Failure to authenticate and load PRs and Issues in GitHub Enterprise

Creating a new issue from https://github.com/microsoft/vscode-pull-request-github/issues/3371#issuecomment-1253800533. I tested GitHub Enterprise support this morning with VSCode Insiders and still was not able to sign in with GitHub Enterprise.
Background info:

Extension version: v0.51.2022092110
VSCode Insiders version:  1.72.0-insider (Universal), Commit: 333754f29b719f605904f072b13c054c2231b9bd
GHES version: 3.3.3
OS, Arch: MacOS 12.6, ARM
Settings (host name redacted)"github-enterprise.uri": "https://github.host.com/",
"githubPullRequests.logLevel": "debug",

Steps to Reproduce:

Loaded Insiders. I only see a prompt for GitHub auth flow and not for GitHub Enterprise auth flow.
Go through GitHub auth and login. Cancelling login does not show the GitHub Enterprise auth flow, only a successful login to GitHub does. logout after initial login.
Immediately logging out of GitHub auth or proceeding straight to GitHub Enterprise auth flow seems to make no difference in subsequent steps.
Go through GitHub Enterprise auth flows.

OAuth browser flow fails.
Local server flow fails.
Device activation succeeds.

The extension still fails to properly load PRs and issues

From these steps and the logs below, I noticed some things

VSCode does not understand that I only want to login to GHES. I have to go through the GitHub flow directly first for GitHub Enterprise auth flow to show. This might be the source of the issue?
It looks like the GitHub Enterprise auth tries to load two different sessions, one with and one without workflow scope. The one without workflow scope is found but the one with workflow scope is not found. See full logs below for more details.[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Got 1 verified sessions.
[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Got 0 sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:20:02.419] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email...
[2022-09-21 11:20:02.419] [GitHub Enterprise Authentication] [info] Got 1 sessions for read:user,repo,user:email...

Do I need to manually clear the keychain on the OS somehow? Could prior login attempts be conflicting there?

Additional log details for the authentication extension logs:

Log (GitHub Enterprise Authentication)
[2022-09-21 11:19:19.414] [GitHub Enterprise Authentication] [info] Getting sessions for all scopes...
[2022-09-21 11:19:19.414] [GitHub Enterprise Authentication] [info] Got 0 sessions for ...
[2022-09-21 11:19:24.036] [GitHub Enterprise Authentication] [info] Reading sessions from keychain...
[2022-09-21 11:19:24.041] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:19:24.049] [GitHub Enterprise Authentication] [info] Got stored sessions!
[2022-09-21 11:19:24.049] [GitHub Enterprise Authentication] [info] Got 0 verified sessions.
[2022-09-21 11:19:24.049] [GitHub Enterprise Authentication] [info] Got 0 sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:19:24.052] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email...
[2022-09-21 11:19:24.052] [GitHub Enterprise Authentication] [info] Got 0 sessions for read:user,repo,user:email...
[2022-09-21 11:19:24.053] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:19:24.053] [GitHub Enterprise Authentication] [info] Got 0 sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:19:24.071] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email...
[2022-09-21 11:19:24.071] [GitHub Enterprise Authentication] [info] Got 0 sessions for read:user,repo,user:email...
[2022-09-21 11:19:24.788] [GitHub Enterprise Authentication] [info] Getting sessions for all scopes...
[2022-09-21 11:19:24.788] [GitHub Enterprise Authentication] [info] Got 0 sessions for ...
[2022-09-21 11:19:28.631] [GitHub Enterprise Authentication] [info] Logging in for the following scopes: read:user repo user:email
[2022-09-21 11:19:28.633] [GitHub Enterprise Authentication] [info] Trying without local server... (read:user repo user:email)
[2022-09-21 11:19:34.770] [GitHub Enterprise Authentication] [info] Exchanging code for token...
[2022-09-21 11:19:35.761] [GitHub Enterprise Authentication] [error] GitHubTokenExchangeError: Internal Server Error
	at v.exchangeCodeForToken (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/github-authentication/dist/extension.js:1:716366)
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/github-authentication/dist/extension.js:1:711948
[2022-09-21 11:19:42.690] [GitHub Enterprise Authentication] [info] Trying with local server... (read:user repo user:email)
[2022-09-21 11:19:43.976] [GitHub Enterprise Authentication] [info] Exchanging code for token...
[2022-09-21 11:19:44.993] [GitHub Enterprise Authentication] [error] GitHubTokenExchangeError: Internal Server Error
	at v.exchangeCodeForToken (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/github-authentication/dist/extension.js:1:716366)
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/github-authentication/dist/extension.js:1:713109
[2022-09-21 11:19:47.356] [GitHub Enterprise Authentication] [info] Trying device code flow... (read:user repo user:email)
[2022-09-21 11:20:01.639] [GitHub Enterprise Authentication] [info] Getting user info...
[2022-09-21 11:20:02.306] [GitHub Enterprise Authentication] [info] Got account info!
[2022-09-21 11:20:02.312] [GitHub Enterprise Authentication] [info] Storing 1 sessions...
[2022-09-21 11:20:02.384] [GitHub Enterprise Authentication] [info] Reading sessions from keychain...
[2022-09-21 11:20:02.384] [GitHub Enterprise Authentication] [info] Stored 1 sessions!
[2022-09-21 11:20:02.384] [GitHub Enterprise Authentication] [info] Login success!
[2022-09-21 11:20:02.416] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Token acquired from secret storage.
[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Got stored sessions!
[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Read the following session from the keychain with the following scopes: read:user repo user:email
[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Got 1 verified sessions.
[2022-09-21 11:20:02.418] [GitHub Enterprise Authentication] [info] Got 0 sessions for read:user,repo,user:email,workflow...
[2022-09-21 11:20:02.419] [GitHub Enterprise Authentication] [info] Getting sessions for read:user,repo,user:email...
[2022-09-21 11:20:02.419] [GitHub Enterprise Authentication] [info] Got 1 sessions for read:user,repo,user:email...

GitHub Pull Request
[Debug<PHONE_NUMBER>.476s] RateLimit> API call count: 17 (/user)
[Debug<PHONE_NUMBER>.481s] RateLimit> API call count: 18 (/user)
[Debug<PHONE_NUMBER>.901s] RateLimit> Rate limit remaining: 4982
[Debug<PHONE_NUMBER>.906s] RateLimit> API call count: 19 (/user)
[Debug<PHONE_NUMBER>.04s] RateLimit> Rate limit remaining: 4981
[Debug<PHONE_NUMBER>.04s] RateLimit> API call count: 18 (/user)
[Debug<PHONE_NUMBER>.227s] RateLimit> Rate limit remaining: 4980
[Debug<PHONE_NUMBER>.229s] No remotes found. The following remotes are missing: origin, upstream
[Debug<PHONE_NUMBER>.229s] FolderRepositoryManager> Displaying configured remotes: origin, upstream
[Debug<PHONE_NUMBER>.23s] No GitHub remotes found
[Debug<PHONE_NUMBER>.24s] Authentication> No GitHub Enterprise token found.
[Debug<PHONE_NUMBER>.24s] Review> Queuing additional validate state
[Debug<PHONE_NUMBER>.24s] Review> Validating state...
[Debug<PHONE_NUMBER>.241s] No remotes found. The following remotes are missing: origin, upstream
[Debug<PHONE_NUMBER>.241s] FolderRepositoryManager> Displaying configured remotes: origin, upstream
[Debug<PHONE_NUMBER>.271s] No GitHub remotes found
[Debug<PHONE_NUMBER>.315s] Review> no matching pull request metadata found for current branch <branch>
[Debug<PHONE_NUMBER>.315s] Review> no matching pull request metadata found on GitHub for current branch <branch>
[Debug<PHONE_NUMBER>.315s] PullRequestTree> Removing PR #undefined from tree
[Debug<PHONE_NUMBER>.353s] RateLimit> Rate limit remaining: 4979
[Debug<PHONE_NUMBER>.353s] No remotes found. The following remotes are missing: origin, upstream
[Debug<PHONE_NUMBER>.353s] FolderRepositoryManager> Displaying configured remotes: origin, upstream
[Debug<PHONE_NUMBER>.353s] No GitHub remotes found
[Debug<PHONE_NUMBER>.682s] RateLimit> API call count: 19 (/user)
[Debug<PHONE_NUMBER>.116s] RateLimit> Rate limit remaining: 179986
[Debug<PHONE_NUMBER>.12s] RateLimit> API call count: 20 (/user)
[Debug<PHONE_NUMBER>.61s] RateLimit> Rate limit remaining: 179985
[Debug<PHONE_NUMBER>.627s] No remotes found. The following remotes are missing: origin, upstream
[Debug<PHONE_NUMBER>.627s] FolderRepositoryManager> Displaying configured remotes: origin, upstream
[Debug<PHONE_NUMBER>.637s] No GitHub remotes found

Looking at the log output, I'm guessing this is the issue:
Trying device code flow... (read:user repo user:email)

It looks like the device code flow is missing the workflow scope, and the other two auth flows don't work with my GHES instance.

Sorry for the delay in responding to this!

I have to go through the GitHub flow directly first for GitHub Enterprise auth flow to show.

You might need to wait 5 seconds before signing in, but you should get taken directly to the GitHub Enterprise auth flow. The delay comes from this extension waiting for the git extension to provide some information. I'll see if I can wait to show the button until we've reached that point. We were also falling back to a github.com login in the enterprise login didn't work. I'm removing that fallback when we are very sure that the open repo is enterprise.

Actually, it looks like all auth flows are trying to login without workflow scope. Not sure if that is intended or not.

We updated our scopes to include workflow 5 months ago. To make it easier on our users, we continue to accept logins that were missing workflow. For this reason you will see some logs that don't contain the workflow scope. You should never actually be prompted to log in without the workflow scope though, which leads me to:

The extension still fails to properly load PRs and issues

I haven't been able to reproduce this issue. Are you using an official VS Code build? There are quirks in auth for unofficial builds, so knowing whether you're using an official build will help narrow down the issue.

You might need to wait 5 seconds before signing in, but you should get taken directly to the GitHub Enterprise auth flow. The delay comes from this extension waiting for the git extension to provide some information.

I never see get the auth flow for GHES at all, regardless of wait time. It just never seems to trigger unless first going through GitHub auth flow.

We updated our scopes to include workflow 5 months ago. To make it easier on our users, we continue to accept logins that were missing workflow. For this reason you will see some logs that don't contain the workflow scope. You should never actually be prompted to log in without the workflow scope though

:+1:

I haven't been able to reproduce this issue. Are you using an official VS Code build? There are quirks in auth for unofficial builds, so knowing whether you're using an official build will help narrow down the issue.

I'm testing with the official VSCode pre release version as you suggested in some of the other GHES issues. Hope that helps!

I can also try a fresh nightly install and retrying if that might help?
There do seem to be issues authenticating with the first two options for the GHES flow. Not sure if that's specific to our GHES instance, the version we're running, or something else.

At the bottom of the activity bar (by default the bottom left corner of VS Code) there's an "Accounts" icon. Can you try signing out of your GitHub Enterprise account from there, reload the window, then sign back in using the "Sign in" button in GitHub view?

Can you try signing out of your GitHub Enterprise account from there, reload the window, then sign back in using the "Sign in" button in GitHub view?

Just tried that. It still defaults to logging into GitHub from the GitHub view "Sign in" button. Signing in to github.com... and opens a github.com link in the browser. GitHub Enterprise authentication never triggers.

Same results on the latest version of Insiders (Version: 1.72.0-insider (Universal) Commit: bcb6c9b7e0e795bdf65ea440025d204060e4bfc8)

One more question about your setup then: Do you have a folder open in VS Code that contains a git repo with GitHub Enterprise remotes?
Can you grab logs by doing the following:

Set "githubPullRequests.logLevel": "debug"
Reload your window
Try to log in
Share the output from GitHub Pull Requests

I updated to the latest Insider's version just now (1.72.0-insider (Universal) Commit: 9fb452c4852ef098206ec67a2b236ad5fd0ba828) and I no longer see a prompt to login to GitHub or GitHub Enterprise at all

Thanks for all the logs. This seems to be the important line, which indicates that your git remote doesn't appear to be a GitHub remote:
[Debug<PHONE_NUMBER>.41s] GitHubServer> Host https://github.host.com/org/repo is associated with GitHub: 0

In the extension, we make a request to your host then check to see if the headers in the response include x-github-request-id. This is how we tell if the git remote is actually a GitHub (enterprise or not) remote.
It looks like your enterprise server isn't responding with that header. I don't know why that might be the case. I've tested with GitHub Enterprise 3.3, and the expected headers are in the response there. If you're ok with emailing me the URL of your enterprise host, then please do and use the email in my profile. In parallel, I will add some logging for these headers so I can see if there's some other header that I should be looking for (these logging changes won't make it into the pre-release build for a few more days as we are stabilizing for release).

If you're ok with emailing me the URL of your enterprise host, then please do and use the email in my profile. In parallel, I will add some logging for these headers so I can see if there's some other header that I should be looking for (these logging changes won't make it into the pre-release build for a few more days as we are stabilizing for release, which is why I'm also asking for the email if possible).

That would be great. I'm working with our GHES team to get some additional details as well 🤞🏻

From those additional logs I can see that x-github-request-id is not included in the headers, which explains why the GitHub Enterprise flow never triggers. If I'm able to trigger it manually (given the above hacky steps), is x-github-request-id on the headers still needed for the extension to work with GHES?
Additional debug logs on the OAuth errors when authenticating might help as well, though I'm not 100% sure what additional info could be logged from the GHES error response.

@wrslatz can you share the headers that are in the response? I added the check for x-github-request-id since it seemed like a safe way to know if the server is a GitHub server, but it's possible that was a bad assumption. If that's the case, then I'll need to add a way for you to get to the enterprise auth.

@wrslatz I added a fallback detection for GitHub servers. The latest pre-release build has the change. Could you please let me know if it works for you?

@wrslatz I added a fallback detection for GitHub servers. The latest pre-release build has the change. Could you please let me know if it works for you?

@alexr00 I just tested with pre-release version v0.53.2022101119 and see the same results. Login initially moves me through the public GitHub flow and I can only access the GitHub Enterprise flow after that.
The GitHub Enterprise login also still does not work once I move all the way through the flow (not sure if that is something on our GitHub Enterprise side or not). The first two methods still fail with an Internal Server Error (not sure if there's anything additional we can log there that would be helpful).

Can you paste the following in a browser URL bar, hit enter, and share what it returns?
https://your.githubenterprise.host/status

Example with GitHub.com:

Can you paste the following in a browser URL bar, hit enter, and share what it returns?

GitHub lives! (2022-10-11 22:51:38 +0000) (1)

Thanks for your patience and help with this @wrslatz. I think I found the problem. I'll let you know it's available in a pre-release build (should be tomorrow).

Tested this morning and I see an additional log message right after the headers logging that may be helpful
[Debug<PHONE_NUMBER>.872s] GitHubServer> No response from host https://github.host.com/org/repo: Unexpected token < in JSON at position 0

Ok, seems like there's still some difference between what the server I'm testing with and the one that you're using returns. I assumed that they'd return the same unauthenticated response, but it seems that yours doesn't return a json response. I'm adding logging for the server response so we can see what your server is returning.

Looks like that response does show an auth issue
GitHubServer> Received fallback response from the server:
401 Unauthorized

You need a valid user and password to access this content.

Thanks for sticking with this @wrslatz. It seems that your GitHub Enterprise server isn't providing any information at all that we can use to know that it's actually GitHub Enterprise. I'll need to add a separate "Sign in with GitHub Enterprise" button since it seems that there are cases where the Enterprise server is simply not configured to respond in a known way.

Thanks for sticking with this @wrslatz.

No sweat, thanks for the really helpful and quick support and testing here!

It seems that your GitHub Enterprise server isn't providing any information at all that we can use to know that it's actually GitHub Enterprise. I'll need to add a separate "Sign in with GitHub Enterprise" button since it seems that there are cases where the Enterprise server is simply not configured to respond in a known way.

I wish I could get more info about our Enterprise setup so I could pass it along. Hopefully that'll change in the future.
I'll be happy to test any additional changes here 👍🏻

New behavior: If we can't tell that the remote is github.com or GitHub Enterprise there will be a "Sign in with GitHub Enterprise" button in the GitHub view. If you choose that then we'll try to help you set up GitHub Enterprise. Sixth time's the charm 😅.
The change is available in the latest pre-release version of the extension with VS Code insiders.

It's working! On latest insiders with pre-release extension version the Sign In button correctly logs me in with GitHub Enterprise to start instead of public GitHub. From there, the third login option (device login) works. After logging in, I now see issues and PRs populating! 🚀
Thank you @alexr00 🎉 for continuing to help when I didn't have much debug info to provide.
I believe the first two auth options fail because of issues with our GitHub Enterprise setup. I'm happy to open a separate issue if you'd like to keep track of that as a potential separate issue.

Thanks for verifying that the issue is fixed!
If you feel confident the first two auth options fail because of issues with your Enterprise setup, then I don't think we need to create an issue for that. If you think that those two options should be working, then yes, please do file an issue!


Utility Network Trace - "The input feature does not belong to this utility network."

When using the Utility Network Trace sample, I'm seeing the following error logged to the console:
error occurred: code: 2
error message: Invalid argument.
error additional message: The input feature does not belong to this utility network.

Steps to reproduce:

Open the Utility Network Trace example
Select Connected as the trace configuration
Tap/click Add New to add a starting point
Tap/click on a feature

Hi @philium, for step 4, do you recall which feature you tapped on? I've tried a few and haven't gotten this messaging in the console.

Here you go:
https://user-images.githubusercontent.com/2257493/208531814-92d90b14-f795-4496-8e60-3eacf233ac9b.mov
There's also another error about "geometries must not be empty" when tapping Trace.

The error seems to be coming out of core when calling UtilityNetwork.makeElement(arcGISFeature:terminal:). I can reproduce the error when attempting to make an element with a feature with a subtype name of "Medium Voltage Radial". I don't see an obvious way to predetermine if a feature belongs to a utility network so I've checked with the team.

There's also another error about "geometries must not be empty" when tapping Trace.

I'll be investigating this under #233 as it appears to be a separate issue.

@philium As Ryan suggested in the linked thread, I experimented with using a withErrorHandler. That works and stops this from being logged but of course that may end up stopping other helpful messages. Do you have an opinion on whether we should proceed and stop the logging or close this without change? My thinking is that it's a valid error and we should continue to log it.

Can you create an issue in our internal Swift API repo to discuss that?

Ref Swift #3246

Behavior may change as a result of Swift 3714

Closing; as of Swift 3714 the error is discarded and no longer logged.


ESP32C3 Version

Is your feature request related to a problem? Please describe.
I tried to change the version to ESP32C3 but couldn't manage to get anything but errors
Describe the solution you'd like
Could you please upload a compiled version for the ESP32C3?

Hi. @Soforak
Currently i don't have suitable environment setup to build, please share error log may I can help if anything to possible.
Surely i will share you firmware files as soon as possible.

Hi @Soforak, can you please test the firmware and provide me with an update? Thanks!
esp32C3.zip


Add taplo pre-commit hook to format and sort toml files

ref https://github.com/pyvista/pyvista/pull/6781

pre-commit.ci autofix

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.09%. Comparing base (46147e2) to head (d8410b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   43.09%   43.09%
=======================================
  Files          11       11
  Lines         478      478
=======================================
  Hits          206      206
  Misses        272      272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


IP masquerade & traffic destined outside of overlay network

I have been using Flannel with Docker in our cluster. I enabled IP masquerade in my Flannel network in the hopes that all outbound traffic will see the host IP address and not the container IP address, but I still see my container IPs (private subnet) in the Firewall!! The Firewall rejects this traffic - I see this in the logs " access-list FLANNEL-IN denied tcp FLANNEL/<IP_ADDRESS>(34520)". This happens intermittently
Expected Behavior
I was hoping the ip-masq flag will masquerade all container IPs and replace with the host IPs, is my understanding correct?
Current Behavior
Intermittent ip-address "leak".
Context
Firewall rejects traffic..
Your Environment

Flannel version: v0.11.0
Backend used (e.g. vxlan or udp): vlan
Etcd version: 3.3.11
Docker version: 18.09.3
Operating System and version: Ubuntu 16.04.6 LTS

Having similar on-prem issue where packets don't return to containers from public internet, but local LAN routing works fine.  --ip-masq is enabled in flannel daemonset.
Issue is intermittent and not reproduceable so difficult to troubleshoot.


doc:  create schemas to separate routes by tags and comment on routes to explain their function

In this PR, I added Swagger documentation to Fastify routes, including schemas with tags and descriptions. This makes the API more user-friendly and easier to maintain for developers. I didn't include request body details in the routes because it would require extensive typing in Zod, causing significant extra work.
Some examples of the documentation:

I can only accept this pr as a two- or more-part series. I do understand that typing the response would add more work. But that's where the gain is. Now we have tags on routes, which is fine. But how do I pass it on to others so they can integrate with us? They don't know what to expect from the payload.
Can i count on you for the next prs @victorlourenco-vhl ? They can be sent on smaller and more concise ones'

I can only accept this pr as a two- or more-part series. I do understand that typing the response would add more work. But that's where the gain is. Now we have tags on routes, which is fine. But how do I pass it on to others so they can integrate with us? They don't know what to expect from the payload.
Can i count on you for the next prs @victorlourenco-vhl ? They can be sent on smaller and more concise ones'

Yes, now I will close the PR

I can only accept this pr as a two- or more-part series. I do understand that typing the response would add more work. But that's where the gain is. Now we have tags on routes, which is fine. But how do I pass it on to others so they can integrate with us? They don't know what to expect from the payload.
Can i count on you for the next prs @victorlourenco-vhl ? They can be sent on smaller and more concise ones'

I agree with @Joabesv perspective!

I think that a good way to start, more easily, will be working on the insominia collection. If you get each of routes and send a request for it, you will be able to copy the parameters of the response, so the swagger is going to be complete.
@victorlourenco-vhl


Update README.md

Hi Guang Li,
It would be great if you could include our dataset distillation challenge in the awsome DD Github. It's an effective advertising tool.
Best,
Ahmad

I was planning to wait until the website went public before including it in the project, but adding it now is not bad. Thanks for the reminder.

Sorry, not see the website.


ZeRO strategy script for Semantic Segmentation Training

Thank you for open-sourcing this brilliant and outstanding project. However, with a model size of 6 billion parameters, it is still infeasible to train on consumer-grade graphics cards without using memory optimization tools like DeepSpeed. Could you provide a semantic segmentation training script based on mmsegmentation and the ZeRO strategy in the future? Looking forward to your reply.

Hello, we do indeed have an internal version of mmsegmentation that supports deepspeed (an older version of mmsegmentation, v0.25.0), but we have made significant changes to the mmcv code, which may be difficult to maintain in the future. We plan to investigate whether there is a more elegant way to support deepspeed, such as upgrading to the latest version of mmsegmentation (v1.x) and using mmgine.

Hello, we do indeed have an internal version of mmsegmentation that supports deepspeed (an older version of mmsegmentation, v0.25.0), but we have made significant changes to the mmcv code, which may be difficult to maintain in the future. We plan to investigate whether there is a more elegant way to support deepspeed, such as upgrading to the latest version of mmsegmentation (v1.x) and using mmgine.

Thank you for your response. I was wondering if it might be possible for you to first open-source this part of the custom code so that we can explore training with DeepSpeed. We look forward to your more elegant usage method with mmsegmentation in the future. Thank you very much.

Hello, we do indeed have an internal version of mmsegmentation that supports deepspeed (an older version of mmsegmentation, v0.25.0), but we have made significant changes to the mmcv code, which may be difficult to maintain in the future. We plan to investigate whether there is a more elegant way to support deepspeed, such as upgrading to the latest version of mmsegmentation (v1.x) and using mmgine.

Thank you for your response. I was wondering if it might be possible for you to first open-source this part of the custom code so that we can explore training with DeepSpeed. We look forward to your more elegant usage method with mmsegmentation in the future. Thank you very much.

Of course, it's possible, but I need some time to organize the code. It's worth noting that there seems to be compatibility issues with PyTorch 2, so you'll need to set up an additional environment with PyTorch 1.12.

Hello, we do indeed have an internal version of mmsegmentation that supports deepspeed (an older version of mmsegmentation, v0.25.0), but we have made significant changes to the mmcv code, which may be difficult to maintain in the future. We plan to investigate whether there is a more elegant way to support deepspeed, such as upgrading to the latest version of mmsegmentation (v1.x) and using mmgine.

Thank you for your response. I was wondering if it might be possible for you to first open-source this part of the custom code so that we can explore training with DeepSpeed. We look forward to your more elegant usage method with mmsegmentation in the future. Thank you very much.

Of course, it's possible, but I need some time to organize the code. It's worth noting that there seems to be compatibility issues with PyTorch 2, so you'll need to set up an additional environment with PyTorch 1.12.

That's great, thank you for your open-source spirit. I am really looking forward to the subsequent updates, and also, thank you for the reminder about the environment setup.

I open this issue as a todo to remind me not to forget about this.

I open this issue as a todo to remind me not to forget about this.
Okay, I am very much looking forward to your update. Thank you once again!

May I ask if there has been any progress? Looking forward to your reply.

May I ask if there has been any progress? Looking forward to your reply.

I'm sorry that I have a lot of trivial things to do recently. I will release this code as soon as possible, probably within this week.

May I ask if there has been any progress? Looking forward to your reply.

I'm sorry that I have a lot of trivial things to do recently. I will release this code as soon as possible, probably within this week.

Okay, I look forward to your update and express my highest respect.

Sorry to keep you waiting, I have posted the code at: https://github.com/OpenGVLab/InternVL-DeepSpeed. However, I haven't had time to write a README yet. I will update with the README tomorrow.

Sorry to keep you waiting, I have posted the code at: https://github.com/OpenGVLab/InternVL-DeepSpeed. However, I haven't written a README for it yet. I will update with the README tomorrow.

Great! Thanks a lot!

@wyyhit README has been updated, if you encounter any problems in use, please feel free to contact me.

@wyyhit README has been updated, if you encounter any problems in use, please feel free to contact me.

Sure, I am planning to try training in the next couple of days. I'll ask for your advice if needed.

I have decided to close this issue. If you encounter any problems, feel free to ask me in the InternVL-MMDetSeg repository.


--puppetfile option ignored in latest version

The --puppetfile option stopped working in the latest version.  On examination onceover always reads the file Puppetflie no matter what is specified.  This is a problem if you need to use a difference file for testing, eg to add mock fixtures or reference git/forge servers differently

Fixed in v3.2.7


Fix response code for existing att and wrong rev

Overview
https://github.com/apache/couchdb/pull/3673 created a bug where trying to delete an existing attachment using the wrong rev would return a 404. This PR changes the response code to be a 409 as intended.
Testing recommendations
Assuming you have a database test and doc 25 and att recipe.txt,
Deletion of existing attachment using incorrect rev:
% curl -X DELETE 'http://localhost:15984/test/25/recipe.txt?rev=4-garbage' -H 'Authorization: Basic YWRtOnBhc3M='
{"error":"not_found","reason":"missing_rev"}

409 error in this case.
Deletion of non-existing attachment using correct rev:
% curl -X DELETE 'http://localhost:15984/test/notexisting.txt?rev=2-e6eeb3fa3da4088ff5dac56b7c34a732' -H 'Authorization: Basic YWRtOnBhc3M='
{"error":"not_found","reason":"Document is missing attachment"}

404 error in this case.
Related Issues or Pull Requests
404 at deletion of an existing attachment when using wrong rev: https://github.com/apache/couchdb/issues/3684
Fix response code for nonexistent attachment: https://github.com/apache/couchdb/pull/3673
Checklist

[x] Code is written and works correctly
[x] Changes are covered by tests
[x] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

I think we're still missing another corner case when we delete a document without a rev:
$ http delete $DB/db/doc/att1
HTTP/1.1 404 Object Not Found

{
    "error": "not_found",
    "reason": "Document is missing attachment"
}

We'd expect a 409 here but we get a 404.
We will probably have to check for the attachment existence in this part:
Doc = case extract_header_rev(Req, chttpd:qs_value(Req, "rev")) of
        missing_rev -> % make the new doc
            if Method =/= 'DELETE' -> ok; true ->
                % check doc and attachment
                couch_doc_open(Db, DocId, nil, [])

and in
       Rev ->
            case fabric:open_revs(Db, DocId, [Rev], [{user_ctx,Ctx}]) of
            {ok, [{ok, Doc0}]} ->
                chttpd_stats:incr_reads(),
                % check for existence of attachment....
                Doc0;

And if those pass just let it fall through to the fabric:update_doc/3 and blow up with a 409

Thanks for the fixup. I improved it a bit with another edge case here https://github.com/apache/couchdb/pull/3686


Add uftm.txt

Federal University of Triângulo Mineiro added.

ogr.txt

@felpshn I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host uftm.br not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!


Use single line use statements

The

use <...>::{XXX, YYY, ZZZ}

style for use statements is causing merge conflicts all over the place, making it extremely cumbersome to have multiple pull requests in flight. Switch to a different style that is less prone to such issues.

Going ahead and merging this mechanical change to unblock follow on work.


How to develop a new Connector？

Discussed in https://github.com/apache/incubator-seatunnel/discussions/4723

Originally posted by YuanjunXu May  9, 2023
I want to develop a new Connector.
What should I do or what interfaces should I implement？

You can see https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-connectors-v2/README.zh.md

thx


iOS 13 not work

WVJBNoHandlerException, No handler for message from JS

same problem ，any help?  Thx.

same problem ，any help? Thx.

This library is no problem, it should be a problem with the plugin initialization, please check carefully


Command line is too long

Android Studio version: 4.0.1 (based probably on Intellij 2019.3.3)
kotest version: 4.2.3
kotest plugin version: 1.1.16-IC-2019.3
Then I try to run any test in my main bigger project, I'm getting the error:

I've tried doing same thing on newly created project and it's working as expected.
Maybe adding "shorten command line" option to Kotest run configuration will solve this issue?

Can you show me the command line? I wonder if your classpath is huge.
If you need to obfuscate you can.
On Mon, 7 Sep 2020 at 11:33, Rafal<EMAIL_ADDRESS>wrote:

Android Studio version: 4.0.1 (based probably on Intellij 2019.3.3)
kotest version: 4.2.3
kotest plugin version: 1.1.16-IC-2019.3
Then I try to run any test in my main bigger project, I'm getting the
error:
[image: obraz]
https://user-images.githubusercontent.com/6077897/92406131-854af980-f137-11ea-8c62-c52da7330c30.png
I've tried doing same thing on newly created project and it's working as
expected.
Maybe adding "shorten command line" option to Kotest run configuration
will solve this issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kotest/kotest-intellij-plugin/issues/94, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFVSGRBII3QIC7QPVPXEUTSEUDMJANCNFSM4Q6R4GJQ
.

It's not showing any output in run window. I've tried to google where to view it, but no luck.
Could you tell me where I can find it?

Does it work if you choose the shorten option?
On Mon, 7 Sep 2020, 12:18 Rafal<EMAIL_ADDRESS>wrote:

It's not showing any output in run window. I've tried to google where to
view it, but no luck.
Could you tell me where I can find it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kotest/kotest-intellij-plugin/issues/94#issuecomment-688444436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFVSGSOZRITG7DHNC33AY3SEUIURANCNFSM4Q6R4GJQ
.

This option is not available for me for Kotest (but it is for JUnit).

I have a build that fixes this if you want to test it locally ?
kotest-plugin-intellij-1.1.0-SNAPSHOT-IC-2020.1.zip
You would need to remove your existing plugin first and restart and install this one manually from the settings -> plugins -> cog icon.

Thank you for quick, new build.
Unfortunately, I cannot install it. The message is "Plugin 'kotest' is incompatible with this installation".
I'm using Android Studio version 4.0.1. When I click Help -> IntelliJ IDEA Help, it redirects me to https://www.jetbrains.com/help/idea/2019.2/installation-guide.html, so I assume it's based on IntelliJ 2019.2.
Would it be possible to prepare plugin compatible with this version?

Uploading kotest-plugin-intellij-1.1.0-SNAPSHOT-IC-2019.3.zip…
Try this

Unfortunately, the link is wrong. Could you paste new one?

kotest-plugin-intellij-1.1.0-SNAPSHOT-IC-2019.3.zip
Strange, try this one.

I was able to test it today and it's working with both "JAR Manifest" and "classpath file". Thank you! 👍

Great, I'll cut an official release this weekend.

Fixed in the version that's pending release.


incorrect usage of num_gpus & num_workers in mnist_replica.py

mnist_replica.py has the following code.
 if FLAGS.num_gpus < num_workers:
    raise ValueError("number of gpus is less than number of workers")

This will work fine in a single worker setup with one or more GPUs. However, it will throw error if the number of workers is greater than the number of GPUs available in each worker. For example, using 2 workers each with 1 GPU will trigger this error.
It looks like this if-block can be removed. If that is an acceptable change, I can send a PR for that.

What would the extra worker use for compute?

I am not sure what you mean by "extra worker". I am assuming that I can use any number of workers to run this example. I tried running it with 2 workers each with 1 GPU and got this error. Is that not a valid setup to run mnist_replica.py?

I'm not familiar with this code, but I'm assuming that check is because it's inefficient to use more workers than GPUs, because each worker uses one GPU for compute.  Each worker does some compute, and in GPU mode this compute takes place on a GPU.

In my case, I would like to use 2 GPU. However the workers I have in Cloud have only 1 GPU each. So, I had to use 2 workers to employ 2 GPUs for my job. I understand that getting a bigger VM with more GPU is more efficient and would not result in this error but the configuration I am using sounds like a valid one and I find this error unnecessarily restrictive.

@skaarthik Ah, sorry for my confusion.  @mrry Does this check look wrong to you?  I tried finding who added it in the history, but failed.

It looks wrong to me, but I think it might have a weird sense where it's used for multi-GPU in a single machine, but not multi-machine multi-GPU. @caisq wrote that code, so he can confirm.

Sorry this fell through the cracks.  If you're still interested, @skaarthik, we'd be happy to accept a PR.

Great. I will send a PR.

Now that the PR is merged, can I close this issue?


Update network-plugins.md

change docker to Docker

NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

This change is

This is a duplicate of #7191, so closing it - see the comments there, as Docker in this case isn’t a proper now and doesn’t need to be capitalized, although I do appreicate the review and thoughtfulness.
/assign


Override material instance parameters

Is there anyway to do with the current python binding?
I would like to do something like this:
myMaterialInstance.OverrideScalarParameterDefault("UseThisColor", 1.0, True)
Cheers,
Eric

As UMaterialInstanceConstant doesn't change parameters at Runtime, I have to wrap the following functions in my own UEPyMaterialInstance.h/.cpp
SetScalarParameterValueEditorOnly();
SetVectorParameterValueEditorOnly();
SetTextureParameterValueEditorOnly();
SetParentEditorOnly();
PostEditChange();

@rdeioris, what is the contribution policy here? Possible to push my changes to a dev branch?

Yes, the material interface is not exposed to the reflection system (except for very few cases).
I think a UEPyMaterial.c/.cpp api would be a better naming choise, so we can expose all of the material related features (starting from here: https://docs.unrealengine.com/latest/INT/API/Runtime/Engine/Materials/UMaterialInterface/index.html)
Regarding contribution, simply make a pull request for the master branch (add your credits into the CONTRIBUTORS file)
Regarding
SetParentEditorOnly();
PostEditChange();

combine them in a single function as PostEditChange() is mandatory.

Ok, I can call PostEditChange() right after SetParentEditorOnly(). The following functions require to call PostEditChange to populate the changes down the chain as well.
SetScalarParameterValueEditorOnly();
SetVectorParameterValueEditorOnly();
SetTextureParameterValueEditorOnly();

As you may want to set multiple parameters without triggering post edit change event for performance reason,  PostEditChange() could be exposed separately.

Ok, at this point i think it is better to expose PostEditChange as a generic UObject method and follow the C++ pattern by calling it manually.

I didn't realized that PostEditChange is UObject method. Good call.

Remember to make a pull request when your code is usable :) Thanks


Some path based icons do not seem to load correctly

For example see this material design "cut" icon, one of the scissor handles is not in the right place. I attach the file here for reference. To load it in oksvg you will need to apply #5 as it uses compressed float number format.
cut.zip

I have found that the cause is relative move.
If you open the example above and change the two "m" to "M" and load it you see the exact output that oksvg is creating...


Are there any examples?

How to use this plugin?

Unfortunately the process is pretty in-depth because the Gradle native plugins themselves are not very fleshed out.
Adding Gradle to an existing CMake project
If you just want to "gradleify" a cmake project to make it available to use for Gradle projects, the process isn't too complicated. You'll want to create a gradle.build file in the root of your cmake project. Start it with
plugins {
	id "me.walkerknapp.use-cmake-library"
}

cmake.targetMachines.set([
			machines.windows.x86, machines.windows.x86_64,
			machines.macOS.x86_64,
			machines.linux.x86, machines.linux.x86_64,
			machines.os("android").architecture("armv7a"),
			machines.os("android").architecture("arm64-v8a"),
			machines.os("android").x86,
			machines.os("android").x86_64])

This will import the plugin and give it a list of machines to target. By default, Gradle will only be able to compile for one target, which can be fine, but to specify additional compilers, I usually add:
apply {
    from('toolchains.gradle.kts')
}

and then make a file like https://github.com/WalkerKnapp/rapidopus/blob/main/toolchains.gradle.kts detailing various compliers to use.
Also to note, part of Gradle's underdeveloped native plugins is a lack of cross-compilation. There has been a PR sitting for more than 2 years that solves this (gradle/gradle#10024), but until it looked at again, I use a Gradle fork that has these changes merged: https://github.com/WalkerKnapp/gradle/releases/tag/v7.2cc. You can use it by running:
gradlew wrapper --gradle-distribution-url=https://github.com/WalkerKnapp/gradle/releases/download/v7.2cc/gradle-7.2-bin.zip

After you have your Gradle project set up, you can depend on it from Gradle native applications, build it with Gradle, etc.
Injecting Gradle into a CMake-Based Source Dependency
An entire project that uses this plugin more practically is https://github.com/WalkerKnapp/rapidopus, but this is a little bit more complicated than needed because instead of just "gradleifying" an existing cmake project, it injects this plugin into a source dependency (a cmake project downloaded from GitHub on the fly).
The gist of the process is that you first make a plugin that can be injected into a source dependency: https://github.com/WalkerKnapp/rapidopus/tree/main/plugins (This is the part that relies on this project)
Next you create a source dependency on the repository that hosts the cmake library you want to use. You can inject the plugin you previously made into this dependency. https://github.com/WalkerKnapp/rapidopus/blob/main/settings.gradle
Then you can depend on the cmake project from the source dependency like a normal gradle dependency: https://github.com/WalkerKnapp/rapidopus/blob/93148b402f628a03a5912b514e6f21a0e74fadfa/rapidopus-natives/build.gradle.kts#L80

Thanks


🚧Create status check for preview labeling

I have done the items below . . .

[X] I have updated the title by replacing the '<title>' section.

Description
Create a status check workflow that checks to make sure that the PR is labeled with the preview label.
Acceptance Criteria
This issue is finished when:

[ ] Workflow runs
[ ] Workflow only runs for release/ branches which are for preview

ToDo Items

[ ] Draft pull request created and linked to this issue
[X] Priority label added to issue (low priority, medium priority, or high priority)

Issue Dependencies
No response
Related Work
No response

I would love to handle this. I would appreciate a pointer though. Thanks.

Sure thing.
If you look at the Velaptor workflows, you can use these as a guide/reference to help you out on workflow related stuff.
To make sure that it is only for a release branch, you just have to setup the workflow to run for pull request events only and against a release branch using this below.
on:
  workflow_dispatch:
  pull_request:
    types: [ synchronize ]
    branches: [
      release/v*.*.*
    ]

The workflow_dispatch in the YAML sets the workflow up to be able to ran manually. I like having this on my workflows to be able to execute them manually for troubleshooting purposes or for simple verification.
As for checking if a pull request does or does not have certain labels, you this github action


Is ErrorInterceptor Working

Hello, I was trying to use this library but I had a problem using addErrorInterceptor. Error Interceptor is correctly working? I see the tests and I notices that test of ErrorInterceptor was comented...please let me know if I should use it or will be available soon?

AddErrorInterceptor should work properly so if you had problem could you send me more information about  it


Ensure only one ddu-ff-filter buffer are created.

fix: #91

Thanks.  But my fix is better.
The initialization should not be skipped.


Intermittent test failures in Azure DevOps build pipeline

After converting all of the tests in the UnitTests.SubText assembly from MbUnit to MSTest (and switching from SQL Server Express to LocalDB), the tests consistently pass in various local environments but sometimes fail when executed on hosted agents in Azure DevOps.
For example, the following two tests failed after merging the changes into the master branch:

GetEntriesByTagDoesNotIncludeFuturePosts
GetPostsByDayRangeDoesNotIncludeFuturePosts

In both of these tests, the expected number of entries is returned:
Assert.AreEqual(2, entries.Count, "Expected to find two entries.");
However, subsequent test assertions fail due to either the first or second result not matching the expected item:
Assert.AreEqual(entries.First().Id, entryOne.Id, "Ordering is off.");
Assert.AreEqual(entries.ElementAt(1).Id, entryZero.Id, "Ordering is off.");

Since the message parameter is the same for the two assertions, it is unclear which line is actually failing.
Also note that the stack traces shown in Azure DevOps only contain minimal information (i.e. no line numbers). For example:
at UnitTests.Subtext.Framework.Components.EntryTests.FutureEntriesGetTests.GetEntriesByTagDoesNotIncludeFuturePosts()
It is believed these test failures are due to the Collect advanced diagnostics in case of catastrophic failures option on the Visual Studio Test task in the build pipeline. Disabling that option initially resulted in all of the tests passing (build 6625). However, the subsequent CI build on the master branch failed (build 6626).

The root cause appears to be a timing issue...specifically due to the following code blocks:
UnitTestHelper.Create(entryZero);
UnitTestHelper.Create(entryOne);

Depending upon the speed at which this code is executed, it may result in the two entries having the same value in subtext_Content.DatePublishedUtc (which means the order in which the data is subsequently returned when querying the database will be ambiguous).


Issue with Spring Cloud Function

Hi All,
I found this issue during the repackaging of my native app.
My environment is:

jdk17
maven 3.8.6
graalVM 17

My Spring Boot project is

maven/java
spring boot version 2.7.5
java 17
dependencies:

Spring reactive web
Function
GraalVM Native Support

If I launch the command
mvn -Pnative package
I get this error during che analysis phase:
ERROR io.netty.handler.ssl.BouncyCastleAlpnSslUtils - Unable to initialize BouncyCastleAlpnSslUtils.
java.lang.ClassNotFoundException: org.bouncycastle.jsse.BCSSLEngine

My app is not able to be packaged and published. The error is generated by the Spring Cloud Function dependency.
I tried:

exclude netty and put jetty;
change JDK/GraalVM version;
go back to previus version of spring boot/cloud.
with no success.

Is this a bug, or am I doing something wrong?
Thanks a lot!

As the native support moves on Spring Boot 3 side, please test with Spring Boot 3 snapshots using https://start.spring.io/#!type=gradle-project&language=java&platformVersion=3.0.0-SNAPSHOT&packaging=jar&jvmVersion=17&groupId=com.example&artifactId=demo&name=demo&description=Demo project for Spring Boot&packageName=com.example.demo&dependencies=native,cloud-function by building the native application with mvn -Pnative native:compile, and if it fails create an issue on https://github.com/spring-cloud/spring-cloud-function/issues with a repro.


Version 0.3.0 (Code Freeze)

Friday, I'm tagging v0.3.0 (whether or not it's the same code as v0.2.2 remains to be seen). From that point until sodium_compat is audited, I'm enacting a code freeze, which will end once #8 has moved forward at all.

Please include commit 5ed507e in this tag.

Anything in dev-master will be included in the tag.


sdk$runInlineQuery Filter with multiple options.

I need to be able to run an inline query where I can use a combination of filters.
For example: data <- sdk$runInlineQuery(model = "model_name",
view = "my_awesome_explore",
fields = c("id", "count"),
filters = list("field_name" = "filter_expression",
"another_field" = "filter_expression"),
How would I do something like this:
data <- sdk$runInlineQuery(model = "model_name",
view = "my_awesome_explore",
fields = c("id", "count"),
filters = list("field_name" = "filter_expression1","filter_expression2","filter_expression3")

Hey @dougneedham, thanks for bringing this up. It's not immediately clear to me whether the Looker API accepts duplicate keys for the same field in the filters parameter. Based on what I know, I would expect the following to work:
filters = list("field_name" = "filter_expression1",
                    "field_name" = "filter_expression2")

But this may not be the case based on how the Looker API expects the request and how LookR creates the request. There might be room for improvement on my end here. I'll do some testing and get back to you.
In the meantime, Looker allows you to combine multiple filter expressions into a single filter expression, with different methods for different data types. For example, with string type fields, you can use commas to match either string. FOO,BAR will match either FOO or BAR. For number type fields, you can use the AND and OR keywords. >10 AND <=20 will match numbers 11-20.


Issue with version 0.24.1

When using Swarmion version 0.24.1:
2023-02-10T19:11:12.393Z	undefined	ERROR	Uncaught Exception
{
    "errorType": "Runtime.HandlerNotFound",
    "errorMessage": "index.main is undefined or not exported",
    "stack": [
        "Runtime.HandlerNotFound: index.main is undefined or not exported",
        "    at Object.UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1038:15)",
        "    at async start (file:///var/runtime/index.mjs:1200:23)",
        "    at async file:///var/runtime/index.mjs:1206:1"
    ]
}

I'm trying to pinpoint the issue in this release...
We definitely need to add integration tests for our packages on actual AWS environment 🙄

Ok so apparently it comes from https://github.com/swarmion/swarmion/commit/08019e8e6f66b656f2ff33c45feda2abb1769528

This is due to:
https://github.com/swarmion/swarmion/commit/08019e8e6f66b656f2ff33c45feda2abb1769528#diff-5bab8e38aa0a5de5269ee0e1e12525d234ed42a0894fdee17edef4f9fd9928bbR10-R11
This looks like a circular import issue, maybe our circular tests configuration is wrong...

I'm really lost here...
In order to have a working release, I'll temporarily remove the two lines (so #461 is no longer available). @Sc0ra we'll need to work to get it back online 🏋🏻♂

In order to fully fix this issue, we need to:

bring back the mock handler feature
add integration tests to ensure this never happens again

Ok I think I have the culprit: it is probably json-schema-faker. My current hypothesis is that it is not side-effects-free, so it interferes with the code shipped on the Lambda.
@Sc0ra @adriencaccia  I think the best way is to create a separate package for testing (serverless-contracts-tests?). This way we can keep the value of this package without shipping it on Lambda.
WDYT?

I completely agree with this. We need to split serverless-contracts to ensure it remains scalable.
This my be a breaking change though, we'll need to have a migration strategy as well...

Getting some progress on the resolution: Removing this single line from the bundled lambda code fixes the issue:
//<EMAIL_ADDRESS>(function(f) {
  if (typeof exports === "object" && typeof module !== "undefined") {
-    module.exports = f();
  } else if (typeof define === "function" && define.amd) {
    define([], f);
  } else {
    var g;
    if (typeof window !== "undefined") {
      g = window;
    } else if (typeof global !== "undefined") {
      g = global;
    } else if (typeof self !== "undefined") {
      g = self;
    } else {
      g = this;
    }
    g.$RefParser = f();
  }

This confirms this issue comes from the inclusion of json-schema-faker in the bundle

However, two questions remain:

why is this piece of code included in our bundle?
why is it overriding module.exports?

It might be worth to open an issue on the json-schema-faker repository

We can resolve this using something similar to what I talked about in https://github.com/swarmion/swarmion/issues/551#issuecomment-1479385043
Ie. using exports to only expose tests related helpers through a subpath.
WDYT @fargito?


Add node 15 test

replaces #781

Starting container circleci/node:16
Warning: No authentication provided, using CircleCI credentials for pulls from Docker Hub.
  image cache not found on this host, downloading circleci/node:16

Error response from daemon: manifest for circleci/node:16 not found: manifest unknown: manifest unknown

Seems there is an issue :thinking:

Nevermind :facepalm: ... Node 16 isn't a thing yet :sweat_smile:

Awesome, thank you very much! :pray:


feature: Export wasm module path and execute function

Coverage remained the same at 85.462% when pulling 5a4f822df99893276b3aef87335b6bfcbb3ccb95 on export_wasm into 4b13ed4f575688bef05cdcaf5736140be7a5eb53 on main.

Coverage remained the same at 85.462% when pulling 5a4f822df99893276b3aef87335b6bfcbb3ccb95 on export_wasm into 4b13ed4f575688bef05cdcaf5736140be7a5eb53 on main.


:wrench: Match the English text to that of the session details screen.

Issue

none.

Overview (Required)

The English text on the AboutScreen and Session Details screens is misaligned, so we have made them match.

Screenshot

Before
After

Looks great!


using let instead of var

try to make it es6.

I think we want to keep the code the same as in the tutorial to prevent confusion, but feel free to add an extra folder ES6_Version/ with updated code. (as can be seen here: https://github.com/CodingTrain/Rainbow-Code/tree/master/Tutorials/P5JS/p5.js/09/9.07_p5.js_Drawing_Object_Trails)


DomainName( ) returns domains with a '/'

Sometimes we get invalid domains names from DomainName( ) such as "corporate24/7.biz".

Thats a good catch. Ill do some secondary filtering to make sure random data it uses doesnt effect a valid domain. Thanks!

v4.2.2


chore: LSDV-4894: Update to NodeJS LTS

Hi @nicholasrq!
This PR was created in response to a PRs in upstream repo:

https://github.com/heartexlabs/label-studio-frontend/pull/1323
https://github.com/heartexlabs/dm2/pull/173

/frontend build lsf

/git merge develop

/git merge develop


Implement model validation (Old 190)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:07
Implement "validating" validation.
use Watson\Validating\ValidatingTrait;

class Post extends Eloquent
{
    use ValidatingTrait;

    protected $rules = [
        'title'   => 'required',
        'slug'    => 'required|unique:posts,slug',
        'content' => 'required'
    ];

    protected $validationMessages = [
        'slug.unique' => "Another post is using that slug already."
    ];
}

// Check whether the model is valid or not.
$post->isValid(); // true

// Or check if it is invalid or not.
$post->isInvalid(); // false

// Once you've determined the validity of the model,
// you can get the errors.
$post->getErrors(); // errors MessageBag

if ( ! $post->save())
{
    // Oops.
    return Redirect::route('posts.create')
        ->withErrors($post->getErrors())
        ->withInput();
}

return Redirect::route('posts.show', $post->id)
    ->withSuccess("Your post was saved successfully.");

try
{
    $post->saveOrFail();

}
catch (Watson\Validating\ValidationException $e)
{
    $errors = $e->getErrors();
    return Redirect::route('posts.create')
        ->withErrors($errors)
        ->withInput();
}

One can bypass validation:
$post->forceSave();

In gitlab by @A-Lawrence on Aug 31, 2015, 01:11
Ardent is no more.  Switched to Validating library.
ALawrence66 - 2015-02-21T19:50:59.146047+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:11
Implemented Ardent validation on the Role and Permission models.  2 down, 50 to go.  Ref issue #488395 (190).
ÔåÆ <>
ALawrence66 - 2015-02-21T14:57:04.749433+00:00

This is mostly invalid now we're using request validation.


Section schema, enabled_on templates all, triggers theme-check error

Describe the bug
The section schema below triggers a theme-check error:
Source

Debugging information

Theme Check v2.1.0

Absolutely right. We forgot to add that to the list in our JSON schema:
https://github.com/Shopify/theme-liquid-docs/blob/main/schemas/theme/section_schema.json#L103-L123
Fixing this...
Thanks for reporting :)

Should be fixed by https://github.com/Shopify/theme-liquid-docs/pull/476
A restart of your editor should load the latest version of the schema that supports enabled_on "" / disabled_on ""


[WIP] Unify and improve config option registration code

This PR attempts to unify and make all the config registration code more consistent - aka so it exposes / utilizes the same API.
I only started to dig into since I started a bunch of test errors like that recently - https://gist.github.com/Kami/fcfa62f1ae7f0b84cd3981ecd6f5fe37.
It looks like there is some kind of race with config option registration which likely depends on the import ordering or similar. Either this issue has been there for a long time already (not so unlikely) or some recent code changes re-arranged the imports or similar which started to trigger this issue more often (I did quickly check git history without much success., but I could have also missed something)
Sadly most of the config modules itself have import time side affects (options are registered on import) which is bad. Fixing / improving that would likely be a very deep rabbit hole since tons of existing code and tests relies on this behavior.
So with this PR I'm really just trying to unify the code and gets tests to pass consistently. Keep in mind that registering the same options multiple times should not be and it's not fatal so if we ignore such errors it's OK (well, it's not prefect, but it's compromise - an alternative is much larger code change which could likely takes many days to even weeks).

I'll merge this since it also contains a test fix (https://github.com/StackStorm/st2/pull/5227#issuecomment-819812421) and the change itself should be safe and fully backward compatible - this way we can get some "CI miles" on it as part of nightly job and see how it behaves over multiple build runs.


__vsnprintf_chk: symbol not found in image ruby:3.3.4-alpine3.20

When I execute this line in a Docker image ruby:3.3.4-alpine3.20
Informers.pipeline("embedding", "sentence-transformers/all-MiniLM-L6-v2")

I get this error:
I, [2024-12-05T20:49:55.365882 #9]  INFO -- : [62709cc1-e351-4573-a1ce-3f2ca6e48fa3] [Rollbar] Details: https://rollbar.com/instance/uuid?uuid=0fbf0811-7b79-4246-80cd-11f99480882e (only available if report was successful)
E, [2024-12-05T20:49:55.366954 #9] ERROR -- : [62709cc1-e351-4573-a1ce-3f2ca6e48fa3]
[62709cc1-e351-4573-a1ce-3f2ca6e48fa3] LoadError (Could not open library '/usr/local/bundle/gems/onnxruntime-0.9.3-x86_64-linux/vendor/libonnxruntime.so': Error relocating /usr/local/bundle/gems/onnxruntime-0.9.3-x86_64-linux/vendor/libonnxruntime.so: __vsnprintf_chk: symbol not found.
Searched in <system library path>):
[62709cc1-e351-4573-a1ce-3f2ca6e48fa3]
Causes:
[62709cc1-e351-4573-a1ce-3f2ca6e48fa3] LoadError (Could not open library '/usr/local/bundle/gems/onnxruntime-0.9.3-x86_64-linux/vendor/libonnxruntime.so': Error relocating /usr/local/bundle/gems/onnxruntime-0.9.3-x86_64-linux/vendor/libonnxruntime.so: __vsnprintf_chk: symbol not found.
Searched in <system library path>)
[62709cc1-e351-4573-a1ce-3f2ca6e48fa3]
[62709cc1-e351-4573-a1ce-3f2ca6e48fa3] app/services/user_favorites/generate_embeddings.rb:3:in `perform'

This is the Dockerfile:
FROM ruby:3.3.4-alpine3.20

# Install dependencies
RUN apk update --no-cache
RUN apk upgrade

RUN apk add --no-cache build-base git curl
RUN apk add --no-cache bash libstdc++ zlib pkgconfig autoconf automake libtool nasm
RUN apk add --no-cache tzdata nodejs npm openjdk8 libxml2 libxslt gcompat imagemagick
RUN apk add --no-cache gifsicle jpegoptim libpng libjpeg-turbo libjpeg-turbo-utils optipng pngcrush pngquant
RUN apk add --no-cache advancecomp --repository http://dl-cdn.alpinelinux.org/alpine/edge/community
RUN apk add --no-cache jhead --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing
RUN npm install -g --force --unsafe-perm=true --allow-root svgo advpng-bin
RUN apk add --update --no-cache openssh

# For mysql
RUN apk add --no-cache mariadb-dev

# Install postgresql dependencies
RUN apk add libpq-dev

# Set an environment variable where the Rails app is installed to inside of Docker image:
ENV RAILS_ROOT /var/www/app
RUN mkdir -p $RAILS_ROOT

# Set working directory, where the commands will be ran:
WORKDIR $RAILS_ROOT

# Setting env up
ENV RAILS_ENV="production"
ENV RACK_ENV="production"

# Basic folders (required by puma)
RUN mkdir -p tmp/pids
RUN mkdir -p tmp/sockets

# Adding gems
COPY Gemfile Gemfile
COPY Gemfile.lock Gemfile.lock

RUN bundle install --jobs 1 --retry 2 --without development test

# Adding project files
COPY . .
# RUN bundle exec rails assets:precompile

EXPOSE 3000
CMD ["bundle", "exec", "puma", "-C", "config/puma.rb"]

Thanks for the support

In another Docker image (same configuration) the error is:
onnx/model.onnx |████████████████████████████████████████████████████████████████████████████████████████████████████|
/usr/local/bundle/gems/irb-1.14.1/lib/irb.rb:1260:in `full_message': Could not open library '/usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/vendor/libonnxruntime.arm64.so': Error relocating /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/vendor/libonnxruntime.arm64.so: __getauxval: symbol not found. (LoadError)
Searched in <system library path>
/usr/local/bundle/gems/ffi-1.17.0-aarch64-linux-musl/lib/ffi/dynamic_library.rb:94:in `load_library': Could not open library '/usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/vendor/libonnxruntime.arm64.so': Error relocating /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/vendor/libonnxruntime.arm64.so: __getauxval: symbol not found. (LoadError)
Searched in <system library path>
	from /usr/local/bundle/gems/ffi-1.17.0-aarch64-linux-musl/lib/ffi/library.rb:95:in `block in ffi_lib'
	from /usr/local/bundle/gems/ffi-1.17.0-aarch64-linux-musl/lib/ffi/library.rb:94:in `map'
	from /usr/local/bundle/gems/ffi-1.17.0-aarch64-linux-musl/lib/ffi/library.rb:94:in `ffi_lib'
	from /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/lib/onnxruntime/ffi.rb:5:in `<module:FFI>'
	from /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/lib/onnxruntime/ffi.rb:2:in `<module:OnnxRuntime>'
	from /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/lib/onnxruntime/ffi.rb:1:in `<main>'
	from /usr/local/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /usr/local/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /usr/local/bundle/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
	from /usr/local/bundle/gems/zeitwerk-2.7.1/lib/zeitwerk/core_ext/kernel.rb:34:in `require'
	from /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/lib/onnxruntime/inference_session.rb:313:in `api'
	from /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/lib/onnxruntime/inference_session.rb:301:in `api'
	from /usr/local/bundle/gems/onnxruntime-0.9.3-aarch64-linux/lib/onnxruntime/inference_session.rb:8:in `initialize'
	from /usr/local/bundle/gems/informers-1.2.0/lib/informers/models.rb:201:in `new'
	from /usr/local/bundle/gems/informers-1.2.0/lib/informers/models.rb:201:in `construct_session'
	from /usr/local/bundle/gems/informers-1.2.0/lib/informers/models.rb:171:in `from_pretrained'

Hi @fguillen, the shared library included in the ONNX Runtime gem requires glibc (and Alpine uses musl). You can try using gcompat, or use the non-Alpine Ruby image.

Hi @ankane wow, thanks for the quick answer. I found my way. Let me know if you think is the right one:
It looks like the issue belongs to the dependency onnxruntime.
Here is the solution: https://github.com/microsoft/onnxruntime/issues/8162#issuecomment-1623120734
Add this to the Dockerfile
RUN apk add --no-cache onnxruntime --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing/ -X http://dl-cdn.alpinelinux.org/alpine/edge/community/ -X http://dl-cdn.alpinelinux.org/alpine/edge/main

And, in the ruby code:
OnnxRuntime.ffi_lib = "path/to/lib/libonnxruntime.so"

That should work as well (although you'll likely want to make sure the version of shared library matches the one included in the version of the gem you're using).

That should work as well (although you'll likely want to make sure the version of shared library matches the one included in the version of the gem you're using).

Sorry, I am not sure how can I confirm this. This is what I find in my Gemfile.lock:
> cat Gemfile.lock | grep informers
    informers (1.2.0)
  informers

> cat Gemfile.lock | grep onnx
      onnxruntime (>= 0.9)
    onnxruntime (0.9.3-aarch64-linux)
    onnxruntime (0.9.3-arm64-darwin)
    onnxruntime (0.9.3-x86_64-darwin)
    onnxruntime (0.9.3-x86_64-linux)

And this is the version of the shared library:
libonnxruntime.so.1.19.2

Is this a problem?

You'll need to check the changelog for onnxruntime-ruby.

Oh!, perfect, I see. I have to use onnxruntime version 0.9.2:
0.9.2 (2024-09-04)
Updated ONNX Runtime to 1.19.2

Thanks!


[Feature] Create all habits screen

Describe your changes
Newly add all habits screen to glance the currently available habits.
Also add a toggling action to pined the habit. If it has pinned, it will show to home screen as mainly focused habit.
Issue ticket number and link
#7

LGTM 👍


[JOSS Review] Paper Feedback

Thank you for submitting this cool toolbox! Here is my feedback on the paper.
General Feedback

I may debate the claim that a Python package should be used for real-time applications. If that was critical, then this package should have been implemented in C++, Rust, or something like that. I think Python is good for ease of use and prototyping, but I may pull back on some of these claims.
In addition to the citations, which you already have, I think it would be helpful to have a brief introduction to these evaluation metrics (ellipsoids and polytopes) and what they do. As such, I think your "Physical Capacity Metrics" would be better served BEFORE the "Implemented Polytope Evaluation Algorithms" section. First say what these things are, and what they are used for, and then get into which algorithms are in PyCapacity.
The tables of evaluation times need to have some notion of variance. Instead of saying things like ~5ms, I (and readers) would be mostly interested in something like 5ms +/- 1ms, as well as a brief description of how this data was collected (how many samples, etc.) -- see e.g., https://jhavl.github.io/mmc/ for an example.
Please add a Conclusion section at the end
Capitalize Python, Jacobian, and Cartesian throughout

Summary

Typo in line 7: "the robot's are required" --> "robots are often required"
Typo in line 9: "One of ways to quantify" --> "One way to quantify"
Line 11: Consider gender-neutral language in line 11 "where he lacks" --> "where they lack"
Typo in line 13: "as todays collaborative" --> "as today's collaborative"
Missing : in line 19 -- "Most of these metrics can be represented by two families of geometric shapes: ellipsoids and polytopes"
Finish your summary by saying what this paper does: It introduces a new package named PyCapacity!

Statement of Need

More of a question: Have there been other tools available, in Python or otherwise, that do these ellipsoid/polytope calculations and visualizations? If so, you should list them and cite them. For example:

https://jhavl.github.io/mmc/
https://github.com/tecnalia-medical-robotics/manipulability_metrics
https://gitlab.com/KeerthiSagarSN/rospygradientpolytope

Typo in line 27: "human musculoskeletal modes" -> "human musculoskeletal models"
I really like that you demonstrated which existing publications already use your work. Very important!

Physical Capacity Metrics

Typo in line 83: "Reachable space approximation of in the desired horizon" -- of what? I think it is either missing a word, or the "of" should be deleted
The caption in Figure 2 is missing a period after "visualized with biorbd".

https://github.com/openjournals/joss-reviews/issues/5670

Hi  @sea-bass
Thanks for the detailed review I appreciate it.
I helped me a lot to go a step further and I ma pleased with the result.
The paper is almost entirely rewritten, but the main changes are:

a bit more consequential Statement of need with a discussion about the existing solutions
a bit more info about what is the main aim of the library (apart form the near real-time)
I've done a bit more benchmarking and updated the table with the statistics, as well as provided the benchmarking scripts in the examples folder so that everyone can check on their system
Added the conclusion
A section about the differences of ellipsoids and polytopes, and what do they actually represent added

In terms of the real-time claim.
It is absolutely true that if the real-time would have been the only goal the python implementation does not make sense. The goal of the library is to provide efficient tools for their evaluation in a easy-to-use package. However, looking at the efficiency of the implemented algorithms , even though they are implemented in python, they are in many cases good enough for interactive applications.
Especially in terms of musculoskeletal models, they are usually restricted to off-line use, due to their inherent dimensionality issues (large number of muscles) . The ICHM algorithm implemented in this package is able however to evaluate their polytopes within a 200-300ms which might have taken hours with different methods.
So its much closer to real-time than before, but it is far from sub-millisecond that you'd probably expect form "real-time" claims.
However just as an example, we have used this package (both for robots and humans) for the real-time robot control in our lab, we ran the code at the frequency of 50 to 100Hz which is perfectly enough for many use-cases.
Finally, the area of using  task-space physical ability metrics (especially polytopes) in real time applications is very small at the moment, mostly due to their computational complexity, so having the real-time keyword in the title allows to reach further and show to the community that it is not as far from the real-time as they might think. :D

@askuric I have the same concern as @sea-bass on the real-time claim. I do agree with your rationale but may be think about replacing "Real-time" with "Fast" or "Efficient" keywords instead.
I would also suggest to add some of the numbers you mentioned above in the paper and may be an example where the computation is profiled

Typo in line 21: "off line" --> "offline"/"off-line"

Thanks @askuric -- took a look at your reworked paper and it looks awesome! Much clearer and gentler introduction to the readers.
My only "real" comment is that it's probably risky for the paper to provide direct links to the performance benchmarking scripts since this might change in the future. I'd just say "provided in the repository" and add instructions in the repo itself for reproducing the benchmarking for both the robot and musculoskeletal models.
Finally, some small editorial comments as I read through. Nothing major:

In the summary, and again in the statement of need, you mention robotic-toolbox but I think they call the module roboticstoolbox. Either use this, or the full name "Robotics Toolbox for Python".
In the summary, line 15, small typo "biomechanics softwares opensim" --> "biomechanics software opensim"
Typo in line 57-58: "as they are essentially a triangulated meshes" --> "as they are essentially triangulated meshes"
Line 65 missing a space between cddlib and the citation, same with line 69 in pygradientpolytope and its citation.
Typo in like 75: "Futhermore" -> "Furthermore"
Line 129: Extra space after the comma in "their faces, H-representation".
Lines 208-209 missing a word: "provides a brief performance evaluation of their execution times"
Line 212 fix capitalization: "7 dof Franka Emika panda" -> "7 DOF Franka Emika Panda"
Same with like 218: "50 muscle 7 dof" -> "50 muscle, 7 DOF"
Lines 213-214 missing a word: "computer equipped with a 1.90 GHz Intel i7..."

Hey @sea-bass,
Thanks a lot for your updates, the paper is updated with your comments.
I absolutely agree about the script link, it is not the smartest idea in long-run.
The paper is regenerated in the main issue:
https://github.com/openjournals/joss-reviews/issues/5670
Let me know if there is anything else you'd like me to do.

LGTM -- thanks for making all these updates!

Hi @ShravanTata,
Sorry to rush you, but did you maybe have time to look into the made changes?
I'd be happy to hear your feedback.
Thanks!


Add proper support for a single RequestTracingFilter that supports Servlet 2.x and Servlet 3 environments at the same time

Fixes issue #50. Big thanks to @adriancole and @woldie for the help on this.

Codecov Report

Merging #52 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     98.93%   98.94%   +<.01%
+ Complexity      475      471       -4
============================================
  Files            28       28
  Lines          1132     1139       +7
  Branches        134      133       -1
============================================
+ Hits           1120     1127       +7
  Misses            4        4
  Partials          8        8

Impacted Files
Coverage Δ
Complexity Δ

...et/WingtipsRequestSpanCompletionAsyncListener.java
100% <ø> (ø)
8 <0> (ø)
:arrow_down:

.../wingtips/servlet/RequestTracingFilterNoAsync.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...tips/servlet/RequestWithHeadersServletAdapter.java
100% <ø> (ø)
4 <0> (?)

...ava/com/nike/wingtips/servlet/HttpSpanFactory.java
100% <ø> (ø)
10 <0> (?)

...java/com/nike/wingtips/servlet/ServletRuntime.java
100% <100%> (ø)
3 <3> (?)

...om/nike/wingtips/servlet/RequestTracingFilter.java
100% <100%> (ø)
23 <22> (+13)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd95cc6...6a90703. Read the comment docs.


GPU vs. TPU, A100, V100, T4

Do you have a recommendation for which runtime configuration will produce a batch of images the fastest when running your notebook?

RunPod 3080 and 3090 are the best for inference, colab GPUs aren't that good

So I paid on run pod and I can get to a point where it shows me "connection options" and it gets to a point with the image below but then none of these take me to a place where I can get the standard automatic1111 interface.  The first option stays "not ready".  the second option takes me to a page where I have no idea how to do anything.  If I connect to the web terminal it takes me to a terminal like prompt.  How do I get to the interface?  And is there a way to get this to use what's in my google drive for models, lora's, etc, or is this a new drive that I need to upload stuff to?  Thanks in advance for your help!

Also, while I'm trying to figure that out, is there one of the GPUs on colab that are the best?  Seems like A100 followed by V100 followed by T4?  Is that right

click on "connect to jupyter lab", make sure you chose the fast stable diffusion template, when you click on connect to jupyter lab, it will take you to jupyter interface, choose the A1111 notebook, it will look similar to the colab notebook.
A100 is way stronger than T4 but 5 times more expensive

Is there a way to connect my google drive so it can grab models from there?  Also, when I followed your instructions I was able to get to the automatic1111 start page, but when I ran the start stable diffusion cell, I got this error:
FileNotFoundError                         Traceback (most recent call last)
Cell In[3], line 8
3 Password= ""
5 # Add credentials to your Gradio interface (optional).
6
7 #-----------------
----> 8 configf=sd(User, Password, model) if 'model' in locals() else sd(User, Password, "");import gradio;gradio.close_all()
9 get_ipython().system('python /workspace/sd/stable-diffusion-webui/webui.py $configf')
File /workspace/mainrunpodA1111.py:403, in sd(User, Password, model)
399   auth=""
401 call('wget -q -O /usr/local/lib/python3.10/dist-packages/gradio/blocks.py https://raw.githubusercontent.com/TheLastBen/fast-stable-diffusion/main/AUTOMATIC1111_files/blocks.py', shell=True)
--> 403 os.chdir('/workspace/sd/stable-diffusion-webui/modules')
404 call('wget -q -O paths.py https://raw.githubusercontent.com/TheLastBen/fast-stable-diffusion/main/AUTOMATIC1111_files/paths.py', shell=True)
405 call("sed -i 's@/content/gdrive/MyDrive/sd/stablediffusion@/workspace/sd/stablediffusion@' /workspace/sd/stable-diffusion-webui/modules/paths.py", shell=True)
FileNotFoundError: [Errno 2] No such file or directory: '/workspace/sd/stable-diffusion-webui/modules'

did you run all the cells from the top ?

Thanks for the feedback.  In your opinion then, do you get more images per
dollar with V100 than A100?
Matthew D. Lieberman, Ph.D. (twitter http://twitter.com/social_brains)
Director, UCLA Social Cognitive Neuroscience Laboratory
http://www.scn.ucla.edu
Co-Founder, Resonance Inc. https://www.resonance.info
Editor-in-Chief, Social Cognitive and Affective Neuroscience
https://academic.oup.com/scan
Zoom - https://ucla.zoom.us/my/lieberman
"Being skeptical means demanding evidence, not ignoring it"  -Bobby Azarian
"When I went to school, they asked me what I wanted to be when I grew up. I
wrote down ‘happy.’ They told me I didn’t understand the assignment, and I
told them they didn’t understand life."  -John Lennon
On Fri, Jun 30, 2023 at 6:30 AM scorpi0n81 @.***> wrote:

Do you have a recommendation for which runtime configuration will produce
a batch of images the fastest when running your notebook?
I am using V100 and it creates batch of 4 pretty fast. V100 is a good
balanced point of return of cost as consumes less compute units per hour
and is decent in terms of speed in terms of delivery. A100 is yes faster
but the additional per hour compute units dont justify what you get in
return.
—
Reply to this email directly, view it on GitHub
https://github.com/TheLastBen/fast-stable-diffusion/issues/2295#issuecomment-1614655482,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZG3OPPI5NZAR2G2EIDSJHDXN3IGRANCNFSM6AAAAAAZX5W7QI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for the feedback.  In your opinion then, do you get more images per
dollar with V100 than A100?

Thanks for the feedback.  In your opinion then, do you get more images per
dollar with V100 than A100?

Not saying it mathematically as the kind of model settings etc.. will influence time per image however, purely in my opinion and experience - yes, V100 hits the sweet spot compared to A100 in terms of more bang for the buck!

yes, if you can get the v100, it's the best option for colab


Prometheus: More detailed metrics

Do you want to request a feature or report a bug?
Feature

What did you expect to see?
I like to have a more detailed metric with prometeus.
For example:

Requests per Route
Requests per Backend
Average Time per Backend
Average Time per Route

Hi @danielh1989,
Thanks for your interest in Træfik projet.
For information, the current available metrics are :

config_reloads_total
traefik_config_reloads_failure_total
traefik_config_last_reload_success
traefik_config_last_reload_failure
traefik_entrypoint_requests_total
traefik_entrypoint_request_duration_seconds
traefik_entrypoint_open_connections
traefik_backend_requests_total
traefik_backend_request_duration_seconds
traefik_backend_open_connections
traefik_backend_retries_total
traefik_backend_server_up

What do you mean exactly when you tell "per route"? Prometheus doesn't like "unbound" label values and so putting an arbitrary path into it is not an option if you don't want to kill your Prometheus server.

as an example, i'd really like to know which API (based on a path) is slower than others when using the traefik_backend_requests_total metric. my services don't have an unbounded number of APIs so perhaps Traefik could only fill the label for backend requests that are not a 404 to avoid client spam.

Recently I moved from ingress-nginx controller to traefik, and only now I realised, that traefik unfortunately doesn't have any way to collect metrics by URL path. For example in ingress-nginx controller this behavior works by default: https://github.com/kubernetes/ingress-nginx/blob/96b6228a6b65a85e421b8a348a149e99181664d1/deploy/grafana/dashboards/request-handling-performance.json#L314
Traefik has a lot of pros like SSL certificates management and very comfortable routing, but observability of the system also is one of the most important thing, and now I can't understand which route of my API works slow....
Hope that the path label will be added in nearest future..

I found the metric labels were more usable if I used an intermediate TraefikService in the path to my actual k8s service.

Recently I moved from ingress-nginx controller to traefik, and only now I realised, that traefik unfortunately doesn't have any way to collect metrics by URL path. For example in ingress-nginx controller this behavior works by default: https://github.com/kubernetes/ingress-nginx/blob/96b6228a6b65a85e421b8a348a149e99181664d1/deploy/grafana/dashboards/request-handling-performance.json#L314
Traefik has a lot of pros like SSL certificates management and very comfortable routing, but observability of the system also is one of the most important thing, and now I can't understand which route of my API works slow.... Hope that the path label will be added to metrics in nearest future..

yes, the observability for every path of URL(route) is important for me too,  even for alert/notification of traffic accident.


17118 update base address for vite

Issue #: /bcgov/entity#17118
Description of changes:

Fixed Base Address to work with Vite migration (Fixes sourcemap error in https://github.com/bcgov/business-create-ui/pull/560)
Changed vue-plugin-helper-decorator to vuelidate-property-decorators. The former is a very outdated and old package. I've tested and the way we're using the decorator works the exact same way with both.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

I thought all the tests passed previously?

I wouldn't approve all these changes on a Friday afternoon, but you're in tomorrow, right? :)

Sev, 99% of the changes here are from npm build storybook. The actual changes are at the end (only a handful).

PS It would be nice to separate the SB files from the other changes. 179 is a large number to review (even if I skip over most of them).

Actually, Travis noted recently that we should not commit the SB files, and the CI job should re-create them. We need to bug @pwei1018 to help us with this :)

I thought all the tests passed previously?

Yup, they do. I re-ran the job, all is green now.

PS It would be nice to separate the SB files from the other changes. 179 is a large number to review (even if I skip over most of them).

Actually, Travis noted recently that we should not commit the SB files, and the CI job should re-create them. We need to bug @pwei1018 to help us with this :)

Oh shoot. Shall I fix that? I'll only commit my changes?

@severinbeauvais Should be much much cleaner now. No more committed SB files.

PS It would be nice to separate the SB files from the other changes. 179 is a large number to review (even if I skip over most of them).

Actually, Travis noted recently that we should not commit the SB files, and the CI job should re-create them. We need to bug @pwei1018 to help us with this :)

Oh shoot. Shall I fix that? I'll only commit my changes?

We haven't implemented the auto-Storybook-build yet. See 17345.
For now, please commit the SB files.

I'm playing with this locally. It appears that validations are not working. I'm seeing this in the console.log when I make the address editable in SB for CompletingParty:

I tried adding "vuelidate-property-decorators" as a dependency for CompletingParty but that doesn't seem to help.

I tried adding "vuelidate-property-decorators" as a dependency for CompletingParty but that doesn't seem to help.

^^ This may or may not be needed but that's not the issue here.
The issue is with the way that validations are working. Previously, in the validation-mixin, this.$v[prop][key].$params.maxLength had a prop max with a value, but at the moment maxLength=null.

I tried adding "vuelidate-property-decorators" as a dependency for CompletingParty but that doesn't seem to help.

^^ This may or may not be needed but that's not the issue here.
The issue is with the way that validations are working. Previously, in the validation-mixin, this.$v[prop][key].$params.maxLength had a prop max with a value, but at the moment maxLength=null.

Sev, I just noticed that this issue has been present even before this PR. I went to the SB in the main repo (without my changes), and I can also see this error. I was also having this issue in my Vite PR. I fixed it by playing with the vuelidate verison. I'll check how things are going in here.

The issue is with the way that validations are working. Previously, in the validation-mixin, this.$v[prop][key].$params.maxLength had a prop max with a value, but at the moment maxLength=null.

We don't see this error in SB BaseAddress because no schema is declared.
With a schema:

^^ This may or may not be needed but that's not the issue here.
The issue is with the way that validations are working. Previously, in the validation-mixin, this.$v[prop][key].$params.maxLength had a prop max with a value, but at the moment maxLength=null.

Please try now Sev. Should be fine.

Please try now Sev. Should be fine.

Indeed, now it works!
Can you please add an address schema to BaseAddress? You can prob use the same one as in the CompletingParty story.
And then we'll be good to merge this!

lerna notice
Successfully published:
 -<EMAIL_ADDRESS> -<EMAIL_ADDRESS>lerna success published 2 packages

lerna notice
Successfully published:
 -<EMAIL_ADDRESS> -<EMAIL_ADDRESS>lerna success published 2 packages

Thanks Sev!


Ensure types checked

Due to a mistake in the Webpack config, TypeScript code was being compiled properly, but no actual type checking was done. Corrected this, and made necessary changes to the code accordingly.

@rileyhgrant just for my own peace of mind, could you please definitely make sure to try this locally? specifically, try introducing a type error (dealer's choice, LMK if you have trouble coming up with something), and make sure that both yarn build from the browser subdirectory, and yarn jest from the main directory, both fail with appropriate type erros.

@rileyhgrant interesting--note that the name of the source JS file it's complaining about appears to be autogenerated, and the fact that it's under the dist/public directory. Looks like the problem here is, for some reason, Webpack is trying to include the result of a previous compilation as a source for the current compilation.
What happens if you rm -rf that dist/public directory and try the build again? (Or you could mv that directory elsewhere if rming it makes you nervous.)

@rileyhgrant as for the counterintuitive behavior regarding the site still working after a build failure, this is something I've also gotten caught on many times: you're looking at the last successful build of the site. That does mean that, if you create a type error, then don't run tests before checking in your code, it's possible to push code with a type error to Github.
That's not catastrophic, because CI will catch that when it tries to build the bundle from scratch, and it's infinitely better to have CI catch that than to let it slip by. But it would also be better to catch that earlier in the pipeline. I wonder if we could rig up some kind of widget on the page itself that only displays in dev mode, something very prominent in a deliberately garish color scheme, with a warning to the effect of YOU ARE LOOKING AT A STALE BUILD. 6 build failures since 2022-09-13 09:25.

I thought about the possibility of a pre-commit hook that ensures that the source builds from a clean slate, but the problem is that that could turn very time-consuming. I wonder though if there's a way to just typecheck everything without actually having to compile everything, that should be much faster if possible, and while it won't catch every bug it should catch a great many of them.

Aha, thanks for so thoroughly answering my questions. You were, of course, correct on the errors on my machine coming from some previously built files in the dist/public that were still hanging around. As an aside, is removing the contents of that directory something I should do regularly? Or is this a particular case in which there were older files still hanging around and this is the first time TypeScript was properly trying to compile things to JavaScript with type checking?
Removing the contents of that directory causes the intended behavior when introducing a type error, and you already touched upon the interesting bit of falling back on the previous successful build (thanks for the clarification). Interesting idea on both of the fronts re: stale build warning for the site in dev mode, or just checking types without compilation. For my two cents, I feel like a stale build warning message on the site would be sufficient? Happy to discuss more offline and hear more about peoples opinions.
Anyhoo, thanks for answering my questions. Looks good!

@rileyhgrant no need to delete dist/public regularly, no, it's only something you need to do if like in this case you think it's specifically implicated.
I'll make an issue about giving a stale-build situation a higher profile generally, feels like we can wait to move on that one until we all three have a chance to talk it over.

That's not catastrophic, because CI will catch that when it tries to build the bundle from scratch

Well, never mind, because it turns out CI will only catch such a bug if it's in a file that some test exercises, which is almost none of the codebase as it currently stands. So it looks like we'll need to add in an explicit test that the code compiles, I'm thinking now I will add a CI step for that to this PR. More commits to follow.

@rileyhgrant as I mentioned above, I added a new commit with a step that builds the whole project. I verified that a type error that got past jest was caught by the new step, in run https://github.com/broadinstitute/gnomad-browser/actions/runs/3045979908/jobs/4908216219.

@rileyhgrant as I mentioned above, I added a new commit with a step that builds the whole project. I verified that a type error that got past jest was caught by the new step, in run https://github.com/broadinstitute/gnomad-browser/actions/runs/3045979908/jobs/4908216219.

That it does! Very nice.


[Bug] Ability to see the source code of tests

Describe the bug
One can see the source code of tests (may contain the solution) by accessing the file system.
To Reproduce

Go to the training page of any kata.
Set the language to JavaScript.
Add this line:console.log(require("fs").readFileSync("/home/codewarrior/index.js").toString());

Click on [Attempt].
The source code appears in the Log section.

Expected Behavior
Any attempt to access the FS should throw or do nothing.
Contexts

OS: macOS
Browser: Safari
Browser Version: 12.0.2

Any attempt to access the FS should throw or do nothing

This is not possible because it's the only way to read user solution code (in /home/codewarrior/solution.txt) in text fixture. Permission for individual files should be configurable though.

This is not a bug


compose: Make input value updates more consistent

Use handleMessageChange and handleTopicChange in
componentWillReceiveProps to change message and topic input
values instead of setting the state manually.
This ensures consistency with other functions in the same component.
This changes the behavior slightly:

for topic, we collapse the compose buttons
for message, we do the same plus we send a 'typing' event to the
server

Merged, in the interest of getting #2738 in and a release out.
I am still curious about my questions above, though.
Thanks again!


MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.6.6, and con…

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.