Welcome Page (After Countdown)

As a user, I wish to see the Welcome Page differently once October begins - the countdown should be replaced.

Hi @lisphelps, could you assign this to me?

Opened a PR for this fix - #97
I included a screenshot, but if a test is required too let me know and I'll update my PR. It's getting late and I need to get up early tomorrow 😆

Thanks! Ok no problem, I'll get that done later on today.

Hey @aaronshivers , I updated my PR for this with some tests to check for the changed heading and the link I added. I updated some of the tests to skip based on whether it's currently hacktoberfest or not so they shouldn't fail 🙏 .
Can you run the tests again and review when you get a chance? Thank you!


change name

ArrayTools already exists on BioConductor for some microarray package.
Find an alternative name to be able to submit it to CRAN.

renaming to narray


Utilise bash shell when calling aurora_delete.sh from reaper script

Out of curiosity: Would it also work to remote the "sh", and call it without? What would be the difference?

Hmm yeah, that works as well! Not sure why I didn't do that originally :thinking:


Feat/xxx/backup umh

Description
documentatiopn for the umh backupt script/ how to backupt entire UMH

This is why it is failing:
<html>
<body>
<!--StartFragment-->

14:42:11.682 | hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended linux/amd64 BuildDate=2023-03-12T11:40:50Z VendorInfo=gohugoio
-- | --
14:42:11.876 | Error: Error building site: "/opt/buildhome/repo/umh.docs.umh.app/content/en/docs/production-guide/backup_recovery/backup-entire-umh.md:78:4": failed to extract shortcode: template for shortcode "warning" not found
14:42:11.877 | Total in 270 ms
14:42:11.887 | Failed: build command exited with code: 255
14:42:12.732 | Failed: error occurred while running build command

<!--EndFragment-->
</body>
</html>


updated event.js file with the fetch handle function, formatted user …

…input for api key, appended the return from the api

Approved!


TNBC POS - User Management & Authorization - MILESTONE 02

Link to original project proposal.
https://github.com/thenewboston-developers/Projects/issues/254
Link to most recent milestone payout request.
https://github.com/thenewboston-developers/Projects/issues/276
Milestone Description
In this milestone we're working on User Management, User Authentication and User Authorization based on user role permissions.
Here is the software user interface design that we would make functional both on the frontend and backend in this milestone.
Link : https://www.figma.com/file/Wr9cmAbtCiwSbYETuF7bKi/Authentication-and-User-Management?node-id=0%3A1
Objective 1 : Backend development
Tasks List :  These functionalities would be done on the backend and API would be generated

User login, forgot password, reset password & email verification
User Role-permission list, Add new role-permission, update, view & delete role-permission
Register new user, update & delete user, view user list
Add user profile, update, delete & view user profile,
Password change, Image update form user profile setting
data Pagination & search functionalities
Data validate on backend

Objective 2 : Frontend development
Tasks List :  On frontend we would develop following interfaces, integrate backend APIs and role-permission based authentication functionalities

App Layouts of Guest user Authenticate user & POS interface
Login, Programmatic redirection based on role permissions after login, forgot password, reset password,
Role-permission list, Add new role-permission, update role-permission
Register new user, Update user, user list
Add user profile, update user profile, view user profile
Profile settings, Password Update, Image update, email verification
403, 404, 500 error pages
Route access based on role-permission
Pagination & search functionalities for data-tables
Form validations

Proof of running works of the proposed milestone :
Postman documentation of Backend Apis : https://documenter.getpostman.com/view/17175268/U16bxUvD
Backend github repository : https://github.com/Techminate/TNBC-POS-Backend
Deployed development version of frontend : https://tnbc-pos-dev.herokuapp.com/
Frontend github repository : https://github.com/Techminate/TNBC-POS-Frontend

#
Objective
How can auditors verify milestone?

1
Backend development
We would provide Postman documentation of Backend Apis and github project repository

2
Frontend development
We would provide the link of deployed app and github project repository

How long do you estimate this milestone will take to complete?
3 Weeks
Project Wallet
a5dbcded3501291743e0cb4c6a186afa2c87a54f4a876c620dbd68385cba80d0

@SazidAhmed, Bucky recently made an announcement (https://discord.com/channels/774574985510518806/774610040618221588/880525066964713482) whereby the first (or next) milestones of every project must be up to the point of MVP.
Please edit this milestone to take this into consideration.

Approved.


e2e-cli.sh pre-submit script fails

workflow_id:30330619
run_id:540[8](https://github.com/slsa-framework/slsa-verifier/actions/runs/5408519694/jobs/9827769041?pr=645#step:6:9)45[9](https://github.com/slsa-framework/slsa-verifier/actions/runs/5408519694/jobs/9827769041?pr=645#step:6:10)460
artifact_id:
gh: Not Found (HTTP 404)
  End-of-central-directory signature not found.  Either this file is not
Archive:  artifacts1.zip
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of artifacts1.zip or
        artifacts1.zip.zip, and cannot find artifacts1.zip.ZIP, period.
artifact_id:
gh: Not Found (HTTP 404)
  End-of-central-directory signature not found.  Either this file is not
Archive:  attestation1.intoto.jsonl.zip
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of attestation1.intoto.jsonl.zip or
        attestation1.intoto.jsonl.zip.zip, and cannot find attestation1.intoto.jsonl.zip.ZIP, period.
/home/runner/work/slsa-verifier/slsa-verifier
Testing against builder args
  **** Default parameters (annotated tags) *****
./__THIS_REPO__/slsa-verifier verify-artifact artifact1 --provenance-path attestation1.intoto.jsonl --source-uri github.com/slsa-framework/example-package
WARNING: Insecure SLSA_VERIFIER_TESTING is enabled.
Verifying artifact artifact1: FAILED: open artifact1: no such file or directory

FAILED: SLSA verification failed: open artifact1: no such file or directory
✖ 1 == 0 :: not main default parameters (annotated_tags)
Error: Process completed with exit code 1.

Fixed in #646


Slicing buffers fails in latest Microsoft Edge

slicing buffers fails in Edge 25.10586.0.0
it boils down to this:
var buf = new Buffer(100);
var arr = new Uint8Array(100);
buf instanceof Uint8Array; // true
Uint8Array.prototype.subarray.call(arr, 0, 0).length; // 0
Uint8Array.prototype.subarray.call(buf, 0, 0).length; // 100 !

Would you say this is an issue with Edge or with this lib?

This sounds like an issue with Edge, especially if it's a regression from IE11. Should probably be filed on http://connect.microsoft.com/

This sounds like a regression in Edge from IE11. Can you file a bug report with Microsoft and post the link here?

Just added Edge to the test suite (https://github.com/feross/buffer/pull/87) and for what it's worth, the tests all pass.

I have tested it some more all tests pass in Edge, as you said.
When i use Buffer from https://wzrd.in/standalone/buffer, I don't get these issues.
So it seems to be something in our tool chain that is causing this issue. Maybe some combination of Babel/browserify. I will continue down the rabbit hole, thanks for your assistance and for updating your tests to run on Edge

Thanks for updating this issue, @oskbor. If you end up discovering a bug, please do open a new issue, or comment in this one. Cheers!

Bug report posted to Microsoft
https://connect.microsoft.com/IE/feedbackdetail/view/2207846/buffer-uint8array-regression-in-latest-edge

I just marked that I've also experienced the bug on the issue.

Thanks!
Do you have any ideas on why my build might fail while the one on wzrd.in does not? I spent all day trying to find the reason, but ended up no wiser :confused:

@oskbor Can you open a new issue?

The test sweet uses Edge 13 which is ancient. This bug doesn't occur in Edge 20. It does in Edge 25. There are no VM's out there running Edge 25 as far as I know; I spent a ton of time getting my hands on a physical machine to reproduce this :-)

@Sjors EdgeHTML13 is actually pretty new. See: https://en.wikipedia.org/wiki/Microsoft_Edge#Release_history And there's no way to get a newer version with Sauce Labs right now.
To be clear, you're not reporting a new issue. Just saying that you got this bug using an old version of browserify/buffer?

I see, good to know EdgeHTML has different versioning from the browser.

The issue went away for me as soon as I upgraded browserify*, so indeed I'm
not reporting a new bug.

= make sure grunt-browserify is also up to date and using browserify >=13


get sourcemap type from ENV

Is your proposal related to a problem?

There is an issue with sourcemaps and hot reloading now
https://github.com/facebook/create-react-app/issues/6074
Also, sourcemap type is opinionated.
Sometimes you want fast rebuild, and sometimes you want include columns to courcemaps and be able to place breakpoint in one line arrow functions.
Sometimes you want sourcemaps in production.
Describe the solution you'd like

Add REACT_APP_SOURCEMAP variable with some default values on development and production modes.
Describe alternatives you've considered

https://github.com/timarney/react-app-rewired
Additional context

https://github.com/facebook/create-react-app/issues/6074
https://github.com/facebook/create-react-app/issues/21
https://github.com/facebook/create-react-app/issues/99

Can you try the latest release and see if this has improved? If not please open a new issue.


Introduce "Bundler.clean_env"

Via https://github.com/bundler/bundler/issues/4232
Which should return the environment as it was before bundler modified it.
Should this use "original_env" or "clean_env" or both?

At one time, the difference was that one went up one layer of env, while the other removed all Bundler values. I'm not sure if that's still true today.

You can assign this ticket to me if you want.

I am okay with providing both clean_env (delete all Bundler env) and original_env (restore env to before this Bundler loaded). In Bundler 2.0, I think we should only provide original_env.

@indirect @segiddins I added original_env and clean_env (the latter with a @deprecated flag). I've also rewritten the "with_clean_env_spec" test, I think it's simpler now and covers more.
What do you think?

@RochesterinNYC want to review the spec changes?

Other than a bit of possible DRYing up and more utilization of rspec features, the specs LGTM.

Thanks for the feedback!
I moved the "bundle install" code to a before block.
I'm not sure about let. To replace all assignments with let I would need to wrap each test in a context block where I would then define those values (code, path, result). Is it the way to go?

@njam Nope, you're right. It's possible to re-arrange these around to use let blocks but it's fine as is/isn't necessary. :+1:

@homu r+

:pushpin: Commit 1066a72 has been approved by segiddins

:hourglass: Testing commit 1066a72 with merge b20fbf8...

:sunny: Test successful - status


Suggestion: Dropbox Support

I would love to see Dropbox support for this app.

I don't really think that dropbox support is something that ripme should do. There are already well made programs to download from filelockers and trying to recreate that work in ripme would just make the program heavier and more bloated then it needs to be.

Duplicate of https://github.com/4pr0n/ripme/issues/285


Removed Social media Icon text and Added hover effect

Can you please add screenshots of before and after?

Left one is before right is after

Closing this PR, as there are no further developments.


Correct package.json name to rdfjs org

What is the benefit of this change? Keeping the name rdf-js will not require any changes in code.
If we do this, however, everyone will have to update all of their imports.

Nothing has to break, we can publish over rdf-js to proxy this package. Bringing the package under the rdfjs org aligns it with this repo and signals that it is endorsed and maintained by the RDFJS team.

That sounds awesome, I do agree it would bring clarity and consistency!

So we then agree to publish both rdf-js and @rdfjs/types?

Alternatively, rdf-js could be deprecated and point to the newer @rdfjs/types for people wishing to update to the major version 2.x of the types. I think that solution would allow people to organically discover that the types have a new major release and slowly migrate to the canonical URL rather than having two concurrent versions more or less forever around.
The other question that seemed more important is how to proxy @types/rdf-js to this deployment. It seems unclear what the best way forward in that matter is. But I don't think it should hold off publishing @rdfjs/types.

Alternatively, rdf-js could be deprecated

I'm still not convinced. Keeping rdf-js does not break anyone's code. Even if it's only s/rdf-js/@rdfjs/types/ I think it's unnecessarily disruptive. All they would change is the package.json entry

The other question that seemed more important is how to proxy

You mean what happens when we finally start publishing our own package? I have not experienced it first hand as typings author but Definitely Typed has a policy for removing packages. They recommend removing the @types/ package as soon as we publish our own. At which point I think an empty package is published with deprecation warning on npm install.

The current situation is already disruptive since there are two concurrent packages rdf-js and @types/rdf-js and in fact, on the homepage of the rdf-js package it clearly states: "Do not install this package directly".
See: https://www.npmjs.com/package/rdf-js
As a result and for the past 2 years, I think most people (including me and most of the recent repository I've encountered) have been relying on @types/rdf-js, not on rdf-js. If removing the @types/rdf-js package is ok in your opinion, I don't see how deprecating rdf-js is a problem in comparison.
First, deprecating rdf-js will not force anyone to update their dependency, once again to a new major so not an automatic update anyway, it will instead show a deprecation message when they install it incentivising them to install the authoritative/canonical package. See: https://docs.npmjs.com/using-deprecated-packages.
Second, there is nothing in the rdf-js package name that hints towards the fact that it is a types library rather than an implementation of the RDF/JS specification. It confused everyone I've talked to.
Third, The brand name RDF/JS is a great asset, it would be a shame not to use it Including it in the package name makes the endorsement/source clear and it's very helpful/reassuring, even more so to new developers of which we can only hope there will be more in the future.
Thanks for the link to the policy for removing packages on DefinitelyTyped, it makes things clearer. Great to see that this process properly deprecates @types packages and link them to the relevant repo. See: https://www.npmjs.com/package/@types/3d-bin-packing

Curious that I have never experience the confusion you refer to. Let me give you a complete example.

I think most people have been relying on @types/rdf-js, not on rdf-js.

You only consider package.json? Any project using the types will install @types/rdf-js, which pretends to be type declarations for rdf-js. (The fact that this package actually exists is right now irrelevant).
Thus, in code you will find imports like:
import { NamedNode } from 'rdf-js'

By reviving rdf-js for the types no code will have to change. The next patch release of @types/rdf-js will simply install rdf-js as its dependency and thus all other @types packages which depend on RDF/JS spec (for example type fo parsers/serializers) will continue to seamlessly work because all of their imports will still be valid.

If removing the @types/rdf-js package is ok in your opinion, I don't see how deprecating rdf-js is a problem in comparison.

Again, the current package will not be removed. It will simply proxy to a new "real" package to ease adoption. How it "is a problem in comparison"? Read below

Now, changing the name to @rdfjs/types will completely break everyone. I expect that the necessary updates will create a snowball effect and it will likely continue until everyone migrates to the new package.
The problem is similar to what can happen if you somehow end up with multiple versions of @types/rdf-js. Duplicate declarations of type can be falsely identified as incompatible in weird places in your modules, preventing successful build.

So while I agree that if we were starting from a clean slate, I too would opt for a more natural, less confusing package name, at this point we do not have that luxury. We're looking at an existing ecosystem which we cannot afford to break and that should trump the arguments about people being confused.

Nothing has to break, we can publish over rdf-js to proxy this package.

@blake-regalia, so you propose to publish rdf-js with a single index.d.ts module?
export * from '@rdfjs/types`

Apologies for the late reply, but I agree with @tpluscode's stance on this.
Using this other package name will be break all existing packages, requiring them to change all imports.
Whereas just migrating to rdf-js would allow people to keep all of their existing code unchanged (and be compatible with other packages that have not yet been updated to the new typings).
So I'm against merging this PR.

Apologies for the late reply, but I agree with @tpluscode's stance on this.
Using this other package name will be break all existing packages, requiring them to change all imports.
Whereas just migrating to rdf-js would allow people to keep all of their existing code unchanged (and be compatible with other packages that have not yet been updated to the new typings).
So I'm against merging this PR.

Coming back to this thread, I suggest we deprecate the other packages and point to o@rdfjs/types as the single source of truth for RDFJS typings. Package deprecation is not a big deal guys. Let's clean this up once and for all.

@blake-regalia you agree with my https://github.com/rdfjs/types/pull/4#issuecomment-747949752 ?
As long as we won't have everyone change their imports right away I can agree with what happen's here

I initially proposed making rdf-js a proxy lib, but then we would have to maintain two packages in order to keep semvers up to date. I believe the more appropriate course of action here is to simply deprecate the other package and point users to the scoped package @rdfjs/types. Keep in mind, nobody's code will break. When they are ready to migrate then they can do so.
More technically: I would propose publishing a new minor semver version of rdf-js and then immediately deprecate only that version. This would ensure that when a user installs a module that depends on rdf-js they are not met with a deprecation message. When developers are ready to upgrade however, then they can perform migration.

Word of caution
The proxy package could just have a single version and a dependency on "@rdf-js/types": "*". Actually trying to use sem ver is asking for trouble. Conflicting versions of multiple types versions easy lead to weird nom/yarn resolutions and broken build. We had a long discussion about @rdfjs/data-model which had a dependency on a specific version of the types. It was a constant issue until it became a "star" dependency. (https://github.com/rdfjs-base/data-model/pull/24#discussion_r479949230)

Started an open discussion in DefinitelyTyped gitter channel to clarify the removal/deprecation process here: https://gitter.im/DefinitelyTyped/DefinitelyTyped?at=609382c70845c416dcc8497b

After a productive discussion with @tpluscode - I agree with the proxy package which has a wildcard dependency on the @rdfjs/types package.
I will be merging this PR now that we have resolved how to proceed with the DefinitelyTyped package.

I believe we need a new repo for rdf-js and publishing setup? @rubensworks, you previously published that on NPM...

I believe we need a new repo for rdf-js and publishing setup?

Isn't that the purpose of this repo here? Also #3.

@rubensworks, you previously published that on NPM...

That's just a stub package, we can easily publish over that when we get to that point :-)

Isn't that the purpose of this repo here?

In which case I come back to proposing a monorepo, albeit with one of the two packages really not changing much, and changesets to make publishing easy for maintainers

when we get to that point :-)

we are very close to that point

one of the two packages

What packages do you have in mind?
I see only one package (the one coming from @types/rdf-js).

@rdfjs/types -> the real one we have here right now
rdf-js -> a proxy package

Ah ok, so actually there will be 2 proxy packages: @types/rdf-js will be a proxy to rdf-js, and rdf-js will immediately also be a proxy to @rdfjs/types.
Thanks for the clarification!
Since rdf-js should not need further changes after its initial release, it might be better to just have a separate repo for this, which we can then ignore.

Since rdf-js should not need further changes after its initial release, it might be better to just have a separate repo for this, which we can then ignore.

Yes, also an option :)

Sounds good to me


Remove custom CMake cross compilation for Android.

Cross compilation [for Android] is not special. Compiler tools are built on the host and installed (using CMake, Bazel, via vcpkg,
via pip, etc.). The runtime and target tests are built for the target, referencing host tools where needed using IREE_HOST_BINARY_ROOT. Some parts of the project only build or are only useful on the host, so some configuration like setting IREE_BUILD_COMPILER=OFF is still useful.
This removes our custom CMake code and updates all of our scripts and docs to invoke CMake in two explicit steps: once for the host and once for the target.
Fixes https://github.com/google/iree/issues/4323.
Fixes https://github.com/google/iree/issues/4520.
Fixes https://github.com/google/iree/issues/2494 (tentatively).
Helps with https://github.com/google/iree/issues/3843.

Thanks Scott for taking on this! Overall looks awesome to me. I think we need to update https://google.github.io/iree/get-started/cmake-options-and-variables#cross-compilation too.

Cool, updated that doc too.

Thanks Scott for taking on this! Overall looks awesome to me. I think we need to update https://google.github.io/iree/get-started/cmake-options-and-variables#cross-compilation too.

Cool, updated that doc too.


add className to a column header

hello,
Is there any way to add a className to a column header?
thx

Right now you have to use the customHeadRender method and override the header component of the cell. You can see an example here: https://github.com/gregnb/mui-datatables/blob/master/examples/customize-columns/index.js
However, there's a PR in for a setCellHeaderProps feature (https://github.com/gregnb/mui-datatables/pull/889). If that gets approved, you'd be able to do it by adding the following to the options of the column:
setCellHeaderProps: () => ({className: "whatever-you-want"})


How to inflate fragments into the NavigationBar

The tutorial only showed how to inflate views, but what about fragments?

any suggestion ? please ...

         navigationTabBar.setViewPager(viewPager);
just define a viewpager and setup that , then use above code
to change the fragment when ntb state change use
navigationTabBar.setOnPageChangeListener

https://github.com/Devlight/NavigationTabBar/issues/107


[BUG]: expo-sqlite migrator seems to apply only the first migration

What version of drizzle-orm are you using?
0.30.1
What version of drizzle-kit are you using?
0.20.14
Describe the Bug
When there is multiple migrations, Drizzle seems to only apply the first one.
I have created a minimal reproducible example in this repo.
As I said in the README of the repo, I have tested two cases:

First one with two migrations. The first migration creates a table with a TEXT column id. The second migration changes the id column to INTEGER. The result is that the id is a string, which is the type of the first migration. The second migration is not applied.
Second one with only one migration. The migration creates a table with a TEXT column id. The result is that the id is a number, as expected.

That's why I think that the issue comes from the fact that there is multiple migrations and that Drizzle only applies the first one.
Expected behavior
I would expect that all migrations are applied.
Environment & setup
"babel-plugin-inline-import": "^3.0.0"
"expo": "~50.0.5"
"expo-sqlite": "~13.3.0"
"react": "18.2.0"
"react-native": "0.73.4"

Hey @arthur-fontaine! You were almost right. Drizzle only applied the first query from the second migration. To work correctly, you need to separate all the queries using --> statement-breakpoint as shown below:
CREATE TABLE `messages_temp` (
    `id` INTEGER PRIMARY KEY NOT NULL,
    `text` TEXT
);
--> statement-breakpoint
INSERT INTO `messages_temp` (`id`, `text`)
SELECT CAST(`id` AS INTEGER), `text`
FROM `messages`;
--> statement-breakpoint
DROP TABLE `messages`;
--> statement-breakpoint
ALTER TABLE `messages_temp` RENAME TO `messages`;

Thanks for your response @RomanNabukhotnyi. I was not aware about this statement-breakpoint, so I guess it is not a bug as I said.
However, I find this is not very clear. When I generated the migration, Drizzle generated a file with this content:
/*
 SQLite does not support "Changing existing column type" out of the box, we do not generate automatic migration for that, so it has to be done manually
 Please refer to: https://www.techonthenet.com/sqlite/tables/alter_table.php
                  https://www.sqlite.org/lang_altertable.html
                  https://stackoverflow.com/questions/2083543/modify-a-columns-type-in-sqlite3

 Due to that we don't generate migration automatically and it has to be done manually
*/

The message is very clear about why Drizzle cannot generate the migration automatically, but does not say how to write it manually.
Especially, there is no mention to the need to use --> statement-breakpoint. The documentation mention it (not even directly) in configuration documentation (here and here), but my first reflex when I saw this message was far from searching in this part of the documentation.
Maybe a guide that explains the needs to write a correct manual migration would be nice?

Opened a PR to update the error message: https://github.com/drizzle-team/drizzle-orm/pull/2871


[core] Expire snapshot should skip branches create snapshot.

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

If the snapshot is not deleted here, when will it be cleared?

If the snapshot is not deleted here, when will it be cleared?

@JingsongLi @LinMingQiang  Maybe we both need to merge our PRs.

Please rebase master.

Please rebase master.

done.

@LinMingQiang Can we remove this feature? Branches can only be created through tags, or completely new branch (without inheriting data from the main branch).


Fix E2E tests

Summary
This little guy was added recently:

This makes the cy.get(.icon-account-plus-outline) return two elements instead of one, so clicking on it was ambiguous. I simply isolated the calls to the checklist element itself.
Let's see if CI passes.
Ticket Link
--

Skipping QA as there are no code changes in the product.


CKEditor: this.instance.editable is not a function

Describe the bug

Currently upgrading from PrimeFaces 5.1 to 11.0
Tried with both 11.0.2 and 11.0.3

Editor appears to be functioning correctly, but throws this error. I discovered this error on a component within a dialog. I tried outside of a dialog and I get the same error. Once the component in the dialog is rendered, the screen is broke.

I noticed some differences in filenames between my local instance and the showcase.
local

showcase

Reproducer
No response
Expected behavior
No response
PrimeFaces Extensions version
11.0.3
JSF implementation
Mojarra
JSF version
2.2
Browser(s)
No response

Working fine for me. Unzip this reproducer:  pfe-842.zip
Run mvn clean jetty:run and navigate to http://localhost:8080/primefaces-test/
Running Mojarra 2.2, PF 11, PFE 11.0.4

Well, turns out that I needed to upgrade resources-ckeditor. I only figured that out because I was looking for transitive dependencies containing "ck" and it caught my attention. I didn't see it mentioned in the showcase or anywhere else really. Seems like an important detail ;)

Yeah sorrry we have it right on our README.MD: https://github.com/primefaces-extensions/primefaces-extensions   CKEDitor and MonicoEditor are separate JARS.

Doh! I don't know how I missed that! I appreciate the speedy responses! 👍

Let me know if you get to the bottom of your other issue as well.


Filtering terms in model: Confusing /__entryType__/filteringTerms.json files

FilteringTerms and filters are still confusing. One of the areas is the existence of filteringTerms.json files (e.g. in biosamples) which are supposedly placeholders for information files about the available filtering terms for the entry type but do not constitute an endpoint. So it seems that they are for internal use only (and anyway most probably would be kept in a database or generated on the fly).
Proposals:

delete filteringTerms.yaml / .json
optionally add a /filtering_terms endpoint to endpoints, for each entity where filters apply, e.g. /biosamples/filtering_terms/, additionally to /filtering_terms, to list all applying to the given scope

I would rather add
"scope": {
    "type": "array",
    "items": {
        "type": "string"
    }
}

property to the beaconFilteringTermsResults.json.
so we would define entryTypes for filters and do not need many endpoints.
the /filtering_terms endpoint will have:
{
    "id": "LOINC:3141-9",
    "label": "Weight",
    "type": "alphanumeric",
    "scope": ["individual", "biosamples", ...]
}

I think this would simplify both, implementation and usage.
Best,
Dmitry

@redmitry Yes, IMO also a good option (actually my preferred one). But the form in which to do this is not clear because there are some open questions:

Can there be several scopes (and why would there)?
Does the scope apply to the object in the model (i.e. the filter matches a parameter there) or to the entry type requested? Not the same; the model definition would just be a hint for where this is processed; the entry type use could mean that the filter could be applied somewhere else to filter the entry type indirectly (e.g. variants for a biosample parameter).
Do we want to hint at the precise scope, i.e. the parameter in the entry type's schema in the default model? This seems like a good option but this could be confusing for implementers and also would be problematic for alternative models etc.
Also: Do we need/want a scope in the filter's query part at all? One instance comes to my mind (DUO codes) but this may be a bit constructed...

For me in summary I'd rather see a flexible use where the terms in the beaconFilteringTermsResults have some (optional) information about the scope they apply to, potentially w/ parameter (e.g. biosamples.histologicalDiagnosis) but more for informational purposes. So a solution like above would be one option.
There had also been some discussion at https://github.com/ga4gh-beacon/beacon-v2/issues/79#issuecomment-1589006540 (w/o final resolution).

I also like the approach that @redmitry has done with filtering terms. I think it would fit better the idea of filters we are applying in beacon and would help the user to quicker find what can he filter and where. Just one observation, wouldn't the scope be defined better an object than an array?, like this:
"scope": {
    "type": "object",
    "items": {
        "type": "string"
    }
}

On the other hand, on @mbaudis observations, I agree that giving a scope hint can be problematic if we think in alternative models, but as you said we can add it to be optional, not required. But I can think of some examples (in fact we have them in our reference implementation) where an ontology applies to two different scopes, like ethnicities/diseases/sex ontologies in individuals and cohorts.

Good note about the examples (sex, ethnicities...). Another argument for having entities in the filteringTerms - but not for queries since you'd either query cohorts or individuals. I think the use of query aggregation here across entry types (variants for a certain diagnosis, biosamples from male subjects ...) does not interfere for these examples since there is a difference between collection schemas and data records.

Can there be several scopes (and why would there)?

The filters are to be applied to particular entry types, so IMO it's reasonable to enumerate (limit) their scopes.

Does the scope apply to the object in the model (i.e. the filter matches a parameter there) or to the entry type requested?

IMO, the scope defines the entry type it applies, not the parameter. The parameter in particular entry type may differ in different implementations (mongo, sql, omop, etc.).
The reference implementation uses "scope" attribute in the filtering_terms to provide "mongodb" parameter. issue #79
Again, at the moment, there is no "scope" parameter in filtering terms.
Alphanumeric filters may require more complex solutions than just path to the property. For instance, here is java implementation filter:
{
    "id": "LOINC:3141-9",
    "label": "Weight",
    "type": "alphanumeric",
    "query": "{'measures': {'$elemMatch': {'assayCode.id': '$$id', 'measurementValue.value': {$$operator: $$value}}}}}"
}

Note, that "query" is filtered out when exposed by "filtering_terms" (we just use the same format for configuration).

Not the same; the model definition would just be a hint for where this is processed; the entry type use could mean that the filter could be applied somewhere else to filter the entry type indirectly (e.g. variants for a biosample parameter).

Well, the idea that "scope" defined in the query corresponds to "scope"s defined in filtering_terms.

Do we want to hint at the precise scope, i.e. the parameter in the entry type's schema in the default model? This seems like a good option but this could be confusing for implementers and also would be problematic for alternative models etc.

Parameters in the entry should be out of scope, IMO. Beacon implementation may generate beacons dynamically and use other query languages or whatever.

Also: Do we need/want a scope in the filter's query part at all? One instance comes to my mind (DUO codes) but this may be a bit constructed...

This could provide the choice in a case of complex query. Imagine we have say "age" filter which may be applied to two entities (e.g. biosamples and individuals).

We are having several parallel discussions here, which, usually, ends up in some threads not being closed.
I would suggest to split the discussion in three different ones:

Keeping or not the filteringTerms.yaml inside every entry type folder
Making listing the filtering terms vs using filtering terms more homogeneous
Having multiscope in the filterTerm definition

Makes sense?


Move test tooling to Jest

Istanbul has been deprecated:

Deprecation Notice: this version of istanbul is deprecated, we will not be landing pull requests or releasing new versions. But don't worry, the Istanbul 2.0 API is now available and is being actively developed in the new istanbuljs organization.

This is preventing some new tests from being written, such as those in https://github.com/cfpb/cfgov-refresh/pull/3830.
The Istanbul 2.0 API is significantly different. After chatting with @sebworks, instead of migrating istanbul, we could use jest, which largely keeps the same syntax we have, but includes jsdom and istanbul code coverage.
Additions

Adds default Babel config to package.json.
Adds Jest config to package.json.

Removals

Removes empty tests (Jest doesn't allow this).
Removes jsdom from package.json
Removes gulp-istanbul from package.json
Removes mocha from package.json

Changes

Changes gulp test task to run Jest for JS unit tests.
Changes o-table-row-links.js to set window URL with window.location.assign(…) from window.location = … so that the location method can be mocked in tests.
Changes o-table-row-links-spec.js to check for calls to window.location.assign(…) instead of checks of the URL.
Removes tests path from the gulp config in favor of retrieving the path through the environment.js.

Testing

Run ./frontend.sh
Run gulp unit:test to run all JS unit tests.
Run gulp test:unit --specs=js/modules/ to run a directory of specs.
Run gulp test:unit --specs=js/modules/o-table-row-links-spec.js to run a single spec.
Open test/unit_test_coverage/lcov-report/index.html to see code coverage report.

Todos

Chai and Sinon can be replaced with Jest too.

Nice work on this, @anselmbradford


Excess angular momentum when 2D kinematic body rotates beyond 180 degrees

Godot version:
3.2.2-stable, also latest master as of this writing (git commit 443686d724ce8ac58dcdf09389e9f996aee866c1).
OS/device including version:
All (tested on Ubuntu 20.04, Windows 10).
Issue description:
When a KinematicBody2D rotates beyond 180 degrees, any RigidBody in contact with it flies away.
This is because the 2D physics server calculates angular momentum using the difference between the previous update's angle and the current angle. When rotating beyond 180, the angle wraps around to -180, and the server calculates a difference of nearly 360 degrees between frame, resulting in a very high angular momentum. This is then propagated to colliding physics bodies.
See reddit thread: https://www.reddit.com/r/godot/comments/ifxtf5/is_this_something_that_should_be_fixed_for/
Steps to reproduce:
Have a KinematicBody2D rotating to nearly 180 degrees. Place a RigidBody on top. As soon as the KinematicBody2D passes 180 degrees of rotation, the RigidBody will fly away with large amounts of momentum.
Minimal reproduction project:
See https://github.com/Tobzster/KinematicBody2D_Angular_Velocity_Glitch from the author of the reddit thread.

I will submit a PR as soon as I figure out how to do so :).


UnhandledPromiseRejectionWarning: TypeError: Cannot destructure property warnings of 'undefined' or 'null'.

🐞 Bug report
Command (mark with an x)

- [x ] build

Is this a regression?

 Yes, the previous version in which this bug was not present was: 8.0.0
Description

Whenever there's an error in a scss-file connected to a component, childCompilation becomes undefined and hence can't be destructed. err is provided. So I guess you just need handle the empty childCompilation case.
#angular-cli/packages/ngtools/webpack/src/resource_loader.ts:109
const { warnings, errors } = childCompilation;

🔬 Minimal Reproduction
https://github.com/JonWallsten/angular-bug
Step 1: npm i
Step 2: npm run build
Step 3: ...
Step 4: Profit!
🔥 Exception or Error
UnhandledPromiseRejectionWarning: TypeError: Cannot destructure property `warnings` of 'undefined' or 'null'.
    at childCompiler.compile (C:\Users\jway52\repo\angular-devkit-bug\node_modules\@ngtools\webpack\src\resource_loader.js:81:46)
    at compilation.seal.err (C:\Users\jway52\repo\angular-devkit-bug\node_modules\webpack\lib\Compiler.js:666:23)
    at hooks.additionalAssets.callAsync.err (C:\Users\jway52\repo\angular-devkit-bug\node_modules\webpack\lib\Compilation.js:1369:13)
    at _err0 (eval at create (C:\Users\jway52\repo\angular-devkit-bug\node_modules\tapable\lib\HookCodeFactory.js:33:10), :9:1)
    at _evaluate.then.catch.err (C:\Users\jway52\repo\angular-devkit-bug\node_modules\@ngtools\webpack\src\resource_loader.js:70:39)
    at process._tickCallback (internal/process/next_tick.js:68:7)

🌍 Your Environment

Angular CLI: 8.2.0
Node: 10.16.0
OS: win32 x64
Angular: 8.2.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.802.0
@angular-devkit/build-optimizer   0.802.0
@angular-devkit/core              8.2.0
@angular-devkit/schematics        8.2.0
@angular/cdk                      8.1.2
@angular/http                     8.0.0-beta.10
@angular/material                 8.1.2
@ngtools/webpack                  8.2.0
@schematics/angular               8.2.0
@schematics/update                0.802.0
rxjs                              6.5.2
typescript                        3.5.3
webpack                           4.39.1

I just noticed this was fixed and committed 4 days ago.

@JonWallsten   do you know what in scss files  might cause this issue? i only get this error when i try to build for angular universal 'npm run build:ssr'

@JonWallsten do you know what in scss files might cause this issue? i only get this error when i try to build for angular universal 'npm run build:ssr'

Unfortunately it can be anything that the linter doesn't pick up. In my case it was : instead of ; and then multiple dots before the class.
The easiest way to check is to edit this file<EMAIL_ADDRESS>and add return reject(err); on the line before the error occurs. It will give you all info you need.


Intellisense breaks completely when using System.Xml.XmlWriter

Environment data
dotnet --info output:

.NET Command Line Tools (1.0.0-preview2-003121)
Product Information:
Version:            1.0.0-preview2-003121
Commit SHA-1 hash:  1e9d529bc5
Runtime Environment:
OS Name:     Windows
OS Version:  6.1.7601
OS Platform: Windows
RID:         win7-x64

VS Code version: 1.3.1
C# Extension version: 1.2.2
Steps to reproduce

Create a new project with dotnet new.
Open it in VS Code.
Add the following lines to Main() in Program.cs:

var sw = new System.IO.StringWriter();
var writer = System.Xml.XmlWriter.Create(sw);

Expected  behavior
Intellisense should provide autocompletion for methods of writer.
Actual behavior
Intellisense breaks completely and only shows "loading" ("wird geladen" in German).

After that, Intellisense won't even work for simple things like Console.WriteLine anymore. I have to reopen VS Code completely to get it working again, but the error can be reproduced indefinitely with the code above.
OmniSharp Log shows instances of:

[ERROR:Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware] An unhandled exception has occurred: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.

Hi, could you try the latest beta release, v1.3.0-beta? I just tried that version and couldn't reproduce this issue.

Installed v1.3.0-beta1, but unfortunately the problem is still there.

EDIT: Nevermind, I still had an instance of VS Code open. Problem seems fixed in the beta!

That's fantastic news!


there is no padding token in vocabulary?

I didn't find a padding way of tiktoken

The vocabularies of the tokenisers that come builtin correspond to the tokenisers used in production by OpenAI's models.
If you want to define your own encoding with a special padding token, please feel free too! Just pass a value to special_tokens when constructing your encoding.


Add set_in, update_in

Analogous to Clojure's assoc-in, update-in
Follow-up to https://github.com/Suor/funcy/pull/28#issuecomment-77737258

Hello and thanks for your efforts.
You, however, implemented mutating set_in() and update_in(), which kind of not funcy scope. Funcys set_in() should behave like clojures assoc-in: create a new collection based on passed one, with a bit of it altered.
Also, please, change argument names to be more in line with the rest of the library, like here - https://github.com/Suor/funcy/commit/e6bd6af1f803c0778ae8a6a335df6d58822727a7

@Suor, sorry for the late response, I didn't get an email notification for this.
Hmmm, to create a new collection, I would have to use copy.deepcopy, is that okay performance-wise? Or any other ideas?
Will change the arg names in the next push.

No deep copies, new collection should share parts with old one. That's the point. E.g.:
d = {
    'a': {'x': 1, 'y': 2},
    'b': {'z': 3}
}
set_in(d, ['a', 'x'], 10) == {
    'a': {'x': 10, 'y': d['a']['y']},
    'b': d['b']
}

Do you need more help with this? Or more clarifications?


redefinition of module 'YogaKit'

Description
redefinition of module 'yoga'
redefinition of module 'YogaKit'
Version
0.69.4
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 12.4
CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
Memory: 2.16 GB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK:
API Levels: 23, 26, 27, 28, 29, 30, 31
Build Tools: 26.0.2, 27.0.3, 28.0.3, 29.0.2, 29.0.3, 30.0.3, 31.0.0
System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom_64, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google APIs ARM 64 v8a, android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play ARM 64 v8a, android-31 | Google Play Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8193401
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: 11.0.15 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.4 => 0.69.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
npx react-native init TestProject --template react-native-template-typescript
npx react-native run-ios
Snack, code example, screenshot, or link to a repository
TestProject/ios/Pods/Headers/Public/YogaKit/YogaKit.modulemap:1:8: redefinition of module 'YogaKit'
module yoga {
TestProject/ios/Pods/Headers/Public/yoga/Yoga.modulemap:1:8: redefinition of module 'yoga'
module YogaKit {
TestProject/ios/Pods/Headers/Public/YogaKit/YogaKit.modulemap:1:8: redefinition of module 'YogaKit'
module yoga {

there was a conflict version, I have tried to remove the react native & reinstall, worked for me

@hiephuynhFDS What does it mean that there was a conflict version? I have deleted node_modules and package-lock.json and reinstalled. Is that sufficient to address the "conflict version" issue?


Update Readme - Copy Migrations

Add Info about how to: Copy the mautic rails engine migrations

seems not required, the migration is executed it stay inside the engine...


leafmap buttons have incorrect sizing

From https://github.com/googlecolab/colabtools/issues/498#issuecomment-917335447
The layout of the leafmap buttons do not match the JupyterLab appearance.

This is caused by this package is currently targeting Widgets version 5.0.0a which notably removes the DOMWidgetView.pWidget property.
pWidget is being referenced in https://github.com/jupyter-widgets/ipyleaflet/blob/b48351977f8a96b008c25a859e9ff7516ccbfa4e/js/src/controls/WidgetControl.js#L95.

The correct fix for this issue is for this package to publish proper support for @jupyter-widgets/base:4.0.0.
The easy hack for this issue is to shim in the deprecated pWidget getter removed in https://github.com/jupyter-widgets/ipywidgets/commit/f5a67f8486bb78c5001088e3d87495e23f240457#diff-efb19099381ae8911dd7f69b015a0138d08da7164512c1ee112aa75100bc9be2L890.

The fix should now be live.


Using GREYHostApplicationDistantObject with CocoaPods Setup

I've setup EG2 using CocoaPods, and ensured the base functionality works. I then followed the instructions for the whitebox setup.

When attempting to interact with the target app, I get the following error: caught "NSInvalidArgumentException", "*** -[NSProxy doesNotRecognizeSelector:<method_name>] called!"
With the CocoaPods setup, do I need to create the helper bundle, and add all of the linking as specified in the other instructions? Could someone add some clarity around this?

Can you try using GREY_REMOTE_CLASS_IN_APP() ?
On Fri, Feb 21, 2020 at 1:33 PM Ethan Wolfe<EMAIL_ADDRESS>wrote:

I've setup EG2 using CocoaPods, and ensured the base functionality works.
I then followed the instructions for the whitebox setup
https://github.com/google/EarlGrey/blob/earlgrey2/docs/swift-white-boxing.md
When attempting to interact with the target app, I get the following
error: caught "NSInvalidArgumentException", "*** -[NSProxy
doesNotRecognizeSelector:<method_name>] called!"
With the CocoaPods setup, do I need to create the helper bundle, and add
all of the linking as specified in the other instructions? Could someone
add some clarity around this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/EarlGrey/issues/1201?email_source=notifications&email_token=ADRQEFKON5FULBLZAT2F27TREBCCZA5CNFSM4KZKYP22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPNHOOQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRQEFN6MYJ2IOL62CFOQHLREBCCZANCNFSM4KZKYP2Q
.

@tirodkar Am I able to call that method from Swift? I'm unable to find any documentation around how to use that.

Look at
https://github.com/google/EarlGrey/blob/earlgrey2/Tests/Functional/Sources/Swift/SwiftTests.swift#L234
.
On Mon, Feb 24, 2020 at 9:38 AM Ethan Wolfe<EMAIL_ADDRESS>wrote:

@tirodkar https://github.com/tirodkar Am I able to call that method
from Swift? I'm unable to find any documentation around how to use that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/EarlGrey/issues/1201?email_source=notifications&email_token=ADRQEFK5UV26CIKHHBY77J3REQAYZA5CNFSM4KZKYP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMY2QWY#issuecomment-590456923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADRQEFJ2KIH4ZD4CD57HAW3REQAYZANCNFSM4KZKYP2Q
.

@tirodkar Ok, so I tried
let targetApp = GREYRemoteClassInApp(classVal: UIApplication.self).shared
targetApp.setStatusBarOrientation(UIInterfaceOrientation.landscapeLeft, animated: false)

And got the following error:
caught "NSInvalidArgumentException", "*** -[NSProxy doesNotRecognizeSelector:grey_trackAsRootViewControllerForWindow:] called!"
I was able to perform validations, though. The following worked:
let targetApp = GREYRemoteClassInApp(classVal: UIApplication.self).shared
XCTAssertTrue(targetApp.statusBarOrientation.isPortrait)

What do I need to do to manipulate the target app? Is there any setup I am missing?

@tirodkar Using EG2, are we able to modify the application under test? For example, If I would like to change a windows root view controller, or inject a mocked api client into the app, does using the remote access to the app under test allow me to do that?

I am trying to do the same thing.  I have setup my targetApp (as above):
let targetApp = GREYRemoteClassInApp(classVal: UIApplication.self).shared

let scene = targetApp
                .connectedScenes
                .filter { $0.activationState == .foregroundActive }
                .compactMap {$0 as? UIWindowScene}
                .first

However, I get a crash on filter { $0.activationState == .foregroundActive } :
Could not cast value of type 'EDOObject' (0x10fc02af8) to 'UIScene' (0x7fff898a50b0).
2020-03-23 17:57:25.144628-0700 SandboxIntegrationTests-Runner[9153:3048750] Could not cast value of type 'EDOObject' (0x10fc02af8) to 'UIScene' (0x7fff898a50b0).

My intention was to find the keyWindow of the scene:
let window = scene?.windows.filter({ $0.isKeyWindow }).first
and then set the root controller of the window to the view I am trying to test.
Any thoughts on how to modify the application under test similar to EarlGrey?

@tirodkar Using EG2, are we able to modify the application under test? For example, If I would like to set a window's root view controller, or inject a mocked api client into the app, does using the remote access to the app under test allow me to do that?

We

@tirodkar Ok, so I tried
let targetApp = GREYRemoteClassInApp(classVal: UIApplication.self).shared
targetApp.setStatusBarOrientation(UIInterfaceOrientation.landscapeLeft, animated: false)

And got the following error:
caught "NSInvalidArgumentException", "*** -[NSProxy doesNotRecognizeSelector:grey_trackAsRootViewControllerForWindow:] called!"
I was able to perform validations, though. The following worked:
let targetApp = GREYRemoteClassInApp(classVal: UIApplication.self).shared
XCTAssertTrue(targetApp.statusBarOrientation.isPortrait)

What do I need to do enable the manipulation of the target app (ex. set the root view controller for a specific test)? Is there any setup I am missing?

We are observing this behavior as well when setting up a basic project with Pods. Did you manage to find a solution?


convert-pth-to-ggml.py expects 2 parts for ALPACA-LORA-13B, but it has only one

the export-from-huggingface.py scripts only generates one checkpoint file (consolidated.00.pth) for ALPACA-LORA-13B, but when I then run python3 ./scripts/convert-pth-to-ggml.py models/ALPACA-LORA-13B 1 0
I get the following output:
{'dim': 5120, 'multiple_of': 256, 'n_heads': 40, 'n_layers': 40, 'norm_eps': 1e-06, 'vocab_size': -1}
Namespace(dir_model='models/ALPACA-LORA-13B', ftype=1, vocab_only=0)
n_parts = 2

Processing part 1 of 2

[...]
Processing part 2 of 2

Traceback (most recent call last):
  File "./scripts/convert-pth-to-ggml.py", line 274, in <module>
    main()
  File "./scripts/convert-pth-to-ggml.py", line 267, in main
    model = torch.load(fname_model, map_location="cpu")
[...]
FileNotFoundError: [Errno 2] No such file or directory: 'models/ALPACA-LORA-13B/consolidated.01.pth'

The old version of this script was handling this correctly.

Also I get this error when I try to run it:
[Info]: Func('Model') loading model(='ALPACA-LORA-13B') from ./models/ALPACA-LORA-13B/alpaca-lora-q4_0.bin - please wait ...
[Info]: Func('KVCacheBuffer::init') kv self size  =  512.00 MB
[Error]: Func('Model') invalid model file ./models/ALPACA-LORA-13B/alpaca-lora-q4_0.bin (bad magic)
[Error]: Func('FastLlama::Params::build') Unable to load model
Traceback (most recent call last):
  File "examples/python/example-alpaca.py", line 11, in <module>
    model = Model(
  File "examples/python/build/fastllama.py", line 208, in __init__
    raise RuntimeError("Unable to load model")
RuntimeError: Unable to load model
Exception ignored in: <function Model.__del__ at 0x7f4e2d3cb310>
Traceback (most recent call last):
  File "examples/python/build/fastllama.py", line 404, in __del__
    signal.signal(signal.SIGINT, signal.SIG_DFL)
  File "~/miniconda3/envs/fastllama/lib/python3.8/signal.py", line 47, in signal
    handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
TypeError: signal handler must be signal.SIG_IGN, signal.SIG_DFL, or a callable object

Ah yes,
Good catch. I was trying to move away from my hacky implementation. In our old method, for large models, creating just one file was not a good idea because of high memory usage during conversion and quantization steps.
I wanted to add a way to split the models into smaller parts during the exporting part.
Please give me some time I will get it done by tonight.

Meanwhile you can try the sync_llama branch for now.
All ggml models exported to huggingface work now. Been testing Vicuna and Alpaca 7B and 13B

This should be fixed in the new PR, can you please check?

Fixed!


Fix cart and customer updates on login

When user logs in then his cart (created for Anonymous user) should be preserved and merged with authenticated user's cart (if any). It doesn't happen now as session_key used by update_cart_after_login is already a new key (due to a call to request.session.cycle_key() in auth->login). Tests for this behaviour are also invalid as these are not triggering default login view.

Has anything changed within Django?

I haven't found much changes regarding cycle_key call on login since 1.8. Maybe there were some changes in previous versions. Anyway it doesn't work now


Export of user list as .CSV

As per feedback:

In the Staff screen add a column per user showing the remaining days
to take off. And that is really important.
Good option will be to have "export" to CSV for this table - Name,
Department, Used days, Available Days. That is something values by
Human Resources and Finance as available days are relevant for the
financial sheets of a company!

I suggested CSV as it is simple text file with "," or ";" as separator.
I see there are also Excel libs for exporting. Check this one which looks simple and has example how to create the excel in the memry buffer and directly stream it for download
https://www.npmjs.com/package/node-excel-export

consider also https://github.com/timeoff-management/application/issues/143


hi! i run 'pod playgrounds Alamofire', but i got a error

when i run 'pod playgrounds Alamofire'
A error said '[!] Unable to find host target for Pods-AlamofirePlayground. Please add the host targets for the embedded targets to the Podfile.'
And i add 'target 'Pods-AlamofirePlayground' do ... end ' or ' abstract_target 'Pods-AlamofirePlayground' do' to my profile.But none did work. i got the same error words what like above.
How can i fix it?
my Xcode is 7.3.1, pods is 1.1.0.beta.1
thank you.

This should have been fixed in the latest release 1.2.2 of this plugin, please just update it.


[Feature Request]Export the eval result.

Is your feature request related to a problem? Please describe.
Export the Output as json or some format like that.
Additional context

Hi @random-yang,
Can you please elaborate on your ask here? Do you want to export the outputs of any flow run or just evaluation run(your title says eval result)? Is the provided picutre the outputs of your flow? Can you tell us why you need this feature to help us better underdstanding your scenario?

Hi @random-yang, Can you please elaborate on your ask here? Do you want to export the outputs of any flow run or just evaluation run(your title says eval result)? Is the provided picutre the outputs of your flow? Can you tell us why you need this feature to help us better underdstanding your scenario?

For example, I want to export the table data to a local file with format json, csv...
For a further process. What should I do or do you have a better advice?

Hi @random-yang, Can you please elaborate on your ask here? Do you want to export the outputs of any flow run or just evaluation run(your title says eval result)? Is the provided picutre the outputs of your flow? Can you tell us why you need this feature to help us better underdstanding your scenario?

For example, I want to export the table data to a local file with format json, csv... For a further process. What should I do or do you have a better advice?

@random-yang sorry for the delayed response first. Regarding to the data in your screenshot, currently our UI page does not support an export button to support dump to a file; we might add, but I cannot promise - we can use this issue to track. But there should be a workaround for this.
This UI page is rendered via some API calls, so you can manually call the API to get these data in memory, and dump to your expected format. The API is /v1.0/LineRuns/list, and you shall find more details (such as parameters) from these lines.
NOTE that this is only a workaround as I cannot promise we will not make any change in either API signature or response in the future, please leverage this API carefully; and I believe the better solution is the UI page supports export with a button, which needs some discussions, and time to implementation.

Hi @random-yang, Can you please elaborate on your ask here? Do you want to export the outputs of any flow run or just evaluation run(your title says eval result)? Is the provided picutre the outputs of your flow? Can you tell us why you need this feature to help us better underdstanding your scenario?

For example, I want to export the table data to a local file with format json, csv... For a further process. What should I do or do you have a better advice?

@random-yang sorry for the delayed response first.
Regarding to the data in your screenshot, currently our UI page does not support an export button to support dump to a file; we might add, but I cannot promise - we can use this issue to track. But there should be a workaround for this.
This UI page is rendered via some API calls, so you can manually call the API to get these data in memory, and dump to your expected format. The API is /v1.0/LineRuns/list, and you shall find more details (such as parameters) from these lines.
NOTE that this is only a workaround as I cannot promise we will not make any change in either API signature or response in the future, please leverage this API carefully; and I believe the better solution is the UI page supports export with a button, which needs some discussions, and time to implementation.
Feel free to give it a try, and let me know if this works for your scenario, thank you!

Sounds like it will solve my problem, I'll try it.


bugfix(http): solved request concurrency issue.

Description
Fix for rxjs dependency changes which caused concurrency request failure. (when multiple requests were thrown at the same time, sometimes one or more would fail)

Coverage decreased (-0.01%) to 67.654% when pulling 506615e6e180b236111f4d11525067335eda087a on feature/bugfix-http-concurrency into 56242b11046975aa2957c15caca15f8da7365f83 on develop.

Coverage decreased (-0.01%) to 67.654% when pulling f195107e7046953823047b793f8a08ac59b36723 on feature/bugfix-http-concurrency into 1cd3e49c62a3cc8b03f3f153fc3bb554061e495e on develop.


make python3.8 compatible and fix segfault

with distributed runs number of cpus explode

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@polisettyvarma accept license/cla if you want to merge your changes

@polisettyvarma This is a reminder to please accept the CLA.

Closing as solved by another PR.


Coordinate issues

Hello, thanks for your excellent work, I would like to ask why the habitat coordinate system is used when training on the matterport dataset and the predicted rotation is in the form of yzxw. If I want to use other datasets to train my code, can I place the pose as [x, y, z, qx, qy, qz, qw]?

Hi -- the dataset containing renders on matterport is in habitat coordinates since it is collecting using habitat, i.e. habitat-matterport. As far as using for other datasets and the coordinate convention, I'd recommend you use FAR. It has about half the average error of this work along with indoor and outdoor checkpoints. I think the coordinate should be easier to work with as well!

Thanks for the suggestion, I will follow your suggestion to read another excellent work of yours！


Looks like lib/ dir isn't update(Cloud module did not built).

Describe the bug
In v1.2.1, it seems to be Cloud module was not built(running tsc command)
So this patch #130 did not apply yet.
To Reproduce
Steps to reproduce the behavior:

(in nodejs project) add package

yarn add<EMAIL_ADDRESS>

Look build module file

cat ./node_modules/nature-remo/lib/Cloud.js | grep -A 4 sendSignal

The fix has not been incorporated.

❯ cat ./node_modules/nature-remo/lib/Cloud.js | grep -A 4 sendSignal

    sendSignal(signalId) {
        return __awaiter(this, void 0, void 0, function* () {
            const response = yield this._post(`/1/signals/${signalId}`);
            return response;
        });

Expected behavior
Expected output is here.
❯ cat ./node_modules/nature-remo/lib/Cloud.js | grep -A 4 sendSignal

    sendSignal(signalId) {
        return __awaiter(this, void 0, void 0, function* () {
            const response = yield this._post(`/1/signals/${signalId}/sends`);
            return response;
        });

Can you check if you are building?
Additional context
Add any other context about the problem here.

Thank you for the report.
This should have been included in 1.2.1 but hadn't.
Published new version v1.2.2.

Thank you for publishing new version.
I confirmed that it works with the new version.


test-branch/execute-job/quoted-authorization/2472b17b-02a2-4827-bb79-c5e8ad8dc748

PR for testing e7cbaf075bcf7703a443be12d848f9598554f858

/canonical/self-hosted-runners/run-workflows e7cbaf075bcf7703a443be12d848f9598554f858


Fix ChromePicker layout shift

Add style to ChromePicker to prevent layout shift. Please let me know if this is sufficient. Thank you!

For a visual, attached is a screenshot of the change I made. The ChromePicker opens up over the interface to prevent the layout shift.

Can you also make it shut when clicked somewhere else or after picking the color.

Yes I will work on that feature!

LGTM, Thanks for contributing


chore: convert to module

Let's add the exports field and verify that bpmn-in-color-moddle JSON descriptor can be loaded via import ("assert").

@nikku ready now

Released as v0.2.0


Build the lean code in CI

You'll need to turn actions on for this repository for this to do anything

@googlebot I signed it!


chore: Update controller-runtime to v.0.11.0

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates controller-runtime to v0.11.0.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.925%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
182

Relevant Lines:
424

💛  - Coveralls


Add initial support for Added/Removed/Changed

For some of the colorschemes where diffAdded and diffRemoved were explicitly set up.
Default colors looks ok for most of the bundled colorschemes, however they might be added in the future.

Thanks!


ConsoleCommand

This is a rather raw idea, and perhaps this won't be in the core. But what if we extend the app command model to build a console (itself as a command) that allows to run any of the Bootique commands available to a given app interactively in the console.
This may be useful for jobs, etc., cutting down on the length of commands one needs to retype.
Will also likely need a way to change configuration for commands. Again, very raw idea...

More brainstorming of the console idea. While there can be an app-specific embedded console, perhaps we can start with an external console app called bq that can be a Swiss army knife of Bootique, helping with app launching and auto-completion, bootstrapping new projects, finding dependencies online, running scripts, etc.

I really like where you going with this.

This sounds really awesome.

Some brainstorming on how the console might look like

Start interactive console, but not the app

$ java -jar myapp.jar --console > /tmp/out.txt 2>/tmp/err.txt

> help
> start
> start --config=classpath:someconfig.yml --server
> start &
> status
> check	# Runs healthchecks
> stop
> quit	# stop the app and quit console.

Start the app as usual, with console accessible on a port

$ java -jar myapp.jar --some-command --config=someconfig.yml
$ telnet <IP_ADDRESS> 9357

> help
> status
> check	# Runs healthchecks
> stop 	# stop the app, stay in console
> quit	# quit console without stopping the app.


WIP: Gpl-378 create ont run

Closes #297

TODO:
move resolvers into component
move apollo.js file into graphql
reload runs on create
redirect shows alert message
refactor status in flowcell component
check if extra variable is required in gql queries

Is there any chance we could move the apollo.js file to the graphql folder just to keep it all in one place. As we start adding more logic to this it feels like a more logical place to put it.
UPDATE
Looked into this, and I think an apollo.js config file is required at the root. I've refactored code of it into the graphql folder

Weird. I tried it in my branch and it was ok. No matter. It is pretty clean anyway.


deps sweep

All seems to work!

FYI, grunt-vulcanize seems to be the only one we can't upgrade because we're not on Polymer 1.0. That seems like a larger job than I'm willing to tackle right now :-)

:+1:


[Feature Request] Open dropdown on hover

Is your feature request related to a problem? Please describe.
The feature request is related to a ux problem.
Describe the solution you'd like
As a user, when I see a dropdown menu in the nav bar i'd expect it to open on hovering over it.
Ideal would be:

Hover over dropdown trigger
Dropdown opens
Mouse leaves the dropdown trigger and items
Dropdown closes

This feature could be implemented as a new component.
Describe alternatives you've considered
There isn't a real alternaive.
Screenshots or Videos
No response

https://codesandbox.io/p/sandbox/sffwws?file=%2FApp.jsx%3A1%2C1&utm_medium=sandpack

https://codesandbox.io/p/sandbox/sffwws?file=%2FApp.jsx%3A1%2C1&utm_medium=sandpack

In the example, it is only possible to open the dropdown with an onClick event instead of an onHover event.

It seems Codesanbox is not working properly, here's the code
import React from "react";
import {Dropdown, DropdownTrigger, DropdownMenu, DropdownItem, Button} from "@nextui-org/react";

export default function App() {
 const [isOpen, setOpen] = React.useState(false)

  return (
    <Dropdown isOpen={isOpen}>
      <DropdownTrigger
        onPointerEnter={() => setIsOpen(true)}
        onPointerLeave={() => setIsOpen(false)}
      >
        <Button
          variant="bordered"
        >
          Open Menu
        </Button>
      </DropdownTrigger>
      <DropdownMenu aria-label="Static Actions">
        <DropdownItem key="new">New file</DropdownItem>
        <DropdownItem key="copy">Copy link</DropdownItem>
        <DropdownItem key="edit">Edit file</DropdownItem>
        <DropdownItem key="delete" className="text-danger" color="danger">
          Delete file
        </DropdownItem>
      </DropdownMenu>
    </Dropdown>
  );
}


Behavior of Write() with line-feed at its end is different/faulty

Following visible test will show the faulty behavior:
$proxy = $this->getProxy('P', 'pt', 'A4');
$proxy->AddPage();
$proxy->SetFont('arial', '', 10);
$proxy->Write(8, "A\n");
$proxy->Write(8, "B");
$this->assertProxySame($proxy, 0.15, 72);

Also this one:
public function testWriteWithNewLines()
{
    $proxy = $this->getProxy();

    $proxy->SetFont('arial');
    $proxy->AddPage();
    $proxy->Write(2, 'A simple test');
    $proxy->Write(2, ".\n\nBest regards,\n\nTest Team");

    $this->assertProxySame($proxy, 14.64);

}


Regression in cursor blink/display behavior on navigation

There is a regression that's popped up somewhere in the fast track builds between 18214 and 18252 regarding the behavior of the displayed caret/cursor.
Behavior was observed under fish, the long and short of it is that the cursor disappears when navigating within the commandline buffer left and right, and you don't know where it's positioned (zero visual feedback) until the blink timeout elapses 0.5/1s later and the cursor reappears, extremely hindering productivity.
Previous versions of Windows (18214/17763) would keep the cursor visible while keying left/right, regardless if it was in block or underline mode. Under 18252, the cursor immediately vanishes completely on left/right navigation, and does not reappear until navigation has ceased and the timeout elapses.

I believe this is the same as Microsoft/console#269.

I believe you're right. Thanks @Erebuxy .


One-click installer fails to find VS code path

When running the one-click installer on Windows 10, I encountered an issue installing the VS Code extension. The script detected that I already have VS Code installed, but when it attempts to run it in order to install the extension via
C:\Program Files (x86)\Microsoft VS Code\bin\code
it was unable to locate the path.  I've got VS Code under
C:\Program Files\Microsoft VS Code\bin\code
It looks like the script, at line 18 of
/out/tasks/task-installation.js
defines the path like so:
_vsCodeExePath = _path2.default.join(process.env['ProgramFiles'], 'Microsoft VS Code', 'bin', 'code');
I was able to proceed through the rest of the script by manually installing the extension to VS Code, but wanted to point this out, since I didn't see it listed in troubleshooting section.

@pemj Did you use our latest install package? If vscode with version newer than 1.13.1 detected. We will install extension by "code --install-extension xxxx" instead of full vscode path


HTML - Quicksuggestions do not work (without pressing CTRL + Space) for ID and Name when using Emmet

VSCode Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
OS Version: Darwin x64 19.4.0
macOS version: 10.15.4

Steps to Reproduce:

New HTML doc
Type inp and then press TAB
As expected you get the full, pre-filled and text pre-selected <input type="text" name="" id="">
If one now types, text gets replaced with the new characters, as expected
Pressing Tab automatically goes in between the " " of name=, as expected
If you then start typing, you do not get any auto-complete suggestions. So, if you have had a <label for="test1">, and then an <input..., you would not get the test1 suggestion when typing in the "pre-selected" syntax.
If you, however, after pressing tab, press the left arrow and then right arrow to move the caret back and forth a character(and therefore losing the pre-selection) you now get the auto-suggestion when typing.
CTRL+Space work fine at step 6.

Does this issue occur when all extensions are disabled?: Yes
Settings.json:
{
    "editor.quickSuggestions": {
        "other": true,
        "comments":true,
        "strings": true,
    },
    "editor.acceptSuggestionOnCommitCharacter": true,
    "editor.suggest.statusBar.visible": true,
    "editor.acceptSuggestionOnEnter": "on",
    "editor.quickSuggestionsDelay": 10,
    "editor.suggestOnTriggerCharacters": true,
    "editor.tabCompletion": "on",
    "editor.suggest.localityBonus": true,
    "editor.suggestSelection": "recentlyUsed",
    "editor.wordBasedSuggestions": true,
    "editor.parameterHints.enabled": true,
}

Screen Recording 2020-04-23 at 15.58.28.mov.zip

Try setting: "editor.suggest.snippetsPreventQuickSuggestions": false to enable suggestions while completing snippets.

Nice one @gjsjohnmurray . That was it. Ta 👍


Using a channel to asynchronously receive a reply from StateMachine::apply().

The reply should happen asynchronously, somehow. Make this method synchronous
and instead of using the result, pass a channel where to post the completion.
The Raft core can then collect completions on this channel and update the client
with the result once all the preceding operations have been applied to the state
machine. This way we'll reach operation pipelining w/o the need to wait for the
completion of each operation inline.
https://github.com/datafuselabs/openraft/blob/46644c8409c7dff627c991cc65849507ad5265b3/openraft/src/storage.rs#L324-L329

Just yesterday, we discussed it with the colleagues what this means in detail (also for the snapshot, that's similar).
In fact, we need a two-stage process: first, the state machine update or snapshot is triggered on the &mut self to prepare the operation. This may even complete the operation fully, but on the other hand, it may need to (sometimes) synchronize, so it still needs to be async. As a result, we can return a 3-state value with immediate result, immediate error or a boxed dyn Future + 'static (e.g., representing a task to be executed in the background). Then, for all such futures, we can start background tasks with appropriate report back to the main loop of the Raft core. The started tasks (and also immediately completed, if there was no future reported) can be kept in a List or Deque or similar structure. Since they are produced in-order, the structure grows to the right.
When the task completes, as mentioned, it will send the completion message. If it is at the head of the queue, then we can report the completion back to the client and repeatedly check the new head. I.e., if we have tasks 1,2,3,4,5 completed out-of-order 2,3,5,1,4, then the completion of 2, 3 and 5 will do nothing, completion of 1 (head of the outstanding requests) will send the completion of 1 to the client and then check the remainder of the queue, i.e., also send completions for already-completed requests 2 and 3. 4 is incomplete, so the processing stops there. Following the same logic, when 4 completes, it will send completions for 4 and 5 to the client.

As a result, we can return a 3-state value with immediate result, immediate error or a boxed dyn Future + 'static (e.g., representing a task to be executed in the background).

So this is what you expected the API to be, right?
// where R: AppResponse
type ApplyResult = Result<R, Error>;

enum Either<T, U>{
    Left(T),
    Right(U),
}

fn apply_to_state_machien() -> Either<ApplyResult, Box<dyn Future<Output=<ApplyResult>>>

If it is, what about making the return value just a Future?

An implementation could just return a Future that is already ready for poll() if the apply can be done at once.
And it could also return a Future in which the apply will actually be done.

With GAT, will it be as efficient as returning an immediate result?

Yes, something like that. Simple Future won't work, since the Future which needs to be deferred to a background task must be 'static. Further, the implementation may need to await something. Concretely, we have exactly this situation in our code: the modification preparation needs write access (via &mut self), but also needs to await allocation of resources (which is typically immediate, but not always). Then, based on that, it can either execute the request immediately or build the 'static Future to be awaited in a task.

Then, after resources are acquired, based on other factor, it can either execute the request immediately or build the 'static Future to be awaited in a task.

Is it all right to return a ready Future if it can execute the request immediately?
This would make the API simpler. Unless in this way it affects the performance.

Is it all right to return a ready Future if it can execute the request immediately?
This would make the API simpler. Unless in this way it affects the performance.

That's true, but not sufficient.
The problem is as follows:

The internal implementation needs to run alone on the state machine until all resources are acquired. This is typically immediately, but it is async. This is the future returned from the apply_to_state_machine() call. Due to the technical constraint, this future is not 'static, but rather bound to '_ of the caller.
After acquiring resources, there is a potentially long-running task, which doesn't need write access to the state machine and can run concurrently to other operations on the state machine. This task must be 'static (otherwise you can't dispatch it and can't "unborrow" &mut self to return from apply_to_state_machine()). Ultimately, this task is finished and at that time, the result of the operation is known and can be sent to the client (provided all previous operations also finished).

Instead of returning a double-future, it's also possible to call the API with a result receiver (which needs to be 'static). Then, instead of returning the result directly by the Future, the returned Future would be the one just preparing the state machine (or not - it could've computed the result directly) and the actual result will be sent later via the result receiver provided to the call.
This way, the API would be fairly simple and the "simple" implementations could just set the result on the receiver before returning, more complex ones would do it in a background task.
The receiver would effectively schedule a callback to the main loop via the mpsc channel (or whatever other primitive is used, I'm not sure).
I.e., something like:
async fn apply_to_state_machine(&mut self, entries: &[&Entry<D>], result_receiver: Runtime::ResultReceiver<R>);

where ResultReceiver would have something like:
fn send_result(&self, index: u64, result: Result<R, StorageError>);

A simple implementation would implement it then like this:
async fn apply_to_state_machine(&mut self, entries: &[&Entry<D>], result_receiver: Runtime::ResultReceiver<R>)
{
    for entry in entries {
        result_receiver.send_result(entry.log_id.index, internal_state.apply(entry).await);
    }
}

I hope it is clearer now.


Add validation metric to support miniwdl validation

Description
This PR includes changes that support adding DNAstack's miniwdl validation to Dockstore's metrics system. View the corresponding metrics aggregator PR here https://github.com/dockstore/dockstore-support/pull/457
Previously, Execution captured information related to a workflow execution run. It didn't seem quite right to add validation information to Execution because miniwdl validation is not a workflow execution run. I created RunExecution which is essentially what Execution was before (a workflow run execution) and ValidationExecution which is a workflow validation execution (ex: miniwdl validation or womtool validation).
As a result, I created ExecutionRequestBody, which is a wrapper for RunExecutions and ValidationExecutions, that's used for the endpoint that sends metrics to S3. It also allows the metrics aggregator to easily get RunExecutions and ValidationExecutions.
Due to the restructuring, things in dockstore-support (tooltester in particular) will break once the dockstore version is updated. Will need to make tweaks in it to accommodate this new model once this PR is merged and a new tag is created, FYI @fhembroff.
Review Instructions
Follow review instructions in https://github.com/dockstore/dockstore-support/pull/457
Issue
SEAB-4695
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

A high-level comment/question, before delving into the details of the PR... I may be misunderstanding, but hopefully this isn't off-base.
How useful it is to have aggregate validations? If you're the author of the workflow, maybe, but otherwise I don't see the usefulness.

If I'm the user of the workflow, I would just care if the head of the version I'm interested in is valid or not, per MiniWdl. If it's been invalid 99% of the time, but the head is good, I'm good. If it's been valid 99% of the time, but the head is invalid, then I can't use it.
If it's invalid, I would want to know the invalidation details; certainly as the author, so I can fix them, perhaps even as the consumer (maybe the invalidation is just a warning I can live with). Won't this get lost with aggregation?
We might want to know what version(s) of MiniWdl the validation was done with -- maybe it validates with 1.0 but not 2.0.

I think the MiniWDL validation info is very useful, but I'm wondering if it's right to put it together with the metrics, and if instead it shouldn't be separated out.

How useful it is to have aggregate validations? If you're the author of the workflow, maybe, but otherwise I don't see the usefulness.

Unsure and it is a fair question, we were discussing this and we seemed a little on the fence. Part of what got me off the fence was that different validators may have different results (i.e. womtool passing and miniwdl not passing, or different versions of miniwdl disagreeing) similar to how our yaml validator is being tightened up.
So maybe it is useful to have an "overall" aggregated validation state similar to how this PR is currently passing 16/17 checks.

I think the MiniWDL validation info is very useful, but I'm wondering if it's right to put it together with the metrics, and if instead it shouldn't be separated out.

Willing to consider it, not sure what it would look like. Without "us" running it and generating canonical validation results, user submitted validation information does at a first glance look a lot like metrics.
Is part of the concern that we do not have GET endpoints for the metrics,  aggregated or not?
This could be a part of the discussion for #5449

was here, waiting to see how the conversation unfolds...

Is part of the concern that we do not have GET endpoints for the metrics, aggregated or not? This could be a part of the discussion for #5449

No, that wasn't the concern; I hadn't really thought that far ahead :).  Just at a high level, when I first saw the PR, it doesn't feel like whether a static analyzer was run 1 time or 1,000 times on a workflow is information worth tracking, whereas whether the workflow was run 1 time or 1,000 times, along with various metrics gathered from the runs, clearly is.
I'm going to process your other comments and take a look at the code again.

it doesn't feel like whether a static analyzer was run 1 time or 1,000 times on a workflow is information worth tracking,

For a specific platform partner, I probably agree. i.e. if DNAstack runs the same miniwdl validator 1000 times, I'd probably be happy with just overwriting the results. If they run v1 through v5 of the validator with different results, that might be?


Added new collection folder shrooms

Kindly add fractal shrooms to the marketplace

Sorry, no any information about the website, disord or twitter.

Sorry, no any information about the website, disord or twitter.

Hi @cloud6605, thanks for the feedback. We are currently in the process of setting up the official website, Discord, and Twitter for the Fractal Shrooms project.


Which BIDSVersion?

Hello,
We are starting to convert are datasets to BIDS format.
In the dataset_description.json file, the BIDSVersion is listed.
"BIDSVersion | REQUIRED. The version of the BIDS standard that was used."
How does one determine what BIDSVersion  is used?  Is it based on a specific conversion pipeline (e.g, dcm2bids ,etc.). We convert our data from dicom format to nifiti using dcm2niix, but don't see any BIDSversion listed in the .json files.  We've arranged the data in BIDS format based on the tutorial  (http://reproducibility.stanford.edu/bids-tutorial-series-part-1a/#man3) using a bash script and then use the bids_validator to confirm the dataset.
Thanks.
g.

Good question (and by that I mean I have no clear idea how to answer it). :smile:
Tried to see into the archives of issues of the validator if there is anything about this.
The is issue mentions this:

"The validator should validate the latest released version of the standard."

So I don't know if the validator checks that the version mentioned in the dataset description matches the requirement of that specific version.
But this highlights the fact that the validator could do 2 things that could help many users:

have an output message mentioning the BIDS version it is using,
actually check that the version number mentioned in the dataset matches the one it is using and tell users about this.

So I don't know if the validator checks that the version mentioned in the dataset description matches the requirement of that specific version

It does not - and I am not sure whether that's a good or bad thing. Ideally of course, the validator would check BIDS datasets according to the BIDSVersion field --> and a dataset formatted under BIDS 1.2 would pass the validator under 1.2 requirements, but potentially fail under 1.4 requirements.
But such a logic is not built into the validator. That piece of software can only validate one "BIDS version" (the newest stable release, 1.4 currently).

have an output message mentioning the BIDS version it is using

that sounds good to me in principle, yet practically the validator does not have full coverage of the BIDS specification (yet) and additionally, it is lagging behind the specification in terms of development. Given these two points, it would currently be a lie of the validator to claim to be validating according to version 1.4.
To JavaScript knowledgeable BIDS contributors: If you read this, please head over to the "low hanging fruits" project --> we would very much welcome some developers over at bids-validator!

How does one determine what BIDSVersion is used?

IMHO it's up to the conversion / curating software to tell you according to which standard version the processing is happening. For example in mne-bids we print the BIDSVersion that we use as an output of our pipeline automatically.
And if you are manually curating your BIDS dataset, you would put into this field the version of the docs that you used to prepare your dataset. Ideally you would always use the newest stable release (1.4 currently)

Thank you both for your feedback.
It appears that people using various pipelines to format the data into BIDS  might run into this issue.
For example, take the tutorials listed in this site:
https://github.com/bids-standard/bids-starter-kit/wiki/Tutorials
Both of these walk-through examples were very straightforward and helpful, yet they were created in 2018 and reference BIDSVersions 1.0.2. and 1.1.0, respectively.
If the current stable release is 1.4, that means thing would have changed.
Should BIDS users only use the following website with the pdf link as the template:
https://bids.neuroimaging.io/specification.html
https://bids-specification.readthedocs.io/en/stable/
How often are newer BIDSVersions released, and what is the most efficient way for users to know when new versions are released?
Regarding the bids-validator, it is stated the latest release of bids-validator always look for the datasets adhering to the latest BIDSVersion format.  As long as we keep bids-validator up to date, we are assured that it will determine if your dataset meets the latest BIDSVersion criteria?
Thanks again.
g.

It appears that people using various pipelines to format the data into BIDS might run into this issue.

yes, I can imagine that.

How often are newer BIDSVersions released,

we don't have a stable period or releases, but looking at the releases page can perhaps give you a feeling for it. We are following semver and increment a minor version whenever we add a new BIDS extension proposal, and we increment a patch version whenever we feel like some threshold is reached of new clarifications or inclusions and we don't want to wait until the next minor increment.
The major increment is reserved for breaking changes that'll come about with BIDS 2.0 --> no timeline exists for that as of yet.

hat is the most efficient way for users to know when new versions are released?

subscribing to our channels

"watching" the github specification repository
following on Twitter
subscribing to the BIDS mailing list
etc. (e.g., NeuroStars with the BIDS tag, or the BrainHack mattermost)

As long as we keep bids-validator up to date, we are assured that it will determine if your dataset meets the latest BIDSVersion criteria?

yes, keeping your bids-validator up to date is a good idea. If it passes at timepoint 1, it's highly likely that it will also pass at timepoint 2 in the future, because in BIDS we are keeping breaking changes to an absolute minimum until BIDS 2.0 comes around.
That means the only way your BIDS formatted dataset that passes the validator now can fail in the future is for these reasons:

a breaking change was made because a serious bug was discovered and absolutely HAD to be fixed (very low probability, happened about 2 times since 2016, but I don't now exact numbers right now)
the bids-validator coverage has increased and it now catches bugs that were bugs already before ... but they simply went unnoticed

FWIW: Re validating against a specific bids version, eventually #475 would open possibility to validator(s) to validate at least parts of the specification against the specified BIDS version.

thanks sapplehhoff for the clarification
g


'shared' target doesn't install libmujs.so

It's best if build accepted options, like BUILD_SHARED and BUILD_STATIC and only built/installed what is requested.

There are multiple Makefile targets for building and installing static and shared libraries explicitly:
shared, install-shared, static, install-static, etc.


Server thread crashes when moving too fast through new chunks

If you, say, fall at terminal velocity through not-yet-generated chunks for long enough, the server thread will just die; afterwards, any attempt to "save and quit" freezes the client. Tested in single-player, both opened to LAN and not; haven't had a chance to test a dedicated server yet.
[16:27:44] [main/INFO]: [CHAT] Teleported <PROFILE NAME> to 10000.5, 2500.0, 10000.5
[16:27:54] [Server thread/ERROR] [cubicchunks]: Attempting to unload already unloaded cube at CubePos(619, 4, 622)
[16:27:54] [Server thread/ERROR] [cubicchunks]: Attempting to unload already unloaded cube at CubePos(620, 4, 621)
[16:27:54] [Server thread/ERROR] [cubicchunks]: Attempting to unload already unloaded cube at CubePos(624, 4, 631)

Can confirm that this also happens in dedicated servers.

I tried and I still can't reproduce the issue.
My setup: new CustomCubic world, forge build 2600, cubic chunks 0.0.824.0.
Flied 10000 blocks away from spawn on spectator mod on max speed, in the meantime switching render distance values, sometimes going back and forth, changing directions and going in circles.
At that speed I was surprised cubic chunks works as well as it does anyway, but no issue found.
Are you using other mods? Which cubic chunks version? Which forge version?

I was able to reproduce the issue with JourneyMap installed. JourneyMap causes chunks to be generated outside of server thread, which completely breaks XYZMap class, causing the iterator to hang while looking for next element. As it is, this is not fixable and not considered an issue with cubicchunks, it's just journeymap being incompatible.


Enabling more than one dependency's feature enables its default features.

My crate depends on cpython crate, and I need to compile the latter with support for Python 2.7.  According to crate's documentation, this is achieved by turning off default features (=python3-sys) and adding python27-sys:
[dependencies]
cpython = { version = "0.3.0", default-features = false, features = ["python27-sys"] }

So far so good.
However, when I try to enable one more feature,
[dependencies]
cpython = { version = "0.3.0", default-features = false, features = ["python27-sys", "extension-module"] }

... I get a compilation error in cpython's build script:
error[E0428]: the name `PYTHONSYS_ENV_VAR` is defined multiple times
  --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/cpython-0.3.0/build.rs:10:1
   |
7  | const PYTHONSYS_ENV_VAR: &'static str = "DEP_PYTHON27_PYTHON_FLAGS";
   | -------------------------------------------------------------------- previous definition of the value `PYTHONSYS_ENV_VAR` here
...
10 | const PYTHONSYS_ENV_VAR: &'static str = "DEP_PYTHON3_PYTHON_FLAGS";
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `PYTHONSYS_ENV_VAR` redefined here
   |
   = note: `PYTHONSYS_ENV_VAR` must be defined only once in the value namespace of this module

Turns out that cargo passed both --cfg 'feature="python27-sys"' and --cfg 'feature="python3-sys"' into build script compilation, whereas they are supposed to be mutually-exclusive.
It looks as if adding more than one dependency feature overrides "default-features = false"...
Notes
Output of cargo version: cargo 1.38.0-nightly (26092da33 2019-07-31)

Looks like you need to use the extension-module-2-7 feature instead.

Ah, ok, I guess that makes certain sense...


Marginalized Gaussian Mixture Model Implementation

This is a tutorial for the Marginalized Gaussian Mixture Model using Turing. All code is commented and theory is also explained.
Ported from: https://docs.pymc.io/notebooks/marginalized_gaussian_mixture_model.html
I tried to stick to the Tutorials Roadmap described in #1 .

I am getting error related to issue: TuringLang/Turing.jl#722
@cpfiffer, we discussed regarding this.
Once it is correct, this tutorial should work.