Code refactors

Description
JS

Use stateless functions if possible
Ensure propTypes used everywhere
use mapDispatchToProps in our connect functions.

Current implementation
import {connect} from 'react-redux';
class A extends React.Component {
   constructor(props) {
     super(props);
     this.doSomething = this.doSomething.bind(this);
   }
   doSomething() {
          this.props.dispatch(someAction());
   }
   render() {
        return (<SomeComponent onClick={this.doSomething} />
    }
}

export default connect()(A);

Moving forward
class A extends React.Component {
     render() {
        return (<SomeComponent onClick={this.props.onAction} />
     }
}

function mapDispatchToProps(dispatch) {
     return {
         onAction: () => dispatch(someAction)
     };
}

export default connect(null, mapDispatchToProps)(A);

CSS

Vertical rhythm to CSS

What are your thoughts on the short-hand version of mapDispatchToProps, especially when we are not renaming the action creator?
Here's an example:
import { createTopic } from 'actions/topics';

class A extends React.Component {
     render() {
        return (<SomeComponent onClick={this.props.createTopic()} />
     }
}

export default connect(null,{ createTopic })(A);

Thanks for the suggestion!
Yep I like it, unless we find the need to remap our action type creators. Although it would be less understandable. We can roll with the short-hand version and see how we like it.
import { createTopic } from 'actions/topics';

class A extends React.Component {
     render() {
        return (<SomeComponent onClick={this.props.createTopic} />
     }
}

export default connect(null,{ createTopic })(A);

I don't think we need to wrap the onClick handler in a function do we? We can just pass in the prop as is.

I agree, you don't need the wrap in this case. As I understand it, and correct me if I'm wrong, if we want to pass in some parameters, then we need to wrap it or use .bind.
return (<SomeComponent onClick={() => this.props.createTopic('hello')} />
return (<SomeComponent onClick={this.props.createTopic.bind(this, 'hello')} />

@huyphamily You would need to bind it if you're using a function within that component (not the prop) I think.
Also, using an anonymous function in the render method is not a good idea because you would not be able to use Pure Render Mixin or optimise rendering.


AttributeError on calling LLMGraphTransformer.convert_to_graph_documents

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_experimental.graph_transformers.llm import LLMGraphTransformer
from langchain.llms.bedrock import Bedrock
from langchain.text_splitter import RecursiveCharacterTextSplitter
from langchain_community.retrievers import WikipediaRetriever
from langchain_community.graphs.neo4j_graph import Neo4jGraph

bedrock=boto3.client(service_name='bedrock-runtime')

def prepare_graph(wiki_keyword):
    wiki_retriever = WikipediaRetriever(doc_content_chars_max=2000, top_k_results=1)
    docs = wiki_retriever.invoke(wiki_keyword)

    text_splitter = RecursiveCharacterTextSplitter(chunk_size=500, chunk_overlap=50)
    doc_chunks = text_splitter.split_documents(docs)

    llm=Bedrock(model_id='mistral.mistral-7b-instruct-v0:2', client=bedrock)
    llm_transformer = LLMGraphTransformer(llm=llm)

    graph_documents = llm_transformer.convert_to_graph_documents(doc_chunks)
    graph = Neo4jGraph()
    graph.add_graph_documents(graph_documents)

Error Message and Stack Trace (if applicable)
Traceback (most recent call last):
  File "...\...\load_data_graph.py", line 46, in <module>
    prepare_graph('Paris')
  File "...\...\load_data_graph.py", line 38, in prepare_graph
    graph_documents = llm_transformer.convert_to_graph_documents(doc_chunks)
  File "...\...\venv\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 646, in convert_to_graph_documents
    return [self.process_response(document) for document in documents]
  File "...\...\venv\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 646, in <listcomp>
    return [self.process_response(document) for document in documents]
  File "...\...\venv\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 595, in process_response
    parsed_json = self.json_repair.loads(raw_schema.content)
AttributeError: 'str' object has no attribute 'content'

Description
I am trying to load a page from Wikipedia, split it and load to Neo4j using langchain
Wikipedia --> WikipediaRetriever --> RecursiveCharacterTextSplitter --> LLMGraphTransformer --> Neo4jGraph
LLM used is Mistral 7B (using AWS Bedrock)
System Info
langchain==0.1.17
langchain-community==0.0.36
langchain-core==0.1.52
langchain-experimental==0.0.58
langchain-text-splitters==0.0.1
langsmith==0.1.52
platform : windows
Python 3.10.8

Let me see.

I am having the same issue here :'/

its
CODE:
%pip install --upgrade --quiet  langchain langchain-community langchain-openai langchain-experimental neo4j json_repair
import os
import json
import types
from langchain_community.graphs import Neo4jGraph
from langchain_experimental.graph_transformers import LLMGraphTransformer
from langchain_openai import ChatOpenAI
from langchain_core.documents import Document
from langchain_community.llms import Ollama
llm = Ollama(temperature=0, model="llama2")
llm_transformer = LLMGraphTransformer(llm=llm)
os.environ["NEO4J_URI"] = "neo4j://localhost:7687"
os.environ["NEO4J_USERNAME"] = "neo4j"
os.environ["NEO4J_PASSWORD"] = "neo4jadmin"
graph = Neo4jGraph()
text = """Marie Curie, born in 1867, was a Polish and naturalised-French physicist and chemist who conducted pioneering research on radioactivity.She was the first woman to win a Nobel Prize, the first person to win a Nobel Prize twice, and the only person to win a Nobel Prize in two scientific fields.Her husband, Pierre Curie, was a co-winner of her first Nobel Prize, making them the first-ever married couple to win the Nobel Prize and launching the Curie family legacy of five Nobel Prizes.She was, in 1906, the first woman to become a professor at the University of Paris."""
documents = [Document(page_content=text)]
graph_documents = llm_transformer.convert_to_graph_documents(documents)
ERROR
AttributeError                            Traceback (most recent call last)
Cell In[19], line 10
8 texts = text_splitter.create_documents(text)
9 #documents = [Document(page_content=texts)]
---> 10 graph_documents = llm_transformer.convert_to_graph_documents(texts)
File C:\tools\Anaconda3\lib\site-packages\langchain_experimental\graph_transformers\llm.py:646, in LLMGraphTransformer.convert_to_graph_documents(self, documents)
634 def convert_to_graph_documents(
635     self, documents: Sequence[Document]
636 ) -> List[GraphDocument]:
637     """Convert a sequence of documents into graph documents.
638
639     Args:
(...)
644         Sequence[GraphDocument]: The transformed documents as graphs.
645     """
--> 646     return [self.process_response(document) for document in documents]
File C:\tools\Anaconda3\lib\site-packages\langchain_experimental\graph_transformers\llm.py:646, in (.0)
634 def convert_to_graph_documents(
635     self, documents: Sequence[Document]
636 ) -> List[GraphDocument]:
637     """Convert a sequence of documents into graph documents.
638
639     Args:
(...)
644         Sequence[GraphDocument]: The transformed documents as graphs.
645     """
--> 646     return [self.process_response(document) for document in documents]
File C:\tools\Anaconda3\lib\site-packages\langchain_experimental\graph_transformers\llm.py:595, in LLMGraphTransformer.process_response(self, document)
593 nodes_set = set()
594 relationships = []
--> 595 parsed_json = self.json_repair.loads(raw_schema.content)
596 for rel in parsed_json:
597     # Nodes need to be deduplicated using a set
598     nodes_set.add((rel["head"], rel["head_type"]))
AttributeError: 'str' object has no attribute 'content'

its able to run llama2 server and model but having this same bug/error
CODE: %pip install --upgrade --quiet langchain langchain-community langchain-openai langchain-experimental neo4j json_repair
import os import json import types from langchain_community.graphs import Neo4jGraph from langchain_experimental.graph_transformers import LLMGraphTransformer from langchain_openai import ChatOpenAI from langchain_core.documents import Document from langchain_community.llms import Ollama
llm = Ollama(temperature=0, model="llama2") llm_transformer = LLMGraphTransformer(llm=llm)
os.environ["NEO4J_URI"] = "neo4j://localhost:7687" os.environ["NEO4J_USERNAME"] = "neo4j" os.environ["NEO4J_PASSWORD"] = "neo4jadmin"
graph = Neo4jGraph()
text = """Marie Curie, born in 1867, was a Polish and naturalised-French physicist and chemist who conducted pioneering research on radioactivity.She was the first woman to win a Nobel Prize, the first person to win a Nobel Prize twice, and the only person to win a Nobel Prize in two scientific fields.Her husband, Pierre Curie, was a co-winner of her first Nobel Prize, making them the first-ever married couple to win the Nobel Prize and launching the Curie family legacy of five Nobel Prizes.She was, in 1906, the first woman to become a professor at the University of Paris."""
documents = [Document(page_content=text)] graph_documents = llm_transformer.convert_to_graph_documents(documents)
ERROR
AttributeError Traceback (most recent call last) Cell In[27], line 2 1 documents = [Document(page_content=text)] ----> 2 graph_documents = llm_transformer.convert_to_graph_documents(documents)
File C:\tools\Anaconda3\lib\site-packages\langchain_experimental\graph_transformers\llm.py:646, in LLMGraphTransformer.convert_to_graph_documents(self, documents) 634 def convert_to_graph_documents( 635 self, documents: Sequence[Document] 636 ) -> List[GraphDocument]: 637 """Convert a sequence of documents into graph documents. 638 639 Args: (...) 644 Sequence[GraphDocument]: The transformed documents as graphs. 645 """ --> 646 return [self.process_response(document) for document in documents]
File C:\tools\Anaconda3\lib\site-packages\langchain_experimental\graph_transformers\llm.py:646, in (.0) 634 def convert_to_graph_documents( 635 self, documents: Sequence[Document] 636 ) -> List[GraphDocument]: 637 """Convert a sequence of documents into graph documents. 638 639 Args: (...) 644 Sequence[GraphDocument]: The transformed documents as graphs. 645 """ --> 646 return [self.process_response(document) for document in documents]
File C:\tools\Anaconda3\lib\site-packages\langchain_experimental\graph_transformers\llm.py:595, in LLMGraphTransformer.process_response(self, document) 593 nodes_set = set() 594 relationships = [] --> 595 parsed_json = self.json_repair.loads(raw_schema.content) 596 for rel in parsed_json: 597 # Nodes need to be deduplicated using a set 598 nodes_set.add((rel["head"], rel["head_type"]))
AttributeError: 'str' object has no attribute 'content'

I encountered the same problem

@somashekarbrdtscblr I encountered the same problem

AttributeError                            Traceback (most recent call last)
 in <cell line: 5>()
3 text_splitter = TokenTextSplitter(chunk_size=512, chunk_overlap=24)
4 documents = text_splitter.split_documents(docs)
----> 5 graph_documents = llm_transformer.convert_to_graph_documents(documents)
2 frames
/usr/local/lib/python3.10/dist-packages/langchain_experimental/graph_transformers/llm.py in process_response(self, document)
593             nodes_set = set()
594             relationships = []
--> 595             parsed_json = self.json_repair.loads(raw_schema.content)
596             for rel in parsed_json:
597                 # Nodes need to be deduplicated using a set
AttributeError: 'str' object has no attribute 'content'
I encountered the same problem

I'm also facing the same error.

Running the same "Marie Curie" use case (with AzureOpeAi) i always get empty nodes. On Langsmith I can that the model is able to extract the nodes, but i see on the PydanticToolsParser step:
[big json here] are not valid JSON. Received JSONDecodeError Expecting value: line 1 column 1 (char 0)

Updates on the original issue:
(1) I switched from Mistral to OpenAI (GPT 3.5 Turbo) and encountered a different error message.
ValueError: Could not use APOC procedures.
(2) I referred to the following issue and adjusted the settings in Neo4j as suggested: https://github.com/langchain-ai/langchain/issues/12901#issuecomment-1836657528
Currently, I am facing this error:
    graph_documents = llm_transformer.convert_to_graph_documents(doc_chunks)
  File "...\...\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 646, in convert_to_graph_documents
    return [self.process_response(document) for document in documents]
  File "...\...\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 646, in <listcomp>
    return [self.process_response(document) for document in documents]
  File "...\...\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 598, in process_response    nodes_set.add((rel["head"], rel["head_type"]))
TypeError: string indices must be integers

Version Info:
langchain                                0.1.20
langchain-aws                            0.1.6
langchain-cohere                         0.1.5
langchain-community                      0.0.38
langchain-core                           0.1.52
langchain-experimental                   0.0.58
langchain-openai                         0.0.5
langchain-text-splitters                 0.0.1
neo4j                                    5.20.0

I also have met this kind of error
graph_documents = llm_transformer.convert_to_graph_documents(documents)
  File "d:\Anaconda3_2019_10\envs\llm\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 762, in convert_to_graph_documents
    return [self.process_response(document) for document in documents]
  File "d:\Anaconda3_2019_10\envs\llm\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 762, in <listcomp>
    return [self.process_response(document) for document in documents]
  File "d:\Anaconda3_2019_10\envs\llm\lib\site-packages\langchain_experimental\graph_transformers\llm.py", line 714, in process_response
    nodes_set.add((rel["head"], rel["head_type"]))
TypeError: string indices must be integers

Hello @TangJiamin  I have also same issue when  using llama3 witth llamacpp. Do you have any solution to fix it?

We've added a lot of fixes. Can you check noe

Looks like this code is moving to a different repository.
https://github.com/langchain-ai/langchain-experimental/tree/main/libs/experimental/langchain_experimental/graph_transformers

Hi!
I'm also facing AttributeError
AttributeError: 'dict' object has no attribute 'nodes'
When using the LLMGraphTransformer, i'm following the tuto from the langchain documentation and got an error either with gpt-4-turbo or gpt-4o-mini
Error

AttributeError                            Traceback (most recent call last)
Cell In[84], line 10
3 text = """
4 Marie Curie, born in 1867, was a Polish and naturalised-French physicist and chemist who conducted pioneering research on radioactivity.
5 She was the first woman to win a Nobel Prize, the first person to win a Nobel Prize twice, and the only person to win a Nobel Prize in two scientific fields.
6 Her husband, Pierre Curie, was a co-winner of her first Nobel Prize, making them the first-ever married couple to win the Nobel Prize and launching the Curie family legacy of five Nobel Prizes.
7 She was, in 1906, the first woman to become a professor at the University of Paris.
8 """
9 documents = [Document(page_content=text)]
---> 10 graph_documents = llm_transformer.convert_to_graph_documents(documents)
File ~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:809, in LLMGraphTransformer.convert_to_graph_documents(self, documents, config)
797 def convert_to_graph_documents(
798     self, documents: Sequence[Document], config: Optional[RunnableConfig] = None
799 ) -> List[GraphDocument]:
800     """Convert a sequence of documents into graph documents.
801
802     Args:
(...)
807         Sequence[GraphDocument]: The transformed documents as graphs.
808     """
--> 809     return [self.process_response(document, config) for document in documents]
File ~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:809, in (.0)
797 def convert_to_graph_documents(
798     self, documents: Sequence[Document], config: Optional[RunnableConfig] = None
799 ) -> List[GraphDocument]:
800     """Convert a sequence of documents into graph documents.
801
802     Args:
(...)
807         Sequence[GraphDocument]: The transformed documents as graphs.
808     """
--> 809     return [self.process_response(document, config) for document in documents]
File ~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:742, in LLMGraphTransformer.process_response(self, document, config)
740 if self._function_call:
741     raw_schema = cast(Dict[Any, Any], raw_schema)
--> 742     nodes, relationships = _convert_to_graph_document(raw_schema)
743 else:
744     nodes_set = set()
File ~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:609, in _convert_to_graph_document(raw_schema)
605 else:  # If there are no validation errors use parsed pydantic object
606     parsed_schema: _Graph = raw_schema["parsed"]
607     nodes = (
608         [map_to_base_node(node) for node in parsed_schema.nodes if node.id]
--> 609         if parsed_schema.nodes
610         else []
611     )
613     relationships = (
614         [
615             map_to_base_relationship(rel)
(...)
620         else []
621     )
622 # Title / Capitalize
AttributeError: 'dict' object has no attribute 'nodes'

Thats weird, I'll look into it
V sre., 30. okt. 2024, 23:38 je oseba JulienF @.***>
napisala:

Hi!
I'm also facing AttributeError
AttributeError: 'dict' object has no attribute 'nodes'
When using the LLMGraphTransformer, i'm following the tuto from the
langchain documentation and got an error either with gpt-4-turbo or
gpt-4o-mini
Error
AttributeError Traceback (most recent call last)
Cell In[84], line 10
3 text = """
4 Marie Curie, born in 1867, was a Polish and naturalised-French physicist
and chemist who conducted pioneering research on radioactivity.
5 She was the first woman to win a Nobel Prize, the first person to win a
Nobel Prize twice, and the only person to win a Nobel Prize in two
scientific fields.
6 Her husband, Pierre Curie, was a co-winner of her first Nobel Prize,
making them the first-ever married couple to win the Nobel Prize and
launching the Curie family legacy of five Nobel Prizes.
7 She was, in 1906, the first woman to become a professor at the
University of Paris.
8 """
9 documents = [Document(page_content=text)]
---> 10 graph_documents =
llm_transformer.convert_to_graph_documents(documents)
File
~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:809,
in LLMGraphTransformer.convert_to_graph_documents(self, documents, config)
797
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:797
def convert_to_graph_documents(
798
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:798
self, documents: Sequence[Document], config: Optional[RunnableConfig] = None
799
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:799
) -> List[GraphDocument]:
800
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:800
"""Convert a sequence of documents into graph documents.
801
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:801
802
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:802
Args:
(...)
807
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:807
Sequence[GraphDocument]: The transformed documents as graphs.
808
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:808
"""
--> 809
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:809
return [self.process_response(document, config) for document in documents]
File
~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:809,
in (.0)
797
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:797
def convert_to_graph_documents(
798
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:798
self, documents: Sequence[Document], config: Optional[RunnableConfig] = None
799
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:799
) -> List[GraphDocument]:
800
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:800
"""Convert a sequence of documents into graph documents.
801
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:801
802
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:802
Args:
(...)
807
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:807
Sequence[GraphDocument]: The transformed documents as graphs.
808
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:808
"""
--> 809
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:809
return [self.process_response(document, config) for document in documents]
File
~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:742,
in LLMGraphTransformer.process_response(self, document, config)
740
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:740
if self._function_call:
741
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:741
raw_schema = cast(Dict[Any, Any], raw_schema)
--> 742
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:742
nodes, relationships = _convert_to_graph_document(raw_schema)
743
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:743
else:
744
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:744
nodes_set = set()
File
~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:609,
in _convert_to_graph_document(raw_schema)
605
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:605
else: # If there are no validation errors use parsed pydantic object
606
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:606
parsed_schema: _Graph = raw_schema["parsed"]
607
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:607
nodes = (
608
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:608
[map_to_base_node(node) for node in parsed_schema.nodes if node.id]
--> 609
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:609
if parsed_schema.nodes
610
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:610
else []
611
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:611
)
613
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:613
relationships = (
614
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:614
[
615
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:615
map_to_base_relationship(rel)
(...)
620
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:620
else []
621
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:621
)
622
https://file+.vscode-resource.vscode-cdn.net/Users/julienfresnel/Documents/modjo-ml/nlp/graphrag/~/miniconda3/envs/name_finder/lib/python3.9/site-packages/langchain_experimental/graph_transformers/llm.py:622
Title / Capitalize
AttributeError: 'dict' object has no attribute 'nodes'
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/langchain/issues/21482#issuecomment-2447756160,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYGGTM3I6ZJIYI2R4N5UZTZ6EDSBAVCNFSM6AAAAABHOZ7KV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXG42TMMJWGA
.
You are receiving this because you commented.Message ID:
@.***>


Remove redundant code for EOL Python 3.7

Python 3.7 support was dropped in August 2023 in https://github.com/nedbat/coveragepy/releases/tag/7.3.0 so we can remove some old compatibility checks.

Thanks.  Part of me wants to keep the old stuff in show_pyc as a possibly generally useful tool, but you are right, I shouldn't hold onto it.  How did you find these bits?

I have this hacky function in my dotfiles:
function grepv () {
if [ -z "$1" ]
  then
    # No argument supplied
    git grep -nrE "version_info|python_version_tuple|python_version|PY_MAJOR_VERSION|PY_VERSION_HEX|hexversion|sys\.version" . "${@:3}"
else
#   git grep -nrIE --colour=always "(py(thon)?( )?)?$1(\.?|(, ?))$2|0x0${1}0${2}0000" . "${@:3}"
  git grep -nrIE "(py(thon)?( )?)?$1(\.?|(, ?))$2|0x0${1}0${2}0000" . "${@:3}"
fi
git grep -n "universal *= *1"
git grep -n python_requires
git grep -n requires-python
}

Then run plain grepv without args to see lots of places where things like sys.version_info are used, or grepv 3 7 for things that might look like a 3.7 version number. Lots of false positives, but that's okay, it's just for glancing over!

https://github.com/asottile/pyupgrade is also a useful too that can clean up some version checks too:
pip install pyupgrade
pyupgrade **/*.py --py38-plus

But looks like it wouldn't find these. It could be useful to upgrade lots of type annotations (Tuple -> tuple etc).

Very cool, thanks.  I've used pyupgrade, it's great:
% git log --grep=pyupgrade --format='%h %ad | %s' --date=short
  6205c9fe 2023-08-30 | style: pyupgrade --py38-plus --keep-runtime-typing
  df79a639 2021-05-03 | refactor: remove redundant Python 2 code (#1155)
  14449eed 2021-05-01 | refactor: pyupgrade --py36-plus *.py
  ddf5ba8c 2021-05-01 | refactor: pyupgrade --py36-plus tests/**.py
  4c4ba2e0 2021-05-01 | refactor: pyupgrade --py36-plus coverage/*.py

Oh, and one of those was you:
 df79a639 2021-05-03 | refactor: remove redundant Python 2 code (#1155)

I see you don't have pre-commit in this repo, but I have pyupgrade in there for most of my projects.


Issue with recipe/sentry

Q
A

Issue Type
Bug

Deployer Version
6.3.0

Local Machine OS
Debian GNU/Linux 9 (stretch)

Remote Machine OS
N/A

PHP Version
7.0.32

Description
Since my last composer update:

Updating deployer/deployer (v6.3.0 => v6.4.3): Downloading (100%)
Updating deployer/recipes (6.1.6 => 6.2.1): Downloading (100%)

I have this error when typing any php bin/dep [...] command :
root@cd5281a61ed2:/var/www/site/symfony# php bin/dep ssh staging

[ParseError] syntax error, unexpected '='
#0 /var/www/site/symfony/vendor/deployer/deployer/src/Deployer.php(325): require()
#1 [internal function]: Deployer\Deployer::Deployer{closure}()
#2 /var/www/site/symfony/vendor/deployer/deployer/src/Deployer.php(326): call_user_func(Object(Closure))
#3 /var/www/site/symfony/vendor/deployer/deployer/bin/dep(126): Deployer\Deployer::run('v6.4.3',
'/var/www/site...')
#4 {main}

The error seems to come from here:

[$ref, $authorName, $authorEmail, $timestamp] = explode('#', $line);

This seems valid in PHP 7.1 but triggers an error in PHP 7.0.* . Do any of you have the same error?
Content of deploy.php
<?php

namespace Deployer;

require 'recipe/symfony3.php';
require 'recipe/sentry.php';
require 'vendor/deployer/recipes/recipe/slack.php';

[...]

indeed, sorry for that, when i wrote this i missed that parent project requires php 7.0 and this syntax is in 7.1 only


feat(datepicker): give selected style precedence over prev month

Give selected style precedence over prev month
GDS-2275

I think this issue has already been resolved on our board,
https://github.com/MyPureCloud/genesys-spark/pull/229
https://inindca.atlassian.net/browse/COMUI-2538

I think this issue has already been resolved on our board,
#229
https://inindca.atlassian.net/browse/COMUI-2538

Nice one, thanks for letting me know

We should maybe talk about it in standup on how to sync the boards or have a process so that there is no duplicate tickets.


Support for pluggable editors

Different editors for different mime types? Other ways of specifying editor for a content document?
Examples with mime types:

text/plain
text/markdown
application/json

Other examples:

graphical schedule planner
etc

mime-type switching editor was implemented


Output Stream recording

Is it possible to record from the outputstream as it stands?
I have tried (on 'initialized'):
//user record
var u = connection.userByName('clux')
u.outputStream().pipe(fs.createWriteStream('./test.pcm'));

or
// global record
connection.outputStream().pipe(fs.createWriteStream('./test.pcm'));

and then running
// playback
fs.createReadStream('./test.pcm').pipe(connection.inputStream());

but nothing seems to be heard from my bot. I know the playback part should work since I can play your sin.pcm file. Is this not the intended usage?
(btw module has been fantastic so far - have done some really fun things with it :+1: )

I don't have problem with this. Make sure you're using up to date version though - there was a problem few weeks ago where the user-specific output streams weren't working. This was fixed two weeks ago in f689be7a6da226984fc0b0478a3df7d32cc9e1cb but the NPM version was a bit later I think.

I can also confirm that the above code works, I am using a smiliar setup. Make sure this is not a problem related to permission in your server.

That is weird. I am on the latest version. It is the recording stage to test.pcm that fails. The file only gets endless blocks of four zeroes written to it, and the 'voice' event on connection seems to never trigger.
I'll request a look at the server config later, it's not my server, but I mean, I can transmit and join using key and cert, what could be different for listening?

Please try on 'ready'. On 'initialized' the connection was initialized but the library is still waiting for the initial status of the server.

No, that's not doing it either. I'll try to do some debugging though. Added a console.log('got udttunnel data', data) to the beginning of MumbleConnection.prototype._onUDPTunnel and the buffer is definitely receiving my data properly.

Right. The type in _onUDPTunnel is 0 which is not one of the valid ones in MumbleConnection.codecValues so the packet is ignored.  Not sure how that is zero, given that the valid ones are 4 or 5, but that is at least the problem.

Interesting solution:
//var type = ( data[0] & 0xe0 ) >> 5;
var type = 5;

Ironically this is actually the "correct" solution - correct as far as the codecs go anyway. I've got no idea why the Celt codec is set to be number 5 on line 69:
MumbleConnection.codec = { Celt: 5, Opus: 4 }
The correct value for Celt would actually be 0...

Fixed in a2f1a158f19d8f203d1d756cd747da1a35f03d9f
Thanks for reporting it! I guess the rest of us were using Opus which works. The exact codec used is kind of hidden by the implementation which makes it nice to use but causes weird issues when the codecs differ. :)

Hehe, yeah that makes sense. Thanks for the fast publish :)


Should I add support for Protractor?

Hi @Georgegriff and thanks for your amazing query-selector-shadow-dom!
I understand that your motivation behind writing this library was to provide support for Playwright, which now has its own CSS selector engine inspired by your work. In light of this, are you planning to continue to maintain this library?
If the answer is yes, would you be open to me submitting a PR adding support for Angular Protractor?
Thanks,
Jan

This library existed before playwright, it's just playwright was the easiest to integrate with recently (until it wasn't needed anymore) But of course, more than happy! Although bare in mind have have zero experience with that test framework. So any examples/background or test cases would be great.
It may also be simpler to derive a new library with this is a dependency, up to you

Hi @Georgegriff! Many thanks for merging the PR 👍
Is there anything left to do before we could have the new feature available on NPM?

I'll try to release it today when I get chance

Released in 0.6.0

Brilliant, thanks @Georgegriff :shipit:


CORS errors occur on Trust Wallet

When browsing with TrustWallet, I get a CORS error.
I inspected the APK with Android Studio. Then, I noticed that the response of https://ethereum-rpc.trustwalletapp.com/ has not sometimes added Access-Control-Allow-Origin header.
This is mostly a TrustWallet issue, but I'm happy to report it here.
For example, Uniswap does not have this problem. Is it due to too many connections?
-- screenshots --
When Access-Control-Allow-Origin header is missed:

When Access-Control-Allow-Origin header is added:

Currently, an owned Etherreum nodes for the Dev Protocol is working.

HTTPS: https://devprotocolnode.net/ethereum/mainnet
Websocket: wss://devprotocolnode.net/ws/ethereum/mainnet (I recommend using the Websocket provider as the HTTPS provider cannot subscribe to events)

The solution is to use the owned Etherreum nodes instead of the built-in node.
Also, some features will be available even in browsers that do not have a built-in wallet.

Code
// change provider
web3.setProvider('wss://devprotocolnode.net/ws/ethereum/mainnet');

FYI: https://web3js.readthedocs.io/en/v1.2.7/web3.html#setprovider

This issue is already fixed, and I could verify using TrustWallet.


lemminx: init at 0.27.0

Description of changes
Test reproducability of the fetchMvnDeps pr https://github.com/NixOS/nixpkgs/pull/256176 using ofborg.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

We decided to NOT use fetchMvnDeps. Closed.


Container uses 5GB of ram sitting mostly idle

Looking at my datadog metrics, it seems to be consuming 5GB of ram at all times (using, not requested), this is more than any of my very heavily used crossplane providers (most of which use less than 1GB of ram.  Is there anything that can be done to reduce memory consumption?  I'm only syncing one composition with this currently so it's very lightly used.

Hello. Thank you for the feedback. May I ask if the function occupied 5G of memory when it was first deployed, or if the memory usage after a period of use may be due to memory leakage.

Seems like a memory leak -- it was steady at 25-50MB until it shot up to 5GB over the course of about 10 days and stayed steady there.  I deleted the pod and it's back to 25MB currently.

Make sense. I will release a new function version without the memory leak later. Thanks for the feedback.


Issues launching executable

Machine: Mac Catalina 10.15.7
python --version returns 3.10.1
Running chmod +x ./dist/yt-dlp-gui on mac doesn't do anything. Is there another step in this installation process?

Building on Mac is untested, I see that you're giving it execution permissions but did you actually try running it? ./yt-dlp-gui
I'd recommend updating the code with git pull before doing the above.


MailCatcher not capturing in Rails 4.2.4

Using Ruby 2.2.2
New rails app with postgres db. Scaffolded UsersController while calling         Testsend.test_email(@user).deliver_now in users#create doesn't get captured in MailCatcher.

I'm seeing this very recently as well.
Using ruby 2.2.3p173.

Thanks, this sounds like a configuration issue. Closing.


Not all results are coming

Hi, I think only results of first page are coming. However you mentioned that 120 results at Max should come but I'm only getting the results from 1st page.
Search query= NDA coaching in Agra
Got 16 results in json file but there were a lot more than this in next pages.
So this library doesn't offer paginated resujts?

No, it scrapes all results, in your query there are few results only just visit https://www.google.com/maps/search/NDA+coaching+in+Agra/ and see it for yourself.


Try open front camera if needed

Not working on 100% devices, works on most of the commercial manufacturers.

SPAM ⚠


'type' object is not subscriptable

After updating to the new release (from the working new_api branch) I get this error:
Traceback (most recent call last):   File "/usr/local/bin/porschecli", line 5, in <module>     from pyporscheconnectapi.cli import cli   File "/usr/local/lib/python3.8/dist-packages/pyporscheconnectapi/cli.py", line 6, in <module>     from pyporscheconnectapi.account import PorscheConnectAccount   File "/usr/local/lib/python3.8/dist-packages/pyporscheconnectapi/account.py", line 2, in <module>     from pyporscheconnectapi.vehicle import PorscheVehicle   File "/usr/local/lib/python3.8/dist-packages/pyporscheconnectapi/vehicle.py", line 20, in <module>     class PorscheVehicle:   File "/usr/local/lib/python3.8/dist-packages/pyporscheconnectapi/vehicle.py", line 207, in PorscheVehicle     def location(self) -> tuple[Optional[int], Optional[int], Optional[int]]: TypeError: 'type' object is not subscriptable
What can I do to resolve this?
pip uninstall pyporscheconnectapi  + pip install pyporscheconnectapi did not help.

Got it - pyporscheconnect needs python 3.9 now. I suggest fixing the documentation or fixing the code.

Thanks for the heads-up. And yes, everything older than 3.9 is end-of-life by now. I updated the requirements to 3.9, but now sure everything will work ok with that old version either. I suggest you move to 3.12 or 3.13.

Fixed in #68ef782


esbuild serializer causes Gradle to crash when the bundle generates a warning

What happened?
I configured Metro to use the ESBuild serializer, with the default options.
Using the default react-native-gradle-plugin process, Gradle runs the bundle command when building a release, changed so it runs rnx-bundle:
# app/build.gradle

react {
  bundleCommand = "rnx-bundle"
}

But this happens:
…/android/app/build/ASSETS/createBundleReleaseJsAndAssets/index.android.bundle:1:51547: warning: the variable "Promise" was not declared in function "bE1"
[22:52:00]: ▸  use strict";(()=>{var lse=Object.create;var cI=Object.defineProperty;var  [the whole 5 MB bundle]
[This repeated 10 times, including the whole bundle, as there are 10 warnings]
…
Exception in thread "pool-1-thread-1" java.lang.OutOfMemoryError: Java heap space

And then the build fails, because the Java process too all available memory trying to output those 5 MB lines.
If I disable whitespace minification in esbuild, then I each error displays the line where it happens, which are short (as there are newline characters in the emitted bundle), and the build goes fine.
Here is the output with whitespace minification disabled:
> Task :app:createBundleReleaseJsAndAssets
warning: the transform cache was reset.
                Welcome to Metro v0.73.9
              Fast - Scalable - Integrated

info esbuild bundle size: 6619674
info Writing bundle output to:,
…/android/app/build/ASSETS/createBundleReleaseJsAndAssets/index.android.bundle
info Writing sourcemap output to:, …/android/app/build/intermediates/sourcemaps/react/release/index.android.bundle.packager.map
info Done writing bundle output
info Done writing sourcemap output
info Copying 17 asset files
info Done copying assets
…/android/app/build/ASSETS/createBundleReleaseJsAndAssets/index.android.bundle:2495:20: warning: the variable "Promise" was not declared in function "bE1"
    (yE1 || (yE1 = Promise.resolve())).then(e).catch(function(t) {
                   ^~~~~~~
…/android/app/build/ASSETS/createBundleReleaseJsAndAssets/index.android.bundle:2496:14: warning: the variable "setTimeout" was not declared in anonymous function " 3#"
      return setTimeout(function() {
             ^~~~~~~~~~
…/android/app/build/ASSETS/createBundleReleaseJsAndAssets/index.android.bundle:3916:17: warning: the variable "FileReader" was not declared in function "Bue"
    var t = new FileReader(), r = kT1(t);

When I launch the bundle directly from the CLI (react-native rnx-bundle --dev false --platform android), those errors are not displayed, so I am not sure what Gradle does that displays them. Could it be a post-process task, done with Metro once the bundle is created?
Affected Package
metro-serializer-esbuild
Version
0.1.23
Which platforms are you seeing this issue on?

[X] Android
[ ] iOS
[ ] macOS
[ ] Windows

System Information
info Fetching system and libraries information...
System:
    OS: macOS 13.3.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 67.69 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: Not Found
    npm: 9.5.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.1 - /var/folders/cn/qgvjcjx97mj8rc2vx37vgkvh0000gn/T/frum_69495_1683799833063/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK:
      API Levels: 26, 31, 32, 33
      Build Tools: 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0, 33.0.0, 33.0.2
      System Images: android-24 | Google APIs ARM 64 v8a, android-25 | Google APIs ARM 64 v8a, android-26 | ARM 64 v8a, android-26 | Google APIs ARM 64 v8a, android-28 | Google ARM64-V8a Play ARM 64 v8a, android-32 | Google APIs ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2022.1 AI-221.6008.13.2211.9477386
    Xcode: 14.3/14E222b - /usr/bin/xcodebuild
  Languages:
    Java: 20.0.1 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^18.2.0 => 18.2.0
    react-native: ^0.71.8 => 0.71.8
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to Reproduce

Configure a project to use metro-serializer-esbuild (changing the Metro config is enough, no need for @rnx-kit/cli here)
Have warnings in your bundle
Run ./gradlew bundleRelease to generate release
Check the build output, there is a huge line with the whole bundle when showing the warning location. Gradle may even crash if your bundle is big enough.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

After investigating a bit more, those errors are printed by hermesc when compiling the bundle during the build phase.
And the same issue also occurs during the iOS build (multi-MB lines printed) but XCode copes well with them and do not crash.

Do you find the warnings useful? If not, you can suppress them by adding -w to hermesFlag in android/app/build.gradle:
react {
    hermesFlags = ["-O", "-output-source-map", "-w"]
}

I do not understand where they come from, and did not spend the time trying to figure out why they are here.
warning: the variable "Promise" was not declared in function "bE1"
the variable "setTimeout" was not declared in anonymous function
Why would those not exist? 🤔

Most likely because those functions are polyfilled and Hermes can't see them unless you specify where to look: https://github.com/facebook/hermes/issues/342
You can simply disable the warning if the bundle works without issues.

One other thing: If you're passing this bundle to the Hermes compiler, you can also consider disabling minification altogether. It shouldn't affect the size of the bytecode output.

I've just learned that you can control the output width using -max-diagnostic-width. I've updated the workaround here: https://github.com/microsoft/rnx-kit/issues/2416#issuecomment-1547309239

I've submitted a fix upstream to limit the output: https://github.com/facebook/react-native/pull/37531
I will close this issue when it lands. In the meantime, you can apply one of the following workarounds:
If you only use Hermes on Android, you can add -max-diagnostic-width=80 in android/app/build.gradle to limit the line width:
react {
    hermesFlags = ["-O", "-max-diagnostic-width=80", "-output-source-map"]
}

Alternatively, if you don't care about the warnings, just disable them:
react {
    hermesFlags = ["-O", "-output-source-map", "-w"]
}

iOS doesn't have an equivalent as far as I can tell. If you also use Hermes on iOS, you can instead disable minifying whitespaces in the esbuild plugin:
const { makeMetroConfig } = require("@rnx-kit/metro-config");
const { MetroSerializer, esbuildTransformerConfig } = require("@rnx-kit/metro-serializer-esbuild");

module.exports = makeMetroConfig({
  serializer: {
    customSerializer: MetroSerializer([], {
      minify: true,
      minifyWhitespace: false,
      minifyIdentifiers: true,
      minifySyntax: true,
    }),
  },
  transformer: esbuildTransformerConfig,
});

If you configure the plugin, you don't need to change your build.gradle.
Documentation: https://github.com/microsoft/rnx-kit/tree/main/packages/metro-serializer-esbuild#minifywhitespace

Merged in facebook/react-native@260bcf7f1bf78022872eb2f40f33fb552a414809


graphite.options: fix bug with import from archaius.

Untested, but I bet this does the trick ;)

LOL, I'm going to guess you're right :)


Footer

Footer
User Story
Acceptance Criteria

[x] The header has to be responsive in different screen sizes.

The footer is now integrated into the page layout


Doesn't appear to automatically add cookie attributes by default

Just spun up a new rails app, cookie attributes weren't set (is the railtie working?)

Maybe https://github.com/oreoshake/secure_cookies/issues/2 is the problem. I had to add config.middleware.use SecureCookies::Middleware

Yep, fixed in #5


Contribute KNN to classifier

In the repository multiple machine learning techniques are verified. Therefore, application of KNN should be a good contribution. For further details take a look at the following resources:

SKLearn: KNN
KNN

Create a well documented .ipynb file detailing your implementation.

I can work on knn using sklearn

Fine, if you require any aid, you can check out tutorial implementations.


Add more states to Wait For Element State keyword

The keyword Wait For Element State has currently four states available.
https://marketsquare.github.io/robotframework-browser/Browser.html#Wait For Elements State
To increase the usability of this keyword it would be nice to have other states available.
I propose the following.

[ ] enabled

[ ] disabled

[ ] editable

[ ] readonly

[ ] stable

[ ] inanimation  (maybe not)

[ ] selected

[ ] deselected

[ ] focused

[ ] defocused

[ ] checked

[ ] unchecked

This would make this keyword much more powerful and usable!

@Snooz82 The initial set of attributes is directly supported by Playwright.
I guess the others could be implemented with some combination of polling and getAttribute or waitForSelector
So
enabled can be implemented by waiting for not having disabled attribute
disabled can be implemented by waiting having disabled attribute
editable can be implemented by waiting for not having readonly attribute
readonly can be implemented by waiting for readonly attribute
no idea what stable means?
I don't think we can detect whether animation is running or not.
Selected and deselected are straightforward as are checked and unchecked
I guess you can detect focused element by pseudoclass :focus

@yanne
Stable can be detected by check that the element is not animated anymore. Pw does it by comparing the bounding box.
https://github.com/microsoft/playwright/blob/master/docs/actionability.md

Disabled can be fetched by getting the .disabled field from the ElementHandle.
Like document.querySelector('#id').disabled

We could also have a look in Jani Mikkonens SeleniumTestability Library how he waits for elements stop animating.
https://github.com/rasjani/robotframework-seleniumtestability

i think, because we mostly wait for a truthy value we should use page.waitForFunction()
https://github.com/microsoft/playwright/blob/master/docs/api.md#pagewaitforfunctionpagefunction-arg-options

stable and inanimation should be implemented on Playwright side with the next release. then we can finish this task


vim plugin specific snippets

Issue description
Some of the vim plugins need a specific vim configuration to work on nixos, we should add these to nixpkgs (via a passthru key) so that either
1/ users can reference these snippets e.g. in a home manager configuration:
      programs.neovim.plugins = [ {
        plugin = unicode-vim;
        config = pkgs.vimPlugins.unicode-vim.advisedSnippet;
        # the advisedSnippet being:
        # with "let g:Unicode_data_directory='${pkgs.vimPlugins.unicode-vim}/share/vim-plugins/unicode-vim/autoload/unicode'
      }

or
2/  the neovim wrapper can add these snippets to the init.vim / init.lua
The alternative of patching the plugin doesnt suit me as it makes  bug reports harder and in case we dont patch correctly could taint the nixos reputation: it's best to generate a config that the user can then report to the vim plugin author.
An additionnal issue is that some plugins depend on treesitter grammars such as rest.nvim: without the grammer it triggers
no parser for 'http' language, see :help treesitter-parsers so we should be able to set that as a dependency
Here I want to collect such snippets until we agree on the proposition/naming:

unicode.vim needs:

let g:Unicode_data_directory='${pkgs.vimPlugins.unicode-vim}/autoload/unicode'

coq_nvim needs (see https://github.com/NixOS/nixpkgs/issues/168928):

g.coq_settings.xdg

vim-markdown-composer can now set the path to the binary which means we wouldn't have to patch it anymore https://github.com/euclio/vim-markdown-composer/issues/69#issuecomment-1103440076

sql-nvim; let g:sql_clib_path = '${pkgs.sqlite.out}/lib/libsqlite3.so'

fzf-hoogle-nvim needs vim.g.hoogle_fzf_cache_file = vim.fn.stdpath('cache')..'/hoogle_cache.json'

vim-grammalecte let g:grammalecte_cli_py='${pkgs.python3Packages.grammalecte}/bin/grammalecte-cli.py' (see https://github.com/NixOS/nixpkgs/pull/151095)

llm-nvim do lsp.bin_path = "${pkgs.llm-ls}/bin/llm-ls" as per https://github.com/NixOS/nixpkgs/pull/306828

@mrcjkb @GaetanLepage after I've patched sqlite.nvim to remove the need for the snippet, I felt guilty. We should not patch plugins at the risk of maddening maintainers.
so I thought of 2 things to tackle the issue:

reproducing the unwrapped/wrapped nix way, aka sqlite.nvim-wrapped would have sqlite.nvim as a dependency plus the snippet let g:sql_clib_path = '${pkgs.sqlite.out}/lib/libsqlite3.so'
add a passthru.initRc that contains the snippet so users are free to use it directly, as well as us in the nixpkgs infrastructure (to setup tests for instance).

I believe 1 adds too much boilerplate. 2 seems more straightforward and generic. We could have an option in the neovim wrapper that auto-adds passthru.initRc when available as well.
What do you think ?

This would be my preferred approach:
Luarocks has a external_dependencies option. We should be able to utilise this as follows:

Update the rockspec to use external_dependencies.
Fix the sqlite.lua library so that it can auto-detect the sqlite library and fall back to g:sql_clib_path if it isn't found.
This would probably need a similar mechanism that luarocks uses.
I don't think it will be possible for luarocks-nix to make use of the external_dependencies[^1], so this would require an override.
But the luarocks build should fail if the external dependency isn't present. And specifying them becomes the responsibility of the upstream plugin author.

[^1]: The format is { EXPAT = { header = "expat.h" } }

the sqlite.nvim was just an example, I did not mean it as an example to handle external dependencies, see for instance the fzf-hoogle-nvim example.
It's probably left better for another issue but I have little faith upon external_dependencies reliance. It would need a mapping between external_dependencies and all the distribs packages (if we consider only nixpkgs, luarocks-nix should be able to map the common ones, but what library name should rockspec authors use in their external_dependencies ?). Not only that but luarocks doesnt care about pkg-config for finding libraries, which is a pain for nixpkgs.
Even then, libraries might need special care. I think it's a multi-year project which I personally would refrain from. It's to handle problems like this we have nix :)
Now if anyone could make me believe this is possible, that would be the neorocks team but it's out of the scope of this issue (in my mind, we can create another ticket if you really want to tackle this).

I see.
Something to watch out for (e.g. with the fzf-hoogle-vim example): That will only work with Nvim, but not Vim. It looks like something that should be fixed upstream.
But I see your point, e.g. for Python dependencies.
I'd prefer the passthru.initRc or passthru.initLua option.
Perhaps the config could even default to using it if it's null.

luarocks doesnt care about pkg-config for finding libraries, which is a pain for nixpkgs.

I don't think a plain Lua wrapper for pkg-config would be very hard to implement. And perhaps something like that could be upstreamed to luarocks.

I'd prefer the passthru.initRc or passthru.initLua option.

I agree, this seems like an appropriate approach.

The PR of what I mean: https://github.com/NixOS/nixpkgs/pull/334913

With the related PR being merged, I will close this. Feel free to add your snippets and tag me if I've forgotten any


Example with spot nodepool

Since one of the scenarios that inspired this project revolved around mixed nodepools and being able to deploy a % of a workload to spot/ephemeral nodes, I created a sample walk-through similar to that using Harvest VMs except with the second nodepool having a Priority equal to spot.
I created a separate deployment for this sample so the toleration could be included without risk of touching/breaking other samples or tests by adding it to the existing replicaset.
Signed-off-by: Cara MacLaughlin<EMAIL_ADDRESS>

@helayoty @aramase -- just adding another example so hopefully a short & simple review


✨ Add convert for propositional->relational

Codecov Report

Merging #9 (258037f) into main (76d2d93) will increase coverage by 1.78%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   91.30%   93.08%   +1.78%
==========================================
  Files           7       10       +3
  Lines         138      188      +50
==========================================
+ Hits          126      175      +49
- Misses         12       13       +1

Flag
Coverage Δ

unittests
93.08% <98.00%> (+1.78%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

relational_datasets/convert/convert_numpy.py
96.42% <96.42%> (ø)

relational_datasets/convert/__init__.py
100.00% <100.00%> (ø)

...ional_datasets/convert/tests/test_convert_numpy.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d2d93...258037f. Read the comment docs.


ability to remove edge attributes

At the moment you can add and update edge attributes but there's no possibility for removing an edge attribute at a later time. Neither the Edge-classes nor the AttributeBag-classes provide functionality to delete attributes.
The same is true for Vertex objects.

Absolutely, this should be supported :+1:
How do you think a possible API could look like?
This has originally been discussed as part of #103, so some of the original discussion can be found in there. Afaict the main issue was telling non-existant and null values apart.

What's wrong with a simple removeAttribute($name) method? Simple, clean and self-explanatory - no need to make complicated.

Agreed :+1:

I agree :+1: Does anybody feel like filing a PR? :-)


There's no value resource.

There's no "colors.xml".
There's no "strings.xml".
There's no "styles.xml".

Hi. Thank you for your interest in my project.
I can't upload the value file for security reasons. sorry.🙇♂

So hide the sensitive data and upload it with something like....
`<string name="secret_key">API_KEY_00245</string>`

TO
<string name="secret_key">당신의 비밀 키</string>

Hi. I'm sorry for answering too late. Thank you for your interest in my project. I can't upload the value file for security reasons. sorry.🙇♂

What security reasons in colors.xml and styles.xml?!
If you have any API keys in strings.xml you can mask it.


Given initial conditions?

Any way to fix some initial conditions in this Julia version of SIAN? Our school doesn't have Maple.

Gleb helped me with the model. It will be nice to have such functionality. Often, by giving values to certain initial conditions (for the state variables), non-identifiable parameters may become globally identifiable.

Good to know that the issue was resolved. I will close this for now.


NonNullable JSON data type attribute

Problem
Columns with data type Json can technically be nullable, even thought they are defined as not nullable in the prisma schema.
However, it would be very helpful to mark Json columns as absolutely not nullable via a data type attribute.
This would prevent a lot of tedious logic in larger codebases which try to enforce a strict type-safety.
Example:
To please the typescript compiler that prisma queries really don't return a null value (because we enforce that on data write/update operations) for json columns, we have a lot places which look like this:
const entity = await prisma.entity.findMany(...)

return {
      ...entity,
      entries: entity.entries.map((entry) => ({
        ...entry,
        someSubEntity: {
          ...entry.someSubEntity,
          attributes: entry.someSubEntity
            .attributes as Attributes, // we need to tell tsc that there are really no null values stored in the json column
        },
      })),
    }

Suggested solution
Introduction of a @jsonNotNullable data type attribute which ensures that both for write / update operations on the model no null value is written to the column and that the generated JsonValue type does not contain ... | null.
E.g. the generated type would be something like JsonValueNotNullable = string | number | boolean | JsonObject | JsonArray
Alternatives
None.
Additional context
None.

Columns with data type Json can technically be nullable, even thought they are defined as not nullable in the prisma schema.

Can you elaborate on that a bit? Is this about the database preventing foo = null but not foo = "null" (as the second is valid json technically)?

While setting up a demo usecase repository I recognized that even with my proposed feature we would run into typescript issues, since json columns can't be typed yet in prisma.
So I guess we have to wait for https://github.com/prisma/prisma/issues/3219 and I think the problem described above would also be solved with typed json columns feature.

Can you still elaborate on the perceived problem right now that I quoted? We talked about this internally, but were not sure if this is actually a problem right now that we missed.

Ok, so take the following schema:
model MyEntity {
  id           Int                @id @default(autoincrement())
  json_column  Json
}

The json_column is not marked as nullable in the prisma schema, but the generated type for that column is still Prisma.JsonValue, which boils down to string | number | boolean | JsonObject | JsonArray | null. So the generated type still includes | null, which is totally fine from a technical view, because JSONB columns in PostgreSQL which are marked as NOT NULL still can contain a null value since null is a valid json value.
So the idea of the @jsonNotNullable data type attribute was, that prisma enforces that no null value can the written to a column annotated by that attribute, and thus the generated type for the json_column column would also not contain the null value in the union type (e.g. JsonValueNotNullable = string | number | boolean | JsonObject | JsonArray).

So I understand correctly that json_column Json already makes sure there is not database level NULL value in that column (which is also backed by the types, as it requires a value to be set and the field is not optional), but both the database and the types allow a Json null. Correct? And you want a way to forbit that as well?

To clarify: this isn't about Prisma incorrectly accepting JavaScript null value as the value of a non-optional Json field (which I just double-checked isn't the case), this is a feature request to be able to narrow the type of the value stored in a Json column so that the type of the result of read operations won't include null, and the write operations won't accept Prisma.JsonNull, right?

Yes that is how I understood you now, you want to disallow a Json Null or Prisma.JsonNull for a specific field to further clarify what is expected and wanted in a column. The database will not be able to express that constraint (without getting fancy), but Prisma could definitely do that in the types and via validations or similar.
I think that sounds like a valid feature request if you can describe it in a way the majority of my colleagues will understand :D

@aqrln Exactly! :)

I'm also really needing this :+1:


Data model: make the example and text match

The data model page has had various sections like composite types added which are not reflected in the example at the top.
Need to include everything in the example, or otherwise make it clearer that the same example is not used throughout

Related thing to fix: https://github.com/prisma/docs/issues/1753

👋 we're cleaning up our backlog of issues and are closing everything older than two years. If you still feel that this issue is relevant, please feel free to re-open and our team will take a look. Thank you!


AEIP-2. Comments on Properties

Is your feature request related to a problem?
I am sorry I have other concerns about the Properties, hope that will help to progress.

Seems that there are 2 roles in properties;
one is to define some metadata of the token (parent) and to define a list of NFT instances (children). It will be nicer to separate these 2 items in different attributes, on an object and another one a collection.
metadata:{}  &  instances: [].  (didn't find a better word than instances)

Metadata are defined by an item with 2 attributes key/value, as JSON is based on "key:value", it is more efficient (size, implementation to find the value etc..) to use the native approach. example:
[
{  "key": "origin", "value": "France"},
{  "key": "organism", "value": "DG" }
]
should be
{
"origin": "France",
"organism": "DG
}

For NFT instance, the id should be mandatory and controlled by the developer, I will not recommended to have the index based on the position in a collection (mix representation & business)

Describe the solution you'd like
No response
Additional context
No response

Hello @pvalette
Thanks for the contribution.
I think the first one is interesting, we thought about it, before.
The "key"/"value", was to make the schema evolutionary and still be validated.
But this can be implemented.
For the second, I don't think should be mandatory, in some other blockchains it's either mandatory or self-defined in the contract (auto or specified). In the AEIP2 there is a mention to give the id in the property field.

Closed by #14


fix: 404 page in <4 letter shortcode

Description
When trying to access a link that does not exist, a 404 Page must be displayed (Link Broken), this happens only if the shortcode is less than 5 or more than 5. Fixed it using app.all method by catching all other routes
Fixes # (issue)
#207
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Put two letters after kzilla.xyz. Ex: kzilla.xyz/gg

Changes

N/A

Flags

N/A

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

This is supposed to be Fixes #number
not this :

@sm-sami check it out, if its fine, please merge it. Thanks!

@alvinbengeorge Please merge srmkzilla:master onto this branch.

@sm-sami Merged


comma in template string right after ${} causes comma-spacing

minimal example:
let a = 1;
console.log(`${a}, b`); // will report comma-spacing

comma escaping can be used as a workaround:
let a = 1;
console.log(`${a}\, b`); // no error

Yep, same problem in JSX text content.

Same

We have the same problem.

Can you please verify that this issue still exists on 3.0.1?

Using 3.0.1 I still encounter the issue with commas either in template strings or in JSX.

I still see it as well.
src line:
console.log(${ios}, ${android}, ${phone}, ${tablet})
error:
  267:27  error  A space is required after ','  comma-spacing

Still not working, the same error:
log.info(`Failed to enable text ad ${advertId}, trying to enable banner.`, textAdException);

Same here, still getting it with 3.0.1.

Looking into this... The tokens in espree/esprima aren't the same?
// espree (has no comma node) and thus no issue
[ { type: 'Template', value: '`${' },
  { type: 'Identifier', value: 'a' },
  { type: 'Template', value: '}, b`' },
  { type: 'Punctuator', value: ';' } ]
// babel/acorn
[ { type: 'Punctuator', value: '`' },
  { type: 'Punctuator', value: 'template' },
  { type: 'Punctuator', value: '${' },
  { type: 'Identifier', value: 'a' },
  { type: 'Punctuator', value: '}' },
  { type: 'Punctuator', value: ', b' },
  { type: 'Punctuator', value: '`' },
  { type: 'Punctuator', value: ';' } ]

So maybe we need to combine tokens to make a Template type? @sebmck

Ok comma-spacing in jsx text should be fixed in 3.1.5.

I just tried 3.1.5 and still get issue on this snippet
                  (
                    `upload/`,
                    `upload/` +
                      `w_${ Math.round(item.crop.width / item.crop.ratio) },` +
                      `h_${ Math.round(item.crop.height / item.crop.ratio) }/` +
                      `x_${ Math.round(item.crop.x / item.crop.ratio) },` +
                      `y_${ Math.round(item.crop.y / item.crop.ratio) },` +
                      `w_${ Math.round(item.crop.cropWidth) },` +
                      `h_${ Math.round(item.crop.cropHeight) },` +
                      `c_crop/`
                  )

Ok I got it down to
a(`a`,
  `a`)

So does it error on the eslint parser? I think it's erroring because it doesn't think there is a newline.

on the eslint parser

I use babel-eslint with probably too many things that might break eslint default parser
No eslint exceptions if it's what you are asking.
I just get "normal" comma-spacing reported.

Ok I copied the snippet into a new file and don't get an issue?
{
  "env": {
    "es6": true,
    "node": true
  },
  "parser": "babel-eslint",
  "rules": {
    "comma-spacing": 1
  }
}

hum ok I will investigate that later. Sorry if it's a mistake from my side.

Bump, this is still complaining:
module.exports = {
  render() {
    var {name} = this.props;
    return Math.max(null, `Name: ${name}, Name: ${name}`);
  }
};

Trimmed down from a React component code to this.  Warning would go away if changed var {name} to var name.

Ah sorry can reproduce - will push a change soon.

Thanks, @hzoo. That fixes this for me:

@KylePDavis Awesome!
@XeCycle Sorry, I was going to wait for another fix but it's taking a while, so that should be fixed in 3.1.8!


Dynamic generation of username : admin and password : password for wp-admin

Description of the feature

Need implementation of creating  a dymanically generated username and password for wp-login username and details.
Benftits of feature

This will help in the cracking of the password, because admin will be displayed in the case of blog, ie who wrote the blog.. and the hacker must try only the password which is easy to find because we have given the 50% details .. I want it to be complicated for the hacker to find the wp login details of the username and the password
Additional context

No screenshots available

You can use the ADMIN_USER environment variable, but I see where you are coming from - Regardless of what happens wordpress creates the default post and page and shows the author leaking the Admin user. I suggest this be something brought up with Wordpress developers.
An alternative way would be if you can figure out with wp-cli how to remove the page and post I can script it upon first install with an environment variable.


Funds Withdraw request

Raising this from #10.
Using modal to take the request
In request

Take the reason
Wallet address
% Amount

Follow the sequence diagram in documentation.

Why closed?
For this version, this feature kept on hold.


@ operand problem in supplemental materials

I cannot execute code in supplemental materials:

It shows TypeError: unsupported operand type(s) for @: 'Operator' and 'Operator'. I cannot find any information in Qiskit documentation on how to solve this.

@pawmasz what version of python are you running? The @ symbol does matrix multiplication. Since it's not working, feel free to replace the line
np_ZZ_matrix = CNOT @ I_Rz @ CNOT
with
np_ZZ_matrix = np.matmul(np.matmul(CNOT, I_Rz), CNOT)

Your solution works, thank you.
I'm still wondering how you can multiply two Operator (using * also doesn't work). I looked over Operator code and documentation and don't see operator overloading for @. And more strange is that both Python and NumPy should support @, and * but in my case they don't.
I'm using Python 3.9.7. This is my environment:
Package              Version
-------------------- ---------
argon2-cffi          21.3.0
argon2-cffi-bindings 21.2.0
attrs                21.4.0
backcall             0.2.0
bleach               4.1.0
certifi              2021.10.8
cffi                 1.15.0
charset-normalizer   2.0.10
colorama             0.4.4
cryptography         36.0.1
cycler               0.11.0
debugpy              1.5.1
decorator            5.1.0
defusedxml           0.7.1
dill                 0.3.4
entrypoints          0.3
fonttools            4.28.5
idna                 3.3
ipykernel            6.6.1
ipython              7.30.1
ipython-genutils     0.2.0
ipywidgets           7.6.5
jedi                 0.18.1
Jinja2               3.0.3
jsonschema           4.3.3
jupyter-client       7.1.0
jupyter-core         4.9.1
jupyterlab-pygments  0.1.2
jupyterlab-widgets   1.0.2
kiwisolver           1.3.2
MarkupSafe           2.0.1
matplotlib           3.5.1
matplotlib-inline    0.1.3
mistune              0.8.4
mpmath               1.2.1
nbclient             0.5.9
nbconvert            6.4.0
nbformat             5.1.3
nest-asyncio         1.5.4
notebook             6.4.6
ntlm-auth            1.5.0
numpy                1.22.0
packaging            21.3
pandas               1.3.5
pandocfilters        1.5.0
parso                0.8.3
pbr                  5.8.0
pickleshare          0.7.5
Pillow               9.0.0
pip                  21.2.4
ply                  3.11
prometheus-client    0.12.0
prompt-toolkit       3.0.24
psutil               5.9.0
pycparser            2.21
pydot                1.4.2
Pygments             2.11.1
pylatexenc           2.10
pyparsing            3.0.6
pyrsistent           0.18.0
python-constraint    1.4.0
python-dateutil      2.8.2
pytz                 2021.3
pywin32              303
pywinpty             1.1.6
pyzmq                22.3.0
qiskit               0.34.0
qiskit-aer           0.10.1
qiskit-ibmq-provider 0.18.3
qiskit-ignis         0.7.0
qiskit-terra         0.19.1
requests             2.27.0
requests-ntlm        1.1.0
retworkx             0.10.2
scipy                1.7.3
seaborn              0.11.2
Send2Trash           1.8.0
setuptools           58.0.4
six                  1.16.0
stevedore            3.5.0
sympy                1.9
terminado            0.12.1
testpath             0.5.0
tornado              6.1
traitlets            5.1.1
tweedledum           1.1.1
urllib3              1.26.7
wcwidth              0.2.5
webencodings         0.5.1
websocket-client     1.2.3
wheel                0.37.0
widgetsnbextension   3.5.2
wincertstore         0.2

@ajrazander I think I've figured it out.
When using qiskit.quantum_info.operators.Operator class, to perform matrix multiplication A * B you need to use B.compose(A) method because operator @ is not overloaded in Operator class. Possible operations on Operator class are described in documentation.
I've tried this on one of the cells that showed error and comparison between Qiskit and NumPy gives result True:

If you agree I can prepare PR soon.

Thanks for pointing that out @pawmasz. Here's the specific section in the docs (if you don't want to scroll as much).

@pawmasz  I am trying to write a product of operators like PA= I^Z^Z and PB=Z^Z^I.... Pproduct= PA*PB.... how i should do in QISKIT ???

What kind of product are you trying to do? In python, @ is often overridden to be used for matrix multiplication while * is used for element-wise multiplication. If you want to do matrix multiplication between operators used A.compose(B):
pa = I^Z^Z
pb = Z^Z^I
pc = pa.compose(pb)
print(pc)

which outputs the expected result ZIZ

How then i should implement it on circuit. Taking  "pa = I^Z" and simultaneously apply it on two qubit like |01>. as i want to make a circuit in which Identity goes to first state|0> and Z apply on |1>

@ajrazander  thanx for helping


Admin API query parameter size is not reported in the next URL in paginated lists

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
2.1.8
Current Behavior
When doing the following request:
GET http://localhost:8001/services?tags=test&size=1

The response contains a single item as expected by the size argument (I could not find it documented in the Kong Admin API, anyway)
but in the next field the contained URL is:
"next": "/services?offset=WyIzZWQ2N2EwMC1mNGY2LTQ4NTUtYmQ0Yi0zMmZmMWMzNWVmNmMiXQ&tags=test"

the tags parameter is present, but size is missing.
Expected Behavior
The size parameter should have been present so that the pagination will keep respecting the size the user requested:
"next": "/services?offset=WyIzZWQ2N2EwMC1mNGY2LTQ4NTUtYmQ0Yi0zMmZmMWMzNWVmNmMiXQ&tags=test"

Steps To Reproduce
1. Do the request: `GET http://localhost:8001/services?tags=test&size=1`
2. Verify that the `next` field in the response lacks the `size` parameter

Anything else?
No response

Hey! I would like to work on this issue.
If I'm not wrong the change is required in the  /kong/api/endpoints.lua  right?
and something along the lines of
if args.size then
      next_page_size = "&size=" .. escape_uri(type(args.size) == "number" and args.size[1] or args.size)
end

I'm a bit new to the codebase and Lua itself, so any suggestions and guidance are much appreciated...


elasticsearch-curator: new package added

I've prepared elasticsearch-curator package for managing ElasticSearch indices. Unfortunately, package in EPEL doesn't work with ES higher 2.0. So that's why it might be very useful for modern installations.

Ok, looks good for me. Merged.

@gongled I've fixed dependencies for elasticsearch-curator package but it still require newer version of python-click package (required: 3.3+, available: 2.6).


fix: snap zones with pivot offset

Description
Fix highlights for objects with a pivot/collider offset.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:
Aditional Notes

Checklist

[X] My code follows the Coding Conventions
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

I tested it and it works fine but I have the same concerns as @Gusinuhe


added generic disclosure that is relevant to Monitor-Me, and updated …

…license

Very very nice!


additional attributes

All songs, albums, artists and playlists should have their uri saved with them. Don't need to save the song_to_uri dict then.
Songs should have an additional_artists attribute that captures feature artists. Main artist shouldn't be included here I guess? Or maybe?
—
Created via Raycast

fixed in #18


[paraview] fix building with mpi feature enabled

This PR fixes building paraview with the mpi feature enabled. To my knowledge that feature has never been tested and thus was actually never working before.
The following changes where made:

Apply a fix to vtk so that some headers get installed that are required by ParaView.
Enable the FiltersParallelFlowPaths module in vtk when both paraview and mpi features are enabled.
Download the source for IceT before building ParaView.

Additionally I have added the mpi feature to the vcpkg-ci-paraview test port. This should make sure that the combination will be tested in the future. I am not sure what the policy about such testing ports is, so let me know if you would prefer that I revert that change.
edit: I had to disable the mpi feature of the vcpkg-ci-paraview test port again, since it enables the parallel feature of hdf5 which is in conflict with the cpp feature that is required by some other port.

I will test it locally.

I will test it locally.

Testing...

Testing...

When building vtk[openvr,qt,python,atlmfc,paraview,opengl]:
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

Does that related to your changes?

When building vtk[openvr,qt,python,atlmfc,paraview,opengl]:
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

Does that related to your changes?

@JackBoosY: Sorry for the late reply. The error is not related to this PR. This happens when hdf5[parallel] is already installed and you are trying to install vtk without the mpi feature.
See this comment in another PR and the following discussion.

@JackBoosY: Sorry for the late reply. The error is not related to this PR. This happens when hdf5[parallel] is already installed and you are trying to install vtk without the mpi feature.
See this comment in another PR and the following discussion.

Can you please solve the file conflicts by revert vtk.json, merge this branch from master and regenerate the version record?
Thanks.

Can you please solve the file conflicts by revert vtk.json, merge this branch from master and regenerate the version record?
Thanks.

Can you please solve the file conflicts by revert vtk.json, merge this branch from master and regenerate the version record?

Done!

Can you please solve the file conflicts by revert vtk.json, merge this branch from master and regenerate the version record?

Done!

c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory

Seems your changes is incorrect. An extra slash.

c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory
c++: error: /mnt/vcpkg-ci/installed/x64-linux/debug/lib//libglib-2.0.a: No such file or directory

Seems your changes is incorrect. An extra slash.

Pinging @albertziegenhagel for response. Is work still being done for this PR?

Closing this PR since it seems that no progress is being made, Please reopen if work is still being done.


Fix entity links and contextmenu

fix entity link broken for all types except Item
#102
fix contextmenus action not displayed

Will merge every fixes into a single PR


error with bib

I installed the ZotHero 2.1 version appropriate for Alfred 5. But I seem to get an error with saying:
[Errno2] No such file or directory: '/Users/me/Zotero/better-bibtex.sqlite'
I am using the default path for Zotero since that is where I have installed it.  I am sure I have some setting wrong.
Thanks,
Claudio

@cgrattonUW I think you need to install the better-bibtex add-on in Zotero. Instructions here


Prevent matching of invalid HTML tags

Here's a simple idea to fix https://github.com/burodepeper/language-markdown/issues/178.

Breaks the integration tests regarding autolinks, such as <https://www.github.com>, hmm, see: https://github.github.com/gfm/#autolinks
Maybe best way to solve all these issues is to have a general selector for opening and closing tags, without any added logic. An additional step could make a distinction between various types of tags/links/etc. What do you think?

Breaks the integration tests regarding autolinks

That would be fixed by putting include: '#links' above include: '#html'.

I've tried your approach, and ran into some additional issues. See b1a1da1 for my implementation and tests. Thanks for your help!


Possible issues loading the plugin in Velocity

Our metrics say 30 people are successfully using the plugin on velocity, but we received one report that the plugin wasn't loading:

it was user error, probably an improperly uploaded jar file


Support for C# 10?

I'm using C# 10 in my ASP.NET WebApplication (<LangVersion>10</LangVersion>). Using this SDK it seems this is not possible:

Invalid option '10' for /langversion. Use '/langversion:?' to list supported values.

Is there a way to make this work? FWIW I am building other libraries against .NET Framework 4.8 with C# 10.

I've added the latest version of that package, but the error remains.
    <PackageReference Update="Microsoft.Net.Compilers.Toolset" Version="4.0.1" />

The SDK pulls in
<PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="3.8.0" PrivateAssets="All"/>

automatically - as well as
<PackageReference Include="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" Version="3.6.0" />

unless you set the property ExcludeASPNetCompilers to true.
If you are using Microsoft.Build.CentralPackageVersions you can actually set these versions in your central packages file.
Because of the order, if you place it in your project file, I'm pretty sure your
    <PackageReference Update="Microsoft.Net.Compilers.Toolset" Version="4.0.1" />

happens before the include so there will be nothing to update at that point.
If you move that to Directory.Build.targets it should work though.
Alternatively use
<PropertyGroup>
    <ExcludeASPNetCompilers>true</ExcludeASPNetCompilers>
</PropertyGroup>
<ItemGroup>
    <PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="4.0.1" PrivateAssets="All"/>
    <PackageReference Include="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" Version="3.6.0" />
</ItemGroup>

I will also look at potentially updating the default version pulled in by the SDK to 4.0.1.
I'm not entirely sure if there is an updated version of the CodeDom Providers, which means the langversion available in your compiled pages might not support C# 10.

Using version 4.0.66 with <MicrosoftNetCompilersToolset_Version>4.0.1</MicrosoftNetCompilersToolset_Version> gets rid of that error 👍. Thank you for your time and investigation.

Sadly I'm running into another issue which I hoped to get rid off by switching to Sdk-style project in the first place. My project builds fine on Windows (old-style csproj), but fails to build on macOS/Mono with the following error. I don't understand why this happens as MyLibrary builds just fine.

Assembly 'MyLibrary' with identity 'MyLibrary, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' uses 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version than referenced assembly 'System.Net.Http' with identity 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

That brings back some bad memories. I think this SO answer might help:
https://stackoverflow.com/a/51424880/2225808

Yes bad memories indeed. I thought I left those behind by migrating to PackageReference and auto binding redirects. And it has been working fine for years now on Windows (regular Framework 4.8).
Thanks for the suggestion. My project already has a transitive dependency on System.Buffers 4.5.1, and making that dependency explicit doesn't resolve the build warning. I suspect the bug is with Mono not resolving the System.Net.Http dependencies similar to framework v4.7.2 or 4.8, but I have yet to find proof of this.

@Bouke Since the update to 4.0.66 deals with the c#10 issue, do you mind closing this?
If there is something specific to the SDK which affects your binding redirects / package resolving process perhaps open a new issue about it.
It should be noted, that using this on Linux/Mac with Mono is not really a supported scenario for this SDK and you are in for many other difficulties I suspect.


Failed to find configured registry to update for URL in Rancher 1.3

Rancher v 1.3
objectpartners/rancher-ecr-credentials:latest
I'm getting the following error:
Updating ECR Credentials PMReturned from AWS GetAuthorizationToken call successfully PMLooking for configured registry for host nnnn.dkr.ecr.us-west-1.amazonaws.com PMFailed to find configured registry to update for URL nnnn.dkr.ecr.us-west-1.amazonaws.com
Actual account number in place of nnnn.
While pulling from the Rancher catalog and using version 1.1.0, I would only see Updating ECR Credentials. No timeouts or further logs.

have you configured this registry in Rancher for the environment that you are running this container in?
Also, please try using the 1.1.0 release instead of latest as latest has some future work in it that hasn't been released yet.


Enabling inline results produces an error

"Error in handler: SyntaxError: Failed to execute 'add' on 'DOMTokenList': The token provided must not be empty."
Just updated to ink 0.6.5 and protorepl 1.4.20
Ink Console is on and functioning. When "show inline results" is true in protorepl settings, the above error occurs.

Latest update to ink removed the error.


Customize UI

Is there a way to add my custom CSS for the UI?

There is not, but if you have any suggestion, we may try to implement them in Black Screen.

Right now, the only option I see is doing like Slack (which is also built with Electron): create a "Preference" tab in Black Screen menu and let people add custom colors.
This solution might take some time to develop. Not sure if it worth it or not.

But maybe you wanted to change or add something specific using custom CSS?

Hmm not really.
I like to custom the tools I use in general so I was curious about it.
It's not essential though :)

Being able to change the background/text color would be nice. :)

Since Black Screen is targeted at developers anyway who probably won't shy away from some CSS themselves, it would be nice to just have it load a custom CSS after the original one. TaskPaper does this  reasonably well. I think the four options for this are

Look for a ~/.blackscreen.css or $XDG_CONFIG_HOME/black-screen/user.css
Bundle a blank user.css file with the app, and preferably have a menu option that will show this file in Finder
Respect an environment variable that lets the user specify the location of a custom CSS file
Have a settings dialogue that lets the user specify the location of a custom CSS file

Personally, I prefer 1. or 3. as it makes it easier for me to have the same setup on different machines and keep my settings files in sync. Is there a technical challenge to loading two CSS files that I'm not aware of?

@maebert I was thinking about a solution like 1. too. Simple and also you could share your css with other people easily. But when I look into how the css is done, it's using inline style so no css classes. With the actual implementation, I don't think solution 1. is possible. Maybe you know a way of doing it?

Ah, well. Is that an issue with electron, or just something that will need to be refactored?

I would love this feature. Personally I would want to use this with a different typeface and font size (13px Inconsolata. I've forked the app to do so but would love if we added it as a config option instead. The inline styles are just React -- most of the main configuration is already abstracted in main.ts. We could easily pull out the remaining variables like typeface and colors, and let users customize with their own CSS or dotfile.
cc/ @maebert @iDams @shockone

Is there currently any way to change the font size?

@kevinchau321 Yep! You can change it in your ~/.hyper.js file:
config: {
    // default font size in pixels for all tabs
    fontSize: 16,
    ...
}

Wrong terminal emulator, @iDams. ;)
Currently there is no way to change font size unless you are willing to change it in the source code. Moving forward I like Linux approach of having one value per file, like ~/something/black_screen/font_size would contain just one value: 12.

I don't say customizing css itself, but basic options, like font-size, line-height and colors are essentials for this. Each developer uses it's own setup and this would be awesome on BS.

Changing font size is a must have feature for me, especially shortcuts like cmd+ and cmd- that change the window size and font size all at once (just like the built in mac terminal)

@kevinchau321 Oh yeah, I forgot cmd+. Black Screen it's a helluva terminal emulator, and with these options, would kill.

Closing in favor of https://github.com/railsware/upterm/issues/1124


Update documentation workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%.  Consider uploading reports for the commit 9d1f079 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #354   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           96        96
  Lines         3228      3228
  Branches       242       242
=========================================
  Hits          3228      3228

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dialog: click .v-modal to close Dialog

If the Dialog is smaller than the .v-modal (for example, put left:200px on Dialog's style), you can't close Dialog by clicking .v-modal. This pr solves this problem.

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Add some descriptions and refer relative issues for you PR.
[x] Make sure you are merging your commits to dev branch.

Please write a demo.

It's better to change style on .el-dialog instead. .el-dialog__wrapper should always be fullscreen. https://jsfiddle.net/leopoldthecuber/vxjx3stm/10/

@Leopoldthecoder  it covers all .el-dialog's style

Use custom-class


Infer registry

While working on cargo publish for workspaces, I noticed a few ways in which the registry inference for cargo package seemed wrong. (This only affects the unstable -Zpackage-workspace feature.) This is all about the interaction between --index/--registry, and the package.publish fields.

Previously, if multiple crates were packaged and they had different package.publish settings, we would ignore those setting and fall back to "crates-io". After this PR, we will bail out with an error instead (unless they've specified --registry or --index).
Previously, we would validate the inferred registry against the package.publish settings, even if the --index argument would have taken precedence. After this PR, we will skip registry validation in this case.
Previously, we were just ignoring the registry value inferred from package.publish: we'd validate that it was ok, but then just not use it.

I'm mystified by the failure in the build-std tests. When I run it locally I don't get the [UPDATING] line, but it seems to be reliably present in CI. (Also, I don't see why this PR would affect that test)

Ok, I rebased and the mysterious build-std error seems to have gone away.

@bors r+

:pushpin: Commit 275d3b6e5489ee24be1f2d083f772829bae16a15 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 275d3b6e5489ee24be1f2d083f772829bae16a15 with merge 495d02cb4731e31d54c0127ef8f0b7b4b219a3a3...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 495d02cb4731e31d54c0127ef8f0b7b4b219a3a3 to master...


Task combinators.

@spebbe I realize this is kind of an expansive PR, but a bunch of the combinators are built on top of others. Let me know if you'd prefer breaking some of this stuff into smaller commits.
I also added a few extension methods on Task which is feature I don't see used anywhere else, though this may be from supporting Dart 1 in the past.
Looking forward to any feedback you have.

Really great additions! Gotta try some things out but will review properly soon!