Not catching channel events

Hello guys,
so i'm sure this is an easy fix but channel names and events do not match what is dispatched in Laravel:
What i listen for:
account_creation_requests
AccountCreationRequestReceived
And I get from Laravel:
private-account_creation_requests
App\Events\AccountCreationRequestReceived
Do i need to change something in the way i declare my listeners/channels/events on the Flutter side?

Declare channels with exact name that matches the channel name coming from the backend, same thing with the events.
So use private-account_creation_requests as your channel name, and use App\Events\AccountCreationRequestReceived as your event name. Because if it comes from Laravel - then you should use it.

Ok will do. Thank you.


Optionally fail if user/key not given

I have a shared build script like:
...
bintray {
 user = System.getenv('BINTRAY_USER')
 key = System.getenv('BINTRAY_KEY')
...

I spent about an hour troubleshooting why I suddenly was unable to release from my laptop. After a while, when running with -i, I saw a small info log about not running bintrayUpload because no user was specified.
If I could set a property that says the plugin should fail, instead of just ignoring the missing property, that would have med me realize this much faster. Or always fail if the property is not set, unless there is a use case where someone would want to run without a user.
Same thing with mavenCentralSync. If someone configures sync = true but configures no user/password, I think there should be an error.

Same thing with mavenCentralSync. If someone configures sync = true but configures no user/password, I think there should be an error.

I completely disagree here.  We publish our package as part of an organization and that organization has its OSSRH credentials on its profile.  Those are the values that should be used by the Bintray Maven Central sync stuff - and in fact when you do this from the UI that is exactly what happens if you do not specify any values here.
All that said, I'm not so sure that this is the same thing that happens from the plugin.  I do not specify the sync creds in the plugin config for the reasons I described above - but the sync does not automatically happen.  Does the plugin just ignore the mavenCentralSync section completely if no creds are given?  If so, it shouldn't.  It should just send the empty values.  I'll wait to open a new issue until its confirmed that this is what happens.

Thank you for opening this issue @tomasbjerre . We are investigating this issue and how to improve this.

Hi @tomasbjerre
I just wanted to update you upon the release of the new version 1.8.1 of the Gradle Bintray Plugin. Previously, if username or password were missing, the bintrayUpload was skipped (as you encountered). With this version, if a username or password are missing, bintrayUpload will not be skipped but the upload will fail with a 401 error:
> Could not publish 'null/maven/gradle.tests.pkg.name5/1528775107200': HTTP/1.1 401 Unauthorized [message:This resource requires authentication]
Please let us know if this suits your needs.
Thanks,

Great thanks!


Update Node to 8.0.0

Need to wait for this first: https://github.com/nodejs/docker-node/issues/372

@panuhorsmalahti thanks for keeping an eye on it, will update as soon as parent issue is resolved.

Node 8.0.0 image is now available.


Extensions Guide

We currently have a list of recommended (e.g. softly endorsed) extensions in the documentation (this needs some love).
In addition, we should have a document that lists all community extensions, grouped by category.

Prompted by https://github.com/kennethreitz/requests/issues/3131

Feel free to paste extensions you're aware of here.

PyPI catalogs these for us see:

searching for requests on PyPI
searching for requests on Warehouse

Judging by the number of these packages, I'm not sure we want to keep a list of every community extension. That seems... extreme.

Yeah, no API clients (maybe one or two exceptions; doubtful). They have to look at least somewhat generally useful.

I forsee this being a fairly large list, intended to be for discovering new toys, or looking for something specific via ctrl-f.

you can start with some well used n promising ones first


URL normalization

How could URLs be normalized?
http://chrisdry.wp/wp-content/themes/scribe/css/../fonts/Pe-icon-7-stroke.eot

Not sure what you're asking. Is UnCSS reporting some errors? If you're fetching resources over the network, it should be able to find them without any help :)

If the css contains ..\ uncss leaves it in the absolute URL.
--
+36204242498
Ezen a készüléken nehéz gépelni.
Elnézést!
On March 8, 2015 5:14:21 PM CET, Giacomo Martino<EMAIL_ADDRESS>wrote:

Not sure what you're asking. Is UnCSS reporting some errors? If you're
fetching resources over the network, it should be able to find them
without any help :)

Reply to this email directly or view it on GitHub:
https://github.com/giakki/uncss/issues/156#issuecomment-77758276

I don't think this should be UnCSS's responsibility; that should be up to a CSS minifier.

I would agree....
This site http://refresh-sf.com/ has YUI and CleanCSS. None of them normalizes the relative URL.
Do you know any minifier that does it?

a {
    background: url(http://chrisdry.wp/wp-content/themes/scribe/css/../fonts/Pe-icon-7-stroke.eot);
}

This lib seem very small. (IDN, query strin etc. normalization)

Nodejs has it!
> var url=require('url');
undefined
> url.resolve('http://example.com/two', '../one')
'http://example.com/one'

Do you know any minifier that does it?

None, as far as I'm aware.

Please consider adding url.resolve().
Thank you!

@szepeviktor This feature is supported in cssnano, if you would like to have it in your build. https://github.com/ben-eb/cssnano

@mikelambert No reason to keep this open that I can see.

OK


Decrease the noise of the daily digest message

Summary
Currently, we send a daily digest if a user has:
Tasks that are due today or are overdue
Tasks with no due date
After introducing the weekly digest message, we can decrease the noise of the daily digest by notifying users only if they have tasks due today or overdue. The weekly digest message will have full information, including tasks with no due date, so they will not be forgotten.
Ticket Link
Fixes: https://github.com/mattermost/mattermost-server/issues/21503
Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[ ] Unit tests updated

Hello @shinnlok,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Oops, I'm sorry I missed this one @shinnlok! Thanks for the contribution :)

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!


HA-SIP crashes at first call

Hello,
Thank you for this great integration!
I had my homeassistant on a HP-T630 and the HA-SIP integration was running just fine with my incoming calls (FritzBox)
But now I restored my configuration to my actual environment which is a OdroidN2 +  (quad-core ARM Cortex-A73 CPU)
Is there knowledge that the HA-SIP integration cant rin on a ARM CPU?
At the first call HA_SIP crashes, If I call then immediately after the first call I am getting my menu. As said, all worked fine on the HP-T630.
This is what the supervisor logs says:
24-01-18 14:54:13 WARNING (MainThread) [supervisor.addons.addon] Watchdog found addon ha-sip is failed, restarting...
24-01-18 17:07:04 WARNING (MainThread) [supervisor.addons.addon] Watchdog found addon ha-sip is failed, restarting...
Any idea how I maybe can solve this?
Thank you.
Versions of it all are all up to date till 18-01-2024
Hans

I'm using ha-sip on a raspberry pi 4, which should be the same architecture, and I also get some random crashes from time to time which I could not get hold of. Maybe it's pjsip, maybe my code does something wrong. I unfortunately can't help you with that currently.

Too bad, but thank you for the quick answer...

Can you re-check with the current version?

Hi,
No sorry but either the T630 as the OdroidN2 are both not in use anymore. But I can tell you that it all works perfect with a Intel NUC i5.
Thanks for your effort.


[IOT] Test updates for beta branch

Description
Testing updates, specifically rerecording tests and ensuring that commands would work.
https://github.com/Azure/azure-cli/issues/22174
Additional Changes:

_test_utils.py was changed for all versions to use cryptography over pyopenssl.
Updated the certificate create code to serialize the correct body for non-latest profiles

Tests not rerecorded:

DPS and Central are not listed in AZURE_API_PROFILES 2020-09-01-hybrid profile and thus have not been re-recorded
IoT Hub identity test was not originally recorded in the 2020-09-01-hybrid profile and is thus not re-recorded.

Testing Guide
Used azdev test <command> --profile <profile> --live to rerecord tests
History Notes
[IOT] Test updates for beta branch

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

IoT

Your PR should not modify so many modules. Please rebase pull and rebase code from the remote dev branch first


support weekday

schedule is super useful and handy, thank you.
here's a suggestion.
schedule.every().weekday.at("07:00").do(start_coffee_machine)
syntactic sugar yes, but would be nice,

If this is syntactic sugar what is the the supported alternative? I'm trying to execute a function every weekday.

Hi! This feature request is being tracked in #129.
If you feel like this request is different you are welcome to commend and we can re-open :)

Hi! This feature request is being tracked in #129.
If you feel like this request is different you are welcome to commend and we can re-open :)


Last Suggestion not Showing Correctly

I have been seeing an issue on my Sonim XP5s (running Android 8.1) where the last item in the suggestions (the farthest right suggestion) is not completely showing (it is cut off on the end) when I first cycle through the suggestions. However, if I cycle through them a second time, by the second time it looks correct (see how "Hid" shows correctly the second time).
I have poked at the code a bit, learned about RecyclerView, etc. The xml/layout looks good, and possibly that isn't where the issue lies because it eventually looks good on the second try. I'm thinking it could be something with the functions for selecting left/right. I would be curious where you think the issue may lie and I am open to debugging that specific code area myself:

also, I am noticing on first scroll, it doesn't scroll very smooth. It kind of shifts left and then back to the right. It's almost as if the left-most suggestion is left-aligned to the screen (see how "Gi" is aligned to the left of the screen) and it's not allowing it to be cut off a bit and fade off to the left. Hope that makes sense.

Ah, I see. Sorry, for misinterpreting.
However, scrolling works fine on both my phones. Selecting the previous/next word happens in SuggestionsBar.scrollToSuggestion(), but I see nothing wrong there.
There are two possible problems:

It could be a RecyclerView bug in older Android versions (I'm testing on 10 and 11).
People claim sometimes the RecyclerView needs some time before it is able to scroll

I doubt it is the second case, but could please help with confirming? In SuggestionsBar.scrollToSuggestion() try replacing:
mView.scrollToPosition(selectedIndex);

with this:
new Handler().postDelayed(() -> mView.scrollToPosition(selectedIndex), 200);

Supposingly, scrolling will become inadequately slow, but it will work. Of course, this is not a solution, it is just a test.

Ah, even without testing this code and scrolling slower, "Hid" popped up just fine. It does seem to be a speed thing.
Try pressing left when you first get suggestions (which goes immediately to the last suggestion). Is the last suggestion showing fine on your Android 10/11 phones?

Yes, this workaround is working, which is bringing us closer to the root of the problem.
I've found that a more obvious way to test this bug is when you first get a list of suggestions, press the left key so that it goes directly to the last suggestion instead of scrolling left to right until the end. Typically when I press 1 and then the left key, I can't even see the "?" that is suggested, but I was able to with this patch

There may be a better solution in that Stackoverflow thread. Instead of waiting for 200 ms, this is supposed to wait for the view to become ready, then scroll:
mView.post(() -> mView.scrollToPosition(selectedIndex));

Could you please replace the same line as above, but with the .post() alternative. It works very well on my phone, so if it fixes the problem on yours, we can keep it.

That did not work very well, the delay works better. I was even able to reduce the delay to 100 ms and I don't notice any slowness, but get to see the last suggestion correctly.

This is probably happening on other low end phones too, so I would like to have it fixed.
I have two ideas how to fix it, but before that, I need to know one more thing. But let's start with the original version of SuggestionBar.java, the one that's in master.

Type "4-4", then cycle the suggestions until you can see the last one.
Select it, but do not press OK.
Change the text case with "#" (or whatever key you have configured).

Are you still able to see the last suggestion? Has the list automatically scrolled to the beginning?
If yes, then setSuggestions() must also be fixed. Otherwise, we'll take care only of scrollToSuggestion().
Also, could you please validate one more alternative way of fixing the problem? Since your phone needs some time to update the highlighted word before scrolling, let's reverse the order of actions and first scroll, then let it draw on the screen as long as it wants. This could again fail, but we could give it a try. So, scrollToSuggestion() would look like this:
public void scrollToSuggestion(int increment) {
	if (suggestions.size() <= 1) {
		return;
	}

	int oldIndex = selectedIndex;

	selectedIndex = selectedIndex + increment;
	if (selectedIndex == suggestions.size()) {
		selectedIndex = 0;
	} else if (selectedIndex < 0) {
		selectedIndex = suggestions.size() - 1;
	}

	mView.scrollToPosition(selectedIndex);

	mSuggestionsAdapter.setSelection(selectedIndex);
	mSuggestionsAdapter.notifyItemChanged(oldIndex);
	mSuggestionsAdapter.notifyItemChanged(selectedIndex);
}

The other idea is to add a configuration option "alternative scrolling" or similar, that when enabled will allow scrolling with delay, which definitely works for you.

That's so sad... OK, I guess I'll add a setting for the alternative scrolling method using a delay.


A bit off topic but: What is used to increase or decrease the pitch of the generated audios?

You see, there are multiple ways to modify the pitch of an audio with libraries like PyWorld (Harvest) or Parselmouth, but, as far as I understand, Crepe is only an analyzer and extractor of the pitch curve, and does not have the function to modify the pitch of an audio.
However, in RVC you can change the pitch by semitones and without introducing almost artifacts with respect to the other alternatives.
What is used together with Crepe to modify the pitch of the audio according to the desired semitones in RVC?
It would be very useful for me to know it in order to apply it in other projects.
Thank you.

Pitch is an input of the model.
The model learned "what pitch outputs what wavform".
So.


Focus behaviour for buttons and anchors

Bug Report

What is the issue?

The yellow focus indicator is visible after clicking on a button or an anchor.
What steps are required to reproduce the issue?

Mouse click
Move the mouse over the button, click and then move the mouse away. The yellow highlight is shown on the button.

Keyboard
Tab onto the button, tap the enter key and leave. The yellow highlight is shown on the button.

What was the environment where this issue occurred?

Device: Mac
Operating System: OSX Big Sur 11.4
Browser: Chrome
Browser version: 91.0.4472.106 (Official Build) (x86_64)
NHS.UK frontend package version: nhs-frontend v3.0.3
Node version: v14.17.0
npm version: v6.14.3

Is there anything else you think would be useful in recreating the issue?
We're aware this could be an accessibility feature and would like some input (no pun intended) on whether the behaviour is different in more recent versions or whether its the same?

This is expected behaviour at the moment - the reality is that in both these situations the button is still focused so the yellow highlight is shown correctly. You'll see the same behaviour if you look at the buttons on https://design-system.service.gov.uk/
However, this is now "fixable" by using https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible but I don't think this is something we would transition to lightly without significant research and possibly discussion with the govuk-frontend folks. Alas the feature's existence in web standards doesn't always mean it's been thoroughly considered from an accessibility and usability perspective.

Had a quick chat with someone from the GOV.UK design system team and they said:

"It would be good to see more evidence and research to see how focus-visible tests with users. For instance, we know from research that some users with mild vision impairment use a mouse. We’d need to be confident that this change wouldn’t actually make using a mouse less accessible for some users."

Thanks for getting back quickly.
I experimented a little (before you pointed out :focus-visible) and attached a document wide listener that blurs the highlight when a mouse click occurs but keeps the highlight when an Enter key is pressed.
The behaviour of this change felt odd though as the highlight got lost and this would no doubt confuse people alternating between keyboard and mouse - myself included.
From our point of view it looks like we'll have to wait for any future changes from you and GOV.UK .


Create HtmlBlock.php

Added generates of html blocks. It will be useful to generate article content in a blog or something similar

Fixed

What's wrong with HTML provider (cf #971)? If you just want the HTML body, then you'd better update the existing provider rather than creating a new one.

Besides, #1237 seems to go in the right direction already.


feat: add Scaleway as a provider

Signed-off-by: Patrik Cyvoct<EMAIL_ADDRESS>What this PR does / why we need it:
Add Scaleway as a provider
Special notes for your reviewer:
Relates to https://github.com/kubermatic/kubeone/issues/1136
Not sure how to add E2E since a Scaleway account is needed
Optional Release Note:
Add Scaleway as a provider

Thanks for the review @moadqassem , I'll adress it this week or next week :)
Regarding the test, the tokens will be generated on your side? 🤔

Thanks for the review @moadqassem , I'll adress it this week or next week :)
Regarding the test, the tokens will be generated on your side? 🤔

API token will be on our side, our prow job will take care of that ;)

@moadqassem all reviews fixed, and added e2e files :smile:

@Sh4d1 In order to run the current pr in ci you have to add a section for that in .prow.yaml something similar to this:
  - name: pull-machine-controller-e2e-scaleway
    always_run: false
    decorate: true
    error_on_eviction: true
    clone_uri<EMAIL_ADDRESS>    labels:
      preset-scaleway: "true"
      preset-hetzner: "true"
      preset-e2e-ssh: "true"
    spec:
      containers:
        - image: golang:1.13.8
          command:
            - "./hack/ci-e2e-test.sh"
          args:
            - "TestScalewayProvisioningE2E"
          resources:
            requests:
              memory: 1Gi
              cpu: 500m

@moadqassem :heavy_check_mark:

@Sh4d1 I have a question regarding the creation and the starting of the instance. So what if the instance was created and during starting, something goes wrong and the machine doesn't start in the first time. The current logic will be, machine-controller will keep checking if that created machine has a node(which is not the case because the instance is there but it is never started which means it is unavailable) and after some time, the machine controller will delete that machine and recreate it again. Now this delay can be avoided by controlling the status of the instance in the get method. If the instance is created and fetched please control that it is in a running state, and if it wasn't then start it.

@moadqassem okay so in the Get method I should add a switch on the server state ? And if it's in stop state I should start it ? In that case it will also start a stopped but already created server too, is that good?

@moadqassem okay so in the Get method I should add a switch on the server state ? And if it's in stop state I should start it ? In that case it will also start a stopped but already created server too, is that good?

Well, those instances are reconciled based on their names and the tags that are attached to them, thus, why would the machine controller care about a stopped instance :) also we don't actually support  shutting down/stopping of a machine as you probably noticed in the provider interface. User should assume that what is created by the machine controller should be managed by it, and if someone do tweaking manually then they should expect some unwanted actions.

@moadqassem added, let me know what you think :smile:

@moadqassem all good :smile:

/ok-to-test

/test pull-machine-controller-e2e-scaleway

@moadqassem yep my bad, fixed it as well as the spelling error :smile:

/test pull-machine-controller-e2e-scaleway

@Sh4d1 Thank you very much for your work, the pr looks good :)
/approve
/lgtm


TLS versioning need correct tests

Things the tests need to cover:

[ ] Error when downstream asks for a TLS version that's too low
[ ] Error when downstream asks for a TLS version that's too high
[ ] Error when we ask upstream for a TLS version that's too low
[ ] Error when we ask upstream for a TLS version that's too high

Other things we need to make certain of:

[ ] Docs cover how to configure TLS version checking
[ ] Docs cover what to expect for a version mismatch

@gsagula Are the upstream checks meaningful? Is there other stuff I'm missing?

Hey @gsagula, how about review the checklist above and make sure everything's covered? I've landed #1524 (woot!) but it's worth doublechecking.

#1551 covers what I think we need here. :)


s/nose_parameterized/parameterized

"The nose-parameterized package is deprecated and has been renamed to parameterized."
I simply followed the instructions from https://pypi.python.org/pypi/nose-parameterized.

Thank you for bringing the repo closer to the present.


Segfault on CREATE VIEW query

Creating a new view based on another materialised view (based on MergeTree-Engine tables) results in a segmentation fault. The query looks like this:

CREATE MATERIALIZED VIEW yt.videoid_lookup POPULATE AS SELECT DISTINCT id, channel_id from videos

The error log looks like this:
2017.08.17 10:41:18.804826 [ 1 ] <Warning> ConfigProcessor: Include not found: networks
2017.08.17 10:41:18.804876 [ 1 ] <Warning> ConfigProcessor: Include not found: networks
2017.08.17 10:41:20.804800 [ 7 ] <Warning> ConfigProcessor: Include not found: clickhouse_remote_servers
2017.08.17 10:41:20.804902 [ 7 ] <Warning> ConfigProcessor: Include not found: clickhouse_compression
2017.08.17 10:41:24.088431 [ 9 ] <Error> BaseDaemon: ########################################
2017.08.17 10:41:24.088517 [ 9 ] <Error> BaseDaemon: (from thread 8) Received signal Segmentation fault (11).
2017.08.17 10:41:24.088567 [ 9 ] <Error> BaseDaemon: Address: NULL pointer.
2017.08.17 10:41:24.093478 [ 9 ] <Error> BaseDaemon: 1. clickhouse-server(std::enable_if<std::is_reference<DB::ASTSelectQuery&>::value, DB::ASTSelectQuery&>::type typeid_cast<DB::ASTSelectQuery&, DB::IAST>(DB::IAST&)+0x13) [0x27cc6a3]
2017.08.17 10:41:24.093512 [ 9 ] <Error> BaseDaemon: 2. clickhouse-server(Poco::ThreadImpl::runnableEntry(void*)+0x96) [0x31c19c6]
2017.08.17 10:41:24.093529 [ 9 ] <Error> BaseDaemon: 3. /lib64/libpthread.so.0(+0x7dc5) [0x7f7f22fbcdc5]
2017.08.17 10:41:24.093556 [ 9 ] <Error> BaseDaemon: 4. /lib64/libc.so.6(clone+0x6d) [0x7f7f2088f76d]

Similar problem https://github.com/yandex/ClickHouse/issues/598

ok, then I'll close this one.


Simplify and tidy up scripts~

Hopefully I didn't break anything.
Needless to say, I haven't tried the deploy script... But I'm feeling lucky, I think it should work. Running http-server ./build and then opening localhost:8080 shows the demo as one would expect.
Otherwise the other stuff should work. This depends on react and react-dom being devDependencies, otherwise it won't work.

Ah, the changes to deploy and start look nice. Let me test it out a bit.

The build index was broken without the postbuild script running but the fix was a super small change in the webpack config for that target so... everything else looks good. Haven't tried deploy yet either but I share your optimism. :)


How to use resolve

Guys, with this syntax:
$stateProvider
        .state('home', {
            url: '/',
            template: '<home></home>'
        });

It's possible to use resolve? Or do we need a controller property in the state in order to use it?
Thank you.

what do you mean by resolve? are you talking about
$stateProvider
        .state('home', {
            url: '/',
            template: '<home></home>',
            resolve: {
              yourData: function(yourService) {
                return yourService.getAsyncPromise()
              }
            }
        });

@gdi2290 Yes, How is 'yourData' injected in the controller if we are rendering the component using template. For resolve to work do we need controller: 'HomeCtrl' and templateUrl: 'home.html', don't we? Sorry if I'm missing something.

@santios here's an example
import angular from 'angular';
import uiRouter from 'angular-ui-router';
import homeComponent from './home.component';

let homeModule = angular.module('home', [
	uiRouter
])
.config(($stateProvider, $urlRouterProvider)=>{
	$urlRouterProvider.otherwise('/');

	$stateProvider
		.state('home', {
			url: '/',
			template: '<home></home>',
			resolve: {
			  'yourData': (yourService) => {
			    return yourService.getAsyncPromise()
			  }
			}
		});
})
.directive('home', homeComponent);

export default homeModule;

class HomeController {
	constructor(yourData) {
                console.log(yourData)
		this.name = 'home';
	}
}

HomeController.$inject = ['yourData'];
export default HomeController;

@gdi2290 Thank you for your answer but this is throwing and error: "Unknown provider: myDataProvider"
I think the problem is that you can't inject dependencies to this controller, as the controller is being used inside a directive definition, and we are rendering the component directly in the template option of the state (template: '<home></home>').
import template from './home.html';
import controller from './home.controller';
import './home.styl';

let homeComponent = function(){
	return {
		template,
		controller, //this is home controller, how will resolve inject the data here?
		restrict: 'E',
		controllerAs: 'vm',
		scope: {},
		bindToController: true
	};
};

I think we need a folder called pages, where we use components. For example:
$stateProvider
		.state('home', {
			url: '/',
			templateUrl: 'page.html',
            controller: PageController,
			resolve: {
				myData: function(){
					return promise;
				}
			}
		});

And inside page.html we can use the home component and posible pass the resolved data:
<home myData='ctrl.myData'></home>

What do you think?

$stateProvider
        .state('home', {
            url: '/',
            templateUrl: 'page.html',
            controller: PageController,
            resolve: {
                myData: function(){
                    return promise;
                }
            }
        });

you need to inject your service and return either an object or a promise

@gdi2290 I have exactly same issue with resolve as @santios so what is the proper solution for this problem?

@martinmicunda this is solved in angular2 but you would handle it like this in a directive
import template from './home.html';
import controller from './home.controller';
import './home.styl';

let homeComponent = function(){
    return {
        template,
        controller, //this is home controller, how will resolve inject the data here?
        restrict: 'E',
        controllerAs: 'vm',
        scope: {},
        bindToController: true
    };
};

home.controller.js

class HomeController {
    constructor(YourService) {
        console.log(YourService);
        this.yourData = [];

        // resolve data
        YourService.getAsyncPromise().then(res => {
          this.yourData = res.yourData;
        });

        this.name = 'home';
    }
}

HomeController.$inject = ['YourService'];
export default HomeController;

the resolve is a way for us to synchronously load our data before we load our template. With the directive we don't really have that luxury without wrapping the directive

@gdi2290 yeah that's what I start doing but then I got more complex example with onEnter and that doesn't work either...
    $stateProvider
        .state('employees.add', {
            url: '/add',
            onEnter: function($stateParams, $state, $modal) {
                $modal.open({
                    template: template,
                    resolve: {
                        languages: LanguageResource => LanguageResource.getList(),
                        positions: PositionResource => PositionResource.getList({lang: 'en'}),
                        roles: RoleResource => RoleResource.getList({lang: 'en'})
                    },
                    controller: 'EmployeesAddController',
                    controllerAs: 'vm',
                    size: 'lg'
                }).result.finally(function() {
                        $state.go('employees');
                    });
            }
        });

@martinmicunda You won't be able to use much more than the template and controller option inside the state object. If you really want to do this, you should create a pages folder ( that will bring up some duplication) and create there a plain controller with a view using the components, something like this:
pages/main/
 main.controller.js
 main.js
 main.html

Inside main.html:
<home></home>

And in main.js you can use the normal resolve with all the options you are used too.

There is this solution that keeps both resolve and component in tact:
in home.js
$stateProvider
		.state('home', {
			url: '/',
			controller: function($scope, yourData) {
				this.yourData = yourData;
			},
			controllerAs: 'homeState',
			template: '<home your-data="homeState.yourData"></home>',
			resolve: {
				yourData: function() {
					return 42;
				}
			}
		});

in home.component.js
let homeComponent = function(){
	return {
		template,
		controller,
		restrict: 'E',
		controllerAs: 'vm',
		scope: {
			yourData: '@'
		},
		bindToController: true
	};
};

and in home.controller
class HomeController {
	constructor(){
		this.name = this.yourData;
	}
}

A little bit of boilerplate (that can be customized in the generator's templates) and an additional controller for each component generated, but that does the trick.

@eshcharc That's clever, thank you for sharing.

@santios  If you have a spare time, please open a PR.

to resolve you need to

create resolves in state;
add a controller to the state
inject the data that you want to resolve in the controller
bind the data to your directive in the template
configure your directive to receive data

this works since the template won't load until resolve is finished then it's only a problem of passing the data to the directive

+1. I lost a good few hours of my life trying to fix this in a more elegant way and the page solution feels more palatable than the everything is a directive approach.

Hi @eshcharc (Ma Kore? :)
I've tried your solution 1 for 1, no typos or anything, and for some reason my controller doesn't receive the props i'm binding in the template. Any idea why?

Ok Ok got it!
Not sure why, but my component needed to look a little bit different then your's:
let categoryComponent = {
  restrict: 'E',
  template,
  controller,
  controllerAs: 'vm',
  bindings: {
  	categoryData: '='
  }
};

Glad you could solve that. Next time, don't esitate to call.
Since I started using RxJs I find it rare that I inject to component. I rather subscribe to the proper stream. Try that, it'll change your programmatic life...

In due time :-) thanks!

@eshcharc can you provide an example?

It's not about an example. You will need to read and see what RxJs is all about.
The thing is that you set your model as a stream and register for changes in your componet.
This is quite out of scope here.

@eshcharc I know about reactive programming, I only doesn't thought about representing state as data stream.

State and data manipulation is best achieved with Scan operator.

@santios  @eshcharc @gdi2290 according to the angularjs 1.5.0-rc.0 docs this is how you resolve data for a component:
var myMod = angular.module('myMod', ['ngRoute']);

myMod.component('home', {
  template: '
Home

Hello, {{ home.user.name }} !
',
  bindings: {user: '='}
});

myMod.config(function($routeProvider) {
  $routeProvider.when('/', {
    template: '<home user="$resolve.user"></home>',
    resolve: {user: function($http) { return $http.get('...'); }}
  });
});

hope it works for you

@blackendstudios  but that is ngRoute, this project uses ui-router

yeah yeah,I know, is for illustration porpuses, I that's way I said "@santios @gdi2290 according to the angularjs 1.5.0-rc.0 docs this is how you resolve data for a component"

Sorry guys, I still don't get it.
After running "gulp component --name admin" in my CMD I got this in my admin.component.js:
import template from './admin.html';
import controller from './admin.controller';
import './admin.styl';

let adminComponent = {
  restrict: 'E',
  bindings: {},
  template,
  controller,
  controllerAs: 'vm'
};

export default adminComponent;

and this in my admin.js:
import angular from 'angular';

import uiRouter from 'angular-ui-router';

import adminComponent from './admin.component';

import {default as AdminController} from './admin.controller';

let adminModule = angular.module('admin', [
    uiRouter
]).component('admin', adminComponent);

export default adminModule;

For triggering resolve in ui-router I need to change admin.js to this:
import angular from 'angular';
import uiRouter from 'angular-ui-router';
import adminComponent from './admin.component';
import {default as AdminController} from './admin.controller';

let adminModule = angular.module('admin', [
    uiRouter
])

    .config(($stateProvider, $urlRouterProvider) => {
        "ngInject";

        $urlRouterProvider.otherwise('/');

        $stateProvider
            .state('admin', {
                url: '/admin',
                template: '<admin></admin>',
                controller: AdminController,
                controllerAs: 'vm',
                resolve: {
                    retailersList: ['RestManager', 'AuthManager', (rest, auth) => {
                        if (auth.isLogin() && auth.isAdmin())
                            return rest.getRetailersList();
                        return [];
                    }]
                }
            });
    })

    .component('admin', adminComponent);

export default adminModule;

but now my admin.controller.js file is getting invoked twice and that can't be good!
In the second invocation I'm getting an error:
Unknown provider: retailersListProvider <- retailersList
This is my admin.controller.js file:
let vm = null;

class AdminController {
    constructor(retailersList) {
        vm = this;

        vm.retailersList = retailersList;
    }
}

AdminController.$inject = ['retailersList'];

export default AdminController;

I'm sure I can have all kind of workarounds but what is the best practice?
Thank you.

O.K. I got it:
All I needed to do is replace the templates in the admin.js file and the admin.components.js file like this:
in the admin.js file switch this line:
template: template,

with this line:
template: '<admin></admin>',

and in the admin.components.js file switch this line:
template: '<admin></admin>',

to this line:
template: template,

Also add
import template from './admin.html';

to the top of the admin.js file and delete the same line from admin.component.js file.

but now my admin.controller.js file is getting invoked twice and that can't be good!

What do you expected? You have one controller in state definition and one in component.

what is the best practice?

Well... ok. First of all, data should be passed to component via bindings. (also all your components (i.e. custom elements) should have prefix.)
import template from './admin.html';
import './admin.styl';

// I like to make all components controllers private
// but you chose how to work with them
class MyAdminComponent {
    // this is instead of watchers in controllers
    set list(list) {
        this._list = list;
        this.reactOnListChanges();
    }

    reactOnListChanges() {
       // do stuff...
    }
}

export default {
  restrict: 'E',
  bindings: {
      list: '='
  },
  template,
  controllerAs: 'vm'
};

This is our component. All state which it need will be passed from above via bindings. And this state will be prepared in our route resolvers. One note, consider to move all your resolvers to separate resolver-services.
export function retailersListResolver(rest, auth) {
    "ngInject";
    if (auth.isLogin() && auth.isAdmin()) {
        return rest.getRetailersList();
    }

    return [];
}

// admin.js or somewhere else
import * as resolvers from './resolvers';

angular
   .module('app')
   .service(resolvers); // this will register all your resolvers
   .config(function ($stateProvider) {
        $stateProvider.state('admin', {
            url: '/admin',
            resolves: {
                 'retailersList': 'retailersListResolver' // service instance
            },
            // we need to aggregate resolved values
            // in uiRouter 0.2.19 this will be done automaticly
            controller: function ($scope, retailersList) {
                 $scope.$resolve = {retailersList};
            },
            // now we will pass data to our component
            template: '<my-admin list="$resolve.retailersList"></my-admin>`,
        }
   });

About uiRouter 0.2.19:
controller: function ($scope, retailersList) {
    $scope.$resolve = {retailersList};
}

You can update uiRouter to latest version (i.e. 0.2.19-dev) to get rid of this. This was implemented 2-3 weeks ago and merged into legacy branch.
Does that helped?

That solution looks neat!
Thank you.

@eshcharc Hi, first of all, thanks for your solution I lost a few hours before I found this issue, I'm sorry to bother you but I tried your solution and it doesn't work for me :(
I git cloned the project and started fresh ! I added your solution like that with some debugging
$stateProvider
    .state('home', {
      url: '/',
      controller: ($scope, yourData) => {
        console.log("1 " + yourData);
        console.log(this);
        this.yourData = yourData;
        console.log("2 " + this.yourData);
      },
      controllerAs: 'homeState',
      template: '<home your-data="homeState.yourData"></home>',
      resolve: {
        yourData: () => { console.log('resolving'); return 42; }
      }
    });

and in the controller this is undefined.
Am I missing something ?

@pibouu Hi!

Am I missing something ?

Yep, read about arrow functions and lexical this. This will answer your question. Change it like this:
controller: ($scope, yourData) => {
    $scope.$resolve = {yourData};
},
// controllerAs: '$ctrl'  - no need for this since we are using scopes
template: `<my-home your-data="$resolve.yourData"></my-home>`

@fesor you should use array dependency annotation
{
    controller:['$scope', 'yourData', ($scope, yourData) => {
        $scope.$resolve = {yourData};
    }],
    // controllerAs: '$ctrl'  - no need for this since we are using scopes
    template: `<my-home your-data="$resolve.yourData"></my-home>`
}

@fesor @blackendstudios Thanks for your replies thank you so much ! ! It works fine now !
ps: I used the legacy branch with the 0.2.18 of ui-router.

@blackendstudios I use latest version of uiRouter, so i just don't need controller at all. But yes, you are right.

@fesor 0.2.19-dev not exist. 1.0.0-alpha.4 at that moment

Hi guys,
if someone is still interesting, I made it work using ui-router 1.0.0-alpha.5, and following ToddMotto styleguide.
and this is how the code shoud look like
/* ----- todo/todo.component.js ----- */
import template from './todo.html';
import controller from './todo.controller';

const TodoComponent = {
  bindings: {
    todoData: '<'
  },
  controller,
  template: template
};
export default TodoComponent;

/* ----- todo/todo.controller.js ----- */
class TodoController {
  constructor() {
      "ngInject";
      console.log('this is the data from resolve', this.todoData);
  }
}

export default TodoController;

/* ----- todo/index.js ----- */
import angular from 'angular';
import TodoComponent from './todo.component';

const todo = angular
  .module('todo', [])
  .component('todo', TodoComponent)
  .config(($stateProvider, $urlRouterProvider) => {
    "ngInject";
    $stateProvider
      .state('todos', {
        url: '/todos',
        component: 'todo',
        resolve: {
          todoData: PeopleService => PeopleService.getAllPeople();
        }
      });
    $urlRouterProvider.otherwise('/');
  })
  .name;

export default todo;

hope this help.

How can you test state resolves with this approach? I've been trying various approaches and nothing is working. Any help appreciated :)
EG my state resolve:
$stateProvider
    .state('someState', {
      url: '/p/:id',
      resolve: {
        someData: (myService, $stateParams) => {
          return myService.getTheData($stateParams.id);
        }
      },
      controller: ['$scope', 'someData', ($scope, someData) => {
        $scope.profile = someData.data;
      }],

      template: '<some-page profile="someData"></some-page>'
    });

simplified spec:
beforeEach(function(){
  window.module(Services.name);
  window.module(($provide) => {
    $provide.value('profile', { name: 'testing' }  );
  });
});

beforeEach(inject((_$rootScope_, _$q_, _$httpBackend_, myService) => {
  $rootScope = _$rootScope_;
  $q = _$q_;
  deferred = _$q_.defer();
  $httpBackend = _$httpBackend_;
  myService = myService;
  scope = $rootScope.$new();
  scope.vm = $rootScope.$new();
  spyOn(myService, 'getTheData').and.callThrough();
  makeController = () => {
    return new MyController(myService, {$scope: scope, profile: mockProfile });
  };
}));

describe('Controller', () => {

  it('should have a heading property', () => {
    // let vm = makeController(myService, {$scope: scope, profile: mockProfile});
    let vm = makeController();
    expect(vm.profile.name).toBeDefined();
  });

});

@ttbarnes #199

using @albert5287 solution seems to work fine for my until one point. I have access to $ctrl.todoData, but within my controller this.todoData stays undefined.
For async issue I've tried a simple $timeout, which returns a promise in default. Am I missing something?

@albert5287 solution seems to work.
Anyway I experience an odd behavior.
The resolved variable isn't instantly available on my controller.
For testing purpose and to sort out async issue I gave it a try using $timeout in resolve route.
Resolve:
testResolve: $timeout => $timeout(() => ...., 5000)
Controller:
console.log('resolved', this.testResolve) -> display undefined.
However if I put another $timeout within my Controller and set it to 1millisecond, I get the resolved var.
Controller:
$timeout(() => console.log('resolved from timeout', this.testResolve), 1); -> displays test data.

I am confirming what @salacis is seeing in my own code.

@Incognito That the usual behaviour of an component. Take a look at this.$onInit = () => {}. Your resolved variables will be there when everything is loaded properly.

Oh, that works much better. I'm now using this pattern:
 class SomeController {
  constructor(SomeApi, $stateParams) {
     "ngInject";
     this.SomeApi=SomeApi;
     this.someId = +$stateParams.someId;
  }

  $onInit() {
    // Actual logic...
  }

Thanks for the tip!

That's not the appropriate way to use it. look at this https://toddmotto.com/angular-1-5-lifecycle-hooks

After reading the onInit part of code, the specific problem you see with that code was not obvious to me. Is the issue that it contains all logic, or that it is defined at initialization instead of in the constructor?

@Incognito $onInit method is responsible to component initialization. Constructor should not contain any logic.
By doing this you could create instance of component, pass data to it and then call $onInit method for component initialization. This simplifies testing and extension of components.

I don't quite get it.
In the Todo example this code exists:
https://github.com/AngularClass/NG6-todomvc-starter/blob/master/src/app/components/todoItem.component.js
export class TodoItemController {
  constructor(todoList) {
    "ngInject";
    this.todoList = todoList;
    this.isEditing = false;
  }

  onDestroyClick() {
    this.todoList.remove(this.task);
  }
// ...

In my example I also inject dependencies via the controller and perform logic inside other methods. In the Todo example it's a method on the controller, and in mine it is a lifecycle hook.
.... is the issue my injection of $stateParams in the constructor?

In the Todo example this code exists:

todoList is dependency of an component. There is no any logic or data retrieval.  As for isEditing, it is just initial state of this component. Only component itself responsible for it's initial state (encapsulation and stuff).

is the issue my injection of $stateParams in the constructor?

Yep. By doing this you couple your component to specific route which isn't that flexible. Components != screens. You could have some-kind of top-level components which defines screens, but they should delegate all presentation responsibilities to lower-level components and pass data via binding.
It will be better if you pass all resolved values directly to components binding. UI Router allows that.

I think I can test both, no?

Yes, you can, but when state defined via bindings it's easier.

Oh I think I get it now. That would let me modify stateful dependencies per instance instead of component instead of the same dependencies every time via ng inject. That's cool.


FZF_DEFAULT_COMMAND breaks when SHELL set to pwsh

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[x] Windows
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[ ] fish
[x] pwsh

Problem / Steps to reproduce
When $env:SHELL or $SHELL is set to pwsh -NoLogo on Windows or /usr/bin/pwsh or *nix ( in my case it is RHEL 9 ), usage like
$env:FZF_DEFAULT_COMMAND = 'fd.exe'
fzf

fails with command failed.
I have even tried
$env:SHELL = 'pwsh -NoLogo -NoProfile -ExecutionPolicy Bypass -NonInteractive -InputFormat Text -OutputFormat Text -Command'

on Windows and it still fails.
Workaround
On Windows set $env:SHELL = 'cmd.exe'. On *nix running pwsh, do $env:SHELL = '/usr/bin/bash' or the like.

@mattcargile I am encountering the same issue. Have you been able to diagnose the underlying mechanism(s)? If not, could you share any promising leads that you think I could build on to troubleshoot myself?

@mattcargile I am encountering the same issue. Have you been able to diagnose the underlying mechanism(s)? If not, could you share any promising leads that you think I could build on to troubleshoot myself?

I'm not sure how to debug it unless you understand the fzf source and how it uses that environment variable.
I did just try setting $env:SHELL = 'pwsh' and it does work. Adding the parameters is what breaks it. Maybe try it without parameters?

Ah, that explanation seems likely. I've run into issues with Windows treating things like that as a command name (i.e. just the resolvable name of an executable) rather than a command invocation/expression (i.e. to be parsed into a command to execute and arguments to pass to it).
Does fzf have any mechanism to specify a default command for shell invocations that fzf will take care of parsing/interpreting itself? (analogous to the currently-supported environment variables FZF_DEFAULT_COMMAND, FZF_CTRL_T_COMMAND, etc.)

Ah, that explanation seems likely. I've run into issues with Windows treating things like that as a command name (i.e. just the resolvable name of an executable) rather than a command invocation/expression (i.e. to be parsed into a command to execute and arguments to pass to it).
Does fzf have any mechanism to specify a default command for shell invocations that fzf will take care of parsing/interpreting itself? (analogous to the currently-supported environment variables FZF_DEFAULT_COMMAND, FZF_CTRL_T_COMMAND, etc.)

I looked briefly at the README.md and didn't see anything. I might try creating a bat or cmd file as your $env:SHELL to get the features you want?


Question: Is it necessary to use the tok2vec component?

Hi! I've been doing some NER on a reasonably large number of documents using the specialised NER models, and to speed things up I have disabled a number of components including tok2vec. Is this likely to affect performance? I don't have an evaluation set with which to test yet. Equally, what i the minimum set of components I need to run the NER models?

Closing due to inactivity, feel free to reopen if you still have questions.

Thanks!


Reject conversion from userdata to Object.

Most of userdata should not be set to share hash.
Let's think of the following example.
-- Create WScript.Shell.
local ole = nyagos.create_object("WScript.Shell")

-- Launch notepad.exe
-- This will launch notepad.exe successfully.
ole:Run("notepad.exe")

for i=1, 10 do
    -- Save ole in share hash.
    share.ole = ole
    ole = nil

    -- The following ensures that ole object is garbage-collected.
    -- As a result, ole:__gc is called.
    collectgarbage("collect")

    -- Retrieve ole from share hash.
    ole = share.ole
end

-- The following may fail and cause crash because ole:__gc has been called and
-- `Data *ole.IDispatch` in capsule_t has already been released.
ole:Run("notepad.exe")

In the above example, the second call of ole:Run may fail because ole:__gc has already been called and Data in capsule_t has been released.
In general, setting userdata object to share hash causes this kind of issue because Lua VM cannot manage members in share hash.
Therefore, it may cause duplicated call of __gc and other unexpected behaviors.
To avoid this kind of issues, this patch always rejects conversion from userdata in Lua to Object in Golang.
This patch may affect existing Lua scripts, which store userdata to share hash, such as capture_t, method_t, iolines_t, stream_t and so on although this patch solves the issue.

Ok. To avoid crashes, I accept some restrictions.
I consider that it is not a heavy problem that share[] can not contain userobjects.
I worry about the cloned Lua-instance to make a background goroutines for pipelines.
But it is a smaller problem than crashes.
Thank you.


Fix bug with jumping content and little refactoring

Hi, thanks for the component. When working with it, I had a small bug, so I decided to fix it and make a pull request.

Also, it's better to use scrollHeight instead of offsetHeight, so you will not need to do any tricks with setTimeout. I certainly added $nextTick(). Also, I did not understand why change the styles via dom directly, and not use the vue capabilities.

Hey, thanks for the PR!
Can you describe the bug you fixed? I'm not sure I understand.
Also, I think you used the Prettier code style, correct? Before, it was Standard, and because of the added commas and semicolons, the diff is larger than it should be, which makes it hard to see what exactly you changed.
If you want, you can resubmit with those things fixed, otherwise I'll close this in a few days.

In project not set standard eslint, my code editor use airbnb. I change codestyle.
Bug:
If you set active: false by default, then content is jumping. Component take too many time for calc height.

@danieldiekmeieri recommend you to rewrite everything he did with your code, but with your own eslint settings. Because my eyes hurts when i see what was before 😄


Selection unexpectedly dismisses after dragging mouse from the input/textarea to the browser's toolbar

Context
One of our testers noticed that when you drag a mouse from the textarea to the browser's toolbar - the selected annotation gets dismissed:
https://github.com/user-attachments/assets/37360bd9-1740-4668-89bb-6729a82838f2
Issue
During the investigation, I found that the dismissal is triggered by the pointerup handler. Especially by the following lines: https://github.com/recogito/text-annotator-js/blob/682af04e5df8d2da5013a14dbed2d988fc99ece0/packages/text-annotator/src/SelectionHandler.ts#L162-L167
https://github.com/recogito/text-annotator-js/blob/682af04e5df8d2da5013a14dbed2d988fc99ece0/packages/text-annotator/src/SelectionHandler.ts#L145-L147
That's because when you quickly drag your mouse from the input/textarea to the toolbar - the captured selection range is collapsed (1). And the pointerup targets the html element (2).

Therefore, such a combination passes as the "click" over an empty area in the pointerup listener:

Example
I'm able to consistently replicate the issue even using the text-annotator-react example popup by extending timeDifference "click" timeout:

https://github.com/user-attachments/assets/25ecd56a-a125-4880-9faf-d1849446c98d
Suggested Changes
We can additionally check whether the ephemeral "click" is about to get processed on the html element. If so - skip the processing.

I believe that the issue is widen than I initially anticipated!
The annotation also gets dismissed when I select the text within the input/textarea, drag the mouse over the annotatable area, and release it.
The nature of the dismissal is the same as before - we unexpectedly process releasing of the mouse as the click.
https://github.com/user-attachments/assets/5965e07f-bf2c-41b7-a0c8-b776c21b0dfd

I think that the issue can be generalized to the "don't process the click when the pointerdown event started on editable area". I'll create a new one of that


How to set up in docker compose?

I am trying to set up zeronsd in docker using the docker compose. Cannot find documentation on how to do it.
Also I would like to not expose the zeronsd to any other on service on the server. Do I need the docker container to join the network if the host has already joined the network?

With the current released docker image you won't be able to do it. You'll have to build you own image so you can set the ZEROTIER_LOCAL_URL env var. That being said, I was not able to actually fully get it working this way yet.

anyone having issues building images? i would like to setup zeronsd like this.


Error related to too many generated variables

This error is difficult to recreate unless the file being recreated is very large, such as a spreadsheet with multiple large datasets.
There is a small possibility that the amount of generated variables will exceed the allowed amount as dictated by dotnet.  This is rare but should be addressed to achieve one of the goals of this project. (i.e.: To successfully recreate as many Microsoft Office documents as possible to their entirety without errors using the code generated by this library).
One possible solution to this is to allow the library to reuse variables already generated when possible but that will take time to work on.

Issue should be resolved now with 13dfd56b1645e998648b2fcceda6d580386b55c3 commit


Create PULL_REQUEST_TEMPLATE.md

Should probably say these changes will be relevant across all the repos if the above has been copied to them.


missingin directory

where is the components directory, needed following files :

<rel="stylesheet" type="text/css" href="components/bootstrap/dist/css/bootstrap.min.css">
<rel="stylesheet" type="text/css" href="components/font-awesome/css/font-awesome.min.css">
<rel="stylesheet" type="text/css" href="components/rdash-ui/dist/css/rdash.min.css">

Run bower install inside the project directory and check the src/components path.

@avijais @berlinquin I have the same problem after checking out the repo and following the installation steps in the README. I replaced components with ../bower_components/ inside index.html and did some gulp config modifications -  this seems to do the trick.


IconProp typings issue

Getting the following error:
 node_modules/@zopauk/react-components/types/components/atoms/Icon/Icon.d.ts:5:5
    5     variant: IconProp;
          ~~~~~~~
    The expected type comes from property 'variant' which is declared here on type 'IntrinsicAttributes & IconProps'

This should be set to IconDefinition not IconProp
https://github.com/zopaUK/react-components/blob/d8a467120a524681cea658f88c83ac9c71a4a801/src/components/atoms/Icon/Icon.tsx#L5-L7

:tada: This issue has been resolved in version 4.25.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create test_plugin.py

test pep8speaks PR

Hello @AirlineDog! Thanks for opening this PR.

In the file jarviscli/plugins/test_plugin.py:

Line 11:8: E225 missing whitespace around operator
Line 11:9: E226 missing whitespace around arithmetic operator
Line 12:9: E225 missing whitespace around operator
Line 13:7: E111 indentation is not a multiple of four
Line 14:12: E225 missing whitespace around operator
Line 14:12: E711 comparison to None should be 'if cond is None:'
Line 15:7: E111 indentation is not a multiple of four
Line 16:11: E201 whitespace after '('
Line 16:13: E202 whitespace before ')'

Do see the Hitchhiker's guide to code style


Feature/add anatomogram celltype heatmap experiment page

These changes were included in PR https://github.com/ebi-gene-expression-group/atlas-web-single-cell/pull/120.


Crash without internet connection

If i start ui auth flow intent without an internet connection, i can see the account picker but when i tap on my account i got this crash:
com.google.android.gms.tasks.RuntimeExecutionException: com.google.firebase.FirebaseException: An internal error has occured. [ Internal error. ]
at com.google.android.gms.tasks.zzh.getResult(Unknown Source)
at com.firebase.ui.auth.ui.AcquireEmailHelper$1.onComplete(AcquireEmailHelper.java:57)
at com.google.android.gms.tasks.zzc$1.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5951)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1400)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1195)
Caused by: com.google.firebase.FirebaseException: An internal error has occured. [ Internal error. ]
at com.google.android.gms.internal.zzacq.zzbN(Unknown Source)
at com.google.android.gms.internal.zzacn$zzg.zza(Unknown Source)
at com.google.android.gms.internal.zzacy.zzbO(Unknown Source)
at com.google.android.gms.internal.zzacy$zza.onFailure(Unknown Source)
at com.google.android.gms.internal.zzact$zza.onTransact(Unknown Source)
at android.os.Binder.execTransact(Binder.java:446)

Hey,
This issue is already fixed for the next release of Firebase Auth; the library will correctly throw a network error in this case. We'll need to test that we're handling this new exception in FirebaseUI appropriately, so I'll leave this open until we confirm it's fixed when the new version lands.

@iainmcgin Has the new version you mentioned been released yet?
I tested the authentication flow without a network connection and received the following:
07-12 15:49:26.080 9698-9698/in.iamkelv.golink W/AcquireEmailHelper: Error fetching providers for email
                                                                     com.google.firebase.FirebaseNetworkException: A network error (such as timeout, interrupted connection or unreachable host) has occurred.
                                                                         at com.google.android.gms.internal.zzafg.zzes(Unknown Source)
                                                                         at com.google.android.gms.internal.zzafd$zzg.zza(Unknown Source)
                                                                         at com.google.android.gms.internal.zzafo.zzet(Unknown Source)
                                                                         at com.google.android.gms.internal.zzafo$zza.onFailure(Unknown Source)
                                                                         at com.google.android.gms.internal.zzafj$zza.onTransact(Unknown Source)
                                                                         at android.os.Binder.execTransact(Binder.java:453)

Is there a way I can neatly handle com.google.firebase.FirebaseNetworkException? It would be good to let the user know that the connection failed.

@kz I just released version 0.4.3, I am not exactly sure which commit Iain was referencing but can you check if your issue was fixed?

@samtstern Thanks for your reply. Unfortunately, I have decided to go with FirebaseJS in an Ionic app instead. If I do get this error again while using Firebase for Android in the future, I will be sure to let you know.

@kz good luck with Ionic!  Closing this issue for now, if someone else has the same problem they can open a fresh issue.

Still facing this issue on Android 5.0 . Updated firebase core to 10.0.1.

Got this crash using firebase-auth 15.0.0


test: restoring tests

10.4.0 has been released and contains a fix for the issue.
Feel free to reopen the issue or to submit a new one if you meet any problems.


import data from external VC

If I have AViewController, and I put KSTokenView on BViewController.  I need segue some data in a dataArray from A to B, when B get it, it should tokenise all data into several token. Unfortunately, I could not figure out how-to.

here is my code:
override func viewDidAppear(animated: Bool) {
super.viewDidAppear(true)
    if count(tagsArray) > 0 {
        tokenView.becomeFirstResponder()

        for i in 0...(count(tagsArray) - 1) {
            if count(tagsArray) == 1 && tagsArray[0] == "" {
            } else {
                let token = KSToken(title: tagsArray[i])
                tokenView.addToken(token)
            }
        }
        tokenView.resignFirstResponder()
    }
}

However, if I use this, it will show up suddenly! If I put it in other method,such as viewDidLoad() or viewWillAppear(), all titles will NOT tokenise!

@fealonelei I guess the KSTokenView is not properly initialized, before tokens are being added.
I'll look into this issue as soon as get to my work computer.

My KSTokenView on BController is a view on xib, I set its outlet to code.
then,
override func viewDidLoad(){
tokenView.delegate = self
tokenView.promptText = "    "
tokenView.placeholder = "input more tags when click space "
tokenView.maxTokenLimit = 20 //default is -1 for unlimited number of tokens
tokenView.style = .Squared
tokenView.font = UIFont.systemFontOfSize(14)
==============
// if I put code here, when view show up, the tokenView will be empty.
if count(tagsArray) > 0 {
tokenView.becomeFirstResponder()
       for i in 0...(count(tagsArray) - 1) {
           if count(tagsArray) == 1 && tagsArray[0] == "" {
           } else {
            let token = KSToken(title: tagsArray[i])
            tokenView.addToken(token)
        }
    }
      tokenView.resignFirstResponder()
  }
  }

@fealonelei Issue is fixed in latest commit d7892e2d0f8cc0845a57d3d878ac8fb702fb5911
You can reopen the issue if there is still problem.


Issue 258 - Added Google Chrome Badge

Hi Adam,
This pull request adds a Google Chrome badge to indicate to the user whether their selection will be rendered or unrendered. This was mentioned in Issue #258 (Make toggle button more state-aware).
There was an earlier pull request that had messy commits (PR #315 ). This contains the same content but tidier.
Here's a snippet of the badge:

Refactor changes
In the markdown-here.js file, we pulled out some code inside markdownHere and put it into a new function getMarkdownRenderObject so that we could reuse it. You'll see there's a another new function called selectionContainsRenderedMarkdown that needed the same code.

There's a problem with the behaviour: getOperationalRange changes the current selection, so calling it (via the selectionContainsRenderedMarkdown check) messes up any existing selection. I fooled around with saving and restoring the selection before and after the call, but:

It's complicated enough to do right that it would probably necessitate introducing the rangy library.
It makes me uncomfortable to be rapidly changing the selection as the user types. Seems ripe for bad behaviour.

I don't see this as an essential-enough feature to introduce this complexity.
I'm going to close this PR and the issue it implements, to dissuade additional implementations. They can be reopened if the situation changes.
I appreciate the effort you went to.


Show verbatim scientific names for occurrences in tables etc which have TAXON_MATCH_NONE or TAXON_MATCH_HIGHERRANK

Extracted from the comment thread on #341

I understand "closed" means fixed in this case. Right?
But how long does this take to go live in portal site?
Thanks

Typically within a couple of days. At times within hours.


ui: new history screen

Part of #806
New design for history screen

The original design has some problems:

It probably based on an outdated version of the app, where we show a simple list of past run (each run contains multiple benchmarks)
Since we want to sort and filter the results, we must show it at one deeper level (benchmark instead of run).
For now, I just updated the old result screen with this new simple design. We can improve it further if our designer has some new design.

 →

@banjo247 Please check my first comment related to the design.

@banjo247 ping, we need your comments

@anhappdev Let's remove the sorting feature, just sort the dates (either ascending or descending)

New history screen https://github.com/mlcommons/mobile_app_open/pull/866


Looking forward

Have been thinking a lot about how to make the POS class more directly comparable. What I've concluded is that proportions are the way to go; i.e. in a given sentence, how many words are adjectives/nouns/etc.? So that's what my current implementation does, but if anyone has further ideas, let me know!

I'm currently working on a project that would use text analysis to determine subject matter of the content and I think it'd be a great direction for your class. Please let me know if it's something you'd be open to, as I'd love to implement it in my project.


[HA] k3s master nodes should check if the bootstrap data isnt available

Version:
v0.10.0-rc2
Describe the bug
Currently if multiple k3s servers started in HA mode and without one of them having --bootstrap-data the whole cluster will fail to start and the following errors will appear:
Oct 19 18:16:03 ip-172-31-5-95 k3s[2986]: time="2019-10-19T18:16:03.662147564Z" level=error msg="Update cert unable to convert string to cert: Unable to split cert into two parts"
Oct 19 18:16:03 ip-172-31-5-95 k3s[2986]: time="2019-10-19T18:16:03.945490466Z" level=info msg="Connecting to proxy" url="wss://<IP_ADDRESS>:6443/v1-k3s/connect"
Oct 19 18:16:03 ip-172-31-5-95 k3s[2986]: time="2019-10-19T18:16:03.947296126Z" level=error msg="Failed to connect to proxy" error="x509: certificate signed by unknown authority"

To Reproduce

start external database (postgres)
start 3 k3s servers and connect them to this database

Expected behavior
k3s server should fail fail properly if it can't find the bootstrap data, or as an alternative bootstrap the server if it can't find the data.
Actual behavior
3 masters will generate different certificates and errors above will be seen

Closing as Out Of Date, HA works fine in current version of K3s (v1.20-v1.23)


Rename transfer/approval "id" to "subject"

Depends on https://github.com/hyperledger/firefly-tokens-erc1155/pull/67 and https://github.com/hyperledger/firefly-tokens-erc20-erc721/pull/42

Codecov Report

Merging #709 (138a302) into main (39991ae) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #709   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          323       323
  Lines        19887     19886    -1
=========================================
- Hits         19887     19886    -1

Impacted Files
Coverage Δ

internal/database/sqlcommon/tokenapproval_sql.go
100.00% <100.00%> (ø)

internal/database/sqlcommon/tokentransfer_sql.go
100.00% <100.00%> (ø)

internal/events/tokens_approved.go
100.00% <100.00%> (ø)

internal/events/tokens_transferred.go
100.00% <100.00%> (ø)

internal/tokens/fftokens/fftokens.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39991ae...138a302. Read the comment docs.


feature request : tree-style-  triangle

how about adding a modern tree node indicator,  triangle
example :  https://bootstrapstudio.io/

please check the Demo: http://www.treejs.cn/v3/demo.php#_515

in your old-version(i guess 3.5,17)  ,  triangle is implemented.
but in later version ,  splite of triangle is deprecated.
why ?
i implemented triangle with font-awesome , but this one  looks  more smart !!
.
what about recall triangle  ??
.
http://<IP_ADDRESS>:81/webhtml/稻壳/D17-01古籍-书目库/html/plug-ins/ztree/demo/en/excheck/checkbox_count.html

@alpastar
This is only demo. If you want to see the code,please visit : https://github.com/zTree/zTree_v3/tree/v3.5.17
but I don't remember that I use the  trangle.


Parse Marathon volumes into service property

Extend MarathonUtil to parse volume data (container, tasks) into a service volume property.

Reviewer: @mlunoe

SGZM!


Order list of files by name

Although I'd like to have them ordered by name reversed, that would add additional buttons, ... I think this is so far a simple solution to have files at least in order

LGTM. Can you sign the Google CLA? https://cla.developers.google.com/

Done
On Thu, Oct 15, 2015, 03:32 Ross Light<EMAIL_ADDRESS>wrote:

LGTM. Can you sign the Google CLA? https://cla.developers.google.com/
—
Reply to this email directly or view it on GitHub
https://github.com/zombiezen/filedrop/pull/7#issuecomment-148259326.


send (at least) 1 REV to each registered REV address

@leithaus took the ball on this
@ian-bloom noted there's a small window between when the list of addresses is fixed and when voting opens. @leithaus acknowledged.

voting costs ~0.05 REV, so 1 REV is enough to vote 20x

10 test rev have been sent to all registered accounts using https://github.com/rchain-community/rv2020/blob/rank-order/src/cli/distributerev.rho
To use this on mainnet to fromAddr and uri of the Set of registered members needs to be updated.

Having this on the rank-order branch is awkward: I don't want to land most of that branch, but this looks good.


xwj

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided - Closing


Opentoonz base module

I had to remove the analyze() function, so opentoonz dependencies will not render. But I think that not many people need it. In any case, this can be added later.
Also, tcomposer has no (or maybe hidden?) Options for setting the scene resolution, so it always renders to the scene resolution tnz

I think this should be merged now. Future improvements can be added as separate PRs. Thank you!


TileMap

use tile map assets and create collsions

changed from large to small as took way less than expected

@msorret


Start developing an experimental SSR package

What is the change that we're proposing and/or doing?
Use a third party community solution, Method 1 - Stencil Wrapper with modifications, to allow the GCDS components to work in an SSR environment.
Consequences

What becomes easier or more difficult to do because of this change?
Proposed solution patches the @stencil/core package that the components use to render, patch could potentially not work after any stenciljs update.
Lots of custom work involved to make this work

Checklist:

[ ] Setup branch with project configured to our project
[ ] Remove use of window in components (top-nav, side-nav, topic-menu)
[ ] Change attributes to use camel case (buttonRole instead of button-role).
[ ] Build in an exception for our

non-shadow-dom components.

Part of #613


podfingerprint: exclude terminal method

Add new pfp computation method
that only considers pods which are non-terminal state. A pod is in a terminal state if .status.phase in (Failed, Succeeded) is true.

/hold

need to rethink about that


Add 3D Mobjects - Cone, Cylinder, Line3D, Arrow3D and Torus.

Motivation
To include more standard 3D mobjects for users.
Overview / Explanation for Changes
Added more 3D mobjects - Cone, Cylinder, Line3D, Arrow3D and Torus. Mostly taken and modified from dor2727's inactive PR.
For PRs introducing new features, please provide code snippets
using the newly introduced functionality and ideally even the
expected rendered output. -->
Oneline Summary of Changes

- Added more 3D mobjects (:pr:`1026`)

Testing Status
Added four five tests in test_threed.py
Further Comments

My first ever open source contribution, please be gentle :)

Acknowledgements

https://github.com/ManimCommunity/manim/pull/657

https://github.com/3b1b/manim/blob/master/manimlib/mobject/three_dimensions.py

[x] I have read the Contributing Guidelines

Reviewer Checklist

[ ] Newly added functions/classes are either private or have a docstring
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The oneline summary has been included in the wiki

Hi @Darylgolden , thanks for the contribution! Also, way to pick up on the older PRs -- we definitely need to handle more of the older issues/PRs. As a first pass, LGTM!
We could improve this PR by adding documentation for your new threed_mobjects, or even short samples videos in the docstring for your classes (and perhaps the other already existing 3D mobjects while we're on this python file).

We could improve this PR by adding documentation for your new threed_mobjects, or even short samples videos in the docstring for your classes (and perhaps the other already existing 3D mobjects while we're on this python file).

As 3d rendering is very slow, I would recommend to use only images in the docs and no videos.

We could improve this PR by adding documentation for your new threed_mobjects, or even short samples videos in the docstring for your classes (and perhaps the other already existing 3D mobjects while we're on this python file).

As 3d rendering is very slow, I would recommend to use only images in the docs and no videos.

Adding to that, note that the example I made uses the directive:
    .. manim:: ExampleCone
        :save_last_frame:

which will only save the last image.

For now actually, feel free to keep the get/set methods and such, but you do still need to change where you access width/height attributes as that will break on the master branch

Sorry for the trouble @friedkeenan, but can you provide an example of how I should change my code? Still not very familiar with how python properties work.

It's no trouble don't worry. Basically, on master setting obj.width and obj.height will scale the object to fit that width/height, but currently you're setting stuff like self.height to store the argument that was passed to the constructor. I think you should be able to just stop setting that attribute and it'll work fine

@friedkeenan Ah, I think I get what you mean now. I've replaced self.height with self._height, and the tests seem to pass now. Can you check that it is acceptable?

@Darylgolden You'll need to pull the latest changes into your fork's master, handle any merge conflicts, and push the updates to this feature_3d_mobjects branch afterwards. Quite a few commits have been merged into master since the initial work was done in your branch.

This is really strange, as far as I can tell the only thing that changed by resolving the merge conflicts is poetry.lock, which was changed as I had to re-create the poetry shell (for some reason after I did it the tests passed). Do you happen to know why this is happening?

Never mind, I fixed it.

I think the directions are currently flipped:
cone = Cone(direction=-Z_AXIS)
gives me

I think the directions are currently flipped:
cone = Cone(direction=-Z_AXIS)

This is the intended behavior (the direction indicates which direction the Cone's apex should point in). What I find strange is that the default Cone() object is positioned with it's tip at the origin (instead of the base resting on top of the XY plane), but this is just changing the default behavior. Other 3D Mobjects put the center of mass at the origin (e.g. Sphere, Cube, Cylinder).

I don't think positioning a cone's tip at the origin as a default is unnatural; it's the cone generated by z = k*sqrt(x^2+y^2), which seems to me like the most natural equation for a cone. I don't think placing the cone with the center of mass at the origin is very natural (since it is 1/3 or 1/4 from the base to the tip); I can change the default behavior if needed though.

I don't think positioning a cone's tip at the origin as a default is unnatural; it's the cone generated by z = k*sqrt(x^2+y^2), which seems to me like the most natural equation for a cone. I don't think placing the cone with the center of mass at the origin is very natural (since it is 1/3 or 1/4 from the base to the tip); I can change the default behavior if needed though.

I think we can keep it like it is, thanks for clarifying!

I don't think positioning a cone's tip at the origin as a default is unnatural; it's the cone generated by z = k*sqrt(x^2+y^2), which seems to me like the most natural equation for a cone. I don't think placing the cone with the center of mass at the origin is very natural (since it is 1/3 or 1/4 from the base to the tip); I can change the default behavior if needed though.

Not needed, but just thought I'd point that out.

Wasn't planning on ignoring them - I was just committing the "easy" fixes and then fixing the rest later.

That's my bad, I seem to struggle in pasting code with proper indentation from editor to github.


Added upgrade notification component to About page.

Closes "Move the "update available" notification to the about page." part of #5071
Currently when a new upgrade is available, a banner displayed on top of the header, on all pages, which doesn't go away until the blog is upgraded. This message was moved to About page. The message won't go away till the blog is upgraded but it's far less annoying.

New release notifications are shown only in About page instead of as a banner on the top
Added gh-upgrade-notification component and upgrade-notification service
app/routes/application.js looks for notifications of type "upgrade" and invokes upgrade-notification service to render the message in about.hbs.
Added gh-upgrade-notification CSS classes to render message in red.
Picked some fixes https://github.com/TryGhost/Ghost/pull/5670/files

WRT the ember destructuring - most if not all of the files in the ember codebase have been converted to use it so there's lots of examples 😄
Congrats on the first PR though, looks good 👍

@acburdine thanks a bunch for the tip! I've fixed destructuring and linting errors. Hope this works.

@vkandy Apologies if I wasn't clear in my initial comment. This is what I meant by destructuring:
instead of this:
import Ember from 'ember';

const {
  Component
  inject: {service}
} = Ember;

export default Component.extend();

Do this:
import Component from 'ember-component';
import injectService from 'ember-service/inject';

export default Component.extend();

This uses the shims from this library and there's a couple example PR's that I did recently that convert a lot of the const destructuring over to the new shims imports: #95 #101 #110 .
Sorry if it seems a bit nitpicky, but since most if not all of the code uses the new shims code it'd be nice to have it consistent 😄

This has fallen behind but I've fixed the tests and grunt validate and grunt test-ember look OK. Please review. Thanks!

hey @vkandy I'll review this in a bit, but would you mind rebasing against master so it's easier to tell what your changes are? right now it includes changes from several other pull requests.
 Hope this is OK? Thanks for all the tips and being patient!

Looks great, thanks! Will review this later today hopefully.

LGTM 👍


Memory Pool destructor uses allocator_default.

In MemoryPool.h, the destructor uses allocator_default even if a allocator function has been provided via roctracer_properties_t and was used in the constructor.
https://github.com/ROCm-Developer-Tools/roctracer/blob/0876c253d8b6380a1d6bd1f2b34c5b4c1e8c94db/src/core/memory_pool.h#L91-L98
If custom memory management is carried out in properties.alloc_func, then the required custom free-ing of the memory cannot be matched when the allocator default is used in the destructor. This creates a double-free or other possible problems.

@TimourPaltashev any progress here?

Hi Kiumars,
Do we have any activity on this issue??
https://github.com/ROCm-Developer-Tools/roctracer/issues/54
Many thanks,
TT.
From: Bert Wesarg @.>
Sent: Tuesday, June 14, 2022 11:50 AM
To: ROCm-Developer-Tools/roctracer @.>
Cc: Paltashev, Timour @.>; Mention @.>
Subject: Re: [ROCm-Developer-Tools/roctracer] Memory Pool destructor uses allocator_default. (#54)
[CAUTION: External Email]
@TimourPaltashevhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTimourPaltashev&data=05|01|Timour.Paltashev%40amd.com|cc6cb0c65d5d4f40be8c08da4e36b087|3dd8961fe4884e608e11a82d994e183d|0|0|637908294263493089|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=2JSDS5%2BZwbqbu18DfK2MeTYcZMg6LnkokpWqXkiPFqg%3D&reserved=0 any progress here?

Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FROCm-Developer-Tools%2Froctracer%2Fissues%2F54%23issuecomment-1155597758&data=05|01|Timour.Paltashev%40amd.com|cc6cb0c65d5d4f40be8c08da4e36b087|3dd8961fe4884e608e11a82d994e183d|0|0|637908294263493089|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=LHh3XNFiPQiYVNqRWJtrHUY8drSjPSC7mW8GZZ2%2FhPU%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUTS6PPPULZCFALDMHLHNRLVPDH5TANCNFSM45BEZZOA&data=05|01|Timour.Paltashev%40amd.com|cc6cb0c65d5d4f40be8c08da4e36b087|3dd8961fe4884e608e11a82d994e183d|0|0|637908294263493089|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=JI%2B3IVbwsey%2BtHTR7v94XsusyqCwrBokk6EF%2Bf5UjRU%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

[AMD Official Use Only - General]
Hi Timour,
I think this code has changed for rocm-5.3, let me double check and send you update
Best regards,
Kiumars
From: Paltashev, Timour @.>
Sent: Tuesday, June 14, 2022 12:32 PM
To: ROCm-Developer-Tools/roctracer @.>; ROCm-Developer-Tools/roctracer @.>
Cc: Sabeti, Kiumars @.>; Bert Wesarg @.***>
Subject: RE: [ROCm-Developer-Tools/roctracer] Memory Pool destructor uses allocator_default. (#54)
Hi Kiumars,
Do we have any activity on this issue??
https://github.com/ROCm-Developer-Tools/roctracer/issues/54
Many thanks,
TT.
From: Bert Wesarg<EMAIL_ADDRESS>Sent: Tuesday, June 14, 2022 11:50 AM
To: ROCm-Developer-Tools/roctracer<EMAIL_ADDRESS>Cc: Paltashev, Timour<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [ROCm-Developer-Tools/roctracer] Memory Pool destructor uses allocator_default. (#54)
[CAUTION: External Email]
@TimourPaltashevhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTimourPaltashev&data=05|01|Timour.Paltashev%40amd.com|cc6cb0c65d5d4f40be8c08da4e36b087|3dd8961fe4884e608e11a82d994e183d|0|0|637908294263493089|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=2JSDS5%2BZwbqbu18DfK2MeTYcZMg6LnkokpWqXkiPFqg%3D&reserved=0 any progress here?

Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FROCm-Developer-Tools%2Froctracer%2Fissues%2F54%23issuecomment-1155597758&data=05|01|Timour.Paltashev%40amd.com|cc6cb0c65d5d4f40be8c08da4e36b087|3dd8961fe4884e608e11a82d994e183d|0|0|637908294263493089|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=LHh3XNFiPQiYVNqRWJtrHUY8drSjPSC7mW8GZZ2%2FhPU%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUTS6PPPULZCFALDMHLHNRLVPDH5TANCNFSM45BEZZOA&data=05|01|Timour.Paltashev%40amd.com|cc6cb0c65d5d4f40be8c08da4e36b087|3dd8961fe4884e608e11a82d994e183d|0|0|637908294263493089|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=JI%2B3IVbwsey%2BtHTR7v94XsusyqCwrBokk6EF%2Bf5UjRU%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Fixed in 9d728f74a14cbce6aaa4fa8d74d6be1ab0cd9c84


Black terrain when adding textures

I was just trying to give water noise textures when this happened. Removing the noise textures didn't help, but I had to remove and re-add every texture I had.
Godot 4.2.2
Terrabrush 0.6.1
Edit: The cause is having 2 textures at once, not water

upon further testing, when I tried to add normal textures to the water again, it worked.

Hey @HEofOttoman !
This is due to the fact that not all of your textures share the same format (this is required by the shader).
The thing you should check is the compress mode and the mipmap generation.
Right now you should have an error in the console saying you this.
Also, as soon as you put for example a normal texture, make sure you provide one for all the texture sets.
I talk about this in this video (at about this time) : https://youtu.be/n5WeAqeea1c?t=271
Let me know if it helps 🙂

oh ok thank you. Does it have to be the same file format (ie. all .png or .jpg) because

this happened after I fixed all the settings

Removing the other materials didn't remove the issue either,

reloading the scene only removed the black parts, but turned everything grainy.

I tried to change the compression, but Godot wouldn't let me change it at all

Join discord and can help quicker if you like. Textures need to be of same file and look like this to my knowledge.

Thank you for helping. However, after closing godot and trying again 15 hours later, the issue had disappeared, and all the textures, upon being re-added were working again, even though some of the files have different formats.

Alright, cool! So, I can close this issue for now 🙂?
You can always open another one if needed later!

I will, but one more question

is there a way to fix these artifacts?

Once again, thank you very much. This is a very good plugin.

Sounds good, I'm glad you like it! 🙂


Deploy

Are the deploy docs found here up to date?  I just tried deploying this locally and the site is slightly different compared to the live site on the memex box.
cc @jeffbaumes

No those were not up to date. See #21.

This is outdated.


stable is not stable

I've created a stable branch which does work but I don't consider it a true stable branch. This is just some prep for the next release. Once I have my first true release, I'll close this issue (which is only acting to serve as a reminder).

Stable doesn't exist anymore and our first release is stable.


Reset to default button no longer available

Issue description:
Hi Ari, Hope you're well
Did you remove the Reset to default button? or it since WP 4.9.4?
Thanks
Version used:
v3.0.25
Using theme_mods or options?
Code to reproduce the issue (config + field(s))

Yes it was removed.
https://github.com/aristath/kirki/issues/1600

@Serpentsoft what @anthonyryanrusso is accurate. reset was removed in v3.0.12.
It wasn't working properly and with changesets it's now obsolete


v0.3 Release Tracking Issue

This issue is to give context to the community on the progress being made towards v0.3 release.
The current plan is to release v0.3 in early August 2021.
v0.3 is focused on adding multi-modal image support (#1041), such that AutoGluon can be trained on datasets containing images, text, and tabular data at the same time via the TabularPredictor API.
Images will be sent via a new column in the input pandas DataFrame. This new column will include the string path to disk of the images for each row. Internally, AutoGluon will load these images when necessary to do predictions with image models.
As an additional improvement, AutoGluon's image models are going to be overhauled with the backend changed from MXNet to PyTorch. This effort will unlock more powerful image models to be available in AutoGluon, including EfficientNet. This is currently in progress and is expected to be completed in early August.
Beyond image related improvements, there are various other optimizations and QoL additions as well. An example is #1136 which accelerates  TabularPredictor data preprocessing by 7.8x in online inference situations for problems that include text and tabular data. This enables AutoGluon to have sub 50ms latency when deployed.
The full list of new features and improvements will be provided in the v0.3 release notes.

AutoGluon v0.3.0 is officially released! Release notes: https://github.com/awslabs/autogluon/releases/tag/v0.3.0


Unavailable API

Hi,
I was very excited seeing messaging support in the pybricks API. However, I got stopped in my tracks today when I actually tried to use it. I am currently building a 2-brick model with my son and we were planning to use BT messaging.
Where can I find a pybricks-micropython version that has the API documented here?

We're working hard to get everything online in the week to come. Great to see you found this already :)
You can get the latest build of ev3dev which now comes with pybricks-micropython here:
https://oss.jfrog.org/list/oss-snapshot-local/org/ev3dev/brickstrap/

It is still a beta version, though, so there may be a few things here and there that are not up to speed with the documentation yet.
But messaging is already working. We'd love to hear about your experiences when you try it.

I just found it and I am thrilled! Thanks for getting back to me so fast!
Be assured, I will be beta testing all week for you!

Excellent, much appreciated! Feel free to share your findings at https://github.com/pybricks/support
Extra note while you are testing:
We're trying to make sure that any user script written with version 1.0, will still work in this new release, despite some API changes. So if you still have any old scripts ready to be tried out, we'd love to hear if we broke anything.

Unfortunately, I just started with pybricks and the messaging was my first experiment beyond some trivial motor testing.
When I built a printer/plotter wiht my other sone last year, we used ev3dev2. But given how much faster micropython is (I am joyfully surprised) and how much tighter the controls seem to be, I will switch over completely even with the other project.

No problem, I'm sure there's still plenty we have to fix in the 2.0 version alone :)
Yes, Pybricks has its own set of motor control drivers, which was a major piece of this whole project, so I'm glad its being noticed, and feedback on this is very welcome too.

Ok, Bluetooth is working well. I wish there would be some high-level connectivity control, but I will play around with it.
For example, I would like to leave the server running and restart the client as I keep developing. Having to restart both on every testing cycle is annoying. I am sure I can come up with a solution, but  a child learning this stuff will not. I know it is not easy to do, but a simple is_connected() function would be nice, so when the client disconnects, the server knows to wait for a connection again.
On the other hand, maybe it would be best to hide the connection stuff altogether and only deal with mailboxes. Code behind the scenes can deal with everything connection related.

Thanks for your feedback, glad to hear you got Bluetooth working.
I've copied your feedback to an internal issue about ongoing Bluetooth improvements. Feel free to create a dedicated issue about it if you like though.
As far as this issue is concerned, I've just populated the downloads page with some links. It's very minimal, but at least it can be found now. The docs already have a link to this download page too.
So I think this issue is ready to be closed as the very first public issue. Thanks for reporting! :)