HHH-14513 5.3

Blanket jira for backporting:
https://hibernate.atlassian.net/browse/HHH-14640
Includes the following:
https://hibernate.atlassian.net/browse/HHH-13685
https://hibernate.atlassian.net/browse/HHH-13689
https://hibernate.atlassian.net/browse/HHH-13925
https://hibernate.atlassian.net/browse/HHH-13682
https://hibernate.atlassian.net/browse/HHH-14030
https://hibernate.atlassian.net/browse/HHH-14083
https://hibernate.atlassian.net/browse/HHH-14247
https://hibernate.atlassian.net/browse/HHH-14111
https://hibernate.atlassian.net/browse/HHH-14144
https://hibernate.atlassian.net/browse/HHH-14199
https://hibernate.atlassian.net/browse/HHH-14283
https://hibernate.atlassian.net/browse/HHH-14315
https://hibernate.atlassian.net/browse/HHH-14513
this PR also contains:

the upgrade to Gradle 6.7.1
changes to automate the release process

Thanks @yrodiere for great help with this PR!

Thanks to you for doing the actual work :)

LGTM, though you might want to change the HHH- prefix of the commits to match yours (I think that's what Gail usually does?)

I'm happy to edit the commit messages that are missing the "HHH-" prefix.
IMO, it's not worth the effort to try to figure out the original jira issue for those commits (if there was one). The easiest thing to do would be to create a new jira issue for backporting this work to 5.3. I plan to reference the new jira issue in the edited commit comments for those commits that don't already reference an HHH issue.
@yrodiere, @dreab8, does that sound good to you?

Does this PR change the MANIFEST.MF contents to use different values than before?

LGTM, though you might want to change the HHH- prefix of the commits to match yours (I think that's what Gail usually does?)
I also checked the generated OSGi instructions in MANIFEST.MF; here's the diff:
https://gist.github.com/yrodiere/50b0bb95a44f650a41099e8de1f9b867
As far as I can tell we have the same (expected) differences as in #3080:

In hibernate-core, there are two new imported packages (Import-Package header): com.ibm.websphere.jtaextensions and org.objectweb.jonas_tm. The old plugin didn't detect the dependencies, but the new one does: we load classes from these packages dynamically, if they are present, in the transaction manager code. I made the imports optional and removed the version constraints, since I'm not sure what the version constraints are.

I'm not sure if adding optional dependencies on com.ibm.websphere.jtaextensions + org.objectweb.jonas_tm could cause (surprising) problems in some environments that might find those but previously didn't.
For example, could com.ibm.websphere.jtaextensions cause Hibernate Sessions to auto join JTA transactions automatically in an environment that includes com.ibm.websphere.jtaextensions where as previously without this change that didn't happen?
Is it easier to exclude these new dependencies instead of answering my question for this pr?

In hibernate-core, there is a new Private-Package header that references two packages: org.hibernate.xsd.cfg and org.hibernate.xsd.mapping. From what I can tell, those packages only contain resources (XSD files). They weren't exported in 5.4.7.Final. The Private-Package header is just a byproduct of BND and does not change anything in OSGi runtimes (it's ignored).
In hibernate-gradle-plugin, the Import-Packages for the Groovy APIs no longer point to a specific version (the "version" bit was removed). As far as I can tell, we don't have an explicit dependency to a specific version of Groovy in our own gradle files, so I think it makes sense? I can add a version manually, but I would need to know which version we want to target. Or, you know, we just leave it as is: I might be wrong, but running a Gradle plugin in an OSGi environment looks pretty niche.
All OSGi instructions were removed from javadoc and sources JARs. Apparently they were copied there by mistake. If we wanted to restore them, it would be quite complicated with the new plugin.

IMO, it's not worth the effort to try to figure out the original jira issue for those commits (if there was one). The easiest thing to do would be to create a new jira issue for backporting this work to 5.3. I plan to reference the new jira issue in the edited commit comments for those commits that don't already reference an HHH issue.
@yrodiere, @dreab8, does that sound good to you?

I've created https://hibernate.atlassian.net/browse/HHH-14640

IMO, it's not worth the effort to try to figure out the original jira issue for those commits (if there was one). The easiest thing to do would be to create a new jira issue for backporting this work to 5.3. I plan to reference the new jira issue in the edited commit comments for those commits that don't already reference an HHH issue.
@yrodiere, @dreab8, does that sound good to you?

I've created https://hibernate.atlassian.net/browse/HHH-14640

Sounds perfect, thanks.

For example, could com.ibm.websphere.jtaextensions cause Hibernate Sessions to auto join JTA transactions automatically in an environment that includes com.ibm.websphere.jtaextensions where as previously without this change that didn't happen?

No idea. All I can say is that I'm not aware of any report of this problem in the ~1 year that we've released 5.4 with this patch.

Is it easier to exclude these new dependencies instead of answering my question for this pr?

It's easier. Done. @dreab8 , @gbadner, please note that I added a commit just for this.

Superseded by https://github.com/hibernate/hibernate-orm/pull/4030.


Doesn't work on yosemite ?

Hello, I really appriciated about this project.
It will help me at creating my screencast for video tutorial.
I already installed keycastr via brew on my Mac OS X ( Yosemite ).
And I ran the application. I don't know if i missing something or what.
I'm using the svelte visualizer, because i'm confused about the default visualizer(nothing happens).
when i use svelte visualizer the blackbox appears, and shift,control,option and command button respond to it, but i don't see other button(e.g control C, it should appear ^ C ).
Can you help me about this issue / bug  ?
Thanks

Just installed it on Yosemite, all is fine.


Add instance labels/titles

As seen in https://github.com/confio/cosmwasm-examples/pull/40 there is a desire to label different instances of a contract. The functionality that was added into the contract is not needed by the contract itself, so it should live in meta data.
This is nice for testing, naming, branding no matter which contract you instantiate.
Those labels should be in the list /wasm/code/${id}/contracts

Yes, together with #80 and #75 this should make the list queries much cleaner

This came to my mind when I saw https://github.com/confio/cosmwasm-examples/pull/40 and thought does this really belong here? Does the contract functionality even care about such a name?.

You are right, it does not belong there. It was just to provide what this issue would solve


Grammeme order

pymorphy2 assumes that the first grammeme is a POS tag; it is wrong for LT2OpenCorpora XML export:
<l t="лосняковий">
        <g v="nomn"/>
        <g v="masc"/>
        <g v="ADJF"/>
      </l>

It looks like the source dictionary also has POS tag as a first grammeme, so preserving the original order (when possible, both in <l> and in <f>) should solve the issue.

It seems this is fixed.


Default cli.App.Usage behaviour is very hard to override and leads to ugly help

My urfave/cli version is
v2.27.2
Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here (this is broken btw)
[x] Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

My project is using go modules.

Describe the bug
This line of the code doesn't allow to set an empty cli.App.Usage value, which together with the fact that helpNameTemplate is not configurable makes it hard to have a clean HELP: section in the CLI docs.
https://github.com/urfave/cli/blob/1210bdf785b2bddda680a262acc84d5e7b583460/command.go#L203
To reproduce
Create a cli.App{Usage: ""} or cli.App{} struct and launch it with --help.
Observed behavior
It's not possible to remove the "A new cli application" string from the help.
Setting Usage to " " also leaves the -.
The only way I've found is to entirely override cli.AppHelpTemplate or set Usage: "\b\b ".
Expected behavior
I would like to be able to set Usage to "" without it being overridden, or at least be able to customize helpNameTemplate to be able to remove the part that uses Usage.
Want to fix this yourself?
We'd love to have more contributors on this project! If the fix for
this bug is easily explained and very small, feel free to create a
pull request for it.
Run go version and paste its output here
go version go1.22.2 darwin/arm64

Run go env and paste its output here
GO111MODULE='auto'
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/redacted/Library/Caches/go-build'
GOENV='/Users/redacted/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/redacted/go/pkg/mod'
GOOS='darwin'
GOPATH='/Users/redacted/go'
GOROOT='/Users/redacted/sdk/go1.22.2'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/redacted/sdk/go1.22.2/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.2'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/redacted/cli_path/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/tp/x23ymr696x1fyzfy7rq7fr740000gp/T/go-build457189288=/tmp/go-build -gno-record-gcc-switches -fno-common'

@Amaury-Behague You can set a custom template and override whatever you want in the help text. It is not very user friendly but anyone with a knowledge of go templating should be able to handle it. At this point v2 is in maint mode so we cannot make any changes to the current behavior. If you have an ideas we can incorporate them into v3.


docs(readme): Add release badge to readme

:tada: This PR is included in version 1.6.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


cannot use WSLg and another X server at the same time with different DISPLAYs

Windows build number:
Microsoft Windows [Version 10.0.19045.2311]
Your Distribution version:
Debian 10.13
Your WSL versions:
>wsl --version
WSL バージョン: <IP_ADDRESS>
カーネル バージョン: <IP_ADDRESS>
WSLg バージョン: 1.0.47
MSRDC バージョン: 1.2.3575
Direct3D バージョン: 1.606.4
DXCore バージョン: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windowsバージョン: 10.0.19045.2311

Steps to reproduce:

Start Ubuntu or Debian on WSL2
Start any X server proxy (such as https://github.com/nbdd0121/wsld , just for example) on a different DISPLAY such as :10 (not :0)

WSL logs:
pulseaudio.log
weston.log
stderr.log
WSL dumps:
None
Expected behavior:
The X server proxy should start with no error.
Actual behavior:
$ wsld
Failed to listen: Read-only file system (os error 30)
$ cat .wsld.toml
[x11]
display = 10
force = true
$ ls -al /tmp/.X11-unix/
total 12
drwxrwxrwx   2 root  root     60 Dec 13 15:23 .
drwxrwxrwt 189 root  root  12288 Dec 13 15:25 ..
srwxrwxrwx   1 sumii sumii     0 Dec 13 15:23 X0
$ touch /tmp/.X11-unix/X10
touch: cannot touch '/tmp/.X11-unix/X10': Read-only file system

This is because WSLg hijacks the entire directory /tmp/.X11-unix/ and does not allow to create a different socket like /tmp/.X11-unix/X10 .
A possible fix would be a symlink from only /tmp/.X11-unix/X0 to /mnt/wslg/.X11-unix/X0 instead of "hijacking" the entire directory.

@esumii if you remount /tmp/.X11-unix with rw option then it works. This issue is being tracked by https://github.com/microsoft/WSL/issues/9303

Thanks, but hijacking such a common directory is in general a bad idea.  Symlink would be better.
sudo umount /tmp/.X11-unix
ln -sf /mnt/wslg/.X11-unix/X0 /tmp/.X11-unix/

Thanks but at least I need to use multiple X servers at the same time (for my class at the university, where students use various X servers).


Assign interface Lan to a bridge

Hi,
I cannot " 2) Set interface(s) IP address" to a bridge as LAN interface:
LAN (igb2)      ->
LANWIFI (bridge0) -> v4: <IP_ADDRESS>/24
OPT1 (igb1)     ->
WAN (igb0)      -> v4/DHCP4: <IP_ADDRESS>/24
WIFI (ath0_wlan1) ->

Logout                              7) Ping host
Assign Interfaces                   8) Shell
Set interface(s) IP address         9) pfTop
Reset the root password            10) Filter Logs
Reset to factory defaults          11) Reload all services
Power off system                   12) Upgrade from console
Reboot system                      13) Restore a configuration

Enter an option: 1
Valid interfaces are:
igb0             00:0d:b9:47:2c:4c Intel(R) PRO/1000 Network Connection, Version - 2.5.3-k
igb1             00:0d:b9:47:2c:4d Intel(R) PRO/1000 Network Connection, Version - 2.5.3-k
igb2             00:0d:b9:47:2c:4e Intel(R) PRO/1000 Network Connection, Version - 2.5.3-k
ath0_wlan1       04:f0:21:2e:55:42
ath0              Atheros 9280
You now have the opportunity to configure VLANs.  If you don't require VLANs
for initial connectivity, say no here and use the GUI to configure VLANs later.
Do you want to set up VLANs now [y|n]? n
If you do not know the names of your interfaces, you may choose to use
auto-detection. In that case, disconnect all interfaces now before
hitting 'a' to initiate auto detection.
Enter the WAN interface name or 'a' for auto-detection: igb0
Enter the LAN interface name or 'a' for auto-detection
NOTE: this enables full Firewalling/NAT mode.
(or nothing if finished): bridge0
Invalid interface name 'bridge0'
Enter the LAN interface name or 'a' for auto-detection
NOTE: this enables full Firewalling/NAT mode.

Which version are you on? Which version did this stop working? Was it ever working? Option "1" is for first time setup: physical and VLAN, Option"2" is for light reassignment. You said option "2" but pasted option "1".

opnsense-17.1.4
I think it never worked.
I cannot assign lan to bridge on option 1 too.

We won't change interface assignment. Extended configuration (beyond ethernet and VLANs) is created via the GUI or a config import from a previous system.
IP assignment works for assigned interfaces including a bridge, I just tested this...

Timeout


验证安装的时候报错，Userwarning

/home/yuyue/下载/mmdetection-master/mmdet/core/anchor/builder.py:17: UserWarning: build_anchor_generator would be deprecated soon, please use build_prior_generator
'build_anchor_generator would be deprecated soon, please use '
Use load_from_local loader
/home/yuyue/下载/mmdetection-master/mmdet/datasets/utils.py:69: UserWarning: "ImageToTensor" pipeline is replaced by "DefaultFormatBundle" for batch inference. It is recommended to manually replace it in the test data pipeline in your config file.
'data pipeline in your config file.', UserWarning)
/home/yuyue/下载/mmdetection-master/mmdet/core/anchor/anchor_generator.py:324: UserWarning: grid_anchors would be deprecated soon. Please use grid_priors
warnings.warn('grid_anchors would be deprecated soon. '
/home/yuyue/下载/mmdetection-master/mmdet/core/anchor/anchor_generator.py:361: UserWarning: single_level_grid_anchors would be deprecated soon. Please use single_level_grid_priors
'single_level_grid_anchors would be deprecated soon. '
mmcv-full         1.3.13
mmdet             2.16.0
torch                1.8
cuda                 10.2
what cause this, please help me!

This is only a warning, there is no error report.


Use release drafter github action to generate new release content

https://github.com/marketplace/actions/release-drafter

https://github.com/abap-observability-tools/abap-log-exporter/blob/main/.github/workflows/update-changelog.yml


I have downloaded nicolaka/netshoot image and when i scanned i found some critical vulns. Are there any plan to mitigate these vulnerabilities? or do you have any alternate fix for these? Are you planning to address any of these vulnerabilities?

github.com/influxdata/influxd
github.com/emicklei/go-restful
golang.org/x/net
github.com/opencontainers/runc
golang.org/x/net
github.com/containerd/containerd
golang.org/x/crypto
golang.org/x/text
github.com/docker/docker
go.etcd.io/etcd
am seeing vulnerabilities for the above packages @nicolaka

https://github.com/zhangguanzhang/netshoot


project type filter for ddev list command (ddev list --type=)

The Issue
As a user of many different local installed ddev projects I want to filter the ddev list output. Currently we have the only-active flag available.
Additionally we could filter by project type.
How This PR Solves The Issue
The PR restructures the parameters of the list command into a struct. This prepares the command to get additional filters in the future like tags.
Manual Testing Instructions
Run the ddev list command with new filter option -t or --type and set a project type
Example: ddev list -t php or ddev list -t magento2.
The filter can be combined with active only filter.
ddev list -A -t php
Automated Testing Overview
I added a simple test which filters by a not existing type. Currently I am looking for a good way to test also the project type filter by an existing type.

What do you think @cmuench , does this have a future?

@rfay The filter is already working. I had a bigger idea but we can start with this approach. That's why it's currently marked as draft.

This is looking quite good and is a major code improvement, thanks!
It's missing

the proper updates to docs to mention the new feature, https://ddev.readthedocs.io/en/latest/users/usage/commands/#list
It needs to have examples add in the command so ddev help list will show this option (and perhaps others).

Done

This is looking quite good and is a major code improvement, thanks!
It's missing

the proper updates to docs to mention the new feature, https://ddev.readthedocs.io/en/latest/users/usage/commands/#list
It needs to have examples add in the command so ddev help list will show this option (and perhaps others).

it's done

Yay, thanks. Back now and will catch up on PRs eventually :)

Yay, thanks. Back now and will catch up on PRs eventually :)

No pressure. I was not sure if I had to inform you.


Super CSV Eclipse IDE

Hi all.
So, i'm having trouble "installing" the library in Eclipse IDE. Mostly becaus it has no JAR files (i think).
Is there anyway to put it to work? or any explanation to why i'm having such difficulty?
Thanks all
Best Regards

1.Using by super-csv source code
Use the following command
git clone https://github.com/super-csv/super-csv.git
mvn package

jar files in /target for each subproject.(java version: 1.8, mvn version: 3.5)
2.Using in Maven Project
Please read: http://super-csv.github.io/super-csv/downloading.html
I'm glad to help you

I guess it depends on what you mean by "installing" the library.
Do you need to use SuperCSV from inside your own application? Then you need the JAR file, or need to use Maven and a pom.xml file where you configure SuperCSV as a dependency inside.
Or do you need to clone SuperCSV and play around with the SuperCSV code itself inside Eclipse?


Re-init example to support RN 0.37

I was unable to launch example project both on iOS and Android.
Probably because it uses old native project templates (no MainApplication.java, old AppDelegate.m, etc.), but modern version of react-native js module.
So I ran react-native init from scratch and copied js code back into new project.
Now it works with react-native 0.37.

ty


How to retrieve current cublasHandle_t

How is it possible to get the current cublasHandle_t in lua, so that I can pass it to some custom ffi function.  For example I have an C function in some library void fwd_gpu(cublasHandle_t cublas_handle) that I want to call via ffi.
Previously, I could do ffi.cast('THCState*', cutorch.getState()).currentBlasHandle, but it seems the structure has changed.
Looking at the current struct, it should be something likeffi.cast('THCState*', cutorch.getState()).resourcesPerDevice.blasHandles[0]. However, this returns NULL.
Any ideas?

the right way is to call this C function (you can call it via ffi too)
https://github.com/torch/cutorch/blob/master/lib/THC/THCGeneral.h.in#L159

Sorry, I dno't see cutorch.getDeviceBlasHandle() within torch, only cutorch.getBlasHandle() which returns a number, but not the handle?

it's not exposed as a cutorch function, it's only exposed at the C level.

Are there any reasons why this functionality is not exposed as a cutorch function?
Of course it is no problem to implement it, but I think it would nice to have nevertheless.

no strong reason, we have just not done it.

no strong reason, we have just not done it.


Update typo

describe your changes...

[ ] Read and sign the CLA. PRs that haven't signed it won't be accepted.
[ ] Make sure your PR complies with the writer's guide.
[ ] Review the diff carefully as sometimes this can reveal issues.
[ ] Do not abandon your Pull Request: Stale Pull Requests.
Remove these instructions from your PR as they are for your eyes only.

Thanks but it's on purpose if you read the above paragraph.


Add output location to pipeline submitted dialog

Enhance pipeline submitted dialog with more information about where the experiment outputs are located

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Latest dialog version


Backend doesnt build

Problem persists when after you add admin and pass for user in cookiecutter steps, DB and connections fail. Browser console also outputs this:
Request URL: http://localhost/docs
Request Method: GET
Status Code: 404 Not Found
AND
Request URL: http://localhost/api/v1/login/access-token
Request Method: POST
Status Code: 404 Not Found
Remote Address: [::1]:80

@acidjunk Should i do a git pull to update?

Thanks for the help @acidjunk ! :cake:
If this was related to those issues, this should be fixed in master, so you could re-generate the project with the new changes.
Otherwise, the best way to debug it would be to check your logs.


Could not find method google() for arguments [] on repository container.

Finished installing it, react-native run-android outputed the following error:
* Where:
Build file '...\node_modules\react-native-android-location-enabler\android\build.gradle' line: 5

* What went wrong:
A problem occurred evaluating project ':react-native-android-location-enabler'.
> Could not find method google() for arguments [] on repository container.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 15.523 secs

{
react-native-cli: 2.0.1
react-native: 0.53.0
}

Did you add google() repo in your android/build.gradle ?
buildscript {
    repositories {
        jcenter()
        google()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.1.3'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
        google()
    }
}

I didn't, then I followed this thread react-native-community/react-native-svg/issues/584  which suggests the same thing you said. Apparently I have to update my projects gradle wrapper, unfortunately this causes conflicts with a few other installed packages.


Solution dependencies fail due to RuntimeIdentifier being forwarded

I have a project with multiple RuntimeIdentifiers and it fails to build a solution reference which doesn't have a RuntimeIdentifier.
Error is
Assets file 'C:\DEV\xenko\sources\core\Xenko.Core.Tasks\obj\project.assets.json' doesn't have a target for '.NETFramework,Version=v4.7.2/win7-d3d11'. Ensure that restore has run and that you have included 'net472' in the TargetFrameworks for your project. You may also need to include 'win7-d3d11' in your project's RuntimeIdentifiers.

I think what it needs is to have RuntimeIdentifier in the ProjectReferenceWithConfiguration.GlobalPropertiesToRemove:

MSBuild code reference (where TargetFramework is hardcoded):
https://github.com/Microsoft/msbuild/blob/e77fa08888dbf7d6478b7659aeaccc39ce04c435/src/Tasks/ResolveProjectBase.cs#L280

I could fix the problem with this kind of target:
  <Target Name="_XenkoRemoveRuntimeIdentifierFromSolutionDependencies" AfterTargets="AssignProjectConfiguration">
    <ItemGroup>
      <ProjectReferenceWithConfiguration Condition="'%(ProjectReferenceWithConfiguration.ReferenceSourceTarget)' != 'ProjectReference'">
        <GlobalPropertiesToRemove>%(ProjectReferenceWithConfiguration.GlobalPropertiesToRemove);RuntimeIdentifier</GlobalPropertiesToRemove>
      </ProjectReferenceWithConfiguration>
    </ItemGroup>
  </Target>

Can you please submit a PR with the fix?


DPDK 23.11, ARM compatibility, Dockerfile enhancments

Updated to DPDK 23.11. With this, the meson build system with pkg-config is preferable to the previous method for handling DPDK builds, since it greatly decreases build system complexity and allows for more end-user customizations.
Added support for aarch64. The main area of incompatibility was around timers. Machnet proper leverages DPDK's timer library for this, the shim uses include/pause.h, which will error out if the architecture is unsupported. Tests on AWS show that msg_gen and pktgen work as expected.
A docker bake file has been added (docker-bake.hcl), which allows building a matrix of docker containers at various microarch versions. This enables machnet users to take advantage of newer instruction sets. Additionally, an Amazon Linux docker container has been added in addition to the Ubuntu container as a proof of concept for additional distros. The docker bake file currently defaults to the America/New_York timezone, but I'm open to moving it to UTC.
The revised dockerfiles also give more control over what is built into DPDK. Currently, all raw, crypto, baseband, dma, event, regex, ml, gpu, vdpa and compress drivers are compiled out, and several of the "common" drivers (driver libraries for multi-function devices) are also disabled. This disables Marvell Oceton family DPUs and some NXP SOCs by default due
to the large size of the drivers. It also disables all apps aside from
testpmd (used for validing an environment) and all NIC PMDs which aren't machnet compatible.

@microsoft-github-policy-service agree company="MongoDB"

Thanks Owen, this is great work. Let's merge this.

The PR removes the use of ${RTE_SDK} from some CMakeLists.txt + requires a system-wide installation of DPDK in /usr. This breaks my bare-metal (non-Dockerfile) builds, but I think this is fine. Let's support only Docker builds going forward.

ADD https://github.com/DPDK/dpdk.git#v23.11 ${RTE_SDK} doesn't work for me. Instead I had to uncomment the RUN git clone line. I'm using Docker version 20.10.12.

Did you get a chance to test the PR with msggen on x86 too?

* The PR removes the use of ${RTE_SDK} from some CMakeLists.txt + requires a system-wide installation of DPDK in `/usr`. This breaks my bare-metal (non-Dockerfile) builds, but I think this is fine. Let's support only Docker builds going forward.

If you want a custom location for DPDK, you would now do that via standard pkg-config environment variables. PKG_CONFIG_PATH is the variable to use for ubuntu builds.

* `ADD https://github.com/DPDK/dpdk.git#v23.11 ${RTE_SDK}` doesn't work for me. For some reason, in the container image, it ends up creating a `/root/dpdk` file instead of a directory. Instead I had to uncomment the `RUN git clone` line. I'm using Docker version 20.10.12.

The feature was merged in 2022, which might be why. Is there a minimum docker version I should target? Due to docker recommending you pull from their repos directly, I've typically only written for 6-month-old versions under the assumption most people were relatively up to date. Is there a minimum version of docker you want to support? 4 years old seems like a bit much.

* Did you get a chance to test the PR with msggen on x86 too?

I was not able to test on x86 aside from compiling for it under qemu emulation. I'm confident enough to pass it over to you for proper testing (which I can't do because of the difficulty of me accessing Azure environments) since most of what I did was either changing the names of defines or dealing with changed struct members.

Thanks, this makes sense.
We don’t list a minimum supported docker version yet, as we haven’t faced a compatibility issue before. I find it useful that the old Dockerfile works with the package manager’s (e.g., apt) default docker on all OSes we’ve tested. In this case the benefit of breaking compatibility with old Docker versions seems minor, so I suggest we use the “git clone” method.

We don’t list a minimum supported docker version yet, as we haven’t faced a compatibility issue before. I find it useful that the old Dockerfile works with the package manager’s (e.g., apt) default docker on all OSes we’ve tested. In this case the benefit of breaking compatibility with old Docker versions seems minor, so I suggest we use the “git clone” method.

Do we want to toss the bake file then? That's only for relatively recent versions of docker, but it's by far the most convenient way to build a matrix of containers for different distros. We could also require a more up to date docker for anyone building the full matrix of containers. The reason I originally used ADD was because the full matrix downloads each repo 6 times per distro, enough to start to get concerned about rate limiting if we were to add Azure Linux or Redhat's UBI containers to the list, or add in Azure Cobalt CPUs. ADD makes it cached so it's only 1 download.

I’m fine with requiring a more up to date docker for anyone using the bakefile.

I’m fine with requiring a more up to date docker for anyone using the bakefile.

Ok, I'll move things back to git clone.

Thanks, merging.

Just noting for the future: we should ensure that things work with stock Ubuntu 20.04, which some current Machnet users depend on.


Update readme.md

Revising w/ X, username, emoji
Objective
Complete assignment!
Changes made
Adding username & emoji as well, since I failed to do that the first time. Whoops.
Who needs to review this Pull Request?
@stalerat and @anna586

🛳 approved!


Feat: vela up support read from stdin

Signed-off-by: Jianbo Sun<EMAIL_ADDRESS>Description of your changes

I have:

[x] Read and followed KubeVela's contribution process.
[x] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Pasting or writing a Yaml, especially with EOF in the command line is difficult. Any background for this feature?

Pasting or writing a Yaml, especially with EOF in the command line is difficult. Any background for this feature?

you can see the picture in the PR description.

Pasting or writing a Yaml, especially with EOF in the command line is difficult. Any background for this feature?

you can see the picture in the PR description, it's also a feature of K8s. Unix style pipe, for example:
cat vela.yaml | vela up -f -

It's friendly to cat a file. Do users have to paste a YAML as in the picture?

Pasting or writing a Yaml, especially with EOF in the command line is difficult. Any background for this feature?

you can see the picture in the PR description, it's also a feature of K8s. Unix style pipe, for example:
cat vela.yaml | vela up -f -

It's friendly to cat a file. Do users have to paste a YAML as in the picture?

Our docs use in this way, this can be easily copy paste.


Inquiry and Suggestions Regarding OpenBLAS Code Flow with OpenMP

Hello,
I've been delving into the OpenBLAS codebase, specifically focusing on the gemm_driver function in level3_thread.c with the #USE_OPENMP=1 flag enabled. I've come across a section in the code where a lock is used in the Pthreads and Win32 backend before initializing and assigning the blasqueue. The lock is released only after the exec_blas call is completed.
My current understanding is :

In the case of Pthreads The thread pool is initialized (POSIX), and when a BLAS call is made, the thread pool is utilized to execute it, after which the threads go back to sleep. The use of locks ensures that only one exec_blas call can be executed at a time.

If I use a thread pool with No_of_threads < nthreads (number of queue partitions) defined in level3_thread.c, I encounter a deadlock within the inner_threads function.
There seems to be significant busy-waiting (NOP) inside the inner_thread function call for thread synchronization.

I have a few questions and want to seek suggestions from the community:

I noticed that OpenMP locking mechanisms like omp_set_lock are not used, and instead, busy-waiting is implemented inside the exec_blas function in blas_server_omp.c using max_parallel_number. Could you please provide insights into this choice?

The inner_thread function appears to encounter deadlock when used with fewer threads. I tested this in OpenMP by creating a parallel region inside exec_blas in line 437 - blas_server_omp.c with a fixed number of threads less than nthreads. Could you shed some light on the reasons behind this behavior?

Considering the busy-waiting in the code, have there been considerations for putting threads to sleep or employing other synchronization methods to enhance efficiency?

I would appreciate clarification on these points.

regarding 1. The code involving max_parallel_number is only a stopgap "solution" (from #1536) for the case when an OpenMP program makes two or more concurrent calls to BLAS functions and the calls to exec_blas would end up using the same queue buffers. For calls from within an OpenMP parallel region, OpenBLAS will currently use a single thread only (see omp_in_parallel() conditional in common_thread.h). Generally, the OpenMP code in OpenBLAS for the most part dates back to the original GotoBLAS2 of 15 years ago, so tends not to use more recent OpenMP features. I am currently trying to unravel all this, but it is turning into a bigger task than I anticipated...
2., Unfortunately it is not quite clear to me what you are trying to do with using fewer threads inside the level3 code, possibly you are accidentally creating a situation where part of the code still expects all threads to be in use ? At least I am not aware of deadlocks in "normal" operation.
3., the pthreads code already utilizes a configurable THREAD_TIMEOUT for putting idle threads to sleep, the omp server code appears to rely on the OMP_WAIT_POLICY of the OpenMP implementation to do the right thing. The busy-waiting inside the inner_thread is a feature inherited from GotoBLAS2 (for which almost no documentation of implementation details exists)

Hi @martin-frbg

I see the issue #1536 and that openMP goes to single thread execution when it sees that it is in OMP_Parallel region but instead of looping in a while(true) loop to acquire a memory region isn't it better to use omp_locks there or conditional wait policy. Suppose we have 32core machine with 32 parallel instances with NUM_PARALLEL=1 then only one of them gets the access and other 31 instances are busy waiting in a while loop and wasting other cores.

I tried limiting the number of OpenMP threads at line 438 in blas_server_omp.c and it gets stucks. The value of num was supposed to be 32.

It is getting stuck inside inner_threads function in level3_thread.c.

I suspect it is waiting for all threads to come before moving forward but since the number of threads are lower than num variable in blas_server_omp.c it is getting stuck.

Similar to (1), I can see we have used YIELDING inside inner_threads function which internally is just a bunch of NOP instructions. It is similar to busy waiting. Shouldn't we use some conditional waiting instead? I think OpenMP has taskyield and task priority which can be used instead of YIELDING with some architectural changes.

It is entirely possible that you know more about the topic than me, and as mentioned the core parts here stem from a time when large, fast multiprocessor machines barely existed. (The pthreads build was not thread safe at all back then, I suspect OpenMP was mostly used as an opaque way of getting around that)
There have been a few discussions about doing away with the ugly YIELDING in the past, but nothing conclusive came out of them.

FYI it appears that taskyield is an empty stub in GCC's libgomp - the situation appears to be better with LLVM's libomp at least from about 2020 onwards but I have not checked in depth if it is implemented as anything fundamentally better than the current YIELDING.

While I'm still looking into this, unfortunately I have not seen any gains from your suggestions - though perhaps I am doing something wrong. Did you try with omp_set_lock() yourself ?
The busy waiting is a complicated topic, we've discussed and experimented with various alternatives since years (e.g. #1051) without conclusive results and I notice the BLIS project is stuck in the same predicament (e.g. their issue #604).
Lastly, if you want to restrict the number of threads for a given BLAS call, you'd need to do that at the interface stage (or by invoking openblas_set_num_threads() in the calling program) to keep the thread count information consistent across
the program and avoid deadlocks from waiting on phantom threads.

Fundamentally, if you are using a backend like TBB or Cilk or partr, you give it tasks that could be executed in parallel, but you have no control over whether they actually are executed in parallel.   So you cannot use a spin-lock in the tasks that assumes they are running in parallel, and you cannot use openblas_set_num_threads to control the number of threads that will actually be used — instead, openblas_set_num_threads in this context will just set the number of potentially parallel tasks that a dgemm call will be broken into.
That means that you need to replace the spin-lock with something else, either:

expose (e.g. via another callback) the TBB task-group-wait synchronization (or whatever the appropriate API is), and call it instead of a spin-lock
or refactor the inner-thread function into multiple calls to the threading-backend callback, which already waits for all tasks to complete, corresponding to the multiple stages that you currently spin-lock between.
For performance, it might be possible to pass additional hints to the runtime scheduler of TBB (or whatever) hinting that certain tasks should be scheduled onto certain threads.  But fundamentally, you might lose some parallel performance as a tradeoff for attaining better composability.

I guess we could create a separate "spin-lock" function that would have to be overridden in the callback from #4577. Not sure if it is possible to determine at runtime what the threading backend is (or even just if it is TBB), but there is probably no way to come up with a backend-agnostic synchronization mechanism(?).

You could have a function waitgroup(groupinfo) that looks something (crudely) like
if (waitgroup_callback != NULL) {
    waitgroup_callback(groupinfo);
}
else {
    # busy-wait
}

where there would be some API to set waitgroup_callback, and groupinfo would be some data structure with information about the group of tasks you are waiting on (which could be set by the threads callback and passed into the work function via an extra argument).


BadAttributeIdInvalid  when browsing Server

Hello
Great library! I'm developing an OPC-UA Server as module to an existing Machine control software. I'm quite new in OPC-UA world, please forgive me if my question is dumb.
I'm facing a browsing error within standard Server topic with uaExpert:

I think this BadAttributeIdInvalid of ValueRank makes trouble within Kepware Client in browsing phase.
I made a test: In HandleReadRequest I added line 626 .NET:
else if (readValueIds[i].AttributeId == NodeAttribute.ValueRank && !(node is NodeVariable))
{
    res[i] = new DataValue(-1, StatusCode.Good);
}

Now I don't have errors anymore in uaExpert. It means that uaExpert try to get a ValueRank of of a no-NodeVariable. I don't understand why?

UaExpert tries to read all possible attributes for every node to show in its attribute table on the right side of the window, even invalid ones. ValueRank is not valid for values which aren't arrays.


Install dependencies first

Hello, I have project with RDBMS dependency. Same project have pre-install hooks which loads tests data (only for development), then pre-install,pre-upgrade hook which runs migrations (prod) .
First problem is on development - since helm first runs hooks, then installs the chart and dependencies - create-database hook will never succeed, because it requires database running and healthy, but database is installed after the hooks.
Second problem is missing configmap/secrets, because they are not annotated. I managed that with duplicating all the configs with suffix "hook".
But how to overcome the first problem?

It sounds like you have an ordering problem - you want the database to be created and running before you load test data and run migrations. You should probably be using a post-install hook instead.

Ok that makes sense, the only issue is that some services will crash until DB is created... but I guess no easy way to fix this?

If you want things to run in sequential order, you can provide a weight to certain hooks.
From https://helm.sh/docs/topics/charts_hooks/#writing-a-hook:

It is possible to define a weight for a hook which will help build a deterministic executing order.

Hook weights can be positive or negative numbers but must be represented as strings. When Helm starts the execution cycle of hooks of a particular Kind it will sort those hooks in ascending order.


Forced squash-merges have incorrect subject (sync-pr-commit-title)

Description
Whenever I force squash-merge pull-requests there is a high chance that the subject of a PR will get corrupted. And it looks like this wonderful extension is responsible for this - I didn't observe the issue having the extensions disabled.
There are two manifestations of the issue:

The subject will have the trailing ) removed, e.g.: My wonderful feature (#123 for github/myorg/myproduct/pull/123.
The subject will have the second line appended, e.g.: My wonderful feature (#123)Co-authored-by: dotnet-maestro[bot]<EMAIL_ADDRESS>for github/myorg/myproduct/pull/123.

How to replicate the issue + URL
https://user-images.githubusercontent.com/4403806/233512897-bf1236c2-8aef-4081-9862-511eb655a90c.mp4
Extension version
23.4.15
Browser(s) used
Microsoft Edge Version 112.0.1722.48 (Official build) (64-bit)

Thank you for the detailed bug report.
We do have a feature that works on both of those fields when squashing: sync-pr-commit-title
Now I'm not sure why this is happening on force-merged PRs specifically since the UI seems to be the same.

We do have a feature that works on both of those fields when squashing: sync-pr-commit-title

Thank you for pointing me to it. I'm going to disable it and see if the issue goes away.

I have a guess as to why this is happening: is the PR title longer than 70 characters? That would explain the tail of the title appearing in the description box, that's a native GitHub behavior.
Also there's a related feature that clears the description field but I don't remember its name.

No, not that long :) With the extension disabled the subject isn't getting trimmed or appended to.

How many commits does the PR have?

There's usually only one commit. Though I have never made any connections.
Here's a recording with the extension disabled:
https://user-images.githubusercontent.com/4403806/233517065-9c886fc8-9bcd-460f-a25c-8f275468eb50.mp4

I'm not seeing any issues on this repo, but also I'm not seeing clear-pr-merge-commit-message (that's likely due to the outdated usage of onPrMergePanelOpen)

Related code that generates the PR commit title:
https://github.com/refined-github/refined-github/blob/db4e57a3f67af5374219e4deb30e1f78de35fc3c/source/features/sync-pr-commit-title.tsx#L21-L24

There's usually only one commit. Though I have never made any connections.

Why use squash merges in that case?
I just checked and actually we only have that check in the feature that clears the description:
https://github.com/refined-github/refined-github/blob/db4e57a3f67af5374219e4deb30e1f78de35fc3c/source/features/clear-pr-merge-commit-message.tsx#L45-L48
So here's what's happening, I think unrelated to forced merges:

sync-pr-commit-title is generating the wrong title
clear-pr-merge-commit-message is skipped

That means that what you have in the description box is unrelated to Refined GitHub, it's just the native behavior which is due to the long commit title.

I appreciate the detailed issue report but it's impossible to actually determine what's happening since the content is private/altered :(
What your screencast suggests is likely not a direct consequence of Refined GitHub as it's impossible that it sets a parens-less title, it's set all at once here:
https://github.com/refined-github/refined-github/blob/f33e0da2d4b1694c642c73705b0e9b9c5085e787/source/features/sync-pr-commit-title.tsx#L23
I'll have to close this until reproducible in the wild.
(I deleted your first screencast because the private URL was showing in some frames)

There's usually only one commit.

Why use squash merges in that case instead of just rebase merges?

Repo policies.

I'll have to close this until reproducible in the wild.

No worries. Thanks for your time.

Yep, that's the second issue I described above.

I just experienced something similar when I opened the merge form just as a new commit was pushed. This caused the form to close and, likely, sync-pr-commit-title to injected it into whatever field was focused: the comment field.


Allow websockets annotation doesn't appear to work

What happened?
Allow websockets annotation does not seem to work when added to an ingress.
What did you expect to happen?
websockets work.
How'd it happen?

kubectl apply configuration below.
visit configured URL
get error about websockets

What's your environment like?

docker desktop k8s cluster on mac
pomerium 0.26.2 via kubectl apply -k github.com/pomerium/ingress-controller/config/default?ref=v0.26.2 and following quickstart guide

What's your config.yaml?
apiVersion: v1
kind: Service
metadata:
  name: code-server
  namespace: gaurdro-dev
  labels:
    app: code-server
    service: code-server
spec:
  ports:
    - port: 8000
      targetPort: 8443
      name: http
  selector:
    app: code-server
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: code-server
  namespace: gaurdro-dev
spec:
  replicas: 1
  selector:
    matchLabels:
      app: code-server
  template:
    metadata:
      labels:
        app: code-server
    spec:
      containers:
        - image: linuxserver/code-server
          imagePullPolicy: Always
          name: code-server
          ports:
            - containerPort: 8443
              protocol: TCP
              name: http
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: gaurdro-dev
  namespace: gaurdro-dev
  annotations:
    ingress.pomerium.io/allow_websockets: 'true'
    allow_websockets: 'true'
    ingress.pomerium.io/allowed_domains: |
      - pomerium.com
    ingress.pomerium.io/pass_identity_headers: 'true'
spec:
  ingressClassName: pomerium
  rules:
    - host: 'gaurdro-dev.localhost.pomerium.io'
      http:
        paths:
          - pathType: Prefix
            path: /
            backend:
              service:
                name: code-server
                port:
                  number:  8000

What did you see in the logs?
requestlogs.txt
Additional context
code-server has been demonstrated to work in standalone mode recently.

The ingress controller is creating the route with the option set. I will try running the code server using regular pomerium to see what's different.

It doesn't work with core pomerium either. It does work with older versions of code-server. I will try to find out when it broke.

It broke with https://github.com/coder/code-server/releases/tag/v4.10.1 . Setting:
preserve_host_header: true

fixed it. This option is available in the ingress controller as:
metadata:
  name: code-server
  annotations:
    ingress.pomerium.io/preserve_host_header: "true"

Added https://github.com/pomerium/documentation/pull/1645.
Going to close this issue since adding the additional annotation fixed the problem.


chore: set up root tsconfig as "solution"

This follows the official handbook for monorepos:
https://www.typescriptlang.org/docs/handbook/project-references.html#overall-structure
Hopefully this will improve the goto references functionality.

@zwave-js-bot automerge


Verify Loader Chaining

Verify, with tests, that you can add post loaders or pre loaders that affect require'ed Opal files. I suspect with the !! in our Webpack requires, you can't.

Might be related to #7


yii/web/Session regenerateID eats errors

This line https://github.com/yiisoft/yii2/blob/master/framework/web/Session.php#L302 eats the error produced when this could have been caught and logged as a warning making this issue much easier to track down.
What steps will reproduce the problem?
Do not give access to the PHP sessions folder

What is the expected result?
Don't eat errors log them as a warning instead or fix root cause of race condition

What do you get instead?
A PHP Fatal Error Using Craft 3 without proper permissions set for the PHP session storage

Additional info
Craft 3.0.6

That's correct but it's there for a reason. You can find in via the link. If you know how to deal with it in a better way, let us know.

can we close this?


Is there a way to get mapWrapper instance so that I can play with geocoding/reverseGeocoding

Thanks for this wonderful repo and Is there a way to get mapWrapper instance so that I can play with geocoding/reverseGeocoding in my own components.

import {GoogleMapsAPIWrapper} from 'angular2-google-maps/services/google-maps-api-wrapper';
...
@Component(...
providers: [GoogleMapsAPIWrapper]
...
constructor(private _mapsWrapper: GoogleMapsAPIWrapper){}

Simply injecting GoogleMapsAPIWrapper will not do the trick there, because _map is private (private _map: Promise<mapTypes.GoogleMap>) and not accessible in component
writing new google.maps.Geocoder() in component is also not working. due to google is undefined error.
So how can i get map instance from GoogleMapsAPIWrapper Service ??

@parmod-arora
I could introduce a new method getMap to get the google map instance from the wrapper. Then you could write a custom component like this (for quick workaround, that works with the current version, you could use the private _map Promise):
<sebm-google-map [latitude]="lat" [longitude]="lng">
  <my-comp></my-comp>
</sebm-google-map>

@Component({
  selector: 'my-comp'
})
export class MyComp {
  constructor(private _wrapper: GoogleMapsAPIWrapper) {
    this._wrapper.getMap().then((m) => {
      // implement your own logic
    }
  }
}
``

sounds like a good idea =]

@SebastianM
I created a pull request. https://github.com/SebastianM/angular2-google-maps/pull/155 (feat(SebmGoogleMap): exposing _map Instance from GoogleMapsAPIWrapper)
but build is failing and i am not able to figure out why ?
https://travis-ci.org/SebastianM/angular2-google-maps/builds/111165799
Can you look at the pull request and provide some kind of documentation for sending pull-requests.

@parmod-arora thanks for the PR. There was an issue in Travis CI. Can you do a rebase (shorten the commit message and add only on commit to the PR)? Then the build should be green.
Thanks!

Oh BTW: I will also add some contribution guidelines very soon.

Thanks for your suggestions,
Every things works as expected please merge below PR.
https://github.com/SebastianM/angular2-google-maps/pull/161

Hi I put together a working example of accessing the native map, it seems to be a little confusing how to use it at first.
https://github.com/philipbrack/example-angular2-google-maps-getNativeMap

@SebastianM is the code you provided still working? GoogleMapsAPIWrapper doesn't seem to have a getMap() method, and neither does the getNativeMap() method actually returns a native map.


Add ability to customize web server bind interface

I liked having the web interface available but didn't like the idea of it being available remotely.

This PR adds the ability to set the interface to bind on.
It also changes the default interface to <IP_ADDRESS>.

I can change the default back to * if you prefer. The readme examples were all using http://localhost:8586 so I wasn't sure if you had intended it to be accessible remotely or not.
The normal method of accomplishing this in docker is to listen on <IP_ADDRESS> within the container and then use -p to map ports out to the host. -p <IP_ADDRESS>:8586:8586 would be the usual method. However, because the container uses the host's network namespace this normal method doesn't work, but it means that binding to <IP_ADDRESS> works for accessing from the host and prevents remote systems from connecting.
Documentation for the server.bind option is https://redmine.lighttpd.net/projects/lighttpd/wiki/Server_bindDetails
I'm happy to make any changes if you like the idea.

Hi, thanks for this pull request. The default bind to * is somewhat intentional as that was the default behaviour of each httpd I tested. The readme mentions http://localhost:8586 as that appears to be a common way for indicating a valid url to a locally running service regardless of how that service is exposed. However you are correct that the readme should have explained that the bind is still *.
Because the default has so far been *, I'd prefer to keep it that way as Docker doesn't have a common way for pushing change notes to user when a new version of an image is used to replace a previous image of the same name and tag. This is the change I'd request you to make as otherwise some existing users would be likely to suddenly loose access to the output on update without any clear indication why. Also since you did encounter the doubt about the default bind, it could be good to mention the default behaviour verbally at least in the "Container content" section, possibly also in "Running the container" if you feel the consequences of this option could use more text/examples.
Regarding the "Environment variables" section addition, I don't think "Network interface of the web server" is totally correct as based on the lighttpd documentation binding using a network interface name isn't supported. As vnStat itself refers to network interface names, it would be better to refer to IP addresses in this context to avoid misunderstandings. The earlier text also uses the term "http server" instead of "web server".

All great points.
I agree that it's probably good to keep the default in order to avoid breaking changes.
Good call on the "network interface" vs. "IP address" in this context to avoid confusion. For "http server" vs "web server" I was just using the terminology from the HTTP_PORT in the line above. I changed all existing instances for consistency now too.
I've made the changes and it now defaults to <IP_ADDRESS>. One part of the lighttpd docs says the default is * but when I tried that it gave an error so I think their docs either didn't mean it literally or are outdated in that part.
I think <IP_ADDRESS> will bind on IPv4 and not IPv6 by my interpretation of their docs. Lighttpd has a whole entry on IPv6 config and says it treats server.bind not being set as a special case and will conditionally bind on IPv6 if server.use-ipv6 is set. If you think it would be better to truly get this default behavior I can modify the start.sh file to just not include server.bind in the config file at all by default and only include it if the environment variable is set. Do you have a preference?

I think it would indeed be better to compare for * in start.sh and leave the server.bind line out if it's a match. That way the lighttpd bind behaviour stays the same by default, just in case there's something left out of the documentation or if it would happen to change in some future version.

I think this should be ready now.
I tested three cases.
1 HTTP_BIND not provided
After starting, it was listening on all interfaces and there was no server.bind field in the config.
$ sudo lsof -Pi | grep 8586
lighttpd  2130696      messagebus    5u  IPv4 91417290      0t0  TCP *:8586 (LISTEN)

$ docker exec -it vnstat cat /etc/lighttpd/lighttpd.conf | fgrep server.bind

2 HTTP_BIND=*
After starting, it was listening on all interfaces and there was no server.bind field in the config.
$ sudo lsof -Pi | grep 8586
lighttpd  2133253      messagebus    5u  IPv4 91507664      0t0  TCP *:8586 (LISTEN)

$ docker exec -it vnstat cat /etc/lighttpd/lighttpd.conf | fgrep server.bind

3 HTTP_BIND=<IP_ADDRESS>
After starting, it was listening on <IP_ADDRESS> and server.bind was set correctly in the config.
$ sudo lsof -Pni | grep 8586
lighttpd  2134951      messagebus    5u  IPv4 91518519      0t0  TCP <IP_ADDRESS>:8586 (LISTEN)

$ docker exec -it vnstat cat /etc/lighttpd/lighttpd.conf | fgrep server.bind
server.bind = "<IP_ADDRESS>"


Create weather android application

Description

You can use any language for android - Java/ kotlin/ flutter
You can create beginner friendly application with your own idea, and designs
Please use appropriate comments to self describe your code
Add necessary readme.md, images, refer other apps for this task
Make sure you don't change other directory projects and don't push/select .idea folder
Already existing weather apps on github will be considered as spam.

You can comment below to get assigned to this issue.

/hlavu


Serve whitehall organisation logos from asset manager

NOTE. This can't be merged until the following dependencies have been deployed:

Upload all existing Whitehall organisation logos to Asset Manager

Merging this change first would result in 404s for organisation logos that don't yet exist on Asset Manager.

Configure Asset Manager to serve Whitehall assets from S3

Merging this PR first would mean we'd invalidate the caches of existing Whitehall organisation logos. While this isn't a big deal in the case of organisations (because there are so few of them) it would potentially cause us problems when migrating a larger group of assets.

This routes requests for Whitehall organisations logos to Asset Manager instead of to Whitehall. See this milestone for more info.
The change to common.yaml results in a new location block being added to the assets-origin Nginx config to proxy the request to static.
The change to static_extra_nginx_config.conf.erb adds a location block to proxy the request to asset-manager. The additional configuration is a duplication of the configuration required to proxy requests for /media to static in the same file. I plan to DRY this duplication up in a subsequent commit.
Requests for organisation logos were previously being proxied from assets-origin to whitehall-frontend by the /government/uploads location configured in hierdata/common.yaml.
I've tested the effect of this change on my development VM and am confident that it's working as expected. I saw the following differences in response headers but I don't think we need to worry about any of them:

Cache-Control

max-age=14400, public from Whitehall
private from Asset Manager
This is expected because I'm running Asset Manager in development mode. It'll add the correct Cache-Control headers in production.

Last-Modified

Wed, 25 Oct 2017 15:01:08 GMT from Whitehall
Wed, 25 Oct 2017 15:00:34 GMT from Asset Manager
This is expected because this was a new image uploaded to Whitehall which was then sent to Asset Manager so it'll have been written to the two different places on disk at different times.

ETag

"59f0a734-13767" from Whitehall
"59f0a712-13767" from Asset Manager
This is expected because this was a new image uploaded to Whitehall which was then sent to Asset Manager. Part of this etag is based on the Last Modified time which, as explained above, is also different.

Strict-Transport-Security

Not present from Whitehall
max-age=31536000 from Asset Manager
This is added by the location block in the static nginx configuration.
It seems fine to add this header given that we want to encourage browsers to always access this site over HTTPS.

Thanks for reviewing, @floehopper. I've addressed your comments and so I think this is ready to merge once we've uploaded the existing organisation logos.

The two prerequisites for this PR have now been completed so I'm going to get this merged!


[20.09] linux-hardened: 5.8.x -> 5.9.x

5.8.x is EOL which is kind of unfortunate for a hardened kernel.
(cherry picked from commit 726d307d2c1ebd43ff616a8f1ff9282202657bcf)

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build linuxPackages_latest_hardened.kernel
Like this?


[Bug Report] DatePicker have a issue when i use daterange in mobile screen it should be one page

Element UI version
2.13.2
OS/Browsers version
Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Mobile Safari/537.36"
Vue version
2.6.9
Reproduction Link
https://codepen.io/pen/?&editable=true=https%3A%2F%2Felement.eleme.io%2F
Steps to reproduce
just open it in the mob screen size it will be very bad
What is Expected?
it shoud be with 2 modes to open in one page in moblie
What is actually happening?
it's open in 2 pages in mobile and desktop

@AhmedShibob I also have this issue on mobile. Just notice your Codepen link doesn't work

@MatanYadaev
It's doesn't work in the official website too  https://lusaxweb.github.io/vuesax/components/upload.html


MINOR: Improve config-streams.html, remove extra

Improve config-streams.html, remove extra
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@dujian0068 Could you attach the fixed output to me? The fix looks good to me but it would be nice to take a look at html result

@dujian0068你能把修复后的输出附给我吗？修复后的效果看起来不错，但最好能看一下 html 结果

hello:
I have deployed the fixed HTML page here：
http://<IP_ADDRESS>:8080/dev/documentation/streams/developer-guide/config-streams.html
thank you

@dujian0068 thanks for your contribution!


Wrong last image?

Hello,
it seems that the last image is the same as the previous and it is not matching the text before it: "When unsure if a setting is enabled or disabled for a platform you are developing for, reference the URP assets contained within the Mesh Toolkit Uploader's URP folder".
Thanks,
Pekka Kaipiainen

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: dd327c11-3ea7-2f39-bea1-8bd669ef8e21
Version Independent ID: dd327c11-3ea7-2f39-bea1-8bd669ef8e21
Content: Model textures
Content Source: mesh/develop/design/model-textures.md
Service: mesh
GitHub Login: @typride
Microsoft Alias: vinnietieto

I inserted the correct image.


Unable to upload dataset to the new data portal

When i am trying to upload datasets using latest swcc to the new data portal i am facing the following the error:
I tried using both the xlsx and swproj as project file.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/sci/mkaranam/Desktop/ShapeWorks/Python/shapeworks/shapeworks/upload.py", line 88, in upload_dataset
    dataset.add_project(Path(project_file))
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/swcc/models.py", line 380, in add_project
    project = Project(
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/swcc/models.py", line 268, in create
    value.create()
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/swcc/models.py", line 399, in create
    self._load_data_spreadsheet()
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/swcc/models.py", line 409, in _load_data_spreadsheet
    xls = load_workbook(str(file), read_only=True)
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/openpyxl/reader/excel.py", line 317, in load_workbook
    reader.read()
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/openpyxl/reader/excel.py", line 276, in read
    self.read_manifest()
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/site-packages/openpyxl/reader/excel.py", line 134, in read_manifest
    src = self.archive.read(ARC_CONTENT_TYPES)
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/zipfile.py", line 1472, in read
    with self.open(name, "r", pwd) as fp:
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/zipfile.py", line 1511, in open
    zinfo = self.getinfo(name)
  File "/home/sci/mkaranam/miniconda3/envs/ShapeWorks/lib/python3.9/zipfile.py", line 1438, in getinfo
    raise KeyError(
KeyError: "There is no item named '[Content_Types].xml' in the archive"

Looks like the excel file may be corrupted: https://stackoverflow.com/questions/71177086/openpyxl-error-there-is-no-item-named-content-types-xml-in-the-archive
I can send you a better copy perhaps? But I have recently updated (#187) the python client to only accept the swproj type.
Did you get the same error when using the swproj file? It shouldn't need openpyxl in that case. Could you post that log as well?


Batch processing for rcnn prediction

I want to send pictures to rcnn network for prediction by batch. Does the current rcnn function like im_detect() and Predictor() support this. If they do not support this function, what change should I do to achieve the goal?

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


[$500] Web/Desktop - Request skeleton is shown grayed out instead the IOU details.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to a conversation with a request money.
Open the IOU details
Disable the internet connection on the device
Click Delete the request

Expected Result:
Verify the request has been deleted and the IOU preview in conversation has been updated (the message should be still grayed out)
Actual Result:
Request skeleton is shown grayed out instead the IOU details.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.65-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/c09bfa2b-f772-48bc-9a96-f4ba9f867acb
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bdce495f39748b20
Upwork Job ID:<PHONE_NUMBER>575839232
Last Price Increase: 2023-09-08
Automatic offers:

0xmiroslav | Reviewer | 26737448
ginsuma | Contributor | 26737449

@0xmiroslav - bump on proposal review - thx!

@0xmiroslav can you share a bit more context? What do we do with regular messages deleted while offline, strikethrough or no strikethrough? I think this is a good thing to discuss in #expensify-open-source, particularly the detail about the receipt. I think it's fine to not show it, but it'd be ideal to gray it out if it's not too difficult. Can you start that convo?

Payments

[ ] Reporting bonus: N/A
[ ] Contributor: @tienifr ($250 via Upwork)
[ ] Contributor: @ginsuma ($250 via Upwork)
[ ] C+: @0xmiroslav ($500 via Upwork)

@0xmiroslav - can you review this checklist when you have a chance? thanks! https://github.com/Expensify/App/issues/26939#issuecomment-1733296960

kk paid both contributors!
@0xmiroslav im kind of confused about what's going on with your payment but lmk if you need me to do anything with the offer that was sent.
also bump on reviewing this checklist - ty! https://github.com/Expensify/App/issues/26939#issuecomment-1733296960

i will wrap this one up today

okay @0xmiroslav i sent your Upwork profile an offer for this one. once it's accepted, I'll pay it out + the bonus and close this out.

paid!


PP-11463 Test - without truncating

WHAT
A brief description of the pull request:
HOW
Steps to test or reproduce:

Testing - closing branch, no longer required.


Remove dependency on lodash in ViewBox.js

We can just use the array.prototype native methods for some and reduce here rather than using lodash. Also fixed usage of let to const where the params are not re-assigned.

Thanks for this PR
👍


cmuclmtk is not defined

I've been trying to install jasper all day, and when finally I'm supposed to launch it I have this issue. Any idea for a fix? (I've reinstalled cmuclmtk several times, still not working).
pi@raspberrypi:~ $ /home/pi/jasper/jasper.py
No handlers could be found for logger "client.vocabcompiler"
*******************************************************
*             JASPER - THE TALKING COMPUTER           *
* (c) 2015 Shubhro Saha, Charlie Marsh & Jan Holthuis *
*******************************************************
ERROR:client.vocabcompiler:Fatal compilation Error occured, cleaning up...
Traceback (most recent call last):
  File "/home/pi/jasper/client/vocabcompiler.py", line 163, in compile
    self._compile_vocabulary(phrases)
  File "/home/pi/jasper/client/vocabcompiler.py", line 269, in _compile_vocabulary
    vocabulary = self._compile_languagemodel(text, self.languagemodel_file)
  File "/home/pi/jasper/client/vocabcompiler.py", line 290, in _compile_languagemodel
    cmuclmtk.text2vocab(text, vocab_file)
NameError: global name 'cmuclmtk' is not defined
ERROR:root:Error occured!
Traceback (most recent call last):
  File "/home/pi/jasper/jasper.py", line 146, in <module>
    app = Jasper()
  File "/home/pi/jasper/jasper.py", line 109, in __init__
    stt_passive_engine_class.get_passive_instance(),
  File "/home/pi/jasper/client/stt.py", line 48, in get_passive_instance
    return cls.get_instance('keyword', phrases)
  File "/home/pi/jasper/client/stt.py", line 40, in get_instance
    vocabulary.compile(phrases)
  File "/home/pi/jasper/client/vocabcompiler.py", line 171, in compile
    raise e
NameError: global name 'cmuclmtk' is not defined

PS: I'm on raspian lite

How did you install cmuclmtk?
Try below procedure:

Run
sudo pip install --upgrade cmuclmtk
Download pkg:
cmuclmtk
Install it:
sudo dpkg -i cmuclmtk_3alpha-1_armhf.deb
Restart Jasper

I installed it using:
svn co https://svn.code.sf.net/p/cmusphinx/code/trunk/cmuclmtk/

I got this:
Requirement already up-to-date: cmuclmtk in /usr/local/lib/python3.4/dist-packages

Tried the procedure you proposed but got the same result.
I do not know python so what I'm about to say might be stupid but, I had to modify the populate script because it was using old function no longer avaible in python3 (i.e. raw_input). And I had severl problems where it didn't find some modules. I solver that issue by using
sudo apt-get install python-X
So my theory is that maybe it's looking for cmuclmtk in the wrong directory? Like pyhton instead of python3.4.

I've got the same issues


refactor!: move getNetworkIdentity to network class

Motivation

Spin-off from https://github.com/ChainSafe/lodestar/pull/5229

Description
Move getNetworkIdentity logic into network class to reduce interface surface

:tada: This PR is included in v1.9.0 :tada:


Show machine 'capacity'

Machine capacity could be described as a percent active. If you need 3.2 machines, you will have to place 4 that are 80% active. 80% would be useful to have as extra info to know how loaded those machines are.

Not really necessary / can be inferred by the number itself with precision > 0


ECMPS Test Files Group 34

./src/utils/selectors/assert.test.js
./src/utils/selectors/facilities.test.js
./src/utils/selectors/monitoringConfigurations.test.js
./src/utils/selectors/monitoringPlanDefaults.test.js

PR: https://github.com/US-EPA-CAMD/easey-ecmps-ui/pull/1219


HADOOP-17244. S3A directory delete tombstones dir markers prematurely.

This changes directory tree deletion so that only files are incrementally deleted
from S3Guard after the objects are deleted; the directories are left alone
until   metadataStore.deleteSubtree(path) is invoked
This avoids directory tombstones being added above files/child directories,
which stop that subtree operation from actually finishing.
Also:

callback to delete objects splits files and dirs so that
any problems deleting the dirs doesn't trigger s3guard updates
new statistic to measure #of objects deleted, alongside request count.
callback listFilesAndEmptyDirectories renamed listFilesAndDirectoryMarkers
to clarify behavior.
Test enhancements in ITestDirectoryOperationCost, but I didn't manage to
replicate it there (didn't quite understand the cause); the FileContext
test works for regression testing.

Change-Id: I8f96536bc6ffaf548b3da1068b9bfc897d34a993

Tests in progress

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 37s
trunk passed

+1 :green_heart:
compile
19m 30s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m  0s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 46s
trunk passed

+1 :green_heart:
mvnsite
2m 23s
trunk passed

+1 :green_heart:
shadedclient
19m 52s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 15s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 17s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 28s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 22s
the patch passed

+1 :green_heart:
compile
18m 49s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
18m 49s
the patch passed

+1 :green_heart:
compile
16m 58s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 58s
the patch passed

-0 :warning:
checkstyle
2m 42s
root: The patch generated 2 new + 171 unchanged - 0 fixed = 173 total (was 171)

+1 :green_heart:
mvnsite
2m 21s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  8s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 19s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 47s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 32s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 35s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 55s
The patch does not generate ASF License warnings.

203m 41s

Reason
Tests

Failed junit tests
hadoop.fs.TestLocalFSFileContextMainOperations

hadoop.fs.viewfs.TestFcMainOperationsLocalFs

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2280

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8ed0a65527dd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ac7d4623aef

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/1/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/1/testReport/

Max. process+thread count
2745 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 39s
trunk passed

+1 :green_heart:
compile
24m 17s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
20m 30s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 43s
trunk passed

+1 :green_heart:
mvnsite
2m 24s
trunk passed

+1 :green_heart:
shadedclient
19m 49s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 15s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 11s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 21s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 34s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s
the patch passed

+1 :green_heart:
compile
19m 21s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
19m 21s
the patch passed

+1 :green_heart:
compile
17m  6s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
17m  6s
the patch passed

+1 :green_heart:
checkstyle
2m 44s
the patch passed

+1 :green_heart:
mvnsite
2m 23s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  9s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 20s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 42s
hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 39s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 56s
The patch does not generate ASF License warnings.

189m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2280

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b43739be005f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0d855159f09

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/2/testReport/

Max. process+thread count
1554 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2280/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Note: I ran the hdfs contract tests in my IDE to verify it was happy too; all good.

repeatedly tested against london with options showing the error and the -Dkeep option and unguarded. Some transient failures related to local network issues, addressed in HADOOP-17181.

This patch is incomplete. Reverted and will create a new one.
Issues

cleanup on a multipart fail will tombstone everything; no information at that point as to what is/isn't a dir
delete needs more coverage

I think I may want to push this delete/no-delete logic into s3guard -it can do the check rather than relying on the layer above. But: we will need to pass down for each path whether a path is a dir or a file, so that s3guard doesn't do a DDB query on every single path entry to work that out for itself


Add provider function to return a list of all stages and their progress

Describe the feature
with https://github.com/alloy-rs/alloy/pull/1079 we can now emit an list of stages and their processed blocks
which can be obtained from the
https://github.com/paradigmxyz/reth/blob/9e685163deb57b2a2e1661195c093071d1e85647/crates/storage/storage-api/src/stage_checkpoint.rs#L5-L9
we need a new function here that returns a list of all checkpoints in that table:
we need to iterate over this table and decode its keys to string and the checkpoint
https://github.com/paradigmxyz/reth/blob/9e685163deb57b2a2e1661195c093071d1e85647/crates/storage/provider/src/providers/database/provider.rs#L2507-L2509
TODO

add get_all_checkpoints function to trait

this can be done via
https://github.com/paradigmxyz/reth/blob/9e685163deb57b2a2e1661195c093071d1e85647/crates/storage/db-api/src/transaction.rs#L22-L22
and then walk
https://github.com/paradigmxyz/reth/blob/9e685163deb57b2a2e1661195c093071d1e85647/crates/storage/db-api/src/cursor.rs#L40-L40
FYI @loocapro
Additional context
No response

Happy to get it!


03/30/2018 02:52 : Create Pull Request for branch master -> prTesting1_2018033002

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Does not count time correctly in Safari

When used in Safari it shows correct time when page is loaded. However, when you go to other tab and switch back to FlipClock tab later, it shows wrong time. It looks like that somehow page freezes when it's out of the focus and restores back when it's in focus again.

This has been fixed in the new js-es6 branch which is the official v1 draft. It now uses requestAnimationFrame loops to handle the animation. This should prove to be a much better handling of the performance, and the handling for inactive tabs has been improved as well.


Number Theory : Sieve Of Eratosthenes

Description
How to find Prime number efficiently in competitive programming.
Domain
Competitive Programming
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


[ETFE-933] Add Info header to Soap Header

Use existing values for now. I'm chatting with Arun Thomas about whether ChRIS or Core need to create new values for us to submit going forward.


MAG240M distributed training

Description

Run ogbn-mag240m dataset in Quiver.
Optimize the performance with adaptive data allocation.
Enable distributed feature communication.
Prepare the evaluation results for our paper.

Milestones

[x] NCCL primitives with RDMA support
[x] Feature exchange
[x] Quiver's feature allocation algorithm
[x] Quiver's 240M example according to PyG single-device training (DGL omitted because it is similar)
[x] Quiver's 240M multi-GPU example (run on komodo)
[x] Quiver's 240M multi-node example (run on komodos)
[x] DGL and P3 multi-node baselines (simulation, will add full experiments on the cloud)
[x] Documentation for distributed design and APIs

Notes

A simple algorithm to partition the feature data, and we can improve it
To repeatedly run experiments, we store the features to cache on disks, but there is an option to generate online
There could be a way to fully utilise NCCL bidirectional bandwidth, especially when the number of nodes is not the power of 2

Is this PR ready to merge?

Is this PR ready to merge?

Not yet.


fix typo in help dialog

Note that this will require a change in the Translate Wiki data files (minor detail)

Already fixed on that end  https://github.com/mathjax/MathJax-i18n/blob/master/JSON/en/HelpDialog.json#L11 (but we never import those...)

@christianp thanks for merging in that bower fix ;-)

GitHub pull requests remain a mystery to me. I have no idea how that commit ended up in this PR.

I'm sorry, but the pull request is still a problem.  It is branched from master but should be branched from develop (and merged to develop as it is now).  The reason the bower fix is included is because it was merged into master but not merged into develop (as it should have been when the hot-fix was made to master).  I merged it into develop a few weeks ago, but since your branch is from master, it is included in your history here.
The way this is supposed to work is that you make a new branch from the current develop branch, make your changes, and then make a pull request to develop.  The git-flow model that we are using doesn't allow pulls from master into develop (only from develop into master, and then only for new releases).  If this had been a larger set of changes, I'd recommend rebasing the commits onto a new branch from develop, but it is probably just easier to make a new branch from develop and make the edit again before making a fresh pull request.
Sorry it is so complicated, but once you have done it a couple of times it gets to be more natural.

FYI new feature for the web interface is https://github.com/blog/1945-quick-pull-requests


[DataFrame] [Typo] Fix the typo

Test build #27829 has started for   PR 4717 at commit 858d7b0.

This patch merges cleanly.

Test build #27829 has finished for   PR 4717 at commit 858d7b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27829/
Test PASSed.

Looks like another fine tiny doc fix that can go straight in and for 1.3. I checked and there is indeed no DataFrameImpl anywhere in the code in master or 1.3.


Direct Property GetValue does not return expected value

In this code
https://github.com/AvaloniaUI/Avalonia/blob/f80737aa01a8232bcc8623aeb0e8aa65c4f854b4/tests/Avalonia.Base.UnitTests/AvaloniaObjectTests_Metadata.cs#L62-L76
if you create an instance of Class 1, the value of the Direct property will be null instead of the expected value "foo".

This is expected behavior: direct properties can be thought of as simply adding metadata to standard CLR properties, and if you want a CLR property to have a default value then you just need to set the default value of the field. so you should be doing:
private string _direct = "foo";

Did yo notice that for styled properties it's called "DefaultValue" whereas for direct properties it's called "UnsetValue"?
This is because the value in the case of direct properties it's not intended to supply a default value. The unset value is only used when calling ClearValue with a direct property (i.e. unsetting the value).

Thanks for the clarification. If I wanted to create a read-only property like WPF what should I do?

If you want to create a read-only property you can create a direct property but supply only a getter. You can see an example here:
https://github.com/AvaloniaUI/Avalonia/blob/cbd5a4c59afd83c7deccbb88f7a8ebd7192964fb/src/Avalonia.Visuals/Visual.cs#L30-L31


refactor: mark a few client-side packages as side-effect-free

Motivation
Instant bundle size optimization⚡
I did not mark core as side-effect-free, though, because there are a few side-effects there (mostly importing non-module CSS), and it's quite tedious trying to filter out everything.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Page builds fine

The most prominent issue is CSS. As soon as a component imports CSS, to ensure stable CSS insertion order (#3678), we have to mark all downstream consumers as side-effect-ful. This makes us not able to actually fully tree-shake.

This looks much better IMO, no more hacks...
My idea is that Details should be a semi-public, if not fully public, API, so we should probably have a better pattern


Prevent p2p user from claiming a contribution that does not have an email.

We have discussed changing this so that the ask & offer forms will require emails if you're in p2p mode. This change should be enough to work around the fact that email is currently the only thing we support for logged out users

We have discussed changing this so that the ask & offer forms will require emails if you're in p2p mode. This change should be enough to work around the fact that email is currently the only thing we support for logged out users

We have discussed changing this so that the ask & offer forms will require emails if you're in p2p mode. This change should be enough to work around the fact that email is currently the only thing we support for logged out users

... and then after further discussion, we returned to the original idea of solving this on the claiming end instead.
We tossed around different possible solutions but landed on the idea that a future 'hybrid' mode might have to solve for this problem anyway -- where contributions w/ email can be claimed but those w/o email can be dispatched. In that world, solving this in the claim flow or on /contributions felt more appropriate.

We have discussed changing this so that the ask & offer forms will require emails if you're in p2p mode. This change should be enough to work around the fact that email is currently the only thing we support for logged out users

... and then after further discussion, we returned to the original idea of solving this on the claiming end instead.
We tossed around different possible solutions but landed on the idea that a future 'hybrid' mode might have to solve for this problem anyway -- where contributions w/ email can be claimed but those w/o email can be dispatched. In that world, solving this in the claim flow or on /contributions felt more appropriate.


Laravel 10 upgrade

In laravel 10, I think Jobs now respond with Illuminate\Foundation\Bus\PendingDispatch objects rather than the response of what the handle method has.
In feature:
$this->run(GenerateUUIDJob::class);

now responds with
Illuminate\Foundation\Bus\PendingDispatch^ {#9196 // app/Models/Traits/HasUuid.php:36
  #job: App\Domains\Uid\Jobs\GenerateUUIDJob^ {#9197}
  #afterResponse: false
}

instead of the response of what the handle method does:
class GenerateUUIDJob extends Job
{

    public function __construct()
    {
    }

    public function handle(): string
    {
        return Str::orderedUuid();
    }
}

Support for Laravel 10 would be really appreciated...

https://github.com/lucidarch/lucid/pull/49
Please refer to this PR to solve the problem with Laravel 10.x

Feel free to use my fork https://github.com/ksimenic/lucid. It has all optimizations for Laravel 10.
All you need to do is to add following in your composer.json
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/ksimenic/lucid"
        }
    ],

and then require
"lucidarch/lucid": "dev-latest"

@ksimenic we are currently using your fork in combination with laravel 10; but are running into an issue where that all jobs and operation that have the ShouldQueue interface are still executed on the sync queue.
That's caused by this little piece of code: https://github.com/laravel/framework/blob/11.x/src/Illuminate/Bus/Dispatcher.php#L92 that always forces execution to the sync queue.
Any idea what the best option would be to get the 'old' behaviour back?
Using the runInQueue method from the UnitDispatcher currently requires me to override the 3rd argument in all calls because we use different queue names compared to the name 'default'

Alright, have looked, but the least impact way in my option will be to alter the UnitDispatcher on line 58:
            $result = $this->dispatchSync($unit);
        }

to:
            if ($unit instanceof ShouldQueue) {
                return $this->dispatch($unit);
            }

            $result = $this->dispatchSync($unit);
        }