Demo img2img webcam browser

Demo Notes

Frontend in Svelte
Backend: FastAPI / WebSocket / MJPEG stream
Wrapper is copied and modified here to accept a prompt for img2img and engine_dir, allowing me to specify the directory and reuse the compiled model in the Docker environment.

All the StreamDiffusion code is on img2img.py. Please feel free to add any speedup suggestions.
I'm using t_index_list=[35, 45]. Is there a way to provide a strength on a 0-1 scale?

We will make a noise scheduler function and realize parametric operations such as noise strength 0.0~1.0 and num_denoising_steps 1~50. We will also do the review for the PR soon!

hi @GradientSurfer, thanks for detailed response! I really appreciate the feedback, I'm happy to address some of your points on this PR, also if you're interested in collaborating, please send edits, commits. do you have PR edit access?

Looks cool, nice work @radames! I've been tinkering with a strikingly similar set of changes, but using a canvas with drawing tools instead of webcam input.
If you and the team don't mind unsolicited feedback, I'll leave a review and share a few suggestions/thoughts that I hope you find helpful:

Batch inference
It appears image frames are processed one at a time in this demo, but batching multiple frames together for higher throughput (& FPS)  should result in a smoother experience (at the expense of increased latency).

Addressing number 2 here, we can try a batching approach!

Circular buffer & continuous streaming
It looks like the server requests the client to send a frame - instead of this request/response cycle, the client could continuously stream image frames to the server which would maintain a circular buffer that can then be used to perform batch inference. Notably examples/screen/main.py uses that approach.

Ohh yes that makes a lot of sense, In my original demo with LCM, I did use an async queue(), but back in time, the inference was slow, and the result was a lagged video, thus I decided to switch to ping/pong approach.

No separate endpoint/stream for returning generated images
The generated image could be returned to the client via the websocket connection, instead of via a separate API endpoint. This could be a minor code simplification, and notably would sidestep the linked chromium bug (so we could avoid sending frames twice to every browser that isn't firefox).
Yes, that's a great point, MJPEG stream seems a bit awkward, and buggy on Chrome, Ideally it would be on WebRTC, but I was looking into performance and simplicity. An open socket jpeg streaming looked faster to me compared to sending blobs over websocket, it needs an extra decoding processing to send the bytes to the <img>.  However, this demo seems very fast and it's doing the blob over websockets -> <img> https://www.fal.ai/camera

Return raw pixels in RGBA format
Generated images can be returned to the client in raw RGBA pixel format and then directly written to the canvas. This may be a relatively minor optimization, but it avoids the overhead of transforming to & from JPEG format and any associated lossy compression.

Yes you're right, however I did the canvas to normalize the webcam image, cropping on the desired size, this could be done on the backend, whichever is faster.

Integrate wrapper.py modifications
The modifications to accept a prompt for img2img and to support engine_dir are great and seem well contained, those ought to be integrated into the canonical wrapper.py so there is no unnecessary duplication of code or maintenance burden.
Done on PR #66 , and when it's merged I can update it here.

Perhaps these ideas could be addressed here or in future PRs (or not at all), either way I'd be happy to discuss or collaborate further on details - feel free to reach out.

@radames I do not have PR edit access here, @cumulo-autumn perhaps you would consider granting collaborator access?

hi @cumulo-autumn , I think it's good now. I've fixed a couple of uncaught exceptions. One important note, while the server and the client were designed to accept multiple queued connections, the wrapper and StreamDiffusionWrapper are not working well in that regard, i.e. the buffer across stream.stream is shared, so if you open multiple browser tabs and switch the prompt and webcams, you'll notice the images are leaking across tabs. For instance when using diffusers pipe(...) it's possible to have queue calls, as long as they're quick inference, example here.
ps. please pull and test again if you can on Windows

@radames I do not have PR edit access here, @cumulo-autumn perhaps you would consider granting collaborator access?

Hi @GradientSurfer . Thank you for your valuable PR submissions in the past, and for your many meaningful suggestions this time as well! Regarding PR edit access, currently, we are keeping it within a group of acquaintances, so please allow us to hold off on adding new PR edit access for now. However, we are very much open to more discussions and PRs in the future, so we definitely want to continue doing those! (I apologize for the late response this time, as it has been a busy end-of-year period. Also, I really appreciate your prompt and valuable feedback on this PR.) We will consider our policy on adding new PR edit access in the future!

hi @cumulo-autumn , I think it's good now. I've fixed a couple of uncaught exceptions. One important note, while the server and the client were designed to accept multiple queued connections, the wrapper and StreamDiffusionWrapper are not working well in that regard, i.e. the buffer across stream.stream is shared, so if you open multiple browser tabs and switch the prompt and webcams, you'll notice the images are leaking across tabs. For instance when using diffusers pipe(...) it's possible to have queue calls, as long as they're quick inference, example here. ps. please pull and test again if you can on Windows

Hi @radames. Thank you for the update! It works perfectly in my environment too! I am going to merge it.


404 page not rendered when routeBasePath is "/", and no version uses that path

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
Combining routeBasePath: '/', with having each version at a specific path (the version itself) results in unknown pages rendering "blank" content (instead of the "Page not found" content).
Reproducible demo
https://stackblitz.com/edit/github-py3g6d?file=docusaurus.config.js
Steps to reproduce
From a fresh project:
$ npm run docusaurus docs:version 1.1.0

And add the following to the docs config:
          routeBasePath: '/',
          versions: {
            current: { path: '/current' },
            '1.1.0': { path: '/1.1.0' },
          },

then visit /foo route. No "Page Not Found" content :cry:
Expected behavior
Render the "Page not found" content
Actual behavior
Empty page
Your environment
No response
Self-service

[x] I'd be willing to fix this bug myself.

Duplicate of https://github.com/facebook/docusaurus/issues/9688

Also, any suggestions on a workaround?

Sorry 🤪 https://github.com/facebook/docusaurus/issues/9665
I think a workaround could be to create a 404.md doc with slug /, but didn't try. If this doesn't work I don't see any other workaround.

However the problem/solution is likely to be the same: make react-router-config render top-level 404 if no subroute matches current path

I'd love to help pitch in if possible! Feel free to thoughtdump how someone would go about doing this :smile:

There's some bits of code that seem to have the intention of showing the <NotFound> 404 component when there's no route match... but apparently not triggering?

fallback handling: https://github.com/facebook/docusaurus/blob/ca09f238f3d809641614309cd8118a4e42475c1b/packages/docusaurus/src/client/exports/ComponentCreator.tsx#L28-L45
which syncs with the generated routes: https://github.com/facebook/docusaurus/blob/ca09f238f3d809641614309cd8118a4e42475c1b/packages/docusaurus/src/server/routes.ts#L312-L315
these are pulled together by: https://github.com/facebook/docusaurus/blob/ca09f238f3d809641614309cd8118a4e42475c1b/packages/docusaurus/src/client/App.tsx#L29

@huonw You have found out how we show 404 "in general". However, the docs plugin is weirder: it declares a wildcard subpath match (like /{routeBasePath}/*) so that the sidebar never re-renders on navigation. In this case, a "not found" would not be caught by the root wildcard, but by /docs/*.

Ah, right, okay, so with routeBasePath == / as we configured, the docs plugin catch-all route is /* and presumably is in the route list before that final catch-all, and thus wins.

Yes, exactly :D

Curious, why is the not found working on our own website? 🤔
https://docusaurus.io/docs/notFound
Why does it only happen when routeBasePath is /, I found this surprising.

There are a few ways we could handle it.

Automatically add a * not found route to all subroutes, similar to what is done at the root here:

Fix React-Router-Config route rendering logic

Currently we render routes with a package:
export {renderRoutes as default} from 'react-router-config';
Problem: if a parent route match the path, but no child route match the path, then it does not "escape" the parent route and try to enter another parent route that also matches, nor does it try to render the default * 404 route.
This is IMHO what we should fix.
This would also enable us to have 2 plugins use routeBasePath as / (even if I wouldn't recommend this due to potential conflicts between plugins, it should technically be possible)

Have a way for plugins to declare their custom 404 page

This can be interesting because some users might have a dedicated 404 @theme/DocPageNotFound to say that the doc does not exist, with a link to the root of the version.
That's probably overkill (and requires CDN config to route /docs/* 404 to /docs/notFound.html) but I already saw someone requesting that kind of thing.
Not a priority IMHO

I would go with solution 2, but that's probably not easy.
We'd need to fix that code: https://github.com/remix-run/react-router/blob/v5/packages/react-router-config/modules/renderRoutes.js

Note this code doesn't even exist anymore in React-Router v6

I wonder if we're ought to try and see if this bug exists after upgrading. You might be able to feed two birds with one scone.
And if not, we likely ought to file an issue so it's made known to the maintainer(s)

Okie dokie, I know it wasn't your first choice, but decided to take a stab at the "easy" solution here of 1.
https://github.com/facebook/docusaurus/pull/9719
I'm relatively noviced when it comes to JS (and furthermore TS), so feel free to tear me a new one with suggestions/questions/etc... I try and learn through osmosis.

@slorber there is a workaround, although it's not for the faint of heart :laughing:
https://github.com/pantsbuild/pantsbuild.org/pull/84


Ignore sysvinit scripts when systemd is used

What does this PR do?
use SYSTEMCTL_SKIP_SYSV env var
Motivation
Remove irrelevant warning on install

what's the warning? Some customers would use the enable command directly, could the warning mislead them?

@remicalixte ok, thanks for the info. I could still see these warnings confuse some users (they look a bit worrying TBH).
Could you update the release note on the sysv-init support to mention that these warnings can be safely ignored on systemd-based systems? (and could you check our public docs as well?). Thanks!

@olivielpeau the public docs on debian advice to use the service command which is available with sysvinit: https://docs.datadoghq.com/agent/basic_agent_usage/deb/?tab=agentv6.
Is there any other public docs I would have missed ?

@remicalixte you can double-check on the docs available on this repo as well, but that's all I can think of 👍


got 415 "Unsupported Media Type"

The test operation is mentioned below where I am specifying content-type as application/JSON but still receives Unsupported Media Type I have two different mongo-DB one for prod(which is on atlas) and a local mongo instance for testing plus I am using pusher lib which has different keys set based on the environment
Error
ReferenceError: You are trying to import a file after the Jest environment has been torn down.
  at Object.toObject (node_modules/mongoose/lib/utils.js:290:27)
  at model.Query.Object.<anonymous>.Query.find (node_modules/mongoose/lib/query.js:1989:22)
  at model.Query.Query [as constructor] (node_modules/mongoose/lib/query.js:97:10)
  at new model.Query (node_modules/mongoose/lib/model.js:4747:11)
  at Function.find (node_modules/mongoose/lib/model.js:2037:14)

C:\Users\DANISH\Desktop\My-Space\Nuts-app A full whatsapp clone\server\test\Messages.test.js:22
throw err;
^
Error: expected 201 "Created", got 415 "Unsupported Media Type"
at Test.Object..Test._assertStatus (C:\Users\DANISH\Desktop\My-Space\Nuts-app A full whatsapp clone\server\node_modules\supertest\lib\test.js:270:12)
at Test.Object..Test._assertFunction (C:\Users\DANISH\Desktop\My-Space\Nuts-app A full whatsapp clone\server\node_modules\supertest\lib\test.js:285:11)
at Test.Object..Test.assert (C:\Users\DANISH\Desktop\My-Space\Nuts-app A full whatsapp clone\server\node_modules\supertest\lib\test.js:175:21)
at Server.localAssert (C:\Users\DANISH\Desktop\My-Space\Nuts-app A full whatsapp clone\server\node_modules\supertest\lib\test.js:133:12)
at Object.onceWrapper (events.js:416:28)
at Server.emit (events.js:310:20)
at emitCloseNT (net.js:1657:8)
at processTicksAndRejections (internal/process/task_queues.js:83:21)
::ffff:<IP_ADDRESS> - GET / HTTP/1.1 200 29 - 4.636 ms
::ffff:<IP_ADDRESS> - GET /v1/api/messages/sync HTTP/1.1 500 2732 - 9.292 ms
`
##Test-query
test('should return message create response', () => {
request(app)
.post('/v1/api/messages/new')
.send({
message: 'I am unable to get message',
name: 'danish',
timestamp: '1234',
received: true,
})
.set('Content-Type', 'application/json')
.set('Accept', 'application/json')
.expect(201)
.end((err, res) => {
if (err) {
throw err;
}
console.log(res.body);
});
});
`

the issue is resolved now we can create a different file for test setup that includes all the test configuration for the database/caching engine etc with all the methods to the setup the config by wrapping inside the wrappers jest provide and export them in that ever test its needed
for reference check this link:

the issue is resolved now we can create a different file for test setup that includes all the test configuration for the database/caching engine etc with all the methods to the setup the config by wrapping inside the wrappers jest provide and export them in that ever test its needed
for reference check this link:


Make stress tests log each instance separately

This is sweet! Consider undoing my recent change to add a unique id since the need for that is moot with this fix.


How to check if touch id has been enrolled for ios?

Is there any way to check if the touch id has been enrolled for ios using ionic like for android?

isAvailable should take care of that.

I mean if i deleted all my fingerprints do isAvailable called ?


Collect same history records in view

Collect items with the same type which stand in a row to a group
Show count, authors combined, last timestamp


Stretch scrolling effect does not work correctly.

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
run and scroll down and up
Expected results
work ok
Actual results
When swiping quickly up and down, the motion effect is almost instantaneous and does not gradually speed up.
This error does not occur with native android apps.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: SingleChildScrollView(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              Container(
                width: 300,
                height: MediaQuery.sizeOf(context).height * 1,
                child: Center(child: Text('fast scroll down and up\n' * 200)),
              )
            ],
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/52562340/6a22fa56-fd5c-4de8-954d-f51344109d6e

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[!] Flutter (Channel stable, 3.16.1, on Microsoft Windows [Version 10.0.19045.3693], locale en-US)
    • Flutter version 3.16.1 on channel stable at C:\Users\tbm98\fvm\default
    ! Warning: `flutter` on your path resolves to C:\Users\tbm98\fvm\versions\stable\bin\flutter, which is not inside
      your current Flutter SDK checkout at C:\Users\tbm98\fvm\default. Consider adding C:\Users\tbm98\fvm\default\bin to
      the front of your path.
    ! Warning: `dart` on your path resolves to C:\Users\tbm98\fvm\versions\stable\bin\dart, which is not inside your
      current Flutter SDK checkout at C:\Users\tbm98\fvm\default. Consider adding C:\Users\tbm98\fvm\default\bin to the
      front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7f20e5d18c (2 days ago), 2023-11-27 09:47:30 -0800
    • Engine revision 22b600f240
    • Dart version 3.2.1
    • DevTools version 2.28.3
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\tbm98\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.7.34202.233
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] IntelliJ IDEA Community Edition (version 2023.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2023.2.3
    • Flutter plugin version 76.3.4
    • Dart plugin version 232.10248

[√] VS Code (version 1.84.2)
    • VS Code at C:\Users\tbm98\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.76.0

[√] Connected device (4 available)
    • SM G960N (mobile) • 2b390848d61c7ece • android-arm64  • Android 10 (API 29)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.19045.3693]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 119.0.6045.161
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 119.0.2151.93

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

In the video I used the release version with the command flutter build apk. The same error occurs with debug build.
please take a look @TahaTesser @Piinks

Hi @tbm98
This does not seem obvious in the example above. I tried removing the list limit by commenting Container height in the sample code (200 items are displayed) but still did not notice the issue. Checked on the lastest stable and master channels.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.16.1, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.16.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7f20e5d18c (9 hours ago), 2023-11-27 09:47:30 -0800
    • Engine revision 22b600f240
    • Dart version 3.2.1
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version unknown)
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.8+0-17.0.8b1000.22-10799086)

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe Patch 3.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.17.0-18.0.pre.59, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.17.0-18.0.pre.59 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cae47c4641 (66 minutes ago), 2023-11-29 18:19:30 -0800
    • Engine revision 35939ca853
    • Dart version 3.3.0 (build 3.3.0-170.0.dev)
    • DevTools version 2.30.0-dev.4
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version unknown)
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.8+0-17.0.8b1000.22-10799086)

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe Patch 3.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

I also checked this on the previous 3.13.9, the feel seems to be the same as 3.13.9. What was the last Flutter version that you found worked well?

Hi @huycozy
The height fixation is intentional. I discovered this issue a long time ago (seemingly since this effect was introduced) but only now had the time to report it.
When the length of the ListView is just enough to reach the last position and the first position in just one swipe, the problem appears.

Thanks for your response. I can see the issue now. I didn't pay close attention to your swiping gesture in the video. To make this more clear, I share the demo video from Android native app (on Android 14) here for the comparison:
https://github.com/flutter/flutter/assets/104349824/61da0705-9dde-44b1-ab32-a9186e782a9e
But I think this issue should be aggregated into https://github.com/flutter/flutter/issues/82906. What do you think?

I'm not sure if re-implement with shaders will fix this problem. However, this error is not serious and difficult to notice. I think this issue should be left until the effect is re-implemented and I or someone else checks the results again.

Perhaps we can also re-check this once https://github.com/flutter/flutter/issues/138940 is solved. Meanwhile, I will label this for other's opinions.
Reproduced this on the latest stable/master channels.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.16.2, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.16.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e1c857886 (9 hours ago), 2023-11-30 11:51:18 -0600
    • Engine revision cf7a9d0800
    • Dart version 3.2.2
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version unknown)
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.8+0-17.0.8b1000.22-10799086)

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe Patch 3.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 119.0.6045.199

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.17.0-20.0.pre.10, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.17.0-20.0.pre.10 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision be268ebde2 (4 minutes ago), 2023-11-30 22:07:26 -0500
    • Engine revision c26e6ced11
    • Dart version 3.3.0 (build 3.3.0-174.2.beta)
    • DevTools version 2.30.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version unknown)
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.8+0-17.0.8b1000.22-10799086)

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe Patch 3.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 119.0.6045.199

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

I think this is a dupe of https://github.com/flutter/flutter/issues/82906 which requires implementing the stretch effect as a custom shader for better fidelity.
Thank you for reporting, I am going to close this issue as a duplicate of that one.

It's quite surprising to actually see some people having nausea problems when using this effect
The link I just found 🤔https://www.reddit.com/r/GooglePixel/comments/qcadhq/the_overscroll_stretching_in_android_12_is/

It's quite surprising to actually see some people having nausea problems when using this effect The link I just found 🤔https://www.reddit.com/r/GooglePixel/comments/qcadhq/the_overscroll_stretching_in_android_12_is/

Not "some". Read the comment section of any video on YouTube mentioning this feature. It's a lot of people.


How do you create a custom EntityDialog class?

I am trying to create a replacement version of the EntityDialog typescript class. I essentially just copy and pasted the existing class code into one of my Modules's *Dialog.ts classes to make it a bit easier to try out. The code is basically:
namespace SampleWebsite.SampleModule {

    @Serenity.Decorators.registerClass()
    export class TestDialog<TItem, TOptions> extends Serenity.TemplatedDialog<TOptions> implements Serenity.IEditDialog {
   // Rest of the code copied/pasted from Serenity.EntityDialog
   }
}

Then I modified my current module dialog code:
namespace SampleWebsite.SampleModule {

    @Serenity.Decorators.registerClass()
    @Serenity.Decorators.responsive()
    //export class InventoryItemDialog extends Serenity.EntityDialog<InventoryItemRow, any> {
    export class InventoryItemDialog extends TestDialog<InventoryItemRow, any> {
        protected getFormKey() { return InventoryItemForm.formKey; }
        protected getIdProperty() { return InventoryItemRow.idProperty; }
        protected getLocalTextPrefix() { return InventoryItemRow.localTextPrefix; }
        protected getNameProperty() { return InventoryItemRow.nameProperty; }
        protected getService() { return InventoryItemService.baseUrl; }

        protected form = new InventoryItemForm(this.idPrefix);
    }
}

When I run this form, it fails with:
Error: Can't locate template for widget 'InventoryItemDialog' with name 'InventoryItemDialog'!
From what I can gather, this happens because the widget can't find that element in to page so it can inject the content. But it's not clear to me where I can fix this.

It searches for current class name, followed by base class names for a template matching the name.
As there is no InventoryItemDialog.Template.html anywhere, it searches for the base class, which is EntityDialog by default. There is a EntityDialog.Template.html under ~/Views/Templates so it can use it as a fallback, so you need to put there a TestDialog.Template.html file.

Closing due to inactivity.


Remove the .Normalize() to fix PointAtInternal

The Normalize method call when calculating the current vector is causing errors.  Line 166 does not want a normalized vector, it wants to compute how much of the full vector is needed to reach the desired paramter.
Suggest adding a test in Polyline tests that looks like
            var r = Polygon.Rectangle(2,2);
            Assert.Equal(new Vector3(1,1,0), r.PointAt(0.5));

This test, which uses a rectangle not of unit length will reveal the problem.

This is a great catch! Thanks @wynged.

This now contains the test that was accidentally added to  #120


Stuck on "Loading library status..." after inserting an API token.

Describe the bug
The application becomes stuck on "Loading library status..." after inserting an API token.
To Reproduce
Steps to reproduce the behavior:

Launch Cods iBroadcast
Enter my API token
Get stuck on "Loading library status..."

Expected behavior
Unknown, I just installed the application, and this bug appeared the first time I launched it.
Screenshots

Desktop (please complete the following information):
Edition - Windows 11 Pro
Version - 23H2
Installed on - 06/05/2024
OS build - 22631.3447
Experience - Windows Feature Experience Pack 1000.22688.1000.0
Additional context
iBroadcast Log.txt

Hello there!
Did you try to run the application with the "-logging" parameter?
It should create a log file on your desktop.
If you can provide that file, I will be able to investigate the problem further . Also you could also adding "-log32" to show a visual logger.

Hello there! I can only assume an error reading your library occurs, this is usually caused by older formats of the json data.
To debug this further I will need the POST output of the network requests, more exactly you will need to use the "-exportpost" parameter, which will output files containing all the tracks in your library. As far as I have seen do not contain any sensitive information, except the name of your library songs of course
If you don't want to publish that information here, you can send the requests to me in private via discord at @codrut1001, or you can send me an email at<EMAIL_ADDRESS>There should be a folder on your desktop with a few more files, the best way to send them is to make a compressed zip folder containing all of them.

Hi Codrax! No problem, here's the export, with both --exportpost and -logging parameters on:
iBroadcastExport.zip
I also want to note, that when launching the application this time, I was not asked to enter my API token, unlike all the other times I attempted to fix whatever was happening by just restarting the application/computer.

You were not asked to provide the API token because you successfully logged In. In the first log you provided, you can see just that.
I'll take a look at the zip file you provided and hopefully I can figure out what's causing the error

I'm running 1.8.6 which I just downloaded today from your website. I got your Discord request, we'll continue there.

Bug caused by locale settings fixed in iBroadcast for Windows version 1.9.0


pytest skeleton

Create very simple pytest skeleton

After merge https://github.com/Septima/fikspunktsregister/pull/18 and rebase I hope this PR will pass CI.

Well, "It works on my machine" 😀
Fingers crossed.

We got miniconda working but this PR needs to specify deps


PLAT-10276: Bot certificate authentication

Ticket
PLAT-10276
Description
Implemented bot certificate authentication.
Checklist

[x] Referenced a ticket in the PR title and in the corresponding section
[x] Filled properly the description and dependencies, if any
[x] Unit tests updated or added
[x] Docstrings added or updated
[x] Updated the documentation in docs folder

In case an invalid cert (something that is not a pem file for instance) is passed, is the error message helpful for the bot developer? to help him understand what needs to be fixed

I added a specific log message.


Sensor "Range" reporting 0 km in 3.0.0 Beta 2

The sensor Range reports 0 km in 3.0.0 Beta 2, while in 2.2.5 it reports 369 km.
Diagnostic file is uploaded in #117

I think this is caused by that in 3.0.0 the engine_type=ICE, while in 2.2.5 it was Electric. I guess ICE is not correct engine type, otherwise we need to include this value in the if-statement of line 355

This is caused by a typo in my fix for engine type determination.  It was setting your EV to ICE incorrectly as you say.  Will be fixed in beta3

If you want to pull the updates from dev and see if these issues are fixed?

Latest updated from dev did resolve Range issue! Well done!


Is this project dead?

There seems to be a flood of unmerged PRs, no action on behalf of the owner for over a year, and the last release was two years ago. Is there an actual currently developed fork of this somewhere? It's a shame to lose a valuable alternative to sharp.

I would hope not, I still use jimp often.

Looks to be the case unfortunately

same I am stuck on upgrading to webpack 5 as well.

I remember the author being extremely strapped for time, and being eager for new contributors.
Hopefully someone can come forward to help keep this project moving forward. I absolutely love it. Extremely valuable alternative to Sharp.

Just tossing this out there.  @oliver-moran would you be willing to start a Kickstarter, to try to raise some money to put you back to work on this project?
I absolutely love Jimp, and I'd personally be willing to kick in some money to try to keep it moving forward.

I'd donate to the cause as well. Maybe even help out with some code here or there. Although I don't think @oliver-moran is around Github anymore. Maybe we should consider doing a fork sooner or later.

Hey all - one small update. I pinged Oliver (publicly) and this was his response, so if anyone is interested in being a contributor, sound off here, and he might add you. (I'd love to help but I know absolutely nothing about this project - I just adore being able to resize images in a Lambda function without pulling in huge binaries, like with Sharp)

Hey, everyone. Thanks for opening this thread – and apologies I haven't been able to keep up with the work here.
Adam, I note your response above, but if it's OK with you could I lean on you to guide me as to what the community needs me to do to get things unblocked?

@oliver-moran basically find someone you trust to drive the project forward, and grant them commit access to the project, and npm access to cut new versions.
A year or two ago you added me as a contributor, but I haven't been able to help much since I .... don't really know anything about image manipulation code. At all. LOL. I basically helped get some trivial PRs out.
If we have any volunteers who are able and willing to try to maintain this project, sound off

how is this now? are we going forward?

I see that v0.16.2 was released a couple of months ago, so the project clearly isn't entirely dead. Is this issue still needed?

Hey @oliver-moran I've sent you a message on twitter on how to move forward with maintenance on jimp. In short:
We need to move the repo from under @oliver-moran's account to a shared org to make collaboration easier.
For that I've made https://github.com/jimp-dev

After a little break I'm happy to facilitate maintenance on the project. I'm also willing to help new maintainers hop on board. I myself do not plan on adding too much though.

@hipstersmoothie - don't forget the npm keys, so others can cut releases. That's the key piece. Ya'll could just fork the repo anywhere you want, but you wouldn't be able to publish.

I’m a owner of the nom package 👍🏼

And now it's in the org 🎉 Going to close out this issue and some other and put out a new call for maintainers

@hipstersmoothie ah! So sorry to tell you things you already knew.
Stoked to see this project moving forward again. Thank you so much for the work you're putting in!

https://github.com/jimp-dev/jimp/issues/1128


⚠ Ixtanet SAT has degraded performance

In cadaad0, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20873 ms

Resolved: Ixtanet SAT performance has improved in fb6084f after 291 days, 15 hours, 25 minutes.


Kubernetes Ingress - Allow specifying gateway via annotation (solve 404 TLS issues)

Kubernetes Ingress - Allow specifying an existing gateway via annotation:
ingress.kubernetes.io/istio-gateway: "istio-system/my-existing-gateway"

This way we can create one gateway manually and that should solve the TLS with the same certificate 404 issue with Kubernetes Ingress.
For more details check this issue: https://github.com/istio/istio/issues/27205#issuecomment-692735668
[ x ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ x ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @guyromb. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot I signed it!

@howardjohn
Please check my comment here: https://github.com/istio/istio/issues/27205#issuecomment-692735668
The idea is to allow specifying an existing gateway via K8s Ingress annotation. This way we can create one gateway manually and that should solve the TLS / same certificate 404 issue.
This is my first PR and I am new to the Istio code base. Sorry if there is anything confusing.

I have some concerns that this will basically cause us to ignore the Ingress spec (specifically, the TLS settings). It would be more ideal if we handled this transparently

What do you suggest?

@istio-testing unit-tests_istio

/ok-to-test

@guyromb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@guyromb: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guyromb: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test release-notes_istio

lint_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guyromb: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test release-notes_istio

lint_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test lint_istio

gencheck_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guyromb: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test release-notes_istio

lint_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test lint_istio

gencheck_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guyromb: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test lint_istio

gencheck_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
e364207939651a2167ecb76d68688ab240d2f1c8
link
/test integ-multicluster-k8s-tests_istio

release-notes_istio
e10cdf949ce3f310749c7824ad9e6ebcb00db274
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@guyromb: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
762fa7ede59a55d759bc9711d48fae040a93dcd8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

@guyromb: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
762fa7ede59a55d759bc9711d48fae040a93dcd8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

My suggestion would be to modify the logic to handle these issues automatically without pushing the burden to the user. However, this may be the more pragmatic approach. I really don't want to get to the point where we have a bunch of configuration for Ingress though

My suggestion would be to modify the logic to handle these issues automatically without pushing the burden to the user. However, this may be the more pragmatic approach. I really don't want to get to the point where we have a bunch of configuration for Ingress though @howardjohn

I agree with you. I'd like to keep it clean as well and an automated way will be ideal. However, that means that we will have to analyze all the ingresses and decide when to create a new gateway, when to use the same etc.. I can see this creates new troubles.
I don't see an easy way to do it and in the meanwhile it is simply not possible to use K8s Ingresses with TLS, unless you have different domains and certificates. In the past, you could modify the k8s-autogenerated-gateway, and there was more flexibility despite that it was manual. Although the existing automation makes some things easier with installation, but it is not working the way it is intended to be (unless you have a different solution I missed?) so we really need to fix it. Otherwise, it is better to completely deprecate the Kubernetes Ingress support.
Therefore, for this case, I believe this "code smell" is acceptable. Do you think we can make a compromise here?

@googlebot I fixed it

@googlebot I consent

@googlebot I consent.

@googlebot I consent.

@googlebot I fixed it

@googlebot I consent.

@guyromb: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
9d5d4042ad2c6604c5dab6561615892de33baf09
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

Closing for now because this feature is not implemented yet.
@guyromb please reopen after the feature has been implemented and the new annotation is also added to the reference docs.

Sorry, closed wrong PR. Meant to close the doc PR.

No worries. Any update if you plan to get this merged?

Why not use the ingress class to select gateway? Annotation is not a good API.

Because you might want to specify different gateways to handle it. Right now Istio generates those automatically, without an option to configure them properly. Also, Kubernetes Ingress is broken when using Istio and TLS and this is a working solution for that.
Annotations are common practice in other solutions like Ambassador, Linkerd2, and Traefik.

I mean we can specify an ingress class that selects the right ingress gateways. Though I admit annotation is simpler.

@hzxuzhonghu how?

The IngressClass allows setting parameters, it is possible to specify the right instances with it

Thanks @hzxuzhonghu . we are still on Kubernetes 1.16 (GKE) so cannot use it yet. Also, according to the following example - where can you specify the Gateway name? it is unclear what are the possible parameters / no docs.
apiVersion: networking.k8s.io/v1beta1
kind: IngressClass
metadata:
  name: istio
spec:
  controller: istio.io/ingress-controller
---
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: ingress
spec:
  ingressClassName: istio
  rules:
  - host: httpbin.example.com
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          serviceName: httpbin
          servicePort: 8000

/remove-lifecycle-stale

not stale

@guyromb the IngressClass API spec.parameters property is actually a TypedLocalObjectReference. A pity, because if they had used the normal ObjectReference you'd be able to reference Gateways in any namespace.

indeed @yp28, at least a good start would be to be able to even choose a gateway :)


Microsoft Edge Browser and message event

It looks like the message event is not being fired on the Microsoft Edge Browser, even after successfully connecting and subscribing to a topic.  Browser version is Microsoft Edge 38.14393.0.0.
Works great otherwise, on Firefox and Chrome.
Edit: Looks like the packet for subscribe gets sent but no suback is returned.

I did a little bit more digging to inspect the web socket traffic and it looks like the subscribe packet is never being sent by the browser.  I followed the debugger all the way down to the mqtt-packet module writing to the stream.  Looks like on the next tick when the stream gets uncorked, the message gets sent in Chrome, but not in Edge.  Any thoughts or insights would be greatly appreciated!

Hey @stevilyu ,
Thanks for a digging in to this issue, very helpful!
isBrowserSocket is defined here:
https://github.com/kmamykin/mqtt-websocket-stream/blob/master/src/utils.js#L19
export const isBrowserSocket = (socket) => {
  return socket.send.length === 1 // send is sync in browser and async with length 3 on server using 'ws' module
}

which was kind of a hack. The idea is we need to differentiate between a browser version of WebSocket and a server/node.js version of WebSocket. While both implementations should be compatible (ha!) ws.WebSocket.prototype.send takes 3 parameters (and is async function with a callback) and browser's WebSocket.prototype.send takes 1 parameter, and is sync.
I see that https://msdn.microsoft.com/library/Hh994652 has it that send takes only 1 argument, so my guess is that socket.send.length returns 0 on MS Edge. May be due to https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/110711/
I dont have Ms Edge installed, if you can figure out a better way to check if WebSocket instance is browser's or ws's let me know, or better yet submit a pull request against https://github.com/kmamykin/mqtt-websocket-stream

I actually just ended up changing that conditional statement to make it work:
var isBrowserSocket = exports.isBrowserSocket = function isBrowserSocket(socket) {
  return socket.send.length != 3; // send is sync in browser and async with length 3 on server using 'ws' module
};```

Probably not the best approach, but worked in a pinch!


Use CDN in examples?

Hello. You may not be aware of this, but instascan is available on cdnjs. In your examples, you assume the user is using a copy of instascan on their server, however, using a CDN is much better. You might want to change your examples to use the CDN instead.
Here's the CDN: https://cdnjs.com/libraries/instascan

nvm the cdn doesnt work


Re-generate for ML 2021-10

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/azp run

/azp run "net - machinelearningservices - ci"

/azp run net - machinelearningservices - ci

/azp run net - machinelearningservices - ci

API changes have been detected in Azure.ResourceManager.MachineLearningServices. You can review API changes here

API changes have been detected in Azure.ResourceManager.MachineLearningServices. You can review API changes here

API change check for Azure.ResourceManager.MachineLearningServices
API changes have been detected in Azure.ResourceManager.MachineLearningServices. You can review API changes here

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.MachineLearningServices
Azure.ResourceManager.MachineLearning


How do I use QSV for auto conversions

I have set up qsv on my Synology DS918+ and it works from the handbrake web interface.
I can’t seem to figure out how to get this to work for auto conversion. I guess this needs a change to my docker run command, but I can’t figure out what the changes are.

Hi rubyredrick,
great I can help a fellow DS918+ friend ;-)
I've made my own conversion preset (wirt h265 qsv, quality settings, audio settings, ...) and use this conversion preset in the docker enviroment settings
 (sorry, german settings)

Hi rubyredrick,
great I can help a fellow DS918+ friend ;-)
I've made my own conversion preset (wirt h265 qsv, quality settings, audio settings, ...) and use this conversion preset in the docker enviroment settings

Thanks. but your link only leads to a jpg image.
The problem I'm having is that I'm ending up with videos which have a black screen, and only audio.  This is my current setup.
I also made a preset.
QSV 1080p30.json.txt Note I renamed it from .json to .json.txt so that GitHub would accept it as an attachment.

Here is my handbrake debug log
handbrake.debug.log

Are you using the same preset that is working in the UI?

Yes, I just reran using the web UI and it’s fine. I’m mystified.


Roll-up of tweaks and enhancements made to the core compiler dialects.

These are standalone updates made to the util dialect as part of the streams work. For context of where these are used see the full branch... or use imagination.

(the failure here is https://github.com/google/iree/issues/7323)


Removing iOS 7 Support

According to Apple, 54% of devices are on iOS 10, 38% are on iOS 9, leaving just 8% on iOS 8 or below. They don't show the breakdown of that 8%, but I think it's safe to say that less than 1% of users are still on iOS 7. I'd love to remove all the iOS 7 stuff and make the iOS code way more readable. I will probably do this soon unless anyone objects.

+1
RN doesn't even support iOS 7 now, it's moved to 8.

Done


fix(build): fix condition on ubuntu 18.04 and EL family

https://github.com/Kong/kong/actions/runs/3937638139/jobs/6735444446


Use individual fork to submit homebrew updates

Public-Facing Changes
None
Description
Use @foxglovebot's "personal" fork of homebrew to release CLI versions, rather than the @foxglove org's fork. This allows homebrew automation to amend the PR.
Fixes https://github.com/foxglove/mcap/issues/1063

Why not keep the commit message?

The first two lines of the commit message are the default.
The third line of the commit message was not actually @mentioning us (see https://github.com/Homebrew/homebrew-core/pull/162640 for example).

The dream of @ mentions has died. I tried many things and was unable to get it to work.


Unit tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e85531) 36.68% compared to head (f5f6e02) 44.02%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   36.68%   44.02%   +7.33%
==========================================
  Files           7        7
  Lines         477      477
==========================================
+ Hits          175      210      +35
+ Misses        276      235      -41
- Partials       26       32       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Enhancement] Lazy loading tree

Changed directory tree behavior on BE & FE to implement lazy loading (loading each directory when it is requested).
Work Summary
BE

Refactored api.js to two new files: folderService.js & fileService.js.
Changed behavior of folderService get function to implement getting only the requested directory layer.
New folderService.js sets the type attribute as the file extension.

FE

changed directory-tree to implement lazy loading using the new folderService.get function.
Change file icon (and color) based on tree type attribute.
On initialization, The initial tmp_path directory will be loaded (moved to a variable for convenience).

Some known issues

14 - output.name = 'Development'; is hard-coded. Needs to just get the directory name and of course it needs to check that the path is actually a directory!!!.

@ortichon - This is the pull request that will solve your problem. I was able to load my Development folder with this (and with your current pull request I can't).
Tell me if this helped. And please kindly review it :smile:
At Google, we used to mark a pull request as good with a:  tag. you can add one in a comment by writing :lgtm:. Reviewable supports a quick emoticon retrieval functionality that's pretty cool (though it's taken from Github :laughing: )

Comments from the review on Reviewable.io

Hi,
The lazy loading works fine and behaves as expected. I checked it on my Mac machine with my home folder.
-enhancement
Currently folder has their own icon and all but they don't have the caret triangle until selected. so the user can't know if the folder is empty of not before selecting it.
-bug
when selecting a folder with massive content (folders or files) the list getting out of bounds, we'll have to change the container div "overflow-y" to scroll

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

everything on the screen don't have real styling. The code editor have the same problem (with the height). We'll fix this in a new branch and create a new bug for it so it will be considered a mission.
-enhancement  I thought about removing the triangle all together, so it didn't bother me as much. We can open a bug about it but it's gonna be pretty low priority in my opinion. It's clear that a folder is empty since it's being selected instead of expanding.
I rather have an open-folder closed-folder icon toggle if you think something clearer is needed.

Comments from the review on Reviewable.io

I'll write some follow ups I started developing for this change:

Sorted files and folders.
20+ file extensions support
default file icon for unsupported files.

Comments from the review on Reviewable.io

Ok, cool. great idea about the open/close folder icons.
May I merge to master?

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

Sure. Go ahead :wink:

Comments from the review on Reviewable.io

Summary

added angular-loading-bar to bower
changed directory structure to include components.

Each component will have the following folder structure:

[component_name] {
  [componentName].js
  [componentName]Template.html
  // [componentName]Style.scss (to be added later)
}

[componentName].js

Most of the time, this will include a directive + controller combo. Things like Modals don't need a directive:

angular.module('[appName]')
  .directive(function() {

	})
	.controller('[componentName]Ctrl' ,function() {

	})


Add src/ to .npmignore

We're publishing the .ts files to npm because of the empty .npmignore

Actually... including /src/ makes the source maps works for consumers. Including the source shouldn't be causing a problem.

how about?
"sourceMap": true,
"inlineSources": true
https://www.typescriptlang.org/docs/handbook/compiler-options.html


What are the pressure measurement scenarios of Shenyu

Our company is conducting pressure test on Shenyu recently. I'd like to ask about the pressure test scenario of Shenyu.

you can run  shenyu, and then test it

I mean stress test scenario,for example open log or close log ,some performance bottleneck scenario and so on...  it not just  a simple test. I want to get some practical advice. thanks

Hi @kangarooking , I understand what you want. But it's hard to give a precise scenario (deployments, configurations, etc.), since there are uncertain upstream and downstream services. I would suggest that you just start the benchmark test and try to improve the performance step by step. Once the performance meet your requirement, you will get the best scenario which you want. And the feedback is welcome here, if you'd like to share.

Excuse me, do you have the pressure test results？


Updated TOC to include section 4.19 34.shutdown_heartBeat.yaml and 35.start_heartBeat.yaml

Updated TOC to include section 4.19 34.shutdown_heartBeat.yaml and 35.start_heartBeat.yaml

Covered by PR #26


Form Fields which cause a validation error off-screen with ListView.builder do not have an error when you scroll down

Steps to Reproduce

Create a form long enough that you want to use ListView.builder for performance
Submit the form with a field off screen past what is built lazily
When you scroll down, the widget will not show an error
If you scroll back up, widgets which used to show errors have them cleared
If you press submit again and there is an error at the top still, the fields which used to have an error do not display anything

Expected results:
An error message on fields which blocked the form from submitting
Actual results:
No error (but it's worth noting the fields off screen do properly block the forms validation)

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  State<MyHomePage> createState() => MyHomePageState();
}

class MyHomePageState extends State<MyHomePage> {
  final formKey = GlobalKey<FormState>();

  final controllers = List.generate(20, (index) => TextEditingController());

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(
        child: const Icon(Icons.send),
        onPressed: () {
          final isValid = formKey.currentState!.validate();

          if (!isValid) {
            ScaffoldMessenger.of(context).showSnackBar(
              const SnackBar(
                backgroundColor: Colors.red,
                content: Text('Correct the form'),
              ),
            );
          } else {
            ScaffoldMessenger.of(context).showSnackBar(
              const SnackBar(
                backgroundColor: Colors.green,
                content: Text('Form valid'),
              ),
            );
          }
        },
      ),
      body: Form(
        key: formKey,
        child: buildListViewBuilder(),
      ),
    );
  }

  // This will show errors on off-screen widgets when you scroll down
  Widget buildSingleChildScrollView() {
    return SingleChildScrollView(
      child: Column(
          children: controllers
              .map((c) => MyFormField(
                    controller: c,
                    i: controllers.indexOf(c),
                  ))
              .toList()),
    );
  }

  // This will not show errors on off-screen widgets when you scroll
  Widget buildListViewBuilder() {
    return ListView.builder(
      itemCount: 20,
      itemBuilder: (context, i) {
        return MyFormField(
          controller: controllers[i],
          i: i,
        );
      },
    );
  }
}

class MyFormField extends StatefulWidget {
  final TextEditingController controller;
  final int i;

  const MyFormField({
    Key? key,
    required this.controller,
    required this.i,
  }) : super(key: key);

  @override
  State<MyFormField> createState() => _MyFormFieldState();
}

class _MyFormFieldState extends State<MyFormField> {
  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(16.0),
      child: TextFormField(
        controller: widget.controller,
        decoration: InputDecoration(
          labelText: "Field ${widget.i + 1}",
        ),
        validator: (s) {
          if (s == null || s.isEmpty) {
            return "Field is required";
          }
        },
      ),
    );
  }
}

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.19043.1466], locale en-CA)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc5)
[√] Chrome - develop for the web
[√] Android Studio (version 4.1)
[√] IntelliJ IDEA Community Edition (version 2021.1)
[√] VS Code (version 1.63.2)
[√] Connected device (3 available)

• No issues found!

https://user-images.githubusercontent.com/29047682/150879128-8773dc01-296e-4b73-9c75-76357fc908fe.mp4
Notes

AutomaticKeepAliveClientMixin does NOT cause fields which have never been rendered yet to properly display an error when you scroll down. It does however, cause fields which displayed an error to still be red when you scroll back up
restorationId on the form and fields does not fix it either

Hi @MilesAdamson, Thanks for filing the issue. This is working as intended considering ListView.builder builds its items on demand which means when the item is about to be visible in the viewport it gets built and destroyed when its gets off screen based on the cacheExtent value, You can control this length using cacheExtent
e.g  adding cache extent 2000 (should be maxExtent) fixes the issue for your case
  Widget buildListViewBuilder() {
    return ListView.builder(
      itemCount: 20,
      cacheExtent: 2000,
      itemBuilder: (context, i) {
        return MyFormField(
          controller: controllers[i],
          i: i,
        );
      },
    );
  }

while in case of any other ScrollView like SingleChildScrollView or ListView all its child / children are created at once regardless of the length of the list and are stored in memory until the lifetime of the widget.
Closing as this is working as intended, if you disagree feel free to write in the comments and I will reopen it.
Thank you.

Hey @maheshmnj, using cacheExtent and/or the ListView(  constructor does not let form fields render on their first build with an error. Only putting all of the children in a SingleChildScrollView + Column works, which could have performance issues with a long enough form

Also before anyone says "just make the form shorter and multiple pages" the app works with JSON schema and I do not have complete control over the length of the form. Some pages are obscenely long

@MilesAdamson you are using a cache extent of 20  as a result you are still seeing the error getting reset. try setting it to 2000, Alternatively, you could maintain the errors in the state of the app and show errors for selective fields, Heres is a similar discussion on StackOverflow for your reference https://stackoverflow.com/questions/47409181/losing-state-of-each-form-field-when-the-form-is-scrolled-off-screen

Yes I could re-write the form field and form state, and house all the errors in my app state. However, why can't the form field draw itself with an error when it has an error on its first build? Its not clear to me how that it's intended and a non-issue that form fields can have an error which invalidates the form, but visually have no error

However, why can't the form field draw itself with an error when it has an error on its first build?

This is happening for two reasons firstly your form is long and secondly, you are using ListView.builder the listview Items are erased and rebuilt from memory when they go off-screen and are brought into the screen (made visible).
Heres a short video from flutter to understand this https://www.youtube.com/watch?v=KJpkjHGiI5A

I understand the widget is erased from memory. What I don't understand, is that when a TextFormField comes into memory, and my form state has an error, why does it not display that error? Its state does not match what is rendered.
As you said I could house the errors in my own app state and make a form field render with an error on its first build. Why can't TextFormField's do the same?


Feature/single server smart graph satellite

Scope & Purpose
Tests for dump and restore when dumping on single server and restoring in a cluster for SmartGraph, Disjoint SmartGraph, HybridSmartGraph and HybridDisjointSmartGraph. Added tests for empty graphs (without edge relations), graphs without data (with empty vertex and edge sets) and graphs with data:

The smart graph is a cycle of length 100 with a symmetric edge relation and self-loops on every vertex.
The disjoint graph is a disjoint union of two such cycles of size 50 each.
The satellite graph is also a disjoint union of two such cycles of size 50 each.
The hybrid graph has two vertex collections: one satellite and one smart each of size 50. In both vertex collections, the vertices are enumerated by value (which is the smartGraphAttribute) from 0 to 49. The edges go from vertex i (in the satellite collection) to vertex i (in the smart collection) and from vertex i to vertex (i+1) % 50.
The hybrid disjoint graph a graph with one satellite vertex collection (verticesSat), two non-satellite vertex collections (verticesANonSat and verticesBNonSat) connected to other collections, an orphan collection and two edge relations: edgeSatA from verticesSat to verticesANonSat and edgesAB from verticesANonSat to verticesBNonSat. The size of every vertex collection is 50. In each vertex collection, the vertices are enumerated by value (which is the smartGraphAttribute) from 0 to 49. Edges from edgeSatA go from vertex i (in verticesSat) to vertex i (in verticesANonSat) and from vertex i to vertex (i+1) % 50. In total, we have 50 + 50 = 100 edges in this collection (this is tested). Edges from edgeAB are constructed with the same function but go only from vertex i to vertex i because both vertex collections are not satellite and vertices with different values of value (i.e., i and (i+1) % 50) cannot be
connected in a disjoint graph. Thus in total we have 50 edges in this collection (this is tested).

The orphans are faked: just some vertex collections are used to fill them, but it is not tested whether the vertices are really orphans.
The tests verify that graph and collections properties of restored graphs are correct.
(Please describe the changes in this PR for reviewers - mandatory)

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[ ] No backports required
[ ] Backports required for: (Please specify versions and link PRs)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket number:
[ ] Design document:

Testing & Verification
(Please pick either of the following options)

[ ] This change is a trivial rework / code cleanup without any test coverage.
[ ] The behavior in this PR was manually tested
[ ] This change is already covered by existing tests, such as (please describe tests).
[x] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[x] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:
Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the HTTP API
[ ] Added Swagger examples for the HTTP API
[ ] Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

Jenkins started now. Will merge as soon as jenkins reports green.

Jenkins green ,will merge now back to feature base branch


Phinvads Vocab function enhancements

@mscaldas2012 comments....
I was wondering if we can make some changes to Redis PHINVads...
I'd like to see if you can add the concepts as a map ... like this:
/* Insert name and age field in  */Map<String,String> map = new HashMap<String, String>(map.put("concept1",valueConcept1);map.put("cencept2",valueConcept2);jedis.hmset("PHVS_YesNoUnknown", map);
[Yesterday 11:37 AM] Caldas, Marcelo (CDC/DDID/NCEZID/DPEI) (CTR)
with that' I don't even need to download the concepts... I'll be able to use a jedis.hexists("vocabKey", "conceptKey")

@mscaldas2012 Which PR was this implemented on? (Because I'd like the PR and the issue linked)

@mscaldas2012 Which PR was this implemented on? (Because I'd like the PR and the issue linked)


error TS2440: Import declaration conflicts with local declaration of 'SoapClient'.

Building the client, it produces an error:
$ tsc
src/client/soap/client.ts(1,10): error TS2440: Import declaration conflicts with local declaration of 'SoapClient'.

In client.ts there is a line
export interface SoapClient extends SoapClient {

obviously a class cannot extend itself,
an easy fix will be to change the import statement to:
import { Client as SoapClientBase, createClientAsync as soapCreateClientAsync } from "soap";

and then use it like so:
export interface SoapClient extends SoapClientBase {

Is there something I might be missing here, or is it a bug ?

Ah, I figured it out! I was using a file named: soap.wsdl file, which generated SoapClient which happens to much the default SoapClient. Renaming the file soap.wsdl to something else resolved the issue, but it should be nice to have a check for this in the source.
I think this issue can be closed now.

I had a similar issue with a number in my wsdl file name and that caused a bunch of issues


Question about auto reconnect

Hi,
I'm using the ESP32-A2DP library and i'm not sure about the auto reconnect feature.
I try to build a speaker with a power save mode and therefore  i want to stop Bluetooth sink when entering power saving. It works for me when using a2dp_sink.end(false) and restart it with a2dp_sink.start(true, true) which sould use the auto reconnect feature (but it doesn't work).
Isn't it working as aspected or do i use the functions not as intended?
Kind regards
Franz

By calling end() you basically indicate that you do not want to reconnect.
What happens if you don't call end ?

If I don't call end the device will stay connected. Any other options to disable bluetooth and activate it later again?

You can try disconnect() ?

I'm getting core panic exceptions as soon as i call end method (without any own code).
Is there an option to make device not visible?

Depends what you mean with this and your IDF release.
Maybe you look for set_discoverability()

Thx. When i manage visibility, scan_mode and last connection on my own everything works as aspect. Shall i close the issue or do you want to look after twice end call?
Really appreciate your help :)

I suggest that you close.


Update glfw.c3

extname -> extern, define -> typedef changes.

Thanks 🙏

Sorry if I'm making a lot of pull requests, I'm looking at how much the deprecated syntax constructs are used and figured I could suggest fixes for what I found.


Added support for ActionName attribute in XML comments

Added support to ApplyActionXMLComments for ActionName attribute.  Fixes
#118

Just released version 4.2.0 with these changes. Please try it out and provide feedback if you get a chance.
FYI, bar any serious bugs, this will be the last release of the 4.x line. All future development and features will be targeted to the next major version 5.x, which makes the transition from Swagger 1.2 to Swagger 2.0.


Automated Package Upgrade

:tada: This PR is included in version 5.0.429 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Restructure functionselect

Separate aggregates from Q Functions (Q Functions = NONE + BIN + aggregates - COUNT)
Separate timeUnits from T Functions (T Functions = NONE + timeUnits)
Tested in Voyager2 and PoleStar.

Fix a bug where bin is duplicated in scope.func.list.aboveFold.

I think the description is pretty vague.  I think you mean we set  func.list.aboveFold = aggregates.aboveFold and thus splicing func.list.aboveFold cause side effect to aggregates.aboveFold, which is probably bad.  But I still don't understand why is that bad?  Is it because then you'll have multiple bin in the list?
In any case, the splice thing is already a hack and this is another hack to fix the hack.
I wonder if this would only create more and more problems?
I don't understand why you don't just have aboveFold and belowFold for Q and T, which is the right grouping rather than having to do this messy splice.

@kanitw Re-structuring is done. Please review (again).

@kanitw I've cleaned up the .all fields. Hopefully this is cleaner.


Wrong image scale for iPhone 6+ Zoomed in mode

@implementation AFImageResponseSerializer
- (instancetype)init {
...snip----
#if defined(__IPHONE_OS_VERSION_MIN_REQUIRED)
    self.imageScale = [[UIScreen mainScreen] scale];
    self.automaticallyInflatesResponseImage = YES;
#endif

    return self;
}

here the scale is wrong if the iPhone 6+ uses the zoomed mode.
This fixes it, but only for the instance of 6+ and @3x:
CGFloat scale =[[UIScreen mainScreen] scale];
if  ([[UIScreen mainScreen]respondsToSelector:@selector(nativeScale)])
{
    CGFloat nativeScale = [[UIScreen mainScreen]nativeScale];
    if (scale != nativeScale) {
        if ((scale==3)&&(nativeScale>2.65))
        {
            scale = 2;
        }
    }
}

self.imageScale = scale;

That's interesting. So you end up with a 3x image when you actually need a 2x image?

Yes. So say I GET an image that is 60x60px. if @2x it reports its size as 30x30px. If @3x it reports its size as 20x20 pixels. In zoomed in mode on iPhone 6+, which still reports its scale as 3 but is pretending to be 2, then, all the images look like they are 33% smaller.
My solution works for this instance but I don't think it's great or I would have checked it in ;-)

For the iPhone 6, if you are running Zoomed Mode, you get the following values:
[[UIScreen mainScreen] scale] == 2.0
[[UIScreen mainScreen] nativeScale] == 2.34750

6+ In Standard Mode
[[UIScreen mainScreen] scale] == 3.0
[[UIScreen mainScreen] nativeScale] == 2.608696

6+ in Zoomed Mode
[[UIScreen mainScreen] scale] == 3.0
[[UIScreen mainScreen] nativeScale] == 2.88


Dates for meetings and outreach

community outreach and meetings date formats are not applied consistently some are 2020/6-7/6 and others are 2020/6/6-2020/7/6 (also that date format is unhelpful for sorting and being able to have a sortable table so you can see most recent conference or for example all iwbda conferences would be nice)

will fix that too.

Fixed!


dashboard: improve the needRepro logic

This has two objectives:

Make repros better over time (as we update descriptions / improve
syzlang / repro- and fuzzing algorithms), even for old bugs.
Constrain the impact of backward compatibility bugs in syzkaller.
The fewer old repros we have, the less likely it is to stumble on some
problem during patch testing / bug or fix bisection.

Also closes https://github.com/google/syzkaller/issues/3122

@dvyukov PTAL
Added tests + added the extra logic for the SYZFAIL/SYZFATAL case (so that now it also closes https://github.com/google/syzkaller/issues/3122).

@dvyukov @tarasmadan PTAL


Autotracking is showing Powder when it hasn't been received.

I didn't look into the code much to figure out the actual issue, but the autotracking ID for Powder seems to be wrong, as it's lighting up when I don't have Powder. Possibly linked to the wrong item.

Yeah thats most likely because you did magic bat with fake powder.
But yeah powder is a bit wonky and i will look over it.

No, I did not. This issue was noticed because it showed Magic Bat (which is mislabeled "Satan" for some reason?) was green.

Ah ok. Then i really need to look into that.
Yeah. I really should rename it to "Magic Bat" but the Satan comes from the group I usually play with 🫠 same with "brewing drugs" subtitle of the witch hut check.


could the static HttpClient be re-used by multiple users at the same time?

Suppose I defined a static HttpClient as below(per this doc):
private static HttpClient httpClient = new HttpClient();
Then there are 100 users calling this function at the same time, I want to know if the static HttpClient can be re-used among these 100 users? or each user have a HttpClient instance?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb8d85a7-1ca3-71f4-85fb-7fb02850b60e
Version Independent ID: 3d7daee4-fd6d-0e96-299a-90b3637e6150
Content: Manage connections in Azure Functions
Content Source: articles/azure-functions/manage-connections.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Thanks for bringing this to our attention. We are actively investigating and will get back to you soon.

Hi @star286 - That's right, all 100 users will share the same connection pool owned by the same instance of HttpClient.
Per the doc for HttpClient:

HttpClient is intended to be instantiated once and re-used throughout the life of an application

@mike-urnun-msft , thanks for your information:). One more question, is this also true for documentdbclient / sql client?

@star286  That's right, DocumentDB client uses singleton which achieves the same thing and the SqlClient also does the same thing through ADO.NET.
Since we didn't determine any changes to this doc upon reviewing your feedback, we will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


1.20.1

As the title suggests 1.20.1 PLEASE!!!!!
This has been a good ver for Minecraft mods so please add it

As stated in another issue, support for Minecraft 1.20.1 is currently not planned.

This issue has been resolves in commit 6ba5f38 on the backport/1.20.1 branch.