Youtube session invalidation - simply exits instead of reloading

When a youtube video is left paused in mpv for a long time, the session becomes invalidated (naturally). However, when resumed and the cached amount is consumed, mpv simply exits as it thinks the EOF has been reached. The expected behaviour would be to reload the video from its original url.
The following error messages are the only ones which appear after the youtube session has been invalidated:
[ffmpeg] https: HTTP error 403 Forbidden
[ffmpeg] tls: The specified session has been invalidated for some reason.
[ffmpeg] https: Will reconnect at 95321392 in X second(s), error=Input/output error.

where X takes the value of 0, 1, 3, and 7.

@Farzat07 thanks for reporting, I'll try to reproduce this issue. How long do I need to wait until the cache invalidation happens?

I never really measured the time, but I guess around 6 hours should be enough.

Ugh, it'll take some time to reproduce. BTW, after reading the issue again

... mpv simply exits as it thinks the EOF has been reached.

The plugin has an option to check for more content after the EOF is reached. But it is disabled by default.
# when the end-of-file is reached, reload the stream to check
# if there is more content available.
reload_eof_enabled=no

Maybe try enabling it and see if that helps.

Yeah but I believe that is supposed to be for different use cases e.g. a live stream.
When used on normal videos that setting makes mpv kinda enter into an infinite loop at the end of the video.

mpv kinda enter into an infinite loop at the end of the video

Hmm... it does not happen to me, at least with YouTube videos. Can use send a link that triggers this behavior when played with mpv?

Ok I was wrong actually - it does not actually get into a loop, but it does get stuck at the ending which makes it seem like so. At the EOF the video reloads and as there is nothing left to play, the video just stays as it is.
I'm finding this behaviour consistent across videos, even local ones. You can reproduce with this one https://videos.lukesmith.xyz/w/jNDH1cnxNfwwJH2pZvAqdM. The only exception was youtube though - it just exited normally after discovering that this is actually the end of the file.
In the end this setting seems to effectively mimic the --keep-open option as a side effect (at least in the majority of cases). It might work as a temporary solution but I don't think it is ideal.

I'm trying to check the link. youtube-dl does not recognize the file format, are you using a different backend?
$ mpv 'https://videos.lukesmith.xyz/w/jNDH1cnxNfwwJH2pZvAqdM'
Failed to recognize file format.

$ youtube-dl -F 'https://videos.lukesmith.xyz/w/jNDH1cnxNfwwJH2pZvAqdM'
[generic] jNDH1cnxNfwwJH2pZvAqdM: Requesting header
WARNING: Falling back on generic information extractor.
[generic] jNDH1cnxNfwwJH2pZvAqdM: Downloading webpage
[generic] jNDH1cnxNfwwJH2pZvAqdM: Extracting information
[info] Available formats for jNDH1cnxNfwwJH2pZvAqdM:
format code  extension      resolution note
0            unknown_video  unknown

Yeah I'm using yt-dlp because they applied the fix to that (peertube links).
You can use this static link though, same effect.
https://videos.lukesmith.xyz/static/webseed/9847f270-f9ab-42ff-8d33-a59da419b245-480.mp4

Hmm... For me, the video doesn't get stuck or get into a loop. On EOF it reloads and then exits.
$ mpv 'https://videos.lukesmith.xyz/static/webseed/9847f270-f9ab-42ff-8d33-a59da419b245-480.mp4'
 (+) Video --vid=1 (*) (h264 852x480 24.000fps)
 (+) Audio --aid=1 (*) (aac 2ch 44100Hz)
Cannot load libcuda.so.1
AO: [pulse] 44100Hz stereo 2ch float
VO: [gpu] 852x480 => 853x480 yuv420p
AV: 00:09:32 / 00:09:32 (100%) A-V:  0.000 Cache: 0.0s
[reload] eof reached, checking if more content available
[reload] reloading video from 572.232562 second
[reload] file  1 of 1 in playlist

AV: 00:09:32 / 00:09:32 (100%) A-V:  0.000 Cache: 0.0s
 (+) Video --vid=1 (*) (h264 852x480 24.000fps)
 (+) Audio --aid=1 (*) (aac 2ch 44100Hz)
AV: 00:09:32 / 00:09:32 (100%) A-V:  0.000 Cache: 0.0s
[reload] eof reached, playback ended

Exiting... (End of file)

I'm using the default youtube-dl script. Can it be an issue with how the reload plugin interacts with yt-dlp?

Ok I tried the original youtube-dl backend, same problem.
But then I tried changing my configuration to see if one of my settings was causing this: turns out the culprit is gapless-audio=no. Once I comment that line, the error disappears.
I still need that setting though - without it replaygain settings can't be used on playlists (check https://github.com/mpv-player/mpv/issues/8267).

gapless-audio setting has no effect to me. From the man page

     NOTE:
        This feature is implemented in a simple manner  and  relies  on  audio  output  device
        buffering  to  continue playback while moving from one file to another. If playback of
        the new file starts slowly, for example because it is played from a remote network lo‐
        cation  or because you have specified cache settings that require time for the initial
        cache fill, then the buffered audio may run out before playback of the  new  file  can
        start.

I assume it has something to do with the latency, maybe I wasn't lucky enough. Anyway, I'll try to reproduce the original issue with the timed-out YouTube session.


datatable: implemented js datatable

Summary
Bringing the ability to define custom datatables to js.
Details
Before we're getting into details, I'd like to point this out:
There's a lot of duplication with parameter type registry (in cucumber-expressions).
Ideally, I'd want to predefine some types, likes [int]... but that requires the paramter type registry.
Shouldn't we just build this at the same place the parameter type registry is? (move parameters out of expressions?)
Shouldn't it just they both just be the same registry?
@aslakhellesoy @mpkorstanje
When we do get into details:
There's some things to be aware of / TODOs

Its my first (real) commit: dont hold back on your comments, I likely messed up a lot
Although I wrote tests before code, I didnt consider many edge cases yet, at least should do some parameter checks.
I pretty much ignored any kind of CI for now
I haven't really looked at how this ties into cucumber-js yet
I did not look into a general (for all languages) DataTable test set, nor writing documentation

Motivation and Context
conversation started here: https://cucumberbdd.slack.com/archives/C6QJ6N695/p1525332789000331
How Has This Been Tested?
Merely unit tests - not even sure if I built the right thing (see above)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[X] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[X] I've added tests for my code.
[X] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

There's a lot of duplication with parameter type registry (in cucumber-expressions).
Ideally, I'd want to predefine some types, likes [int]... but that requires the paramter type registry.
Shouldn't we just build this at the same place the parameter type registry is? (move parameters out of expressions?)
Shouldn't it just they both just be the same registry?

They look the same but they aren't the same.

Paramter types in cucumber expressions work on the results of regexes.
The data table types work on table cells, table rows, table entries and whole tables.

This means that you can't reuse cucumber expression types as data table types.  An example of this difference would be string. In cucumber expressions escaped quotes are unescaped. In data table they are not.
What does look similar all the other functions that transform a string into a basic type. But this is merely a coincidence and trivial enough to ignore the duplication effects off.

@mpkorstanje thanks for the quick feedback.
I think I see your argument for keeping some separation. Just as a brain dump, I think one could desire to have a type defined both for expressions and datatables:
When winning numbers are 1, 2 and 3
// expression: `winning numbers are {[int]}`

When winning numbers are:
    | 1 |
    | 2 |
    | 3 |
// expression: `winning numbers are` + data table type `[int]`

It would get interesting is when you define a custom parameter type mytype and would like to get [mytype] table for free - which would be totally awesome. we could quite easily build that smartness into datatable I guess, but it (or another entity) has to know about the parameter type registry.
together with a normalization (like the escaped quotes vs non escaped quotes you mention).

They look the same but they aren't the same.

I feel they are conceptually more similar then is implemented, and it somewhat still feels unnatural tables are so diverged from types in expressions.

You might be able to achieve this one abstraction level higher. There you could multiplex certain registrations to both the data table and parameter type registry. But you'd have to know if regex and transform function are safe to use.
For example:
defineParameterType(new ParameterType<>(
    'color',           // name
    /red|blue|yellow/, // regexp
    s => new Color(s)  // transformer function
))

defineDataTableType(new DataTableType<>(
    'color',
    new TableCellTransformer(s => s is red blue or yellow ? new Color(s) : throw excpetion)
))

Could be replaced with a single call if  defineParameterType were to multiplex all registrations to defineDataTableType and the real defineParameterType like so:
defineParameterType(new ParameterType<>(
    'color',           // name
    /red|blue|yellow/, // regexp
    s => new Color(s)  // transformer function
))

But now you could put orange in the data table and end up with a valid, but rather unexpected color. I suppose you could wrap the transform function in a function that checks the regex first and aborts if it doesn't match.

The above doesn't solve the problems of  string.
This gives us a few options:

Leave both registrations separate. Downside, no free conversion. Upside, no problems
Demultiplex registrations.  Free conversion, but we need a solution and we need to be able to explain it.

Question: How often are types between steps and data tables shared?  If often it'd be worth spending time one. Otherwise the actual duplicate registration will be a rare occurrence so not really worth adding complexity for .

That was fast! I'll need some time to review this. I'll post here later.

Transformers implemented somewhat differently than java: as static methods of DataTableTransformer (instead of their own classes). Found that a js-friendlier approach.
And for consistency, used the name DataTableTransformer instead of TableTransformer

And for consistency, used the name DataTableTransformer instead of TableTransformer

Perhaps I should consider that too.

Transformers implemented somewhat differently than java: as static methods of DataTableTransformer (instead of their own classes). Found that a js-friendlier approach.

Looks good to me!

At first glance this looks like a rather different implementation from the Java one. If you look at the other libraries (gherkin, cucumber-expressions, tag-expressions) you'll find that implementations are pretty similar. Same class names, same method names, same implementations, same tests etc.
Anyone who only knows one of the supported programming languages should be able to fix a bug or add a feature in all the other implementations. -Simply by finding their way around a consistently organised codebase.
Did you consider designing/organising the code (and tests) more similar to the Java implementation @lenntt?

@aslakhellesoy @mpkorstanje
I mainly looked how cucumber-expressions/javascript was organized an took conventions from there, but tried to honor the java implementation as much as possible (though not finished).
I agree that the behavior and tests should be more similar. I'll work on that ~next week.
But, I don't want to introduce any unnecessary complexity. As javascript isn't statically typed like java, it doesn't need to be as verbose. Agreed?
Just curious - did you consider transpiling java to javascript?

As javascript isn't statically typed like java, it doesn't need to be as verbose. Agreed?

Sure, but the overall structure should be the same.

Did you consider transpiling java to javascript?

And Ruby and Go and other future languages? No :-)

Cool, I think I'm not that far off - just not complete.
I hadn't really looked at DataTableTypeRegistryTableConverter (and tests) ealier.
It isn't documented (nor used anywhere?).

Where does it fit in? Whats the difference between a converter and a transformer?
Also, I tried not to break with whats already in cucumber-js, which seem to have a similar role (?) but is different?

The converter is used behind the scenes by DataTable.asX methods. This can be used by the user to convert a data table when cucumber can't, or shouldn't.

Also, I tried not to break with whats already in cucumber-js, which seem to have a similar role (?) but is different?

Don’t aim to keep this backwards compatible. Aim for an implementation that is as consistent as possible with datatable/java.
We can add backwards-compatible layer in cucumber-js later, or we can decide just to break backwards compatibility, as Cucumber-JVM 3.0.0 does.

@mpkorstanje Thanks, got it.
Think the biggest feature gap is that the js implementation isn't typed. So, for example, I'm not able to specify the keys in my map are integers, without transforming to integers in my transformer myself.
Would this be acceptable to add that later? It should be possible a type system later as a non-breaking change. (and I do think it will be different from the java implementation).
I'd rather focus on polishing a minimal viable thing (tests, docs, ci -> integration in cucumber-js), as I can't estimate how much time I can spent in upcoming weeks.
@aslakhellesoy fair enough :)

for noise reduction, will reopen/create new one when ready. hopefully, later this/next week

Reopening, but still wip - starting by translating the tests (sidenote: not all are java tests are friendly-structured for translation to describe-it). Good to do, as java and javascript starting to look more like each other.
But I still have concerns and I'm not a 100% convinced we should aim for java parity, especially for a first step: javascripters aren't used to typed tables/objects nor need to be as strict in java. like ruby.
Therefore, the use cases are limited.
As a cucumber user, I'd be happy with a defineDataTableType where I can define a 'type' (as string-identifier?) together with a 'transform' function that gives me a DataTable as parameter.
All the extra's like trying to auto-convert the table (e.g. solve {MyObject=> [MyOtherObject]}), has very little value to me - though this is where a lot of the added complexity is (LOCs * 10 at least). I don't like writing 100s lines of code no one is going to use (or likes to maintain).
So @mpkorstanje , @aslakhellesoy , does it make sense to weaken the datatable spec for dynamically typed languages (javascript, ruby)?

Solving my {MyObject=> [MyOtherObject]} would be over kill I imagine. Do you think {"String"=> [MyOtherObject]}  is also useless? That is what the language supports.

not useless, little value.
Perhaps because I haven't seen the datatable language full in action yet.
The few builtin converters, to support 'basic' type of tables, comparable to cucumber-js
I'd be totally happy if I could do, for example, something like this:
defineDataTableType('myOtherObjectTable', function(dataTable) {
   let myTable = dataTable.hashes()     // {String => String[]}
   Object.keys(myTable).forEach(function(key) {
       obj[key] = obj[key].map((cell) => {return new MyOtherObject(cell)}) // convert String[] to MyOtherObject[]
   });
   return myTable
});

The registry itself doesn't need to know about MyOtherObject itself.

For Java I know that the example you've given would be a royal pain to implement. Especially if I had to do it for a few types. And while implementing the converter in Java I found that it was easier to implement the full set of theoretically possible transformations then to limit my self to the practical set. It drove out all the edge cases.
But I'm out of my depth when it comes to utility in js. If the primary uses are lists of hashes, or hashes of hashes then we wouldn't need the transformers at all in js. In which case it'd be better not to implement it at all.
Are there typescript bindings for cucumber?

Afaik typescript compiles to js, so you're just using the js bindings.
I'm inexperienced with TS, but I can imagine it can be more painful like java.
What we could do... implement my straightforward suggestion straight into cucumber-js instead?
That way, the gap between cucumber-js and cucumber grows. but:

cucumber repo is kept consistent,
it also gives us some room for getting real use cases and something more concrete to discuss?

I was thinking of doing it the other way around. I think I could extract out all the jvm specific stuff. Having the same basic data table implementation in a single location is a good thing.
.

And this would also make it easier for other implementations to get started on data tables.


Website latency reduction

I'll use this issue to collect some of the opportunities to improve page load time based on my attempts to measure latency for defining an SLO:

https://tools.pingdom.com/#618e1f3848c00000

I'm planning to work on this one.

I just assessed the performance using Page Speed Insight:
https://pagespeed.web.dev/analysis/https-osv-dev/rsqqsi0hrn?form_factor=mobile
and it indicates potential room for improvement on the mobile version.

https://github.com/google/osv.dev/pull/2221


[py2py3] Check unittests from Slice 20 in py3 #10551

Fixes #10551
Status
in dev
Description
open
1. JobSubmitter_t

[ ] usual change mode opening pickle file
[ ] broken test/python/WMComponent_t/JobSubmitter_t/JobSubmitter_t.py:JobSubmitterTest.testA_BasicTest

run
python3 setup.py test --quickTestMode=true --buildBotMode=true --reallyDeleteMyDatabaseAfterEveryTest=true --testCertainPath=test/python/WMComponent_t/JobSubmitter_t/JobSubmitter_t.py:JobSubmitterTest.testA_BasicTest

2. ./test/python/WMComponent_t/DBS3Buffer_t/DBSUpload_t.py

[ ] check why this is failing in my docker, but nothing is reported by jenkins. seems like a connection problem

fixed
Is it backward compatible (if not, which system it affects?)
yes
Related PRs
follow up to #10349
External dependencies / deployment changes
nope

I add here some more information about the problem described above.
The unittest
python3 setup.py test \
--quickTestMode=true --buildBotMode=true \
--reallyDeleteMyDatabaseAfterEveryTest=true \
--testCertainPath=test/python/WMComponent_t/JobSubmitter_t/JobSubmitter_t.py:JobSubmitterTest.testA_BasicTest

It fails with [1]. I added some debugging, pushed to this branch https://github.com/mapellidario/WMCore/commit/620972ece11a8c5e3b40450bba7c9c562eb6de4e  and i get [2] in stdout.
Notice that

SandboxCreator creates /tmp/tmpktiqf054/workloadTest/TestWorkload/WMSandbox/WMWorkload.pkl
in GetSpecAndNameFromTaks.py we get from MySQL /tmp/tmpktiqf054/workloadTest/workloadTest/WMSandbox/WMWorkload.pkl

and these two differ!
[1]:
======================================================================
FAIL: Use the MockPlugin to create a simple test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dmwm/wmcore_unittest/WMCore/test/python/WMComponent_t/JobSubmitter_t/JobSubmitter_t.py", line 363, in testA_BasicTest
    self.assertEqual(len(result), nSubs * nJobs)
AssertionError: 0 != 40

[2]:
-------------------- >> begin captured stdout << ---------------------
Installing JobDump app into database: http://localhost:6994/jobsubmitter_t%2Fjobs
Installing FWJRDump app into database: http://localhost:6994/jobsubmitter_t%2Ffwjrs
Installing WMStats app into database: http://localhost:6994/wmagent_summary_t
Using MockLogDB
DM debug - makesandbox /tmp/tmpktiqf054/workloadTest/TestWorkload/WMSandbox/WMWorkload.pkl
DM debug - makesandbox2 False
DM debug - wmworkload setspecurl /tmp/tmpktiqf054/workloadTest/TestWorkload/WMSandbox/WMWorkload.pkl
DM debug - makesandbox2 /tmp/tmpktiqf054/workloadTest/TestWorkload/WMSandbox/WMWorkload.pkl True
DM debug - propagate  created
DM debug - propagate  created
DM debug - getalljobs [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40]
Using MockReqMgrAux ('http://localhost/reqmgr2',) {}
DM debug - propagate  submitfailed
DM debug - entry <WMCore.Database.ResultSet.ResultSet object at 0x7fdee7e175b0>
DM debug - entry [{'name': '2c97e0fc-fa5f-4e86-8056-be035e5369cf', 'spec': '/tmp/tmpktiqf054/workloadTest/workloadTest/WMSandbox/WMWorkload.pkl', 'task': 'basicWorkload/Production'}]
DM debug - getDataFromSpecFile /tmp/tmpktiqf054/workloadTest/workloadTest/WMSandbox/WMWorkload.pkl
DM debug - persistency load - filename /tmp/tmpktiqf054/workloadTest/workloadTest/WMSandbox/WMWorkload.pkl
DM debug - persistency  False
DM debug - A
DM debug - getalljobs []
DM debug - getalljobs []

--------------------- >> end captured stdout << ----------------------

@amaltaro I really need to ask for your help here, something bad is happening but I do not know what.
You can start from this PR, but feel free to start from scratch and apply one commit at a time to see what they change, maybe you can come up with better solutions. Thanks in advance! Sorry to change your schedule!

test this please

@amaltaro I realized that you already fixed most of these issues in #10636. I left only a couple of fixes to the unittests themselves. I think we can merge this. What do you think?


Change to using sys.path and other windows compatibility changes

[X] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.
[X] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
[X] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
[X] I've written tests to cover the new code and functionality included in this PR.
[X] I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

this should fix import issues in Windows for importing plugins in the load_plugin() method.

Related Issues

Related to #2 (code credit to the PR, but had to clean it up as a merge seems to have gone wrong)

Test strategy

Manually tests with my plugins with py2.7 and 3.5 on Mac. Testing on a windows machine momentarily.

Coverage decreased (-0.2%) to 34.194% when pulling a8ee0a44773a7f50d747d413f4b944240dff63fa on jammons:make_plugin_imports_work_in_windows into 14442f3f43787ec3260aa2206c2c51deecd85892 on slackhq:master.

This looks good to go after that one fix! :shipit:


can nvblox ros use lidar as input?

Hi I'm using nvblox to produce a costmap for my robot to do a navigation
can it inputs Lidar pointcloud data and still works?
also, if I use other lidar based SLAM as a state estimator, would it works?
since the rgbd and double stereo IR camera and RGB camera altogether takes up too much bandwidth
If nvblox can inputs lidar data and so do vslam, then It might be able to just using lidar data.
Is that right or I am missing something?
thanks for any reply.

nvblox_ros accepts 3D LiDAR input. We are also agnostic as to where the pose estimate comes from, so an (accurate) 3D pose from LiDAR SLAM will work fine.
I am somewhat surprised you have bandwidth problems though. Are you using the realsense? What computer are you running on?

nvblox_ros accepts 3D LiDAR input. We are also agnostic as to where the pose estimate comes from, so an (accurate) 3D pose from LiDAR SLAM will work fine.
I am somewhat surprised you have bandwidth problems though. Are you using the realsense? What computer are you running on?

Hi @alexmillane,
thanks for the reply, and for the bandwidth, I'm using realsense d435i and now I'm transmitting these datas from one computer to another, so smaller bandwidth usage would be appreciated
another question is that can this nvblox map reuse as to the navigation application? since for the navigation loading a map which is already built is more convenient.
Thanks for your reply.

Ah I see. Your bandwidth limitations now make sense.
The nvblox_node exposes a load map service that can be used to load an existing map for navigation.

Ah I see. Your bandwidth limitations now make sense.
The nvblox_node exposes a load map service that can be used to load an existing map for navigation.

How can I use this map for navigation2? I couldnt find any example related to this

We have docs about using this package for navigation on Nova Carter here.
To run it on your own robot, you'll have to adapt the nova carter launchfiles to your robot.

here.
I glanced this page but there does not exist isaac_ros-dev package in github and this nova carter tutorial launch files run from packe isaac_ros-dev.  That's why I cannot reach launch files or anyother to implement my robot


Creating npm package for ts client

Could we put the package.json in the src/Microsoft.AspNetCore.SignalR.Client.TS folder? Seems awkward to have it at the repo root.

Not sure. 2 reasons:

Samples and tests depend on that because they use browserify and gulp. If this is moved to a subfolder we will have to run npm install multiple time (slow) on multiple levels (I don't even think is supported currently by the build system)
in npm repo is a package if I moved it to a subfolder I would have to place distributable files to a subfolder of src/Microsoft.AspNetCore.SignalR.Client.TS to be able to publish the package. The src/Microsoft.AspNetCore.SignalR.Client.TS would have to have the .npmignore file and things are getting even messier. In the other PR I copy files from the dist folder which is now in the root - if this is moved they would have to search for the build artifacts in the src/Microsoft.AspNetCore.SignalR.Client.TS

As I said today during the meeting - it almost feels like the TS client should be in a separate repo (or we could create a repo just for building the npm package and consume JS client as an npm package here but we would always be 1 commit behind)

⌚


FCE-747 | integrate new protobufs in webrtc and ts client

Description
Implements protobuf communication in webrtc-client as well as in ts-client.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to
not work as expected)

Wjechał


Check if the outputDir exists before attempting to create the version…

…s.json file
Description
When generating API specifications using the versioning configuration, there is not check if the directory exists like in the generateApiDocs function. This results in an error when creating the versions.json file.
Motivation and Context
This change is required so that you can generate versioned docs without any issues.
How Has This Been Tested?
I changed my version of the plugin locally and verified that this does in fact fix the issue. I generated versioned api docs and did not get the error after implementing this change.

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

Hi @tyler-mairose-sp, install the latest canary release if you need it sooner.
As for #893 I think the implementation works but I have concerns that it may be too open, i.e. it would effectively execute/eval whatever function is provided by the user...but not yet decided on what the actual risk is.
Have you considered alternative approaches, perhaps a custom vendor extension that we could use to inject the classname?

Hi @tyler-mairose-sp, install the latest canary release if you need it sooner.
As for #893 I think the implementation works but I have concerns that it may be too open, i.e. it would effectively execute/eval whatever function is provided by the user...but not yet decided on what the actual risk is.
Have you considered alternative approaches, perhaps a custom vendor extension that we could use to inject the classname?

Hey @sserrata,
TLDR: I haven't thought of a better way yet.
I originally wrote it so that x-experimental set to true would trigger the class add and that would work. For our use-case we already have a header that designates whether something is experimental so I was trying to avoid adding another custom field to our specs.
I did try to make it open so that more code changes would not be required in the future. A user of this plugin could specify the custom class as the key and their function check as the value in the plugin configuration.
My thought was that whomever uses the plugin would be the one putting in their function check so it would be okay, but I am not sure what all could be run from that function's context.

I originally wrote it so that x-experimental set to true would trigger the class add and that would work.

One other idea that may work today: have you tried implementing a custom mustache template for this? The idea would be to create if statements that apply a specific sidebar_class_name depending if an operation has an extension. It's not a perfect solution, because there's no way to actually check the value of the extension, only the existence of any extensions...so if you already have custom extensions defined for some of your operations this may not work....
---
id: {{{id}}}
title: "{{{title}}}"
description: "{{{frontMatter.description}}}"
{{^api}}
sidebar_label: Introduction
{{/api}}
{{#api}}
sidebar_label: "{{{title}}}"
{{/api}}
{{^api}}
sidebar_position: 0
{{/api}}
hide_title: true
{{#api}}
hide_table_of_contents: true
{{/api}}
{{#json}}
api: {{{json}}}
{{/json}}
{{#api.method}}
{{#api.extensions.length}}
sidebar_class_name: "experimental api-method"
{{/api.extensions.length}}
{{^api.extensions.length}}
sidebar_class_name: "{{{api.method}}} api-method"
{{/api.extensions.length}}
{{/api.method}}
{{#infoPath}}
info_path: {{{infoPath}}}
{{/infoPath}}
custom_edit_url: null
{{#frontMatter.proxy}}
proxy: {{{frontMatter.proxy}}}
{{/frontMatter.proxy}}
{{#frontMatter.hide_send_button}}
hide_send_button: true
{{/frontMatter.hide_send_button}}
{{#frontMatter.show_extensions}}
show_extensions: true
{{/frontMatter.show_extensions}}
---

{{{markdown}}}

And here's a snippet of my plugin config showing how to define the template:
petstore: {
            specPath: "examples/petstore.yaml",
            proxy: "https://cors.pan.dev",
            outputDir: "docs/petstore",
            sidebarOptions: {
              groupPathsBy: "tag",
              categoryLinkSource: "tag",
            },
            template: "api.mustache", // Customize API MDX with mustache template
            downloadUrl: "/petstore.yaml",
            hideSendButton: false,
            showSchemas: true,
          } satisfies OpenApiPlugin.Options,

Sorry, forgot to add this...technically, there is a way to write an if statement that checks the value of the extension, but it would require writing some preprocessing logic that is currently not open/exposed via the plugin options.
That said, maybe providing a way to pass custom template functions is another viable path to supporting this.


Replace md5 checksum on repository keys with fingerprint (bsc#988907)

(cherry picked from commit e1c01647bf36d14f7f35c1fee23d7738d34a13a7)

+1


Closes #2113 fix derive extreme records

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

I was thinking about the test you added. Is that sufficient or do we need another test for dataset_ref when it isn't the same thing ? I am thinking no, but...

In all other tests which specify dataset_ref it is different from the input dataset. So I think this case is covered.


Confirm that trips sharing a block cannot overlap

Error 54 states that "block trips must not have overlapping stop times". Where does this requirement come from? I understand the logic, but has a consumer indicated this is a problem for them?
Full content of the error message (as an example):
Notice{filename='trips.txt', level='ERROR', code='54', title='Block trips must not have overlapping stop times', description='Trips with trip_id: 15141366-NC2010-NCTD-Weekday-06 (first time: 16:06:00, last time: 17:00:00) and 15245013-NC2010-NCTD-Holiday1-11-1111111 (first time: 16:06:00, last time: 17:00:00) from block: 30301 overlap. Conflicts happen on: [tuesday, wednesday, thursday, friday, monday].', extra='{blockId=30301, tripFirstTime=16:06:00, previousTripFirstTime=16:06:00, previousTripId=15245013-NC2010-NCTD-Holiday1-11-1111111, conflictingDateList=[tuesday, wednesday, thursday, friday, monday], previousTripLastTime=17:00:00, tripId=15141366-NC2010-NCTD-Weekday-06, tripLastTime=17:00:00}'},

@mcplanner This rule is implemented in the original Google GTFS Python validator, so implementation in this tool was part of reaching feature parity with the Python validator. Here's the Python validator rule implementation:
https://github.com/google/transitfeed/blob/d727e97cb66ac2ca2d699a382ea1d449ee26c2a1/transitfeed/schedule.py#L1205
...and the error text:
https://github.com/google/transitfeed/blob/d727e97cb66ac2ca2d699a382ea1d449ee26c2a1/transitfeed/problems.py#L754

@mcplanner This rule is implemented in the original Google GTFS Python validator, so implementation in this tool was part of reaching feature parity with the Python validator. Here's the Python validator rule implementation:
https://github.com/google/transitfeed/blob/d727e97cb66ac2ca2d699a382ea1d449ee26c2a1/transitfeed/schedule.py#L1205
...and the error text:
https://github.com/google/transitfeed/blob/d727e97cb66ac2ca2d699a382ea1d449ee26c2a1/transitfeed/problems.py#L754

Got it, thank you!

Got it, thank you!


Unable to delete individual files with "-" suffix.

I'm trying to delete delete  a single file from a multiple file upload field but it does not seem to work. I just get back a 200 for the patch request and see that nothing was actually deleted.
Deleting all the files by using null works tho.
Any suggestions?
Thanks in advance.

I've just tested it locally and it is working fine for me (there are also integration tests that confirms the behavior).
Here is an example with the JS SDK:
await pb.collection("example").update("RECORD_ID", {
    // you can also pass an array for deleting multiple files
    "myFileField-": "abc_Fdt6aN3pdZ.png"
})

Are you sending json or multipart/form-data? Could you provide a code sample?

I'm closing the issue since I'm not able to reproduce it. I've tested it locally with both json and miltipart/form-data requests and it is working fine for me.
I'm not sure what could be the cause of the issue in your case. Make sure that you are using PocketBase v0.11+.
Feel free to provide more details how you are sending the request and I'll investigate it further.


set camera to continuousAutoFocus

in the handler that is called 1 second after tap to autofocus, set the camera mode to continuous autofocus.

in the handler that is called 1 second after tap to autofocus, set the camera mode to continuous autofocus. Before, it was setting to autoFocus without continuous mode.
Description
in FocusHandlerExtension func resetCameraToContinuousExposureAndFocus()
changed .autoFocus to .continuousAutoFocus
Motivation and Context
https://github.com/dokun1/Lumina/issues/99
How Has This Been Tested?
with this fix, after tapping to focus on a point for 1 second, the camera mode successfully returns to continuous autofocus.
Types of changes

[X ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ x] I have read the CONTRIBUTING document.

oops, this is not the correct change. Please disregard this PR.


Languages are incorrectly showing up as "overrides"

We need to ignore application/languages in the overrides section. It's sending application/languages and the updater is warning us for having too many overrides.

I always asked myself why languages are shown in /dashboard/system/environment/info
What about removing this line ?

Yeah, that line shouldn't be in there.


Print network and time info when the board starts

Printing network info and the current time (when setting that up) is useful for debugging purposes. Due to the "example" nature of this project I think it's useful to show this when a user is moving first steps with a ESP32 board.

I've addressed your comments and rebased on the latest master

Thx @gguuss !


Add python release workflow and changelog

Description of change
Add python release workflow and changelog
Links to any relevant issues
Fixes https://github.com/iotaledger/wallet.rs/issues/741
Type of change

Enhancement (a non-breaking change which adds functionality)

Change checklist

[ ] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that new and existing unit tests pass locally with my changes

Release would currently fail on macos because of rocksdb, see https://github.com/Thoralf-M/wallet.rs/actions/runs/3695378920/jobs/6257680734


JTextField: scrolling works incorrectly

And scrollbars on OS X not works. Also in HTML too.

What do you mean? Could you provide a screenshot?


GCP - Pin Google SDK

https://github.com/capitalone/cloud-custodian/blob/master/tools/c7n_gcp/setup.py#L34
Latest version of google SDK no longer has oauth2client.  Either pin to old SDK or add that dependency to setup.py
https://github.com/google/google-api-python-client/commit/9eb303e10cc9d6aa09137d1d68a0673e5aa5b4b0#diff-2eeaed663bd0d25b7e608891384b7298

thanks for the heads up.

Seems like the blocking issue is resolved here.


Incorrect pynvml dependency

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
For several builds now, the upstream version of this package has supported pynvml 11.5.  However, this package continues to list pynvml <11.5 as a dependency.  I would just submit a PR to address this issue.  However, since this package has also dropped support for Python 3.8, I would also appreciate if an appropriate build supporting pynvml 11.5 could also be made for Python 3.8, which may mean another build of v1.5.39.
Installed packages
N/A

Environment info
N/A

@emeryberger @jaltmayerpizzorno @sternj  Checking in on this issue.  Any thoughts?

It might be worth moving to nvidia-ml-py, which superseded pynvml (with a couple features dropped)
nvidia-ml-py is continuing to get regular updates; whereas, pynvml is not
Admittedly this may involve upstream changes

I just verified that nvidia-ml-py works on a recent-ish NVIDIA GPU, and have switched to that. I'll cut a new release momentarily.

Closing as nvidia-ml-py will be the NVIDIA GPU library going forwards.


Using Sprig with non craft dataset tables

Hello,
I wasn't able to find any examples of using Sprig with a database table not supplied by Craft. Is this possible? My use case is that we have several databases not related to Craft CMS, and our commerce items are located in a MS SQL Server.

Sprig doesn't care what database you use – if it can be done via Twig or PHP then it can be done with Sprig.


Package does not include the py.typed file?

While the repo has a py.typed file and uses annotations, I don't think the py.typed file is being packaged which causes the following error when type checking code which imports piptools:
error: Skipping analyzing "piptools": module is installed, but missing library stubs or py.typed marker  [import]
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

I think the solution is to just include package_data = ["py.typed"] in setup.cfg.
As a bonus the classifier Typing :: Typed could also be added.

Hello @AustinScola,
FYI, I made a PR to fix this. Just out of curiosity, why do you need to import piptools in your code?

Just out of curiosity, why do you need to import piptools in your code?

I have a wrapper script around piptools that adds functionality.

Interesting, is this something we could integrate into pip-tools?

Maybe? It lets me use a config file to give names to specifications of requirements files and to freeze multiple specifications at once


Do you know the performance impact (PI) algorithm?

Hi, the latest distributed task allocation algorithm based on market auction mechanism is performance impact (PI) algorithm, this algorithm is also improved in the framework of CBBA, do you have relevant knowledge about PI algorithm?

Hi, thanks for reaching out. I'm not aware of this algorithm since distributed task allocation is not in my research scope.


Can't build app to Android

I tried this options when building:

It did not work. Any workarounds?

Try to  !

That may solve it, gonna test it and reply the results here.

Sadly, it didn't work, now the error is:

And i still can't build it :/

I figured it out! The build was failing because   was set to   instead of  ! Closing this issue now!


Ingress Controller - external address value

Hi,
I have been using Nginx Ingress Controller with Kubernetes cluster on AWS and i have noticed that the address field in the ingress object is updated automatically based on which host the Pod of IngressController is running on.
I think it would be better if the external IP or maybe a service name (will be LoadBalancer Service) to extract the external IP from.
Thanks.

@mrmm this is fixed (not released yet). Next version will use the correct value in AWS and GCE

@aledbf thanks for the reply, i am looking forward for the release ;)

@aledbf , could this also work with bare metal? Or is there a workaround to get a node public ip?

could this also work with bare metal?

The behavior in baremetal is the expected. It returns the node where the ingress controller is running. What issue do you have with this?

@aledbf, we have discussed it in slack. You wrote the current release 0.8.3 doesn't work right with external-ip. Do you have release any beta of ingress-controller on gcr.io which i can test ?

@remoe not yet. We are moving the code from this repo to kubernetes/ingress

i was wondering if this works. I've found this: https://github.com/kubernetes/contrib/issues/228 :

In a general sense, there's just no way we could know how to provision
external IPs for nodes short of a cloud provider hook, and sadly "bare
metal" is not a cloud provider yet.

Is this no longer the case?

@aledbf , the main issue was:
https://github.com/kubernetes/kubernetes/issues/23920


Bump version to 0.10.1

Describe your changes

Linked issues

Closes
Breaking changes

[ ] This issue contains breaking changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (46866af) 69.30% compared to head (4c14e46) 69.23%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   69.30%   69.23%   -0.08%
==========================================
  Files          72       73       +1
  Lines        3128     3130       +2
  Branches      315      308       -7
==========================================
- Hits         2168     2167       -1
- Misses        810      813       +3
  Partials      150      150

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support release parameter

This will be required for server-stored source/maps.
Raven.config({release: "my app version"})

http://sentry.readthedocs.org/en/latest/developer/client/index.html#release

:+1:


Brainstorm image

@jonathantorres

Added initial notes here: https://github.com/Nobox/finalizer-server/blob/dev/docs/sow.md please make any updates or changes as necessary :+1:

:+1: cangri lets code tomorow ;)


Fix implicit istream cast

On my c++ compiler (apple clang v11), the implicit cast of istream to bytes read caused an error.  Adding the explicit call to "gcount()" fixed that. Not sure if this will cause issues on any other compiler...
Also, those commits/reverts should be squashed or whatever.  Mistakenly committed the exes while testing the fix.

Great! Thanks.


fix: [446] better gitignore for IDEs and OS.

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?
How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
Should ignore IDEs and OS files.
Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Listing shows up without PyCharm exclusions not to be Added in git commands.
Related issues or PRs
(https://github.com/cpacker/MemGPT/issues/446)
Is your PR over 500 lines of code?
Yes the .gitignore adds OS(Linux, Windows, macOs), IDE(PyCharm, VisualStudio, pydev, NetBeans, Eclipse) Other(vim, JupyterNotebooks)

Tests are Failing on a nonrelated Error in tests regarding gitignore.
FAILED tests/test_websocket_interface.py::test_websockets - requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.openai.com/v1/chat/completions
============= 1 failed, 15 passed, 5 skipped, 2 warnings in 51.24s =============
Error: Process completed with exit code 1.


JavaScript Platform

We need a way to generate a complete JavaScript file for execution.  A couple of options:

Direct the JavaScript platform to build JavaScript files individually for items on the whileypath.
Update the JavaScript backend to simply translate all items on the whileypath automatically.  This is perhaps a bit awkward if we're building libraries, etc.  We could use a build.js.library flag or similar perhaps.

Actually, this was already done.


Data Structure Analysis

Adapted version of DSA for BASIL
includes symbolic access analysis and a reaching definitions analysis that works slightly differently from the one already implemented. (registers changed by a procedure call are defined by the call instruction)

I'm a bit confused by the commit history here - some of Yousif's commits that are not ready to merge in yet have been included, but then later reverted? Is there a neater way to do things than that?

It'll take some time to get across all the details of this, so detailed comments would really help to make it easier to understand.
One thing that makes the code more difficult to follow at the moment is the widespread use of tuples - is it possible that replacing those with case classes would make sense?

https://github.com/UQ-PAC/BASIL/blob/c806362d0f7e867968c39808c2bc559eb06543cd/src/main/scala/analysis/solvers/IDESolver.scala#L105
The call to exitToEntry here causes a ClassCastException: class ir.Procedure cannot be cast to class ir.IndirectCall for the tests correct/syscall/clang_O2:GTIRB and correct/syscall/gcc_O2:GTIRB when run with the analysis on.

Is there an option to output the .dot files you demonstrated today? I can't find that anywhere, and when I attempted to manually add that functionality, none of the nodes in the .dot files I got it to output had any contents beyond a number.
Rather than using .dot graphs though, it would be more useful for debugging if it could print the mappings in plain text, in an order that made sense - relating back to the order of statements in the IR?

Is there an option to output the .dot files you demonstrated today? I can't find that anywhere, and when I attempted to manually add that functionality, none of the nodes in the .dot files I got it to output had any contents beyond a number.

I pushed my most recent changes on, now you should be able to produce dot graphs from a DSG using
writeToFile(dsg.toDot, "test.dot")

Rather than using .dot graphs though, it would be more useful for debugging if it could print the mappings in plain text, in an order that made sense - relating back to the order of statements in the IR?
Yeah this makes sense, I'll work on outputting text format

That's pretty much what I added in, but the DOT graph it produced didn't have anything in the nodes except their number, it didn't contain all the information that was in the graph you demonstrated today.

mainTopDown.txt
This is one of the outputs I got, for src\test\correct\jumptable\clang\jumptable.adt

That's pretty much what I added in, but the DOT graph it produced didn't have anything in the nodes except their number, it didn't contain all the information that was in the graph you demonstrated today.

could you please pull and try again

Thanks, that works.
The DSA seems to run into problems with overlapping accesses. The following is from src\test\correct\jumptable\clang\jumptable.bir with comments added:
000003fe: R8 := 0x10000
// 0x10DC0 contains a pointer to the procedure add_two
// 0x10DC8 contains a pointer to the procedure add_six
00000404: R8 := R8 + 0xDC0
// loading 128 bits from 0x10DC0 loads both the 64-bit pointer at address 0x10DC0
// and the 64-bit pointer at address 0x10DC8 to V0, concatenated together
0000040b: V0 := mem[R8, el]:u128
// storing V0 to the stack stores the pointer to add_two at R31 + 0x10 and the pointer to add_six at R31 + 0x18
00000413: mem := mem with [R31 + 0x10, el]:u128 <- V0
0000041a: R8 := mem[R8 + 0x10, el]:u64
00000422: mem := mem with [R31 + 0x20, el]:u64 <- R8
00000429: R8 := mem[R31 + 0x10, el]:u64
0000042e: R30 := 0x7D0
00000431: call R8 with return %00000433

00000433:
// the DSA says that R8 at this assignment points to node 434 which is empty, but it should point to add_six
// or alternatively some node that represents that the pointers to add_two and add_six were loaded together and stored on the stack together
00000438: R8 := mem[R31 + 0x18, el]:u64
0000043d: R30 := 0x7D8
00000440: call R8 with return %00000442

Flags like CF, VF, etc. are inherently 1-bit values and can't point to anything, I don't think there is a reason to include them in this?

In general it would be preferable if you do not use the examples folder for any tests - the existing contents of the examples folder are very out of date and we really should delete most of them. Any new test files should be put in their own folder in the tests folder - move the /unsafe_pointer_arithmetic and /interproc_pointer_arithmetic folders from /examples to /src/test/dsa.

I've merged this and from my testing it seemed to be working fine, but please create issues for any problems that occur.


A bug about focus~

When the INPUT element get focus, the datepicker box will show, and then I click the INPUT element, the box hide, when I click the INPUT again, the box will not show~~
So I think you bind the focus event on the INPUT element but not click event

I am pretty sure this is intended behaviour so that once the box is closed you can manually type in the date.


Long press flashlight quick action for more options

Long press to choose to activate SOS or strobe (give a few options for strobe frequency)

@kylecorry31  Is this expected to be a dropdown which contain list of strob and SOS
or
long press should navigate to a new screen like flashlight screen

Hi, it should be an option picker dialog  (Pickers.item from Andromeda)


VRPTW-RT

This PR:

[x] Adds instances for the VRPTW with release times (VRPTW-RT).
[ ] Adds the best known solutions.

Shall we close this PR?


fix: articles/active-directory/hybrid/how-to-connect-install-move-db.md

Escape element

@nschonni : Thanks for your contribution! The author, @billmath, has been notified to review your proposed change.

Verified editorial correction. Thanks


CU 8 -  OnBeforeTestBalance new Param or New Event

Hi,
it would be great if we can get a new Param (GLEntry) in this Event or to have another EVENT like maybe "OnBeforeFindGLEntry" or "OnBeforeCalcGLEntry," so we can customize the filtering on GLEntries - to extend the analysis.

it would be great, if this can be added!


Conflict with bootstrap-datepicker

Hi everyone
I'm using bootstrap-datepicker and I'm using bootstrap-editable in another div and i got bootstrap-editable's css overlapping bootstrap-datepicker's behavior.
The problem is that the datepicker-days should be on display block but bootstrap-editable sets the div's property to none.
Could you help me ?
Example code
https://jsfiddle.net/g0j4uxox/1/

I solved this by using JQuery 2.2.4
The problem was that the latest JQuery version doesn't set the div's display's style to block, it just dosn't set any style. That's where your css kicks in and hide it.
This is still a huge problem and you should update your lib.
I'm letting this Issue open to let updaters know this.


ImageMagick resize longest edge to "x"

Hey! I love meteor-uploads and all the hard work you've done, Tomas. Your active presence and support are commendable.
One possible suggestion is to include the option for imagemagick to resize the longest edge of an image, rather than providing a strict w x h. The images I'm working with are portrait and landscape, so having to resize them to a strict w x h pixel size does not work.
As far as I can tell, you can pass the length of the longest edge to imageMagick affixed with ">" and it will resize the image appropriately. I haven't done any tests, I just found the response with some quick searching. Does this sound like something you'd consider implementing?

Hi, I have not tested it, but I'm pretty sure that if you only specify width and no length it will yield into your desires behaviour.

With just width specified, the original image is uploaded, but other versions don't get created and no error is thrown.

Can you get the latest version of server and let me know if it helped? I did not test it.
To set only width you need to specify height as null or 0.

Quickly tested this last night and it looks like it's working! I'll do some more thorough testing early next week to verify if that's okay. Thank you so much Tomi.

It appears to work with both height:0 and height:null. Did you change anything? I could have sworn I tried it with height:null yesterday! Anyway, I think you can close this issue now. Thanks again.

@tomitrescak You can close this, as far as I can tell it is resolved. Thank you.


Error no Module requests_html

ModuleNotFoundError: No module named 'requests_html'

Thank you for reporting this issue but it seems you just don't have the module installed. Please install all modules in the requirements.txt file.

Hello. Yes I installed all the modules. But still I still get this error

Hello. Yes I installed all the modules. But still I still get this error

It sounds like it's not installing correctly. Try the following commands please
pip install --user requests_html --break-system-packages
sudo pip install requests_html --breake-system-packages
You can also try with PIPX
python3 -m pip install --user pipx python3 -m pipx ensurepath sudo pipx ensurepath --global
Fedora--
sudo dnf install pipx
pipx ensurepath
Debian--
sudo apt install pipx
pipx ensurepath
MacOS--
brew install pipx
pipx ensurepath

A beautify update is in development for Ominis-Osint osint. I'll include a install script


[BUG][BACKPORT][v1.3.x] Misleading log "BUG: replica is running but storage IP is empty"

Describe the bug
https://github.com/longhorn/longhorn/issues/4153

Verified on v1.3.x-head
Result Pass
Steps
After upgrade LH from v1.2.4 to v1.3.x-head, can get correct level log(debug) in longhorn-manager pod as below shown
kubectl logs longhorn-manager-vcg2p -n longhorn-system | grep "Replica is running but storage IP"
time="2022-06-21T05:01:42Z" level=debug msg="Replica is running but storage IP is empty, need to wait for update" accessMode=rwo contro


Segfault in prepare job during Patching of the CoreDNS Configmap

When trying to install maesh on our Cluster, the prepare Job crashes with this segfault:
time="2019-10-02T08:48:11Z" level=info msg="Checking Cluster..."
time="2019-10-02T08:48:11Z" level=info msg="Cluster check Complete..."
time="2019-10-02T08:48:11Z" level=info msg="Preparing Cluster..."
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x100c7d7]

goroutine 1 [running]:
github.com/containous/maesh/internal/k8s.(*ClientWrapper).patchCoreConfigMap(0xc00039a280, 0xc000104480, 0xc000447b60, 0x1, 0x1)
        /go/src/github.com/containous/maesh/internal/k8s/client.go:228 +0x67
github.com/containous/maesh/internal/k8s.(*ClientWrapper).patchCoreDNS(0xc00039a280, 0x13fde0c, 0x7, 0x1400ff0, 0xb, 0xc0004bde80, 0x14)
        /go/src/github.com/containous/maesh/internal/k8s/client.go:207 +0x14b
github.com/containous/maesh/internal/k8s.(*ClientWrapper).InitCluster(0xc00039a280, 0x13fcecf, 0x5, 0x0, 0xc00039a280)
        /go/src/github.com/containous/maesh/internal/k8s/client.go:191 +0x101
github.com/containous/maesh/cmd/prepare.patchCommand(0xc0002668c0, 0x20, 0x30)
        /go/src/github.com/containous/maesh/cmd/prepare/prepare.go:46 +0x35d
github.com/containous/maesh/cmd/prepare.NewCmd.func1(0xc0000b2030, 0x0, 0x0, 0x0, 0xc000283d50)
        /go/src/github.com/containous/maesh/cmd/prepare/prepare.go:20 +0x2a
github.com/containous/traefik/v2/pkg/cli.run(0xc000283d50, 0xc0000b2030, 0x0, 0x0, 0x8, 0xc0000d9d18)
        /go/pkg/mod/github.com/containous/traefik/v2@v2.0.0/pkg/cli/commands.go:117 +0x171
github.com/containous/traefik/v2/pkg/cli.execute(0xc000283d50, 0xc0000b2030, 0x1, 0x1, 0x0, 0xc000292201, 0xc00009f5c0)
        /go/pkg/mod/github.com/containous/traefik/v2@v2.0.0/pkg/cli/commands.go:46 +0x7ba
github.com/containous/traefik/v2/pkg/cli.execute(0xc000283ce0, 0xc0000b2020, 0x2, 0x2, 0xc000283d01, 0x1e8b920, 0xc000058750)
        /go/pkg/mod/github.com/containous/traefik/v2@v2.0.0/pkg/cli/commands.go:81 +0x15c
github.com/containous/traefik/v2/pkg/cli.Execute(...)
        /go/pkg/mod/github.com/containous/traefik/v2@v2.0.0/pkg/cli/commands.go:40
main.main()
        /go/src/github.com/containous/maesh/cmd/maesh/maesh.go:43 +0x3e1

The Cluster is a kubeadm cluster on version 1.14.7 with CoreDNS 1.3.1. Tiller is running with a cluster-admin ClusterRole so it should have enough permissions.

Hey @CBeerta,
that looks strange. Which version of Maesh you're running?

Ive used helm install --name=maesh --namespace=maesh --set controller.image.tag=latest --set controller.logging.debug=true maesh/maesh` to install, so 0.4.0

Thanks. I'll give it a go and see if I can reproduce your issue

Does it matter that our CoreDNS sits in the kube-system namespace? With configmap and all?

I'm pretty certain that the problem is coreConfigMapName = coreDeployment.Spec.Template.Spec.Volumes[0].ConfigMap.Name.
In the kubeadm deployment, the first volume for coredns is an emptydir for /tmp.
If i move the tmp Volume to the second place in the deployment, and the configmap to first, the hook completes and patches the configmap.

Thanks for digging that up! That would explain why it doesnt happen for me on k3s. I just tried to reproduce your issue. I'll need to see what we can do to prevent that

Hey @CBeerta,
I have a created an experimental image with a (potential) bugfix included. Could you try that out?
helm install helm/chart/maesh --namespace maesh --set controller.image.name=santode/maesh --set controller.image.tag=issue261
Thanks :)

Yes @SantoDE, that that version installes perfectly, thanks!


Don't use Zwitterion

Zwitterion is becoming obsolete, it is a little too unwieldy and complicated. I would like to replace it with zwitterion-production, but the NGINX dependency is undesirable since it can't be installed with npm (at least no one seems to have made a project for that yet). I think I should use a simple Node static server, and perhaps use the TS transpilation portion of zwitterion-production if that is important enough.

This fixes the NGINX dependency problem: https://github.com/lastmjs/nx-local-server

We will use Zwitterion, which is currently the zwitterion-production project. It will need to be merged into zwitterion


Run TestBuildCopyWilcardInName only on linux daemon and unix client

Should fix win2lin.
/cc @thaJeztah @mlaventure @johnstep @tiborvass @duglin
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

LGTM
ping @jhowardmsft

Hmmm. This should work win2lin and on RS1 win2win... Let me look in a bit what's going on.

Yeah, this is the wrong fix. It's a test bug somewhere in the context building code, nothing to do with Windows not supporting wildcards. See this simple manual test which does similar (running against a Linux machine from a Windows client)
PS E:\docker\build\TestBuildCopyWildcardInName> $env:DOCKER_HOST="jhoward-ubuntu:2375"
PS E:\docker\build\TestBuildCopyWildcardInName> docker build .
Sending build context to Docker daemon 4.096 kB
Step 1/3 : FROM busybox
 ---> d9551b4026f0
Step 2/3 : COPY *.txt /tmp/
 ---> 566236cb63a7
Removing intermediate container 83eeb9cf1434
Step 3/3 : RUN ls -l /tmp/
 ---> Running in 90e0ed46386e
total 8
-rwxr-xr-x    1 root     root            47 Jan 20 18:21 file1.txt
-rwxr-xr-x    1 root     root            47 Jan 20 18:21 file2.txt
 ---> fa30e689e061
Removing intermediate container 90e0ed46386e
Successfully built fa30e689e061
SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. All files and directories added to build context will have '-rwxr-xr-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.
PS E:\docker\build\TestBuildCopyWildcardInName>

@johnstep FYI

Oh actually, I see, I misread the comment and what the test is doing. Correct, Windows doesn't support * in a filename.
LGTM.


H5190 support

What issue do you have? Please be as thorough and explicit as possible.
I have an H5190 water temperature sensor for my pool. When signing into my account in homebridge, the status page shows an error message with the following:
{"device":"03:1F:74:8D:00:00:00:16:FF:FF:00:40:FF:FF:00:13","deviceName":"H5109_0013","model":"H5109","httpInfo":{"groupId":0,"device":"03:1F:74:8D:00:00:00:16:FF:FF:00:40:FF:FF:00:13","sku":"H5109","spec":"","versionHard":"1.4","versionSoft":"1.9","deviceName":"H5109_0013","deviceExt":{"deviceSettings":"{"temMin":0,"temMax":4000,"temWarning":false,"fahOpen":false,"temCali":0,"humMin":0,"humMax":10000,"humWarning":true,"humCali":0,"netWaring":true,"uploadRate":10,"battery":100,"wifiLevel":0,"sno":0,"powerSaveModeState":false,"gatewayId":452416,"gatewayInfo":{"device":"0E:0C:D0:C9:07:14:D2:34","sku":"H5042","topic":"GD/0e9b1d18a37f326276b4dd3d1d501f6b","bleName":"ihoment_H5042_D235","address":"D0:C9:07:14:D2:35","secretCode":"EKt3bqCzdZM="},"sku":"H5109","device":"03:1F:74:8D:00:00:00:16:FF:FF:00:40:FF:FF:00:13","deviceName":"H5109_0013","versionHard":"1.4","versionSoft":"1.9"}","lastDeviceData":"{"online":false,"tem":3285,"hum":0,"lastTime":1719540600000,"avgDayTem":3285,"avgDayHum":0}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/86c7b7b5b9fd09778d79463a8afc4268-add_list_type_device_h5109.png\",\"headOnImg\":\"\",\"headOnImgNew\":\"\",\"headOffImg\":\"\",\"headOffImgNew\":\"\",\"ext\":\"\",\"ic\":0}"},"share":0,"deviceId":21998774,"gidConfirmed":true,"goodsType":199,"attributesId":0,"supportScene":0}}
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?

Which version of Homebridge/HOOBS do you have?

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.

Which version of this plugin (homebridge-govee) do you have? Has the issue started since upgrading from a previous version?

Which Govee devices do you have that are causing issues? Please include product models if applicable.

Please paste any relevant logs below.

I have the same sensor and it would be great if it was added.

Very interested in this as well. Holding off on purchasing this combo deal until support is confirmed
https://us.govee.com/products/goveelife-smart-pool-thermometer-with-smart-gateway-1s?Style=1+Gateway+%2B+2+Floating+Sensor

Also should be noted that the Gateway H5042 and Floating Sensor is H5109 and NOT H5190.

any idea when this might be supported? i see the template addition. i have this device and am in the latest beta. finds it fine but no devices created yet. anything i can do to help develop or test this? i’m not super clear what the templates do differently than the known devices. thanks!


Error detected while processing function kite#events#event[29]

On every keystroke in nvim, I'm getting this error:
Error detected while processing function kite#events#event[29]..kite#client#post_event[5]..kite#async#execute:
E117: Unknown function: chansend
Error detected while processing function kite#events#event[29]..kite#client#post_event[5]..kite#async#execute:
E117: Unknown function: chanclose

I have tried reinstalling the plugin.
I'm running Ubuntu 18.04.5 LTS and using neovim v0.2.2.
Here's the link to the Kite-generated application log

The plugin only works with neovim v0.3.0+.  Sorry, the version check in the plugin is out of date and it should have warned you.


FileNotFoundError: [Errno 2] No such file or directory: '/home/orazayy/GAST-Net-3DPoseEstimation-inference/lib/detector/yolov3/../../../checkpoint/yolov3/yolov3.weights'

Dear @fabro66
I think there is inconsistency in file locations, hence I am getting the following error:
python gen_skes.py -v baseball.mp4 -np 1
Loading YOLOv3 network.....
Traceback (most recent call last):
  File "gen_skes.py", line 179, in <module>
    generate_skeletons(video=video_path, output_animation=args.animation, num_person=args.num_person)
  File "gen_skes.py", line 114, in generate_skeletons
    keypoints, scores = hrnet_pose(video, det_dim=416, num_peroson=num_person, gen_output=True)
  File "/home/orazayy/GAST-Net-3DPoseEstimation-inference/lib/pose/hrnet/pose_estimation/gen_kpts.py", line 185, in gen_video_kpts
    human_model = yolo_model(inp_dim=det_dim)
  File "/home/orazayy/GAST-Net-3DPoseEstimation-inference/lib/detector/yolov3/human_detector.py", line 88, in load_model
    model.load_weights(args.weight_file)
  File "/home/orazayy/GAST-Net-3DPoseEstimation-inference/lib/detector/yolov3/darknet.py", line 352, in load_weights
    fp = open(weightfile, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '/home/orazayy/GAST-Net-3DPoseEstimation-inference/lib/detector/yolov3/../../../checkpoint/yolov3/yolov3.weights'

Thanks.

Hi~   I just fixed it. You can change the file name of "checkpoints" to "checkpoint"

Thanks, it works now.


Fix typos

Pull Request Motivation
Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).
Use the following command to get a quick and dirty summary of the specific corrections made:
git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

forbiden (6)
shoud (4)
comare (4)
exhanges (4)
lastest (3)
revsion (3)
seclector (2)
certificiate (3)
inital (3)
certficate (2)
detemines (2)
annoation (2)
inalid (2)
inconsitencies (2)
initate (2)
kuberenetes (2)
infromers (2)

Kind
/kind cleanup
/kind documentation
Release Note
NONE

/ok-to-test

/approve
/lgtm


Creating a mesh parameters in GravMag inversion

In Gravity and Magnetic 3D Inversion application (v0.9.0-rc.3) there are no parameters for creating a mesh (Mesh option in Inversion Parameters)

Thank you for the information.
However, there are a few questions about OctreeMesh Creation:

Why the application does not recognize 2D grid types in geoh5 (I've imported topo grid in GA)?
Why the mesh saved in new geoh5 (I need to write script to copy the mesh into original file)?

1- Hmm good point about the 2d grid. We just need to add it to the list of accepted objects. That being said, data from a 2d grids don't really have a z position (just flat constant) you might have to also create yourself a points from cell centers with drape Z?
2- No you should just be able to ctrl-c the mesh in GA,   then ctrl-v in your other project. Or second option you just drag and drop the geoh5 that has the mesh to your viewport. GA is pretty cool that way.

Creation points from 2d grid cells available only in Pro license.

Fair enough. Here's a workaround that should work (untested)

Use the export app to create a csv from your 2d grid. This csv will load as Points by default in GA.

Use the data transfer app to interpolate your elevation from dem or topo surface.

Use the calculator app to assign elevation to your points.

From there you will have points and topo to create your octree. Should work...
Dom

Would probably be a good idea to make an app for that - 2d grid to draped points. We could then simplify the inversion app even more and let you do the conversion prior as well.

Will add the option in the jupyter-app only to help out free users on GEOPY-687 for v0.9.1


Documentation issue: ordered/geoJSON on collection.add_geo_index

In the base collection, it seems like the ordered index value is incorrectly documented. According to theArangoDB docs this geoJSON being set to true turns on geoJSON support/indexing. Here in the docstring nothing of the sort is mentioned, and it implies that it has something to do with coordinate ordering.
https://github.com/ArangoDB-Community/python-arango/blob/86411ef40dc22b51a21eccdce8cc179b46d322f1/arango/collection.py#L1169-L1200
It took me way too long to figure out how to turn on geoJSON support because of this.

Thank you for the report @Adrian-at-CrimsonAuzre. Will take a look when my time allows.


"Helegiu", "Brătila", "Deleni", "Drăgugești" are villages in "Helegiu" common, "BACĂU" county

Description : When user is typing the villages in the search bar, the locations should appear in the dropdown menu correctly spelled and with localities information (as in Law nr. 2 din 16 februarie 1968)
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing.
After every step delete the text you typed from the search bar.

Steps 1: Click on the search bar and write Helegiu"
Expected result: In the drop down menu you find "Helegiu, Bacău"

Steps 2: Click on the search bar and write "Brătila"
Expected result: In the drop down menu you find "Brătila, Bacău (Helegiu)"

Steps 3: Click on the search bar and write "Deleni"
Expected result: In the drop down menu you find "Deleni, Bacău (Helegiu)"

Steps 4: Click on the search bar and write "Drăgugești"
Expected result: In the drop down menu you find "Drăgugești, Bacău (Helegiu)"


GPU training and scaling

Obviously 50-60 GPUs simultaneously training for 4 weeks is less than ideal, in that we probably lack access to a cluster with that many GPUs and don't want to wait a month for the training to occur.
My thoughts were that we could preprocess the position samples, upload them and use something like
http://cs.stanford.edu/people/karpathy/convnetjs/
For the training - with people simply going to the site, pressing start, and a batch of games with the current weights for current net is provided to them and it automatically returns the results after the batch finishes.  Perhaps the owner of that site would be willing and interested to help set up the customization.
Then we announce on one the go servers/forums the dates that we plan to use, and people simply pop on to the site when they have some spare time on their computer.  It seems possible that this would allow us to converge far faster.
If there are enough people we could train multiple nets at the same time (There might literally be millions of people interested in donating compute cycles).

We actually have a sizeable computing cluster here at the University of Rochester. We were planning to train the models ourselves and release the trained weights across multiple epochs. We don't have 50-60 GPUs, though, so training time may actually turn out to be an issue.. in which case we'll have to start considering other options like renting time from Amazon/Google.
Correct me if I'm wrong, but it looks liks convnetjs is good for smaller datasets to be trained in-browser, not for networked/distributed training (which is a non-trivial problem in general)

It is designed for smaller datasets to be trained in-browser.  I'm aware of the non trivial nature of networked/distributed training - but the problems are mostly efficiency related I suspect.  If you are willing to 'waste' resources (ie 500 people training being the equivalent of a 40 GPU trained system) then I don't think it is as difficult a problem (trying to see what the literature says on this...).

I found this page very informative: [[https://www.quora.com/What-are-some-distributed-SGD-implementations]]

https://github.com/maxpumperla/elephas
www.ics.uci.edu/~welling/publications/papers/MLinBrowser.pdf

Yes those look very much along the lines of what I was thinking.

It might be interesting to train the networks on different sized games.  Testing and evaluation on smaller games (9x9) should give a lot more certainty as to play quality.

Definitely - we were thinking about testing the pipeline on smaller boards, where other AIs can serve as 'experts' and be used to generate any amount of training data. Nothing in the current state/feature processing/training code really requires 19x19 boards, though it was sort of assumed here. I believe that's the only line that would need to be changed to run the training on smaller games.

Leaving this remark here because it's too similar to open up a distinct issue. I've written the supervised policy training routine in such a way that it will (hopefully) transfer seamlessly to one or more GPUs. I'm planing to get this working on our university computing cluster tonight or tomorrow.

OK I verified that training works on GPU as expected. model.fit_generator() asks how many workers it should use. Is there a way to programmatically estimate a good number of workers? Or do we have to do it manually?


dune: 1.6.2 -> 1.7.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dune/versions.
meta.description for dune is: '"A composable build system"'.
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/nix/store/ac163cyv21lizbfipj1355af0ngw8yra-dune-1.7.3/bin/dune passed the binary check.
/nix/store/ac163cyv21lizbfipj1355af0ngw8yra-dune-1.7.3/bin/jbuilder passed the binary check.
2 of 2 passed binary check by having a zero exit code.
1 of 2 passed binary check by having the new version present in output.
found 1.7.3 with grep in /nix/store/ac163cyv21lizbfipj1355af0ngw8yra-dune-1.7.3
directory tree listing: https://gist.github.com/3c6d38def2227b39dbf2db4af53a1009
du listing: https://gist.github.com/83af0ff6a1ec2370b21e01db90614441

Rebuild report (if merged into master) (click to expand)

86 total rebuild path(s)
24 package rebuild(s)
24 x86_64-linux rebuild(s)
23 i686-linux rebuild(s)
17 x86_64-darwin rebuild(s)
22 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
acgtk
alt-ergo
beluga
dune
eff
flow
fstar
google-drive-ocamlfuse
jackline
libbap
libguestfs
liquidsoap
ocaml-top
ocamlformat
patdiff
pyre
python27Packages.guestfs
python37Packages.guestfs
reason
satysfi
stog
trv
vagrant
virt-top

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ac163cyv21lizbfipj1355af0ngw8yra-dune-1.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A dune https://github.com/r-ryantm/nixpkgs/archive/4cfbe4b6fc2f9a5fcd791ec8a69e1c7929eb79bf.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ac163cyv21lizbfipj1355af0ngw8yra-dune-1.7.3
ls -la /nix/store/ac163cyv21lizbfipj1355af0ngw8yra-dune-1.7.3/bin

cc @vbgl for testing.

@GrahamcOfBorg build ocamlPackages.ocp-index

FWIW ocp-index was fixed upstream https://github.com/OCamlPro/ocp-index/pull/128


second attempt at supplementing aria roles external doc

<a> tags are infinitely more clickable when they include real text.
(and now i understand that your gh-pages source is actually maintained in master)

:+1:


Reset to Rest Pose in Skeleton2D menu fails

Godot version
v3.4.stable.official [206ba70f4]
System information
Windows 10
Issue description
I have rigged a paper doll guy, mapped bones to verts for deformation, and created animations.

In Godot v3.3.4.stable.official [faf3f883d] I can select the Skeleton2D and use the Skeleton2D menu to "Set Bones to Rest Pose." The result looks good. However, in Godot v3.4.stable.official [206ba70f4] this does not work as expected.

When I select "Reset to Rest Pose" in the newer version, the Polygon2D assets return to rest pose, however the bones do not. This seems to scramble the mapping of verts to bones for all animations.

Steps to reproduce

Load a Skeleton that has been mapped to Polygon2Ds authored in v3.3.4.stable.official [faf3f883d]
Select the Skeleton2D
Use the Skeleton2D menu to "reset to rest pose"

Observe: Polygon2Ds correctly return to rest pose, bones do not.

Try to play an animation

Observe: Now that bones have new offsets animations no longer look correct.
Minimal reproduction project
RestPoseBug.zip

@irslutz  Can you reproduce this in any of the 3.4 betas and RCs to determine when the regression started?

@Calinou I did a little bracketing for the test case. Beta2~beta4 seemed good, the first reproduction of the bug was beta 5.

See this change in beta 5: https://github.com/godotengine/godot/commit/de3f454c27c4598961583b2ac86b67a159478ee6
That's only a rename, maybe that's the source of confusion? The 3.4 equivalent of "Set Bones to Rest Pose" is "Overwrite Rest Pose".

OK @akien-mga is correct, functionality between the two options is consistent.

"Make Rest Pose (From Bones)" has become "Reset to Rest Pose"
"Set Bones to Rest Pose" has become "Overwrite Rest Pose"

In each case the new label provides identical functionality. But it seems that those two labels should be switched, at least in English.

The button texts were tweaked in https://github.com/godotengine/godot/pull/52317 following the advice from https://github.com/godotengine/godot/issues/28124.
@bitbutter Did I get them the wrong way around? I don't really understand right now.

It looks like that suggestion was to change words and order. The words have changed but the order is the same.

@Calinou I have tried to illustrate what it appears the request from #28124

It appears that the functionality that was tied to Make Rest Pose (From Bones) should have the text Overwrite Rest Pose and be put in the lower position. The functionality tied to Set Bones to Rest Pose should be matched to the text Reset to Rest Pose and be in the upper position.
The text is in the correct position, but the functionality is reversed.
I hope this is helpful.

OK @akien-mga is correct, functionality between the two options is consistent.

"Make Rest Pose (From Bones)" has become "Reset to Rest Pose"
"Set Bones to Rest Pose" has become "Overwrite Rest Pose"

In each case the new label provides identical functionality. But it seems that those two labels should be switched, at least in English.
I notice current documentation uses old terms.

I can't agree more, this labeling is very confusing.

I notice current documentation uses old terms.

Can you point to the documentation which still uses the old terms?


kindly merge the PR which solves the issue of config not found

@msonowal The bug looks very obvious, could you share the error output please.

This is the error because config variable is not defined,
so, in the PR I have added it var config = Elixir.config; on line 12 which solves the purpose

I would also appreciate this fix in upstream. I don't like to patch the vendors myself to get something working...


QUESTION: Is this compatible with Apple Remote Desktop?

Just wondering if this is compatible with Apple Remote Desktop? I can't seem to get the mas commands to work properly when I push a unix command via ARD.

Unfortunately I haven't got any experience with ARD so I don't have an answer at this point. I think some other people have tried so perhaps they will have some comments.

Thanks for the quick response. I will post what error I receive and hopefully someone knows what I have to do. Would really like to get this up and running. We manage over 100 Imacs and there's no easy way to just update the App store stuff without going into the computers individually.

You need to specify a full path to mas since in this case the environment doing the "Send UNIX Command" doesn't include /usr/local/bin in its default PATH. So use /usr/local/bin/mas.

That worked! now one other thing. I am trying to run the signin command but i keep getting error(7)null. Any idea what that might be?
Thanks again!

If the 7 is coming from the app that is the AlreadySignedIn error code: https://github.com/argon/mas/blob/master/mas-cli/Error.swift#L21

Hi, I don't think I am already signed in though. When I run the mas install command I can see on my test computer that it brings up the Apple ID sign in.

If you open the App Store on the test machine and check the Store menu you will probably find you are signed in. Sometimes install will prompt for password if you signed in a long time ago.
If you run mas signout followed by mas signin then try to install does it still bring up the prompt?

On 27 Apr 2016, at 18:13, bkrivelow<EMAIL_ADDRESS>wrote:
Hi, I don't think I am already signed in though. When I run the mas install command I can see on my test computer that it brings up the Apple ID sign in.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub https://github.com/argon/mas/issues/25#issuecomment-215153057

Yes the sign in to download from app store prompt still comes up even after doing the signout and signin command. I do notice though that I do not get the signing into app store line in terminal but it doesnt kick back an error.

If you're still having this problem could you please try with a newer version?


some improvements

Currently im porting an existing QT App to guy.
First, it's a great concept, neverthe less I want to suggest some improvements I've built in now into guy.py, but I want to explain and discuss why I did so, before making a change request.
As far as I understand the code,  (async) def init  is executed for every connecting client (means one time if running in CEF or App mode, once for every browser tab in SERVE mode.
What I'm missing is a kindof "cleanup" equivalent to init.
so I changed on_ close in WebSocketHandler the following way:
    def on_close(self):
        try:
            current=WebSocketHandler.clients[self]
            logger.debug("Disconnect %s",current._id)
            async def doCleanUp( instance ):
                cleanup=instance._getRoutage("cleanup")
                if cleanup:
                    if asyncio.iscoroutinefunction( cleanup ):
                        await instance(self,"cleanup")
                    else:
                        instance(self,"cleanup")

            asyncio.ensure_future(doCleanUp(current))
            del WebSocketHandler.clients[self]
        except KeyError:
            pass

The check for the KeyError is cleaner in my eyes, to avoid ugly logger entries when closing an "old" browser tab in SERVE MODE.
The next thing I changed is:
class WebServer(Thread): # the webserver is ran on a separated thread
    port = 39000
    def __init__(self,instance,host="localhost",port=None,autoreload=False):

            ......
            ......
           self.instance._webserver=(self.host,self.port)
           self.instance._tornado = self
           .......
           .......

I need the tornado instance, or better said it's event loop,  to pass it over to a AsyncIOMotorClient instance for being able to use the async emit or emitMe methods when something happens inside a db changestream.
But I can imagine, it is useful generally if something from "outside" happens which has to be emitted to the client.
So it is for example possible to initiate the AsyncDB Connection like this in the GUY App:
async def init(self):
     if Classname.DBAsync is None:  # that's a static thing
         Classname.DBAsync = AsyncConnection(f"mongodb://{self.host}:{self.port}",io_loop = self._tornado.loop)
     await self.js.start()

Please let me know what you think,
best
Robert

hi

Currently im porting an existing QT App to guy.

Perhaps .. You should have a look to gtag (currently, it's a separated lib, but in a near future, gtag will be included in guy) : its a layer, on top of guy, to (really) easily make a GUI (in a more classical way). It should be a lot easier to migrate a qt app in a guy way.

What I'm missing is a kindof "cleanup" equivalent to init.

yes, you've right ... it can be very useful to close up some things !!!
(the way you implemented fit well with the logic)

I need the tornado instance, or better said it's event loop
I can understand the need ! no trouble!

Please let me know what you think,
it's good for me

Ok, the pull request is done.
I also added a afterServerStarted event which passes the webserver instance as well as the app instance back.
Nevertheless i kept the _tornado attribute, since I found out, that in app and cef mode, init happens before.
Whenever you need the eventloop, you need to have access to it at this moment.
One big please:  Could you disable (or make it interuptable by a flag or somewhat else ) guy.exit() when sunning in server mode?
This is a huge issue in my eyes.
BTW.
I had a look ad gtag already before i began. Although it's nice, but it is not an option for me. My GUI is rather complex, so I do this with the great webix  library.

sorry for the long delay
PR is merged !


Update documentation about installation of toolchain

Do I need to delete the branch or do you keep them in case if ?

For small stuff like this you can delete the branch directly !
Le 24 févr. 2016 9:47 PM, "Alexandre Cherpillod"<EMAIL_ADDRESS>a écrit :

Do I need to delete the branch or do you keep them in case if ?
—
Reply to this email directly or view it on GitHub
https://github.com/lis-epfl/MAVRIC_Library/pull/181#issuecomment-188448009
.


What about Pretty-J1939 ?

Hello iDoka, Great list very useful !
What about Pretty-J1939 ?
https://github.com/nmfta-repo/pretty_j1939

Hello Tuthmosis,
I'll add it and want to say thank you for your contributing.


Updated clean_old_versions.py and mention it in README

As I was using script clean_old_versions.py, I've made small improvements in it,
added working tags version sorting, made all parameters configurable from cli.
Also, I've added small section about this script in README.

again, thanks, @abulimov !


added the docker file to front end and fixed the package.json for docker

This PR contains very few changes related to dockerizing the the frontEnd Application:
Here are changes list:

Added Dockerfile to the frontend
Fixed the material UI React CSS pack to latest version its been renamed as mui/systems instead of mui/styles (NOTE: This change could impact that some doms might not render, could be a simple fix if we can look up the documentation).

Why did I renamed the mui/systems instead of mui/styles?

Because the mui/styles was depricated here is the changelog we can refer from https://mui.com/system/styles/basics/

Why did I renamed the mui/systems instead of mui/styles?

It's great that you updated mui/styles. Can you confirm it's not breaking the UI rendering?

I did check it, With the current state of UI its not breaking, but might break in future we need to put an eye on the functionality when we are testing end to end on console we can see and fix them if we encounter any, But as of now its not breaking


Fix typo in balance strategy range documentation

@ppizarro thanks! This was actually also spotted by @maksadbek and fixed under https://github.com/IBM/sarama/pull/2657, I just hadn't gotten around to reviewing and merging yet. Should now be fixed on main. Thanks to both for catching this problem 🙏🏻


Custom widgets for cells

The grid is awesome, but it has a lack of functionality: it works only with texts and can not diaplay more complex data.
For example, my rest api returns me user profiles with avatars, so I have url string but i shouldn't show actually strings im my table.

this is example of expected behavior.
Such widgets should not be editable, at least this behavior should not be handled by the grid.
Example, how this works on application side:
PlutoColumnType.widget(widget: (dynamic value) {
  if (value != null) {
    return Image.network(value, fit: BoxFit.scaleDown);
  }
  return Icon(Icons.image_not_supported_outlined);
})

Of couse, displaying user's images is not only one potentional use-case.
My solution still is a bit tricky, because class _CustomCellWidgetState extends directly _DefaultCellWidgetState instead State. I think, it should be fixed by converting a part of _DefaultCellWidgetState into mixin to share it's functionality.

Thanks for the first contribution. Let me apply this.

I've been thinking for a long time whether or not to add the CustomeWidget you suggested.
I have added enableEditingMode to the PlutoColumn property.
If you set enableEditingMode to false and have the renderer return an Image widget, I think this might be similar to what you want.
Added to version 1.0.0-pre.5.
I didn't merge your PR, but it helped me a lot.
Previous PRs have also helped a lot. Thank you again.
P.s. I want to add your profile to Contributors at the bottom of the Demo page.

Great news! I've just checked new beta and I think that it's implementation is much better than my PR.  But I often prefer to show an example of solution than just leave an issue with feature request and no code at all :-)
P.s. about my profile in Contributors - thanks, it would be nice!

Does someone have a complete example of fitting or scaling a an image to fit within a PlutoCell?


[BUG] Can't install on Ubuntu

Describe the bug
I've installed Rust just to try this package, so I'm not experienced with it. I'm not being able to install it on Ubuntu.
To Reproduce
Steps to reproduce the behavior:
cargo install tplay
  --- stderr
  thread 'main' panicked at /home/micael/.cargo/registry/src/index.crates.io-6f17d22bba15001f/alsa-sys-0.3.1/build.rs:13:18:
  `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" PKG_CONFIG_ALLOW_SYSTEM_LIBS="1" "pkg-config" "--libs" "--cflags" "alsa"` did not exit successfully: exit status: 1
  error: could not find system library 'alsa' required by the 'alsa-sys' crate

  --- stderr
  Package alsa was not found in the pkg-config search path.
  Perhaps you should add the directory containing `alsa.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'alsa', required by 'virtual:world', not found

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile `tplay v0.4.5`, intermediate artifacts can be found at `/tmp/cargo-installf3bw3c`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

cargo install tplay --features="mpv_0_35" --no-default-features
  --- stderr
  thread 'main' panicked at /home/micael/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ffmpeg-sys-next-6.0.1/build.rs:715:14:
  called `Result::unwrap()` on an `Err` value: `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" PKG_CONFIG_ALLOW_SYSTEM_LIBS="1" "pkg-config" "--libs" "--cflags" "libavutil"` did not exit successfully: exit status: 1
  error: could not find system library 'libavutil' required by the 'ffmpeg-sys-next' crate

  --- stderr
  Package libavutil was not found in the pkg-config search path.
  Perhaps you should add the directory containing `libavutil.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'libavutil', required by 'virtual:world', not found

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile `tplay v0.4.5`, intermediate artifacts can be found at `/tmp/cargo-install0jgH9U`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Expected behavior
It should be possible to install it.
Desktop (please complete the following information):

OS: Ubuntu 23.10
tplay  --version: Couldn't install
yt-dlp --version: Not installed
mpv --version: Not installed
rustc --version: rustc 1.74.0 (79e9716c9 2023-11-13)
pkg-config --modversion opencv4: Not installed
ffmpeg -version: Not installed

Oh, I think I just needed to install the dependencies first. I thought they were just for development, and that for end users they would be automatically installed, or something like that. My bad.


Out-DbaDataTable null value from pipeline handling

Fixes #892
Changes proposed in this pull request:

Added AloowNull() metadata tag and an if to catch nulls instead.

How to test this code:

[ ] $dbatools |  Out-DbaDataTable
[ ] then populate $dbatools so it's not null and test again.

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

Appveyor tests are lying, ignore them! Thanks for the fix, @SirCaptainMitch!


Added a chart & other misc. changes

Chart view, some icons for the context menus and a yes/no confirmation when removing paths.


add worker group config

add worker group config and comment no needed worker.properties

Codecov Report

Merging #2681 into dev-1.3.0 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-1.3.0    #2681   +/-   ##
============================================
  Coverage        36.13%   36.13%
  Complexity        2468     2468
============================================
  Files              431      431
  Lines            19856    19856
  Branches          2419     2419
============================================
  Hits              7174     7174
  Misses           12037    12037
  Partials           645      645

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f1e83...43f1e83. Read the comment docs.


style(overlay): :sparkles: added queryParams to Team Info

Pushed from my laptop this time @Manokii pls code review thanks!