How may I hide a week if locked, and then show it when unlocked?

Describe your problem here.
For a mod I'm creating, I need to hide some weeks and then show them on their unlock. Also, I would need to hide some Freeplay levels if their week is locked, and then show them when unlocked.
Additionally, if you could help me to do so in Freeplay, but when their week is completed instead of just unlocked, I would be glad. :)
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I edited PlayState.hx, StoryMenuState.hx, WeekData.hx, and WeekEditorState.hx trying to do it by myself.

I added the wrong label. Creating new issue with the correct label...

@XtraXD1 you should probably close this one

ok

nobody respond ;-;

balls
On Thu, Apr 27, 2023 at 12:30 PM Noel345 @.***> wrote:

nobody respond ;-;
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/1327#issuecomment-1526143163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7OIQJ6Z4XKMSJJPE4BGS23XDK3K5ANCNFSM5IWXHGUQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
**Disclaimer: This message and any attachments are intended for the use of
the addresses(s) only and may be confidential and/or legally privileged. If
the reader is not the intended recipient, DO NOT READ, notify sender and
delete this message. In addition, be aware that any disclosure, copying,
distribution or use of the contents of this message is strictly prohibited.
The contents of this message, while possibly falling under the exceptions
of the Inspection of Public Records ACT [NMSA Chapter 14, Article2] may be
subject to inspection by the public.


Can't access data in App Extension after converting to RealmSwift

I have rewritten my ObjC code to Swift and also started using RealmSwift. In my app I can access Realm object without any problem. But in App Extension (Today widget) I'm always getting 0 results (using same code from shared class).
I was checking App Groups settings for both app and extension, also path for Realm configuration is the same.
Anyone having similar issue? Or is there any tutorial/example how to use RealmSwift in Swift2.0 with App Extension?

Do you set the path for your Realm file for both targets also into the App Group as seen in our Tutorial: Sharing Data between WatchKit & your App, with Realm?

For both targets I'm setting the path this way:
let container = NSFileManager.defaultManager().containerURLForSecurityApplicationGroupIdentifier("group.com.martinpilch.test")
let realmURL = container!.URLByAppendingPathComponent("default.realm")
var config = Realm.Configuration()
config.path = realmURL.path
Realm.Configuration.defaultConfiguration = config

That looks fine. Do you really write that in ypur app after ypu setup the configuration? When do you check in your app extension the number of results. If you reset the database file in development on every launch, it could be necessary that you would need to usewrite notifications to sync the processes. If that shouldn't be the case, could you try to extract the user data and ensure that there Is at least one realm file containing the expected data? (Not sure though, how or whether that's actually possible for app extension data.)

I finally found solution @mrackwitz ! I was using different code for migration. Working version looks like this:
let container = NSFileManager.defaultManager().containerURLForSecurityApplicationGroupIdentifier("group.com.martinpilch.test")
let realmURL = container!.URLByAppendingPathComponent("default.realm")
var config = Realm.Configuration()
config.path = realmURL.path
config.schemaVersion = 3
config.migrationBlock = { migration, oldSchemaVersion in
    if (oldSchemaVersion < 3) {

    }
}
Realm.Configuration.defaultConfiguration = config
let _ = try! Realm()

The most important part is let _ = try! Realm() which was missing for widget. You can mark it as closed, now it's solved for me. Thank you for your time!

Okay, that makes sense. Thanks for reporting back. Be aware though that if you not hold anymore a strong reference to your Realm from a thread, that the cached weak accessor will be cleared as well and you pay a little extra cost next time when you access the Realm. So it might make more sense to pass on the reference which you get by your last call.

Hi Everyone I have a similar issue in this ticket, I tried all was written here, but it does not work either, any please help?


Typo in definition of TLWE key

Hi, I was reading through the implementation of the code, and I believe that there is an off by one error in the SizeData method for a TLWE key. As far as I understand, this should be size of Binary times degree of the polynomials (n) times the number of elements of the secret key vector (k). (k+1) would be referring to the TLWE sample size (T_N[X]^k, T_N[X]).
https://github.com/vernamlab/cuFHE/blob/1af2f2be596e66fcc14f5659d8a89432fe53d41f/cufhe/include/cufhe_core.h#L162
Part of this is just to confirm my understanding of the code, as I'm sure this is not so serious and is probably only used in size calculations!

Hello, @asraa. I'm the writer of the forked version
I agree with you. This should be sizeof(T) * this->n_ * this->k_.


Track updates and swaps in FixedRateExchange

Neither updates or swaps are tracked in FixedRateExchange

what do you mean ? example

Yeah seems to be working. Always seems to be null in the tests but I'll look into that more


[FEATURE]: monkeys workflow editor

Describe the Feature Request
After examining several open-source AI workflow projects, I found that the interaction and design of monkeys are currently the most user-friendly. However, after studying the code of monkeys' workflow editor UI, I found it a bit difficult to detach. May I ask, will the editor part be separated in the future to become a new project?
Describe Alternatives
sequential-workflow-editor

This is a task we plan to undertake, but we don't have a specific timeline at the moment. If you are interested in participating, we would like to invite you to join us in completing this work.

How can I participate in this work? Or should I say learning, as I am still a beginner in front-end development.


Step 1 does not explain how to get the secret

Step 3 says we need a client secret. But the previous steps do not explain how to generate it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85b1fba4-870b-1602-0d4f-6f50bdbfc370
Version Independent ID: 93873b36-5f27-bd06-df23-804c38f21b37
Content: Azure AD Node.js web app getting started
Content Source: articles/active-directory/develop/active-directory-devquickstarts-openidconnect-nodejs.md
Service: active-directory
Product: unspecified
GitHub Login: @CelesteDG
Microsoft Alias: celested

@tomconte Thanks for your feedback! We will investigate and update as appropriate.

Hello @tomconte - I looked at the config.js file (from the GitHub sample) and in the exports.creds section it notes to put the clientSecret if you are doing code or id_token code. I found this article, https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-create-service-principal-portal#get-application-id-and-authentication-key, which I think shows how to generate the clientSecret (or authentication key). I think step 5 of that "Get application ID and authentication key", where you get the key value, is the clientSecret.
Hello @navyasric - Can you please confirm if the info I have above is correct? If so, I can update the topic to include a note about the clientSecret and how it's the same as the authentication key value.

Hi @CelesteDG Yes the article is missing the step to create a key in the register your app section.
The client secret here is the application key. You can find the step to create an application key here: https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-integrating-applications#to-add-application-credentials-or-permissions-to-access-web-apis

Thank you, @navyasric - Can you please review the new step 8 here: https://review.docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-devquickstarts-openidconnect-nodejs?branch=pr-en-us-41858#step-1-register-an-app - I added that step 3 (in the register your app section) based on your feedback. Please let me know if you have any suggested tweaks. I will sign off once I have your approval. Thank you.

Thanks @CelesteDG . Looks good to me.

Thank you very much for the input, @navyasric  I'll sign off on the PR.

Thanks everyone for your answers!

Hello @SaurabhSharma-MSFT - #please-close this issue. The update is live. Thank you.

@tomconte We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Add architectural support for shared interrupts

This series of patches introduces architectural support for shared interrupts.
This works by keeping track of all of the ISR/arg pairs passed to z_isr_install() and calling
them in our own "dummy" ISR.
In theory, this patch series shouldn't affect the current architecture as this is an opt-in option and the series only contains additions and no modifications of current code.
Currently, there's a weird dependency on the ARM64 architecture. This is because I was only able to test this change on said architecture.
For the associated issue please see: https://github.com/zephyrproject-rtos/zephyr/issues/61278.

@andyross TYVM for all of your input !
Currently, I'm taking a look at https://github.com/zephyrproject-rtos/zephyr/pull/57146. I'm going to try to find a way to allow us to make use of the shared interrupts feature using IRQ_CONNECT() as well. I'm thinking a combination of this patch (which handles the shared interrupts "dynamically" ) and the one I've mentioned above (which handles the shared interrupts "statically"). When I have something somewhat decent I will submit a PR as an alternative to this one.
If that doesn't work, I'll come back to this PR and address all of your suggestions.
As I'm going to be away starting from next week, this might take a while :( (ETA 2 weeks or so).

Feature implemented in https://github.com/zephyrproject-rtos/zephyr/pull/61422.


bug: github CI failing due to starknet-js

Bug Report
Madara version:
Latest version on main

Current behavior:
The github ci tests are failing specifically due to the starknet-js tests failing.
Here are the specific logs: https://github.com/keep-starknet-strange/madara/issues/1549#issuecomment-2043547828
This is the specific repo at fault, https://github.com/keep-starknet-strange/sequencer-js-compatibility-tests

Expected behavior:
All tests should pass

Steps to reproduce:
Create a pull request and view the logs.

Hi @hhamud, can I try this out?
Though the logs is not displaying from my end

@princeibs I can't assign anything but I am fine with you doing this. you would need to ask @apoorvsadana or @tdelabro for it to be assigned to via github.
Also here is the log as a file.txt: 13_Run starknet-js compatibility tests _ test.txt
and this is the specific github workflow file that is used. https://github.com/keep-starknet-strange/madara/blob/main/.github/workflows/starknet-js-tests.yml

Alright sure. Will hop on it 🚀

@apoorvsadana @tdelabro
Can you assign me please?

Sure @princeibs, assigned to you.

@princeibs any news on this one?

Facing a blocker with when starting up madara.
Running this command cargo run --release -- --dev throws the error below:

@tdelabro

repository archived in favor of https://github.com/madara-alliance/madara


Implement functionality

Now that you have created all MVC components, you may begin implementing functionalities. For each functionality,

add a route in the route module, and add the corresponding controller function in the controller module. Implement the controller function to just send a simple message.
test to make sure that a request can be routed to the route handler, which calls the corresponding controller function. Fix any error that may arise
replace the simple message by implementing necessary logic in controller function/model/view templates. Keep in mind that this differs from request to request.

For some requests, such as viewing the landing page, the controller function needs to render the corresponding view template, nothing else.
For some requests,  it is more complicated. For example, to show event details, the controller function needs to query the model to retrieve the event object,  pass it to the corresponding view template, and render the view template. This requires you to add functionality to the model and the controller function. Further,  you also need to update the corresponding view template to replace all of the static placeholder information with dynamic data. In addition, this process can also go in the other direction. For example, to create a new event, the controller function needs to retrieve user input from the request object, queries the model to add data to the array, and redirect the browser accordingly.

Begin by implementing the functionalities associated with general site navigation.

user is able to view the landing page
user is able to view the contact page
user is able to view the about page

Next, implement the functionalities associated with events.

user is able to view all events sorted by category
user is able to view the details of an event
user is able to view the new event page
user is able to create a new event
user is able to view the edit event page
user is able to edit an event
user is able to delete an event

Here are some additional hints regarding implementing some of these functions:
Sort events by categories: The events view should display all events sorted by category. Your app should handle this dynamically.  In other words, if you add another event with a new category, the application will be able to handle that without having to update or change any code.
There are different ways to implement this. One way to implement it is as follows:

In the model, implement a function to return all events and implement a function to return all distinct categories.
In the controller function, call model functions to get all events and get all distinct categories and pass them to the view template
In the view template, iterate through the distinct categories, for each category, display the events of that category.

You may find it is easy to use array iteration methods, such as foreach, filter, and map to implement these functionalities.
Event detail: all event field must present except the id field. You may choose any format for the start/end fields, and they do not need to be exactly the same as what I had in the demo.
Create a new event: you will need to implement functionalities to support file uploading, please refer to the file uploading tutorial.
Edit event: On the edit event page, make sure that all fields in the form other than the image are pre-filled with event details. If the start/end date/time fields are not populated, check the format of the start/end property of the event in the model. Make sure that the value of the property is a string of yyyy-mm-ddTmm:ss.

event details complete, except for file uploads and sorting
user is able to view landing page

sorting events by category method added
button added to required ejs files


Added support for multiple series in WithAutorange option.

hi @erkkah ,
I'm using Margaid often with multiple plots sharing the Y-axis, and I'm having to manually set the range to the max/min of all of them.
So I thought instead an idea would be to extend WithAutorange to support as input not only one series, but various.
It's a very simple changed, so I wrote the PR here directly -- it doesn't break compatibility with previous code (with maybe some very odd exception).
Let me know if that works for you. If you prefer I could create also another type of option.
cheers

For the same use case of supporting multiple plots sharing the Y-Axis, I noticed that the legends were not appearing in the bottom -- because there was not enough space in the inset. But growing the inset space would also grow on the top/left/right, so not very practical.
So I added a change that automatically grows the SVG size to provide space in the bottom for the legends, when they are created in the bottom position.
The PR is small, but it does expose some of the underlying Brackets representation -- so maybe you will not want it. Let me know, maybe you have a better idea on how to do it ? (if you want the change at all)
cheers
A snapshot of my use case:

Hi. Thanks a lot for the PR! In the middle of something else, but will look into it in a couple of days.

No worries, thank you for writing the library! And no hurry.

hi @erkkah , I was wondering if you would have a chance to review the PR ?
On a separate topic, I was wondering what are your thoughts on adding a mouse-over the points to display their values, using something like this. Maybe showing the values on a line at the bottom of the plot ?

On a separate topic, I was wondering what are your thoughts on adding a mouse-over the points to display their values, using something like this. Maybe showing the values on a line at the bottom of the plot ?

I think that would be a great addition. Especially if it can be done in CSS and as an option. I have limited time to work on that now, but as you know, PRs are welcome!

Btw, would it be ok to create a new release tag ? (0.3.0?)

Oops. I tagged it, but forgot to make a release. Will do!


businessID should be of a type string (uuid)

When I pass MDA a setting that contains businessID as a uuid string,  I get
{"detail":[{"loc":["body","businessID"],"msg":"value is not a valid integer","type":"type_error.integer"}]}

To my understanding, businessID is the transaction_uuid of the ISSM flow which is in a uuid format as indicated by the examples below:
6cc52f2c24ff4e4c901d49ee701b8223, c907cedc-5fd3-47a9-9188-6e6bc401d870
Thanks.

Yes, you are completely right, this error had been previously detected, and will be corrected asap when we update the current version of the MDA. Thank you @aviweit!


Azure Blob File copy fails to upload to $web container

AzCopy Job fails to upload files to container with name $web. Below are the details:

Error Log:

@chandanch Have you given required permissions i.e. storage blob contributor/ storage blob owner to your SPN ?
Please check this doc once : https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-v10#option-1-use-azure-active-directory

@chandanch Any update here?

Closing it, please feel free to reopen if you have any other query


Paddy stops working with Symbols within a symbol. Sketch 49.3

This is an issue template.
Please fill in the relevant fields – whether this is a Feature request or a Bug report
Remove any sections that are not relevant to you.

Bug report
Expected behavior:
When creating a nested symbol with symbols, the nested symbols with paddy on them stop working on the overrides.
Actual behavior:
(Please include a screenshot or screen recording if possible)

Steps to reproduce:
(Please attach a Sketch file if possible)

We have got this problem too!

+1

Same issue -I've began creating a design system for a live chat and all my templates are basically useless

Me too =/


Issue while connecting to remote docker socket

Describe the bug
I am using a VPN and have exposed the docker socket over this VPN. This way I can set the DOCKER_HOST variable to my Server's VPN IP and control docker from there.
However when using lazydocker it cannot connect and throw an error
To Reproduce
Expose a docker socket on the network and try connecting only with the IP
Expected behaviour
As long as docker ps works I would expect lazydocker to work as well.
Screenshots

Desktop (please complete the following information):

OS: Archlinux
Lazydocker Version 0.23.1

The issue comes from the docker go client. Not lazydocker, it seems my issue can be closed.


Add pygame and user interface to Hangman game

Currently Hangman can only be played in terminal, pygame module needs to be added in it.

I would like to work on this issue.
Does this issue fall under hacktoberfest?

Sure, you can work on this.

please assign it to me


fix(rpc): disallow duplicated rpc path

What this PR does / why we need it:
Prevent users from setting duplicated RRC path by mistake.
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @iawia002

Release note:

NONE

Thanks!
/lgtm
/cherrypick release-0.3


Slight question and issue.

Whenever I sometimes leave my avatar's project it'll completely corrupt my toggles and Ill have to redo them, if Im doing something wrong please let me know!
Along with that, is inventory inventor broken with the new VRChat update? If so will there be an update soon to fix it because when updating my avatars to physbones they were not very cooperative with the toggles; the toggles decided to just not work in general.
Please let me know thank you.

Inventory Inventory is entirely compatible with the Physbones update, so I'm not quite sure why your toggles would be misbehaving or corrupting. Could you delete Inventor from your project and reimport it to see if the issue persists?

Inventory Inventory is entirely compatible with the Physbones update, so I'm not quite sure why your toggles would be misbehaving or corrupting. Could you delete Inventor from your project and reimport it to see if the issue persists?

Im going to be trying to use it in unity and hopefully it will work!


Chapter on Relations suggests that it is the first time it's using the where clause, but it has been used before.

In part 1, Relations, after introducing the with clause inside ≤-total, the book shows the same proof  ≤-total′  written with where clause; Then it says that it's the first time that we are using a where clause and explains it. When in fact,  in the second chapter, +-assoc-2 it had already been used twice.

The easiest fix is perhaps to simply remove the where clauses in +-assoc. Each of those definitions can easily stand alone as a top-level definition.


Parse Typescript annotations in template expressions

Vue's toolchain (vite/vue-loader) have recently added support for Typescript annotations in template expressions:
<template>
  <q-input
    debounce="250"
    outlined
    clearable
    :model-value="item"
    @update:model-value="(val: string) => updateItem(idx, val)"
  />
<template>

This can compile and run just fine with vite/webpack but eslint is reporting an error in VSCode because its parser does not seem to support Typescript annotations in expressions yet

Is it possible to extend this parser (used by eslint-plugin-vue) to also parse Typescript annotations in expressions?

You need to specify  "@typescript-eslint/parser" in parserOptions.parser.
https://github.com/vuejs/vue-eslint-parser#parseroptionsparser

This seems to be an issue with eslint's VSCode extension. I did not notice until now that eslint already processes this just fine from the command line


Link to Saleor Dashboard (admin area) demo for README

This is small thing, but it's very important for newbies

Codecov Report

Merging #1098 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   63.67%   63.65%   -0.02%
==========================================
  Files         106      106
  Lines        5869     5869
  Branches      729      729
==========================================
- Hits         3737     3736       -1
  Misses       1994     1994
- Partials      138      139       +1

Impacted Files
Coverage Δ

saleor/core/utils/random_data.py
83.59% <0%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bf520...30d1bc9. Read the comment docs.

Thank you! ✨


Add meeting notes from September

:books: Documentation preview :books:: https://docs-community--86.org.readthedocs.build/en/86/

Can a RTD admin rebuild 22028772?

Thanks @egeakman!
A


XSS when hydrating component

Elderjs newbie here. Not sure, but assume that this, or a similar approach is a realistic use-case. Where able to do an XSS injection by exploiting the hydration mechanism.
route.js
module.exports = {
  data: {
    test: "</script><script>alert('Yo!')</script>",
  },
  all: () => [],
  permalink: '/:slug/',
};

Blog.svelte
<script>
  import MyComponent from '../../components/MyComponent.svelte';
  export let data;
</script>

<MyComponent hydrate-client={{ data: data.test }} />

MyComponent.svelte
<script>
  export let data;
</script>

{data}

Loading the Blog page executes alert('Yo!').
Reported a similar issue in SvelteKit some months back https://github.com/sveltejs/kit/issues/721

@valterkraemer Yep, 100% an XSS issue. The docs include this warning:

Security Note: Whatever you pass to hydrate-client will get written to the HTML shipped to the browser via JSON.stringify. There are XSS and security considerations of passing data to the client, only hydrate content you trust.

I don't imagine it being too complex to escape it if we wanted to make that less of a concern.

Oh okay, thanks @nickreese. Yeah, at least how they fixed it in SvelteKit seems to be pretty straight forward https://github.com/sveltejs/kit/pull/769


Cs row

cs-index is not a directive but component up to now and it is divided into four other components.
The hierarchy:
cs-index
cs-filter-row
cs-table-container
cs-table-header
cs-table-row

@bence-nagy the branch is ready to merge


es5 support

Please support es5, like Google dart async/await in the browser.

Do you mean async/await for ES5, or do you mean ES5 in general?

For es5, typescript async/await which transpiles to existing es5.
On Sunday, October 11, 2015, Daniel Rosenwasser<EMAIL_ADDRESS>wrote:

Do you mean async/await for ES5, or do you mean ES5 in general?
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/5211#issuecomment-147235568
.

The status of this is well covered on #1664.  This is a dupe.

This will be implemented in #1564

Implementation of this feature has been declined as mentioned in #3975 and #10307

What do you mean with declined?
https://github.com/Microsoft/TypeScript/pull/9175 says it is implemented and it is still on the Roadmap

Indeed, I was confused by this chain of issues. You might also look at #11725


werf dismiss and werf helm uninstall do not remove the release version resources if there is a Job with "helm.sh/hook: pre-delete"

Before proceeding

[X] I didn't find a similar issue

Version
v1.2.321
How to reproduce
In any chart, add Job with annotation "helm.sh/hook: pre-delete", run werf dismiss or werf helm uninstall
Result
Common problem: the release version resources is not removed with either dismiss or helm uninstall, secret with the release (i.e. the release itself) is deleted, but its resources are not.
If helm release has only one version, resources is not uninstalled at all.
If there are two or more versions, the resources of previous versions are deleted, but the last one remains (a release can be deleted in its entirety, in which case resources from the last version are not counted, but I haven't checked what happens if there are new resources in the new version of release).
Expected result
The release has been deleted completely with all resources
Additional information
The problem is that when pre-delete hooks are executed, the release is set Phase = hooks-pre, which causes the phase to be considered not started in the Calculate() function (link to switch case) of the resources to delete and its resources are not included in the general deletion list.
If there are no pre-delete hooks, then the release phase status before Calculate() is hooks-post and everything works fine.
The solution to this problem may be the following code after pre-delete hooks are executed:
    if *rel.Info.LastPhase == release.PhaseHooksPre {
        *rel.Info.LastPhase = release.PhaseHooksPost
    }

This same bug is repeated in werf v2, but I haven't checked it in the code and it requires additional confirmation.

I confirmed this problem also exists in v.2.7.1


Upgrade dependencies and replace deprecated or unmaintained packages

This PR upgrades all devDependencies to the latest versions and replaces packages that are deprecated or unmaintained.
Specifically,
PhantomJS --> puppeteer
extract-text-webpack-plugin --> mini-css-extract-plugin
babel-plugin-__coverage__ --> babel-plugin-istanbul

Codecov Report

Merging #86 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   78.76%   78.84%   +0.07%
==========================================
  Files           7        7
  Lines         146      156      +10
  Branches       24       24
==========================================
+ Hits          115      123       +8
- Misses         30       32       +2
  Partials        1        1

Impacted Files
Coverage Δ

src/Rule.jsx
100% <0%> (ø)
:arrow_up:

src/controls/ValueSelector.jsx
100% <0%> (ø)
:arrow_up:

src/controls/ValueEditor.jsx
100% <0%> (ø)
:arrow_up:

src/controls/ActionElement.jsx
100% <0%> (ø)
:arrow_up:

src/RuleGroup.jsx
100% <0%> (ø)
:arrow_up:

src/QueryBuilder.jsx
62.5% <0%> (+0.3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db9d7e...ff21f46. Read the comment docs.


Add destaggering functionality

Change Summary

This is an updated version of #37 to handle de-staggering in all three dimensions and in a (hopefully, still needs to be tested) dask-friendly way.
Currently a draft PR to get eyes on my implementation right away; will be working on tests, documentation updates, and cleaning up the type hints later today.
Related issue number

Closes #35
Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable

I think it would be nice to support destaggering multiple dimensions at once. Couldn't we just recursively call _destagger_variable for a single dim?

You're right, I was originally thinking about maybe finding some variables staggered in z and one of the x or y dimensions, but it seems that this doesn't occur (at least in output data). So nevermind! :D

While this doesn't add direct tests with dask (deferring to https://github.com/xarray-contrib/xwrf/issues/60 and a later release...perhaps v0.1?), with some some cursory exploration it looks like everything works out for https://github.com/xarray-contrib/xwrf/issues/52#issuecomment-1248425926.

Thank you for the feedback @lpilz and @andersy005! I believe all the issues raised have been addressed. With an approving review from someone on @xarray-contrib/xwrf-devs, this should be good to merge.

Awesome work :rocket: Thanks a lot!


Problems with ng-tree-select with nzVirtualHeight and nzHideUnMatched

Reproduction link
https://stackblitz.com/edit/angular-jfshdc?file=src/app/app.component.ts
Steps to reproduce

Configure ng-tree-select with nzVirtualHeight and nzHideUnMatched (particularly - simply add nzHideUnMatched for virtual height sample from demo page)
Search something (particularly - "-9")

What is expected?

Only matched elements are displayed
No hierarchy gaps (empty rows)
Scroll is updated to reflect new hierarchy state

What is actually happening?

Only matched elements are displayed ( )
Hierarchy is displayed with huge gaps (-)
Scroll size is not updated. Scroll behavior looks strange: often displays empty area, non-stable element rendering etc. (-)

Environment
Info

ng-zorro-antd
11.1.0

Browser
Firefox

Same as the issue mentioned last October in #5873

Hi Guys,
Do you know any workaround for this? Thanks

Any updates on this? I got #treeSelect [nzVirtualHeight]="!treeSelect.inputValue ? '300px' : false" working but the actual search is still super slow.
Thanks

II am not sure if this is the best way but it seem to fix the issue for me (it removes the items from the array instead of just visually hiding them so that the scrollbar updates correctly)
In ng-zorro-antd-tree.js change:
this:
 ngOnInit() {
        var _a;
        this.nzTreeService.flattenNodes$.pipe(takeUntil(this.destroy$)).subscribe(data => {
            this.nzFlattenNodes = tempNodes;
            this.cdr.markForCheck();
        });

to:
        var _a;
        this.nzTreeService.flattenNodes$.pipe(takeUntil(this.destroy$)).subscribe(data => {
			var tempNodes = [];
			var counter = 0;
			data.forEach(e => {
				if(!e.canHide){
					tempNodes.push(e);
					counter = counter + 1;
				}
			});
			if (counter == 0){
				 this.nzFlattenNodes = data;
			}else{
                                 this.nzFlattenNodes = tempNodes;
			}
            this.cdr.markForCheck();
        });

I'm newbie with Angular and nz and can't find ng-zorro-antd-tree.js in my project to change the code in it. Could you explain me where it has to be?

@evlogievvasil
Mine was located here :
node_modules\ng-zorro-antd_ivy_ngcc_\fesm2015
Would be easier updating it in the source then building but i havent had time to find out where it is located.

@whittssg , could you help me if I want to create custom nz-custom-tree-component  with your code but in typescript which to use in my project, where in the component ts code have to make changes to achieve the same result?

Also, [nzDropdownMatchSelectWidth]="false" does not work with nzVirtualHeight.


[SYM-4153] Improve the error message for 403 responses from the API

Current dependencies on/for this PR:

main

PR #149   👈

This comment was auto-generated by Graphite.


Map Download Failed Error when using Google account

Was getting Map Download failed error when using -c.  Downloaded latest version. Getting this error now only when using Google to login. (PTC works)
2016-07-26 19:03:41,253 [auth_google] [ INFO] Google Login successful.
2016-07-26 19:03:41,325 [ search] [ INFO] Login successful
2016-07-26 19:03:42,221 [ rpc_api] [ ERROR] Could not parse response:
Traceback (most recent call last): File "c:\pokeman\pogom\pgoapi\rpc_api.py", line 205, in parse_main_request response_proto.ParseFromString(response_content)
File "C:\Python27\lib\site-packages\google\protobuf\message.py", line 186, in ParseFromString self.MergeFromString(serialized)
File "C:\Python27\lib\site-packages\google\protobuf\internal\python_message.py", line 844, in MergeFromString raise message_mod.DecodeError('Unexpected end-group tag.') DecodeError: Unexpected end-group tag.

Do you only get one error or dozens like this?

It seems to be the same error but it repeats.  See below:
http://imgur.com/a/Cnj5f

Can you paste your init file content ?

#!/usr/bin/python
-- coding: utf-8 --
config = {
'LOCALE': 'en',
'LOCALES_DIR': 'static/locales',
'ROOT_PATH': None,
'GOOGLEMAPS_KEY': 'XXXX'
}

I noticed in your readme it doesn't say to use -a google.  Could that be the reason I'm getting this error?  I have that in there.  If I don't use -a google I get a login failed error.

Getting the same thing here.
Put my GMaps key into the init config.
Running on Windows 10 x64.
Replaced rpc_api.py:212 with log.exception('Could not parse response: \n%s', response_content) and noticed that the response was an HTML error page.

<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>502 Server Error</title>

Error: Server Error

The server encountered a temporary error and could not complete your request.
Please try again in 30 seconds.

Not a Python guy, but maybe I can figure out how to log the headers for each request (with/without pycurl) and see if I can spot the difference, if someone else doesn't figure it out first.

was working fine until PTC went down ran the script with google and now I am also getting this error.

I have the same issue, running on ubuntu

Maybe it's an issue isolated to Google logins?  Anyone here using PTC having the issue?

yes ptc went down and i started to get same error

Same issue as #11 . -c worked with PTC, but not with Google accounts.

Yup, just tested.  It works with PTC but not google accounts

Yup, PTC ate dirt sometime last night when I was hoping to begin some real scans of my city.  Realised that PTC is terrible and wanted to swap all my scans to google.  I have it running now with Google but with no -C and it seems like it's taking a bit longer more.  Not really a big deal to me.  I just want data to use to find nests, etc but still it was nice when it was blazing fast.

Tried the google login with and without -c, states im logged in, but no scans happen. getting the same errors as above Could not parse response:

This happens with -c on PTC accounts as well.

This is happening for me without -c on google and ptc accounts.


samba: 4.19.2 -> 4.19.3

Description of changes
Fix for CVE-2018-14628 not being mitigated in Samba based domain controllers.
Note it seems that domains still need a manual intervention after updating by running
samba-tool dbcheck --cross-ncs --attrs=nTSecurityDescriptor --fix
Things done

Updated sources
Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Given that this requires manual action to fix the information leak, we should find a way to inform users of this; I suspect most users wouldn't notice.

A warning that is displayed when building the NixOS config if:

stateVersion  is <= 23.11
an additional option has not been enabled on the service to disable the warning
pkgs.samba.wafConfigureFlags does not contain --without-ad-dc
?

It should cover most cases while not being too noisy for the majority of users.

A warning that is displayed when building the NixOS config if:
* `stateVersion`  is <= 23.11

* an additional option has not been enabled on the service to disable the warning

* `pkgs.samba.wafConfigureFlags` does not contain `--without-ad-dc`
  ?

It should cover most cases while not being too noisy for the majority of users.

Feel free to implement it (separately?), I do not use the nixpkgs samba service in my own setup. I do not intend to change anything related to the service in this PR, however, feel free to supersede it with one that does.

Alright, I think AD DC functionality is obscure enough that we don't need to make a big deal of this; hopefully better tooling (security tracker in development as part of the STF security work) will help address this kind of thing better in the future.


weekBefore field is not respected properly.

Describe your bug here.
Here I attempt to add weeks between 2,3 and between 4,5
Both appear after week 7 in alphabetical order of filename.
Also did not work in previous versions.
Happens both in mod folder and assets folder.
Neither name of file nor "WeekName" are valid.
Only work around is to rename all weeks to not follow week# notation. But that also necessitates renaming the story list week pngs.

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No source code changes. Clean 0.6.3

it supposed to be same as the file name
week2e
week4e

weekBefore is for unlocking
Create weekList.txt if you want to order them manually

Ok I was misunderstanding.
Made a week list, but it seems placing it in mods folder does not override the one in assets folder. I have to edit the original one instead. And if i delete the OG and only have the one in mods folder it all still works except for tutrial being the last song for some reason.
So I guess I'll close this since its resolved and start a seperate report for WeekList not overriding.


port 11435 used for ?

python embedding_proxy.py --port 11435 --host http://localhost:11434

This is to host a separate embeddings for Ollama since their API is strictly /api/embeddings

This is to host a separate embeddings for Ollama since their API is strictly /api/embeddings

port 11435 used for ? I do not see anywhere use the port of 11435

This is to host a separate embeddings for Ollama since their API is strictly /api/embeddings

port 11435 used for ? I do not see anywhere use the port of 11435 @severian42

You need it only for embeddings with Ollama.
It will not be used when you do embeddings through openai API.

This is to host a separate embeddings for Ollama since their API is strictly /api/embeddings

Get it, thanks again


Successfully ran on MacOS

I successfully compiled and ran Blogifier from the GitHub source with Visual Studio 2022 under MacOS Ventura 13.4.1.
No issues with it so far.
Thanks for developing it.

Also ran on an ARM64 based Mac Mini.
I did have to install npm on it and use package manager to restore the dependencies after I copied the solution folder over to it. Also had to update my .Net runtime on the Mac Mini.  A couple of packages throw "unknown author" errors when it ran and I had to allow them in the security tool. Apart from that it compiles and runs fine.

Very happy with your successful attempt. At present, there are still many functions of this project that have not been perfected. I will continue to improve it, and I will continue to improve it. You are also welcome to improve the functions of this project.


[WIP]Move custom styles to root App file(_app.js)

All Submissions:

[ ] Have you followed the guidelines stated in CONTRIBUTING.md file?
[ ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

New Feature Submission:

[ ] Does your submission pass the tests?
[ ] Have you linted your code locally prior to submission?

Changes To Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

Pipeline needs https://github.com/reflex-dev/reflex-web/pull/202 merged to pass


Fix Jenkins build failing due to version collisions

I noticed Travis is failing - any objections to addressing that in a separate PR? @jonparrott @jmdobry

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   75.65%   75.65%
=======================================
  Files          47       47
  Lines        1828     1828
  Branches      253      253
=======================================
  Hits         1383     1383
  Misses        445      445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6ab6f...27c32db. Read the comment docs.


fix: Support updates of inherited labels and annotations on PVCs

Closes: #119
Signed-off-by: Marco Nenciarini<EMAIL_ADDRESS>

/ok-to-merge

@sxd this can be merged


Generate @k8slens/extensions via tsc only

This method only produces the relavent .d.ts files

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>

Closing as it seems that we actually do want .js files in the extension.


Fix/7.x/bulk formatter

Continuation of #3797
this consolidates someof the places we either serialize to bytes or call ToArray().
This also references Nest7 from our nuget feed, this is a versioned package where all types live in Nest7 and Easticsearch.Net7 . This has been around for a while see: https://www.elastic.co/blog/nest-and-elasticsearch-net-upgrading-your-codebase
Here we use it to profile against the integration branch.
On bulk the write path is still a lot hotter then the read path, this does not fix that but does improve allocations.

Method
Jit
Runtime
Mean
Error
StdDev
Gen 0
Gen 1
Gen 2
Allocated

'NEST updated Bulk()'
LegacyJit
.NET 4.7.2
511.0 ms
6.89 ms
9.89 ms
8000.0000
2000.0000
-
-

'NEST Bulk()'
LegacyJit
.NET 4.7.2
470.4 ms
10.76 ms
15.44 ms
16000.0000
4000.0000
-
-

'NEST updated Bulk()'
RyuJit
.NET Core 3.0
304.8 ms
4.38 ms
6.56 ms
8000.0000
2000.0000
-
153176144 B

'NEST Bulk()'
RyuJit
.NET Core 3.0
317.4 ms
4.23 ms
5.93 ms
16000.0000
4000.0000
-
199605512 B

Allowed IMemoryStreamFactory to be set on connection settings so we can compare with a factory that just returns MemoryStream

Method
Mean
Error
StdDev
Gen 0
Gen 1
Gen 2
Allocated

PR
360.6 ms
8.57 ms
12.29 ms
9000.0000
3000.0000
1000.0000
146.03 MB

'PR no recyclable '
382.4 ms
14.08 ms
20.64 ms
10000.0000
4000.0000
2000.0000
169.58 MB

7.x
388.3 ms
7.96 ms
11.91 ms
16000.0000
4000.0000
-
189.47 MB

Switched to linux machine, now only shows core results
Added results for this PR using a memory stream factory that simply returns memorystreams.

This might look good in benchmarks but needs validation of longterm effects. Even in benchmarks its the most gen2 heavy.

The test data List<Project>() alone is ~70mb.

Tests are broken because the test frameworks often takes RequestBytes or ResponseBytes which are not always clean.

Closing this in favor of smaller PR's


Journal modifications, Routing Journal, RoutingJDAO

Modified Journal interface to not extend Sink interface
Modified Journal interface to make put, remove, and replay context oriented
Removed writeComment from JDAO and put it in FileJournal
Simplified & cleaned up code

@jlhughes The only restriction would be to make sure it doesn't include a . in the name as it will create issues with the routing.


Automatic Scrolling to the newest message

Description
Earlier the app used to scroll down automatically to the latest message but now the feature seems to be broken. It was using endref react hook earlier for the same. Feel free to suggest better method than that or you can also fix that only.

I have fixed the issue now

@cherau That's great ! But from next time, do ask someone to assign you to a issue. Because the worst thing that could happen is duplication of PRs and we hate wasting someone's time. I am assigning you to this issue now but from next time, keep this in mind ^_^


Can this tool generate a TOC if the input file does not contain a 1st-level head?

I don't specify a 1st-level head in markdown files because Jekyll creates one for me when I use the title: directive. My typical markdown file looks something like this:
---
layout: post
title: My Title
---

### Saturday, May 28

#### KIN ➜ BOS
Amtrak Northeast Regional #66 departs Kingston Station at 6:17 am and arrives in South Station, Boston at 7:58 am.

MBTA transit to Logan Airport.

#### BOS ➜ ATL ➜ SFO
Delta Airlines #1801 departs at 11:00 am and arrives at 1:43 pm.
Delta Airlines #1923 departs at 2:35 pm and arrives at 4:45 pm.

Here is the output from gh-md-toc:
Table of Contents
=================

Created by [gh-md-toc](https://github.com/ekalinin/github-markdown-toc.go)

I expected to see a TOC. Am I doing something wrong?

Hey @cmaynard
Just tested it with the latest version:
➥ cat test.md
---
layout: post
title: My Title
---

### Saturday, May 28

#### KIN ➜ BOS
Amtrak Northeast Regional #66 departs Kingston Station at 6:17 am and arrives in
South Station, Boston at 7:58 am.

MBTA transit to Logan Airport.

#### BOS ➜ ATL ➜ SFO
Delta Airlines #1801 departs at 11:00 am and arrives at 1:43 pm.
Delta Airlines #1923 departs at 2:35 pm and arrives at 4:45 pm.

➥ ./gh-md-toc test.md

Table of Contents
=================

    * [title: My Title](#title-my-title)
      * [Saturday, May 28](#saturday-may-28)
        * [KIN ➜ BOS](#kin--bos)
        * [BOS ➜ ATL ➜ SFO](#bos--atl--sfo)

Created by [gh-md-toc](https://github.com/ekalinin/github-markdown-toc.go)

➥ ./gh-md-toc --version
0.6.0

What version of the gh-md-toc do you use?
Do you have internet connection during the test?

I installed the latest from homebrew. I'll check it later.

On May 10, 2016, at 08:55, Eugene Kalinin<EMAIL_ADDRESS>wrote:
What version of the gh-md-toc do you use?
Do you have internet connection during the test?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

As I see, there's 0.5.0:

https://github.com/Homebrew/homebrew-core/blob/master/Formula/github-markdown-toc.rb

Just created pull request for 0.6.0:

https://github.com/Homebrew/homebrew-core/pull/1048

Hey @cmaynard
Did you try the latest version?

I ran gh-md-toc 0.6.0 on several of my markdown files. So far, the output looks good. Thanks!

Cool. Glad it works for you.


Update index.yml

Updated HyperLink for "What is inter-directory provisioning?"

#atcp

#sign-off


add func for stairlike links rendering

I made stair-like link paths. I think it's missing functionality because it's useful for advanced hierarchy like organizational charts.
Examples:

VX-library have a "step" type for links. You can configure and see it here in action

Coverage increased (+0.007%) to 99.73% when pulling 7f8f30dd82f99b9d3d05a7606d62a220fe86a044 on martyns0n:feature/add-stair-like-links into 365001ec214f9741716a7612991e145ac1163584 on bkrem:master.

Coverage increased (+0.007%) to 99.73% when pulling 7f8f30dd82f99b9d3d05a7606d62a220fe86a044 on martyns0n:feature/add-stair-like-links into 365001ec214f9741716a7612991e145ac1163584 on bkrem:master.

Thank you for adding this path function + tests @martyns0n 💯
Already looks great, just a few minor points to be resolved before we can ship this 👍

Published: https://github.com/bkrem/react-d3-tree/releases/tag/v1.16.0
Thanks again for taking the time to add this! :)


[FEATURE REQUEST] Option to install scoop directly through the installer

Please confirm these before moving forward.

[X] I have searched for my feature proposal and have not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This proposal is a completely new feature. If you want to suggest an improvement or an enhancement, please use this template.

Describe the new feature
option to install scoop directly through the installer, similar to what is already offered for chocolatey, with a simple checkbox.
Describe how this new feature could help users
Access to a large repository of apps easily without having to install it manually via powershell

I don't understand what you mean

I don't understand what you mean

sorry, I should have put the title as "uniget installer" to make it clearer
have another checkbox below install chocolatey to install scoop:

This is not possible due to the way in which Scoop is installed on the system.
Chocolatey is bundled with UniGetUI, and does not actually get installed.
Scoop, instead, requires a system install, and wouldn't be a good practice to run the script from the installer.


Global core.hooksPath does not work

Does core.hooksPath work with gitea, it seems that after git init  writes its own hooks into data/git/repositories/TestRepo/hooks ....
and also a set git config --global core.hooksPath <pathToMyHooks> does not help.
Only when the hooks reside in data/git/repositories/TestRepo/hooks then the hooks are triggered... ?

Gitea version (or commit ref): 1.11.0+dev-134-g4ee986e4c
Git version: 2.22

ping

I've still not had a chance to actually properly investigate this

I think it was only a user problem. But the enhancement would be beneficial.


Format checking

Current implementations is really crude and bassically supports checking only against pythons implementation of json spec.
JSONC is basically just a supperset of json for support for comment in the file, so that would require removing comments from original contnent and then checking if new content is json compatible.
JSONL format that would require checking each line in the file if its json compatible, there also in the wild use of jsonl with multiline objets which will require some custom parsing of the file, ie checking forn }\n combaination of symbols and verifyng that it matches the opening brace of the object

There is a jsonlines lib
I have some thoughts about this.


Check hubot project status with GitHub

https://github.com/github/hubot/blob/master/CONTRIBUTING.md says

We like to at least comment on, if not accept, pull requests within a few days.

but the last commit to hubot was May 2016 and the pull request to add Symphony to the list of adapters has sat in their queue for 8 months (https://github.com/github/hubot/pull/1228).
Would be great to get some colour from GitHub directly on what's going on with the project (if it's long-term maintenance no big deal, just clear the PR queue...)

I guess we can close this @jonfreedman ?


[BUG] - Delete bodies module clears intel

Describe the bug
The new Create Intel module creates an intel object that has a setDamage 1 applied to it since this is how to prevent a player from just picking up the intel straight to their inventory rather than using the custom hold action. But since the object created is technically "dead", we should either have the Delete Bodies and Delete Clutter modules whitelist the intel objects (Item_Laptop_Unfolded, LanD_File1_f, etc.) or find a better way to prevent players from just picking up the intel.
To Reproduce
Steps to reproduce the behavior:

Create a new piece of intel using the Create Intel module.
Place either the Delete Bodies or Delete Clutter modules.
Observe intel is deleted.

Expected behavior
The intel should not be deleted since it may affect the mission flow.

There is a utility function for this:
[_object] call MAZ_EZM_fnc_ignoreWhenCleaning;

Fixed on dev


Added debug log callback capabilities

Due to intensive usage of OpenSSL libs linked to my product, sometimes there's a need to investigate OpenSSL behaviour while troubleshooting specific problem in the product. Debugging is not always possible to the best option is to add debug log to OpenSSL code. However logging using  printf() sometimes is not an option - the stdout/stderr may be redirected and not accessible directly. So the best solution is to let OpenSSL libs to log into a product debug log. Another profit is seeing OpenSSL debug log lines bound to the relevant product debug log lines.

This is a new feature and as such it needs to be submitted against the master branch. Please also note that there is already the OSSL_trace() API, that basically serves the same purpose.
Also to merge any contribution of non-trivial size we would need a CLA signed by you. https://www.openssl.org/policies/cla.html

This is a new feature and as such it needs to be submitted against the master branch. Please also note that there is already the OSSL_trace() API, that basically serves the same purpose.
I see - OSSL_trace() in the master branch does the function that I need. Is it planned to be ported to 1.1.1 branch? My interest is to get the debug logging callback from this upstream delivery to my product (otherwise I will need to patch my product's OpenSSL libs on every OpenSSL 1.1.1 release). If there're not plans for double-commit OSSL_trace() to 1.1.1 - which options do I have?

Also to merge any contribution of non-trivial size we would need a CLA signed by you. https://www.openssl.org/policies/cla.html
I have already provided ICLA on Nov 28, 2019 and got a confirmation mail

I am sorry but we do not backport features to stable branches by policy. So the only thing you could do is to maintain a backported OSSL_trace support by yourself in a forked repository.

I am sorry but we do not backport features to stable branches by policy. So the only thing you could do is to maintain a backported OSSL_trace support by yourself in a forked repository.

Tomáš, thank you very much for the explanation.  I will check whether they exist in the master branch and will submit the delta. What is about bug fixes - can I still submit them to 1.1.1 stable branch?

Bug fixes in general should go to the master branch and then can be backported into older stable branches if those bugs are there too. Only in case a bug fix would not be applicable to the master branch because it is not relevant there anymore, it can be merged only into the stable branch directly.


Categorizing guides, plugins, loaders, etc.

There're so many guides, plugins and loaders listed in the sidebar now, and it's sort of overwhelming for users, especially new users of webpack.

One thing I've been thinking about is that we can categorize them like what we have done with the API page:

It's just a small change, but it would improve user experience a lot. Also there's already a group option we can use in the frontmatter, so that change won't be difficult.
Problem to solve
If we all agree the aforementioned change is necessary, now we have a problem to solve: How many groups should we have, and which page belongs to which group?
Loaders
It should be easy to handle loaders as there're already groups in its index page https://webpack.js.org/loaders/:

We can reuse them or even make changes when necessary.
Plugins
We might not be able to categorize plugins just like what we did to loaders, here's my proposal, we can use three groups to categorize them:

webpack: plugins defined under webpack namespace
webpack-contrib: plugins developed under webpack-contrib
others: other webpack plugins

Guides
This would be the most difficult part, but I think it's possible.
As there're too many potential topics under guides, we might categorize them based on the users' level of webpack, for example:

Quick start for webpack beginners
Intermediate
Advanced topics like https://webpack.js.org/guides/package-exports/ which common users won't care
Any other suggestion?

Cons?
No permalink would be changed because of the aforementioned change, we just upgrade the sidebar, so I believe there's no cons. But do let me know if you think there're.

Hey I would like to take up the issue

Hey I would like to take up the issue

I just found a similar request here https://github.com/webpack/webpack.js.org/issues/3726

I just found a similar request here https://github.com/webpack/webpack.js.org/issues/3726


Could not check authorization on the server / Could not login on the server Error: Network Error.

Hi guys,
I am new on CVAT and I am not a developer. The situation I have is:

Yesterday I cloned and installed CVAT on Windows 10. It worked like a charm.
Today, I turned the computer on, tried to log in on CVAT but I couldn´t.

I built and run docker, without results.
Attached I am sending the login screen.
MAny thanks in advance for the help!
Miguel

@Miguelistan
Hi, try to restart docker containers using:
docker-compose down
docker-compose up

If you specified docker-compose files with -f flag when you build CVAT, please specify them also here.

Dear Boris @bsekachev
Thank you. It didnt work out.
This is what I do, please point any problem you may see:

Openin GitBash
Starting Docker
cd cvat directory
docker-compose build
docker-compose up -d
go to  localhost:8080

Then it shows the problem to login the server.
Attached you can find a txt file with all the GitBash lines
Thank you a lot
CVAT_problem.txt

@Miguelistan
You haven't done docker-compose down as far as I understood. Right?
You need to do it and after that, do docker-compose up

@bsekachev
Thank you very much, it's working fine now

Always use CVAT in a fresh Incognito Tab, cheers!

I met the same "Could not check authorization on the server" error. And it was solved by following @mmaaz60 's :

Always use CVAT in a fresh Incognito Tab, cheers!

🍻

@mmaaz60 hey I stuck after docker-compose up because in git bash is doing something and than it hung up.

met the same issues as above. Some of the services was not started in the background, because docker was not granted enough memory ressources.


i added my name to this project

I added my name as an altschooler to this opensource project. © AltSchool Africa

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.


Update to Ignition Edifice

New feature implementation
Implemented feature
Update dependencies to Ignition Edifice. Requires rmf_demos #22 and rmf_traffic_editor #330. Addresses #7 . Will also require updating the docs under rmf_demos once they are merged
Implementation description
Version bump of all the libraries that have been updated in Ignition Edifice.
Sdformat is now a lot less tolerant on deviations from the specification (hence the required PRs). Did some quick testing on scenarios with various features (robots, doors, delivery requests, crowdsim) and there seem to be no regressions.
To test install Ignition Edifice
sudo apt install ignition-edifice
and do a clean build of the workspace.

I briefly tested this change with the different demo worlds. Looks fine to me. :+1:
One concern might be regarding the rosdep installation for ignition-edifice. Will need to test the full installation pipeline in a clean workspace and env, to make sure all relevant ign dependencies are installed. Also, as stated, will need to update the CI in rmf_demos.

I briefly tested this change with the different demo worlds. Looks fine to me. +1
One concern might be regarding the rosdep installation for ignition-edifice. Will need to test the full installation pipeline in a clean workspace and env, to make sure all relevant ign dependencies are installed. Also, as stated, will need to update the CI in rmf_demos.

Yea sadly ignition-edifice is not in rosdep (same as ignition-dome) so it has to be installed manually. This will probably be fixed in Galactic / Fortress but it's still at least a few months away and will have to be installed manually for the time being.

Yikes, In this case we will need indicate sudo apt install ignition-edifice` in CI and installation.

Yikes, In this case we will need indicate sudo apt install ignition-edifice` in CI and installation.

Yea I was waiting for the docs PR to be merged, we will have to update dome to edifice in both CI and docs under rmf_demos.
I expect the rmf_demos PR to break CI and become green once this is merged


Catalog Manage Studies Index Query Fix

This fix shows the records in the surveys table.
The main change is in the model, the SQL was failing with isdeleted.
        // @TODO: Validate this definition
        // var $filter=array('isdeleted='=>0);
        var $filter=array();

The search works, the list of the surveys was empty after the upload.
There is a condition isDeleted=0. This is related to soft delete, I guess.
El mar, 18 oct 2022 a las 14:52, Mehmood Asghar @.***>)
escribió:

Thanks, I will review and merge. What was the issue with the search? Was
it not working?
—
Reply to this email directly, view it on GitHub
https://github.com/ihsn/nada/pull/48#issuecomment-1282339639, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFLYXQQEMPTFY7LVCBBF5XTWD2MRJANCNFSM6AAAAAARHGNTTA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@ch-ricardor,  there is a new branch (develop-php8) for all PHP-8 related updates. The branch includes new updates not in master branch yet. Please make sure to pull the develop-php8 branch before making any new changes. There are some database changes,  see the file install/schema.mysql.sql.


[nifi-cluster] cluster.nifiProperties.overrideSecretConfig is ignored when configured

What steps will reproduce the bug?

Deploy helm chart with following values:

cluster:
  nifiProperties:
    overrideSecretConfig:
      name: nifi-config-override
      data: nifi.properties
      namespace: nifi

Create a secret with the following contents:

apiVersion: v1
data:
  nifi.properties: bmlmaS5zZW5zaXRpdmUucHJvcHMua2V5PXpnOExlVlNZSkQ0cEhzR2pUd3Y5dXkK
kind: Secret
metadata:
  name: nifi-config-override
  namespace: nifi
type: Opaque

Decoded, the secret is as follows (in JSON):
{
  "nifi.properties": "nifi.sensitive.props.key=zg8LeVSYJD4pHsGjTwv9uy\n"
}

Observe as the nifi-cluster-config-1 secret does not contain the properties from the override secret

What is the expected behavior?
The resulting node config contains the properties mixed in from the override secret
What do you see instead?
The properties in the resulting node config remain unconfigured
Possible solution
No response
NiFiKop version
v1.10.0
Golang version
Whatever is bundled with the container image
Kubernetes version
Client Version: v1.29.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.7-gke.1104000
NiFi version
No response
Additional context
I have configured the values based on https://github.com/konpyutaika/nifikop/issues/47#issuecomment-1077539019.
I tried with both nifi.properties and properties as the secret key but neither worked.
Additionally, I tried with both the values for secret override above, as well as the following (per the comment reference to an old repo):
cluster:
  readOnlyConfig:
    nifiProperties:
      overrideSecretConfig:
        name: nifi-config-override
        data: nifi.properties
        namespace: nifi

@juldrixx Would you happen to have any insight on this issue?

@juldrixx Would you happen to have any insight on this issue?

The feature was implemented in this PR https://github.com/konpyutaika/nifikop/pull/455, but has not yet been released. It is therefore not available in the current helm chart.

@juldrixx Would you happen to have any insight on this issue?

The feature was implemented in this PR #455, but has not yet been released. It is therefore not available in the current helm chart.

Ah, I see. Is there an ETA on when the next version will be released with this new feature?


Implement TimePickerDialog Widget in the Widget Catalog

TimePickerDialog Widget needs to be added to the Widget Catalog. Make sure to include the description of the widget in the Description tab and add an argument to include link to the official docs of the widget (Refer to any example in widgetList.dart for better understanding. Also add an argument for category of the widget and give it a category accordingly. Showcase all properties of the widget. (Refer to the official docs in case of any doubts)
Please attach screen recording of the same once done in the PR.

Update: A new feature has been added which requires you to add a new attribute named codeString in widgetList.dart. A new class needs to be added within the *widget*.dart file you have made named *Widget*Code and the code for the widget needs to be passed here. Please check out other widget files to get a better idea. Make sure this feature has been added before you push your changes.
Let me know if you have any doubts.

Sure, I will assign this to you. Good luck!


feat: expose core.ACTION_DEFINITIONS to allow custom header sections

I want to add two custom actions switch_provider and switch_cwd and have them shown in the fzf header like what the live_grep or the git_status provider has:
---Switch provider while preserving the last query and cwd
---@return nil
local function switch_provider()
  local opts = {
    query = fzf.config.__resume_data.last_query,
    cwd = fzf.config.__resume_data.opts.cwd,
  }
  fzf.builtin({
    actions = {
      ['default'] = function(selected)
        fzf[selected[1]](opts)
      end,
      ['esc'] = function()
        fzf.resume(opts)
      end,
    },
  })
end

---Switch cwd while preserving the last query
---@return nil
local function switch_cwd()
  local opts = fzf.config.__resume_data.opts or {}

    -- Remove old fn_selected, else selected item will be opened
    -- with previous cwd
    opts.fn_selected = nil
    opts.cwd = opts.cwd or vim.uv.cwd()
    opts.query = fzf.config.__resume_data.last_query

    vim.ui.input({
      prompt = 'New cwd: ',
      default = opts.cwd,
      completion = 'dir',
    }, function(input)
      if not input then
        return
      end
      local stat = vim.uv.fs_stat(input)
      if not stat or not stat.type == 'directory' then
        print('\n')
        vim.notify(
          '[Fzf-lua] invalid path: ' .. input .. '\n',
          vim.log.levels.ERROR
        )
        return
      end
      opts.cwd = vim.fs.normalize(input)
    end)

    -- Adapted from fzf-lua `core.set_header()` function
    if opts.cwd_prompt then
      opts.prompt = vim.fn.fnamemodify(opts.cwd, ':~:.')
      local shorten_len = tonumber(opts.cwd_prompt_shorten_len)
      if shorten_len and #opts.prompt >= shorten_len then
        opts.prompt =
          path.shorten(opts.prompt, tonumber(opts.cwd_prompt_shorten_val) or 1)
      end
      if not path.ends_with_separator(opts.prompt) then
        opts.prompt = opts.prompt .. path.separator()
      end
    end

    fzf.resume(opts)
end

I searched through the the issue and found this that provides a method to set custom headers, but as it says it does not change the header of some providers that already have their default header, and it is also kind of cumbersome if user wants to add a action header for multiple providers (e.g. the switch_cwd actions can be applied to all providers that inherits the files actions, including files, git_files, git_status, grep, lsp, oldfiles, quickfix, loclist, tags, btags, args)
After some searching and reading (using fzf-lua's live_grep :)) I found the default headers are defined in the ACTION_DEFINITIONS variable in core.lua. It will be much more convenient if we can expose it to users so that they can add custom actions to the table and fzf-lua will automaitcally pick it up.
For example, to add the switch_cwd custom action, one only need to
local fzf = require('fzf-lua')
local actions = require('fzf-lua.actions')
local core = require('fzf-lua.core')
local path = require('fzf-lua.path')

---Switch cwd while preserving the last query
---@return nil
function actions.switch_cwd()
  local opts = fzf.config.__resume_data.opts or {}

    -- Remove old fn_selected, else selected item will be opened
    -- with previous cwd
    opts.fn_selected = nil
    opts.cwd = opts.cwd or vim.uv.cwd()
    opts.query = fzf.config.__resume_data.last_query

    vim.ui.input({
      prompt = 'New cwd: ',
      default = opts.cwd,
      completion = 'dir',
    }, function(input)
      if not input then
        return
      end
      local stat = vim.uv.fs_stat(input)
      if not stat or not stat.type == 'directory' then
        print('\n')
        vim.notify(
          '[Fzf-lua] invalid path: ' .. input .. '\n',
          vim.log.levels.ERROR
        )
        return
      end
      opts.cwd = vim.fs.normalize(input)
    end)

    -- Adapted from fzf-lua `core.set_header()` function
    if opts.cwd_prompt then
      opts.prompt = vim.fn.fnamemodify(opts.cwd, ':~:.')
      local shorten_len = tonumber(opts.cwd_prompt_shorten_len)
      if shorten_len and #opts.prompt >= shorten_len then
        opts.prompt =
          path.shorten(opts.prompt, tonumber(opts.cwd_prompt_shorten_val) or 1)
      end
      if not path.ends_with_separator(opts.prompt) then
        opts.prompt = opts.prompt .. path.separator()
      end
    end

    fzf.resume(opts)
end

core.ACTION_DEFINITIONS[actions.switch_cwd] = { "Switch CWD" }

fzf.setup({
  actions = {
    files = {
      ['alt-c'] = actions.switch_cwd,
    },
  },
})

to have the custom header shown in all providers that inherits from files:

files provider

git_status provider
Also changing the default separator to "|" to align with the default separator of git_status.

I have no problem with these changes @Bekaboo, the only “issue” I have with it is that I don’t like this code and there needs to be a better interface for this but that’s on me :)
Your new functions look great!

Btw, personally I would’ve used another fzf-lua interface to choose the new directory, perhaps files with a custom command for fd --type d.

Thanks for accpeting this PR.

Btw, personally I would’ve used another fzf-lua interface to choose the new directory, perhaps files with a custom command for fd --type d.

True, I just write this quickly and vim.ui.input() is simpler to use. I will definately try to replace it with some fzf functions when I get time :)

@Bekaboo, FYI ACTION_DEFINITION header set behavior changed with https://github.com/ibhagwan/fzf-lua/commit/718be95a88f6200137c17d64999e947afba07151, I can't guarantee it will stay like this forever but it's better than before, my plan is to remodel the actions/keybinds and the headers associated with them but I can't commit when it will be done.

@ibhagwan Thanks for letting me know!

@ibhagwan Thanks for letting me know!

Hi @Bekaboo, FYI, there is another change incoming (probably the last in a while) that might affect the code you came up with, due to the work required to support windows I refactored but parts of the code, for example the path module was changed to support both windows and UNIX style paths (+added proper tests) and the core module changes the way it passes area to the headless wrapper via mt_cmd_wrapper it now encodes the option using base64 (to minimize escaping issues) and fzf_opts no longer require escaping any option and many more changes…
The new code is already published under the windows branch and so far it seems to be working great with no issues, I plan to merge the code sometime next week if no major issues are found.
You’re one of the few users (that I’m aware) who make use of fzf-lua internals (not just the API, which remained unchanged), I can updated you when I do that so you can pin the previous commit if you need more time to adjust.
As a side note, I also want to refactor the ACTION_DEFINITIONS as I dislike that part of the code, needs to be a more generic interface anyone can use.

@ibhagwan Thanks, I am happy to see that fzf-lua is being constantly improved!

@ibhagwan Thanks, I am happy to see that fzf-lua is being constantly improved!

Ty @Bekaboo! Merged.


Add Option to Exclude Destination Branch Changes

Currently, the changes made are being determined by the command git diff <destination branch>..<source branch>. This command results in changes made in the destination branch as well.
Some CI tools have option to merge the source branch into the destination with the git clone step itself. In this case, changes made in the destination branch become irrelevant for determining the affected targets.
For these scenarios, we should use the git diff <destination branch>...<source branch> command to accurately determine the effective change set.
Proposal
Add one more command line option to exclude destination branch changes.

Hey, good point, let me check what can be done to achieve this.

Instead of passing the destination branch as the --base-branch argument try using git merge-base to find the best common ancestor between your source and destination branches. Using this commit at the --base-branch argument the tool will only consider the changes from the source branch back to that common ancestor.
example from my CI script:
MERGE_BASE=`git merge-base ${SOURCE_COMMIT} ${DESTINATION_BRANCH}`
echo "Merge Base: ${MERGE_BASE}"
mint run XcodeSelectiveTesting --base-branch ${MERGE_BASE}

@ashutosh-dhse with the new option -c it's possible to pass in the changed files as a list: https://github.com/mikeger/XcodeSelectiveTesting/pull/39
See https://github.com/mikeger/XcodeSelectiveTesting/issues/37


Fixes arm64 image and adds CI

Our arm64 image was busted because the mirror of alpine didn't mirror
as a multi-architecture image. This adds CI to ensure that the image
built can indeed run on the intended architecture.
NOTE: this currently uses Docker Hub image as a base, but when stable,
this repository is low traffic, so unlikely to cause an outage.
Regardless, we should find a multi-arch mirror when we can.

I will do a second order check before merging.. building a temporary tag using the multi-arch stuff, then testing that on single arch arm64 in a travis slave somewhere else.

https://github.com/openzipkin/docker-java/issues/34 struck again, but the good news is that downstream verification on actual arm works now.


Extension violates webstore's policy

Extension was disabled by chrome and is removed by webstore. What exactly is the issue?

I've been notified by chrome team via mail. According to their latest policy - Since there is no updates in the my extension for a long period of time, my extension has been taken down. Don't worry - I'll plan to have a small update very soon.
Meanwhile, you can still clone the repo and run this extension on your browser.


Please give me an example

Hi guys,
I am now have a contract that has been deployed at Ropsten testnet.
Does anyone here can give me an example that create Raw transaction and interact with contract at Ropsten testnet by using web3swift and etherscan api???
Thank you.

You should instantiate a web3 using a custom provider URL, after that you can follow various examples from test or an example app

From: trnhgquan<EMAIL_ADDRESS>Sent: Thursday, April 26, 2018 7:45:32 AM
To: BANKEX/web3swift
Cc: Subscribed
Subject: [BANKEX/web3swift] Please give me an example (#83)
Hi guys,
I am now have a contract that has been deployed at Ropsten testnet.
Does anyone here can give me an example that create Raw transaction and interact with contract at Ropsten testnet by using web3swift and etherscan api???
Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/BANKEX/web3swift/issues/83, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGKv9_J1QHvTujOKMi4sqoy6kG8mWaQVks5tsVDsgaJpZM4TkhIG.

Hi, @trnhgquan .
Did you saw Example App in our repo? There is an example, how to create the transaction.

@trnhgquan  The web3swiftTest in web3swift repo is also a nice example. It helps me a lot.


What license should this project have?

I wasn't paying attention when I made this repo and put the GPLv3 on it, instead of LGPLv3 like the other kweb repos. However, after thinking about it some more I think a different license makes more sense for this repo.
Since this repo doesn't contain any kweb code, and it's entire purpose is to be copied and built on, I think we want to use the unlicense. I'm not a lawyer, but I think this license will allow this project to be altered and redistributed without restriction, while the kweb-core project itself would still be under LGPLv3.

Ah, that's a very good point - I agree that we should use a license that doesn't impose any restrictions on use - which means GPL and LGPL are inappropriate.
I believe the most common license in this category is the Apache License, is there a reason to prefer the unlicense over that one?  I don't think I'd heard of it before.

I don't understand the finer points here, I only suggested the unlicense because it was recommended by https://choosealicense.com/ as the license to use when you want to completely opt out of copyright restrictions. Their page on Apache v2 lists "State Changes" and "License and copyright notice" as conditions of this license, but their summary also says "Licensed works, modifications, and larger works may be distributed under different terms and without source code", so I'm not sure exactly how it would work in this case.

Ah, I see - sorry if I jumped the gun on adding a license.
My only concern with unlicense was that it seemed like it might not be very well known - and this could cause issues because companies that are super-strict might require that a lawyer review it.
But on doing some reading it looks like it's more common than I thought - so I've switched the LICENSE file to unlicense per your original suggestion.


Add SnakBar on double press exit

@Prashant4900 I would like to work on this issue

@Prashant4900 I would like to work on this issue

that great

Hey can you specify the location where the onpressed for back button is specified (ie navigation.pop)? I'm having a hard time finding it.

you might know how WillPopScope Widget will work its a parent widget on Scaffoled and its hold onWillPop Arguments so on that place just pass our fcOnWillPop()
child: WillPopScope(
    onWillPop: fcOnWillPop,

    child: ListView(),

  ),

For more detail see the readme file. So when you did that then the function is activated.
Suppose if you do that on the home screen and press the back button on single time then the snack bar needs to show


[UIKit] Prohibiting user's location results in endless spinner.

Steps:
1.Set location to "Ask Next Time Or When I Share" in settings for Radzima Dev.

2.Open app and go to details screen -> map.
3.Press "Проложить маршрут".
4.In location popup, press "Don't Allow".

Expected:
1.Nothing happens.
Actual:
1.Button shows activity indicator indefinitely.

Verified successfully on Test Flight as a part of Mobile Release 2 Build 15 UiKit v.1.0.21

https://jira.epam.com/jira/browse/EPMEDUTOUR-8762


Add unique user id to API

Currently there is no method to request a unique identifier for a user using the API. This poses some problems with OAuth, since there is no proper way of matching a user to a local user when they log in using OAuth.
Proposed fix:
Add a field id to the getPersonDetails method.

Currently, the method already provides the caller with a couple of reasonable identifiers:

studentId (although this can be null)
employeeId (although this can be null)
email

Also, I fail to see the need for an ID needed for matching as this method can only be called for the currently authenticated user, meaning that you can always be assured that the result obtained from getPersonDetails is for the person currently authenticated.
This result can then be matched to the local user in the OAuth application.

As you say yourself, the student- and employee identifiers can be null. The e-mail address is not to be trusted since I can change this in my profile. This would (in the very best case) lead to incorrectly identifying a user as a "new" user instead of a returning one.
For cases where someone authenticates only once (for example the Inter-Actief mobile app) the current situation is fine, but for web platforms having to match an Inter-Actief user to a local user a real unique and consistent identifier (in whatever size or shape) is necessary.
(Nearly) every OAuth provider provides a way of obtaining the ID. For example, GitHub has a special method for this that only returns the ID (so requesting the person details scope is not necessary).
TL;DR: I do not agree with you, only really unique and consistent identifiers work when having to match users on multiple login attempts.

Yeah, after some discussion with @windwarrior I just realized that the situation where a person logs in multiple times could create certain issues. I'll get started on this right away.

Great to hear! I would have stressed that no haste is to be made since for the symposium website we have at least a couple of months to spare, but I already see a pull request :smile:

The only remark I have, which is an issue with the fix I proposed, is that by implementing an id on getPersonDetails the account scope is needed, providing access to a users account details.
Maybe, for privacy reasons, an additional method (with no required scope) might be a better way to do this.

This should now be fixed in the pull request

Awesome!


Andreja dismissal always romantic

As of 1.14.70, Andreja's dismissal lines have had their conditions removed. This leads to them always using the romantic versions.

Details
0023B35F, 0023B365, 0023B36B need the usual condition forms re-added.
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
Dismiss Andreja while she is a friend, or pissed at you.

Fix attached. Also corrected an issue with her positive dismissal lines not being random:
SFCP_1181.zip


Parse X-Forwarded-For header correctly

Fix #1169. cc @bews

@bews, do you think you could review/test this?

This fix doesn't work: it completely ignores x-forwarded-for header. Invalid call maybe?

Looks like we should be using req.ip instead of req.connection.remoteAddress. Can you test that?

Looks like we should be using req.ip instead of req.connection.remoteAddress

Already tried, it's undefined.

Must be socket.io screwing with it. I also noticed in socket.io v2, in node v4 and v6, connection.remoteAddress is undefined and makes our tests fail.

@xPaw, do we want to merge #1143 first then?

So yeah, looks like socket.io is doing something odd, and the remoteAddress not being available in 2.0 does not help. Will need to dig in further.

@bews try this one then.

@bews try this one then.

It doesn't validate header, so this isn't a proper fix.

It doesn't validate header, so this isn't a proper fix.

I think that's the job of reverse proxy. This PR only fixes parsing the header if it includes multiple IPs.

I think that's the job of reverse proxy.

You mean nginx should do this? How?

nginx would set the header if it's publicly facing, so in that case there is nothing to validate.

nginx would set the header if it's publicly facing

And if it's not? What about behind NAT config?
Also, if there won't be any validation, when this PR doesn't fix #1169 - Lounge still can be crashed in cases when raw header is passed.

And if it's not? What about behind NAT config?

What about it? Whatever is at the top must be setting correct IP in the header. You simply wouldn't use the header that client provides to the proxy.

IIRC every proxy by default just adds client IP to the x-forwarded-for header and doesn't validate the previous content at all. For example: 0,0,0,0 -> 0,0,0,0, <IP_ADDRESS>. But I don't have time to check this.

Yeah, I'm actually with @bews on this one. Even if all reverse proxies work fine, if a user isn't on one, a malicious actor could put a malformed IP on the header and cause the lounge to crash. We shouldn't let this happen.

Added net.isIP.

@YaManicKill, I understand you don't approve this PR anymore? @xPaw, @bews, what do you think is left to do here?

@astorije it's done

@bews, are you okay with this now?

It looks fine, but I haven't tested this.


RSpec/Capybara/SpecificFinders autocorrection shoud remove escape

Reproducion steps
Run RSpec/Capybara/SpecificFinders autocorrection on:
find('#domain-deadbeef\.org-delete')

This returns a tag <tag id="domain-deadbeef.org-delete">, which id contains ..
The . shoud be escaped because bare . is a class selector in CSS.
Expected result
find_by_id('domain-deadbeef.org-delete')

CSS selector escape should be removed.
Actual result
find_by_id('domain-deadbeef\.org-delete')

References
Per HTML Standard, id attribute can contain any character except whitespace.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id

Thanks for the report!
Perhaps, in this case, the following autocorrection is needed.
# before
find_by('#foo.bar')

# after
find_by_id('foo', class: 'bar')

Unfortunately, no. In my case, the id string contains the dot . character; not class.
# for <tag id="foo" class="bar">
find('#foo.bar')
find('.bar#foo')

# after
find_by_id('foo', class: 'bar')

# for <tag id="foo.bar">
find('#foo\.bar')

# after
find_by_id('foo.bar')

I tried to fix this issue, but it's not easy because RuboCop::Cop::RSpec::CssSelector is regexp based.
To fix perfectly, it's needed to rewrite CssSelector with correct CSS selector parser.
Current best fix may be marking SafeAutocorrect: false on the cop.

I tested more edge cases:
# before
find('#foo')
find('#foo\.bar')
find('[id="foo"]')
find('[id="foo[bar]"]')
find('[id="foo"i]')
find('#foo.bar')
find('#foo[hidden]')
find('#foo:enabled')
find('#foo:not(:disabled)')
find('#foo:is(:enabled,:checked)')
find('#foo\,bar')

# after autocorection
find_by_id('foo') # OK
find_by_id('foo\.bar') # incorrect; should be find_by_id('foo.bar')
find_by_id('"foo"') # incorrect; should be find_by_id('foo')
find_by_id('"foo[bar') # incorrect; should be find_by_id('foo[bar]')
find_by_id('"foo"i') # incorrect; should not be modified
find_by_id('foo.bar') # incorrect; should be find_by_id('foo', class: 'bar')
find_by_id('foo[hidden]') # incorrect; should not be modified
find_by_id('foo:enabled') # incorrect; should not be modified
find_by_id('foo:not(:disabled)') # incorrect; should not be modified
find('#foo:is(:enabled,:checked)') # OK
find('#foo\,bar') # incorrect; should be find_by_id('foo,bar')

More case...
# before
find('[id=foo][class=bar]')

# after
find_by_id('foo', class: 'bar') # incorrect

This correction is incorrect because the selector [class=bar] means the value of the attribute class is exactly bar. find_**(class: 'bar'), .bar and [class~=bar] means the class contains bar for example <tag class="deadbeef bar">.

Thank you very much. I understand.
We will attempt to accommodate edge cases.


Show Noosphere version (tag) in settings

Hard-code tag for now. In future, we may add a Noosphere FFI to programmatically get version.

Might be nice to include the SHA of the app too, for debugging.


Typescript: Document Input methods

As described in the docs:
blur used to blur the input element.
focus used to focus the input element.
http://react-toolbox.com/#/components/input

May you update to resolve conflicts??

Closed in favor of #1154


[Enhancement] add ability to auto-link

I get this warning when iIrun pod install with this library installed.
[!] use_native_modules! skipped the react-native dependency 'react-native-locale-detector'. No podspec file was found.
    - Check to see if there is an updated version that contains the necessary podspec file
    - Contact the library maintainers or send them a PR to add a podspec. The react-native-webview podspec is a good example of a package.json driven
    podspec. See https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec
    - If necessary, you can disable autolinking for the dependency and link it manually. See
    https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#how-can-i-disable-autolinking-for-unsupported-library

are you able to add a podspec?
Contact the library maintainers or send them a PR to add a podspec. The react-native-webview podspec is a good example of a package.json driven
    podspec. See https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec

any solution here?


DB-Scaffold output doesn't work with C#8 nullable flag

Steps to reproduce

add Nullable flag to the .csproj
have a varchar nullable column in the DB (mssql)
use DB-Scaffold to generate the entity

public string Name { get; set; }

also the mapping in the modelBuilder

entity.Property(e => e.Name)
    .HasMaxLength(500)
    .IsUnicode(false);

When materializing a row with a NULL Name value, the following error will show:
"SqlNullValueException: Data is Null. This method or property cannot be called on Null values."
Adding .IsRequired(false) or removing the nullable flag fixes this issue.
Expected result
DB-Scaffold should generate output that works with the nullable flag.

Duplicate of #15520


Djlee

for hashicat update

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

Lee Dong Jae seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


[BUG]Unable to create proper roles based access for a particular index-pattern in Opensearch Roles Management

Unable to create proper roles based access for a particular index-pattern in Opensearch Roles Management
Unable to create proper roles based management in Opensearch Roles & User Management.
I create a particular role with restricted access to only a single index pattern with user mapped to it. My goal is that particular user should only see only selected single index pattern data & should not see other index pattern.
But when I create role & user, and try to access , blank screen is displayed.
Have tried multiple times.
It's a bug in roles management in Opensearch.
To Reproduce
Steps to reproduce the behavior:

Create your own role & user .Make sure user is mapped to role.
Now in indices , if we use * for indices , it works fine. But if we use any index pattern like my-index*, it gives blank screen.

Plugins
Have installed all standard plugins including security plugin.
Screenshots

As in above screenshot after I restrict user & role with an index pattern, nothing shows up in any page
Opensearch  Version
1.2.0
Dashboards Version
1.2.0
Additional context
The Opensearch seems to work fine when given full access to all index patterns , but it gives error only when we want to restrict to single or particular set of index patterns.

@Sandy381 Thanks for filing the issue! Would you please confirm that the index management cluster permission has been granted to this user? If that does not help, please transfer the questions to the forum.


Extract middlewares into another folder

Currently the content in middleware.go looks like a mess. Let's move it into a separate directory and extract each middleware into a standalone file.

This will cause some golang import cycle not allowed problem. I will solve this later.


missing/incorrect equals Method in MultipartValuePattern

When using multipartPatterns in StubMappings the equals method always fails. When not using multipartPatterns the equals method works correctly. I noticed that the class MultipartValuePattern does not implement an equals Method and wrote a wrapper class that implements the equals method. The equals method on the StubMappings now works as expected.
Is this missing equals method intentional or is it a bug?
This is the wrapper class I use:
public class FixedMultipartValuePattern extends MultipartValuePattern
{
    public FixedMultipartValuePattern(String name, MatchingType type, Map<String, MultiValuePattern> headers,
        List<ContentPattern<?>> body)
    {
        super(name, type, headers, body);
    }

    public FixedMultipartValuePattern(MultipartValuePattern mvp)
    {
        super(mvp.getName(), mvp.getMatchingType(), mvp.getHeaders(), mvp.getBodyPatterns());
    }

    @Override
    public boolean equals(Object o)
    {
        if (o == null) return false;
        if (this == o) return true;

        if (Objects.equals(this.getClass(), o.getClass()))
        {
            FixedMultipartValuePattern that = (FixedMultipartValuePattern) o;

            return Objects.equals(this.getName(), that.getName())
                    && Objects.equals(this.getBodyPatterns(),that.getBodyPatterns())
                    && Objects.equals(this.getHeaders(),that.getHeaders())
                    && Objects.equals(this.getMatchingType(), that.getMatchingType());
        }

        return false;
    }
}

This class doesn't currently have an equals method as within WireMock it's never used in a way that requires it.
In what context do you find the lack of an equals method causes problems?

I have a use case where I check whether two StubMappings have the same RequestPattern, so I can remove duplicate StubMappings. That's where I use the equals Method.
I think it's very convenient if every class implements the equals method even if it is not required by the main logic.
Would you consider adding the equals method, or should I stick to my wrapper class?

OK, I think it makes sense to support that use case, so I'll tag this as an enhancement.
Happy to receive a PR if you feel like creating one.

I created a PR yesterday. Let me know if you want something to be changed.

I created another issue/pr with more missing equals/hashcode (#2034). This can be closed.


test: add tests for on* property on prototype

test for ondatachannel is omitted on purpose.

Codecov Report

Merging #50 into master will decrease coverage by 88.19%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #50      +/-   ##
=========================================
- Coverage   93.53%   5.33%   -88.2%
=========================================
  Files           1       1
  Lines         820    1124     +304
=========================================
- Hits          767      60     -707
- Misses         53    1064    +1011

Impacted Files
Coverage Δ

rtcpeerconnection.js
5.33% <0%> (-88.2%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e116891...d0015e6. Read the comment docs.