Adding the option for conversion to WebP-format

The problem to solve
When uploading images to a content platform, I might want imagemagick to automatically convert them to Google's image format, WebP for faster loading times.
Proposed solution
I would love to have the option to let imagemagick convert a file to another format, preferably WebP.

Add a targetFormat-option to the imageSizes-array to allow setting a target format (jpg, webp) for automatically resizing and converting the image in one go. That way, we would be able to use 2 image sizes for the WebP-converted image, and 2 image sizes for the JPEG-original (but resized) format to use as fallback for older browsers who do not yet support WebP.

Alternatives
Perhaps it is easier to use a postprocessor? Would love someone's opinion on this.
Additional context
Trying to fit all pieces together that are (imo) necessary for turning ApostropheCMS into the best possible JS-powered digital experience platform.

Interesting!
WebP is pretty great but does not work in IE11 which does unfortunately
still have a couple points of market share. I'm not sure what the right
fallback strategy would be. What does that markup look like, if you know?
Meanwhile it sounds like AVIF is coming up as the replacement for WebP,
although it is currently only turned on in stable builds in Chrome.
(Firefox has it as a developer option.)
On Wed, Dec 16, 2020 at 7:55 PM Bram De Backer<EMAIL_ADDRESS>wrote:

The problem to solve
When uploading images to a content platform, I might want imagemagick to
automatically convert them to Google's image format, WebP for faster
loading times.
Proposed solution
I would love to have the option to let imagemagick convert a file to
another format, preferably WebP.
Add a targetFormat-option to the imageSizes-array to allow setting a
target format (jpg, webp) for automatically resizing and converting the
image in one go. That way, we would be able to use 2 image sizes for the
WebP-converted image, and 2 image sizes for the JPEG-original (but resized)
format to use as fallback for older browsers who do not yet support WebP.
Alternatives
Perhaps it is easier to use a postprocessor? Would love someone's opinion
on this.
Additional context
Trying to fit all pieces together that are (imo) necessary for turning
ApostropheCMS into the best possible JS-powered digital experience platform.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/uploadfs/issues/62, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27PTNI5CHMUIHI4VVO3SVFJJHANCNFSM4U6Z3LXA
.

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

We might have to do something where the JPEG or PNG always exists, but
markup that is "smart" can know the .webp also exists in each case. Markup
that hasn't been upgraded to deal with the issue could still offer JPEG/PNG
without a bc break.
On Fri, Dec 18, 2020 at 8:51 AM Tom Boutell<EMAIL_ADDRESS>wrote:

Interesting!
WebP is pretty great but does not work in IE11 which does unfortunately
still have a couple points of market share. I'm not sure what the right
fallback strategy would be. What does that markup look like, if you know?
Meanwhile it sounds like AVIF is coming up as the replacement for WebP,
although it is currently only turned on in stable builds in Chrome.
(Firefox has it as a developer option.)
On Wed, Dec 16, 2020 at 7:55 PM Bram De Backer<EMAIL_ADDRESS>wrote:

The problem to solve
When uploading images to a content platform, I might want imagemagick to
automatically convert them to Google's image format, WebP for faster
loading times.
Proposed solution
I would love to have the option to let imagemagick convert a file to
another format, preferably WebP.
Add a targetFormat-option to the imageSizes-array to allow setting a
target format (jpg, webp) for automatically resizing and converting the
image in one go. That way, we would be able to use 2 image sizes for the
WebP-converted image, and 2 image sizes for the JPEG-original (but resized)
format to use as fallback for older browsers who do not yet support WebP.
Alternatives
Perhaps it is easier to use a postprocessor? Would love someone's opinion
on this.
Additional context
Trying to fit all pieces together that are (imo) necessary for turning
ApostropheCMS into the best possible JS-powered digital experience platform.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/uploadfs/issues/62, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27PTNI5CHMUIHI4VVO3SVFJJHANCNFSM4U6Z3LXA
.

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

AVIF seems like a future-proof choice indeed.
We should use content negotiation. If user agent lets us know that WebP is supported, we check for the .webp-version. If not, it should fall back to JPEG/PNG.
I've been using a Wordpress plugin that does exactly this. The image URL you're using is always a jpg/png-link, but there's a PHP-script behind the link which is dynamically checking and returning the right supported format. Works great really.
The only question I'm asking myself at the moment: do we convert on upload? Or instantly when the file is request? I'm not really sure what the best (or the most scalable) solution would be.
I'm willing to spend some time on this though, if the above sounds good to you?

Hi,
Any update on this matter? It would be great to have WebP image format alongside others as it is slowly becoming an industry standard.
@boutell IE11 will soon be no longer supported

It is certainly something we want to do. PRs are of course welcome.
On Fri, Apr 30, 2021, 6:40 AM stepanjakl @.***> wrote:

Hi,
Any update on this matter? It would be great to have WebP image format
alongside others as it is slowly becoming an industry standard
https://caniuse.com/?search=webp.
@boutell https://github.com/boutell IE11 will soon be no longer
supported
https://techcommunity.microsoft.com/t5/microsoft-365-blog/microsoft-365-apps-say-farewell-to-internet-explorer-11-and/ba-p/1591666
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/uploadfs/issues/62#issuecomment-830006766,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27M5N67DNKQHORZAUI3TLKCKBANCNFSM4U6Z3LXA
.


Absence of Material Symbol for 'Page Info'

Missing Material Symbol: Page Info
Code Point: f614

Thank you for reporting this!
I see that the page_info icon is missing -
https://fonts.google.com/icons?icon.style=Outlined&selected=Material+Symbols+Outlined:pip:FILL@0;wght@400;GRAD<EMAIL_ADDRESS>The page_info icon is missing from the codepoint and ttf fonts found on the official google repo that the packages uses as the the source of the icon fonts.  I have created a PR #1517 at the material-design-icons github repo
As soon as the official fonts are updated with the missing icons I will release a package update!

It may help to go to the Issue #1517 and give it a thumbs up.

I have added code to the example app so that when it is running as a web app it places state references into the app url as query parameters so that a URL can be used to bring up the app in the state a user has left it.
Here is the URL to look at the icons containing the string page

@nTerior   The https://github.com/google/material-design-icons repo was updated yesterday and the new fonts are now incorporated in the new 4.2659.0 version of the material_symbols_icons package.
show page_info icon is now included
(The middle 2659 number now corresponds to the 2.659 version of the variable fonts being used).


Spell check as you type

+1

I don't know why it doesn't let OS X handle spell check like it does elsewhere.

I'm more of a designer than a developer but would it be possible to leverage this open source js spell checker?
http://www.javascriptspellcheck.com/Software_License_for_JavaScript_SpellCheck

https://github.com/electron/electron/pull/942

+1

+1

+1 I love this app but the lack of spell checking is a real pain.

+1

reopened cuz the first solution we attempted did not work properly across different operating systems

+1

+1

If this issue will be the duplicate of my request #237 , let me say that I want OS X autocorrect enabled as well as spell check highlighting.

+1

+1 to this. Please please please do this.

This could be done via using webframe.setSpellProvider
https://github.com/electron/electron/blob/master/docs/api/web-frame.md#webframesetspellcheckproviderlanguage-autocorrectword-provider
tested it with a toy example, which basically showed every word as misspelled.
const {webFrame} = require('electron')
webFrame.setSpellCheckProvider('en-US', true, {
  spellCheck (text) {
    return false;
  }
})

Also tried using  node-spellchecker but I was getting errors when loading the module.
Uncaught Error: Module version mismatch. Expected 50, got 48.
Tried rebuilding npm with right --abi=50 but still failed
If someone wants to pick this up it's really easy if they get pass this.
I believe these are the steps required if someone wants to pick this up

have it working with node-spellchecker
add to context menu suggested words (this has to be done dynamically, see this issue
add an option to define the language to be used (until now all that's implemented are true/false configurable options)

@averissimo My branch worked just fine in macOS and Linux. I never managed to make it compile from Windows. The main downside of using node-spellchecker is that it requires compiling individually for each platform.

+1 to this. Please please please do this.

+1

This was shared with me. Maybe it helps?
https://github.com/electron-userland/electron-spellchecker
electron-spellchecker is a library to help you implement spellchecking in your Electron applications, as well as handle default right-click Context Menus (since spell checking shows up in them). This library intends to solve the problem of spellchecking in a production-ready, international-friendly way.

Will this require to compile libraries under specific operating systems? I believe @monchote had a solution
The problem is that the dictionary libraries needed to be compiled separately in windows / linux / osx (@monchote, correct me if i'm mistaken)

@averissimo That was the main issue, indeed.

I have only been using yakyak for a little bit on mac and I used to think I could live without some spell-checking (either via node or leveraging the system).
Wouldn't support for some be better than none?  If it's a problem for some systems they deserve more planning rather than weigh down obtainable solutions.  Are there docker containers we could make that we could leverage for builds so native compiling would be less of a problem for the project?
That being said, I've not looked at the code yet but I do really love a lot about this app.  I'll try to back read what's already been attempted by @monchote and @averissimo above but I haven't spent a lot of time with the electron api so any suggestions about stumbling blocks for this issue would be appreciated 👍

+1
If it is necessary I am willing to pay for a version with automatic correction

This would also be a feature I'd be very happy to pay for.

There is another thread on spelling that offers up a solution to devs: https://github.com/yakyak/yakyak/issues/683

Still hoping to have spellcheck on Mac before the new Allo web client comes out :-/

Unfortunately it seems like the person that suggested was wrong (his words)
Last I visited this issue it still required Yakyak to be compiled in different environments, Linux, OSX and Windows. Has something changed related to this?
As we build using Travis-CI.org we would be able to do it in Linux and OSX (if the experiment I'm doing today works)
Question for anyone that knows (hint hint @monchote ) can we compile the necessary libraries for windows using wine?

Thank you André
I already use yakyak for a few months, but what I need most is not to allow automatic correction of spelling mistakes.
I've been following the forum, but can not figure out how to enable this feature.
I'm using MAc

the feature has not been implemented yet, as it requires an infrastructure that supports all 3 main systems OSX, Windows and Linux.
Currently we are building only in Linux for all binaries. (just yesterday we successfully built on both linux and mac osx, thus my question on the comment before :)
That could allows us to actually use spellchecker, but it's still an if, as we would need someone to write/adapt @monchote code and send a pull request

When I worked on this I managed to compile and make it work on both Mac and Linux. I set up a Windows 10 VM and spent many ours trying to build it there with no success.
I'm not sure what the current state is as I haven't looked into it for a while.
Maybe it's worth adding the code and having it work on Mac and Linux even if it doesn't do much on Windows until a solution is found?

What is the process to build the code with spell check support in the #271 pull request?
I.e. any external commands?

Nothing special as far as I remember.

ok, so what was failing in windows? compiling the code or installing the modules?

Setting up the environment and building the project. It was a bit of a nightmare.

LoL you make it sound soooo awesome!! :p
We either need to do it via wine or using a windows CI (continuous integration) service
Otherwise it won't be an automated process which sucks
Thanks for the continuous feedback, I'm sure that sooner or later your code will be merged!!

bump

+1 - I use this app every day on Linux. Would love to have the spellcheck functionality.

+1

+1

+1

+1

+1

+1

+1

+1

Any word on this getting added? Great app too. Love it, this is the only issue for me at this time.
+1

Please add spell check for Mac OSX

Please add spell check for Mac OSX

I'm just going to go out on a limb and say it isn't going to happen.

I'll throw on another vote. Switched to Firefox and I need a dedicated desktop app. This works fantastically but I need me some spellcheck!
+1!

Spellcheck and auto-correct has been requested since 2015? Really?
+1 !
+1000 !

Looks like with the upgrade to Electron v9 in YakYak 1.5.8, spellcheck is enabled now! At least I'm seeing it on macOS:

It only took 4 years, lol.
Thanks,
Nicholas Vilppu
On Wed, Jun 17, 2020 at 5:46 AM Jesse Jarzynka<EMAIL_ADDRESS>wrote:

Looks like with the upgrade to Electron v9 in YakYak 1.5.8, spellcheck is
enabled now! At least I'm seeing it on macOS:
[image: image]
https://user-images.githubusercontent.com/1694586/84826300-c1673600-aff0-11ea-83c4-e55d904c6a6e.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yakyak/yakyak/issues/61#issuecomment-645002701, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOVY6MXT3ZBURGF33RPGNLRW7K2LANCNFSM4BQRGKPA
.

Amazing!

I may have jumped to conclusions, I can see typos, but there isn't a suggested spelling available.
But at least I can see a mistake quicker.

Good news for this issue as I just merged an implementation of spell check that electron has (what @jessejoe and @adampatterson mentioned) #1201
This is now "implemented" on v1.5.10-beta-rolling
I've tested on Ubuntu (linux) all the bullet points below, but I'd like to ask users to test if it works as expected in Windows, MacOSX and Linux
Checklist on what should work:

[ ] It's off by default... red underline no longer appears
[ ] Context menu has options to turn it on
[ ] It actually corrects misspellings
[ ] Turns on and off
[ ] Language switching works

ps. I couldn't find a way to map locale to language string (pt-PT -> Portuguese) so unless someone creates a pull request, that's how it's staying.

I'd really appreciate if someone could check if this works in platforms other than Linux :)

Hi,
on Kubuntu 20.04 LTS,  v1.5.10: works, mostly:
if you go to the menu, then help --> about and then return to conversation, then right clicking will not work properly, it will attempt do display menu for spellchecking but fails and displays only "Copy".

Wow @asenchristov !! thanks for discovering that.
Corrected and already available in v1.5.10-beta-rolling

@averissimo v1.5.10-beta-rolling is stuck at "Connecting" on macOS, so I'm unable to test. 1.5.9 connects fine, I wonder if it's missing one of the fixes.

I inadvertently made a beta build that was buggy as hell and reverted in a few minutes.
I've just tested with the deb and linux tar file and they both work.
@jessejoe  Can you check now?

@averissimo seems to work! Although I'm not sure the context menu is the best place to put the toggle for on/off, I never would've looked there for it.

Do you have any suggestions?
I placed it there as it's likely to be accidentally discovered

I think if it was enabled by default, it's an OK place. Otherwise an option in one of the app menus.

Hi,
on Kubuntu 20.04 LTS, v1.5.10: works, mostly:
if you go to the menu, then help --> about and then return to conversation, then right clicking will not work properly, it will attempt do display menu for spellchecking but fails and displays only "Copy".

I have the same problem in ubuntu 20.04 and also I can't find the spell checker option.


Respring loop b46

Checklist

[ ] I have a useful screenshot that shows the full log(After pressing the view log button) and will post it.
[ ] I have exported my Diagnostics file immediately after jailbreak failed or succeeded and will post it.
[x] I have checked other issues to make sure its not a duplicate issue.
[x] I am using the latest unc0ver beta.
[x] I have checked to see if my device and iOS version are supported.
[x] I can accurately describe the issue in the description and maintain a descriptive but short title.
[x] I will not have more than one issue actively open at once.
[x] I will not be entitled, spam, or use ??? or !!!.

Describe the bug
On b46, when I reboot my iPhone to the non-jailbreak stage, then if I have Reload System Daemons turn on and click Jailbreak button then my phone could get a respring loop.
Else if I turn it on after I had jailbroken my phone and clicked Re-jailbreak button then it would work.
Device

iOS Version: 12.1.1
iOS Device: iPhone 8,1
unc0ver Version: b46

I am also like this
so, I can only turn off this option.


Issues with \ in Dendron Markdown

Dendron comes with a forked version of mpe to support dendron specific functionality like note references. We do this by modifying the markdown before mpe processes it.
There are issues with how we handle \ that causes them to be rendered as newlines in certain situations.

If possible to address the issue with the single line delimiters conflicting with "I would rather $200 than $100", that would be great!

yes, this should also address that issue with the caveat that you will still have to escape the $ signs.
the following would preview normally after the fix
\$100 and \$200

that would be excellent, many thanks!

fixed in 0.9.3 of dendron markdown preview enhanced


There is no "copy" feature in JavaScript when i want to copy the code

Repro steps:

Navigate to https://pxt.microbit.org/beta
Switch to the "JavaScript" and select the code
Then right click and choose "copy"

Except Results ( IE ):

Actual Results:

Either by design or a monaco editor issue. But I see the same behavior in the monaco editor playground.

From: Sam El-Husseini<EMAIL_ADDRESS>Sent: Thursday, May 25, 2017 3:00 AM
To: Microsoft/pxt<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [Microsoft/pxt] There is no "copy" feature in JavaScript when i want to copy the code (#2051)
Either by design or a monaco editor issue. But I see the same behavior in the monaco editor playground.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F2051%23issuecomment-303972648&data=02|01|jhalleux%40microsoft.com|9748231ae3d449e856b508d4a354c4dd|72f988bf86f141af91ab2d7cd011db47|1|0|636313031856981349&sdata=KqlnU5yW8TAEALHhQzW3kV4pB3xmkQ4aFaLqDQbbP0k%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KZeFeFLKAqxskhnIyON2q2jUelVLks5r9VEOgaJpZM4NU-xs&data=02|01|jhalleux%40microsoft.com|9748231ae3d449e856b508d4a354c4dd|72f988bf86f141af91ab2d7cd011db47|1|0|636313031856981349&sdata=1240uLebfCaiQsqLKzXyC020nKKFRS49j6qusxB%2Fhb8%3D&reserved=0.

Fixed in /beta


try to improve amamba/video

尝试优化 amamba 视频页面，现在封面图片不能正常显示

Preview: https://deploy-preview-4996--daocloud-docs.netlify.app/videos/amamba
Seems fixed.


BLE/Wifi connectivity Xiao

Hi! Very nice project! I am interested in using a Xiao board with wireless conectivity. What it would take to implement that?
Regards

There's a footprint for header pins on the board. You can solder in some wires and hook it up to whatever you want without modifying the board.


Update pom property fabric8.maven.plugin.version to 3.1.62

[merge]

lgtm

what is this new lgtm comment? it breaks the CD pipelines as mentioned on IRC when it was talked about.
if changes are made to the way pull requests are merged then changes are needed to the cd pipelines.  each fabric8 project is built and released using the same scripts so if a change to pull requests is made thats fine but that needs to be applied to all projects and pipelines.

iirc lgtm has been on this repo for a while since @rhuss added it. We were trying to get to a point of actually having code reviews to get some stability in there but as people are continuing to self merge it seems pointless.
Either way, we should disable lgtm & move to github code review approval anyway. That needs to be added to CD pipelines regardless as a lot of people are moving to this since it's release so whether we use it or not, it will be important for community.

That's all totally fine but my point is if this happens then it needs to be coordinated and applied to all fabric8 projects.  It also needs to be planned, agreed and prioritised as there's an effort to do this and change to the way we all work.  It's not as simple as applying a new rule to one project.

planned, agreed and prioritised

Oh yeah like all the other changes :-b
BTW lgtm was discussed on IRC before it was added & has been followed by the active maintainers on this repo, as you can see by looking back at PRs. Anyway, let's discuss the required changes on the issue you raised.


BMP loader: Fix 2 bits-per-pixel images

This should fix #67635's crash. (Though for me, instead of a crash, it just created a random image from uninitialized memory.)
The cause of the issue was the BMP file using 2 bits per pixel, and Godot neither supporting nor preventing loading that kind of image.
I added rudimentary support that works exactly like the existing bits-per-pixel options. Unfortunately this carries the same unpacking limitation as the others where all of the bits in a row must divide into bytes evenly. This restricts the allowed image dimensions to multiples of four.
Unfortunately the image in #67635 is 127 pixels wide, so it can't be loaded, but that's better than a crash!

Thanks!


Appliance builds need migration

Recent nightly appliance builds have been failing with database errors, which can be solved by running migrations on the appliance before attempting to start evmserverd.
The appliance console log has seemingly useful output:
MIQ(ApplianceConsole::InternalDatabaseConfiguration#initialize_postgresql) : starting
MIQ(ApplianceConsole::InternalDatabaseConfiguration#initialize_postgresql) : complete
MIQ(ApplianceConsole::InternalDatabaseConfiguration#create_region) : starting
MIQ(ApplianceConsole::InternalDatabaseConfiguration#create_region)  Command failed: script/rails runner script/rake exit code: 255. Error: Error: option --region must be specified.
Try --help for help.
. Output: . At: /var/www/miq/lib/appliance_console/database_configuration.rb:75:in `block in create_region'

database_configuration.rb:75 looks like this:
        AwesomeSpawn.run!(
          "script/rails runner script/rake",
          :params => ["evm:db:region", "--", {:region => region}],
          :chdir  => RAILS_ROOT
        )

That looks right, and indeed running the rake command manually yields the same error...
# rake evm:db:region -- --region 1
Error: option --region must be specified.
Try --help for help.

...so it's looking like something's broken in the process of passing the region to the rake task.
(tl;dr ^)
And finally, just for reference, evm.log complaining about a lack of DB tables, and not much else:
[----] I, [2015-01-15T20:23:02.805135 #6417:8a9ea4]  INFO -- : Vmdb::Initializer.init - Program Name: /var/www/miq/vmdb/script/rails, PID: 6417, ENV['MIQ_GUID']
: , ENV['EVMSERVER']:
[----] I, [2015-01-15T20:24:21.645807 #6417:8a9ea4]  INFO -- : MIQ(EvmDatabaseOps.start) Starting internal database
[----] I, [2015-01-15T20:24:21.645948 #6417:8a9ea4]  INFO -- : MIQ(MiqPostgresAdmin.run_cmd) Running command... service postgresql92-postgresql start
[----] I, [2015-01-15T20:24:33.528206 #6417:8a9ea4]  INFO -- : MIQ(PostgreSQL.configure_connection) SPID: [6526]
[----] I, [2015-01-15T20:24:37.763782 #6417:8a9ea4]  INFO -- : MIQ(PostgreSQL.configure_connection) SPID: [6527]
[----] E, [2015-01-15T20:24:37.764914 #6417:8a9ea4] ERROR -- : MIQ(abstract_adapter) Name: [SCHEMA], Message: [PGError: ERROR:  relation "miq_servers" does not
exist
LINE 5:              WHERE a.attrelid = '"miq_servers"'::regclass
                                        ^
...:             SELECT a.attname, format_type(a.atttypid, a.atttypmod),
                     pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod
              FROM pg_attribute a LEFT JOIN pg_attrdef d
                ON a.attrelid = d.adrelid AND a.attnum = d.adnum
             WHERE a.attrelid = '"miq_servers"'::regclass
               AND a.attnum > 0 AND NOT a.attisdropped
             ORDER BY a.attnum
...]

Thanks @seandst, any idea when this started breaking?  I've gone back to ruby 1.9.3 to see if that "fixed" it.  I don't see that we upgraded trollop (what we use for options parsing here) recently... Trying to narrow the scope.

Our last-known working image was from December (maybe 12/22?). I looked at the rake task and the Gemfile, as well as commits around that time, and nothing's popping out as an obvious culprit.
For reference:
https://github.com/ManageIQ/manageiq/commits/master/vmdb/Gemfile
https://github.com/ManageIQ/manageiq/commits/master/vmdb/lib/tasks/evm_dba.rake
https://github.com/ManageIQ/manageiq/compare/master@{12-15-2014}...master@{12-31-2014}

@seandst Currently running git-bisect... anand-1 seems to be ok.

Monkeypatching Trollop::options lets the evm:db:region rake task succeed:
https://github.com/RedHatQE/cfme_tests/blob/4c36b8df12a62ed93ca4c15c6839534dcfc93a43/utils/appliance.py#L536

Ugh, thanks @seandst... I got nowhere with git-bisect. I don't get it though, I don't think we changed trollop versions recently (last several months).  Maybe @kbrock knows?  We did take ownership of trollop at some points since anand-1 release...

There were some trollop changes right around the time the breakage started, so I started bisecting trollop. In the process, I went back well before the breakage started, and no version of trollop worked, and the rake task still failed with the same error.
So, I'm looking too see if something else might be mangling ARGV in the process.

Let me get back to this, it's a total pain of an issue

This is a terrible hack that gets it working.
--- a/evm_dba.rake    2015-01-22 16:34:44.446203452 -0500
+++ b/evm_dba.rake        2015-01-22 16:33:40.609203535 -0500
@@ -147,7 +147,10 @@
     desc 'Set the region of the current ManageIQ EVM Database (VMDB)'
     task :region do
       require 'trollop'
-      ARGV.shift if ARGV.first == "--" # Handle when called through script/runner
+      puts ARGV
+      Array.new(ARGV).each { |arg|
+        ARGV.shift if ['evm:db:region', '--'].include? arg
+      }
       opts = Trollop::options do
         opt :region, "Region number", :type => :integer, :required => true
       end

So I'll revise my previous thought: Maybe something that was mangling ARGV to strip out rake's args isn't doing it anymore?

I went back to git bisect and this is the culprit:
03c62bcc510aaa309fe18bad991e7a450e0ca0a8 (from 9/23/14)
rake from "~>10.1.0" to "~>10.1"
I'd bet rake changed how it mucks with ARGV and sometime in december a newer rake 10.3 or so
git bisect start
# bad: [8178b3f9236ebb6e10792ec0731fd47b82e8d814] Merge pull request #1400 from Fryguy/add_ec2_c4_instances
git bisect bad 8178b3f9236ebb6e10792ec0731fd47b82e8d814
# good: [ea4c62a6b90ba444254d2cc04d265e1c1d869035] Release anand-1
git bisect good ea4c62a6b90ba444254d2cc04d265e1c1d869035
# good: [6faf9a340ce21f49ec0c02f914625820046af175] Merge pull request #201 from jrafanie/use_trollop_option_parsing_for_git_reference
git bisect good 6faf9a340ce21f49ec0c02f914625820046af175
# bad: [755a1187fe452b9e3a202201e6723ce865e84053] Merge pull request #779 from martinpovolny/route_noleg
git bisect bad 755a1187fe452b9e3a202201e6723ce865e84053
# good: [07cec44eb127b2cbaf4b66e263e3b896edff8046] Merge pull request #450 from kbrock/appliance_console_v2_key
git bisect good 07cec44eb127b2cbaf4b66e263e3b896edff8046
# good: [9efc6c0c3eac9823c32bffff82f35150b25c7ce7] Merge pull request #653 from dclarizio/add_miq_proxy_toggle_dash_route
git bisect good 9efc6c0c3eac9823c32bffff82f35150b25c7ce7
# bad: [54d2772cea44a0c824cec803f13d8940834b98e2] Merge pull request #677 from psav/fix_interval
git bisect bad 54d2772cea44a0c824cec803f13d8940834b98e2
# good: [00e2f52030c77d369bd4bfbaec7361ecd3e3773b] Merge pull request #665 from romanblanco/catalog_erb-haml
git bisect good 00e2f52030c77d369bd4bfbaec7361ecd3e3773b
# good: [27758d437b9a722136ad84aa5d962ec88eea8c94] Merge pull request #585 from blomquisg/bz1133132-no-tenant-fields-in-reporting
git bisect good 27758d437b9a722136ad84aa5d962ec88eea8c94
# good: [577a6ad718ad84214d4c771538887969278afbc5] Merge pull request #700 from jrafanie/fix_user_with_missing_current_group_migration
git bisect good 577a6ad718ad84214d4c771538887969278afbc5
# good: [a95b1842bb88b9b38f83aac134ce44e9588a209d] Remove unused rake task test:lib
git bisect good a95b1842bb88b9b38f83aac134ce44e9588a209d
# bad: [295eccb39430aeffa59e461a3777365f64c149eb] Merge pull request #687 from Fryguy/rip_out_cc_rakefile_stuff
git bisect bad 295eccb39430aeffa59e461a3777365f64c149eb
# bad: [53d989927c1955f177d4333f3dc4977f643e9198] Standardize .rspec* files.
git bisect bad 53d989927c1955f177d4333f3dc4977f643e9198
# bad: [03c62bcc510aaa309fe18bad991e7a450e0ca0a8] Loosen dependencies on bundler and rake to allow upgrading.
git bisect bad 03c62bcc510aaa309fe18bad991e7a450e0ca0a8
# good: [c7a4d41857b11e6fcf03200e75df70638f0d4ca9] Remove no longer used check for RSpec being missing.
git bisect good c7a4d41857b11e6fcf03200e75df70638f0d4ca9
# first bad commit: [03c62bcc510aaa309fe18bad991e7a450e0ca0a8] Loosen dependencies on bundler and rake to allow upgrading.

It looks like rake 10.3.2 worked, 10.4.0 broke us.
https://github.com/ruby/rake/compare/v10.3.2...v10.4.0
It looks like this is the culprit: https://github.com/ruby/rake/commit/a36505d33f873f8f475a28dc4fc48a913b82e8eb

Excellent find!

@seandst I'll have a fix tomorrow...
This should work with old rake and new rake:
-      ARGV.shift if ARGV.first == "--" # Handle when called through script/runner
+
+      i = ARGV.index("--")
+      ARGV.slice!(0..i) if i
+

Wow. great find you two.
We use the trollop / ARGV.shift trick all over the place.
Are there any tests we want to add to trollop or vmdb to ensure that we don't introduce a regression around argument parsing?

Thanks for all of your help on this, gents!


XiaomiGateway3

XiaomiGateway3 is not working since the release of Home Assitant 2023.1.1, it does not load the application. If I download back the last version 2022 it runs without any problems. Am I doing something wrong or has anyone else experienced this error?
Thank you!

See https://github.com/AlexxIT/XiaomiGateway3/issues/911

Thanks!!!

It works perfectly!
:D


On release to storage account initiate a CDN purge

Purge release/latest, release/daily, and installer as needed.
We don't link them today but this is an extra example of why we should not use the CDN for PR assets.

The other option would be to consider setting cache headers on some these resources so the CDN doesn't cache them indefinitely.


Testing Template

What's up?
Just testing the template.
To Do

Create issue.
See if you can delete it.

Checklist

[x] Elif Bayraktar
[ ] Serdar Akol
[ ] Sena Mumcu
[ ] Karahan Sarıtaş
[ ] Mustafa Cihan
[ ] Serhat Hebun Şimşek
[ ] Doğukan Türksoy
[ ] Furkan Keskin
[ ] Metehan Dündar
[ ] Sinem Koçoğlu

Deadline
22.04.2022 @23.59
Additional Information
No response
Reviewers
@uskudarli

I can detete your issue if you want. Let me know if you want me to delete it. @BElifb
Alas, we can close it as:
issue template is verified with this test issue.

I am doing the latter. Thank you so much for your time and attention. @suzan-uskudarli

Issue template is verified with this test issue.


Alerts IN STOCK for Not Available items on Amazon

Description
The application reports items to be in stock, even when not available for amazon-nl
Possible solution
Shouldn't alert when not available
Example: Alerts for https://www.amazon.nl/3080-GAMING-TRIO-10G-grafische/dp/B08HM4V2DH which isn't available, but doesn't have the buying option disabled.

Need to add an outOfStock label. I will or someone will fix.
Thanks.

I made an attempt on the weekend to find an outOfStock label for this.  However,  it does not appear that the page contents returned via the script ever contains this obvious oos message:

tried these oos labels:
outOfStock: {
			container: '#outOfStock > div > div.a-section.a-spacing-small.a-text-center > span',
			text: ['Tijdelijk niet op voorraad.']
		}

outOfStock: {
			container: 'div[id="outOfStock"] div div span',
			text: ['Tijdelijk niet op voorraad.']

		}

Also tried changing the user-agent (in case amazon was blocking the requests).
A debug dump of the entire page contents never contains the words: Tijdelijk... Yet to no avail was the expect output in the returned results... 😕
Amazon using some clever js?  ...this one may take some extra digging... 🤷♂

Thanks for looking at this @xninjax. Bummer that it's not around. Looks like you've done enough digging. Probably not available to be parsed.
Going to close this out and then reference this ticket if it gets solved.
Thanks!


first commit

#907
ask me once for changes if any.

@tarunsamanta2k20 Hi thanks for contributing to MapLibre GL Native.
That preprocessor macro is used in that same file, so to remove it you have to rewrite that a bit.

@tarunsamanta2k20 It seems to be some kind of version check. Why do you think it can be removed completely?

Also please give your pull requests a descriptive title.

@

@tarunsamanta2k20 It seems to be some kind of version check. Why do you think it can be removed completely?

Please suggest me what I have to do?

@

@tarunsamanta2k20 It seems to be some kind of version check. Why do you think it can be removed completely?

Please suggest me what I have to do?

Do you know C++ and the C preprocessor?

@

@tarunsamanta2k20 It seems to be some kind of version check. Why do you think it can be removed completely?

Please suggest me what I have to do?

Do you know C++ and how preprocessor macros work?

@louwers yes

You should be able to run this file through the preprocessor to be able to replace the macro.


Error while deploying AudioVideoPlayback on Azure Cloud Services

I'm trying to run the AudioVideoPlayback bot on Azure Cloud Services but the deployment is failing. In order to deploy it, I've followed the getting started steps of the sample:

Create the certificate (a non-self-signed) for my domain "bot.jhondoe.com" as alias for "bot.cloudapp.net"

Upload the certificate

Configure the solution running the following script:
.\configure_cloud.ps1 -p {path to project} -dns bot.jhondoe.com -cn bot.jhondoe.com -thumb {thumbprint} -bid {botName} -aid {appId} -as {appSecret}

Generate the package

Upload the package to the cloud service.

When the worker roles role instances are starting, they throw the following exception:
Unhandled Exception: No such host is known at System.Net.Dns.GetAddrInfo(String name) at System.Net.Dns.InternalGetHostByName(String hostName, Boolean includeIPv6) at System.Net.Dns.GetHostEntry(String hostNameOrAddress) at Sample.AudioVideoPlaybackBot.WorkerRole.AzureConfiguration.GetInstancePublicIpAddress(String publicFqdn) in C:\repos\microsoft-graph-comms-samples\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\AzureConfiguration.cs:line 462 at Sample.AudioVideoPlaybackBot.WorkerRole.AzureConfiguration.Initialize() in C:\repos\microsoft-graph-comms-samples\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\AzureConfiguration.cs:line 313 at Sample.AudioVideoPlaybackBot.WorkerRole.WorkerRole.OnStart() in C:\repos\microsoft-graph-comms-samples\Samples\V1.0Samples\LocalMediaSamples\AudioVideoPlaybackBot\WorkerRole\WorkerRole.cs:line 92 at Microsoft.WindowsAzure.ServiceRuntime.RoleEnvironment.InitializeRoleInternal(RoleType roleTypeEnum) at Microsoft.WindowsAzure.ServiceRuntime.Implementation.Loader.RoleRuntimeBridge.<InitializeRole>b__0() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() '
For some reason the worker role instance is not finding the Host Entry for "pip.0.bot.jhondoe.com" instance host name.  I'm guessing that the issue is related to the certificate or the solution's configuration but I don't know where to start.

@JonatanMedinilla
Does the Cloud Service have public IP addresses (IL-PIPs) provisioned for each VM instance?
From the exception it seems like the bot startup code is not able to resolve the public IP address of the VM/WorkerRole instance.
https://docs.microsoft.com/en-us/previous-versions/azure/virtual-network/virtual-networks-instance-level-public-ip

@ssulzer Thanks fort the replay. I don't know if it's an error in the getting started of the samples or I misunderstood one of the steps; but in the step 3 of the  Deploy section, the guide says that the CNAME should be the same as our DNS. While analyzing the code, I found that the DNS is being used to generate the instance host name pip.instanceNumber.dns (e.g.: pip.1.bot.jhondoe.com), and the only way that I got to get the Host Entry was using  cloudapp.net as DNS (e.g.: pip.1.bot.cloudapp.net). But, in order to establish the communication with the media server, the CName must be under the domain of my  wildcard certificate (e.g.: bot.jhondoe.com). So, to solve the issue, I've configured the solution running the configure_cloud script with the following values.
.\configure_cloud.ps1 -p {path to project} -dns bot.cloudapp.net -cn bot.jhondoe.com -thumb {thumbprint} -bid {botName} -aid {appId} -as {appSecret}


Changed the file name to foundation-emails.* #409

@rafibomb Could you please review this, please?
#409

Looks good! It will definitely help alleviate confusion as we work to make Foundation more of a family.


general improvements

remove pager in 'git stash show'
add shell aliases and functions
rip bash
use warp terminal
fix zsh
fix python.sh
fix scripts
add shell.sh

This is a benchmark review for experiment review_of_reviews_20240416.
Run ID: review_of_reviews_20240416/benchmark_2024-04-16T14-57-09_v1-16-0-132-gf34b6ca77-dirty.
This pull request was cloned from https://github.com/martimlobao/dotfiles/pull/5. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: benchmark
    enable_docstring_comments: benchmark
    enable_security_comments: benchmark
    enable_tests_comments: benchmark
    enable_comment_suggestions: benchmark

    enable_approvals: true

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      docstrings_model: benchmark
      security_model: benchmark
      tests_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/2lambda123/KasperskyLab-TinyCheck/pull/3
- https://github.com/2lambda123/KasperskyLab-TinyCheck/pull/6
- https://github.com/2lambda123/KasperskyLab-TinyCheck/pull/9
- https://github.com/2lambda123/KasperskyLab-klara/pull/2
- https://github.com/2lambda123/KasperskyLab-klara/pull/7
- https://github.com/2lambda123/beego-beego/pull/11
- https://github.com/2lambda123/dexie-Dexie.js/pull/1
- https://github.com/2lambda123/sandstorm-io-sandstorm/pull/3
- https://github.com/2lambda123/sandstorm-io-sandstorm/pull/4
- https://github.com/2lambda123/typestack-class-transformer/pull/10
- https://github.com/2lambda123/typestack-class-transformer/pull/7
- https://github.com/2lambda123/typestack-class-transformer/pull/8
- https://github.com/2lambda123/typestack-typedi/pull/8
- https://github.com/2lambda123/typestack-typeorm-typedi-extensions/pull/2
- https://github.com/2lambda123/typestack-typeorm-typedi-extensions/pull/3
- https://github.com/2lambda123/unitaryai-detoxify/pull/2
- https://github.com/2lambda123/unitaryai-detoxify/pull/4
- https://github.com/Bilbottom/sql-models/pull/5
- https://github.com/CPUT-DEVS/devpost-hackathon/pull/24
- https://github.com/ErosVece/Discounted-Udemy-Course-Enroller/pull/2
- https://github.com/LemurPwned/video-sampler/pull/21
- https://github.com/TeKrop/overfast-api/pull/109
- https://github.com/TeamPGM/PagerMaid_Plugins_Pyro/pull/181
- https://github.com/Xmaster6y/mulsi/pull/11
- https://github.com/adryells/github-followers-manager/pull/3
- https://github.com/albumentations-team/albumentations/pull/1663
- https://github.com/aleph23/Composer/pull/18
- https://github.com/bengosney/cerberus/pull/800
- https://github.com/bikerski-ctrl/trackingtasks/pull/5
- https://github.com/bruAristimunha/moabb/pull/5
- https://github.com/code-Harsh247/FRSS-project/pull/58
- https://github.com/code-Harsh247/FRSS-project/pull/59
- https://github.com/code-Harsh247/FRSS-project/pull/60
- https://github.com/code-Harsh247/FRSS-project/pull/61
- https://github.com/code-Harsh247/FRSS-project/pull/62
- https://github.com/code-Harsh247/FRSS-project/pull/63
- https://github.com/code-Harsh247/FRSS-project/pull/64
- https://github.com/code-Harsh247/FRSS-project/pull/65
- https://github.com/code-Harsh247/FRSS-project/pull/66
- https://github.com/code-Harsh247/FRSS-project/pull/67
- https://github.com/code-Harsh247/FRSS-project/pull/68
- https://github.com/emoss08/Trenova/pull/247
- https://github.com/emoss08/Trenova/pull/248
- https://github.com/emoss08/Trenova/pull/249
- https://github.com/erxes/erxes/pull/5136
- https://github.com/erxes/erxes/pull/5137
- https://github.com/erxes/erxes/pull/5139
- https://github.com/gdsfactory/gdsfactory/pull/2678
- https://github.com/gdsfactory/kfactory/pull/295
- https://github.com/imflop/brew-scout/pull/17
- https://github.com/jackdewinter/pymarkdown/pull/1058
- https://github.com/jquagga/ttt/pull/53
- https://github.com/jquagga/ttt/pull/56
- https://github.com/jquagga/ttt/pull/57
- https://github.com/jquagga/ttt/pull/58
- https://github.com/jquagga/ttt/pull/59
- https://github.com/kloudlite/iot-devices/pull/2
- https://github.com/kloudlite/iot-devices/pull/3
- https://github.com/kloudlite/operator/pull/177
- https://github.com/kurianbenoy/Indic-Subtitler/pull/14
- https://github.com/manoelhc/test-actions/pull/21
- https://github.com/martimlobao/dotfiles/pull/4
- https://github.com/martimlobao/dotfiles/pull/5
- https://github.com/mraniki/dxsp/pull/628
- https://github.com/naya1503/Mix-Userbot/pull/25
- https://github.com/nbhirud/system_update/pull/10
- https://github.com/nbhirud/system_update/pull/9
- https://github.com/nikhilbadyal/docker-py-revanced/pull/496
- https://github.com/nikhilbadyal/docker-py-revanced/pull/498
- https://github.com/nikhilbadyal/docker-py-revanced/pull/499
- https://github.com/noverd/FL/pull/2
- https://github.com/nuxeo/nuxeo-drive/pull/4793
- https://github.com/nuxeo/nuxeo-python-client/pull/305
- https://github.com/otpless-tech/otpless-android-sdk/pull/69
- https://github.com/pay-theory/pay-theory-documentation/pull/81
- https://github.com/pay-theory/pay-theory-documentation/pull/82
- https://github.com/rbanffy/3270font/pull/125
- https://github.com/robbiebyrd/platinum/pull/54
- https://github.com/simnova/ownercommunity/pull/27
- https://github.com/simnova/ownercommunity/pull/32
- https://github.com/simnova/ownercommunity/pull/33
- https://github.com/simnova/ownercommunity/pull/34
- https://github.com/simnova/ownercommunity/pull/35
- https://github.com/skypointcloud/skypoint-colbert/pull/1
- https://github.com/sourcery-ai-experiments/atari-rl/pull/1
- https://github.com/strawberry-graphql/strawberry/pull/3452
- https://github.com/supabase-community/realtime-py/pull/120
- https://github.com/supabase-community/supabase-py/pull/770
- https://github.com/suttacentral/suttacentral/pull/3134
- https://github.com/suttacentral/suttacentral/pull/3135
- https://github.com/synodriver/cycurl/pull/4
- https://github.com/ultralytics/hub/pull/643
- https://github.com/yuceltoluyag/Rise-of-Kingdoms-Bot/pull/17

# Questions to ask to label the review comments
review_comment_labels:
- label: correct
  question: Is this comment correct?
- label: helpful
  question: Is this comment helpful?
- label: comment-type
  question: Is the comment type correct?
- label: comment-area
  question: Is the comment area correct?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/2lambda123/KasperskyLab-TinyCheck/pull/3
  review_pull_request: https://github.com/sourcery-ai-experiments/KasperskyLab-TinyCheck/pull/4
- dataset_pull_request: https://github.com/2lambda123/KasperskyLab-TinyCheck/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/KasperskyLab-TinyCheck/pull/5
- dataset_pull_request: https://github.com/2lambda123/KasperskyLab-TinyCheck/pull/9
  review_pull_request: https://github.com/sourcery-ai-experiments/KasperskyLab-TinyCheck/pull/6
- dataset_pull_request: https://github.com/2lambda123/KasperskyLab-klara/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/KasperskyLab-klara/pull/3
- dataset_pull_request: https://github.com/2lambda123/KasperskyLab-klara/pull/7
  review_pull_request: https://github.com/sourcery-ai-experiments/KasperskyLab-klara/pull/4
- dataset_pull_request: https://github.com/2lambda123/beego-beego/pull/11
  review_pull_request: https://github.com/sourcery-ai-experiments/beego-beego/pull/1
- dataset_pull_request: https://github.com/2lambda123/dexie-Dexie.js/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/dexie-Dexie.js/pull/1
- dataset_pull_request: https://github.com/2lambda123/sandstorm-io-sandstorm/pull/3
  review_pull_request: https://github.com/sourcery-ai-experiments/sandstorm-io-sandstorm/pull/4
- dataset_pull_request: https://github.com/2lambda123/sandstorm-io-sandstorm/pull/4
  review_pull_request: https://github.com/sourcery-ai-experiments/sandstorm-io-sandstorm/pull/3
- dataset_pull_request: https://github.com/2lambda123/typestack-class-transformer/pull/10
  review_pull_request: https://github.com/sourcery-ai-experiments/typestack-class-transformer/pull/5
- dataset_pull_request: https://github.com/2lambda123/typestack-class-transformer/pull/7
  review_pull_request: https://github.com/sourcery-ai-experiments/typestack-class-transformer/pull/4
- dataset_pull_request: https://github.com/2lambda123/typestack-class-transformer/pull/8
  review_pull_request: https://github.com/sourcery-ai-experiments/typestack-class-transformer/pull/6
- dataset_pull_request: https://github.com/2lambda123/typestack-typeorm-typedi-extensions/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/typestack-typeorm-typedi-extensions/pull/4
- dataset_pull_request: https://github.com/2lambda123/typestack-typeorm-typedi-extensions/pull/3
  review_pull_request: https://github.com/sourcery-ai-experiments/typestack-typeorm-typedi-extensions/pull/3
- dataset_pull_request: https://github.com/2lambda123/unitaryai-detoxify/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/unitaryai-detoxify/pull/2
- dataset_pull_request: https://github.com/2lambda123/unitaryai-detoxify/pull/4
  review_pull_request: https://github.com/sourcery-ai-experiments/unitaryai-detoxify/pull/3
- dataset_pull_request: https://github.com/Bilbottom/sql-models/pull/5
  review_pull_request: https://github.com/sourcery-ai-experiments/sql-models/pull/2
- dataset_pull_request: https://github.com/CPUT-DEVS/devpost-hackathon/pull/24
  review_pull_request: https://github.com/sourcery-ai-experiments/devpost-hackathon/pull/3
- dataset_pull_request: https://github.com/TeamPGM/PagerMaid_Plugins_Pyro/pull/181
  review_pull_request: https://github.com/sourcery-ai-experiments/PagerMaid_Plugins_Pyro/pull/1
- dataset_pull_request: https://github.com/Xmaster6y/mulsi/pull/11
  review_pull_request: https://github.com/sourcery-ai-experiments/mulsi/pull/1
- dataset_pull_request: https://github.com/albumentations-team/albumentations/pull/1663
  review_pull_request: https://github.com/sourcery-ai-experiments/albumentations/pull/6
- dataset_pull_request: https://github.com/code-Harsh247/FRSS-project/pull/63
  review_pull_request: https://github.com/sourcery-ai-experiments/FRSS-project/pull/12
- dataset_pull_request: https://github.com/emoss08/Trenova/pull/248
  review_pull_request: https://github.com/sourcery-ai-experiments/Trenova/pull/2


Can‘t wait for the full featured Karabiner for Sierra.

Please speed the progress of developing karabiner.please

This is neither a bug report nor a feature request. This page is not a forum, and this post doesn't belong here. Can't we close this already?

It's nice to see you're keen @zddewe, but this is the issue tracker mate.


Add weblate

Weblate is a copylefted libre software web-based continuous localization system, used by over 2500 libre projects and companies in more than 165 countries.
https://github.com/WeblateOrg/weblate

@jefftriplett @wsvincent
Can you approval this PR?

@d29107d Thank you for your prompt follow-up. We appreciate the time and effort you put into the pull request, but a thorough review takes longer than 24 hours. For future reference, 24 hours is not an appropriate time to request approval or ping a project's maintainer.

Hi @d29107d, We've added Weblate to the repo. Thanks for taking the time to submit an initial PR.


Datapower recipe

Datapower recipe

@therayy, please see my comments as I believe you want to add a recipe to deploy the DP operator and not the instance.  Also, this PR has a conflict that needs to be addressed.

@therayy, can you update the Validation step to include the cmds to verify the status of the CommonService and PN CR and also the cmd to get the PN console.  Have a look at the MQ or ACE recipe for reference.

@hollisc  please review the changes for the Validation section


Combination of notEqualTo is not working

Check out this issue for an ideal bug report. The closer your issue report is to that one, the more likely we are to be able to help, and the more likely we will be to fix the issue quickly!
For implementation related questions or technical support, please refer to the Stack Overflow and Server Fault communities.
Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

[x] You've met the prerequisites.

[x] You're running the latest version of Parse Server.

[x] You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Hi there,
I think we're not totally done with the issue #1349 and the PR #1350 just solved it partially...
@drew-gross thought that we will be running into trouble for combination and he was... right 😢
I tried to extend the test cases but there is no guide of how to run the server properly and I got some weird errors everytime (btw is there a runnable docker with proper instruction that can be run on a shitty machine just to do the tests?)
So I'll try to explain the problem as precisely as possible: "You have a cake and this cake has fan and haters".
If you want to see the cakes that Mister X didn't rated yet, you will (on Parse.com) have something like this:
var queryCake = new Parse.Query(Cake);
queryCake.notEqualTo("likes", MisterX);
queryCake.notEqualTo("dislikes", MisterX);

And, logically it returns you: all the cakes - the cakes he likes - the cakes he dislikes = all the cakes he doesn't have a opinion on or the cakes he doesn't know about.
The current status:
At the moment, it works really well with one condition but the intersection is not working, I guess: I can have all the cakes he doesn't know about or he hates (noIdea || dislike) or all the cakes he doesn't know about or he likes  (noIdea || like).
My knowledge about mongo are pretty limited but is this possible that the two conditions are joined with a or and not with an and (as it logically should)?
Nevertheless, I can make two queries and the intersection myself but that's really bad design to me...
If someone gives me access to a working test machine or provide me a decent tutorial which works on a shitty linux, I promise to write the test case myself  😬  😉  🎉

Thanks for the bug report, we will look into this. In the meantime, if you want to build and run from source, it should just be 3 steps, assuming you already have git and node installed:

Fork/clone the repo and cd to it
npm install
npm test

If you have issues somewhere in there, let us know.

So, for instance, if the test fail here because Cannot read property id of undefined, it is because of a bad configuration or it is there a regression bug?

I thought every test was working that's why I was asking for a proper tutorial but if they're failing also on your machine, then that's...fine! 🎉 😢

That test works on both my machine and Travis. To debug, change the it to fit to run only that test, then run VERBOSE=1 npm test to see the server logs as you run the tests. That may help you debug.

Ok, got Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL so can it be that my machine is a bit too slow ? 😬

That could be it. You can increase the timeout for that one test by passing a 3rd parameter to it, like
it('test name', done => {
  //test stuff
  done();
}, 60000)

Or change the default when testing on your machine.
That test also doesn't have a catch block, so adding on a catch at the end may expose the true error.

YES! I added jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000 and it does the trick
I'm writing the test case then, thanks

@drew-gross It should do the trick: the test is failing -> every cake is returned but only cake3 should be present.
 What I meant is that the cake3 doesn't have any relation with the  user1 whereas the other do and these notEqualTo should remove the cake1 and cake2 from the list but they, obviously don't.
Hope it is clear and hope you can fix it for our release on Monday 🙏

Hi, is there any news about this issue?
Maybe some ways to fix it without waiting for issue fixing?
It is very important for me, the application, which i am trying to migrate right now, is totally build on relations and queries with combinations of equalTo/notEqualTo...

how about giving this a shot? I'm not sure if the behavior is exactly what you are looking for
var queryCakeLikes = new Parse.Query(Cake);
queryCakeLikes.notEqualTo("likes", MisterX);

var queryCakeDislikes = new Parse.Query(Cake);
queryCakeDislikes.notEqualTo("dislikes", MisterX);

var queryCakes = Parse.Query.or(queryCakeLikes, queryCakeDislikes);
queryCakes.find() //etc.

Unfortunately it will only work if i need OR, but most of all i need AND.
Anyway it is a real problem, because i need to rewrite code which works with old parse perfectly.

@Michael-Kr What version of parse-server are you running?

"parse": "~1.9.0",
"parse-server": "~2.2.16",
Query construction:
query.equalTo("StringProperty", StringValue);
query.notEqualTo("RelationProperty", objectId of some Object);
query.limit(1);
The result of this query is pretty weird, the finded object does not complies to the 'query.equalTo("StringProperty", StringValue);' constraint.
At parse servers everything works correctly.

@Michael-Kr If your equalTo is on objectId, then #2472 will fix this.

@Michael-Kr can you provide come code, examples so we can investigate your issue further?


Add support for LightGBM decision tree

I will add here the progress of lightgbm implementation

first visualization

it was included in version 1.2, PR #112


New release

I would like to ask if there are any plans to update the provider for the new CAPI and Kubernetes versions? Thanks!

Hi @criscola, We will create releases for K8s 1.25, 1.26 and 1.27


Add Unwrap?

Would it make sense to add an Unwrap() function to this library? I have a usecase where I need to check the type of the underlying error, which (AFAICS) Is() cannot do. I can access the Err field of an errors.Error, but that requires having a *Error instead of an error, which AFAIU isn't the intended way to return (wrapped) errors.
Such a function could simply look like:
func Unwrap(err error) error {
        switch e := err.(type) {
                case *errors.Error:
                        return e.Err
                default:
                        return err
        }
}

I don't think this is still relevant with latest go version and fix of go-errors Is method in v1.1.0


add wilc1000 WiFi module support on SAME54 platform

add wilc1000 Wi-Fi module host driver and SDIO driver to SAME54 MCU
SAME54 XPRO platform can work with WILC1000 Wi-Fi module to connect Ali Cloud
change clk from 48MHz to 120MHz

Hi,
May I know what is PC build?
Thanks
Ben

I build on windows

Will you go through the PreValidate process?
Anything I need to fix to go to preValidate process?


Fix #7 - Add Python 2.7 support

Resolve the following compatibility issues in Python 2.7:

[x] Resolve AttributeError: 'module' object has no attribute 'TemporaryDirectory' issue outlined in #7
[x] Resolve input errors when passing strings not wrapped in quotes.
[x] Fix urlopen reference to use urllib2

@gtaylor Can you please take a look at this PR to address #7 and general Python 2.7 support?
Thank you!
Also, are you open to using an import sorting utility like isort ?

Thanks!


⚠ Bofrost.hr has degraded performance

In 66599ce, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 2784 ms

Resolved: Bofrost.hr performance has improved in 0d0a914 after 2 minutes.


Update 1_notmnist.ipynb

The url in the file will not redirect to https. i faced this problem so changing it for someone who will see it in future.
i think port 80 is blocked on that server but 443 is going is going through.

Can one of the admins verify this patch?

The url in the file will not redirect to https. i faced this problem so changing it for someone who will see it in future.
i think port 80 is blocked on that server but 443 is going is going through.
I changed and it working after it.

I signed it!

I signed it!

I signed it!
On Fri, May 19, 2017 at 9:06 AM googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/10022#issuecomment-302600190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9zFJFXbpMRGj6hrjCffr2PSJRc9H2iks5r7Q44gaJpZM4NgCpO
.

@tensorflow-jenkins test this please


WorldCreator Module in .Net Core Framework

𝗤𝘂𝗲𝘀𝘁𝗶𝗼𝗻
Hi Tolis,
When i convert our projects framework to .NetCore wich uses WorldCreator Module it doesn't compile the generated code becouse of using cSharpCodeProvider.CompileAssemblyFromSource(compilerParameters, code);  code doesn't supported in .Net Core.
I've two question
1-Do you plan to fix this neartime
2-For System.Drawing.Image typed properties and also doesn't support in .Net Core for We platform. Do you advice to convert it any type for easiest way?
Thanx for answers by now.
And tell a way to buy you a cup of coffe ;)

Ok thanks for answer,
We are waiting for your solution about this, we are in aggrieved position about that we cannot update our projects framework to .Net Core. Please notify us wich coffeer type is appropriate for you.
Best wishes.

please get in contact with me 2<EMAIL_ADDRESS>and provide a sample app

I checked this case and in general WorldCreator is not at all trivial to get it to comply with the latest changes in XAF architecutre. In addition to non available tests/docs for the package I have no other option as to redesign it from scratch under the Reactive.XAF. So if there are interested sponsors get in touch with me.

Tolis, hello again
i've changed the method from CSharpCodeProvider.CompileAssemblyFromSource to CSharpCompilation.Emit
I put all assemblies our generated code needed and wich u add in Xpand.Extensions.Compiler.CodeCompiler.Compile method  use this CSharpCompilation.Emit method. But the line we generate
 public class DynamicDocumentLibraryModule: DevExpress.ExpressApp.ModuleBase{ }
gives error like below
"CS0012: The type 'Component' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.ComponentModel.Primitives, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'"
if code generator skip to generate DynamicDocumentLibraryModule:DevExpress.ExpressApp.ModuleBase{} line Emit method compile it successfully but then i cannot get moduleType with code below
assembly.GetTypes().First(type => typeof(ModuleBase).IsAssignableFrom(type));
for adding it to ApplicationModulesManager
do u have an idea what am i missing?

do u have an idea what am i missing?

I bet u miss this :)

You must add a reference to assembly 'System.ComponentModel.Primitives, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

I am not sure if a missleading message though, it might refer to .net6 runtime rather to this specific assembly. In any case I would first verify that the assembly dependecy is there

as far as I remember there was a parse of all dependecies on the runtime and automatically added to the dynamic assembly so in theory u should not go add dependecies manually.

But if i don’t add them CSharpCompilation gives assembly missing error.
Its very clear that it needs system.component 😀
Even i add System.Conponent and System.Component.Primitives dlls manually and nothing change.

look I am suggesting out of my mind, so I might be totally wrong cause no test no gain. Anyway these are core assemblies which points towards a .netframework version problem rather than specific assemblies

Yes i can see, so do you know anyone else using this for .net core successfull or another xpand module generating bussines class assemblies in run time with xaf blazor?

Xpand generates assmblies at runtime with the Xpand.Extensions.Compiler.CodeCompiler.Compile extension in many places, in the RX repository at:
Search target
    Xpand.Extensions.Compiler.CodeCompiler.Compile(this SyntaxTree syntaxTree, params string[] references) : MemoryStream
Found usages  (3 usages found)
    <Editors>\<ProgressBarViewItem>\<Xpand.XAF.Modules.ProgressBarViewItem>  (1 usage found)
        Xpand.XAF.Modules.ProgressBarViewItem  (1 usage found)
            ProgressBarViewItemModule  (1 usage found)
                (55: 71)  using var memoryStream = CSharpSyntaxTree.ParseText(code).Compile(references);
    <Model>\<ModelMapper>\<Xpand.XAF.Modules.ModelMapper.Tests>  (1 usage found)
        Xpand.XAF.Modules.ModelMapper.Tests  (1 usage found)
            ModelMapperCommonTest  (1 usage found)
                (71: 60)  using var st= CSharpSyntaxTree.ParseText(code).Compile(typeof(object).Assembly.Location,typeof(AssemblyVersionAttribute).Assembly.Location);
    <Model>\<ModelMapper>\<Xpand.XAF.Modules.ModelMapper>  (1 usage found)
        Xpand.XAF.Modules.ModelMapper.Services.TypeMapping  (1 usage found)
            TypeMappingService  (1 usage found)
                (40: 75)  using var memoryStream = CSharpSyntaxTree.ParseText(code).Compile(references.ToArray());

ModelMapper works for .netcore. The dependecy collection is pretty similar to what I previously said (from the runtime) however is not a blazor module not that it matters and does not create Bussiness objects but rather maps any class to a model interface. You can get a lot of guidance from its codebase.

i've checked ur ModelMapper Module. And i think its DBFirst based and if i use it i must model DB at first then get it to my application. Am i wrong?

the packages generates assemblies with dependecies for .netcore you can look how we did it there and apply it to your case

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Default bootstrap from closest nodes in config (or from closest peers)

What are your thoughts on this now ?

Now node already has ability to filter slow peers.
Can be closed

Thanks !


lib: minimal: Migrate to new logging subsys

Migrate from SYS_LOG to LOG logging mechanism.
Signed-off-by: Olivier Martin<EMAIL_ADDRESS>

Codecov Report

Merging #9425 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9425   +/-   ##
=======================================
  Coverage   52.16%   52.16%
=======================================
  Files         212      212
  Lines       25894    25894
  Branches     5563     5563
=======================================
  Hits        13507    13507
  Misses      10129    10129
  Partials     2258     2258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a8bdf...75af7f1. Read the comment docs.

addressed in #10029


Jekyll alert section template

It would be useful to extend the alert.html liquid template (if that's the right name for it?) and add support for:

Ok: https://fontawesome.com/v3/icon/ok-sign
Bad: https://fontawesome.com/v3/icon/remove-sign
Warning: https://fontawesome.com/v3/icon/warning-sign

Additionally, the default colour for links within the alert template renders them very dark.
Attached is a screenshot where the link colour has been overridden.

If it's useful, the code for the above template is:
{% capture alert_text %}
Any type parameters used by a Lane must implement the Send and Form traits.
{% endcapture %}

{% include alert.html title='Note' text=alert_text %}```

Closed by https://github.com/swimos/swimos-docs/pull/201


slack install fails hash check

Checking hash of SlackSetup.exe... Hash check failed for 'https://downloads.slack-edge.com/releases_x64/SlackSetup.exe'.

Expected:
    c3e9385e3099b27fa62beac2d2d41064d939b39b6853e3c71c5b3c9f757dcc1d
Actual:
    3c9b8fb8d140f6811a8e7163ad9b293f75d2bb94eeae02a8564b241374d5dcb4

Please run scoop update and try again. The version has changed with adf94cb351555bd1bdb81d2483cf30380863f5b9

Ok, I've been running scoop update *, not scoop update.  My bad, I was not aware there was difference in the commands.


window 'popup' dimensions

I appreciate that maybe this question is out of the scope of what you are offering, but thought I would ask anyway. Which variables should I change to modify the size of the main pop-up window? I was chasing after NSwindow, setFrame, NSWidth, but couldn't figure it out.
Thanks again for your help!

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8917572-window-popup-dimensions?utm_campaign=plugin&utm_content=tracker%2F899498&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F899498&utm_medium=issues&utm_source=github).

We will add customizations some day (as in #20), but currently you can open MainMenu.xib and resize both the window and the webview. Let me know if it works.

This worked perfectly, thankyou!


Training Loss increases

Is the loss being output on trainLSTM_1.py , the real train loss or just the loss of some random epoch ?
Cause My training loss seems to increase after 2 epochs ...
FYI : I have used the glove vectors as the word vectors.

Does it increase consistently, or only for 1-2 epochs?

For the first 4 epochs its like :
215424/215375 [==============================] - 418s - train loss: 3.7656
215424/215375 [==============================] - 432s - train loss: 3.7264
215424/215375 [==============================] - 439s - train loss: 3.7595
215424/215375 [==============================] - 442s - train loss: 3.7989

Does not seem right. Try reducing your learning rates, and see what you get. You might also be interested in trying a bunch of different learning rates in parallel, and see which one converges the fastest.

I tried reducing the learning rate  and yes now the loss decreases generally.
Can you give me a fair idea of what was the loss you were getting after around 100 epochs, cause now the losses are decreasing , but not by much ...

I did this project a long time ago, and unfortunately I don't have access to most of the data associated with this project anymore (I graduated undergrad, and do not have access to my machine there anymore).
I remember getting competitive performance on the benchmark around 50-60 epochs, so you might want to try that.

Ok , thanks :) let me run a couple more epochs and I will let you know


Fix disk property name. Was state, should be status.

disk.state was returning None for all disks. Looking at the API docs, the property should be named status. Changing the name to status got me the correct values.

That field was called state at one time, looks like I missed it when it changed. Thanks!


Add elixir query

I've added basic Treesitter mappings for Elixir. I wasn't able to figure out to to properly swap key-value pairs in Keyword Lists or Maps with Atoms as keys, but otherwise everything seems to work.

Thank you so much! If you do end up figuring how to do the key-value pairs, feel free to open another PR.


Decouple packet handlers from serialization

Prototype code for Networker.Formatter.MessagePack and decoupling packet handlers from serialization so that a packet handler can process multiple packets.
This code makes use of MessagePack's Typeless serialization. I added:

Networker.Formatter.MessagePack
Networker.Example.MessagePack
Networker.SerialiserTest

The library modifications include:

Adding IPacketHandler<T> which extends IPacketHandler
Breaking PacketHandlerBase into a regular and generic version

As is, this code works with MessagePack, but it won't for Protobuf or Zero Formatter since it relies of Typeless serialization. We can make it work for Prototbuf simply by passing in the Type. But since Zero Formatter relies strictly on generics, so I don't think it will work with it. That being said, Zero Formatter has been superseded by MessagePack so how important is it for Networker to support Zero Formatter?
Ideally, we would completely defer deserialization to the packet processor and just make PacketHandlerBase<T> an empty class that inherits IPacketHandler<T> to prevent breaking changes.
Right now the PacketHandlerBase.Handle method makes use of reflection.. not sure if there's a better alternative. We can always cache a map of packet types to process methods and even precache on startup.
What do you think?

I handled this a slightly different way but will add documentation on how to use the way you've done it on top. Thanks a lot for doing Networker.Formatter.MessagePack, but please rename to new format Networker.Extensions.MessagePack and include in separate PR.

@MarkioE I'll take care of that later today!


SPEC: /product endpoints - incomplete

GET /product returns a paginated list of #/components/schemas/tea_product, which includes fields such as purl and barcode currently.
However, there is no mechanism provided in the API Spec as it stands to set/provide fields for a Product beyond it's Name in POST /product
From: https://github.com/CycloneDX/transparency-exchange-api/pull/77#discussion_r1850139350
FYI @oej  @vpetersson

Maybe I'm missing something here, but you can do this.

You initially create the product by issuing a POST to /product.
Let's say you then forgot to add say a SKU to this, you would just issue a PATCH against /product/<tea_product_identifier> with the payload {'sku': 'abc123'}.

I do however now realize that this wasn't covered. Adding a PR shortly for this.

I'd provide the same contract for the initial POST and the subsequent PATCH @vpetersson.

d'oh! My bad yes, should of course be there too. Fixed that in the PR. Thanks for flagging.


mpsc::Sender hangs forever

I'm trying to produce a sequence of values from a thread and to consume them in another one using  channel-based streams. However when the receiver stops, the sender will sometimes hang forever, while sometimes it will correctly receive an error and exit.

I'm don't know if i'm not using the channel in the right way or if there is problem in the library (I'm on version 0.1.6).

Thanks for the report! Was indeed a bug in the mpsc channel


help: Add documentation on font configuration for unsupported languages

Updates change-your-language.md. adds instructions on how to check whether the Zulip font supports selected language and steps to configure browser font.

Fixes: #26986
Screenshots and screen captures:

https://zulip.com/help/change-your-language

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Thanks for getting a start on this one, @TsionZerihun !
@drrosa could you please review this PR or put up a revised version, whatever seems easiest?

@drrosa could you please review this PR or put up a revised version, whatever seems easiest?

@alya This PR can be closed in favor of #27425.

@drrosa noted. Thanks for the feedbacks!


LSP Fees

The coordinator should charge a fee for the provided liquidity

The fee is supposed to be charged as fraction of the quantity.
This fee is charged independent of the trade setup; i.e. it's a separate payment and not reflected in the Trade model.
Initially, there is no enforcement to pay the matching fee, but clients are trusted to pay.

Outdated
**Scope of this ticket:**

The client (i.e. the app / a potentially automated market making software) have to know the fee parameters up front. This includes the fee rate and how the fee is supposed to be payed.

Endpoint on the Orderbook so that the client can query what the "fee rate" of the orderbook is (initially we could also hardcode that, but it might be better to build that in configurable from the start)
Endpoint on the Orderbook to be able to generate an invoice that can be paid by the client.

Query the rate, calculate the fee and display  the fee in the app when creating an order
When a trade is being "set up" a client (the app and potential automated market makers) have to ensure to pay the orderbook matching fee. This is triggered as separate payment to the orderbook.
On the client we have to associate the fee payment (a separate Lightning payment to the orderbook) with the trade / order after it was paid, so we can display this fee associated to the order / trade in the wallet history.
Ensure that the coordinator opens a channel with the orderbook initially, so that payments from client to orderbook can be routed.

Can be done outside of the MVP scope:

The orderbook should keep track of fees being paid for matches and potentially ban users if they don't pay

I made a small adjustment:
the fee is paid on the quantity, i.e.
for a taker fee of 0.3% and a maker fee of 0.15%, if a trader goes $100 long with leverage of 2 at the price of $20,000/BTC the fee will be:

for a taker: $0.3 worth of BTC at the price of 20,000 => 1,500 SATS
for a maker: $0.15 worth of BTC at the price of 20,000 => 750 SATS

❓
Will the orderten get paid over  the coordinator?
Will the orderbook eventually have a lightning channel with the coordinator or will the coordinator manage the orderbooks wallet?
🤔 if the coordinator would tale care of the fee payments we could include the payment into our protocol, meaning that we will not confirm the trade unless the fees have been paid. However, if we let the coordinator manage the fees we might not get the fiscal separation that we wanted of these two components.

🤔 if the coordinator would take care of the fee payments we could include the payment into our protocol, meaning that we will not confirm the trade unless the fees have been paid. However, if we let the coordinator manage the fees we might not get the fiscal separation that we wanted of these two components.

This is true but we want to avoid this.

❓ I am wondering if separating the coordinator and orderbook is really a good idea. Respectively if the trader initiated flow will fit to that fee flow.

Let's keep the separation for now and revisit in 3 months.

❓ I guess it also goes into the question what the orderbook charges for. Would we also charge the trader if the match turns out not to be working? E.g. one side is not accepting. If not we would need more coupling between the coordinator and the orderbook, which leads to the original question. 😅

Then let's just not fail during the execution ;)

What do we think about this now? @bonomat @da-kami @holzeis

What do we think about this now? @bonomat @da-kami @holzeis

I've updated the description slightly. I think it has a high priority to start charging fees.

Sounds like a duplicate to #577


Calypso should not switch to instance side when select extended class

https://pharo.fogbugz.com/f/cases/22721/Calypso-should-not-switch-to-instance-side-when-select-extended-class

in v0.14.1


[in-process-integration] Support event publish and use internal image store and container store.

This PR:

Added a new plugin ServicePlugin. The extra layer is especially useful for services which require more than one existing plugins, such as images, tasks etc.
Add internal service implementation for content and snapshot which have proper events published.
Add internal image service.
Add internal container service.

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Close this in favor of https://github.com/containerd/cri-containerd/pull/658


Add python 3 support

The current build failures should be fixed by https://github.com/ChristopherRabotin/bungiesearch/pull/133

Can you rebase off of master (and fix the merge conflict) to confirm that the builds succeed. Thanks.

@ChristopherRabotin done!

great way to start the new year, with Python3 support for Bungiesearch, congrats guys

Agreed! And I'll do the PyPi release today.
On Tue, Jan 5, 2016, 02:12 Di Wu<EMAIL_ADDRESS>wrote:

great way to start the new year, with Python3 support for Bungiesearch,
congrats guys
—
Reply to this email directly or view it on GitHub
https://github.com/ChristopherRabotin/bungiesearch/pull/134#issuecomment-168861385
.

:clap: :cake: :fireworks:


font

is there a way to change font to ligatures fonts

You may need to enable them via stylesheet: https://discuss.atom.io/t/new-ligature-font-support-issue/22189


Support for complex array navigation and access

Resolved Issues:

#414: Restricted random float to be between +/-1e307
#401:  Updated Makefile to find the appropriate Python-config, searches in order

python-config
python$(major_version)-config
python$(version)-config

#397:  Updated vpi_user.h and brought in sv_vpi_user.h
#412:  Removed ability of FLI and vhpi to pad/truncate and updated to test to create a BinaryValue() object with the correct number of bits
#393:  Update for consistently accessing all types of arrays and structures (e.g. Arrays, Arrays of Arrays, 2D Arrays, records with arrays, arrays of records with arrays, etc.)

Updated Makefiles to define the simulator for all simulators to allow conditional compile if necessary, i.e. -DIUS, -DALDEC, -DMODELSIM, etc.
New GPI type, the GPI_GENARRAY to be used with generate loops
No longer creates list of handles, i.e. everything is an actual handle in python
Add knowledge of range constraints (not applicable to generate loops)
Indexing now works based on the range defined in the VHDL/Verilog, i.e. sig(31 downto 16) would be indexed like dut.sig[23] mapping to sig(23)
New notion in VPI/VHPI/FLI of pseudo-handles (see below for more details)
Handle complex data types with constants/generics
Restricted gpi_get_handle_by_index() to only check the parent handles interface because indexing should not be crossing Interface boundaries
Updated to look for generate loops before reporting a handle can't be found
Add a fairly complex set of tests to check all capabilities
Clean-up for Handle.py to move a lot of common functionality to base classes

Pseudo-Handles:
Due to differences between the interfaces and even between simulators for the same interface, there was a need to "find" handles that aren't actual VHPI/VPI/FLI handles.  Examples of this include:

generate loops:

All interfaces have handles to the loop_name with the index, i.e. loop[0], loop[1], etc.  When navigating through Python, dut.loop[0], cocotb will look for "loop" under dut.  Some interfaces will find this, some will find it in some conditions but not all and it actually finds a handle to loop[0] and not "loop".  A Pseudo-Handle is created to resolve this ambiguity so dut.loop will return a valid handle and know how to iterate to get the children.

multi-dimensional arrays:

The python interface will only provide one index at a time, but with a multi-dimensional array some interfaces can be provide a handle with fewer indicies then dimensions while other interfaces require all dimensions to be available to get the handle.  Pseudo-Handles are created for the purpose of holding the dimensions until all dimensions are available.
A Pseudo-Handle is created using the "parent" handle and providing a Name that has additional information.  For example:

Assume from python you are navigating through a generate loop, i.e. dut.a.gen_loop[0]

The interface will attempt to find a handle by name for "a" under dut.  The GpiHandle will have name="a" and a handle to "dut.a"
The interface will attempt to find a handle by name for "gen_loop" under "dut.a".  This doesn't exist, but the interface will find the generate loop and create a GpiHandle that has the name="gen_loop" and a handle to "dut.a"

The easiest way to tell if you have a Pseudo-Handle is compare the "name" of the GpiObjHandle with the actual name of the interface handle and if they don't match then it is a Pseudo-handle.
Interface issues:
During my development, I came across several issues with the simulators and their support through the interfaces.  If you look at my tests you can see what functionality isn't tested with each interface and simulator.

VPI does not support navigating complex data types for constants and parameters.  This really seems to be lacking in the standard more so then lacking support from the vendors.
VPI detects ports as vpiPort and there is no way that I could find to get the actual type.  This is an issue for types other than vpiReg types.
VPI-NCSIM couldn't write a two-dimensional array.
VPI sees an integer port as a 32-bit register and not an integer
VPI doesn't find a structure when iterating
VHPI-Aldec doesn't find signals defined in generate loops when iterating only
VHPI-Aldec segfaults when "reading" the value of a sub-element of a constant or generic

Here are issues I opened with Aldec:

Issue
Description
Status

SPT73814
Unhandled exception caught while executing callback handler$dumpvars() causes a SEGV when complex parameters and localparams are present, i.e. parameters of type structure
Pending Implementation

SPT73842
SEGV errorVerilog signal:wire [2:4][7:0] sig_t7Looking through VPI for name sig_t7[2][3] results in a SEGV and sig_t7[2] is a handle to vpiNetBit and not vpiNet
Pending Implementation

SPT73828
Cannot iterate over "pliRange" of the "pliNet" non-array objectVPI requires different approaches to access the pliRange attribute
Patch Delivered

SPT73829
vpiMember does not return a valid iteratorA handle to vpiStructVar does not return a valid iterator for vpiMember
Patch Delivered

SPT73850
Array of unpacked structures element - incorrect type obtained by VPIArray of structures is seen a vpiArrayVar, but after getting an index, the type returned was vpiBitVar and not vpiArrayVar
Patch Delivered

SPT73851
vpi_handle_by_index to vpiStructVar member do not workAccessing an array inside of a structure returns an unknown type rather than the expected vpiReg
Patch Delivered

SPT73889
vhpi_get_value from complex generic - SIGSEGVNavigating throug a constant that is a complex type, i.e. a record, causes a SEGV when attempting to access the data
Patch Delivered

SPT73892
Iterating for "vhpiSigDecls" on a handle of type "vhpiForGenerateK" returns nothing Newly declared signals are not found when iterating over vhpiForGenerateK types
Pending Implementation

Testing:
Changes were tested with both Python2 and Python3.  All tests were run and passed with Questa, IUS, Aldec across all interfaces for each simulator.

@stuarthodgson @chiggs
It looks like Icarus is SEGV'ing on a lot of these tests.  While I could test on three major simulators, we don't have access to Icarus at our company.  Could you let me know what is causing the issue?  I am sure it is something with my adding in support for some SystemVerilog types or an un-handled vpi call.  That code should be easy to remove if I just know what is causing the issues.

@leftink I'll have a look into and over the huge amount of work you have done. Thanks

@stuarthodgson and @chiggs It was the bug in the Makefile causing the SEGV issue.  I am working to get the test_array to work with Icarus now and then all test should be passing.

@stuarthodgson At this point everything is passing and I have updated everything based on your comments.  If you have anything else, let me know.

@stuarthodgson and @chiggs,
I will try to hold off submitting any more changes until you get this approved.  The last commit for #417 was a fix that I am getting ready to use and it has a dependency on all of these changes so I wanted to go ahead and get it pushed through with this.

Thanks @leftink, really great contribution very much appreciated!