Issue in generating normal maps from SDK

Good evening, I am trying to generate a normal map using Compressonator but finding some issues, the normal maps show some artifacts, although they work just fine from the GUI here a comparison:
From SDK

From GUI

The options seem to be the same and both are recognized as BC3_TYPELSS if I open them with render doc here the Compressonator gui config:

Here the code I use to generate the normals:
  int w;
  int h;
  unsigned char *data = getTextureDataFromFile(path, &w, &h);

  CMP_Texture srcTex;
  srcTex.dwSize = sizeof(CMP_Texture);
  srcTex.dwWidth = w;
  srcTex.dwHeight = h;
  srcTex.dwPitch = w * 4;
  srcTex.dwDataSize = w * h * sizeof(unsigned char) * 4;
  srcTex.format = CMP_FORMAT_RGBA_8888;
  srcTex.pData = data;

  CMP_FORMAT format = CMP_FORMAT_DXT1;
  getFormatFromString(formatString, format);

  //===================================
  // Initialize Compressed Destination
  //===================================
  CMP_Texture destTexture;
  destTexture.dwSize = sizeof(destTexture);
  destTexture.dwWidth = srcTex.dwWidth;
  destTexture.dwHeight = srcTex.dwHeight;
  destTexture.dwPitch = 0;
  destTexture.format = format;
  destTexture.dwDataSize = CMP_CalculateBufferSize(&destTexture);
  destTexture.pData = (CMP_BYTE *)malloc(destTexture.dwDataSize);

  //==========================
  // Set Compression Options
  //==========================
  CMP_CompressOptions options = {0};
  options.dwSize = sizeof(options);
  options.fquality = 0.05f;
  options.dwnumThreads = 8;

  CMP_ERROR cmp_status =
      CMP_ConvertTexture(&srcTex, &destTexture, &options, nullptr, NULL, NULL);
  if (cmp_status != CMP_OK) {
    free(srcTex.pData);
    free(destTexture.pData);
    SE_CORE_ERROR("Compression returned an error {0}", cmp_status);
    return false;
  }

I can confirm that the format gets correctly set to CMP_FORMAT_DXT5.
Any idea on why that might be the case?
Please find here the two textures:
https://1drv.ms/f/s!Ai0n7iKmKMz0gbUQlxM-LeP_FMHCjA

@giordi91  Thanks for the detailed information. The issue is currently under investigation.

@giordi91
The  sample leftShoulderNormalWrong.dds is been compressed using BC1 instead of BC3 (DXT5)
You need to check that destTexture.format = format; is correct and not defaulting to DXT1

@giordi91
The following test was performed and it cannot reproduce the issue you have!,
SDK Example code supplied in Compressonator 3.1.4064\examples\example1\SDK_Example1.sln  was built and a DDS BGRA sample source was used with the following command line: (please note that in future releases v3.2 and above, Codecs DXT5  and less will expect image sources as RGBA file formats)
Example1.exe leftShoulderNormal_BGRA.dds leftShoulderNormal_dxt5.dds  DXT5 0.05
It produced the attached results
leftShoulderNormal.zip

I am 100% sure I am using DXT5, I checked in the debugger right before compressing:

I am also sure the data I am loading is RGBA since I am specifying that to stbi_image:
 unsigned char *cpu_data =
      stbi_load(path, outWidth, outHeight, 0, STBI_rgb_alpha);

Interesting enough I don't seem to see a difference if in the resulting image if I set "CMP_FORMAT_RGBA_8888" or "CMP_FORMAT_ARGB_8888" I get the same result. Weirdly enough.
To be sure I have hardcoded the out format to DXT5. I also tried with BC3 and got the result you can find attached.
DXT5:

BC3:

I will have a look again at the sample, but I am 90% sure that is where I got the code from. I might also try to modify the sample to read from STBI_IMage from a bmp, that is what I am doing.
Here the link of the images, including a zoom out on the blocky:
https://1drv.ms/f/s!Ai0n7iKmKMz0gbd1v_bo6DKmV0PExw
Here below the full code if might be more of use:
#include "processTexture.h"

#define STB_IMAGE_IMPLEMENTATION
#include "stb/stb_image.h"

#include "DirectXTex/DirectXTex.h"

#include "Compressonator/Header/Compressonator.h"
#include "DDS_Helpers.h"
#include "SirEngine/log.h"

#include <unordered_map>

const std::unordered_map<std::string, CMP_FORMAT> STRING_TO_FORMAT{
    {"DXT1", CMP_FORMAT_DXT1},
    {"DXT3", CMP_FORMAT_DXT3},
    {"DXT5", CMP_FORMAT_DXT5},
    {"DXT7", CMP_FORMAT_BC7}};

const std::unordered_map<std::string, DXGI_FORMAT> STRING_TO_DXGI_FORMAT{
    {"DXT1", DXGI_FORMAT_BC1_UNORM},
    {"DXT3", DXGI_FORMAT_BC3_UNORM},
    {"DXT5", DXGI_FORMAT_BC3_UNORM},
    {"DXT7", DXGI_FORMAT_BC7_UNORM}};
const std::unordered_map<std::string, DXGI_FORMAT> STRING_TO_DXGI_FORMAT_GAMMA{
    {"DXT1", DXGI_FORMAT_BC1_UNORM_SRGB},
    {"DXT3", DXGI_FORMAT_BC3_UNORM_SRGB},
    {"DXT7", DXGI_FORMAT_BC7_UNORM_SRGB}};

inline unsigned char *getTextureDataFromFile(const char *path, int *outWidth,
                                             int *outHeight) {
  unsigned char *cpu_data =
      stbi_load(path, outWidth, outHeight, 0, STBI_rgb_alpha);
  if (cpu_data == nullptr) {
    SE_CORE_ERROR("Could not read image: {0},path");
    return nullptr;
  }
  return cpu_data;
}

void getFormatFromString(const std::string &formatString,
                         CMP_FORMAT &outFormat) {
  auto found = STRING_TO_FORMAT.find(formatString);
  if (found != STRING_TO_FORMAT.end()) {
    outFormat = found->second;
  }
}

bool processTextureFile(const char *path, const char *outPath,
                         const std::string &formatString, bool gamma) {
  int w;
  int h;
  unsigned char *data = getTextureDataFromFile(path, &w, &h);

  CMP_Texture srcTex;
  srcTex.dwSize = sizeof(CMP_Texture);
  srcTex.dwWidth = w;
  srcTex.dwHeight = h;
  srcTex.dwPitch = w * 4;
  srcTex.dwDataSize = w * h * sizeof(unsigned char) * 4;
  srcTex.format = CMP_FORMAT_RGBA_8888;
  srcTex.pData = data;

  CMP_FORMAT format = CMP_FORMAT_BC3;
  getFormatFromString(formatString, format);

  //===================================
  // Initialize Compressed Destination
  //===================================
  CMP_Texture destTexture{};
  destTexture.dwSize = sizeof(destTexture);
  destTexture.dwWidth = srcTex.dwWidth;
  destTexture.dwHeight = srcTex.dwHeight;
  destTexture.dwPitch = 0;
  // destTexture.format     = destFormat;
  destTexture.format = format;
  destTexture.dwDataSize = CMP_CalculateBufferSize(&destTexture);
  destTexture.pData = (CMP_BYTE *)malloc(destTexture.dwDataSize);

  //==========================
  // Set Compression Options
  //==========================
  CMP_CompressOptions options = {0};
  options.dwSize = sizeof(options);
  options.fquality = 0.05f;
  options.dwnumThreads = 8;

  CMP_ERROR cmp_status =
      CMP_ConvertTexture(&srcTex, &destTexture, &options, nullptr, NULL, NULL);
  if (cmp_status != CMP_OK) {
    free(srcTex.pData);
    free(destTexture.pData);
    SE_CORE_ERROR("Compression returned an error {0}", cmp_status);
    return false;
  }

  //==========================
  // Save Compressed Texture
  //==========================

  if (cmp_status == CMP_OK) {
    // SaveDDSFile(outPath, destTexture);

    // lets find the right format to use
    if (gamma && formatString == "DXT5") {
      free(srcTex.pData);
      free(destTexture.pData);
      SE_CORE_ERROR("Error in saving texture, cannot use DXT5 and gamma: {0}",
                    path);
      return false;
    }

    DXGI_FORMAT outFormat;

    if (gamma) {
      auto found = STRING_TO_DXGI_FORMAT_GAMMA.find(formatString);
      if (found == STRING_TO_DXGI_FORMAT_GAMMA.end()) {
        free(srcTex.pData);
        free(destTexture.pData);
        SE_CORE_ERROR(
            "Error in saving texture, format not supported with gamma {0}",
            formatString);
        return false;
      }
      outFormat = found->second;

    } else {
      auto found = STRING_TO_DXGI_FORMAT.find(formatString);
      if (found == STRING_TO_DXGI_FORMAT.end()) {
        free(srcTex.pData);
        free(destTexture.pData);
        SE_CORE_ERROR("Error in saving texture, format not supported {0}",
                      formatString);
        return false;
      }
      outFormat = found->second;
    }

    DirectX::Image img;
    img.width = destTexture.dwWidth;
    img.height = destTexture.dwHeight;

    size_t rowPitch;
    size_t slicePitch;
    DirectX::ComputePitch(outFormat, img.width, img.height,
                          rowPitch, slicePitch);
    img.rowPitch = rowPitch;
    img.slicePitch = slicePitch;
    img.pixels = destTexture.pData;
    img.format = outFormat;
    DWORD flags = 0;
    std::string outPathS{outPath};
    std::wstring outPathW{outPathS.begin(), outPathS.end()};
    HRESULT res = DirectX::SaveToDDSFile(img, flags, outPathW.c_str());

    free(srcTex.pData);
    free(destTexture.pData);
  }
  return true;
}

On the other end, color images seem perfectly fine, so I am inclined to exclude issues in saving the image.

@giordi91
A running application using your code sample has been setup.
Note on your sample:  unsigned char *data = getTextureDataFromFile() loads RGBA data.
when using v3.1 SDK  release binaries,   srcTex.pData  should be BGRA  , it has been corrected in the master branch when using DXTn <= 5, but the CMP_FORMAT_RGBA_8888; vs CMP_FORMAT_BGRA_8888 in CMP_Texture is still been ignored and it will be fixed for v3.2 release.
There seems to be no issues with your code sample.  The original source samples are needed to further the analysis.

Thank you for getting back to me, so you are saying, for now, BGRA will work on DXTn <=5 and RGBA won't work until 3.2 hits release right? What about DXT6-7? Will it still require  BGRA?
I will write a quick swizzle from RGBA -> BGRA and see if that fixes it.
Do you need anything else from me to help in your analysis? I am not sure if I have to send something over from reading your last sentence.
Thanks a lot for the help!

@giordi91
BGRA will work on DXTn <=5 and RGBA won't work until 3.2 hits release right?
Yes, if you can't wait for the release just build the current master source it has the swizzle fix.
What about DXT6-7? Will it still require BGRA?
No, those work with RGBA
Do you need anything else from me to help in your analysis?
Yes, please post the original left hand normal image for us to debug with.

Here it is the original texture:
https://1drv.ms/u/s!Ai0n7iKmKMz0gbgnvq6rMt-CbtFmLg
Thank you

@giordi91
Thanks for the sample image.   Attached is the example code (modified source) that generated a dxt5.dds  file in an attached  zip file. (issue67.zip with exe debug_md x64 build and image sample), this code does not show any major artifacts for the sample leftShoulderNormal.bmp
#define STB_IMAGE_IMPLEMENTATION
#include "stb/stb_image.h"
#include "DirectXTex/DirectXTex.h"
#include "Compressonator.h"
#include "DDS_Helpers.h"
#include <unordered_map>
const std::unordered_map<std::string, CMP_FORMAT> STRING_TO_FORMAT{
{"DXT1", CMP_FORMAT_DXT1},
{"DXT3", CMP_FORMAT_DXT3},
{"DXT5", CMP_FORMAT_DXT5},
{"DXT7", CMP_FORMAT_BC7}};
const std::unordered_map<std::string, DXGI_FORMAT> STRING_TO_DXGI_FORMAT{
{"DXT1", DXGI_FORMAT_BC1_UNORM},
{"DXT3", DXGI_FORMAT_BC3_UNORM},
{"DXT5", DXGI_FORMAT_BC3_UNORM},
{"DXT7", DXGI_FORMAT_BC7_UNORM}};
const std::unordered_map<std::string, DXGI_FORMAT> STRING_TO_DXGI_FORMAT_GAMMA{
{"DXT1", DXGI_FORMAT_BC1_UNORM_SRGB},
{"DXT3", DXGI_FORMAT_BC3_UNORM_SRGB},
{"DXT7", DXGI_FORMAT_BC7_UNORM_SRGB}};
inline unsigned char *getTextureDataFromFile(const char *path, int *outWidth,
int *outHeight) {
unsigned char *cpu_data =
stbi_load(path, outWidth, outHeight, 0, STBI_rgb_alpha);
if (cpu_data == nullptr) {
printf("Could not read image: %s",path);
return nullptr;
}
return cpu_data;
}
void getFormatFromString(const std::string &formatString,
CMP_FORMAT &outFormat) {
auto found = STRING_TO_FORMAT.find(formatString);
if (found != STRING_TO_FORMAT.end()) {
outFormat = found->second;
}
}
void RGBA_to_BGRA( CMP_Texture  texture)
{
unsigned char *pixels = texture.pData;
unsigned char pix;
for (int i=0; i < texture.dwDataSize; i+=4) {
pix = *pixels;
*pixels = *(pixels+2);
*(pixels+2) = pix;
pixels += 4;
}
}
bool processTextureFile(const char *path, const char *outPath,
const std::string &formatString, bool gamma) {
int w;
int h;
// loads RGBA data
unsigned char *data = getTextureDataFromFile(path, &w, &h);
CMP_Texture srcTex = {0};
srcTex.dwSize = sizeof(CMP_Texture);
srcTex.dwWidth = w;
srcTex.dwHeight = h;
srcTex.dwPitch = w * 4;
srcTex.dwDataSize = w * h * sizeof(unsigned char) * 4;
srcTex.format = CMP_FORMAT_RGBA_8888;
srcTex.pData = data;
RGBA_to_BGRA(srcTex); // CMP_v3.1 and lower requires BGRA regardless of srcTex.format setting for DXT5 and lower!
CMP_FORMAT format = CMP_FORMAT_BC3;
getFormatFromString(formatString, format);
//===================================
// Initialize Compressed Destination
//===================================
CMP_Texture destTexture{};
destTexture.dwSize = sizeof(destTexture);
destTexture.dwWidth = srcTex.dwWidth;
destTexture.dwHeight = srcTex.dwHeight;
destTexture.dwPitch = 0;
// destTexture.format     = destFormat;
destTexture.format = format;
destTexture.dwDataSize = CMP_CalculateBufferSize(&destTexture);
destTexture.pData = (CMP_BYTE *)malloc(destTexture.dwDataSize);
//==========================
// Set Compression Options
//==========================
CMP_CompressOptions options = {0};
options.dwSize = sizeof(options);
options.fquality = 0.05f;
options.dwnumThreads = 8;
CMP_ERROR cmp_status =
CMP_ConvertTexture(&srcTex, &destTexture, &options, nullptr, NULL, NULL);
if (cmp_status != CMP_OK) {
free(srcTex.pData);
free(destTexture.pData);
printf("Compression returned an error %d", cmp_status);
return false;
}
//==========================
// Save Compressed Texture
//==========================
if (cmp_status == CMP_OK) {
// lets find the right format to use
if (gamma && formatString == "DXT5") {
  free(srcTex.pData);
  free(destTexture.pData);
  printf("Error in saving texture, cannot use DXT5 and gamma: %s",
                path);
  return false;
}

DXGI_FORMAT outFormat;

if (gamma) {
  auto found = STRING_TO_DXGI_FORMAT_GAMMA.find(formatString);
  if (found == STRING_TO_DXGI_FORMAT_GAMMA.end()) {
    free(srcTex.pData);
    free(destTexture.pData);
    printf("Error in saving texture, format not supported with gamma %s",formatString.c_str());
    return false;
  }
  outFormat = found->second;

} else {
  auto found = STRING_TO_DXGI_FORMAT.find(formatString);
  if (found == STRING_TO_DXGI_FORMAT.end()) {
    free(srcTex.pData);
    free(destTexture.pData);
    printf("Error in saving texture, format not supported %s",formatString.c_str());
    return false;
  }
  outFormat = found->second;
}

DirectX::Image img;
img.width = destTexture.dwWidth;
img.height = destTexture.dwHeight;

size_t rowPitch;
size_t slicePitch;
DirectX::ComputePitch(outFormat, img.width, img.height,rowPitch, slicePitch);
img.rowPitch = rowPitch;
img.slicePitch = slicePitch;
img.pixels = destTexture.pData;
img.format = outFormat;
DWORD flags = 0;
std::string outPathS{outPath};
std::wstring outPathW{outPathS.begin(), outPathS.end()};
HRESULT res = DirectX::SaveToDDSFile(img, flags, outPathW.c_str());

free(srcTex.pData);
free(destTexture.pData);

}
return true;
}
int main(int argc, const char* argv[])
{
processTextureFile("leftShoulderNormal.bmp","dxt5.dds","DXT5",false);
return(0);
}
issue67.zip

Thank you so the only issue ends up to be the BGRA vs RGBA?
I am going to test this asap since I am out of town at the moment.

@NPCompress I have tried both manually to modify my code and to copy paste your entire code (except main) and this is the result I got:

Although I am able to run your executable and get the correct result. I am building the library manually using cmake, the only thing I can think of is if I am somehow building it wrong? Can you think on top of your head anything that might affect the quality of the texture?
Left is the result from the SDK, right is a result from the GUI (same config as earlier, DXT5 format everything else default).
The color appears to be swapped, as it still expects/uses RGBA, not BGRA, and you can still see the blocks artifacts in the

@giordi91  Since your building the code from source, you do not need to swizzle the channels as the fix is in the GitHub master source.
It's still puzzling why you see quality differances from building the library and running the GUI. The GUI essentially uses the library to compress the textures.

@NPCompress  I am not building from this repo at this point in time, I made a fork in January to which I committed my CMake build file.
I just made a dummy application with your code, if I link to the installed SDK version I get your result if I link to my built version of the SDK I get the red/blocky result.
In the end, the blockiness seems to be a build issue on my side of compressonator.lib. I will look into that to figure out what is going on there. I can close this issue or keep it open if you want to know what the build issue is.

@NPCompress in order to debug this, I compiled the lib using the provided visual studio solution and I am still seeing the same problem, two things I had to change, first I changed MTd to MDd second I am using Visual Studio 2017 so I had to update the project (v141).
I will see if I can install VS2015 and re-try everything to see if it is an issue with 2015 vs 2017.

I installed vs 2015 on another machine I have, compiled the vs solution provided and linked against the test application you have posted. Still get the blocky issue, please find attached the lib:
https://1drv.ms/f/s!Ai0n7iKmKMz0gbopR3tFzZLwUil7Xw
This lib has been built with the provided visual studio solution, not my custom CMake build, literally:

clone
open in vs 2015
build
link to test app
run
blocky result

If I link instead against the pre-compiled lib coming from the SDK installer all works fine.
I have almost run out of ideas, the last thing I will do will be to also compile the test application with vs 2015 and see if anything changes.
I suppose the visual studio solution is the same you use for your internal development?

@giordi91 Puzzling that you still have an issue with this. !!
For the posted sample source, VS2015 was used for the test along with the release version v3.1.4064 SDK libs.
When you cloned did you use the master source or the source.zip of the release.?
"I suppose the visual studio solution is the same you use for your internal development?"
Yes: for internal development we use VS2015.

The one I linked above was from my forked copy of Compressonator, which was from January or so. I am now trying to do a clean clone from master build using VS solution provided and link to the test application. I will get back to you in a little

Ok,I have run all the possible tests I could think of... I still get the blocky issue. Pleaes find here attached the test solution I have used:
https://1drv.ms/f/s!Ai0n7iKmKMz0gb5MZ3-yMg4s7mnm-Q
you just need to copy the image in the same path of the executable to run it. The solution is setup in debug only and should compile out of the box. I have provided two libraries :

Compressonator_MDdFromMaster.lib : which is just a pure clone, build from provided solution on VS 2015
Compressonator_MDFromSDKInstall.lib is the one copied from compressonator SKD install more specifically Compressonator 3.1.4064.

If you link the same test application against the lib provided by the SDK it works.  If you recompile against the one compiled from master it gets blocky.
I have tried to compile both lib and test app with vs 2015, compile only the lib with 2015 and test app with 2017 and finally full 2017, I still get the same issue. The visual studio 2015 version I am using is configured like this:

This is my vs 2015 version:

The reason I am writing all of this is that my idea was a possible disparity between vs2015 and vs2017. It seems not to be the case, as of now I have run out of ideas. I am not sure how to reproduce this any further. Seems to happen no matter what machine I build on. Can you build on any other machine or different version of visual studio? I really wonder what is going on there.

@giordi91  Thanks for the sample project files for debugging.
The following tests will be performed on my dev system using VS2015.
Baseline the issue using your sample pre-built libs:
Compressonator_MDFromSDKInstall.lib: Your test shows no issues
Compressonator_MDdFromMaster.lib: Your test shows issues
Next step:
(1) Rebuild the SDK v3.1.4064 lib using the published release sources: https://github.com/GPUOpen-Tools/Compressonator/archive/v3.1.4064.zip
(2) Rebuild the libs using the master branch source
A. Validate that the issues still remain between the two sources.
B.  if issues are repoduced, then determine the root cause of issue
C. if no issues then cause might be an external lib issue and or build setups
Will get back to you soon on the results

@giordi91
FYI: These platform setups are used for the lib builds: (It should not make any diffrence!, but its anther thing to eiliminate from the list of causes!)

@giordi91
The baseline test is now completed.
The issue was reproduced from the supplied SDK binaries using your project file.
The issue was not reproduced when building from source:
https://github.com/GPUOpen-Tools/Compressonator/archive/v3.1.4064.zip  (works)
The issue is reproduced using the Master source (block artifacts)
The root cause is been investigated and the fix will be posted in master source. In the meantime, I would suggest that you build your projects using the v3.1.4064 lib sources link above, and enable the RGBA_to_BGRA() in your sample.
DXT5 No issues when libs built from  v3.1.4064 lib source

DXT5 Blocking artifact seen from the master source build

Amazing!! I am glad we finally managed to reproduce on both sides! If there is anything else I can do to help please let me know.
M


Chinese tranditional  zh_HK version

chinese tranditional version

Ok! Only one thing is missing:
Please also add this to the settings.js :)

just changed :)

You changed it on a new branch on your fork, instead of this one. So i cherry-picked that change to the correct-branch for you :)
Looks good now! Thanks :)

Thank you :)
Sorry I am not that familiar with github /coding : (


Sample app link is just GitHub repo

Text says to go download the sample app, but link just takes you to the repo. I’ve been unable to find the sample app download.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 09c65565-6de2-1fec-86c9-b64d6bb8f807
Version Independent ID: 09c65565-6de2-1fec-86c9-b64d6bb8f807
Content: Getting Started with the .NET Multi-platform App UI (.NET MAUI) Community Toolkit - .NET Community Toolkit
Content Source: docs/maui/get-started.md
Product: dotnet-communitytoolkit
GitHub Login: @bijington
Microsoft Alias: joverslu

You make a good point. I can correct the statement to make it clearer that it would require downloading the source code from the repository, building and running. Or something to that effect.
I'm assuming you were expecting to be able to download an application that you could just run?


Orgmode issues with calendar and +popup-mode

What did you expect to happen?
I use org mode schedule functionality (SPC m s). Usually this opened up a popup with calendar picker. However I've recently changed my configs a bit and now the whole org file gets overwritten with the calendar. So apparently for some reason the popup doesn't open in new buffer. Disabling +popup-mode solves the issue.
Now, I'm not sure this is a bug in emacs doom or something with my config. I didn't do any popup modifications. Would you have some hint on what is wrong here? It's bit tricky to debug because there is no apparent error thrown.
I'm using the recent develop branch.

Sorry for the late response. Are you able to reproduce this in vanilla Doom (on C-c C-p)? I can't reproduce this in vanilla or full Doom, with or without +popup-mode, so I suspect it's a configuration issue.
Could you also supply your M-x doom/info and a link to your private config?

I seem to have come across the same problem, which happens when I use golden-ratio, per your recommendation in #2225, and goes away when I remove it.

Indeed! When I turn off the golden-ratio package, popups work fine. Wouldn't have guessed this without your help @bdarcus .

I do wonder where the problem is though. A bug in golden-ratio? A config
limitation in the doom integration? Something else?
On Mon, Feb 24, 2020, 2:09 AM CGenie<EMAIL_ADDRESS>wrote:

Indeed! When I turn off the golden-ratio package, popups work fine.
Wouldn't have guessed this without your help @bdarcus
https://github.com/bdarcus .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hlissner/doom-emacs/issues/2438?email_source=notifications&email_token=AAAAI3Q66CP2X7SS5CAO4W3RENXCJA5CNFSM4KMF65Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWZXGI#issuecomment-590191513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAI3VTAW7ZO2EI4R7FWVTRENXCJANCNFSM4KMF65ZQ
.

This may simply be an incompatibility between the two. Both golden-ratio and the popup manager are trying to manage windows. I'm a bit swamped at the moment, but I'll look into it as soon as I can.

Just a thought, would it be easy to disable golden-ratio-mode for popups only?


Authenticator calculator when Microsoft Authenticator uses domain as name field, it should be Tyle

All authenticators should have correct name
All authenticators should have tyle logo

There is no shortfix on this issue. Closing this task.


Feature: add select box

Description

Add select box for user to get the ticket status for specified sport

Preview

Hi @arthur791004
Thank you so much !!
This repo does not include transpiler like typescript or babel.
Could you change ES6 arrow function to ES5 function syntax ?
I would accept and deploy once modified, thanks again.

Hi @Asing1001
I have changed to use ES5 function syntax.
Thanks.

Thank you so much !


[INLONG-1838] Public components perfect for use in pulsar

Title Name: [INLONG-XYZ][component] Title of the pull request
where XYZ should be replaced by the actual issue number.
Fixes #1838
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Codecov Report

Merging #1842 (c5ee65d) into master (14fb846) will decrease coverage by 0.42%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1842      +/-   ##
============================================
- Coverage     11.96%   11.53%   -0.43%
- Complexity     1048     1050       +2
============================================
  Files           399      400       +1
  Lines         33466    34789    +1323
  Branches       5276     5504     +228
============================================
+ Hits           4003     4014      +11
- Misses        28695    30009    +1314
+ Partials        768      766       -2

Impacted Files
Coverage Δ

...he/inlong/tubemq/client/consumer/RmtDataCache.java
24.16% <0.00%> (-13.18%)
:arrow_down:

.../tubemq/client/factory/TubeBaseSessionFactory.java
53.76% <0.00%> (-4.38%)
:arrow_down:

...tubemq/client/factory/TubeMultiSessionFactory.java
39.28% <0.00%> (-3.03%)
:arrow_down:

...e/inlong/tubemq/client/consumer/ClientSubInfo.java
14.47% <0.00%> (-2.20%)
:arrow_down:

...bemq/server/common/heartbeat/HeartbeatManager.java
36.36% <0.00%> (-2.03%)
:arrow_down:

...ubemq/client/factory/TubeSingleSessionFactory.java
32.50% <0.00%> (-1.72%)
:arrow_down:

...ng/tubemq/client/consumer/BaseMessageConsumer.java
6.25% <0.00%> (-0.09%)
:arrow_down:

...q/client/consumer/SimpleClientBalanceConsumer.java
0.00% <0.00%> (ø)

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
45.70% <0.00%> (+0.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14fb846...c5ee65d. Read the comment docs.


fallback path & sample timing implemented

VA and VAAPI naming contains very obscure differences.

VAAPI is "compound" feature, it requires

libva
Intel OCL
libva-drm
All of them are covered by Intel MSS, and detected together as VAAPI.
Fallback path implementation also requires VA, but without MSS. So we
need to separate VA and VAAPI features. VAAPI still depend on VA also.

On 08/31/2015 11:26 AM, Alexander Alekhin wrote:

|VA| and |VAAPI| naming contains very obscure differences.
—
Reply to this email directly or view it on GitHub
https://github.com/Itseez/opencv/pull/5272#issuecomment-136298738.

I believe that enabling of WITH_VAAPI should force WITH_VA=ON parameter.

It's so, see OpenCVFindLibsVideo.cmake, line 327
On 08/31/2015 12:56 PM, Alexander Alekhin wrote:

I believe that enabling of WITH_VAAPI should force WITH_VA=ON parameter.
—
Reply to this email directly or view it on GitHub
https://github.com/Itseez/opencv/pull/5272#issuecomment-136319961.

Please detect features in dependency order (current code may report detection of VA-API without VA):
if(WITH_VA OR WITH_VAAPI)
  ...
endif()

if(HAVE_VA AND WITH_VAAPI)
  ...
endif()

Detection of VAAPI is actually detection of MSS, which contains of Intel
OCL/iHD driver, Intel libva, libva-drm, mfx (latter isn't used for
interop core/sample purposes). All of these are parts of MSS and for
interop must be installed together. It's critical for interop to use
iHD, libva & libva-drm of corresponding versions from one MSS
installation. So, logically VAAPI is not depends on VA - VA is a part of
VAAPI, indeed. But fallback path implementation uses VA in abscence of
VAAPI, so VA was separated from VAAPI (in this case, it can be any VA
implementation/version).
On 08/31/2015 04:20 PM, Alexander Alekhin wrote:

Please detect features in dependency order (current code may report
detection of |VA-API| without |VA|):
|if(WITH_VA OR WITH_VAAPI) ... endif() if(HAVE_VA AND WITH_VAAPI) ...
endif() |
—
Reply to this email directly or view it on GitHub
https://github.com/Itseez/opencv/pull/5272#issuecomment-136368762.

Please squash commits into one (there are unnecessary intermediate changes)

done
On 09/04/2015 02:32 AM, Alexander Alekhin wrote:

Please squash commits into one (there are unnecessary intermediate
changes)
—
Reply to this email directly or view it on GitHub
https://github.com/Itseez/opencv/pull/5272#issuecomment-137601355.

@avershov Please squash commits when the patch is ready.


Update OWASP dependency-check-maven to 5.2.4

Coverage remained the same at 48.545% when pulling ba7cd742182f3b306dd2680e639388b0b3a7bc75 on sepe81:update-owasp into dfbacfc26a0a354c5a883b8f0314472b592161de on apache:master.


Implement CoffeeLint

http://www.coffeelint.org
Should be run before submitting any new content: coffeelint .

Is it run by travis?

@groupsky commented on 23 jun. 2015 09:50 CEST:

Is it run by travis?

Am not sure about that one. Will do a Google search...

How can I forget, yes it does: https://travis-ci.org/Hackafe/atom-sync-settings/builds/67956936#L108-L118 (sorry have to wake up).

in that case :+1:


example light.ts doesn't work

Example examples/simulated-light/light.ts doesn't work
- tsc light.js fails

/examples/simulated-light/light.ts works now


filer delete directory cache when delete directory throught api

i think it is a bug, reproduce method：
1、create a file：curl -F file=@abc "http://localhost:8888/dir/"
2、delete file and dir：
a）curl http://localhost:8888/dir/abc    -X DELETE
b)  curl http://localhost:8888/dir    -X DELETE
3、create file again：curl -F file=@abc "http://localhost:8888/dir/"
4、list dir curl http://localhost:8888/dir  -H "Accept: application/json"
and you would get 404
i think the reason is cacheDirectory，i would be fix by delete cache when delete dir

i add a cacheDelDelDirectory in func (f *Filer)DeleteEntryMetaAndData can fix this bug

send a pull request?

https://github.com/chrislusf/seaweedfs/pull/686


[xbvr] Add new chart

Description of the change

Add chart for XBVR - a tool for managing your VR porn collection.
Benefits

New chart.
Possible drawbacks

N/A
Applicable issues

N/A
Additional information

Checklist

[ ] Chart version bumped in Chart.yaml according to semver.
[X] Title of the PR starts with chart name (e.g. [home-assistant])
[X] Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

Thanks @CoolMintChocolate ! Please move this into the stable folder and make the chart version 1.0.0.

@onedr0p will do! Out of curiosity what's the incubator folder used for? I'd have thought that new charts must go through that first before getting promoted to stable.

It was mainly an idea of helm charts that would require a lot of custom configuration that don't play nice with the our common chart. I know we haven't specified this anywhere but the majority of helm charts can go directly to stable.

I've made the requested changes to move the chart to stable folder and made the version 1.0.0.

Sorry it took so long, thanks again!

@all-contributors please add @CoolMintChocolate for code


TileⓇ emulation feature?

What about having the Riley also act as a Tile locator? Here is a library that might help.
https://github.com/bachya/pytile

This could be more of an option, for v2, which is nrf52 based.


Postback check for 'greetings' & 'help' and payload consistency for postbacks and quick replies

Why are we doing this?
Closes #38
This PR ties up some loose ends on how postbacks are handled by checking the postback payload against the greeting and help regular expressions if enabled. Persistent menu clicks are emitted as postbacks and the SDK was not catching requests for help that originated from a persistent menu.
Additionally, while text events normalized the user provided content by trimming whitespace and converting to all lower case; postbacks and quick replies were emitting payloads (as text) without this normalization. This PR emits the text in postback and quick replies as normalized text and adds a payload attribute that is the unmodified payload.
Did you document your work?
Yes, README updated!
How can someone test these changes?
Steps to manually verify the change:

npm i
npm t

Optionally, link to an existing bot and make sure said bot still works as expected:

npm link
npm link launch-vehicle-fbm wherever the test bot resides
run and exercise the test bot

What possible risks or adverse effects are there?
An omission from the functionality is that the text events that are emitted from actual text (not payloads or quick replies) do not emit the unmodified text sent by the user, only the normalized text. Having this as the payload would be confusing as it would break the consistent association of payload with the unmodified content of a postback or quick reply. Thus, the payload attribute of the text event is not always sent.
What are the follow-up tasks?
None.
Are there any known issues?
None identified.
Did the test coverage decrease?
No, new capability is covered.

How would I write an echo bot that used the text event to echo back the original text?

The application would have to use the message.text event, which was also the case before this PR.

waiting on the updates to plain old message.text to match postback and quickReply

Now I cannot remember what we discussed...
If we standardize on text = normalized and payload = non normalized here's what need changing to be consistent:

message.text would change from sending text to payload
in the block below, add payload to the text event; change text to payload in the message.text event

    if (text) {
      debug('text user:%d text: "%s" count: %s seq: %s',
        senderId, text, session.count, message.seq);
      this.emit('text', new Response(this, {event, senderId, session, source: 'text', text: text.toLowerCase().trim()}));
      this.emit('message.text', new Response(this, {event, senderId, session, text}));
      return;
    }

waiting on the updates to plain old message.text to match postback and quickReply

This is good to go now, anything else @crccheck?

⬆


CustomersPresence is mandatory in TransactionCreate constructor while it's an optional parameter

The constructor of TransactionCreate has an optional parameter for CustomersPresence while it is being enforced.
This should be enforced via the signature of the constructor.

We will change that. Currently the parameter is required. However as you have noticed correctly we set it with a default value when you do not provide one. This will be included in the next release.

Well to be precise the default value will be null and thus be blocked but I presume you will handle this in the future.
Honestly I think it should be merged in as the SDK is broken to a certain degree.

The CustomersPresence is now made optional in 1.0.2 release. If it's not provided it will default to VIRTUAL_PRESENT. We will also update the documentation on our website, to clarify this behaviour.

Thanks, closing as this has been fixed!


new: composite action

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: FedeDP
Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold while i experiment :D

/unhold
CI is fine ;)

/hold

Also, please note that composite actions do not support boolean inputs :rofl:

/unhold


Tidy example CLI usage

Change "-" to "--" for named parameters.
Remove spaces inside "[ option ]" for optional parameters.
Fix "pdf-mod-info --dump file" to match usage message.

Interesting story about this...it was a actually a production tool used at my previous job, written by a different developer, which I was allowed to take when they let me open source qpdf. I guess I never really looked at it that closely. Thanks.


9.x branch tests are failing.

Laravel Version: 9.x
PHP Version: 8.1
Database Driver & Version: Postgre 14

Description:
Content up on 9.x branch is breaking tests.

Steps To Reproduce:
composer install
vendor/bin/phpunit

You need to install the gmp extension.

how we can install gmp ? and if we want to install it with docker how we can install it? I tried many ways but they failed.

how we can install gmp ? and if we want to install it with docker how we can install it? I tried many ways but they failed.

apt-get install libgmp-dev
docker-php-ext-install gmp


Bug - app Edge WebView2 Runtime: Fails to update

Even if the update is run with admin it fails to update.
The cause could be if the user first attempts to update without admin so it erroneously fails even when admin is used afterwards (WingetUI says it was successful, but it's not).
Running winget upgrade --all in PowerShell works consistently.

This is a winget thing, and much can't be done about that


Change Bootstrap way of theming.

Please do work for this task in a branch named issue-004.
Use CSS variables to change the default bootstrap theme.

Not sure what the best way to change the --bs-* variables is.
Currently using body to override them.


Supports extrusion property for more entity types.

I was wrong, they actually have this attribute.

I resubmitted the code and updated the comments.

Ok I need to do some tests before merging


Revert some more changes when storage type change is attempted

Type of change

Bugfix
Enhancement / new feature
Refactoring

Description
When storage type change is tried for a running cluster, we should revert also the SecurityContext and the Init containers. In the past we reverted only the volumes.

@tombentley We set the PodSecurityContext only for persistent storage (it is not needed for ephemeral). And if don't revert it, it would a) cause a rolling update when the storage type is changes (because it will change in the model) and b) it could cause some issues with accessing the disc (we will run persistent volume without setting the fsGroup).


Hover effect doesn't appear after clicking on bonds or atoms

Steps to Reproduce

Select bond tool
Add bond to canvas
Don't move the cursor

Actual behavior
There is no hover effect on the bond
Expected behavior
Bond has hover effect without moving a cursor

NOTE: this is relevant not only for bonds, but for atoms as well
Looks like the hover effect is always hidden after clicking on canvas. We would like to keep the hover effect w/o having to move the mouse after click.


Container Status Remaining "Waiting" While Deploying DICOMCast

I've deployed DICOM Cast successfully. And performed all the steps of Sync Medical Imaging Server for DICOM metadata into FHIR Server for Azure. But unable to get the corresponding FHIR resources in FHIR service.
Here is the detailed container log:
info: Microsoft.Health.DicomCast.TableStorage.Features.Storage.TableServiceClientInitializer[0]
      Created Table named 'TransientRetryExceptionTable'
info: Microsoft.Health.DicomCast.TableStorage.Features.Storage.TableServiceClientInitializer[0]
      Table Storage and tables successfully initialized
info: Azure.Identity[1]
      DefaultAzureCredential.GetToken invoked. Scopes: [ https://dc2healthdataservice-dc2fhirservice.fhir.azurehealthcareapis.com ] ParentRequestId:
info: Azure.Identity[1]
      EnvironmentCredential.GetToken invoked. Scopes: [ https://dc2healthdataservice-dc2fhirservice.fhir.azurehealthcareapis.com ] ParentRequestId:
info: Azure.Identity[3]
      EnvironmentCredential.GetToken was unable to retrieve an access token. Scopes: [ https://dc2healthdataservice-dc2fhirservice.fhir.azurehealthcareapis.com ] ParentRequestId:  Exception: Azure.Identity.CredentialUnavailableException (0x80131500): EnvironmentCredential authentication unavailable. Environment variables are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/environmentcredential/troubleshoot
info: Azure.Identity[1]
      WorkloadIdentityCredential.GetToken invoked. Scopes: [ https://dc2healthdataservice-dc2fhirservice.fhir.azurehealthcareapis.com ] ParentRequestId:
info: Azure.Identity[3]
      WorkloadIdentityCredential.GetToken was unable to retrieve an access token. Scopes: [ https://dc2healthdataservice-dc2fhirservice.fhir.azurehealthcareapis.com ] ParentRequestId:  Exception: Azure.Identity.
 (0x80131500): WorkloadIdentityCredential authentication unavailable. The workload options are not fully configured. See the troubleshooting guide for more information. https://aka.ms/azsdk/net/identity/workloadidentitycredential/troubleshoot
info: Azure.Identity[1]
      ManagedIdentityCredential.GetToken invoked. Scopes: [ https://dc2healthdataservice-dc2fhirservice.fhir.azurehealthcareapis.com ] ParentRequestId:

To resolve this issue I've set environmental variables such as AZURE_CLIENT_ID, AZURE_TENANT_ID, and AZURE_CLIENT_SECRET while deployment via Azure with OSS.
After successfully setting the environment variables, The container state remains "waiting".

DefaultAzureCredential will go through different types of authentication until it finds one that works - https://learn.microsoft.com/en-us/dotnet/azure/sdk/authentication/?tabs=command-line#exploring-the-sequence-of-defaultazurecredential-authentication-methods
So its not failing on EnvironmentCredential or WorkloadIdentityCredential, but just moving on to the next credential. It looks like it finally uses ManagedIdentityCredential and stops there.
https://github.com/microsoft/dicom-server/blob/main/converter/dicom-cast/docs/authentication.md - see these docs for more options on how to set up authentication

Thank you for your reply,
As you describe here, DefaultAzureCredential  uses ManagedIdentityCredential
As per the documentation I've followed all the steps and still facing this error.

We are still facing issues with the sample application implementations.
Followed the documentation, I've followed all the steps and still facing this https://github.com/microsoft/dicom-server/issues/3045.
Is there any other way or possibility that you can help ?

Hello @jnlycklama
We are still facing issues with the sample application implementations.
Followed the documentation, I've followed all the steps and still facing this https://github.com/microsoft/dicom-server/issues/3045.
Is there any other way or possibility that you can help ?


KeyError:api

Code:
from plugnplai import Plugins[ 5] :
plugins = Plugins.install and activate(urls)
Error
Http Error: 404 Client Error: Not Found for url: https://api. speak, com/%5c.wel1-knowm/ai-plugin. jsor
KeyErrorTraceback (most recent cal1 last)AppData\Local\Temp/ipykerne1_7340/3447704211.py in l from plugrplai import Plugins
---> 3 plugins = Plugins.install and activate(urls)
E: Program Files (x86)Anaconda lib site-packagesiplugnplai plugins.py in instal1-and activate(cls, urls, template)213@classmethod214def install_and_activate(cls, urls: List[str], template: str = template_gpt4):--> 215instance = cls(urrls. templatel216for plugin name in instance.installed plugins.keys:217instance.activatelplugin namel
E: Program Files (x86)Anaconda lib site-packages plugnplai plugins.py in -init-(self, urls, template)209self.tokens = None210--> 211self.instal1 plugins(urls
212213@classmethod
E: Program Files (x86)Anaconda lib site-packages plugnplai plugins.py in instal1 plugins(self, urls,226def instal1 plugins(self, urls: List[str]]:227228I>
for url in urls:
manifest, openapi spec = spec from url(ur1)
openapi_object = PluginObject(openapi spec manifest!self.installed plugins[openapi_object.name for_model] = openapi_object
229230
E: Program Files (x86)Anaconda liblsite-packagesiplugnplailutils.py in spec from url(ur1)102 def spec_from url(ur1):
103
manifest = get_plugin manifest(ur1)
--> 104
openapi url = get_openapi url(url, manifest
105
openapi_spec = get_openapi_spec(openapi ur1)
106return manifest, openapi_spec
E: Program Files (x86)Anaconda lib site-packages plugnplailutils.py in get openapi url(url, manifest)75 # load the OpenAPI specification for the plugin, given the OpenAPI url described in the manifest file
76 def get_openapi ur1(ur1, manifest):
77
openapi urrl = manifest[rapi"][ur1*if openapi_ur1.startswith("/:
18
remove slash in the end of url if present
79
KeyError:api

I tried to reproduce the error, but I couldn't. Could you try plugins = Plugins.install_and_activate(['https://api.speak.com']) to see if this url is working?

Hope it worked for you. Closing once we couldn't reproduce the error


Eap test for jbqa11437

Test for https://issues.jboss.org/browse/JBQA-11437
https://bugzilla.redhat.com/show_bug.cgi?id=1192467

Looks like your commits are not based on the master branch

Some mistake. Here is new pull request https://github.com/wildfly/wildfly/pull/7294


start problem for signed apks

Hello,
I have a problem, when starting of the Appium on real device.
I faced with this Error after click Start Sessions.
Error
An unknown server-side error occurred while processing the command. Original error: Error executing adbExec. Original error: 'Command 'C:\Users\25200038\AppData\Local\Android\Sdk\platform-tools\adb.exe -P 5037 -s TQC000200003470401 install -r 'C:\Program Files\Appium\resources\app\node_modules\appium\node_modules\appium-uiautomator2-server\apks\appium-uiautomator2-server-v4.21.1.apk'' exited with code 1'; Stderr: 'adb: failed to install C:\Program Files\Appium\resources\app\node_modules\appium\node_modules\appium-uiautomator2-server\apks\appium-uiautomator2-server-v4.21.1.apk: Failure [INSTALL_FAILED_VERIFICATION_FAILURE]'; Code: '1'
My real device doesn't accept unsigned apk files or something because of security.
When I realized that, I just signed all of the files below to solve the problem.
 settings_apk-debug.apk
 app-debug-androidTest.apk ,
 appium-uiautomator2-server-debug-androidTest.apk
 appium-uiautomator2-server-v4.21.1.apk

and then, I replaced them with the unsigned ones. After that I wrote  'adb install' on Windows Power Shell to check them if they were correct or not.
The Windows Power Shell showed me :
  ''Performing Streamed Install
  Success''

I thought 'this time I succeed on it.' But it was not happened.
When I clicked Start Session with correct information which Appium need ( deviceName, appActivity, appPackage, platformName).
Same Error occurred again.
Error
An unknown server-side error occurred while processing the command. Original error: Error executing adbExec. Original error: 'Command 'C:\Users\25200038\AppData\Local\Android\Sdk\platform-tools\adb.exe -P 5037 -s TQC000200003470401 install -r 'C:\Program Files\Appium\resources\app\node_modules\appium\node_modules\appium-uiautomator2-server\apks\appium-uiautomator2-server-v4.21.1.apk'' exited with code 1'; Stderr: 'adb: failed to install C:\Program Files\Appium\resources\app\node_modules\appium\node_modules\appium-uiautomator2-server\apks\appium-uiautomator2-server-v4.21.1.apk: Failure [INSTALL_FAILED_VERIFICATION_FAILURE]'; Code: '1'
Like I didn't sign any apk. or I didn't change anything.
After got the same error I checked the Windows Power Shell to see the differences. I faced with the same failed massage at the beginning.
I realized that Appium change the signed files with the beginning ones. It replaced files with the unsigned ones.
It didn't let me make some changings.
I don't know why ?????
HOW CAN I FİX THİS PROBLEM?
IS THERE ANYONE COME ACROSS A PROBLEM LİKE THAT ?
screenshots below,

........

Is it related to scrcpy in any way?

How can I get that it is related to scrcpy or not ?

Is it related to scrcpy in any way?

How can I get that it is related to scrcpy or not ?

You're asking a random question as an issue on the scrcpy repo. If it's not about scrcpy, this is not the good place to ask your question.

Hi I am Dilek's colleagues.
Actually it is not about the scrcpy, the problem is about signed/not signed apps. Appium install some applications when start session. The device rejects to install unsigned apps, all apps must be signed by our team. Even if Dilek changes the all apps with signed ones, When Session is started, Appium overwrites files  by unsigned ones and this causes to installation problem.

this is more of an adb issue, because dragging and dropping an apk just does it directly through adb's install command, but try seeing if any of these solutions work https://stackoverflow.com/questions/15014519/apk-installation-failed-install-failed-verification-failure


Arguments not recognized --console-focus-follow --stream-websockets

Problem Description
The arguments  --console-focus-follow --stream-websockets are not recognized in my tests neither by mitmproxy nor by mitmweb.
Both options are documented on https://docs.mitmproxy.org/stable/concepts-options/ and you can enable in the web interface of mitmweb, but passing on the console fails. (And yes, I've triple-checked to get the rewrite from _ to - correctly.)
Steps to reproduce the behavior:

With a saved file mitmproxy --rfile ./mitmproxy-flow.cap -n  --console-focus-follow --stream-websockets
OR, with mitmweb: mitmweb --anticomp --anticache --mode transparent --web-port 1234 --save-stream-file "+$FLOWSAVE" --web-host <IP_ADDRESS>  (where $FLOWSAVE is a file path)

System Information
$ mitmproxy --version
Mitmproxy: 5.2
Python:    3.7.3
OpenSSL:   OpenSSL 1.1.1d  10 Sep 2019
Platform:  Linux-5.4.51-v7l+-armv7l-with-debian-10.4

It seems that we can't set --console-focus-follow and --stream-websockets directly.
Instead, we can do --set console_focus_follow=true --set stream_websockets=true.
"mitmproxy --rfile ./mitmproxy-flow.cap -n --console-focus-follow --stream-websockets" <- this doesn't work
=> "mitmproxy --rfile ./mitmproxy-flow.cap -n --set console_focus_follow=true --set stream_websockets=true" <- this works

What @gorogoroumaru said - that's also mentioned at the top of the page you linked. :)

Whaaat? By why does setting --anticomp work then – which is a boolean option??
IMHO this is not a good UX – if some options can be set in one way and other'S in another one… :thinking:

If you really want to keep it that way, maybe adjust the error message to give a hint like "Do you possibly miss, using '--set'?"…


Revert "Merge pull request #583 from burke/andrew-debounce-better"

The new debouncing strategy is still not quite what we want. We really
want to stop all services until changes have stopped and then start them
all again. This change makes things worse by leaving old code running longer.
This reverts commit f1d59a855f69b5afee5d67e71c669ab35cfefefe, reversing
changes made to c55b133d5379c2b14511c67c3dfcfc413b40cf28. Note that I excluded the changes to Travis configuration from the revert.

r? @russelldavis

👍


ffmpeg: add tensorflow dnn backend support

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] (ongoing) Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@Atemu should withTensorflow be enabled when withFullDeps is set?

(Noticed https://github.com/NixOS/nixpkgs/pull/225464 while reviewing this. Whoops.)

@Atemu targeted staging.


fix for #550, #551

@IlyaVi @avive
Just realized an edge case that my current design doesnt handle optimally.
Currently, removal process looks like:

User clicks delete button. This passes the address/nickname of that contact down to actions.js
In actions.js, removal is processed. It's done using Array.filter on the contacts array, checking for exact match against the address/nickname passed from delete button and filtering those elements out

I've tested this design in the naive case. However, if duplicate contacts exist (could be a case in which user adds a contact, but contact already exists. Then the user wants to delete the duplicate only) the current design removes both contacts. I'll change this to a Array.splice based removal instead which should cover this edge case

Reopening PR - there's a check when creating contacts to ensure nicknames are unique so the edge case mentioned above won't apply


punks not dead

Thanks //

HI / I filed two days ago, today it will be three days /Why does this
happen ...? I see that many collections go quickly ... should I pay you to
make it faster??
help me solve the problem . thank you.[image: Screenshot_1.jpg]
https://github.com/ordinals-wallet/ordinals-collections/pull/1215
пн, 13 мар. 2023 г. в 22:16, MillHaus33 @.***>:

Merged #1078
https://github.com/ordinals-wallet/ordinals-collections/pull/1078 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/ordinals-wallet/ordinals-collections/pull/1078#event-8736099355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASPQWYXJEZM4CAOSOZRTTJ3W356BDANCNFSM6AAAAAAVYJNJFY
.
You are receiving this because you authored the thread.Message ID:
<ordinals-wallet/ordinals-collections/pull/1078/issue_event/8736099355@
github.com>


Update the browser support

The current browsers we are supporting are updated.
https://www.pivotaltracker.com/story/show/165377239

I did revert the package-lock.json


Plugin broken in Netbox 3.3

After hitting the search button you get an error:
<class 'django.core.exceptions.FieldError'>
Cannot resolve keyword '_termination_a_device_id' into field. Choices are: _abs_length, color, created, custom_field_data, id, journal_entries, label, last_updated, length, length_unit, status, tagged_items, tags, tenant, tenant_id, terminations, type
Python version: 3.9.2
NetBox version: 3.3.0

+1 same error:
`<class 'django.core.exceptions.FieldError'>
Cannot resolve keyword '_termination_a_device_id' into field. Choices are: _abs_length, color, created, custom_field_data, id, journal_entries, label, last_updated, length, length_unit, status, tagged_items, tags, tenant, tenant_id, terminations, type
Python version: 3.10.6
NetBox version: 3.3.5`

also this error:
FieldError at /plugins/nextbox-ui/site_topology/
Cannot resolve keyword '_termination_a_device_id' into field. Choices are: _abs_length, color, created, custom_field_data, id, journal_entries, label, last_updated, length, length_unit, status, tagged_items, tags, tenant, tenant_id, terminations, type
Request Method:	GET
Request URL:	https://sub.domain.tld/plugins/nextbox-ui/site_topology/?site_id=6
Django Version:	4.0.8
Exception Type:	FieldError
Exception Value:
Cannot resolve keyword '_termination_a_device_id' into field. Choices are: _abs_length, color, created, custom_field_data, id, journal_entries, label, last_updated, length, length_unit, status, tagged_items, tags, tenant, tenant_id, terminations, type
Exception Location:	/opt/netbox/venv/lib/python3.8/site-packages/django/db/models/sql/query.py, line 1677, in names_to_path
Python Executable:	/opt/netbox/venv/bin/python3
Python Version:	3.8.10
Python Path:
['/opt/netbox/netbox',
'/opt/netbox',
'/opt/netbox/venv/bin',
'/usr/lib/python38.zip',
'/usr/lib/python3.8',
'/usr/lib/python3.8/lib-dynload',
'/opt/netbox/venv/lib/python3.8/site-packages']

I have the same issue on version 3.3.5.
Version 3.3.0 changed some internal variables which broke this plugin.

When will this be fixed, are they working on this?

I have tried to solve some of the bugs with this plugin.
Works fairly well with netbox version 3.3 and above.
The display topology does not error out.
There are still alot of small bugs with CSS styling and the Save Current View function.
https://github.com/Qwiko/nextbox-ui-plugin

Using @Qwiko patch it still errors on when there are power connections.
   File "/opt/netbox/venv/lib/python3.10/site-packages/nextbox_ui_plugin/views.py", line 499, in get      topology_dict, device_roles, multi_cable_connections, device_tags = get_topology(self.queryset)    File "/opt/netbox/venv/lib/python3.10/site-packages/nextbox_ui_plugin/views.py", line 377, in get_topology      if b_termination.device_id in device_ids:    AttributeError: 'PowerFeed' object has no attribute 'device_id'

@geniesis I now filtered out PowerFeed cabling and that should resolve the issue.
A PowerFeed does not have a Device id and can't be displayed.

As there is no reaction at all since two months, I suppose this project is not being maintained anymore. There are also other major bugs open that are even older. I have therefore switched to netbox-topology-views, which (in my optinion) became a better replacement in the meantime  anyway.

how to correctly remove this plugin? i switch to https://github.com/mattieserver/netbox-topology-views too.

Hi everyone.
Sorry for not responding so much time. I was immigrating to another country and rebuilding by life.
Hopefully I'll return to the plugin development and fix this compatibility issue soon.

Hi everyone.
Sorry for not responding so much time. I was immigrating to another country and rebuilding by life. Hopefully I'll return to the plugin development and fix this compatibility issue soon.

эх.. а кому щас легко. Удачи на новом месте :)

Hey. New plugin version v0.10.0 fixes compatibility issue with NetBox 3.3. It's already available here and on PyPI.


satellite not coming

Hi there,
it looks like you did not download the TLE data which is severed along with the application.
You can do so with npm run update-tle as mentioned in the README.md.
Hope this helps!


Clear Inputs

Current dsb function requires a raw and filtered inputs. It can be misleading what this function does. Propose to name inputs:

adata_filtered
adata_background

Also, propose to add a test if any barcodes overlap. If there is an overlap, remove the overlap from background and inform the user about this.

Here, we're not taking the background data, though. We're taking in the raw data and getting the background ourselves. This is because, usually the data that people will have is the filtered and raw values; asking them to provide the background would require them to do some data manipulation themselves, which we are already doing here.
As for the overlapping barcodes, because we are expecting raw data, there should be overlapping barcodes (which would be the filtered data)


Jump/Ground Pound Bug Of DEATH

Randomly, the player will be stuck in a state where they jump very high and the ground pound "doesn't work" anymore on slopes. No known replication steps yet... but if you play the game longer than 5 minutes you will run into it.

fixed in 2.0 gg ez


Translated into Chinese

Hi, Matt
Our translation team had translated these tips into Chinese.
https://github.com/jobbole/jquery-tips-everyone-should-know/blob/master/README_zh.md

Thank you for doing this. There will be ongoing updates to the repo, which will require the translations to continue. I'm trying to determine if it's practical to have.

Sure, we will continue to translate :)

Thanks for the offer. If I decide in the future that this would be a good use case for a repo I'll connect with you on that.


log not outputting source

Bug Report
What version of Rust are you using?

What operating system and CPU are you using?

What did you do?
Run TiKV
What did you expect to see?
2018/06/22 22:16:24.725 pd.rs:437: [INFO] [region 4128085] try to change peer RemoveNode id: 4604857 store_id: 53
2018/06/22 22:17:23.736 pd.rs:437: [INFO] [region 4128085] try to change peer RemoveNode id: 4604857 store_id: 53
2018/06/22 22:18:22.467 pd.rs:437: [INFO] [region 4128085] try to change peer RemoveNode id: 4604857 store_id: 53
2018/06/22 22:19:20.896 pd.rs:437: [INFO] [region 4128085] try to change peer RemoveNode id: 4604857 store_id: 53
2018/06/22 22:20:19.209 pd.rs:437: [INFO] [region 4128085] try to change peer RemoveNode id: 4604857 store_id: 53

What did you see instead?
Jun 29 20:00:43.749 INFO [region 2] on split region at key t\200\000\000\000\000\000\000\377\027\000\000\000\000\000\000\000\370.
Jun 29 20:00:43.749 INFO [region 2] 3 epoch changed conf_ver: 1 version: 10 != conf_ver: 1 version: 9, retry later
Jun 29 20:00:43.850 INFO [region 2] on split region at key t\200\000\000\000\000\000\000\377\027\000\000\000\000\000\000\000\370.
Jun 29 20:00:43.850 DEBG scheduling task ask split region 2 with key t\200\000\000\000\000\000\000\377\027\000\000\000\000\000\000\000\370
Jun 29 20:00:43.850 DEBG loop poll - 145.552154ms
Jun 29 20:00:43.851 DEBG loop time - Instant { t:<PHONE_NUMBER>85656 }
Jun 29 20:00:43.851 DEBG loop process - 1 events, 18.385µs
Jun 29 20:00:43.851 DEBG executing task ask split region 2 with key t\200\000\000\000\000\000\000\377\027\000\000\000\000\000\000\000\370
Jun 29 20:00:43.851 DEBG reconnect remains: 10
Jun 29 20:00:43.851 DEBG loop poll - 7.582µs
Jun 29 20:00:43.851 DEBG loop time - Instant { t:<PHONE_NUMBER>72221 }
Jun 29 20:00:43.851 DEBG request sent: 1
Jun 29 20:00:43.851 DEBG loop process - 1 events, 151.553µs
Jun 29 20:00:43.852 DEBG loop poll - 9.057µs
Jun 29 20:00:43.852 DEBG loop time - Instant { t:<PHONE_NUMBER>43688 }
Jun 29 20:00:43.852 DEBG loop process - 0 events, 11.349µs
Jun 29 20:00:43.852 DEBG loop poll - 221.894µs

Note: source like pd.rs:437 is missing. This will lead to notable inconvenience when tracing issues.

@overvenus @Hoverbear PTAL

Also notice that log date format (Jun 29 20:00:43.852) is different from the rest of the system (2018/06/22 22:16:24.725) and previous ones, which will also introduce many inconvenience when tracing clients' issues.

Duplicated with #3257.

@BusyJay Oh! Thanks!


Rework messages and packets queues.

Description

reworked queues implementation to provides features required by Transport Interfaces
updated Transport Interfaces code to be compatible with new queues implementation

How Has This Been Tested?

unit tests
integration tests
review

Process
I know the process and did my best to follow it

Codecov Report

Merging #167 (6a80aa9) into main (4383050) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           42        42
  Lines         2314      2351   +37
=========================================
+ Hits          2314      2351   +37

Flag
Coverage Δ

integration-tests
84.81% <44.80%> (-0.97%)
:arrow_down:

unit-tests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...port_interface/abstract_can_transport_interface.py
100.00% <100.00%> (ø)

...ransport_interface/abstract_transport_interface.py
100.00% <100.00%> (ø)

...nsport_interface/python_can_transport_interface.py
100.00% <100.00%> (ø)

uds/transport_interface/records_queue.py
100.00% <100.00%> (ø)

uds/transport_interface/transmission_queue.py
100.00% <100.00%> (ø)


⚠ ClamAV has degraded performance

In bb7dbef, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 439 ms

Resolved: ClamAV performance has improved in d89b8be.


Typo in the README.it

There's a typo in the README.it, there's written "pecondition_frequency" instead of "precondition_frequency"

Thanks, fixed it.


HADOOP-17462: Hadoop Client getRpcResponse May Return Wrong Result

The done variable is not marked as volatile so the thread which is checking its status is free to cache the value and never reload it even though it is expected to change by a different thread. The while loop may be stuck waiting for the change, but is always looking at a cached value. If that happens, timeout will occur and then return 'null'.
In previous versions of Hadoop, there was no time-out at this level, so it would cause endless loop. Really tough error to track down if it happens.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 15s

trunk passed

+1 :green_heart:
compile
21m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m  8s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
shadedclient
19m 44s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 21s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 18s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
20m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
20m 50s

the patch passed

+1 :green_heart:
compile
18m  4s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
18m  4s

the patch passed

-0 :warning:
checkstyle
0m 46s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 98 unchanged - 1 fixed = 99 total (was 99)

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 58s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 22s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 55s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

179m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2610/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2610

JIRA Issue
HADOOP-17462

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 916223cd519b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e306f594218

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2610/1/testReport/

Max. process+thread count
2239 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2610/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 15s

trunk passed

+1 :green_heart:
compile
21m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m  8s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
shadedclient
19m 44s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 21s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 18s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
20m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
20m 50s

the patch passed

+1 :green_heart:
compile
18m  4s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
18m  4s

the patch passed

-0 :warning:
checkstyle
0m 46s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 98 unchanged - 1 fixed = 99 total (was 99)

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 58s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 22s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 55s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

179m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2610/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2610

JIRA Issue
HADOOP-17462

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 916223cd519b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e306f594218

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2610/1/testReport/

Max. process+thread count
2239 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2610/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Feat: run id file: some parameters does not need to compute run ID, such as nthreads.

Give a method to define a variable of inputs/outputs that skip run ID computation.
Method A: use Symbol to skip run ID computation.
CmdProgram(
    inputs = ["A", :B]
)

Internal:

CmdProgram and JuliaProgram: new field: result_independent_args::Set

parse_default: put Symbol elements in the new field.

generate_run_uuid: if the arg is in result_independent_args, skip.

changed in v8.2. New Arg type is created to solve this.


ENH: generate numpy scalars or 0D arrays

closes https://github.com/data-apis/array-api-tests/issues/289

Looks good. Can you check the tests with numpy itself, or at least array_api_compat.numpy, and then merge this? It's possible this could uncover some test failures, and we'd want to at least be aware of them if not fix them before merging here.
This is an example of where having numpy tests run on CI could be useful (https://github.com/data-apis/array-api-tests/pull/298). array-api-strict does not use scalars (it internally converts any numpy scalar into a 0-D array), so the CI tests for it won't really say much here.

It's interesting, actually.
With numpy, $ ARRAY_API_TESTS_MODULE=numpy pytest array_api_tests -v shows exactly the same failures locally on main and on the PR:
======================================================================================== short test summary info =========================================================================================
FAILED array_api_tests/test_creation_functions.py::test_asarray_arrays - ValueError: Unable to avoid copy while creating an array as requested.
FAILED array_api_tests/test_data_type_functions.py::test_finfo[float32] - AssertionError: type(out.eps)=<class 'numpy.float32'>, but should be float [finfo(float32)]
FAILED array_api_tests/test_manipulation_functions.py::test_repeat - TypeError: Cannot cast array data from dtype('uint64') to dtype('int64') according to the rule 'safe'
FAILED array_api_tests/test_operators_and_elementwise_functions.py::test_clip - AssertionError: out.dtype=uint16, but should be uint8 [clip(uint8)]
FAILED array_api_tests/test_signatures.py::test_func_signature[argsort] - AssertionError: Argument 'descending' missing from signature
FAILED array_api_tests/test_signatures.py::test_func_signature[sort] - AssertionError: Argument 'descending' missing from signature
FAILED array_api_tests/test_signatures.py::test_func_signature[clip] - AssertionError: Expected argument 'a_min' to be named 'min'
FAILED array_api_tests/test_sorting_functions.py::test_argsort - TypeError: argsort() got an unexpected keyword argument 'descending'
FAILED array_api_tests/test_sorting_functions.py::test_sort - TypeError: sort() got an unexpected keyword argument 'descending'
======================================================================== 9 failed, 989 passed, 16 skipped, 457 warnings in 50.98s

with array_api_compat.numpy though, a small additional fix is needed to avoid
(Pdb) import numpy as np
(Pdb) p np.__version__
'2.1.3'
(Pdb) p np.asarray(np.False_, copy=False)
*** ValueError: Unable to avoid copy while creating an array as requested.
If using `np.array(obj, copy=False)` replace it with `np.asarray(obj)` to allow a copy when needed (no behavior change in NumPy 1.x).
For more details, see https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword.

So, two things to discuss:

could you take a look that https://github.com/data-apis/array-api-tests/pull/310/commits/0f59c216262f23f33e1d59968b19d71899c1d855 makes sense?
how come it's not caught by testing with just numpy, neither locally nor on CI. Just too few examples? testing with $ ARRAY_API_TESTS_MODULE=array_api_compat.numpy pytest array_api_tests -v catches it consistently from the first try.

Merging after an offline discussion with Aaron.


Add support for passive event listeners

This PR adds support for registering event listeners as passive. For some types of events, e.g. scroll events, this can make a substantial difference in performance and responsiveness.

Let me know if there are any other changes I should make.

Thanks, all is good now 👍  Sorry for the delay, I'll merge this when l have time to cut a release, probably in a week or two.

Thanks, no worries.


remove regulates relations between symbiont->host processes and "normal" host processes

There are several relations this covers, e.g.
GO:0052552 modulation by organism of immune response of other organism involved in symbiotic interaction
is_a
GO:0050776 regulation of immune response
and
GO:0052255 modulation by organism of defense response of other organism involved in symbiotic interaction
is_a
GO:0031347 regulation of defense response
Though these seem at first to be obvious logical relations, they are semantically incorrect.  The child terms are used to describe the FUNCTION OF THE SYMBIONT GENE, i.e. what is the function for the symbiont?  But the relations link them to the FUNCTION OF HOST GENES instead, which leads to the incorrect logical inference that the function of the symbiont gene is in the immune response of the symbiont.
These relations are trying to capture the effect on the host, but it cannot be done this way.  Suggest we remove these relations for now.

Doesn't the inference say that the function of the symbiont gene regulates the function of the host gene? I think that is how these were originally intended.

@thomaspd   Does this make sense, or would you still like these removed?

Unfortunately the current usage doesn't specify whether it is the symbiont's or the host's immune system, so it has ambiguous semantics.  More importantly, the term "regulation of immune system process" is far more commonly used to refer to the immune system of the organism that encodes the gene that is being annotated.  So until we can distinguish these cases, it's best to keep with our more commonly used semantics, in this case that regulation of immune system process means regulation of one's own immune system.
We'll be able to make proper statements LEGO.

OK. I removed those parents.


Exclude known-failing mdsroutes test from image build but not guest-a…

…gent build pipelines
/cc @ChaitanyaKulkarni28

/lgtm


change csv delimiter from ; to ,

Hi there,
The current csv files use ; as the delimiter. Generally , is the default delimiter accepted in lot of places and would be helpful to use this csv files in other applications. Apart from that github also helps you render them beautifully in the webpage with search option if its delimited by ,.
Delimited by ,

Delimited by ;

Would be happy to do a pr if approved.

Hi,
Sure, feel free to make a PR for both of the csv file ;-)

CSV can be delimited by ; it depends on your windows or program settings. My settings uses ; for the same reasone expressed here
https://stackoverflow.com/questions/10140999/csv-with-comma-or-semicolon

Great point about GitHub rendering, this would be cool to see.


Component Grouping

fixes https://github.com/slide-rs/specs/issues/155
Restrutures into a workspace of specs and specs_derive.

Can we have the restructurization PR separate from the new functionality please?

You have to use workspace to include the custom derive as it needs to be it's own crate.

I mean, I could have another PR for it if we want, but it would either just be a workspace of "specs" and "specs_derive" (without functionality).

@Aceeri Maybe you could structure it the same way @ebkalderon did in their PR?

@torkleyy I feel it makes more sense to use a workspace given this is exactly the usecase for it (multiple crates in one repo).

@Aceeri They also implemented it as a workspace, see https://github.com/slide-rs/specs/pull/192/files

Well uh, I have made a mistake so please ignore this for the next couple hours while I go get my backup.

@torkleyy For the WorldSerializer, I just realized why I originally had it. Some serde libraries don't expose Serializer in their interfaces which is annoying, but the only way to serialize with them is to pass in a type that implements Serialize.

@Aceeri I see. It's up to you how you implement it then.

Closing this for now since I'm not sure if it is worth the complexity yet.


Gradle task :dependencyCheckAnalyze gives different result depending on version of AGP

(This is copied from https://github.com/jeremylong/DependencyCheck/issues/6740 where I by accident posted this issue first)
Describe the bug
Running the :dependencyCheckAnalyze gradle task gives different result depending on which version of the android gradle plugin is used. This is despite the dependencies that generate the CVE errors have not changed.
Version of dependency-check used
Using org.owasp:dependency-check-gradle:9.2.0
Also seen this behaviour on 9.0.9
Log file
https://gist.github.com/Pururun/89199a37e9794bac5969193f2a5ed685
To Reproduce
Update to AGP 8.4 or 8.5
Expected behavior
Consistent behaviour regardless of AGP version.
Additional context
Here is our configuration if gradle:
global gradle
allprojects {
   configure<org.owasp.dependencycheck.gradle.extension.DependencyCheckExtension> {
        failBuildOnCVSS = 0F // All severity levels
        suppressionFile = "${rootProject.projectDir}/config/dependency-check-suppression.xml"
    }
}

test gradle
configure<org.owasp.dependencycheck.gradle.extension.DependencyCheckExtension> {
    // Skip the lintClassPath configuration, which relies on many dependencies that has been flagged
    // to have CVEs, as it's related to the lint tooling rather than the project's compilation class
    // path. The alternative would be to suppress specific CVEs, however that could potentially
    // result in suppressed CVEs in project compilation class path.
    skipConfigurations = listOf("lintClassPath")
    suppressionFile = "$projectDir/../test-suppression.xml"
}

Here is the suppress file for the app:
https://github.com/mullvad/mullvadvpn-app/blob/main/android/config/dependency-check-suppression.xml
Suppression file for tests:
https://github.com/mullvad/mullvadvpn-app/blob/main/android/test/test-suppression.xml
I have also tried to move the plugin out of the project file and applying it to each module separately, this did not help.

I ran into this same problem when I updated my AGP version a month or two ago.  I am not really sure what changed in the new version of the AGP but a bunch of configurations were exposed that previously weren't exposed and thus they are getting scanned for vulnerabilities.  I don't really think this is really the fault of this plugin.
I looked back through at older versions of the AGP and I can see that the vulnerabilities were still there.  There is just something different about how things are being compiled and these configurations are now being exposed and scanned when they were not previously.
I also looked ahead at the latest version of the AGP and some of its dependencies and I can see that the vulnerabilities still exist.
Ultimately, it was tedious but we added all of these new issues to our suppression file.  I'd love if the AGP didn't have vulnerable dependencies but there really isn't anything that we could do to fix it other than wait for Google to address it.
Not that this will really help you with your problem or anything - just trying to add more information for discussion.


MAINT: pull aggregator logic out to separate method

for downstream subclassing

See comment on internal repo, I think we can do the needed logic that the sublcass was providing purely from the minute reader interface.

no longer needed.


Close this project and extend the original API instead.

Please improve the original M5Stack API or create a common API to support both the Core 1 and Core 2 instead.
Why?

You have two issue trackers, how will you easily share, address and fix common reported bugs/issues in both projects?
You have two copies of identical source with redundant broken code in this one such as M5.Power. Getting M5Stack API fixed to support the Core 2 will concentrate your mind and make you aware of the issues like these.
It's good practice - any devs like me that need to support builds for both 2 devices now have to put #defines all over our code to swap libraries depending on which device is targeted. This is causing extra work for numerous developers downstream - its trade off between 1 developer (you) or many (us) - that's not developer friendly.
It's causing confusion for newbies - searching for M5Core brings back 2 APIs.
Tests. You haven't got any which means you should write them. You can share them between both devices and save time rather than cut and paste and running two pipelines and fixing them in 2 different projects.
M5Stack the company seems to have a lot of new hardware to support, and therefore a lot of projects. Looking at the delays to releases, bugs not being addressed (e.g. the Atom Matrix) in a timely manner I can only assume you are hopping between projects. If you work on a common project you'll have greater visibility of issue impacts and your customers/devs will see regular updates to builds and issues, instead of giving the appearance of a dead or badly supported project.
I'll provide code/help where I can where I've had to work around a few incompatibilities in my projects to save you time - it's not much and they're workarounds/best effort but it's something.

Apologies for being direct but a large chunk of my current development time is identifying and fixing compatibility issues to do with the above and it's incredibly annoying.

I am in a similar boat in here. Nice hardware, but please also up your software game m5stack!

I am in a similar boat in here. Nice hardware, but please also up your software game m5stack!

+1

+1
It's silly things. You switch from Core to Core2 and suddenly lcd.setBrightness() doesn't work. Suddenly M5Img() can only support PNG and not JPG anymore.

+1
This project uses some weird old version of TFT_eSPI which is pretty unusable (ie the upstream TFT_eSPI version supports way better JPEG decoding through TFT_eFEX). +1000 to everything @KodeMunkie said.

I completely agree; It's a little disingenuous to not support font smoothing in the library (for example) but have implemented it in the factory test code loaded on the device by default, for example. Wishing I had just bought an m5stack now...

How about it then @ropg ? :)

hello guys, if all you need is a single core for many devices, check out the ESP32-Chimera-Core, contributions and PR are welcome :-)

@tobozo Please don't hijack this thread. The third party API you link to doesn't actually support the Core 2 and there don't appear to be any plans to.

hello guys, if all you need is a single core for many devices, check out the ESP32-Chimera-Core, contributions and PR are welcome :-)

@tobozo Please don't hijack this thread. The third party API you link to doesn't actually support the Core 2 and there don't appear to be any plans to.

@KodeMunkie yes it does support M5Core2, thanks for your contribution I'll update the ReadMe now

@tobozo Thanks, I will give it a try.
I had massive problems with the M5Core2 library. A program with Bluetooth BLE client causes reboots then I just added M5.begin()... With a Fire and M5Stack library it works...

Another attempt to combine M5Stack/M5Core/M5StickC+ cores - M5StX. Includes @ropg M5Touch, M5Sound (unmerged) and updated TFT_eSPI with M5_Font_Creator support and unified LcdBrightness and PowerOFF control. Made mostly for my own M5ez/ezTime based project so no complete compatibility intended but can be added.

Currently we have M5Unified, which is compatible with many hosts. Thank you for your feedback.


Issue 93: move spam setting

I tried putting up a button on the screen next to the You are all alone here but it was big and I figured I'd rather...not.
Don't mind the weirdness at the bottom of the gif that's some kinda...weird capture thing.

After linter CSS & label changes here's what it looks like:

Mostly looks good!
Other than the few comments I left, two design thoughts:

We know that people don't want move messages in the theatre. I feel like having messages hidden should be the default behavior.

I think it would be more intuitive if the checkbox was "Always show movement messages" instead of "hide movement messages". Having a checked-off checkbox represent "yes, show me more things" makes more sense to me, and given #1 this also means that the default state would be unchecked instead of checked, which also feels cleaner.

I don't think we should expose the person count variable to players. Just trying to explain that feels like a lot of work, and I feel like finding the optimal value there is our job as designers.

For point 1, sure, can do.
For point 2 - "Always show/Never show" is different from the "Hide all/Hide some" which we have. We have 3 states:
a) Show all messages
b) Show messages when it's not very busy
c) Show no messages
and the current toggle toggles between [b, c] whereas I think the proposed toggle would toggle between [a, c]
I mean I could just change it from a checkbox into a 3-way checkbox thing like with the styles?
For point 3 - what would be a good number? I have 6 right now. Or do we want to just drop it for a binary all/none?

Ahh, interesting point about a/b/c.
Thinking about this more: I suspect almost nobody wants to see enter/leave messages in the theatre. I suspect most people will gain value from join/leave messages in smaller rooms. I'm having a hard time thinking of a use case where either of those will not be true.
This is complicated enough that I think you're right we'd want a 3-way option if we wanted to give people a choice. I increasingly think we just don't want to give people a choice. People who either don't want to see leave/join messages in small rooms, or do want to see them in the theatre, sound like a pretty bad edge case. The only likely design failure we'd be looking at is if we just happen to get the threshold wrong.

I think there's a case for "wait, Alice isn't here anymore? scrolls back up when did Alice leave, did she see that last message(s)?". A simple "show all/show some" toggle would be fine though.
I'm not sure how to set the threshold though.

Yeah, I think that makes sense.
For the threshold: My gut instinct is something like 20? I realistically think what we're designing for is "the theatre vs everything else", so erring on the larger side is probably okay/good.

My reasonably strong threshold for transitioning between "small group" and "large group" modes is 8. See also my proposal to cap video chat at 8 here #284

So, I think the UX expectations here are different from hard capping videochat.
With videochat, erring on a smaller number makes sense for a number of reasons, not the least of which is that we can be very explicit about "sorry, chat is full".
With this, if we do things correctly, people aren't going to consciously notice we've done anything. So the question becomes, if we get the number wrong and people notice, what happens in that fail state.
I think we're better off erring too high, in which case people are slightly annoyed by visual spam, than we are by erring too low, in which case people get confused because they can't tell when somebody leaves.

aren't going to consciously notice we've done anything hmm, I never really thought that was something that was possible? I guess my implicit assumption was that users would definitely notice the presence/lack of movement messages, because it's...pretty hard not to, if any room has them at all.
My sort of thesis is that more than half of all messages in any given feed are going to be movement messages, even in the highest conversation areas, just because:

moving is way easier than talking
by volume, there will be a lot of people, and one person entering and leaving takes up 2 lines. A throughput of even 1 person every 20 seconds makes enough noise to actually match the speed of many text conversations
until they are explicitly drawn into a conversation, people have basically zero stickiness for an individual room, so they'll just sort of hop around looking for something cool

The other thing is, if we only have a "Show All/Show Some" the user can't fix it to show less, they can only fix it to show more, so we should by default err on less.

Thinking of this, perhaps above the threshold a message that comes across that just says something along the lines of "Many people are entering/leaving the [room]", to give a sense of the motion that something is happening and not be abruptly "you can tell who is entering/leaving in room X and now in room Y you can't"? Not sure how that will be to implement!

I absolutely think people won't notice this if our design is correct. People will notice the messages, or lack thereof, if they're disruptive. If they're not, I'm sure you could point out to someone "hey, have you noticed how sometimes the messages show and sometimes they don't?" and they'd recognize it, but design choices like this otherwise tend to fall into the background if they're working the way people sort of intuitively expect them to.
I think a lot about how e.g. Slack's logic about whether to send a notification is unbelievably complicated, but as a user the mental model is purely "I should get a notification whenever it makes sense": https://twitter.com/codevisuals/status/838881724016787457/photo/1
I'm not sure I agree with your thesis, but it's hard to come up with a solid argument that isn't "neither of us has concrete data, but my back-of-the-envelope math is different from yours about what the hypothetical rate of conversation or movement will be".
Another thing that's crossed my mind: there were times in the preview when I felt slightly awkward about leaving a room because of the leave message. Which I think might suggest erring on the side of showing fewer leave messages, but I'm not exactly sure.

@kawa-kitsuragi I think there's one use case there that would be potentially helpful: if I enter a room and then you immediately enter the room before anyone says anything, those two enter messages could theoretically be collapsed into a single "lazerwalker and kawa enter the room" message. I think trying to collapse join/leave messages in any other situation is tricky from a design perspective. Haven't thought through how technically viable this would be to happen on our timescale -- we don't yet have any instances of a message actively being altered after the fact, outside of mods having the ability to delete inappropriate messages.

Since we have differing opinions and so little data: I wonder if it makes sense to store the limit in Redis, and we can raise/lower it based on actually seeing how people behave during the conf?

@kawa-kitsuragi I think there's one use case there that would be potentially helpful: if I enter a room and then you immediately enter the room before anyone says anything, those two enter messages could theoretically be collapsed into a single "lazerwalker and kawa enter the room" message. I think trying to collapse join/leave messages in any other situation is tricky from a design perspective. Haven't thought through how technically viable this would be to happen on our timescale -- we don't yet have any instances of a message actively being altered after the fact, outside of mods having the ability to delete inappropriate messages.

I tried doing that but it was really hard to get it to look half-decent and I gave up. But it's doable! You lose a lot of data with timestamps and stuff but it works.

For now I'll look into storing the value on the server.

Uh, hold on. It looks like it did a bad merge on the Room - still has all the showcases. Ugh.

🎉