Should a cancel a fork if I don't need it at some point?

Description
I'm creating watchers that will fork api events for specific components, at some point those components will be removed from the DOM with componentWillUnmount meaning that the component doesn't need the forked effect anymore, so I'm wondering if there is any benefit canceling the forked effect to flush memory or so?
Is it something I should care about, or somehow this is handled in some other way?
Thank you.

Awesome, that's what I was looking for!
Thanks @shinima


Add Dockerfile, add multi hotspot

Hey,
this implements #7 and #8. I hope you don't mind they are in one PR.
Multi-Hotspot: All changes are backwards compatible to just one hotspot. I've added two arguably helpful tags while at it. Example given.
Docker: @ideasman69 In docker-compose.yaml a user might use this image by something like:
  helium-poller:
    build:
      context: ./helium-dashboard
    image: helium-dashboard:latest
    depends_on:
      - influxdb
    environment:
      INFLUX_HOST: ${MONITORING_HOST}
      INFLUX_PORT: 8086
      INFLUX_BUCKET: helium
      INFLUX_ORG: myorg
      INFLUX_TOKEN: ${INFLUX_WRITE_TOKEN}
      HELIUM_WALLET: ${HELIUM_WALLET}
      HELIUM_HOTSPOT: ${HELIUM_HOTSPOT}

The image has a hardcoded update rate of 30min

Thanks @ThomDietrich - this is exactly what I was after 😄


Severity message generated by lack of bf:creationDate in AdminMetadata

The DCTap for lack of bf:creationDate in big:AdminMetadata lists the desired severity as a "Violation". However, when I tried to validate a description the  resulting violation severity for lack of this property is sh:Info instead of sh:Violation.
I am using the tool with Chrome on a PC.
The work description that I was attempting to validate is:
https://id.loc.gov/resources/works/2079411.html

We have moved away from using bf:creationDate in favor of just bf:date, with a bf:status of "new", so in my opinion this is not a violation.

What I am wondering is if there is any documentation regarding that change and if bf:creationDate will be deprecated? Based on the ontology it still looks like bf:creationDate should be used with admin metadata. If that is not the case we need to update the DCTap and Shacl accordingly, but it would be great to be able to point to something


Updated the document

Updated the doc with the steps guiding the local deployment of external-dns-operator using kind.

/lgtm

/lgtm
/unhold

/approve


Allow cloning Reference objects

Looks good to me! I think CI is failing though?

I'm gonna close this since it's been inactive for some time now, but it can of course be resubmitted!


Add a simple static analysis workflow

This basically just copies the one from Fyne. We might want this before we start merging large PRs.

This is far from perfect. Gocyclo complains about cyclomatic complexity (one of which can probably be ignored) and staticcheck warns about a deprecated method (https://github.com/Jacalz/glfw-js/runs/6285148965?check_suite_focus=true). I don't really know what to do about these so I'll leave this here for you to decide.

The deprecation warning is right, but the point of this binding is to emulate v3, so it is normal that we have the same API as GLFW even if GLFW is marking some of its function as deprecated. Would the warning go away if we marked that API as deprecated in glfw-js too?

If a function is marked as deprecated, then it can use other deprecated API without getting flagged by Staticcheck. But if you have a lot of such functions, it might be more straightforward to just disable that check in the relevant files (see https://staticcheck.io/docs/configuration/#file-based-linter-directives for that.)

Thanks @dominikh. That works great :+1:

The static analysis is now passing: https://github.com/Jacalz/glfw-js/actions/runs/2295779197

Thanks. It’s merged now. Feel free to set the action as required if you want to :)


GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported

Describe the bug
After building darknet_ros following the steps in the README, when I try to launch darknet_ros (roslaunch darknet_ros darknet_ros.launch) I get the following error the second it receives the image feed:
(darknet_ros:22136): Gtk-ERROR **: 11:44:10.920: GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported
To Reproduce
Steps to reproduce the behavior:

Follow the build steps in the README
roslaunch darknet_ros darknet_ros.launch
Error

Expected behavior
I would expect darknet to start using the image feed.
System (please complete the following information):

OS: Ubuntu 20.04
ROS version: Noetic
GPU when relevant: NVidia AGX Xavier

Problem is in the image viewer. Disabling that 'fixes' the problem (at least for me).

I have the same problem.
Could you please tell how to solve it?
THANKS!

Facing same problem, anyone have the solution ?
Thanks


Remove validation webhook for LogPipelines

Description
Out of the experiences gathered, an advanced validation of a pipeline should not be done in a webhook as it takes time, might not be available and anyway need to get repeated at server side again.
Syntactical checks can be done nicely in the CRD definition already.
So the gola is to move all parts of the current webhook to an adequate replacement and get rid of the webhook
Criterias

The webhook is removed
All validation got replaced by adequate replacements

Tasks
- [ ] Move unsupported mode warning
- [ ] Max Pipeline check to be executed on backend side similar to TracePipeline, having proper status change
- [ ] Singleton check for telemetry resource https://github.com/kyma-project/telemetry-manager/issues/555
- [ ] Plugin validation with supported list and hardcoded available plugin list as backend validation feature reflected via status change
- [ ] Missing file/variable reference validation
- [x] Delete dry-run and get manager image free (https://github.com/kyma-project/telemetry-manager/issues/1234)
- [ ] Move API validation into CRD schema validation
- [ ] Delete webhook

Reasons

Attachments

Release Notes

We decided to stay with the validating webhook. The heavy operation of performing dry-runs was removed. We anyway will not get rid of webhooks and the cert mechanism seem to work reliable. So instead we will focus on shifting to OTEL and remove the webhook once we remove fluentbit


Should we simplify the config and get more query data

 level=info msg="networksets not specified in non-nil Resources. Skipping networksets query."
time="2021-06-23T10:48:25Z" level=info msg="secrets not specified in non-nil Resources. Skipping secrets query."
time="2021-06-23T10:48:25Z" level=info msg="events not specified in non-nil Resources. Skipping events query."
time="2021-06-23T10:48:25Z" level=info msg="horizontalpodautoscalers not specified in non-nil Resources. Skipping horizontalpodautoscalers query."
time="2021-06-23T10:48:25Z" level=info msg="e2e-test-crd-publish-openapi-2339-crds not specifi

Lots of resources like that. I made the changes so that we dont have to explicitly list every data type we want to get. I we just provide the empty list I think we get everything (except secrets).
This would make the config much more grockable and then we'd get all the things!
Trivial change I think, just change the default file and golden files. Need to see the impact on size though.

So I ran a few cases and compared them:
-rw-r--r--   1 jschnake  staff   468K Sep 18 08:39 allandkubesystem.tar.gz
-rw-r--r--   1 jschnake  staff   419K Sep 18 08:30 allthethings.tar.gz
-rw-r--r--   1 jschnake  staff   342K Sep 18 08:32 defaultthings.tar.gz
-rw-r--r--   1 jschnake  staff   333K Sep 18 08:34 noresources.tar.gz

No resources to our default is ~10k
Default to all resources is 67k
Adding kube-system logs added 50k
By percentages the 50k and 67k is non-trivial but:

we're talking about KB, not MB or GB. No one will care.
These were quick mode results so the e2e logs are MUCH shorter than a full run. A larger run is consumed by the plugin logs anyways so these do become trivial values.

I say we make both changes so that the query is, by default, the most useful without sacrificing security (want to make sure its clear that we are explicitly not getting secrets).


fixed bookshelf model/migration script bug

@alocke12992 I suspect this was a double whammy of errors. The folders didn't install correctly and then the script didn't exit when it detected something was wrong. Give it a shot by creating or adding a server with Postgres and try to make a model/migration.

When creating a new backend project , and adding a model, the params passed in the console are being used to name the file and generate the model incorrectly. See the photo below;

Looks like I may have found a different bug, after digging into the code a bit I noticed that you're setting table columns to process.argv.splice(3, process.argv.length)  but the data needed to create the columns would come from splitting argv[2]. Here is the console.log of argv:

I've made the bookshelf model script a bit more legible.


[Q] General direction of the image

I have an important question while I try to bend this image to my needs: What is the feature-complete state of this image?
The heroku buildpack for php is a really great source of inspiration in terms of what is possible and needed for running modern, sophisticated php applications on the platform side of things. I am aware that it may slightly conflict with the "many tiny applications"-paradigm Google drives, but I'm curious if you are willing to go towards that direction with this image as well.
I'd like you to take a look at the compile script of the heroku buildpack for php to see some of the features it detects. (https://github.com/heroku/heroku-buildpack-php/blob/master/bin/compile)
I am aware that I can run a docker image with a heroku buildpack on managed vms - but apart from the general, language specific features, I would also expect AppEngine features from the sandbox to get integrated in the future with this image (CloudSQL with a simple socket). If it wasn't for those, I'd just use the one of the heroku flavoured docker images with managed vms.

Greetings, and thanks for the contributions over the last few days.  Our intent is to build a docker base that's usable with Managed VMs, Kubernetes, or any other platform that supports running containers.  We're certainly planning to make it as easy as possible to connect with other Google Cloud services, and we know we have some work to do with hitting feature parity with Heroku.  The truth is, this repository is about a month old :) We're really just getting started.  We made the choice to build this thing in the open, with hopes that folks would help us decide what's important (after getting the core of the thing put together). So for that - we thank you!  As of today - PHP for Managed VMs is still in the experimental stage.  I'm going to update the README to make sure some of this stuff is a little more clear.
Thanks again!

Thank you for the comprehensive answer-exactly what I wanted to know! I hope the question didnt sound too pressing - but you know, time is a somewhat limited good-so I just wanted to check if it fits my needs (apart from the fun part) to push the project forward.
I'm well aware of the age of this repository, but we're about to go full steam with AppEngine and I need to make decisions about where we go and how we get there :)
I finally feel some fresh air in AppEngine regarding PHP.  So let me thank you-this repository is really a good sign for me (as is gcloud-php)!
Regarding the experimental stage of PHP with Managed VMs - I see no problem there. I'm fine with running production loads on MVM as long as the platform-vendor is commited to the project ;)
Thanks to you for developing it in the open. Very appreciated!

Thanks!  We're having a lot of fun with PHP over here right now - I only expect it to get better.  I'm going to go ahead and close this out, but please feel free to keep asking questions, and of course feel free to keep submitting PRs :)


fix correct window size from webui client size. (windows)

I found 'AdjustWindowRect()' function to make correct window size for windows.

Yes, I request newly merge PR #494.
2024년 10월 9일 (수) 오후 10:23, Showns @.***>님이 작성:

Did you close this because it gets replaced by cf0c54e
https://github.com/webui-dev/webui/commit/cf0c54e2bdb5e3308124bff3b7fedfd0457bdd2a
?
—
Reply to this email directly, view it on GitHub
https://github.com/webui-dev/webui/pull/491#issuecomment-2402339347, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQMUIOPNHQFRNTFV4YIFE4TZ2UU4ZAVCNFSM6AAAAABPPAH2FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBSGMZTSMZUG4
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Halcyon.sample.ini causes NullReferenceException crash related to AvatarCurrency

The Halcyon.sample.ini file is missing a definition that causes a NullReferenceException in OpenSim.Region.CoreModules.Avatar.Currency.AvatarCurrency.Initialize() adding [Economy] to the Halcyon.ini config fixes the issue.

Good catch! I'll update the halcyon.sample.ini with an [Economy] section and add some of the definitions that we use here.  e.g. something like:
[Economy]
    ; CurrencyServer = "http://localhost/currency.php"
    LandServer = "http://localhost/landtool.php"

    ObjectCapacity = 45000

    ; Money Unit fee to upload textures, animations etc
    PriceUpload = 0

    ; Money Unit fee to create groups
    PriceGroupCreate = 0

I've added pull request #444 to update the ini file, which doesn't fix the NRE but the sample INI should include this section as well.

I've added EconomyBaseAccount to the sample INI file in #444.

Hi, dear people, my dad did try to figure it out but could find it it is about the last picture or snapshot (a bit off topic) it does not show it on 36 on 37 it did now its just black if you log in again any ideas?
Further as for the [Economy] section is it possible to add Podex?  https://www.podex.com/
Best  Ana Green
And thanks to Bob or Vin for everything :)

Ana, could you post each problem/idea to their own new issues so devs can see and respond to each properly?  Thanks.


Custom icons

Could you make it possible to use custom icons and icon styles (color, size, etc)?

Custom icons would be legendary. Really hoping this feature gets added.


Set up google colab

Fixes #42
Set up google colab

@TomTranter Are we planning to create something similar to https://github.com/pybamm-team/PyBaMM/blob/develop/run-tests.py which will test notebooks and scripts?

What do you think is best for notebooks @priyanshuone6 ?


More proofreading

Mostly issues of punctuation, capitalization, and consistency, but also some minor readability improvements.

I'll go through these in a little bit.

@jhdalek55 I think I've addressed the two points you raised.


Change import location of is_valid_inchikey in pubchem_lookup

Hi Florian,
I noticed that pubchem_lookup.py imports is_valid_inchikey from matchms.utils, but that should be changed to matchms.metadata_utils. The current setup through an import error when trying to use the lookup_metadata_completion function.
Cheers,
Yoann

The issue is resolved. I had two conflicting versions of matchms and matchmsextra. Upgrading to the latest version of both libraries solved it.


Add Istanbul University Student Email

@fatihersndm I am sorry, the domain ogr.iu.edu.tr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


iKnow indexing in genRAW: Time/Frequency/Duration attribute not shown if Measurement attribute in same Concept

The Frequency attribute for 'daily' is missing in the RAW output for the following example:
input:
60 mg daily
-> attributes: attr type="measurement" literal="60 mg daily" token="60 mg" value="60" unit="mg"
The Frequency attribute is however present in the genTrace output:
input:
60 mg daily
-> index="daily" labels="ENCon;ENFrequency(a:Entity,Frequency,);ENInMeasspan;
When the token with Measurement attribute is removed, 'daily' does get the Frequency attribute in the RAW output:
input:
daily
-> attr type="frequency" literal="daily." token="daily."

I updated the title of this issue, including Time and Duration attributes. When a Measurement attribute is present in a Concept, the Time/Frequency/Duration attribute are not shown in the RAW output, but they are shown in the Trace output.
Remark: The combination of Negation, Sentiment and Time attributes doesn't cause a problem.
input:
no good future results
->

Correction of previous comment:
input:
no good future results
->
<attr type="negation" literal="no good future patients" token="no">
<attr type="time" literal="no good future patients" token="future">
<attr type="sentpositive" literal="no good future patients" token="good">

Version 1.0.4 also fixes this Issue#39, @ISC-NLeclercq can you test and confirm that this is working ?
And then close the Issue :-)

Yes, it works. Thank you!


Feature/update 5.6

Implements updates for Android 13 including permissions for BLUETOOTH_CONNECT and POST_NOTIFICATIONS.
Updates compile and target sdk versions to 33.

Requested changes, let me know if you have any questions.


Update managing-expressroute-for-connectivity.md

fix  wrong table syntax

@kelleyvice-msft - PR is ready for final review.  This is just a cosmetic issue.
Thank you.
cc: @kenwith


Add deployment script to set up the MAX3231 RTC

This PR fixes #199.

I've tested this from a fresh RPi image, where I skipped running install.sh and instead only ran deploy/scripts/rtc_setup.sh twice (including a scripted reboot in the middle), disabled Wi-Fi, and then shut down the RPi for several minutes and then booted up the RPi; it successfully received the time from the MAX3231 RTC module.
@rohanpurohit Do you have a MAX3231 module at your end? If not, @renjipanicker do you know if Bharat Forge has one? I believe @hongquanli sent some to Bharat Forge.

I've tested this from a fresh RPi image, where I skipped running install.sh and instead only ran deploy/scripts/rtc_setup.sh twice (including a scripted reboot in the middle), disabled Wi-Fi, and then shut down the RPi for several minutes and then booted up the RPi; it successfully received the time from the MAX3231 RTC module.
@rohanpurohit Do you have a MAX3231 module at your end? If not, @renjipanicker do you know if Bharat Forge has one? I believe @hongquanli sent some to Bharat Forge.

No, I don't @ethanjli, and even if Bharat forge has it, we don't know if/when we'll get it! so maybe it's best if you can merge it and we can test once we get it?

Ok - I will merge this without review, and we can create an issue for it later if there are any problems.
For records-keeping:

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
Were any of these contributions also part of work you did for an employer or a client? No
Does this work include, or is it based on, any third-party work which you did not create? No


intersection syntax (&) is confusing to non-TS developers

During the review on 8/16, the non-TS architects expressed dissatisfaction with some of the syntax inherited from TS:
  @doc("Triggers a job to export a project's data.")
  export is ResourceAction<
    Cadl.Http.AcceptedResponse & Foundations.LongRunningStatusLocation
  >;

There is this brief section in the documentation on intersections (https://github.com/microsoft/cadl/blob/main/docs/tutorial.md#intersections)
One suggestion some though might be more intuitive to non-TS developers would be +
  @doc("Triggers a job to export a project's data.")
  export is ResourceAction<
    Cadl.Http.AcceptedResponse + Foundations.LongRunningStatusLocation
  >;

Ampersand implies "and" more than "+" does, IMO.  I understand that some people don't get the syntax when they first look at it, but this is to be expected when learning any language.  I think the Intersections section of the tutorial could be worded better to make things more clear.

Yeah I think also with the fact that we have | for union feels way more intuitive.

|   -> or
& -> and

We try not to deviate from TypeScript too much when we have parallel concepts and this would be a big breaking change for limited value.


sample code error

Reproduction link
https://ng-zorro-antd-start.stackblitz.io
Steps to reproduce
https://ng.ant.design/components/switch/zh
<nz-switch [(ngModel)]="switchValue">
The correct way of data binding is only [ngModel].However this page is [(ngModel)] and only this one is wrong.
this error is in the first sample code
What is expected?
(- v -)
What is actually happening?
(- v -)

Environment
Info

ng-zorro-antd
8.5.0

Browser
google

If I didn't get you wrong, it's two-way binding syntax. Check this.


test(logger): run integration tests serially

Utilize serial_test crate to run the logger tests serially. Running them in parallel or with --test-threads 1 causes spurious errors.

Yeah, it is still not fixed somehow. I will mark this PR as draft.

Yeah, it is still not fixed somehow. I will mark this PR as draft.

Since this one seems like quite a conundrum, we might leave it as it was for now as well, and focus on something else. I am very curious about why this is failing, though. :smile:
We had some thoughts on potential changes to the logger that would also affect these tests, we can talk about that in the daily tomorrow.


Add Azure SignalR output binding

Description
Add Azure SignalR registration
Issue reference
dapr/components-contrib#147
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation
[ ] Specification has been updated
[ ] Provided sample for the feature

Should we close this one?

Should we close this one?

No, this will merge the SignalR binding into the Dapr runtime. We'll do it after we cut the release for 0.3.0 tomorrow, as we want this and other components updates to make it to 0.4.0.

/ok-to-test

Hey @fbeltrao, since we moved on with the version of components-contrib to a newer version than specified here, I suggest you close this PR and open a new one just with the registration code in the runtime.

Hey @fbeltrao, since we moved on with the version of components-contrib to a newer version than specified here, I suggest you close this PR and open a new one just with the registration code in the runtime.

Hi @yaron2, just for me to understand: what would be the drawback of syncing upstream/master on my branch and pushing the changes?
Do you want me to remove the tests I added?

If you can resolve the conflicts peacefully, that works too :)

/ok-to-test


Doc Type Grid Editor 1.2.3 - Unsaved Changes dialog fires when hitting submit on grid editors

I've just upgraded to the latest version v1.2.3
When I create a new page, choose a grid layout and add a custom grid editor to it on the submit it seems to be firing the
You have unsaved changes Are you sure you want to navigate away from this page? - you have unsaved changes
I click stay and the editor renders fine.
These were working in the previous version and not firing this event.
When the page is already saved this doesnt happen - any ideas how I can prevent this?
Unsure if related Ive the latest version of Matryoshka 0.4.0 installed.

I'm experiencing the same issue.

Hi dont think the problem is with doctypegrid editor I think its the combination of doctypegrid editor and Matryoshka 0.4.0. Just started a project to try debug the situation. No Matryoshka just doctypegrid editor no issue

I've did a clean install of Umbraco with starterkit and added only DoctypeGrid. When i create a new page i get the unsaved changes warning. So i guess Matryoshka  is not interfering for this issue.

When line 283 is commented out,
contentEditingHelper.contentEditorPerformSave(args).then(function (data) {
the dialog doesn't appear. So it looks like contentEditingHelper.contentEditorPerformSave has something to do with it. Maybe this is changed in Umbraco 8.6 and higher.

@mcl-sz what version are you on?

@skttl on version 1.2.3 in combination with Umbraco 8.6.2

I've added the infiniteMode: true option. Now the warning is gone and it works for simple doctypes but not when Nested Content is used in a doctype:
                    // save the content as a blueprint, to trigger validation
                    var args = {
                        saveMethod: contentResource.saveBlueprint,
                        scope: $scope,
                        content: $scope.model.node,
                        create: true,
                        action: "save",
                        showNotifications: false,
                        softRedirect: true,
                        **infiniteMode: true**
                    };

                    contentEditingHelper.contentEditorPerformSave(args).then(function (data) {
                        $scope.model.submit($scope.model);
                        **if (data.id) {
                            $scope.model.node.id = data.id;
                            cleanup();
                        }**

                    },
                    function (err) {
                        // cleanup the blueprint immediately
                        cleanup();
                    });

Thanks for updating @mcl-sz

It looks like there is a problem with validation of a blueprint that contains nested content. When i create a blueprint manualy via the Umbraco backoffice that contains nested content, it is saved even when the nested content contains errors.

The wierd thing is that the popup is only shown when you create a new content node. I compared the args parameter from a already saved document and a new unsaved document and except for the keys they are identical.

Just tried 8.6.4, with DTGE 1.2.3 and Matryoshka 0.4.0.
Created a doc type with a Nested Content property.
Added the DTGE block, and filled the NC property. Clicked Submit. Everything went as expected.
How are you getting this?

For me if I do the following I get the issue.
Just create a page, choose a grid layout and add a custom grid editor.

Thanks, and you are on 1.2.3? Did you update from previous versions?
What is that H-tag selector?

Hi
Yes I am on 1.2.3.
Its a custom property type that Ive made. But it happens regardless if I use an grid editor that has only OTB umbraco property types or one that has custom property types. I can send example if needed?

Hi @skttl ,
It's not difficult to reproduce it with the default Umbraco Starterkit.
Create a documenttype containing an Nested Content property and assign the "Feature" elementtype to it and make the property required. I've added an export from the Doctype I'm using (UDT file):

Nested Content
nestedContent
icon-document
folder.png

False
False
True
Nothing

NestedContent

Nested
nested
Umbraco.NestedContent
fa322cb2-2670-4bb2-8d1f-850d855052b2
Content
0
True
Nothing

30
Content
0

Now create an a new page under "About us" and add this element to the grid  and click the "Submit" button in the DTGE window.
The unsaved changes dialog appears.
The dialog references to the saved blueprint.

Thanks - I'll check up on this. Feel free to see if you can spot the problem too :)

I think i have found the problem but i do not have an idea how to workaround this:
In the redirectToCreatedContent method in the umbraco.services.contentEditingHelper there is an if-statement to check if  $routeParams.create  has a value. Because it's a new page, this value is "true" when a new page is created (it's in the browsers-url)
Existing pages do not have this parameter in the url so that why it only happens on new pages.
I made a dirty fix for this by capturing the $routeParams.create value before saving and resetting it afterwards.
#0c54b21446c22f480a03745046267f773e42bbbd
(This is the firstime a made a pull request and submitted changes so maybye it's not the way it usually has to be is done)

I think i have found the problem and made a small workaround:
In the redirectToCreatedContent method in the umbraco.services.contentEditingHelper there is an if-statement to check if  $routeParams.create  has a value. Because it's a new page, this value is "true" when a new page is created (it's in the browsers-url)
Existing pages do not have this parameter in the url so that why it only happens on new pages.
I made a dirty fix for this by capturing the $routeParams.create value before saving and resetting it afterwards.
This is the firstime a made a pull request and submitted changes so maybye it's not the way it usually has to be is done. Sorry!

Thanks @inetzo works great!

Also added a spinner in 2fc81024ac2fdab54d703d2ae4163edb9bda7c81 (I had a sloppy connection to the database, so it took some time for the blueprint to save :))

works great thanks so much


Vimeo loop setting not working

I've tried setting loop on the component and also within vimeoConfig, but &loop=1 is never appended to the iframe src.

My mistake, didn't see that the vimeoConfig object should include the iframeParams property.


The grid should specify server/client mode

It should be more explicit - at the moment you can sort of mix server and client paging/sorting etc
If it was more explicit it would be easier to understand what you as the consumer needed to provide (it's also confusing me!!)

Don't think we need this.. need to do some testing but I think having serverX bindables is working ok.

Seems ok for now, will close unless something crops up (like not writing unit tests comes and bites me :))


Add an extension to Pharo2VA to extract the list of packages in the load order

This was discussed here.
This would help bringing more complex projects as well as projects you didn't write and hence, you don't know the dependencies and order of load.
We could include this as a feature in the Pharo2VA project.

This won't be necessary since the loader will look recursively load packages from the repository if needed.


fix typo

Wharehouse -> Warehouse

Hello. Thank you for catching this.
We don't accept PR and the actual sources are not in this public github anyway, so I'll close this PR, but I'll have the original sample modified. Thanks again.


Add target-jsonl loader

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2012
Originally created by @DouweM on 2020-05-06 22:56:11

View 2 previous comments from the original issue on GitLab


Unwrap terminated data

The terminated event currently wraps its callback data in an object,
making it inconsistent with the docs (as well as how the other events
operate). This change simply unwraps it.

Good catch.  Thank you!


build stops with cmake issues

lobi@orange4:~/julia05$ git pull https://github.com/JuliaLang/julia.git kf/gallium
lobi@orange4:~/julia05$ make
... some time ...
libtool: link: gcc -m64 -std=gnu99 -O2 -pedantic -fomit-frame-pointer -m64 -mtune=k8 -march=k8 -o .libs/t-locale t-locale.o  ../../tests/.libs/libtests.a /home/lobi/julia05/deps/build/gmp-6.0.0/.libs/libgmp.so ../../.libs/libgmp.so -Wl,-rpath -Wl,/home/lobi/julia05/usr/lib
PASS: t-printf
PASS: t-scanf
PASS: t-locale
==================
All 3 tests passed
==================
Making check in cxx
==================
All 0 tests passed
==================
Making check in mpn
Making check in mpz
Making check in mpq
Making check in mpf
Making check in printf
Making check in scanf
Making check in rand
Making check in cxx
Making check in demos
Making check in calc
Making check in expr
Making check in tune
Making check in doc
warning: --depth is ignored in local clones; use file:// instead.
Note: checking out '2de198b4cec26c2b54c06da4baf88b3f57b9ca86'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

patching file CMakeLists.txt
-- The C compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26")
-- checking for module 'libcurl'
--   package 'libcurl' not found
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_LIBRARIES
  OPENSSL_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:315 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-2.8/Modules/FindOpenSSL.cmake:313 (find_package_handle_standard_args)
  CMakeLists.txt:220 (FIND_PACKAGE)

-- Configuring incomplete, errors occurred!
See also "/home/lobi/julia05/deps/build/libgit2/CMakeFiles/CMakeOutput.log".
make[1]: *** [build/libgit2/Makefile] Error 1
make: *** [julia-deps] Error 2

and i somehow disagree with the non-availability of openssl on a linux system.

http://stackoverflow.com/questions/16248775/cmake-not-able-to-find-openssl
and the installation of libssl-dev gives me some progress...


Clean up docs

Codecov Report
Base: 71.64% // Head: 71.64% // No change to project coverage :thumbsup:

Coverage data is based on head (959ae54) compared to base (f86d9dc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   71.64%   71.64%
=======================================
  Files           8        8
  Lines         268      268
=======================================
  Hits          192      192
  Misses         76       76

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Restructure utils.sh and support gradle > 5.1

I found a relatively simple solution for it anyway, and learned something new in the process (the existience of bc in linux). So for now, we support both.


Install script for Linux and Windows environment

A Tombolo install script for linux, mac and Windows environment which would help user getting started with the project, by installing all the dependencies required by the project, along with installing the project itself. The commands are already provided in the installation guides, need to wrap them up in a script, e.g. bash or other based on the platform.

macOS one done in #537.


Improvements.

Shell now doesn't kill explorer when closing (which could be annoying if you've got Explorer windows open.)
Shell launches Control Panel if ms-settings doesn't exist.
'Shutdown' now shows as a dialogue which appears in the middle of the display.

ok cool ill like merge thanks (also i cant seem to write to and read back registry for some weird reason, maybe im just bad at vb.net but i dont want to accept that)


[FEATURE]: Customize DDP arguments

Describe the feature
In the case when users need to specify DDP launching parameters (e.g. find_unused_parameters), keyword arguments should be passed to torch.nn.parallel.DistributedDataParallel at initialization.

Thanks for the feedback, will add this soon.

We have updated a lot. This issue was closed due to inactivity. Thanks.

If I use zero2, and there are some parameters that should not be trained, how should I set them?  If there are untrained parameters, you may encounter the following error: "AssertionError: fp32 param and grad have different shape".


Implements spawn command

Spawn Command
This pull request is for implementing the spawn command in the debug terminal into the main branch. This command is used for spawning in living entities in the world at a given position or at the player's position. Could the animal team please have a look at this, to make sure the behaviour is what they expect. Feel free to message me on discord or make a comment on the PR if you have any issues/questions.

Thanks looks good!


Campaign transformer and class

Fixes #4482
Establishes a slightly new approach to how we extract Campaign node data, and further, how that node data is transformed when returning data for API requests.
There is now a new Campaign class in the dosomething_campaign module. It updates on what was done before with returning a campaign stadClass object, but allows it to have a slew of custom methods for extracting data and making code more maintainable. When a node id is passed to the class upon instantiation, it will load the node and return a customized Campaign class object ready for use in different contexts (one of which will be the API).
Instantiate using:
$campaign = new Campaign($id);

The Campaign class has numerous protected methods that it uses to get associated data for a campaign to flesh out the kind of data we would expect to get back for a campaign object. Currently this object only collects the necessary data that is going to be used for the campaign, but additional methods will/can be added to collect more information (such as action guide content, faqs and other main campaign page content, etc).
We're defining a modified structure for the returned campaign class object that follows a more organized hierarchical structure that also mimics the structure for response data from the API. This allows us to have to do less cleanup in the transformCampaign() method of the Transformer class. Along those lines, after much discussion with @DFurnes and @aaronschachter  we're removing the need for unique property names for ids (such as nid, or tid). Since there's a much more hierarchical structure to the object, the property id will refer to the parent. This saves time with the need to change every nid, tid in the transformer for the sake of the API and just makes life easier.
A couple new helper utility functions have also been added to the dosomething_helpers module:

dosomething_helpers_extract_field_data()

Extract Drupal field data, accounting for single or multiple values and language. Also return both raw and formatted values if available.

dosomething_helpers_issetor()

Checks if a value is set and if so returns it otherwise returns a default (which can be specified)

Examples

Example output for the Campaign class object
Example output for the Transformed Campaign API repsonse return

NOTE: I'm still updating DocBlocks across the methods.

Little comments but overall looks great!  Awesome work!  :+1:


Maybe add a troubleshooting step for host with PHP 5.6 running phpunit on 7.2

Similar to quicksprint #53, but I think this is probably a useful documentation addition to DDEV docs.
A user may have (and want to keep) PHP 5.6 on their host even though running a DDEV Drupal environment using PHP 7.2. If I ran composer drupal-phpunit-upgrade on the host then no files would be updated so it would be useful to update the docs as either a troubleshooting section or a testing section to refer to running ddev exec composer drupal-phpunit-upgrade or note.

I don't understand... composer is not installed on the host at all, nor is php. ddev requires nothing of the type on the host.

Closing until followup, none yet.


Illegal instruction (core dumped)

Running on Arch Linux.
[darko@antergos-of-barsoom release]$ ./minesweeper
Illegal instruction (core dumped)
[darko@antergos-of-barsoom release]$
No other info.
Same result if I compile without --release.

Thank you! I haven't compile it for a while. Can you please tell me what rust version are you using?

Sure,
cargo -V
cargo 1.33.0 (f099fe94b 2019-02-12)
rustc -V
rustc 1.33.0 (2aa4c46cf 2019-02-28)

Hmm, I've got this ussue after update https://github.com/PistonDevelopers/piston/issues/1202, it seems to be a problem with my Mesa, but nothing near "illegal instruction".
I'll try to update all of the dependencies, maybe it will resolve this issue.


Attestation upload is broken

I was testing something, and came across the following error (expect the e2e tests to trigger a bunch of similar issues within 24hr):
uploading attestation: &{0 } (*models.Error) is not supported by the TextConsumer, can be resolved by supporting TextUnmarshaler interface https://github.com/slsa-framework/example-package/runs/6694426603?check_suite_focus=true
Error coming from https://github.com/slsa-framework/slsa-github-generator/blob/main/signing/sigstore/rekor.go#L53
@asraa @ianlewis any ideas what's going on?

can you run it again with DEBUG=1 on (assuming this is using rekor-cli or our client libs?

what is it only happening today "deterministically" :-)

Rekor team fixed it yesterday. Closing.


BUGFIX: Do not index text nodes

After fixing the bug with indexing - the index explodes
when using texts for suggestions and autocompletion.

Second index with text fields - indexing stoped because of no disk space left.


Generate crd yaml files from go markers

Description
Related issues

Close #XXX

Remove this section if you don't have related PRs.
Checklist

[ ] I've read the guidelines for contributing to this repository.
[ ] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

@padlar what is the item that the PR solve ?

@chen-keinan This is currently a Draft PR, and not ready for review. And blocked by https://github.com/aquasecurity/trivy-operator/pull/233. The goal is to add markers that generates the CRD equivalent to the existing hand-coded CRDs. But we'll see how close we get. The goal of https://github.com/aquasecurity/trivy-operator/pull/233 is to make this PR reviewable.

@chen-keinan This is currently a Draft PR, and not ready for review. And blocked by #233. The goal is to add markers that generates the CRD equivalent to the existing hand-coded CRDs. But we'll see how close we get. The goal of #233 is to make this PR reviewable.

I think its very important to state this in early stage , I'm happy to carry out changes as long it do not harm our main / existing business logic as trivy-operator (security tool)

@chen-keinan This is currently a Draft PR, and not ready for review. And blocked by #233. The goal is to add markers that generates the CRD equivalent to the existing hand-coded CRDs. But we'll see how close we get. The goal of #233 is to make this PR reviewable.

I think its very important to state this in early stage , I'm happy to carry out changes as long it do not harm our main / existing functionality logic for trivy-operator (security tool)

I understand, and I have asked  @padlar to rebase this PR on top of the other one. To see how much generating the CRDs will change them... The controller-gen markers are quite rich, so I think we'll get pretty close to the existing structure.


Improvement

I would like to see deobfuscation of functions
example:
https://cdn.seon.io/v3.0/js/agent.js
https://h.online-metrix.net/fp/check.js?org_id=k8vif92e&session_id=ipaylinks

agent.js: #15
check.js: I need more similar obfuscation.

check.js
if you refresh the page, this script will update with the same obfuscation, but with different parameters

Just change the name. Do you know of any other scripts?

Just change the name. Do you know of any other scripts?

td_3G.tdz_3ca9773a9165473d8acb3384efb8fea2 = new td_3G.td_4q("DECRYPT_STRING_ALWAYS_CHANGING");
I met similar scripts (I don’t remember), but there was a similar logic:

secret_string
decrypter function
call decrypt func, like decrypt(from = 3, to = 10), and get "Times New Roms"

I want to understand their rules, so original source code must be different.

Fixed #15, but agent.js still hasn't completely decoded.
https://pastebin.com/raw/8KfnfR8X

For backup:

agent.txt
check.txt

Resolve agent.txt in v1.7.0


Adding a preloader to the website.

A preloader can be added to the website to enhance the look while navigating the website.
I'm a participant of GSSoC'22, @Astrodevil kindly assign this issue to me. Thank you.

@Astrodevil  Kindly add the "level" label tag. Thank you.

It's for the PR


Include instructions on filtering test runs

Pull Request Test Coverage Report for Build 320341169

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.608%

Totals

Change from base Build 320329180:
0.0%

Covered Lines:
20474

Relevant Lines:
47381

💛  - Coveralls


boards: esp32s2_devkitc: initial board support

Initial board files created to support the esp32s2_devkitc board.

Closing as duplicate of #66463

@nordicjm, Sorry, it is not duplicated. #66463 is esp32s3 SoC.

My bad, missed the 3 being different to 2 in branch name

Needs to be migrated to hwmv2

It was migrated to hwmv2


Add option for wget2

This PR should address this issue. I have tested this one my local fedora machine and it works great.

Hey, why did you ever close this?

Because this is adressed in this PR mostly at least.

That PR won't be merged for a while. It doesn't modify ZVM installs across a few different functions so it can't be merged. I don't think Kira is actively working on fixing it either.
It's be better to make your own PR that addresses this than rely on that PR.


ubuntu 16.04

Does it work in ubuntu 16.04?
Which versions of ubuntu and ansible this script was tested against?
I encountered some problems - some packages are not installed.

I tested on Ubuntu 16.04 in OpenStack.
Are you testing on Amazon?
On Mon, Sep 26, 2016, 23:36 Marcin Kostur<EMAIL_ADDRESS>wrote:

Does it work in ubuntu 16.04?
Which versions of ubuntu and ansible this script was tested against?
I encountered some problems - some packages are not installed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/jupyterhub-deploy-teaching/issues/25, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXYcoXNWYkVGZfxH1Yu1ThZjphq2Egpks5quLlugaJpZM4KHTeB
.

I think that problem I have are connected with conda module in ansible. I have removed all conda: ...  and replaced with appropriate shell: lines and it works.
Funny thing was that sometimes conda module installed packages and sometimes did not, but showed green [ok].

is the ansible-conda folder in your git checkout empty by any chance?

Also I am hitting problems on 14.04 as well

I simply stopped using ansible-conda in favour of "raw" commands ;-(
mk
On Sun, Oct 2, 2016 at 9:21 PM, Brian E. Granger<EMAIL_ADDRESS>wrote:

Also I am hitting problems on 14.04 as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/jupyterhub-deploy-teaching/issues/25#issuecomment-250989720,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIxdpv8Xg8frT8midgmtKsWYXCTP_Saks5qwARLgaJpZM4KHTeB
.

--
Department of Theoretical Physics
Institute of Physics
University of Silesia
40-007 Katowice, Poland
tel. +48 32 3497 612
http://zft.us.edu.pl/kostur
http://icse.us.edu.pl
http://twing.us.edu.pl
Linux: because rebooting is for adding new hardware.


hack/local-up-cluster.sh: Add sudo generating serviceaccount key.

Otherwise will get permission denied, and the serviceaccount key is never generated, thus the apiserver will fatal and quit.

K, think it's fixed in HEAD by using tmp dir. Closing :)


GH-176 Improve cancerous implementation of the failure system

#176

Coverage remained the same at 54.45% when pulling c3a8f9141a5e1ec84ac82eb358495ae7c6b59ebb on dzikoysk/gh-176 into 452ac933b91b6d0b497495318c27f86fb342cfe9 on master.


Failed building wheel for pdftotext on Ubuntu 16.04

I was trying to install pdftotext on Ubuntu 16.04 via pip, but got following error:
# pip install pdftotext
Collecting pdftotext
  Using cached pdftotext-2.1.5.tar.gz (98 kB)
Building wheels for collected packages: pdftotext
  Building wheel for pdftotext (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /tmp/.pyenv-Python3.7/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-k2bzjgjw/pdftotext_e55a0cce589f416bb772c3c10db81767/setup.py'"'"'; __file__='"'"'/tmp/pip-install-k2bzjgjw/pdftotext_e55a0cce589f416bb772c3c10db81767/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-__usos3m
       cwd: /tmp/pip-install-k2bzjgjw/pdftotext_e55a0cce589f416bb772c3c10db81767/
  Complete output (33 lines):
  running bdist_wheel
  running build
  running build_ext
  building 'pdftotext' extension
  creating build
  creating build/temp.linux-x86_64-3.7
  x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPOPPLER_CPP_AT_LEAST_0_30_0=1 -I/tmp/.pyenv-Python3.7/include -I/usr/include/python3.7m -c pdftotext.cpp -o build/temp.linux-x86_64-3.7/pdftotext.o -Wall
  In file included from pdftotext.cpp:5:0:
  /usr/include/poppler/cpp/poppler-page.h:41:23: error: expected ‘,’ or ‘...’ before ‘&&’ token
       text_box(text_box &&) noexcept;
                         ^
  /usr/include/poppler/cpp/poppler-page.h:41:25: error: invalid constructor; you probably meant ‘poppler::text_box (const poppler::text_box&)’
       text_box(text_box &&) noexcept;
                           ^
  /usr/include/poppler/cpp/poppler-page.h:41:25: error: expected ‘;’ at end of member declaration
  /usr/include/poppler/cpp/poppler-page.h:41:27: error: ‘noexcept’ does not name a type
       text_box(text_box &&) noexcept;
                             ^
  /usr/include/poppler/cpp/poppler-page.h:41:27: note: C++11 ‘noexcept’ only available with -std=c++11 or -std=gnu++11
  /usr/include/poppler/cpp/poppler-page.h:42:34: error: expected ‘,’ or ‘...’ before ‘&&’ token
       text_box &operator=(text_box &&) noexcept;
                                    ^
  /usr/include/poppler/cpp/poppler-page.h:42:36: error: expected ‘;’ at end of member declaration
       text_box &operator=(text_box &&) noexcept;
                                      ^
  /usr/include/poppler/cpp/poppler-page.h:42:38: error: ‘noexcept’ does not name a type
       text_box &operator=(text_box &&) noexcept;
                                        ^
  /usr/include/poppler/cpp/poppler-page.h:42:38: note: C++11 ‘noexcept’ only available with -std=c++11 or -std=gnu++11
  /usr/include/poppler/cpp/poppler-page.h:134:10: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
       std::unique_ptr<text_box_data> m_data;
            ^
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pdftotext
  Running setup.py clean for pdftotext

Also tried to install it from sourcecode, but there is the same error.
However, adding "-std=c++11" to https://github.com/jalan/pdftotext/blob/master/setup.py#L37 can fix this issue.

Sounds like you have a non-standard ubuntu 16.04 there. I just tested it out on ubuntu 16.04 and it works as expected.
The ubuntu image I used:
docker pull ubuntu:16.04
docker run -it ubuntu:16.04 bash

The commands I ran inside the image:
apt update
apt upgrade
apt install build-essential libpoppler-cpp-dev pkg-config python3-dev python3-pip
pip3 install pdftotext

The version of poppler on ubuntu 16.04 doesn't require c++11. I suspect you manually installed a different version of poppler, bypassing your package manager? If that's the case, you're on your own.

Sounds like you have a non-standard ubuntu 16.04 there. I just tested it out on ubuntu 16.04 and it works as expected.
The ubuntu image I used:
docker pull ubuntu:16.04
docker run -it ubuntu:16.04 bash

The commands I ran inside the image:
apt update
apt upgrade
apt install build-essential libpoppler-cpp-dev pkg-config python3-dev python3-pip
pip3 install pdftotext

The version of poppler on ubuntu 16.04 doesn't require c++11. I suspect you manually installed a different version of poppler, bypassing your package manager? If that's the case, you're on your own.

earlier it instaled pdftotext-2.1.4-cp37-cp37m-linux_x86_64.whl and it worked, but today it uses pdftotext-2.1.4.tar.gz and it fails. I don't see wheels there https://pypi.org/simple/pdftotext/ anymore.
does it work without cache for you pip install --no-cache-dir  pdftotext==2.1.4?

earlier it instaled pdftotext-2.1.4-cp37-cp37m-linux_x86_64.whl and it worked, but today it uses pdftotext-2.1.4.tar.gz and it fails. I don't see wheels there https://pypi.org/simple/pdftotext/ anymore.
does it work without cache for you pip install --no-cache-dir  pdftotext==2.1.4?

I've reinstalled libpoppler-cpp-dev libpoppler-cpp0 libpoppler-dev and now it works fine.
Thanks for your help!

I've reinstalled libpoppler-cpp-dev libpoppler-cpp0 libpoppler-dev and now it works fine.
Thanks for your help!

@jalan hey, sorry for the request, but could you delete this issue?

@jalan hey, sorry for the request, but could you delete this issue?

@jalan could you remove this issue please?

@jalan could you remove this issue please?


Alignments are not updated for the PrefixModifier

The alignments are just passed through. For them to be valid for using with guided alignments, they will also need to use a custom tokenizer.
From the class docs:

Note that if the target is ZH, JA or basically any other language that is not space segmented,
this wouldn't work as we would be prefixing the whole sentence (or very large part of it).
This is not supported for now. A proper fix would be to use custom detokenizer like in the placeholders.

Doing this work with proper tokenization would also support ZH and JA.

Based on conversation in #36 I'd like to re-think through how this works.

I'm assuming you meant #38 :)
I'm still of the opinion that a structure as discussed in #29 makes things easier.
In a way I'm a bit annoyed at Marian that it consumes detokenized text, but alignment pairs based on tokens. Just let me feed you the tokens and the alignment pairs then, or alignment pairs based on byte offsets. Something more robust than the current hack.

I was dealing with an issue in our training repo with alignments being invalid and Marian crashing by not checking bounds when using guided alignment. https://github.com/mozilla/firefox-translations-training/issues/450 This issue is coming from our use of OpusTrainer. It was even failing when I applied no rules, so something is up.
I'm currently auditing our alignment usage for correctness, and reviewing @eu9ene's PR to add the noise modifiers. I'll probably spend some time looking into this and report back. Feel free to ignore these initial issues while I investigate, but I wasn't aware of the assumption of whitespace tokenized input.
I am a bit curious coming more from the Unicode and ICU world, where we had the word break iterator, which seems a bit more robust than just whitespace tokenization, but I'm unsure of what it looks like integrating the behemoth of the ICU library in a python tool world like this. I'll investigate more and report back.

We used whitespace as most tokenizers gave us tokens separated by whitespace, so because of convention really I suppose.
I was trying to avoid adding tokenizers inside OpusTrainer, I'd rather have them as external tools, but the Tags and Placeholder modifiers need to be aware of what tokenisation was or will be applied in order to tokenize the bits they add. And then all kinds of assumptions started creeping in :(


Check for broken links in the documentation

I've noticed some broken links in the napari-plugin-engine documentation pages. We should fix these, possibly with the same link checking we do for hte napari.github.io respository: https://github.com/napari/napari.github.io/blob/main/.github/workflows/link-checker.yml
One example of a broken link: on this page the linked named "See also: documentation for writing a napari plugin" produces this 404 error.

Recently Tried to fix that specific link in https://github.com/napari/napari-plugin-engine/pull/42 ... need to figure out why it didn't work.
Did you find any others?

I didn't look for any others, figured it might be quicker to let an automated link checker do that :smile:

I ask because that might literally be the only page with links in these docs.  (Not a lot of links).
But feel free to make a PR with the link checker if you want!

Ah, well then maybe that's overkill. Not super familiar with how extensive these docs are, or how many links.
I'm slightly concerned that if we fix that individual link, and then the reorg shuffles files around, it might just break again (probably what happened here in the first place). So it might make sense to wait a little bit, or schedule a follow up/

the reorg no longer uses this repo at all!  so no worries there

It is super weird, I don't know why https://github.com/napari/napari-plugin-engine/pull/42 didn't fix things.
I am looking at latest, and it's not a caching issue (I see the same thing happen in a private window).
Was the main branch renamed from master recently? Which branch does github think it's building the docs with?


GraphQL: add 'transactions' query to return all transactions with paginated results

To support the new homepage design, I'm working on creating and updating graphql queries to provide the necessary data. Most of the API design decisions are inspired by the GitHub GraphQL API as it seems to be one of the more mature, real-world examples.
This PR adds a transactions query to eventually replace the allTransactions query to support a paginated return value that includes total, limit, offset, transactions fields. transactions also does not require CollectiveId or CollectiveSlug arguments. In reality, the use of allTransactions should be replaced by using the Collective query and selecting the transactions field off that relationship.
This PR is also using snapshot testing for verifying the result of graphql queries to simplify testing. Interested in feedback on this pattern. cc: @znarf @clarete

@HipsterBrown Good one.  Thank your for updating Mocha and introducing this new pattern for testing. That would be great to have a quick guide when someone wants also to do that in the future.
The GraphQL updates are looking pretty clean. Unfortunately, I haven't touched much this part yet and can't give you much feedback.

@znarf I'll add a section to the README about the testing setup and usage. :+1:


Support for :headless_chrome?

Does it support :headless_chrome driver?

Seems to work just fine with headless chrome.


misc - restrict .env access

1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

ist removed

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21084
Please use this issue to track the state of your pull request.

thanks @teiling88 :+1: :tada:


Add to Winget

I decided that you would be happy to have another open ticket to cause you a headache up until the release.
This one is to track Podman Desktop Companion availability in Microsoft's Windows Package Manager "Winget" repository that is available for Windows 10 (1809) and up

Unfortunately at this moment, I don't have the budget for performing code signing as it requires payment. I've added the manifests for whoever is financially and technically savy to join in and do it, see in https://github.com/iongion/podman-desktop-companion/tree/main/support/winget


(old ui) Download button on course page not working

Describe the bug
The download url returns 404, on the old course page
(on the individual page of VODs everything is fine)
the url https://tum.live/api/download/27102/linalginfo/linalginfo-April-18-2023 is 404
which should be: edge.live.rbg.tum.de/...
To Reproduce
Steps to reproduce the behavior:

Go to https://tum.live/old/course/2023/S/linalginfo
click download
See 404

Expected behavior
start downloading video, or pop up selection panel for selecting combined/cam/pres like the new ui
Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser Safari
Version 17

similar problem also on the new ui, (it didn't when I tested some times ago... I remember)
(should I create a new issue?)
go to https://tum.live/?year=2023&term=S&slug=linalginfo&view=3
click one of the download options

it seems to be the json file result was missing the jwt token

return of the json https://live.rbg.tum.de/api/courses/linalginfo/?year=2023&term=S, download url without jwt token however


XLink not installed with cmake install (only static issue?)

For a static build of depthai, using DEPTHAI_XLINK_LOCAL... a cmake install

does not install the XLink cmake files 😕
does not install the XLink static libraries 😕
does install the xlink includes 🙂

Setup

Microsoft Windows [Version 10.0.19044.1348]
VS2019 Community v16.11.7
cmake v3.19.1
depthai-core v2.12.1 + my local fixes

Repro

set depthai for a static build, x64, and opencv support
set depthai to use a local xlink with DEPTHAI_XLINK_LOCAL. Use the same commit as hunter would.
set depthai to install to a known location e.g. CMAKE_INSTALL_PREFIX=c:/myinstalldir
cmake configure, build, and then install

Result
Either try to find_package() and then compile an app that would use this depthai install
-or-
search c:/myinstalldir for the xlink cmake file XLinkConfig.cmake and its static libraries XLink.lib/XLinkd.lib
You will find none of these files.
Expected
Your app finds depthai and all its dependencies (like XLink) and cleanly builds.
-or-
You find XLink's cmake files and static libraries in the given install location c:/myinstalldir
Notes
I see all the needed files in the depthai build directory ...\depthai-core\build\XLink. This suggests their might be only a small change needed for cmake install process to use those and then do the install.

Hacking some on this in depthaiDependencies.cmake (probably wrong approach)...
# XLink
if(NOT CONFIG_MODE)
    if(DEPTHAI_XLINK_LOCAL)
        add_subdirectory("${DEPTHAI_XLINK_LOCAL}" ${CMAKE_CURRENT_BINARY_DIR}/XLink EXCLUDE_FROM_ALL)
    else()
        find_package(XLink ${_QUIET} CONFIG REQUIRED)
    endif()
    if(NOT BUILD_SHARED_LIBS)
        list(APPEND targets_to_export XLink)
    endif()
endif()

I've got a few steps further, but app compile fails with depthai because it can't find XLink/XLinkPublicDefines.h
That header was not cmake-installed by depthai yet both XLinkConnection.hpp and XLinkStream.hpp need that include themselves.

I've got a local hack almost working. I think are three things in play...

depthai-core/depthaiDependencies.cmake includes a DEPTHAI_XLINK_LOCAL xlink with the EXCLUDE_FROM_ALL flag. I think that flag excludes that added thing from the ALL built target. And likely from the ALL install target. Therefore xlink isn't installed.
You might be able to get it to install with cmake --install . --component XLink but the cmake code in the XLink project skips all installation steps when a component is defined. It doesn't realize the distinction between a component of depthai -vs- a component of XLink.
Finally, after hacking the above with workarounds, i have the includes and libraries installing. The entire XLink/include directory is installed...all 15 include files. Probably only one needs to be installed XLinkPublicDefines.h

I think removing the EXCLUDE_FROM_ALL is the way to go - although there might be way to specify it explicitly in installation part of core instead


add windsonsea to doc-reviewer

What type of PR is this?
/kind documentation
What this PR does / why we need it:
I joined Karmada one year ago and have actively contributed to the project. By this time, I have authored 24 PRs, and I have also reviewed 17 PRs.
Recently, with the increase in en-zh PRs, I have noticed that the review process is not always timely. To address this, I would like to take on the responsibility of improving the documentation, particularly for Chinese content, in order to provide convenience for native Chinese developers.
As a technical writer, I find great joy in reading and working with both English and Chinese text during the process of writing, translating, and reviewing. I value the opportunity to learn from the texts you have provided in each PR related to the documentation.
I appreciate the honor of being entrusted with this responsibility and look forward to continuing my contribution to enhancing the quality of the documentation.
Thanks.

cc @RainbowMango @Poor12

lol, thanks. Will open a PR there soon.


fix: config checks for generate page CRUD

Description
Generate page crud was checking for the config from DS storage even for non env enabled datasources. This PR fixes that.
PR fixes following issue(s)
Fixes #25640

/ok-to-test

Addint skip-testPlan since the change was earlier tested on EE (didn't go in due to code split). Also, this section only refers to changes in EE and hence not testable here.


Thumbnails Empty with New Version

Glad to see a new version released! Unfortunately all of my thumbnails are coming up as blank/black rectangles. I've waited over an hour with a fast internet connection but no luck. Any ideas on what might be wrong?

Did you not get the update message? Thumbnails cannot be generated in the background anymore. You'll have to visit all the bookmarks and keep everyone open in the visible tab until the thumbnail has been captured (it only takes a bit, but if you close/switch the tab to quickly the thumbnail is not taken). I know it's annoying, but there is no other way. Please have a look at the README, especially the know issues.

Understood. I will do it. Thank you!

This seems like a problematic approach for:

users with existing bookmark collections
users with multiple computers. (Don't want to have to click every bookmark on every computer).

Old approach had these issues covered. Also, I'm still getting some pages that do not generate thumbnails.
Thank you!

This is not by choice, it's the only way. You also need to make sure that the final URL in the tab is the same as the bookmarked one.

Thanks--Adjusting the URL fixed the thumbnail. Did Mozilla force you to abandon the old implementation which auto-generated the thumbnails?

Yes, from Firefox 57, there will be only the webextension API left. I had to almost completely rewrite the extension. Similar extensions use external thumbnail providers which have other problems like privacy, network access and no way to get thumbnails for intranet pages or logged in pages. But I wanted to keep thumbnail generation on the machine. I had the same problems after switching to the new version. I too use several computers. After the first pain, it gets better. Especially because thumbnails for new bookmarks are immediately available (unless you add them manually in the bookmark view, but the best way is to use the star button or Ctrl-D to bookmark the current page). When you then switch to the other computer, you know exactly which ones are new...

OK. Thanks for the explanation. Too bad they forced it to work this way. I will continue to use your cool add-on.
Best

By the way, the following two URLs come up as pure white thumbnails, even when I confirm the links:
https://help.apple.com/logicpro/mac/10.3/index.html
https://musicboxvillage.com/
Just to let you know.
Anthony

I think it's because it's using Javascript rendering, so the website has already finished loading, but the Javascript takes a while to show the content. You can always use the button in the toolbar menu to create a thumbnail once the content is actually there.

I see. That's pretty cool and it works well.
Is there an easy way to make your software upload the good set (with manual snapshots) of thumbnails to the cloud and then share across other computers? That would be really handy.

I guess I could do a manual import/export. That would be relatively straight forward, but maybe not super useful?
Browser sync has storage space limitations unfortunately, so that's no good. I don't know where else I could sync to and I am also a bit afraid of feature creep.

Maybe I didn't explain clearly. I mean, when all of the thumbnails look correct on one computer, have the software automatically upload that set to the cloud. Then when you first set up thumbnails on another computer, you could sync the set from the first one.
I understand about feature creep, so please take my suggestion with a grain of salt! The goal would be to only need to customize/optimize the thumbnails once and also avoid having to "click through" to thumbnails on subsequent computers. Just a thought! I will use your product regardless.
Thanks.

I did understand what you mean, but there is no magic place in the cloud where I can just send stuff. Browser sync would have been an option if storage wouldn't be limited, but it is.

Understood. Thanks.

Hi Sebastian.
I’ve been enjoying your Bookmarks Dial add on for Firefox. One idea: Could you create a function to make the add-on automatically create all the thumbnails in any particular folder when you push the button for that function? That would be very useful in my opinion.
Thanks!
From: Sebastian Blask<EMAIL_ADDRESS>Sent: Wednesday, October 4, 2017 1:14 PM
To: sblask/webextension-bookmark-dial<EMAIL_ADDRESS>Cc: Anthony Mumphrey III<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [sblask/webextension-bookmark-dial] Thumbnails Empty with New Version (#15)
I did understand what you mean, but there is no magic place in the cloud where I can just send stuff. Browser sync would have been an option if storage wouldn't be limited, but it is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sblask/webextension-bookmark-dial/issues/15#issuecomment-334243580, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdR3AtkR1rk8GESX9YrXAvEc1WrII32Wks5so8rsgaJpZM4PsYGw.

Simply not possible...

@sblask
I just want a icon, not a thumbnails, and bookmark folder in right/left side, just as Safari do!  I think safari's bookmark page design is very well.
Anchoy open this issuse, @sblask why you not just put icons on page at first time! Simple, tidy, usefull...

@Yensan I have no idea how Safari looks like, but if you like it so much, just use it? There is no way to just put the icons. Also, if you just want the icons, you can use your browsers bookmark manager...

@sblask
Firefox's bookmark manager is so unconvinient
I use Mac Air in after-hours, but must use Windows in work-time!
I think as a navigate page, Safari's bookmarks is very nice.


use_template_blur.jpg is missing

use_template_blur.jpg is missing but mentioned in readme

@kochaika thanks! @anchouls fixed it in #6


Adds --no-skip-spaces-ortho and --no-skip-spaces-pron flags

[X] Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

--no-skip-spaces-ortho when set to True will not skip words that contain spaces (whether regular or non-breaking  - though I haven't come across any of these yet). This required modifying cli.py, config.py, and wikipron/scrape.py
--no-skip-spaces-pron when set to True will not skip transcriptions that contain spaces (whether regular or non-breaking). This required modifying cli.py, config.py, and extract/core.py. extract/core.py now also checks whether this flag is set and removes the "#" that the segments package inserts. (Is this the desired behavior discussed in #133?)
I also modified languages.json to include the appropriate flags for the relevant languages (Chinese, Vietnamese, Persian, Tibetan). src/scrape.py was slightly modified to make it easier to build the config dictionary passed to Wikipron.
(It's my first time adding a flag so, though this seems to work, I'm not entirely sure I followed best practices, in particular for modifying config.py.)
Resolves #133

I just added Jackson in case he's available.

One thing that makes this generally hard to follow is that the flag semantics have a negation in them. Maybe it would be easier to call it something such that it's a True and not a False when it's enabled...any ideas?

I agree. I confused myself many times while adding the flags. Perhaps more sensible flag names would be allow_spaces_words/allow_spaces_prons. I suppose I was influenced by the amount of --no-... type flags that we already have.
A question I have is --
Jackson's comment from #91 :

In general, I think our API design should be "if the user wants to remove information, they should be forced to do something, e.g., explicitly applying a flag to say so".

Seems to suggest (if 'information' can mean number of transcriptions we scrape) that the default behavior should not be to skip entries with spaces and that using the flag should compel WikiPron to skip entries with spaces. As the flags are currently implemented, our default behavior is to skip entries with spaces, but I wonder if it would be more consistent with Jackson's comments to have the reverse be the case.

Lot of good points here.
I think we should accept this PR as is (modulo my point about “word” vs.
“ortho”) and then at a later date, take Jackson’s advice and refactor for
that.
What do you think?
On Sat, Mar 28, 2020 at 7:38 PM Lucas Ashby<EMAIL_ADDRESS>wrote:

One thing that makes this generally hard to follow is that the flag
semantics have a negation in them. Maybe it would be easier to call it
something such that it's a True and not a False when it's enabled...any
ideas?
I agree. I confused myself many times while adding the flags. Perhaps more
sensible flag names would be allow_spaces_words/allow_spaces_prons. I
suppose I was influenced by the amount of --no-... type flags that we
already have.
A question I have is --
Jackson's comment
https://github.com/kylebgorman/wikipron/issues/91#issuecomment-552208879
from #91 https://github.com/kylebgorman/wikipron/issues/91 :
In general, I think our API design should be "if the user wants to remove
information, they should be forced to do something, e.g., explicitly
applying a flag to say so".
Seems to suggest (if 'information' can mean number of transcriptions we
scrape) that the default behavior should not be to skip entries with
spaces and that using the flag should compel WikiPron to skip entries with
spaces. As the flags are currently implemented, our default behavior is to
skip entries with spaces, but I wonder if it would be more consistent with
Jackson's comments to have the reverse be the case.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/135#issuecomment-605533996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OKRO3SAQYVZCNXKICLRJ2C65ANCNFSM4LVWBHPA
.

I am working on it too, but mine is not complete yet.
Lucas’s looks great :D
Yeonju

On Mar 28, 2020, at 8:27 PM, Kyle Gorman<EMAIL_ADDRESS>wrote:
Lot of good points here.
I think we should accept this PR as is (modulo my point about “word” vs.
“ortho”) and then at a later date, take Jackson’s advice and refactor for
that.
What do you think?
On Sat, Mar 28, 2020 at 7:38 PM Lucas Ashby<EMAIL_ADDRESS>wrote:

One thing that makes this generally hard to follow is that the flag
semantics have a negation in them. Maybe it would be easier to call it
something such that it's a True and not a False when it's enabled...any
ideas?
I agree. I confused myself many times while adding the flags. Perhaps more
sensible flag names would be allow_spaces_words/allow_spaces_prons. I
suppose I was influenced by the amount of --no-... type flags that we
already have.
A question I have is --
Jackson's comment
https://github.com/kylebgorman/wikipron/issues/91#issuecomment-552208879
from #91 https://github.com/kylebgorman/wikipron/issues/91 :
In general, I think our API design should be "if the user wants to remove
information, they should be forced to do something, e.g., explicitly
applying a flag to say so".
Seems to suggest (if 'information' can mean number of transcriptions we
scrape) that the default behavior should not be to skip entries with
spaces and that using the flag should compel WikiPron to skip entries with
spaces. As the flags are currently implemented, our default behavior is to
skip entries with spaces, but I wonder if it would be more consistent with
Jackson's comments to have the reverse be the case.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/135#issuecomment-605533996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OKRO3SAQYVZCNXKICLRJ2C65ANCNFSM4LVWBHPA
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/kylebgorman/wikipron/pull/135#issuecomment-605538111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKPU5BQP3HIW5H6OMNLQKLRJ2IXRANCNFSM4LVWBHPA.

I made the requested changes. Should I have totally changed the flag names to something like include_spaces_word or will will leave them as they are (no_skip_spaces_word/no_skip_spaces_pron) for the time being?
Yeonju's solution #137 of using a single flag for both is pretty cool (I'd imagine people would probably use both of my provided flags or neither) and her command line help statements are better so perhaps I should do some further changes to incorporate her ideas?

I agree re: avoiding (double)-negation in flags; please go for it.
Welcome back Jackson! Hope you're well.
On Thu, Apr 16, 2020 at 3:41 AM Jackson L. Lee<EMAIL_ADDRESS>wrote:

@jacksonllee approved this pull request.
Late to the language party. LGTM!
+1 for not using negation-based flags of --no-X anymore -- we could open
a GitHub issue and handle this later.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/135#pullrequestreview-394373748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OOCAIPELXHNEOXGPNLRM2ZCRANCNFSM4LVWBHPA
.

Had to resolve conflicts (in CHANGELOG.md and src/scrape.py) in order to merge.


Onyx not defined error appears in console when run the script

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing #27180
Action Performed:

Login
use Onyx.set('OnyxUpdatesLastUpdateIDAppliedToClient', null); in the console

Expected Result:
There shouldn't be any error
Actual Result:
Uncaught error appears
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.71-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

OK, I get the same error:
VM64:1 Uncaught ReferenceError: Onyx is not defined     at <anonymous>:1:1
Adding engineering since that doesn't really mean anything to me @thienlnam, is this a BE or FE issue?

You can only do this in your local environment - so not a bug


Feature: better documentation

Hi @morgs32 👋
I'm looking forward to your PRs 😄

Yes I'll give that a shot!


Announcement: climaker

Hi,
Just thought I would let you guys know that I have created a tool for creating CLI tools which is heavily leveraging yargs:

It both provides a CLI to help with the creation for a skeleton for your CLI tool and acts as the library that will plug your binaries to commands - and defines what should be the format of the commands themselves.
Still quite raw, but hope you enjoy :)
https://www.npmjs.com/package/climaker
https://github.com/Wizcorp/climaker

Hey @stelcheck, sorry for the delayed response, thanks for sharing! I haven't had time to play with it yet, but your tool looks pretty slick.
This would be a good candidate for a "Related Packages" section in the README (which doesn't exist yet). I know of at least one other library that is meant to work with yargs. :smile: Know any others we could add? Maybe it's time we finally add this to our docs?

@nexdrew I was going to chime in with the same comment -- I love the idea of this section.
... it would actually be pretty cool to have a yargs website with a section about related projects, and perhaps a section about large projects using yargs -- on that note, wouldn't a logo be nice?

@stelcheck I'm going to close this, but let's create an issue to discuss what a section in the documentation (better still a website) might look like for showcasing related modules.


Getting error while executing registerUser.js(Need help in priority)

I am using the IBM Blockchain platform console to create the network and using the fabcar sample to connect to the network with SDK. The enrollAdmin.js script is successful  but the registerUser.js is giving the below error message.
Failed to register user user1: TypeError [ERR_INVALID_ARG_TYPE]: The "options.ca" property must be one of type string, Buffer, TypedArray, or DataView. Received type object.
As per my analysis the issue is with the line.
const secret = await ca.register({ affiliation: '', enrollmentID: userName, role: 'client' }, adminIdentity);
I am not sure how to resolve it,could you please help on this.

Also having this error, followed the documentation to a T.

am having the same issue.

@amitchandra-1982
@iman-hussain
@LukasJaks
Please refer to the below issue - https://github.com/IBM/evote/issues/41#issuecomment-651925530

That worked for me. Thanks!!


How to get the "lucid_data_dreaming"?

Dear,
You wrote
To use this, the original Lucid Data Dreaming code needs to be downloaded from here:

https://github.com/ankhoreva/LucidDataDreaming

And then it can be run with my script (run.py) to generate image augmentations per image sequence.

Could you tell me where is your run.py???
Thanks in advance

Hey. This was just a typo in my readme. I meant to write 'run.m'.  The run.m is present in the lucid data dreaming folder. I fixed the typo now


💡 Create a footer section

[x ] I am from GSSoC23.
[x ] I would like to be assigned this task.

fill [x] to check the boxes.

I want to create a proper footer section for the page.

Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.

[ x] I follow the Contributing Guidelines of this project.
[ x] I have checked the current issues for duplicate problems.
[ x] I have read the readme of this repository.

Someone is already working on this issue, so can't assign this to you. You can try contributing to a new feature.


[BUG] Undefined behavior when chaining update methods

Describe the bug
There are actually 2 separate things one is a feature request, another is a bug, but I think they are connected.
The bug: When chaining update methods only the last one get's executed:
await MyModel.find_all().set({MyModel.field1: "a"}).set({MyModel.field2: "b"})
# Only field 2 gets updated

The same is also true when passing multiple arguments to update:
await MyModel.find_all().update({"$set": {MyModel.field1: "a"}}, "$set": {MyModel.field2: "b"})
# Only field 2 gets updated

I haven't played with other opearators like inc and mul but I suspect they share the same behavior.
Expected behavior
In case methods are chained together I expect them all to be executed.
In case multiple arguments are passed to update() I expect the behavior to be equivalent to chaining.
Additional context
I discovered this bug while trying to execute an update query with a pipeline, something like this:
await MyModel.find_all().set({"field1": {"$not": "$field1"}})

If I execute this field1 will be set to the literal string value '{"$not": "$field1"}', which is not what I want.
I want to invert the value of field1 (it's a boolean field in this case).
I saw that you can pass pymongo a list of dictionaries in which case it will interpret it as an update pipeline, so I would like to be able to do something like this:
await MyModel.find_all().update([{"$set": {"field1": {"$not": "$field1"}}}])

But this throws an error:
    @property
    def update_query(self) -> Dict[str, Any]:
        query: Dict[str, Any] = {}
        for expression in self.update_expressions:
            if isinstance(expression, BaseUpdateOperator):
                query.update(expression.query)
            elif isinstance(expression, dict):
                query.update(expression)
            elif isinstance(expression, SetRevisionId):
                set_query = query.get("$set", {})
                set_query.update(expression.query.get("$set", {}))
                query["$set"] = set_query
            else:
>               raise TypeError("Wrong expression type")
E               TypeError: Wrong expression type

../../.venv/lib/python3.9/site-packages/beanie/odm/queries/update.py:83: TypeError

I think those issues are all related to the fact that in the update_query property,
the returned value is always of type dict, so pymongo will always interpret it literally and not as a pipeline.
I found a workaround for this:
update = MyModel.find_all().update([{"$set": {"field1": {"$not": "$field1"}}}])
update.encoders[dict] = lambda x: [x]
await update

But for some reason the encoders value stays there and breaks other queries as well.
So I either have to
del update.encoders[dict]

which might not be async-safe,
or just use pymongo/motor directly.

Hi! Thank you for the catch. I'll check it out in the next bug-fixing session. This or next week

Hi!
You can not use the same key in python dict twice:
print({"$set": {MyModel.field1: "a"}}, "$set": {MyModel.field2: "b"} )  # the second one will rewite

Pipelines are supported in https://github.com/roman-right/beanie/pull/669. Please check. Be aware, MongoDB supports a limited list of operators in the update aggregation pipelines.


Kamelet properties config as part of Metadata form

Please describe the feature that you want to propose
There was recently an adition to Kamelet config form in canvas - https://github.com/KaotoIO/kaoto-next/issues/880
This could be included in the metadata Kamelet editor, to sync the config capabilities.

For this, let's start by listing the differences between both forms. (Metadata editor vs Kamalet configuration editor)


reorganized files so that we can start writing test.

After reviewing and merging this pull request, you can put your tests in utils folder. Run "make test" to run the tests in utils folder. See the examples inside the folder for help.
Thanks!

note that the coverage tests are failing only for python3 but succeed for python2. Since we are using python2, I'll find out how to configure it to only run the tests for python2.


Fix(git): add warning of the mismatch of git cred and url

Changes
Fix(git): add warning of the mismatch of git cred and url
Fix #3094
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Fix(git): add warning of the mismatch of git cred and url

/kind feature
/ok-to-test

PTAL 😉  @sbwsg

Fixed. 😆  Please review @sbwsg

Can anybody take a look at this PR? 🤔
/cc @vdemeester

/retest

Can I get a lgtm? /cc @vdemeester 😉

@FogDong @sbwsg can you update the release note with more information about what this change is doing?

@bobcatfish sure thing; updated!


python310Packages.cometblue-lite: 0.4.1 -> 0.5.2

Description of changes
Update to latest upstream release 0.5.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 187560 run on x86_64-linux 1

2 packages built:

python310Packages.cometblue-lite
python39Packages.cometblue-lite


feat(storage): add disk storage using shelve

I should have done this as a review. Github on mobile strikes again.


useSendTransaction does not update its state on error

When calling useSendTransaction, the password modal shows up as expected, but if the transaction results in an error (for example due to unsufficient funds), its state (isLoading, isError, error, ...) is not updated, which results in infinite loading.
The thrown error (probably not catched when it should?):
Error: insufficient funds for intrinsic transaction cost [ See: https://links.ethers.org/v5-errors-INSUFFICIENT_FUNDS ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":51,\"error\":{\"code\":-32000,\"message\":\"insufficient funds for gas * price + value\"}}","error":{"code":-32000},"requestBody":"{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0x02f86a05808459682f008459682f1082520894f76c4b9fbb9fcc2c4c1cdfb11bd6e708ccc66e338080c080a01e137bd2e588741c9a4f9a0c6996690a67ffc5f923ad2e35b6a92c8021752c88a012352598605fc52f08e263c10c8b492646a645177f3613c5e56f9330f6857958\"],\"id\":51,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://eth-goerli.alchemyapi.io/v2/GPR_qF9l_vj-iDb1Kdg3cjDBB-ktJ7Lt"}, method="sendTransaction", transaction="0x02f86a05808459682f008459682f1082520894f76c4b9fbb9fcc2c4c1cdfb11bd6e708ccc66e338080c080a01e137bd2e588741c9a4f9a0c6996690a67ffc5f923ad2e35b6a92c8021752c88a012352598605fc52f08e263c10c8b492646a645177f3613c5e56f9330f6857958", code=INSUFFICIENT_FUNDS, version=providers/5.6.8)
    at Logger.makeError (index.ts:261:28)
    at Logger.throwError (index.ts:273:20)
    at checkError (json-rpc-provider.ts:98:16)
    at JsonRpcProvider.<anonymous> (json-rpc-provider.ts:603:20)
    at Generator.throw (<anonymous>)
    at rejected (json-rpc-provider.ts:20:1)

I'm guessing this is on wagmi, haven't investigated that much yet though.

Fixed by replacing preact with react.