Panic on scorecard execution

Describe the bug
A scorecard run triggers a sigsev panic.

Finished [Signed-Releases]
Finished [Signed-Tags]
Finished [Fuzzing]
Finished [SAST]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x1051573a0]

goroutine 24 [running]:
github.com/ossf/scorecard/checks.IsPrReviewRequired(0x1056c1c18, 0x140001a4000, 0x14000096000, 0x14000010010, 0x140000320c0, 0x140001d8313, 0x10, 0x140001d8324, 0xb, 0x14000074030, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checks/code_review.go:109 +0xf0
github.com/ossf/scorecard/checker.MultiCheck.func1(0x1056c1c18, 0x140001a4000, 0x14000096000, 0x14000010010, 0x140000320c0, 0x140001d8313, 0x10, 0x140001d8324, 0xb, 0x14000074030, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checker/check.go:64 +0xa0
github.com/ossf/scorecard/checks.DoesCodeReview(0x1056c1c18, 0x140001a4000, 0x14000096000, 0x14000010010, 0x140000320c0, 0x140001d8313, 0x10, 0x140001d8324, 0xb, 0x14000074030, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checks/code_review.go:39 +0xac
github.com/ossf/scorecard/checker.(*Runner).Run(0x1400047be40, 0x1056a0f28, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checker/checker.go:54 +0x148
github.com/ossf/scorecard/pkg.RunScorecards.func1(0x1056c1c18, 0x140001a4000, 0x140001bc498, 0x140001d8308, 0xa, 0x140001d8313, 0x10, 0x140001d8324, 0xb, 0x140001a5570, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/pkg/scorecard.go:109 +0x1e0
created by github.com/ossf/scorecard/pkg.RunScorecards
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/pkg/scorecard.go:89 +0x11c

Thanks, I can't seem to reproduce this on the main branch. Could you point it to the main branch and try it?
go run . --repo=github.com/ironpeakservices/ironpeak.be --show-details
go: downloading google.golang.org/api v0.49.0
go: downloading google.golang.org/genproto v0.0.0-20210624174822-c5cf32407d0a
go: downloading golang.org/x/sys v0.0.0-20210616094352-59db8d763f22
Starting [Frozen-Deps]
Starting [Token-Permissions]
Starting [Security-Policy]
Starting [Active]
Starting [Binary-Artifacts]
Starting [Branch-Protection]
Starting [Automatic-Dependency-Update]
Starting [Code-Review]
Starting [Packaging]
Starting [Signed-Releases]
Starting [Contributors]
Starting [Fuzzing]
Starting [SAST]
Starting [Signed-Tags]
Starting [Vulnerabilities]
Starting [CI-Tests]
Starting [CII-Best-Practices]
Starting [Pull-Requests]
Finished [CI-Tests]
Finished [CII-Best-Practices]
Finished [Pull-Requests]
Finished [Signed-Tags]
Finished [Vulnerabilities]
Finished [Security-Policy]
Finished [Active]
Finished [Binary-Artifacts]
Finished [Branch-Protection]
Finished [Frozen-Deps]
Finished [Token-Permissions]
Finished [Automatic-Dependency-Update]
Finished [Code-Review]
Finished [Packaging]
Finished [Contributors]
Finished [Fuzzing]
Finished [SAST]
Finished [Signed-Releases]

RESULTS
-------
Repo: github.com/ironpeakservices/ironpeak.be
Active: Pass 10
commits in last 90 days: 6
Automatic-Dependency-Update: Pass 10
dependabot config found: .github/dependabot.yml
Binary-Artifacts: Pass 10
Branch-Protection: Fail 0
error, retrying: unable to run check, retry: GET https://api.github.com/repos/ironpeakservices/ironpeak.be/branches/master/protection: 404 Not Found []
CI-Tests: Pass 10
CI test found: pr: 71, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/2562464947uccess
CI test found: pr: 70, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/2538423444uccess
CI test found: pr: 69, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/2047220198uccess
CI test found: pr: 68, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1869356465uccess
CI test found: pr: 67, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1742319108uccess
CI test found: pr: 66, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1742147063uccess
CI test found: pr: 65, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1394778193uccess
CI test found: pr: 64, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1241393060uccess
CI test found: pr: 63, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1229496144uccess
CI test found: pr: 62, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1220173749uccess
CI test found: pr: 61, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1219342719uccess
CI test found: pr: 60, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1219117155uccess
CI test found: pr: 59, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1213255406uccess
CI test found: pr: 58, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1213222539uccess
CI test found: pr: 57, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1213099910uccess
CI test found: pr: 56, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1211288432uccess
CI test found: pr: 55, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1208858344uccess
CI test found: pr: 54, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1208559902uccess
CI test found: pr: 53, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1101086179uccess
CI test found: pr: 52, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/1001734939uccess
CI test found: pr: 50, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/913099939uccess
CI test found: pr: 48, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/802497678uccess
CI test found: pr: 47, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/748852679uccess
CI test found: pr: 45, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/748846063uccess
CI test found: pr: 43, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/669829230uccess
CI test found: pr: 40, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/576318912uccess
CI test found: pr: 38, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/574524134uccess
CI test found: pr: 37, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/554345198uccess
CI test found: pr: 36, context: github-actionsuccess, url: https://api.github.com/repos/ironpeakservices/ironpeak.be/check-runs/515782510uccess
found CI tests for 29 of 29 merged PRs
CII-Best-Practices: Fail 10
no badge found
Code-Review: Pass 10
found pr with committer different than author: 35
found pr with committer different than author: 36
found pr with committer different than author: 37
found pr with committer different than author: 38
found pr with committer different than author: 40
found pr with committer different than author: 43
found pr with committer different than author: 45
found pr with committer different than author: 47
found pr with committer different than author: 48
found pr with committer different than author: 50
found pr with committer different than author: 52
found pr with committer different than author: 53
found pr with committer different than author: 54
found pr with committer different than author: 55
found pr with committer different than author: 56
found pr with committer different than author: 57
found pr with committer different than author: 58
found pr with committer different than author: 59
found pr with committer different than author: 60
found pr with committer different than author: 61
found pr with committer different than author: 62
found pr with committer different than author: 63
found pr with committer different than author: 64
found pr with committer different than author: 65
found pr with committer different than author: 66
found pr with committer different than author: 67
found pr with committer different than author: 68
found pr with committer different than author: 69
found pr with committer different than author: 70
found pr with committer different than author: 71
github code reviews found
Contributors: Fail 10
companies found: ironpeakservices
Frozen-Deps: Fail 10
!! frozen-deps/github-actions - .github/workflows/cloudflare.yaml has non-pinned dependency<EMAIL_ADDRESS>(job 'Clear cloudflare cache')
!! frozen-deps/github-actions - .github/workflows/cloudflare.yaml has non-pinned dependency<EMAIL_ADDRESS>(job 'Clear cloudflare cache')
!! frozen-deps/github-actions - .github/workflows/codeql-analysis.yml has non-pinned dependency<EMAIL_ADDRESS>(job 'Analyze')
!! frozen-deps/github-actions - .github/workflows/codeql-analysis.yml has non-pinned dependency 'github/codeql-action/init@v1' (job 'Analyze')
!! frozen-deps/github-actions - .github/workflows/codeql-analysis.yml has non-pinned dependency 'github/codeql-action/autobuild@v1' (job 'Analyze')
!! frozen-deps/github-actions - .github/workflows/codeql-analysis.yml has non-pinned dependency 'github/codeql-action/analyze@v1' (job 'Analyze')
!! frozen-deps/github-actions - .github/workflows/imgcmp.yaml has non-pinned dependency '9sako6/imgcmp@master' (job 'Optimize images')
!! frozen-deps/github-actions - .github/workflows/netlify.yaml has non-pinned dependency<EMAIL_ADDRESS>(job 'Cloudflare Pages')
!! frozen-deps/github-actions - .github/workflows/netlify.yaml has non-pinned dependency<EMAIL_ADDRESS>(job 'Cloudflare Pages')
!! frozen-deps/github-actions - .github/workflows/zap-daily.yaml has non-pinned dependency<EMAIL_ADDRESS>(job 'Scan public website')
!! frozen-deps/github-actions - .github/workflows/zap-daily.yaml has non-pinned dependency<EMAIL_ADDRESS>(job 'Scan k8s cluster')
Fuzzing: Fail 10
Packaging: Fail 10
!! not a packaging workflow: .github/workflows/cloudflare.yaml
!! not a packaging workflow: .github/workflows/codeql-analysis.yml
!! not a packaging workflow: .github/workflows/imgcmp.yaml
!! not a packaging workflow: .github/workflows/netlify.yaml
!! not a packaging workflow: .github/workflows/zap-daily.yaml
Pull-Requests: Fail 3
found commit with PR: 892d9f27a09ee8ce3a0c7052de32a5633434b83d
found commit with PR: 0eb8b08f5810c77f6b50412d68ea2d570e248e0c
!! found commit without PR: 4326814c4382c6ae890e0127b5479c2afcc24f6f, committer: web-flow
found commit with PR: ffb3d4ff52f7f8fc6ed529c53764e01c54561bcf
found commit with PR: aaa90fa318cf7d7db55f71d0ac8d39736f26aff7
found commit with PR: b12a78c17581f85b30a2e8f08c66f224e90b160d
found commit with PR: b20170bdc582e97a61e4387c2524dc86292df671
found commit with PR: 12973f9334ec01ef63d4a40d5bbf6eedbf533b04
found commit with PR: 6dfb330340115dc5f302c8de675dc53fac1a106e
!! found commit without PR: f5a2a82c44eaae24917a52d6b4de21fd9c2f1f3d, committer: hazcod
found commit with PR: 0d21f7b216e068e255dd3577b3632800f1eb65b4
found commit with PR: a505bb4661868917240f745fd979cbbe789fbff9
found commit with PR: 457435467d21849c3d9df236303a557588b3d38c
!! found commit without PR: 2e6d46c293c3b66bcfa2a9307a3ddff1dd2ea6b7, committer: web-flow
found commit with PR: 746f01c899329d096f16a21e67fbeead8078cb47
found commit with PR: 514bb2b58cc65919f9e72c36de1ee4503c9ac737
found commit with PR: ddaf3ad4dd6a9d51fd6a3b50f6c9ddf370b9bcf6
found commit with PR: 6ed59a66c557c87b770569c266e6ac501d24cad7
found commit with PR: c2cc2ab71ccf9de898ae657dbfbf1fc07da5034e
found commit with PR: 9d02661d3a23072e2a97c5c7ea7a3f67e611febc
found commit with PR: b2172d6fb2caeb50a7e6a0bef0ec5b30cd788816
found commit with PR:<PHONE_NUMBER>364563f9d5e97757f8e434b032ddb3
found commit with PR: f221d7edf2f639b557856e73a17a2eab4e71a1b9
!! found commit without PR: c559664a432e64a31a1111797306416bfa344f1e, committer: web-flow
!! found commit without PR: f6e38b2a9b7281fb1a86c1e21319b6008fd2b2e6, committer: web-flow
!! found commit without PR: 605b5f26ee18ac247b74cd3fa613b6b82c8a8b67, committer: web-flow
!! found commit without PR: faffc4e43bb3b31da6f49ce9a18a52cdd2a98578, committer: web-flow
!! found commit without PR: d753bd952bdc7204aecc359bd4c32d7a7e86447f, committer: web-flow
!! found commit without PR: fe6157ad1bef0b60a3dc73e29ad5ee3a35b4c39c, committer: web-flow
found commit with PR: 5d33a03773f8d6479b6d753f0c19188f57c15b52
found PRs for 21 out of 30 commits
SAST: Pass 10
found CodeQL definition: .github/workflows/codeql-analysis.yml
Security-Policy: Fail 5
Signed-Releases: Fail 0
no releases found
Signed-Tags: Fail 0
no tags found
Token-Permissions: Fail 10
!! token-permissions/github-token - no permission defined in .github/workflows/cloudflare.yaml
!! token-permissions/github-token - no permission defined in .github/workflows/codeql-analysis.yml
!! token-permissions/github-token - no permission defined in .github/workflows/imgcmp.yaml
!! token-permissions/github-token - no permission defined in .github/workflows/netlify.yaml
!! token-permissions/github-token - no permission defined in .github/workflows/zap-daily.yaml
Vulnerabilities: Pass 10

+1. I can't seem to reproduce this either. I ran:
$go version
go version go1.16.5 linux/amd64
$GO111MODULE=on go get github.com/ossf/scorecard
$GITHUB_AUTH_TOKEN="xyz" scorecard --repo=github.com/ironpeakservices/ironpeak.be --show-details

Closing the issue. Please re-open if you were able to reproduce the problem or the problem persists.

Hmm, it's still happening.
Finished [Signed-Releases]
Finished [Signed-Tags]
Finished [Fuzzing]
Finished [SAST]
Finished [Branch-Protection]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x1052773a0]

goroutine 24 [running]:
github.com/ossf/scorecard/checks.IsPrReviewRequired(0x1057e1c18, 0x1400019c000, 0x14000096580, 0x14000010040, 0x14000032360, 0x140001b4343, 0x10, 0x140001b4354, 0xb, 0x140000740f0, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checks/code_review.go:109 +0xf0
github.com/ossf/scorecard/checker.MultiCheck.func1(0x1057e1c18, 0x1400019c000, 0x14000096580, 0x14000010040, 0x14000032360, 0x140001b4343, 0x10, 0x140001b4354, 0xb, 0x140000740f0, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checker/check.go:64 +0xa0
github.com/ossf/scorecard/checks.DoesCodeReview(0x1057e1c18, 0x1400019c000, 0x14000096580, 0x14000010040, 0x14000032360, 0x140001b4343, 0x10, 0x140001b4354, 0xb, 0x140000740f0, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checks/code_review.go:39 +0xac
github.com/ossf/scorecard/checker.(*Runner).Run(0x14000353e40, 0x1057c0f28, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/checker/checker.go:54 +0x148
github.com/ossf/scorecard/pkg.RunScorecards.func1(0x1057e1c18, 0x1400019c000, 0x140001b6498, 0x140001b4338, 0xa, 0x140001b4343, 0x10, 0x140001b4354, 0xb, 0x1400019d570, ...)
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/pkg/scorecard.go:109 +0x1e0
created by github.com/ossf/scorecard/pkg.RunScorecards
	/Users/niels/Source/go/pkg/mod/github.com/ossf/scorecard@v1.2.0/pkg/scorecard.go:89 +0x11c
niels@hyde scorecard % go version
go version go1.16.5 darwin/arm64

Interesting! Probably should include in running on osx as part of the tests. The actions does not support m1 https://github.com/actions/virtual-environments/issues/2187

Is this happening for every repository?

Does not happen for github.com/ossf/scorecard 🤔

FWIW, I am also seeing this issue for the github.com/tern-tools/tern repository and I have seen it multiple times:
$ ./scorecard --repo=github.com/tern-tools/tern
Starting [CI-Tests]
Starting [Fuzzing]
Starting [Active]
Starting [Automatic-Dependency-Update]
Starting [CII-Best-Practices]
Starting [Token-Permissions]
Starting [Pull-Requests]
Starting [SAST]
Starting [Security-Policy]
Starting [Branch-Protection]
Starting [Code-Review]
Starting [Contributors]
Starting [Frozen-Deps]
Starting [Signed-Releases]
Starting [Signed-Tags]
Starting [Binary-Artifacts]
Starting [Packaging]
Starting [Vulnerabilities]
{"level":"warn","ts":1626114096.3972945,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 22m28.602729221s to retry..."}

Starting [Pull-Requests]
{"level":"warn","ts":1626108247.218526,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m59.781488331s to retry..."}
{"level":"warn","ts":1626108247.2402127,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m59.759794276s to retry..."}
{"level":"warn","ts":1626108249.4006603,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m55.599375103s to retry..."}
{"level":"warn","ts":1626108249.4019876,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m55.598019001s to retry..."}
{"level":"warn","ts":1626108249.418286,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m55.581724948s to retry..."}
{"level":"warn","ts":1626108249.4588823,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m55.541129001s to retry..."}
{"level":"warn","ts":1626108249.4828103,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m55.51719988s to retry..."}
{"level":"warn","ts":1626111845.0002537,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.0008707,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.0022173,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.002294,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.0023384,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.151078,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -151.068814ms to retry..."}
{"level":"warn","ts":1626111845.1513531,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.1512365,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -151.233529ms to retry..."}
{"level":"warn","ts":1626111845.1516898,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.1520026,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -151.999506ms to retry..."}
{"level":"warn","ts":1626111845.1521258,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.1526062,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -152.602996ms to retry..."}
{"level":"warn","ts":1626111845.152767,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.1530135,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -153.010675ms to retry..."}
{"level":"warn","ts":1626111845.1531382,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.175641,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -175.633024ms to retry..."}
{"level":"warn","ts":1626111845.1760185,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111845.1759393,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting -175.93623ms to retry..."}
{"level":"warn","ts":1626111845.1763117,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111847.0007164,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111847.0013008,"caller":"roundtripper/rate_limit.go:62","msg":"Rate limit exceeded. Retrying..."}
{"level":"warn","ts":1626111847.190758,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m59.809286457s to retry..."}
{"level":"warn","ts":1626111847.7060697,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m56.293938841s to retry..."}
{"level":"warn","ts":1626111847.8431315,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m56.156876887s to retry..."}
{"level":"warn","ts":1626111847.891055,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m56.10895263s to retry..."}
{"level":"warn","ts":1626111847.9266534,"caller":"roundtripper/rate_limit.go:58","msg":"Rate limit exceeded. Waiting 59m56.073354821s to retry..."}

Assigning this to myself. I still haven't been able to reproduce this (even on MacOS). Will try to get some virtual Mac machine with ARM architecture and see if I can reproduce this issue. I have a hunch that this is coming from https://github.com/ossf/scorecard/blob/main/checks/code_review.go#L142, where BranchProtectionRule is null. Although I want to root cause this and figure out what environment causes this bug.

We have an ARM release https://github.com/ossf/scorecard/releases/tag/v2.1.3, could you please try this and let us know?


Use VerticalTabs in site

WIP

It would be cool if dog fooded this.  Buuuut, no body cares if we have Vert Tab in our site.  And we're probably changing layout someday....
Anyway, I'm disappointed that we can't use the DS component and it makes me wonder about the generality of the component, but for today, closing this.
No merge for you!


Temporary embedded collection

Mongo Aggregations are powerful for reporting purposes. However Mongo does not support joins which makes it hard to report over multiple collections unless you've got a database design that uses embedded collections. This library should have a method to create a temporary collection that unreferences the references in the documents in a collection. A query may be added to the temporary collection to reduce overhead and increase performance.
API will look like:
$temporaryCollection = new EmbeddedCollection($collectionName, $query);
$result = $temporaryCollection->aggregate($aggregationBuilder->build());
$temporaryCollection->remove();

The EmbeddedCollection should know which database it belongs to, so updated the API:
$temporaryCollection = new EmbeddedCollection($db, $collectionName, $query);
$result = $temporaryCollection->aggregate($aggregationBuilder->build());
$temporaryCollection->remove();

The remove function should be compatible with MongoCollection (and therefor be called drop).


added ne methods for python 2 compatibility

python2 does not automatically use __eq__ for __ne__ implementation. Everything else in here seems to work with python2, but by not implementing __ne__ , this check raises an error whenever restarting from an existing database in python 2.
Bug demonstration:
import chocolate as choco
space0 = choco.space.Space({'a': choco.uniform(0, 1)})
space1 = choco.space.Space({'a': choco.uniform(0, 1)})
print(space0 == space1)                          # True, as expected
print(space0 != space1)                           # False <-------------- very unexpected

print(space0.spaces == space1.spaces) # True, as expected
print(space0.spaces != space1.spaces) # False, as expected

Sorry about the whitespace changes - only just noticed them... happy to roll back and re-issue if that's a problem...

Looks good to me.


Forward the host REST port to 5000 instead of 3000. Fixes #1528

Description
This changes the host REST port from 3000 to 5000. This matches the peer REST port.
Motivation and Context

The fact that the peer REST port used 5000, but if using Vagrant the host port was mapped to 3000 caused confusion. It was mentioned by @ghaskins and @bmos299 as a point of confusion. There is no reason why port 5000 cannot be used on both the Vagrant host and in the peer.
Fixes #1528
How Has This Been Tested?
Ran make checks, No new tests are required because this PR does not add new functionality.
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by<EMAIL_ADDRESS>To maintainer: after review and before clicking merge
a) Send an email to the Fabric mailing list and post in the #Fabric channel in Slack
b) Contact me and ask me to do so.
In the message, we'll need to indicate that running vagrant halt vagrant up is necessary due to the port change.

This LGTM but I will wait for @angrbrd review, and then coordinate with @srderson for the red-flag changeover before merging.

@angrbrd suggested swapping this fix so that 3000 is the default port on both sides. This would result in no impact for people running a peer in Vagrant and connecting to it from their host, but would impact people running the peer outside of Vagrant. Any thoughts @ghaskins or @mastersingh24?

My tools already assume 3000, so this is the best case scenario for me.
+1

@srderson @angrbrd Why have an unnecessary port mapping?  When someone starts a peer and observes a log message for port 5000 and the core.yaml has port 5000, and they have to connect to Port 3000, that is opening the door for a permanent usability question.   If we change the Port to 5000, there will be a short-term issue for some people (agreed).  However, it is a long-term win.

@bmos299 I think the proposal is to get rid of the remapping.  Now it's just a question of what is the port we want to use consistently across the environments.  I don't have a strong opinion, but picking 3000 is slightly less work for me since I already use that as the default in two tools.

@ghaskins thanks.  I think as a whole the community is more accustomed to 5000.  I think we are better off changing a mapping parm than the system (fabric) default.

@bmos299
@ghaskins is correct. The point of this PR is to remove the port re-mapping in order to eliminate any confusion on the client side. However, as @ghaskins also states, we already have applications hitting port 3000 from outside of Vagrant, which is why I am suggesting to keep that as the exposed port. That would remove any client side impact.

@angrbrd would it be best to open a new issue for this topic?  We have a lot of good detail here.  My point is I can't see changing a product default to accommodate tooling.   Many people (including the team in the lab) use port 5000 directly.

@bmos299 I don't think the issue is accommodating tooling. The issue is disrupting existing applications that already use port 3000 as the default REST interface port. IMHO that would take priority over any tooling that we have. That being said, I would defer the answer to this question to @mastersingh24 @mrshah-at-ibm @masterDev1985 as that team has built legitimate applications on top of this port and unless they have changed it in the Bluemix deployment, it effects that service also. I would like to hear their opinion.

We use port 5000 on the peer as our API port. We'd like to keep it 5000.

@mrshah-at-ibm thanks. @srderson @ghaskins then I think it makes sense to keep the change as is, but send out a note to the Slack channel to alert people prior to this change going in.

LGTM, Thanks!
Reviewed-by: Greg Haskins<EMAIL_ADDRESS>


dashboards: remove apiserver_request_total client label

Related issue: https://github.com/kubernetes/perf-tests/issues/1002

/assign @mm4tt

/lgtm
/approve
Thanks, @hypnoglow !

/ok-to-test

/retest

/retest

Closed and reopened to trigger travis.

/retest

/retest


[4.5] fix: errors when not updating Config\Feature

Needs #8569
Description

add code for backward compatibiltiy

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

This is a bug fix in 4.5. Please review.


1.0.25 is very slow

I've just updated to the 1.0.25 and every action is taking a very long time.
for example creating a new task or moving it to another column.
It looks like the system hangs for a couple of minutes.
The spinner keeps spinning.

You could log into the debug file, to find out wich step is ataking so long.
https://github.com/fguillot/kanboard/blob/master/doc/config.markdown#enabledisable-debug-mode

I've found out that the problem is in sending mail.
It takes 120 seconds to send mail to one user.
I have now disabled mail notifications and will try to reconfigure the mail settings untill it's working faster.

Maybe this issue could help: https://github.com/fguillot/kanboard/issues/1202#issuecomment-139455748


Question about scheduling of ROI modes during training

Hi, great work! I find your training set up quite interesting and wanted to get a bit more detail as to ho wyou managed to get such a flexible inference editing mechanism.
I understand that during training you use batches of both bounding box and free-form ROIs, inlcuding also empty channels, accompanied with the adequate conditioning vector.
I would like to know how do you select when to use each of the ROI modes. Are they selected randomly? Did some of the ROI perform better than others? Does empty channel mean a tensor of zeros?
Also, do you have plans of publishing a quantitative evalution?
Thanks!

maybe this will help
https://bit.ly/3XQLHlH
If you don't have the c compliator, install it.(gcc or clang)

Could you provide detail as to what this is? Thanks!


ClientMetrics will mark metrics before connection has closed

Metrics are being recorded here before we actually close the connection: https://github.com/http4s/http4s/blob/80df97e1fdb1d764059acafcd1f4331135964560/client/src/main/scala/org/http4s/client/middleware/Metrics.scala#L46
The finalizer for the client.run won't run until after the metrics have been marked. When you use the Resource you'll mark your metrics before you've finished consuming the body, which could potentially skew the metrics.
A fix could be marking the metrics as a part of the client.run's Resource release function.
Conversation in gitter: https://gitter.im/http4s/http4s?at=5beef2645f5c925040699ecb

This is something I can look into fixing.


admin permissions

providing a user with mod permissions does not change anything

The user has to log in again to receive the new token. I noticed this isn't working perfectly yet though


VCTK Using Path and glob instead of walk_files

Remove walk_files from VCTK dataset
Fixes:
#1051
#1069

This PR was not tested as this dataset is no longer available.

Thanks! @krishnakalyan3


Overflow from page 2!

The portfolio is good overall but there is overflow from page 2 to the last page when I view it on my desktop

do you mean delay / lag when moving from page 2 to 4?

do you mean delay / lag when moving from page 2 to 4?

Nope, the whole page is giving a overflow scroll, which means some elements in the page are beyond the view port, which makes the website looks unresponsive at desktop screens.

Sorry, actually the concept is like that, only page 1 doesn't have overflow Y / full h-screen. Because pages 2 to 4 will continue to add content and require overflow.
Therefore, I give the fixed styling for navigation on page 2-4 to stay in top layout when scrolling.

maybe as a marker later I will add the "down arrow" icon and when scrolled it will disappear/hidden.

btw thanks for reviewing my repo 🙏


[IRGen] Restored single refcounted object opt for async partial applies.

As part of bringup, specifically in order to support storing the size of the async context as the first entry in the thick context, the optimization that allows the partial application of a single refcounted object to avoid the allocation of a thick context was disabled.
Now that we have async function pointers for partial application forwarders, that rationale is moot, so, here, the optimization is restored.
rdar://76372871

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 533f06215fe83ea2605183fb333500b5d42ee66a

Build failed
Swift Test OS X Platform
Git Sha - 533f06215fe83ea2605183fb333500b5d42ee66a

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 3c04b1933bd3ab28699b7886deb95340a90dfb42

Build failed
Swift Test OS X Platform
Git Sha - 3c04b1933bd3ab28699b7886deb95340a90dfb42

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 13bef6b8449793280054b2759055249db033fb27

@swift-ci please test linux platform

Build failed
Swift Test Linux Platform
Git Sha - 13bef6b8449793280054b2759055249db033fb27

@swift-ci please clean test linux platform

Build failed
Swift Test Linux Platform
Git Sha - 13bef6b8449793280054b2759055249db033fb27

@swift-ci please test linux platform


cmake pkgconfig can't find gstreamer-1.0 pkg conf

-- Found Threads: TRUE
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for module 'gstreamer-1.0'
--   No package 'gstreamer-1.0' found
CMake Error at /usr/local/share/cmake-3.14/Modules/FindPkgConfig.cmake:457 (message):
A required package was not found
Call Stack (most recent call first):
/usr/local/share/cmake-3.14/Modules/FindPkgConfig.cmake:642 (_pkg_check_modules_internal)
gst/common/CMakeLists.txt:13 (pkg_check_modules)

The directions of this project do not specify the pre-requisites. I installed following after above comment and now cmake proceeds.
sudo apt-get install libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev

BTW, Did you try to build via docker?

There are script available to install dependencies gst-video-analytics/scripts/install_dependencies.sh

@alalek. I did not yet build via docker.
@SDxKeeper : Thanks for pointing out the script. It's not mentioned in the "Build-on-host-machine" wiki. Furthermore, it downloads MediaSDK. But if OpenVINO is installed (I use 2019 R1), the script should check OpenVINO based paths for mediasdk. My preference is to use MediaSDK and if needed OpenCV that is installed as part of OpenVINO.

@js07920 yes this is expected behavior,  because gstreamer video analytics plugins were released for openvino 2018 r5, which had incompatible media SDK stack. In next release with official support of openvino 2019 r1, this dependency will be removed for package based installations.

Hi @js07920 ! We've made some significant improvements in our documentation. You're welcome to review and try it: https://github.com/opencv/gst-video-analytics/wiki/Getting-Started-Guide-[R1.2]
If issue with missing packages is not resolved for you, please reopen this issue with additional details


Next release roadmap

Description
This issue keeps track of the main features we should deliver in the upcoming release

[ ] In memory mode
[ ] Go client
[ ] Attach any remote database (e.g. sqlite,  Postgres, DuckDB, ...) #4007
[ ] Execute cypher over relational database
[ ] Graph algorithm package

Performance improvement

[ ] Floating point compression
[ ] Projection & filter push down to relational database scan #3979
[ ] Zone map
[ ] #4013
[ ] #4010

Shall we rename this to 0.6.0 release roadmap? TO be more specific.

I don't mind, but @ray6080 apparently thinks some of the features should be delivered in v0.5.1

I don't mind, but @ray6080 apparently thinks some of the features should be delivered in v0.5.1

I think it's unclear what's the scope of v0.6.0 yet. We need to discuss this internally first.

The CSV Sniffing PR Fixes Decimal Comparison as well. It should be released.

@ray6080 I made some minor modifications to the bullets above, please review.

This was originally for v0.7.0 but we don't seem to still have the record. I'm closing this and open a new one for v0.8.0


Error, invalid type: string expected struct (in json but not toml!), but struct impl custom Deserialize

Hello,
I made a custom deserialize for a struct. It appears to work with the toml crate, but not serde_json.
edit: I appear to have resolved the issue by using deserialize_string instead of deserialize_struct, but would appreciate some explanation why since it's a bit confusing to me what the hint should be. Also, it's still odd to me that it worked with the toml crate, but perhaps that's another issue to file.
The tests:
running 2 tests
test test::test_deser_toml ... ok
test test::test_deser_json ... FAILED

failures:

---- test::test_deser_json stdout ----
thread 'test::test_deser_json' panicked at 'called `Result::unwrap()` on an `Err` value: Error("invalid type: string \"+123456789\", expected struct PhoneNumber", line: 1, column: 22)', libcore/result.rs:945:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

versions:
[dev-dependencies]
serde_json = "1.0.32"
toml = "0.4.8"

custom impl Deserialize and tests:
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct PhoneNumber {
    number: String,
}

impl<'de> Deserialize<'de> for PhoneNumber {
    fn deserialize<D>(deser: D) -> Result<PhoneNumber, D::Error>
        where D: Deserializer<'de>
    {
        struct PhoneNumberVisitor;

        impl<'de> Visitor<'de> for PhoneNumberVisitor {
            type Value = PhoneNumber;

            fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
                formatter.write_str("struct PhoneNumber")
            }

            fn visit_str<E>(self, value: &str) -> Result<PhoneNumber, E>
                where E: de::Error,
            {
                Ok(PhoneNumber {
                    number: value.to_owned(),
                })
            }

            fn visit_string<E>(self, value: String) -> Result<PhoneNumber, E>
                where E: de::Error,
            {
                Ok(PhoneNumber {
                    number: value,
                })
            }
        }

        //deser.deserialize_struct("PhoneNumber", &["user_phone"], PhoneNumberVisitor)
        // edit now works:
        deser.deserialize_string(PhoneNumberVisitor)
    }
}

impl Serialize for PhoneNumber {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
        where S: Serializer,
    {
        serializer.serialize_str(&self.number)
    }
}

#[cfg(test)]
mod test {
    use serde_json;
    use toml;
    use std::collections::HashMap;

    use super::*;

    #[test]
    fn test_deser_json() {
        let json = r#"{"phone": "+123456789"}"#;

        let mut expected = HashMap::new();
        expected.insert("phone".to_owned(),
            PhoneNumber {
                number: "+123456789".to_owned(),
            },
        );

        assert_eq!(
            serde_json::from_str::<HashMap<String, PhoneNumber>>(&json).unwrap(),
            expected,
        );
    }

    #[test]
    fn test_deser_toml() {
        let toml = r#"phone = "+123456789""#;

        let mut expected = HashMap::new();
        expected.insert("phone".to_owned(),
            PhoneNumber {
                number: "+123456789".to_owned(),
            },
        );

        assert_eq!(
            toml::from_str::<HashMap<String, PhoneNumber>>(&toml).unwrap(),
            expected,
        );
    }
}

Glad you got it working!
Deserialize_string indicates that the Deserialize impl expects input which is a string, like "+123456789" in JSON. Deserialize_struct indicates that the Deserialize impl expects input which is the JSON representation of a struct -- {...}. Data formats may or may not respect these hints, so I guess the toml format currently does not.


Updates/vulnerabilities fixed by audit fix

This PR is fixing the issue #42

I`ll review this later today


Add multi repo support, comma separated

@balvig ♻

Could you check whether the other reports support this? Some of them use custom filters so may be necessary to use repo_query there as well!

Could you check this too? 🙇 🙏

@balvig ♻


ResNet Implementation does not match Paper

Comparing the ResNet bottleneck implementation between TensorPack and Kaiming He's own GitHub, I noticed several discrepancies. Specifically, I'm looking at Kaiming He's code here: https://github.com/KaimingHe/resnet-1k-layers/blob/master/resnet-pre-act.lua

When using bottleneck blocks, the stride-2 convolutions for downsampling are performed at different locations:

in Kaiming's code: the first 1x1 convolution in each block performs the downsampling with stride-2 (here)
in TensorPack: the middle 3x3 convolution in each block performs the downsampling with stride-2 (here)

When using "basic blocks," the treatment of the first block in a group is different

in Kaiming's code: BN+ReLU are applied prior to all blocks.
in TensorPack: BN+ReLU is applied to all blocks except the first block of the first group.

Also, there seems to be a typo in TensorPack's imagenet_resnet_utils.py file. On lines 130 and 134, BNReLU is called with BNReLU(preact_type, input) even though the definition of the BNReLU function takes arguments in the opposite order BNReLU(input, preact_type).

As said in the readme, this implementation follows the architecture in fb.resnet.torch.
And this is the file I referred to: https://github.com/facebook/fb.resnet.torch/blob/master/models/preresnet.lua
The arguments of BNReLU is BNReLU(layer_name, input).


Defer reading images list to end of preprocessing

In the current preprocessing design, list of images is generated during gen-list target. However, this relies on listing image formats in a configuration file and not relying on <image> element references, since key defined images are not processes at that point. An alternative design would be to create a list of images during image-metadata target where image dimensions are read. This would allow getting an accurate list of images that doesn't rely on @format or file extensions.

No image list is generated, the images are copied based on job configuration list directly. Copying still doesn't happen at the end of preprocessing. A better approach could be that each transtype handles the copying.

The DITA Community map-driven processing use a final-phase process for generating an Ant script that then does the copying. This process operates on the images in the content and also provides an extension point so that you can add anything else you want to the copying process. This approach might be a useful model.
I took the approach of generating an Ant script because that seemed like the simplest solution that didn't require custom Java code to do the copying.

I'm seeing that images that are the target of a key definition (<keydef keys="mykey" href="image"/>) are not copied to the output, even if they are referenced elsewhere by an <image href="image">. Is this an expected result of the current behavior?

@shaneataylor you have to use format="image" on the key. This will be partially fixed when this feature is implemented.
In any case you should not claim mykey in your example is a DITA topic (omitting @format means target is a DITA topic), you should use e.g. format="image" or format="png".

These were actually external MathML, with format="mml" set in the key definition and customization to pull them into the generated HTML. I was able to work around the problem by removing the keydefs altogether as the reason I needed them no longer exists.


ERROR: Action platform/web/swagger/_validate_swagger_options.optionsvalid.d.ts failed: missing input file

Having really strange issue. Removed any swagger related code, but still getting this error. Not sure where it is coming from.
» yarn bazel build //platform/web/swagger
yarn run v1.22.11
$ yarn run bazelisk build //platform/web/swagger
$ /home/dzintars/code/github.com/dzintars/prime/node_modules/.bin/bazelisk build //platform/web/swagger
INFO: Invocation ID: ba9db120-fa8d-4ec6-9e38-e68669c99bf9
INFO: Analyzed target //platform/web/swagger:swagger (2 packages loaded, 8 targets configured).
INFO: Found 1 target...
INFO: Writing explanation of rebuilds to 'bazel-explain.txt'
ERROR: /home/dzintars/code/github.com/dzintars/prime/platform/web/swagger/BUILD.bazel:10:11: Action platform/web/swagger/_validate_swagger_options.optionsvalid.d.ts failed: missing input file '//platform/web/swagger:swagger.json'
Target //platform/web/swagger:swagger failed to build
ERROR: /home/dzintars/code/github.com/dzintars/prime/platform/web/swagger/BUILD.bazel:10:11 Action platform/web/swagger/_validate_swagger_options.optionsvalid.d.ts failed: 1 input file(s) do not exist
INFO: Elapsed time: 0.196s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
FAILED: Build did NOT complete successfully
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It was leftover in the root build file what caused strange behavior.


set python explicit during transistion

this will allow for easier switching back and forth during development on python 3 functionality
Description

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

regular use on a default python3 platform

we don't use pyenv from mvn do we?

@GabrielBrascher then you have to change your version to the one you did install, or not set it at all. I have to switch between 2 and 3 as well. That is exactly the point of the change. after transistion it should read some 3 version or be deleted if we want to... I'm not sure if just 2 or just 3 works.
if there is no interest in this, I'll just close.

@DaanHoogland I have no particular issue with this change, considering it is meant to the transition from Python 2 to 3.
The issue that I raised is that if this PR gets merged then Travis will fail for all PRs based on the master.
We should then check what version Travis has installed and set to that version or see what we can do to change Travis version. Otherwise, all PRs will have the following issue pyenv: version '2.7.18' is not installed (set by /home/travis/build/apache/cloudstack/.python-version).

@DaanHoogland can this be closed?


Upate url docs - changes in slug.

Fix Url Docs
I changed the slug of the documentation links, because they had spaces in them and were therefore interpreted as different characters, but now we've added a slug separated by “-”.
:heavy_check_mark: Checklist

[✅] Documentation added or updated
[✅] All your commits have a Signed-off-by line in the message.

Hey @ValberJunior :wave:
Looks like this is missing a DCO sign-off in the commit, you can fix it by doing git commit --amend --signoff and then force push the branch back.

@ValberJunior, could you please reabse the pull request with master, it seems to contain changes that are out of context with the pull request

@ValberJunior, could you please reabse the pull request with master, it seems to contain changes that are out of context with the pull request

For some reason, another context has been pulled in. Even if I push my commit, the old context is not lost. Since it's a subtle change, I'll redo the pull request :/


fmap causing kernel to hang.

The following code seems to cause the kernel (7.10.3) to hang, in a notebook, while running fine in ghci:
x = Just 1
:t x
x
y = id <$> x
:t y
y

(Of course, in ghci, there are "let"s in front of "x = ..." and "y = ...".)
Changing "id" to "(+ 1)" produces the expected result:
x :: forall a. Num a => Maybe a
Just 1
y :: forall b. Num b => Maybe b
Just 2

Is there any error output from the console? This seems very strange.

Sorry, I don't seem to be able to launch the console:
Davids-MacBook-Air-2:fft-ccc dbanas$ ipython console --kernel haskell
Traceback (most recent call last):
File "/Users/dbanas/anaconda/bin/ipython", line 11, in
sys.exit(start_ipython())
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/IPython/init.py", line 118, in start_ipython
return launch_new_instance(argv=argv, **kwargs)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 591, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 75, in catch_config_error
return method(app, *args, **kwargs)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/IPython/terminal/ipapp.py", line 305, in initialize
super(TerminalIPythonApp, self).initialize(argv)
File "", line 2, in initialize
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 75, in catch_config_error
return method(app, *args, **kwargs)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/IPython/core/application.py", line 386, in initialize
self.parse_command_line(argv)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/IPython/terminal/ipapp.py", line 300, in parse_command_line
return super(TerminalIPythonApp, self).parse_command_line(argv)
File "", line 2, in parse_command_line
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 75, in catch_config_error
return method(app, *args, **kwargs)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 487, in parse_command_line
return self.initialize_subcommand(subc, subargv)
File "", line 2, in initialize_subcommand
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 75, in catch_config_error
return method(app, *args, **kwargs)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/traitlets/config/application.py", line 418, in initialize_subcommand
subapp = import_item(subapp)
File "/Users/dbanas/anaconda/lib/python2.7/site-packages/ipython_genutils/importstring.py", line 31, in import_item
module = import(package, fromlist=[obj])
ImportError: No module named jupyter_console.app

I'm not sure whether this is helpful, but this:
Just id <*> Nothing

works, while this:
(Just id <*> Nothing) == Nothing

causes the kernel to hang.

This simpler test also causes the kernel to hang:
Nothing == Nothing

@capn-freako Thanks for the report. Just managed to reproduce this.
Very strange behaviour. I'll try to figure out what's going on soon. Whatever it is, it's very strange:
-- works
x = Just id <*> Nothing

-- doesn't work
x = (Just id <*> Nothing)

I have no clue what could cause something like this or how it is just being reported now.

I tried 7.10.2 and 7.10.3 on archlinux x86_64: same problem.
Apparently this is caused by a deadlock in runStmt at:
goStmt :: String -> Ghc RunResult
goStmt s = runStmt s RunToCompletion

but I don't know how to debug it.

Kernel doesn't hang but "teminates the zmq context":
ihaskell: ZMQError { errno = 156384765, source = "getIntOpt", message = "Context was terminated" }
ihaskell: ZMQError { errno = 156384765, source = "getIntOpt", message = "Context was terminated" }
ihaskell: ZMQError { errno = 156384765, source = "send", message = "Context was terminated" }
ihaskell: printf: formatting string ended prematurely

Finally i figured out what's happening.
Code snippets that cause crash doesn't seem to have nothing in common - but they have it instead!
Running "Nothing == Nothing" gives an unexpected result before evaluation:
Line 1: Use isNothing
Found:
Nothing == Nothing
Why not:
isNothing NothingLine 1: Use isNothing
Found:
Nothing == Nothing
Why not:
isNothing Nothing

The reply is unexpected and makes the zeromq communication stop - the ihaskell kernel continues to run!
Being an haskell beginner I don't know how to disable this message (it appears to be an interactive GHC hint).
BTW disabling these "hints" is just a workaround so it could be a good idea showing this messages in Jupyter pager pane.

It's the ihaskell lint causing the problem.
Disabling it with:
:opt no-lint

solves the problem (e.g. kernel doesn't hang anymore).
As I told before it's just a workaround.

It's a small_slip in the Lint code:
--- a/src/IHaskell/Eval/Lint.hs
+++ b/src/IHaskell/Eval/Lint.hs
@@ -187,7 +187,7 @@ htmlSuggestions = concatMap toHtml
             _ -> "warning"

     style :: String -> String -> String
-    style =  printf "
%s
"
+    style =  printf "
%s
"

     named :: String -> String
     named = printf "
%s
"

Do you need a pull request?

Thanks for finding the fix!! You can send a PR if you want, otherwise I'll be happy to apply the patch.

Thanks @franklx for handling this one, closing


feat: Allow Opt in to Codec Switching

Reference implementation for codec switching.
Resolves: https://github.com/shaka-project/shaka-player/issues/1528
Related: https://github.com/shaka-project/shaka-player/issues/4379

Extended StreamingConfig with new enumerated property codecSwitchingStrategy.
Allows for 3 strategies as referenced in original conversation with @theRealRobG .
-- DISABLED is current Shaka behavior.
--SMOOTH behavior allows for use of SourceBuffer.changeType on environments which support it.
--RELOAD behavior replaces MediaSource instances.

@tjohnson-nbcuni Thanks for your PR! Can your sign the CLA? Can you rebase and resolve the conflicts?

@avelad - Yep, jumping through the CLA hoops now. Updated and fixed merged conflicts previously.

@avelad - CLA signed. Rebased and merge conflicts resolved.

Hey guys !
I've been thinking about this PR and also testing it, and I think the decision we took to initiate/control the codec switching from inside the streaming engine, doesn't feel right, 1st because it's an implementation detail of the media source, I think only the media source engine, and the main player flow (because of filtering) should be aware of it, and 2nd because of the complexity and async nature of the streaming engine, it's really hard to refactor it so it doesn't break when there's an ongoing media source reset operation originating from a call to variantSwitch, and 3rd, there's a lot of spooky calls we're doing in the streaming engine on the reload strategy (like calling initStreams_ again).
I think we should revisit this, to see if we can isolate the code switching logic inside the media source, specifically at the call to append by looking at the reference's codec. The media source already has protective measures for blocking operations and we can make the append only return after the media source & buffers are re-created.

Codec-switching should also impact logic in period-flattening.  Currently, multi-period DASH content uses codec compatibility rules to decide what to connect across periods.  If codec-switching is allowed, that means many more connections are possible (and consequently that we either need much more removal of redundant streams or much earlier removal of redundancies during the period-processing stage).
Addressing that may turn out to be much uglier or more performance-impacting than anything else I've left feedback on, but I think we need to understand how we will address that before this PR can be merged.
Thanks so much for your work on this feature, though.  I think this is moving in the right direction.

Codec-switching should also impact logic in period-flattening. Currently, multi-period DASH content uses codec compatibility rules to decide what to connect across periods. If codec-switching is allowed, that means many more connections are possible (and consequently that we either need much more removal of redundant streams or much earlier removal of redundancies during the period-processing stage).
Addressing that may turn out to be much uglier or more performance-impacting than anything else I've left feedback on, but I think we need to understand how we will address that before this PR can be merged.
Thanks so much for your work on this feature, though. I think this is moving in the right direction.

Hey @joeyparrish !
I think I understand what you mean... so, if we had for example:
Period 1:
- Audio adaptation 1: en - main - 2 channels - aac

Period 2:
-  Audio adaptation 1: en - main - 2 channels - ec3

should the player consider period 2 audio adaption 1, an extension of audio adaption 1 from the 1st period ?
If it should, then the period combining logic would need significant changes...
The thing is we don't really expect this scenario to be possible on our streams, but instead we expect all streams  to have a matching configuration including the same codec across all periods. This codec switching feature instead for us is mostly to provide a solution for streams that have some audio languages that are encoded in a single codec, different from the main audio but still supported by the decoder.
Could you still consider accepting the logic on this PR without support for that more lenient combination of streams ?
I suggest we change the default codec switching strategy to NO_SWITCHING as default, allowing explicit opt-in if desired, until we decide how to cater for that problematic scenario.
Thank you for the review.

Hey !
Sorry for letting this go stale for so long... we've been testing this feature across our supported devices and are now getting ready to release it to prod using the RELOAD strategy enabled by default, the reasoning was to support the lowest denominator 1st, and then after we assess KPIs, proceed with testing the SMOOTH strategy across more devices to build a support whitelist.
There were a couple of device/models where we saw unexpected behaviour with the RELOAD tho, for example on Xbox, we found that sometimes when resetting the media source, the video would freeze while audio playback continued playing, and on Tizen 3 we observed that the player would sometimes enter an intermitted seeking behaviour, so we ended up disabling the feature on those until we can investigate it further.
Now, about this pull request, since we've moved on by splitting it into two and already merged the codec switching logic inside the media source and streaming engines (https://github.com/shaka-project/shaka-player/pull/5217), I think we should close this one.
Meanwhile, not sure what're your plans for the filtering logic changes, but we've opted to not further filter out any supported variants by media capabilities, when the codec switching logic is enabled, even on scenarios where both codecs are available for the same lang & role, the reasoning being we do the filtering on the application side based on our rules that give preference to a higher channel count and only then to codecs based on a set order of preference, but we're not sure this would be a desirable behaviour for every app.
The main issue with our approach, is that the initial track selection logic done by the preference based adaptation set criteria, must match our filtering logic, otherwise that track can potentially be outside the options we provide the user with.
A potentially better alternative would be to still run filtering of multiple supported audio tracks that share the same lang & role inside the player, but somehow let the app customize the decisioning logic.
For example, by default the player could opt between duplicate tracks, based of the following order:

channel count pref
codec pref
bandwitdh

but if the app provides a custom audio track selection method through config, for example:
isPreferredAudio(track: shaka.extern.Track, candidate: shaka.extern.Track):boolean then the player would use this function instead to filter the manifest of duplicate audio tracks.
Thoughts ?

I'm going to close this PR because the internal codec switching logic is already done, only the variant filtering part is missing to leave variants with different codecs.
If anyone wants to work on this, there are several files that need to be modified:

For the ABR you have to modify https://github.com/shaka-project/shaka-player/blob/main/lib/media/adaptation_set.js , but keep in mind that the ABR should only do SMOOTH transitions (isChangeTypeSupported () == true)
It would be necessary to modify the logic to maintain variants, this logic is in https://github.com/shaka-project/shaka-player/blob/main/lib/util/stream_utils.js (chooseCodecsAndFilterManifest method)
We should review the logic of the filterManifestWithStreamUtils_ method (at https://github.com/shaka-project/shaka-player/blob/main/lib/player.js) to avoid filtering variants that do not have the same codec.

Point 1 and 3 are easy to implement. Point 2 is where all the logic is.


chore: update to Quarkus 3.3.0.CR1

Are we putting this to main with CR? What if meanwhile needs to a patch release?

Should not be rather just  a test branch for CRs?

Yes, this isn't meant to be merged yet, just wanted to get a CI run on it.


[v12] packet forward middleware

Integrates v4 of https://github.com/strangelove-ventures/packet-forward-middleware into the transfer middleware stack to enable atomic multi-hop through Juno.
callback flow: hooks -> ics29 fee -> packet forward -> transfer module
send packet direction: transfer module -> packet forward -> hooks -> channel
ibctest e2e test here

Upgrade from v11 -> v12 worked for me after that

Thank you, I applied those changes.

junod tx ibc-transfer transfer transfer channel-0 "juno1hj5fveer5cjtn4wd6wstzugjfdxzl0xps73ftl|transfer/channel-1:juno10c3slrqx3369mfsr9670au22zvq082jaej8ve4" 111ujuno $CHAIN_A_ARGS --packet-timeout-height 0-0

The packet forward middleware no longer uses an overloaded receiver. The migration is documented in this PR
We don't have example bash scripts, but you can run the packet forward middleware e2e test in ibctest and swap out for a local/remote juno image.

As implemented doesn't this break IBC hooks?

As implemented doesn't this break IBC hooks?

@faddat - It does not break IBC-Hooks, seems to work just fine:

ok.  I was about to do the check you've now done.  lgtm


fix rescaled vectors

Issue #, if available:
Description of changes: fix rescaled vectors by applying the correct formula
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you please rebase back to main? It's a little difficult to figure out what has changed in this PR.

Hi! Sorry for the confusion, I just rebased the branch. Please review the PR when you have time.

Can you please do the merge?


Update devDependencies and docs

Landed in https://github.com/metarhia/common/commit/1a138fa5897e28da22afc640f8f889255fc7e31c and https://github.com/metarhia/common/commit/133a8a4a1465886270abda1e302db3672b351ffd.


GitHub Orgs not populating properly

When trying to use the App Service Static Web Apps through the Azure portal. It seems that after signing into GitHub the organizations that populate are not complete. I asked at Build what organizations should populate and was told that Admin access was required on the repository in order for it to create the Static Web App. This makes sense to me and I agree, but not all the repositories that I am admin or owner on are available.
When I sign in using this account, the only visible org to select in the drop down is FirstCraftyBrother as in my personal repositories. I expect to be able to see the 4CraftyBrothers org as well as I am the owner and admin to that org which has public repositories in it that I am also the owner of.

It sounds like something may have gone wrong in the auth flow. Can you try removing the OAuth registration and try again? Here are the steps from removing the Azure Static Web App app registration:
On Github, click on the user drop down in the top right. Then click settings, then applications, and finally Authorized OAuth Apps. Here you will see an Azure Static Web App registration that you can delete.
Let us know if that fixes things!

This was the issue, thank you!


GetECDSAPrivateKeyImportOpts constructor for BCCSP.KeyImport usage

It's possible to implement your own CryptoSuite because of wrapped public interfaces, but inside SDK uses internal BCCSP which has a list of available opts and verifies passed opt using reflection on internal structs https://github.com/hyperledger/fabric-sdk-go/blob/main/internal/github.com/hyperledger/fabric/bccsp/sw/impl.go#L147.
While it's still arguable how to implement and solve this issue (with or without internal) this PR allows to use KeyImport method with ECDSA following KeyGen way.

@kopaygorodsky Please include your full name in the DCO sign-off.


[SC] Crash while using the windows 10 cutscene fix (generic UE2 fix)

it crashes upon start giving me an empty error log

Does it crash with that cutscene option enabled, or in both cases?

which option? i meant this file
http://community.pcgamingwiki.com/files/file/643-windows-10-custom-d3d8-dll/

Ah, what is it and why do you need it?

because in windows 10 all UE2 games (with the exception of most of the UE2.5 games, which are compatible with opengl due to the linux port) have problems rendering FMV's (it flickers... a lot) and crash randomly because of an unknown issue with DX12/DX11, this patch forces DX9/DX8/DX7 (depending on the game) which fixes this problems, since SC has a decent amount of FMV's i wanted to fix this, but it seems that i have to either deal with a broken UI or some epilepsy-inducing cutscenes.

But I'm using windows 10 and I made fixes for all 4 splinter cells and never noticed anything you're saying.

So, I downloaded that file, and it's just "enbconvertor". I don't see a point in using this. Also last time I tried d3d8to9 wrapper on Pandora, it crashed too, but that has nothing to do with widescreen fix.

could you please specify which fixes you used in the first splinter cell, because it seems to crash when i have both at the same time but working just fine when they are separte

I don't have any fixes other than widescreen fix.

damn, thanks anyway man, if i find a fix i'll put it here so anyone with the same problem can fix it

Oh, I see now what you mean. In fullscreen mode whenever FMV is played screen flickers, is that right?

The reason it never happened to me is because I usually test games with different resolutions in windowed mode. Anyway, here's what you can do:

in SC\system folder(where you copied the fix), make a copy of msacm32.dll
rename that copy to d3d8.dll
create an empty file with a name 'wndmode.ini'
That way the game will run in borderless windowed mode, should be enough to workaround the problem.

WOW, that fixed it, thanks man, the only problem now is that the ubisoft logo intro seems to crash the game after a few seconds, but it gives me enough time to skip it, also, the cutscenes are on the native resolution, which makes them letter boxed, but its no longer flickering so they are compleatly watchable in a 768p setup.
thanks to your fix and your hd textures, now i can enjoy this game for the first time just like the hd collection.

Oh yeah, I noticed that in windowed mode FMV could "hang" the game sometimes, but it seems like running the game with winxp compatibility mode helps to avoid that.

the cutscenes are on the native resolution
That was done on purpose, because the game switches to 640x480 to make FMV fullscreen, I simply don't approve that behavior. And there's an option inside of the inis, to make them stretch to fullscreen, but with this almost all FMVs become invisible, just black screen with a sound. Luckily it's no longer an issue since pandora.

Im sorry, but i need your help once more, it seems to have stoped working, although, once i delete (or make read-only) the wndmode.ini file it works, but with the flickering cutscenes


[BUG] unable to setup NFS backup-target

Describe the bug
Unable to setup NFS backup-target on dashboard. (error message as the snapshot)
Able to mount the backup-target in console.

To Reproduce
Steps to reproduce the behavior:

Install Harvester with any node
Login to dashboard and setup backup-target with NFS type

Expected behavior
setup successfully.
Environment:

Harvester ISO version: master-e214d829-head
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): qemu/KVM 3 nodes

Additional context
Function works on other versions:

[x] v1.0.0
[x] master-bfd6a8a9-head

Support bundle
N/A

The container for running the webhook is missing the package nfs-client, thus the command failed.

@johnliu55tw Does this mean we can remove the nfs-client package in the backend container image?
It's a bit weird before switching to BCI base image, we seems not install NFS stuff in the webhook container image: https://github.com/harvester/harvester/commit/9c2461f610f3f984f2f1887ffe94db71303a9ee3#diff-49ccf96bb66e42627b495efc688852146c1f0aca84f508c6dc67d97e55c91198

@bk201 The mount command in the old image can mount NFS. I think busybox supports mounting NFS.
# busybox mount -t nfs -o nfsvers=4.2 -o actimeo=1 <IP_ADDRESS>:/home/johnliu/Downloads/share /mnt
# mount | grep <IP_ADDRESS>
<IP_ADDRESS>:/home/johnliu/Downloads/share on /mnt type nfs4 (rw,relatime,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,acregmin=1,acregmax=1,acdirmin=1,acdirmax=1,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=<IP_ADDRESS>,local_lock=none,addr=<IP_ADDRESS>)

As for whether backend container needs the nfs-client, I need to do some further checks.

Verified this bug has been fixed.
Test Information

Environment: qemu/KVM single node
Harvester Version: master-dba85940-head
ui-source Option: Auto

Verify Steps:
same as https://github.com/harvester/harvester/issues/1952#issue-1156652264


Failed to reload settings windows terminal

I have such a problem. Namely, when he wants to make such modifications https://www.bleepingcomputer.com/news/microsoft/windows-terminal-now-has-a-hidden-graphical-settings-editor/ in the windows terminal, he receives this error . And now my question. Where does such an error come from if I do everything in accordance with what is given in the guide? How to fix it?

@Piot1998 you are missing a closing curly brace on line 42, column 1. If you could pastebin your settings I wouldn't mind fixing it for you.

// This file was initially generated by Windows Terminal 1.0.1401.0  // It should still be usable in newer versions, but newer versions might have additional  // settings, help text, or changes that you will not see unless you clear this file  // and let us generate a new one for you.   // To view the default settings, hold "alt" while clicking on the "Settings" button.  // For documentation on these settings, see:  aka.ms aka.ms  {      "$schema": " aka.ms aka.ms ",       "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a       // You can add more global application settings here.      // To learn more about global settings, visit  aka.ms aka.ms       // If enabled, selections are automatically copied to your clipboard.      "copyOnSelect": false,       // If enabled, formatted data is also copied to your clipboard      "copyFormatting": false,       // A profile specifies a command to execute paired with information about how it should look and feel.      // Each one of them will appear in the 'New Tab' dropdown,      //   and can be invoked from the commandline with wt.exe -p xxx      // To learn more about profiles, visit  aka.ms aka.ms      "profiles":      {          "defaults":          {              // Put settings here that you want to apply to all profiles.          },          "list":          [              {                  // Make changes here to the powershell.exe profile.                  "guid": "{61c54bbd-c2c6-5271-96e7-009a                  "name": "Windows PowerShell",                  "commandline": "powershell.exe",                  "hidden": false              },              {                  // Make changes here to the cmd.exe profile.                  "guid": "{0caa0dad-35be-5f56-a8ff-afce                  "name": "Command Prompt",                  "commandline": "cmd.exe",                  "hidden": false              },              {                  "guid": "{b453ae62-4e3d-5e58-b989-0a99                  "hidden": false,                  "name": "Azure Cloud Shell",                  "source": "Windows.Terminal.Azure"              }          ]      },       // Add custom color schemes to this array.      // To learn more about color schemes, visit  aka.ms aka.ms      "schemes": [],       // Add custom keybindings to this array.      // To unbind a key combination from your defaults.json, set the command to "unbound".      // To learn more about keybindings, visit  aka.ms aka.ms      "keybindings":      [          // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json.          // These two lines additionally bind them to Ctrl+C and Ctrl+V.          // To learn more about selection, visit  aka.ms aka.ms          { "command": {"action": "copy", "singleLine": false }, "keys": "ctrl+c" },          { "command": "paste", "keys": "ctrl+v" },           // Press Ctrl+Shift+F to open the search box          { "command": "find", "keys": "ctrl+shift+f" },           // Press Alt+Shift+D to open a new pane.          // - "split": "auto" makes this pane open in the direction that provides the most surface area.          // - "splitMode": "duplicate" makes the new pane use the focused pane's profile.          // To learn more about panes, visit  aka.ms aka.ms          { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" },  { "command": { "action": "openSettings", "target": "settingsUI" }, "keys": "ctrl+shift+s" }      ]  }
    Dnia 28 lutego 2021 23:14 Omega172<EMAIL_ADDRESS>napisał(a):

github.com @Piot1998  you are missing a closing curly brace on line 42, column 3. If you could pastebin your settings I wouldn't mind fixing it for you.
—  You are receiving this because you were mentioned.  Reply to this email directly,  github.com view it on GitHub , or  github.com unsubscribe .

Hold on.  If you could pastebin your settings I wouldn't mind fixing it for you.
—  You are receiving this because you were mentioned.  Reply to this email directly,  github.com view it on GitHub , or  github.com unsubscribe .

@Piot1998 could you post your settings in github itself? Your email client seems to be mangling the contents pretty aggressively 😮

OK
    Dnia 1 marca 2021 13:19 Mike Griese<EMAIL_ADDRESS>napisał(a):

github.com @Piot1998  could you post your settings in github itself? Your email client seems to be mangling the contents pretty aggressively  😮
—  You are receiving this because you were mentioned.  Reply to this email directly,  github.com view it on GitHub , or  github.com unsubscribe .

Just to be clear about the situation. I am using the official windows terminal version, not the preview version.

I'm sending my settings.json file
``js
// This file was initially generated by Windows Terminal 1.0.1401.0
// It should still be usable in newer versions, but newer versions might have additional
// settings, help text, or changes that you will not see unless you clear this file
// and let us generate a new one for you.
// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation
{
"$schema": "https://aka.ms/terminal-profiles-schema",
// "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",

// You can add more global application settings here.
// To learn more about global settings, visit https://aka.ms/terminal-global-settings

// If enabled, selections are automatically copied to your clipboard.
"copyOnSelect": false,

// If enabled, formatted data is also copied to your clipboard
"copyFormatting": false,

// A profile specifies a command to execute paired with information about how it should look and feel.
// Each one of them will appear in the 'New Tab' dropdown,
//   and can be invoked from the commandline with `wt.exe -p xxx`
// To learn more about profiles, visit https://aka.ms/terminal-profile-settings
"defaultProfile": "{00000000-0000-0000-ba88-000000000002}",
"profiles": {
    "defaults": {
        // Put settings here that you want to apply to all profiles.
    },
    "list": [{
            "guid": "{00000000-0000-0000-ba88-000000000002}",
            "commandline": "C:\\Program Files\\Git\\bin\\bash.exe",
            "name": "Git Bash",
            "background": "#012456",
            "hidden": false
        },
        {
            // Make changes here to the powershell.exe profile.
            "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
            "name": "Windows PowerShell",
            "commandline": "powershell.exe",
            "hidden": false
        },
        {
            // Make changes here to the cmd.exe profile.
            "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "name": "Command Prompt",
            "commandline": "cmd.exe",
            "hidden": false
        },
        {
            "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
            "hidden": false,
            "name": "Ubuntu",
            "source": "Windows.Terminal.Wsl"
        },
        {
            "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
            "hidden": false,
            "name": "Azure Cloud Shell",
            "source": "Windows.Terminal.Azure"
        }
    ]
},

// Add custom color schemes to this array.
// To learn more about color schemes, visit https://aka.ms/terminal-color-schemes
"schemes": [],

// Add custom keybindings to this array.
// To unbind a key combination from your defaults.json, set the command to "unbound".
// To learn more about keybindings, visit https://aka.ms/terminal-keybindings
"keybindings": [

    // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json.
    // These two lines additionally bind them to Ctrl+C and Ctrl+V.
    // To learn more about selection, visit https://aka.ms/terminal-selection
    {
        "command": {
            "action": "copy",
            "singleLine": false
        },
        "keys": "ctrl+c"
    },
    {
        "command": "paste",
        "keys": "ctrl+v"
    },

    // Press Ctrl+Shift+F to open the search box
    {
        "command": "find",
        "keys": "ctrl+shift+f"
    },

    // Press Alt+Shift+D to open a new pane.
    // - "split": "auto" makes this pane open in the direction that provides the most surface area.
    // - "splitMode": "duplicate" makes the new pane use the focused pane's profile.
    // To learn more about panes, visit https://aka.ms/terminal-panes
    {
        "command": {
            "action": "splitPane",
            "split": "auto",
            "splitMode": "duplicate"
        },
        "keys": "alt+shift+d"
    },
    {
        "command": {
            "action": "openSettings",
            "target": "settingsUI"
        },
        "keys": "ctrl+shift+s"
    }
]

}
``

Weird. I pasted that into my own settings file and I can't repro this. What editor are you using to modify the file? I'm worried that there's a stray character that's messing up your file for some reason.

I am using Visual Studio Code

Well, that's probably fine then. This is gonna sound ridiculous, but what if you copied the entire text of the file from here on github, pasted it into a new file, then moved that file to be settings.json. Does that fix the issue?

I mean, what exactly should I do? Can you clarify?

Should I copy the entire contents of the settings.json file to a new file and then move it to settings.json? Please tell me what to do exactly because I would like to know more

Instead of copying the settings.json from the repo just delete the contents of your settings.json and it should recreate it. And see if that works.

Ok. And where to save this new settings.json file. The new one. In the directory related to windows terminal or rather it may be on the desktop. Sorry for this question, but I want to be 100% sure

You can just go ahead and save that file right where the old settings.json lives. The idea here is that we're totally rewriting the settings file, to hopefully blow away whatever bad byte is hiding in it.

Ok. Just one more question. Should I delete the old settings.json file or overwrite it with the new one?

@Piot1998 To be safe, let's just delete the file entirely first.

Finished. What's next?

Try booting the Terminal?

But what exactly should I do? Create this settings.json file again, save it on the desktop or rather in the old location of this file where the old settings.json file was?

If you just reboot the terminal without creating a new settings.json file, then the Terminal will create you a fresh settings.json that should work. If that works, then open up that file, delete all the contents, paste in the contents from your old file here on github, and save the file.

Because I completely deleted this settings.json file from its default location

Yep, that should be fine. The Terminal will work without a settings file - it will create one for you when it's first launched.

This is the contents of the old settings.json file

// This file was initially generated by Windows Terminal 1.0.1401.0
// It should still be usable in newer versions, but newer versions might have additional
// settings, help text, or changes that you will not see unless you clear this file
// and let us generate a new one for you.

// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation
{
    "$schema": "https://aka.ms/terminal-profiles-schema",

    // "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",

    // You can add more global application settings here.
    // To learn more about global settings, visit https://aka.ms/terminal-global-settings

    // If enabled, selections are automatically copied to your clipboard.
    "copyOnSelect": false,

    // If enabled, formatted data is also copied to your clipboard
    "copyFormatting": false,

    // A profile specifies a command to execute paired with information about how it should look and feel.
    // Each one of them will appear in the 'New Tab' dropdown,
    //   and can be invoked from the commandline with `wt.exe -p xxx`
    // To learn more about profiles, visit https://aka.ms/terminal-profile-settings
    "defaultProfile": "{00000000-0000-0000-ba88-000000000002}",
    "profiles": {
        "defaults": {
            // Put settings here that you want to apply to all profiles.
        },
        "list": [{
                "guid": "{00000000-0000-0000-ba88-000000000002}",
                "commandline": "C:\\Program Files\\Git\\bin\\bash.exe",
                "name": "Git Bash",
                "background": "#012456",
                "hidden": false
            },
            {
                // Make changes here to the powershell.exe profile.
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "hidden": false
            },
            {
                // Make changes here to the cmd.exe profile.
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "Command Prompt",
                "commandline": "cmd.exe",
                "hidden": false
            },
            {
                "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
                "hidden": false,
                "name": "Ubuntu",
                "source": "Windows.Terminal.Wsl"
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            }
        ]
    },

    // Add custom color schemes to this array.
    // To learn more about color schemes, visit https://aka.ms/terminal-color-schemes
    "schemes": [],

    // Add custom keybindings to this array.
    // To unbind a key combination from your defaults.json, set the command to "unbound".
    // To learn more about keybindings, visit https://aka.ms/terminal-keybindings
    "keybindings": [

        // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json.
        // These two lines additionally bind them to Ctrl+C and Ctrl+V.
        // To learn more about selection, visit https://aka.ms/terminal-selection
        {
            "command": {
                "action": "copy",
                "singleLine": false
            },
            "keys": "ctrl+c"
        },
        {
            "command": "paste",
            "keys": "ctrl+v"
        },

        // Press Ctrl+Shift+F to open the search box
        {
            "command": "find",
            "keys": "ctrl+shift+f"
        },

        // Press Alt+Shift+D to open a new pane.
        // - "split": "auto" makes this pane open in the direction that provides the most surface area.
        // - "splitMode": "duplicate" makes the new pane use the focused pane's profile.
        // To learn more about panes, visit https://aka.ms/terminal-panes
        {
            "command": {
                "action": "splitPane",
                "split": "auto",
                "splitMode": "duplicate"
            },
            "keys": "alt+shift+d"
        }
    ]
}

Like you said, the terminal created a new settings.json file the first time you started the terminal. That file was created by the windows terminal by default on first run, and I didn't touch anything there

Okay, so you've

Deleted settings.json
Re-launched the terminal

Does the Terminal work now? If not, is it displaying an error (and what exactly is the error message)?
I believe it should be working with the default settings. If it is, then I'd go ahead and add parts of your old settings.json file into the newly generated one bit at a time, and keep re-launching the Terminal to make sure it keeps working.

Ok. I'll check it. So now I can easily implement this command from this site https://www.bleepingcomputer.com/news/microsoft/windows-terminal-now-has-a-hidden-graphical-settings-editor/. Because I want to add that this windows terminal is not a preview version, but a normal one.

Nope. The Settings UI is still only in the preview builds. From the release notes:

version 1.6, which includes all of the features from this previous blog post except for the settings UI.

If the settings file is working for you again, I'm gonna go ahead and close this issue out. Thanks!

Thanks


Provide a way to access the component version from the source code

It would be good if there was a way to determine the component version at compile-time as that way it would be easier to make the code compatible with multiple component versions (if there were any incompatible changes).

A potential solution would be to extend RTE_components.h to also contain the version information.

/* ARM::CMSIS:RTOS2:Keil<EMAIL_ADDRESS>*/
        #define RTE_CMSIS_RTOS2             /* CMSIS-RTOS2 */
        #define RTE_CMSIS_RTOS2_RTX5            /* CMSIS-RTOS2 Keil RTX5 */
        #define RTE_CMSIS_RTOS2_RTX5_SOURCE     /* CMSIS-RTOS2 Keil RTX5 Source */

adding e.g.:
#define ARM__CMSIS_RTOS2_Keil_RTX5_Source_MAJOR 5
#define ARM__CMSIS_RTOS2_Keil_RTX5_Source_MINOR 5
#define ARM__CMSIS_RTOS2_Keil_RTX5_Source_PATCH 4
#define ARM__CMSIS_RTOS2_Keil_RTX5_Source_VERSION 0x05050400

#define ARM__CMSIS_RTOS2_Keil_RTX5_Source_VERSION 0x05050400
sounds good, maybe that patch uses last 4 digits and if possible that macro is all capital letters.
For reference, this is how version is encoded for :
Arm Compiler 5 :
__ARMCC_VERSION     PVVbbbb
P = major
VV = minor
bbbb = build
Arm Compiler 6 :
__ARMCOMPILER_VERSION     Mmmuuxx
M = major
mm = minor
uu = update
xx = for Arm internal use

@MiloradCvjetkovic We cannot use compiler version schema here.
Some components use year as the major version, e.g. 2023

I believe that this needs more discussion as we have API version and implementation version.
In CMSIS-Driver we have already version information at runtime.
@MiloradCvjetkovic what was the actual problem that triggered this. Could you describe the scenario?
Could this be better handled at the level of the API header file itself? Hence no change to RTE_components.h?

I suggest to close that issue.  If there is no further votes to keep it, we close it Oct 24.


Not supported enumeration (type union)

I have function like this:
myfile.js
  /**
   * Some description
   * @param {('SUCCESS'|'ERROR')} result
   */
  export function methodName(result) {
    // some code
  }

When I run doxdox 'myfile.js' --output output.md it is crashed with error:
TypeLexerSyntaxError: Expected "!", "(", "*", "...", "=", "?", "function", "module", "{", [ \t\r\n ] or [a-zA-Z_$] but "'" found.:
('SUCCESS'|'ERROR')

type union in JSDoc supported from 2004

With the latest release of doxdox (v4.0.0-preview.1) the default parser is JSDoc so type unions are now supported.


Turbo-carto support

Still needs handling of properties that are left unset because of the pass to async.

I left some comments, lacks of tests and so on but good for now


size of package too big

I got a 636.7Mb package file after run npm run package according README document.It's possible to make it more small size?

For the package, ~2.3Mb is the expected result of node_modules.
It looks you have unexpected folder .npminstall, the node_modules of package is copy from root node_modules, and prune unnecessary dependencies. Could you check .npminstall is exists in root node_modules?

yes! .npminstall is exists in electron-react-boilerplate/node_modules/.How can i ignore it when run npm run package?

Use yarn

@amilajack aewsome, it solved!tks a lot.

🎉


HA: Seaweed UI shows blank topology on slaves

Describe the bug
When using a HA cluster, the UI on the slaves show an empty topology. I found this behaviour confusing and think it would be better if all UIs showed the same topology regardless of roles.  -max=5 -mserver="<IP_ADDRESS>:9334" -port=8080

Expected behaviour
I would like to see the topology (if possible) shown on all master UI
Screenshots

Whoa, I didn't know there was a WebUI, how do you get to it?

@zicklag

For the servers just head to their port: http://hostname:9333
For storage volumes you need to add to /ui/index.html: http://hostname:8080/ui/index.html

Will a redirect work?

I don't mind if they auto redirect to the leader's web pages. The thing to note though is that I access the page outside of the internal network via a reverse proxy, so it would need to proxy the request and not redirect the connecting client as I don't have access to the private range on the overlay network.


Package Dependencies Resolution

There is no package dependency resolution in c5. Installing or uninstalled packages that require other packages or are required by other packages can be dangerous and easily destructive.
An example of package dependency might be a package that installs an Attribute Type where you can select a product. As you might guess, this package would require the "core_commerce" package (or any one of the ecommerce packages on the marketplace) in order to function.
I'd like to open up a discussion about how package dependencies should be resolved.
I propose something along the lines of having a protected array ($packageDependencies) of required package handles in the packages' controller.php files, and a function (requiredDepenenciesInstalled) in the Package class that is called when installing a package that checks to see if all of the handles in $packageDependencies are installed. If not, it gracefully aborts the install with an appropriate error message.
Similarly for uninstalling, a function in the Package class (isDependedOn) gets the list of all installed packages and checks each package for the $packageDependencies  array, then check each $packageDependencies array to see if the current package handle is in them. If it is, abort the uninstall by throwing an exception, otherwise continue as normal.
Should these function be the ones to throw exceptions, or should they instead simply return a Boolean and the exception be handled separately?

Closing this, as it hasn't had any comments in over two years.

This has been fixed by #5995

Whilst I was briefly involved in the discussion >18 months ago, this is the first time I have realised that package dependencies had actually been implemented. Is it documented anywhere?

Yesterday I wrote a doc page: https://documentation.concrete5.org/developers/packages/installation/package-dependencies


fix(lvol): referring lvol name after destroy

Fixed use of Lvol name after it has been freed.
This partially fixes CAS-1258.
Fixes CAS-1258.
This commit fixes crash of mayastor pod when a device on that node is detached. It does not fix crash of mayastor  pod hosting a nexus.

bors try

Closing this PR because release branch is closed. I will recreate it for develop.

@dsavitskiy @GlennBullingham do we need this for the hotfix branch?


Remove Coordinator DBs

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/74/

The tests show several failures, which are probably related to the changes in this PR.


Streamline terminology for BNS encoding

In BNS we have those three encodings for transactions and objects:

External facing types (e.g.  Amount, RegisterUsernameTx)
Protobuf types (e.g.  codecImpl.coin.ICoin, codecImpl.username.IIssueTokenMsg)
binary representation

We need proper verbs for the transitions:

1 -> 2
2 -> 3 (called "encode" by protobuf)
3 -> 2 (called "decode" by the protobuf)
2 -> 1

The term "parse" should probably disappear in this context, as it is used as a synonym for "decode" but does not match properly.
I wonder if there are better terms for 1->2/2->1 than "encode"/"decode".

How about "translateToProtobuf"/"translateFromProtobuf"?

In #1082 I rename the remaining functions for step 1. to encode* for consistency.
Going for

1 -> 2 "encode"
2 -> 3 "encode to binary" (not used much in our code)
3 -> 2 "decode from binary" (not used much in our code)
2 -> 1 "decode"

seems to be the most natural thing right now given how the codebase is written.


Allow install_path to be passed via env var

Sometimes, it would be nice to override the default install path with an environment variable. This diff accomplishes that.

@Detry322 Thanks! helpful! Will merge and push a new version!

Deployed in 1.2.0.


USHIFT-1824: add ssh wrapper functions to scenario.sh

This allows scenario setup steps to do more with the VM before starting the
test.

/lgtm

/lgtm

/override ci/prow/metal-periodic-test-arm
This job was marked as required by mistake. The current change is not related to the job failure.


Regionwide report (all games of a region) download

Two fixes

show export button in all games list (game.index)
create a regionwide report, add download option in region dashboard (same as for clubs)


7.55.x: Backport #26540

What does this PR do?
Backport of #26540

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Radio buttons?

Issue originally submitted here: https://code.google.com/p/guidata/issues/detail?id=32
Reported by<EMAIL_ADDRESS>May 22, 2013
Are there any plans to implement a radio button group?  Yes, it's similar to a ChoiceItem, and I can get by with that for now.  Still, the nice thing about a group of radio buttons is that all of the options are always viewable to the user and can be chosen with one click instead of two.

Duplicate of Issue #4


Kind inquiry about G-Objaverse-280k

Thanks for the high-quality dataset!
I wonder whether the dataset G-Objaverse-280k contains the category of "Poor-quality", and what is the criterion for “poor quality”, the quality of the mesh or the quality of the rendering?

Honestly,  the poor quality of mesh is hard to defined. We do not manually filter "low quality" mesh, but employ a simple strategy that filters boxes, ball, and some very simple obj.

Honestly, the poor quality of mesh is hard to defined. We do not manually filter "low quality" mesh, but employ a simple strategy that filters boxes, ball, and some very simple obj.

Got it! Thanks for your reply！


refactor: refine-core index file export sorted

refine-core index file exports sorted

Thank you for the PR! 🚀 🚀  It's like the one thing I always wanted but never had a chance to do 😄 Checks are failing due to an error in @pankod/refine-antd I'll create an issue for that and link that as it's blocking this PR from merging.

Hey @khnbzkrt ,
Thank you!


CXXCBC-242: core API for KV range scan

jenkins, test this please

Third patch will include manager class, which will encapsulate logic of tracking all vbucket-stream pairs with optional sorting.

Third PR will include manager class, which will encapsulate logic of tracking all vbucket-stream pairs with optional sorting.

I was curious about this.  Good to know it will be coming.