[Feature] Package names in summary audit report

Hi, I think it would be useful to include a summary of affected packages in the audit report much like how yarn audit displays it. My issue is the audit summary displays too little information, but the full report displays too much. Thank you for considering, and more than happy to put in a PR if needed.

yep agree

I am interested in displaying a more user-friendly version of the audits for both NPM and Yarn. Right now the full report displays the raw JSON object received from {npm|yarn} audit --json, the summary displays the metadata field for NPM and Yarn displays anything with the auditSummary field.
There are a few different approaches we could take:

Just remove "unnecessary" fields in the existing JSON objects and continue to show the JSON objects.
Find a way to pretty-print the JSON objects received into their native package-manager print-style (perhaps https://github.com/npm/npm-audit-report#readme for NPM, not sure for Yarn). Unfortunately, since we use the --json flag at audit-time, we are missing out of the regular stdout from NPM and Yarn that you get running {npm|yarn} audit
Introduce a new way to pretty-print that both NPM and Yarn use, likely based on npm-audit-report for ease of implementation.

Thoughts?

CC: @dubbha from #58.

First of all, the summary output didn't even exist a week ago, before https://github.com/IBM/audit-ci/issues/58 and https://github.com/IBM/audit-ci/pull/59
The use case I was covering is described in https://github.com/IBM/audit-ci/issues/58 and the current output covers exactly what I consider to be a summary:
{
    "vulnerabilities": {
      "info": 0,
      "low": 9,
      "moderate": 213,
      "high": 4,
      "critical": 0
    },
    "dependencies": 70026,
    "devDependencies": 0,
    "optionalDependencies": 0,
    "totalDependencies": 70026
  }

It outputs this and yet doesn't fail because of the --critical. The idea behind this is: I don't what the whole CI to fail unless there are critical vulnerabilities, but I want a summary output containing a count for the lower-level vulnerabilities, so that I know when these appear and can fix them when I have time.
The output above is from a real project, and it is exactly sufficient for my use case. Now I don't really get the idea, what would you like it to look like instead? Since I only really care for criticals (remember the --critical) I don't need the output to be too polluted (hence the PR in the first place). And my guess is that with       "low": 9, "moderate": 213, "high": 4, any kind of "summary of affected packages" would pollute the log extensively.

Thanks for the input @dubbha.
I do not think a summary of affected packages would pollute the logs. Aside from the initial audit on a new project (and fix), there will not be 100s of advisories popping up everyday. There should only be a few at most, npm audit or yarn audit does a great job of showing just the essentials without being overly verbose.
I think there are merits to having a concise summary like what you have mentioned, and a pretty print version with just the essentials eg.:
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ hoek                                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ > 4.2.0 < 5.0.0 || >= 5.0.3                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ less                                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ less > request > hawk > sntp > hoek                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/566                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

@quinnturner : Approach 3 sounds good, maybe with a --package-summary flag or something

Thanks for the input @dubbha.

You're welcome.

I do not think a summary of affected packages would pollute the logs.

In fact it will pollute the logs.

Aside from the initial audit on a new project (and fix), there will not be 100s of advisories popping up everyday.

You should not be assuming an initial fix of the issues below my threshold. If I am running audit-ci --critical I only really care for criticals. And you should not be assuming I will even bother to fix the other, lower-level issues, ever. All I need to know is if there are any, that's it. At least that's the idea behind a --summary flag.
What you're talking about is basically returning from a summary to the full output. Even if it's changed from JSON to stdout/pretty-print it's still going back to the full output. This case it makes sense to discuss chaning the --report output, but not the --summary output.
My use case above is 100% legit, and the output comes from a real project where there are no plans to address the minor issues in the nearest future. And with your approach the logs will (again) be polluted to the extent the CI output will become unusable (see below). It will output a "pretty-print" for each an every instance of the mentioned vulnerabilities ("low": 9, "moderate": 213, "high": 4) which I don't really care for in the first place. If I do care for them later, I will run the audit locally and fix them.
Here's how the output would look like:
LINES 1 to 31:
yarn audit
yarn audit v1.13.0
warning package.json: License should be a valid SPDX license expression
warning<EMAIL_ADDRESS>License should be a valid SPDX license expression
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ braces                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=2.3.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ ts-jest                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ ts-jest > cpx > chokidar > anymatch > micromatch > braces    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/786                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.17.11                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ ts-jest                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ ts-jest > babel-plugin-istanbul > istanbul-lib-instrument >  │
│               │ babel-generator > babel-types > lodash                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/782                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

... SO MANY LINES ...
LINES 3196 - 3225
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high          │ Denial of Service                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ https-proxy-agent                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=2.2.0                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ typings                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ typings > typings-core > popsicle-proxy-agent >              │
│               │ https-proxy-agent                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/593                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.17.11                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @linsi/entities                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @linsi/entities > lodash                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/782                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
226 vulnerabilities found - Packages audited: 70027
Severity: 9 Low | 213 Moderate | 4 High
Done in 2.63s.

In my particular use case having 3225 lines of the info I don't really care for at the point is a pollution.
Also it would weigh 527K in size alone, and together with the other logs sooner or later would hit the CI logs sizing limitation like the one mentioned in the original https://github.com/IBM/audit-ci/issues/58
Job's log exceeded limit of 4194304 bytes.

So your pretty-print idea contradicts the use case --summary was introduced for. Either consider dicussing changing the --report output, or maybe introduce your own flag.

@dubbha @iflp Great discussions all around, thanks! What do you think of introducing another report variant which shows both the summary and the vulnerabilties that are breaking the build? Currently, --report shows all vulnerabilities including low when you use the --critical flag. --summary just shows the auditSummary.
The new flag (unknown name) would show the summary and would show the output only for the vulnerabilities that break the CI build (critical in this case) as well as the summary. Alternatively, we could repurpose --summary to do this, as this may be the desired behaviour.

Hi everyone!
I have created #74. Please consider reviewing!

Note that I revised the potential approach in a new comment: https://github.com/IBM/audit-ci/pull/74#issuecomment-479696523
Exerpt:

One alternative that I am interested in as well would be adding the flag --report-type {summary, important, full}. This set up could support different report types in the future. I suggest we would default to important, which is the behaviour in the current PR. We would continue by deprecating the existing --summary and --report flags but continue to support them for "a while", piping them to the associated --report-type (summary --> summary and report --> full) and console.warn the deprecation and potential future removal.

This approach would be a major bump to the version and would include documentation in the README for upgrading an upgrading strategy.

Open to discussion and preferences!

I have released v2.0.0 which addresses this issue by adding the --report-type option; which defaults to a new setting important. important shows the audit summary as well as relevant vulnerabilities instead of the full audit report or no relevant vulnerabilities. For now, I will close this. I see the value of adding a different way of formatting the output, but the original issue of adding package names in the summary audit report has been addressed. Feel free to open another issue for formatting the output if you feel that it would provide significant value.


[favicon] wordmark favicon

Trello: https://trello.com/c/sTH67mNe/8-i-want-a-metashare-wordmark
Included are the generated files. The site manifest would need to be updates with the relative URLs if we are using that file. I looked at how metadeploy was set up and it is using some registered globals that don't yet exist (I think) in MetaShare yet. I've only added the files as of now, but we will need to link to them.

We didn't worry about a manifest.json file on MD -- I'd be inclined to make the same call here (at least for now)?

We didn't worry about a manifest.json file on MD -- I'd be inclined to make the same call here (at least for now)?
I believe it is mostly for Android and Windows Phone users so likely not much of an issue here unless someone is using an android tablet and want to save this as a shortcut. Probably a super small if any market.

 I want a MetaShare wordmark


Why use no_grad for computing d_theta

hello, i found this code ignore grad for g_cos_theta and angular margin.
https://github.com/ydwen/opensphere/blob/main/model/head/sphereface2.py#L62-L80
Will this not cause network oscillation?

@tangzhongliang I think it is the Characteristic Gradient Detachment to stable training proposed in paper "SphereFace Revived:
Unifying Hyperspherical Face Recognition"


Update azure-toolkit-for-eclipse-whats-new.md

incomplete source sentence:
(Instance endpoints are also listed in

Hi @NataliaL, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-nalubs). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@rmcmurray can you address the missing content pointed out by @NataliaL. Thanks.

request to be submitted in privet pr ,  closing this PR


Update version of Traffic Control to 3.0.0.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2242/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2246/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2247/
Test PASSed.


Some iPhone 8, 8Plus, X Models don't recognize.

Hi, I'm iOS developer from Korea.
I cannot speak English well.
I found some problems for DeviceKit.
My iPhoneX didn't recognize for DeviceKit.
So, I found DeviceKit's code, some code has problems.
iPhone 8, 8Plus, X Models has 2 identifiers each.
But DeviceKit has just 1 identifier each.
I want to modify this code, but I don't know how to add this code.
I write this codes here, so who someone add this code please.
Methods name is  mapToDevice(identifier:)
case "iPhone10,4", "iPhone10,1": return iPhone8
case "iPhone10,5", "iPhone10,2": return iPhone8Plus
case "iPhone10,3", "iPhone10,6": return iPhoneX
Thank you for read.
Have a nice day.

I found my fault. I was using 1.3.2 version. Sorry.


Opera Mini: includes

Hi!
Similar to https://github.com/Financial-Times/polyfill-service/issues/897 I noticed that the default set passed through for Opera Mini appears to be lacking support for includes (this is forString, but I am not sure of the support for Array). Here's a few screens from BugSnag:

I hoped that opera mini is not recognized and gets no polyfills, which can be fixed by setting unknown=polyfill, but it's not the case. See: https://cdn.polyfill.io/v2/polyfill.js?ua=Opera/9.80 (Android; Opera Mini/7.6.40234/37.8993; U; en) Presto/2.12.423 Version/12.16 . We consider three hot fixes:

enabling missing polyfills for all browsers features=default,Array.from|always
doing UA sniffing on our servers and going features=default|always when opera mini is recongized
using callback param to check if all polyfills are in place, and if not, force load them

Adding additional browsers as targets for a particular polyfill is easy.  Here's the process:
https://polyfill.io/v2/docs/contributing/common-scenarios#adding-browsers

Thanks Andrew! I'll look into this tomorrow. Note to self: performance.now is also not served for Opera Mini as it should be.


show install progress during flutter run

fixes https://github.com/flutter/flutter/issues/6504
@devoncarew

LGTM.
I so wish we could get adb to give us real data here so we could do an actual progress bar.

I think the progress spinner would move if we refactored the various run functions to use Process.run rather than Process.runSync. I'll give that a whirl in a separate PR.


MySQL driver querying information_schema with a table_schema value of the user instead of the database

The first queries that data-diff performs is getting the columns from the specified table; however, the query is using the user as the TABLE_SCHEMA instead of the database.
data-diff --debug mysql://root:root_password@mysql5:3306/coolname Transaction mysql://user:user_password/@mysql:3306/coolname Transaction
[11:33:45] DEBUG - Running SQL (MySQL): SELECT column_name, data_type, datetime_precision, numeric_precision, numeric_scale FROM information_schema.columns WHERE table_name = 'Transaction' AND table_schema = 'root'
[11:33:45] DEBUG - Running SQL (MySQL): SELECT column_name, data_type, datetime_precision, numeric_precision, numeric_scale FROM information_schema.columns WHERE table_name = 'Transaction' AND table_schema = 'user'

In MySQL's information schema the TABLE_SCHEMA is the database, not the user
https://dev.mysql.com/doc/mysql-infoschema-excerpt/8.0/en/information-schema-columns-table.html
MySQL [(none)]> select TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE, engine from information_schema.tables where table_name = 'Transaction'\G
*************************** 1. row ***************************
TABLE_SCHEMA: coolname
  TABLE_NAME: Transaction
  TABLE_TYPE: BASE TABLE
      ENGINE: InnoDB
1 row in set (0.003 sec)

This is causing data-diff to fail to find the table and columns so data-diff cannot function
RuntimeError: MySQL: Table 'Transaction' does not exist, or has no columns

Versions:
root@22b19e3a116f:/# python3 --version
Python 3.7.3
root@22b19e3a116f:/# pip3 list
Package                Version
---------------------- ---------
asn1crypto             0.24.0
awscli                 1.16.113
botocore               1.12.103
certifi                2018.8.24
chardet                3.0.4
click                  8.1.3
colorama               0.4.5
commonmark             0.9.1
cryptography           2.6.1
data-diff              0.2.0
docutils               0.14
dsnparse               0.1.15
entrypoints            0.3
idna                   2.6
importlib-metadata     4.11.4
jmespath               0.9.4
keyring                17.1.1
keyrings.alt           3.1.1
mysql-connector-python 8.0.29
pip                    18.1
protobuf               4.21.1
pyasn1                 0.4.2
pycrypto               2.6.1
Pygments               2.12.0
PyGObject              3.30.4
python-dateutil        2.7.3
pyxdg                  0.25
PyYAML                 3.13
requests               2.21.0
rich                   10.16.2
roman                  2.0.0
rsa                    4.0
runtype                0.2.6
s3transfer             0.2.0
SecretStorage          2.3.1
setuptools             40.8.0
six                    1.12.0
typing-extensions      4.2.0
urllib3                1.24.1
wheel                  0.32.3
zipp                   3.8.0

Yes, you're right. The code has a "typo" -
        self.default_schema = user

We just fixed it and already merged to master. We'll soon push it to pypi too.

Released in 0.2.1. Give it a try!

It works great! Thanks so much for your quick response and turn around.

@DominicChiampi is your use-case MySQL <-> MySQL? Would love to learn what you're doing with data-diff 😍

@sirupsen I have some (Amazon Aurora) managed MySQL 5.6 databases. Aurora's 5.6 engine is reaching end-of-life early next year. As a result I am exploring different upgrade strategies, for example, upgrading the existing cluster in-place 5.6 -> 5.7 or 5.6 -> 5.7 -> 8.0 or staging a new database server cluster at 8.0 and doing a mysqldump -> import from the 5.6 cluster to the 8.0 cluster.
I don't expect that any of these processes would introduce data integrity issues, but data-diff allows me to quickly collect evidence to support my assumptions.
I expect my final product will be several scripts that each implement one of these strategies with some data-diff usage at the end as part of an automated verification. Then on "go-live" night I will run them in parallel and swap to the cluster that finishes first and does not show any differences from the source database.
MySQL 5.7+ also introduces a JSON data type for columns that my developers are interested in using. There are a couple of columns that are JSON serialized into a varchar typed column. I am unsure if data-diff will work for verifying the column type conversion, but I plan on trying when we get there.


Cannot create a new conversation

I was trying to test the demo out, after having done the initial steps and setting up the serverless functions. I can log in and build the app successfully. However, I cannot create a new conversation.
Error: Cannot read properties of undefined (reading 'then')
  "react": "17.0.2",
  "@twilio/conversations": "2.4.1",

It's this function
  async createConversation(options) {
        await this._ensureReady;
        options = options || {};
        return this._conversationsPromise.then((conversationsEntity) => conversationsEntity.addConversation(options));
    }

Note: I am using the serverless functions for the backend.
Node: v18
Use the steps here to set up the service.

I have gone through the other issues, not that helpful. Anyone who's been able to get throught this, I'd appreciate the support.

makzpatel, camr1993, esquive Any help here. I have the project cloned locally and running. If it'll help I can set up a repo and share that.

Check the variables in the functions. I had the same problem before and found out that I mispelled the variables.

Check both.

In the serverless function
let token = new AccessToken(
      context.ACCOUNT_SID,
      context.TWILIO_API_KEY_SID,
      context.TWILIO_API_KEY_SECRET, {
        identity: event.identity,
        ttl: 3600
      });

    let grant = new AccessToken.ChatGrant({ serviceSid: context.SERVICE_SID });

Variables (ENV)

Add my Twilio Credentials (ACCOUNT_SID) and (AUTH_TOKEN) to ENV -> This is also checked to be true.
So this is in the serverless config!
Do I have to add these variables in the demo project on the front end as well?

@berkus maybe we can change Error: Cannot read properties of undefined (reading 'then') to a different message so it doesn't confuse anyone.

@lesquive sure, we have almost non-existing error handling in the app, there are many places where we could improve error messages and handle them gentler.

I had the same problem and this is how I have solved it.
I was using wrong credentials for TWILIO_API_KEY_SID and TWILIO_API_KEY_SECRET variables.
You must create a new API Key and get the right variables from it.
Check it at https://console.twilio.com/us1/account/keys-credentials/api-keys and use [Create API key] button.

@GomezFabio Thanks.
I already did this. I am able to use auth but cannot create room/channel for testing the whole thing out.
And I was not able to find anything in the demo, example or the docs on how to trace my steps for the setup.
Currently putting twilio on hold, exploring other options.

I've just deployed to Vercel, followed the guide in the github readme of the demo, I also get this error when creating a new conversation:
Cannot read properties of undefined (reading 'then')

Any news on this? @AbdullahQureshi1080

No update, we moved to another sdk as their solution did not fulfill our
use case.
On Fri, 23 Feb 2024, 3:22 am Fabrizio Codello, @.***>
wrote:

I've just deployed to Vercel, followed the guide in the github readme of
the demo, I also get this error when creating a new conversation:
Cannot read properties of undefined (reading 'then')
Any news on this? @AbdullahQureshi1080
https://github.com/AbdullahQureshi1080
—
Reply to this email directly, view it on GitHub
https://github.com/twilio/twilio-conversations-demo-react/issues/144#issuecomment-1960423732,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANJLWWQ6PC477NY7XM6PZUDYU7AJPAVCNFSM6AAAAABAI2MC6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGQZDGNZTGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

My app is deployed on Vercel, I saw "offline" on the top bar under my username.

Did you set up the token generator?
I've setup the two TWILIO API KEYS

Could you please tell me what I'd need to do in particular?

Could you please tell me what I'd need to do in particular?

You need to deploy a function as descibed in the README that will generate and provide you with access tokens. When deploying to vercel it shall ask you about the token generator url - you need to provide that function's url there.

@GomezFabio gave a right answer. Thank you. My problem was in the existing API key which is actually not an API key at all.
https://console.twilio.com/us1/account/keys-credentials/api-keys
This page has two sections.

API keys
Auth Tokens

There was a live auth token which I already used before this demo application and this auth token didn't work.
Now I've created a new API key. I've updated my env variables in the cloud function and everything works now. The status is set to "online" after the initial sign in.
@Fabryz FYI

I guess we're all sorted here. Closing.


Fixed rendering issues related to environmentState.renderTranslucentDepthForPick

This PR has the changes in https://github.com/CesiumGS/cesium/pull/9844 plus some of my own changes. Opening as a separate PR because the original branch was not recoverable.
@ebogo1 this should be good, but could you do a final review and merge?

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Thanks @lilleyse - these changes look good to me. I noticed a couple things:

After rotating the camera, picked positions outside of the point cloud are undefined. After speaking offline, it's possible this is related to https://github.com/CesiumGS/cesium/issues/8179
The original PR mentioned issues with viewer.camera.switchToPerspectiveFrustum() and viewer.camera.switchToOrthographicFrustum() after these changes. I used the Sandcastle code from #9824 to double check this, and I was unable to reproduce any problems.


Change access of ErrorLogMiddleware class to public for testability

I would propose that some classes be public so so they are testable. I'm willing to make a PR for the change, but want to gauge how you feel about it.
For example, I'd like to check that my configured filter creates the filter class with the correct options:
var config = new ConfigurationBuilder()
    .AddJsonFile($"configs/{configName}.json", false, true)
    .Build();
var services = new new ServiceCollection().MyCustomExtension(config);
var provider = services.BuildServiceProvider();

var errorLogger = provider.GetService<ErrorLog>();
Assert.IsType<SqlErrorLog>(errorLogger);

/* Here's the problem
   ErrorLogMiddleware is an internal class, but it also contains any configured
   Notifiers and Filters
*/
ErrorLogMiddleware middleware = provider.GetService<ErrorLogMiddleware>(); // Does not work since

// I'd like to be able to do this
var filters = middleware.Filters.Where(x => x.typeof(MyCustomFilterType));
var notifiers = middleware.Notifiers.Where(x => x.typeof(MyCustomNotifierType));
Assert.Equal(1, filters.Count);
Assert.Equal(3600, filters.First().ExampleTimeOutInSeconds);

Assert.Equal(1, notifiers.Count);

There is also no way to add event handlers OnLogged for now


When inside Sidebar ampstart-nav-item, ampstart-input lost focus one second after clicking it

I was trying to put a search form in AMPStart sidebar, the text input lost focus a second after clicking it. Here's how to reproduce it:

Copied from the navigation component,
include the amp-form js,
then simply add the search form like:

          <form role="search" action="/articles.amp" accept-charset="UTF-8" method="get" novalidate="" target="_top" class="i-amphtml-form" _lpchecked="1">
            <input name="utf8" type="hidden" value="✓">

              <input type="text" name="q" id="ip1" class="block border-none p0 m0 user-valid valid" placeholder="Search">
              Search

            <button class="ampstart-btn">

            </button>
          </form>

It works if I put the exact snippet above into the navbar and there was no error in the browser console so I thought I'd file a bug here. For more visual, see the codepen on a smaller HTML preview.

is this on a particular browser? i tried on Max Os Latest chrome and it seems to be file

@apraditya - I am closing this for now , feel free to re-open with more platform specifics


Annotation pv.kubernetes.io/bind-completed not registered / documented

This is a Bug Report

Problem:
Kubernetes can set an annotation, pv.kubernetes.io/bind-completed, but this is not registered or documented.
Proposed Solution:
Document the annotation in Well-Known Labels, Annotations and Taints.
Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

Additional Information:
/sig storage
/language en

/assign

Try https://github.com/kubernetes/kubernetes/search?q=bind-completed&type=code as a way to find code that uses this annotation.

Yes! that's nice. I had a same thought like searching out. 😄
So, I would go like this as below:
pv.kubernetes.io/bind-completed
Example: pv.kubernetes.io/bind-completed "true"

Used on: PersistentVolumeClaim

The value for this annotation must be true to take effect. This annotation indicates that persistent volume attached to the pods must be bound and status is completed.

You can write {{< glossary_tooltip text="PersistentVolume" term_id="persistent-volume" >}} instead of persistent volume and you then get a nice tooltip (see Custom Hugo Shortcodes).

/triage accepted

/remove-lifecycle stale

@afzal442 any updates on this? 🙂

hey @mehabhalodiya u can refer to this comment https://github.com/kubernetes/website/pull/36399#issuecomment-1383836558
I think u can close this issue

/close


No static/ when installed via pip

After running pip install -U django-import-export==0.4.3 you will notice that the import_export directory does not include the static/ directory, causing 404 errors on the js file.

Did you run the collectstatic command?

Yes, the static/ simply doesn't exist on the pypi package, so there's nothing to collect from it. If I install from the latest commit in this repo, it works just fine.

Confirming.

Thanks for reporting, this should be fixed with new release.


Disable mediacodec and use openh264; A compilation error occurred

[ 75%] Building C object libfreerdp/CMakeFiles/freerdp.dir/codec/h264_openh264.c.o
[ 75%] Building C object libfreerdp/CMakeFiles/freerdp.dir/codec/h264_mediacodec.c.o
In file included from /home/fyb/Desktop/freerdp-2.7.0/libfreerdp/codec/h264_mediacodec.c:27:
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:94:9: error: must use 'struct' tag to refer to type 'ANativeWindow'
ANativeWindow* surface,
^
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:152:15: error: expected parameter declarator
static_assert(sizeof(_off_t_compat) == sizeof(long),
^
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:152:15: error: expected ')'
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:152:14: note: to match this '('
static_assert(sizeof(_off_t_compat) == sizeof(long),
^
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:198:59: error: must use 'struct' tag to refer to type 'ANativeWindow'
media_status_t AMediaCodec_setOutputSurface(AMediaCodec*, ANativeWindow* surface);
^
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:223:29: error: must use 'struct' tag to refer to type 'ANativeWindow'
AMediaCodec *mData, ANativeWindow **surface);
^
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:239:9: error: must use 'struct' tag to refer to type 'ANativeWindow'
ANativeWindow **surface);
^
/home/fyb/Downloads/android-ndk-r15c/sysroot/usr/include/media/NdkMediaCodec.h:252:29: error: must use 'struct' tag to refer to type 'ANativeWindow'
AMediaCodec mData, ANativeWindow surface);
^
/home/fyb/Desktop/freerdp-2.7.0/libfreerdp/codec/h264_mediacodec.c:69:86: error: must use 'struct' tag to refer to type 'ANativeWindow'
typedef media_status_t (AMediaCodec_configure_t)(AMediaCodec, const AMediaFormat, ANativeWindow,
^
struct
8 errors generated.
make[2]: *** [libfreerdp/CMakeFiles/freerdp.dir/build.make:1720: libfreerdp/CMakeFiles/freerdp.dir/codec/h264_mediacodec.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2146: libfreerdp/CMakeFiles/freerdp.dir/all] Error 2
make: *** [Makefile:171: all] Error 2
[ERROR] cmake --build . --target install retured 2

freerdp-2.7.0
openh264：v1.8.0
ndk：r15c

well, you´re doing it wrong :)
more seriously, could you add the parts of the description what you actually do? (e.g. your cmake command line?)

I just modified some Android-build.conf；Then it is compiled directly by ./scripts/android-build-freerdp.sh
WITH_JPEG=0
WITH_OPENH264=1
WITH_MEDIACODEC=0
WITH_OPENSSL=1
WITH_FFMPEG=0
BUILD_DEPS=1
DEPS_ONLY=0
NDK_TARGET=26
JPEG_TAG=master
OPENH264_TAG=v1.8.0  # NOTE: NDK r15c or earlier needed in --openh624-ndk for v1.8.0
OPENSSL_TAG=OpenSSL_1_1_1m
FFMPEG_TAG=n4.4.1
SRC_DIR=$SCRIPT_PATH/..
BUILD_DST=$SCRIPT_PATH/../client/Android/Studio/freeRDPCore/src/main/jniLibs
BUILD_SRC=$SRC_DIR/build
CMAKE_BUILD_TYPE=Debug
BUILD_ARCH="armeabi-v7a arm64-v8a"

Isn't it configured like this?

no, but I´ve added that option now with #7899
anyway, your compilation error is strange. Did you run this on a unclean checkout? (there might be problems if you run it repeatedly)

@FengYuanBiao just a note though, OpenH264 build system is still broken as hell, you need to compile with a different (old NDK) which does have issues with all other dependencies, so best build in separate steps.

@akallabeth
The environment should be OK. Then I'll try to build with n15r previous ndks. You think you can try this, right?

@FengYuanBiao just compiled successfully with:
ANDROID_NDK=~/Android/Sdk/ndk/23.1.7779620/
ANDROID_NDK_OPENH264=~/Android/Sdk/ndk/18.1.5063045/


Joining does NOT work

I wanted to join 9 tokens to a server, and it keeps saying "Unexpected status code 400 while joining token "token"

Use DMDGO's joiner. It's updated there


address book reverts to view all after add-tag

TODO: Clarify if this bug can be fixed - reasonable expectation that the list will not reset when adding the tag


Add openweb bid adapter doc

OpenWeb PBJS adapter in 5.5, but PBS adapter not released yet. I'll go ahead and merge this assuming the server-side adapter will soon be approved.


Omnitruck artifact does not exist for Rocky Linux

Description
https://omnitruck.chef.io/install.sh is now setting platform to "rocky" for rocky linux.  Previously it was setting platform to "el".
The download url created by install.sh is now (notice the p=rocky)
https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=rocky&pv=8.8&m=x86_64
unfortunately that url returns a 404
Previously(2023-Oct-13) the url created by install.sh for rocky linux was
https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=el&pv=8&m=x86_64
notice p=el and pv=8
It looks like install.sh was recently updated to better account for the contents of rocky linux's /etc/os-release but https://omnitruck.chef.io/stable/chef/metadata wasn't updated for the new values returned from the updated install.sh
Chef Version
Chef Infra Client: ALL
Platform Version
Rocky Linux 8
Replication Case
These rocky specific values return 404
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=rocky&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=17&p=rocky&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=18.2&p=rocky&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=18.3&p=rocky&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=18&p=rocky&pv=8.8&m=x86_64"

These generic "el" values return valid data
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=el&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=17&p=el&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=18.2&p=el&pv=8.8&m=x86_64"

# notice these return a url for el7, not el8.  this should probably also be fixed
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=18.3&p=el&pv=8.8&m=x86_64"
curl -v "https://omnitruck.chef.io/stable/chef/metadata?v=18&p=el&pv=8.8&m=x86_64"

Client Output
output from broken attempt (2023-Oct-18]
notice the platform is being set to rocky
[2023-10-18T03:26:42.629Z]     amazon-ebs: Now we can run chef-colo version 17.10
[2023-10-18T03:26:42.629Z]     amazon-ebs:
[2023-10-18T03:26:42.629Z] ==> amazon-ebs: Provisioning with chef-solo
[2023-10-18T03:26:42.629Z]     amazon-ebs: Installing Chef...
[2023-10-18T03:26:42.629Z] ==> amazon-ebs:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[2023-10-18T03:26:42.629Z] ==> amazon-ebs:                                  Dload  Upload   Total   Spent    Left  Speed
[2023-10-18T03:26:42.629Z] ==> amazon-ebs: 100 23710  100 23710    0     0  1218k      0 --:--:-- --:--:-- --:--:-- 1218k
[2023-10-18T03:26:42.630Z]     amazon-ebs: rocky 8.8 x86_64
[2023-10-18T03:26:42.630Z]     amazon-ebs: Getting information for chef stable 17.10 for rocky...
[2023-10-18T03:26:42.630Z]     amazon-ebs: downloading https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=rocky&pv=8.8&m=x86_64
[2023-10-18T03:26:42.630Z]     amazon-ebs:   to file /tmp/install.sh.5941/metadata.txt
[2023-10-18T03:26:42.630Z]     amazon-ebs: trying wget...
[2023-10-18T03:26:42.630Z]     amazon-ebs: ERROR 404
[2023-10-18T03:26:42.630Z]     amazon-ebs: Omnitruck artifact does not exist for version 17.10 on platform rocky
[2023-10-18T03:26:42.630Z]     amazon-ebs:
[2023-10-18T03:26:42.630Z]     amazon-ebs: Either this means:
[2023-10-18T03:26:42.630Z]     amazon-ebs:    - We do not support rocky
[2023-10-18T03:26:42.630Z]     amazon-ebs:    - We do not have an artifact for 17.10
[2023-10-18T03:26:42.630Z]     amazon-ebs:
[2023-10-18T03:26:42.630Z]     amazon-ebs: This is often the latter case due to running a prerelease or RC version of Chef
[2023-10-18T03:26:42.630Z]     amazon-ebs: or a gem version which was only pushed to rubygems and not omnitruck.
[2023-10-18T03:26:42.630Z]     amazon-ebs:
[2023-10-18T03:26:42.630Z]     amazon-ebs: You may be able to set your knife[:bootstrap_version] to the most recent stable
[2023-10-18T03:26:42.630Z]     amazon-ebs: release of Chef to fix this problem (or the most recent stable major version number).
[2023-10-18T03:26:42.630Z]     amazon-ebs:
[2023-10-18T03:26:42.630Z]     amazon-ebs: In order to test the version parameter, adventurous users may take the Metadata URL
[2023-10-18T03:26:42.630Z]     amazon-ebs: below and modify the '&v=<number>' parameter until you successfully get a URL that
[2023-10-18T03:26:42.630Z]     amazon-ebs: does not 404 (e.g. via curl or wget).  You should be able to use '&v=11' or '&v=12'
[2023-10-18T03:26:42.630Z]     amazon-ebs: successfully.
[2023-10-18T03:26:42.630Z]     amazon-ebs:
[2023-10-18T03:26:42.630Z]     amazon-ebs: If you cannot fix this problem by setting the bootstrap_version, it probably means
[2023-10-18T03:26:42.630Z]     amazon-ebs: that rocky is not supported.
[2023-10-18T03:26:42.630Z]     amazon-ebs:
[2023-10-18T03:26:42.630Z]     amazon-ebs: Metadata URL: https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=rocky&pv=8.8&m=x86_64

output from successful attempt (2023-Oct-13)
notice the platform is being set to el
[2023-10-13T17:26:50.210Z] ==> amazon-ebs: Provisioning with chef-solo
[2023-10-13T17:26:50.210Z]     amazon-ebs: Installing Chef...
[2023-10-13T17:26:50.210Z] ==> amazon-ebs:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[2023-10-13T17:26:50.210Z] ==> amazon-ebs:                                  Dload  Upload   Total   Spent    Left  Speed
[2023-10-13T17:26:50.210Z] ==> amazon-ebs: 100 23526  100 23526    0     0   522k      0 --:--:-- --:--:-- --:--:--  522k
[2023-10-13T17:26:50.210Z]     amazon-ebs: el 8 x86_64
[2023-10-13T17:26:50.210Z]     amazon-ebs: Getting information for chef stable 17.10 for el...
[2023-10-13T17:26:50.210Z]     amazon-ebs: downloading https://omnitruck.chef.io/stable/chef/metadata?v=17.10&p=el&pv=8&m=x86_64
[2023-10-13T17:26:50.210Z]     amazon-ebs:   to file /tmp/install.sh.5906/metadata.txt
[2023-10-13T17:26:50.210Z]     amazon-ebs: trying wget...
[2023-10-13T17:26:50.771Z]     amazon-ebs: sha1	25ba625102b3d8d0200f923afe7ccc296945f20a
[2023-10-13T17:26:50.771Z]     amazon-ebs: sha256	c02dea79437b38a8b9e6f4c8d984318b16005ee8ade724708d4312e267d98dbb
[2023-10-13T17:26:50.771Z]     amazon-ebs: url	https://packages.chef.io/files/stable/chef/17.10.3/el/8/chef-17.10.3-1.el8.x86_64.rpm
[2023-10-13T17:26:50.771Z]     amazon-ebs: version	17.10.3
[2023-10-13T17:26:50.771Z]     amazon-ebs: downloaded metadata file looks valid...
[2023-10-13T17:26:50.771Z]     amazon-ebs: downloading https://packages.chef.io/files/stable/chef/17.10.3/el/8/chef-17.10.3-1.el8.x86_64.rpm
[2023-10-13T17:26:50.771Z]     amazon-ebs:   to file /tmp/install.sh.5906/chef-17.10.3-1.el8.x86_64.rpm
[2023-10-13T17:26:50.771Z]     amazon-ebs: trying wget...
[2023-10-13T17:26:51.026Z]     amazon-ebs: Comparing checksum with sha256sum...
[2023-10-13T17:26:51.026Z]     amazon-ebs: Installing chef 17.10
[2023-10-13T17:26:51.027Z]     amazon-ebs: installing with rpm...

Something changed with install.sh between 2023-Oct-13 and 2023-Oct-18.
additional info
Here are the contents of /etc/os-release from my rocky 8 box
NAME="Rocky Linux"
VERSION="8.8 (Green Obsidian)"
ID="rocky"
ID_LIKE="rhel centos fedora"
VERSION_ID="8.8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Rocky Linux 8.8 (Green Obsidian)"
ANSI_COLOR="0;32"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:rocky:rocky:8:GA"
HOME_URL="https://rockylinux.org/"
BUG_REPORT_URL="https://bugs.rockylinux.org/"
SUPPORT_END="2029-05-31"
ROCKY_SUPPORT_PRODUCT="Rocky-Linux-8"
ROCKY_SUPPORT_PRODUCT_VERSION="8.8"
REDHAT_SUPPORT_PRODUCT="Rocky Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.8"

Contents of /etc/os-release have not change between 2023-Oct-13 and 2023-Oct-18.

this patch fixes install.sh found at https://omnitruck.chef.io/install.sh
--- install.sh.orig     2023-10-19 13:45:24.733410719 -0500
+++ install.sh  2023-10-19 13:45:56.159421315 -0500
@@ -440,7 +440,7 @@
        source /etc/os-release
        os="${REDHAT_SUPPORT_PRODUCT}"
        platform_version="${ROCKY_SUPPORT_PRODUCT_VERSION}"
-        platform=$ID
+        platform="redhat"

   elif test "$platform" = "xenserver"; then
     # Current XenServer 6.2 is based on CentOS 5, platform is not reset to "el" server should handle response

Argh, bitten by the same issue here... Thank you for the write-up @gpanula!
Would it make sense to open an issue over at https://github.com/chef/omnitruck ?

Thanks @gpanula for details. I am blocked because of the same, was wondering if there is way to get the older install.sh while the current one gets fixed

Argh, bitten by the same issue here... Thank you for the write-up @gpanula! Would it make sense to open an issue over at https://github.com/chef/omnitruck ?

Thanks, I wasn't aware of the omnitruck repo.
I've opened https://github.com/chef/omnitruck/issues/600  for this issue in that repo.

@gpanula , thanks for reporting the issue, the install.sh changes that generated the issue have been reverted now.
Feel free to verify again an report back if the issue still persists.

https://omnitruck.chef.io/install.sh works for me as it has parameter p=el
But test kitchen fails. My kitchen.yml contains this:
  - name: rocky8
    driver:
      image_urn: center-for-internet-security-inc:cis-rocky:cis-rockylinux-8-l1-gen2:latest
      plan:
        name: "cis-rockylinux-8-l1-gen2"
        product: "cis-rocky"
        publisher: "center-for-internet-security-inc"
    transport:
      name: ssh
      elevated: true
    provisioner:
      name: chef_infra
      product_name: chef
      # product_version: 17.10.95 # https://github.com/chef/omnitruck/issues/600
      product_version: 18.3.0
      always_update_cookbooks: true
      chef_license: accept-no-persist
      root_path: /home/azure/test-kitchen # default /tmp has noexec on CIS hardened images

error is
       Preparing client.rb
       rocky 8.7 x86_64
       Getting information for chef stable 18.3.0 for rocky...
       downloading https://omnitruck.chef.io/stable/chef/metadata?v=18.3.0&p=rocky&pv=8.7&m=x86_64
         to file /home/azure/test-kitchen/metadata.txt
       trying curl...
       Unable to retrieve a valid package!
       Version: 18.3.0

Note p=rocky in the URL.
There is no problem with 17.10.95

In 18.4.2 https://omnitruck.chef.io/stable/chef/metadata?v=18.4.2&p=rocky&pv=8.7&m=x86_64 seems to be good now.

Well...
https://omnitruck.chef.io/stable/chef/metadata?v=18.2.7&p=rocky&pv=8.8&m=x86_64 had been working fine for us for months, until it seems to have fallen off the bandwagon today. We'd only do the "sudo sed -e 's/^ID=\"[^\"]*\"/ID=\"redhat\"/' -i /etc/os-release" hack on < 18.2.7, but have now had to extend that to 18.2.7 as well.
https://omnitruck.chef.io/stable/chef/metadata?v=18.4.2&p=rocky&pv=8.8&m=x86_64 is fine, but is it a "feature" that previous artifacts evaporate all of a sudden?
Thanks!

👀

There are no artifacts for ARM64(aarch64) either.


Implements originalHandlers

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
This implements originalHandlers

Implements: https://github.com/syntax-tree/mdast-util-to-markdown/issues/34

wontfix due to the conversation in the corresponding issue: https://github.com/syntax-tree/mdast-util-to-markdown/issues/34#issuecomment-899344222


crash with ex nihilo creatio

Here is the pastebin:
https://pastebin.com/hDgxubsF

update ex nihilo


[Feature request] Percent encoding support

1. Request
It would be nice, if users can preview images by links with percent encoding.
2. Justification
I'm Russian man. I work with Russian-language images. Now I can't preview decoded and non-decoded images with Russian-language symbols.
3. Settings
For example, I have test.md file. It content:
1. ![photo 1](https://upload.wikimedia.org/wikipedia/commons/thumb/c/c0/Cleopatras.needle.from.thames.london.arp.jpg/781px-Cleopatras.needle.from.thames.london.arp.jpg)
2. ![photo 2](https://upload.wikimedia.org/wikipedia/ru/thumb/d/db/%D0%9C%D0%BE%D0%BD%D1%83%D0%BC%D0%B5%D0%BD%D1%82_%D0%92%D0%BE%D0%B8%D0%BD%D1%81%D0%BA%D0%BE%D0%B9_%D0%A1%D0%BB%D0%B0%D0%B2%D1%8B_%28%D0%92%D0%B8%D0%B41%29.jpg/320px-%D0%9C%D0%BE%D0%BD%D1%83%D0%BC%D0%B5%D0%BD%D1%82_%D0%92%D0%BE%D0%B8%D0%BD%D1%81%D0%BA%D0%BE%D0%B9_%D0%A1%D0%BB%D0%B0%D0%B2%D1%8B_%28%D0%92%D0%B8%D0%B41%29.jpg)
3. ![photo 3](https://upload.wikimedia.org/wikipedia/ru/thumb/d/db/Монумент_Воинской_Славы_(Вид1).jpg/320px-Монумент_Воинской_Славы_(Вид1).jpg)

I successful open all photos.
4. Steps to reproduce
I hover my mouse to URL's of photo 1, 2, 3.
5. Expected behavior
If photo 1:

6. Actual behavior
If photo 2, I can't preview photo. I get stack trace in Sublime Text console:
Traceback (most recent call last):
  File "D:\Sublime Text 3 x64\sublime_plugin.py", line 389, in run_callback
    expr()
  File "D:\Sublime Text 3 x64\sublime_plugin.py", line 620, in <lambda>
    run_callback('on_hover', callback, lambda: callback.on_hover(v, point, hover_zone))
  File "hover_preview in D:\Sublime Text 3 x64\Data\Installed Packages\Hover Image Preview.sublime-package", line 100, in on_hover
  File "./python3.3/urllib/request.py", line 156, in urlopen
  File "./python3.3/urllib/request.py", line 475, in open
  File "./python3.3/urllib/request.py", line 587, in http_response
  File "./python3.3/urllib/request.py", line 513, in error
  File "./python3.3/urllib/request.py", line 447, in _call_chain
  File "./python3.3/urllib/request.py", line 595, in http_error_default
urllib.error.HTTPError: HTTP Error 404: Not Found

If photo 3, I don't get preview and stack trace.
Thanks.

@Kristinita the last version (0.0.12) that I just released fixes the problem with number 2. The problem with number 3 however has to do with the way the parentheses are being fetched so I'll have to change the way links are being fetched from the files which will take a longer. I'll let you know once I have a chance to fix that. Thank you

+1 for issue - just installed your plugin @alvesjtiago , but on all of my images I got just small, grey square pop up instead of image.

URLs:

background: url('http://secure.p06.eloqua.com/EloquaImages/clients/WoltersKluwer/{9584504f-22b7-4c22-a3e2-f4668c53f9b7}_cta-arrow.png') no-repeat right center #e5202e !important;
3.
Neither works, however I can preview both 1. and 2. from original issue by @Kristinita

Thank you for reporting the issue @MateuszDabrowski. I've just released version 0.0.14 which fixes what you have reported. Please let me know if it is now working for you. I'll get back to the remaining parentheses issue reported by @Kristinita once I have the chance.

@alvesjtiago Fixed :) Thank you!

#36 implements highlight + hover as a workaround for number 3 and the like

#37 fixes number 3

This is addressed with #37 and version 0.1.0 which should be automatically updated via package manager.


Add -H, --links option support and hide the number of hard links in the default view

  -H, --links                list each file's number of hard links

b518c103adb74e7f3f9bd0b85a76bb219cf79fef


[v2] Not permitted

Provided that my Class is not secured and i have implemented logic for checking in events like beforeRemove, i can't remove dependant documents in other collections because i am not using an ID selector and the remove was triggered from client. Why does this limitation exist?
Shouldn't be the programmer be responsible for security?

It's how it works in Meteor and I've just duplicated this behavior. They probably had good reason to do so. I've tried to think of the situation when it can be not save to allow deletions with non id selectors and I don't think it's so big deal. However, they decided to do this and I don't want to mess with this philosophy to not introduce any confusion for developers.

I've got a similar issue, I think.
My Class "Watchlist" is secured and I've removed the meteor package insecure.
I'm using Meteors ValidatedMethod to create a method to remove an item. The code in my Meteor Method is:
if (! this.userId) {
  throw new Meteor.Error('watchlists.remove.notLoggedIn');
}

const result = Watchlist.remove({
  _id: watchlistId,
  userId: this.userId,
});

if (! result) {
  throw new Meteor.Error('watchlists.remove.notFound');
}

return result;

I'm not using just the ID because I'm confirming the user owns the Watchlist he/she is trying to remove
I'd like to simulate the result on the client, but I'm getting a Not Permitted error. I'm I doing it wrong?

Consider the follow:
A user owns a campaign and each campaign has a lot of line items and the user triggers a remove for the campaign from the client side. We can't remove all the line items using the campaign id selector. I think this is a reasonable use case.

I'm not going to change it. It's how it's implemented in Meteor so I will stick to it, to make it concise. So far users are creating big applications using Meteor and that wasn't a big deal. I know it may be a constraint but it's not a problem without a workaround. If MDG will change it in the future I will change it too.

I would be glad if you could look for some MDG response to this problem. Why they implemented it that way.

I'm working on one bug in Astronomy and I've noticed that in some cases it's possible in Meteor to remove or update documents by ID. The requirement is calling doc.remove() from within a meteor method call. There is a check in Meteor if we're already in simulation. If so, then we don't check id restrictions. I will update my code to reflect that after I'm done solving the current one problem.

Great!  That addresses exactly my issue. I'll be able to remove in simulation without the "id" restriction. Looking forward to the fix.
Thanks for reopening.

Ok I've fixed it. If you want to use it right away you can clone current version from GitHub. Otherwise it will be available with the next bug fix version. I only have to fix one more bug and I will be releasing. Closing for now.


Browser Extension - eth_signTypedData_v4 "Error - ChainId Mismatch"

Describe the bug
With the Trust Wallet browser extension, we cannot use the request method eth_signTypedData_v4, as it either fails the sign request, or does not even allow to click the confirm button to proceed.
To Reproduce
With the extension enabled, the following in your browser console will cause the "ChainId Mismatch" error in the screenshot below:
await window.ethereum.request({
  method: 'eth_signTypedData_v4',
  params: [
    (await window.ethereum.request({ method: 'eth_requestAccounts' }))[0],
    JSON.stringify({
      domain: {
        name: "Foobar",
        version: "1"
      },
      message: {
        nonce: "a-unique-nonce-hash"
      },
      primaryType: "Auth",
      types: {
        EIP712Domain: [
          { name: "name", type: "string" },
          { name: "version", type: "string" }
        ],
        Auth: [
          { name: "nonce", type: "string" }
        ]
      }
    }),
  ]
});

If I explicitly set a chainId on the domain, sometimes it will trigger the same error, other times it will let me confirm the sign request, however it will fail with error code -32603 and message "The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined":
await window.ethereum.request({
  method: 'eth_signTypedData_v4',
  params: [
    (await window.ethereum.request({ method: 'eth_requestAccounts' }))[0],
    JSON.stringify({
      domain: {
        chainId: window.ethereum.chainId,
        name: "Foobar",
        version: "1"
      },
      message: {
        nonce: "a-unique-nonce-hash"
      },
      primaryType: "Auth",
      types: {
        EIP712Domain: [
          { name: "chainId", type: "string" },
          { name: "name", type: "string" },
          { name: "version", type: "string" }
        ],
        Auth: [
          { name: "nonce", type: "string" }
        ]
      }
    }),
  ]
});

Expected behavior
The same code works just fine with Metamask for instance, and also on Trust Wallet for mobile even. Only the browser extension seems affected.
Screenshots

Additional context
Tested Chrome version only on both Windows and MacOS.

The same issue with 'personal_sign' at extension only.
Environment:

Trust Wallet Extension Version 0.0.229
Google Chrome Version 109.0.5414.119 (Official Build) (x86_64)
We are using @wagmi/core library:
const signature: string = yield signMessage({       message: message as string     })
Got error:


Remove Gmail hack for font size manipulation

The hack to avoid Gmail from resizing text size no longer works: http://freshinbox.com/blog/gmail-supports-displaynone-and-gmail-ios-font-fix-update/

Thanks for the PR! Do you know of another method that works or is this no longer an issue?

It seems the Gmail-specific hack is no longer necessary. I've removed the hack from my campaigns, and see no font resizing, but I can't confirm that this isn't due to my custom CSS. I'll try to set up a few tests, but someone else should confirm this too.

I suggest keeping the hack in for those situations where it's needed (depending on what accounts you add to Gmail, it may or may not support media queries - currently i still use the fix for Android 5.1 stock). What I suggest you do is keep the code, but remove display: none from being inlined (this makes it unnecessary). Create a media query that applies display: none to that code. This way, if the client supports media queries / styles in the head, the forcing of desktop is hidden, and if they don't they get the desktop version / fix for the font-size and layout auto-manipulation. Let me know if you need a code example.


Instant Execute

Allow an option to permit 1 button-press -> start.
While I might not want it on by default, the Jobs and Spooler window could just be skipped and projects could be started with a single button press (maybe forcing the jobs window if you try to instant run a second time).

Unfixed and Passing on this feature.


Add support for workflows

…or multi-step triggers.
In other words, the ability to chain commands together, running additional commands on the result.
Examples:

Finder Selection → Get Path → Paste
Capture Screen → Scale Image… 50% → Email To… (Compose)

Some of this can be accomplished using Event Triggers, but those always run in response to something.
The code should be fairly simple. Don’t even know where to start with the UI.

Is this the same as #538?

Just thinking out loud, the current UI replaces one command window with the next. Perhaps the keystroke to add a new chained command could append a new command window (with the needed panes lined up) below the old one (in the case of Bezel and most others) or to the right (in the case of Primer and other vertical interfaces).

Is this the same as #538?

No, I think that’s more like #225 on steroids. That is, redisplay the interface with the second pane selected for all actions.

@hmelman I was thinking this UI would be in the preferences somewhere, like the “command builder” for defining commands in triggers. But anyone who wants to volunteer to handle that part can implement it however the want. 😃

Yeah I was thinking of "the command builder" too. I think it definitely should display the entire command (or all the commands?) at the same time.


Add underscore to js evaluation to allow for use of get()

This will help with nested fields that could potentially be null

On Performance
after pulling up vm creation to an init function it is way way faster in every sense:
1.03s user 1.03s system 188% cpu 1.094 total

(tested on 1.5k entries)
On shared state
I reckon overwriting the subject each operation will protect us from any serious issues and further effort is not warranted because:

Checked all 1.5k entries made and they match with entries in the database, so nothing is getting garbled by reusing the VM (at least in this simple use case)
Someone went down the rabbit hole of making this safe a few years ago and it looks like they gave up. Although it seems like it was an academic concern even in their use case
I can't imagine what a user would have to be doing with their jsonnet file to really start leaving nasty state in our otto VM. If that happens in the next few months I feel like we can tell them not to get clever with their jsonnet files and be a normal egg.

Something isn't quite right here - when I test locally on the backstage samples, only catalog types defined without a filter are synced. Filters are checked in output/collect.go

tweaked the jsonnet file, should be working now

This looks good and all works for me! You can merge and cut a minor release. Also it's probably worth following up w Hank from Netflix (you can find this on the original thread)


Typo in SpectralFit example notebook

@eneights The file FlatContinuumIsotropic.LowRes.binnedimaging.imagingresponse.area.nside8.cosipy.h5 needs '.gz' at the end. Note that this needs to be corrected in two places in the notebook.

This issue has been addressed with PR#105.


fix macro property file

Description & motivation
fix
To-do before merge
fix the sample file location in this link https://docs.getdbt.com/faqs/documenting-macros
Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

@bachng2017 This change looks good but this FAQ is now in a Docs folder.  Do you need help resolving the conflict?

hey @bachng2017 Thank you for contributing and improving the product docs at dbt! We’ve moved your commit to another PR in order to fix merge conflicts. Your edits will be looked at and merged #2830 which addresses your fix. I'll go ahead and close this issue.


Update packages

cc @rainfore
P.S. Please release this as a minor version, 0.8.1, as there are no breaking changes.

This PR does not work.
$ npm run test

><EMAIL_ADDRESS>test
> mocha tests

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/anders/js/webfonts-generator/node_modules/read-chunk/index.js from /home/anders/js/webfonts-generator/tests/test.js not supported.
Instead change the require of index.js in /home/anders/js/webfonts-generator/tests/test.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/home/anders/js/webfonts-generator/tests/test.js:8:17)
    at async formattedImport (/home/anders/js/webfonts-generator/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async exports.requireOrImport (/home/anders/js/webfonts-generator/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async exports.loadFilesAsync (/home/anders/js/webfonts-generator/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/home/anders/js/webfonts-generator/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async exports.handler (/home/anders/js/webfonts-generator/node_modules/mocha/lib/cli/run.js:370:5)

I’ve opened a replacement:

#14

Perhaps, yes, I haven't been using this package for a while now. I'll close this as the other PR is better.


Crashed: com.apple.main-thread EXC_BREAKPOINT 0x0000000101522608

We are getting crash in production and it is not reproducible. Any help is appreciable.
Flutter 3.0.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision https://github.com/flutter/flutter/commit/ee4e09cce01d6f2d7f4baebd247fde02e5008851 (5 months ago) • 2022-05-09 16:45:18 -0700
Engine • revision d1b9a6938a
Tools • Dart 2.17.0 • DevTools 2.12.2
Logs
Crashed: com.apple.main-thread
0  TCPApp                         0xe12608 NeuFlutterEngine.setup() + 41 (NeuFlutterEngine.swift:41)
1  TCPApp                         0x6b6d84 NeuEngineCache.getEngine(identifier:) + 18 (NeuEngineCache.swift:18)
2  TCPApp                         0x55e7b4 partial apply for closure #1 in FlutterAnalyticsProvider.eventTracker(eventType:payload:funcName:) + 27 (FlutterAnalyticsProvider.swift:27)
3  TCPApp                         0x8f10 thunk for @escaping @callee_guaranteed () -> () ()
4  libdispatch.dylib              0x63094 _dispatch_call_block_and_release
5  libdispatch.dylib              0x64094 _dispatch_client_callout
6  libdispatch.dylib              0x10d40 _dispatch_main_queue_drain
7  libdispatch.dylib              0x10990 _dispatch_main_queue_callback_4CF$VARIANT$mp
8  CoreFoundation                 0x4dab4 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 12
9  CoreFoundation                 0xafd8 __CFRunLoopRun + 2544
10 CoreFoundation                 0x1dc30 CFRunLoopRunSpecific + 572
11 GraphicsServices               0x1988 GSEventRunModal + 160
12 UIKitCore                      0x4e5c50 -[UIApplication _run] + 1080
13 UIKitCore                      0x27f3d0 UIApplicationMain + 336
14 TCPApp                         0xbc5c5c main + 39 (AppDelegate.swift:39)
15 ???                            0x108f183d0 (Missing)

Logs

@siddew201 Could you provide pubspec.yaml file content and a list of affected device information?
Also, please provide the output of flutter doctor -v as well. Thank you!

Hi @huycozy Thanks for response . Please find pubspec.yml file content and affected device/OS detail below
Pubspec.yml content
version: 1.0.0+1
environment:
  sdk: ">=2.16.2 <3.0.0"
dependencies:
  flutter:
    sdk: flutter
collection: ^1.16.0
  flutter_dotenv: ^5.0.2
  mobx: ^2.0.7+4
  flutter_mobx: ^2.0.6+1
  routemaster: ^1.0.1
  webview_flutter: ^3.0.4
  json_annotation: ^4.6.0
  provider: ^6.0.3
  intl: ^0.17.0
  easy_debounce: ^2.0.2+1
  html: ^0.15.0
  url_launcher: ^6.1.5
  hive: ^2.2.3
  hive_flutter: ^1.1.0
  lottie: ^1.3.0
  avatars: ^2.0.2
  focus_detector: ^2.0.1
  dotted_border: ^2.0.0+2
  geocoding: ^2.0.5
  geolocator: 8.2.1
  device_info_plus: 4.1.0
  visibility_detector: ^0.2.2
  launchdarkly_flutter_client_sdk: ^1.1.2
  new_version: ^0.3.1
  cupertino_icons: ^1.0.5
  modal_bottom_sheet: ^2.1.0
  package_info_plus: ^1.4.2
  path: ^1.8.0
  chewie: ^1.3.4
  video_player: ^2.4.5
  youtube_player_flutter: ^8.1.0
  cached_network_image: ^3.2.1
  animations: ^2.0.3
  expandable_page_view: ^1.0.17
dev_dependencies:
  flutter_lints: ^2.0.1
  json_serializable: ^6.1.1
  build_runner: ^2.2.0
  flutter_test:
    sdk: flutter
flutter:
  module:
    androidX: true
    androidPackage: com.tatadigital.neu_app_embed
    iosBundleIdentifier: com.tatadigital.neuAppEmbed
  assets:
    - assets/logo_512x512.png
    -<EMAIL_ADDRESS>Affected Devices and CrashCount:
iPhone7 - (3)
Affected OS and CrashCount:
15.4.0 - (3 Crash)

@flutter-symbolizer-bot https://github.com/flutter/flutter/issues/112846#issue-1395773092 force flutter#v3.0.0 ios release arm64

@siddew201 It doesn't have a lot of Flutter logs here as I can see. Are there any remaining logs from Crashlytic tool that you can provide?


Show token balance in transaction page

Looks like the transaction details page shows ETH balance even if you are sending a token.  I feel like it should show the token balance instead, as ETH balance during token transfer is confusing.

The transaction page is now showing token balance


docs(core): future feature is present feature

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.85%. Comparing base (1a1aaf4) to head (c0ad060).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   97.85%   97.85%
=======================================
  Files          10       10
  Lines         373      373
=======================================
  Hits          365      365
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error when chunk coordinates are invalid

Closes #175

@emacollins I wonder if the CI failure is a real one ... maybe we are actually writing to an array out of bounds and your change is now flagging it? Do you think you can take a look at what that failing test is doing?

@emacollins I just looked at the code of that test that is failing. I think it's a bad test:
    let zarr_meta = ZarrArrayMetadata {
        shape: vec![SIZE as u64, SIZE as u64],
        data_type: DataType::Float64,
        chunk_shape: ChunkShape(vec![
            NonZeroU64::new(2).unwrap(),
            NonZeroU64::new(2).unwrap(),
        ]),
        chunk_key_encoding: ChunkKeyEncoding::Slash,
        fill_value: FillValue::Float64(f64::NAN),
        codecs: vec![],
        storage_transformers: None,
        dimension_names: None,
    };

Chunks are size 2, and we are writing to all coordinates. I think things will pass if you make the chunk size 1x1

@emacollins please let me know if you need help with that failing test

@emacollins please let me know if you need help with that failing test

Just pushed the change to run the test again, but caught in some rebase conflicts headache...Will need to pick this up tomorrow. Apologies for the delay on getting this over the line.

No problem @emacollins ! Thank you!

We just need a cargo fmt --all now and we can merge

@paraseba saw some additional tests failed on the last run, pushed a quick fix that should pass them

Awesome work @emacollins, thank you!
Feel free to join our icechunk slack channel if you are interested, and let me know if you want to work on some other issue.


Move to api 26

Coverage remained the same at 83.704% when pulling 8bda89a568aae903a1a1524d0a77eb99520e50e4 on api-26 into 9f7d9aff6e2dbb9b44fd4c01ca900f8882a6666f on master.


Improvements for the exclusion window

The exclusion page is a bit complex for UX. So a few improvement ideas:

Sort types alphabetically
Group by assembly (so we can exclude whole assemblies)

Would be a good improvement. I don't know, if sharpDox will get this feature. Because I am writing a complete new version of it for .NET Core.


window_size_samples effects infer speed

when i use v3.1 vad onnx model to process audio file, i found that different window size has different infer speed. the 1024 window size is 2x faster than 512 window size(the whole infer time costs on the same audio file)
however, v5.1 vad model has deprecated the window_size_samples parameter, i think its worth to reuse this parameter.

This makes sense, because in case of larger windows, the VAD is incurred less often.
But the new VAD is heavily simplified and sped up, so it is unlikely that we will return the variable window.


Support for messaging individual users

When configuring the Slack integration, you can select particular users instead of channels. But this option is not anywhere in the Jenkins plugin configuration. Is it supported at all? If so, how is it used?
I've tried <username> & @<username> on the Project Channel setting but none of them worked (ie. no messages at all posted).

I don't actively develop this plugin.  I maintain pull requests and releases from now on.  Please feel free to contribute this feature!

@username should work in Project Channel. If several usernames are required, separate them with commas.

Next time I spin up my VM I'll test this.

If you would like to be invited to https://jenkins-slack-plugin.slack.com/ for testing then just ask.

@<username> indeed works. Thanks @peergum


Building from source don't create bin dir in ElmPlatform on Linux

I have this output while building 0.15.1 gist
and Elm-Platform/0.15/bin does not exist tree
I'v got GHC version 7.10.2 and cabal cabal-install version <IP_ADDRESS> using version <IP_ADDRESS> of the Cabal library
Sorry If this is not helpful but I have no idea about Haskell magic :wink:

I think the latest release of cabal made it so instead of bin/ things go into .cabal-sandbox/bin/. Do you have that directory?

See #64.

Thank you! I'll check it out as soon as I get home.

@jvoigtlaender, did cabal change such that what I said is true?
I am having extreme trouble figuring out exactly what is happening on what platform and why, so I need you to be as specific as possible or I won't understand.
Or is the existing build script messed up such that the initial call to cabal sandbox init is actually creating a sandbox that no one uses?

@evancz I wanted to chime in and say that I have the same issue as TeddyDD, but when I tried it again just now it worked.
Not sure if you've made any changes or it was sth. on my end.

@evancz, no, I am not aware that cabal changed in terms of what directories are used. But yes, the existing build script is messed up such that the initial call creates a sandbox then not used by later calls.

#55 should fix that in the public facing version of this, so @TeddyDD, do you mind downloading the latest version of BuildFromSource.hs and trying again? Make sure to destroy everything that's there now and run the fubar.sh script.
Not sure what's up with your case @Enzou, cabal and hackage are mysterious and ever changing. The builds can break and unbreak easily based on what other hackage libraries are doing in patch versions.
#63 is trying out a potentially more reliable route, but we need to figure out how to make it work for different versions of GHC, which it currently does not.

teddy@teddy-Inspiron-5720: Programy » bash fubar.sh                   [16:33:33]
erasing all your user ghc and cabal packages - are you sure (y/n) ? y
erasing directories under ~/.ghc
find: `/home/teddy/.ghc': Nie ma takiego pliku ani katalogu
erasing ~/.cabal/lib
teddy@teddy-Inspiron-5720: Programy » runhaskell BuildFromSource.hs 0.15.1
Cloning into 'elm-compiler'...
remote: Counting objects: 20461, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 20461 (delta 0), reused 0 (delta 0), pack-reused 20457
Receiving objects: 100% (20461/20461), 6.12 MiB | 1.27 MiB/s, done.
Resolving deltas: 100% (11942/11942), done.
Checking connectivity... done.
You are not currently on a branch. Please specify which
branch you want to merge with. See git-pull(1) for details.

    git pull <remote> <branch>

Cloning into 'elm-package'...
remote: Counting objects: 3221, done.
remote: Compressing objects: 100% (22/22), done.
remote: Total 3221 (delta 1), reused 0 (delta 0), pack-reused 3198
Receiving objects: 100% (3221/3221), 604.73 KiB | 715.00 KiB/s, done.
Resolving deltas: 100% (1898/1898), done.
Checking connectivity... done.
You are not currently on a branch. Please specify which
branch you want to merge with. See git-pull(1) for details.

    git pull <remote> <branch>

Cloning into 'elm-make'...
remote: Counting objects: 692, done.
remote: Total 692 (delta 0), reused 0 (delta 0), pack-reused 692
Receiving objects: 100% (692/692), 136.84 KiB | 0 bytes/s, done.
Resolving deltas: 100% (455/455), done.
Checking connectivity... done.
You are not currently on a branch. Please specify which
branch you want to merge with. See git-pull(1) for details.

    git pull <remote> <branch>

Cloning into 'elm-reactor'...
remote: Counting objects: 2340, done.
remote: Total 2340 (delta 0), reused 0 (delta 0), pack-reused 2340
Receiving objects: 100% (2340/2340), 1.61 MiB | 872.00 KiB/s, done.
Resolving deltas: 100% (1375/1375), done.
Checking connectivity... done.
You are not currently on a branch. Please specify which
branch you want to merge with. See git-pull(1) for details.

    git pull <remote> <branch>

Cloning into 'elm-repl'...
remote: Counting objects: 900, done.
remote: Total 900 (delta 0), reused 0 (delta 0), pack-reused 900
Receiving objects: 100% (900/900), 155.92 KiB | 0 bytes/s, done.
Resolving deltas: 100% (558/558), done.
Checking connectivity... done.
You are not currently on a branch. Please specify which
branch you want to merge with. See git-pull(1) for details.

    git pull <remote> <branch>

Writing a default package environment file to
/home/teddy/Programy/Elm-Platform/0.15.1/cabal.sandbox.config
Creating a new sandbox at
/home/teddy/Programy/Elm-Platform/0.15.1/.cabal-sandbox
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: elm-compiler-0.15.1 (user goal)
next goal: union-find (dependency of elm-compiler-0.15.1)
Dependency tree exhaustively searched.

Note: when using a sandbox, all packages are required to have consistent
dependencies. Try reinstalling/unregistering the offending packages or
recreating the sandbox.
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: elm-compiler-0.15.1 (user goal)
next goal: union-find (dependency of elm-compiler-0.15.1)
Dependency tree exhaustively searched.

Note: when using a sandbox, all packages are required to have consistent
dependencies. Try reinstalling/unregistering the offending packages or
recreating the sandbox.
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: elm-reactor-0.3.2 (user goal)
next goal: websockets-snap (dependency of elm-reactor-0.3.2)
Dependency tree exhaustively searched.

Note: when using a sandbox, all packages are required to have consistent
dependencies. Try reinstalling/unregistering the offending packages or
recreating the sandbox.

0.15.1 dir looks the same.

This looks suspicious:

Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.

The BuildFromSource.hs file should do that cabal update call. Without a package list, it's clear that the install will fail.
I'll open a pull request.

Ok cabal update helped. Now I'v got bin dir and alost everything is up and running except elm-reactor. There was some errors while building
Configuring elm-reactor-0.3.2...
Building elm-reactor-0.3.2...
Preprocessing executable 'elm-reactor' for elm-reactor-0.3.2...
[1 of 6] Compiling Paths_elm_reactor ( dist/dist-sandbox-c4f1dabb/build/autogen/Paths_elm_reactor.hs, dist/dist-sandbox-c4f1dabb/build/elm-reactor/elm-reactor-tmp/Paths_elm_reactor.o )
[2 of 6] Compiling Utils            ( backend/Utils.hs, dist/dist-sandbox-c4f1dabb/build/elm-reactor/elm-reactor-tmp/Utils.o )
[3 of 6] Compiling Compile          ( backend/Compile.hs, dist/dist-sandbox-c4f1dabb/build/elm-reactor/elm-reactor-tmp/Compile.o )

backend/Compile.hs:5:1: Warning:
    The import of ‘Control.Applicative’ is redundant
      except perhaps to import instances from ‘Control.Applicative’
    To import instances alone, use: import Control.Applicative()
[4 of 6] Compiling Socket           ( backend/Socket.hs, dist/dist-sandbox-c4f1dabb/build/elm-reactor/elm-reactor-tmp/Socket.o )

backend/Socket.hs:21:64:
    Couldn't match type ‘[Char]’ with ‘FP.FilePath’
    Expected type: FilePath -> IO ()
      Actual type: FP.FilePath -> IO ()
    In the fourth argument of ‘NDevel.treeExtExists’, namely
      ‘(sendHotSwap watchedFile connection)’
    In a stmt of a 'do' block:
      _ <- NDevel.treeExtExists
             notifyManager "." "elm" (sendHotSwap watchedFile connection)
cabal: Error: some packages failed to install:
elm-reactor-0.3.2 failed during the building phase. The exception was:
ExitFailure 1

Ah, I've seen this as well. The reason is that the elm-reactor version corresponding to 0.15.1 doesn't have this commit, but also has no upper bound on the relevant library.
So what you need to do is go into the elm-reactor directory, open the elm-reactor.cabal file, and replace the line fsnotify >= <IP_ADDRESS> by fsnotify >= <IP_ADDRESS> && < 0.2. Then try again. Where by "try again" I do not mean the whole BuildFromSource.hs run, but only (from the directory above elm-reactor): cabal install -j --bindir=../bin elm-reactor.
(Leave out the --bindir=../bin part if you have used a BuildFromSource.hs already incorporating my change from #66.)

Thank you for assistance! I'v got Elm 0.15.1 build and running :) Time to mess around with it. Not sure If I should close this issue?

Cool!
Yes, I think just close the issue.

@jvoigtlaender, I was thinking it'd make sense to add a --constrain=fsnotify==<IP_ADDRESS> to the build script because I think this will get lots of people now. I think it actually will be "backwards compatible" in the sense that older versions will either use it or not care. If it makes sense, would you mind doing a PR?

I am running into this issue with elm-lang/elm-reactor@444a57b3ab520ccc9e20499cde84334cb219c446 and elm-lang/elm-package@613c6022cec0ec49687c38f11dde0f76ac9fac9b.  fsnotify 0.2.1 is installed.  The error message is exactly the same, though.  Nothing changes if I attempt to apply @jvoigtlaender's advice by forcing fsnotify to 0.2.0 in the elm-reactor.cabal file and run cabl install.
lap% runhaskell BuildFromSource.hs 0.16
Cloning into 'elm-compiler'...
remote: Counting objects: 22357, done.
remote: Compressing objects: 100% (49/49), done.
remote: Total 22357 (delta 15), reused 0 (delta 0), pack-reused 22308
Receiving objects: 100% (22357/22357), 6.35 MiB | 1.66 MiB/s, done.
Resolving deltas: 100% (13347/13347), done.
Checking connectivity... done.
Cloning into 'elm-package'...
remote: Counting objects: 3367, done.
remote: Total 3367 (delta 0), reused 0 (delta 0), pack-reused 3367
Receiving objects: 100% (3367/3367), 618.44 KiB | 858.00 KiB/s, done.
Resolving deltas: 100% (2002/2002), done.
Checking connectivity... done.
Cloning into 'elm-make'...
remote: Counting objects: 955, done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 955 (delta 3), reused 0 (delta 0), pack-reused 945
Receiving objects: 100% (955/955), 216.19 KiB | 0 bytes/s, done.
Resolving deltas: 100% (610/610), done.
Checking connectivity... done.
Cloning into 'elm-reactor'...
remote: Counting objects: 2908, done.
remote: Compressing objects: 100% (212/212), done.
remote: Total 2908 (delta 105), reused 0 (delta 0), pack-reused 2695
Receiving objects: 100% (2908/2908), 1.74 MiB | 1.72 MiB/s, done.
Resolving deltas: 100% (1695/1695), done.
Checking connectivity... done.
Cloning into 'elm-repl'...
remote: Counting objects: 920, done.
remote: Total 920 (delta 0), reused 0 (delta 0), pack-reused 920
Receiving objects: 100% (920/920), 159.37 KiB | 0 bytes/s, done.
Resolving deltas: 100% (570/570), done.
Checking connectivity... done.
Downloading the latest package list from hackage.haskell.org
cabal: unrecognised command: sandbox (try --help)
cabal: unrecognised command: sandbox (try --help)
Resolving dependencies...
All the requested packages are already installed:
Use --reinstall if you want to reinstall anyway.
Resolving dependencies...
Configuring elm-make-0.1.2...
Configuring elm-repl-0.4.1...
Building elm-repl-0.4.1...
Building elm-make-0.1.2...
Installed elm-repl-0.4.1
Installed elm-make-0.1.2
Resolving dependencies...
Configuring elm-reactor-0.3.1...
Building elm-reactor-0.3.1...
Failed to install elm-reactor-0.3.1
Last 10 lines of the build log (
/home/coventry/.cabal/logs/elm-reactor-0.3.1.log ):
backend/Socket.hs:21:64:
Couldn't match type `FP.FilePath' with `[Char]'
Expected type: FilePath -> IO ()
Actual type: FP.FilePath -> IO ()
In the return type of a call of `sendHotSwap'
In the fourth argument of `NDevel.treeExtExists', namely
`(sendHotSwap watchedFile connection)'
In a stmt of a 'do' block:
_ <- NDevel.treeExtExists
notifyManager "." "elm" (sendHotSwap watchedFile connection)
cabal: Error: some packages failed to install:
elm-reactor-0.3.1 failed during the building phase. The exception was:
ExitFailure 1

Oh, I thought I would re-open this issue by commenting on it.  I will start a new issue.


Add constructors to the main objects that can accept a HashAlgorithm

It would be nice if the all the main objects that have a HashAlgorithm set could have that algorithm set at instantiation-time rather than an extra call to SetHash()

Hi @mattlorimor, are you still interested in this change?  If so, I could give it a shot, but I would have some questions.
Would you be okay with leaving the existing constructors, and adding new constructors that include the hash as the last argument?  For BloomFilter, that would look something like this:
public BloomFilter(uint n, double fpRate) :
    this(n, fpRate, Defaults.GetDefaultHashAlgorithm())
{
}

public BloomFilter(uint n, double fpRate, HashAlgorithm hash)
{
    var m = Utils.OptimalM(n, fpRate);
    var k = Utils.OptimalK(fpRate);
    Buckets = new Buckets(m, 1);
    this.Hash = hash;
    this.m = m;
    this.k = k;
}

Another option would be to have one constructor, but make the hash default to null and have null mean "default"; e.g.,
public BloomFilter(uint n, double fpRate, HashAlgorithm hash = null)
{
    var m = Utils.OptimalM(n, fpRate);
    var k = Utils.OptimalK(fpRate);
    Buckets = new Buckets(m, 1);
    this.Hash = hash ?? Defaults.GetDefaultHashAlgorithm();
    this.m = m;
    this.k = k;
}

My personal preference would be for the two constructor approach, but either way is fine.
Would you be okay with actually removing the SetHash() functions entirely?  That would be my vote.  If you wanted to keep the SetHash() methods, I would suggest that we change them to throw an exception if any data has already been added to the collection, since changing the hash function at that time must be a mistake.


How to read data from exception?

my server response gives me very usefull data on error, (non 200~ states)
for example, on 401 error, my response holds error message and data to show as dialog.
but dio handles it as simple error, i cannot event cast the error. e as DioError -> DioError is not a valid type.
how do i still get the response on exception handling or event not handle as a excetpion?
but returning as a valid response from dio side, wrapped with higher object containing the success or error data.

Any updates on this?

@wendux any plans for supporting this as-a-feature?

@wendux


copr: table scan ignores point get while encounter common handle

Signed-off-by: Iosmanthus Teng<EMAIL_ADDRESS>What problem does this PR solve?
BatchTableScanExecutor ignores point get while encounter common handles keys.
Check List
Tests

Unit test
Integration test

Release note

BatchTableScanExecutor ignores point get while encountering common handle keys.

LGTM

/merge

LGTM

/merge


reindex into omnibus 2

Move reindex script into priv/ instead of rel/.
have reindex script ask erchef for the correct version to run via rpc
add function to oc_erchef_app to request version.

ping @chef/lob

:+1: Thanks! Is oc_erchef_app the best place for this? My only other thought would be in chef_wm_util.

I figured version was global enough (not really just wm) that it made sense at the highest level.

@marcparadise that works for me.


Subscribe to entity state changes

This PR adds an ability to create subscriptions to Spine entity changes.
The subscription is created using BackendClient#subscribeToEntities({ofType, byId}) method.
A new subscription to all Task entities would look as follows:
backendClient.subscribeToEntities({ofType: taskType})
  .then(({itemAdded, itemChanged, itemRemoved, unsubscribe}) => {
    itemAdded.subscribe({
      next: task => console.log(task);
    });
    setTimeout(() => unsubscribe(), 10 * SECONDS);
  });

This subscription is stopped in 10 seconds.
On the backend the subscriptions are implemented to run in the App Engine requests, updating Firebase data by querying data from Spine on keep-up requests.

@armiol PTAL


Problem on Windows 7 (still claims to require win32-open3 w/ 1.9.2)

I'm running into a problem on Windows 7 x64, where the github gem claims to require win32-open3 even though this functionality (I think?) is baked into ruby 1.9.2.
I tried installing a work-around I found via Google, win32-open3-19, but then got the following error trace when trying to run 'gh create-from-local':
C:/RubyOnRails/Ruby1.9.2/lib/ruby/1.9.1/open3.rb:202:in spawn': No such file or directory - pwd (Errno::ENOENT)         from C:/RubyOnRails/Ruby1.9.2/lib/ruby/1.9.1/open3.rb:202:in popen_run'
from C:/RubyOnRails/Ruby1.9.2/lib/ruby/1.9.1/open3.rb:90:in popen3'         from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github/command.rb:127:in run'
from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github/command.rb:61:in sh'         from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/commands/commands.rb:242:in block in load'
from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github/command.rb:25:in call'         from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github.rb:76:in invoke'
from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github.rb:70:in activate'         from C:/RubyOnRails/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/bin/gh:8:in <top (required)>'
from C:/RubyOnRails/Ruby1.9.2/bin/gh:19:in load'         from C:/RubyOnRails/Ruby1.9.2/bin/gh:19:in '

I believe I am getting the same problem, with a fresh install using latest Railsinstaller on Windows 7
C:\Sites\sciteachplan>gh --help
You must 'gem install win32-open3' to use the github command on Windows
C:\Sites\sciteachplan>gem install win32-open3
ERROR:  Error installing win32-open3:
win32-open3 requires Ruby version < 1.9.0.
On the suggestion above, installing win32-open3-19 initially works to get the help menu up.
C:\Sites\sciteachplan>gem install "win32-open3-19"
Fetching: win32-open3-19-0.0.1.gem (100%)
Successfully installed win32-open3-19-0.0.1
1 gem installed
Installing ri documentation for win32-open3-19-0.0.1...
Installing RDoc documentation for win32-open3-19-0.0.1...
C:\Sites\sciteachplan>gh --help
Usage: github command
Available commands:
....
But then when building local I get the following:
C:\Sites\sciteachplan>gh create-from-local
Please enter your GitHub credentials:
Username: polymatter
Your account token is at https://github.com/account under 'Account Admin'.
Press Enter to launch page in browser.
Token:
C:/RailsInstaller/Ruby1.9.2/lib/ruby/1.9.1/open3.rb:202:in 'spawn': No such file or directory - curl -F 'repository[name]=sciteachplan' -F 'repository[public]=true' -F 'login='polymatter'' -F 'token='' https://github.com/repositories (Errno::ENOENT)
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/1.9.1/open3.rb:202:in 'popen_run'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/1.9.1/open3.rb:90:in 'popen3'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github/command.rb:127:in 'run'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github/command.rb:61:in 'sh'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/commands/commands.rb:246:in 'block in load'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github/command.rb:25:in 'call'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github.rb:76:in 'invoke'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/lib/github.rb:70:in 'activate'
from C:/RailsInstaller/Ruby1.9.2/lib/ruby/gems/1.9.1/gems/github-0.6.2/bin/gh:8:in '<top (required)>'
from C:/RailsInstaller/Ruby1.9.2/bin/gh:19:in 'load'
from C:/RailsInstaller/Ruby1.9.2/bin/gh:19:in '<main>'
some of the formatting went a bit weird with the error above, and I thought it would be useful to indicate this occured with vanilla railsinstaller on windows.

still open?

I have the same issue. Any ideas?

please fix this!

get the same issue !

same issue, please fix...

Same issue here

Same problem.

Same issue here. Help would be greatly appreciated.

Same issue

+1 on this

same issue

same issue

same problem here....

Same here.

same here... :(

potential fix for people using http://railsinstaller.org/ (tested on win7)
/get latest version (install it)
/click start(windows start button )> all programs > railsinstaller > command prompt with ruby n rails (launch it)
/go in to an app directory by typing commands in console you just opened ex "rails new app_name" then switch to directory "cd app_name" make sure to type commands in without the quote marks "<this "<and this
/git comes pre installed with railsinstaller soooooo just type in "git init" command should work blah blah...
or
http://railsinstaller.org < watch video here on main page 3 to 4 mins in he does the git setup (easy peesyyy lemon squeezy wtf?? right??)
if it worked! drum roll please hfksjfhdkj because you have just been helped by a noob :) booyahh (put a "b" instead of a "n" in noob LOLL get it??)
cheeriooo

potential fix for people using http://railsinstaller.org/ (tested on win7)
/get latest version (install it)
/click start(windows start button )> all programs > railsinstaller > command prompt with ruby n rails (launch it)
/go in to an app directory by typing commands in console you just opened ex "rails new app_name" then switch to directory "cd app_name" make sure to type commands in without the quote marks "<this "<and this
/git comes pre installed with railsinstaller soooooo just type in "git init" command should work blah blah...
or
http://railsinstaller.org < watch video here on main page 3 to 4 mins in he does the git setup (easy peesyyy lemon squeezy wtf?? right??)
if it worked! drum roll please hfksjfhdkj because you have just been helped by a noob :) booyahh (put a "b" instead of a "n" in noob LOLL get it??)
cheeriooo

Scott, this sucks!
$ ruby --version
ruby 1.9.3p0 (2011-10-30) [i386-mingw32]

$ gh
You must 'gem install win32-open3' to use the github command on Windows

$ gem install win32-open3
Fetching: win32-open3-0.3.2-x86-mingw32.gem (100%)
ERROR:  Error installing win32-open3:
        win32-open3 requires Ruby version < 1.9.0.

Still the same Problem,
Any fix-up guys !!!


Make ExternalCommitHelper robust on Windows

Starting with Core 3.0 we have a robust interprocess mutex and condition variable implementation on Windows we can use to reliably notify interested parties of commits at the Object Store level.
The implementation heavily borrows from SharedGroup::wait_for_change(). In fact, I believe the generic ExternalCommitHelper implementation should perform equally well on Windows - we’d be using it instead of this one if it only worked with synced realms.

@finnschiermer I think you could review this better


User Personas Pitch Section

Task

Refine the user personas which the team came up with together and write up one for each user discussed

Deliverables

User personas section on pitch document

User personas section completed and includes thorough user stories for each user persona which display problems and needs in clear and concise fashion.


TNBC Treasure Hunt - Draft Mechanism for Puzzles - 1

Link to original project proposal.
https://github.com/thenewboston-developers/Projects/issues/190
Link to most recent milestone payout request.
N/A (First Milestone)
Milestone Description
Draft Mechanism for Puzzles

#
Objective
How can auditors verify milestone?

1
Draft Mechanism for Puzzles
https://wakawakatnbc.notion.site/Milestone-1-Draft-Mechanism-78a38a0c045245dc883cb531ee4e33db

How long do you estimate this milestone will take to complete?
Completed
Project Wallet
f3ea9046c5aa60ab16775989f9e81b6559ad7100f9f441739e375538d394a6ff

@wakawakathedev, approved.


Additive drawing: Sometimes flickers

On my device, there is something flickering with additive drawing. See this video:

Device: Sony Xperia Z1 Compact
Android: 5.1
Tangram-ES: 0.9.0
Map style used: streetcomplete-dark-style

My hypothesis for the flickering here is that it's a z-fighting effect caused by building features from multiple tiles overlapping. At some points when Tangram ES is loading tiles, a placeholder tile from another zoom level will be drawn to cover the area of a tile that's not yet loaded. The placeholder can also overlap with tiles that are currently loaded and draw simultaneously with them. This state is temporary and usually not too noticeable, but in this particular instance it's quite visible.
I'd suggest trying the translucent blending option instead of add. The translucent option should provide better resolution of polygons by depth.

This state is temporary

Tested a bit more.

The state is not temporary, but occurs for those buildings with zero height only in certain zoom ranges. Probably, within these ranges, the same buildings are rendered twice(?)
does not occur for normal simple buildings with a height
does always occur for buildings that are made up of different building part sections. I guess the z-fighting occurs here because the outside wall of buildings is on the same plane than that of the building parts

With translucent, this problem does not occur of course, but I meant to report a bug with add blend mode. It is a different effect, i.e. translucent is not additive.
Perhaps if there are problems with add that cannot likely be solved, the implementation of it could be switched out to be the same as translucent, only additive.

One more test:

For flat buildings, it is only reproducable if the view is tilted
Actually, the general problem is not limited to additive drawing. See video (only reproducable in tilted view, as said):

Hey @westnordost - I've started a branch to handle the walls and depth-buffer/add blend mode issue:
https://github.com/tangrams/tangram-es/pull/1770
If you start to show 3d buildings at source max_zoom (i.e. set source max_zoom to 16) flickering from proxy should also be gone. -- and disable animate unless you need a hand warmer ;)
For the roads: make sure that the layers have a different draw order. Though there is certainly some more z-fighting to fight :)

I'll close this based on the fact that the issue is very old, with a very old version of tangram and the screen records I posted are not available anymore, so I am not sure if this issue still persists. Also, the WIP branch that worked on this issue was deleted.


Introduce ResolverLock, layer on top of low level Named Locks

The resolver lock adds a thin layer above low lever named locks,
does not leak actualy named lock names, but is keyed by artifact,
hence lock ordering is stable (is based on Artifact not on name mapper).
Finally, resolver lock factory is able to spice up the logic for locking
that is now "hacked in" to not alter SyncContextFactory API.
This is EXPERIMENT for testing reasons only.

Post 1.7.0.