Publication of 0.7.0-Alpha

I am trying to pull in the new alpha build but I don't see it on Maven Central. Is there a way to pull it?

Hi,
0.7.0-Alpha is published to the maven central repository
https://mvnrepository.com/artifact/org.jetbrains.kotlinx/kover-gradle-plugin/0.7.0-Alpha
Could you give an example of your project?

plugins {
java
maven-publish
kotlin("multiplatform") apply false
kotlin("android") apply false
kotlin("plugin.serialization") apply false
id("com.android.application") apply false
id("com.android.library") apply false
id("org.jetbrains.compose") apply false
id("org.ajoberstar.grgit") version "4.1.1"
id("nebula.release") version "16.0.0"
id("nebula.maven-publish") version "18.4.0"
id("org.jetbrains.kotlinx.kover") version "0.7.0-Alpha"
id("io.gitlab.arturbosch.detekt").version("1.21.0")
id("io.github.kmbisset89.changelog.plugin") version "1.0.4"
jacoco
}
So this should work correct?

I am getting that I cannot resolve based on your migration page. Please let me know what I am incorrectly doing.

All of these screen shots are in the main build gradle.

Have you refresh the Gradle model in the IDE?
It looks like you have classes for the previous version displayed in the editor.
e.g. class KoverProjectConfig was renamed to KoverProjectExtension.

Also if kover and jacoco plugins are applied together, then this may lead to an error, see #337

I have restarted many times and wiped away caches. I just removed jacoco but cannot get the Kover Project Config to go away.

Still no luck

Classpath changed I see

Try this solution

This is now resolved by updating the class path and dealing with jacoco


Swap nodes in pair

Given a linked list, swap every two adjacent nodes and return its head. You must solve the problem without modifying the values in the list's nodes (i.e., only nodes themselves may be changed.)

Congratulations for your Open source contribution. Don't forget to add a star on this repo.. Happy hacking


Origin not Allowed

Hi! I got this issue regarding the origin.
here's the link to my website. http://issae.codemarketing.com/
how can I fix this?

You should be able to use the player even when you see this issue, as far as I can tell it doesn't affect the rendering of the player itself.


wallet-ext: tokens page locked state

Description

hide actions and token balances from tokens page when the active account is locked
show a login/unlock button to allow the user to unlock the account
allow read access to accounts up to 6 hours after last unlock (probably we should change this)
disable menu navigation when active account is locked

https://github.com/MystenLabs/sui/assets/10210143/ec122181-5abf-4f3d-bdde-e58fda5b9c35
https://github.com/MystenLabs/sui/assets/10210143/02fd064a-3a6f-4932-bfed-f29206182aae
closes APPS-1557
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Great progress!
Making a small observation...when the account is locked the icon should change to the "locked" state in the account card here

Yeah this is not ready yet


Add Correct File Extention to CobolScript

Adding a language
no

[ ] The code displays "Hello World"
[ ] I have updated the readme to include the new language
This adds the correct file extension to CobolScript.

Oh I forgot


"IndustryName" validation causing proxy to discovery endpoints failed

Currently the data recipient's proxy controller expects something like /cds-au/v1/common/status('common' as the industry name), but it should be /cds-au/v1/discovery/status.

Hi @Smoovsky,
Thank you for reaching out and raising this issue. We have logged the issue and will include a fix in a future release.

Hi @Smoovsky ,
Just updating you that this issue has now been fixed in our latest release.
Thanks,
Hansen

Hi @Smoovsky , just letting you know that this has now been fixed in our latest release today.
Thank you.


feat: add event points for spark commands

Description
Closes #8442

add event points pre_command and post_command

Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Added changelog.


Use accessTokens.json from AZURE_CONFIG_DIR before falling back on ~/.azure/

This PR makes AccessTokensPath() use accessTokens.json from the directory configured by the AZURE_CONFIG_DIR environment variable if the AZURE_ACCESS_TOKEN_FILE environment variable is not set before falling back on ~/.azure/.
This matches the behavior of the azure-cli:

https://github.com/Azure/azure-cli/blob/azure-cli-2.0.73/src/azure-cli-core/azure/cli/core/_profile.py#L879
https://github.com/Azure/azure-cli/blob/azure-cli-2.0.73/src/azure-cli-core/azure/cli/core/_environment.py#L9

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:

[x] I've tested my changes, adding unit tests if applicable.
[ ] I've added Apache 2.0 Headers to the top of any new source files.
[x] I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
[ ] If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: pdecat sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

FWIW, this change was tested in the context of the terraform kubernetes provider.
The only backward incompatibility is if someone:

defines AWS_CONFIG_DIR to a custom location different from ~/.azure/,
leaves AZURE_ACCESS_TOKEN_FILE unset,
and still expects tokens to be loaded from ~/.azure/accessTokens.json, and not from an accessTokens.json in AWS_CONFIG_DIR.

Hi @jhendrixMSFT, thanks for the review and merge!
This PR was submitted to dev as instructed in the pull request template.
I noticed you tagged a new version from master shortly after the merge, and it does not include this change.
Is dev planned to be merged into master soon?
Or should I have targeted master directly instead?


Fix card height and layout of UNPUBLISHED and NOT APPROVED labels

UNPUBLISHED and NOT APPROVED labels push card height. We want to:

reduce the font sice of the UNPUBLISHED and NOT APPROVED labels
reduce the margin between title and UNPUBLISHED and NOT APPROVED labels
fix the card height, to avoid the labels pushing it

@giohappy we may have to introduce a scroll when the content overflows the height in order not to cut elements when they go beyond the height.

Another approach could be that we increase the height for all resource cards to accommodate the possible space which label element may take up if present.
@allyoucanmap

@DavidQuartz I'm in favor of using the simplest solution: a single fa-circle-info icon in the position you're showing, but with warning (orange) background. Hovering the icon will show the message "This resource is unpublished (and not) approved".
Of course if the icon is visilbe the title will be restricted horizontally to not overlap with the icon.


develop > master PR

Changes Unknown when pulling 2ed24480b0630cdaacd1e55dd4b4c5ce5237123e on development into ** on master**.

Changes Unknown when pulling c4eac792f7308540ff94fc0ddf9253381bc2d2d8 on development into ** on master**.


Add extraData to transfers

In Paymnet.ts, we need to add the option for user to specify extraData on preparing a TL payment.
We should also add this to getPath since it returns the gas estimation for the transaction using this path and this should depend on the (size of) extraData even though it feels odd.
See: https://github.com/trustlines-protocol/relay/blob/d2b44ac488341b4d7ebfaffd4f5d9c905da07b5c/docs/RelayAPI.md#transfer-path-in-currency-network

Maybe we can improve on the naming of getPath


ref #761: Revert (workaround) breaking interface change

Q
A

Branch
7.1.x

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed issues
chameleon-system/chameleon-system#761

License
MIT

:+1:

Can you fix the three psalm errors? After that I'll happily merge it.


Visual Studio 2017 support

Is your feature request related to a problem? Please describe.
There are no related problems
Describe the solution you'd like
Update from VS2015 to VS2017
Describe alternatives you've considered
Understand if VS2017 clang works well or better use MSVC toolkit
OS and backend
This is related to windows OS.

I have been using VS2017 with Filament without much issues so far, what in particular is this issue about?
Is it about the pre-built packages?

I mean compile filament using clang vs2017 not about usage

Yes, but that is already working... I am compiling filament using clang-cl and VS2017, using the instructions found on the main page.

Our instructions use Visual Studio 2015 because that's what our CI environment offers. According to @shartte it works in Visual Studio 2017 as well (which makes sense, we don't use anything VS specific I believe). Please open a new bug with more specific information if it doesn't work in VS 2017. Thanks!

Okay, thank you!


Choose variant color preview format

Currently we default the variant color preview as HEX, user should be able to choose which color format they want from a list of options:

HEX
HSL
RGB

For now let's just add a <Select> with the 3 options on the top nav.
And let's keep HEX as the default value.


x/build: linux-arm-arm5spacemonkey persistently broken

The linux-arm-arm5spacemonkey builder has been broken for as far back as I dared to page through the logs. It seems to be the only all-red (#22689) builder in the “first-class ports” view (#27689).
As far as I can tell, it's a configuration issue: for some reason the builder sets the Go version to builder host-linux-armel-cross instead of a more realistic version string, and that somehow causes the API check to fail.
See previously #28041. (CC @bradfitz, @onionjake, @zeebo, @dmitshur )
Sample: https://build.golang.org/log/32dafc31f49b66f75902acd5f0d61cb8f6277de6

:: Running /bin/bash with args ["/bin/bash" "-c" "cd $WORKDIR/go/src && ./make.bash && cd .. && mv bin/*_*/* bin && rmdir bin/*_* && rm -rf pkg/linux_amd64 pkg/tool/linux_amd64 pkg/bootstrap pkg/obj"] and env ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-armel-cross-rn8aed9e5" "IN_KUBERNETES=1" "META_BUILDLET_BINARY_URL=http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64" "META_BUILDLET_HOST_TYPE=host-linux-armel-cross" "KUBERNETES_PORT_443_TCP_PORT=443" "KUBERNETES_PORT_443_TCP_ADDR=<IP_ADDRESS>" "KUBERNETES_SERVICE_HOST=<IP_ADDRESS>" "KUBERNETES_SERVICE_PORT=443" "KUBERNETES_SERVICE_PORT_HTTPS=443" "KUBERNETES_PORT=tcp://<IP_ADDRESS>:443" "KUBERNETES_PORT_443_TCP=tcp://<IP_ADDRESS>:443" "KUBERNETES_PORT_443_TCP_PROTO=tcp" "DEBIAN_FRONTEND=noninteractive" "GOROOT_BOOTSTRAP=/go1.4" "GOOS=linux" "GOARCH=arm" "CC_FOR_TARGET=arm-linux-gnueabi-gcc" "HOME=/root" "WORKDIR=/tmp/workdir" "CGO_ENABLED=1" "GOARM=5"] in dir /tmp/workdir

Building Go cmd/dist using /go1.4.
warning: changing VERSION from "devel 552d7b918697e0a5ab1ff22f91abf3e1cfde2e1d" to "builder host-linux-armel-cross"
Building Go toolchain1 using /go1.4.
warning: changing VERSION from "devel 552d7b918697e0a5ab1ff22f91abf3e1cfde2e1d" to "builder host-linux-armel-cross"
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
warning: changing VERSION from "devel 552d7b918697e0a5ab1ff22f91abf3e1cfde2e1d" to "builder host-linux-armel-cross"
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for host, linux/amd64.
Building packages and commands for target, linux/arm.
[…]
##### API check
Error running API checker: exit status 1
Go version is "builder host-linux-armel-cross", ignoring -next /home/builder/stage0scratch/workdir/go/api/next.txt
+pkg bytes, func ReplaceAll([]uint8, []uint8, []uint8) []uint8
[…]
+pkg syscall, type RawSockaddrUnix struct
exit status 1
2018/11/26 19:20:01 Failed: exit status 1
2018/11/26 19:20:07 FAILED

For the record, if I remembered correctly, that builder is special in that it does cross compilation. The toolchain and the standard library is built on AMD64 machine(s) then shipped to the ARMv5 machine(s) to run the tests. When @rsc implemented the build cache, it would never work in this setting (failure was probably toolchain2 and toolchain3 were different). (And it is not possible to run everything on the ARMv5 machine because it is too slow.) So we decided to set up a toolchain version, to bypass certain checks.

Seems like a duplicate of #24754, initially titled cmd/api: failing on linux-arm builder due to non-devel Go version. Now it has a title for a proposed fix, as far as I understand.

I'm happy to help if there is something we can do on the builders to make this easier.

Is this resolved now?  Or is this timeout issue masking it?
This is from one of the latest test runs (https://build.golang.org/log/5137b5ef408a5c5a56d13ae902fe833f501d1e12):
Test "cgo_test" ran over 20m0s limit (20m0.040245806s)

This builder is still persistently broken. Now it appears to be ignoring the next file in the API check.
From https://build.golang.org/log/4728fbb67eb490e9f3df8c5553e16c14fc7cfaf2:
##### API check
Error running API checker: exit status 1
Go version is "builder host-linux-armel-cross", ignoring -next /home/builder/stage0scratch/workdir/go/api/next.txt
+pkg errors, func As(error, interface{}) bool
+pkg errors, func Caller(int) Frame
+pkg errors, func Is(error, error) bool
+pkg errors, func Opaque(error) error
+pkg errors, func Unwrap(error) error
+pkg errors, method (Frame) Format(Printer)
+pkg errors, type Formatter interface { Error, FormatError }
+pkg errors, type Formatter interface, Error() string
+pkg errors, type Formatter interface, FormatError(Printer) error
+pkg errors, type Frame struct
+pkg errors, type Printer interface { Detail, Print, Printf }
+pkg errors, type Printer interface, Detail() bool
+pkg errors, type Printer interface, Print(...interface{})
+pkg errors, type Printer interface, Printf(string, ...interface{})
+pkg errors, type Wrapper interface { Unwrap }
+pkg errors, type Wrapper interface, Unwrap() error
+pkg text/scanner, const AllowNumberbars = 1024
+pkg text/scanner, const AllowNumberbars ideal-int
+pkg text/scanner, const GoTokens = 2036
exit status 1

@bcmills #24754 talks precisely about the API check and how the version name in that builder makes the test fail. So I still think this is a duplicate.

Agreed. Also #24789.


Add FCM API tests

Short description
Add sent push news to the test data and tests for the fcm API endpoint.

You could even add a push notification, which has not been sent yet, to the test data to make sure these news are not contained in the API result.

Good idea. I amended the commit.


Docker build for iOS target sometime freeze on UnityShaderCompilation

We have a CI setup on which we build our projects for android, ios and webgl. IOS builds sometimes freeze when building and never continue. Inside docker container there is many UnityShaderCompilation processes that use 0% cpu and last log from Unity says "Launched and connected shader compiler UnityShaderCompiler after 0.03 seconds".
Version: 2020.3.40f1-ios-1.0.1

Is this a bug related to GameCI? Is it related to the documentation?
Without using the proper bug report format and reporting to the relevant repository we can't really do much. It's unclear what exactly isn't working (and which component is causing it) and it's not clear what you expect the community to do about it.
I'm inclined to close this as invalid.

No trouble at all 🙂


Feedback command

Discuss: a feedback command that allows the player to send feedback (to whom?) in the game.
A first simple version could send an e-mail to me<EMAIL_ADDRESS>but that does not look right. Having a server that could get these messages and update a static page with them would be neat.

@narcolytic what are your thoughts on Twitter integration? So the player could log in and tweet feedback. Possibly with a SS, I suppose.

@neurolytic what are your thoughts on Twitter integration? So the player could log in and tweet feedback. Possibly with a SS, I suppose.

As someone who doesn't use Twitter, I'm not sure. Tweets go out to everyone who follows you, right? You can't 'send a tweet' to someone? So anyone who sends feedback to us would be broadcasting that to everyone they know/the public? That could actually be a clever way of spreading awareness of the game, but would rely on the screenshots being fairly compelling--which honestly is probably hard to do with a text adventure, though I'm sure it's possible.

I agree on the SS part. It'd be a tweet that mentioned us (maybe the game itself gets a profile that I get to manage or I just use mine) so that we would be notified whenever someone sent any kind of feedback.
This could also open doors to trolling and vandalism, which sure would be a problem.

Closed as this is not worth the hassle. At least not for now.


Istiod to issue certificate to a remote cluster

Describe the feature request
Istiod needs to be able to issue certificate to workloads in a remote cluster. This enables using a single istiod for multiple clusters.
Describe alternatives you've considered
Deploying istiod in the remote cluster.
Additional context

@myidpt Would need hand holding for sure, can you provide more details in the issue on what is exactly needed?

@linsun @myidpt THis is exactly what https://github.com/istio/istio/pull/22384 aimed to do. I am waiting further review now.

@irisdingbj can you elaborate how #22384 would cover this?  I took a quick look and it is not obvious as #22384 seems to plugin existing cert which we already do share the same root cert for shared control plane multicluster model.

@myidpt What is the gap now? Can't istio-agent within remote cluster communicate with istiod in the primary cluster?

with the change in #22384, we will generate root cert and two intermidiate CA cert for use of multi-cluster and VM.:
eg: istioctl manifest apply --cert-dir=/etc/certs if /etc/certs is empty it will generate root cert and two intermidate CA key and certs and save them under /etc/certs .   If /etc/certs have related root cert, ca cert and key already, will use it as the same behaviour  described in https://istio.io/docs/tasks/security/plugin-ca-cert/

Any help on the implementation from the community is greatly appreciated. Otherwise it's risky to get this delivered in 1.6.
The implementation needs to touch istiod, enabling it to authenticate the JWTs from external clusters.
Currently the authentication is done by:
https://github.com/istio/istio/blob/1d3b136325a5592511f72a9b041ea396bdbd5180/security/pkg/k8s/tokenreview/k8sauthn.go#L135
The API server address is defined here:
https://github.com/istio/istio/blob/1d3b136325a5592511f72a9b041ea396bdbd5180/security/pkg/server/ca/server.go#L43
So it validates the JWT by calling the TokenReview API on the local cluster.
We need to enable it to be able to call the apiserver on a remote cluster.
I believe today, with shared control plane setup, istiod is able to access the resources from other clusters. We can do the same for the TokenReview feature.

@irisdingbj It seems your PR is trying to build multi-level PKI - it's another angle to solve the multicluster PKI problem.
This issue is focusing on using a single CA to issue certs for workloads in multiple clusters.

@myidpt thanks, I think I got it at a high level.  Basically the main cluster has access to remote cluster via the secret (e.g. istio-remote-secret-remote0 ).  When istio-agent in remote cluster calls the main cluster to authenticate the JTW token used for CSR, the main cluster's istiod need to use that secret (e.g. istio-remote-secret-remote0) to call the remote cluster's API server to validate if the JWT token is valid.  If it is valid, then grant the CSR thus the certificates can be issued to istio-agent at remote cluster.
Please let me know if this aligns what you think.
cc @GregHanson

@linsun Yes, that's correct.

Very clear, so it seems a simple fix can achieve that

@hzxuzhonghu Hey Zhonghu, are you going to help on this? :)

@myidpt thank you!  I talked to @GregHanson he is interested in helping out.  @irisdingbj is also interested to help.  I'm going to remove community help needed.   Would appreciate @myidpt and @hzxuzhonghu's help for review.

@irisdingbj It seems your PR is trying to build multi-level PKI - it's another angle to solve the multicluster PKI problem.
This issue is focusing on using a single CA to issue certs to workloads in multiple clusters.

Thanks! clear to me now.

Thank you everyone.

Hey @irisdingbj we need to add this approach to the multi-cluster setup UG. Can you send me your Email address so that I can add you as an editor to a doc we are working on?

@myidpt both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>works

Thanks. Added you to the doc editor @irisdingbj

@myidpt where can I find the doc you shared? Thanks!

@myidpt I am covering for @irisdingbj while she is on holiday. Please add me to the document<EMAIL_ADDRESS>I need this information for the WG leads meeting tomorrow to address: https://github.com/istio/istio/pull/22384
It is clear to me that this PR is needed. As we punted complete automation of multicluster to 1.7 or later, it is unclear if @irisdingbj 's PR needs a rebase, review, and merge, or not.
Cheers
-steve

Shared with you, Steven. #22384 is a good automation, though the PR itself requires improvements. Making it available in 1.7 makes sense to me.

Closing this now, my thanks to @irisdingbj @hzxuzhonghu @myidpt for the help in delivering/providing consultation to this feature.  I've validated it today (with https://github.com/istio/istio/pull/23942) and it works nicely.


Cross Platform Support and Code Cleanup Pull Request

A rewrite and cleanup of the LibP2PCrypto package.

This includes support for both macOS platforms (using Security and CommonCrypto) and Linux platforms (using CryptoSwift).
Replaced Raw keys with Common protocols
Removed redundant code.
Organized folder structure.
Added a few more tests
Removed unused EC keys

Closes #2


Searching for videos directly on Synctube

I'm not sure if you would consider this out of scope, but I think it would be pretty cool if a user could search for videos through Synctube.
So for example if I typed in a prompt to the add video text box it would search Youtube (or other sources Synctube pulls from) and give a couple of videos in a dropdown to choose from that are close to the prompt.
I bet this would be really nice for mobile users as they wouldn't have to switch apps to get videos since they can't have multiple screens.

This would be a cool idea, but just a search engine for YouTube videos. As much of a plus as possible


⚠ Bofrost.es has degraded performance

In 217c072, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1591 ms

Resolved: Bofrost.es performance has improved in ec522b2 after 6 minutes.


Demonstrate the use of -activateWithCollaboratingAssemblies: in tests

I'm having trouble getting one assembly get a reference to another in a unit test target.

Linked to appsquickly/Typhoon#418


Feature/better docs

Coverage remained the same at 100.0% when pulling 0b53b72a9005648a2f1eecb672232320d49b9c0f on feature/better_docs into ae7d4c04e4f430bd63b6194edea436dde1cb9def on develop.

Coverage remained the same at 100.0% when pulling 89b1425d678c9f9e751c558714fa982c8363c4a6 on feature/better_docs into ae7d4c04e4f430bd63b6194edea436dde1cb9def on develop.

Coverage remained the same at 100.0% when pulling 3ad09f7d0e32179ab7912d8f7203fa91d67a3261 on feature/better_docs into ae7d4c04e4f430bd63b6194edea436dde1cb9def on develop.

Coverage remained the same at 100.0% when pulling 3ad09f7d0e32179ab7912d8f7203fa91d67a3261 on feature/better_docs into ae7d4c04e4f430bd63b6194edea436dde1cb9def on develop.


Change CanaryPhaseProgressing message?

The message around the CanaryPhaseProgressing event is a bit misleading and caused some confusion as we were watching canary events.
https://github.com/weaveworks/flagger/blob/b564a2fda2c44f1aa56bc49eab6b1cd92470b0a1/pkg/canary/status.go#L194
	case flaggerv1.CanaryPhaseProgressing:
		status = corev1.ConditionUnknown
		message = "New revision detected, starting canary analysis."

The "starting canary analysis" looks like it's starting again.
Worth considering changing "started" to "progressing"?

Worth considering changing "started" to "progressing"?

Sounds good, can you please open a PR?

on the way!


refactor(obstacle_stop_planner): remove unnecessary variables and functions, improve code performance

Description

In obstacle_stop_planner, I removed the unused function and variables. Also in some parts, pushPolygon function is called unnecessarily. Also to increase code efficiency, some changes made.
This should be merged after following PRs merged.
https://github.com/autowarefoundation/autoware.universe/pull/3556
https://github.com/autowarefoundation/autoware.universe/pull/3558
Tests performed

Tested in planning simulator and worked well.
Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota Thank you, I will check the issue.


[cli11] Update to 2.3.1

Describe the pull request

What does your PR fix?
Updates cli11 to 2.3.1

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes

Does your PR follow the maintainer guide?

Yes

Thanks for the update!


Remove the tap-highlight-color override

Fixes #19709.
We've long removed the tap highlight, but that takes away from some decent accessibility friendliness. This removes that code so that the highlight is restored to tap targets. It only appears on the tap, disappearing after you release.
/x-ref: https://github.com/necolas/normalize.css/issues/23 where they discuss it's removal in https://github.com/necolas/normalize.css/commit/09be23f8320602edd343e55bbaf4ebc02550b1cc. I'm guessing we just left our implementation intact.

Not had a chance to test, but: how does this affect in-page controls, like dropdown menu triggers? Does it leave them weirdly highlighted? If so, I'd tend to actually say we should leave the suppression as is, OR be very surgical about where we enable it/disable it. Because otherwise these controls may visually suggest to users that they're somehow "toggled" or disabled or whatever, which gets very confusing.


docs: add Cloudflare Docs to showcase

Description
Adds the newly migrated Cloudflare documentation site to showcase.

Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Can't get topicName when the bot is added to the group

Bot Info

SDK Platform:  REST
SDK Version:
Active Channels: Skype
Deployment Environment: local development + Bot Channels Registration

Issue Description
When the bot is added to the group the topicName doesn't come in the request. But when the topicName changes while the bot is already in the group there's a topicName. Is there any way to get topic name when the bot is just added to the group?
Reproduction Steps

Add bot to the group
Change name of the group while bot is in

Expected Behavior
Json that comes to the bot whent it added to the group
{
     "recipient":{
         "name":"BotName",
        "id":"1111111"
     },
     "timestamp":"2018-04-16T08:13:23.27Z",
       "membersAdded":[
        {
               "id":"1111111"
        }
      ],
      "type":"conversationUpdate",
    "serviceUrl":"https://smba.trafficmanager.net/apis/",
       "channelId":"skype",
     "from":{
             "id":"2222222"
     },
     "id":"3333",
       "conversation":{
             "isGroup":true,
             "id":"1243567",
             "topicName": "TestGroup"
       }
}
or (as it come when topic name is changed while the bot is in)
{
...
     "topicName": "TestGroup",
      "conversation":{
            "isGroup":true,
             "id":"1243567"
      }
}
Actual Results
{
...
      "conversation":{
              "isGroup":true,
            "id":"1243567"
     }
}

I will have to double check, but I do not think that data is provided until it is set with the bot in the conversation.

@JasonSowers , but why not? It's clear that the name of the topic isn't under some privacy protection since it available in the request body when someone in the group changes it and bot receives the details of conversation update. So why it has to be unavailable when the bot just joined the group conversation?

My best guess is that it is a deficiency on Skype's end, I haven't had the chance to look into it to give you a more concrete answer.  I will try my best to take a look today.

I asked this back on 2016 in #969. There is also #1175.
Would love to get a update regarding this.

We'll look into adding this field to the skype API in the future.

Thank you for opening an issue against the Bot Framework SDK v3. As part of the Bot Framework v4 release, we’ve moved all v3 work to a new repo located at https://github.com/microsoft/botbuilder-v3. We will continue to support and offer maintenance updates to v3 via this new repo.
From now on, https://github.com/microsoft/botbuilder repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the new Bot Framework v3 repo found here:
https://github.com/microsoft/botbuilder-v3/issues
For Azure Bot Service Channel specific defects or feature requests (e.g. Facebook, Twilio, Teams, Slack, etc.), please create a new issue in the new Bot Framework Channel repo found here:
https://github.com/microsoft/botframework-services/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


Minor fixes on labels for GPIO and PWM LEDs

The first patch fixes/improves the name of a PWM LED device when the label property is missing in its DT node.
And the last two patches fix some minor issues about label properties in the DTS bindings of both GPIO and PWM LEDs (#34275).

@Mani-Sadhasivam I'm not sure why you cleared your assignment since this is an LED PR. Please review.

@Mani-Sadhasivam I'm not sure why you cleared your assignment since this is an LED PR. Please review.

Ah, sorry. I got confused with the PR subject (thought it is the GPIO). Approved now, thanks!


[V2][Multi-site]Fix the case when no site aliases is set

Description
When no site aliases are set, the wrong site is returned. Inside resolveSiteFromUrl logic, siteRef is undefined when we are on the homepage, and when the site alias is also undefined, it happens to return a truthy value, which is wrong.

Types of Changes

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR
-In your app config,  remove site aliases in your retail app config. It should be an empty object

npm start in retail app
Verify that RefArchGlobal is correct site being used when you are in home page. You should also see it in the urls as such `RefArchGlobal/en-US/womens/dresses

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Can we add a test case to ensure the bug doesn't happen again?

Good call 👍 . I've added a test to cover this case


list new website integration on tools page

https://fairinternetreport.com/

Might use our data, but doesn't provide a clear reference page indicating so. Closing.

Might use our data, but doesn't provide a clear reference page indicating so. Closing.


Play sound when output is copied to clipboard

Is your feature request related to a problem? Please describe.
Because I want to continue using full screen to play the game I have to use the clipboard setting to display the information. Right now I have to wait until almost the last second to paste, read, and figure out which prime part to select.
Describe the solution you'd like
To solve this problem of not knowing when the data has been copied to the clipboard can a sound be played? I wouldn't really care what the sound was and it could even be something that is configured in the setting to be a custom file from my hard drive.

Wfinfo already has this exact feature. Make sure the display mode is set to "Light" and it will no longer attempt to spawn in a window but rather fill the clipboard and play a sound.

Humm then can I request to customize the sound? I have never heard it before.

think the sound is hard-coded, but it'll be easy to make it a separate file and let users customize it


[HACKTOBERFEST 2024] - Nano Quiz

[!IMPORTANT]
This issue is part of our 2024 Hacktoberfest initiative. If you are interested in working on this issue, refer to our top-level tasks to see if this issue is claimed, or to claim it if it is not.

This issue is to create the Nano quiz.
The file you should be working on is found in /curriculum/challenges/english/25-front-end-development/quiz-nano.
All quiz questions need to relate to one of these topics:

What is nano?
Commands and shortcuts
CL programs
One of the courses before this quiz is located here. Any commands or topics covered in that course can be used in the quiz. Here's a partial list: opening/editing/saving a file with nano. copy/pasting.

[!CAUTION]
Questions which do not fall under these topics will be rejected.

You are welcome to include code blocks in your questions, but please keep them short (four lines or less).
Please do NOT open a pull request until you have completed all questions. Your quiz should have exactly 20 questions.

Thank you for your interest in contributing. This issue will be opened for contribution when Hacktoberfest starts on October 1st.

[!CAUTION]
Pull requests which are created before October 1st will not be eligible for Hacktoberfest. We appreciate enthusiasm, but encourage you to hold off on contributing to this issue until the event has begun.

If you wish to be notified when this issue is opened for contribution, subscribe to notifications:

This issue is now open
If you would like to work on this issue, please leave a comment so we can assign it to you.
Be sure to read our contributing guidelines.

Hello,I would like to work on this issue.@naomi-lgbt

Hey @BethiPooja,
you are already assigned to different issue - https://github.com/freeCodeCamp/freeCodeCamp/issues/56231.

I'd like to take own this issue.

I'd like to resolve this issue ,@naomi-lgbt , kindly make me a assignee.

@krish2366 this issue has already been assigned, but there are other issues that do not have a contributor yet

This issue has been assigned a contributor. To prevent extraneous notifications, the issue is now locked. If you have any questions, please reach out to me in our Discord community.


Better testing and code + benchmarks

Improved:

[x] Testing
[x] Code syntax
[x] Added Benchmarks

This PR also includes the code improvements from #20, but excluding the thread creation.
When added, the benchmark will help to track the performance of the async schedulers in the future.

Coverage remained the same at 100.0% when pulling 190d76561a524f945ba937bef5e8006eeb0ad2a8 on better-testing-and-code into b4ec8f19546947b97583d07f460b74e81a9eb671 on master.

Coverage remained the same at 100.0% when pulling 190d76561a524f945ba937bef5e8006eeb0ad2a8 on better-testing-and-code into b4ec8f19546947b97583d07f460b74e81a9eb671 on master.

Coverage remained the same at 100.0% when pulling 190d76561a524f945ba937bef5e8006eeb0ad2a8 on better-testing-and-code into b4ec8f19546947b97583d07f460b74e81a9eb671 on master.

Coverage remained the same at 100.0% when pulling 190d76561a524f945ba937bef5e8006eeb0ad2a8 on better-testing-and-code into b4ec8f19546947b97583d07f460b74e81a9eb671 on master.

Coverage remained the same at 100.0% when pulling 190d76561a524f945ba937bef5e8006eeb0ad2a8 on better-testing-and-code into b4ec8f19546947b97583d07f460b74e81a9eb671 on master.

Coverage remained the same at 100.0% when pulling 190d76561a524f945ba937bef5e8006eeb0ad2a8 on better-testing-and-code into b4ec8f19546947b97583d07f460b74e81a9eb671 on master.


Reset password token can't be blank.

Environment

Ruby 2.6.1
Rails 5.2.2
Devise 4.6.1

Current behavior
I can't for the life of me get the reset_password_token to show up in the form. I am unsure if this is a devise issue or a simple_form issue or a rails issue:
Form I changed from hidden to normal text field. As you can see the value is blank even though its in the url:

it's also in the resource object:

here is my view code:

None of my code is particularly strange.
I tested it with a normal rails form and got the code to show up which makes me think maybe its a simple_form issue but I copied the code directly from the simple form generator.

user.rb
devise :database_authenticatable, :registerable, :recoverable, :rememberable, :validatable, :confirmable, :lockable, :timeoutable, :trackable
routes.rb
devise_for :users
resources :users
Expected behavior
I'd expect to see the reset_password_token.

Close in favor https://github.com/plataformatec/simple_form/issues/1642#issuecomment-466397234


Text overflows past the text box size

I am using the latest version of this gem and found that text overflows past the boundaries of the text area bleeding over the html.
if the trix_editor is set to 5 rows and I end up typing more than 5 rows, it will continue but there will not be a scroll bar that appears and the text doesn't respect the boundary set by trix_editor.

Never mind. The issue was related to bootstrap. You can use the form-control class with trix_editor. At least not in the traditional way.


Rewrite the final Substratekittie Runtime

The final Substratekitties runtime was written a long while ago, and really is not the best example of module code.
Things that could be improved:

Using Enumerable Storage Map
Good tests
Generic Types
More private functions to remove redundant code
Smarter ensure checks
Reduce the number of "game" functions to simplify the tutorial
More emphasis with interacting with other modules
Kitty attributes as their own storage item rather than in a struct so that upgrades are easier

@xlc had written his own version of the kitties tutorial which I think goes in the right direction, but may need to be modified so it is easier to teach in a step by step process:
use support::{
	decl_module, decl_storage, decl_event, ensure, StorageValue, StorageMap,
	Parameter, traits::Currency
};
use runtime_primitives::traits::{SimpleArithmetic, Bounded, One, Member};
use parity_codec::{Encode, Decode};
use runtime_io::blake2_128;
use system::ensure_signed;
use rstd::result;
use crate::linked_item::{LinkedList, LinkedItem};

pub trait Trait: system::Trait {
	type Event: From<Event<Self>> + Into<<Self as system::Trait>::Event>;
	type KittyIndex: Parameter + Member + SimpleArithmetic + Bounded + Default + Copy;
	type Currency: Currency<Self::AccountId>;
}

type BalanceOf<T> = <<T as Trait>::Currency as Currency<<T as system::Trait>::AccountId>>::Balance;

#[derive(Encode, Decode)]
pub struct Kitty(pub [u8; 16]);

type KittyLinkedItem<T> = LinkedItem<<T as Trait>::KittyIndex>;
type OwnedKittiesList<T> = LinkedList<OwnedKitties<T>, <T as system::Trait>::AccountId, <T as Trait>::KittyIndex>;

decl_storage! {
	trait Store for Module<T: Trait> as Kitties {
		/// Stores all the kitties, key is the kitty id / index
		pub Kitties get(kitty): map T::KittyIndex => Option<Kitty>;
		/// Stores the total number of kitties. i.e. the next kitty index
		pub KittiesCount get(kitties_count): T::KittyIndex;

		/// Get kitty ownership. Stored in a linked map.
		pub OwnedKitties get(owned_kitties): map (T::AccountId, Option<T::KittyIndex>) => Option<KittyLinkedItem<T>>;

		/// Get kitty owner
		pub KittyOwners get(kitty_owner): map T::KittyIndex => Option<T::AccountId>;

		/// Get kitty price. None means not for sale.
		pub KittyPrices get(kitty_price): map T::KittyIndex => Option<BalanceOf<T>>
	}
}

decl_event!(
	pub enum Event<T> where
		<T as system::Trait>::AccountId,
		<T as Trait>::KittyIndex,
		Balance = BalanceOf<T>,
	{
		/// A kitty is created. (owner, kitty_id)
		Created(AccountId, KittyIndex),
		/// A kitty is transferred. (from, to, kitty_id)
		Transferred(AccountId, AccountId, KittyIndex),
		/// A kitty is available for sale. (owner, kitty_id, price)
		Ask(AccountId, KittyIndex, Option<Balance>),
		/// A kitty is sold. (from, to, kitty_id, price)
		Sold(AccountId, AccountId, KittyIndex, Balance),
	}
);

decl_module! {
	pub struct Module<T: Trait> for enum Call where origin: T::Origin {
		fn deposit_event<T>() = default;

		/// Create a new kitty
		pub fn create(origin) {
			let sender = ensure_signed(origin)?;
			let kitty_id = Self::next_kitty_id()?;

			// Generate a random 128bit value
			let dna = Self::random_value(&sender);

			// Create and store kitty
			let kitty = Kitty(dna);
			Self::insert_kitty(&sender, kitty_id, kitty);

			Self::deposit_event(RawEvent::Created(sender, kitty_id));
		}

		/// Breed kitties
		pub fn breed(origin, kitty_id_1: T::KittyIndex, kitty_id_2: T::KittyIndex) {
			let sender = ensure_signed(origin)?;

			let new_kitty_id = Self::do_breed(&sender, kitty_id_1, kitty_id_2)?;

			Self::deposit_event(RawEvent::Created(sender, new_kitty_id));
		}

		/// Transfer a kitty to new owner
		pub fn transfer(origin, to: T::AccountId, kitty_id: T::KittyIndex) {
			let sender = ensure_signed(origin)?;

			ensure!(<OwnedKitties<T>>::exists(&(sender.clone(), Some(kitty_id))), "Only owner can transfer kitty");

			Self::do_transfer(&sender, &to, kitty_id);

			Self::deposit_event(RawEvent::Transferred(sender, to, kitty_id));
		}

		/// Set a price for a kitty for sale
		/// None to delist the kitty
		pub fn ask(origin, kitty_id: T::KittyIndex, price: Option<BalanceOf<T>>) {
			let sender = ensure_signed(origin)?;

			ensure!(<OwnedKitties<T>>::exists(&(sender.clone(), Some(kitty_id))), "Only owner can set price for kitty");

			if let Some(ref price) = price {
				<KittyPrices<T>>::insert(kitty_id, price);
			} else {
				<KittyPrices<T>>::remove(kitty_id);
			}

			Self::deposit_event(RawEvent::Ask(sender, kitty_id, price));
		}

		/// Buy a kitty with max price willing to pay
		pub fn buy(origin, kitty_id: T::KittyIndex, price: BalanceOf<T>) {
			let sender = ensure_signed(origin)?;

			let owner = Self::kitty_owner(kitty_id);
			ensure!(owner.is_some(), "Kitty does not exist");
			let owner = owner.unwrap();

			let kitty_price = Self::kitty_price(kitty_id);
			ensure!(kitty_price.is_some(), "Kitty not for sale");

			let kitty_price = kitty_price.unwrap();
			ensure!(price >= kitty_price, "Price is too low");

			T::Currency::transfer(&sender, &owner, kitty_price)?;

			<KittyPrices<T>>::remove(kitty_id);

			Self::do_transfer(&owner, &sender, kitty_id);

			Self::deposit_event(RawEvent::Sold(owner, sender, kitty_id, price));
		}
	}
}

fn combine_dna(dna1: u8, dna2: u8, selector: u8) -> u8 {
	((selector & dna1) | (!selector & dna2))
}

impl<T: Trait> Module<T> {
	fn random_value(sender: &T::AccountId) -> [u8; 16] {
		let payload = (<system::Module<T>>::random_seed(), sender, <system::Module<T>>::extrinsic_index(), <system::Module<T>>::block_number());
		payload.using_encoded(blake2_128)
	}

	fn next_kitty_id() -> result::Result<T::KittyIndex, &'static str> {
		let kitty_id = Self::kitties_count();
		if kitty_id == <T::KittyIndex as Bounded>::max_value() {
			return Err("Kitties count overflow");
		}
		Ok(kitty_id)
	}

	fn insert_owned_kitty(owner: &T::AccountId, kitty_id: T::KittyIndex) {
		<OwnedKittiesList<T>>::append(owner, kitty_id);
	}

	fn insert_kitty(owner: &T::AccountId, kitty_id: T::KittyIndex, kitty: Kitty) {
		// Create and store kitty
		<Kitties<T>>::insert(kitty_id, kitty);
		<KittiesCount<T>>::put(kitty_id + One::one());
		<KittyOwners<T>>::insert(kitty_id, owner.clone());

		Self::insert_owned_kitty(owner, kitty_id);
	}

	fn do_breed(sender: &T::AccountId, kitty_id_1: T::KittyIndex, kitty_id_2: T::KittyIndex) -> result::Result<T::KittyIndex, &'static str> {
		let kitty1 = Self::kitty(kitty_id_1);
		let kitty2 = Self::kitty(kitty_id_2);

		ensure!(kitty1.is_some(), "Invalid kitty_id_1");
		ensure!(kitty2.is_some(), "Invalid kitty_id_2");
		ensure!(kitty_id_1 != kitty_id_2, "Needs different parent");
		ensure!(Self::kitty_owner(&kitty_id_1).map(|owner| owner == *sender).unwrap_or(false), "Not onwer of kitty1");
		ensure!(Self::kitty_owner(&kitty_id_2).map(|owner| owner == *sender).unwrap_or(false), "Not owner of kitty2");

		let kitty_id = Self::next_kitty_id()?;

		let kitty1_dna = kitty1.unwrap().0;
		let kitty2_dna = kitty2.unwrap().0;

		// Generate a random 128bit value
		let selector = Self::random_value(&sender);
		let mut new_dna = [0u8; 16];

		// Combine parents and selector to create new kitty
		for i in 0..kitty1_dna.len() {
			new_dna[i] = combine_dna(kitty1_dna[i], kitty2_dna[i], selector[i]);
		}

		Self::insert_kitty(sender, kitty_id, Kitty(new_dna));

		Ok(kitty_id)
	}

	fn do_transfer(from: &T::AccountId, to: &T::AccountId, kitty_id: T::KittyIndex)  {
		<OwnedKittiesList<T>>::remove(&from, kitty_id);
		<OwnedKittiesList<T>>::append(&to, kitty_id);
		<KittyOwners<T>>::insert(kitty_id, to);
	}
}

/// Tests for Kitties module
#[cfg(test)]
mod tests {
	use super::*;

	use runtime_io::with_externalities;
	use primitives::{H256, Blake2Hasher};
	use support::{impl_outer_origin};
	use runtime_primitives::{
		BuildStorage,
		traits::{BlakeTwo256, IdentityLookup},
		testing::{Digest, DigestItem, Header}
	};

	impl_outer_origin! {
		pub enum Origin for Test {}
	}

	// For testing the module, we construct most of a mock runtime. This means
	// first constructing a configuration type (`Test`) which `impl`s each of the
	// configuration traits of modules we want to use.
	#[derive(Clone, Eq, PartialEq, Debug)]
	pub struct Test;
	impl system::Trait for Test {
		type Origin = Origin;
		type Index = u64;
		type BlockNumber = u64;
		type Hash = H256;
		type Hashing = BlakeTwo256;
		type Digest = Digest;
		type AccountId = u64;
		type Lookup = IdentityLookup<Self::AccountId>;
		type Header = Header;
		type Event = ();
		type Log = DigestItem;
	}
	impl balances::Trait for Test {
		type Balance = u32;
		type OnFreeBalanceZero = ();
		type OnNewAccount = ();
		type Event = ();

		type TransactionPayment = ();
		type DustRemoval = ();
		type TransferPayment = ();
	}
	impl Trait for Test {
		type KittyIndex = u32;
		type Currency = balances::Module<Test>;
		type Event = ();
	}
	type KittyModule = Module<Test>;
	type OwnedKittiesTest = OwnedKitties<Test>;

	// This function basically just builds a genesis storage key/value store according to
	// our desired mockup.
	fn new_test_ext() -> runtime_io::TestExternalities<Blake2Hasher> {
		system::GenesisConfig::<Test>::default().build_storage().unwrap().0.into()
	}

	#[test]
	fn owned_kitties_can_append_values() {
		with_externalities(&mut new_test_ext(), || {
			OwnedKittiesList::<Test>::append(&0, 1);

			assert_eq!(OwnedKittiesTest::get(&(0, None)), Some(KittyLinkedItem::<Test> {
				prev: Some(1),
				next: Some(1),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(1))), Some(KittyLinkedItem::<Test> {
				prev: None,
				next: None,
			}));

			OwnedKittiesList::<Test>::append(&0, 2);

			assert_eq!(OwnedKittiesTest::get(&(0, None)), Some(KittyLinkedItem::<Test> {
				prev: Some(2),
				next: Some(1),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(1))), Some(KittyLinkedItem::<Test> {
				prev: None,
				next: Some(2),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(2))), Some(KittyLinkedItem::<Test> {
				prev: Some(1),
				next: None,
			}));

			OwnedKittiesList::<Test>::append(&0, 3);

			assert_eq!(OwnedKittiesTest::get(&(0, None)), Some(KittyLinkedItem::<Test> {
				prev: Some(3),
				next: Some(1),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(1))), Some(KittyLinkedItem::<Test> {
				prev: None,
				next: Some(2),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(2))), Some(KittyLinkedItem::<Test> {
				prev: Some(1),
				next: Some(3),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(3))), Some(KittyLinkedItem::<Test> {
				prev: Some(2),
				next: None,
			}));
		});
	}

	#[test]
	fn owned_kitties_can_remove_values() {
		with_externalities(&mut new_test_ext(), || {
			OwnedKittiesList::<Test>::append(&0, 1);
			OwnedKittiesList::<Test>::append(&0, 2);
			OwnedKittiesList::<Test>::append(&0, 3);

			OwnedKittiesList::<Test>::remove(&0, 2);

			assert_eq!(OwnedKittiesTest::get(&(0, None)), Some(KittyLinkedItem::<Test> {
				prev: Some(3),
				next: Some(1),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(1))), Some(KittyLinkedItem::<Test> {
				prev: None,
				next: Some(3),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(2))), None);

			assert_eq!(OwnedKittiesTest::get(&(0, Some(3))), Some(KittyLinkedItem::<Test> {
				prev: Some(1),
				next: None,
			}));

			OwnedKittiesList::<Test>::remove(&0, 1);

			assert_eq!(OwnedKittiesTest::get(&(0, None)), Some(KittyLinkedItem::<Test> {
				prev: Some(3),
				next: Some(3),
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(1))), None);

			assert_eq!(OwnedKittiesTest::get(&(0, Some(2))), None);

			assert_eq!(OwnedKittiesTest::get(&(0, Some(3))), Some(KittyLinkedItem::<Test> {
				prev: None,
				next: None,
			}));

			OwnedKittiesList::<Test>::remove(&0, 3);

			assert_eq!(OwnedKittiesTest::get(&(0, None)), Some(KittyLinkedItem::<Test> {
				prev: None,
				next: None,
			}));

			assert_eq!(OwnedKittiesTest::get(&(0, Some(1))), None);

			assert_eq!(OwnedKittiesTest::get(&(0, Some(2))), None);

			assert_eq!(OwnedKittiesTest::get(&(0, Some(2))), None);
		});
	}
}

linked_item.rs
use support::{StorageMap, Parameter};
use runtime_primitives::traits::Member;
use parity_codec::{Encode, Decode};

#[cfg_attr(feature = "std", derive(Debug, PartialEq, Eq))]
#[derive(Encode, Decode)]
pub struct LinkedItem<Item> {
	pub prev: Option<Item>,
	pub next: Option<Item>,
}

pub struct LinkedList<Storage, Key, Item>(rstd::marker::PhantomData<(Storage, Key, Item)>);

impl<Storage, Key, Value> LinkedList<Storage, Key, Value> where
  Value: Parameter + Member + Copy,
  Key: Parameter,
  Storage: StorageMap<(Key, Option<Value>), LinkedItem<Value>, Query = Option<LinkedItem<Value>>>,
{
	fn read_head(key: &Key) -> LinkedItem<Value> {
		Self::read(key, None)
	}

	fn write_head(account: &Key, item: LinkedItem<Value>) {
		Self::write(account, None, item);
	}

	fn read(key: &Key, value: Option<Value>) -> LinkedItem<Value> {
		Storage::get(&(key.clone(), value)).unwrap_or_else(|| LinkedItem {
			prev: None,
			next: None,
		})
	}

	fn write(key: &Key, value: Option<Value>, item: LinkedItem<Value>) {
		Storage::insert(&(key.clone(), value), item);
	}

	pub fn append(key: &Key, value: Value) {
		let head = Self::read_head(key);
		let new_head = LinkedItem {
			prev: Some(value),
			next: head.next,
		};

		Self::write_head(key, new_head);

		let prev = Self::read(key, head.prev);
		let new_prev = LinkedItem {
			prev: prev.prev,
			next: Some(value),
		};
		Self::write(key, head.prev, new_prev);

		let item = LinkedItem {
			prev: head.prev,
			next: None,
		};
		Self::write(key, Some(value), item);
	}

	pub fn remove(key: &Key, value: Value) {
		if let Some(item) = Storage::take(&(key.clone(), Some(value))) {
			let prev = Self::read(key, item.prev);
			let new_prev = LinkedItem {
				prev: prev.prev,
				next: item.next,
			};

			Self::write(key, item.prev, new_prev);

			let next = Self::read(key, item.next);
			let new_next = LinkedItem {
				prev: item.prev,
				next: next.next,
			};

			Self::write(key, item.next, new_next);
		}
	}
}

I am going to try and start backporting a few things here.

I really think at this point I may want to just rewrite the tutorial, there is so much to be changed here, and so much new knowledge I have gained along the way. I think a v2.0 of the whole tutorial could be an improvement here.

More brain dump:

Use BalanceOf and Currency rather than depending on the balances module directly


Major Features

[x] "Proper" Basic Auth response
[x] LDAP integration
[x] Refresh Token
[ ] Scope resolution (maybe some kind of API?)
[ ] Session "remembering" login (for some form of SSO)
[ ] Single Logout
[ ] Blacklisting Access/Refresh Token

Any plans for DB (say Postgres) based backend?

Not at the moment. Contributions are welcomed.

@stephanbuys support for Mysql backing has been merged in c69f3297d8 - not Postgres, but it's using Diesel and would be relatively low-hanging fruit to extend it to support Postgres as well.

@stephanbuys I have added MySQL, SQLite, and PostgresSQL support.
(https://github.com/lawliet89/rowdy/issues/68)


SS4 - Cannot update password if the email is email is a non-email format

Module version(s) affected
4.13.32
Description
Most likey same issue as #11034 , but i've created a new issue due to this being related to SS4
You can successfully create a new member with a email address that is a non-email format.
However, when you go to update password an error is givien and you are unable to update
I suspect this is the "Your password has been changed" email, this only looks to occur on "live".
error-log.ERROR: Uncaught Exception Swift_RfcComplianceException: "Address in mailbox given [testjoe] does not comply with RFC 2822, 3.6.2." at

Maybe this is intedend behaviour, however then you should not be able to create a member with a non-email to begin with.
How to reproduce
Set SS_ENVIRONMENT_TYPE=live
Create a member with a non-email eg "testemail"
Try to update password  = error
Possible Solution
No response
Additional Context
No response
Validations

[X] Check that there isn't already an issue that reports the same bug
[X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

Silverstripe CMS 4.x has entered the "security fixes only" support phase, and will not be receiving any more bug fixes, except for security vulnerabilities with a CVSS score of 7.0 or higher. See the major release policy for more information.
If this also affects Silverstripe CMS 5.x, please let me know and I'll re-open this issue.


Error while running 'java -jar endpoints-0.1-SNAPSHOT.jar'

Hi,
I am following instructions in README file to setup environment for buggy-taskmanager.
I am able to build the project, however 'java -jar endpoints-0.1-SNAPSHOT.jar' is giving errors.
below is the error.
org.postgresql.util.PSQLException: FATAL: database "s_ink" does not exist
Logs are attached for reference.
endpoints-0.1-SNAPSHOT -  errors.txt

Hi @kuulrahool,
sorry for the delay in replying on my side.
It seems that the database s_ink doesn't exist. The Readme.md suggest to call it taskmanager and this is probably wrong anyway:

Did you try to update the application.properties regarding the db connection parameters of both scheduler and web as reported on the Readme.md?
Did you try to rename the db s_ink instead of  taskmanager?

Let me know if it solve the issue!
Regards,
Damiano

Hi Damiano,
Sorry for the late reply.
Thank you, it worked after renaming the Database.
However, while working with the buggy application I see below tests are failing.
@Test
public void taskServiceFunctionTest() {
TaskDTO t = new TaskDTO();
t.setTitle("Test task3");
t.setStatus(TaskState.NEW.toString().toUpperCase());
TaskDTO t1 = taskService.saveTask(t);
assertTrue(taskService.resolveTask(t1.getUuid()));
assertEquals(t1.getStatus(),"RESOLVED");
}

@Test
public void Bug() {
    TaskDTO t0 = new TaskDTO();
    TaskDTO t1 = new TaskDTO();
    TaskDTO t2 = new TaskDTO();
    TaskDTO t3 = new TaskDTO();
    t0.setTitle("Test task0");
    t1.setTitle("Test task1");
    t2.setTitle("Test task2");
    t3.setTitle("Test task3");
    t0.setStatus(TaskState.NEW.toString().toUpperCase());
    t1.setStatus(TaskState.NEW.toString().toUpperCase());
    t2.setStatus(TaskState.RESOLVED.toString().toUpperCase());
    t3.setStatus(TaskState.NEW.toString().toUpperCase());
    taskService.saveTask(t0);
    taskService.saveTask(t1);
    taskService.saveTask(t2);
    taskService.saveTask(t3);
    List<TaskDTO> list = taskService.showList();
    assertEquals(4, list.size());
    t0.setStatus(TaskState.POSTPONED.toString().toUpperCase());
    t1.setStatus(TaskState.POSTPONED.toString().toUpperCase());
    t2.setStatus(TaskState.POSTPONED.toString().toUpperCase());
    t3.setStatus(TaskState.POSTPONED.toString().toUpperCase());
    taskService.showList();
    assertEquals(0, list.size());

}

I am not able to change the state of the task using taskService.postponeTask() and taskService.resolveTask().
Also showlist() function is returning count of postponed tasks also.
Please advise if my understanding is correct.

Thank you so much Damiano.
Regards
Rahul


no support for description template for changelist

we have a fixed template for a changelist description in in our perforce server, the plugin seems to override this template descrption, which is annoying.
i am getting this server error withtout the template
EnforceMinimalStandardCLDescription' validation failed
is it a bug or missing feature?? is there a way to have a template for each change list?

What are you doing in the extension when the errors appear? Submitting a change / creating a changelist?
It sounds like you have some kind of form-out trigger on perforce that writes some stuff in the description, then the format of the changespec input is validated?
So you would have to enter the changelist description in the same format as the template - If the template is multi-line, this means that's only possible in the source control view "Message" box, and only by doing it manually. If multi-lines are required then it wouldn't work from other locations such as when submitting the default changelist directly
If I'm right - it could probably be partially supported - probably a setting could be added to enable a mode where the "Message" box is pre-populated with with the templateby reading it out the default changespec - (this still wouldn't help for multi-line templates in other places though)
p.s. I currently maintain a fork of this extension - this may be merged back in soon


[W5.11][W13-A2] Aadyaa Maddi

Enhancement 2:
Made the FindCommand case insensitive.

I think Contact.java should not have been included in this PR as it makes it unclean, should add it under a separate PR

Right, thanks for pointing that out!

@amad-person
Some comments added. Please ack & close the PR after reading comments.

Acknowledged, thanks!


Error: Failed to mkdir /lib-modules: mkdir /lib-modules: read-only file system

I'm getting a "CrashLoopBackOff" on the Longhorn-csi-plugin pod with kubic-os and an on premise Kubernetes Cluster.
The error shows me: "Error: Failed to mkdir /lib-modules: mkdir /lib-modules: read-only file system"
Maybe this is because kubic uses a read-only file system.
How to solve that problem?

It looks like the directory specified by CSI plugin pod here is wrong. It shouldn't need to create a new directory. Looks like should be /lib/modules instead of /lib-modules.
We will fix this in the next release.

Closed by mistake. That commit should refer to #464

https://github.com/rancher/longhorn-manager/pull/267 merged.


send Market order

Hi,
In binance documentation, for a MARKET order, we need symbol, side, type and quantity or quoteorderQty for them, (price for you.)
I have an error with MARKET type order, because (I think) all LIMIT type parameter are required.
How can I do to send Market order please ?
Regards,

Hi, welcome to the project and thanks for reporting the issue.
You are correct. Depending on the type parameter, some of the other parameters become required. [1]
I'm not sure why we are missing that. If Binance has added parameter requirements after this module was first released (Dec 2017), it is possible that some methods are now broken. But I don't know how Binance manages API updates so I'm just guessing.
I'll update the parameters and their requirements.
[1] https://github.com/binance-exchange/binance-official-api-docs/blob/7a8d958157d3c0ed8ddaead8d1c0273ec9a3504e/rest-api.md#new-order--trade

Can you test if https://github.com/taskula/binance-perl-api/commit/2401f9b1430e782f314d2c755577138c2c1332e5 works?

Issue author reported that they are unable to contribute further. I'll test it myself and merge https://github.com/taskula/binance-perl-api/tree/issue_9 to master.
Closing issue.

Hi Lari
I test the upgrade realese for market Order;
For BUY MARKET test using $api->order_test(
I test with quoteOrderQty parameter, and it's look like your are only waiting quantity parameter for market order.
So I test with quantity parameter and it look like now waiting Price but it's not require for market order if I understand Binance doc.
For SELL MARKET order, it is the same error.
Adding price give a new error
[Binance::API::Request::_exec] Bad Request at /usr/local/share/perl/5.30.0/Binance/API/Request.pm line 105.
How need I do ?
regards

Hi Lari
I test the upgrade realese for market Order;
For BUY MARKET test using $api->order_test(
I test with quoteOrderQty parameter, and it's look like your are only waiting quantity parameter for market order.
So I test with quantity parameter and it look like now waiting Price but it's not require for market order if I understand Binance doc.
For SELL MARKET order, it is the same error.
Adding price give a new error
[Binance::API::Request::_exec] Bad Request at /usr/local/share/perl/5.30.0/Binance/API/Request.pm line 105.
How need I do ?
regards


NSMicrophoneUsageDescription issue with Apple

Hello,
I’m facing an issue when trying to publish the application to Apple. Apple is asking me to add NSMicrophoneUsageDescription to the Info.plist. However, I’m not using the recording feature of the library; I’m only using the waveform.

ITMS-90683: Missing purpose string in Info.plist - Your app’s code references one or more APIs that access sensitive user data, or the app has one or more entitlements that permit such access. The Info.plist file for the “***********.app” bundle should contain a NSMicrophoneUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. If you’re using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. For details, visit: https://developer.apple.com/documentation/uikit/protecting_the_user_s_privacy/requesting_access_to_protected_resources.

Is there a way to avoid this?

Hi @MagnasiePro, Currently there is no way to avoid this, Because of current permission handling in library. we may consider dynamic options for permission requests in near future. Feel free to contribute and raise a pull request, we would be happy to incorporate changes

Thank you for the answer, no problem !


Linux Support

@jingle0927 falcon-sql-client supports Linux, Mac and Windows. Please, find our latest release here: https://github.com/plotly/falcon-sql-client/releases .

@n-riesco  The homepage says: "Free, open-source SQL client for Windows and Mac"


Automatically detect GPU

Automatic GPU detection would be preferable over the current manual method using the website.
This probably needs a database to translate the GPU names reported by the system to the seemingly arbitrary GPUIDs used by Nvidia.

I could not find an existing database with Nvidia's PFIDs online, so I will have to create my own.
Now I just need to find a reliable way of identifying the GPU within Windows in the first place. The reported name of the GPU itself may not be accurate enough as some special versions and differing manifacturers may report different names. So I need to check for some ID that is unique to the GPU itself.

I found out how Nvidia looks up their internal IDs and experimented with the API a bit. A few things I found out:

URL to get all GPUs with their pfid and psid: https://www.nvidia.com/Download/API/lookupValueSearch.aspx?TypeID=3
URL for all OS IDs: https://www.nvidia.com/Download/API/lookupValueSearch.aspx?TypeID=4
URL for all Language IDs: https://www.nvidia.com/Download/API/lookupValueSearch.aspx?TypeID=5

Some GPUs exist twice in the first list. That's because of the mobile variants of some GPUs haing the same name as the desktop variant. I tried a few models and found that the desktop product is always the first model in that list, the mobile version being the second occurence.

This means I can now work on automatically populating the download API call I was already using all the time.
https://www.nvidia.com/Download/processDriver.aspx?psid=<ProductSeries>&pfid=<ProductType>&osid=<OperatingSystem>&lid=<Language>

Implementation started in bf9814cfd09a62dedf7604b3fa5683cb43ebfd09.


Fix parsing floating-point numbers

This PR just flips the order of the parsers for numbers to support floating-point number literals.

Oops, thank you!


Ollama GPU support

Added a new method WithGPUSupport to the extension methods for when you create an Ollama server resource. Using an enum for the GPU support options.
Closes #298

PR Checklist

[x] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
[x] Based off latest main branch of toolkit
[x] PR doesn't include merge commits (always rebase on top of our main, if needed)
[ ] New integration

[ ] Docs are written
[ ] Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)

[x] Tests for the changes have been added (for bug fixes / features) (if applicable)
[x] Contains NO breaking changes
[x] Every new API (including internal ones) has full XML docs
[x] Code follows all style conventions

Other information

@elbruno here's the GPU support that we discussed.

@elbruno here's the GPU support that we discussed.

Amazing! thanks


[HOTFIX] ZEPPELIN-931: fix interpreter listing bug

What is this PR for?
Currently available interpreter list is not shown in Creating New Interpreter section. It seems this bug was generated after #835 was merged. So I temporally deactivated 3 SerializedName code lines.
What type of PR is it?
Bug Fix
Todos

[x] - Fix interpreter listing bug when creating new interpreter

What is the Jira issue?
ZEPPELIN-931
How should this be tested?

Build latest master branch and browse Zeppelin home
Create new interpreter -> You can not see the available interpreter list in this step like below attached screenshot
Apply this patch
Build again and browse  -> You can see the available interpreter list as normal

Screenshots (if appropriate)

Before

After

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@jongyoul I saw you are working on applying new mechanism to all of the existing interpreters in ZEPPELIN-804 as subtasks. I think this bug was caused since interpreterGroup , interpreterName and interpreterClassName  that I deactivated was not matched with group in here. So if you have a better way to solve this bug, just let me know :)

@AhyoungRyu I've tested and reproduced what you mentioned. Your change looks simple but it's not perfect because you cannot see spark interpreter in your interpreter list because interpreter-setting.json read interpreterGroup, interpreterName and interpreterClassName while initialisation. I'll submit a PR into your branch. Thanks for reporting this.

I don't know whether front-end uses RegisteredInterprerter. We need to find a way to indicate or mark which class is used in front and backend.

@jongyoul I see. That's why I can't see Spark interpreter in the list. Thanks ! Okay i'll check ASAP.

@AhyoungRyu Could you please add "[HOTFIX]" in a title?

@jongyoul Yeah I just added :)

@jongyoul I applied your patch and it works :)

@AhyoungRyu I've missed something. I submitted a PR, again.

@jongyoul That was also applied.

@AhyoungRyu Thanks.

@jongyoul Let's wait the travis then :)

@Leemoonsoo CI has been passed. Could you check this one ? :)

LGTM. I'll merge it asap.

@jongyoul Yeah sounds good.


Fixes links inside main.md

Description
Broken links
What changed?
Links are now clickable, and they link to their appropriate destination.
Are there any files to ignore?

Hello, thank you for your PR these markdown files are actually in a format that gets compiled together by another tool so the
{{< relref "*.md" >}}
syntax is necessary to make this page work correctly: https://mongodb.github.io/node-mongodb-native/3.6/tutorials/main/


I am getting the LORA KEY NOT LOADED error when using this LoRA

What should be the settings avoid this error? I am using the default settings
10 photos x 10 repeats 10 epochs for a 1000 steps training. Except that I change LoRA rank to 16. The LoRA though ran with error but finished with a photo generated - but it looks very bad.

I have the same problem, I'm using comfyUI and i get inconsistent results, some images are very good and some doesnt seem to work at all

same problem

I'm getting better results and more consistency using forge rather than ComfyUI


HandTracking mobile on Android Fragment not working with unity

Hi,
I am working on Android with the HandTracking feature. I want to display a Unity scene and run hand tracking at the same time. To do so, I chose to use Android Fragments. I did a first app with two fragments : one running a unity scene and the other a preview of the camera (using cameraX). This is the result :

Then, I made an app with only one fragment running mediapipe, this is the result :

Finally, i did an app with my two inital fragments (unity and mediapipe) but the app is always crashing. Do you have any suggestion to fix the crash ??
Thanks
See the logcats :
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 000000747a39cff0
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: Build type 'Release', Scripting Backend 'il2cpp', CPU 'arm64-v8a'
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: Build fingerprint: 'samsung/dreamltexx/dreamlte:9/PPR1.180610.011/G950FXXS6DSL2:user/release-keys'
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: Revision: '10'
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: pid: 21219, tid: 21313, name: UnityMain  >>> com.polymont.fragments1camera1unity <<<
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x0<PHONE_NUMBER>b7a790  x1<PHONE_NUMBER>38aee0  x2<PHONE_NUMBER>800000  x3<PHONE_NUMBER>b79f80
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x4<PHONE_NUMBER>8c2000  x5<PHONE_NUMBER>b7a000  x6<PHONE_NUMBER>38af00  x7<PHONE_NUMBER>38af10
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x8   000000003f000000  x9<PHONE_NUMBER>39cff0  x10<PHONE_NUMBER>1a9b00  x11<PHONE_NUMBER>38af50
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x12<PHONE_NUMBER>38aee0  x13<PHONE_NUMBER>38aef0  x14<PHONE_NUMBER>000000  x15<PHONE_NUMBER>003800
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x16<PHONE_NUMBER>eb11d0  x17<PHONE_NUMBER>ddfd30  x18<PHONE_NUMBER>000097  x19<PHONE_NUMBER>6879e0
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x20<PHONE_NUMBER>1ff708  x21<PHONE_NUMBER>47b000  x22<PHONE_NUMBER>383530  x23<PHONE_NUMBER>47b000
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x24<PHONE_NUMBER>47b000  x25<PHONE_NUMBER>47b000  x26<PHONE_NUMBER>000197  x27<PHONE_NUMBER>1ff704
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     x28<PHONE_NUMBER>0002f4  x29<PHONE_NUMBER>687a60  x30<PHONE_NUMBER>c1fbec
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH:     sp<PHONE_NUMBER>6879d0  pc<PHONE_NUMBER>c1fbd8  pstate<PHONE_NUMBER>000000
2020-03-12 14:28:45.100 21219-21313/com.polymont.fragments1camera1unity E/CRASH: backtrace:

[...]

2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#00  pc<PHONE_NUMBER>00069c  [vdso] ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#01  pc<PHONE_NUMBER>2d8bd4  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#02  pc<PHONE_NUMBER>2d8774  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#03  pc<PHONE_NUMBER>2e082c  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#04  pc<PHONE_NUMBER>2b4f80  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#05  pc<PHONE_NUMBER>20dd0c  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#06  pc<PHONE_NUMBER>1b07d4  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#07  pc<PHONE_NUMBER>1b10e8  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#08  pc<PHONE_NUMBER>1ab24c  /data/app/com.polymont.fragments1camera1unity-90x0gfNlV07shwTDksbjkQ==/base.apk ()
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#09  pc<PHONE_NUMBER>543fe0  /system/lib64/libart.so (art_quick_generic_jni_trampoline+144)
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#10  pc<PHONE_NUMBER>53af88  /system/lib64/libart.so (art_quick_invoke_stub+584)
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#11  pc<PHONE_NUMBER>0a9140  /system/lib64/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+200)
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#12  pc<PHONE_NUMBER>25f5e8  /system/lib64/libart.so (_ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPNS_11ShadowFrameEtPNS_6JValueE+344)
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#13  pc<PHONE_NUMBER>2595a4  /system/lib64/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+948)
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#14  pc<PHONE_NUMBER>50b580  /system/lib64/libart.so (MterpInvokeDirect+296)
2020-03-12 14:28:45.307 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#15  pc<PHONE_NUMBER>52d714  /system/lib64/libart.so (ExecuteMterpImpl+14484)
2020-03-12 14:28:45.308 21219-21313/com.polymont.fragments1camera1unity E/CRASH: 	#16  pc<PHONE_NUMBER>000002  <unknown/absolute> ()
2020-03-12 14:28:45.309 21219-21313/com.polymont.fragments1camera1unity E/AndroidRuntime: FATAL EXCEPTION: UnityMain
    Process: com.polymont.fragments1camera1unity, PID: 21219
    java.lang.Error: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 000000747a39cff0
    Build fingerprint: 'samsung/dreamltexx/dreamlte:9/PPR1.180610.011/G950FXXS6DSL2:user/release-keys'
    Revision: '10'
    pid: 21219, tid: 21313, name: UnityMain  >>> com.polymont.fragments1camera1unity <<<
        x0<PHONE_NUMBER>b7a790  x1<PHONE_NUMBER>38aee0  x2<PHONE_NUMBER>800000  x3<PHONE_NUMBER>b79f80
        x4<PHONE_NUMBER>8c2000  x5<PHONE_NUMBER>b7a000  x6<PHONE_NUMBER>38af00  x7<PHONE_NUMBER>38af10
        x8   000000003f000000  x9<PHONE_NUMBER>39cff0  x10<PHONE_NUMBER>1a9b00  x11<PHONE_NUMBER>38af50
        x12<PHONE_NUMBER>38aee0  x13<PHONE_NUMBER>38aef0  x14<PHONE_NUMBER>000000  x15<PHONE_NUMBER>003800
        x16<PHONE_NUMBER>eb11d0  x17<PHONE_NUMBER>ddfd30  x18<PHONE_NUMBER>000097  x19<PHONE_NUMBER>6879e0
        x20<PHONE_NUMBER>1ff708  x21<PHONE_NUMBER>47b000  x22<PHONE_NUMBER>383530  x23<PHONE_NUMBER>47b000
        x24<PHONE_NUMBER>47b000  x25<PHONE_NUMBER>47b000  x26<PHONE_NUMBER>000197  x27<PHONE_NUMBER>1ff704
        x28<PHONE_NUMBER>0002f4  x29<PHONE_NUMBER>687a60  x30<PHONE_NUMBER>c1fbec
        sp<PHONE_NUMBER>6879d0  pc<PHONE_NUMBER>c1fbd8  pstate<PHONE_NUMBER>000000

        at [vdso].(:0)
        at base.(:0)
        at base.(:0)
        at base.(:0)
        at base.(:0)
        at base.(:0)
        at base.(:0)
        at base.(:0)
        at base.(:0)
        at libart.art_quick_generic_jni_trampoline(art_quick_generic_jni_trampoline:144)
        at libart.art_quick_invoke_stub(art_quick_invoke_stub:584)
        at libart._ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc(_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc:200)
        at libart._ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPNS_11ShadowFrameEtPNS_6JValueE(_ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPNS_11ShadowFrameEtPNS_6JValueE:344)
        at libart._ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE(_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE:948)
        at libart.MterpInvokeDirect(MterpInvokeDirect:296)
        at libart.ExecuteMterpImpl(ExecuteMterpImpl:14484)
        at Unknown.00000002(Unknown Source:0)

@romaindebraize  is it an unity app that you are showing?

@Zumbalamambo i did a simple scene in Unity and then i exported it as an android studio project. After that i made a library with the android studio project containing my scene in order to use it in a fragment.

Did you finally get to use mediapipe along with unity? I would be interested to see your solution if so, since I am trying to do the same thing.

No, i am still struggling to do it..
Good luck

@romaindebraize Hey can you provide the code of how you converted Mediapipe to a fragment? Thank you

Refer https://github.com/homuler/MediaPipeUnityPlugin repo to work on Hand tracking.


Reproducing proteingym

Hi!
I'm trying to run your proteingym pipeline, and I'm having a couple of issues. I'm using the proteingym_branch and your ProtMamba_long_fondation model.
Firstly, in proteingym.py you are supposed to import prepare_target from tests/proteingym/utils.py but that function doesn't exist in there, so I'm currently importing it from ProtMamba_ssm/utils.py. Is that ok, or are this functions supposed to be different?
Secondly, in ProtMamba_ssm/modules.py it seems that you have updated the mamba version as you have changed
from mamba_ssm.modules.mamba_simple import Block from mamba_ssm.ops.triton.layer_norm import RMSNorm, layer_norm_fn, rms_norm_fn
to
from mamba_ssm.modules.block import Block from mamba_ssm.ops.triton.layernorm import RMSNorm, layer_norm_fn, rms_norm_fn.
I'm still using the old Mamba version. Do you think this is problematic?
With these two (minor) changes I'm getting very different results from the ones reported in the paper with an average Spearman correlation of ~0.10. Here are Spearman values per protein that I find: ProtMamba_long_foundation_proteingym_msalength_200_spearman.json
Any idea where this huge difference could come from?
Thanks for your help!

Hi @sohviluukkonen,
I have updated the code to make it more clear (https://github.com/Bitbol-Lab/ProtMamba-ssm/blob/proteingym_branch/tests/proteingym/proteingym.py). This should solve a lot of issues. In particular, one problem that could happen is if you don't have checkpoint_mixer = False when you load the model.
Otherwise, it's not clear for me if using the old version or not is problematic, maybe we could investigate that if your problem is not solved later.
Hope this will help!


Key modifiers

Hey,
I noticed that in the GLFW SetKeyCallback the modifier is never used:
window.SetKeyCallback(func(window *glfw.Window, k glfw.Key, s int, a glfw.Action, m glfw.ModifierKey) {
	key := Key(k)
	if a == glfw.Press {
		Input.keys.Set(key, true)
	} else if a == glfw.Release {
		Input.keys.Set(key, false)
	}
})

but it is used with the mouse:
window.SetMouseButtonCallback(func(window *glfw.Window, b glfw.MouseButton, a glfw.Action, m glfw.ModifierKey) {
	x, y := window.GetCursorPos()
	Input.Mouse.X, Input.Mouse.Y = float32(x)*scale, float32(y)*scale

	// this is only valid because we use an internal structure that is
	// 100% compatible with glfw3.h
	Input.Mouse.Button = MouseButton(b)
	Input.Mouse.Modifer = Modifier(m)

	if a == glfw.Press {
		Input.Mouse.Action = Press
	} else {
		Input.Mouse.Action = Release
	}
})

I spent some time trying to figure out the best way to figure out how to figure out when the shift key was also pressed down, and the quickest way to do that is add this to button.go
func (b Button) HasShiftModifier() bool {
	return Input.keys.Get(LeftShift).Down() || Input.keys.Get(RightShift).Down()
}

func (b Button) HasControlModifier() bool {
	return Input.keys.Get(LeftControl).Down() || Input.keys.Get(RightControl).Down()
}

func (b Button) HasAltModifier() bool {
	return Input.keys.Get(LeftAlt).Down() || Input.keys.Get(RightAlt).Down()
}

func (b Button) HasSuperModifier() bool {
	return Input.keys.Get(LeftSuper).Down() || Input.keys.Get(RightSuper).Down()
}

So that I have my own input system that returns one of these buttons and then I can do checking in my callbacks.
Since Input.keys isn't exported, I don't have access to the keymanager inside of the input manager--which would also be another way to do this (make it exported).
My real question though is why not rewrite SetKeyCallback and the key manager to include the modifiers given by GLFW?

Did you try adding the modifiers you want to their own button group and checking that? I'm actually not sure if it actually works because I'm not able to test it out at the moment, but I made a gist for it
https://gist.github.com/Noofbiz/0b57df144787007d5e0fdd8d4d0ad74d


add more data as inputs

volume
bid/ask spread
RSI/MACD / other derivative metrics
social sentiment analysis

ref: #13 #8

I've used Ichimocku in my manual trading.  They are very powerful.

Have you looked at all into using Social Mention or Google Alerts for social sentiment analysis?
Sifting and reacting to viral bursts of social approval could provide large gains with minimal trading.

Nice @jeff-hykin , I didnt check the other issues. I will start to follow all of them in here.
@owocki I already had filled the form, will you create a a group or we will be here by now?

@rmendes900 just sent your invite

(Just saving this for future use)
Heres a potential data source @darcy mentioned on slack
https://www.quandl.com/data/BCHAIN?keyword=bitcoin

Quandl looks super easy to integrate, there's also a Python library:
https://www.quandl.com/help/python

https://github.com/owocki/pytrader/pull/75

https://github.com/owocki/pytrader/pull/76


Kubernetes YAMLs are missing spec

Kubernetes YAMLs are missing spec branch. We see
kind: Mesh
mtls: ...

whereas we should see
kind: Mesh
spec:
  mtls: ...

Universal does not have this branch.

This is fixed in the latest version and will be included in the next build.


FI-1888: Update profile support test

Summary
Update the profile support test to not issue warnings based on supported profiles and to support a list of resources which must be supported in order to pass.
Testing Guidance
Unit tests demonstrate the new functionality.

After approving, I was thinking about how in the 'ABOUT' section on really presents 2 options: USCDI and not USDCI, and yet downstream users of this test could list any set of resource.  It might make sense for the config to just be 'USCDI: true/false'.


Rewrite Python bindings using pybind11

pybind is a great project by Wenzel Jakob, very much in the spirit of
Boost.Python (and with substantially similar syntax), but is
C++11-based, light-weight, header-only, and compiles in a fraction of
the time as code that uses Boost.Python.
So the primary change here is to switch underlying implementation of our
Python bindings. But in the process, I made a number of improvements and
changes to the Python bindings, some of which are not strictly backwards
compatible, so this is a BREAKING CHANGE that may require some (hopefully
minor) changes to your OIIO-using Python code.

All of the functions that read and write blocks of pixels (such as
ImageInput.read_image(), ImageOutput.write_tile(), or
ImageBuf.get_pixels()) no longer use old-style Python arrays, but now
use NumPy ndarray objects. I'm guessing that NumPy is such a common
Python package that it's not an onerous dependency to add, the n-D
array syntax is really handy for images (e.g., pixel regions are
naturally structured as [y][x][channel] multidimensional arrays and
very easy to use that way), and pybind11 makes it very easy to
manipulate NumPy ndarray objects but comparitively difficult to use
old Python arrays.

We now transparently accept strings anyplace that a TypeDesc is used
as a function parameter. For example,
ImageBuf.set_write_format(TypeFloat) can alternatively be called as
ImageBuf.set_write_format("float").

Some specialized enum types (such as ImageInput.OpenMode) have been
replaced by strings: ImageInput.open (filename, ImageInput.Create)
should now be called as ImageInput.open (filename, "create")

It should be encouraging that of all the Python test files in our test
suite, testsuite/python-*/src/test-*.py, a very small number of source
lines needed to be changed.
Also note that we include pybind11 as a git submodule (since it's far
from being a common installed dependency) This is the first time we've
used a submodule, and I'm not 100% convinced this is the way to go...
we may revise this and instead make the build download it if not found.

After some discussion with Chris, I decided to just git clone pybind11 if we need a local copy, rather than using git submodules. (I can't discern any penalty for doing it this way, and it gives us a little more flexibility as well as not scaring people who don't like submodules.)
Also changed the download logic just a bit. It is now:

If BUILD_PYBIND11_FORCE is true, download a local copy (regardless of      any system install).

Otherwise, look for a system-installed copy, and use it if found.

Otherwise, if BUILD_MISSING_PYBIND11 is true (default), download      a local copy.

So, the default behavior is to use an installed copy, or auto-download if that's not found. But it's possible to force a download (ignoring system) or to disallow a download (making missing pybind11 simply an error).
Also, none of this happens if the build is USE_PYTHON=0.

I can't speak to the backwards compatibility issues - but the binding code itself looks much nicer!

I've seen no objections here or on the mail list, so I'm going to merge this today.


create simple install script

can be used remotely or locally.

I don't think there's any reason to add an install script. All you need to do is copy a file; this just replaces 2 lines with 95 lines...

so I can ssh to all my servers and run
for i in serverA serverB serverC; do
curl -s https://raw.githubusercontent.com/ryanmjacobs/c/master/install.sh | INSTALL_PREFIX=~/bin bash /dev/stdin inst ; done

That's why.

for i in serverA serverB serverC do
ssh $i "curl -s https://raw.githubusercontent.com/ryanmjacobs/c/master/c ~/bin ; done

Is this not short enough, or am I missing something?

@alebcay but... it has colors :rainbow: :rainbow: (mind you 16 bit)! And :rainbow: warnings! :warning: :warning:!!!
Also has the ability to be updated IF new things are added.

I get the :rainbow: and :warning: - and that's great - but in terms of updating, couldn't you just reinstall it and effectively update it?
Also, one must consider whether or not :rainbow: and :warning: are worth putting into an install script that is half the length of the entire script itself.

but :rainbow: ...
Let's put this on the wiki.

:+1:

https://github.com/ryanmjacobs/c/wiki/Installation-Helper I updated the script so it can be run independently, either locally or remote.

for i in serverA serverB serverC do
ssh $i "curl -s https://raw.githubusercontent.com/ryanmjacobs/c/master/c ~/bin/c ; done
Is this not short enough, or am I missing something?

I think this is the best way to install, apart from cloning the repo and copying the file. Personally, I dislike "install scripts" because I never know exactly what they are doing. A simple download using curl is all you need.

Whoa, so you're down with user-maintained packaging repositories such as AUR, but being able to grab the latest HEAD at any time via an install script is a no-no? But doing a for i in curl is A-OK? Pick a side here.
How many people blindly add public keys to their dpkg repositories without double checking? How many people download a tagged version of your code without also comparing it against a md5sum on a different server?
Fact is, most don't.
Libevent has a insanely low ratio of 20 to 1 downloads to md5 checks, that's scary in itself.
Keybase is a good start. md5sum your releases, sign them using the distributed key, put the md5sum on multiple hosts, and we have a nice distributed method of saying "NOPE!" or "YEP!".
To completely tear out the things I did on the wiki was way too premature.

To completely tear out the things I did on the wiki was way too premature.

As a bystander, I must agree on this point. The wiki content itself should have undergone further discussion before actions were taken. Documentation is an important part of any project, no matter how big or small.

Keybase is a good start. md5sum your releases, sign them using the distributed key, put the md5sum on multiple hosts, and we have a nice distributed method of saying "NOPE!" or "YEP!".

The question at this point is not whether signing releases is a good idea or not; rather, is it worth the extra effort for:

first and foremost, users
second, other contributors
lastly, yourself
One must calculate the possibility and the risks of such a scenario even occurring. The ideas you bring up here are certainly worth considering, but they should be implemented into the package manager rather than the software package itself.

To completely tear out the things I did on the wiki was way too premature.

Sorry about that. My decision to remove the install script from the wiki was rash. I probably should have waited longer. However, an install script that is more than half the length of the actual script seems out of place. A simple copy is much more fit.

being able to grab the latest HEAD at any time via an install script is a no-no? But doing a for i in curl is A-OK?

I don't understand. Isn't for i in curl also grabbing from the latest HEAD?

md5sum your releases, sign them using the distributed key

Lastly, I don't think that it's worth the hassle to md5sum releases here. Let the package managers handle that.

The question at this point is not whether signing releases is a good idea or not; rather, is it worth the extra effort for...

Yes. If it was a pet-project or a small library, sure, I'll look the other way. But this is a front-end to a compiler.
I was just discussing a huge disaster redhat made in 2001 or so where they compiled an entire distribution using a development version of GCC; thus every-single-binary was subject to that bug.
In reality, all of the verification is pretty much drag and drop, see: https://github.com/ellzey/libevhtp/blob/develop/SIGNED.md generated by https://keybase.io/docs/command_line/code_signing

Ryan creates a keybase.io account and puts his key everywhere.
Ryan makes a release, and signs it.
We all track ryan
Our scripts can verify using the SIGNED.md BEFORE installing.

Personally, I dislike "install scripts" because I never know exactly what they are doing. A simple download using curl is all you need.

That's a personal opinion. The wiki snippets was an alternative to your opinion.

A simple copy is much more fit.

This is what boggles me. You are completely down with AUR, and bpkg, but in this ticket push for a "just scp it" ideal.
So is it a security thing, or are you just confused? I assumed it was security related until I remembered you promote bpkg, and I read the following:

Lastly, I don't think that it's worth the hassle to md5sum releases here. Let the package managers handle that.

The point is, once such a method is implemented on this end, it makes it more difficult for other systems to integrate with it. As you mentioned, most package managers don't do distributed signature checks, and  to include it specifically with the project would make very little sense. It sounds big enough to be a project of it's own.
As quoted from "Acceptable Formulae" from the Homebrew project:

We don’t like install-scripts that download things

Because that circumvents our hash-checks, makes finding/fixing bugs harder, often breaks patches and disables the caching. Almost always you can add a resource to the formula file to handle the separate download and then the installer script will not attempt to load that stuff on demand. Or there is a command line switch where you can point it to the downloaded archive in order to avoid loading.

But this is a front-end to a compiler.

Fair enough. On another note, this is released under the MIT license, so it's technically okay to enforce  caveat emptor.

In reality, all of the verification is pretty much drag and drop, see: https://github.com/ellzey/libevhtp/blob/develop/SIGNED.md generated by https://keybase.io/docs/command_line/code_signing

Ryan creates a keybase.io account and puts his key everywhere.
Ryan makes a release, and signs it.
We all track ryan
Our scripts can verify using the SIGNED.md BEFORE installing.

Alternatively, @ryanmjacobs doesn't have to be the one to sign the releases (granted, it's less trustworthy than if he were the one to do it, but it's still better than nothing I would suppose).

This is what boggles me. You are completely down with AUR, and bpkg, but in this ticket push for a "just scp it" ideal.

Many people already have AUR and/or bpkg installed. To provide it via these systems is most likely a convenience to end users. I can remember bpkg install ryanmjacobs/c much more easily than curl <someRandomGitHubAddress>.sh | bash <someObscureArgs>. On the contrary, if one can figure out the URL, they can also intuitively use a command such as curl <someRandomGitHubAddress> ~/bin/c - as long as they know how to use curl, then they can get the file themselves. The format/syntax of the install script is not exactly standardized. I know I certainly didn't know how to use it when I first stumbled across this PR.

I pretty much agree with everything that @alebcay has said.
By the way, I sign all of the releases. You can view the GPG signatures with git show v0.10, or verify them with git tag --verify v0.10. My public key can be found right here.