Add OAuth::Signature::HMAC::SHA256 and associated tests

I've had a requirement to start using HMAC-SHA256 on a project and thought it would be useful to push upstream. I've based the implementation directly on that of HMAC-SHA1.
Please let me know if this is wanted, or if I missed a test file (I took a look though and duplicated the ones I thought were necessary).

Thanks for the contribution. LGTM other than the code climate errors.
IMO we should probably allow/ignore CodeClimate's error about possible code duplication--I don't see a DRY problem here, Code Climate is probably just trigger-happy on that.

Thanks! Yeah, I'd offer to refactor but I agree that it's probably more overhead than it's worth.

I'll deal with codeclimate later. The code looks good.


numpy.argsort

Returns the indices that would sort an array.
https://docs.scipy.org/doc/numpy-1.15.0/reference/generated/numpy.argsort.html

@emrahsungu Could you make the ndarray.argsort more generic that supports axis? I just made the simple version.

@Oceania2018, I will have a look right away. Generic, as in not just for ndim==1 right?
https://github.com/SciSharp/NumSharp/blob/3dd1ff017ac7f0fb48ea0c4bcb2913e38e4c0994/src/NumSharp.Core/Extensions/ndarray.argsort.cs

@emrahsungu Yes, you are definitely right. Appreciate you take that job.

Any progress?

Hi there, I am simply sorry for no progress. I am working 9am - 11pm currently because we are on a deadline for our next game. I only have weekends to look at the code 😭. Good news you get to see new Pokemons 🤣

@Oceania2018, I just created a pull request for the Issue. Sorry for the comments, I will fix them when I have more time at hand

@emrahsungu , awesome, we appreciate. Your commits are making NumSharp better. @dotChris90 , we should welcome Sungu again.
We have one coding principle:
Try to avoid using LINQ especially in the intensive loop function. (sometimes LINQ is not good as we thought).
Enumerable.Range(0, iterateUntil).Select(_ => previousStep.Concat((_).Yield()));
is not good as the simple for (int i = 0; i < iterateUntil; i++);
And the Yield is bad performance.
You don't have to change it right away.
We did some performance discuss before:
https://github.com/SciSharp/NumSharp/issues/14
https://github.com/SciSharp/NumSharp/issues/63

Thanks for the comments, I really appreciate it. Like you mentioned LINQ comes with an overhead about 1.40 times of the simple for loop. I usually choose it for the expressiveness. I have not tested the simple Enumerable.Range case but it definitely should be slower than the similar for loop. I will fix it as soon as I have some time.
Can you please tell me more about the Yield() bad performance? We use it on AI servers such as skill selection etc

I've not test yield yet, just know from this post.


[EI-7][Doc]Need more information on single config file

Description:
Under https://ei.docs.wso2.com/en/latest/micro-integrator/references/config-catalog/ we need to specify the location of this deployment.toml file inside the distribution. Also need a description on this single config file, how to use it, when to use it etc. This is a new concept so need better clarity.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

The required information is now available in the doc.
https://ei.docs.wso2.com/en/latest/micro-integrator/references/config-catalog/

The required information is now available in the doc.
https://ei.docs.wso2.com/en/latest/micro-integrator/references/config-catalog/


⚠ Bofrost.be has degraded performance

In d28cdde, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1581 ms

Resolved: Bofrost.be performance has improved in 3d226ca after 7 minutes.


[Feature Request] Archive Files

Hi
I have limited space on the PC that I use to download Tumblr content, and I move blogs off to a removable external drive. If I do this with TumblThree the entire blog is lost from the UI. I guess that the folder structure is enumerated to determine which tumblrs we follow.
So I'd like the ability to move files/folders and not have TumblThree lose track of the blog, or worse, re-download Gb worth of files that I've already archived to another location.

It's implemented already.
Leave the database/index files named after your blog in the Index folder of your download location. E.g. your blog is named wallpaper, then leave the wallpaper.tumblr and wallpapers_files.tumblr in mydownloadlocation\Index.
The suffix can vary depending on what blog type you download (search, hidden, normal blog), but the root name does not.
As long as those two files stay in place, you can (re-)move any downloaded file.

Thanks. I'd not spotted the index folder, which I'd moved to the external drive. Moved it back :o)


Primary Role Key Error

Describe the bug
await user.get_primary_group_role() Key Error: 'memberCount'
Copy of error:
  File "/robloranker/./main.py", line 37, in promote
    await promote_command(interaction, roblox_client, username, reason)
  File "/robloranker/commands/promote.py", line 30, in promote_command
    operator_user_primary_role = await operator_user.get_primary_group_role()
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roblox/bases/baseuser.py", line 255, in get_primary_group_role
    group=Group(
          ^^^^^^
  File "/usr/local/lib/python3.11/site-packages/roblox/groups.py", line 52, in __init__
    self.member_count: int = data["memberCount"]
                             ~~~~^^^^^^^^^^^^^^^
KeyError: 'memberCount'

To Reproduce
Use await user.get_primary_group_role().
In my case, I only accessed the primary role .group.id:
    operator_user_primary_role = await operator_user.get_primary_group_role()

    if operator_user_role is None or operator_user_primary_role is None:
        await interaction.followup.send(f"There was an error getting your group role.")
        return

    if operator_user_primary_role.group.id is not get_main_group_id():
        await interaction.followup.send(f"Cannot promote {target_user.name} as ___ is not your primary group.")
        return

The operator_user in my case holds the owner role in the primary group.
Expected behavior
A clear and concise description of what you expected to happen.
VPS:

OS: Ubuntu
Version: 22.04

Have been informed get_primary_user_role() has been deleted post 2.0.0.


convert 2D image into the point set representation

Is there a way to convert a 2D image into the point set representation as used in the code

More information is needed to answer your question. What is the image? Are there unique values in the image that you could assign to be the points?
If you have a segmentation image, and each pixel of the image is assigned to be the border of a tissue of interest, then you could easily extract those pixel locations from the image and use them in this algorithm. For example:
import numpy as np
y = np.asarray(np.where(x==1))

The above assumes that you have an image x, and you want to make all of the pixels valued 1 to be your points.
However, if you have a full segmentation (not just the border) you will need to find the pixels on the border of the segmentation. You can look up something called marching cubes or marching squares - there are many implementations.
If you have a raw image. Then, you will either need to segment the image and do the appropriate steps as described above. Or, you may be able to threshold the image in some way. E.g., you could identify that the border pixels of the object you are interested in are all within a specified range - so, say you have an image and you identify that all of the pixels on the border of the object are between 5-10 then you could use this twist on the above code:
import numpy as np
y = np.asarray(np.where(((x>5) and (x<10))))

The above would get the x,y coordinates of all pixels in the image x that have a value between 5 and 10.
Again, these are just some general ideas. More detailed information about your example are needed to provide any specific information/insights.

Got it thanks.

Did this work out for you? Which suggestion did?
If everything is resolved, is it alright if we close this issue?

Thank you @gattia for developing low-rank and other quality-of-life improvements. I have merged your pull requests with the development branch. I think when we merge development into master we should bump the version to 2.1.0.
That being said, I also think that our current examples might be insufficient to help new users with pycpd. When I have more time, I will go through the issues and see if I can create a better set of examples.

Sounds good. I think we can close this one.
Let me know what you’re thinking for examples. I’m happy to contribute as best I can. Either making new ones or code review.


Unnecessary RAM consumption

I am using HP Bx576tx, Ubuntu 19.10 OS. Every time "flutter run" command is executed the app is run consuming 600-1000MB of RAM on the laptop. The issue is after the runtime is quit by pressing "q" the run time ends. But the amount of RAM reserved for the same does not get cleared. When the app is run for the second time, it allocates a new portion of the RAM. When I use this cumulatively, the laptop starts to lag and get eventually stuck/hangs. There is no other way but to force shutdown the laptop.

You haven't actually provided any information on what version of flutter you are using and how much ram it is consuming

Have you ever worked on Android development before? That's how Gradle works. Those processes are the daemon(s) spawned and used by Gradle whenever you're building something, in your case your Flutter app project. Gradle will terminate any idle daemons after 3 hours, but since you seemingly have resource availability issues especially RAM, these are my recommendations to you:

Please add more RAM when it's possible. Any kind of modern Android development needs a lot of memory, 4 GB of RAM won't cut it, you need more.

Please check what the daemons are doing by executing ./gradlew --status in <your project root>/android. Stop any idle daemons to reclaim the memory. To stop them, instruct the Gradle wrapper to stop the daemons it has spawned. Execute ./gradlew --stop in <your project root>/android.

You can disable the daemon completely. You can disable them system-wide or per-project basis. To disable the daemon, you can see the solutions here. You will have to wait longer during the debug/build session when compared to daemon enabled since the build process restarts from scratch (more information here)

Hi @AbhayVAshokan
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Add pyproject.toml for Custom Node Registry

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.
The main benefits are that authors can

publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

[ ] Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
[ ] Write a short description.
[ ] Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish
Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

hey @blepping, wanted to send a small nudge and ask if you had any questions!

@blepping, wondering if there's any way we can support you on this PR!


How long does it take to train the code2nl model in the codebert folder?

I tried to reproduce it, but it had been running for a day on a Tesla K80 graphics card, and progress was extremely slow. The dataset is less than 1GB.

I am not sure how much time the training takes in K80. Even if the model is trained on 4 v100, it also needs to take about one day.


add topic

I suggest adding the topic interpolation in the About section at https://github.com/furstj/interpolation

Done :)


Write unit tests for bot/cogs/watchchannels/__init__.py

Write unit tests for bot/cogs/watchchannels/__init__.py.
Implementation details
Please make sure to read the general information in the meta issue and the testing README. We are aiming for a 100% branch coverage for this file, but if you think that is not possible, please discuss that in this issue.
Additional information
If you want to work on this issue, please make sure that you get assigned to it by one of the core devs before starting to work on it. We would like to prevent the situation that multiple people are working on the same issue. To get assigned, leave a comment showing your interesting in tackling this issue.

Internal discussions deemed these tests to be unnecessary.


The README specifies "Lua 5.1+" and "Lua 5.2+", which is it?

Right at the start:

Simple C++11 friendly header-only bindings to Lua 5.2+.

And then in the requirements:

Lua 5.1+

This page suggests 5.2 requirement, and I could not make it build under 5.1, So I guess it's supposed to be 5.2


[Registry Mobile][WP theme] Icon alignment

Nomination, DPGA Technical Team Review and Digital Public Good steps should be displayed side by side instead of one by one scrolled way.

Wordpress theme issue

Acceptance criteria
On URL https://digitalpublicgoods.net/registry/
Set screen size to mobile device such as iPhone SE. Icons "Nomination, DPGA Technical Team, Digital Public Good" should align horizontally next to each other on page.

Suggestion: the icons visually are not centered because the non-justified text block above has no right edge. What if we add some space to the right of the bounding box of the icons to center them visually. I tested it and a right padding of 1rem looks good.

Looks good now.


Update .io with Jaeger as "preview"

Update .io site to include Jaeger as an additional managed service
.com is updated (see below)

You mean here?
Or here?
I'm a bit unsure if we should put "preview" on .io, since the website is about the Compliant Kubernetes product, not the Elastisys offer. But maybe we should have a chat to clarify what website contains what.

Both those places, but also here @cristiklein (please include both ArgoCD and Jaeger in this picture)

Also, if we should put "preview" or not on the .io site I leave up to you to decide. Since it is part of the product, to me, it would make sense to leave out "preview" since we are not marketing the managed service on the .io site and therefore it is outside the scope of the BDR saying we can only market beta features as preview.


Open-scd-core is not exporting any typed mixins.

Open-scd-core is not exporting any typed mixins.
Therefore I cannot use a mixin inside a plugin.
Can these be exported by the foundation as well?

Let's refine this

Discussion from Slack
pascal wilbrink
10:51 AM
@openscd/open-scd-core is not exporting any Mixins (typed ones). Can this be fixed? Added a github issue here: https://github.com/openscd/open-scd-core/issues/88
#88 Open-scd-core is not exporting any typed mixins.
Open-scd-core is not exporting any typed mixins.
Therefore I cannot use a mixin inside a plugin.
Can these be exported by the foundation as well?
https://github.com/[openscd/open-scd-core](https://github.com/openscd/open-scd-core)|openscd/open-scd-coreopenscd/open-scd-core | Feb 17th | Added by GitHub
white_check_mark
eyes
raised_hands
Christian
11:09 AM
Thanks, good idea!
pascal wilbrink
11:11 AM
and what about the OpenSCD class?
Christian
11:11 AM
I think we already export that from open-scd.ts, don't we? We could export the mixins from there as well. (edited)
pascal wilbrink
11:12 AM
https://www.npmjs.com/package/@openscd/open-scd-core?activeTab=explore
There's only a foundation.d.ts file in here, no open-scd.d.ts
11:13
import { OpenSCD } from<EMAIL_ADDRESS> This doesn't work
import { OpenSCD } from '@openscd/open-scd-core'; Neither does this (edited)
Christian
11:22 AM
"compile": "tsc -b && tsc foundation.ts --declaration --emitDeclarationOnly --outDir dist", in package.json means we currently export types only for foundation.ts, we should add open-scd.ts to that command to fix that. We could do that in the same pull request which re-exports the mixins from open-scd.ts, what do you think?

This won't be necessary anymore if the OpenSCD class is exported. The issue will arrise again if we start with CoMPAS based on OpenSCD-core.

This is still an issue for me, I can't use open-scd-core in tests easily unless I either have the OpenSCD class (as a lit element with types) or I have mixins which I can wrap my plugin in.
So I'd like to re-open this and perhaps we can discuss at refinement.


Docs: update links to new react-router docs

"Other api" docs about React Router were pointing at the old urls (which do not redirect properly). Updated to point to the new ones

@jacob-ebey is there something that needs fixing on the website for redirections? If not, please merge this one 🙏🏼


Toolbar height in app header

Bug, feature request, or proposal:
Bug
What is the expected behavior?
What is the current behavior?
Toolbar height switches when android keyboard appears in chrome for mobile
What are the steps to reproduce?
place Toolbar on top of app header -> place input field under it -> click input field -> when android keyboard appears, the toolbar switches from portrait to landscape and the height of the toolbar jumps
u can see it on my demosite. https://atippr.moniholz.at click in the loginform an watche the toolbar on top,  when the keyboard appears
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
beta-2
Is there anything else we should know?

Adding overflow hidden to the body fixes this issue with onscreen keyboards pushing up the toolbar.
body {
    overflow: hidden;
}

thanks for your answer, i tried this, but no effect :(

Looking into this more the problem is with how media queries calculate the orientation: portrait and landscape. So when the virtual keyboard is opened, it resizes the viewport and the media queries for the md-toolbar switch from portrait 56px to landscape 48px.
@DevVersion I notice you created the pull to add the responsive sizing to the toolbar #2157. Are there plans to use alternative media queries instead of using the orientation?


I want to know about the audio value range [-1,1]

Hello, I am also a researcher in the direction of sound source separation. I have benefited a lot from seeing your work.
But I have some questions about sound processing.

Why should the raw audios' values be limited between -1 and 1?
I did some verification. There is a difference between performing STFT after sound mixing, and performing STFT first and then mixing on the spectrum. STFT(audio1+audio2)≠(STFT(audio1) + STFT(audio2))
How can this be explained?
Looking forward to your reply.

@avis-ma Clipping the values between -1 and 1 is a widely used pre-processing step in this field. It will make the network easier to train. For the second question, I have proved it theoretically in the supplement material. Besides, I have verified it in the experiments. Please try it more carefully.


TypeError: a bytes-like object is required, not 'list'

  File "\winocr.py", line 18, in recognize_pil     return recognize_bytes(img.tobytes(), img.width, img.height, lang)   File "\winocr.py", line 11, in recognize_bytes     writer.write_bytes(list(bytes))
I think something changed in DataWriter

i have merged, thank you for your commit


emscript-sdk install woes

Something probably changed with the base github action images because the emscript-sdk does not work anymore.

We are locked on 3.1.30 and the latest 3.1.45 is now using node16

fixed in https://github.com/microsoft/devicescript/commit/7e8846e58970ea459cddae79c125f5900bff7451


Socket.IO integration

Is there any way to integrate socket.io service in tabrisjs app?
For web it's really easy, all you have to do is include socket.io javascript file and that's it:
<script src="/socket.io/socket.io.js"></script>
<script>
  var socket = io('http://localhost');
  socket.on('news', function (data) {
    console.log(data);
    socket.emit('my other event', { my: 'data' });
  });
</script>

how should I use socket.io.js in tabrisjs? Can I load it as module?

Just add it to the dependencies section of your package.json.  Here's an example with chart.js:
https://github.com/eclipsesource/tabris-js/tree/v1.1.0/examples/chart

Tabris.js currently doesn't have client side support for WebSocket, so the core functionality would not work. @bev-on What would you like to do with socket.io? Maybe engine.io is an option?

@gosia-eclipsesource @cookieguru Thanks!
@gosia-eclipsesource I need it for simple text exchange. I will try to use engine.io as client in my app and I will add it at dependencies as @cookieguru suggested it. Can I connect socket.io server using engine.io client or should I use engine.io as server too? Because I can't touch anything server side and it's already running socket.io.

@bev-on We haven't tried it that way yet. But we will have a look and let you know.

Tested socket.io-client [git][npm] in a very simple use case for text-based data exchange. To make it work I had to modify socket.io.js to change the line XHR.prototype.supportsBinary = true; to XHR.prototype.supportsBinary = false;.
For the module to be supported out of the box and to enable binary data exchange, following web interfaces and XHR features would need to be supported:

the Blob constructor
xhr.responseType

"arraybuffer"
"blob"

xhr.response support for response types:

ArrayBuffer
Blob

xhr.send(data) argument types:

ArrayBuffer
Blob

There may be more browser APIs which need to be supported for the client to work out of the box.

Is there any chance to see normal working solution in nearest future?

+1
XHR polling is not an option

Is this possible to create static local html file with connected socket.io library, open it in hidden webview  and organize some kind of "tunnel" between my apps logic and sockets?

@sergio-doman A direct communication is currently not possible via a hidden WebView we are currently working on #613 which should add direct support in the very near future.

@mpost sounds really good, thx for response

@sergio-doman With the advancements in ArrayBuffers we are also pushing a WebSocket integration so expect to have something in your hands in the not to distant future: https://github.com/eclipsesource/tabris-js/issues/188#issuecomment-196724300

WebSockets are supported in 2.0.0. Could you try again with the latest version npm install tabris@latest.

Maybe it's just me, but I cannot get socket.io-client to work with tabris. I Loaded in the javascript file and added it to the dependencies. Then, I required it in the script, and wrote some code to tell it to connect, and console.log saying that it works.
When running the code on my device, no errors arise, but also nothing happens. Not sure whats going on at this point. I'm certain the socket.io server works correctly, as I have other socketio clients connecting to it without a problem (server is over HTTPS)
I also then tried using the npm package "socket.io-client" but that throws an error when running about the missing tty module.
Any thoughts about what could be going on?

@NickLD Which Tabris.js and client versions are you using?
You might also try the ttys package as mentioned in https://github.com/eclipsesource/tabris-js/issues/1293#issuecomment-299614026

I'm using the latest tabris client<EMAIL_ADDRESS>I tried using ttys, and now instead of missing tty, it shows missing fs.. from ttys itself.

@NickLD Sounds like the same issues as mentioned in the other thread.
Is there something you're after that Socket.io provides that isn't part of WebSocket?

Well, the rest of my service. which i'm trying to create the app for, uses socket.io for all the other endpoints and clients. Being able to keep everything consistent would be ideal. I suppose it would be entirely possible to implement a socket.io client from scratch, but it would be so much better to be able to use the official client for obvious reasons.
I also need support for receiving binary payloads, which I isn't available yet, but is in the works if I understand. XHR polling isn't really an option either..

Ditto the sentiments about XHR and code re-usage.
I haven't looked at the Socket.io source myself; do you know why the client would need access to the filesystem?  If it's ephemeral storage, you could probably stub the fs methods out and have them write to memory and get the same functionality.

Socket.IO client doesn't use fs itself, but it appears that ttys does.
It seems ttys uses it to emulate stdout?
https://github.com/TooTallNate/ttys/blob/master/index.js
I'm still not sure why the client needs this in the first place. This is with the npm version of socketio client.
I tried the browser socketio client, and while it didnt throw any errors, it seems to just do nothing. Very confusing..

@NickLD fs was recently added in #1364

I found using socket.io.js can, although this is the browser used, this is the URL"https://cdn.bootcss.com/socket.io/2.0.3/socket.io.js"

Tested socket.io-client [git][npm] in a very simple use case for text-based data exchange. As WebSocket is not supported yet (see #188), the client falls back to using XHR. To make it work I had to modify socket.io.js to change the line XHR.prototype.supportsBinary = true; to XHR.prototype.supportsBinary = false;.
For the module to be supported out of the box with XHR and to enable binary data exchange, following web interfaces and XHR features would need to be supported:

the Blob constructor

xhr.responseType

"arraybuffer" #613
"blob"

xhr.response support for response types:

ArrayBuffer #613
Blob

xhr.send(data) argument types:

ArrayBuffer #613
Blob

There may be more browser APIs which need to be supported for the client to work out of the box.

At the moment, we already have Blob, ArrayBuffer and WebSocket. I will try to connect socket.io-client to socket.io` as soon as I can

We can't use socket.io-client at the moment.

engine.io-client uses the xmlhttprequest-ssl module, where errors occur due to the lack of implementation of the Node API.

Even if there is a easy replacement for two modules, child_process must be done natively.
What do we need from the Tabris team to make socket.io-client worked without errors:

Move fs from tabris to fs module
Make a url module (or use url-polyfill)
Make child_process.spawn

I doubt that child_process.spawn will not be possible on a mobile device as you are not able to create a new process.
It likely makes more sense to wrap the official native socket.io sdk libraries in a tabris plugin. eg https://github.com/socketio/socket.io-client-java


Task 183-189 SNLI Tasks

6 answer generation tasks, 1 classification task on SNLI

Why did we close this PR?

There is problem with the fork, I am working with Anjana to create a new PR shortly


Update translations from transifex, fix trans tags and context

Codecov Report

Merging #978 into master will decrease coverage by -0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   62.45%   62.43%   -0.02%
==========================================
  Files         109      109
  Lines        5963     5963
  Branches      731      731
==========================================
- Hits         3724     3723       -1
  Misses       2095     2095
- Partials      144      145       +1

Impacted Files
Coverage Δ

saleor/core/utils/random_data.py
83.59% <0%> (-0.4%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e24b16...92cfdbc. Read the comment docs.


Clean up global commands and help text

Changes:

Renamed disconnect to disassociate because we have a connect command that does not do the opposite
Renamed env to variables to align verbiage with Dashboard
Adjusted help text for all commands
Both Stripe and Heroku CLIs were used as a style reference

Old renamed command still work but are deprecated.

I'm unsure how I feel about init and disassociate being complementary commands. They don't sound related and IDK how I feel about the verbage of disassociate
To me, it almost feels like they should be connect and disconnect and we could consider renaming connect to something else
Thoughts?

@JakeCooper ya, it still seems a bit weird to me too. I was also thinking that disassociate may be an infrequent-enough command to put under railway init remove or something.

We could rename init to link/unlink but that doesn't imply the ability to create a project as much as init does. Or we could rename disassociate to unlink (didn't think of that verb before).


Bugfix: support multidimensional NumPy mask arrays in ak.mask

Fixes #975

Yes, that's all it needed. I'll try to get this into 1.4.0, too.

OK. I've modified the test to actually check the result of ak.mask, but it still passes.


Render markdown as HTML in documentation tips

This is feature request, and maybe a bit contentious since such decisions usually is taken in language spec level.
But I would love to see tooltip rendered as HTML when I type markdown in my comments.
E.g.
/**
 * This function is helper for `CreateObject.foo()`
 **/
function bar(d) {

}

Should render in Atom Tooltip as: This function is helper for CreateObject.foo()
I took the idea shamelessly from Swift and Xcode.
Add Maybe it could be configurable from tsconfig.json? "docs" : "markdown"

I would like this as well.

Maybe it could be configurable from tsconfig.json? "docs" : "markdown"

Perhaps later. I think we should be able just switch it on without any aweful issues

Even though I like it I don't want to deviate on the UI experience on this one, so closing as I don't want someone else to put any effort in this.

I have since reconsidered this stance. Especially since typedoc already renders these as markdown :rose:
I've done the same in alm.tools in tooltips :

As well as in the documentation view : https://basarat.gitbooks.io/alm/content/features/documentation-view.html


[suggestion] [1.7.10+] [1.12.2] Factory Version of the Precision Sawmill

Please add a Factory Version of the Precision Sawmill to make it more easy to create a large wood processing Machinery.

btw: i added 1.7.10+ to the Title because i would prefer to have that also for the old Version, and i have added 1.12.2 to the Title for the case the 1.7.10 version isn't longer worked on.


Mention & Invite to room how does it work - reported by Santhoshkumar Sellavel

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a Workspace
Open #announce room or any room
"This is the beginning of the private #announce room, invite others by @mentioning them", this is shown at the beginning of the chat.
Try to use @ mention

Expected Result:
Able to mention & invite users
Actual Result:
Unable to invite users
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by:  @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1645736648234169
View all open jobs on GitHub

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal
Simple one,
Need to refactor the copy here,

There further discussion evolving in the same thread here.

There further discussion evolving in the same thread here.

Is that the right link? I'm not seeing any conversation there

@stitesExpensify Not sure how I messed that one -> here

@stitesExpensify should we add wait for copy label here?

@stitesExpensify I think we should add waitingForCopy label for this issue based on the discussion  here

Hey sorry I've been sick the last week. Waiting for copy makes sense to me!

Triggered auto assignment to @sylveawong (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

Sorry, I just wanted to clarify – are we trying to update the copy for the 4 rooms or 2?
From mitch's post: https://expensify.slack.com/archives/C01GTK53T8Q/p1646776612170489?thread_ts=1645736648.234169&cid=C01GTK53T8Q

#admins - "Collaboration between Workspace Name admins starts here! :tada:  This is a place to chat about workspace configuration"
#announce - "Collaboration between all Workspace Name members starts here! :tada:  This is a place to chat about anything about anything Workspace Name related"
User Created Rooms - "Collaboration in Room Name starts here! :tada: "
Domain rooms - "Collaboration between Domain Name members starts here! :tada:  "

I think we want to update all 4

Domain room not yet available.
So these three would be enough right? @stitesExpensify

#admins - "Collaboration between Workspace Name admins starts here! 🎉 This is a place to chat about workspace configuration"
#announce - "Collaboration between all Workspace Name members starts here! 🎉 This is a place to chat about anything about anything Workspace Name related"
User Created Rooms - "Collaboration in Room Name starts here! 🎉 "

Yep as long as @sylveawong likes that copy :)

Looks great to me @sylveawong

I asked for translations in slack, will post them here when they're ready :)

Collaboration among [workspaceName] admins starts here! :tada:
Use #admins to chat about topics such as workspace configurations and more.

Este es el lugar para que los administradores de [workspaceName] colaboren! :tada:
Usa #admins para chatear sobre temas como la configuración del espacio de trabajo y mas.

Collaboration between all [workspaceName] members starts here! :tada:
Use #announce to chat about anything [workspaceName] related.

Este es el lugar para que todos los miembros de [workspaceName] colaboren! :tada:
Usa #announce para chatear sobre cualquier cosa relacionada con [workspaceName].

Collaboration starts here! :tada:
Use this space to chat about anything #[RoomName] related.

Este es el lugar para colaborar! :tada:
Usa Usa este espacio para chatear sobre cualquier cosa relacionada con #[RoomName].

Updated Proposal

Add translations to copy files as shown below.

In en.js
        beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}) => `Collaboration among ${workspaceName} admins starts here! 🎉\nUse `,
        beginningOfChatHistoryAdminRoomPartTwo: ' to chat about topics such as workspace configurations and more.',
        beginningOfChatHistoryAnnounceRoomPartOne: ({workspaceName}) => `Collaboration between all ${workspaceName} members starts here! 🎉\nUse `,
        beginningOfChatHistoryAnnounceRoomPartTwo: ({workspaceName}) => ` to chat about anything ${workspaceName} related.`,
        beginningOfChatHistoryUserRoomPartOne: 'Collaboration starts here! 🎉\nUse this space to chat about anything ',
        beginningOfChatHistoryUserRoomPartTwo: ' related.',

#####In es.js
        beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}) => `Este es el lugar para que los administradores de ${workspaceName} colaboren! 🎉\nUsa `,
        beginningOfChatHistoryAdminRoomPartTwo: ' para chatear sobre temas como la configuración del espacio de trabajo y mas.',
        beginningOfChatHistoryAnnounceRoomPartOne: ({workspaceName}) => `Este es el lugar para que todos los miembros de ${workspaceName} colaboren! 🎉\nUsa `,
        beginningOfChatHistoryAnnounceRoomPartTwo: ({workspaceName}) => ` para chatear sobre cualquier cosa relacionada con ${workspaceName}.`,
        beginningOfChatHistoryUserRoomPartOne: 'Este es el lugar para colaborar! 🎉\nUsa este espacio para chatear sobre cualquier cosa relacionada con ',
        beginningOfChatHistoryUserRoomPartTwo: '.',

Add the following new method to get the welcome message for rooms in reportUtils.js.

/**
 * Get welcome message based on rooms type
 * @param {Object} report
 * @param {Object} policiesMap must have Onyxkey prefix (i.e 'policy_') for keys
 * @returns {Object}
 */

function getRoomWelcomeMessage(report, policiesMap) {
    const welcomeMessage = {};

    const workspaceName = lodashGet(
        policiesMap,
        [`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`, 'name'],
        Localize.translateLocal('workspace.common.unavailable'),
    );

    if (isAdminRoom(report)) {
        welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminRoomPartOne', {workspaceName});
        welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminRoomPartTwo');
    }

    if (isAnnounceRoom(report)) {
        welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartOne', {workspaceName});
        welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartTwo', {workspaceName});
    }

    if (isUserCreatedPolicyRoom(report)) {
        welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartOne');
        welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartTwo');
    }

    return welcomeMessage;
}

Finally use it in ReportWelcomeText.js as shown below.

Screenshots:
Admin Room

Announce Room

User Room

@stitesExpensify

LGTM, the only changes I would make would be:

Use else if for performance
We should have a default for if something goes really wrong and fails all 3 if checks

@NicMendonca can we hire @Santhosh-Sellavel for this please? Thanks!

We should have a default for if something goes really wrong and fails all 3 if checks
What should be default values?

Yep that makes sense to me!

Upwork job: https://www.upwork.com/jobs/~0152360e4f1d2a4c0a cc @Santhosh-Sellavel

Unassigning because @Santhosh-Sellavel is a C+, and doesn't need another C+ to review it.

📣 @Santhosh-Sellavel You have been assigned to this job by @stitesExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Done. Have you applied on upwork as well?

@stitesExpensify PR is ready for review!

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.49-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/8330

If no regressions arise, payment will be issued on 2022-04-12. :confetti_ball:

@Santhosh-Sellavel paid for reporting and fix, thank you!


Cannot install dependencies

Heya,
How do I do an npm install with react set to .13.0-rc2?  I get the following errors on both the code and docs:
npm ERR! peerinvalid The package react does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>Thanks!

Heya :3, you have to update the peerDependencies locally.
The docs site is supposed to use react-router, like material-ui, but I'm still waiting for them to land React 0.13 support, you can follow progress here: https://github.com/rackt/react-router/issues/638
Jest is also broken if you update to the latest node version.
I'm going to refactor the docs page to not use react-router while we wait for them to fix the compat issues.


New runs failing since merge of 886a0ce

I am seeing this error:

File "/home/runner/work/mastodon_get_replies/mastodon_get_replies/find_posts.py", line 756, in
arguments.lock_file = os.path.join(arguments.state, 'lock.lock')
AttributeError: 'Namespace' object has no attribute 'state'

Was coming to do just this, experiencing as well.

Same
https://github.com/quicoto/mastodon-get-replies/actions/runs/4616214140/jobs/8160941063

Apologies everyone. That should now be fixed, without needing further action

Some correction to the 'without needing further action' part:
If you are running a GitHub Action you need not take any further action.
If you are running a cron job, you'll need to get the latest version of find_posts.py and remove artifacts/lock.lock.


ERROR: Soil thermal nodes do not extend below bottom soil layer

I ran VIC v. 4.2.c over a basin in the Columbia River Basin (PNW, U.S.) in energy balance mode (3-hour time step). The model ran to completion for all cells; however, at least one cell gave the following error:
"ERROR: Soil thermal nodes do not extend below bottom soil layer, currently unable to handle this condition."
I have 10 soil thermal nodes and 3 soil layers. FROZEN_SOIL is FALSE. Damping depth = 4 and total soil depth = 4.0378. This error message is confusing and probably unnecessary when FROZEN_SOIL=FALSE.

@tbohn - any idea what is going on here?

The problem is fairly trivial - the check just needs to be modified to only happen when FROZEN_SOIL = TRUE.

Okay, so let's make sure the following are true in VIC 5:

this check is only performed when it matters (FROZEN_SOIL is TRUE)
If we say ERROR, we actually raise an error.

Agreed

This sounds good to me. The only other thing that might be useful is if the error message said:  "ERROR: Soil thermal nodes do not extend below bottom soil layer, currently unable to handle this condition. Check that soil thermal damping depth is greater than total soil column depth."

Actually, the solution is not as trivial as I'd thought, although it's still fairly simple to solve.  My previous response was too hasty - I relied on my imperfect memory of the code without confirming by checking the code.
It turns out that even when FROZEN_SOIL is FALSE, the code estimates soil layer temperatures (using QUICK_FLUX scheme if appropriate).  Obviously these temperatures won't be very accurate if the soil goes below freezing, but it at least guarantees that you can get model estimates of temperature under all modes of simulation.  So, I can't just ignore the check when FROZEN_SOIL is FALSE.  Fortunately when FROZEN_SOIL is FALSE, no other variables depend on these layer temperature estimates (I originally implemented them so that John Yearsley could have temperature estimates for his stream temperature model), i.e. they have no effect on the water and energy balances.  Therefore, I propose that in this case we just extend the temperature of the deepest node down to the bottom of the bottom soil layer.

@lizaclark can you point me to the input parameters, forcings, etc for a grid cell that failed?  I'm trying to reproduce the error but not able to - could be my settings or something...

@tbohn : Check your email for the test files.

@tbohn : Just checking that this is still in the works ...

PR is on the way...

OK, I can't reproduce this in 5.0 when FROZEN_SOIL is FALSE.  In 5.0, the only way to get to that error message is when FROZEN_SOIL is TRUE.  I've fixed the bug for this case: instead of giving an error when the soil thermal nodes don't extend to the bottom of the soil column, the soil layer temperatures are computed assuming that the temperature of the deepest node pertains to all depths below it.  Since nothing else in the model depends on these reported soil layer (not node) temperatures, it seems harmless enough to allow a soil layer temperature to be computed for this case.
I can examine 4.2.c and try to find a fix for that release to go into 4.2.d, if people feel this is important.

closed via #467


[language-translator] Not Authorized from example project

[language-translator] from example project will throw
12-15 11:32:29.464 6619-6671/com.ibm.watson.developer_cloud.android.myapplication E/WatsonService: https://gateway.watsonplatform.net/language-translation/api/v2/translate, status: 401, error: Not Authorized
12-15 11:32:29.467 6619-6671/com.ibm.watson.developer_cloud.android.myapplication E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #3
                                                                                Process: com.ibm.watson.developer_cloud.android.myapplication, PID: 6619
                                                                                java.lang.RuntimeException: An error occurred while executing doInBackground()
                                                                                at android.os.AsyncTask$3.done(AsyncTask.java:318)
                                                                                at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
                                                                                at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
                                                                                at java.util.concurrent.FutureTask.run(FutureTask.java:242)
                                                                                at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                                at java.lang.Thread.run(Thread.java:761)
                                                                                Caused by: com.ibm.watson.developer_cloud.service.UnauthorizedException: Unauthorized: Access is denied due to invalid credentials
                                                                                at com.ibm.watson.developer_cloud.service.WatsonService.execute(WatsonService.java:143)
                                                                                at com.ibm.watson.developer_cloud.service.WatsonService.executeRequest(WatsonService.java:183)
                                                                                at com.ibm.watson.developer_cloud.language_translation.v2.LanguageTranslation.translateRequest(LanguageTranslation.java:293)
                                                                                at com.ibm.watson.developer_cloud.language_translation.v2.LanguageTranslation.translate(LanguageTranslation.java:256)
                                                                                at com.ibm.watson.developer_cloud.android.myapplication.MainActivity$TranslationTask.doInBackground(MainActivity.java:332)
                                                                                at com.ibm.watson.developer_cloud.android.myapplication.MainActivity$TranslationTask.doInBackground(MainActivity.java:328)
                                                                                at android.os.AsyncTask$2.call(AsyncTask.java:304)
                                                                                at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                                at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                                at java.lang.Thread.run(Thread.java:761)

even i provided the correct credential from bluemix dashboard
Steps to reproduce
Just use the example project, provide username and password, run
Expected behavior
Not force closed and can translate the text i provided
Actual behavior
Force closed and throw exception
Android Phone
One Plus One(A001)
CyanogenMod version 14.1-20161123-NIGHTLY-bacon
Android version 7.1
android-sdk version
Same with example project:
compileSdkVersion 23
buildToolsVersion "23.0.2"
minSdkVersion 9
targetSdkVersion 23

Hey @hendrawd I think you are trying to use the LanguageTranslator service, but you are using LanguageTranslation in your code. Please check that because we change the service name recently.

@germanattanasio So how to use LanguageTranslation service from IBM Bluemix dashboard in https://console.ng.bluemix.net/catalog/?category=services&taxonomyNavigation=services?
I can't seem to find LanguageTranslation service there, only LanguageTranslator

You can't use LanguageTranslation that service was renamed to LanguageTranslator. Just use LanguageTranslator

@germanattanasio so this example project will not works right? Because it is used LanguageTranslation

I just saw the example project and you are right. It won't work. You need to update the example to use the LanguageTranslator service. It should be easy because it's the exact same service as LanguageTranslation we just changed the name

thanks for the update, i will check it tomorrow and let you know the result


unify-logs-naming-with-db

TL;DR
Renamed 'events' to 'logs' for consistency and clarity in storage-related functions.
What changed?

Renamed parameter 'events' to 'logs' in InsertLogs function
Changed GetEvents function to GetLogs
Updated variable names from 'events' to 'logs' in affected functions
Modified function signatures in the IDBStorage interface to reflect these changes

How to test?

Ensure all calls to InsertLogs now use 'logs' instead of 'events' as the parameter name
Verify that GetLogs is called instead of GetEvents throughout the codebase
Check that the IDBStorage interface is implemented correctly in all storage connectors
Run existing tests to confirm that the functionality remains unchanged

Why make this change?
This change improves code consistency and readability by using the term 'logs' instead of 'events' when referring to blockchain log entries. This aligns better with Ethereum terminology and reduces potential confusion between events and logs in the codebase.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#26  👈
#25
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AmineAfia and the rest of your teammates on  Graphite

Merge activity

Sep 20, 6:38 AM EDT: @AmineAfia started a stack merge that includes this pull request via Graphite.


Display correct line numbers for multiple .text sections

Object files with multiple .text sections currently display incorrect line numbers. This is because we are storing line info by mapping an address to a line number, not taking section index into consideration.
DWARF 2.0+ supports multiple .text sections by defining multiple "sequences", where each sequence starts from address 0 and correlates to one .text section. I've implemented support for this, by iterating to the next code section whenever a sequence ends. This means the line info is now mapping section index, to address, to line number.
From what I've read, DWARF does not define how it correlates a sequence to a section. I've made an assumption and believe that the first sequence should correlate to the first code section, and so on.
I haven't tested this on all the architectures that objdiff supports, but I'd be happy to do so if anyone can provide some object files.

Thanks for this! I committed a few changes that cleans things up and fixes the issue for DWARF 1 as well. This code is a little tricky when dealing with objects that are either 1. missing a .text section but still have a .line section or 2. have empty .text section(s). So my changes are aimed at making sure the logic is solid in those cases. Could you retest with your DWARF 2 objects?

I'm gonna go ahead and merge this for a 2.0.0 alpha release.


KILT dataset: empty string in triviaqa input field

What happened
Both train and test splits of the triviaqa dataset (part of the KILT benchmark) seem to have empty string in their input field (unlike the natural questions dataset, part of the same benchmark)
Versions
KILT version is 1.0.0
datasets version is 1.1.2
more here
How to reproduce
In [1]: from datasets import load_dataset
In [4]: dataset = load_dataset("kilt_tasks")
# everything works fine, removed output for a better readibility
Dataset kilt_tasks downloaded and prepared to /people/lerner/.cache/huggingface/datasets/kilt_tasks/all_tasks/1.0.0/821c4295a2c35db2847585918d9c47d7f028f1a26b78825d8e77cd3aeb2621a1. Subsequent calls will reuse this data.

# empty string in triviaqa input field
In [36]: dataset['train_triviaqa'][0]
Out[36]:
{'id': 'dpql_5197',
 'input': '',
 'meta': {'left_context': '',
  'mention': '',
  'obj_surface': {'text': []},
  'partial_evidence': {'end_paragraph_id': [],
   'meta': [],
   'section': [],
   'start_paragraph_id': [],
   'title': [],
   'wikipedia_id': []},
  'right_context': '',
  'sub_surface': {'text': []},
  'subj_aliases': {'text': []},
  'template_questions': {'text': []}},
 'output': {'answer': ['five  £', '5 £', '£5', 'five £'],
  'meta': [],
  'provenance': [{'bleu_score': [1.0],
    'end_character': [248],
    'end_paragraph_id': [30],
    'meta': [],
    'section': ['Section::::Question of legal tender.\n'],
    'start_character': [246],
    'start_paragraph_id': [30],
    'title': ['Banknotes of the pound sterling'],
    'wikipedia_id': ['270680']}]}}
In [35]: dataset['train_triviaqa']['input'][:10]
Out[35]: ['', '', '', '', '', '', '', '', '', '']
# same with test set
In [37]: dataset['test_triviaqa']['input'][:10]
Out[37]: ['', '', '', '', '', '', '', '', '', '']
# works fine with natural questions
In [34]: dataset['train_nq']['input'][:10]
Out[34]:
['how i.met your mother who is the mother',
 'who had the most wins in the nfl',
 'who played mantis guardians of the galaxy 2',
 'what channel is the premier league on in france',
 "god's not dead a light in the darkness release date",
 'who is the current president of un general assembly',
 'when do the eclipse supposed to take place',
 'what is the name of the sea surrounding dubai',
 'who holds the nba record for most points in a career',
 'when did the new maze runner movie come out']

Stay safe :)

Just found out about https://github.com/huggingface/datasets/blob/master/datasets/kilt_tasks/README.md
(Not very clear in https://huggingface.co/datasets/kilt_tasks links to http://github.com/huggingface/datasets/datasets/kilt_tasks/README.md which is dead, closing the issue though :))


explorer public tally fix

wip

@cong-or fyi draft-pull-requests.

@cong-or fyi draft-pull-requests.

ah ok, thanks :)


README: add Forum

Dear maintainers,
As a part of the Consolidating Ansible discussion platforms initiative, this PR adds the communication section template defined by the community to the README and the docsite. Similar PRs are now being raised across all the Ansible ecosystem projects.
Thank you

cc @oraNod
ready for review

@oraNod the suggestion has been committed, PTAL


Bulk Equip Menu Tweaks

Make sort and filter consistent with changes in my-items. (For now, still omits search bar and ascending, as before)
Modify styling of the amount display on items to add transparency and shift location slightly
Show the amount display in the bulk equip modals
Remove imagemin from being directly invoked by pre-commit as it should be covered in lint-staged.

Note: imagemin doesn't work on my local setup either, may need a separate tweak or explanation on what environment it works for.

How the items look in the bulk equip modal:

Add rarity text in the selection:

How it looks in the my items page:


Output values of generator network appear to be limited to a very low range, causing a darkened image to be generated

All activation functions are set to relu.


Arc new tab

Description
As mentioned in #4255, I added a preference to define the URL that opens with the "Open New Tab" command. By default it's https://google.com.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

🚀 tested and LGTM.
One comment about validation of the url. Also, related to that, is it possible to do the validation when the user enters the url in the preferences? Might make for a better UX if the feedback is given there instead of when they try to open a new tab.

Nice, thanks for testing and verifying it works for you. Unfortunately we don't have validation in the preferences yet. This could be indeed a nice-to-have that would improve the UX. We have plans to revamp the preferences and make it more dynamic and configurable. This should also cover validation. In the meantime I added some validation in the command as you've seen.


Change SPs Status: RFC > Obsolete

MIP10
MIP7
MIP39
MIP40
MIP41
@patrick-j-govalpha

You missed this one:
https://mips.makerdao.com/mips/details/MIP14c2SP5

You will need to check that these proposals shouldn't have been set to 'Accepted' status. I believe most of the MIP10 ones ended up passing.

@Gala-G please action the rest of LFW's comments prior to merge

@LongForWisdom @patrick-j-govalpha
I discussed some of these points with Long on Monday. I apologize for this oh-so-messy PR!
Whitespaces: I have no idea why there are so many unwanted whitespaces. I was unable to delete the lines or revert them. MIP41c5-SP2 - which should not be touched in this PR - was part of this whitespace problem. I will start being careful about this.
SPs in "Formal Submission" marked as "Obsolete": I was able to verify most of them and marked them as "Accepted" based on our discussion with LFW. I was unable to trace down MIP10c9-SP16 and MIP10c7-SP1. Should I mark them back as "Formal Submission", do you know where I can find if they were ratified? Let me know please.
MIP14c2-SP5 that I missed on the initial commit, was done.
Let me know if there is anything else I should do
Thank you!


Content designer SOMC resource not generated

Describe the bug
'Content designer statement of merit criteria resource is not being generated.
To Reproduce
Steps to reproduce the behavior:

Go to 'Hiring Digital' -> 'Designers' -> 'Content designers'
Notice that 'Content designer statement of merit criteria is not there

Expected behavior
'Content designer statement of merit criteria' resource should be present.
Additional context
Add any other context about the problem here.

@dylanzheng94
This is in progress, I think it's related to #313.
I'll unpublish for now, redeploy, and republish once all the links are available.

Resolved in the interim --


Implement Waverider 2

Creating this PR so I can link pipeline issue without forgetting. Feel free to add whatever else needs to be added here

Resolve #912

would it be possible to make Key changes in const module as a separate PR to merge to master? This will prevent too much drift churn between master and this branch

Sure, I'll move it over to another PR


disable public interfaces & pool based cloud init

this PR will adds two configuration features

add config parameter to disable public interfaces at hetzner node creation (ipv4 and/or ipv6)
cloud init function can be configured in pool section too (pool config overrules global config)

thanks and take your time no harry to this
stephan

@derlinuxer hi, why did you close it? :)

I tried to sync your changes into my fork via "sync fork" ("sync fork" should be called "override fork"). That was a mistake and all my changes were gone, also the PR. We use your tool very much and I needed your fix for "system_upgrade_controller_manifest_url", but me changes are also mandatory. Now I merged it with my local git from IDE and will create a new RP after some tests.
Do you have any advice for a proper sync your changes into my fork if the PR not included and without loosing my stuff?

Oh sorry to hear that. I would usually just pull from the origin repo/branch to update mine.


Replace Matrix with da.Array with unknown shapes

The Matrix class was created to support array-like things with unknown shapes, as well as sparse matrices. Since dask.array supports these now, we may be able to remove this class.
One issue is that the Matrix class does support sparse matrices, while dask array doesn't. In most places we know whether the output of an operation is sparse or dense. The best solution might be to only use Matrix for sparse matrices, and use da.Array elsewhere.

Is there a subset of operations for which dask.array would work if its constituent arrays were sparse?  Are there modest changes we could make to the functions we use within dask array graphs that would extend this set of operations?

With the recent rewrite, this is no longer applicable. Closing.


Fix sqlite

Rebased from #812 for further work + upstreaming - see other pr for full context on approach

So right now this won't allow pip installs of packages that need the headers.
To achieve that, we need to, roughly, do this:

apt-get install libsqlite3-dev in the Python formula (see https://github.com/heroku/heroku-buildpack-php/blob/343fa959d4c195beb7febe1996340624baf713b9/support/build/php#L59-L71 for a generic way of doing this)
ensure realpath is also apt-get installed on cedar-14 in the Python formula (see previous point's link for the pattern)
mkdir -p ${OUT_PREFIX}/include ${OUT_PREFIX}/lib/x86_64-linux-gnu
cp /usr/include/sqlite3*.h ${OUT_PREFIX}/include
ln -fs $(realpath /usr/lib/x86_64-linux-gnu/libsqlite3.so) ${OUT_PREFIX}/lib/x86_64-linux-gnu/libsqlite3.so

This will ensure that the libsqlite3 headers, as well as a symlink for the generic .so library (which gets resolved when compiled against) are included in the built Python tarball
Then, in bin/compile, just before pip install, we need to point the compiler infrastructure at those additional locations:

export CFLAGS="-I/tmp/libsqlite3-dev/usr/include ${CFLAGS:-}"
export LDFLAGS="-L/tmp/libsqlite3-dev/usr/lib/x86_64-linux-gnu ${LDFLAGS:-}"

This should then allow building e.g. a pysqlite dependency in requirements.txt.

Capturing for future reference:
The reason for the shift in approach is that the apt-buildpack won't load headers properly, and thus would not allow users of pysqlite or other utilities to use sqlite on runtime. We're opting to preserve this functionality instead, with added complexity as the tradeoff 🎉

Also important: the c and ld flags will not be updated in this pr, but a future one when this functionality is flipped on. That's a potentially breaking change, so slicing this up there unblocks the rest of this work without causing breakage.


Added IMO- In My Opinion in chat-acronyms

If you want to add or update an acronym
Keep in mind that the readme.md is generated. It is useless to edit it directly.
If you want to add or update an acronym, edit the correct file in the data folder
(e.g. acronyms.json)
Checklist before merging

[ ] The title says what this PR do
[ ] The description includes an issue ticket number if any
[ ] Only a json is changed if you want to add or update an acronym

IMO already exist in the acronym list. I will close this PR.


Consistency in OTel plugin names

Is your feature request related to a problem? Please describe.
Data Prepper currently have multple plugins related to OTel but we don't follow any standard naming convention.
For example, otel_trace_source and otel_metrics_source.
Also, having processor keyword in a processor plugin is redundant.
For example, otel_metrics_raw_processor
Describe the solution you'd like
All the plugins should follow a common naming convention, and we can leverage the https://github.com/opensearch-project/data-prepper/issues/2504 to make the changes without breaking anything.
Sources list,
otel_trace_source -> otel_traces
otel_metrics_source -> otel_metrics
otel_logs_source -> otel_logs
Processors list,
otel_trace_raw -> otel_traces
otel_metrics_raw_processor -> otel_metrics
service_map_stateful -> service_map
While it is allowed to have same name for a source and processor, I think it's a confusing user experience. Please comment if you have any suggestions.

@asifsmohammed , Data Prepper has two processors related to OTel traces.

otel_trace_raw
otel_trace_group

With the proposed change, it would then have:

otel_traces
otel_trace_group

This does not seem to provide any additional clarification. Can we find a better name? One that clarifies how this is different than otel_trace_group? And should we rename otel_trace_group?

@dlvenable I initially proposed changing otel_trace_raw to otel_trace_span but even that doesn't provide clarification. Looks like from the description of both the processors they do the same thing except the stateful processing. Maybe the description is inaccurate here.
otel_trace_raw - does stateful processing on extracting and filling-in trace group related fields
otel_trace_group - ills in the missing trace group related fields by looking up the OpenSearch backend
Let me know if you have any suggestions.

It seems that the difference here is between using stateful processing versus using OpenSearch? Shouldn't we reflect that in the names of the processors?

Yes we should. I don't think anyone has any ideas on the names here.


Export button feature don't work as expected

Hi,
The export button not seem to have the correct behaviour, before and after this commit : https://github.com/qlik-demo-team/qdt-components/commit/0a07c425d0df6a0e13e1e7c66c01224d388c8a6c#diff-63103223f3a15739abbf1bfb73fe645d
BEFORE (>2.5.5)
The urlFix function remove the virtual proxy.
// url = 'https://sub.domain.com/virtualproxy/tempcontent/3f34ee45-3236-4bd0-8162-3962defcd086/7714207e-274d-4284-9764-35a6c9a1f1f4.csv?serverNodeId=06a72d32-e22b-4cc6-8b0e-e58a66043bb8'
if (qViz) {
     const _options = (options) || { format: 'CSV_T', state: 'P' };
     const url = await qViz.exportData(_options);
     const _url = urlFix(url); // it removes the virtual proxy prefix :(
     window.open(_url, '_blank');
}
// _url = 'https://sub.domain.com/tempcontent/3f34ee45-3236-4bd0-8162-3962defcd086/7714207e-274d-4284-9764-35a6c9a1f1f4.csv?serverNodeId=06a72d32-e22b-4cc6-8b0e-e58a66043bb8'

AFTER (<=2.5.5)
The regex replacing the urlFix method don't work in my case.
// url = https://sub.domain.com/virtualproxy/tempcontent/3f34ee45-3236-4bd0-8162-3962defcd086/7714207e-274d-4284-9764-35a6c9a1f1f4.csv?serverNodeId=06a72d32-e22b-4cc6-8b0e-e58a66043bb8
if (qViz) {
     const _options = (options) || { format: 'CSV_T', state: 'P' };
     const url = await qViz.exportData(_options);
     const _url = url.split(/(?=http.?:\/\/)(.*)(?=http.?:\/\/)/)[2];
     window.open(_url, '_blank');
}
// _url is undefined because the array returned by the split method
// contain only one index with this regex

This is leading to open a blank page, because the url is undefined.
To Reproduce
I'm able to reproduce this bug with your html example (https://github.com/qlik-demo-team/qdt-components/blob/master/docs/usage/Html.md) and my settings
<head>
  <script type="text/javascript" src="qdt-components.js"></script>
</head>
<body>
  <qdt-component id="qdt1"></qdt-component>
</body>

<script type="text/javascript">
  var options = {
    config: {
      host: "sub.domain.com",
      secure: true,
      port: 443,
      prefix: "virtualproxy",
      appId: "70cfeb89-544b-4f35-b9f3-01197aa349ae"
    },
    connections: {
      vizApi: true,
      engineApi: true
    }
  }
  var qdtComponents = new QdtComponents(options.config, options.connections);
  var element = document.getElementById('qdt1');
  qdtComponents.render('QdtViz', {id: 'cFTyznX', height:'300px', exportData: true}, element);
</script>

I am also experiencing this issue.
Removing the Regex and just using the passed url variable seems to fix this issue

I too am experiencing this issue, trying what @Jackoc123 mentioned fixes the issues

Hello,
I'm also experiencing an issue with the export button.
The export image directs you to a blank page.
Thank you!

I had the same issue. @Jackoc123 is correct- by removing the Regexp and simply using the straight up URL resolved the problem

Is there a fix availble now


Choose how to build, use maven local or use snapshot artifacts from maven

@zelinh Can you add description to this issue?


Add Snippet Shortcut Maker

I really love creating snippets in VSCode for making my coding easier & quicker but I find the normal way of creating a snippet a little unnecessary!, having to put it all in manually & making sure it is all correct is slightly annoying. I have used extension like this but they seem to no longer work & I was wondering if there was anyway if you could implement a similar feature to VSCode or make an official extension for it.
Having the ability to just select the text you want as a snippet & then right click & select the option "Create New Snippet" & then go through the process of naming the snippet, shorcut command & description is alot easier. Any chance of this happening?
I would also just like to say thanks to everyone who works on developement of VSCode since its my go to tool for all my coding needs & makes learning code easier for me a begginer so it's greatly appreciated. Thanks

Duplicate of #26706 ?

Seems #26706 is somewhat the same idea. I will close this issue since it’s basically the same idea.


feature request : batch edit

It would be very nice to be able to easily edit several commits at once.
For example, changing the author name or email of several commits, or adding an offset to commit dates.
Also it would be convenient to use keyboard to edit timestamp (to type number into boxes).
I would like to contribute to this great but I have no idea how to implement such a feature 🙄
for now... 😄

You can already replace a name or an email with another one in ALL commits, using the "Bulk Edit" mode.
Is it what you have in mind ?

oups yes for author name/email bulk edit mode does the trick
but then I'm missing the date offset, for me, we could have a check box next to each commit line to select it and choose which value to change, and for date it could work as relative or absolute (I worked on sunday but want to move all sunday's commit on next monday morning)

Oh, I get it now, you'd like to edit multiple commits at once using check-boxes
I'll think about that

I'd love to have a bulk-edit functionality that's driven by a regular expression, or a simple "find/replace" type behavior (so I could edit every commit msg and replace bits of information with new information).
The use case I'm primarily targeting is editing Jira ticket IDs within a batch of commits. We use a pre-commit script to append a ticket ID to the beginning of every commit (based on a pattern in the branch name), and occasionally I have to move commits around between branches & different tickets, and need a way to essentially find/replace something like "XX-1234" with "XX-5678".
Interactive rebase + the --exec flag gets me pretty close, but it's still not an automatic/one-click action.


Update URL to new BrainPad Arcade page

Updated BrainPad Arcade URL to new webpage.

https://www.brainpad.com/arcade/


pkg/build: different ELF signature for equivalent kernels

Reincarnation of #1271.
Using config https://syzkaller.appspot.com/text?tag=KernelConfig&x=7dfdbc03b40f61a2
I created scripts/gcc-plugins/randomize_layout_seed.h and certs/signing_key.pem" files as pkg/build/linux.go would.
And then built as:
KBUILD_BUILD_VERSION=0 KBUILD_BUILD_TIMESTAMP=now KBUILD_BUILD_USER=syzkaller KBUILD_BUILD_HOST=syzkaller KERNELVERSION=syzkaller LOCALVERSION=-syzkaller make

Build kernel on b1e8eb11fb9cf666d8ae36bbcf533233a504c921 and dcd479e10a0510522a5d88b29b8f79ea3467d501.

Section headers:
  [Nr] Name              Type             Address           Offset
       Size              EntSize          Flags  Link  Info  Align
  [ 2] .rodata           PROGBITS         ffffffff89400000  08600000
<PHONE_NUMBER>abc60d<PHONE_NUMBER>000000  WA       0     0     4096
  [14] .data             PROGBITS         ffffffff8b000000  0a200000
<PHONE_NUMBER>ee98c0<PHONE_NUMBER>000000  WA       0     0     4096

.rodata symbols
ffffffff8af7baa8 R __stop___ex_table
ffffffff8af7bacc<PHONE_NUMBER>000018 r _note_55
ffffffff8af7bae4 R __stop_notes
ffffffff8cf59124 R __start_orc_unwind_ip
ffffffff8d5e0664 R __start_orc_unwind

for .data section I also can't figure out the changed symbol:
ffffffff8c001300<PHONE_NUMBER>000040 d channel_2ghz
ffffffff8c0045a0<PHONE_NUMBER>000008 D d_level_size_i2400m
...
ffffffff8cc44be0<PHONE_NUMBER>000010 d rate_ctrl_algs
ffffffff8cc52080<PHONE_NUMBER>000060 d _rs.1
```
These diffs seem to point into holes between symbols. I don't understand how is that possible, nor why there are these holes as well...

Trying with LD=ld.lld (LLD 12.0.0) is no better:
1,2c1,2
< .text	3f12ce9c2574c43b16e4181f2481639a9a372edc8467990ce3722743ca8314a5
< .rodata	dd98517c3ef09c5088a91b2e2f6237eb95e5d10a977ea0033dbdf935b3377740
---
> .text	bc79a929983aedaa3f742ae5886abf85b62b48b363eab438ba7c1957252a78ea
> .rodata	ebe30ad0a9b1e5b083ed7f5394988c65428b469b82fa5214de5e4c2d4104990e
23,24c23,24
< .data	48b2b5d589172cf3f543f606d2ba5b789f50c60d358d69cc2f65913ec20d81cf
< __bug_table	0ac21582eb0d90b77cf2f8958922240c477cd0c568deb192248b80f00f29e119
---
> .data	d210e54e9eba2c4268b6d32f77c267c4d4faf51d1b76cf9c79db6c2a1c4c0548
> __bug_table	557e8b814f588cd7f5c87418ab36360978dcd7378576087639c1e9ca5a325aac
31c31
< .init.text	958af1c88cc6fc08218e9bc951dec68c289ce8bbda590bf16e7955f96cac8792
---
> .init.text	63a1962a705abdc2b135ebba9dacfa121347d2b8e6ee50ec4b844851c19052fc
33c33
< .init.data	c708e310b4aa127ecd54f49d2ee986582b18f8bc82bb114d0fccd06a2036d05a
---
> .init.data	fd4fb0eea730ce6f73627e3a3d26502e327ea52960f9076e6089a55c83a92f89
40c40
< .exit.text	ef9b9052d082bfbb66acddf001f89169643ef74565c01138a6ad20b75ba13784
---
> .exit.text	ec7d0fdc1bbed246552bb2153e23e3c9c02747de7bf77247d97a785c2816d0d6
45c45
< aba7cf5bb13b7153df5df41e15d9992666d7acbdb20dd638fa488eaf90c66409
---
> 094c6bd52d76249da6c479249a682293343ec8a704020633c0b6ac610eacfd5b

This all makes me sad. One of these things we should not be spending time on at all...

Another example of non-stable build:
https://syzkaller.appspot.com/bug?extid=830c6dbfc71edc4f0b8f
"WARNING in dev_change_net_namespace" issue is detected on x86 instances, but bisected to "arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0()" which only touches arch/arm64.

I can't reproduce the previous case locally. Running:
$ syz-build -config .config -kernel_src /src/linux -trace -userspace ../.config -vm=qemu -compiler=gcc-11

Gives me on both commits:
signature: d088522a56053ecbe7df3496a2dab349e7cc16f3f46964a888288f7aa1dfaf8f
compiler: gcc version 11.2.0 (Debian 11.2.0-20), GNU ld (GNU Binutils for Debian) 2.38

And running with -compiler=gcc-8 that was used during bisection gives the following on both commits:
signature: f4af20a62e3d7c60b646135c80f6ec2a35b5fb1e4e4062e30bfa4e57598a69c0
compiler: gcc version 8.4.0 (Debian 8.4.0-7+build1), GNU ld (GNU Binutils for Debian) 2.38

However, the compiler used during bisection is 8.1.0, which is older. Maybe there were some bugs in earlier versions of gcc 8 (?). I think we need to update compiler version used during bisection to the default one after some kernel release.

Cannot reproduce with the gcc used by bisection as well. But perhaps it was fixed already. That bisection happened 2 years ago...

Another example of false positive due to changed kernel signature:
<EMAIL_ADDRESS>We bisected to:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82ede9c19839079e7953a47895729852a440080c
But this file is not even enabled in the build (CONFIG_SCSI_UFSHCD).
Yet bisect log says kernel signatures are different:
culprit signature: c1512384fd0e6d2bd48b3a1ce2034eb5c0de195562eca27cd2c0c6ac58cd4863
parent  signature: 1f86ef314029ed6e1f240aae874259f4bb0f7978f8b38b29d6c184b82965b331


@screen returns malformed css in development mode

Stack:
Tailwind 1.4.6
NextJs: 9.4.1-canary.5
I have this class defintion in my style sheet:
@tailwind base;
@tailwind components;
@tailwind utilities;
@tailwind screens;
/* ... some other classes including @apply, etc */
.filter-bar {
  top: 100px;
  @screen sm {
    max-height: calc(100vh - 100px);
  }
}

Which outputs this CSS (per chrome inspector) when in developer mode:
.filter-bar {
    top: 100px;
    @media (min-width: 640px) {;
    max-height: calc(100vh - 100px);
    }: ;
}

Note specifically @media (min-width: 640px) {;
When I build the project, the correct CSS is produced, when I run the project in development mode I get that malformed CSS. Any ideas where I could look to see what's causing the issue?
My postcss config:
module.exports = {
  plugins: [
    "tailwindcss",
    "postcss-preset-env",
    "postcss-flexbugs-fixes",
    [
      "postcss-preset-env",
      {
        autoprefixer: {
          flexbox: "no-2009",
        },
        stage: 3,
        features: {
          "custom-properties": false,
        },
      },
    ],
  ],
};

and my tailwind purgecss definition:
purge: {
    content: [
      "./pages/**/*.{js,jsx,ts,tsx}",
      "./components/**/*.{js,jsx,ts,tsx}",
    ],
    defaultExtractor: (content) => content.match(/[\w-/:]+(?<!:)/g) || [],

    // These options are passed through directly to PurgeCSS
    options: {
      whitelist: ["bg-red-500", "px-4"],
    },
  },

Thanks!

It would be great if you could share some reproducible case.
I have some projects using Tailwind and Next, using the same versions as you (except for the canary version of Next) and don't have this problem.
If you could share the content of your next.config.js file, it could help too. As you say the problem only occurs in dev mode, it could have something to do with Webpack HMR.

You need to use some sort of nesting plugin if you're going to nest your CSS like that. I thought postcss-preset-env would handle it but seems like maybe not? Also very odd that you have that plugin in your config twice?
Anyways either add a nesting plugin or rewrite your CSS like this so it's valid:
.filter-bar {
  top: 100px;
  @screen sm {
    max-height: calc(100vh - 100px);
  }
}
@screen sm {
  .filter-bar {
    max-height: calc(100vh - 100px);
  }
}


Fix retrieving weight samples.

I've found that getWeightSamples where broken. There was "java.lang.IllegalStateException: Must specify a valid bucketing strategy while requesting aggregation" error.

@13thdeus thanks


YeastPathways updated model IDs, URL comments, add BP mappings

Regen of YeastPathways models after code changes as described in https://github.com/geneontology/yeast-pathways-go-cams/pull/9.

@kltm Great, thank you! Will alert the channel when I'm about ready to go.


Local variable names shouldn't start with capital

Should be possible to catch violations with a Structural Search pattern.

@leventov, I would like to work on this. Let me know how to begin with as I'm new to making contributions. Please share any document for beginner contributors to Druid. Thanks in advance.

Hi @sashidhar, welcome to the community!
You can add LocalVariableName and LocalFinalVariableName patterns to this file: https://github.com/apache/incubator-druid/blob/master/codestyle/checkstyle.xml. Then trying to mvn install -DskipTests from the root of the project, Checkstyle will show you all violations.

@sashidhar , have you started working on this yet?

Yes, I've started working on this. I'll update once I've made code changes.
On Fri, May 17, 2019 at 11:45 AM lml2468<EMAIL_ADDRESS>wrote:

@sashidhar https://github.com/sashidhar , have you started working on
this yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-druid/issues/7609?email_source=notifications&email_token=AACGIELEUVUH57TDB74HG23PVZEQHA5CNFSM4HLJBCT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVT25RQ#issuecomment-493334214,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACGIENOJCS26HFPJCSGB2LPVZEQHANCNFSM4HLJBCTQ
.

@leventov

This is the match pattern I'm currently using for Local Variable names '^a-z_*$' considering variables starting with and ending with underscores as well. Let me know if this is fine.

There are several occurrences of variables which are not constants (i.e non static fields) which have variables all capitalized for instance,    Pattern DOT_OR_WHITESPACE = Pattern.compile("[\s]+|[.]+");    etc. I'm changing these to lower case. Is that fine ?

@leventov,

For local final variables example here http://checkstyle.sourceforge.net/config_naming.html#LocalFinalVariableName suggests names that are only upper case letters and digits "^[A-Z][A-Z0-9]*$".

As per this pattern, following variable should be changed  from
final ObjectMapper mapper = new ObjectMapper(); to
final ObjectMapper MAPPER = new ObjectMapper();
I'm not sure if this makes sense changing non static variable names to all caps !!

There are several occurrences of variables which are not constants (i.e non static fields) which have variables all capitalized for instance, Pattern DOT_OR_WHITESPACE = Pattern.compile("[\s]+|[.]+"); etc. I'm changing these to lower case. Is that fine ?

For some of these, it might be an indication that the variable was intended to be a static constant, but the original developer just forgot to include the static keyword. So I would approach these with an open mind to fixing bugs like that too, not necessarily just fixing the names to match the current state.

For local final variables example here http://checkstyle.sourceforge.net/config_naming.html#LocalFinalVariableName suggests names that are only upper case letters and digits "^[A-Z][A-Z0-9]*$".

IMO, this is silly, I don't see a reason to require this pattern. In fact, I'd be more inclined to require the opposite (local final variables should start with lowercase letters).

How do I create a pull request ? I've made changes in a local branch and unable to commit the local branch to remote. I was thinking to push local branch to remote and then raise a pull request.

@sashidhar it looks like there is a collision and @lml2468 has already solved this problem. In general, please consult to Github Help and web search to resolve such questions: https://help.github.com/en/articles/creating-a-pull-request


App versioning for master branch

The master branch should have a different version as the submission branch.

Suggestion: for the master branch, we may use 0.0.1 and when we create a new submission branch, we adjust the version for that branch.

let's do 2.


[Q] Ability to create a drop down for field values to filter based off of in HistoryTable with Custom Charts

Hi, I've been trying to see if it is possible to filter the data displayed in a custom chart based on the value present in a certain column in the historyTable using some kind of dropdown in a query. For example, if I had a historyTable with 'epoch number' as a column and values ranging from 1-10, would it be possible to add a drop down parameter where I could choose the epoch number value to display data from that particular epoch only?
My current solution is to hard code the value (say 'epoch number = 0') in the vega-lite chart definition, something like: "transform": [     {         "filter": {           "field": "epoch number",           "equal": 0       } ] . However this means I need to create a separate template for each epoch number. I was wondering if this could be interactively controlled as a slider/dropdown in the Query?
Possible leads (that I don't know how to move forward from):

It seems like what I want based on the vega-lite documentation is the ability to define a parameter. However when I add this to the chart definition on the wandb UI, no data is displayed in the chart. The code snippet goes something like:
"params": [  { "name": "epn", "value": 0,    "bind": {"input": "range", "min": 0, "max": 50, "step": 1} } ],  "transform": [  {      "filter": {        "field": "epoch number",        "equal":  #"epn"    }  },
It seems like this issue #2372  is trying to achieve a similar thing. The issue refers to a 'configurable field' which is what I think I want to achieve. The issue I think is different from this in terms of the fact that the column name remains the same for me.

Thanks in advance!

Hi @snnithya, thanks for sharing this! I just tested on my end but it seems that you can only add a slider for the step by going to the "Other Settings" section and enabling the option

But the bind option doesn't add the slider. Another way to handle this is to add an extra string parameter as a user input such as:
{
        "filter": {
          "field": "quantizer",
          "equal": "${string:quantizer_filter}"
      }
    },

So you can write the desired number without accessing the spec although you need to access the chart settings. Could you please give this a try and see if it would be useful for you?

The string parameter works perfectly! Thanks for your help :)


alias with $ breaks the plugin

Describe the bug
example:
    "paths": {
      "$styled-system/*": ["./styled-system/*"]
    }

in tsconfig.json
I think this is because of the regex you are using, need to somehow escape the dollar sign I believe.
Reproduction
cant.com
Steps to reproduce
No response
System Info
System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 100.06 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.2.0 - ~/Library/pnpm/pnpm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 120.0.6099.199
    Chrome Canary: 122.0.6232.1
    Safari: 17.2.1
  npmPackages:
    @vitejs/plugin-react: ^4.0.0 => 4.2.1
    vite: ^5.0.0 => 5.0.11
    vite-plugin-dts: 3.5.2 => 3.5.2

Validations

[X] Read the FAQ.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is where the error is coming from:
https://github.com/qmhc/vite-plugin-dts/blob/main/src/transform.ts#L131
const endSlash = matchResult[1].match(matchedAlias.find)![0].endsWith('/')

 matchResult[1].match(matchedAlias.find)! return null and [0] fails.

@qmhc
Thank you :D


markdown removed in list

Hello @tdonohue i've finished this task ✋ i will be attentive to any comments.
References

Fixes #2119

Description
Markdown is not applied in item lists.
Instructions for Reviewers

Login
Create an item with an abstract using markdown.
go to recent items section in home page.
You can see that markdown is not applied.

List of changes in this PR:

i've installed remove-markdown library which has MIT License.
I removed markdown in description section of each item.

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[ ] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

Closing as this hasn't been worked on in over a year and is outdated.  We can always reopen later as needed.


Unable to compile tests on Ubuntu 20.04 when using cppAD

I am currently using the robotology-superbuild. If I try to compile the tests on Ubuntu 20.04 I get the following error
In file included from /home/sdafarra/Software/robotology-superbuild/robotology/bipedal-locomotion-framework/src/AutoDiff/tests/CppADTest.cpp:11:
/home/sdafarra/Software/robotology-superbuild/robotology/bipedal-locomotion-framework/src/AutoDiff/include/BipedalLocomotion/AutoDiff/CppAD.h:12:10: fatal error: cppad/cppad.hpp: No such file or directory
   12 | #include <cppad/cppad.hpp>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/AutoDiff/tests/CMakeFiles/CppADTestUnitTests.dir/build.make:63: src/AutoDiff/tests/CMakeFiles/CppADTestUnitTests.dir/CppADTest.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2525: src/AutoDiff/tests/CMakeFiles/CppADTestUnitTests.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
08:59:16: The process "/usr/bin/cmake" exited with code 2.

I checked the CMake variables, and all the cppad related variables are set, including cppad_INCLUDE_DIRS.
@traversaro @GiulioRomualdi

Sorry, I had in cache the position of an old installation of CppAD that I previously removed. Cleaning the build folder did the trick.


Feature Request: Allow the --notification disclosure triangle to be optional

We're testing out the --notification feature in 2.0 Preview.3789
/Library/Application\ Support/Dialog/Dialog.app/Contents/MacOS/Dialog --notification --title "Title goes here" --subtitle "Subtitle goes here" --message "Message goes here.\nSecond line." --icon /System/Library/CoreServices/Finder.app

When the cursor hovers over the Notification, a disclousre triangle is displayed:

Clicking the disclousre triangle reveals a larger version of the icon:

Please allow the --notification disclosure triangle to be optional.

can't be done - that's how notifications work with the swiftUI framework.


Fix mta->mts rail route

This maybe isn't my fault, but minemaster is complaining you get stuck on roundabouts doing so.

I took the rail, and it isn't my fault. I contacted minemaster and told him this.


Ability to refresh PropertyFieldListPicker target site while pane is open

Category

[x] Enhancement
[ ] Bug
[X] Question

Version
[1.11.0]
Expected / Desired Behavior / Question
Is there a way to refresh/update the webAbsoluteUrl property of a PropertyFieldListPicker field while the pane is open? I have a custom string property named siteUrl which is used to populate the webAbsoluteUrl property for a list picker. When the pane opens, and the siteUrl field is populated, the list picker works.
However, when I try changing the siteUrl field, it doesn't update the list picker. I have to close the pane and reopen it. So is there a way to reinitialize the pane while open after a field changes? Basically this would work similar to a cascading drop-down, the user needs to enter a Site Url before they can access the list picker.
I've tried the following:
protected onPropertyPaneFieldChanged(propertyPath: string, oldValue: any, newValue: any): void {
  if (propertyPath === 'siteUrl' && newValue) {
    ...
    this.context.propertyPane.refresh();
  }

This is how my list picker is setup:
PropertyFieldListPicker('listSelect', {
  ...
  onPropertyChange: this.onPropertyPaneFieldChanged.bind(this),
  properties: this.properties,
  context: this.context,
  webAbsoluteUrl: this.properties.siteUrl,
})

Observed Behavior
Property pane does not refresh the context for a PropertyFieldListPicker which uses a custom webAbsoluteUrl property which is based on a string field in the property pane.

I stumble upon exactly the same. It seems that loading lists from the specified site happens only on component mount rather than when properties have been changed.

@zshane15 this would be a good update to the control. Will add it as an enhancement.

I have implemented an enhancement to the single and multi-list picker controls. Feel free to test out the latest beta. More information about how you can do this can be found here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

Thanks @estruyf the beta works great! Exactly what I needed.

Tested and works


TR: Log WARN rather than FATAL when a polling URL param isn't set

For example, deepcoveragezone.polling.url can remain unset if the CDN
operator doesn't want to use the Deep Caching feature. Rather than
logging FATAL with a stacktrace, just log it as a warning.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/983/
Test PASSed.


Make gulp useable from npm scripts

By creating npm scripts that hook up to gulp tasks users won't have to install gulp globally, e.g. npm run build-styles instead of gulp styles
The npm scripts should look something like this:
"scripts": {
  "build": "gulp",
  "build-styles": "gulp styles"
}

The script/task names should be as such

gulp -> build
gulp styles -> build-styles
gulp scripts -> build-scripts
gulp images -> build-images
gulp etc -> build-etc
gulp serve -> serve

There should also be a pre script that runs before build that runs eslint on gulpfile.js
"prebuild": "eslint gulpfile.js"

Closed by 0860976f6db0ae3972ea90da6349806be87a808d
First travis-ci build https://travis-ci.org/iron16/webnext/builds/178740108


Add CoreBot to VSIX template

Proposed Changes

Add CoreBot sample to VSIX templates
Update Readme.md file with info related to CoreBot
Also, fixes issue #1073

Testing

Open the BotBuilderTemplatesVSIX.sln in Visual Studio 2017
Once the project is loaded, rebuild it. Once the re-build process is concluded, close the Visual Studio instance.
Go to {your project path}\bin\debug folder and run the BotBuilderVSIXV4.vsix VSIX installer. Ensure that there isn't any Visual Studio instance open.
Once the installation process is concluded, open a Visual Studio 2017 instance and go to File -> new -> project and you will see the templates under the Visual C# -> Cloud -> AzureBotService category

To test it in Visual Studio 2019, open a new instance and select  Create New Project. You will see the templates in the template selection window.

@GasparAcevedoZainSouthworks Any way to clean up the simple stuff so we can figure out how to merge this in?

@cleemullins we fixed the first three issues. Regarding the fourth issue, we have the same error as you:

If you agree, we will create an Issue in this repository, but we consider that this isn't necessary due to the error message is pretty explanative.


[Feature]: Support flashdecoding++ async unified softmax

flashdecoding++ paper: https://arxiv.org/abs/2311.01282

Q3 Collaboration Plan of Infra and IaaS Labs: https://bytedance.us.larkoffice.com/docx/HKXfdRh1noMrbAxcgL2ureGasdQ

FlashDecoding++ Summary: https://bytedance.larkoffice.com/wiki/WbqXwRL3qi0x18kJVkAcU0HZnte, including Asynchronized Softmax, Double Buffering, Heuristic Dataflow, and more profiling-related optimizations.

The new kv cache memory layout and performance benchmarks is also needed.

Inference Improvement Weekly Status and Progress: https://bytedance.us.larkoffice.com/docx/RGnPdj5gfoBN3YxuY3yuLtlQsjb

Primarily related method paged_attention_v2_reduce_kernel:
https://github.com/vllm-project/vllm/blob/main/csrc/attention/attention_kernels.cu#L567

I'm taking this issue. Please add me to the organization member and this repo. Thanks.

Check different block sizes and max qk sizes.

Confirm some implementation related details:

How to check overflow, how does the overflow impact, e.g., precision or crash?
Check the usage of red_smem. Why is qk_max saved here?
Check partition>1 + 99.99% again.

Goal:

Change vllm/dattention's qk_max implementation when PARTITION_SIZE = 1
Get some perf numbers

Confirm some implementation-related details:

Check how the qk_max affects PARTITION_SIZE > 1 cases

Goal:
Change vllm/dattention's qk_max implementation when PARTITION_SIZE = 1
Get some perf numbers
Confirm some implementation-related details:
Check how the qk_max affects PARTITION_SIZE > 1 cases

dAttention's qk_max MRs were merged

Goal:

Comparing perf results (token/s): vanilla dattn vs unified qk_max dattn
Implement per-head shifting window dAttention code
Comparing rollback counts: unified qk_max dattn vs shifting window (phi) dattn

Solved the unexpected result problem by resolving some bugs and problems.
Collected rollback numbers and end-to-end perf numbers. Discussing the results.


Feature: Reoccuring Events w/ Reminders

Discord natively doesn't support the ability to create reoccurring events. Things like First Friday and various Tech Lancaster meetups could be automatically scheduled.

gay

Closing this due to Discord literally just adding an event frequency option for re-occurring events.


add requirements.txt to allow quick installation of dependencies?

This is a quick issue relating to the JOSS review comments at: https://github.com/openjournals/joss-reviews/issues/5411#issuecomment-1548163405
For development I'd usually expect to see a file containing the dependencies somewhere (e.g. requirements.txt or environment.yml). Does this exist? I see that the dependencies are listed in README.md, but it would be nice to have a file that can be used by package managers (e.g. pip, conda).

All (required and optional) dependencies are listed in pyproject.toml, and pip uses this file for installation. For example, if you want to set up your dev environment, you can do so with pip install -e ".[dev]" from the root folder of your clone, which will install all dependencies necessary for development.
I would like to avoid duplicating (and keeping in sync) requirements in a separate requirements.txt, unless there is a specific use case that is not covered by pyproject.toml – maybe you have something in mind that I'm missing?

@cbrnr you make a good point, there's no particularly strong reason to have a requirement.txt file here (I think it's just become habit to see one!).