os: TestStdPipe flake on darwin

Noticed on a trybot run:
https://storage.googleapis.com/go-build-log/0e1049fe/darwin-amd64-10_10_bc2daf40.log
--- FAIL: TestStdPipe (0.08s)
	pipe_test.go:85: unexpected exit status exit status 2 for descriptor 1s sig false
FAIL
FAIL	os	0.428s

Paging Mr. Signals, @ianlancetaylor.

This happens much more often on the new OS X 10.9 builder.
I also notice leftover spinning testprogcgo.exe processes sometimes. (Related?)

I have not been able to recreate this with gomote.  I have a theory and will send a CL, but it's just a logical guess, not something I can demonstrate will work.

Maybe fixed.


update artifacts api to v4

GitHub is deprecating v3, I think we can just update the version since we're not doing anything weird but I can't really test this without it getting pushed because we only use it for making releases

By the migration docs I think the Upload binaries task needs changing because it's currently run on all OSs, and won't modify the existing artifact now that they're immutable -- only the first one will win.
jar is fine because it's only run on ubuntu.

can't look at this anymore someone else will need to, sorry


Enhancement : Location icon in social section

I recently updated hugo academic theme on my website www.hackdown.me
and the location icon changed (all black instead of both with and black).
It now looks like this:
http://www.clipular.com/posts/5330251597742080?k=osMkAlQlb9qoCaTPbE_F0M7-jko
Could you please change it to the old one or let the user choose what we wants?

The latest master version of Academic uses the latest version of Font Awesome. Font Awesome was re-designed from scratch and the icons have all changed slightly. I forget exactly what the icon appearance was before, but you can find the new icons here if you wish to edit the code for the contact widget: https://fontawesome.com/icons?d=gallery&q=location


Feature Request: Add new settings for imported geometry

Tomb Editor allows builders to import 3D models as "Imported Geometry". In Classic engines, this feature cannot be used to its full extent as the limit of vertices per room is relatively low. In Tomb Engine, however, this limit has been removed and you are able to import more complex models. We're likely to see more and more custom levels made entirely of imported geometry.
Currently, you have to choose a lighting mode:

The feature seems a little incomplete (or not suitable for every workflow), as every mode overwrites the others. You can't have, for example, vertex colors+room lights. A net improvement would be to allow all kinds of combinations:

Sorry, I should have posted this in Tomb Editor repository insteas


Insert template in different element (component)

Hi. I would like to insert the template of a component in a different element but maintain the components tree structure. To be more precise, I have a component (bootstrap modal) which is rendered in the middle of the html content. Now the problem is that the styles of the modal inherits from parent, so what I want to archive is to have my component right there but the template to be inserted just before body end tag
I have tried to put a basic example here and I can't get it working: https://jsfiddle.net/fkm1qtb1/2/ . As you can see, the text is red because the parent element has that color which applies on children too. So I want the template to be inserted on a custom element that is not affected by the color (on this example)
Is this possible, I'm doing something wrong ?
Thanks.

What you seem to be trying to achieve may be to use slots to distribute the content.  http://vuejs.org/examples/modal.html
Through your reproduction you can inspect the result and see that the content is actually being passed to the components body.

@yyx990803
On a side note,  perhaps a feature implementation for vm.$slots could be useful to aid in content distribution via js.
Reasons for this could be to provide a single modal component instance to the DOM. This way we could dispatch events with content,  for the component or use Vuex to manage state for the component and its content distribution.
This will help prevent cases of two way binding and possible code duplication.

@blake-newman it's on the roadmap: https://github.com/vuejs/vue/issues/1726

@yyx990803 So it is didn't see the issue.

@blake-newman thanks for your answer. Actually I want the content to be distributed outside of the component. For example:

    <component-parent>
        <component-child-modal></component-child-modal>
   </component-parent>

So, what I want is that component-child-modal template to be inserted into modal-content div. Is that possible ?

https://github.com/rhyzx/vue-transfer-dom

thanks @vuchl . Looks like is what I'm looking for! I will give it a try.

@geodeveloper this is not a feature that will be supported in Vue itself, but yeah the 3rd party solution could work.

@yyx990803 ok, though it will be nice to have something like that built-in, there are a lot of cases where you need to have the component mounted on different element outside of component.
@vuchl I tried that plugin and works as expected! Thanks again.

You can do this:
mounted: function() {   document.body.appendChild(this.$el); }
The component html is moved as expected, at least for me it worked hahah.

I have created a Vue2 compatible v-transfer-dom directive at https://github.com/tmorehouse/vue-transfer-dom


[Backport 2.x] cypress | create detector specs update (#518)

Description
Backport #518 to 2.x branch
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #577 (3cce573) into 2.x (f93dfe0) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##              2.x     #577   +/-   ##
=======================================
  Coverage   32.66%   32.66%
=======================================
  Files         135      135
  Lines        4020     4020
  Branches      697      649   -48
=======================================
  Hits         1313     1313
  Misses       2567     2567
  Partials      140      140

see 2 files with indirect coverage changes


add Mentors schema

I updated the types and added the "topics" category to the scheme

@hercase LGTM! 🚀


let custom props pass

This is in parity with the server side PR https://github.com/segment-integrations/integration-klaviyo/pull/11
Letting custom props pass through. The Js library uses the same http api so I am just doing the same thing here as the implementation of the server side PR.
@segment-integrations/core

LGTM


Masking is too complex

Hi there, from time to time I want to use a mask for my sprites. Which is only possible with shaders or (mis)using the light2D node.
Every time I want to implement a mask, I have to crawl the whole web to get to a solution. One response is "Just write a shader" but honestly, it's not "just" write a shader. Its: I have to put more work than expected into a very common problem by writing a shader :)
On the other side is the light2D method where you can use the "mask" property, which does not work at all. You have to use the "mix" property and add a canvas material to the masked sprites.
This is more than unintuitive and makes me crasy cause of this feeled randomness of masking an area. You can see this in this example: https://godotengine.org/asset-library/asset/115
So this is a feature proposal for a Mask node.
The handling of that should be simple. One good way is the Item Cull Mask of the light2D. If it matches with another node, then the mask is applied. Also, would it be great if sprites and colored rects which are children of that Mask node are treated as the texture. So the mask ist more flexible.
It is realy unexpecting complex to mask some nodes in Godot. Or did I just miss the "Just drag that shape and its done" somewhere?^^

Yeah something simple and easy to setup for masking 2D textures would be very useful.  Such as electing to mask one sprite to another, so you could visually drag it around in the editor and visual the result immediately.
I bump into this often enough, and as you say, it is a chore every time.  During which, I reflect often about the ease of masking operations in all the other software I use.

I would go with just adding a "Mask" mode to all CanvasItem making them modulate things in the same Z, relative to parent.
This way we could use Polygon2D, Sprites and even Line2D or Buttons to mask.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

For the record, this was already implemented in the master branch for 4.0 via CanvasItem clipping: https://github.com/godotengine/godot/pull/43167


Don't show Nukeops text when no nukies

About the PR

The  The operatives were: text always showed up even if there were no nukies.
Why / Balance

Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

this is also getting fixed in #25786

this is also getting fixed in #25786

will just use that pr then.


fix(Text): show tooltip on ellipsis only when needed

Summary
Type

Bug

Summarise concisely:
What is expected?
When using oneLine prop in Text it was using tooltip on hover even when not needed. I fixed it.
Relevant logs and/or screenshots
Before:
https://user-images.githubusercontent.com/15812968/211562821-fc998b9d-85cf-4aad-b0e8-dd1b6edc04e5.mov
After:
https://user-images.githubusercontent.com/15812968/211562889-440eae96-a8ae-48d2-8ac7-999a365ed0be.mov

I think we should also be able to always have a tooltip, even when the text isn't truncated.

I think we should also be able to always have a tooltip, even when the text isn't truncated.

@QuiiBz Why is that? If you need a tooltip you can wrap your Text component into a Tooltip 😄

Yes never mind you're right :)


Unknown parameter 'averageImage'

Hi, I encountered an error problem when I run the 'train_id_net_res_market_new.m' file.
The error displayed that
"
Error using vl_argparse (line 128)
Unknown parameter 'averageImage'
Error in vl_argparse (line 97)
opts = vl_argparse(opts, vertcat(params,values), varargin{:}) ;
Error in cnn_train_dag (line 47)
opts = vl_argparse(opts, varargin) ;
Error in train_id_net_res_market_K_1 (line 37)
[net,info] = cnn_train_dag(net, imdb, @getBatch,opts) ;"
Could you tell me how to fix it in your spare time? Thanks again for your kindness.

You may check two place.

In my training code, I defined the value of average image (I just calculated the mean of RGB channels)
https://github.com/layumi/Person-reID_GAN/blob/master/train_id_net_res_market_K_1.m#L16
In  cnn_train_dag, there should be an empty value pre-defined. So we call this function and put our value into it.
https://github.com/layumi/Person-reID_GAN/blob/master/examples/cnn_train_dag.m#L16

Help it can help you.

I've solved my problem. Thank you for you reply.


Prompt caching causes reproducible outputs to be inconsistent

What is the issue?
When trying to generate reproducible outputs, changing prompts causes results to be inconsistent
OS
No response
GPU
No response
CPU
No response
Ollama version
No response

Fixed by https://github.com/ollama/ollama/pull/4986


Segmented Control

Hi, I'm facing an issue with segmented control, it was ok but 2 months later it shows me this error after updating the package and flutter:
file:///C:/src/flutter/packages/flutter/lib/src/cupertino/segmented_control.dart:106:10
..\…\cupertino\segmented_control.dart:106
groupValue == null || children.keys.any((T child) => child == groupValue)
"The groupValue must be either null or one of the keys in the children map."
The relevant error-causing widget was:
FormBuilderSegmentedControl
Flutter : 3.3.4
Package: 7.7.0

@PRQAE Could you kindly include your code if possible?
From what I can deduce from the message, it seems like an assertion warning. It seems the value you've set as your initial value is not part of the list of items available for selection.


Prisma Init exiting without errors before finishing

Bug description
When running Prisma Init on windows 11 the command starts to run and when the Downloading Prisma engines for Node-API for windows progess reaches about 60% it silently exits with no error codes, and when trying in WSL it does the same thing and echo $? reports exit code 0.
Manually downloading the binaries and placing them in the correct location causes it to finish correctly.
The same thing happens in WSL2 - Ubuntu 22.04.2 LTS, Command Prompt and Powershell
I also tried it with both Windows Firewall and Defender disabled and it still silently exited.
Package.json:
{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "prisma": "^5.3.1"
  }
}

Node -v:
C:\Users\garre\WebstormProjects\API>node -v
v18.14.1

C:\Users\garre\WebstormProjects\API>

NPM -v:
C:\Users\garre\WebstormProjects\API>npm -v
9.5.0

C:\Users\garre\WebstormProjects\API>

Debug Log:
C:\Users\garre\WebstormProjects\API>DEBUG="*" npx prisma init
  prisma:fetch-engine:download  file<EMAIL_ADDRESS>does not exist and must be downloaded +0ms
  prisma:fetch-engine:download  file<EMAIL_ADDRESS>does not exist and must be downloaded +2ms
  prisma:fetch-engine:download  https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/query_engine.dll.node.gz will be downloaded to<EMAIL_ADDRESS>+1ms
  prisma:fetch-engine:download  https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/schema-engine.exe.gz will be downloaded to<EMAIL_ADDRESS>+2ms
  prisma:fetch-engine:download  Downloading https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/query_engine.dll.node.gz to<EMAIL_ADDRESS>... +1ms
> Downloading Prisma engines for Node-API for windows [                    ] 0%  prisma:fetch-engine:download  Downloading https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/schema-engine.exe.gz to<EMAIL_ADDRESS>... +54ms
> Downloading Prisma engines for Node-API for windows [============        ] 61%
C:\Users\garre\WebstormProjects\API>

How to reproduce

Create new Project
Install Prisma with npm install prisma --save-dev
Run npx prisma init
Prisma exits at around 60%

Expected behavior
Prisma to fully initialise
Prisma information
Prisma Doesnt Initialise due to bug
Environment & setup

OS: Windows 11 Home

Database: PostgreSQL 14.9 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924, 64-bit

Node.js version: v18.14.1

Prisma Version
Doesnt finish running due to bug.

@DAHPr0gram3r Could you try again with this command and share the output logs?
set DEBUG=* && npx prisma -v

Also, could you check that you have some free disk space on that disk partition just in case?

Ok im so confused its worked now i did try npx prisma -v yesterday with DEBUG=* set and it did the same thing as npx prisma init where it would just silently exit and provide simlar output with DEBUG=* set. Nothing has changed on my end as far as I'm aware the only thing that could have happened that could even remotely effect it is my PC locked and went to sleep.
Output:
  prisma:engines  binaries to download libquery-engine, schema-engine +0ms
  prisma:fetch-engine:download  file<EMAIL_ADDRESS>does not exist and must be downloaded +0ms
  prisma:fetch-engine:download  file<EMAIL_ADDRESS>does not exist and must be downloaded +1ms
  prisma:fetch-engine:download  https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/query_engine.dll.node.gz will be downloaded to<EMAIL_ADDRESS>+1ms
  prisma:fetch-engine:download  https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/schema-engine.exe.gz will be downloaded to<EMAIL_ADDRESS>+3ms
  prisma:fetch-engine:download  Downloading https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/query_engine.dll.node.gz to<EMAIL_ADDRESS>... +1ms
> Downloading Prisma engines for Node-API for windows [                    ] 0%  prisma:fetch-engine:download  Downloading https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/schema-engine.exe.gz to<EMAIL_ADDRESS>... +87ms
  prisma:loadEnv  project root found at C:\Users\garre\Documents\Test\package.json +0ms
  prisma:tryLoadEnv  Environment variables not found at null +0ms
  prisma:tryLoadEnv  Environment variables not found at undefined +1ms
  prisma:tryLoadEnv  No Environment variables loaded +0ms
prisma                  : 5.3.1
@prisma/client          : Not found
Current platform        : windows
Query Engine (Node-API) : libquery-engine 61e140623197a131c2a6189271ffee05a7aa9a59 (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 61e140623197a131c2a6189271ffee05a7aa9a59 (at<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.3.1-2.61e140623197a131c2a6189271ffee05a7aa9a59
Default Engines Hash    : 61e140623197a131c2a6189271ffee05a7aa9a59
Studio                  : 0.494.0

And its doing it again
set debug=* && npx prisma -v  output:
C:\Users\garre\WebstormProjects\API>set DEBUG=* && npx prisma -v
  prisma:engines  binaries to download libquery-engine, schema-engine +0ms
  prisma:fetch-engine:download  file<EMAIL_ADDRESS>does not exist and must be downloaded +0ms
  prisma:fetch-engine:download  file<EMAIL_ADDRESS>does not exist and must be downloaded +1ms
  prisma:fetch-engine:download  https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/query_engine.dll.node.gz will be downloaded to<EMAIL_ADDRESS>+2ms
  prisma:fetch-engine:download  https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/schema-engine.exe.gz will be downloaded to<EMAIL_ADDRESS>+1ms
  prisma:fetch-engine:download  Downloading https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/query_engine.dll.node.gz to<EMAIL_ADDRESS>... +0ms
> Downloading Prisma engines for Node-API for windows [                    ] 0%  prisma:fetch-engine:download  Downloading https://binaries.prisma.sh/all_commits/61e140623197a131c2a6189271ffee05a7aa9a59/windows/schema-engine.exe.gz to<EMAIL_ADDRESS>... +87ms
> Downloading Prisma engines for Node-API for windows [============        ] 60%

Hey @DAHPr0gram3r, could you please provide us with a reproduction? Without it, we have no chances of reproducing your issue and will eventually have to close it. Could you please help us with that? Thanks. Perhaps what you could try next is to run this in docker container in WSL 2.

Hey @DAHPr0gram3r  ,
Did you get a chance to have a look at @millsp  comment? It'd be helpful for us to move your issue forward.
Without further information, we'll have to close this issue. Thank you 🙏

As we've tried to reach @DAHPr0gram3r twice without success, we're now closing this issue.
Please leave a comment below with a reply to this message if you see this issue, and we'll reopen it. Thanks!

I'm seeing the identical behaviour - could you please share the solution?


enable suffix for generated members

Hi, can you provide some example / your use case?

we put “View” after fieldName. For example, mNameView means it is a view, but mName usually is a String.

OK, that's a valid request. We will accept a pull request for this.

I guess the best approach might be not to add another field
but to replace prefix setting with more complex format string.
Anyone could then specify format of the field names with format strings like:
"v${ID}", "m${ID}View", "m${ID}${TYPE}"
Where ${ID} would correspond to view id transformed to CamelCase.
Variable ${TYPE} would be a simple class name.

There is a lot of place in settings, one more field would be OK and more user-friendly IMHO. But both would work.


TEVA-2090 - Rename StatusCake tests

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-2090
Changes in this PR:

Use the StatusCake website_name field to distinguish between the 3 checks we use

Review app deployed to https://teaching-vacancies-review-pr-2949.london.cloudapps.digital


Convert binary attributes into rich numericals

Ref https://github.com/mapbox/gabbar/issues/43

In https://osmcha.mapbox.com/47414802/, a place=village was converted to place=town.

At present, the context we give the machine learning model about this modification is along with other attributes are:

place: 1
place_old: 1
place_modification: 1
harmful = 1

But, the model has no knowledge on what the modification was to make an effective prediction on whether the feature modification was a 👍 or a 👎. So, how about we convert the binary value representing the modification into better numerical's to aid the model to make a more informed decision.
Popularity from TagInfo
TagInfo provides values for what percentage of place features have say a city as the value. Ex: 0.43% of all place objects on OpenStreetMap are place=city. With this, the model will currently get the following attributes:

place_new: 24.92% - Percentage of place=village
place_old: 2.21% - Percentage of place=town

cc: @batpad @geohacker

We now have percentages from TagInfo as values. Ex:

tourism tag in newVersion of feature has value which 5.54% of tourism features have in OSM
boundary tag in oldVersion of feature has a value which 89.37% of boundary features have


khashier displays this transaction incorrectly

See http://khashier.com/tx/24acea41498b2f387ff751997f8dc90a4551f7b638e7cfc00750a9966f3bc018
It says the fee is -3.9961 when it was really 0.0039.
It says it has 839 outputs when it really has 838.
It lists one of the outputs twice, with two different 'spent' links:
http://khashier.com/tx/5d46a5d2596e41b3f42c161a362532ce82a54c599b2fb5e75e153aa941acb553
http://khashier.com/tx/53a63ff503e39486cafc279d4ae3feabbbaf539c396404c1fff4ad70512244dd
The 'output' link in both of the above points at http://khashier.com/tx/24acea41498b2f387ff751997f8dc90a4551f7b638e7cfc00750a9966f3bc018#o465
The output in question staked twice, but one of them was orphaned.

The bug is more obvious here, where the fee is off by around 2000 CLAMs:
http://khashier.com/tx/3423091ad3e4dbb17822baeeae773dc9741995a3db9b9ce77732167f8e9a1913

I just noticed it again:
http://khashier.com/tx/f1cad229a6fbe5765e854ac194f892049c9af8528d93d7c64145326a9d27b22d


wfst decoder adaptation

wfst decoder or beam search decoder should be chosen at the decoding config part

@godjealous @tjadamlee @Some-random wfst decoder adaptation for transformer which is runnable has been committed and need to be checked


Improve DoubleInt (or integer literal) performance

So I wanted to see the difference (#31) makes on DoubleInt, and the difference is great. After that, I compared it against my predecessor project and that one still perform divisions faster. Zzz. I haven't gotten around to optimizing the new abstraction yet, although (#31) is a step in the right direction.

Edit: Ultimathnum.U256 is faster if I set its integer literal to Int.

final class Benchmarks: XCTestCase {

    /// Takes `0.358 seconds` on MacBook Pro, 13-inch, M1, 2020.
    func testNumberick256() {
        let a: UInt256 = "58472848379039952684853851736901133239741266891456844557261755914039063645794"
        let b: UInt256 = "94611056096305838013295371573764256526437182762229865607320618320601813254535"

        for _ in 0 ..< 369 * 100 {
            var lhs = blackHoleIdentity(a)
            var rhs = blackHoleIdentity(b)
            var counter = 0

            dividing: while !rhs.isZero {
                counter += 1
                (lhs, rhs) = (rhs, lhs.remainderReportingOverflow(dividingBy: rhs).partialValue)
            }

            precondition(lhs == 1)
            precondition(rhs == 0)
            precondition(counter == 369)
        }
    }

    /// Takes `1.665 seconds` on MacBook Pro, 13-inch, M1, 2020
    /// Takes `0.881 seconds` on MacBook Pro, 13-inch, M1, 2020 + pointer-bit shifts
    /// Takes `0.308 seconds` on MacBook Pro, 13-inch, M1, 2020 + pointer-bit shifts + pointer-bit literal
    func testUltimathnum256() {
        let a = U256("58472848379039952684853851736901133239741266891456844557261755914039063645794")!
        let b = U256("94611056096305838013295371573764256526437182762229865607320618320601813254535")!

        for _ in 0 ..< 369 * 100 {
            var lhs = blackHoleIdentity(a)
            var rhs = blackHoleIdentity(b)
            var counter = 0

            dividing: while !rhs.isZero {
                counter += 1
                (lhs, rhs) = (rhs, lhs.remainder(Divisor(unchecked: rhs)))
            }

            precondition(lhs == 1)
            precondition(rhs == 0)
            precondition(counter == 369)
        }
    }
}

The euclidean algorithm is probably not the best thing to benchmark given that the quotient is always small, but meh. I just defaulted to some fibonacci thingy in a hurry, because why not?

Ultimathnum.UXL is a bit faster than Numberick.UIntXL, however :smiley:

I profiled it and discovered that it's integer literal that's slow. Lmao. :rofl:

A) Swift.Int literal takes it to ~300ms.
B) RootInt/entropy() <= IX.size fast path takes it to ~400ms.

I suppose another way of solving is by meticulously calling single element initializers instead of using integer literals, but that would be like a downgrade in terms of ergonomics. It's just too silly that some integer literals resolve at runtime.

Turns out that there's still some division to make too. Instead of:
normalization.value >= Base.size // normalization is Shift<Self>

I can guard-cast it to a half shift and use the half-shift methods:
guard let normalization = Shift<Base>(exactly: normalization.value) else { ... }

Also, I haven't even implemented two-way comparisons yet. It's all three-way still.

Hm. I can get to ~340ms by writing extensions like: init(load: 1 as Element.Magnitude).

I changed the integer literal type to Element.IntegerLiteralType for the time being.


Is there anyway to fix the tabline tab width?

I just have a question about tabline tab width. Is there any option to fix the tab width? If the name is too long, show only a few words.

can you be more specific about tabline tab width ?

can you be more specific about tabline tab width ?

Yes, I put the picture to describe it better.

ah, I see what you mean. I think you can either define your own formatters, like mentioned in the help: https://github.com/vim-airline/vim-airline/blob/ddaf69804aeb1ea7f26cfe0517b8d6f092ab1caf/doc/airline.txt#L1239-L1248
or use one of the existing formatters, like unique_tail, unique_tail_improved or short_path as mentioned in the help: https://github.com/vim-airline/vim-airline/blob/ddaf69804aeb1ea7f26cfe0517b8d6f092ab1caf/doc/airline.txt#L1270-L1293

Got it. Thank you for your explanation. :)

I'm sorry to bother you, but vim script is my first time writing. I wrote the code in my airline.vim file.
let g:airline#extensions#tabline#enabled = 1
" let g:airline#extensions#tabline#formatter = 'unique_tail'
let g:airline#extensions#tabline#tab_nr_type = 1
let g:airline#extensions#tabline#show_buffers = 0
let g:airline#extensions#tabline#show_close_button = 0
let g:airline#extensions#tabline#show_splits = 0

function MyTabTitleFormatter(n)
  let buflist = tabpagebuflist(a:n)
  let winnr = tabpagewinnr(a:n)
  let bufnr = buflist[winnr - 1]
  let winid = win_getid(winnr, a:n)
  let title = bufname(bufnr)

  " I don't know how to call this function from here, could you please review it?
  let unique_tail_title = airline#extensions#tabline#formatters#unique_tail#format(a:bufnr, a:buflist)

  if strlen(unique_tail_title) > 15
    unique_tail_title = unique_tail_title[-15:]
  endif

  return unique_tail_title
endfunction

let g:airline#extensions#tabline#tabtitle_formatter = 'MyTabTitleFormatter'

Could you check what is wrong with this code? I want to get the title from airline#extensions#tabline#formatters#unique_tail#format function and split the string if the title length is longer than 15.

I figured it out. Thanks.


FTP Listener should pass ftp:Client as an argument

In order to do something meaningful with FTP listener you have to do the following.
ftp:ClientConfiguration sftpClientConfig = {
    protocol: ftp:SFTP,
    host: "localhost",
    port: 21213,
    auth: {
        credentials: {username: "wso2", password: "wso2123"},
        privateKey: {
            path: "../resources/keys/sftp.private.key",
            password: "changeit"
        }
    }
};

ftp:Client sftpClient = check new(sftpClientConfig);

listener ftp:Listener secureRemoteServer = check new({
    protocol: ftp:SFTP,
    host: "localhost",
    auth: {
        credentials: {
            username: "wso2",
            password: "wso2123"
        },
        privateKey: {
            path: "../resources/keys/sftp.private.key",
            password: "changeit"
        }
    },
    port: 21213,
    path: "",
    pollingInterval: 2,
    fileNamePattern: "(.*).csv"
});

service "ftpServerConnector" on secureRemoteServer {
    function onFileChange(ftp:WatchEvent event) {
        ftp:Client sftpClient = check new(sftpClientConfig);
        stream<byte[] & readonly, io:Error?>|error fileStream = sftpClient->get(fileName);
    }
}

You always have to create the ftp:Client by duplicating the configurations given to the listener. This can be easily avoided. If we pass the ftp:Client as an argument.
function onFileChange(ftp:Client client, ftp:WatchEvent event) {}

Proposal for this feature can be found here

It was decided to add ftp:Caller instead of ftp:Client


Our links to angular.io are broken

Since the new version of Angular.io, our links to the style guide are broken. For instance, https://angular.io/styleguide#!#05-12 becomes https://angular.io/guide/styleguide#style-05-12 .
I can fix them for the next version.

I will hold the release until we fix them.


python310Packages.omnikinverter: 0.8.1 -> 0.9.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.omnikinverter is: Python module for the Omnik Inverter
meta.homepage for python310Packages.omnikinverter is: https://github.com/klaasnicolaas/python-omnikinverter
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.0 with grep in /nix/store/6r5rq1q4kxi1y80g38ai2pbnxj22zfv6-python3.10-omnikinverter-0.9.0
found 0.9.0 in filename of file in /nix/store/6r5rq1q4kxi1y80g38ai2pbnxj22zfv6-python3.10-omnikinverter-0.9.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.omnikinverter
python311Packages.omnikinverter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6r5rq1q4kxi1y80g38ai2pbnxj22zfv6-python3.10-omnikinverter-0.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.omnikinverter https://github.com/r-ryantm/nixpkgs/archive/aad26c83ce4097c12ddc22591b335a05f457787d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6r5rq1q4kxi1y80g38ai2pbnxj22zfv6-python3.10-omnikinverter-0.9.0
ls -la /nix/store/6r5rq1q4kxi1y80g38ai2pbnxj22zfv6-python3.10-omnikinverter-0.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.omnikinverter

1 package built:

python310Packages.omnikinverter

Maintainer pings
cc @fabaff for testing.

Python 3.11 support: https://github.com/klaasnicolaas/python-omnikinverter/pull/305


When starting the app the first time without internet, it crashes

Describe the bug
In the main method, await getFont() is run before the call to runApp is made and control is handed to Flutter. When there's no internet, the await getFont() fails with a SocketException and the app doesn't start.

Addressing Issue #62.

Closed via #64


Failed to select an OpenTelemetry Collector instance for pod's sidecar

Component(s)
operator
Describe the issue you're reporting
We'd deployed recently OT into our AKS cluster and are now trying to use auto instrumentation but the operator always throws the below error:
{"level":"error","ts":"2024-01-19T10:32:29Z","msg":"failed to select an OpenTelemetry Collector instance for this pod's sidecar",
"namespace":"opentelemetry",
"name":"platform-samples-api-2",
"error":"no OpenTelemetry Collector instances available",
"stacktrace":
"github.com/open-telemetry/opentelemetry-operator/pkg/sidecar.(*sidecarPodMutator).Mutate
/home/runner/work/opentelemetry-operator/opentelemetry-operator/pkg/sidecar/podmutator.go:84\ngithub.com/open-telemetry/opentelemetry-operator/internal/webhook/podmutation.(*podMutationWebhook).Handle
/home/runner/work/opentelemetry-operator/opentelemetry-operator/internal/webhook/podmutation/webhookhandler.go:92\nsigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).Handle
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/webhook/admission/webhook.go:169\nsigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP
/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/webhook/admission/http.go:98\nsigs.k8s.io/controller-runtime/pkg/webhook/internal/metrics.InstrumentedHook.InstrumentHandlerInFlight.func1
/home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/promhttp/instrument_server.go:60\nnet/http.HandlerFunc.ServeHTTP
/opt/hostedtoolcache/go/1.21.5/x64/src/net/http/server.go:2136\ngithub.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerCounter.func1
/home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/promhttp/instrument_server.go:147\nnet/http.HandlerFunc.ServeHTTP
/opt/hostedtoolcache/go/1.21.5/x64/src/net/http/server.go:2136\ngithub.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2
/home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/promhttp/instrument_server.go:109\nnet/http.HandlerFunc.ServeHTTP
/opt/hostedtoolcache/go/1.21.5/x64/src/net/http/server.go:2136\nnet/http.(*ServeMux).ServeHTTP
/opt/hostedtoolcache/go/1.21.5/x64/src/net/http/server.go:2514\nnet/http.serverHandler.ServeHTTP
/opt/hostedtoolcache/go/1.21.5/x64/src/net/http/server.go:2938\nnet/http.(*conn).serve
/opt/hostedtoolcache/go/1.21.5/x64/src/net/http/server.go:2009"}

We used HELM chart 0.45.2 for the deployment with operator version 0.92.0. As we are in AKS we modified clusterrole.yaml template as  this was also needed, and added:
- apiGroups:
      - rbac.authorization.k8s.io
    resources:
      - clusterroles
      - clusterrolebindings
    verbs:
      - get
      - list
      - watch

Value file has the only modification as below:
autoInstrumentationImage:
  python:
     repository: "otel/autoinstrumentation-python"
        tag: ""
  dotnet:
     repository: "otel/autoinstrumentation-dotnet"
        tag: ""

And also deployed a collector-contrib instance with HELM using chart 0.78.0 and appVersion 0.92.0 as statefulset.
Currently the whole deployment looks like this:
$ kubectl get all
NAME                            READY   STATUS    RESTARTS   AGE
pod/collector-0                 1/1     Running   0          29s
pod/operator-65c799c7c8-kwqtz   2/2     Running   0          2m52s

NAME                                   TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)             AGE
service/collector                      ClusterIP   <IP_ADDRESS>   <none>        4317/TCP,4318/TCP   3d7h
service/operator                       ClusterIP   <IP_ADDRESS>   <none>        8443/TCP,8080/TCP   2m52s
service/operator-webhook               ClusterIP   <IP_ADDRESS>    <none>        443/TCP             2m52s
service/platform-samples-api-service   ClusterIP   <IP_ADDRESS>   <none>        80/TCP,443/TCP      13h

NAME                       READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/operator   1/1     1            1           2m53s

NAME                                  DESIRED   CURRENT   READY   AGE
replicaset.apps/operator-65c799c7c8   1         1         1       2m53s

NAME                         READY   AGE
statefulset.apps/collector   1/1     3d7h

And with the sample application has the annotation sidecar.opentelemetry.io/inject: 'true' yet we get the above error.

That error message implies you have an annotation somewhere like sidecar.opentelemetry.io/inject: "true" - the error is about the Collector sidecar not auto-instrumentation.  The annotation only works with a OpenTelemetry Collector custom resource, not a collector installed by the helm chart.


fbb: Support yet another undocumented date header layout (2006-01-02 15:04)

I've encountered yet another undocumented date header layout while playing around with winlink's Radio Only network.
The original message was sent with RMS Express to LA3F X-Rms-Originator: LA3F.
When downloaded via LA3F (one of my pickup points), the Date format was YYYY.MM.DD HH:MM. This is the previously seen undocumented/incorrect layout seen earlier (https://github.com/la5nta/wl2k-go/issues/29).
When downloaded via SM5RVH running RMS Relay-<IP_ADDRESS>, the date header was encoded using the layout YYYY-MM-DD HH:MM.
We need to support decoding messages with this layout. I really hope WDT will fix their code and/or the specification some day(!!).

For the record:

The Date: field is the UTC date and time the message was originated and is in the format YYYY/MM/DD HH:MM.

http://winlink.org/b2f

The complete path of the message:
X-Rms-Path: LA3F@2016-06-26-08:44:04 PA3GJM@2016-06-26-08:49:20 SM5RVH@2016-06-26-08:56:56


Update get started doc for RLC and DPG

Update get started doc for RLC and DPG

/check-enforcer override

/check-enforcer override


Support for AzureRM >= 4.0

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Would like to use this module, but with the Azurerm provider >= 4.0
New or Affected Resource(s)/Data Source(s)
terraform-azurerm-avm-res-storage-storageaccount module
Potential Terraform Configuration
No response
References
No response

@tparvu Thank you for reaching out. We are planning to upgrade this module to version 4.0 in the near future. Therefore, this issue will remain open.

Here are similar changes in other AVMs if that could be helpful:

https://github.com/Azure/terraform-azurerm-avm-res-cognitiveservices-account/issues/61
https://github.com/Azure/terraform-azurerm-avm-res-managedidentity-userassignedidentity/issues/52

Any updates for this ticket? It's getting really awkward that some modules can work with version  4, some can't, some can do both,...
I'm expecting an update with a bugfix on another module that only supports 4 from now on, so I won't be able to profit from the bugfix because I'm using this module as well...

Any luck on this ticket please? I am using storage account for flow logs and  I am planning to use virtual network flow logs instead of NSG flow logs and the provider from 4.11.0 onwards supports this.

I've posted a PR in #198 with the minimum changes required to support AzureRM v4 - I have purposefully made the smallest possible change possible, whilst removing any deprecation warnings.
The module retains compatibility with v3 as well, I can see any breaking changes that are relevant, only deprecated parameters noted in the upgrade guide, which were not being used anyway.
Linting, docs, grept-apply all pass, & pre-commit all look good to me.  I haven't run E2E tests but don't see why they should break.


[3.3] Bugfix: Add missing plan version increments in repair-distributeShardsLike

Changes backported from #5649, plus fix of js/server/tests/resilience/repair-distribute-shards-like-spec.js.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/393/

There seems to be a red test in jenkins.
I think it is unrleated. Do you agree?

@mchacki I agree, this should be unrelated.


🍞 Object / commit data traversal helpers

it would be cool to have something like the js object loader but a lil more featured and fun/easy to use for traversing, filtering, inspecting objects

should be fixed by traversal implementation


Code enhanced with some bug fixes

Coverage decreased (-0.8%) to 13.466% when pulling ae5eecfa3dc30e669acdd77c7f9e04f3d77eb2d5 on vidyasagar-r:enhancements_branch into f461ef706cb11a917d14cce1d17e3a2f4256bcdb on MicroPyramid:master.


Improve persistence test

Why?
We faced a regression in XMLNode serialization, which the original test did not capture.
What?
This PR changes the test to check if the body of the kitchen-sink is unaffected by saving and loading.

Codecov Report

Merging #521 into master will decrease coverage by 1.58%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
- Coverage   59.11%   57.53%   -1.59%
==========================================
  Files         174      174
  Lines        4075     4076       +1
==========================================
- Hits         2409     2345      -64
- Misses       1666     1731      +65

Impacted Files
Coverage Δ

src/editor/util/TOCProvider.js
48% <100%> (-8.76%)
:arrow_down:

...rc/editor/commands/SchemaAwareToggleListCommand.js
26.66% <0%> (-66.67%)
:arrow_down:

src/editor/commands/InsertXrefCommand.js
0% <0%> (-60%)
:arrow_down:

src/editor/commands/TableCellCommand.js
40% <0%> (-50%)
:arrow_down:

src/editor/util/FootnoteManager.js
57.14% <0%> (-42.86%)
:arrow_down:

src/editor/util/FigureManager.js
66.66% <0%> (-33.34%)
:arrow_down:

src/editor/commands/InsertInlineFormulaCommand.js
0% <0%> (-32%)
:arrow_down:

src/editor/commands/IncreaseHeadingLevelCommand.js
33.33% <0%> (-19.05%)
:arrow_down:

src/editor/commands/DecreaseHeadingLevelCommand.js
33.33% <0%> (-19.05%)
:arrow_down:

src/editor/util/xrefHelpers.js
43.58% <0%> (-12.83%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3e411...2e2e6b2. Read the comment docs.


Update logic-apps-overview.md

The difference between two solutions haven't been mentioned anywhere in the documentations (AFAIK). The preceding question and its linked article doesn't address it either. I've added a new FAQ to inform readers about their options.

@ecfan
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Left feedback revisions to make.

Thanks for suggestion. Committed the change.

#sign-off


Dynamic emails with templates is failing with exception

The dynamic emails with templates is failing with the exception :
java.lang.NullPointerException: body
at open.springboot.mail.model.impl.EmailImpl.(EmailImpl.java:42) ~[spring-boot-email-tools-0.1.1.jar:0.1.1]
at open.springboot.mail.model.impl.EmailImpl$EmailImplBuilder.build(EmailImpl.java:44) ~[spring-boot-email-tools-0.1.1.jar:0.1.1]
In open.springboot.mail.model.impl.EmailImpl, removing the @NonNull annotation of the body field fixes the problem.
Find below an extract of my code :
email = EmailImpl.builder().from(new<EMAIL_ADDRESS>"SoulPay System"))
		.to(Lists.newArrayList(new InternetAddress(operation.getBeneficiary().getEmail(),
		operation.getOperator().getFullName())))
		.subject("Declaration").encoding(Charset.forName("UTF-8")).build();
modelObject.put(NotifParamsConstants.PARAM_INIT_PUBLIC_NAME, operation.getOperator().getFullName());
modelObject.put(NotifParamsConstants.PARAM_CREDITED_WALLET_DESC, creditedWallet.getAccName());
modelObject.put(NotifParamsConstants.PARAM_TRANSACTION_AMOUNT,customFormat.format(operation.getTotal()));
modelObject.put(NotifParamsConstants.PARAM_TRANSACTION_ID, operation.getReference());
modelObject.put(NotifParamsConstants.PARAM_BALANCE_AMOUNT, customFormat.format(creditedAccountBalance));
emailService.send(email, "DEC_BENEF_EMAIL.ftl", modelObject);

Do you refer to master or to the unmerged branch?
Anyway, I'll check this in the evening.

@phrouv I had a quick look.
Why do you want to send an email without a body?
In principle you can set it to empty, isn't that possible?

The faulty release is the latest published one : 0.1.1
My code looks the same as your sample code (below) of your  README.md where the body is not set either considering it is coming from the template.
public void sendEmailWithTemplating(){
Arrays.asList(new<EMAIL_ADDRESS>"Gaius Cassius Longinus"),
new<EMAIL_ADDRESS>"Marcus Iunius Brutus Caepio"))
.stream.forEach(tyrannicida -> {
final Email email = EmailImpl.builder()
.from(new<EMAIL_ADDRESS>"Gaius Iulius Caesar"))
.to(Lists.newArrayList(new InternetAddress(tyrannicida.getEmail(), tyrannicida.getName())))
.subject("Idus Martii")
.encoding(Charset.forName("UTF-8")).build();
//Defining the model object for the given Freemarker template
final Map<String, Object> modelObject = new HashMap<>();
modelObject.put("tyrannicida", tyrannicida.getName());
   emailService.send(email, "idus_martii.ftl", modelObject);

};

By setting the body to empty 'body("")', it's working. So I suppose a change of the  README.md will do the trick.

@phrouv :+1:
I'll update the readme then (or actually you can do it, and then I'll approve the change

Fixed with PR https://github.com/ozimov/spring-boot-email-tools/pull/4
Thanks for reporting the issue


leverage generateTemplates capability of harvester/addons

Problem:

PR introduces minor changes to installer to leverage the new generateTemplate capability added to harvester/addons
Prior to this change the addon updates were being managed by updates to version_info file, and also updating the version details in the rancher-22-addons.yaml template file.
Solution:

This has been simplified to use the chart versions in version_info file and allow ability to generate template file dynamically. This ensures that chart and image version change is only ever kept in one single location.
addons PR: https://github.com/harvester/addons/pull/4
Related Issue:
https://github.com/harvester/harvester/issues/4937
Test plan:

@w13915984028 now that version_info is the sole driver of template and addon generation, do you think we still need the chart / addon version check in build-bundle?

@mergifyio backport v1.4


Update default.rb

Since the value of @resource[:master_slave] is either :true or :false, and symbols in Ruby are always truthy, this needs to be compared explicitly with the symbol :true.
This is actually the same fix as in the following pull request:
https://github.com/redhat-openstack/puppet-pacemaker/pull/66
This was closed, because the project was moved from redhat-openstack to openstack, with the suggestion to resubmit the fix to the new location. However this was never done by the original author of the fix.
Hence I am submitting this fix myself.

Thank you for contributing to openstack/puppet-pacemaker!
openstack/puppet-pacemaker uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Add travis ci or circle ci build status

Have the appveyor windows build status ready and would like some help with getting travis ci or equivalent to work.  Current problem I am having is the numpy+mkl requirement from the requirements.txt file so anyone with experience on scipy and linux or how to do alternate requirements or setup the travis build to be conditional.

Now have Appveyor and Travis CI build status badges hooked up to commits


Link to API Stewardship Board API Review wiki page not working

The link to API Stewardship Board API Review wiki page is not working.

Fix deployed to Prod


How to preload with webpack?

import Preload from 'preload-it';
import myImage from 'myimagepath.png'

const preload = Preload();
preload
  .fetch([
    myImage,
  ])
  .then((items) => {
    console.log(items);
  });

Seems to be not working and will throw an error. :(

preload-it accepts base64 URIs, so with webpack you can use url-loader to transform files into base64 URIs, which then can be passed to fetch:
for instance this will work fine:      preload.fetch(['data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg==']);`


WebPack Compiler with Third Party APIs like Mapbox

I have trouble using sass-loader and using third party APIs when I try to run the Node server. Though I have made some modifications in your code-base, like adding Webpack compiler and Webpack-Dev-Middleware to the Express, but during the start of Node Express Server, the Webpack -d runs fine (i.e. Build is successfull), but the Server doesn't start.
It gives me following error:

First when Scss files are imported to React Components, I get Syntax error for @import in any .scss files.
To handle this, I removed Sass Imports (Just to check if it works without Sass compilation), but after that, I got following error:

mapbox-gl.js:404
"use strict";module.exports=self;
                            ^

ReferenceError: self is not defined

where mapbox-gl is a third-party library, and I import them in the Components, using the following plugin in webpack.conf:
new webpack.ProvidePlugin({
    mapboxgl: 'mapbox-gl',
    turf: "@turf/turf"
  }),

My Webpack conf is right, as it works, when I start it with webpack-dev-server.... Problem is when I try to use the same settings for creating a Universal React App.
I know this is not an issue, but was hoping that you might help me here someway, as I have searched a lot and tried a lot of ways to make it work, but none of them came out true.
Thanks

Hello @Shub1427,
sorry but without being able to look at some code this is very hard to troubleshoot even though I guess it's a matter of some wrong configuration in your webpack setup.
Also, since it seems you changed a lot of this tutorial code, I wouldn't consider this as an issue of this repo per se, so I am closing the issue. Feel free to reply here if you think that's not the case


[Question]  Does selecting a custom monster during a spawn keep the expansion of the base monster?

Description of Problem or Question
I've a question.
Does selecting a custom monster take into account the expansion of the base monster?
For example: I defined 10 custom monsters 3 based on monsters in the expansions. If I have monsters selected via traits, will the 3 monsters based on unselected expansions also appear?
Valkyrie Version
2.5.6

I have a very limited knowledge of the editor, so maybe it could be done in a different way.
I think you must set a variable for each monster, to link them to a specific expansion. Then, create a check test with those variables, so the monster will not appear if the variable doesn't match the test.

Yes you're right: custom monster dosen't spawn in normal way so they are all excluded from normal gaming.


Shalmath

text: Can Shalmath use his untap ability as he is stolen by Temptation-no
link: http://www.vekn.net/forum/search?query=shalmath&searchdate=all&childforums=1&catids=6&start=15

So I put this one on Temptation. Is more of a ruling on Temptation (you cannot use Coven or Heidelberg either between the decision to use the counters and the control change). It has not much to do with Shalmath IMO.


Commit API docs

To keep repo history small, always amend and force-push this commit rather than adding commits to the gh-pages branch

I checked out your branch and compared it against main locally (GH was not kind to this PR). The changes look good. I'll force-push them to the branch as usual.


Crashes on Windows 7 laptop

Find-object crashes about 1 in 3 times on windows 7 laptop.
version is 0.6, opencv 3.0.0 with non-free.
Installed on a 64 bit Windows 7, on a Sony VPCF1 type laptop, running Intel i7 processor
Find-Object was installed by downloading and running the win-64 exe installer file.
The find-object.exe file is date  10/07/2015, size 118KB
example of operation;-
start up Find-Object by clicking on the above .exe file
press space bar for default camera (laptop)
add object from file
crash
It also crashes about 1 in 5 times after ...delete object...

There is a version 0.6.2 here : https://github.com/introlab/find-object/releases
You can also try the latest version (not officially released) here: https://ci.appveyor.com/project/matlabbe/find-object/branch/master/artifacts

As suggested, I've replaced version 0.6 with version 0.6.2.
The defect has not occurred after several hours.
I'll close this issue.
Many thanks for your prompt and effective help.

Hi
Thanks for your very helpful and quick reply.
I'm very impressed with the find-object tool. I think many more novices and new-comers could find it interesting, if there was more tutorial type material about it available on the web.
let me explain...
I'm a new comer to computer vision, image classification and object detection, etc. I've studies opencv, and learned from various sites, such as https://www.pyimagesearch.com/2018/09/10/keras-tutorial-how-to-get-started-with-keras-deep-learning-and-python/, etc.
To understand how to use Find-Object ... I installed it and used it ! I'm impressed.
Then ...
I looked at the various sites, including ;- https://github.com/introlab/find-object/wiki ,  https://introlab.github.io/rtabmap/ ,  https://husarion.com/tutorials/ros-tutorials/4-visual-object-recognition/ , etc.
But ... there is a lack of information about many of its functions and their operation.
For example, there does not seem to be any explanation about what the " camera from directory of images " does. Of course it becomes fairly clear by just using that function, and other simpler functions. But often novices like me will be struggling  with the question ;- is it supposed to do that ? What is it doing now ? Not all it's functions are self-explanatory to new-comers.
If there were more tutorials, I'm sure many more learners would use the tool and it's popularity would increase. Many would then be able to get into the details ( setting parameters, etc ) and your teams reputation would be greatly increased.
While I understand that basic introductory information takes time and is often tedious to the experts, well, .... we all had to start at some time !
With Regards,
Robert Agribot

From: matlabbe<EMAIL_ADDRESS>Sent: 28 March 2019 12:06
To: introlab/find-object
Cc: Agribot; Author
Subject: Re: [introlab/find-object] Crashes on Windows 7 laptop (#85)
There is a version 0.6.2 here : https://github.com/introlab/find-object/releases
You can also try the latest version (not officially released) here: https://ci.appveyor.com/project/matlabbe/find-object/branch/master/artifacts
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/introlab/find-object/issues/85#issuecomment-477567761, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsfHdgrI-ZERA-639kE69zbNwyeVvDa6ks5vbLBjgaJpZM4cPzW_.

Hi Robert,
Thank you for for your support and your suggestions. There are indeed only a limited number of tutorials on Find-Object by lack of time (I am more involved on RTAB-Map project right now) and it was a tool made at the beginning for people who already played a little with OpenCV's feature detection a priori. That project evolved over time to be more user friendly, even into an application that can be used directly as interface to other applications (like with TCP/IP support). I see that many new comers can learn what OpenCV's feature detection can do with Find-Object. I use it also often when I need to tune visual feature parameters for other projects.
I am supposed to come back to Find-Object and add new features in the near future, I'll see if I can add more details to this introductory tutorial, in particular the other options we see in the menus.
Regards,
Mathieu


Cleaner code

@bratseth please review.
Your suggestions implemented.
For some unknown reason, github did not include these in the first merge.

Java build was OK, but cpp bootstrap.sh failed at line 12.


Add ability to load DICOM tag mapping from ADA-1107

The ADA-1107 repo a CSV file called views.csv which contains the DICOM tags to use for clinically relevant information. dicom4ortho should use that file to perform the mapping. This would also allow dicom4ortho to support various different versions of ADA-1107.

There should be the ability to

download the CSV file from public URL at runtime
cache the object locally, so that the software doesn't need to download it at every iteration
allow the user to specify an alternate file

Done.


can't run vscode correctly

VSCode Version:1.3
OS Version: virtualbox Ubuntu 16.04

Steps to Reproduce:
step1：code .
step2: vscode menu can't work

@JeffreyChan what exactly does not work? can you maybe provide screenshots?


Deploy binaries automatically

This PR deploys automatically the mdbook-katex binaries for Linux and MacOS operating systems.
To run the deploy action, you just need to push a tag.
You can find a fake release here.
Thanks in advance for your review! :)

Hello,
Thank you for the PR!
Is there a reason why you didn't add a release for windows as well?

Hello,
Thank you for the PR!
Is there a reason why you didn't add a release for windows as well?

Hello @lzanini!
Yep, for this reason: https://github.com/theduke/quickjs-rs/issues/93

Hello @lzanini!
Yep, for this reason: https://github.com/theduke/quickjs-rs/issues/93

Thanks for merging my PR @lzanini, very appreciated! :)

Thanks for merging my PR @lzanini, very appreciated! :)

You're welcome :+1:

You're welcome :+1:


Configurably warn or explode on errors

In the real pipeline we'd want to explode.
E.g. the link doesn't exist

this is like a year old and in a separate issue it think we have it throw a searchable [link]


cargo install probe-run fails with compilation error

Describe the bug
Simply running cargo install probe-run ends up with
   Compiling defmt-json-schema v0.1.0
   Compiling probe-rs-target v0.13.0
   Compiling defmt-decoder v0.3.3
error[E0716]: temporary value dropped while borrowed
  --> /Users/tolgaparlan/.cargo/registry/src/github.com-1ecc6299db9ec823/defmt-decoder-0.3.3/src/log/json_logger.rs:26:28
   |
26 |             let mut sink = io::stdout().lock();
   |                            ^^^^^^^^^^^^       - temporary value is freed at the end of this statement
   |                            |
   |                            creates a temporary which is freed while still in use
...
29 |             serde_json::to_writer(&mut sink, &create_json_frame(record, host_timestamp)).ok();
   |                                   --------- borrow later used here
   |
   = note: consider using a `let` binding to create a longer lived value

error[E0716]: temporary value dropped while borrowed
  --> /Users/tolgaparlan/.cargo/registry/src/github.com-1ecc6299db9ec823/defmt-decoder-0.3.3/src/log/json_logger.rs:33:24
   |
33 |             let sink = io::stderr().lock();
   |                        ^^^^^^^^^^^^       - temporary value is freed at the end of this statement
   |                        |
   |                        creates a temporary which is freed while still in use
34 |             self.host_logger.print_host_record(record, sink);
   |                                                        ---- borrow later used here
   |
   = note: consider using a `let` binding to create a longer lived value

error[E0716]: temporary value dropped while borrowed
  --> /Users/tolgaparlan/.cargo/registry/src/github.com-1ecc6299db9ec823/defmt-decoder-0.3.3/src/log/json_logger.rs:50:24
   |
50 |         let mut sink = io::stdout().lock();
   |                        ^^^^^^^^^^^^       - temporary value is freed at the end of this statement
   |                        |
   |                        creates a temporary which is freed while still in use
51 |         serde_json::to_writer(&mut sink, &SCHEMA_VERSION).ok();
   |                               --------- borrow later used here
   |
   = note: consider using a `let` binding to create a longer lived value

error[E0716]: temporary value dropped while borrowed
  --> /Users/tolgaparlan/.cargo/registry/src/github.com-1ecc6299db9ec823/defmt-decoder-0.3.3/src/log/pretty_logger.rs:34:28
   |
34 |                 let sink = io::stdout().lock();
   |                            ^^^^^^^^^^^^       - temporary value is freed at the end of this statement
   |                            |
   |                            creates a temporary which is freed while still in use
...
38 |                     None => Self::print_println_record(record, sink),
   |                                                                ---- borrow later used here
   |
   = note: consider using a `let` binding to create a longer lived value

error[E0716]: temporary value dropped while borrowed
  --> /Users/tolgaparlan/.cargo/registry/src/github.com-1ecc6299db9ec823/defmt-decoder-0.3.3/src/log/pretty_logger.rs:43:28
   |
43 |                 let sink = io::stderr().lock();
   |                            ^^^^^^^^^^^^       - temporary value is freed at the end of this statement
   |                            |
   |                            creates a temporary which is freed while still in use
44 |                 self.print_host_record(record, sink);
   |                                                ---- borrow later used here
   |
   = note: consider using a `let` binding to create a longer lived value

For more information about this error, try `rustc --explain E0716`.
error: could not compile `defmt-decoder` due to 5 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `probe-run v0.3.4`, intermediate artifacts can be found at `/var/folders/9l/m7lkb4vx10s3s3g0dq086s3m0000gn/T/cargo-installVSUMIJ`

Caused by:
  build failed

To Reproduce
Steps to reproduce the behavior:
I am in an m1-mac environment. Other than that I don't think I had to do anything special to reach this bug.

Your Rust version is out of date and needs to be updated


[Skin] Project-Myhaen

This is actually for UT99 - stated in the Readme and clear from the format of the files.
Odd that it was parsed as Unreal Tournament 2004?

URL: https://unrealarchive.org/unreal-tournament-2004/skins/P/project-myhaen_a5f9285e.html
Hash: a5f9285e51b50a4ca9496472b5e9444f21960414
Current name: Project-Myhaen

It decided it's UT2004 based on the package version: which says it's 126. Usually the engine/package version is < ~68 for Unreal and < ~117 for UT.
126 pushed it into UT2004 territory.
Fixed.


Adding :fishsticks: emoji

This emoji is an inside joke at GitHub where employees were testing the limits of what they could get compensated for using discretionary budgets with a new vendor.  For a limited time, frozen fishsticks was the most extraordinary item we could find, which was a rally point for introducing the :fishsticks: emoji.

Thanks!


Scenario choice so that ride selection is limited to the chosen scenario, and pre-built scenario rides are filled out automatically

Also consider harder guest generation for soft guest cap


Inform about persistence of data on IPFS

Correct me if I'm wrong but once you put files in IPFS, you can't delete them.
Since the app looks like a great way to share "private" files between friends. It might be useful to specify this: Once shared, it can't be unshared. or something in that vein.
What do you think?
PS: Thanks for a great project that makes using IPFS in such a simple and appealing way.

Agreed, we should add that. Thanks for the kind words!


Switch from using SDL_UpperBlitScaled to SDL_BlitScaled

As you can see here, SDL has switched, and so we should follow this.

While true, it's not practical. If you look at the source for SDL_surface.h #l476 you'll see that SDL_BlitScaled is actually just a macro:
#define SDL_BlitScaled SDL_UpperBlitScaled

Since there's no way to use C macros in our rust FFI code, we shouldn't change it until SDL_BlitScaled is a symbol.
@AngryLawyer I think this can be closed.

Whoops. I see we have no blit_scaled method on Surface, only upper_blit_scaled. I think we could copy upper_blit_scaled and add a deprecate attribute to the old method to match what SDL2 intends to do. I'll make a PR.


Unifies usage of Hex encoders

:clipboard: Fixes #816
Overview
Unifies usage of Hex encoders
Changes
Removed Crypto.(de|en)code_address, limited usage to Eth.Encoding & Utils.HttpRPC.Encoding.
In code try to use Eth.Encoding except the cases RPC is used.
In test use whatever fits (including Base.decode16)
Testing
Cleaning work, existing test should suffice.

Coverage remained the same at 80.823% when pulling 85e72818ff5275e57784701107cbf6ccb76ea577 on 816-unify_hex_encoders_usage into bbd6bd4cb89e83fe121377125fd70ba8b71f529c on master.

Note to self: Wait for test coverage get over

Kudos!


Don't enable http1 feature in hyper

This is aspirational at the moment, but wanted to validate that the upstream PR (hyperium/hyper#2377) works as intended.

hyper has been fixed so that the "http1" feature is no longer necessary
to get the various connection types required by this crate.

Thanks!


Benchmark performance visualisation over a period of time.

Benchmark tests for chipmunk store the performance results for each tag in json format. This data should be available as a comparative visualisation.

Completed with PR#2061


Confirm success of removal of Docker Hub

Docker Hub was removed for security (I took care of this; nothing big, I looked through logs) and dramatic speed reduction purposes, and as far as I can tell Docker Hub isn't needed for production (I know it isn't for testing because tests pass).
Here are some of the lines I noticed for production in Ansible which needs Docker name and image:

Defined in: https://github.com/opensyllabus/osp-pipeline/blob/ef8ca513bf258dcb58ead88c5b5296c22db03c9c/deploy/ansible/roles/spark/defaults/main.yml
Used in: https://github.com/opensyllabus/osp-pipeline/blob/ef8ca513bf258dcb58ead88c5b5296c22db03c9c/deploy/ansible/roles/spark/tasks/start.yml

I think simply setting the container name and built image name in docker-compose.yml solves any issues, but say the docker instances being spun up can't access the built image, then we will need to push to ECS repo on master pushes, and only use said image in production.

Hey @lily-mayfield,
Can you say more about this - where was it removed? We do need to push to Docker Hub for deployment, with the current system - the image has to be available on some kind of public-facing registry so that the EC2 nodes can pull it when the cluster is deployed.

@davidmcclure I went ahead and got a micro subscription to docker hub for private repo. i'll add back instructions for manually updating the image and all that.
thanks!

Also sorry about that--I totally spaced on this one!


Do not retrieve null records

Hi. I am trying to retrieve only translated menus in to my header. Currently have Portuguese and English translations. If I use the code bellow, it does not load the null record (thats OK), but it is not loading the notNull record also (Portuguese record).
Here is my controller (part)..
$menus = Menu::whereHas('translations', function ($query) {
    $query->where('locale', 'en')->whereNotNull('menu');
})->get();

My view..
@foreach ($menus as $menu)
@if ($menu->category_id == 1)

slug }}">{{ $menu->menu }}

 @endif
@endforeach

Appreciate your help, guys!

Feel free to use the translatedIn scope as demonstrated at the docs: https://github.com/dimsav/laravel-translatable#available-scopes

Thanks for your kindness. I will take a look at the documentation!


Baselines MAINTAINERS and CODEOWNERS

Description
Baselines the MAINTAINERS and CODEOWNERS.
Issues Resolved
https://github.com/opensearch-project/notifications/issues/616
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #654 (3de5674) into main (176278e) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main     #654   +/-   ##
=========================================
  Coverage     61.84%   61.84%
  Complexity      114      114
=========================================
  Files            73       73
  Lines          2495     2495
  Branches        266      266
=========================================
  Hits           1543     1543
  Misses          775      775
  Partials        177      177

Flag
Coverage Δ

opensearch-notifications
61.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@opensearch-project/admin, could anyone help to sync this repo's permissions? Thanks.


Improve test coverage

As my grandmother used to say, a coverage report says more than a thousand words:
https://codecov.io/gh/aaronpowell/ps-nvmw/src/master/nvm.psm1

Hey, 76% ain't bad as a starting point!

Code coverage is in the 80% range, I'm good with that.


Intel Documentation Links

The Intel links for the Architecture Manual and Optimization Manual are no longer valid.
Architecture manual seems to be missing at that URL.
wget -nc https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf -O Intel_Architecture_Manual.pdf
--2023-09-28 10:05:08--  https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf
Resolving software.intel.com (software.intel.com)... <IP_ADDRESS>, 2600:1408:c400:594::1ea2, 2600:1408:c400:590::1ea2
Connecting to software.intel.com (software.intel.com)|<IP_ADDRESS>|:443... failed: Resource temporarily unavailable.
Connecting to software.intel.com (software.intel.com)|2600:1408:c400:594::1ea2|:443... failed: Network is unreachable.
Connecting to software.intel.com (software.intel.com)|2600:1408:c400:590::1ea2|:443... failed: Network is unreachable.

I can find a valid download link at https://www.intel.com/content/www/us/en/developer/articles/technical/intel-sdm.html but it seems to be hidden behind a URL redirect.
Optimization Manual gets a redirect that results in a forbidden response, but I can access the redirected URL fine via my web browser.
wget -nc https://software.intel.com/sites/default/files/managed/9e/bc/64-ia-32-architectures-optimization-manual.pdf -O Intel_Optimization_Manual.pdf
--2023-09-28 10:06:17--  https://software.intel.com/sites/default/files/managed/9e/bc/64-ia-32-architectures-optimization-manual.pdf
Resolving software.intel.com (software.intel.com)... <IP_ADDRESS>, 2600:1405:c000:295::1ea2, 2600:1405:c000:2af::1ea2
Connecting to software.intel.com (software.intel.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://corpredirect.intel.com/Redirector/404Redirector.aspx?https://software.intel.com/sites/default/files/managed/9e/bc/64-ia-32-architectures-optimization-manual.pdf [following]
--2023-09-28 10:06:17--  https://corpredirect.intel.com/Redirector/404Redirector.aspx?https://software.intel.com/sites/default/files/managed/9e/bc/64-ia-32-architectures-optimization-manual.pdf
Resolving corpredirect.intel.com (corpredirect.intel.com)... <IP_ADDRESS>, 2600:1405:c000:2af::1ea2, 2600:1405:c000:295::1ea2
Connecting to corpredirect.intel.com (corpredirect.intel.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://www.intel.com/content/dam/develop/external/us/en/documents/64-ia-32-architectures-optimization-manual.pdf [following]
--2023-09-28 10:06:17--  https://www.intel.com/content/dam/develop/external/us/en/documents/64-ia-32-architectures-optimization-manual.pdf
Resolving www.intel.com (www.intel.com)... <IP_ADDRESS>, 2600:1405:c000:2af::1ea2, 2600:1405:c000:295::1ea2
Connecting to www.intel.com (www.intel.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2023-09-28 10:06:17 ERROR 403: Forbidden.

Hi! Thanks for letting me know! I would have fixed sooner but apparently my notification settings don't work.
I'm glad to hear someone actually is using it! I hope people enjoy the bookmarks on the BIOS manual, that was hard to get working :)


Update csv preview template to use components

What
Does the following to the CSV preview template (example page):

Applies the govuk frontend grid system
Applies the organisation logos component
Applies the page title component
Applies the table component
Makes the table navigable to keyboard and screenreader users (see this PR for why we would want to do this)
Adds govuk-body and govuk-link to page elements where appropriate
Tidies up the markup, styling and code

Why
Part of ongoing work by the govuk accessibility team to ensure that we are consuming our components gem in as many places as possible to reduce the risk of hidden tech debt across our frontend apps.
Card
Visual changes

Before
After

Tab navigation example
https://user-images.githubusercontent.com/64783893/113127557-cbb99000-9210-11eb-9efe-5b3b9831b165.mov
Testing
There currently isn't an easy way to test this locally so I've been deploying to integration. Let me know when you want to do a test pass and I'll deploy to integration for you.

This current link has reverted to the old version, I'm seeing the darker blue and bolded copy.
The gem swaps are active and working - it's nice a few files of sass have been able to be removed as a result.


Expose internal select2 settings

As described in https://github.com/iStefo/ember-select-2/pull/23, there is a need for accessing the full flexibility of the jQuery select2 plugin, that can not be established in the near future when trying to uphold the current quality and safety of this component.
I explained why I think that simply opening every option to the outside world is not a good idea: Because it may give the illusion that every setting is tested and works the way things work in ember.js. But they might not, and opting-in should be harder than just setting a binding - but not as hard as forking this project!
Therefore I am thinking of a way that does not require modifying this code, but maybe instead subclassing it. A very early idea would be an API like this:
import Select2 from 'ember-select-2';

export default Select2.extend({
    // define options here for all instances of this component
    customOptions: {},

    // or in a dynamic fashion based on custom options from outside
    customSetup: function() {
        this.customOptions = {
            matcher: function(...) { /* custom plain-JS matcher to override provided */ },
            otherSelect2Setting: true
        };
    }.on('init')
});

When setting up the component, ember-select-2 could check the customOptions (not calling it options on purpose) hash and choose the options provided there over the default implementations. This way, all the flexibility is exposed but no false promise is made for compatibility.
An alternative approach would a an optional method that would be called after building up the original options hash and that works like this:
import Select2 from 'ember-select-2';

export default Select2.extend({
    customizeOptions: function(options) {
        // override options while having access to the defaults
        var oldMatcher = options.matcher;
        options.matcher = function(item, query) {
            // allow items that match the query and all superstar items
            return oldMatcher(item, query) || item.superstar;
        }
        return options;
    }
});

This approach seems even more flexible to me because it allows access not only to the select2 default options set by the original component, but also to internal state & configuration that was built up in the didInsertElement method.
What do you think of these two approaches?

what is the status on this? would be nice to have

@iStefo I'm inclined toward the second option myself, as the ability to specify custom options seems to be something that a number of folks will start wanting down the road.  As far as your though option 1

no false promise is made for compatibility

Seems like you could state clearly in the docs that customizeOptions has the potential for breakage, use at your own risk and setup tests to ensure things keep working ...  Thoughts?
I'm about to add some customizations of my own, which is why I've been looking at this further :-)  Would be happy to bounce ideas around on this if it'd be helpful ...

I consider second approach as better. I am pretty sure that such opportunity will break select2 in some cases, but as @acorncom said if you make it clear in docs I am sure it will give added value in future. Let us know what's the status on that. If you need any help in coding due to lack of time just give a sign :)

@iStefo Agreed with @jniechcial, if you want other folks doing the work and sending PRs, we're happy to, just would rather keep all our changes in one place instead of having them spread across custom forks :-)

:+1:
Would be happy to see this implemented !
I've seen the following fork implementing related things: https://github.com/qianthinking/ember-select-2
Any other examples that I could build upon in the mean time ?

I made it the same way in my custom fork. It is completly enough for per project use, but the extensive implementation should be able to access every option of select2. I like the one that @iStefo present, but until it is implemented still need to work on my own fork to be flexible ;)


Development of select

The select component is part of the MVP of the SL Design System. A select gives users the ability to make a single selection from a number of options.
Check Miro board design ideation:
https://miro.com/app/board/uXjVP6TtQdI=/?share_link_id=419677033460
Use cases

in a form
in a page
when it's pre selected
when it is empty
when you unselect it
Select: icon + item (single select)
Select: item (single select)
The amount of options determines what kind of control you need to use

Features

Positioning strategy popover (pop-up aligned with current selection)
Design for default selection
Keyboard navigation
Auto sizing to length of longest option

Types (can be different based on the outcome of the use cases)

default
subtle
none (no box)

States

idle
hover
active
focus
invalid
disabled
readonly

### Tasks
- [ ] Development
- [ ] Writing tests
- [ ] Add support for multiple box shadows in one token. right now the translator ignores those shadows.

For the dropdown use <dialog popover>

There's a problem using size.3xs values in the box-shadow for the listbox boxshadow. In those values the px is included. In other places we set a box-shadow the px is not included in the value of the token, and we add it when transforming the tokens to css. When using size.3xs we get a calculated value in the browser like 2px px this is invalid and so we see no box shadow.

Also the naming of the tokens doesn't seem to be consistent between core and SL-light theme

Todo:

[ ] keyboard navigation options first goes through all optiongroups, then separate options.


Ballz improvements

Better concern division into modules, now works on Linux !
forces.nit module is not really used yet but will be.
PS : mnit_simple and mnit_ballz aren't launching on android at the moment, I'll fix this in a further PR

Not sure how this issue's name passed through my spam filters.

jenkins: ok to test

Since android is borken, maybe remove anything related to android in the PR. You will introduce them in a next one.

Finally we have the much hyped walls, and as a bonus it's a nice clean up!
Unless you plan on completing the features related to the dead code/module right away, you should probably remove it. Keep it for a future commit and it will kick start you next PR!
 It will be easier to follow once integrated if they all begin with the same prefix!

Reroll :

Standardized commits
fixed commentaries
removed the forces part (sorry for your pun @privat)
fixed android part, was an infinite recursion in App creation :/

:shipit: !


[FLINK-16303][rest] Enable retrieval of custom JobManager log files

Based on #11542.

@flinkbot run travis


On further save after Import animation, Godot keeps reordering generated AnimationLibrary animations

After every Import animation (from animated sprite), I commit my new updated animation library.
But later, after some saving, playing, reopening project, I see that my animation library has changed again. I notice no content change so it must be just animation reordering, but it's annoying to see a non-change in VCS.

Maybe it's something to fix on Godot side? Unless we can easily do it on our side by calling some force save/refresh API, like ResourceSaver.save?

It could also be related to some caching with animation libraries and the way the plugin handles resource changing since right now it's just directly updating the reference to an AnimationPlayer.
I have another plugin that also deals with animation libraries, and I've since found that the best way to handle it is using UndoRedo with very precise target, so everything goes through the editor (and possible whatever caching/saving mechanism it has).
Might be worth experimenting integrating UndeRedo with this plugin as well, but idk how much work that'll be or if it'll actually fix it.


Is it possible to use MariaDB?

The other apps I have installed on my server use MariaDB- I was wondering if it was possible to avoid installing a second SQL server.

Oh it looks like it's planned for the future.


Fix swagger

Don't show limit/offset for endpoints not supporting it

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 87.691%

Files with Coverage Reduction
New Missed Lines
%

safe_transaction_service/history/services/collectibles_service.py
2
90.48%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5920

Relevant Lines:
6751

💛  - Coveralls


Support activeBuildProfile parameter

Context
When using "activeBuildProfile" parameter (in "customParameters", example: customParameters: -activeBuildProfile Assets/Settings/BuildProfiles/WindowsDevelopment.asset) (for Unity 6) builder action throws an error message:
Aborting batchmode due to failure:
Can't have -activeBuildProfile argument defined when using -buildTarget argument

Problem is "targetPlatform" is a required parameter.
Suggested solution
Maybe require to have either "targetPlatform" parameter OR another parameter like "buildProfile". "buildProfile" parameter would hold the same value "activeBuildProfile" requires, a relative path to the profile asset.

Yeah Build Profiles is quite a recent feature which is indeed something that would be worth adding as a feature 👍
More details about the build profiles

This would be incredibly useful

@coderabbitai read the following files and suggest an approach to add support for activeBuildProfile parameter for unity version >= 6 (6000)
dist/default-build-script/Assets/Editor/UnityBuilderAction/Builder.cs
dist/default-build-script/Assets/Editor/UnityBuilderAction/Versioning/GitException.cs
src/index.ts
src/model/platform-setup/setup-windows.ts
src/model/unity.test.ts
src/model/input.ts
dist/default-build-script/Assets/Editor/UnityBuilderAction/Versioning/VersionApplicator.cs
src/model/action.ts
dist/default-build-script/Assets/Editor/UnityBuilderAction/Versioning/Git.cs
dist/default-build-script/Assets/Editor/UnityBuilderAction/Versioning/VersionGenerator.cs
src/model/action.test.ts
src/model/unity.ts
dist/default-build-script/Assets/Editor/UnityBuilderAction/Input/ArgumentsParser.cs
dist/default-build-script/Assets/Editor/UnityBuilderAction/Reporting/StdOutReporter.cs
dist/default-build-script/Assets/Editor/UnityBuilderAction/Reporting/CompileListener.cs
src/model/input.test.ts
src/model/platform-setup/setup-mac.ts
src/model/platform-setup/setup-android.ts
src/model/docker.ts
src/model/docker.test.ts
action.yml

@coderabbitai There is an existing command line argument for this on the unity cli, it is -activeBuildProfile. Here is an example of how I used it in a different project (this is a confirmed to be working solution used with GitlabCI, not the GameCI Unity Builder GitHub Action):
#!/usr/bin/env bash

set -euo pipefail

echo "Building for '$BUILD_TARGET'"

# Ensure the build path is defined and exists
export BUILD_PATH="$UNITY_DIR/Builds/$BUILD_TARGET/"
mkdir -p "$BUILD_PATH"

# Base Unity command split into an array
mapfile -t UNITY_CMD < <(
  printf "%s\n" \
    "${UNITY_EXECUTABLE:-xvfb-run}" \
    "--auto-servernum" \
    "--server-args=-screen 0 640x480x24" \
    "unity-editor"
)

# Base Unity arguments
mapfile -t UNITY_ARGS < <(
  printf "%s\n" \
    "-projectPath" "$UNITY_DIR" \
    "-quit" \
    "-batchmode" \
    "-nographics" \
    "-customBuildTarget" "$BUILD_TARGET" \
    "-customBuildName" "$BUILD_NAME" \
    "-customBuildPath" "$BUILD_PATH" \
    "-executeMethod" "BuildCommand.PerformBuild" \
    "-logFile" "/dev/stdout"
)

# Adjust arguments based on whether a build profile is provided
if [[ -n "${BUILD_PROFILE_PATH:-}" && -f "$BUILD_PROFILE_PATH" ]]; then
  echo "Using build profile: '$BUILD_PROFILE_PATH'"
  UNITY_ARGS+=("-activeBuildProfile" "$BUILD_PROFILE_PATH")
else
  echo "No build profile specified or the file does not exist; proceeding with default build target."
  UNITY_ARGS+=("-buildTarget" "$BUILD_TARGET")
fi

# Print arguments for debugging
echo "Unity Command: ${UNITY_CMD[*]}"
echo "Unity Arguments: ${UNITY_ARGS[*]}"

# Run the Unity command with arguments
"${UNITY_CMD[@]}" "${UNITY_ARGS[@]}"

UNITY_EXIT_CODE=$?

# Check the Unity exit code and display appropriate messages
if [[ $UNITY_EXIT_CODE -eq 0 ]]; then
  echo "Build succeeded with no failures."
elif [[ $UNITY_EXIT_CODE -eq 2 ]]; then
  echo "Build succeeded, but some tests failed."
elif [[ $UNITY_EXIT_CODE -eq 3 ]]; then
  echo "Build failed due to other reasons."
else
  echo "Unexpected Unity exit code: $UNITY_EXIT_CODE."
fi

# List the build output directory contents
ls -la "$BUILD_PATH"

# Fail the job if the build folder is empty
if [[ -z "$(ls -A "$BUILD_PATH")" ]]; then
  echo "Build folder is empty! Failing the job."
  exit 1
fi

Here are some additional details I am aware of:

It is important to not pass a full path or even a relative path starting with ./ to the -activeBuildProfile parameter. It must use a local path to the asset file. For exmaple:

BUILD_PROFILE_PATH: "Assets/Settings/Build Profiles/Android Mobile.asset"
BUILD_PROFILE_PATH: "Assets/Settings/Build Profiles/Android VR Oculus.asset"

The documentation for the -activeBuildProfile is available here: https://docs.unity3d.com/Manual/EditorCommandLineArguments.html

Command
Description

-activeBuildProfile <pathname>
Set the build profile saved at the given path as an active build profile (e.g., -activeBuildProfile "Assets/Settings/Build Profiles/WindowsDemo.asset"). Applies custom scripting defines found in the Build data section of the active build profile before compilation. These scripting defines are additive and don’t override other scripting defines in your project.

Impressive @GabLeRoux :)

Ended up hiding those comments as they add a stream of information that isn't really helpful.
For whoever feels like taking a stab at this, please have a look at the combination of the first comment from Coderabbat and the followup from @GabLeRoux.

I've looked a bit at this already and so far the biggest issue (I think) has not been mentioned.
(Which is why I think that AI assistants are mostly useless, surface-level noise; but whatever)
The action currently does a bit of build platform specific setup depending on the build target. If the build profile were to be specified instead of the build target, the necessary information would not be available at the required time.
We could try to extract the build target information from the BuildProfile asset file directly and use that to fill in the action parameter. That way we wouldn't need to change most of the existing code. I'm just not sure how robust and reliable that would be.

We're just casually trialing this bot. It's been doing some very helpful comments as well.
Agreed that auto-detect would be preferable where possible. We already do that for the unityVersion or editorVersion param and could do the same for this.
That said, I think the whole point of Build Profiles is to have multiple. So beyond auto-detecting we do need to be able to specify it as a param as well.


any plans for PestPHP?

It would be a really welcome addition to detect PestPHP and run those tests also. Ty

You can change the phpunit executable to point to the pest executable:
	"phpunit.executable": "vendor/bin/pest",

This will run pest bin script instead of phpunit. The problem is that pest prints color codes:

PHPUnit automatically disables colors via the the --colors options which defaults to auto. You can manually disable colors in pest with --colors=never:
	"phpunit.options":
	{
		"colors=never": true
	},

But pest still prints color codes so the output now looks like this, a bit better but still an issue:

Colors in the Sublime Text output
Sublime Text output panels can't handle terminal color codes. PHPUnitKit handles the output by printing output with no color and then applying a syntax on which your color scheme is applied. I can add a syntax for Pest and add an easy to use boolean option phpunit.pest to enable pest. This would just the same as setting "phpunit.executable": "vendor/bin/pest" but I think the color code issue needs to be fixed in Pest. I think Pest should not print those when --colors=never is set.

I opened issue on the Pest issue for the --colors=never issue: https://github.com/pestphp/pest/issues/778

I've added some color output for Pest. To enable Pest you can replace the phpunit.executable:
        "phpunit.executable": "vendor/bin/pest",
	"phpunit.options":
	{
		"colors=never": true
	},

Until the color issue in Pest is fixed you will need to pass the --colors=never option to stop some of the color codes being printed. Pest still also has the issue of printing some color codes when it shouldn't, but I'm sure they'll fix those issues.
I'm thinking of added a phpunit.pest boolean option so that you would only need to enable it and under hood the plugin will configure the above settings.
You can also set these settings at a project level rather than global:
You can set settings on per-project basis: Menu > Project > Edit Project
{
"settings": {
"phpunit.executable": "vendor/bin/pest",
"phpunit.options":
{
"colors=never": true,
},
}
}

I added the boolean setting phpunit.pest. Just set it to true to enable the Pest test runner.

Please open issues about missing syntax highlighting of the output


fix(section-form): prevent crash when displayOptions are not present

Fixes a bug where the app would crash if used on a server version where section.displayOptions are not present.
We could've just checked for the presence before parsing, but I wrapped JSON.parse in a try-catch, because displayOptions is just an arbitrary string - so it could fail in various ways.
We also should introduce some error-boundaries to the app, so the entire app doesn't crash on errors like this.

I would say null. That Was the initial intention at least.
On Fri, 26 Apr 2024, 13:43 Birk Johansson, @.***> wrote:

@.**** commented on this pull request.
In src/data-workspace/section-form/displayOptions.js
https://github.com/dhis2/aggregate-data-entry-app/pull/375#discussion_r1580975150
:

@@ -0,0 +1,23 @@
+const defaultDisplayOptions = {

Not sure if it's best to have an object like this, empty object {} or a
null/undefined.
—
Reply to this email directly, view it on GitHub
https://github.com/dhis2/aggregate-data-entry-app/pull/375#pullrequestreview-2024954199,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHXXRLDBNSDIDYDPK43BPLY7JDVJAVCNFSM6AAAAABG2WCR4SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRUHE2TIMJZHE
.
You are receiving this because your review was requested.Message ID:
@.***>


Reconfigure connections appear to stay open

Hi there,
Once again, thanks are in order for the simple-too-use yet powerful docker-flow tools!
We are successfully running the swarm-listener/flow-proxy combo and have encountered our first glitch yesterday:
swarm-listener was not reacting to newly deployed services. When checking the container I saw that the swarm-listener process had surprisingly many sockets open.
We re-deployed the swarm-listener and everything went back to normal again.
Today I updated and redeployed the swarm-listener (version 1.25) and noticed that there was a connection (swarm-listener -> flow-proxy) for every reconfigure request the swarm-listener had sent.
Is this known behavior? From a quick glance at the code I cannot see any reason why this should happen.
Thanks in advance!
Cheers,
Konrad

I'm a bit surprised that happens. Unfortunately, I'm not testing that so I probably missed it. Can you send me the commands you used to see the number of open connections?

I used netstat -tn to list all open connections. All connections were between the swarm-listener and the flow-proxy and in state "ESTABLISHED".
Unfortunately, I am not familiar with go and even less with its libraries. However, I did some research and the net/http library appears to do some unexpected stuff with keep-alive connections. For example, I found this blog entry. It is not exactly the same problem but somewhat similar.

Forget the above blog post, this one seems to describe the exact behavior I am seeing:
http://nanxiao.me/en/a-brief-intro-of-tcp-keep-alive-in-gos-http-implementation/

I made a "blind" fix for this issue. I added lines that will close the body of a response. That was, indeed, something I missed and should have done from the start. The reason this is a "blind" fix is that I will not have a decent internet connection until Monday so I didn't do an extensive set of tests to confirm the fix. Can you try the newest release of DFSL and let me know whether it fixes the problem?

Great, thanks! I was trying to find some time to attempt a fix myself but was not able, so far.
I will give it a spin and check if the connections are closed properly

Unfortunately your fix does not appear to get rid of the problem. I still have one established connection per sent request in my test setup.
I did test with a small number of services though, so I created a Transport with MaxIdleConns: 1. However, either I do not understand how go deals with idle connections or there is some other problem here.
When I set DisableKeepAlives: true on the transport I could see that the connections were closed properly.
So I am still confused about what exactly is going on here. If you want to, I can submit a proper pull request.

PR would be great!

@podloucky-init Did you have some time to work on the PR?

@vfarcic Not yet, unfortunately. I am pretty swamped right now.

@podloucky-init Any luck with a PR?

Sorry about the inexcusably long delay. Since I do not know go, it took a bit of fiddling to get things as I wanted them. Unfortunately connections are not closed properly (CLOSE_WAIT).

Closing due to inactivity...