Pellet mode not working

So I've set my "collectPellets" to 1 and have tried hitting P with bots and nothing had happend.
Is there anything wrong? Or am I doing it wrong?

oops just noticed spelt "Pellet" in the title wrong :P

Download the last version.

I've already changed the code from the commit into the old 1.6.0 multiogar edited

Did you install the Tampermonkey script?

yes

Could not reproduce. Make sure you are using the latest version along with the collectPellets config set to 1, and disableERTP set to 0

collectPellets is set on 1 and disableERTP is on 0 and I wasn't on the vanilla client, but on a different client which had the E R T and P script already in it. I did use the client on a different MultiOgar-Edited and the pellet mode worked just fine

I just tried it on the original vanilla client and it isn't working

I don't experience any issues.
Are you sure you didn't change anything about minions in the files? Are you
sure that the ERTP matches agar? Maybe reinstall a draft server, with
everything unedited, then only change the collectPellets and ERTP controls
in the gameserverini
On 30 March 2017 at 22:19, freaky767<EMAIL_ADDRESS>wrote:

I just tried it on the original vanilla client and it isn't working
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Megabyte918/MultiOgar-Edited/issues/718#issuecomment-290548116,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWjIVLypb7febJYJeCr47Dpt89FZN8scks5rrBxegaJpZM4Mu1ZA
.

Ok
will try

I do not edit the gameserver.ini file, I just edit the gameserver.js file and then delete the gameserver.ini

Also please @Megabyte918 fix the decay

You can mess with the decay in the gameserver.ini
The more higher the value, the more mass decay reducts.

Ok it does work in the latest version, I still don't know why it doesn't work on the old 1.6.0 which I edited the code with the commit.

When Megabyte did the commit about the minionplayer, I copied the code and then put in my 1.6.0 of multiogar-edited


added keywords meta tag to html head

Keywords to increase SEO.

Great but did you use some kind of auto beautify? or auto indentation? because this makes it really hard with merge conflicts :)

Oh oh. Sorry. Novice error. I’m using Prettier in VS Code. How can I remedy this?

I’m guessing I’ll have to delete this PR, fork again and turn off the editor extension and then submit a new PR?

that would probably be the easiest way :)


Support for %% comments

It looks like the Advanced Slides plugin does not recognise %% comment section. They work with the built in presentation view but not with the Advanced presentation.

Im not able to reproduce it. Can you provide me an sample?
I've tested it with the sample from here: https://mszturc.github.io/obsidian-advanced-slides/basic-syntax/textstyle/

Looks like inline comments are supported but not multiline in the shape:
Here a multi-line comment:

%%
several lines
that should not be shown in the presentation
%%

Should appear again

Ohh yeah correct. Will be fixed in the upcoming release


fix matchGroup

        def matchSubGroup(sub_group): # TODO fix

https://github.com/Creeper19472/cfms_2/blob/a9834912fbccf13c0333d6500458566f7cccf5f4/include/bulitin_class/users.py#L173

fixed in the latest commit


update READMEs for postgres and sqlite to match constructors

Updated the documentation to match what the constructors actually accept. Postgres and Sqlite do not accept strings directly as URIs.
In the MySQL index.js, the constructor accepts either a string or an options object. That would be another possible approach if we need consistency
Related #91

Thanks for this @pricecomstock.
I want to wait for @Jytesh's opinion about this.
My feeling is we should to modify the constructor to support the same interface as the rest of connetors.
Ideally, we want:
const keyvSQLite = new Keyv({ store: new KeyvSQLite('sqlite://path/to/database.sqlite')})

Closing in favour of #96


WIP: Introduce an enhancement proposal process

This commit introduces an enhancement proposal process copied from
the OpenShift enhancements process but stripped down to keep only
the pieces which are currently relevant to HyperShift.

So far I have only stripped away stuff from the OCP content which I thought was inapplicable, and haven't added anything HyperShift specific. Suggestions welcome...


Update Proposal to include DAHeader

The starting point for integration of DA Proofs within consensus

Codecov Report

Merging #248 (71ae64b) into master (eff282a) will increase coverage by 1.12%.
The diff coverage is 18.46%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   60.87%   62.00%   +1.12%
==========================================
  Files         261      260       -1
  Lines       23640    23200     -440
==========================================
- Hits        14392    14385       -7
+ Misses       7759     7315     -444
- Partials     1489     1500      +11

Impacted Files
Coverage Δ

cmd/tendermint/commands/init.go
2.22% <0.00%> (-1.78%)
:arrow_down:

config/toml.go
60.86% <ø> (ø)

node/node.go
54.77% <ø> (-3.25%)
:arrow_down:

p2p/ipld/nmt_wrapper.go
90.90% <ø> (ø)

p2p/ipld/read.go
82.85% <ø> (ø)

proxy/client.go
0.00% <ø> (-23.08%)
:arrow_down:

test/e2e/generator/generate.go
0.00% <ø> (ø)

tools/tm-signer-harness/internal/test_harness.go
60.53% <ø> (-0.38%)
:arrow_down:

types/block.go
76.39% <ø> (-1.58%)
:arrow_down:

types/canonical.go
92.85% <ø> (+0.26%)
:arrow_up:

... and 41 more

@liamsi, there is some strange fail in TestCoverage check due to race that roots somewhere deep from the test. Is this something that needs to be fixed before? For me, it seems like no, but just double-checking

Is this something that needs to be fixed before? For me, it seems like no, but just double-checking

That's weird as it didn't occur previously. Looking at the log output put it kinda seems related to the code changes though. Let me run it locally first.

So the issue is found in nmt and the fix resolves the race locally. However, it is still unclear how that has been found out only by now.

Did you test if the change in the nmt lib actually appeases the race detector though?

the fix resolves the race locally.
@liamsi ☝🏻

But I checked over modified 0.2.1, while the PR in nmt goes over 0.3.0, which is not compatible with this PR in core

So we need to include the support for 030 here or make this PR wait while someone ads support for it in master

One second, I'll open a PR against yours in a few mins.


First Breadcrumb

Right now the first breadcrumbs brings back the site name or site title. But I don't see a way to change that name to be link "Home"

Hey @mattksand!
You could alter the way the first breadcrumb item displays using a custom renderer. Most likely you would want to customize the RenderSiteLink method which you can find the default implementation for here.
Though, you could also insert a Home link or any other HTML markup in the RenderOpeningTag method as well.


Gemini include l2 heartbeat event for sequenceId

@bmancini55 please lmk if you have any other ideas around this. You need access to the sequenceId in the heartbeat event to validate order book data, so I figured the easiest backwards-compatible solution was to just emit an l2update event without any ask or bids changes that only includes the sequenceId

@bmancini55 I've added further comments and fixed test runner

@bmancini55 I've added further comments and fixed test runner

@bmancini55 alright should be good

@bmancini55 alright should be good


Possible to have more than one landing zone implementation share core subscriptions?

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
I am interested in exploring the possibility of having 2 instances of a landing zone. Once instance would be a complete implementation with "core", "management", "networking" and "identity" resources. The second instance I would like to just implement the "core" (Landing zone management groups and associated policies) resources and point to the management, networking and identity resources of the first implementation.
The reasoning behind this is to provide "early access" of changes in applicable Azure Policy to a subset of workloads before those same policy changes are applied to the workloads in the "complete" landing zone implementation. The thinking here is that it is policy changes that workload administrators would need to evaluate and respond to whereas the mgmt/network/idm resources are more centrally managed where change can be evaluated differently and don't need to be re-implemented. Since Policy is defined at the root and "Landing Zones" levels (in addition to specific landing zones beneath), it would seem that the only way to be prepared to evaluate potential policy changes in module upgrades, etc,  would be to instantiate two different LZ implementations.
I thought I could just use the pattern of separate module instantiations with remote terraform state as shown in the wiki as a way to achieve this - but where I run into a problem is that if I define subscription_id_management/subscription_id_connectivity to have the module reference those subscription ids in policy, etc - it also wants to place those subscriptions under the core management groups and I only want them placed under the core management groups of the complete landing zone implementation (and not the core policy only implementation).
In looking at the documentation/code, I didn't see an option for preventing the module from attempting to place the subscription_id_management (as well as the the connectivity one) under the corresponding management group? Am I missing some configuration that could accomplish this? If not, it would be nice for this capability to be a new configuration feature.
Thanks for your consideration! - John

Hi! This module is somewhat opinionated - therefore it expects to deploy the core MGs in a fixed configuration.
You can disable this by deploy_core_landing_zones to false and then configuring everything as a custom_landing_zone


Fix bug to allow reading large (>4kish) files.

Simply initialise VirtioBlk::inflight to 0 in the constructor, to allow reference count to reach 0 (and fire the callback).

Can one of the admins verify this patch with one of the following commands:

"test please" for a one time test run
"ok to test" to accept latest and future commits on this pull request for testing
"add to whitelist" to add the author to the whitelist

Nice catch :+1:

ok to test


Make function signature clickable even when scrolled inside a function

Version and Platform (required):

Binary Ninja Version: 4.1.5747-dev Personal, 7558ffe9
OS: manjaro
CPU Architecture: x86_64

Bug Description:
When I am not at the top of a function i cannot click (or edit) the signature of it.
This is especially annoying inside the single function view, as the signature is displayed twice and one of them is not clickable
Steps To Reproduce:
Scroll inside a big function and try to click the function signature
Expected Behavior:
I can click the function signature even when I am not at the top of the function.
Screenshots:

Function signature clickable:

Function signature not clickable scrolled inside a function:

Single function view:

This is tracked as part of #3708, please give that issue a thumbs up so we know to prioritize it


FatalThrowableError when trying to delete a role

Hi,
I tried deleting a role with the code below:
$role = Role::findOrFail($role_id);
//dd($role);
$role->delete();
And I got the following error:
FatalThrowableError in Model.php line 956: Class name must be a valid object or a string
I've confirmed the dd dumped the correct Role instance. Also I've used the same code for deleting a permission and worked fine.
Any help would be greatly appreciated! :)

It seems to be fixed it by replacing
Config::get('auth.model') with
Config::get('auth.providers.users.model')
in EntrustRoleTrait.php  -> public function users()
So the return looks like:
return $this->belongsToMany(Config::get('auth.providers.users.model'), Config::get('entrust.role_user_table'),Config::get('entrust.role_foreign_key'),Config::get('entrust.user_foreign_key'));
Credit to ilyadavydyuk from issue https://github.com/Zizaco/entrust/issues/624

@Zizaco Please fix this Config::get('auth.model') in EntrustRoleTrait


requestAnimationFrame callback order is nondeterministic

Description
In my experience, the order of rAF callbacks is always deterministic on web. It seems like it's deterministic per spec. In other words, this:
requestAnimationFrame(() => {
  console.log('1')
})

requestAnimationFrame(() => {
  console.log('2')
})

requestAnimationFrame(() => {
  console.log('3')
})

should produce
1
2
3

That is the case on the web, but it's not in React Native.
Instead, on React Native, it's seemingly non-deterministic
Steps to reproduce
See this snack: https://snack.expo.dev/PsXPlo457DmfjCIEzRIsp?platform=ios
Expected:
1,2,3

Actual:

I believe this is the case for:

Both platforms on 0.74.*
Seemingly, only for Android on 0.76.* (maybe due to New Architecture being a default?)

React Native Version
0.76.0
Affected Platforms
Runtime - Android, Runtime - iOS
Output of npx react-native info
System:
  OS: macOS 14.6.1
  CPU: (16) arm64 Apple M3 Max
  Memory: 60.87 GB / 128.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.8.0
    path: /opt/homebrew/bin/node
  Yarn:
    version: 1.22.22
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.8.2
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2412.12266719
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.12
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.1
    wanted: 0.74.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs
N/A

Reproducer
https://snack.expo.dev/vZ6_gSpj6iB6z0tpgDnsw?platform=android
Screenshots and Videos
No response

cc @rubennorte @sammy-SC i believe you both worked in this area, is this a known issue? can lead to very subtle mistakes in app code (in our case, this led to a lightbox being permanently stuck and requiring an app restart.)

Thanks for reporting this, @gaearon!
Honestly, we need to rewrite the entire implementation for requestAnimationFrame because, apart from the problems you mentioned, it doesn't provide semantics that resemble anything on Web. They're basically glorified timers.
I don't know why the order isn't respected, but if this is happening for requestAnimationFrame then it's also happening for setTimeout, where the order should also be preserved. This is definitely a bug.
I'll add it to our backlog to prioritize it. If you'd like to contribute a fix in the meantime, please feel free to submit a PR :)


[BEAM-722] Display data infrastructure

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

@charlesccychen @robertwb @swegner The basic code structure is here. Let me know if you guys think this makes sense. This code already displays data on the UI.
The tests have silly failures that should have been fixed by my last commit. I'll squash them all together before merging.
Some of my questions:

Should we add another directory within transforms/ or should I just add one file?
For more complex cases (items that have url, label, etc), I went with a dictionary because DisplayDataItem receives other inputs such as namespace on construction. It felt more natural if these didn't have to be specified by the user - but I can change it to something else if necessary.
Let me know if you think more tests are necessary.

The Jenkins build is failing due to BEAM-753

@pabloem Jenkins failure is not related to https://issues.apache.org/jira/browse/BEAM-753. It is failing with the Too many files with unapproved license: 3 See RAT report error.
Please copy the standard license header to the new files. This should resolve the jenkins problem.

I really don't think it makes sense to reuse JAVA_CLASS. We could move towards one common CLASS type, but I think we want some way of distinguishing Java vs Python. For example, imagine a UI which recognizes Beam SDK classes by the module prefix and links to the relevant Java/Python documentation.
My preference is to add PYTHON_CLASS type and update runners. @bjchambers may also have thoughts.

After talking with @bjchambers and @robertwb, we decided to leave Python classes as STRING types until the Fn API allows us to represent classes in a generalized manner. I've updated the tests, code, and new documentation to reflect this.

I've addressed previous concerns. @robertwb PTAL : )

r: @robertwb please review : )

PTAL - I addressed the issues you pointed out.

@robertwb can you take a look?

LGTM


emergency fix for niles ignoring timezones and defaulting to GMT

bad hotfix - closed in favor of #56


manageTrailingCommas should be set by kotlingLangStyle()

🐛 Describe the bug
The upstream ktfmt uses manageTrailingCommas for kotlinlang, so the gradle plugin should also do so. See Formatter.kt and FormattingOptions.kt.
⚠ Current behavior
I have to manually enable manageTrailingCommas to match upstream ktfmt config.
✅ Expected behavior
The gradle plugin should have same default as ktfmt.
💣 Steps to reproduce
Call kotlingLangStyle().
📷 Screenshots

📱 Tech info

Device:
OS:
Library/App version:

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

I was jus testing this in our project as well, and also noticed it.

As a workaround, you could temporally use this config
ktfmt {
    kotlinLangStyle()
    manageTrailingCommas = true
}


Fix to a global leak

field and values were being added to the global scope. Fixed that.

Good eye! Thanks.


[Question]: ¿Why i can share PDFs from Android but not from iOS?

What is your question?
I'm using this library to share an PDF document into whatsapp, messenger and gmail, Android works pretty fine but in iOS i recibe a message without the pdf.

Checklist before submitting a question

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I am using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project


[DEV-9618] Update theme kit

Has been updated by renovate https://github.com/prezly/theme-nextjs-bea/pull/497


[bug] Inline links not sufficiently distinguishable from surrounding text in dark contexts

Describe the bug
By default, inline links in dark contexts are 1) not underlined (except when hovered/focused), and 2) do not have 3:1 color contrast from their surrounding paragraph text.

This is a failure of WCAG criterion 1.4.1: Use of color.
Frank Taylor first brought this up in the RHDS chat, resulting from this Red Hat Jira issue.
Which Component?
n/a
Steps to reproduce

Go to a link using one of the dark mode contexts, like the Red Hat Integration page.
Scroll to a section of the page with the dark mode context until you see some text with inline links, like this:

Inspect the link text and the regular text and do a color contrast check (WebAIM has an online checker). The regular text is #ffffff, and the link text is #73bcf7, for a contrast of 2.04:1. This is below the required 3:1 contrast ratio.

Expected behaviour
The link text should either 1) be underlined by default (pre-hover/focus), or 2) have 3:1 color contrast from the surrounding text (current fail) and also have a visual enhancement, like an underline, upon hover and focus (current pass). All normal-sized text must still meet or exceed 4.5:1 contrast from the background, too.
Screenshots
No response
Element HTML
No response
Operating System (OS)
macOS
Browser
Chrome
More browser information
Chrome 110
Additional Info
The tricky part of this may not be just a matter of picking a link color that contrasts with the non-link text. But it has to do so while keeping its sufficient color contrast against all backgrounds, too! The "dark" context could be especially tough.
Honestly, the easiest thing to do may just be to underline the inline links--at least in dark contexts.

This could be represented in docs if we aren't changing the color value with a best practices section under foundations /typography/interaction states
Thoughts @coreyvickery?
Psuedo code example: (implementation would differ based on inside a component vs on general page)
a {
  color: var(--_link-color, var(--rh-color-accent-base-on-light, #0066cc));
  text-decoration: var(--_link-decoration, none);
}

.dark a {
  --_link-color: var(--rh-color-accent-base-on-dark, #73bcf7);
  --_link-decoration: underline;
}

Do we need to fix this in tokens prior to 1.0? See also #869

@bennypowers No, something so small doesn't need to hold up 1.0.
@zeroedin Makes sense to me, Marionne or I can update the documentation when we're ready to jump back into working on ux dot again.
@hellogreg We'll probably go with adding an underline for dark theme as Steven outlined.


spatial.transform.Rotation.mul seems slow compared to np.matmul

Hello scipy team,
Thank you for the Rotation package, such a great tool, for those of us who had enough of drawing rotations.
I have a question about speed which might have to do with me holding the package wrong. I would have expected the composition operation to be relatively fast in Rotation since it seems to use quaternions in the background, so fewer operations than plain matrix multiplication but these are the numbers I get:
scipy.__version__
'1.6.2'

p = R.from_quat([0, 0, 1, 1])
q = R.from_quat([1, 0, 0, 1])

%%timeit -n 1000
r=p*q
5.65 µs ± 407 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)

a = p.as_matrix()
b = q.as_matrix()

%%timeit -n 1000
a@b
1.24 µs ± 123 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)

even einsum is faster
%%timeit -n 1000
np.einsum('ij, jk->ik', a, b)
2.09 µs ± 130 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)

Is this to be expected? For many compositions am I better off with numpy?
Thank you

Maybe @nmayorov will have some thoughts.

@elena-pascal
Rotation multiplication is done with per-rotation loop in Cython. Quaternions are multiplied by straightforward array index, multiply and sum operations. It should be reasonably fast.
But I guess numpy BLAS accelerated functions are faster. I think numpy.matmul or numpy.tensordot are worth considering as the replacement for multiplication logic in Rotation. However the sequence of operations will be quaternion -> matrix -> multiplication -> quaternion, so these additional conversions will add overhead.
If it's important for you, maybe you can try testing different approaches for single, small and large number of Rotation multiplications and send a pull request?


Undefined index: title (lexy.php) and json_encode(): Invalid UTF-8 sequence (admin.php)

I recently noticed a large error.log file filled with thousands of the here under line on a Cockpit powered one-page website:
PHP Notice:  Undefined index: title in /public_html/cockpit/vendor/Lexy.php(429) : eval()'d code on line 9
and in the cockpit directory there's another error.log file with:
PHP Warning:  json_encode(): Invalid UTF-8 sequence in argument in /public_html/cockpit/modules/core/Cockpit/admin.php on line 94
Yesterday I created another one-page and the same errors shows up.
Thought I'd report it.
Best regards,
Dennis

do you try to output $title somewhere (region?)...seems there is no field/variable name titlte

Thank you for your quick reply!
You are right, title wasn't in the collection anymore.
As for the error on the other page:
PHP Notice:  Undefined index: Datum in cockpit/vendor/Lexy.php(429) : eval()'d code on line 16
PHP Notice:  Undefined index: Extra in cockpit/vendor/Lexy.php(429) : eval()'d code on line 16
Collection Verjaardagen (birthdays)  contains three text fields Naam (name), Datum (date) and Extra.
In a Region I use:
<?php foreach(collection("Verjaardagen")->find() as $item): ?>
      <li>
        <?php echo $item["Datum"];?>
        <?php echo $item["Naam"];?>
        <?php echo $item["Extra"];?>
      </li>
   <?php endforeach;?>
I can't quite figure out what goes wrong.
My apologies for being a (partial) noob.
Best regards,
Dennis

try <?php echo @$item["Datum"];?> / <?php echo @$item["Extra"];?>


Do we need all these packages to be installed with primeqa ?

As of today 12/13/22, we've these packages:
  "bitarray~=2.3.7": ["install", "gpu"],
  "bump2version~=1.0.1": ["dev"],
  "click~=8.0.4": ["install", "gpu"],
  "datasets[apache-beam]~=2.3.2": ["install", "gpu"],
  "faiss-cpu~=1.7.2": ["install", "gpu"],
  "faiss-gpu~=1.7.2": ["gpu"],
  "gitpython~=3.1.27": ["install", "gpu"],
  "ipykernel~=6.13.0": ["notebooks"],
  "ipywidgets~=7.7.0": ["notebooks"],
  "jsonlines~=3.0.0": ["install", "gpu"],
  "ninja~=<IP_ADDRESS>": ["install", "gpu"],
  "nltk~=3.7": ["install", "gpu"],
  "packaging~=21.3": ["install", "gpu"],
  "pandas~=1.3.5": ["install", "gpu"],
  "psutil~=5.9.0": ["install", "gpu"],
  "pyarrow~=7.0.0": ["install", "gpu"],
  "pyserini~=0.16.0": ["install", "gpu"],
  "pytest~=7.1.1": ["tests"],
  "pytest-cov~=3.0.0": ["tests"],
  "pytest-mock~=3.7.0": ["tests"],
  "pytest-rerunfailures~=10.2": ["tests"],
  "scikit-learn~=1.0.2": ["install", "gpu"],
  "signals~=0.0.2": ["install", "gpu"],
  "spacy~=3.2.2": ["install", "gpu"],
  "stanza~=1.4.0": ["install", "gpu"],
  "torch~=1.11.0": ["install", "gpu"],
  "tox~=3.24.5": ["tests"],
  "transformers~=4.17.0": ["install", "gpu"],
  "sentencepiece~=0.1.96": ["install", "gpu"],
  "ujson~=5.1.0": ["install"],
  "tqdm~=4.64.0": ["install", "gpu"],
  "frozendict": ["install", "gpu"],
  "nlp": ["install", "gpu"],
  "protobuf~=3.20.0": ["install", "gpu"],
  "tabulate~=0.8.9": ["install", "gpu"],
  "rouge_score": ["install", "gpu"],
  "rouge~=1.0.1":["install"],
  "myst-parser~=0.17.2": ["docs"],
  "pydata-sphinx-theme~=0.9.0": ["docs"],
  "sphinx~=4.4.0": ["docs"],
  "sphinx_design~=0.2.0": ["docs"],
  "recommonmark~=0.7.1": ["docs"],
  "grpcio~=1.48.1": ["install", "gpu"],
  "grpcio-tools~=1.48.1": ["install", "gpu"],
  "fastapi~=0.85.0": ["install", "gpu"],
  "uvicorn~=0.18.0": ["install", "gpu"],
  "cachetools~=5.2.0": ["install", "gpu"],
  "sqlitedict~=2.0.0": ["install", "gpu"],
  ```

Can we all go through this list and just say who uses these else we remove them? We want primeqa installation process a quick one.

pyarrow is pinned because datasets would pull in a buggy version of pyarrow.
boolean: datasets, pandas, torch, transformers,

Here are the packages from the list for which I found corresponding imports in  primeqa/primeqa/ir/dense/*
bitarray
faiss-cpu
faiss-gpu
gitpython
signals
torch
tqdm
transformers
ujson

Additionally, ninja is needed for then .cpp extensions in PLAID

@vishwajeetkumar93 @riyazbhat : Could you please confirm the packages we need for tableqa and qg respectively ?


video autoplays after navigating back to the screen!

Facing the same issue too.

I am also facing the same issue.  please help


Fix typo when adding inline snapshot

Summary
This PR fixes a typo when adding an inline snapshot Couln't -> Couldn't
Test plan
Just a typo fix

Codecov Report

Merging #6656 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #6656   +/-   ##
=======================================
  Coverage   63.73%   63.73%
=======================================
  Files         235      235
  Lines        8940     8940
  Branches        3        4    +1
=======================================
  Hits         5698     5698
  Misses       3241     3241
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-snapshot/src/State.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0b1d7...eaf2cb0. Read the comment docs.


Reach Next Ascension.

For new players the first Ascension including the second and third maybe the fourth its not a big deal to reach the required level. But for people in Ascension 6 and up it is a big deal to reach required level. Cause it takes and absurd amount of time. Unless this part of the game is intentional. If that is the case then its ok. Nevermind.
But if it is no I would like to propose if its possible and it doesnt take you that much time in codding, a prestige skill point worth 5 points so new players dont get it right away, even an toggeable option  ( hidden until u reach A5 at least or not) could be if u decide to, to make an entire battle (all 100 boxes of a level) to be done in seconds. Like the game will recognize the difference between yours and enemys fleet and modules in too and a bar will start filling according to this difference and just get the resources the map offers. If the difference is enourmous the bar would fill in a second, but if there is a difference but still for thousands the bar would progress slower.
(U could add another branch of Skill points named "spy", that could tell u how much resources ull get by defeating the enemy. Or it could be under searching.)
Cause well an A7 player that can unlock titan in the very first 10 levels its quite lets say irritating to repeat all the process all over again when in fact hse did it 7 times already. This player already knows it ,.. hse just want to reach the next ascension and get over it. But it hse cant cause there are 120 levels to pass before doing them.
Of course this could bring some momentary problems. Battles provide Habittale space resources robot c. and research which these are quite necessary for progressing. Research would bring the most problem of all i believe cause if u get all of it all of a sudden and u dont have the researches u dont want in backlog this will get researched and worst of all if its not Autosorted. A solution for this would be to "Program" which researches u want before ascending so in next ascension, once unlocked these unwanted researches will be put inmediately in backlog so they dont get researched not wasting research resources in them.
Surely there are others things to consider but i cant think of them.

Can you explain about the filling bar? just skip the battle after x seconds or simulate the battle?
I think that i can put a skill point to fight more tile at same time, like you said, that would scale easily and won't be OP since at some point you won't be able to fight more tile of high level enemy at same time (or at least i suppose so).
Another funny option would be having more fleet (with increased naval cap price) that fight more time at time, unfortunately this cannot scale to x100. i cannot simply spawn 100 web worker threads.

For example the filling bar would only activate if the game detects that u can easily defeat the first row of boxes. The bar would start to fill up very fast if u do the first row in less than 5 seconds and when the bar gets fully filled up u receive the entirety of the resources that enemy has to offer.
The bar could be in any of these two spaces.

After u get the resources you would jump directly into the Next level enemy if u have a certain amount of search. This would be the main purpose of the bar, as you said it would be to skip the level faster. Because the player already knows he will defeat it very easily the first 100 levels.
More tiles at the same time would be a good solution too. Of course after 80 90 100 110 level this wont be the case because a box starts to take more than just a second to defeat. Here u can put some strategy into the game in skill points. I think it would be after the -0.3 fight time. Or only unlockable after A4 or 5 and having the fight time skill point.
More fleet would also be another option, yeah i agree but that would take the difficulty of higher levels unbalancing the game if i think of it correctly.
Another option i thought of these days was to implement a boss after the 100 boxes. So after certain amount of ascensions you would only fight the boss of every level and so skipping all the boxes if u have higher module power than the enemy level. Like just seize the entire city/planet/fleet by defeating the mothership or the central defenses.... Idk .. just a thought.
Id suggest to add the github page to kongregate in a more visible manner, so more people can come in here and post many suggestions for exapanding or adding more content to the game. Many people dont even know it was made here in github nor that it even exists this platform.

@darkniko So basically your original request was a toggle to combine the whole enemy fleets on the map into one big fleet.
Basically your 10000 ships vs their maximum 1000000 ships.
Is that right?
@scorzy Having more fleet doesn't mean more web workers, it doesn't care which player fleets are battling if the player has more than one, it only care about what 2 fleets that it's given contain and simulate the battle between them.
The current web worker can handle at least 10 times more fleet on my old computer,  newer modern computer probably can handle more.
Most of the time is spend on GC, having more fleet or ships would only made that worse, unless an object pool is used.  (I am assuming GC is the reason why the fleet is limited to 10k ship)
With an object pool, the performance doubled on my computer with the current workload, it should perform way better if there more fleet (not ship) fighting since it wouldn't be creating and discarding 50000+ object max per fleet per fight causing major GC.
I have a branch on my repo that implement it cause I have a memory growth issue but it seem like the cause wasn't the web worker and it turns out to be an non-issue so I didn't create a pull request.
But if you intent to have more than one fleet for the player, a pull request can be created using
https://github.com/scorzy/IdleSpace/compare/master...asl97:object_pool?expand=1

Just to clarify, using an object pool will improve performance for more ship too.
Just not as much as more fleet (battle/fight).

@asl97 can you send a pull request? optimization is always welcome

@scorzy since you asked, I went ahead and created it.
You know, you could have done it yourself by following the branch compare link.

thanks


Improve Branding feature to support multiple variations of the same screen.

Describe the issue:
In the current branding feature set, it only supports one versions of the screen to be previewed when editing the texts. However there can be instances where the page considered is dynamic and has multiple versions where the editable texts are not all available in the same screen. The current feature set cannot address this requirement.

Improvement description
The following changes are to be made.

Introduce a new "VARIATIONS" meta tag to the meta tags used in resource properties to identify and assign i18n keys to screens.
Improve the populate-branding-i18n-defaults script to support the newly introduced meta tag.
Add drop down to select the variation for the screens that have multiple variations.

Key design decisions

VARIATIONS meta tag will support multiple variations to be included as string of space separated variations.
A variation will not be bound to a particular screen and can be reused with any available screen.
eg : The variation "sms-otp" can be in the variation list of a "password-recovery" screen as well as "username-recovery" page.
A base variation can be set for all screens which will be the initial view at the preview pane.
A basic variation  base will be assigned to all screens that do not have a base variations specified.
The variations will only be displayed under text customization. The other branding sub features will use the base variation of the screen.

Instructions to add a new variation of a screen

Add the new variation type to the VARIATIONS meta tag value set of the i18n strings in Resources.properties  that are introduced in the variation.
Add the new variation type to the PreviewScreenVariationType in branding-preferences.
Update the BrandingNS.variations in branding-ns.ts file and in branding.ts file.
Change the screen skeleton to pick the new variation type and change the preview accordingly.
This logic will have to be implemented newly if no variations are currently in use for the screen.
Note : use the i18n strings where necessary in the newly added screen variation.
Change the base display variation in the BASE_DISPLAY_VARIATION constant in custom-text-preference.ts file.

This was onboarded with the Password recovery via SMS OTP feature. Hence closing the issue.


feat: use EvenEmitter3 for web-sdk

This PR

Fixes an issue where the events node polyfill does not comply to the node:events types.
When trying to use the web OpenFeatureEventEmitter the following error message comes up, describing that the events polyfill's EventEmitter is incompatible to node:events EventEmitter.
✘ [ERROR] TS2416: Property 'eventEmitter' in type 'OpenFeatureEventEmitter' is not assignable to the same property in base type 'GenericEventEmitter<ProviderEmittableEvents, Record<string, unknown>>'.
  Type 'EventEmitter' is not assignable to type 'PlatformEventEmitter'.
    Types of property 'addListener' are incompatible.
      Type '(type: string | number, listener: Listener) => EventEmitter' is not assignable to type '(eventName: string | symbol, listener: (...args: any[]) => void) => PlatformEventEmitter'.
        Types of parameters 'type' and 'eventName' are incompatible.
          Type 'string | symbol' is not assignable to type 'string | number'.
            Type 'symbol' is not assignable to type 'string | number'.

This PR fixes that issue by not using the events anymore and instead using https://www.npmjs.com/package/eventemitter3
cc @toddbaert
Related Issues

Fixes #845

@lukas-reining @beeme1mr I pushed a small change to remove @types/events since it's not needed now.

@lukas-reining @beeme1mr I pushed a small change to remove @types/events since it's not needed now.

Ah sure missed that one thanks!


Add bioconda recipe for psirc

Description of feature
Currently there is only a custom image available via dockerhub. We should find a cleaner solution, most likely via a bioconda recipe.

Bioconda recipe added via this PR.
Once the containers become public, the environment definition should be updated


[NFC] Make NSCopying a known protocol

Adds NSCopying to KnownProtocols.def, removes it from KnownFoundationEntities.def, and updates a couple places where we looked it up manually to use ASTContext::getProtocol().

@swift-ci please smoke test

Probably supersedes the ClangImporter's getNSCopyingType, too.

@jrose-apple I think getNSCopyingType() gets the clang version of the type. Am I wrong? Or is that true but not an obstacle?

No, it's going for the type-as-imported. But maybe it makes sense for Clang to do the lookup more directly. (Or maybe it doesn't, since we have lookup tables for Swift.)

Anyway, that doesn't have to go into this PR.

@swift-ci please smoke test

The KnownProtocol mechanism uses a form of lookup that doesn’t look into underlying clang modules, so I had to switch approaches, instead sharing implementation with e.g. getNSErrorDecl().

@jrose-apple I've converted over the ClangImporter use too. (I tried doing the same thing for the use of NSObjectProtocol, but the straightforward change broke a test involving a typedef'd protocol and I didn't want to go off on a tangent debugging it.)
@swift-ci please smoke test


⚠ Bofrost.com has degraded performance

In c9b6500, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 418 ms

Resolved: Bofrost.com performance has improved in 07aa15f after 8 minutes.


Bug: dup followed by assign

So, this has me stumped.  I think I should try to reproduce this in C and see if it's fixed on master of SS:GraphBLAS.
    A = Matrix.from_values([0], [0], [1])
    B = A.dup(dtype=float)
    B[0, 0] = 0.1
    assert B[0, 0].value == 0.1  # Fails!  value is 0; it is being coerced to an integer

Fixed in 3.3.1.


Encode documentation html files as UTF-8

This makes the diffs generated by git as part of future changes (for example typo fixes) to these files easier to read. This PR only includes html files whose contents would change when encoding them as utf-8. These encoding differences are caused by the "non-breaking space" character (U+00A0 / 0xA0 in ISO-8859-1), which is included in these html files. Github renders them as a normal space, so the diff looks a bit weird.

These file are auto-generated from source xml files, so the change would have to be made there.

If you correct it at the source and force push to this PR, we can reopen it.

I didn't manage to get the commits to this branch to appear in here, so instead I created a new branch and a new PR (#5482). As such, I think this PR can remain closed and I hope the other PR is merged :slightly_smiling_face: .


npmrc registry cafile config not respected

When using a custom registry a custom certificate might also be required. Yarn and NPM support a cafile property in the npmrc to specify a custom certificate.

So, this may not be a fix for the npmrc file issue, but this was helpful for me when dealing with my org's custom certs.
I was having an issue where pnpm install was failing because it wasn't recognizing our my custom certificate ("self-signed certificate" error) whereas the yarn_install rule of rules_nodejs, worked fine. The problem was that I was I had an environment variable configuration for my own certs called NODE_EXTRA_CA_CERTS that was already set on my local machine.
But rules_js is (probably) more hermetic and scrubbing the local environment variables whereas the yarn_install workspace rule  from rules_nodejs (probably) does not.
So the workaround, was to simply set this variable again in my .bazelrc file.
build --action_env=NODE_EXTRA_CA_CERTS='/etc/ssl/certs/my-ca-cert.crt'

And that was able to get everything to work. Just another FYI, I found that passing in my cert into the bazel jre itself, didn't matter in this case. It would matter for doing an HTTP_ARCHIVE rule, but it didn't matter for my PNPM install rule whether it was set or not.


cocoapods support?

i use cocoapods for development and would like to use this library in my project. Can you please upload a podspec?

Hi, thanks for your interest!
I'll be adding CocoaPods support shortly and I'll send you a message as
soon as it's published.
Cheers,
Stephane
On Fri, Oct 5, 2018 at 9:25 AM jafara<EMAIL_ADDRESS>wrote:

i use cocoapods for development and would like to use this library in my
project. Can you please upload a podspec?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scribd/LiveCollections/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AkffrhFOuI8pQyXADY9IlQ3_cBAzdAcpks5uh4fcgaJpZM4XKihe
.

CocoaPods is now supported!
Add either line to your Podfile:
pod 'LiveCollections', '~> 0.9.6'
pod 'LiveCollections'
Cheers,
Stephane
On Fri, Oct 5, 2018 at 10:16 AM Stephane Magne<EMAIL_ADDRESS>wrote:

Hi, thanks for your interest!
I'll be adding CocoaPods support shortly and I'll send you a message as
soon as it's published.
Cheers,
Stephane
On Fri, Oct 5, 2018 at 9:25 AM jafara<EMAIL_ADDRESS>wrote:

i use cocoapods for development and would like to use this library in my
project. Can you please upload a podspec?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/scribd/LiveCollections/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AkffrhFOuI8pQyXADY9IlQ3_cBAzdAcpks5uh4fcgaJpZM4XKihe
.

CocoaPods officially supported as of version 0.9.6


Expose proxyReqWs events

We can add a onProxyReqWs callback analogous to onProxyReq for the proxyReq events.
Alternatively, we could expose the proxy object itself.  That'd probably give the user the most flexibility in attaching callbacks.

Totally forgot to expose this event; which has been added in http-proxy v1.12.0
https://github.com/nodejitsu/node-http-proxy/compare/1.11.3...1.12.0
Thanks for reporting!

Just published v0.12.0.
With this release, you can subscribe to all events from http-proxy.
I've added the missing ones: proxyReqWs, open and close.


Change 'node_start_ip' answerfile variable to 'node_ip'

This PR is to fix https://github.com/viniciusferrao/cloysterhpc/issues/48
Change node_start_ip to node_ip because it does not increment automatically right now.

Alright that makes sense. Thanks.


cephfs: set Pool parameter to empty for Snapshot-backed volumes

Describe what this PR does
Set VolumeOptions.Pool parameter to empty for Snapshot-backed volumes. This Pool parameter is optional and  only used as 'pool_layout' parameter during subvolume and subvolume clone create request in cephcsi and not used for Snapshot-backed volume at all.
It is not saved anywhere for use in subsequent operations after create too. Therefore, We can set it to empty and not error out.
Refer: https://docs.ceph.com/en/latest/cephfs/fs-volumes/?highlight=pool_layout#fs-subvolumes
Resolves: #3820

/test ci/centos/mini-e2e/k8s-1.27

@mergifyio rebase


test suite does not launch from a nested directory path

running the test suite from here will work:
/Users/username/qaopensource-framework
running the test suite from here will not work:
/Users/username/workspace/qaopensource-framework
error thrown:
Traceback (most recent call last):
File "suite_runner.py", line 462, in
CONFIG_PARSER.set('browserstack_caps', 'os', create_caps_arr_mod[0]['os'])
KeyError: 'os'

Working on a fix. Should have it in tomorrow.

Do you have an eta on this fix?

:-(

I have been swamped and have had zero time for personal projects. I think
about it almost every day, but there is just no time. You may want to open
a pull request with a fix if you some time.

Reply to this email directly, view it on GitHub
https://github.com/qaopensource/qaopensource-framework/issues/2#issuecomment-306316657,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATniLV5CkLxwGsreY0L-jlqzOTQ1YLxks5sBHQygaJpZM4NZyup
.


npm update Electron

contains webview security-related patch, and service worker fixes + others (see https://github.com/electron/electron/releases/tag/v1.8.4 )

Please wait before merging, I have problems with NPM 5.7.1 so I am downgrading to 5.6.0.
See:
https://github.com/npm/npm/issues/18758#issuecomment-373933957

Okay, both package.json and package-lock.json are now synchronized. I am testing the app again (npm run start).

App tested okay, I will ensure NPM remains at version 5.6.0 for future updates!


[Bug] Possible threadlock when using load_scene_interactive()

The load_scene_interactive() method of the SceneManager is hardcorded to use use_sub_threads = true when calling ResourceLoader.load_threaded_request(). In the newest versions of Godot there seems to be a bug that can cause a threadlock in the resource loader that will result in infinite loading of the scene without any error.
This is likely cause by use of the preload() function shortly prior to or at the same time as ResourceLoader.load_threaded_request() with use_sub_threads = true.
See the following two GitHub issues:
https://github.com/godotengine/godot/issues/85255
https://github.com/godotengine/godot/issues/84012
It would be cool to add a warning somewhere in the scene manager documentation about it until its fixed and maybe give the option to set use_sub_threads = false when calling load_scene_interactive().
Thank you very much, this plugin is awesome!

This seems to be the reason why I couldn't load my scene beyond the 70% mark.


Fixed scores error, update new scores to db

Saving the policy ranker instance itself because sqlite file only holds the data and it seems too much change to initialize a new ranker from it.


updated local and task types

You'll also need to update each occurance where Task and LocalTask are used in other files to get building working and the tests to pass.

I made some changes in the exec.rs file, as well as a couple more in the lib.rs file.
I took a look at the results of tests you ran, and it looked like the errors were coming from the lib.rs file.

thank you for your patience and working with me on this! its very much appreciated

thank you for your patience and working with me on this! its very much appreciated

Sure thing - thanks for taking on this task!  Looks good to merge once all the tests finish.


Allow Dev Console to be embedded as an iframe

Related to https://github.com/Shopify/shopify-cli-extensions/issues/306
Fix issue where the name was set incorrectly - should be set to the extension title
Support embedded the Dev Console as an iframe:

Show the QR Code in a modal instead of the popover so the position is fixed. Previously this was opened as popover which doesn't work well when the Dev Console embedded as an iframe as it can be positioned off screen
Make the extension link action emit a navigate event instead of opening the deep link to load the local extension

https://user-images.githubusercontent.com/29458473/168893823-b12713f5-00a8-42a6-80d4-38a6fee0c8c2.mov
Tophat
NOTE: You will see extensions that are not related to Admin. This is expected until the Dev Console can take a param to filter by surface areas which will be handled in a subsequent PR.

Use my spin shop: shop1.shopify.app-bridge-svve.trish-ta.us.spin.dev
Pull this branch and run make clobber; make bootstrap
Run ngrok http 8000 and make note of the tunnel url
Modify the testdata/extension.config.yml to point to my shop on Spin and update the public_url to point to your tunnel url

-public_url: https://example.ngrok.io
+public_url: https://TUNNEL-URL
-store: test-shop.myshopify.com
+store: shop1.shopify.app-bridge-svve.trish-ta.us.spin.dev

Remove all extensions except for Product Subscription as the other ones will not work in this PR and are not currently being filtered out. Your extensions should look like this:
extensions:
  - uuid: 00000000-0000-0000-0000-000000000002
    type: product_subscription
    title: Product Subscription Test Extension
    development:
      root_dir: 'tmp/product_subscription'
      build_dir: 'build'
      template: 'typescript-react'
      renderer:
        name: '@shopify/admin-ui-extensions'
        version: '^1.0.1'
      entries:
        main: 'src/index.tsx'

Run make run serve testdata/extension.config.yml
Click on the deep link to open the Product Subscription extension in my shop on Spin
Verify that you can open the Dev Console as an iframe and the following all work:

[ ] you can click the X button to hide the Dev Console when it's visible
[ ] you can click from the Dev Console link in the side bar to show the console when it's hidden
[ ] hovering on the Product Subscription extension should highlight that extension
[ ] clicking on the show/hide icon for the Product Subscription extension should show/hide the extension
[ ] clicking on the QR Code icon should bring up the QR code in a modal
[ ] clicking on the link for the Product Subscription extension should navigate to the product details page for the first product if you're not already on the page

Not related to this PR, but the checkbox on the extension table isn't working (probably some race condition).

This issue is captured here https://github.com/Shopify/shopify-cli-extensions/issues/202


Fix potential race condition

Fixes #UI-555
Changes proposed in this pull request:

Help prevent race condition between blocknative txConfirmation and allowances update onchain

@garethfuller I've actually encountered this type of issue before (The claim button uses both blocknative / infura to deal with the race issue). So essentially after your fire the listener you also wait for the transaction to be mined via await tx.wait()
I kinda think the long-term solution would actually be not to use Blocknative for transactions and roll our own transaction handler. (Gnosis for example needs a custom solution anyway and cannot use Blocknative)


[Usage]: How to use LoRARequest with AsyncLLMEngine?

Your current environment
Collecting environment information...
PyTorch version: 2.1.2+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: version 3.29.2
Libc version: glibc-2.35

Python version: 3.10.14 | packaged by conda-forge | (main, Mar 20 2024, 12:45:18) [GCC 12.3.0] (64-bit runtime)
Python platform: Linux-5.15.0-56-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 11.6.124
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce RTX 3090
Nvidia driver version: 535.154.05
cuDNN version: Probably one of the following:
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn.so.8
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn_adv_infer.so.8
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn_adv_train.so.8
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn_cnn_infer.so.8
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn_cnn_train.so.8
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn_ops_infer.so.8
/usr/local/cuda-11.6/targets/x86_64-linux/lib/libcudnn_ops_train.so.8
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   39 bits physical, 48 bits virtual
CPU(s):                          20
On-line CPU(s) list:             0-19
Thread(s) per core:              2
Core(s) per socket:              10
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           165
Model name:                      Intel(R) Core(TM) i9-10900K CPU @ 3.70GHz
Stepping:                        5
CPU MHz:                         3700.000
CPU max MHz:                     5300.0000
CPU min MHz:                     800.0000
BogoMIPS:                        7399.70
Virtualization:                  VT-x
L1d cache:                       320 KiB
L1i cache:                       320 KiB
L2 cache:                        2.5 MiB
L3 cache:                        20 MiB
NUMA node0 CPU(s):               0-19
Vulnerability Itlb multihit:     KVM: Mitigation: VMX disabled
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Mmio stale data:   Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed:          Mitigation; Enhanced IBRS
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:             Mitigation; Microcode
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp pku ospke md_clear flush_l1d arch_capabilities

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] torch==2.1.2
[pip3] triton==2.1.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] torch                     2.1.2                    pypi_0    pypi
[conda] triton                    2.1.0                    pypi_0    pypiROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.0.post1
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	CPU Affinity	NUMA Affinity	GPU NUMA ID
GPU0	 X 	0-19	0		N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

How would you like to use vllm
We want to use LoRA with AsyncLLMEngine, but there is no examples.
We mimicked official tutorial , add LoRARequest to generate method,
but got error message:
TypeError: object of type 'LoRARequest' has no len()

Is that possible use LoRA adapter with AsyncLLMEngine?

AsyncLLMEngine  support LoRA, refer to :https://github.com/vllm-project/vllm/blob/main/vllm/engine/async_llm_engine.py#L558

https://docs.vllm.ai/en/latest/models/lora.html

Yes, vllm supports. Enable lora and create LoRARequest when generate.
We use fast api example,
modify main with:
args.enable_lora=True
args.max_loras=1
args.max_lora_rank=8
args.max_cpu_loras=2
args.max_num_seqs=256

modify generate with:
results_generator = engine.generate(prompt, sampling_params, request_id,LoRARequest("jho8useyrjbhkwuyu", 1, path_to_lora_folder))

run api_server.py, service started,
than run command in terminal:
curl -X POST http://<IP_ADDRESS>:8000/generate    -H 'Content-Type: application/json'    -d '{"prompt":"hello, how do you do? "}'

service log:
Received request 54c05950315b48f48de87e45088ab2f3: prompt: 'hello, how do you do? ', sampling_params: SamplingParams(n=1, best_of=1, presence_penalty=0.0, frequency_penalty=0.0, repetition_penalty=1.0, temperature=1.0, top_p=1.0, top_k=-1, min_p=0.0, seed=None, use_beam_search=False, length_penalty=1.0, early_stopping=False, stop=[], stop_token_ids=[], include_stop_str_in_output=False, ignore_eos=False, max_tokens=16, min_tokens=0, logprobs=None, prompt_logprobs=None, skip_special_tokens=True, spaces_between_special_tokens=True), prompt_token_ids: LoRARequest(lora_name='jho8useyrjbhkwuyu', lora_int_id=1, lora_local_path=path_to_lora_folder), lora_request: None.

and dump error log:
Exception in callback functools.partial(<function _raise_exception_on_finish at 0x7f990a1a0dc0>, error_callback=<bound method AsyncLLMEngine._error_callback of <vllm.engine.async_llm_engine.AsyncLLMEngine object at 0x7f990837a680>>)
handle: <Handle functools.partial(<function _raise_exception_on_finish at 0x7f990a1a0dc0>, error_callback=<bound method AsyncLLMEngine._error_callback of <vllm.engine.async_llm_engine.AsyncLLMEngine object at 0x7f990837a680>>)>
Traceback (most recent call last):
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 38, in _raise_exception_on_finish
    task.result()
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 480, in run_engine_loop
    has_requests_in_progress = await asyncio.wait_for(
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/asyncio/tasks.py", line 445, in wait_for
    return fut.result()
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 439, in engine_step
    await self.engine.add_request_async(**new_request)
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 258, in add_request_async
    return self.add_request(request_id,
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 325, in add_request
    seq = Sequence(seq_id, prompt, prompt_token_ids, block_size,
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/sequence.py", line 208, in __init__
    self._append_tokens_to_blocks(prompt_token_ids)
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/sequence.py", line 248, in _append_tokens_to_blocks
    while cursor < len(token_ids):
TypeError: object of type 'LoRARequest' has no len()

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "uvloop/cbhandles.pyx", line 63, in uvloop.loop.Handle._run
  File "/home/wonder/anaconda3/envs/vllm-310/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 45, in _raise_exception_on_finish
    raise AsyncEngineDeadError(
vllm.engine.async_llm_engine.AsyncEngineDeadError: Task finished unexpectedly. This should never happen! Please open an issue on Github. See stack trace above for the actual cause.

@Rares9999
[rank0]: Traceback (most recent call last):
[rank0]:   File "/home/data/app/vllm/vllm_api_Qwen.py", line 196, in
[rank0]:     generation_config,tokenizer,stop_words_ids,engine,lora_request = load_vllm(args_parameter)
[rank0]:   File "/home/data/app/vllm/vllm_api_Qwen.py", line 64, in load_vllm
[rank0]:     engine=AsyncLLMEngine.from_engine_args(args)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 398, in from_engine_args
[rank0]:     engine = cls(
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 349, in init
[rank0]:     self.engine = self._init_engine(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 473, in _init_engine
[rank0]:     return engine_class(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 236, in init
[rank0]:     self._initialize_kv_caches()
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 313, in _initialize_kv_caches
[rank0]:     self.model_executor.determine_num_available_blocks())
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/executor/gpu_executor.py", line 75, in determine_num_available_blocks
[rank0]:     return self.driver_worker.determine_num_available_blocks()
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
[rank0]:     return func(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/worker/worker.py", line 162, in determine_num_available_blocks
[rank0]:     self.model_runner.profile_run()
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
[rank0]:     return func(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 844, in profile_run
[rank0]:     self.execute_model(seqs, kv_caches)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
[rank0]:     return func(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 749, in execute_model
[rank0]:     hidden_states = model_executable(
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/model_executor/models/qwen2.py", line 330, in forward
[rank0]:     hidden_states = self.model(input_ids, positions, kv_caches,
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/model_executor/models/qwen2.py", line 254, in forward
[rank0]:     hidden_states, residual = layer(
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/model_executor/models/qwen2.py", line 216, in forward
[rank0]:     hidden_states = self.mlp(hidden_states)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/model_executor/models/qwen2.py", line 75, in forward
[rank0]:     gate_up, _ = self.gate_up_proj(x)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank0]:     return self._call_impl(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in call_impl
[rank0]:     return forward_call(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/lora/layers.py", line 470, in forward
[rank0]:     output_parallel = self.apply(input, bias)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/lora/layers.py", line 600, in apply
[rank0]:     _apply_lora_packed_nslice(
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/lora/layers.py", line 129, in _apply_lora_packed_nslice
[rank0]:     add_lora_slice(output, x, lora_a_stacked[slice_idx],
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/lora/punica.py", line 196, in add_lora_slice
[rank0]:     ops.dispatch_bgmv_low_level(
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/_custom_ops.py", line 34, in wrapper
[rank0]:     return fn(*args, **kwargs)
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/vllm/_custom_ops.py", line 472, in dispatch_bgmv_low_level
[rank0]:     torch.ops._punica_C.dispatch_bgmv_low_level(
[rank0]:   File "/home/fist/miniconda3/envs/vllm/lib/python3.10/site-packages/torch/ops.py", line 854, in call
[rank0]:     return self._op(*args, **(kwargs or {}))
[rank0]: RuntimeError: No suitable kernel. h_in=8 h_out=18944 dtype=Float out_dtype=BFloat16


Fix markdown to support collapsible-sections in Github pages

Fix markdown to support normal Github markdown inside collapsible-sections in Github pages

There is a lot of unclear and sometimes conflicting guidance for doing so for pages that employed collapsible sections and Github markdown.  For this site, the most important fixes were:

Always put an empty line after collapsible section tags.
Put double quotes around any string that included whitespace in the site config file (_config.yml).
Use the markdown: GFM processor in the site config file (_config.yml).

My _config.yml file:
title: "Recreational Reading Log"
description: "List of my reading since 2022 July 25"
logo: https://mccright.github.io/rrl/m.svg
# https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/setting-a-markdown-processor-for-your-github-pages-site-using-jekyll
markdown: GFM

It is deployed at: https://mccright.github.io/rrl/


{AKS} Vendor new SDK and bump API version to 2024-05-01

Related command

Description

{AKS} Vendor new SDK and bump API version to 2024-05-01
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AKS


[SPARK-25464][SQL] Create Database to the location,only if it is empty or does not exists.

Modification content:If the database is created with location URI then should be empty/should not exists
What changes were proposed in this pull request?
If the user specifies the location while creating the Database then location should be empty or should not exists
for e.g create database db1 location '/user/hive/warehouse';
this command will be passed only if 'user/hive/warehouse' is empty or should not exists.
How was this patch tested?
Added testcases and also manually verified in the cluster

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@sandeep-katta can you please update the tile, i think as per your description it seems to be the data will be dropped if the location of the newly created database points to some existing database location.

@srowen @HyukjinKwon  I think this can be a risk if the location of the newly created database points to an existing one, if user drop the db both the db data will be lost .

See JIRA, I don't think this should be merged.

Yes I agree 2 database should not point to same path,currently this is the loop hole in spark which is required to fix.If this solution is not okay ,then we can append the dbname.db to the location given by the user
for e.g
create database db1 location /user/hive/warehouse
then the location of the DB should be /user/hive/warehouse/db1.db

See JIRA, I don't think this should be merged.

I have referred Databricks doc https://docs.databricks.com/spark/latest/spark-sql/language-manual/create-database.html and implemented accordingly.Let me know if any suggesstion

We should look at Spark documentation, and Hive, if any, to figure out what the right behavior is here. Spark generally follows Hive. See https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateTableCreate/Drop/TruncateTable  I think this is, further, conflating what LOCATION and EXTERNAL does. I agree that external DB files shouldn't be deleted, but not simply those specified by LOCATION. At least that is my understanding.
@yhuai or @cloud-fan or @clockfly might know more.

I'm not sure if there is a concept called "external database" in Hive...

There is ... see https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ManagedandExternalTables
I think Spark conflates the two. It's rare (?) but possible to specify a custom location of a managed table, but, typically occurs for EXTERNAL tables. So maybe this is OK.
  private def createTable(tableIdent: TableIdentifier): Unit = {
    val storage = DataSource.buildStorageFormatFromOptions(extraOptions.toMap)
    val tableType = if (storage.locationUri.isDefined) {
      CatalogTableType.EXTERNAL
    } else {
      CatalogTableType.MANAGED
    }

And in SqlParser:
    // If location is defined, we'll assume this is an external table.
    // Otherwise, we may accidentally delete existing data.
    val tableType = if (external || location.isDefined) {
      CatalogTableType.EXTERNAL
    } else {
      CatalogTableType.MANAGED
    }

So if LOCATION implies EXTERNAL in Spark, then I get this. EXTERNAL tables shouldn't be deleted.
I agree that the Hive impl doesn't seem to take this into account, on the code paths that call dropDatabase. CC @andrewor14 in case he is available to comment on the original implementaiton. WDYT @cloud-fan

That link says Hive does support EXTERNAL. What am I missing? Well, in any event we aren't contemplating a behavior change here.
If you delete a table with LOCATION specified, what should happen? Hive would delete it I guess... unless it's EXTERNAL. Looks like Spark would delete it even when it's in an 'external' location.
If these are conflated I guess we weigh the surprise in not deleting 'local' locations for data when a table is dropped, vs surprise in deleting 'external' locations for data.

That link says Hive does support EXTERNAL. What am I missing?

Hive supports EXTERNAL only for tables, not databases.
The CREATE TABLE syntax:
CREATE [TEMPORARY] [EXTERNAL] TABLE [IF NOT EXISTS] [db_name.]table_name ...

The CREATE DATABASE syntax:
CREATE (DATABASE|SCHEMA) [IF NOT EXISTS] database_name ...

Owp, I've been misreading that several times. Right. Well by analogy, if a database has a non default LOCATION then so do it's tables, and they are treated like EXTERNAL tables. Dropping the DB means dropping the tables, and dropping those tables doesn't delete data. So should the same happen for DBs? Seems sensible, because the DB directory might not even be empty.
Still I feel like I'm missing something if it only comes up in the case that two DBs have the same location, which is going to cause a bunch of other problems.
But is it the right change simply because it's consistent with how dropping tables works?

This is a behavior change and makes us different from Hive. However I can't find a strong reason to do it. It's like importing a database, but we can't automatically create table entries in the metastore when creating a database with an existing location.
To me a more reasonable behavior is, fail earlier when creating a database with an existing and non-empty location.

seems @cloud-fan  comments are valid as it will not result in any behavior change, I will update the PR accordingly WDYT @srowen

cc @cloud-fan @srowen  I have updated the code,Please review

ok to test

Test build #96601 has started for PR 22466 at commit 597f8e6.

Test build #96601 has finished for PR 22466 at commit 597f8e6.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96601/
Test FAILed.

Test build #96619 has finished for PR 22466 at commit 597f8e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96619/
Test PASSed.

Test build #96689 has started for PR 22466 at commit 943b7fd.

Test build #96689 has finished for PR 22466 at commit 943b7fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96689/
Test FAILed.

I am running the same test case with hive version 1.2.1.spark2  and it is passing,can I know with what hive version CI is running and how org.apache.hive.jdbc.HiveStatement  and external catalog are linked,I don't see any such code. cc @cloud-fan @gatorsmile

Test build #96730 has started for PR 22466 at commit 7d28da0.

Test build #96730 has finished for PR 22466 at commit 7d28da0.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96730/
Test FAILed.

Test build #96736 has started for PR 22466 at commit f05d7c1.

Test build #96736 has finished for PR 22466 at commit f05d7c1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96736/
Test FAILed.

Test build #96750 has started for PR 22466 at commit 63dc53a.

Test build #96750 has finished for PR 22466 at commit 63dc53a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96750/
Test FAILed.

Test build #96768 has started for PR 22466 at commit 3c2831b.

Test build #96768 has finished for PR 22466 at commit 3c2831b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96768/
Test FAILed.

Test build #96766 has finished for PR 22466 at commit 86e4d50.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96766/
Test FAILed.

Test build #96929 has started for PR 22466 at commit 7577a5a.

@sandeep-katta Can you update the PR title?

Test build #97118 has finished for PR 22466 at commit c50e99b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97118/
Test PASSed.

@cloud-fan @gatorsmile if everything is okay,can you please merge this PR

The major comments are in the test cases. Could you help clean up the existing test cases?

Test build #97158 has started for PR 22466 at commit b837d48.

Test build #97158 has finished for PR 22466 at commit b837d48.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97158/
Test FAILed.

Test build #4364 has started for PR 22466 at commit b837d48.

Test build #97169 has started for PR 22466 at commit 5d95a09.

Test build #4364 has finished for PR 22466 at commit b837d48.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

you can type the same thing, the jenkins will work for you :)

Test build #97182 has started for PR 22466 at commit 5d95a09.

Test build #97182 has finished for PR 22466 at commit 5d95a09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97182/
Test PASSed.

The major comments are in the test cases. Could you help clean up the existing test cases?

All the comments are fixed and corrected the testcases

Test build #97434 has started for PR 22466 at commit d290998.

Test build #97434 has finished for PR 22466 at commit d290998.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97434/
Test FAILed.

retest this please

Test build #4381 has started for PR 22466 at commit d290998.

Test build #4381 has finished for PR 22466 at commit d290998.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@cloud-fan @gatorsmile all the testcases are passed and review comments are addressed,can you help me to merge this PR please

Btw, what if create database if not exists ...? Seems like an exception will be thrown if the table exists even if we specify if not exists?

Btw, what if create database if not exists ...? Seems like an exception will be thrown if the table exists even if we specify if not exists?

Good catch :+1:  ,I have updated the code accordingly

Test build #97544 has started for PR 22466 at commit 619c396.

Test build #97548 has started for PR 22466 at commit 675ab8c.

Test build #97550 has started for PR 22466 at commit d862591.

Test build #97548 has finished for PR 22466 at commit 675ab8c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97548/
Test PASSed.

Test build #97544 has finished for PR 22466 at commit 619c396.

This patch fails PySpark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97544/
Test FAILed.

retest this please

Test build #97589 has finished for PR 22466 at commit d862591.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97589/
Test FAILed.

Test build #97602 has finished for PR 22466 at commit 28a086d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97602/
Test PASSed.

Test build #97614 has started for PR 22466 at commit b091996.

Test build #97615 has started for PR 22466 at commit 570c5b7.

Test build #97614 has finished for PR 22466 at commit b091996.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97614/
Test PASSed.

Test build #97615 has finished for PR 22466 at commit 570c5b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97615/
Test PASSed.

cc @gatorsmile if everything is okay ,this PR can be merged ?

Regarding the potentially high cost of file listing, CREATE DATABASE is not a frequent operation. The cost is high only if the target directory is non-empty with many many files. We are blocking users from creating such a database. Thus, the cost is not a big deal I think.
We need to list this behavior change in the SQL migration guide.

Test build #103122 has started for PR 22466 at commit 6f4c9ce.

@gatorsmile I have updated the SQL migration guide

Test build #103124 has started for PR 22466 at commit 6532466.

Test build #103124 has finished for PR 22466 at commit 6532466.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #103122 has finished for PR 22466 at commit 6f4c9ce.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103122/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103124/
Test FAILed.

retest this please

Test build #103130 has started for PR 22466 at commit 6532466.

Test build #103130 has finished for PR 22466 at commit 6532466.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103130/
Test FAILed.

retest this please

retest this please

Test build #103252 has started for PR 22466 at commit 6532466.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8696/
Test PASSed.

Test build #103252 has finished for PR 22466 at commit 6532466.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103252/
Test PASSed.

cc @srowen  @cloud-fan @gatorsmile

Can one of the admins verify this patch?

ping @srowen @gatorsmile @ueshin @cloud-fan . Please check now this can be merged to master branch for spark-3.0 release . I am happy to do any more code/documentation changes if required.

Test build #108984 has started for PR 22466 at commit 0a52bdc.

Test build #108984 has finished for PR 22466 at commit 0a52bdc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108984/
Test FAILed.