[FLINK-6811][table] Add TIMESTAMPADD supported in SQL

In this PR I have add TIMESTAMPADD supported in SQL. (the semantics keep consistent with calcite)

Syntax
timestampAdd (datepart SqlTypeFamily.ANY, number:SqlTypeFamily.INTEGER, date:SqlTypeFamily.TIMESTAMP )
-datepart
Is the part of date to which an integer number is added.
-number
Is an expression that can be resolved to an int that is added to a datepart of date
-date
Is an expression that can be resolved to a time.

Example
SELECT timestampAdd(month, 1, '2017-05-31')  from tab; --> 2017-06-30 00:00:00.000

Note: Due to the difference of [[org.apache.calcite.rex.Rex Literal]] between calcite 1.12 and calcite master we should temp close support the construce of TIMESTAMPADD(SqlTypeFamily.ANY, SqlTypeFamily.INTEGER, SqlTypeFamily.DATE), until upgrade to calcite 1.13. See more https://issues.apache.org/jira/browse/FLINK-6851

[x] General

The pull request references the related JIRA issue ("[FLINK-6811][table] Add TIMESTAMPADD supported in SQL")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Rebase code and add doc after FLINK-6960 & FLINK-6925.

I have rebase the code and update the PR.

Thanks @sunjincheng121. Looks good to merge. I will merge this...


Experienceing issues

Pls i recovered my zen wallet with my passphrase but all my coin I earn so hard was gone. Moreso I got my wallet back today and all my coins are gone. can you guys help me get them back? thanks. My e-mail is<EMAIL_ADDRESS>


SWReveal errors in latest version of Swift/XCode...

Excuse my naivety as am not used to GitHub etiquette yet or if this is the correct place to mention this...
Been working off the standard SWReveal examples which are all similar. It would appear there have been some changes in the latest Swift beta that required changed syntax. Am using Xcode 9, beta 2 and the previous Swift 3 approved versions not working:
revealViewController() != nil {
        btnMenuButton.target = self.revealViewController()   // 1st line
        btnMenuButton.action = #selector(SWRevealViewController.revealToggle(_:))    // 2nd line etc
        //  btnMenuButton.action = #selector((SWRevealViewController.revealToggle) as (SWRevealViewController) -> () -> Void) as Selector // Swift 3 fix
        view.addGestureRecognizer(self.revealViewController().panGestureRecognizer())
}

The 2nd line gives a libswiftCore.dylib function signature specialization error.
btnMenuButton.action = #selector(SWRevealViewController.revealToggle(_:))
If I activate the 3rd line and decativate the 2nd, e.g.
// btnMenuButton.action = #selector(SWRevealViewController.revealToggle(_:))
btnMenuButton.action = #selector((SWRevealViewController.revealToggle) as (SWRevealViewController) -> () -> Void) as Selector // Swift 3 fix

I get Ambiguous reference to member 'revealToggle'.
Any ideas?

Nothing to do with the Swift version. Please delete this question.


Add better support for defaults

have fallback defaults for any missing configuration in application.yml

Fixed by #8


Page links to out-of-date release

This page links to more information in the 2022 Release Wave 1 plan (which is now archived). Should link to the Wave 2 plan here: https://learn.microsoft.com/en-us/dynamics365-release-plan/2022wave2/finance-operations/dynamics365-project-operations/

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f9e6fb89-aea1-8903-fefa-1b214ccc8161
Version Independent ID: 0521676e-131c-31b7-a646-45907ef5c8de
Content: Dynamics 365 Project Operations
Content Source: articles/index.md
Service: dynamics-365-project-operations
Product: ****
GitHub Login: @stsporen
Microsoft Alias: kfend

@smearp Thank you for letting us know. The link has been updated and should be live soon.


Fix build error and part of test error

Description
Fix build error and part of test error
Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #42 (4f52490) into workspace (dcc9869) will increase coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace      #42      +/-   ##
=============================================
+ Coverage      66.01%   66.10%   +0.08%
=============================================
  Files           3241     3242       +1
  Lines          62462    62464       +2
  Branches        9689     9689
=============================================
+ Hits           41236    41292      +56
+ Misses         18878    18822      -56
- Partials        2348     2350       +2

Flag
Coverage Δ

Windows
66.10% <ø> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...njected_metadata/injected_metadata_service.mock.ts
100.00% <ø> (ø)

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to use Balena SDK with balena staging environment?

We need to test against Balena Staging environment... In order to deploy our release we use Balena Python SDK. Read an article that mentioned how to do it with the CLI, but could not find anything for the SDK

Hello @u93 sorry for the late response on this. You can achieve what you want by setting the api_endpoints setting like
from balena import Balena

b = Balena()
b.settings.set('api_endpoint', 'https://api.balena-staging.com')
...

There are actually more steps to get the sdk api on a working state for this, it was mostly functional for me setting:
from balena import Balena

b = Balena()
b.settings.set('api_endpoint', 'https://api.balena-staging.com')
b.settings.set('pine_endpoint', 'https://api.balena-staging.com/v6/')
b.settings.set('builder_url', 'https://builder.balena-staging.com/')

I do understand however that this workflow is complex and we should be able to set the balena/oB backend domain only once.

Hello @u93 with the release of balena-python-sdk v13 #326 settings objects can now be used with the constructor itself, which allows for multiple objects pointing to different instances of the SDK and a much easier configuration to point to staging environment.
If you want to change for the staging environment, you could simply do:
balena = Balena({"balena_host": "balena-staging.com"})
However, this will overwrite your balena-cloud settings (stored api keys etc). So we recommend using
a different data_directory for each balena-sdk instance, e.g:
balena_prod = Balena()
balena_staging = Balena({
    "balena_host": "balena-staging.com",
    "data_directory": "/home/balena-staging-sdk/.balena",
})


When can we expect the release?

Hi guys! You are doing a good job. We already use an open source alternative to Openai (OpenOpenAI), but it is not being developed. Tell me, when can we expect a more or less stable release that would replicate the standard functionality of the chatbot? Now we see your active development and therefore we are in no hurry to integrate. Maybe make a release with a stable tag?

@dacom-dark-sun what is your definition of stable?
I'm solo maintainer atm, feel free to check issues :)


Invalid Type Cast in at_onboarding_flutter

Describe the bug
Invalid Type cast occurs on line 101 of pair_atsign.dart
https://github.com/atsign-foundation/at_widgets/blob/44c5fd80f36822ea1a99d3dfbf794654676daab9/at_onboarding_flutter/lib/screens/pair_atsign.dart#L101
When this line is reached an exception is hit and there is no exception handling for an invalid type cast so then
nothing happens and the app is stuck on a blank screen.
To Reproduce
Steps to reproduce the behavior:

Sign into onboarding with a new non-activated atsign
Enter verification code sent to the email associated with the atsign
Hit 'Verify & Login'

Then the blank screen appears
Expected behavior
The app validates the code and asks the user to save the backup key
Screenshots
I did fix this issue on my project locally by changing these lines in pair_atsign.dart at
https://github.com/atsign-foundation/at_widgets/blob/44c5fd80f36822ea1a99d3dfbf794654676daab9/at_onboarding_flutter/lib/screens/pair_atsign.dart#L101
from:

to:

Smartphone (please complete the following information):

Device: Google Pixel 4 Emulator with Android API 30
OS: Android 11

Issue was found on other physical devices as well
Were you using an @application when the bug was found?

@Vento

Fixed with #178


Need appveyor build

I realize we may not be able to run the functional tests, but this repo needs an appveyor build that compiles and runs unit tests (if any) at least.

Done


Looping feature

Could you add a setting to loop the video continuously?

Yeah it would be nice, @milleniumbug asked about it also.

LoopsEndlessly or Repeating maybe.
tbh my workaround was like 6 lines, so I don't feel very strongly about this feature.

The looping could be improved over my workaround if, some time before the end, the control would pre-load the start of the film so it would be able to start it without any delay.

You could have a property Loop and, on MediaEnded, simply execute:
if (Loop)
{
    MediaElement.Stop();
    MediaElement.Play();
}


add dependabot config

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 88.287%

Files with Coverage Reduction
New Missed Lines
%

contracts/libs/ValidatorStorage.sol
2
71.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
772

Relevant Lines:
848

💛  - Coveralls


⚠ ClamAV has degraded performance

In 94948f4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 186 ms

Resolved: ClamAV performance has improved in 3c67edc.


Bug in preview data display

In editor
**Bold**
*Italic*

rendered as

  asd

  asd

But it should be

  asd
  asd

Data stored correctly. But in preview we have a bug.

Sorry it's not a bug.
Need to set
renderingConfig: {
  singleLineBreaks: false
},

But i have misunderstood why it settled default to true.
Because of this, it seems like library have a bug .

In a WYSIWYG-style editor, this:
**Bold** *Italic*
...implies that you want a line break to be inserted between the two lines. You can change that default behaviour with the configuration option you mention.

@danabrey
But markdown is not WYSIWYG.
For exmaple if you send
**Bold**
*Italic*

and server and it should convert somewhere you will be surprised. Because preview !== realConvertedMarkdown

Guys is there a preview mode only?

GitHub Flavored Markdown is the variant used for SimpleMDE. It supports single line breaks.
More than that, SimpleMDE is designed for users who are not familiar with Markdown. Not supporting single line breaks would no doubt confuse this type of user.

@WesCossick  ok, thank you for explanation.
But still it was a bit strange to see different code in the preview, and output :)


⚠ Bofrost.be has degraded performance

In 062524a, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1131 ms

Resolved: Bofrost.be performance has improved in 8a3355b after 7 minutes.


[investigate] Contract changes required to allow enabling stable assets with just governance proposal and oracles

Expected Behavior
A new stable asset can be created just with a governance proposal and the deployment of oracles.
Current Behavior
Now it requires:

Contracts to be released with the audit cycle (like stableTokenEUR and exchangeEUR)
One governance proposal to activate the oracles and freezing
A second governance proposal to unfreeze + enable.

@martinvol is this work that's needed for be done by CAP? if not, I'd like to remove the CAP label so we are only tracking CAP work on our backlog.
If you feel CAP needs support, we can create a separate ticket with the specific ask from the CAP circle and link to this one.

@aslawson find out how urgent based on timeline for releasing more stable assets

I think the output of this should be economics makes a lists of things that need to be changed in both contracts and tooling, and then we open new issues and assign as we see fit.


Update dependencies and features

This looks great @bstrie, thanks!
@novacrazy I'd be curious if you have an objection to removing hashbrown now that it's in std?

The std hashbrown doesn't use FxHash by default, but we weren't using that by default either, though now it's not presented to the user in the evmap docs. The hashbrown crate itself did provide a better implementation of FxHash than the dedicated fxhash crate.
However, this is fine, I think. It may even give a bit better performance to use the std version, since std is allowed to use nightly features internally on stable IIRC.

Yup, my thinking here is that people can still depend on hashbrown if they want to use their FxHash, but us shipping it as a dependency no longer seems necessary.
@bstrie the CI error is https://github.com/xd009642/tarpaulin/issues/190, and is unrelated to your change.


Add FirestoreDb.SnapshotAllAsync for multiple snapshots

This is the equivalent of Firestore.getAll() in Java, but follows
the name of SnapshotAsync that we have in DocumentReference.
We could rename it to SnapshotAllAsync, potentially.
cc @schmidt-sebastian and @GoogleCloudPlatform/appengine-java
Fixes #1837.
Implementation is obviously trivial - this is mostly about naming...

GetAll() has been approved :)

Filed as #1885 for easy tracking.


Change topo-order to date-order

Change to date-order because topo-order doesn´t work very well at repos with a lot of tags. Fixing also #69

This repo is being archived. Thanks for your support along the way!


qa_crowbarsetup: move fill back out of loop in order not to call it too often

moving the call of chef-client outside of the loop, otherwise it was called too often

:+1:


Support OpenAI in Spring Cloud Azure

Description

Add AzureOpenAIAutoConfiguration
Add spring-cloud-azure-starter-openai

All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Simplified and improved toolbar tutorial

Coverage remained the same at 82.598% when pulling 5e6cec54068f8caf579cf25b098ce049722d87db on evildmp:docs-improve-toolbar-intro into 291028b4a16b6036f57aaf46525cb974ffcfc2f1 on divio:release/3.4.x.


INT B-21846 TOO/SC can create UB shipments

Agility ticket
Summary
Small oopsie - forgot to add in the UB option for the SC/TOO to add UB shipments via the dropdown. This PR addresses adding in that logic and conditionally rendering the UB option if the UB flag is on and if one or both of the duty locations are OCONUS.
Also added in styling for the UB shipment tag & tests.
How to test

Access MM as office user, ensure UB flag is on
Create customer with a duty locations that are CONUS
Go to add a shipment - should not be able to add a UB shipment
Create a new move, but with one or both duty locations being OCONUS
Go to add a shipment - should now see the UB option
Go through the workflow as SC/TOO and ensure you can complete creation of UB shipments

Screenshots

Changed back to CONUS addies for duty locations

Changed one to be OCONUS - now TOO can select UB

code looks fine- but im not crazy about that it technically allows a conus shipment (based on the addresses) to be UB-
UB shipments are International only

code looks fine- but im not crazy about that it technically allows a conus shipment (based on the addresses) to be UB- UB shipments are International only

Hm. Well UI-wise they wouldn't be able to create a UB shipment unless one of the duty locations on the orders is OCONUS.
Do you have a solution or idea in mind to resolve your concerns?

code looks fine- but im not crazy about that it technically allows a conus shipment (based on the addresses) to be UB- UB shipments are International only

Hm. Well UI-wise they wouldn't be able to create a UB shipment unless one of the duty locations on the orders is OCONUS.
Do you have a solution or idea in mind to resolve your concerns?

probably fine- long as the oconus logic is in the code and not passed in.. shouldn't be an issue- which I see it is
the test case just threw me off- since it wouldn't be a valid scenario

code looks fine- but im not crazy about that it technically allows a conus shipment (based on the addresses) to be UB- UB shipments are International only

With this check:
  useEffect(() => {
    // Check if either currentDutyLocation or newDutyLocation is OCONUS to conditionally render the UB shipment option
    if (originDutyLocation?.address?.isOconus || destinationDutyLocation?.address?.isOconus) {
      setIsOconusMove(true);
    } else {
      setIsOconusMove(false);
    }
  }, [originDutyLocation, destinationDutyLocation, isOconusMove, enableUB]);

We are ensuring that the user can't create a UB shipment unless the orders allow for an international shipment.

code looks fine- but im not crazy about that it technically allows a conus shipment (based on the addresses) to be UB- UB shipments are International only

Hm. Well UI-wise they wouldn't be able to create a UB shipment unless one of the duty locations on the orders is OCONUS.
Do you have a solution or idea in mind to resolve your concerns?

probably fine- long as the oconus logic is in the code and not passed in.. shouldn't be an issue- which I see it is
the test case just threw me off- since it wouldn't be a valid scenario

oh yeah the test was just for convenience


Feature - Autocomplete - Added autoselect first option on enter

This modifies the autocomplete so that when you press enter it will automatically select the top option.
This is overwritten if the user hovers over an option and press enter.
Not sure if this is the best way to do this. Happy to hear feedback.

I need to take a closer look, gonna check during the weekend :)

This could certainly be implemented better. I tried a couple things, but kept running into issues with setting state and re-renders.
So decided that it was a fair assumption that if the user pressed 'enter' they wanted to just select whatever was on top (or had been selected with the keyboard).
Having the 'active' state set to whatever is currently at the top would make logical sense but was causing multi re-renders.
I'm been trying to make our forms + react-toolbox behave better for keyboard only use. Next thing is the date picker and being able to type in a date.

I think it's good enough! 👍


Admin system not allowing access (probably connected to Spark and Drupal not being on SSL - should be fixed now)

Hagit confirmed it is working for her as well.


Add multi thread Example

Demonstrate that direct zephyr calls can be made even with the Arduino API in use.
Examples shows concurrency by async blinking of 3 LEDs

Signed-off-by: Dhruva Gole<EMAIL_ADDRESS>

I again rebased the dev on top of this branch 🤦🏼
Now this has added all latest commits from main into this branch showing too many unnecessary files changes. I am closing this PR and creating a different branch and will cherrypick the useful commits there.


Increase test setup timeout

Coverage remained the same at 97.998% when pulling f5b498ebf8f95f250dbd3a4a5aeff83f03b54c1b on test-setup-timeout into cdbfff3a935dd4a88dde3f5d2d40659ea901bb5b on master.


Patch (Update plugin.yml)

Thanks @thebigsmileXD for reminding me.
(https://twitter.com/XenialDan/status/917013438949396480)


About coco

Hello senior brother, as far as I know, coco is not a temporal video frame. How did you train four datasets together?

关于COCO数据集，我们对采样的图片进行copy多次，以模拟视频帧的训练。

Thanks for your reply!


SDC-1615 feature/property-template

SDC-1615

Some comments about this feature in the properties file or readme (self explanatory properties file preferred)? 🤓

Some comments about this feature in the properties file or readme (self explanatory properties file preferred)?

I'm working on the documentation ;)


The bitnami/kubectl image at public.ecr.aws is only having amd64 architecture

Description
Observed Behavior:
The bitnami/kubectl image (used in the postInstallHook) at public.ecr.aws is only having amd64 architecture.
Expected Behavior:
The bitnami/kubectl image (used in the postInstallHook) at public.ecr.aws is having the multi architecture like the image on dockerhub.
Reproduction Steps (Please include YAML):
$ crane manifest public.ecr.aws/bitnami/kubectl:1.30
{"schemaVersion":2,"mediaType":"application/vnd.docker.distribution.manifest.list.v2+json","manifests":[{"mediaType":"application/vnd.docker.distribution.manifest.v2+json","digest":"sha256:68a21ff34c2a67329faa4d6088272d54d4a4e7a21076b3a435624e45503a17ab","size":430,"platform":{"architecture":"amd64","os":"linux"}}]}
$ crane manifest bitnami/kubectl:1.30
{"schemaVersion":2,"mediaType":"application/vnd.docker.distribution.manifest.list.v2+json","manifests":[{"mediaType":"application/vnd.docker.distribution.manifest.v2+json","size":430,"digest":"sha256:68a21ff34c2a67329faa4d6088272d54d4a4e7a21076b3a435624e45503a17ab","platform":{"architecture":"amd64","os":"linux"}},{"mediaType":"application/vnd.docker.distribution.manifest.v2+json","size":430,"digest":"sha256:75243f00f9d7313cbf0142258edab749f9b4461f8efbbe970df1193c7aef35a0","platform":{"architecture":"arm64","os":"linux"}}]}

Versions:

Chart Version: v1.0.0
Kubernetes Version (kubectl version): 1.30

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment
The bitnami/kubectl image at public.ecr.aws is only having amd64 architecture

Closing as a duplicate of #6775


added graalpy

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@tomasstupka can you sign the contributor license agreement?


NOT_FOUND when path contains spaces

I get an 404 error when trying to read files that contain a space in their filename. I tried using %20 or %B both did not help.

I fixed it by adding enableDecodeURI: true to the config of the staticPlugin


"But it failed!" messages should not reveal the target

From #2367:

The target of a failed [move] should be ambiguous to both players; that is, the animation shouldn't play out. This happens with...moves that bring up the message "But it failed!", like Fake Out, Disable, etc., so it can probably be generalized in this way.

Using a move blocked by Primal weather should not reveal which slot was targeted

This adds a new method to battles: hideLastTarget. It removes the target from the last move message and suppresses its animation.
This makes the [still] attribute hide the target from the same move message whenever it is added.
In addition, the target is removed from replaced with the source in -fail minors where it shouldn't be revealed.
Currently, changes are only applied to -fail minors where the target could have been one of several Pokemon, but would not be revealed to the players in-game. This may cause inconsistencies in whether or not animations play when moves fail, but this seems like a less urgent issue than preventing an information leak.
I appreciate your feedback!

It just occurred to me that removing the Pokemon from the -fail message removes the result animation. This could be fixed by setting the Pokemon to the user rather than the target in these cases.

Yeah, |-fail|USER is probably what we want here.

Looks good. @Marty-D?

One other thing we could do is add a failLastMove function, to combine all of this stuff together.

But at this point it makes sense to merge then refine.

Yes, looks great, thanks @mathfreak231!

...am I missing something or could this have just all been consolidated to happen somewhere around here https://github.com/Zarel/Pokemon-Showdown/blob/master/data/scripts.js#L134

Like if (!moveResult) this.attrLastMove('[still]'); somewhere between Lines 134 and 136?

Yes, in hindsight that would have made sense.

But to be fair, major surgery on battle APIs is begging for trouble so I'm not surprised most people take the safer solution.


repository name => property-graph-formatter ?

I prefer short names and URLs. How about pg-format, so the URL becomes https://g2glab.github.io/pg-format/? The web application is about PG format and not limited to its formatting. It also shows syntax errors, so it's a validator, and it could be extended to simple graph visualization. Another possible name is pl-playground similar to JSON-LD Playground: a place to try out PG format.

The short name and the descriptive name, both are reasonable to me. Should we also consider merging this to pg/pgraph repository?

While I will consider the name pg-format,
we will still have a chance to make decisions.

There are three repositories:

this one: web application to try out, validate, format PG format
pgraph: CLI and library to parse and convert between property graph formats
pg: project description of PG format, data model etc.

Two of them could be merged but could also be kept separate. The best location of some files is not fixed anyway. By the way I don't mind moving pgraph into g2lab repository.

I agree that we should merge them if possible. Creating a new org is an option too. I hope to gradually move forward as far as it is not too urgent!

Creating a new org is an option too

pg and pgraph are taken. pg-format is available. property-graphs or similar is too long.

(pgformat, pgfmt and pg-fmt are also available.)
Still, I think it is a good idea to invite @nichtich to g2glab organization, and transfer the repository.


doc: summon.md: we now need gopass-summon-provider

RELEASE_NOTES=n/a
Signed-off-by: Marco Molteni<EMAIL_ADDRESS>

This closes #1633

Codecov Report

Merging #1658 (170d4c3) into master (93539af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   57.64%   57.64%
=======================================
  Files         204      204
  Lines        9854     9854
=======================================
  Hits         5680     5680
  Misses       3503     3503
  Partials      671      671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93539af...170d4c3. Read the comment docs.

Ah, it looks like that a force push dismisses reviews in this repo?
In any case, I updated the commit to use relative links.

Also, if you are using Summon yourself, maybe you could explain why it's interesting to use with Gopass? I don't know anything about Summon myself, I think it could help users to have a clearer understanding of what is Summon and why it's nice to use with Gopass.

Maybe another time.

For example: will Summon erase the env var after usage or not?

It would be impossible for summon to leave around the environment variables actually, due to how shells and subprocesses work.
In general, summon is well though-out from a security point of view.


setup.py install and mercurial version requirement

sudo python3.8 setup.py install
........
Copying mbed_cli-1.10.2-py3.8.egg to /usr/local/lib/python3.8/dist-packages
mbed-cli 1.10.2 is already the active version in easy-install.pth
Installing mbed script to /usr/local/bin
Installing mbed-cli script to /usr/local/bin
Installed /usr/local/lib/python3.8/dist-packages/mbed_cli-1.10.2-py3.8.egg
Processing dependencies for mbed-cli==1.10.2
Searching for mercurial>=5.2
Reading https://pypi.org/simple/mercurial/
Download error on https://pypi.org/simple/mercurial/: [Errno 13] Permission denied -- Some packages may not be found!
Couldn't find index page for 'mercurial' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno 13] Permission denied -- Some packages may not be found!
No local packages or working download links found for mercurial>=5.2
error: Could not find suitable distribution for Requirement.parse('mercurial>=5.2')

Internal Jira reference: https://jira.arm.com/browse/IOTBTOOL-521

Could you please try installing mbed-cli using pip e.g. pip install mbed-cli and if this doesn't work try installing Mercurial individually e.g. pip install Mercurial and send us the results. Thanks

@madchutney - please let us know if you have an update.

@maclobdell We believe this was caused by a problem with pip and it should now have been resolved. Can you please check that this is still occurring?


Add Example for File Upload

Progress indicators for file uploads (specifically indicators for Request objects) would be a great example.  At the time of writing, this doesn't seem possible yet, and the Request docs do indicate ReadableStream may be used as a request body
String body: sent
// Post "hello" body.  Browser sends and server responds with what it receives.
fetch(
  new Request('https://dev.anthum.com/post-test/', {
    body: 'hello',
    headers: {
      'content-type': 'text/plain'
    },
    method: 'POST'
  })
)
.then(response => response.text())
.then(data => console.log(data))
.catch(error => console.error(error));

ReadableStream body: not sent
This may just be bad experimental code on my part or the browsers do not yet support it.
const stream = new ReadableStream({
  start(controller) {
    controller.enqueue(new TextEncoder().encode('hello'));
    controller.close();
  }
});

// Post ReadableStream body. Browser doesn't seem to send, and server responds with nothing received
fetch(
  new Request('https://dev.anthum.com/post-test/', {
    body: stream,
    headers: {
      'content-type': 'text/plain'
    },
    method: 'POST'
  })
)
.then(response => response.text())
.then(data => console.log(data))
.catch(error => console.error(error));

This implementation was also posted for discussion and resolution on Stack Overflow
https://stackoverflow.com/questions/49085424/

@AnthumChris SO says Page Not Found.
What is controller up in the original post.

StackOverflow redirects to this: https://stackoverflow.com/questions/49085424/constructing-fetch-request-with-readablestream-body does that work for you?
MDN has some good info on the controller, and I recommend starting here: https://developer.mozilla.org/en-US/docs/Web/API/Streams_API/Using_readable_streams

First link is still Not Found but thanks. I will read Streams API on mdn.

I wonder if StackOverflow is doing some special geo-based redirection.  You could also try searching (with quotes) "Constructing Fetch Request with ReadableStream Body" and there's one answer that shows:

I wonder if StackOverflow is doing some special geo-based redirection. You could also try searching (with quotes) "Constructing Fetch Request with ReadableStream Body" and click the first result:

Cannot find this in any way.

A ReadableStream can now be sent as a fetch() request body (https://github.com/whatwg/fetch/pull/425). I'll plan on adding an example for upload progress indicators.
@jakearchibald wrote great article Streaming requests with the fetch API. This example shows a server responding with the streaming request it receives:
fetch(new Request('https://dev.anthum.com/post-stream-test/', {
  body: new Response('🎉').body,  // new ReadableStream
  duplex: 'half',
  method: 'POST',
  headers: { 'Content-Type': 'text/plain' },
}))
  .then(response => response.text())
  .then(console.log)
  .catch(console.error)

_@amdiv, @fselcukcan: Apologies, please ignore original StackOverflow URL (~https://stackoverflow.com/questions/49085424/~), It was marked as a duplicate question and deleted.


Complex Docker Compose hangs when running in amd64 VM

Describe the bug
I have a fairly complex Docker Compose file running under a Debian 12 amd64 machine. If the docker compose services are started individually, they entire stack will run successfully. However, starting the entire docker-compose stack at one time will hang the docker services. e.g. docker ps or docker compose logs will not output/return.
To Reproduce
No response
Expected behavior
No response
Diagnostic report (required)
OrbStack info:
Version: 1.0.0
Commit: c43913566b3e18b25f38a8d5f70e535eb265bdb2 (v1.0.0)
System info:
macOS: 13.5.2 (22G91)
CPU: arm64, 10 cores
CPU model: Apple M1 Max
Model: MacBookPro18,2
Memory: 64 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2023-09-22T21-56-31.984926Z.zip

Screenshots and additional context (optional)
No response

I'd highly recommend using Docker's multi-platform support (export DOCKER_DEFAULT_PLATFORM=linux/amd64) instead. It will be much faster and more reliable, without issues like this.

I'd highly recommend using Docker's multi-platform support (export DOCKER_DEFAULT_PLATFORM=linux/amd64) instead of running the entire thing in an emulated machine. It will be much faster and more reliable, without issues like this.

Okay, thank you


C++ Solution for #359

Solved issue #359
In Language- C++

[x] Updated README Link
[x] Added code with comments

Thanks for contributing!

Please do not make a PR unless assigned

Add proper comments


⚠ Bofrost.at has degraded performance

In d4a92db, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1049 ms

Resolved: Bofrost.at performance has improved in ab591de after 306 days, 21 hours, 55 minutes.


Remove custom string operations with native Rust ones. Some code refactoring.

Closes #94
Replace custom string operations (find, substitute, replace, etc.) with Rust equivalents.
Simplify sending Rust strings to Lua.
Initial code refactoring to make it more idiomatic:

convert file names to snake case
correct some structures names (camel case)

Additional small code fixes.

I'll address all performance issues you have mentioned.
About converting functions to a class methods: I was even started doing that (some to_string() methods) but then it appeared it will take a lot of time and blow up the PR, so I decided to do it before or in proc macro task. One by one.


App responder fix and logic separation (alternative solution)

Alternative solution for my PR #1384
I guess this one is much better for many reasons:

Good logic separation: respond() method should not modify Response object, it should just output headers and body. Instead I've added finalize() method, which finalizes response and returns finalized value.
Good for Unit testing of run() function, where you don't need respond method in most cases.
Now App itself is "reusable" in Unit tests. For huge projects it is critical. For example unit tests for my project run almost for 40 minutes if I create App object from scratch all the time (with all Middleware, Redis/ElasticSearch/Doctrine/Acl/S3/etc settings). But if I make App object static and reusable for all my Test Cases and only inject new response/request objects - unit tests run only 15 minutes. Before it was not possible to "reuse" App because of static variable $responded = true inside respond() method.

Oh so much yes on this... :100: * :+1:

The only thing I don't like is code duplication here:
$statusCode = $response->getStatusCode();
$hasBody = ($statusCode !== 204 && $statusCode !== 304);

If you know how to fix it, please, let me know.

Changes Unknown when pulling 6eebd6ab5f6f428bef37132145e20679ae19375e on yurevichcv:feature/app-responder-fix-alternative2 into ** on slimphp:3.x**.


Support reading and writing database tables

Create generic JDBC reader/writer factories for creating readers and writers for database tables of any types.

Closing as out of scope.


Version 10

#70

@pivnicek That's a good one. I think you're right, we shouldn't keep it here.

Ref.: https://keboola.slack.com/archives/C035LGNK5/p1544460078092600


Question : How to change default message of Send Verification Email

Hi Nicolas,
Is there a recommended way to change the default email message to a custom one.
Maybe an option in Options or in the Admin panel to set a subject, body or something along those lines.
I know for the body we'll probably have to extend and add what ever text we'd like since it dynamically generates the invitation url. But i'm just curious if theres a easy way to add a custom message tailored to the end client's request.


Updated to 3.0.8

Hi @skifaster @nolimits4web,
great library. I have used your meteor version but it was missing some very nice features you have added! So I have updated it, in hope everyone in the community can enjoy your great work!
@skifaster  i have rebased your version on the current 3.0.8 release. And just exported the Swiper for meteor.
Would be great, if you guys could go on and merge this and publish it to meteor to avoid copies.
Cheers,
Ahmed
PS.: I have tested it in my project :)

thanks, pushed to atmosphere


Add circle.yml

build with CircleCi
update Simplecov version

Hey there. 😍

hey handsome(s) 🍆

tite tite tite

Worth noting, CircleCI doesn't support testing multiple rubies:  https://circleci.com/docs/unrecognized-ruby-version/
Look to just fix Travis instead?

@Fosome I do this on a node project to test against multiple nodes:
https://github.com/vigetlabs/gangway/blob/master/circle.yml#L5-L9
Possibly similar here?

@nhunzaker Something like this out there: http://www.jetthoughts.com/blog/tricks/2014/11/24/run-tests-against-multiple-ruby-versions-on-circleci.html
Feels brittle, dunno.
FWIW 1.9.3px seems so old (plenty of warnings just bundle installing), maybe we should move to >= 2.0 support, or even >= 2.1.


Italian translations

Same as PR: #4523 due to move my git tree to a separate branch.

newest Italian translation of:

all Udacity courses (ud811, ud860, ud882, ud891 & ud890, ud892, ud893, ud899)
Performance
Performance > HTTP2
Performance > RAIL
Performance > Understanding Low Bandwidth and High Latency
Performance > The PRPL Pattern

proof-read Italian translation of:

Performance > Optimizing Content Efficiency
Performance > Critical Rendering Path
Media > Video

added me as "translator"

@petele I glanced over this and nothing jumped out at me. I've dealt too little with either Udacity courses or translations to be confident in merging this. Please look it over.

Thank you @carlaofarrell for your revision. I've just rebased my commits to resolve any conflicts.

@carlaofarrell Let me know if you have any notes about my contributions.

Thanks @carlaofarrell and @lucab85  - I'll merge this and push it live on Monday morning. Thanks to both of you for your hard work on this!!

Yay! This is a great news!

Ok, thank you!

On Nov 9, 2017, at 12:06 AM, Luca Berton<EMAIL_ADDRESS>wrote:
@lucab85 commented on this pull request.
In src/content/it/fundamentals/performance/http2/index.md:

+HTTP/1.1.
+In particolare, gli obiettivi del progetto sono
+stati i seguenti:

+* Obiettivo una riduzione del 50% del tempo di caricamento della
+pagina (PLT).
+* Evitare la necessità di modifiche al contenuto dagli autori del sito
+web.
+* Ridurre al minimo la complessità di distribuzione e evitare le
+modifiche delle infrastrutture di rete.
+* Sviluppare questo nuovo protocollo in collaborazione con la comunità
+open-source.
+* Raccogliere dati reali di prestazioni per convalidare o meno il
+protocollo sperimentale.
+
+Note: Per ottenere il miglioramento del PLT del 50%, SPDY mirava a
You doesn't translate any "Note" to "Nota" because it is a special markdown callouts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


BottomSheet Default Sheet content Implementation.

This Implementation providers a way to add BottomSheet Content without having to specify some layout at consumers end.
A Builder is provided for this which can be used to build default content with as many horizontal , vertical  and divider layouts in customizable manner.
Thi PR also exposes custom attributes for customizing text appearances of horizontal and vertical items and helps organizing them.
This PR does not cover :
Themed BottomSheet
Landscape specification as right drawer.

@aishwarya56


fill in tests for tests/github/fair_software/badge/test_checker_with_noreason_user_config.py

spawned from PR #224
https://github.com/fair-software/howfairis/blob/bb246019abbb510d19a4642cb51b6596a736ea1d/tests/github/fair_software/badge/test_checker_with_noreason_user_config.py

also tests/github/fair_software/badge/test_checker_with_reasonable_user_config.py

All tests for both test classes have been implemented in #224


comments?

I was viewing an ActiveState recipe at: https://code.activestate.com/recipes/65207-constants-in-python/
I saw the link to this GitHub repo.  I'm not sure what is the intention of this repo.  Is it meant to replace the website?  If so, the repo is missing a very important thing: the comments.
Many recipes include comments that expand upon the recipes themselves.  Look at the page I mentioned above for an example.

Based on my observation, link https://code.activestate.com/recipes/ provides the searching ability to discover recipes based on keywords(this feature is generally missing from the activestate/code rep). However, as of now, the search itself does not work due to fail bindings with Google WebAPI.


Crash with AdvancementInfo

I was testing my modpack, and when I tried to open the Purpeille advancement tab, my game crashed, and Not Enough Crashes reported that the issues arose from AdvancmentInfo and Purpeille. When I turned off the AdvancementInfo mod, the Purpeille advancement tab worked just fine and there was no crash.
Fabric Loader: 0.14.6
Fabric API: 0.55.1
Here is the link to the crash report:
https://gist.github.com/Fourbo/3ed3ef02a1dc8358a6f54b1e3cfb10af

Looks like I just forgot some null checks. Fix will be out later today along with another update.

Fixed in version 2.3.1. Have fun!


Native plugin for Android

Description
iOS plugin already works in the project, native methods can be called. We need the same for Android.

I did a quick test on this, and there are multiple issues with gradle build.

AndroidManifest merge error
Theme resource not found

These are probably due to AndroidManifest or resource files in built aar file. Or I built aar file from Cardboard SDK wrong.

My Result so far:
For Build from IntelliJ IDEA/Android Studio (all in sdk folder):

Change the style to following so that the build from unity won't popup resource merge issue:

   <style name="AppTheme" parent="android:Theme.Light">
        <item name="android:windowContentOverlay">@null</item>
    </style>

Remove the AppName and AppTheme properties in AndroidManifest, so that unity won't popup manifest merge issue.
In gradle task panel, click sdk/Tasks/build/assemble instead of build, assemble is the only one without critical exception.

This maybe correct or incorrect, because I can't confirm if it works in Unity.
For usage in Unity:

DLLName is cardboard_api or libcardboard_api
Crash on start, there is no log. After logged a lot, it seems crash in CardboardQrCode_getSavedDeviceParams
Cardboard_initializeAndroid is not called. But need to find a way to call it, this includes get a JavaVM pointer and a context.

This is the aar file I built.
CardboardAndroid.zip

After thousands of errors and exceptions, finally get it to a minor working state:
sdk-debug.zip
This is the aar plugin, except of removing user-feature tag for openglES2.0, nothing is changed. This is built based on Cardboard Plugin 1.1.0, which has changed a lot since initial version.
Following things must be done in Unity, I don't like it but this is the current states.

Custom gradle files must be created, and following packages must be added to dependencies:

implementation 'com.android.support:appcompat-v7:28.0.0' (This is for the activity itself)
implementation 'com.android.support:support-compat:28.0.0' (Ask for permission method is in a class within this package)
implementation 'com.google.android.gms:play-services-vision:15.0.2' (QR Code process class is in this package)
implementation 'com.google.protobuf:protobuf-lite:3.0.0' (For decoding the qr code url)

Target SDK MUST be 9.0 instead of 10 which is already released. Google uses getExternalStorageDirectory to access file storage and store the cardboard profile, but something is changed in Android 10 and external storage can not be easily changed. (I'm not sure if this is true). Anyway, otherwise I'll get folder or file access denied when scan the qr code.
Write Permission should be "External(SDCard)" in project setting.

This storage situation is terrible in my opinion, because sooner or later Google Play will say all apps must target Android 10, and this has to be changed.

How much of these issues are related to using their library for QR code scanning, and could that be alleviated by switching to use https://github.com/micjahn/ZXing.Net ?

@hawkwood
This shouldn't be much issue using play service for qr code scanning, there are other reasons that I want to prevent using external libraries.
There are a lot of third party assets/plugins using Google Support packages, like facebook SDK and firebase SDK, and they use actual aar files in Plugins folder instead of using dependency in gradle. I had a lot of troubles trying to get them work together, even with the "Jar Resolver" plugin. If this SDK requires additional google support librarys it will only add pain. But there aren't much I can do for now.
About qr code scanning, these parts are used in android library, so even I switch to ZXing, it would be java implementation of ZXing instead of ZXing.Net. It is possible but I don't think I'll do that for now.

A fork is created from Google Cardboard.
https://github.com/mobfishgmbh/cardboard
I need proper way to track that much changes from source code.

https://developer.android.com/training/data-storage/shared/documents-files
About share storage

Merged into public-dev.
Document Updated.
A fork is created from Google Cardboard.
QR Code scan issue is fixed for android.
getExternalStorageDirectory issue is resolved.
Target SDK is API 29 and External(SDCard) write permission is no longer needed.
Cardboard Profile is now NOT shareable, each app will have its own cardboard profile data.

Merged to master and released.


Use Alamofire ~> 4.0.0 in pod spec dependency

Am currently using Moya 8.0.1 via cocoapods but i now have to use the cocoapods post_install hook to set config.build_settings['SWIFT_VERSION'] = '3' because otherwise the project can't build in the latest version of Xcode because of the syntax updates to swift and the version of Alamofire used in the podsepc is only ~> 3.0.0. which doesn't have the latest updates needed.

According to this https://github.com/Moya/Moya/blob/master/Moya.podspec#L25 it uses Alamofire 4.2. Are you sure your issue is not in your Podfile or Xcode configuration?

OK yes. i read my pod error incorrectly. This is the error I had. But if i check the install after removing my requirement for 4.3.0 then i see 4.2 is used
`[!] Unable to satisfy the following requirements:

Alamofire (= 4.3.0) required by Podfile
Alamofire (~> 3.0) required by Moya/Core (6.1.2)
`

But any reason why the latest version of Xcode would complain about the syntax without having config.build_settings['SWIFT_VERSION'] = '3' set?
I may need to move my question over to Alamofire


bip39 mnemonic validation added

This PR allows users import 12 word mnemonic phrases from popular wallets.
It also validate mnemonic phrases to prevent funds losing by users.

Codecov Report

Merging #1116 (a85f273) into master (de9d978) will increase coverage by 32.69%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1116       +/-   ##
===========================================
+ Coverage   44.75%   77.45%   +32.69%
===========================================
  Files         329       32      -297
  Lines        6323      692     -5631
  Branches     1027      125      -902
===========================================
- Hits         2830      536     -2294
+ Misses       3395      148     -3247
+ Partials       98        8       -90

Impacted Files
Coverage Δ

src/RenderWalletState.ts

src/transaction/CreateBitcoinTransaction/RawTx.tsx

src/create-wallet/WalletOptions.tsx

src/transaction/CreateTx/ToField/ToField.tsx

src/transaction/CreateTx/GasLimitField/index.ts

...ransaction/CreateTransaction/CreateTransaction.tsx

src/address-book/ContactList/Contact.tsx

src/accounts/reducer.ts

src/components/accounts/ImportMnemonic/index.ts

...ansaction/CreateTx/GasLimitField/GasLimitField.tsx

... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9d978...a85f273. Read the comment docs.


Removed build ouptut from source control repository.

To make reviewing my changes possible I decided to split them into multiple commits.
This part hides from git any changes caused by build. The approach is following:

Binary files produced by Code Tools solution were removed from repository.
Additional files were added to .gitignore file.
Template files for vsix manifests were created. These files are supposed to be modified in order to change non-version related fields.
DURING BUILD (from build.bat)
Vsix manifest files are overwritten by templates.
New version is applied to each overwritten vsix manifest file and version.cs
All vsix manifest files and version.cs are assumed unchanged via git update-index -–assume-unchanged {file_path}

With this approach we can build freshly cloned repository from Visual Studio and from command line script. In both cases git will not report any changes in files.
Appveyor build status

Nice job! BTW, how hard it would be to add official Appveyor builds for master branch?

LGTM.

@SergeyTeplyakov Integrating AppVeyor with pushes on master branch or even pull requests should be easy. I have sent you an email with some details.


aws adapter get_path should work without CF distribution or NGINX proxy

The aws storage adapter uses a domain prefix that is meant to  resolves to an S3 bucket path. In our production / staging setup we use a CloudFront distribution to proxy the prefix CNAME to the s3 bucket path URL.
An out of the box installation shouldn't require another service (nginx / CF) to resolve the get_path to the correct s3 bucket URL
e.g. storage.yml
development:
  adapter: aws
  prefix: development
  bucket: labelmars-image-data
  access_key_id: <key>
  secret_access_key: <secret>

sets an avatar media resource src as development/subject_location/12d7141b25-0353-4a7e-aee8-480c351521d3.jpeg and thus the aws adapter get_path code returns
https://development/subject_location/12d7141b25-0353-4a7e-aee8-480c351521d3.jpeg
We should provide a configuration directive to modify the default behaviour to not use a CDN or maybe find the bucket URL programatically or even allow the dev to add a domain_prefix yaml option to ensure get_paths return the s3 bucket URL's.
  domain_prefix: labelmars-image-data.s3.amazonaws.com

that results in https://labelmars-image-data.s3.amazonaws.com/development/subject_location/12d7141b25-0353-4a7e-aee8-480c351521d3.jpeg
Thanks to @squiddon for bringing this up.

See also #1763

keeping this open

closed by #3453


Add English-Estonian (WMT2018) as new problem

Hi,
this PR adds English-Estonian as new problem. English-Estonian is new for WMT18, so all training data from WMT site is used.
The development data is also taken from WMT. Unfortunately, the original development data includes SGML tags, so I stripped them using input-from-sgm.perl from Moses.

Wonderful, thanks!


#925 fix(users): sanitize username and password when user is created

Fix #925.
I am an absolute angularjs beginner, so please verify twice if this doesn't break anything...
Cheers.

Thanks @lewer :+1:


Doc: block expression requirement

The documentation is entirely silent on the fact that block expressions are an absolute requirement for setting up spans in addition to the #[trace] attribute.

The records of LocalSpan are submitted to the collector once the guard of set_local_parent gets dropped. So, if you collect the trace when the guard is alive, the LocalSpan will have no chance to get collected. And yes, we need to update the document for this behavior.


Fix RHODS Operator Scrape job

JIRA: https://issues.redhat.com/browse/RHODS-1677
Signed-off-by: Anish Asthana<EMAIL_ADDRESS>

I split out part of the changes into https://github.com/red-hat-data-services/odh-deployer/pull/144/files


only nodejs and python runtime can reuse global scope variable

Environment details:

native ubuntu

Steps to reproduce the issue:
I've tested whether global variables could be reused when container was reused.
The test results show that only nodejs runtime can reuse global scope variable.
The AWS Lambda service is not stateless for all runtimes. (it means an action can reuse global variable if container is reused)
Is there any OW spec for a global variable?
1. Javascript
let globalCache = {};
function main(params) {
	globalCache[getRandom()] = getRandom();
	return globalCache;
}
function getRandom() {
  return Math.random();
}

If the container is reused, the global variable is reused.
{
  "0.25746017280185063": 0.7853652208888477
}

{
  "0.25746017280185063": 0.7853652208888477,
  "0.4376083800717476": 0.6122601078429637
}

2. PHP
<?php
print_r($GLOBALS);
if (!isset($GLOBALS['count'])) $GLOBALS['count'] = 0;
function main(array $args) : array
{
	$GLOBALS['count'] = $GLOBALS['count'] + 1;
	return ["count" => $GLOBALS['count']];
}

The global variable is not retained even if the container is reused. (Only returns 1)
{
  "count": 1
}

3. Python
g = 0
def main(args):
    try:
        global g
        g = g + 1
        return {"count": g}
    except Exception as e:
        # please handle exception here
        # you can return or hide an error message
        return {"error": str(e)}

The global variable is not retained even if the container is reused. (Only returns 1)
If you run the same code in AWS Lambda, the count will increase.
{
  "count": 1
}

4. Java
The static variable is not retained even if the container is reused. (counter variable is always 1)
class Global {
    public static int counter = 0;
}

public class Application {
    public static JsonObject main(JsonObject args) {
        Global.counter++;
        System.out.println(String.valueOf(Global.counter));
        return null;
    }
}

log
1

@rabbah
I am considering utilizing a global variable in a python action for a DB connection pool so as to avoid unnecessary overload on my DB system.
My question is: What do you think about this pattern? Is it encouraged?

If you use a global variable, as you said, you can reuse the DB connection pool or use the cache layer.
I think it is more useful to use it if the action code developer understands the global object well. (you should handle an exception, and consider the memory limit of the container. )
There are also some examples of actually using the global object to retain state.

https://www.trek10.com/blog/stateless/
https://rewind.io/blog/simple-caching-in-aws-lambda-functions/

With the introduction of action loop as the common proxy, we can also close this issue. Other runtimes using the new proxy support globals.

PHP:

code https://apigcp.nimbella.io/api/v1/web/playground/default/showCode/user911348/samplePHP
run it https://apigcp.nimbella.io/api/v1/web/playground/user911348/samplePHP

Java:

code https://apigcp.nimbella.io/api/v1/web/playground/default/showCode/user911348/sampleJava
run https://apigcp.nimbella.io/api/v1/web/playground/user911348/sampleJava

I didn't try Ruby but confident it also works because it also uses the new proxy. It's conceivable we can add a new test to the basic runtime test suite to cover this use case now.


Test changes to account for 0.39 deprecations

Updating some tests to account for various deprecations happening in pennylane for v0.39.

[sc-73913]


Update account balance (New version)

When account or networkActive is updated, switch to the active network and active account, and monitor balance with block mined.

And each round we need to send multiple query to provider, maybe we can leverage other libraries, I found two, to decrease the call count:

https://github.com/Rubilmax/ethers-multicall-provider
https://github.com/ethers-io/ext-provider-multicall


allow input of negative sign first before entering a number?

I wonder if you could modify to allow entering negative sign first before the numbers?

I could take care of this issue @cesarrew

@christopheelkhoury
Hello, any update on this.

@kalyanvedurumudi author never gave me authorization to work on this.

@kalyanvedurumudi author never gave me authorization to work on this.

The author doesn't seem to have time for the project since June 2018. Being this an open-source project and everything, perhaps someone would like to pick up the glove and create their own fork?

@guillep2k great idea. I've forked it right here. If anyone would like to filter the issues open here and open them on my fork, we could get this wheel rolling.

@guillep2k You could become one. There's no harm in that. Could help the community and help your expertise at the same time.

@guillep2k You could become one. There's no harm in that. Could help the community and help your expertise at the same time.

I'm not even using Angular! :-)
Anyway, I can do that with the open issues, but can't with the pull requests. I'll drop a line on those.

@christopheelkhoury I'm unable to open issues. There's no such option in the fork. Perhaps you need to change some configuration?

@christopheelkhoury Yes, you need to go to the "Settings" tab and check the "Issues" box option so I can add the issues.

@guillep2k done

I know that the issue will remain open while the original author isn't working but I was curious if @thelebdev has a workaround for this. I've checked your fork of this project and cannot see any future commits or resolution on this issue - did you include this into your fork and was it ever resolved?
Thanks

Hey @joevandebilt buddy, I mentioned here that I've forked the repo and would like to kick-start support for it from a different perspective. I've merged a PR that was opened there recently.
If you want to re-kickstart development on this package, let me know


Spontaneous events callbacks

Possible solution for feature discussed in issue #19.
Please review at your convenience.
Feel free to tell me to change stuff. :)

Sorry for the delay. Please read my comments. This commit https://github.com/haku/chromecast-java-api-v2/commit/e5b0a16659d2a8248596e11bd189c9d0fea40d95 looks fine, another one requires some updates.

The EventListenerHolder parameter on Channel is because it needs to be the same instance that the ChromeCast instance has.  This way if the ChromeCast disconnects and reconnects again any previously added listeners are still present.
I used CopyOnWriteArraySet just because it seemed like the right tool.  The list of listeners is rarely going to be changed but very frequently read and iterated over.  While the chance of a listener being added or removed in one thread while being iterated over to invoke in another is low, it seemed prudent to protect against.  Using a Set from java.util.concurrent avoids the need to synchronise every time a listener is invoked.
I have restructured the way events are passed to the the listeners so they are wrapped in ChromeCastSpontaneousEvent.  Please let me know what you think.

The EventListenerHolder parameter on Channel is because it needs to be the same instance that the ChromeCast instance has. This way if the ChromeCast disconnects and reconnects again any previously added listeners are still present.
I used CopyOnWriteArraySet just because it seemed like the right tool. The list of listeners is rarely going to be changed but very frequently read and iterated over. While the chance of a listener being added or removed in one thread while being iterated over to invoke in another is low, it seemed prudent to protect against. Using a Set from java.util.concurrent avoids the need to synchronise every time a listener is invoked.

This is fine. Let's leave it.

I have restructured the way events are passed to the the listeners so they are wrapped in ChromeCastSpontaneousEvent. Please let me know what you think.
Show all checks

Well, I don't quite understand why you have created an hierarchy of events. I think you should either use enumeration to detect event type or hierarchy. I prefer enumeration. You can encapsulate logic to get the actual object right into enumeration element. It's up to you how to implement this, but I insist to have a single way - either enums or hierarchy of classes.

I have removed the hierarchy of sub-classes.
Tired me last night made things more complex than they needed to be.

Merged. Thank you.


Python example to create an AKS cluster

This example will create an AKS cluster. I left out any sys runtimes as I wasn't sure if the Pulumi team would prefer any parameter runtimes to be passed in or not.

Hi @AdminTurnedDevOps, thanks for opening this PR.
We usually put our public examples to the central repo here: https://github.com/pulumi/examples
The examples in provider repos are meant mostly for integration testing.
There's already an AKS/Python example in https://github.com/pulumi/examples/tree/master/azure-py-aks. Do you feel like that example is not enough to get started with AKS and python? If so, consider contributing to improve it.
Thank you!

That makes sense! Thanks. I was looking under the Azure examples, but I couldn’t find it. Now I see it was in the main examples page.
Perhaps one example under the Azure portion?


Duplicate DataDrivenEntityTriggerEvent, no DataDrivenEntityTriggerEventSignal

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'BeforeDataDrivenEntityTriggerEvent'
See error

Expected behavior
BeforeDataDrivenEntityTriggerEvent leads to a page explaining its properties rather than what should be its signal class
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Microsoft Edge
Version: 97.0.1072.76

This issue could be closed now, Thank you @MajestikButter


Operator: implement operator watch logic

Watch deployments that are annotated with the reload-on-secret-change annotation. Deployments with the value "true" shall be watched.
Annotation name:
alpha.vault.security.banzaicloud.io/reload-on-secret-change

Specification for this feature has been changed and its progress is tracked in another project.


Issues from 20 to 30 excluding issue 29

In this pr these issues are contained:

closes #20 , closes #21 , closes #22 , closes #23 , closes #24 , closes #25 , closes #26 , closes #27 , closes #28 , closes #30
Also as we discussed in private chat would be good to consolidate issues more so that we have at least one issues per category instead of one issues per subcateogry/text change
Heres pr that includes all the changes...keep in mind i included changes from previous pr as well because there were some folder changes which will be hard to merge later on..
Also you can specify if somewhere table of contents for subcategory is needed like in /Governance/Alchemy/
Here it is deployed https://bafybeiew576g2zvumyx2isdbdkssa3mwpuydnlu6mrp45j5drggb3avnmy.ipfs.dweb.link/

Awesome work @Mi-Lan! Thanks.
In the future, one issue will be opened per category, and comments related to a PR will be held in that thread rather than the Issue itself.
Regarding table of contents, I will be aiming to address this alongside internal linking (Some links currently lead to google docs, which I will ratify to work internally). I will discuss this with you shortly since the base content is almost fully integrated at this point. :)

heres ipfs with fixed table https://bafybeihekgnd4td64gc4st477akoyeov6sgvllvq6hfn7iwgy537n3ulra.ipfs.dweb.link/


Vendor pathtools

Description
Pathtools is broken on Python 3.12 and appears to be dead (no commits in 7 years).  This break WandB on Python 3.12.
Suggested Solution
Please consider vendoring it or using pathlib instead.
Alternatives
No response
Additional Context
No response

Hi @NeilGirdhar , thank you for writing in. We've received your request and will review and provide an update.

Also came across this issue -- would be grateful for a fix!

Hi @NeilGirdhar @danielkelshaw. We will be turning on support for py3.12 sometime in the next week and will be addressing the pathtools component. You can expect this to be released with next SDK version in 2 weeks.

Looks like this is fixed by #3443


topsql: fix instances output more than given time range (cherry-pick #104)

cherry-pick #104 to release-5.4

Signed-off-by: Zhenchi<EMAIL_ADDRESS>What problem does this PR solve?
In master, if we want to query instances between ts 400 and ts 500, we query vm via /api/v1/query_range with arguments
query = last_over_time(instance[100s])
start = 400
end = 500
step = 100s

However, it will fetch instances from (300, 500].
What is changed and how it works?
In this patch, we query vm via /api/v1/query with arguments
query = last_over_time(instance[101s])
time = 500

Finally, It will fetch instances from [400, 500].
Besides, fetchSumFromTSDB can also change to the same way.

/merge


Tube definition

O3PO:tube has O3PO:nozzle as subclass, and is defined as "def. a functional complex that is enclosed and hollow and that acts as a passageway to carry different sorts of things (e.g., fluids, cables, other ducts)".
There is no reason to believe a pipe fitting, hose, or any other enclosed and hollow element that allows the passageway of fluid should not be a tube too.
One could argue even open valves and open line blinds adhere to this description

I modified the definition of tube by adding "long" to the description. Also moved nozzle to the material artifact class.


Feature/post timeout

Added optional control of the http request sent via PostSolrConnection.
Currently the ability to set the http timeout is enabled.
Non breaking change to the internal API.
Non breaking change to the external API.
Fairly extendable solution.
Please review and comment.

Hi @TLogik ,
Thanks for the PR!
After having just a quick look I'm a little confused (maybe I missed something):

How will the end-user (the programmer using SolrNet) define the timeout? Since it is defined only on an internal method, which is being called by other methods (Get and GetAsync)?
Post and PostAsync do not share the timeout setting, which might be a bit confusing.
Why is the setting itself a Func<int> and not a normal int property?

The idea of the settable timeout is great, we support it in the AutoSolrConnection, by defining the HttpClient, would indeed be nice to see it on the PostSolrConnection as well.

Hi @gjunge
Great questions :-)
I am actually pulling the pull request back.
It was mainly aimed at the get request, which is actually a POST.
Also the SolrConnection exposes a Timeout, not via ISolrConnection, but thru actual implementation.
https://github.com/SolrNet/SolrNet/blob/master/SolrNet/Impl/SolrConnection.cs#L87
But just to go thru the questions.

They cannot! (epic fail) Needs to be fixed (but i will, for now, retract the pull request).
True. In general the PostSolrConnection class is somewhat confusing. the GET method actual is a POST.
https://github.com/SolrNet/SolrNet/blob/master/SolrNet/Impl/SolrPostConnection.cs#L51
Really good question which i was also asking myself. There is not a really good reason but i chose it because of:

I would have to add nullable value types, since the properties should be optional - and i do not really like nullable value types. The function delegates can be nullable.
As function delegates there could be some level of flexibility behind how the value was actually generated that could implement business logic. Possible a bit overengineered for at request timeout - but it provides a way for the options to behave differently based on system behaviour. This can ofc. also be achieved via 'normal' get/set.


Create guided_decoding.md

Creating example file on how to use guided decoding capabilities in VLLM.
This was originally created with Jupyter notebook and converted to markdown. None of the examples currently are in Jupyter notebook so let me know if you would prefer that.
Let me know if there is anything else you would like to see. It would be helpful if anyone understood the following categories:

Regex: I struggled to get longer examples to work. It appears outlines does not allow for multiline outputs and as such many of the special regex characters do not work.
Guided input: I need a better name for this and would like to know if there is an easier way to do this. I had hoped that turning add_genearation_prompt off and providing an assistant initial response would work but it appears that the jninja template adds an eos token.

As an aside, it would be nice if there was a format prompt endpoint for the openai endpoint.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

cc @br3no @rkooo567 @njhill

will take a look. I feel like we should wait a little bit until we implement the API section in this RFC though https://github.com/vllm-project/vllm/issues/5423 (in case of API change)

FWIW, as a user, I found this document to be super-helpful, as the vLLM docs only discuss automatic function calling, and I couldn't find any documentation about structured JSON output.

It looks like a different doc got merged on this topic in #9943. I think this PR can be closed in favor of follow-ups adding and improving the doc that was merged.
https://docs.vllm.ai/en/latest/usage/structured_outputs.html


Update README to remove references to mysticmine website

Hi there,
The mysticmine.com website seems to be redirecting to this GitHub repo, so the links in the README saying that one can find more info and buy the game on mysticmine.com should probably be removed.

Not sure about this since this README can be accessed outside of github (through a git clone or a packaged zip)

Well I mean the link to mysticmine.com should be removed and replaced by a link to https://github.com/koonsolo/MysticMine. Or it can be kept, but it should not mention that you can buy the game there, since you can't buy it on GitHub.

Indeed the part about buying the game should be removed


Fix broken test

fix unit tests (fix relative path issue, flickr -> github users)

@EisenbergEffect I've checked those and they work. On-Top of that there is currently a bug with Karma-JPSM (https://github.com/Workiva/karma-jspm/issues/77), which based on the outcome, might require a slight modification of our karma.configuration file. Nevertheless I think we're good to merge this one already.

It seems that karma-jspm is not being actively maintained...

I think we found the solution, thanks to the help of our community users. https://github.com/Workiva/karma-jspm/pull/84
I'd welcome anyone to weigh in into the PR so that the karma-jspm people see that its important :+1:

@EisenbergEffect on top of the changes from this PR please also update the karma-jspm version in package.json to -> "karma-jspm": "2.0.1-beta.2". Checked it out now and all the tests are passing now with the new tag :+1:

i'll go ahead and submit a pull request with the updated package json

@EisenbergEffect Please use my pull request instead, which includes this pull request from @bohnen as well as the change proposed by @zewa666.

Ok. I'm closing this PR then.


Setup OpenCollective sponsor button

This adds a sponsor button to the repo, might be a cleaner approach compared to adding it in the readme :)


[i2c,rtl] Compress ACQ FIFO entries

Description
This issue is based on a TODO that I added in this pull request: https://github.com/lowRISC/opentitan/pull/21857
Encode i2c_acq_byte_id_e more efficiently in the ACQ FIFO. Each entry in the ACQ FIFO does not need to contain both an 8 bit data field and a 3 bit identifier. We should have the ACQ FIFO be 9 bits wide where the MSB indicates whether it is a data byte or a control byte. This way we can add more values to this enum without having to widen the ACQ FIFO width.
The affected file: https://github.com/lowRISC/opentitan/blob/master/hw/ip/i2c/rtl/i2c_pkg.sv

2 ID bits might be necessary to encode the six enum values together with the 8-bit data field. Something like this could work:
id     abyte
2'b00 <abyte> is a byte (could be address+r/w or data) that we NACK'd
2'b01 <abyte> is a data byte that we ACK'd
2'b10  <abyte> contains the address+r/w that was ACK'd, but the transfer will continue and NACK subsequent data bytes (this only happens for writes)
2'b11  Start, Restart, or Stop -- depending on the value of <abyte>

Each entry in the ACQ FIFO can be up to 10 bit wide, so 2 ID bits are okay, but not more

@marnovandermaas may I ask you to please prioritize this (or let me know if you cannot work on it at the moment)? This is a prerequisite for using a 10-bit-wide SRAM to store ACQ FIFO entries (part of #22159).

@andreaskurth I won't have time to look at this before next week. One thing that was mentioned to me is that for a regular start it would be good to have an encoding of which I2C address it went to (at the moment this could be done with one bit) and also whether it was is a read or a write. I still think we can do it in 9 bits:

0XXXXXXXX where X's are 8 bits of data byte that we acknowledged.
10XXXXXXX where X's are the 7 least significant bits of the data byte or address+R/W that we not acknowledged.
110SAAAAR where S is one when it is a start or zero when it is an address that was nacked and will continue to subsequently NACK all data bytes that follow, A is a 4-bit encoded address, R is whether it was a read or a write.
1110XXXX where X's are a 4 byte encoded control bits which can either be a stop or a restart for now.

Okay, thanks for the info. Let's hold this for now: With #22216 the SRAM that now backs all FIFOs is 13 bit wide (due to the width of the FMT FIFO; see #22166). If we don't need to further optimize the area, we'll close this issue (or at least defer it to a future revision).

This may be easier than compressing the entries of the FMT FIFO (#22166), but as in the current architecture all FIFOs are stored in the same SRAM, there's no value in compressing just the ACQ FIFO entries. Potential future release and backlog.


Should verify checksum on install

https://github.com/cloudskiff/driftctl/pull/190 will add checksum alongside binaries.
We should verify it on install !

Binary checksum verification and signature validation done in 08d0350


Update logo

Tracy (Tan Yun) designed new logos for us, after merging this PR I will update the readme with the absolute URL. This PR also updates the docs website.

That looks awesome! Thanks @tanyuntracy! 🎉


Router - add combinatorial logic to override the next_tile_arb_fifo_id cardinal acording to the current tile_id & the destination tile_id

Note - we may be able to use the module we have already created for this override.
But we need to make sure we set the cardinal parameter to "LOCAL".
And make sure the RTL will set the correct value taking into consideration the current tile_id (which is the next_tile_id??) so it will match the correct fifo_arb direction. (north/south/east/west)
Then once it reaches the router & matches the correct fifo_arb cardinal, the next_tile_fifo_arb_id will be overridden again.

@yeonatanPerelman - this is done?
Note we need to do something similar in the mini_core_tile to set in HW the correct next_tile_fifo_arb_id.
PLease have a separate issue for that.

This is Done


Refactor client codes

Client side codes now are really a mess.
Should divided scripts into parts according to its usage.
And minify them then include.

Considering front-end framework for now.
Maybe one of below:

Angularjs
React
Polymer

If you have any ideas, please comment, thank you!

The css files could be easily treated like LESS, which could be compress automatically by the server. I think there are some modules which compress the client javascript files bevor sending the request (or at server start).
Dividing into separated files would be the easiest solution to start, and becoming an overview of the current situation.


Disk Infrastructure and Interrupts Fix

This PR introduces the disk drive system. It also includes a fix for the interrupt system. Interrupts are now inhibited when the condition code register is set high. It also introduces a new memory routine for reading addresses $FFF0 - $FFFF (These addresses should be read from the ROM regardless of the memory mapping mode and the MMU).

Codecov Report

Merging #14 into master will decrease coverage by 2.39%.
The diff coverage is 15.2%.

@@             Coverage Diff             @@
##             master      #14     +/-   ##
===========================================
- Coverage     84.88%   82.48%   -2.4%
- Complexity      907      910      +3
===========================================
  Files            21       22      +1
  Lines          3460     3574    +114
  Branches        257      281     +24
===========================================
+ Hits           2937     2948     +11
- Misses          459      556     +97
- Partials         64       70      +6

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/ca/craigthomas/yacoco3e/common/IO.java
11.62% <ø> (+0.51%)
2 <0> (ø)
:arrow_down:

...java/ca/craigthomas/yacoco3e/runner/Arguments.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...a/ca/craigthomas/yacoco3e/components/Emulator.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...in/java/ca/craigthomas/yacoco3e/runner/Runner.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../craigthomas/yacoco3e/components/IOController.java
88.92% <30.76%> (-4.8%)
181 <0> (+1)

...ava/ca/craigthomas/yacoco3e/components/Memory.java
71.29% <33.33%> (-1.09%)
33 <1> (+1)

.../ca/craigthomas/yacoco3e/components/DiskDrive.java
8.21% <8.21%> (ø)
1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef2325...9ad7c51. Read the comment docs.


Semantic Commit Test

This PR was just to test the Semantic Commit Workflow, which seems to run fine.

Test: Semantic PR Title seems to work

Can confirm this is fully working, deleting branch.


[HOLD for payment 2023-05-22] [$1000] Android - App crashes upon inputting @ with characters for specific accounts

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/18469
Action Performed:

Login to NewDot
Open any chat, focus on compose box
Input @kr
Depending of device and account try inputting and deleting comments: @kr, @jack, @john
Accounts with repro crash:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Expected Result:
App does NOT crash upon inputting @ with characters for specific accounts
Actual Result:
App crashes upon inputting @ with characters for specific accounts
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/df359ff7-b715-4bd6-b4d1-d478d27ff4bb
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01959ee93ac2a57333
Upwork Job ID:<PHONE_NUMBER>371589120
Last Price Increase: 2023-05-12

@puneetlath seems this is related to your Mentions PR: https://github.com/Expensify/App/pull/18469
Do you think this should be a blocker? 🤔

Crazy

Sent hiring offers to @allroundexperts and @mollfpr.
@mollfpr friendly reminder on the checklist. I think regression test isn't needed since this was caught during regression testing.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes due to multiple Layout animation calls
What is the root cause of that problem?
Seems LayoutAnimation.configureNext called on the wrong places where it definitely gets called for both the functions calculateEmojiSuggestion, calculateMentionSuggestion.
What changes do you think we should make in order to solve the problem?
We should place the call within the condition so it makes sure to execute any of the one feature only instead of both calls. Calling it exactly before updating the state will also ensure a smooth transition.
https://github.com/Expensify/App/blob/2266274a137b0e2f9c1f8d937ff927626264c77c/src/pages/home/report/ReportActionCompose.js#L509-L512
https://github.com/Expensify/App/blob/2266274a137b0e2f9c1f8d937ff927626264c77c/src/pages/home/report/ReportActionCompose.js#L552-L558
https://github.com/Expensify/App/assets/14358475/6a455f7f-82fe-4089-844e-18ef45144c17

Paid @allroundexperts.
@mollfpr I'll get you as soon as the checklist is done.

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/14686

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/14686#issuecomment-1557518431

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1684772772741469

Thanks @mollfpr.
All paid now!


[AutoPR applicationinsights/resource-manager] Update applicationinsights management Node.js package version to 2.0.0

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3538

(message created by the CI based on PR content)

Codecov Report

Merging #3040 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3040   +/-   ##
=======================================
  Coverage   57.43%   57.43%
=======================================
  Files        7767     7767
  Lines      158336   158336
=======================================
  Hits        90937    90937
  Misses      67399    67399

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d1fb4...368ca14. Read the comment docs.

NodeJS


Option to disable/enable calendar icon for journal pages

Idea
The calendar icon for journal pages has fixed date on them, that feel very wrong & confusing to me.
I can see few ways of solving this:

Make the icon dynamic to suit the current date or journal page they belong to.
Remove the date/month from the icon & change it to something more vague, but still identify as journal page.
Provide option to disable or enable the icons for journal page, like you've option to disable the favicon for external links.

Thanks for your amazing work in the extension, I especially love the last few updates.

dynamic SVG can be a pain and too much work for so small thing: different langs, different date locale settings to parse... i think will just change icon to calendar without day.
on windows current emoji better than on mac )

something like this

This looks neat! Does it also looks like that on linux?

yes, it's svg, not emoji (which has tens of variation, depending on provider)

check latest release 2.5.x


Viewer - Add Comment Analyzer, optimize labels for test print

Optimize Viewer page

Would you like to increase the version?


select one tiflash node as gc owner

What problem does this PR solve?
Issue Number: ref https://github.com/pingcap/tiflash/issues/6827
Problem Summary:
We need to campaign one tiflash as GC owner for LockService
What is changed and how it works?

Add OwnerManager for selecting one owner through PD/etcd
Get the owner id by TMTContext::OwnerInfo
Add etcd related codes

etcdpb from etcd-io/etcd v3.4.24
Etcd::Client

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)

ETCD_ENDPOINT=<IP_ADDRESS>:6520 ./dbms/gtests_dbms --gtest_filter='*OwnerManagerTest*'
test passed

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-unit-test

/build

/merge


fix(curriculum): grammatical error in instruction - Odin project: Recipe page

Checklist:

[X] I have read and followed the contribution guidelines.
[X] I have read and followed the how to open a pull request guide.
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #53696
In this PR :
I fixed fixed the grammatical error in instructions in the Odin project : Recipe page
Error:
You should have a <ol> with the the steps as the list items <li>.
Fix:
You should have a <ol> with the steps as the list items <li>.

Hi @JoeMakuta. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


[TASK] Add ability to convert a History Set to a Point Set

Issue Description
Sometimes it is useful to convert a History Set into a Point Set, and keep all the data.  Current features don't easily do this (so we can convert and keep the max values, or the min values, or other subsets, but not the entire data).
Describe the solution you'd like
If there is a History set with input: x, y, pivot parameter: t, and output: a,b I would like a point set with input: x,y,t, and output: a,b.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Closure checklist passed...
Closure approved via #1396

Closure checklist passed...
Closure approved via #1396


lastfm scrobble support broken?

Apologies if this isn't broken. I set the envar(s) on my instance and it looks like it's reading from the mpd playback but not submitting to lastfm. During container instancing I see:
b0280688f7bf [last.fm]
b0280688f7bf url = https://post.audioscrobbler.com/
b0280688f7bf username = <EMAIL>
b0280688f7bf password = <PASSWORD
b0280688f7bf journal = /log/mpdscribble-lastfm.journal

I can also see that it's internally seeing the playback:
$ podman exec -it mpd /bin/cat /log/scrobbler.log
2024-04-08T16:20:18+0000 starting mpdscribble (mdc 0.24)
2024-04-08T16:20:18+0000 loaded 0 songs from /log/mpdscribble-lastfm.journal
2024-04-08T16:20:18+0000 waiting 15 seconds before reconnecting
2024-04-08T16:20:34+0000 connected to mpd 0.23.5 at localhost
2024-04-08T16:21:23+0000 new song detected (Old Crow Medicine Show - Elzick’s Farewell), id: 197, pos: 0

However I never see submissions to last.fm? I also noticed that https://post.audioscrobbler.com/ has a text page that suggest redirection to http://www.audioscrobbler.net/ ?

Hello, I have to say I have not been using mpdscribble for quite some time now. I currently use yams with my docker image on a daily basis and it works.
However, do the files you are playing come from the mpd library or from some other source, like a upnp media server?

If you are using upnp, last time I tried, the problem was with missing "duration" of the song. Scrobbling was therefore not possible using mpdscribble.
However I just tested the "embedded" mpdscribble with an mpd instance with its own library and I can see my scrobbles.
If you are not using upnp, maybe there's some other issue, in this case please post your compose file and/or any relevant information.

Not using upnp, just mpd. I'm trying to build up a pod with upnp to ultimately play from a subsonic instance (navidrome) and qobuz).  Can you post the mpscribble logs?
Also, from inside the mpd container, when playing, can you post the output of
mpc current -f %file%
For docker I would do something like
docker exec -it mpd bash
then send the command from the terminal. I'm sure you know how to do that with your containers (I cannot be sure I would know it with podman)

Hello, did you solve the issue?
p.s. I am making progress with the listenbrainz-mpd docker image!

Apologies for the long delay!

I currently use yams with my docker image on a daily basis and it works.

I'll likely do this, I put in an issue on that project because it seems to exit before I can authenticate.

One thing to check, mpdscribble expects to be able to connect to mpd using "localhost" as the address. The port of course can be specified and defaults to 6600. This should be ok with bridged networking as well as with host networking in docker.

Nearly positive the pod created by podman would facilitate this working.
While playing music:
[tune@muckle mpd]$ podman exec -it mpd mpc current -f %file%
Artists/Ray LaMontagne/Ray LaMontagne - God Willin' & The Creek Don't Rise (2010) [FLAC 16bit 44kHz]/06 This Love Is Over.flac

I correct myself, it's configurable using SCROBBLER_MPD_HOSTNAME

I attempted setting this to mpd (the container name) and to <IP_ADDRESS> but it doesn't appear to resolve the issue.

Hello, thank you for verifying with mpc.
Of course mpdscribble should work, the file is local, I assume it has title and artist tags, so I don't see why it should not work.
The unusual thing of the scrobbler feature included in mpd-alsa-docker is that the script will launch the scrobbler in the background before launching mpd.
Can you verify that a mpdscribble process is actually running?

no they are not available, but you can install them running a bash in the running container and issuing these:
apt-get update
apt-get install -y procps
of course this won't work if the app is run with a --user switch or podman equivalent.
anyway, the process should be also visible from the host machine, so just run a
ps aux | grep mpdscribble
from the host, and the process should appear. Double check that a
ps aux | grep mpd
actually returns something.

I'm here also. I am quite a noob on discord. Chat me if you find me!

For any other users: we did not talk about this specific issue.
I still can't figure out what is happening. I would ask you two things:

Can you please post the full container log, so we can check the generate configuration files?
From inside the container, can you please verify that a telnet operation to the mpd/port specified on the mpdscribble.conf file are actually reachable?

Thank you


Textual definition update: add EC/RHEA xrefs to GO:0052642 lysophosphatidic acid phosphatase activity (?)

id: GO:0052642
name: lysophosphatidic acid phosphatase activity
def: "Catalysis of the reaction: lysophosphatidic acid + H2O = phosphate + monoacylglycerol." [PMID:20045079, PMID:7966317]
synonym: "LPA phosphatase activity" EXACT []
synonym: "lysophosphatidate phosphatase activity" EXACT []
is_a: GO:0016791 ! phosphatase activity
I think this is the same as https://enzyme.expasy.org/EC/<IP_ADDRESS> / https://www.rhea-db.org/rhea/33155:
EC:<IP_ADDRESS>
Name:2-lysophosphatidate phosphatase
Alt_name:1-acyl-sn-glycerol 3-phosphatase
Reaction:a 1-acyl-sn-glycero-3-phosphate + H2O <=> a 1-acyl-sn-glycerol + phosphate
Would you agree @kaxelsen @pgaudet ?
I see UniProt has Q9SRQ6 (arabidopsis NPC3) annotated to EC:<IP_ADDRESS>/RHEA:33155 and GO:0052642 from PMID: 20045079

Looks ok to me

OK, thanks.
From the ontology call the other day, it sounded like I need to add 'activity' to the end of the EC names when adding them as synonyms??

Yes, this is how we have been doing this, let's stay consistent. Hopefully the future script to maintain the synonyms up to date can fix all these to match the EC names.