Is it can  be integrated into a qt ui program?

I think using the main viewer class with QT would be difficult. Meanwhile, some elements (e.g., GLCanvas and 3D primitives) are based on pure OpenGL, and might be possible to be used with QT.


fix: background context should affect only dark background in Textarea

There are 7 places where getContext('background') is used - Checkbox, Input, InputAddon, Radio, Textarea, Toggle and ToolbarButton. In all of them except Textarea this context only slightly changes color of some aspect in dark mode. But in Textarea it also changes bg-gray-50 to bg-white.
Removed that switch to be consistent with other components. (And in ToolbarButton just moved the same class from a conditional statement.)

Can you show me screenshots of what are different in the Textarea from other components?

I thought it is clear - if the "background" context is set (which Frame does) it changes its background color to white in non-dark mode. Other inputs do not do that.

Here is a screenshot of <Input /> and <Textarea /> inside Modal:


request for setting - Prefer IPv4 over IPv6

Prerequisites

[X] Verify that this is not a Windows issue;
[X] Refer to the system requirements;
[X] Refer to the How to use;
[X] I do not use a homebrew Windows image;
[X] I did not tweak Windows before that could cause system instability;
[ ] If your issue concerns the Wrapper, please mention @BenchTweakGaming in issue

Steps to reproduce
script can only enable\disable ipv6.
But official recomendation is "Prefer IPv4 over IPv6" instead . https://learn.microsoft.com/en-us/troubleshoot/windows-server/networking/configure-ipv6-in-windows
since a lot things linked to ipv6 service.
so that about both win10+win11.
Windows Version
win11
Sophia Script version
11_v6.2.7

Hi. This is not actually an issue. Script only provides feature to disable not, it doesn't make users to do it. So everyone can just comment out this function.

as i say it request, why this option have only 2 options instead of best possible?

You meant, y

@TristisOris, https://github.com/farag2/Sophia-Script-for-Windows/releases/tag/6.3.0


android: fix memory overwriting in uv_interface_addresses()

Fix a regression of https://github.com/libuv/libuv/pull/2486.
For IFA_ADDRESS and IFA_LOCAL network interface, we'll write two IP addresses to ifaddrs:

IP address: https://github.com/libuv/libuv/blob/v1.x/src/unix/android-ifaddrs.c#L520
Network mask: https://github.com/libuv/libuv/blob/v1.x/src/unix/android-ifaddrs.c#L583

In that PR, it added a break, then we only malloc one IP address memory space for l_entry, which leads to memory overwriting issue.

@linroid You're targeting master with this PR but you probably want to target the v1.x branch because that's where releases are cut from.
I can't cherry-pick it to v1.x because it doesn't apply cleanly. Can you retarget this PR? Thanks.

Never mind, I was able to merge it with some wedging. Landed in v1.x in commit 7656e981, thanks!


traefik:v1.1.0-rc2 with rabbitmq:3-management not working fully

I'm using traefik:v1.1.0-rc2 with rabbitmq-management using this rule :
[backends]
  [backends.rabbitmq]
    [backends.rabbitmq.LoadBalancer]
      method = "drr"
      sticky = true
    [backends.rabbitmq.servers.1]
    url = "http://x.x.x.x:15672"
    [backends.rabbitmq.servers.2]
    url = "http://x.x.x.x:15672"
    [backends.rabbitmq.servers.3]
    url = "http://x.x.x.:15672"

[frontends]
  backend = "rabbitmq"
    [frontends.rabbitmq.routes.rabbitmq]
    rule = "PathPrefixStrip: /rabbitmq"

When i'm using the rabbitmq manager like this url : http://<IP_ADDRESS>/rabbitmq/#/queues/%2F/task.begin
The access.log file show this : GET /api/queues///task.begin HTTP/1.1" 404
I think that the /%2F/ is replaced by a simple /. A mode like 'ProxyPass http://localhost:15672/ nocanon' is available ?
Thanks.

@LazGit which version of traefik are you using?

I tested the master version and the v1.1.0-rc2 for docker swarm support. Same problem :/

@LazGit indeed, due to the underlying muxer used in traefik https://godoc.org/github.com/gorilla/mux#Router.UseEncodedPath.
As a workaround, I suggest to use Host rules for now

I'll close this issue, because I think the question is answered, but feel free to continue the conversation.


Fix static type for dataparser configs

https://github.com/nerfstudio-project/nerfstudio/pull/1909 adds support for custom dataparsers via a type that's dynamically generated from tyro.extras.subcommand_type_from_defaults(), but unfortunately this type can't be used as an annotation. (in pyright / pylance it gets resolved to Unknown)
Not a great solution, but the best one I can think of, curious about thoughts from @jkulhanek / @tancik.

I don't think there is anything wrong with it. I tried to achieve the same using typing.cast(typing.Type[DataParserConfig], ...). The type gets resolved correctly, but pylance complains.


Fix missing conditional in create_partitions

./setup_sdcard.sh: line 647: syntax error near unexpected token fi'
is generated unless missing then is added back in.

Crap, I had forgotten to push this same patch while at work today. Sorry for leaving it broken.

Happens to us all, thanks for all the hard work!


extra guide lines on large file

Testing #133906
set "editor.guides.bracketPairs": true
clone the typescript repo https://github.com/microsoft/TypeScript and open src/compiler/checker.ts (this is simply a large file, not sure if that has anything to do with this).
result: additional vertical guidelines as seen here:

If you click around they guides will be highlighted and eventually disappear...

This has the same reason as #133921 - when opening checker.ts initially, bracket pairs are not very accurate - in particular not, when a lot of brackets appear in strings and comments, as in checker.ts.
I think the solution here would be to consider the minimum indentation when rendering these bracket guides.


react-intl v2

[ ] update messages, use collocation
[ ] add universal user agent detection (browser, server, native)
[ ] fix react native, https://github.com/yahoo/react-intl/issues/119#issuecomment-180355897
[ ] Ideally allow to switch app language during runtime
[ ] este validation should be stateless and use only default messages

https://github.com/yahoo/react-intl/blob/master/UPGRADE.md

collocation, does that mean you want the messages to be stored with their components?

It means the default messages should be written in a component, so en dictionary should be unnecessary, ideally. Not entirely sure.

The only issue with that, is reuse across mobile, server, and browser. No?

Indeed, that's a pretty good point. I think we still need intl/msg. Any idea?

@stephengfriend Check d489a1ffb76ea96a907b7d0ceef0bb18bbd99da7. I think I got it right. Use definedMessages at start, and when you need to reuse it, move them into /common/appFeature/fooMessages.js :-)


Fix tool exit order

We now finish_activity only after the _exit_stack has finished to ensure the finalization of the Components of a Tool happens during the activity.

@mexanick could you re-approve?


publishConfig is not preserved when building dist/

Bug Report or Feature Request (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request

Generator Version
5.8.0
Repro steps.

Add
"publishConfig": {
    "registry": "xx"
  },

to package.json in root
Then run gulp build
Desired functionality.

I would expect to see the publishConfig object in dist/package.json
Mention any other details that might be useful.

It seems easy to fix, just add
publishConfig
to
let fieldsToCopy = ['version', 'description', 'keywords', 'author', 'repository', 'license', 'bugs', 'homepage'];

(gulpfile.js, line 316)

hi @eh-am
Sorry for the late answer (actually, i responded via mail, but somehow it got lost).
In order to keep the distributed package.json as  light as possible, i only copy relevant  properties required to publish your package on NPM and needed by final users when installing it.
publishConfig seems not to be in such case, but instead is very specific to your project.
You can simply edit the gulpfile.js as you did.


Cannot type anything in Firefox nightly

On Firefox nightly 68.0a1 (2019-03-22) on Debian stable, I can't type anything other than the Enter key.
@alex suggested I try setting the preference dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode to include pypyjs.org, and that fixed it and I can type normally. Presumably there's some non-legacy thing PyPyJS needs to do.

It's perfect!
Ryan
On Wed, Mar 27, 2019, at 05:54, Geoffrey Thomas wrote:

On Firefox nightly 68.0a1 (2019-03-22) on Debian stable, I can't type
anything other than the Enter key.
@alex https://github.com/alex suggested I try setting the preference
dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode to
include pypyjs.org, and that fixed it and I can type normally.
Presumably there's some non-legacy thing PyPyJS needs to do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pypyjs/pypyjs/issues/217, or mute the thread
https://github.com/notifications/unsubscribe-auth/AACHhxq0WsMS5PXgKvBAUMt5701LJKEPks5vamz4gaJpZM4cMNbN.

It's perfect!

Well that's embarassing, looks like I email replied to this github issue rather than to an unrelated email. Sorry about that.

Thanks for reporting this, but I have to be honest, I don't expect to make time to dig into this issue at all.

Just so you know, same problem and (hacky) solution on Ubuntu 18.04 LTS firefox.

This still exists on Ubuntu LTS 22.04 / Firefox 106 and will presumably do so forever - the explanation is here - https://support.mozilla.org/en-US/kb/dom-events-changes-introduced-firefox-66
The work around remains

go to about:config in your firefox URL bar (accepting any warnings)
search for dom.keyboardevent.keypress.hack.use_legacy_keycode_and_charcode
add ,pypyjs.org to the end of the configuration string

Thanks for leaving this up so that it can be experimented with.


DBZ-3449 Adding 'quick' profile

https://issues.redhat.com/browse/DBZ-3449

@jpechane, there still seems to be some enforcer version issue, as revealed by this (unrelated) PR. Building core with JDK 8 won't work, the GH Action would have to set up two JDKs and use JDK 11 for the main repo and JDK 8 for the Cassandra connector.

@gunnarmorling GH Workflow updated and PR applied, thanks!


[CIT-589] Fix the absence of grouping on increased maximum accepted message delay

Proposed fix:

The start of batch is the event time of its first event

Previously, the start a new batch was computed after the processing time
(reduced by the delivery_jitter aka the maximum accepted delay),
while the event time was used to add an event in a batch.

The first negative effect, was that the batch start date was not
deterministic but dependent of the processing time.
The main issue was that increasing the maximum accepted delay
was reducing the span of events that could be added to a batch.
Up to the point where each batch is formed only by its former point.

Now, the event time is used to define the span of a new batch and to
find a candidate batch for an event.

The processing time is no more used to define a batch, but just to
determine when there is no point to wait for more events.
Increasing the maximum delay has no impact on grouping,
but only on 1) the messages that are discarded because late
and 2) an augmented delay to emit batches.

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #478 (677a8f7) into main (d341793) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   62.50%   62.63%   +0.13%
==========================================
  Files         114      114
  Lines        7358     7376      +18
==========================================
+ Hits         4599     4620      +21
+ Misses       2759     2756       -3

Impacted Files
Coverage Δ

common/batcher/src/batcher.rs
93.84% <100.00%> (+0.68%)
:arrow_up:

sm/plugin_sm/src/plugin_manager.rs
45.37% <0.00%> (+1.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d341793...677a8f7. Read the comment docs.


Usage with Next.js Api Routes

Hi! I'm trying to render an email inside a Next.js api route.
My fine in /api/email.tsx looks something like:
import React from 'react'
import { Button } from '@react-email/button'
import { Html } from '@react-email/html'
import { render } from '@react-email/render'

export const runtime = 'edge'

function Component() {
  return (
    <Html>
      <Button
        pX={20}
        pY={12}
        href="https://example.com"
        style={{ background: '#000', color: '#fff' }}
      >
        Click me
      </Button>
    </Html>
  )
}

export default function test(request: Request) {
  const text = render(<Component />)
  return new Response(text)
}

I get this kind of error:

Is there anything I could do? I'd really like to render inside my current project.

I don't believe this will work as an Edge runtime. Can you use this as a regular API endpoint instead?
export const runtime = 'edge'

You were totally right. All seems to ber working well now! I'd be nice to be able to use it on the Edge runtime but I think that's a React/Vercel issue.

I don't believe this will work as an Edge runtime. Can you use this as a regular API endpoint instead?

I think I was just able to make it work using the edge runtime. I took the render function in @react-email/render which was nice and short, and replaced renderToStaticMarkup with renderToReadableStream.
Streaming itself is not actually important for email, and react-email had the two tweaks (doctype and pretty formatting), so I converted the stream back to a string and then I was able to use the whole thing in the Edge Runtime on Vercel, and https://wintercg.org/ would work in general.
I'm getting response times around 50-200ms depending on how warm it it is (first is a little slower). I think this would be interesting to have build in to react-email @zenorocha. What do you think?

@zenorocha
I just built a similar solution as @alvarlagerlof. My implementation checks if renderToStaticMarkup is defined. If not renderToReadableStream is used and the stream is converted to a string.
It would be nice to have something like this directly integrated in react-email, but it requires the introduction of an async function like renderAsync to work, so we are not introducing breaking change. I could create a pull request with my changes and add it to the docs if you are ok with creating a renderAsync function.

@zenorocha
I could create a pull request with my changes and add it to the docs if you are ok with creating a renderAsync function.

I just ran into this problem and it would be great to see your workaround and yes please make a PR.

I will create a PR this weekend, hope it gets attention. I'll reply here after I opened it.

PR filed at https://github.com/resendlabs/react-email/pull/603


GDScript: Fix implicit cast to typed array when passing parameter

Fixes #93990.

We should add a dedicated method in the future, since we often forget about typed arrays with Variant::construct().

Thanks!


[BUG] The latest master code doesn't work with pydantic 2.0a2

Describe the bug
when source build latest code on Ubuntu 18.04.3 LTS and run bert pruning sparse example in DeepSpeedExample, you will see crash.
from the log, it's because the code in deepspeed/runtime/config_utils.py was changed recently to use pydantic BaseModel.fields which doesn't exist in latest pydantic version.
To Reproduce

cd DeepSpeed
python setup.py install
cd DeepSpeedExamples/compression/bert
source ./bash_script/pruning_sparse.sh   # port number in sh file is wrong, need manual change.

Expected behavior
functionality work
Screenshots
/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/pydantic-2.0a2-py3.8.egg/pydantic/_internal/_config.py:230: UserWarning: Valid config keys have changed in V2:

'allow_population_by_field_name' has been renamed to 'populate_by_name'
'validate_all' has been renamed to 'validate_default'
warnings.warn(message, UserWarning)
Traceback (most recent call last):
File "run_glue_no_trainer.py", line 49, in
from huggingface_transformer.modeling_bert import BertForSequenceClassification
File "/home/wenhuach/DeepSpeedExamples/compression/bert/huggingface_transformer/modeling_bert.py", line 51, in
from transformers.modeling_utils import (
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/transformers/modeling_utils.py", line 37, in
from .deepspeed import deepspeed_config, is_deepspeed_zero3_enabled
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/transformers/deepspeed.py", line 38, in
from accelerate.utils.deepspeed import HfDeepSpeedConfig as DeepSpeedConfig
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/accelerate/init.py", line 7, in
from .accelerator import Accelerator
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/accelerate/accelerator.py", line 29, in
from .checkpointing import load_accelerator_state, load_custom_state, save_accelerator_state, save_custom_state
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/accelerate/checkpointing.py", line 24, in
from .utils import (
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/accelerate/utils/init.py", line 124, in
from .other import (
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/accelerate/utils/other.py", line 27, in
from deepspeed import DeepSpeedEngine
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/init.py", line 16, in
from . import module_inject
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/module_inject/init.py", line 6, in
from .replace_module import replace_transformer_layer, revert_transformer_layer, ReplaceWithTensorSlicing, GroupQuantizer, generic_injection
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/module_inject/replace_module.py", line 732, in
from ..pipe import PipelineModule
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/pipe/init.py", line 6, in
from ..runtime.pipe import PipelineModule, LayerSpec, TiedLayerSpec
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/pipe/init.py", line 6, in
from .module import PipelineModule, LayerSpec, TiedLayerSpec
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/pipe/module.py", line 19, in
from ..activation_checkpointing import checkpointing
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 25, in
from deepspeed.runtime.config import DeepSpeedConfig
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/config.py", line 28, in
from .zero.config import get_zero_config, ZeroStageEnum
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/zero/init.py", line 6, in
from .partition_parameters import ZeroParamType
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/zero/partition_parameters.py", line 601, in
class Init(InsertPostInitMethodToModuleSubClasses):
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/zero/partition_parameters.py", line 603, in Init
param_persistence_threshold = get_config_default(DeepSpeedZeroConfig, "param_persistence_threshold")
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/deepspeed-0.9.1+cc67f22f-py3.8.egg/deepspeed/runtime/config_utils.py", line 114, in get_config_default
assert field_name in config.fields, f"'{field_name}' is not a field in {config}"
AttributeError: type object 'DeepSpeedZeroConfig' has no attribute 'fields'
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 2220051) of binary: /home/wenhuach/anaconda3/envs/torch/bin/python
Traceback (most recent call last):
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/torch/distributed/launch.py", line 195, in
main()
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/torch/distributed/launch.py", line 191, in main
launch(args)
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/torch/distributed/launch.py", line 176, in launch
run(args)
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/torch/distributed/run.py", line 753, in run
elastic_launch(
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 132, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/wenhuach/anaconda3/envs/torch/lib/python3.8/site-packages/torch/distributed/launcher/api.py", line 246, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
============================================================
run_glue_no_trainer.py FAILED

System info (please complete the following information):

OS: Ubuntu 18.04
GPU: NV P40
Python version: 3.8

PS: after manually switch pydantic version from 2.0a2 to 1.10.7. the latest code works


getReferencingElements

To prevent dangling references caused e.g. by deletion of model elements they used to point to, the API should offer also the possibility to collect all elements referencing a particular target element.
This opens some further, related possibilities. E.g. when a synchronisation is being carried out via the rm-bridge, one could make the automatic deletions that happen during modification of the target model also explicitly visible in the changeset which is applied by the rm-bridge.
The implementation of this functionality depends on the internal representation and persistence of the model (e.g. a  graph DB) and may of course be changed over time.

I'm marking this as "model breaking", because this function is a prerequisite for cleaning up dangling references; not cleaning them up breaks a model.


Test if we can call psa_crypto::init.

The "system call" test_psa_crypto is added, in the same way that
fd_create was added, but it takes no arguments and just calls
psa_crypto::init.
rust-examples/linear-regression is modified so that it calls
that function.

It gets rejected by wasm-checker, of course!


Refine the Windows OS check

Hello,
I would like to propose a little refinement to Windows OS check. It seems that one of the possible values of PHP_OS constant could be Windows. Therefore, it might be better to convert its value to the uppercase before comparing.

Thanks!


fhir-path parser cannot parse datetime fractionalSeconds with more than 6 digits of precision

Describe the bug
When attempting to use a dateTime value with fractional seconds of more than 6 digits of precision in a FHIRPath expression, an exception is returned: com.ibm.fhir.path.exception.FHIRPathException: java.time.format.DateTimeParseException: Text '2012-04-15T15:00:00.000000000Z' could not be parsed, unparsed text found at index 26
To Reproduce
Steps to reproduce the behavior:

use a dateTime value with a fractional seconds precision of more than 6 digits in a FHIRPath expression

Expected behavior
In order to be consistent with parsing of dateTime and instant fields on object creation (see issue #1446), and date values in search queries (see issue #1505), up to 9 digits of precision should be allowed for fractional seconds in FHIRPath dateTime values,  and should be truncated to 6 digits of precision when evaluating the FHIRPath expression.
Additional context
Add any other context about the problem here.

Unit test coverage looks good.


Mei export Updates

This PR solves some relatively important issues that were overlooked with MEI export.

Added important support for dotted notes.
Added Cadence Class and visualization in the export.
Added support for Beams in MusicXML which will nicely visualize and export beams in MEI.
Added support for barlines, title and fermata
Added a function to infer beams
Updated rest infilling.
Added support for cross-staff beaming.

Thank you.

Codecov Report
Attention: Patch coverage is 31.40794% with 190 lines in your changes are missing coverage. Please review.

Project coverage is 84.11%. Comparing base (018f264) to head (13298b7).
Report is 1 commits behind head on develop.

Files
Patch %
Lines

partitura/score.py
8.33%
143 Missing :warning:

partitura/io/exportmei.py
52.12%
45 Missing :warning:

partitura/io/importmusicxml.py
95.83%
1 Missing :warning:

partitura/utils/music.py
66.66%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
- Coverage    84.96%   84.11%   -0.86%
===========================================
  Files           82       82
  Lines        14236    14497     +261
===========================================
+ Hits         12096    12194      +98
- Misses        2140     2303     +163

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cherry-pick from master: Ensure wheels experiment control and experiment groups uses correct debugger

Codecov Report

Merging #8546 into release-2019.11 will increase coverage by 0.01%.
The diff coverage is 57.14%.

@@                 Coverage Diff                 @@
##           release-2019.11    #8546      +/-   ##
===================================================
+ Coverage            59.46%   59.47%   +0.01%
===================================================
  Files                  509      509
  Lines                23390    23397       +7
  Branches              3779     3780       +1
===================================================
+ Hits                 13909    13916       +7
- Misses                8575     8576       +1
+ Partials               906      905       -1

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
87.12% <ø> (+0.99%)
:arrow_up:

src/client/telemetry/constants.ts
100% <100%> (ø)
:arrow_up:

src/client/datascience/jupyter/jupyterDebugger.ts
10.47% <11.11%> (ø)
:arrow_up:

src/client/debugger/extension/adapter/factory.ts
92.98% <90.9%> (-1.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a689a3...2e4721a. Read the comment docs.


let g:Lf_CursorBlink=0 breaks  and

vim or neovim?

[x] vim
[ ] neovim

Output of vim --version or nvim --version:

VIM - Vi IMproved 8.1 (2018 May 18, compiled May 18 2018 18:36:07)
MS-Windows 32-bit GUI version with OLE support
Included patches: 1
Compiled by mool@tororo
Huge version with GUI.  Features included (+) or not (-):

Output of :echo has("python"): 0

Output of :echo has("python3"): 1

Operating system:

[ ] Linux
[ ] Mac OS X
[x] Windows
[ ] Etc.

Configurations related to LeaderF in vimrc:

let mapleader=' '
call plug#begin('~/vimfiles/plugins')
Plug 'Yggdroot/LeaderF'
call plug#end()
let g:Lf_CursorBlink=0

When using the above minimal vimrc file, which sets the variable g:Lf_CursorBlink to 0. <C-J> and <C-K> mappings stop working completely when trying to scroll the LeaderF output.

Are you using the latest version of LeaderF?

I was not... I updated to the latest version and it's working correctly now.


Rust language support added.

With help from @schani.
Preview in browser

Please generate comments at the top of the output that explain how to read models from JSON.

@krk Please see my fixes in https://github.com/quicktype/quicktype/commits/rust

Thanks for the fixes.

Will someone give this the rust label for completeness, please?


Question for ScanRefer benchmark, not Scan2cap

Dear authors,
I am wondering why the paper is said that Vote2Cap is tested on ScanRefer, not Scan2cap benchmark.
As long as I understand, ScanRefer takes pointclouds with a text query as inputs and finds the referred unique 3D box.
On the other hands, Scan2Cap takes only pointclouds input and estimate 3D boxes with descriptions.
I think Vote2Cap is conducted for the task like Scan2Cap, but in your paper it is written to be evaluated on ScanRefer.
Did you also conduct your model on ScanRefer benchmark test? If so, can you share how it works as ScanRefer task requires two inputs, the pointcloud scenes and query. If it was actually tested on Scan2Cap, is there any method to test your mode on ScanRefer?
Thanks for your help in advance!

Would you mind suggesting how to make the modification to work for 3D visual grounding task on ScanRefer dataset? It seems working very well on the 3D grounding task well.

You can choose to 1) match the generated instance caption with the querying sentences, or 2) match the generated bounding box feature with the querying sentences like existing 3DVG models.


Improve CI and include coverage data

Replaces #295. The only differences are:

this PR is from a branch within the QCHacker group (and not on the nelimee/tqec fork),
the last 3 commits are removed.

Adding a message to PRs require write permission to that PR, which is only given when the branch to be merged is from the same repository as the base branch (here, QCHackers/tqec). Trying to circumvent that with workflow_run seems too complex for such a low-priority issue, so let's live with that restriction for the moment.
TLDR: PRs from branches in any repository other than QCHackers/tqec will fail the CI job about coverage, this is "expected" and is not a code issue but rather a GitHub permission issue.

TLDR: PRs from branches in any repository other than QCHackers/tqec will fail the CI job about coverage, this is "expected" and is not a code issue but rather a GitHub permission issue.

Does this mean that from now on, contributors on should work on branches from the QCHackers group instead of their own forks? If so, may implicate step 4 of the contributions file


Bind  only id to model

How  bind with [(ngModel)]  only the id of item not the object item tha contains id and itemName??
One option is on callback method getting the id of item selected but  I have many dropdowns and is not profitable to do that. There is a config option to bind only id?

always return object only.


move to external react-transition-group dependency

Per https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html:

react-addons-css-transition-group - Use react-transition-group/CSSTransitionGroup instead. Version 1.1.1 provides a drop-in replacement.

Please review the webpack.base.config.js changes whether it needs changes.

Would love to know if anyone is using that patch already?

Yes, I tested it, but I use Rollup, so I can't speak for the Webpack changes. It works fine otherwise. Would love to see this merged soon, currently a blocker for upgrading to latest React.

@eddywashere Hi there, could you please give us an update? Thank you

Please merge this PR ASAP. The deprecated dependencies are no longer installing and it's breaking our app.
Thanks,

@samrod that is not how deprecations work.

Any status updates regarding this PR?

.oO( time to fork )

This PR messed up the Rollup config, bumping the file size from 95kB to 335kB. Reported the issue as #472.
I have opened a PR with a fix in #474.


Allow deploy to work when there are no changes to the main branch

Testing this is change is a bit tricky and kind of self referential.  To test it, I created a separate file script/test_deploy.h in my local repo and commented out most of the rest of the script other than this specific logic.
This should let you see if a change on your local on the main branch gets stashed and restored.  It should should work with or without other stashed changes.
The other important case is when there is a conflict between what you have locally and what's on the target branch.  To test this make sure the check for main at the top of the script is commented out.
Then create a temporary branch that you push to GitHub.
In your usual local repo make a change that you don't check in.
Make a fresh clone of the GitHub repo in another directory and make a change that conflicts with the one you just made and push that to GitHub.
Now run the script from your usual repo.  It should fail when it tries to pop the stashed change with a conflict message.
Hopefully that's reasonably clear and paves the way for us to not require that there be differences between the main branch and what's on the server for the files that are managed by git.

😵💫
Trust you on this one...
Curious though, what are the differences between main and what's on production currently? I remember there being some, but i just ran git stash list y no hay nada.

@nimmolo AFAIK, the only potential difference is the banner, which is now in sync because @mo-nathan fixed it.

Actually at the moment the banner has to be different.  Otherwise the deploy script will fail.  Hence this PR.  At the moemnt:
mo@mushroomobserver:/var/web/mo$ git diff
diff --git a/config/locales/en.txt b/config/locales/en.txt
index 71b746b5a..f65d72b9f 100644
--- a/config/locales/en.txt
+++ b/config/locales/en.txt
@@ -1301,7 +1301,7 @@
   app_title: Mushroom Observer

   # This goes in a box at the top of the page.
-  app_banner_box: "Check out the \"Mushroom Observer Etsy store\":https://www.etsy.com/shop/MushroomObsMerch — T-shirts, bags and swag!
\nWe're working on MO. If you have trouble posting, try logging out and logging back in again.
\nPlease \"report a bug\":https://mushroomobserver.org/emails/ask_webmaster_question if you find one."
+  app_banner_box: "Checkout \"Project Field Slips\":https://mushroomobserver.org/articles/37!
\nPlease \"report a bug\":https://mushroomobserver.org/admin/emails/webmaster_questions/new if you see one."

   # These are the controls/links in the left-hand panel.
   app_intro: Introduction
@@ -1579,7 +1579,6 @@
   form_locations_species_help: List the common, rare, or otherwise interesting species found here.
   form_locations_notes_help: Enter notes that are specific to this particular location.  For example, whether it is private or public, whether permits are required, driving directions, etc.
   form_locations_dubious_help: Submit again to use this location name or edit the text below to correct any typo.
-
   # names/_form_name
   form_names_locked: Lock this name so users cannot change name, author or rank?
   form_names_detailed_help: For detailed help see Names in Mushroom Observer.


Win10 create machine not work, and give me execptions

https://stackoverflow.com/questions/75890104/virtualbox-api-ivirtualboxcreatemachine-causing-exceptions
ENVIRONMENT
Virtualbox
SDK
pywin32 306
vboxapi 1.0
virtualbox 2.1.1

Operating System:  Windows 10
Python version: 3.11
VirtualBox version: 7.0.8
VirtualBox SDK version: 7.0.8 installed
Location where VirtualBox SDK is installed: C:\Program Files\Oracle\VirtualBox\sdk
virtualbox-python / pyvbox version: 2.1.1
[ ] Happens in latest master branch?

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

I no longer have time to maintain this library, so am closing this issue.

The virtual box API version 7.0 doesn't work with python 3.11.0. It only supports 3.10 version so you should switch back to that version and try again.

Unfortunately, the "createMachine" interface has changed from VirtualBox 6 to 7.
This Repo was made for the Version vbox_version = "6.1.16" as written in virtualbox/library.py.

@0nelight I have been testing each method to see which one's are broken. I will take a look at createMachine method too.


Revert "Update ThemeToggle.astro"

Reverts froehners/twenty23#7

👷 Deploy Preview for famous-marshmallow-cfbd61 processing.

Name
Link

🔨 Latest commit
8b499591d1690b60301f2284bf41be691d2c2f90

🔍 Latest deploy log
https://app.netlify.com/sites/famous-marshmallow-cfbd61/deploys/64a48286afba7c0008335187


Connecting to a navidrome server with Album art rate limiting makes the application completely unusable

Describe the bug
When I connect to my Navidrome instance, which has a lot of songs, after a few seconds the rate limiting kicks in and causes errors in the requests, which shows an alert for each request and makes the application completely unusable.
Navidrome introduced rate limiting because of performance and rate limiting issues on external APIs, when too much album images are requested, see https://github.com/navidrome/navidrome/issues/2130 and related settings https://github.com/navidrome/navidrome/blob/bcab3cc0f908a01ebb99f9f6d0bfb37fadbd95bf/conf/configuration.go#L86-L88.
The rate limiting is enabled by default.
To Reproduce
Steps to reproduce the behavior:

Connect to a navidrome instance with a lot of songs and rate limiting enabled
Wait a few seconds
See error

Expected behavior
Application should still be usable, and respect the rate limiting (if possible). Maybe the 429s can just be ignored for now.
Screenshots
https://github.com/SubmarinerApp/Submariner/assets/292363/403b0998-104f-4e2d-9167-16cec8a631ce
Versions:

macOS [e.g. 13.5]: 14.0
Subsonic Server and Version [e.g. Navidrome 0.44, Subsonic 6.1.6]: Navidrome 0.49.3
Submariner Version [e.g. 2.2]: 2.4.2
Download Source [e.g. Mac App Store]: homebrew

Additional context
Add any other context about the problem here.

I have a preliminary patch for this:
diff --git a/Submariner/SBClientController.swift b/Submariner/SBClientController.swift
index 596b80c..20f3616 100644
--- a/Submariner/SBClientController.swift
+++ b/Submariner/SBClientController.swift
@@ -49,6 +49,29 @@ fileprivate let logger = Logger(subsystem: Bundle.main.bundleIdentifier!, catego
                 if response.statusCode == 404 {
                     self.server.markNotSupported(feature: type)
                     return
+                } else if response.statusCode == 429 {
+                    // Newer versions of Navidrome back getCoverArt w/ third-party APIs.
+                    // As such, it rate limits API requests that can invoke them.
+                    // Instead of bothering the user, retry the request later.
+
+                    // Retry-After is seconds or a specific date
+                    let retryAfter = response.value(forHTTPHeaderField: "Retry-After")
+                    logger.info("Retrying w/ Retry-After value \(retryAfter ?? "<nil>")")
+
+                    if let retryAfter = retryAfter,
+                       let specificDate = retryAfter.dateTimeFromHTTP() {
+                        _ = Timer(fire: specificDate, interval: 0, repeats: false) { timer in
+                            self.request(url: url, type: type, customization: customization)
+                            timer.invalidate()
+                        }
+                    } else if let retryAfter = retryAfter {
+                        let seconds = TimeInterval(retryAfter) ?? 5
+                        _ = Timer(timeInterval: seconds, repeats: false) { timer in
+                            self.request(url: url, type: type, customization: customization)
+                            timer.invalidate()
+                        }
+                    }
+                    return
                 } else if response.statusCode != 200 {
                     let message = "HTTP \(response.statusCode) for \(url.path)"
                     let userInfo = [NSLocalizedDescriptionKey: message]
diff --git a/Submariner/String+Time.swift b/Submariner/String+Time.swift
index 3544ea1..9653767 100644
--- a/Submariner/String+Time.swift
+++ b/Submariner/String+Time.swift
@@ -18,6 +18,13 @@ extension String {
         formatter.locale = Locale(identifier: "en_US_POSIX")
         return formatter
     }()
+    fileprivate static let httpDateFormatter: DateFormatter = {
+        let formatter = DateFormatter()
+        formatter.dateFormat = "EEE', 'dd' 'MMM' 'yyyy' 'hh:mm:ss' GMT'"
+        formatter.timeZone = TimeZone(secondsFromGMT: 0)
+        formatter.locale = Locale(identifier: "en_US_POSIX")
+        return formatter
+    }()

     static let componentFormatter: DateComponentsFormatter = {
         let formatter = DateComponentsFormatter()
@@ -34,6 +41,10 @@ extension String {
         return String.rfc3339DateFormatter.date(from: self as String)
     }

+    func dateTimeFromHTTP() -> Date? {
+        return String.httpDateFormatter.date(from: self)
+    }
+
     init(timeInterval: TimeInterval) {
         if timeInterval == 0 || timeInterval.isNaN {
             self = "00:00"

If you want, I can provide a binary build of this against the current development snapshot for you to test.

Hey @NattyNarwhal,
Thanks for the ultra fast reply!
Yes the patch works, I tested it and the 429 dialog is not appearing anymore.
However I believe the core problem is that I have a playlist with 3000 tracks. It seems like the app is trying to download the metadata for all the songs in the playlist at once. Then the server gets overwhelmed with requests, some are rejected with the 429, but the other still cause the server to be overloaded. A bunch of requests then are hitting the timeout and for those I'm seeing a "Request timed out" dialog.
Because of these many requests to the server, it is not possible to start playing a song.
e.g.:
	API endpoint /rest/getCoverArt.view
Task <4533726C-C078-4698-9D01-5BF93C0BD2A9>.<1> finished with error [18.446.744.073.709.550.615] Error Domain=NSURLErrorDomain Code=-1001 "The request timed out." UserInfo={_kCFStreamErrorCodeKey=-2102, NSUnderlyingError=0x60000d0967f0 {Error Domain=kCFErrorDomainCFNetwork Code=-1001 "(null)" UserInfo={_kCFStreamErrorCodeKey=-2102, _kCFStreamErrorDomainKey=4}}, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <4533726C-C078-4698-9D01-5BF93C0BD2A9>.<1>, _NSURLErrorRelatedURLSessionTaskErrorKey=(
    "LocalDataTask <4533726C-C078-4698-9D01-5BF93C0BD2A9>.<1>"
), NSLocalizedDescription=The request timed out., NSErrorFailingURLStringKey=http://raspberrypi:4533/rest/getCoverArt.view?t=XX&s=XX&id=mf-XX&v=1.15.0&c=submariner&u=lukas, NSErrorFailingURLKey=http://raspberrypi:4533/rest/getCoverArt.view?t=XX&s=XX&id=mf-XX&v=1.15.0&c=submariner&u=lukas, _kCFStreamErrorDomainKey=4}
Handling URL http://raspberrypi:4533/rest/getCoverArt.view?t=XX&s=XX&id=mf-XX&v=1.15.0&c=submariner&u=lukas
	API endpoint /rest/getCoverArt.view

Maybe the solution is to only download the metadata for the songs which are currently visible in the list?

This quickfix makes the problem disappear (i.e. avoiding to fetch album covers for every song in the playlist):
diff --git a/Submariner/SBSubsonicParsingOperation.swift b/Submariner/SBSubsonicParsingOperation.swift
index aca281a..6d78522 100644
--- a/Submariner/SBSubsonicParsingOperation.swift
+++ b/Submariner/SBSubsonicParsingOperation.swift
@@ -397,7 +397,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                 } ?? false
                 logger.info("Adding track (and updating) with ID: \(id, privacy: .public) to playlist \(currentPlaylist.itemId ?? "(no ID?)", privacy: .public), exists? \(exists) index? \(self.playlistIndex)")

-                updateTrackDependenciesForDirectoryIndex(track, attributeDict: attributeDict)
+                updateTrackDependenciesForDirectoryIndex(track, attributeDict: attributeDict, shouldFetchAlbumArt: false)

                 // limitation if the same track exists twice
                 track.playlistIndex = NSNumber(value: playlistIndex)
@@ -412,7 +412,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                 // FIXME: Should we update *existing* tracks regardless? For previous cases they were pulled anew...
                 logger.info("Creating new track with ID: \(id, privacy: .public) for playlist \(currentPlaylist.itemId ?? "(no ID?)", privacy: .public)")
                 let track = createTrack(attributes: attributeDict)
-                updateTrackDependenciesForDirectoryIndex(track, attributeDict: attributeDict)
+                updateTrackDependenciesForDirectoryIndex(track, attributeDict: attributeDict, shouldFetchAlbumArt: false)

                 track.playlistIndex = NSNumber(value: playlistIndex)
                 playlistIndex += 1
@@ -884,7 +884,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
     }

     // not as good as former, but we have to use it until we switch to using tag based metadata instead of hierarchy index
-    private func updateTrackDependenciesForDirectoryIndex(_ track: SBTrack, attributeDict: [String: String]) {
+    private func updateTrackDependenciesForDirectoryIndex(_ track: SBTrack, attributeDict: [String: String], shouldFetchAlbumArt: Bool = true) {
         var attachedAlbum: SBAlbum?
         var attachedCover: SBCover?
         var attachedArtist: SBArtist?
@@ -925,7 +925,9 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                 attachedAlbum.cover = attachedCover!
             }

-            clientController.getCover(id: coverID)
+            if shouldFetchAlbumArt {
+                clientController.getCover(id: coverID)
+            }
         }

That works; it might also be a good idea to also perhaps batch the requests for album/artist/cover by ID and do it at the end. Since they spawn a new operation regardless of when it's called, I don't think it would affect the logic in the code.

Something like:
diff --git a/Submariner/SBSubsonicParsingOperation.swift b/Submariner/SBSubsonicParsingOperation.swift
index aca281a..19fd404 100644
--- a/Submariner/SBSubsonicParsingOperation.swift
+++ b/Submariner/SBSubsonicParsingOperation.swift
@@ -86,6 +86,9 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
     var currentAlbumID: String?
     var currentCoverID: String?

+    // used to batch requests, i.e. covers in a playlist
+    var getCoverIDs = Set<String>()
+
     init!(managedObjectContext mainContext: NSManagedObjectContext!,
           client: SBClientController,
           requestType: RequestType,
@@ -287,7 +290,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                (cover.imagePath == nil || !FileManager.default.fileExists(atPath: cover.imagePath! as String)) {
                 // file doesn't exist, fetch it
                 logger.info("Fetching file for cover with ID: \(coverID, privacy: .public)")
-                clientController.getCover(id: coverID)
+                getCoverIDs.insert(coverID)
             }
         }
     }
@@ -361,7 +364,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                 }

                 if album?.cover?.imagePath == nil {
-                    clientController.getCover(id: coverArt)
+                    getCoverIDs.insert(coverArt)
                 }
             }
         }
@@ -627,6 +630,9 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
         threadedContext.processPendingChanges()
         saveThreadedContext()

+        // submit further requests. since they run in their own context, it doesn't matter that we submit after updating Core Data
+        getCoverIDs.forEach { self.clientController.getCover(id: $0) }
+
         if requestType == .ping && !errored {
             postServerNotification(.SBSubsonicConnectionSucceeded)
         } else if requestType == .updatePlaylist {
@@ -874,7 +880,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                 attachedAlbum.cover = attachedCover!
             }

-            clientController.getCover(id: coverID)
+            getCoverIDs.insert(coverID)
         }

         if let attachedAlbum = attachedAlbum {
@@ -925,7 +931,7 @@ class SBSubsonicParsingOperation: SBOperation, XMLParserDelegate {
                 attachedAlbum.cover = attachedCover!
             }

-            clientController.getCover(id: coverID)
+            getCoverIDs.insert(coverID)
         }

         if let attachedAlbum = attachedAlbum, let artistName = attributeDict["artist"] {

Unfortunately, I think Navidrome provides a separate cover ID for each track, so this doesn't actually save anything over your solution.

I've applied your patch and merged it.


Recommended usage is impossible to satisfy

The recommended usage section in the README states the following:

Your library MAY provide a feature that will enable "allocator-api2/nightly". When this feature is enabled, your library MUST enable unstable #![feature(allocator_api)] or it may not compile.

This is impossible because of feature unification. Consider there are two crates a and b that depend on allocator-api2. a does not enable the nightly feature, b does. Now a project that contains both a and b will fail to compile, as b turning on the feature flag will also turn it on for a, but a does not contain #![feature(allocator_api)].
This does actually happen in the real world in a large complicated project which ends up depending on hashbrown twice: https://github.com/rust-lang/hashbrown/issues/564. But as more and more crates start using allocator-api2 you don't even need such a complicated scenario.

It is easy to satisfy really. Just provide nightly feature if you depend on allocator-api2.
Then in case of large project stumbled on that library being added as dependency without enabling "nightly", large project can add that library as dependency and enable "nightly".

Yes, but can be fixed in root crate

The root crate does not depend on c, and should not need to care about it or whatever feature flags it uses.
It's just not a reasonable system. Suppose allocator-api2 takes off in popularity and all data structure crates start using it. A root binary crate now might have to add dozens of nightly feature flag propagations for all kinds of dependencies of dependencies (or even further down the dependency chain) that it truly does not care about.

Yes, but only if they want to build on nightly and enable "nightly" features in at least some of their dependencies that reaches allocator-api2.
I would love to enable lang features based on features enabled in dependency alone. Without special feature enabled for the crate.
Unfortunately it doesn't work like that.
So enabling "nightly" in transitive dependencies root crate doesn't care about is the lesser evil.
Other solutions I found are worse.


OS_SymbolLookup Function Prototype Variable Names Do Not Match Implementation

The OS_SymbolLookup function prototype (in osapi-os-loader.h) defines the prototype to be:
int32 OS_SymbolLookup (cpuaddr *symbol_address, const char *symbol_name );
While the implementations of this function declares the function with variable names that do not match the prototype:
int32 OS_SymbolLookup( cpuaddr *SymbolAddress, const char *SymbolName )
This could result in compiler errors/warnings on certain platforms.  It is recommended to update the prototype variable names to match the implementations.

Imported from trac issue 162.  Created by sstrege on 2016-03-10T12:21:00, last modified: 2019-04-23T15:45:34

Trac comment by cdknight on 2018-07-24 13:57:19:
CCB determined this is not worth working.


Some updates for vtt parser

I don't know if this is still active, I needed some changes, maybe there will be more, so I thought why not publish them to the original repo too.
Async is really a necessity because we can have big vtts, and there are other improvements that can be made with modern practices too. We'll see.

I left the async method in the interface still commented because it wouldn't make much sense to have all the other parsers throw NotImplementedException, but still it was needed. Also I didn't merge async and sync implementations in one, async could be used for sync, atm I didn't feel like it.

Thank you for your contribution.
Indeed, async methods are a great to the parsers as the operations can take quite a long time on certain subtitle files. I'm in line with your choices and, indeed, the ideal in the future would be for all parser to implement the async method.
That will be for another release ;)


Adds failure as the recommended way to express a blocking error in a Dangerfile

I ended up adding a dangerfile to one of our ruby apps, and obviously this was the right fit https://github.com/artsy/exchange/pull/168 - but the default rubocop settings don't want you writing fail.
I originally aliased raise - like mentioned in https://github.com/danger/danger/issues/1006 but it didn't feel right, so I chatted with @yuki24 added failure as an option, and made it the default in all the docs.

( This doesn't break anything, so I'm shipping it as a patch 💯 )


MS/MS spectral networking

Basic information

My operating system: macOS Ventura 13.3.1
My MZmine version: 3.3.0 and 3.4.27

What happened
I am processing MS2 data, and I would like to know if MZmine can group aligned feature list based on cosine similarity. It seems to me that MS/MS spectral networking (Molecular networking) module should do the trick, but eventually, I do not understand how it works and what is the output. I also haven't found any documentation or tutorials for this module.
Below are the parameters I use. The task is running, but I cannot spot any difference before and after.

Technically, I can export data to GNPS and proceed there, however, my goal is the only list of grouped peaks with cosine similarity score, and GNPS is a bit of an overkill, so it would be great to use that feature in MZmine.
Thanks for the help!!

We are still working on this feature. The visualizer is broken at the moment but there is a feature list exportmodule that exports all the network to graphml


Canvases rendering error when width is too high

Bug description
Same bug as mentionned in this issue :
https://github.com/katspaugh/wavesurfer.js/issues/3682
When the Wavesurfer container is given a too large width (ie: +80000), only one canvas is rendered with this width instead of multiple canvas of MAX_CANVAS_WIDTHpx, resulting in an error
This bug was fixed in 7.7.12 but seems to be present again in 7.8.2
Environment

Browser: Chrome

Minimal code snippet
const options = {
  container: 'body',
  height: 128,
  width: 80000,
  normalize: false,
  waveColor: '#ff4e00',
  progressColor: '#dd5e98',
  cursorColor: '#ddd5e9',
  cursorWidth: 2,
  url: '/examples/audio/audio.wav',
  mediaControls: true,
  sampleRate: 8000,
}

const wavesurfer = WaveSurfer.create(options)

Expected result
Multiple canvas of smaller width

Obtained result
Single canvas width huge width, resulting in display error

Screenshots

Thanks for the report!


AWS: Make a SCP Sandbox Account

Might be nice for testing and classes to make a SCP Sandbox account that has hard limits on spending/resources.

This is done :)


Inner declaration missing for a recursive function value in a module

(This is quite possibly related to https://github.com/fsharp/FSharp.Compiler.Service/issues/495 if the problem is around module-level function values.)
This small snippet:
let rec badLoop =
    () // so that it is a function value
    fun x -> badLoop (x + 1)

is reported by FCS as let badLoop = badLoop@4.Force(()), but the declaration for badLoop@4 is not present inside the FSharpImplementationFileContents.Declarations list.

Nice find :)

I checked this and it seems the item is present in the Declarations - at least it is now.  It is marked CompilerGenerated so you have to be careful that you are not skipping those

@dsyme Thanks for the update.
Tested it now (at commit 5a87eb9), still the exposed members are not usable enough for translation:

On generated members, both EnclosingEntity and LogicalEnclosingEntity are throwing an exception, making it ambigous which module contains them.
The recursive reference is exposed as a Value x pattern, not a Call, where x.IsModuleValueOrMember returns false, so it seems like a local variable where it is not.

@Jand42  Ah ok, thanks


Override or disable pluralization of table names?

Is there a way to disable pluralization for all tables aside from overriding the urlForFindAll individually for each adapter? I've been searching for a while now but can't find an easy way to do it. Any help would be appreciated. Thanks.

I was pretty sure I tried all methods on type yesterday. This works, thank you.


Story: registry can be used to dogfood wasm-tools (componentized)

This is a story issue to track the overall progress towards achieving a user story.
Task issues will be track here soon.

Cleaning up old issues


added functions for rotating and reversing array in parts

New function name- array_rotate and array_reverse_part
Short Description

array_rotate function can rotate array in counter clockwise direction (left) by given number of steps
array_reverse_part function can reverse specific part of the array like last two element or any subarray

References (documentation, links, etc.)

I took this idea from a GFG question or rotating array

Limitations (If it has any edge cases)

Currently this function is only applicable to array having scalar values. for objects like element I think I need to implement deep copy to prevent mutating original array.

this is for issue #15

Please review the PR.

I will soon be reviewing all the PRs(Probably by the end of coming Saturday and Sunday). Sorry for the wait.


librepo: enable zchunk support on darwin

Motivation for this change
Thanks to @nima2007 's work in https://github.com/NixOS/nixpkgs/pull/107443, we can now enable zchunk support on Darwin as well
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107972 run on x86_64-linux 1

Result of nixpkgs-review pr 107972 run on x86_64-darwin 1

6 packages built:

libdnf
librepo
microdnf
python37Packages.librepo
python38Packages.librepo
python39Packages.librepo


Service not printing on windows 10

when running it as service on windows 10. it doesn't print anything. but when debugging it in visual studio it works well

Does it work when you run it from the console (start the exe with the flag --console) ?
If it runs as a service, the user the service runs under must have printers installed (Windows links printers to users IIRC). It can help to use a service account instead of Network Service or Local System.

Does it work when you run it from the console (start the exe with the flag --console) ?
If it runs as a service, the user the service runs under must have printers installed (Windows links printers to users IIRC). It can help to use a service account instead of Network Service or Local System.

Yes it works when running as console application but it is not working while running as a service ,,, according to the microsoft docs the PrintDocument is based on WinForms and i think windows service dont have the rights to print documents

Is any solution found about this issue?
Printing from service is not possible. Any workaround for this problem?

Yes it works when running as console application but it is not working while running as a service ,,, according to the microsoft docs the PrintDocument is based on WinForms and i think windows service dont have the rights to print documents

I was able to print using service.
I will contribute the code for this fix
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: yiwan74 @.>
Sent: Sunday, May 1, 2022 8:01:27 PM
To: huysentruitw/print-it @.>
Cc: Saad Yasir @.>; Author @.>
Subject: Re: [huysentruitw/print-it] Service not printing on windows 10 (#12)
Is any solution found about this issue?
Printing from service is not possible. Any workaround for this problem?
Yes it works when running as console application but it is not working while running as a service ,,, according to the microsoft docs the PrintDocument is based on WinForms and i think windows service dont have the rights to print documents
—
Reply to this email directly, view it on GitHubhttps://github.com/huysentruitw/print-it/issues/12#issuecomment-1114258603, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6UE62NCMQACOA3T3LSC3DVH2MEPANCNFSM47NZL7CA.
You are receiving this because you authored the thread.Message ID: @.***>

Yes. You are right. It can print from service.
I was trying to print from service on printer that was redirected through remote desktop.
In that case it prints only when started with Visual Studio.
But when I used local network printer it prints well from service too.


Please restart recent builds

The latest builds after PR merge had timeout failures (possibly CI issues). Would one of the maintainers mind hitting restart on the CI? See here: https://github.com/conda-forge/qgis-feedstock/runs/34293501292

Just did. Fingers crossed.

Done I think. Reopen this if you are still having trouble...


Run-time error '458' in Windows Excel 2016 64bit

I get an error when trying to retrieve values. (See the colored line on the screenshot)

The code works fine in Excel 2016 32bit.
I am using Windows, not a Mac and I've allready installed the latest version: VBA-JSON v2.2.4
My Json string looks like this:
{     "rows": [         {             "object": {                 "id": "123",                 "label": "TEST",                 "entityId": 1             },             "values": [                 "12345678",                 "TEST"             ]         }     ] }
Am I doing something wrong?

I'm not entirely sure, but it may be from lack of a type on json_Row. If you explicitly define Dim json_Row As Dictionary do you still get the error?

Hi Tim,
I didn't see that one coming. :) That was the problem.
Thank you for the solution!


feat(Data/Set/Lattice, Order/Filter/Basic): more lemmas about kernImage and filter analog

Co-authored-by: Junyan Xu<EMAIL_ADDRESS>@alreadydone
This was originally discussed on Zulip, and Junyan made most of the work in this message. I just changed some proofs to use a bit more Galois connections.
This is a bit of a gadget but it does simplify the proof of comap_iSup, and it will also be convenient to define the space of functions with support a compact subset of a fixed set. See this message for more details.

bors merge


Bootstrap resampling for correlation matrices

When we create a network for a cohort of participants we can't meaningfully interpret graph measures if they change dramatically when the selection of participants is slightly altered. :8ball:
We want to use bootstrap resampling to measure how much our graph measures change under perturbations to the group of participants.
When we implement this it should be done at the point of creation of correlation matrices. We will then perform the same analyses on the bootstrapped matrices as we would on the original.
:sparkles:
I'm not sure what resources there are for bootstrap resampling in python- Please comment if you do! :star2:

@KirstieJane Here's what I wrote about bootstrap resampling. I don't know if you can directly edit my comments, but if not, you can comment below and I'll copy paste :cherry_blossom:


Unable to connect

The search for stations is done normally but it is very rare that I manage to connect to them. 9 times out of 10 I get the message that is attached to all my phones on the dev channel: OPO, BQ E5 HD, NEXUS 5. Is this normal at the current stage of development of the application ?

I am afraid it is problem with the SHOUTcast servers. Sometimes the search results indeed cause this error and sometimes repeating the same query results in working links.
If you think it is an isue with the code of the app you can take a look at the log file:
 .cache/upstart/application-click-shoutcast-ubports.wdehoog_shoutcast-ubports_0.4.log.

Thank you for your answer. I'm not a developer, so there's nothing I can do. But having by interest looked at the log, everything indicates that some elements probably need to be updated. I see  'Binding loop detected for property "height", 'caller' is deprecated..
I can't interpret that.
De : Willem-Jan de Hoog<EMAIL_ADDRESS>À : wdehoog/shoutcast-ubports<EMAIL_ADDRESS>Sujet : Re: [wdehoog/shoutcast-ubports] Unable to connect (#10)
Date : 27/03/2020 21:22:47 Europe/Paris
Copie à : gbdomubpkm<EMAIL_ADDRESS>   Author<EMAIL_ADDRESS>I am afraid it is problem with the SHOUTcast servers. Sometimes the search results indeed cause this error and sometimes repeating the same query results in working links.
If you think it is an isue with the code of the app you can take a look at the log file:
.cache/upstart/application-click-shoutcast-ubports.wdehoog_shoutcast-ubports_0.4.log.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

The 'Binding loop ...' error is not a real problem (some qml related thing). The app will work even with this error in the log.
If possible you can past the log in some pastebin site or attach it here so I can take a look.
You can also look at the logs while using the app:
tail -f .cache/upstart/application-click-shoutcast-ubports.wdehoog_shoutcast-ubports_0.4.log

maybe you can spot some pattern or try the urls shown in the log in a browser.

https://paste.ubuntu.com/p/7TP337XdT4/
De : Willem-Jan de Hoog<EMAIL_ADDRESS>À : wdehoog/shoutcast-ubports<EMAIL_ADDRESS>Sujet : Re: [wdehoog/shoutcast-ubports] Unable to connect (#10)
Date : 27/03/2020 22:41:05 Europe/Paris
Copie à : gbdomubpkm<EMAIL_ADDRESS>   Author<EMAIL_ADDRESS>The 'Binding loop ...' error is not a real problem (some qml related thing). The app will work even with this error in the log.
If possible you can past the log in some pastebin site or attach it here so I can take a look.
You can also look at the logs while using the app:
tail -f .cache/upstart/application-click-shoutcast-ubports.wdehoog_shoutcast-ubports_0.4.log
maybe you can spot some pattern or try the urls shown in the log in a browser.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for the log. This url fails: http://yp.shoutcast.com/sbin/tunein-station.m3u?id=1674844.
If you try it in browser you get a file containing:
#EXTM3U

nothing more. It is an empty playlist. Normally this file contains some stream urls. So SHOUTcast sends an empty list and there is nothing the app can do to fix this.

Sorry i don't understand. Why SHOUTcast sends an empty list for some stations ? Stations that don't work in shoutcast are well functional because they work outside of Shoutcast..

Well I guess it is a bug in their system. Either they return stations for which they don't have the stream urls or they return the wrong id.
Is there any particular station you tried?

No. I look for a singer and then I choose a piece of music from it that is associated with a station.
But this  not new problem affects all Shoutcast users even if I'm the one who reported it.
I thought you could maybe solve the issue.
Thank you for considered the problem.

I don't think there's any point in leaving that issue open.


Running the same code twice giving two different results

Hi, I am running faster-whisper on an audio file like follows
segments, info = model.transcribe(wav, task="transcribe", language="hi",beam_size=1, word_timestamps=True,max_new_tokens=50  )

The same code sometimes gives two segments and sometimes gives one segment on the same audio file. I find this weird. Is this expected ? whenever this gives 2 segments, second one of those is always "insertions" . there is no speech, but model gives some words as output.
However if I slightly modify the above statement  to not output word timestamps like follows
segments, info = model.transcribe(wav, task="transcribe", language="hi",beam_size=1, max_new_tokens=50  )

I always get only one segment in the output with good accuracy.
Is the presence of "word_timestamps=True" messing this up ?

Is this possible ? Did anyone observe this ?

Ok. Here is what I did. I took a pretrained HF model (https://huggingface.co/vasista22/whisper-hindi-small) and fine-tuned it using my data. Then I converted the checkpoint to faster-whisper format.
If I use "word_timestamps=True" in transcribe function, I am getting extra (useless) segments in the output. I don't know why.
This is not happening if I use whisper model directly for transcription. This is happening with my fine-tuned model only.

when "word_timestamps=False", the output is as follows
Segment(id=1, seek=600, start=0.0, end=6.0, text='सितम्बर 19', tokens=[50364, 45938, 33279, 36158, 48521, 27099, 3941, 105, 25411, 1294], temperature=0.0, avg_logprob=-0.17912933772260492, compression_ratio=0.6857142857142857, no_speech_prob=1.3633834695708693e-14, words=None)
when it is True, the output is like this
Segment(id=1, seek=252, start=np.float64(0.0), end=np.float64(2.52), text='सितम्बर 19', tokens=[50364, 45938, 33279, 36158, 48521, 27099, 3941, 105, 25411, 1294], temperature=0.0, avg_logprob=-0.17907507040283896, compression_ratio=0.6857142857142857, no_speech_prob=1.3633834695708693e-14, words=[Word(start=np.float64(0.0), end=np.float64(2.16), word='सितम्बर', probability=np.float64(0.999978095293045)), Word(start=np.float64(2.16), end=np.float64(2.52), word=' 19', probability=np.float64(0.9993481040000916))]) Segment(id=2, seek=496, start=np.float64(2.52), end=np.float64(4.96), text='सितम्बर', tokens=[50364, 45938, 33279, 36158, 48521, 27099, 3941, 105, 25411], temperature=0.0, avg_logprob=-0.4705956637859344, compression_ratio=0.65625, no_speech_prob=0.02291429601609707, words=[Word(start=np.float64(2.52), end=np.float64(4.96), word='सितम्बर', probability=np.float64(0.741854028776288))]) Segment(id=3, seek=598, start=np.float64(4.96), end=np.float64(5.98), text='सितम्बर 19', tokens=[50364, 45938, 33279, 36158, 48521, 27099, 3941, 105, 25411, 1294], temperature=0.0, avg_logprob=-0.4931728406385942, compression_ratio=0.6857142857142857, no_speech_prob=0.2716793119907379, words=[Word(start=np.float64(4.96), end=np.float64(5.98), word='सितम्बर', probability=np.float64(0.7634602943435311)), Word(start=np.float64(5.98), end=np.float64(5.98), word=' 19', probability=np.float64(4.705471383203985e-06))])

when the flag is False, the text is correct and also the number of segments is also correct. But the end of the segment is marked as "6.0" which is incorrect. "6sec" is duration of the wave file.
when the flag is True, the first segment text is correct and end time of the first segment is also correct. But it gave two more segments which is incorrect.

Is there something wrong which is obvious ?


Lang file values from d2vpkr

I made a script to automatically get some of the values (game_mode_n, rune_n, npc_dota_x, and the new region_n) from d2vpkr's lang files, and save them to our lang files.
This script is probably a one time use, so I'll probably remove it from this PR before we're done. If you think we should keep it in, let me know where it should be.

You can create a dev directory in the root and put the script there (like what we do in core)


improve clarity of script naming

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
i came to the site from hn, understanding that the site is about automating tasks on proxmox.
One of the first scripts I saw was the docker lxc script. The description of the script explains what docket is, which let me wonder if this is about running docker somehow nativley on proxmox. This is probably my fault by not reading the site properly, but I have two suggestions in mind:
Make Lxc stand out as a label that imakes clear its not part of the script title.
Make somehow clear that the script installs e.g. docker, because the only thing that is shown is a description of what docker is.
Please provide a description of the expected behavior.
As written above.
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
No response

Thanks for your feedback, and I get your point.
Currently, there are labels on the site, and a view other mentions:

But I do think it would help, if the GitHub introduction was also added to the site, that would make it clear what you are looking at for newcomers.


Include examples of all 3 methods of specifying user/host/password in README

Right now the README tells how to use the config file to set the username, hostname, and password. We should provide examples of providing these as CLI arguments, mention the use of environment variables, and link to the docs on config options.
docs on the env variable use: https://github.com/ansible/tower-cli/blob/master/docs/CONFIG_CMD_OPTIONS.md

Removing docs issues from milestones

I think we're looking to lean more heavily on the login command in the future


Refine the autogenerated package READMEs, add a publish script

Their layout is more forgiving now for NPM and Github, and the demo source code is automatically included.
Also went into the components that rely on another's styles and made sure they were being explicitly required.
Closes #13

Current coverage is 95.96% (diff: 100%)

Merging #17 into master will not change coverage

@@             master        #17   diff @@
==========================================
  Files            24         24
  Lines          1041       1041
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            999        999
  Misses           42         42
  Partials          0          0

Powered by Codecov. Last update 46422c6...f394602


【Bug report】win10 can not start a socket after system updated.

Describe the bug
win10 22H2 启动时无法创建socket连接
To reproduce

Start the program on win10
A black background error is showed.

Expected behavior
start a socket server.
Screenshots

Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response

me too

我也是，没想到是win10更新的问题...


cannot launch from apps section

Cannot launch application from the "apps" section. This always ends with an error stating that the credential-id is not set. Deployments from the data section work correctly. The same treatment is needed in both cases w.r.t. the credentials.

This is already fixed


rustfmt ICE with expanded code

Code
Minimized from expanded code (i.e. -Zunpretty=expanded) that we rustfmt in the Linux kernel to make it easier to read:
const _: () = builtin # offset_of(x, x);

Which makes sense, given:
https://github.com/rust-lang/rust/blob/7606c13961ddc1174b70638e934df0439b7dc515/src/tools/rustfmt/src/expr.rs#L401-L406
However, it would be nice to ignore (or format) these so that we can format expanded code.
Meta
It breaks in the latest stable (1.76.0) and nightly:
rustc 1.78.0-nightly (516b6162a 2024-03-03)

Error output
thread 'main' panicked at src/tools/rustfmt/src/expr.rs:405:13:
internal error: entered unreachable code

Backtrace

thread 'main' panicked at src/tools/rustfmt/src/expr.rs:405:13:
internal error: entered unreachable code
stack backtrace:
   0:     0x7fbfb27e405f - std::backtrace_rs::backtrace::libunwind::trace::h4257829118b815c0
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x7fbfb27e405f - std::backtrace_rs::backtrace::trace_unsynchronized::h8bf698b8571a7ffa
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x7fbfb27e405f - std::backtrace::Backtrace::create::hf360b329ac3984cf
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/backtrace.rs:331:13
   3:     0x7fbfb27e3fa0 - std::backtrace::Backtrace::force_capture::hce7c17c21d97619a
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/backtrace.rs:312:9
   4:     0x7fbfaf49641f - std[f9c89fb8bbe75f53]::panicking::update_hook::<alloc[7bfe078ffefd51e6]::boxed::Box<rustc_driver_impl[5cb1284730e04d20]::install_ice_hook::{closure#0}>>::{closure#0}
   5:     0x7fbfb27fef00 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::hd5a664d4e890a68c
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/alloc/src/boxed.rs:2030:9
   6:     0x7fbfb27fef00 - std::panicking::rust_panic_with_hook::h1329efa5bdc573dd
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:783:13
   7:     0x7fbfb27fec09 - std::panicking::begin_panic_handler::{{closure}}::h6ae91631ec1cf42d
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:649:13
   8:     0x7fbfb27fc186 - std::sys_common::backtrace::__rust_end_short_backtrace::hda139f8d0aadc9cd
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/sys_common/backtrace.rs:171:18
   9:     0x7fbfb27fe974 - rust_begin_unwind
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:645:5
  10:     0x7fbfb2849085 - core::panicking::panic_fmt::h862551fb494a270a
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/core/src/panicking.rs:72:14
  11:     0x7fbfb2849143 - core::panicking::panic::hddedaf52f5081cd3
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/core/src/panicking.rs:144:5
  12:     0x55e95779da61 - rustfmt_nightly[ce9e407bc4d9aa35]::expr::format_expr
  13:     0x55e957802286 - <rustfmt_nightly[ce9e407bc4d9aa35]::stmt::Stmt as rustfmt_nightly[ce9e407bc4d9aa35]::rewrite::Rewrite>::rewrite
  14:     0x55e9578193aa - <rustfmt_nightly[ce9e407bc4d9aa35]::visitor::FmtVisitor>::walk_stmts
  15:     0x55e957812870 - <rustfmt_nightly[ce9e407bc4d9aa35]::visitor::FmtVisitor>::visit_block
  16:     0x55e95779ecfb - rustfmt_nightly[ce9e407bc4d9aa35]::expr::rewrite_block_with_visitor
  17:     0x55e95779f0cc - rustfmt_nightly[ce9e407bc4d9aa35]::expr::rewrite_block_inner
  18:     0x55e95779d5fc - rustfmt_nightly[ce9e407bc4d9aa35]::expr::format_expr
  19:     0x55e9577a907f - rustfmt_nightly[ce9e407bc4d9aa35]::expr::rewrite_assign_rhs_expr::<rustc_ast[6684c6343d18f394]::ast::Expr>
  20:     0x55e9577ab367 - rustfmt_nightly[ce9e407bc4d9aa35]::expr::rewrite_assign_rhs_with_comments::<&alloc[7bfe078ffefd51e6]::string::String, rustc_ast[6684c6343d18f394]::ast::Expr>
  21:     0x55e9577b98fd - <rustfmt_nightly[ce9e407bc4d9aa35]::visitor::FmtVisitor>::visit_static
  22:     0x55e95781601d - <rustfmt_nightly[ce9e407bc4d9aa35]::visitor::FmtVisitor>::visit_item
  23:     0x55e9577f9f06 - <rustfmt_nightly[ce9e407bc4d9aa35]::visitor::FmtVisitor>::visit_items_with_reordering
  24:     0x55e957819bdb - <rustfmt_nightly[ce9e407bc4d9aa35]::visitor::FmtVisitor>::format_separate_mod
  25:     0x55e9576961ce - <rustfmt_nightly[ce9e407bc4d9aa35]::Session<std[f9c89fb8bbe75f53]::io::stdio::Stdout>>::format_input_inner::{closure#0}
  26:     0x55e9576ab731 - rustfmt[22febc4b220ec6a2]::format_and_emit_report::<std[f9c89fb8bbe75f53]::io::stdio::Stdout>
  27:     0x55e9576a9bcc - rustfmt[22febc4b220ec6a2]::execute
  28:     0x55e9576a529b - rustfmt[22febc4b220ec6a2]::main
  29:     0x55e95768fa83 - std[f9c89fb8bbe75f53]::sys_common::backtrace::__rust_begin_short_backtrace::<fn(), ()>
  30:     0x55e957691d39 - std[f9c89fb8bbe75f53]::rt::lang_start::<()>::{closure#0}
  31:     0x7fbfb27e1043 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::he5f334fe0a08c913
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/core/src/ops/function.rs:284:13
  32:     0x7fbfb27e1043 - std::panicking::try::do_call::h231e398ce39da676
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:552:40
  33:     0x7fbfb27e1043 - std::panicking::try::h46412093dcdab127
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:516:19
  34:     0x7fbfb27e1043 - std::panic::catch_unwind::hfbb2d28c473eb4dd
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panic.rs:146:14
  35:     0x7fbfb27e1043 - std::rt::lang_start_internal::{{closure}}::h083e0c5f8fcad290
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/rt.rs:148:48
  36:     0x7fbfb27e1043 - std::panicking::try::do_call::h37fd7901d6535c55
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:552:40
  37:     0x7fbfb27e1043 - std::panicking::try::h7c485b04206d8759
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panicking.rs:516:19
  38:     0x7fbfb27e1043 - std::panic::catch_unwind::hfea1c5c7d30edbf3
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/panic.rs:146:14
  39:     0x7fbfb27e1043 - std::rt::lang_start_internal::hc4df6736fe95cc4a
                               at /rustc/516b6162a2ea8e66678c09e8243ebd83e4b8eeea/library/std/src/rt.rs:148:20
  40:     0x55e9576ac8f5 - main
  41:     0x7fbfac319d90 - <unknown>
  42:     0x7fbfac319e40 - __libc_start_main
  43:     0x55e95767f269 - <unknown>
  44:                0x0 - <unknown>

rustc version: 1.78.0-nightly (516b6162a 2024-03-03)
platform: x86_64-unknown-linux-gnu

Cc: @metaspace (who found it when trying to expand his rnull driver)
From: https://rust-for-linux.zulipchat.com/#narrow/stream/291565-Help/topic/Using.20the.20.2Ersi.20target/near/423973701.

Indeed, looks like it, thanks!
If ignoring (or similar) is possible, that is great. In general, what would be best is knowing that rustfmt supports the -Zunpretty=expanded output.

To the best of my knowledge, as long as the output from -Zunpretty=expanded is valid, parsable rust code then rustfmt should be able to handle it, but I'm going to err on the side of caution and say it depends on the input you give rustfmt. I haven't really used -Zunpretty=expanded and I don't think we have any tests setup to more thoroughly verify that.
One caveat would be a case like this where there was an assumption that certain AST nodes would never appear directly in the AST, and instead would be expanded later in the compilation process. There might also be cases where rustfmt doesn't handle experimental, nightly-only syntax.
Another thing to keep in mind is that the max_width is a hard constraint for rustfmt. Depending on how verbose / nested the expansion is rustfmt might not be able to format certain AST nodes if they can't fit within the max_width limit.

Thanks for the analysis! Yeah, -Zunpretty=expanded is a feature that people is finding useful in the kernel, so it would be nice to make sure it is possible to format the output with rustfmt to make it a bit more readable (though it is also true that some of the output is already fairly readable). Would it make sense to test the formatting in tests for -Zunpretty=expanded itself, for instance, or here?
I think it is reasonable that the output of rustfmt here is best-effort, i.e. if something isn't as pretty as in the "normal code" case, or some lines aren't even formatted at all, I think that would be fine. In other words, getting most of a file formatted is already better than getting nothing.
If you want, we could reuse this issue to make it more about the general idea of ensuring it can process (to some degree) -Zunpretty=expanded code without ICE'ing.

Overall I think makes sense to add one off code snippets like the one you included in the issue description as test cases for rustfmt, but I don't know if we'd set up exhaustive -Zunpretty=expanded tests in rustfmt (at least not at this time).
It's hard to guarantee that rustfmt can handle all the -Zunpretty=expanded code you throw at it. After all, there are plenty of bugs formatting unexpanded code 😅 and I'm sure all of them would apply to -Zunpretty=expanded input too. We've also had instances where seemingly unrelated changes in the compiler suddenly cause crashes in nightly rustfmt so the chance of an ICE is never really 0%.
I agree that it would be better if rustfmt could process the -Zunpretty=expanded input without ICE'ing, and right now I think it makes sense to tackle each ICE as it pops up. If you or anyone else working on the kernel finds that there are other inputs that cause rustfmt to crash or behave strangely it would be great to open up issues as they arise!
In this case I think the fix for this one is something like this:
diff --git a/src/expr.rs b/src/expr.rs
index 147f4b31..6a21d88a 100644
--- a/src/expr.rs
+++ b/src/expr.rs
@@ -404,8 +404,11 @@ pub(crate) fn format_expr(
         ast::ExprKind::FormatArgs(..)
         | ast::ExprKind::IncludedBytes(..)
         | ast::ExprKind::OffsetOf(..) => {
-            // These do not occur in the AST because macros aren't expanded.
-            unreachable!()
+            // These don't normally occur in the AST because macros aren't expanded. However,
+            // rustfmt tries to parse macro arguments when formatting macros, so it's not totally
+            // impossible for rustfmt to come across one of these nodes when formatting a file.
+            // Also, rustfmt might get passed the output from `-Zunpretty=expanded`.
+            None
         }
         ast::ExprKind::Err => None,
     };

Thanks! That makes sense -- we will report the ICEs then. I added a note about it on our linked issue.
Of course, bugs can happen :) It was more about knowing whether expanded output was intended to be handled or not.

@rustbot claim

I just hit this issue with 1.79.0-nightly (1684a753d 2024-04-01) and I am a bit confused, should this already be in nightly?

@y86-dev I can understand the confusion. Fixes applied directly to rustfmt won't be reflected in nightly until we sync rustfmt up with rust-lang/rust

For reference: I can see it fixed in the current nightly (1.81.0), but not the current beta (1.80.0).

1.80 beta was cut before the subtree sync with the fix. i don't recall offhand where 1.80 is on the release train but if it's not too late then we could see if the relevant teams would support a backport to beta to pull it in

Ah, sorry, I wrote the message for reference since I was taking a look to see in which version it got fixed.
But, of course, getting it into 1.80.0 would be nice, since some people want to use the feature and it has been a while. There are a bit more than 3 weeks until its release.


Power off works power on does not. Multiple network adapters?

The power off side works perfectly but I am not able to get it to power back on.  I tried the HDD power save settings and the quick power on is enabled.  The TV and the PC are on the same network.  The only think I can think of is if the magic packet is being set out the correct network adapter.  I have VM Ware Workstation installed and that creates multiple VMWare Network adapters.  I am wondering if the magic packet is being sent out from one of these interfaces rather than the correct interface.

Hi there, can you enable the logging and upload the log to here please so I can have a look: https://pastebin.com/

Here you go:
https://pastebin.com/ACnCY04w

Thanks,
Looking at the log I have some questions

It looks like you tried experimenting with different values for the power on timeout. Is that correct?

Can you confirm that the PC is on subnet <IP_ADDRESS>/24? (note to self - add this piece of info to the log output and add a warning message if not). It should not matter what network adapter broadcasts the WOL, as long as it is on the same subnet. (See my notes in the readme.md on the first page of the repo)

Is the TV connected via cable or wifi?

It does indeed look like the TV does not respond to WOL or the WOL package does not reach it. (it looks like the magic packets are sent out from the PC though)
Here are some things for you to consider if you feel like testing:

You did not specifically write it, so please ensure that you have enabled 'Turn On via Wi-Fi' (regardless of if the TV is connecting via wifi or cable.

If you are on wifi, try using a cable to see if that changes anything. Note that this will require you to update the IP and MAC, so it might be easiest to just add another device while testing.

Double check the MAC-address with what is written in the network settings of the TV.

You could try to use this program to see if you can wake the TV with it: https://wol.aquilatech.com/ and then let me know how that goes. This program can also be used to listen for magic packets, which can provide further clues to what is going on and help understand whether broadcasted packets f.e are simply dropped by VMWare and needs

Let me know please how it goes. If we can find a bug in the code I will update accordingly

Thank you for all your help.  Totally my bad.  I did not read the instructions carefully enough.  I did not have the turn on via Wi-Fi enable.  After turning that on it is working perfectly.
Thank you for everything.

Thanks for confirming, glad it works for you!


kv_walk: docs, tests, tools, and recipes

Tools ideas
add_path_get and path.KeyPath are useful to get a "flat read access" from nested stores, but it's just for getting data: It's not enough to get a full KvReader (needs iter, len, contains) or KvPersister (needs del and set). kv_walk is relevant there. One could imagine a dol.trans.store_decorator that takes the same arguments as kv_walk (or a "kv_walker" object), and decorates the store in such a way as to offer a store whose keys are the paths of the kv_walk.
Related to the "flat stores" is this issue on hypercubic keys and issue on subscripting abilities.
dol.filesys deals with file/folder traversal with max_levels and isdir/isfile only, and these are somewhat baked in the code. One could envision a future for dol.filesys that would offer the same functionality, but also more, expanding the tree traversal aspects to anything involving path, key and value.
Other
Can see applications of remap for inspiration of applications.
┆Issue is synchronized with this Asana task by Unito

Just pushed a flattener: Made it in dol, here: https://github.com/i2mint/dol/blob/4c516485270adb87613cdc0b8497565446bc0e84/dol/trans.py#L2193
Note: It doesn't allow flat WRITES or DELETES. Just reads.

Related:

FlatReader
Making conditional_data_trans better, and generally; recursively applying wrappers


build: remove unused variable in dockerized script

Commit 881a3cb583 removed the hack/kubevirt-builder directory but
missed a variable using that directory in hack/dockerized. The
variable is unused so remove it.
Signed-off-by: Jim Fehlig<EMAIL_ADDRESS>
What this PR does / why we need it:
Removes an unused variable in the dockerized script.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm
/approve
Thanks!

/ok-to-test

/override pull-kubevirt-e2e-k8s-1.15-ceph
/override pull-kubevirt-e2e-k8s-1.16


feat: Support for z.literal(null)

Currently, z.literal(null) gets translated to {"type": "object"} which isn't very representative.
Not sure if this is the right way to go about it, I just went with the most obvious modification.

@JeongJuhyeon Oh, this is definately a bug! Nice catch. Would you mind adding a test?

Note to self: this broke tests so was force pushed from the main branch after optimistic merge


firefox-bin: Avoid including both the wrapped and unwrapped versions.

Motivation for this change
When running nix run nixpkgs.latest.firefox-nightly-bin, using https://github.com/mozilla/nixpkgs-mozilla, the shell contains both versions of Firefox, the unwrapped Firefox and the wrapped Firefox. Due to the path order, the unwrapped firefox is the one which is started when typing firefox.
This problem cause the GTK environment variable to not be considered with any wrapped Firefox, except with the one which is built from source as it is compiled against a specific GTK version.
The problem is caused by the propagated-user-env which suggests to carry the path of the unwrapped browser, in order to fix the man pages (based on the comment).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is tested as working by running which -a firefox in a shell spawn with nix run nixpkgs.firefox-bin. Before, which -a firefox would list both the unwrapped and the wrapped Firefox, and after it would only list the wrapped Firefox.

your fork is old
i use this to keep my fork up to date
#!/usr/bin/env bash
# if not done before
# git remote add upstream https://github.com/NixOS/nixpkgs.git

git fetch upstream
git checkout master
git rebase upstream/master
git push

your fork is old

Thanks, I used to rely on nixpkgs-channels to avoid pulling all experimental branches.

Result of nixpkgs-review pr 125669 at 28242f5d run on x86_64-linux 1

1 package skipped due to time constraints:

slimerjs

3 packages built successfully:

dropbox
dropbox-cli
mate.caja-dropbox

I even managed to find a wrapFirefox user that does provide the man directory: vimb.  However, it gets man into the result even without this piece of code, so maybe we should simply remove it.  Well, the cause is perhaps a bit too... magical:
find . -type f \( -not -name "${browserName}" \) -exec ln -sT "${browser}"/{} "$out"/{} \;

Actually, this creates share/man/man... so it would seem better to simply remove this piece of code.

I do not think so, as man does not exist in the target directory. ln -s will not create a directory to store a symbolic link in it, it would if the man directory existed.
Also this code is used a few lines above to handle icons.

Basically a revert of 00dc25b. I don't mind.

Yes, except that now there is a command which does the correct thing above and that this patch is no longer necessary.


Permission guidence for Azure AAD needed by the operator

Currently, the recommendations for API permissions to be granted for Azure Active Directory is the following:

Group.Read.All
GroupMember.Read.All
User.Read.All

Alternately, the following permission can be used instead:

Directory.Read.All

Should the guidance be changed  to use this new permission model or retain the existing guidance

It should be as narrow as possible, so the three given is probably the best. I don't think User.Read.All is required - perhaps User.ReadBasic.All is sufficient.