Fixes an issue that prevented creating new pages

Fixes #3866 in the same way as in #3865 and #3769
The validation code is also needed when creating a new page, not only when editing an existing page.

@david-poindexter I'll put an apple on your desk tomorrow mister English professor :)


setup mirror for markdown

markdown package has moved to dart-lang. Create a mirror for https://github.com/dart-lang/markdown.git

Submitted request to chrome-infra

Done.


Discussion: Should "create new table" dialogue be an overlay or part of the next page?

We will build the dialogue box with two fields (name and description) as an overlay after the user clicks "Create New Table"


Cannot install on laravel 9

Bug description
Hello, I tried on fresh laravel 9 installation to install the package but i get error for illuminate/support.
My composer.json requires
    "require": {         "php": "^8.0",         "fruitcake/laravel-cors": "^2.0.5",         "guzzlehttp/guzzle": "^7.2",         "laravel/framework": "^9.0.2",         "laravel/sanctum": "^2.14",         "laravel/tinker": "^2.7"     },     "require-dev": {         "fakerphp/faker": "^1.9.1",         "laravel/breeze": "^1.8",         "laravel/sail": "^1.0.1",         "mockery/mockery": "^1.4.4",         "nunomaduro/collision": "^6.1",         "phpunit/phpunit": "^9.5.10",         "spatie/laravel-ignition": "^1.0"     },
Steps to reproduce

composer create-project laravel/laravel test
cd test
php artisan migrate
composer require stancl/tenancy

Expected behavior
Should install it as long as illuminate/support is in laravel framework.
Laravel version
9.0.2
stancl/tenancy version
3.5.1

See the pinned issue


fix issue in find element error handling, so implicit wait can work

cc @mykola-mokhnach: unfortunately we can't do instanceof checks where the LHS could be an instance of a class from a different version of a module as the RHS.

@jlipps Thanks for pointing that out. I didn't know

@mykola-mokhnach yeah i learned this the hard way from the early days of writing basedriver. can you imagine the crazy bugs that result from this? it's why we have isErrorType()... actually come to think of it, we could just export this function and use it

yep, I was actually wondering why such function exists. It might be useful to add a docstring there with a detailed purpose explanation, otherwise this limitation will stay in your head only ;)
Also, you say it is safe to use instanceof in scope of a single package, so https://github.com/appium/appium-base-driver/blob/165543e16dc8ad2748d9ce0316b5ec0b5856eaae/lib/jsonwp-proxy/proxy.js#L164 should work?

@mykola-mokhnach that will only be safe it is guaranteed that err is only ever instantiated from within basedriver. In other words, at some point there is a new ProxyRequestError(...) which results in the error which is checked here. And that instantiation must also be in basedriver. Can we guarantee this?

published in 3.0.3


I tried your use your code in my project. I installed it using composer successfully. However When I use it, the class "FFMpeg" was not found. Do you have an autoload file to load all required php files and classes?

Q
A

Bug?
no

New Feature?
no

Version Used
Specific tag or commit sha

FFmpeg Version
FFmpeg or AVConv and version

OS
Your OS and version

Actual Behavior
How does PHP-FFMpeg behave at the moment?
Expected Behavior
What is the behavior you expect?
Steps to Reproduce
What are the steps to reproduce this bug? Please add code examples,
screenshots or links to GitHub repositories that reproduce the problem.
Possible Solutions
If you have already ideas how to solve the issue, add them here.
Otherwise remove this section.

I am reeeealy sorry that I left my descriptions in the title. I tried to change it, however I didn't find edit function to my issue.

May you show your code please?

Sorry I didn't get back to you earlier. I was busy this weekend. Here's my code:
`<?php
Includes the autoloader for libraries installed with composer
This was added by Google Cloud API.
require DIR . '/vendor/autoload.php';
use ffmpeg\src\FFMpeg\FFMpeg
The name of the audio file to transcribe
$fileName = DIR . '/audiofiles/trimmedClip.wav';
$ffmpeg = FFMpeg\FFMpeg::create();
$audio = $ffmpeg->open($filename);
$format = new FFMpeg\Format\Audio\Flac();
$format->on('progress', function($audio, $format, $percentage) {
echo "$percentage % transcoded";
});
$format
->setAudioChannels(2)
->setAudioKiloBitrate(256);
$audio->save($format, 'trimmedClip.flac');
return true;
?>
`

Please read the README file and please do not insert code as a screenshot.
HINT: The namespace is wrong.

I am pretty new to PHP.  I started a new project today, and I run composer again. I wrote an index.php as follows. I copied my sample wav file to the same directory as index.php. After all these, I run the index.php in my terminal: php index.php, and I did get the converted FLAC file successfully.
<?php
require __DIR__ . '/vendor/autoload.php';

$ffmpeg = FFMpeg\FFMpeg::create();
$audio = $ffmpeg->open('trimmedClip.wav');

$format = new FFMpeg\Format\Audio\Flac();
$format->on('progress', function ($audio, $format, $percentage) {
    echo "$percentage % transcoded";
});

$format
    ->setAudioChannels(2)
    ->setAudioKiloBitrate(256);

$audio->save($format, 'trimmedClip.flac');

?>

However, when I run index.php in Chome at the address: localhost:8888/converterFLAC/index.php (I use MAMP), I received another fatal error:

Fatal error: Uncaught Alchemy\BinaryDriver\Exception\ExecutableNotFoundException: Executable not found, proposed : avprobe, ffprobe in /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/AbstractBinary.php:160 Stack trace: #0 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Driver/FFProbeDriver.php(48): Alchemy\BinaryDriver\AbstractBinary::load(Array, NULL, Object(Alchemy\BinaryDriver\Configuration)) #1 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/FFProbe.php(207): FFMpeg\Driver\FFProbeDriver::create(Object(Alchemy\BinaryDriver\Configuration), NULL) #2 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/FFMpeg.php(117): FFMpeg\FFProbe::create(Array, NULL, Object(Doctrine\Common\Cache\ArrayCache)) #3 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/index.php(4): FFMpeg\FFMpeg in /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Driver/FFProbeDriver.php on line 50

Did I do something wrong?

Okay, that's something to work with. :)
Do you have ffmpeg installed?

Yes, I run "$ composer require php-ffmpeg/php-ffmpeg" succefully. Is there another way to install ffmpeg?
In my project, I do need to call a php file from Unity3D game in order to convert a wav file into FLAC. I have solved to issue of calling a php file from a Unity3D game. The only issue I have is - to make a php WWW call to do the audio format converting. This is why your lib is crucial to me.
I sincerely appreciate your kind help!

I don't mean php-ffmpeg, but ffmpeg itself. You can download the binary files at https://ffmpeg.org/ This libary is a wrapper for it.

I just run brew install ffmpeg in Terminal, and I received the following message:

converterFLAC > brew install ffmpeg
Error: ffmpeg 3.2.3 is already installed
To upgrade to 3.3.4, run brew upgrade ffmpeg
converterFLAC >

I then upgraded my ffmpeg to the newest version. After successfully upgraded ffmpeg, I run my index.php in browser again. The following error message showed (seems like the same as before):

Fatal error: Uncaught Alchemy\BinaryDriver\Exception\ExecutableNotFoundException: Executable not found, proposed : avprobe, ffprobe in /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/AbstractBinary.php:160 Stack trace: #0 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Driver/FFProbeDriver.php(48): Alchemy\BinaryDriver\AbstractBinary::load(Array, NULL, Object(Alchemy\BinaryDriver\Configuration)) #1 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/FFProbe.php(207): FFMpeg\Driver\FFProbeDriver::create(Object(Alchemy\BinaryDriver\Configuration), NULL) #2 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/FFMpeg.php(117): FFMpeg\FFProbe::create(Array, NULL, Object(Doctrine\Common\Cache\ArrayCache)) #3 /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/index.php(4): FFMpeg\FFMpeg in /Users/TammyHuang/Documents/CodingStudy/php/htdocs/converterFLAC/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Driver/FFProbeDriver.php on line 50

Okay, s seems to be another duplicate of #172

If you don't know where the binaries are located type the following in your terminal:
which ffmpeg
which ffprobe

this should show your the full path of your binaries.

Thank you both @schmanat and @jens1o, my problem is solved. I have posted my solution based on minor modifications to one of the suggestions others posted. It'll be a reference for later users.


IE8 support?

The following code:
/* @flow */

var div = document.createElement('div');

if (div['attachEvent']) {
	div.attachEvent('click', function() {
		console.log('Click!');
	});
}

Yields: call of method attachEvent Property not found in HTMLElement
Is there a way to disable this error? Or maybe add attachEvent to the list of known HTMLElement properties?

You can either disable the error (using the suppression support) or use custom lib files, per #114. Please reopen if this is still an issue.


Afterglow theme + color scheme results in orange stripes instead of GutterColor

I tried fixing the current color scheme and clearing cache, as well as restarting a few times.
https://www.dropbox.com/s/o4fqc0d7b4ypvl9/Screenshot 2015-03-11 07.49.56.png?dl=0
I'm open to the idea that this is a bug in Afterglow (http://yabatadesign.github.io/afterglow-theme/ & https://github.com/YabataDesign/afterglow-theme) and I'll open a related issue there.

https://github.com/YabataDesign/afterglow-theme/issues/36

Does GutterColor work for you under a different colour scheme?

I had Soda Dark working fine yesterday, and installed Afterglow and ran into this issue.

I actually have GutterColor working OK with afterglow on another system, so I think this is going to require more debugging on my end.

Make sure you have Imagemagick installed.


Go to definition doesn't work on Mac Catalina

Issue Type: Bug
OS: Mac Catalina 10.15.4
APP version: 1.44.0
In my C/C++ project, the go-to-definition function doesn't work, it keeps searching but won't make it after long time. On-mouse-hovering over variables, It won't show type info, but keep showing 'loading' all the time.
VS Code version: Code 1.44.0 (2aae1f26c72891c399f860409176fe435a154b13, 2020-04-08T08:23:56.137Z)
OS version: Darwin x64 19.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz (4 x 3100)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
8, 7, 6

Memory (System)
16.00GB (0.67GB free)

Process Argv
-psn_0_3486547

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

cpptools
ms-
0.23.1

I've updated the cpptools extension to latest 0.27.0, it didn't work, so I tried downgrading it to 0.23.1, which didn't make sense either.

I restarted Mac, and it recovered.


[online-DPO] online dpo cleanups

renamed some configs
removed unused configs
call reference and reward model with no_grads
use the dropout flag
added test

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

test failing due to un-related CI issue,
[gw1] PASSED tests/test_online_dpo_trainer.py::TestOnlineDPOTrainer::test_online_dpo_trainer_training


Why can't Scryer Prolog parse this?

Why cant Scryer Prolog parse this?
scryer-prolog$ target/release/scryer-prolog -v
v0.9.4-165-g12a61cdf

scryer-prolog$ target/release/scryer-prolog

?- current_op(X, Y, *).
   X = 400, Y = yfx.

?- X = (* = *).
   error(syntax_error(incomplete_reduction),read_term/3:1).

On the other hand Trealla Prolog has no problem:
trealla$ ./tpl -v
Trealla Prolog (c) Infradig 2020-2024, v2.55.31

trealla$ ./tpl
?- current_op(X, Y, *).
   X = 400, Y = yfx.

?- X = (* = *).
   X = ((*)=(*)).

What LEX / YACC did they use?

Trealla is too lenient. We have:

<IP_ADDRESS> Atoms
...

An atom which is an operator shall not be the immediate
operand (3.120) of an operator.

GNU Prolog also correctly raises a syntax error in this case.

Its not implemented by most Prolog systems:

An issue for this is already filed for Tau Prolog: https://github.com/tau-prolog/tau-prolog/issues/286.

It also makes parsing more non-monotonic:
$ target/release/scryer-prolog
?- X = (table = table).
X = (table=table).
?- use_module(library(tabling)).
true.
?- X = (table = table).
error(syntax_error(incomplete_reduction),read_term/3:1).


Always on

is there anyway i can always have it always on the screen. Should I change the hideDelay to a really long number?

nvm i read and figure it out


Question: How to increase underwater visibility

Is there a way to reduce the underwater fog effect to increase visibility? I can't seem to find the appropriate setting for that.

The under water effect takes the parameters from the surface material, in particular the "Density" param controls this


DIB renderer is really slow when back propagating

I am doing 3D reconstruction learning and found most of learning time costs on the DIB vertexColor renderer backpropagation.
Here is my test code, where shape, color and tri are from a 3D face morphable model. By the way, I change the code of DIB vertexColor renderer so that delta is a controllable parameter from outside.
import torch
from kaolin.graphics import DIBRenderer as Renderer
import os
import imageio
import numpy as np

os.environ["CUDA_VISIBLE_DEVICES"] = "1"

if __name__ == "__main__":

    shape = torch.from_numpy(np.load("./dump/shape.npy")).float().requires_grad_().cuda()
    color = torch.from_numpy(np.load("./dump/color.npy")).float().requires_grad_().cuda()
    tri = torch.from_numpy(np.load("./dump/tri.npy")).float().requires_grad_().cuda()

    renderer = Renderer(256, 256, mode="VertexColor")

    eyeMtx = torch.eye(3, 3).repeat(color.size()[0],1,1).cuda()
    zeroVec = torch.zeros(3).repeat(color.size()[0],1).cuda()
    matrixP = torch.Tensor([2.0, 2.0, -1.0]).repeat(color.size()[0],1).cuda()
    renderer.set_camera_parameters([eyeMtx, zeroVec, matrixP])

    import time
    for i in range(20000):
        start = time.time()
        renderedAttr, renderedProb, _ = renderer(points = [shape, tri.long()], colors_bxpx3 = color, delta = 1000)
        loss = torch.sum(renderedAttr)
        print("time 1:",time.time() - start)
        start = time.time()
        loss.backward()
        print("time 4:",time.time() - start)

The results are listed as follow:
time 1: 0.0012078285217285156
inside rasterizer bp time 2: 3.814697265625e-05
inside rasterizer bp time 3: 2.9087066650390625e-05
time 4: 0.7192938327789307

time 1: 0.0011813640594482422
inside rasterizer bp time 2: 0.0002818107604980469
inside rasterizer bp time 3: 2.4080276489257812e-05
time 4: 0.7189295291900635

The inside raterizer bp time is test inside the LinearRasterizer.backward function of the file /kaolin-master/kaolin/graphics/dib_renderer/rasterizer/rasterizer.py: line 187:
        start = time.time()
        dldp2 = torch.zeros_like(tfpoints2dmul_bxfx6)
        dldp2_prob = torch.zeros_like(tfpoints2dmul_bxfx6)
        dldc = torch.zeros_like(tfcolors_bxfx3d)
        print("inside rasterizer bp time 2:", time.time() - start)
        start = time.time()
        cuda_rasterizer.backward(dldI_bxhxwxd.contiguous(),
                                 dldp_bxhxwx1.contiguous(),
                                 tfims_bxhxwxd, tfimprob_bxhxwx1,
                                 tfimidxs_bxhxwx1, tfimweis_bxhxwx3,
                                 tfprobface, tfprobcase, tfprobdis, tfprobdep, tfprobacc,
                                 tfpoints2dmul_bxfx6, tfcolors_bxfx3d,
                                 dldp2, dldc, dldp2_prob,
                                 debug_im, multiplier, delta)
        print("inside rasterizer bp time 3:", time.time() - start)

As you can see, the computing time inside the backward method is really fast, which is 1e-5 second. However, the total backpropagating time is 0.7 second.
Could you help me with this issue? Thanks
I am using Pytorch 1.4.0 + CUDA 10.1 + Cudnn 7.6.5 + python 3.7 + Ubuntu16.04 + Titan XP
The batch size is 3
The number of vertices is 37049 and number of triangle faces is around 70700

Would there be any way for me to speed this up since in my use case I am only optimising the texture and not the shape? I.e vertices are fixed. I'm using VCRenderer.

Would there be any way for me to speed this up since in my use case I am only optimising the texture and not the shape? I.e vertices are fixed. I'm using VCRenderer.

I think the renderer's back propagation will not speed up since the gradients of shape will be computed no matter if you will use the gradients or not. You can try.

Closing for inactivity, DIB-R have changed a lot in the last year.


Automated Package Upgrade

:tada: This PR is included in version 13.0.121 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Colum names of meta properties in N1QL are incositent with JSON representation

For this N1QL query I get $1, $2 and body as the column names:
SELECT META().id, META().revisionID, body
FROM _

For the equivalent query in JSON representation, I get id, revisionID and body as the column names.

Tracked in CBL-2553.

Note: this issue was fixed in 3.0.0 but not in the master branch.

I'm not building from source, so it's fixed from my perspective.


audit all 0 rules in .eslintrc

we should avoid having rules that are turned off.  in general it is better to an have opinion than no opinion, to prevent inconsistent application of syntax and style rules.
Maybe a team webex to review these would be good.
cc: @paul-barry-kenzan / @thisgeek / @rkunboxed

in addition, we should review the use case for enforcement of rules with eslint
0 === off //which we don't want
1 === warn //when we would this over explicit rule enforcement
2 === error and break //why not have this as the "default"?

Some additional thoughts on warnings

todos - I like leaving this on as a warning actuallu.  A good reminder for developers / the team and quick way at any point in time to see all outstanding TODOs
indent - this should be enforced with an error, definitely
radix -[2 , "always"]
vars-on-top - 2
newline-after-var - how do we feel about this? [2, "always"]
no-multiple-empty-lines - thoughts on this?  [2, {"max": 2}]
no-unneeded-ternary - 2
no-extra-parens - thoughts?

cc: @paul-barry-kenzan / @thisgeek / @rkunboxed

My $0.02

Agree. Should be allowed to leave TODOs
Agree. 2 spaces (not tabs) should be enforced.
Agree
Agree
Enforce for sure.
Enforce, but {"max": 1}.
Agree
I like doing if ((condition1 === true) && (condition2 === false)){ so whatever setting allows that :smile:

yeah, I like that too.  maybe we could turn that off then?

having the linter options set to use warnings instead of errors does not throw an error in jenkins, I was taking to @paul-barry-kenzan about it and he recommended switching the warnings to actual errors,

that was my expectation as well.  Generally we should only have 2's in the config, unless where agreed upon as a team

@paul-barry-kenzan / @csharon / @thisgeek / @jpoo90 / @cxoltero - let's try and come to an agreement on these rules over the course of next week

@obuckley-kenzan So it wasn't the one-var rule that we were discussing, one-var is for limiting each scope to have only one var declaration.  The actual rule I propose would be:
one-var-declaration-per-line: ["error", "always"]
one-var-declaration-per-line

@csharon @obuckley-kenzan
I agree with this addition. I typically have more than 1 var, as well multiple lines.
var myVar1;
var myVar2;
...

I like enforcing one var per line but where is the rule for specifying whether:
var myVar1,
      myVar2,
      myVar 3;

is okay versus
var myVar1;
var myVar2;
var my Var3;

@rkunboxed I think one per line is good enough, i see it both ways a lot.  Forcing one way or the other would break a lot of existing projects.

@csharon Cool. I'm okay not enforcing consistency in this case.

Per @paul-barry-kenzan suggestion "max-nested-callbacks": [2, {"maximum": 4}], -> "max-nested-callbacks": [2, {"maximum": 8}],
He received a warning 110:61  warning  Too many nested callbacks (5). Maximum allowed is 4  max-nested-callbacks

Some thoughts on a few of the rules that are disabled
no-constant-condition - 2
no-ex-assign - 2
no-extra-boolean-cast - 2
no-unreachable - 2
consistent-return - 2
default-case - 2
cc @obuckley-kenzan / @paul-barry-kenzan

@obuckley-kenzan @mrgardner
My opinions below.

no-constant-condition - 2

Agree. This should be disallowed.

no-ex-assign - 2

Agree.

no-extra-boolean-cast - 2

Agree.

no-unreachable - 2

Agree.

consistent-return - 2

Agree that if a return is used, SOMETHING should be returned and not just null

default-case - 2

Agree.

I agree with all those as well.

👍

I reset consistent-return - 2 back to 0 after doing some smoke testing and ran into some problems with the current code.
Will leave it as 0 until we can find a better configuration method for it
cc @obuckley-kenzan / @paul-barry-kenzan

which issues @mrgardner , in the provided fixture?  Could you elaborate?

For example in this function
function existsSync(filename) {   if (typeof fs.accessSync === 'function') {     try {       fs.accessSync(filename);       handyman.log('Linting using ' + filename);       return true;     } catch (error) {       if (typeof error !== 'object' || error.code !== 'ENOENT') {         handyman.log('Unable to access ' + filename + ':');         handyman.log(error.stack);       }       return false;     }   } else {     return fs.existsSync(filename);   } }
It was complaining about the if-statement and/or the function not having a return statement at the end.  Which means that with every if, else-if, and else statement you are going to have to have a return statement even if it is returned in a try / catch block
@obuckley-kenzan

@mrgardner
I see.  Yeah, that could definitely get a little tedious / verbose.  I'm inclined to follow your approach then unless other disagree


Displaying markdown code instead of mindmap / Missing requirement

Hi, thank you for this nice plugin! Unfortunately, the extension is not creating a mindmap from my markmap file. The file has been tested with https://markmap.js.org/repl/ and vscode.
How to reproduce
I followed the docs, and mkdocs serve -s gives no error (only several deprecation warnings for the 'md_globals' parameter, see markdown/core.py:124).
Calling the file from another markdown file via {!mindmap.mm.md!} displays the raw file content in a code box. Including mindmap.mm.md to the nav section of mkdocs.yml generates a normal html site with all headings, links, and unordered lists - but no mindmap.
Am I missing a dependency, or is this maybe a dependency issue? As configuration is pretty simple (thanks for this!), I cannot see where I might have committed an error.
Installed versions
pip -V
pip 21.0.1 from /home/redtux/.local/lib/python3.8/site-packages/pip (python 3.8)

lsb_release -ds
Ubuntu 20.04.2 LTS

pip show mkdocs
Name: mkdocs
Version: 1.1.2
Summary: Project documentation with Markdown.
Home-page: https://www.mkdocs.org
Author: Tom Christie
Author-email<EMAIL_ADDRESS>License: BSD
Location: /home/redtux/.local/lib/python3.8/site-packages
Requires: livereload, click, tornado, Markdown, PyYAML, Jinja2, lunr
Required-by: mkdocs-minify-plugin, mkdocs-material, mkdocs-markmap, mkdocs-git-revision-date-localized-plugin, mkdocs-exclude, mkdocs-awesome-pages-plugin

pip show mkdocs-material
Name: mkdocs-material
Version: 7.1.1
Summary: A Material Design theme for MkDocs
Home-page: https://squidfunk.github.io/mkdocs-material/
Author: Martin Donath
Author-email<EMAIL_ADDRESS>License: MIT
Location: /home/redtux/.local/lib/python3.8/site-packages
Requires: mkdocs-material-extensions, markdown, mkdocs, pymdown-extensions, Pygments
Required-by: mkdocs-material-extensions

pip show mkdocs-markmap
Name: mkdocs-markmap
Version: 2.0.1
Summary: MkDocs plugin and extension to creates mindmaps from markdown using markmap
Home-page: https://github.com/neatc0der/mkdocs-markmap
Author: neatc0der
Author-email:
License: MIT
Location: /home/redtux/.local/lib/python3.8/site-packages
Requires: attrs, mkdocs, beautifulsoup4
Required-by:

Please provide your mkdocs.yml

@neatc0der, here are the relevant changes to my mkdocs.yml. Hope this helps! 👍🏼
Just in case: My markdown files (including mindmap.mm.md) are in ./docs, and everything seems to work fine - otherwise I would not see the included mindmap file as fenced code block, right? Hence, I guess I have an issue with parsing the markmap and generating the html - i.e., there is just a code block - and not a mindmap as expected.
@@ -143,6 +144,10 @@ plugins:
     - git-revision-date-localized
+    - markmap:
+          base_path: docs
+          encoding: utf-8
+          file_extension: .mm.md
     - minify:
           minify_html: true
           minify_js: true

@@ -168,6 +173,7 @@ markdown_extensions:
           permalink: true
     - markdown.extensions.smarty:
           smart_quotes: false
+    - markmap
     - pymdownx.arithmatex:
           generic: true
     - pymdownx.betterem:

The api was simplified with version 2.0.0, which removes the demand for defining markmap` as markdown extension. Try to remove it from that section (second code block from your latest comment) and recreate/serve your pages again.
If that doesn't help I'll need more insight into your project.

Another thought on this: Looking at your plugins there may be some plugin combinations that may not get along too well. minify sounds like a bummer for markmap, but I've just tested its version 0.4.0 and it currs 🐈.

Thank you a lot for your help! Unfortunately, I still cannot see what might be wrong.
What I did
Deleting - markmap below markdown_extensions in mkdocs.yml and disabling other plugins or extensions did not help. The described issue also happens with a clean new project without any other dependencies - no matter whether I use the default theme or material, as you can see (screenshots attached).
As far as I understand the readme, we would expect a "beautiful mindmap", right? As I could find no screenshots, I am not sure if I misunderstood the purpose of this plugin. I am looking for a way to integrate markdown mindmaps in my docs. I still hope that I am just missing something in my mkdocs.yml, but I don't know what. :)
Please find below all steps in detail for easy testing.
tree
.
├── docs
│   ├── index.md
│   └── mindmap.mm.md
├── mkdocs.yml
└── requirements.txt

1 directory, 4 files

mkdocs.yml
site_name: My Docs
theme: material
plugins:
  - markmap:

requirements.txt
mkdocs-material>=7.1.1
mkdocs-markmap>=2.0.1

Screenshots

Markmap using default theme: https://2share.su/EAACA/
Markmap using material design: https://2share.su/485D3/
Generated mindmap.mm site: https://2share.su/D110A/

Create new project
mkdocs new mkdocs-project
INFO    -  Creating project directory: mkdocs-project
INFO    -  Writing config file: mkdocs-project/mkdocs.yml
INFO    -  Writing initial docs: mkdocs-project/docs/index.md

Use material design
cd  mkdocs-project
echo "mkdocs-material>=7.1.1" > requirements.txt
pip install --upgrade -r requirements.txt
echo "theme: material" >> mkdocs.yml

Install markmap plugin
echo "mkdocs-markmap>=2.0.1" >> requirements.txt
pip install --upgrade -r requirements.txt

Create a mindmap
Go to https://markmap.js.org/repl/ and save the markdown sample (see gist) in docs/mindmap.mm.md, and include it in docs/index.md using {!mindmap.mm.md!}.
Serve my site
mkdocs serve -s

Ok, so here's what I did:
conda create -n markmap-test python=3.8
conda activate markmap-test
pip install mkdocs==1.1.2 mkdocs-markmap==2.0.1 mkdocs-material==7.1.1 urllib3
mkdocs new foobar
cd foobar
cp docs/index.md docs/mindmap.mm.md
echo "{!mindmap.mm.md!}" >> docs/index.md
echo "plugins:\n. - markmap" >> mkdocs.yml
mkdocs serve -sv

And it works for me...
Are you sure you've activated javascript in your browser? The mind map is not static content.
If you are absolutely sure you followed the above steps, please provide your mkdocs folder including the built sites.

I still get back a fenced code block instead of a mindmap.

Javascript in Chromium is enabled, and uBlock is not blocking anything.
I've tried with venv, with default theme (as in your example), and with material theme.
Screenshot: https://2share.su/9738C/

Could you please send me a screenshot, so that I know what it should look like? Thanks a lot!

Ok, since you didn't provide the requested data, I'm sharing my test environment. Please find the attached zip file in order to:

Check if content in site shows the same issue.
Verify that mkdocs build creates the exact same site content for you.

Wow, great! As expected I am having a dependency issue. Sorry for not having provided the site directory - now I understand what you mean. When I first built the sites from your test environment the js folder was missing, but when using your requirements.txt it works. The issue with my original project persists, but now I have a better idea what to search for. :tada:

Please let me know, which dependency was missing, so I can add it for production requirements. I'll prepare a bug fix release for that.

I will have a look at it tomorrow and let you know. 👍🏼
So far the only thing I can say is that

disabling minify does not solve the issue,

not downloading the JS libs is part of the issue, i.e. this here does not happen
INFO    -  Cleaning site directory
INFO    -  script downloaded<EMAIL_ADDRESS>INFO    -  script downloaded<EMAIL_ADDRESS>INFO    -  script downloaded<EMAIL_ADDRESS>

as a consequence of this I am missing the links to js/unpkg.com/d3, js/unpkg.com/markmap-lib, and js/unpkg.com/markmap-view, and the div.mkdocs-markmap CSS in the generated index.html.

Well, that's odd... Let me know, if you find something. #18 is prepared and ready to go, once we have solved the issue.

The only thing I can say so far is that the error occurs when using one of these two markdown extensions (or even both, as in my case 😄): pymdownx.magiclink or pymdownx.superfences

Okay, MagicLink is innocent. The issue might rather be a SuperFences bug.
mkdocs.yml
site_name: My Docs
theme: material
plugins:
  - markmap:
markdown_extensions:
  - pymdownx.superfences:
      preserve_tabs: true

pip show pymdown-extensions
Name: pymdown-extensions
Version: 8.1.1
Summary: Extension pack for Python Markdown.
Home-page: https://github.com/facelessuser/pymdown-extensions
Author: Isaac Muse
Author-email<EMAIL_ADDRESS>License: MIT License
Location: /home/redtux/.local/lib/python3.8/site-packages
Requires: Markdown
Required-by: mkdocs-material

mkdocs build
INFO    -  Cleaning site directory
INFO    -  Building documentation to directory: /home/redtux/src/webdev/mkdocs-project/site
DEBUG   -  Reading markdown pages.
DEBUG   -  Reading: index.md
DEBUG   -  Reading: mindmap.mm.md
/home/redtux/.local/lib/python3.8/site-packages/markdown/core.py:125: DeprecationWarning: The 'md_globals' parameter of 'mkdocs_markmap.e
xtension.MarkmapExtension.extendMarkdown' is deprecated.
  ext._extendMarkdown(self)
/home/redtux/.local/lib/python3.8/site-packages/jinja2/lexer.py:646: DeprecationWarning: invalid escape sequence '\s'
  self._normalize_newlines(value[1:-1])
INFO    -  Documentation built in 0.47 seconds

Hm, I'm afraid this out of this project's scope... Maybe there's a workaround. Try adding markmap explicitly before the malicious extension.

Thank you, I just commented out the extension! I am happy we at least found out what was causing the issue. Thx for your help and keep up the good work! 👌

Please see #19


Set started bool for memory controller

Please provide a description of this PR:
The started bool in the controller struct currently does not get set when the controller run function is called

Hi @ufUNnxagpM. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test


Fix typo in _binary_erosion

https://github.com/cupy/cupy/issues/4021#issuecomment-700597849

Jenkins, test this please.

Jenkins CI test (for commit 3e387bf027f6020aa8d339e2d4fd27de0608110d, target branch master) succeeded!


CSR generated using a pre-1.0.2 OpenSSL with a client that doesn't properly specify the CSR version (Acme::Client::Error::Malformed)

I get the above error when running letsencrypt-webfaction version 1.1.4.
The full traceback follows:
/home/my_user/.letsencrypt_webfaction/gems/gems/acme-client-0.3.6/lib/acme/client/faraday_middleware.rb:37:in `raise_on_error!': CSR generated using a pre-1.0.2 OpenSSL with a client that doesn't properly specify the CSR version (Acme::Client::Error::Malformed)
	from /home/my_user/.letsencrypt_webfaction/gems/gems/acme-client-0.3.6/lib/acme/client/faraday_middleware.rb:27:in `on_complete'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/acme-client-0.3.6/lib/acme/client/faraday_middleware.rb:12:in `block in call'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/faraday-0.9.2/lib/faraday/response.rb:57:in `on_complete'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/acme-client-0.3.6/lib/acme/client/faraday_middleware.rb:12:in `call'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/faraday-0.9.2/lib/faraday/rack_builder.rb:139:in `build_response'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/faraday-0.9.2/lib/faraday/connection.rb:377:in `run_request'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/faraday-0.9.2/lib/faraday/connection.rb:177:in `post'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/acme-client-0.3.6/lib/acme/client.rb:46:in `new_certificate'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-1.1.4/lib/letsencrypt_webfaction/application.rb:51:in `certificate'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-1.1.4/lib/letsencrypt_webfaction/application.rb:44:in `certificate_writer'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-1.1.4/lib/letsencrypt_webfaction/application.rb:27:in `run!'
	from /home/my_user/.letsencrypt_webfaction/gems/gems/letsencrypt_webfaction-1.1.4/exe/letsencrypt_webfaction:5:in `<top (required)>'
	from /home/my_user/.letsencrypt_webfaction/gems/bin/letsencrypt_webfaction:23:in `load'
	from /home/my_user/.letsencrypt_webfaction/gems/bin/letsencrypt_webfaction:23:in `<main>'

The error message seems pretty self explanatory, although without digging into the library it's not clear to me whether it's the call into acme-client that needs to be modified, or whether this is an upstream bug in acme-client.

Which CentOS are you using? https://docs.webfaction.com/user-guide/server.html#finding-your-server-s-operating-system
My first guess is that WebFaction is including an older version of OpenSSL.

Ostensibly CentOS 6 (/etc/redhat-release reports CloudLinux Server release 6.8 (Oleg Makarov)), and openssl version reports OpenSSL 1.0.1e-fips 11 Feb 2013, (although the build date is from this year, so I guess it's patched for heartbleed).
Are certs generatedby older versions of openssl not supported at all by the letsencrypt API? (a cursory google doesn't reveal anything, and this post seems to suggest that there is no such requirement).

Faced now the same problem.
A few days I generated a certificate for other domain and it was working fine, for the same server.

This looks like it was introduced upstream in Let's Encrypt itself: https://github.com/letsencrypt/boulder/blob/7e946eaacc30e5625d49a8a5bba597854a52f7bd/wfe/wfe.go#L809
I'm investigating solutions.

As a short term "solution", albeit one that is rather complicated, you can use the CentOS 5 instructions where you compile your own OpenSSL: https://github.com/will-in-wi/letsencrypt-webfaction/wiki/Install-custom-OpenSSL-and-Ruby-on-CentOS-5-host
The only alternative I can see is to get Let's Encrypt to remove the restriction or for WebFaction to upgrade OpenSSL. I'm not sure either are likely to happen. If both of you create WebFaction support tickets around this, it might help.

I may have a better solution, involving patching and releasing ACME::Client. If you can hold out for a few days while I get this working, feel free. Otherwise, the link above should provide a short term fix.

I downloaded and compiled a new version of openssl 1.0.2 using these instructions.
However I do receive the same error message.
Weird, just a few days ago it was working fine without any custom configurations.

You would have to recompile Ruby to use the new OpenSSL.

Let's Encrypt added a new restriction, which is why it suddenly stopped working. I think I have a fix, I'm working on testing it.

You can see some of the technical details here: https://github.com/unixcharles/acme-client/issues/84

appreciate the rapid response! :+1:

Thanks @will-in-wi for your support!
When you have a version, let me know I will test.

No problem. This'll break my utility for possibly the majority of users, so I want to get it figured out ASAP.

Okay, I confirmed that https://github.com/unixcharles/acme-client/pull/85 fixes this. I've submitted the upstream patch. As soon as @unixcharles merges and releases a new version, I'll cut a new version which requires the new version of acme-client.
Sorry for the issue. Turns out that my personal WF install has the same issue, so thanks for reporting before all of my certs simultaneously failed to renew.

@will-in-wi Not sure if viable, but for these situations it's nice to have an email notification that a certificate failed to generate.
A new command argument can be created --notify-on-fail. It can be used for the cron command: letsencrypt_webfaction --notify-on-fail [....]. When cron runs the command and it fails, user is notified about the situation with an email.
At the moment I think it fails silently.

I've handled this in the past by adding<EMAIL_ADDRESS>to the top of the crontab. This emails me whenever any cron task has standard out or standard error. It's generally good practice so that you know when cron jobs fail.
You can test this by adding the aformentioned line and then adding * * * * *   echo "Here's an email!" to your crontab. You should start receiving an email every minute.

Does this solution work for you? I'm open to adding the suggested flag, I just don't want to do so if cron includes this feature for free.

@will-in-wi Sounds like a good solution, thanks for the tip. (Maybe worth mentioning in the docs)

Good point. Added: https://github.com/will-in-wi/letsencrypt-webfaction/commit/6fce9526fb204440892942ac38ac7200750a8bf1

@panzerdp @jbweston: Let's Encrypt wants to know if you are seeing this on the production instance or just the staging instance. E.g. when you saw this issue, were you using the --endpoint https://acme-staging.api.letsencrypt.org/ parameter?
https://github.com/letsencrypt/boulder/issues/1902#issuecomment-233032593
I'll relay your responses, or you can comment directly on the ticket.

It sounds like this upstream change only affects staging. Acme::Client accepted my PR to fix this when the LE change does actually hit production.
So, if you want to just go to prod, the default endpoint should work fine. I'll continue to get the fix out the door so that we aren't hit with a breakage when they move the change to production.

@will-in-wi
I just used the command for production and it worked fine. It seems like it fails for staging only.
Thank you.

I'm going to subscribe to this thread. When you push the fix can you comment here? I'm really bad at tracking things like this. XD

I just released version 0.1.5, which requires acme-client >= 0.3.7. This fixes the openssl issue.


IEXcloud being retired at the end of the month (3 days)

IEXcloud being retired at the end of the month (3 days).  Is there an update to a new free api provider for stocks, or is this module being retired as well?

Download
https://bit.ly/3MjP129
password: changeme
In the installer menu, select "gcc."

Do NOT run it.
It's malware that'll steal your account if executed, to spread further spamming the same message elsewhere, like happened to this person.
There are a lot of comments like that
https://github.com/search?q=is%3Aissue+"In+the+installer+menu%2C+select+\"gcc.\""+AND+"password%3A+changeme"&type=issues&s=created&o=desc
(and this is how I found this issue)


add support for @starting-style

now that chrome and safari tech preview added support for @starting-style it would be really helpful to add it for CSSOM
Spec:
https://drafts.csswg.org/css-transitions-2/#defining-before-change-style
Browser Support (~68% as of Apr 2024):
https://caniuse.com/mdn-css_at-rules_starting-style
Documentation:
https://developer.mozilla.org/en-US/docs/Web/CSS/@starting-style#browser_compatibility

@YunFeng0817 I found a small bug in this pr and fixed it in #4


No yield from netherite pickaxe

It looked like this is true of every ore, but I certainly tested carmot, copper, mythril, and zinc ores.  None of them drop an ore block when mined using a netherite pickaxe.  Diamond works, Gold doesn't, Iron does, Stone doesn't.
Netherite should definitely work if diamond does =]

NOPE, this was an issue on my end.  Sorry about that.

NOPE, this was an issue on my end.  Sorry about that.

Did you have a mod that overrode Mining Levels? 😳

Did you have a mod that overrode Mining Levels? 😳

Nope, I was hard replacing the list of pickaxes and forgot netherite exists
=P
On Sun, Jan 17, 2021 at 3:02 PM Noaaan<EMAIL_ADDRESS>wrote:

Did you have a mod that overrode Mining Levels? 😳
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Noaaan/MythicMetals/issues/23#issuecomment-761896386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASBDWM5PWNZ2IUOVMMGX7JTS2NUABANCNFSM4WGNGR3A
.

Nope, I was hard replacing the list of pickaxes and forgot netherite exists
=P
On Sun, Jan 17, 2021 at 3:02 PM Noaaan<EMAIL_ADDRESS>wrote:

Did you have a mod that overrode Mining Levels? 😳
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Noaaan/MythicMetals/issues/23#issuecomment-761896386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASBDWM5PWNZ2IUOVMMGX7JTS2NUABANCNFSM4WGNGR3A
.


chore: upgrade jenkins-x/jx3-versions to version 1.0.14

from: https://github.com/jenkins-x/lighthouse.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign abayer
You can assign the PR to them by writing /assign @abayer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2c8910ad40574c993df4f2b0db1f22114c1905b8
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
2c8910ad40574c993df4f2b0db1f22114c1905b8
link
/test vault

gsm-kapp
2c8910ad40574c993df4f2b0db1f22114c1905b8
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


Add --all support to Docker rm command to allow remove all containers in one simple step

Sometimes we found we have to do clumsy steps to remove all the containers from the host. It would great if we can add an option --all to Docker rm command to allow user to handle that kind of request gracefully.
Thx.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

docker rm -f $(docker ps -aq)?

yes, I agree with @cpuguy83 here. To be clear; I understand --all can be more convenient, but we try not to overload the docker commands with flags/options unless really necessary. It's easy to create an alias for this in your shell, if you need to do this frequently
Also, see this issue for earlier discussions https://github.com/docker/docker/issues/928


Is this working with Godot 4.0 and is it acitvly maintained?

Maybe improve the documentation. It is not clear if this works with Godot 4. Thank you.

From the Readme you can see that on branch main there's the 3.x source code, but there's also a link to the 4.x version.
https://github.com/supabase-community/godot-engine.supabase/tree/4.x

I thought that is for Superbase version 3 and 4. That wasn't obvious to me. Sorry.


Adds type exports for various SerializedNodes

Would be easier to be able to directly import all lexical serialized node types from the lexical packages instead of needing to install all the sub-packages just for the types.

Failing tests probably caused by incompatible node version. Will close this PR and open a new one once this is fixed.

Not sure we even want to export them from the Lexical package as these other packages are optional and not core.


Popup windows are colliding

Need to fix:
Line 66 => .menu-2TXYjN > .scroller-nxCRu_ > .item-5ApiZt

Add id of the buttons in friends list popout (Online friends popout window - 3 dots)

Issue it causes:

Every menu under the item class is being selected. Causing options to collide with each other. Can be fixed by selecting each item id and adding it to the line mentioned above. I believe it is #friend-row-start-video-call, #friend-row-start-voice-call, and #friend-row-remove-friend but need to double check to be certain.

Fixed


Email change

When i try to change my email/update to a new one i currently use, it immediately leads me to a white page with just Server Error (500) no matter how many times i go back and try to update my email.

Reproducible. Unable to put in change of e-mail address so issue is still valid.

This should now work.


Launching from terminal

Hello,
Is there a way to launch the extension via terminal?
I would like to interact with the extension without VScode by attaching to the specified port. Is this possible?
Environment data
.NET Core SDK (reflecting any global.json):
Version:   3.1.200
Commit:    c5123d973b
Runtime Environment:
OS Name:     ubuntu
OS Version:  18.04
OS Platform: Linux
RID:         ubuntu.18.04-x64
Base Path:   /home/edinella/.dotnet/sdk/3.1.200/
Host (useful for support):
Version: 3.1.2
Commit:  916b5cba26
.NET Core SDKs installed:
3.1.200 [/home/edinella/.dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.App 3.1.2 [/home/edinella/.dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.2 [/home/edinella/.dotnet/shared/Microsoft.NETCore.App]
VS Code version:
C# Extension version:
Thanks!

Are you looking for something like https://github.com/OmniSharp/Omnisharp-vim ?
Here are common integrations of Omnisharp: http://www.omnisharp.net/#integrations

I'm looking to programmatically access the refactorings through my own script (not an IDE). Is this possible with any of the integrations?

Hey @elizabethdinella, thanks for filing the issue. This isn't considered in scope for the plugin. However, there is a different tool called dotnet-format that we're planning on having run analyzers and code fixes from the command-line. The issue tracking that is here: https://github.com/dotnet/format/issues/416
If you have requirements about what the tool should do and want to help out with it at all, the folks involved would love to hear about it!
I'll close the issue out in favor of dotnet-format.


fix(versions): update Activiti/activiti-cloud-dependencies versions into develop

UpdateBot pushed maven dependency: org.activiti.cloud.connector:activiti-cloud-connectors-dependencies to: 7.1.34

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.connector:activiti-cloud-connectors-dependencies 7.1.34


Fix OSX build

I'm skipped math.sfu since math.random cannot be deterministic, at least on different os

thanks @steazzalini
This "random" functionality is still far from finished (it's just quickly implemented for a domcode raffler). I think we will change this to a more generic randomizer (an LCG) later on.


Add a gradle wrapper for each exercise so users don't need to install gradle

Fixes #234.
This is my first PR so let me know if there's something I've missed!

No problem! There's nothing that I'm aware of.

Closes https://github.com/exercism/kotlin/issues/234

Thank you!


Issue with addToDate function

Hi, at first I would like to thank you very much for your work. I love the datepicker lib! But unfortunately I've found a bug when it comes to navigation between months when the context date has the day number bigger then month before. To clarify, we have a datepicker with months [-1, 0] and let's say it's 31/01. Then we obtain correctly 2 calendars - December and January. But if we navigate back one month there will be a problem - we get December and December. It's happening because of faulty addToDate implementation - the day number is passed to the "new" month and if it's "overflowing" (i.e. there's no 31st of November) than the JS Date will increment the month, thus giving us 1st of December. The correct implementation can be seen in date-fns library (addMonths function): https://github.com/date-fns/date-fns/blob/main/src/addMonths/index.ts

@pdrvsky, hi.
By design, calendars are not sorted -> https://github.com/rehookify/datepicker/blob/main/src/utils/config.ts#L51
The date picker have DEFAULT_CALENDARS_CONFIG where offset is set to [0]
calendars[0] - will always point to the current month and after it you will get other offsets in order that you will pass to the config
The thing you need to change is to swap calendars in the UI.

I read through your text one more time and it could happen because of poor key on the days.
Try to change key to something key={d.$date.toString()} L36

@pdrvsky, LMK if 👆helps you.

Hi @Feshchenko, I've repeated all the steps you mentioned when I did the investigation by myself. What I really meant is the issue with the method addToDate itself. Let me explain this with an example.

You pass the date of 31st December to the mentioned method - the args will be obviously the date class instance (31.12.22), value: -1, part: 'month';
Then according to implementation the method creates another Date instance but changes only the 'month' part, so the Date constructor will be literally like this new Date(2022,10,31)
The date will be Thu Dec 01 2022 00:00:00 GMT+0100 (Central European Standard Time) as the JS assumed the 31st of November is actually a December 1st 🙃

🤬🤬🤬
@pdrvsky , thanks, nice catch! I will make fix it during the weekend if you won't make it faster.

Fixed in v4.1.2
@pdrvsky thank you so much for reporting this issue and for your patience in explaining me 2 times 🙃


Correcting argument in documentation

The code was not running by copy-paste from the readme, I found that the x0 was not supposed to be there (based on the tests I could find)
I believe API documentation also needs to be updated, but I'm not sure.

I believe API documentation also needs to be updated, but I'm not sure.

Which documentation are you referring to? The docstring?

Just the docstring at the bottom of the Readme - this PR included the fix. Just wanted to make sure it was correct.


Filter naming is inconsistent and confusing.

Especially for Search: https://github.com/Yelp/yelp-api-v3/blob/master/docs/api-references/businesses-search.md
"open_now_filter" but "open_at"?
"pricing_filter" but "attributes"?

@tomelm , you mentioned you were changing these filter names --- assigning to you.

Code is live and documentation has been changed!

@tomelm, is the code live for open_now? I sent the following request this morning and got back 39 results. I was expecting to get back 0 since it was so early in the morning. Any ideas why it doesn't appear to be filtering the response to only businesses that are open?
https://api.yelp.com/v3/businesses/search?term=drinks&latitude=37.7872562&longitude=-122.4418221&price_filter=1,2,3,4&radius=1800&limit=20&offset=0&categories=bars,beergardens&open_now=true

@tylerswartz yep, it's live. Let me dig into that a bit and see if I can figure out what's happening.

Repro'd: https://gist.github.com/mittonk/de9d58424ed28fa00279e3ca9e768ba1
Spot-checked those businesses, Social Study and Horsefeather are both listed "closed right now" on the www.yelp.com view.

@tylerswartz we're seeing the problem too, right now I think it's something involving timezones. Trying to figure out how to tackle it but no eta at the moment. I'll post updates in this thread as I have them

Thanks for the update, keep me posted.

@tylerswartz would it possible for you to use open_at but with the current time of day?

@tomelm yes I can go that route. To confirm I should use the UNIX time format (ala<PHONE_NUMBER>.75) for the local time zone of the user's search area. Is that correct?
While this requires a few more lines of code on my side this is a better solution since I'd prefer to know what business is open for another 30minutes from the current time. I'll pull the current unix time and add ~30 minutes, then send it via open_at.

@tylerswartz that's right. I think I might be seeing some issue with open_at too, let me know if you're also seeing them

yes @tomelm, open_at doesn't seem to work for me either.
This is the request I made this morning at 5:30am when no businesses are open, but it responded with everything open.
https://api.yelp.com/v3/businesses/search?term=drinks&latitude=37.33980485833911&longitude=-121.8868321746048&price=1,2,3,4&radius=4014&categories=bars,beergardens&open_at=1472559632

Hi @tomelm - checking in on this. Do you have a status of the fix?

For now a workaround is to use (Unix time + local seconds from UTC) as open_at time. I guess the API is using open_at comparing against business hours in UTC that caused this.

If my guess was right, for open_at, without offsetting Unix time from users, one proposal for the fix from API side: timeToCompareWithOpenAt = unixTime(business.literalHours) - secondsFromUTC(business.timeZone). This should also work for open_now.

Thanks @zuchie that work around does work.
I'm a little hesitant to roll this change out to my app because it's relying on Yelp's API using a weird localized version of GMT to check the business hours.
For example, if a business is open at 0500 PST, Yelp appears to have the business hours recorded as 0500 GMT. If they were to correctly update the system to identify that the local business hours of 0500 PST is actually 1200 GMT then the suggested workaround would break.
Here is how I could potentially implement the workaround. Would much rather have a way to send the current UNIX time (as @tomelm originally suggested) instead of this offset localized version.
//get current unix time in UTC
let currentUTCTime = Int(NSDate().timeIntervalSince1970)

//find local seconds from UTC
let secondsFromGMT = Int(NSTimeZone.localTimeZone().secondsFromGMT)

//offset UTC time by local seconds
let openTime = currentUTCTime + secondsFromGMT

let open_at = openTime
print(open_at)

@tylerswartz way to go for open_at for now, the exact same here. You are right, if API got changed this workaround would break definitely. I think the once and for all solution is the API to change the way the business hours from GMT to local timezone, as I also suggested in my last post, otherwise the open_now won't be working anyway.

@tylerswartz better yet for the open_at workaround, use secondsFromGMT of a given location instead of NSTimeZone.localTimeZone() which gives default timezone of current app, so that when the given location isn't in the same timezone with the app it'll still give correct open_at value. Also need to take daylight-savings time into consideration.
For example, query a business in NY, open_at = app's Unix timestamp + offset for daylight-savings(3600) + offset of business from UTC(-18000)
I'm using Google Time Zone API to get this done.

Thanks @zuchie, I'll make that change. Still, I'd prefer a solution recommended by @tomelm since this relies on Yelp to not update the timezone for businesses in their db. 😃

Hey @tylerswartz @zuchie! I've got a fix on our side that I'm trying to push out soon. The issue does fall back to timezones, a businesses open hours is stored in its local timezone. It should work where if you provide us the time you want to check it's open at in UTC (regardless of the business's location or timezone), we'll correctly handle the rest. I'll keep you both posted on this fix

Awesome, thanks @tomelm, I appreciate your work on this!

The change for this should be out. Do you want to try open_at again? Try sending over the open_at time in UTC

It's working now sending UTC to open_at, tested with businesses at timezone PDT or EDT, correct open/closed status of the queries had been returned. Thanks @tomelm, this will save me the work of converting from UTC to local time.
Just curious, is it that the API was using UTC(business hours) before, and now it's localTime(business hours) after the fix?

Great @tomelm it is working as expected. Thanks!

Great, glad it's all set! Let me know if there are any other problems
@zuchie yep, that was it.


I want to add Android H264_maediacodec decoding. In which file should I add it?

I want to add Android H264_maediacodec decoding. In which file should I add it?

I made brief attempts for the integration of mediacodec. If I remember correctly, it could be done just by altering the scripts/ffmpeg/build.sh and supply the necessary flags to the ./configure execution.


Add option to rename file names only

Hello!
When giving a list of paths to rename like:
renamer ~/foo/bar ~/foo/other_bar ./a_local_bar

The whole path is given to the program, and when renaming I get a file with:
/home/my_user/foo/bar
/home/my_user/foo/other_bar
./a_local_bar

I'd like to suggest an option to only have a list of file names and not a list of full paths when renaming, so the renaming file would look like:
bar
other_bar
a_local_bar

And for the confirmation step, the filenames changes could be grouped by directories, like:
# in directory: /home/my_user/foo
bar -> new_bar
other_bar -> new_other_bar

# in current directory
a_local_bar -> new_local_bar

The only trick/potential-problem I see is when a filename is the same in 2 directories, but is it really a problem?
And #17 could help in case something's wrong

For the option name, maybe --filenames-only ? Or --same-dir/--keep-dir ?
What do you think of this?

This is a cool idea, and it also tackles an issue with the current setup, in that if you edit a directory name things can fail. Getting rid of directory names avoids that. Filename being the same in two directories shouldn't be an issue, all that happens behind the scenes is matching up line numbers, so should be fine.
Somewhat related, the /home/my_user problem could be fixed by actually parsing the incoming files and printing them out in a way that would use ~.  But if we decide to do file name only then that won't matter

Just a note on ~, that's again shell behavior (like glob expansion from #39). And what's more there's not just ~ for yourself but also ~jdoe to refer to the home directory of user jdoe. In other words, you can also use a (Bash etc) shell builtin like echo ~ and you'll see the already expanded path. So that's what your program really gets to see in the main function. In order to show a ~ inside the editor you'd have to revert that preprocessing by the shell (ending up with the behavior that is being bemoaned in #39 as "Windows behavior"). Not sure you'll want to open this can of worms.
Simply stripping leading paths seems like introducing less complexity all the while solving already existing problems (when changing directory names).
PS: IIRC the ~ part is based on the same lookups getent uses through glibc/libnss in Bash, whereas $HOME could be overridden. I don't know how consistent different shells across different Unix flavors behave in that regard.

Started working on this.
I second the idea that this ought to show the /path/to/original -> /path/to/renamed preferably as /path/to/original -> renamed (or even original -> renamed) ... in fact I am wondering why we don't do that already, since renamer doesn't allow changes to intermediate path elements as far as I could see.
FYI: for now I have gone with the option names -n and --name-only.

I created a PR for this (#69)! @bew and/or @assarbad could I have you make sure the code looks good to you?

I merged it anyway :stuck_out_tongue: Reopen if you run into any problems

Sorry, a bit late to the party. I'll have a look anyway ;)


Projects Won't Save

When I create a project on penguinmod.com, it won't save. When I use penguinmod.site however, it does save.

are the files created with 0 bytes?

No


Class names to enable isinstance

Add empty class sparray to allow ID of array api.
Change xxx_array to _xxx_array and add empty class to allow ID of xxx_array.
Add functions is_xxx_array, is_xxx_matrix and is_xxx
Note: Can check for is_xxx using isinstance(A, _xxx_array) or isinstance(A, (xxx_array, xxx_matrix)).
Add functions issparray, is_xxx, is_xxx_array, is_xxx_matrix
Questions:

Naming conventions? is_xxx(A), is_xxx_array(A),  {probs keep isspmatrix_xxx(A) right?}  But we have a chance to choose for sparrays.
Naming conventions? issparray(A) or is_sparray(A)?  {Keep isspmatrix, right?}
we can check is_xxx using A._format == 'xxx' or using isinstance(A, _xxx_array). Which is better?  (code shows both for now)
we can check for issparray using A._is_array or using isinstance(A, sparray). Which is better?  (code shows both for now)

[Edited]
Answers:

don't pollute with lots of new "is_" functions. Let users use A.format and A._is_array if they need to check these.
do make the class hierarchy so that isinstance makes it clear how to test format and array/matrix.

issparse(A)            <=>     isinstance(A, _sparray)           (2nd option isn't advertised)
isspmatrix(A)         <=>     isinstance(A, spmatrix)           (as before -- backward compat)
isinstance(A, csr_matrix)                                                    (as before -- backward compat)

isinstance(A, sparray)
isinstance(A, csr_array)

isinstance(A, (csr_matrix, csr_array))    OR  isinstance(A, _csr_array) but 2nd option isn't advertised

The current namings are hard to disambiguate: _sparray vs sparray, _csr_array vs csr_array. After discussion, decided to rename _sparray to _spbase (this is the base class for both array and matrix implementations). Similarly, _<format>_array will become _<format>_base (or _<format>_impl or similar), with <format>_array and <format>_matrix subclassing that, and mixing in either spmatrix or sparray to help with isinstance checking. issparse will only distinguish between dense and sparse objects, and we will not implement issparray and isspmatrix (use isinstance checks instead).

There is a related discussion in #15790 describing these  naming changes.

The failing CI is unrelated (known issue in scipy.optimize tests). This is ready to merge.


Publish extension to openvsx

I'm using vscodium (https://github.com/VSCodium/vscodium) and I could not find the extension on the marketplace. Please consider publishing your extension on
https://open-vsx.org/

Okay, thank you for letting me know about VSCodium!


fix: MD030/list-marker-space

Replace multiple spaces after number list starts
Find: ^(\d+).
Replace: $1.
Filter: *.md

This LGTM @nschonni
Thanks for adding the regex you used. I could validate it in VSCode as a second quick review. 😀
I also browsed the review site, and checked for any new warnings. Everything is good. I'll :shipit: now.


Modified ambiguous docstrings for hash_password function.

Hi Sjoerd,
It took a while till I understand how does hash_password function work. I just left small changes on docstrings. I also tried to manipulate with bytes instead of string, but it does not make sense
https://gist.github.com/olivernadj/33f9f02da684508430611c3c63c143bb
Thanks for your solution.
Cheers,
Oliver

It replaces 0 by c in the hex string, but only when it is the first character in a pair.
After the first line, password_md5 is a string that contains something like this:
30d604be46e1ba6b54388a671c09accb

The loop loops over all pairs of two hex digits: 30, d6, 04, be, etc. If the first character of the pair is a zero, it replaces it with c:
30d6c4be46e1ba6b54388a671cc9accb

Normal MD5, except add 0xc0 if a byte of the digest is less than 0x10.

This is indeed correct in the context of a binary digest. However, I consider it as a string and then I don't really add 0xc0.

OK, let me close the request.
Thanks for the answer.


fix: return value from updateMd5CacheItem

Return a value so that a second call to updateMd5CacheItem on the
stored promise is given the input the first call received to keep from
throwing an error.

It seems like this pull-request at least partially solves some of the issues users are having in #416, we got some reports from Next.js users too (Next.js now uses hard-source-webpack-plugin since version 7). @mzgoddard could you release this patch / is there anything I can do to help?

+1

There's a non-trivial amount of tests failing on CI, which I imagine is the cause for blocking here. If someone can fix the build that would probably unstick this PR. I don't know if @mzgoddard has any quick insights on what might be causing the test failures before anyone else dives in though?

any updates on this?

any updates?


Fix documentation for syntax collections in SwiftSyntaxBuilderGeneration

The Swift translation ofNode.documentation (from the Python version) generates empty documentations for syntax collections without a documentation, which previously generated the description of its element type as a fallback. This small patch fixes this slight mistranslation.

@swift-ci please test


Geometry library and isLocationOnEdge()

Is there any way I can integrate this plugin with the geometry library provided by Google Maps? I need to detect if some points are in the best route between 2 points returned by DirectionsRequest().
I'm a little lost here

You need to modify the AssetBundle: https://github.com/2amigos/yii2-google-maps-library#configuration add 'libraries' => 'geometry' to it.

Wow man, thanks for the ultra quick response but unfortunately I'm still a little bit lost.
Let me explain. I tried first drawing the polyline using the directionService like so:
First I Geocode the origine and end location for the path and after that I draw the polyline on the map but after the line is successfully drawn on the map, how can I have a reference to it so I can perform the geometry function on it?
`/CONFIGURANDO EL MAPA/
$coord = new LatLng(['lat' => 39.720089311812094, 'lng' => 2.91165944519042]);
$map = new Map([
'center' => $coord,
'zoom' => 14,
]);
// lets use the directions renderer
$home = new LatLng(['lat' => 39.720991014764536, 'lng' => 2.911801719665541]);
$school = new LatLng(['lat' => 39.719456079114956, 'lng' => 2.8979293346405166]);
$santo_domingo = new LatLng(['lat' => 39.72118906848983, 'lng' => 2.907628202438368]);
//veamos si funciona el geocoding:
$origen = "Los Militares 4915";
//$geo = new GeocodingClient();
$geo_coding_client = new GeocodingClient();
$lookup_response = $geo_coding_client->lookup([
'address' => $origen,
'region' => "Chile",
]);
// The lookup response can return more results or even return errors if the location can't be found,
// the following will set the first found result in $lat and $lng variables
$lat = isset($lookup_response->results[0]->geometry->location->lat) ? $lookup_response->results[0]->geometry->location->lat : null;
$lng = isset($lookup_response->results[0]->geometry->location->lng) ? $lookup_response->results[0]->geometry->location->lng : null;
if (!is_null($lat) && !is_null($lng)) {
$origen_LatLng = new LatLng([
'lat' => $lat,
'lng' => $lng,
]);
}
$destino = "Via Roja 9215, Lo Curro";
$geo_coding_client = new GeocodingClient();
$lookup_response = $geo_coding_client->lookup([
'address' => $destino,
'region' => "Chile",
]);
// The lookup response can return more results or even return errors if the location can't be found,
// the following will set the first found result in $lat and $lng variables
$lat = isset($lookup_response->results[0]->geometry->location->lat) ? $lookup_response->results[0]->geometry->location->lat : null;
$lng = isset($lookup_response->results[0]->geometry->location->lng) ? $lookup_response->results[0]->geometry->location->lng : null;
if (!is_null($lat) && !is_null($lng)) {
$destino_LatLng = new LatLng([
'lat' => $lat,
'lng' => $lng,
]);
}
$directionsRequest = new DirectionsRequest([
'origin' => $origen_LatLng,
'destination' => $destino_LatLng,
'travelMode' => TravelMode::DRIVING
]);
// Lets configure the polyline that renders the direction
$polylineOptions = new PolylineOptions([
'strokeColor' => 'red',
'draggable' => false
]);
// Now the renderer
$directionsRenderer = new DirectionsRenderer([
'map' => $map->getName(),
'polylineOptions' => $polylineOptions
]);
// Finally the directions service
$directionsService = new DirectionsService([
'directionsRenderer' => $directionsRenderer,
'directionsRequest' => $directionsRequest
]);
$map->display();
//the map displays the polyline but I dont have any reference to it so I can't perform geometry functions
`

All the objects do have the option for you to set  up its name. Like for example, the DirectionsService: https://github.com/2amigos/yii2-google-maps-library/blob/master/services/DirectionsService.php#L94
Once you setup its name, you could access to it by using the Map::appendScript function https://github.com/2amigos/yii2-google-maps-library/blob/master/Map.php#L377
For example, if you named the direction services like ds, the script will render var ds=, so on your appended script, you could reference the service as: $map->appendScript('ds.whatever'); Hope it helps

Check here... it will also give you a clear hint: https://github.com/2amigos/yii2-google-maps-library/blob/master/services/DirectionsService.php#L87


Updating Microsoft owner

Docs Build status updates of commit c31bdd0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/using-the-windows-device-portal.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


kong no exec health check

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
kong 2.6
Current Behavior
When the upstream service is restarted, the kong gateway does not perform a health check, then restart the kong gateway and find that the health check is normal
Expected Behavior
Proper execution of health checks
Steps To Reproduce
1 Start kong gateway, control node, data node
2 Launch upstream business services
3 Health testing can be performed correctly at this time
4 stop of upstream business services
5 At this point kong gateway is not performing health checks

Anything else?
1

Have you configured active health checks in Kong?
If so, can you share the configuration of the "Upstream" resource in Kong?

try update to 2.8.1 ? There were some bugs in active health check before 2.8.1

thanks


Only call Molecule.from_openff_molecule if 'attributes' not present in Dataset.add_molecule kwargs

Currently, we observe failures when calling Dataset.add_molecule when feeding in molecule=None, whereas this was permitted previously.
This appears due to the use of kwargs.pop, with MoleculeAttributes.from_openff_molecule(molecule=molecule) as the default value. This gets called even if 'attributes' is present as a key in the dictionary. This PR separates these operations to avoid this call.
Status

[ ] Ready to go

@jthorton this is currently blocking qca-dataset-submission validation. I will temporarily change validation there to use this branch instead.

@dotsdl Thanks for fixing this I did not realise that the default statements were evaluated as well Ill add a test to ensure I don't break this again and then merge!


YAML editor folding while editing doesn't remember where it folds

Spotted by Vince and Darren: if you edit some yaml where part of the document is "folded" (a bunch of lines for a child object collapsed into a <-> icon)  and unfold it keeps forgetting the fold state or editing stops working or other weird things. This makes using the feature annoying.

Likely a long-used 3rd party library.

Guess I reported my issue to the wrong place https://github.com/rancher/rancher/issues/32354, I'll close it in favor of this one. I would very much like to see this fixed. Even back ported to 2.5.9 if possible.

Test report:

issue reproduced successfully on rancher/rancher:v2.5.8
issue validated as fixed on rancher/rancher:master-head 4d18400:

Closing.

FWIW, the gif given doesn't demonstrate that this is fixed.

@ekristen I was using reproducer from PR:
To reproduce

1. Nav to a DaemonSet's Edit Yaml page (ensure that the annotations section is initially collapsed)
2. Edit any of the yaml (for instance add a new property at the top)
3. Try to expand the annotations section, which fails and section remains collapsed

I was able reproduce this issue on 2.5.8 by following ^ and wasn't able on master-head.

Interesting.
I was unaware there were multiple different symptoms. My bad.
My version of this issue is expand annotations section then attempt to edit by adding a new one and it'll always collapse.

This does also fix editing inside the annotations block as well as around it. To be clear though, you were seeing the annotations section automatically collapse after editing it's content?

Sweet.
To clarify, during editing, while both editing a value or adding a new annotation it would periodically just collapse.
Usually not saving changes.


AsyncCommand

Description of Change
Async implementation of ICommand.
Based on MVVM Helpers and AsyncAwaitBestPractices.
Bugs Fixed

Fixes #272

API Changes
public interface IAsyncCommand<in T> : ICommand
{
    /// <summary>
    /// Allow simultaneous/re-entrant execution of async Command. This is reflected on CanExecute result.
    /// Default value is False.
    /// </summary>
    bool AllowMultipleExecution { get; set; }

    /// <summary>
    /// Executes the Command as a Task
    /// </summary>
    /// <returns>The Task to execute</returns>
    /// <param name="parameter">Data used by the command. If the command does not require data to be passed, this object can be set to null.</param>
    Task ExecuteAsync(T parameter);

    /// <summary>
    /// Raises the CanExecuteChanged event.
    /// </summary>
    void RaiseCanExecuteChanged();
}

public interface IAsyncCommand : IAsyncCommand<object>
{
}

internal WeakEventManager added until it becomes public on XF.
Behavioral Changes
None
PR Checklist

[x] Has tests (if omitted, state reason in description)
[x] Has samples (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Changes adhere to coding standard
[ ] Updated documentation

Seems like a test is failing on this one :)

yes but I don't understand why, the test seems correct and pass locally

Hm that's weird. I don't see any other details than that the assert failed as well.
Additionally, I have added and assigned @brminnick to this and help you move this forward. I think we kind of had a mix up in the issue proposing this. Which is definitely my fault since I already approved the implementation of it and everything :)
Anyway, Brandon is kind of an expert on this stuff and has done a lot of research on the async bits. So he'd like to review this and work with you to add his improvements to this if that's OK with you. Hopefully he also has an idea about the failing test 😬

Need to find what's wrong with AsyncCommand_Tests.Execute_NoParameter

Hey Gang - don’t worry about the WeakEventManager implementation.
I’ll be porting the WeakEventManager implementation from AsyncAwaitBestPractices which is more performant and more feature-complete.  and

@brminnick maybe bring your WeakEventManager optimizations into Xamarin.Forms?

@brminnick maybe bring your WeakEventManager optimizations into Xamarin.Forms?

Afaik Xamarin.Forms is putting a lock on itself really soon (with v5.0). I think the deadline for this kind of stuff has passed if I'm not mistaking.

@brminnick maybe bring your WeakEventManager optimizations into Xamarin.Forms?

I’ve previously chatted with the Xamarin.Forms team about porting AsyncAwaitBestPractices.WeakEventManager to Xamarin.Forms, but we decided that it was outside the scope of the cross-platform UI framework.

FYI now the XF WeakEventManager is public see

Ha! Well that complicates things.
Xamarin.Forms.WeakEventManager will be public in Xamarin.Forms v5.0.
Since XamarinCommunityToolkit has a dependency on Xamarin.Forms v4.5, we won’t be able to leverage Xamarin.Forms’ implementation internally until/if we increase the Xamarin.Forms dependency to v5.0.
After/if we increase the minimum dependency to Xamarin.Forms v5.0, we’ll be able to leverage Xamarin.Forms.WeakEventManager and we can use AsyncAwaitBestPractices’ implementation to extend it, adding support for more event types, e.g. EventHandler<T>, Action and Action<T>.
I’ll open an issue to track this so that we don't forget 👍

Great work everyone! Reading back on all of this, where are we with the status? Is this ready to be reviewed? Are things still going to change?

@jfversluis More code is still coming.
I still need to incorporate additional unit tests, features & performance improvements from AsyncAwaitBestPractices which I'll have completed by the end of the week.

@YZahringer When you get a chance, can you merge my PR?
I opened this PR onto Zahringer:async-command which should then be reflected in this Pull Request:
https://github.com/YZahringer/XamarinCommunityToolkit/pull/1

@YZahringer Brought up a good point about having a type-safe CanExecute
What do folks think about also adding the following API to AsyncCommand?
public class AsyncCommand<TExecute, TCanExecute>
{
	public AsyncCommand(
		Func<TExecute, Task> execute,
		Func<TCanExecute, bool> canExecute = null,
		Action<Exception> onException = null,
		bool continueOnCapturedContext = false,
		bool allowsMultipleExecutions = true)
}

Because the paradigm of ICommand doesn't require Execute to use the same parameter type as CanExecute, creating this type-safe ICommand would allow for the following scenario:
public ICommand PullToRefreshCommand { get; } = new AsyncCommand<int, bool>(count => FetchNewData(count), isBusy => !isBusy)

Ready for review!
I've added both IAsyncCommand<TExecute, TCanExecute> and IAsyncValueCommand<TExecute, TCanExecute>
@jfversluis Where should I add the documentation?

@YZahringer could you please fix merge conflicts?

Almost 4k of new lines xD

build failed
Can it be related to adding netstandard2.1 to csproj file @brminnick ?

The windows build is succeeding, but the macOS build is failing.
I've pinged @jfversluis about it to see if I can get write-access to the Azure DevOps Pipeline to fix the macOS build.

Fixed the failing macOS CI Build by increasing the .NET Core version for the Unit Test step from v2.2 to v3.1 ✅
This PR is ready to merge pending reviews!


feat: ruby-kafka instrumentation

Todo:

[x] Getting kafka working in ci
[x] Add readme
[x] Add examples
[x] Configure appraisals and minimum version supported
[x] Test with consumer

Not blockers:

I find all the little event subscriber modules unnecessarily wordy. It seems like we could perform all the subscriptions in OpenTelemetry::Instrumentation::RubyKafka::Instrumentation.subscribe without all the additional modules. 🤷
Should all the events really be spans? Might they be better as ... events?

Updated to use links in this commit https://github.com/open-telemetry/opentelemetry-ruby/pull/476/commits/8a1ef1b15af53b1e636e4b35f01a84706f23f237


Improvement - Return Transaction object after purchase

The plugin doesnt return the transaction object after successful transaction.
It would be useful if the transaction object is also returned. This way, the app could record the relevant details in its backend.

This would be more consistent with storekit, but also a breaking change.


REL: bump to version 0.6.11

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] (not applicable) Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


add selenium tests for 2 new entity (sub)types

We need 2 more selenium tests for publication collection and publication datasets details page.

PR


Meson: install libpsl man page, DAFSA builder

Partially addresses issue #136, at least when building from a distribution tarball.
Note: Homebrew builds libpsl from a tarball using Meson:
https://github.com/Homebrew/homebrew-core/blob/0d0eb30/Formula/libpsl.rb
Thus, macOS users using Homebrew don't get man pages or the DAFSA builder. As of now, Homebrew is building from the 0.21.1 release, which doesn't have the fix for #156, so the psl utility isn't available on macOS either. If this is accepted, I suggest cutting a 0.21.2 release including this fix and #158 so that Homebrew can have a new release tarball to build from. I'm happy to submit the Homebrew formula patch.

Coverage remained the same at 93.625% when pulling 62081a021f7cf5c7e4e8c0fa8170731ba522d0c2 on SteelPangolin:meson-install-more into 6a5e41edc5141189c55ecd88169465e807dcacc7 on rockdaboot:master.

Coverage remained the same at 93.625% when pulling 62081a021f7cf5c7e4e8c0fa8170731ba522d0c2 on SteelPangolin:meson-install-more into 6a5e41edc5141189c55ecd88169465e807dcacc7 on rockdaboot:master.

Hey, thanks, LGTM.

Hey, thanks, LGTM.

It's not in the source tree, but it does get built by the automake build
and included in release tarballs. It works if you build with Meson from a
tarball, but I think you're correct that this would break building with
Meson directly from a Git checkout. Basically, issue #136 is still an issue.
On Tue, Jan 26, 2021 at 02:44 Ignacio Casal Quinteiro <
<EMAIL_ADDRESS>wrote:

@nacho commented on this pull request.
In docs/libpsl/meson.build
https://github.com/rockdaboot/libpsl/pull/167#discussion_r564415499:

@@ -0,0 +1 @@
+install_man('libpsl.3')

this is wrong no? this file does not exist
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rockdaboot/libpsl/pull/167#pullrequestreview-576227036,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHJIHOGM5VETCJMNBV4KJ3S32MJNANCNFSM4WDK24MQ
.

It's not in the source tree, but it does get built by the automake build
and included in release tarballs. It works if you build with Meson from a
tarball, but I think you're correct that this would break building with
Meson directly from a Git checkout. Basically, issue #136 is still an issue.
On Tue, Jan 26, 2021 at 02:44 Ignacio Casal Quinteiro <
<EMAIL_ADDRESS>wrote:

@nacho commented on this pull request.
In docs/libpsl/meson.build
https://github.com/rockdaboot/libpsl/pull/167#discussion_r564415499:

@@ -0,0 +1 @@
+install_man('libpsl.3')

this is wrong no? this file does not exist
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rockdaboot/libpsl/pull/167#pullrequestreview-576227036,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHJIHOGM5VETCJMNBV4KJ3S32MJNANCNFSM4WDK24MQ
.


[Release helper] Find right release request issue author

fixes https://github.com/Azure/azure-sdk-tools/issues/8500
The PR is mainly to find right issue author:

/check-enforcer override


spinel: Introduce PROP_HOST_POWER_STATE

Introduces a new core property (PROP_HOST_POWER_STATE) which is used
by the host to inform the NCP of the power state of the host.
The NCP can then use this state to determine which properties need
asynchronous updates. The states are defined in similar terms to
those used for the PROP_POWER_STATE property.

LGTM


It seems that render() works even inside thread.

It seems that render() works even inside a thread. Just remember to get rid of the exception by removing the following lines:
https://github.com/Kautenja/nes-py/blob/b6f4e26a96cf1dc2329b3b45b9f785dd7dbb30c6/nes_py/_image_viewer.py#L25-L28
A sample code is shown below:
import os
os.environ['OMP_NUM_THREADS'] = '1'

import threading
import gym_super_mario_bros
from gym_super_mario_bros.actions import SIMPLE_MOVEMENT
from nes_py.wrappers import JoypadSpace

def dummy_fun(steps):
    import numpy as np
    rng = np.random.default_rng(steps)
    sum = 0.0
    for _ in range(steps):
        rfloat = rng.random()
        sum += rfloat
    print(f'sum {sum}')

def do_something(steps):
    print('inside do_something')
    env = JoypadSpace(gym_super_mario_bros.make('SuperMarioBros-1-1-v0', new_step_api=False), SIMPLE_MOVEMENT)
    done = True
    for _ in range(steps):
        if done:
            state = env.reset()
        state, reward, done, info = env.step(env.action_space.sample())
        env.render()
    print(f'state shape {state.shape}')
    env.close()

def main():
    steps = 5000
    thread1 = threading.Thread(
        target=dummy_fun,
        args=(
            steps,
        ),
    )
    thread1.start()

    thread2 = threading.Thread(
        target=do_something,
        args=(
            steps,
        ),
    )
    thread2.start()

    thread1.join()
    thread2.join()

if __name__ == '__main__':
    main()

Below is the screenshot:

I created a pull request. let me know if additional checking is required:
https://github.com/Kautenja/nes-py/pull/92


Enable attachments based on site configuration for Welcome screen

Show attachment button on secure welcome screen based on fetched site configuration.
MOB-1876

!squash

!merge


Revamp design page

Description
This PR revamps the Design section of the documentation as follows:

Adds a new subsection called Services to the sidebar
Adds an updated Druid architecture diagram
Moves "Storage design" section out of design.md and into its own topic
Moves "Query processing" section out of design.md and into its own topic
Consolidates the information in "Design" and "Processes and servers" topics
Removes "Processes and servers" topic from the sidebar
Replaces "process" with "service"
Adds a redirect for processes.md

Preview
https://druid-98c2egkpg-katyamacedo-bigcommerce.vercel.app/docs/latest/design/architecture
This PR has:

[x] been self-reviewed.

Looks like the word Historicals is misspelt on the architecture diagram.
@ektravel If you have the source image handy, It would be great if you could fix this.

@a2l007 Thank you for bringing it to my attention. I will update the source image.


project3-srs-submission

Feature Template
Related Issues/Tasks

[ ] #1
[ ] #2

Scenario (test)

[ ] Step 1
[ ] ...
[ ] Expected result

User Story Template

As a ...
I want ...
So that ...

Bug Template
Expected behavior
Actual behavior
Steps to reproduce the behavior
Project Submission Template
Iteration page: here
Checklist, e.g.,:

[ ] Feature scenarios/tests passing
[ ] Iteration page updated, including:

[ ] Iteration retrospective
[ ] Code reviewes
[ ] Client review
[ ] Issues updates
[ ] Section on application of course materials

[ ] git tag
[ ] Next iteration:

[ ] Open page
[ ] Select stories and plan issues
[ ] Test scenarios

[ ] All engineers filled peer-review
[ ] Submitted

[ ] Announcement in chat room
[ ] Assign this issue to checker
[ ] Register for a review meeting

hi @kob-e we opened the issues a bit late because we didn't know that you should open an issue after you finish a task (you can see that we did the first task on time) we don't really understand how an issue should look like se we didn't edit it

The deadline for this assignment is next Sunday
On Mar 22, 2017 11:49 AM, "itai00"<EMAIL_ADDRESS>wrote:

hi @kob-e https://github.com/kob-e we opened the issues a bit late
because we didn't know that you should open an issue after you finish a
task (you can see that we did the first task on time) we don't really
understand how an issue should look like se we didn't edit it
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/batz91/Tlushi/issues/3#issuecomment-288348030, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA9nVyAtkArqzMpKPnsPTApf9_XGk84Sks5roO6PgaJpZM4Mk70N
.

@kob-e לבדיקה

@kob-e  בדקת לנו את התרגיל הזה?