[MINOR][DOCS] Add jira url in pull request description

What changes were proposed in this pull request?
For more detailed discussion, please review:

SPARK-XXX

(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Merged build triggered.

Merged build started.

Test build #72845 has started for PR 16920 at commit e61125a.

Test build #72845 has finished for PR 16920 at commit e61125a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72845/
Test FAILed.

Merged build finished. Test FAILed.

cc @srowen

Test build #72910 has started for PR 16920 at commit 375f35e.

Test build #72910 has finished for PR 16920 at commit 375f35e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72910/
Test PASSed.

Why is this necessary? It seems like an extra step needed and doesn't provide any real information.
I suggest you use this: https://chrome.google.com/webstore/detail/jirafy/npldkpkhkmpnfhpmeoahhakbgcldplbj?hl=en

@rxin just a fast link to jira :)

Yea the only issue is that it requires another manual update. Why not use the chrome plugin I sent?

Oh, if this is asking people to repeat the JIRA link in the description, then, no I don't agree with that.

@rxin cool, Jirafy is enough.


SOVERSION decreased from 12 to 11 in 4.4.1-RC2

The SOVERSION was increased to 12 in 4.4.1-RC1 with these changes in CMakeLists.txt & liblib/Makefile.am (83f1e01409aeb50d4b1820e382985c3ab42741e2):
-SET(netCDF_LIB_VERSION 11.0.0)
-SET(netCDF_SO_VERSION 11)
+SET(netCDF_LIB_VERSION 12.0.0)
+SET(netCDF_SO_VERSION 12)

-libnetcdf_la_LDFLAGS = -version-info 11:0:0 ${NOUNDEFINED}
+libnetcdf_la_LDFLAGS = -version-info 12:0:0 ${NOUNDEFINED}

This SONAME bump was correct because several symbols available in earlier versions were removed, as documeted in the changes to the Debian package symbols file
4.4.1-RC2 reverted the SOVERSION back to 11 with commits 10f85caf265efa66e3cc36b6f02f3de3ed8c588d, 595474d71bb3968c584c5994c5415b78d60723aa & 287e73ca2621dd61045ddeb7a5f837a35f4053fc.
Based on the symbols changes, the SONAME bump was correct and did not need reverting. Case 3 from the libtool manual is applicable:

Programs may need to be changed, recompiled, and relinked in order to use the new version. Bump current, set revision and age to 0.

All the changed/deleted symbols are not externally usable; only the symbols
defined in include/netcdf*,h are available for use by library users. I would have said
that only changes to that set of files need to be considered for SONAME bump. Ward?

None of the libnetcdf reverse dependencies in Debian are using any of the removed symbols (all confined to ncdispatch.h), so the SONAME bump is indeed not strictly required.
I think it's safe to close this issue and leave the SONAME as it is in 4.4.1 RC2.


Ensure SlipStream version cannot be overwritten

It should be driven by the build system only

This was done.


bruno: 1.14.0 -> 1.16.0

Description of changes
https://github.com/usebruno/bruno/releases/tag/v1.15.0
https://github.com/usebruno/bruno/releases/tag/v1.16.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 307852 run on x86_64-linux 1

1 package built:

bruno

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 307852 run on x86_64-linux 1

1 package built:

bruno


0001 check that handler has been processed to avoid race condition

There was an occasional flaky behaviour on some endurance test due to a delayed update event coming from appendInit who is triggering the appendBufferFinished() handler in appendUntil() ahead of time. So a delayed dispatching of update events is generating a race condition on appendInit.
A change on the test would make appendBufferFinished() ignore update events coming before the initializer call to startAppendBuffer() to fix the issue.
INVALID_STATE_ERR: DOM Exception 11: An attempt was made to use an object that is not, or is no longer, usable.
Endurance Tests with this error

InfiniteAVLoopTiny?
InfiniteAVLoopNormal?
InfiniteAVLoopHuge?

I wasn't able to reproduce this issue on any of the endurance tests. I don't want to accept this change since appendUntil is used throughout the MSE testsuite. It's hard to determine the impact of this change throughout the rest of the tests. I would be happier if you can narrow down the cause of this issue and structure the fix so the event dispatch works as you think it should. Either that or fix the issue directly in the endurance tests themselves.


Replace CITATION.bib with CITATION.cff for better GitHub integration

Replaced the existing CITATION.bib file with a CITATION.cff file to leverage GitHub's native citation support. The CITATION.cff file provides both human- and machine-readable citation metadata, allowing users to easily cite the repository in formats like APA and BibTeX directly from GitHub's "Cite this repository" feature.
The new CITATION.cff includes:

Author details
Title, DOI, and URL
Book title and conference details
Keywords and abstract

This change aligns with modern citation practices for software and academic works on GitHub. See:

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files

Hmmm I get this weird warning I can't seem to get rid of, while the CFF seems to be formatted correctly.

The issue might be that it isn't present on the main branch, but not sure.

Thanks! There's a link to the removed .bib file in README. Shall we change it to point to the "Cite this repository" feature instead?


Add Avian2D Support

Close #14
This PR adds physics/avian.rs as an alternative to rapier. Avian2D was added as another optional feature and all the #[cfg(feature = "rapier")] were either updated to #[cfg(any(feature = "rapier", feature = "avian"))] or the avian conditional was added right after.
All the rapier examples were replicated with the avian version as well.
In the properties/event.rs the function spawn_rapier_collider was generalized to spawn_collider since now it can either be rapier or avian.

Seems very good, thank you so much! :)
I'll have a closer look tonight and merge + release if it's OK

Code seems to work, however CI does not like having the same public functions being defined twice :(
(and I'm not sure why I had to manually trigger it)
Would it be possible to rename public functions in src/physics/rapier.rs to insert_XXX_rapier_colliders and public functions in src/physics/avian.rs to insert_XXX_avian_colliders ?
We could then define functions insert_object_colliders and insert_tile_colliders in  ./src/physics/mod.rs which will call either backend based upon feature flags (simple pass-through functions).
This way, you won't have to rename everything in the other places.
Also, could you please add the new examples in examples/README.md ?
Thanks!

Code seems to work, however CI does not like having the same public functions being defined twice :( (and I'm not sure why I had to manually trigger it)
Would it be possible to rename public functions in src/physics/rapier.rs to insert_XXX_rapier_colliders and public functions in src/physics/avian.rs to insert_XXX_avian_colliders ? We could then define functions insert_object_colliders and insert_tile_colliders in ./src/physics/mod.rs which will call either backend based upon feature flags (simple pass-through functions). This way, you won't have to rename everything in the other places.
Also, could you please add the new examples in examples/README.md ?
Thanks!

Working on it!

Clippy now was happy locally @adrien-bon

Seems good! I'll merge and do the release.
Thank you very much! :)


Bump actions

Codecov Report
Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 52.73%. Comparing base (9db2ed0) to head (b501c50).
Report is 1 commits behind head on main.

Files
Patch %
Lines

internal/cli/images.go
0.00%
1 Missing :warning:

pkg/file/file.go
66.66%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #51    +/-   ##
========================================
  Coverage   52.73%   52.73%
========================================
  Files          10       13     +3
  Lines         603      730   +127
========================================
+ Hits          318      385    +67
- Misses        233      278    +45
- Partials       52       67    +15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


sqlite3 command not found | db_dump.sql not tracked (should it be??)

/usr/local/bin/my-pihole-lists$ sudo /usr/local/bin/pihole-cloudsync/pihole-cloudsync --push
--push option detected. Running in Push/Upload mode.
/usr/local/bin/pihole-cloudsync/pihole-cloudsync: line 99: sqlite3: command not found
Local Pi-hole lists are different than remote Git repo. Updating remote repo...
On branch master
Your branch is up to date with 'origin/master'.
Untracked files:
(use "git add ..." to include in what will be committed)
db_dump.sql
nothing added to commit but untracked files present (use "git add" to track)
Done!

you probably don't have sqlite3 installed. Try running sqlite3 --version and if not found run apt install sqlite3

you probably don't have sqlite3 installed. Try running sqlite3 --version and if not found run apt install sqlite3

Thanks @hamah99
Yep, that solved the sqlite issue. Now just need to work through whether db_dump.sql should be tracked by git or not
(I'm fairly new to GIT and unfortunately not a developer for my day job)

you probably don't have sqlite3 installed. Try running sqlite3 --version and if not found run apt install sqlite3

Thanks @hamah99
Yep, that solved the sqlite issue. Now just need to work through whether db_dump.sql should be tracked by git or not
(I'm fairly new to GIT and unfortunately not a developer for my day job)


average_reviewers_per_pull

Let's add average_reviewers_per_pull metric to the quality-of-service.rb script. It should calculate the average number of people who post their comments in a pull request (not only review authors, but all people, including bots).

@Yegorov sure, go ahead please


TypeError: e.join is not a function

I tried to use logatim (nodejs v5.5) but it gives an error:
$ npm install logatim
$ node
> const logatim = require('logatim');
undefined
> logatim.warn('oops')
TypeError: e.join is not a function
    at a (/home/jos/tmp/node_modules/logatim/dist/logatim.umd.min.js:1:3955)
    at i (/home/jos/tmp/node_modules/logatim/dist/logatim.umd.min.js:1:3818)
    at s (/home/jos/tmp/node_modules/logatim/dist/logatim.umd.min.js:1:3729)
    at repl:1:9
    at REPLServer.defaultEval (repl.js:252:27)
    at bound (domain.js:287:14)
    at REPLServer.runBound [as eval] (domain.js:300:12)
    at REPLServer.<anonymous> (repl.js:417:12)
    at emitOne (events.js:95:20)
    at REPLServer.emit (events.js:182:7)
>

Am I overlooking something obvious?

Damn! You're right. While making the styles I forget to check if the output without styling was good.
Really appreciate it. Now it's fixed here cd56fdf34e531d445010b9dbc3224317edda969d
I'm closing the issue since the new tests are passing. However, feel free to comment anything related to this ;)

Thanks for the quick fix!


GitLens hovers no longer work in latest insiders

Issue Type: Bug
With the latest insiders, none of the GitLens hovers work anymore -- though normal hovers seem to be unaffected.

VS Code version: Code - Insiders 1.39.0-insider (bdd1971f2cd9d08a8a90e02740f1850afe03da66, 2019-09-17T06:02:08.670Z)
OS version: Windows_NT x64 10.0.18980

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (18.88GB free)

Process Argv
--enable-proposed-api eamodio.remotehub

Screen Reader
no

VM
0%

It does work for me and I'm on the same commit:

Why does your process argv include --enable-proposed-api eamodio.remotehub though? I don't think that's the cause, just asking.

@octref It looks like this was caused by Live Share. If I remove Live Share all is fine -- and if I re-install it it breaks. Probably because it seems to be infinitely downloading dependencies -- and I see this in the console:

I have that in my args, because RemoteHub has more features with proposed apis :)

Do you mind opening an issue at https://github.com/MicrosoftDocs/live-share then?

Looks like one is already opened - https://github.com/MicrosoftDocs/live-share/issues/2815. I'll close this out now


Get started c++

This is a 'port' to C++ of GettingStartedInPython.  It follows the Python text closely, in terms of content and examples.  A set of complete example programs are included to complement the snippets in the text.  It is not complete - it only goes up to the end of 'Substructure Searching' but I think that's a useful start.
It needs work to allow it to be incorporated into the build process.  At present, for example, the CMakeLists.txt is standalone and is only known to work on a Ubuntu 16.04 machine.
A certain amount of editorialising has crept in, and there is some speculation in places on the difference between the C++ and Python APIs that warrant checking by someone more skilled in the art.
Apologies for the fact that I learnt about 'git rebase' too late to take out some of the spurious intermediate commits.
Oh, and there are 2 changes in MolDraw2D that cropped up in testing that really should be on a separate branch. Sorry about that. I would guess that no one has ever used MolDraw2DQt.

Nice work!

@DavidACosgrove don't worry about "git rebase" we squash the whole thing into one commit usually.

It'll take me a while to work through all the comments, and I'm really busy
at the moment.  I expected the CMakeLists.txt to have to change to fit into
the existing build system, but I didn't know how to do that, so I just
hacked something together to make the examples build for me as I was going
along.  The '-std=c++11' flag is required so that example7.cpp compiles,
but was just a) laziness on my part, not wanting to have to figure out the
iterator types for the rings b) anticipation of the new version of RDKit in
defence of a)!
Qt 5.7 at least (I haven't gone further back to see when it first came in)
does need '-std=c++11'
I'll try and work through the corrections/suggestions over the next week or
so, but I'm afraid it'll be slow.
Dave
On Tue, Feb 7, 2017 at 7:17 AM, Greg Landrum<EMAIL_ADDRESS>wrote:

@greglandrum requested changes on this pull request.
I'm going to go ahead and submit this review without having read the .md
document yet. I just looked at the C++.
This was a ton of work and I think it will really help people get to
speed. Thanks for the contribution Dave!
In Code/GraphMol/MolDraw2D/CMakeLists.txt
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -25,6 +25,7 @@ if(RDK_BUILD_QT_SUPPORT)
set(QTDRAW2D_SRC MolDraw2DQt.cpp)
set(EXTRA_LOCAL_LIBS ${EXTRA_LOCAL_LIBS} ${Qt5Widgets_LIBRARIES}  ${Qt5OpenGL_LIBRARIES} )
rdkit_headers(MolDraw2DQt.h DEST GraphMol/MolDraw2D)

SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")

Is C++11 mandatory for Qt?
In Code/GraphMol/MolDraw2D/MolDraw2DQt.h
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -25,7 +25,7 @@ namespace RDKit {
class MolDraw2DQt : public MolDraw2D {
public:
MolDraw2DQt(int width, int height, QPainter &qp, int panelWidth = -1,

         panelHeight = -1);

         int panelHeight = -1);

oof... yeah, you're right, this code hasn't been compiled in a while.
In Docs/Book/C++Examples/CMakeLists.txt
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,37 @@
+cmake_minimum_required( VERSION 2.8.9 )

+project(RDKitSV)
+
+set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}")
+
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11" )
If the code is going to be on the trunk it shouldn't require C++11. The
modern-c++ branch is coming (really!), and we could use this there.
In Docs/Book/C++Examples/CMakeLists.txt
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,37 @@
+cmake_minimum_required( VERSION 2.8.9 )

+project(RDKitSV)
+
+set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}")
+
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11" )
+
+set(Boost_USE_STATIC_LIBS ON)
+set(Boost_USE_MULTITHREADED OFF)
+set(Boost_USE_STATIC_RUNTIME ON)
+find_package( Boost COMPONENTS iostreams filesystem system thread)
+
+find_package( Cairo REQUIRED )
Requiring cairo is a definite restriction on where this can be used. I
assume (I'm reviewing the code in the order that github shows it to me, so
I don't yet know) that this is so that you can create PNGs from the
examples?
In Docs/Book/C++Examples/CMakeLists.txt
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

+find_package( Cairo REQUIRED )
+
+find_package( MyRDKit COMPONENTS FileParsers SmilesParse Depictor RDGeometryLib

RDGeneral SubstructMatch Subgraphs MolDraw2D FileParsers GraphMol DistGeometry DistGeomHelpers
MolAlign Optimizer RDGeometryLib ForceField ForceFieldHelpers Alignment
ForceField ForceFieldHelpers MolTransforms EigenSolvers )

+include_directories( ${RDKIT_INCLUDE_DIR} ${CAIRO_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS})
+message( "${CAIRO_INCLUDE_DIRS}" )
+
+set(EXECUTABLE_OUTPUT_PATH ${CMAKE_SOURCE_DIR})
+
+set( LIBS ${RDKIT_LIBRARIES} ${Boost_LIBRARIES} ${CAIRO_LIBRARIES} z )
+
+foreach( exnum RANGE 1 16 )
Nice. I didn't know this cmake feature
In Docs/Book/C++Examples/FindCairo.cmake
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,81 @@
+# - Try to find Cairo

I'm struggling with this one. There's a version of FindCairo.cmake in
$RDBASE/Code/cmake/Modules and duplicating it feels somehow wrong. I
understand that you're trying to provide a full build system for these
examples, but I don't think this or your FindRDKit.cmake script, is the way
to do it.
I would lean towards setting up the RDKit install process so that it
creates a FindRDKit.cmake and copies the cmake file it uses to some other
install directory (likely in share somewhere) so that they can be used in
client code but we only have to have one copy. I will think about this a
bit more, but it shouldn't be part of this PR.
For this one: I would say pull out the files connected with having your
own build system and make it part of the RDKit builds.
In Docs/Book/C++Examples/FindMyRDKit.cmake
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,37 @@
+# Attempts to find RDKit libraries using the current value of $RDBASE

same comment here about the build system
In Docs/Book/C++Examples/example1.cpp
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,35 @@
+//

I believe these examples shouldn't leak memory. Created pointers in all
the examples. should be deleted, if only to make explicit to people working
with the code which pieces of memory they own.
In Docs/Book/C++Examples/example1.cpp
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

+#include
+#include <GraphMol/GraphMol.h>
+#include <GraphMol/SmilesParse/SmilesParse.h>
+#include <GraphMol/FileParsers/MolSupplier.h>
+
+int main( int argc , char **argv ) {
+

RDKit::ROMol *mol1 = RDKit::SmilesToMol( "Cc1ccccc1" );
std::cout << mol1 << std::endl;

std::string file_root = getenv( "RDBASE" );
file_root += "/Docs/Book";

std::string mol_file = file_root + "/data/input.mol";
RDKit::SDMolSupplier mol_supplier( mol_file , true );

In general I would suggest making calls with optional arguments clearer by
adopting Brian's approach and doing:
bool sanitize=true;
RDKit::SDMolSupplier mol_supplier( mol_file , sanitize );
In this particular case, I don't think the use of an SDMolSupplier to
read a mol file is a good choice. I think it would be better to use
MolFiletoMol
In Docs/Book/C++Examples/example1.cpp
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

+#include <GraphMol/FileParsers/MolSupplier.h>

+int main( int argc , char **argv ) {
+

RDKit::ROMol *mol1 = RDKit::SmilesToMol( "Cc1ccccc1" );
std::cout << mol1 << std::endl;

std::string file_root = getenv( "RDBASE" );
file_root += "/Docs/Book";

std::string mol_file = file_root + "/data/input.mol";
RDKit::SDMolSupplier mol_supplier( mol_file , true );
RDKit::ROMol *mol2 = mol_supplier.next();
std::cout << mol2 << std::endl;

try {

For the next two cases where you expect exceptions: I would make it
explicit (in the catch) what the exceptions should be.
In Docs/Book/C++Examples/example11.cpp
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

+#include <GraphMol/MolOps.h>
+#include <GraphMol/MolAlign/AlignMolecules.h>
+#include <GraphMol/DistGeomHelpers/Embedder.h>
+#include <GraphMol/ForceFieldHelpers/MMFF/MMFF.h>
+#include <GraphMol/ForceFieldHelpers/UFF/UFF.h>
+#include <GraphMol/SmilesParse/SmilesParse.h>

+int main( int main , char **argv ) {
+

RDKit::ROMOL_SPTR mol( RDKit::SmilesToMol( "C1CCC1OC" ) );
RDKit::ROMOL_SPTR mol1( RDKit::MolOps::addHs( *mol ) );
// Original distance geometry embedding
RDKit::DGeomHelpers::EmbedMolecule( *mol1 , 0 , 1234 );
RDKit::UFF::UFFOptimizeMolecule( *mol1 );

// new Riniker and Landrum CSD-based method

This is easier to understand if you use the new EmbedParameters class,
specifically a copy of RDKit::DGeomHelpers::ETKDG. Something like this:
DGeomHelpers::EmbedParameters params(DGeomHelpers::ETKDG);
params.randomSeed = 1234;
DGeomHelpers::EmbedMolecule(*mol, params);

In Docs/Book/C++Examples/example13.cpp
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,33 @@
+//
+// Generating depictions - example12.cpp

picky, but you're off by one with the name here (and in other files below)
In Docs/Book/C++Examples/example8.cpp
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662:

@@ -0,0 +1,21 @@
+//
+// Modifying molecules example8.cpp

+#include
+
+#include <GraphMol/GraphMol.h>
+#include <GraphMol/SmilesParse/SmilesParse.h>
+#include <GraphMol/MolOps.h>
+
+int main( int argc , char **argv ) {
+

RDKit::ROMOL_SPTR mol1( RDKit::SmilesToMol( "CCO" ) );

You do it elsewhere too, but I like this use of smart pointers to avoid
the memory leak problem and to make it explicit that the memory is owned
here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/1285#pullrequestreview-20264662, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIxdFk6AxxBiNJMFGNTnAJhHMXbf7Z_iks5raBqRgaJpZM4L1K5C
.

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

Yes, I need to go through and tidy that all up.
On Tue, 7 Feb 2017 at 13:12, gedeck<EMAIL_ADDRESS>wrote:

@gedeck commented on this pull request.
In Docs/Book/C++Examples/example8.cpp
https://github.com/rdkit/rdkit/pull/1285:

@@ -0,0 +1,21 @@
+//
+// Modifying molecules example8.cpp

+#include
+
+#include <GraphMol/GraphMol.h>
+#include <GraphMol/SmilesParse/SmilesParse.h>
+#include <GraphMol/MolOps.h>
+
+int main( int argc , char **argv ) {
+

RDKit::ROMOL_SPTR mol1( RDKit::SmilesToMol( "CCO" ) );

I've now seen that this is mentioned in the actual document under memory
management.
The code is full of RDKit::ROMol* use. Is it better to use the ROMOL_SPTR
instead for new code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/1285, or mute the thread
https://github.com/notifications/unsubscribe-auth/AIxdFlNXtyZciBXFi42ZIy7N5bXuL0zyks5raG3CgaJpZM4L1K5C
.

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

@DavidACosgrove : let me know when you want me to review this again.

Will do.  When are you planning the 2017.3 release?  I'd like to hit that
if possible with a good margin beforehand.
Dave
On Fri, Feb 10, 2017 at 7:41 AM, Greg Landrum<EMAIL_ADDRESS>wrote:

@DavidACosgrove https://github.com/DavidACosgrove : let me know when
you want me to review this again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/1285#issuecomment-278878230, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIxdFunQrAzxigJyqUyyWYkOyJzF8mMfks5rbBS5gaJpZM4L1K5C
.

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

Optimistically the release should be end of March/early April

I've pushed a new version with the changes as requested, I hope.  Sorry it took so long.  The one thing I have yet to fix is the CMakeLists.txt.  I can't work out how to persuade the build system to pick it up.  Could someone give me a few pointers, and I'll keep at it?

Once the two changes suggested in my review have been made, I think it would also be useful to add a note towards the top of the .md file explaining that this should be viewed as a work in progress.

It's a good point - I guess I lost track of the purpose of the document, as
an introduction to get beginners started.  I've tidied it up, and also
committed the other change you asked for about the pickle filename which
didn't seem to have been included last night.
Dave
On Mon, Mar 27, 2017 at 7:11 PM, Greg Landrum<EMAIL_ADDRESS>wrote:

@greglandrum commented on this pull request.
In Docs/Book/C++Examples/example11.cpp
https://github.com/rdkit/rdkit/pull/1285#discussion_r108240163:

+#include <GraphMol/MolOps.h>
+#include <GraphMol/MolAlign/AlignMolecules.h>
+#include <GraphMol/DistGeomHelpers/Embedder.h>
+#include <GraphMol/ForceFieldHelpers/MMFF/MMFF.h>
+#include <GraphMol/ForceFieldHelpers/UFF/UFF.h>
+#include <GraphMol/SmilesParse/SmilesParse.h>

+int main( int main , char **argv ) {
+

RDKit::ROMOL_SPTR mol( RDKit::SmilesToMol( "C1CCC1OC" ) );
RDKit::ROMOL_SPTR mol1( RDKit::MolOps::addHs( *mol ) );
// Original distance geometry embedding
RDKit::DGeomHelpers::EmbedMolecule( *mol1 , 0 , 1234 );
RDKit::UFF::UFFOptimizeMolecule( *mol1 );

// new Riniker and Landrum CSD-based method

ah, yes, you use it once; I see it now.
I don't see any value in having the full set of parameters show up in a
tutorial document. They are difficult to follow and confusing (and, yes, I
know that I'm responsible for this API...). The parameter class is much
cleaner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/1285#discussion_r108240163, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIxdFnSsgvVSy6ylEBkR7sXx0_xsCJ-pks5rp_vGgaJpZM4L1K5C
.

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

I think this is ready to merge; it's a great starting point.
@bp-kelley : any objections to the merge?


Add possibility to customize coffea-casa/coffea-casa-analysis Dask worker image

For https://github.com/CoffeaTeam/coffea-casa/tree/master/docker/coffea-casa-analysis we will develop probably a solution that will allow easily customise or overwrite exisring in image UNL HTCondor settings

This requires the overhaul of the helm charts which is a different issue.


Accepting Terms for All Images Under One Publisher

Hello,
I tested with the commands and they work great. The issue I have is that the publisher I accepted terms for has up to 50 different images. I'd prefer not to have to accept the marketplace terms per image. Is there a way to accept the marketplace terms as a whole per publisher?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77a1361f-355d-9d60-4733-cd2d0d429985
Version Independent ID: 5d85cdce-c9f0-c36a-486f-a8e3dda6c94f
Content: az vm image terms
Content Source: src/azure-cli/azure/cli/command_modules/vm/_help.py
Service: virtual-machines
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

hi @qwordy could you pls have a look? thanks

Azure CLI doesn't support it yet. It is a reasonable feature ask.


Adding Infinite Scroll in the feed and Progress bar

Description
Currently a user can see only 5 video card so I want to add infinte scroll component so that many video cards could be seen this will enhance the user experience.
secondly, I would like to add progress bar.
Screenshots
No response
Additional information
No response

#112 Please assign me this issue. I have done this type of work in my project.

Issue #95 is currently being addressed, and it pertains to the same matter.


feature(component): Add keyboard controls to ToggleSwitch

Breaking changes
ToggleSwitch now requires:

checked (boolean)
onChange ((checked: boolean) => void)

You can now use Tab to navigate into a ToggleSwitch, and use Space to toggle its state.
Features

[x] Add keyboard controls to ToggleSwitch

Bug fixes

[x] Resolve missing accessible label on Forms docs

Tests
Unit

[x] Add unit tests for form controls, resolves https://github.com/themesberg/flowbite-react/issues/38

Coverage isn't great so I will work on this more.


⚠ Bofrost.de has degraded performance

In 9084bf0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1195 ms

Resolved: Bofrost.de performance has improved in 3ea846a after 13 minutes.


Split k8sutils functions into different pkgs

This PR contains partial changes of #400 that has already been reviewed
This PR moves the runtime-related functions of the package k8sutils to the langruntime pkg and the Controller specific functions to the controller pkg. It also moves the unit tests, increasing the coverage and adding new integration tests for languages with deps.

Landing this since it has already been reviewed and it contains its tests and docs.
Let me know if something else should be addressed.


chore(deps): bump avocano

There's a few other pending dependencies and a release for avocano; I might wait til those merge, update this PR, then merge this.


Use of undeclared identifier 'FIRApp'

I am getting this error with RN 0.40 Xcode 8.2.1. Any idea why?

I am also getting this using v1.0.6 and RN .38

I was able to resolve this by adding
@import Firebase;
To the AppDelegate.m file that includes the [FIRApp configure]; line.

in my case with ionic cordova project I had just add
#import "FIRApp.h"
to  CDVGoogleAnalytics.m file

In AppDelegate.m:
`
// Your import
...
#if DEBUG
`


[WIP] Gpl 773 adding hifi generation

Closes #traction service 509 (https://github.com/sanger/traction-service/issues/509)
Linked with PR in traction-service
Changes proposed in this pull request:
*Added default values to generate hifi
*Removed sequencing mode
*
TODO:
pre extension time default

TODO:

Add NPM


Fix #120 and modified README for images API.

Scroll ability for text
Modified README for images API.

There was some issue with PR sorry for messing up.

No problem.


Track URLs that failed to load because gateway was down.

Is your feature request related to a problem? Please describe.
As part of #1092, we now have capability to reload the pages that failed to load because the gateway was offline. The check involves matching tab titles to validate if the page has content or did it fail. While this works, it won't work with non-english browsers or break in the future because the browsers could change the wording. I would like to improve the functionality to something like what @lidel suggested in the thread.
Describe the solution you'd like

Attach a listener to onErrorOccurred from src/lib/ipfs-request.js.
Add isRecoverableViaOnlineApi which stores failed requests to local gateway in a cache similar to errorInFlight.
Then, I could check if url is present in that cache, removing the need for matching titles.

Describe alternatives you've considered
An implementation using title matching has been provided in #1092.
Additional context

Discussion: https://github.com/ipfs/ipfs-companion/pull/1092#pullrequestreview-1101156516
Follow Up to: https://github.com/ipfs/ipfs-companion/issues/1010
Initial PR: https://github.com/ipfs/ipfs-companion/pull/1092

@lidel can you please assign this to me?


Support to Brazilian Portuguese

Hi, will Metavoice support languages such as Brazilian Portuguese? I've noticed that the fine-tuning code is not available yet. Is it possible to contribute in some way?

Hey @paulovasconcellos-hotmart , we've just https://github.com/metavoiceio/metavoice-src/pull/93 for finetuning the last N transformer blocks of the first stage LLM. Best to play around with the hyperparams in finetune_params.py as we didn't determine the optimal set.
Next step to improve finetuning effectiveness is to have LoRA adapters for the first stage LLM which is being worked on here.

Closing due to inactivity.


Include default endpoints in app build

During flutter build apk add default URL for endpoints to be included in app.

This went in with feat/5-ffi.


Server side Errors on Client side

I tried to register already a registered account,nothing happens on the UI side unless you view it
on console logs,how can we capture these errors on UI side as well?

I’m using the PostJsonAsync extension method which assumes a success response.
If you swap to the standard PostAsync method then you can manage non-success codes, something like this.
var stringContent = new StringContent(JsonSerializer.Serialize(registerModel), Encoding.UTF8, "application/json");
var response = await _httpClient.PostAsync("api/accounts", stringContent);

if (response.StatusCode == System.Net.HttpStatusCode.BadRequest)
{
    // Handle bad request
}


feat: expose loading & unloading function and only auto unload inside components

BREAKING CHANGE

When creating the merge commit message keep in mind that this is a breaking change.


Refactor snapshot for format k8s

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #32
Refactor for https://github.com/kubernetes-sigs/kwok/pull/381#discussion_r1156251789
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Thanks @wzshiming. I will review tomorrow.

/lgtm
Thanks @wzshiming!

Created https://github.com/kubernetes-sigs/kwok/issues/456 to track follow-ups.


Update README.md

What type of PR is this?

correction

What this PR does / why we need it:
Update links as now /blob is no longer part of the raw file URL

@bigludo7 please check if you can approve this, to create rc3. -Thanks


Heap buffer overflow in dssp.cpp

There is a heap overflow bug in dssp.cpp:
If  stop == True then since bool stop = t == dssp.end(); it means that t == dssp.end() and therefore accessing t->ss() will cause a heap buffer overflow.
I think the solution is to move:
if (stop)
  break;

above the if (lastSS != t->ss()) check:
if (stop) {
  break;
}

if (lastSS != t->ss()) {
  st = t;
  lastSS = t->ss();
}

Thanks for pointing this out. It is fixed now.


exception thrown outside of main thread when upload fails

Is this a client library issue or a product issue?

client issue -<EMAIL_ADDRESS>

Did someone already solve this?
no but it's very similar to https://github.com/googleapis/nodejs-storage/issues/1968, perhaps the same solution can be applied here?

Do you have a support contract?
no

Environment details

OS: linux
Node.js version: 16.x
npm version: 8.5.5
@google-cloud/storage version: 6.2.3

Steps to reproduce
unfortunately i can't reliably reproduce it but sometimes we get errors that can't be caught.
our code:
try {
  await storage.bucket(bucket).file(file).save(data, { resumable: false })
} catch(error) {
 // do something here
}

the stack trace
<EMAIL_ADDRESS>in new ApiError at line 79:15
<EMAIL_ADDRESS>in Util.parseHttpRespBody at line 214:38
<EMAIL_ADDRESS>in Util.handleResp at line 155:117
<EMAIL_ADDRESS>in <anonymous> at line 535:22
/usr/src/app/node_modules/retry-request/index.js in onResponse at line 240:7
/usr/src/app/node_modules/teeny-request/build/src/index.js in <anonymous> at line 157:17
<EMAIL_ADDRESS>in runMicrotasks
node:internal/process/task_queues in processTicksAndRejections at line 96:5

and the associated network request:
POST https://storage.googleapis.com/upload/storage/v1/b/BUCKET/o?uploadType=multipart&name=FILENAME [503]

we've seen this ~20 times today

Thank you for reporting this @modosc. I know you said you are not reliable able to reproduce this but is there any other information you could provide, i.e., does this happen more often on data of a certain size threshold? Any particular time of day when it happens more frequently? How many operations are you performing at a time?

this mostly seems to happen in a single endpoint call where we are uploading ~20 different files - each one is around 200kb.
beyond that there's no pattern to when this occurs.

we also get a slightly different version of the stack trace sometimes:
<EMAIL_ADDRESS>in new ApiError at line 79:15
<EMAIL_ADDRESS>in Util.parseHttpRespBody at line 214:38
<EMAIL_ADDRESS>in Util.handleResp at line 155:117
<EMAIL_ADDRESS>in <anonymous> at line 535:22
/usr/src/app/node_modules/retry-request/index.js in onResponse at line 240:7
/usr/src/app/node_modules/teeny-request/build/src/index.js in <anonymous> at line 157:17
node:internal/process/task_queues in processTicksAndRejections at line 96:5

note this one is missing the<EMAIL_ADDRESS>in runMicrotasks line

@ddelgrosso1 thanks for the suggestion, we're adding that option now.

it turns out this wasn't occurring outside of the main thread after all and was just a bug in how we handled error reporting. sorry for the noise!

Thank you for the update @modosc.


Fixes a leak in PotreeWriterRandom.

I converted a 1.8b points in 0.5h with a constant memory usage less that 600MB.

Wow, nice. But rather than fixing a leak, isn't the effect of this change that variables are passed by reference rather than creating a local copy which would still get deleted automatically after leaving the scope?

Yes, I was hunting a leak, but I found a copy by value. And really, I agree that this patch should have had no effect except performance.
But...


Question: Does BigQuery java SDK support Kotlin coroutines?

As the title says, Does BigQuery java sdk reactively hits the query API or not. If not, is there a work around where this support can be added to fetch the data reactively using coroutines or suspend functions?

Thanks for the comment. As of now, the BigQuery java sdk does not support Kotlin routines, and as far as I know there are no plans to support that feature (they are different languages after all). There are talks regarding creating a Kotlin sdk for BigQuery, however. Unfortunately I cannot provide an estimate on when or even if the Kotlin sdk will be released. In the meantime, here are a few links that you might find useful:
Calling Kotlin Suspend Functions from Java
Coroutine Implementation in Java


Open to Work

I'm open to work.

Imagine being stuck in "The Matrix" but with no menial job and no fake steak. 0/10, would not recommend.


Designer - Shows that Teams doesn't support 1.2v

Teams does support 1.2v

@cconrado I can repro this on https://vnext.adaptivecards.io/designer but not on https://adaptivecards.io/designer
I think vNext is a bit out of date, and in any case the main site currently represents the latest. @matthidinger do you know what might be happening on vNext?

@dclaux ah that's right I tried it on vnext.

@matthidinger / @Paulcam206 / @dclaux  - longer term we should get together to try to figure out a story for what and where vnext gets deployed from and for what purpose..

Why don't you guys add a beta branch,
deploy changes to there first and only merge beta -> main?
main -> www.adaptivecards.io
beta -> vnext.adaptivecards.io
Thats what i usually do at least, based on that vnext would always be at least same as main most likely have more things however.

@deejaytc that's what it's supposed to be basically. Not sure why vnext seems to be behind main though at the moment.

Deployment failed maybe?

@DeeJayTC we'll be debugging and and get back to you on this one on what is going in here. Thanks a ton for your patience!


531 fix structure of formfield

In this PR I updated FormField to support IconStart and IconEnd, and used it in Input, Select, Checkbox and Textarea components.
and moved examples of form components to new page /previews/form-components.


Update README.md

corrected image display & removed incorrect tip & corrections

Hi Lan, does this needs to be reviewed by someone else in the Slovenian team?
P.S. it's a good idea to add your real name to the GitHub profile, it took me a moment to connect the dots ;-)

Hi Flod!
Regarding the guideline I have removed - I first asked Matjaž to remove it, and he asked me to create an account and do it myself, so I guess he's okay with it.
Thanks for the tip - Github is something new to me :-) I'll add a name.
Lan

OK, let's merge then. Thanks for the PR!
(cc @mathjazz)

Nice work, @upwinxp! Thanks for merging, Flod!


Fix testfile

Consider if bytes are actually better than strings? Should we change the app to take strings?

Consider if bytes are actually better than strings? Should we change the app to take strings?

Would probably be a good idea, but.. next week we need to rewrite the whole thing in another programmning language, so i dont think we should focus our energy too much on fixing design-flaws in this version


Oauth2 support in Envoy xDS client

We should at least add support for an authorization header in the REST/gRPC clients. Beyond this, support for negotiating access tokens as described at https://developers.google.com/identity/protocols/OAuth2 and other auth, e.g. JWT, would be nice to have. We probably need the full auth flow if we want to maintain persistent connections beyond the lifetime that a static token would provide for.

As discussed via email, I think there's a case to be made for a clean auth provider interface as there are likely other uses for something like this. To wit:

oauth
basic
other org-specific auth mechanisms (e.g. cookies)
even kerberos (I once worked at a place that did kerberos for web sites)

If we make the Google gRPC client a configurable alternative to the inbuilt client, we should probably align with the connection/call credentials scheme supported there, see https://grpc.io/docs/guides/auth.html.

#3161 should resolve this issue

Closing as fixed.


Rename "Baseball Diamond" preset to "Baseball Field"

While the term "baseball diamond" is sometimes used to refer to the entire play area in baseball, it more precisely refers to just the area within the four bases (which form a diamond). The recommended way to map baseball pitches in OSM is to cover the entire field, not just the infield. The English name of the leisure/pitch/baseball preset should be changed to "Baseball Field" to better indicate what should be mapped.
baseball diamond should be added under terms so it will still be searchable.

Wouldn't mind taking this one on.  I've forked and started looking at it

@Spotts9 Go for it!


Require template name to have first character as capital.

This change is

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
5176c452714b7d5a08cfa6b32da95a9c0c942007
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jenkins job mixer/presubmit passed

Jenkins job mixer/pilot-regression passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/pilot-regression passed


New preload

Move all file processor and decoder into the preload stage. The data will be saved to a new data structure called 'packet' When replay, the vulkan replay consumer will process those packets directly.
The new preload only works for vulkan API

Author zehao-jing-arm not on autobuild list. Waiting for curator authorization before starting CI build.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please have a look at this patch :)


cover pdf to jpg will get an error.

here is test code, both get an error (but cover is complete ).
imageputfile("2.pdf", "1.jpg")

imageputfile({pdf:"2.pdf"}, {image:"1.jpg"})

I am unable to reproduce this error

I can't reproduce the error either......
I'll reopen this when I find a way to reproduce this.


So shy to commit a cmake issue

I look through all the issues here, very few is about cmake. I am so shame to commit this kind issue.

I ran cmake, and got this:
CMake Error at cmake/qt4/FindQt4.cmake:379 (include):
include could not find load file:
Call Stack (most recent call first):
CMakeLists.txt:52 (find_package)
CMake Error at cmake/qt4/FindQt4.cmake:743 (CHECK_CXX_SYMBOL_EXISTS):
Unknown CMake command "CHECK_CXX_SYMBOL_EXISTS".
Call Stack (most recent call first):
CMakeLists.txt:52 (find_package)
"Google" taught me to remove the following line  from CMakeLists.txt in the root of the Hyperion repository:
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake/qt4)
It got a little further this time, but still got this:
CMake Error at libsrc/jsonserver/CMakeLists.txt:42 (qt4_use_modules):
Unknown CMake command "qt4_use_modules".
"Google" told me to add "-DENABLE_DISPMANX=OFF -DENABLE_SPIDEV=OFF" to cmake flags, but there is no change.

Anyone could give more advice, any reply would be appreciated.

You should add a little bit more specification about your target platform, etc.

The indicated symbol is part of a standard cmake installation (http://www.cmake.org/cmake/help/v3.0/module/CheckCXXSymbolExists.html). You could try and locate the cmake-module (locate CheckCXXSymbolExists.cmake).
Removing the custom find scripts for locating qt4 could have undesired consequences. There is a reason that Hyperion has its own version, as the standard version has trouble differentiating between qt5 and qt4.
Disabling DISPMANX makes sense if you are not building for the RPi. This is the video-grabber intended for that platform. However you do need to have some form of grabbing to capture screen content (X11, V4L, ...)
Disabling SPIDEV makes sense if the platform you are compiling for does not have a SPI-device.

Should be done
Closed due to age. Please open a new one, if problems still exists.
Thank you


Add SplitButton component

🙋 Feature Request
A SplitButton combines a button which provides some default action, and a dropdown to access related actions.

💁 Possible Solution
A SplitButton acts as a container for a Button and a Menu. It does not implement any logic on its own, but it does provide styling for the button and wraps the menu in a MenuTrigger with a more button internally.
<SplitButton variant="cta">
  <Button onPress={onOpen}>Open</Button>
  <Menu onAction={onAction}>
    <Item>Share</Item>
    <Item>Create new</Item>
    <Item>Publish</Item>
  </Menu>
</SplitButton>

The API for this is as follows:
interface SpectrumSplitButtonProps {
  // Exactly two children are required: a Button and a Menu.
  children: [ReactElement, ReactElement],
  // These props are propagated to both buttons
  variant: 'cta' | 'primary' | 'secondary',
  isQuiet?: boolean,
  isDisabled?: boolean
}

Styling
The splitbutton spectrum-css classes can be used to implement this. In order to apply them, we can use the SlotProvider. The button slot can be used to send a class to the child button element, along with the variant, isQuiet, and isDisabled props (which should override any props set on the Button itself.
The menu (second child) should be wrapped in a MenuTrigger with a second button with a more icon inside.
Accessibility
No specific accessibility needs to be implemented for SplitButton. The MenuTrigger and Button components should handle the necessary a11y on their own. The only thing is that the more button should have an aria-label with something like "More actions".
🧢 Your Company/Team
RSP

Closing as not doing. We've decided with Spectrum design that this is not a good pattern and we won't carry it forward to v3.


Uninstall Helm Chart should remove shadow services

Do you want to request a feature or report a bug?
Bug
What did you do?

Install Maesh using Helm
Create a new Service (which should create a shadow-service)
Uninstall the Helm chart

What did you expect to see?
I was expected all resources created by Maesh to be removed.
What did you see instead?
Shadow services haven't been removed.
Output of controller log:
Not relevant for this bug report.
What is your environment & configuration (arguments, provider, platform, ...)?
Maesh built from sources on master.
If applicable, please paste the yaml objects required to reproduce your issue
Not relevant for this bug report.

Charts Hooks could be the solution.

The chart can only remove services that are created by the chart. The shadow services are not created by the chart, and cannot be directly removed.
However,
We could have a maesh cleanup command that removes all the created objects, and is triggered from an uninstall hook!

@dtomcej Yes, exactly. That what I had in mind. Uninstalling Maesh and then re-installing it using Helm with the current version leads to undesired behavior on TCP services. Indeed, shadow services are created only if they don't exist, and so, the TCPPortMapper won't store the port mapping for the existing shadow service.


Segfault in libwayland-client

If the wayland clipboard from window_clipboard is dropped while using winit there is a segfault in libwayland-client when the mouse is moved (could also be with other window events).
See https://gitlab.com/veloren/veloren/-/issues/855
gdb-backtrace.txt

Could you test https://github.com/Smithay/smithay-clipboard/pull/31 ? I've tested it with some veloren that was crashing before,and it's no longer does that if you patch clipboards to use this branch.

I had the user that was seeing the issue test a veloren build with this. Our Cargo.lock was pointing to smithay-clipboard 0.5.2 so before patching in the branch I needed to update the minor version of clipboard_wayland https://docs.rs/clipboard_wayland/0.1.2/clipboard_wayland/ which allowed updating smithay-clipboard. To be thorough I made a build for testing with the updated deps before patching in your branch.
These are the builds:
older clipboard crate: https://gitlab.com/veloren/veloren/-/jobs/896170352/artifacts/download
updated clipboard crate: https://gitlab.com/veloren/veloren/-/jobs/896176166/artifacts/download
updated clipboard crate with fix: https://gitlab.com/veloren/veloren/-/jobs/896176086/artifacts/download

The results were:

older clipboard crate build segfaults, updated clipboard crate build does not segfault, and updated clipboard crate with fix build does not segfault

So it seems like updating might have had an effect. :confused:
My changes for these builds can be found here (each commit corresponds to one of the builds listed above): https://gitlab.com/veloren/veloren/-/merge_requests/1602

I think this is resolved.


[sk] Calculate the indices of invalid values

Summary
Backend now calculates indices of invalid values for phone numbers, zip codes, and emails. This can be used by the frontend to highlight these entries as invalid.
Tests
Unit tests were developed locally to test that the invalid indices are calculated correctly, alongside testing on user datasets to confirm that the validity metric still reports outputs correctly.
cc:
@wangxiaoyou1993

Note: This latest push also fixed a bug in the case where non-integer values are used as dataframe indices. Now the the integer locations of indexes are returned rather than actual dataframe index itself.


Version tags?

At the moment, versions are not tagged in this repository, making it hard to determine which Git revisions correspond to releases on pub.dev.
Can versions be tagged here as well?

@hacker1024 sure, I will do in next release


Create Entry Points For PoS Consensus In Server

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

feature/proof-of-stake

PR #875

PR #888   👈

This stack of pull requests is managed by Graphite.


How to edit the self defined json  to send

How to edit the self defined json  to send

Maybe a example json file is better

Maybe a example json file is better

Any JSON file

Ok, i tried  and use tcpdump get the sending message. It's work

another question: the json file content only send once per connection
How to send file contents regularly？

another question: the json file content only send once per connection How to send file contents regularly？

Edit the file src/websocket-pressure-test.js at line 86


[WIP] Split dist diff into 3 parts

TBD

Closing to open a clean PR not burdened by too many force pushes 😊


Add '[ICLR 2024] SWE-Bench: Can Language Models Resolve Real-world Github Issues?'

https://www.swebench.com/
https://github.com/princeton-nlp/SWE-bench

[ICLR 2024] SWE-Bench: Can Language Models Resolve Real-world Github Issues?

https://arxiv.org/abs/2310.06770

SWE-bench: Can Language Models Resolve Real-World GitHub Issues?
Carlos E. Jimenez, John Yang, Alexander Wettig, Shunyu Yao, Kexin Pei, Ofir Press, Karthik Narasimhan
Language models have outpaced our ability to evaluate them effectively, but for their future development it is essential to study the frontier of their capabilities. We consider real-world software engineering to be a rich, sustainable, and challenging testbed for evaluating the next generation of language models. We therefore introduce SWE-bench, an evaluation framework including 2,294 software engineering problems drawn from real GitHub issues and corresponding pull requests across 12 popular Python repositories. Given a codebase along with a description of an issue to be resolved, a language model is tasked with editing the codebase to address the issue. Resolving issues in SWE-bench frequently requires understanding and coordinating changes across multiple functions, classes, and even files simultaneously, calling for models to interact with execution environments, process extremely long contexts and perform complex reasoning that goes far beyond traditional code generation. Our evaluations show that both state-of-the-art proprietary models and our fine-tuned model SWE-Llama can resolve only the simplest issues. Claude 2 and GPT-4 solve a mere 4.8% and 1.7% of instances respectively, even when provided with an oracle retriever. Advances on SWE-bench represent steps towards LMs that are more practical, intelligent, and autonomous.

Thank you for your contribution. SWE-bench has been added.

Looks like there may have been some unintended changes along with that?

Sorry，the errors has been fixed.


Introduce phpstan in build pipeline

Please consider to add https://github.com/phpstan/phpstan into your build pipeline.
Even on Level 0 phpstan was able to report 233 Errors:
$ ./vendor/bin/phpstan analyse -c phpstan.neon -l0 Checkout Content Framework Profiling System
[...]
 ------ --------------------------------------------------------------------------------------------------------------
  Line   Framework/Test/Serializer/StructNormalizerTest.php
 ------ --------------------------------------------------------------------------------------------------------------
  31     Class stdClass referenced with incorrect case: StdClass.
  87     Class stdClass referenced with incorrect case: StdClass.
  107    Class stdClass referenced with incorrect case: StdClass.
  279    Constructor of class Shopware\Core\Framework\Test\Serializer\ConstructorStruct has an unused parameter $age.
 ------ --------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   Profiling/Cart/CircularCartCalculationTracer.php
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  22     Shopware\Core\Profiling\Cart\CircularCartCalculationTracer::__construct() does not call parent constructor from Shopware\Core\Checkout\Cart\Cart\CircularCartCalculation.
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------
  Line   System/Listing/Struct/ListingSortingDetailStruct.php
 ------ ------------------------------------------------------------------------------------------------------------------
  19     Access to an undefined property Shopware\Core\System\Listing\Struct\ListingSortingDetailStruct::$productStreams.
 ------ ------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------
  Line   System/Mail/Aggregate/MailAttachment/Collection/MailAttachmentDetailCollection.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------
  35     Return typehint of method Shopware\Core\System\Mail\Aggregate\MailAttachment\Collection\MailAttachmentDetailCollection::getShops() has invalid type
         Shopware\Core\System\Mail\Collection\ShopBasicCollection.
  37     Instantiated class Shopware\Core\System\Mail\Collection\ShopBasicCollection not found.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 233 errors

Would you accept a PR with a matching phpstan configuration?

@bcremer I would love it :blush: :+1:
I don't know about @janbuecker and @OliverSkroblin :smile: :see_no_evil:
but you should wait with your PR, Olli has some big changing PR in the pipe, which will be merged soon :wink:

Like I said yesterday evening, I'll wait for the latest change by @OliverSkroblin and then fix the issues as some files don't exist anymore. I also added phpstan to our build pipeline to identify those issues earlier from now on.
I'll leave a comment when we fixed the issue. ;-)

Done with level 1.


Unable to create collider shape from mesh!

Hello! When trying to build, it gives me this error 'Unable to create collider shape from mesh!'
The plugin was working fine, i dont know why this happened.

Hmm this means that create_convex_shape or create_trimesh_shape is returning null. The documentation isn't very clear on the cases when this could happen. Do you know which meshes it is talking about? Perhaps it's an empty mesh?

How can I get that information?

Okay I just did some testing, and this might be related to #68 as well, are you on RC2? I'm able to reproduce this on Godot 4 RC2. It seems like the resource loader is failing to load any resources. I'm looking into it!

Yes! I am on RC2

Looks to be caused by this change: https://github.com/godotengine/godot-cpp/commit/75af9003dc2b1583966ab91be6ce1687378860ae

The latest godot-cpp commit should fix this.

Thank you! I'll wait for the next release as I'm too lazy to compile the engine :p


"Play on TV" aka Chromecast button does not display on chromecast-supported sites (e.g. YouTube)

Describe the bug
A clear and concise description of what the bug is.
Cannot cast directly to chromecast (not using cast tab which provides lower bitrate and worse performance) videos on sites like youtube.com
To Reproduce
Steps to reproduce the behavior:

Enable flag #cast-media-route-provider
Go to youtube.com
Click on any video
See that chromecast icon is missing and you can't directly cast video to chromecast
Try and repeat this on standard chromium and you will notice the button does appear

Expected behavior
Direct native casting of video on sites like youtube.com
Screenshots
Ungoogled-chromium:

Chromium proper:

Environment (please complete the following information):

OS/Platform and version: macOS 11.2
ungoogled-chromium version: Version 88.0.4324.146

Additional context
If this is a privacy issue with enabling it by default, at least provide a flag to be able to enable it. Casting without the native/direct cast functionality is an abysmal experience

Both the issue you're having, and the proposal to have a flag to make this feature available as an opt-in have already been mentioned in https://github.com/Eloston/ungoogled-chromium/issues/1137, so feel free to close this as duplicate and comment there instead.


Support asynchronous producer-consumer relationships

It should be possible to compute a producer and a consumer asynchronously, with an optionally storage folded buffer between them.

I've been thinking about this quite a bit, here's what I have so far.
I've realized that an asynchronous pipelined loop is exactly the same as parallelizing a loop with a block body, where each child of the block is a stage in the pipeline. This approach has an added benefit that it should parallelize such that each thread runs the whole loop body on a particular iteration of the loop, which improves locality. (This is in contrast to setting up threads to each only do one stage of the pipeline, which would be passing the data from one thread to the next.)
Of course, this will require some extra synchronization to be inserted between the stages to be correct.
If we just do this on a storage folded pipeline, it would result in no parallelism, because the synchronization would only allow one stage to run at once.
However, if we increase the storage folding factor such that multiple iterations of each stage can be running at the same time, and the synchronization logic understand that, we should be able to run multiple stages of the pipeline in parallel.

I've got this working, with a lot of TODOs (below). Here is what it generates for the loop in bazel run builder:pipeline_test -- --gtest_filter=split_split_mode/stencil_chain.pipeline/parallel_1 (I added a few comments):
   _semaphores = allocate(stack, 8, {
     {[(buffer_min(out, 1) + -3), buffer_max(out, 1)], 8, <>},
     {[0, 1], ((buffer_extent(out, 1) * 8) + 24), <>}
   }) {
    call(<fn>, {}, {_semaphores})  // fill(_semaphores, 0)
    slice_dim(_semaphores, 0, (buffer_min(out, 1) + -3)) {
     call(<fn>, {}, {_semaphores})  // fill(_semaphores, 1)
    }
    parallel loop(y in [(buffer_min(out, 1) + -2), buffer_max(out, 1)], 1) {
     _semaphores = clone_buffer(_semaphores) {
      intm = clone_buffer(intm) {
       out = clone_buffer(out) {
        check(semaphore_wait(buffer_at(_semaphores, (y + -1), 0), 1))
        crop_dim(intm, 1, [(y + 1), (y + 1)]) {
         call(<fn>, {in}, {intm})
        }
        check(semaphore_signal(buffer_at(_semaphores, y, 0), 1))
        check(semaphore_wait(buffer_at(_semaphores, (y + -1), 1), 1))
        crop_dim(out, 1, [y, y]) {
         call(<fn>, {intm.uncropped}, {out})
        }
        check(semaphore_signal(buffer_at(_semaphores, y, 1), 1))
       }
      }
     }
    }
   }

This actually works for the stencil test (above), and the stencil_chain (3 stages).
The approach taken at the moment is pretty dumb: it just runs a parallel loop, and inserts synchronization around every stage of the loop to wait for the previous iteration of that stage to run. It requires an array of semaphores with 2 dimensions: one for the loop variable, and one for the stages. It initializes the semaphores to all 0, except for one before the first loop variable value, which is initialized to 1.
There are quite a few TODOs:

It deadlocks because this call https://github.com/dsharlet/slinky/blob/af966788b1f45efa814fb51b9623b4dd1079f718/runtime/evaluate.cc#L277 doesn't know that it can't recursively enqueue the worker (like the enqueue_many workers above do). This is an easy but messy fix.
It adds synchronization even for loops/stages that don't need it.
I don't think anything stops from producers running too far ahead and trashing folded buffers. But I have never had this happen in any of the tests so far... but I'm pretty sure it's possible and needs to be guarded against.
It expands the fold_factor of sliding window loops too much. It currently doubles the fold_factor, it should only need to increment it by how much a loop iteration writes.
I think we should be able to fold the semaphores buffer in the loop variable dimension. Initializing the semaphores correctly in this case is tricky, although I think the semaphores end up zero anyways. I think it might not be working because of #41.


Apple Silicone "This application is not supported on this mac"

After installing on my Macbook Pro with Apple M1 Max via
npx @puppeteer/browsers install chrome@stable
I am unable to start.  This seems a different error than mentioned in the README.  Is apple silicone supported?

Cannot reproduce (M1 Pro):

Interesting, thank you. that does work when launched from the command line.  It did not work for me when launched from finder.  That's not really the important use case but was confusing.  Is that expected?

Also cannot reproduce, see screenshot below (you can see I don't get the overlay 🚫 icon).
I'm glad it works for you from the command-line so that it doesn't block you. Not sure why the behavior in Finder is different for both of us though.

That screenshot was helpful.  Here was some additional blurbs when I launched via the command line.
My arch is arm64, but the install process installed mac-115.0.5790.102/chrome-mac-x64/ whereas your screenshot shows chrome-mac-arm64...
daniel.toms@Q9JQNC9X77 ~ % arch
arm64
daniel.toms@Q9JQNC9X77 ~ % npx @puppeteer/browsers install chrome@stable
<EMAIL_ADDRESS>/Users/daniel.toms/chrome/mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing
daniel.toms@Q9JQNC9X77 ~ % cd  /Users/daniel.toms/chrome
daniel.toms@Q9JQNC9X77 chrome % mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing
zsh: no such file or directory: mac-115.0.5790.102/chrome-mac-x64/Google
daniel.toms@Q9JQNC9X77 chrome % mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/G
daniel.toms@Q9JQNC9X77 chrome % "mac-115.0.5790.102/chrome-mac-x64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing"
[57465:259:0723/083617.892174:ERROR:chrome_browser_main.cc(1036)] The use of Rosetta to run the x64 version of Chromium on Arm is neither tested nor maintained, and unexpected behavior will likely result. Please check that all tools that spawn Chromium are Arm-native.
[57465:259:0723/083621.062646:ERROR:chrome_browser_cloud_management_controller.cc(162)] Cloud management controller initialization aborted as CBCM is not enabled.

So it seems like my mac has rosetta running and the installer chooses to install a different architecture.  i don't know if that's something that can/should be fixed, or perhaps, noted somewhere.  or if its just my own environment problem to deal with.  i would suspect others would hit this in the future though.

FYI @OrKoN. Is @puppeteer/browsers selecting the wrong architecture?

I am not able to reproduce:
❯ arch
arm64
❯ npx @puppeteer/browsers install chrome@stable
Downloading chrome r115.0.5790.102 - 121.5 MB [====================] 100% 0.0s
<EMAIL_ADDRESS>/Users/alexrudenko/src/pptr-test/chrome/mac_arm-115.0.5790.102/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing

We rely on Node to detect the platform. What does the node -e "console.log(require('os').arch())" return for you? It should be the same as arch.

Ah, got it.  We use asdf and are on an old node version 16.13.1 which does not correctly detect the arch.  Switching to v20.5.0 and its correctly detected and Chrome for Testing works as expected.  You might consider adding a nodejs check to the install, or a note to the FAQ, or perhaps this issue will help future travelers.  Thanks all!
(not sure the closing protocol here so will leave open)

@OrKoN Do you want to move the issue to https://github.com/puppeteer/puppeteer before we close this bug, or is would you say it is WAI?

for posterity, with asdf
daniel.toms@Q9JQNC9X77 ~ % node -e 'console.log(require("os").arch())'
x64```

Since it's working with nvm, we can just close this. If more issues come up related to asdf then we can reconsider.


S3 Customizations

There is a lot here. These all need to be scoped and designed

[ ] SSE customer key: https://github.com/awslabs/smithy-rs/issues/126
[x] Parsing ARNs from input parameters
[x] Custom endpoint based on input, configuration, and region.
[x] Accelerate, dualstack, seaport, accesspoints,
[x] Trailing checksums https://github.com/awslabs/smithy-rs/issues/1263
[ ] ~Change GetBucketLocation’s response LocationConstraint to match AWS region names. (Probably should be removed)?~
[x] Fix GetBucketLocation to be unwrapped during operation deserialization (aws-sdk-rust#116)
[x] Additional request ID header: HostID https://github.com/awslabs/smithy-rs/issues/422
[x] BucketName to endpoint (virtual host addressing)
[ ] ~Auto decodes gzip response~

I think most of these will be solved by endpoints 2.0. Adding the retriage tag to confirm and update the issue later.

Only SSE customer key will remain after endpoints 2.0.

SSE tracked in https://github.com/smithy-lang/smithy-rs/issues/126


⚠ Bofrost.be has degraded performance

In 691a894, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2802 ms

Resolved: Bofrost.be performance has improved in e01adac.


DO NOT MERGE YET: Rebuild PR import.

@cmungall I built an update for pr_import.owl. It would be good for you to review, as there are substantial changes, and lots of new HGNC terms (which doesn't seem to be a valid OBO namespace). Thoughts?

I am redoing this.


Add maven_install.json v2 support

no tests yet

Fixes Issue
Description of Change
Please add a description of the proposed change
Have test cases been added to cover the new functionality?
yes/no

I still need to add tests, but this is working


Autorefresh stopped working on 0.7

Hi,
We just upgraded to tessera 0.7 and found that the autorefresh stopped working.
We are using firefox 38.
I had a quick peak in the code but I am in no way a javascript expert but did find that in the refresh function line 6237 in tessera.js that 'this' does not point to the manager object but the actual window which doesn't have the 'current' object and as such skips the load function all together.
Hope that helps.
Jozef

Whoops - thanks! Will get that fixed up shortly.

Fixed

Great thanks for the quick turnaround!


Unexpected outcomes while trying to merge two instances of type reflect.Value

https://play.golang.org/p/Jewi51WT-gZ
The expected outcome here is:
printing overlayed
&{b1 [] 1}
&{b2 [{d1 f1 t1} {d2 f2 t2}] 2}

but we get:
printing overlayed
&{b1 [] 1}
&{b2 [{d1 f1 t1} {d2 f2 t2}] 0}

which means if the dest has no value provided, the value from src will be used.
I tried this with a few different versions of the library: specifically 0.3.7, 0.3.8 & 0.3.10. Got the same response in all cases.
Although, with the version 0.3.9, I got a different response, still incorrect
printing overlayed
&{b1 [] 1}
&{b2 [] 2}

The field value from the base is preserved, but the slice value from override is lost.
We don't see this issue if the values are converted to respective structs first and then invoke mergo.Merge: https://play.golang.org/p/t-ND1sobjUb
We get the expected outcome in this case.

I'm not sure trying to merge reflect.Value is the safest option. It seems to be mergeable because the struct contains a pointer to the underlying data, but it feels like you are relying on an internal implementation detail for that, which is usually a bad idea.
I would go for the code in your second link, it looks clearer and less magic. Anyway, I will take this into account in the next big version of Mergo, written from scratch.
If you provide a PR for the current version, I won't mind reviewing and merging it.

The sample code is definitely not going to do what you want as provided, mostly because you don't actually want to merge go's internal reflect.Value structs. You actually want to merge the things in those reflect.Value structs. That's possible, but it would take a fair bit of work. Ultimately, it's imdario's call, but it sounds like he considers this out-of-scope.
In more detail:
You're asking mergo to merge two reflect.Value structs. They do have type struct, and they're even the same type of struct, so technically this package can try to merge them, but reflect.Value doesn't have any exported fields. As the documentation  states, "Mergo won't merge unexported (private) fields." This is really a language limitation, and there's not much this library could do about it.
The obvious thing to try would be to call .Interface() on your reflect.Value before passing it into mergo. That could work, but it doesn't for a couple reasons:

mergo doesn't accept interface{} as the top level value, only structs and maps (see package documentation) You could solve that by trying to resolve the interface{} to a struct or a map in the library, but I don't know if the author is interested in supporting that. I don't see any obvious technical barriers, but it's definitely outside the documented scope of allowed inputs. It would need to be solved inside mergo though, since I'm not aware of any way to convert reflect.Value to its contained concrete type without knowing what that type is. If you knew what the underlying concrete type was, presumably you wouldn't be trying to work with reflect.Value.
If you solve that, you're going to run into the same problem #162 is reporting - the value inside your interface isn't addressable, simply because it's in an interface. There are good, if complex, reasons for this that are documented on that issue. Again, this is solvable, but it's not a trivial change.

If you could get all that working, then you could lift it into the package and support reflect.Value as a valid input type. I personally wouldn't go that far, but not my decision

Just wanted to circle back on this. I was able to change the code in the original post to make it behave as desired. The problem seemed to be making an unnecessary call to the reflect Value's Elem method, which was essentially dereferencing the underlying pointer type.
I would like to point out that, documented or not, this library seems to gladly accept interface{} types in the Merge function as long as the reflect kind is a pointer to a struct (maybe pointer to map works too, I didn't try). Simple illustration here.
In any case, altering the original author's code to pass the non-dereferenced, interface{}-casted values to the Merge function, along with some compensating changes, was enough to get it to behave as desired: https://play.golang.org/p/_r3fc_UikdX


Construct BST From Preorder

Construct BST From Preorder Traversal

Related Issue

#1208

Proposed Changes

Code to convert Bst From Preorder Traversal
Readme file for the same.

Additional Info

Binary search trees are a very important concept in data structures.
BST helps us speed up our binary search as we are able to find items faster.
We can use the binary search tree for the addition and deletion of items in a tree.

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

I have added the code for converting BST from preorder traversal which is important concept as it is a medium-level question in competitive programming.

This concept is not yet implemented and it solves the understanding of the binary search tree and the preorder traversal.

fixes issue #1208

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Code
Output

LGTM🌟

LGTM 🎉✨
Good Contribution @ritikagarg0326

Thankyou


[Feature Request] Specify pairs by regular expression

I really like the fastwrap feature of this plugin!
I would be very happy if fastwrap could be done in HTML (JSX).
Right now I am adding {<div>, <div>} but I would like to use it with other tags.
So I would like to use regular expressions to specify pairs.
Like this:
opts.internal_pairs = {
	{ "<.*>", "<\/.*>"},
}

I tried to implement it myself, but couldn't figure out where to add it.
I hope implement it 🙏

It is on the TODO list for the next version.

Really? I look forward to the next version!

+1 this would be super useful! Definitely looking forward to it being added!


[PI-1623] : Code Handover | Chatbot | when large file is uploaded for any textual answers the service is terminating

… answers the service is terminating

This is contribution from Punjab Impl Team.


Update endpoint flow list to V2

According to this blog post, we should move away from our current endpoint of listing Power Automate flows. We are currently using the v1 endpoint which is being deprecated.
The v2 endpoint should be called as follows:
GET https://api.flow.microsoft.com/providers/Microsoft.ProcessSimple/environments/{environment}/v2/flows?api-version=2016-11-01

As far as I know:

This is only the case to list all Power Automate flows as admin (more investigation needed)
According to my tests, listing flows not as admin, we should still use the V1 endpoint (more investigation needed)
This is a breaking change, the output of the endpoint is different

There's some urgency behind this change, because apparently the v1 API will stop functioning altogether coming July 15

I'm not entirely sure if it will stop working at July 15. Currently, I have no trouble using it on my environment.


Updated Pase Cookie Example check if values have double quotes

Hey,
I've added a check if the values contain double quotes.
When this is the case then I slice the quotes away.

@CreaTorAleXander,
Nice, I wish I could approve and merge.
You may need to get some attention of the maintainers. Try tagging them.

Closing as the original issue was not valid.


Add Playground/Console Documentation

Proposed changes
Add Playground/Console Documentation. This has been in progress for a couple of weeks, I'm just not super familiar with ELM (the language used for the backend) so the progress is slow.
Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

Not obligatory, but suggest an idea for implementing addition or change

Other information

Anything else we should know? (e.g. detailed explanation, related issues, links for us to have context, eg. stack overflow, codepen, etc)

This is done..


Rename role to distinguish from ansible vault

Suggestion to rename this role to distinguish it from ansible vault.
The name: ansible-community.ansible-vault really makes it look like it's related to ansible vault rather than hashicorp vault / vaultproject.
Few ideas:

ansible-community.ansible-hashicorp-vault
ansible-community.hashicorp-vault
ansible-community.ansible-hashi-vault
ansible-community.hashi-vault
ansible-community.ansible-vaultproject
ansible-community.vaultproject
etc.

Any feedback on this from the active maintainers? @bbaassssiiee and others?


Vuex edit state

Version
6.0.1
Reproduction link
github.com
Steps to reproduce
open devtools and try to change vuex state (test) and save it.
What is expected?
change state
What is actually happening?
Can't edit Vuex state, when changing value and saving – data doesn't change

Vue 2.6.14
Firefox 96.0
Ubuntu 20.04

My mistake to let editing enabled. It's not implemented yet and I overlooked this for the v6 release.


Update onboarding survey for Laos

Shortening the survey to around 15 questions to make the onboarding process smoother

Working! Tested on a participant's phone, they do not see the old questions


[FEATURE REQ] Update LNbits to the new version <IP_ADDRESS>

Please update the guide on LNbits to the new version (<IP_ADDRESS>).

PR #1111 opened!

Issue resolved!

Issue resolved with #1111, closing the issue.


python312Packages.yappi: 1.6.3 -> 1.6.4

Diff: https://github.com/sumerc/yappi/compare/refs/tags/1.6.3...1.6.4

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 353128 at d5f92921 run on x86_64-linux 1

:white_check_mark: 5 packages built:

python311Packages.ax-platform
python311Packages.yappi
python312Packages.ax-platform
python312Packages.yappi
tribler


Fix link to community article

The link to Philip Borestein's article under community resources was broken. This update fixes the URL.

Thanks!


Reducer

Please read and mark the following check list before creating a pull request (check one with "x"):

[ ] I read and followed the CONTRIBUTING.md guide.
[ ] I read and followed the New Feature Checklist guide.

Short description of what this resolves:

#26 #36


Add Graph options and add setting for enabling Key graph features for variables

Fixes Part of #338.
Description of the changes:

Add the graph options panel
Add the graph option to analyze functions with variables

How changes were validated:

manually

Closing since it looks like Rudy took this over


Curriculum Review: Day 1 - Numpy & Pandas

How clear is the material? What’s confusing?

The material is pretty clear and straightforward. It is well structured and I found it highly readable and comprehensible.

Are we assuming any knowledge that we shouldn’t be? Where should we add background info?

No, the tutorial starts from the basics and builds its way up to help us with the included activities. The provided background information through the supporting text cells was enough to understand the context and functionalities well.

Is the structure of the lesson engaging? Are there any parts that are unnecessary/boring/too long?

The to-do parts are pretty engaging, and the tutorial length is perfect.

How much time did it take you to complete the assignments? Keeping in mind that most participants will likely take more time than you, how much time should we suggest that participants spend on each activity?

The first activity took me ~6 minutes. So, 6-8 minutes should be good (also considering that they are working in groups). The second activity is pretty small and mainly prompts for a small discussion between the group members. So, they are likely to finish it in ~2 minutes. Overall, I think 10 minutes should be good. (Not including optional activities)

Additional Comments

We are asking the question if arrays have fixed size, how do you think numpy.append works? from the participants in the first text cell. I think we should also include its answer explicitly in the Key.
I couldn't find the files for the Optional Activity 3 in the Google colab folder (both in the tutorial and the key). We need to include the star_names.json file at the path - ../example_data/star_names.json

Thanks Chetan! Excellent comments. I'll change the answer key to address this, and I'll make sure the paths in the colab are correct (good catch).

Just updated the solution in the drive @chetanchawla; let me know what you think.

PR to address path issue: #94

Thanks Sarah, everything looks good now!


[stable/elasticsearch] better chown in init containers

What this PR does / why we need it:
In some environment PVs may contain special directories, such as .snapshot, that are read-only.
Having these unexpected read-only directories makes chown initContainer to fail.
Which issue this PR fixes
Introducing new attributes master.allow_chown_failure and data.allow_chown_failure, which allows chown container to fail..
Special notes for your reviewer:
Alternatively, using more targeted chown command might be more desired.
chown -R elasticsearch:elasticsearch /usr/share/elasticsearch/data/nodes
chown -R elasticsearch:elasticsearch /usr/share/elasticsearch/logs/*log*

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Just ignoring the a failure doesn't sound like a good plan to me.
There could be other reasons the command fails.
Can you change this to use the more targeted command.

@rendhalver rebased off master, and changed to more targeted "chown"

@rendhalver could you please take a look at this again?

/assign @icereval

Updated title to better reflect what code does after implementing changes suggested by @rendhalver

/ok-to-test

bumped the version and merged master/origin..

@rendhalver "pull-charts-e2e" is now passing

merged master and bumped version 1.15.1

/cc @davidkarlsen, would you please advise on possibility of merging this?

merged master, bumped version to 1.15.2

merged master, bumped version to 1.15.3

.. and bumped to 1.15.4

/assign
Instead of doing an inclusion, could we search for files based on exclusion (.snapshot) in order to be future-proof? And comment why?

@desaintmartin I've targeted known Elasticsearch directories, since they seems to be stable and known..
going the other way, explicitly ignoring .snapshot is future proofing it, I suppose..
suggested change have been implemented

Thanks!
/lgtm


Add a documentation page. Restructure navigation

This adds a documentation page to the website, to replace the in-tree landing pages, and restructures the top level navigation to have only 'Documentation', 'Community', 'Downloads', and 'Contribute' links.
The security, legal and FAQ pages are all linked from the docs page.
To deal with nightly and beta docs I just included a section called 'nightly and beta documentation' that goes only to the in-tree landing page for those, the thinking being that they are less important, and for more knowledgeable users. So I did not try to duplicate all the relevant information for all three channels ala the downloads page.
For non-english resources I deferred to rust-learning temporarily, though I'd prefer to use the forge for that. I opened a PR against rust-learning to include all the book translations.
For other useful resources I again deferred to rust-learning. To keep things non-overwhelming I like having secondary resources on another page, though perhaps rust-learning will not be that page in the future.
You can see this deployed, along with the contributions page here.
Needs to wait on the contributions page to merge, and if it merges before the FAQ then it needs to be edited to make the FAQ link work.
Fixes https://github.com/rust-lang/rust-www/issues/179. cc https://github.com/rust-lang/rust-www/issues/175
cc @efindlay @aturon @steveklabnik

r? @nikomatsakis
(rust_highfive has picked a reviewer for you, use r? to override)

I used Go and Scala as references.

I've pushed a commit to split out a 'project policies' section. Adding a section on 'policies' generally suggests we need more links there. One possibly is the link explaining Rust governance and processes that I have mentioned to you previously.
I've been thinking about adding a footer across the site, particularly to explain how to submit changes to the website itself, possibly to explain the copyright of the website itself. We could add other legal links there, but frankly I think we should not, because they are not so important that that they should be available from every page of the website.
I'm going to be doing some work on integrating the FAQ styling with the rest of the site. Part of this may be touching how the header is separated from the content. I'll see if anything there suggests ways to make this header look more balanced.

I've pushed a change to my deployment that adjusts the style of the site to accomodate the styling of the faq. The changes are described here. Part of this adds a border element to most pages near the navbar, and it also reduces the whitespace around the navbar on the index page.

@brson Looking very good! I think the separate policy section works well, and agree that it's a natural place to talk about governance, etc. (Though I don't think we have to do that for this initial round of website updates).
My only (very small) nit is that the horizontal rule separating the header from the rest seems thinner than the rule separating the different sections, which felt a bit jarring.
But overall the rules and large section headers feel pretty good as a way to present a lot of information in a manageable and simple way.

On reddit /r/killercup suggested that the syntax index should be advertised more widely. I already added it to rust-learning, and I'm tempted to add it to the references section.

@brson Sounds like a good idea to me.

@aturon My latest version uses a consistent-width horizontal rule everywhere.
This PR is subsumed by [that].


"Cannot find the path" on Windows

I assume Windows is not supported due to Shell? I’m using Cmder, which I think, provides Unix commands but I don't know if that's relevant in this case.

Oh. We are using Mac OS X only here so to be entirely honest I could not try it on Windows. Maybe @valeriangalliat can give us a hand here?

I have been investigating a bit and apparently I am using some commands that are not supported by Windows, such as cat or rm -rf.
A solution would be to port this script over to Node.js to ensure compatibility, but this is not something I am willing to do myself given I mostly wrote it for Edenspiekermann where we only deal with Mac OS X (and more broadly speaking Unix).
I’d still like Valérian’s opinion. We never know. Maybe he can do magic. :)

Only Unix systems for me too, don't have a Windows at hand.
But if Cmder provide Unix commands, I bet it contains cat and rm.
The problem here is that the script is not actually running. The error you see every time is either your shell not finding the spritesh command in your PATH, or not finding /bin/bash (from the shebang).
I don't know Cmder at all but I would investigate on these options. If which spritesh or command -v spritesh does not error and shows the right path to spritesh, then it's a problem with the shebang. Do you know if Cmder interprets shebangs, and if you have a Bash implementation at hand? Or at least a sh implementation (at first sight spritesh can run on bare sh).

You need a proper terminal.
Cygwin and git-bash would do the trick in windows.
Just run the script from inside one of them.

@TxHawks I can confirm that it works in Git Bash. I doubt that there are many developers on Windows that have Node installed but not Git, so this is a solid solution.

Very good. :)


chore: release 2.10.0

:robot: I have created a release *beep* *boop*
2.10.0 (2024-06-03)
Features

merge api (#503) (0106e4d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-cli/releases/tag/v2.10.0 :sunflower:


Marketbuddy has been outdated for 3 months.

I can't tell if I've done something wrong, but Marketbuddy hasn't updated for me in several months. I'm just being prompted to "wait for it to be updated by its author."

Do you use a mega repo?
Delete the plugin and follow these steps

That worked! Thank you! I just had to delete it and reinstall.

That fixed it, but now it crashes my game whenever I interact with sale history pages.

Try removing the config. Exit the game, go to %APPDATA%\XIVLauncher\pluginConfigs (in windows explorer) and delete the Marketbuddy.json file

That worked! Thank you so much! You're the best! ♥


Create aspnetcore shared framework symbols packages

Addresses https://github.com/aspnet/Universe/issues/853
Checking effects on downstream builds.

:up::date:


ruff format moves # noqa comment to wrong location

I would like to switch my codebase to ruff format, but there is one annoying issue that breaks my use case: Some # noqa comments are moved resulting in issues when calling ruff check.
Hers's a minimal code snippet to demonstrate what happens:
# test.py (original)

import typing

def foo(
    __bar: str,
    /,
    **specifiers: typing.Any,  # noqa: ANN401
) -> int:
    return len(specifiers)

$ ruff --version
ruff 0.3.1

$ ruff check --isolated --select ANN401 test.py

$ ruff format --isolated test.py
1 file reformatted

# test.py (reformatted)

import typing

def foo(
    __bar: str,
    /,  # noqa: ANN401
    **specifiers: typing.Any,
) -> int:
    return len(specifiers)

$ ruff check --isolated --select ANN401 test.py
test.py:7:19: ANN401 Dynamically typed expressions (typing.Any) are disallowed in `**specifiers`
Found 1 error.

I assume this issue is an edge case that has to do with the keyword-only / syntax being used. Are there any workarounds available?

Oh hmm, this looks like a bug, thanks. Will look into it. The only workaround I could think of is using # fmt: skip on the header for now:
import typing

def foo(
    __bar: str,
    /,
    **specifiers: typing.Any,  # noqa: ANN401
) -> int:  # fmt: skip
    return len(specifiers)

This is why we need a programming language that doesn't allow comments :joy:

This is why we need a programming language that doesn't allow comments 😂

Or an AST that represents / ;)
FYI: This is not specific to noqa. We incorrectly associate any end-of-line comment **kwargs comment following /
https://play.ruff.rs/cb2a370c-ae53-48a5-a35f-810b9c537ae2

Thanks @MichaReiser and everyone else at https://github.com/astral-sh! You rock 🚀


undefined status in web ui

Environment

OS: official docker image
Erlang/OTP: 8.1
EMQ: Stable 2.2.0

Description
I've been trying to use a newer version of emqttd as I was using 2.0.2 from a non official container, but in all EMQ 2.2.x version I see an undefined label in clients and session tabs. I.e, SendMsg RecvMsg, MaxInflight.... and so on

@carlos-renjel-coderoad-com Enable the client Stats in etc/emqttd.conf:
## Enable client Stats: on | off
mqtt.client.enable_stats = on

@emqplus
Hi! I just enabled mqtt.client.enable_stats = on and mqtt.session.enable_stats = on, and everything is as expected
Thanks!