most-valuable-hero from one transition gets reused for next transition despite not being the most valuable

Steps:

Start stocks in with 50x time dilation.
Tap a row. Wait for the animation to reach 50%.
Tap back. Wait for the animation to reach 25%.
Tap another row. Wait for the animation to reach 50%.

Notice how the hero arrow from step 2 ends up being the hero arrow in step 4. Instead, two arrows should end up in flight, one going back to the old location, and one going to the new location.

Hit back.

The arrow from the row you tapped in step 4 vanishes, to make room for the hero, which now goes there. When the animation finishes, the original arrow just blinks back into existence.

@HansMuller This is one of the bugs I was talking to you about with heroes the other day. Specifically, this is the one about how some heroes need to be on a different timeline than others, and sometimes maybe we need to split the party and have some go one way and some the other.

This is basically obsolete now because MVH keys are gone, but https://github.com/flutter/flutter/issues/5798 is the new version of this bug.


Update documentation for TrailingComma rules

This is the first part of addressing https://github.com/detekt/detekt/pull/5386#issuecomment-1304916205
The second part would be adding @ActiveByDefault, however I was running into runtime exception at multiple places across our codebase, hence I would leave it for the next PR.

@chao2zhang can you address the comment of @BraisGabin and me about the .java-version? Aside from this, we can merge this one 👍


Add the ability to pass custom PropertyValueRenderers

I found it frustrating that there are no options to configure objects to be rendered as in the default LogEventPropertyValue.Render(…) method and apply fancy themes to them. Although it would be preferable to add this feature to Serilog itself, doing so would have numerous consequences. Therefore, I decided to implement it in this project.
The main addition is the IPropertyValueRenderer interface and ThemedDefaultPropertyValueRenderer class, which is a direct copy of the corresponding (ScalarValue/StructureValue/SequenceValue/etc).Render(…) method implementations, but with added theming capabilities. ThemedJsonPropertyValueRenderer (renamed ThemedJsonValueFormatter) implements this interface too.
Additionally, I included the format and formatProvider parameters since they were used in the default renderers. It appears that they are actually necessary in this context based on the design.
TODO

[ ] Add documentation

And I think, to keep things consistent, it would be a good idea to make the ThemedJsonPropertyValueRenderer class public, not internal

Thanks for dropping by!
Would it be possible to include a bit more info about the usage scenario you have in mind? I can see from the PR how the extension point fits in, but I'm not sure whether the extra surface area is worthwhile given that if you're prepared to write custom code then many scenarios could possibly be achieved directly via ITextFormatter without the involvement of this library.
Thanks!

Also, I think that it would be nice to make the abstraction one more level up and add somethink like interface IMessageRenderer { void Render(MessageTemplate, LogEvent, TextWriter) }, and inside it will use IPropertyValueRenderer. Because I found it strange that there is some edge case: the logic below (about scalar rendering) is duplicated there and in ThemedJsonValueFormatter itself. I think this logic should be coupled in one place like IMessageRenderer

Thanks for your reply, I appreciate the thought and effort that's gone into the PR.
At this stage I don't think it's a part of the design space I'm ready to push into; the custom functions extension point is the limit of the extensibility I had in mind for Serilog.Expressions, specifically because it covers a wide range of scenarios with a very narrow surface area. Over time this should set the library up for easy maintenance and evolution, while not limiting things too much.
Thanks for putting this forward, all the same. Please drop me a line if you need a hand pushing ahead in a fork or via some other approach.


Skip Button?

Is there a way to tell the player to create a skip button on Vast 2.0?

I use the attribute 'skipoffset' in Linear tag,  like this
.....

00:00:05

.....

VAST 2.0 doesn't support Skip button, u need to use VAST 3.0.


TESTING: Exact restarts

All drivers should support exact restarts.  This issue is meant to track the test implementation for this feature.
Driver specific notes:
Classic Driver - Only when binary state file is used, ASCII will have round off errors
Image Driver - xref: #402
CESM Driver - xref: #196, should support CESM rpointer file convention (ref)
cc @yixinmao

merged today: #402 so we're ready to get started here.

closed via #517


Failed conversion of MobileNet

Hi,
Has anyone have any luck converting MobileNet type architecture? We receive this error Pull #53 has been integrated.
Traceback (most recent call last):
File "convert.py", line 60, in
main()
File "convert.py", line 56, in main
args.phase)
File "convert.py", line 27, in convert
transformer = TensorFlowTransformer(def_path, caffemodel_path, phase=phase)
File "caffe-tensorflow\caffe-tensorflow-master\kaffe\tensorflow\transformer.py", line 221, in init
self.load(def_path, data_path, phase)
File "caffe-tensorflow\caffe-tensorflow-master\kaffe\tensorflow\transformer.py", line 254, in load
print_stderr(self.graph)
File "caffe-tensorflow\caffe-tensorflow-master\kaffe\errors.py", line 7, in print_stderr
sys.stderr.write('%s\n' % msg)
File "caffe-tensorflow\caffe-tensorflow-master\kaffe\graph.py", line 125, in str
tuple(out_shape)))
TypeError: unsupported format string passed to tuple.format
Thanks,
Tim

@ginger0106  Hi, I have finished converting caffe to tensorflow. But I am a little confused about conv function:
conv(3,3,32,1,1,biased=False,group=32,relu=False,name='conv2_1_dw')
Can you tell me how to write the conv function in network.py?
Please! Thank you very much!


Having two columns sorted desc on the same time

I am not sure if this is a bug or should be a feature request, but currently two columns cannot display rows descending both on the same time, only the first column will actually be desc but the other will be asc.

@alexdobsom Could you provide more details. Where does the data grid come from?


AddCommand documentation

Pull Request Test Coverage Report for Build 149

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.199%

Totals

Change from base Build 136:
0.0%

Covered Lines:
1993

Relevant Lines:
2367

💛  - Coveralls

Yea, okay looks good


Maven plugin fails when no runs have been executed

Using gatling with maven (gatling-maven-plugin)
Context
We currently use the plugin on our continuous integration server to test our performance.
Tests are run against docker images. And to be able to always shutdown/clean up all docker containers in a correct way, we use the failOnError property with value false to not have our build fail immediately and not being able to cleanup our environment in a decent way.
During the verify phase, the lastRun.txt is checked and if tests failed, build will also fail.
So far so good.
Problem case
But when there is for example a problem in our scala code that is used to perform the tests, errors will be shown, but due to the failOnError=false, this will not fail the build and next phases will be executed.
During the  verify phase, our lastRun.txt is empty in this case. And this will not fail the build.
So in the end it will look as if all was good, but in fact, no tests were executed at all.
Feature request
Is it possible to adapt the verify mojo to:

fail the build in case the lastRun.txt does not contain any entries, OR
introduce a configuration property to let the build fail if no entries are found in the lastRun.txt

I agree with the need but I disagree with the suggested solutions. IMHO, lastRun.txt should also store build failures and rethrow in verify.
Contributions welcome :)


Kotlin SDK

As much as I would love to have cross-platform SDK support for Featurevisor, I would suggest we hold on until the JavaScript SDK matures further.

Currently in progress here: https://github.com/featurevisor/featurevisor-kotlin


satty: init at 0.7.0

Description of changes
Added package for satty, a screenshot annotation tool inspired by Swappy and Flameshot.
Init from latest main commit, as it contains a fix (thanks @a-kenji !) for the build that is not in the release and breaks the build.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

@hmenke Hope I got it right after the back-and-forth. I've squashed the branch for clarity, it now packages release version + patch as suggested

Result of nixpkgs-review pr 268980 run on x86_64-linux 1

1 package built:

satty

Thanks for the notification @donovanglover !
Unfortunatly I didn't had time to write the derivation yet, but this looks great !
I'll give it a try tonight.

Satty already ships with a desktop item which only needs to be installed by the appropriate hook. The icon needs to be copied manually.
--- a/satty.nix
+++ b/satty.nix
@@ -10,6 +10,7 @@
 , libadwaita
 , pango
 , fetchpatch
+, copyDesktopItems
 }:

 rustPlatform.buildRustPackage rec {
@@ -35,6 +36,7 @@ rustPlatform.buildRustPackage rec {
   cargoHash = "sha256-0GsbWd/gpKZm7nNXkuJhB02YKUj3XCrSfpRA9KBXydU=";

   nativeBuildInputs = [
+    copyDesktopItems
     pkg-config
     wrapGAppsHook4
   ];
@@ -48,6 +50,12 @@ rustPlatform.buildRustPackage rec {
     pango
   ];

+  postInstall = ''
+    install -Dt $out/share/icons/hicolor/scalable/apps/ assets/satty.svg
+  '';
+
+  desktopItems = [ "satty.desktop" ];
+
   meta = with lib; {
     description = "Satty - A Screenshot Annotation Tool inspired by Swappy and Flameshot";
     homepage = "https://github.com/gabm/Satty";

LGTM! Maybe change the commit message to satty: init at 0.7.0.

I applied all the suggestions. Also renamed commit and PR to reflect the stable version.

Result of nixpkgs-review pr 268980 run on x86_64-linux 1

1 package built:

satty

Result of nixpkgs-review pr 268980 run on x86_64-linux 1

1 package built:

satty

(original author of satty here)
@pinpox @a-kenji thank you for this contribution! Would you mind adding installation instruction to Satty's README for other fellow nix users?


Info pages for some MAL entries (consistently) fail to load

I'm using the 2.1.1 release available here from GitHub, on a CM 12.1 (nightly) device without GApps.
I am experiencing a problem, by which the Info/Description pages for some anime/manga in MAL fail to load, with the following error message on the bottom of the screen:
Atarashii can't load the details
This seems to be deterministic - if I clear the App's cache and Local Data, reboot the device, and try again - the same entries fail to load. Also reproducible across a few different WiFi networks I have access to, and the Mobile Internet.
When I have a bit more time, I'll try to compile a short list of some entries which always do load, and respectively some which always don't. But otherwise, I'm not sure what other information I should provide - nonetheless I'm keen to if someone lets me know what I should share/do. :smile:

A list of a few titles that show this issue would be greatly appreciated.

Well for me, it feels like the majority of things.
Entries that work:

Mawaru Pengruindrum
Toaru Kagaku no Railgun
Golden Boy
Shakugan no Shana Specials
Hetalia World Series
Durarara!! Specials
Sayonara Zetsubou Sensei
Strike Witches

Entries that don't

.hack//Sign
Akikan!
Azumanga Daioh
Cardcaptor Sakura
Chobits
Gosick
Hanamaru Youchien
Hellsing Ultimate
Karigurashi no Arrietty
Lodoss-tou Senki
Serial Experiments Lain
Toradora!
Yuru Yuri
Zero no Tsukaima
Zero no Tsukaima F

I can keep adding to this if you really want, but I can reproduce this consistently. It'd be interesting to know if others have this problem too.

Confirmed that it is not an API issue.
In my custom build it loads fine, it could be a bug that I fixed after rewriting some parts. To be 100% sure we need to try to reproduce it on the same version as @aphirst.
I will look into this as soon I am done with the DB changes.

Running a quick test with 2.1.1 on a N9 with AOSP (factory image) and not seeing any issues with the titles. Some are on my list, some are not. Maybe this is CM-related? I'd love to see a logcat when the error occurs.

I tried to generate a log using logcat locally on the device (in the terminal Emu I ran logcat > filename.txt then switched to Atarashii and opened a few Anime entries), but the file I got out doesn't seem to be especially relevant: https://a.pomf.cat/ycsxqz.txt (I opened one "not working" then one "working" entry).
I tried it again (2 or 3 non-working, 2 working) and the log still seems irrelevant https://a.pomf.cat/dcoija.txt . I guess I'm doing something wrong? It looks like it's only logging stuff to do with the terminal emulator, which is obviously useless...

OK I think I got it, I gave the terminal emulator superuser priviliges. https://a.pomf.cat/njclmt.txt
I did a clear of Atarashii's Cache and Data, opened it fresh, enabled the log, tabbed into Atarashii, and opened the following 5 entries:

Elfen Lied (didn't load)
Elfen Lied Special (didn't load)
Ergo Proxy (didn't load)
Eve no Jikan (did load)
Fate Kaleid Liner Prisma Ilya (did load)

Awesome!
NetworkTask.doInBackground(): ANIME-task API error on job GETDETAILS: 200 - OK W/System.err( 4124): retrofit.RetrofitError: com.google.gson.JsonSyntaxException: java.lang.NumberFormatException: Expected an int but was 5.4 at line 1 column 2697 path $.storage_value W/System.err( 4124): 	at
This is your error and this is enough info to find the cause!

MAL supports floats on storage value, and the API documents that it will pass a "decimal number". The application should probably be fixed.

@aphirst I will release this week a quickpatch. Thanks for your help to find this issue!

@ratan12 No problem! Happy to help in the ways I can.
@motokochan How come, then, that it seemed to work fine on your side with AOSP? I'm curious to know :smile:

The cause was the storage value. We do not use that feature so we had no problems ;)

What he said. I don't usually set storage for the titles I watch. I think I may only have it on one title that I used for testing the API parsing.

The fix is ready. Once the API got updated I will release it.

@aphirst The fix got released yesterday.
I will not close this issue because it is still in version 2.2 which also must be fixed.

Fixed by 58a8dd8


made default.html HTML5 compliant and updated submodule

Fixes #169. Edited default.html to be HTML5 compliant. Also updated to latest brackets-browser-livedev commit.

I think the Travis build is failing because it's trying to update the sub-module to the one in my [PR] (https://github.com/humphd/brackets-browser-livedev/pull/53/commits) but it can't find it because it hasn't landed yet.

Looks good.  Make sure your other patch to move things to filer/lib/* includes this file (i.e., bbld will need a path update). r=me.


RTNETLINK answers: File exists but link does not exist in the net.

Description
I'm trying to create this simple topology:
{
  "nodes": [
    {
      "group": 10,
      "id": "h10"
    },
    {
      "group": 2,
      "id": "s20"
    },
    {
      "group": 2,
      "id": "s21"
    },
    {
      "group": 10,
      "id": "h30"
    }
  ],
  "links": [
    {
      "source": "s21",
      "target": "h10",
      "value": 10
    },
    {
      "source": "s20",
      "target": "h10",
      "value": 10
    },
    {
      "source": "s21",
      "target": "h30",
      "value": 10
    },
    {
      "source": "s20",
      "target": "s21",
      "value": 10
    },
    {
      "source": "s20",
      "target": "h30",
      "value": 10
    }
  ]
}

Below is the relevant part of the code and its output.
Code:
net.link = TCULink
for l in network_graph['links']:
    u, v, link_speed = l['source'], l['target'], l['value']
    print u, v
    net.addLink(nodes[u], nodes[v], link_speed)
    print [str(l) for l in net.links]

Output:
mininet ~/host
$ sudo mn -c; sudo python main.py
*** Removing excess controllers/ofprotocols/ofdatapaths/pings/noxes
<snip cleanup output>
*** Cleanup complete.
s21 h10
['s21-eth10<->h10-eth0']
s20 h10
['s21-eth10<->h10-eth0', 's20-eth10<->h10-eth1']
s21 h30
Traceback (most recent call last):
  File "main.py", line 43, in <module>
    net.addLink(nodes[u], nodes[v], link_speed)
  File "build/bdist.linux-x86_64/egg/mininet/net.py", line 366, in addLink
  File "build/bdist.linux-x86_64/egg/mininet/link.py", line 574, in __init__
  File "build/bdist.linux-x86_64/egg/mininet/link.py", line 559, in __init__
  File "build/bdist.linux-x86_64/egg/mininet/link.py", line 449, in __init__
  File "build/bdist.linux-x86_64/egg/mininet/link.py", line 493, in makeIntfPair
  File "build/bdist.linux-x86_64/egg/mininet/util.py", line 194, in makeIntfPair

Exception: Error creating interface pair (s21-eth10,h30-eth0): RTNETLINK answers: File exists

Expected/Desired Behavior:
The link should be created.
Actual Behavior:
An error occurs.
Detailed Steps to Reproduce the Behavior:
Just run the code in this Gist: https://gist.github.com/luism6n/ddbc3300789b2ddfe564daedfd186b47
Additional Information:
mininet ~/host
$ sudo mn --version
2.2.2
mininet ~/host
$ python --version
Python 2.7.6

I've solved it by not overwriting the default link constructor with:
net.link = TCULink
and instead adding links to the network using:
net.addLink(nodes[u], nodes[v], cls=TCULink, bw=link_speed)


make local fastq bigger

fixes issue with ecoli test

ugh the snakemake actions is broken: https://github.com/snakemake/snakemake-github-action/issues/38 can just merge this anyway. its just ecoli fastqs.


This tool should work even if the working directory includes spaces on Windows.

1.1.1 solves this issue.

5f83d708448f21738b05600d6011f9a979a00528 fixes this.


[Storage] Fix #26567: az storage blob download-batch:  When matching pattern, list blobs with prefix to reduce the number of list calls.

Related command

az storage blob download-batch:
Description

When matching pattern, previously first grabs the full list before trying to filter. Now list blobs with prefix to reduce the number of list calls.
Testing Guide

History Notes

[Storage] : az storage blob download-batch:  When matching pattern, list blobs with prefix to reduce the number of list calls.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage


Dump new documents of an index partially dumped to other elastic cluster

Context
In order to help us troubleshoot issues with this project, you must provide the following details:

ElasticDump version 6.8
Elasticsearch version 6.8
Node.js version (note that nodejs v10+ is required for this tool) 18.20.2
Full command you are having issue with (with inputs and outputs) ["elasticdump", es_input_url, es_output_url, access_key, secret_key, "--retryAttempts=3", "--retryDelay=3", "--limit=5000", "--scrollTime=10m", "--type=data"]
A data-set you can share publicly which reproduces the problem NA or any small document count

Describe the bug
Dumping from one elastic cluster to another for 3 documents is successfully done, now after 5mins or so, I get new documents in source elastic cluster, I want to dump only the remaining documents newly added in source. How can I do it?
To Reproduce
I tried scrollId, where I'm passing the scrollId in next run to dump remaining docs, I don't get the newly added docs with this scrollId. Probably because in that scroll time ES didnt get the new docs.
Current behavior
Unable to correctly dump ONLY remaining docs
Expected behavior
I want to dump remaining docs, and not start all over again.

You can use the "searchBody" to filter out the remaining document. It's accepts an elastic search query/filter

Ok, how can I pass the "from" attribute in this? for example:
{"from":2,"size":100,"query":{"match_all":{}}}

elasticdump \
  --input= es_input_url \
  --output= es_output_url \
  --searchBody="{\"from\":2,\"size\":100,\"query\":{\"match_all\":{}}}"


v6: explore different styles for active (toggled) and disabled controls to not rely on use of color

Description
Come up with changes/different styles for the toggled/active styling, which currently relies on use of color
Motivation & Context
The active class (when it conveys the toggled/pressed state of a control - not required for just regular non-toggle-able controls) should have a much stronger differentiation with the non-active class for cases like button toggles, custom checkboxes/radio buttons, dropdown triggers.
The same arguably also applies to disabled controls - they need to visually be differentiated from operable/active controls, without relying just on shading/tinting (OR the shading/tinting needs to have a difference of 3:1 to the regular state).
If we're only going by a change of background, as is currently the case, the difference between the non-active and active background should be at least a ratio of 3:1 (see the second note in https://www.w3.org/WAI/WCAG21/Understanding/use-of-color.html ... which, incidentally, i wrote)
This approach (making the active style darker for dark controls, lighter for light controls) gets very limiting, as there simply aren't enough shading/tinting options for all our colours to reliably get to a 3:1 ratio, both for disabled and for active (toggled) state.
This branch explores some options. It's not meant as a mergeable PR at this point, but for initial exploration
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[x] Breaking change (fix or feature that would change existing functionality)

Checklist

[ ] I have read the contributing guidelines
[ ] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-37434--twbs-bootstrap.netlify.app/

Related issues
https://github.com/twbs/bootstrap/issues/37365

First attempt, simply increasing the shading/tinting for .active. While the current change works well for the regular primary colour button, the difference is not sufficient for other colours (to see them all in action, check the button dropdowns at the end of https://deploy-preview-37434--twbs-bootstrap.netlify.app/docs/5.2/components/dropdowns/#single-button)
Suspect we may think beyond a change in background/border, to something more drastic. Some initial ideas:

split out the intent: keep .active as it is, but then make specific extra styles (either as a new class, or with more specific selectors) for toggle buttons, dropdown toggles, custom checkboxes/radio buttons...anywhere where we currently just lazily piggy-back on the .active class to visually show something more than just the classic :active state
for dropdowns, we can make use of the down-arrow chevron icon better. have the icon point up when toggle/pressed. this provides a visual cue about the control's state that does not rely on colour
for checkboxes/radio buttons, perhaps take the same approach as the outlined checks and radios https://deploy-preview-37434--twbs-bootstrap.netlify.app/docs/5.2/forms/checks-radios/#outlined-styles ... these don't rely specifically on use of color, as they essentially invert the control (though need to see how they fare with the lighter colours in our palette...those may need a further visual boost). for the non-outlined version, we could reverse the styles: non-checked/selected has solid background, selected/checked only has border. alternatively, for the solid background button styles, introduce an additional outline for the checked/pressed state.
for toggle buttons, take a similar approach? go for solid vs border only? or have additional border/outline?


PropCore: added propInertia()

Sets the directional inertia

can you change it to setInertia (setMass)?

Originally it was setInertia(), the reason for propInertia() was to leave all with the same syntax of propcore extension. (propBreak, propDrag, propDraw, propShadow, propSetBuoyancy...)


App won't open

How do I uninstall the app and remove the shortcut?

Hello @u-Ter.
You can try this:
sudo rm -Rf /opt/trello*
sudo rm -Rf /usr/bin/trello
sudo rm -Rf /usr/share/applications/trello.desktop
Regards


[ENH] preventing potential typo issues

As there can be multiple ways people understand several distributions, e.g., log_normal, logNormal, LOGNORMAL it is better to have a constant variable pointing to a fix string representation for both the internals and the user so that typos can be avoided

see -> 6faaa7f5401fb9aec8c4e90cb404f2f50c7dd8e8


Bugfix/fix edge

Problem
process.nextTick prevents the client from working in edge environments
Solution
Commented out process.nextTick for now. This may cause text to break.
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ *] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Test Plan
Manually testing the client.

Seems like this will address #44

I force-pushed because I wanted to revert the commits where you'd bumped versions and stuff, since publishing is now handled by a github actions workflow.


Safari - RangeError: Maximum call stack size exceeded.

When trying to test my application in Safari I am getting RangeError: Maximum call stack size exceeded. error and the app won't boot. However the app works fine in Chrome.
I narrowed it down to this module by completely removing the initialization of Aurelia and having my main.js file only import aurelia-bootstrapper-webpack. Just importing this module will cause the error above to happen.
The stack trace points to the following block of code in my bundle.js.
            function createCollection(proto, objectOnly) {
                function Collection(a) {
                    if (!this || this.constructor !== Collection)
                        return new Collection(a);
                    this._keys = [];
                    this._values = [];
                    this._itp = [];
                    this.objectOnly = objectOnly;

                    if (a)
                        init.call(this, a);
                }

We've got new official webpack setups now. Perhaps there was a configuration issue. We haven't been able to reproduce this issue.


[usb] Rework I/O

This PR reworks the I/O of the USB device such that topgen can be used for the top-level integration.
To ease review, the autogenerated files are in a separate commit. I will squash these before merging.
This PR is related to #1677.

This might be of interest for @stefanlippuner .

Thanks @mdhayter and @eunchan for your reviews and feedback. I will leave this one open for a couple more hours, before squashing and merging.


feat(mongod_host): added multi-host cluster configuration

Hello, this pull request introduces the capability to create a cluster from multiple nodes.
Currently, by default, in your repository it's only possible to create a single node in a cluster. This PR enables adding/removing additional nodes.

can you write an example with multiple hosts?

I'm not sure if you need an example for

Why multiple nodes are needed in a cluster?
An example of creating multiple nodes through the module?

If it's the second option, in the 'examples' directory, I've updated the main.tf to create two nodes, the number can be more or fewer as required.
This PR does not limit the use of a single node in a cluster.


Consider using directive form for "For SGo:" doc comments.

In the README, there's a section describing "For SGo:" doc comments.
https://github.com/tcard/sgo#for-sgo-doc-comments
Right now they look like this:
// For SGo: func(string, func(w http.ResponseWriter, req *http.Request)
func HandleFunc(pattern string, handler func(ResponseWriter, *Request))

Which looks a lot like a normal comment written by humans for humans, without following any special syntax and without having special meaning to a compiler or other tool. Someone who's unfamiliar with it may think the above code is no different than:
// This is for SGo: func(string, func(w http.ResponseWriter, req *http.Request)
func HandleFunc(pattern string, handler func(ResponseWriter, *Request))

But that would be significantly different.
I have a question. Have you considered using the directives comment form for this? Such comments are distinguishable from normal human comments because they don't have a space between the // and the first character, and they usually have the form //tool:subtool, for example:
//go:generate foo bar

Similarly, you could use the following syntax for your "For SGo:" doc comments:
//sgo:for func(string, func(w http.ResponseWriter, req *http.Request)
func HandleFunc(pattern string, handler func(ResponseWriter, *Request))

Or something like that (I would imagine it'd begin with //sgo: but not sure as to what to place after the colon).
What do you think?

I'm not sure right now how would that interact with godoc and friends. Would that directive still be considered a doc comment?
"For SGo" annotations are intentionally supposed to be human-readable. One of the key principles of SGo is to keep friction with pure Go as minimal as possible. Having Go code cluttered with SGo directives works against this. If the SGo-related metadata is presented as human readable documentation, that also shows up in godoc (and godoc.org) and specifies the "contract" of the documented thing for human Go coders, this friction is reduced, in my opinion. I see your point, but I'm not sure that's the right tradeoff here.
Consider also that most of the time those comments will appear in .go files translated from adjacent .sgo files, so only people totally unacquainted with the codebase and build process could be tempted to alter them.

I see your points, and those are good arguments for keeping it more human readable.
The comments would still appear in godoc, since they're attached to the identifier. But they certainly look more "for the machine" than for humans.
I guess the challenge here is you want something that works both for humans, and for machines, but different from regular "for humans-only" comments.
When perusing Go code in general, when I see comments that look like for humans, I expect that changing them should not break the program.
I suppose my only suggestion is to try it out, and see how it looks. If the //sgo:for looks very ugly, then too bad. But if it grows on you and you start to find it readable/nice while still being clear that it's semantically important and not something just for humans that can be changed without breaking programs, then that's a huge win.

A few months have passed and I'm not aware of anybody else using or reading SGo besides me and by extension some of my coworkers that can give their input on this (if anybody else is using it, I'd love to know!). We haven't had any problem with the current form, and I still prefer it for the reasons above.
I'm closing this issue then. Thanks @shurcooL though!

Sounds good, thanks for considering it! 👍


Add serialization support for std.typecons.Typedef!T.

Any news on this?

Didn't notice that this was still sitting here...


Cleaner and tighter.

I did rename one or two public methods, but AFAIK they are all still pre-release, so now is the time to get them right.
I tested performance between the before/after and find no difference. I did add a multi-threaded test to try to detect any race conditions (haven't found any in a few hundred runs), and it can also serve as a decent quick test balloon on performance because it is designed to generate maximum contentention.

@TobiasSQL Again, possibly best viewed by just pulling my branch local (note it is metadataCaching2 not metadataCaching) and using the diffs here as a guide.

Codecov Report

Merging #291 into metadataCaching will decrease coverage by 0.08%.
The diff coverage is 73.5%.

@@                  Coverage Diff                  @@
##             metadataCaching     #291      +/-   ##
=====================================================
- Coverage              37.34%   37.26%   -0.09%
+ Complexity              1751     1745       -6
=====================================================
  Files                    106      106
  Lines                  24429    24435       +6
  Branches                3976     3974       -2
=====================================================
- Hits                    9124     9106      -18
- Misses                 13684    13701      +17
- Partials                1621     1628       +7

Flag
Coverage Δ
Complexity Δ

#JDBC41
37.07% <73.5%> (-0.19%)
1733 <28> (-10)

#JDBC42
37.18% <73.5%> (-0.01%)
1743 <28> (+4)

Impacted Files
Coverage Δ
Complexity Δ

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
59.08% <100%> (-0.62%)
129 <0> (-2)

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
45.43% <70.29%> (-0.34%)
279 <26> (+8)

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
33.83% <93.33%> (-0.23%)
99 <2> (-5)

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
47.79% <0%> (-1.48%)
9% <0%> (-1%)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
29.24% <0%> (-0.9%)
55% <0%> (-2%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
26.83% <0%> (-0.8%)
183% <0%> (-7%)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
36.96% <0%> (-0.07%)
0% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
47.11% <0%> (+0.14%)
196% <0%> (+1%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5ba9b...9e73ba8. Read the comment docs.

@brettwooldridge, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@TobiasSQL Sorry I need poking at this, squashing and pushing tweaks.  I'll resolve the above conflicts that have surfaced.
I have separate change set I'm working on, built on top of these changes, that are showing 3-10x improvements in transactions per second across the board (both prepared statements and regular statements).  Rather than continually piling on the metadataCaching branch, I'll hold those until the branch is merged into the mainline.

Rebased.  All tests passing.  Feel free to ask about any particular change.

In summary...
Observation: The prepared statement handle cache and prepared metadata cache are largely orthogonal.  For example, the handle cache can be enabled, but the metadata cache disabled, and vise-versa.

If we ignore the metadata cache (assume disabled), the handle is borrowed in the SQLServerPreparedStatement constructor, and released in closeInternal() (as before).
When the metadata cache is enabled, the metadata cache acts as an additional client -- equivalent to a user prepared statement -- and borrows the statement handle when the metadata cache entry is created, and releases it when the cache entry is evicted.
Treating the cache a just another client simplifies the state management.  Because of the symmetry in acquisition/release it is not possible for the reference count to "over reference" or "under reference" the statement handle.

Running multi-threaded oltpbenchmark harness's JPAB benchmark with ~75,000 transactions and eight clients under the profiler also showed 0 thread contentions on any of the cache collections (handle or metadata).
02:27:26,097 (DBWorkload.java:801) INFO  - ======================================================================
02:27:26,097 (DBWorkload.java:802) INFO  - Rate limited reqs/s: Results(nanoSeconds=40000512846, measuredRequests=76630) = 1915.7254381967982 requests/sec
02:27:26,099 (DBWorkload.java:675) INFO  - Output Raw data into file: results/jpab-newer.32.csv
02:27:26,742 (DBWorkload.java:709) INFO  - Output into file: results/jpab-newer.32.res
02:27:26,742 (DBWorkload.java:712) INFO  - Grouped into Buckets of 5 seconds
02:27:26,788 (DBWorkload.java:613) INFO  - ======================================================================
02:27:26,788 (DBWorkload.java:614) INFO  - Workload Histograms:
Completed Transactions:
Persist/01           [ 3792] *****
Retrieve/02          [53728] ********************************************************************************
Update/03            [15246] **********************
Delete/04            [ 3872] *****

Thanks a ton @brettwooldridge!
I have started going through this and merging with changes I have been working on, posting comments as I go :-)

@brettwooldridge, thanks a lot for your help in improving the performance of our JDBC driver! We are currently working on stabilizing the code to prepare for our next release. This includes running a bunch of automated tests in our test framework, which we haven't managed to put on GitHub yet. I've told @TobiasSQL that we need to merge these metadata caching changes ASAP to start stabilizing. Him and I agree that we should take your updated API names. @TobiasSQL is working on merging changes from your branch, and will continue to take more after stabilizing.
Please let us know if there's anything, especially related to public API names, that you strongly feel we should get into the next release.
Again, thank you so much for your help thus far. We really appreciate your time! 😄

Andrea

@ajlam @TobiasSQL Thanks to everyone for moving the driver forward, and huge kudos to Microsoft for open sourcing the driver in the first place!
I don't envision any changes to the public API.  I am working on a set of caching improvements based on some profiling runs that I think will provide a large performance increase, particularly for patterns employed by ORM frameworks.  I don't have a solid completion date, but possibly within the week.

Thanks @brettwooldridge, I just finished a push into metadataCaching fixing some issues found by tests in our old infrastructure (related to cursors). Also cleaned up public APIs a bit, would be great if you take a peek at those (especially related to "discard actions/unprepare") so we can make any changes before the next public release. As @ajlam mentioned, once we have things stabilized for the release we should continue the optimizations, hopefully we can then just take your PRs directly :-)

Some comparables of current progress
Using the v6.1.6-preview driver:
04:16:06,153 (DBWorkload.java:801) INFO  - ======================================================================
04:16:06,154 (DBWorkload.java:802) INFO  - Rate limited reqs/s: Results(nanoSeconds=40001173473, measuredRequests=80252) = 2006.2411432546726 requests/sec
04:16:06,157 (DBWorkload.java:675) INFO  - Output Raw data into file: results/jpab-newer.53.csv
04:16:06,844 (DBWorkload.java:709) INFO  - Output into file: results/jpab-newer.53.res
04:16:06,844 (DBWorkload.java:712) INFO  - Grouped into Buckets of 5 seconds
04:16:06,900 (DBWorkload.java:613) INFO  - ======================================================================
04:16:06,900 (DBWorkload.java:614) INFO  - Workload Histograms:
Completed Transactions:
Persist/01           [ 4121] *****
Retrieve/02          [63980] ********************************************************************************
Update/03            [ 8090] **********
Delete/04            [ 4071] *****

From my speedify branch, consisting of the metadataCache2 branch plus ongoing work...
04:10:18,202 (DBWorkload.java:801) INFO  - ======================================================================
04:10:18,202 (DBWorkload.java:802) INFO  - Rate limited reqs/s: Results(nanoSeconds=40000398344, measuredRequests=92646) = 2316.126934618309 requests/sec
04:10:18,205 (DBWorkload.java:675) INFO  - Output Raw data into file: results/jpab-newer.52.csv
04:10:19,005 (DBWorkload.java:709) INFO  - Output into file: results/jpab-newer.52.res
04:10:19,005 (DBWorkload.java:712) INFO  - Grouped into Buckets of 5 seconds
04:10:19,081 (DBWorkload.java:613) INFO  - ======================================================================
04:10:19,082 (DBWorkload.java:614) INFO  - Workload Histograms:
Completed Transactions:
Persist/01           [ 4750] *****
Retrieve/02          [74045] ********************************************************************************
Update/03            [ 9246] *********
Delete/04            [ 4615] ****

More work to do ... the big wins (eg. ResultSet metadata caching) aren't in there yet.

@TobiasSQL : I guess your metadatacaching includes this fix too. If so we can close this PR.

Yes, I think this particular PR I have picked up most everything from into my PR. Brett has been doing a bunch of more work that he was planning to issue a PR for as soon as my changes make it back to master (when do you expect that to happen?). @brettwooldridge is that accurate?

@TobiasSQL That is accurate.

Closing this PR as @TobiasSQL already include this in his patch.
@TobiasSQL : Your patch is already in Master & DEV.

Brett has been doing a bunch of more work that he was planning to issue a PR for as soon as my changes make it back to master (when do you expect that to happen?).

@v-nisidh, oh, I did not realize (maybe I should have looked...). Hey @brettwooldridge that means we are ready for you to start PRing your speedify stuff :-)


Feat(event) - added nonInteraction option

Implementing the non-interaction events https://developers.google.com/analytics/devguides/collection/analyticsjs/events#non-interaction_events
@kaesonho I'm not sure about how you would like to implement this. Could you review please?

IMO the flatten-style arguments for ga is a little bit awkward :(
It strictly depends on the arguments order, which might be lead to trouble of scalability
According to fieldsObject, it should be better to refactor to  sth like
var params = {
    hitType: 'event',
    eventCategory: model.category || DEFAULT_CATEGORY,
    eventAction: model.action || DEFAULT_ACTION,
    eventLabel: model.label || i13nNode.getText(payload.target) || DEFAULT_LABEL,
    eventValue: model.value || 0,
    transport: model.transport || 'none',
    nonInteraction: model.nonInteraction || false
};

_command.call(this, {
  tracker: model.tracker || '',
  commandName: 'send',
  arguments: [params]
});

@hero78119 @kaesonho I did a bit of refacto to use the ga fieldsObject :)

thanks for the update 👍

it's published https://github.com/kaesonho/react-i13n-ga/releases/tag/v0.2.5 :)


Added icons to headings in footer #1543

Description
This PR fixes #1543
Notes for Reviewers
I have added icons to the footer of the meshery.io page
Signed commits

[x] Yes, I signed my commits.

@leecalcote @ritiksaxena124 would like to have a look at this issue.

Hey @hemantmm ,
Thanks for raising the PR, Please add this as your agenda in Doc to discuss it in the Website Meeting tomorrow at 6:30 PM IST.
Subscribe to community calendar for more details of meetings at Layer5.

Sorry for not attending the meet!

Hey, @leecalcote  @saurabh100ni will not be able to attend the meeting due to college at 6 pm when the meeting starts I will be traveling on the bus and reaching home around 7:30 pm.
So, could have a look at the PR?

@vishalvivekm can answer this.

@vishalvivekm you can check now!

@hemantmm closed?

@vishalvivekm actually by mistake some other files were pushed while pushing the changes that's why I have created a new PR.


load/overload should return the array variables

When I call the load functions I get a list which is like this:
array(2) {
  [0] =>
  string(22) "SYMFONY_ENV=production"
  [1] =>
  string(15) "SYMFONY_DEBUG=0"
}

I don't want to parse it again, it would be nice to have the key value as const => value, this way I can proceed with my own customization.
What led me to this is because dotenv doesn't convert booleans to proper typing and in the issue you say its not going to be implemented, but I want to do it in my own software right after loading the variables and rewrite them if I need to.
Do you think its a viable solution to change the return type of load/overload or provide a way to read those variables back?
Thanks!

Duplicate issue.

@GrahamCampbell could you link the main issue?


Filter lower versions when checking ignored versions

Changes the condition that raises AllVersionsIgnored when all new
versions are ignored when there are some new versions, filtering out
lower versions.
I opted to do this in the condition to not introduce any breaking
changes in the version checkers.
I've also explored always filtering lower version before filtering
ignored versions but this has been implemented inconsistently across
package managers so could cause a bunch of subtle bugs.
Most package managers only filter lower versions when checking for the
lowest security fix version, and rely on the latest version being set,
even if it's the current version. 🤦♂
I wonder if it would make more sense to do a separate refactor to start
using the UpdateConfig and IgnoreCondition classes in a more generic
way in the base update checker instead of doing the same filtering in each
package manager.

@thepwagner I've attempted to fix this issue where currently we won't raise AllVersionsIgnored  when ignoring update types as these only filter new versions:
Pre:

Post:

So now, if the ignore conditions end up rejecting all new versions we raise.

[ ] Add some test cases

I made it through about half of the ecosystems. The GitCommitChecker is not yet passing but I haven't dug in yet to see if my test setup is wrong or if target code needs some adjustment.


Final lint fixes

Motivation
Finish linting fixes.
Changes
Fix linting issues across the project.

bors merge

bors merge

bors merge


Removing  function 'send_email'

It's insecure, not used in the code and undocumented.
Fixing #2008
Please also note that sending email from Dashboard is implemented in completely different commit 'e2a70d8' and not use 'send_email' function at all.

You also need to remove the call to this endpoint from inside of the UI.

You also need to remove the call to this endpoint from inside of the UI, unless that UI component uses some newer logic.

That's a point - there's no call from UI exist. Or any other call. It looks like some abandoned piece of code, which was never used.

Which UI component?  I find no callers of send_email.

It looks like we can also get rid of the SMTP_SERVER config setting, which isn't used anywhere else.

@DanCech : well... Dashboard have ability to send email, see https://github.com/graphite-project/graphite-web/commit/e2a70d8fe5a37ed52cd8166233607bcc50c15b64

It's probably also worth to backport it to 0.9.x and 1.0.x
Not sure should we make new releases for this branches... Maybe fixed branch should be enough.

Yes but that doesn't use that config setting, it uses the django EmailMessage class which is configured via the django EMAIL_* settings.

Yes but that doesn't use that config setting, it uses the django EmailMessage class which is configured via the django EMAIL_* settings.

Ah, nice find then, @DanCech
Removed together with unused imports.

Codecov Report

Merging #2499 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
- Coverage   80.01%   79.88%   -0.13%
==========================================
  Files          85       85
  Lines        9131     9040      -91
  Branches     1948     1938      -10
==========================================
- Hits         7306     7222      -84
+ Misses       1544     1537       -7
  Partials      281      281

Impacted Files
Coverage Δ

webapp/graphite/settings.py
74.75% <ø> (-0.13%)
:arrow_down:

webapp/graphite/composer/views.py
23.8% <ø> (-31.75%)
:arrow_down:

webapp/graphite/composer/urls.py
100% <ø> (ø)
:arrow_up:

webapp/graphite/tags/utils.py
79.41% <0%> (-1.67%)
:arrow_down:

webapp/graphite/readers/rrd.py
85.48% <0%> (-0.67%)
:arrow_down:

webapp/graphite/carbonlink.py
51.61% <0%> (-0.32%)
:arrow_down:

webapp/graphite/functions/views.py
94.28% <0%> (-0.31%)
:arrow_down:

webapp/graphite/node.py
92.59% <0%> (-0.27%)
:arrow_down:

webapp/graphite/readers/multi.py
92.15% <0%> (-0.16%)
:arrow_down:

webapp/graphite/tags/localdatabase.py
94.36% <0%> (-0.13%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021cfe6...5a5f231. Read the comment docs.


Update how to managed network

Added limitation for compute resources in managed vnet.

@jhirono
Can you review this PR? Sign off or approve if you accept the changes.
Note: To sign off, add a #sign-off comment to the PR.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


persist override of HUGINN_PORT

fixes #2447

Those legacy HUGINN_ prefixes keep biting us 😒
I think your solution should not break any other use case of the variables.
@baip Could you please double check that I am not missing something?


[JENKINS-62669] Mercurial support going away from Bitbucket

Matches https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/320.

Sorry, something messed up with the fork I guess.

(You are supposed to delete your “fork” after @jenkinsci clones it.)


23.2.0a1: DynamicTraitedSpec object has no attribute T1w_preproc

What happened?
Using the new alpha release, fMRIPrep quickly failed. Note that this same command worked on the same dataset at an earlier version of the next branch pulled about a week ago.

Singularity
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
FreeSurfer
Please copy and paste any relevant log output.
<EMAIL_ADDRESS>(node:17) Warning: Closing directory handle on garbage collection
(Use `node --trace-warnings ...` to show where the warning was created)
This dataset appears to be BIDS compatible.
        Summary:                Available Tasks:                     Available Modalities:
        92 Files, 2.44GB        NSD Functional Localizer Task        MRI
        1 - Subject
        1 - Session

	If you have any questions, please post on https://neurostars.org/tags/bids.
231121-12:51:29,909 nipype.workflow IMPORTANT:
	 Running fMRIPrep version 23.2.0a1

         License NOTICE ##################################################
         fMRIPrep 23.2.0a1
         Copyright 2023 The NiPreps Developers.

         This product includes software developed by
         the NiPreps Community (https://nipreps.org/).

         Portions of this software were developed at the Department of
         Psychology at Stanford University, Stanford, CA, US.

         This software is also distributed as a Docker container image.
         The bootstrapping file for the image ("Dockerfile") is licensed
         under the MIT License.

         This software may be distributed through an add-on package called
         "Docker Wrapper" that is under the BSD 3-clause License.
         #################################################################
231121-12:51:30,273 nipype.workflow IMPORTANT:
	 Building fMRIPrep's workflow:
           * BIDS dataset path: /om2/scratch/tmp/smeisler/fsub_proc/sub-01/data.
           * Participant list: ['01'].
           * Run identifier: 20231121-125116_d251562e-f5a8-4dc6-8496-73f04e37b896.
           * Output spaces: T1w fsnative MNI152NLin2009cAsym:res-native.
           * Pre-run FreeSurfer's SUBJECTS_DIR: /om2/scratch/tmp/smeisler/fsub_proc/sub-01/data/derivatives/freesurfer.
231121-12:51:31,727 nipype.workflow INFO:
	 ANAT Stage 1: Adding template workflow
231121-12:51:32,324 nipype.workflow INFO:
	 ANAT Stage 2: Preparing brain extraction workflow
231121-12:51:32,414 nipype.workflow INFO:
	 ANAT Stage 3: Preparing segmentation workflow
231121-12:51:32,420 nipype.workflow INFO:
	 ANAT Stage 4: Preparing normalization workflow for ['MNI152NLin2009cAsym', 'MNI152NLin6Asym']
231121-12:51:32,433 nipype.workflow INFO:
	 ANAT Stage 5: Preparing surface reconstruction workflow
231121-12:51:32,454 nipype.workflow INFO:
	 ANAT Stage 6: Preparing mask refinement workflow
231121-12:51:32,457 nipype.workflow INFO:
	 ANAT Stage 7: Creating T2w template
231121-12:51:32,466 nipype.workflow INFO:
	 ANAT Stage 8: Creating GIFTI surfaces for ['white', 'pial', 'midthickness', 'sphere_reg', 'sphere']
231121-12:51:32,487 nipype.workflow INFO:
	 ANAT Stage 8: Creating GIFTI metrics for ['thickness', 'sulc']
231121-12:51:32,495 nipype.workflow INFO:
	 ANAT Stage 8a: Creating cortical ribbon mask
231121-12:51:32,499 nipype.workflow INFO:
	 ANAT Stage 9: Creating fsLR registration sphere
231121-12:51:32,503 nipype.workflow INFO:
	 ANAT Stage 10: Creating MSM-Sulc registration sphere
231121-12:51:33,717 nipype.workflow INFO:
	 B0 field inhomogeneity map will be estimated with the following 3 estimator(s): [<EstimatorType.PHASEDIFF: 3>, <EstimatorType.PHASEDIFF: 3>, <EstimatorType.PHASEDIFF: 3>].
231121-12:51:34,413 nipype.workflow INFO:
	 Setting-up fieldmap "auto_00000" (EstimatorType.PHASEDIFF) with <sub-01_acq-fMRI_run-2_phasediff.nii.gz, sub-01_acq-fMRI_run-2_magnitude1.nii.gz, sub-01_acq-fMRI_run-2_magnitude2.nii.gz>
231121-12:51:34,413 nipype.workflow INFO:
	 Setting-up fieldmap "auto_00001" (EstimatorType.PHASEDIFF) with <sub-01_acq-fMRI_run-3_phasediff.nii.gz, sub-01_acq-fMRI_run-3_magnitude1.nii.gz, sub-01_acq-fMRI_run-3_magnitude2.nii.gz>
231121-12:51:34,413 nipype.workflow INFO:
	 Setting-up fieldmap "auto_00002" (EstimatorType.PHASEDIFF) with <sub-01_acq-fMRI_run-4_phasediff.nii.gz, sub-01_acq-fMRI_run-4_magnitude1.nii.gz, sub-01_acq-fMRI_run-4_magnitude2.nii.gz>
231121-12:51:35,102 nipype.workflow INFO:
	 Stage 1: Adding HMC boldref workflow
231121-12:51:35,110 nipype.workflow INFO:
	 Stage 2: Adding motion correction workflow
231121-12:51:35,119 nipype.workflow INFO:
	 Stage 3: Adding coregistration boldref workflow
231121-12:51:35,184 nipype.workflow IMPORTANT:
	 BOLD series will be slice-timing corrected to an offset of 0s.
231121-12:51:36,62 nipype.workflow INFO:
	 Stage 1: Adding HMC boldref workflow
231121-12:51:36,68 nipype.workflow INFO:
	 Stage 2: Adding motion correction workflow
231121-12:51:36,73 nipype.workflow INFO:
	 Stage 3: Adding coregistration boldref workflow
231121-12:51:36,132 nipype.workflow IMPORTANT:
	 BOLD series will be slice-timing corrected to an offset of 0s.
231121-12:51:36,404 nipype.workflow INFO:
	 Stage 1: Adding HMC boldref workflow
231121-12:51:36,410 nipype.workflow INFO:
	 Stage 2: Adding motion correction workflow
231121-12:51:36,416 nipype.workflow INFO:
	 Stage 3: Adding coregistration boldref workflow
231121-12:51:36,478 nipype.workflow IMPORTANT:
	 BOLD series will be slice-timing corrected to an offset of 0s.
231121-12:51:36,749 nipype.workflow INFO:
	 Stage 1: Adding HMC boldref workflow
231121-12:51:36,755 nipype.workflow INFO:
	 Stage 2: Adding motion correction workflow
231121-12:51:36,761 nipype.workflow INFO:
	 Stage 3: Adding coregistration boldref workflow
231121-12:51:36,820 nipype.workflow IMPORTANT:
	 BOLD series will be slice-timing corrected to an offset of 0s.
231121-12:51:37,92 nipype.workflow INFO:
	 Stage 1: Adding HMC boldref workflow
231121-12:51:37,99 nipype.workflow INFO:
	 Stage 2: Adding motion correction workflow
231121-12:51:37,104 nipype.workflow INFO:
	 Stage 3: Adding coregistration boldref workflow
231121-12:51:37,161 nipype.workflow IMPORTANT:
	 BOLD series will be slice-timing corrected to an offset of 0s.
231121-12:51:37,434 nipype.workflow INFO:
	 Stage 1: Adding HMC boldref workflow
231121-12:51:37,598 nipype.workflow INFO:
	 Stage 2: Adding motion correction workflow
231121-12:51:37,603 nipype.workflow INFO:
	 Stage 3: Adding coregistration boldref workflow
231121-12:51:37,663 nipype.workflow IMPORTANT:
	 BOLD series will be slice-timing corrected to an offset of 0s.
231121-12:51:41,882 nipype.workflow INFO:
	 fMRIPrep workflow graph with 1961 nodes built successfully.
231121-12:51:55,5 nipype.workflow IMPORTANT:
	 fMRIPrep started!
231121-12:51:56,682 nipype.workflow CRITICAL:
	 fMRIPrep failed: 'DynamicTraitedSpec' object has no attribute 'T1w_preproc'

Additional information / screenshots
An HTML file was created that said there were no errors, oddly enough.

Wow, not sure how I missed that one. That'll be a fix in smriprep.


Update parser.ts to support function callbacks in args

Simple fix for https://github.com/Morglod/bun-ffi-gen/issues/4.
Still, callback types are not generated, limiting the quality of the final bindings.

please provide header file with this case because for now it generates function pointer inside args
may be its some corner case


⚠ Bofrost.be has degraded performance

In df53b79, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1940 ms

Resolved: Bofrost.be performance has improved in 6b637a9 after 43 minutes.


unable to open file explorer with node v8.10

Steps to reproduce
Tell us about your environment:

ndb version: 1.0.43
Platform / OS version: macOS Mojave 10.14.3
Node.js version: 8.10

What steps will reproduce the problem?
Using the below package version:

esm => 3.0.84

ndb => 1.0.26

setup ndb with node version 8.10 and run below command

ndb -r esm index.js

Please include code that reproduces the issue.
[skip]
What is the expected result?

Source>Filesystem should have file explorer open and allow the app to debug

What happens instead?

ndb has opened with no source
no error in terminal and the app is not starting
after terminating the app getting the below error,

    at process.target.send (internal/child_process.js:588:16)
    at Rpc.routeMessage_ (/Users/ashwinsoni/test-ndb/node_modules/carlo/rpc/rpc.js:393:10)
    at Rpc.sendCommand_ (/Users/ashwinsoni/test-ndb/node_modules/carlo/rpc/rpc.js:333:10)
    at Handle.callMethod_ (/Users/ashwinsoni/test-ndb/node_modules/carlo/rpc/rpc.js:79:38)
    at WebSocket.ws.once (/Users/ashwinsoni/test-ndb/node_modules/ndb/services/ndd_service.js:95:24)
    at Object.onceWrapper (events.js:317:30)
    at emitTwo (events.js:126:13)
    at WebSocket.emit (events.js:214:7)
    at WebSocket.emitClose (/Users/ashwinsoni/test-ndb/node_modules/ws/lib/websocket.js:180:10)
    at Socket.socketOnClose (/Users/ashwinsoni/test-ndb/node_modules/ws/lib/websocket.js:802:15)

Please, have a look to 239#. Does it work for you?

Thanks @felixdrp for the reference.
Still the error persist.

Please check out<EMAIL_ADDRESS>it contains more reliable implementation of file system.

Feel free to comment this issue or file another one if you still can reproduce it with latest ndb release.

Thanks, @ak239 for the update. Yes<EMAIL_ADDRESS>works amazing.


Initial CI

Tested locally. GitHub Actions runs only if the workflow exists in the main branch.

Thanks for the change Vitalia!

Thanks for the change Vitalia!

now you have tests :)


Settings not saved

When i save the settings it's applied on the app but when i change the settings page and come back it shows country and city blank normally it should be as i set it

Fixed!


Doc

Hey @danielhuppmann, I tried to fix the windows issue. I don't know how else to do it further.

Ok @danielhuppmann, this is ready to be merged. I could not get windows CI to work, so that is still untested. May be worth checking out on your machine.

ok @danielhuppmann, windows ci now includes building docs, this should be good to go.


Tracking Issue: Various non-researchable recipes visible in factoriopedia.

What is the problem?
There are several recipes in Pyanodons that are not unlockable however they still appear in areas such as editor mode and factoriopedia.
Commonly these recipes were added to an earlier mod in the modpack, and their technology was simply taken away instead of their full prototype being deleted.
This is a tracking issue to help locate such cases.

There is a recipe called "Biomass" which you can find in the Factoriopedia which supposedly takes 250 Muddy Sludge and outputs 1 biomass in an Evaporator Mk1.  The Evaporator does not have this recipe.  I sorely wish this was real.


response timeout due to asynchronous method used in rpc provide method in spite of setting autoAck to false

I call once the rpc for registering then it returns two responses. I set the timeout values to 1 min and I am sure that process does not do it more than 1 min. How is that possible?
client.rpc.provide("register", function(data, response){
   client.rpc.make("anorherProcess", data, function(err, result){
if (err){
   response.send({"err": err});
   return;
}
    response.send({"err": err, message:  'user is added successfully!'});
});
});

client.rpc.make("register", data, function(err, result){
   console.log("err:", err, " result:", result);
});

err: RESPONSE_TIMEOUT  result: undefined
err: null  result: { message: 'user is added successfully!'}

I think it is because of aynchronous method used in rpc provide method, Why rpc triggers timeout error before timeout value from config file passed?

Thanks for raising! We will take a look at this as soon as possible.
If possible, can you raise issues against the SDK repo? It makes it easier for sprint planning.
Thank you!

This seems to be happening with deepstream.io-client-java as well.

Hi @Sheshagiri, it looks like the correct config option to be using is rpcResponseTimeout, rather than rpcTimeout as seen here.
Could you please try that and let us know if you're still having trouble?

@AlexBHarley  thank you for the prompt response. After adding the rpcResponseTimeout flag to the client I don't see the RESPONSE_TIMEOUT issue.


Update Resty dependency to 2.7.0+ version for bazel users

For people who are building code with this flagsmith library and bazel a workaround is needed to support the old resty 2.3.0 library dependency which contains legacy bazel rule naming in the resty BUILD.bazel file
2.3.0 BUILD.bazel file
2.7.0 BUILD.bazel file
Users will get an error similar to this when trying to build anything using the current flagsmith release with bazel:
no such target '@com_github_go_resty_resty_v2//:resty': target 'resty' not declared in package '' defined by /private/var/tmp/_bazel_user/123abc/external/com_github_go_resty_resty_v2/BUILD.bazel and referenced by '@com_github_flagsmith_flagsmith_go_client//:flagsmith-go-client'

This error indicates bazel is looking for a go_library rule named resty instead of go_default_library
The workaround/fix is to update the go.bzl file created by bazel gazelle to have two additional settings:
    go_repository(
        name = "com_github_go_resty_resty_v2",
        build_file_generation = "off",                     # Needs to be added manually
        build_file_proto_mode = "disable_global",
        build_naming_convention = "go_default_library",    # Needs to be added manually
        importpath = "github.com/go-resty/resty/v2",
        sum = "h1:JOOeAvjSlapTT92p8xiS19Zxev1neGikoHsXJeOq8So=",
        version = "v2.3.0",
    )

The solution is to upgrade the dependency in your go.mod file to require github.com/go-resty/resty/v2 v2.7.0
Of course you should also check their release notes and be sure any functionality you are using has not changed and run tests, etc. Same process as any other regular golang dependency updates.


Add support for rollouts

Hey everyone,
We are mostly using argocd rollout resource instead of deployments:
apiVersion: argoproj.io/v1alpha1
kind: Rollout

The Rollout of ArgoCD is a popular CRD that is used by most of the people that use ArgoCD, its basically a deployment but with extra capabilities.
It would be great if the krr tool could support it so it will show results of Rollouts as well.

Good Idea! Thanks, @arnoldyahad
We do not yet support ReplicaSets, that are not bound to Deployment/StatefullSet, so this is good one to also implement

@LeaveMyYard I had the time to work on a solution: https://github.com/robusta-dev/krr/pull/85

Closing as PR was merged


An error occure with the RegExp    [^\Dabc]+

[^\Dabc]+   ==    [^abc]+
'111bbaaab'.match( /[^\Dabc]+/ ) === '111'

fixed (21/02/2015)


FinACE breaks in mobile device?

I found this when I checked other PRs, seems the FinACE breaks in iPhone.
https://main--icicidirect--aemsites.hlx.live/research/equity

I found this when I checked other PRs, seems the FinACE breaks in iPhone.
https://main--icicidirect--aemsites.hlx.live/research/equity

seems ok to me..

can we close this @JiangLong2019 @ravverma  ?

@ravverma I still can reproduce it but this time is recent-report.

@JiangLong2019  @ravverma For me , recent report is not visible on mobile.

@ravverma @JiangLong2019 should we close this issue ?

@anagarwa Now the api doesn't return any data, I will check when it works.

I have checked on my mobile both FinACE and recent report are working fine, even I am not seeing the overflow which @JiangLong2019 was showing during daily

Thanks @ravverma, following is my device information.
OS: iPhone13 15.6.1
Browser: Safari
Let me get one more answer, if it's not reproducible, I'll close it.
@sdmcraft @anagarwa @vivesing @sneharora1 Are you able to reproduce this ticket?

FinAce block is working fine on both iphone chrome and safari for me.

Thanks @vivesing, how about recent-report?

Recent Reports block also works fine on iphone chrome and safari browsers

Thanks @vivesing, close it.


adjust MTV assessment to new results schema

FLPATH-1734
https://issues.redhat.com/browse/FLPATH-1734

/lgtm

@masayag @ElaiShalevRH I have lgtm. i need also approve :-)

The jira says

MTV should be fixed to put the next workflow suggestions in the new results structure
In addition any other related links and info can be put there as well.

Can you please explain where "other related links and info" are/can be set?

The jira says

MTV should be fixed to put the next workflow suggestions in the new results structure
In addition any other related links and info can be put there as well.

Can you please explain where "other related links and info" are/can be set?

looking at gabriel's example it seems that this part did not change. so old code still works.

The output of the successful state is wrong

@gabriel-farache please take a look at my latest changes


Add email attribute to contrib

Add to JATS4M, TextureJATS, and Person schema. Also update EntityConverters accordingly.

See #390.

@axfelix email should be supported in master now.


tlbregister registers with exact path instead of relative path

Hello!  Thank you for publishing such a useful project.  It was a pleasure to find and easy to get started.  As a minor nit, one of the "tripping points" I experienced was that unlike regasm, dscom tlbregister does not expand the path provided to be a full path.
Actual behavior:
PS C:\path\to\project> dscom tlbregister foo.tlb
Type library was registered successfully
PS C:\path\to\project> (Get-ItemProperty 'hklm:Software\Classes\TypeLib\{F50810FE-4FA5-3CFF-9523-530867891B55}\1.0\0\win64')."(default)"
foo.tlb

Expected behavior:
PS C:\path\to\project> dscom tlbregister foo.tlb
Type library was registered successfully
PS C:\path\to\project> (Get-ItemProperty 'hklm:Software\Classes\TypeLib\{F50810FE-4FA5-3CFF-9523-530867891B55}\1.0\0\win64')."(default)"
C:\path\to\project\foo.tlb

If you prefer a PR, let me know.

@mgaffigan you are welcome to reopen this issue if you have problems with the bugfix.

Just tested.  Worked perfect.  Thanks again.


Fix typo in logger service name settings

Summary
Just noticed the typo in the logs while running the service
Description for the changelog
threat-drgaon => threat-dragon in logger service name settings
Other info
Note that the same typo exists in main and v2-development branches

Codecov Report

Merging #425 (6999d1b) into main (f669300) will increase coverage by 0.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   96.54%   97.53%   +0.98%
==========================================
  Files         127       27     -100
  Lines        1826      486    -1340
  Branches      111        0     -111
==========================================
- Hits         1763      474    -1289
+ Misses         56       12      -44
+ Partials        7        0       -7

Impacted Files
Coverage Δ

src/service/x6/shapes/text.js

src/i18n/pt.js

src/components/ThreatModelSummaryCard.vue

src/store/index.js

src/store/actions/loader.js

src/views/ThreatModelEdit.vue

src/views/Diagram.vue

src/views/Report.vue

src/store/modules/threatmodel.js

src/desktop.menu.js

... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f669300...6999d1b. Read the comment docs.

I think the build is failing because the dockerhub credentials do not exist on the fork - don't worry about the failures, should be good to merge!  Longer-term, we may want to re-think how that works for PRs coming from forks. :smile:

@danielpops do you want to have the honour of merging in your change?

@danielpops do you want to have the honour of merging in your change?

I don't see the merge button. I am not a maintainer on the repo


Tiled resources / reserve resources support ?

Hi,
Our current D3D11-based engine is using tiled resources.
Does The Forge provide any abstration layer for its abstract equivalent (reserved resources in D3D12, etc.) ?
Thanks a lot!
Cheers,
Greg

Hi Greg,
this is our No. 1 priority feature that we want to add. Can't promise when it is in there but probably very soon.
Have a great day,

Wolfgang

Took longer than expected :-) The new Sparse Virtual Texture example should cover that?

Hi Wolfgang,
this is good news, thanks for the hard work and sharing the news. I'll have a look at this !
Cheers,
Greg


Add a count up timer option

Is your feature request related to a problem? Please describe.
Currently, we are using a countdown timer of 0 minutes to mimic a count up timer (stopwatch). Some of our members have expressed confusion about why the timer is negative and red, so we would like a upwards counting timer.
Describe the solution you'd like
I would like an option that allows the timer to count upwards rather than down. This would act as a stopwatch instead of a timer for timekeeping purposes.
Describe alternatives you've considered
Mentioned above.
Additional context
None

This will be implemented as part of the LoS extension. If the default_time of a countdown is 0, it is a count-up timer and should be represented as such. This is required for interposed questions which count up.

this issue will be closed together with #3247


feat(telegram): emit telegram internal events

Support for telegram internal events:

telegram/inline-query
telegram/chosen-inline-result
telegram/callback-query
telegram/shipping-query
telegram/pre-checkout-query
telegram/poll
telegram/poll-answer
telegram/chat-member

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3240c93). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   80.39%
=========================================
  Files             ?        7
  Lines             ?      653
  Branches          ?       54
=========================================
  Hits              ?      525
  Misses            ?      128
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3240c93...ba0a327. Read the comment docs.


Always get raise this problem when i try to run eternal_checker.py ip

root@kali:/AutoBlue-MS17-010# python eternal_checker.py <IP_ADDRESS>
Traceback (most recent call last):
File "eternal_checker.py", line 89, in
main()
File "eternal_checker.py", line 66, in main
conn = MYSMB(options.target_ip, int(options.port))
File "/AutoBlue-MS17-010/mysmb.py", line 122, in init
smb.SMB.init(self, remote_host, remote_host, timeout=timeout)
File "/usr/local/lib/python2.7/dist-packages/impacket/smb.py", line 2437, in init
self.neg_session()
File "/AutoBlue-MS17-010/mysmb.py", line 178, in neg_session
smb.SMB.neg_session(self, extended_security=self.__use_ntlmv2, negPacket=negPacket)
File "/usr/local/lib/python2.7/dist-packages/impacket/smb.py", line 2657, in neg_session
smb = self.recvSMB()
File "/usr/local/lib/python2.7/dist-packages/impacket/smb.py", line 2521, in recvSMB
r = self._sess.recv_packet(self.__timeout)
File "/usr/local/lib/python2.7/dist-packages/impacket/nmb.py", line 914, in recv_packet
data = self.__read(timeout)
File "/usr/local/lib/python2.7/dist-packages/impacket/nmb.py", line 997, in __read
data = self.read_function(4, timeout)
File "/usr/local/lib/python2.7/dist-packages/impacket/nmb.py", line 983, in non_polling_read
raise NetBIOSError('Error occurs while reading from remote', ERRCLASS_OS, ex[0])
impacket.nmb.NetBIOSError: Error occurs while reading from remote(104)

Based on your error it looks like you're using python2.7
This project was recently upgraded to python3. While initial support for both 2 & 3 was tested upon upgrading I can provide no guarantee that python2 will work going forward.
Also, regardless of which Python version you use, please be sure you have the latest version of the "impacket" libraries installed.
All of this is in the README file. I'll leave this issue open for now until you've tried these things in case this is a real issue, but there's not enough information here to reproduce what you're receiving (in other words it works just fine for me). Hopefully insuring you have the latest dependencies helps, otherwise please follow up with any new errors you receive and I will look into them.

i have now uninstalled python 2.7 and running the script with python3.
root@kali:/AutoBlue-MS17-010#pip --version
bash: /usr/local/bin/pip: /usr/bin/python: bad interpreter: No such file or directory
root@kali:/AutoBlue-MS17-010# python --version
bash: /usr/bin/python: No such file or directory
root@kali:/AutoBlue-MS17-010# pip3 --version                       pip 20.1.1 from /usr/lib/python3/dist-packages/pip (python 3.8)
root@kali:/AutoBlue-MS17-010# python3 --version                    Python 3.8.6
root@kali:/AutoBlue-MS17-010# python3 eternal_checker.py <IP_ADDRESS>
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/nmb.py", line 979, in non_polling_read
received = self._sock.recv(bytes_left)
ConnectionResetError: [Errno 104] Connection reset by peer
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "eternal_checker.py", line 89, in
main()
File "eternal_checker.py", line 66, in main
conn = MYSMB(options.target_ip, int(options.port))
File "/AutoBlue-MS17-010/mysmb.py", line 122, in init
smb.SMB.init(self, remote_host, remote_host, timeout=timeout)
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/smb.py", line 2437, in init
self.neg_session()
File "/AutoBlue-MS17-010/mysmb.py", line 178, in neg_session
smb.SMB.neg_session(self, extended_security=self.__use_ntlmv2, negPacket=negPacket)
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/smb.py", line 2657, in neg_session
smb = self.recvSMB()
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/smb.py", line 2521, in recvSMB
r = self._sess.recv_packet(self.__timeout)
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/nmb.py", line 914, in recv_packet
data = self.__read(timeout)
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/nmb.py", line 997, in __read
data = self.read_function(4, timeout)
File "/usr/local/lib/python3.8/dist-packages/impacket-0.9.22.dev1+20200929.152157.fe642b24-py3.8.egg/impacket/nmb.py", line 983, in non_polling_read
raise NetBIOSError('Error occurs while reading from remote', ERRCLASS_OS, ex.errno)
impacket.nmb.NetBIOSError: Error occurs while reading from remote(104)

Could not reproduce this locally, but I can confirm this is not a bug with the eternal check script. Just ran a fresh install on a known vulnerable and non-vulnerable targets and received expected output.
This error is being consistently raised from the impacket library's' nmb.py for your use case. Why that is I don't know, but unless you are able to reproduce this across multiple targets, it appears to just be an issue on the one .0.101 target you reference in your output. These errors are raised when reading  NetBIOS data from the target fails for some reason (https://github.com/SecureAuthCorp/impacket/blob/master/impacket/nmb.py). Based on that information, this does not seem to be a bug with the eternal_checker.py script nor the impacket libraries, this actually appears to be expected output whenever the nmb.py error is raised for a legitmate reason. In the case of 0x104 error that you receive it looks like it's related to finding file info and is probably related to some permission issue on your target system.
I'll be the first to admit my Windows System internals/error code knowledge is not that deep, but since I just pulled down this code base, installed everything from scratch to test, I have no choice but to say that this error is unique to you unfortunately. If anyone else comes across this and can provide more info, I'll be happy to look into working on a fix. Since this is not reproduce-able I'll have to close this out. Good luck!


Documentation on building config objects

Current document suggests importing db_config_fsd.obj from original generator repo, but we should add a generator or at bare minimum documentation on how to build one from scratch as we add new features and additions.
Long-term, we may want to switch to a non-serialized objects (e.g. .yml files), but this will require more integration steps.

Resolving db_config.obj creation with a workaround with #1 , but planning a longer-term fix with swapping to .yml files for long-term configuration plans.

Being addressed in #17


PTR Values Still Haven't Updated

This issue was listed as resolved 13 hours ago, but when I load up the ptr version the old values are still active.
Edit: they are updated correctly now

Must've been a cache issue.


[udp] platform UDP sending depending on the 'IsHostInterface' flag

The problem with current implementation is that:
When PLATFORM_UDP is enabled and a custom UDP server is started with socket.Bind(0), the server can receives datagrams from both host interface and Thread interface, but the responses are always sent via the platform UDP.
I think whether a UDP message should be sent via host interface or Thread interface should be determined by the IsHostInterface flag.

@wgtdkp
Do you think this PR is deprecated by https://github.com/openthread/openthread/pull/6111?

@wgtdkp
Do you think this PR is deprecated by https://github.com/openthread/openthread/pull/6111?

@wgtdkp
Do you think this PR is deprecated by #6111?

Yes, I believe this PR is trying to fix the same issue. Will close it.

@wgtdkp
Do you think this PR is deprecated by #6111?

Yes, I believe this PR is trying to fix the same issue. Will close it.


Update README.md

Hi,
This small PR adds a link to get your app on F-Droid 👍
You can now eventually add the fdroid and/or f-droid tags that will appear on the right side of the repo.

Oh! I've been waiting for this to become available on F-Droid! Thanks!

Could you update your commit message with something more descriptive like this: readme: add f-droid link

I'm not sure I can change the commit description easily via github.com
Just cherry-pick the changes, it'll be ok

Thank you! 7f4517f48c88363dc4956ac6e842078c649a2c0d


Dynamic list issue - Error[500]

Hi,
Can someone please help me with the following issues?
When trying to make a dynamic list I get to see the following error:

After refreshing the dynamic list is added - however, when I try to open it I get to see Error [500]:

I've setup parcelvoy using docker compose (https://docs.parcelvoy.com/overview/quick-start)

Hello @ajatula! That particular issue should've been resolve by #291. Could you try please pulling the latest and see if you are still experiencing the issue? You will most likely need to archive any previously created lists.

@pushchris thx! I pulled the latest version :)
I'm getting a new error when trying to make a new project (please see the screenshot below:) , any ideas?

Below my docker api logs:
2023-10-17 10:32:58 [1697531578041] ERROR (8 on e64936c7da5c): error
2023-10-17 10:32:58     ctx: {
2023-10-17 10:32:58       "request": {
2023-10-17 10:32:58         "method": "GET",
2023-10-17 10:32:58         "url": "/api/admin/projects/all",
2023-10-17 10:32:58         "header": {
2023-10-17 10:32:58           "host": "api:3001",
2023-10-17 10:32:58           "connection": "close",
2023-10-17 10:32:58           "sec-ch-ua": ""Google Chrome";v="117", "Not;A=Brand";v="8", "Chromium";v="117"",
2023-10-17 10:32:58           "accept": "application/json, text/plain, /",
2023-10-17 10:32:58           "sec-ch-ua-mobile": "?0",
2023-10-17 10:32:58           "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
2023-10-17 10:32:58           "sec-ch-ua-platform": ""macOS"",
2023-10-17 10:32:58           "sec-fetch-site": "same-origin",
2023-10-17 10:32:58           "sec-fetch-mode": "cors",
2023-10-17 10:32:58           "sec-fetch-dest": "empty",
2023-10-17 10:32:58           "referer": "http://localhost:3000/",
2023-10-17 10:32:58           "accept-encoding": "gzip, deflate, br",
2023-10-17 10:32:58           "accept-language": "nl-NL,nl;q=0.9,en-US;q=0.8,en;q=0.7,ru;q=0.6,it;q=0.5",
2023-10-17 10:32:58           "cookie": "oauth={"access_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwib3JnYW5pemF0aW9uX2lkIjpudWxsLCJleHAiOjE2OTc1NjgyMTYsImlhdCI6MTY5NzQ4MTgxNn0.uZ-qMoeRjkIHHsWTuvxUQsNQfxdCijw-IjX5Uq3mqlM","expires_at":"2023-10-17T18:43:36.117Z"}; oauth.sig=dp4f-9lvAOqmQySfG-rEjb4Mkss; ph_[YOUR_VALUE]posthog=%7B%22distinct_id%22%3A%22018b3a3b-b6e1-7dab-a18a-5ea9bac8922c%22%2C%22%24device_id%22%3A%22018b3a3b-b6e1-7dab-a18a-5ea9bac8922c%22%2C%22%24user_state%22%3A%22anonymous%22%2C%22%24sesid%22%3A%5B1697490285437%2C%22018b3a3b-b6e4-71b6-aa88-6eb32c0c2ad9%22%2C1697489073892%5D%7D"
2023-10-17 10:32:58         }
2023-10-17 10:32:58       },
2023-10-17 10:32:58       "response": {
2023-10-17 10:32:58         "status": 404,
2023-10-17 10:32:58         "message": "Not Found",
2023-10-17 10:32:58         "header": {
2023-10-17 10:32:58           "vary": "Origin"
2023-10-17 10:32:58         }
2023-10-17 10:32:58       },
2023-10-17 10:32:58       "app": {
2023-10-17 10:32:58         "subdomainOffset": 2,
2023-10-17 10:32:58         "proxy": true,
2023-10-17 10:32:58         "env": "production"
2023-10-17 10:32:58       },
2023-10-17 10:32:58       "originalUrl": "/api/admin/projects/all",
2023-10-17 10:32:58       "req": "",
2023-10-17 10:32:58       "res": "",
2023-10-17 10:32:58       "socket": ""
2023-10-17 10:32:58     }
2023-10-17 10:32:58     error: {
2023-10-17 10:32:58       "originalStack": "TypeError: Cannot read properties of undefined (reading 'organization_id')\n    at Builder. (/usr/src/app/build/projects/ProjectService.js:53:95)\n    at compileCallback (/usr/src/app/node_modules/knex/lib/formatter/formatterUtils.js:7:12)\n    at rawOrFn (/usr/src/app/node_modules/knex/lib/formatter/wrappingFormatter.js:225:7)\n    at QueryCompiler_MySQL.whereWrapped (/usr/src/app/node_modules/knex/lib/query/querycompiler.js:1095:17)\n    at QueryCompiler_MySQL.where (/usr/src/app/node_modules/knex/lib/query/querycompiler.js:584:34)\n    at /usr/src/app/node_modules/knex/lib/query/querycompiler.js:135:40\n    at Array.forEach ()\n    at QueryCompiler_MySQL.select (/usr/src/app/node_modules/knex/lib/query/querycompiler.js:134:16)\n    at QueryCompiler_MySQL.toSQL (/usr/src/app/node_modules/knex/lib/query/querycompiler.js:75:29)\n    at Builder.toSQL (/usr/src/app/node_modules/knex/lib/query/querybuilder.js:84:44)\n    at ensureConnectionCallback (/usr/src/app/node_modules/knex/lib/execution/internal/ensure-connection-callback.js:4:30)\n    at Runner.ensureConnection (/usr/src/app/node_modules/knex/lib/execution/runner.js:318:20)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async Runner.run (/usr/src/app/node_modules/knex/lib/execution/runner.js:30:19)\n    at async Project.all (/usr/src/app/build/core/Model.js:93:25)\n    at async allProjects (/usr/src/app/build/projects/ProjectService.js:53:12)"
2023-10-17 10:32:58     }
2023-10-17 10:33:04 [1697531584619] ERROR (8 on e64936c7da5c): error
2023-10-17 10:33:04     ctx: {
2023-10-17 10:33:04       "request": {
2023-10-17 10:33:04         "method": "POST",
2023-10-17 10:33:04         "url": "/api/admin/projects",
2023-10-17 10:33:04         "header": {
2023-10-17 10:33:04           "host": "api:3001",
2023-10-17 10:33:04           "connection": "close",
2023-10-17 10:33:04           "content-length": "103",
2023-10-17 10:33:04           "sec-ch-ua": ""Google Chrome";v="117", "Not;A=Brand";v="8", "Chromium";v="117"",
2023-10-17 10:33:04           "accept": "application/json, text/plain, /",
2023-10-17 10:33:04           "content-type": "application/json",
2023-10-17 10:33:04           "sec-ch-ua-mobile": "?0",
2023-10-17 10:33:04           "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
2023-10-17 10:33:04           "sec-ch-ua-platform": ""macOS"",
2023-10-17 10:33:04           "origin": "http://localhost:3000",
2023-10-17 10:33:04           "sec-fetch-site": "same-origin",
2023-10-17 10:33:04           "sec-fetch-mode": "cors",
2023-10-17 10:33:04           "sec-fetch-dest": "empty",
2023-10-17 10:33:04           "referer": "http://localhost:3000/",
2023-10-17 10:33:04           "accept-encoding": "gzip, deflate, br",
2023-10-17 10:33:04           "accept-language": "nl-NL,nl;q=0.9,en-US;q=0.8,en;q=0.7,ru;q=0.6,it;q=0.5",
2023-10-17 10:33:04           "cookie": "oauth={"access_token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwib3JnYW5pemF0aW9uX2lkIjpudWxsLCJleHAiOjE2OTc1NjgyMTYsImlhdCI6MTY5NzQ4MTgxNn0.uZ-qMoeRjkIHHsWTuvxUQsNQfxdCijw-IjX5Uq3mqlM","expires_at":"2023-10-17T18:43:36.117Z"}; oauth.sig=dp4f-9lvAOqmQySfG-rEjb4Mkss; ph[YOUR_VALUE]_posthog=%7B%22distinct_id%22%3A%22018b3a3b-b6e1-7dab-a18a-5ea9bac8922c%22%2C%22%24device_id%22%3A%22018b3a3b-b6e1-7dab-a18a-5ea9bac8922c%22%2C%22%24user_state%22%3A%22anonymous%22%2C%22%24sesid%22%3A%5B1697490285437%2C%22018b3a3b-b6e4-71b6-aa88-6eb32c0c2ad9%22%2C1697489073892%5D%7D"
2023-10-17 10:33:04         }
2023-10-17 10:33:04       },
2023-10-17 10:33:04       "response": {
2023-10-17 10:33:04         "status": 404,
2023-10-17 10:33:04         "message": "Not Found",
2023-10-17 10:33:04         "header": {
2023-10-17 10:33:04           "vary": "Origin",
2023-10-17 10:33:04           "access-control-allow-origin": "http://localhost:3000"
2023-10-17 10:33:04         }
2023-10-17 10:33:04       },
2023-10-17 10:33:04       "app": {
2023-10-17 10:33:04         "subdomainOffset": 2,
2023-10-17 10:33:04         "proxy": true,
2023-10-17 10:33:04         "env": "production"
2023-10-17 10:33:04       },
2023-10-17 10:33:04       "originalUrl": "/api/admin/projects",
2023-10-17 10:33:04       "req": "",
2023-10-17 10:33:04       "res": "",
2023-10-17 10:33:04       "socket": ""
2023-10-17 10:33:04     }
2023-10-17 10:33:04     error: {
2023-10-17 10:33:04       "headers": {
2023-10-17 10:33:04         "Access-Control-Allow-Origin": "http://localhost:3000",
2023-10-17 10:33:04         "vary": "Origin"
2023-10-17 10:33:04       }
2023-10-17 10:33:04     }
2023-10-17 10:32:58
2023-10-17 10:32:58   TypeError: Cannot read properties of undefined (reading 'organization_id')
2023-10-17 10:32:58       at createQueryBuilder (/usr/src/app/node_modules/knex/lib/knex-builder/make-knex.js:320:26)
2023-10-17 10:32:58       at knex (/usr/src/app/node_modules/knex/lib/knex-builder/make-knex.js:101:12)
2023-10-17 10:32:58       at Project.table (/usr/src/app/build/core/Model.js:225:16)
2023-10-17 10:32:58       at Project.build (/usr/src/app/build/core/Model.js:229:36)
2023-10-17 10:32:58       at Project.all (/usr/src/app/build/core/Model.js:93:36)
2023-10-17 10:32:58       at allProjects (/usr/src/app/build/projects/ProjectService.js:53:36)
2023-10-17 10:32:58       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-10-17 10:32:58       at async /usr/src/app/build/projects/ProjectController.js:47:16
2023-10-17 10:32:58       at async serve (/usr/src/app/node_modules/koa-static/index.js:59:5)
2023-10-17 10:32:58       at async cors (/usr/src/app/node_modules/@koa/cors/index.js:61:32)
2023-10-17 10:32:58       at async /usr/src/app/build/api.js:48:17
2023-10-17 10:32:58
2023-10-17 10:33:04
2023-10-17 10:33:04   TypeError: Cannot read properties of undefined (reading 'organization_id')
2023-10-17 10:33:04       at createProject (/usr/src/app/build/projects/ProjectService.js:73:32)
2023-10-17 10:33:04       at /usr/src/app/build/projects/ProjectController.js:75:57
2023-10-17 10:33:04       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-10-17 10:33:04       at async serve (/usr/src/app/node_modules/koa-static/index.js:59:5)
2023-10-17 10:33:04       at async cors (/usr/src/app/node_modules/@koa/cors/index.js:110:16)
2023-10-17 10:33:04       at async /usr/src/app/build/api.js:48:17
2023-10-17 10:33:04

@pushchris Can you please let me know if the following steps are correct to install parcelvoy locally?

pull the latest code
perform the command 'mv .env.example .env' in:

the root directory
apps/platform, and
apps/ui

npm install from the root directory
npm start

That is very odd indeed! I am unable to replicate unfortunately, going to have to do some digging. Those are the correct steps for pulling from source. Do you have access to the database you are running this on? Can you check if anything is being inserted into the rules table when you create the list? And if so, is there a reference to that rule in the rule_id table in lists? Can you also check what the relationships are on the lists table?

Ok, one more thing to try:
If you run:
`SHOW CREATE TABLE `lists`;

Does it contain a foreign key to rule_id that contains a ON DELETE clause?
If so, run the following and let me know if it resolves the issue:
ALTER TABLE `lists` DROP FOREIGN KEY `lists_rule_id_foreign`;

If not we'll keep looking!

So after following the mentioned installation steps and running 'npm start' I get to see a database error and a 504-error in the browser:
Database error:
[1697579181034] ERROR (20319 on MacBook-Pro-van-Anton.local): database error     err: {       "type": "Error",       "message": "connect ECONNREFUSED <IP_ADDRESS>:3306",       "stack":           Error: connect ECONNREFUSED <IP_ADDRESS>:3306               at Function.get (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/knex-builder/make-knex.js:44:26)               at getSchemaBuilder (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/table-creator.js:71:17)               at ensureTable (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/table-creator.js:10:10)               at listCompleted (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/migration-list-resolver.js:12:9)               at Object.listAllAndCompleted (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/migration-list-resolver.js:25:5)               at Migrator.latest (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/Migrator.js:63:57)               at migrate (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/apps/platform/src/config/database.ts:51:33)               at exports.default (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/apps/platform/src/config/database.ts:82:15)               at Function.init (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/apps/platform/src/app.ts:33:44)               at processTicksAndRejections (node:internal/process/task_queues:95:5)       "errno": -61,       "code": "ECONNREFUSED",       "syscall": "connect",       "address": "<IP_ADDRESS>",       "port": 3306,       "fatal": true,       "originalStack": "Error: connect ECONNREFUSED <IP_ADDRESS>:3306\n    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1284:16)"     } Error: connect ECONNREFUSED <IP_ADDRESS>:3306     at Function.get (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/knex-builder/make-knex.js:44:26)     at getSchemaBuilder (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/table-creator.js:71:17)     at ensureTable (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/table-creator.js:10:10)     at listCompleted (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/migration-list-resolver.js:12:9)     at Object.listAllAndCompleted (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/migration-list-resolver.js:25:5)     at Migrator.latest (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/node_modules/knex/lib/migrations/migrate/Migrator.js:63:57)     at migrate (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/apps/platform/src/config/database.ts:51:33)     at exports.default (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/apps/platform/src/config/database.ts:82:15)     at Function.init (/Users/antonjatula/Desktop/parcelvoy/platform-1.0.0-beta.4/apps/platform/src/app.ts:33:44)     at processTicksAndRejections (node:internal/process/task_queues:95:5) {   errno: -61,   code: 'ECONNREFUSED',   syscall: 'connect',   address: '<IP_ADDRESS>',   port: 3306,   fatal: true,   originalStack: 'Error: connect ECONNREFUSED <IP_ADDRESS>:3306\n' +     '    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1284:16)' }
Browser error and another terminal error:

Error occurred while proxying request localhost:3000/api/admin/profile to http://localhost:3001/ [ECONNREFUSED] (https://nodejs.org/api/errors.html#errors_common_system_errors)

If instead of 'npm start' I run 'docker compose up' I can get into my project and subsequently reproduce the errors with the dynamic list.
I tried to inspect the mysql database by doing the following steps in the terminal:
docker exec -it platform-100-beta4-mysql-1 bash
mysql -u root -p

use parcelvoy;

Can you check if anything is being inserted into the rules table when you create the list?
yes :)

And if so, is there a reference to that rule in the rule_id table in lists?

Can you also check what the relationships are on the lists table?

The data you posted is definitely emblematic of the issue that was resolved by https://github.com/parcelvoy/platform/pull/291 in v1.0.0-beta.4. The issue pertained to the list not properly associating the rule to itself so the list view would never load. I've been trying to reproduce what you are experiencing and have yet to get it to trigger in the latest docker version. Can we try two more things:

If you are pulling the docker image from latest change to 1.0.0-beta.4 just to quadruple check its the right version
Change whatever database value you are using to be different. This will autocreate a fresh database just to see if the issue is still potentially related to the database (though from your images it looks fine). It wont affect your previous database.

Thanks!

Changing the docker image from latest to 1.0.0-beta.4 solved it!! Thank you so much. I really appreciate it.


Does using the YouTube API count as views?

I want to use the youtube API in my app, but I would like to know if using this package will also count as views for my channel?

Duplicate of #219


Replace deprecated assertions assert_equal(nil, ...)

These were accidentally overlooked in PR #445
DEPRECATED: Use assert_nil if expecting nil from test/models/observation_test.rb:880. This will fail in Minitest 6.

Coverage remained the same at 91.415% when pulling<PHONE_NUMBER>c820ff663cebb78000055f7c79243c on JoeCohen:replace-assert-equal-nil into acfabc30312988d0875b5d1f7d6cb23272559d56 on MushroomObserver:master.