Module generator uses header guards with leading underscores

Running ceedling module:create[magic] (v0.28.3) in a new project will create a header file for that module. The header file begins with:
#ifndef _MAGIC_H

According to §7.1.3 of the standard (ANSI C90 and C11 at least, I haven't checked C99), this identifier format is reserved. So the generated header files are courting undefined behaviour. Granted, I'd be surprised if anything came of it, but who knows what those compiler writers will do next?

I realised the module generator is part of Unity, not Ceedling. It's filed on Unity.


Skipped tests are not shown if skipping is due to fixtures

If a test is skipped due to a fixture causing the skip, the test is not shown at all. Here's a minimal example, test_simple.py:
import pytest

@pytest.fixture
def skipfixture():
    pytest.skip('fixture not available, should skip')

def test_passes():
    pass

def test_with_skipfixture(skipfixture):
    pass

def test_skip_manually():
    pytest.skip('this was skipped inside the test function')

The output from py.test -v test_simple.py without pytest_sugar 4.0 installed:
[...]
test_simple.py::test_passes PASSED
test_simple.py::test_with_skipfixture SKIPPED
test_simple.py::test_skip_manually SKIPPED

============================== 1 passed, 2 skipped in 0.01 seconds ==============================

With sugar, however:
 tests/test_simple.pytest_passes ✓                                                 67% ██████▋
 tests/test_simple.pytest_skip_manually ⚫                                         100% ██████████

Results (0.01s):
       1 passed
       1 skipped

Note that test_with_skipfixture is missing.

This has been fixed with the upcoming version.


Problem with items without price

I have experienced that recommendation items sometimes are returned by Adobe Sensei without price information.
The response from https://commerce.adobe.io/recs/v1/precs/preconfigured should return a price section such as,
"prices": {
                        "maximum": {
                            "finalAdjustments": [],
                            "regular": 699.0,
                            "regularAdjustments": [],
                            "final": 699.0
                        },
                        "minimum": {
                            "finalAdjustments": [],
                            "regular": 699.0,
                            "regularAdjustments": [],
                            "final": 699.0
                        }
                    },

But for some products I get the following in the response,
"prices": {},

This creates problems for the recommendedItem context and it will return a type error. The crash (type error) occurs in the following code section.
https://github.com/adobe/commerce-events/blob/0a1eafe77160f498ebf36cd41d6dc0dfddcacc35/packages/storefront-events-collector/src/contexts/recommendedItem.ts#L47
I think that it would be helpful to improve error handling, not sure exactly what can be done since the problem seems to be on the server side. I suggest that such "broken" items without price are filtered out by the recommended item context to avoid the entire app to crash when such item is recommended.

@johan-lindahl this issue was resolved in 1.3.1! feel free to try out and let us know if anything seems off!


Minor improvements

Hi @jy-binary
Please review the PR.

Removed tar ball from the MANIFEST file
Fix pod error

Many Thanks.
Best Regards,
Mohammad S Anwar

Current coverage is 81.81% (diff: 100%)

Merging #6 into master will not change coverage

@@             master         #6   diff @@
==========================================
  Files             1          1
  Lines            22         22
  Methods           0          0
  Messages          0          0
  Branches          3          3
==========================================
  Hits             18         18
  Misses            4          4
  Partials          0          0

Powered by Codecov. Last update a72aa79...12935e3

The change looks good. Thanks @manwar


Chapter 2

Hi there,
I have not seen this issue in the issues section, and I was wondering if it has happened before. I'm currently trying to get the test data set, and I currently have this exact code from the book written:
from sklearn.model_selection import StratifiedShuffleSplit

split = StratifiedShuffleSplit(n_splits=1, test_size=0.2, random_state=42)
for train_index, test_index in split.split(housing, housing["income_cat"]):
    strat_train_set = housing.loc[train_index]
    strat_test_set = housing.loc[test_index]

However, I keep getting the following error:
TypeError: object of type 'CategoricalDtype' has no len()

The full error is below:

I've checed plenty of times but I can't find any typos, nor can I figure out if something in a prior cell block is preventing this. I'm running a Jupyter notebook on a Windows machine (I have Anaconda installed). All of the other code blocks up until this point seem to work fine.
Loving the book btw!
Thanks,
Joey

Hi @jjf1218 ,
I'm really glad you're enjoying the book!  :)
You probably have Scikit-Learn 0.20.1 which had a bug, see issue #378 (when you search for issues on github, make sure to search for both open and closed issues). You just need to upgrade Scikit-Learn to the latest version, and everything should run fine.
Hope this helps,
Aurélien

Thanks for the reference! It now seems to be working.
Cheers!
Joey


zoom and rotate imageView

Is there a way to zoom in and out and rotate image?
if not please add
Thanks

You can use pinch to zoo, rotate and scale.

How to pinch to zoom and rotate?
It just says Pinch to Scale and Rotate views. but doesn't show how to do that.

You can use pinch to zoom, rotate and scale.

How to pinch to zoom and rotate?
It just says Pinch to Scale and Rotate views. but doesn't show how to do that.

You can use pinch to zoom, rotate and scale.

How to pinch to zoom and rotate?
It just says Pinch to Scale and Rotate views. but doesn't show how to do that.

https://www.computerhope.com/jargon/p/pinch-to-zoom.htm


work.ink not being bypassed

We already know that linkvertise is not being bypassed, and we are working on it. Please be patient while we found a fix for it.
Edit 5:50PM at 17/05/22 (BRT): Pull Request 498 fixed Linkvertise bypass. Work.ink still not bypassed.

Same thing about work.ink, when the bypass is working we will give updates on this issue.

they send the link back from the server when you finish the required steps, thats also verified before they send the link back, not sure we can bypass that anymore

crowdbypass then?

#942 has a bypass for work.ink, closing.

reopening, will link this to the PR

Needs for MV3.


feat(backend): optional pagination for user query

🍰 Pullrequest

Issues
based on #1518
Todo

[X] None

@roschaefer The code you reviewed is already in master.

How come? This PR here is in "Draft" mode, I looks not being merged. If the changes are already in master we should see the PR getting auto-closed when I hit "rebase"...

Ahh, merge conflicts. So, can we close this PR then?


Fix version of shellsheck

Change content and motivation
Fixes shellcheck to a specific version and also updates some code to comply with this (currently latest) version of shellcheck.

Since @carmat88 approved you can go ahead and merge!


18/8 roundtable summary

post a quick summary of today's discussion, emphasizing this holy grail around a common app for web3 grants, to the roundtable chat

draft


HHVM support?

It seems like Ardent is completely broken because of lines like this:
https://github.com/laravelbook/ardent/blob/master/src/LaravelBook/Ardent/Ardent.php#L376
HHVM returns a different structure for debug_backtrace() as it doesn't return magic calls.
Issue in question: https://github.com/facebook/hhvm/issues/1944

Bump.

well, it seems by that issue they intentionally broke compatibility with the Zend implementation?
if that's the case, I'm not sure what to do here. Would need to take a deeper look in the code and, maybe, even create a split there between PHP implementations - and I'm not sure this is good.
I would accept PRs on this, though :)

IMO, you shouldn't be using debug_backtrace() in application code. Shouldn't Ardent be able to use __call()? Or is there some Laravel reason that's not possible.

Take a look here: https://github.com/illuminate/database/blob/master/Eloquent/Model.php#L785
This is actually only an override to allow for Ardent's intelligent properties.
I guess you should ask for HHVM support to Eloquent first, not us :)


Teach EmbeddedExtractor to use distribution.properties

Rationale
EmbeddedExtractor was still using the distribution file
Teach EmbeddedExtractor to read name, version, and buildUrl properties from distribution.properties. Logic isn't as simple as it could be since we need to continue supporting the VERSION file until the new gradle plugins version is adopted. The reading code currently prefers properties from distribution.properties, but falls back to VERSION if those properties aren't found. VERSION handling will be removed (and reading code simplified) once the new plugins version is adopted.
Related Pull Requests

https://github.com/LabKey/gradlePlugin/pull/220

@labkey-tchad any other testing you think we should do on this PR? As mentioned in the comment, this class will continue using the VERSION file until plugins v4.2.0 is published (next week?), at which point it should switch over to pulling version and buildUrl from distribution.properties.


fix citing issue

we want to cite like \cite{some_reference} and the result should be [1] with the link on the citation
now it is written like the name of the cite so the user must write (\cite{some_reference})

done


Added brazilian portuguese language

Please add this brazilian portuguese translation. I'm pt_BR native, so, no translator used.
Notice that instead of using por as asked for the language (ISO 639-2 Code) I used pt_BR. I know that is not on guideline, it should be por but, there are some variations of portuguese, so it's quite common using pt (or por) as portuguese from Portugal and pr_BR for Brazilian Portuguese.
Some slightly diffences can be found as, in pt, file is ficheiro while in Brasil file is arquivo because in Brasil ficheiro is a binder.
If even after that it still not acceptable, I can change the code for por, but it could generate some confusion if in the future someone try to add the portuguese from portugal to the Udeler.

@FaisalUmair .... or you can just name it as - Portugues (BR) - which stands for BRazil, and when it comes to Portuguese from Portugal, you can name it as - Portuguese (PT) ... it will work in the same way =)

@tofanelli it will work, but the problem is that, at the moment I wrote the PR, the languages name couldn't contain spaces, that's why I said that I had no time for a fix and "just" left as Português, without country.
I think that if the problem is already fixed, Português (BR) and Português (PT) is indeed the best naming one could choose.

@tofanelli , @williamokano  I think I am  not the right person to ask this question. But if there are two versions of Portuguese language then I think we should separate them accordingly. But as of now we only have Brazilian Portuguese added  so I think it is okay to  name the language just Portuguese.
But I will see whats wrong with the space issue here, if fixed, I will rename it to Portuguese (BR). Would that be alright?

Yes, Will be :)
Em dom, 11 de mar de 2018 02:54, Faisal Umair<EMAIL_ADDRESS>escreveu:

@tofanelli https://github.com/tofanelli , @williamokano
https://github.com/williamokano I think I am not the right person to
ask this question. But if there are two versions of Portuguese language
then I think we should separate them accordingly. But as of now we only
have Brazilian Portuguese added so I think it is okay to name the language
just Portuguese.
But I will see whats wrong with the space issue here, if fixed, I will
rename it to Portuguese (BR). Would that be alright?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FaisalUmair/udemy-downloader-gui/pull/33#issuecomment-372091727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AForwkzj_ZCI3DgUB0cqhzQvTdZDUZYvks5tdLwAgaJpZM4Rkq1b
.

@FaisalUmair .... yup... it will =)


Search current buffer content

Hi, I can't help but notice that the project contains producer.vim.currentbuffer which to me it seems to populate what I want (a content to search for). Now, I already tried to figure out how to use it and here's the result...
local snap = require('snap')
snap.run({
  producer = snap.get('producer.vim.currentbuffer'),
  select = snap.get('select.currentbuffer').select,
})

And as you can see, the producer does indeed populate the content of current file, but the filtering is not working.
So, could you help on how to setup or see why the filtering is not properly working?

nvm, got it working with
local snap = require('snap')
snap.run({
  producer = snap.get('consumer.fzf')(snap.get('producer.vim.currentbuffer')),
  select = snap.get('select.currentbuffer').select
})


Lua 5.1 minimum compatibility

See https://github.com/Omikhleia/resilient.sile/pull/70
silex/fixes.lua:174:23: accessing undefined field searchpath of global package

IIRC, that line was copied from SILE.

We appear to be running luacheck wrong upstream in SILE because we have std = "max" instead of std = "min". I'll look into that now and it may be that since we're loading compat patches we can actually use "max", but we should clarify that. I'll look into it.

I just fixed this in luacheck so that --std min+sile should now allow the use of package.searchpath() since we patch it into Lua 5.1. It will be in a new version of LuaCheck shortly.


Shim TCP Load-balancer

microk8s is excellent. Thank you!
I've begun using microk8s as my exemplar Kubernetes deployment and then test additionally elswhere e.g. on Kubernetes Engine and DO.
It's reasonable to assume that each platform provides TCP Load-balancing and thus enables services with --type=LoadBalancer but this is untrue for microk8s.
Instead, it's possible (recommended) to localhost:${NODEPORT} services.
This means that microk8s is unlike (most) others.
Is there utility in providing a TCP LB shim for microk8s that defaults to the host's IP and the service's NodePort? IIUC this is a chunk of what's done by a Kubernetes Load-balancer implementation anyway.
The downside is the requirement to use unique (host) ports but this is satisfied by the uniqueness of NodePorts.
This would enable the equivalent of kubectl expose --type=LoadBalancer and -- I think -- would permit most deployments to continue working when querying a service's LoadBalancer.
This would bring microk8s' functionality further in line with other platforms.
Apologies if this is a naive request.

microk8s is excellent. Thank you!

Thank you for using MicroK8s.
Probably the easiest option to get a loadbalancer in MicroK8s is through MetalLB. We already have a pending PR for this (https://github.com/ubuntu/microk8s/pull/759) but we haven't merge it yet.
Do you have another loadbalancer implementation in mind? We would gladly review and merge it. This is a very interesting topic.

Thanks for the prompt and helpful reply, @ktsakalozos
MetalLB is a good option.
I think -- and I'm perhaps I'm being overly simplistic here (!?) -- there's an even simpler option.
Classic (!) TCP Load-balancing in Kubernetes is somewhat redundant. The LB exposes an endpoint and proxies traffic to the cluster's nodes via the Nodes' (service's) NodePort. Kubernetes then proxies traffic to one of the Pods backing the service. A two-fer with the challenge that the LB is disintermediated from the backend (Pods), but...
Because microk8s is only a single Node (the host), this functionality of the Load-balancer is redundant; it must always route traffic to the same Node (the host). Because Kubernetes uniquely assigns NodePorts, it also make sense (though this could be advanced functionality) to use the NodePort as the LB's port. As a result, the TCP Load-balancer is effectively just a pass-through.
BUT it provides a benefit that a client need not ask "Are you microk8s? Do you support TCP Load-balancing?", it can simply do the equivalent of kubectl expose service --type=LoadBalancer (as it would only many other Kubernetes services) and get a object back that behaves like a Load-balancer, provides an endpoint (localhost:${NodePort}) and works as expected.
Another advantage is that, if it's a simple as I suspect, microk8s could include this as a default, trivial implementation that avoids taking additional dependencies on 3rd-party offerings.

Let me think about this a bit. However, I would like to point out that MicroK8s is not a single node cluster, have a look at https://microk8s.io/docs/clustering

IDNKT :-)
Yes, this changes things.
Sorry to have wasted your time.


server: do not deploy or upgrade vm with inactive service offering

Description
This PR fixes #6740
The deleted service offering is not removed , but changed to Inactive state.
Therefore the state needs to be checked when deploy/create new vm or upgrade vm.
Similar check is added to router service offering as well.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

    (localcloud) 🐱 > deploy virtualmachine zoneid=7c9769a1-ba70-4f3a-a976-5a6ae7d946bb templateid=936f5eda-6be2-11ed-a030-1e0066000350 networkids=e7d3308c-03fc-4411-998d-ff45a2c1fccc  serviceofferingid=c1ebd091-57a6-427a-99a9-6c482de84a4f
    {
      "virtualmachine": {
        "account": "admin",
    ...
      }
    }

    (localcloud) 🐱 > delete serviceoffering id=c1ebd091-57a6-427a-99a9-6c482de84a4f
    {
      "success": true
    }

    (localcloud) 🐱 > deploy virtualmachine zoneid=7c9769a1-ba70-4f3a-a976-5a6ae7d946bb templateid=936f5eda-6be2-11ed-a030-1e0066000350 networkids=e7d3308c-03fc-4411-998d-ff45a2c1fccc  serviceofferingid=c1ebd091-57a6-427a-99a9-6c482de84a4f
    🙈 Error: (HTTP 431, error code 4350) service offering is Inactive: c1ebd091-57a6-427a-99a9-6c482de84a4f

Is this bugfix good for 4.18 cc @weizhouapache @DaanHoogland ?
@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5478

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Is this bugfix good for 4.18 cc @weizhouapache @DaanHoogland ? @blueorangutan package

@rohityadavcloud cc @DaanHoogland
yes but it has low priority

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
@rohityadavcloud cc @DaanHoogland
yes but it has low priority  SystemVM template(s). I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5484

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5485

Trillian test result (tid-6083)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39396 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7063-t6083-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_deploy_vm_with_extraconfig_kvm
Error
1.17
test_deploy_vm_extra_config_data.py

test_03_update_vm_with_extraconfig_kvm
Error
1.15
test_deploy_vm_extra_config_data.py

test_02_deploy_vm_on_specific_cluster
Error
0.12
test_vm_deployment_planner.py

test_03_deploy_vm_on_specific_pod
Error
0.14
test_vm_deployment_planner.py

test_04_deploy_vm_on_host_override_pod_and_cluster
Error
0.14
test_vm_deployment_planner.py

test_05_deploy_vm_on_cluster_override_pod
Error
1.15
test_vm_deployment_planner.py

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5488


Provide more detailed decorate documentation

There are subtle differences between this function from one series to the next, as per comment here: https://github.com/d3fc/d3fc-series/pull/43#discussion_r135208397

This issue was moved to d3fc/d3fc#1118


init.py

Why do we have an init.py file in the main directory? Does it do something? It was created with the accounts app, as I can see.

maybe


What's the recommend way to indicate debug is also implicated sampled in tracing context

Hi, so we are have some discussion around how should the tracing context handle the situation where the debug is also a implicated sampled decision.
We have a bitmask to represent the sampling state in tracing context where sampled and debug are represent in different bit. And the tracing context has isSampled() method to tell user whether or not to record current span.
In order to make sure isSampled() method returns true when the sampling state is either debug or sampled. We have the following two choices.

Set debug bit and sampled bit when decision is debug. And isSampled() method will simplely return whether the sampled bit is set.

Set debug bit only when decision is debug. But isSampled() method will have to return true if debug bit or sampled bit is set.

We are wonder if there is a preferred way from the spec standpoint. Thanks in advance!

in brave, we ensure the sampling bits are assigned when debug is, even if they weren't propagated. This means that outgoing would have both sampled and debug even if sampled wasn't passed on the way it. This is better in practice as some tools don't understand debug.
  static int debug(boolean debug, int flags) {
    if (debug) {
      flags |= FLAG_DEBUG | FLAG_SAMPLED_SET | FLAG_SAMPLED;
    } else {
      flags &= ~FLAG_DEBUG;
    }
    return flags;
  }

https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/SamplingFlags.java#L178-L185


Update GMT5 recipe

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-admin, please rerender

@ocefpaf @leouieda In this PR, I sync up the GMT5 recipe with the GMT6 recipe, and add myself as a maintainer. It's ready for review.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Created the branch and merged it. Thanks @seisman!


Bug fix for spinner on index page

Description
This is a pull request for a small bug fix in the index page for issue #22
Additional Information
Your ENS/address: iafhurtado.eth

This was quick nice.

I don't quite think you have it solved friend.
// Show the spinner only when isInAllowList is false
<>{isInAllowList && <Spinner />}</>

The above code only shows the loading spinner if isInAllowList is not false and is already in an else block that makes reaching that state impossible so the loading spinner will never be shown.
The problem we are having with the spinner is that it is showing before a user has even attempted to connect their account and so that means we will not ever know whether they are in the allow list at this state so the allow list is irrelevant right now.
You also probably want to clean up your commit history to only include the relevant file worked on.

Great feedback, will rework PR. 🪓


REDUNDANT_AWAIT warning not reported

Godot version
4.1.dev(c151d3231f)
System information
MacOS 13.4 M1 Pro
Issue description
This a regression from #74949. The warning is not trigerred even when it should be. it wasn't detected before as the test did not raise an error until more recently, but the warning was indeed already not present since then.

Edit :
The test seems to pass consistently I don't know why it didn't pass before but the warning is still not raisede where it should.
The difference between this and the test case is the presence of the return type hint. Without it, it won't raise the warning.
Steps to reproduce
copy paste this code it should raise a warning just as stated in the test case but it isn't
func test():
	print(await not_coroutine())

func not_coroutine():
	return "awaited"

Minimal reproduction project
N/A

It is correct. Without the return type hint, there is no warning, as the function may return a signal. See https://github.com/godotengine/godot/issues/74879#issuecomment-1471382046


MSI UI Icon

Follow-up from #90.

The minimal MSI installation progress UI displays a generic icon.
It would be nice for it to include the given application's icon, if any.

(maybe addressing #91, requiring changes to the install progress UI, helps us understand how to attain this) :)

NOTE:

While addressing #91 under #105, learned that we will need two bitmaps for the MSI UI.
Per the WiX docs at https://wixtoolset.org/documentation/manual/v3/wixui/wixui_customizations.html:

WixUIDialogBmp is a 493×312 pixel bitmap.
WixUIBannerBmp is a 493×58 pixel bitmap.

IDEA:

Maybe we could use pillow to auto-generate such bitmaps if/when an icon is given.
How hard can that be? :-)

NOTE:

While addressing #91 under #105, learned that we will need two bitmaps for the MSI UI.
Per the WiX docs at https://wixtoolset.org/documentation/manual/v3/wixui/wixui_customizations.html:

WixUIDialogBmp is a 493×312 pixel bitmap.
WixUIBannerBmp is a 493×58 pixel bitmap.

IDEA:

Maybe we could use pillow to auto-generate such bitmaps if/when an icon is given.
How hard can that be? :-)

PROGRESS:

Played around a bit with pillow.
This mini program produces a simple banner given an ICO file.
Pimping things up a bit could be nice... (how?)

#!/usr/bin/env python3.7

from PIL import Image

BANNER_WIDTH = 493
BANNER_HEIGHT = 312
BANNER_LEFT = 164

BANNER_BACK = 'white'

ICON_WIDTH = 64
ICON_HEIGHT = 64

ICON_X = (BANNER_LEFT - ICON_WIDTH) // 2
ICON_Y = 24

if __name__ == '__main__':

    ico = Image.open('mu.ico')
    ico64 = ico.resize((ICON_WIDTH, ICON_HEIGHT))

    banner = Image.new('RGBA', (BANNER_WIDTH, BANNER_HEIGHT), BANNER_BACK)
    banner.alpha_composite(ico64, (ICON_X, ICON_Y))

    banner.save('banner.png')

NEXT:

Let's try and integrate such a banner into the MSI files, shall we?

PROGRESS:

Played around a bit with pillow.
This mini program produces a simple banner given an ICO file.
Pimping things up a bit could be nice... (how?)

#!/usr/bin/env python3.7

from PIL import Image

BANNER_WIDTH = 493
BANNER_HEIGHT = 312
BANNER_LEFT = 164

BANNER_BACK = 'white'

ICON_WIDTH = 64
ICON_HEIGHT = 64

ICON_X = (BANNER_LEFT - ICON_WIDTH) // 2
ICON_Y = 24

if __name__ == '__main__':

    ico = Image.open('mu.ico')
    ico64 = ico.resize((ICON_WIDTH, ICON_HEIGHT))

    banner = Image.new('RGBA', (BANNER_WIDTH, BANNER_HEIGHT), BANNER_BACK)
    banner.alpha_composite(ico64, (ICON_X, ICON_Y))

    banner.save('banner.png')

NEXT:

Let's try and integrate such a banner into the MSI files, shall we?

CLOSING:

Just merged PR #172.
One less thing todo under #85.


Remove unused config variable and Docker Compose files

Description
Removes the unused port setting in peer/core.yaml and the now-obsolete Docker Compose files in the consensus directory.
Motivation and Context
Eliminate user confusion. Fixes #1548, #1567.
How Has This Been Tested?
No new test needed, this PR just removes unused files. Passes all unit and behave tests.
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Kostas Christidis<EMAIL_ADDRESS>

Thank you @kchristidis, this is a nice cleanup.  It sounds from the comments in the referenced issues that this is generally agreed to be the right actions.  However, I would feel better if a stakeholder or two could chime in with agreement here before merging.

@ghaskins: Thanks for the note. As you note in #1662, and as a grep for viper.GetInt("peer.port") shows, nothing in the code reads this option. For the sake of completeness, I will amend the original PR by removing the lines in main.go that reference the port variable, so I'm going for Option 3.
Depending on the verdict of #1662, feel free to accept or reject it.

@ghaskins Viper does not bind command-line flags to YAML/Environment Variables. All of the command-line flags other than --logging-level should be eliminated from the main.go as they don't work.

@tuand27613 @corecode I am not familiar enough with the consensus docker compose, so could you please review and comment.  In general, I like what @kchristidis did: Removing a lot of stuff :-)

Agree with @kchristidis  on removal of consensus/docker-compose-files/*
These files originally were for unit testing back in obc-peer days. Not needed as we now have the files in ./bddtests, Bishop's busywork tool and Ramesh's utility.

@ghaskins is waiting on me, and I'm checking to see if @bcbrock is right.
I have reproduced the behavior that @bcbrock sees in #578, i.e. the flag does not bind to the config values (but the environment variables do). This is not supposed to happen according to the viper documentation.
Running some tests to make sure we're configuring this right. Will update.

@ghaskins: Removed the additional port references you found. Once, Travis is done, this PR should be good to go.
I debugged the issue that @bcbrock brought up in #578. Viper works fine; no need to remove the flags but we do need to issue a fix. Will push a separate PR for this today.

(@ghaskins: The failure reported by Travis seems to be on test #680, which according to your statement is "notoriously flaky". Let me know if you need anything else from me.)

if 680 is flakey, can we stub it out until it is fixed?

Looking at the logs, I am seeing the failure as caused by:
    When I query chaincode "example2" function name "query" with value "a" on peers                                             # steps/peer_basic_impl.py:422
      | vp0 | vp1 | vp2 | vp3 |
      Traceback (most recent call last):
        File "/usr/local/lib/python2.7/dist-packages/behave/model.py", line 1456, in run
          match.run(runner.context)
        File "/usr/local/lib/python2.7/dist-packages/behave/model.py", line 1903, in run
          self.func(context, *args, **kwargs)
        File "steps/peer_basic_impl.py", line 424, in step_impl
          query_common(context, chaincodeName, functionName, value, True)
        File "steps/peer_basic_impl.py", line 450, in query_common
          resp = requests.post(request_url, headers={'Content-type': 'application/json'}, data=json.dumps(chaincodeInvocationSpec), timeout=30, verify=False)
        File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 94, in post
          return request('post', url, data=data, json=json, **kwargs)
        File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 49, in request
          return session.request(method=method, url=url, **kwargs)
        File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 457, in request
          resp = self.send(prep, **send_kwargs)
        File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 569, in send
          r = adapter.send(request, **kwargs)
        File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 422, in send
          raise ReadTimeout(e, request=request)
      ReadTimeout: HTTPConnectionPool(host='<IP_ADDRESS>', port=5000): Read timed out. (read timeout=30)

The last line of vp3's log (<IP_ADDRESS>) is:
19:53:20.602 [rest] Query -> ERRO f08 {"Error": "Querying Chaincode -- Error:Failed to execute transaction or query(Timeout expired while executing transaction)"}

Prior to this timeout in vp3's log I see:
19:51:49.807 [consensus/obcpbft] processEvent -> DEBU ce7 Replica 3 batch main thread looping
19:51:49.807 [consensus/obcpbft] processEvent -> DEBU ce8 Replica 3 processing event
19:51:49.807 [consensus/obcpbft] processEvent -> INFO ce9 Replica 3 application caught up via state transfer, lastExec now 42
19:51:49.807 [consensus/obcpbft] moveWatermarks -> DEBU cea Replica 3 updated low watermark to 42
19:51:49.807 [consensus/handler] ValidateState -> DEBU ceb Validating the current state
19:51:49.807 [consensus/obcpbft] executeOutstanding -> DEBU cec Replica 3 attempting to executeOutstanding
19:51:49.807 [consensus/obcpbft] executeOutstanding -> DEBU ced Replica 3 certstore map[]

This indicates to me that vp3 is actually in a good state, state transfer has completed, and it is up to date. (Checking the log for vp1 confirms, that indeed, the last seqNo executed should be 42).  I think it's worth investigating what's going on here, because as far as consensus/statetransfer (which is the target of this test) is concerned, this test is completing successfully.  Instead, it is the query to verify this which is timing out.

@jyellick: Interesting. I pushed an empty commit so as to re-trigger Travis. Let's see what we get this time.

@jyellick are you suspecting that the unit-test failures are possibly legit and we should hold off this merge?

@ghaskins I have no reason to believe that this particular set of commits is problematic.  I was responding to the suggestion that we disable the issue_680 behave test.  When tests are failing because of inconsistent timing or other problems, I understand disabling them until the test can be redesigned to work more consistently.  In this case though, as best as I can tell, the test is operating as expected, and it's unclear why this query is timing out.
As you can see from the log, vp3 was caught up and should have been in a consistent state as of 19:51:50, and a query timed out after 30s at 19:53:20.  This would indicate to me that we are witnessing a bug in the fabric that should be investigated and fixed, not a bug in the test that should be suppressed.

@jyellick ah, ok.  Thank you for the explanation.  I just wanted to make sure you weren't concerned that this patch might be causing a real failure.  It sounds like it should be ok to go in.

LGTM
Reviewed-by: Greg Haskins<EMAIL_ADDRESS>

@kchristidis you can re-run travis by clicking on the details link in the PR summary page and there's a small recycle glyph in the Travis UI

@jyellick agree, think we should open an issue and have someone investigate

@christo4ferris: I did not know that and instead went with what the Travis CI README suggested. Thank you!


[#2279] improvement(test): Isolate catalog class path in IT

What changes were proposed in this pull request?
Move the test cases that depend on the Docker environment to their corresponding catalog modules.
Why are the changes necessary?
For better management.
Fix: #2279
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing test can cover the changes.

@yuqi1129 I would suggest we have a thorough solution before doing this change.

@yuqi1129 I would suggest we have a thorough solution before doing this change.

Let me thoroughly review the hive-related tests. It appears that the hive-related tests have more complex dependencies:

HDFS. This is to check the file's existence and read/write status.  For example, drop an external table and verify if the path of the table is clear.
Hive Metastore was used to check the status of the Hive Docker instance, retrieve Hive table objects through Thrift, and then compare them with that loaded by Gravitino.
Thrift: Handle some exceptions.

Iceberg and JDBC-related tests are clear and under control.

Issue has nothing related to your PR, please fix the issue. Also adding detailed descriptions to issue.

The code is far from ready, please spend time on polishing it, and think about the overall code organizations.

@jerryshao
This PR is ready for review.

You should also check why tasks.configureEach<Test> in root gradle is not worked. Also, if the tasks.configureEach<Test> is not worked, it means other codes here is also not worked, like setting testNG and others, you should confirm all.

Also, I think you need to keep this behavior after the change
  tasks.configureEach<Test> {
    testLogging {
      exceptionFormat = TestExceptionFormat.FULL
      showExceptions = true
      showCauses = true
      showStackTraces = true
    }
    reports.html.outputLocation.set(file("${rootProject.projectDir}/build/reports/"))
    val skipTests = project.hasProperty("skipTests")
    if (!skipTests) {
      if (project.name == "trino-connector") {
        useTestNG()
        maxHeapSize = "2G"
      } else {
        useJUnitPlatform()
      }

      jvmArgs(project.property("extraJvmArgs") as List<*>)
      finalizedBy(tasks.getByName("jacocoTestReport"))
    }
  }

You should also check why tasks.configureEach<Test> in root gradle is not worked. Also, if the tasks.configureEach<Test> is not worked, it means other codes here is also not worked, like setting testNG and others, you should confirm all.

Maybe we need to clarify what the skipTests means. In the main branch, skipTests will skip all tests in the module, it's equivalent to skipping all unit tests, however, when we move ITs to the module, I want to confirm what the behavior skipTests we need to abide by.
The latest changes means we will skip all unit tests if users set property skipTests.

You should also check why tasks.configureEach<Test> in root gradle is not worked

It works actually if skipTests means skipping all tests including ITs.

Also, I think you need to keep this behavior after the change
  tasks.configureEach<Test> {
    testLogging {
      exceptionFormat = TestExceptionFormat.FULL
      showExceptions = true
      showCauses = true
      showStackTraces = true
    }
    reports.html.outputLocation.set(file("${rootProject.projectDir}/build/reports/"))
    val skipTests = project.hasProperty("skipTests")
    if (!skipTests) {
      if (project.name == "trino-connector") {
        useTestNG()
        maxHeapSize = "2G"
      } else {
        useJUnitPlatform()
      }

      jvmArgs(project.property("extraJvmArgs") as List<*>)
      finalizedBy(tasks.getByName("jacocoTestReport"))
    }
  }

This behavior has not changed.

You should also check why tasks.configureEach<Test> in root gradle is not worked. Also, if the tasks.configureEach<Test> is not worked, it means other codes here is also not worked, like setting testNG and others, you should confirm all.

Maybe we need to clarify what the skipTests means. In the main branch, skipTests will skip all tests in the module, it's equivalent to skipping all unit tests, however, when we move ITs to the module, I want to confirm what the behavior skipTests we need to abide by.
The latest changes means we will skip all unit tests if users set property skipTests.

You should also check why tasks.configureEach<Test> in root gradle is not worked

It works actually if skipTests means skipping all tests including ITs.

Let's keep this behavior.

Let's keep this behavior.

Okay, I will revert the latest changes.

I mean keep what current main branch's definition: skipTests => skip UT, skipITs => skip IT, not reverting it. You can check the ci script, currently there's no chance to run ITs in each catalog.

I mean keep what current main branch's definition: skipTests => skip UT, skipITs => skip IT, not reverting it. You can check the ci script, currently there's no chance to run ITs in each catalog.
You should think about which way is the right way, not just changing it and then reverting it abruptly.

I see.  I will use another PR to change the name skipTests to skipUTs, the current name is quite misleading.

Each sub-module needs to configure useJUnitPlatform() to make the UTs work well, that is how skipTests is working.

Thanks @yuqi1129 for your work, please keep improving if there's something missing or need to refactor further.

I mean keep what current main branch's definition: skipTests => skip UT, skipITs => skip IT, not reverting it. You can check the ci script, currently there's no chance to run ITs in each catalog.
You should think about which way is the right way, not just changing it and then reverting it abruptly.

I see. I will use another PR to change the name skipTests to skipUTs, the current name is quite misleading.

It's actually the way maven uses, maven uses skipTests to skip all the UTs.

I mean keep what current main branch's definition: skipTests => skip UT, skipITs => skip IT, not reverting it. You can check the ci script, currently there's no chance to run ITs in each catalog.
You should think about which way is the right way, not just changing it and then reverting it abruptly.

I see. I will use another PR to change the name skipTests to skipUTs, the current name is quite misleading.

It's actually the way maven uses, maven uses skipTests to skip all the UTs.

To the best of my ability, SkipTests will skip all tests other than UTs.


GLTF/GLB files not showing correctly on explorer

Issue Overview:
Currently, when requesting or fetching GLTF/GLB files using the /content/inscription_id endpoint in our application, the files are being served without any file extension. This creates inconvenience and inconsistency as the files should ideally be served with their appropriate extensions for proper identification and usage.
Expected Behavior:
We expect the GLTF/GLB files to be served with their respective extensions when requesting or fetching them through the /content/inscription_id endpoint. This would enable seamless integration and consistent handling of the files across our application.
Steps to Reproduce:
Make a request or fetch the GLTF/GLB file using the /content/inscription_id endpoint.
Observe the response and note that the file is served without any file extension.
Additional Information:
This issue affects our application's functionality and makes it challenging to process the GLTF/GLB files correctly. It is important to serve the files with their appropriate extensions for compatibility with other systems and tools that rely on these file formats. We believe that addressing this issue would enhance the overall usability and interoperability of our application.
Please let me know if any further information is required.

The data model of inscriptions is that of a HTTP response so the MIME type of the file is set in the Content-Type header. The .glb file extension has the MIME type model/gltf-binary.

Noticing that ordinals.com recognizes the MIME type correctly (model/gltf-binary) but the frontend is not displaying the 3D object properly.
example: https://ordinals.com/inscription/d0567fd09a67cc512a9270d8f55d2e891b78d6026f13a370ffed570e494f1100i0
other explorers seem to be displaying properly:
Ordiscan - https://ordiscan.com/inscription/17486115
Ord io - https://www.ord.io/11637870

Ok good catch, will reopen

Still have to deploy to ordinals.com but just merged #2369


Scrolling in ngScrollbars div affects adjacent div scrolling

I have a navigation menu on the left side of my page to which I've added ngScrollbars.  I've configured it and it works great.  The only problem I'm having is with the page content div which is to the right of the left menu "pane".  I have not implemented ngScrollbars to this div; it has the default browser scrollbar when needed (overflow: auto;).  I've found that when both the left side and page content are scrollable, when I scroll to the bottom of the ngScrollbars div and continue to scroll down, it scrolls down in the adjacent page content div.  Likewise, when I scroll to the top of the ngScrollbars div and continue to scroll up, it scrolls up in the adjacent page content div.
This is pretty bizarre behavior that I can't imagine is expected.  Any ideas?  I'm experiencing this in all browsers.  I'm hoping it's just a simple config change...
ps. Thanks for porting the mCustomScrollbar jQuery plugin into Angular!

It turns out there is actually a config setting for this :stuck_out_tongue_winking_eye::
mouseWheel: { preventDefault: true }

Thanks! I'm glad you figured it out and I appreciate the detailed issue


update gems

Test Branch Commit

Test

Update branch and commit

test

Commit File (Test)

Test Review

tt


[HUDI-5846] use the right constructor of SparkBulkInsertDeltaCommitActionExecutor

Change Logs
JIRA: HUDI-5846.
Avoid ClassCastException while using constructor of SparkBulkInsertDeltaCommitActionExecutor
for 'Map' to 'BulkInsertPartitioner'
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

Closing this PR as master already has the change


Problematic use of babel-plugin-flow-react-proptypes in ESM build

The use of babel-plugin-flow-react-proptypes in the es Babel env causes many CJS require calls to end up in what should be an ESM build. You can observe this in the published build; for example, List contains require('../Grid').
This largely defeats the purpose of an ESM build, since it means that most modules in the build cannot be tree-shaken under any circumstances.
The problem was introduced in #731 and there's some discussion about the need for the plugin in #730.

P.S. thanks for your amazing work on this library ❤

Unfortunately it looks like the Babel plugin cannot currently output ESM, but there is talk of potentially supporting it in brigand/babel-plugin-flow-react-proptypes#159.
I've seen other libraries solve this problem by using Flow types internally and also adding explicit propTypes to user-facing components (rather than using a Babel plugin which transpiles the former into the latter). The duplication sucks, but it more explicitly captures the fact that Flow types can't always map precisely onto PropTypes (e.g. functions), and tests can generically prevent the two from getting out of sync.

@billyjanitsch I have the same decision. Gonna write explicit prop types maybe in next minor release.


replace method for deprecation and keep reference of requestTemplate

there are some integration codes in out project making use of the requestTemplate, but after enable sleuth the reference is null. We found the reason here and the method of building the request is depracated

can you check which version of feign this sets minimum to? we should add that to the release notes.
also is there a unit test that can show the template saved is usable?

@adriancole - the OpenFeign version would be 10.7.2. It comes as a transitive dependency here from Spring Cloud OpenFeign, anyway.
@HashZhang Thanks for the PR. Could you please add a test as @adriancole has suggested.

Added
@adriancole
@OlgaMaciaszek


KAFKA-17749: Fix Throttler metrics name

Since we (well I) inadvertently changed the Throttler metric names in https://github.com/apache/kafka/commit/e4e1116156d44d5e7a52ad8fb51a57d5e5755710 (included in both 3.8.0 and will be in 3.9.0), I suggest treating this as a bug and fixing it without doing a KIP.
We should be able to backport to 3.8.1 and 3.9.1.
cc @chia7712 since you reviewed https://github.com/apache/kafka/pull/16023
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Would you include it in the notable changes for 3.8.0 and again in 3.8.1/3.9.0 to say it's reverted back?

I would maybe just include it on the notable changes of 3.8.1.
"This metric's name was changed by mistake, it was wrongly renamed to  org.apache.kafka.storage.internals.utils.Throttler now is back at kafka.utils.Thottler"
Something like this I think is sufficient.

Then we can merge as is in trunk, and include a note in upgrade.html when we backport to 3.8 and 3.9

Let's do it!


Add detail about module header usage guide

Prerequisites
Put an x into the box(es) that apply:

[ ] This pull request fixes a bug.
[ ] This pull request adds a feature.
[ ] This pull request enhances existing functionality.
[ ] This pull request introduces breaking change.
[x] This pull request enhances documentation.

For more information, see the Contributing Guide.
Description
Add detail on extracting module header to user guide.
Issues Resolved
Fixes #278
Checklist
Put an x into all boxes that apply:

[ ] I have read the Contributing Guidelines.

Tests

[ ] I have added tests to cover my changes.
[ ] All tests pass when I run make test.

Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Code Style

[ ] My code follows the code style of this project.

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   81.68%   81.68%
=======================================
  Files          34       34
  Lines        1796     1796
=======================================
  Hits         1467     1467
  Misses        274      274
  Partials       55       55


Modify actions to avoid processing when only doc PRs

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing changes and/or breaks backward compatability?:

@mbrandenburger please review PR when you can.


Gestouch suddenly stopped working on Windows 10 with latest Animate CC

I have an AIR application that has been running Gestouch for a couple of years. I've been updating it regularly and now Gestouch events stopped working on Windows 10 after updating to the latest Animate CC release. They work as expected on Mac.
I've also tried running the source code in Animate CC on the Windows machine but the event just doesn't fire. Other events like MOUSE_DOWN and CLICK works.
Have any tricks up your sleeve?
Edit:
It's more specifically the TransformGestureEvent.GESTURE_TRANSFORM and PanGestureEvent.GESTURE_PAN events that stops firing.
Seems to have something to do with the multi-touch drivers from PQLabs (multitouch.com). Uninstalled them, rebooted and it works. Worked with the drivers installed a couple of days ago. Wierd. Have to investigate further.

@stefanedberg mhm perhaps some logs will help you understand what's happening
Check if this makes sense to you https://github.com/fljot/Gestouch/commit/7d929b23b6482e2448ef18ab412d27fae4c2a325 (I remember adding logging in develop branch https://github.com/fljot/Gestouch/tree/develop)

Closing for now. Please feel free to update and reopen.


Code check in?

Hi! I'm hoping to set up a bot like the one in the A-Frame Slack, for our own Slack, to notify us if people ask relevant questions.
I looked through the code here and also in https://github.com/mkungla/slackoverflow but it looks like it's just the boilerplate and the actual code for the API and bot itself is missing?
If it might possible to share it, that'd be great! Thanks.

No worries, I found donmccurdy/stack-overflow-feed-bot !

@mkungla Is the code for the bot there?

@ngokevin and @poshaughnessy no working bot which we are using is not donmccurdy/stack-overflow-feed-bot so I should check actual bot in here, will try to find coming days time to pick that up and update this repo.

@poshaughnessy so can also reopen this and I notify you when I have checked in our bot.

@poshaughnessy this can be closed now let me know if you have any questions


Add more options to Integer.Format.Hexadecimal.

The following options have been added:

lowercase - use lowercase instead of uppercase A-F letters
without_leading_zeros - don't include leading zeros in the output

Motivation: These options are needed for printing IPv6 addresses in the new https://github.com/savi-lang/IPAddress package.


Add missing groups parameter to createUser API

As discussed with @LukasHirt
https://talk.owncloud.com/group/aarnet-tech?msg=c2wy8KRkF4tQseMh4
This SDK is missing the groups parameter - this enables subadmin users of a specific group to create more users in that group, which was not previously possible via this API.

@rpocklin I quickly edited the commit message so I could push again into this PR to restart the CI - we switched back to .drone.yml to unblock this PR. CI should be green now.


build system now supports more build environments

Before if you were compiling with Clang on Windows using MSYS2 or any environment that wasn't Windows native it would try and use MSVC build flags no matter what compiler was selected. I fixed that issue with my edits. Change anything you dislike.
(By the way, I've never contributed to someone else's project, if I'm suppose to open an issue first no matter what, I'm genuinely sorry)

Can confirm that this is needed to fix:
[12:08:15] i686-w64-mingw32-g++: error: /Zc:inline: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /EHs-c-: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /GR-: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /wd4244: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /wd4267: No such file or directory
[12:08:15] make[2]: *** [CMakeFiles/demumble.dir/build.make:77: CMakeFiles/demumble.dir/demumble.cc.obj] Error 1
[12:08:15] make[2]: *** Waiting for unfinished jobs....

@nico Could this be merged?


Update for 1.19

Was working until SiraUtil 3 in 1.19. Would love to see an update when possible :)

I did actually update it 3 weeks ago but forgot to create a new release here, oops. ¯\_(ツ)_/¯


⚠ Mobitopup has degraded performance

In eb12cb7, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4703 ms

Resolved: Mobitopup performance has improved in b3d870d after 420 days, 5 hours, 38 minutes.


Accept multiple paths on the command line

Currently ruplacer only accepts one path, unlike grep, sed, etc. I'd like to use it like
ruplacer foo bar folder1 folder2
ruplacer spam baz myproject/spam_*

I'll start working on it if you review #39
Deal?

... or you could - I hear you like Rust now :)

Lol, I was deceived! I'll think about it ^^

Hopefully I can make some progress on this with #93! 🤞


Instructions to onboard onto W3C trace context format are missing

Could you please add them here https://docs.microsoft.com/en-us/azure/azure-monitor/app/correlation#w3c-distributed-tracing

Thanks! Proposed the change on the repo.

Thanks!


CommandLine Error: Option 'use-dbg-addr' registered more than once

i installed codon with install.sh script, to use it in my existing project as @codon.jit
codon==0.15.3
codon-jit==0.1.1
but when i launch my program i get
: CommandLine Error: Option 'use-dbg-addr' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options
[1]    39236 IOT instruction (core dumped)  python3 main.py

Hi @DanInSpace104 -- first time I'm seeing this error! What OS and architecture are you on? Not sure what's in main.py, but I'm assuming you get the same error on a simple test program?

@arshajii i created test file, codon.jit decorator works fine.
I am trying to use it inside PyQt5 project, but i am wrapping 'clean' function that deals with variables of built-in types

@DanInSpace104 Can you please tell me more about your environment (OS, version, etc.)? I'd like to reproduce it if possible.


added Coverage

You want to make a PR to Talos
Thanks so much :) First, please take a moment to carefully check through
the below items:
Sanity

[x] I'm aware of the implications of the proposed changes
[x] Code is PEP8
[x] I'm making the PR to master

Docs

[x] Docs are updated
[x] Docs version is correct (index.html and _coverpage.md)

Tests

[x] Changes have gone through actual use testing
[x] All local tests have passed (run ./test.sh in /talos)
[x] Tests have been updated to reflect the changes

Pull Request Test Coverage Report for Build 640

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 85.619%

Files with Coverage Reduction
New Missed Lines
%

talos/model/network_shape.py
1
96.43%

Totals

Change from base Build 636:
0.1%

Covered Lines:
1280

Relevant Lines:
1495

💛  - Coveralls


provider: enable csi omap generator for client

send a configMap from provider to client to enable csi-omap generator required for DR on client cluster

Closing this as we pivoted from the design


No spacing after divider "/"

I've have three crumbs and they don't get a space after the "/" but in the examples, there is a space.
What I expect
Home / One / Two
What I get
Home /One /Two
{% breadcrumb "Home" "app:home" %}
{% breadcrumb "One" "app:one" %}
{% breadcrumb "Two" "app:two" %}

The issue was the default breadcrumb template is using bootstrap2, I'm using v4.
I added this to my settings from the docs and I'm now getting properly formatted dividers.
BREADCRUMBS_TEMPLATE = "django_bootstrap_breadcrumbs/bootstrap4.html"

resolved


Backport of HSEARCH-5057 to 7.0 - Bump software.amazon.awssdk:auth from 2.22.1 to 2.23.3

https://hibernate.atlassian.net/browse/HSEARCH-5057

Hmm, no, let's not backport a minor version upgrade of a dependency. Especially since there's no particular reason for the upgrade :)
Closing, let's focus on #3906.


fixed mnemonics are not being used

This agd keys add is missing the --recover option:
https://github.com/Agoric/agoric-3-proposals/blob/ed0faf911e5972f660f7480b1ee1d611e598517a/packages/synthetic-chain/public/upgrade-test-scripts/run_prepare_zero.sh#L16
cc @turadg @LuqiPan @ivanlei

@dckc the command is agd keys export user1 --unsafe   --unarmored-hex --keyring-backend="test" to export private keys


Duplicate redraw calls in cmdline cause flicker

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Issues

[X] I have checked existing issues and there are no open or closed issues with the same problem.

Neovim Version
NVIM v0.7.0-dev+793-g991e872d8
Minimal reproducible config
set packpath=

if has('vim_starting')
  set encoding=utf-8
endif
scriptencoding utf-8

if &compatible
  set nocompatible
endif

let s:plug_dir = expand('/tmp/plugged/vim-plug')
if !filereadable(s:plug_dir .. '/plug.vim')
  execute printf('!curl -fLo %s/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim', s:plug_dir)
end

execute 'set runtimepath+=' . s:plug_dir
call plug#begin(s:plug_dir)
Plug 'hrsh7th/nvim-cmp'
Plug 'hrsh7th/cmp-buffer'
call plug#end()
PlugInstall | quit

" Setup global configuration. More on configuration below.
lua << EOF
local cmp = require "cmp"
cmp.setup {
  mapping = {
    ['<CR>'] = cmp.mapping.confirm({ select = true })
  },
  formatting = {
    fields = { "kind", "abbr", "menu" },
  }
}
cmp.setup.cmdline('/', {
  sources = {{ name = 'buffer' }},
})
EOF

hi CmpItemAbbrMatch ctermfg=green
hi CmpItemAbbrFuzzyMatch ctermfg=blue
EOF

Description
https://github.com/hrsh7th/nvim-cmp/blob/1b94aacada96d2a33fef2ecf87748b27a2f50630/lua/cmp/view/custom_entries_view.lua#L222-L226
https://github.com/hrsh7th/nvim-cmp/blob/1b94aacada96d2a33fef2ecf87748b27a2f50630/lua/cmp/utils/window.lua#L177-L181
While typing in cmdline, the two duplicate redraw calls will cause flicker of completion window.
Flicker:

No flicker (remove one of the redraw call in src):

This might seem subtle in the minimal reproduce sample, but the flicker is much more apparent if the rendering costs more time (in my dialy use).
Steps to reproduce
Enable cmdline completion and type in cmdline.
Expected behavior
There should be no flicker of completion window.
Actual behavior
The flicker happens on keystroke at times.
Additional context
No response

I'll fix this. thank you!

interestingly enough; I'm getting this issue again, with the cmdline plugin. same behaviour, for instance, my Packer* commands are doubled up. is this a regression perhaps @hrsh7th?


optimize manifest requests for registry based depedendcies

motivation: improve performance by reducing redundant http calls
changes:

save main manifest on first request
cache known manifest across calls in RegistryPackageContainer
add RegistryPackageContainer tests
fix a bug in workspace where custom tools version is not propogated to the toolsLoader

rdar://86218181

@swift-ci please smoke test


OtherPassword privilege perhaps-unnecessarily required (3.0.78)

With a (non-DataCurator/SystemUser) user with CodeModification but NOT with OtherPassword privilege, some things work but some other things don't work.   While there are some gotchas in using symboldictionary and symbollists without OtherPassword in this old server version, it seems like the specific failures here seem to be using symbol dictionaries as temporary dictionaries when perhaps ordinary dictionaries or arrays would do.
As this user, I can (re) load a project that was already loaded previously (before I took away the privilege), and clone a project, but not load the newly cloned project (compileUsingNewClasses:andExistingClasses:).
I can create new classes but not save methods (error in _parseMethod:category:using:environmentId:).
Also when I am in the the debugger and looking at the method (probably not one that is accessible as this user), I get an error dialog "Array does not understand #start".

Also get this from time to time in the debugger, when attempting to find popup menu.

CodeModification is required - I get walkbacks everywhere without that, but it's fairly reasonable to expect a code management system to require CodeModification.  Otherwise, as of 3.2.12, a new user with no additional privileges appears to be able to create a package, class, methods, unload and reload, and examine stacks in debugger.


Import Error on El Capitain

I have a pyenv virtualenv running 2.7.11. I run the following:
pip install newspaper
Which runs fine.
When I run the REPL I get the following:
Python 2.7.11 (default, Feb 22 2016, 10:04:27)
[GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import newspaper
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/newspaper/__init__.py", line 10, in <module>
    from .article import Article, ArticleException
  File "/Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/newspaper/article.py", line 12, in <module>
    from . import images
  File "/Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/newspaper/images.py", line 19, in <module>
    from PIL import Image, ImageFile
  File "/Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/PIL/Image.py", line 66, in <module>
    from PIL import _imaging as core
ImportError: dlopen(/Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/PIL/_imaging.so, 2): Symbol not found: _PyUnicodeUCS2_AsLatin1String
  Referenced from: /Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/PIL/_imaging.so
  Expected in: flat namespace
 in /Users/ben/.pyenv/versions/burtonmail/lib/python2.7/site-packages/PIL/_imaging.so
>>>

It looks to be a problem with linking PIL references but I'm not sure how to proceed.

Can you try upgrading Pillow (pip install -U Pillow) and see what happens?

Hey - sure I did that - however the problem still persists.

Weird...
In any case, it's some issue with Pillow, so I think you'll have better luck opening an issue there: https://github.com/python-pillow/Pillow

OK - thanks !!


Downgrade dependency node-fetch to v2

The package crashes any attempts at loading in CJS because it attempts to load version 3 or over of node-fetch, which is not compatible with CJS. Please do not update node-fetch to version 3 in the future to ensure compatibility. Version 2 is still in long-term support.


Documentation for backup/restore is missing a few steps

The documentation for backup/restore at https://docs.chef.io/server_backup_restore.html is overall very good, but if you follow it verbatim, it will use the old SSL certificate for the old server's FQDN.
Before the chef-server-ctl reconfigure command, the following should be added:
Ideally, the server you restore to will have the same FQDN as the one you backed up. If this is not possible, perform the following additional steps:
edit /etc/opscode/chef-server.rb and /etc/opscode/chef-server-running.json to replace the old FQDN with the new one.
Delete the old SSL certificate, key and -ssl.conf file from /var/opt/opscode/nginx/ca . If you use a CA-issued certificate instead of a self-signed certificate, copy that certificate and key into the same directory.
On each client, update the /etc/chef/client.rb file to point to the new server.

Doc edit in : https://github.com/chef/chef-web-docs/blob/master/content/runbook/server_backup_restore.md

https://github.com/chef/chef-web-docs/pull/3342


Add -c config alias to the CLI

If you have multiple webpack configuration files then each of your scripts ends up requiring that you specify a config file, so having a shorthand for it is nice and convenient.

Thanks


ISPN-8074 failing random in computeIfPresent

https://issues.jboss.org/browse/ISPN-8074
Corrected the L1NOnTxInterceptor when an exception is raised from
the command.
This is done by properly waiting flush cache method call and propagating the exception to avoid race conditions.

comment adressed @rvansa

LGTM, just let the CI finish the night shift.

@rvansa CI finished successfully

Integrated, thanks.


Add initial ClearLinux support for testing RPM build

What does this PR do?
This adds RPM packaging support sufficient for testing installation of the datadog agent on Clearlinux
Motivation
Experimenting with using clearlinux
Additional Notes
The existing dependency scanning creates a dependency on /bin/sh in the resulting RPM.  I cannot find a way to inject %define __requires_exclude ^/bin/sh$ using omnibus, unless I manually create the spec.erb described at https://github.com/chef/omnibus/blob/3e43293a0eff95c4175c983247b737a2ce137e35/docs/Building on RHEL.md
Any suggestions on how to do this are welcomed.  Clearlinux installs /bin/sh as part of a different package entirely as part of the os-core bundle installation.
Describe your test plan
rpm -ivh --force  datadog-agent-7.26.0-1.x86_64.rpm; datadog-agent configcheck

Hi 👋 thanks for opening the PR.
I think the problem here is that the autogenerated /bin/sh dependency is generated for a reason - for example, the omnibus/package-scripts/agent/postinst script that your PR modifies has #!/bin/sh as the interpreter and AFAICT running on a system that doesn't have /bin/sh, it would just fail. There are more scripts that use /bin/sh as their interpreter as well. I'm not very familiar with Clear Linux, but I'll try to take a look at this and see what the best solution might be.

Ok, after getting more familiar with Clear Linux, I see where the problem is now:
Since Clear Linux is not primarily an RPM-based distribution, rpm can be installed on it, but the RPM database is empty (initially), so there is no package that provides /bin/sh in RPM terms, even if /bin/sh is actually present on the filesystem (installed via the os-core bundle).
I think that perhaps removing the /bin/sh dependency might be the right way to go, but I will have to investigate a little bit more what effect that would have on installation on all the RPM-based platforms that we support today. I'll update this discussion when I have a better understanding of whether or not we can do this change.

First of all, sorry for not responding further on this for a long time.
As for the solution, is it an option for you to use containerized agent as described in Datadog docs? That's generally a good way to go, unless there's something the containerized agent can't do on ClearLinux (in which case we'd love to hear specific issues).

Hello -
We are not currently planning to allow containerized applications to run on our production infrastructure.
We have tried to build a virtual RPM so that the RPM db reflects that /bin/sh is installed.  Is that a valid enough workaround that you could accept this PR?
cc:onfleet-ablair


WIP: Graceful deletion of a VirtualMachineInstance

When a host node is deleted, the guest VMIs are evicted, killing the
running tenant node in this VMI.
This PR gracefully delete the VMI, by first drain the guest node. Only
if the drain successful, CAPK will delete the VMI.
The PR is based on a feature in KubeVirt, where by setting the eviction
strategy to "external" KubeVirt will not delete the VMI, but will set
the vmi.Status.EvacuationNodeName field to signal to the external
controller (CAPK in this case) that the VMI should be evicted.
Working on progress. TODO:

[ ] check if can drain the node [?]
[x] add unit tests
[ ] add functional tests

Known Issues

does not support external clusters (#100)

Signed-off-by: Nahshon Unna-Tsameret<EMAIL_ADDRESS>Release notes:

Added graceful eviction of a VMI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 134 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.7%) to 42.271%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/vmi_controller.go
0
134
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.7%

Covered Lines:
711

Relevant Lines:
1682

💛  - Coveralls

/ok-to-test


Assign categories to expenses

add a categories table
add seed script to populate with some categories (mimics the splitwise category list)
add category relation to expense table,
add ability to select category in the create/edit forms

Re-submitted this implementation, merged with the expenseDate and uneven-split changes.
The intent here is to follow the split wise categories so it's easier to import from a CSV.
Happy to discuss the implementation.

@ChristopherJohnston looks great!
I had some trouble to make the migration work, so I changed it a bit, to insert categories into the database as part of the migration (instead of using a seed). It makes more sense to me, what do you think?

Closes #35

It looks fine as the migration. I'm now wondering if it's easier and better just to have a hard-coded list of categories to save the additional overhead from database queries - particularly if the categories are going to be fixed.

@ChristopherJohnston looks great!
I had some trouble to make the migration work

for reference I took the seed script concept from https://planetscale.com/blog/how-to-seed-a-database-with-prisma-and-next-js

I'm now wondering if it's easier and better just to have a hard-coded list of categories to save the additional overhead from database queries - particularly if the categories are going to be fixed.

That is a fair point, maybe it’ll be easier to deal with hardcoded categories.

I'm now wondering if it's easier and better just to have a hard-coded list of categories to save the additional overhead from database queries - particularly if the categories are going to be fixed.

That is a fair point, maybe it’ll be easier to deal with hardcoded categories.

Since the implementation is pretty much done, I'd keep it in the DB as it keeps things extensible. That's how I was about to implement it anyways :laughing:

Yep it's not a bad implementation as it is - just need to be careful of the impact on api calls on Vercel as volume increases. I would think it's fine for now

Thanks @Max-TheCat for the input! I’ll merge the PR as is. Worst case scenario we migrate to a hardcoded list, which wouldn’t be too much work 😉


Add browserstack logo to README & site

Fixes #624

Build failing, but as this is only site / documentation changes I am merging all the same

Oddly you cannot merge PRs with failed builds on a phone, but switch to desktop view and it's all good!


Locale setting unsuported

I pushed up mentalist from the source code on an Arch linux system and when I try to execute the program i get the error  File "/usr/lib/python3.6/site-packages/Mentalist-1.0-py3.6.egg/mentalist/view/main.py", line 15, in <module>     locale.setlocale(locale.LC_ALL, 'en_US.UTF-8')   File "/usr/lib/python3.6/locale.py", line 598, in setlocale     return _setlocale(category, locale) locale.Error: unsupported locale setting
If that is unsupprted what locales are supported then?

same problem

I also faced this issue . After many research i got the solution.
step 1:
open your kali terminal
type: locale -a
hit enter
step 2:
Now, to add a new locale edit the locales.gen - find en_US.UTF-8
type: cat /etc/locale.gen | grep en_US.UTF-8
hit enter
step 3:
Uncomment the en_US.UTF-8 UTF-8 string
type: sudo nano /etc/locale.gen
hit enter
and uncomment "en_US.UTF-8 UTF-8" by removing the "#" sign
press ctrl+o to save
press ctrl+x to exit
step 4:
run locales generator
type: sudo locale-gen
hit enter

thanks! very helpful

thanks @HackerTuhin !

@HackerTuhin legend.


Insert failed when inserted sql contains “code” cloumn

Which version of ShardingSphere did you use?
4.0.0-RC3-SNAPSHOT
Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
Expected behavior
insert successfully
Actual behavior
org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException:
Error updating database.  Cause: java.lang.IllegalStateException
The error may involve com.msxf.crm.workbench.dao.mapper.mdm.DemoMapper.insert-Inline
The error occurred while setting parameters
SQL: insert into w_demo (id,code,name,create_time, create_id, create_name,update_time, update_id, update_name,deleted)     values (?, ?, ?,       ?, ?, ?,       ?, ?, ?,       ?)

SQL like this is ok:

The insertValues is null：

Example codes for reproduce this issue (such as a github link).

We need add code to unreserved words list in g4 file, any body want to do this?


Enable BBE test automation

Description:
Currently this is done manually as testerina function mocking is not working.

Closing this, since fix is merged to 1.2.0 release branch.


Microsoft Dynamics 365 - Translation Service - Completed with Error

When creating a translation request based on a .xlf file, the translation service reports this as "Completed with errors" and shows no further information. When viewing the output, it shows: File could not be translated. Open a new request. This request completed with the error(s).
The request ids are 85924, 85925, 85926, 85927
Thanks for any advice.

@BSSI-Vinay, thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 community page to get help with your questions from the Dynamics community.


SQ 5 Not Connecting

SQ5 will not connect after 3.0 update. Looping Error Write ECONRESET when trying to connect.

What version of the module?


get_ssm_by_region dies if specified region has no mutations

I haven't fully debugged this, but I've been trying to retrieve variants for a small aSHM region. It works for genomes, but not capture:
regions <- GAMBLR:::process_regions(only_regions = "BCL6")

dim(get_ssm_by_region(
    region =regions$regions[2],
    seq_type = "genome"
))
# [1] 239  45

get_ssm_by_region(
    region =regions$regions[1],
    seq_type = "capture"
) %>% dim()

# [1] 543  45

get_ssm_by_region(
    region =regions$regions[2],
    seq_type = "capture"
)

# Error in methods::as(data[[i]], colClasses[i]) :
#   no method or default for coercing “character” to “l”

I believe the capture maf file doesn't have any rows matching the region described by regions$regions[2] so vroom is choking on the specified column types. Can you please investigate? Ideally this would be robust to even small regions where one might find no mutations.

@HoumanLM Could your new indexing approach using the RSamtools package help us resolve this?

@rdmorin For the tabix part that we have discussed earlier, I used Rsamtools for having a function similar to 'get_ssm_by_region' so it seems that it can solve the issue.


Lazily materialize the null buffer builder of boolean builder

Signed-off-by: remzi<EMAIL_ADDRESS>Which issue does this PR close?

Closes #2058 .
Rationale for this change
Improve the performance when there is no null in the array.
Benchmark result
Tested on M1 Pro Mac
bench_bool/bench_bool   time:   [664.02 us 683.00 us 705.62 us]
                        thrpt:  [708.60 MiB/s 732.06 MiB/s 752.99 MiB/s]
                 change:
                        time:   [-66.725% -66.281% -65.716%] (p = 0.00 < 0.05)
                        thrpt:  [+191.68% +196.57% +200.52%]
                        Performance has improved.
Found 20 outliers among 100 measurements (20.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  16 (16.00%) high severe

What changes are included in this PR?
Lazily materialize the null buffer builder, just as what we have done in the primitive builder.
Are there any user-facing changes?
No.

Codecov Report

Merging #2073 (4f06db3) into master (86543a4) will increase coverage by 0.00%.
The diff coverage is 93.61%.

@@           Coverage Diff           @@
##           master    #2073   +/-   ##
=======================================
  Coverage   83.61%   83.62%
=======================================
  Files         223      223
  Lines       58539    58559   +20
=======================================
+ Hits        48947    48969   +22
+ Misses       9592     9590    -2

Impacted Files
Coverage Δ

arrow/src/array/builder/primitive_builder.rs
92.57% <ø> (-0.55%)
:arrow_down:

arrow/src/array/builder/boolean_builder.rs
87.25% <93.61%> (+11.49%)
:arrow_up:

...row/src/array/builder/string_dictionary_builder.rs
90.64% <0.00%> (-0.72%)
:arrow_down:

parquet/src/encodings/encoding.rs
93.43% <0.00%> (-0.20%)
:arrow_down:

arrow/src/datatypes/datatype.rs
64.41% <0.00%> (+0.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86543a4...4f06db3. Read the comment docs.

Thank you @tustvold  for your review!


Patch libtiff for CVE-2023-52356 (#8298)

Co-authored-by: xiaohongdeng<EMAIL_ADDRESS>(cherry picked from commit c477bcd9d0c3e4055f35f4552b96434b3b6eacbb)
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[x] Ready to merge

Summary
Patch for CVE-2023-52356.
Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-52356

Test Methodology
Buddy build change only

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=600097&view=results
linking buddy build


Fix error when using multiple allowRoutes namespaces in gateway

Fixes: #30085
Fix error when using multiple allowRoutes namespaces in gateway

/test

Mentioned this in the parent issue, but also commenting here.
Confirmed this fix works!  Tested by deploying the 1.15.0-rc0 helm chart and using the container image generated in the PR workflow ((https://github.com/cilium/cilium/actions/runs/7407854202/job/20154860573?pr=30100).
values
operator:
  image:
   override: "quay.io/cilium/operator-generic-ci:bd0f507f2d5f3912c512f2fe728e0b19c974b88d"

/test

/test

/ci-ipsec-upgrade

/ci-e2e

/cc @sayboras Please take a look.

Thanks for the ping. I was not aware of this PR, and was working on the fix for the same issue.

/test

/ci-ipsec-upgrade

/ci-clustermesh

/ci-e2e


PARQUET-682: Add a writer + reader example with detailed comments

Added a reader writer example.

Covered all the physical types supported by Parquet.
Did not include clang format for the example for sake of readability

Added WriteAllValues API for convenience.

+1 -- will merge on green build


Tip: Things to check if you get an npm run lint error or build error

I am opening this issue as I also caught up in the npm run lint error issues.
After a few hours research on github issues and googling, I found the current checklist to resolve this issue.
(Note: this applies to both react-slingshot and react-redux course git repo)

[ ] First Make Sure .eslintrc is in your project root folder.
The current ESW have some weird behavior in terms of reading .eslintrc. Even your .eslintrc is not in your root folder, for example, I accidentally put mine in the /tools folder, some of the setting will still be activated like parserOptions but none of the rules are valid.
Putting the .eslintrc in the wrong folder would lead to Parsing error: The keyword 'import' is reserved

And it is not related to the setting of your .eslintrc but whether it is in your root folder or not.
If you didn't put

"sourceType": "module",     "ecmaFeatures": {       "jsx": true,       "modules": true     }

Missing modules setting would lead to Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
[ ] Second change the npm run lint script to "esw webpack.config.* src tools; exit 0" and change the npm run lint:watch script to "esw webpack.config.* src tools --watch; exit 0"
If ESW found any error or warning in your project like console statement or missing semi, the lint thread will be exit with Exit status 1.
This will lead to an ELIFECYCLE error.
This is actually not an error but a warning of ESW to indicate that it will print out all the warning and error. Adding exit 0 will not break the eslint checking but allow npm script to ignore the status 1 and allow ESW to print all all the warning and error.
[ ] Third check eslint/esw global install version and the local version to match.
This is not an issue I encounter but, make sure the global install is not outdate or out-sync with local project will help you resolve the 'esw' keyword. And this means we could use esw to replace the /node_modules/.bin/esw.

These are all the issues I found regarding debugging npm run lint issues. I hope this helps a lot current unresolved opened issues. Including some closed issues with is not correctly resolved.
This include:
https://github.com/coryhouse/react-slingshot/issues/133
https://github.com/coryhouse/react-slingshot/issues/84
https://github.com/coryhouse/react-slingshot/issues/150
Note: I did not reproduce the issue above, some my solution could be not working with the above issues but I think this is a pretty solid solution to the current version of eslint/esw/npm script.
Credit to:
modules solution
exit 0 solution

@SenLi325 Wow, great stuff. Thanks for pulling all this together! This is really comprehensive and helpful! 👍

Update on First check list.
[http://eslint.org/docs/user-guide/configuring#configuration-cascading-and-hierarchy](Configuration Cascading and Hierarchy)
The eslint use cascading and hierarchy to achieve different eslint config for each folder. So make sure you have a .eslintrc in the root folder with the correct setting and adding more in the sub-folder if your need more in-deep config.

This is probably obvious to everyone except me, but it took me a bit to figure out that step 2 occurs in the package.json. That fixed my issue, so thanks!

I've had this issue for weeks. Now fixed (on the react-redux pluralight course)
It was the path issues with eslint watch. I made sure i  installed eslint watch 2.1.14 both globally and locally

Is anyone still having issues here or are we OK to close this? Also thanks again to @Evilcat325 for pulling this together.

I'm fine with closing, but would suggest copying any info here to here: https://github.com/coryhouse/react-slingshot#having-issues-try-these-things-first

@Evilcat325, would you be willing to throw up a PR to update the docs section https://github.com/coryhouse/react-slingshot/blob/master/README.md#having-issues-try-these-things-first ?

Added help wanted label for someone to transfer this to documentation. This would also be a good-first-pr, but we didn't have a label for that.

@coryhouse, can you create a good first PR label? I don't think we have access to create labels.

Ah! Great idea. Done. 👍

Eager to get my first PR in :smiley:.
Is this info still valid, since we are no longer using a .eslintrc file (#405)

Great to hear @romarioraffington! Correct, you can ignore the .eslintrc tip since that's in package.json now.

How does this look @coryhouse ?

Tip: Things to check if you get an npm run lint error or build error:

If sourceType": "module", "ecmaFeatures": { "jsx": true, "modules": true } is missing from the eslint rules then the following error will be thrown: Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

If ESW found an error or warning in your project (e.g console statement or a missing semi-colon), the lint thread will exit with Exit status 1. To fix:

Change the npm run lint script to "esw webpack.config.* src tools; exit 0"
Change the npm run lint:watch script to "esw webpack.config.* src tools --watch; exit 0"

Note: Adding exit 0 will allow the npm scripts to ignore the status 1 and allow ESW to print all warnings and erros.

Ensure the eslint/esw globally installed version matches the version used in the project. This will ensure the esw keyword is resolved.

Hi @romarioraffington - Thanks! I corrected a minor typo by editing your comment. Let's omit the first bullet since that code is already included in the project. but otherwise looks great. Thanks!

Closing since @romarioraffington added! 👍

This lint thing does not work for me on Windows... Even if I applied all the suggestions. I just ignore it for the time being...  In general this is why it is difficult for me to start with all these tools: versioning nightmare + completely unreadable error messages...  Traceback (most recent call last):
2023-12-29T22:36:51.0583160Z npm ERR!   File "/Users/runner/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py", line 42, in
2023-12-29T22:36:51.0584660Z npm ERR!     import gyp  # noqa: E402
2023-12-29T22:36:51.0585240Z npm ERR!     ^^^^^^^^^^
2023-12-29T22:36:51.0586950Z npm ERR!   File "/Users/runner/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/init.py", line 9, in
2023-12-29T22:36:51.0588470Z npm ERR!     import gyp.input
2023-12-29T22:36:51.0590190Z npm ERR!   File "/Users/runner/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 19, in
2023-12-29T22:36:51.0591870Z npm ERR!     from distutils.version import StrictVersion
2023-12-29T22:36:51.0592830Z npm ERR! ModuleNotFoundError: No module named 'distutils'
2023-12-29T22:36:51.0594180Z npm ERR! gyp ERR! configure error
2023-12-29T22:36:51.0594960Z npm ERR! gyp ERR! stack Error: gyp failed with exit code: 1
2023-12-29T22:36:51.0597100Z npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/Users/runner/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:284:16)
2023-12-29T22:36:51.0600060Z npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
2023-12-29T22:36:51.0601530Z npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
2023-12-29T22:36:51.0602690Z npm ERR! gyp ERR! System Darwin 21.6.0
2023-12-29T22:36:51.0605080Z npm ERR! gyp ERR! command "/Users/runner/hostedtoolcache/node/16.20.2/x64/bin/node" "/Users/runner/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
2023-12-29T22:36:51.0608100Z npm ERR! gyp ERR! cwd /Users/runner/work/homebridge-inkbird-wifi-gateway/homebridge-inkbird-wifi-gateway/node_modules/@abandonware/noble
2023-12-29T22:36:51.0610350Z npm ERR! gyp ERR! node -v v16.20.2
2023-12-29T22:36:51.0611190Z npm ERR! gyp ERR! node-gyp -v v9.1.0
2023-12-29T22:36:51.0611760Z npm ERR! gyp ERR! not ok
2023-12-29T22:36:51.0612110Z
2023-12-29T22:36:51.0612510Z npm ERR!      /Users/runner/.npm/_logs/2023-12-29T22_36_36_654Z-debug-0.log
2023-12-29T22:36:51.0650830Z ##[error]Process completed with exit code 1.


Add default CommitID for create pull review api

If user create pull review through api but not set CommitID,I think it's necessary to use last headCommitID as default seting, or this review will be considered as stale review which is wrong

@zeripath the review api is added in #11224 which is not in v1.11. So it's not need to backport ... :)

I would move this into pull_service.CreateCodeComment ...

I would move this into pull_service.CreateCodeComment ...

I have thought about this, I didn't add it into CreateReview is because ui's Commit ID is auto added, So CommitID  won't have chance  to be empty. so add to api is enough, then user can
use api more simple.
ref:
https://github.com/go-gitea/gitea/blob/866ce126ecce2f28f4fc25648cf4bd74679c00cc/templates/repo/diff/new_review.tmpl#L9-L11

Maybe need skip-changelog label :)

Codecov Report

Merging #11334 into master will increase coverage by 0.01%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master   #11334      +/-   ##
==========================================
+ Coverage   43.82%   43.84%   +0.01%
==========================================
  Files         613      613
  Lines       87207    87221      +14
==========================================
+ Hits        38217    38238      +21
+ Misses      44277    44271       -6
+ Partials     4713     4712       -1

Impacted Files
Coverage Δ

routers/api/v1/repo/pull_review.go
64.55% <42.85%> (-0.71%)
:arrow_down:

modules/log/event.go
64.61% <0.00%> (-1.03%)
:arrow_down:

services/mirror/mirror.go
19.40% <0.00%> (+0.65%)
:arrow_up:

modules/git/repo.go
52.30% <0.00%> (+1.25%)
:arrow_up:

services/pull/pull.go
34.54% <0.00%> (+1.33%)
:arrow_up:

models/repo_mirror.go
12.76% <0.00%> (+10.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58bc4b...2ec6081. Read the comment docs.


Bug: A spiral with 1 turn has an estimated DCR of 0 ohms

It looks like there is something wrong with the estimated DC resistance of spirals, as if I se the num_turns to 0, it always estimated 0 ohms.

Closed by PR #11


Subtitle fontSize in Header not working

Seems like the fontSize set in native-base-theme/components/Header.js isn't being passed down to the Subtitle component in Headers. I also tried ejecting the Theme files again.
React-Native v0.44
Native-Base v2.1.3

Seems like the whole subtitle style is not working in my case,
same issue as #675
    "native-base": "2.1.3",
    "react": "16.0.0-alpha.6",
    "react-native": "0.43.4",

@fhad-getmaple
 <Header hasSubtitle>
    <Left>
                    <Button transparent>
                        <Icon name='arrow-back' />
                    </Button>
                </Left>
                <Body>
                    <Title>Title</Title>
                    <Subtitle style={{fontSize: 20, color: 'red'}}>Subtitle</Subtitle>
                </Body>
                <Right />
            </Header>

try the above code will work for you.

Hi @GeekRishabh,
Thanks for the work around. Do you have any word if the bug itself will be fixed in an update?
Thanks.

package.json
    "native-base": "^2.1.4",
    "react": "16.0.0-alpha.6",
    "react-native": "^0.44.0",

This works fine, with default components, without inline style

Subtitle doesn't seem to work. Here is my package.json
"react": "16.2.0",
"react-native": "0.52.2",
"native-base": "^2.3.7"

I see a definition for Title, but not for Subtitle (t with a lower case). But I see SubTitle, but if I use that I get the following error.
Invariant Violation: Element type is invalid: expected a string (for built-in components) or a
class/function (for composite components) but got: undefined. You likely forgot to export your
component from the file it's defined in, or you might have mixed up default and named imports.

Here is what I see in the definition -

I'm using it exactly the way it says in the example in the docs. Something like this -
<Container>
  <Header>
    <Left>
      <Button transparent>
        <Icon name='arrow-back' />
      </Button>
    </Left>
    <Body>
      <Title>Title</Title>
      <Subtitle>Subtitle</Subtitle>
    </Body>
    <Right />
  </Header>
</Container>

@aswinramakrish are you still facing this issue. Checked this. It is working fine (with 2.3.10). Attaching a gif
Gif

Ok. Found the issue. The default color of Subtitle is #ffffff and guess what my header background was? 😂


Test sbt 1.3.0-RCx using Play and Lagom

[x] playframework/twirl - https://github.com/playframework/twirl/pull/247
[ ] playframework/interplay
[ ] playframework/playframework
[ ] playframework/play-samples - https://github.com/playframework/play-samples/pull/43
[ ] lagom/lagom
[ ] lagom/lagom-samples - https://github.com/lagom/lagom-samples/pull/82

Twirl looks ok.
lagom-samples failed on Travis CI - https://travis-ci.org/eed3si9n/lagom-samples/builds/562204766, some with "Conflicting dependencies". I've opened https://github.com/coursier/coursier/issues/1284

Opened https://github.com/sbt/zinc/issues/690 based on Community Builds failing on Play, but apparently it existed also on sbt 1.2.8.

Here's Interplay - https://github.com/playframework/interplay/pull/85

Play 2.7 branch - https://github.com/playframework/playframework/pull/9417
Play master branch - https://github.com/playframework/playframework/pull/9521

Play's 2.7 branch looks mostly ok.


bump containernetworking/cni to v0.8.1

This PR bumps containernetworking/cni to v0.8.1

/release-note-none

/lgtm
/approve

/override continuous-integration/travis-ci/pr
Travis is used exclusively for release builds.


Failed to create a tag starting with -- in Azure portal with CLI commands

Related command

az group create --location eastus --name tagtest --tags "--key=value"
az group create --location eastus --name tagtest --tags "--key"="value"

Describe the bug

Failed to create a tag starting with "--". Such as "--key:value".
But in Azure portal, tag name starting with "--" can be created successfully.

To Reproduce

Create a tag in Azure Portal with CLI commands. For example, a resource group with a tag "--key:value".

Expected behavior

A tag starting with "--" can be created successfully using CLI commands.

Environment summary

azure-cli                         2.39.0

@zhoxing-ms for awareness

This should work: az group create --location eastus --name tagtest --tags="--key=value"
Ref: https://docs.microsoft.com/en-us/cli/azure/use-cli-effectively?tabs=bash%2Cbash2#use-hyphen-characters-in-parameters

az tag create command is returning Authorization failed Error:
I am running below given azure cli command in azure pipelines tasks, azure cli version is 2.39.0

az tag create --resource-id /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxdd43/resourceGroups/AZ-xx-ixxxxxxxxxxx-xxxxxx-xx-xx/providers/Microsoft.Databricks/workspaces/xxxxxxxxdatabricks --tags version=1.240.16

@vivek602  I can't reproduce it. This is another issue, please create a new issue with the detailed error message.

Hello,
Is it possible to tag all Azure resources based on the resource name for eg. resource name starts with Dev_* show be tagged as Env=Dev using AZ CLI?


zeroGyroscope needs to resetPose as well

When we zeroGyro in the drive we should also zero the simRotation, additionally we need to call resetPose(getPose()) in order for the simulated pose (and real pose ) estimate to be correct.

Will work on next meeting

Fixed by #92