fix: upgrade isort pre-commit hook to work with newer Python versions

Hi again,
Sorry, I'm trying to be a good open-source citizen, but pre-commit is having trouble installing the isort hook in my machine at least. Apparently, the version currently being by pre-commit (v5.10.1) no longer builds?
I'm on Debian 12 (Bookworm)
Funnily enough, the issue seems to go away after you simply update the version of the isort pre-commit hook to the latest one (5.12.0)
$ git ci --amend
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/cristian/.cache/pre-commit/repo4tjo_ue1/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
Processing /home/cristian/.cache/pre-commit/repo4tjo_ue1
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
error: subprocess-exited-with-error
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [17 lines of output]
      Traceback (most recent call last):
        File "/home/cristian/.cache/pre-commit/repo4tjo_ue1/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/cristian/.cache/pre-commit/repo4tjo_ue1/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/cristian/.cache/pre-commit/repo4tjo_ue1/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-9ybw1zef/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-9ybw1zef/overlay/lib/python3.11/site-packages/poetry/core/factory.py", line 58, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.

Thank you,
I did not notice that we were working with outdated version of isort and flake8 hook.
I'll merge this one as is and will upgrade the other hooks version before releasing the package.


Convert boolean environment variables to native booleans

Describe the problem
If you have env variables like PUBLIC_DEBUG or feature flags like PUBLIC_FEATURE_XY which are true or false, it would be handy to automatically cast them from string to booleans.
This ways you can use them very easily like
<MyComponent show={PUBLIC_DEBUG} />

instead of writing
<MyComponent show={PUBLIC_DEBUG === 'true'} />

or even
<MyComponent show={PUBLIC_DEBUG.toLowerCase() === 'true'} />

Describe the proposed solution
Add a new env configuration to svelte.config.js
convertBoolean?: boolean;

or castBoolean or something similar.
Alternatives considered
as described above
Importance
nice to have
Additional Information
No response

This feels unwise to me. How do we deal with env vars that are missing? How do we deal with env vars that are set to a value other than true or false? How do we know which ones ought to be booleans? What happens if someone wants to set an env var to the string true or false without it being interpreted as a boolean? What happens to the TypeScript types?
This all feels like something that should happen in userland with a wrapper module that does precisely what you need for that given application.

How do we deal with env vars that are missing?

The same as you do now.

How do we deal with env vars that are set to a value other than true or false?

They will be processed as you do right now - as string.

How do we know which ones ought to be booleans?

"true" | "false"

What happens if someone wants to set an env var to the string true or false without it being interpreted as a boolean?

then he won't set the new configuration key at all - just the default behavior.

What happens to the TypeScript types?

Nothing. Those env vars are boolean, the others are string.

What happens to the TypeScript types?

If you set an env var to true or false, don't you expect it to be a native boolean? I mean by default every env var is a string, sure, but what you really want is a boolean, right? So with this proposal you can opt-in for that behavior, but you don't have to.

I personally would do <MyComponent show={PUBLIC_DEBUG} /> even with it a string. Because people represent booleans in different ways with env vars. E.g. PUBLIC_DEBUG="true", PUBLIC_DEBUG="1", PUBLIC_DEBUG="". I think this is probably best kept as a userland problem with something like
function is_bool(variable: string) {
	return variable == 'true';
}

Although I still think you're better off letting javascript evaluate it as truthy. You could even do !!PUBLIC_DEBUG in your code.

Because people represent booleans in different ways with env vars. E.g. PUBLIC_DEBUG="true", PUBLIC_DEBUG="1", PUBLIC_DEBUG="".

Yea, that's a good point and as you mentioned, you can catch/convert it easily with !!, which isn't really verbose.
So that's definitely a viable way.
Although I'm still thinking about offering a way to optimize the env loading. At the end of the day a framework should ease your life and I think bool values (switches) are very common.

Given all the possible ways this could go wrong (different formats for true/false, omitting variable == suddenly String again) I'm also against adding something like this. It might be convenient for some cases but there's too much nuance to explain in the docs about how it behaves, at which point it's better to solve this in user land - therefore closing.


Added USER_TWEETS fetching

Let me know if the method should be called 'tweets' or 'timeline'
Closes #367
Closes #368

I think it makes sense to use 'timeline' here, instead of 'tweets', since this library is user-facing and serves as an abstraction over rettiwt-core.

Updated, tested

Okay I'll be merging it in the evening. I'm afk now :(

@omarcinkonis There is an issue with fetching the timeline when a cursor is provided. The same data is returned over and over again when using a cursor. I'm looking into it right now.


make volumes rw to prevent starting issue with not writeable volumes

Thanks for the PR, @org-tekeli-borisp!
Just curious, is there a specific operating system setup you were having issues with? I haven't had this issue come up on Mac or Ubuntu.

I'm on manjaro linux with zfs filesystem.
Today I'm not able to reproduce the issue again. Kafka starts and is runnnig. Strange...
directory_permissions.log
docker_ps.log
zk-multiple-kafka-multiple.log
Sorry for your time and thanks for great lectures!


Updated !referrals command

Now it's say that you can have 10 referrals  instead of one :)

Thank you!
Any chances you could rebase to remove the conflicts?


Singular data tests can now be documented

Resolves https://github.com/dbt-labs/docs.getdbt.com/issues/6132
Originally https://github.com/dbt-labs/docs.getdbt.com/pull/6147
What are you changing in this pull request and why?
The description property is available for singular data tests beginning in dbt v1.9, and this PR highlights how singular tests can now be documented.
🎩 Previews

description
docs-paths
documentation placement

Additional information
Opened https://github.com/dbt-labs/docs.getdbt.com/issues/6193 since we don't have documentation how to add a description for the Jinja macro associated with custom generic tests. This follow-up will allow us to consider the description of both generic and singular data tests in context of each other.
Checklist

[x] I have reviewed the Content style guide so my content adheres to these guidelines.
[x] The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
[x] Wait until https://github.com/dbt-labs/dbt-core/pull/10792 is merged
[x] Add a note to the prerelease version Migration Guide

@dbeatty10 @mirnawong1 I'm realizing this doesn't have a release note - do we want one?

good point and have created a release note PR here: https://github.com/dbt-labs/docs.getdbt.com/pull/6227


Proposal for improved Table Element

In some recent discussions I mentioned that Table was not designed to hold large tables (>10k cells) as its based on NdMapping, which is really designed to hold individual elements. Any real data manipulation on a Table Element can become very slow. Since Table elements are the common interchange format when performing many operations, e.g. sample, reduce, this can happen pretty quickly.
My suggestion is as follows, much like we have different plotting backends we could have different data backends. The implementation of DFrame already provides most of the functionality that Table provides but allows for much faster operations and conversions. Instead of having two separate classes the user should be able to decide which implementation of Table HoloViews should use internally, e.g. inbuilt, pandas or xray. As long as the different Table implementations share the same public API this would be a clean and very easy (the current DFrame could be made to match the Table API fairly easily) way of getting a more performant Table implementation.
I'd also consider deprecating the dframe method since you could get a pandas based Table object by calling .table(backend='pandas') or switching the global data backend to 'pandas'.
I'm not 100% decided on implementation details but I guess we'd just have multiple classes called Table for each data backend. I'd be very happy to hear other suggestions though.

That all sounds good to me, and very important to do.
BTW, recently I've been using blaze to read files in, but then converting them to Pandas dataframes and then to Numpy arrays:
http://continuumio.github.io/datashader/gdelt.html
http://continuumio.github.io/datashader/nyc-taxi.html
It would be better to leave them directly as Blaze objects or at least Pandas objects, if that would work properly, because then people could have low-cost visualization of what they are working with, without having to move everything into HoloViews objects that duplicate the memory usage.
If there's a better way to do this already, let me know!  E.g. I wasn't sure how to use Pandas without Seaborn, as the examples I saw all involved Seaborn, so I just converted it to Numpy arrays instead.

Here's the source code for those notebooks, which can be linked in from the Examples section of the HoloViews web site:
http://continuumio.github.io/datashader/gdelt.ipynb
http://continuumio.github.io/datashader/nyc-taxi.ipynb

This was implemented as part of the Data API PR, closing.


New version: Mill v1.2.0

Registering package: Mill
Repository: https://github.com/pevnak/Mill.jl
Created by: @racinmat
Version: v1.2.0
Commit: d725d6de7c74fdce8973647590902eeed3e3f8da
Reviewed by: @racinmat
Reference: https://github.com/pevnak/Mill.jl/commit/d725d6de7c74fdce8973647590902eeed3e3f8da#commitcomment-39013239

wait


openresty: <IP_ADDRESS> -> <IP_ADDRESS>

https://openresty.org/en/changelog-1019009.html
Brings support for the rejectSSL option.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@ofborg test nginx-variants.openresty


ANNPLT-129:  Drop the hibernate3-maven-plugin in favor of providing d…

…irect support for database schema drop+create
https://issues.jasig.org/browse/ANNPLT-129
The Announcements portlet implements a 'db-init' Maven goal that drops & re-creates the database schema.  This capability is integrated into the uP4 Maven build via uportal-portlets-overlay.
The current implementation is based on the hibernate3-maven-plugin.  This solution is problematic because (1) it's not well integrated into the rest of the app's features (so it's always been very brittle), and (2) it doesn't port well to the Gradle-based build in uP5.
We need to  replace it with something we provide directly that is a first-class part of the Spring app.

Why does db init need to be integrated with the application features? it's a one off script build script.

One of the major themes of uPortal 5 is Reducing the Learning Curve.  Everything has to be easy.  It needs to be possible for someone who knows almost nothing about databases and SQL to get a local dev environment set up properly.
In Announcements (as elsewhere) we're using Hibernate, but we're using Spring-managed Hibernate.  The Hibernate configuration and the Spring ApplicationContext are blended.  The only way we can launch a Hibernate process that will use the same configs as the running app itself is to bootstrap the Spring ApplicationContext along with it.
A decent example of where this blending matters is encrypted properties.  Probably the most common thing to encrypt is the database password.  Spring is responsible for decrypting these properties, so Hibernate must get it's connection information through Spring.  Another example is with property overrides;  it's the Spring PropertyPlaceholderConfigurer that handles the overrides.
Reading the changes it looks like a standard plugin is being replaced with custom code.

We were using the hibernate3-maven-plugin.  It's not spectacular, but we can make it work in Maven.  We can't use it directly in Gradle.  We have limited options to choose from because the version of Hibernate we're using -- 3.6.10 -- is pretty out of date.  It is the most recent version of Hibernate3, but Hibernate3 hasn't had a release since FEB 2012.
But this solution is actually based on a standard:  Hibernate Tools.  This solution doesn't include custom code to figure out what the schema should be and to create it;  it relies on a Hibernate-provided tool for that.  That tool is called hbm2ddl.  The hibernate3-maven-plugin is just a thin wrapper around it, and so is this solution.

So because we added encrypted properties to the Sprint Context.
Abstractions in uPortal that could otherwise be independent of the ApplicationContext are now tightly coupled with the ApplicationContext and impossible to unit test without the full ApplicationContext?
Should we rethink how encrypted properties are handled?

Hibernate3 hasn't had a release since FEB 2012

We should move to the latest stable hibernate version.

But this solution is actually based on a standard: Hibernate Tools.

👍 for using Hibernate tools.

So because we added encrypted properties to the Sprint Context.
Abstractions in uPortal that could otherwise be independent of the
ApplicationContext are now tightly coupled with the ApplicationContext
and impossible to unit test without the full ApplicationContext?

Any approach we might select for encrypted properties would have an impact on how we would need to run something like hbm2ddl.  And it's not just encrypted properties (though it's a good example);  property overrides and Spring features like @Transactional create en environment where it's not sensible to run Hibernate w/o Spring in the mix.
This tactic -- running the hbm2ddl tool from within the fully-booted app -- at least saves us from dealing with these details individually.  The Hibernate task is pulling configs exactly the same way the running app does, so it automatically benefits from all the features we use now and any features we may use in the future.
We should move to the latest stable hibernate version.

Well, yes;  but that's sort of the "tip of the iceberg."  We need an opportunity to work on a "next gen" Announcements module.  It can be an evolution of this one -- I'm inclined to approach it that way -- but it's reasonably clear that a significant effort is needed.  I look forward to that opportunity.
In the mean time, we have folks trying to implement uP5 this month.  It's tactically important to give them an integrated Announcements module that works at least as well as uP 4.3.


Translate kube architecture section to Indonesian

This PR addresses #13854

[x] master-node-communication
[x] nodes

/assign @irvifa

@irfiva this is ready now

Overall this is already good, however I think we should discuss several keywords translations for this..

/lgtm
/approve

/assign @girikuncoro

/approve /lgtm

RElated to #13929


[CoreInternal] Add explicit generics typing for Array.Index usage (2)

Context
Follow-up to #10075. Older Swift versions (< 5.3) do not like referencing the
Array type without specifying the generic type for the array. This can result
in a buildtime error when building with a Swift version under 5.3.
Prevents #10171

Please add a pod lib lint CI test that sets the swift-format to 5.3 or 5.0 or 4.2, after verifying that it fails without your fix.

Ugh, I'm locally linting with the Swift version specifier and not reproducing the original build failure.

Hmm, I wonder if that behavior is related to compiler version and not Swift version?

Hmm, I wonder if that behavior is related to compiler version and not Swift version?

Agreed, I don't think I understand yet where the problem is.

OK to merge this today ahead of code freeze and work on testing later.

Thanks, will do 👍

@paulb777, this is good for another pass. Feel free to merge after approving!


How to install cargo subcommands with nix?

How to install for example cargo-graph with cargo? Is there a way to do this with the current cargo nix infrastructure?
Pinging cargo/rust maintainers @wizeman @madjar

Doesn't cargo pick them up automatically? It does for me, at least.

Adding ~/.cargo/bin: to your PATH might help.

So you mean I can cargo install them and when adding ~/.cargo/bin to my PATH everything should work?
Sounds nice, will try and report back.

Yes, exactly. It also works with packages installed via nix (like rustfmt, which comes with a cargo-fmt binary).

Works.

BTW, if you ever wanted to install a cargo subcommand for the Nix-built Cargo, it would be sufficient to install the package containing the subcommand -- as long as a subcommand cargo-foo is found anywhere on your $PATH, running cargo foo will work (source).

I'm experiencing this on 23.11 again
DRI driver not from this Mesa build ('23.1.9' vs '23.3.3')
failed to bind extensions
DRI driver not from this Mesa build ('23.1.9' vs '23.3.3')
failed to bind extensions
DRI driver not from this Mesa build ('23.1.9' vs '23.3.3')
failed to bind extensions
Failed to create GBM device for render device: /dev/dri/renderD128: Illegal seek
DRI driver not from this Mesa build ('23.1.9' vs '23.3.3')
failed to bind extensions
DRI driver not from this Mesa build ('23.1.9' vs '23.3.3')
failed to bind extensions
DRI driver not from this Mesa build ('23.1.9' vs '23.3.3')
failed to bind extensions
Failed to create GBM device for render device: /dev/dri/renderD128: No such file or directory
Failed to get GBM device

Info:
[⚠] Environment
    - OS: NixOS 23.11.0 X64
    ✔ webkit2gtk-4.0: 2.42.4
    ✔ rsvg2: 2.57.1
    ✔ rustc: 1.76.0 (07dca489a 2024-02-04)
    ✔ cargo: 1.76.0 (c84b36747 2024-01-18)
    ⚠ rustup: not installed!
      If you have rust installed some other way, we recommend uninstalling it
      then use rustup instead. Visit https://rustup.rs/
    ⚠ Rust toolchain: couldn't be detected!
      Maybe you don't have rustup installed? if so, Visit https://rustup.rs/
    - node: 18.18.2
    - pnpm: 8.10.2
    - yarn: 1.22.19
    - npm: 9.8.1

[-] Packages
    - tauri [RUST]: 1.6.0
    - tauri-build [RUST]: 1.5.1
    - wry [RUST]: 0.24.7
    - tao [RUST]: 0.16.7
    - tauri-cli [RUST]: 1.5.10
    - @tauri-apps/api [NPM]: 1.5.3
    - @tauri-apps/cli [NPM]: 1.5.10

[-] App
    - build-type: bundle
    - CSP: default-src 'self'; img-src * asset: https://asset.localhost; font-src *
    - distDir: ../dist
    - devPath: http://localhost:3333/
    - framework: Vue.js
    - bundler: Vite


Intellisense and tooltips stops working

Occasionally, Intellisense will die with the following error (from the Code debugger): -
shell.ts:541 Cannot read property 'Data' of null: TypeError: Cannot read property 'Data' of null
    at C:\Users\Isaac\.vscode\extensions\Ionide.Ionide-fsharp-2.13.2\Components\CodeLens.js:149:50
    at process._tickCallback (internal/process/next_tick.js:103:7)

No idea why it happens or how / when it starts working again.

In fact it's more than intellisense - codelens and hover-over tooltips stop working as well.

Yeah, error only tells us that we don't get anything reasonable from FSAC. I've noticed it too, but haven't found any way to reproduce the problem. I guess for some reason FCS crashes / hangs. But no idea why.

Can we put some more logging in - I don't know if FSAC gives any more details like a stack trace?

Hi,
I turned on the logging for Ionide via User Settings:
"FSharp.logLanguageServiceRequestsOutputWindowLevel": "DEBUG",
"FSharp.logLanguageServiceRequests": "both"

When I code with the output panel is open, the error does not occur. There's no red underline, and Ionide does not crash. As soon as I close the output panel, Ionide crashes again after the first error, after the red underline.
This is the output of the error, after I open the output again:
[00:04:59 INFO ] REQ (065) -> {tooltip}, File = "~/src/Any.fsx"
[00:04:59 ERROR] RES (065) <- {tooltip} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8910 Data=undefined
[00:05:06 INFO ] REQ (066) -> {parse}, File = "~/src/Any.fsx"
[00:05:06 INFO ] REQ (067) -> {lint}, File = "~/src/Any.fsx"
[00:05:06 ERROR] RES (066) <- {parse} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8910 Data=undefined
[00:05:06 ERROR] RES (067) <- {lint} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8910 Data=undefined

Here's some info from error output:
Error: Cannot read property 'Data' of null
    at C:\Users\Isaac\.vscode\extensions\Ionide.Ionide-fsharp-2.15.5\Components\CodeLens.js:149:50
    at process._tickCallback (internal/process/next_tick.js:103:7)

Can confirm the problem on macos 10.12.2. It seems the ECONNREFUSED is the culprit here?
ionide.txt

For information: I'm using OS X Yosemite 10.10.5, still with the error.

So thanks to some investigation by @lucasmreis  we know that it started to occur more after ionide/ionide-vscode-fsharp@8653153.
Probably error is somewhere in new FSAC's namespace resolver I've ported from VFPT.

Please check 2.19.4. If it's not working please provide me reproduction example and OS / mono info.
I can't fix it by random changing code in FSAC and hoping it will work

SOLVED! (at least for me 😄  )
Thanks a lot, one more time!
My settings:
▶ mono --version
Mono JIT compiler version 4.6.2 (mono-4.6.0-branch/ac9e222 Wed Dec 14 17:02:09 EST 2016)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           normal
        SIGSEGV:       altstack
        Notification:  kqueue
        Architecture:  x86
        Disabled:      none
        Misc:          softdebug
        LLVM:          yes(3.6.0svn-mono-master/8b1520c)
        GC:            sgen

On a OS X Yosemite 10.10.5.

Confirmed, I also noticed in the last few days that it's not happening any more.
It sometimes takes time on startup to "parse" everything so that intellisense works, but it catches up eventually.

It sometimes takes time on startup to "parse" everything so that intellisense works, but it catches up eventually

I guess that's something to do with our startup strategy (parsing all projects in workspace). Not really sure how we can fix it shrug

Really wasn't complaining - just an observation. VS seems a little faster than Ionide here, that's all.

@Krzysztof-Cieslak OK.

I am still getting this error fairly regularly and will cause intellisense, codelens and the tooltips to stop working.  Sometimes it starts working again and other times I have to restart vscode to get it working again.  I have been using this gist to try and get a reliable method to reproduce my issue.

I open this file in vscode and scroll to the bottom of the file so that line 23 is the first line of code I see
Remove line 29 (stopwatch.stop())
Go to the bottom of the line and try to type something using intellisense, I have been trying to use List.map
At this point intellisense will just show "Loading..." or only show intellisense for the contents of the file and not the correct options for list.*
Scrolling up to the top of the file will show the blank lines where the code lens used to be, but they never load.

shell.ts:437 Cannot read property 'Data' of null: TypeError: Cannot read property 'Data' of null
at /Users/ben/.vscode/extensions/Ionide.Ionide-fsharp-2.22.2/Components/CodeLens.js:155:50
at process._tickCallback (internal/process/next_tick.js:103:7)
> mono --version
Mono JIT compiler version 4.6.2 (Stable <IP_ADDRESS>/ac9e222 Sat Jan  7 16:00:28 PST 2017)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:           normal
	SIGSEGV:       altstack
	Notification:  kqueue
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	LLVM:          supported, not enabled.
	GC:            seen

OS X El Capitan 10.11.6
VSCode 1.9.1
Iodide-FSharp 2.22.2

Can confirm on
macOs 10.12.3
VS Code 1.9.1
Ionide-Fsharp 2.22.1
Log

[Extension Host] rejected promise not handled within 1 second
Cannot read property 'Data' of null: TypeError: Cannot read property 'Data' of null
    at mapResult (/Users/stefan/.vscode/extensions/Ionide.Ionide-fsharp-2.22.1/Components/Errors.js:42:10)
    at /Users/stefan/.vscode/extensions/Ionide.Ionide-fsharp-2.22.1/Components/Errors.js:123:36
    at process._tickCallback (internal/process/next_tick.js:103:7)
'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M54, around October 2016. See https://www.chromestatus.com/features/5316065118650368 for more details.
Cannot read property 'Data' of null: TypeError: Cannot read property 'Data' of null
    at /Users/stefan/.vscode/extensions/Ionide.Ionide-fsharp-2.22.1/Components/ResolveNamespaces.js:30:37
    at process._tickCallback (internal/process/next_tick.js:103:7)
[Extension Host] [IONIDE-FSAC] RES (117) <- {namespaces} ERROR in 686 ms: Error: socket hang up Data=%O
socket hang up: Error: socket hang up
    at createHangUpError (_http_client.js:252:15)
    at Socket.socketOnEnd (_http_client.js:344:23)
    at emitNone (events.js:91:20)
    at Socket.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
[Extension Host] [IONIDE-FSAC] RES (119) <- {declarations} ERROR in 463 ms: Error: socket hang up Data=%O
[Extension Host] [IONIDE-FSAC] RES (115) <- {namespaces} ERROR in 962 ms: Error: socket hang up Data=%O
[Extension Host] [IONIDE-FSAC] RES (081) <- {declarations} ERROR in 3996 ms: Error: socket hang up Data=%O
[Extension Host] [IONIDE-FSAC] RES (104) <- {namespaces} ERROR in 1920 ms: Error: socket hang up Data=%O
[Extension Host] [IONIDE-FSAC] RES (122) <- {tooltip} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
connect ECONNREFUSED <IP_ADDRESS>:8941: Error: connect ECONNREFUSED <IP_ADDRESS>:8941
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1081:14)
[Extension Host] [IONIDE-FSAC] RES (123) <- {namespaces} ERROR in 3 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (124) <- {parse} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (125) <- {tooltip} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
[Extension Host] [IONIDE-FSAC] RES (126) <- {parse} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (127) <- {lint} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
connect ECONNREFUSED <IP_ADDRESS>:8941: Error: connect ECONNREFUSED <IP_ADDRESS>:8941
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1081:14)
[Extension Host] [IONIDE-FSAC] RES (128) <- {completion} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (129) <- {parse} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
[Extension Host] [IONIDE-FSAC] RES (130) <- {tooltip} ERROR in 5 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (131) <- {parse} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (132) <- {tooltip} ERROR in 5 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
connect ECONNREFUSED <IP_ADDRESS>:8941: Error: connect ECONNREFUSED <IP_ADDRESS>:8941
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1081:14)
[Extension Host] [IONIDE-FSAC] RES (133) <- {parse} ERROR in 2 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (134) <- {parse} ERROR in 3 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
[Extension Host] [IONIDE-FSAC] RES (135) <- {tooltip} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (136) <- {parse} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (137) <- {lint} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
connect ECONNREFUSED <IP_ADDRESS>:8941: Error: connect ECONNREFUSED <IP_ADDRESS>:8941
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1081:14)
[Extension Host] [IONIDE-FSAC] RES (138) <- {tooltip} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] [IONIDE-FSAC] RES (139) <- {tooltip} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
[Extension Host] rejected promise not handled within 1 second
[Extension Host] [IONIDE-FSAC] RES (140) <- {tooltip} ERROR in 1 ms: Error: connect ECONNREFUSED <IP_ADDRESS>:8941 Data=%O
connect ECONNREFUSED <IP_ADDRESS>:8941: Error: connect ECONNREFUSED <IP_ADDRESS>:8941
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1081:14)

Unfortunately  I'm having this issue too. Is there anything we can do to help?

Yeah, would like to help out too. At the moment is has become almost unusable in VS Code. For every F# stuff I do, I have to use Atom now because Ionide dies after like three keystrokes in Code.

That's interesting. I wonder why this doesn't have in Atom - perhaps the way that they're interacting with FSAC is somehow different?

Could be. It does work in atom but some important things (e.g. renaming) are not supported. That's why we really need to fix the vs code extension, but I really don't know where to start or how to help out.

We've just come across the problem in our team too
shell.ts:437 Cannot read property 'Data' of null: TypeError: Cannot read property 'Data' of null     at /Users/Jon/.vscode/extensions/Ionide.Ionide-fsharp-2.23.0/Core/Project.js:145:10     at /Users/Jon/.vscode/extensions/Ionide.Ionide-fsharp-2.23.0/fable_external/Helpers-1977695102.js:67:7     at process._tickCallback (internal/process/next_tick.js:103:7)

@isaacabraham everything in the atom tools are old, old fsac, old transpiler(funscript) no one works on it
Does anyone have a reliable reproduction for this issue? I've never encountered it myself so its hard to go about fixing it

@cloudRoutine @kc0isg has one that always triggers for me. But with the latest version it has gotten worse. ionide on vs code on macOS quits on the first red squiggly line that appears. Tried it on both my personal MacBook and the one I use for work. Both are always kept up to date.

Looks like it's the problem with resolve namespace endpoint on mono (which would explain why Atom doesn't have it - even tho I've updated FSAC some time ago in Atom plugin we just don't use this endpoint there).

Just released 2.23.1 with Resolve unopened namespaces and modules code fix optional and disabled by default.
Please check if it helps, and then if you can reproduce problem by turning it on and restarting Code.

@Krzysztof-Cieslak just updated. Now it dies immediately when I open a .fsx file. 😕
//Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:138 Cannot read property 'Data' of null: TypeError: Cannot read property 'Data' of null
    at /Users/stefan/.vscode/extensions/Ionide.Ionide-fsharp-2.23.1/Core/Project.js:145:10
    at /Users/stefan/.vscode/extensions/Ionide.Ionide-fsharp-2.23.1/fable_external/Helpers-1977695102.js:67:7
    at process._tickCallback (internal/process/next_tick.js:103:7)

Have fixed our error by uninstalling Xamarin mono
sudo rm -rf /Library/Frameworks/Mono.framework
sudo pkgutil --forget com.xamarin.mono-MDK.pkg
sudo rm -rf /etc/paths.d/mono-commands

and installing with Homebrew
brew install mono

Woohoo! The solution @JonCanning proposed works! At least for me 😅

Can you both check if turning on resolveNamespaces  breaks anything on homebrew version on mono?

@Krzysztof-Cieslak enabling it does not crash it. But in some files the code lens feature (the grey function signatures that appear above the functions) don't work. Can't discern a pattern there. In some files it works, in others it doesn't.

@Krzysztof-Cieslak Confirmed on Windows that it's still happening :-( Sorry.

@isaacabraham, can you provide me any reliable reproduction? :-(

@Krzysztof-Cieslak Maybe I was too hasty. It disappeared on a file but now seems to be back!

No, it's still there. Happy to do a screenshare with you if you'd like to dig around a bit? Skype me or similar.

After using it more the last day, the problem keeps reappearing on both my Macbooks 😕 I'll try to come up with a repro but it is quite hard. It seems to happen more often in .fsx files that reference external assemblies (#r) and other fsx files (#load), for me.

Definitely seems to last longer with the last releases, although still happens eventually. Here's the error I get if I ctrl + space on a symbol: -
[Extension Host] [IONIDE-FSAC] RES (1461) <- {completion} ERROR in 3 ms: {SyntaxError: Unexpected token u in JSON at position 0}, Data=%O

Can confirm what @isaacabraham said. Tried Ctrl + Space on different symbols and got:
[Extension Host] [IONIDE-FSAC] RES (002) <- {completion} ERROR in 114 ms: {SyntaxError: Unexpected token u in JSON at position 0}, Data=%O
//Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:133

[Extension Host] [IONIDE-FSAC] RES (003) <- {completion} ERROR in 5 ms: {SyntaxError: Unexpected token u in JSON at position 0}, Data=%O
//Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:133

[Extension Host] [IONIDE-FSAC] RES (020) <- {completion} ERROR in 33 ms: {SyntaxError: Unexpected token u in JSON at position 0}, Data=%O
//Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:133

[Extension Host] [IONIDE-FSAC] RES (056) <- {completion} ERROR in 4 ms: {SyntaxError: Unexpected token u in JSON at position 0}, Data=%O

Here's something else I'm seeing (only on recent release): -

Sorry, that was my bad, CodeLens bug should be fixed in 2.23.4
Also, I've added some additional "logging" - there will be F# Language Services (server) tab in output panel, please check if anything is printed out there when FSAC stops working for you.

@Krzysztof-Cieslak new Output tab is not showing for me

Can confirm. No Output tab.

Please set:
// FSharp configuration
// Set the verbosity for F# Language Service Output Channel
"FSharp.logLanguageServiceRequestsOutputWindowLevel": "DEBUG",

// Enable logging language service requests (FSAC)  to an output channel, the developer tools console, or both
"FSharp.logLanguageServiceRequests": "both"

For which cases is Ionide suposed to work? Only with projects created with Ionide? Or should something like Intellisense (not code highlightening) work even with non projects so simple *.fs files?

OK, new task for people for whom this is happening - next time when it stops working please try executing go to symbol in file command (Ctrl + Shift + O on windows)
Also, does error highlighting also stops working? Or is it fine, just tooltips and autocomplete is not working?

I was trying to make some world bank demos. I'll try to make a repro later if I can.
Error highlighting still worked if I used wrong name, while code lens and auto complete broken

I believe that the problem lies deeper than I've expected - in FCS. I've created issue over there with some additional logging - https://github.com/fsharp/FSharp.Compiler.Service/issues/716. If someone is able to use FCS and reproduce this bug, please help. Apparently I'm not good enough F# dev to build FCS on any of my machines.

FSLab Project
https://gist.github.com/anonymous/9673b4f881e3c2071bda3b9aa5300216
Hitting . on last line to bring up the list of items does nothing.
[20:31:01 ERROR] RES (261) <- {completion} ERROR in 10 ms: {"SyntaxError: Unexpected token u in JSON at position 0"}, Data=undefined
[20:31:02 INFO ] REQ (262) -> {tooltip}, File = "~\2. World Bank.fsx"
Data={"FileName":"c:\Users\diese\Source\Repos\FsLabTutorial\2. World Bank.fsx","Line":10,"Column":42,"Filter":""}
[20:31:02 DEBUG] RES (262) <- {tooltip} in 4 ms: Kind={"info"}
Data="Cannot find ident for tooltip"

@kellerd, your issue is same as https://github.com/ionide/ionide-vscode-fsharp/issues/147. I believe it's different than rest of cases described here

In case anyone is advantures and would want to debug this issue:

Build FCS in Debug,
Build Ionide/FsAutoComplete in Debug
Copy paste both into %USERPROFILE%\.vscode\extensions\Ionide.Ionide-fsharp.SOME_VERSION\bin
Start Code
Attach to FsAutoComplete.Suave.exe from VS
...
Profit

I fail at step 1. ;)

I'll try it tomorrow

I fail at step 2 :)

Hahaha I'm exited how it's going for me tomorrow :joy:

IDK how to compile FCS in debug correctly?

Cannot run build.cmd for ionide xD

https://github.com/ionide/FsAutoComplete <> ionide/ionide-vscode-fsharp.
You don't need build plugin.

THanks for information. I'm on it

Okay, I set everything up. I'm on it :smiley: !

I've been able to consistently reproduce this. If I add the mutable qualifier to a variable then the tool tips and CodeLens comes back until I save again, it's very consistent. However, getting it to trigger in the first place is still random.
For example, changing line 32 of this gist from let (Ordered1D (a1, a2)) = a in to let mutable (Ordered1D (a1, a2)) = a in

Thanks you for this information. I'll try to reproduce it too :)

Just for documentation purposes. That's what camed up after I changed the line to mutable but keep in mind it isn't what we searched for.
shell.ts:437 Systemfehler (ENOENT: no such file or directory, ... (short version)

Also I found stuff like that happening afterwards the bug occured.
shell.ts:437 Seq did not contain any matching elemenent
I also debugged the language service but it didn't showed up anything.

Can you check latest version? (2.25.0) I've included in it unofficial, fixed version of FCS... It fixes problem (for me)

I'll try it out @Krzysztof-Cieslak

@Krzysztof-Cieslak was just going to say today, I used it for a few hours on Sunday without any problems. Success! Thanks :-)

Can also confirm that VS Code F# is great again! Thanks Krysztof!

@Krzysztof-Cieslak I hate to spoil the party, but this is still not working for me...
I start VS Code and create a new file (tester.fsx) in a new directory. When I start typing on the first line of the file, I get autocompletion just fine. However, once I have put anything on the first line, such as namespace Tester or let a = 1, autocompletion no longer works on the next line. When I start typing something on that line (e.g. an S), I get the following error in the F# Language Service tab:
[19:12:07 INFO ] REQ (120) -> {completion}, File = "~/tester.fsx" Data={"FileName":"/Users/noklesta_adm/tmp/vscode/tester.fsx","SourceLine":"S","Line":3,"Column":2,"Filter":"Contains","IncludeKeywords":true} [19:12:07 ERROR] RES (120) <- {completion} ERROR in 5 ms: {"SyntaxError: Unexpected token u in JSON at position 0"}, Data=undefined [19:12:08 INFO ] REQ (121) -> {parseProjects}, File = "~/tester.fsx" Data={"FileName":"/Users/noklesta_adm/tmp/vscode/tester.fsx"} [19:12:08 DEBUG] RES (121) <- {parseProjects} in 9 ms: Kind={"errors"} Data={"File":"/Users/noklesta_adm/tmp/vscode/tester.fsx","Errors":[]}
So the problem seems to be this JSON-related error - does anybody have any idea what that means? I have disabled all extensions except Ionide-fsharp.
macOS Sierra
VS Code 1.10.2
Ionide-fsharp 2.25.2
(By the way, I'm just learning .NET and F#, so I apologize if I'm making some kind of stupid mistake here...)

I have uninstalled Xamarin Studio and VS for Mac preview (I was trying them both out) and installed mono through homebrew instead, as someone suggested above, and now it seems to be much more stable. Fingers crossed :)
Thanks a lot for this excellent plugin!

I have this under the debugger in VS when FSAC loses its mind, but....you know, the sucky thing about stackoverflow issues is that there's no more stack...

 Not sure what information I should provide, it seems to happen almost immediately after I start coding.

I'm faced up with issue too.
macOS 10.13.6
Mono 5.10.1
Dotnet Core 2.1.401
VS Code 1.26.1


Enhance GitHub Action Metadata and Branding

User description

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

[ ] Yes
[ ] No

Description

Updated the action's name and description for clarity.
Changed branding details to improve visual representation.
Author information has been updated.

Changes walkthrough 📝
Relevant filesEnhancement

action.ymlUpdate GitHub Action Metadata

action.yml
Updated action name to 'GitHub Badges Action'.  Enhanced description to specify functionality.  Changed author name to 'Guilherme Branco Stracini'.  Modified branding icon and color.

+5/-5

@gstraccini prettier


(Auto-)Update Docker Hub image

The Docker Hub image is still built with nginx:1.9.5, according to the Dockerfile. The badge in the README says nginx:1.9.2. Can you please update both (or you may want to delete the badge)?
You might want to link the Hub image with this repo to auto-update the image on push. When you relax the version constraint for nginx, e.g. to FROM nginx:1.9 and link the image to the upstream image (current version is 1.9.7), you'll get automatic updates there as well. Either way, you can link to the upstream Debian image to at least receive automatic package updates if you want to stay on a fixed version of nginx for the image (or link both for max effect).

See this https://github.com/jwilder/nginx-proxy/pull/57#issuecomment-65462239 for pinning to a specific version :smile:

@jwilder There seems to be an issue with your latest builds on Docker Hub. It seems they were auto-generated. This broke my auto-generated custom "child" builds, too. Can you take a look at this?
BTW, you can set e-mail notification if a build on Docker Hub fails.

@fbender I kicked it and setup notifications.  Didn't know about the notifications... thanks!

Awesome, looks good!

Oh yeah, did you link the build with the upstream Debian and nginx images, so your build gets updated once they are updated?

@fbender Linking with the debian image should not be necessary since the Official Images build process rebuilds all child images when there are changes to the parent images.

@fbender I linked it to the nginx image.

Cool thanks!

I just remembered that this image has a specific version requirement for the nginx image, so version bumps of the official nginx image won't have any effect even if the automated build is linked.

The only case where it will have an effect is if the version that nginx-proxy is using is still the latest version and the nginx image is updated for some reason other than a version bump (e.g. a rebuild of the parent debian image).


#89 Display Package Version

Added the package version to the logo.
Not sure if this is the best way to do this. Did a bit of research and found out that importing package info can be a little picky on how its defined.
Setting value with JSON.stringify() seems to help make sure its the right variable type when passed through Vite. https://stackoverflow.com/questions/67707813/defining-global-variables-with-vite-development#answer-67708431
And the import statements came from the SvelteKit FAQ though theirs was based in the svelte.config.js file and I had to use vite.config.ts to get it to work right. Not sure why. https://kit.svelte.dev/faq#read-package-json

P.S.
If you modify the package.json version number, you have to restart the server or vite.config.ts won't pick up the changes

You know... I'm thinking it might be better to just supply an environment variable with the version string. Relying on the package.json doesn't feel like the right idea to me, because the "version" isn't just the frontend version or the backend version, it is a combined monorepo release.
So either an environment variable or the version from the root package.json.
What do you think?

Either should work. env might be more performant since we don't need NodeJS's filesystem for it. Do you use the versioning for anything on the backend side?

Let's go with modifying src/env.ts and using a PUBLIC_POCKETHOST_VERSION=0.4.1 or whatever in .env-template
Thank you for doing another round on this!

Updated env.ts, added the new env variable name to the template and to my local .env file.
Removed all the file system stuff.


Introducing HTC Sync Manager v3.1.87

I need help with zap stanza, it deletes only files, but not dirs.

rmdir is only for empty directories. If you want to delete directories with files inside, use delete.
Also, to solve common stylistic issues (which this cask has), run brew cask style --fix {{your_cask_file}}.

up&rebase

Thank you for the contribution. It needed some fixes, so they were made in 53c705c70e3091d7b4c994dd358959f60a54252f. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Timelapse, Keogram, Startrails Only Show in the Admin Panel

Good morning and thanks for the absolutely wonderful application. I have an issue i am sure is simply related to configuration.
My Admin Panel / Images shows the Images, Timelapse, Keogram, and Startrails perfectly, and has accumulated them successfully over the last 3 nights. However the website only shows the live image. The others simply show "No xxx images" where xxx is timelapse, keogram, or Startrails, depending on which left-hand menu selection was made.
Any help would be greatly appreciated!

And sorry for putting this on the issues page vs. discussion.

@gktozer   Glad you like Allsky and thanks for the complement.
The WebUI uses the images from the allsky/images folder.  The Allsky Website uses copies of the timelapse, keogram, and startrails images, since the website often runs on a different server.  That means those images have to get copied to the Website.
Check that you're copying the files - make sure UPLOAD_KEOGRAM, UPLOAD_VIDEO, and UPLOAD_STARTRAILS are true in config/config.sh.
You also need to tell Allsky where to copy the files to.  I assume your Website is on your Pi, so in config/ftp-settings.sh, make sure PROTOCOL="local" and set the *_DIR variables according to the instructions in the file.
If those settings are already true, then please follow the instructions on the Reporting Issues Wiki page and I'll take a look at the log file.

@gktozer    Any update?

Closing Issue - no response from user in over a month.


drivers: serial: nrf: Adding UARTE driver for the nRFx family

Added support for two instances of UARTE.

Kconfig.nrfx is capable to configure UART and UARTE driver.

Signed-off-by: Jakub Rzeszutko<EMAIL_ADDRESS>

Codecov Report

Merging #8640 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8640   +/-   ##
=======================================
  Coverage   64.23%   64.23%
=======================================
  Files         440      440
  Lines       42093    42093
  Branches     7072     7072
=======================================
  Hits        27039    27039
  Misses      11828    11828
  Partials     3226     3226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c6894...d86460c. Read the comment docs.

This PR was inspired by @BertoldVdb-byteflies

The commit title should be corrected to start with "drivers: serial:".

I pushed #8761 to fixup the dts.fixup and handle both UART and UARTE on UART0.  This also fixes UART1 support which would have been broken.

One problem we face is that the flow control pins can be on both GPIO port 0 and 1 on a nRF52840 which is currently not supported on the nrf UART driver. Could we consider this issue for UARTE already?

@JoeHut With this PR all PINs for UARTE0 and UARTE1 (including flow control) can be set either on GPIO0 or GPIO1.

recheck

@galak can you take another look?

@MariuszSkamra : So far UARTE driver is expecting defines for UART.
When all drivers will be migrated to DT it will change. So as a temporary solution you can simply change:
NORDIC_NRF_UARTE_40002000_CURRENT_SPEED  to:
NORDIC_NRF_UART_40002000_CURRENT_SPEED.

I've removed extra lines.

@galak #8761 merged

@jarz-nordic I tried testing this last night with the following setup:

nRF52840-DK 0.11.0 HW rev
WNC-M14A2A LTE-M modem using https://github.com/zephyrproject-rtos/zephyr/pull/6344
GPIO P1 PR: https://github.com/zephyrproject-rtos/zephyr/pull/8799
DTS cleanup for UARTE: https://github.com/zephyrproject-rtos/zephyr/pull/8761
Some random additional changes for nRF: https://hastebin.com/arehivedif.diff while debugging

I tried using the LTE-M modem pins as both GPIO P1 and P0 (past 31) and was unable to get a response.  I know this is a fairly complex setup and I see that several of those PRs were merged today.  So, I'm going to setup a more basic test using a TTL device.
Did you have a recommended setup?

@mike-scott  Some comments from my side.
PR: #8799 is for UART driver, this PR concerns UARTE.
I have sucessufully tested this driver for UARTE0 and UARTE1 with following examples:

hello world
shell

I understand that you are trying to use driver from this PR. Can you debug if you reach function: uarte_nrfx_fifo_fill?
According to debug from your link you have:
`+#if 0
while (size--)  {
uart_poll_out(ctx->uart_dev, *buf++);
}
+#else

uart_fifo_fill(ctx->uart_dev, buf, size);
+#endif`

I am having some doubts about it. Function uart_fifo_fill shall be called from interrupt context while uart_poll_out not. It looks to me that you tested it in the same context.

@jarz-nordic I was testing it both ways actually.  When I used uart_poll_out() I was hanging at:
https://github.com/zephyrproject-rtos/zephyr/pull/8640/files#diff-0de7d1227701470077e7117a57033444R243
And the data didn't seem to be sending anything when I used uart_fifo_fill()

@jarz-nordic an update:

I needed to flip TX/RX pins (oddly)
And I'm using GPIO_P1 for controlling the modem pins.

I now can receive output from the power up sequence on the modem:
https://hastebin.com/orokuniloj.vbs
But apparently the "AT" command isn't being received on the modem end yet (should trigger an "OK" for the modem driver to continue).  Still debugging.

Ok, I have it working now.  Apparently I had documented the RX, TX, CTS, RTS pins from the modem side.  So they all needed to be flipped.
Also, using uart_poll_out() is what works atm.  When I tried uart_fifo_fill(), it was only sending the "A" and and a carriage return so that I was getting back an ERROR code.

FYI, here's a full log of successful modem communication: https://hastebin.com/vaburuluhu.txt


Adding Home Icon to every Page

Description
@Abidsyed25 I have added the home icon to every page and also improved the styling in some pages. Kindly review this.
Fixes:  #147

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@Ojas-Arora few checks have been failed. Please try to resolve that and also resolve merge conflicts

@Ojas-Arora try to add a video of what changes you exactly made on this website

@Abidsyed25 ok

@Abidsyed25 I have resolved all the conflicts and I don't know how to make video but I can tell u what changes I have made
Added Home Icon png in all the pages i.e about us,FAQ,Terms and Conditions and Contact Page.
Linked the home icon in all the pages i.e about us,FAQ,Terms and Conditions and Contact Page.
Improved the styling in these pages also.
Kindly review this.


Text cursor navigation by using Ctrl Left / Ctrl Right is very tedious

Good evening
AsciidocFX is very useful to write Asciidoc files, thanks a lot!
Unfortunately, the Text cursor navigation by using Ctrl Left / Ctrl Right is very tedious:
the cursor stops twice too often compared to any other editor. Example:
# The Circumflex accent ^ shows the Cursor position if Ctrl-Right is pressed
# The behavior of a typical editor (like notepad++ or this GitHub Markdown Editor):
AsciidocFX improves Asciidoc …
^          ^        ^        ^
# The behavior of AsciidocFX :
AsciidocFX improves Asciidoc …
^         ^^       ^^       ^^

It would be marvelous if this behavior could be fixed.
Thanks a lot, kind regards,
Tom

Hi @nightwing, how can I do this with ace ?

@rahmanusta you can use editor.session.$selectLongWords = true

Thanks @nightwing ,
@schittli it will be available in next release https://github.com/asciidocfx/AsciidocFX/commit/f6f11fb68af519d606814c31e24d9bb4f37c29ad

Thank you very much, @rahmanusta for your investigation and support!,
it's great to hear about the next usability enhancement :-)


satty: 0.8.2 -> 0.8.3

Diff: https://github.com/gabm/Satty/compare/v0.8.2...v0.8.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Version in the commit message should be updated as well

Version in the commit message should be updated as well

Fixed. Sorry, not sure why nix-update did that.

Result of nixpkgs-review pr 277432 run on x86_64-linux 1

1 package built:

satty


Get() Should accept a default value to be returned when key is not found

https://github.com/Venemo/node-lmdb/blob/0f2f2e7ef930136342d618d74ad8f27f66247ea4/src/txn.cpp#L197-L199
When the key is not found, currently the code always returns null. It should accept a default value to be returned, instead, when the given key is not found. For example:
get(key, defVal) {
  if(key is not found) return defVal;
}

If you desire a default value, you can use JavaScript.
var value = txn.getString(dbi, 42) || "Your default value"

I don't think it's a good idea to bloat node-lmdb with such features, but if you feel like implementing it, a pull request is always welcome.


Cannot obtain call result from plugin compiled by tinygo with go-pdk

go version

1.22.5 linux/amd64

tinygo version

0.32.0 linux/amd64 (using go version go1.22.5 and LLVM version 18.1.2)

os

Linux tjt <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Mar 29 23:14:13 UTC 2024 x86_64 GNU/Linux

node version:

v18.19.0

@extism/extism vesrion

1.0.3 or 2.0.0-rc3

go-pdk

1.0.5

main.go
package main

import (
	"fmt"
	"github.com/extism/go-pdk"
)

func main() {}

//export hello
func hello() int32 {
	fmt.Println("before", pdk.InputString())
	pdk.OutputString("Hello World")
	fmt.Println("after")
	return 0
}

then compiled by tinygo build -o plugin.wasm -target=wasi main.go
test.js
const createPlugin = require("@extism/extism")

;(async() => {
    const p = await createPlugin("plugin.wasm", {
        useWasi: true,
        enableWasiOutput: true,
    })

    console.log(await p.call("hello", "ppp"))
})()

Run with node test.js, reuslt:
before ppp
after
null  // output block not found

Using the exstim cli to call extism call plugin.wasm hello --wasi is working expectly

that's surprising! i'll see if i can reproduce today

here is the demo https://github.com/Celend/extism-js-sdk-demo , I'm also debugging the lib source :D

hmm, yeah i tried a variety of things. I can't seem to get it to work. I suspect this is happening b/c some languages that compile to WASI have quirks and they don't get consistently initialized. We may need to add in a case for this SDK (which is pretty unique to our others as it's custom to target the W3C wasm interface).
Let me know if you see anything. I'll also ping @chrisdickinson today and have him take a look. We have a few people on the team who are familiar with these quirks.

Just to report back for anyone else who looks. The linked project uses v2-rc, but it appears to be happening on v1 as well

We are discussing this in Discord. May be an inconsistency with the way that memory is freed when these two projects meet. We'll try to confirm the theory.

I saw the discord discussion, remove extismFree(offset) https://github.com/extism/go-pdk/blob/7180e57f1b612f1fa769aa5eedde4844f5f6e324/extism_pdk.go#L166 did really worked.

thanks, good to know!

@Celend, this was a recently identified issue, and I missed one place to fix this occurrence. Sorry for that! Will have an update out shortly and will ping here.

@nilslice Thanks for UPDATE! but the address probelm still exists, I think it's int64 max value.
If we should reset the memory, reset for every call or some specific frequency?

@Celend - yes, sorry, i should have clarified :) the PR only addresses the output issue.
as far as the reset frequency goes, I would reset as often as you can tolerate. unless you really need to keep your plugin state alive for a long-running process, it is fast to recreate a plugin and would reset liberally.

@nilslice nevermind! but why do not remove the retentions after call? because to avoid memory copy from wasm to host?

fixed in 1.0.6


getting ack request in case of late(delayed) offer

Hello Dave,
My drachtio app is UAS and in case the late offer received, how can my app get ack response?
My app calls the connectCaller function of mediaserver.
Thank you.

It's been a while, but I found dialog ack event and solved SDP issue.


Gmail attachments

This pr enables to handle attachment file download from Gmail.
Features

Retrieve multiple emails at once by their IDs.
Save multiple attachments from emails to your local system.

Tool Hanlders
add_tool_handler(tools_gmail.GetAttachmentToolHandler())
add_tool_handler(tools_gmail.BulkGetEmailsByIdsToolHandler())
add_tool_handler(tools_gmail.BulkSaveAttachmentsToolHandler())

very nice. thanks!


KeyError in Webpack stats output

I'm using webpack v 1.13.1 transpiling TypeScript and have webpack-bundle-tracker 0.0.93 which outputs webpack-stats.json such as the following:
{"status":"error","message":"(3,21): error TS2503: Cannot find namespace 'moment'.","publicPath":"/website/js/"}
django-webpack-loader is looking for a key 'error' which isn't present in this output and therefore the page  throws a Python KeyError.

Raised this as wrong user and can't delete.

@robinelvin re-open if this is still an issue.

@owais Yes, this is still an issue. When Typescript compilation has no errors it works fine but when there are errors the output is as described.

Please re-open if this is still an issue in 1.0.0-alpha.0. PRs welcome.


FancyZones crashing

Microsoft PowerToys version
0.65.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
drag a window while holding shift
go to a zone
let go of the dragging while still holding shift
✔ Expected Behavior
window get snapped into the zone without any issues
❌ Actual Behavior
fancyzones crashing and window stays in transparent mode
(it doesn't matter if I'm using transparent windows or not, it's still the same issue)
Other Software
No response

I checked EventViewer and it says the d3dcompiler_43.dll has crashed.
see the ZIP which has the EventViewer XML and my settings.

Can you please attach a /bugreport?

Ah, I see, the zipped folder already contains enough information, thank you for preparing it in advance.

Hi @xBiei, looked into your problem. Most likely it's related to GPU drivers since that dll is responsible for shader compilation.
Please let me know if updating drivers help.
/needinfo

Hi @xBiei, looked into your problem. Most likely it's related to GPU drivers since that dll is responsible for shader compilation.
Please let me know if updating drivers help.
/needinfo

This issue didn't happen before I changed my CPU to Ryzen 9 7900x.
It's new in the market but it's still weird bcuz I didn't change my gpu nor my gpu drivers.
I'll give it sometime.
For now, I updated my GPU drivers.
If the error occurs again I'll reopen this issue


Custom ordering of resource creation / deletion

First of all I'd like to thank Grafana Labs and the community around it for yet another brilliant tool! Using this feels like a very promising alternative to Helm or Terraform for Kubernetes deployments.
I'm using Tanka to deploy CRDs for AWS App Mesh controller which in turn creates objects in AWS App Mesh. The CRDs reference eachother (ie. a GatewayRoute references a VirtualService). Deleting a VirtualService while there are still GatewayRoutes linked to it, causes the controller to block the deletion which somehow results in Tanka being unresponsive until I close it via CTRL^C.
Is there any way I can instruct Tanka to delete resources only after certain other resources have been deleted? In my use-case this could work by prioritizing whole Kinds of resources, but ideally I would want it to work on a per-resource-basis.
Even though the controller seems to handle creation of the CRDs in the "wrong" order better, this could probably still help for creation as well.
The way I fixed this for now is deleting the objects manually via the AWS Console and then removing them via kubectl (which is also blocked by the controller but is more "flexible" in terms of ordering).
I tried checking the docs and the other issues but couldn't find anything that would help me here, if there's something I missed, I'd be happy to try.

Thank your for the report.
I believe this is quite similar to https://github.com/grafana/tanka/issues/246, also there the ordering was suggested.

Hi @Duologic, yep there are definitely some similarities but I feel #246 is more around prioritizing CRDs in general and not how to sort individual resources versus one another. If you prefer, you can close this and I can voice my input in the existing issue.
How could resource-specific ordering be implemented in a Tanka-idiomatic way? I can imagine a few variants:

adding a dependsOn or similarly named explicit field to the definitions that is not rendered to the output like Terraform does
adding some configuration (file or parameters) that defines the order of CRDs and/or individual resources
implicitly deriving the dependencies via references in the input (like Terraform does), although this doesn't help with use cases where resources dont't depend on values from depending resources (which is probably why depends_on exists in Terraform)

Pretty sure there are other, more idiomatic ways. I would consider working on the implementation if the general direction makes sense...

I don't have an immediate answer to that, my gut feeling says it should be part of the Environment's spec. It could have an ordered list of manifests that should be applied before anything else.
It is different than #246, but I think it will touch nearly the same code and should probably be designed for together with this issue.
At Grafana, we use Flux to apply exported manifests to the cluster. This reduces the need for working on this on our end but we gladly want to collaborate and accept community contributions.

I'm leaning towards combining tanka (or just jsonnet) with a GitOps tool like Flux or ArgoCD (like @Duologic mentioned, thanks for the input) which will probably solve a bunch of other, unrelated issues.
I'm closing this for now.


[Model Issue]: Serial Part 3.0.0

URL to Model with Issue
https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.serial_part/3.0.0
Issue Description
Date regex does not fit the example value.
Schema is not valid to payload!

@johannsvarela

@catroest means we must change the String example and therefore we have to provide a new SerialPart version (i guess 3.0.1 or 3.1.0)?
FYI @BenediktMuellerIML

@eckardg There are currently two issues that need to be resolved:

The example for the date information does not match the defined regular expression
The existing regular expression for date does not meet all ISO 8601 date formats. The Industry Core Committee should therefore vote on whether the regular expression should be adapted or not.

@jSchuetz88 The topics mentioned also concern the Industry Core models Batch 3.0.0 and JustinSequencePart 3.0.0.

@johannsvarela : Thanks for your explanation. I agree to your proposal. Unfortunately I am not knowledgeable enough of modeling to decide about the regex question

@eckardg In dependence of your preferred solution I might be able to help you out.

@johannsvarela @jSchuetz88 Any idea how to fix this or if we are able to fix this for release 25.03? If not, I would remove it from the changes for 25.03 here: https://github.com/eclipse-tractusx/sig-release/issues/986

@markuskeidl This depends on the preferred solution. We can either change the Regexp, but this would be a minor change and could impact the compatibility of technical implementations.  Or we could just fix the example, which would not impact the compatibility, thus could be fixed as a hotfix.
If you have a preferred way, I can prepare the Change.


ISPN-5621 Remove add and addAll support from entrySet methods.

https://issues.jboss.org/browse/ISPN-5621

Refactored imports.

integrated! thanks @wburns :)