[FeatureRequest] port SpatialUpSamplingNearest and SpatialBatchNormalization from cunn

I tried to rebuild something like http://tinyclouds.org/colorize/ and found that SpatialUpSamplingNearest and SpatialBatchNormalization are not available within clnn. I tried porting Upsampling yesterday (https://github.com/pawni/clnn/commit/091882dea693f9500907341f26c1c492a9b76ad8 ). It seems to work but I haven't tested it properly yet. I will continue to have a look at that and the BatchNormalization, however input would be much appreciated. :)

Cool. Sounds good :-)  Looks like you've already ported it to THNN too?  Let me know when you want me to merge.

Yes I did, as I did not know how not to put it into THNN and be able to use it ;) Is there anything I should keep in mind when porting the things or  is the current port okay as it is?

Ah... hmm... ah :-)  Yes, there is a breaking change coming up.  Look at https://github.com/torch/nn/pull/601  To see what's going to happen, and the effect:
git clone https://github.com/fmassa/nn.git
cd nn
git checkout THNN_fmassa_2
luarocks make rocks/nn-scm-1.rockspec

Now, try re-running your tests :-)

Hi, the THNN changes have been merged in now https://github.com/torch/nn/pull/601#event-554379230

Hi, saw that and tested it. I think THNN isn't the problem but I get some weird values which I need to fix - I need to check when I have some time to figure out wether it is the CL code or somewhere in the c++ where my values are getting corrupted. It seems like I am running over the limit of the data types but not sure though.

Ok. Just in case it's useful, what I normally do for testing kernels is:

add some c/c++ code to print out the result of calling a kernel
modify the kernel to not update the output tensors
add an if clause, for one single kernel thread, and use that to write out a bunch of debug/diagnostic info, like:

kernel something(foo, blah, ....) {
  // stuff here

  // out[get_global_id(0)] = foo; // commented out

  if(get_global_id(0) == 0) { // only one thread enters this, ever
    out[0] = 123; // some visible value, check anything is happening at all
    out[1] = b[0]; // find out what is in b[0]
    // etc ...
  }
}

I tried adding your debug code however I can't even see the 123 in the output. Furthermore, it mostly does not change the output but sometimes it seems to put random values into it. Do you have any idea why that might happen?
I made the changes here: https://github.com/pawni/clnn/blob/master/lib/THCLNN/SpatialUpSamplingNearest.cpp
And there is also a test script testing the module similar to the other ones.

(accidentally clicked into this.  please paste a new, dummy, message, so it stays in my notifications.  i will check after word / at weekend)

(push)

oh, it should be k.out(output).
Also, you'll need to call synhronize(), and copy the data back from the gpu to the cpu.
To synchronize is something like:
    cl->finish()

To copy back from gpu to cpu is something like:
THClTensor_wrapper(state, output)->copyToHost();

(it might be that changing from k.in to k.out, for hte output, is sufficient to solve the issue. But usually custom kernels require a fair amount of debugging.  Depends...

(just to be clear, you dont need to synchronize, or copy data back, normally. just if you are debugging. actually since you are using cout to print, it might handle that automatically, I'm not sure)

(As for, what is the difference between k.in, and k.out.  Basically, k.in will copy data from main memory to the gpu memory before running the kernel, and then do nothing afterwards, as far as that particular value or tensor.  k.out will leave the gpu-side buffer as created but not initialized in any particular way, and certainly not with the contents of the cpu-side tensor copied into it.  After running the kernel, the data will be copied from gpu into main memory.  It's been a while, but I think that the way it does this is by setting a 'dirty' flag, so it wont actually explicitly copy stuff, unless you try to read it and stuff, but it will cause a copy to take place, when you try to read it, as long as you read it through tensor api methods.  And there's also inout which does both. transfer in both directions.  In the back of my mind, I think that inout is the same as one of in or out in practice, but I cant remember, so just use the one that matches what should be happening)

That made it an easy fix - I just changed the out and added the finish() and copyToHost() and it seems to work now. Thanks a lot! Shall I create a PR for that?

(see https://github.com/pawni/clnn/commit/7f9a8677d429a6c1376dd3fef3b4783bad6ac553 )

I just changed the out and added the finish() and copyToHost() and it seems to work now.

Ok great!
Actually, the finish and copyToHost are only needed for debugging (so you can see the output, and even then I'm not sure they're needed, if you use cout, as you do).  You should be able to remove them now, and it should continue to work.  Hopefully :-)

Just changed it and it is still working as it should - thanks! :)
Do you want me to PR?

Yes, please create a PR.

Well... I get the following error messages when I run the tests:
SpatialUpSamplingNearest_backward
 Function call failed
/home/ubuntu/torch/install/share/lua/5.1/nn/THNN.lua:1045: OpenCL error, code: CL_INVALID_ARG_SIZE at /home/ubuntu/git/cltorch/src/lib/THClKernels.cpp:27
stack traceback:
	[C]: in function 'v'
	/home/ubuntu/torch/install/share/lua/5.1/nn/THNN.lua:1045: in function 'SpatialUpSamplingNearest_updateOutput'
	...ch/install/share/lua/5.1/nn/SpatialUpSamplingNearest.lua:50: in function 'forward'
	...tall/share/lua/5.1/clnn/testSpatialUpSamplingNearest.lua:123: in function 'v'
	/home/ubuntu/torch/install/share/lua/5.1/clnn/test.lua:2619: in function </home/ubuntu/torch/install/share/lua/5.1/clnn/test.lua:2617>
	[C]: in function 'xpcall'
	/home/ubuntu/torch/install/share/lua/5.1/torch/Tester.lua:115: in function 'pcall'
	/home/ubuntu/torch/install/share/lua/5.1/torch/Tester.lua:186: in function '_run'
	/home/ubuntu/torch/install/share/lua/5.1/torch/Tester.lua:161: in function 'run'
	/home/ubuntu/torch/install/share/lua/5.1/clnn/test.lua:2658: in function 'test'
	(command line):1: in main chunk
	[C]: at 0x00406670

--------------------------------------------------------------------------------
SpatialUpSamplingNearest_forward_batch
 Function call failed
/home/ubuntu/torch/install/share/lua/5.1/nn/THNN.lua:1045: OpenCL error, code: CL_INVALID_ARG_SIZE at /home/ubuntu/git/cltorch/src/lib/THClKernels.cpp:27
stack traceback:
	[C]: in function 'v'
	/home/ubuntu/torch/install/share/lua/5.1/nn/THNN.lua:1045: in function 'SpatialUpSamplingNearest_updateOutput'
	...ch/install/share/lua/5.1/nn/SpatialUpSamplingNearest.lua:50: in function 'forward'
	...tall/share/lua/5.1/clnn/testSpatialUpSamplingNearest.lua:36: in function 'v'
	/home/ubuntu/torch/install/share/lua/5.1/clnn/test.lua:2619: in function </home/ubuntu/torch/install/share/lua/5.1/clnn/test.lua:2617>
	[C]: in function 'xpcall'
	/home/ubuntu/torch/install/share/lua/5.1/torch/Tester.lua:115: in function 'pcall'
	/home/ubuntu/torch/install/share/lua/5.1/torch/Tester.lua:186: in function '_run'
	/home/ubuntu/torch/install/share/lua/5.1/torch/Tester.lua:161: in function 'run'
	/home/ubuntu/torch/install/share/lua/5.1/clnn/test.lua:2658: in function 'test'
	(command line):1: in main chunk
	[C]: at 0x00406670

Thoughts?

Probably no_elements should be an int, to match what you are feeding to k.in, and because pretty much everything in clnn is ints for now (no-one has ever complained once about this, as far as i remember, so ints they stay for now :-) )

Weird - it runs fine for me..
what are the versions of your other libraries / environment so that I can try to replicate?
But I also changed the long to int (just kept it from the conversion ;) ) so you could try again

Ok.  Seems like there is a bunch of stuff missing from my CMakeLists.txt too, so cog isnt running.  All that stuff in quotation marks at the bottom of the .cpp file should be generated automatically by cog.

hmmm, mine still fails actually.  I'll push where I am to a branch.

Here's the changes I've made: https://github.com/pawni/clnn/compare/master...hughperkins:pawni-master?expand=1  You should be able to run 'cog' to update the bits in quotation marks at the bottom of the cpp files by doing:

cd build
ccmake ..
flick 'DEV_RUN_COG' to 'ON' (you'll need python in the path)
'c' for configure, 'g' for generate'
cd ..
luarocks make clnn-scm-1.rockspec => should now copy the contents of the .cl files into the .cpp files, whenever the .cl files are updated

Weird - it runs fine for me..
what are the versions of your other libraries / environment so that I can try to replicate?
But I also changed the long to int (just kept it from the conversion ;) ) so you could try again

Well, the specific error CL_ARG_SIZE normally means something like there is a mismatch between the arguments you are passing to k.in and the arguments expected by the kernel, in the .cl file.  It could be gpu-specific plausibly, but shouldnt depend on other libraires and stuff, I think.
I'm using an NVIDIA 940M, on Ubuntu 15.10 64-bit.

Oh wait, changing from long to int fixed forward, but back is still broken.  I will do the same thing in backward.

Ok, passing now.  I've merged to master: https://github.com/hughperkins/clnn/commits/master

awesome, thanks!

Thank you very much Nick

Thank you for the support! I hope that I'll also find time to get my head around the batch normalisation but that looked a bit harder than the up sampling - I'll keep you posted about it.

Ok, cool.  Sounds good :-)  Batch normalization would be very useful :-)

Oh... SpatialBatchNormalization does look quite challenging... the good news is, no thrust.  thrust is basically not directly portable, needs a bunch of creativity.
SpatialBatchNormalization contains a zillion kernels, but they should be all fairly directly portable.  Probably a bunhc of work though.  All those bits with triple angle brackets are CUDA kernel launches, eg:
SpatialBatchNormalizationBackward_kernel<8>
      <<<blocks, threads, 0, s>>>
      (input, gradOutput, gradInput, gradWeight, gradBias, weight,
       saveMean, saveStd, scale);

The kernel itself is higher up in the same file, and it's a template, with parameters.
OpenCL itself doesnt handle templates.  OpenCL is essentially C99, whereas templates are from c++.  What I'm doing is using lua as a templating language.
You can see an example by looking at the CUDA implementation of THCApply.cuh, in cutorch, and comparing it to the OpenCL version, ie compare https://github.com/torch/cutorch/blob/master/lib/THC/THCApply.cuh with https://github.com/hughperkins/cltorch/blob/master/src/lib/THClApply.cpp and https://github.com/hughperkins/cltorch/blob/master/src/lib/THClApply.cl
The stuff with curly brackets {% ... %} is templating, in the style of Jinja2, but using {% ... %}, instead of {{ ... }}.

Just noticed that SpatialBatchNormaliation used to be working, and was broken in https://github.com/torch/nn/pull/665 and an earlier commit.  Fixed it now.  Should be working again now?

Hi,  I decided to take the radical step of rolling back torch and cltorch to aorund 21 February, prior to a bunch of the THNN changes, which were causes entropy at a rate faster than I could handle.  This has the downside that thats just slightly before your PR for spatialupsamplingnearest.  So you might need to resubmit the PR for that please.

Should all be working again now, I think?


Margin at the bottom of the form

Bottom Margin of the form is bit less as compared to other three sides

I would like to work on this

@Anupam-Panwar there is another issue (Design a new creative footer) https://github.com/QAZIMAAZARSHAD/Voters-Registration-Portal/issues/4.
I think this margin issue will be handled there, so no need to create a new issue.
If you have any better ideas for the footer you can work on issue number https://github.com/QAZIMAAZARSHAD/Voters-Registration-Portal/issues/4

@QAZIMAAZARSHAD I thought that issue will deal with design of new footer only.


Need to clarify speed of the server

The readme says that the server has speed about 10K trades per second but which part of the server has this speed?
I guess, it’s the accesshttp module. Is it correct?

MySQL is the bottomneck, the whole system order tps is actual about 1k.

It depends on the MySQL. You can move the write history part out of matchengine and use mulit mysql instance to increase the performance.


This is still happening.
npm ERR!


Fix ...styles example in the readme

Hi, I was playing around with some of the examples in the README.md in CodeSandbox and noticed this.
Not sure if this is an error in the docs or a bug but removing the array fixed the issue.

What: README.md

Why: Example not working.

How: Remove array from example.

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         106    106
  Branches       27     27
=====================================
  Hits          106    106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055a921...ba81213. Read the comment docs.


Remove Cloud Images from DC/OS repo.

High-level description

https://jira.d2iq.com/browse/D2IQ-52088 - Remove Cloud images. These images are no longer used.

The testing for DC/OS OS Qualification is done using dcos-images project.
The DC/OS universal installer uses Upstream AMIs directly - https://github.com/dcos-terraform/terraform-aws-tested-oses
So, the files getting deleted are stale and are not used by DC/OS.

@mesosphere-mergebot label ready for review

@mesosphere-mergebot changelog-not-required not a user facing change


Use cli without ormconfig file

Is it possible to use the current cli without a ormconfig file? I normally initiate my database connection as follow, this way I can keep all the code on typescript side and avoid having an extra configuration file
import path from 'path';
import { createConnection, Connection } from 'typeorm';

import { env } from './env';

const { DB_HOST, DB_PORT, DB_USER, DB_PASSWORD, DB_NAME } = env;

export const createDbConnection = async (): Promise<Connection> => {
  try {
    const entitiesPath = path.resolve(process.cwd(), 'src/db/entities/*{.ts,.js}');

    return await createConnection({
      type: 'postgres',
      host: DB_HOST,
      port: DB_PORT,
      username: DB_USER,
      password: DB_PASSWORD,
      database: DB_NAME,
      entities: [entitiesPath],
      synchronize: true,
    });
  } catch (e) {
    throw new Error(`Unable to connect with the database, e: ${e.message}`);
  }
};

Hello @tiagocorreiaalmeida, I have this problem, how did you solve it?

@EndersonPro  I ended up changing to sequelize

@EndersonPro I also wanted to avoid an extra configuration file.
Here's how I did it:
Assuming you have the following directory structure:
- database
  - config
    - Connection.ts
  - entities
  - factories
  - seeds
package.json

Pull out your typeorm connection options to a separate file.
Connection.ts
import { ConnectionOptions } from 'typeorm';

export const typeormConfig: ConnectionOptions = {
  type: 'postgres',
  host: process.env.POSTGRES_HOST || 'localhost',
  port: process.env.POSTGRES_PORT ? parseInt(process.env.POSTGRES_PORT, 10) : 5432,
  username: process.env.POSTGRES_USER,
  database: process.env.DATABASE || 'database',
  password: process.env.POSTGRES_PASS,
  synchronize: false,
  logging: 'all',
  entities: ['database/entities/*.ts'],
  migrations: ['database/migrations/*.ts'],
  cli: { migrationsDir: 'database/migrations' },
};

// important to work with CLI.
module.exports = {
  ...typeormConfig,
  seeds: ['database/seeds/**/*{.ts,.js}'],
  factories: ['database/factories/**/*{.ts,.js}'],
};

package.json
"scripts": {
    ...
    "db:seed": "ts-node -r tsconfig-paths/register ./node_modules/typeorm-seeding/dist/cli.js -r database/config -n Connection.ts seed"
  },


Refactor & rename the /admin/slack/create-proposal-channel/{proposal_id} endpoint

Instead of having the existing endpoint that will create (and update if the channel already exists), have a single endpoint name that we call using the different HTTP verbs, so that

GET - returns information on a proposal slack channel
POST - creates a proposal slack channel - errors if already exists
PUT - updates / enforces settings for an existing proposal slack channel

@danielballan @padraic-shafer Does this make sense ?

The sounds good to me.

Do we also want a DELETE ?


Can I highlight the type of $type(fix/feat/xxx) in the submit window?

No, you can't. The message field has its own syntax with auto-completion by default (but without highlighting).
This is not the purpose of this plugin at the moment. Syntax highlighting is planned only for the template in the settings.

It's just only show

Maybe in future releases :)


Getting a weird page from law.justia.com instead of lyrics

When trying to fetch the lyrics for the song "I Killed A Man (Live in Moscow)" by the artist "Slaughter To Prevail",
somehow i get the contents of this page.
Code:
const options = {
apiKey: Bun.env.CLIENT_ACCESS_TOKEN,
title: "I Killed A Man (Live in Moscow)",
artist: "Slaughter To Prevail",
optimizeQuery: true,
};
const rawLyrics = await getLyrics(options);
console.log(rawLyrics);
It's very weird, any idea for how that's happening?

Can you please share the output?

It's extremely long, basically the whole content of the case presented on that link. Start with : Citation: 409 Mich. 672\n\nFITZGERALD, J.\n\nThe existence and scope of the felony-murder

It's extremely long, basically the whole content of the case presented on that link. Start with : Citation: 409 Mich. 672\n\nFITZGERALD, J.\n\nThe existence and scope of the felony-murder

I've found that page by googling some of the content i received. I believe that you would get the same result if you'll request that specific song

I believe you're getting the lyrics for this song.

Guess you're right. But still, it's a long way from the song i requested. Any idea why?

@SemionVino The getLyrics function searches the song via Genius API and returns the lyrics for the first search result by default. For more accuracy, I would recommend using the searchSong function, doing a fuzzy search on the search results and then fetch lyrics for the closest match using getSongById.


nomad_1_7: 1.7.6 -> 1.7.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hashicorp/nomad/releases.
meta.description for nomad_1_7 is: A Distributed, Highly Available, Datacenter-Aware Scheduler
meta.homepage for nomad_1_7 is: https://www.nomadproject.io/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.7.7 with grep in /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7
found 1.7.7 in filename of file in /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
nomad
nomad_1_7

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nomad_1_7 https://github.com/r-ryantm/nixpkgs/archive/2beb145343695f2a25870c6eebf88f1dd6446099.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2beb145343695f2a25870c6eebf88f1dd6446099#nomad_1_7

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7
ls -la /nix/store/83zll22k4mrj0sbscdypajrn1am2gjzi-nomad-1.7.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

nomad (nomad_1_7)

Maintainer pings
cc @rushmorem @pradeepchhetri @endocrimes @amaxine @techknowlogick @cottand for testing.

duplicate of https://github.com/NixOS/nixpkgs/pull/304689 , closing


improve readme

@vesparny pls r&m, I refactored readme a bit as it's done in other gulp plugins
Installation, Usage, Options

merging!


Can I pass the model as a LMP call override?

OMG - Ell is fantastic! It's super obvious to use, and much simpler then Langchain!
The only thing I haven't been able to figure out is how to select the model at call time (as opposed to passing it to ell.simple or ell.complex. I'd expect an override just like we have for api_params on any LMP call.
I want this because I have a lot of model fine tunes which I select at runtime, and loading it into the decorator feels abusive. Another use case would be a program that wants to pass the model name on the command line.

Yes! You actually use the api_params override to do it.
`my_lmp(api_params={"model": "another_model"})

Hi @MadcowD, A followup question on this, is there a way to override the model choice / config globally (i.e. for all ell calls)?


Uncorrect path find for translations

$ crowdin-cli-py --version
crowdin-cli-py 0.95.1
$ cat crowdin.yaml
project_identifier: poradnia
api_key_env: CROWDIN_API_KEY

files:
  -
    source: '/poradnia/**/locale/en/LC_MESSAGES/django.po'
    translation: '/poradnia/**/locale/%two_letters_code%/LC_MESSAGES/django.po'

For source files everything is great:
$ crowdin-cli-py list translations
Warning: Configuration file misses parameter `base_path` that defines your project root directory. Using current directory as a root directory.
poradnia/keys/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/templates/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/events/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/letters/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/records/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/cases/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/advicer/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/tasty_feedback/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/users/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po

For translations files subsitutions fail:
$ crowdin-cli-py list translations
Warning: Configuration file misses parameter `base_path` that defines your project root directory. Using current directory as a root directory.
poradnia/keys/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/templates/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/events/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/letters/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/records/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/cases/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/advicer/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/tasty_feedback/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
poradnia/users/locale/en/LC_MESSAGES/locale/pl/LC_MESSAGES/django.po
$ find poradnia -name 'django.po' -wholename '*/pl/*'
poradnia/keys/locale/pl/LC_MESSAGES/django.po
poradnia/templates/locale/pl/LC_MESSAGES/django.po
poradnia/events/locale/pl/LC_MESSAGES/django.po
poradnia/letters/locale/pl/LC_MESSAGES/django.po
poradnia/records/locale/pl/LC_MESSAGES/django.po
poradnia/cases/locale/pl/LC_MESSAGES/django.po
poradnia/advicer/locale/pl/LC_MESSAGES/django.po
poradnia/tasty_feedback/locale/pl/LC_MESSAGES/django.po
poradnia/users/locale/pl/LC_MESSAGES/django.po```

What I am doing wrong?

Hello. You're doing nothing wrong, I think there is some "minor" bug with replacing a file name for translations file. I'll try to fix it today.

There was some compatibility issue. I managed to reproduce your project configuration, and figured out that this wrong file path for translations, only occurs for Python 2.7, on 3.5 everything fine. So I did some patching and now it should work like a charm.
You try upgrade to new version and see yourself if it works like intended. 0.95.2
pip install --upgrade crowdin-cli-py

Thanks, fixed!


Remove arrow function and replace with function keyword in server.js

Fixes #65

@NogsMPLS Did you try with 4.2.1 already so I can close the PR? I would like to maintain supported ES6 features in node 4

Yeah, sorry. You are correct, moving to Node 4 solved this issue, I will close pull request.
Maybe a note in the contribution area to inform people that if they want to run locally for testing their contributions they'll need node 4? Just an idea.

Yes, you are right, It should be included in the Contribution section in the README.
Thanks!


Feature/equivalent content store graph

Currently if the equivalent_content store reaches an inconsistent
state where rows exist for a set that should not be part of the set
according to the equivalence graph store we will serve stale content
as part of the set. To resolve this we will store the equivalence
graph as a static field on equivalent_content and use it to check
every returned row is actually part of that set

LGTM, other than that minor thing


feat: telemetry uuid

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 23 (73.91%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 66.619%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

getdeck/telemetry/telemetry.py
17
23
73.91%

Files with Coverage Reduction
New Missed Lines
%

getdeck/telemetry/telemetry.py
1
57.89%

getdeck/utils.py
1
65.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1403

Relevant Lines:
2106

💛  - Coveralls


Image links are broken

Hi team,
Excalidraw+ user here - many drawings of mine display a "n/a image" all of the sudden (gray placeholder, as if the image is not there).
These are all drawings which I've been using for the past weeks with no issues.
The issue even persists with new drawings I started today: pasting an image and switching back and forth to a different drawing shows broken links.
This issue is stopping me from using my drawings at the moment, can you please assist?
Thanks in advance!

I don't know if this is related, but i cant embedd none type of image links using Web Embedds. When doing so, i recieve each time the next message

I've tried embedding links to jpg, png, gifs, etc

@pikatwinky that's for embedding websites (e.g. youtube links), not images. For images, use this button:

Or simply copy/paste an image, or drag & drop it on canvas.

@orperel sorry for missing the issue over here, but I see you were able to contact us over at Discord. If the issue persists, please reach us over there or over the email (support@excalidraw.com). 🙏


feat: Add Weight & Biases logging and reporting

This PR add functionality to log evaluation results to Weight & Biases.
In addition to logging evaluation runs and tables we also add functionality to auto generate an easily sharable Weight & Biases Report.
An example auto generated report can be seen here
To install this functionality please run pip install "lm_eval[wandb]"

This looks like a great start, and is something that’s been on my mental to-do list for quite a while.
One thing we often do is evaluate several models on the same datasets, and then wish to compile a report comparing them. If you could add a function that you call on a set of reports that produces the combined report, that would greatly increase the value added to people using this library.
Here’s an example of the kind of plot I have in mind.

@StellaAthena : Thanks for the input. Currently, the integration logs a single run and creates a report for an evaluation run linked to a specific model and it's relevant tasks. I love what you have suggested and was thinking along the same lines. However, to achieve that we will need access to either existing runs and reports (formatted in a a specific way) or logged evaluation tables that can be compiled into the right kind of graphs in a report. I feel with these in place - comparing different models/reports will become possible. I will work on this feature and raise a PR for that soon.

@parambharat any updates on this?

Hi @StellaAthena , yes this is WIP with a few changes pending. I'm currently on vacation and will be back by the end of the week. I'll commit the changes as soon as I'm back. Sorry for not dropping the update here earlier.

Wonderful! Can’t wait to see it.

How does this sound? @parambharat

@satpalsr. Thank you for the link to your colab and the corresponding workspace. It was really helpful in moving this PR forward in the direction that @StellaAthena has requested.
@StellaAthena : Let me know if the changes I've pushed works. Due to current constraints in the wandb ReportsAPI I was only able to add the comparison plots to a run. And add a link to the run in the report. The necessary plots can be imported into the report easily. I have added a how-to Note for this in the auto-generated report.
Here's the sample report: https://wandb.ai/parambharat/lm_eval/reports/-2023-01-03-09-06-02-Model-comparison-report--VmlldzozMjU0Mzg5
and the corresponding run : https://wandb.ai/parambharat/lm_eval/runs/1awvscu4

Hi @StellaAthena : Do you have any feedback on this ? Can you please take a look and see if this works ?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: StellaAthena:x: Bharat Ramanathan:x: parambharatBharat Ramanathan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi is there any progress on this?

We're moving towards supporting Zeno for visualizations. But feel free to reopen this if you think it's still worth doing. Also note that we've changed our default branch.

@lintangsutawika i don't see any harm in supporting both, and lots of people (including at EleutherAI!) regularly use WandB for logging.

@mkeoliya I am currently at NeurIIPs but have looking at this on my to-do list for next week. One thing is that we just pushed a major backend update. I assume some changes (hopefully minor) will be necessary to ensure compatibility with main. Would you be able to do a pass at addressing that?

@mkeoliya I caught COVID at NeurIPS and am unlikely to get to this before EOY.

Closing as superseded by https://github.com/EleutherAI/lm-evaluation-harness/pull/1339


Issue with Rendering the Profile Images.

Description
Apparently, the image loading is quite not normal. Sometimes it gets loaded fully, sometimes it displays the alt text. Normally this should not happen, on a fully functional internet connection.
Screenshots

Additional information
N/A

I'm not sure, but I don't think this is an error of the website. According to the console, the images don't load because of an error with the status 429 (Too Many Requests), which is probably caused by the limit of requests that GitHub allows.

@GaryNLOL isn't there any way we can fix it?

Instead of making the fetch for lists.json multiple times, It's ideal to maintain a global state. It may limit the number of requests to the user list.

I have an idea about maintaining the list.json in global state using context hook. But when I tried implementing it, I encountered an another issue while navigating from Profile component to the Home page. The state is resetting during the routing. Any suggestions?

I have a working solution in my local repo to eliminate duplicate network calls for a list and maintaining a global state using Context API. Can I create a PR for this issue?

I have a working solution in my local repo to eliminate duplicate network calls for a list and maintaining a global state using Context API. Can I create a PR for this issue? @krishguptadev

Yeah sure!

Isn't this issue fixed already?

The pull request is created for it. It has to be reviewed. fix: rendering profile images (#480) #504

Yes, I tried searching for a profile too and it didnt render and when I reloaded the page it worked.

I had another kind of issue but simillar to this #1085

I think this is due to the rate limit on GitHub's API
We are planning to refactor the home page as the list is so long now
Here is the issue
https://github.com/EddieHubCommunity/LinkFree/issues/1264

This should be fixed now with PR #1306


Add missing members and alphabetize ordering

This adds in some missing workspace members and alphabetizes the ordering.
cc @sunshowers maybe this would also be a good lint, similar to the cargo fmt ones for imports.

@bors-libra r+ cool thanks.

:hourglass: Testing commit 84bd34a396df091ac9342777ab4d947e0fc1536a with merge c1c890951cabb232939f7dd80defa8013e26f445...

looks good! I'll try writing a lint for this -- should be easy if we parse the root toml + use guppy.

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: rexhoffman
Pushing c1c890951cabb232939f7dd80defa8013e26f445 to master...


CSS leaking

There is CSS leaking after updating from 0.8.0 to 0.9.0. It's setting background color, font, and others on components that are not Jotai Dev tools.
I noticed that it's adding the whole @mantine css to my project.

Thanks for reaching out!
We have a known issue when customers use Mantine in their main app along with Jotai, the theme would not work as expected (light/dark mode). Our recommendation is to sync the theme via props. Please see this warning.
If this issue is different, could you please create a small repro? Happy to look into it.

I don't use Mantine, in my case I use Panda CSS. Moreover, importing the CSS file, based on the documentation, leaks Mantine to all my application affecting all my styles. Also, it happen if I'm running in dev or prod mode. The devtools is supposed to be available on dev more, correct?

Could you please create a small repro perhaps on CSB?

I think I know what's going on here. We're including global styles that affect the body tag. For now, could you try overriding your style with !important while I look into the fix?

Hey @marviobezerra
Could you test this canary tag and see if that fixes the issue for you? - https://ci.codesandbox.io/status/jotaijs/jotai-devtools/pr/139/builds/496213 (Follow Local Install Instructions)

I'll try tomorrow morning and post back. Thanks for the quick response.

@arjunvegda It's still broken because of these styles:

Particularly font-size: inherit is causing the size of my buttons to be wildly off what they should be.

@sebinsua  - you could also downgrade it to 0.8.0 temporarily until we figure this out. Sorry for the hassle!
Re: css-reset styles, what's a good way to remove them? I think the inherit problem is that Mantine is not designed to be used for libraries 🤔 But it drastically helps us in adding new features without having to maintain our own library.
Should we write our own post css plugin that removes the css reset styles?

I tried and it still leaking. I downgraded to 0.8.0 and it's working.

Could you folks test the latest change https://ci.codesandbox.io/status/jotaijs/jotai-devtools/pr/139/builds/496725 ?

Could you folks test the latest change https://ci.codesandbox.io/status/jotaijs/jotai-devtools/pr/139/builds/496725 ?

This seems to be working for me.

@arjunvegda this is still not fixed on https://pkg.csb.dev/jotaijs/jotai-devtools/commit/992cb72f/jotai-devtools. I am using tailwindcss and the default "light" theme is overwriting some default global CSS styling to be black.

Thanks for reporting @kvnxiao! Could you try this tag https://pkg.csb.dev/jotaijs/jotai-devtools/commit/57787cb3/jotai-devtools/_pkg.tgz? If this does not fix the issue, then could you please create a small repro on CodeSandbox?

@arjunvegda I've been having the same issue.  installed from https://pkg.csb.dev/jotaijs/jotai-devtools/commit/57787cb3/jotai-devtools/_pkg.tgz and can confirm this fixes it for me

Released the fix in v0.9.1. Please feel free to re-open this issue if the problem persists.

thank you for this!

The same issue in v0.10.0 it leaks the CSS and alters mantine menu style.


Custom animation example is missing

Hello,
Is it possible to put the code for the custom animation shown on the screenshot ?
Thanks

which screenshot?

On the main page, you have a animated gif with différent screens

The first screen is normal swipeable tile
The second is swipeable cards
The third is with a custom animation
The fourth is with chat bubbles
Do you have the source code for the third screen ?

I told you in the email I lost it. However, after that, I looked in my folders and I found it. It's easy to implement, it's done using custom paint. The implementation is somehow similar to this code
If you really want to get this animation code you have to pay me, I will give you.


Add jrife to organization members

Add jrife to organization members.

cc @joestringer @hemanthmalla

I also noticed<EMAIL_ADDRESS>:)


updated orion documentation with tourguide examples.

This PR updates the documentation related with Orion Context Broker. Now the documentation examples follow the model defined in the Tourguide Application.
A compiled version can be consulted at http://testfiwaretour.readthedocs.org/en/refactor-orionv1-adapt_tourguide/development-context-aware-applications/introduction/

overall looks good but I'm a bit worried about data inconsistency, please check

please check the payload indentation and consistency. In v1 payloads everything is represented as a string so it is a surprise to see it as you represent it, are those the outputs provided by the real service?

We have executed all the requests using curl again and we have copy-pasted the result from the console. We only have modified aggregateRating values because they are not updated correctly.
aggregateRating values are always:
 {
     "reviewCount" : 0,
     "ratingValue" : null
}

LGTM. @FiwareULPGC  Please fix the nit, double quotes on Client id and then merge yourself squashing,


Fix zero downtime deployments

Changes

Uses schema versions to separate new instances of the indexer
Readonly behavior on the index store for web server responses

Tests

Tested on railway with uniswap example

Closing in favor of #498


Invert axis doesn't work

MoltenGamepad version 1.2.1
According to docs this should invert  the axis direction:

wiimote.cc_left_x = left_x-

Tried a lot of variations but none works. The moment I add a minus to the mix the whole axis (X AND Y) goes dead:
abs_rz = "left_y", "Left stick Y axis"
abs_z = "left_x-", "Left stick X axis"

It works just fine without the minus but also does not invert the axis direction.
Inverting both does also not work (Tried that because the whole axis will also not work if x OR y are missing)

Nvm, I confused gendevices with profiles.
It works when dropped in a profile file and loaded from there 🤦


Feature request: Specify portfolio mouseover image

Portfolio items have images specified and when hovered over, present a generic shaded image with + sign (as in screenshot below).
Visitors suggest it is useful to see an alternative roll-over image related to the content that will be presented when clicked.
This may or may not be useful to roll over within the modal or page - I haven't considered this in any detail.
This could be applied such as:
# Example Gallery Item / Standalone Page
Title: Awesome Thing
image: assets/images/awesome.png
image_rollover: assets/images/rollover.png
Date: 2021/03/20
actions:
  - icon: external-link-alt
    content: Learn More
    link: http://example.com

This actually isn't an image at all, but just a semi-transparent background color and a text character + making this effect.
At the very least, this could be done by swapping the background color for a background image in the CSS and hiding the +.
I'll probably see if I can add an actual image element into that hover container without breaking anything though.  I'd rather not start mixing in inline CSS unless I have to (it'd have to be inline to be able to manipulate it with Twig).
Should be doable either way though.
I don't really see that having a purpose for the modal / standalone page views, so it'd probably be specifically a thumbnail_rollover image.  You could still use full size image property as your thumbnail with it though, it just wouldn't have a rollover when displayed in the modal / standalone page view.


0.4.0

Injecting the $window service.
No need of "this".

Dupe of #377, we'll try to get that one merged.

I did this one in order to commit the change on the 0.4.0 branch, and not only master.

LGTM, @lirantal any comments?

can't comment as I don't do angular.


Handle folded block scalars in script blocks

Literal Style block scalars (|) are generally handled properly, but folded block scalars (>) confuse the syntax because each newline is treated as a newline in shell when it is actually an implicit line continuation.
This syntax is sometimes advantageous when using many arguments in a call and definitely preferrable from a syntax perspective over an implicit unqouted multi-line scalar or even a quoted multi-line scalar.
Syntax documentation: https://yaml.org/spec/1.2.2/#813-folded-style
Example (using GitLab syntax):
release-finish:
  extends: release
  rules:
    - if: $CI_COMMIT_BRANCH =~ /^release\//
      when: manual
  script:
    - NEW_VERSION="${NEW_VERSION:-${CI_COMMIT_BRANCH#release/}}"
    - >-
      mvn
      --batch-mode
      $MAVEN_CLI_OPTS_DEFAULT
      $MAVEN_CLI_OPTS
      $MAVEN_GITFLOW_CLI_OPTS
      gitflow:release-finish
      -DpushRemote=true
      -DreleaseVersion="${NEW_VERSION}"
      -DskipTestProject=true

Would you expect to make a new Bash embed file that puts a - match '\n' in the prototype? Or prepend it judiciously? Or override to strip all the newline pops in every context that has them?

I think I'd try going with an embed that back-references the number of spaces used on the first block scalar line and then use a prototype that just swallows all new-lines, ideally as a re-usable extended syntax.


CASE/unrealistic_high_pm25

Case Details:
cd /scratch1/NCEPDEV/stmp4/Li.Pan/COM/firex_1/logs/2019070100
grep -ni "pm25 max" gfs.forecast.highres.log
8390: pm25 max =    2101.25335386130       min =   9.947723530538242E-027
11148: pm25 max =<PHONE_NUMBER>26711       min =   9.823742736999839E-027
13858: pm25 max =<PHONE_NUMBER>.33169       min =   9.681838852327386E-027
16568: pm25 max =   2.147749677365294E+020  min =   9.730520599258893E-027
Model Configuration Details

Resolution: C384L64
Begin Date:<PHONE_NUMBER>
End Date:<PHONE_NUMBER>
Cold Start: True
Forecast length (FHMAX_GFS): 24 hours
FV3 output: every 6 hours

Aerosol Model Configuration
rcfile=/scratch2/NCEPDEV/naqfc/Li.Pan/save/data/NASA/rc.firex
logfile=/scratch1/NCEPDEV/stmp4/Li.Pan/COM/firex_1/logs/2019070100/gfs.forecast.highres.log
rundir=/scratch2/NCEPDEV/stmp1/Li.Pan/chem202108/firex_1
homgfs=/scratch2/NAGAPE/arl/Li.Pan/global-workflow

@lipan-NOAA could you give a little more context for what is happening? Is
this extremely localized and does it persist? Is this due to a specific
species (OC, BC or DUST)? What is the wet scavenging settings?
I noticed that you did not use the latest develop branch for your
configuration files. There are several updates and we have been seeing
fairly stable runs.
What branch of the UFS-Aerosols are you using? Is this the feature/p7.1?
On Mon, Aug 23, 2021 at 9:42 AM lipan-NOAA @.***> wrote:

Case Details:
cd /scratch1/NCEPDEV/stmp4/Li.Pan/COM/firex_1/logs/2019070100
grep -ni "pm25 max" gfs.forecast.highres.log
8390: pm25 max = 2101.25335386130 min = 9.947723530538242E-027
11148: pm25 max =<PHONE_NUMBER>26711 min = 9.823742736999839E-027
13858: pm25 max =<PHONE_NUMBER>.33169 min = 9.681838852327386E-027
16568: pm25 max = 2.147749677365294E+020 min = 9.730520599258893E-027
Model Configuration Details

Resolution: C384L64
Begin Date:<PHONE_NUMBER>
End Date:<PHONE_NUMBER>
Cold Start: True
Forecast length (FHMAX_GFS): 24 hours
FV3 output: every 6 hours

Aerosol Model Configuration
rcfile=/scratch2/NCEPDEV/naqfc/Li.Pan/save/data/NASA/rc.firex
logfile=/scratch1/NCEPDEV/stmp4/Li.Pan/COM/firex_1/logs/2019070100/gfs.forecast.highres.log
rundir=/scratch2/NCEPDEV/stmp1/Li.Pan/chem202108/firex_1
homgfs=/scratch2/NAGAPE/arl/Li.Pan/global-workflow
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/noaa-oar-arl/UFS-Aerosol-Config/issues/20, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIUVN424KJQC7YHV24OZTLT6JF2HANCNFSM5CUTVLZQ
.

@bbakernoaa It happened everywhere near the surface for all species. I did not do any changes on scavenging settings, which are defined in rc.file.  And I compared my rc.file to Kate's, except for extdata.rc and history.rc, there are no big differences. Since I am focusing on engineering test at this moment, I don't think it will make big differences.
I am still using feature/aerosols, and I am going to upgrade it to feature/p7.1.

@lipan-NOAA. I highly suggest you upgrade to feature/p7.1 there a few fixes
in it and use the develop branch of this repository for the configuration
files.
Could you provide some plots?
Btw the scavenging factors are not set in the .rc files. The values must be
present in those values but only used internally for nasa. The values used
in UFS-Aerosols are found in your case yaml file.
Please use the configuration repository so that we can keep track of
setting and are sure of the co figurations. We went through this with GEFS
and were never completely sure what exactly was being done.
On Mon, Aug 23, 2021 at 12:43 PM lipan-NOAA @.***>
wrote:

@bbakernoaa https://github.com/bbakernoaa It happened everywhere near
the surface for all species. I did not do any changes on scavenging
settings, which are defined in rc.file. And I compared my rc.file to
Kate's, except for extdata.rc and history.rc, there are no big differences.
Since I am focusing on engineering test at this moment, I don't think it
will make big differences.
I am still using feature/aerosols, and I am going to upgrade it to
feature/p7.1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/noaa-oar-arl/UFS-Aerosol-Config/issues/20#issuecomment-903938307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFIUVN5WDSWLJNDK4ZDWYVDT6J3ELANCNFSM5CUTVLZQ
.

@lipan-NOAA - Your global-workflow directory (/scratch2/NAGAPE/arl/Li.Pan/global-workflow/sorc/ufs_coupled.fd) shows that your experiment used a code revision not recommended for testing:
url: https://github.com/ufs-community/ufs-weather-model
hash: 22613e8 (July 20)
This version does not include a crucial update to the convective transport that fixes the unrealistic high mixing ratios you reported. The update was applied on August 12.
Please follow the instructions listed in issue #14 and do not use model revisions other than those recommended in issue #14.


Drkey juan pr7

7 / 7
Initial changes from @juagargi are complete with this PR.

This change is

go/lib/drkey/suite.go, line 15 at r2 (raw file):
Previously, Oncilla wrote…
The design here is to simple and does not extend well. See comments on PR #41
The design should be similar to the beacon + beaconstorage in the beacon server
packages:

drkeystorage (imports drkey)

defines the interface of a drkey Store

drkey  (must not import drkeystorage)
defines the SV, Lvl1, Lvl2 keys.
defines  the concrete implementation of drkeystorage.Store
defines a DB interfaces. Implementations are in subpackages (see: beacondbsqlite). This interface is used for database interactions.
defines the protocol interface
drkey/drkeydbsqlite
concrete implementation
drkey/protocol
list of known protocols mapping to their implementation.

The Store interface will be a useful abstraction. Initially, I suggest dropping the cache.
When we add it later (if needed) this can be done transparent to callers.
I also suggest you split the Store into multiple "views".
e.g.

sciond will not care about anything else but Lvl2 keys
CS will care about SV + Lvl1 keys

I think the following types would be nicer to work with:

type DRKey struct{
  Key common.RawBytes
}

type SVMeta struct {
  Epoch Epoch
}

type SV struct {
  SVMeta
  DRKey
}

type Lvl1Meta struct {
  Epoch Epoch
  SrcIA addr.IA
  DstIA addr.IA
}

type Lvl1 struct {
  Lvl1Meta
  DRKey
}

type Lvl2Meta struct {
  Epoch Epoch
  SrcIA addr.IA
  SrcHost  addr.HostAddr
  DstIA addr.IA
  DstHost  addr.HostAddr
  KeyType  Lvl2Type
  Protocol string
}

type Lvl2 struct {
  Lvl2Meta
  DRKey
}

then the protocol could be something like:
type Protocol interface {
  DeriveLvl2(meta Lvl2Meta, key Lvl1) Lvl2
}

go/lib/drkey/suite.go, line 15 at r2 (raw file):
Previously, Oncilla wrote…
I think the following types would be nicer to work with:

type DRKey struct{
  Key common.RawBytes
}

type SVMeta struct {
  Epoch Epoch
}

type SV struct {
  SVMeta
  DRKey
}

type Lvl1Meta struct {
  Epoch Epoch
  SrcIA addr.IA
  DstIA addr.IA
}

type Lvl1 struct {
  Lvl1Meta
  DRKey
}

type Lvl2Meta struct {
  Epoch Epoch
  SrcIA addr.IA
  SrcHost  addr.HostAddr
  DstIA addr.IA
  DstHost  addr.HostAddr
  KeyType  Lvl2Type
  Protocol string
}

type Lvl2 struct {
  Lvl2Meta
  DRKey
}

then the protocol could be something like:
type Protocol interface {
  DeriveLvl2(meta Lvl2Meta, key Lvl1) Lvl2
}

I agree with almost everything. What I still don't see is how we can have different flows for the key derivation. I.e. from the design doc we have at least two flows: the L2 derived from L1 (thus requires L1) and another flow for the L2 derived from the DS (requires the DS, but not the L1: in fact, waiting to receive the L1 should fail, as the idea for this flow is not to communicate the L1 but the DS).
The derivation can share the same signature (the needed base key is just bytes) but not the same data flow.
My proposal is to configure each protocol to have two values:

Data flow (needs L1 or DS)
Derivation algorithm (same signature) DeriveLvl2(meta Lvl2Meta, base []byte) (Lvl2Key, error)

It is not as flexible as fully configuring the data flow (e.g. with instrospection) and algorithms for each step, although I don't think we need that flexibility thus we should keep it much simpler.

go/lib/drkey/suite.go, line 15 at r2 (raw file):
Previously, juagargi (Juan A. García Pardo Giménez de los Galanes) wrote…
I agree with almost everything. What I still don't see is how we can have different flows for the key derivation. I.e. from the design doc we have at least two flows: the L2 derived from L1 (thus requires L1) and another flow for the L2 derived from the DS (requires the DS, but not the L1: in fact, waiting to receive the L1 should fail, as the idea for this flow is not to communicate the L1 but the DS).
The derivation can share the same signature (the needed base key is just bytes) but not the same data flow.
My proposal is to configure each protocol to have two values:

Data flow (needs L1 or DS)
Derivation algorithm (same signature) DeriveLvl2(meta Lvl2Meta, base []byte) (Lvl2Key, error)

It is not as flexible as fully configuring the data flow (e.g. with instrospection) and algorithms for each step, although I don't think we need that flexibility thus we should keep it much simpler.

I do not understand what you are trying to say.
I think it is important to think about how this API is going to be used:
ClientView:
From the clients point of view, no derivation is necessary. It just asks the store for the lvl2 DRKey.
CS:
The CS will use the protocol API to derive keys.
If Src is local:

derive lvl1 key from SV
derive lvl2 using Protocol.DeriveLvl2
If Src is remote:
read lvl1 from store
derive lvl2 using Protocol.DeriveLvl2

Note, that it does not matter whether the protocol uses a derivation secret or not. The logic will be implemented in DeriveLvl2
Delagated Svc:
The delegated service will only serve protocols that support delegation.

read delegation secret from store
derive lvl2 using DelegationProtocol.DeriveLvl2FromDelegtation

I thought I have written this already down, but I did not find it anymore.
You then have the 2 interfaces:
type Protocol interface {
  Name() ProtocolType
  DeriveLvl2(meta Lvl2Meta, key Lvl1) Lvl2
}

// DelegationSecret is the delegation secret.
type DelegationSecret struct{}

type DelegationProtocol interface {
  Protocol
  DeriveLvl2FromDelegtation(meta Lvl2Meta, key DelegationSecret) Lvl2
}

The CS will always just use the Protocol abstraction.
The Delegation service will always use the DelegationProtocol abstraction
All protocols that support delegation MUST implement DelegationProtocol.
In the code we then have basically a registry (as simple as a map) where protocols can register themselves with. (If we want to, we can have a separate registry for delegation Protocols)
var Registry map[ProtocolType]Protocol

Or more elaborate:
type Registry struct {
  default map[ProtocolType]Protocol
  delegation map[ProtocolType]DelegationProtocol
}

func (r *Registry) AddDefault(protocol Protocol) {
    if _, ok := r.default[p.Name()]; ok {
      panic("registering same protocol with different types")
    }
    r.default[p.Name()] = p
    return
}

func (r *Registry) AddDelegation(protocol DelegationProtocol) {
    if _, ok := r.default[p.Name()]; ok {
      panic("registering same protocol with different types")
    }
    r.default[p.Name()] = p
    return
}

fuinc (r *Registry) Get(protocol ProtocolType) (Protocol, bool) {
  if p, ok := r.default[protocol]; ok {
    return p, true
  }
  p, ok := r.delegation[protocol]
 return p, ok
}


fix L1 Shorting Rewards memory leak

Description

The Shorting Rewards section on L1 is doing a fetch for each currency, then updating the gasInfo based on the requests.
I'm not sure why this was done this way, since each result of the API call is overwritten by the subsequent result. e.g. the call for sETH overwrites the result from the previous call to sBTC.
Removing these fetches altogether takes care of the memory leak issue.
Related issue

https://github.com/Kwenta/kwenta/issues/231
Motivation and Context

How Has This Been Tested?

If you visit L1 shorts and pop open the Performance Monitor tab in Chrome Dev Tools, you'll now see the CPU usage steadily in the single digits (as opposed to 100+, as it's currently behaving in production)

Screenshots (if appropriate):

Make sure you update dev too


fix(sdk): use plan change api if user is already subscribed

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.37%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5987

Relevant Lines:
14472

💛  - Coveralls


Use actionproxy from dockerSkeleton do not clown and own is the motto FTW!

Closes #3

No more clowning around!

@rabbah bump


feat: support rename table

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
support parsing the RENAME TABLE statements in the parser and execute the rename statement
Checklist

[x]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)
closes #723

It looks like there may be some issue with CI. PTAL
cc @killme2008 @evenyag @waynexia

It looks like there may be some issue with CI.

You could click the details to see which test failed.
--- STDERR:                   catalog::remote_catalog_tests tests::test_rename_table ---
thread 'tests::test_rename_table' panicked at 'called `Result::unwrap()` on an `Err` value: EmptyValue { backtrace: Backtrace(   0: <snafu::backtrace_shim::Backtrace as snafu::GenerateImplicitData>::generate
             at /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/snafu-0.7.3/src/backtrace_shim.rs:15:19
      <catalog::error::EmptyValueSnafu>::build
             at src/error.rs:24:17
   1: <catalog::error::EmptyValueSnafu>::fail::<bool>
             at src/error.rs:24:17
   2: <catalog::remote::manager::RemoteCatalogManager as catalog::CatalogManager>::rename_table::{closure#0}
             at src/remote/manager.rs:470:24
   3: <core::pin::Pin<alloc::boxed::Box<dyn core::future::future::Future<Output = core::result::Result<bool, catalog::error::Error>> + core::marker::Send>> as core::future::future::Future>::poll
             at /rustc/935dc07218b4bf6e20231e44eb9263b612fd649b/library/core/src/future/future.rs:124:9
   4: remote_catalog_tests::tests::test_rename_table::{closure#0}
             at tests/remote_catalog_tests.rs:296:13

It looks like there may be some issue with CI.

You could click the details to see which test failed.
--- STDERR:                   catalog::remote_catalog_tests tests::test_rename_table ---
thread 'tests::test_rename_table' panicked at 'called `Result::unwrap()` on an `Err` value: EmptyValue { backtrace: Backtrace(   0: <snafu::backtrace_shim::Backtrace as snafu::GenerateImplicitData>::generate
             at /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/snafu-0.7.3/src/backtrace_shim.rs:15:19
      <catalog::error::EmptyValueSnafu>::build
             at src/error.rs:24:17
   1: <catalog::error::EmptyValueSnafu>::fail::<bool>
             at src/error.rs:24:17
   2: <catalog::remote::manager::RemoteCatalogManager as catalog::CatalogManager>::rename_table::{closure#0}
             at src/remote/manager.rs:470:24
   3: <core::pin::Pin<alloc::boxed::Box<dyn core::future::future::Future<Output = core::result::Result<bool, catalog::error::Error>> + core::marker::Send>> as core::future::future::Future>::poll
             at /rustc/935dc07218b4bf6e20231e44eb9263b612fd649b/library/core/src/future/future.rs:124:9
   4: remote_catalog_tests::tests::test_rename_table::{closure#0}
             at tests/remote_catalog_tests.rs:296:13

This PR changes lots of crates, I think it might be difficult to test and review these changes. I'm afraid the PR doesn't add enough tests to cover most cases, especially for the mito table engine and the storage engine. I'd recommend dividing the PR into several parts, each affecting a few crates, as the tracking issue #723  lists.
As for this PR, you could only retain the changes to the parser, but throw an error to tell users this feature is not supported yet.

This PR changes lots of crates, I think it might be difficult to test and review these changes. I'm afraid the PR doesn't add enough tests to cover most cases, especially for the mito table engine and the storage engine. I'd recommend dividing the PR into several parts, each affecting a few crates, as the tracking issue #723 lists.
As for this PR, you could only retain the changes to the parser, but throw an error to tell users this feature is not supported yet.

OK, thanks for your suggestion. I will close this pr and split these changes into several prs for submission.


feat(multireplicasnapshot): remove multi replica snapshot checks in dataplane

Let's add some tests as well

Added the test for multi-replica snapshot. Will more fault cases from control-plane BDD.

Depends on what type of fault cases, all paths should be tested in this repo only, it's not the control-plane's CI responsibility to find bugs in this repo..

Let's add some tests as well

Added the test for multi-replica snapshot. Will more fault cases from control-plane BDD.

Depends on what type of fault cases, all paths should be tested in this repo only, it's not the control-plane's CI responsibility to find bugs in this repo..

I was indicating the cross node fault scenarios. As part of other review comments, cover error scenarios which can fail in dataplane explicitly.

bors try

bors merge


add a manpage

Would you consider adding a manpage? I've seen https://github.com/restic/restic/issues/31 and doc/Manual.md, but I mean a manpage as in man restic :-). I would help packaging.

Something like the output of "./restic --help" would be OK.

Yeah, good idea.

Here is a suggestion. I'd appreciate some general feedback, before I proof-read and clean it up.
As I seem not to be able to upload a ".1" file here, please get it
[https://cloud.dahlberg.cologne/index.php/s/VHeiASfAMcVBCsB](from my ownCloud).
Written in mdoc; View using:
$ mandoc ./restic.1 | $PAGER
$ nroff -mdoc ./restic.1 | $PAGER

Huh, thanks a lot for your work! Are you aware of any generated that can be used to generated the manpage from a readable format? I don't speak nroff/troff and I'd really like to avoid learning another language...

asciidoctor works fine for manpages.

Some features only work native workflow. Such as semantic markup of flags, arguments, environment variables etc. in a way that they may be searched by man/whatis/apropos. Also man pages usually follow a certain style (eg. standard section names and sequences), which the other tools do not support.
But if you do not want a "real" full featured man page, but just something that may be started with "man restic" and looks close enough, pod2mdoc seems to be somewhat popular. Here on github, some people seem to have workflows for markdown to man and of course there is pandoc, which converts almost every type of formatted text into every other.
Here's the ultimate resource:
http://mdocml.bsd.lv/
Especially:
http://manpages.bsd.lv/history.html
http://manpages.bsd.lv/
http://mdocml.bsd.lv/man/mdoc.7.html

since Sphinx is already used to build the readthedocs html, why not just use the same tool with -b man and generate ( a bit to verbose ) man page as well ?

Cobra can generate man pages. I did not look closer into this, but since restic already uses cobra this might be a easy way to get man pages. What do you think?

That's possible, and would be nice because we can have inline documentation for the commands. It would need some automation to generate a man page for restic and all the sub commands, which is updated regularly (especially for releases).

I think having the man pages generate by cobra is the way to go, so we have the same documentation inline and in the man pages and don't need to write (and update) another document.

Is someone working on this?

I've started


[Feature] Create Fastify Plugin 🖲

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
NodeJS agent skywalking plugin for fastify server.
Use case
I want skywalking to trace on my nodejs fastify server. I'm using graphql on fastify [nodejs].
Related issues
No response
Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, as many of this kind of requests, we don't follow this.
We only provide dev docs, and pull request review.


Support background highlighting for code blocks

🚀 The feature, motivation and pitch
Support background highlighting for code blocks.
As a great example, again, we can refer to this great tool:
https://github.com/d0c-s4vage/lookatme
https://lookatme.readthedocs.io/en/latest/
The screenshot is better than the thousand words:

Does this improve readability? Hell yes!
Alternatives
No response
Additional context
No response

Also taking a look at this plugin gives nice ideas too:
https://github.com/MeanderingProgrammer/markdown.nvim


Having column name different from "password" causes error "ok"

In my DB the column name for password is, say, my_column_name_for_password.
Configuring auth query like this:
auth.mysql.auth_query = select my_column_name_for_password from my_table where my_username_column = '%u' limit 1

results in this "wonderful" error in logs:
`2017-05-19 11:55:46.687 [error] <0.413.0>@emqttd_protocol:process:202 Client(paho89953546151409@<IP_ADDRESS>:63668): Username 'user here' login failed for {{case_clause,{ok,[<<"my_column_name_for_password">>],[[<<"password here">>]]}},[{emq_auth_mysql,check,3,[{file,"d:/emqtt/v2.1.2/emq-relx/deps/emq_auth_mysql/src/emq_auth_mysql.erl"},{line,42}]},{emqttd_access_control,auth,3,[{file,"d:/emqtt/v2.1.2/emq-relx/deps/emqttd/src/emqttd_access_control.erl"},{line,60}]},{emqttd_protocol,authenticate,2,[{file,"d:/emqtt/v2.1.2/emq-relx/deps/emqttd/src/emqttd_protocol.erl"},{line,491}]},{emqttd_protocol,process,2,[{file,"d:/emqtt/v2.1.2/emq-relx/deps/emqttd/src/emqttd_protocol.erl"},{line,182}]},{emqttd_client,received,2,[{file,"d:/emqtt/v2.1.2/emq-relx/deps/emqttd/src/emqttd_client.erl"},{line,311}]},{gen_server2,handle_msg,2,[{file,"d:/emqtt/v2.1.2/emq-relx/deps/emqttd/src/gen_server2.erl"},{line,1046}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}

It took me a while to figure out that I must change query to this:
auth.mysql.auth_query = select my_column_name_for_password as password from my_table where my_username_column = '%u' limit 1

Could you at least mention that in documentation? Thanks!

auth.mysql.auth_query = select my_column_name_for_password as password from my_table where my_username_column = '%u' limit 1

That's what I wrote.

Dude, you need to update documentation for that.
Simply closing the issue as "invalid"? Not cool, dude, not cool at all.

@mvmn Is it a common sense to use 'select as'?

No.
The documentation mentions nothing about field name "password" being mandatory, so there doesn't seem to be any reason to add "as password" there.
I'm not sure about Erlang, but in other programming languages it's very easy to just take column by index, so if query returns is supposed to return one string column - it's (columns) name can be ignored by code, and it's value can be just taken by index (first column of resulting row).
However, since in your code it is not the case, and column name is used instead - it should be mentioned in documentation that that particular column name is mandatory.
Also a clearer error message would be nice.
Although if you think of it, the fix to take column by index (take first column of row) would be even better. Just ignore the column name - why bother. The query should return only one column anyway.

Hi @mvmn, Thanks for your suggestion. Please help review the latest README that we updated just now. Would you like to submit a PR for this issue if the documentation is still not enough?

Sure.
I see you've added my_column_name_for_password as password to README, but then reverted it:
https://github.com/emqtt/emq-auth-mysql/commit/ad55f8d1891c674e0534689ac3495e1ccceb43a8
It was fine that way I suppose, not sure why the revert.

Made a PR
https://github.com/emqtt/emq-auth-mysql/pull/57

@mvmn The PR #58  has been merged.


change https://erp.iitkgp.ernet.in/ to https://erp.iitkgp.ac.in/

The ernet one is throwing some privacy error now.

Oh yeah, Thanks, changing RN!
On Sun, 28 Jul 2019 at 23:06, Sangeet Kumar Mishra<EMAIL_ADDRESS>wrote:

The ernet one is throwing some privacy error now.
[image: image]
https://user-images.githubusercontent.com/24244580/62010745-3721a380-b18c-11e9-90b7-6786ca51dca5.png
You can view, comment on, or merge this pull request online at:
https://github.com/xypnox/gyft2/pull/3
Commit Summary

change https://erp.iitkgp.ernet.in/ to https://erp.iitkgp.ac.in/

File Changes

M README.md https://github.com/xypnox/gyft2/pull/3/files#diff-0
(2)

Patch Links:

https://github.com/xypnox/gyft2/pull/3.patch
https://github.com/xypnox/gyft2/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xypnox/gyft2/pull/3?email_source=notifications&email_token=AF7KDS4BTT5M75POFWURYWTQBXKH7A5CNFSM4IHNA5N2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HB5D3XA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7KDSZRV4O76LBFTHUBWN3QBXKH7ANCNFSM4IHNA5NQ
.


Hello, Stranger Things

Hi fans!

Saw this being used in Stranger Things just now as I finally got around to watching the new season lmao

Saw this being used in Stranger Things just now as I finally got around to watching the new season lmao

I don't know what can I do, so close and lock.


Network Error when saving settings (v0.1.0)

Here's a recording of the issue. https://www.loom.com/share/097c1609db1c48398246619cc5595009

In the network tab of developer tools, the failing request is a request to POST https://moufette.universaldatatool.com/graphql, fails with 400 error. Here's the response:
{"errors":[{"message":"Variable \"$property\" of required type \"ID!\" was not provided.","locations":[{"line":1,"column":39}],"extensions":{"code":"INTERNAL_SERVER_ERROR","exception":{"stacktrace":["GraphQLError: Variable \"$property\" of required type \"ID!\" was not provided.","    at _loop (/home/ec2-user/moufette/node_modules/graphql/execution/values.js:94:17)","    at coerceVariableValues (/home/ec2-user/moufette/node_modules/graphql/execution/values.js:121:16)","    at getVariableValues (/home/ec2-user/moufette/node_modules/graphql/execution/values.js:50:19)","    at buildExecutionContext (/home/ec2-user/moufette/node_modules/graphql/execution/execute.js:206:61)","    at executeImpl (/home/ec2-user/moufette/node_modules/graphql/execution/execute.js:104:20)","    at Object.execute (/home/ec2-user/moufette/node_modules/graphql/execution/execute.js:63:35)","    at /home/ec2-user/moufette/node_modules/apollo-server-core/dist/requestPipeline.js:249:48","    at Generator.next (<anonymous>)","    at /home/ec2-user/moufette/node_modules/apollo-server-core/dist/requestPipeline.js:8:71","    at new Promise (<anonymous>)","    at __awaiter (/home/ec2-user/moufette/node_modules/apollo-server-core/dist/requestPipeline.js:4:12)","    at execute (/home/ec2-user/moufette/node_modules/apollo-server-core/dist/requestPipeline.js:228:20)","    at Object.<anonymous> (/home/ec2-user/moufette/node_modules/apollo-server-core/dist/requestPipeline.js:176:42)","    at Generator.next (<anonymous>)","    at fulfilled (/home/ec2-user/moufette/node_modules/apollo-server-core/dist/requestPipeline.js:5:58)"]}}}]}

Hi @seveibar
sorry for the late reply. did you manage to solve this issue?
if not I promise I will look into it this weekend

We didn't, we just left the defaults in!


chore: observer the animation box without route change

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #542 (8dc6dad) into dev (76d6fad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #542   +/-   ##
=======================================
  Coverage   95.89%   95.89%
=======================================
  Files         217      217
  Lines        5167     5167
  Branches      983      983
=======================================
  Hits         4955     4955
  Misses        205      205
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d6fad...8dc6dad. Read the comment docs.


 What happened to the previously list of companies icons near the bottom of the page? I think those were great.
Comment 2. Could we use a var instead of using text directly, we may consider to support i18n.
Discuss with qiujian16, for comment 1 some wording and icons are not accurate, so decide not to include it right now. We can have more discussion on that. For comment 2 no need to worry about it right now. We can add this feature in the future.

/approve
/lgtm

@SkrPaoWang unfortunately https://github.com/open-cluster-management-io/open-cluster-management-io.github.io/pull/120 was merged prior to the DCO check was activated.
I think you will have to amend the https://github.com/open-cluster-management-io/open-cluster-management-io.github.io/pull/127/commits/09ef07c335b1dd647694c1ce3db68e4982238926 and then force push your branch.

/lgtm


Remove the phrase "Adobe Creative Cloud Teams"

Changed the sentence to remove the "Teams" word from the note as Adobe Creative Cloud has Teams version.
Changed the prerequisites to Adobe Creative Cloud for Enterprise.

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions

This article does not require any next steps, so I have not added it. SaaS app tutorials are not TOC integrated.
Our toc is here: https://docs.microsoft.com/en-us/azure/active-directory/active-directory-saas-tutorial-list
#sign-off