iOS OOM crash on GDTCORFlatFileStorage

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.0
Firebase SDK version:

FirebasePerformance (3.3.0):
    - FirebaseCore (~> 6.9)
    - FirebaseInstallations (~> 1.5)
    - FirebaseRemoteConfig (~> 4.7)
    - GoogleDataTransport (~> 7.0)

Installation method: CocoaPods
Firebase Component: Performance

[REQUIRED] Step 2: Describe the problem
we got an oom crash, the firebase don't catch the crash.we use some other method got this crash stack.
-[GDTCORFlatFileStorage pathsForTarget:eventIDs:qosTiers:mappingIDs:onComplete:]_block_invoke_2 (in xxx) (GDTCORFlatFileStorage.m:681)

[GDTCORFlatFileStorage checkForExpirations]_block_invoke (in xxx) (GDTCORFlatFileStorage.m:0)

Most of the crash user are crash when start input message. when start input the memory useage increase fast.
Steps to reproduce:
I can't reproduce.
Relevant Code
Any help apperciate.

Can you run an Instruments trace with the latest version of FirebasePerformance?

Can you run an Instruments trace with the latest version of FirebasePerformance?

i can't reproduce this crash.

Even if you cannot get the app to crash, it would still be useful to see the memory spike and allocations that happen when the user starts inputting a message.

I got the same issue, all those people are from china Mainland, Is it possible to the sdk to keep trying something ?

This potentially may be related to #6903.

I'll investigate on my end if GoogleDataTransport may lead to excessive memory usage in the case of bad network connectivity.
@KorolZhu The info on your application memory usage is still needed as the core reason of the  may be outside Firebase. Thanks!

@maksymmalyhin @morganchen12
Hello, Let me first describe the issue I encountered
The user opens the app, and then opens the app's memory usage display and CPU usage display.  you will see that the memory keeps growing, and the speed is very fast. In about one minute, it grows to 2098M (OOM limit), and then crash.
in the whole process the CPU usage always being in 60% - 90%
Then I integrated oom monitoring. When oom happens, I grab the stack information. The main stack information is as follows (not very perfect, I can only take a look at it)
{
"tag": "MemStat",
"info": "",
"scene": "",
"name": "Malloc 1.78 KiB",
"size":<PHONE_NUMBER>, （Memory size allocated：1036M）
"count": 597754,
"stacks": [
{
"caller": "5a94c9aac64532278938f578b18c9b9c@20415780",
__44-[GDTCORFlatFileStorage checkForExpirations]_block_invoke (in HelloTalk_Binary) (GDTCORFlatFileStorage.m:0)
                "size":<PHONE_NUMBER>,
                "count": 597754,
                "frames": [
                    {
                        "uuid": "32e63b4b0cb63798a0d0ceb99793bb08",
                        "offset": 62940

                        libsystem_malloc.dylib

                    },
                    {
                        "uuid": "32e63b4b0cb63798a0d0ceb99793bb08",
                        "offset": 65616

                        libsystem_malloc.dylib

                    },
                    {
                        "uuid": "14223db57ae5302a9495de26da6f9724",
                        "offset": 102720

                        Foundation

                    },
                    {
                        "uuid": "14223db57ae5302a9495de26da6f9724",
                        "offset": 331816

                        Foundation
                    },
                    {
                        "uuid": "14223db57ae5302a9495de26da6f9724",
                        "offset": 331624

                        Foundation
                    },
                    {
                        "uuid": "5a94c9aac64532278938f578b18c9b9c",
                        "offset": 20415780

                        __44-[GDTCORFlatFileStorage checkForExpirations]_block_invoke (in HelloTalk_Binary) (GDTCORFlatFileStorage.m:0)

                    },
                    {
                        "uuid": "e749b178a64d336383ef863a6073a06b",
                        "offset": 8500

                         libdispatch.dylib

                    },
                    {
                        "uuid": "e749b178a64d336383ef863a6073a06b",
                        "offset": 13740

                         libdispatch.dylib

                    },
                    {
                        "uuid": "e749b178a64d336383ef863a6073a06b",
                        "offset": 39524

                         libdispatch.dylib

                    },
                    {
                        "uuid": "e749b178a64d336383ef863a6073a06b",
                        "offset": 42136

                         libdispatch.dylib
                    },
                    {
                        "uuid": "e749b178a64d336383ef863a6073a06b",
                        "offset": 80476

                         libdispatch.dylib
                    },
                    {
                        "uuid": "1fb3935b8af63f3cbb260b1f8e6f6fcd",
                        "offset": 14104

                         libsystem_pthread.dylib
                    },
                    {
                        "uuid": "1fb3935b8af63f3cbb260b1f8e6f6fcd",
                        "offset": 39368

                         libsystem_pthread.dylib
                    }
                ]
            }
        ]
    }

According to the above stack information, it is preliminarily determined that it is the firebase SDK problem, and then I try to modify the source code of the SDK：

Continue to contract out to the user for verification, but the problem is not solved, the memory will continue to grow, but the growth is very slow, and the CPU utilization rate is still the same.
Then I went on to try to modify it as follows：
1、print the directory file count : xxx/Library/Caches/google-sdks-events/, then remove this path
2、remove Firebase/Core Firebase/Analytics Firebase/Performance Firebase/Crashlytics, and remove all those call: [FIRAnalytics logEventWithName:@"xxx" parameters:xxx];
3、remove this call [FIRApp configure];

Continue to contract out to the user for verification, and the user's log is printed as follows：
2020/11/19 23:03:52:574  --google googleSDKEvent, count: 64045
2020/11/19 23:03:52:574  --google batchContents, count: 0
2020/11/19 23:03:52:574  --google eventContents, count: 63893
2020/11/19 23:03:52:574  --google libraryContents, count: 3

Then when users install the package, they will be stuck in the startup screen when they open the application (maybe because there are too many directory files in Google sdkevent, so it takes a lot of time to remove them?) When the user tries to open the app for many times, it will be normal, and the CPU and memory consumption are at normal levels. So it was confirmed that 100% of the oom was caused by firebase SDK
Then extract the user log again：
2020/11/20 09:53:35:933  --google googleSDKEvent, count: 7
2020/11/20 09:53:35:933  --google batchContents, count: 0
2020/11/20 09:53:35:933  --google eventContents, count: 4
2020/11/20 09:53:35:933  --google libraryContents, count: 0

So can you identify the problem from what I described above？
Is googleSDKEvent can not uploaded to Google servers in Chinese mainland?  and  led to an increase in the number of those events cache. and when the number is large, and the user open the app, the sdk keep try upload or something?
need help, thanks

@KorolZhu Thank you for your investigation, it is really helpful!
We are working on the optimization of the events cleanup logic for such a big amount of pending events.
GoogleDataTransport debug logs will be very helpful to understand how so many events were accumulated on the devices. You can enable debug logging by following these steps. @KorolZhu Would it be possible to share the logs?
Note:
It would be interesting to understand why so many events accumulated on the device. It may be either because of a huge amount of events logged or the events not being sent or both. Firebase Performance and Firebase Crashlytics use GoogleDataTransport SDK to send data to the backend. As Crashlytics usually logs only one event per app startup I would assume that the main source of the events is Performance traces. @KorolZhu Does the application log any custom performance traces? If so, reducing amount of them may mitigate the issue a bit.

@maksymmalyhin
Hi, My application does not use any custom performance traces, I just integrated performance SDK through pod, without any code call related to performance SDK。
The GoogleDataTransport debug log (When I integrated performance SDK)
And I did some experiments as follows:
First I added some logs in  this method didFinishLaunchingWithOptions:

After I integrated performance SDK, Every time I start the app(just start app, not use app), dozens of new files will be generated, and the number of files never decreases

After I integrated performance SDK, Every time I start the app, and scroll some table view (lots of image will download), Hundreds of new files will be generated, and the number of files never decreases

After I removed performance SDK, Only 2 new files are generated each time app is started, No matter how you use the app

@KorolZhu Thank you for the provided logs. Entires like the following indicate that the device with the issue cannot reach the Firebase endpoint:
There was an error uploading events: Error Domain=NSURLErrorDomain Code=-1001 "请求超时。" UserInfo={_kCFStreamErrorCodeKey=-2102, NSUnderlyingError=0x283a2c030 {Error Domain=kCFErrorDomainCFNetwork Code=-1001 "(null)"

It may be because of some network restrictions, firewall settings, connectivity issues, etc. It means that the part of application that relies on GoogleDataTransport will not function on such devices (currently Firebase Performance and Crashlytics rely on GoogleDataTransport).
On our end we will optimize the code for such cases to prevent performance degrading in the case of a big amount pending events. But it won't fix the connectivity issue and the app missing features.

@KorolZhu I'm closing the issue so far. After the optimization done in #7014 the big amount pending events should not lead to the OOM crashes. The change scheduled for the next Firebase release, but you may test the version of GoogleDataTransport from master. Your feedback is appreciated.
Please note that #7014  fixes only the excessive memory usage and doesn't fix the server reachability issue that you experience.
Feel free to comment  or reopen the issue with additional info if needed.

@maksymmalyhin  This only fixes the excessive memory usage issue caused by a large number of local events, but as long as I integrate firebase performance SDK, there will be more and more pending events, this large number of events will take up disk space and may consume CPU resources? Is there any way to continue to optimize, such as setting a maximum number of pending events, and replacing the oldest events when the number exceeds this number, or Is it possible to fix the server reachability, For example, provide a proxy setting to let my server upload these events.

@KorolZhu As the API to register a custom endpoint to send events to - it is an interesting idea. I'm not sure it solve the issue because, e.g. if the client has a network with a very restrictive firewall the proxy server endpoint may be blocked as well, so it doesn't looks like a universal solution. You may try to suggest the affected users to the global proxy or VPN settings on their devices to test if this approach works. You may create a separate ticket with a feature request describing the use case and the proposed solution, so we may keep a focused discussion there.
As for further optimization. Currently the amount of events is limited by the combined on-disk size to 20MB, so no new events will be added to the storage until older events are sent or removed due to expiration. We keep experimenting  with other types of limit looking for a proper balance between the implementation complexity, supported use cases and performance. Potentially more updates are expected in the future.
Also we are working with Firebase Performance team to reduce storage utilization without compromising accuracy of the performance metrics (cc @visumickey b/168729571).
Your feedback is appreciated and will be taken into account in the future optimization work. Feel free to the Profiler traces or other measurements along with the use case description that may be helpful.


Deprecation warning for version 2025.5

Heey,
Today I noticed this deprecation warning
WARNING (ImportExecutor_0) [homeassistant.helpers.typing] HomeAssistantType was used from speedport, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'speedport' custom integration

2025.5 is still a while ahead, though better to early than to late 😸

I had create a pull request for it.
https://github.com/Andre0512/speedport/pull/21


test update

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

This pull request is fixing a bug in the existing swagger definition, which has a “ImageUrl” string query parameter instead of the url being passed on as a json within the request body as in the APIM documentation here:  https://westus.dev.cognitive.microsoft.com/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236
so this is not a breaking change, but rather a bug fix and the failing tests should be ignored.
The pull request is also fixing a couple broken links in the auto-generated docs.
Example:
In this
link the text: "PersonGroup - Train" should refer to here.

/azp run automation - sdk

/azp run automation - sdk

@nabilat, am guessing that you need the autogenerated sdks for each language to be updated to reflect the doc changes made here?
Am not sure about the other languages, but javascript for sure has not released an update.
@jhendrixMSFT, Is there a separate process to be followed here to have the sdks updated?
cc @lmazuel

@ramya-rao-a I believe the next step is to go to http://aka.ms/openapihub to submit a request to release updated SDKs (click "Request SDK release").

Thanks @jhendrixMSFT
@nabilat, Have you made the request at  http://aka.ms/openapihub ?


⚠ GitLab Server has degraded performance

In 14acb49, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11005 ms

Resolved: GitLab Server performance has improved in 2919317.


Builds do not start on OKD / OpenShift

After following the instructions, the builds do not work on the latest OKD 4.11 from the current CRC.
The OpenShift instructions for Tekton show the setup of a service account with anyuid:
https://tekton.dev/docs/pipelines/install/ (OpenShift tab, which mentions a non-existing system account ?).
Unfortunately that does not seem to work.
I can imagine that because of the kvm plugin it uses something may go wrong on CRC ( OpenShift Local ) ?
I would just think that when building OKD images, OKD on CRC would be a logical choice, so whatever is needed should be documented, or mentioned that it does not work following the instructions.

A workaround for installation is :

after tekton installation, switch to the project logged in as kubeadmin : oc project tekton-operator
Then run the commands to allow the proper rights as described in the install docs
oc adm policy add-scc-to-user anyuid -z tekton-pipelines-controller
oc adm policy add-scc-to-user anyuid -z tekton-pipelines-webhook
then : oc apply -k overlays/local should complete without problems

After that, I never get a pod with:
$ kubectl get all -n okd-coreos-pipeline
NAME                               DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/device-plugin-kvm   0         0         0       0            0                     5m5s

A lot has change in this repo and we're not explicitly supporting CRC. I'll close but please feel free to re-open if the issue still persists.


Input quantity on Item Script Containers

I'd like to request quantity input control for custom items.
Example item: https://one.denizenscript.com/haste/66591
I had hoped to sort-of add quantity via a tag to the input items. Unfortunately, this does not work, and the recipe fires with 5x 1 item, as opposed to 5x 32 items.
Thank you.

If a vanilla recipe can't do it, an item script one can't either. Item script recipes just inject new recipes to the vanilla crafting handler.
You can try to hack it based on crafting events but uh... good luck making that work.


Unable to load gzippet nifti files from AWS

Hi, it seems it's not possible to load a gzipped nifti file from AWS, i think it's cause because the file url doesn't end in .gz, it ends with ?X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Algorithm=...
It takes very long to decompress and load a nifti file.

Found the problem to load NIFTI files from AWS: /home/eduardo/Projects/neurocloud.es/node_modules/ami.js/src/core/core.utils.js
ex: data.query = 'X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIENAUPLLEGRXA3FA%2F20180710%2Feu-central-1%2Fs3%2Faws4_request&X-Amz-Date=20180710T114949Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Signature=e654c37b329794426dc320ccb9a379043e53f10ae806b840dd706901a9a7d031'
if (data.query) {
  // Find "filename" parameter value, if present
  data.filename = data.query.split('&').reduce((acc, fieldval) => {
    let fvPair = fieldval.split('=');
    if (fvPair.length > 0 && fvPair[0] == 'filename') {
        acc = fvPair[1];
        console.info(fvPair,'found');
    }
    return acc;
  });
}

If, filename is not found "acc" always has the first value of the acumulator, in this case "X-Amz-Content-Sha256=UNSIGNED-PAYLOAD" instead of ""


Segmentation fault with Deno Test

I felt on case looking close what is described upstream in https://github.com/rust-lang/rust/issues/88737. What debugging steps could be made in order to isolate further the issue (e.g. Deno and/or Rust and/or deeper)?

Please provide a reproduction and output from your terminal, otherwise we're guessing in the blind.

@bartlomieju That was painful to derive but here we go. Can you try on your end?
// src/lib.rs
use deno_bindgen::deno_bindgen;
use tokio::runtime::Runtime;

#[deno_bindgen]
fn ping() {}

#[deno_bindgen(non_blocking)]
fn start() {
    let rt = Runtime::new().unwrap();
    rt.block_on(F::new());
}

pub struct F {}

impl F {
    pub async fn new() {
        ()
    }
}

# Cargo.toml
[package]
name = "native"
version = "0.1.0"
edition = "2021"

[lib]
name = "native"
crate-type = ["cdylib"]

[dependencies]
deno_bindgen = "0.5.1"
tokio = { version = "1.19.2", features = ["full"] }

// a_test.ts
import * as native from "./bindings/bindings.ts";

Deno.test("a", async () => {
  await native.start();
})

// b_test.ts
import * as native from "./bindings/bindings.ts";

Deno.test("B", async () => {
    await native.ping();
})

# develop
cargo clean
deno_bindgen

deno test --unstable --allow-all a_test.ts
> Check file:///home/zifeo/metatype/typegate/a_test.ts
> running 1 test from ./a_test.ts
> a ... ok (6ms)
>
> ok | 1 passed | 0 failed (55ms)

deno test --unstable --allow-all b_test.ts
> Check file:///home/zifeo/metatype/typegate/b_test.ts
> running 1 test from ./b_test.ts
> B ... ok (4ms)
>
> ok | 1 passed | 0 failed (41ms)

deno test --unstable --allow-all b_test.ts a_test.ts
> Check file:///home/zifeo/metatype/typegate/b_test.ts
> Check file:///home/zifeo/metatype/typegate/a_test.ts
> running 1 test from ./b_test.ts
> B ... ok (3ms)
> running 1 test from ./a_test.ts
> a ... ok (6ms)
>
> ok | 2 passed | 0 failed (147ms)

deno test --unstable --allow-all a_test.ts b_test.ts
> Check file:///home/zifeo/metatype/typegate/a_test.ts
> Check file:///home/zifeo/metatype/typegate/b_test.ts
> running 1 test from ./a_test.ts
> a ... ok (6ms)
> 'deno test --unstable --allow-...' terminated by signal SIGSEGV (Address boundary error)

# production
cargo clean
deno_bindgen --release

deno test --unstable --allow-all a_test.ts b_test.ts
> Check file:///home/zifeo/metatype/typegate/a_test.ts
> Check file:///home/zifeo/metatype/typegate/b_test.ts
> running 1 test from ./a_test.ts
> a ... ok (5ms)
> running 1 test from ./b_test.ts
> B ... ok (4ms)
>
> ok | 2 passed | 0 failed (57ms)

@bartlomieju That was painful to derive but here we go. Can you try on your end?
// src/lib.rs
use deno_bindgen::deno_bindgen;
use tokio::runtime::Runtime;

#[deno_bindgen]
fn ping() {}

#[deno_bindgen(non_blocking)]
fn start() {
    let rt = Runtime::new().unwrap();
    rt.block_on(F::new());
}

pub struct F {}

impl F {
    pub async fn new() {
        ()
    }
}

# Cargo.toml
[package]
name = "native"
version = "0.1.0"
edition = "2021"

[lib]
name = "native"
crate-type = ["cdylib"]

[dependencies]
deno_bindgen = "0.5.1"
tokio = { version = "1.19.2", features = ["full"] }

// a_test.ts
import * as native from "./bindings/bindings.ts";

Deno.test("a", async () => {
  await native.start();
})

// b_test.ts
import * as native from "./bindings/bindings.ts";

Deno.test("B", async () => {
    await native.ping();
})

# develop
cargo clean
deno_bindgen

deno test --unstable --allow-all a_test.ts
> Check file:///home/zifeo/repro/a_test.ts
> running 1 test from ./a_test.ts
> a ... ok (6ms)
>
> ok | 1 passed | 0 failed (55ms)

deno test --unstable --allow-all b_test.ts
> Check file:///home/zifeo/repro/b_test.ts
> running 1 test from ./b_test.ts
> B ... ok (4ms)
>
> ok | 1 passed | 0 failed (41ms)

deno test --unstable --allow-all b_test.ts a_test.ts
> Check file:///home/zifeo/repro/b_test.ts
> Check file:///home/zifeo/repro/a_test.ts
> running 1 test from ./b_test.ts
> B ... ok (3ms)
> running 1 test from ./a_test.ts
> a ... ok (6ms)
>
> ok | 2 passed | 0 failed (147ms)

deno test --unstable --allow-all a_test.ts b_test.ts
> Check file:///home/zifeo/repro/a_test.ts
> Check file:///home/zifeo/repro/b_test.ts
> running 1 test from ./a_test.ts
> a ... ok (6ms)
> 'deno test --unstable --allow-...' terminated by signal SIGSEGV (Address boundary error)

# production
cargo clean
deno_bindgen --release

deno test --unstable --allow-all a_test.ts b_test.ts
> Check file:///home/zifeo/repro/a_test.ts
> Check file:///home/zifeo/repro/b_test.ts
> running 1 test from ./a_test.ts
> a ... ok (5ms)
> running 1 test from ./b_test.ts
> B ... ok (4ms)
>
> ok | 2 passed | 0 failed (57ms)

@littledivy can you take a look?

@littledivy @bartlomieju Let me know if you need something else, this is definitely a blocker for the FFI.


Unable to open input stream for resource netty-common-4.1.16.Final.jar

Hi - When am trying to use the pushy jar with netty jars on IBM WAS, it gives me an error on my server startup. I googled but could not find any solution. Can you pls help me with it?
Error:
com.ibm.ws.ecs.internal.scan.context.impl.ScannerContextImpl scanJAR unable to open input stream for resource io/netty/util/internal/shaded/org/jctools/queues/package-info.class in archive WEB-INF/lib/netty-common-4.1.16.Final.jar
Pls let me know if you need more details.

Hello!
This sounds more like a request for general support than it does like a bug report or a feature request. We generally ask people to move these kinds of questions to the Pushy mailing list because:

The mailing list has a wider audience, and you're more likely to find somebody who has experience with your particular circumstances on the mailing list.
Posting your question to the mailing list can help other people who are having the same problem.
Because there isn't a bug to fix or a feature to add, we can't reasonably solve your problem by making any kind of engineering change.

I emphasize that we'd be happy to help, but let's move this conversation to a different venue.


Release 1.0.0

@davkal @foot @ekimekim @bowenli @jpellizzari @tomwilkie @jml @abuehrle @pidster @errordeveloper This is a major release, please chip in by testing this release branch in the scenarios below and tick off what you tested afterwards (including your name at the end).
EDIT: To make things  easier to test I have pushed the image weaveworks/scope:release-1.0-cd1e06b
Thanks!

[x] Start a 2 node cluster and leave a UI connected, watch for performance regression (Done by @2opremio)
[x] Run a Scope cluster on ECS (Done by @2opremio)
[x] Run Scope on https://github.com/microservices-demo/microservices-demo/
[x] Run Scope on Docker For Mac
[x] Start and stop Scope in standalone mode

[x] Linux
[x] docker-machine

[x] Connect probes from release candidate to Weave Cloud

[x] Local scope in probe-only mode connects to Weave Cloud and renders correctly

[x] dev
[x] prod

[x] Controls appear for containers and function correctly (Done by @2opremio)

[x] dev
[x] prod

[x] No new errors in logging or telemetry

[x] dev
[x] prod

Things to think about

Kubernetes Integration
CPU and memory usage

Won't have time before the release, sorry.

I've tested on

SockShop locally (docker compose)
D4M
dev

Thanks @pidster. Can you tick it off from the check list?

I've ticked off the things I've tested

@fons I tested the latest on my ubuntu host and probes are not showing up in Weave Cloud, btw.
It does start and stop, though.

It allowed me to include a command twice, i.e.: weave launch weave launch token=<xxxx>

@abuehrle you mean scope launch, right?

Yes,  I meant scope launch.  I will log this issue for you.   Probably a whole lot more tests we could do there as well.

I've tested docker-machine on MacOS.

Start a 2 node cluster and leave a UI connected, watch for performance regression

I actually updated the probes in the dev cluster https://github.com/weaveworks/service-conf/pull/324 and I observed they are consuming ~70% CPU which is pretty horrible but I don't think it's a regression. I am getting a CPU profile just in case.

Here it goes, nothing new is spiking up. However, conntrack's XML parser seems to be consuming too much CPU. I have noticed how the parser was less than optimal, but 42% CPU is big enough to consider switching to another parser.

@2opremio is it worth replacing the conntrack parser if there's an alternative to conntrack in the pipe?

@pidster Please comment in the relevant issue https://github.com/weaveworks/scope/issues/1991
This issue is for the release (and we are not going to replace the parser before then)


How to select which repeat code to merge?

I woke up to many amazing pull requests this morning: #2, #3, #4, #5, #6.
What is the best way for me to select one to merge as well as honor others contributions? Should I just decide? Vote? Just do whatever @meiamsome says (this is my usual approach to coding)?
One idea I have is to merge them one at a time by order of submission. And let each subsequent pull request have a chance to refactor and improve?

My level of English does not allow me to present my code correctly. But I try despite all;)
I use your method with a Command Object allowing more flexibility later and no regex.
The integration of the parser allows little change in the original code (sketch.js).
But the criterion for choosing a code is, in my opinion, to be able to understand it first and foremost. That said I want to have a return on my proposal elsewhere ( if it's possible ).

#10 implemented more functions so maybe it would be neat since you would have more in one pull?

New commands I added were actually "invented" by me (I had no idea Logo is an existing language and there is a specification), at the same time I don't see any ways it might be harmful. I tried to preserve "convenient" structure and style of Logo language.

Make a vote and  people ar not able to vote it self

I have a implementation where i have been working on for a couple months (in java).

I ended up just doing my own  in #24!


Indexer

wow, what is this code is trying to do?
I don't sit very well with this code base

Sorry, it’s my fault. This code is my experiment to integrate psql indexer for modules handler. I forked to aura-sql and now it’s not part of this project


Add ability to update client's secret

This PR allows developers to write a migration that would update secret of an existing client.

Hey @mfolnovic I will make sure to release your change ASAP :)

Released with version 0.2.74. @mfolnovic  could you verify if it works for you?

@klg71 thank you for quick reaction, I've verified that release works as expected :)


Include Vanity address generator

It would be cool to be able to generate accounts with a "vanity" address (a nice looking address) directly from the app.
Base for a native lib could be https://github.com/paberr/nimiq-vanity-miner

Yeah, I like the idea! I will add this feature, soon.


Implement help preview for local package(s)

Addresses #637, replaces #644.
This PR implements a preview feature for the help pages based on .Rd files in the current directory:

If a requested help-topic-path matches one of the present .Rd files, this file is converted to html and shown instead of the original help page
The R side bar contains a new item which lists all of the help topics from local .Rd files
If local files change, help previews are updated accordingly
The setting "r.helpPanel.previewLocalPackages" controls which (sub)directories are checked for local packages. By default this is just the main workspace folder (["."]), but subdirectories can be specified. The feature can be disabled by setting this to [].

Some possible future improvements are:

~Preview meta files (DESCRIPTION, Index)~
Toggle between installed help/preview per page
Performance improvements (?)

When I'm trying with RMariaDB, I wonder why R/MariaDBResult.R, R/dbIsValid_MariaDBResult.R do not have links to the files in the workspace in the following help page

When I'm trying with RMariaDB, I wonder why R/MariaDBResult.R, R/dbIsValid_MariaDBResult.R do not have links to the files in the workspace in the following help page

I wasn't aware that there can be multiple R file references in a single .Rd file. Should be fixed with the last commit.

Thanks for the quick fix! Another one is following where the workspace folder appears for some reason?

Thanks for the quick fix! Another one is following where the workspace folder appears for some reason?

Turns out there can even be line breaks in the list of related R files. Should work with the latest commit.

The original entries become the following

Also, "Open Help Topic using ?" will have duplicate entries regarding the package under development:

I noticed that there is an issue with special characters if R's default encoding on the machine is not utf-8. If you know a simple way to e.g. set R's stdout to utf-8, please let me know.


Renaming the repo

Going through the README.md suggests that the name of the repository can be changed to a more intuitive one.
Links with #2

Perhaps "CAM Gravity Wave PyTorch Emulator"?
With details about how it forms a training pipeline on the comments.

I agree with Jack.  or just "CAM Gravity Wave Emulator"


nested ordered lists not rendering

Reproducible in the demo at https://markdown-it.github.io/:

It appears rendering for ordered lists is also ignoring line breaks (visible above).

Elements of the nested lists should be aligned to the first non-space character of the parent list item.
For example, this is nested list:
1. Parent item
   1. Nested list item

But this one is not:
1. First item
  1. Second item (not a nested list)

Because the first has three spaces and the second has two? I don't understand how that doesn't qualify.
The nested unordered list directly above it is using two spaces:
Unordered

+ Create a list by starting a line with `+`, `-`, or `*`
+ Sub-lists are made by indenting 2 spaces:
  - Marker character change forces new list start:
    * Ac tristique libero volutpat at
    + Facilisis in pretium nisl aliquet
    - Nulla volutpat aliquam velit
+ Very easy!

Just as an example here is how github is rendering the same list above when ordered:

Create a list by starting a line with +, -, or *
Sub-lists are made by indenting 2 spaces:
Marker character change forces new list start:
1. Ac tristique libero volutpat at
1. Facilisis in pretium nisl aliquet
1. Nulla volutpat aliquam velit
Very easy!

and here is how markdown-it is rendering it:

@ngoldman have you read the commonmark spec? It has more of the reasoning I believe.

Ah, I see. Thanks @vyp. This was a stylistic variation of CommonMark I was not familiar with. Since markdown-it is 100% CommonMark I guess my argument is invalid. The second thing I noticed is also invalid -- the ordered lists are rendering correctly, it's just the style of the site that makes them look like they're part of the same list. Thanks for the lesson.

The second thing I noticed is also invalid -- the ordered lists are rendering correctly, it's just the style of the site that makes them look like they're part of the same list.

Sorry for being annoying, but I don't see this? Perhaps I've inputted the wrong example? https://markdown-it.github.io actually has a 'permalink' button you can click on after you have inputted your text (so you didn't have to take screenshots), could you do that because I'm a bit curious? Thanks in advance!

Closed - works as needed (according to CM spec)

@vyp https://markdown-it.github.io/#md64=eyJzb3VyY2UiOiJPcmRlcmVkXG5cbjEuIExvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0XG4yLiBDb25zZWN0ZXR1ciBhZGlwaXNjaW5nIGVsaXRcbjMuIEludGVnZXIgbW9sZXN0aWUgbG9yZW0gYXQgbWFzc2FcblxuXG4xLiBZb3UgY2FuIHVzZSBzZXF1ZW50aWFsIG51bWJlcnMuLi5cbjEuIC4uLm9yIGtlZXAgYWxsIHRoZSBudW1iZXJzIGFzIGAxLmBcblxuXG4xLiB0aGlzIGxpc3QgbG9va3Mgd2VpcmRcbjEuIGJ1dCBpdCdzIGp1c3QgYSBDU1MgdGhpbmcgbm90IGEgbWFya3VwIHRoaW5nIHNvIGl0J3Mgbm90IGFuIGlzc3VlXG5cbjEuIGhvd2V2ZXIgdGhpcyBzZWVtcyBsaWtlIGFuIGlzc3VlIGFzIGl0IHNob3VsZCBiZSB0aGUgc3RhcnQgb2YgYSBuZXcgbGlzdCAtLSB1bmxlc3MgdGhhdCdzIGFub3RoZXIgQ29tbW9uTWFyayB0aGluZyBJJ20gdW5hd2FyZSBvZlxuXG4xLiBzZWUgd2hhdCBJIG1lYW4gLS0gYWZhaWsgdGhpcyBzaG91bGQgYmUgIzEgbm90ICM0XG5cblN0YXJ0IG51bWJlcmluZyB3aXRoIG9mZnNldDpcblxuNTcuIGZvb1xuMS4gYmFyXG4iLCJkZWZhdWx0cyI6eyJodG1sIjpmYWxzZSwieGh0bWxPdXQiOmZhbHNlLCJicmVha3MiOmZhbHNlLCJsYW5nUHJlZml4IjoibGFuZ3VhZ2UtIiwibGlua2lmeSI6dHJ1ZSwidHlwb2dyYXBoZXIiOnRydWUsIl9oaWdobGlnaHQiOnRydWUsIl9zdHJpY3QiOmZhbHNlLCJfdmlldyI6Imh0bWwifX0=

@ngoldman Ah okay I see. I think the "this list looks weird" is due to being wrapped in <p> tags, but not sure.

unless that's another CommonMark thing I'm unaware of

Indeed, I believe you're using 'loose' lists here. I think example 203 (and so on) might help clear things.

:+1: CommonMark !== GFM


[BUG] org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testList - Flaky Test

Describe the bug
The tests fail in tearDown
java.lang.AssertionError: AcknowledgedResponse failed - not acked
Expected: <true>
     but: was <false>
	at __randomizedtesting.SeedInfo.seed([A1A7B8410230F86A:260E9455E87A563E]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked(OpenSearchAssertions.java:125)
	at org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked(OpenSearchAssertions.java:129)
	at org.opensearch.test.TestCluster.wipeIndices(TestCluster.java:181)
	at org.opensearch.test.TestCluster.wipe(TestCluster.java:92)
	at org.opensearch.test.OpenSearchTestClusterRule.afterInternal(OpenSearchTestClusterRule.java:323)
	at org.opensearch.test.OpenSearchTestClusterRule.after(OpenSearchTestClusterRule.java:188)
	at org.opensearch.test.OpenSearchTestClusterRule$1.evaluate(OpenSearchTestClusterRule.java:374)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)

Failed Build
Related component
Build
To Reproduce
REPRODUCE WITH: ./gradlew ':modules:reindex:test' --tests "org.opensearch.index.reindex.ReindexBasicTests.testMultipleSources" -Dtests.seed=A1A7B8410230F86A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-HN -Dtests.timezone=America/North_Dakota/New_Salem -Druntime.java=21

Expected behavior
Test should pass
Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Triage - attendees 1 2 3 4 5 6 7]
@rajiv-kv Thanks for filing

[Triage - attendees 1 2 3 4 5 6 7]
Second look - the reproduction does not align with the issue title, its unclear what next steps are.  Please open a new issue with consistent details.


🛠Fix Input Field Text Color Visibility Issue

Related Issue
“None”
Fixes:  #1388
Description
This PR updates the text color in input fields to improve visibility. Previously, the white text color made it difficult to read against similar background colors.
Type of PR

[x] Bug fix

Screenshots
Before

After

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@akash70629 There are conflicts merging your pr . Create a new pr


Update MD file on new branch 2017-26-14_21-11-58

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Vocabulary symbols

Hello everyone, is it possible to add new symbols to the vocabulary? For example I can see that the "toy set" vocabulary contains the whole alphabet a-z plus a blank character. Is it possible to just add "!", "?", ",", "." to this text file, so that sentiment analysis after transcription can be more accurate?
Thank you.

Sure, it is possible. But you'll need a labeled speech dataset with all these symbols. Of course, the larger dataset the better. Normalized LibriSpeech doesn't have such characters. Another option is to train a punctuation prediction model on a large text corpus and then use it to post-process ASR transcriptions.

@vsl9 , thank you for the response, however if I use the comma symbol wouldn't it mess up the csv file that is being read during train/validation mode?

We use pandas for parsing csv files. It should work fine with commas if a transcript with a comma is inside double quotas:
wav_filename,transcript
0000.wav,there is no comma
0001.wav,"here is a comma , symbol"

Thank you @vsl9 .


Packagist Versioning

When are you planning to do a x.y.z numerical versions of the package?
It'd be nice to have the ability to "djlambert/doctrine2-spatial" : "0.1.*"  so I can have the updates over time instead changing the version names for each revision.
I'd like to do something other than dev-master, preferably.

Tag 0.1 now available !   0.2 will probably come soon :wink:


Add icons to NetAtmo sensors

There seem to be a bunch of git commits that shouldn't be there. Can you branch off a fresh dev branch and add your commit?

Done.


wrong use of flask.globals resulting in unpredictable behaviour and possibly a big waste of your time

in flask_sijax.py:
def _on_before_request(self):
g.sijax = self
...
g's scope is the app context, not the request context

the issue was not with the use of g but with the fact that flask_sijax.py basically uses a global var to store the per request instanciated sijax object, resulting in unwanted behaviour.
Anyway, I think I've fixed the issue by doing a find and replace of self._sijax to request.sijax.
Replace all g.sijax with request.sijax. (also in your htmls) and it should be fine.
If someone is still interested in using this lib, I've attached the modified version of flask_sijax.py.
flask_sijax.py.tar.gz

Is this a regression with some new version of Flask?
It's been working fine for me and I've never encountered any issue. Nor have I heard of anyone else report it.
I'm not doing any Python web development anymore, but.. If you'd like to submit a PR with this or any other fixes, I'd be happy to merge them and release a new version of Flask-Sijax, etc.

It may well be due to a change in Flask. This issue only occurs when during processing of one sijax request another sijax request with a different path is made.t I'm using this lib at the moment so I'll do some more testing to make sure my changes work correctly before doing a PR.


[BUG] Databricks pass through authentication doesn’t work for any read operation

When using Rapids plugin with Databricks pass through authentication doesn’t work for any read operation (outside of dbfs)
when selecting from delta tables “Security Token Expired” error is displayed.
Steps/Code to reproduce bug
When creating Databricks cluster enable pass through authentication on standard cluster. Issue select statement on any delta table which is not on dbfs.
Expected behavior
Pass through authentication should work.
Environment details (please complete the following information)

Environment : Databricks 8.2 runtime on Azure

Spark configuration settings related to the issue
Pass through authentication enabled on Databricks runtime environment 8.2

Additional context
Add any other context about the problem here.
All functionality works as intended when data is on dbfs

@jlowe You are right.
I just used latest 21.12 snapshot jars and verified that https://github.com/NVIDIA/spark-rapids/issues/3903 is fixed.
However when writing dataframe to blob storage using passthrough auth, the issue still exists.
Here is my reproduce statement:
<EMAIL_ADDRESS>
It will fail with:
Caused by: org.apache.spark.SparkException: Job aborted due to stage failure: Task 1 in stage 25.0 failed 4 times, most recent failure: Lost task 1.3 in stage 25.0 (TID 488) (<IP_ADDRESS> executor 0): java.util.concurrent.ExecutionException: com.databricks.backend.daemon.data.client.adl.AzureCredentialNotFoundException: Could not find ADLS Gen2 Token
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
	at com.nvidia.spark.rapids.MultiFileCoalescingPartitionReaderBase.$anonfun$readPartFiles$7(GpuMultiFileReader.scala:820)
	at com.nvidia.spark.rapids.MultiFileCoalescingPartitionReaderBase.$anonfun$readPartFiles$7$adapted(GpuMultiFileReader.scala:819)
	at scala.collection.Iterator.foreach(Iterator.scala:941)
	at scala.collection.Iterator.foreach$(Iterator.scala:941)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
	at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
	at com.nvidia.spark.rapids.MultiFileCoalescingPartitionReaderBase.$anonfun$readPartFiles$4(GpuMultiFileReader.scala:819)
	at com.nvidia.spark.rapids.Arm.closeOnExcept(Arm.scala:87)
	at com.nvidia.spark.rapids.Arm.closeOnExcept$(Arm.scala:85)
	at com.nvidia.spark.rapids.FilePartitionReaderBase.closeOnExcept(GpuMultiFileReader.scala:236)
	at com.nvidia.spark.rapids.MultiFileCoalescingPartitionReaderBase.$anonfun$readPartFiles$1(GpuMultiFileReader.scala:804)
	at com.nvidia.spark.rapids.Arm.withResource(Arm.scala:28)
	at com.nvidia.spark.rapids.Arm.withResource$(Arm.scala:26)
	at com.nvidia.spark.rapids.FilePartitionReaderBase.withResource(GpuMultiFileReader.scala:236)

As @jlowe shared, setting spark.rapids.sql.format.parquet.reader.type=PERFILE can workaround this issue.
When spark.rapids.sql.format.parquet.reader.type=COALESCING or MULTITHREADED, the issue can be reproduced.

Moving to the backlog as the PERFILE option resolved the issue for the time being.

Moving to the backlog as the PERFILE option resolved the issue for the time being.

Has there been any performance measurements done on the workaround?  PERFILE will likely perform noticeably worse than the default, and that may influence the priority.


P/Invoke Documentation

I was planning on compiling my complex application using CoreRT, but it uses a lot of P/Invoke (and more than a little COM interop). After reviewing the source code and issues/PRs, I have come to the conclusion that P/Invoke on CoreRT requires different techniques (more unsafe methods, C# pointers, and manual conversion of types) than P/Invoke on CoreCLR. In addition, COM interop would be significantly more complicated due to the abstractions used under CoreCLR (ComImportAttribute et al) not being implemented here.
Unfortunately, I have found very little documentation as to what changes are required, and what functionality is not implemented. Could you please provide a file in the Documentation directory or something detailing what changes are required when porting a P/Invoke-heavy codebase from CoreCLR to CoreRT? Thanks!

CoreRT is not far enough to compile complex applications yet. We do plan do have fully interop support via MCG tool eventually, but it will take a while.
cc @yizhang82

@wjk As @jkotas mentioned, we are actively working on porting over MCG tool (from .NET native) to CoreRT to enable p/invoke scenarios and the same support would most likely still available to you in CoreRT. However, we don't have a plan to port the COM interop support yet (but it's definitely doable, and we can even support simple COM interop in other OS through simple COM ABI rules). Just curious - what kind of COM interop scenarios you have in mind with CoreRT?

@yizhang82 The COM interop I have in mind is that required to enable calls into COM required for Windows integration in GUI apps (IFileDialog, ICustomDestinationList, and ITaskbarList4 in particular).

@wjk I have initial support for mcg based interop enabled in latest CLI bits.To enable you need use compile-native directly 'dotnet compile-native --enableinterop '.I have tested some very basic scenarios on windows and linux.As @yizhang82 mentioned we are actively working on it and it's very likely that you will run in to bugs.I will more than happy to help you with any issues.


no-conditional-statement

Replaces no-if-statement

Codecov Report

Merging #23 into master will increase coverage by 0.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   89.67%   90.12%   +0.44%
==========================================
  Files          28       28
  Lines         397      415      +18
  Branches       71       77       +6
==========================================
+ Hits          356      374      +18
  Misses         33       33
  Partials        8        8

Impacted Files
Coverage Δ

src/configs/functional.ts
0% <ø> (ø)
:arrow_up:

src/configs/all.ts
0% <ø> (ø)
:arrow_up:

src/util/rule.ts
100% <ø> (ø)
:arrow_up:

src/rules/no-conditional-statement.ts
100% <100%> (ø)

src/rules/index.ts
100% <100%> (ø)
:arrow_up:

src/util/typeguard.ts
82.08% <100%> (+1.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7e898...a1b1e77. Read the comment docs.

@jonaskello I've added an option to ignore conditional statements if each branch contains a return statement. What name do you think we should go with for this option? For now I've named it "allowReturningStatements".
Note: This option only checks the defined branches, not all possible branches. So the following example would not be a violation despite the fact that there is no else return statement (or final return statement for the function).
const foo = (() => {
  if (condition) {
    return value;
  }
})();

Checking all possible branches is possible and I may add that option in future. However, the option would need to (or at least should try to) avoid collision with the no-else-return rule making it a little more difficult to implement. We should probably come up with a name for this option now as well.

Nice work!
Yes, I can see how no-else-return would make it more difficult since then we need to check the whole function. IMO best-practice when using an if or switch to emulate an expression would be to have all cases fully covered (like in pattern-matching). For switch there is the default-case rule that requires it to be fully covered by a default case. I guess the equivalent for if would be a rule that requires else to be present but it seems there is no such rule.
One way to go would be to not do the fully covered checking in no-conditional-statment but instead delegate that to the default-case rule for switch and for if implement an equivalent new rule that requires an else part to be present. However, if you emulate conditional expressions by putting if-statments in separate functions you might want to have the return at the end instead of an else so not sure what is best here. My feeling right now is that having an else required is the best option since it keeps the if statement self-contained and so it is easier to see it as an expression. Looking at the do-expressions proposal they have an example with if which uses else, but I don't think that would be required, it would probably allow any expression at the end outside of the if statement instead of an else branch.

Regarding the option name, perhaps something like ignoreReturn or allowReturn? Or perhaps allowReturningBranches to be more explicit. I haven't checked the code but I guess with this option the error reporting could be per-branch?

I've renamed the option to allowReturningBranches. It can now be set either to a boolean or to "onlyIfExhaustive". All branches must be defined if "onlyIfExhaustive" is specified (if statements require else statements, switch statements require default cases).
I've asked a question over at microsoft/TypeScript to see if it is possible to check for exhaustive switches that don't have a default case.
Other than that, I think this PR is ready.

Perhaps allowReturningBranches: "onlyIfExhaustive" could be shortened to allowReturningBranches: "ifExhaustive" without loosing any clarity?
Other than that I think this is good to go :-).


Provide defaults for using JAVA_HOME cacerts for proxy / client creation

There are cases where we may just want to use the trusted certs from the default cacerts file from JAVA_HOME when no Optional<SSLSocketFactory is provided.
Not exactly sure where the best spot to put the default would be, or if we should be making it more explicit?
A few options I see are as follows:

Adding an else after the ClientProvider classes (ie. https://github.com/palantir/http-remoting/blob/develop/http-clients/src/main/java/com/palantir/remoting/http/FeignClientFactory.java#L229) that pulls the java home cacerts location
Create new method signatures (ie. createProxyWithCaCerts(..) or something along those lines)

Thoughts?

I haven't confirmed this empirically, but I would have expected OkHttp to
use the Java default certs/sslsocketfactory if none is explicitly provided?
On Sat, Jun 25, 2016 at 10:56 AM Cody Moore<EMAIL_ADDRESS>wrote:

There are cases where we may just want to use the trusted certs from the
default cacerts file from JAVA_HOME when no Optional<SSLSocketFactory is
provided.
Not exactly sure where the best spot to put the default would be, or if we
should be making it more explicit?
A few options I see are as follows:

Adding an else after the ClientProvider classes (ie.
https://github.com/palantir/http-remoting/blob/develop/http-clients/src/main/java/com/palantir/remoting/http/FeignClientFactory.java#L229)
that pulls the java home cacerts location
Create new method signatures (ie. createProxyWithCaCerts(..) or
something along those lines)

Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/palantir/http-remoting/issues/145, or mute the thread
https://github.com/notifications/unsubscribe/AGOdwWfHBBL72tU_6XNKCvLwSxV56b9Mks5qPWuigaJpZM4I-ZVf
.

Hmm good point, it looks like it does at quick glance, but I will attach a debugger and see what I can find.

I poked around a bit and it seems like the implementation that OkHttp uses for grabbing the SSLContext uses an impl of the TrustManagerFactoryImpl that uses the jssecacerts file first before the cacerts file.
From TrustManagerFactoryImpl:
var2 = new File(var9 + var7 + "lib" + var7 + "security" + var7 + "jssecacerts");
                    if((var3 = getFileInputStream(var2)) == null) {
                        var2 = new File(var9 + var7 + "lib" + var7 + "security" + var7 + "cacerts");
                        var3 = getFileInputStream(var2);
                    }

Which means that if we follow the standard directions of trusting the Palantir CA in our cacerts file we end up not being able to get the appropriate trust chain.
I handled this by removing the jssecacerts file on my local machine, but I am not sure about this kind of guarantee on Circle, etc.  What do you think the best way to handle this would be?

This priority seems to be correct w.r.t. to Java spec:
http://docs.oracle.com/javase/7/docs/technotes/guides/security/jsse/JSSERefGuide.html#X509TrustManager
On Mon, Jun 27, 2016 at 12:57 PM Cody Moore<EMAIL_ADDRESS>wrote:

I poked around a bit and it seems like the implementation that OkHttp uses
for grabbing the SSLContext uses an impl of the TrustManagerFactoryImpl
that uses the jssecacerts file first before the cacerts file.
From TrustManagerFactoryImpl:
var2 = new File(var9 + var7 + "lib" + var7 + "security" + var7 + "jssecacerts");
if((var3 = getFileInputStream(var2)) == null) {
var2 = new File(var9 + var7 + "lib" + var7 + "security" + var7 + "cacerts");
var3 = getFileInputStream(var2);
}
Which means that if we follow the standard directions of trusting the
Palantir CA in our cacerts file we end up not being able to get the
appropriate trust chain.
I handled this by removing the jssecacerts file on my local machine, but
I am not sure about this kind of guarantee on Circle, etc. What do you
think the best way to handle this would be?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/palantir/http-remoting/issues/145#issuecomment-228856894,
or mute the thread
https://github.com/notifications/unsubscribe/AGOdwYfoUeIfnF_AsY-kE0a4ZiW-rfZoks5qQCsjgaJpZM4I-ZVf
.

Not sure if I should do a workaround of explicitly using the cacerts file on my end when that priority order is the standard.  Shouldn't our circle nodes have the third gen root CA trusted then?

closing after some offline discussion.


fix: babel error - closes #11

ignore .babelrc as discussed here https://github.com/BBB/react-native-card.io/issues/11
ignore .idea as the folder currently comes when installing via npm

Thanks!


gobgp: 2.25.0 -> 2.26.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/osrg/gobgp/releases.
meta.description for gobgp is: "A CLI tool for GoBGP"
meta.homepage for gobgp is: "https://osrg.github.io/gobgp/"
meta.changelog for gobgp is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/ir2b9i9kqna6x981aidnrgfhn5n9d0yx-gobgp-2.26.0/bin/gobgp passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 2.26.0 in filename of file in /nix/store/ir2b9i9kqna6x981aidnrgfhn5n9d0yx-gobgp-2.26.0

directory tree listing: https://gist.github.com/a1ce817e08e361e1be6ae9ab3a8873f0

du listing: https://gist.github.com/b960572efd83a5c2cdd52745259b0fbd

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gobgp

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ir2b9i9kqna6x981aidnrgfhn5n9d0yx-gobgp-2.26.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gobgp https://github.com/r-ryantm/nixpkgs/archive/82cf561bbed33883f51eba8d2191542ab703f184.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ir2b9i9kqna6x981aidnrgfhn5n9d0yx-gobgp-2.26.0
ls -la /nix/store/ir2b9i9kqna6x981aidnrgfhn5n9d0yx-gobgp-2.26.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gobgp

Maintainer pings
cc @higebu @kalbasit for testing.

Result of nixpkgs-review pr 118502 run on x86_64-linux 1

1 package built:

gobgp


Add random number in filename

To avoid conflict in parallel

Related to https://github.com/ecrl/padelpy/issues/46


Please release

Please tag a version so that we could reference this library.

:+1:

Please tag.

2 years later

4 years later

https://github.com/php-lock/lock


Fix names for psp1 and vita

This commit should take care of this -
https://github.com/libretro/mrboom-libretro/blob/master/Makefile


Improve the Firebase Account Module

Improve the Firebase Account Module
:recycle: Current situation & Problem

Firebase includes some built-in password rules that we do not expose in the API
We do not display localized error messages for Firebase errors
The localization of the sign-up button is not correctly set
The application does not recognize if, e.g., a user is deleted in the Firebase Emulator or on Firebase
The application does not refresh its state when the user is logged in

Thank you to @jenlmoore for providing valuable feedback to the CardinalKit project!
:bulb: Proposed solution

Includes a password rule in the UI (at least eight characters, no whitespaces)
Adds localized descriptions for Firebase Errors
Improves the logic in the account module to use the correct localization
Automatically sets the user to nil and the account to be signed out if a user refresh token request did not succeed
Adds further logic to refresh the application if a user is signed in

Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

The failed check appears to be due to an error in a clean up step. The tests are all passing.

The clean up step failed due to the build step failing before that. I have fixed that failing dependency.
The build error failed due to wrong key in the localization files, I have fixed this 👍


Wrong sunrise data for city with longitude > 90E

Hi,
While testing your lib with city like Noumea or Auckland, I noticed big errors in sunrise calculation (for example, sunrise in Auckland returns 20:03 NZDT insted of 05:56). Sunset is ok thought (20:38 NZDT). After investigating, error appears with location with a longitude > 90 (but it seems ok with longitude < 90 thought).
The thing is, Auckland is tested in your test dataset, but I've found that all the tests made are not pertinent, because of an error in expectCorrectTimeOrNoEventCode function, as eventTime.diff(refEventTime).minutes always returns 0,  (eventTime.diff(refEventTime).as("minutes") should be used here (cf. my pull request).

Oh, wow, thanks. Seems like I made a mistake somwhere when I changed the library from moment to luxon and then made another mistake in the test code that hid it. In addition to what you mentioned, solar noon calculations seem to be broken pretty much everywhere. Will try to dig into this but of course if you can find the source of the error I would be very grateful.

I've managed to find a fix for sunrise/dusk/..., it is indeed linked to a luxon library call.
The solar noon are still broken though

Closed and will release to npm later today. Thanks again for spotting this!

Published on npm


Grad-cam for 3D CNN

Hi,
I've been trying to use your Grad CAM implementaiton on a 3D CNN. My input is a tensor of size (1, 2, 70, 70, 70), but my output is of size (2, 70, 70, 9). I don't understand that 9, do you know why ?
Thank you very much

Hi, I've been trying to use your Grad CAM implementaiton on a 3D CNN. My input is a tensor of size (1, 2, 70, 70, 70), but my output is of size (2, 70, 70, 9). I don't understand that 9, do you know why ? Thank you very much

Have you found a solution？

Did you find the solution?


CREATE TABLE foo( t text PRIMARY KEY ) fails with Table foo has no primary key

Setup
$ cargo new a && cd $_
$ diesel setup
$ diesel migration generate create_foo

up.sql
CREATE TABLE foo( t text PRIMARY KEY );

down.sql
DROP TABLE foo;

Versions

Rust:
rustc 1.33.0-nightly (bf669d1e3 2019-01-25)
Diesel:
diesel 1.4.0
Database:
PostgreSQL 11.1
Operating System
macOS Mojave 10.14.2 (18C54)

Feature Flags
None

diesel:
diesel 1.4.0

Problem Description
$ diesel migration run
Running migration 2019-01-29-055113_create_foo
Diesel only supports tables with primary keys. Table foo_tbl has no primary key

What are you trying to accomplish?
Create a simple table
What is the expected output?
Success
What is the actual output?

Diesel only supports tables with primary keys. Table foo_tbl has no primary key

Are you seeing any additional errors?
No
Steps to reproduce
$ cargo new a && cd $_
$ diesel setup
$ diesel migration generate create_foo

Then edit the up.sql and down.sql to match above.
Checklist

[ ] I have already looked over the issue tracker for similar issues.
[ ] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

I see the same issue, even though the migration ran successfully...

I cannot reproduce this with the current diesel release and the provided information, therefore I'm closing this issue. Feel free to add more information how this issue occurs.

Confirmed that it now works. Good to see!


Cloudant couchDb view still including unwanted id keys outside from the DOC

when querying couchdb, it is still sending bad formatted array of objects :
https://jose:windsurf@1c54473b-be6e-42d6-b914-d0ecae937981-bluemix.cloudant.com/footballers/_design/footballers/_view/football?include_docs=true
i only want this :
[
{mydoc1content},
{mydoc2content}
]

And it currenlty gives me this :
[
{id:1,value:1:key:1;doc:{mydoc1content}},
{id:2,value:2:key:2;doc:{mydoc2content}}
]

How to only get the docs ? not the unwanted id, key and docs values ?
I think it is called 'metadata', how to get rid of theses unwanted stuffs ? It blocks me from developping further things.
I can't use it with angularjs cause it send badly formatted array of json, please help me.
this is my map fonction
function (doc) {
  emit(doc._id, 1);
}

Github issues are for bugs only. If you have questions, you can use the mailing list, Slack or StackOverflow
You can't only the docs by querying the views. It's designed this way. You mentioned Angular. You can probably query the view and format the data the way you want it. Otherwise, there's always Mango queries that returns an object like this: {docs: [docs....]}


Make synthetic processing tests depend on methods in pipeline

Make test/emtf_synthetic/test_processing.process_sythetic_mth5_remote_reference(station_cfg1, station_cfg2)
depend on processing_config.
Then move it to pipelines as a case of process_mth5().
Best to factor process_mth5 into smaller functions that can be reused for RR processing

synthetic tests are now using pipeline codes and config.json files


tokio-epoll-uring: use it for on-demand downloads

Problem
On-demand downloads are still using tokio::fs, which we know is inefficient.
Changes

Add pagebench ondemand-download-churn to quantify on-demand download throughput

Requires dumping layer map, which required making history_buffer impl Deserialize

Implement an equivalent of tokio::io::copy_buf for owned buffers => owned_buffers_io module and children.
Make layer file download sensitive to io_engine::get(), using VirtualFile + above copy loop

For this, I had to move some code into the retry_download, e.g., sync_all() call.

Drive-by:

fix missing escaping in scripts/ps_ec2_setup_instance_store
if we failed in retry_download to create a file, we'd try to remove it, encounter NotFound, and abort() the process using on_fatal_io_error. This PR adds treats NotFound as a success.

Testing
Functional

The copy loop is generic & unit tested.

Performance

Used the ondemand-download-churn benchmark to manually test against real S3.
Results (public Notion page): https://neondatabase.notion.site/Benchmarking-tokio-epoll-uring-on-demand-downloads-2024-04-15-newer-code-03c0fdc475c54492b44d9627b6e4e710?pvs=4

Performance is equivalent at low concurrency. Jumpier situation at high concurrency, but, still less CPU / throughput with tokio-epoll-uring.
It’s a win.

Future Work
Turn the manual performance testing described in the above results document into a performance regression test: https://github.com/neondatabase/neon/issues/7146

Only got to do the performance testing now, but, I think this is a fairly safe change, so, merging it now, even if there's less soak time before the next release.


Staked balances not showing up

It could have something to do with init actions. It can introduce data inconsistencies when we miss something. Resyncing with the subgraph should be a scheduled job.

Init is a super heavy query unfortunately, I wouldn't want to run that regularly

oh, you did run the init mutation?
Hm, good point. We might want to check the logic for cow pools

fixed for cow


Histogram issue #2313 fixed

#2313 - Tornado Chart doesn't work, when "Decimal Points" >= 9999.

Looks good.


Limitations of numbers of users or session host per pool.

I would like to know do we have any limitations such as number of users per host pool or number of session host per pool? As I don’t see any limitations as such in any of the documentation. As a note I am aware of per session host there is limitation of 9999 users.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2eeca14-80ef-c0b4-2719-80ceb286ba3d
Version Independent ID: b7d3df23-3158-2807-eecc-73e7230c2033
Content: What is Windows Virtual Desktop? - Azure
Content Source: articles/virtual-desktop/overview.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@ChristianMontoya Can you please confirm if there are any limitations on number of users/session host per pool? Thanks.

@pabbinedi : No, we do not have current limits on users per host pool or number of sessions per host pool. If we do add limits for continuity of the service, we'll update the docs accordingly.

We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Add support for MQTT (publisher/subsriber protocol)

Adding support for MQTT
The PR implements the extract_response_codes_mqtt and extract_requests_mqtt functions.
I also have added a tutorial for fuzzing the MQTT broker - Mosquitto, a detailed guide can be checked under tutorials/mosquitto/README.md.

hi，Author, I have an error when testing Mosquitto with aflnet. The error says that the MQTT protocol is not supported.


Contained button with icon spacings

Description of the Feature
At MDFillRoundFlatIconButton you can see that the spacings/paddings are not correct. The right padding seems a bit too much and according to material design's button specs it should be 12 from the left, 8 between the icon and the text and 16 on the right.
I'm not sure if this a bug or a lack of feature but it doesn't feel like a bug. So I'm adding it here.
Screenshots

@BananaMasterz Yes, thanks for the question. Obviously indentations is not correct.

@BananaMasterz This is fixed, just old screenshots in the documentation


trigger.change on number input throws a warning

I'm using trigger.change on the following input:
<input type='number'>
trigger.change's new value is a string, so I'm going with the flow and using it like so:
trigger.change(input, "42");
and I get the following warning:
The specified value "42#" is not a valid number. The value must match to the following regular expression...
Using simulate.change works though...

trigger functionality was removed in v1.0.0.


Add dependency for U-Boot. Make debian tools noninteractive.

Add dependency for U-Boot.
Make debian tools noninteractive.
Change shell from dash to bash.

Thanks!


Cocoapod install step failed

Team, please have a look into this error detail:

this our podfile looks like :

Thanks for your kindly support.

Hi @tonifirnandes ,
Can you please replace the "smart quotes" around target 'HelpsterCompany' with regular single or double quotes? That will fix this issue.
I'll create an internal card to improve the error message.

Ohh and of course if you'd have any questions just let us know! :)

Thank you very much team, just noticed there are some inappropriate smart quotes in our pod file. Anyway, we have another issue, would you like to help us resolved it thanks.
helpster-bitrise-error-log.log

Glad to hear you managed to solve that issue @tonifirnandes ! :)

Anyway, we have another issue, would you like to help us resolved it thanks.

It seems that's not related to this issue, can you please create a new one? To make it easier for others to find the right one when they are searching for a solution for the same issue :)

Oke thank you very much team. i'll create new one.


RLOS output clipped when run in 3D Map in ArcGIS Pro

I ran a RLOS (Military Tools 1.0 in ArcGIS Pro 1.4.1) on sample data in 2D view using a radius of 10000 and Observer height of 300. The output looks good. I wanted to check it in 3D, so I used View> Convert 2D to 3D. The output still looked good.
I ran the tool in 3D, and the results looked mostly correct, but the edge of the RLOS circle was cut off before the edge of the surface data. Ran again and saw the same issue but cutting off the other side of the circle. See below (my red lines added for emphasis).

This does not correspond to the edge of the terrain data.

Map_3D coordinate system GCS WGS 1984.
Map (original) coordinate system WGS 1984 Web Mercator Auxiliary Sphere
Surface data coordinate system WGS 1984 UTM Zone 10N

This also happens with the Visibility component add-in.

LLOS seems to be working fine in the same area.

This is still an issue with the Add-in.

From reading the info above this is an issue with the GP tool and the Add-in. I wonder if this is a issue that we cannot control and is a core issue.

The tool runs correctly in 2D , but it does not run correctly in 3D.

I am also getting this output at times in 2D. I think this is a high priority issue. @nfeuerstein

I see that this is fixed at build #1427


Make sure 95%+ code coverage

**As a tester ...
**I need to make sure the reliability of code...
**So that I need make sure the code coverage is above 95%
Details & Assumptions:
Run the nosestests to check the coverage
Acceptance Criteria:
Make the coverage 95%+
Given a completed code
When run the nosetests
Then make sure the coverage is 95%+ and no error.

Is it necessary to set this as an independent issue? Why not require every teammate to test their work before the pull request and make sure the coverage >= 95%?


Column header binding

I believe it's a new issue introduced since 1.0.x.
Tested using the demo codepen, with {{$scope.Calories = "Calories";}}.
Bind element will be shown as the row content {{header}} rather than desired values set in js.
<mdt-header-row>
    <mdt-column>
        {{header}}
    </mdt-column>
</mdt-header-row>

Correct me if I'm supposed to use something else instead.

I'm working on it.

Fixed version released in v1.1.2

I updated the source file using bower, which is now v1.1.2. But I can't see the resolved result, as well as on the codepen. Do you need to update the dist folder?
 I'm not good at using Bower.

You completely right, sorry. Few minutes and it'll be there.

@davidcui2 please try now with v1.1.3 and tell me if it was working. Thanks!

All happy now. Good job!


[Feedback] Initial NSByteCountFormatter implementation

I used NSDateFormatter and some other classes as a reference point. Shall I continue with the implementation?

The default values look correct to me.


Switch to flit for packaging

as per https://github.com/wagtail/cookiecutter-wagtail-package

I've tested locally by comparing the builds (old vs this PR)


perf(timegrinder): Optimize DebugMatch by only extracting matched portion

Currently, DebugMatch will perform both a match and an extract against the full input. Since Match returns a start/end index, a smaller slice can be passed to Extract. This results in less work for the regexp engine.
The speed difference is highly dependent on the length of the input data and the index of the timestamp, but with my test data, this gets a 3% speed improvement.

retargeting to next-patch and updating branch.
LGTM, i'll get this approved to run through CI/CD.
Welcome and thank you for the the PR!

we are planning a release very soon and will do a merge down that will get 1.21.X out of the fold so that these CI/CD tasks complete.  Enabling automerge so everything just happens when that happens.

@ashnwade this will require a force merge as we aren't updating the go version in next-patch just yet.

Or what Kris said.

Thanks for reviewing this! Sounds good. If you guys end up bumping the version then I'll need to rebase this branch, so just let me know if you need that (I also allowed edits by maintainers so feel free to do it yourselves if you prefer)


Unbiased Watermark

Hello,
Could you help me with a sample code of Invoking watermarking algorithms for Unbias Watermark?
I know from the original paper that we can either choose delta-reweight or gamma-reweight, but from your code, I dont know how to apply to my use case.
Thank you

Thank you for your issue. We currently only support Gamma reweight, as delta-reweight significantly impacts text quality. We appreciate your suggestion and plan to add delta-reweight implementation in a future update. Thanks for helping us improve. 😊

Hello there,
Thank you for your prompt return and I really appreciate your effort to make the code run.
If you are able to run the delta-reweight, may you share the file with me? Sorry If I am asking too much.
I think it is okay to take a look at the watermarked output of delta-reweight as delta-rewieght is more logit-based watermark than gamma (in term of logic and intuition), I believe.
Actually, I am able to run the code from the original paper (link: https://github.com/xiaoniu-578fa6bff964d005/UnbiasedWatermark ) but for some reasons, it always stops at 499th data point due to the below error:
Processing input 498 of 2000
Traceback (most recent call last):
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/Gen_llama2.py", line 84, in <module>
    outputs = model.generate(
              ^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/unbiased_watermark/monkeypatch.py", line 20, in generate
    return original_generate(*args, **kargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/unbiased_watermark/monkeypatch.py", line 20, in generate
    return original_generate(*args, **kargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/unbiased_watermark/monkeypatch.py", line 20, in generate
    return original_generate(*args, **kargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  [Previous line repeated 495 more times]
  File "/network/rit/lab/Lai_ReSecureAI/kiel/anaconda3/envs/unbias_wm/lib/python3.12/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/anaconda3/envs/unbias_wm/lib/python3.12/site-packages/transformers/generation/utils.py", line 1945, in generate
    prepared_logits_processor = self._get_logits_processor(
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/unbiased_watermark/monkeypatch.py", line 23, in _get_logits_processor
    processors = original__get_logits_processor(*args, **kargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/unbiased_watermark/monkeypatch.py", line 23, in _get_logits_processor
    processors = original__get_logits_processor(*args, **kargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/network/rit/lab/Lai_ReSecureAI/kiel/Unbiased_WM/unbiased_watermark/monkeypatch.py", line 23, in _get_logits_processor
    processors = original__get_logits_processor(*args, **kargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  [Previous line repeated 495 more times]
  File "/network/rit/lab/Lai_ReSecureAI/kiel/anaconda3/envs/unbias_wm/lib/python3.12/site-packages/transformers/generation/utils.py", line 873, in _get_logits_processor
    processors = self._merge_criteria_processor_list(processors, logits_processor)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RecursionError: maximum recursion depth exceeded

Or if you can share monkeypatch.py, I would be really grateful for it.
Thank you.

Thanks for your questions. We will release the implementation of delta-reweight as soon as possible. Then you can use our code to run your experiment. 😊

Thank you Panly
Please let me know when you've released the code by commenting here.
Thank you and have a great weekend.


observe always hides when told

Description
Fixes a bug where not all observer progress bars
were staying hidden if the 'hide' configuration
was flagged.
Type of change

[x] :bug: Bugfix

Issue(s)

fixes https://github.com/alcionai/corso/issues/1569

Test Plan

[x] :muscle: Manual

Should we consider showing a one time message for event but without the progress indicator? We could consider that in a follow up as well though.
PS: I have updated the issue link in PR desc

Should we consider showing a one time message for event but without the progress indicator? We could consider that in a follow up as well though

@meain Unfortunately, progress bars and logs fight for display.  Depending on race conditions and write order, it is possible for the progress bars to erase logs as they're written to the console.  Primarily, the 'no-progress' flag is to shut down the display entirely in case we need to record the logs instead.  Keeping around one-time messages will likely keep clobbering things.


Add new BlankSlateWithTable

Add uts
Proposed Changes

Potential Breaking Changes

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1329 into master will decrease coverage by 0.02%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
- Coverage   99.45%   99.43%   -0.03%
==========================================
  Files         365      367       +2
  Lines        9171     9184      +13
  Branches     2165     2167       +2
==========================================
+ Hits         9121     9132      +11
- Misses         50       52       +2

Impacted Files
Coverage Δ

...vapor/src/components/blankSlate/BlankSlatesHOC.tsx
100% <100%> (ø)

.../src/components/blankSlate/BlankSlateWithTable.tsx
77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187860b...4d5036f. Read the comment docs.


Fix hangs from loadCommands

Fixes #91
This should fix several of the issues I was seeing with the loadCommands function

For more details, open the Copilot Workspace session.

Changeset? Tho I assume the next release will be 0.6.0 in which case the nodejs package will be removed anyway

Oh true this will be fixed by nuke anyway


Protein coverage CV term

Name:
Protein coverage
Definition:
The coverage of protein sequences from the peptide sequences identified. The table records the coverage itself, the protein accession (SHOULD correspond to the accession used in fasta document used for Sequence DB based identification), Length of the protein(, and optionally if it is a decoy entry.)
Proposed value type:

[?] n-tuple
{'coverage':[...], 'accession':[...], 'length':[...], *'TD':[...]}
*optional

Please add comments (i.e. descriptions on how to interpret the values) for the metrics.
As we also have "table" as type, this would be a better suggestion in my opinion.

@mwalzer please add comment (explanation for interpretation)

Indeed, and I refined the definition a little.
Name:
Protein coverage
Definition:
The coverage of protein sequences from the peptide sequences identified. The table records the coverage itself (percentage), the protein accession (SHOULD correspond to the accession used in the document used for Sequence DB based identification), Length of the protein(, and optionally if it is a decoy entry.)
Comment:
Higher is better. Gives insight into how much of the target search space is covered. Low coverage can be caused by the absence of proteins, because of the used acquisition methods insensitivity to certain peptide species or shortcomings of the identification method.
Proposed value type:

[ ] single value
[ ] n-tuple
[x] table
[ ] corresponding lists
[ ] matrix

{'coverage':[...], 'accession':[...], 'length':[...], *'TD':[...]}
*optional

@julianu Where would we put something like relationship: has_order MS:1002108 ! higher score better? As text in the comments is suboptimal. And how do we designate which column is primary/affected by has_order? And units.

@julianu Maybe we can use this one as an example during PSI2020 to formalise the cv term value situation.


In-app survey

We currently don't really have any way to connect to our end users. Most bugs are raised by operators - proxies for the end users. This seems to be reflected in our survey, where ops-engineer is well represented, but ML-engineer, not so much.
We could use two techniques.
(1)
Ask the user about their use case the first time they open the UI, and forward them to public docs helping them with that use case (capturing what they choose):
https://www.appcues.com/blog/how-turbotax-makes-a-dreadful-user-experience-a-delightful-one

(2)
After two weeks of using the users interface, we should ask them how they are doing?

(3)
When they get a major/minor version (not patches), we should signpost the blog to point out the new version and its features.

            You've just upgraded to v3.2. Did you know about???

 * HTTP template for making fast HTTP request-
 * Multi-cluster for running workflows that span clusters/namespaces

[ Show me all the new features ] [ Dismiss ] [ Never show this again ]

@rbreeze thoughts?

I really like both ideas, especially getting feedback from users about their experience. One note is, I believe this would require "phoning home" which may pose an issue.
The navigation piece of this, though, seems easy enough to implement and it would be a nice user experience.

I think we need to do this without in-app telemetry, otherwise operators will want to disable it.
I thought each icon could lead to a page on the docs, which in turn have Google Analytics.

We would only phone home if they want to share their feedback. I think that is fine.


Why did you use low-pass filter twice in AMPBlock?

https://github.com/sh-lee-prml/BigVGAN/blob/37e49f36e50134de45b407bf2c6b1a61cea09329/models_bigvgan.py#L66-L69
Is these necessary? I didn't find it in paper.

I refer to Appendix A (page 13) of BigVGAN paper.

The upsampled feature is followed by M number of AMP residual blocks,
where each AMP block uses different kernel sizes for a stack of dilated 1D convolutions defined as
ki,j (j = {1, . . . , M}).  --> M =3 [3, 7, 11]
The j-th AMP block contains L number of the anti-aliased periodic activation
and the dilated 1D convolution using a dilatation rate of di,j,l(l = {1, . . . , L}).
--> L = 6 (3x2) [[1,1], [3,1], [5,1]]
So I used low-pass filter twice in this module.
But, I'm not sure it is same with what the author intended. When i first implemented this part, I was also confused because the figure was not matched with the hyperparameter (Specifically, dilation rates).

Thanks for your reply.

Thank you for your concern about this issue.
I agree your idea about using a low-pass filter only once. However, in this case, I was confused about activation function between these dilated convs.
The original HiFi-GAN used a leaky-relu for activation function in this part. However, in this paper, BigVGAN replaced it with snake1d. Hence, I implemented this part just by using snake and resamping with low-pass filter twice.
I just think that it would have been nice if there are additional ablation studies about this part in this paper.
I'm not sure that which implementation is best in this cases. I hope that the authors of BigVGAN adress thier idea with more ablation studies...

Yeah, you're right. I'll try to use snake1d directly between two dilated convs. And I will tell you the results of my experiment. Maybe someday NVIDIA will open source their work. ^^

After some comparison, I found that both models (using resampling once or twice) have similar performance.
But when using twice, training/inference speed is much slower so I changed it as you mentioned

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
lsiqueira, @bitsark, @joytianya, @ghchris2021, @RUI-LONG, @wangjing0, @jmetzz, @davoclavo, @tchaton, @Nyandwi, @pikid, @AlexeyAB, @askmetoo, @malteos, @DeShuiYu, @eugenesiow, @Santinule, @kennethleungty, @sumandas0, @NaoMatch


Rename partnerParams to extraPartnerParams

Story: https://app.shortcut.com/smileid/story/xxx
Summary
Rename partnerParams to extraPartnerParams
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.

can you update the CHANGELOG

Done


Sort-Imports fails when 'none' is first sort option

tslint and typescript versions
$ tslint --version
5.11.0
$ tsc --version
Version 3.2.1

tslint.json configuration
{
  extends: [
    'tslint-react',
    'tslint-eslint-rules',
    'tslint-config-prettier'
  ],
  defaultSeverity: 'error',
  rulesDirectory: 'tslint-microsoft-contrib',
  rules: {
    'sort-imports': [true, { 'member-syntax-sort-order': ['none', 'all', 'single', 'multiple', 'alias'], 'ignore-case': true }],
  }
};

Typescript code being linted:
import './index.css';
import * as React from 'react';
import App from './App';
import ReactDOM from 'react-dom';

ReactDOM.render(<App />, document.getElementById('root'));

Actual Behavior:
ERROR: src/index.tsx[1, 1]: All imports of type "None" must occur before all imports of type "All"
Expected Behavior:
Should not have any errors

If you look at the code, inside the _processMemberSyntaxSortOrder method, the sortOptions does not add the 'none' option to the order array because the if statement of (memberSyntaxTypeMap['none']) evaluates to 0, which is false, and thus is skips adding the option. Changing this to explicitly check for undefined instead of using the "evaluates to false" shortcut should resolve this issue.
It was causing sort-imports to incorrectly state that none must occur before all imports of type all in the above member-syntax-sort-order: ['none', 'all', 'single', 'multiple', 'alias'] even though all none imports were above all imports.


Fix quote char on "Planning your migration to GH"

Change the quote character “ to " on the jq filter of the git-sizer's output.

Why:
The filter applied by jq on git-sizer's output was using the wrong quotation character to enclose the filtering information and jq errored with:
jq: error: syntax error, unexpected INVALID_CHARACTER, expecting end of file (Unix shell quoting issues?) at <top-level>, line 1:
“.unique_blob_size”

Closes: #30079

What's being changed (if available, include any code snippets, screenshots, or gifs):
Use the correct quotation character (hex 22 on ASCII / UTF-8) with jq for filtering the output of git-sizer.
Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Thank you for opening a PR and linking it to your issue! ✨ I’ll get this triaged for review! :zap:


Decide how to deal with masked integral data on coordinates and cell measures

See comment: https://github.com/SciTools/iris/pull/2447/files#r106936956

Replaced by #2490 and #2491


OCW 132

Enable redis caching for what is worth. Update have been also made to devtools though not tested.

Warning! yum install redis doesn't work so the deployment part of this will need some more work.


[Event Request] Table 5050 Contact - OnCreateVendorLinkOnAfterCreateLink

Hi, would it be possible to get an OnCreateVendorLinkOnAfterCreateLink event in table 5050 (Contact), like this:
    procedure CreateVendorLink()
    var
        ContBusRel: Record "Contact Business Relation";
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeCreateVendorLink(Rec, IsHandled);
        if not IsHandled then begin
            CheckForExistingRelationships(ContBusRel."Link to Table"::Vendor);
            CheckIfPrivacyBlockedGeneric;
            TestField("Company No.");
            RMSetup.Get();
            RMSetup.TestField("Bus. Rel. Code for Vendors");
            CreateLink(
              PAGE::"Vendor Link",
              RMSetup."Bus. Rel. Code for Vendors",
              ContBusRel."Link to Table"::Vendor);

            OnCreateVendorLinkOnAfterCreateLink(Rec, xRec, ContBusRel); // New Event
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnCreateVendorLinkOnAfterCreateLink(var Contact: Record Contact; xContact: Record Contact; var ContactBusinessRelation: Record "Contact Business Relation")
    begin
    end;

#18077
Thanks!

ContBusRel is only used to reference the "Link to Table" enum in this code. This doesn't make sense as an event parameter.

@dannoe
Thanks!
I completely agree, it makes no sense to add this parameter. Also, it is not used in our customization. We just want to make the event more generic and similar to the requested event in the CreateCustomerLink procedure where this parameter can be used for some reason (for example, to apply some extra filters).
The signature of the requested event has been updated.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 40859.


attach: fix the performance issue of the new attach implementation

Closes #223
This PR allows frida_attach_entry accepting ebpf-arguments-like callbacks, in this way we could avoid an extra callback layer that translates ebpf arguments from original arguments.
Benchmark result of the current commit

Benchmark result of the commit prior to the new attach implementation

According to the benchmark, the new attach implementation has the same performance as the previous one

Can you introduce how this PR works?

Can you introduce how this PR works? It seems like a large PR.

Allowing frida_attach_entry to store a callback function with signature int(void* memory, size_t memory_size, uint64_t* return_value). This signature is intended for calling ebpf programs. When the hook is triggered, and the mentioned callback is provided, the corresponding function would be directly triggered.
In the previous design, frida_attach_entry only accept callback with signature void(const pt_regs&). If user want to call a ebpf program with the unified registering interface, a intermediate layer that accepts pt_regs as argument and call the ebpf callback  is needed.
So the new design reduces one intermediate callback layer, so the calling latency could be reduced.
Why doesn't frida_attach_entry stores bpftime_prog to call ebpf program? Currently attach parts doesn't depend on any API in runtime, so we can't use bpftime_prog.

Can we make attach part depends on the runtime API? Will that be simple?

Can we make attach part depends on the runtime API? Will that be simple?

runtime has no need to depend on attach (except base_attach_impl), attach also has no need to depend on runtime.
They both depend on base_attach_impl. Attach impls should be registered at runtime, and attach_manager (current bpf_attach_ctx) should be responsible for managing registered attach impls. These procedure has no performance degradation. Attach callbacks are std::function which are directly provided by attach_manager. Abstraction is only needed for a unified attach impl interface


Task: Add Infocom-like Presentation

Implement an Infocom style of presentation based on Zork I, Zork II and Zork III.

This should include using a fixed-width font since the formatting of some of the description text requires it.