[wip] explore vs2015_runtime clobber errors

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Thanks so much for maintaining this!
I've been getting some errors when installing it alongside other things on windows, as it seems to include its own vs2015 redistributable dlls.
I'm hoping adding that dependency will either:

build, and all the detecton will be great, the package will be smaller, and not require any changes
fail, and require managing the list of dlls to list

If it does something far outside of these, then it might not be able to go into %PREFIX/Library, which would be sad, and admit breaking the "no-vendoring" rule, but at least wouldn't break other stuff.

ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-core-file-l1-2-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-core-file-l2-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-core-localization-l1-2-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-core-processthreads-l1-1-1.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-core-synch-l1-2-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-core-timezone-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-conio-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-convert-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-environment-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-filesystem-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-heap-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-locale-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-math-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-multibyte-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-private-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-process-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-runtime-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-stdio-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-string-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-time-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/api-ms-win-crt-utility-l1-1-0.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/msvcp140.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/ucrtbase.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: conda-forge::firefox-68.0.2-0, anaconda::vs2015_runtime-15.5.2-3
path: 'library/bin/vcruntime140.dll'
ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: anaconda::notebook-6.0.1-py36_0, anaconda::notebook-6.0.1-py36_0
path: 'menu/notebook.json'
Verifying transaction: ...working... done
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-core-file-l1-2-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-core-file-l1-2-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-core-file-l2-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-core-file-l2-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-core-localization-l1-2-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-core-localization-l1-2-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-core-processthreads-l1-1-1.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-core-processthreads-l1-1-1.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-core-synch-l1-2-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-core-synch-l1-2-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-core-timezone-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-core-timezone-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-conio-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-conio-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-convert-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-convert-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-environment-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-environment-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-filesystem-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-filesystem-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-heap-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-heap-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-locale-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-locale-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-math-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-math-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-multibyte-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-multibyte-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-private-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-private-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-process-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-process-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-runtime-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-runtime-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-stdio-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-stdio-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-string-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-string-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-time-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-time-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\api-ms-win-crt-utility-l1-1-0.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\api-ms-win-crt-utility-l1-1-0.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\msvcp140.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\msvcp140.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\ucrtbase.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\ucrtbase.dll
ClobberWarning: Conda was asked to clobber an existing path.
source path: C:\Miniconda\pkgs\vs2015_runtime-15.5.2-3\Library\bin\vcruntime140.dll
target path: C:\Miniconda\conda-bld\robotlab_1568588664863_test_env\Library\bin\vcruntime140.dll
WARNING:conda.gateways.disk.create:Environment name starts with underscore ''. Skipping menu installation.
WARNING conda.gateways.disk.create:make_menu(241): Environment name starts with underscore ''. Skipping menu installation.
Executing transaction: ...working... done
set PREFIX=C:\Miniconda\conda-bld\robotlab_1568588664863_test_env
set SRC_DIR=C:\Miniconda\conda-bld\robotlab_1568588664863\test_tmp

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Thanks so much for maintaining this!

Thank you for maintaining geckodriver, was thrilled when I found there's already a conda package for it.
I'm afraid @ocefpaf or another core dev will need to chip in on this. I really don't know the pros and cons of this change.
Perhaps worth noting that we were hoping to have the windows build not just trample all over bin but go in it's own directory like we do on Linux and OSX but we didn't get to it. Ref: https://github.com/conda-forge/staged-recipes/pull/9234#discussion_r321859931

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

great, that worked. it's still complaining about vc, will try some compilers

Now getting 64 files packaged, vs 88 in the published package, which seems like good progress. There are a number of additional unix deps we could add to squelch more warnings, but they at least weren't causing errors when installed/used in constructor.
Adding geckodriver was just for kicks, though it may be interesting to add this package as a test dependency over there to see if we can actually get them talking, though the gtk thing will keep it from working on linux, it seems?

I've been getting some errors when installing it alongside other things on windows, as it seems to include its own vs2015 redistributable dlls.

Can you share more so we can see the error you were experiencing and how this fixes it.

Ehm, basically if you have a construct.yaml for constructor:
name: FireFoxConda
version: 0.1.0
channels:
  - https://conda.anaconda.org/conda-forge

specs:
- firefox
- anything-that-uses-vs2015-redistributable-which-is-basically-everything

it falls over due to the 24 duplicated files. Granted, these pretty much don't change, but when they do it breaks the universe.
I added ignore_duplicate_files: True to ignore it, but sometimes this points to far deeper problems, and would prefer to build with that flag turned off (unavoidable, sometimes). I'll get back to this (still have some paths to run down whether they are okay to ship), but hope this helps explain the underlying goal.

Can I get steps to reproduce "it breaks the universe?"

Sorry, my actual build errors have fallen off the queue in azure!
Supporting windows is hard enough.  I'd rather like to know that my windows users' compiler runtime, which basically every windows user will have installed, is the same one it always is, rather than sometimes having been replaced by some other package.
Duplicate package contents a) indicate vendoring, which is one of the things conda-forge discourages b)  give people strange permission denied errors c) causes errors in downstream consumers of conda packages, such as constructor d) increases the total downloaded package size.

Supporting windows is hard enough.

This doesn't feel constructive. I'm just trying to gather more information so I can test this PR as we haven't gotten input from @ocefpaf yet.

Apologies for not being more concrete. Here's the kind of error one can get
on install:
https://forum.image.sc/t/problems-to-install-deeplabcut-2-0-gpu-using-anacoda3-in-windows-10/24018
Removing may also reveal issues:
$ conda create -n foo some-package-that-uses-vs2015_runtime
$ activate foo
$ conda install -c conda-forge firefox
$ conda remove firefox
$ some-package-that-uses-vs2015_runtime
...and maybe it tells you library/bin/api-ms-win-core-console-l1-1-0.dll or
one of the other 23 overlapping files that got unlinked, but then again,
maybe not.
On phone, can't check if that would be a problem, or if the link/reverse
link magically know to restore the missing files... definitely might!
I've also encountered conda-build not liking testing in environments that
have packages with shared paths... so I would imagine having in a meta.yml:
test:
requires:
- firefox
- selenium
- opencv
- geckodriver
...probably raising a ClobberError, assuming at least one of those deps
brings in vs2015_runtime.
On Fri, Sep 27, 2019, 19:17 Sarah Bird<EMAIL_ADDRESS>wrote:

Supporting windows is hard enough.
This doesn't feel constructive. I'm just trying to gather more information
so I can test this PR as we haven't gotten input from @ocefpaf
https://github.com/ocefpaf yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/conda-forge/firefox-feedstock/pull/1?email_source=notifications&email_token=AAALCRF7Z2KJH2FELPLKNTLQL2IBNA5CNFSM4IW4ODDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72JYBY#issuecomment-536124423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAALCRCYB525MGKMD5M6SELQL2IBNANCNFSM4IW4ODDA
.

Downloaded https://repo.anaconda.com/miniconda/Miniconda3-4.7.10-Windows-x86_64.exe
conda install -c conda-forge conda conda-build constructor

(base) C:\foo>conda info

     active environment : base
    active env location : c:\mc3
            shell level : 1
       user config file : C:\Users\IEUser\.condarc
 populated config files :
          conda version : 4.7.12
    conda-build version : 3.18.9
         python version : 3.7.3.final.0
       virtual packages :
       base environment : c:\mc3  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/win-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/win-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/msys2/win-64
                          https://repo.anaconda.com/pkgs/msys2/noarch
          package cache : c:\mc3\pkgs
                          C:\Users\IEUser\.conda\pkgs
                          C:\Users\IEUser\AppData\Local\conda\conda\pkgs
       envs directories : c:\mc3\envs
                          C:\Users\IEUser\.conda\envs
                          C:\Users\IEUser\AppData\Local\conda\conda\envs
               platform : win-64
             user-agent : conda/4.7.12 requests/2.22.0 CPython/3.7.3 Windows/10 Windows/10.0.17134
          administrator : False
             netrc file : None
           offline mode : False

(base) C:\foo>conda list
# packages in environment at c:\mc3:
#
# Name                    Version                   Build  Channel
asn1crypto                0.24.0                   py37_0
beautifulsoup4            4.8.0                    py37_0    conda-forge
bzip2                     1.0.8                he774522_0
ca-certificates           2019.9.11            hecc5488_0    conda-forge
certifi                   2019.9.11                py37_0
cffi                      1.12.3           py37h7a1dbc1_0
chardet                   3.0.4                    py37_1
conda                     4.7.12                   py37_0    conda-forge
conda-build               3.18.9                   py37_5    conda-forge
conda-package-handling    1.3.11                   py37_0
console_shortcut          0.1.1                         3
constructor               3.0.0                    py37_0    conda-forge
cryptography              2.7              py37h7a1dbc1_0
filelock                  3.0.10                     py_0    conda-forge
freetype                  2.10.0               h563cfd7_1    conda-forge
glob2                     0.7                        py_0    conda-forge
idna                      2.8                      py37_0
jinja2                    2.10.1                     py_0    conda-forge
jpeg                      9c                hfa6e2cd_1001    conda-forge
libarchive                3.3.3                h0643e63_5
libiconv                  1.15                 h1df5818_7
liblief                   0.9.0                ha925a31_2
libpng                    1.6.37               h7602738_0    conda-forge
libtiff                   4.0.9             h36446d0_1002    conda-forge
libxml2                   2.9.9                h464c3ec_0
lz4-c                     <IP_ADDRESS>              h2fa13f4_0
lzo                       2.10                 h6df0209_2
m2w64-gcc-libgfortran     5.3.0                         6
m2w64-gcc-libs            5.3.0                         7
m2w64-gcc-libs-core       5.3.0                         7
m2w64-gmp                 6.1.0                         2
m2w64-libwinpthread-git   <IP_ADDRESS>34.697f757               2
markupsafe                1.1.1            py37hfa6e2cd_0    conda-forge
menuinst                  1.4.16           py37he774522_0
msys2-conda-epoch         20160418                      1
nsis                      3.01                          1    conda-forge
olefile                   0.46                       py_0    conda-forge
openssl                   1.1.1c               hfa6e2cd_0    conda-forge
pillow                    6.1.0            py37h9a613e6_0    conda-forge
pip                       19.1.1                   py37_0
pkginfo                   <IP_ADDRESS>                    py_0    conda-forge
powershell_shortcut       0.0.1                         2
psutil                    5.6.3            py37hfa6e2cd_0    conda-forge
py-lief                   0.9.0            py37ha925a31_2
pycosat                   0.6.3            py37hfa6e2cd_0
pycparser                 2.19                     py37_0
pyopenssl                 19.0.0                   py37_0
pysocks                   1.7.0                    py37_0
python                    3.7.3                h8c8aaf0_1
python-libarchive-c       2.8                     py37_11
pytz                      2019.2                     py_0    conda-forge
pywin32                   223              py37hfa6e2cd_1
pyyaml                    5.1.2            py37hfa6e2cd_0    conda-forge
requests                  2.22.0                   py37_0
ripgrep                   11.0.2               h301d43c_3    conda-forge
ruamel_yaml               0.15.46          py37hfa6e2cd_0
setuptools                41.0.1                   py37_0
six                       1.12.0                   py37_0
soupsieve                 1.9.4                    py37_0    conda-forge
sqlite                    3.29.0               he774522_0
tk                        8.6.9             hfa6e2cd_1003    conda-forge
tqdm                      4.32.1                     py_0
urllib3                   1.24.2                   py37_0
vc                        14.1                 h0510ff6_4
vs2015_runtime            14.15.26706          h3a45250_4
wheel                     0.33.4                   py37_0
win_inet_pton             1.1.0                    py37_0
wincertstore              0.2                      py37_0
xz                        5.2.4                h2fa13f4_4
yaml                      0.1.7                hc54c509_2
zlib                      1.2.11               h62dcd97_3
zstd                      1.3.7                h508b16e_0

made a recipe

{% set name = "MPL" %}
{% set version = "2.0" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  fn: LICENSE
  url: https://www.mozilla.org/en-US/{{ name }}/{{ version }}/

build:
  number: 0

test:
  requires:
    - firefox
    - geckodriver
    - selenium

about:
  home: https://www.mozilla.org/en-US/firefox/releases
  license: MPL-2.0
  license_family: OTHER
  license_file: LICENSE
  summary: 'Mozilla Public License'

built recipe

(base) C:\foo>conda build -c conda-forge .
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
Adding in variants from internal_defaults
INFO:conda_build.variants:Adding in variants from internal_defaults
Attempting to finalize metadata for mpl
INFO:conda_build.metadata:Attempting to finalize metadata for mpl
BUILD START: ['mpl-2.0-0.tar.bz2']
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... done
Source cache directory is: c:\mc3\conda-bld\src_cache
INFO:conda_build.source:Source cache directory is: c:\mc3\conda-bld\src_cache
INFO conda_build.source:download_to_cache(43): Source cache directory is: c:\mc3\conda-bld\src_cache
No hash (md5, sha1, sha256) provided for LICENSE.  Source download forced.  Add hash to recipe to use source cache.
WARNING:conda_build.source:No hash (md5, sha1, sha256) provided for LICENSE.  Source download forced.  Add hash to recipe to use source cache.
WARNING conda_build.source:download_to_cache(59): No hash (md5, sha1, sha256) provided for LICENSE.  Source download forced.  Add hash to recipe to use source cache.
Downloading source to cache: LICENSE
INFO:conda_build.source:Downloading source to cache: LICENSE
INFO conda_build.source:download_to_cache(66): Downloading source to cache: LICENSE
Downloading https://www.mozilla.org/en-US/MPL/2.0/
INFO:conda_build.source:Downloading https://www.mozilla.org/en-US/MPL/2.0/
INFO conda_build.source:download_to_cache(80): Downloading https://www.mozilla.org/en-US/MPL/2.0/
Success
INFO:conda_build.source:Success
INFO conda_build.source:download_to_cache(91): Success
Extracting download
Warning: Unrecognized source format. Source file will be copied to the SRC_DIR
source tree in: c:\mc3\conda-bld\mpl_1569631852451\work
Using legacy MSVC compiler setup.  This will be removed in conda-build 4.0. If this recipe does not use a compiler, this message is safe to ignore.  Otherwise, use {{compiler('<language>')}} jinja2 in requirements/build.
WARNING:conda_build.windows:Using legacy MSVC compiler setup.  This will be removed in conda-build 4.0. If this recipe does not use a compiler, this message is safe to ignore.  Otherwise, use {{compiler('<language>')}} jinja2 in requirements/build.
WARNING conda_build.windows:msvc_env_cmd(91): Using legacy MSVC compiler setup.  This will be removed in conda-build 4.0. If this recipe does not use a compiler, this message is safe to ignore.  Otherwise, use {{compiler('<language>')}} jinja2 in requirements/build.
Packaging mpl
INFO:conda_build.build:Packaging mpl
INFO conda_build.build:build(1570): Packaging mpl
Packaging mpl-2.0-0
INFO:conda_build.build:Packaging mpl-2.0-0
INFO conda_build.build:bundle_conda(891): Packaging mpl-2.0-0
No files or script found for output mpl
WARNING:conda_build.build:No files or script found for output mpl
WARNING conda_build.build:bundle_conda(971): No files or script found for output mpl
number of files: 0
Fixing permissions
Packaged license file/s.
Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
WARNING:conda_build.build:Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
WARNING conda_build.build:bundle_conda(1042): Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
TEST START: c:\mc3\conda-bld\win-64\mpl-2.0-0.tar.bz2
Adding in variants from C:\Users\IEUser\AppData\Local\Temp\tmpmv2v7coe\info\recipe\conda_build_config.yaml
INFO:conda_build.variants:Adding in variants from C:\Users\IEUser\AppData\Local\Temp\tmpmv2v7coe\info\recipe\conda_build_config.yaml
INFO conda_build.variants:_combine_spec_dictionaries(188): Adding in variants from C:\Users\IEUser\AppData\Local\Temp\tmpmv2v7coe\info\recipe\conda_build_config.yaml
Renaming work directory,  c:\mc3\conda-bld\mpl_1569631852451\work  to  c:\mc3\conda-bld\mpl_1569631852451\work_moved_mpl-2.0-0_win-64
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... done

## Package Plan ##

  environment location: c:\mc3\conda-bld\mpl_1569631852451\_test_env

The following NEW packages will be INSTALLED:

    asn1crypto:      0.24.0-py37_1003          conda-forge
    ca-certificates: 2019.9.11-hecc5488_0      conda-forge
    certifi:         2019.6.16-py37_1          conda-forge
    cffi:            1.12.3-py37hb32ad35_0     conda-forge
    cryptography:    2.7-py37hb32ad35_0        conda-forge
    firefox:         68.0.2-0                  conda-forge
    geckodriver:     0.24.0-h21ff451_1         conda-forge
    idna:            2.8-py37_1000             conda-forge
    mpl:             2.0-0                     local
    openssl:         1.1.1c-hfa6e2cd_0         conda-forge
    pip:             19.2.3-py37_0             conda-forge
    pycparser:       2.19-py37_1               conda-forge
    pyopenssl:       19.0.0-py37_0             conda-forge
    pysocks:         1.7.1-py37_0              conda-forge
    python:          3.7.3-h510b542_1          conda-forge
    selenium:        3.141.0-py37hfa6e2cd_1000 conda-forge
    setuptools:      41.2.0-py37_0             conda-forge
    six:             1.12.0-py37_1000          conda-forge
    sqlite:          3.29.0-hfa6e2cd_1         conda-forge
    urllib3:         1.25.6-py37_0             conda-forge
    vc:              14.1-h0510ff6_4
    vs2015_runtime:  14.16.27012-hf0eaf9b_0
    wheel:           0.33.6-py37_0             conda-forge
    win_inet_pton:   1.1.0-py37_0              conda-forge
    wincertstore:    0.2-py37_1002             conda-forge

Preparing transaction: ...working... done
Verifying transaction: ...working...

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-core-file-l1-2-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-core-file-l1-2-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-core-file-l2-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-core-file-l2-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-core-localization-l1-2-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-core-localization-l1-2-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-core-processthreads-l1-1-1.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-core-processthreads-l1-1-1.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-core-synch-l1-2-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-core-synch-l1-2-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-core-timezone-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-core-timezone-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-conio-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-conio-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-convert-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-convert-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-environment-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-environment-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-filesystem-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-filesystem-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-heap-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-heap-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-locale-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-locale-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-math-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-math-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-multibyte-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-multibyte-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-private-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-private-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-process-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-process-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-runtime-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-runtime-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-stdio-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-stdio-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-string-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-string-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-time-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-time-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\api-ms-win-crt-utility-l1-1-0.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\api-ms-win-crt-utility-l1-1-0.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\msvcp140.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\msvcp140.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\ucrtbase.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\ucrtbase.dll

ClobberWarning: Conda was asked to clobber an existing path.
  source path: c:\mc3\pkgs\vs2015_runtime-14.16.27012-hf0eaf9b_0\Library\bin\vcruntime140.dll
  target path: c:\mc3\conda-bld\mpl_1569631852451\_test_env\Library\bin\vcruntime140.dll

it then proceeds to build successfully, as the above are just warnings.

made construct

# construct.yaml
name: FireFoxConda
version: 0.1.0

channels:
  - https://conda.anaconda.org/anaconda
  - https://conda.anaconda.org/conda-forge

specs:
  - python
  - firefox
  - geckodriver

(base) C:\foo>constructor
platform: win-64
Collecting package metadata (repodata.json): done
Solving environment: done
fetching: python-3.7.4-h5263a28_0.tar.bz2
fetching: firefox-68.0.2-0.tar.bz2
fetching: geckodriver-0.24.0-h21ff451_1.tar.bz2
fetching: ca-certificates-2019.8.28-0.tar.bz2
fetching: vs2015_runtime-15.5.2-3.tar.bz2
fetching: vc-14.1-h21ff451_3.tar.bz2
fetching: openssl-1.1.1-he774522_0.tar.bz2
fetching: sqlite-3.29.0-he774522_0.tar.bz2
fetching: certifi-2019.9.11-py37_0.tar.bz2
fetching: wincertstore-0.2-py37_0.tar.bz2
fetching: setuptools-41.2.0-py37_0.tar.bz2
fetching: wheel-0.33.6-py37_0.tar.bz2
fetching: pip-19.2.3-py37_0.tar.bz2
Checking for duplicate files ...
Error: File 'Library/bin/api-ms-win-core-file-l1-2-0.dll' found in multiple packages: vs2015_runtime-15.5.2-3.tar.bz2, firefox-68.0.2-0.tar.bz2

did not build

Using the compiler jinja2 syntax is very much standard these days for packages that need compilers.
Vendoring the runtimes is probably a side effect of bypassing that mechanism.  The dependency on runtimes is automatically added by conda-build when using the compiler packages, but not when using the legacy implicit stuff.
Vendoring runtimes in random packages is indeed really bad.  In fact, Microsoft doesn't even like the fact that conda ships runtime packages at all.  They would prefer that users obtain the runtimes via windows update.  Shipment via conda is something they are OK with because we still have to support older Windows versions.
Vendoring runtimes is bad because you are then imposing an implicit compatibility bound that you probably don't even know about.  The way that things work on Windows is that you need a runtime that is as new or newer than the compiler that was used for each package in the system.  If conda provides the absolute latest runtime, but your package then clobbers that with an older one, it can break other software in the environment.
I see no downsides to this PR, and recommend merging it.

@conda-forge-admin please rerender

Thanks for all the hardwork @bollwyvl. Much appreciated. Thanks for the review @msarahan.

Hooray!
On Sun, Sep 29, 2019, 16:34 Sarah Bird<EMAIL_ADDRESS>wrote:

Thanks for all the hardwork @bollwyvl https://github.com/bollwyvl. Much
appreciated. Thanks for the review @msarahan https://github.com/msarahan
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/conda-forge/firefox-feedstock/pull/1?email_source=notifications&email_token=AAALCRAIBXHXD35MS5THSYDQMEGLXA5CNFSM4IW4ODDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD736B5Q#issuecomment-536338678,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAALCRGAWLOWNVT2MWFOE5DQMEGLXANCNFSM4IW4ODDA
.

This doesn't feel constructive. I'm just trying to gather more information so I can test this PR as we haven't gotten input from @ocefpaf yet.

Sorry @birdsarah and @bollwyvl I was away travelling and still catching up with notifications. Looks like this was solved and @msarahan was the right person to answer this anyways :wink:
Thanks for your efforts to make this package available in conda-forge!


LUTECE-2163 : Add CSRF tokens to CacheJspBean actions

This also fixes LUTECE-1855 : All state-altering actions are changed to POST.

Merged, Thanks !


[BUG] After inviting the user, email ID is copied to Name field as well

Issue: After inviting the user, email ID is copied to Name field as well. Either Name should be left blank or it should be updated later on.
Browser Details: Chrome Version 85.0.4183.102 (Official Build) (64-bit)
Device Details: macOS 10.15.6 (MacBook Pro)
Note: Tried on cloud.
Steps to replicate :
1.Login to https://app.appsmith.com/user/login
2. go to 'Manage users'.
3. Click on 'Invite Users'
4. Fill up the details and click on 'invite'.
Actual Result: 'email ID' provided is also copied to the Name field.
Expected Result: email ID provided should not be copied to the Name field.
Attachment: https://drive.google.com/drive/folders/1dP-YRPvK_9zalv9qAKOQjs7hM8xob6HW?usp=sharing

I would like to work on this issue if it is still available. I would just like to clarify the scope of this so I know what direction to work in. Should this be addressed by just preventing the copying of the Email into the Name field and leaving it blank? Or should the functionality to edit the user's Name be added as well?

I would like to work on this issue if it is still available. I would just like to clarify the scope of this so I know what direction to work in. Should this be addressed by just preventing the copying of the Email into the Name field and leaving it blank? Or should the functionality to edit the user's Name be added as well?

@trdillon go for it! I think for now just preventing the copy should be great, once we have an additional page for account setting, this makes sense


fix(robot-server): allow /instruments endpoint to support the 96 channel

Overview
This is a temporary fix to allow the /instruments endpoint the ability to return 96 channel pipettes when they are attached. The real fix is to refactor the /instruments endpoint to use v2 validation for pipettes.
Test Cases

[x] /instruments endpoint no longer errors out when 96 channel is attached
[ ] Can successfully proceed to a protocol run with a 96 channel

This PR does not appear to fix the problem with the 96 channel. Maybe there is another issue specific to the app @smb2268 ?


Asking for changes

After installing it is asking for many changes in pod file in swift 4.2 , xcode 10.1

this is due to xcode updates i'm assuming. if this issue persists, open a another issue


Error connecting to the service protocol: HttpException: Connection closed before full header was received, uri

"Error connecting to the service protocol: HttpException: Connection closed before full header was received, uri"  this is what i am getting after adding your plugin in my flutter application.
I tried with version 1.1.1, 1.1.0 and 1.0.3 of your plugin got the same issue. I already tried searching on internet regarding this problem but no any satisfactory answer found.

I had same problem how do you solve it

any idea how did you solve this problem?

I have solve this problem by following this steps.
Once you have the Facebook App ID figured out, youll have to do two things.
First, copy-paste the following to your strings resource file. If you don't have one, just create it.
<your project root>/android/app/src/main/res/values/strings.xml
<?xml version="1.0" encoding="utf-8"?>
<resources>
    <string name="app_name">Your App Name here.</string>

    <!-- Replace "000000000000" with your Facebook App ID here. -->
    <string name="facebook_app_id">000000000000</string>

    <!--
      Replace "000000000000" with your Facebook App ID here.
      **NOTE**: The scheme needs to start with `fb` and then your ID.
    -->
    <string name="fb_login_protocol_scheme">fb000000000000</string>
</resources>

Then you'll just have to copy-paste the following to your Android Manifest:
<your project root>/android/app/src/main/AndroidManifest.xml
<meta-data android:name="com.facebook.sdk.ApplicationId"
    android:value="@string/facebook_app_id"/>

<activity android:name="com.facebook.FacebookActivity"
    android:configChanges=
            "keyboard|keyboardHidden|screenLayout|screenSize|orientation"
    android:label="@string/app_name" />

<activity
    android:name="com.facebook.CustomTabActivity"
    android:exported="true">
    <intent-filter>
        <action android:name="android.intent.action.VIEW" />
        <category android:name="android.intent.category.DEFAULT" />
        <category android:name="android.intent.category.BROWSABLE" />
        <data android:scheme="@string/fb_login_protocol_scheme" />
    </intent-filter>
</activity>


Hello, about the random kernel point selection

Hello Hugues,
I would really appreciate it if you are able to help me with the following two questions.
https://github.com/HuguesTHOMAS/KPConv-PyTorch/blob/73e444d486cd6cb56122c3dd410e51c734064cfe/kernels/kernel_points.py#L109
Is there a specific reason why you set a normal distribution of N(-radius0, 2*radius0) for the sampling of random kernel points?
https://github.com/HuguesTHOMAS/KPConv-PyTorch/blob/73e444d486cd6cb56122c3dd410e51c734064cfe/kernels/kernel_points.py#L133
Also, what is side_n? And why it is computed in this way?
Best regards,
Leon

Is there a specific reason why you set a normal distribution of N(-radius0, 2*radius0) for the sampling of random kernel points?

Well, it is not a normal distribution, it is uniform, between -radius0 and radius0. There is no specific reason, it is just initialization, not very important.

what is side_n? And why it is computed in this way?

For a volume, it would be the cubic root of the total number of points, so the number of points on a linear segment. This function. But we do not use this part of the code anyway. This is some debug code that I implemented some time, but do not use anymore


[AST] Batch port to analyser and convert to tsx

Howdy
Nothing too crazy going on for this one
Lightspeed had the most changes because I largely lifted the code from DNC technicalities removing parts of the code that aren't used for lightspeed
I changed the format for Lightspeed because I like the ability to click on the time and see it in action -- if you prefer the previous accordion format, I can change it back. I leave it up to the reviewer

Lightspeed before changes (production):

Lightspeed after changes (testing):


Randomizer Compatibilty update

Don't merge this until Randomizer 4 has been updated to version 4.0.3 or greater

will you merge that yourself once it's been updated?

Honestly I made this PR because I expected @homothetyhk to be updating rando later that day while I was busy. But yeah the expectation is that Homothety will merge this when he merges in the rando 4 update (which includes breaking changes which these updates address - that's why I did it like this rather than just waiting)


Build the backend site in buildspec.yml

Pull Request Template
Issue Overview
This PR addresses metrotranscom/doorway-infra#64
Note that this PR probably won't work yet. Expecting a follow-up CL in the infra repo (once this PR is merged and can be tested with). See notes below.

[ ] This change addresses the issue in full
[x] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Build the backend Docker image and push it to ECR
How Can This Be Tested/Reviewed?
This has been tested locally with Codebuild local script, with some environmental variables manually fed in. It may not work out of the box in the actual CI/CD pipeline, and I expect a follow up CL in the doorway-infra repo to update the terraform configs.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have added QA notes to the issue with applicable URLs
[ ] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[ ] I have exported any new pieces added to ui-components
[ ] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Can we add documentation on how to invoke this? Is the plan to only allow terraform to invoke this?

GuangHui has left and this work has been implemented in subsequent PRs.  Closing


May you consider changing the way you connect hive to a configuration file?

Hi @zuoakang, yes for sure, I think we should keep the current way of connecting and add the configuration file way of connecting,  in case you want to simply change the server without having to edit the configuration file I have some user that find it more easy to change it directly in the kernel.
Do you want to contribute on this?

@Dubrzr Can we completely remove current way of connecting and only support config file? Config file can be a json like below
{   "url": "hive://<kerberos-username>@<hive-host>:<hive-port>/<db-name>",   "connect_args" : {     "auth": "KERBEROS",     "kerberos_service_name":"hive"   },   "pool_size": 5,   "max_overflow": 10,   "default_limit": 20,   "display_mode": "be"  }
This will ensure connection details at once place and if there is any change in the configurations users can change the file and restart the kernel.
Let me know your thoughts and I would like to contribute on this.

I'm not sure we should remove the possibility to configure the Hive connection from the kernel. Actually it makes sense to only have a single kernel for Hive and be able to connect to many different hive sources with this kernel.
Let's say I have two notebooks I am working on in parrallel that use the same hive kernel and use different hive servers, how can I manage that using only a single configuration file? It doesn't work, except if you install a different kernel for each hive server, which is not really easy...
I understand that it is really useful to have a configuration file so that you don't have to configure the connection each time you start a new hive lernel, but it should not remove the ability to connect to different source.
The solution could be that by default, when you start the kernel, it reads a configuration file at ~/.hiveql_kernel.conf, if it exists it uses it, else you have to configure the connection in the notebook. If you have a configuration file and want to connect to another hive server then the configuration in the notebook overwrite the one in the configuration file.
The proposition for the json is perfect :)

@Dubrzr thanks for the clarification, will pick this up

@bharatl awesome, let us know if you have any other thoughts about this or if you need help ;)
Thanks!

I also was wondering if hiveql kernel could not be the start of a new more generalist kernel: an sqlalchemyKernel ! I mean, behind this kernel we only query a hive database using sqlalchemy, and we could think that with some work it can work with postgres, mysql, ... all sqlachemy compatible databases!
I think a sqlalchemyKernel would be awesome for a lot of persons, and I don't get why it doesn't already exists ahah. Next step ;)

@Dubrzr @parisni raised PR
implementation details:

Current way of connecting to hive (cell with $$) takes precedence if present  else we check for config file

By default we read config file present at ~/.hiveql_kernel.json  (users home directory)

There is also a provision for user to export path of the config file to variable HIVE_KERNEL_CONF_FILE  example export HIVE_KERNEL_CONF_FILE=<path_to_conf_file> and start the jupyter

Any changes to config file requires kernel to be restarted

This PR doesn't include changes to README and connection error string.


Fix/mediator transports

This PR has code that corrects issues related to mediation.
Corrections

multiple restarts with the same mediation invitation
second sorting of connection transport services based on inbound services
multiple outbound transport support

add transport is now register transport, which allows using multiple types of transport.

Codecov Report

Merging #419 (87bdd8f) into main (f0cf209) will decrease coverage by 22.34%.
The diff coverage is 51.00%.

@@             Coverage Diff             @@
##             main     #419       +/-   ##
===========================================
- Coverage   86.29%   63.95%   -22.35%
===========================================
  Files         249      249
  Lines        5255     5324       +69
  Branches      784      804       +20
===========================================
- Hits         4535     3405     -1130
- Misses        720     1918     +1198
- Partials        0        1        +1

Impacted Files
Coverage Δ

...ckages/core/src/transport/WsOutboundTransporter.ts
3.94% <0.00%> (-1.32%)
:arrow_down:

packages/core/src/agent/Agent.ts
84.21% <48.27%> (-12.67%)
:arrow_down:

packages/core/src/agent/MessageSender.ts
66.94% <66.66%> (-7.28%)
:arrow_down:

packages/core/src/agent/TransportService.ts
94.59% <100.00%> (+2.28%)
:arrow_up:

...c/modules/routing/messages/KeylistUpdateMessage.ts
56.52% <100.00%> (-43.48%)
:arrow_down:

...s/routing/messages/KeylistUpdateResponseMessage.ts
58.62% <100.00%> (-41.38%)
:arrow_down:

...ore/src/modules/proofs/ProofResponseCoordinator.ts
22.22% <0.00%> (-77.78%)
:arrow_down:

.../src/modules/proofs/models/RetrievedCredentials.ts
25.00% <0.00%> (-75.00%)
:arrow_down:

...dules/credentials/CredentialResponseCoordinator.ts
18.42% <0.00%> (-75.00%)
:arrow_down:

...s/core/src/modules/proofs/services/ProofService.ts
14.48% <0.00%> (-74.21%)
:arrow_down:

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cf209...87bdd8f. Read the comment docs.

Awesome work here @burdettadam! I'd agree here with @TimoGlastra that splitting this into multiple PRs is likely helpful to work through the various aspects.
Also @TimoGlastra happy to talk with you guys on a call or at the AFJ call on Thursday if helpful.

@jakubkoci @JamesKEbert @burdettadam Can I go ahead and merge this PR?


Fix 401 malformed WWW-Authenticate

references
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/WWW-Authenticate
https://tools.ietf.org/html/rfc7235#section-4.1
What issue does this PR address?
401 malformed WWW-Authenticate cause some error when java invoke api in IdentityServer4
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[ ] Unit Tests for the changes have been added (for bug fixes / features)

Other information:

Not sure the value "Restricted" makes sense. Perhaps use "IdentityServer".

Saw "Restricted" on nginx, i think both are ok, now it has been changed to IdentityServer


I added Hellow world with design

What does the program do ?

In what programming language it is written?

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


[QUESTION] Will you update package?

It is not compatible with new versions of depended packs.

How did you fix that, I can not install the plugin because it's conflicting with 2 other dependencies

I added conflicting packages independently to .yaml
But of course it is temporary solution for now. Still need update here.


Choice of the value in the HashSection

Hi, in the HashSection function you wrote:
hash = *str + (hash << 6) + (hash << 16) - hash;
just out of curiosity is there anything special about the numbers 6 and 16?

Sorry for my late reply, I borrow the codes from under url, sdbm hash.
http://www.cse.yorku.ca/~oz/hash.html


HTML report missing incomplete/review issue element details and fix the following sections.

It would be great if we have the details of issues under incomplete section with Element locator, Element Source and Fix the following section for the each issue similar to that of axe chrome extension report review section as shown below.

Hi @rshidling I was just looking for this enhancement as well! Have you implemented any kind of workaround that's worked for you?


Allow engine_v2 recipes to fetch a build configuration from monorepo repository

As with the engine_v2 coordinator recipe engine_v2 when it runs a flutter/engine build, I would like
the coordinator to download the build properties for the monorepo builds from a .json configuration
file in the monorepo repository.
This can be done by adding flexibility to the build properties download step, so it checks out the monorepo repository
instead of the engine repository. Exactly the same check as is used in
https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine_v2/builder.py#207
can be added when downloading the config, to checkout monorepo instead of flutter/engine, and download from a path in that repo.

Has this been implemented?


ambient: traffic passing through istio-gateway does not gain TLS communication

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description

Traffic from/to istio-gateway from/to app does not gain mTLS communication.
More specifcally one of curl commands from sleep in this docs is not displayed as encrypted.

Reproduce steps:
1. Deploy Istio with the steps in this docs.
Note: I used Istio APIs instead of Gateway API.
2. Adding your application to ambient
In the section "Adding your application to ambient", it has a curl command from sleep to $GATEWAY_HOST/productpage as:
$ kubectl exec deploy/sleep -- curl -s "http://$GATEWAY_HOST/productpage" | grep -o "<title>.*</title>"

However, it is not encrypted in Kiali display.
Please refer to this image:

The path sleep-latest -> istio-ingressgatewy -> productpage is not encrypted. Actually the image "Kiali dashboard" in the docs also not encrypted.
Additional note:

Other two commands below have no problem.

$ kubectl exec deploy/sleep -- curl -s http://productpage:9080/ | grep -o "<title>.*</title>"
$ kubectl exec deploy/notsleep -- curl -s http://productpage:9080/ | grep -o "<title>.*</title>"

Adding istio-system ns into ambient stops working the traffic.

$ kubectl label namespace istio-system istio.io/dataplane-mode=ambient
$ kubectl exec deploy/sleep -- curl -s "http://$GATEWAY_HOST/productpage"
upstream connect error or disconnect/reset before headers. reset reason: connection termination

Version
$ istioctl version
client version: 1.19-alpha.8601b0908c15acf9b9c7decdaf80f8a447f835f3
control plane version: 1.19-alpha.8601b0908c15acf9b9c7decdaf80f8a447f835f3
data plane version: 1.19-alpha.8601b0908c15acf9b9c7decdaf80f8a447f835f3 (4 proxies)

Only monitoring tools are 1.18 installed via the following commands.
kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.18/samples/addons/prometheus.yaml
kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.18/samples/addons/kiali.yaml
kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.18/samples/addons/jaeger.yaml

Additional Information
No response
Affected product area

[X] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

I vaguely recall this was a Kiali bug but cannot find the reference

Thank you! I'm asking Kiali team if anyone can comment here - https://istio.slack.com/archives/CJVRXB09F/p1687311811339699


annotations support for appmesh-gateway helm chart

Please add support for pod, service and service account annotations in appmesh-gateway helm chart.

The Flagger's gateway has been deprecated in favour of the official App Mesh one https://github.com/aws/eks-charts/tree/master/stable/appmesh-gateway


[nextjs] Nodejs process doesn't stop

Describe the bug
I'm having a strange issue on windows. When I run dev mode, stop it, and then try to run it again, Next.js starts on a different port. I've found the cause, the node runtime isn't terminated when the app is stopped. If I try to access the original port, nothing is served, and I get a timeout, but the port remains blocked because the runtime is still running. I'm not sure if this can be fixed, as I don't know if it's possible to do anything if you stop dev mode.
Quinoa version
2.4.9
Quarkus version
3.13.2
Build / Runtime
Next.js
Package Manager
YARN
Steps to reproduce the behavior
Described above
Expected behavior
The nodejs runtime should be terminated and port should not be blocked.

OK it might be specific to Yarn?  I have not had any trouble with straight NPM on Windows and I use Quinoa a lot.
Can you put together a small reproducer showing the issue?

I have tested this directly from the command line (frankly, I could have done this before opening this issue) and it seems that if you execute mvn quarkus:dev and then stop it, it works and everything terminates perfectly fine. However, if you use IntelliJ and execute it through the UI or through 'Execute Maven Goal', it won't stop the process. I wonder if, when you stop it through IntelliJ, it doesn't terminate Maven gracefully but instead kills it, which would result in this behavior?

I am no expert on the IntelliJ plugin but you are right i am going to guess it some how shuts down differently than the command line.  Not sure where you report IntelliJ plugin issues but maybe on Quarkus Zulip channel to start to see what any of the devs say?  They might be able to guide you to the correct place.
I am going to close this as not a Quinoa issue for now...I can re-open if they report back that we aren't doing something correctly.


Can I change the viewpager_animatedHeaderImage flag on code?

I was thinking:

to simply change the state of app:viewpager_animatedHeaderImage through databinding
execute onFinishInflate() method of the materialViewPager.
but anyway I wish to have an opinion from the contributors.
Thanks in advance


Invalid signature file digest for Manifest main attributes

We are using zookeeper-3.4.10.tar.gz (https://archive.apache.org/dist/zookeeper/zookeeper-3.4.10/zookeeper-3.4.10.tar.gz) in our project. When running the scan we got following error
04:56:41 [INFO] Finished Archive Analyzer (3 seconds)
04:56:41 [INFO] Finished File Name Analyzer (0 seconds)
04:56:43 [WARN] An unexpected error occurred during analysis of '/home/jenkins-master/workspace/build-pipeline-ocscli.scan/dependentImages/prod-search-mesos-framework-zookeeper/contrib/fatjar/zookeeper-3.4.10-fatjar.jar' (Jar Analyzer): Invalid signature file digest for Manifest main attributes
04:56:44 [INFO] Finished Jar Analyzer (3 seconds)
04:56:58 [INFO] Finished Central Analyzer (13 seconds)
04:56:58 [INFO] Finished Assembly Analyzer (0 seconds)
04:56:58 [INFO] Finished Dependency Merging Analyzer (0 seconds)
04:56:58 [INFO] Finished Version Filter Analyzer (0 seconds)
04:56:59 [INFO] Finished Hint Analyzer (0 seconds)
04:57:00 [INFO] Created CPE Index (1 seconds)
04:57:00 [INFO] Skipping CPE Analysis for npm
04:57:03 [INFO] Finished CPE Analyzer (4 seconds)
04:57:03 [INFO] Finished False Positive Analyzer (0 seconds)
04:57:03 [INFO] Finished NVD CVE Analyzer (0 seconds)
04:57:03 [INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
04:57:03 [INFO] Finished Dependency Bundling Analyzer (0 seconds)
04:57:04 [INFO] Analysis Complete (26 seconds)
04:57:05 [ERROR] Invalid signature file digest for Manifest main attributes

I'm not sure if this is an issue with dependency-check.  In the referenced zookeeper archive I do not see a zookeeper-3.4.10-fatjar.jar - so I am assuming part of your build process creates this? If that is the case then the fatjar is being created incorrectly as it is combining the signatures from a signed JAR into the fatjar.  See the stackoverflow question on the topic. If you are generating the fat jar you need to configure it to strip the signatures.

Jeremy, thanks for your fast investigation.
We use this directly from apache.org, we don't build this. You can find the zookeeper-3.4.10-fatjar.jar in the referenced zookeeper archive in directory zookeeper-3.4.10.tar/zookeeper-3.4.10/contrib/fatjar

If you test the signature on the provided fatjar you get the following results:
$ jarsigner -verify -verbose zookeeper-3.4.10-fatjar.jar
jarsigner: java.lang.SecurityException: Invalid signature file digest for Manifest main attributes

The issue is not with dependency-check. The fatjar was created incorrectly.

You could configure dependency-check's <failOnError>false</failOnError>.

Jeremy, thanks a lot. About the failOnError configuration: How can I do this, I don't find anything in the documentation. We are using the docker image of owasp/dependency-check. Can you point me to the documentation where I can find informations about configuration. Thx.

Sorry, assumption on my part. For some reason I thought you were using the maven plugin rather then the docker/cli. I believe the report, etc. will still get created. However, I also just realized that the error will prevent the correct analysis of the fatjar...
The best option would be to contact the zookeeper team and ask about the invalid signature; alternatively you could submit a patch back to the build.xml in the contrib/fatjar. An exclude like the one below likely needs to be added to the file sets being used to generate the fatjar:
<zipgroupfileset dir="lib" excludes="META-INF/*.SF,META-INF/*.DSA,META-INF/*.RSA"/>


Add Code Samples for Common Scenarios

Add code samples in the README and sample files that run through basic common scenarios such as the following:

[ ] Create if not exists
[ ] Listing containers or blobs and creating clients from the listings
[ ] Upload if not exists
[ ] Overwrite if exists

[ ] Downloading to a file
[ ] Setting a proxy
[ ] Working with BlobStreams
[ ] Generating/setting a sas

Also, just for tracking, ensure we have these scenarios covered in v8<->v12 as well


Update concept-di-container.md

Added missing comma

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
-

Fixed issues
-

Thanks!


I've installed it, but why does this link open a comfyui page and turn it into a browser?

I've installed it, but why does this link open a comfyui page and turn it into a browser~ Do I need to set something else?

/

click here to turn off the wide mode


installation problem

I tried to install looper by using pip in the cemm server (with --user), but it failed with this error message:
PermissionError: [Errno 13] Permission denied: '/cm/shared/apps/RSeQC/2.6.4/cm/shared/apps/python/2.7.6/lib/python2.7/site-packages/RSeQC-2.6.4-py2.7.egg-info/PKG-INFO'
I have already tried with different python and pip versions, but did not work out. Does anyone know how to handle this, or an alternative (without pip) installation?

Hi Murat,
This doesn't seem to have anything to do with which version of python or looper you're using but with other software you have loaded in the cluster. You can test this by installing inside a virtualenvironment (like here for example).
RSeQC causes problems frequently with other libraries and I'm not sure why. Try unloading this module.

Yes, unloading RSeQC solved the problem. Thanks.


Error in mapreduce call while calculating molecular weights.

Hello Paul,
Thank you for a great talk at Juliacon 2021.
There is an error in the mapreduce call calculating molecular weights. The operators +,* should be interchanged to fix this issue. I have sent a pull request to fix this
Regards
Ramesh

Thanks again for pointing out this issue.


Backup datatstore operation for rsync driver

To report a security issue please follow this procedure:
[https://github.com/OpenNebula/one/wiki/Vulnerability-Management-Process]
Description
When is executed the backup operation for the rsync backup datastores, the command fail if the user has specified a different  RSYNC_USER than oneadmin.
To Reproduce
Backup to a datastore (type backup and driver rsync) using a different user than oneadmin as RSYNC_USER and the oneadmin user didn't exist in the rsync_host
Expected behavior
A clear and concise description of what you expected to happen.
Details

Affected Component: [datastore driver rsync, make_dst_path action]
Hypervisor: [KVM]
Version: [6.6.0]

Additional context
part of the driver delivered
rc = TransferManager::Action.ssh('make_dst_path',
:host => rsync_host,
:cmds => "mkdir -p #{backup_path}")
can be changed to:
rc = TransferManager::Action.ssh('make_dst_path',
:host => "#{rsync_user}@#{rsync_host}",
:cmds => "mkdir -p #{backup_path}")

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

Fixed Thanks!


Request: one menu option for “overrides”

Is it an idea/option to have one place for profiles/targets/overrides?
Right now the app provides Temp Targets with some limited possibilities for changes.
There is also the section with profiles with very many possibilities for changes.
Why the section of Temp Targets still exists?
Could a name change help?
For example: change the menu name “Profiles” to “Overrides“ (or whatever) and replace and eliminate the Temp Targets menu. So it is not about “profiles” or “temp targets”. It is about overriding the current settings for a limited time or indefinitely.

Closing profiles exist now as well


[Bug]: File-picker button still shows old value in the following scenario

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When, in a file picker, I bind the visible property of the widget to a checkbox. Now, on deploy, I choose say 5 files. Then uncheck the visible property.. The file-picker disappears.. Now, when I check the visible property checkbox, the file picker button still reads as 5 files selected, but in the file picker modal, there are no files listed. On browsing again, and choosing say 2 files, the number on the button adds up to the above 7, though there are only 2 chosen.
Steps To Reproduce

Add a file picker widget to the canvas.
Bind its Visible property to a checkbox. (If checked = true, else = false)
Maximum number of files, give a limit of say 10.
Deploy the app. Now select say 5 files in the file picker and click upload.
Uncheck the box to make the file-picker widget invisible.
Again check it to make it visible.
Now it is seen that the number on the button indicates 5 files selected. However, on clicking the button, the modal shows up empty.
If we select two files in the modal and upload, it shows 7 files selected, though only two were selected from the modal.

Public Sample App
No response
Version
Production

Valid issue, happens when the filepicker is hidden. Unsure about reach, but assuming people who have marked filepicker's isVisible. Looking at data where it's js controlled i found roughly 10 unique values where this can happen
Stats

Stat
Values

Reach
10

Effort (months)
0.5


Fix error when ecs::join-ing with unregistered components

Add the World::addStorage() function to force the registration of a component
Closes #112

Codecov Report

Merging #113 (add63d0) into master (19838c2) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   20.38%   20.33%   -0.06%
==========================================
  Files          88       88
  Lines        1388     1392       +4
  Branches      508      508
==========================================
  Hits          283      283
- Misses        975      976       +1
- Partials      130      133       +3

Impacted Files
Coverage Δ

src/ecs/resource/Timer.hpp
0.00% <ø> (ø)

src/ecs/join/MaybeJoin.hpp
69.23% <50.00%> (-22.44%)
:arrow_down:

src/ecs/world/World.hpp
68.42% <50.00%> (-4.92%)
:arrow_down:

src/ecs/join/Join.hpp
66.66% <0.00%> (+3.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19838c2...add63d0. Read the comment docs.


Create a register page via html with jinja

This issue is part of the 'sign up' scrum team.

made redundant by #77
@lioramilbaum  please close this issue.


build: print build fail message

Otherwise, CI turns green even on compile errors (Semaphore CI).

doesn't this create a dependence on the grep FAIL hack in semaphore? if the test script exits early with $?==0 when build fails, then that's what should be fixed

@heyitsanthony All fixed. PTAL. Thanks.

This still bakes in relying on the semaphore grep FAIL hack; the problem is tee eats the exit code. There are probably other places besides the build pass where the test script could fail without emitting a FAIL, so this won't catch everything.
I think the fix would be to change semaphore to have bash -c "set -o pipefail; RELEASE_TEST=y INTEGRATION=y PASSES='build unit release integration_e2e functional' ./test 2>&1 | tee test.log" so the nonzero exit code is passed to semaphore.

@heyitsanthony That worked. Thanks!
https://semaphoreci.com/coreos/etcd/branches/pull-request-8301/builds/8


fix netzkino extractor for subcategory urls

Some movies on netzkino are in subcategories, but the api url is only for main category. E.g. http://www.netzkino.de/#!/science-fiction-kinoab18/downstream will not load with current extractor. This PR fixes this by splitting the category and taking only the last part.

There is another URL format: http://www.netzkino.de/#!/kinoab18-all/downstream.
Tests should be added.

Oh. Just noticed the URL I provided doesn't work with my fix. Before I was using a movie from the "Prickelkino" category.
So there are different formats

http://www.netzkino.de/#!/kinoab18-all/downstream
where the main-category is in front of the dash

http://www.netzkino.de/#!/prickelkino-kinoab18/night-eyes-iii-ov
where it's the other way around.

Interestingly the first URL works only with the first part kinoab18 as category, but the second works with either prickelkino or kinoab18 but not with prickelkino-kinoab18. So I changed my PR.

http://www.netzkino.de/#!/science-fiction-kinoab18/downstream does not work now.

Dann. When I have some time, I'll scrape their entire website go find out wjoxh different formats they use.


NO results from paheal (http vs https)

What steps will reproduce the problem?
Searching for images on paheal with https disabled (which is default).
What is the expected behavior? What do you get instead?
Expect to get image results when searching, but with the https option unchecked (which is the default), paheal does not load.
How often does this problem occur?
Seems to be an issue all the time now.
What version of the program are you using? On what operating system?
5.3.3
Windows 10.
Please provide any additional information below
Enabling https in the source makes it work again, but downloads won't work. It seems paheal has switched to https but the images are still in http links. Maybe there's a way to use https for searching and http for downloading?

I have no problem loading paheal using the default non-HTTPS settings.
Loading http://rule34.paheal.net/ NSFW in my browser also works (actually, both HTTP and HTTPS work on their website, except that as you said images are always over HTTP).
Maybe it was a temporary issue?

Closing for lack of update and reproducibility.
Feel free to re-open and provide some more information if the problem persists.


[P1][Bug][a11y] Focus order of "customization" bottom sheet is incorrect

Prerequisites

[X] I have searched the backlog for duplicate or closed feature requests

Your test device
iPhone 14 Plus
OS Version
17.1.1
App version
v0.18.0
Describe the issue
Inside almost all variants, when there's a "customization" bottom sheet, in most of cases, the focus order is not correct
Sometimes the first element focused is "customization" (instead of page title or main description), sometimes elements inside the sheet are ordered inconsistently.

NB: behavior is correct on variant Buttons>Icons and Sliders demo
Expected Behavior
On each variant page, focus order should be :

back button
colour palette
3 all interactive elements in demo view (focus forced on first element of this view on page loading)
customization sheet, and following elements in order
tab bar

OK sur 0.18<PHONE_NUMBER>)


Html widget

Add apostrophe-html-widget, which supports not rendering the widget if the option safeMode is present (as a get or a post param) or if the rendering is occuring due to an AJAX request (because in that context, a document.write could break our world).
@boutell I've made the changes we discussed.

Beauty! @mcoppola, the html widget has landed, thank Jimmy, I just did a quick consult.


Basket cart prediction using Apriori algorithm

The aim is to build a recommendation system for an online shopping cart using the Apriori algorithm further adding an interactive user interface created with Streamlit. This system can enhance the shopping experience by suggesting relevant products, potentially increasing sales and customer satisfaction.
@Niketkumardheeryan  I would like to work on this issue as part of GSSoC.

@Niketkumardheeryan I cant see the reflection on the leaderboard. Could you please check it once?


V3 workbox cache expiration

R: @jeffposnick @addyosmani @philipwalton
I stopped at this point because I altered the DB and touched a mess of stuff. Woohoo.

LGTM, but the automated tests are now unhappy.


RFC: Future of User Data

Description of Problem
DNN currently uses a single user object for all sites within a multitenant instance. There is one user with ID, Login Name, Display Name, Email address, first name and last name, shared by all sites. Besides, each user has membership to (each or specific sites) and a profile for each site (containing individual first name and last name as well)
There had been frequent complaints about same user might not be created for a second site, unless using same credentials. And modifying first or last name does not get properly reflected (affect current site or all sites???) - while updating other profile properties affect current site only.
Proposed Solution Option 1
sync FirstName and LastName across all sites within installation (like DNN 3-5.5). Any change will affect all sites, as user.FirstName and user.LastName become "master" again.
Implementation should be trivial.
Proposed Solution Option 2
generalizing solution 1, we may sync across sites all profile properties with same name and data type, i.e. if a user updates his address, it will automatically affect all sites. This may also been applied to superusers as well to avoid special treatment of them. we may add a host setting "syncUserProfiles" to enable this feature.
This will not cause significant effort to implement
Proposed Solution Option 3
decouple user profiles from sites. Each site (or mastersite of a site group) gets its totally independent user profile, user objects are site specific and a user "myusername" from site A does not share anything with "myusername" from site B.
This will cause the biggest effort and may fail, if 3rd party modules didn't place an FK on users table.
Proposed Solution Option 4 (half way 3)
don't touch current user object (including aspnet_users and aspnet_membership), but move properties "DisplayName". "FirstName" and "LastName" to UserPortals table (maybe extended by prefix and middlename). The formula to (optionally) construct the displayname from firstname etc. nees to be moved from HostSettings to portalSettings as well, allowing it to be defined per site.
In a multi-tenant DNN instance, this will keep the constraint that a user can only register to a second site with same username and email address (or just email address, if it is used for login) using the same password, but may used different first name, last name and display name, and if he decides to leave one site, these information may get obfuscated (or deleted). We are still open to implement the feature of syncing names and profile properties, if desired. This may cause compatibility issues, if 3rd party extensions rely on the current data structure.
Note: I would not move the names only to the properties table, as this table is not really efficient for retrieving the values. We could also add a "calculated" profile data type, which generates its content from other columns of users, portalusers and userprofile tables instead of relying on names - as a default to be edited or readonly.
Alternatives Researched
There are pros and cons for each option, the biggest con to option 3 is the risk to fail upgrade for 3rd party modules. IMO option 2 would provide the best benefit for current users.
Affected version

[x] 10.x or later

To give my two cents: I think that solution option 2 would be the most "logical" enhancement, but there could be some problems with the GDPR (also with solution option 1) as well, if a user wants to get deleted from one portal, but not from the other. There is a need to accomplish this, or a solution where users are and portals are strictly separated.
I have worked for a bigger organisation that has setup different portals for different projects, something like a.organisation.xyz, b.organisation.xyz etc. The biggest issue was that when a user, who was already registered for project A and wanted to register for project B but using a different password (which is respected as a good proctice) got confused, because he got a message that this user already exists. Most of them went on and choose a different username, and created a second, third, etc. login. This was definitely not the intention.

Overall I like the behavior of Solution 1, as that has the least impact as the user is still in control of the visibility etc.  If we expand this to other fields, I'm a bit concerned that with Option 2 we would get into a situation where a user could have something that was "private" on one installation and public on another etc.  It sounds like you might already be thinking of this, but just a through.

Vote for Solution 3 as most simple and bullet-proof.

I would follow MaikITs thinking that data privacy has some potential horrors here, and this will follow through all future legislation even the US' I believe.   Imagine that with 100,000 users!  If a person's name is on a forum entry then that's open for discussion in the portal's privacy policy as deletion doesn't necessarily mean redaction. Pseudo naming is a whole other bag of worms.
Go for the single user record with access to portals as necessary. Whether what they have is public or private content makes little difference in practice, its what you hold that is important.   You just must not mix up users even if they share the same name, thus creating an inadvertent disclosure of someone else's data.  Not so much a problem for employees of the same business, a nightmare if the platform is public.

I have once worked for a bigger organisation that has setup different portals for different projects, something like a.organisation.xyz, b.organisation.xyz etc. The biggest issue was that when a user, who was already registered for project A and wanted to register for project B but using a different password (which is respected as a good practice) got confused, because he got a message that this user already exists. Most of them went on and choose a different username, and created a second, third, etc. login. This was definitely not the intention.

I think this case could be resolved using external authentication systems, like AD.

I think this case could be resolved using external authentication systems, like AD. Just not "using a different password for every project" in the same organisation, of cause 😄

No. Because most of the users were not members of the organization itself, and therefore not "objects" in the AD. And you can't force people to use Facebook, Google or whatever authentication.

I think this case could be resolved using external authentication systems, like AD. Just not "using a different password for every project" in the same organisation, of cause smile

No. Because most of the users were not members of the organization itself, and therefore not "objects" in the AD. And you can't force people to use Facebook, Google or whatever authentication.

OK, it looks like special case for me - and as with all special cases we need solid (read "simple") base for third-party extensions which would provide solutions for different cases. I think it's not very hard to implement some kind of sync between different user profiles by some matching field like email - if it really needed.
Still like to see more love to site groups in DNN... For solution 3, it's likely better to have different account types for single site and site groups.

@MaiklT, @KenTombs, @roman-yagodin
Regarding privacy, we are in the same situation now: if a user registered for multiple sites using same username and passwords, his displayname, first name and last name is shared and can be retrieved in forums etc. from users object, where the information is still needed for the other sites, he is still an active member of. A module can check for userportals.isdeleted or the record existing, but this is not under control of DNN and I fear, a number of modules will miss this requirement.
I added option 4 above. where those fields would be moved to userportals table, i.e. become site specific. This will not affect login name and email address (which should not been displayed to other users anyways), but in alternative 4, the display names could be obfuscated or erased per site.
However, if you are using public registration on multiple sites with email as user name, the user can register only to a second site, if using the same password or a different email address.

@mitchelsellers
when syncing the properties in option 2 or 4, we would for sure not touch visibility settings of the properties and might not sync, if there has not been a value entered before. Besides, this should be an option, the host may enable for superusers, admins or all users,

IMO, this is the general question: how many DNN instances are used for multiple sites with public access targeting different audiences (i.e. without using site group feature) - and how big is for these sites the risk of same user trying to register? if the sites are totally independent (e.g. shared DNN hosting), the biggest constraint currently is registration being blocked, if email used for login and the address is already used in a different site. This can only be solved by option 3, otherwise individual DNN instances should be used.
If, on the other hand, users are aware that the sites are somehow "connected" (same owner,...), they would expect updates to their profile affecting all sites, not just the current one, which would lead to option 2 or 3 with syncing the profile.

PS: if we are not implementing Option 3, we should at least display a hint to a member of multiple sites, when he updates his user name or password ("Your account data has been updated. Please note, this affects your membership for domain1.com and domain2.org")-

This RFC is still to keep right ?

Yes, we need to get someone to lead the implementation on this one.

this is still valid and needs to be turned into a bundle of action items.

this is still valid and needs to be turned into a bundle of action items.

I have thought long and hard on this topic.  I believe I have created a number of issues in the past that are directly related to this issue being discussed.
I believe that in my mind each registration or user should be considered an object.  That object is part of one portal or a master portal (site group).  When joining sites together a master portal is created.  This should be the portal each user is registered to a site that gets added to a site group should then have that users registered Portal ID link to the master portal for all users so they sync with the master site portal id.  And a way to merge users possibly asking them to fill in the blanks as needed or select the information that best fits between the two when they log in possibly.   If you ever remove a site from a site group you should then have options of which users you want to move if any to that site.
It would also be nice if security roles traveled with the user id plus site id and a master site security roles are added to all sites in the site group.   So you can have "Content Managers" role appear on all and manage them from any portal in that site group.
The profiles should all be the same for a group and registration fields should align with master portal settings and those fields should be set across all portals for viewing profiles and updating user information.
The issue is the Unique Email that is set in the web.config.  This needs to be set to a scope that is sites or site groups using a Unique Email per site or site group.
If you have this set in the web config you run into issues allowing people in a similar area of sites that happen to be on the same DNN instance is you cannot register or login on different sites or click on a verification link if in a site group.
This would definitely take some careful thought making a solution that can cure these user account issues.
This is my two cents hopefully some of it makes some...

Testing a comment

Still an issue.