Impl 338

BTW, there might be a room to improve (refactoring) subscribe/unsubscribe functions.
I want to do that after deprecated functions are removed.
This PR keep the original way of implementation.


Add sourcemaps and production mode in webpack bundles

👍🏻  Nice, please just add a line in the changelog, like this, and we're ready to go
Add sourcemaps and production mode in webpack bundles #83

I'll do it


Yolov8 on OAK-1 using depthai_sdk

Hi,
I am trying to deploy a custom yolov8 model to an OAK-1 camera using the depthai_sdk, however when I am executing the script I get the following error:

This is not a YOLO detection network! This configuration attempt will be ignored.

The code that I am running is the following:
with OakCamera() as oak:
    color = oak.create_camera('color')
    nn = oak.create_nn("yolov8s_cld.blob", color)
    with open(str(Path("yolov8s_cld.yaml").resolve())) as file:
        conf = json.load(file)
        nn.config_yolo_from_metadata(conf['nn_config']['NN_specific_metadata'])
    oak.visualize(nn.out.passthrough, fps=True)
    oak.start(blocking=True)

And the .yaml file content is as shown below:
{
    "nn_config":
    {
        "output_format" : "detection",
        "NN_family" : "YOLO",
        "input_size": "640x640",
        "NN_specific_metadata" :
        {
            "classes" : 2,
            "coordinates" : 4,
            "anchors" : [],
            "anchor_masks" : {},
            "iou_threshold" : 0.5,
            "confidence_threshold" : 0.5
        }
    },
    "mappings":
    {
        "labels":
        [
            "class-1",
            "class-2"
        ]
    }
}

I was wondering if the yolov8 models are supported in the depthai_sdk or if I have to try a different approach using the depthai API building the pipeline from the start?

@ptoupas could you try:
nn = oak.create_nn("yolov8s_cld.blob", color, nn_type="yolo")

Otherwise you'd likely need to pass in json, which holds the metadata and model path, similar to jsons here:
https://github.com/luxonis/depthai/blob/main/depthai_sdk/src/depthai_sdk/nn_models/yolo-v3-tiny-tf/config.json
And instead of the model_name, you'd specify either blob, or xml + bin (openvino format, gets converted on-the-fly to blob).

@Erol444 Thanks for the quick reply!
By using the combination of adding the nn_type="yolo" argument when calling create_nn() and by using the .blob as produced by this tool https://tools.luxonis.com/ it seems to work now, thanks a lot!
I just wanted to give you some extra feedback. When I use the .blob model which I have converted from .onnx using this tool https://blobconverter.luxonis.com/ it seems to not working. I am not sure what is the issue, it might be something with the nms not being incorporated or something, but I get this error:

Mask is not defined for output layer with width '8400'. Define at pipeline build time using: 'setAnchorMasks' for 'side8400'.

Thank you for your assistance in quickly resolving my issue.
Best!

Hi @ptoupas ,
I believe that's because tools.luxonis.com will change the yolo architecture a bit, so also the anchor masks won't be the same as using blobconverter (which doesn't alter the architecture). Great to hear your issue was resolved!
Thanks, Erik


Add Docker to provider list supporting workload clusters

Description of changes: Added the Docker provider to the list of EKS Anywhere providers that support the management/workload cluster topology.

/lgtm

/cherry-pick release-0.13


Feat/folder seq

Description
draft: folder/file sequencing
https://github.com/usebruno/bruno/assets/25679466/2ba2bf85-8dd2-4b14-b997-ec1a6889e2f0

If this is still being worked on the order of requests when running a collection should reflect this custom order instead of the old ordering logic.

Do you need help to get this merged? I can open another PR with conflicts resolved
I think it would resolve those 2 issue
Resolves #1974
Resolves #1568

what is missing to get this merged ?

We are right now held up other priorities this week.
This PR has been worked on by @lohxt1 (who is a FTE on Bruno Team)
We plan to focus on getting this merged his early Oct.
Meanwhile, the community can help review the PR, test i, identify bugs or suggest changes.


Bug: laggy scrolling

Type
UI-related issues
Bug description
Laggy scrolling & laggy viewer
Steps to reproduce
Step 1. Open random booru
Step 2. Open viewer
Step 3. Scroll
Android version
13
App version
1.4.1
Screenshots or videos
No response
Solution
Loading in a non-UI thread
Additional context
No response
Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

Only the animation lags. Perhaps it is possible to make it possible to move to the next image without animation by clicking in the right/left zone of the viewer?

Only the animation lags. Perhaps it is possible to make it possible to move to the next image without animation by clicking in the right/left zone of the viewer?

maybe it's possible, I'll look into the code

I think this is substantially underselling the effects. I have a Samsung S23 Ultra, and the app is basically unusable after 2 or 3 pages worth of posts.

I think this is substantially underselling the effects. I have a Samsung S23 Ultra, and the app is basically unusable after 2 or 3 pages worth of posts.

Yes man, ± same issue
So maybe it because my tag blacklist? Its huge

Maybe due to the Flutter framework they've used, and needs optimization to avoid stuttery on scrolling.
Me, I disabled the blur in settings and it improved quite well, but the lag still persist. Mine using an old phone with Helio P23 SoC, 3GB of RAM, Android 9.

Me using phone with Snapdragon 732G, 8GB + 3 swap RAM, Android 13, so idk

The app is still completely unusable, by the way. I'm going to download some alternative until this one is functional again.


[Bug]: Current Driverstandings gives a 500 error

Description
When going to https://api.jolpi.ca/ergast/f1/current/driverStandings.json I get a 500 error
Affected URL
api.jolpi.ca/ergast/f1/current/driverStandings.json
To Reproduce
Go to https://api.jolpi.ca/ergast/f1/current/driverStandings.json
Expected Behavior
No 500 error but json response
Supporting Data / Screenshots
No response

Thanks for reporting, issue should be resolve now :)


[custom server] Handle internal routes automatically

Fixes https://github.com/zeit/next.js/issues/1627

Did you still get HMR after this change?

@rohmanhm Yes. Any issues?

If so, submit an issue with more details.


fix(statutory): fix setting fee paid for members list. Fixes HELP-1305

apparently we send fee_paid as string and for whatever reason backend also returns it as string (it stores it properly though), so I've done 2 things: converting this value to a float and 2) updated the input so it'd only accept float values (so if you'll type aaa, it'll complain)

:tada: This PR is included in version 1.13.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: images

Fix RM-XYZ

🧰 Changes
Fixes saving images. I mucked with the attributes and got it wrong. OOps.
🧬 QA & Testing

Broken on production.
Working in this PR app.

@jennspencer and @trishaprile - For expediencies sake, I'm going to merge this now. If you have any review notes, let me know.

@jennspencer and @trishaprile - For expediencies sake, I'm going to merge this now. If you have any review notes, let me know.

oh! i'm working on embeds and images saving properly in another branch, embeds are proving to be rather wiley and inline images totally get toasted

This PR was released!
🚀 Changes included in v6.75.0-beta.41


Bug: orchestrator restarts after deployment if there are changes in consumer config

📜 Description
It bugs out while deploying orchestrator specifically when there are changes around NATs config with context deadline exceeded error while trying to update consumer config. error is as added below :
{"level":"error","ts":1721198981.6713727,"caller":"pubsub-lib/PubSubClientService.go:336","msg":"failed to update Consumer config","received consumer config":{"durable_name":"DEVTRON-CHART-PRIORITY-GITOPS-INSTALL-DURABLE","name":"DEVTRON-CHART-PRIORITY-GITOPS-INSTALL-DURABLE","deliver_policy":"last","ack_policy":"explicit","ack_wait":120000000000,"max_deliver":-1,"filter_subject":"DEVTRON-CHART-PRIORITY-GITOPS-INSTALL-TOPIC","replay_policy":"instant","max_ack_pending":1,"deliver_subject":"_INBOX.yUzuqkpjxgjQISwdsb27am","deliver_group":"DEVTRON-CHART-PRIORITY-GITOPS-INSTALL-GROUP","num_replicas":0},"err":"context deadline exceeded","stacktrace":"github.com/devtron-labs/common-lib/pubsub-lib.PubSubClientServiceImpl.updateConsumer\n\t/go/src/github.com/devtron-labs/devtron/vendor/github.com/devtron-labs/common-lib/pubsub-lib/PubSubClientService.go:336\ngithub.com/devtron-labs/common-lib/pubsub-lib.PubSubClientServiceImpl.Subscribe\n\t/go/src/github.com/devtron-labs/devtron/vendor/github.com/devtron-labs/common-lib/pubsub-lib/PubSubClientService.go:161\ngithub.com/devtron-labs/devtron/pkg/eventProcessor/in.(*WorkflowEventProcessorImpl).SubscribeDevtronAsyncInstallRequest\n\t/go/src/github.com/devtron-labs/devtron/pkg/eventProcessor/in/WorkflowEventProcessorService.go:1024\ngithub.com/devtron-labs/devtron/pkg/eventProcessor.(*CentralEventProcessor).SubscribeAll\n\t/go/src/github.com/devtron-labs/devtron/pkg/eventProcessor/CentralEventProcessorService.go:115\ngithub.com/devtron-labs/devtron/pkg/eventProcessor.NewCentralEventProcessor\n\t/go/src/github.com/devtron-labs/devtron/pkg/eventProcessor/CentralEventProcessorService.go:39\nmain.InitializeApp\n\t/go/src/github.com/devtron-labs/devtron/wire_gen.go:1175\nmain.main\n\t/go/src/github.com/devtron-labs/devtron/main.go:28\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:267"}
👟 Reproduction steps

Deploy orchestrator changing NATs consumer. It is although not exactly replicated, it could be intermittent but it is evident that this happens when there are changes in NATS consumer config.
For instance : try changing the CONSUMER_CONFIG_JSON: '{"DEVTRON-CHART-INSTALL-DURABLE":{"natsMsgProcessingBatchSize":1}}'

👍 Expected behavior
It should have retry mechanism which until consumer config is updated.
👎 Actual Behavior
It fails almost after 20 seconds when orchestrator is not able to update the Consumer config.
☸ Kubernetes version
NA
Cloud provider

NA

🌍 Browser
Chrome
🧱 Your Environment
NA
✅ Proposed Solution
NA
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#10178

Above issue happened because of missing ConfigMap from orchestrator for running multi replica for NATS.
ConfigMap :
NATS_MSG_REPLICAS: "3"
Closing the issue.


Add overloads for call methods that accept query/response and conversation

…rsation
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-evaluation

multiple test gates passing and previous run was passing

/check-enforcer override


add: Atik Vohra Profile

@Gyanthakur Pls review my commit and merge.

_ No description provided. _

you make a mistake

fix your profile image in project section

Hope it is fine now @Gyanthakur


Load ringtones list asynchronusly

[x] Load ringtones from the DB and media provider in the worker thread.
[x] Display loader until all the list gets loaded.

Issue fixed in cfb65b4cc122dac77e7460ec29c07a3467a2c248.


Propose to support file upload form control

include upload library (e.g. ng-upload) will increase the whole package size. I'm more glad to see a general way to embed icons and behaviors.

Note that currently the widget is tested with ng-fileupload 5.0.9. Please stick on this version.


[Errno 2] No such file or directory: 'my_autotrain_llm/checkpoint-108/adapter_model.bin'

Prerequisites

[X] I have read the documentation.
[X] I have checked other issues for similar problems.

Backend
Colab
Interface Used
CLI
CLI Command
!autotrain llm
--train
--model ${MODEL_NAME}
--project-name ${PROJECT_NAME}
--data-path data/
--text-column text
--lr ${LEARNING_RATE}
--batch-size ${BATCH_SIZE}
--epochs ${NUM_EPOCHS}
--block-size ${BLOCK_SIZE}
--warmup-ratio ${WARMUP_RATIO}
--lora-r ${LORA_R}
--lora-alpha ${LORA_ALPHA}
--lora-dropout ${LORA_DROPOUT}
--weight-decay ${WEIGHT_DECAY}
--gradient-accumulation ${GRADIENT_ACCUMULATION}
--quantization ${QUANTIZATION}
--mixed-precision ${MIXED_PRECISION}
$( [[ "$PEFT" == "True" ]] && echo "--peft" )
$( [[ "$PUSH_TO_HUB" == "True" ]] && echo "--push-to-hub --token ${HF_TOKEN} --repo-id ${REPO_ID}" )
UI Screenshots & Parameters
learning_rate = 2e-4
num_epochs = 4
batch_size = 1
block_size = 1024
trainer = "sft"
warmup_ratio = 0.1
weight_decay = 0.01
gradient_accumulation = 4
mixed_precision = "fp16"
peft = True
quantization = "int4"
lora_r = 16
lora_alpha = 32
lora_dropout = 0.045
Error Logs
❌ ERROR  | 2023-12-21 06:55:38 | autotrain.trainers.common:wrapper:86 - train has failed due to an exception: Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/autotrain/trainers/common.py", line 83, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/autotrain/trainers/clm/__main__.py", line 446, in train
    trainer.train()
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer.py", line 1537, in train
    return inner_training_loop(
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer.py", line 1990, in _inner_training_loop
    self.control = self.callback_handler.on_train_end(args, self.state, self.control)
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer_callback.py", line 373, in on_train_end
    return self.call_event("on_train_end", args, state, control)
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer_callback.py", line 414, in call_event
    result = getattr(callback, event)(
  File "/usr/local/lib/python3.10/dist-packages/autotrain/trainers/clm/callbacks.py", line 36, in on_train_end
    adapters_weights = torch.load(best_model_path)
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 986, in load
    with _open_file_like(f, 'rb') as opened_file:
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 435, in _open_file_like
    return _open_file(name_or_buffer, mode)
  File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 416, in __init__
    super().__init__(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: 'my_autotrain_llm/checkpoint-108/adapter_model.bin'

❌ ERROR  | 2023-12-21 06:55:38 | autotrain.trainers.common:wrapper:87 - [Errno 2] No such file or directory: 'my_autotrain_llm/checkpoint-108/adapter_model.bin'

Additional Information
I had previously executed the same code with identical parameters and setup, and it ran seamlessly. However, I am currently encountering an error.

I have checked other issues for similar problems.

I dont think you have: https://github.com/huggingface/autotrain-advanced/issues/427
Which version are you on?

I have just installed it with !pip install -U autotrain-advanced this command at the start of execution

its probably fetching the old version. please make sure you have the latest version using !autotrain --version command. it should be 0.6.71 or later.

it is working! version problem like you said, thank you!


Ensure null-termination of filenames copied by strncpy

Prior use of strncpy passed the buffer length for n; when the string to copy is
length n or longer, this results in the buffer not containing a null byte. This
is problematic as the buffers are assumed to contain a null byte elsewhere.
Reported here: https://forums.freertos.org/t/freertos-fat-compiler-warnings/14843

Thanks for the feedback. I have updated the PR.
I had previously assumed ffconfigMAX_FILENAME  did not include null byte; I have updated PR accordingly.
STRNCPY does not ensure a trailing zero. STRNCPY just calls strncpy. As noted in the GCC warning we are passing strncpy a length equal to the buffer size.
From the strncpy man page we can see:
The strncpy() function is similar, except that at most n bytes of src are copied.  Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated.

and
If there is no terminating null byte in the first n bytes of src, strncpy() produces an unterminated string in dest.  If buf has length buflen, you can force termination using something like the following:

           if (buflen > 0) {
               strncpy(buf, str, buflen - 1);
               buf[buflen - 1]= '\0';
           }

As such, the current uses of strncpy will end up with no null termination if the copied string is length greater than (ffconfigMAX_FILENAME - 1).
The PR has been updated to just fix uses of strncpy. I have also updated it to use  pcFileName[ sizeof( pcFileName ) - 1 ] = 0; instead of = { 0 } to ensure null bytes.

Updated PR to use the macro in ff_dir.c and to use the length to index instead of sizeof


Notebook archive should support interactive holomaps

Right now, HoloMaps are exported as a single frame. There are several issues with exporting holomaps in archives:

HoloMaps can take a lot more disk space than static images.
They are harder to test if we want to use archive testing in the future.
Saving out separate HTML+JS for our javascript widgets is hard to include in index.html due to the same origin policy.

Nonetheless, we now have static HTML export and it would be nice to be able to use it. Ideally we could have standalone HTML files that display nicely by themselves but that can also be linked into an overall notebook document. Unfortunately, this looks like it might be quite tricky to get right.
Lastly, this might link to the proposal of storing the main holomap data in JSON files....

I don't really understand the proposal here, we can and do support HoloMap exports now, but maybe not in archives? Please close if you think this has been addressed.

I know we can export standalone html files for holomaps now but I would need to check how this applies in the context of archives.


Auto generate provider for faster release of new endpoints

When new endpoints are added to ZITADELs APIs, manual work is needed to implement the changes in the Terraform provider. This adds lag to the Terrafrom provider release.
It could be useful to use tools that automatically generate Terraform resources from gRPC definitions.
Example (never used personally, but could be worth investigating): https://github.com/gravitational/protoc-gen-terraform

When new endpoints are added to ZITADELs APIs, manual work is needed to implement the changes in the Terraform provider. This adds lag to the Terrafrom provider release.
It could be useful to use tools that automatically generate Terraform resources from gRPC definitions. Example (never used personally, but could be worth investigating): https://github.com/gravitational/protoc-gen-terraform

I shortly looked at it as I started the implementation, as I understand it, the generation is just for the schema of the resources, you still have to implement all create, update, delete and read functions. So with this in mind, I opted to do it without generation, but maybe I need to take a closer look.

Default policies and custom texts are currently generated with https://github.com/gravitational/protoc-gen-terraform, had to include https://github.com/hashicorp/terraform-plugin-mux as we used terraform SDK before and the generated code is for terraform framework.
Will close this issue, for now, migrating everything over to terraform protocol version 6 with terraform framework will be done step by step.


Replace brute force and add log

Replace a brute force search with a numpy operation
Add log about candidate and gpu information

It is a little strange here that lcm can be larger than max_acceptable_batch_size. By not adding lcm to base_list when lcm is greater than max_acceptable_batch_size will cause unit tests to fail.

Any update on this?


Terminal output div container should be more accessible for screen readers

CC @isidorn
System Info

Version: 1.46.0-insider (system setup)
Commit: cd41dd1f6065db76c77c6e2f659bb50e6f558dec
Date: 2020-05-29T05:51:32.662Z
Electron: 7.3.0
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

With either NVDA or JAWS loaded, type any commands in terminal (Ctrl+`) input area.
Press Shift+Tab two times from the terminal input to focus in terminal output list view.
The terminal output list is reachable via tab key thanks to tabindex = "0" attribute; however, screen readers (both NVDA and JAWS) do not read anything with arrow keys unless users manually switch on browse mode.
The additional problem can be found with very long terminal outputs that require scroll behavior. Screen reader users have to switch back to forms mode to arrow up/down  to scroll through the output history (while not being read any current line) and again, turn back to browse mode to check the results.

Does this issue occur when all extensions are disabled?: Yes

Suggested Solutions
Currently, the terminal output
 container denoted with class = "xterm-accessibility-tree" has role = "list".
As a blind developer myself, I am requesting the following for accessibility improvements for screen readers.

Please change the value of role attribute from "list" to "document" so that screen reader users can navigate the terminal output via arrow keys using browse mode.
Please adjust the tabindex value of this terminal output container in the way that screen reader users can quickly Shift+Tab from terminal input area. In other words, pressing tab key from terminal output area should go to terminal input area; pressing Shift+Tab key from terminal input goes to terminal output area denoted with role = "document" div.
Ideally, it would be great if the terminal output can be also included in the F6-keycycle.

@jooyoungseo thanks for feedback.

I believe @Tyriar decided to use the role list because the terminal consistes of multiple lines with each being a listitem. We can experiment changing to document but let's also try to get feedback from the community
This makes sense, however it might be controlled by the shell, @Tyriar will know more
It is included in the F6 keycicle. Can you provide more details what is not working here?

If you use role list and listitem, meaning static roles, you need a container that is a role document. Otherwise, screen readers will not read these lists properly. Since they are static text, that is appropriate to do. So the list and list item are appropriate, but the container must be a role document, too.

@MarcoZehe makes sense
@Tyriar we could put the role: document on the terminal xterm div element which is an ancestor of the list role and it should be good.

Hi,
The entry part of the terminal is included in the F6 cycle, but not the output.

@chrisnorman7 aha. Then we would not change the F6 behavior, since the point of F6 is to give a birds view navigation over the workbench components. Once you are close to something you want you should tab into it. Since moving from the entry of the terminal to the output should be easy (if it is not we should fix) I would not change F6 behavior.

In my opinion, the ideal is that we could navigate in the terminal output using the arrows to read by character, line and word.

@jooyoungseo did you know about control + arrow keys to read terminal lines. if so, then I do not quite understand why you propose these changes.

The problem with ctrl+Arrow keys is that this will just dump a line into the synthesizer and be done with it. No review, and more importantly, no braille support. So making this output actually navigable with screen reader reading commands is a very welcome enhancement for both speech and braille users.

The problem with ctrl+Arrow keys is that this will just dump a line into the synthesizer and be done with it. No review, and more importantly, no braille support. So making this output actually navigable with screen reader reading commands is a very welcome enhancement for both speech and braille users.

ok. now i understand. thanks.

Honestly, it could be easier.
When I press shift tab from the terminal's input, I hear "Section", then
when I hit it again I get into the output. Same for tabbing from the output
to the input. Whatever "section" is, it sits in between input and output.
 Then we would not
change the F6 behavior, since the point of F6 is to give a birds view
navigation over the workbench components. Once you are close to something
you want you should tab into it. Since moving from the entry of the
terminal to the output should be easy (if it is not we should fix) I would
not change F6 behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/98918#issuecomment-637446058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBUZ2JCSLVJAICATZAJ4JDRUTHZHANCNFSM4NPJDSKA
.

@isidorn, the idea I would like to propose for either F6 cycle or tabindex adjustment is about a more easier and screen-reader-friendly approach.
Let me give you an example. I am a Python programmer who has to frequently switch between code editor pane and terminal output.
When I execute a code block from code editor into terminal, I have to do the following:

Press 'Ctrl+`' to focus in terminal input.
Pres 'Shift+Tab' key twice to focus in terminal output.

Wouldn't there be a more efficient way to quickly switch between code editor and terminal output?

All good feedback,
Though let's wait for @Tyriar to hear his thoughts.
@jooyoungseo you would basically like a command that gives focus directly to the terminal output

Unless the thing which sits between the input and the output, that NVDA
simply reads as "section" is important, why not remove its tabindex
attribute?
Take care,
Chris Norman
On Tue, 2 Jun 2020 at 16:21, Isidor Nikolic<EMAIL_ADDRESS>wrote:

All good feedback,
Though let's wait for @Tyriar https://github.com/Tyriar to hear his
thoughts.
@jooyoungseo https://github.com/jooyoungseo you would basically like a
command that gives focus directly to the terminal output
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/98918#issuecomment-637611577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBUZ2ORYEP7XR42IY7DMZTRUUKHNANCNFSM4NPJDSKA
.

The problem with ctrl+Arrow keys is that this will just dump a line into the synthesizer and be done with it. No review, and more importantly, no braille support. So making this output actually navigable with screen reader reading commands is a very welcome enhancement for both speech and braille users.

why not remove its tabindex attribute?

The ctrl+arrow 'navigation mode' was built with help from NVDA and the main reason it exists is because the list is and must be virtual. As I understand it, navigation with a screen reader is not possible using a virtual list as we need to update the contents of the DOM during navigation and we don't get events to trigger when a screen reader is being navigated.
The buffer must be virtual for the same reasons as the editor, we cannot create 1000+ lines of dom content, easy with their own set of spans as browsers don't like that and VS Code would lock up whenever you press enter (triggering a layout after a row changes).

you would basically like a command that gives focus directly to the terminal output

Navigation mode is that command; ctrl+up and ctrl+down.

@Tyriar ok, but it still holds that we can add a role 'document' to the parent container.

If that will improve the experience that's easy 👍

Wow, thanks for working so hard on this all. That's great.

Yeah it should improve the experience.
As for the other focus discussions I am not sure what action items we can extract out of those.

We might well need to add buttons to the document to allow the user to scroll the terminal up/down. I don't know that Orca, jaws and NVDA will properly scroll the terminal in such a way that you guys can dynamically update the DOM.

Adding scroll buttons would be possible. However, in my opinion, the "document" role would suffice because it will then be treated as a read-only multi-line text box where you can navigate the terminal output from top all the way to the bottom regardless of its length. Please correct me if I am wrong.

@Tyriar, I hope you don't mind me asking this again. Could we expect to experience this improvement in July 2020 milestone? I am asking this because see the June and July milestone label up there. I am very looking forward to this improvement.

@jooyoungseo fixed 🙂

@Tyriar, after testing the latest commit (15ada625f20086007e2c4aa0d760234360cd648f), I have found that the implemented "document" role has not not made any navigation improvements for both NVDA and JAWS.
@MarcoZehe, would you mind helping us addressing this issue?
I have tested with the following code-insiders:
Version: 1.48.0-insider (system setup)
Commit: 15ada625f20086007e2c4aa0d760234360cd648f
Date: 2020-07-30T14:43:12.691Z
Electron: 9.1.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

The document role is on a div with class xterm-accessibility-tree. Keyboard focus, when shift-tabbing from the terminal input twice, lands on the outer div with classes 'terminal xterm'. The document role must be on something that is either the focused element itself, so the latter div, or something outside that, but not below it in the hierarchy. In essence, the role is on the wrong div.

Thanks very much for your advice @MarcoZehe!
@Tyriar, would you mind adjusting the position of "document" role following @MarcoZehe's advice so that we can get the real improvement?
Appreciatively,

Thanks for trying this out and for letting us know.
@Tyriar let me reopen this so we try to address feedback from @jooyoungseo and @marcozehe

Oh? I actually verified this one and was able to use browse mode to navigate the list items by use ins+space and then shift+i, am I doing something wrong?

You should not need to use Insert+Space first. If done right, tabbing into this area would then turn document mode on automatically, tab out, and it returns to application mode.

@MarcoZehe wouldn't browse mode break terminal input if it's switched to automatically when focusing the terminal?

Not if you put it where tab stops land, as I indicate above. It is just two containers up from where the role is now. The entry field is outside that container. Browse mode would be applied to all descendants of that xtrm thing, but not to the input, which lives outside. So the moment focus leaves this particular area, NVDA will return to application mode.

@MarcoZehe when I change it to be 2 containers above I land on the terminal and it says "document, terminal input edit" (because the textarea is under .terminal.xterm), the input still seems to work fine but i and shift+i input instead of navigating? I still need to enter browse mode with shift+ins manually?

If I tab into the terminal it says "document", and pressing i or shift+i just says "i" without doing anything?

Hm, when I open a terminal, I am in the edit field. I then shift-tab twice (the first stop is for what I don't know). And that is where NVDA should then go into browse mode. So if putting the role on the xterm div doesn't work because it does include the input, maybe move that tabindex="0" down to where the role="document" is instead. Does that work?

the first stop is for what I don't know

This is for this:

, the purpose of that is to move keyboard focus to the hide panel button and skip everything else but there was a bug causing that not to happen. But anyway, that would break what we're trying to go for here where shift+tab allows us to navigate the terminal so I'll remove it. It's also a bit ugly as it depends on both xterm.js internals and panel internals (the reason it broke).

maybe move that tabindex="0" down to where the role="document" is instead

Having both tabindex="0" and role="document" on the terminal xterm element just ends up saying "document", i and shift+i end up just saying "i" so I'm not seeing this automatic switching to browse mode in NVDA. I could add an aria-label there to say something like "Enter browse mode to navigate terminal rows, document"?

That surprises me, I would have thought the moving of the tabindex attribute to the same element that contains role="document" would work. It usually does.

@Tyriar,
In the latest version of VSCode insider, the terminal output aria-live event is not automatically read by JAWS (v2020.2006.12.400).
Version: 1.48.0-insider (system setup)
Commit: 2277c8e2a3e1cc630a6397301ba54a1dccd8a60d
Date: 2020-08-07T11:32:09.993Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

@Tyriar,
It would be still ideal for screen reader users to not manually switch between browse mode and focus mode. I think there should be another factor causing the "document" role to not work, which we might want to further investigate.

I'll move the document to the terminal xterm element I was talking about so you can verify whether it's better, maybe I was doing it wrong.

@Tyriar, aria-live event for the terminal output is working again for JAWS (tested with the latest insider commit: bd08768fd310d34cdd4423a53e5f3ca77340fea5).
To make the "docvument" role work, what if we do the following?:
Currently, the
 has ``"document" role without any tabindex attribute.
On the other hand, tabindex = "0" is set within the outer
.
Please move the tabindex = "0" from the outer to the "xterm-accessibility-tree" container having the "document" role. And, please make sure the outer container not to have any tabindex.

Please move the tabindex = "0" from the outer to the "xterm-accessibility-tree" container having the "document" role. And, please make sure the outer container not to have any tabindex.

@jooyoungseo moving the tabindex will change a bunch of other stuff though like outline styles, focus/blur events, etc. Plus .xterm-accessibility-tree doesn't exist when a11y mode is disabled so it would fork the functionality (probably leading to regressions on one of them).

PR to move the role to the main .terminal.xterm element as discussed, I'll pull this in and it should be available in tomorrow's Insiders build. If people could verify whether this improves the situation that would be great.

Thanks very much for your hard work @Tyriar.
In my experience with the latest commit (d1f267742169584db010716d92addf50d4cd8139), neither JAWS nor NVDA auto-switches between browse and document mode in the terminal input and output.
What do you think @MarcoZehe and @zersiax? Would you mind you all testing the latest commit for this feature?

using orca, when I'm at the terminal and pressing shift + tab, orca just announces that I'm in a document but doesn't switch to browse mode.
Nothing else is read, even if I try to navigate with the arrows.

CC @leonardder and @feerrenrut:
Would either of you mind investigating why browse mode is not auto-activated with NVDA in the terminal output area which has been marked up with "document" role? As discussed in this thread, we want to have NVDA to stay in forms mode for terminal input, and to auto-switch into browse mode for terminal output.

I tested this with latest insider and am seeing some strange things.

The input edit box is part of the document that contains the output. Is this intentional? I think this might be a cause of somewhat strange behavior here and there. I think I'd put the document role on the div with class xterm-accessibility instead.
What is causing the automatic reading of the terminal? I assume a live region somewhere?

Thanks @leonardder!
I also agree with @leonardder's point. @Tyriar, could you please move "document" role to .xterm-accessibility to see if that works?

@Tyriar, would there be any expected timeline for this patch sooner?

CC @isidorn:

Was there any update on this issue?

If this issue can't be addressed in a reasonable timeframe, would it be possible to revert to the past behavior (no document role)?

I am asking this because the document role that has been over-applied to the terminal input area keeps preventing screen readers from getting auto-suggestions. Plus, it is very difficult for screen reader users to navigate bash history using arrow keys within the terminal input area because it is treated as a read-only div....

@jooyoungseo I have discussed this with @Tyriar and we are not 100% sure on what are the best changes we can do here and we felt like we were mostly guessing on the approach, thus there have been no update in the product.
We can invest more time in this next milestone and hopefully improve it.
Is somebody willing to do a call with me to better explain all the issues here. @jooyoungseo @MarcoZehe @jvesouza
@Tyriar is there some easy way for me to tune the terminal and produce different builds for tryout?

@isidorn:
Sure, I can explain the issue in detail on Zoom if that could help. Please let me know how and when you would like me to have a chat with you.

@isidorn the easiest way to test would be to modify the DOM via devtools. The actual change is a bit of a pain to do; xterm pr, merge, update xterm in vscode, fix distro.

@Tyriar thanks!
@jooyoungseo I am in CET timezone. So we could sync tomorrow or on Friday some time that works for you
Please send me an email to inikolic at microsoft dot com

@isidorn's notes from that meeting:

Both the input and output of the terminal have the document role. Ideally only the output should have this role, so the screen reader switches to browse mode and back properly. The input element should not have a role set at all
Very hard to navigate history - when previous element shown, navigating by character left / right reads "blank"
radian package offers auto completion, the auto completions are nicely rendered in our terminal but every time focus changes we read everything, not the focused item in the suggest box

We need to remove the document role from the terminal

@Tyriar and @isidorn--Any update on this issue? Because this is marked as an August milestone.

@jooyoungseo thanks for the ping, created https://github.com/xtermjs/xterm.js/pull/3419

@tyriar Awesome thanks. So this should be in insiders tomorrow, right?
@jooyoungseo would be cool if you could try this out tomorrow and let us know how it goes.

Thank you very much @Tyriar!
@isidorn -- Sure, I will keep you posted tomorrow.

Yep, updating xterm.js in vscode now

@isidorn I have tested the insider version that is better than the one with "document" role applied to terminal input. I still think we need to keep this issue open because...:

The terminal output still needs "document" role (terminal input must not have that role though).
Auto-suggestion is not read properly in terminal input, such as radian.

Thanks for trying this out. Let's reopen due to 1. @Tyriar can we add a document role for the output?
As for 2. @jooyoungseo can you please open a new issue? That one does not seem related to this one? Thanks!

fixed with the xterm update

@meganrogge awesome, thanks!
@jooyoungseo would be great if you can try it out from tomorrow and let us know how it is now. Thanks!

This update doesn't seem to be available now. I tested the following version:
Version: 1.61.0-insider (system setup)
Commit: 8d30d4d922dda917d22f05a81f2ab4fad7349779
Date: 2021-09-24T09:00:59.405Z
Electron: 13.4.0
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

@meganrogge should that version contain the fix?

@isidorn and @meganrogge -- I have a better idea. How about using role = "textbox" and readonly = "true" instead of role = "document"?
I am suggesting this because Focus on Output View(Ctrl+Shift+U) uses this technique, which offers screen readers very satisfactory accessibility for both NVDA and JAWS. For example, once focused in Output View, Ctrl+Home goes to the very beginning of the output log as Ctrl+End goes to the very end. I can navigate the output view using general keyboard arrow-key navigation up/down-arrows for line navigation; left/right-arrow keys for character navigation.
The following includes my two suggestions:

For screen readers, semantically mark up the Terminal Output area as a readonly textbox with role = "textbox" and readonly = "true".

Assign a keyboard shortcut key to Focus Terminal Output. Currently, neither `` Focus Terminal Tabs View nor Toggle Terminal put user focus in the terminal output area; the default landing point is terminal input so screen reader users have to manually press Shift+Tab key to find the terminal output area, which is inconvenient.

I believe these changes improve terminal accessibility in a much better way.

@jooyoungseo this is great feedback, thanks a lot.
However for benefits of using role="textbox" + readonly over document role let's continue here https://github.com/microsoft/vscode/issues/133773#issuecomment-927854480
Ctrl navigation is not dependent on the role, this just works because the Output view uses the Editor underneath. So even if we changed the role for the terminal there would be no improvement regarding this.
As for 2) this is a good suggestion, can you please create a new issue and ping me @isidorn on it. Thanks a lot 👏
As for the document role are the changes there for you in the latest insiders. Is there improvement compared to VS Code stable?

@isidorn -- role = "document" is not available in the latest insider build because I think the patched xterm.js has not yet been merged into this branch. I would love to test the patch asap. Yes, I agree that we should test the "document" role first over "textbox".
Version: 1.61.0-insider (system setup)
Commit: 5991e3c4b97eca5568069bf3e0910ab693ad3549
Date: 2021-09-27T05:16:11.989Z
Electron: 13.4.0
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

It'll be easier to handle links with role=document, and caret navigation
would need to be provided by the application for role=textbox. However, the
navigation may be more intuitive for some people with role=textbox, and the
application may get better control over whats on each line.
On Sat, Sep 25, 2021 at 10:56 AM JooYoung Seo @.***>
wrote:

@isidorn https://github.com/isidorn and @meganrogge
https://github.com/meganrogge -- I have a better idea. How about using role
= "textbox" and readonly = "true" instead of role = "document"?
I am suggesting this because Focus on Output View(Ctrl+Shift+U) uses this
technique, which offers screen readers very satisfactory accessibility for
both NVDA and JAWS. For example, once focused in Output View, Ctrl+Home
goes to the very beginning of the output log as Ctrl+End goes to the very
end. I can navigate the output view using general keyboard arrow-key
navigation up/down-arrows for line navigation; left/right-arrow keys for
character navigation.
The following includes my two suggestions:

For screen readers, semantically mark up the Terminal Output area as a
readonly textbox with role = "textbox" and readonly = "true".
2.
Assign a keyboard shortcut key to Focus Terminal Output. Currently,
neither `` Focus Terminal Tabs View nor Toggle Terminal put user
focus in the terminal output area; the default landing point is terminal
input so screen reader users have to manually press Shift+Tab key to find
the terminal output area, which is inconvenient.
I believe these changes improve terminal accessibility in a much better
way.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/98918#issuecomment-927151192,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABI2FPLSRKMXTUJBEKPWERLUDX5LTANCNFSM4NPJDSKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Derek Riemer:
Improving the world, one byte at a time. ⠊⠍⠏⠗⠕⠧⠬ ⠮ ⠸⠺⠂ ⠐⠕ ⠃⠽⠞⠑ ⠁⠞ ⠁ ⠐⠞⠲
Software engineer, Drive web

@isidorn -- Ideally, I would love to test both "document" and "textbox" role to see if which one would be better. We can even get other users' feedback. Terminal output is very critical area for screen reader users and tis improvement would be far reaching. Currently, Focus on Output View(Ctrl+Shift+U) provides the most accessible caret navigation for both JAWS and NVDA. That's why I suggested that as a role model.

Reopening this and assigning to October since it is not actually fixed.
@jooyoungseo thanks a ton for the PR that fixes this 👏

CC @isidorn and @Tyriar
Once I have tested "document" role and tabindex = 0 attached to "xterm-accessibility" class (i.e., terminal output area) with NVDA and JAWS, I don't see any significant improvement. Rather, I have been experiencing several unanticipated side effects. If possible, I would like to suggest to remove "document" role and tabindex = 0 to go back to the previous behavior until we find any other great solutions.
First, Ctrl+Down-arrow and Ctrl+up-arrow no longer work reliably in terminal after this "document" role patch.
Second, JAWS does not read dynamic content changes (i.e., aria-live) after this patch as mentioned in #142983.
Version: 1.65.0-insider (system setup)
Commit: bb221a61d29deabd99ee9431736d04f2175cb596
Date: 2022-02-11T05:19:13.554Z
Electron: 16.0.8
Chromium: 96.0.4664.110
Node.js: 16.9.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044

Okay we will revert that change

I think that this is addressed by https://github.com/microsoft/vscode/issues/169853, pls lmk if you disagree

Closing this and creating a new one which describes how we plan to partition the buffer using shell integration


Performance of master branch dropped by 20%?

Just benchmarked the master branch and found that the read performance is 20% slower than the 1.2 release branch. After reviewing recent changes, it seems this PR brings the regression - it increases IO size to 1MiB:

I don't understand why increasing IO size gets a lower read performance. The only related metric is goroutine count - less goroutines means less concurrency? but those two IO sizes are far less than BlockSize, I suppose it has nothing to do with readahead?

NB: Maybe also introduce a CI test that evaluates and detects performance regression too on each commit?

fixed https://github.com/juicedata/juicefs/pull/5087

I suppose it's not a fix but a workaround. We still don't know why the regression happens, but just leave the burden to users with another magic flag.

The main branch changed the default behavior which cause the performance degradation, we have revert the change and introduce a flag for new behavior.


Added enable/disable functionality

Added wrapper option.
Added data-highlighted=true or false if a color or none is selected: An afterHighlight hook could be used to remove unused highlights.

Nice work!  This looks to be exactly what I needed :)

This solved the issue with the "destroy" method not working. Thanks!

Just as a heads up, I've forked this repo, and merged this PR in: https://github.com/zao-web/texthighlighter

@jrobles-boom this is what I needed. It works perfectly. Thank you very much.


[Feature] Improve user experience in datasource page

What is the purpose of the pull request
For #1470 .
To improve user experience in datasource page, add default port for each type database.

When create or edit datasource, there is a default vaule for port. If user changes type, the default value changes.

Use local variables in browser memory, to cache user previous input port for each type. For example :
time-a:  MySQL default  port is 3306 , user change 3306 to 4000.
time-b:  User change type from MySQL to ClickHouse , the port change  from 4000 to 8123.
time-c:  User change type from ClickHouse back to MySQL，the port change from 8123 to 4000，use previous input cache to fillback.

In edit datasource page, when the page first loads, use the query value fillback instead of default value.

Brief change log

Edit createDataSource.vue

Verify this pull request

Manually verified the change by testing locally.

Codecov Report

Merging #1471 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev   #1471   +/-   ##
=====================================
  Coverage   0.22%   0.22%
=====================================
  Files        271     271
  Lines      13591   13591
  Branches    2158    2158
=====================================
  Hits          31      31
  Misses     13550   13550
  Partials      10      10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec5f2e...eccd6c7. Read the comment docs.


Change learner action to be a welcome message on new pull requests

Let's update the action the learner creates to welcome new contributors when they make pull requests with an issue comment.


CPU [Linux]: Added CPU name detection for more architectures

Description
This expands CPU name detection for Linux as per this documentation to many architectures.
This should also fix #526.

LGTM :+1:


Workflow CD fails to deploy plugin modules with 403

Reproduction steps
The automated CD release of a new plugin jenkinsci/mina-sshd-api-plugin fails to deploy the module plugins in nexus. Note that the plugin is a multi module plugin (like the aws java sdk plugin for example)
Expected Results
The CD release should deploy the following:

https://repo.jenkins-ci.org/releases/io/jenkins/plugins/mina-sshd-api/mina-sshd-api-parent/ (parent pom)
https://repo.jenkins-ci.org/releases/io/jenkins/plugins/mina-sshd-api/mina-sshd-common-api/ (hpi)
https://repo.jenkins-ci.org/releases/io/jenkins/plugins/mina-sshd-api/mina-sshd-core-api/ (hpi)
https://repo.jenkins-ci.org/releases/io/jenkins/plugins/mina-sshd-api/mina-sshd-sftp-api/ (hpi)
https://repo.jenkins-ci.org/releases/io/jenkins/plugins/mina-sshd-api/mina-sshd-ssh-api/ (hpi)

Actual Results
The CD release fails to deploy the modules:
[INFO] --- maven-deploy-plugin:2.8.2:deploy(default-deploy) @ mina-sshd-common-api ---
[INFO] Using alternate deployment repository maven.jenkins-ci.org::default::https://repo.jenkins-ci.org/releases/
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Mina SSHD API :: Parent 2.8.0-14.va_eb_e1a_e0145a_:
[INFO]
[INFO] Mina SSHD API :: Parent ............................ SUCCESS [01:08 min]
[INFO] Mina SSHD API :: Common ............................ FAILURE [  9.282 s]
[INFO] Mina SSHD API :: Core .............................. SKIPPED
[INFO] Mina SSHD API :: SCP ............................... SKIPPED
[INFO] Mina SSHD API :: SFTP .............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:24 min
[INFO] Finished at: 2022-06-14T23:02:46Z
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "consume-incrementals" could not be activated because it does not exist.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy(default-deploy) on project mina-sshd-common-api: Failed to deploy artifacts: Could not transfer artifact io.jenkins.plugins.mina-sshd-api:mina-sshd-common-api:hpi:2.8.0-14.va_eb_e1a_e0145a_ from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): authorization failed for https://repo.jenkins-ci.org/releases/io/jenkins/plugins/mina-sshd-api/mina-sshd-common-api/2.8.0-14.va_eb_e1a_e0145a_/mina-sshd-common-api-2.8.0-14.va_eb_e1a_e0145a_.hpi, status: 403 Forbidden -> [Help 1]

Anything else?
The plugin was hosted recently and haven't been released yet:

https://github.com/jenkins-infra/repository-permissions-updater/issues/2582
https://github.com/jenkins-infra/repository-permissions-updater/pull/2583

There is some discussion about the repository paths in:

https://github.com/jenkins-infra/repository-permissions-updater/pull/2584#pullrequestreview-1001146719

cc @jglick

The wildcard in the permissions file doesn't actually work, because the file names are (dis)allowed based on the name. See this repo's readme.
It works for https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-aws-java-sdk.yml because the name is a true prefix of all file names. It doesn't work here because name includes -api.
Just don't use this trick. Nobody understands how this actually works, including the people merging PRs, and it creates tons of problems.

I see. Thanks for the explanation, will propose a fix then.


zsh mac jd function in .zshrc

Traceback (most recent call last):
File "/usr/local/bin/jumpdir", line 5, in
main()
File "/usr/local/lib/python2.7/site-packages/jumpdir/main.py", line 57, in main
bm = Bookmarks(BOOKMARKS)
File "/usr/local/lib/python2.7/site-packages/jumpdir/bookmarks.py", line 24, in init
self.load_bookmarks()
File "/usr/local/lib/python2.7/site-packages/jumpdir/bookmarks.py", line 76, in load_bookmarks
self.bm_dict = json.loads(jfile.read())
File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/init.py", line 338, in loads
return _default_decoder.decode(s)
File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 366, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 384, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
jd:3: parse error: condition expected: !=
Jumpdir could not find a matching directory :(

Same happens for me. It seems Jumpdir creates some empty cache files (at least for OSX El Capitan) and later fails to decode them as JSON. To solve this we could simply write an empty dict when we create the files (or avoid creating them at all?).
Even if I fix that manually, the "initial search" which I assume builds a dictionary of all directories in HOME_DIR, takes a very very long time. Maybe it would be better to build the cache incrementally when a certain depth (1-2 dirs) is reached?

Thanks for the PR request @asfaltboy, I've merged your changes to master.
Jumpdir started off as a personal project, so the edges are a bit rough. I am open to the idea of incremental cache generation to reduce the overhead of the "initial search".
At the moment on the first run of JD the 'map_directories' method is called, which creates the dictionary representing HOME_DIR through a call to the 'dict_builder' function, and then saves the dictionary to the cache file in JSON format.
Furthermore if jumpdir cannot find a matching directory when searching, it will call 'map_directories' to rebuild the dictionary + cache in case the directory the user is searching for was created after cache generation.

Honestly, I just tried Jumpdir today for the first time. I was actually looking for wting/autojump but found your project because I could not remember the name 😊


plese delete, I made a big mistake

Hello Steve,
sorry I mixed, sources from https://github.com/enqack/docker-esp8266-micropython and https://github.com/BradenM/docker-esp8266-micropython. Sorry, I was waching TV beside and Mr. Pmurt with his fellows did a terrible thing. I didn't pay enough attention. Sorry.
hcet14

I hope this issue will be deleted. Sorry again.

I hope this issue will be deleted. Sorry again.


Insert ignores background colour.

When we insert a character (charcode 5) then the previously set background color is ignored - a space with a black background is always inserted. When editing text with a background other than black, this does not look good.

Its the same with backspace. It inserts a black square on the right.


Fixed a small typo in the italian translation

In "document_properties_mb", {{size_mb}} was instead {{size_kb}}.

Looks good, but this also needs to be reported upstream to prevent accidentally reverting this with the next L10n update.
@yurydelendik (or someone else): Could you file an upstream issue for the L10n team before we merge this?

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1151093.

@Snuffleupagus Thank you!
/botio-linux preview

Thank you! The issue has already been fixed upstream too, so no worries there.

:D


Don't ship unneeded files for composer installs

This PR adds .gitattributes, which can be used to control which files are being shipped with distribution installs via Composer.
This will prevent Composer from downloading files which are not needed when used as a dependencies: CI files and tests.

Cheers @Seldaek!


refactor: layer0 to edgio

❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)

@pi0
Regarding https://github.com/unjs/nitro/pull/676#discussion_r1060544277,
So what we need to enable is deploying hassle-freely to Edgio even if I just follow the first guide I see on nitro: https://github.com/unjs/nitro/pull/676#issuecomment-1320844155

Usage of @edgio/nitropack will ensure that we can update and maintain the changes for the user if we were to change our API for serving routes. Make sense?

What I visualize with this https://nitro.unjs.io/guide/introduction/getting-started with Edgio,
# The usual flow
mkdir nitro-app
cd nitro-app
mkdir routes
cd routes
touch index.ts
cat >> index.ts
export default defineEventHandler(() => 'nitro is amazing!')
cd ../
npx nitropack dev
# The app is ready with Nitro

# To deploy this to Edgio
npm i -g @edgio/cli
edgio init --connector=@edgio/nitropack
edgio deploy

What I'm thinking would be another hassle free integration is:
mkdir nitro-app
cd nitro-app
mkdir routes
cd routes
touch index.ts
cat >> index.ts
export default defineEventHandler(() => 'nitro is amazing!')
cd ../
npx nitropack dev
# The app is ready with Nitro

# To deploy this to Edgio
NITRO_PRESET=edgio npx nitropack build
npm i -g @edgio/cli
edgio deploy

But Edgio's CLI will require a package.json, routes.js, edgio.config.js to deploy which might exist with projects, but not by default for the getting started guide.

Hi dear @rishi-raj-jain. Thanks for rework and adding routes generator 💯
I think the second usage makes it more consistent with other providers usage. Can it be edgio deploy .output maybe? We can (auto)generate any necessary file such as routes.js and edgio.config.js inside output directory, ready for edgio deployment without user involvement.
Thinking to simplify production deployment into:
npx nitropack build --preset edgio
npx @edgio/cli deploy .output

What do you think?

@pi0
I understand it now, right makes sense, thanks for the guidance, I'm updating it...
Can you help me with how I can test my changes with a local nitro version, if possible?

Why I'd love to test the preset locally is I'm not aware of what values would .publicDir will have and what's the directory gonna look like once compiled:

Hi dear @rishi-raj-jain. Thanks for rework PR 💯
Hey there, hope you're well. It's pleasure, learning while contributing 💚

I think the second usage makes it more consistent with other providers usage. Can it be edgio deploy .output maybe? We can (auto)generate any necessary file such as routes.js and edgio.config.js inside output directory, ready for edgio deployment without user involvement.

Totally, now I see it. Re-worked it now.

Now my aim here is to ensure that routes.js, edgio.config.js, edgio/prod.js and package.json get's created inside the output folder of Nitro (because that's what presets are aiming to do, right?). Is that happening per the current PR? It'd be great if I could do something to simulate this locally.

I'd want the user to run the npx @edgio/cli deploy inside the output folder inside of the directory where these files are created (i.e. the output dir), how can we make that happen?

From vercel.ts what I learn is that I can modify the output paths if the present is being used.
  output: {
    dir: "{{ rootDir }}/.vercel/output",
    serverDir: "{{ output.dir }}/functions/__nitro.func",
    publicDir: "{{ output.dir }}/static",
  },

I think then all of it can be done in the .edgio folder. Two things I'd want here is to add .edgio to .gitignore create edgio.config.js inside the rootDir and then users can deploy with npx @edgio/cli deploy directly.

I don't mind changing (default) output to .edgio if you prefer but only as you mentioned, it would require manually ignoring the new directory. (Vercel has to use a special directory because their CI/CD detects builds from this dir).
I think generated edgio.config.js can be inside .edgio/edgio.config.js or .output/edgio.config.js by making edgio CLI smartly detecting this directory (both netlify and vercel support it for local development too). We could support top level edgio.config file later as user-supplied configuration and merge it with auto generated configurations from nitropack. Alternatively, CLI could support a positional argument in last that specifies root dir that it operates on.

I don't mind changing (default) output to .edgio if you prefer but only as you mentioned, it would require manually ignoring the new directory. (Vercel has to use a special directory because their CI/CD detects builds from this dir).

Great, I've done the addition to .gitignore via appendFile so that it doesn't break anything for the user.

I think generated edgio.config.js can be inside .edgio/edgio.config.js or .output/edgio.config.js by making edgio CLI smartly detecting this directory (both netlify and vercel support it for local development too). We could support top level edgio.config file later as user-supplied configuration and merge it with auto generated configurations from nitropack. Alternatively, CLI could support a positional argument in last that specifies root dir that it operates on edgio deploy

That's a great feedback for Edgio CLI. I've already asked the team if this is supported else I'd get this supported soon.

@pi0 Re-requested your review if you could confirm that this runs fine with an example? Would love to know if there's a possibility that I can make some local version of nitro and take it for a spin.

Also, @manniL how can I add a redirect in docs so that https://nitro.unjs.io/deploy/providers/layer0 goes to https://nitro.unjs.io/deploy/providers/edgio?

@rishi-raj-jain My first guess would be using routeRules via https://github.com/unjs/nitro/blob/main/docs/nuxt.config.ts

@manniL Thanks! Learning that this was also introduced with Nitro!

Seems like the redirect via routeRules is not working.

Yup, docus based redirect seems to work fine. That sorts the documentation. @pi0 anything left?

I have left some new comments @rishi-raj-jain sorry it is taking long. feel free to message me in slack or discord to have a PP and quickly going over any questions you have.

I have left some new comments @rishi-raj-jain sorry it is taking long. feel free to message me in slack or discord to have a PP and quickly going over any questions you have.

Hey, no worries, we're all trying to make great software.
I tried reaching to you on discord.
Here's the same message:
Thank you so much for continuously providing feedback on my PR. It's all process of learning for me as well.

So I made relevant changes per your comments on https://github.com/unjs/nitro/pull/822, please have a look when you get time.

Overall what remains is: Deciding a folder structure to use which will be ideal for users.

So the thing is that Edgio CLI requires the following in the directory where the command is ran:
- Two packages installed: @edgio/core and @edgio/cli
- package.json with the name field
- edgio.config.js

Rest of the thing I can handle inside edgio.config.js.

Atlast, in the directory where the command is ran, .edgio folder is created by Edgio CLI which is then used by it.

So what I'm thinking is so that all looks convenient to the users:

- Output a folder not named .edgio (to avoid conflict with the pointer I mentioned above) say something like .edgio_output and then this folder contains:
 -- package.json: with just a name field that is either generated randomly or taken from rootDir/package.json
 -- install these two packages in this folder
 -- edgio.config.js: with the files as required
 -- whatever's required for edgio connector

- Then user can deploy with the following flow:
npm i -g @edgio/cli
PRESET=edgio npx nitropack build
cd .edgio_output && edgio deploy

Makes sense? What do you think?
Also, have another PR: https://github.com/nuxt/image/pull/709 that I think you can easily merge.

Thanks for all helping on this ❤ I have merged it via https://github.com/unjs/nitro/pull/858 with a couple of changes. Please let me know if you like any changes.

Thank you all! ❤


dev-exp branch fail to compile under vs2019

I get these erros:
2>init.obj : error LNK2019: unresolved external symbol __imp_mi_allocator_init referenced in function mi_process_load
2>init.obj : error LNK2019: unresolved external symbol __imp_mi_allocator_done referenced in function mi_process_done

Ah yes, the VS2019 solution in lagging but I'll update it soon! -- I even see a PR is ready for this. (You can always open the VS2017 one in VS2019 too as a workaround).


Update netty-all, netty-codec-http to 4.1.49.Final

Updates

io.netty:netty-all
io.netty:netty-codec-http

from 4.1.48.Final to 4.1.49.Final.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.netty" } ]

labels: library-update

Coverage remained the same at 0.0% when pulling 01050b2a96b1980ddc7b270b539dd0be600a98cb on scala-steward:update/netty-all-4.1.49.Final into e0e69cbdae0efbf8bd0e57c9ebf1c7e88a399cdd on andyglow:develop.


Visual grouping of nodes

Requested functionality.
I've been looking at the possibility of visually grouping nodes using a simple different background with some title. A simple rectangle that encompasses several nodes.
What would be its usefulness? Let's imagine an IoT sensor and actuator representation system in a home or industry. Suppose we need to visually group all the sensors in the same room, in the kitchen, bathroom, etc.
It would be about having the possibility of visual grouping of nodes.
The idea would be similar to the graphic in the following link: https://docs.cruncherlabs.com/cruncher
Special thanks to the library developers. Nice job.

https://github.com/wbkd/react-flow/issues/658

Thanks a lot!

@RafaelCruzMarquez Just use https://github.com/flowhub/the-graph

I will collect new feature ideas in the "Discussions/New Features" section. This issue will be closed in favour of #1022


Update 2024 CF Workshop page with link to SMHI workshop page.

I added the link to the SMHI page and added Daniel and Kevin to the organizing committee list. I think we might want to update some of the text to better align with the SMHI page. (Ping - @larsbarring @davidhassell @japamment @efisher008 @erget @kevin-obrien)

Thanks Ethan -- looks good to me.


Fix CI build: update test matrix & use yarn for CI builds

This is necessary because npm 6 requires Node.js 6.

@cwelch5 OK if I merge this in?


Bug: detect-gpu crashes on SSR/SSG

Problem
detect-gpu will crash on SSR/SSG.
ReferenceError: window is not defined
    at /hoge/hoge/node_modules/detect-gpu/dist/detect-gpu.umd.js:1:2591
    at /hoge/hoge/node_modules/detect-gpu/dist/detect-gpu.umd.js:1:131

I know detect-gpu depends on window object, but getGPUTier returns early without window object,  so I think this ReferenceError is unexpected behavior.
Early Return
https://github.com/TimvanScherpenzeel/detect-gpu/blob/23b80f1d0c02417804c4913ef0702524a56469b7/src/index.ts#L69-L75
https://github.com/TimvanScherpenzeel/detect-gpu/blob/23b80f1d0c02417804c4913ef0702524a56469b7/src/internal/deviceInfo.ts#L2
I think this line is the cause of this ReferenceError.
Reproduce
node

and
const { getGPUTier } = require("detect-gpu");

Notes
Can I fix this issue?

Hi @Shinyaigeek, could you have a look if this MR fixes your issue?
https://github.com/TimvanScherpenzeel/detect-gpu/pull/51

Hi! #51 fixes my issue, Thanks 🙏

@Shinyaigeek thanks for confirming, I had little time lately to look at that MR in detail - hope to get to it soon!

Had some time over lunch - version 3.0.0 has been published which includes the bug fix!

Thanks!! version 3.0.0 perfectly works!!


Unable to install robotjs in Docker image Centos/Ubuntu/Linux

Trying to do npm install in Linux image inside Docker in a mac. Unable to install. Getting errors in most combinations.
Tried various versions of Linux, Nodejs < 12 and > 12 versions.
Step 9/27 : RUN node --version
 ---> Running in ...
v11.15.0
Removing intermediate container ...
Step 10/27 : RUN npm -v
 ---> Running in..
6.7.0

Should install
Does not install and fails with this error
Reproduce - copy package.json from mac to linux in Docker.
Npm install
><EMAIL_ADDRESS>install xxx.....nodemodulesfolder/robotjs
> prebuild-install || node-gyp rebuild

prebuild-install WARN install self signed certificate in certificate chain
make: Entering directory `xxx.....nodemodulesfolder/robotjs/build'
  CXX(target) Release/obj.target/robotjs/src/robotjs.o
cc1plus: warning: command line option '-Wbad-function-cast' is valid for C/ObjC but not for C++ [enabled by default]
In file included from ../../nan/nan_new.h:189:0,
                 from ../../nan/nan.h:290,
                 from ../src/robotjs.cc:2:
../../nan/nan_implementation_12_inl.h: In function 'void InitAll(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)':
../../nan/nan_implementation_12_inl.h:119:1: warning: inlining failed in call to 'static Nan::imp::FactoryBase<v8::FunctionTemplate>::return_t Nan::imp::Factory<v8::FunctionTemplate>::_ZN3Nan3imp7FactoryIN2v816FunctionTemplateEE3NewEPFvRKNS_20FunctionCallbackInfoINS2_5ValueEEEENS2_5LocalIS6_EENSC_INS2_9SignatureEEE.constprop.30(Nan::FunctionCallback, v8::Local<v8::Value>, v8::Local<v8::Signature>)': --param large-function-growth limit reached [-Winline]
 Factory<v8::FunctionTemplate>::New( FunctionCallback callback
 ^
In file included from ../../nan/nan.h:290:0,
                 from ../src/robotjs.cc:2:
../../nan/nan_new.h:239:47: warning: called from here [-Winline]
     return imp::Factory<T>::New(callback, data);
                                               ^
In file included from ../../nan/nan_new.h:189:0,
                 from ../../nan/nan.h:290,
                 from ../src/robotjs.cc:2:
../../nan/nan_implementation_12_inl.h:119:1: warning: inlining failed in call to 'static Nan::imp::FactoryBase<v8::FunctionTemplate>::return_t Nan::imp::Factory<v8::FunctionTemplate>::_ZN3Nan3imp7FactoryIN2v816FunctionTemplateEE3NewEPFvRKNS_20FunctionCallbackInfoINS2_5ValueEEEENS2_5LocalIS6_EENSC_INS2_9SignatureEEE.constprop.30(Nan::FunctionCallback, v8::Local<v8::Value>, v8::Local<v8::Signature>)': --param large-function-growth limit reached [-Winline]
 Factory<v8::FunctionTemplate>::New( FunctionCallback callback
 ^
In file included from ../../nan/nan.h:290:0,
                 from ../src/robotjs.cc:2:
../../nan/nan_new.h:239:47: warning: called from here [-Winline]
     return imp::Factory<T>::New(callback, data);
                                               ^
In file included from ../../nan/nan_new.h:189:0,
                 from ../../nan/nan.h:290,
                 from ../src/robotjs.cc:2:
../../nan/nan_implementation_12_inl.h:119:1: warning: inlining failed in call to 'static Nan::imp::FactoryBase<v8::FunctionTemplate>::return_t Nan::imp::Factory<v8::FunctionTemplate>::_ZN3Nan3imp7FactoryIN2v816FunctionTemplateEE3NewEPFvRKNS_20FunctionCallbackInfoINS2_5ValueEEEENS2_5LocalIS6_EENSC_INS2_9SignatureEEE.constprop.30(Nan::FunctionCallback, v8::Local<v8::Value>, v8::Local<v8::Signature>)': --param large-function-growth limit reached [-Winline]
 Factory<v8::FunctionTemplate>::New( FunctionCallback callback
 ^
In file included from ../../nan/nan.h:290:0,
                 from ../src/robotjs.cc:2:
../../nan/nan_new.h:239:47: warning: called from here [-Winline]
     return imp::Factory<T>::New(callback, data);
                                               ^
../src/robotjs.cc: In function 'Nan::NAN_METHOD_RETURN_TYPE keyToggle(Nan::NAN_METHOD_ARGS_TYPE)':
../src/robotjs.cc:592:34: warning: 'down' may be used uninitialized in this function [-Wmaybe-uninitialized]
    toggleKeyCode(key, down, flags);
                                  ^
  CC(target) Release/obj.target/robotjs/src/deadbeef_rand.o
  CC(target) Release/obj.target/robotjs/src/mouse.o
  CC(target) Release/obj.target/robotjs/src/keypress.o
../src/keypress.c: In function 'typeString':
../src/keypress.c:259:41: warning: 'n' may be used uninitialized in this function [-Wmaybe-uninitialized]
  #define toggleUniKey(c, down) toggleKey(c, down, MOD_NONE)
                                         ^
../src/keypress.c:274:16: note: 'n' was declared here
  unsigned long n;
                ^
  CC(target) Release/obj.target/robotjs/src/keycode.o
  CC(target) Release/obj.target/robotjs/src/screen.o
  CC(target) Release/obj.target/robotjs/src/screengrab.o
  CC(target) Release/obj.target/robotjs/src/snprintf.o
../src/snprintf.c: In function 'portable_vsnprintf':
../src/snprintf.c:557:33: warning: signed and unsigned type in conditional expression [-Wsign-compare]
       size_t n = !q ? strlen(p) : (q-p);
                                 ^
../src/snprintf.c:704:40: warning: signed and unsigned type in conditional expression [-Wsign-compare]
             str_arg_l = !q ? precision : (q-str_arg);
                                        ^
../src/snprintf.c:943:62: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             fast_memset(str+str_l, (zero_padding?'0':' '), (n>avail?avail:n));
                                                              ^
../src/snprintf.c:372:35: note: in definition of macro 'fast_memset'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:943:74: warning: signed and unsigned type in conditional expression [-Wsign-compare]
             fast_memset(str+str_l, (zero_padding?'0':' '), (n>avail?avail:n));
                                                                          ^
../src/snprintf.c:372:35: note: in definition of macro 'fast_memset'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:960:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             fast_memcpy(str+str_l, str_arg, (n>avail?avail:n));
                                               ^
../src/snprintf.c:365:35: note: in definition of macro 'fast_memcpy'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:960:59: warning: signed and unsigned type in conditional expression [-Wsign-compare]
             fast_memcpy(str+str_l, str_arg, (n>avail?avail:n));
                                                           ^
../src/snprintf.c:365:35: note: in definition of macro 'fast_memcpy'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:969:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             fast_memset(str+str_l, '0', (n>avail?avail:n));
                                           ^
../src/snprintf.c:372:35: note: in definition of macro 'fast_memset'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:969:55: warning: signed and unsigned type in conditional expression [-Wsign-compare]
             fast_memset(str+str_l, '0', (n>avail?avail:n));
                                                       ^
../src/snprintf.c:372:35: note: in definition of macro 'fast_memset'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:981:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                         (n>avail?avail:n));
                           ^
../src/snprintf.c:365:35: note: in definition of macro 'fast_memcpy'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:981:39: warning: signed and unsigned type in conditional expression [-Wsign-compare]
                         (n>avail?avail:n));
                                       ^
../src/snprintf.c:365:35: note: in definition of macro 'fast_memcpy'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:992:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             fast_memset(str+str_l, ' ', (n>avail?avail:n));
                                           ^
../src/snprintf.c:372:35: note: in definition of macro 'fast_memset'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:992:55: warning: signed and unsigned type in conditional expression [-Wsign-compare]
             fast_memset(str+str_l, ' ', (n>avail?avail:n));
                                                       ^
../src/snprintf.c:372:35: note: in definition of macro 'fast_memset'
   { register size_t nn = (size_t)(n); \
                                   ^
../src/snprintf.c:564:19: warning: variable 'starting_p' set but not used [-Wunused-but-set-variable]
       const char *starting_p;
                   ^
../src/snprintf.c:369:48: warning: 'str_arg' may be used uninitialized in this function [-Wmaybe-uninitialized]
       for (ss=(s), dd=(d); nn>0; nn--) *dd++ = *ss++; } }
                                                ^
../src/snprintf.c:573:19: note: 'str_arg' was declared here
       const char *str_arg;      /* string address in case of string argument */
                   ^
  CC(target) Release/obj.target/robotjs/src/MMBitmap.o
  CC(target) Release/obj.target/robotjs/src/xdisplay.o
../src/xdisplay.c: In function 'setXDisplay':
../src/xdisplay.c:53:2: warning: implicit declaration of function 'strdup' [-Wimplicit-function-declaration]
  displayName = strdup(name);
  ^
../src/xdisplay.c:53:16: warning: incompatible implicit declaration of built-in function 'strdup' [enabled by default]
  displayName = strdup(name);
                ^
  SOLINK_MODULE(target) Release/obj.target/robotjs.node
  COPY Release/robotjs.node
make: Leaving directory `xxx.....nodemodulesfolder/robotjs/build'

><EMAIL_ADDRESS>postinstall xxx.....nodemodulesfolder/core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

><EMAIL_ADDRESS>postinstall xxx.....nodemodulesfolder/@angular/cli
> node ./bin/postinstall/script.js

><EMAIL_ADDRESS>postinstall xxx.....nodemodulesfolder/husky
> opencollective-postinstall || exit 0

Your Environment

RobotJS version: multiple .. 0.5/6 etc
Node.js version: 12/11 etc
npm version:
Operating System: mac/docker-inside linux

Hello @deepziem ,
I build my electron app with robotjs inside a docker file and its working. Here my example dockerfile:
FROM nikolaik/python-nodejs:python3.7-nodejs12-stretch
RUN apt update -y && apt install -y libxtst-dev libpng++-dev make gcc
RUN mkdir test
WORKDIR /root/test
RUN npm init --yes
RUN npm install robotjs

actually has the same error ..

RUN apt-get install libxtst-dev libpng++-dev make gcc --assume-yes

Hope you try this


RT Chat strange behavior (extra dummy word)

Once you write the symbol "&" and edit, it will be filled with strange word "&amp"

Fixed in newest release


Limits of each implementation

Hello,
will the first code listed and plugging into the awl’s aid port collect the data that the furnace sends to symphony every 10 seconds? I am looking to access the data the dealers receive on their portal, but I want to record the historical data. Will this work or do I need to create the connection between the abc and awl? Also, is the Ethernet cable that comes with the awl use the standard t568b? Thank you for this awesome code.

I'm not sure what you're referring to with "first code listed", so I'll try to explain more.
The general way to use this software is to have the aurora_mqtt_bridge constantly running as a system and publishing messages to MQTT. From there, you can have a home automation system (like Home Assistant or OpenHAB) consume the MQTT messages and allow you to see state, control things, and implicitly record history. I'm pretty sure there's also plugins for Telegraf/InfluxDB to directly consume MQTT messages and store the history in InfluxDB. If you're wanting to store the history in some other way, and looking to bypass MQTT, that should be possible, but you'll have to write your own ruby code that uses this gem directly, and then outputs the data in whatever way you want.
As to if this is the same data as is sent to Symphony and the dealer portal - yes and no. This tool has access to the exact same data that an AWL (and thus Symphony) can access, it's a matter of finding the data you want. I've mapped almost every register that an AID tool or the AWL/Symphony Web UI can display for my system, so I know where to find the data. But I've never seen the dealer portal on Symphony, so cannot say with certainty that I'm pulling every piece of information that has. You can look through my list of register names at https://github.com/ccutrer/waterfurnace_aurora/blob/096f930b962e37193e89144e7a6395de3f266eaa/lib/aurora/registers.rb#L697 to see if the data you're hoping for is mapped already (beware that naming might be slightly different - this is true even of WaterFurnace's tools - the AID tool and Symphony might have slightly different naming for the same data point). The MQTT bridge defaults to refreshing the data every 5 seconds while it's running.
As for where to connect: if you have an AWL, and you want to use an AWL and this tool, you must connect to the AWL's AID Tool port. If you no longer need/want an AWL, or don't have one, you can connect directly to the WaterFurnace (actually the ABC board is what you talk to). Either way, the same data is available - an AWL just forwards any requests on its AID tool port to the ABC. You cannot use the MQTT bridge and an AWL if you tap in between the ABC and the AWL - the messages will clobber each other and neither tool will work.
As to the wiring of the AWL-provided cable: I'm not sure, but if I remember correctly the provided cable doesn't even use the standard 4 colors. IIRC it is a "straight" cable, and not a "crossover", but you'll have to identify wires by their pin location in one of the plugs, rather than by color.

Thank you for the response. So if I plug into the aid tool port on the awl, it will pull data every seconds?

Yup

Btw, I had a technician over today, and he confirmed that what he sees on the Symphony website is exactly the same as I see with the Web AID Tool locally, and the ruby gem is currently publishing (almost?) everything accessible in the AID Tool.

I have had it running for a few days now and the outside temp stopped
updating, but the symphony app still updates. Any idea on how to fix that
one data point? Thank you.
On Mon, Feb 7, 2022 at 6:02 PM Cody Cutrer @.***> wrote:

Btw, I had a technician over today, and he confirmed that what he sees on
the Symphony website is exactly the same as I see with the Web AID Tool
locally, and the ruby gem is currently publishing (almost?) everything
accessible in the AID Tool.
—
Reply to this email directly, view it on GitHub
https://github.com/ccutrer/waterfurnace_aurora/issues/13#issuecomment-1032021559,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGPVED6SYHE7AASXXPLYB3U2BFQLANCNFSM5NEVV3ZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

To be clear, the aurora-xxx/abc/outdoor-temperature topic in MQTT has stopped updated, but other data points are updating, like aurora-xx/abc/entering-air-temperature? That would be quite unusual for a single data point to stop working, since all data is fetched from the ABC in a batch. It would make more sense to me if somehow the bridge had either stopped running, or was jammed up, and no data was updating anymore.

Hmm. Do you have an IZ2 system, or just a single communicating thermostat? The register I'm pulling the data from looks like it might be in an IZ2-only range, so if you don't have IZ2 I might need to find where the register is for non-IZ2.
If you restart the aurora_mqtt_bridge, does it start updating again? If it doesn't, try publishing the message 31003 to aurora-xxx/$modbus (replacing xxx as appropriate with your serial number), and then it should send back a message at aurora-xxx/$modbus/31003 with a fresh reading. Is that reading still "stuck"?

I’m sorry, but I am still new at some of this. How exactly do I send a
message on ssh? Can you give me the exact command please? I have the serial
number, I just don’t know how to start the command to publish a message.
On Tue, Feb 8, 2022 at 10:27 AM Cody Cutrer @.***>
wrote:

Hmm. Do you have an IZ2 system, or just a single communicating thermostat?
The register I'm pulling the data from looks like it might be in an
IZ2-only range, so if you don't have IZ2 I might need to find where the
register is for non-IZ2.
If you restart the aurora_mqtt_bridge, does it start updating again? If it
doesn't, try publishing the message 31003 to aurora-xxx/$modbus
(replacing xxx as appropriate with your serial number), and then it should
send back a message at aurora-xxx/$modbus/31003 with a fresh reading. Is
that reading still "stuck"?
—
Reply to this email directly, view it on GitHub
https://github.com/ccutrer/waterfurnace_aurora/issues/13#issuecomment-1032732626,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGPVEHXTJNLDMVEX4ASBSLU2EY6JANCNFSM5NEVV3ZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

It's MQTT. I would recommend using MQTT Explorer (http://mqtt-explorer.com) as a simple UI to see what data is in your MQTT server.

Thank you. I sent the message and now the mqtt explorer shows no temp and
home assistant is showing the reading as zero. I then uninstalled the gem
and mosquito and then reinstalled them. Now it is again Stu k at 12
degrees.
On Tue, Feb 8, 2022 at 5:10 PM Cody Cutrer @.***> wrote:

It's MQTT. I would recommend using MQTT Explorer (http://mqtt-explorer.com)
as a simple UI to see what data is in your MQTT server.
—
Reply to this email directly, view it on GitHub
https://github.com/ccutrer/waterfurnace_aurora/issues/13#issuecomment-1033113556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGPVEFSRLZX35WNLITBBJDU2GIFRANCNFSM5NEVV3ZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


src/Makefile: Create/delete source_id/generated.ml

since #2587, the generated file is source_id/generated.ml, and no
longer source_id/source_id.ml. The latter is a normal file that make clean should not delete. So let’s tell make about this.
(It seems that either nobody runs make clean, or everybody expects
weird behaviour and isn’t surprised that make clean deletes committed
files.)

This PR does not affect the produced WebAssembly code.


stuck in DownloadFileAsync

unfortanly don't have WtClient logs  and cant reproduce it isolated .
( big app with thousands connections , lot of threads and async actions and debug logs with primitive static Helpers.log  completly useless, I can't separate different WTclients in log)
BUT i have idea, mayby this could help:
when im restart a service, after dispose wtclients with stucked actions i see lot of errors in  log
errors look like something was UNLOCKed in dispose and trying to  do  session.save
files are small, few kb - ProfilePhoto without 'big' flag
Message: The object or value could not be serialized. Path: $.
MeatSource: System.Text.Json
TargetSite: Void ReThrowWithPath(System.Text.Json.WriteStack ByRef, System.Exception)
Stack Trace:
   at System.Text.Json.ThrowHelper.ReThrowWithPath(WriteStack& state, Exception ex)
   at System.Text.Json.Serialization.JsonConverter`1.WriteCore(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)
   at WTelegram.Session.Save()
   at WTelegram.Client.NewMsgId(Boolean isContent)
   at WTelegram.Client.SendAsync(IObject msg, Boolean isContent, Rpc rpc)
   at WTelegram.Client.Invoke[T](IMethod`1 query)
   at WTelegram.Client.<>c__DisplayClass141_0.<<DownloadFileAsync>g__LoadPart|0>d.MoveNext()
--- End of stack trace from previous location ---
   at WTelegram.Client.DownloadFileAsync(InputFileLocationBase fileLocation, Stream outputStream, Int32 dc_id, Int64 fileSize, ProgressCallback progress)
   at  (APP STACK)

    Inner Exception
    ---------------
    Type: System.InvalidOperationException, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
    Message: Cannot write the start of an object or array without a property name. Current token type is 'None'.
    MeatSource: System.Text.Json.Rethrowable
    TargetSite: Void ThrowInvalidOperationException(System.Text.Json.ExceptionResource, Int32, Int32, Byte, System.Text.Json.JsonTokenType)
    Stack Trace:
       at System.Text.Json.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource, Int32 currentDepth, Int32 maxDepth, Byte token, JsonTokenType tokenType)
       at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryWrite(Utf8JsonWriter writer, T value, JsonSerializerOptions options, WriteStack& state)
       at System.Text.Json.Serialization.JsonConverter`1.WriteCore(Utf8JsonWriter writer, T& value, JsonSerializerOptions options, WriteStack& state)

App hold lot of stuck calls because i ignore them, I make anti-stuck workaround
var limit = Task.Delay(TimeSpan.FromMinutes(1), stoppingToken);
var sendTask = //call   wt cliebt
Task.WaitAny(sendTask, limit) ;

Also got hang in DownloadFileAsync... Worked around with time limit + reconnect


HSEARCH-3795 Get rid of Version.logVersion()

https://hibernate.atlassian.net/browse/HSEARCH-3795

Merged thanks!


Add landing page

This does not currently validate the identifiers. That will be added later when the parser lands.
figma:
https://www.figma.com/file/WSXjCGc1k6FVI093qhlzOP/04-Recieving-share-link?node-id=59%3A1

demo:
https://matrix-to-hqclep1bv.vercel.app/

Sorry for the million files. They're all very small

This resolves: https://github.com/matrix-org/matrix.to/issues/90


Tests fail for s390x in Fedora since 0.12.15

Tests fail for 0.12.15 in Fedora for s390x arch. Tested for rawhide, F41 & F40. Builds for 0.12.14 are fine.
--- FAIL: TestCliRun (1.14s)
    --- FAIL: TestCliRun/exp,_exp10,_exp2,_expm1_functions (0.00s)
        cli_test.go:87: standard output:
              strings.Join({
              	"[1,0.606530659,2.718281828,0.22313016,7.389056098,22026.46579480",
              	"6,2.6881171418161356e+43]\n[1,0.316227766,10,0.031622776,100,1000",
              	"0000000,1",
            - 	".0000000000000002",
              	"e+100]\n[1,0.707106781,2,0.35355339,4,1024,1.2676506002282294e+30",
              	"]\n[0,-0.393469341,1.718281828,-0.77686984,6.389056098,22025.4657",
              	"94806,2.6881171418161356e+43]\n",
              }, "")

    --- FAIL: TestCliRun/atan2/2,_hypot/2_functions (0.00s)
        cli_test.go:87: standard output:
              strings.Join({
              	"[0,1.5707963267948966,0,0.785398163397448",
            - 	"3",
            + 	"4",
              	",3.141592653589793,2.819842099193151]\n[0,3.75,12,5,6.25,13,16,16",
              	".433578429544795,20]\n",
              }, "")

FAIL
exit status 1

Could you paste the result of the following command?
gojq -n -c '[range(0; 100; 10) | exp10 *<PHONE_NUMBER> | floor /<PHONE_NUMBER>]'

Thank you, I fixed the tests.


Bad result for tutorial.mnist_blackbox

I run the tutorial code called mnist_blackbox.py, however the result is not the expected for the test accuracy of oracle on adversarial generated using the substitute is 0.85096. It  seems the adversarial examples have little effect on the test accuracy. Has anyone else meet this problem? By the way, the version of tensorflow I used is 1.2.1. I think it's not the problem of tensorflow.
Successfully downloaded train-images-idx3-ubyte.gz 9912422 bytes.
Extracting /tmp/train-images-idx3-ubyte.gz
Successfully downloaded train-labels-idx1-ubyte.gz 28881 bytes.
Extracting /tmp/train-labels-idx1-ubyte.gz
Successfully downloaded t10k-images-idx3-ubyte.gz 1648877 bytes.
Extracting /tmp/t10k-images-idx3-ubyte.gz
Successfully downloaded t10k-labels-idx1-ubyte.gz 4542 bytes.
Extracting /tmp/t10k-labels-idx1-ubyte.gz
X_train shape: (60000, 28, 28, 1)
X_test shape: (10000, 28, 28, 1)
Preparing the black-box model.
Defined TensorFlow model graph.
Completed model training.
Test accuracy of black-box on legitimate test examples: 0.989746192155
Training the substitute model.
Defined TensorFlow model graph for the substitute.
Substitute training epoch #0
Completed model training.
Augmenting substitute training data.
Labeling substitute training data.
Substitute training epoch #1
Completed model training.
Augmenting substitute training data.
Labeling substitute training data.
Substitute training epoch #2
Completed model training.
Augmenting substitute training data.
Labeling substitute training data.
Substitute training epoch #3
Completed model training.
Augmenting substitute training data.
Labeling substitute training data.
Substitute training epoch #4
Completed model training.
Augmenting substitute training data.
Labeling substitute training data.
Substitute training epoch #5
Completed model training.
Test accuracy of oracle on adversarial examples generated using the substitute: 0.850964466594

Yes, there is a related issue raised #176 . Switched to the Adam optimizer has resulted this drop in accuracy. Using Adadelta will get you better results, a test accuracy of 0.497 on the adversarial samples. Something will be done about this soon.

@npapernot What's the plan to address this issue? It looks like #176 didn't address this?

I made a note to take another look a few days ago but I did not get a chance to look at it yet.