Add indication whether a feature is a community or enterprise (paid) feature

Not all the libraries that are free for personal use provides all of their features for free, some use community and enterprise licensing. For example, ag-Grid uses the e symbol to indicate if it's an enterprise feature such as server-side, pagination, sorting, filtering, etc.

Having an icon indicative if it's an enterprise feature or not would be helpful for independent developers to know if the feature they want are free for personal use. We could also implement filters in the future.

Good insight. This is precisely why I implemented a third state for features other than true/false — if the feature is a string, the site displays the feature with an exclamation and tooltip:

I don't think I've used this to designate premium features like you suggested, though. What do you think?

I believe what you proposed is a solution and much easier but it would probably better for future improvements to have a dedicated state for community and enterprise licensed feature for us to filter features further.
ex. filter by feature -> filter by community or enterprise license.
But I believe we can also do this with exclamation and tooltip but it would probably be vague since they have to hover for the message to understand the indication instead of a dedicated solution.
I haven't checked but if only a handful of the sites listed has this, a tooltip might be enough for now. The dedicated solution might be too overkill.

We could actually reuse your logic with the exclamation. For example if the string contains enterprise, we use the enterprise icon to cater both solution and later on apply the filter by community or enterprise license.
What do you think?

Definitely onboard with the word premium. As for the icon, I have looked at the library you are using  (e.g. react-icons/fa) and I also thought that it's the only icon that conveys the message.
Might also be a goods-first-issue don't you think. I wanted to contribute but I always get bad credentials error when I try to run GITHUB_TOKEN=<token> yarn dev

Yeah, I'd love the help!
Sorry you're having trouble. What you're doing should work. I'm using a GitHub personal access token with zero permissions — maybe make sure yours works and that you can do simple curl requests against the API?
I just moved from yarn to pnpm (as I'm doing in all my projects), so make sure to use GITHUB_TOKEN=ghp_xxxx pnpm dev moving forward.

I made a proof of concept with regards to this gh issue. Let me know if the PR is as expected and I will make the necessary changes for the other premium features.
BTW, sorry for the messy history. I am trying to learn.

Looks good to me! I would have used a regexp myself, but .includes() is totally fine.

I am familiar with regexp and will implement that in future commits.

You're live! https://jsgrids.statico.io/


asdf list all yq does not list yq versions with minor version numbers that have more than 1 digit

For instance version 4.16.2 is not listed, the latest version listed is 4.9.8

This seems to be working for me after a quick test. I see v4.16.2 as the last version in the list.
If you are still seeing problems with this are you able to share any additional information about the environment you are seeing this in?


Is there a Mandarin multi-speaker pretrained model?

Hi, Is there a Mandarin multi-speaker pretrained model?  I didn't find it

We do not support it.
Do you have recommendation of such a TTS dataset?

好的 谢谢  暂时没有收集


nil pointer dereference when accessing hook returned by test.NewNullLogger and using debug log level

func main() {
	tlog, hook := test.NewNullLogger()
        // commenting the following statement results in a 'nil pointer dereference'
	// tlog.Level = log.DebugLevel
	tlog.Debug("Test debug")  // Changing the log level to Warn or Error doesn't result in an error
	fmt.Println(hook.LastEntry().Message)  // nil pointer error occurs on this line
	return
}

Output
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x213c]

Setting either the log level explicitly to debug or logging with a level above debug works fine.

Exact same issue myself.

FWIW I am seeing this issue with NewNullLogger and NewGlobal.
When I try NewLocal I'm getting a vendor error:
cannot use tlog (type *"github.com/maxlinc/omitted/vendor/github.com/Sirupsen/logrus".Logger) as type *"github.com/Sirupsen/logrus" in argument to test.NewLocal

you can try
type DevNull struct{}
func (DevNull) Write(p []byte) (int, error) {
return len(p), nil
}
l := log.New(new(DevNull), "", 0)

Just curious, what would you expect the behavior to be?  I was able to reproduce with logging an Info level Entry, but explicitly setting the logger to Warn:
	tlog.Level = logrus.WarnLevel
	tlog.Info("Test info")

The hook hasn't received any Entries (as expected), and its LastEntry would be nil.

Normal behaviour, test code is incorrect, closing.


Parent method in conditional CSS

Use case: we need to use button hovers on desktop only, so we can detect desktop devices and add  class "no-touch" to html tag.
CSS should be:
.no-touch .link:hover {...}

It would be fine, if we had some parent() method for ampersand, e.g.
val link = style(
  ...,
  &.hover.parent(".no-touch")(
    ...
  )
)

I can't remember if there's a way to do this with the existing DSL or not.
If not, the good news is that it will be trivial to add as the underlying mechanics are already in place to support it. It might just need a PR to wire it up with a prepend value.
https://github.com/japgolly/scalacss/blob/master/core/src/main/scala/scalacss/Style.scala#L35-L42
So you'd just want to end up with a value of sel like (".no-touch " + _).

I wanted this functionality too, and independently re-invented it as an unsafeParent method, very similar to the existing unsafeRoot and unsafeChild methods. I was going to file a new issue, but discovered this one already existed :-)
This is what I came up with, which would be an trivial addition to DslBase:
  /** Enables a parent CSS selector to be added to the style, along the lines of the SASS `parent-selector &` construct.
    *
    * Parent selectors are useful for customizing styles based upon a CSS class added to a parent element (e.g. for language localization, or for browser-specific customization).
    *
    * Use `unsafeParent` like this:
    *
    * {{{
    * val styleWithJaCustomizations = style(
    *   // common styles here ...
    *   unsafeParent(".ja")(
    *     color(pink)
    *   )
    * )
    * }}}
    *
    * This will generate something along the lines of:
    *
    * {{{
    * .Css_Container-styleWithJaCustomizations {
    *   // common styles here ...
    * }
    *
    * .ja .Css_Container-styleWithJaBrowserCustomizations {
    *   color: pink;
    * }
    * }}}
    *
    * @param p The name of the parent CSS selector.
    * @param t The content to be included under the parent selector.
    * @return An [[Style.UnsafeExt]] object that will emit the desired CSS.
    */
  def unsafeParent(p: String)(t: ToStyle*)(implicit c: Compose): Style.UnsafeExt = unsafeExt(p + " " + _)(t: _*)

Until this feature is implemented in DslBase (presumably placed next to unsafeChild), end-users may wish to add a trait like the following to their project, and then extend that rather than scalacss.StyleSheet.Inline:
import scalacss.internal.Compose
import scalacss.internal.DslBase.ToStyle

trait AugmentedStylesheetInline extends scalacss.StyleSheet.Inline {
  import dsl._
  def unsafeParent(p: String)(t: ToStyle*)(implicit c: Compose): Style.UnsafeExt = unsafeExt(p + " " + _)(t: _*)
}

@japgolly What is the status of this? The issue is quite old, perhaps this feature is already implement? If so please point me to the right place. Otherwise, what do you think about including this into the library? I've extended it a bit:
import scalacss.internal.{Compose, StyleA}
import scalacss.internal.DslBase.ToStyle

trait AugmentedStylesheetInline extends scalacss.StyleSheet.Inline {
  import dsl._

    def parent(p: StyleA)(t: ToStyle*)(implicit c: Compose): Style.UnsafeExt = unsafeParent(s".${p.htmlClass}")(t: _*)

    def unsafeParent(p: String)(t: ToStyle*)(implicit c: Compose): Style.UnsafeExt = unsafeExt(p + " " + _)(t: _*)
}

Named it just parent as it will fail at compile if the parent style (css class) is removed. Or maybe by "safe" you mean something more?
In any case, I can make a PR, unless there is a reason you wouldn't want such change introduced?
Cheers


GitHub code fences should output pre

GitHub's code fences should output a pre element and not a code element, you can see that at the first lines of http://github.github.com/github-flavored-markdown/
Btw, thanks for an awesome module. It was a huge advantage to be able to use marked instead of other, more limited JavaScript Markdown parsers for my StyleDocco project.

I tried to look into this issue myself, but it seems like the tests actually expect pre output, and pass. However:
$ ./bin/marked
```
foo
```^D

foo

Am I doing something wrong?

The marked script was changed once options were added. You need to use the --gfm flag to enable gfm now. It was easier to do it this way than to have gfm enabled by default and creating a --nogfm argument.
Hmm, you're right. It does only output pre. Strange that it doesn't bother adding a code element, even if you name the language you're using. I guess the language's @class will have to go on the pre element instead of a code element.

I noticed another error when using gfm: true. The lexer reports code blocks to be of pre type, but in the tok function there is no case for pre, only code, so gfm code fences will output undefined when parsed.
I wasn't sure how you wanted to fix it, either by changing the lexer to output the code type, or by adding another case for pre types?

https://github.com/chjj/marked/blob/master/lib/marked.js#L123
      tokens.push({
        type: 'code',
        lang: cap[1],
        text: cap[2]
      });

Where do you get tokens with a type of pre? Could you show me an example?

Bah, that was probably something I had changed in my local copy while investigating the previous issue then. Sorry for wasting your time :P


Nightly Tests Binary Failure chapter05_recurrent-neural-networks/rnns-gluon StraightDope: Python2 Single-GPU StraightDope: Python3 Single-GPU

Description
Nightly tests have failed on test "chapter05_recurrent-neural-networks/rnns-gluon" for two consecutive runs with timeout errors.  We can reasonably say that the CI infrastructure is performing as expected.
08-22: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTests_onBinaries/detail/NightlyTests_onBinaries/125/pipeline
08-23: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTests_onBinaries/detail/NightlyTests_onBinaries/126/pipeline
.
INFO:root:Running notebook 'chapter05_recurrent-neural-networks/rnns-gluon'
INFO:traitlets:Executing notebook with kernel: python2
ERROR:traitlets:Timeout waiting for execute reply (600s).
ERROR:root:Cell execution timed out
.
======================================================================
FAIL: test_rnns_gluon (test_notebooks_single_gpu.StraightDopeSingleGpuTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/mxnet/tests/nightly/straight_dope/test_notebooks_single_gpu.py", line 180, in test_rnns_gluon
    assert _test_notebook('chapter05_recurrent-neural-networks/rnns-gluon')
AssertionError
----------------------------------------------------------------------

@zhreshold

@vishaalkapoor - Any comments here? Thanks!

@sandeep-krishnamurthy
Hi, this was resolved by reverting notebooks that were added on 08-21 (just prior to the failure) https://github.com/apache/incubator-mxnet/pull/12343
and you created an issue to track adding back those notebooks.
https://github.com/apache/incubator-mxnet/issues/12345
Coincidentally, I'm looking at the straight dope today :)
Please feel free to close this issue as it's being tracked in issue 12345.


chore: Reduce line-height overwrites, add base font-size

I keep noticing several bits of weirdness to do with line-heights and font-sizes. This PR deals mainly with line-heights and centralizes them using relative units in our base stylesheet. I also noticed setting --kui-line-height also solves some issues mainly with k-cards.
The font-size addition was a late amend when I noticed some weirdness there also. At least for the moment, this amend means we can control our base font size, which is important for us seeing as we use rems quite a bit. I guess there are other places where we might change our rem usage to use --kui-font-size more, but still I guess there will be places where we might use rem.
This PR originally grew out of https://github.com/kumahq/kuma-gui/pull/1807#pullrequestreview-1748060631
I'm still a little unsure about setting --kui-line-height-20 ourselves but given everything I'd rather do that now and have all our line-heights make sense, we can always undo this at a later date. All in all there are more things that make me want to do this than not want to do this.

@kleinfreund I think the majority of your inline comments can be addressed with this:
Did you see that .k-card-body uses --kui-line-height, therefore setting --kui-line-height to 1.3 means .k-card-body uses that, which means we no longer have to set line-heights for everything as if anything does inherit from that it will still be 1.3 i.e. the default for the application (which is also a relative unit and therefore just works in the majority of cases). This covers your suggestions I think and is the entire point of this PR.

That is intentional. The CSS custom properties are intended to be the application-level customization layer and the Sass variables are the defaults. This allows Kongponents styles to be customized without resorting to overriding CSS rule sets.

Ok great!

Could you provide us with some before/after screenshots of places where we need to change --kui-line-height-20, please?

Again see above for the point of the PR, but I think it's more the fact that we can remove all of the places where we resort to overriding the CSS by using the CSS custom property (as you've mentioned above). This PR sets the line-height in one place and then it generally works for the entire application without having to add more and more CSS overwrites throughout the application.
There are a few places where this does improve things visually here's one of them:
Before

After

I guess there are others, but the thing is I should barely need to think about it now.

Additionally, I think the base font size should be set on html or body. Why add .kuma-ready?

In a HTML document :root is html, I added kuma-ready as we own that and I don't want to apply this rule until our application is ready.
I think I covered everything but lemme know if not.

Don’t get me wrong, I’m very much in favor of using relative line-heights because in the vast majority of cases, there isn’t a need for a more fine-grained control of line-height.
However, since we do use Kongponents and its styles are exclusively written with non-relative font-size/line-height pairings, we also have more constraints to take into account.
Specifically, I think setting one --kui-line-height-XX property (and yes I did see that, I commented on it here and here) to change the absolute line-height of the line-height-XX token to a relative one is problematic. It breaks the scale between that and other line height tokens and partially defeats the purpose of using design tokens in this way. This is how the individual line height tokens would apply with those changes:

line-height
value

10
12px

20
1.3

30
20px

40
24px

50
28px

60
32px

70
36px

80
40px

90
48px

100
56px

If we really, really want to override the line height tokens, we should override all line height tokens so we don’t break the scale and risk any updates to that scale breaking our visuals. And I kinda don’t want to override any of those line height tokens.
Ultimately, if that’s how you want to handle this, I’m fine with it. It just really doesn’t seem like intended design token use.

In a HTML document :root is html, I added kuma-ready as we own that and I don't want to apply this rule until our application is ready.

The point was very much about why .kuma-ready is there. It shouldn’t be. It doesn’t provide anything useful. The variable setting code show go into the variables file also.

Do you think we should set the document font size before the application is ready?

Yes, 100%. There is no reason to have a set of base styles that don’t always apply. Base styles should always be set and use tag selectors so they apply to all elements for that tag and can be easily overridden by more specific things. On that note, html is a preferable selector as it has lower specificity than :root.

For what it's worth, for MinK, the app shell handles hiding the host app so this REALLY isn't needed there.
I'll also note that this thread will likely be mute next week as a lot of the classes you're targeting k-card-body as an example are changing or being removed.
Once the reskin effort is complete, there should be zero style overrides on things like card text, etc. that live inside a component.

https://github.com/kumahq/kuma-gui/pull/1853 needs to happen first

I'm still a little unsure about setting --kui-line-height-20

Looks like since https://github.com/kumahq/kuma-gui/pull/1853 we no longer need to do this 🎉

@adamdehaven @kleinfreund I wanted to resurrect this one now that the KCard amends have gone in.
I noticed since those amends went in things are much better, and this PR removes all the line-height overwrites we had. Instead we have 1 single line-height in the base stylesheet that is applied to body and headers. It is still a relative value, but that means we don't have to worry about line-height for anything that it non-kongponent.
I think the font-size 16 is no longer required but even when that issue was fixed upstream I was half "maybe we should keep this here for if it happens again" @adamdehaven will completely leave that one up to you whether you want me to remove or you think we should keep it in here.
Following that last point if we are leaving it in, I'd be fine using html and removing the .kuma-ready if I know that I'm not ever going to clobber any font sizes in the small period of time where our application is loaded but not yet ready. Overall it might be easier to say "just remove this font-size entirely, if the issue happens again, it happens again, we know where to fix it if it does" - I'm also ok with that.
If you could let me know either way on those points and we can get this one merged or closed.
So TLDR;

font-size remove entirely or leave.
If the answer to 1. is leave, then let me know on the selector options.
line-heights are we ok with what is here now?

font-size remove entirely or leave.

I reckon it’d be the most safe to always set a font-size on html.

2. If the answer to 1. is leave, then let me know on the selector options.

I don’t think there is a point in differentiating between "HTML file is discovered and its styles are applied" and "We set .kuma-ready" when it comes to styles. That just delays when styles are applied and I can’t think of any reason why we’d want that.
We should apply font-size to the selector html.

3. line-heights are we ok with what is here now?

I think so. Perhaps we can also reconsider setting some of those font-sizes in a form context, but we don’t have to do that now.

I don’t think there is a point in differentiating between "HTML file is discovered and its styles are applied" and "We set .kuma-ready" when it comes to styles. That just delays when styles are applied and I can’t think of any reason why we’d want that.

The original issue came from the fact that the MinK loading template applied a font-size different to ours on html from what I remember. I'm guessing this was because of setting the font-size of something for the loader, or previous to our application being ready. If that is still necessary (or someone adds something again in the future), then we wouldn't clobber that with this rule due to the .kuma-ready

The original issue came from the fact that the MinK loading template applied a font-size different to ours on html from what I remember. I'm guessing this was because of setting the font-size of something for the loader, or previous to our application being ready. If that is still necessary (or someone adds something again in the future), then we wouldn't clobber that with this rule due to the .kuma-ready

I think we established that this wasn’t intentionally set

Which makes me want to resolve the kuma-ready thing, as if we are removing it then I think that we might want the higher specificity of :root?
Anyway, let me know if you follow why I think the kuma-ready thing is probably a good idea.

I don’t think we want the higher specificity, but it probably won’t cause issues, so I’m fine with using :root.

You don't need kuma-ready.
Root should be fine; anything more specific on a global level might conflict with Kongponents or other components which isn't desired.

Cool thanks all, let me remove the kuma-ready but leave the :root I think that was the consensus here


Remove unnecessary group assignment for management user prune.sh script.

Defining the group isn't required here as only user has access to the script.
Also there may not be a group named after the username, which is the case on my management machine.

I've not been able to test this, but I'm wondering what the resulting group is if you don't define it. It might be root if you run the role with become and that wouldn't be good.

@stroobl Yes, the group would be root. Why is that a problem? root can do anything anyway :thinking:


Implement Line Integral Convolution

Vector visualization is crucial to visualize fluid movements (i.e. winds and ocean currents).
The first implementation of LIC in BlenderNC will follow the Scipy LIC website (link here)
The objectives are:

[ ] Static velocity field animated (i.e. animate a snapshot of the velocity field)
[ ]  Continues animation of the velocity field (i.e. animate the velocity field in time)

The final objective is to allow users to produce animations like the perpetual ocean by NASA:
https://www.youtube.com/watch?v=CCmTY0PKGDs

Update:

First implementation of LIC in BlenderNC:


is CodeExplorerBundle mean to be reusable bundle?

is CodeExplorerBundle mean to be reusable bundle?
(where is the place to ask this question, and not opening new issue?)

It's OK to open issues to ask this kind of questions!
CodeExplorerBundle was created because of the old way of developing Smyfony apps. However, with Symfony Flex it will be no longer necessary. I have a prototype of Symfony Demo with Symfony Flex on my local computer. It's almost working. All bundles are gone and the whole app is much simper now. I'll create the PR once Flex is open sourced. Thanks!

ok, thanks.


[Bug] BD is in Dutch while regular Discord features are in English like supposed to

Describe the Bug
BetterDiscord is in Dutch (my native language) while regular Discord features are in English like supposed to.
To Reproduce

Live in the Netherlands
Set Discord language to English, UK
Inject Discord executable with BetterDiscord

Expected Behavior
Everything is in English, like I've set in my Discord settings
Screenshots

Discord Version
Stable

After changing if you leave the settings menu then re-open it, is it still mis-translated?

Yes

Does this happen now with the latest version?

Doesn't seem to be, thanks.


Adds TfIdfVectorizer as a custom kernel for onnxruntime

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9f8681c) 82.68% compared to head (9276bc6) 82.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   82.68%   82.68%
=======================================
  Files          51       51
  Lines        6595     6595
=======================================
  Hits         5453     5453
  Misses       1142     1142

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sensor Things API application

This PR adds followings commits:

Add sta (Sensor Things API) application. This application provides endpoints for Observation model.
Add tests to verify the sta endpoint verbs.

Great! Thanks!


Not working with SVG elements

Scroll to SVG path element failed with no warning, nothing happens.
You can get coords by getBBox() function, but need to consider SVG scaling.

Solved for me by using animated-scroll-to package instead.

It'd be great if this library could also work with svg elements


RoverDude/USI mod metadata overhaul

Add USI-Core, USI-MKSLite, USI-NuclearRockets. Change install methods and dependencies of other USI mods as well as make use of their .version files. Epoch bumps to mods that currently conflict with the new USI-Core should have users update those mods and avoid issues (hopefully). If that doesn't work then a lot of users will need to be told to remove and re-install UKS and/or Karbonite.
With thanks to @qm3ster and @bobprime for giving me a basis to work from and for pushing me to (finally) get this done.
Closes #2392, closes #2474, closes #2343, closes #2361

I suspect that Jenkins failure is due to KerbalStuff web site issues. Will have it rebuild later.

Files look alright, but testing is required.

Files look alright, but testing is required.

I'm not sure if you're saying that you're going to test or if you're looking for someone else to do it.

@plague006 : You are totally awesome. :)

All of these look excellent to me, and definitely better than the old versions given the restructure. Merging with enormous thanks. <3

@qm3ster and @bobprime just want to re-iterate that the work you guys did was great and appreciated. I only did this myself because it was easier to have the entire USI library overhauled at once with all the small and large changes required.


Small code comment to help identify React vs HTML

I'm going to push back on this and reject simply because the lines before those blocks already say the same. Thank you for the PR!


Logitech Media Server addition

What this PR does / why we need it:
Which issue (if any) this PR fixes:
Fixes #
Any other useful info:

Hi, thanks for your contribution.
Few things missing:

docs
ports listed in the relevant doc file
the hostname is missing from traefik.toml
add the application to the readme

Also:

please remove the "last modified by comments", this is unnecessary when files are version controlled
does logitech media server modify files it serves? If not, then we don't need the rw permission variable in all.yml and just fix the permission to ro
The user and group id variables in all.yml aren't used.
the mediaserver webport variable isn't used,
the port isn't specified to Traefik so external access won't work as it's configured due to multiple ports being mapped. See other applications for examples.

This was a mistake, was supposed to go to my fork only.
Will submit here later.


Inheriting configs

Hey 👋
Im creating my own Style Function API on top of SS v5.
Without going too deep into why I'm doing this, I've created this minimal example to reproduce the issue: https://codesandbox.io/s/styled-system-issue-inheriting-configs-p3ibv

Note: The example above is dumb, please don't fixate too much on it.

Basically, I'm importing the border function from SS and then creating my own border function based off its config.
Surprisingly the borderRadius prop stops working.
I've been knocking my head against the wall trying to figure out why - but no luck (and now I have a headache)
Does this make sense to anyone?

I just realized that I hadn't finished setting up the API to actually work like this (though I thought it was in there already) – think I can get an update to support this soon


Loading/exporting models in AEON format

We should be able to load models in AEON format and perhaps also extend the format (in a standardized way) to accommodate new components of the sketch. It already supports the model annotations, which could be used to represent most of the sketch parts that are not supported directly.
I see several "steps":

[x] Loading models in plain AEON format. This is super useful for testing purposes at the moment.
[x] Loading models in AEON format with model annotations that would include HCTL formulas for dynamic properties and FO formulas for static properties. It is also helpful for testing inference workflows but not pressing.
[x] Design how to standardize the annotations for other kinds of template properties and extend the loader to cover these two.

I think the first two are critical and should be relatively straightforward to implement. The last one is not really critical at the moment, but it would be a nice addition before a proper release.
We should also make it possible to export the models in (extended) AEON format, covering as much of the sketch as possible.
Lastly, SBML support would be practical too. This will be easier to implement once we have a format for representing all the template properties.

With #47 and #48, the first two tasks are finished. We still need to finish task 3. That is, extend/standardize the AEON format to cover template properties and datasets.

This is now mostly done with #57. Other entities are encoded with JSON annotations. We might get back to this in future and make the format rely more on the annotation system itself, instead of encoding the entities with JSON.


HelmChart api object - comma problem

Hi,
I am using k3s cluster version v1.20.4+k3s1 and I am trying to apply a rancher HelmChart using this controller. It works, however I have a problem when I try to use a comma value in set. I am aware that helm requires to escape a comma sign, but I guess somehow when helm-install starts, it does something weird to this setting.
My Helm chart object looks like this:
kind: HelmChart
metadata:
  creationTimestamp: "2021-04-22T09:47:03Z"
  finalizers:
  - wrangler.cattle.io/helm-controller
  generation: 3
  name: rancher
  namespace: kube-system
  resourceVersion: "2177"
  uid: bd42926e-355a-49d6-ab28-b15331067363
spec:
  chart: rancher
  repo: https://releases.rancher.com/server-charts/stable
  set:
    hostname: rancher-test.com
    http_proxy: http://example-wproxy.test.com:8080
    https_proxy: https://example-wproxy.test.com:8443
    ingress.tls.source: secret
    no_proxy: <IP_ADDRESS>/8\\,<IP_ADDRESS>/8
  targetNamespace: cattle-system
status:
  jobName: helm-install-rancher

and helm-install logs look like this:
helm_v3 install --namespace cattle-system --repo https://releases.rancher.com/server-charts/stable --set-string hostname=rancher-test.com --set-string http_proxy=http://example-wproxy.test.com:8080 --set-string https_proxy=https://example-wproxy.test.com:8443 --set-string ingress.tls.source=secret --set-string rancher rancher
Error: must either provide a name or specify --generate-name

From job logs it seems that no_proxy part is missing, there is nothing atfer last --set-string
And when I don’t escape comma i get an error about it:
helm_v3 install --namespace cattle-system --repo https://releases.rancher.com/server-charts/stable --set-string hostname=rancher-test.com --set-string http_proxy=http://example-wproxy.test.com:8080 --set-string https_proxy=https://example-wproxy.test.com:8443 --set-string ingress.tls.source=secret --set-string no_proxy=<IP_ADDRESS>/8,<IP_ADDRESS>/8 rancher rancher

Error: failed parsing --set-string data: key map "10" has no value

I also tried adding a different amount of \ and other " and more more, unfortunately with no success.
Is this a bug or is there maybe a workaround for this problem?

This should be resolved by #95, which won't land in K3s and RKE2 for a bit, but you can fix it on current versions by overriding the default spec.jobImage and manually escaping the comma in the set string:
kind: HelmChart
metadata:
  name: rancher
  namespace: kube-system
spec:
  jobImage: rancher/klipper-helm:v0.5.0-build20210505
  chart: rancher
  repo: https://releases.rancher.com/server-charts/stable
  set:
    hostname: rancher-test.com
    http_proxy: http://example-wproxy.test.com:8080
    https_proxy: https://example-wproxy.test.com:8443
    ingress.tls.source: secret
    no_proxy: <IP_ADDRESS>/8\,<IP_ADDRESS>/8
  targetNamespace: cattle-system

Thanks, so it was a bug.
As a workaround I just ran the helm manually, but I guess editing job will work too.


General: Improve navbar responsiveness

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The navbar has a fixed breaking point for collapsing everything into a menu. This leads to a lot of unused space on certain screen sizes. In the example below, everything would still easily fit into the navbar itself.

Description

This PR adds some more advanced responsive behavior to the navbar. If there's not enough space, the links to Course Overview, Course Management and Server Administration are collapsed into the menu, but the icons for notifications, theme and the user menu stay in the menu bar. Then, if there's not enough space for them, they'll be moved into the collapsed menu in a second step.
The breakpoints are approximately and dynamically calculated, taking the length of the login and the available options into account. For example, the breakpoint for the first wrap step needs to be lower if someone doesn't have access to Server Administration.
Steps for Testing

Prerequisites:

A user of each type: Student, Instructor, Admin

Test that the navbar collapses correctly for each user type. You should observe different breakpoints for each as they have different navbar options available. Note that the navbar will always leave space for the maximum occupancy (notification badge, disconnected icon, loading spinner) so it might look like it's wrapping too early but it's actually not - and it's not the intention to be 100% precise. It should just not let 1000 pixels of wasted space, but be a bit more intelligent
Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

navbar.component.ts
76%
86%

Screenshots

https://user-images.githubusercontent.com/23171488/178323269-1be0eeb0-128e-479b-850f-a7a7ae20a6f1.mov

@jschmautzer The idea is that if you have to click the hamburger menu, your cursor / finger is on the right side; so we've moved the course link to the right side as well so you don't have to swich to the other side. But yes, we could move it to the middle if the majority thinks that this is better. We could also move the icons to the right side as well instead of spreading them 🤷

@jschmautzer After discussing this with @krusche we decided to move the third line to the right as well so it looks more aligned. :)

@S-Eibl Interesting. Could you be more precise on the environment you're using? OS, Browser Version etc? I am not able to reproduce this behavior, see below

Hm, @S-Eibl. Tried it on a fresh windows installation with a fresh chrome installation real quick. Still works good :D
Anyone else who can repro this?

@ge65cer I've had a quick look and that's related to a lot of the logic being reloaded in the notification sidebar component when it gets rerendered. It requires some more refactors of it and the notification service so I'll fix that in a follow up


VS Code does not respect the diff flag in .gitattributes

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69.0
OS Version: Windows <IP_ADDRESS>44

Steps to Reproduce:

Open a local git repository in vscode

Make changes to a file 1.txt, and then add this simple .gitattributes file:
 *.txt -diff

Confirm output of git diff on the terminal: Binary files a/1.txt and b/1.txt differ

View the diff from VS Code Source Control panel.

Expected output:
VS Code source control panel shows "No preview available, binary files a/1.txt and b/1.txt differ" or a similar message.
Actual output:
VS Code shows the plaintext diff.

Context: I intend to unset the diff flag for certain large auto-generated files in my project. If I accidentally open their diff on the VS Code Source Control, currently, there is a noticeable lag (less than a second) and the rendered diff itself is unusable anyway. So, I'd prefer if VS Code just didn't attempt to display the diff in the first place.
Cross-ref: SO post that I made two weeks ago about the same issue.

Nice catch. I had written 1.6.90 instead of 1.69.0, fixed now.

@lszomoru Any feedback on this please? Happy to help in repro of the issue if required. Thanks!

Hi @lszomoru , let me know if this is valid issue and if I can help in anyway towards advancing it. Thanks!

@GaurangTandon, sorry this issue got lost in my notifications. I will try to take a quick look later this week.

Just ran into this issue myself! Huge HTML diffs that slow everything down, but I would like to track a rendered notebook in my repo...

Also just encountered this issue (in my case, wanting to flag a file to be diffed) with binary files flagged to diff in .gitattributes not rendering as text in VSCode.  Would be great if VSCode's diff visualization aligned with the git diff command output (ie. respecting the .gitattributes diff flag) 👍


A11y Build Warnings:  A11y: Non-interactive element  cannot have interactive role 'option'

Current Behavior
SvelteKit: v1.11.0
Skeleton: v1.0.0
Several components are causing warnings to be emitted when building a project.

![Screenshot 2023-04-07 at 10 05 42 (2)](https://user-images.githubusercontent.com/26180499/230532889-8c8ea44f-706f-4f72-9acf-64689be9e1a2.png)
Steps To Reproduce

Run vite build

Anything else?
Encountered warning while building portfolio site (link below).  Started happening after skeleton v1.0 upgrade.
https://github.com/cesarnml/portfolio-sveltekit

@cesarnml already resolved and the fix will come in the new release next week. Thanks for reporting though!
https://github.com/skeletonlabs/skeleton/pull/1280#issuecomment-1497926290


wrong crops on own dataset

Hi all :)
I'm trying to run openmask3D with data recorded with the PolyCam iOS app. From PolyCam I can export a pointcloud.ply file of the scene (Z up), images, depth and .json file per each frame that hold the camera intrinsics and extrinsics, as well as the image width, height and a blur_score. See details here
.json example:

{
"t_00" : 0.17319575,
"blur_score" : 32.372955,
"cx" : 507.0329,
"t_22" : 0.8309242,
"t_02" : 0.45727086,
"t_21" : -0.48847204,
"t_12" : 0.3169675,
"t_23" : -24.16848,
"center_depth" : 4.009069,
"timestamp" :<PHONE_NUMBER>4,
"height" : 768,
"t_10" : -0.9481788,
"t_03" : -4.817948,
"t_20" : 0.2663835,
"manual_keyframe" : false,
"t_13" : 0.65569174,
"width" : 1024,
"fy" : 849.0737,
"angular_velocity" : 3.4028235e+38,
"cy" : 383.2808,
"t_01" : 0.8722997,
"fx" : 849.0737,
"t_11" : 0.022103118
}

The t_ij element of the transform matrix is in row-major order, so i is the row and j is the column. We omit the last row because it is simply [0, 0, 0, 1].

\begin{bmatrix}
t_{00} & t_{01} & t_{02} & t_{03} \\
t_{10} & t_{11} & t_{12} & t_{13} \\
t_{20} & t_{21} & t_{22} & t_{23} \\
0.0 & 0.0 & 0.0 & 1.0
\end{bmatrix}

the pose/0.txt file would then be:

0.173196 0.872300 0.457271 -4.817948
-0.948179 0.022103 0.316968 0.655692
0.266383 -0.488472 0.830924 -24.168480
0.000000 0.000000 0.000000 1.000000

Quoting the polyform page:

The coordinate system of the camera poses follows the ARKit gravity aligned convention which you can read about here. In short, this is a right-handed coordinate system where the +Y axis points up, and -Z axis points in the direction that the camera was pointing when the session started, and perpendicular to gravity. Note: depending on the coordinate system convention of your downstream application you might have to apply an additional rotation to the camera transform to get the conventions to match.

I do then apply a 90 degrees X rotation matrix in order to have the Z axis up.
\begin{bmatrix}
1 & 0 & 0 & 0 \\
0 & 0 & -1 & 0 \\
0 & 1 & 0 & 0 \\
0 & 0 & 0 & 1
\end{bmatrix}
\cdot
\begin{bmatrix}
t_{00} & t_{01} & t_{02} & t_{03} \\
t_{10} & t_{11} & t_{12} & t_{13} \\
t_{20} & t_{21} & t_{22} & t_{23} \\
0.0 & 0.0 & 0.0 & 1.0
\end{bmatrix}

Resulting in
pose/0.txt

0.173196 0.872300 0.457271 -4.817948
-0.266383 0.488472 -0.830924 24.168480
-0.948179 0.022103 0.316968 0.655692
0.000000 0.000000 0.000000 1.000000

I then get the intrinsic from the first frame:
\begin{bmatrix}
fx & 0.0 & cx & 0.0 \\
0.0 & fy & cy & 0.0 \\
0.0 & 0.0 & 1.0 & 0.0 \\
0.0 & 0.0 & 0.0 & 1.0
\end{bmatrix}

849.073700 0.000000 507.032900 0.000000
0.000000 849.073700 383.280800 0.000000
0.000000 0.000000 1.000000 0.000000
0.000000 0.000000 0.000000 1.000000

PolyCam images resolution differs from the depth images, since the iOS Lidar is limited to 192x256px
Image: 1024x768
Depth: 256x192
I then resize them to 640x480 to fit your test dataset. By downsampling the color images and upsampling the depth images.
Since the iPad scans are taken in a vertical orientation, but saved horizontally, I also implemented a script that applies a rotation to the images, as well as to the camera poses and intrinsic. eg. from (480x640) to (480x640)
Now to my problem:
I'm getting a good segmentation from the mask3d part, but when checking the crops I'm only getting crops from few images (like max 4-5 from the 100-200 loaded), this way I'm not getting crops from objects that would be present from other images shot from other angles. crops also seems redundant within the only few objects selected. Sec. 3.2.1 of the paper.
Even within the objects where I could see some decent cropping was done, they don't get masked when queried in the visualization tool.
I've tried several scenes, from simple to complex, with and without image rotation, and with different parameters, with no success.

@aycatakmaz @elisabettafedele

Hi Niccolò,
Sorry for our late reply!
I took a look at the information you shared here. If I understand correctly, you resize both the depth images and the RGB images to 640, 480, which is great.
There are two potential issues that come to my mind, and it could arise due to the settings in the https://github.com/OpenMask3D/openmask3d/blob/main/run_openmask3d_single_scene.sh file:
1- It could be that SCENE_INTRINSIC_RESOLUTION is not set correctly. This should be the original resolution of the images that was used in the intrinsic matrix, SCENE_INTRINSIC_RESOLUTION="[height,width]". If I understand correctly, these values refer to 768 and 1024 in your case. So the resolution according to the intrinsic matrix should be set as an input in the config file.
2- The DEPTH_SCALE parameter should also be set correctly. Our depth images (from the ScanNet dataset) are scaled by 1000, so in order to convert them to meters, we divide the depth values we load by 1000 (which is the DEPTH_SCALE). If your depth values are already in meters, you should set this number to 1.
I hope this helps, and once again sorry for the late reply.
Best,
Ayca

I am closing the issue, feel free to re-open it if the issue continues!


Update Documentation/Readme

Google's documentation for cloudprint is really old now.  Their API playground does not feature it any longer, rather they have a ...minimal... simulation tool here
Also, using this gem before the point of having a refresh_token is impossible, and understanding the flow of obtaining a refresh_token is complicated.  Martin Fowler wrote an article about this, and he was using a well-documented API!

I agree with both statements. As for #2, I do intend to provide a more automated workflow up to the point of getting a refresh token. Unfortunately, I don't have much time to work on the CloudPrint gem.
If you feel this is something you'd like to tackle, I think I can provide some guidance for it.


Cow: Watch ponmankalhomes.com

Cow requests the watch of the watch_keyword ponmankalhomes\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ponmankalhomes\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Fixed Toolbar UI

Increased contrast of toolbar-handler
fixes #5118
https://github.com/plone/volto/assets/103531475/2de076da-000c-43e6-bf32-dfe20275c0eb

contrast increased and accessibility working fine in toolbar.

@Noobham this PR is incomplete and does not fix #5118 entirely. Please read the description again.

@Noobham additionally do not close and open multiple PRs for the same issue. See item 3 in https://6.docs.plone.org/contributing/first-time.html#things-not-to-do

@stevepiercy Thanks for reminding .

Why these 3 unit test failing any idea about this??
I have fixed accessibility problem .

@Noobham have you read https://6.docs.plone.org/volto/contributing/testing.html and https://6.docs.plone.org/volto/contributing/acceptance-tests.html? Each of the failed CI jobs has a link to the explicit error message and why it fails. Example: https://github.com/plone/volto/actions/runs/6982100725/job/19000572605?pr=5431. However you should run these tests locally and get them to pass before pushing commits to the repo. This will make your development faster, save CI resources, and avoid sending notifications to subscribers. If you still get stuck, then you can push your work and ask for help, explaining what you specifically do not understand in the failure messages.

@Noobham have you read https://6.docs.plone.org/volto/contributing/testing.html and https://6.docs.plone.org/volto/contributing/acceptance-tests.html? Each of the failed CI jobs has a link to the explicit error message and why it fails. Example: https://github.com/plone/volto/actions/runs/6982100725/job/19000572605?pr=5431. However you should run these tests locally and get them to pass before pushing commits to the repo. This will make your development faster, save CI resources, and avoid sending notifications to subscribers. If you still get stuck, then you can push your work and ask for help, explaining what you specifically do not understand in the failure messages.

@stevepiercy Thanks...

@ichim-david My first thought was to increase the contrast, but this will 'create' another color. In this case, wouldn't it be better to simply remove the opacity? What do you think?

@ichim-david should i change color as it was before in this PR.

@ichim-david should i change color as it was before in this PR.

@Noobham  I would do as I've said in my comment here https://github.com/plone/volto/pull/5431#issuecomment-1827477819
Unfortunately, I got no replies on this idea even when I asked for feedback.
so:

set opacity to 0.65
set #e40166 color on hover

@Noobham it's holiday season so I don't know exactly who will take the time todo the technical review until next year.
There are 2 things that I would do extra:

Add aria-expanded property on the button https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded
Change the aria-label and affect also the sidebar button otherwise we would have a merge where the toolbar is all visible while the sidebar is with 0.3 opacity and with bad accessibility.
I consider both sections to be mirrors of each other so I would make both changes in same pull request.

Even then you might get more feedback from others but again be prepared to take into consideration that this pull request might be merged only in January as ppl get back to work from holiday season, including myself.

@ichim-david What should I do with the sidebar button as I'm having trouble understanding the second section? Would you kindly ellaborate it please .
Thanks.

@ichim-david What should I do with the sidebar button as I'm having trouble understanding the second section? Would you kindly ellaborate it please . Thanks.

@Noobham

You are logged in and you want to add a content or you edit one.
The toolbar and sidebar are both opened in edit.
The sidebar has similar button and functionality to the one found on the toolbar.

https://github.com/plone/volto/assets/103531475/32acf93d-0b4e-46b8-a38f-0847ea94c1a3
Sidebar-handler's animation is playing when the page refreshes.
How should I approach animation?
@ichim-david

Screen.Recording.2024-01-26.at.10.26.55.PM.mov
Sidebar-handler's animation is playing when the page refreshes. How should I approach animation? @ichim-david

@Noobham the color stays the same from light blue to a higher opacity blue, I didn't say for you to make the sidebar red, I said you need to apply the changes similar to what it was done in the toolbar.
"Change the aria-label and affect also the sidebar button otherwise we would have a merge where the toolbar is all visible while the sidebar is with 0.3 opacity and with bad accessibility."
Indeed I said that they were mirrors of each other but I thought you would have understood that I mean that they have the same functionality and style but they don't have the same color.
Regarding the animation that doesn't need to change, it is meant to bring awareness to the editor that it has those handles that can be interacted with.

@ichim-david I apologise for not fully understanding what you said.
from my understanding I need to adjust the sidebar's accessibility. but sidebar accessibility is already set.

@Noobham as you said, you have already addressed the aria state toggle between open and closed, but I have not verified. I believe that @ichim-david wants only the opacity to be similar between the two button handles, for the toolbar and the sidebar, for their normal, hover, and clicked states. The color values would not change, and there would be no additional animation.
Also please note that you need to merge main into your branch and resolve the merge conflicts, as the GitHub UI in this issue indicates, then push your commits to your branch. See Update your pull request from your fork.

Closing pull request as it's abandoned, last feedback was not taken into consideration and the logic for expanded is incorrect it should be inverted as seen from the test snapshot output.


[BUG] ISM force_merge on datastream index

What is the bug?
On Opensearch 2.16.0
I have created ISM policy, with force_merge step to force to have one segment after the datastream index has rolled out and move to warm node. The step always finished on timeout.
After put ISM log level to DEBUG, I get the following logs:
{"type": "json_logger", "timestamp": "2024-09-16T14:04:13,248Z", "level": "DEBUG", "component": "o.o.i.i.s.f.WaitForForceMergeStep", "cluster.name": "logmanagement2-rec", "node.name": "opensearch-data-os-2", "message": "Force merge still running on [.ds-logs-log-default-000617] with [2] shards containing unmerged segments", "cluster.uuid": "ZbghcuYqTtWRmCHMd4tbyw", "node.id": "cYyrcay5QPS7_zi0HxvyJg"  }

How can one reproduce the bug?

Create new Opensearch cluster with hot and warm tiers
Create Index template to allow create datastream index

{
  "index_patterns": [
    "logs-*"
  ],
  "priority": "500",
  "data_stream": {
    "timestamp_field": {
      "name": "@timestamp"
    }
  },
  "name": "template_log",
  "template": {}
}

Create datastream index logs-log-default
Create ISM policy

{
    "id": "policy-log",
    "seqNo": 2848481,
    "primaryTerm": 23,
    "policy": {
        "policy_id": "policy-log",
        "description": "Policy for logs index",
        "last_updated_time":<PHONE_NUMBER>454,
        "schema_version": 21,
        "error_notification": null,
        "default_state": "hot",
        "states": [
            {
                "name": "hot",
                "actions": [
                    {
                        "retry": {
                            "count": 3,
                            "backoff": "exponential",
                            "delay": "1m"
                        },
                        "rollover": {
                            "min_index_age": "1d",
                            "min_primary_shard_size": "5gb",
                            "copy_alias": false
                        }
                    }
                ],
                "transitions": [
                    {
                        "state_name": "warm",
                        "conditions": {
                            "min_index_age": "1d"
                        }
                    }
                ]
            },
            {
                "name": "warm",
                "actions": [
                    {
                        "retry": {
                            "count": 3,
                            "backoff": "exponential",
                            "delay": "1m"
                        },
                        "read_only": {}
                    },
                    {
                        "retry": {
                            "count": 3,
                            "backoff": "exponential",
                            "delay": "1m"
                        },
                        "allocation": {
                            "require": {
                                "temp": "warm"
                            },
                            "include": {},
                            "exclude": {},
                            "wait_for": false
                        }
                    },
                    {
                        "retry": {
                            "count": 3,
                            "backoff": "exponential",
                            "delay": "1m"
                        },
                        "index_priority": {
                            "priority": 50
                        }
                    },
                    {
                        "timeout": "1d",
                        "retry": {
                            "count": 3,
                            "backoff": "exponential",
                            "delay": "1m"
                        },
                        "force_merge": {
                            "max_num_segments": 1
                        }
                    }
                ],
                "transitions": [
                    {
                        "state_name": "delete",
                        "conditions": {
                            "min_index_age": "2d"
                        }
                    }
                ]
            },
            {
                "name": "delete",
                "actions": [
                    {
                        "retry": {
                            "count": 3,
                            "backoff": "exponential",
                            "delay": "1m"
                        },
                        "delete": {}
                    }
                ],
                "transitions": []
            }
        ],
        "ism_template": [
            {
                "index_patterns": [
                    "logs-log-*"
                ],
                "priority": 100,
                "last_updated_time":<PHONE_NUMBER>454
            }
        ]
    }
}

Wait Force merge step. The force_merge step always in timeout.
What is the expected behavior?
Force merge run successfully on get one segment per shard.
What is your host/environment?
Opensearch 2.16.0

I think the force_merge setp must be estimate the target size to look if there are sufficious space on node.
And in all case, the setp must be failed because node space left on device instead to failed with Action time out

@disaster37 did you try explain API to get the information on the policy failure ?

[Catch All Triage - 1, 2,  3,  4]


Using Json4sSupport trait with a RejectionHandler.builder()

Happy Holidays everyone! :)
probably a basic scala question rather than akka-http-json specific...but i'm trying to use this with a RejectionHandler and i don't know of an elegant way to use Json4sSupport or if it's even possible.  Would like to have some guidance.
thanks!

Not an issue. For questions please use Gitter.


unstable display behavior of the current month

export const DateTimePicker = () => {
  const [date, setDate] = useState(new Date());
  useStyles();

  return (
    <Flatpickr
      data-enable-time
      value={date}
      options={{
        prevArrow: "*",
        nextArrow: "*",
        // mode: "range",
        time_24hr: true,
        dateFormat: "d.m.Y H:i",
        locale: Russian
      }}
      onChange={() => {
        setDate(date);
      }}
    />
  );
};

I connect react-flatpickr 3.9.0  to codesandbox, and month information is displayed in the span tag (expected beh
avior).

However, if I transfer this code to a local project (based on the Create React App), the month is displayed as a list.

Which of the component's behaviors is correct? Can you set options to control the display of the month (month name or list of months)?

I believe the difference is due to the version of flatpickr (not react-flatpickr) being used in each project.
Looks like the select-based version was released in flatpickr 4.6.0, feel free to lock the version used in your project to whichever version you like by running npm install<EMAIL_ADDRESS>for example.
Closing because I don't think this is a related to this wrapper component in particular, but feel free to write back.

@jacobmischka Probably you did not understand me correctly. in the local project and on codesandbox, exactly the same code and the same dependencies with the same versions are used. It is strange to see this behavior of the same code.

I believe I did. While your version of react-flatpickr may have been the same, I am betting that your version of flatpickr itself was not. As a nested dependency, without manually locking it to a specific version or using a lockfile its version can change.
This library (react-flatpickr) has<EMAIL_ADDRESS>as a dependency. Thus, versions of the underlying flatpickr library may change without changing the version of react-flatpickr.

the problem is solved by one line, if you use yarn
  "resolutions": {
    "react-flatpickr/flatpickr": "4.5.7"
  }


Do not select token when Add to bond

Describe the bug
Version test: v1.0.15(211)
To reproduce the bug
Steps:

Go to the Add to Bond screen (All account)
Perform Import account successfully
Re-open Add to bond screen and observe the displayed screen

Actual: Do not select token
https://drive.google.com/file/d/15Awga5Ucy9AdtiyXIyYU4mRHFonVICeQ/view?usp=drive_link

Version test: v1.1.0(220)
Device test: IP 11
Can't reproduce this issue on the newest version
-> Close issue


Allows use of tspans with transitions along a path

@gka
This should allow for the tspan values to update when for example transitioning along a path a la Mike Bostock's example http://bl.ocks.org/mbostock/3902569.

I don't think the tspans code needs to be modified for this to work - try saving a reference to the text element and translating it.


Space Explorer - Projectiles Tutorial

Step 2 - there are no instructions/actions to do in this step.  Can we keep all the context-setting information in the first pop-up dialog?

Step 7 - Add another "Congratulations, you finished!" step at the end of this tutorial

Changing in both repos
https://github.com/microsoft/pxt-skillmap-sample/pull/48


Update to EFCore.BulkExtensions v3.2.4 breaks a self-contained .NET Core 3.1 ServiceFabric service

I have a ServiceFabric service, which is running the latest .NET Core 3.1. I published & deploy it as self-contained. It references EFCore.BulkExtensions. For version 3.1.4 everything worked great, but after update to version 3.2.4, there is an error during deployment on service fabric:
There was an error during CodePackage activation. The process/container terminated with exit code:2147516556.
After research, I found out that there is a problem with Microsoft.Data.SqlClient version (update from v1 to v2).
It is known issue for Microsoft.Data.SqlClient v2 SqlClient issue
Fix is still not ready. The temporary solution is to use EFCore.BulkExtensions v3.1.4

Thx for info.
At the moment, as you have suggested, the older version can be used.
Hope they will fix it soon so we can update to newer version.
If not we could downgrade that package until it gets solved.

Latest version 3.3.6 of the Bulk library is now referencing 2.1.2 Microsoft.Data.SqlClient


llvmPackages_13.lld: add postPatch to fix Darwin build

Motivation for this change
This allows building emscripten on Darwin, and thus ghcjs.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139043 at d32e0e6b run on aarch64-linux 1

7 packages failed to build:

chromium
fast-cli
foo-yc20
kapitonov-plugins-pack
puppeteer-cli
purePackages.faust
ungoogled-chromium

14 packages built successfully:

emscripten
faust (faust2)
faust2alqt
faust2alsa
faust2csound
faust2firefox
faust2jack
faust2jackrust
faust2jaqt
faust2ladspa
faust2lv2
faustPhysicalModeling
faustStk
lld_13 (llvmPackages_13.lld)

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


AABB boxes do not move with the animation

I cant find any issues already reported on this and im not sure if this is an intended behavior
Godot version:
3.0.6 from steam
OS/device including version:
Ubuntu 18.04
Issue description:
bounding boxes do not move along the animation

and because of that when boxes are off the screen meshes are hidden even if you actually could see them or rather where they are supposed to be, that happens in both editor and ingame

Steps to reproduce:
i just imported a model with a bunch of separate meshes for different parts of it
Minimal reproduction project:
if needed i could provide my model for testing

Can anyone still reproduce this bug in Godot 3.2.2 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


Add ability to set target on buttons

If I use this type, I am not able to set the link to be opened in another tab/window.
I believe this would be an easy fix, are you open for a community contribution on this?

It could be great to have a contribution for that of course :D
If you change the template for the target _blank.
Don't forget to add rel="noopener noreferrer".
See : https://stackoverflow.com/a/50709724

@maximehuran I felt lucky and submitted a PR. let me know what you think.


2 new API endpoints to IndexUpdater: create_embs_and_doclens and update_searcher

create_embs_and_doclens - Create embeddings and doclens for new  passages, with option to persist to disk.
update_searcher - Update the searcher with the said embeddings and doclens.

This is to support the following workflow:

To add new passages, call create_embs_and_doclens on the GPU. Set persist argument to True.
Pull the persisted embeddings and doclens files and upload to elsewhere.
Have another application call update_searcher, with the files from step 2 as input. This will allow to insert new embeddings into an index that had been loaded in memory.

This looks good to me, but I was not involved in building this component so I'm likely missing something. @santhnm2 and @narnix-gnos, do you have thoughts?
@jessiejuachon Do you want to think about adding handling for the workflow where the number of documents is too small or is grown too much for the current approach? I remember we had a rich discussion around that

Anyway, looks good to merge from my end

This looks good to me, but I was not involved in building this component so I'm likely missing something. @santhnm2 and @narnix-gnos, do you have thoughts?
@jessiejuachon Do you want to think about adding handling for the workflow where the number of documents is too small or is grown too much for the current approach? I remember we had a rich discussion around that

Thanks! Will wait for @santhnm2 / @narnix-gnos .
Yes, that is something that can be looked at after this merge request!

LGTM, but are any changes required for this test? https://github.com/stanford-futuredata/ColBERT/blob/main/colbert/tests/index_updater_test.py

I believe there should be no change in the test. In this PR, there is no change in the code logic of the add function. The only change is instead of the add function containing all of its original code, it now calls 2 new functions: create_embs_and_doclens and update_searcher.


Pictogram Full Screen Button

Add pictogram full-screen button like this screen shot.

Share SVG file of button
Group 8.svg.zip


Ability to move file explorer like editor window

I would love to be able to move the file explorer like a regular window as it would open up a ton of customizability like having the terminal under the file explorer which I would prefer to have on my laptop as it has a smaller screen and any saved space is good.

It's not clear to me what you mean by "regular window", though you can drag and drop the terminal to be under the explorer:


Use single focus trap at app root for all hotkeys

would allow avoiding code like this https://github.com/thomasboyt/bipp/blob/eeb461b032e879c1a5b033194f91d527ac455691/app/views/Attract/Handler.js#L14
or this https://github.com/thomasboyt/bipp/blob/f4301506d7558480f6237584906e685bf36db024/app/views/lib/PlaybackWrapper.js#L25
or this https://github.com/thomasboyt/bipp/blob/eeb461b032e879c1a5b033194f91d527ac455691/app/views/Player/states/Loaded.js#L26
etc

https://github.com/Chrisui/react-hotkeys/issues/12 is promising in this regard

react-hotkeys has an attach prop to specify DOM element to listen on: https://github.com/Chrisui/react-hotkeys/blob/master/lib/HotKeys.js#L54-L62
unclear if mousetrap supports multiple instances bound to the same element


opset specialization

Does opset downgrading work well enough to export as the current opset and then downgrade with ONNX tools rather than attempting to make ops know how to behave as different opsets?

Can use schema to generate functions for different opsets.


⚠ Bofrost.at has degraded performance

In 2946820, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2399 ms

Resolved: Bofrost.at performance has improved in 5d4312d.


[Linux Controller] Support control from linux

Problem
<what's wrong or missing, please include any applicable:

expected behavior
actual behavior
steps to reproduce
system configuration
screenshots, images, logs, etc.

Proposed Solution
<suggested fix, suggested enhancement>

This issue is already tracked in the Linux Platform Layer project. Closing.


Replace deprecated command with environment file

This PR replaces the deprecated command set-output with new environment file before it gets disabled.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The branch should start with misc so we don't bump the version.

The branch should start with misc so we don't bump the version.

It should be bumped because Golang has been updated to 1.20


Add Details and Update the horror page UI

Related Issue
This PR is raised again for the changes in the PR #4420
Description
PR #4420
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[X]I have made this change from my own.
[X] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@abhi03ruchi Please review these changes so that I can make them for the other pages.

keep the heading like this . also fix the spacing b/w the heading and the cards .

hey @abhi03ruchi udpated the styling, please check

@abhi03ruchi Please review these changes so that I can make them for the other pages.

on classic literature page , another contributor is working . u can do other pages first . and add details to that page at last.

@abhi03ruchi Iwill do that

i have reverted ur changes . u changed assets/html/top10.html also due to which quizzes ( a feature added by a contributor) were deleted .
commit only those changes that are related to ur issue .
raise new pr for horror page .


[Suggestion] Cross dimensional access to the network

Would be awesome if there was a way to access the network directly, cross dimensionally.(multi block structure maybe? I loved AE2's implementation of that)

nope that is OP imo


8511 fix positions display

Clubhouse Story
Submitter checklist

[ ] Test covering functionality added/fixed in
Check the linked story includes the following:

[ ] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass
[ ] Post merge, story marked complete

Note: this is branched off of 2304-rollback, so that PR should be merged before this one!

Cherry-picked relevant commits here: https://github.com/AugurProject/augur/pull/1342


Remove implicit finishing of the archive if Builder is dropped.

For a few reasons:

This allows removing the 'static requirement on the writer.

There was no way to abort writing the archive without writing the termination sections. If an error happens while building the archive, it's probably best to not write the termination sections, so that the incomplete archive doesn't look complete.

Writing the termination sections in a separate task made it indeterminate when exactly it happened. It could happen long after the Builder was dropped.

Writing the termination sections on drop made sense in the original sync 'tar' crate, where it was more well-defined, but in async world it's better to require the programmer to be explicit about finishing it.
This is an incompatible change, if your application doesn't call finish or into_inner explicitly.

This PR does the same as https://github.com/vorot93/tokio-tar/pull/17 , but also changes the way things worked by default — with the new library version, old code stops adding a termination to builder implicitly.
Might not be a good thing to do right now, I'd start with backward-compatible approach from https://github.com/vorot93/tokio-tar/pull/17 first


AoT Compatibility

As initially mentioned in #58, this package is not compatible with AoT compiler, at least the angular-cli AoT loader, specifically with the error Unexpected value 'Ng2AutoCompleteModule' imported by the module 'AppModule'.
Looks like something related to publish a metadata.json file generated by the angular compiler, as mentioned in angular/angular#11262.
I'll add a PR for this when I start having some results.

oh well... After 3 small nights fighting on the compilers and webpack, I think I got it. I'll be posting the PR now.

PR is merged


Incomplete display with Tex

I have tried to generate a simple text using Tex, but the text keeps cutting off from the end. I have tried removing the last part of color map "Paper 1: TEAL" and it seemed to work fine. I also tried with some other text samples and they worked perfectly as well, I think this text triggered some edge case due to which it does not get rendered properly.
Code:

from manim import *

class MainScene(Scene):
    def construct(self):
        intro1 = Tex(r"""This is the series of videos where we are going to discuss\\ selected but challenging problems of JEE (Adv.)
                            2020\\Paper 1. In this series there are total 8 problems, and\\we shall discuss one problem in each video. We
                            shall\\upload videos on consecutive days today onwards at 3\\PM IST. Stay tuned with us.""",
                            tex_to_color_map={"JEE (Adv.) 2020":TEAL, "challenging": ORANGE, "selected": BLUE, "tuned":RED, "Paper 1":
                            TEAL}, tex_environment = "flushleft", stroke_width=1.5)
        intro1.width = config.frame_width-0.5
        self.play(Write(intro1), run_time=1)
        self.wait(4)
        self.play(FadeOut(intro1))
        self.wait(0.1)

Wrong display: As you can see, the text gets cut off from the end. Sometimes it displays some more characters than this, but there are always few missing characters.

Additional context

I am using Manim Community v0.9.0.

It seems that you are using the community version of manim, so you'd better ask this question in their discord channel or open an issue in ManimCommunity/manim instead of here.


Keras on_epoch_end() callback output happens BEFORE completion of epoch output with verbose=1

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): modified TF example code
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab and Win10
TensorFlow version (use command below): 2.3.0

Describe the current behavior
when training Model using Model.fit() with verbose=1 (for progress bar) and keras.callbacks.Callback() with on_epoch_end() function I observe that callback output happens BEFORE completion of the epoch progress output, like this:
Epoch 1/2
 63/125 [==============>...............] - ETA: 0s - loss: 43.2549 - mean_absolute_error: 4.6003
CALLBACK MESSAGE ON END EPOCH 0
125/125 [==============================] - 0s 794us/step - loss: 37.6690 - mean_absolute_error: 4.6575

Describe the expected behavior
callback output should happen AFTER completion of the epoch progress output:
Epoch 1/2
125/125 [==============================] - 0s 900us/step - loss: 36.9897 - mean_absolute_error: 4.8264
CALLBACK MESSAGE ON END EPOCH 0

Standalone code to reproduce the issue
see gist here

The print is before the end cause you have the weight update step.
Check this https://github.com/tensorflow/tensorflow/issues/29964#issuecomment-505498333 and follow-up comments.
I suppose that if there is something missing or that you want to better notify to developers you can open a small documentation PR on these lines https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/engine/training.py#L858:L862

So if you see it is after validation and before the training end https://github.com/tensorflow/tensorflow/blob/v2.3.0/tensorflow/python/keras/engine/training.py#L1135-L1145

@bnack, thank you for the replies, but I am not quite getting it. From the code of Model.fit() I see that the callback is only called at the VERY END of epoch. So why is callback output happening BEFORE the output of the last few batches? Could you please explain?
I also noticed that this problem is absent when batch training time is much greater. Could it be the case that batch output and callback output are done in parallel and the batch output gets delayed somehow?

I'd like to propose a simple commit to make the standard ProgbarLogger come first in the list of callbacks. It requires changing this line  from self.callbacks.append(self._progbar) to self.callbacks.insert(0, self._progbar)
Which TF branch shall I commit to?

Yes PR are on master. I don't remeber the logic about why the are appended. You can try to collect feedbacks on the PR

just made pull request

@poedator,
Looks like the issue has been fixed.
On running the code with the latest TF-nightly, I got the expected output. Please find the gist of it here. Thanks!

Thanks, guys! This is my first PR merged into a major project.


Exemptions on 'spaces around keywords' rule

The wait(foo); is a complete statement in itself and should not be
following this rule. Instead it is better aligned with the 'functions
and task calls' rule.
Signed-off-by: Srikrishna Iyer<EMAIL_ADDRESS>

Let's take a quick vote on this and go with the majority team's recommendation. I filed #55 to solidify this.


Visualization of attention mechanism

Hello author, can you provide the code of attention visualization in the paper，

You can either refer to previous issues or this code for more details.


Add mattermost wiki

1. Create Mattermost Bot

Install mmctl
Go to mmct
Create bot

2. Create channel

Create channel using mmctl Channel
Run mmctl channel search to find Channel ID
Create a group and add bot to this group

3. Add bot to channel

Invite bot as member
copy bot token

3. Edit config.json
{
  "base": {
    "logo": "",
    "project": "",
    "environment": "",
    "comment": "",
    "reportLink": "",
    "language": "ru",
    "messenger": "mattermost",
    "allureFolder": "",
    "enableChart": false
  },
  "mattermost": {
    "url": "mm.<team>.com",
    "token": "<bot_token>",
    "chat": "<Channel_ID>"
  }
}

Run allure notification

java \
  "-DconfigFile=${PATH_TO_CONFIG_JSON}" \
  -jar allure-notifications-4.1.jar

@svasenkov

@valfirst кто Wiki для MM обновить может?

@valfirst кто Wiki для MM обновить может?

not me :)
PS: my personal would be to follow "documentation as a code" approach and move everything from GitHub wiki to README.md as a first step (in future GitHub pages could be considered for hosting a generated documentation website if necessary)

@valfirst кто Wiki для MM обновить может?

not me :)
PS: my personal would be to follow "documentation as a code" approach and move everything from GitHub wiki to README.md as a first step (in future GitHub pages could be considered for hosting a generated documentation website if necessary)

Good idea

@svasenkov кто может вмержить в wiki?

Wait, please


New firmware 1.28.100555 adds field 'launchedFromCloud' to Application

Hello,
my ChromeCasts got a firmware update to version 1.28.100555 today,
and i couldn't get the device status anymore, because a new field "launchedFromCloud" was added to the Application object.
I will create a pull request where i have added the field and a test for the new status response.
I don't know anything about newer features of the Cast stuff, so i don't where the field is coming from.

I have just released new version with changes from your PR. I believe it should become available in Maven Central today.
Thank you very much for helping fixing this bug.

Glad i could help!


build-init should consistently offer Kotlin as the default DSL for all project types

Expected Behavior
When I run the init task I expect the defaults will be the same in the respective steps.
Current Behavior
Kotlin is used consistently for build script DSL, except when Groovy is selected for the implementation language.
Context (optional)
An example, unexpected output:
$ gradle init

Select type of project to generate:
  1: basic
  2: application
  3: library
  4: Gradle plugin
Enter selection (default: basic) [1..4] 4

Select implementation language:
  1: Groovy
  2: Java
  3: Kotlin
Enter selection (default: Java) [1..3] 1

Select build script DSL:
  1: Kotlin
  2: Groovy
Enter selection (default: Groovy) [1..2]

Steps to Reproduce
Run gradle init with various input.
Gradle version
8.2-20230427234156+0000
Build scan URL (optional)
No response
Your Environment (optional)
No response

My personal opinion on that one is that defaulting to the Groovy DSL for a Groovy based project makes sense.
It would be a good short poll for the community Slack to see what the community thinks of this.


MAXITER = 0 as Special Case

When setting maxiter to zero for either optimizer I get the following message. Please add an explicit regression tests which runs this special case.
test.grmpy.txt
Traceback (most recent call last):
File "run.py", line 15, in
grmpy.estimate('test.grmpy.ini')
File "../../grmpy/estimate/estimate.py", line 47, in estimate
print_logfile(dict_, rslt)
File "../../grmpy/estimate/estimate_auxiliary.py", line 217, in print_logfile
file_.write(fmt.format('', section + ':', rslt[section.lower()]))
KeyError: 'warning'

Are there any problems in adressing this issue or did you just not get to it yet? Let me know if you need any help ...

I added a test in test_integration.py.


feat(chart): Added annotation: to api.service and default api.service.annotations value to values.yaml

Added a section to charts/kargo/templates/api/service.yaml to add 0 to many annotations to the api service.
When hosting Kargo in a managed K8s system, in this case AKS, an annotation can be added to create an internal or externally facing managed azure load balancer for ingress.

Hi @ed-boykin. Thanks for this!
I understand your need, but want to suggest a more general-purpose approach to this so that arbitrary annotations can be added to any/all Kargo pods, as there may be reasons beyond those you are encountering to do such a thing.
If I may suggest, @MPritsch has taken a very nice approach to doing something similar for adding arbitrary env vars to any/all Kargo pods over in #1874.
If you could emulate that approach, I think this would be something we could get into v0.6.0.
Thanks again!

Thank you @ed-boykin!


UserWarning: None of the inputs have requires_grad=True. Gradients will be None

学习率为零，后面的chosen和rejected全为none

Could not estimate the number of tokens of the input, floating-point operations will not be computed

use float32.


gdb debugger allocatable arrays not shown

Hi,
I'm using the gdb debugger with gfortran with vscode on windows.
As compiler args I only used -ggdb -Wall
Here allocatable arrays are not shown correctly in the debugger.
To be more exact: There is always just a [0]
The program itself works fine.
I can print the allocated array.
I'm not sure were this problem is located: gdb, gfortran or vs code extension
But I can't find a workaround.

In launch.json I use the default setting.
Here little test program:
program horst

    implicit none

    integer :: n, n_max
    integer, dimension(4)              :: n_sqrt
    integer, dimension(:), allocatable :: n_sqrt_alloc

    n = 1
    n_max = 4
    allocate(n_sqrt_alloc(n_max))

    do n=1, n_max
        n_sqrt(n) = n**2
        n_sqrt_alloc(n) = n**2
    end do

    write(*,'(A,4(I3))') 'not allocatable:',n_sqrt
    write(*,'(A,4(I3))') 'allocatable:',n_sqrt_alloc

    write(*,*) 'works fine, but not in the debugger'

end program horst

My guess would be that your binary might be out of date and GDB is struggling to associate it with your later modified source file.
Make sure that the binary you are debugging reflects your latest source file, i.e. you haven't modified your .f90 after compilation.
To automate that you can create a build task tasks.json that will be calling your build system whatever that is.
Here is an example that calls make -j, you can substitute that with a sh ./build.sh or gfortran -g -Wall horst.f90.
The you can call the build task through VS Code.
{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
  "tasks": [
    {
      "label": "compile",
      "type": "shell",
      "command": "make",
      "args": [
        "-j"
      ],
      "presentation": {
        "echo": true,
        "reveal": "always",
        "focus": false,
        "panel": "shared"
      },
      "group": {
        "kind": "build",
        "isDefault": true
      },
      "problemMatcher": [
        "$gcc"
      ],
    },
  ]
}

Could you give that a try and let me know how it goes?
FYI
I tried the example that you posted and it seems to work okay

Thanks for the fast response.
But unfortunately this doesn't solve it.
This was exactly what I tried my times.
Used a build.sh or direct in terminal gfortran -g -Wall. Deleted all files. All results in the same probelm.
I also tried it on another windows machine with the same MinGW installed on it.... Same Problem

I installed another MinGW Version.
Now it works.
Sorry for the confusion.


flterm: Remove C++ dependency, reduce runtime deps

flterm is written in C, it does not need a C++ compiler installed.
Also, listing strict build time dependencies as runtime dependencies
(a) drags in a lot of stuff, and (b) causes weird end user upgrade
dependencies, so remove that.
Difference in resulting dependencies is huge:
vagrant@conda:~/conda-hdmi2usb-packages$ diff /tmp/flterm.dep.before /tmp/flterm.dep.after
10c10
< {'c_compiler': 'gcc', 'cxx_compiler': 'gxx'}
---
> {'c_compiler': 'gcc'}
27a28
>         - gcc_linux-64 7.3.0 h553295d_6
29d29
<         - gxx_linux-64 7.3.0 h553295d_6
31,33d30
<         - gcc_linux-64 7.3.0 h553295d_6
<         - gxx_impl_linux-64 7.3.0 hdf63c60_1
<         - libgcc-ng 8.2.0 hdf63c60_1
34a32
>         - libgcc-ng 8.2.0 hdf63c60_1
37d34
<         - libstdcxx-ng 8.2.0 hdf63c60_1
39,46c36
<         - binutils_impl_linux-64 2.31.1 h6176602_1
<         - libstdcxx-ng 8.2.0 hdf63c60_1
<         - gxx_linux-64 7.3.0 h553295d_6
<         - gcc_impl_linux-64 7.3.0 habb00fd_1
<         - libgcc-ng 8.2.0 hdf63c60_1
<         - gcc_linux-64 7.3.0 h553295d_6
<         - gxx_impl_linux-64 7.3.0 hdf63c60_1
<         - binutils_linux-64 2.31.1 h6176602_6
---
>         - libgcc-ng >=7.3.0
vagrant@conda:~/conda-hdmi2usb-packages$

and in particular looks like it avoids dragging in the binutils dependency on which the Conda C compiler was built, which we have no need to depend on at runtime.  (Most of the volume reduction in build dependencies is from not depending on C++ compiler at all.)
At minimum this gets us closer to conda update --all not wanting to downgrade lots of stuff to upgrade binutils.  (And maybe we need to do something similar with our -newlib builds too?)
Ewen

FTR, I think we probably also want to simplify gcc/newlib dependencies in the same way:
https://github.com/timvideos/litex-buildenv/issues/123#issuecomment-468087905
https://github.com/timvideos/litex-buildenv/issues/123#issuecomment-468089963
and I'm testing building with that change (for lm32) in my Vagrant VM now.  If it builds okay here, I'll create another pull request for that.  I'd suggest we merge both at the same time, and maybe try to have it as one Travis build...
Ewen


Height of drawer is not full

I am getting this, but height is not full:

This is my setup:

On initial VC:
Class: KYDrawerController
Module: KYDrawerController
Attributes
mainSegueIdentifier: main
drawerSegueIdentifier: drawer
Everithing works but this height.
What can be problem here?

@mirzadelic Hi! Please try this sample to the reference
Sample.zip


TOC create and update not working

What is the problem?
Creating or updating existing TOC blocks in markdown files doesn't work.  Upon executing the command, nothing happens.
Is there any error message in the console?
no messages in devtools

All TOC functionalities are broken in the latest vscode insider build... That's caused by the internal changes of the vscode built-in markdown extension. I need to think about removing the dependency on it...

Is there any chance of creating an independent extension, with just TOC functionality?  I have tried other extensions however, yours has the best TOC features by far.

There are two things

Dependency on the vscode built-in extension. It's relatively a big change, and will take some time given that I don't have enough time now.
Only the TOC features. This is easy but I guess it is not necessary...

For now, I would suggest opting out from the vscode insider channel so that the TOC features can work well.

Interesting Microsoft/vscode@281f242cfff7231515eeb3ef195bb237ae3182db added githubSlugifier. Nothing in the history was removed just refactored right? Would it make sense to separate TocProvider that switches APIs and throws errors next time the data shape changes?

This should be fixed with the development build.

Working!

Broke again.
Activating extension 'yzhang.markdown-all-in-one' failed: Cannot find module '/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/markdown-language-features/out/tableOfContentsProvider'.

After taking a look at the latest build of vscode, I find we can no longer "import"/reuse vscode's codes, completely.
A good thing is that I realise this dependency is not necessary anymore. (We no longer need to contribute to outline view (TOC) since vscode takes it over.)
I can even expect a better performance by removing this dependency. The only problem is I might not have time in the near future. If someone is interested, here is the only method we need to implement by ourselves
https://github.com/neilsustc/vscode-markdown/blob/1c1272202c115c29a27fc1d637aa5eb67e97fa3d/src/toc.ts#L230

I changed my mind. It breaks the whole extension 😂.
Fixed with v1.6.2.

Verified!

I get following message when trying to create / update TOC in v1.6.2 and VS Code 1.28.0:
Cannot read property '1' of null

@mprasil Could you please provide more context (e.g. your Markdown content, more detailed error message)? No one can reproduce a problem with just the error message...

Apologies for missing the details, I was in a bit of a hurry and wanted to get to this issue next day. To be specific, I was working on this specific file. You just need to remove the TOC there as that was later added by another TOC plugin.
It appears that the functionality broke as I updated to latest VS Code release.
As for the error message, unfortunately this popup is the only thing I can see:

There's no message in the debug console or anywhere else. I'm not familiar with debugging VS Code plugins, so if there's something I can do to get some more info, let me know.

@mprasil Many thanks! I can reproduce now. The problem is the #.drone.yml in the code block is wrongly treated to be a heading.
And it is fixed now. Download the dev build here.

I can verify that the fixed version works fine. Thanks!

closing this, original problem reported fixed.  Thank you @neilsustc 👍


Cannot add target="_blank" attribute to  within

How can we reproduce this bug?
<menu><item href="http://www.address.com/" target="_blank"></item></menu>
What did you expect to happen?
The hyperlink within the 'item' component to contain the target="_blank" attribute, so that links clicked by users via a web email client are guaranteed to open in a new tab/window, no matter the client's default action. This doesn't need to apply by default, but ideally we should have the option to include it.
What happened instead?
The hyperlink does not include the target="_blank" attribute.
What email clients does this happen in?
All inlined HTML, ergo all web clients.
This is a similar issue to #432 though that applies to 'button' Inky elements rather than 'item' ones.

Looks like the PR that solves this for buttons can be easily extended to menu items - https://github.com/zurb/inky/pull/42 Is that something you can help with?

Awesome PR by @ClementParis016 https://github.com/zurb/inky/pull/54

Thanks, I'm glad to contribute to this nice project :)


OSASINFRA-3681: improve the doc on OpenStack

What this PR does / why we need it:
Improve the doc on OpenStack.
/hold

I hold it for now because we planned to add more content (e.g. NFV, etcd on local disk).

Hey @EmilienM I think we need to adjust the e2e-openstack-aws to be triggered only when the PR is not a documentation one. WDYT?

Hey @EmilienM I think we need to adjust the e2e-openstack-aws to be triggered only when the PR is not a documentation one. WDYT?

that is wrong and I had that on my list for today. I'll ping you with a fix.

/test

/test

/test images

/hold cancel
this is ready for review @MaysaMacedo @stephenfin @mandre

/lgtm


WIP: Added the ability to toggle autosaving on and off

Autosaving is now disabled by default and toggleable in the settings.

When autosave is disabled, the save function just doesn't get called when the time goes off
When the autosave toggle is pressed, the autosave file is immediately saved
The setting will also be saved in the manual save file. (this works for my use case, but we definitely want to move settings like this into their own save file)

This feature would be better suited for the System Settings feature which we are planning to add. It is better to separate system setings from saved profiles


CVEs in the library dependencies

I found your project used some dependencies that contain CVEs. I suggest updating their versions to increase the security of your project. See below for more details:

Vulnerable Library Version: org.codehaus.groovy : groovy-all : 2.3.9
CVE ID: CVE-2015-3253, CVE-2016-6814
Import Path: flyway-gradle-plugin/pom.xml
Suggested Safe Versions: 2.4.10, 2.4.11, 2.4.12, 2.4.13, 2.4.14, 2.4.15, 2.4.16, 2.4.17, 2.4.18, 2.4.8, 2.4.9, 2.5.0, 2.5.0-alpha-1, 2.5.0-beta-1, 2.5.0-beta-2, 2.5.0-beta-3, 2.5.0-rc-1, 2.5.0-rc-2, 2.5.0-rc-3, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.5, 2.5.6, 2.5.7, 2.5.8, 2.5.9, 2.6.0-alpha-1, 2.6.0-alpha-2, 2.6.0-alpha-3, 2.6.0-alpha-4, 3.0.0, 3.0.0-alpha-1, 3.0.0-alpha-2, 3.0.0-alpha-3, 3.0.0-alpha-4, 3.0.0-beta-1, 3.0.0-beta-2, 3.0.0-beta-3, 3.0.0-rc-1, 3.0.0-rc-2, 3.0.0-rc-3, 3.0.1
Vulnerable Library Version: org.codehaus.plexus : plexus-utils : 1.5.15
CVE ID: CVE-2017-1000487
Import Path: flyway-maven-plugin/pom.xml
Suggested Safe Versions: 3.0.16, 3.0.17, 3.0.18, 3.0.19, 3.0.20, 3.0.21, 3.0.22, 3.0.23, 3.0.24, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0

Thanks for drawing our attention to this. Looks like we'll need to take a major version update for plexus-utils. Ideally we'll push this out in 6.3. However if we need to make breaking changes to accommodate our dependency updates we'll push it back further.


A glittering gem jumps both ways

We have a dependency conflict with the astrolabe gem. Unfortunately, the
maintainer is not currently accepting pull requests.
Therefore, bring the needed code from astrolabe directly into rubocop.
This will also make it easy for us to adjust the naming of some methods to
improve code readability. This can be done a bit later.

:+1:


update to build with go1.20

as title

Should build-backend-no-gcc be updated to 1.19 if we're bumping up min go version?

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@82728a7). Click here to learn what that means.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main   #22732   +/-   ##
=======================================
  Coverage        ?   47.19%
=======================================
  Files           ?     1106
  Lines           ?   148755
  Branches        ?        0
=======================================
  Hits            ?    70204
  Misses          ?    70188
  Partials        ?     8363

Impacted Files
Coverage Δ

models/db/sql_postgres_with_schema.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jolheiser ah good catch.

Bump min go version to 1.19 as well?

Why merge without answering my question?

Did it not get bumped? I think both places we have minGo got bumped, right?

@silverwind my apologies, I had missed your comment. GitHub mobile app is rather aggressive with hiding parts of PR threads. I thought I caught all places to bump min, but can send another apt to bump elsewhere.


Polish translation for Flopp's map

Hi @flopp !
I'm developer from opecaching-pl project. I want to solve https://github.com/opencaching/opencaching-pl/issues/332 and help in https://github.com/flopp/FloppsTolleKarte/issues/36
I prepared two files with polish translations. I have hope this is enough and now you can make required changes for provide polish language in your map ;]

Thank you very much!
I will look into it in the next days...

The polish translation is online. Thanks again!

Looks great.
Thank you :+1:


Fix Toggle space and Rotation Angle exceeding 360

Related to #892 and #891
Toggle space fix result

Rotation Angle exceeding 360 fix result

This does close those two issues, no? Why is it just related?