Overhaul library to support extensibility and better adhere to RFC 6749

NOTE: This is a breaking change that will require a major version bump.
As such, this diff bumps the next release version to 2.0.0-alpha.
This diff is a significant rewrite of the library that:

Adds extensibility to support arbitrary OAuth 2.0 extensions in the
future without having to break backward compatibility again. This is
primarily accomplished through traits and generics (Resolves #27).

Improves adherence to the OAuth 2.0 spec (RFC 6749):

Requires access token responses to be JSON-encoded, dropping support
for form-encoded responses. Also adds the HTTP request header
"Accept: application/json" to ensure that loosely compliant OAuth2
implementations such as GitHub's return a JSON response (Resolves #33).
Fixes the access token error response types enum to follow Section
5.2 of the spec instead of <IP_ADDRESS>, which is for the Implicit Grant
flow only. The Implicit Grant errors are only seen by the browser,
and not by client applications that would be using this library.
Fixes parsing of the "scope" token response field, which is a
space-delimited string instead of a JSON array of strings.
Removes the "state" field from the token error response, which is not
defined in Section 5.2 of the spec. This field is only returned by
earlier steps in the OAuth2 flows.
Only parses the access token response as an error if the client
receives a non-200 HTTP response code. Section 5.2 of the spec defines
the expected response code as 400 Bad Request.
Uses HTTP Basic Auth for client authentication by default, rather
than including the client_id and client_secret in the request body.
This matches the recommendation in Section 2.3.1 of the spec.

Slightly improves the usability of the library

Renames the main struct from Config to Client.
Makes the "state" parameter mandatory unless the "insecure" module is
used (Fixes #28). This is critical to protect clients against CSRF.
Improves the documentation to more closely refer to the spec.
Improves the examples to include CSRF protection.

Once this merges, I'll send out another PR for https://github.com/ramosbugs/oauth2-rs/tree/stronger_types, which replaces stringly typed fields with stronger typing.

From the other thread:

After thinking about this a bit more, I'm not sure it makes sense to take ownership of the state, since the client needs to keep it around in order to verify that it matches the state parameter passed in via the redirect URI. Any objections to passing in a reference instead?

Yeah, that makes sense to me.  That would eliminate a call to clone in the code using the API and it is possible that a future implementation could avoid the allocation.
I'm not sure it's worth the trouble, but an alternative API might be to take a closure that generates the random state and then returns a (url, state) tuple.  It would be more obvious that the consuming code is still expected to do something with it.  Or maybe the closure could be part of the Client struct so that the state generation code is defined along with the other configuration.

Great idea! Since I added a CsrfToken type in the stronger_types branch, I've been thinking of adding a factory method that creates a random one, but I don't think that should be the only interface since some callers may want to use a hash or some other value. So, a closure would work well here. I think it would make sense to leave it as an argument to authorize_url to help cases where people want to pass their own value. Otherwise, they'd have to update the Client each time, which was the issue with the 1.x implementation.
Then, I can mark CsrfToken as #[must_use] and return it from authorize_urlas you suggested. I'll go ahead and add that to the second branch.


importsNotUsedAsValues is not properly handled when using near-operation-file and custom hooks

Describe the bug
When using near-operation-file and apolloReactHooksImportFrom the import from @apollo/client does not use import type which causes an error when importsNotUsedAsValues is set to error
To Reproduce
Steps to reproduce the behavior:
Sandbox reproducing the behavior https://codesandbox.io/s/reverent-liskov-ctzvc?file=/document.generated.tsx:91-132

My GraphQL schema:

type Query {
    user(id: ID!): User!
}

type User {
    id: ID!
    username: String!
    email: String!
}

My GraphQL operations:

query user {
    user(id: 1) {
        id
        username
        email
    }
}

My codegen.yml config file:

schema: schema.graphql
generates:
  schema.ts:
    plugins:
        - typescript
  ./:
    documents: document.graphql
    preset: near-operation-file
    presetConfig:
      extension: .generated.tsx
      baseTypesPath: ./schema.ts
    plugins:
      - typescript-operations
      - typescript-react-apollo
    config:
      apolloReactHooksImportFrom: ./hooks.ts
      documentMode: external
      importDocumentNodeExternallyFrom: near-operation-file
      useTypeImports: true

Expected behavior
The line:
import * as Apollo from '@apollo/client';

should instead be:
import type * as Apollo from '@apollo/client';

because only types are being used from that import
Environment:

OS:
@graphql-codegen/...:
NodeJS:

Additional context

@mvestergaard Are you sure import type * as Apollo from '@apollo/client'; will work? Since it's not used as type only, but we are depending on the hooks coming from Apollo (which are functions).

@dotansimha That's what the whole thing is about. We're using the apolloReactHooksImportFrom, which results in the only thing being imported from @apollo/client is types

@SimenB I believe you looked at importsNotUsedAsValues related issues previously. Any idea for a quick way to fix this? I haven't looked at the code for this project for quite a while.

I'd look at the linked PRs to #3695, I don't remember any detail 😅

Alright, worth a shot. Might try to find a fix for this when I find the time.

Available in<EMAIL_ADDRESS>Thanks @mvestergaard !


Add bulk person search API

This adds a POST API endpoint for bulk person lookup by TRN & DOB. Up to 500 people can be requested in one go. The singular find by last name and DOB operation has been amended to return induction status, QTS and EYTS as well so that both operations have the same response structure.
In doing this I've also refactored some of the Get Person operation so that some its response types can be re-used. Some of the mapping logic has moved into those types too instead of being baked into specific API operations.
I've also made PreviousNameHelper a non-static class so we don't have to use IConfiguration directly in all the places it's called from.

 Bulk person search API for CTR


Parse commit messages and include urls to Github or Jira issues in a release.

If we find things like [DEV-123] or #123 or feenkcom/gtoolkit#123, we should create an url to the actual issues.

We won't address this at this time.


[#1405] Print warning message instead of failing the bootstrap when using Java prior 8u151

What changes were proposed in this pull request?
Print warning message instead of failing the bootstrap when using Java prior 8u151
Why are the changes needed?
Fix: #1405
Does this PR introduce any user-facing change?
Yes, users who want to use Java prior 8u151 to bootstrap Gravitino just get an error message instead of failing.
How was this patch tested?
Manually review

Hi, @pan3793 thank you for your contribution! Can you provide a short message about why we should use warn level message here?

The context indicates Java prior 8u151 has security issues.

The context indicates Java prior 8u151 has security issues.

Exactly, for this reason, we disable JAVA that before 8u151.

@yuqi1129 what's the principle of Gravitino to handle the security issues? For example, what if the user wants to use an EOL version HMS(has log4shell security issue) combined with Gravitino, Gravitino just rejects the connection?


Multiple Issues

I had added 15 Bots in Server.
when mp_auto_join_team was 1
All bots were in spectator teams. They Could'nt join CT/T.

Everytime there is 1 bot who stays in spec.

Bots are still camping and shift walking when
yb_camping_allowed "0"
yb_graph_fixcamp "0"
yb_walking_allowed "0"

Bots using other weapons where I have only enabled deagle,ak,m4,awp
yb_restricted_weapons "usp;glock;p228;elite;fn57;m3;xm1014;mp5;tmp;p90;mac10;ump45;galil;famas;sg552;aug;scout;g3sg1;sg550;m249;flash;sgren;defuser;shield"

Compiled tweaked rehlds from
https://git.stx.su/ds/rehlds-fbs/commit/75c055267c7d5c0ac49bd2ced82922251249d6be
So that BOTs can get Nonsteam/Valveid
But its not working

In server browser total player count is = bot in spec + actual Players.
Other bots who have joined team aren't showing in Server Browser.
yb_enable_query_hook "1"

BOTs dont have their own Playtime? Like If I change Bot quota from 15 to 20 in middle, the new bots joined also have the same time as the old ones

When a BOT is kicked from console, The new BOT which Joins in place of that has the same playtime

one problem = one issue.


Add logging of user actions to file

Then those actions can be used for automatic replay or as a base for #5.

Not important enough now.


Job_Failed Custom Event/Telemetry

Hi Team,
In order to track job health, we'd like to request a Job_Failed event. This event would be fired off anytime a single task failed. Ideally it would include job_id info, as well as it's sub-task ids (and/or which task failed).
If this is something your team believes that we can take care of ourselves, please let us know and we will reach out for guidance.
Please reach out if there are any questions.
Thanks!

A Job at it's core, is just an easy way to refer to a collection of tasks.  OneFuzz does not have a concept of jobs failing, only tasks.
The built-in libfuzzer simple template maps the set of tasks for a single libfuzzer target into a single job.  However, this mapping is not a requirement.  We have users that appear to use the job to indicate all of the targets for a given application (think Edge, which has hundreds of libfuzzer targets for the Edge application).
To your request, when a task fails, it generates a task_failed event, which includes the job_id ,task_id, and the full task config (which indicates the type of task).  Does this meet your needs?

I believe it does, and thank you for the clarification. I think my needs will be met by just tracking failed tasks, and I can link those to individual jobs because we now include job ids.
My only question is - does a failed task == (essentially) a failed job. Apologies if I am still misunderstanding something.

Example, if we have a libFuzzer target where the coverage extraction fails, but fuzzing and crash reporting can still be successful and valuable.

I see... so what task would we want to alert a failed job on? Just the fuzzing/crash reporting tasks?

@nharper285 , based on our discussions offline, I've opened the following issues related to this discussion: #642, #643, #644, and #645.  I believe these issues will meet your underlying need.  Can you please review these issues?

Closed per discussion


PathLocationStrategy (RouterProvider) in development

Dart SDK Version : 2.5.0
AngularDart Version : 5.3.0
Whether you are using Windows, macOS, or Linux : macOS
Whether you are using Chrome, Safari, Firefox, Edge (if applicable) : All browsers
Auth0

Hello everyone, I am trying to use PathLocationStrategy (RouterProvider) in development, as I am using Auth0 for auth and it has a callback which will pass query URL parameters back to my app.
I cannot use HashProviders, as some query params need to be retrieved from the callback url, which does not work when using a hash url.
I have read that webdev does not support deep linking and also that it is recommended to pick an adequate strategy early on.
I can build the app with webdev build and have it working as expected, however this is a terrible workflow.
I am coming from Angular Ts, where ng serve would handle both strategies correctly.
Is there any way I can run the app in development while using PathLocationStrategy ?
Many thanks.

I cannot use HashProviders, as some query params need to be retrieved from the callback url, which does not work when using a hash url.

HashLocationStrategy should support query parameters. If you can provide a reproduction, please file another issue detailing what doesn't work.

Is there any way I can run the app in development while using PathLocationStrategy ?

I'm not sure if webdev provides this capability, but it sounds like a feature request (or clarification) for https://github.com/dart-lang/webdev/issues. Perhaps it could provide a means to define rewriting URL requests. We use such a feature for our HNPWA Firebase deployment to support deep linking with PathLocationStrategy: https://github.com/dart-lang/angular/blob/44d8ee96f03e54fadb1fbdf0e021570f8d88f6da/examples/hacker_news_pwa/firebase.json#L9-L14


No documentation for the opt-in optimization yew::set_event_bubbling(false)

This is about:

Undocumented code

Problem
https://github.com/yewstack/yew/pull/1542 introduces an opt-in optimization that registers all event listeners globally and disables event bubbling. This is nowhere reflected in the documentation.
Questionaire

I'd like to write this documentation

@WorldSEnder Thank you for documenting it for me :D

Was convenient to do, since I worked on event related stuff ;)


Add some content for features on HomePage

Thanks for adding the markdown parsing, @Essam. I noticed one minor issue with that. See the unwanted indentation after the itemised list:

Not sure how to fix that within the yaml file.
I also noticed some lack of synchronisation between the yaml subtitles and the actual subtitles rendered. That is, expected subtitle is sometimes replaced with a subtitle from a different section.
At your leisure, would be good to get your feedback on the actual content.

Thanks @EssamWisam  for the improvements.
Instead of "Tuning Wrapper", how about "Tuning & Other Wrappers"?
And logically I find it a little strained to put the code snippets before the explanations.

Thanks @EssamWisam for the improvements.
Instead of "Tuning Wrapper", how about "Tuning & Other Wrappers"?
And logically I find it a little strained to put the code snippets before the explanations.

I personally felt it was more boring when the code block was last especially when there was a lot of text. In a sense, if I am a new Julia user already come from Python and know ML I can maybe infer most of the raw text by reading the code. It's also why I mentioned it would be good to add more comments to the code.

Okay, I'm happy to go with that. I've retitled Tuning Wrapper to Meta-algorithms and added some comments to the code snippets to make them more self-contained.

@EssamWisam With the extra comments, the height of the code blocks (apparently static) needs some adjustment. Can you fix that?

@EssamWisam With the extra comments, the height of the code blocks (apparently static) needs some adjustment. Can you fix that?

It's quite confusing that I had a static height to start with. I fixed that now. Could you check?

@ablaom I have a suggestion to put Nested Tuning somewhere after Smart Pipelines since it uses `pipelines.

Could you check?

All good 👍🏾

I have a suggestion to put Nested Tuning somewhere after Smart Pipelines since it uses `pipelines.

Good catch. Fixed. ✔

Any ideas for the highlighted placeholder? Maybe Let's see how MLJ elevates your ML experience or Explore the ways you can use MLJ to boost your productivity or MLJ offers a number of novel and convenient features.

Any ideas for the highlighted placeholder? Maybe Let's see how MLJ elevates your ML experience or Explore the ways you can use MLJ to boost your productivity or MLJ offers a number of novel and convenient features.

To be honest, I can't think of anything that isn't redundant. "Features" is pretty self-evident. Let's drop it.

Thanks for the valuable feedback. Perhaps we can merge this now? There's still content needed for "Getting Started" but this can be a new PR.


Option vargreek-shape still mentioned in documentation

vargreek-shape is still mentioned in documentation - https://github.com/wspr/unicode-math/blob/81b54630a67d41a61cf3cc42d32e2f6c5dbca46d/unicode-math-doc.tex#L309 - even though it was removed in recent release.

Apologies, I appear to have corrected that some time back but never committed the change...

Hello! I know this is quite outdated, but what to do if I liked the option?

@LDVSOFT — good question! The trick is to remember that literal unicode chars will work directly, and the unicode-math-table.tex file maps command names to literal unicode chars. And looking in that file, you'll find \mitvarphi and \mitphi as the underlying names. So you can write
\documentclass{article}
\usepackage{unicode-math}
\AtBeginDocument{
  \renewcommand\phi{\mitvarphi}
  \renewcommand\varphi{\mitphi}
}
\begin{document}
$\phi$ $\varphi$
\end{document}

Oh, mit prefix is available. That's nice, thank you!


APT install .deb file with missing xz-utils

I'm trying to write an ansible role which installs a .deb file package with apt.
I noticed that xz-utils is an optional requirement of the apt ansible module that is necessary to install .deb files. So, I install xz-utils with the apt module in a task before trying the install my .deb file in another task.
However, the .deb file install task fails when mitogen is used, but not with the regular ansible.
My questions:

is this expected with mitogen? or is this a bug?
is there a workaround?

Here are the details of my installation:
$ ansible --version
ansible 2.9.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/sylvain/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15+ (default, Oct  7 2019, 17:39:04) [GCC 7.4.0]

$ ansible-config dump --only-changed
DEFAULT_STRATEGY(env: ANSIBLE_STRATEGY) = mitogen_linear
DEFAULT_STRATEGY_PLUGIN_PATH(env: ANSIBLE_STRATEGY_PLUGINS) = [u'/home/sylvain/.local/lib/mitogen/ansible_mitogen/plugins/strategy']

Can I have any help? Thanks!


A change to an editor tab shouldn't change its instance

The extension host side of editor tabs currently creates new instances of tab whenever something changes. E.g tab instance is thrown away and recreated when it dirty state changes. This behaviour makes it hard to work with the API and instances should update in-place whenever possible.

Yeah I understand this is probably the perfect solution but I didn't want to have to patch the tab model in the ext host and main thread due to the complexity of it. All the cases I can think of or have seen would either use the instance returned from an event or just will grab the model when a command is executed

👯


Use HashMap::entry api to speed up lookups

Currently in the hot loop for diffusion we're doing
        let existing = self.get(tile_pos);
        self.map.insert(tile_pos, existing + signal_strength);

Which involves two hash map lookups. We can use the entry api to turn this into a single hash map lookup with significant performance benefits (17-20%). Arguably the code is also cleaner this way.
Also added AddAssign and SubAssign implementations, just because it makes the code look a bit nicer.
Benchmarks
test result: ok. 0 passed; 0 failed; 51 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/signals.rs (target/release/deps/signals-e82e00caa29fb839)
add_signal_minimal      time:   [212.55 ns 213.71 ns 214.64 ns]
                        change: [-1.2760% -0.5628% +0.1650%] (p = 0.13 > 0.05)
                        No change in performance detected.

signal_diffusion_minimal
                        time:   [612.12 ns 613.33 ns 614.46 ns]
                        change: [-5.0854% -4.8589% -4.6528%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 17 outliers among 100 measurements (17.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  14 (14.00%) high severe

add_signal_tiny         time:   [13.901 µs 13.914 µs 13.933 µs]
                        change: [-2.3908% -2.2498% -2.1225%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  5 (5.00%) high mild
  2 (2.00%) high severe

signal_diffusion_tiny   time:   [72.077 µs 72.131 µs 72.199 µs]
                        change: [-17.871% -17.765% -17.641%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe

add_signal_modest       time:   [11.697 ms 11.711 ms 11.727 ms]
                        change: [-3.2473% -3.1040% -2.9383%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

Benchmarking signal_diffusion_modest: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.1s, or reduce sample count to 70.
signal_diffusion_modest time:   [70.494 ms 70.542 ms 70.592 ms]
                        change: [-20.130% -19.996% -19.877%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  2 (2.00%) high severe

Very nice, thank you!


563 Use django-constance 1.1

This includes Django 1.8 support, so we can stop
using our private fork.
Fixes #563

looks good


deleteCustomResource occasionally errors due to undefined customResourceObj/customResourceArg

Bug Report
What did you do?
Created multiple custom resources with filemanager operator and deleted them. While some were deleted successfully, others  prompted errors and had to be retried.
What did you expect to see?
Expect to see a success or failure message rather than a vscode error. If the following error is acceptable then this is not a bug but a more descriptive error or prompt for the user to try again may be more appropriate.
What did you see instead? Under which circumstances?
I encounter the following error:

Possible Solution
Do not call delete when the customResourceArg or customResourceObj in deleteCustomResource function is undefined.
Additional context

The object, which is sometimes undefined is passed from the treeDataProvider to the function so error checking to catch that was added in https://github.com/IBM/operator-collection-sdk-vscode-extension/pull/46.


Demo site is down

https://shop-demo.parseapp.com/ is responding with

This site can’t be reached
shop-demo.parseapp.com’s server IP address could not be found.

This repo hasn't been modified in 5 years. If it's deprecated - it might help potential stripe users if you mark it clearly as such.

Did you try? Still working?

This site can’t be reachedshop-demo.parseapp.com’s server IP address could not be found.
Try running Windows Network Diagnostics.
DNS_PROBE_FINISHED_NXDOMAIN


32x32 icons are cropped to 16x16

32x32 icons are cropped to the upper left 16x16 portion when the bubble is added.

Thanks Scott, just fixed this to support favicons of any size in commit:
ef308a3809ddeb133f018acbffcaa67d2d5e1c14


Add Node Fetch a popular bot

This bot hits our test servers all the time.
Some info:
Link: https://community.cloudflare.com/t/server-being-spammed-by-node-fetch-user-agent/133167
Link: https://webmasters.stackexchange.com/questions/124570/what-is-the-purpose-of-user-agent-node-fetch-fetching-just-the-base-url-from-our
Link: https://github.com/node-fetch/node-fetch
Example UA:
node-fetch/1.0 (+https://github.com/bitinn/node-fetch)

Testing Link: http://thadafinser.github.io/UserAgentParserComparison/v5/user-agent-detail/c5/bd/c5bd20f5-af96-4592-9668-0ed7ff7f0050.html

Coverage increased (+0.02%) to 99.97% when pulling b5ec72cbcb14479f30ae434441b5c5f658e0c2c2 on ayumi-cloud:node-fetch into 880b9fa797401d14b28956442944c3daa70240ff on WhichBrowser:master.

Fixed by a8514f2ccf8d2ed8dd7a5acb51234dd07ee4834a

Fixed by a8514f2ccf8d2ed8dd7a5acb51234dd07ee4834a


Can this be run serverside only?

hm

No, it is required on both the client and the server. However, datapacks are only needed on the server - the server's attribute configuration is synced to the client.

I meam if the code is tweaked a bit, iirc Vanilla clients ignore unknown attributes


Moved code dealing with general file level arrributes to FsDataWriter

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

@zliu41 @sahilTakiar can you review?

Updated.

LGTM with one small comment

@sahilTakiar any more comments?

Updated.

LGTM


[BUG] Mage docker container doesn't start with bind mounts on Windows

Describe the bug
2024-03-20 14:42:22 [2024-03-20 13:42:22.500] [warning] auth_module_create_missing_role flag is deprecated. It not possible to create roles through the module anymore.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] auth_module_create_missing_user flag is deprecated. It not possible to create users through the module anymore.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] auth_module_manage_roles flag is deprecated. It not possible to create roles through the module anymore.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] storage_parallel_index_recovery flag is deprecated. Check storage_mode_parallel_schema_recovery for more details.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] auth_module_create_missing_role flag is deprecated. It not possible to create roles through the module anymore.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] auth_module_create_missing_user flag is deprecated. It not possible to create users through the module anymore.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] auth_module_manage_roles flag is deprecated. It not possible to create roles through the module anymore.
2024-03-20 14:42:22 [2024-03-20 13:42:22.504] [warning] storage_parallel_index_recovery flag is deprecated. Check storage_mode_parallel_schema_recovery for more details.
2024-03-20 14:42:22 You are running Memgraph v2.15.0
2024-03-20 14:42:22 To get started with Memgraph, visit https://memgr.ph/start

then it just exits with status 139 according to docker desktop.
To Reproduce
Steps to reproduce the behavior:
version: "3"

services:
  memgraph:
    image: memgraph/memgraph-mage:latest
    container_name: memgraph-mage
    volumes:
      - ./mg_lib:/var/lib/memgraph
      - ./mg_log:/var/log/memgraph
      - ./mg_etc:/etc/memgraph
    ports:
      - "7687:7687"
      - "7444:7444"
    command: ["--log-level=TRACE"]

  lab:
    image: memgraph/lab:latest
    container_name: memgraph-lab
    ports:
      - "3000:3000"
    depends_on:
      - memgraph
    environment:
      - QUICK_CONNECT_MG_HOST=memgraph
      - QUICK_CONNECT_MG_PORT=7687

Run this compose on Windows 10 with docker desktop 4.26.1, directories ./mg_lib, ./mg_log and ./mg_etc have been created before running docker compose up
Expected behavior
Mage should start like it does when the compose defines volumes instead of bind mounts.
Screenshots

Hi @arminus, thank you for reporting this issue. We are aware that the bind mounts are not working as expected. We've recently had a similar discussion on another issue related to this and there were a few possible solutions mentioned, such as changing the file ownership and permissions, changing the default location of a docker data directory with the --data-root property and using named volumes instead of bind mounts. Let me know if any of the solutions help in your case

Sorry, didn't find https://github.com/memgraph/memgraph/issues/1734 - I can confirm that the compose file given in https://github.com/memgraph/memgraph/issues/1734#issuecomment-1952435168 works for me.
Since so far, I'm testing Memgraph on Windows only, file ownership and permissions shouldn't normally be the cause. I'm using docker for a variety of purposes and bind mounts haven't been an issue for any so far. (experience is different on Linux of course).

We intend to work on improving the overall user experience with docker-compose soon so any feedback is valuable. I'll keep you updated on the topic. Is this currently a blocker for you?

No, this is not a blocker - just "unusual" behavior

1 in community: https://discord.com/channels/842007348272169002/1270687906087964702/1275360784167211048


RISC-V ELF support?

I tried using sqlelf to analyze a RISC-V ELF binary but got this error:
Unknown machine type for <my RISC-V ELF file>

I then realized that x86_64 is the only architecure supported.
Is there a plan to support RISC-V ELF binaries in the future?

There's a flag to disable eager loading some tables.
If you turn off the instructions table; it should give you the rest OK.
I believe capstone supports RISC-V so it should be a straightforward improvement.
Want to give it a crack?

I have just started learning RISC-V, but I'll give it a go.


how to get message from server?

I spent almost one day. please help me.
I have ubuntu server (<IP_ADDRESS>)
I use win 7 laptop (<IP_ADDRESS>), and install growl for window.
test code on laptop. growl display message.
var Growl = require('node-notifier').Growl;

var notifier = new Growl({
  host: 'localhost', // '<IP_ADDRESS>',
  port: 23053
});

notifier.notify({
  title: 'Foo',
  message: 'Hello World'
}, function(error, response) {
  console.log(error);
  console.log(response);
});

but this code does not work in ubuntu.
[Error: Couldn't connect to growl (might be used as a fallback). Make sure it is running]

How do I get message form ubuntu?
var Growl = require('node-notifier').Growl;

var notifier = new Growl({
  host: '<IP_ADDRESS>',
  port: 23053
});

notifier.notify({
  title: 'Foo',
  message: 'Hello World'
}, function(error, response) {
  console.log(error);
  console.log(response);
});

Your syntax looks right to me. Have you checked if you can communicate with growl? That port's are open and everything on that end is fine.
As seen in the code, host and port are set. You can also try running growly directly to see if that works. I have a feeling this is more a problem with network connectivity.

growly work fine. good.
var growly = require('growly');

growly.setHost('<IP_ADDRESS>', 23053);
growly.notify('This is as easy as it gets', { title: 'Hello, World!' });

below code does not call growl
var Growl = require('node-notifier').Growl;

var notifier = new Growl({
  host: '<IP_ADDRESS>',
  port: 23053
});

notifier.notify({
  title: 'Foo',
  message: 'Hello World'
}, function(error, response) {
  console.log(error);
  console.log(response);
});

and below code does not call growl.notify
var notify = require('gulp-notify');

notify.onError({
  title: 'Foo',
  message: 'Hello World',
  host: '<IP_ADDRESS>',
  appName: 'Foo',
  port: '23053'
});

Ah, you're right. The code check's if you have growl locally (an faulty implementation). checkGrowl() should be extended.
For now, you can avoid this by activating wait.
var notify = require('gulp-notify');

notify.onError({
  title: 'Foo',
  message: 'Hello World',
  host: '<IP_ADDRESS>',
  appName: 'Foo',
  wait: true,
  port: '23053'
});

I think checkGrowl is not need. Because growly return callback.
edited code
and gulp-notify
edited notify.js
edited extra_api.js
It works now.

Thanks! checkGrowl was originally implemented to give better feedback to the user on what error occurred. Especially on "fire and forget" mode, where you don't wait for the response. I think a better solution is to extend checkGrowl to take a host and port as well.


W <IP_ADDRESS> battery monitor

There is an bug in lines 71 through 99 of "SettingsDlg.cs".(Fixed)
But I don't know how the battery power detection and switching logic was refactored after the refactoring, but sure enough, there is something wrong with the battery detection and switching logic

Seems like I screwed up copy and pasting the code. Thanks for finding and fixing the issue.
Ideally I would merge the PR immediately. But since it includes the changes from the other PR, it makes it a little bit more difficult.
It would be best if you create separate branches for each changes. With separate PRs for each branch.
So that I could merge each PR individually.
I know that it's more work for you. It's just a suggestion. We can make this work. I just need a little time.


Update MainActivity.Java at startIntentService()

I added one line of code to avoid NullPointerException at FetchAddressIntentService.Java.

Though it worked for me yet I want to be sure I am right


Skip webpackPrefetch if the module is already preloaded

Motivation / Use-Case
It prevents an additional network request for prefetching (webpackPrefetch) when the module is already preloaded.
It fixes the issue https://github.com/webpack/webpack/issues/17496.
Summary

🤖 Generated by Copilot at f5dab1b
Avoid duplicate prefetch links for JSONP chunks. Check existing preload link elements in lib/web/JsonpChunkLoadingRuntimeModule.js before creating and appending prefetch links.
Details

🤖 Generated by Copilot at f5dab1b

Prevent duplicate prefetch links for the same chunk (link)

Any updates? The PR is very important for me.

Why? The browser will load it from the cache anyway. This code increase runtime size without any profit

Why? The browser will load it from the cache anyway. This code increase runtime size without any profit

@alexander-akait
Try the example in the issue https://github.com/webpack/webpack/issues/17496.
For me, the first time loading on the Chrome browser results in 2 network requests, and neither of the requests receives its content from the cache.
The runtime increases by only 245 bytes, I believe it's worth it.

Firefox:

Chrome is buggy here, we need to report them.
Why you use<link rel="preload" as="script" href="http://localhost:3000/Module.js"> if you have webpackPrefetch: true?

Because browsers have different behaviour I don't want to land this PR right now, before deciding to fix it, we need to get feedback and understand which behavior is correct.
That is intresting if you have:
<html>
        <head>
          <link rel="preload" as="script" href="http://localhost:3000/Module.js">
          <link rel="preload" as="script" href="http://localhost:3000/Module.js">
        </head>
</html>

Chrome doesn't create an extra request, but if you have
<html>
        <head>
          <link rel="preload" as="script" href="http://localhost:3000/Module.js">
        </head>
</html>

And then create <link rel="preload" as="script" href="http://localhost:3000/Module.js"> dynamically using javascript, chrome makes an extra request

/cc @paulirish @addyosmani Should I open a bug report? Thanks


Fix example execution

Resolves: https://github.com/fcrepo4-exts/migration-utils/issues/75

Looks good.


lxd v0.7-0 + ubuntu server 15.04 = ulimit doesn't work

Hello,
I make some tests with lxd, and I found (In my opinion) big problem
On Lxd ( 0.7-0ubuntu1 , run on Ubunru server 15.04 ( amd64 ))
I cannot use ulimit command. I tried run this, on Linux Debian 7
container. Example:
ulimit -n 65000
bash: ulimit: open files: cannot modify limit: Operation not permitted
ulimit with read only parameter ( ulimit -n ) works great ( ;) )
on lxc, ulimit works great.
Regard
GK
PS I checked "ulimit problem" on lxd 0.10, and problem exists in new version :/

Hi,
That's not related to LXD at all but to user namespaces.
You'll notice the exact same when using unprivileged containers under LXC.
Basically what's going on there is that even though it looks like you're root in the container, you're actually uid 165536 (or similar) outside the container, which doesn't have the right to increase user limits, only reduce them.
Today it's not possible to workaround this but it's probably worth considering adding some ulimits to the ever growing list of security knobs in LXD so that the default ulimit for the container can be increased at startup time, therefore letting the user deal with larger values (they'd still not be able to increase them, they'd just start at a higher value).

Thank you for the quick reply.
Can you tell me, how can I  turn off unprivileged mode
and use ulimit command  on my containers.
I use Ubuntu server v15.04 and LXD v0.10
Regards
GK

Create a new unprivileged container profile
lxc profile create privileged
lxc profile set security.privileged true
Start a new container from "image" using the privileged profile
lxc launch image blah --profile default,privileged

Thank you very much for answer, but I hava still problem...
Actually I use file system containers and I run them by lxc start
Is there solution for my sytuation / environment ???
Regards
GK

When I do changes in profile configuration, by use command: "lxc profile set security.privileged true", should I see any changes, when I use command: "lxc profile show privileged" ?.
I see only standard output:
lxc profile show privileged
name: privileged
config: {}
devices: {}
Regards
GK

On Tue, Jun 09, 2015 at 08:04:50AM -0700, geekon75 wrote:

When I do changes in profile configuration, by use command: "lxc profile set security.privileged true", should I see any changes, when I use command: "lxc profile show privileged" ?.

You need to set the profile name (the fact that this command doesn't
error out is a bug that is fixed in later releases, apologies):
lxc profile set privileged security.privileged true

I see only standard output:
lxc profile show privileged
name: privileged
config: {}
devices: {}
Regards
GK

Reply to this email directly or view it on GitHub:
https://github.com/lxc/lxd/issues/745#issuecomment-110394541

Oh yes. I was close :) After changes,  container works excelent
Wery, wery thank for solution !
This information was very important and necessary.
Where can I see all possible configuration options for container ?
Regards
GK

On Tue, Jun 09, 2015 at 08:20:07AM -0700, geekon75 wrote:

Oh yes. I was close :) After changes,  container works excelent
Wery, wery thank for solution !
This information was very important and necessary.
Where can I see all possible configuration options for container ?

https://github.com/lxc/lxd/blob/master/specs/configuration.md

Regards
GK

Reply to this email directly or view it on GitHub:
https://github.com/lxc/lxd/issues/745#issuecomment-110399934

Tkank you, thank you. It's very important link, for me even critical.
It's strange, that I can't saw this document...
Regard
GK

Until full ulimit support is added, it might be nice to add:
LimitNOFILE=65536
to the [service] section of /lib/systemd/system/lxd.service
in the vivid packages?
The number chosen is a little arbitrary of course, but hopefully strikes a balance between resource exhaustion (which seems pretty likely with default 1024:4096 setting which systemd applies by default on vivid), and host resource exhaustion/DoS?

Sounds like a good idea indeed.


Hide EntityAutocompletePicker only if there are zero available options

Hey, I just made a Pull Request!
I noticed some odd behavior in the EntityAutocompletePicker. If there is one available option, the picker will be hidden. This can make sense in some cases, but in others be quite confusing.
Let's say I have a new catalog and have just begun using tags on my entities. Right now I only use one tag, "critical", to distinguish entities in a critical path. 5 of my 20 components have tags: ['critical']. The tag picker won't render on the catalog page. As a user I expect that I can filter by my one "critical" tag.
It seems like EntityAutocompletePicker evolved from the EntityNamespacePicker (see: https://github.com/davidan01/backstage/commit/9b3ab37e1e9b75a9b68e82c92e6c7456ea1dce32), which would explain this: metadata.namespace is a required field; if there's only one available option, that means that there's "nothing to pick from" (every entity has the same value, default).
On string fields like namespace, one option would be to have /api/catalog/entity-facets?facet=metadata.namespace return the number of entities where the value is unset. Then the picker could distinguish between these two cases:
{
    "facets": {
        "metadata.namespace": [
            {
                "value": "default",
                "count": 2325
            },
            {
                "value": null,
                "count": 0
            },
        ]
    }
}

{
    "facets": {
        "metadata.labels.language": [
            {
                "value": "typescript",
                "count": 8
            },
            {
                "value": null,
                "count": 4
            },
        ]
    }
}

This would be a bit trickier with tags though, as the facets endpoint returns counts of individual tags, vs. the entire tag list on an entity.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

No rush on this. Curious about people's thoughts. This'd affect the namespace picker too, as that'd show default where it's currently hidden.

Ah & DCO needs to be fixed.

no stale! merge! lol


Add regolith exec <filter-name> [arguments...] command

This idea is a result of a discussion about #191 and #190 on discord.
The exec command will be able to run filters on the source files of the project. The filters that are intended for this purpose will need to specify that in their filter.json file using new property - canModifySource (the name of the property is yet to be decided).
The user will be able to force non-exec filters to be used that way by using the --force flag.

I think the best way to ship this feature is by treating as a true feature, and not as a side-consequence of flags.
Once we have good "branding" for the idea, we can then name things like 'canModifySource' , the name of the command, and then also include docs and stuff.
The more I think about it, the more I wonder whether tool is the right branding.
We could get:

regolith run-tool ...
And filter property is isToolScript

I like it. We can it call with these names.

This issue is closed with #220. The command is called regolith tool


freesmug-chromium 44.0.2403.130

Thank you for the contribution. It was merged directly as<PHONE_NUMBER>83e3e95d2c4160ad7f22e3a0560449 to keep commit history cleaner. Your contribution is still credited to you.


ConfettiManager leaking

Hi,
I'm using LeakCanary and getting these leaks really often.

I'm not 100% sure, but I think that in ConfettiManager terminate method you should call animator.removeAllUpdateListeners.

There shouldn't be a leak regarding the update listeners because the animator is contained entirely within the ConfettiManager class, and inside terminate we cancel the running animator if there is one.
Are you keeping a reference of ConfettiManager somewhere outside of your context? ConfettiManager has a handle on the underlying view which has a handle on the underlying context so that can potentially cause a leak.

I wasn't keeping any references of ConfettiManager, but it looks that the leak was because I didn't unbind ConfettiView in Fragment onDestroyView.


Add autoenv, bash-funk, direnv, testssl.sh

+1 for direnv, use it all the time.

Closing this PR - it is based off of changes to readme.md - which has since been renamed to README.md in the intervening years. Anyone feel free to open a new PR to add any of any of these bash utilities / applications / tools.


Roll fails to send if there are more than 1 type of dice used

The content script works by scraping the Roll20 character sheet and preparing a string to send over to TaleSpire via the url relay. TaleSpire takes care of the actual dice, the only thing it needs is a string that can be decoded by the app.
At the moment, the content script is failing with rolls that use more than 1 type of dice, because the roll 20 interface adds spaces inbetween the dice which causes the dice roll string to contain encoded string values %20 that correspond to the space.
For example, if my Attacks & Spellcasting section contains a 1d12+3+1d4, the roll20 interface formats this as 1d12+3  + 1d4, which gets passed into TaleSpire as 1d12+3%20%20+%201d4, which is unparse-able by the game.
The quickest solution here is to just trim all extra white space when sending over the roll.

Closed with: https://github.com/aptmac/roll20-to-talespire/pull/3


[MIST-1152] Fix IllegalArgumentException in GroupRebalancer

This PR resolves #1152 by

fixing comparator in GroupRebalancer

I've tested this issue in local environment and it works well. Thanks a lot for your work!


Issue after database connection with "-" fix

I have this connection in openedge project.json:
      {
        "name": "mydb_RO",
        "connect": "-db db/sports2024 -ld sp2k -RO",
        "dumpFile": "",
        "aliases": []
      },

I get error:
Error connecting DB: There is no server for database c:\Users\pkuprevicius\projects\ServiceFramework\db\sports2024. (1423) (1423)
It specifically stopped working after 624-database-with-doesnt-connect-from-openedge-projectjson was merged.

It seems that -RO was somehow emitted and it tired to connect without it. -RO setting allows to connect to the database without database server.


Python 3 Support

Since all dependencies (openpyxl, bibtexparser, lxml, requests) are already Python 3 compatible, making a one-liner fix will make the script working on both Python 2 and 3.
diff --git a/3gpp-citations.py b/3gpp-citations.py
index 91f6a64..628dfef 100644
--- a/3gpp-citations.py
+++ b/3gpp-citations.py
@@ -71,7 +71,7 @@ for row in ws.iter_rows(row_offset=1):
                     entry['month'] = date[1].strip()
                 break

-    print entry
+    print(entry)
     db.entries.append(entry)

 writer = BibTexWriter()

Done! Thanks a lot for the suggestion!


Fix Read More Buttons

#9
Issue: Read More Buttons not functioning properly.
Resolved: By selecting the paragraph corresponding to the button clicked using querySelectorAll() and the id of the clicked button.

Good job @aashay-03! Just merged your pull request.
Quick note: Next time on, when you are opening an issue, please make sure that an issue isn't already existing for the same. Issue #3 was already open while you opened #9. Thanks.

Apologies for the same, from next time onwards I will be more careful.
Thank you for merging my pull request.


AmazonS3Client.GetObjectMetadataAsync() throw exception for filename with space character

Description
I have a s3 filename with space in it: has space.txt.
The url shown in AWS console in entry "Object URL" is https://bucket.s3.amazonaws.com/has+space.txt.
When calling AmazonS3Client.GetObjectMetadataAsync(), passing the request with prop Key = "has+space.txt", it throws exception:
Amazon.S3.AmazonS3Exception: Error making request with Error Code NotFound and Http Status Code NotFound. No further error information was returned by the service. ---> Amazon.Runtime.Internal.HttpErrorResponseException: Exception of type 'Amazon.Runtime.Internal.HttpErrorResponseException' was thrown.

So there are 2 issues here:

AmazonS3Uri() doesn't decode + to   (space) in key.
AmazonS3Client.GetObjectMetadataAsync() doesn't accept the key parsed by AmazonS3Uri() if there's space in filename.

I can manually scan and replace + to   (space), but shouldn't be, right? Because the GetObjectMetadataRequest should accept the result Key from AmazonS3Uri.
Reproduction Steps
Using this testcase, bucket name is just an example.
// The file name is 'has space.txt'
// This URL is copied from AWS console in entry "Object URL"
var url = "https://bucket.s3.amazonaws.com/has+space.txt";

// Use AmazonS3Uri() to parse URL
var s3Uri = new AmazonS3Uri(url);

// Build the request
var req= new GetObjectMetadataRequest()
{
    BucketName = s3Uri.Bucket,
    Key = s3Uri.Key, // value here is `has+space.txt`. If manually set to `has space.txt`, the request below is success.
};

// And client
var s3Client = new AmazonS3Client(awsKeyId, awsKeySecret, RegionEndpoint.GetBySystemName(awsRegion));

// Do request and got exception
var res = await s3Client.GetObjectMetadataAsync(req); // throw exception

Environment

SDK Version: AWSSDK.S3:<IP_ADDRESS>
Package Version: AWSSDK.S3:<IP_ADDRESS>
OS Info: Windows 10
Build Environment Visual Studio 2019
Targeted .NET Platform:  net5.0

Resolution

[ ] :wave: I can/would-like-to implement a fix for this problem myself

This is a :bug: bug-report

Issue reproducible using the code provided by customer. Upload the object to S3 which has space character in file name. AWS S3 Console will show the uploaded object with key name having space (as expected), use Copy URL from S3 console to use the URL in the code above. Manually changing + to space character resolves the issue.
Question: should AmazonS3Uri automatically decode + and other escaped characters (also known as percent-encoded octets) that don't have a reserved purpose (refer .NET Uri Class)?

AmazonS3Uri class uses System.Uri class. Here is some behavior of System.Uri class:
using System;

namespace UriTest
{
    class Program
    {
        static void Main(string[] args)
        {
            var urlWithPlus = "https://somebucket.s3.us-east-2.amazonaws.com/C8624825821_S3+Log";
            var urlWithSpace = "https://somebucket.s3.us-east-2.amazonaws.com/C8624825821_S3 Log";
            var urlwithEncodedSpace = "https://somebucket.s3.us-east-2.amazonaws.com/C8624825821_S3%2BLog";

            Uri uriWithPlus = new Uri(urlWithPlus);
            Uri uriWithSpace = new Uri(urlWithSpace);
            Uri uriWithEncodedSpace = new Uri(urlwithEncodedSpace);

            Console.WriteLine($"URL with Plus LocalPath: {uriWithPlus.LocalPath}");
            Console.WriteLine($"URL with Space LocalPath: {uriWithSpace.LocalPath}");
            Console.WriteLine($"URL with Encoded Space LocalPath: {uriWithEncodedSpace.LocalPath}");
        }
    }
}

This produces the output:
URL with Plus LocalPath: /C8624825821_S3+Log
URL with Space LocalPath: /C8624825821_S3 Log
URL with Encoded Space LocalPath: /C8624825821_S3+Log

Per System.Uri documentation, Escaped characters (also known as percent-encoded octets) that don't have a reserved purpose are decoded (also known as being unescaped). These unreserved characters include uppercase and lowercase letters (%41-%5A and %61-%7A), decimal digits (%30-%39), hyphen (%2D), period (%2E), underscore (%5F), and tilde (%7E).
Amazon S3 buckets allows space and + characters in object key. Hence, if object key is like C8624825821_S3+Log, then changing + to space would be incorrect and may result in unintended side-effects (imagine there are 2 objects named C8624825821_S3+Log and C8624825821_S3 Log. Changing + to space character and using this new key to delete operation would result in incorrect object being deleted).

Hi @ashishdhingra
So is it planned to fix?

@akivamu Based on our analysis, we could not change the existing behavior of AmazonS3Uri since that would be a breaking change for existing users. What we might possibly be able to do is to provide an overloaded constructor for AmazonS3Uri which accepts boolean parameter shouldDecode. If the value for this parameter is true, then we can attempt to decode the URL (e.g. changing "+" to space). The default value false would retain the existing behavior. Please advise if this is an acceptable solution for your use case.

Thanks @ashishdhingra that solution should work to me.

Fixed in AWSSDK.S3 (<IP_ADDRESS>)


gather-logs: Avoid errors in console on Ubuntu

These 2 files don't exist so they fail
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2990#1daddd93-024b-4c78-8d74-3a2831852fbf


Xnero: Watch skyhelpservice.com

Xnero requests the watch of the watch_keyword skyhelpservice\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

skyhelpservice\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Log path not found when installing latest shopware

When installing the latests Shopware Version using this cli tools, i`m getting a Log path not found Exception.
Seems as the tools are looking for a wrong log path.
I guess the lookup path in this line https://github.com/shopwareLabs/sw-cli-tools/blob/af5d2ef8a2c85d5c3feffd143e6bc11523a11c76/src/Services/ShopwareInfo.php#L34 should be 'logs/.htaccess' instead of 'log/.htaccess' and then it should also return 'logs' instead of 'log'.

Good catch, thank you @micru.
Fixed with https://github.com/shopwareLabs/sw-cli-tools/commit/24ec2a13a0d7bb1b5a9bb6751b0749b4f28a830b.


feat: add more functions and parameters for the datetime module

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re #1602
feat: add more functions and parameters for the datetime module

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

3 of 34 (8.82%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 70.927%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/runtime/src/datetime/mod.rs
0
31
0.0%

Files with Coverage Reduction
New Missed Lines
%

kclvm/third-party/serde_yaml/src/de.rs
1
82.67%

kclvm/runtime/src/datetime/mod.rs
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.03%

Covered Lines:
51574

Relevant Lines:
72714

💛  - Coveralls


Which version is most up-to-date?

Describe the bug
pip by default install now version 0.1.2. But newest version is 0.0.3.
https://pypi.org/project/supabase/#history

To Reproduce
Steps to reproduce the behavior:

pip install supabase

Expected behavior
It should install latest version
Screenshots
Above
Desktop (please complete the following information):
n/a
Smartphone (please complete the following information):
n/a
Additional context
n/a

Have deleted all outdated versions, should default to 0.0.3 now

Awesome, issue solved then :)


Initialize the app with popular folders

When a user opens the app for the very first time, empty folders list could be confusing.
We need to provide a user with option to initialize the app with default folders.
These folders could be:

DCIM/Camera
Pictures
Downloads
Documents

For this issue be considered solved, we need:

[ ] determine clear list of "popular" folders
[ ] determine variations of each path in different Android versions
[ ] modify "first run dialog" in the way it would not only suggest to scan filesystem for previously created folders, but also to add "popular" folders

Additional requirements:

[ ] folder suggesting dialog must be separate from scan dialog
[ ] folder suggesting dialog must be presented after scan dialog
[ ] if any of suggested folders is already added, it should be excluded from suggestions
[ ] if no folders remain to suggest, folder suggesting dialog can be omitted

Also, improvements to scan dialog can be made:

[ ] if the app can't find .ark-global folder with a list of roots inside, it should ask for scan
[ ] if there is .ark-global folder with a list of roots inside, the app shouldn't ask for scan


Popover opens and closes contantly when mouse is in specific position

The popover opens and closes repeatedly when the mouse is in a specific position.
https://github.com/user-attachments/assets/7c81f704-2a95-4da4-9be8-8cb6d7b2dc0e

Can you provide a reproducible example?

@luoxiaozero you can reproduce it on the official thaw docs with no changes: https://thawui.vercel.app/components/popover
https://github.com/user-attachments/assets/000b7c40-ecdc-45b5-b93e-c190c680c951
The mouse needs to be in a very precise position for it to trigger.

I have not found this mouse position yet. I'll mark it as a bug and I'll fix it once I reproduce the issue.


Module 2 Week 2 Peer-to-peer review Sandeep Abel Ahmed Zermarden

Excellent job so far! Just let us kindly suggest some changes:

Please check the Modules folder. We think that you have empty files. You can delete them if you want.
You can restructure your project to have more modular files.
Your code can be refactored according to ES6 recommendations.

Done as recommended


Undefined symbol trying to build a test.

This is all I have so far and I'm getting the compiler error. Am I missing something obvious?
   func testPodcastFavoriteToggle() {
        let store = TestStore(
            initialState: TopShowsState(topPodcasts: self.topPodcasts),
            reducer: topShowsReducer,
            environment: SystemEnvironment.live(environment:
                TopShowsEnvironment(dataClient: DataClient.mock())
            )
        )
    }

and my reducer's type:
public let topShowsReducer: Reducer<TopShowsState, TopShowsAction, SystemEnvironment<TopShowsEnvironment>> =

the error...

thanks.

Hey @pcolton! This kind of error usually means build settings need to be tweaked, but we'll need more information to troubleshoot. Can you please use our GitHub issue template and attach a project that reproduces the error? I've pasted the template in again below:
**Describe the bug**
Give a clear and concise description of what the bug is.

**To Reproduce**
Zip up a project that reproduces the behavior and attach it by dragging it here.

```swift
// And/or enter code that reproduces the behavior here.

```

**Expected behavior**
Give a clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Environment**
 - Xcode [e.g. 11.4.1]
 - Swift [e.g. 5.2.2]
 - OS (if applicable): [e.g. iOS 13]

**Additional context**
Add any more context about the problem here.

Describe the bug
Cannot build project which includes a test, get error.
To Reproduce
Created a simple test project, added TCA as a framework. Then added a test case target, test won't compile properly.
Screenshots

Environment

Xcode 11.4.1

TestTCA.zip

Hey @pcolton, looks like TCA isn't being linked in the test target:

That'll fix it.

Yes, thank you. Too bad that's a bit buried in settings for tests. I've been using TCA for many months now, but just now getting to tests (I know, bad) - but that error was a bit obscure to me and I didn't consider the obvious.
I think adding a TCA FAQ to your site or as a pinned item in the forums might be nice, and covering this specific error would be nice as well ;-).
Thanks!


Fix usage with generic functions

This fixes the following test:
declare const fn: <T>(a: T) => { value: T };
const fn2 = memoizeOne(fn); // $ExpectType <T>(this: unknown, a: T) => { value: T };

Previously, the return type was:
(a: any) => { value: any; }

… meaning all type safety was lost!

You okay with this @TrySound?

You okay with this @TrySound?

I think I have fixed this issue in #124. Could you please take a look @OliverJAsh?
Thank you for raising this issue. I'll close this issue and we can track this piece of work in #124


Generate and validate default parameter file

Is your feature request related to a problem? Please describe.
I found it odd that for software that generates whole ARM templates, the documentation indicates I have to write my own parameter file by hand and that there's no built-in validator (given that Bicep contains all the metadata used for parameter field validation.
Describe the solution you'd like
I'd like to request a flag that generates a basic parameter file for the build complete with the default values for each parameter and a validation tool that lets me provide a template parameter file at build that Bicep can validate the values of.

you can install the ARM VSCode extension.

select file type as

Then use snippets.

it will provide this...

Then you can continue with snippets to create individual params
Switch the param file back to JSON language (e.g. F1, language, select)

There could be an easier way...
related to this: https://github.com/Azure/bicep/issues/3381
There is a thread on having the ability to have native Bicep param file format, I will link it if I find it.


Improve README.md

The current README needs work.  We need more details on the website part and the "Deploying" section should probably move to the pombase-chado wiki (and be expanded).

is this quick?

I put high priority, but you can lower to medium....

which README?

It's: https://github.com/pombase/website/blob/master/README.md
I haven't got around to it yet.

OK I can't help there. Removed quick and added "internal"


Kotlin support

When annotating web services with @Api in a web app with both Java and Kotlin files, only the services in Java files show up in the generated swagger.json and swagger.yaml files.  Is this an issue with the plugin or a configuration issue on my part?  Thank you

Nevermind.  Apparently the issue was that the swagger-maven-plugin needed to be after org.jetbrains.kotlin plugin in the maven pom.xml file.

@jblough I put swagger-maven-plugin after org.jetbrains.kotlin plugin in the maven pom.xml file and I'm still don't see kotlin resources in swagger.json file.
Could you share your configurations?
Are you using spring or jax-rs?
Thanks in advance


Integrate systemd control of service

actually call "systemctl stop lokid" when as root as needed

and starting too I guess (loki-launcher start) would require sudo, but then how do you do a quick test or debug?

well stop and start has some integration
and most of the mode that needs it to be stopped should be hooked in.
Anything else?

start could detect is-enabled and halt that to use systemctl start
but just make systemd-start doesn't run this check


Property tests

This property is advertised:
filename (p </> a) == filename a, but it was tested wrong, and only with a unit test.
This PR fixes that.

Accidental formatting changes.


Feature Request: Support the Tasks Plugin

I use the Tasks plugin in combination with the Checklist plugin.
However, completing a task using the Checklist sidebar, doesn't let Tasks put in the completed date information. This means I have to click the task in the sidebar just to go to the note that holds the task, then complete it normally, just to go back where I left.
It would really help if there was some kind of coop between the 2 plugins.

Curious if you've tried using Tasks query for say:
```tasks
not done
due today
```
And drag that note the side bar?

* Ignore the green background working through a CSS margin issue

Nope... hadn't thought of that one 😄
It does solve the issue - unfortunately for this addon, it won't be required then..
Now off, and create an issue with the suggested query... if checking repeated items through it, it doesn't repeat...


[Test] Cypress Exam Participation

Motivation and Context

We want to have an End-to-End test, where a student participates in an exam and hands it in afterwards.
Description

This PR adds a new test, which creates a running exam with a text and programming exercise, registers a student and participates as said student in the exam. Pageobjects have been added to aid with the navigation in the exam as well als the course overview in the beginning. Further exercise types like quizzes will be added later once we have the page objects for those.
Steps for Testing

Configure cypress according to our guide
Run yarn cypress:run --spec src/test/cypress/integration/exam/*
Make sure that all tests passed

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Waiting for PR #3908 to be merged

@jhainzlschmid @rs-maker Could you work out how the PRs should proceed? Especially because this one is blocked by #3908, but #3908 is not in the milestone this one is in. To unblock the milestone, either this needs to move out of milestone 5.1.4 or the other PR needs to be part of it as well.

Tests still pass after merging develop

Test still pass after implementing suggested changes

Test still pass after resolving the merge conflict


Drop .z stream from Python version in JL main menu

After #25 , new images display the full python version when launching into the JupyterLab main menu.
For consistency with the Dashboard spawner page, I would suggest dropping the .z stream from the version string.
@guimou I understand you requested this to enable users to deal with multiple kernel versions, do you think it would be likely for users to use multiple kernel versions with the same minor but different patch?
Perhaps it would be possible to only show the .z stream when two kernels with the same minor versions are detected?

The configuration had two goals:

Remove the "(ipykernel)" mention that does not bring anything apart from
confusing people.
Indicate the Python version, not for multiple kernels (you're right, it
won't happen much), but as a reminder of which image they launched. With
n-1 and n support, they may have in their RHODS environment 3.8 and 3.9
images, then 3.9 and 3.10...

Regarding the z version it's not really important, so it can be removed for
sure. It's a slight modification to make on the Dockerfile.
On Mon., Mar. 6, 2023, 09:54 Luca Giorgi, @.***> wrote:

After #25 https://github.com/opendatahub-io/notebooks/issues/25 , new
images display the full python version when launching into the JupyterLab
main menu.
For consistency with the Dashboard spawner page, I would suggest dropping
the .z stream from the version string.
@guimou https://github.com/guimou I understand you requested this to
enable users to deal with multiple kernel versions, do you think it would
be likely for users to use multiple kernel versions with the same minor but
different patch?
Perhaps it would be possible to only show the .z stream when two kernels
with the same minor versions are detected?
—
Reply to this email directly, view it on GitHub
https://github.com/opendatahub-io/notebooks/issues/49, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6C4YUSFTVAF2LCGSR2GRDW2X3B7ANCNFSM6AAAAAAVRHJBCY
.
You are receiving this because you were mentioned.Message ID:
@.***>

How to test code in local system:

Make the changes in the notebook and build it with following code:
podman build -t runtime . --build-arg BASE_IMAGE=[quay.io/opendatahub/workbench-images:jupyter-minimal-ubi9-python-3.9-2023a-20230605](http://quay.io/opendatahub/workbench-images:jupyter-minimal-ubi9-python-3.9-2023a-20230605)
Run the code to test:
podman run -p 8888:8888 localhost/runtime
Make sure the python version z stream is not showing.

PR Under review
Moved this to next sprint 1.31.


use mainline puppetlabs_spec_helper gem

The 'jenkins-infra/puppetlabs_spec_helper' fork is significantly behind the
mainline gem release.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

If all the tests are passing, then sure.


Add traling-comma rule in the standard rule list in README

Description
When this rule was promoted to the standard rule set it was not added to the standard rule list
Checklist

[x] PR description added
[ ] tests are added
[ ] CHANGELOG.md is updated

In case of adding a new rule:

[x] README.md is updated
[ ] Rule has been applied on Ktlint itself and violations are fixed

Tnx for reporting the missing rule. I have improved the description a bit.


[ISSUE #790] [Bug] Method invokes System.exit(0)

replace System.exit(0)  with throw new RuntimeException();
Fixes ISSUE #988 .

Hello, please revise the title according to the standard.

Hello, please revise the title according to the standard.

done!


Spatial mesh not recovering properly after device sleeps

Describe the bug
The spatial mesh is shifted when returning to the app after putting the device to seep
To reproduce
Steps to reproduce the behavior:

Start the app (spatial mesh should be visible and aligned)
Press the power button on the HL2 to put the device to sleep
Press the power button again to wake the device
Return to the app (the spatial mesh should appear shifted)

Expected behavior
The spatial mesh should recover and align itself like it was before putting the device to sleep
Your setup (please complete the following information)

Unity Version: 2020.3.19f1
MRTK Version: 2.7.3

Target platform (please complete the following information)

HoloLens 2

Additional context
Repo here https://github.com/bhtruong93/spatial-mesh-bug-2.7.3
Essentially it is an empty project with the setup and a scene that uses the default configurations for MRTK

@keveleigh  or @davidkline-ms have either of seen this issue?   Does this seem like it could be related to this OpenXR issue?
https://github.com/microsoft/OpenXR-Unity-MixedReality-Samples/issues/52
@bhtruong93, have you seen this issue Unity 2019?  I believe you've recently upgraded to 2020.  Also, are you using the Windows XR Plugin or the Mixed Reality Open XR Plugin?  And what versions?

@AMollis no we haven't seen this in Unity 2019. Yes, you're right we're currently testing on an upgraded 2020 branch. We're also using Mixed Reality OpenXR, version 1.0.3

We're also using Mixed Reality OpenXR, version 1.0.3

Are you able to update to a newer version? The spatial mapping support in Mixed Reality OpenXR was basically rewritten between 1.0.3 and 1.1.0. It would be interesting to see if you're still able to repro after updating to the latest.

@keveleigh thanks for the tip. Verified that the problem still persists in our app as well as the clean test app using Mixed Reality OpenXR 1.3.0 and Unity OpenXR 1.3.1

I am investigating this now. Hope to have some more information for you soon.

@davidkline-ms do you have any thoughts on work arounds? Two specific questions

Is there some way we could restart or reset the spatial mesh system?
Do you think that spatial understanding will have the same issue? If not, it may be a reasonable alternative for our use case.

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Ensure API tests are tearing down properly

When going through the test code, it looks like Node Filtering tests have a teardown method that removes all the nodes. Most of the other test cases have nothing at all, though there is one test class that has the node removal code at the end of the last case of that test.
This task is to see if the Node.remove() code is necessary and, if so, put it in the appropriate places for existing tests (which likely should be in the teardown method), and definitely to remove it from the one time it's just hanging out at the end of a test case. If it's not necessary anywhere, then we should remove it from the node filtering tests.

I'd be interested in working on this

OK -- will assign. You can check in with @brianjgeiger as needed ... he'll be checking messages even while away. Thanks.

@brianjgeiger Says I should talk to Jeff.

OK


Add check for logic adapter agreement

Closes #169

@gunthercox Just wanted to know more about this? Could you give an example when this will occur?

Sure, consider a scenario where multiple logic adapters are being used. In a case where the outputs generated by the logic adapters are as follows:

Confidence
Statement

0.2
'Good morning.'

0.5
'Good morning.'

0.7
'Good night.'

In this case, two of the logic adapters have generated the same result. The idea behind these changes is to treat the fact that the two adapters have agreed on a response as a significant indicator that this particular response has a greater probability of being a more accurate response to the input.


fix: character

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change bernoulli(1) and bernfrac(1) to +½

This pull request is part of the project at https://github.com/sympy/sympy/pull/23926 and also fixes #604.

I fixed merge conflicts, yet I'm closing this stale pr.
Feel free to reopen it if you wish, but please adapt first code as it was suggested above (in short: control new behaviour with an option).


Better error message when using AzCopy Benchmark with Read only SAS token

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
➜  ~ azcopy
AzCopy 10.11.0
Project URL: github.com/Azure/azure-storage-azcopy
Which platform are you using? (ex: Windows, Mac, Linux)
MacOS Apple Silcon
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
azcopy bench "https://[account].blob.core.windows.net/[container]?"
What problem was encountered?
When SAS token contain only permission Read, run the above command will throw out not quite useful error message.

In MacOS 11.5.1, use brew to install azcopy
brew install azcopy
azcopy login
Generate SAS token for a container within a Storage Account with ONLY Read permission
azcopy bench "https://[account].blob.core.windows.net/[container]?"
Have you found a mitigation/solution?
Using azcopy bench --mode="Download" will at least tell you a 403 error This request is not authorized to perform this operation using this permission. A better error handling would be benefited,

it needs list permission. or you try using azcopy login if your user already had those permissions.

I just attempted to reproduce this issue and it looks like benchmark now fails with an error message that indicates lack of permissions. Closing this issue as a result.
./azcopy.exe bench "https://XXXXXX.blob.core.windows.net/test?sp=r&st=2023-11-01T18:21:52Z&se=2023-11-02T02:21:52Z&spr=https&sv=2022-11-02&sr=c&sig=Bf6k86Vl1YtLLtY8xKjbaYDZlgq%2BInjCsVbjHQpkj9A%3D"
INFO: Cannot auto-tune concurrency because it is fixed by environment variable AZCOPY_CONCURRENCY_VALUE
INFO: The benchmark feature is currently in Preview status.
INFO: Benchmarking uploads to https://XXXXX.blob.core.windows.net/test/benchmark-82be6f96-4838-b743-55ab-f50c80ba930b.
INFO: Scanning...
INFO: Any empty folders will not be processed, because source and/or destination doesn't have full folder support
Job 82be6f96-4838-b743-55ab-f50c80ba930b has started
Log file is located at: C:\Users\XXXXX.azcopy\82be6f96-4838-b743-55ab-f50c80ba930b.log
INFO: Authentication failed, it is either not correct, or expired, or does not have the correct permission PUT https://XXXXXX.blob.core.windows.net/test/benchmark-82be6f96-4838-b743-55ab-f50c80ba930b/22
RESPONSE 403: 403 This request is not authorized to perform this operation using this permission.
ERROR CODE: AuthorizationPermissionMismatch
AuthorizationPermissionMismatchThis request is not authorized to perform this operation using this permission.
RequestId:de5f09fa-601e-0066-3bf0-0c3efd000000
Time:2023-11-01T18:22:39.0785933Z
0.0 %, 0 Done, 0 Failed, 100 Pending, 0 Skipped, 100 Total, 2-sec Throughput (Mb/s): 17.3212p


This whole project should be opt in, not opt out.

This bridge should be opt in by default, and not opt out.
The fact that users have to know about this in the first place, then make specific changes to their profiles to stop you from boosting their posts into another, possibly problematic, network without consent is backwards.
This bridge should only bridge posts from users that have a #bsyBridge tag in their profile, and not the other way around.
I know the temptation as a developer is to want your project to succeed and garner a lot of users, but by making this tool opt-out by default you don't end up with users; you end up with potential victims.

+1, doing this as an opt-out project just shows the developer has no concept of consent or no interest in it, don't know, which is worse.

Understood. I'm working on a new opt in idea, https://github.com/snarfed/bridgy-fed/issues/835#issuecomment-1942046208, hopefully it can replace the original pure opt out. Apologies for not figuring it out sooner.


fix: allow higher pino versions

Thanks for providing the package pino-lambda.
We use it in combination with pino 7 which seems to work just fine, only npm is making troubles because of the peerDependency pino declared as ^6.0.0. Would you consider to change it to >=6.0.0?
This might resolve #26

To be more strict I changed it to >=6.0.0 <8.0.0 because we can't know if it will work with a further breaking change update from pino.


Cleaning up application profiles that belong to deleted workloads

Currently kapprofiler does not clean-up application profiles but it should delete them as soon as the related object is deleted

I'll take this up.


[5.1] Make acceptsJson return true if the accept type is for json-api

This PR is pretty straightforward; it makes Illuminate\Http\Request::acceptsjson() return true if the accept header of the request is either application/json or application/vnd.api+json (as per JSON API).

That won't work the first return will always exit out of that function so the 2nd one will never get called.

This is wrong anyway.

That other content type is not json, as already discussed.

@GrahamCampbell would a better option be adding a new method to check for acceptsJsonApi() or similar? Where is that discussion, I didn't find any...

Just read the header manually.

We don't need loads of methods.

Also, if you say you accept the type of json, acceptsJson WILL return TRUE already.

Look at our tests.

If the client says they only understand that specific type of json, then they DO NOT accept any old json.


Use in bsfUtility/BsTypes.h

Currently BsTypes.h's typedefs are defined as such.
namespace bs
{
    typedef char INT8;
    typedef unsigned char UINT8;
    typedef short INT16;
    typedef unsigned short UINT16;
    typedef int INT32;
    typedef unsigned int UINT32;

#if BS_COMPILER == BS_COMPILER_MSVC
    typedef unsigned __int64 UINT64;
    typedef __int64 INT64;
#else
    typedef unsigned long long UINT64;
    typedef long long INT64;
#endif
}

We can replace these with the types in
namespace bs
{
    typedef std::int8_t INT8;
    typedef std::uint8_t UINT8;
    typedef std::int16_t INT16;
    typedef std::uint16_t UINT16;
    typedef std::int32_t INT32;
    typedef std::uint32_t UINT32;
    typedef std::int64_t UINT64;
    typedef std::uint64_t INT64;
}

I'd argue that it'd be easier for new contributors to just use std::[u]int*_t than the bs::[U]INT* types, for nothing else than simple familiarity with the standard types.

We could do
namespace bs
{
    using std::int8_t;
    using std::uint8_t;
    using std::int16_t;
    using std::uint16_t;
    using std::int32_t;
    using std::uint32_t;
    using std::int64_t;
    using std::uint64_t;
}

To avoid always having to append std to the int names..

I'm torn regarding the std types. It's something I'd like to switch to, but I also don't want to refactor the entire codebase replacing all the usages of existing types in fear it will break code layout if done in an automated way. At the same time I don't feel like using two different naming schemes.
But I guess the change has to start somewhere, so ultimately I wouldn't be opposed towards using the std types for all new code, and convert older code slowly towards it as well.


"Error downloading kickstart file" with OSX host and VMWare Fusion

Hi,
this is probably a problem with my OSX network configuration or VMWare Fusion configuration, but any help would be welcome.
I'm trying to build a new box for CentOS 6.4 64bit on OSX 10.8 host for VMWare Fusion 5.0.3. The build fails at downloading the kickstart file from the host machine with error:
ERROR: Error downloading http://<IP_ADDRESS>:7122/ks.cfg: Couldn't connect to server

If I fix definition.rb (or otherwise tweak veewee) to download the kickstart file using my host's public ip instead of host_ip_as_seen_by_guest, it works.

@datakurre I might have the same problem. Do you remember how you fixed it?


feat: relativistic HMC

Thanks for the review. I just recalled that we were intended to create a new branch for experimental stuff instead of merging it to the main branch. I will create a new PR for this instead and fix the CI.

There are pros and cons for maintaining two branches -- BUG fixes and improvements will take a lot longer to propagate to the main branch. We observed that trend on DynamicPPL.
It's ok to merge this PR to the master branch I think. The new algorithm is already separated from the stable code, which is the main reason for a new branch.

I’m a bit concerned about the new dependency though. It makes no sense for all upstream packages to depend on a package that is not well maintained (last update was like 2 years ago). I could make it optional using Revise.jo. How do you think?

IMO a different branch seems like the best option given the introduction of a new dep :confused:

@yebai I second to @torfjelde. Adding that dependency is a bad idea and managing it using Requires.jl is a bit cumbersome too. Since this is mostly for experimental features, I think we could just create a new branch called experimental, which we manually sync with the master. We just need to make sure we only introduce code change in the src/experimental folder; all other changes should come from merging with master.

@yebai I second to @torfjelde. Adding that dependency is a bad idea and managing it using Requires.jl is a bit cumbersome too. Since this is mostly for experimental features, I think we could just create a new branch called experimental, which we manually sync with the master. We just need to make sure we only introduce code change in the src/experimental folder; all other changes should come from merging with master.

Sure, that sounds good. Perhaps call that branch hmc-research instead?

Sure, that sounds good. Perhaps call that branch hmc-research instead?

Sounds good. I will do this.

EDIT: in that case, let's perhaps separate the changes to Kinect types into a new PR against master.

Do you mean undo the already merged PR (#299) in master?


[CI Optimization] Remove check_repo

Remove check_repo  and its output and all related references.

[ ] compilation_on_android_ubuntu.yml
[ ] compilation_on_macos.yml
[ ] compilation_on_nuttx.yml
[ ] compilation_on_sgx.yml
[ ] compilation_on_windows.yml

I removed it and found a way to disable jobs run on the forked repo by adding if condition for all jobs(but for testing purposes, comment it for now). I also made two jobs into independent reusable workflows, and so far, so good. But there is one thing worth noticing is that when passing the argument to called workflow, there are only three type are supported(string, number, boolean). Though there is a way to walk around this problem and pass the type you want, it could become more tricky when input is complex
the current status can be seen in this branch

Second thought, maybe run workflows on foked repo is not a bad idea. Developers can use it as a verification environment and are able to prepare a high quality PR. So how about keeping enable jobs run on foked repos?

build_llvm.py --project clang lldb is about to generate wamr-lldb binary. I guess we don't need it when building llvm libraries for iwasm and wamrc.
we can use another workflow, like * _build_wamr_lldb.yml* to handle wamr-lldb binary specificaly.

Second thought, maybe run workflows on foked repo is not a bad idea. Developers can use it as a verification environment and are able to prepare a high quality PR. So how about keeping enable jobs run on foked repos?

But we need to make sure run the release job only on bytecodealliance/wasm-micro-runtime.  Maybe  if: ${{ github.repository_owner == 'bytecodealliance' }}

Second thought, maybe run workflows on foked repo is not a bad idea. Developers can use it as a verification environment and are able to prepare a high quality PR. So how about keeping enable jobs run on foked repos?

But we need to make sure run the release job only on bytecodealliance/wasm-micro-runtime. Maybe  if: ${{ github.repository_owner == 'bytecodealliance' }}

Word. I also think about the situation where CI should be triggered on the forked branch, but maybe we could be limited them to less scenery. To think about it, all the commits on the BA branch will be from the pull request, right? Maybe we can only trigger the ci when the branch becomes a pull request base or a pull request target? In that way, CI doesn't have to be run every time sync fork or push a simple commit(if you want to test before PR, you can always trigger it manually). Theoretically, the code quality won't be hurt since we can specify the trigger condition so that CI will run on the base branch when PR is opened/edited and run on the target branch when merged if I understand the document correct. I will test whether this logic is feasible if you think this is a good practice

IIUC, you are saying

remove the on.push trigger
only run when a PR is opened, updated and closed with push_request_target

on:
  pull_request_target:
    types: [opened, synchronize, closed]

jobs:
   xxx:
  if: github.event.pull_request.merged == true

Sure, please take a look.

https://github.com/bytecodealliance/wasm-micro-runtime/pull/1543


Diskpool operator CrashLoopBackOff when CRD already exists

Describe the bug
When updating helm values or otherwise making updates that requires a restart of the mayastor-operator-diskpool pod, if the generated CRD already exists, the entire pod enters CrashLoopBackOff because it wants to re-create the CRD and can't.
To Reproduce

helm upgrade --install mayastor mayastor/mayastor -n mayastor
Observe pods start up after some time
Create disk pool, observe it come online
helm upgrade --install mayastor mayastor/mayastor -n mayastor --set operators.pool.resources.limits.cpu=200m
Observe CrashLoopBackOff of mayastor-operator-diskpool pod

Expected behavior
If CRD exists and there are no required updates to it (maybe by timestamp or hash?), do not try to recreate and do not error out.  This will allow updates to configuration in a production environment whereas now v2.0.0 using helm will not allow configuration updates without data destruction
Error
Output from mayastor-operator-diskpool pod
│ operator-diskpool   2023-02-23T15:32:44.943229Z ERROR operator_diskpool: failed to create CRD error ApiError: customresourcedefinitions.apiextensions.k8s.io "diskpools.openebs.io" already exists: AlreadyExists
OS info (please complete the following information):

Distro: Talos 1.3.5
Kernel version: 5.15.94-talos
MayaStor revision or container image: docker.io/openebs/mayastor-operator-diskpool:release-2.0

Workaround
NOTE: this is destructive to data

Remove finalizers from all diskpool objects
Delete all pools
Delete CRD
Delete POD and let it recreate itself and the CRD

Additional context
Have been discussing with @avishnu on slack

@ryandellolio , Could you please share us clusterrole for mayastor sa
kubectl get clusterrole mayastor-cluster-role -oyaml

I am no longer able to grab these logs but this should be reproducible in a local cluster.
Unfortunately I had to abandon mayastor in my production cluster due to this and a few other things causing challenges such as the the need for an etcd persistence storage solution (which is a circular dependency it seems, given I am using mayastor for persistent storage!)
Let me know if you need anything else from me or if you want me to reproduce in a local talos cluster, and can report back in a few days.

Hi @ryandellolio, sorry to hear you had some issues. Btw the image you were using is not the stable release version, that one is v2.0.0.  If you use the latest version of images directly it might require helm chart update.
Btw did you try to use the manual storage class for etcd? Thanks for helping us out even though you went another way!

Interesting, so not setting the version explicitly doesn't pull 2.0.0? Yes that could be the cause.  I'll test in a local talos cluster.
(Re: etcd manual storage class, I did try this, but am hesitant with my architecture, as talos os is immutable and wipes the node on reboot by design.  I can change this behavior, but it's not desirable given I'm sold on the immutable os concept)

Interesting, so not setting the version explicitly doesn't pull 2.0.0

For stable/released 2.0.0, you'd want to use v2.0.0.
We probably should document that somewhere but we push each images for each release branch and develop per commit. Example, if a new commit comes into the release/2.0 branch we push new container images with tag release-2.0. This is what we've done as we're working in preparation for 2.0.1. When it's time to release, we'll push the v2.0.1 tag which means we'll then push images with the container tag v2.0.1. All of that to say, release-** is simply the latest (potentially unstable) of its respective release branch.

Re: etcd manual storage class

Interesting, what about the attached storage devices? Do those get wiped too? (Meaning we'd have to rebuild the entire pool).
If yes, what happens if you reboot all nodes, do you lose all your pools? Also what happens if you reboot the node where k8s etcd lives (seems like roughly the same issue you'd have with our etcd)? (sorry I don't really know how talos works..)

Thanks @niladrih, this has solved all of my start-up issues with Mayastor on my Talos cluster!

For other users of talos + mayastor + local-provisioner: In Talos, kubelet lives in a container with limited visibility into the root filesystem. You need to bind mount /var/openebs/local to make the local-provisioner work.
machine:
  kubelet:
    extraMounts:
    - destination: /var/openebs/local
      source: /var/openebs/local
      type: bind
      options:
      - bind

@ryandellolio I will proceed and close this issue.


Improve wording of labelmap action

Update the wording of the labelmap relabel action to make it more
clear that it acts on all the label names, rather than the list provided
by source_labels.
Signed-off-by: SuperQ<EMAIL_ADDRESS>

CC @seanrees

I think the documentation is fine as is but we could error when source labels is specified with this action.

ping :)

Gah, clicked the wrong one, now GH ui freezes when I try to click on @roidelapluie 's


Levels for CEMU SMMDB won't load in client

The [SMMDB] client won't load the levels, why?

Just stopped working for me too.  Any update on this issue?

Yeah sorry.
That's because the client still uses the old domain and I had to refresh the redirect.
It should be working again


[bugfix] TIMESTAMP not detected as date

@vylc @betodealmeida

Codecov Report

Merging #5629 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5629      +/-   ##
==========================================
+ Coverage   63.48%   63.48%   +<.01%
==========================================
  Files         360      360
  Lines       22889    22890       +1
  Branches     2547     2547
==========================================
+ Hits        14531    14532       +1
  Misses       8343     8343
  Partials       15       15

Impacted Files
Coverage Δ

superset/dataframe.py
94.64% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39dfb9...d923870. Read the comment docs.


The given range isn't in document. - when used with react-quill

Nothing to configure - used default options.

Not this library's issue.

what was the issue? I'm having the same bug

@nichwch put the mention plugin above your React Component. This will do the trick.
const mention = {
...
}

export default class YourComponent extends Component {

	render() {
		return (
			<ReactQuill
				modules={{mention}}
			/>
		)
	}
}

@mateioprea what if I need to dispatch an ajax request from the props, a.k.a. this.props.dispatch() how can I do this outside the class?


ES View support: Implementaion

[x]  Allow ES views in Workspace. ES view shows up on edit workspace/view drop down. 1 SP
[ ]  Execute ES query in a Dashboard. 1 SP
[ ]  Show ES query result as a  table. 2 SP
[x] Show ES query editor in Dashboard Edit window, when the parent workspace has a ES view. 3 SP.

Waiting for result cards and table view from @kenjinp (search app)

Linked to https://github.com/BlueBrain/nexus/issues/1169

Linked to https://github.com/BlueBrain/nexus/issues/1169


Make TBA last entry and Remove preregistration

Registration is kinda implied with doors-open

Why move Fatemeh's talk?


Official Language/Framework IDE configuration Starter Template Wizard

Zero-Config Project Creation 🚀
Problem:
In Visual Studio and Raider, when starting a new project, you get this zero-config experience, where you don't need to set up almost anything per programming language. In visual studio, it does not feel like Zero-Config. It feels like... A-Lot-Of-Config before stuff work optimally.
Solution:
It would be nice if Microsoft had a git repository with zero-config for each programming language and sub-language/framework.
It should not install the framework you select, but only the optimal IDE configuration files.  With this setup, you can save a lot of time. 😎
Example steps:

You open a folder in VsCode
Go to a panel called something like "Create Project Settings From Template"
Select Language/Framework/Combo.
Language/Framework version
Make checkboxes where the user can check what to setup: 👈 NICE 🥳

Settings.json for local Workspace (not global)
launch.js settings for debugging
tasks.js optimal settings
Checkboxes for Installing recommended Extensions for current workspace
Create Configs only

What could more be added to the list?
What is your feedback?
Do you like the idea?

For which language are you missing this? IMO this should be provided by language extensions.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!