Add identity provider modules

Ticket
N/A
Changes

What was added, updated, or removed in this PR.

Adds identity-provider module to configure an AWS Cognito user pool
Adds identity-provider-client module to configure an AWS Cognito user pool app client
Updates the service layer to optionally optionally enable an identity provider

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

Many projects need an identity provider. This PR adds an option to the app config to allow projects to specify whether they want to enable one using AWS Cognito.
This is needed by the rails template, which comes with auth out-of-the-box.
Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Tested on platform-test
Using https://github.com/navapbc/platform-test/pull/108
Screenshot showing the Cognito user pool:

Screenshot showing the Cognito user pool app client:

Screenshot of ECS task definition showing that the new Cognito env vars and secrets are passed through to the ECS task:

Test deploy on platform-test-rails
Using https://github.com/navapbc/platform-test-rails/pull/1

@lorenyu I think I've addressed all the comments in your previous review. Could you please take another look? Thanks!

How complicated would it be to add some minimal auth logic to the example app in platform-test that leverages the identity provider?

I think this is too complicated to add to this PR. But does bring up some good questions about how we want to make sure our test apps are exercising all of the core functionality. For instance, I could see wanting to do something similar for notifications. Should we add a follow-up issue for that?

Also, it doesn't necessarily have to be with platform-test example app — if you tested the identity provider with the rails template, I wonder if there is some evidence we can provide that this infra setup works with the rails app — maybe a link to a platform-test-rails PR (if that exists), or if you have a private test repo that's using this same infra maybe just sharing some screenshots or something from there?

Yes, I've been testing with the platform-test-rails repo. I can include some screenshots from there.

I'm realizing that I totally missed writing documentation for this feature, so I'll add that in, too.

@rocketnova one thing that came up today is the notion that it would be nice to have PR environments use the same cognito pool as the default workspace, so that we can test using existing users and data rather than needing to go through the account creation flow etc on every PR.
It doesn't have to be in this PR, but I think we'd want to not call the identity provider module if it's a temporary environment and instead use a data source to fetch the existing user pool. Thoughts?

@lorenyu That's interesting. I think that can work. Let's not put it into this PR. This one basically ready to go and I don't want to delay getting it merged in.

Yes, I've been testing with the platform-test-rails repo. I can include some screenshots from there.

For future readers, here's some of the cognito application logic:

https://github.com/navapbc/platform-test-rails/blob/6cd6cf1d8a35767ab693515374f0658d13ab2e7d/app-rails/app/adapters/auth/cognito_adapter.rb
https://github.com/navapbc/platform-test-rails/blob/6cd6cf1d8a35767ab693515374f0658d13ab2e7d/app-rails/app/models/concerns/devise/models/cognito_authenticatable.rb

Yes, I've been testing with the platform-test-rails repo. I can include some screenshots from there.

For future readers, here's some of the cognito application logic:
* https://github.com/navapbc/platform-test-rails/blob/6cd6cf1d8a35767ab693515374f0658d13ab2e7d/app-rails/app/adapters/auth/cognito_adapter.rb

* https://github.com/navapbc/platform-test-rails/blob/6cd6cf1d8a35767ab693515374f0658d13ab2e7d/app-rails/app/models/concerns/devise/models/cognito_authenticatable.rb

👍 I also added a gif and screenshot to the "Testing" portion of the PR description if that's helpful. Sorry I forgot to call that out explicitly.

@rocketnova one thing that came up today is the notion that it would be nice to have PR environments use the same cognito pool as the default workspace, so that we can test using existing users and data rather than needing to go through the account creation flow etc on every PR.
It doesn't have to be in this PR, but I think we'd want to not call the identity provider module if it's a temporary environment and instead use a data source to fetch the existing user pool. Thoughts?

Created https://github.com/navapbc/template-infra/issues/719 for this feature.


Send macro no longer working.

Previously (in the old version), I was able to send a macro to a partymember by pressing "Send" and then filling out their name. That doesn't seem to be the case anymore. I could be wrong, but I assumed that either you needed to target the person you want to send the macro to and press "Send" since the send button gives no confirmation.
That doesn't work, however. Is this incorrect or is sending macros still not supported again yet?

Fixing some other important stuff I broke this.  I have started the fix see #191
TimothyLuke

On 15 Jan 2017, at 12:54 pm, Oninaig<EMAIL_ADDRESS>wrote:
Previously (in the old version), I was able to send a macro to a partymember by pressing "Send" and then filling out their name. That doesn't seem to be the case anymore. I could be wrong, but I assumed that either you needed to target the person you want to send the macro to and press "Send" since the send button gives no confirmation.
That doesn't work, however. Is this incorrect or is sending macros still not supported again yet?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing as will fix in the linked issue


Kontact does find Kontact/Plugin service type -> empty window

Issue description
Kontact does not find the Kontact/Plugin service type resulting empty window:

I was also able to reproduce the error with this little c++ snippet:
# main.pro
SOURCES = main.cpp
QT += KService KCoreAddons

// main.cpp
#include <KServiceType>
#include <KServiceTypeTrader>

int main(int argc, char** argv) {
  QCoreApplication a(argc, argv);
  auto res = KServiceTypeTrader::self()->query(QStringLiteral("Kontact/Plugin"));
}

qmake main.pro
make
./main
kf5.kservice.services: KServiceTypeTrader: serviceType "Kontact/Plugin" not found

Steps to reproduce
$ kontact
grantlee.template: "Plugin library 'kde_grantlee_plugin' not found."
grantlee.template: "Plugin library 'kde_grantlee_plugin' not found."
kf5.kservice.services: KServiceTypeTrader: serviceType "Kontact/Plugin" not found
grantlee.template: "Plugin library 'kde_grantlee_plugin' not found."
grantlee.template: "Plugin library 'kde_grantlee_plugin' not found."

Technical details

system: "x86_64-linux"
host os: Linux 4.14.42, NixOS, 18.09.git.3c5bdec (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0
channels(root): ""
channels(joerg): "nixpkgs, unstable-small-18.09pre137207.92f0d31b949"
nixpkgs: /home/joerg/git/nixpkgs

I don't understand how services are defined. What files do I need to look for to see what services are available on my system?

According to strace it also finds all kontact plugins in the service directory:
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontactconfig.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5847, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFDIR|0555, stx_size=9, ...}) = 0
openat(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 7
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/todoplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=6754, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/summaryplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5390, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/kmailplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5172, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/specialdatesplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5416, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/journalplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5548, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/korganizerplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5625, ...}) = 0
statx(AT_FDCWD, "/home/joerg/.nix-profile/share/kservices5/kontact/kaddressbookplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5788, ...}) = 0
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFDIR|0555, stx_size=8, ...}) = 0
openat(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 7
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact/kmailplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5172, ...}) = 0
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact/specialdatesplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5416, ...}) = 0
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact/korganizerplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5625, ...}) = 0
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact/todoplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=6754, ...}) = 0
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact/summaryplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5390, ...}) = 0
statx(AT_FDCWD, "/run/current-system/sw/share/kservices5/kontact/journalplugin.desktop", AT_STATX_SYNC_AS_STAT, STATX_ALL, {stx_mask=STATX_BASIC_STATS, stx_attributes=0, stx_mode=S_IFREG|0444, stx_size=5548, ...}) = 0

I am not sure if there is a way to provide this through a wrapper. Maybe we can at least document it somewhere?

I don't think this has been solved.

Not stale. There's something bigger going on here, specifically relating to the grantlee.template: "Plugin library 'kde_grantlee_plugin' not found." error.
When I run kontact, kmail, kaddress, or korganizer via terminal, they all work perfectly. When run via KRunner (which uses systemd), I see odd behaviour similar to this, suggesting an environment issue.
Dumping the environment variables for each shows significant differences - I've attached the dumps for reference.
kontact-logs.zip

Interestingly, I do not have a fully blank window, but 'only':

the problem described in #96255 (e. g. akregator not being able to show the content of emails)
and kmail not showing any mail bodies (e. g. sender, receiver, attachments, etc. are displayed correctly, but the body itself stays empty)

Additionally, I experienced it in the same way as @vs49688, after switching from X to wayland (things work fine on X but are broken on wayland).

Today I was able to narrow it down to one specific env variable:

inside my terminal, the env variable NIX_PROFILES is set:

$ echo $NIX_PROFILES
/run/current-system/sw /nix/var/nix/profiles/default /etc/profiles/per-user/florian /home/florian/.nix-profile /var/lib/flatpak/exports /home/florian/.local/share/flatpak/exports

starting via krunner (or the application menu or autostart), does not have that variable set. I tested that via notify-desktop (enter the following command into krunner or the start menu): notify-desktop "nix profiles variable" "$(echo $NIX_PROFILES)"

I suspect the root cause my be the same as in https://github.com/NixOS/nixpkgs/issues/129442#issuecomment-876212507 (e. g. wayland not picking up certain files defining env variables), therefore the workaround mentioned in the comment should work for this problem too (I'll try to find the time for testing it and put my result here).

Adding
  environment.sessionVariables = {
    NIX_PROFILES = "${lib.concatStringsSep " " (lib.reverseList config.environment.profiles)}";
  };

indeed fixes the issue for me.
Because the problem is not unique to kontact and the variable also isn't specific to kontact, I don't think the variable should be defined/changed just for kontact, though I'm not nearly experienced enough with nix to have any idea where to put it. Therefore I unfortunately don't see myself in the position to open a PR for (I'm happy to tackle this with some guidance though ;)

Interestingly, I do not have a fully blank window, but 'only':
* the problem described in [Akregator bug: Plugin library 'kde_grantlee_plugin' not found. #96255](https://github.com/NixOS/nixpkgs/issues/96255) (e. g. akregator not being able to show the content of emails)

* and kmail not showing any mail bodies (e. g. sender, receiver, attachments, etc. are displayed correctly, but the body itself stays empty)

That is exactly the behaviour I'm seeing, and the above fixes it for me.
Should this be closed as a dup of https://github.com/NixOS/nixpkgs/issues/129442?

Interestingly, I do not have a fully blank window, but 'only':
* the problem described in [Akregator bug: Plugin library 'kde_grantlee_plugin' not found. #96255](https://github.com/NixOS/nixpkgs/issues/96255) (e. g. akregator not being able to show the content of emails)

* and kmail not showing any mail bodies (e. g. sender, receiver, attachments, etc. are displayed correctly, but the body itself stays empty)

That is exactly the behaviour I'm seeing, and the above fixes it for me.
Should this be closed as a dup of https://github.com/NixOS/nixpkgs/issues/129442?


Interesting behavior in Safari with FA5

Hi, I just found this and am excited to use it.  Thanks for creating it.
I found what seems to be an interesting issue when using safari, Bootstrap 4, Font Awesome 5 and JQuery 3.2.1
https://use.fontawesome.com/releases/v5.0.6/js/all.js

Tested in Chrome, looks as expected:

In Safari (latest), the filled stars drop down to the next line leaving blank space where the empty star was.

Code:

Rate:

<input type="hidden" class="rating" data-filled="fas fa-star fa-2x" data-empty="far fa-star fa-2x" data-fractions="2"/>

I would like to help, but I don't have any Mac available nor found an easy solution to test the latest Safari on Linux or Windows 😞. The last version for Windows, Safari 5, is too old.
I will try to borrow an iPad and see if I can reproduce it there :wink:.
Of course, if you feel comfortable and wish to contribute, feel free to create a pull request 👍.

I have the same issue using Bootstrap Icons. The div class 'rating-symbol-background' is in the correct place, but 'rating-symbol-foreground' is below where it should be.

I have the same issue using Bootstrap Icons. The div class 'rating-symbol-background' is in the correct place, but 'rating-symbol-foreground' is below where it should be.


title editing error

after clicking on the title:

this is due to the new microcomponent architecture

fix in https://github.com/datproject/dat-desktop/pull/395


Explorer new theme feedback for action

Visual Issues

dataset overview on the right hand side eo should be EO
fix dataset overview bottom white (100px padding) space
need to fix overflow: scroll where the scroll bar is splitting the page
reduce footer height, merge all footer text into one line
think about menu bar height and maybe shorten the width to allow space for map
remove _ from page title and dataset name
remove shadow from logo

Link issues - broken links or misleading links

is there an actual navigation issue?

Usability issues

left-hand side date picker needs to disable month with no data
unknown whitebox above recenter on the map
Add platform NCI/AWS/Sandbox information to title
product selector too noisy, underline + bold + italics + bold italics  white text on blue

Feature wishlist - what links/features should be available but it is not

Add a technical section in the menu area
introduce animation to allow space splitting when clicked, address the issue with too much white space

For further discussion

Well done, huge improvement!
Not sure how you want to handle feedback, but the first thing for me is:

lots of unnecessary scroll bars displayed in Firefox.


Fails on all ssh connections

Error downloading server from https://github.com/VSCodium/vscodium/releases/download/1.77.1./vscodium-reh-linux-arm64-1.77.1..tar.gz

@cutec-chris looks like your are not using vscodium desktop as a client but maybe code-oss? then please follow this comment

I just installed version 0.0.37 of open-remote-ssh on VSCodium v 1.78.2. I have my .ssh/config file set up so that I can do ssh remotemachine from a terminal. However, when I try to have VSCodium open that machine remotely it fails to open. Here's the log:

[Info  - 18:23:41.145] Resolving ssh remote authority 'ssh-remote+devdesktop' (attemp #1)
[Trace  - 18:23:41.173] Identity keys:
/Users/myusername/.ssh/id_rsa ssh-rsa SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX=
[Info  - 18:23:41.413] Trying no-auth authentication
[Info  - 18:23:41.462] Trying publickey authentication: /Users/myusername/.ssh/id_rsa ssh-rsa SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX=
[Error  - 18:23:41.563] Error resolving authority
Error: All configured authentication methods failed

Do you have any advice as to why this is failing? I should also note the permission on the key is 600. Appreciate any advice you can give! :)

Hi @davidtbo, I have some questions,

what's your local OS?
does your key has a passphrase?
is it added to the ssh-agent?
can you share the logs when connecting from a normal terminal using ssh -v devdesktop to check how it does authentication there?

Local OS is Mac 13.4 Ventura. No passphrase. I can do ssh remotemachine on the terminal and it works, but VSCodium won't connect to it with the plugin.
I'm not sure about adding it to an ssh-agent.
Here are the logs from my terminal:

OpenSSH_9.0p1, LibreSSL 3.3.6
debug1: Reading configuration data /Users/myusername/.ssh/config
debug1: /Users/myusername/.ssh/config line 8: Applying options for *
debug1: /Users/myusername/.ssh/config line 226: Applying options for devdesktop
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 21: include /etc/ssh/ssh_config.d/* matched no files
debug1: /etc/ssh/ssh_config line 54: Applying options for *
debug1: Authenticator provider $SSH_SK_PROVIDER did not resolve; disabling
debug1: Connecting to devdesktop port 22.
debug1: Connection established.
debug1: identity file /Users/myusername/.ssh/id_rsa type 0
debug1: identity file /Users/myusername/.ssh/id_rsa-cert type 4
debug1: Local version string SSH-2.0-OpenSSH_9.0
debug1: Remote protocol version 2.0, remote software version OpenSSH_7.4p1-RHEL7-7.4p1-22 mdy1.0
debug1: compat_banner: match: OpenSSH_7.4p1-RHEL7-7.4p1-22 mdy1.0 pat OpenSSH_7.4* compat 0x04000006
debug1: Authenticating to devdesktop:22 as 'myusername'
debug1: load_hostkeys: fopen /Users/myusername/.ssh/known_hosts2: No such file or directory
debug1: load_hostkeys: fopen /etc/ssh/ssh_known_hosts: No such file or directory
debug1: load_hostkeys: fopen /etc/ssh/ssh_known_hosts2: No such file or directory
debug1: SSH2_MSG_KEXINIT sent
debug1: SSH2_MSG_KEXINIT received
debug1: kex: algorithm: curve25519-sha256
debug1: kex: host key algorithm: rsa-sha2-512
debug1: kex: server->client cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none
debug1: kex: client->server cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none
debug1: expecting SSH2_MSG_KEX_ECDH_REPLY
debug1: SSH2_MSG_KEX_ECDH_REPLY received
debug1: Server host key: ssh-rsa SHA256:55gu+gPSDr6fmNjmY0C+nEI7MYlTQmri1r9IgKB1ZNo
debug1: load_hostkeys: fopen /Users/myusername/.ssh/known_hosts2: No such file or directory
debug1: load_hostkeys: fopen /etc/ssh/ssh_known_hosts: No such file or directory
debug1: load_hostkeys: fopen /etc/ssh/ssh_known_hosts2: No such file or directory
debug1: Host 'devdesktop' is known and matches the RSA host key.
debug1: Found key in /Users/myusername/.ssh/known_hosts:259
debug1: rekey out after 134217728 blocks
debug1: SSH2_MSG_NEWKEYS sent
debug1: expecting SSH2_MSG_NEWKEYS
debug1: SSH2_MSG_NEWKEYS received
debug1: rekey in after 134217728 blocks
debug1: get_agent_identities: bound agent to hostkey
debug1: get_agent_identities: ssh_fetch_identitylist: agent contains no identities
debug1: Will attempt key: /Users/myusername/.ssh/id_rsa RSA SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX explicit
debug1: Will attempt key: /Users/myusername/.ssh/id_rsa RSA-CERT SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX  explicit
debug1: SSH2_MSG_EXT_INFO received
debug1: kex_input_ext_info: server-sig-algs=<rsa-sha2-256,rsa-sha2-512>
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug1: Authentications that can continue: publickey
debug1: Next authentication method: publickey
debug1: Offering public key: /Users/myusername/.ssh/id_rsa RSA SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX explicit
debug1: Authentications that can continue: publickey
debug1: Offering public key: /Users/myusername/.ssh/id_rsa RSA-CERT SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX explicit
debug1: Server accepts key: /Users/myusername/.ssh/id_rsa RSA-CERT SHA256:WV+Fw83KnoPx085XXXXXXXXXXXXXXXXXXXXXXXXXXXX explicit
Authenticated to devdesktop ([<IP_ADDRESS>]:22) using "publickey".
debug1: channel 0: new [client-session]
debug1: Requesting<EMAIL_ADDRESS>debug1: Entering interactive session.
debug1: pledge: filesystem
debug1: client_input_global_request: rtype<EMAIL_ADDRESS>want_reply 0
debug1: client_input_hostkeys: searching /Users/myusername/.ssh/known_hosts for devdesktop / (none)
debug1: client_input_hostkeys: searching /Users/myusername/.ssh/known_hosts2 for devdesktop / (none)
debug1: client_input_hostkeys: hostkeys file /Users/myusername/.ssh/known_hosts2 does not exist
debug1: client_input_hostkeys: no new or deprecated keys from server
debug1: Sending environment.
debug1: channel 0: setting env LANG = "en_US.UTF-8"
Last login: Fri Jun  2 18:14:05 2023 from <IP_ADDRESS>

Ok looks like you are using certificate based auth, that's currently not supported, I'll create a separate issue for it.


Fix typo in STS template summary

A suggestion by @mrbarge didn't make it's way into #136 (my fault, don't know how to use a GUI).

/lgtm

/lgtm


Update OpenSSL url path for building SGXSSL in non-docker mode

Signed-off-by: manju956<EMAIL_ADDRESS>

CI job is failing with weird issue (missing signed-off field though the commit has the field).
Hence closing this PR.

CI job is failing with weird issue (missing signed-off field though the commit has the field).
Hence closing this PR.


Add ARM64 Rooted Android support and setup guide.

This could open a lot of windows for creative applications if it's available for android.

Thanks for the addition. I have other commitments right now, so feel free to fork this and add the functionality.


Animation editor key snapping is rounded to some predetermined value instead of using exact snap value

Tested versions

Reproducible in : 4.4.dev3, 4.4.dev2
Not reproducible in : 4.2.2.stable

System information
Windows 11 - Godot v4.4.dev3
Issue description
When you set time snap value in animation editor and you try to create or move key, the result key time value is rounded to some predetermined value instead of using exact number to snap.
Some examples:

If snap value is 0.15, key is actually snapped to value 0.1429
If snap value is 0.225 or 0.275, key is actually snapped to value 0.25
If snap value is 0.3 or 0.4, key is actually snapped to value 0.3333333...
If snap value is from 0.45 to 0.75, key is actually snapped to value 0.5
If snap value is bigger than 0.75, key is actually snapped to value 1
The same rules apply for any integer value like 2.225 is snapped to 2.25, or 4.3 is snapped to 4.33333...

Note that timeline cursor doesn't have this issue and it snaps correctly to exact snap value, no matter how much decimal part is.
Steps to reproduce
1.) Create AnimationPlayer, some Sprite or ColorRect, and create some simple moving animation for it
2.) Try to set snapping value to 0.25, 0.3, 0.425, 0.45 and 0.75 and try to create new key or move existing one and see that it snaps to incorrect value, while timeline cursor is moving correctly (when timeline cursor snap is enabled)
Minimal reproduction project (MRP)
MRP.zip

Sounds like:

https://github.com/godotengine/godot/issues/97832

Which has been fixed, if you are able to build from source you can test the latest version, or wait for dev4 which should be out soon

Sounds like:

Animation track editor no longer snapping to intervals of 0.0001 when using seconds snapping mode. #97832

Which has been fixed, if you are able to build from source you can test the latest version, or wait for dev4 which should be out soon

Just built sources from master branch and no it's still broken

ok I've managed to fix this bug by commenting this section of code (which doesn't make any sence tbh) and just setting "snap_unit" straight to the "step" value

I assume half of this problem is a specification rather than a bug.
When importing an external 3D animation, the default snap value is 1/30, which is an unreasonable number, 0.0333.
The problem here is that simple truncation and snapping will not allow snapping to 1.0s, so we use modf() snapping with https://github.com/godotengine/godot/pull/98826 and https://github.com/godotengine/godot/pull/96328 to snap every 1.0 interval.
There are two possible approaches:

Set the default for all animation modes to FPS Mode to prevent snapping to 1.0 when 0.333 is accumulated

In other words, needs to add a change to #98826 to all animation default to FPS Mode

Ignore the accumulation error issue when snapping above 1.0 and document that

In other words, #98826 only applies when step is 1.0 or higher and needs to add documentation

I believe that the default change by approach 1 should not be done, at least not during Godot5, since it could break projects that use the existing 0.333 snap. So we should probably choose approach 2.


improve travis behavior

build only master and PRs to master
finish on first error
remove redundant tox stuff

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   52.67%   52.67%
=======================================
  Files           7        7
  Lines         131      131
  Branches       33       33
=======================================
  Hits           69       69
  Misses         57       57
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eda25...8f8c9fc. Read the comment docs.


[Bug]: URLSearchParams#get(k, v) is not implemented and uses URLSearchParams#get(k) instead

Version
29.7.0
Steps to reproduce
Prepare
git clone https://github.com/kvndrsslr/jest-bug-urlsearchparams-has-k-v.git
cd jest-bug-urlsearchparams-has-k-v
npm ci

Test
npm run test

This fails only on ./jsdom-test-env.test.js.
Now try to comment out line 3 in ./jest.config.js and run again:
npm run test

This time all the tests pass.
Expected behavior
URLSearchParams.has(k,v) works as expected.
Actual behavior
Instead of URLSearchParams.has(k,v), only URLSearchParams.has(k) is implemented and hence returns false positives in tests that contain .has(k,v)
Additional context
URLSearchParams#has(k,v) seems to be not correctly implemented in jest only when using testEnvironment: 'jsdom'.
I have no idea where this goes wrong, as it works in node by default and it works when testing jsdom and whatwg-url in isolation too.
Environment
System:
    OS: macOS 14.4
    CPU: (12) arm64 Apple M2 Pro
  Binaries:
    Node: 18.19.1 - ~/.volta/tools/image/node/18.19.1/bin/node
    npm: 10.2.4 - ~/.volta/tools/image/node/18.19.1/bin/npm
    pnpm: 8.15.0 - ~/.volta/bin/pnpm
    bun: 1.0.30 - /opt/homebrew/bin/bun
  npmPackages:
    jest: ^29.7.0 => 29.7.0

That's because you're using jsdom@24 in your test, which is the newest version. If you install jsdom@20 (which is what ships with Jest) you can see the test failing in the same way with the builtin test runner.
jest-environment-jsdom@next (v30 alpha) ships with jsdom@22. You can setup a version with jsdom@24 using https://www.npmjs.com/package/@jest/environment-jsdom-abstract
diff --git c/custom-jsdom-env.js w/custom-jsdom-env.js
new file mode 100644
index 0000000..4b132f6
--- /dev/null
+++ w/custom-jsdom-env.js
@@ -0,0 +1,7 @@
+const { default: TestEnvironment } = require('@jest/environment-jsdom-abstract');
+
+module.exports = class JSDOMEnv extends TestEnvironment {
+  constructor(config, context) {
+    super(config, context, require('jsdom'));
+  }
+}
diff --git c/jest.config.js w/jest.config.js
index 69f6556..7d1219c 100644
--- c/jest.config.js
+++ w/jest.config.js
@@ -1,6 +1,6 @@
 module.exports = {
   // comment out this line and the test is successful
-  testEnvironment: 'jsdom',
+  testEnvironment: './custom-jsdom-env.js',
   collectCoverage: false,
   moduleFileExtensions: ['js'],
   resetMocks: true,
diff --git c/package.json w/package.json
index 2219366..fe9e848 100644
--- c/package.json
+++ w/package.json
@@ -10,8 +10,8 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
+    "@jest/environment-jsdom-abstract": "^30.0.0-alpha.3",
     "jest": "^29.7.0",
-    "jest-environment-jsdom": "^29.7.0",
     "jsdom": "^24.0.0",
     "whatwg-url": "^14.0.0"
   },


URL in description and README broken

The URL in the repository description and README are pointing to avnet-dev-workshop's copy of the game instead of yours.
Please fix both, so they point to your copy of the game at https://avnet-dev-workshop.github.io/github-games-JesusNavarrete215.

updated url


What I think are minor improvements

Please test before merging. Most people don't, but I suggest it every time.

Tested; works great


Installation error

I'm getting the following error while running the installation command.
$ deno run --allow-run --allow-read https://deno.land/x/snel/install.ts
Download https://cdn.skypack.dev/-/svelte@v3.38.3-1PgPjnTrq7345fJLweHF/dist=es2020,mode=imports/optimized/svelte/store.js
Download https://cdn.skypack.dev/-/svelte@v3.38.3-1PgPjnTrq7345fJLweHF/dist=es2020,mode=imports/optimized/svelte/motion.js
Download https://cdn.skypack.dev/-/svelte@v3.38.3-1PgPjnTrq7345fJLweHF/dist=es2020,mode=imports/optimized/svelte/animate.js
Download https://cdn.skypack.dev/-/svelte@v3.38.3-1PgPjnTrq7345fJLweHF/dist=es2020,mode=imports/optimized/common/global-5c50bad9.js
Check https://deno.land/x/snel/install.ts
error: Import 'https://cdn.skypack.dev/-/svelte@v3.38.3-1PgPjnTrq7345fJLweHF/dist=es2020,mode=imports/optimized/svelte/animate.js' failed: 525 <unknown status code>
    at https://cdn.skypack.dev/svelte@3.38.3/animate:15:0

this is related with skypack


Add SPI acquisition for X-Heep

Added SPI acquisition in X-Heep
updated README including X-Heep

LGTM, I let @DimitriosSamakovlis take care of extra revision and merge

Overall looks good.
For consistency, please:

add the license + author/date structure at the top of your main.c (easy copy-paste from other files - put your name as main author)
move the Readme inside the x-Heep folder

Then you are all done!


Unmet dependencies buffer overflow fix

Description
Fix a potential buffer overflow in the code executing the unit tests. When executing a test case, its dependencies are checked and the identifiers of unmet dependencies are stored in a statically allocated array. The PR adds a check to ensure that we don't overrun the array. It adds also indications in test reports when the array is too small to store all the unmet dependencies of a test case.
Status
READY
Requires Backporting
Yes
2.16 and 2.7
Steps to test or reproduce
I have tested the changes in this PR by reducing the size of the unmet_dependencies[] array to two and running the test_suite_psa_crypto_se_driver_hal test suite.

Cool, thanks for the review. I will do the backport PRs this afternoon.


fix: follow the includes when returning affected tables in live*

This is awesome, thanks :) and this will fix my hack posted in #user-feedback.
One other requirement noted in the Linear issue description that's not addressed by the include tree is also detecting when a where clause uses a related table. For example, you could query on a relation without including it. I'd suggest we address that in future when implementing proper relation query support.


Feature/pattern match automaton

do not review

Jenkins: test this please

cherry-picked into the main branch


[Issue - #120] - fix: don't call toggleFullscreen if allowFullScreen is set to false

PR Checklist
Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change

PR Type
What kind of change does this PR introduce?

[x] Bugfix

Fixes
Issue Number: #120
What is the current behavior?
Even if allowFullScreen prop is set to false, if f key is pressed, full-screen mode will be called
What is the new behavior?
full-screen mode will not be called when f key is pressed if allowFullScreen is false

@cesar-cb nice, thanks! :v:


Broken link

@biarocha commented on Thu Jun 27 2019
The link from " configuration guide for ArcSight SmartConnector for Azure Monitor Event Hub." is broken.

Detalhes do documento
⚠ Não edite esta seção. É necessário para a vinculação do problema do docs.microsoft.com ➟ GitHub.

ID: bdb257b2-dce3-fe06-c84d-4784fc701f5b
Version Independent ID: 9553d0d3-ebd6-1d99-e483-6ec937c274bf
Content: Como integrar os logs do Azure Active Directory ao ArcSight usando o Azure Monitor
Content Source: articles/active-directory/reports-monitoring/howto-integrate-activity-logs-with-arcsight.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

Hi team,
the mentioned link leads to an error page:

@CeciAc Thanks for your feedback! We will investigate and update as appropriate.

I have created a backlog item to track this.
#please-close

@CeciAc This is to advise you that the new updated link should be appearing in the doc. Thank you for advising us of this issue.


test issue

Test issue. Please assign to author.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 64d1f88b-ee1f-90e0-798e-06e6948977ae
Version Independent ID: 6ba03686-85bf-85e9-0682-17d7d4564477
Content: Global Secure Access (preview) remote network connectivity - Global Secure Access
Content Source: docs/global-secure-access/concept-remote-network-connectivity.md
Service: network-access
GitHub Login: @kenwith
Microsoft Alias: kenwith

@
Thanks for your feedback! We assigned case to document author.

#please-close


filter landmark list on input in search bar

This needs to be rebased on master ...

New branch has been created from master branch for this PR.


feat: increase sessions in the pool in batches and set default min sessions to 10

Increase the number of sessions in the pool in batches of 25 (configurable) for better performance and less RPCs.
This also adds four benchmarks for to verify the working of the above change, and for comparison with other supported platforms. The simulated execution times and network latency is not intended to be 100% equal to a production situation, but to simulate a realistic and repeatable situation that can be used for multiple platforms.

Sorry @olavloite, I ran out of time to take a proper look at this. So it'll be next week before I get to this. Hope that it's ok.

Thanks for this change @olavloite. I just had one minor question.
Another thought is the possibility of initializing the client with some sessions. As I understand it, default min sessions is 0 so I think we would wait for the first request before attempting to create sessions. Your change helps since at least now we won't be creating one session at a time when your default min sessions is zero. But maybe we can set min to something like 10 so the pool opens with something. Thoughts?

Yes, I do think it would be good to set a non-zero default value for min sessions. I've updated it to the suggested default of minimum 10 sessions. These sessions are created asynchronously when a new database is opened.

@skuruppu I figured out why the system tests (and emulator tests) were failing, and the reason behind it might also be a reason that it might not be a good idea to change the default for min to a non-zero value. The following lines of code is the normal way to create a new database:
      database2 = instance.database(generateName('database'));
      const [, database2CreateOperation] = await database2.create({
        schema: `
        CREATE TABLE Albums (
          AlbumId STRING(1024) NOT NULL,
          AlbumTitle STRING(1024) NOT NULL,
          ) PRIMARY KEY(AlbumId)`,
      });
      await database2CreateOperation.promise();

The first line will however not only get a reference to the database, but it will also try to open a session pool for it. As the database at that moment does not yet exist, filling the session pool with sessions will fail. That is not a problem as long as the default for min=0, but once it is changed to a non-zero value, it will cause errors.

@olavloite thanks for looking into changing the min sessions to be non-zero. That makes sense. The pool is initialized in the constructor but as you said, the database may not exist at that point.
So it makes sense to not change that here then.
I think we can get this working by moving the pool creation logic (conditionally) but that's for another time.

I'd be happy for you to merge this in when you're ready.


[Question] Under windows platform, 'iocli gen' only generate file under current pacakge.

As for linux/darwin platform, after running 'iocli gen' under root pkg of go project. all pkg of the project are scanned and did code generation. But under windows platform, iocli gen only scan current project and gen code for it. It causes the problem that when developing under windows platform , developers have to run iocli gen under each package that needs to gen code.
The problem may caused by windows path spliter '' , and  wecan try fixed by refering to solution of controller-gen

Which solution is concrete? I can't find the solution from the link that you supply.

这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Can't stream json object in to std::basic_stringstream<wchar_t>

What is the issue you have?

It is not possible to directly stream a json object into a std::basic_stringstream<wchar_t>.

Please describe the steps to reproduce the issue. Can you provide a small but working code example?

Try to stream an json object into a std::basic_stringstream<wchar_t>

(Not) working minimal example:
https://wandbox.org/permlink/UPTfYGpCkteUSbDx

What is the expected behavior?

That the required operator overload exists, so it can be streamed into a std::basic_stringstream<wchar_t> like it can into a std::basic_stringstream<char>

And what is the actual behavior instead?

The operator overload is missing resulting in a complier error.

Which compiler and operating system are you using? Is it a supported compiler?

GCC 8.3 on Debian 10 (and yes, it is supported according to the link)

Did you use a released version of the library or the version from the develop branch?

Using version 3.6.1

If you experience a compilation error: can you compile and run the unit tests?

99% tests passed, 1 tests failed out of 88

Label Time Summary:
all        = 2271.43 sec*proc (41 tests)
default    = 134.07 sec*proc (41 tests)

Total Test time (real) = 2446.36 sec

The following tests FAILED:
         80 - test-unicode_all (Timeout)
Errors while running CTest

This is indeed not supported in the moment. What would be the encoding of the characters in the stream? UTF-16?

I cannot really answer the question. Though my guess would be UTF-8.
I cannot answer it with 100% certainty because it is the stream type the https://github.com/zuhd-org/easyloggingpp library uses. Though I think they just use UTF-8. Especially considering I can use .dump() just fine.

Great to see this dying due to inactivity.

Sorry, but this is a part-time project. And for this issue it’s not even clear what to do.

The simplest solution would be to just stream a string object into it. I mean wstreams need to be able to handle that themselves. And if they don't that's not your problem.

But in order to do this, the characters of type char have to be converted to wchar. And this conversion would also involve encoding: how would an UTF-8 string be recoded to a sequence of wchar?

No. You can stream chars just fine into a "wstream".
http://cpp.sh/2u7wa

Technically, anything can be converted to anything. But:

But in order to do this, the characters of type char have to be converted to wchar. And this conversion would also involve encoding: how would an UTF-8 string be recoded to a sequence of wchar?

I do not think such a conversion should be part of the API of the library - if needed, user code should do it, because only this code knows what a sequence of wchar should mean in this setting.

Again, you don't need to convert anything. Normal char based strings are just fine. Because then the stream is obligated to do the correct conversion.


test lanes are running for more than 7 hours and timeout

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
k8s test lanes are running for more than 7 hours and fail due to incompletion.
This affects most of the lanes: 1.15-ceph, 1.16, 1.17, 1.18
For example:
Test started today at 3:23 AM failed after 7h5m4s.

{"component":"entrypoint","file":"prow/entrypoint/run.go:164","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 7h0m0s timeout","time":"2020-06-18T14:32:52Z"}

What you expected to happen:
Tests should complete on time.
How to reproduce it (as minimally and precisely as possible):

@dhiller created #3609 to at least give us a little bit more hints.

The issue is resolved right now. A greenhouse restart made the issue go away. We failed to identify root causes. Could be a pod network issue, the node where the cache was scheduled or an issue in greenhouse itself.

there are still issues like that
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3766/pull-kubevirt-e2e-k8s-1.17/1280386915538833408

Not sure how the timetamp addition has been going? @danielBelenky I remember there was an issue with that? Or is that working? Should I revive the simpler #3609?

/close
Timestamps are added and there is now in general a node which only hosts caches to avoid sideeffects from other workloads.


Error loading page - The page could not be loaded due to a configuration error

Hi! Getting started with the boilerplate repository (https://github.com/hotwired/turbo-ios/tree/main/Demo), I am trying to configure a turbo-ios application to connect with rails 7. Everything works fine on most advance and replace actions, except that some links are broken in the iOS context. Those specific links work on both iPhone Safari and web browsers.
My problem seems quite similar to the one described here : https://github.com/hotwired/turbo-ios/issues/3
When the link is clicked through the simulator app, the request is sent to the web server, executed and rails returns a 200 status. However, the view from the simulator throws an error (after staying stuck on the loading screen for a few seconds). Clicking the retry button actually loads the page (cf. screenshots 1 & 2).

For example, in the index page below, clicking on the main link (i.e. "MRH-L de Dora Holder") will trigger the error, but clicking on the ellipsis dropdown and on the "informations" dropdown item will load the page properly. But those two links point to the same exact URI. They alse have no "data-turbo"="false" attribute and no data-turbo-action attribute either because I want to advance (actually adding the "data-turbo-action=advance" instead of implying it doesn't work either).
The structure of this page is the following

each row is loaded in a turbo_frame with a src attribute pointing to the show page
each row contains

links to the show page
the dropdown ellipsis.
Clicking the ellipsis will lazy-load the menu items from a lazy-loaded turbo_frame pointing to the object show page as well.

I don't know if this structure could have an impact on my issue.
I also made sure that my JS console doesn't throw errors on those specific pages that don't load. Once again, they work fine in other contexts (web browsers, safari) and after clicking the retry button as well. It really seems like the advance redirection mechanism, and probably the configuration of my app, are causing the issue.

Most links advance or replace, work fine. Only a few actually throw this error. And this will happen even if I don't change anything to the boilerplace (except the local variable in Demo.swift). But I can't figure out the pattern that will throw the error.
Any help would be greatly appreciated!
Thanks,

These are example logs from Xcode on a failed request. I cannot figure out why does turbo cancels the visit though, and how to troubleshoot this issue?
2024-09-23 18:44:28 +0000 [Bridge] ← pageInvalidated ["timestamp":<PHONE_NUMBER>302] [:]
2024-09-23 18:44:28 +0000 [JavascriptVisit] cancelVisit http://localhost:3000/fr/dashboard/insurance_policy/9968 [:]
2024-09-23 18:44:28 +0000 [Bridge] → window.turboNative.cancelVisitWithIdentifier [Optional("5466888a-44c7-41d6-9add-c141c8431ab8")] [:]
2024-09-23 18:44:28 +0000 [Session] visit ["location": http://localhost:3000/fr/dashboard/insurance_policy/9968, "options": Turbo.VisitOptions(action: Turbo.VisitAction.advance, response: Optional(Turbo.VisitResponse(statusCode: 200, responseHTML: Optional("  <turbo-frame data-turbo-action=\"replace\" id=\"show_insurance_policy_9968\" src=\"/fr/dashboard/insurance_policy/9968?load=true\">\n    <canvas data-animated-logo-target=\"canvas\" class=\"animated-logo rotating\" width=\"105\" height=\"88\" style=\"height: 48px;\" />\n</turbo-frame>")))), "reload": false]
2024-09-23 18:44:28 +0000 [ColdBootVisit] startVisit http://localhost:3000/fr/dashboard/insurance_policy/9968 [:]
2024-09-23 18:44:28 +0000 [Bridge] ← visitCompleted ["timestamp":<PHONE_NUMBER>302, "identifier": 5466888a-44c7-41d6-9add-c141c8431ab8, "restorationIdentifier": 49bc7694-2680-4239-b047-e3b01e4e6775] [:]
2024-09-23 18:44:28 +0000 [Bridge] = window.turboNative.cancelVisitWithIdentifier evaluation complete [:]


search files by name imperfect tokenization

VSCode Version:1.53.0
OS Version:Darwin x64 17.7.0

Version: 1.53.0
Commit: 8490d3dde47c57ba65ec40dd192d014fd2113496
Date: 2021-02-03T16:01:04.046Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 17.7.0
Steps to Reproduce:

open search files by name palette
example:

search project files by name, type interview man means I want search interview man start serial files, but search result list imperfect

search file name include route, result list

Does this issue occur when all extensions are disabled?: Yes
sorry, I'm not good at english.

keyword should have minimal match weight?  //just my ideas only
range 1 should view in result list index 1,
not match should dismiss

See https://github.com/microsoft/vscode/issues/99171#issuecomment-637973584
Try interviewman instead of interview man

@bpasero is there a way that a contiguous match in the path can be made to outrank a non-contiguous match in the name (see second screenshot)?

See #99171 (comment)
Try interviewman instead of interview man

But, interview man means I want fuzzy search with two keyword interview & man maybe fireman,woman,manager or another includes
Start match, End match, middle match

The implementation is at https://github.com/microsoft/vscode/blob/master/src/vs/base/common/fuzzyScorer.ts
By entering interview man you are requiring both interview AND man to score > 0. In your latest screenshot see how the matches that you boxed with yellow qualify by containing the letters m, a and n somewhere in one of the components (path, name), even though those letters appear in a different sequence.

thanks for your explain.

Related https://github.com/microsoft/vscode/issues/25925
@gjsjohnmurray

is there a way that a contiguous match in the path can be made to outrank a non-contiguous match in the name (see second screenshot)?

Currently not.


How to close an realm object?

We got the error like
/var/mobile/Containers/Data/Application/F7B60998-EA3A-4A0B-882B-2E1243AD57ED/Documents/ShopOrderTab.realm: Unable to open a realm at path '/var/mobile/Containers/Data/Application/F7B60998-EA3A-4A0B-882B-2E1243AD57ED/Documents/ShopOrderTab.realm': open() failed: Too many open files.
(null)
and i found close realm object can resolve this problems. but i don't know how to close it. help

Please check out https://github.com/realm/realm-cocoa/issues/4435 and provide some more info about your case in order to investigate it, thanks!


Adds support for sending LCOV coverage reports

Hey, I just made a Pull Request!
This pull request adds support for sending LCOV coverage reports. LCOV reports are sent as text/plain, which is now an accepted content-type. Explanation of how the coverage files are structured can be found here.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for the PR! I'm not well versed with this format but perhaps @alde could help and take a little look :)
Looks good to me otherwise 👍

Thanks all!


[Feature Request] Ability to pass the output filepath and output filename

Thank you. Will do.

Done. Please check the latest version pip install conda-env-export==0.4.5


Change default max of floating point to infinity from max

Description
I recently found while using the library that the default maximum value for a floating point value (for example when using gt_eq) was set to std::numeric_limits<double>::max() which in C++ is less than std::numerical_limits<double>::infinity(). In my use case infinity was the default value of the parameter and this caused problems when trying to use something like rqt_reconfigure to look at the parameter and caused the rest of the parameters not to load.
It makes sense to me that the largest positive value would be infinity and not max double.
Testing
I updated and added a test in descriptor_test_gtest.cpp and ran
colcon test

but would like help adding additional tests that shows the default value of infinity.
I would also like to know if there's a way for my to run this test node so I can check the rqt_reconfigure output.
When I run
ros2 run generate_parameter_library_example test_node

I get
terminate called after throwing an instance of 'rclcpp::exceptions::ParameterUninitializedException'
  what():  parameter 'fixed_string_no_default' is not initialized
[ros2run]: Aborted

:shrug:

Thanks for fixing this.

I would also like to know if there's a way for my to run this test node so I can check the rqt_reconfigure output.
When I run

To fix that, you just have to pass the parameter yaml into the node like this.
ros2 run generate_parameter_library_example test_node --ros-args --params-file src/generate_parameter_library/example/config/implementation.yaml

Note, that the path is relative to the workspace.

@griswaldbrooks  Do you mind running pre-commit to fix the formatting?

@pac48 have you ever seen something like
[WARN] [1705172458.735387611] [rqt_reconfigure]: Failed to retrieve parameters from node /admittance_controller: cannot convert float NaN to integer
[WARN] [1705172459.250283042] [rqt_reconfigure]: Failed to retrieve parameters from node: cannot convert float NaN to integer

this is very similar to what I encountered on my other project when attempting to use infinity

also, for more context, this happens when running ros2 run rqt_reconfigure rqt_reconfigure with my changes. When running
griswald@gpl-container-dev:~/ws$ ros2 param get admittance_controller default_infinity
Double value is: inf

There doesn't seem to be an issue, but this affects running rqt_reconfigure and custom tools that are getting the parameter ranges.


support hostheader as a partition to allow multiple sites to be handled by 1 bucket/stack

Since the host header isn't in the log file name, it would need to be part of the log bucket's prefix configured in CloudFront to keep the lambda stateless when converting new log objects to the partition format.
We have lots of sites, and would like to avoid the overhead of setting up a new stack for each one, and also have the flexibility to query multiple sites at once while still maintaining the cost/performance benefits of using partitions.

How many hostnames do you have, 10/100/10000s...? How many Amazon CloudFront distributions do you have?
Querying for the x-host-header in the logs does not do the trick?


[Central_v2] As a teacher, I can change my profile picture to choose an avatar.

This affects the edit profile flow. It is a subflow for "edit profile picture".

Prototype here


Linux: fix bottom edge resizing

Resizing by bottom left, bottom or bottom right were not working correctly on Linux.
With this change they behave like the correct edge.

LGTM


Update scalatest to 3.2.17

About this PR
📦 Updates org.scalatest:scalatest from 3.2.16 to 3.2.17
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

@SethTisue I tried using rebase but it looks a bit different, just merge or squash merge?

@jxnu-liguobin sorry, I don't understand the question?

@jxnu-liguobin sorry, I don't understand the question?

I just merged it, but PR shows that the commit has two authors


java.lang.NoClassDefFoundError: Could not initialize class io.netty.channel.DefaultChannelId

Expected behavior
connect to server(tcp use netty).
Actual behavior
got an error NoClassDefFoundError, and there was a warn print by logger:  WARN io.netty.channel.DefaultChannelId - Failed to find the current process ID from ''; using a random value: 749849705
Steps to reproduce
1.prepare my netty client in a common way.
2.connect to loop server.
Minimal yet complete reproducer code (or URL to code)
client:
    eventExecutors = new NioEventLoopGroup();
    bootstrap = new Bootstrap();

    bootstrap.group(eventExecutors)
            .channel(NioSocketChannel.class)
            .handler(new ChannelInitializer<SocketChannel>() {
                @Override
                protected void initChannel(SocketChannel ch) throws Exception {
                    ch.pipeline().addLast(new ByteArrayDecoder())
                            .addLast(new ByteArrayEncoder())
                            .addLast(new Handler()); // not important in reproduce
                }
            });
    try{
             // problem
            channelFuture = bootstrap.connect(<IP_ADDRESS>, 7070).sync();
    }catch(Error e){
            // logger.log(e)
    }

besides, you need a common server use netty.
Netty version
i had try 4.1.75.final and 4.1.77.final, problem exist in both.
JVM version (e.g. java -version)
jdk1.6.0_u45
OS version (e.g. uname -a)
Red Hat Enterprise Linux Server release 5.6 (Tikanga)
Linux version 2.6.18-238.el5PAE

java.lang.NoClassDefFoundError: Could not initialize class io.netty.util.internal.EmptyArrays is the reason why this method failed!

@DevinChemeleon do you have the complete stack trace?

no, i didn't get one from java, but there are some information through debug, and the source code version is 4.1.77.final:
java.lang.NoClassDefFoundError: javax/security/cert/X509Certificate
java.lang.NoClassDefFoundError: Could not initialize class io.netty.util.internal.EmptyArrays
java.lang.NoClassDefFoundError: Could not initialize class io.netty.channel.DefaultChannelId
io.netty.channel.ChannelException: Unable to create Channel from class class io.netty.channel.socket.nio.NioSocketChannel
the invoke happends in io.netty.channel.AbstractChannel's newId().
the stack trace is like to:
io.netty.channel.DefaultChannelId.newInstance()
io.netty.channel.AbstractChannel.newId()
...
and the Error appeared in the Class:DefaultChannelId's static init block:
static {
...
if (processId < 0) {
//  first appearance but is not fatal
processId = defaultProcessId();
...
}
...
if (machineId == null) {
// the second and fatal
machineId = defaultMachineId();
...
}
...
}
some supplementary informations:
the project jdk is <IP_ADDRESS> and the runtime jre is 1.6.0_u45
linux verison: Linux localhost.localdomain 2.6.18-238.el5PAE #1 SMP Sun Dec 19 14:42:44 EST 2010 i686 i686 i386 GNU/Linux

I think something is wrong with your JRE. It's complaining that javax/security/cert/X509Certificate is missing, but that class was introduced in Java 1.4: https://docs.oracle.com/javase/6/docs/api/javax/security/cert/X509Certificate.html
Also, your Linux and Java versions are 12 and 9 years old, respectively. I strongly recommend migrating to something more recent.

thanks, for some reason, my project need to compatible with these older versions.
i'm not sure if it's the X509Certificate causeed the failure. I hope we can determine the real reason.

We don't support java 1.4. You will need something more recent to use netty.

oh, something went wrong with my jre, the problem has been solved, thanks!


Keep src dir clean from test data

I just meant to fix the paths, my rustfmt hook did some reformatting. If you don't mind you can merge if not I can fix it up

Having it without the rustfm changes would be great. Running rustfmt is on my TODO list :)

will fix it up in a bit

@vmx there you go


bugfix: fix the wrong package path

Ⅰ. Describe what this PR did
fix the wrong package path
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3025 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3025      +/-   ##
=============================================
- Coverage      50.30%   50.17%   -0.14%
+ Complexity      3069     3066       -3
=============================================
  Files            600      600
  Lines          19514    19486      -28
  Branches        2408     2363      -45
=============================================
- Hits            9817     9777      -40
+ Misses          8714     8701      -13
- Partials         983     1008      +25

Impacted Files
Coverage Δ
Complexity Δ

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

...tobuf/convertor/BranchReportResponseConvertor.java
95.45% <0.00%> (-4.55%)
3.00% <0.00%> (ø%)

... and 28 more


Target macOS 12 and iOS 15

I have recreated the Xcode project from scratch, which massively simplifies the container app. It's now just a single SwiftUI app for both macOS and iOS.

@fregante Do you remember how you managed to include the "assets" thing in https://github.com/refined-github/refined-github/pull/6612? That's the only thing left. Maybe you could do it again.

The window is currently resizable on macOS. We need to target macOS 13 to be able to lock the window size.

If you drag the assets folder into the resources window it will add just the folder, not its contents

That did it 👍

I assume because of the new target iOS version, this is now required: https://github.com/refined-github/refined-github/pull/6874/commits/fa99606fa6648b7835f8cb1ba744007c33a5503b

It works after adding that.

@fregante This is now done.

A couple of issues:

the app doesn't quit when the window is closed
the app starts with a wide window

These things require macOS 13. I'm too lazy to polyfill when we can target macOS 13 in a month. I don't think this should hold back merging.

I think this is reason enough to just target macOS 13 now.

These things require macOS 13

Sizing a window requires macOS 13?? What APIs are you using?

I think this is reason enough to just target macOS 13 now.

That was the idea since Sonoma will be released in like 3 weeks. Those changes can be made here and then it can be merged in a month

I don't see why it needs to stay open. I don't like long-running PRs, and I also don't plan to do a new Safari version until then anyways.

Sizing a window requires macOS 13?? What APIs are you using?

It's complicated. The window used to always be fixed size if you set a fixed size on the root view, but they changed it in macOS 13 to not respect the root view, but the modifiers to change it back require macOS 13.

I don't like long-running PRs

I mean, I did mention that there was no rush and that we could wait until Sonoma, but you can merge anytime.

I mean, I did mention that there was no rush and that we could wait until Sonoma, but you can merge anytime.

Hehe. I know, but today was the time I had time and motivation.

Includes https://github.com/refined-github/refined-github/issues/6000#issuecomment-1486143405
Safari 16.4+


warning

'nltk.downloader' found in sys.modules after import of package 'nltk', but prior to execution of 'nltk.downloader'; this may result in unpredictable behaviour
warn(RuntimeWarning(msg)).

Duplicate of https://github.com/nltk/nltk/issues/2162


[WIP] Spanishtutorials GTN fix

This page will have all the translations for the GTN tutorials to render in human-translated spanish

@pclo @ales-ibt @hexylena @beatrizserrano
Hey team!
I've put together a list of the stuff that wasn't translatable in the auto-rendered tutorials. We're working on translating them, but I figured I'd kick this off somehow so the Helena can figure out where this doc should go / how it should look while the Hispanohablantes work their magic.
Also, idk if @pclo or @ales-ibt are taggable, but it would be good if they were...

Fantastic @nomadscientist, I'll look into the technical side of it and see what our options are!

Hope to catch up with you soon hehe
Next week is a better for me, and I can finally get back to reading  and
working on other things different from courses hehehehe
On Fri, Jun 18, 2021 at 8:31 AM Helena @.***> wrote:

Fantastic @nomadscientist https://github.com/nomadscientist, I'll look
into the technical side of it and see what our options are!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/galaxyproject/training-material/pull/2651#issuecomment-863824780,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSEGN3YNBXPYVLHZUUVBL3TTLY45ANCNFSM464O34KA
.

closing this, since it's incorporated in https://github.com/galaxyproject/training-material/pull/2562


Put structs common to backends in backend.common

It is strange that sox_backend depends on custom classes defined in soudfile_backend. This PR introduces backend.common module where these custom classes are defined and have both sox_backend and soundfile_backend depend on it.

Thanks!


Support vector for intra-sample merge

Hi Adam,
I try to do intra-sample merge of SVs from multiple callers and want to get the support vector for each caller. I am a little bit confused about the collapsed.vcf and merge.vcf. Let's say the example you gave is from two different callers.
>> caller-one.vcf:
chr1 1 ... GT 0/1
chr1 5 ... GT 1/1
>> caller-two.vcf:
chr1 1 ... GT 1/1
chr1 7 ... GT 0/1

>> merge.vcf:
chr1 1 ... GT 0/1 1/1
chr1 5 ... GT 1/1 ./.
chr1 7 ... GT ./. 0/1

Truvari outputs:
>> truvari_merge.vcf
chr1 1 ... GT 0/1 1/1
chr1 5 ... GT 1/1 0/1
>> truvari_collapsed.vcf
chr1 7 ... GT ./. 0/1

Here are my questions:

Why is chr1 7 ... GT ./. 0/1  in the truvari_collapsed.vcf, but chr1 5 ... GT 1/1 ./. is kept as  chr1 5 ... GT 1/1 0/1 in your truvari_merge.vcf?
Similar to jasmine, I am trying to obtain the support vector for each SV from the GT columns in the output VCF. For example, I would get SUPP_VEC=11 for chr1 5 ... GT 1/1 0/1, since they have genotypes to their corresponding callers. Moreover, I also want to tag the caller-specific SVs (i.e., SVs only detected by one caller). Thus, what is your suggestions on this?

Looking forward to your reply! Thanks!

The example states it is "...matching any calls within 3bp...". The variants at position 5 and and position 7 are therefore matched. The example command uses the default --keep, which is 'first' and therefore the position 5 variant is in the output. The second sample's genotype in the position 5 variant is altered because genotypes are consolidated during collapsing. That position 5 variant is now the kept representative of the position 7 variant and therefore inherits its genotype information.
As for why the position 7 variant is in the truvari_collapsed.vcf, this file hold the representations which were collapsed into a kept variant representation. I may have made a mistake by naming that the --collapsed-output and maybe called it --removed-output.
Truvari collapse populates FORMAT/SUPP flag if the --intra flag is set. (details).  This flag also consolidate the samples such that the output VCF only has a single SAMPLE column. If you'd like to preserve the sample columns and also have a SUPP, you'd need to create an annotation script to fill in the SUPP flag.

Thanks for your explanation! It helps a lot!
In terms of the value for NumCollapsed, it will be NumCollapsed=1 for chr1 5 ... GT 1/1 0/1 because only one variants collapsed.
>> truvari_merge.vcf
chr1 1 ... GT 0/1 1/1
chr1 5 ... GT 1/1 0/1

If what I mentioned above is correct, I further got some results that made me confused. The example below is one record in truvari_merge.vcf and the NumCollapsed=3. While from the GT columns, I can tell there are two SVs
chr1    2203974 pbsv.DEL.109;DEL00000125        GAGCAGTGCCCACACCCCCAGGTGAGCATCTGACATCGTGGAGCAGCACCCCACACCCACAGGTGAGCATCTGACAGCCTGGAGCAGCACCCACACCCCCAGGTGAGCATCTGACAGCCTGGAACAGCACCCACATCCCCAGGTGAGCCTCTGACATCGTCGAGCAGCACCCCACACCCACAGGTGAGCATCTGACAGCCTGGAACAGCACCCACACCCCCAGGTGAGAATCTGATGTTCTGGAGCATCACACACAACCACAGGTGAGCATCGGAGAGTCTGGAGCAGCACCCACAACCCAAGGTGAGCATCTGACAACCTGGAGCAGCACCCACACCCCGAGGTGAGCATCTGACCTCCCGGAGCAGGACCCATACCTCCAGGCGAGCATCTGAACCCATGGAGCAGCACCCACGCCCCCAGGCGAGCATCTGACCGAACAGAGCAGCACCCACAACCCCATGCGAGCATCTGACAGCCTGGAACAGCACCCACAACCCCAGGTGAGCATCTGACAGCCCGCAGCAGCAACCACACGCACAGGTGAGAATCTGACAGCCCGT     G       635     PASS    SVTYPE=DEL;SVLEN=-562;PRECISE;SVMETHOD=EMBL.DELLYv1.1.8;PE=0;MAPQ=0;CT=3to5;CIPOS=-6,6;CIEND=-6,6;SRMAPQ=42;INSLEN=0;HOMLEN=6;SR=15;SRQ=0.994223;CONSENSUS=CACCCCCAGGGGAGCATCTGAAATCCTGGAGCTGCACCGACAACACCAGGTGAGCATCTGAGAGCCTGGAACAGCACCCGCACCCCCAGGTGAGAATCTGACAGCCTGGAAGAGCACCCCATATCCCCGGGTGAGCATCTGACAGCCTGGAACAGCACCCACTCCCCCAGGTGAGCACCTGACAGACTGGAACAGCACCCACAGGCCCAGGTGAGCCTCTGACAGCTTGGAACAGCACGCGCACCCCCAGGTGAGCATCTGACAGCCTGGAACAGCACCCACACCCCCAGGCGAGCATCTGATAGCCTGGAACAGCACCCACACCCCCAGGAGAGCATCCGGCAGCCTGCAGCAGAACCCACACCAACAGGCGAGCATCTGACAGCCTGGGTCGGCACCCACACCCCCAGGTGAGCATCTGACGGCCTGGAACAGCACCCACACCCCCAGGTGAGCATCTGACATCGTGGAGCAGCACCCCACACCCACAGGTGAGCATCTGACAACCTGGAGCAGCACCCACACCCCCAGGTGAGCATCTGACAGCCTGGAACAGCACCCTGCACCCCCAGGTGAGCATCCGACAGCCTGGAGCAGCAACCACACTCCCAGGCGAGCATCCGATGACCTGGAGCAGCACCCACAACCCCAAGTGAGCATCTGATTTTCTGGAGCAGCACCCACAACCACTGGTGAGCATCGTAGAGTCTGGAGCAGCGCCCACAGCCACAGGCGAGCATCTGACAGCCCGGAGCAGTGCCCACACCCCGAGGTGAGCATCTGACAACAGGGAGCAGCACCCATAGCCCATGGTGAGCACCTGACAACGTGGAGCAGCACCCACACACCCAGGTGAGCATCTGATGGTCTGGAGCAGCACCCACAACCACAGGTGAGCATCGGAGAGTCAGGAGCAGTGCCCACACACCCAGGCGAGCATCTGACAGCCTGGAGCAGCACCCACACCGGCAGGGGAGCATCTGACATCCTGGAGCAGCACCGACAACCCCAGGTGAGCATCTGAGAGCCTGGAACAGCACCCACAACCCCAGGTGAGAATCTGACAGCCTGGAAGAGCACCCCACATCACCGGGTGAGCATCTGACAGCCTGGAACAGCAACCATACCCTCAGGTAAGCATCTGACAGACTGGAACAGCACCCACACGCCCAGGTGAGCCTCTGACAGCCTGGAACAGCACGCGCAACCCCAGGTGAGCATCTGACAGCCTGGAACAGCACCCACACCCACAGGTGAGCATCTGACAGCATGTAACAGCACCCACACCCCCAGGTGAGCATCTGACAGCCTGCAACAGCACCCTGCACCCCCAGGTGCGCACGTGACAGCCTGGAAGAGCACCCACACCCCAAGGCGAGCATCTGACGGCCTGGAACGGCACCCACACCCCCAGGCGAGCATCGGACAGCCTGGAGCAGCACCCCACACCCCCAGGTGAGCATCCGACAGCCTGGAGCAGCACCCACACCCCCAGGTGAGCATGTGACAGCCTGGAAGAGCACCCACACCCCCAGGCGAGCATCTGACAGCCTGGGTCGGCAACCACACACGCAGGTGCGCATCTGATGGTCTGGAGCAGCACCCACACCAACAGGTGAGCATCTGACAGCCTGGAACAGAACCCACACCCCCAGGTGAGCATGTGACAGACTGGAACAGCACCCACATGCCCAGCTGAGCCTCTGACAGCCTGTAACAGCAGCCTGCACCCCCAGGTGCGCCCGTGACAGCCTGGAACAGCACCGACACCCACAGGCGAGCATCTGACGGCCTGGAACAGCACCCACACCCCCAGGTGAGCATTGGACAGCCTGGAGCAGCACCCACAACCCCAGGCGGGCAACCGACAACCTGGAGCAGCACCCACACCCACAGTTGAGCAT;CE=1.8857;CONSBP=952;AC=2;NumCollapsed=3;NumConsolidated=0;CollapseId=73.13 GT:AD:DP:SAC:GL:GQ:FT:RCL:RC:RCR:RDCN:DR:DV:RR:RV       ./.:.:.:.:.:.:.:.:.:.:.:.:.:.:. 0/1:68,15:83:40,28,11,4:.:.:.:.:.:.:.:.:.:.:.   ./.:.:.:.:.:.:.:.:.:.:.:.:.:.:. ./.:.:.:.:.:.:.:.:.:.:.:.:.:.:. 0/1:.:.:.:-80.0277,0,-128.336:10000:PASS:28004:48314:30574:2:0:0:35:21  ./.:.:.:.:.:.:.:.:.:.:.:.:.:.:. ./.:.:.:.:.:.:.:.:.:.:.:.:.:.:.

You can tie the CollapseId to the collapse output's MatchId to find the three variants which comprise the three collapsed entries. What you'll likely find is that one of the samples have genotype information in the kept entry and one of the collapsed entries. See the --gt parameter for info no how to allow genotypes from the same sample to prevent variants from matching.

Awsome, this is really helpful! Thanks a lot!

Hi Adam,
I tried to unpack the SUPP for a truvari merged VCF from three callers. I found some records with SUPP=0. For example:
chr1    789884  Sniffles2.INS.30S0      A       GTGGAATGTAATGGAATGAAATGGACTCGAATGGAATTAAATGGAATGGAACGGAATGGACTGGG 2       GT   PRECISE;SVTYPE=INS;SVLEN=64;SUPPORT=29;COVERAGE=151,156,159,168,173;STRAND=+-;AF=0.182;STDEV_LEN=0;STDEV_POS=0;SUPPORT_LONG=0;AC=0 GT:GQ:DR:DV:SUPP      0/0:60:130:29:0

I am wondering what happened to this SV, since I would expect all SUPP value >0 in the merged VCF.
Thanks!

Populating the SUPP flag involves finding which "samples" have evidence for the presence of the variants. The only signal that's reliable for measuring variant presence is a '1' in the GT. So, if one encounters a situation where there is a VCF entry describing an 'absent' (i.e. reference homozygous) variant, the SUPP flag may become 0.
Your example variant probably looked similar to the following in the pre-collapse input:
chr1    789884  Sniffles2.INS.30S0      A       GTGGAATGTAATGGAATGAAATGGACTCGAATGGAATTAAATGGAATGGAACGGAATGGACTGGG 2       GT   PRECISE;SVTYPE=INS;SVLEN=64;SUPPORT=29;COVERAGE=151,156,159,168,173;STRAND=+-;AF=0.182;STDEV_LEN=0;STDEV_POS=0;SUPPORT_LONG=0;AC=0 GT:GQ:DR:DV:SUPP      ./.:.:.:.:.       0/0:60:130:29:0


NMAKE DOCS

I have a serious question. How man yman hours did you dedicate to creating documentation that looks good enough to Project Managers but actually tells me nothing?
How can you have a commands section that does not list the commands?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0bb1aa3-a4ac-1bb5-f232-54eed4fca4c1
Version Independent ID: da4631dd-bb32-73e7-83e6-7c1336a6c526
Content: Commands in a Makefile
Content Source: docs/build/reference/commands-in-a-makefile.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@runette
I appreciate that your expectations weren't met here. If you're looking for the nmake command-line options, you'll find them in the NMAKE Options section of the Running NMAKE article. I can see that the title of the article may not convey the content, since it really is mostly about the command-line options and return values.
Speaking of commands, that might represent some semantic confusion. When we talk about nmake commands, we mean the commands you can put in your makefile, which includes literally anything you can invoke from the command prompt. That's not only tough to enumerate, it's different for every machine. Presumably you'd have common ones for Visual Studio like cl.exe, csc.exe, or link.exe, but nmake is equally happy to invoke gcc.exe or clang.exe. Or notepad.exe, for that matter. If instead you're asking for a list of common build labels such as "clean", "debug", or "release", remember those labels are totally arbitrary and are defined by you in your makefile.
Taking your question about documentation development effort seriously, it's hard to say how long it took, since this content was written back in the '90s, if not earlier. It's only been touched to migrate it to new content systems since then. As nmake is not a tool in active development with changes that need updated docs, we've occasionally fixed doc bugs, but that's about it. Unfortunately, our time is limited, and we tend to spend it on new content or content with high traffic, and nmake doesn't qualify on either count.

@runette
You may contact the Microsoft data protection officer by filling out the webform at https://aka.ms/privacyresponse. The first link has more details and additional contact options.
I apologize that our feedback procedure may have given you an expectation of privacy that wasn't delivered. At the bottom of every page in the C++ documentation, there's a Feedback section, with buttons for feedback on the product or on the current page. The "This page" button takes you to our public GitHub repository, where you can enter an issue in a pre-filled form. You must be logged into GitHub to create an issue. Just like any other GitHub issue in a public repo, the issue is public, and it's associated with your public GitHub profile. There's no way to create a private issue through this mechanism, or to send private messages on GitHub. The only exposure of your personally identifiable information is what you've chosen to make public through your GitHub profile.
If you like, I can delete your issue. It won't appear with your profile information attached; it will only show that issue #3122 was deleted.

@corob-msft
Note that I DID NOT click on the facebook links or the github links. I filled in this form

So you can see why I was very surprised to see this comment on GH.
Please delete this issue. It is a matter of principle.

@runette
Only you will see this message, and only in the form of a notification mail from GitHub, if you have it enabled.
I'm also surprised by your report, to the point of considering it bizarre, if not impossible. I have not been able to reproduce the effect. The helpful page verbatim reporting has gone to a different database in the past. It doesn't track the same info that the page feedback control does, and it doesn't record your GitHub user name, just a session ID. That makes it difficult to believe it could generate a GitHub issue as if it came from you. There won't be any channel for follow-up, but I will investigate.


Create LICENSE, CODE_OF_CONDUCT, DesignDoc

Homework 15 - Software Release

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Nesting with RouteWithSubRoutes not working along with Switch & without Switch Not able to add Default route

Version
^5.0.0
Test Case
Implemented same Route Config solution shared at https://reacttraining.com/react-router/web/example/route-config
Steps to reproduce
In case your component 'RouteConfigExample' in example modified as follow to display only routes in whole page.
function RouteConfigExample() {
  return (
    <Router>
      <div>
        {routes.map((route, i) => (
          <RouteWithSubRoutes key={i} {...route} />
        ))}
      </div>
    </Router>
  );
}

Expected Behavior
Should support Default Route
Actual Behavior
Added default route is getting rendered in each sub routes as we don't have Switch over parent routes.

Switch doesn't work with nested routes, only the ones described at the top level. You will need to convert your route structure to a flat list.


mysql mount vloume failed

What happened:
mysql mount vloume failed with error:

What you expected to happen:
mysql mount vloume success
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Openebs status:
blockdevice:

storageClass:

pvc:

Environment:
Kubernetes version (use kubectl version):
1.20.5
iSCSI client(cat /etc/iscsi/initiatorname.iscsi):
InitiatorName=iqn.1994-05.com.redhat:7bb275836254
iSCSI service( systemctl status iscsid):
active

@dapiaoke2021  can you please share:
kubectl get cstorvolume -n openebs -o yaml


Ability to schedule joining instances

I would like to be able to double click my "enter instance" key to schedule a join for a preview.
This means that when the preview is nearly finished (roughly 300-500ms before joining) it plays a warning sound, and when it finished generating the player is automatically put in the world.
Additionally, double clicking (<300ms) my "enter instance" or "focus reset" hotkeys should schedule joins for all locked instances
I have implemented this for myself using a python script to spam the Play Next Lock hotkey, but it would be a good addition to SeedQueue itself
It would also be very useful if the world gen % of the highest instance with a scheduled join was able to be displayed in some way, either by rendering it on the wall screen or outputting it to a text file for macros/OBS to handle it.
The purpose of this is so you can position the % number in the middle of a a 3x3 main grid, and when the number is nearly at 100% you know you're about to be put into a seed

How do you expect the warning sound to work? play a warning sound when the instance finishes loading, wait, then put into the seed or estimate the time to finish and send the warning 300-500ms before that?
Double clicking seems like a good suggestion for https://github.com/KingContaria/seedqueue/issues/3.
Last point is a bit unrelated to scheduling join, either a good fit for another issue, for example the percentages could be included in the wall stateoutput.
To render it directly in Minecraft, suggest in https://github.com/KingContaria/seedqueue/issues/4, its not exactly the same thing but ive been considering having something like "text sources" included in transformations and they could potentially have different sources, for example 'highestlockedworldgenpercentage', id be open to implement fairly personalized things for something like that.
For future discussion I'll treat this only as a suggestion to be able to schedule individual or all instances and have a warning sound before putting you into the world.
Am i understanding correctly that you want to be able to schedule multiple enters, basically acting as a way to bypass the wall screen without the option enabled?

For the warning sound it would be fine to just play it around 95% world gen (configurable)

Am i understanding correctly that you want to be able to schedule multiple enters, basically acting as a way to bypass the wall screen without the option enabled?
Scheduling an enter would also lock it, so having wall bypass enabled would handle that aspect of it. The "scheduled enters" should be forgotten once an instance is entered (going back to wall shouldn't put you in a world 500ms later when one loads), but they should stay locked

Started work on this here: https://github.com/KingContaria/seedqueue/tree/feature/schedule-joins
Should scheduling a ready instance to be joined act the same as playing it? If not, how else would you like it to be handled?
I'm also not sure how i want the warning percentage to be configured yet, I don't want to clutter the settings menu with stuff that only takes effect with resourcepacks so i might make it part of the sounds .mcmeta file.

Should scheduling a ready instance to be joined act the same as playing it?
Yes


Fix doc nits warnings in STORE documentation

Fixes:
(cd ../work/openssl; /usr/bin/perl util/find-doc-nits -n -p ) >doc-nits
if [ -s doc-nits ] ; then cat doc-nits; rm doc-nits ; exit 1; fi
*** WARNING: line containing nothing but whitespace in paragraph at line 19 in file doc/man3/OSSL_STORE_INFO.pod
*** WARNING: line containing nothing but whitespace in paragraph at line 55 in file doc/man3/OSSL_STORE_LOADER.pod
*** WARNING: line containing nothing but whitespace in paragraph at line 12 in file doc/man3/OSSL_STORE_open.pod
make: *** [doc-nits] Error 1

This is already part of #3860 FWIW

This is already part of #3860 FWIW

OK, close this one.


Execute the preprocessing script

@thuhoainguyen I just fixed the code so now you can run it entirely. To run the code, go to the project root folder FBK/kits23 (remember NOT 'FBK/kits23/kits23') and run:
To update the code:
git pull

To activate the virtual environment:
source venv/bin/activate

To update libraries:
pip3 install -e .

To execute preprocessing:
python3 segmentation/segmentation_preProc.py

And it will run. The info will be printed on the terminal. You can inspect the results by looking at segmentation/results/<datetime> the folder  in format of the time you execute the code. Inside that folder are the results.
Tips: you you want to stop the code in the middle of the process, press keys Ctrl + C (or Cmd + C in Mac maybe...). Inside the results/<datetime> folder there's also a file .log saved all the info of the python running process (I made for you as a gift, because I know that you will close the terminal and all the info of the running process will be gone).


Fix errors in the README

@benedictflorance Please fix the DCO sign.

How do I add the missing DCO sign now? Kindly help.

DCO sign has been fixed.


log runtime handler together with pod and container configs

Signed-off-by: Maksim An<EMAIL_ADDRESS>

@kevpar Can you check this in?

ping again, just needs someone to check it in. @katiewasnothere @kevpar


Behind reverse proxy https, mixed content Warning

Hello!
Trying to run this behind a reverse proxy to serve with https but im getting the same issues as described here: https://github.com/MasterEvarior/cocopasty/issues/5 . Nothing gets saved.
When checking the browser console for errors i can see edge/chrome throwing mixed content warnings and not allowing the connection to the backend since its http.
If i add the proxy conf with: add_header 'Content-Security-Policy' 'upgrade-insecure-requests'; so all http calls are upgraded to https i instead get SSL errors in the console which results in also nothing getting saved.
Anything that can be done regarding to this, thanks!

Hi there
I'm currently on vacation and after that moving houses. So I won't be able to response or change any code in timely fashion.
Can you provide screenshots of the mixed content warning?  I will take a look at them as soon as I can ( may take a while tough)


Enhancement

switch for initializing Animated has been removed, it's cleaner and also safer.
React.Children.toArray(children) will calculate only once.
arrow functions has been removed from JSX elements, for performance.

sorry for sending all this in one PR.

@sijad Do you see the same thing? :)

As you can see in screenshot some items are cropped at the bottom of the list.

has this enhancement been merged? I am facing the same issue.

@jahnavi310 Do you have the problem with the latest release?


Potential Issue on IE 11 and data object declaration as function

Version
2.4.2
Reproduction link
https://jsfiddle.net/jvilomar/gvsukfa3/1/
Steps to reproduce

Create a component
Declare the data option as a function inside the component, as especified by the docs.
Run on IE 11

What is expected?
The component should render without any issue on IE 11.
What is actually happening?
The component breake the code.  The error on the console said Invalid Character at the data declaration line.

I was just building some demos and by coincidence had to run the app on IE and suddenly the app stop working.
Some Points:

I don't use any transpiler, just a pure JS function and Loaded the vue.js library from the cdn.
Didn't tested on earlier IE version or Firefox.
Works perfectly on Chrome and Edge.

The problem is more likely that your template definition uses template literals which don't work in IE11

Yes Sir.
Changed to normal string and It worked.  I think that I will have to use babel in orther to avoid some of that errors, since I have to rely heavily on IE for my customers.
Thanks for the reply.


Add DisplayList implementation details

Codecov Report

Merging #179 (3f9ce31) into master (a6c6550) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage     71.70%   71.70%
  Complexity      731      731
=========================================
  Files            99       99
  Lines          2110     2110
  Branches        277      277
=========================================
  Hits           1513     1513
  Misses          489      489
  Partials        108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c6550...3f9ce31. Read the comment docs.


Binary sensor removed from Xiaomi Mija door sensor after update to 0.95.0

Home Assistant release with the issue:

0.95.0
Last working Home Assistant release (if known):
0.94.4
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io
Component/platform:

ZHA
Description of problem:
Removed binary sensor in sensor quirk "zhaquirks.xiaomi.mija.sensor_magnet.Magnet".
In sensor "zhaquirks.xiaomi.aqara.magnet_aq2.MagnetAQ2" binary sensor ok
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

The contact sensors should still have their binary sensors. I have both of these on dev still and they both have their binary sensors still. Buttons / remotes had the sensors removed intentionally. Can you provide a screenshot of the device in the config panel that is missing the sensor and can you also check “unused entities” in Lovelace to ensure that something didn’t cause the entity id to change?

I tried to reconnect the sensor - it did not help.
[0x610b:1:0x000a] ZCL request 0x0000: [[0]]
[0x610b:1:0x000a] Unexpected ZCL reply 0x000b: [1, <Status.SUCCESS: 0>]
Device 0xd092 (00:15:8d:00:02:73:6f:62) joined the network
Device 00:15:8d:00:02:73:6f:62 changed id (0xcf17 => 0xd092)
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
Checking quirks for LUMI lumi.sensor_magnet (00:15:8d:00:02:73:6f:62)
Considering <class 'zhaquirks.xiaomi.mija.sensor_magnet.Magnet'>
Fail because device_type mismatch on at least one endpoint
Considering <class 'zigpy.quirks.smartthings.SmartthingsMultiPurposeSensor'>
Fail because device_type mismatch on at least one endpoint
Considering <class 'zhaquirks.centralite.3315S.CentraLite3315S'>
<class 'zhaquirks.centralite.3315S.CentraLite3315S'> signature update is required. Support for `signature = {1: { replacement }}` will be removed in the future releases. Use `signature = {'endpoints': {1: { replacement }}}
Fail because endpoint list mismatch: {1, 2} {1}
Considering <class 'zhaquirks.centralite.3320.CentraLite3320'>
<class 'zhaquirks.centralite.3320.CentraLite3320'> signature update is required. Support for `signature = {1: { replacement }}` will be removed in the future releases.  Support for `signature = {1: { replacement }}` will be removed in the future releases. Use `signature = {'endpoints': {1: { replacement }}}
Fail because device_type mismatch on at least one endpoint
Considering <class 'zhaquirks.xbee.xbee3_io.XBee3Sensor'>
Fail because endpoint list mismatch: {232, 230} {1}
Considering <class 'zhaquirks.xbee.xbee_io.XbeeSensor'>
Fail because endpoint list mismatch: {232, 230} {1}
Considering <class 'zhaquirks.xiaomi.mija.smoke.MijiaHoneywellSmokeDetectorSensor'>
Fail because device_type mismatch on at least one endpoint
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=1 value=<TypeValue type=uint8_t, value=10>>]]
[0xd092:1:0x0000] Attribute report received: app_version=10
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=65282 value=<TypeValue type=LVList, value=[<TypeValue type=Bool, value=Bool.true>, <TypeValue type=uint16_t, value=3055>, <TypeValue type=uint16_t, value=424>, <TypeValue type=uint40_t, value=0>, <TypeValue type=uint16_t, value=12>, <TypeValue type=uint8_t, value=87>]>>]]
[0xd092:1:0x0000] Attribute report received: 65282=[<TypeValue type=Bool, value=Bool.true>, <TypeValue type=uint16_t, value=3055>, <TypeValue type=uint16_t, value=424>, <TypeValue type=uint40_t, value=0>, <TypeValue type=uint16_t, value=12>, <TypeValue type=uint8_t, value=87>]
skipping discovery for previously discovered device: 00:15:8d:00:02:73:6f:62 - is rejoin: True
LUMI lumi.sensor_magnet: started configuration
LUMI lumi.sensor_magnet: channel: zdo-LUMI lumi.sensor_magnet_ZDO async_configure stage succeeded
0xcf17:1:0x0000: finished channel configuration
0xcf17:1:0x0001: finished channel configuration
LUMI lumi.sensor_magnet: channel: power-0xcf17:1:0x0001 async_configure stage succeeded
0xcf17:1:0x0005: finished channel configuration
LUMI lumi.sensor_magnet: channel: scenes-0xcf17:1:0x0005 async_configure stage succeeded
0xcf17:1:0x0006: finished channel configuration
LUMI lumi.sensor_magnet: channel: event_relay-0xcf17:1:0x0006 async_configure stage succeeded
0xcf17:1:0x0008: finished channel configuration
LUMI lumi.sensor_magnet: channel: event_relay-0xcf17:1:0x0008 async_configure stage succeeded
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
initializing channel: basic from_cache: False
LUMI lumi.sensor_magnet: channel: basic-0xcf17:1:0x0000 async_configure stage succeeded
LUMI lumi.sensor_magnet: completed configuration
LUMI lumi.sensor_magnet: stored in registry: ZhaDeviceEntry(name='LUMI lumi.sensor_magnet', ieee='00:15:8d:00:02:73:6f:62', last_seen=1561649327.5701854)
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xb75c:1:0x0400] ZCL request 0x000a: [[<Attribute attrid=0 value=<TypeValue type=uint16_t, value=40>>]]
[0xb75c:1:0x0400] Attribute report received: measured_value=40
[0xb75c:1:0x0406] ZCL request 0x000a: [[<Attribute attrid=0 value=<TypeValue type=bitmap8, value=1>>]]
[0xb75c:1:0x0406] Attribute report received: occupancy=1
Updated alarm state: 1
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
Updated alarm state: 0
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0x610b:1:0x000a] ZCL request 0x0000: [[0]]
[0x610b:1:0x000a] Unexpected ZCL reply 0x000b: [1, <Status.SUCCESS: 0>]
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet
[0xd092:1:0x0000] ZCL request 0x000a: [[<Attribute attrid=5 value=<TypeValue type=CharacterString, value=lumi.sensor_magnet>>]]
[0xd092:1:0x0000] Attribute report received: model=lumi.sensor_magnet

Experiencing same issue, door sensors gone and controlling lights as well (Ikea) Tried readding. No luck

@dmulcahey
Considering <class 'zhaquirks.centralite.3315S.CentraLite3315S'>
<class 'zhaquirks.centralite.3315S.CentraLite3315S'> signature update is required. Support for `signature = {1: { replacement }}` will be removed in the future releases. Use `signature = {'endpoints': {1: { replacement }}}
...
Considering <class 'zhaquirks.smartthings.tag_v4.SmartThingsTagV4'>
<class 'zhaquirks.smartthings.tag_v4.SmartThingsTagV4'> signature update is required. Support for `signature = {1: { replacement }}` will be removed in the future releases. Use `signature = {'endpoints': {1: { replacement }}}

Should zha-quirks package version be bumped?
Another thing that doesn't make sense, per log I don't see a Quirk replacement matched, yet in devices it shows quirks applied.

I’ll bump and PR it today.

@RunarG3 are all your door sensors Xiaomi Mija sensors? Lights don't have binary_sensors. If you have any issues, it sounds to be a different issues, so you should open it and submit all relevant information, including models/manufacturers of the sensors gone and debug log.

They Are Xiaomi Aqara, and the binary sensors disapeared, ONLY showing zha.(name) . I know lights are not binary sensors, and zigbee lights still show. But I thought maybe that info about them not working would help.

With the Xiaomi Aqara sensors, I'm fine.

@RunarG3 can you go to ZHA config panel, select Basic cluster and get: manufacturer and model attributes? You may have to press the button on the device, to awake it in order to read the attr.

The Mija magnet does in fact have an issue. The above referenced PR will correct it. Sorry about that!

Thanks!

The Mija magnet does in fact have an issue. The above referenced PR will correct it. Sorry about that!

I have a similar issue with a Keen Temperature Sensor, which is a rebranded Xiaomi Aqara Temp/Humidity Sensor.

Will the PR correct this as well?

@curt7000 No, the issues aren’t related. Please open a new issue and describe your problem in detail please.

@curt7000 No, the issues aren’t related. Please open a new issue and describe your problem in detail please.

OK.  New issue opened at https://github.com/home-assistant/home-assistant/issues/24860
Thanks!