BUG FIX deviceSpecimenType incorrectly recorded

Related Issue or Background Info

fixes #3236

Changes Proposed

fix variable name

Additional Information

this is a temporary fix, there will be a follow up ticket that will remove all gql queries and replace it with codegen query/mutations since that will provides a better validation of the variable names

Screenshots / Demos
Checklist for Author and Reviewer
Infrastructure

[X] Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Design

[X] Any UI/UX changes have a designer as a reviewer, and changes have been approved
[X] Any large-scale changes have been deployed to test, dev, or pentest and smoke-tested by both the engineering and design teams

Content

[X] Any content changes (including new error messages) have been approved by content team

Support

[X] Any changes that might generate new support requests have been flagged to the support team
[X] Any changes to support infrastructure have been demo'd to support team

Testing

[X] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[X] Database changes are submitted as a separate PR

[X] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[X] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[X] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback
[X] Each new changeset has a corresponding tag

[X] GraphQL schema changes are backward compatible with older version of the front-end

Security

[X] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[X] Any dependencies introduced have been vetted and discussed

Cloud

[X] DevOps team has been notified if PR requires ops support
[X] If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

terraform plan is showing a scaling change from 2 instances to 4. This is due to our weekend scaling rules in effect, and can be safely ignored. LGTM!


[CircleGraph] Disable show node properties window

This will disable showing node properties window when clicked.

click is changed to toggle selection of the node

ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

from draft #482
this change is to provide multiple selection feature


Feature proposal: Copy aria-label attribute to select 2 input field

Currently if you set an aria-label attribute on your select menu for a multiple select, the aria-label is not copied to the select2 input field. It would be useful if this could be copied for improved accessibility.

+1 When checking for WCAG compliance, I noticed that all of those inputs lack a label. I have not yet found a workaround for this.
I'd also like to see the aria-labelledby attribute copied from the original <select> to the select2 <input>.
Example

<select id="my_select" aria-labelledby="my_select_label">...</select>
...
<input class="select2-search_field" aria-labelledby="my_select_labe">

Hi @dagoss ,
I am not sure how your hack worked for you but its not worked for me. But thanks for the idea you gave.
I have got issue "Label text is empty." while checking for WCAG 2.0 AAA compliances. When I digged into, I found that there is no  for the <input type="search"... created. So I have created label dynamically from jQuery by following code -
jQuery(document).ready(function () {
    jQuery(".select2-search__field").each(function () {
        var select_name = "select2-search__field_" + jQuery(this).attr("aria-labelledby");
        // add attribute ID = "select2-search__field_" + its label id
        jQuery(this).attr("id", select_name);
        // find parent
 and add label for="select2-search__field_" + its label id
        jQuery(this).closest("li.select2-search").append('Test
');
    });
});

I have added label in parent  but if you have any other tag then you can replace that.
Thanks and appreciate your efforts.

@Sachin4dotnet It probably didn't work for you because my jquery selector was looking for a container .form-group (I'm using Bootstrap).

Reopening this since I think it's a valid accessibility request for Select2.

Reopening this since I think it's a valid accessibility request for Select2.

Hi is there a way to set attributes tabindex & aria-hidden on a multiple select, to improved accessibility?
<select class="select2-hidden_accessible" tabindex="-1" aria-hidden="true">
to have
tabindex="0" aria-hidden="false".
As @dagoss mentioned above

Aside: I don't really understand the point of .select2-hidden_accessible on the original  element because it also gets tabindex="-1" and aria-hidden="true".

+1 for this issue, it is very important under new accessibility laws for European Union, possibly California and others.

I'm pretty sure the tabindex property is already copied over:
https://github.com/select2/select2/blob/cd545a4794461d835040d0140d6820f862bf5ca7/src/js/select2/selection/base.js#L24-L31

Aside: I don't really understand the point of .select2-hidden_accessible on the original <select> element because it also gets tabindex="-1" and aria-hidden="true".

Because browsers suck at consistency so we need to allow screen readers to be able to focus on the original <select> so we can re-route it appropriately. We try our best to get it to disappear as much as possible for screen readers but taking it out of the document flow seemed to really mess them up, so we hide it off screen instead. Long history there.

This feature request remains open, likely expanding the scope to reasonable ARIA attributes and not just the original aria-label request.

Has this issue been addressed yet?

I was able to tackle this using the Adapters. Had to write my own "ariaLabelledbyAdapter" and then override the bind() method in case of DropdownAdapter and had to override update() method for SelectionAdapter to get it working.


Preview File ?

Is your feature request related to a problem? Please describe.
Nope. i just want to say can you make some folder preview for it and also preview from other file?
Describe the solution you'd like
Describe alternatives you've considered
Additional context

yes .. like Windows Explorer, which makes it easier for users to find out files more easily and can see a little preview of each file and folder

Duplicate of #3326.


Linux friendly manpage generation

I'm using picocli for my project, and I would like to create manual page for it.
Is there any recommended approach to generate a manual page for standard linux's command man ?
Issue type, depending on possibilities: question, feature suggestion, or article/documentation improvement request.

That’s a great idea!
We can add a DocGen class that generates documentation from a CommandSpec in various formats. The first format could be manpage.

See also #299, which suggests using pandoc for this.
Do you feel like providing a PR for this?

All good points.

a new artifact is a good idea. I’m thinking info.picocli:picocli-docgen. Let’s make a new module for this in the picocli project.
package: I’m thinking picocli.docgen
class DocGen (no need to extend anything)
one idea is to have a static method generateDocs(String contentType,  CommandSpec spec) : String.

The idea/hope is that content type (mime type) would make it extensible: ”text/html” for HTML, etc. Not sure if this is a good idea. Do markdown and man pages have a standard mime type, for example?
Also not sure what the return type of the method should be. Either return a String, or void and print to standard out?
Thoughts?

Also, output type can be DocBook SGML, which can be then converted to manpage using docbook-to-man

And, so you think of whole new artifact, and/or github project? Or, what's yours idea about new artifact picocli-docgen.

I was thinking to create a module picocli-docgen in the picocli project. The build would create a new picocli-docgen-x.x.x.jar in addition to the picocli-y.y.y.jar. No need for a new GitHub project. The picocli-docgen module may have external dependencies in addition to depending on picocli.
About the DocGen API, what you’re saying makes a lot of sense. We can evolve this over time, I would be surprised if we got it perfectly right from the beginning. :-)

About mine type for man pages:

Currently, troff documents are listed under the nonstandard application/x-troff and text/x-troff.  However, the IANA approved the standard text/troff MIME type on 2005-06-10.

according to https://bugs.freedesktop.org/show_bug.cgi?id=5072

I will rename the existing examples module to picocli-examples.
If you want, I can create a docgen branch and add a picocli-docgen module in that branch. That may make it easy to work together on this.

Perhaps doxygen is a good tool to use for this ticket.
Alternatively we can just generate raw man groff macros. This page and this page show some examples. It looks reasonably straightforward.
@kravemir Are you still interested in this? Should I go ahead and create the picocli-docgen module?

@remkop: yes, I'm interested in this. It's on my todo-list, but there are still some task before this. One was to create picocli debian package and get it uploaded to debian official repositories.
I saw readme, and thanks for attribution :-) Though, if you want to refer me on debian, you can use https://udd.debian.org/dmd/?kravec.miroslav%40gmail.com or https://qa.debian.org/developer.php?login=kravec.miroslav%40gmail.com.
And, regarding this feature. I thought about first implementing some solution directly for my tool, then make it as reusable solution, and create PR for picocli containing the implementation.

Understood. Thank you again for creating the debian package! I updated the links on the README page, let me know if these links need further correction.
About this ticket, glad to hear you are still interested.
Feel free to create a picocli-docgen module (#498) as part of the PR if this module does not exist by then.

Also, output type can be DocBook SGML, which can be then converted to manpage using docbook-to-man

I think DocBook is a very flexible way to support multiple output formats.
You should even consider generating an AsciiDoc document, which then can be converted to manpages directly (or HTML or PDF) or to DocBook which in turn can be converted to other formats.
There exists the https://github.com/asciidoctor/asciidoctorj project to parse or convert AsciiDoc documents programmatically.
AsciiDoc is very easy to write for humans (also and very readable), however I don't know how easy it is for a machine to generate AsciiDoc or whether AsciidoctorJ provides an API to create AsciiDoc documents.

A description on how to do it via commandline is given in
https://asciidoctor.org/docs/user-manual/#man-pages.
As far as I know, AsciidoctorJ also supports this.
There are some restrictions on the format of the AsciiDoc document, but that shouldn't be a problem.

An initial version of picocli.codegen.docgen.manpage.ManPageGenerator has landed in the picocli-codegen module in master.
You can test by checking out the latest master and building with:
gradlew clean publishToMavenLocal

That should publish picocli-4.2.0-SNAPSHOT to your local .m2 Maven cache. You can then try this in a project that uses the info.picocli:picocli:4.2.0-SNAPSHOT dependency.
Here is an example Gradle build.gradle snippet:
dependencies {
    compile "info.picocli:picocli:4.2.0-SNAPSHOT"
    annotationProcessor "info.picocli:picocli-codegen:4.2.0-SNAPSHOT"
}

mainClassName = "my.pkg.MyCommand"

task generateManpageAsciiDoc(type: JavaExec) {
    dependsOn(classes)
    group = "Documentation"
    description = "Generate AsciiDoc manpage"
    classpath(configurations.compile, configurations.annotationProcessor, sourceSets.main.runtimeClasspath)
    main 'picocli.codegen.docgen.manpage.ManPageGenerator'
    args mainClassName, "--outdir=${project.buildDir}/generated/docs"
}

apply plugin: 'org.asciidoctor.convert'
asciidoctor {
    dependsOn(generateManpageAsciiDoc)
    sourceDir = file('src/docs/manpage')
    outputDir = file('build/docs')
    logDocuments = true
    backends 'manpage'
}

The generateManpageAsciiDoc task generates xxx.adoc files in build/generated/docs for each command and subcommand.
The asciidoctor task converts adoc files in src/docs/manpage to xxx.1 manpage files in build/docs/manpage/.
Note that the sourceDir for the asciidoctor task is the src/docs/manpage directory. In this directory, I have a manually maintained xxx.adoc file for each command and subcommand, to allow me to customize the resulting manpage.
In the manually maintained xxx.adoc files you can use AsciiDoctor's include mechanism. If you simply want to add some sections to the end of the page, you can pull in the full generated page with the generated-manpage tag, like this:
// src/docs/manpage/xxx.adoc
:includedir: ../../../build/generated/docs
include::{includedir}/xxx.adoc[tag=generated-manpage]

== Authors
My, myself and I.

It is also possible to include the picocli-generated sections individually, so that the generated sections can be customized with additional text that follows the generated text for the section. For example:
// src/docs/manpage/yyy.adoc
:includedir: ../../../build/generated/docs
include::{includedir}/yyy.adoc[tag=generated-man-header]

include::{includedir}/yyy.adoc[tag=generated-man-name-section]

This is a very good tool.

include::{includedir}/yyy.adoc[tag=generated-man-synopsis]

*mycommand* [-hVv] [a=VERY] [--different=synopsis]

include::{includedir}/yyy.adoc[tag=generated-man-description]

Here are some additional description lines.

include::{includedir}/yyy.adoc[tag=generated-man-arguments]

include::{includedir}/yyy.adoc[tag=generated-man-options]

include::{includedir}/yyy.adoc[tag=generated-man-commands]

include::{includedir}/yyy.adoc[tag=generated-man-exit-status]

include::{includedir}/yyy.adoc[tag=generated-man-footer]

[%hardbreaks]
Here is an extra example:
abc def ghi jkl mno pq
abc def ghi jkl mno pq
abc def ghi jkl mno pq

== Authors
All of us.

== Copyright
Just hand it out, it's fine.

(These tag names may be changed before the picocli 4.2.0 release.)
Of course, the asciidoctor task could also simply take the generated build/generated/docs as input directly if no customization is needed.
Known issues:

custom option sections (arggroup option sections) are still ignored
embedded markup like @|bold hello|@ is rendered as ANSI escape codes and not yet converted to AsciiDoc markup

Feedback welcome!

@kravemir, @hupfdule,  All,
picocli 4.2.0 has been released, including this functionality. Enjoy!


Add type for D1Result meta

Hi :wave:
The published types for D1Result currently have meta defined as any, and error defined as never:
https://github.com/cloudflare/workerd/blob/713d9824a4cbc988d6a622813a3087b6a894650f/types/defines/d1.d.ts#L1-L6
This PR aims to clean them up, based on the binding types:
https://github.com/cloudflare/workerd/blob/713d9824a4cbc988d6a622813a3087b6a894650f/src/cloudflare/internal/d1-api.ts#L9-L14
the binding mapper function:
https://github.com/cloudflare/workerd/blob/713d9824a4cbc988d6a622813a3087b6a894650f/src/cloudflare/internal/d1-api.ts#L302-L316
the client API docs:
https://developers.cloudflare.com/d1/platform/client-api/#return-object
and Q5 in the pricing FAQ:
https://developers.cloudflare.com/d1/platform/pricing/#frequently-asked-questions
cc @geelen and @mrbbot per git blame

Shall we merge?

@dom96 I have a test worker here which returns all the meta properties: https://d1-meta-test.danifoldi.workers.dev
According to that there is even more available metadata, so I believe @mrbbot asked in internal chat about those to confirm which ones they intend on keeping and should be documented.

We’re still discussing this internally. Hold tight please.

@DaniFoldi do you mind undoing the removal of error?: never;? I can fix that up separately - we're happy with the meta update

Yup, I pushed a change reverting that 💯


Social Media handles (for the front page) don't save.

I've been getting this error for a while now, not sure why :/

Can reproduce

Confirmed, has to do with the CSRF token


⚠ Bofrost.at has degraded performance

In a058538, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1328 ms

Resolved: Bofrost.at performance has improved in 5e90d8a.


Gzip large response objects

Use gzipping to compress responses
* Note: make sure the frontend server also uses gzipping

https://damyanon.net/post/flask-series-optimizations/
Seems awfully simple. The frontend does use gzipping, this is taken care of using the compression middleware:
app()
  .use(
    ...
    compression({ threshold: 0 }),
    ...
  )

Do we even need Gzipping in the backend? JSON payloads are nothing compared to the HTML/CSS/JS served by the frontend

Yeah, we don't


Add basic tests for kvrocks2redis

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
So that we're sure that the fundamental functions of kvrocks2redis work well.
Solution
@git-hulk I'm still counting on you to understand how to use kvrocks2redis. So that we can add some gocase to cover those usages.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

It should be hard to add Go test cases for this tool but can add a fixed dataset to make sure it works well with those data types.

OK, let me add a how-to-use kvrocks2redis doc first.

OK, let me add a how-to-use kvrocks2redis doc first.

@git-hulk do you have a plan or estimate on this ticket?

@tisonkun Yes, I wonder if I should refactor this tool since it's NOT easy to maintain now. But I haven't started it yet. Plan to do that at the beginning of May, after I release the first version of the controller: https://github.com/KvrocksLabs/kvrocks_controller/issues/49

@git-hulk can you provide some basic how-to-use info here so that I can follow up?

@git-hulk can you provide some basic how-to-use info here so that I can follow up?

Sure, thanks. Sorry for forgetting this, I'll add the how-to-use doc this week first.

Related to https://github.com/apache/kvrocks-website/pull/138.

I also created another issue #1643 to track improvements of kvrocks2redis.


Add vfuncs to WidgetImpl

These are some vfuncs that I previously added manually into my subclasses and are still missing.

realize
unrealize
map
unmap
motion_notify_event

I've verified that realize and unrealize work as intended. Map and unmap are mostly the same, and should work. I'm not entirely sure about motion_notify_event however, in particular about passing the second argument and whether it should really be mutable.

I've applied the suggested changes and renamed a variable for clarity. The CI came up red before because of what looked like a network error to me. I just wanted to mention that too.

The CI came up red before because of what looked like a network error to me

Happens :)

@GuillaumeGomez good to go once the CI is happy :) Thanks @tsahyt !

@GuillaumeGomez time to merge :)


Crash opening some Vulkan frame dumps (1.0, sample framedump included)

Description
When loading some frame dumps of my emulator PPSSPP, RenderDoc crashes immediately.
Repro steps
Load the following dump in RenderDoc: http://www.ppsspp.org/unofficial/godofwar.rdc
Environment

RenderDoc build: 1.0
Operating System: Windows 10
API: Vulkan
Geforce driver: 391.01

The capture you posted was captured on a GTX 770, and the closest hardware I have is a GTX 970 which is unfortunately not compatible (running on a similar driver, 391.35, I get different memory requirements on load which break it.
Are you able to capture on different hardware? Or else could you email me so we can see if I can find some other way to repro the problem?

I'll try to get a capture on Geforce 940MX shortly.

Caught one on the 940MX that crashes.
http://ppsspp.org/unofficial/godofwar_940mx.rdc


Small change to allow major version to be bumped

Background
I forgot to bump the Major version and need a PR to do it!!

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.

Fixes https://github.com/OctopusDeploy/Issues/issues/8229

Fixes https://github.com/OctopusDeploy/OctopusTentacle/issues/547

Related to https://github.com/OctopusDeploy/Issues/issues/8229


👨💻 Add types declaration file

Closes #17
It should be good for the initial types.
I do not change the package.json since this package provide both cjs and esm.
Having the types field may get things weird in types resolving.
.d.cts should match .cjs and .d.ts should match .js automatically.

@dr-dimitru Can you double check the current types if it meet the actual implementation?


Refactor MainWindow

Pull Request Test Coverage Report for Build 853

57 of 80 (71.25%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 84.367%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/ui/MainWindow.java
2
3
66.67%

src/main/java/seedu/address/ui/MainDisplay.java
23
32
71.88%

src/main/java/seedu/address/ui/test/TriviaTestPlaceholderPage.java
16
29
55.17%

Totals

Change from base Build 779:
0.2%

Covered Lines:
2585

Relevant Lines:
3064

💛  - Coveralls


Anypoint mq 3.x

@alegmarra - please review my edits to your new MQ v3 connector docs. These were published to the Beta site today.
@fermujica - We need to figure out how to merge this. It's unclear whether we can have subfolders in the pages folder. Please see @george-hoffer comments in slack.

@alegmarra @george-hoffer @hannanelson Per Meeta's request, please do not merge this PR. We have not yet determined how to handle versioned connectors on our site. This is a high priority project, but we are not ready to implement any solutions.

@hannanelson The subfolders are supported in the site.
This previews like this:

But there are a few of broken internal references that need to be fixed before we can accept this change:
repo: https://github.com/mulesoft/docs-connectors | branch: anypoint-mq-3.x | component: connectors | version: master
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-ack.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-consume.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-ack.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-listener.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-connector.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-publish.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-connector.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-consume.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-connector.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-listener.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-connector.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-ack.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-connector.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-connector-reference.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-consume.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-ack.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-consume.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-connector-reference.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-listener.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-connector-reference.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-listener.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-ack.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-listener.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-consume.adoc
  path: modules/ROOT/pages/anypoint-mq/2.x/anypoint-mq-publish.adoc | xref: anypoint-mq/2.x/anypoint-mq/anypoint-mq-listener.adoc

repo: https://github.com/mulesoft/docs-mq | branch: latest | component: mq | version: master
  path: modules/ROOT/pages/mq-ack-mode.adoc | xref: connectors::anypoint-mq/anypoint-mq-ack.adoc
  path: modules/ROOT/pages/mq-connectors.adoc | xref: connectors::anypoint-mq/anypoint-mq-connector.adoc
  path: modules/ROOT/pages/mq-connectors.adoc | xref: connectors::anypoint-mq/anypoint-mq-ack.adoc
  path: modules/ROOT/pages/mq-connectors.adoc | xref: connectors::anypoint-mq/anypoint-mq-listener.adoc
  path: modules/ROOT/pages/mq-connectors.adoc | xref: connectors::anypoint-mq/anypoint-mq-consume.adoc
  path: modules/ROOT/pages/mq-connectors.adoc | xref: connectors::anypoint-mq/anypoint-mq-publish.adoc
  path: modules/ROOT/pages/mq-connectors.adoc | xref: connectors::anypoint-mq/anypoint-mq-connector-reference.adoc

antora: xref validation failed! See previous report for details.

@fermujica - when did you run this build? I fixed all the broken links in my last commit (or at least all the ones in my local build).


[Feature] Add Pagination

Is your feature request related to a problem? Please describe.

Currently, all the blog posts are lined up one after another, which may incur in the home page becoming longer and longer with time and more number of posts being posted in the future.

Describe the solution you'd like

So, to solve this issue, pagination feature can be added with which a fixed number of posts will be shown on the home page and rest would be saved for other pages which will result in concise and clear homepage experience for all the users.

Hey, I am interested to work on this issue. Can I start to work.
@harsh-9in , @Kajol-Kumari

Hey @ManishShah120 instead of pagination, can you please change it to left and right slider having 1/2 posts in it ? It would look better this way.
Reference: https://www.jssor.com/
\cc: @harsh-9in @Swarnimashukla

I see🤔 this would be much better than pagination. Okay, assign me with the required labels.

@ManishShah120 please edit the issue description accordingly, I am assigning it to you.

Is it Okay Now, @Kajol-Kumari


Update InterPro in nightly load

https://www.ebi.ac.uk/interpro/release_notes.html

I've updated the InterPro input file.  I'll check the load on Wednesday morning.

All looks good.  We've now using InterPro 73.0

News item (very short)

[ ] InterPro Update
"PomBase is now using InterPro Version 73:0. InterPro 73.0 integrates 1,531 new methods from the CATH-Gene3D (122), CDD (330), PANTHER (1075), Pfam (2), PROSITE profiles (1) and TIGRFAMs (1) databases, and covers 81.2% of UniProt Knowledgebase release 2019_02.
See https://www.ebi.ac.uk/about/news/service-news/InterPro-73.0 for the release notes.

[ ] Retweet. PomBase now includes InterPro V 73:0
https://twitter.com/InterProDB/status/1111216956869357568

NEW TICKET for news item because it's a different task

The announcements have always been part of the task so far but hey ho...


Fatal error: Class 'Facebook\WebDriver\Firefox\FilesystemIterator' not found

File: lib/Firefox/FirefoxProfile.php on line 160 contains reference to FilesystemIterator class with invalid namespace.
Fixes are either to add a 'use' clause or prepend the reference with absolute namespace path (in this case, simple '').

Fixed by @black-silence, will tag a new version for this correction.  Sorry!


modify platform openstack

add the platform to operating system in order to enable on grub.cfg the kernel args platform.id=openstack required for metal3 workflow

I don't think this is the right approach to expose this single kernel argument as a top level config item. I'm not sure if we'd have other platforms besides OpenStack, but if we don't, then I don't think it makes sense to make this an open variable that may only have on value.
We've had on the roadmap to be able to pass in arbitrary kernel arguments for other reasons. I think that functionality is what will answer this, using the general kernel arg setting for this one-off use case rather than treating this case as a specific config item. I'll prioritize working on that and will hopefully have something in the next few days.

Yes, I think you've got more context than me on the code structure and roadmap of features to be implemented. This PR was only an idea of implementation just to have a quick discussion. I'm gonna close it ;)


Fix compilation under VS 2022.1

This commit fixes the compilation under VS 2022.1 and clang, be evaluating a static_assert(false) safety check only when the template is actually instantiated. This is achieved by making the assertion depend on the template parameter.
Validation Steps Performed

Host.EXE compiles under VS 17.1.0 Preview 3.0 (32110.40.d17.1) ✅

@msftbot merge this in 1 minute

Thanks!


Translate services-networking/service.md in Korean.

This is a Feature Request
What would you like to be added
Translate services-networking/service.md in Korean
Why is this needed
The following files are not translated into Korean.

[ ] /en/docs/concepts/services-networking/service.md

Comments
Page to update: https://kubernetes.io/docs/concepts/services-networking/service/
I am translating this document.
The translated document will be submitted to dev-1.16-ko.7 or dev-1.17-ko.1 branch.
If it is translated very quickly, it is submitted to dev-1.16-ko.6.
/language ko

/assign

There was something that came out first.
#13943


Bug - Entries are not rolling back if error occurs during posting on Bank/Giro Journal

Bug exists on current BC Online (checked on 17.1.18256.19044).
Company CRONUS NL, without addons or extensions.
The journal and lines should be like this:

On the last line there is wrong "VAT Prod. Posting Group". Post it - and you will get the error:
The VAT Posting Setup does not exist. Identification fields and values: VAT Bus. Posting Group='BINNENLAND',VAT Prod. Posting Group='FULL NORM'
Check Customer Ledger Entries, and you will find the entry:

The lines are still exist in journal because of the error, but the entries are not rolling back. This occurs for all ledger entries (Customer, Vendor and G/L).
And you can post this journal again, and the entries will be created.
This bug is not present on versions 16.3 or earlier.

Thank you for reaching out. Your request could be reporting a product bug not related to the AL extensibility. Please reach out to the relevant support channels as specified in Product Support
On premises - https://support.microsoft.com/en-us/supportforbusiness/productselection?sapId=93d37907-ad94-d591-22e9-593cfa09dd3f
On line – read more here https://docs.microsoft.com/en-ca/dynamics365/business-central/dev-itpro/administration/manage-technical-support or contact your partner
If you are a partner open a support incident through Partner Center - https://partner.microsoft.com/en-us/pcv/dashboard/overview


First table of default and min values may be wrong

I think the default values should be 1 and the min values should be 0. The table seems to have these swapped. This is in the very first table at the top of the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58fa8bbe-e0eb-4944-bc60-617aec0c0dde
Version Independent ID: eae53948-3193-a451-5963-3e6cd8ee2972
Content: Scaling in Azure Container Apps
Content Source: articles/container-apps/scale-app.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@krispenner Thank you for your inputs. We have engaged the content team on this to review and update as required.

The default number of replicas has been changed to 0, and the minimum is 0.  I have updated the article.
#please-close


Open Source : 6. Open Source in Gaming

Description 📜
Gaming is a little behind in Open Source especially for modern AAA titles. Open Source technology is being used to make the games , but the game itself maybe closed source
Topics to cover:

Advantages and Limitations
Open Source Game Engines ( Unity , Godot , Love2D)
Current Open Source Games ( 0AD , Xonotic , SuperTuxCart , FreeDOOM , OpenRCS2 )
How to contribute

Domain of Contribution 📊

[x] Open Source

Thanks to @Aryamanz29 for the opportunity for opening this issue

/assign

/assign

PR raised

@pspiagicw Awesome work 🎉🎉


Want to re-design the navigation bar

I want to re-design the navigation bar along with the font used there so that it looks more interactive.

@aslams2020  please label this as "gssoc-extd", "hacktoberfest2024" & "level-1".

I want to work on this issue , can you please assign me this ?


Set Session Parameters

IBM's AppScan security software flagged the session because a base path was not set to restrict the session to the login script, and because HTTPOnly was not set.
This commit adds a new config file where custom session options can be added, and loads those settings as part of the Zend bootstrapping.
The install.md document was modified to reflect the change that needs to be made in the session.ini file

Hi Michael,
Thanks for this patch. We've been moving towards YAML configs--could you use that format for this config as well?

Done. I also made the sessions config optional. If it isn't set, it behaves as it did before the patch. Also updated the install.md document to reflect the preference of using the yaml file.


Custom hook to rebuild Embla in React?

Hi,
I was following the code sandbox for iOS style picker.
For my use case I have to update the carousel items when props change. And when items are updated the styling got messed up and items will no longer snap in the selection box. So I think the only solution is to rebuild embla instance. Is there a custom hook for rebuilding it? If there is none can you give some advice on how to customize it?

Hello @phyominh,
Thank you for your question. Try something along these lines:
const reloadPicker = useCallback(() => {
  if (!embla) return
  setWheelReady(false)
  setWheelReady(() => {
    embla.reInit()
    embla.dangerouslyGetEngine().translate.toggleActive(false)
    setRotation()
    return true
  })
}, [embla, setWheelReady, setRotation])

useEffect(() => {
  reloadPicker()
}, [reloadPicker, /* add your props here as dependency */])

Let me know if it helps!
Best,
David

@phyominh, did you see my response?

@davidcetinkaya Oh, sorry for the late response. I didn't get the notification for the first reply.
Yes, this solves the styling problem. Thank you very much for your answer and thanks for this library. You can close the issue now.

@phyominh no worries, thanks for getting back to me. I'm glad it worked!
I just want to mention that the iOS style pickers didn't render correctly in IE11 (issue #104). When I first created the pickers, I didn't know that IE11 didn't support the following CSS: transform-style: preserve-3d;.
But I've fixed this issue and updated the CodeSandboxes. So in case you need to support IE11, please update your code to match the following sandbox:

iOS Picker (IE11 support)

Kindly,
David


Add queries for zos4 on nodes/farms endpoint

Is your feature request related to a problem? Please describe
some networks are not supported on zos4 so we need queries to filter them.
Describe the solution you'd like
add queries for the node if it supports:

wireguard
yggdrasil
public ips

Also, please add them as fields on the node object
same queries should be added too to the farms' queries

@Eslam-Nawara we have features now which provide these info, right?
plz add docs on how to use it and link it in the issue

after the discussion, i think having a filter features and node_features which takes a list of features and filter the nodes that support it will be more suitable for the usecase.

/nodes?features=network,zmachine,zdb
/nodes?features=zmachine-light,network-light

and in the node response will add the full list of the supported features
no need for wg/ygg/pubIp filters in that case, knowing that network-light nodes doesn't support them.
is that okay?

Verifications

Tried https://gridproxy.dev.grid.tf/nodes?features=zmachine-light,network-light

Got nodes for light deployments

Tried https://gridproxy.dev.grid.tf/nodes?features=network,zmachine,zdb

Got nodes for v3 deployments

Tried https://gridproxy.dev.grid.tf/farms?node_features=zmachine-light,network-light

Got farms supports v4 nodes

Notes

I found a node with ipv4 in ight filter
Not all nodes supports mycelium in light filter too

i suspect it is because some nodes missed the features set update.
checking https://gridproxy.dev.grid.tf/nodes?features=zmachine-light&status=up only the up nodes (2 now) they both have mycelium and not ipv4 as expected
the other down nodes are

1 node in freefarm which last update was 14 days which is before the update
3 nodes are a dev nodes. mostly run from source code which hadn't have the update


[Issue]: Split send Audit / Treasury reports button into separate buttons

Why is this issue important?
Partner have reported they use audit and treasury reports at different times, and would like separate buttons
Current State

Expected State
The send Treasury and Audit report by email button is split into 2 buttons:

"Send Audit Report by Email"
"Send Treasury Report by Email"

Both buttons should display on the Uploads page and be visible only to Admin users (not Staff)
Implementation Plan
No response
Relevant Code Snippets
No response

this is now a duplicate, closing


Google Translator Toolkit shutting down

First of all, thank you for creating an awesome plugin to simplify localization within Flutter! It has been really useful to us so far!
With Google shutting down its Translator Toolkit after December 4th, 2019, I'm wondering what your plan is for this plugin? Will you start directing people to use an alternative (paid) translation tool that supports ARBs such as Crowdin, or will you modify the plugin to use an alternative file format supported by other translation tools? Are there any other i18n tools that anyone can recommend?
We're quickly trying to wrap up some of our translation projects before Translator Toolkit shuts down, but are hoping to sort out an alternative path forward before too long.

You can use Localizely.
They support ARB files, pretty easy to use.


NewApi doesn't support pgxscan

NewApi and its options do not appear to work with pgxscan, only dbscan which would be ok if dbscan accepted pgx rows, but it doesn't. Which means we can't use any of the NewApi options like WithAllowUnknownColumns.
We are using pgx V5 and scany V2
Please confirm if it's intended behaviour, is it just lacking implementation or is it a bug?
Thanks.

Nevermind, I've figured out that it can be done like this
`dbScanApi, err := pgxscan.NewDBScanAPI(dbscan.WithAllowUnknownColumns(true))
if err != nil {
	return err
}

api, err := pgxscan.NewAPI(dbScanApi)

if err != nil {
	return err
}

err = api.Select(t.context, querier, dest, sqlString, args...)

`
I thought pgxscan would accept dbscan options directly, instead it expects a dbscan API.


Program operation error

Hello, an error occurs when the program is running. The error is as follows:  tensorflow.python.framework.errors_impl.InternalError: dnn PoolForward launch failed [Op:AvgPool]

Which version of tensorflow and tensorflow-gpu do you use?

tensorflow==2.3.0

Try upgrading your tensorflow to 2.6 or greater.


gdbstub:typo fix

Summary
typo fix
Impact
gdbstub
Testing
vela

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Masking by latitude (or hemisphere) on top of mask_landsea

I have used the Preprocessor feature mask_landsea and it works well for me. However, is it possible to also mask by latitude on top of it? For instance, I would like to mask the Northern hemisphere sea or land so that I can plot the phenomena in the Southern hemisphere. Another example, I would like to mask everything but the Arctic. Is this capability already built in?

I managed to generate new mask files and add them as an option to the preprocessor.

@hahsan1, great that you solved your problem. You might also consider using the extract region preprocessor.

That's good to know, looks like it could be very useful for masking all but select countries. Thanks!


reason version on opam

The current version of reason on opam is listed as 3.2.0.  When I install it via opam and look at the installed package list it also indicates that I'm running v3.2.0.  However, when I type:
# refmt --version
Reason 3.0.0 @ bee43b0

Indicating to me that the actual version being used by reason installed via opam is version 3.0.0.  Sorry if I'm misunderstanding how reason works but I'm assuming that dune, rtop etc. are using refmt directly.
Thanks,
Jason

Version 3.3 correctly updated the version. When we push 3.3.x to opam, it will be fixed. Thanks for reporting, it's a known temporary issue.


⚠ Site ANTS has degraded performance

In 6b88ff6, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 3166 ms

Resolved: Site ANTS performance has improved in 5083513.


Setting callback after Stream initialisation

We are trying to set the callback after the Stream initialisation, something like below, which doesn't work:
import time
import numpy as np
from pysoundcard import Stream, continue_flag

def callback(in_data, out_data, time_info, status):
    out_data[:] = 0.1 * np.random.rand(*out_data.shape) - 1
    return continue_flag

# This works:
stream = Stream(
    samplerate=44100,
    blocksize=1024,
    callback=callback
)

# This doesnt work:
stream = Stream(
    samplerate=44100,
    blocksize=1024,
)
stream.callback = callback

stream.start()
time.sleep(5)
stream.stop()

This could be useful, for example, to allow the user to setup the audio properties, before handing us the stream to setup the callback and read/write.
Perhaps using properties to set the callback, and only then create the callback_wrapper, could solve this?
class Stream(object):
    def __init__(self, callback=None):
        # We don't need to care about callback_wrapper here anymore
        self.callback = callback

    @property
    def callback(self):
        return self._callback

    @callback.setter
    def callback(self, value):
        self._callback = callback_wrapper(value, something...)

Then from outside you can do
stream.callback = my_callback_function

at any time (before stream.start) to set the callback.

The problem is that the underlying library requires to run either in callback mode or in read/write-function mode. This has to be decided when the Stream is created, and can't be changed later. There's nothing I can do about this on the Python side to change this. Sorry.

Okay, thank you - I didn't realise that! Is it possible to, or worth considering, creating the stream only when the stream is started, if that is the first point where it would be required? I guess this would allow Stream properties to be set and updated, up until the point where the stream actually starts and properties must be fixed?

This would be possible, yes. It would have the disadvantage that the Stream object would report errors only when first used, and those errors would potentially refer to incorrect property values that were set at a different time. I prefer the current behavior where errors are created at the time where the incorrect values were set.
That said, it is probably pretty easy to create a wrapper for the Stream object, that only initializes the object when actually used. This is something you can probably easily do in your own code base. If you want to share it, I could link to it in the README, or even incorporate it in PySoundCard.

Okay, thank you, I understand. We've got a workaround for the moment, but I'll let you know if we end up writing anything worth sharing/incorporating. Cheers


doc doesn't work on stable

Using example on doc with std
use talc::*;

static mut ARENA: [u8; 10000] = [0; 10000];

#[global_allocator]
static ALLOCATOR: Talck<spin::Mutex<()>, ClaimOnOom> = Talc::new(unsafe {
    // if we're in a hosted environment, the Rust runtime may allocate before
    // main() is called, so we need to initialize the arena automatically
    ClaimOnOom::new(Span::from_const_array(core::ptr::addr_of!(ARENA)))
}).lock();

fn main() {
    let mut vec = Vec::with_capacity(100);
    vec.extend(0..300usize);
}

result in
  |
7 | static ALLOCATOR: Talck<spin::Mutex<()>, ClaimOnOom> = Talc::new(unsafe {
  |                         ^^^^ use of undeclared crate or module `spin`

This is intentional: Talc doesn't come with a decent lock out of the box so you're expected to bring your own. The spin crate's spinlocked mutex is a reasonable choice and what the allocator has been tested with.
Below the example you'll find:

Note that while the spin crate's mutexes are used here, any lock implementing lock_api works.

So you'll need to run cargo add spin to get the example to work.
If you think anything should be changed, let me know.

I'm closing this for now as it has been addressed and has since remained inactive. Please feel free to re-open it or open a new commit though.


MySQL integration tests getting stuck

if the MySQL database driver is missing, the following command (which runs MySQL integration tests) takes too long to exit:
pytest "src/tests/integration/test_generic_db_operations.py" -k "ip_with_mySQL"

If the db driver is missing, it should be pretty quick to check that so there's something going on with the integration tests that are causing them to get stuck for some time before showing up the error message.
we need to modify it so the command breaks and displays an appropriate error quickly, so users know they need to install the drivers. Note that there might be other errors as well, so we need to ensure that all the pre-requisites to run MySQL integration tests are documented here.
Note: the comments on this issue are locked. If you need to ask questions, please open a draft PR, tag me and ask your questions.

closing in favor of https://github.com/ploomber/jupysql/issues/730


ci: use  visibility crate for bench

As I got to know the visibility crate, I'm proposing the change to use it.
Alsongside this uses the changes of #46 but using static therefore removing the dependency on lazy_static.

@felipenoris hey mate, any chance of getting this project going again?


UI - Can't log in anymore

ISSUE TYPE

Improvement Request
Documentation Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

4.18.0

CONFIGURATION

OS / ENVIRONMENT

Ubuntu 22.04 LTS
SUMMARY

I set up ACS and tried to play with the config to enable SSL since otherwise I can't upload an ISO. I accidentally set the flag option that forces the https cookie and now I can't log in anymore (I'm still struggling with the SSL configuration and wanted to log in to check some configs). I've been looking everywhere for this configuration option in the files, but can't find it anywhere.
STEPS TO REPRODUCE

EXPECTED RESULTS

My expectation is to be able to find the setting somewhere in the settings file or to be documented in the docs (maybe it is in a mysql table?)

ACTUAL RESULTS

I can't find this setting and the docs are missing information regarding where to find it and how to access all the settings without the use of the UI

@lsabi  could you check if this article helps? https://www.shapeblue.com/securing-cloudstack-4-11-with-https-tls/

I still can't get it to work. The self signed certificate has been successfully installed, as the browser requests me to trust the certificate that cannot be checked (I haven't used a trustworthy CA, since it is just for internal use and tests). Now, the UI gives me error 503, but the logs do not show anything wrong. The server has been restarted several times within today
From /var/log/cloudstack/management/management-server.log
2023-08-07 16:16:44,346 INFO  [o.a.c.ServerDaemon] (main:null) (logid:) Server configuration file found: /etc/cloudstack/management/server.properties
2023-08-07 16:16:44,368 DEBUG [c.c.u.c.EncryptionSecretKeyChecker] (main:null) (logid:) Encryption Type: null
2023-08-07 16:16:44,408 INFO  [o.a.c.ServerDaemon] (main:null) (logid:) Initializing server daemon on null, with http.enable=true, http.port=8080, https.enable=true, https.port=8443, context.path=/client
2023-08-07 16:17:01,599 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [bootstrap] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-<IP_ADDRESS>.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context.xml]
2023-08-07 16:17:01,635 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [bootstrap] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-<IP_ADDRESS>.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context-inheritable.xml]
2023-08-07 16:17:02,143 DEBUG [c.c.u.c.EncryptionSecretKeyChecker] (main:null) (logid:) Encryption Type: file
2023-08-07 16:35:45,189 INFO  [o.a.c.ServerDaemon] (main:null) (logid:) Server configuration file found: /etc/cloudstack/management/server.properties
2023-08-07 16:35:45,204 DEBUG [c.c.u.c.EncryptionSecretKeyChecker] (main:null) (logid:) Encryption Type: null
2023-08-07 16:35:45,244 INFO  [o.a.c.ServerDaemon] (main:null) (logid:) Initializing server daemon on null, with http.enable=true, http.port=8080, https.enable=false, https.port=8443, context.path=/client
2023-08-07 16:36:00,348 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [bootstrap] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-<IP_ADDRESS>.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context.xml]
2023-08-07 16:36:00,351 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [bootstrap] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-<IP_ADDRESS>.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context-inheritable.xml]
2023-08-07 16:36:00,813 DEBUG [c.c.u.c.EncryptionSecretKeyChecker] (main:null) (logid:) Encryption Type: file
2023-08-07 16:54:22,951 INFO  [o.a.c.ServerDaemon] (main:null) (logid:) Server configuration file found: /etc/cloudstack/management/server.properties
2023-08-07 16:54:22,962 DEBUG [c.c.u.c.EncryptionSecretKeyChecker] (main:null) (logid:) Encryption Type: null
2023-08-07 16:54:22,996 INFO  [o.a.c.ServerDaemon] (main:null) (logid:) Initializing server daemon on null, with http.enable=true, http.port=8080, https.enable=true, https.port=8443, context.path=/client
2023-08-07 16:54:35,886 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [bootstrap] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-<IP_ADDRESS>.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context.xml]
2023-08-07 16:54:35,888 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] (main:null) (logid:) Loading module context [bootstrap] from URL [jar:file:/usr/share/cloudstack-management/lib/cloudstack-<IP_ADDRESS>.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context-inheritable.xml]
2023-08-07 16:54:36,263 DEBUG [c.c.u.c.EncryptionSecretKeyChecker] (main:null) (logid:) Encryption Type: file

From /var/log/cloudstack/management/access.log
<IP_ADDRESS> - - [07/Aug/2023:16:56:10 +0000] "GET / HTTP/1.1" 301 0 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 10
<IP_ADDRESS> - - [07/Aug/2023:16:56:10 +0000] "GET /client/ HTTP/1.1" 503 394 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 7
<IP_ADDRESS> - - [07/Aug/2023:16:56:10 +0000] "GET /favicon.ico HTTP/1.1" 301 0 "https://<IP_ADDRESS>:8443/client/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 2
<IP_ADDRESS> - - [07/Aug/2023:16:56:10 +0000] "GET /client/favicon.ico HTTP/1.1" 503 405 "https://<IP_ADDRESS>:8443/client/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 4
<IP_ADDRESS> - - [07/Aug/2023:16:57:48 +0000] "GET /client/ HTTP/1.1" 503 394 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 4
<IP_ADDRESS> - - [07/Aug/2023:16:57:48 +0000] "GET /favicon.ico HTTP/1.1" 301 0 "https://<IP_ADDRESS>:8443/client/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 3
<IP_ADDRESS> - - [07/Aug/2023:16:57:48 +0000] "GET /client/favicon.ico HTTP/1.1" 503 405 "https://<IP_ADDRESS>:8443/client/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" 8

/var/log/cloudstack/management/apilog.log does not contain anything for the past 3-4 days, so it should not be relevant. So does /var/log/cloudstack/management/setupManagement.log

@lsabi
self-signed cerificate could be the root cause

@lsabi hope you were able to solve the issue. You could revert your changes and follow best practices per the blog @rajujith had shared. If you're still blocked, pl raise another issue with steps of reproduction. For questions that aren't bug reports, you can use the Github discussions.


Suggest fix for mappers tagging zoo animals to Wikipedia/Wikidata entries directly

This is related to #6652.
We should suggest automatic fixes that change wikipedia and wikidata tags to species:wikipedia and species:wikidata when someone uses attraction=animal.
This should work 99% of the time, except if it's a really famous individual animal with its own Wikipedia page, or a notable enclosure in a notable zoo. So it should be more of a suggestion that can be dismissed.

So it should be more of a suggestion that can be dismissed.

What should happen if dismissed? There is no way to tag this so it will appear again and again and sooner or later someone will retag it.
Not sure is it viable (from technical viewpoint and from legal due to copyright issues with what Wikidata includes) - but maybe check whatever target wikidata/wikipedia page is classified as an animal?

Not sure is it viable (from technical viewpoint and from legal due to copyright issues with what Wikidata includes) - but maybe check whatever target wikidata/wikipedia page is classified as an animal?

That seems to be the suggestion: checking whether the Wikidata item is tagged as an animal. Not sure how copyright would come into the picture if the result is only that species: would be prepended to the key. Copyright covers published works, but Wikidata would only be used here in the validation step.
A given Wikidata item about an animal species won’t necessarily say that it’s an instance of a species, because there can be multiple subclasses between it and the species item. However, it would be possible to check for a property such as taxon name (P225) or taxon rank (P105).

What should happen if dismissed? There is no way to tag this so it will appear again and again and sooner or later someone will retag it.

Perhaps add not:species:wikidata and a validator warning about species:wikidata contradicting not:species:wikidata?

Perhaps add not:species:wikidata and a validator warning about species:wikidata contradicting not:species:wikidata?

species:wikidata still can be added to a notable enclosure (it would link to what kind of species is inside)

It looks like the wikidata tag is used less than 1000 times with attraction=animal (I didn't look up the exact number). Since we don't always want to move the wikidata value to species:wikidata, we can't use one of iD's existing validation rules. As such, I'm afraid it'd be much more work to write a new rule than to just resolve these all manually.

And if someone is interested in fixing this (and other misused wikidata/wikipedia) manually, with a support from a Python script...
Then I can publish my script that I am using for that (but it requires some actual review and looking at proposed edits, not just blindly pressing "y, edit this").
(hopefully this kind of comment is OK)

but it requires some actual review and looking at proposed edits, not just blindly pressing "y, edit this"

If you need help reviewing these issues, perhaps you could publish it as a MapRoulette challenge but mark it as an advanced task with instructions on what to look for. I’ve created MapRoulette challenges for QA based on SPARQL queries in the past. Unfortunately, Sophox is currently down (Sophox/sophox#24), so scripts like yours are currently the way to go.

I'd love to tackle a maproulette challenge like that.


readthedocs broken for `latest'

In http://ga4gh-schemas.readthedocs.org/en/latest/api/references.html,
there is a link for "See References schema for a detailed reference.",
http://ga4gh-schemas.readthedocs.org/en/latest/schemas/refernces.html
which does not exist.

http://ga4gh-schemas.readthedocs.org/en/latest/schemas/references.html
Works with an e between r & n ;)

this was fixed but not closed


Setting attributes without changing state or times

Version of the schedule_state component
0.19.0
Configuration
default_state: 18
events:
- state: 15
  start: 10:00
  end: 15:00
- state: 20
  start: 15:00
  end: 20:00
- condition:
    - condition: state
      entity_id: binary_sensor.wohnzimmer_fenster
      state: "on"
  window: "open"

Describe the bug
When it's 13:00 and the window is open, the state is 18 and starts from 00:00 to 23:59 instead of the expected 15 from 10:00 to 15:00. Also, the next_state is 18 instead of the expected 20.

Start and end times need to be quoted. This is why it's not working as you expect. Added note in README

Start and end times need to be quoted. This is why it's not working as you expect. Added note in README

Actually you don't, 10:00 is just valid as a string.
And even if quoted, which it actually is in my config, it still doesn't work

I don’t know what to tell you. I have created a unit test that works when the times are quoted and fails when they are not. I am using the same config you provided.

On Dec 17, 2023, at 15:05 , Chris Werner Rau @.***> wrote:
Start and end times need to be quoted. This is why it's not working as you expect. Added note in README
Actually you don't, 10:00 is just valid as a string.
And even if quoted, which it actually is in my config, it still doesn't work
—
Reply to this email directly, view it on GitHub https://github.com/aneeshd/schedule_state/issues/187#issuecomment-1859269729, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATKODJE43XUIS5JRE3KD7TYJ5GBVAVCNFSM6AAAAABAXPGG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGI3DSNZSHE.
You are receiving this because you modified the open/close state.

Please include log files, following the instructions in the documentation. That might help debug the issue. On Dec 17, 2023, at 15:05, Chris Werner Rau @.***> wrote:
Start and end times need to be quoted. This is why it's not working as you expect. Added note in README
Actually you don't, 10:00 is just valid as a string.
And even if quoted, which it actually is in my config, it still doesn't work
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

This is my test.yaml;
platform: schedule_state
name: schedule test
refresh: "00:30:00"
default_state: 18
minutes_to_refresh_on_error: 1
extra_attributes:
  unit_of_measurement: "°C"
  state_class: measurement
  window: "closed"
events:
  - state: 15
    start: "10:00"
    end: "15:00"
  - state: 20
    start: "15:00"
    end: "20:00"
  - condition:
      - condition: state
        entity_id: binary_sensor.wohnzimmer_fenster
        state: "on"
    window: "open"

This is the state with the window closed;
icon: mdi:calendar-check
friendly_name: schedule test
states:
  - "15"
  - "20"
  - "18"
next_state: "20"
start: "10:00:00"
end: "15:00:00"
friendly_start: "10:00:00"
friendly_end: "15:00:00"
errors: []
unit_of_measurement: °C
state_class: measurement
window: closed

This is the state with the window open;
icon: mdi:calendar-check
friendly_name: schedule test
states:
  - "15"
  - "20"
  - "18"
next_state: "18"
start: "00:00:00"
end: "23:59:59.999999"
friendly_start: "00:00:00"
friendly_end: midnight
errors: []
unit_of_measurement: °C
state_class: measurement
window: open

There are no logs for this, even with debug 😅

What are you using to get this info:

This is the state with the window closed;
icon: mdi:calendar-check
friendly_name: schedule test

(etc)
???
schedule_state creates INFO logs in the HA log by default, so you should at least see things like:
INFO     custom_components.schedule_state.sensor:sensor.py:754 schedule test:
{'15': (),
'18': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999)),
'20': ()}
{'state_class': {'measurement': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999))},
'unit_of_measurement': {'°C': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999))},
'window': {'closed': (),
'open': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999))}}
For info on HA logs: https://www.home-assistant.io/integrations/system_log/ https://www.home-assistant.io/integrations/system_log/
To enable schedule_state DEBUG logs: https://github.com/aneeshd/schedule_state?tab=readme-ov-file#on-a-real-ha-instance https://github.com/aneeshd/schedule_state?tab=readme-ov-file#on-a-real-ha-instance
I need at least the INFO logs, preferably the DEBUG logs.

On Dec 18, 2023, at 4:35 , Chris Werner Rau @.***> wrote:
This is my test.yaml;
platform: schedule_state
name: schedule test
refresh: "00:30:00"
default_state: 18
minutes_to_refresh_on_error: 1
extra_attributes:
unit_of_measurement: "°C"
state_class: measurement
window: "closed"
events:

state: 15
start: "10:00"
end: "15:00"
state: 20
start: "15:00"
end: "20:00"
condition:

condition: state
entity_id: binary_sensor.wohnzimmer_fenster
state: "on"
window: "open"
This is the state with the window closed;

icon: mdi:calendar-check
friendly_name: schedule test
states:

"15"
"20"
"18"
next_state: "20"
start: "10:00:00"
end: "15:00:00"
friendly_start: "10:00:00"
friendly_end: "15:00:00"
errors: []
unit_of_measurement: °C
state_class: measurement
window: closed
This is the state with the window open;

icon: mdi:calendar-check
friendly_name: schedule test
states:

"15"
"20"
"18"
next_state: "18"
start: "00:00:00"
end: "23:59:59.999999"
friendly_start: "00:00:00"
friendly_end: midnight
errors: []
unit_of_measurement: °C
state_class: measurement
window: open
There are no logs for this, even with debug 😅

—
Reply to this email directly, view it on GitHub https://github.com/aneeshd/schedule_state/issues/187#issuecomment-1859939170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATKODN6ROPGQ54MMTINGY3YKAE7RAVCNFSM6AAAAABAXPGG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZHEZTSMJXGA.
You are receiving this because you modified the open/close state.

What are you using to get this info:

This is the state with the window closed;
icon: mdi:calendar-check
friendly_name: schedule test

(etc)
???

That's the /developer-tools/state page.

schedule_state creates INFO logs in the HA log by default, so you should at least see things like:
INFO     custom_components.schedule_state.sensor:sensor.py:754 schedule test:
{'15': (),
'18': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999)),
'20': ()}
{'state_class': {'measurement': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999))},
'unit_of_measurement': {'°C': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999))},
'window': {'closed': (),
'open': [datetime.time(0, 0),datetime.time(23, 59, 59, 999999))}}
For info on HA logs: https://www.home-assistant.io/integrations/system_log/ https://www.home-assistant.io/integrations/system_log/
To enable schedule_state DEBUG logs: https://github.com/aneeshd/schedule_state?tab=readme-ov-file#on-a-real-ha-instance https://github.com/aneeshd/schedule_state?tab=readme-ov-file#on-a-real-ha-instance
I need at least the INFO logs, preferably the DEBUG logs.

I have the following in my configuration.yaml;
logger:
  default: warn
  logs:
    custom_components.schedule_state: debug

And I'm not getting any logs from this integration 😅
I even restarted HA afterwards.

I took a closer look at your config.
This event:
  - condition:
      - condition: state
        entity_id: binary_sensor.wohnzimmer_fenster
        state: "on"
    window: "open"

Has no start/end times - so it is the whole day. Which means, whenever your window is open, everything reverts to the default state. This matches the INFO log I see.
I don't know why you don't get any log messages, probably you have disabled logs by some other means.
Overall, I am not seeing a bug here. Maybe a clarification is needed in the documentation?
Thanks for the /developer-tools/state pointer. I did not know about that view.

Yes, if this was intended behavior, then I would change this issue into a feature request 😁
Otherwise I would have to add this attribute templated to every event in every schedule I have 😅

ok submit a feature request and provide details on how you think it should work. The behaviour I see matches what I expect / designed.


feat: start supporting spec 2.4 by using latest generator version 1.9.5

Description
Bump @asyncapi/generator dependency to 1.9.5 on packages.json
Related issue(s)
Resolves https://github.com/asyncapi/github-action-for-generator/issues/232

@victormartingarcia hey, I see you created PR from master that probably was not synchronized with upstream master, and this is why this PR is not only introducing changes in Dockerfile but also package files again.
Best way to solve it is to prepare your fork using https://github.com/asyncapi/community/blob/master/git-workflow.md, especially if you plan further contributions. Then create a new PR

Sorry about that!
I created a new PR #237 following the contribution guidelines above. I had to downgrade to node 14 for making it work on my local machine, but mysteriously it is falling on the pipeline: https://github.com/asyncapi/github-action-for-generator/runs/7893944814?check_suite_focus=true
Any ideas how to fix it?


[Feature] Add mouse wheel scrolling into tab bar for better ux

Is your feature request related to a problem? Please describe.
When I want to change the resume section on the tab bar, it is not convenient for me to click on the small arrow multiple times to reach the section I want.
Describe the solution you'd like
Use mouse wheel scrolling will have a better user experience if needed.
Describe alternatives you've considered
none
Additional context
none

@AmruthPillai I have a PR ready if you would like this feature. thanks


Respect build.target when getting target dir

Use cargo_metadata crate
Respect build.target when getting target dir
Introduce RustTarget to cope better with better changes
Add CARGO_MAKE_CRATE_CUSTOM_TRIPLE_TARGET_DIRECTORY env var

Fixes #557

Codecov Report

Merging #554 (094be61) into master (30b6ba4) will decrease coverage by 25.57%.
The diff coverage is 44.44%.

:exclamation: Current head 094be61 differs from pull request most recent head 9066371. Consider uploading reports for the commit 9066371 to get more accurate results

@@             Coverage Diff             @@
##           master     #554       +/-   ##
===========================================
- Coverage   93.01%   67.44%   -25.58%
===========================================
  Files          98       98
  Lines       19283    19230       -53
===========================================
- Hits        17936    12969     -4967
- Misses       1347     6261     +4914

Impacted Files
Coverage Δ

src/lib/environment/crateinfo_test.rs
91.32% <0.00%> (-8.68%)
:arrow_down:

src/lib/environment/crateinfo.rs
77.47% <57.14%> (-7.36%)
:arrow_down:

src/lib/storage_test.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

src/lib/proxy_task_test.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

src/lib/recursion_level_test.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

src/lib/cli_test.rs
1.98% <0.00%> (-94.72%)
:arrow_down:

src/lib/scriptengine/rsscript_test.rs
0.00% <0.00%> (-90.56%)
:arrow_down:

src/lib/scriptengine/rsscript.rs
0.00% <0.00%> (-88.34%)
:arrow_down:

src/lib/environment/mod_test.rs
12.42% <0.00%> (-84.37%)
:arrow_down:

src/lib/legacy_test.rs
17.64% <0.00%> (-82.36%)
:arrow_down:

... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6ba4...9066371. Read the comment docs.

cargo FS structure looks like this:
target
\---debug
\---x86_64-custom-target
    \---debug

so it can be wrong behavior. Is it better to introduce a new env var?

can you explain a bit?

Behavior with custom target triple:

cargo creates target/debug folder with build scripts in it
cargo creates target/my_custom_triple with the rest

I don't know can cargo store there something else and will behavior be changed in the future.
What about workspaces? cargo ignores .cargo/config of member if you call cargo in workspace root, but don't if you do it in member's folder, so you see that member will store its artifacts in target/my_custom_triple when others do it in target

what new var did you have in mind?

Something like CARGO_MAKE_CRATE_CUSTOM_TRIPLE_TARGET_DIRECTORY

how would they be used if there were 2, meaning how do users know which one to use?

User will decide which directory he needs - folder of custom target triple (target/my_custom_triple) or folder of host (target)

@ark0f thanks a lot for the answers and PR. i agree with your approach of adding another env var.
tell me when its ready :)

looks awesome @ark0f thanks a lot
@pheki can you please verify that your use case is fixed with this PR?
After that i'll merge this into the 0.33 branch

Oh, I missed this PR... It's great and I've verified, it fixes #557.
Curiously, I'm also using a custom target, but its being set on [env] then passed in cargo build --target=${RUST_TARGET}, so I won't be able to use this new env var, but the current approach of joining the path works fine.

@pheki thanks for confirming :)
@ark0f merging this. thanks a lot!!!


chore: re-port Mathlib.Algebra.Star.SelfAdjoint

This file was sufficiently far out of sync that it seemed sensible to just report it.
A fresh output from mathport is included as a first commit; making it possible to diff both against the version in mathlib, and the version from mathlib.
The change to Mathlib.Algebra.Star.Module was forgotten in #2926.

I recommend reviewing this against the mathport output rather than the previously ported version.

bors merge


docs: Advise upgrading to latest versions for setup.

All issues / errors that I ran into during my setup were resolved by upgrading Yarn, Node, and XCode.

I think we need to add this as a separate sentence, summarizing that generally having the latest versions of these tools will avoid problems. In this, we should also include 'latest MacOS' version, as the latest XCode usually depend on it.

Thanks @jackrzhang for these notes!
I just merged the Yarn and Xcode commits, with a couple of tweaks:

I added the recommendation for latest macOS, as Boris mentioned and I recall you mentioning you had to do for the latest Xcode
I tweaked the Yarn recommendation to "latest stable" rather than "latest 1.x" -- those mean the same right now, when they diverge in the future we probably mean "latest stable", and the install page we link to identifies the "stable" version right at the top so that instruction should be as clear as any.

I'm curious about your change to the Node line. In particular I'm not actually sure what version I would install if following that instruction. :smile: The Node downloads page doesn't identify a version as "stable", but it has an "LTS", which is 8.x, and a "Current", which is 10.x (and IIRC was 9.x when I was setting things up myself a few months ago.)
Did you have trouble on 8.x that was resolved on 10.x? I wrote 8.x because that's what I decided to install, based on upstream (on that downloads page) saying it's "Recommended For Most Users". But if 10.x worked better for you, maybe we should recommend that instead.

@gnprice I've just resolved some merge conflicts, and this PR has automatically closed. I used Node 9.6.1 when I was setting up - it didn't seem to be the cause of any issues 😄

BTW, as a default we should recommend the LTS.
I personally use Current when playing with Node development, but for example jest was broken for a week after the initial release of 10.0.

@borisyankov I've rebased and updated the developer-guide to recommend Node LTS.

I used Node 9.6.1 when I was setting up - it didn't seem to be the cause of any issues :smile:

Got it -- thanks for the details!
I do think we want to keep saying "8.x" in the doc because that's the info that's actionable when following the instructions on the page we link to; but I've just pushed a small commit that hopefully makes the context clearer.

Closing because I think that accounts for everything that was in this PR, but of course please open a new PR for any further notes you'd like to add to the guide :smiley:


[Docs] Update mermai graph in design principles

Just updated some wording for mermaid graph:
sequenceDiagram

participant Filesystem
participant Client
participant ARCtrl

Note over Client,ARCtrl: ARC.fromFilePaths
Client->>ARCtrl: filepaths
ARCtrl->>Client: ARC

Note over Client,ARCtrl: ARC.GetReadContracts
ARCtrl->>Client: contracts

Note over Client,Filesystem: File.read
Client->>Filesystem: filepath
Filesystem->>Client: DTO

Note over Client,ARCtrl: ARC.SetISAFromContracts
Client->>ARCtrl: fullfilled Contracts
ARCtrl->>Client: ARC datamodel

resolved in e9c0a2e280dcf6ccce0d4008b89ffcee7d12d772


Fix Markdownlint

@Saibamen, which markdown lint did you use?

@Saibamen, which markdown lint did you use?

https://github.com/DavidAnson/markdownlint
https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint


0.5.0

This PR includes BC breaks:

all: resolve naming inconsistencies in jwk set names used in hydra #239
sdk: resolve naming inconsistencies #226

I will resume work on this release beginning September 19th


Bash dependency inside containers

I've noticed some bash scripting going on inside Drone which expects bash to be present in a container.
With the "minimal containers" approach, this can become a problem. See for example: https://github.com/blendle/docker-ruby/pull/3
Any thoughts on refactoring the scripts to only use bourne-shell compatible scripts?

Agreed. In fact this was fixed in the matrix demo I gave. We are moving toward a plugin model, and you can see this plugin that is responsible for generating the build script:
https://github.com/drone-plugins/drone-build
It removes the traps which are probably the biggest issue. The only requirement is base64 which is used to properly echo our build commands:
https://github.com/drone-plugins/drone-build/blob/master/main.go#L39
Plugins are swappable, so hypothetically you'll be able to swap this plugin with an alternate implementation for generating a shell script.
Let's track progress for this in #902 since it encapsulates the issue you've described.


Arch specific ptrace commands for BSDs

This PR is to add architecture specific ptrace requests etc.
Don't merge this yet if it passes I want to go over the other BSDs and architectures to see if I've missed anything I'm just creating the PR to get that initial CI approval that it's right as I expect this bit to be more fiddly.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

So there might be architecture specific commands for apple. But in all honesty I can't find anything about it online, so I'm going to count this as done once the CI passes and then that should be the last of ptrace related PRs!

@bors: r+

:pushpin: Commit f6e6be1986de49b0a606b40c6e1f389935202bed has been approved by alexcrichton

:hourglass: Testing commit f6e6be1986de49b0a606b40c6e1f389935202bed with merge 41944d5c37ef53647c09ac92cdb4bf636840dfab...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 41944d5c37ef53647c09ac92cdb4bf636840dfab to master...


createStore should perhaps accept preloadedState: PreloadedState | S

At least as of 4.0.5, createStore accepts preloadedState: PreloadedState<S>. One imagines that one can pass S to preloadedState, and in most cases this is correct. However, there are cases in which S is not assignable to PreloadedState<S>, at least since<EMAIL_ADDRESS>See https://github.com/microsoft/TypeScript/issues/35992 for more information on this issue. It's unclear to me whether https://github.com/microsoft/TypeScript/issues/35992 is a typescript bug, but I'm wondering if createStore should accept preloadedState: PreloadedState<S> | S, which would mitigate the issue of branded types being mapped to never.

This is fixed for 5.0 via #3485.

This is fixed for 5.0 via #3485.

Thanks @timdorr !!!


Download count roll-up loses bot/crawler information

When the download count roll-up job runs, it sets all download facts older than 42 days to have a client dimension ID of 1.
https://github.com/NuGet/NuGet.Jobs/blob/master/src/Stats.Warehouse/Programmability/Stored Procedures/dbo.RollUpDownloadFacts.sql#L120
This means that downloads that came from crawlers and bots are counted in downloads.v1.json and in the download counts put in the gallery DB:
https://github.com/NuGet/NuGet.Jobs/blob/master/src/Stats.Warehouse/Programmability/Stored Procedures/dbo.SelectTotalDownloadCountsPerPackageVersion.sql#L21
This means that bot/crawler download counts don't count... but only for 42 days after that download!

/cc @xavierdecoster


[Auto-generated] Update dependencies (pyproject.toml)

Update dependencies (pyproject.toml)
Automatically created PR from the cd_dependencies.yml workflow.

Codecov Report

Merging #51 (f93996b) into ci/dependency-updates (5fa7f36) will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           ci/dependency-updates      #51   +/-   ##
======================================================
  Coverage                  72.95%   72.95%
======================================================
  Files                         14       14
  Lines                        514      514
======================================================
  Hits                         375      375
  Misses                       139      139

Flag
Coverage Δ

linux
72.95% <ø> (ø)

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa7f36...f93996b. Read the comment docs.


Pull Request LeetCode 1171

What have you Changed
Adding solution to LeetCode 1171: Remove Zero Sum Consecutive Nodes from Linked List
Issue no. - #1615

[ ] This issue was assigned to me if not it will be marked as spam.
[ ] My file is in the proper folder
[ ] I am following clean code and Documentation.
[ ] I have added the title and what program will do first in the file
[ ] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

Please review my changes and let me know if there is anything else I need to edit.


refactor(bpp): make lateral offset smaller for monotonic bounds

Description
closes https://github.com/autowarefoundation/autoware.universe/issues/5396
This PR solves the specific issue above however logic in the makeBoundLongitudinallyMonotonic needs to be fixed as already addressed with a todo comment.

Tests performed
https://github.com/autowarefoundation/autoware.universe/assets/48479081/4692f900-3775-4fc6-94ce-a16836ea70ca
Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 -san I am struggling to understand the reason behind code section here:
https://github.com/autowarefoundation/autoware.universe/blob/db2768626a2e60e859934e0155b42088ef592be5/planning/behavior_path_planner/src/utils/utils.cpp#L1970-L1986
At the moment smaller lateral offset for non-monoton candidate can suppress the issue however non-monotonic bound points stay in the bound with this logic. Since I am not sure of the use case and the reason of the function I am not offering a fix but a workaround. Do you think assigning a smaller value to lat_offset could cause any problems for the use cases which you created the func to handle? I offered a value for it but please review it and feel free to offer another value or a solution if any
cc: @shmpwk

I am struggling to understand the reason behind code section here:

@mehmetdogru Have you already seen this doc?
At first, let me explain the logic to remove non-monotonic bound.
Step1. The main purpose of this function is to remove points that are not monotonically increasing with respect to the longitudinal direction of the path. So, it appends orientation infomation to each bound point based on the near path point.
https://github.com/autowarefoundation/autoware.universe/blob/64e2ab33dfcfd8a32dc76fe9de0396209a0f5c41/planning/behavior_path_planner/src/utils/utils.cpp#L1885
Step2. Check if the bound is monotonic. In this step, it uses lateral offset value. If the angle P2P1P3 in following fig is larger than 0.0 deg, it is a non-monotonic bound point.
https://github.com/autowarefoundation/autoware.universe/blob/64e2ab33dfcfd8a32dc76fe9de0396209a0f5c41/planning/behavior_path_planner/src/utils/utils.cpp#L1931-L1939
Step3. If there is a non-monotonic bound, it removes it. In this step, it searches intersect point and append it to bound point.
https://github.com/autowarefoundation/autoware.universe/blob/64e2ab33dfcfd8a32dc76fe9de0396209a0f5c41/planning/behavior_path_planner/src/utils/utils.cpp#L1976-L1985

@satoshi-ota -san
Thank you for the explanations and references. I would like to work on this function maybe little bit later and talk about it more on it however currently these values causes issues. So maybe we can make lat_offset 10 m for now until we find a fix?

@mehmetdogru
Sorry to be late.
The reason to implement makeBoundLongitudinallyMonotonic is just for visualization. Without this implementation, when the map has a complicated hatched road markings area, the drivable area's shape will be very weird.
If it's hard to maintain the function, we can discuss removing the function considering how bag the visualization will be.

@takayuki5168 -san
Thank you for your answer. IMO it is completely ok having a function around created for visualization purposes as long as it does not break any functionality. In this case we have a problem with the functionality ➡ https://github.com/autowarefoundation/autoware.universe/issues/5396
I am curious about this variable that why it is 100 m? Is there a use case that requires such big number?
If not we can assign a reasonable number for now to satisfies both your use cases and sample map drive.

@mehmetdogru Thanks for your proposal.
We set such a large number so that it can find intersecting point in following situation where the vehicle is driving in large drivable area. I think 0.1 ~ 10m is not enough but I can make it smaller value than 100m I guess. So, I'll try to find proper value that doesn't cause the issue at first in sample map and some other maps.

Hi @mehmetdogru
I tried some values for monotonic function. As a result, I confirmed it was ok for most of our use cases to change the value to 20.0m. And this change might be able to fix https://github.com/autowarefoundation/autoware.universe/issues/5396.
Therefore, I think it is ok to change the lateral offset value from 100m to 20.0m right now.

FYI: I also tried to solve the underlying cause of the issue. To be honest, I think it is possible to fix the issue without any changing of the variable. I suspected that the is_monotonic function had some bugs, so I re-built the function again in following PR. Then, it seems the issue is fixed. So, I would be appriciate if you could try it when it is convenient for you.
https://github.com/autowarefoundation/autoware.universe/pull/5565

@satoshi-ota
https://github.com/autowarefoundation/autoware.universe/pull/5565 solves the issue. Thank you for fixing the bug :pray: If it is ok for you lets merge it once you make it open.

@mehmetdogru
I'm happy to hear that :+1:
I opened PR. Could you leave some comments on that PR to show that you already confirmed it solves issue https://github.com/autowarefoundation/autoware.universe/issues/5396? (Maybe other maintainer approves it.)


Feature: API team management

Allow to Create RoleBinding (User and Team) for compatible objects (Request, Instance and Team for now)

Done and merged in dev branch


Why can't we define licenses per dependency?

Hi @johnynek,
Sorry for the silly question which may be based on a wrong understanding of the license requirement of third_party/ dependencies.
From what I understand, we can only define the licenses option for the full set of the dependencies declared in the .yaml file. Why is that? Why are we not able to define a license type per dependency?
Does the license argument in the build rules represent the license in which the vendor defined for their code distribution, or does it represent our copyright/ownership over the "build rule" for the dependency (and not the dependency itself)? If it is the former, what if we have different license types across different dependencies?
Thank you!

@haikalpribadi the licenses setting was something I accepted as a PR and maybe should have required more work.
we don't put our deps in third_party at stripe, we use 3rdparty which is shorter and what was used at Twitter which we copied, so we don't get hit by this issue.
I'm happy to accept a PR to improve this, but currently it is low priority for me personally so I probably won't get to it.
The way to add support is to add license as an optional field the classes that represent projects in the yaml file, and then after it is parsed pass it through at generation time.

Thanks, @johnynek. I'm happy to submit a PR for this, but I should first understand what the expected usage of license is.
Are we supposed to declare license individually per dependency?
What about the transitive dependencies that are pulled in during parseproject? How do we declare them / modify the generated BUILD files?

I really don't know why bazel want this, and since i think bazel wants them on the builds it is resistant to automatic transitive tooling.
I think requiring it is a misfeature that is forcing bazel users into managing third party licensing the way google thinks it should be done.
Like I said, just using a different directory fixes the issue. I'm not that interested in satisfying this problem. We review changes to dependencies.yaml and workspace.bzl and make sure they point to Apache or BSD licensed code, and we are satisfied with that approach.

We actually already do have it in a different directory. However, we also see the value on declaring the license of your dependency - it fits our use case.
Anyways, I'll see what we can do with our team and submit PR when we come up with a solution. And of course, it will be optional to enable the feature. :)


move integration tests to source/test/integ/

The integration tests have been saved under source/api/tests even though e2e and unit tests are under source/tests. The pattern for solutions is to put unit, integ, and e2e tests all in the same subfolder (e.g. source/tests/unit/, source/tests/integ/, source/test/e2e/). I request that the integ tests be moved to source/tests/integ/ in order to improve the organization of those test assets.

If you can resolve this issue, then resolve this as well -> https://github.com/aws-solutions/amazon-marketing-cloud-uploader-from-aws/issues/107


[release-1.4] Add limits to the operator deployment

This is an automated cherry-pick of #434

@googlebot I consent.


Changed task.py fixed indentation and other changes

Fixed indentation
added permission_classes in @detail_route

please test your code before submitting at least using CURL for the api part


Flake8 rule 'E999' reported an invalid point

Flake8 reported an invalid point for the rule E999, with the messge SyntaxError: invalid syntax.
on line 1:
from marshmallow import Schema, fields, post_load
Debug information:
Atom version: 1.12.6
Flake8 version: 3.0.4 (mccabe: 0.5.2, pyflakes: 1.2.3, pycodestyle: 2.0.0) CPython 2.7.10 on Darwin

Please update your flake8, v3.1.0 fixed one bug related to this, and v3.2.1 fixed a whole class of positioning errors with E999 messages.

Closing due to a lack of response, if you are still experiencing this after updating to flake8>=3.2.1 please either file a new issue or respond here with code to reproduce it, thanks!


Install link is broken

Hey there @luxonauta , can you guide me how fix it for the website. Since https://draculatheme.com/rio is not available.

Thanks for the report; I will fix it!

Thank you @luxonauta 🙏 🙏 🙏

🥳 Fixed: https://draculatheme.com/rio-terminal

🎖 thank you @luxonauta !!


Add back morte

stack {build,test,bench} now work with morte-1.6.10 against the latest nightly resolver

Thanks!


[Bug] NaNs produced when env.backends.onnx.wasm.proxy = true?

I think I'm doing something silly here, but setting env.backends.onnx.wasm.proxy = true makes this produce NaNs:
let { pipeline, env } = await import('https://cdn.jsdelivr.net/npm/@xenova/transformers@2.8.0');
env.allowLocalModels = false;
// env.backends.onnx.wasm.proxy = true; // uncomment this line to produce NaNs
let extractor = await pipeline('feature-extraction', 'Xenova/bge-base-en-v1.5');
let result = await extractor("test 123", { pooling: 'mean', normalize: true });
console.log(result.data);

I thought maybe it was a 2.8.0 regression, but I tried all versions back to 2.5.4 and it's didn't work in any of them, so that makes me lean toward assuming that I'm doing something wrong. If that's the case, then an informative error message would be helpful :)

Hey @josephrocca, thank you for the issue!
I just happen to work on something that helps here: https://runtimetypeinspector.org/
However, I still need to work on the webpack integration (webpack plugins are so complicated...), so right now I can't make the runtime type inspection process reproducible (I'm using my own rollup build script), so I will just note what I discovered so far.
The first "miscalculation" RTI found was here:

Then it's easy to set a breakpoint and inspect the data, first big clue:

Hey, the BigInt64Array is... empty!
a bit of tinkering later...
Go to:
https://github.com/xenova/transformers.js/blob/4e4148cb5ce7f4a9265f58b4eeb660c64bed0386/src/pipelines.js#L128-L129
Add this code:
        // Run model
        console.log("model_inputs.input_ids.data", model_inputs.input_ids);
        //debugger;
        let outputs = await this.model(model_inputs)
        console.log("model_inputs.input_ids.data", model_inputs.input_ids);

Output:

(this means whatever happens in await this.model(model_inputs) invalidates our typed array)
You can uncomment the //debugger; and eventually I figured the BigInt64Array is invalidated in ONNXRuntime:

I did a bunch of WebAssembly programming some years ago and one reason I can think of is memory growth: whenever the WASM memory is increased, it invalidates the typed arrays pointing into that.
However, I don't have the time right now to dig deeper into this, I have to prepare a bit more for RTI to integrate it into the webpack build script of Transformers.js... I hope this sheds a little bit more light into the issue so far 💡

Ah RTI looks like a very cool project! I had a project where I desperately needed something like that in the past. BTW, this issue is exciting to me.
RE this issue - thanks for looking into it! From your investigation, it sounds like this comes from the ORT Web side of things, so a minimal pure ORT Web example is probably required?
Currently my workaround is just to manually put it in a web worker myself.

Ah RTI looks like a very cool project! I had a project where I desperately needed something like that in the past. BTW, very tangential, but this issue is exciting to me along these lines.

Thank you! Don't forget to like and subscribe :zany_face: I'm kind of against TS-style type annotations in the first place, but I don't want to go into that here.

RE this issue - thanks for looking into it! From your investigation, it sounds like this comes from the ORT Web side of things, so a minimal pure ORT Web example is probably required?

We blamed ONNXRuntime before, but then it was our own fault - so before we point that out, I would like to read @xenova's take on this issue aswell.
I debugged a bit further into ONNXRuntime and I'm pretty sure it's an ownership issue - when the BigInt64Array crosses the Worker border, it's loosing ownership, and when transformers.js wants to do further calculations with it - the tensor data array is empty.
So if we rewrite this code:
https://github.com/microsoft/onnxruntime/blob/a5537f2f563d4975c7e6121a7eb260bbbfd9455a/js/common/lib/inference-session-impl.ts#L108
const results = await this.handler.run(feeds, fetches, options);

Into:
    console.log("feeds before", feeds);
    const feedsCopy = {};
    for (const key in feeds) {
      const feed = feeds[key];
      feedsCopy[key] = feed.clone();
    }
    const results = await this.handler.run(feedsCopy, fetches, options);
    console.log("feeds after", feeds);
    console.log("feedsCopy after", feedsCopy);

The output is:

So we can just clone the feeds into feedsCopy and "sacrificing" them for the session... probably we can do this clone-sacrifize-trick in transformers.js aswell? Something to figure out for a PR either here or at ONNXRuntime.
Documentation for ONNXRuntime run:
https://github.com/microsoft/onnxruntime/blob/a5537f2f563d4975c7e6121a7eb260bbbfd9455a/js/common/lib/inference-session.ts#L337-L356
I doesn't really warn anyone that it could kill our typed arrays :thinking: :sweat_smile: So maybe it should be reported...

Currently my workaround is just to manually put it in a web worker myself.

Interesting, so just load all of transformers.js into a worker and then it's not crossing the worker boundary, because it's all in a worker? What is the disadvantage of this, maybe poorer debugging via F12/DevTools?

Thanks so much for your investigation @kungfooman! Am I correct in saying that this suggests we need to make copies before passing it to the proxied inference session, because the inference session consumes the array and moves its data?

Thanks so much for your investigation @kungfooman! I'm not sure if it is related, but after the inference session returns, I replace all ONNX tensors with a custom tensor class (which subclasses the ONNX tensor class), to add certain functions to the class. Perhaps this has something to do with the invalidation of the existing tensor?
In the meantime, we could add a simple fix which (1) tests if proxy is set to true, and if it is, we make copies before sending to the inference session. @josephrocca or @kungfooman would you be interested in making a PR?

I doesn't really warn anyone that it could kill our typed arrays 🤔 😅 So maybe it should be reported...

cc @guschmue @fs-eire for this. I would expect that the proxy should handle the cloning, as to avoid issues like this in the users' code (in case this is not specific to transformers.js).


Fix a crash related to waypoints.

The game would crash due to illegal array access when shift-clicking the first waypoint with a vanilla remote. This check prevents that.

Nevermind, I seem to have been a bit quick calling it there. I'm now having a hard time reproducing the original issue reliably.


FieldArray: fields.remove() not working in IE11/Firefox

Are you submitting a bug report or a feature request?
Bug Report
What is the current behavior?
Using FieldArray (only posting the relevant part of the code):
<FieldArray
    name="transitions"
    component={TransitionsFields}
 />

class TransitionsFields extends PureComponent<Props> {
   render() {
    const { fields } = this.props;
    {fields.map((transition, index) => (
        <Field
              name={`${transition}.startStateId`}
              (...) />
        <Field
              name={`${transition}.targetStateId`}
              (...) />
        <IconButton aria-label="Eliminar">
              <Tooltip title="Eliminar">
                   <DeleteIcon
                        color="action"
                        onClick={() => fields.remove(index)}
                    />
               </Tooltip>
         </IconButton>
    )}
  }
}

fields.remove(index) is working fine in Chrome, but it doesn't in IE11 or latest Firefox. There are no errors, the render is not updating and the field is not being removed.
What is the expected behavior?
fields.remove() should work consistently across supported platforms.
What's your environment?
React v16.3.1, Redux-form v7.3.0, Internet Explorer 11 & Firefox Latest

My bad. The issue was not due to redux-form, but due to materialUI, onClick prop has to be passed to IconButton not to Icon component. Odd thing is, Chrome still manages to bubble up the event and it works. Closing this.