Tracing protocol is HTTP even though tempo-k8s is related to self-signed-certificates

Bug Description
The tracing protocol that is expected is HTTP even though tempo-k8s is related to self-signed-certificates. Furthermore, even though we are using charm_tracing_config, tracing is enabled but server_cert is returning None. Since tempo-k8s is using HTTPS, the mysql charm tries to export spans to tempo and fails continuously (leading to the charm getting stuck with the same hook handler - which does not return as span exporting is retrying infinitely)
To Reproduce
In k8s model:

juju deploy cos-lite --trust --channel edge
juju deploy tempo-k8s --channel edge
juju integrate tempo-k8s:grafana-dashboard grafana:grafana-dashboard
juju integrate tempo-k8s:grafana-source grafana:grafana-source
juju integrate tempo-k8s:ingress traefik:traefik-route
juju integrate tempo-k8s:metrics-endpoint prometheus:metrics-endpoint
juju integrate tempo-k8s:logging loki:logging
juju deploy self-signed-certificates
juju integrate tempo-k8s:certificates self-signed-certificates

In lxd model:

checkout code from https://github.com/canonical/mysql-operator/pull/465
tox -e build-production
juju deploy -n 1 ./mysql_ubuntu-22.04-amd64.charm
juju consume uk8s:admin/cos.tempo-k8s
juju consume uk8s:admin/cos.self-signed-certificates
juju integrate mysql:tracing-certificates self-signed-certificates
juju integrate mysql tempo-k8s

Environment
juju: 3.4.3
microk8s: MicroK8s v1.27.13 revision 6744
lxd: 6.1
ubuntu 22.4.3 LTS
Relevant log output
...
unit-mysql-3: 15:55:47 WARNING unit.mysql/3.juju-log <class '__main__.MySQLOperatorCharm'>.tracing_server_ca_cert is None; sending traces over INSECURE connection.
unit-mysql-3: 15:55:47 INFO unit.mysql/3.juju-log Unit workload member-state is online with member-role primary
unit-mysql-3: 15:55:48 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 1s.
unit-mysql-3: 15:55:49 WARNING unit.mysql/3.juju-log Timeout was exceeded in force_flush().
unit-mysql-3: 15:55:49 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 2s.
unit-mysql-3: 15:55:51 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 4s.
unit-mysql-3: 15:55:55 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 8s.
unit-mysql-3: 15:56:03 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 16s.
unit-mysql-3: 15:56:19 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 32s.
unit-mysql-3: 15:56:52 INFO juju.worker.uniter.operation ran "update-status" hook (via hook dispatching script: dispatch)
unit-mysql-3: 15:56:52 WARNING unit.mysql/3.juju-log <class '__main__.MySQLOperatorCharm'>.tracing_server_ca_cert is None; sending traces over INSECURE connection.
unit-mysql-3: 15:56:53 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 1s.
unit-mysql-3: 15:56:54 WARNING unit.mysql/3.juju-log Timeout was exceeded in force_flush().
unit-mysql-3: 15:56:54 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 2s.
unit-mysql-3: 15:56:56 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 4s.
unit-mysql-3: 15:57:00 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 8s.
unit-mysql-3: 15:57:08 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 16s.
unit-mysql-3: 15:57:24 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 32s.
unit-mysql-3: 15:57:57 WARNING unit.mysql/3.juju-log <class '__main__.MySQLOperatorCharm'>.tracing_server_ca_cert is None; sending traces over INSECURE connection.
unit-mysql-3: 15:57:57 INFO unit.mysql/3.juju-log Unit workload member-state is online with member-role primary
unit-mysql-3: 15:57:58 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 1s.
unit-mysql-3: 15:57:59 WARNING unit.mysql/3.juju-log Timeout was exceeded in force_flush().
unit-mysql-3: 15:57:59 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 2s.
unit-mysql-3: 15:58:01 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 4s.
unit-mysql-3: 15:58:05 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 8s.
unit-mysql-3: 15:58:13 WARNING unit.mysql/3.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 16s.
...

Additional context
Certificate retrieved in mysql charm:
ubuntu@juju-5ba1f4-3:~$ ls -la /var/snap/charmed-mysql/common/var/run/
total 16
drwxr-xr-x 3 snap_daemon root 4096 Jul 26 15:27 .
drwxr-xr-x 5 snap_daemon root 4096 Jul 26 15:25 ..
drwxr-xr-x 2 snap_daemon root 4096 Jul 26 15:26 mysqld
-rw-r--r-- 1 root        root 1240 Jul 26 15:27 tracing-ca.crt

databag from the perspective of mysql (note that protocol type is http):
  - relation-id: 19
    endpoint: tracing
    cross-model: true
    related-endpoint: tracing
    application-data:
      receivers: '[{"protocol": {"name": "otlp_http", "type": "http"}, "url": "http://<IP_ADDRESS>:4318"}]'
    related-units:
      tempo-k8s/0:
        in-scope: true
        data:
          egress-subnets: <IP_ADDRESS>/32
          ingress-address: <IP_ADDRESS>
          private-address: <IP_ADDRESS>

Quick passby thought: did you add certificates relation to traefik too? Maybe this one was missing.

@mmkay I related traefik with self-signed-certificates (on both certificates and receive-ca-cert endpoints). i am getting the below Query Error in Grafana's explore page. Any ideas what may have gone wrong?

Not immediately but you can check Administration -> Datasources and check what URL is shown next to Tempo's datasource. In your setup I'd expect https://<IP_ADDRESS>:3200. If it is like that you can also try reaching this address from your grafana host by juju sshing into it and running curl.

@shayancanonical Could you verify if the certificate is being copied in the charm container of mysql-operator and that you're running update-ca-certificates afterwards?
This way, the charm should trust the passed CA.

Hi @shayancanonical are you still experiencing this issue??

@Abuelodelanada  @lucabello  Can confirm that the issue is still reproducible (even after confirming that the cert is added as a result of running updata-ca-certificates). However, we have some concerns about having to add another relation interface to our charm in order to retrieve the CA from the certificates operator related to tempo-k8s. We suggest the tempo-k8s passing the CA it is using via the databag to the related database charm (MySQL in this case)
We have a similar use case in MySQL: MySQL relates to self-signed-certificates operator and instead of asking the app related to MySQL to get the cert by relating to the self-signed-certificates operator, MySQL passes the cert to the client app through the databag.
The reason I mention this is because doing so would greatly simplify our implementation and reduce the probability of human error.
Logs while reproducing:
unit-mysql-0: 19:49:11 INFO juju.worker.uniter.operation ran "update-status" hook (via hook dispatching script: dispatch)
unit-mysql-0: 19:49:11 WARNING unit.mysql/0.juju-log <class '__main__.MySQLOperatorCharm'>.<property object at 0x7fd85a03f060> returned None; sending traces over INSECURE connection.
unit-mysql-0: 19:49:12 WARNING unit.mysql/0.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 1s.
unit-mysql-0: 19:49:13 WARNING unit.mysql/0.juju-log Timeout was exceeded in force_flush().
unit-mysql-0: 19:49:13 WARNING unit.mysql/0.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 2s.
unit-mysql-0: 19:49:15 WARNING unit.mysql/0.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 4s.
unit-mysql-0: 19:49:19 WARNING unit.mysql/0.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 8s.
unit-mysql-0: 19:49:27 WARNING unit.mysql/0.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 16s.
unit-mysql-0: 19:49:43 WARNING unit.mysql/0.juju-log Transient error Internal Server Error encountered while exporting span batch, retrying in 32s.

attempting to repro with:

juju deploy cos-lite --channel edge --trust
juju deploy tempo-k8s --channel edge tempo
jhack imatrix fill
juju deploy self-signed-certificates --channel edge ssc
jhack imatrix fill
offer/consume as specified by OP

everything seems to work. Endpoint is https

issue was that traefik wasn't related to SSC. closing this, and opening a different ticket instead to see if we can surface this situation better

--> https://github.com/canonical/tempo-coordinator-k8s-operator/issues/46


fixes direction swipe

Currently the menu opens if one swipes from left far upwards. This should not happen since touch from down to up or the other way around is scrolling other content.
The menu should only be opened if one moves it from left to right or closing from right to left.
This pr implements this fix with an allowed range of 25px up/down. (May be changed to be configurable but 25px should be a fine default value.)

Coverage decreased (-2.04%) to 67.836% when pulling 7af27609493445f286e167bc3524a7d564323f50 on raffis:direction_fix into 6eb8440ddc7e94194723f86f6580de4d101762a3 on Mango:master.


Import/Export in the uP5 Manual(#1241)

This PR updates the Import/Export tool documentation for uPortal to reflect the new commands in uP5. It replaces outdated commands with the current syntax and usage, ensuring accuracy and clarity. The documentation includes step-by-step instructions and examples to guide users through the Import/Export process. Additionally, it addresses any discrepancies found in the previous version.

@ChristianMurphy ready to merge ?

@555vedant enhance your calm, give people a chance to review. 🙂

@ChristianMurphy  thnx for suggestions

With uPortal 5, the data import/export tasks are invoked using Gradle. The commands and its parameters are same for the most part, so the documentation needs to be updated to reflect that

in this format template is more readable !!

@jonathanmtran Changes done.

@jonathanmtran PR ready to merge ??

Please squash the commits into one

@jonathanmtran squashing done


Latest<EMAIL_ADDRESS>caused ReferenceError: document is not defined

This issue happened just now while running test using JEST, and I traced back to the issue is originated from the latest upgrade of flatpickr on version 4.1.1.
If I run my test it shows error as following:
    TypeError: Cannot read property 'parentNode' of undefined

      at node_modules/flatpickr/dist/flatpickr.js:2:193
      at Object.<anonymous> (node_modules/flatpickr/dist/flatpickr.js:2:225)
      at Object.<anonymous> (node_modules/react-flatpickr/build/index.js:19:18)
      at Object.<anonymous> (src/app/components/Order/CustomerModifyAddressEventsContent.js:9:49)
      at Object.<anonymous> (src/app/components/Order/CustomerModifyAddressEvents.js:7:69)
      at Object.<anonymous> (__tests__/app/components/CustomerModifyAddressEvents.test.js:6:36)
      at handle (node_modules/worker-farm/lib/child/index.js:44:8)
      at process.<anonymous> (node_modules/worker-farm/lib/child/index.js:51:3)
      at emitTwo (events.js:106:13)
      at process.emit (events.js:191:7)
      at handleMessage (internal/child_process.js:718:10)
      at Pipe.channel.onread (internal/child_process.js:444:11)

Moreover, once I upgrade to<EMAIL_ADDRESS>I cannot even start up my project since it always fails on SSR, error log:
/Users/cslinmiso/Documents/Repositories/runnerProject/node_modules/flatpickr/dist/flatpickr.js:2
(function(l, i, v, e) { v = l.createElement(i); v.async = 1; v.src = '//' + (location.host || 'localhost').split(':')[0] + ':35729/livereload.js?snipver=1'; e = l.getElementsByTagName(i)[0]; e.parentNode.insertBefore(v, e)})(document, 'script');
                                                                                ^

ReferenceError: document is not defined
    at Object.<anonymous> (/Users/cslinmiso/Documents/Repositories/runnerProject/node_modules/flatpickr/dist/flatpickr.js:2:226)
    at Module._compile (module.js:541:32)
    at Module._extensions..js (module.js:550:10)

I had tried using version 4.1.0 and it worked with no error. Not sure why and I wonder if anyone meets this issue since 4.1.1 released 4 hours ago...
Thanks.

it's an error in the flatpickr library itself.
https://github.com/chmln/flatpickr/issues/1117
let's see what happens

Same here, something is wrong with build system.

Same here – it appears that the underlying flatpickr library has been updated, while not changing the version number for react-flatpickr.

Flatpickr has issued 4.1.2 that resolves the issue.

I believe 4.1.2 should match the semver version specified in this package, so an npm upgrade should be all you need.
Please let me know if there's anything we need to do for this package and I'll reopen!


"unknown free variable" kernel error with complex do block

As found by @larsk21. All the individual parts seem to be necessary.
import Lean.Elab.Tactic
open Lean Lean.Elab.Tactic

-- `unknown free variable: _kernel_fresh.4758`
def bar : TacticM Unit := do
  try
    let a ← `(1)
    evalTactic (← `(tactic| refine abc $(quote 1)))
  catch _ => pure ()

Have found another relevant example:
inductive Foo
| mkFoo1
| mkFoo2
| mkFoo3
| mkFoo4
| mkFoo5
| mkFoo6

class FooDim where
  dim : Foo → Nat

instance: FooDim := ⟨ fun
| .mkFoo1 => 2
| _ => 0
⟩

inductive Nat': Nat → Type where
| zero: Nat' 0
| succ: Nat' n → Nat' (n+1)

structure Bar [i: FooDim] where
  foo: Foo
  dim: Nat' (i.dim foo)

-- unknown free variable: _kernel_fresh.63
def Bar.fails: Bar → Bar
| ⟨.mkFoo1, Nat'.succ (Nat'.succ Nat'.zero)⟩ => ⟨.mkFoo1, Nat'.zero.succ.succ⟩
| e => e

nightly-2023-03-01


changes for About dialog when unbranded or 'adapted from'

Should version number?
Should we append sim title with (adapted)
Other changes?
Link to the phet website?

Lots of questions, should discuss with @kathy-phet

@kathy-phet envisions unbranded being when people use our libraries/assets to make a pretty unique sim or a topic we do not cover. In this case, the about dialog should have some verbiage about powered by scenery with University of Colorado there, acknowledgement of PhET down near bottom of about dialog.
for medium branded sims: these include even just a major "paring" down of a sim, such as a much simpler version of say Under Pressure with a much limited control set. Initial thought is to have link to original sim in a phrase such as "adapted from Balancing Act", remove sims credits, let third party deal with version number and sim title, with link to PhET site and acknowledgment of PhET and CU Boulder.
Something like
Sim Title (chosen by adapter)
Adapted from "Sim Name"
originally produced by PhET Interactive Simulations (TM), University of Colorado
NO credits of our team or software agreement/licensing

Can you comment on priority?  If this is needed soon, perhaps it would be good for @aaronsamuel137 to take the lead.

This issue is replaced by various other issues that discuss what specific brands look like. Closing.


fix: minor readme and release job fix

ReadMe and Release Job Fix

Codecov Report

Merging #52 (476c80b) into main (4bc0b72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   35.91%   35.91%
=======================================
  Files          23       23
  Lines         827      827
=======================================
  Hits          297      297
  Misses        502      502
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc0b72...476c80b. Read the comment docs.


Remove deprecated version parser; refactors

Besides removing the unused get-version-from-legacy-file, I've also pruned out a fair bit of useless or dead code, such as setting MAKE_OPTS (does nothing, and it set by python-build anyway), and creating our own tmpdir (also done by python-build).
A handler for refs and more quoting were also added.

Thank you very much!


add Edmund Karp in java

add Edmund Karp in java

Please edit the README file accordingly :)

ok will do.

readme updated :)

Please close the PR!


Unexpected custom error message from ValidateStruct

Hello again,
it would be really nice if the custom errors from ValidateStruct() had the same format as from Validate(). Right now ValidateStruct() also returns the name of the failed field which makes it hard to use the custom error together with other code. Makes sense?
data := "2123"
err := validation.Validate(data,
	validation.Match(regexp.MustCompile("^[0-9]{5}$")).Error("error.mustbefive"),
)
fmt.Println(err) // Prints: "error.mustbefive"

type Foo struct {
	Bar string
}
t := Foo{Bar: "2123"}
err = validation.ValidateStruct(&t,
	validation.Field(&t.Bar, validation.Match(regexp.MustCompile("^[0-9]{5}$")).Error("error.mustbefive")),
)
fmt.Println(err) // Prints: "Bar: error.mustbefive"

Of course, this makes perfect sense. Thanks for the explanation.


The ability to see a user's session in view-only mode by another user

@HRNasr what protocol and OS do you refer to?

@HRNasr is that possible with Guacd? Does Guacd have this feature? You know, if Guacd doesn't support this, there's nothing much we can do on our side

@HRNasr one critical issue is that RDP doesn't support two users to connect. Not even for viewer


MB-13122 Update dependabot to also look at gh actions for updates

Jira ticket for this change
Summary
Update dependabot to also check gh actions for updates.
Docs on updating gh actions w/dependabot
We do this in the mymove-docs repo too.
h/t to @duncan-truss for recommending this

Messages

:book:
:link: MB-13122

  Generated by :no_entry_sign: dangerJS against c19bbc16b990a7000972c1d0347349305677c830


IP Addresses are not sorted correctly

Description
IP Addresses are not sorted correctly.

Steps to reproduce the issue:

Open "Containers" tab
Sort "IP Addresses"

Instead they should be sorted like <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> and so on.
Technical details:

Portainer version: 1.16.5
Target Docker version (the host/cluster you manage): 18.03.0-ce, build 0520e24
Platform (windows/linux): linux

Browser: firefox 60.0b10

Hi. Please assign it to me

I wanna edit ContainersDatatableController.js, add a new function this.ipComparator. Then I need edit containersDatatable.html where I change orderBy filter by adding custom comparator(ipComparator)

@deviantony please look at the pull request https://github.com/portainer/portainer/pull/2334

@pantegrow I will, sorry I'm a bit busy on other topics right now.

In the latest version (2.0.0) of Portainer, we do not have an IP address column. This is no longer an issue.

Indeed, this issue can now be closed.


--scale

learn from the training set scaling parameters to put all feature values inside [0:1]
apply them on the test set

--iwn was repaired, in the mean time

done; but currently not supported in production (the scaling params would need to be stored along with the trained model)


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.26 to before v5.15.19",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2feb27dbe00cbb4f7d31f90acf6bd0d751dd0a50",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e43669c77cb3a742b7d84ecdc7c68c4167a7709b"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "2feb27dbe00cbb4f7d31f90acf6bd0d751dd0a50",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "e43669c77cb3a742b7d84ecdc7c68c4167a7709b",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: fix information leakage in /proc/net/ptype\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.19 by commit e43669c77cb3a742b7d84ecdc7c68c4167a7709b, it was introduced in version v2.6.26 by commit 2feb27dbe00cbb4f7d31f90acf6bd0d751dd0a50. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000258


Github actions failure due to missing VK_KHR_external_memory_fd Vulkan extension

In https://github.com/ami-iit/yarp-device-openxrheadset/actions/runs/2923665308 the tests failed with the error
Test project /home/runner/work/yarp-device-openxrheadset/yarp-device-openxrheadset/build
    Start 1: openxrheadset_test
1/1 Test #1: openxrheadset_test ...............***Failed    0.35 sec
Warning:  |yarp.device.openxrheadset| Runtime does not support the HTC Vive Trackers!
 INFO [p_create_system] Creating system:
	Builders:
		rgb_tracking: RGB tracking based devices (PSVR, PSMV, ...)
		lighthouse: Lighthouse-tracked (Vive, Index, Tundra trackers, etc.) devices builder
		remote: Remote simulation devices builder
		legacy: Legacy probing system
	No builder selected in config (or wasn't compiled in)
	No builder was certain that it could create a head device
	Selected legacy because it maybe could create a head
	Using builder legacy: Legacy probing system
	Result: XRT_SUCCESS
DEBUG [xrt_gfx_provider_create_system] Doing init 0x560397b2f200
ERROR [create_device] vk_create_device: VK_ERROR_EXTENSION_NOT_PRESENT
	Failed to create Vulkan device.
ERROR [xrt_gfx_provider_create_system] Failed to init compositor 0x[56](https://github.com/ami-iit/yarp-device-openxrheadset/runs/8007913672?check_suite_focus=true#step:13:57)0397b2f200
XR_ERROR_INITIALIZATION_FAILED in xrCreateInstance: Failed to create the system '-3'
Error [GENERAL | xrCreateInstance | OpenXR-Loader] : LoaderInstance::CreateInstance chained CreateInstance call failed
Error [GENERAL | xrCreateInstance | OpenXR-Loader] : xrCreateInstance failed
Error:  |yarp.device.openxrheadset| Failed to create XR instance.
Error:  Failed to initialize OpenXr interface.
[INFO] |yarp.device.openxrheadset| Closed

I checked the available Vulkan extensions and I noticed that the extension VK_KHR_external_memory_fd was present in https://github.com/ami-iit/yarp-device-openxrheadset/runs/7986680925?check_suite_focus=true, but it got removed in https://github.com/ami-iit/yarp-device-openxrheadset/runs/8007913672?check_suite_focus=true
This extension is required by monado: https://gitlab.freedesktop.org/monado/monado/-/blob/06ee685e9a20e7e7a875f0ed4849b948aea4c575/src/xrt/compositor/main/comp_compositor.c#L595

This is strange, did the lavapipe/mesa version in the base image changed?

Indeed, the working version is installing mesa 22.2~git2206220600 from oibaf, while the broken version is installing mesa 21.2.6 from the regular ubuntu repos. Probably something is going wrong with oibaf? Anyhow, ubuntu 22.04 has mesa 22.0.5, perhaps that is enough without using oibaf repositories?

I saw that an updated mesa was uploaded in oibaf 4 hours ago: https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers . Perhaps we just had an hiccup in which the server already removed the old mesa without uploading the new one?

Thanks a lot @traversaro for the analysis. I tried running the Action again (https://github.com/ami-iit/yarp-device-openxrheadset/runs/8013744950?check_suite_focus=true) but it failed :thinking:

By looking a bit more, it seems that oibaf removed almost all the packages for Focal (see https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers?field.series_filter=focal). Not sure why. Possible options are:

Upgrate the image to ubuntu-22.04
Use https://launchpad.net/~kisak/+archive/ubuntu/kisak-mesa (or some other mesa ppa) in place of oibaf

I tried the first in https://github.com/ami-iit/yarp-device-openxrheadset/tree/fix_ci


How to get the PCI path of the BOOT partition?

When add system boot parameters to a custom entry, how to get the full PCI path address of the BOOT partition?

Can you add a hotkey to the start menu to save the list of information you need on disk?

When add system boot parameters to a custom entry, how to get the full PCI path address of the BOOT partition?

You need to use the debug version, which located in OpenCorePkg/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCore-0.5.4-DEBUG.zip and set Misc->Debug->Target to 67.  It will save the bootlog to disk, In the log, look for anything with Dp, it's a potential DevicePath to entry.
About the key to copy entries info to disk, I already thought of that, but haven't got time to get to it. Since using the above method will achieve the same thing, still not sure if it's really needed.

This function is necessary!
There are limitations to using the DEBUG function. If you did not successfully boot with Windows in the last startup, you cannot find the startup path in the log file. Only when you successfully boot Windows with OC successfully, you can query the partition path information in the log!
The problem now is that because the Windows boot information could not be found in the OC boot menu, I wanted to add an attempt to the custom entry, but now I cannot get the path information correctly!
The cause of the problem was a user, his MAC and Windows were installed on the same disk, but the Windows information could not be found in the boot menu to enter the Windows system correctly!
In the CLOVER boot menu, you can easily see the PCI path information of each bootable partition by pressing the space bar. It is also necessary to add this function to OC!

Make a hotkey function, use the hotkey to automatically save all bootable PCI path information in a file under the EFI partition！


After stabilization missions

[x]  Add a setting for the circle size and compute the mask with it
[x] Check for fft shift before the stabilization
[ ] Try add CufftHandle wrapper
[x] Refreshe the pipe with the stabilization and get the ref on refresh
[x] Stabilize when launching with already enabled

Also need to add the reticle when modifying registration zone.


dbeaver/dbeaver#19583 Fix statements create attempts if is not intern…

…al driver error. Do not invalidate after nested invalidation fail.

verified


[ONNX] Remove unused includes

@arogowie-intel I'd like this to be a good start, I don't think I can do a complete clean up at this time. I addressed your comments, thanks.


Deserializer as a function

Reworked contribution from https://github.com/cakesolutions/scala-kafka-client/pull/60

👍 LGTM


Link the Rust YouTube channel on Community page. Fixes #562.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks!


feat: create most-popular-movies component

Dependencies

gatsby-source-contentful
Valtio
gatsby-plugin-testing
react-test-renderer

What
I created a new component called most-popular-movies that displays a list of popular movies. The component includes a title, a list of movies (each with a name, image, and description), and a button that allows users to load more or fewer movies. Initially, only 3 movies are displayed.
Why
This component provides a visually appealing way to showcase popular movies to users. By allowing users to load more or fewer movies, we can provide a more personalized experience and reduce the initial load time for users with slower connections.
How
The component uses a state variable to track the number of movies to display. When the "Load More" button is clicked, the state is updated to increase the number of movies. Conversely, clicking the "Load Less" button reduces the number of movies displayed. The component fetches movie data from contentful GraphQL API and renders the results based on the current state.
Testing
I have added unit tests to cover the component's functionality, including:

Testing that the component renders without crashing
Testing that the component queries and renders movies data correctly.

To run unit tests: npm run test:unit
To get test coverage: npm run test:unit:coverage
Screenshots
Mobile View
View 1

View 2

View 3

Tablet View
View 1

View 2

Desktop View
View 1

View 2

View 3

This PR effectively adds a new
most-popular-movies component that provides a visually appealing way to showcase popular movies to users. The component's ability to load more or fewer movies enhances user experience and reduces initial load times for users with slower connections.


Callable[[Any * N], Any]: Trouble matching against constructors for certain built-in types

In the test suite's test_callable_p_r you will see lines like:
# NOTE: Cannot introspect constructor for certain built-in types
# TODO: Define __signature__ for failing internal types
self.assertTryCastFailure(Callable[[], Any], bool)
self.assertTryCastFailure(Callable[[], Any], int)
self.assertTryCastSuccess(Callable[[], Any], float)
self.assertTryCastSuccess(Callable[[], Any], complex)
self.assertTryCastFailure(Callable[[], Any], str)
self.assertTryCastSuccess(Callable[[], Any], list)
self.assertTryCastFailure(Callable[[], Any], dict)
self.assertTryCastSuccess(Callable[[], Any], tuple)

We want all of those lines to all be assertTryCastSuccess (and still have the test pass).
The failing lines above occur because an inspect.Signature cannot be generated for the constructor of certain built-in types:
inspect.signature(bool)  # ERROR: ValueError: no signature found for builtin type
inspect.signature(int)  # ERROR: ValueError: no signature found for builtin type
inspect.signature(float)  # OK
inspect.signature(complex)  # OK
inspect.signature(str)  # ERROR: ValueError: no signature found for builtin type
inspect.signature(list)  # OK
inspect.signature(dict)  # ERROR: ValueError: no signature found for builtin type
inspect.signature(tuple)  # OK

Based on reading the implementation of inspect.signature() and the underlying _signature_from_callable(), it looks like the desired fix would be to define an __signature__ on the type itself. For example:
sig = inspect.Signature()
bool.__signature__ = sig  # ERROR: TypeError: can't set attributes of built-in/extension type 'bool'
assert inspect.signature(bool) == sig

Unfortunately as the ERROR above alludes, there's no way to set __signature__ directly from normal Python code.
Next steps:

[ ] Find/create issue on upstream Python issue tracker RE inspect.signature(bool) (and calls on similar built-in types) not working
[ ] Shepherd that issue to resolution

The inspect.signature() documentation alludes:

Note: Some callables may not be introspectable in certain implementations of Python. For example, in CPython, some built-in functions defined in C provide no metadata about their arguments.

I think this issue should be considered a bug (and therefore prioritized higher than a normal enhancement) because its existence means that when checking against a Callable[[Any * N], Any] type, the output of trycast is NOT Decidable, which is a goal articulated in trycast's Philosophy.
However this issue is NOT a regression in functionality, so doesn't merit the "regression" label.


(PUP-6256) Ensure that agent run returns exit code instead of log entry

Before this commit, the Agent#run method would pass a block to the
Agent#run_in_fork that, in case a StandardError was raised, would
log the exception and then return the created Log instance. Since the
caller of the block expects an exit code, which it passes on in a call
to exit, it would fail with another exception when it instead passed
the returned Log instance.
This commit ensures that the block instead returns the integer 1 in case
a StandardError is raised.

CLA signed by all contributors.

Not sure why the appveyor run failed, re-running


fix(core) correct noisy acl warmup

Issue reference
Fixes #13205

Hi @ADD-SP @bungle, I believe it's a minor but significant fix. Could you please review it and proceed with merging?

Nice one @jeremyjpj0916 , keeping up the good work 😄 !

@Tieske yep trying to make moves from 2.8.x to 3.7.1 right now so will be calling out all the big/small issues I see. Been awhile since I really got to get hands on with Kong. Happy to submit things like this for easy low hanging fruit 🤣.
Glad to see you are still working with Kong! Been awhile since we met at the conferences.


Fix crash in extract_links when self text is blank

Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/user/builds/rtv/rtv/__main__.py", line 252, in <module>
    sys.exit(main())
  File "/home/user/builds/rtv/rtv/__main__.py", line 231, in main
    page.open_submission(url=url)
  File "/home/user/builds/rtv/rtv/subreddit_page.py", line 186, in open_submission
    page.loop()
  File "/home/user/builds/rtv/rtv/page.py", line 84, in loop
    self.controller.trigger(ch)
  File "/home/user/builds/rtv/rtv/objects.py", line 604, in trigger
    return func(self.instance, *args, **kwargs)
  File "/home/user/builds/rtv/rtv/submission_page.py", line 148, in open_link
    opened_link = self.prompt_and_open_link(data)
  File "/home/user/builds/rtv/rtv/submission_page.py", line 162, in prompt_and_open_link
    extracted_links = self.content.extract_links(data['html'])
  File "/home/user/builds/rtv/rtv/content.py", line 327, in extract_links
    soup = BeautifulSoup(html, 'html.parser')
  File "/usr/lib/python3.7/site-packages/bs4/__init__.py", line 246, in __init__
    elif len(markup) <= 256 and (
TypeError: object of type 'NoneType' has no len()

🙏


Should log file contain plain text database username passwords etc?

name: Bug report
about: Help us improve the framework by reporting bugs!

Database credentials in the log file in production mode
I have enabled logs for critical errors and I can see this information in my log files
CRITICAL - 2018-11-26 00:05:13 --> MySQL server has gone away
#0 /var/www/myproject/system/Database/MySQLi/Connection.php(177): mysqli->real_connect('my_database_host', 'my_database', 'my_password', 'my_database', 3306, '', 0)
#1 /var/www/myproject/system/Database/BaseConnection.php(369): CodeIgniter\Database\MySQLi\Connection->connect(false)
#2 /var/www/myproject/system/Database/BaseConnection.php(602): CodeIgniter\Database\BaseConnection->initialize()
#3 /var/www/myproject/application/Models/MydbModel.php(297): CodeIgniter\Database\BaseConnection->query('\r\n          SEL...')
#4 /var/www/myproject/application/Controllers/Home.php(95): App\Models\MydbModel->getCategoryData(Array)
#5 /var/www/myproject/system/CodeIgniter.php(810): App\Controllers\Home->category()
#6 /var/www/myproject/system/CodeIgniter.php(307): CodeIgniter\CodeIgniter->runController(Object(App\Controllers\Home))
#7 /var/www/myproject/system/CodeIgniter.php(221): CodeIgniter\CodeIgniter->handleRequest(NULL, Object(Config\Cache), false)
#8 /var/www/myproject/public/index.php(45): CodeIgniter\CodeIgniter->run()

Obviously I have replaced the above with dummy values but I am just wondering if log file should include information set by .env file? Having this information is useful, I suppose, to know which server it is trying to connect to and failing but I wanted to inform you about this.
CodeIgniter 4 version
CodeIgniter-4-develop

@natanfelles Sorry but my main concern is with the username and passwords being included in the log file.

yes - its "just" the error page in development mode
-> if you use the default error page in production mode everything is good.
only if you customize/create own the production error page take care of not show sensitive informations
/close everything is right

Is this something that CI is doing out of the box? or a situation where you are logging something and expect CI to suppress sensitive info?
If this is being logged by the MySQLi driver, then do we need to suppress the error when it happens, and recast it as an exception without sensitive info?
Should we make it clearer in the docs that sensitive info like this will show in the log, on purpose?

its logged by the callstack - its only shown in development

Never show sensitive informations and never log sensitive informations. We should prevent in the  development too.

@jim-parry

Is this something that CI is doing out of the box? or a situation where you are logging something and expect CI to suppress sensitive info?

Yes, out of the box in production mode.

If this is being logged by the MySQLi driver, then do we need to suppress the error when it happens, and recast it as an exception without sensitive info? Should we make it clearer in the docs that sensitive info like this will show in the log, on purpose?

Yes, I am using a MySQL database to connect to. I have two servers, one where I have my web app hosted and the other where I have mysql database hosted. One of the cron jobs restart my database server at midnight and that's when I get these errors in my log. I suppose the end user only sees "Whoops" page.
@puschie286 -

its logged by the callstack - its only shown in development Edit: there is already a note on the Multiple Environment page,

Yes I have enabled to log critical errors as I want to check my logs if there is anything broken on my site. The above log info is from production mode.


docker_error_capture_fix

Modified the Docker Runner execute() method return stdout as stderr if the exit code of the executed command was greater than 0.
Updated unit tests.

Codecov Report

Merging #56 (5d644b1) into main (4ac2159) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   94.84%   94.77%   -0.08%
==========================================
  Files          10       10
  Lines        1456     1435      -21
==========================================
- Hits         1381     1360      -21
  Misses         75       75

Flag
Coverage Δ

unittests
94.77% <100.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

build_magic/runner.py
94.07% <100.00%> (-0.05%)
:arrow_down:

build_magic/core.py
92.73% <0.00%> (-0.19%)
:arrow_down:

build_magic/reference.py
99.34% <0.00%> (-0.04%)
:arrow_down:

build_magic/cli.py
97.82% <0.00%> (-0.02%)
:arrow_down:

build_magic/output.py
98.97% <0.00%> (-0.02%)
:arrow_down:

build_magic/macro.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac2159...5d644b1. Read the comment docs.


Missing exported symbols on dlib shared library on MSVC

Expected Behavior
I want an "out of project" debug shared library build of dlib on VS2017 64 bit and link it from other compiled project. I'm aware of ODR rules and I think I am not in a violating condition.
Current Behavior
Building a debug enabled shared library on VS2017 64 bit doesn't produce a workable dll. Linking it from hello world program does risults in the following errors:
1>main.obj : error LNK2019: unresolved external symbol "public: __cdecl dlib::entropy_decoder_kernel_2::entropy_decoder_kernel_2(void)" (??0entropy_decoder_kernel_2@dlib@@QEAA@XZ) referenced in function "public: void __cdecl dlib::compress_stream_kernel_1<class dlib::entropy_encoder_model_kernel_5<257,class dlib::entropy_encoder_kernel_2,200000,4>,class dlib::entropy_decoder_model_kernel_5<257,class dlib::entropy_decoder_kernel_2,200000,4>,class dlib::crc32>::decompress(class std::basic_istream<char,struct std::char_traits<char> > &,class std::basic_ostream<char,struct std::char_traits<char> > &)const " (?decompress@?$compress_stream_kernel_1@V?$entropy_encoder_model_kernel_5@$0BAB@Ventropy_encoder_kernel_2@dlib@@$0DANEA@$03@dlib@@V?$entropy_decoder_model_kernel_5@$0BAB@Ventropy_decoder_kernel_2@dlib@@$0DANEA@$03@2@Vcrc32@2@@dlib@@QEBAXAEAV?$basic_istream@DU?$char_traits@D@std@@@std@@AEAV?$basic_ostream@DU?$char_traits@D@std@@@4@@Z)
1>main.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl dlib::entropy_decoder_kernel_2::~entropy_decoder_kernel_2(void)" (??1entropy_decoder_kernel_2@dlib@@UEAA@XZ) referenced in function "public: void __cdecl dlib::compress_stream_kernel_1<class dlib::entropy_encoder_model_kernel_5<257,class dlib::entropy_encoder_kernel_2,200000,4>,class dlib::entropy_decoder_model_kernel_5<257,class dlib::entropy_decoder_kernel_2,200000,4>,class dlib::crc32>::decompress(class std::basic_istream<char,struct std::char_traits<char> > &,class std::basic_ostream<char,struct std::char_traits<char> > &)const " (?decompress@?$compress_stream_kernel_1@V?$entropy_encoder_model_kernel_5@$0BAB@Ventropy_encoder_kernel_2@dlib@@$0DANEA@$03@dlib@@V?$entropy_decoder_model_kernel_5@$0BAB@Ventropy_decoder_kernel_2@dlib@@$0DANEA@$03@2@Vcrc32@2@@dlib@@QEBAXAEAV?$basic_istream@DU?$char_traits@D@std@@@std@@AEAV?$basic_ostream@DU?$char_traits@D@std@@@4@@Z)
1>main.obj : error LNK2019: unresolved external symbol "public: void __cdecl dlib::entropy_decoder_kernel_2::set_stream(class std::basic_istream<char,struct std::char_traits<char> > &)" (?set_stream@entropy_decoder_kernel_2@dlib@@QEAAXAEAV?$basic_istream@DU?$char_traits@D@std@@@std@@@Z) referenced in function "public: void __cdecl dlib::compress_stream_kernel_1<class dlib::entropy_encoder_model_kernel_5<257,class dlib::entropy_encoder_kernel_2,200000,4>,class dlib::entropy_decoder_model_kernel_5<257,class dlib::entropy_decoder_kernel_2,200000,4>,class dlib::crc32>::decompress(class std::basic_istream<char,struct std::char_traits<char> > &,class std::basic_ostream<char,struct std::char_traits<char> > &)const " (?decompress@?$compress_stream_kernel_1@V?$entropy_encoder_model_kernel_5@$0BAB@Ventropy_encoder_kernel_2@dlib@@$0DANEA@$03@dlib@@V?$entropy_decoder_model_kernel_5@$0BAB@Ventropy_decoder_kernel_2@dlib@@$0DANEA@$03@2@Vcrc32@2@@dlib@@QEBAXAEAV?$basic_istream@DU?$char_traits@D@std@@@std@@AEAV?$basic_ostream@DU?$char_traits@D@std@@@4@@Z)
1>main.obj : error LNK2019: unresolved external symbol "public: void __cdecl dlib::entropy_decoder_kernel_2::decode(unsigned int,unsigned int)" (?decode@entropy_decoder_kernel_2@dlib@@QEAAXII@Z) referenced in function "public: void __cdecl dlib::entropy_decoder_model_kernel_5<257,class dlib::entropy_decoder_kernel_2,200000,4>::decode(unsigned long &)" (?decode@?$entropy_decoder_model_kernel_5@$0BAB@Ventropy_decoder_kernel_2@dlib@@$0DANEA@$03@dlib@@QEAAXAEAK@Z)
1>main.obj : error LNK2019: unresolved external symbol "public: unsigned int __cdecl dlib::entropy_decoder_kernel_2::get_target(unsigned int)" (?get_target@entropy_decoder_kernel_2@dlib@@QEAAII@Z) referenced in function "public: void __cdecl dlib::entropy_decoder_model_kernel_5<257,class dlib::entropy_decoder_kernel_2,200000,4>::decode(unsigned long &)" (?decode@?$entropy_decoder_model_kernel_5@$0BAB@Ventropy_decoder_kernel_2@dlib@@$0DANEA@$03@dlib@@QEAAXAEAK@Z)
1>main.obj : error LNK2019: unresolved external symbol "public: __cdecl dlib::base64::base64(void)" (??0base64@dlib@@QEAA@XZ) referenced in function "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const __cdecl dlib::get_serialized_frontal_faces(void)" (?get_serialized_frontal_faces@dlib@@YA?BV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ)
1>main.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl dlib::base64::~base64(void)" (??1base64@dlib@@UEAA@XZ) referenced in function "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const __cdecl dlib::get_serialized_frontal_faces(void)" (?get_serialized_frontal_faces@dlib@@YA?BV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ)
1>main.obj : error LNK2019: unresolved external symbol "public: void __cdecl dlib::base64::decode(class std::basic_istream<char,struct std::char_traits<char> > &,class std::basic_ostream<char,struct std::char_traits<char> > &)const " (?decode@base64@dlib@@QEBAXAEAV?$basic_istream@DU?$char_traits@D@std@@@std@@AEAV?$basic_ostream@DU?$char_traits@D@std@@@4@@Z) referenced in function "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const __cdecl dlib::get_serialized_frontal_faces(void)" (?get_serialized_frontal_faces@dlib@@YA?BV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ)
1>main.obj : error LNK2001: unresolved external symbol USER_ERROR__inconsistent_build_configuration__see_dlib_faq_1_
1>main.obj : error LNK2001: unresolved external symbol DLIB_VERSION_MISMATCH_CHECK__EXPECTED_VERSION_19_15_99

Apparently some some symbols are not correctly exported for shared linking.
Steps to Reproduce

Download dlib 19.15 or provided head.
Compile with following script:

md build 2> NUL
cd build
cmake -G "Visual Studio 15 2017 Win64" -T host=x64 -DBUILD_SHARED_LIBS=ON -DCMAKE_INSTALL_PREFIX=%cd%\target ..
cmake --build . --target install --config Debug
pause

Unzip dlibtest.zip hello world program;
Fix hardcoded paths in CMakeLists.txt;
Run boostrap.cmd, which is same as the following script:

md build 2> NUL
cd build
cmake -G "Visual Studio 15 2017 Win64" -T host=x64 ..
cmake --build . --config Debug
pause

Notice linking errors.

Version: v19.15 or current head (65a73ea7a46ee0f000ea6deb6d51a67e955ee7d8)
Where did you get dlib: dlib.net, official github repo
Platform: Windows 10 64 bit
Compiler:  MSVC 2017 15.8.4

Hmmm, I just noticed that no class/function I'm checking is decorated with a classic macro that switch between __declspec(dllexport) and __declspec(dllimport) in MSVC, which is required. Is the shared library use case supported in Windows? Am I missing something?  I am unable to find any information regarding in the faq or compile guide.

I highly recommend not building this way.   But yes, there are no _declspec annotations.  This is on purpose.  You could do something like use https://cmake.org/cmake/help/v3.4/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html.  But really, there is no reason to build dlib this way.  While it's fine to build shared libraries on other systems like Linux, the way visual studio handles shared libraries, especially C++ libraries, is very undesirable.
So unless you really understand all the implications you should not do it.

I take your points and they are well made.  However, there is also the issue that the vast majority of dlib’s code is templated. If it weren’t for that I would be more amenable to the idea. But right now building a shared library version doesn’t really get you very much since all those templates are going to be statically built into your app anyway.
There is a secondary issue that the vast majority of dlib users don’t understand how to use a dll. Trust me when I say this that your understanding of the issues here is in the top 0.1% of people who ask me about using dlib in visual Studio. Any suggestion to build a dll version of dlib in the documentation increases the number of confused emails I get.
Past versions of dlib used to explicitly forbid building shared versions of dlib in visual studio. That was refactored out (as an incidental part of larger changes) and should probably be put back in with an appropriate error message as documentation.


operator [R] gitlab-runner-operator (1.11.0)

This PR is related to case number 03428081 in https://connect.redhat.com/support/technology-partner/
Versions of GitLab Runner Operator before 1.11 do not include the com.redhat.openshift.versions label. Starting with version 1.11 com.redhat.openshift.versions was added with the value 4.8-4.10. This means that GitLab Runner Operators versions before 1.11 incorrectly claim to support OpenShift versions <4.8 and >4.10. To avoid confusion, we'd like to remove GitLab Runner Operator version which don't specify com.redhat.openshift.version.
Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.

/retest

/retest-required

Hi @J0zi @mvalarh a handful of tests have failed but I'm not sure what to make of them or how to proceed. Could you provide some guidance please? Thanks in advance.

@bertoldia since you are removing all versions prior to 1.11.0, you should remove replaces: gitlab-runner-operator.v1.10.0 from 1.11.0's CSV.

/merge possible

/merge possible

Hi @J0zi, @mvalarh This PR is ready to merge. Is one of you able to do that? Thanks.

@ggeorgiev-gitlab , please approve as you are original reviewer

@bertoldia yes we can do it but we prefer that reviewer listed in ci.yaml file approve it.

/unhold

Btw the bot's link from https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/2234#issuecomment-1431728299 doesn't work

/merge possible

Thanks @J0zi, @mvalarh, @ggeorgiev-gitlab :+1:


Fix website "go home" links

The built GitHub pages "Go Back" links do not work.
https://zenika.github.io/zenika-career-paths-framework/


Embed tweets for presentation in search results in NRTS demo

@xeniaqian94 take a look at this:
https://dev.twitter.com/web/embedded-tweets
In the NRTS demo search results, let's embed tweets for presentation. Check out this as an example:
http://lintool.github.io/JScene/search-demo.html

Will fix it soon.
A small puzzle is to correctly render css/js element into a Mustache template, in specific, putting files like bootstrap.min.css in the correct directory when referred in template  <link href="bootstrap.min.css" rel="stylesheet"> Inline css/js codes could work but separate js/css file would be preferable for good organization.
Posted the question Mustache community, waiting for some help...
https://github.com/spullara/mustache.java/issues/159

You can just link to a publicly available absolute URL?

This isn't (necessarily) a Mustache issue.
It has to do with how Jetty is being configured to serve up static files. Currently it isn't.
The simplest solution is to do as Jimmy suggested and use a CDN for the necessary bits.
The "better" solution would be to correctly configure the Jetty server to serve static content. In doing so, we have the ability to develop more interesting web applications later.
I'm not super familiar with Jetty but I believe the two easiest options are:

edit the doGet function in TweetServlet and manually serve up the necessary files

This is the super hacky way to do it and you probably don't want this

actually set up a static content directory and serve from there

See http://stackoverflow.com/questions/10284584/serving-static-files-w-embedded-jetty
The Jetty tutorial also talks about this a bit (apparently)
The real trick here is to set up static content serving and dynamic content to work well together.    In node.js, this means getting the order of setting handlers right. Likely means something similar here but with more Java cruft.

Agree with @aroegies
Yes, serving static content is something we'll need to eventually do.

So as it turns out, I didn't want to do any actual work today and got this entire thing working.
That is:

serving up static content
embedding tweets with the Twitter Embed API

There are pretty-ification issues with the current displaying of embeded tweets but that's neither here nor there.
In addition, there is probably a better way to use Mustache to doing the tweet embedding but the way I did was the most expedient and didn't involve me learning too much about Mustache.
See commit a37b5079557024e767356bd55f939519274eadf5 in my fork for code.

Thanks for the help/code. Then let me follow up with the rest trivial part.

@xeniaqian94 seems like @aroegies fixed this: https://github.com/aroegies/Anserini/commit/a37b5079557024e767356bd55f939519274eadf5
Look at that branch? See https://github.com/lintool/Anserini/network for context.

Merged commit 35690612eead265e7b7284ab13cfee0b8de5f4f3


Manage site "maintenance" / "coming soon" page from env

Hello,
i would introduce inside the openserverless-site templates the parsing of an env variable called HUGO_SITE_MAINT (or something like..).
When this is set to true, all the routes are disabled and only the homepage with the "Coming Soon" message is displayed.
When unset (or set to false), the full website is displayed.
This can be useful to start the merge of the code on the main repository, allowing other members to work on it without searching the "latest code" on forks.

+1
This would ease the introduction of new documentation steps, so I strongly support this type of feature.

Hello,
i've implemented the feature.
If you look at the Taskfile.yml in the branch issue_49 inside my fork, i've added an env variable called
HUGO_SITE_MAINT.
When set to true a "COMING SOON" page is displayed.
You can see the live preview here: https://openserverless-demo.netlify.app/
However, to make available this code, i need to do a first big PR from my fork/branch to openserverless-site/main.
Let me know if I can proceed.

+1
A great feature that speeds up and simplifies development


Python 3.10 incompatible

Hi! 👋
I've been working on upgrading Home Assistant to Python 3.10, and noticed this package isn't compatible with Python 3.10.
Python upgrade PR: https://github.com/home-assistant/core/pull/59729
Error from tests:
  File "/__w/core/core/venv/lib/python3.10/site-packages/velbusaio/protocol.py", line 51, in __init__
  self._send_queue = asyncio.Queue(loop=self._loop)
  TypeError: As of 3.10, the *loop* parameter was removed from Queue() since it is no longer necessary

A quick sneak peek/search revealed more cases of passing the loop argument:
https://github.com/Cereal2nd/velbus-aio/search?q=loop
Could this be fixed? 🙏  ❤
Thanks!
../Frenck

Started working on this
https://github.com/Cereal2nd/velbus-aio/compare/py310


fix needed - Auto camera position

Sometimes the camera can be named persp1,  fix_camera should at least check if persp camera exists first .
# Traceback (most recent call last):
#   File "/users/lrpvottero/git/vtool/python/vtool/process_manager/ui_data.py", line 2878, in _open_file
#     self.data_class.open()
#   File "/users/lrpvottero/git/vtool/python/vtool/data.py", line 3340, in open
#     self._after_open()
#   File "/users/lrpvottero/git/vtool/python/vtool/data.py", line 3220, in _after_open
#     self._center_view()
#   File "/users/lrpvottero/git/vtool/python/vtool/data.py", line 627, in _center_view
#     maya_lib.core.auto_focus_view()
#   File "/users/lrpvottero/git/vtool/python/vtool/maya_lib/core.py", line 2035, in auto_focus_view
#     fix_camera()
#   File "/users/lrpvottero/git/vtool/python/vtool/maya_lib/core.py", line 2039, in fix_camera
#     camera_pos = cmds.xform('persp', q=True, ws=True, t=True)
# ValueError: No object matches name: persp

This is fixed with this pull
https://github.com/louisVottero/vtool/pull/451


Question: Has anyone managed to place the scanner in the background?

Just a quick question; has anyone managed to put the scanner in the background of the web view with the current version/release?
I know this has been asked before but I can not determine the answer from previous threads.
If not, what work need to be done to make this happen.

No, it's not possible with the plugin as it's implemented


Test

Testing this project feature

This is a test to close the issue

This is the second test to close this issue


UseStaticImport should rewrite if method already exists

What version of OpenRewrite are you using?

org.openrewrite:rewrite-core:jar:8.29.0

What is the smallest, simplest way to reproduce the problem?
UseStaticImport should not rewrite with an import static when there is a method in the scope with the same name (and maybe signature).
The second case below I'm not sure how to best deal with, perhaps don't rewrite the String.valueOf, or do what the test here does.
  @Test
  void testUseStaticImport() {
    rewriteRun(
        spec -> spec.recipe(new UseStaticImport("java.util.List of(..)")),
        // language=java
        java(
            """
                    package com.helloworld;

                    import java.util.List;

                    public class Foo {

                        void of() {}

                        void foo() {
                          List.of();
                        }
                    }
            """));
  }

  @Test
  void testUseStaticImport2() {
    rewriteRun(
        spec ->
            spec.recipe(
                new CompositeRecipe(
                    List.of(
                        new UseStaticImport("java.lang.String valueOf(..)"),
                        new UseStaticImport("java.lang.Integer valueOf(..)")))),
        // language=java
        java(
            """
                    package com.helloworld;

                    public class Foo {
                        void foo() {
                          String.valueOf("1");
                          Integer.valueOf("1");
                        }
                    }
            """,
            """
                    package com.helloworld;

                    import static java.lang.String.valueOf;

                    public class Foo {
                        void foo() {
                          valueOf("1");
                          Integer.valueOf("1");
                        }
                    }
            """
        ));
  }

Are you interested in contributing a fix to OpenRewrite?
Happy to give it a try with some pointers, as usual not sure where to start.

Thanks for the report! In this case I think extending the preconditions with a separate visitor that looks at static imports used might be best. We already have a check on not declaring any similarly named methods. This would be a similar check but then looking at not having any similarly named static imports already.
https://github.com/openrewrite/rewrite/blob/c97c7f214634c78b257e6a7eb6705727f3d46900/rewrite-java/src/main/java/org/openrewrite/java/UseStaticImport.java#L62
Welcome to add just those two unit tests to a draft pull request to kick this off; then we can see if you work it out from there, or tag team to get this through.

We already have a check on not declaring any similarly named methods

Is that intended to inhibit the behaviour in the first test I included? I happened to notice that the buggy behaviour there seems to require the class being in a package, so perhaps something is broken with the precondition.

Hmm; Yes thanks for calling that out! Shows again why I love runnable bug reports. Makes troubleshooting much easier.

Here's a start: https://github.com/openrewrite/rewrite/pull/4307. This fixes the bug with not taking the package name into account, but does not add a precondition for already imported methods yet.


Offline use for 0.8.1

If building the offline versions for the different platforms, using node-webkit, isn't too hard, it would be great to have instructions on the Wiki.
I want to use 0.8.1 offline but the dmg isn't available yet. I'd have no problem building myself, I just don't know how.
Thank you for the great little app.

Oh well, here's the instructions


FutureProvider.future not yielding result immediately if inner FutureOr is a value

Describe the bug
FutureProvider works on FutureOr, but FutureProvider.future does not properly work if the inner future is a value.
To Reproduce
import "package:flutter_riverpod/flutter_riverpod.dart";

final aProvider = FutureProvider((ref) => 42);
final bProvider = FutureProvider((ref) => ref.watch(aProvider.future));

final dummy = Provider((ref) {
  final a = ref.watch(aProvider);
  final b = ref.watch(bProvider);
  print("a: $a");
  print("b: $b");
  print("");
});

Future<void> main() async {
  final container = ProviderContainer();
  container.listen(dummy, (previous, next) {});
  await Future.any([]);
}

Output:
a: AsyncData<int>(value: 42)
b: AsyncLoading<int>()

a: AsyncData<int>(value: 42)
b: AsyncData<int>(value: 42)

Expected behavior
b should immediately be AsyncData<int>(value: 42).

There's nothing wrong with that. That's how Future behaves. They are async, and therefore emit their result after a minor delay.
This isn't a Riverpod problem.


[BUGFIX] Do not require meta package typo3/minimal

Do not require the meta package typo3/minimal but require
the packages that are really required by the package itself.
Do also add a suggestion to install typo3/testing-framework
as it is required by the bootstrap.
Fixes #3

Thanks a lot!


Create a Features card medium filled

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component and add the component in Features Card/features-card-medium-filled.html.
If you need to use any icon please use it from Hero Icons
Good luck.

please assign me this

You have already been assigned to an issue. @devjain2309

It's completed now. You can assign me this.

Sure @devjain2309

But first check the comment on the previous PR.

@Rajdip019 please check my previous PR and if you found it right then assign me this.

Allow me to work on this issue.

Are you still working on this issue? @devjain2309


Removed deprecated packages by upgrading @babel/cli to version 7.16.7

I noticed some deprecated package warnings when I was installing dependencies:
madison ~/projects/redux
532 ߷  rm -rf node_modules && npm ci
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated

added 1029 packages, and audited 1030 packages in 13s

88 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

After looking into these packages, it seems that they are only depended upon by one package in the project, @babel/cli:

madison ~/projects/redux
533 ߷  npm ls urix
<EMAIL_ADDRESS>/Users/madison/projects/redux
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        └─┬<EMAIL_ADDRESS>          └──<EMAIL_ADDRESS>

madison ~/projects/redux
534 ߷  npm ls resolve-url
<EMAIL_ADDRESS>/Users/madison/projects/redux
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        └─┬<EMAIL_ADDRESS>          └──<EMAIL_ADDRESS>
After upgrading @babel/cli, the urix and resolve-url packages seem to no longer be needed:
madison ~/projects/redux
543 ߷  npm ls urix
<EMAIL_ADDRESS>/Users/madison/projects/redux
└── (empty)

madison ~/projects/redux
544 ߷  npm ls resolve-url
<EMAIL_ADDRESS>/Users/madison/projects/redux
└── (empty)

Changelog

Removed dependencies to the deprecated urix and resolve-url packages by upgrading @babel/cli to version 7.16.7

Heh, and we're just rippling the package conflicts down through one PR at a time :)
If you see any other packages that ought to be updated now, might as well go ahead and roll them into this PR too.


Add search endpoint for Books

API Endpoint or Feature
It would be very useful to have a search endpoint in the REST API.
Use-Case
Exploring using Bookstack as a user guide for an application, but we plan to develop a context-sensitive-help feature which will allow users to search help docs from within the application. A search endpoint in the REST API would be essential for this. Thanks!
Additional Context
If required, add any other context about the feature request here.

Thanks for the request @come2thecabaret.
I've just come across #909, which was opened before we finished, or even started, work on the API. Since that covers the same request I'll close this off as a duplicate.
You can do some level of searching via the current API endpoints. Please see my comment in #909 to see how this would be done.


Upgrade to Jinja2 v3

Description
Fixes dependency issues in downstream projects. Jinja2 is unsupported
and currently broken. As a result, the tiler project would throw on startup.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
In the tiler serveice, templates are used for the item_preview endpoint. The item_preview endpoint is generated correctly under this version of Jinja2
Checklist:
Please delete options that are not relevant.

[x] I have performed a self-review
[ ] Changelog has been updated
[ ] Documentation has been updated
[x] Unit tests pass locally (./scripts/test)
[x] Code is linted and styled (./scripts/format)

Have you thought about moving the requirements out of setup.py and into a requirements.txt and then using something like Dependabot to manage updates? I don't fully understand the relationship between the pins here and deployed services, but IMO anywhere where we have exact pins we should be using something like dependabot to keep them up to date.

In cases like this where setup.py is used for dependencies, is it recommended to use 3.0.* or even 3.*?

I think the relevant question is: is this repository for a library or an application? If it's an application, then pins be as strict as possible and updated explicitly. If it's a library, then things should be specified as loosely as we're willing to maintain.
Once you've determined that you can organize things however you want. setup.py files can include arbitrary Python code, and so can read from a requirements.txt to pass along to install_requires.

As I'm the one who moves the requirements to the setup.py I think I have to answer for it 😄

I think the relevant question is: is this repository for a library or an application? If it's an application, then pins be as strict as possible and updated explicitly.

The way it's structured, right now it's both, because the library like pccommon is used in pctiler and pcstac. Which is one of the reason we needed the setup.py.
As for only using requirement.txt (and reading it from setup.py), this is not something recommended, as mentioned in https://newbedev.com/requirements-txt-vs-setup-py it's usually the other way.
maybe we could do something like what rasterio uses:

runtime requirements: https://github.com/rasterio/rasterio/blob/master/setup.py#L259-L270
test env requirements: https://github.com/rasterio/rasterio/blob/master/requirements.txt

also worth mentioning that most of libraries now use setup.cfg and/or pyproject.toml files to manage their installation requirement, using requirement.txt is less and less common.


Update price of a listing(contract)

We are planning on integrating Open Bazaar into our store and one of our primary requirements in addition to creating listings(contract) is that we want to be able to update price of an existing listing(contract) dynamically based on available inventory size, etc.. I checked the code of the restapi.py on the server. There seems to be no API available to update a contract.
Is this something that is planned for any future releases?
Thanks in advance.
Sridhar

If this would be important for other users of the community, it would be good if you could come up with any suggestions/feedback on such an API. We would be happy to contribute this feature for the community.

If you pass the contract_id parameter to the contracts call, it updates that contract with the new data you've sent.

@jjeffreys,
Thank you for your response. I did notice that we can pass the contract_id and it would update with the new data.
I do not know how useful it would be for others, however, for our usecase, we would have only price and quantity of the inventory updating frequently. In this case, passing all data again to the contract is quite heavy for us. We have hundreds of thousands of products in our inventory and will be making price updates of that order or even much more every day. We still have no clue how scalable this platform is, we will be testing all this in the coming weeks.
Also, this feature - to update price and quantity, is almost a standard in many marketplaces - Amazon, eBay, for high volume sellers. We are one such seller who are testing out this OpenBazaar platform.
The light weight API I have in my mind is something like -
update_inventory_status(contract_id, price, quantity) - which would update price and quantity of the given contract, leaving rest of the details unchanged.
Let me know your thoughts if this would be valuable API for the community(It is for us) or any suggestions you have about the API itself.
Thanks,
Sridhar

Currently contacts don't have a quantity. We will be adding that in the future, when we do that we'll look at allowing partial updates to contracts. If we changed the contract api to only update the data that was sent (so you could send only the contract_id and the parameters you want to change) that would cover your scenario, correct?

Partial updates - this would be a great feature! And true, allowing partial updates would cover my usecase and much better than adding a new API.
Do you have any estimates on when we can expect this feature? We are not in a hurry, but just wanted to understand from a timeline perspective.
Thanks again for your reply. Very much appreciated.

Inventory management is on our short term roadmap. https://trello.com/b/dF6ymHGU/openbazaar-high-level-roadmap


The downloaded 3dmatch Dataset cannot be read

It seems like some .npz files is damaged,and cannot be read


504 error when browsing directories in large repo

Gitea version (or commit ref): main (commit 8fa3bbc42450fe34cc0cee3de566b17fa131d1c6, built with Go 1.16.4)
Git version: 2.31.1
Operating system: Debian 10

Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No (not relevant)

Log gist: log

Description
I have a copy of GCC repo on my Gitea instance on LXD container.
I'm trying to browse gcc/ subdirectory, but it always returned 504 error, presumably because the subdirectory contained 946 entries (directories and files). I used to be able to access the subdirectory sometimes in the past.
Inspecting using Developer Tools on Firefox, I noticed that the HTTP request during the attempt was initiated by BrowserTabChild.jsm script, but slow response time from server (1 minute) might cause the error.
I'm running Gitea behind NGINX as reverse proxy, and the relevant NGINX config is:
    location / {
        proxy_pass http://<IP_ADDRESS>:3000;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    }

Screenshots

[not relevant]

This is a timeout.
Please test #16059 to see if this solves your problem - if not try #16063 or try building with gogit enabled instead.

@zeripath I don't see any difference when building with TAGS="bindata gogit"; still returned 504.
And I can't test #16063 because it means downgrading database, and I only have one Gitea instance (as production), and I don't want to spin up another instance because of memory constraints on my computer (I only have 4 GB RAM).

@zeripath on first load of subfolder gcc it took 169161ms to load! (dbms: mysql; version<PHONE_NUMBER>; no-gogit)

@bagasme for now you just have to raise git timeout limits via config

I have this same problem. Our prod server, running v1.14.6 of Gitea is NOT having this problem, but every time I populate our develop server running Gitea v1.15.0 with the same DB and filebase, if I go to https://develop.door43.org/unfoldingWord/en_tn it will sometimes timeout. It doesn't do it every time, sometimes it does show the page, sometimes it doesn't. I have debugged and I found where it is stopping is when it tries to do the Discard(1) when b.n is 0 for the README file (which in my problematic repo has a size of more than 4096 bytes). It is failing here:
https://github.com/go-gitea/gitea/blob/main/modules/git/blob_nogogit.go#L126
I don't know if this is the same as the gcc repo being used, as it has a smaller README file. @zeripath I am not sure why the Discard(1) never returns, not even if I set my TIMEOUT really high. This page shows that it should return an error when there are no bytes in the buffer, which I assume is the case when the code reaches the line linked above? See https://pkg.go.dev/bufio#Reader.Discard

Oh wait, maybe @6543 fixed this with https://github.com/go-gitea/gitea/pull/16899? Does that sound like the issue that was fixed @6543 ?

Hmm, I am using the latest code from release/v1.15 and does have the DataAsync fix. Yet do wonder about that Discard(1) call when there are no bytes to read...

Ok, looks like the above fix fixes the Close() call that seemed to previously be hanging.

Not sure if this is/was the same problem that the OP repo was having though. @bagasme you may want to try the latest of of the development branch (main) or the release/v1.15 branch.

@Richmahn is the hold up definitely occurring at blob.Close()? Two options for what is going on here :

A miscount with the buffering code:

echo $SHA | git cat-file --batch

will return a header line which read by ReadBatchLine followed by the blob content + a trailing '\n'.
But I can't see a miscount there.

Some buffering or slow flushing?

This may be similar to the reasons why windows users seem to have trouble with the native backend. On #16773 I've had to use an os.Pipe and explicitly Sync the stdinWriter - maybe we need something like that for the stdoutReader?
Looking at the code for go's exec it appears that using io.Pipe doesn't avoid an os.Pipe from being created so we can get get rid of the io.Pipe.

I'm sorry that there appears to be a bug here - I'm really kinda stumped as to what's going on though. Perhaps the fixes from @6543 will have fixed the issue. What I'll do it is clone the repo and see if I can make it happen locally.

Some questions:

What OS are you running on?
What version of git?

Not sure if this is/was the same problem that the OP repo was having though. @bagasme you may want to try the latest of of the development branch (main) or the release/v1.15 branch.

Yeah I think this issue is regarding something different and is to do with the old algorithm. Those problems should be a lot less frequent now.

@zeripath Running on an AWS server:
$ cat /proc/version
Linux version 4.14.241-184.433.amzn2.x86_64 (mockbuild@ip-10-0-1-230) (gcc version 7.3.1 20180712 (Red Hat 7.3.1-13) (GCC)) #1 SMP Wed Aug 4 14:35:15 UTC 2021
$ git version
git version 2.32.0

So no, not Windows. It was occurring right there at the .Close() call I put Printf()s everywhere. It was the Close() for when the repo home page reads the README file and was trying to close it in the defer. I increased my timeout in the config to 600 and it still never returned for the page. However, if I refreshed the page, it would sometimes work.

Ok, looks like the above fix fixes the Close() call that seemed to previously be hanging.

Does this imply that the problem is fixed now?

I just now today found what was going on with my repos and my 504. I am working from a fork of Gitea for my company which adds features, one being to look at a manifest.yaml file in the root directory of a repo and read it like Gitea does the README.md file. I found since Gitea change to using a CatFileReader, my YAML file reader was closing it when it did a ReadAll(). I just today fixed it to use a MultiReader and leave the CatFileReader open for other batch calls. So it was an error in my own code.


Open Preview to the Side button desapeared.

I was wondering weather this was only happening to me.
I use MARP in VS Code and all of a sudden the Open Preview to the Side button desapeared. Just like in the picture below:

Any ideas about?
Thanks in advance!

Transferred issue from marp-cli repository to marp-vscode. 🚚
Other extensions that have been installed together with Marp for VS Code may make an adverse effect.
For example, Markdown Preview Enhanced, that is one of very popular Markdown extension in VS Code, will hijack and hide VS Code's Open Preview to the Side button. If MPE extension had been installed into your VS Code, try to disable the extension, or turn off markdown-preview-enhanced.hideDefaultVSCodeMarkdownPreviewButtons in settings.

Require to restart VS Code after changing the state.

MPE can write and preview presentation in Markdown but does not support Marp, and also not provide the contribution point to extend Marp support.

Related issue: https://github.com/shd101wyy/markdown-preview-enhanced/issues/1253

Of course, the other extension also might make the button hide. If necessary, you can find out the extension that brings a root cause by using extension bisect.

Most certainly this is the cause!
Thank you very much for your perfect explanation!


Constraints documentation - Technical Constraints

New branch feature_arc42_02constraints_technical created.

First commit for the branch added. It is a first approach to describe the first two remarkable technical constraints.

Ended first draft of the technical constraints. Merged changes into the central branch for architecture constraints.


Eventbus.publish calls its listeners without a try catch

OpenUI5 version:
Any (originally found in 1.108.15 but the relevant code has not changed since)
Browser/version (+device/version):
Firefox 123.0 (64-Bit)
URL (minimal example if possible):
I created a small example based on the openui5 sample app (only changed the controller and view)
https://github.com/Johan482/minExampleSAPUI5NoTryCatchEventbus
It has 2 buttons which each publish an event that has 2 listeners.

The normal button simply logs in both listeners
The dump button throws an error in the first and logs in the second

Steps to reproduce the problem:

Open the example and start the webserver

Open the console
Click on the button "Publish the normal event"

Click on the button "Publish the dump event"

What is the expected result?
In both cases the data is correctly published and the second listener has no errors.
Therefore second listener should be called regardless of what happens in any others.
What happens instead?
The listeners are called in a loop without any errorhandling, so any errors cause subsequent listeners to no longer be called.
In this case step 5 does not call the second listener.
Any other information? (attach screenshot if possible)
The problem is in src/sap.ui.core/src/sap/ui/core/EventBus.js L. 231

A try catch statement is needed either here or in the _callListener function

Hello @Johan482 ,
Thank you for sharing this finding. I've created an internal incident DINC0085566. The status of the issue will be updated here in GitHub.
Regards,
Iliana


llama example seems broken

I am trying to run the llama example, and I am getting this (endless) repeated generation:
cargo run --release --features cuda --example llama
loading the model weights from meta-llama/Llama-2-7b-hf
starting the inference loop
My favorite theorem is 1+1=2.
I'm a mathematician, and I'm a computer scientist. I'm a professor at the University of California, Berkeley. I'm also a member of the Simons Institute for the Theory of Computing.
I'm interested in the foundations of mathematics, and in the foundations of computer science. I'm interested in the foundations of mathematics because I think that mathematics is the most beautiful thing we know, and I want to understand it better. I'm interested in the foundations of computer science because I think that computers are the most powerful tools we have, and I want to understand them better.
I'm interested in the foundations of mathematics because I think that mathematics is the most beautiful thing we know, and I want to understand it better. I'm interested in the foundations of computer science because I think that computers are the most powerful tools we have, and I want to understand them better.
I'm interested in the foundations of mathematics because I think that mathematics is the most beautiful thing we know, and I want to understand it better. I'm interested in the foundations of computer science because I think that computers are the most powerful tools we have, and I want to understand them better.

It's very common to have repeating generation with LLMs if you don't enforce a repeating-penalty, you can turn it on with --repeat-penalty 1.1 for example.

Thanks ! I have tried with different penalties: 1.1, 1.15, 1.2, 1.5 and it still repeats itself up to 1.15, from 1.2 on it provides very short answers (without repetition). That said, a short answer would be best, in this case.

Did you also add a temperature?

Closing this as hopefully fixed, note that with the introduction of llama-3 i've changed the parameters from the example so that there is a default temperature and repeat penalty and it will be less confusing.


Error says, 'pls buy a quantum computer with blackhole at the core to run the program securely'

Clearly it is an issue with your hardware. Have you tried running it with no power and no hardware whatsoever? Also make sure no people are in the area, as people tend to mess things up.
When run completely in a vacuum this is entirely stable and secure.


Added OWASP top 10 list to security section

OWASP maintain a very useful list of common web application security issues

25/100


Alternative Site Name in WP Admin Bar

It is not easy in some user installs to identify the right site for each language. It would be helpful, it is possible the Alternative Title would be use in the Site Name of the Admin Bar.
Currently helps this plugin.
https://gist.github.com/bueltge/7abfbfc65f1f19a782cc
But, will we add this to the core. The result is a optional settings or not? Or we use it always, if is set in the settings to each site?

From directly discussion. Is not a option for the core, overhead and additionals for settings. We will rewrite the add on to use the MLP API and done, ready to use.
see http://make.marketpress.com/multilingualpress/2015/02/how-to-get-translations-programmatically/

New discussion for feature in MLP Core.

After we release this new feature, we should remove the add-on from the wiki.

Ready to merge via #182

Closed in https://github.com/inpsyde/multilingual-press/commit/fb0478765701b65a16841e8dff5d67c3e7451fc8.


Question about HNSW index creation

The workflow of a dense document store is creating all the points with write_documents and then creating their embeddings with update_embeddings.
My question is about the HNSW graph; write_documents creates points with random vectors (fill_missing_embeddings=True). So the HNSW graph is built around these random points. Later when using the real embeddings, does the graph adapts to the real vectors? Does doing this 2 step process lead to suboptimal searching results and it might be better to have the embeddings prepared for a single insertion via write_documents?  Thanks~

@danielfleischer it would definitely be better to have the embeddings prepared beforehand. We implemented the possibility to store data without the embeddings, so it is compatible with the other engines. However, the HNSW graph will be rebuilt when you store new embeddings, so no need to worry. Of course, you'll be building the graph twice, so that's overhead.

Thanks!


No docs for ComPtr

https://docs.rs/wio/0.2.0/wio/com/struct.ComPtr.html doesn't exist, perhaps the crate needs some doc(cfg) stuff?

That is the docs for the linux version. I just need to specify the appropriate docs.rs stuff so it defaults to Windows.

Yeah, that's what I mean, you can use doc(cfg) to make that work IIRC

It's also worthwhile specifying it as the default in Cargo.toml:
[package.metadata.docs.rs]
default-target = "x86_64-pc-windows-msvc"


Client for addressing databases required

In general, information that is required for connecting to the database, which is holding the application data, shall be documented in the CONFIGfile and be made available for configuration on the REST interface.
In a first step, connecting to ElasticSearch shall be made available.
It turned out that several specific attributes are required for connecting to ElasticSearch.
A specific ElasticSearchClient class shall be defined as a client to the HttpClient class.

Artifact to be temporarily stored:
                                  - description: 'elastic search client'
                                    type: object
                                    required:
                                      - local-id
                                      - layer-protocol-name
                                      - elastic-search-client-interface-1-0:elastic-search-client-interface-pac
                                    properties:
                                      local-id:
                                        type: string
                                      layer-protocol-name:
                                        type: string
                                        enum:
                                          - 'operation-server-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_OPERATION_LAYER'
                                          - 'http-server-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_HTTP_LAYER'
                                          - 'tcp-server-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_TCP_LAYER'
                                          - 'elastic-search-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_ELASTIC_SEARCH_LAYER'
                                          - 'operation-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_OPERATION_LAYER'
                                          - 'http-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_HTTP_LAYER'
                                          - 'tcp-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_TCP_LAYER'
                                      elastic-search-client-interface-1-0:elastic-search-client-interface-pac:
                                        type: object
                                        required:
                                          - elastic-search-client-interface-configuration
                                          - elastic-search-client-interface-status
                                        properties:
                                          elastic-search-client-interface-configuration:
                                            type: object
                                            required:
                                              - elastic-search-user
                                              - elastic-search-password
                                              - index-alias
                                            properties:
                                              elastic-search-user:
                                                type: string
                                              elastic-search-password:
                                                type: string
                                              index-alias:
                                                type: string
                                              service_records_policy:
                                                type: string
# hier die Parameter einsetzen, die in ElasticRepository.js hard codiert sind

                                              detailed-logging-is-on:
                                                type: boolean
                                          elastic-search-client-interface-status:
                                            type: object
                                            required:
                                              - operational-state
                                              - life-cycle-state
                                            properties:
                                              elastic-searchal-state:
                                                type: string
                                                enum:
                                                  - 'elastic-search-client-interface-1-0:OPERATIONAL_STATE_TYPE_AVAILABLE'
                                                  - 'elastic-search-client-interface-1-0:OPERATIONAL_STATE_TYPE_UNAVAILABLE'
                                                  - 'elastic-search-client-interface-1-0:OPERATIONAL_STATE_TYPE_NOT_YET_DEFINED'
                                              life-cycle-state:
                                                type: string
                                                enum:
                                                  - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_EXPERIMENTAL'
                                                  - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_OPERATIONAL'
                                                  - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_DEPRECATED'
                                                  - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_OBSOLETE'
                                                  - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_UNKNOWN'
                                                  - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_NOT_YET_DEFINED'

Proposed ElasticSearchClient:
- description: 'elastic search client'
  type: object
  required:
    - local-id
    - layer-protocol-name
    - elastic-search-client-interface-1-0:elastic-search-client-interface-pac
  properties:
    local-id:
      type: string
    layer-protocol-name:
      type: string
      enum:
        - 'operation-server-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_OPERATION_LAYER'
        - 'http-server-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_HTTP_LAYER'
        - 'tcp-server-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_TCP_LAYER'
        - 'operation-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_OPERATION_LAYER'
        - 'elastic-search-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_ELASTIC_SEARCH_LAYER'
        - 'http-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_HTTP_LAYER'
        - 'tcp-client-interface-1-0:LAYER_PROTOCOL_NAME_TYPE_TCP_LAYER'
    elastic-search-client-interface-1-0:elastic-search-client-interface-pac:
      type: object
      required:
        - elastic-search-client-interface-configuration
        - elastic-search-client-interface-status
      properties:
        elastic-search-client-interface-configuration:
          type: object
          required:
            - auth
            - index-alias
            - service-records-policy
          properties:
            auth:
              type: object
              minProperties: 1
              additionalProperties: false
              properties:
                api-key:
                  type: string
                  description: 'base64EncodedKey'
            index-alias:
              type: string
            service-records-policy:
              type: string
        elastic-search-client-interface-status:
          type: object
          required:
            - operational-state
            - life-cycle-state
          properties:
            elastic-searchal-state:
              type: string
              enum:
                - 'elastic-search-client-interface-1-0:OPERATIONAL_STATE_TYPE_AVAILABLE'
                - 'elastic-search-client-interface-1-0:OPERATIONAL_STATE_TYPE_UNAVAILABLE'
                - 'elastic-search-client-interface-1-0:OPERATIONAL_STATE_TYPE_NOT_YET_DEFINED'
            life-cycle-state:
              type: string
              enum:
                - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_EXPERIMENTAL'
                - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_OPERATIONAL'
                - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_DEPRECATED'
                - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_OBSOLETE'
                - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_UNKNOWN'
                - 'elastic-search-client-interface-1-0:LIFE_CYCLE_STATE_TYPE_NOT_YET_DEFINED'

few nits:

elasticsearch is one word (not elastic-search)
elastic-searchal-state is typo and it should be operational-state

I am not sure if CONFIGfile should contain state like elastic-search-client-interface-status
In case everything is configurable via REST during runtime, what are the expectations to happen when:

index-alias is changed
service-record-policy is changed

The attached proposal for the ElasticSearchClient consolidates the following changes:

Policy::phases::hot::min_age, Policy::phases::hot::actions::rollover::max_age and Policy::delete::min_age have been added to the proposed ElasticSearchClient.
service-record-policy has been made fully available for configuration in the proposed ElasticSearchClient.
elastic-searchal-state has been replaced by operational-state
elastic-search has been replaced by elasticsearch

Further clarification:

Would like the OaM section of the REST API to represent operational and life-cycle state of the connection to the ElasticSearch, too. Would like the REST API and the content of the CONFIGfile to stay in synch.
If index-alias is changed, it is expected that the application is reading/writing data stored under the new index-alias in the database (no matter, whether index-alias has been used before, or not).
If service-record-policy is changed, it is expected that:

In case of existing name, attributes of existing service-record-policy shall be changed and applied.
In case of new name, new service-record-policy shall be created and applied.

_AVAILABLE: data can be read and write to the database
_NOT_YET_DEFINED: only to be represented, if operational-state attribute is not supported by the application implementation
In regards of periodicity of checking the operational state, I would support your preference.


NO-YT: Add storybook

Description
We want to add storybook to our tool belt to supercharge our Design to Engineering workflow. This tool will allow us to easily add/change/QA new components. To be able iterate as fast as possible we need to ideally spend as little time as possible on base level components or minimal changes due to not having the right level of flexibility to begin with. Following the atomic design system we will slowlt transition all current base components into 3 layers - atoms, molecules and organisms the fill in any missing components as needed.
Out of scope and potential follow-up
Screenshots
Checklist (for submission)

[ ] Add storybook libraries
[ ] Update Android binary
[ ] Update App startup to use new config variable

Checklist (for reviewers)

[ ] Checked app can be run without storybook as usual
[ ] Checked app can be run with storybook + web UI

closing this PR, will replace with a newer one


No module named yolox.exp

I'm attempting to convert my yolox pytorch model to a tensorRT in python
When i apply the code given:
python tools/trt.py -f <YOLOX_EXP_FILE> -c <YOLOX_CHECKPOINT>
I get the following error:
from yolox.exp import get_exp
ModuleNotFoundError: No module named yolox.exp
Has anyone ever experienced this?  is there a work around or any ideas on how to resolve.

Did you install YOLOX as README suggested?

Yes, I figured out the issue.
I recently reformatted my hard drive.
A few of the YOLOX dependencies call on python files that had long path's.  I had to enable long paths in my windows registry.


Test Istio release "Istio 1.9.7"

Istio recently (2021-07-22 19:24:37 +0000 UTC) released "Istio 1.9.7". Let's test it :rocket:.

closing this will be EOL this month


Fix ingress in all helm charts

Helm charts which have ingress deployment, refuse to deploy on Kubernetes <1.19, because of a little typo bug introduced with  #354
Fix bug by removing the additional "-" character in the else-statement of the ingress service backend:
{{- if semverCompare ">=1.19" $kubeVersion }}
pathType: ImplementationSpecific
backend:
service:
name: {{ $fullName }}
port:
number: {{ $svcPort }}
{{- else -}}   =====> {{- else }}
backend:
serviceName: {{ $fullName }}
servicePort: {{ $svcPort }}
{{- end }}

Following charts are affected:

RabbitMQ
Commento
Elasticsearch
Ghost
Gitea
Graylog
Nextcloud
Remark42
Wordpress