Add ability to copy formatted code to clipboard

I'd like to request adding the ability to copy selected code to the clipboard with syntax highlighting. This is useful for pasting formatted code into another application (e.g., Word document, e-mail).
Regular Visual Studio does this by default (it puts both text and RTF formats on the clipboard).
RTF works well for me, but maybe HTML would be okay too, as long as it is 'pastable' (dependency-free).

:+1:

We definitely need this.

Thumbs up!.. Would be awesome if the code can be copy pasted along with the syntax highlighting into word or ppt!.. Such a good IDE, especially with typescript + angular 2 combo , this wud be like gold for me!...Please provide syntax highlighting..

Would love this feature! We regularly share code, and it would be much easier to read/understand if there's color coding and indentation.

👍

You should be able to write an extension to do this, you would need to include a syntax highlighter in the extension though. I'm not sure we would want to integrate something like this into the core editor (concerned about feature bloat).

I would really like this feature.  I was quite surprised that this wasn't already supported when I tried it (I'm a Visual Studio user!).  If an extension had to do its own syntax highlighting I think that wouldn't be a great user experience, as I find how VSCode highlights absolutely fine and wouldn't want to have to manage a separate highlighter configuration.
Are you concerned about feature bloat from an end-user perspective or from the codebase itself?  I wouldn't comment on the latter, but from an end-user perspective, I enjoy the fact that it's seamless on VS.  i.e. VS copied the colour information and if I tried to paste in to an app that didn't support colour (e.g. notepad) then it just disappeared and the app behaved as if I was pasting plain text.  In apps like PowerPoint (where I regularly copy and paste code snippets!) I have the source formatting and plain text options available.

+1

:+1:

:+1:

👍

Is there anything that is blocking this, or is it not a desired feature ?

Dear GitHub Gods,
Please add this feature.
Sincerely,
Ryan

Would love to see this happen.  Great for communicating about code.

there is a plugin for atom: https://atom.io/packages/copy-as-rtf
and Code highlighting for Keynote presentations
maybe someone can write a plugin to wrap these

HI, I just publish one plugin for this:
https://marketplace.visualstudio.com/items?itemName=atian25.copy-syntax

Hey, thanks, Atian! We'll check it out!

Hello @atian25,
Thanks for the extension but it copies the text and put "literal" RTF signatures/tags (whatever people call them) around it.  So when I paste the code, I get something like this:
{\rtf1\ansi\uc0\deff0{\fonttbl{\f0\fmodern\fprq1\fcharset0 Monaco;}}{\colortbl;\red136\green136\blue136;\red186\green33\blue33;\red0\green68\blue221;\red102\green102\blue102;\red64\green128\blue128;\red160\green160\blue0;\red25\green23\blue124;\red0\green128\blue0;\red187\green102\blue136;\red187\green102\blue34;\red136\green0\blue0;\red170\green34\blue255;\red153\green153\blue153;\red0\green160\blue0;\red160\green0\blue0;\red255\green0\blue0;\red128\green0\blue128;\red176\green0\blue64;\red0\green0\blue255;\red187\green187\blue187;\red188\green122\blue0;\red0\green0\blue128;\red125\green144\blue41;\red210\green65\blue58;}\f0 \fs50{\chbrdr\chcfpat16 @}unittest.skipIf(mock is None, {\cf2 "`mock` module not installed!"})\par

... when I am expecting a color coded text similar to below:
@unittest.skipIf(mock is None, ...)

If it helps, I'm pasting it into an blank Outlook email window.  For those who want an interim solution, look at Notepad++'s NppExport plugin (Copy HTML to clipboard)

hey, @johncruise the extension is use pygments behind, and  it offer HtmlFormatter
so, for now, you can:

set copy-syntax.defaults.format to html
maybe copy-syntax.formatters.html.full to true
then copy and you will get html output

but, I don't know whether copy-paste module can copy it to clipboard with correct format (see https://github.com/atian25/vscode-copy-syntax/issues/1)
I don't have window and outlook now, could you please have a try and feed back?
btw, you can report an issue/suggest at https://github.com/atian25/vscode-copy-syntax/issues

@Tyriar does vscode have any api for extension to set clipboard?

@atian25 there is no copy and paste in the API, I think the advice is to pull in a node module which does it for you.

@Tyriar This capability should be part of native VS Code experience, not as a plugin.
If anyone doesn't like the colors, he can simply select the pasted code and apply a single color to them.
How many  👍 do you need before getting convinced to implement it as part of VS code?
; )

+1  Definitely need this !!

We hear your voice and I'm working on it :)

Awesome! awesome! awesome! requesting you to make it something like the
"Copy as HTML" in one of the simple editors like Notepad++ , where,
whatever be the Theme, the copied one will also copied like the
theme!..cant wait to see the same working on VS code. I see a "Copy syntax
as" in the plugins for VS Code, but seems nothing close to the one I saw in
Notepad++ or Webstorm.
On Thu, Feb 9, 2017 at 6:38 AM, Peng Lyu<EMAIL_ADDRESS>wrote:

We hear your voice and I'm working on it :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#issuecomment-278515230,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEyqyLgt2UPK3FFrWYhlL8ovkIj6ylqUks5ramclgaJpZM4HkOob
.

@harikrishkk I enjoyed the moment that what you describe is what I did. We converted the content with theme into HTML with inline CSS then it can be as compatible as possible.

Can Insiders build try the early stages of this with some flag or so?
Cheers,

You should be able to see this Copy with Syntax Highlighting feature from Friday's Insider update. Please let me know if you guys find any problem with it :)
I would close this issue once tomorrow's Insider is out, thank you all for your patience and feedback.

Getting the error  Command Failed: Python -v

Thanks for the update on this and for your hard work on this feature.
Certainly looks like the fundamentals are working, font and colour information is coming across.
I tried with some Go code, pasting in to PowerPoint 2016, but it didn't paste the background correctly, as the text box it created wasn't configured with the right dimensions.  TBH I wasn't expecting the background to come across at all.

I also compared with VS2015 on some C# code.  VS2015 didn't attempt to take across a background and pasted white text from VS2015 as black text in to PowerPoint, taking in to account the background colour change from dark to light.  Would it be possible to mimic VS2015's behaviour with this feature as this works perfectly for what I want to achieve.

I love it as it now!
I tried it in Gmail opened in Chrome, and in Word, both on Mac. The result is super impressive!
I love that it picked the background. I guess for copying to Word if you want a white background temporarily switch to a theme that matches what you want.
It picked everything, except for lint error underlines, which is exactly what I'd expect and want it to do.
Thanks heaps!

Looks great! Many thanks for adding this feature!
I was surprised when first testing that it includes the background (dark theme in my case).  Sometimes I don't want this, such as pasting in a report (e.g., Word document), but it is easy enough to switch themes when I want the light background.  So, the implementation is perfect for me.

Can someone tell me the steps to try this out? I updated the visual studio
code to latest version, set the editor.copyFormat to true in settings, but
trying to copy paste still throws "command.copySyntax" not found error.
On Fri, Feb 17, 2017 at 8:07 PM, thomas-taylor<EMAIL_ADDRESS>wrote:

Looks great! Many thanks for adding this feature!
I was surprised when first testing that it includes the background (dark
theme in my case). Sometimes I don't want this, such as pasting in a report
(e.g., Word document), but it is easy enough to switch themes when I want
the light background. So, the implementation is perfect for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#issuecomment-280666402,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEyqyHqLW7UymzBA1e5D3wPDUfEZyZETks5rdbC6gaJpZM4HkOob
.

This works very nice.  It basically seems to mirror the VS2013 copy/paste
feature where it copies the background and does a full width paste of the
background.  If memory serves, VS2012 would copy background, but only under
the text, so when pasting you would have jagged ends of the line.  VS2015
by default copies with a nice theme (not sure if you can change it), but
must not use the current theme.  I used a dark background, but when
copying/pasting it is a white background.
Many comments are coming that we could easily change the theme if we want
to have a different look when pasting.  Would it be possible to have a
setting like editor.copyTheme in settings.json that would do that for us?
Thanks again for the great feature...
On Fri, Feb 17, 2017 at 8:46 AM, Harikrishnan KK<EMAIL_ADDRESS>wrote:

Can someone tell me the steps to try this out? I updated the visual studio
code to latest version, set the editor.copyFormat to true in settings, but
trying to copy paste still throws "command.copySyntax" not found error.
On Fri, Feb 17, 2017 at 8:07 PM, thomas-taylor<EMAIL_ADDRESS>wrote:

Looks great! Many thanks for adding this feature!
I was surprised when first testing that it includes the background (dark
theme in my case). Sometimes I don't want this, such as pasting in a
report
(e.g., Word document), but it is easy enough to switch themes when I want
the light background. So, the implementation is perfect for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/Microsoft/vscode/issues/3518#issuecomment-280666402
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AEyqyHqLW7UymzBA1e5D3wPDUfEZyZETks5rdbC6gaJpZM4HkOob>

.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#issuecomment-280668654,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUNn4YVKoWcAI63mtM799igm_9MQ1GKks5rdbKsgaJpZM4HkOob
.

@AroraMunish does that happen when you just press ctrl/cmd+c? It looks like an extension problem to me.

@andybrodie I'll give Powerpoint a try on Windows, the output HTML is just simple <div>s so I'll see if I make anything wrong with the layout.
Speaking of VS2015, are you saying that you are using Dark theme in VS2015 and when you copy it to Powerpoint, the pasted content has white background and black font color? Does other colorization still work? A screenshot can help me understand  :)

@harikrishkk Just simply Ctrl/Cmd+C without any configuration.
@thomas-taylor @schallm or anyone uses Dark theme, I'm a Dark theme guy as well. At the very beginning, I didn't put the background color from the theme into the output content, but later on I found for most cases the output is ugly or unreadable. I suppose you can imagine that as for Dark theme, the font color are always light. Light font above white background is terrible most of the time. The dark theme you are using makes sure that the background color and foreground color has good contrast so I choose to ship bkg color to the clipboard.
I can see reasons that why customizing the pasted content style is useful as sometimes you can't easily modify the styles in the target application. Look forward to more users feedback on this once we ship it to stable.

Here is a screenshot of VS2015 (dark theme) with code selected, copied to
clipboard, pasted to Outlook...  I don't know if they use a different theme
when copying, but it works great.  I get syntax highlighted code that looks
great, but without the dark background...
[image: Inline image 1]
On Fri, Feb 17, 2017 at 12:40 PM, Peng Lyu<EMAIL_ADDRESS>wrote:

Closed #3518 https://github.com/Microsoft/vscode/issues/3518.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#event-967388535, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAUNnwQOKJnPJEhKDyBOuQt1w9PtjGoDks5rdemtgaJpZM4HkOob
.

Here is a screenshot of VS2015 (dark theme) with code selected, copied to clipboard, pasted to Outlook...  I don't know if they use a different theme when copying, but it works great.  I get syntax highlighted code that looks great, but without the dark background...

@harikrishkk - You say you have latest, but just to be sure you know, today this is only in the insider build: https://code.visualstudio.com/insiders
@rebornix - I think the way it matches the theme exactly (including background) is perfect.  Regular VS 2015 appears to switch the entire theme (for example text that is white in VS 2015 dark theme is pasted as black text in Word/Outlook).  This works fine too (for my needs), but I like your implementation in VS Code better.  That said, I also like the suggestion from @schallm to have a setting to choose the theme that you want to use for this cut/paste feature.

Superb! I just installed the one with the insiders link! .what i previously
downloaded was the normal one from the vs code site... And i tried copy
pasting a sample to word doc! sweet!... A simple crtl+ c, and paste it!....
@thomas taylor, thanks a lot!...
[image: Inline image 1]
On Sat, Feb 18, 2017 at 1:24 AM, Thomas Taylor<EMAIL_ADDRESS>wrote:

@harikrishkk https://github.com/harikrishkk - You say you have latest,
but just to be sure you know, today this is only in the insider build:
https://code.visualstudio.com/insiders
@rebornix https://github.com/rebornix - I think the way it matches the
theme exactly (including background) is perfect. Regular VS 2015 appears to
switch the entire theme (for example text that is white in VS 2015 dark
theme is pasted as black text in Word/Outlook). This works fine too (for my
needs), but I like your implementation in VS Code better. That said, I also
like the suggestion from @schallm https://github.com/schallm to have a
setting to choose the theme that you want to use for this cut/paste feature.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#issuecomment-280750131,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEyqyJZ3Hcy35ak_0ysS4HCMfSG-YqPPks5rdfr6gaJpZM4HkOob
.

When I try to copy using right click | Copy Syntax, I get the error "Command failed: python -V".  Do I need to pre-install anything?

@munish, https://code.visualstudio.com/insiders try downloading the
installer from here and see if its working..i had the same issue when i was
just trying to take the latest of the VS code from the usual site. After
installing this build ( a green one ), it did work for me
On Sun, Feb 19, 2017 at 2:41 PM, Munish Arora<EMAIL_ADDRESS>wrote:

When I try to copy using right click | Copy Syntax, I get the error
"Command failed: python -V". Do I need to pre-install anything?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#issuecomment-280906121,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEyqyF0YSxaBQIl30R7qz1lEK1p7yKzoks5reAdYgaJpZM4HkOob
.

Thanks Harikrishnan .. it worked..

Not working with Powerpoint. I have to copy it in Word first then I have copy from word and paste in Powerpoint

@MateenKadwaikar is there anyway in Powerpoint that can trigger a force copy with formatting? In Outlook on macOS, I have to do that always as the default paste is just pasting plain text.

@MateenKadwaikar , +1 to @rebornix. PowerPoint has a default text based paste. From Edit menu though you can choose "Paste Special...", which will give HTML and RTF options. I have found the VS Code HTML copy to work with both.

Is anyone facing issues while copy pasting? I get the code but indentations
is all wrong and has to put tab or space every single time. A couple of
updates before, it wasnt the case i guess.
On Wed, Feb 22, 2017 at 3:11 AM, Meligy, GuruStop.NET <
<EMAIL_ADDRESS>wrote:

@MateenKadwaikar https://github.com/MateenKadwaikar , +1 to @rebornix
https://github.com/rebornix. PowerPoint has a default text based paste.
From Edit menu though you can choose "Paste Special...", which will give
HTML and RTF options. I have found the VS Code HTML copy to work with both.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/3518#issuecomment-281490195,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEyqyGFDg0LecvhvR61GG82TRpPG2JVhks5re1oWgaJpZM4HkOob
.

+1 It doesn't work with OneNote 2016 either

@dalyIsaac do you mind sharing what platform and version you are using and a gif can help me understand what's going on, thanks!

Guess:

maybe vscode is copy as HTML format
keynote only support RTF format
word/mail support both

@rebornix Is this feature configurable? I couldn't find a setting for disabling this feature.. Unlike other people in this thread I personally prefer copying the plain text and nothing else. I also think copying plain text should be the DEFAULT behavior, like all other similar, non-IDE text editors (e.g. Atom, Sublime Text, Notepad++).
I appreciate all the effort went into enabling this feature. I hope you guys can add a boolean option in Settings file to enable/disable it.

@tedyun If you want to copy plain text: select text the Edit --> Copy
If you want to copy with syntax: select text then open command pallate and select "Copy with Syntax Highlighting"

@lukeaus It doesn't work that way in my machine. Both (Edit -> Copy) and (Ctrl+C) copy the text WITH syntax highlighting. Version 1.12.2

@rebornix I'd really appreciate if you can take a second look at this issue.

@tedyun we put both plain text and html in clipboard and it's the target application who decides which format to paste.

@rebornix when copying codes into OneNote2016, indentation(using spaces) will get lost.

It seems that OneNote will ignore 'white-space: pre;'. Get   solution back, maybe?

I'd like to using sublime text 3 format paste!

Ctrl+Shift+V

How to realize it in VScode ?

@rebornix @Meligy on Outlook for Mac (v15.35) I can get formatted text into an email if I spam the crap out of paste cmd (below)

I can detect visually a FOUC-like render of the formatted paste under normal conditions too (one can see in the screen cast too). Surely there must be a way to disable the sanitizing that Outlook is doing in Outlook prefs, rt? (If anyone knows, plz share)
Definitely not a problem with VSCode... i just really want to be able to paste syntax-highlighted snippets in company email 😞

@eckdanny You don't need to spam the paste key combo. Just paste once, and then notice the little icon that appears after your paste. Click the icon and change it to "keep source formatting."

@Aptend you can paste into Word, copy, and paste into OneNote. If you remove the dark text background color the text colors are too light to see, but you can change VS Code to a light theme before copying ;)
I also found a few OneNote requests in UserVoice that everybody should upvote:

https://onenote.uservoice.com/forums/327186-onenote-for-windows-windows-phone/filters/my_feedback
https://onenote.uservoice.com/forums/327186-onenote-for-windows-windows-phone/suggestions/6189896-respect-whitespace-tags-in-pasted-html-text-e

It doesn't work with OneNote 2016!


add option for table privacy in the import api

Right now there is not an option to set the privacy of a table using the Import API. It'd be great to have it!
I want to upload a dataset to CartoDB and programmatically choose the privacy of the table.

Solved in PR #5022


Update redirect-files

Description
To be merged after this PR is merged: https://github.com/dcos/dcos-docs/pull/926/files
Urgency

[ ] Blocker
[X] High
[ ] Medium

Requirements

Test all commands and procedures.
Build content locally and test for formatting/links.
Add redirects to dcos-website/redirect-files.
Change all affected versions (e.g. 1.7, 1.8, and 1.9).
See the contribution guidelines.

retest this please

@sascala please add work in progress label until this is ready for merge.


System property tests fail on NI-XNET 15.5

Our integration tests were tested out on 15.5 an ran into this problem.

Python version: Python 3.4
NI-XNET version: NI-XNET 15.5

___________________________ test_device_properties ____________________________

nixnet_in_interface = 'CAN1'

    @pytest.mark.integration
    def test_device_properties(nixnet_in_interface):
        """Verify Device properties.

        Ideally we'd match these against a known piece of hardware to ensure the
        correct values are being returned.  That makes it hard though for someone
        to run these tests with any piece of hardware for most properties.  For
        now, we'll just verify the calls don't call catastrophically and someone
        can always run py.test with ``-s``_.  For ``int_refs_all``, we can at least
        make sure that one device reports ``nixnet_in_interface``_.
        """
        with system.System() as sys:
            devs = list(sys.dev_refs)
            assert 0 < len(devs), "Pre-requisite failed"
            for dev in devs:
                in_intfs = [intf for intf in dev.intf_refs_all if intf == nixnet_in_interface]
                if len(in_intfs) == 1:
                    break
            else:
>               raise RuntimeError("Pre-requisite failed: can't find device for interface")
E               RuntimeError: Pre-requisite failed: can't find device for interface

tests\test_system.py:121: RuntimeError
_____________________________ test_intf_container _____________________________

nixnet_in_interface = 'CAN1'

    @pytest.mark.integration
    def test_intf_container(nixnet_in_interface):
        with system.System() as sys:
            intfs = list(sys.intf_refs_all)
            in_intfs = [intf for intf in intfs if intf == nixnet_in_interface]
>           assert len(in_intfs) == 1
E           assert 0 == 1
E            +  where 0 = len([])

tests\test_system.py:140: AssertionError
_______________________________ test_intf_blink _______________________________

nixnet_in_interface = 'CAN1'

    @pytest.mark.integration
    def test_intf_blink(nixnet_in_interface):
        """Verify LEDs can be blinked.

        Since we don't have a camera watching the LEDs, we can at least test if we
        are having an impact by checking

        - `ENABLE` works anytime except a session is in use
        - `DISABLE` always works

        Sleeps are in place in case this in case a visual confirmation is possible
        by the developer.
        """
        with system.System() as sys:
            intfs = list(sys.intf_refs_all)
            in_intfs = [intf for intf in intfs if intf == nixnet_in_interface]
>           assert len(in_intfs) == 1, "Pre-requisite failed"
E           AssertionError: Pre-requisite failed
E           assert 0 == 1
E            +  where 0 = len([])

tests\test_system.py:175: AssertionError
____________________________ test_intf_properties _____________________________

nixnet_in_interface = 'CAN1'

    @pytest.mark.integration
    def test_intf_properties(nixnet_in_interface):
        """Verify Interface properties.

        Ideally we'd match these against a known piece of hardware to ensure the
        correct values are being returned.  That makes it hard though for someone
        to run these tests with any piece of hardware.  For now, we'll just verify
        the calls don't call catastrophically and someone can always run py.test
        with ``-s``_.
        """
        with system.System() as sys:
            intfs = list(sys.intf_refs_all)
            in_intfs = [intf for intf in intfs if intf == nixnet_in_interface]
>           assert len(in_intfs) == 1, "Pre-requisite failed"
E           AssertionError: Pre-requisite failed
E           assert 0 == 1
E            +  where 0 = len([])

tests\test_system.py:207: AssertionError

My theory is that the intf_refs_all versions of the properties is fairly new and doesn't work on the older versions.  But if so, why do the calls return no interfaces rather than throwing an error?

Alternatively, this was some kind of hardware failure.
tox runs the same tests on multiple versions of python.  The first run only had these failures.  The other runs failed as if there wasn't any hardware in the system.  These tests that failed were at the tail end of the run, so that might have been when the hardware first went on the fritz.
nixnet/_frames.py::nixnet._frames._calculate_payload_size PASSED
nixnet/_frames.py::nixnet._frames._calculate_payload_unit_size PASSED
nixnet/_frames.py::nixnet._frames._get_frame_payload_length PASSED
nixnet/_frames.py::nixnet._frames._split_payload_length PASSED
nixnet/_utils.py::nixnet._utils.flatten_items PASSED
nixnet/types.py::nixnet.types.CanFrame.__repr__ PASSED
nixnet/types.py::nixnet.types.CanFrame.from_raw PASSED
nixnet/types.py::nixnet.types.CanFrame.to_raw PASSED
nixnet/types.py::nixnet.types.CanIdentifier.__int__ PASSED
nixnet/types.py::nixnet.types.CanIdentifier.__repr__ PASSED
nixnet/types.py::nixnet.types.CanIdentifier.from_raw PASSED
nixnet/types.py::nixnet.types.RawFrame.__repr__ PASSED
tests/test_errors.py::test_success PASSED
tests/test_errors.py::test_known_error PASSED
tests/test_errors.py::test_unknown_error PASSED
tests/test_errors.py::test_known_warning PASSED
tests/test_errors.py::test_unknown_warning PASSED
tests/test_errors.py::test_driver_call PASSED
tests/test_examples.py::test_can_frame_queued_empty_session[input_values0] PASSED
tests/test_examples.py::test_can_frame_queued_empty_session[input_values1] PASSED
tests/test_examples.py::test_can_frame_queued_empty_session[input_values2] PASSED
tests/test_examples.py::test_can_frame_queued_empty_session[input_values3] PASSED
tests/test_examples.py::test_can_frame_queued_empty_session[input_values4] PASSED
tests/test_examples.py::test_can_frame_stream_empty_session[input_values0] PASSED
tests/test_examples.py::test_can_frame_stream_empty_session[input_values1] PASSED
tests/test_examples.py::test_can_frame_stream_empty_session[input_values2] PASSED
tests/test_examples.py::test_can_frame_stream_empty_session[input_values3] PASSED
tests/test_examples.py::test_can_frame_stream_empty_session[input_values4] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values0] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values1] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values2] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values3] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values4] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values5] PASSED
tests/test_examples.py::test_can_signal_single_point_empty_session[input_values6] PASSED
tests/test_frames.py::test_iterate_frames_with_empty_payload PASSED
tests/test_frames.py::test_iterate_frames_with_base_payload PASSED
tests/test_frames.py::test_iterate_frames_with_partial_base_payload PASSED
tests/test_frames.py::test_iterate_frames_with_multiple_frames PASSED
tests/test_frames.py::test_iterate_frames_corrupted_frame PASSED
tests/test_frames.py::test_can_identifier_equality PASSED
tests/test_frames.py::test_can_identifier_overflow PASSED
tests/test_frames.py::test_can_identifier_extended_overflow PASSED
tests/test_frames.py::test_raw_frame_equality PASSED
tests/test_frames.py::test_raw_frame_conversion PASSED
tests/test_frames.py::test_can_frame_equality PASSED
tests/test_frames.py::test_serialize_frame_with_empty_payload PASSED
tests/test_frames.py::test_serialize_frame_with_base_payload PASSED
tests/test_frames.py::test_serialize_frame_with_payload_unit PASSED
tests/test_frames.py::test_serialize_frame_with_excessive_payload PASSED
tests/test_frames.py::test_stream_loopback PASSED
tests/test_frames.py::test_queued_loopback PASSED
tests/test_frames.py::test_singlepoint_loopback PASSED
tests/test_frames.py::test_session_frames_container PASSED
tests/test_frames.py::test_session_frames_properties PASSED
tests/test_frames.py::test_session_frame_container PASSED
tests/test_lib.py::test_unsupported_platform PASSED
tests/test_lib.py::test_function_not_supported PASSED
tests/test_session.py::test_flatten_items_invalid PASSED
tests/test_session.py::test_session_container PASSED
tests/test_session.py::test_session_properties PASSED
tests/test_session.py::test_session_properties_transition PASSED
tests/test_session.py::test_parse_can_comm_bitfield PASSED
tests/test_session.py::test_start_explicit PASSED
tests/test_session.py::test_flush_baseline PASSED
tests/test_session.py::test_flush_output_queue PASSED
tests/test_session.py::test_wait_for_intf_communicating PASSED
tests/test_session.py::test_wait_for_transmit_complete PASSED
tests/test_session.py::test_wait_for_intf_remote_wakeup PASSED
tests/test_session.py::test_connect_terminals_failures PASSED
tests/test_session.py::test_disconnect_terminals_failures PASSED
tests/test_session_intf.py::test_intf_container PASSED
tests/test_session_intf.py::test_intf_properties_settable_only_when_stopped PASSED
tests/test_session_intf.py::test_stream_session_requires_baud_rate PASSED
tests/test_session_intf.py::test_sleep_transition PASSED
tests/test_signals.py::test_singlepoint_loopback PASSED
tests/test_signals.py::test_signals_container PASSED
tests/test_system.py::test_system_container PASSED
tests/test_system.py::test_system_properties PASSED
tests/test_system.py::test_system_intf_refs_superset PASSED
tests/test_system.py::test_system_intf_refs_all_superset PASSED
tests/test_system.py::test_device_container PASSED
tests/test_system.py::test_device_properties FAILED
tests/test_system.py::test_intf_container FAILED
tests/test_system.py::test_intf_blink FAILED
tests/test_system.py::test_intf_properties FAILED

It appears that "tests/test_system.py::test_device_properties FAILED" causes the hardware to have problems. I am unable to self test the hardware successfully after tox has completed.

What steps did you take to root cause the problem to that test?

I bid a compare between the Ethernet cDAQ and USB logs. The Ethernet log does have some additional failures we can likely attribute to connection troubles but both logs start failing at the tests/test_system.py::test_device_properties test and continue to fail all tests that use hardware references from that point forward.
Also, the hardware was not in a usable state upon the completion of the test so the problem likely started at that test or soon after.

So Ajay just ran this and it started failing at "test_system_intf_refs_superset".
One thing to be careful of is that the test that first fails might not be the test that put the machine into a bad state.

Ajay has done 2 runs of tox without test_system.py without problems.

Fixed by #163


Camera2api had trouble taking photos continuously

I have problems using camera2api from this model. I just removed the image viewer function.
I tested on a number of devices such as Nokia 6, Nokia 7.2, Nokia 8.1, Samsung j7 prime, and most likely caused the error.
Another small problem is that the preview image is stretched and the phone will get hot so fast
This is an error video : https://drive.google.com/file/d/1ZXLcedqqx_SKKxNrJfWjC4-P8cGPHtFb/view?usp=sharing

I just dealt with that problem. I'm not very experienced in android and maybe the problem is somewhere even deeper, but I see this:
When you get an "image" in function takePhoto(), there is code:
...
       session.capture(captureRequest.build(), object : CameraCaptureSession.CaptureCallback() {`
...
               // Loop in the coroutine's context until an image with matching timestamp
                // We need to launch the coroutine context again because the callback is done in
                //  the handler provided to the `capture` method, not in our coroutine context
                @Suppress("BlockingMethodInNonBlockingContext")
                lifecycleScope.launch(cont.context) {
                    while (true) {
...
                        // Build the result and resume progress
                        cont.resume(CombinedCaptureResult(
                                image, result, exifOrientation, imageReader.imageFormat))

                        // There is no need to break out of the loop, this coroutine will suspend
                    }
...

It is even noted here that the loop is written correctly, but it seems that it is because of this loop that the thread remains hanging and after accumulating 64 (you can even count flashes on the video) the threads in Dispatchers.IO stop running. Since it is 64 threads that are restricted in Dispatchers.IO by default. And if you add the key to exit the loop, everything starts to work steadily:
...
                var key = true
                @Suppress("BlockingMethodInNonBlockingContext")
                lifecycleScope.launch(cont.context) {
                    while (key ) {
...
                        // Build the result and resume progress
                        key = false
                        cont.resume(CombinedCaptureResult(
                                image, result, exifOrientation, imageReader.imageFormat))

                        // There is no need to break out of the loop, this coroutine will suspend
                    }
...

I don't know if it's a realization problem or maybe it's coroutine problem, but it helped me.
I'm sorry if my English isn't very clear...)

The image being stretched was fixed by #256. For the other issues that arise after you modify the sample, we would need a little more information to help you. I would recommend creating a question on StackOverflow, feel free to post the link here.


Updates to QA - Test Summary, Linearity Summary Prototype (Week: 5/23/2022)

9/7/2022: Completed all updates as requested


Vehicle.commands.next returns last waypoint not next waypoint

The reported vehicle.commands.next value is numerically the waypoint that was just left rather than the waypoint that you're heading towards. This is incorrect
You can see the behaviour by observing mission_basic.py example (note we're reporting next waypoint as 0 (incorrect), then the system reports we've reached waypoint 1 (correctly)
Distance to waypoint (0): None
Distance to waypoint (0): None
Distance to waypoint (0): None
>>> Reached Command #1
Distance to waypoint (1): 7.44343078803
Distance to waypoint (1): 3.82302758257

As an aside, this causes the example to misreport the distance to the next waypoint (and rather report the distance from the last waypoint)

Fixed by #423.


Support HTML5 input event

Closes #30
This PR adds HTML5 input event support to the library.
review plz @eventualbuddha

@eventualbuddha review plz


Switch the AC on and off with a tap in the home app

Is it possible to redesign the plugin so that you can switch the AC on and off with a tap in the home app?

I think you tried to merge into the wrong project. This pull request tries to merge into the old dead DirtyDevWork/homebridge-daikin project instead of the new homebridge-daikin-local.
Please ignore if this was on purpose.


Add full-text search/tsvector functions and types

@k0001 what would need to be done to implement this? I really need this feature for my own work, so I'm prepared to put in some work (which it seems will have to start from postgresql-simple 😨)

Thanks for your interest!
Some things I can think of off the top of my head:

Thanks for your interest!
Some thinks I can think of off the top of my head:

We need data PGTsVector and PGTsQuery to be used as type level indexes for database side stuff, both with PgPrimType and PgTyped instances.

We need to introduce TsVector and TsQuery for correctly representing tsvector and tsquery in Haskell (probably in Tisch.Internal.Kol).

We need ToKol instances for TsVector and TsQuery.

We need to add functions that work on Kol TsVector and Kol TsQuery to Tisch.Internal.Fun.

So will all the work be in Tisch? I understand you're planning to remove the Opaleye dependency, but postgresql-simple doesn't support tsvector/tsquery, it seems.


Fix Istio RBAC samples to use fully qualified service names.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu
Assign the PR to them by writing /assign @frankbu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for the fix!
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu
Assign the PR to them by writing /assign @frankbu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liminw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1d9254144e926c49dc5e4eea115cf2fe0848e227
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1d9254144e926c49dc5e4eea115cf2fe0848e227
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
1d9254144e926c49dc5e4eea115cf2fe0848e227
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0057d88b818ba54384be9472be35732143d5b577
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


点击重试后自动将聊天窗口滚动到最底部 / automatically scroll chat window to the bottom after clicking "Retry"

我在使用你们的产品时，会遇到网络不稳定导致消息发送失败的情况。这时，我会点击“重试”按钮，但是聊天窗口并不会自动滚动到最底部，导致我认为点击没有起到效果。
因此，建议添加一个功能，使得在点击重试按钮后自动将聊天窗口滚动到最底部，展示最新消息。
谢谢！
I've experienced network instability while using your product, which leads to message sending failure. When I click the "Retry" button, the chat window doesn't automatically scroll to the bottom, which makes me think that clicking the button didn't work.
Therefore, I suggest adding a feature that automatically scrolls the chat window to the bottom after clicking "Retry," showing the latest messages.
Thank you!

done.


Quality fixes

I rule and have completed some work on Case Manager that's ready for review!
Cleans up a bunch of the ashes from the controlled brushfire of deployment. No substantial changes other than fixing indents and cleaning up rake quality violations.
I gave us a new metrics directory to start from.
This pull request makes the following changes:

quality fixes

Current coverage is 98.37% (diff: 97.43%)

Merging #617 into master will decrease coverage by 0.01%

@@             master       #617   diff @@
==========================================
  Files            25         25
  Lines           498        493     -5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            490        485     -5
  Misses            8          8
  Partials          0          0

Powered by Codecov. Last update 9543cb6...590fa43


Mm 43612

Summary
Cloud instances with a file limit (Starter and Professional subscriptions) show UI notifying that the limit has been hit and that archived files are unavailable until upgrade. Note that because this requires backend changes, but the ticket for the backend is a separate ticket, I made a separate draft branch based off this one that will run the spinwick tied to the backend changes. It will   be posted here:
Spinwick: https://mattermost-webapp-pr-10903.test.mattermost.cloud
Username | Password
<EMAIL_ADDRESS>| Cws@10102020
Ticket Link
https://mattermost.atlassian.net/browse/MM-43612
Related Pull Requests

Has server changes: https://github.com/mattermost/mattermost-server/pull/20703/files

Screenshots
Full size archived display:

Compact size archived and unarchived display:

Release Note
Cloud instances with a file limit (Starter and Professional subscriptions) show UI notifying that the limit has been hit and that archived files are unavailable until upgrade.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@stevemudie gentle ping for review


Add Event Entry Layout option for Time Above Title

Love the widget, thanks!
Can you add an option to the "Event entry layout" feature to allow putting the time above the title in addition to the existing option of time below title?

We have Time AND Location on the same line (and actually in the same text field) below the title.
Moving this above Title doesn't look convenient unless you hide Location
?!

Thisrequest is the same as in #167 Please follow up there.


BZ#1598893 - Updated URL for custom buttons dialogs

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes

fix for BZ # https://bugzilla.redhat.com/show_bug.cgi?id=1598893

Screenshot of the fix working as expected.

@chalettu LGTM 👍

@miq-bot add_label blocker

@chalettu would this also need to be backported to hammer,..if yes, can you add the hammer/yes label.

This got merged into master before hammer was cut so I don't believe it needs a hammer backport. @JPrause

Gaprindashvili backport details:
$ git log -1
commit bf5bb0e7e782b909ea6e8a6cbac7e14fd026e289
Author: Allen Wight<EMAIL_ADDRESS>Date:   Fri Aug 10 17:16:11 2018 -0400

    Merge pull request #1467 from chalettu/custom-button-details-url

    BZ#1598893 - Updated URL for custom buttons dialogs

    (cherry picked from commit b1cb62ed39127adb52c6ce8c1b6a100a722c26c1)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1646605
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1646604


Install target should also build cami & exceptions and install them

cami and exceptions will be built by default.
make install will also install cami and exceptions.
cami & exceptions install path will be exported in the pkgconfig file.

cami and exceptions will be built by default.
make install will also install cami and exceptions.
cami & exceptions install path will be exported in the pkgconfig file.


Add caution to the README to not upload the output of memory dump, and the feature is experimental

Also fix an old description of the output

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.629%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4463

Relevant Lines:
5676

💛  - Coveralls


Remove createJSModules @overide marker - RN 0.47 compatibility

createJSModules is now not required on Android from RN 0.47. I actually can't build an app on RN 0.47 without removing this method/@ovveride marker. This should be backwards compatible.

Hi! @evollu please review, merge and publish to npm to be ready for RN 0.47, this change is backward compatible.

@evollu

sorry I'm on vacation.
Please just remove the function

released as v4.0.0, will publish to npm tomorrow


upsert bug?

When saving a bookshelf record more than one time but with same id, it fails with a postgre sql error:
Unhandled rejection error: insert into "article" ("reference", "title") values ($1, $2) returning "reference" - duplicate key value violates unique constraint "article_reference_unique"
[...]

I prepared a sample for reproducing this issue: https://github.com/strarsis/bookshelf-upsert-issue

UPSERT was added to PostgreSQL in version 9.5 but the sample reproduction code is using v9.1. I believe you're not allowed to insert any records with the same unique id more than once in v9.1.

Thank you for looking into this issue.
Now I tried this also with 9.5/9.6/latest postgres version, but I still get the same error.
You can clone and try it here: https://github.com/strarsis/bookshelf-upsert-issue/tree/postgres_latest

So this issue also persists with a recent postgresql server.
How can I further debug this?

So the reason why this fails is that upsert isn't even implemented in underlying knex yet: https://github.com/tgriesser/knex/issues/54


Find, insert, update, delete

Initial work for CRUD operations using the RxSession.
Still a prototype and the code and commits are not that clean (sorry) but should be a good starting point for discussing how to move on.
It only works for a simple entity (no associations, no transactions, single table, no cascading, ... )
Tests require a PostgreSQL running,  this is the command using podman (should work with docker as well):
sudo podman run --ulimit memlock=-1:-1 -it --rm=true --memory-swappiness=0 --name PostgreSQL -e POSTGRES_USER=hibernate-rx -e POSTGRES_PASSWORD=hibernate-rx -e POSTGRES_DB=hibernate-rx -p 5432:5432 postgres:10.5

@FroMage Could you have a look at ReactiveSessionTest and the code in general and check that I didn't break any of your changes (or mostly that what I've changed make some sense), please?
@Sanne If you want to have a look I think this might be a good starting point.
Thanks

By the way, I think there is a transaction that doesn't get closed somewhere (I can see it form the Postgre Server log). If you have any idea on when that happens, it would be nice.

Transactions are automatically closed when you use the query methods on the pool. if you access the query method on the connection then you're responsible for closing it.
BTW, if you ever find that you have an async operation that's giving you trouble and you don't know who started it, use https://github.com/FroMage/quarkus/blob/panache-rx/extensions/panache/rx-panache/runtime/src/main/java/io/quarkus/panache/rx/runtime/RxOperations.java#L93
In hibernate-rx you will want to work not on the pool, but on a client, which can be either a connection or a transaction.
In Panache RX I use PgClient as given to me by the container: https://github.com/FroMage/quarkus/blob/panache-rx/extensions/panache/rx-panache/runtime/src/main/java/io/quarkus/panache/rx/runtime/RxOperations.java#L147
And then this class gives me a PgClient that is either transaction-scoped, and a PG transaction and part of the JTA transaction, or a request-scoped PgConnection: https://github.com/FroMage/quarkus/blob/panache-rx/extensions/panache/rx-panache/runtime/src/main/java/io/quarkus/panache/rx/runtime/client/TransactionScopedPgClient.java
This is really a copy of that the ORM guys did for Quarkus Hibernate ORM.

Merged https://github.com/hibernate/hibernate-rx/pull/7


feat: notify user interruption

Closes #525
This is part of the feature proposal. I'll add necessary comments and test case if the feature is accepted.

@krpeacock ping~

Hi, Kyle,It's strange that I received this Email, but I cannot see your comment on GitHub.Anyway, I can reply to you this way.The "interval" you mentioned is not a real interval. It's registered by setTimeout instead of setInterval. The callback is called once, no repeat. Once the II window is closed, we come to the then clause, no more future task is registered.ThanksWei发自我的手机-------- 原始邮件 --------发件人： Kyle Peacock @.>日期： 2022年2月13日周日 半夜12:42收件人： dfinity/agent-js @.>抄送： Wei Wei @.>, Author @.>主    题： Re: [dfinity/agent-js] feat: notify user interruption (PR #526)
@krpeacock commented on this pull request.
In packages/auth-client/src/index.ts:

@@ -284,6 +289,19 @@ export class AuthClient {

 // Open a new window with the IDP provider.
 this._idpWindow = window.open(identityProviderUrl.toString(), 'idpWindow') ?? undefined;

// Check if the _idpWindow is closed by user.
const checkInterruption = (): void => {

 // The _idpWindow is opened and not yet closed by the client

 if (this._idpWindow) {

   if (this._idpWindow.closed) {

     this._handleFailure(ERROR_USER_INTERRUPT, options?.onError);

   } else {

     setTimeout(checkInterruption, INTERRUPT_CHECK_INTERVAL);

Do we clear this interval anywhere?
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

It's strange that I received this Email, but I cannot see your comment on GitHub.Anyway

I had made that comment on mobile early in the morning, and I deleted it after looking closer at the code and realizing I was mistaken 😅.


unsafe apply actions on dev.*

It is possible to pop a VLAN and MPLS tag without proving the existence of those tags.

I just checked the dev.* instance, and it still has this behavior. Was it fixed in develop, but not pushed?

Fixed behavior to only display popTag action if a match for tag is present

This bug is resolved; however, when I update the match set and I already have a action started ... the action dropdown isn't reset. This is nit picking but we should address in a later version.


e2e: minor changes to allow running e2e on OpenShift

Most of my manual testing I do on OpenShift. It is useful to run the e2e suite for
validation. However, running on OpenShift fails with different issues. This PR
addresses the problems, and adds arguments that make it possible to run the
tests on an OpenShift deployment with a Ceph cluster configured through Red
Hats OpenShift Container Storage.
This isn't making everything work out of the box though. Some changes to the
files in the examples/ directory are still needed (like different drivername and
ServiceAccount). But things are getting much closer already.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

Hmm, this fails on Kubernetes now because the runAsUser has been dropped, will need to set a UID that works for both Kubernetes and OpenShift.
Failed: Error: container has runAsNonRoot and image will run as root (pod: "vault-bfdd5577b-fvllh_cephcsi-e2e-3a4167ea2926(545b370d-808a-4966-80fd-1e9b86f4a255)", container: vault)


Change AdventureWorkDW to AdventureWorksDW

Refer to here https://docs.microsoft.com/en-us/sql/analysis-services/multidimensional-tutorial/multidimensional-modeling-adventure-works-tutorial?view=sql-server-2017. It should be AdventureWorksDW instead of AdventureWorkDW.

@chanmmn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update; merging.
@chanmmn - Thanks for fixing the typo.


YouTube Code Block

Instead of adding in a bunch of frames for every video I want to write up something on is there a way to manually create a custom-frame with just the code block?

#   ``````custom-frame
All properties listed here and values
#    ``````

Hi! You can just create a single custom frame that links to YouTube itself, and then use the urlSuffix property to link the video you want to link. Specifically, you can set something like this:
The frame's url as https://www.youtube.com/watch?v=
And then a video can be displayed as
frame: YouTube Video
urlSuffix: <video id>


Display dropdown content on top if there's not enough space on bottom of dropdown

Is it possible to display dropdown content on top if there's not enough space on bottom. I have a very long form where the multiselect dropdown almost falls to bottom of the page. When the dropdown button is clicked, the page extends and gets a scrollbar to display content options.
Not sure if this was requested before. So opening a new enhancement ticket.
P.S: I am still on version 0.3.2. Can't update to latest as the angular version we are using is still 2.x.

You can add dropup to containerClasses in configuration to achieve this.
Try it out on my demo page: https://chris--jones.github.io/angular-2-dropdown-multiselect/

Unfortunately it doesn't work with the latest bootstrap 4 beta, any idea how to work around it?


Pass canvas context into lifecycle functions

Update shouldn't be called if the canvas context is undefined, so provide a context that we don't have to null-check to the update functions.
Other lifecycle functions may have optional context... tbd.
This context will be of either 2D or 3D type; maybe we can use this as a generic for the Project class, and resolve that type automatically? Or maybe that'd be annoying to deal with... try it out.
Make sure to note this in the Quick Start docs.

Maybe also pass in a non-optional canvas reference


I18n PL update

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Type of change
Please delete any options that are not relevant.

Translation update

Tip: I used Microsoft Language Portal to check some tech words


Restlike routes redirect for Notifications

To support links from notifications we will need a generic way to link to an entity. The MiqRequest is one of the entities user will want to be notified about. More to come.
@miq-bot add_label enhancement, ui, euwe/yes
@miq-bot assign @martinpovolny

@miq-bot assign @martinpovolny

/cc @skateman

Euwe Backport details:
$ git log
commit aa4515864faf7656e6fd77fb87a09587b8a1be24
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Thu Oct 6 10:30:37 2016 +0200

    Merge pull request #11607 from isimluk/restful-redirect

    Restlike routes redirect for Notifications
    (cherry picked from commit 3c462e23d5c18bc0318bce8adff96dab2adf078b)

Did we end up using this at all?
The only references to restful_redirect...
manageiq-ui-classic/spec/requests/restful_redirect_spec.rb
22:      get '/restful_redirect', :params => { :model => 'MiqRequest', :id => req.id }

manageiq-ui-classic/config/routes.rb
2969:    :restful_redirect => {

manageiq-ui-classic/locale/ManageIQ_UI_Classic.pot
6849:#: ../app/controllers/restful_redirect_controller.rb:15

No, I am sorry, this immediately become lowest priority after notification trello could checked. I still think it would be beneficial to do it. No idea about the other priorities though.
So please accept a random gif as apology.

Thanks @isimluk ! :) We've hit one of the methods during a dead code check .. so not removing, and  adding to the list of things to finish :)


Detect SVG without XML declaration

This PR only taps into signature macro and adds value check for <svg attribute, so that the reader can tell that the content is SVG.
Additionally, any additional changes that are related to #22 can be added in this PR

You should add a dedicated signature to SVG like for Drawio. Adding SVG on the XML signatures directly can create a detection errors: without the reader-xml feature, an SVG file without declaration would be considered as XML.
Please note that in the signature.rs file, the signatures are in order of decreasing size, and then alphabetical order.
Also, I'll put directly "<svg " instead of "<svg" in the signatures, it will be a bit more accurate.
The reader-xml feature will no longer be needed for XML-based formats without declaration: I will add it in the documentation of the crate.
Can you please make the changes?

Yeah, that makes perfectly sense.
Aside from adding a dedicated signature for SVG, I've also renamed the test case -- to better reflect what the test does.

Thanks!


Multi-GPU Inference

I want to generate the 1280 resolution video, but I don't have an A100 GPU. Is there any way to support multi-GPU inference?
Looking forward to your reply. Thank you

We don't support multiple GPUs right now, but you can take a look https://github.com/aigc-apps/CogVideoX-Fun/pull/79. VAE will support tile decoding.

We don't support multiple GPUs right now, but you can take a look #79. VAE will support tile decoding.

Thanks. I noticed that there is a 1.5 version branch. Will the model trained based on CogVideoX1.5 be made public later?

I want to generate the 1280 resolution video, but I don't have an A100 GPU. Is there any way to support multi-GPU inference? Looking forward to your reply. Thank you

Yes.


Webview-Sample: cannot find module 'path' / 'vscode'

After downloading and loading the webview sample, extension.ts contains an error:
Cannot find module 'path'. ts(2307) [1,23]
Cannot find module 'vscode'. ts(2307) [2,25]
Parameter 'e' implicitly hasan 'any' type. ts(7006) [96,4]
Parameter 'message' implicitly has an 'any' type. ts(7006) [107,4]

Did you run npm install?

After npm install it worked.
I would suggest to include that information here:
https://code.visualstudio.com/api/extension-guides/webview
At best close to the link to the github repository.

This is covered in https://github.com/microsoft/vscode-extension-samples/tree/master/webview-sample#running-the-example


Threadsafe for mono

see:ModuleBuilder.DefineType is not thread-safe https://github.com/neuecc/MessagePack-CSharp/issues/161

Ver 1.3.2 includes this fix.


Delete display bug

Deleting when only one person is displayed in the list (such as find alex followed by delete 1) will cause the person list panel to turn white.

Thanks for letting us know about this. We were actually aware about this issue. However, this bug seems apparent in the base version of the address book. We'll fix it if time permits.

Thanks for the suggestion. Yup it is a known issue and I will try to fix it on my end.

The issue is fixed as of latest merge via a [small modification]. (https://github.com/CS2103AUG2017-T10-B3/main/pull/97)


Feature Request: 'Lock' an Instance

Provide a way to 'lock' an instance from getting deleted or re-aliased by other folks on a team.
I assume this gets into team roles and permissions, not sure where this is on your roadmap.

Thank you so much for the effort you have put into this issue! 😊
However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.
You can read more about our biggest release yet here: https://zeit.co/blog/now-2


GIX: Sns Account Encode and Decode utils

Motivation
User sees the string representation of the SNS Accounts.
Changes

New ledger utils to encode and decode the sns accounts.

Tests

Test new ledger utils.

@peterpeterparker please review


Add UDS support for Unix systems

Summary
This change adds UDS support for Unix systems. The networking primitives
src/net/uds. These modules provide the structs for UnixDatagrams,
UnixListeners, and UnixStreams. Each of the methods on these structs
dispatch to the Unix system structs in src/sys/unix/uds.rs.
Use of these new structs should feel fairly similar to the Tcp[...]
equivalents. The tests added also reflect the similar behavior that would be
expected.
Details
Since this change only adds UDS support, there should be no behavior changes
anywhere else. For reviewing, I recommend starting from the networking
primitives and seeing what methods they dispatch to.
The tests added in tests/uds.rs should feel fairly similar to
tcp_stream.rs--the main difference coming from supporting PathBufs as the
socket address to connect to.
I originally pulled in some testing infrastructure added to v0.6.x in #944,
but ultimately found the functionality to not be as helpful due to a lot of
changes that have since taken place in master. I think #944 could still be
helpful, but as a separate change that is more about improving testing
functionality and not included in a change that introduces additional
functionality.
Signed-off-by: Kevin Leimkuhler<EMAIL_ADDRESS>

How does this PR compare to alexchrichton/mio-uds ?

@asomers this is updating the UDS implementation to the latest mio. It also moves it in tree because std now supports UDS and moving it in tree reduces the number of dependencies.

Same as for UnixDatagram and UnixListener:

std -> sys,
std::os::unix::net::UnixListener -> net::UnixListener, and
add SelectorId.

@Thomasdezeeuw I'm not sure I follow all the parts of this comment in UnixStream, UnixDatagram, and UnixListener.
I can rename the std field to sys, and I have added the selector_id field for debug assertions.
I'm not sure I follow std::os::unix::net::UnixListener -> net::UnixListener. These types are not available in std::net, they are only available through these paths and must be imported directly.

@Thomasdezeeuw I think most of your comments should be addressed from the last commit.  Originally, the UDS types dispatched the the std UDS
types from the net module. This was different from other net module
types because it did not use the sys modules types for that OS.
This was okay because currently UDS is only supported by Unix, but when
windows support is added this would have been a problem.
The new structure sets up most of the work for Windows UDS support as
the net module UDS types now all dispatch to their inner sys module
types.

I have left all your comments from your last review that had to do with this unresolved, but I think they should all be addressed at this point.

Since this change is so large, can some double check this and merge if acceptable?

@carllerche I had limited the use of mio's SocketAddr because it had felt more like an inconvenience that libstd's SocketAddr was not public; I leaned towards using it in the least amount of places possible.
That's a good point though about using it everywhere for now and changing over all at once when we can. I'll make that change!

@carllerche Had to introduce some further mio::unix::SocketAddr functionality to return it everywhere it is used, but net::SocketAddr is no longer used now.
Also fixed a cfg in the UDS tests that was not actually running them correctly.


hypershift e2e script changes

Description

Hypershift install args
Hypershift CLI install inputs
Indexing management cluster stats
Firewall changes

Fixes

@dry923 @morenod Need your review on this PR when you get time please? We are looking at leveraging this script for chaos testing HyperShift. Thanks.


Schema error creating physical plan for TPC-DS q10

Describe the bug
Creating a physical plan for q10 fails with:
Error: SchemaError(FieldNotFound { field: Column { relation: Some("web_sales"), name: "ws_bill_customer_sk" }, valid_fields: Some([Column { relation: Some("customer"), name: "c_customer_sk" }, Column { relation: Some("customer"), name: "c_current_cdemo_sk" }, Column { relation: Some("customer"), name: "c_current_addr_sk" }]) })

Here is the part of the logical plan that failed in create_intial_plan:
FAILED ON SubqueryAlias: c [c_customer_sk:Int32, c_current_cdemo_sk:Int32, c_current_addr_sk:Int32]
  LeftSemi Join: web_sales.ws_bill_customer_sk = c.c_customer_sk [c_customer_sk:Int32, c_current_cdemo_sk:Int32, c_current_addr_sk:Int32]
    TableScan: customer projection=[c_customer_sk, c_current_cdemo_sk, c_current_addr_sk] [c_customer_sk:Int32, c_current_cdemo_sk:Int32, c_current_addr_sk:Int32]
    Projection: web_sales.ws_bill_customer_sk [ws_bill_customer_sk:Int32]
      Inner Join: web_sales.ws_sold_date_sk = date_dim.d_date_sk [ws_sold_date_sk:Int32, ws_bill_customer_sk:Int32, d_date_sk:Int32]
        TableScan: web_sales projection=[ws_sold_date_sk, ws_bill_customer_sk] [ws_sold_date_sk:Int32, ws_bill_customer_sk:Int32]
        Projection: date_dim.d_date_sk [d_date_sk:Int32]
          Filter: CAST(date_dim.d_year AS Int64) = Int64(2002) AND CAST(date_dim.d_moy AS Int64)date_dim.d_moy >= Int64(4) AND CAST(date_dim.d_moy AS Int64)date_dim.d_moy <= Int64(7) [CAST(date_dim.d_moy AS Int64)date_dim.d_moy:Int64, d_date_sk:Int32, d_year:Int32]
            Projection: CAST(date_dim.d_moy AS Int64) AS CAST(date_dim.d_moy AS Int64)date_dim.d_moy, date_dim.d_date_sk, date_dim.d_year [CAST(date_dim.d_moy AS Int64)date_dim.d_moy:Int64, d_date_sk:Int32, d_year:Int32]
              TableScan: date_dim projection=[d_date_sk, d_year, d_moy] [d_date_sk:Int32, d_year:Int32, d_moy:Int32]

To Reproduce
Unigore test tpcds_physical_q10.
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

The bug is that the join keys are assumed to be in the same order as the left and right relations but in this case the left key is in the right schema
left schema = ["customer.c_customer_sk", "customer.c_current_cdemo_sk", "customer.c_current_addr_sk"]
right schema = ["web_sales.ws_bill_customer_sk"]
l = web_sales.ws_bill_customer_sk, r = c.c_customer_sk

The second bug is that the schema has customer.c_customer_sk but the join condition has c.c_customer_sk

tpcds-35 also have this problem.

@askoa , I also investigated this problem.
Your comments are very useful to solve this problem, thank you.

Seems the schema error when creating the logical / physical plan has been resolved in the meantime.


How to invoke the code action to create and update a TOC in VSCode ?

The marksman language server is implemented with the code action of build and update the ToC of a file. However, I tried the VSCode command palette, the Ctrl+, quick code action keyboard shortcut and Ctrl+Space quick completion menu, none of these options contains the ToC code action.
Is this feature implemented in the VSCode extension, or is there an way to enable it in VSCode extension?

Try right clicking to open the menu and select Source Action....

Try right clicking to open the menu and select Source Action....

I'm writing some markdown files again nowadays, and the bug is that the code action cannot be invoked by the user-configurated keybinding ctrl+oem_comma. And after triggering the code action using command palette or the right-click menu, the code action is still invalid when using the keybinding. What's worse, the user-configurated keybinding will corrupt the code action somehow, causing invocation from right-click menu fail and can only be invoked again using command palette.

Resolved: An clobbered keybinding cause the erroneous response.


Change disk size value in devmapper test

Description
On some machine, the root test testMakeFileSystem (https://github.com/containerd/containerd/blob/main/snapshots/devmapper/pool_device_test.go#L240) fails with error
Not enough space to build proposed filesystem while setting up superblock

The reason behind is not a containerd bug itself, but the minimal size of a disk required for a partition is larger than the size of the disk created by the test. Current disk size is approximately 100KB and 200KB https://github.com/containerd/containerd/blob/main/snapshots/devmapper/pool_device_test.go#L43). 1MB and 2MB will be enough.
To reproduce manually, create a disk of size indicated, and try mkfs.ext4 <disk>.
Another workaround is to precise explicitly the blocksize with -b 1024. So,  mkfs.ext4 <disk of 100KB> -b 1024 is OK.
Reproduced on two machines:
uname -a
Linux rdr-runtimes-dev-etienne-guesnet-cont-test-1 5.4.0-99-generic #112-Ubuntu SMP Wed Feb 2 17:12:06 UTC 2022 ppc64le ppc64le ppc64le GNU/Linux

and
uname -a
Linux pwr-rt-bionic-x1.fyre.ibm.com 5.4.0-91-generic #102-Ubuntu SMP Fri Nov 5 16:31:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Steps to reproduce the issue
No response
Describe the results you received and expected
Results:
Not enough space to build proposed filesystem while setting up superblock
Expected:
Nothing (if run in testsuite), or something like
Creating filesystem with 96 1k blocks and 16 inodes

Allocating group tables: done
Writing inode tables: done
Writing superblocks and filesystem accounting information: done

using directly mkfs.ext4 in a terminal.
What version of containerd are you using?
main branch of git repository
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

@EGuesnet can you update the title of this issue to include the architecture? as we've hit differences before due to larger page sizes on Power, it will probably be more obvious to folks as to why we'd like a change in the test.


Unable to setup basic auth

This may not be the correct place for this, if so please direct me to the right place.
I just started using postgrest recently and I followed the wiki tutorial https://github.com/begriffs/postgrest/wiki/Security-and-Permissions to setup basic auth access. I have the schema, table and trigger and I manually set a few of the roles as well as verified that the the trigger rejected adding rows that do not correspond to roles. Everything seems to be there and I have access through the anonymous flag but I cannot authenticate with basic auth. I always get a
401 Invalid username or password

response.
the --db-user and --db-pass I am using is granted usage on the postgrest schema. Currently it is a super user and can insert and delete data.
Any ideas?

The authentication can be tricky and its setup should probably be better automated by postgrest in the future. If you inspect the postgrest.auth in something like pgadmin can you tell me what rows you see inside it? I want to be sure that you not only have database roles set up but that you have "web users" in the auth table as well.

Yeah I just have trivial roles and passwords:
From roles.sql
-- c11z is god
CREATE ROLE c11z SUPERUSER LOGIN PASSWORD 'c11z';
-- anon is useless
CREATE ROLE anon NOLOGIN;
-- lurker is the web crawler's database user
CREATE ROLE lurker LOGIN UNENCRYPTED PASSWORD 'lurker' NOSUPERUSER INHERIT        NOCREATEDB NOCREATEROLE NOREPLICATION;
-- Group for sharing api access
CREATE ROLE api;
-- maestro is the main api that has access to the database
CREATE ROLE maestro LOGIN UNENCRYPTED PASSWORD 'maestro' NOSUPERUSER INHERIT  NOCREATEDB NOCREATEROLE NOREPLICATION;
GRANT api to maestro;

From postgrest.auth
cdb=# select * from postgrest.auth;
   id    | rolname |                             pass
---------+---------+--------------------------------------------------------------
 c11z    | c11z    | c11z
 lurker  | lurker  | lurker
 maestro | api     | maestro
(3 rows)

When I launch postgrest
postgrest -d cdb -P 5432 -U c11z --db-pass c11z --db-host <IP_ADDRESS> -p 3000 -a c11z

Sometimes I use anon of for -a but of course I get nothing. With c11z as -a I get full access until I try to use basic auth then I get 401 for any user I try.

One problem is that you have plaintext passwords in the auth table. The proper way to create users right now is to run postgrest with a powerful anonymous role and post to the /postgrest/users route with a payload that looks like
{
  "id": "lurker",
  "pass": "lurker",
  "role": "lurker"
}

It will encrypt the password with bcrypt and then write a row to the auth table. So erase the rows you have in there now and recreate them by posting to this route.
In the future I should add command line options to make users without having to do HTTP posts.

That worked, thanks.
One small problem is that in the 201 response I see
Malformed JSON

Since the post worked and my json is simple I suspect there may be a bug in whatever json is supposed to be returned as a response.
Also I get 404's when I try to GET /postgrest/users?id=eq.c11z whether I use the c11z basic auth or not.

I think the Malformed JSON message happens because the response is blank and yet is delivered with content type json (an empty string is not proper json). I could have it omit a content type or use text/plain when the response is empty to avoid the warning.
Also the reason you can't request /postgrest/users is that it is a special-case route that only accepts post. It is kind of limited so far. There is no way to change a password over HTTP for instance. Tasks like that still require some manual intervention.

Thank you.


Error when loading nif.owl in Protege: core.owl not found

Hello,
When trying to load the NIF ontology (http://purl.org/nif/ontology/nif.owl) in Protege using file -> Open from URL... similarly to what is described on this page, I get the following error:

I am using Protege 5.0.0. The log is:
loading OntologyID(Anonymous-0) from http://purl.org/nif/ontology/nif.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/nif_backend.owl>)) from http://ontology.neuinfo.org/NIF/Backend/nif_backend.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/BIRNLex-OBO-UBO.owl>)) from http://ontology.neuinfo.org/NIF/Backend/BIRNLex-OBO-UBO.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/BIRNLex_annotation_properties.owl>)) from http://ontology.neuinfo.org/NIF/Backend/BIRNLex_annotation_properties.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/OBO_annotation_properties.owl>)) from http://ontology.neuinfo.org/NIF/Backend/OBO_annotation_properties.owl
loading OntologyID(OntologyIRI(<http://protege.stanford.edu/plugins/owl/dc/protege-dc.owl>)) from http://protege.stanford.edu/plugins/owl/dc/protege-dc.owl
loading OntologyID(OntologyIRI(<http://www.w3.org/2004/02/skos/core>)) from http://www.w3.org/2004/02/skos/core
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/pato.owl>)) from http://ontology.neuinfo.org/NIF/Backend/pato.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/quality_bfo_bridge.owl>)) from http://ontology.neuinfo.org/NIF/Backend/quality_bfo_bridge.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/ro.owl>)) from http://ontology.neuinfo.org/NIF/Backend/ro.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/ro_bfo1-1_bridge.owl>)) from http://ontology.neuinfo.org/NIF/Backend/ro_bfo1-1_bridge.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/bfo.owl>)) from http://ontology.neuinfo.org/NIF/Backend/bfo.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/NIF-Quality.owl>)) from http://ontology.neuinfo.org/NIF/Backend/NIF-Quality.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/DigitalEntities/NIF-Investigation.owl>)) from http://ontology.neuinfo.org/NIF/DigitalEntities/NIF-Investigation.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/Backend/BIRNLex-OBI-proxy.owl>)) from http://ontology.neuinfo.org/NIF/Backend/BIRNLex-OBI-proxy.owl
loading OntologyID(OntologyIRI(<http://ontology.neuinfo.org/NIF/DigitalEntities/CogPO.owl>)) from http://ontology.neuinfo.org/NIF/DigitalEntities/CogPO.owl
loading OntologyID(OntologyIRI(<http://purl.obolibrary.org/obo/iao/dev/iao-main.owl>)) from http://purl.obolibrary.org/obo/iao/dev/iao-main.owl
loading OntologyID(OntologyIRI(<http://purl.obolibrary.org/obo/bfo/2014-05-03/classes-only.owl>)) from http://purl.obolibrary.org/obo/bfo/2014-05-03/classes-only.owl
loading OntologyID(OntologyIRI(<http://purl.obolibrary.org/obo/ro/releases/2015-02-11/core.owl>)) from http://purl.obolibrary.org/obo/ro/releases/2015-02-11/core.owl
File not found: https://raw.githubusercontent.com/oborel/obo-relations/v2015-02-11/core.owl
java.io.FileNotFoundException: https://raw.githubusercontent.com/oborel/obo-relations/v2015-02-11/core.owl
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	[...]
	... 182 more

It looks like the issue comes from the import of http://ontology.neuinfo.org/NIF/DigitalEntities/NIF-Investigation.owl -> http://ontology.neuinfo.org/NIF/DigitalEntities/CogPO.owl -> http://purl.obolibrary.org/obo/iao/dev/iao-main.owl that links to http://purl.obolibrary.org/obo/ro/releases/2015-02-11/core.owl which is not found.
Could you let me know if this is the right URL to access NIF owl file or if, in relation to the transition to scicrunch and GitHub, there is another location (URL) that I should look at? (I get the same error when opening the nif.owl file available in this GitHub repository.)
Thank you in advance!

This bug has been reported to upstream here: https://github.com/OBOFoundry/purl.obolibrary.org/issues/144.

I have issued a temporary fix in http://ontology.neuinfo.org/NIF/DigitalEntities/CogPO.owl so it will import.

Thank you! I can confirm that nif.owl is now loading following this fix.


Reproduce problem on 15-1

I reproduce 15-1 setting
the result is:
  | 1-15 | 16-20 | mIoU | all
mib | 35.1 | 13.5 | 29.7 | -
PLOP(reproduce train) | 64.94 | 20.77 | 53.90 | 55.16
PLOP(reproduce test) | 65.01 | 16.85 | 52.97 | 54.11
PLOP(paper) | 65.12 | 21.11 | 54.64 | 67.21
it is reasonable  for train but for add --test the result drops too much.

In other words, resutl is different  between the test after the whole training or  test it by using the same script and parameters but using the command --test

Hello, thanks for your report, it's indeed weird. I haven't found it before because I was always re-training all steps.
I've made a hot fix where we always reload the saved weight (https://github.com/arthurdouillard/CVPR2021_PLOP/commit/381cb795d70ba8431d864e4b60bb84784bc85ec9) but I'll try to undertstand later why does it happen.
I've just re-run a 15-1 overlap plop and here are my results with training mode and with testing mode as you did:
(old/new/all/avg)
Train mode: 66.4 / 19.31 / 55.19 / 67.09
Test mode:  66.4 / 19.31 / 55.19 / 67.09
Results are a bit different from paper results (a bit better in old, and a bit worse in new), but that's expected as I've run this on another machine than the one I've used for the paper.


support bind targetIp to start service

support bind targetIp to start master&meta&data service
support depoly cluster at one node.

Codecov Report

Merging #1726 (bb0e5df) into master (8e449b6) will increase coverage by 0.00%.
The diff coverage is 21.62%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##           master    #1726   +/-   ##
=======================================
  Coverage   49.40%   49.41%
=======================================
  Files         451      451
  Lines       74183    74201   +18
=======================================
+ Hits        36649    36664   +15
- Misses      34645    34649    +4
+ Partials     2889     2888    -1

Impacted Files
Coverage Δ

metanode/btree.go
0.00% <ø> (ø)

metanode/metanode.go
0.00% <0.00%> (ø)

metanode/partition_fsm.go
0.00% <0.00%> (ø)

metanode/partition_fsmop_inode.go
0.00% <0.00%> (ø)

metanode/server.go
0.00% <0.00%> (ø)

master/server.go
56.43% <25.00%> (+0.21%)
:arrow_up:

master/http_server.go
84.63% <100.00%> (ø)

util/stat/statistic.go
61.64% <100.00%> (+1.15%)
:arrow_up:

master/meta_partition.go
58.15% <0.00%> (-1.18%)
:arrow_down:

...r/github.com/cubefs/blobstore/common/rpc/simple.go
70.92% <0.00%> (-0.89%)
:arrow_down:

... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


exec-healthz: Fix user:group configurations

Fixes #2661. See discussions on #2670.
Some others user:group configurations are imported from kubernetes/dns#31.
/assign @bowei @luxas
@guirish Could you please build/test s390x image with this? I don't have the correct environment. Thanks :)

This change is

@luxas Thanks for the comment. Unfortunately, doesn't seem like there is a consistent uid/gid we could use across every distro: https://en.wikipedia.org/wiki/User_identifier#Special_values, at least nobody has had a few different IDs.
Also just learned a bit how we set user in k8s yaml spec, found https://kubernetes.io/docs/tasks/configure-pod-container/security-context/. Don't think it is obvious enough that every user will follow :(

Also just learned a bit how we set user in k8s yaml spec, found https://kubernetes.io/docs/tasks/configure-pod-container/security-context/. Don't think it is obvious enough that every user will follow :(

If they don't, they don't.
The best way to solve this is to go all-in on either alpine or busybox I think and set this value in the k8s spec to make it visible for the admin.
I've never liked that we treat different platforms differently without a real reason...
@MrHohn What do you think about that?

Is that possible given all of the platforms?

alpine exists for all arches, yes

The best way to solve this is to go all-in on either alpine or busybox I think and set this value in the k8s spec to make it visible for the admin.

Make base images consistent sounds good to me. Though it still makes sense to configure a non-root user:group in Dockerfile by default,  in that way user will be better protected even if they don't set it in k8s spec.

@MrHohn the build is successful for ARCH=s390x. As it is the same change which was suggested in PR #2670 for s390x, I did not encounter any issues while testing it on s390x. I will close PR #2670 once you merge these changes.

This change LGTM
/cc @ixdy @timstclair looks good to you?

Nice. We should make this change to other images that use a mix of alpine & busybox.

/lgtm

@bowei @luxas @MrHohn For building exechealthz for s390x ARCH, I had to add correct 'BUILD_IMAGE' in make command for build to pass.
make ARCH=s390x container VERSION=1.X BUILD_IMAGE=s390x/golang:1.7-alpine3.6
Can we update the Makefile to use BUILD_IMAGE specific to the architecture (similar to BASEIMAGE)?

@guirish Did it fail during the build or the built image is broken? I'm not seeing error on my end:

.../contrib/exec-healthz$ ARCH=s390x make container
building: bin/s390x/exechealthz
Sending build context to Docker daemon 22.89 MB
Step 1 : FROM s390x/alpine
latest: Pulling from s390x/alpine

d45fd9d3c4f1: Pull complete
Digest: sha256:3297a9b30b666eb3e2a926fbbe49dbdbc60a457deb1487a0df7838a9beb02916
Status: Downloaded newer image for s390x/alpine:latest
 ---> 63a4f4f24775
Step 2 : MAINTAINER Prashanth B<EMAIL_ADDRESS> ---> Running in 2e202c14b409
 ---> bcde52cf8617
Removing intermediate container 2e202c14b409
Step 3 : ADD bin/s390x/exechealthz /exechealthz
 ---> 21577bbbe99f
Removing intermediate container 925c33b85fab
Step 4 : USER nobody:nobody
 ---> Running in 46dfb6d0d358
 ---> 6754df8bdf9f
Removing intermediate container 46dfb6d0d358
Step 5 : ENTRYPOINT /exechealthz
 ---> Running in 5f09e17600cb
 ---> 5fa7374c14b4
Removing intermediate container 5f09e17600cb
Successfully built 5fa7374c14b4
container: gcr.io/google_containers/exechealthz-s390x:b0d0b90e

@MrHohn He's on s390x himself I think and you're cross-compiling, that's the difference.

@guirish We may not want to bind BUILD_IMAGE with ARCH, as we usually cross compile images for all arch on the same machine. Another thought is to add a variable say BUILD_ARCH, but that sounds not much different from explicitly specifying the BUILD_IMAGE.

@MrHohn Thanks for the updates. Could you kindly push a new docker images of exechealth for s390x on google repository, so that we can have a working copy of exechealthz for our reference.

@guirish Sure, checked a bit and found we never released s390x image for exec-healthz. So I pushed one with the newest tag we have on the other platforms (gcr.io/google_containers/exechealthz-s390x:1.2).


doc: add putting imagePullSecret in the service account

Signed-off-by: akihikokuroda<EMAIL_ADDRESS>Closes #363

I'll update.  Thanks!


challenge-09

@diemilio, I'm going to merge it into a branch, so I can make some edits and then push it live. Thanks for the contribution.

Thanks @amirebrahimi


Bump COLLECTOR_VERSION

Description
Bump collector version to one that is on master. Latest master has some tests broken by the kernel module deprecation so we can't use #5488 for now.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
CI should be enough.

/retest


Add validation to OpenAI URL

Invalidate URLs that have spaces in the hostname since golang doesn't like that
e.g. https://api.open ai.com would throw an error invalid character "" in host name
This prevents saving invalid URLs in the form:

I've added a PR that I think might do.
It appears to be a convention that Grafana settings pages let you input invalid details and save them, only exposing the problem when the health-check fails later ("Save & test" button). The PR maintains that convention, but invalid settings can now be fixed.

Closing since https://github.com/grafana/grafana-llm-app/pull/405 fails the health check and serves the same purpose in a better way


Fix VV and GHMC NCMC

Lots of fixes for VV and GHMC NCMC!

Wow, I wonder if I accidentally brought in some other changes.

I think there are a few more logic flow issues left over from reworking the integrators into something you have to call nsteps times.  Sorting those out now. Don't merge yet!

I've refactored the common code between NCMCVVAlchemicalIntegrator and NCMCGHMCAlchemicalIntegrator into an NCMCAlchemicalIntegrator base class and vastly simplified the code for the VV and GHMC NCMC integrators.  The NCMC tests pass on my machine.
Let's see if the tests pass here and then you can review and merge, @pgrinaway!
Wait...why is travis not running?

Ah. Travis isn't running because this is a PR into your branch, @pgrinaway

OK, so you'll need to review and merge and take things from here, @pgrinaway.

Thanks so much! will review and merge!

This looks great! Thanks a million!


Closer Github UI look

When we have a look to Gitea compared to Github it's look alike but there are several color and menu ui tweak that still need to be done.
On the other hand, semantic ui provide a good template that look like Github better than Gitea do.
I think an improvement can be done around semantic to see why Gitea doesn't seems to look as it should.
Maybe an update of the vendor css or something else.
After this step, the theming feature should be a plus  (I will make another issue for that).

Nope, forget it. We are forced to look different than GitHub, otherwise we will end up like this: https://gitbucket.github.io/gitbucket-news/gitbucket/2016/03/20/change-user-interface.html

I didn't know about that.
Thanks


Is it compatible with latest ES 1.5.0?

I can't seem to get it started.

Exception in thread "elasticsearch[Slither][dynamodb_river][T#1]" com.amazonaws.AmazonClientException: Unable to marshall request to JSON: N
ull key.
        at com.amazonaws.services.dynamodbv2.model.transform.ScanRequestMarshaller.marshall(ScanRequestMarshaller.java:265)
        at com.amazonaws.services.dynamodbv2.AmazonDynamoDBClient.scan(AmazonDynamoDBClient.java:291)
        at org.elasticsearch.river.dynamodb.DynamoDbRiver$Indexer.index(DynamoDbRiver.java:217)
        at org.elasticsearch.river.dynamodb.DynamoDbRiver$Indexer.run(DynamoDbRiver.java:187)
        at java.lang.Thread.run(Unknown Source)
Caused by: com.amazonaws.util.json.JSONException: Null key.
        at com.amazonaws.util.json.JSONWriter.key(JSONWriter.java:206)
        at com.amazonaws.services.dynamodbv2.model.transform.ScanRequestMarshaller.marshall(ScanRequestMarshaller.java:107)
        ... 4 more

I figured out the null key error. It had to do with the "updated" field. that field has to be a number in the database.
I have another problem now. The plugin just makes ES unresponsive, this is the last line in the log:
[2015-04-09 03:01:04,445][INFO ][river.dynamodb           ] [elasticsearch1.localdomain] [dynamodb][votes] Start DynamoDB for table Votes

I managed to get this river plugin working on my windows machine, but the Linux is giving me trouble.


Update outdated macros

Description
This updates some documentation macros to point to the correct versions in the dart:ui package. I had updated them in the engine a long time ago, but didn't get around to renaming them in the framework (until now).
Tests

Should be test exempt (docs only).

Related PRs

https://github.com/flutter/engine/pull/30002
https://github.com/flutter/engine/pull/30006

What the heck?  That macro is literally defined in the same file as the original. The only difference is the name. Hrm.

Oh, I see. The newly referenced symbol doesn't exist (it's prefixed with ui.) in the referring code.

I guess the engine PR needs to be rolled in before this will pass the docs tests.

Yes, that's the case.


文档中英文夹杂

Issue Type
Documentation Bug
Source
binary
Secretflow Version
/
OS Platform and Distribution
/
Python version
/
Bazel version
No response
GCC/Compiler version
No response
What happend and What you expected to happen.
- https://www.secretflow.org.cn/docs/secretflow/latest/zh-Hans/tutorial/CustomDataLoaderTF#%E6%8E%A5%E5%8F%A3%E4%BB%8B%E7%BB%8D
- https://www.secretflow.org.cn/docs/secretflow/latest/zh-Hans/tutorial/CustomDataLoaderTF#3.-Build-dataset_builder_dict
- https://www.secretflow.org.cn/docs/secretflow/latest/zh-Hans/tutorial/CustomDataLoaderTorch#Define-the-Model-Architecture

出现中文文档夹杂英文

Reproduction code to reproduce the issue.
above


Improve function interface docs

Issue Ref: None
Description:
Improve docs related to the new function interface
TODOs:

[X] Ready to review
- [ ] Automated Tests
[X] Docs

LGTM


More info possible?

Hello Erik,
Is it possible to get even more info out of this? Like returnflow on heating, gassmoke temp and kwh usage graph?
Great intergration btw.

If the data is available in the app or on the website under expert panel, it should be automatically added.
Did you set mode to both in  your configuration?

Hello :)
Im Sorry i was sleeping when i set it up ! I didnt remove the #
Sorry for the time sir! really a great intergration u made


Fine tune the MessageHandlerLookup for Spring Native support

This PR contains changes to support Spring Native through the Spring Native Extension.

Hi!, for what release number (milestone)?

Hi!, for what release number (milestone)?

Thanks for the interest in this feature, @mbecca.
As soon as we conclude on the release, we'll update this issue's "milestone" field.
I'd hope we make it for 4.6.0, but this is by no means a blocker for that release at the moment.
So, in short, stay tuned!

We refer to Bike Rental - Native Edition sample project for those interested in a workable use case of this pull request.

Note that this pull request no longer inserts the full Axon Spring Native implementation.
Instead, it provides a level of support so that the dedicated Spring Native Extension can provide that implementation.


Set up travis to run unit- or integration-tests only

Just a re-imagining of our Travis build. Now we can run a unit-test-only build, followed by the full suite of IT env's, but without unit tests.
The unit tests run in under 20 minutes, and the IT's without them run in under 40. Because of the faster execution time, we can use the "trusty" Travis build (8GB, 50-min limit).

:ok_hand: :thumbsup: :clap:

The unit-test-only is running out of memory - some tweaks to do. Also, want to pull the dev-resources from our repo on S3 instead of building every time.

OK, memory is increased, and the S3 pull is working.


refactor: UartStmDuplexDma to reuse UartStm

There seems to be a lot of duplication with different flavour of UART's. This PR aims to reuse UartStm base class and build on top of it for DMA functionality.

There is no prevention to set oneBasedIndex in constructors to 0. As result oneBasedIndex-1  for transmitDmaChannel will have value 255.


Field returns html by default, method text() does not exist

The documentation states that the Doxter Model returns the plain text content stored via the field type. It also describes a method text() to achieve the same result.
I just installed Doxter on a Craft 3-beta.10 install. {{ entry.doxterField }} returns the formatted HTML, albeit with the tags escaped. Using  {{ entry.doxterField.text() }} throws an error:
Neither the property "text" nor one of the methods "text()", "gettext()"/"istext()"/"hastext()" or "__call()" exist and have public access in class "selvinortiz\doxter\fields\data\DoxterData".
After digging around the source code I was able to output the plain text content with {{ entry.doxterField.getRaw() }}. Is this the new way of doing it? If so, please update the docs.

@connor-baer Thanks for the heads up! We'll update the code or the documentation to address text()|getRaw().
We'll make sure that plain text is returned by default.
Thank you so much for taking the time to open an issued🙏

@connor-baer The next version of doxter will have {{ entry.doxterField }} return parsed html, the same as {{ entry.doxterField.html }}. We opted to do it like this, because craft is doing the same.
To get the raw content, you can now do {{ entry.doxterField.raw }}.
The documentation will reflect these changes as soon as the next version is released. Hope this clarifies everything.

@gui-gui Sounds good to me. Thank you for your hard work!

Thanks for clarifying and implementing this!


Aggregate 'special event' trackers with normal trackers

That way when you have one legend with specialEvent_kills = 7 and another legend with kills = 10, your total_kills should be 17

Would be stat "Total kills" shown in global_info or somewhere else?

the API has a 'totals' section, but it's just an aggregation of the legends data, so I was thinking that I would keep the 'totals' (use the 'tracker' class) and add a 'total_kills'
so we would have player.totals.special_event_kills player.totals.kills (and now) player.totals.total_kills  or something like that

I'm moving this issue over to my other repository. apex-legends-tracker
The reason is that I'm going to add more of this kind of logic to a 'tracker' instead of the core API.  This repo really should just get the data from apexlegendsapi.com
Cloned to: https://github.com/johnsturgeon/apex-legends-tracker/issues/9