Update INC quick start examples

Existing Sample Changes
Description
Update two INC quick start examples README.md with new template.
Fix the code error to adapt to new API.
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Delete this line and everything below if this is not a PR for a new code sample
Delete this line and all above it if this PR is for a new code sample
Adding a New Sample(s)
Description
Please include a description of the sample
Checklist
Administrative

[ ] Review sample design with the appropriate Domain Expert:
[ ] If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

[ ] Implement coding guidelines and ensure code quality. see wiki for details
[ ] Adhere to readme template
[ ] Enforce format via clang-format config file
[ ] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
[ ] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
[ ] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

[ ] OSPDT Approval (see Project Manager for assistance)
[ ] Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
[ ] Bandit Scans (Python only)
[ ] Virus scan

Review

[ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
[ ] Review readme with Tom Lenth(@tomlenth) and/or Project Manager
[ ] Tested using Dev Cloud when applicable

@NeoZhangJianyu
You might not work on the right code base. please rebase your local codes to the latest development branch

This out of date. I updated the README directly so closing this PR.


add a test for tokenizeTopN(text, n, profile)

to improve coverall coverage for: tokenizeTopN(text, n, profile)

Coverage increased (+0.2%) to 98.333% when pulling 27126806f1e4f957f59ba37c4088c869db4e8e3e on ksseono:master into fb376ad4179c21f3d016259cb2e5af418790b41a on open-korean-text:master.

Coverage increased (+0.2%) to 98.333% when pulling 9825efee2b9da809bc9a1dd312e814c934531151 on ksseono:master into fb376ad4179c21f3d016259cb2e5af418790b41a on open-korean-text:master.

LGTM thanks!


A few typos in texts fixed.

This must be a mistake of the CI script, since to submit this PR I made:

a fresh clone;
changed the texts only (not exportable to scripts);
notebook2script.py produces no new files to be added to commit;
diff_nb_script.py (from the repo) reports;
This cell doesn't have an export destination and was ignored:
but returns 0 exit code.

!!! Diff between nbs and scripts
!!!Remember to run notebook2script.py or script2notebook.py
##[error]Bash exited with code '1'.
##[section]Finishing: Detect diff module/nbs

Yes, one of the developers of v2 that we won't name doesn't run his conversion scripts before he pushes ;)
Thanks for the PR


Please edit docs/directory

the avax docs are a little off:
https://github.com/ava-labs/avash
This says "cd $GOPATH/src/github.com/ava-labs/avash"
But
go get github.com/ava-labs/avash
installs a diretory not named avash, it is named<EMAIL_ADDRESS>so it doesn't match the install docs.
Also the website says "An Avalanche Client Implementing Avalanche Standard CLI Flags", which sort of comes before the Quick Setup, and is sort of confusing 💘

On recent release of go, seems like modules are stored in pkg/mod instead of src


Change content-type header for POST requests from "text/plain;charset=UTF-8" to application/json

Describe the bug
If the request content type header is not set to application/json , common API frameworks like express with body-parser cannot parse it
To Reproduce
Steps to reproduce the behavior:

Set up CopilotTextArea
Send a request to an express server with body-parser middleware enabled [ really common for JSON ]
Try and parse the body with req.bod
req.body is empty

Expected behavior
I expect
Screenshots
If applicable, add screenshots to help explain your problem.
** Browser (please complete the following information):**

Universal

Additional context

Sending JSON as json is a standard convention, this could break not just Express but most other frameworks.

@ataibarkai I would like to work on this issue.

Great @iamtouha , let me know if you need any support

Certainly! Could you please specify which files I should be looking at to apply the changes.

Is this bug done?


Get error regeneratorRuntime is not defined

I try to create epub reader, and trying to make a new copy but still get error regeneratorRuntime is not defined on ReactViewer

and here my code

Ok. I'll check! 🙆♂

Ok. I'll check! 🙆♂

im glad to hear that, thank you

Same problem here on NextJS stack:
"next": "13.1.6",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-epub-viewer": "^0.2.0"

Ok. I'll check! 🙆♂

im glad to hear that, thank you

You can add
import "regenerator-runtime"
On your code and it's resolve for me!

I was too busy with what I was doing, so I couldn't check it.
Thanks for suggesting a way. We will review it soon! 🙂
@Nirator78

Got the same issue. Thanks for saving man


Feature: show the time a resource was locked in the slack message

When I run the /locks command in Slack I would love to see what time each resource was locked.

The reason I want this is I want an easier way to tell whether a lock is stale (and someone's forgotten to clean it up) or if it's been recently locked. Other features requested include notifications and I'd prefer that setup too! But this seemed like an easier improvement so thought I'd suggest it here too 😉

Nice idea @RaniSputnik


CB-10324: Add entitlement for EFS in CloudBreak

Add entitlement CDP_DATA_LAKE_AWS_EFS in CloudBreak, so we can hide the EFS related code before it is fully functional.
This is blocked by https://github.infra.cloudera.com/thunderhead/thunderhead/pull/3031, which should be committed first, then commit this change.

Do you have a counterpart entitlement in the thunderhead as well?

Yes. It is in https://jira.cloudera.com/browse/ALTCORE-3497, already committed. Its code review is at https://github.infra.cloudera.com/thunderhead/thunderhead/pull/3031


generate i18n error code

[ ] create a formalised spec to represent errors and make sure they integrate properly with errors.Is, errors.As
[ ] ensure appropriate use of wrapping is implemented
[ ] create error code generator

As a general rule when receiving errors from called functions, make sure you add contextual information by wrapping, either by wrapf function or by using %w inside format string

The reason why I've been having so many problems with go-i18n is because of the poor design of go-i18n, which depends on the code always importing "github.com/nicksnyder/go-i18n/v2/i18n", which is really stupid. All code with extractable content MUST import directly from nicksnyder/go-i18n/v2/i18n.
To avoid namespace clashes, we'll name local localisation folders locales instead of i18n. Unfortunately we have to accept that i18n is reserved for go-i18n because of the issue recently discovered.
See:

best practices - logrocket

created ginkgo snippet:

$1: the core name of the error (should not include Err or Error in its name)

  "Ginko Variable Native Error": {
    "scope": "go",
    "prefix": "gverrt",
    "body": [
      "Context(\"$1 error\", func() {",
      "  When(\"given: matching error\", func() {",
      "    It(\"🧪 should: affirm\", func() {",
      "      err := core.New$1Error(\"bar\")",
      "      Expect(",
      "        core.Is$1Error(err),",
      "      ).To(BeTrue(),",
      "        \"error does not match $1\",",
      "      )",
      "    })",
      "  })",
      "",
      "  When(\"given: non matching error\", func() {",
      "    It(\"🧪 should: reject\", func() {",
      "      err := errors.New(\"fake\")",
      "      Expect(",
      "        core.Is$1Error(err),",
      "      ).To(BeFalse(),",
      "        \"not matching error should not match $1\",",
      "      )",
      "    })",
      "  })",
      "})",
      "",
    ],
  },


Replace string literals with #selector

Just something that bugged me in build logs ;)

Thanks for helping @VladislavJevremovic :)

Ah, welcome! I've got a few more ideas/submissions... once I get a spot of time to spare 😉


Is there anyway of interacting with the poll stickers?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I know there is an api that can read users story. I am just wondering if it is possible to interact with the stickers like poll sticker.
Describe the solution you'd like
A clear and concise description of what you want to happen.
An api would be nice
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

It's not possible

But I've seen bots like stellation media have this kind of feature


Popover - fix error when content or title is a number

Due to @cvrebert comment (https://github.com/twbs/bootstrap/pull/20210#issuecomment-229783242) convert content and title to string
Close #20193

I don't think it's the right fix. What you are doing is preemptively converting the data-title and data-content to string, effectively you are bypassing the checks done in Util.typeCheckConfig.
I think that checks were put in place for a reason (I guess controlling the content to avoid XSS).
Moreover the data-title and data-content can be an element or a function and you are converting it to a string.
I think what @cvrebert meant in this comment was to consider the title and content as a string when you add them to the popover/tooltip not preemptively before the check. But that's not possible as the check is done before that.
The proper fix is to merge PR #20210 for the data-content of the popover and apply the same fix for the data-title in the tooltip (and add unit test that are not present in #20210)

Moreover the data-title and data-content can be an element or a function and you are converting it to a string.

That's not true, I only convert when it's a number that's all.
Moreover same is already done for delay

The delay is not converted:
if (config.delay && typeof config.delay === 'number') {
    config.delay = {
        show : config.delay,
        hide : config.delay
     }
}

The delay can be an object with show/hide or a single number. This code handle the second case (a single number meaning both show and hide are the same).  No conversion here and the original parameter still goes through Util.typeCheckConfig.

For me it's a conversion but that's not the subject here.
Thank you for your feedbacks 👍

if config.delay is a string then config.delay.show will also be a string and will fail in Util.typeCheckConfig as intended. What I meant by 'not a conversion' is that is doesn't change the type. You code change the type by doing toString().

At the beginning config.delay is a Number and at the end config.delay is an Object that's why I said it's a conversion.

Actually I think the code regarding the delay, should be done after the call to Util.typeCheckConfig otherwise it defeat the purpose of the check and let the user pass any type as the delay.
Basically we shouldn't change the config before checking it.

It's a point of view but, we only accept string, element and function for title and content so if it's not a string we convert the argument.
About delay to be compliant with documentation we have to perform the conversion.

Delay showing and hiding the tooltip (ms) - does not apply to manual trigger type
If a number is supplied, delay is applied to both hide/show
Object structure is: delay: { "show": 500, "hide": 100 }

For me they are not a better point of view than an other, your point of view is equal to mine but a path have been chosen that's all.


Testing: prepare to merge go_test.sh with the one in Piper

Description
Just bringing in cl/617512759 from Piper, potentially in preparation for merging this script with the one in Piper.
Related issue

How has this been tested?

Checklist:

Unit tests

[ ] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[ ] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

I'd prefer something like "if value in array", but with only 2 values, I don't care too much.

sorry, forgot to respond to this, but i'm not sure how to do this in bash without defining a special function just for this and it didn't sem worth it.


IN vs. INOUT

It appears that setting the intent to IN is pretty unpredictable and has shown to change the input variable randomly (very VERY BAD). INOUT is actually pass by reference, which does not appear to show this behaviour. So change ALL INs to INOUT...

I'm not too sure if this is true. There's a lot of sketchy coding going on here because I'm not entirely certain what version of Fortran I should be writing in to be compatible with LS-DYNA.


New Architecture<EMAIL_ADDRESS>incompatible (android only)

react-native:0.74.5 newArchEnabled=true
react-native-collapsible-tab-view:6.2.1 | 8.0.0
react-native-pager-view:6.3.4
<Tab.FlatList/> no render
like this:

If this library is replaced with<EMAIL_ADDRESS>it can be displayed normally
this is my code：

This patch fixes it
https://github.com/mozzius/graysky/blob/4435189b1e3a992133fed287bc46397992649153/patches/react-native-collapsible-tab-view.patch

@mozzius Thank you for solving my problem

why is this closed? issue isn't fixed in lib

this needs to be merged to be fixed


Emit 'error' event if no job servers are available

If all servers fail, an event should be emitted on job object.

hi Tommaso,
the problem is already emitted on Client in the method _getJobServer. I suppose it makes more sense to emit such error on the client than on a job.
what do you mean?

Some example will explain better the problem:
client = gearmanode.client({
  host: '<IP_ADDRESS>',
  port: 4730,
});
var job = client.submitJob('queue', 'workload', {background: true});
job.on('submitted', function() {
  console.log('This job is submitted  correctly!');
});
job.on('error', function() {
  console.log('This job is not submitted correctly');
  // application logic to handle the error
 // for example redo the submitJob with another client
});

It is correct to emit the error on client as you said, but i would like the job notified too, otherwise the listener will be pending and never invoked.


Support more parameter types in COM interface declarations

Motivation
COM interface declaration support was initially added in #1540. Currently it only supports parameters of pointer type which can be passed through the FFI boundary.
For example, the following fails:
#[interface("00000000-0000-0000-0000-000000000000")]
unsafe trait ITest: IUnknown {
    fn SetFoo(&self, i: i32) -> HRESULT;
}

This should support more parameter types, including primitive types and common Windows API types which can also be passed through based on something like AbiTransferable in com-rs.
(Naturally this is all a very recent addition, still under development and not expected to be working yet -- submitting this for tracking purposes. Thank you!)

Yep, that was only the start. I hope to support the same type-system as the rest of the windows crate supports.

A few initial issues with the interface macro that I'm working through:

The interface macro only lets you write methods with a single parameter. That's obviously an issue. 😉
The interface will fail if the implement feature is not enabled - it makes invalid cross-feature dependencies. It should not need the implement feature at first glance, but it may be simpler to combine them...

#1486 was re-opened, so closing this in favor of that issue. Thank you for the efforts!

Improvements to the interface macro are now published as part of 0.34.0.


Update README.md FAQ link

The FAQ link returns 404:
curl -I https://backstage.io/docs/FAQ
HTTP/2 404

It does redirect to a working page, but intermediately shows a Page Not Found error.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation

Is anyone able to review, please?


Feature: Adding noninteractive mode

adding noninteractive flag to use first commit message retrieved from openai to avoid user interaction

Would it be a good idea to print the commit to the terminal after automatically accepting it?

Thanks! waiting for this to be released

Has there been any word on whether or not this will be merged? It's definitely something that I would love to have, both for non-critical private repos, and for giving AI powered git commits a proper trial run, eg. to see how good (or bad) it actually is in the long run, if you simply allow it to control all commit messages with no manual intervention.

PR looks good! Would you mind adding a quick test?

I hope this can be released soon!

PR looks good! Would you mind adding a quick test?

Test is added!

Please merge this @Nutlope 🙏

This is a very useful, two people already worked on it and both are well implemented, I talked about this on #216, and there is another PR ready to be reviewed #249

👋🏼 To everyone here.
I've made a version of this repo that also includes the abiity to set a config to auto-confirm=true, among other stuff, as
this repo seems to be abandoned, which i completly respect.
@nthings : Feel free to open a PR with the --noninteractive flag if you like 😄

New version: https://github.com/negoziator/ai-commit


Chore: use probot/stale

I agree with this, though considering it's a relatively small project 60 days might be too aggressive?

Double it to 120?


Allow PrimaryValues to be a collection of custom objects

Use-case is the same as in https://github.com/beto-rodriguez/Live-Charts/issues/67#issuecomment-171952572: realtime display of sensor values.
So a whole bunch of data is read regularly and needs to be displayed distributed among multiple plots with multiple series each.
Both for performance reasons and regarding code duplication (1 ObservableCollection property in my viewmodel for each single series to display) it would be good if one could just bind PrimaryValues of multiple Series objects to the same collection of custom objects and then use another property to define which property of that custom object to use, similar to OxyPlot I think.

When I started writing this library, I actually wanted to implelemt this, but I had some issues, now that we have more contributors we can try to solve it.
If I am correct, what you are saying is that instead of ObservableCollection<double> we use ObservableCollection<MyModel> and then specify which property to plot maybe Func<MyModel,double> would work, similar to what entityframework does, please correct me if I am wrong.

Yeah like they do here: https://github.com/oxyplot/oxyplot/blob/develop/Source/Examples/WPF/WpfExamples/Examples/BindingObservableCollectionDemo/MainWindow.xaml
ItemsSource="{Binding Measurements}" DataFieldX="Time" DataFieldY="Value"
For this scenario I even have such a class/struct with measurements already. Just the time is "missing" and could/would or might even need to stay separate.

@Trass3r In oxyplot they make an ugly implementation (in my opinion), from https://github.com/oxyplot/oxyplot/blob/develop/Source/Examples/WPF/WpfExamples/Examples/BarSeriesDemo/MainWindow.xaml.cs#L47
ValueField property is string, that means that ItemsSource might be an ObservableCollection<object> and then they might use reflection to get the desired property, this might have serious performance issues, becuase they first box/unbox the object, and then they use reflection which could be 1,000 times slower than accesing a normal property. I really think that is not the way, In my opinion we should use generics ObservableCollection<T> where T : class, I wish everything were beautiful about generics, but from msdn docs (see note at bottom) we should need a little bit more of code.
So I see 2 options
1) Use Oxyplot implementation.
Pros:

Clean markup

Cons

Performance, in this issue we are tying to fix a performance issue and this solution will lead to a new issue then.

2) Use Generics
Pros

Performance

Cons

Will need more setup. for example instead of

<liveCharts:SeriesCollection>
    <liveCharts:LineSeries PrimaryValues="{Binding}" />
    <liveCharts:LineSeries PrimaryValues="{Binding}" />
</liveCharts:SeriesCollection>

you will need
<liveCharts:SeriesCollection>
    <MyClassSeries PrimaryValues="{Binding}" />
    <MyClassSeries PrimaryValues="{Binding}" />
</liveCharts:SeriesCollection>

Where MyClassSeries could be
public class MyClassSeries : Series<MyClass>
{
}

I'll need to think a bit about this. At least simple cases need to stay simple. You wouldn't wanna have to create a custom class just to plot some double values. But in special cases like realtime data it is acceptable to write more code for better performance.
Regarding the boilerplate code aspect this MySeries class approach doesn't seem to work out as-is.
It also needs constructors and in the end you have to create one boilerplate class per series again just to 'unpack' the object. Maybe one could use something like this to get around that: http://joyfulwpf.blogspot.ch/2009/10/using-lambda-expression-in-xaml.html
I'm not sure to which extent specifying the type parameters in xaml is supported, apparently some things changed with .NET v4 at least: https://msdn.microsoft.com/en-us/library/ee956431.aspx

I am working on it, I think I got a an idea, let me test how it works, and I will publisg as soon as possible. This will again be a big update and change an important part of the code, Thank you for your requests they are helping alot.

OK right now this is almost finished, but before I apply it to all the code I would like to know your opinion @Trass3r @gregsdennis, the problem is that syntax changed drastically but it has too many benefits like readability, performance, it should also help to build a “more Mvvm app”, it will also make live charts more stable and scalable for example #33 will be practically fixed then this is done.
Now you don’t plot an ObservableCollection<double> now you plot ChartValues<T> where T is anything you want by default it is initialized as double, but you can make it anything you need, it has no constraints, ChartValues<T> class is a smart collection specialized for live charts, it should improve performance a lot.
I implemented many interfaces to avoid Generics in XAML, this should keep XAML syntax practically the same with some exceptions, for example Labels property will disappear and you will need to map it from T. Here is a preview of the new syntax, I really like it but I would like your opinion.
var series = new SeriesCollection
            {
                new LineSeries(),
                new LineSeries(),
                new LineSeries()
            }.For(new SeriesConfiguration<WeatherDay>()
                .X((day, index) => index) //use a zero based index for x
                .Y(day => day.Temperature) // use temperature property for Y
                .XLabel(day => day.DateTime.ToShortTimeString()) // format Date Property as label
                .YLabel(day => day.Temperature + " °")); // format Temperature Property as label

WeatherDay is the object that in this case a user is ploting the weather temperature and its date
public class WeatherDay
    {
        public DateTime DateTime { get; set; }
        public double Temperature { get; set; }
    }

Thanks

I can look tonight...

will try it tomorrow

this is solved with multiple commits, I will close it now and update docs as soon as possible

Hmm I don't see yet how I can show multiple series using different data from the same structure.
The MvvmLine example contains a SalesData class with multiple data entries but only 1 of them is used.

Using series with diferent data structure?, the code was actually working like this but it was hard to setup because instead of
SalesmenSeries = new SeriesCollection
            {
                new LineSeries(),
                new LineSeries(),
                new LineSeries(),
            }.Setup(new SeriesConfiguration<SalesData>().Y(x => x.ItemsSold));

you would need
SalesmenSeries = new SeriesCollection
            {
                new LineSeries().Setup(new SeriesConfiguration<SalesData>().Y(x => x.ItemsSold)),
                new LineSeries().Setup(new SeriesConfiguration<SalesData>().Y(x => x.ItemsSold)),
                new LineSeries()..Setup(new SeriesConfiguration<SalesData>().Y(x => x.ItemsSold))
             }
            };

I think that you normally would need to plot the same structure, but it is true that it would be necessary to include one serie with another data structure, So I will add a SeriesConfiguration property to Series class too,
Then SeriesConfiguration class will be pulled something like this
var config = Series.SeriesConfiguration ?? SeriesCollection.SeriesConfiguration;

What I'm trying to do is using a sampling structure like
struct Sample {
    double time;
    double v1;
    double v2;
    double v3;
    double v4;
}
ChartValues<Sample> foo;
...

Also facing general issues:

BarChart does not show tooltip and even crashes at some point in lvc.Charts.Chart.TooltipTimerOnTick
ChartValues could provide ObservableCollection's constructors
also getting crashes with LineSeries: "'n. def.' is not a valid value for property 'Y1'."

 I keep testing today. I ulpedated my last comment please see and let me know If I got your point

Yeah I think that should work, Series also having a config and a fallback to the collection.

this should sovle this issue, I keep working on examples to show an examlpe

The TooltipTimerOnTick crash also happens with LineChart. And the axis crash.

Everything is working fine for me, please clone this repo and see all the changes, there are too many changes but it is worth, if you keep having troubles then please let me know more about the error.

also consider reading https://github.com/beto-rodriguez/Live-Charts/releases/tag/0.6.0

I read this, but I think in mvvm Series shouldn't be a FrameElement, use template maybe better.

The command is always async but you could not access it in another thread.

@AuroraDysis I just commited better examples, only in line chart for now, I will update Readme, please see new line examples they will help you


Formatting JSON in preview isn't working

Preflight Checklist

[x] I have installed the latest version of Storage Explorer.
[x] I have checked existing resources, including the troubleshooting guide and the release notes.
[x] I have searched for similar issues.

Storage Explorer Version
1.36.0
Regression From
1.35
Architecture
x64
Storage Explorer Build Number
20241012.1
Platform
All
OS Version
Windows 11
Bug Description
Formatting json files no longer works, it changes but then reverts back to unformatted json.
Steps to Reproduce

Launch storage explorer
Open blob storage container
Preview unformatted json file
right-click select "Format JSON"
Close just opened tab

Actual Experience
When selecting the "Format JSON" option, the formatted json is displayed for a brief moment, before reverting back to unformatted json.
Expected Experience
I would expect the formatted json to be displayed.
Additional Context
No response

@houlgap Just to get some details, how long is this brief moment? I assume this happens for every JSON file you try? Do you have app logs you can share?

@houlgap Sensitive information is redacted automatically from the logs, so you can share them safely here. If you're still concerned, you can share them privately by sending them to sehelp at microsoft dot com.

I am also able to reproduce this. I've also noticed the "Format JSON" command does not change to "Restore JSON", so something is causing it to revert back immediately.

See trace logs attached
StorageExplorerLogs.zip

Problem seems to have started after commit 2711461 when tab lifecycle was introduced. No idea why this would affect the Monaco editor....

We've discovered the problem. Code that sets up the <webview> element is run in the update method of a custom Knockout binding. Formatting JSON modifies the display name of the tab. Since the display name of the tab is an observable, the update method runs again, which means the setup code is run again, ultimately creating a new <webview> renderer process. This is why the JSON appears to reset almost immediately and why a crash happens when trying to close the tab.


Homebrew does not close properly with Aroma

Homebrew does not close properly with Aroma.
According to a Discord post from Maschell:

Launch homebrew XYZ is crashing when exiting:
Not all homebrew are fully compatible with Aroma yet. Older homebrew often didn't implement the ProcUI loop properly, which leads to some issues now.

New interesting article on this topic: Why some homebrew apps are incompatible with Aroma and how to fix them

Fix by PR #20.


[SYSTEMML-776] Upgrade Spark version

Updated Spark version.

All tests passed at https://sparktc.ibmcloud.com/jenkins/job/SystemML-OnDemand/233/.

LGTM
Do we need to create artifacts with Spark version going forward? May be separate thread we can have discussion on.

Thank you Arvind for reviewing!

Tests in progress:
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1021/


[<IP_ADDRESS>] Power Button does not turn off the screen, instead functions as a second Back Button

In an older version (I believe 1.4.x, but I'm not sure) the power button would turn the screen off. This was useful as it was a quick way to reduce CPU time to 0.1% or lower, if I wanted to do something else without closing Leapdroid. Very good for multitasking.
Now, it performs the same functionality as the back button.  The back button itself behaves normally.

Fixed. Will be in the next release.


What's the state of custom templates?

Hi there :wave:
We were talking about that before, but didn't remember where it was and what issues there had. But didn't follow what's up for awhile, so directly asking: how can we customize the templates of the generators, can we? Where to place them, in what structure?
I have personal streaming scaffolder, which is enough in most cases, but probably i want to start using Generate and i can't until i can customize the templates, because don't want to stick to the default ones. With verb it's easy, because it's just an option "layout": "empty", so that's why integrated it and using it for last year (or probably more; we waiting v0.9 finally ;p).
I'm going through very big changes around my profile and packages, so whole month i'll update all of my ~350 packages and will move most of them to @tunnckoCore organization. I want to unify everything.

We've been using them since the beginning. I think there was a bug with nvm that was resolved.
I'm pretty sure you can add templates to the ~/templates directory. Dotfile templates are prefixed with _, like _gitignore, to prevent them from being confused with real dotfiles. The goal was to make the directory customizable. We might have enabled that already, sorry I haven't had a chance to check and I don't remember if I actually published the code to do that.

Hm. Yea it was something like that, really.
As about the place of ~/templates, I believe that we discussed that too and was thinking to be 1) hidden or inside the ~/.data-store. (btw not to mention that someone makes .date-store too ;d).
But beside that fact that i probably should ignore, what should be the structure of that folder? Is it something like below?
templates/
- generate-package/templates/
- generate-project/templates/
- generate-git/templates/


:sparkles: add getWilayaByCode

Description
Add getWilayaByCode method that gets a wilaya code as a parameter and returns the matching wilaya.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Updated the dataset

Checklist:

[x] I checked that there's no dataset update (can be done by running npm run update-dataset)
[x] npm test passes on my machine
[x] npm run lint passes on my machine

@all-contributors add @oussamabouchikhi for code


Signup command

Allows player to signup with an emoji

also make it add signed up role

Ok done for now


Obsolete code

Hello!
I was taking a look at the codes in the next link:    [  https://elixir-examples.github.io   ]
And I realized that some of them are obolsete. For example:
https://elixir-examples.github.io/examples/strip-trim-leading-and-trailing-whitespace-from-a-string
saids :
"a" = String.strip("    a     ")
And it should be
"a" = String.trim("    a   ")
Im using elixir 1.5.2
Regards! If I happen to find more I'll tell you, thank you

Thanks for reporting this. It is now fixed:
https://elixir-examples.github.io/examples/strip-trim-leading-and-trailing-whitespace-from-a-string


[ada mode] Add

Hi. We're no longer accepting new modes into the main distribution. The recommended way to distribute new modes is to maintain them in their own repository and publish them to NPM as separate packages—see for example the Elixir mode.


Add version to support Rails <IP_ADDRESS>

Not merging to head, as we keep making these for every minor rails patch.


singleGroups forbids grouping unary operations

The binding power of unary operations is not considered when singleGroups is enabled. For example, the grouping operator in the following expression has a substantive effect on the expression, but JSHint considers is unnecessary:
(-3).toString();

Patch incoming!

A fix for this has been merged and will be in the next release after the current 2.8.0


info on parameters

describe how some of the variables in the bash script are used and under which conditions.

Summary by CodeRabbit

Documentation

Enhanced instructions in the README for handling envFile and creating a conda environment, improving clarity on environment setup.

@coderabbitai full review


NTR: myocyte reprogramming involved in skeletal muscle regeneration

Please provide as much information as you can:
myocyte reprogramming involved in skeletal muscle regeneration

Definition (free text)
The process during skeletal muscle regeneration whereby myocytes loose their Z-band architecture and become,  mesenchymal, re-enter the cell cycle, then proliferate.

Reference, in format PMID:#######
PMID:32320444

Gene product name and ID to be annotated to this term
twist3     ZDB-GENE-000210-7

Parent term(s)
GO:0043403 skeletal muscle tissue regeneration

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)
myocyte dedifferentiation narrow

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

**Any other information
Cell reprograming is a normal part of fish biology.  Fish naturally regenerate almost every tissue and frequently have mature fully differentiated cells become less differentiated and proliferate instead of relying on stem cells.

What is the status of this ticket?  Can this ticket be reviewed by someone?

Hi @cerivs
Sorry about the late reply! We dont create procomposed terms anymore, we recommend people annotate these as GO-CAMs as for example 'myocyte reprogramming' part of 'skeletal muscle regeneration'
Does that work for you ?
Thanks, Pascale

@cerivs
You should be able to capture this in GO-CAM without the precomposed term. Please let me know if you need help making the model.
Thanks, Pascale


Hitting the refresh button causes "NoteHost: Page Not found (404)."

Hitting the refresh button on any sub-page causes "NoteHost: Page Not found (404)."

Adding a slugToPage entry fixes the problem, however the pages that do not have it always yield 404

Any idea how to resolve this?

I am a bit confused. If you don't have a slug to page defined for a specific route, the default behavior is to show the 404 page. What do you expect should happen?

Let me clarify. This is a notion page that is accessible and loads correctly on first load via a link on the root. The specific problem occurs only after hitting the refresh button on an already loaded page.
Steps to reproduce:

Setup Notehost with a single slugToPage which points to the notion page ID of the home page and deploy.
Embed a second page on that home page. Let's call it page "X"
Open your page via the domain and then follow the link to navigate to page "X". Should load ok.
Press refresh button. This is where I see "NoteHost: Page Not found (404)." and this replicates consistently.

I've made a few changes that should address this issue.
Can you please test it with the latest version of notehost?


updates to parametric demo files

Pull Request Test Coverage Report for Build 100

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.463%

Totals

Change from base Build 98:
0.0%

Covered Lines:
2011

Relevant Lines:
2854

💛  - Coveralls


Test this works on linux

Is your enhancement related to a problem? Please describe
It should work on linux
Describe the solution you'd like
working on linux
Describe alternatives you've considered
No response
Additional context
No response

At the moment we are blocked on two issues:
https://github.com/containers/podman-desktop/issues/2861 which involves not being able to run rootful containers on linux systems.
and
https://github.com/osbuild/bootc-image-builder/issues/98 which doesn't allow building containers on a rootless container.
We'd have to fix one of the issues to get this functionality to work on linux.
You can perform the build no problem via CLI with sudo, but we are unable to perform the build through podman desktop at the moment.

We can now create root podman machines on Linux on Podman Desktop: https://github.com/containers/podman-desktop/issues/5823
So we can use bootc-image-builder on Linux now.
We however, must have documentation / ample notifications indicating that you need a rootful Linux machine to do this.

I think documenting the requirement for a rootful machine is OK at this time.

Documenting the requirements sounds good to me.  The extension could also throw a warning if the machine runs rootless.

@cdrage I don't see that the requirement on running as root inside the machine has been addressed with #186.  Am I missing something?

@cdrage I don't see that the requirement on running as root inside the machine has been addressed with #186. Am I missing something?

It's been added to the readme: https://github.com/containers/podman-desktop-extension-bootc?tab=readme-ov-file#requirement-2-rootful-mode-on-podman-machine
It was always there, but now we just added the "works on Linux" part / you must create a Linux machine.

Created https://github.com/containers/podman-desktop-extension-bootc/pull/187 to add more detail regarding Linux support, as you are right however, there is limited information in the docs / requirements that were missing.


Rendering long pages into multiple ones bug

If we have one long page to render into multiple A4 pages, then we get the following:

New to this version

Closed by using.
tr {
  page-break-inside: avoid;
 }


Add plot_ppc

Until explicit indexes are supported it won’t be possible to have the groupby like behaviour

I also propose to completely get rid of the "mean" line. Nobody understands what it actually means and there are many cases where it's range is much larger than each individual sample ending up in very strange/ugly plots.

Can we keep it, and make it default to False?

maybe if we rename the argument and legend entry?

what name(s) do you have in mind?

I think we should avoid the word "mean" because it makes people think about the mean of the posterior predictive. "combined" seems to be more intuitive in plot_trace, but here we combine over samples instead of over chain only, "aggregate" might also help with avoiding relating that to the actual mean.

Aggregate can be a good choice

Plot_ppc support for discrete values might have to be thought of as well: https://github.com/arviz-devs/arviz/issues/1103

Some more plot_ppc related issues with legacy Arviz plot_ppc:
A bug when zooming in:
https://github.com/arviz-devs/arviz/issues/1756
A feature request for adding HDI-style credible intervals for plot_ppc:
https://github.com/arviz-devs/arviz/issues/1654

Plot_ppc support for discrete values might have to be thought of as well: https://github.com/arviz-devs/arviz/issues/1103

Discussion related to better support for discrete values should go to #53.


Generalizing Django-Todo using settings.AUTH_USER_MODEL + small bug fix

Hi Scott,
It is fun using the Django-Todo program!  Please review my suggested changes.
Thanks,
              -Shanti

Ouch!
Will do!   Sorry about that.  I was messing with it as part of finding out
some issues.   Please stay tuned....
Thanks,
Best Regards,
                    -Shanti

On Thu, Dec 1, 2016 at 1:24 AM, Scot Hacker<EMAIL_ADDRESS>wrote:

@shacker commented on this pull request.
In todo/init.py
https://github.com/shacker/django-todo/pull/32#pullrequestreview-10907577
:

@@ -1,10 +0,0 @@
-"""

Oops - you've accidentally wiped out the init.py - I can no longer
install the app. Please restore this file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shacker/django-todo/pull/32#pullrequestreview-10907577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMRtTFVXTylxL7FK0jN-SlgDDZpb-O7Vks5rDmgXgaJpZM4LAt03
.

Hi Scot,
I have restored init.py.  Please check.
Thanks,
              -Shanti

Thanks for restoring the init . All looks good. Thanks for your contribution!


Getting OpenCl to run with new distrocl

I can run neural-style fine with cpu but trying to run opencl fails. Using a 8gb amd card. I'm fairly new to Ubuntu, but my best guess is that the new way of installing cltorch and clnn through distro-cl is not getting picked up correctly. I passed all the tests without errors running install tests for cltorch
source ~/torch-cl/install/bin/torch-activate luajit -l torch -e 'torch.test()' luajit -l nn -e 'nn.test()' luajit -l cltorch -e 'cltorch.test()' luajit -l clnn -e 'clnn.test()
Here is what i get when I run the neural-style opencl example
zed@zed-desktop:~/neural-style$ th neural_style.lua -style_image examples/inputs/picasso_selfport1907.jpg -content_image examples/inputs/brad_pitt.jpg -output_image profile.png -model_file models/nin_imagenet_conv.caffemodel -proto_file models/train_val.prototxt -gpu 0 -backend clnn -num_iterations 1000 -seed 123 -content_layers relu0,relu3,relu7,relu12 -style_layers relu0,relu3,relu7,relu12 -content_weight 10 -style_weight 1000 -image_size 512 -optimizer adam
libthclnn_searchpath	/home/zed/torch-cl/install/lib/lua/5.1/libTHCLNN.so
Successfully loaded models/nin_imagenet_conv.caffemodel
MODULE data UNDEFINED
warning: module 'data [type 5]' not found
conv1: 96 3 11 11
cccp1: 96 96 1 1
cccp2: 96 96 1 1
conv2: 256 96 5 5
cccp3: 256 256 1 1
cccp4: 256 256 1 1
conv3: 384 256 3 3
cccp5: 384 384 1 1
cccp6: 384 384 1 1
conv4-1024: 1024 384 3 3
cccp7-1024: 1024 1024 1 1
cccp8-1024: 1000 1024 1 1
Using Advanced Micro Devices, Inc. , OpenCL platform: AMD Accelerated Parallel Processing
Using OpenCL device: Hawaii
Setting up content layer	2	:	relu0
Setting up style layer  	2	:	relu0
WARNING: Skipping content loss
Setting up content layer	9	:	relu3
THClReduceAll.cl build log:
"/tmp/OCL24627T10.cl", line 51: warning: function "IndexToOffset_999_get" was
declared but never referenced
static inline unsigned int IndexToOffset_999_get(unsigned int linearId, global const TensorInfoCl *info) {
^
"/tmp/OCL24627T10.cl", line 66: warning: function "getLinearBlockId" was
declared but never referenced
static inline unsigned int getLinearBlockId() {
^
THClReduceAll.cl build log:
"/tmp/OCL24627T11.cl", line 9: warning: variable "in1" was declared but never
referenced
float *in1 = &_in1;
^
"/tmp/OCL24627T11.cl", line 10: warning: variable "out" was declared but never
referenced
float *out = &_out;
^
"/tmp/OCL24627T11.cl", line 51: warning: function "IndexToOffset_999_get" was
declared but never referenced
static inline unsigned int IndexToOffset_999_get(unsigned int linearId, global const TensorInfoCl *info) {
^
"/tmp/OCL24627T11.cl", line 66: warning: function "getLinearBlockId" was
declared but never referenced
static inline unsigned int getLinearBlockId() {
^
Setting up style layer  	9	:	relu3
WARNING: Skipping content loss
Setting up content layer	16	:	relu7
Setting up style layer  	16	:	relu7
WARNING: Skipping content loss
Setting up content layer	28	:	relu12
Setting up style layer  	28	:	relu12
WARNING: Skipping content loss
Running optimization with ADAM
/home/zed/torch/install/bin/luajit: /home/zed/torch/install/share/lua/5.1/nn/Container.lua:67:
In 34 module of nn.Sequential:
/home/zed/torch/install/share/lua/5.1/nn/THNN.lua:109: bad argument #8 to 'v' (cannot convert 'number' to 'struct THClTensor *')
stack traceback:
[C]: in function 'v'
/home/zed/torch/install/share/lua/5.1/nn/THNN.lua:109: in function 'SpatialConvolutionMM_updateGradInput'
...ed/torch/install/share/lua/5.1/nn/SpatialConvolution.lua:133: in function <...ed/torch/install/share/lua/5.1/nn/SpatialConvolution.lua:127>
[C]: in function 'xpcall'
/home/zed/torch/install/share/lua/5.1/nn/Container.lua:63: in function 'rethrowErrors'
/home/zed/torch/install/share/lua/5.1/nn/Sequential.lua:55: in function 'updateGradInput'
neural_style.lua:320: in function 'opfunc'
/home/zed/torch/install/share/lua/5.1/optim/adam.lua:33: in function 'adam'
neural_style.lua:343: in function 'main'
neural_style.lua:500: in main chunk
[C]: in function 'dofile'
.../zed/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x00406670
WARNING: If you see a stack trace below, it doesn't point to the place where this error occured. Please use only the one above.
stack traceback:
[C]: in function 'error'
/home/zed/torch/install/share/lua/5.1/nn/Container.lua:67: in function 'rethrowErrors'
/home/zed/torch/install/share/lua/5.1/nn/Sequential.lua:55: in function 'updateGradInput'
neural_style.lua:320: in function 'opfunc'
/home/zed/torch/install/share/lua/5.1/optim/adam.lua:33: in function 'adam'
neural_style.lua:343: in function 'main'
neural_style.lua:500: in main chunk
[C]: in function 'dofile'
.../zed/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x00406670
Since the new cltorch install uses its own distribution of torch there might be an issue there but might just be my install. Any help would be appreciated.

You don't need to use distro-cl; if you already have torch installed and working on CPU then you should be able to install cltorch and clnn with luarocks:
luarocks install cltorch
luarocks install clnn

luarocks install cltorch
luarocks install clnn

From what I can tell these seem to be disabled
they failed when I tried them on a different ubuntu install.

What is the error message?

zed@zed-desktop:~/neural-style$ luarocks install cltorch
Installing https://raw.githubusercontent.com/torch/rocks/master/cltorch-scm-1.rockspec...
Using https://raw.githubusercontent.com/torch/rocks/master/cltorch-scm-1.rockspec... switching to 'build' mode
Cloning into 'cltorch'...
remote: Counting objects: 123, done.
remote: Compressing objects: 100% (118/118), done.
remote: Total 123 (delta 10), reused 32 (delta 2), pack-reused 0
Receiving objects: 100% (123/123), 213.23 KiB | 0 bytes/s, done.
Resolving deltas: 100% (10/10), done.
Checking connectivity... done.
git clone --recursive git://github.com/hughperkins/cltorch.git && cd cltorch && cmake -E make_directory build && cd build && cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_PREFIX_PATH="/home/zed/torch/install/bin/.." -DCMAKE_INSTALL_PREFIX="/home/zed/torch/install/lib/luarocks/rocks/cltorch/scm-1" && make -j$(getconf _NPROCESSORS_ONLN) install
Cloning into 'cltorch'...
remote: Counting objects: 4827, done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 4827 (delta 5), reused 0 (delta 0), pack-reused 4810
Receiving objects: 100% (4827/4827), 1.01 MiB | 1.74 MiB/s, done.
Resolving deltas: 100% (3327/3327), done.
Checking connectivity... done.
Submodule 'src/EasyCL' (https://github.com/hughperkins/EasyCL.git) registered for path 'src/EasyCL'
Submodule 'src/clMathLibraries/clBLAS' (https://github.com/hughperkins/clBLAS) registered for path 'src/clMathLibraries/clBLAS'
Cloning into 'src/EasyCL'...
remote: Counting objects: 1851, done.
remote: Total 1851 (delta 0), reused 0 (delta 0), pack-reused 1851
Receiving objects: 100% (1851/1851), 863.53 KiB | 1.67 MiB/s, done.
Resolving deltas: 100% (1219/1219), done.
Checking connectivity... done.
Submodule path 'src/EasyCL': checked out 'ef17a3e1b3d70b7ba89f94682500bc2d95ecb273'
Submodule 'thirdparty/clew' (https://github.com/hughperkins/clew.git) registered for path 'thirdparty/clew'
Cloning into 'thirdparty/clew'...
remote: Counting objects: 262, done.
remote: Total 262 (delta 0), reused 0 (delta 0), pack-reused 262
Receiving objects: 100% (262/262), 92.78 KiB | 0 bytes/s, done.
Resolving deltas: 100% (102/102), done.
Checking connectivity... done.
Submodule path 'src/EasyCL/thirdparty/clew': checked out 'ea11370417c1935e49f1f90e45089473334db824'
Cloning into 'src/clMathLibraries/clBLAS'...
remote: Counting objects: 3186, done.
remote: Total 3186 (delta 0), reused 0 (delta 0), pack-reused 3186
Receiving objects: 100% (3186/3186), 2.59 MiB | 2.55 MiB/s, done.
Resolving deltas: 100% (1979/1979), done.
Checking connectivity... done.
Submodule path 'src/clMathLibraries/clBLAS': checked out '6df2f999a80789efee3376e8fffeb26d891b464c'
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Torch7 in /home/zed/torch/install
git version 1.9.1
using git setting USE_GIT 1
Warning: Failed loading manifest for /home/zed/.luarocks/lib/luarocks/rocks: /home/zed/.luarocks/lib/luarocks/rocks/manifest: No such file or directory
CMAKE_PREFIX_PATH /home/zed/torch/install/bin/..
Warning: Failed loading manifest for /home/zed/.luarocks/lib/luarocks/rocks: /home/zed/.luarocks/lib/luarocks/rocks/manifest: No such file or directory
Installed rocks:
argcheck
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
cwrap
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
dok
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
env
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
fftw3
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
gnuplot
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
graph
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
graphicsmagick
1.scm-0 (installed) - /home/zed/torch/install/lib/luarocks/rocks
image
1.1.alpha-0 (installed) - /home/zed/torch/install/lib/luarocks/rocks
loadcaffe
1.0-0 (installed) - /home/zed/torch/install/lib/luarocks/rocks
lua-cjson
2.1devel-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
luaffi
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
luafilesystem
1.6.3-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
nn
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
nngraph
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
nnx
0.1-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
optim
1.0.5-0 (installed) - /home/zed/torch/install/lib/luarocks/rocks
paths
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
penlight
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
qtlua
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
qttorch
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
signal
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
sundown
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
sys
1.1-0 (installed) - /home/zed/torch/install/lib/luarocks/rocks
threads
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
torch
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
trepl
scm-1 (installed) - /home/zed/torch/install/lib/luarocks/rocks
xlua
1.0-0 (installed) - /home/zed/torch/install/lib/luarocks/rocks
CMake Error at CMakeLists.txt:41 (message):
Please install cltorch from https://github.com/hughperkins/distro-cl

-- Configuring incomplete, errors occurred!
See also "/tmp/luarocks_cltorch-scm-1-269/cltorch/cltorch/build/CMakeFiles/CMakeOutput.log".
Error: Build error: Failed building.

Hrm, I'm getting the same error. Something must have changed recently in cltorch; try opening an issue over at  https://github.com/hughperkins/cltorch.

Hmmmm, well, running from torch-cl seems to work ok for me?
ubuntu@peach:~/git/neural-style$ torch
torch-cl activated
ubuntu@peach:~/git/neural-style$ ./runcl.sh
libthclnn_searchpath	/home/ubuntu/torch-cl/install/lib/lua/5.1/libTHCLNN.so
Successfully loaded models/vgg_normalised.caffemodel
conv1_1: 64 3 3 3
conv1_2: 64 64 3 3
conv2_1: 128 64 3 3
conv2_2: 128 128 3 3
conv3_1: 256 128 3 3
conv3_2: 256 256 3 3
conv3_3: 256 256 3 3
conv3_4: 256 256 3 3
conv4_1: 512 256 3 3
conv4_2: 512 512 3 3
conv4_3: 512 512 3 3
conv4_4: 512 512 3 3
conv5_1: 512 512 3 3
conv5_2: 512 512 3 3
conv5_3: 512 512 3 3
conv5_4: 512 512 3 3
Using NVIDIA Corporation , OpenCL platform: NVIDIA CUDA
Using OpenCL device: GeForce 940M
Setting up style layer  	2	:	relu1_1
Replacing max pooling at layer 5 with average pooling
Setting up style layer  	7	:	relu2_1
Replacing max pooling at layer 10 with average pooling
Setting up style layer  	12	:	relu3_1
Replacing max pooling at layer 19 with average pooling
Setting up style layer  	21	:	relu4_1
Setting up content layer	23	:	relu4_2
Replacing max pooling at layer 28 with average pooling
Setting up style layer  	30	:	relu5_1
Running optimization with L-BFGS
<optim.lbfgs> 	creating recyclable direction/step/history buffers
Iteration 50 / 700
  Content 1 loss: 69249.922903
  Style 1 loss: 1.133451
  Style 2 loss: 0.243755
  Style 3 loss: 0.036350
  Style 4 loss: 0.002463
  Style 5 loss: 0.002799
  Total loss: 69251.341721

But yes, luarocks install cltorch and luarocks install clnn are not currently supported.  There were lots of changes with THNN, that were breaking cltorch every few days, which meant it spent more time being broken than not.  If you run from distro-cl, it should be stable, and just keep working.  Why it's not working for you though is unclear.  As you can see fro mthe above, it runs ok on my own distro-cl installation, which should ideally be identical to your own.

I'm running it like this:
ubuntu@peach:~/git/neural-style$ cat runcl.sh
#!/bin/bash

name=$1
source settings.sh

th neural_style.lua -style_image examples/inputs/picasso_selfport1907.jpg -content_image examples/inputs/brad_pitt.jpg -gpu 0 -output_image cl_$name.png -image_size $size -model_file models/vgg_normalised.caffemodel -num_iterations $its -save_iter $saveits -normalize_gradients -content_weight 50000 -style_weight 90000 -backend clnn -optimizer lbfgs -pooling avg -seed 123

ubuntu@peach:~/git/neural-style$ cat settings.sh
#!/bin/bash

#its=30000
its=700
saveits=50
size=200

ah, you're not running from torch-cl, look at your error message:
/home/zed/torch/install/bin/luajit: /home/zed/torch/install/share/lua/5.1/nn/Container.lua:67:

The path i nthe error message is /home/zed/torch, it should be /home/zed/torch-cl.  Can you try doing:
source ~/torch-cl/install/bin/torch-activate

th neural_style.lua -style_image examples/inputs/picasso_selfport1907.jpg -content_image examples/inputs/brad_pitt.jpg -output_image profile.png -model_file models/nin_imagenet_conv.caffemodel -proto_file models/train_val.prototxt -gpu 0 -backend clnn -num_iterations 1000 -seed 123 -content_layers relu0,relu3,relu7,relu12 -style_layers relu0,relu3,relu7,relu12 -content_weight 10 -style_weight 1000 -image_size 512 -optimizer adam

Ran
source ~/torch-cl/install/bin/torch-activate
th neural_style.lua -style_image examples/inputs/picasso_selfport1907.jpg -content_image examples/inputs/brad_pitt.jpg -output_image profile.png -model_file models/nin_imagenet_conv.caffemodel -proto_file models/train_val.prototxt -gpu 0 -backend clnn -num_iterations 1000 -seed 123 -content_layers relu0,relu3,relu7,relu12 -style_layers relu0,relu3,relu7,relu12 -content_weight 10 -style_weight 1000 -image_size 512 -optimizer adam
and got an error but realized it was because I had installed loadcaffe only into ~/torch and not ~/torch-cl
After installing loadcaffe in torch-cl it works now.
Thanks for the help @hughperkins  @jcjohnson !
Maybe an update to the readme with more instructions on setting up open-cl will up useful for others. This is amazingly fast now compared to cpu. Now i'm going to try to do it with an image sequence to  style videos.

Cool. awesome :-) maybe I will just add loadcaffe to distro-cl. It seems like it's a standard enough thing to simply add. Will ponder this. Thanks for figuring this out!

(added loadcaffe to distro-cl https://github.com/hughperkins/distro-cl/commit/66fda53343cf662d1a50da75eda94e2719bba968 )

Sorry if I write in closed topic, but i try opencl with torch-cl; any advice? ubuntu 14.04.04
goemon@asrock-linux:~/neural-style$ th neural_style.lua -style_image examples/inputs/picasso_selfport1907.jpg -content_image examples/inputs/brad_pitt.jpg -output_image profile.png -model_file models/nin_imagenet_conv.caffemodel -proto_file models/train_val.prototxt -gpu 0 -backend clnn -num_iterations 1000 -seed 123 -content_layers relu0,relu3,relu7,relu12 -style_layers relu0,relu3,relu7,relu12 -content_weight 10 -style_weight 1000 -image_size 512 -optimizer adam
libthclnn_searchpath	/home/goemon/torch-cl/install/lib/lua/5.2/libTHCLNN.so
Successfully loaded models/nin_imagenet_conv.caffemodel
MODULE data UNDEFINED
warning: module 'data [type 5]' not found
conv1: 96 3 11 11
cccp1: 96 96 1 1
cccp2: 96 96 1 1
conv2: 256 96 5 5
cccp3: 256 256 1 1
cccp4: 256 256 1 1
conv3: 384 256 3 3
cccp5: 384 384 1 1
cccp6: 384 384 1 1
conv4-1024: 1024 384 3 3
cccp7-1024: 1024 1024 1 1
cccp8-1024: 1000 1024 1 1
Using Advanced Micro Devices, Inc. , OpenCL platform: AMD Accelerated Parallel Processing
Using OpenCL device: Tahiti
Setting up content layer	2	:	relu0
/home/goemon/torch-cl/install/bin/lua: symbol lookup error: /home/goemon/torch-cl/install/lib/libEasyCL.so: undefined symbol: lua_pcall

Hmmmm.... I'm not sure.... I tried doing a full installation and running neural-style on a 14.04 box  https://gist.github.com/hughperkins/b53cc8dc1e84b84d306a3f32d781d69b  The only things that occur to me is that maybe you're pulling down lua from somehwer eother than torch-cl?  What is the output of doing:
which lua
which th
which luajit
echo $PATH

?

Hi, Thanks.. There is the output (cpu mode -gpu -1 is working)
goemon@asrock-linux:~$ which lua
/home/goemon/torch-cl/install/bin/lua
goemon@asrock-linux:~$ which th
/home/goemon/torch-cl/install/bin/th
goemon@asrock-linux:~$ which luajit
/usr/bin/luajit
goemon@asrock-linux:~$ echo $PATH
/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch/install/bin:/home/goemon/torch/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch-cl/install/bin:/home/goemon/torch/install/bin:/home/goemon/torch/install/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
goemon@asrock-linux:~$

hmmm, my which luajit looks different:
ubuntu@peach:~$ which luajit
/home/ubuntu/torch-cl/install/bin/luajit

Can you also do:
th -e 'print(_VERSION)'
th -e 'print(_ENV)'

...and use th to run the following script (save it as eg /tmp/test.lua) ? :
local i_min = 0
while arg[ i_min ] do i_min = i_min - 1 end
local lua_exe = arg[ i_min + 1 ]
print('lua_exe', lua_exe)

I did a clean install; ubuntu 16.04; only torch-cl (distro-cl) and neural style (neuralstyle is working in cpu mode)
I runned the test
luajit -l torch -e 'torch.test()' - ok
luajit -l nn -e 'nn.test()' - ok
luajit -l cltorch -e 'cltorch.test()' - NO
luajit -l clnn -e 'clnn.test()' -ok
goemon@asrock-pc:~$ luajit -l cltorch -e 'cltorch.test()'
running tests...
aftter requiring cltorch.unit_storage
Running 2 tests
|_  ==> test_basic
*|  ==> test_get
**  ==> Done
Completed 0 asserts in 2 tests with 2 errors

test_basic
Function call failed
Something went wrong: OpenCL library not found at /home/goemon/torch-cl/opencl/cltorch/src/torch/generic/Storage.cpp:101
stack traceback:
[C]: at 0x7fc248ecc5c0
[C]: in function 'ClStorage'
.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:25: in function 'v'
.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:84: in function <.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:82>
[C]: in function 'xpcall'
...e/goemon/torch-cl/install/share/lua/5.1/torch/Tester.lua:115: in function 'pcall'
...e/goemon/torch-cl/install/share/lua/5.1/torch/Tester.lua:186: in function '_run'
...e/goemon/torch-cl/install/share/lua/5.1/torch/Tester.lua:161: in function 'run'
.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:91: in function 'test'
...e/goemon/torch-cl/install/share/lua/5.1/cltorch/Test.lua:8: in function 'test'
(command line):1: in main chunk
[C]: at 0x00405e90

test_get
Function call failed
No OpenCL-enabled devices available at /home/goemon/torch-cl/opencl/cltorch/src/lib/THClGeneral.cpp:139
stack traceback:
[C]: at 0x7fc248ecc5c0
[C]: in function 'ClStorage'
.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:64: in function 'v'
.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:84: in function <.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:82>
[C]: in function 'xpcall'
...e/goemon/torch-cl/install/share/lua/5.1/torch/Tester.lua:115: in function 'pcall'
...e/goemon/torch-cl/install/share/lua/5.1/torch/Tester.lua:186: in function '_run'
...e/goemon/torch-cl/install/share/lua/5.1/torch/Tester.lua:161: in function 'run'
.../torch-cl/install/share/lua/5.1/cltorch/unit_storage.lua:91: in function 'test'
...e/goemon/torch-cl/install/share/lua/5.1/cltorch/Test.lua:8: in function 'test'
(command line):1: in main chunk
[C]: at 0x00405e90

#tester.errors	2
res	false
luajit: ...e/goemon/torch-cl/install/share/lua/5.1/cltorch/Test.lua:10: assertion failed!
stack traceback:
[C]: in function 'assert'
...e/goemon/torch-cl/install/share/lua/5.1/cltorch/Test.lua:10: in function 'test'
(command line):1: in main chunk
[C]: at 0x00405e90

and
th -e 'print(_VERSION)'
th -e 'print(_ENV)'
goemon@asrock-pc:~$ which luajit
/home/goemon/torch-cl/install/bin/luajit
goemon@asrock-pc:~$ th -e 'print(_VERSION)'
Lua 5.1
goemon@asrock-pc:~$ th -e 'print(_ENV)'
nil

Cool. 16.04 is good.  Thats what I'm using, so will make it tons easier :-)  Can yo ucheck the output of:
clinfo

Tihs should show your GPU.  if it doesnt, you might need to install GPU drivers.  You might also need to sudo apt-get install -y clinfo first, for this command to work.

In 14.04 i installed fgrlx from Ubuntu Software; in 16.04 the new beta driver don't support my 7950 :/
http://support.amd.com/en-us/kb-articles/Pages/AMDGPU-PRO-Beta-Driver-for-Vulkan-Release-Notes.aspx
I can use opensource driver? I must also install the SDK?

Ah.  Well, if by opensource, you mean Clover, it lacks basic things, like tanh, so you probably wont get very far with it.  I guess back to 14.04 you go.  cltorch runs just fine on 14.04, so there's no reason why it wont work on your system . There's something not quite expected about your system, which I suspect is something to do with some combination of your PATH and / or lua version, which we cna probably figure out.  Might need a bit of patience though, since I dont have direct access to see what is happening.

Thanks! All works. (I was wrong something with torch and distro-cl installed together)

Super cool!  Great! :-)


On rare occasions the game does not register the player winning the game

The current way of tracking if a player wins is prone to bugs and errors.

Needs entire refactor of win conditions to not be tied to flags.
W18 OK 100 points


Images missing from HTML version of spec

Images are not rendering in the HTML released version of the Image Format spec (v0.4.0.)
The root cause MIGHT be that the HTML src= attributes seem to use relative URLs instead of absolute URLs.:

The following figure shows how the above media types reference each other:

NOTE: Images ARE rendering in PDF version of spec :)

I recommend tagging with Milestone = v1.0.0 since this should not block any minor releases, but would be good to resolve before a v1 release.

cc @vbatts

i think this is because the pdf inlines the images, but the html expects to find the images.
I went down the road to base64 encode and html inline the images, that was not real great for this doc process.
I could attach those img/ files in the release docs. That would seem sufficient to me. WDYT @RobDolinMS ?

On Wed, Sep 07, 2016 at 12:21:19PM -0700, Vincent Batts wrote:

I went down the road to base64 encode and html inline the images,
that was not real great for this doc process.

If the goal is to produce a single-page version of the spec, I think
we can save a lot of headache by writing it up in one big Markdown
file (opencontainers/runtime-spec#264 had something similar, but we
don't even need that much magic).  Or we can switch to
reStructuredText or some other format that's designed with this sort
of “produce compilable documentation” goal in mind.

i've spent some cycles on this, and still do not have a solution yet.
I realize the concern, but worse-comes-to-worse, I'd drop the single page HTML and only provide PDF rather than so-grossly hack this in.

As Rob says above, this is low priority, moving to rc3.

I am moving this to rc4 based on discussion on the mailing list that HTML and PDF isn't really the end goal as much as a top to bottom readable spec: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/XNreeSORPTQ

Per chat on OCI Dev ConCall, a partial (and sufficient) solution would be for a /img/ directory to be included with the release.  When the HTML spec is published, the /img/ directory should be published in the same location and the images will render.

two things @RobDolinMS

@wking's idea of an HTML <base> tag works fine, and will fetch the images from the tagged version on github. I've manually updated the RC3 and RC2 html documents with this approach.
I, or someone, will take a stab at a PR to get this in the make docs target so it is not a manual process.

For posterity, it is adding to the top of the *.html file:
<!DOCTYPE html>

    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
    <title>image-spec v1.0.0-rc3</title>
    <base href="https://raw.githubusercontent.com/opencontainers/image-spec/v1.0.0-rc3/">

and to the tail of it:

opened a PR for this
On Wed, Jan 25, 2017 at 5:35 PM, Rob Dolin (MSFT<EMAIL_ADDRESS>wrote:

Per chat on OCI Dev ConCall, a partial (and sufficient) solution would be
for a /img/ directory to be included with the release. When the HTML spec
is published, the /img/ directory should be published in the same location
and the images will render.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/image-spec/issues/247#issuecomment-275254711,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6ennYs2pIxXNKKJxzKILUISwN-etks5rV84fgaJpZM4JzJxg
.


TensorRT execution failed

Cuda 10.1
Ubuntu 18
TensortRT 6
GPU : 1050 TI
[TensorRT] ERROR: INVALID_CONFIG: The engine plan file is generated on an incompatible device, expecting compute 6.1 got compute 7.5, please rebuild.
[TensorRT] ERROR: engine.cpp (1324) - Serialization Error in deserialize: 0 (Core engine deserialization failure)
[TensorRT] ERROR: INVALID_STATE: std::exception
[TensorRT] ERROR: INVALID_CONFIG: Deserialize the cuda engine failed.
Traceback (most recent call last):
  File "demo.py", line 30, in <module>
    test_image_tensorrt()
  File "demo.py", line 13, in test_image_tensorrt
    dets, lms = centerface(frame, h, w, threshold=0.35)
  File "/opt/github/CenterFace/prj-tensorrt/centerface.py", line 21, in __call__
    return self.inference_tensorrt(img, threshold)
  File "/opt/github/CenterFace/prj-tensorrt/centerface.py", line 73, in inference_tensorrt
    context = engine.create_execution_context()
AttributeError: 'NoneType' object has no attribute 'create_execution_context'

Looks like this is going to work on Turing architecture only.

hi,
Maybe your computer environment doesn't match the author's, because the serial file depends on CUDA、GPU driver、GPU and so on

Maybe you can try tensorrt7.

@ywlife
Can mention exact cuda, tensortRT versions for compatibilty ?

@ywlife
[TensorRT] ERROR: INVALID_CONFIG: The engine plan file is generated on an incompatible device, expecting compute 6.1 got compute 7.5, please rebuild.

please check your GPU compute capablity in here

tensorrt7    [TensorRT] ERROR: ../rtsafe/corereadarchive.cpp  -serialization error in verifyheader 0 (version tag does not match) @dexception

trt file be generated from onnx file. I am not sure about the conversion script.
@ywlife
Can you share the convertion script ?

I got the same problem.but i soloved. you should re-generate .onnx file use your  environment.

in my titanx,there was same problem.then I changed my onnx input shape and bulid new trt file from change onnx, finally, python demo.py,that was OK!


Upgrade controller-tools to version 0.4.1

Fixes #1837.
Release Note
chore: Upgrade controller-tools to version 0.4.1

Travis CI is taking ages, do we still need it ?

Travis CI is taking ages, do we still need it ?

The Travis CI job executes the common test suite on OpenShift 3.11. It should be easy to run the suite as part of the tests executed by the GitHub actions OpenShift workflow.


NameTable.subsetTag static increment breaks binary hash

Hi, i assumed that generating a PDF with the same commands twice, will result in the same binary file. I found this is not the case, if embedded fonts are used. The PDFs only differ in the name of the embedded font.
NameTable has the static variable subsetTag, that is incremented for every call to NameTable.encode(), but never reset.
Why?
What about resetting this whenever pdf generation finished? Or just skip this counter entirely?

The tag is actually required by the pdf spec for subset fonts, and must be unique. Why does it matter that the binary files are 100% unique? I believe other things would be different as well, such as the creation date, which is stored in the file as well.

Ah, I see.
Well, my application requires to produce exactly the same binary file for repeated execution of the same commands on PDFDocument. I do set PDFDocument.info.CreationDate, so the only remaining binary difference of generated PDFs is the name of the embedded fonts. Without embedded fonts, the produced PDF is always the same.
Would be nice to have this "feature" in case of embedded fonts too.
What about adding a function to reset this counter manually, if required?


Support for --debug option

From mocha --help
...
Options:
    ...
    -d, --debug                             enable node's debugger, synonym for node --debug
    ...

It would be helpful if mocha-webpack could add an equivalent option to allow debugging of test code.

@ukch, do you think you could open a PR for this maybe?

Note that mocha has both --debug and debug which are a little different; ideally mocha-webpack should support both.


Allow setting a preferred port in acquireTokenInteractive

This PR updates the default loopback client to attempt listening at a preferred port set by the consumer of acquireTokenInteractive API, falling back to any available port if preferred port is not available. See also #5578

Codecov Report

Merging #5575 (c5d87f6) into dev (9384b58) will decrease coverage by 0.00%.
The diff coverage is 86.95%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.50% <ø> (ø)

Carriedforward from 9384b58

msal-browser
86.28% <ø> (ø)

Carriedforward from 9384b58

msal-common
86.01% <ø> (ø)

Carriedforward from 9384b58

msal-core
82.84% <ø> (ø)

Carriedforward from 9384b58

msal-node
83.39% <86.95%> (+0.01%)
:arrow_up:

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from 9384b58

msal-react
94.68% <ø> (ø)

Carriedforward from 9384b58

node-token-validation
88.88% <ø> (ø)

Carriedforward from 9384b58

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-node/src/network/LoopbackClient.ts
69.84% <85.71%> (+6.20%)
:arrow_up:

...ib/msal-node/src/client/PublicClientApplication.ts
76.31% <100.00%> (ø)

Decided to drop this PR, which seems redundant given #5578 and also introduces a somewhat complex logic into the lib, which is probably not a good idea.


Improve Documentation on IoT

Currently I'm following this tutorial on IoT
https://github.com/awsdocs/AWS-Kinesis-Video-Documentation/blob/master/doc_source/how-iot.md

The final step involves putting in a test string such as this
$ gst-launch-1.0 rtspsrc location=rtsp://YourCameraRtspUrl short-header=TRUE ! rtph264depay ! video/x-h264, format=avc,alignment=au !
 h264parse ! kvssink stream-name="kvs_example_camera_stream" iot-certificate="iot-certificate,endpoint=iot-credential-endpoint-host-name,cert-path=/path/to/certificate.pem,key-path=/path/to/private.pem.key,ca-path=/path/to/cacert.pem,role-aliases=KvsCameraIoTRoleAlias"

Currently issue I'm experiencing is I'm getting unexpected ASSIGNMENT error.
of the iot-certificate string, what are ambigious are iot-certificate, iot-credential-endpoint-host-name. For example endpoint could have a prefix of https:// or not. And I suspect iot-certificate should be assigned to a path.
Could someone verify the accuracy of the IoT instructions?

the endpoint should be whatever aws iot describe-endpoint --endpoint-type iot:CredentialProvider returns.

I think it's how gstreamer parsing comma delimited string that's an issue. Maybe someone can give it a shot?

I got the same set of certificates working for WebRTC, so it's not a mis-configuration issue on the AWS side. In addition, it is the gstreamer that is complaining about the input format.

 Appreciated the help! It was something else in the pipeline that is generating this error. Thanks for confirming! Possibly use "cat" to clarify the format of the endpoint.


Can't disable Blue Loading Screen

Hey,
how to disable the Blue Loading Screen with the three dots and the two blue boxes?
Thank you!

That's the A-frame loading screen. You can change it to an all-black screen by adding loading-screen="backgroundColor: black" to the a-scene element or disable it entirely with loading-screen="enabled: false". More info here: https://aframe.io/docs/1.2.0/components/loading-screen.html

Thank you so much!


Update gcp deployment_manager install files to support Istio 0.7.1

Update gcp deployment_manager install files to support and default to Istio 0.7.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @garystafford. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I signed it!

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Offensive text in countries list

Recently it was noted that the list of countries in HOT Tasking Manager user profile settings contained text that residents of Taiwan consider highly offensive.
I traced the Tasking Manager's code to this library where, indeed, the default ISO 3166-1 label for Taiwan that angers users is found.
I've seen two fixes for this in other libraries:

Simply remove the extraneous "Province of China" text
Keep the ISO 3166-1 names in place, but implement a "human readable" version of names that are a bit unwieldy and default to that when displaying

see eg https://github.com/SmileyChris/django-countries/issues/60 and its list:
COMMON_NAMES = {
"BN": _("Brunei"),
"BO": _("Bolivia"),
"IR": _("Iran"),
"KP": _("North Korea"),
"KR": _("South Korea"),
"LA": _("Laos"),
"MD": _("Moldovia"),
"RU": _("Russia"),
"SY": _("Syria"),
"TW": _("Taiwan"),
"TZ": _("Tanzania"),
"VE": _("Venezuela"),
"VN": _("Vietnam"),
}

Thanks, @fifieldt! Sorry for the delay on answering. I switched the countries data to OpenStreetMap ( #5 ). It's fixed now.

Thanks @willemarcel , I confirm it's updated in the tasking manager.


Bug: disabled rules: [all] does not disable YAML Timestamp.

Describe the Bug
disabled rules: [all] does not disable YAML Timestamp.
How to Reproduce
Steps to reproduce the behavior:

Set up the YAML Timestamp like this
In a note, write disabled rules: [all] in the YAML
Excute the command lint current file
The YAML timestamp is still inserted

Expected Behavior
The YAML timestamp should not be inserted when disabled rules: [all] is there.
Device

[x] Desktop (macOS)

@zcysxy , thanks for reporting this. I will see about taking a look at this for this next release.

Note to self, I need to check disabled rules for each special rule that is not run as if it were a regular rule to allow it to run in a particular order.

This issue should be resolved on master. Please let us know if this is not resolved on master or in the next release.


Inline code does not close correctly.

This is a 0.9 regression. Inline code that is started does not stop.

Fixed in 0.9.0-alpha.2


[WIP] Check for default external group and support :groups option

Add support for the :groups option in pilot when adding testers. Also this checks to see if there is a group marked as isDefaultExternalGroup from the iTC API to add to that if available.

          2 Warnings

:warning:
Pull Request is Work in Progress

:warning:
Please provide a changelog summary in the Pull Request description @ohayon

  Generated by :no_entry_sign: Danger

A possible issue - I have an app with no default external group.  When I add pilot add with no group name, it works great.  When I pilot add to a group name that exists, it works great. But, when I pilot add to a group name that DOES NOT exist, I get no error, and the tester is added to the account-level testers, but that is all.  Seems like this should be a warning or an error in this case.


Not working after 10.6GB update

After the update on May the 3rd the radar only shows the map without players.

New encryption with that update, will be very hard to find a way to bypass it everytime.
I'm guessing ~1 week, if not then you wont get any free radars anymore.


dwave_networkx.pegasus_graph(1) doesn't produce graphical output (it appears)

On my Mac OS X 10.14.3, using Anaconda,
graph = dwave_networkx.pegasus_graph(1)
dnx.draw_pegasus(graph)
plt.show()

does not produce any output.
Whereas
graph = dwave_networkx.pegasus_graph(2)
dnx.draw_pegasus(graph)
plt.show()

produces a picture.
I would like to understand why this approach doesn't produce a single Pegasus unit cell.

mathematically, the number of qubits is 24M(M-1). For M = 1, it's zero. Hence we don't get output for M = 1.


ES6 shorthand methods confuse requireSpacesInAnonymousFunctionExpression

The rule requireSpacesInAnonymousFunctionExpression is triggering errors for ES6 shorthand methods, which are not anonymous.
Error:
Missing space before opening round brace

Sample code:
const foo = {
    doStuff() {
        console.log();
    }
};

Configuration:
"requireSpacesInAnonymousFunctionExpression" : {
    "beforeOpeningRoundBrace" : true,
}

There's an option for shorthand http://jscs.info/rule/requireSpacesInAnonymousFunctionExpression
Yeah it's true its not 'anonymous` but it is that way in the AST/ESTree http://astexplorer.net/#/f7rzQ9dHCc (FunctionExpression with id null)

I did actually see that, but I assumed that would then not enforce a space before the curly brace. Is that not the case? I didn't bother testing that. I still want the curly space enforced for shorthand methods.

Okay, it seems question is answered, ping us up, if i'm wrong

This does not behave as I desire.
I want this to error due to lack of space before the curly brace, but it does not with the allExcept hack.
const foo = {
    doStuff(){
        console.log();
    }
};


[Algo] Merge Sort [Java]

https://en.wikipedia.org/wiki/Merge_sort
Please assign this to me.

GitMate.io thinks possibly related issues are https://github.com/NITSkmOS/Algorithms/issues/21 ([Algo]: Add Heapsort in Java), https://github.com/NITSkmOS/Algorithms/issues/46 ([Algo] Binary Search [Java]), https://github.com/NITSkmOS/Algorithms/issues/18 ([Algo]: Add Bubble Sort in Java), https://github.com/NITSkmOS/Algorithms/issues/63 ([Algo] Insertion Sort [Java]), and https://github.com/NITSkmOS/Algorithms/issues/134 ([Algo] Shell Sort [Java]).

I have added a PR to Mere sort in java. Please check it. Thanks for involving participation @udayvig

I have added a PR to Mere sort in java. Please check it. Thanks for involving participation @udayvig

Oh, I must have missed that. Sorry.

@fedesassone still waiting for you to accept the invitation.

@fedesassone assigned. Also, don't forget to read CONTRIBUTING.md documentation before opening a PR.


Hugo: finetune blog teaser styling (/blog/)

Moved date above tags
Made summary text slightly larger so the '...' doesn't fall on the next line
Cleaned up the list.html
Cleaned up teaser.scss
Blog teaser css adjustments - featured images grows with the content hight - remove spacing on the sides - correct font colors

For https://linear.app/usmedia/issue/CUE-325

FYI, needs a rebase with the search results fixes to see all the fixes

@jpluscplusm yes, it is also depending on page width, and of course the added width of all the characters. I'll adjust the number some more, but it will always be a possibility

Imported as https://review.gerrithub.io/c/cue-lang/cuelang.org/+/1168307

Closed via d85a288c0e889d0813f986fa79a8d335f25ae81e


dean/formatter break line with comma

note that this only adds a comma to the last argument of a list \ last use in a usemultilist.
a different PR will deal with improving the array format.

This change is


Available packages missing description

I am using Microsoft R open <IP_ADDRESS>

This info is not instantly available and populated asynchronously AFAIR.

It shows up correctly on MRO 3.3.2

Looks like the RDS merge seems to generate two rows with the same name. We try to set the row names and that is failing and hence the description data is not merged with available packages.

I've been using 3.3.3 for a while now... @AlexanderSher may comment on how exactly this is populated.

I think the issue is with MRO 3.3.3.

Interesting. MRO is supposed to be identical to CRAN, it is only different in linked libraries. Yes, I can repro with MRO 3.3.3 in Available tab only.

Isn't this a bug on MRO?

Not sure if they promised us anything about compatibility.

This may be due to a glitch with MRAN. The site was actually down for a few hours last week.

I can actually repro with stock 3.3.3. AFAIK MRO says it is 100% compatible with stock except that it is using Intel libraries for performance. BTW package manager doesn't see to reload when switching between different workspaces. It really should. Also,

Bumping up priority. Need to investigate and handle before the next 2017 15.2 preview.

Reverting didn't help. Actually, it reproes for me even with 3.3.2

So initial error message happens b/c PM is created by VS as tool window is persistent. I think it either should not be persistent (it affects perf so we get 'PM is slowing down VS' gold bar). Still need to handle reconnection.

I've checked the VS part - it does everything as expected, so we need to dig R code

BTW package manager doesn't see to reload when switching between different workspaces.

Just checked, it reloads both Installed and Loaded panes. Do you have a specific repro?

Ok, I've found the regression. It is in XAML.

OK. what changed?

The original bug, as filed by @karthiknadig occurred only on MRO <IP_ADDRESS>. We investigated it together and found that the merge code was producing 2 rows for the restfulr package.
https://github.com/Microsoft/RTVS/blob/564b8b4851fc042227d071601976b439436e0594/src/Host/Client/Impl/rtvs/R/packages.R#L73
Then the next line, https://github.com/Microsoft/RTVS/blob/564b8b4851fc042227d071601976b439436e0594/src/Host/Client/Impl/rtvs/R/packages.R#L76, was failing because it tried to assign the same name for 2 entries in the same list.

I am on 3.3.2 and I am seeing partial data

Ok, but there is also a XAML issue :)

@huguesv , what do you think about original bug? Should we do something on our side or should we notify MRO?

You'd need to have reliable repro specific to MRO 3.3.3.

Here is the minimal repro:
url <- gsub("src/contrib", "web/packages/packages.rds", "https://mran.microsoft.com/snapshot/2017-03-15/src/contrib")
path <- tempfile('pkg', fileext = '.rds')
suppressWarnings(download.file(url, destfile = path, quiet = TRUE, mode = "wb"))
fields <- c('Package', 'Title', 'Description', 'Built', 'URL', 'Author')
details <- readRDS(path)
details <- as.data.frame(details, stringsAsFactors = FALSE, rownames = extra[, 'Package'])
details <- details[fields]
restfulr <- subset(details, Package == "restfulr")

restfulr contains two records.

So this is MRO 3.3.3 only right?

No, it is specific to https://mran.microsoft.com, to all snapshots starting from https://mran.microsoft.com/snapshot/2017-03-08/src/contrib

But don't we use standard mirror by default?

https://mran.microsoft.com is a default for MRO

We can remove duplicates just like we do for installed.packages (3rd line added, in add.details ):
        pkg.rds.path <- download.packages.rds(repo.url)
        repo.details <- read.packages.rds(pkg.rds.path)
        repo.details <- repo.details[!duplicated(repo.details[, 'Package']),]
        repo.available.with.details <- merge(repo.available, repo.details, by = 'Package', all.x = TRUE)

We can filter that manually using package name or call unique, but the later will have some perf implications:
> microbenchmark(unique(details))
Unit: milliseconds
            expr      min       lq     mean   median       uq      max neval
 unique(details) 28.95504 30.05033 31.75493 30.50633 31.95296 72.15795   100

> microbenchmark(details[!duplicated(details$Package),])
Unit: milliseconds
                                    expr      min       lq     mean   median
 details[!duplicated(details$Package), ] 1.495571 1.771408 2.285385 1.929763
       uq     max neval
 2.352957 5.72752   100

Ok then, added to PR


[feat] recursive option for fileDropEnabled

Describe the problem
It would be nice to have a recursive option for fileDropEnabled, so that it would work the same that dialog.open works with the recursive option. My application needs to access files inside sub directories in the provided folder, but dropped items only seem to add the main folder and first level of files to the fs scope.
Describe the solution you'd like
I'm not quite sure how this option would be implemented, an additional configuration setting of fileDropRecursive in tauri.conf.json could be added.
e.g.
{
  "tauri": {
    // ...
    "windows": [
      {
        "title": "Tauri App",
        "width": 1600,
        "height": 900,
        "resizable": true,
        "fullscreen": false,
        "fileDropRecursive": true
      }
    ]
  }
}

Alternatives considered
I'm currently forced to have a global fs scope (e.g. ["**"]), which is something I'd very much like to avoid. I tried to figure out how to extend the fs scope through Rust, but even after hours of scouring through GitHub issues/discussions, the Tauri website and the Rust docs for Tauri (even tried ChatGPT and Bing Chat... I got desperate...), I wasn't able to figure out how to do it...
Tauri is my first interaction with Rust and it's quite hard figuring out the Rust docs when no examples are provided for how to use the methods listed in the documentation, on the other hand the provided JavaScript/TypeScript documentation shows nice minimal examples on basic usage (would be nice if the Rust docs had similar examples for Rust beginners like me).
Even though I'm able to find the functions I'm suppose to use in Rust using the docs, I have no idea how to use them, everything I've tried just gives me errors (which is why some minimal examples would be nice)...
Example from Rust docs:

Sorry I got a bit of topic here... Simply put, implementing a fileDropRecursive configuration setting would be quite helpful and a better solution than having to manually do recursive fs scope addition from the frontend using as Rust command.
Additional context
No response

The rust solution would look something like this
#[tauri::command]
fn extend_scope(handle: tauri::AppHandle, path: std::path::PathBuf) {
  let _ = handle.fs_scope().allow_directory(path, true); //just ignoring the error here because i'm lazy
}

Of course if you can handle the whole file drop event in rust in the first place this would be a bit more secure (there can't be random paths injected then)

Thank you @FabianLars very much for giving me a clear example. It still gave me an error since use tauri::Manager; wasn't included, but that was an easy fix, I cannot thank you enough, since this finally gives me feature parity with dialog.drop.
Sadly I don't think I'll ever manage to do the whole thing in Rust, since I need to do a fair amount of parsing of the dropped folder. The best I could implement was to handle the file drop detection in Rust, extend the scope and then emit an event to the frontend with the dropped path.
While I do now have it working, it would still be really nice to have a configuration option for this, since it's quite a bit of added code. dialog.drop supports it so feature parity with it would be appreciated.
Here is the end result if anyone else wants to implement something similar (it's probably not optimal):
use tauri::Manager;

// the payload type must implement `Serialize` and `Clone`.
#[derive(Clone, serde::Serialize)]
struct Payload {
  path: String,
}

fn main() {
  tauri::Builder::default()
    .on_window_event(|event| match event.event() {
      tauri::WindowEvent::FileDrop(drop_event) => {
        match drop_event {
          tauri::FileDropEvent::Dropped(dropped) => {
            // only the first path is fetched
            let dropped_path = dropped.first();
            if dropped_path.is_none() == false {
              println!(
                "Scope extended with path (from file drop): {:?}",
                dropped_path.unwrap()
              );

              let window = event.window();
              let app_handle = window.app_handle();
              let fs_scope = app_handle.fs_scope();
              let asset_scope = app_handle.asset_protocol_scope();

              // INFO: error handling is not implemented here yet

              // extend fs scope
              let _fs_result = fs_scope.allow_directory(dropped_path.unwrap(), true);

              // extend asset scope
              let _asset_result = asset_scope.allow_directory(dropped_path.unwrap(), true);

              let _event_result = window.emit(
                "file-dropped-scoped",
                Payload {
                  path: dropped_path.unwrap().to_string_lossy().into(),
                },
              );
            }
          }
          _ => {}
        }
      }
      _ => {}
    })
    .invoke_handler(tauri::generate_handler![])
    .run(tauri::generate_context!())
    .expect("error while running tauri application");
}


Remove manual credits section from release notes template

GitHub now automatically shows a contributors section at the bottom of release notes, with a photo of each contributor. Right above this we show a generated list of contributors. Our list has some problems: it shows multiple dependabot entries, and the Openverse bot.
We may want to consider removing our section in favor of GitHub's. One question I have is that GitHub's section may only appear in the GitHub UI, while ours is in the actual text of the release. Is there a benefit to having it in the text that we'll lose?

I'm not aware of any use of the text outside the context of the GitHub UI so I agree that the credits section can be dropped.

We've removed the credits sections from the release notes.


[Bug] Display of Spell Icons is messed up and creat Spells Button appears in spell list but doesn't work

So I switched over to this module from the magic items' module. It works fine, but I noticed a few issues.
So for one, the Icons don't use the right proportions in the Edit tab for the spells of the Item.  This also causes the format to get broken.

It's also annoying that you can't add or edit the new spells onto the item while it's on a player. You always have to copy it back to the items tab and edit it there, and then give it back to the player.
Another thing is that this strange create spell button appears on the char sheets spellbook along the spells. Even for the players. It confuses the players and when they click it by accident it throws an error message, so it doesn't even do anything. (could that be removed or at least hidden from the player's side?)

And finally, is there no config option to set the spell tab in the item edit window to be invisible for players?

I suggest consulting your UI modules. Non-repro.


Revert "Add jsonPackage for refactoring purposes"

Hello, I would like to know why did you revert this PR?