Add OpenAI as a pluggable spec

🚀 Feature
We should enable serving a model through a spec, without having to implement it manually in decode_request and encode_response. The spec (could be more than one) would:

expose a route
implement specific ways of decoding requests and encoding responses
require the API to expose certain kinds of information (e.g. token used)

in a way that is pluggable at the LitServer level (spec=OpenAISpec) and independent from the API implementation itself.
Motivation
We want to make it seamless for users to expose a model using one or more standard specs.
Pitch
I define a LitAPI subclass, call LitServer(api, spec=OpenAISpec, ...) and I will get an v1/chat/completions/ endpoint that behaves like an OpenAI compatible endpoint.
Alternatives
We subclass LitServer and LitAPI, but this would't compose cleanly down the road with other pieces we want to factor out (e.g. kvcache management).

Closed by #98 #100 #101


Video watermarks doesn't go away after start playing video on iOS

After start playing the video, 'youtube logo' watermark doesn't go away. Also in fullscreen mode.

The same happens to me, I found that if you tap first on the play icon below the cue an load buttons (in the above example), it hides the youtube logo, title and avatar correctly, however if you  touch the webview screen either to stop or play the video, the youtube logo, title and avatar do not go away

The same happens to me~~~!!

Has anyone been able to find the solution to this?

Can you guys please test with v7.0.0 ?

I tested it with Version 7.0.0+2 and the detailed example
https://github.com/sarbagyastha/youtube_player_flutter/blob/master/example/lib/main.dart
But It's still not working :(

Same here, tested in 7.0.0+3, both in simulator and an actual device with iOS 13.5.1


Up/down hold not working

On main screen in vfo mode numbers not changed until key release

Thanks for the report, it has been fixed.


Bundles should be able to receive configuration from launcher / OSGi config admin

See title

A  nice place to test this would be after implementing #4


Make worker-build support custom JS shims

This allows for users to provide their own JS shim and allowing them to customize behaviour: panic handling, wasm coredumps, and so on...
It defaults to the embedded shim in the binary to avoid breaking changes.

I think in the future we should explore different bundling modes, currently we always export a valid Worker but it seems like we may want a future where we export function/class stubs for people to do however they'd like and leave making a valid worker entirely up to them without them doing a custom shim. I'm fine with supporting this until then, but I think this is indicative of the holes in worker-build.


[Proposal] Access Primary Scroll Controller in nested Navigator

Use case
When using nested Router, primary scroll controller is not worked. So, Scrolling Screenshot(Android), Tap to scroll top(iOS) aren't worked.
It's because in nested router, context doesn't point to root context, so PrimaryScrollController.of(context) is primary scroll controller for nested router, not whole application.
I.E

Scaffold

Navigator

SingleChildScrollView

PrimaryScrollController <-- it point to Navigator's Primary Scroll Controller

So, we have to pass Controller as parameter like https://github.com/flutter/flutter/issues/85603#issuecomment-876798161
Proposal
Be able to use
PrimaryScrollController.of(Navigator.of(context, rootNavigator: true).context);

or
https://github.com/flutter/flutter/blob/f4a44a9d6867dfefa8adceecafa35694e47f8df1/packages/flutter/lib/src/widgets/primary_scroll_controller.dart#L62
Change this code to PrimaryScrollController always use root's context.
or, add parameter on primary scroll controller
PrimaryScrollController.of(context, rootNavigator: true);

if rootNavigator is true, primary scroll controller use root's context

https://medium.com/@suhw4n/flutter-tab-to-scroll-top-on-nested-navigation-b176cc759921
Here's my solution for now..

Hi @SuhwanCha, I ran the below code sample from the linked issue, I am unable to reproduce the issue. In nested navigation scroll state seems to be maintained.  Let me know if I am missing anything and please share output of flutter doctor -v and share a minimal and complete code sample to reproduce the issue.
https://user-images.githubusercontent.com/31410839/147464401-82bd053b-f18b-4b2a-82f0-3eb1e8b258e8.mov

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MainPage(),
    );
  }
}

class MainPage extends StatefulWidget {
  const MainPage({Key? key}) : super(key: key);

  @override
  _MainPageState createState() => _MainPageState();
}

class _MainPageState extends State<MainPage> {
  final _navigatorKey = GlobalKey<NavigatorState>();
  int currentIndex = 0;

  @override
  Widget build(BuildContext context) {
    // Grab the top most controller
    final ScrollController controller = PrimaryScrollController.of(context)!;

    return Scaffold(
      body: IndexedStack(
        index: currentIndex,
        children: [
          TapBodyWidget(
            listName: 'A',
          ),
          Navigator(
            key: _navigatorKey,
            initialRoute: 'B',
            onGenerateRoute: (settings) => MaterialPageRoute<dynamic>(
              builder: (context) {
                return TapBodyWidget(listName: 'B', controller: controller);
              },
              settings: settings,
            ),
          )
        ],
      ),
      bottomNavigationBar: BottomNavigationBar(
        type: BottomNavigationBarType.fixed,
        unselectedItemColor: Colors.black,
        selectedItemColor: Colors.blue,
        selectedLabelStyle: TextStyle(
          color: Colors.blue,
          fontWeight: FontWeight.bold,
        ),
        unselectedLabelStyle: TextStyle(
          color: Colors.black,
          fontWeight: FontWeight.bold,
        ),
        currentIndex: currentIndex,
        onTap: (index) => setState(() => currentIndex = index),
        items: [
          BottomNavigationBarItem(
            icon: Icon(Icons.favorite_border),
            label: 'TAB A',
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.bookmark),
            label: 'TAB B',
          ),
        ],
      ),
    );
  }
}

class TapBodyWidget extends StatelessWidget {
  const TapBodyWidget({Key? key, required this.listName, this.controller})
      : super(key: key);
  final String listName;
  final ScrollController? controller;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: ListView.separated(
          controller: controller,
          itemBuilder: (context, index) {
            return ListTile(
              tileColor: Colors.red[100 * (index % 9 + 1)],
              title: Text('$listName :  $index'),
              trailing: Icon(Icons.chevron_right),
              onTap: () => Navigator.of(context).push(
                MaterialPageRoute(
                  builder: (context) => TapBodyWidget(
                    listName: '$listName:$index',
                    controller: controller,
                  ),
                ),
              ),
            );
          },
          separatorBuilder: (context, index) => Divider(),
          itemCount: 100),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.8.1 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (11 days ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.61.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • iPhone 13 (mobile) • 45FE8AD8-94DA-4F94-B52B-81102B1B42E7 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)    • macos                                • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 96.0.4664.110

• No issues found!

Hi, @maheshmnj
In your code, it works but TapBodyWidget received ScrollController as parameter.
In this solution, passing ScrollController might be cumbersome.
So, I propose there will be option to directly access PrimaryScrollController in nested widget.
For example,
PrimaryScrollController.of(Navigator.of(context, rootNavigator: true).context);

Ah, I get it now, @SuhwanCha Thanks for the clarification that makes sense.

Thank you, @maheshmnj
Because I’m not familiar with open source contribution, so I just would like to if do I have to wait or can I make PR now.

@SuhwanCha You are open to submitting a PR and make sure to link this issue in your PR description.

This has been a source of immense suffering for the better part of 6 months for me and is holding up my app release in that time.
Heres to hoping a fix is coming 🙏    Not being able to scroll up in a tabbed application doesn't look good right now

@maheshmnj
Hello, I created PR. Can you review it and request reviewing to other org members?
Thanks

@maheshmnj
Hello, I created PR. #96012 Can you review it and request reviewing to other org members?

I am not the right person, Please wait until someone reviews it, or you may reach out to team members on discord in Hackers new channel https://github.com/flutter/flutter/wiki/Chat.

cc: @Piinks

Closing this as a duplicate of https://github.com/flutter/flutter/issues/85603


Running command for intent handling produces FileNotFoundError

Hi,
I am running Rhasspy on a web interface on Ubuntu 20.04. I am trying to run a local command for intent handling from Rhasspy. I customized my profile to reflect my program:
"handle": {
        "system": "command",
        "command": {
            "program": "/home/evl/.config/rhasspy/profiles/en/rhasspy-win/main.py"
        }
    },

As you can see, and by this issue, I used an absolute path. Rhasspy logs don't show anything of importance, but Docker logs show this:
[DEBUG:2021-05-24 11:30:19,753] rhasspyserver_hermes: Handling NluIntent (topic=hermes/intent/GetTime, id=58fb283d-cedc-4da4-80ae-3dfc1b9358e1)
[DEBUG:2021-05-24 11:30:19,754] rhasspyremote_http_hermes: ['/home/evl/.config/rhasspy/profiles/en/rhasspy-win/main.py']
[ERROR:2021-05-24 11:30:19,768] rhasspyremote_http_hermes: handle_intent
Traceback (most recent call last):
  File "/usr/lib/rhasspy/rhasspy-remote-http-hermes/rhasspyremote_http_hermes/__init__.py", line 824, in handle_intent
    stderr=asyncio.subprocess.PIPE,
  File "/usr/lib/python3.7/asyncio/subprocess.py", line 217, in create_subprocess_exec
    stderr=stderr, **kwds)
  File "/usr/lib/python3.7/asyncio/base_events.py", line 1533, in subprocess_exec
    bufsize, **kwargs)
  File "/usr/lib/python3.7/asyncio/unix_events.py", line 190, in _make_subprocess_transport
    **kwargs)
  File "/usr/lib/python3.7/asyncio/base_subprocess.py", line 37, in __init__
    stderr=stderr, bufsize=bufsize, **kwargs)
  File "/usr/lib/python3.7/asyncio/unix_events.py", line 763, in _start
    universal_newlines=False, bufsize=bufsize, **kwargs)
  File "/usr/lib/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.7/subprocess.py", line 1522, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/evl/.config/rhasspy/profiles/en/rhasspy-win/main.py': '/home/evl/.config/rhasspy/profiles/en/rhasspy-win/main.py'
[DEBUG:2021-05-24 11:30:19,758] rhasspyserver_hermes: Sent 370 char(s) to websocket

As you can see, it's looking for the file main.py which does not exist. I am 100% sure that the path is correct because I copied and pasted pwd output. Does anyone have any ideas as to how to fix this?
I previously tried using asyncio and websockets myself, but couldn't run any asynchronous methods while the websocket ran forever, so I'm now trying to run it as a program. Any help would be appreciated. Thanks!

Inside docker, the path "/home/evl/.config/rhasspy/profiles/en/rhasspy-win/main.py" does not exist.
It only exist on the host.
Changing the path to /profiles/en/rhasspy-win/main.py will work, because that is path is available in the container.
It is mapped to the profiles folder for Rhasspy on the host.

@Romkabouter Thanks for the clarification, I'm sure this will definitely help! I figured another way around this issue, and just forgot to close this. I'll check out this fix later and see if it works.


fix verse of the day

Fixed, it was a type error due to which graphql gave null
else things were fine

so there was a typecasting issue for datetime in flutter for the graphql api,grapgql query needs date object but string was passed,

also now there is  a new issue
the server is at GMT and we are at GMT +5:30
so the new verse gets updated after 5:30 hours for us and till then it would show null
a quick fix would be to show the last entered verse in db, that would change at cron job call
this way we would get a verse of the day without a fail

this is a particular issue with graphql because in the rest api we filter the verse of the day with date that's from the server's timezone and this matches the timezone of setting the verse and gives us a verse of the day without any failure. We initailly designed the db for FastApi, being REST api we are still getting full verse at the verse of the day endpoint even by saving only verseNumber without reference in db
fix
I am updating the qyery with last added verse in db

so there was a typecasting issue for datetime in flutter for the graphql api,grapgql query needs date object but string was passed,
also now there is a new issue
the server is at GMT and we are at GMT +5:30
so the new verse gets updated after 5:30 hours for us and till then it would show null
a quick fix would be to show the last entered verse in db, that would change at cron job call this way we would get a verse of the day without a fail
this is a particular issue with graphql because in the rest api we filter the verse of the day with date that's from the server's timezone and this matches the timezone of setting the verse and gives us a verse of the day without any failure. We initailly designed the db for FastApi, being REST api we are still getting full verse at the verse of the day endpoint even by saving only verseNumber without reference in db
fix
I am updating the qyery with last added verse in db

As another alternative we can adjust the dateTime to GMT in flutter that @ravinder-chadha  can do as I am quite new to this stuff, but I guess the last:1 works

I think we just need to add the .toUtc() to the datetime.now() call.
Something like this:
var now = new DateTime.now().toUtc()
@Gupta-Anubhav12 Try that out and see if it works.

var now = new DateTime.now().toUtc() works fine. So, merging.


Supporting/endorsing additional launchers

People have suggested that FO should support/endorse PolyMC (e.g. #296) because of its additional features and Modrinth support and ATLauncher because of Modrinth support. Both should also support Quilt (#257).
However, here's my current stance on this subject:

MultiMC forks - to my knowledge they are still just forks, with all the pros and cons of MultiMC, so at the moment there doesn't seem to be a substantial reason to recommend one over another and as with any forks, they may not be as up-to-date with feature and security updates as they should.. Maybe if one of those make the modpack updating easier, it would give a better reason to consider.
Edit: PolyMC will be supported due to high interest and planned modpack updater
Edit 2: PolyMC will not be considered and instead its fork, Prism Launcher is now supported
ATLauncher - it's good that it seems progressive with Modrinth and Quilt development, but the last time I checked it still has bad UX from FO standpoint because it prefers its own modpack repo (aka you can't just search "Fabulously Optimized" and click install, it needs more clicks).
Edit: this issue no longer exists, but it still needs some UX improvements before I'll consider.
Modrinth launcher (WIP, #63) - I will endorse it when it gets released and FO becomes stable (sustainable) in Modrinth.
Others - know any?

Edit: See https://github.com/Fabulously-Optimized/fabulously-optimized/issues/297#issuecomment-1133878580 for current plan.

MultiMC forks - to my knowledge they are still just forks, with all the pros and cons of MultiMC, so at the moment there doesn't seem to be a substantial reason to recommend one over another and as with any forks, they may not be as up-to-date with feature and security updates as they should.. Maybe if one of those make the modpack updating easier, it would give a better reason to consider.

PolyMC is a lot more updated than MultiMC, take a look at the commit historu

PolyMC is a lot more updated than MultiMC, take a look at the commit history

Fair, but I'm still waiting to see more differences that would improve the UX in some way. Downloading mods for example is not a good reason, because as far as I see, there is no update feature for those either.

PolyMC is a lot more updated than MultiMC, take a look at the commit history

Most likely reason is the main developer currently away from most dev stuff. And as Madis0 said, it's still fundamentally the same launcher, installing and updating modpacks don't change either.

PolyMC isn't old enough to shake off all the trolls, as they still post meme comments on MultiMC PRs. I feel like the launcher needs to mature a bit.

That person is not on the PolyMC dev team

How is he away from most dev stuff since PolyMC exists

this makes absolutely no sense, but maybe I should clarify: Peterix stated that he was currently away from most dev stuff in the MultiMC discord. I don't understand how that has anything to do with PolyMC's existence

As far as I see, there is no update feature for those either.

A mod/modpack upgrade in on their milestone for the next release (https://github.com/PolyMC/PolyMC/issues/65 & https://github.com/PolyMC/PolyMC/issues/274)

Some preliminary work is in progress
https://github.com/PolyMC/PolyMC/pull/426

Thanks for the reply. I checked it out and reported some usability problems but yeah, the UX needs more work overall.

Bringing this issue back to life by saying that PolyMC plans to give the ability to auto-upgrade modapcks and mods on version 1.4.0! Currently, they are working on version 1.3.0, which also brings some very useful features.

I don't think modpack updating will get in 1.4.0, probably will be delayed, but for sure 1.4.0 will have a mod updater!

This is the current plan for supporting various launchers in FO.

The graph does not indicate all capabilities of the launchers, but rather the ones I would like to recommend and support
Some mentioned launchers don't exist yet
Support start depends on various aspects, including UX improvements and CF API situation settling

ManyMC is now based on PolyMC, as of version 0.1.0. A PolyMC release with official M1 support is planned soon (via).

Prism Launcher (a fork of PolyMC) is now supported.

A good resource of launchers to test: https://github.com/modrinth/awesome#launchers

Not actually a good idea to add new launchers to support just for the sake of it - if something new and popular will come, I'll consider it anyway. So, for any new launchers - create a new separate meta issue.


Add Azure Function Health Checks

Description

Add new Azure Function with an HTTP trigger for return a health check status
Add new health check for Key Vault secrets
Add health check to docker-compose for functions
Fix SQL server docker-compose health check
Integrate health check into PR pipeline

Related issues
N/A
Testing
PR Build

TODO: More tests


Implemented (Good) Broyden

This PR adds the implementation of the good Broyden method (denoted in scipy as 'broyden1').
Some current pending aspects that I would like to discuss (and this is why I am opening this PR):

I currently have a very hard time getting any test to pass when using float32, as numerical imprecisions cause nan and inf values to appear in my Broyden matrix computations. @mblondel if you have any idea on how to typically resolve those any input is welcome.
I noticed that the setting of gamma is super important in many tests: maybe I should do like scipy and compute it if not set. Btw, unlike LBFGS I didnt find a rule to update it with iterations, so for now it is fixed.
For now I rely on jax autodiff to perform the line search, whereas scipy computes an adhoc version of the derivative of ||f(x)||^2 (see here). I think it would be nice to compute this adhoc trick only when the function is not differentiable, so I need to find a way to check this nicely.
similarly to LBFGS, it's not possible to use the unrolled differentiation when linesearch is used. I am wondering whether we should have a more explicit error (atm it's something like cannot differentiate through while_loop).
I have implemented a limited memory version of the broyden method like scipy. However, I currently am not implementing a mechanism to switch to a full matrix if the history size is bigger than the variable dimension (this is also not implemented in LBFGS). Maybe for now a warning to the user could be enough?

Happy to get your thoughts on which of these aspects should be in this PR and which can wait.

@mblondel the tests are now passing in float32 probably due to some update in main that fixed the issue.
When you have time could you answer the other questions I had regarding this PR?
I think all of them could be handled in different PRs, so I am going to mark this one as ready for review.

@mblondel added : can you tell me what you think of the content of root_finding.rst ? not sure exactly what I need in there, but took inspiration from fixed point and unconstrained

If you can squash, then I'll merge :)

Squash done

There is an unrelated failure in main. I will merge when CI is back to green.


Dart2js mixin in typed data list does not get the correct type parameter.

We have
  abstract class NativeTypedArrayOfInt
      extends NativeTypedArray
          with ListMixin<int>, FixedLengthListMixin<int>
      implements List<int> {
and
  class NativeUint8List
      extends NativeTypedArrayOfInt
      implements Uint8List native "Uint8Array,!nonleaf" {
The implementation of NativeUint8List.where is inherited from ListMixin<int>, but when called, its type parameter is missing/dynamic, so the returned Iterable is a WhereIterable<dynamic>, not WhereIterable<int>.

There are two problems.
import 'dart:typed_data';
main() {
  var x = new Uint8List(1);
  print(x is List<int>);
  print(x is List<String>);
  print(x.where(null) is Iterable<int>);
  print(x.where(null) is Iterable<String>);
}

(prints true, false, true, true).
The first problem is that ListMixin.where$1 passes the argument receiver to getRuntimeTypeArgument.
The lookup of the substitution function is done on the receiver, but it should be done on the interceptor for the receiver.
It would be best if the interceptor was passed in to getRuntimeTypeArgument, since it is almost always available locally (e.g. as this).
       where$1: function(receiver, test) {
        return H.setRuntimeTypeInfo(new H.WhereIterable(receiver, test), [H.getRuntimeTypeArgument(receiver, "ListMixin", 0)]);
      },

The second problem is that the mixin application is missing the $asListMixin substitution.
It appears to be related to https://github.com/dart-lang/sdk/issues/20113

This problem will block strong mode.
getRuntimeTypeArgument could call getInterceptor, but that would be very expensive.
The cost might be reduced by making getRuntimeTypeArgument a method, since the interceptor and receiver are always available in the method (this = interceptor).
The $asListMixin substitution would need to be using interceptor calling convention, passing the receiver as a parameter.

@rakudrama fixed this when adding getRuntimeTypeArgumentIntercepted


support for JME Application States

Hi,
why you don't use JME's Application States? (see here
http://wiki.jmonkeyengine.org/doku.php/jme3:advanced:application_states )
It's looking that you implement the same thing in your class controller.Controller.  Things like enabled/running/paused/updateLoop are implemented manually by you. Is there a reason for that?
Is it because you use a timer-speed-combination? And than you must handle you own Updateloop?
thanks for answering

It has been done naturally and i've never loot at JME App States deeply. First I needed a controlleur to catch inputs, then The controller gained the model refresh responsibility, plus the GUI redraw, then I implemented a second controller and created a super class, etc etc.
If my implementation is close to JME App State, it is not intended, and I don't think to have specific needs so App States should certainly make the job.
Do you think it could be interesting to refactor?

absolutely. If there is an software pattern in JME like AppStates and its working good, then you should use it. So it's easier to understand for developers. And like you see in your implementation, this pattern is good, because you use it in the identical way. A refactoring should be easy. I will try it if it's ok.

done now with last commit.


Fix compiler warnings

Lots of the warnings are caused by signed-unsigned comparisons.

All wanings fixed in the warningFix branch.


[SPARK-21087] [ML] CrossValidator, TrainValidationSplit expose sub models after fitting: Scala

What changes were proposed in this pull request?
We add a parameter whether to collect the full model list when CrossValidator/TrainValidationSplit training (Default is NOT, avoid the change cause OOM)

Add a method in CrossValidatorModel/TrainValidationSplitModel, allow user to get the model list

CrossValidatorModelWriter add a “option”, allow user to control whether to persist the model list to disk.

Note: when persisting the model list, use indices as the sub-model path

How was this patch tested?
Test cases added.

Test build #81685 has started for PR 19208 at commit 46d3ab3.

Test build #81685 has finished for PR 19208 at commit 46d3ab3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81685/
Test FAILed.

Merged build finished. Test FAILed.

cc @jkbradley

Test build #81686 has started for PR 19208 at commit ae13440.

Test build #81686 has finished for PR 19208 at commit ae13440.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81686/
Test PASSed.

CC @hhbyyh and @MLnick  Does this look reasonable to you?
And @hhbyyh would you want to split off a new JIRA for your original solution of adding an option to dump models to disk?  Then we could revive your PR.

oh...sorry for that, I integrate @hhbyyh's old PR into this new one, because I found the code "dump models to disk" and "collect models" seem to be cohesive and split them will cause some conflicts when merging. @jkbradley

Synced offline: I hadn't looked carefully and seen the 2 issues had been merged.  @WeichenXu123 said he will split the work in 2, adding one parameter first.

@jkbradley I split this PR, removed the code for "dump models to disk", so the PR will be smaller and easier to review. When this PR merged, I will create follow-up PR for "dump models to disk". Thanks!

Test build #81767 has started for PR 19208 at commit e0f4ce6.

Test build #81767 has finished for PR 19208 at commit e0f4ce6.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81767/
Test FAILed.

Jenkins, test this please.

Test build #81772 has started for PR 19208 at commit e0f4ce6.

Test build #81772 has finished for PR 19208 at commit e0f4ce6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81772/
Test PASSed.

Merged build finished. Test PASSed.

It's OK to me to include the "dump model to disk" https://github.com/apache/spark/pull/18313 in this or other PR (or not).
After reading the discussion, I feel it's an overkill to support a feature like this in two ways (keeping in memory and dumping to disk). Allowing user to register a custom action after each batch of est.fit(trainingDataset, epm) looks like a more general solution to me, in there user may dump models to disk, collect it for later use, or evaluate with other metric.
If you want to stick to this way which I'm not a fan of, I would only suggest to add the logic to estimate the memory the models will cost and stops the application if OOM is foreseeable.

@smurching Thanks! I will update later. And note that I will separate part of this PR to a new PR (the separated part will be a bugfix for #16774 )

I will update this PR after #19350 get merged. We need to address another issue first. Thanks!

Test build #82233 has started for PR 19208 at commit 77d05f6.

Test build #82233 has finished for PR 19208 at commit 77d05f6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82233/
Test FAILed.

Test build #82246 has started for PR 19208 at commit e009ee1.

cc @smurching code updated, thanks!

Test build #82246 has finished for PR 19208 at commit e009ee1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82246/
Test PASSed.

Merged build finished. Test PASSed.

Test build #3972 has started for PR 19208 at commit e009ee1.

taking a look...

Test build #3972 has finished for PR 19208 at commit e009ee1.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

ping @jkbradley Comments all addressed! Pls take a look again. Thanks!

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83388/
Test FAILed.

Merged build finished. Test FAILed.

Test build #83393 has started for PR 19208 at commit 2a83fb5.

Test build #83393 has finished for PR 19208 at commit 2a83fb5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83393/
Test PASSed.

Done with review.  I mainly review CrossValidator since some comments will apply to TrainValidationSplit as well.  Thanks for the PR!

Test build #83469 has started for PR 19208 at commit f2ef609.

Test build #83469 has finished for PR 19208 at commit f2ef609.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83469/
Test PASSed.

Test build #83530 has started for PR 19208 at commit 7bacfca.

Test build #83530 has finished for PR 19208 at commit 7bacfca.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83530/
Test FAILed.

Merged build finished. Test FAILed.

Test build #83534 has started for PR 19208 at commit 654e4d5.

Test build #83534 has finished for PR 19208 at commit 654e4d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83534/
Test PASSed.

Test build #83823 has started for PR 19208 at commit 2bb6835.

Test build #83823 has finished for PR 19208 at commit 2bb6835.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83823/
Test FAILed.

Test build #83824 has started for PR 19208 at commit 7e997da.

I manually tested backwards compatibility and it works fine. I paste the test code for CrossValidator here.
Run following code in spark-2.2 shell first:
import java.io.File
import org.apache.spark.ml.tuning._
import org.apache.spark.ml.{Estimator, Model, Pipeline}
import org.apache.spark.ml.classification.{LogisticRegression, LogisticRegressionModel, OneVsRest}
import org.apache.spark.ml.feature.HashingTF
import org.apache.spark.ml.linalg.Vectors
import org.apache.spark.ml.param.ParamMap
import org.apache.spark.ml.regression.LinearRegression
import org.apache.spark.sql.Dataset
import org.apache.spark.sql.types.StructType
import org.apache.spark.ml.evaluation.{BinaryClassificationEvaluator, Evaluator, MulticlassClassificationEvaluator, RegressionEvaluator}
import org.apache.spark.ml.feature.{Instance, LabeledPoint}

def generateLogisticInput(offset: Double,scale: Double,nPoints: Int,seed: Int):Seq[LabeledPoint] = {
    val rnd = new java.util.Random(seed)
    val x1 = Array.fill[Double](nPoints)(rnd.nextGaussian())
    val y = (0 until nPoints).map { i =>
      val p = 1.0 / (1.0 + math.exp(-(offset + scale * x1(i))))
      if (rnd.nextDouble() < p) 1.0 else 0.0
    }
    val testData = (0 until nPoints).map(i => LabeledPoint(y(i), Vectors.dense(Array(x1(i)))))
    testData
  }
import spark.implicits._
val dataset = sc.parallelize(generateLogisticInput(0.0, 1.0, 10, 42), 2).toDF()
val lr = new LogisticRegression
val lrParamMaps = new ParamGridBuilder().addGrid(lr.regParam, Array(0.001, 1000.0)).addGrid(lr.maxIter, Array(0, 3)).build()
val eval = new BinaryClassificationEvaluator
val numFolds = 3
val cv = new CrossValidator().setEstimator(lr).setEstimatorParamMaps(lrParamMaps).setEvaluator(eval).setNumFolds(numFolds)
val cvModel = cv.fit(dataset)
cvModel.save("file:///Users/weichenxu/work/test/s1")

and then run following code on current PR: (in spark-shell)
val model = org.apache.spark.ml.tuning.CrossValidatorModel.load("file:///Users/weichenxu/work/test/s1")
model.hasSubModels

Test build #83824 has finished for PR 19208 at commit 7e997da.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83824/
Test FAILed.

Jenkins, test this please.

Test build #83834 has started for PR 19208 at commit 7e997da.

Test build #83835 has started for PR 19208 at commit 7e997da.

Test build #83835 has finished for PR 19208 at commit 7e997da.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83835/
Test FAILed.

Test build #83834 has finished for PR 19208 at commit 7e997da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83834/
Test PASSed.

Merged build finished. Test PASSed.

Awesome, thanks for the updates and for checking backwards compatibility!
LGTM
Merging with master


Support Fraktur ANSI escape sequence

If I run echo -e "\e[20mfoobarblahbizbang\e[0m" in the command line, I expect to see Gothic text, but instead see text rendered in the default font.


gRPC takes a long time to receover after network issue

Repro steps:

Enter airplane mode
Exit airplane mode
Immediately send an RPC

Expected:
RPC succeeds or fails fast
Actual:
RPC fails with GRPCErrorCodeUnavailable after ~ 18s
Subsequent retry succeeds
@jcanizales @makdharma

Hi Zeke, was that with the Cronet networking layer, or without?

Zeke just mentioned that this happens without Cronet. @jcanizales - isn't this the classic network status monitoring case you fixed?

@tkchin I am not seeing this behavior with the RouteGuide sample app. When the phone enters airplane mode the RPCs fail immediately, and start working immediately after coming out of airplane mode. Same is true when wifi is disconnected/connected.

Maybe he's using an old commit?

I can repro this fairly reliably with my own app on my iPhone 6S. Is there anything I can do to get more logs?

We should totally enable all core traces after we do grpc_init(). Surrounded by an #ifdef of some GRPC_DEBUG macro.

@jcanizales Can you submit the fix that is already working for @tkchin ?

@jcanizales Please also submit the PR for master branch.


Load genesis from GENESIS_URL

Signed-off-by: Jonas Niestroj<EMAIL_ADDRESS>Summary of Changes
The GENESIS_URL env variable seems to be not used at the moment. So i added the functionality for loading the genesis file and adding it to the indy ledgers.
I was not sure about making the ledger from the env a production ledger or not.
Maybe a json file with the format of
[{"name": "BCovrinTest", "isProduction": false, "genesisTransactions": ...}]
would be more configurable then having default ledgers and adding one with the env file.
Feedback and other ideas appreciated.
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[ ] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@TimoGlastra I updated the PR with a new approach. Now its easy to update/add/remove new ledgers.
If this approach is suitable for you i will also update the README but before doing this, feedback is appreciated.


Refactor distance calculation utilities to be elevation-aware

In preparation for making Douglas Peucker polyline simplification elevation-aware (discussion, larger diff I'm breaking into separate reviews), this review implements calcNormalizedEdgeDistance3D on each DistanceCalc implementation so 3D Douglas Peucker can call it from here and refactors a bit:

Now that each implementation is 3D-aware, remove DistanceCalc3D and add a 3D calcDist method onto each implementation
Rename DistanceCalc2D to DistanceCalcEuclidean since it also handles elevation

Thanks also here! Really valuable work @msbarry!


How to get the Point Cloud

Hello,
How can I get the point cloud of the all image?The coordinates x,y and z of each pixel?
And the respective rgbd match?
Thanks

Same here. Would really like to know how to get point cloud. If anyone got any ideas, please share.

me too, please!

Use the depth image as source of the polar points.
x = r * sin(a)*cos(b)
y= r * sin(a)sin(b)
z= rcos(a)
The angles a and b are results of the index and the FOV(70.6° x 60°):
for w in range(width):
    a = FOV_H * (i / width) - (FOV_H / 2)
    for h in range(height):
        b =FOV_V * (i / height) - (height / 2)

Use the depth image as source of the polar points.
x = r * sin(a)*cos(b)
y= r * sin(a)sin(b)
z= rcos(a)
The angles a and b are results of the index and the FOV(70.6° x 60°):
for w in range(width):
    a = FOV_H * (i / width) - (FOV_H / 2)
    for h in range(height):
        b =FOV_V * (i / height) - (height / 2)


the front page link for custom decision portal  https://portal.ds.microsoft.com/ is not loading below is the link to the image  can u update the link or let me know the correct URL for registering the app with custom decision service

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

@prasanthijul30 what is the link to the document you are following?

Front page link
Get Outlook for iOShttps://aka.ms/o0ukef

From: Micah<EMAIL_ADDRESS>Sent: Tuesday, March 26, 2019 1:19:15 PM
To: MicrosoftDocs/azure-docs
Cc: Prasanthi Kalla (Zen3 Infosolutions America Inc); Mention
Subject: Re: [MicrosoftDocs/azure-docs] the front page link for custom decision portal https://portal.ds.microsoft.com/ is not loading below is the link to the image ![image](https://user-images.githubusercontent.com/48961368/55019391-08af7400-4fb2-11e9-9d46-d...
@prasanthijul30https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprasanthijul30&data=02|01|v-kalp%40microsoft.com|c2548ba54ff34134a8fd08d6b22851dd|72f988bf86f141af91ab2d7cd011db47|1|0|636892283571463575&sdata=F7VEzRAmnoyWJGwbVfyPze68GlxXdNIdZgB2JiJFczc%3D&reserved=0 what is the link to the document you are following?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F28052%23issuecomment-476832044&data=02|01|v-kalp%40microsoft.com|c2548ba54ff34134a8fd08d6b22851dd|72f988bf86f141af91ab2d7cd011db47|1|0|636892283571463575&sdata=xZh6NHODeIKlkpSk0mTngEX6ZBorS7S0oeijZpDW%2Bg0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAusXWELMUFaeoiyE0RVl20Qo2ViglgUWks5vaoDDgaJpZM4cMCe-&data=02|01|v-kalp%40microsoft.com|c2548ba54ff34134a8fd08d6b22851dd|72f988bf86f141af91ab2d7cd011db47|1|0|636892283571463575&sdata=83%2BeOfyp87Jvtkqq0y3eHN%2BEhZljrEaUFXNNhp3ODOU%3D&reserved=0.

Sorry which front page? I am not following

https://docs.microsoft.com/en-us/azure/cognitive-services/custom-decision-service/custom-decision-service-get-started-register
in the above page there is link front pagehttps://portal.ds.microsoft.com/ this link is not working?
Thanks,
Prasanthi
From: Micah<EMAIL_ADDRESS>Sent: Tuesday, March 26, 2019 2:03 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Prasanthi Kalla (Zen3 Infosolutions America Inc<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] the front page link for custom decision portal https://portal.ds.microsoft.com/ is not loading below is the link to the image ![image](https://user-images.githubusercontent.com/48961368/55019391-08af7400-4fb2-11e9-9d46-d...
Sorry which front page? I am not following
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F28052%23issuecomment-476851369&data=02|01|v-kalp%40microsoft.com|98f2a6e48c0441b9785e08d6b22e6bdc|72f988bf86f141af91ab2d7cd011db47|1|0|636892309793676440&sdata=J5Rg8%2BqOPzl4cRA9wTlxtP7bazROGJB3UW3sFT7ee3s%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAusXWNdJOu0aHfhqzxkwG5VG8vQpQ-4Uks5vaosAgaJpZM4cMCe-&data=02|01|v-kalp%40microsoft.com|98f2a6e48c0441b9785e08d6b22e6bdc|72f988bf86f141af91ab2d7cd011db47|1|0|636892309793686394&sdata=yl6zKYFHhkHS19khhBrEOqcb0t0P89Ky25PwUlYpcfI%3D&reserved=0.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d5d2969-e3ff-7d00-04f3-de6e44b59a86
Version Independent ID: 0aaf6a69-2cfe-a485-cfe5-a5a28b1fc447
Content: Register your application - Custom Decision Service
Content Source: articles/cognitive-services/custom-decision-service/custom-decision-service-get-started-register.md
Service: cognitive-services
GitHub Login: @slivkins
Microsoft Alias: slivkins

@YutongTie-MSFT can you help on this one?

@slivkins Hi Alex, I can confirm the Portal Link is broken, could you please check and update the document? Thanks a lot.

Custom Decision Service is a lab. It is not a preview or GA service.
#please-close


New Golang Security Announcement: [security] Go 1.19.4 and Go 1.18.9 are released

Go to the Golang group to view the announcement.
Follow the on-call runbook to backport fixes to all supported Golang versions.

These have been addressed. Closing this out.


Cascading with more than one condition

Hi there,
The  cascading used in  serenity guide use COUNTRY and City example use something like
SELECT CITY WHERE COUNTRYID=X
How to achieve cascading with two conditions
SELECT CITY WHERE COUNTRYID=X && POPULATION<10000

You can do it from several ways, personally I like to make lookup editors and overriding the get_items...

Thanks, Can you show me an example or link to similar question

I create a lookup.cs file and used prepare query, instead of xx below I need form value like this.form.myfield
query.Distinct(true)
.Select(fld.MyFieldName)
.Where(
new Criteria(fld.MyFieldId) ==xx );

there's an example on creating custom editor, here it's

Create Type Script file with the following and change the variable with yours:

 @Serenity.Decorators.registerEditor()
 export class ProduceSeafoodCategoryEditor extends
    Serenity.LookupEditorBase<Serenity.LookupEditorOptions, Northwind.CategoryRow> {

    constructor(container: JQuery, opt: Serenity.LookupEditorOptions) {
        super(container, opt);
    }
    protected getLookupKey() {
        return Northwind.CategoryRow.lookupKey;
    }
    protected getItems(lookup: Q.Lookup<Northwind.CategoryRow>) {
        return super.getItems(lookup).filter(x =>
            x.CategoryName === 'Produce' || x.CategoryName === 'Seafood');
    }
}


Webpack no longer compiles as of 2.1.9

Not sure what the problem is but webpack seems to compile fine on 2.1.8, but 2.1.9 and later it will no longer complete. It just runs forever with no errors or anything.  I don't have time to create a test, but when i do I can create one. Just submitting issue to be reminded and maybe someone else also has issue.
I am using webpack 2.2.0-rc3

Cannot reproduce with vue 2.1.10, webpack 2.2.1, vue-loader 10.0.2.
Please try to upgrade everything to the latest version and see if the problem persists,
if so, please check your webpack configs, and create a reproduction repo.
Closing now as it doesn't seem to be related to vue.
Also, you might want to check

If vue and vue-template-complier's version are the same.
If there's any webpack config/params suppressing errors.


RFC: Support for bidirectional communication (prompting the user)

The protocol currently supports making requests to an agent service. However, some agents may need to be able to communicate with the user in order to function optimally. For example:

User: please buy me a new set of cutting boards
AI: would you like wooden or plastic cutting boards?
User: I like wood
AI: searches for wooden cutting boards and places an order on Amazon

Adding a way for agents to prompt the user would greatly increase the versatility of the protocol imo.
Proposal
Two primary options:

Extension of the protocol with a status awaiting_input, and a way to resolve this status with additional input for an existing task or step

Extension of the task endpoint with a callback (or similar) attribute through which a client can specify a callback URL which may be polled with prompts for the user until they are resolved.
Example:

Giving the agent a task

POST /agent/tasks
{
  "input": "Please find a nice olive wood cutting board on Amazon and order it for me.",
  "callback_url": "https://my-service.url/agents/203820/callbacks"
}

The agent wants more info

POST https://my-service.url/agents/203820/callbacks
{
  "prompt": "What is your budget for this purchase?"
}

{
  "prompt_id": 123,
  "status": "pending",
  "created": "2023-08-23T13:49:51.141Z",
  "last_updated": "2023-08-23T13:49:51.141Z"
}

The agent polls the client until the prompt is resolved

GET https://my-service.url/agents/203820/callbacks/123

Responses:
{
  "prompt_id": 123,
  "status": "pending",
  "created": "2023-08-23T13:49:51.141Z",
  "last_updated": "2023-08-23T13:49:51.141Z"
}

{
  "prompt_id": 123,
  "status": "resolved",
  "answer": "I don't want to spend more than €40 on this purchase",
  "created": "2023-08-23T13:49:51.141Z",
  "last_updated": "2023-08-23T13:53:12.634Z",
}

{
  "prompt_id": 123,
  "status": "rejected",
  "created": "2023-08-23T13:49:51.141Z",
  "last_updated": "2023-08-23T13:53:12.634Z",
}

Alternatives

Extending the protocol with full chatting capabilities:

GET /agent/tasks/<task_id>/chats
List chats regarding task <task_id>

POST /agent/tasks/<task_id>/chats
Start a new chat regarding task <task_id>

POST /agent/tasks/<task_id>/chats/<chat_id>/messages
Post a new message in an existing chat

GET /agent/tasks/<task_id>/chats/<chat_id>/messages
Get all messages in a chat

POST /agent/tasks/<task_id>/chats/<chat_id>/close
Close/resolve a chat

Interesting, I feel like chats are better implemented with websockets - What do you think? @jzanecook

This might be one of the perfect examples for a plugin referencing #71 since it's something that not all agents might have.

Can you attend a meeting the Agent protocol meeting on the 12th to discuss this?


Clarification shouldCompactOnLaunch documentation

The example in the documentation (https://realm.io/docs/swift/latest/#compacting-realms) is not very clear to me, as I don't know if the compaction could be called all the time during app use or only once at startup. Is the implementation below correct or would it be better to make a separate config including shouldCompactOnLaunch to call once on app launch.
If I add shouldCompactOnLaunch to the default configuration I see the block being called every time I create a realm instance.
        Realm.Configuration.defaultConfiguration = Realm.Configuration(schemaVersion: schemaVersion, migrationBlock: migrationBlock,shouldCompactOnLaunch: { totalBytes, usedBytes in
        // totalBytes refers to the size of the file on disk in bytes (data + free space)
        // usedBytes refers to the number of bytes used by data in the file

        // Compact if the file is over 100MB in size and less than 50% 'used'
        let oneHundredMB = 100 * 1024 * 1024
        print ("totalbytes \(totalBytes)")
        print ("usedbytes \(usedBytes)")
        if (totalBytes > oneHundredMB) && (Double(usedBytes) / Double(totalBytes)) < 0.7{
            print("will compact realm")
        }
        return (totalBytes > oneHundredMB) && (Double(usedBytes) / Double(totalBytes)) < 0.7
    })
    do {
        // Realm is compacted on the first open if the configuration block conditions were met.
        _ = try Realm(configuration: config)
    } catch {
        // handle error compacting or opening Realm
    }

And one more thing would be interesting to me: What happens if the compaction fails? Too little storage would be a reason. Will I still be able to access the data and the compaction will just be skipped?

@bb-git shouldCompactOnLaunch block is invoked again if the Realm instance is cleared from internal cache. It's intended behavior.
For the second question, the compaction operation reads the entire contents of the Realm file, rewrites it to a new file at a different location, then replaces the original file. So if compaction fails or skipped, it is not replaced the original file. So you can still access the data.

So what's the best practise then?
I now made a seperate config for the compaction in the app delegate and did not include the compaction in the default configuration, so if necessary it should be done on app launch.
As you manage everything now, I guess there is no autoreleasepool needed for the realm instance that includes compaction in the config in this configuration?
Thanks

@bb-git If you do not need to handle multiple configurations (it means your app doesn't have multiple Realm files), the best practice is setting the configuration to default configuration once, then use try! Realm().
No autorelease block is needed. The compaction process is all done by Realm. The only situation which autorelease block needed is multi-threading. Use autorelease block to avoid unintentional version pinning. Please see https://realm.io/docs/swift/latest/#threading

So I'm doing it like this now:
        let config = Realm.Configuration(schemaVersion: schemaVersion, migrationBlock: migrationBlock,shouldCompactOnLaunch: { totalBytes, usedBytes in
            // totalBytes refers to the size of the file on disk in bytes (data + free space)
            // usedBytes refers to the number of bytes used by data in the file

            // Compact if the file is over 20MB in size and less than 60% 'used'
            let twentyMB = 20 * 1024 * 1024
            return (totalBytes > twentyMB) && (Double(usedBytes) / Double(totalBytes)) < 0.6
        })
        do {
            // Realm is compacted on the first open if the configuration block conditions were met.
            _ = try Realm(configuration: config)
        } catch {
            // handle error compacting or opening Realm
        }

        Realm.Configuration.defaultConfiguration = Realm.Configuration(schemaVersion: schemaVersion, migrationBlock: migrationBlock)

I guess this is also fine, as it all happens on the same thread? I'm just afraid of data loss.
I will have a look in using autoreleasepools on background threads, as I suffer from rapidly growing database size without this size really being necessary and used.

I guess this is also fine, as it all happens on the same thread? I'm just afraid of data loss.

Correct, it's fine. And it all happens on the main thread.

@kishikawakatsumi Came here via the StackOverflow question: https://stackoverflow.com/q/44407812/144857
I'm seeing the same issue as @bb-git, where the shouldCompactOnLaunch block is being called excessively. Here's my configuration:
    var realmConfig: Realm.Configuration = Realm.Configuration.defaultConfiguration
    realmConfig.fileURL = ....
    realmConfig.shouldCompactOnLaunch = { (totalBytes: Int, usedBytes: Int) -> Bool in
        guard totalBytes > 100 * 1_048_576 else { return false }
        guard Double(usedBytes) / Double(totalBytes) < 0.5 else { return false }
        log.warning("Should compact Realm database: \(usedBytes) / \(totalBytes)")
        return true
    }

I'm seeing this shouldCompactOnLaunch block called constantly, whenever I'm updating objects. In one place in my code I'm updating hundreds of objects, and shouldCompactOnLaunch is being called over 100 times per second. This doesn't feel correct, since it's no longer 'on launch', and Realm isn't acting on a true value anyway at this point as the file isn't compacted until the next app launch.
Also, Realm seems to be caching this block, because even if I set it to nil at some point later, the block still fires.
Is this really expected behaviour? If so, I'm tempted to stop setting shouldCompactOnLaunch on most app launches, and perhaps just have it set every 25th app launch or something.
Let me know if you'd like a sample project or any other info.
Thanks.

It looks like current the compactOnLaunch block is called each time a Realm is opened on a new thread, even if that Realm is already open on other threads.
Why is this a problem for you? Is it just that you're logging messages from within the block? The overhead of calling it too often should be unmeasurably small compared to the time it takes to open the Realm at all.

I have some fixes for this awaiting review in https://github.com/realm/realm-object-store/pull/496 and https://github.com/realm/realm-cocoa/pull/5114.

@tgoyne Sorry for the delay, got distracted. That makes sense for what I was seeing.
I've worked around this issue for now by using an autoreleasepool on app start up.  I use a Realm Config with a shouldCompactOnLaunch block, have it do the check, then exit the pool and set up a Realm stack without the shouldCompactOnLaunch block. Seems to be working much better now.

@kishikawakatsumi sorry to dig this up, but really the compacting happens on main thread? Won't i slow down UI tasks?


Fix renaming function dialog in VisualScript does not work correctly

Fixes #58021
Issue fixed
OK button doesn't work for confirming function rename dialog in VisualScript editor.
Identified cause
Current code only validate the function renaming with return key pressed.
OK button is not connected to any callback function.
Fix proposal
Connect the OK button.
Other minor changes :

Title was missing for this dialog ("Alert!" was used. Set title to "Rename Function")
LineEdit wasn't grabbing the focus so entering the new name wasn't as fluid as it can be. Now grabbing the focus on popup.

Thanks!


Feature/footer social

Add brand icons font variant.
Add social links.
Update Footer styling to accommodate links and bring in line with design.
Update talk section stylie to fix bugs from chat integration

@jebw Id prefer to use flexbox over table as a display property as it serves most users better. I'll add fallback support for IE11 and add to the PR.


Mat/Pat - Supervisor Confirmation

Supervisors should see the a confirmation screen when they approve or deny a form.
Design -
Approval - https://miro.com/app/board/uXjVOWaGSE0=/?moveToWidget=3458764567822490602&cot=14
Denial - https://miro.com/app/board/uXjVOWaGSE0=/?moveToWidget=3458764567825651345&cot=14
AC

[x] Supervisor sees the correct confirmation page on approval and denial

@ayushdamani @fazil-ey this change is ready to test on TEST env. let me know if you face any other issue while testing this one.

Since I am not able to validate my own submissions, I will request the team at check-in to test this together.

For a submission APPROVED:
"Employees must inform their supervisor if there are any changes to the start date of the their maternity.."
Could you please remove "the" from the sentence? Apologies, since there was an error on the Miro board.

@ayushdamani Please review again, I removed "the".

Thank you so much for the update, Jerry! Moving to PO

looks good


updates from huan-li

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/huan-li.yml
:white_check_mark:Succeeded

rd/index.yml
:white_check_mark:Succeeded

rd/map.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feat: Added functionality to connect node by dragging and dropping from anywhere on node

Describe your changes :

Added functionality to connect node by dragging and dropping from anywhere on node
#8521
Closes #8530

Type of change :

[x] Improvement
[x] New feature

Frontend Preview (Screenshots) :
https://user-images.githubusercontent.com/71748675/201013606-eb6ee017-9a2a-40dd-b28c-68a1db226ee1.mov

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Hi, @Sachin-chaurasiya comments are addressed!


Residential buildings: refine scenarios

Once the historic data and the apartment blocks archetypes are in place, we need to refinde our scenario values.

Fig.3 of the Global Status Report 2017 has floor area projections by region and decade apparently coming from the 2017 ETP.

A bit confused. You mean other scenario values that the ones discussed in https://github.com/YaleCIE/RECC-project/issues/104? I extended the target tables already, etc.

Current refined scenario assumptions are being tested now. Can re-open issue if needed.


table is not extended to full width of parent

Problem: table is not extended to the width of it's parent
code:

		<Column
		header={<Cell>First Name</Cell>}
		cell={<Cell>mama</Cell>}
		fixed={true}
		width={100}
		/>
		<Column
		header={<Cell>Sentence! (flexGrow greediness=2)</Cell>}
		cell={<Cell>chacha</Cell>}
		flexGrow={2}
		width={200}
		/>
		<Column
		header={<Cell>Company (flexGrow greediness=1)</Cell>}
		cell={<Cell>nana</Cell>}
		flexGrow={1}
		width={200}
		/>
		<Column
		width={100}
		header={<Cell>Last Name</Cell>}
		cell={<Cell>sasa</Cell>}
		/>

Screenshot

I want 4 col table full width, and the table width should be fluid to the it's container, which is a div in this case. And it's not doing that, I don't know what is missing.
git repo demo: https://github.com/craigcosmo/react-boilplate/tree/test-table

solution: https://github.com/facebook/fixed-data-table/issues/289


vue.config.js vueLoader.preserveWhitespace = false not work

Version
3.0.0-beta.6
Reproduction link
https://jsfiddle.net/yozman/3Lcwjrts/
Steps to reproduce
vue.config.js
What is expected?
$slots.default 去掉空格
What is actually happening?
$slots.default 空格一直存在

感觉是 vueLoader 的 preserveWhitespace 未生效

Tested, and it's working with or without vue.config.js.🤔

@jkzing
r u sure？
$slots.default.length 一直是包含空格的

@yozman Yes, from what I'm seeing, preserveWhitespace is working as expected.
Maybe you could provide your problematic code (like a github repo) to help reproduce the issue.

@jkzing
I use .js without .vue
// parent.js
import Child from './child';

const template = /*html*/`
  <child>

one

two

  </child>
`;

export default {
  template,
  components: {
    Child,
  },
};

// child.js
const template = /*html*/`

    <slot/>

`;

export default {
  template,

  created() {
    console.log(this.$slots.default.length);
  },
};

Well, if you use js files, then you are not using vue-loader, which only takes care of .vue files.

Inline JS strings are compiled by the runtime compiler, not vue-loader.

@yyx990803
how can I set preserveWhitespace to runtime compiler?

@yyx990803 @LinusBorg
could u please give a solution?

This would have to be addressed in the vue repository, not vue-loader.

@yozman you cannot. If you want that behavior you have to use pre-compile via vue-loader.

@yyx990803 why don't u make a feature to that, as every FE known everything is js, not .vue

@yyx990803 why don't u make a feature to that, as every FE known everything is js, not .vue

yes, inline template need preserve whitespace


Show Screen on Page

Hi ,
I want to use different page on click on tab/swipe , how to do that ?

Hey, I just released a new alpha 2.0.0-alpha.0 of the library. It's rewritten using react-native-gesture-handler and react-native-reanimated addresses a many platform specific bugs and performance problems. The documentation is updated as well.
Please try the new version and see if it addresses your issue. If not, please open a new issue following the issue template.


fix: Allow serializing child widget if it is a substring of the conta…

…iner
Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test tags=""
:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

Bug Fixes

Improved the handling of widget names in file paths to ensure only the trailing instance is removed, enhancing path integrity and preventing unintended modifications.

/build-deploy-preview skip-tests=true


Heatmap 'select' apply to column instead of cell

Version
4.9.3
Reproduction link
https://jsfiddle.net/2j1bgshz/3/
Steps to reproduce
Click any cell with data inside.
What is expected?
The cell is selected, with a default gray border displayed.
What is actually happening?
Besides the clicked cell, all of those in the same column look as if they were selected.

In the console.log output of 'selectchanged' event, there is an array named selected[0][dataIndex]. It changes after every event. It stores the indexes of all selected cells, instead of columns.
I expect the style of selected cells can change accordingly, however, it goes wild to the whole column.
I think it's a bug.
I tried solving it by putting every row's data in a different series, but that seems not really smart.
Looking forward to better solutions :)

I'm also running into this issue, but didn't discover it until converting our whole application over to eCharts.
I agree that this is a bug though, since all other actions on series-heatmap are cell-scoped (e.g. emphasis/hover, tooltip). If this is intended functionality, documentation would be helpful.

The reason is data without name will be assigned with a default name from category axis. So cells on the same column will have same name. This design is mainly for the bar, line charts. But it may have issue in the heatmaps.
The solution is assign a unique name for each cell data.

@pissang Makes sense! That change was successful! Thanks for the help, and for such a wide-reaching charting library!

@pissang Makes sense! That change was successful! Thanks for the help, and for such a wide-reaching charting library!

I am facing the same issue... Could you provide an example of how I can assign unique name for each cell data item. Thanks.

I am facing the same issue... Could you provide an example of how I can assign unique name for each cell data item. Thanks.

I created a simple guide on Stack Overflow for solving the problem. Essentially, I implemented the solution mentioned by @pissang and included the relevant part of the documentation alongside it.
Selecting a Single Cell Instead of a Column on a Heatmap Chart: A Step-by-Step - Stack Overflow Answer

I just hit this bug.


confusion with config in online mode

I was already using QLIB without the server.
my provider_uri was QLIB_DS2_DATA_DIR
Now I installed the qlib server and it is running. I checked the logs
My config is as follows
`ONLINE_CONFIG = {
# data provider config
"calendar_provider": {"class": "LocalCalendarProvider", "kwargs": {"remote": True}},
"instrument_provider": "ClientInstrumentProvider",
"feature_provider": {"class": "LocalFeatureProvider", "kwargs": {"remote": True}},
"expression_provider": "LocalExpressionProvider",
"dataset_provider": "ClientDatasetProvider",
"provider": "ClientProvider",

# config it in user's own code
"provider_uri": "<IP_ADDRESS>:/",
# cache
# Using parameter 'remote' to announce the client is using server_cache, and the writing access will be disabled.

"expression_cache": None,
"dataset_cache": None,
"calendar_cache": None,
"mount_path": QLIB_DS2_DATA_DIR,
"auto_mount": True,  # The nfs is already mounted on our server[auto_mount: False].
"flask_server": "<IP_ADDRESS>",
"flask_port": 9710,
"region": "cn",

}`
Now Im not able to query any data.

View the NFS mount result: df -h
If NFS is not successfully mounted, you can mount it manually: sudo mount -t nfs <IP_ADDRESS>:/ <QLIB_DS2_DATA_DIR>
Check whether qlib-server is running successfully: telnet <IP_ADDRESS> 9710
If port 9710 cannot be connected, you can post the log of qlib-server startup


Experiment on full set of iapp_wiki_qa_squad

Sub tasks

[x] Find sizeable dataset for benchmarking https://github.com/iapp-technology/iapp-wiki-qa-dataset
[x] Convert to iapp_wiki_qa_squad: https://github.com/iapp-technology/iapp-wiki-qa-dataset
[x] PR to huggingface/datasets: https://github.com/huggingface/datasets/pull/1873
[x] Runnable notebook: https://colab.research.google.com/drive/1o-bM5V2C7m2BaXapwZBcavq5Ig3VF0fK?usp=sharing
[x] Notebook that works 100% with WangchanBERTa and iapp_wiki_qa_squad (shared with @artificiala )
[x] Train on combined iapp_wiki_qa_squad and thaiqa_squad as training set (duplicates removed)
[x] Acceptable finetuning performance
[x] Add helper functions to thai2transformers
[x] Experiment scripts

@cstorm125  Try TyDi QA?

@cstorm125  Try TyDi QA?

@cstorm125 Try TyDi QA?

How many questions for Thai again?

@cstorm125 Try TyDi QA?

How many questions for Thai again?

Got it
Train/valid/test at 11,365/2245/2203
@artificiala let's use this instead of thaiqa

Got it
Train/valid/test at 11,365/2245/2203
@artificiala let's use this instead of thaiqa

TyDi QA removed thai and japanese. @kobkrit is our only hope.
https://github.com/huggingface/datasets/tree/master/datasets/tydiqa

TyDi QA removed thai and japanese. @kobkrit is our only hope.
https://github.com/huggingface/datasets/tree/master/datasets/tydiqa

WIP with small (4k) set of thaiqa_squad adapted from example in HF
https://colab.research.google.com/drive/1o-bM5V2C7m2BaXapwZBcavq5Ig3VF0fK?usp=sharing

WIP with small (4k) set of thaiqa_squad adapted from example in HF
https://colab.research.google.com/drive/1o-bM5V2C7m2BaXapwZBcavq5Ig3VF0fK?usp=sharing

Change to benchmark on this:
https://github.com/iapp-technology/iapp-wiki-qa-dataset

add iapp_wiki_qa_squad to huggingface/datasets
https://github.com/huggingface/datasets/pull/1873

MVP Notebook WIP at: https://colab.research.google.com/drive/1o-bM5V2C7m2BaXapwZBcavq5Ig3VF0fK?usp=sharing

Wiki models still cannot do QA because it does not provide offset_mapping like Fast Tokenizers.

Closing until Wikimodels can use Fast Tokenizers https://github.com/vistec-AI/thai2transformers/issues/19

Hello. I used thai2transformers'project for built BERT pre-trained successed. (with run_mlm.py)
But I would like to fine-tuning in Q/A so I can't to continue with this project.
I try with "Runnable notebook: https://colab.research.google.com/drive/1o-bM5V2C7m2BaXapwZBcavq5Ig3VF0fK?usp=sharing", but failed. I'd like to get advised with fine-tuning Q/A by using BERT pre-trained model. Thank you.


Display Container Stats

It would be great if the UI can show stats of containers. Similar to docker stats command.

:+1:

:+1:

Implemented with #135, available in v0.8.0-beta, let me know what you think.


Create Float, DateTime, and Version properties

LiteralProperty should become an abstract base class. IntProperty, FloatProperty, DateTimeProperty, and VersionProperty should define or override the convert_to_user and convert_from_user methods.
@bbartley says version numbers are derived from Maven version numbers, so we'll have to come up with a reasonable way to validate those. Or just let the user figure out it.

sbol.test.test_identified.TestCopy.test_copy_and_increment_version on  branch 71-implement-copy-methods is currently marked as an expected failure because it depends on VersionProperty.incrementMajor method

IntProperty exists. FloatProperty, DateTimeProperty, and VersionProperty still need to be implemented.

Closed by #296


Add minimal memory manager failing tests with NewMemoryAndSize / Read…

Adds a few tests to capture the following behaviour which leads to a MemoryClassCheck "Unknown host pointer" error.
Vector x(1);
x.UseDevice(true);
{
   Vector X;
   X.NewMemoryAndSize(x.GetMemory(), x.Size(), false);
   X.Read();
   x.SyncMemory(X);
}
x.Read();

We do need a formal review for this PR (since it goes in a PR under review).
@v-dobrev and @YohannDudouit, can you just comment/approve?

LGTM


feat: Add better error handling to rule creation

What
Adds better error handling to rule creation
Why
Currently SQL Parse Errors are never surfaced. If an SQL parse error occurs it is nicer behaviour that it is instantly surfaced.
How
By capturing different error types and reporting on them accordingly

Thanks for creating this tool @alinadima !  It works really well! Let me know if you need anything else from me for this. Currently SQL errors are not surfaced making them somewhat difficult to debug! :sweat_smile:

Thanks for creating this tool @alinadima ! It works really well! Let me know if you need anything else from me for this. Currently SQL errors are not surfaced making them somewhat difficult to debug! 😅

What
Adds better error handling to rule creation
Why
Currently SQL Parse Errors are never surfaced. If an SQL parse error occurs it is nicer behaviour that it is instantly surfaced.
How
By capturing different error types and reporting on them accordingly

Thanks for creating this tool @alinadima ! It works really well! Let me know if you need anything else from me for this. Currently SQL errors are not surfaced making them somewhat difficult to debug! 😅

Thanks so much for your feedback and PR @ryanolee! Much appreciated! Will review your PR in the next few days.


[NTR] candelabrum cell

Please check that the term does not already exist by using the ontology search tool OLS:
https://www.ebi.ac.uk/ols4/ontologies/cl
Preferred term label
Synonyms (add reference(s), please)
Definition (free text, with reference(s), please. PubMed ID format is PMID:XXXXXX)
Parent cell type term (check the hierarchy here https://www.ebi.ac.uk/ols4/ontologies/cl)
Anatomical structure where the cell type is found (check Uberon for anatomical structures: https://www.ebi.ac.uk/ols4/ontologies/uberon)
Your ORCID
Additional notes or concerns

Definition:
A GABAergic interneuron located in the cerebellar cortex. This GABAergic interneuron type has a small cell body near the Purkinje cell layer (PCL), dendrites that extend to the surface of the molecular layer, and beaded axons that make numerous local synapses within the molecular layer. A candelabrum cell is excited by mossy fibers and granule cells but inhibited by Purkinje cells, and it inhibits molecular layer interneurons, which leads to the disinhibition of Purkinje cells.
reference:
PMID: 35578131
extended definition:
Candelabrum cells are the most abundant interneurons in the Purkinje cell layer and are present in all cerebellar lobules.
reference:
PMID: 35578131
Synonym:
CC
reference:
PMID: 35578131
synonym:
candelabrum interneuron
reference:
PMID: 35578131
@JABelfiore please review


@conda-forge-admin,please add bot automerge

As per title.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/alibi-detect-feedstock#2.


Removal of split package between netty-codec and netty-codec-xml

Motivation:
The netty-codec maven module contains the io.netty.handler.codec.xml.XmlFrameDecoder class which shares a package with the package of the netty-codec-xml maven module, and therefore exhibit a split package. A split package is not allowed by the java module system.
Changes:
The class io.netty.handler.codec.xml.XmlFrameDecoder is moved from the netty-codec maven module to the netty-codec-xml maven module along with its tests. Since it is a breaking change the revapi difference has been added to the list of ignored breaking changes.
Results:
The split package is removed, users of the class io.netty.handler.codec.xml.XmlFrameDecoder will need to add the netty-codec-xml maven module to their dependencies in order to continue using the class.
Fixes #14228

The graal metadata needs to be updated as well

@chrisvest please have a look

still failing, having another look

ok got it, it is repeated for each jar that is a dependency

A few builds failed without a log


Replace Avatar in favor of Icon in OuiFacetButtons example

Description

Update "avatar as icon" example as described in #909

[x]  Replace avatar with icon/facet tokenObject
[x]  Change text Avatar as icon to Facet with Icon example

Issues Resolved

Closes #909
Check List

[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[x] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@KrooshalUX Can you approve screenshot is what you were looking for?

@joshuarrrr LGTM


GEODE-4389: Ensure that region template creation does not require cal…

…lback classes on the locator
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

precheckin is green


[WIP] starting on APK v2 Signature

Codecov Report

Merging #427 into master will decrease coverage by 0.14%.
The diff coverage is 14.28%.

@@            Coverage Diff            @@
##           master    #427      +/-   ##
=========================================
- Coverage   68.84%   68.7%   -0.15%
=========================================
  Files          41      41
  Lines       13378   13413      +35
=========================================
+ Hits         9210    9215       +5
- Misses       4168    4198      +30

Impacted Files
Coverage Δ

androguard/core/bytecodes/apk.py
57.17% <14.28%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643bc6a...3795173. Read the comment docs.