New OpenVPN Client Export Broken

The new version of the client export has several missing features, and produces currently unusable config files.
For example, you are now unable to have a client export that will use the Windows certificate store instead of a cert file. Also, for some reason it capitalizes "TCP" and "UDP" for the protocol, which many clients do not like.

and you're planning to work on things you're missing?

what @AdSchellevis is trying to say:

please quantify and qualify "several missing features"
please qualify "unusable config files"
please tell us if you have tested the latest version19.1.2 -- at least one bug you mention has been fixed so it would save you the time reporting it ;)

Cheers,
Franco

I don't know if this was included before, but the docs say there should be an export option named "OpenVPN Connect" but there isn't. See here where the iOS directions list this: https://docs.opnsense.org/manual/how-tos/sslvpn_client.html#ios
Let me know if this is a separate bug and i'll log it as such.

@Sovenger it's more a documentation issue, the iOS app should accept the standard packages if I'm not mistaken. If someone wants to help out fixing the docs, that would be highly appreciated.

@Sovenger it's more a documentation issue, the iOS app should accept the standard packages if I'm not mistaken. If someone wants to help out fixing the docs, that would be highly appreciated.

I'm happy to update the docs once we nail down what the process should be. I've tried an additional 4 other steps after the point that I linked you to and still wasn't able to get it to work (e.g. messing around with different certs, reformatting the .ovpn file, and importing the certs to the phone's keychain).
What should the docs say?

@Sovenger can you explain what you've tried on your ios device? I'll try the same steps on my iOS device and see what happens.

@AdSchellevis sure!

Follow all steps in the docs here, https://docs.opnsense.org/manual/how-tos/sslvpn_client.html up to the iOS part
From the iOS steps: VPN -> OpenVPN -> Client Export
Under Accounts / Certificates section of that screen, click the download arrow icon on the right of the user line
Unzip the download somewhere on your desktop. You'll have three files: .key, .ovpn, and a .p12.
On your phone, download the OpenVPN Connect app.
On your desktop, plug in your phone with a USB cable
Open iTunes
Click the mini phone icon in the upper left header area
Click File Sharing, in the left menu
Find and clickon the OpenVPN app
In the right pane, scroll down to the bottom and click Add File
Find and select all three files to upload
May need to click sync, however, mine auto-synced. YMMV
Open the OpenVPN app on the phone and it should list both the p12 and .ovpn profiles as ready to import
Click "Add" on each of them. The cert will ask you for a password, just hit OK (blank pw)
Everything SHOULD be ready now. Click the connect slider on the new profile. It'll try to connect, ask for a password and token, input it and then it'll fail.

ok, just tested this on my device, very easy.

install the ios client (same as you already did)
go to the exporter and choose "File Only" which is the default for most embedded device types (this includes all the required cert in text mode)
go to iTunes, drop .ovpn profile onto the iOS devive
go to the iOS device and connect.

That's basically all :)
You can find our docs repository here https://github.com/opnsense/docs

@AdSchellevis that worked :).
I'll look at getting these documentation changes into a pull request.
@xenorites back to you.

@Sovenger thanks in advance!

Missing features:

Yealink Phone Export (separate issue exists)
Inability to use Windows Cert Store

Unusable config issues:

Having the "Validate server subject" box checked results in a server validation error when attempting to connect - it appears to attempt to use the full subject in the config produced, but this causes issues. Solution was only name verification.
The config files produced have the protocol capitalized, which neither the Gnome GUI nor the OpenVPN Windows binary support. Solution was lower-case protocols in the config file.

I have not had time to test; only discovered the issues while setting up some new users. I will try and take some time later this week or this weekend to do further digging into any issues or solutions.

timeout
(Windows cert store fixed in https://github.com/opnsense/core/issues/3500)


Vec2i, Vec3i, Vec4i are unnecessary?

What is the purpose of having HMM_Vec2i, HMM_Vec3i, and HMM_Vec4i? All three functions simply cast their integer arguments to floats. And there is no loss of precision when converting int to float, so compilers should be able to do this conversion implicitly in the float versions of these functions.
(This may just be my relative inexperience programming in plain old C.)

So, i dont know if this is a good reason or not. MSVC gives a warning if you put int into a function that takes a float argument so it generates and if you used Vec2i for creating a vector of "ints" it will not generate a warning that way.

So i kinda think that they are worth keeping just to keep the warning amount at a minimum

Good enough reason for me! (MSVC sounds very frustrating though!)

@bvisness It is im pumping out a lot of these bugs expect a commit within the next hour. Is the unit test up and running?

Not on Travis yet, but I can run them locally and report back. (I'll look into the Travis config now that it's merged.)


file-drop element improvements

There are a number of improvements that we can make to the file-drop element that are not directly related to the needs of the app. (see https://github.com/GoogleChromeLabs/squoosh/pull/56 for more context)

[ ] Add enter and leave events
[ ] Add .files support to ondrop (filter...)
[ ] Add valid/in-valid events that map to the css class changes.

Marking as V1, as I think the element needs to support these things to be useful externally.


Use apivalidation.ValidateImmutableField instead of field.Forbidden

What would you like to be cleaned:
When validating CRDs, we should use apivalidation.ValidateImmutableField instead of field.Forbidden for simplicity.
Also discussed here https://github.com/kubernetes-sigs/kueue/pull/1081

/assign


How to use keyboard navigation?

Keyboard navigation has not been implemented yet. As a requirement, I will implement it in future versions


Develop Go webhook integration WIP

In regards to #38 request. Posted status/questions in issue tracker

Automated message from Dropbox CLA bot
@corykitchens, it looks like you've already signed the Dropbox CLA. Thanks!

@corykitchens just wanted to check in on whether you're going to have a chance to finish this anytime soon.

@tomaszkolek I think you could take over finishing this integration if you'd like.

Closing since this system has been redone in the interim and the PR has been stalled for a full year.


[TBDGen] Remove InstallAPI Flag logic

The linker & TAPI doesn't use it anymore.
We should likely remove the command line options for this too but that might need to be staged, this unblocks downstream CI for now.

macOS test failures look fixed by: https://github.com/apple/swift/pull/64077
I'll retry.

@swift-ci please test


Is the Ergodox-EZ opensource?

I've looked at other open source keyboards, and found downloadable PCB designs. I don't see that here. Are those designs available?

@dmgm you can find the PCB designs for the Ergodox here: https://github.com/Ergodox-io/ErgoDox/tree/master/ErgoDOX pcb
You can also find the CAD-files for the original Ergodox case in that GitHub-project:
Quote from the original ergodox webpage (https://www.ergodox.io/):

The entire project (including this website) is open source, allowing you the freedom to modify and tweak the project as you see fit.

However I'm not sure about the openness of the Ergodox EZ's designs with additional changes to the original case, the metal legs and the hand rests.

If I'm wrong tell me, but the Ergodox EZ had toolless change switch sockets. I believe using the kailh sockets. Use of that socket requires a PCB update. I havent downloaded and opened the ergodox-io pcbs, but I dont think they have been modified to use this alternative mechanism.
Hense my question as to whether the PCBs used by Ergodox-ez where open source. I dont this they are, but I woun't be surprised if people think they are buying an open source hardware keyboard.

@dmgm I did not know that :+1: I assumed the Ergodox EZ used the original PCB design.
Looking at the Ergodox EZ website it only mentions that the open-source firmware QMK is used, but nothing about the hardware designs.
I guess we can assume that none of the hardware designs are open-source, since the website doesn't claim that they are and there are no repositories containing hardware designs.

I think you are correct. I had hoped that this git repository was controlled by someone from ergodox-ez and I would get a definitive answer.

@dmgm well, the owner of Ergodox EZ is @ezuk. So, he would be the person to ask for a definitive answer :slightly_smiling_face:

@ezuk could you please provide a definitive answer?

@dmgm let's see if we can get current pcb designs, checking with my partners.

Just uploaded the schematics for V5!


Unable to connect to Grammarly

The Error
When I go through the process of connecting to my Grammarly account, after accepting the xdg-open request, vscode gives the following error:
Request $/handleOAuthCallbackUri failed with message: Minified error #8: See https://developer.grammarly.com/docs/error-explainer?code=8&args=vscode%3A%2F%2Fznck.grammarly%2Fauth%2Fcallback%3FwindowId%3D1&trace=Error%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A60282%0A++++at+Generator.next+%28%3Canonymous%3E%29%0A++++at+bt+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26642%29%0A++++at+o+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26846%29%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26907%0A++++at+new+Promise+%28%3Canonymous%3E%29%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A26786%0A++++at+Ve+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A60396%29%0A++++at+https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A90543%0A++++at+t.SDK.handleOAuthCallback+%28https%3A%2F%2Fjs.grammarly.com%2Fgrammarly-sdk%401.7%3A17%3A90565%29 for details.

The URL referenced gives the error: Invalid oauth callback url: vscode://znck.grammarly/auth/callback?windowId=1
The same error happens in both vscode and vscode-insiders. This is using the release version of the extension.
System Information
This is on Fedora 37.

I see the same problem both on Ubuntu 18.04 and Mac Mini M2 chip.

Confirming it happens within WSL2 (Debian 11). Same error message.

Confirming it happens on Windows 10, with vscode version 1.75.1 (user setup) with Grammarly extension version 0.22.1

Confirming it happens on Windows 10, with vscode version 1.75.1 (user setup) with Grammarly extension version 0.22.1

Same.

same on Windows 11 here
Edition	Windows 11 Pro
Version	22H2
Installed on	10/5/2022
OS build	22621.1265
Experience	Windows Feature Experience Pack 1000.22638.1000.0

Can confirm the same issue on M1 Pro MBP.

Same error. I have found a workaround to get the extension working:
Go to the extension page, click the arrow beside Uninstall button, and select "Install Another Version..." Select v0.18.0, and reload VSCode. Try going through the process of connecting to your Grammarly account. After connecting successfully, you can update the extension to the latest version.

Can confirm that workaround works for me too! Many thanks!

Go to the extension page, click the arrow beside Uninstall button, and select "Install Another Version..." Select v0.18.0, and reload VSCode. Try going through the process of connecting to your Grammarly account. After connecting successfully, you can update the extension to the latest version.

The earlier version worked, but updating to the latest version brought back the same error for me.

The earlier version worked, but updating to the latest version brought back the same error for me.

For me, after logging in the extension kept working even after updating to the latest version.

The latest version of the extension works for me so I am closing this issue

I found that I couldn't log in no matter what after not using the plugin and Grammarly desktop app for a long time (tried rolling back to 0.18 and preview versions), but everything seemed to be normal after I installed the desktop app and logged in. The official version of the plugin can work normally without requiring me to log in. I don't know if my experience is valuable information.


Improved webtoons folder naming

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #262)
[ ] a new Ripper
[ ] a refactoring
[ ] a style change/fix

Description
The ripper now includes the site name in the album title
Testing
Required verification:

[X] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[X] I've verified that this change works as intended.

[X] Downloads all relevant content.
[X] Downloads content from multiple pages (as necessary or appropriate).
[X] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[X] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

Coverage remained the same at 25.217% when pulling 7a24637b08a26a022f390b72025582f666b1133a on cyian-1756:webtoons into 1000fb78e8aaf37d92419eccac9cd958f301f043 on RipMeApp:master.


Failed to set UI/GPU task runner priority

Everytime i run my program i have a run-time error:
E/flutter ( 2059): [ERROR:flutter/shell/platform/android/android_shell_holder.cc(138)] Failed to set UI task runner priority
E/flutter ( 2059): [ERROR:flutter/shell/platform/android/android_shell_holder.cc(132)] Failed to set GPU task runner priority
$flutter doctor -v
[✓] Flutter (Channel stable, v1.17.1, on Linux, locale en_US.UTF-8)
• Flutter version 1.17.1 at /home/myname/Development/flutter/flutter
• Framework revision f7a6a7906b (5 days ago), 2020-05-12 18:39:00 -0700
• Engine revision 6bc433c6b6
• Dart version 2.8.2
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /home/myname/Android/Sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /snap/android-studio/88/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Android Studio (version 3.6)
• Android Studio at /snap/android-studio/88/android-studio
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build
1.8.0_212-release-1586-b4-5784211)
[✓] Connected device (1 available)
• Anbox • emulator-5558 • android-x64 • Android 7.1.1 (API 25) (emulator)
• No issues found!

Hi @ageorg06
could you check if it happens with newer android version?
could you provide a complete minimal code sample / app to reproduce it?


Display analytics for one specific VirtualHost

Let's goaccess -f access.log with 1 week of logs. The panel > 9 - Virtual Hosts displays:
 Hits   Vis.      %   Bandwidth Data
 ------ ---- ------ ----------- ----
 ...
 11089   290  5.83%    4.14 MiB www.sitea.com
 4873    348  2.56%  443.20 MiB www.siteb.com
 2606   1258  1.37%  465.10 MiB www.sitec.com
 2159    454  1.14%  193.24 MiB www.sited.com

How to ask GoAccess to display analytics for sitea.com only, for each day (without exiting goaccess and doing a CLI command) ?
Example:
www.sitea.com   oct-18       56 visits
www.sitea.com   oct-17       36 visits
www.sitea.com   oct-16       192 visits
...

Currently not possible without doing some preprocessing (e.g., grep, awk, etc), however, #117 will definitely cover this. In fact, the filtering feature is the next big update that GoAccess will get, both in the HTML side and the terminal side :)

Thanks for this answer @allinurl!
Do you already have a beta test version that has this feature? I'd love to test this, because without this, I can't use GoAccess (I have 10 virtualhosts and I need to see which traffic comes from where)
Congrats again for this tool!

Unfortunately no beta yet.

Isn't this yet available? I need to filter output only for a single host and ignore the rest lines of access log file.

@mohsen Working on #117 as we speak. Stay tuned as it will be out rather sooner than later.


Streamline management of contact details

How are contact details currently managed?

organisations?
users?
metadata contact?
etc

Ideally contact details are entered once and can be re-used
Some contact fields can be populated from or linked to existing or new user accounts
Some contacts (like the data contact at a custodian) might never be users but might need to be repeated / re-used across metadata records - how to manage these?

for organizations, CKAN saves the organization information in several tables in the database,  the group table being the most direct, there is also a member table which holds relations between users, groups ..etc., every organization has several roles where each connected to an account, a "member" role has the ability to view metadata records authored by the org, "editor" role has authorship capabilities, "admin" role can add other accounts to the org.

users contacts are saved in user table in the database, it holds regular contact info as name, password, email,  static data as user profiles are handled via links as opposed to local storage, more elaboration is needed on "Ideally contact details are entered once and can be re-used" as the current model saves contact into in this table in a central way, it appeals to the browser behavior on entering contact details to login vs caching the details, if SSO is needed please specify so and relate to an existing RF.

more elaboration is needed on the meaning of "metadata contact", if a user is a part of an organization system, they will be able to interact with metadata records according to their roles, hopefully the notification system will notify different contacts in one org about the latest changes to a specific metadata record.

the number of contact fields is limited, it's hard to tell which field are you referring to and the functionality you want to achieve, is there any RF about this ?,  "Some contact fields can be populated from or linked to existing or new user accounts".

do you mean that these custodians are out of the system completely "not users" ? as far as CKAN allows, users do not have to be members of an organization to be able to collaborate, there is the notion of dataset collaborators which can be enabled to allow some users accessibility to certain metadata records without them being a part of an organization, but they still have to be a registered on the system as "users",
"Some contacts (like the data contact at a custodian) might never be users but might need to be repeated / re-used across metadata records - how to manage these?"

closing for lack of activity, please re-open if appropriate

leaving open to investigate during maintenance, was not on the project board in any case


Date display in banner has undefined NaN

Mac 10.14.6, Chrome 76.0.3809.100

I'm taking a look at this one.

Confirmed that this is working fine now.


Encrypt secrets

Add a one-time key that is used to encrypt the content and appended to the retrieval link.

Closed in https://github.com/madebyraygun/pssst/commit/a66b331b5149e2a2f132fde44cf90181fc69ee6d


Feature/issue 445 deprecate model write csv

Summary:
Remove write_csv methods from generated model code.
Remove lots of lint from generator.hpp
Intended Effect:
Make code easier to maintain and remove buggy code that wrote in the wrong order and was confusing people looking at the program C++ code.
How to Verify:
Look at generated model code.
Side Effects:
Any code that might have dependenced on write_csv().  But that code probably would've been broken because the header writer and value writer weren't matched.  These can be replaced with the newer array-based methods.
Documentation:
None.
Reviewer Suggestions:
Anyone.

Looks good.


Latest github doesn't build - Can't find gamepad.h (MacOSX)

In file included from /Users/graham/Documents/Code/github/Polycode/Core/Contents/Source/PolyStemGamepad.cpp:1:
/Users/graham/Documents/Code/github/Polycode/Core/Contents/Include/PolyStemGamepad.h:6:10: fatal error: 'gamepad/Gamepad.h' file not found [2]
#include "gamepad/Gamepad.h"
Freshly cloned PolyCode, build the debug & release versions on Mac.  Seems the gamepad dependency isn't being build correctly.
(Also the libpng md5 is incorrect.  I updated the script to use 1.5.7 and changed the md5 and that worked)

Fixt.


Refactor: normalize axis

Please review ~#5953 and~ #5964 first.
~This also fixes  #4486.~

I'll kick the CI after #5964 is merged.

/test mini

Jenkins CI test (for commit 7797d4c00957c82126913321e6db985056dadad4, target branch master) succeeded!

I should not ban cupy.sum(x, axis=[0]) in this PR with label cat:code-fix.
FYI,
x = [1, 2, 3]
numpy.sum(x, axis=[0]))  # => TypeError("'list' object cannot be interpreted as an integer")
numpy.mean(x, axis=[0]))  # => TypeError('an integer is required (got type list)')
numpy.median(x, axis=[0]))  # => 2.0

Seems some tests need care for the case axis=None.


 Nice work

(Once your tests have stabilized, create ticket(s) for them in your milestone and then rebase the commits onto those tickets)

Thanks @alexanderdean ! Will do

the CI results in this case are not relevant I don't think

The Base64 implementations for the JVM are notoriously fickle across different JVMs/classpaths etc!

This looks great @ninjabear - next step for me is to build this as a release candidate and get it running for some existing jobs to confirm no regressions...

Cool! Fingers crossed!


Locale full names should display consistently

Noticed when testing - I suspect this may be a function of the library we're using to generate locales and it might be arguably grammatical in some sense of the locale/language's own rules as to whether or not it should be capitalized, but we should probably normalize the display in our generated components in some way.

Screenshot description: a language selector showing:
* English
* Faroese
* français
* Deutsch

Would be interested in @BlueSlug's input on this but my understanding is that en français, languages are not capitalized. Thus the endonym for the French language is not capitalized. Am I correct in that understanding, @BlueSlug? I agree it looks odd in this context but I'm not sure capitalizing for consistency would be the best approach. It's easy enough to do if we decide that, though, using Illuminate\Support\Str::ucfirst().


build_mrbconf.h

With this patch mruby build system can separate mrbconf.h macro and compiler flag macro.
To use mrbconf.h macro use MRuby::Build#enable_mrbconf method to enable specific macro easily instead of appending to defines property.
(if you need to enable MRB_GC_FIXED_ARENA call enable_mrbconf :gc_fixed_arena)
Additionally when you change mrbconf in build_config.rb the whole code would be recompiled with new mrbconf so that it's safer.
Though it has some limitation:

it can't specify macro with value
it can't disable mrbconf
it can't detect conflict of mrbconfs

I'm not sure we should allow building separate configs, as this also complicates the build system.
Is there another way we could introduce this feature outside of the current scope?


fix: ignore openshift-origin-oauth-proxy image

Problem:

Solution:

Related Issue:
https://github.com/harvester/harvester/pull/5787
Test plan:

@mergifyio backport v1.3


fix(cloudflare): import notImplemented using a relative path

This was trigering the following error:
-> % npx wrangler dev

 ⛅ wrangler 3.91.0
-------------------

✘ [ERROR] Build failed with 1 error:

  ✘ [ERROR] Could not resolve "src/runtime/_internal/utils"

  node_modules/.pnpm/unenv@file+..+unenv/node_modules/unenv/runtime/node/module/$cloudflare.mjs:53:31:
        53 │ import { notImplemented } from "src/runtime/_internal/utils";
           ╵                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    You can mark the path "src/runtime/_internal/utils" as external to exclude it from the bundle,
  which will remove this error.

edits:

the cumprit is this PR last week by me
I create https://github.com/unjs/unenv/issues/357 to try to solve this at build time

Is this the only case of this kind of import?

yes - I amended the description, you might not have seen it, that's something I introduced last week.
Existing import are relative.

I assume that there is some tsconfig.json setting to make src based imports work within this repo? (Perhaps baseUrl - https://github.com/unjs/unenv/blob/main/tsconfig.json#L3?)

If there is stuff like that going on in the repo, I would expect there to be some transpilation happening when the package is compiled to JS that would update these imports to work in vanilla node? Why didn't that happen? Perhaps an alternative fix would be to ensure that unenv's build step fixes these imports automatically?

As of before this PR, the transpiled code (in dist/) would contain import { notImplemented } from "src/runtime/_internal/utils"; which is not a valid path.
It should be possible to detect that at build time, I'll create an issue. For now, let's merge the fix if it looks ok.

It should be possible to detect that at build time, I'll create an issue. For now, let's merge the fix if it looks ok.
👍


roc-1.7.x rc4 updates

LGTM, but I'd like to add #54 "[asm] Transform options for assembler" to this release candidate as well.


Use relative -> absolute positioning hack (...)

(...) in order to position the TOC automatically no matter the height of the navbar.

Currently, the TOC is positioned with a position: fixed;, which means that the TOC must know the height of the navbar (which turns into a mess if a logo image is added).
This patch will move the TOC up in the DOM, right inside the vuperess-theme-blog__post-layout element.
Then it will use the "relative -> absolute" CSS hack, which will make the TOC absolutely positioned accounting from the vuperess-theme-blog__post-layout element, instead of the upper left corner of the screen.

Without this patch:

With this patch:


Add str in conversion to stop toml.type from being encoded and breaking markdown mode

📝 Summary
Saving a new markdown file with a user specified default width, causes breakage since tomlkit loads wrapped types as opposed to raw python types. The result of saving or creating a new md notebook gives something like:
---
title: Example
marimo-version: 0.6.22
width: !!python/object/apply:tomlkit.items.String
- !!python/object/apply:tomlkit.items.StringType
  - '"'
- medium
- medium
- !!python/object:tomlkit.items.Trivia
  indent: ''
  comment_ws: ''
  comment: ''
  trail: '

    '
---

Ideally, you might consider casting config loads to be the raw python values.
To replicate, set your default to something that is not "compact".
Then do marimo edit example.md (assuming example.md doesn't exist). Make a change, and try to save. View the raw file.
🔍 Description of Changes
Just run str on frontmatter inputs, this is safer, even if the toml config is properly converted.
📜 Reviewers
@akshayka OR @mscolnick

for reference: https://github.com/python-poetry/tomlkit/issues/43


Moved the range logic into the gesture recognizers

What
This fixes a bug that makes the links very hard to tap, they are only tappable if you hold your finger for at least 0.5 seconds. Due to the touchesBegan is the one getting the range, but is called AFTER the TapGesture.

Thank you!


make install creates /usr/include/hyprland/wlroots/wlr/config.h.in when .in should be dropped

Description
This is a bug in the original wlroots project, and i'm way too lazy to wait for upstream to realize it.
Essentially, when it attaches the include/ directory in the meson build from wlroots, it doesnt rename the files correctly, leaving a "config.h.in" and "version.h.in" when both should have their .in extension dropped. I figure this is a decent thing to add to the already existing "fixwlr" make task, since it would simplify building from an external perspective.

This is a bug in the original wlroots project

No, the gettext files are used by meson to generate config.h, meson install doesn't copy them.
Essentially, when it attaches the include/ directory in the meson build from wlroots, it doesnt rename the files correctly
make install copies these gettext files  because in the following line, *.h* glob matches *.h.in.
cd subprojects/wlroots/include && find . -name '*.h*' -print0

This should be harmless.

So are you saying its a bug in the hyprland make? Upon building I did not see a "config.h", though I did see the ".in" equivalent

Fair, i'll leave the issue open in case someone else is faster, if not i'll submit a pr soon

This is a bug in the original wlroots project, and i'm way too lazy to wait for upstream to realize it.

Hyprland is no more wlroots. Should it be closed?


Problem when i ran demo.py

Traceback (most recent call last):
File "demo.py", line 90, in
main()
File "demo.py", line 67, in main
net.load(DEFAULT_WEIGHTS)                        # load downloaded weights
File "/home/zhangq/anaconda3/lib/python3.6/site-packages/torch/nn/modules/module.py", line 518, in getattr
type(self).name, name))
AttributeError: 'ResidualGRUNet' object has no attribute 'load'

Sorry to reply late, you may try the new version.


SSL conf module is added too late

If you configure openssl.cnf as expected i.e. to contain:
openssl_conf = default_conf

[ default_conf ]

ssl_conf = ssl_sect

[ ssl_sect ]

sapps = sapps_sect

[ sapps_sect ]

Protocol = ....

It will not work when openssl s_client is called with '-ssl_config sapps' option.
openssl s_client -ssl_config sapps ...
Error using configuration "sapps"
139853230610176:error:25066067:DSO support routines:dlfcn_load:could not load the shared library:crypto/dso/dso_dlfcn.c:113:filename(libssl_conf.so): libssl_conf.so: cannot open shared object file: No such file or directory
139853230610176:error:25070067:DSO support routines:DSO_load:could not load the shared library:crypto/dso/dso_lib.c:161:
139853230610176:error:0E07506E:configuration file routines:module_load_dso:error loading dso:crypto/conf/conf_mod.c:222:module=ssl_conf, path=ssl_conf
139853230610176:error:0E076071:configuration file routines:module_run:unknown module name:crypto/conf/conf_mod.c:164:module=ssl_conf
139853230610176:error:14187071:SSL routines:ssl_do_config:invalid configuration name:ssl/ssl_mcnf.c:152:name=sapps
The reason is that the SSL conf module is added too late as it is added after the default configuration file is already loaded.
This patch basically fixes the issue, however I understand that it is not portable.
diff --git a/crypto/conf/conf_mall.c b/crypto/conf/conf_mall.c
index 4e7a434..1c8f289 100644
--- a/crypto/conf/conf_mall.c
+++ b/crypto/conf/conf_mall.c
@@ -7,6 +7,8 @@
  * https://www.openssl.org/source/license.html
  */

+#define _GNU_SOURCE
+
 #include <stdio.h>
 #include <openssl/crypto.h>
 #include "internal/cryptlib.h"
@@ -15,10 +17,16 @@
 #include <openssl/asn1.h>
 #include <openssl/engine.h>

+#ifdef HAVE_DLFCN_H
+# include <dlfcn.h>
+#endif
+
 /* Load all OpenSSL builtin modules */

 void OPENSSL_load_builtin_modules(void)
 {
+    void (*SSL_module_add_fn)(void);
+
     /* Add builtin modules here */
     ASN1_add_oid_module();
     ASN1_add_stable_module();
@@ -26,4 +34,9 @@ void OPENSSL_load_builtin_modules(void)
     ENGINE_add_conf_module();
 #endif
     EVP_add_alg_module();
+#ifdef HAVE_DLFCN_H
+    SSL_module_add_fn = dlsym(RTLD_DEFAULT, "SSL_add_ssl_module");
+    if (SSL_module_add_fn != NULL)
+        SSL_module_add_fn();
+#endif
 }

Probably the load of the SSL conf module code should all be moved to libcrypto as otherwise for applications using just the libcrypto although they do not care about the SSL conf stuff they would still encounter the libssl_conf.so load errors.

Please try out #4792, I do believe that fixes your issue.

Yes, that fixes the issue with openssl apps. The remaining question is what happens if some 3rd party application calls OPENSSL_init_crypto() but uses some shared library that uses libssl for TLS communication (and calls itself OPENSSL_init_ssl()).

As a test I tried to call both OPENSSL_init_crypto() and OPENSSL_init_ssl() in the apps_startup() and as expected this makes it not to work correctly again. So yes, the #4792 fixes the issue for openssl app but it is not completely general solution.

Generally speaking, we're thinking that an application shouldn't need to use OPENSSL_init_crypto or OPENSSL_init_ssl, as these are called internally when needed.  Secondly, I'd say that an application that knowingly uses anything that ends up calling libssl routines should call OPENSSL_init_ssl before OPENSSL_init_crypto, if that's at all needed.
Remains, of course, cases when the load and use of libssl isn't a known fact, or when it so happens that OPENSSL_init_crypto gets called first, for whatever reason...  I'll dive into this.  @mattcaswell, if you have any ideas around this, it would be helpful.

The whole point about OPENSSL_init_crypto() and OPENSSL_init_ssl() was that they (in most cases) should be implicit and called automatically. Similarly you shouldn't need to explicitly clean up the library. In previous version of OpenSSL there has been the problem where two different libraries loaded by an application both have a dependency on OpenSSL and then they have a battle about initialisation and de-initialisation. In that scenario you could easily envisage a case where one external library has a dependency on libcrypto (only) and one has a dependency on both libcrypto and libssl. Depending on the order these external libraries get called then OPENSSL_init_crypto() could get called before OPENSSL_init_ssl(). Unfortunately I don't have any great ideas for solving it... :-(

Well, my patch above actually solves it, but unfortunately it is a hack and not something that could be committed.
On the other hand as loading the configuration is done explicitly only when OPENSSL_init_crypto() is called with OPENSSL_INIT_LOAD_CONFIG I suppose this might not be a pronounced problem in real world.

Right...  and the hack could be made useful, as that's basically a poor man's implementation of weak symbols, so to speak.
Another thing I'm considering is lazy evaluation, i.e. read a process the config file as late as possible.  In other words, CONF_modules_load_file and friends could just register the file name, but the actual reading would only happen the first time anyone tries to use its values.

Cancel the lazy evaluation idea, it was a bad one...

@t8m, you're actually more right than you might know...  I needed to re-read the manpage to jog my memory about this all.
The relevant section (from https://www.openssl.org/docs/man1.1.0/crypto/OPENSSL_init_crypto.html):

Numerous internal OpenSSL functions call OPENSSL_init_crypto(). Therefore, in order to perform non-default initialisation, OPENSSL_init_crypto() MUST be called by application code prior to any other OpenSSL function calls.

I find it troublesome, though, that only OPENSSL_init_crypto is mentioned here.  @mattcaswell, what would you say about the idea of merging the OPENSSL_init_crypto and OPENSSL_init_ssl manual pages into one for 1.1.1?

My guess is that they were separate because crypto and ssl were separate subdirs until recently.

Yes, that's my guess as well.

Yes that was the reason. I have no problem with merging the pages.


Spelling - remaining code changes

Summary of the Pull Request

References
#3741

PR Checklist

[ ] Applies to #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@ryanbodrug-microsoft
can you assign someone from your team to review this PR? Thanks.


ingress: Skip gateway servers with mutual TLS configured

When mutual TLS is configured on the gateway, a probe is attempted, but is rejected because the caller does not have a client certificate present. With the knative-ingress-gateway configured like the following:
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - '*'
    port:
      name: https
      number: 443
      protocol: HTTPS
    tls:
      credentialName: knative-ingress-gateway-tls
      minProtocolVersion: TLSV1_3
      mode: MUTUAL

The v0.13.2 networking-istio operator dumps log lines like the following:
{
    "level": "error",
    "ts": "2020-04-19T00:47:41.053Z",
    "logger": "istiocontroller.istio-ingress-controller.status-manager",
    "caller": "status/status.go:378",
    "msg": "Probing of https://hello-world-hello-world.ai1.cluster.k8s.local:443 failed, IP: <IP_ADDRESS>:443, ready: false, error: error roundtripping https://hello-world-hello-world.ai1.cluster.k8s.local:443: remote error: tls: alert(116) (depth: 0)",
    "commit": "aa470a6",
    "knative.dev/controller": "istio-ingress-controller",
    "stacktrace": "knative.dev/serving/pkg/network/status.(*Prober).processWorkItem\n\tknative.dev/serving/pkg/network/status/status.go:378\nknative.dev/serving/pkg/network/status.(*Prober).Start.func1\n\tknative.dev/serving/pkg/network/status/status.go:276"
}

TLS alert 116 is certificate_required.
The change is to detect when a gateway is setup for mutual TLS and skip attempting to probe the gateway. In the example above, this will result in 0 probe targets being generated, which is reasonable as this isn't a common or likely "supported" configuration. Regardless, the changes included allow the system to enter a ready state rather than being stuck with IngressNotConfigured forever (even though traffic works).

/ok-to-test
/assign @JRBANCEL

/test pull-knative-net-istio-latest
Looks like a unrelated failure (maybe) - trying again.

/lgtm
🚀

/approve


Break Stories page into components

discussion piece

We need to identify components that are unique to this page and one that can be used in the app.

Components
I've made some presumptions here if you can clarify @mar-bi this will help for the next pages 👍
Excuse my shaky hand 😸

So, top is the nav, correct?
So if you can clarify what the other dark boxes are that would be great 💯
The only thing other than those I can identify would be:

stories container
stories card
the buttons
search

So, top is the nav, correct?

Yes, absolutely. Your identification of components is correct.  :+1: :mag:
Here I try describe the page components from the top to the bottom of the page.
We have:

Header (grad.then() + navigation menu)
Dashboard (heading with the name of  the page + some text + a button)
Main:

nav - a filter for stories ("latest", "oldest", "craziest" :grinning: )
search box
stories container with stories cards
pagination (a small black box right down the stories container) - shows pages with arrows

Footer

Story card contains:

image or avatar (dark circle)
heading of the story
paragraph of story text
button

Ok, so StoryCard will be an issue in it's own right to go into the Components project?
Components project isn't a thing yet, feel free to create it 👍
we'll get a checklist going on the main ticket for the components identification project 🎉

Yes, StoryCard have to be an independent issue.
Story Project have to be created to, and checklist will help to track the identification.

closing this now, all items listed on #21


Export new icons from Figma

@equinor/eds-ux exported icons can be seen here https://github.com/equinor/design-system/pull/2272/files


How to remove the lines of the calenderView i dont want to see the lines of each day

you can manage line using  function topMarkerSetup() in   CVCalendarDayView.swift
you can do whatever you want to do  with line

thankz keval it helps me a lot


Tooltip directions vary wildly in the list

All tooltips should follow the 'tooltip on top' design, unless otherwise noted.
http://www.patternfly.org/pattern-library/widgets/#tooltip

outdated - closing


Create a contact info block

Add links to social networks (LinkedIn, Facebook, Instagram), phone number, email, Telegram username, etc.

Odessa, Ukraine
<EMAIL_ADDRESS>https://www.linkedin.com/in/serghei-filimonov-6a2963120


Cannot type until extension host is started

We need to figure out where we can take a shortcut. My thinking is that https://github.com/Microsoft/vscode/blob/master/src/vs/platform/commands/common/commandService.ts#L23 could be the place

if this is positive we go run the command send the activation event afterwards/in parallel. Still, it does introduce a tiny semantic change


Selection of Backup table

System information:

Operating system (distribution) and version linux mint
DBeaver version 6.3.3
Additional extensions

Connection specification:

Database name and version
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
When doing a backup you able to select a schema and table but it does not hold true during the backup. I am not able to just backup a single table.
Steps to reproduce, if exist:
Right click table > tools> backup Select the schema and table to back up click start and all tables will be backed up only if one is selected
Include any warning/errors/backtraces from the logs

Hi @Jnb2387 ,
cannot reproduce an issue. could you test it against 6.3.4 version?

Downloaded 6.3.4 and now unable to backup any table.
Error received says no matching tables were found, when I am selected the table via a checkbox.
/usr/lib/postgresql/12/bin/pg_dump --verbose --host=px-geo02-d --port=5432 --username=dpsdata --format=c -t "permit_review.permit_tracker" geocoder
Task 'PostgreSQL dump' started at Mon Feb 03 12:06:29 MST 2020
pg_dump: last built-in OID is 16383
pg_dump: error: no matching tables were found
Task 'PostgreSQL dump' finished at Mon Feb 03 12:06:29 MST 2020
2020-02-03 12:06:29.418 - IO error: Process failed (exit code = 1). See error log.
2020-02-03 12:06:29.418 - java.io.IOException: Process failed (exit code = 1). See error log.
at org.jkiss.dbeaver.tasks.nativetool.AbstractNativeToolHandler.executeProcess(AbstractNativeToolHandler.java:182)
at org.jkiss.dbeaver.tasks.nativetool.AbstractNativeToolHandler.doExecute(AbstractNativeToolHandler.java:237)
at org.jkiss.dbeaver.tasks.nativetool.AbstractNativeToolHandler.lambda$0(AbstractNativeToolHandler.java:52)
at org.jkiss.dbeaver.runtime.RunnableContextDelegate.lambda$0(RunnableContextDelegate.java:39)
at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)

Got the same issue pg_dump: error: no matching tables were found when tried to backup few tables from schema. Backup works fine when all available schemas and tables are selected.

With 6.3.3 I was able to only backup all tables in the schema, in 6.3.4 I cant backup anything.

@Jnb2387 @amkisko does pg_dump command look valid for you?
Are database/schema/table names correct?
I still can't reproduce this problem but I didn't test it on PG 12 yet.

@Jnb2387 @amkisko does pg_dump command look valid for you?
Are database/schema/table names correct?
I still can't reproduce this problem but I didn't test it on PG 12 yet.

I copied generated command to console and it worked. :)

Yeah same with me, copying the generated command and using it in a terminal worked without issue.

I am experiencing the same behavior (DBeaver version 6.3.4 on Linux Ubuntu 18.04). When all database tables are included in backup the routine completes successfully. When one table is excluded from backup, the routine fails with message, "pg_dump: no matching tables were found". Here are the generated commands from both backup types (text in <> is text that I am providing here instead of the user-specific text in the generated commands):
All tables included in backup:
/usr/bin/pg_dump --verbose --host=<host> --port=5432 --username=<username> --format=c -n "<dbschema>" <dbname>
One table removed from backup:
/usr/bin/pg_dump --verbose --host=<host> --port=5432 --username=<username> --format=c -t "<dbschema.table1>" -t "<dbschema.table2>" -t "<dbschema.table3>" -t "<dbschema.table4"  <dbname>

This seems to be PostgreSQL 12 specific.

I'm actually using PostgreSQL version 10.

@rolandknapp Ok.
What is your local PG client version then?
/usr/bin/pg_dump --version

Maybe the problem is in pg_dump and server version mismatch

More info regarding my case: MacOS, PostgresApp
% pg_dump --version
pg_dump (PostgreSQL) 11.5

And please note:

I copied generated command to console and it worked.

@ serge-rider. The pg_dump version on the client is 10.12 and the PG version on the host is 10.11.

Still having pg_dump issues with version 7.0.0 on Postgres 12

@Jnb2387 "quoting capitals" - is it incorrect? Could you write some example?
@amkisko

And please note:

I copied generated command to console and it worked.

Yes, this made me think that pg_dump invoked directly is a different version of pg_dump.
Otherwise I can't realize what magic brings this bug to life.
Maybe it be caused by invalid identifiers quoting?

I am no longer experiencing this issue with version 7.1.*, any table is now able to be selected and dumped including quoted tables "Test_Table"


[PATCH] enhance check-mime-type.pl: also check property-modified files

[[[
Enhance hook script check-mime-type.pl to also check property-modified files.

contrib/hook-scripts/check-mime-type.pl:

add option to recognize property-modified files for checks
make check for svn:eol-style optional
enhance texts and comments to reflect changes
rename array "files_added" to "files_to_check" to better fit its usage
explicitly mark here document with quotes as interpolating
fix script name in comments
update copyright and license to reflect switch to ASF

Patch by: Matthias Bücher<EMAIL_ADDRESS>Suggested by: Leo Davis [1]
[1]<EMAIL_ADDRESS>]]]

Hello, Please could you discuss this PR on our dev@ mailing list (dev {at} subversion.apache.org) - see https://subversion.apache.org/mailing-lists.html. Attach the patches (either in Git or SVN format) with a .txt extension to your mail. Thanks!

See discussion thread and review at https://lists.apache.org/thread.html/red026ebd7412691b03eb95468993c222dea64443a427be75b2509946%40<dev.subversion.apache.org>

Hi there, sorry for the long delay. I read dev list comments and will re-write history of this pull request. Give me next weekend. Kind regards

Hi there, sorry for the long delay. I read dev list comments and will re-write history of this pull request. Give me next weekend. Kind regards

Thanks! No worries.

Updated the PR with the changes I send to the mailing list on 2020-12-21 16:22 CET. Had to rewrite history.

Updated the PR with the changes I send to the mailing list on 2020-12-21 16:22 CET. Had to rewrite history.

您的来信已收到

@maddes-b Thanks for your patch, committed in r1911931. Sorry for the long delay in getting this sorted!


Comments on 9.2 update

-- 4.x.x should not contain an option "+ 6.X.X-0 Cart Update then 6.X.X-0 MSET".  This never has any benefit over 4.X mset.
-- Attempting to follow this guide with 1.x or 2.x and getting the OTP won't work, because the user is told to skip to part 5, but part 5 includes a copying RedNAND step.  Because they skipped to part 5, they don't have a RedNAND.
-- This guide misses the case of 9.0-9.2 + low/no browser.  (Has it been confirmed that Ninjhax 2 doesn't work on such systems?)
-- Where the guide describes how to do a cart update, it needs to tell the user to delete any downloaded update first.  (Has it been confirmed that the usual method of deleting an installed update does a complete deletion and a cart update will not then try to use it?)
-- Is getting the OTP using the 2.1 method possible on 2.2?

9.0-9.2 with low/no browsers:

One Chinese user failed on 9.2.0-4U, then succeeded on 9.2.0-4U -> 9.9.0-4U -> 9.2.0-20U.
For whom wants to test them again: Cooking Mama provides 9.0.0E, Super Smash Bros. (Only a few versions) provides 9.2.0U, No 9.0.0-9.2.0J exist.

For 1.X and 2.0's shortcut, it should be:

(1) Cubic Ninja OTP (and NAND backup for whom wants unpolluted ticket.db - later NAND backup will not give you an unpolluted ticket.db since installing CIA Sysupdater already installed an illegal ticket on it. FBI's delete ticket option can only disable those illegal tickets. It can't remove them from ticket.db even they're "deleted" which actually = disabled.)
(2) Upgrade to 9.2.0-20
(3) Do some preparations for directly going to Part 5 (actually it's only (1) 9.2.0-20 NAND backup without A9LH (2) Softwares and guide to boot HBL)
(4) Go to Part 5 and ignore Section IV & V

Edited.


[Fix]Conflicting fonts

Montserrat font was added to global.css, but Roboto was left in. Either are good choices, pick one and remove the other import.

I'd like to fix this issue :)
(Merge conflicts broke my last PR also).


Add CI environment conditional back

Description
re: https://github.com/GrantBirki/actions-sandbox/issues/8#issuecomment-1319303604
Issue parser wasn't properly parsing with the changes in this PR when running in the actions-sandbox repo
Testing

ran unit tests

merging for testing with this issue: https://github.com/GrantBirki/actions-sandbox/issues/8


Add Versions Buttons to Mod List View

I found it helpful using a greasemonkey script while using Solder 0.3 to
include a versions button on the Mod List View.
This is helpful when updating mod versions for a modpack, less clicking when you got a big list of updates to install, you can hop straight to the version page as you rarely need the details page anyway once the mod is installed.
So I reimplemented the button properly for the current version of Solder.
The Manage button has been recoloured too so that it fits in with theme, matching the colour order on the Modpack Management View.
Using a width style directly on the th element was the best that I could come up with to keep the buttons on the same line (based off the amount of js being flung about ready to screw it up :) )

Here is screenshot of my modified copy of solder with the yellow Manage button along with the blue Versions button.

This is redundant as per commit  https://github.com/TechnicPack/TechnicSolder/commit/9ac3a64b87843b287e0247cae644a697d138d5ec
e.g. https://github.com/TechnicPack/TechnicSolder/commit/9ac3a64b87843b287e0247cae644a697d138d5ec#diff-5cb3cffc6b4425177a8cf8aff73e2bfdR19
Where I have changed the behavior of the Mod view to default to versions instead of the info first.
I appreciate the contribution but no longer see the need for an extra button since the "Manage" button will now pull up Versions tab first by default.


maintainers/build: skip packages without meta

Motivation for this change
Some packages do not have a meta attribute, and made the script crash.
This will be useful for ZHF: #97479
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 97514 1

@fgaz I would like to use nix-build maintainers/scripts/build.nix --argstr maintainer username on darwin. Is it possible to adjust this script to skip all packages not supported on current platform (darwin)?

@sikmir yes, you could add a check here after the ):
https://github.com/NixOS/nixpkgs/blob/793017e93ab42eb2a8e0b8a9897a64d6655617c9/maintainers/scripts/build.nix#L34-L38
something like && (includesDarwin pkg.meta.platforms) (not sure how to implement inlcudesDarwin. there's probably a function somewhere in nixpkgs that can do that)


Allow optional seed in Stream.scan?

Right now with 2 arguments, it throws a nondescriptive error:
// current behaviour
s = Stream(11)
t = Stream.scan((x,y)=>x+y, s)
//=> stream.js:106 Uncaught TypeError: Cannot read property '_state' of undefined(…)

It is, however, annoying to be forced to provide a seed when you just want to use the current stream value. It would be nice to make the seed optional, assuming it equal the current stream value if missing:
// This would be nice to have!
s = Stream(11)
t = Stream.scan((x,y)=>x+y, s) //=> 11
s(1), t()  //=> 12

In comparision, RxJS does allow for optional seed in their similar method:
https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/scan.md

@dmitriz
Usually when I run into this, its a sign that a stream is receiving data when it shouldn't.
e.g.
Why initialize s with 11?  You could leave s as Stream() and pass 11 to scan.
Maybe that's just for this example, but even in a real world case it boils down to the same decision.
I think it's better to have a single entry point than multiple entry points (where possible).
In the rare case this is needed, you can just pass in s() as the initial value.  So its not a lot of boilerplate.
I'm personally against this change, I think variadic api's and optional arguments lead to less clear code.  I wouldn't want to mimic Rx's API or JS's reduce, its tiny changes like this, that little by little make an API harder to use.  In isolation they seem convenient, but overall the implementation requires more (implicit or explicit) branching, which makes it more likely there'll be bugs and more tests, and more documentation.
Another subtle point I'd like to make re: scan, providing the initial argument is a great opportunity to document in code what the shape of your resulting data structure is/will be.  It's often handy to see it in full inline (or nearby), so that when you write your update function you have a reference.  In this case its just a number, but in a larger application it may be a quite large object, and each case in a reducer may not ever show the complete object, instead it just assigns to it in piecemeal.

Thank you @JAForbes for an excellent explanation!
Not only I agree with all you said but I have even found a serious flaw in my proposal -- you may not even be able in some cases to pass s() as initial value because it might not be of the right type!
I should have picked a better more realistic example. In the real use cases, you supply a stream of actions and scan over it to get the stream of states. Plus, the choice of the sum as reducer is terrible because it has 2 special features: both accumulator and feed are of the same type and the result is commutative. Which make it a horrible choice for an example because it deceives you into wrong intuition.
So let us pick the better reducer that has none of these "flaws":
const reducer = (state: Array<number>, action: number) => state.concat(action)

And now we can initialise our action stream and scan over the reducer to get the state stream:
var actions = Stream()
var states = Stream.scan(reducer, [10], actions)
actions() //=> undefined
states() //=> [10]

After this setup, all we need is simply pipe our actions into the actions stream and our states stream will update itself via reducer with no extra work!
actions(1)
states() //=> [10, 1]
actions(2)
states() //=> [10, 1, 2]
...

And now we can pipe that state stream into our view and render to get it updated.
But what if the action stream already had some data before the scan? Like the last action?
var actions = Stream(1)
var states = Stream.scan(reducer, [10], actions)
actions() //=> 1
states() //=> [10, 1]

So the last action had been taken into account, which might be unwanted. Say your last action was to view specific hotel but now you pass the state representing the full hotel list as seed to the scan. Then the new state will be computed from the last action applied to the seed, which will be that last hotel, instead of the seed itself, which is what you want. So this looks like a flaw in the scan implementation, doesn't it?
And what about passing actions() as the seed? You get a type error!
Which must also happen with RxJS if I understand it correctly.
But sure enough both their examples are addition and multiplications -- both are commutative and have equal types for both args. And you won't discover that problem in those cases. So I'm really puzzled how is their implementation working in general.

Its not necessarily a type error, but in the case of patterns like the Elm architecture it is.

But what if the action stream already had some data before the scan? Like the last action?

This only happens if components seed their own streams instead of letting a parent context do that (which is usually better).  But this isn't a problem, your update will be called with the seed and the value from your actions stream.

And you won't discover that problem in those cases. So I'm really puzzled how is their implementation working in general.

This is exactly right, if you want to fold without a seed in a type safe way, you need to have a notion of empty for that type.  The name for a type that has both concat and empty is a Monoid.
Without an empty value we can't fold without a seed in a type safe way.
Because Stream.scan doesn't know what type we are folding into, we need to provide an initial value, otherwise we're relying on runtime context to make a decision (that's a very Javascript way of doing things) and that's a lot less simple.

So the last action had been taken into account, which might be unwanted.

If the last action is unwanted, then its beyond Stream.scan's responsibility to do that.  Its behaviour is correct and useful.  If you want to dismiss that value, you can decorate your data somehow so your update function can disregard it, perhaps a session increment or some other solution.  e.g.
function update(state, action){
  if( state.session > action.session ){
    return state
  } else {
     ...
  }
}

But that's beyond the responsibility of scan, that's an application concern.  So I don't see how scan is flawed, apologies if I'm misunderstanding you.  😄

Because Stream.scan doesn't know what type we are folding into, we need to provide an initial value, otherwise we're relying on runtime context to make a decision (that's a very Javascript way of doing things) and that's a lot less simple.

Indeed, so it seems the RxJS has this safety "problem", interesting...

But what if the action stream already had some data before the scan? Like the last action?

This only happens if components seed their own streams instead of letting a parent context do that (which is usually better). But this isn't a problem, your update will be called with the seed and the value from your actions stream.

I mean the opposite,  the new component would re-use the existing action stream from the parent, which means it has some old actions from the past that we don't necessarily want to replay on the new component, do we?
We might even expect new actions of new type accounted for in the new reducer, but not necessarily for the old actions, so we might end up with type error. And it feel weird to patch the update/reducer function just to accommodate the single last action that I don't even want :)
I'll probably rather patch the scan method, but
perhaps I am missing something and would love to see a real example with that situation actually occurring (scan over non-empty action stream).

Not a single test with nonempty stream before scan!
https://github.com/lhorie/mithril.js/blob/next/stream/tests/test-scan.js
https://github.com/paldepind/flyd/blob/master/test/index.js

Not a single test with nonempty stream before scan!

Something that needs rectified as per the result of this issue. 😉

has some old actions from the past that we don't necessarily want to replay on the new component, do we?

This is really up to the application.  In many cases this is exactly the behaviour we want, in other cases it would never happen because we only initialise streams at the single entry point to the entire application.
We may want this behaviour if we do not want to consider race conditions from separate systems merging (e.g. a value sent down a stream from a url change, vs a value coming from a server).  Maybe one module is loaded after the other, we shouldn't care, the semantics of emitting the existing value makes streams really easy to predict, it abstracts over the async and sync case, whichever it is, scan, and map will behave in the same way, and emit the same number of times whether the value arrives later, or whether it was already there at the time the other module is initialised.

And it feel weird to patch the update/reducer function just to accommodate the single last action that I don't even want :)

This is an application concern, so it makes sense to have the reducer handle application specific behaviour.

Not a single test with nonempty stream before scan!

Its worth testing, but it also shouldn't be divergent behaviour in flyd/mithril, so the test should just state that both cases emit the same number of times for an existing value and a value that comes later.

Right now with 2 arguments, it throws a nondescriptive error:

I agree we could emit a more descriptive error.  But I don't agree the behaviour should be changed.

has some old actions from the past that we don't necessarily want to replay on the new component, do we?

This is really up to the application. In many cases this is exactly the behaviour we want, in other cases it would never happen because we only initialise streams at the single entry point to the entire application.

Ok, here is my conceptual attempt. I might be wrong of course.
I consider a stream x conceptually as just a collection of values spread over discrete time moments. It is not the same as the function x(t) defined for all times t and constant on the intervals between the events. Why?  Because e.g. a constant function with value 0 over the whole time axis is not the same as that same value 0 being fired at specific time moments. Because we care when the events are fired, rather then when their value changes.
Now the scan method creates new child stream from the parent. When does it emit? Precisely when the parent stream does! But that does not happen at the time of creation of the child. So the new value is computed only at the moments when parent emits at all times, except the time of creation, where it is still computed nevertheless. That just feel conceptually irregular. It might be just me of course.
I am not saying the current implementation might not be useful. It surely can be in some cases. And not so in others. However, you can't simply argue by the usefulness. Not only because it depends on use cases and subjective, but also because usefulness comes from the way it is applied. Which is not necessarily the pure method's responsibility. The method itself, in my view, should behave the most natural and the simplest possible way.
For instance, you define the map(f) over array by applying it to every value. Why? Because it is the simplest rule possible. But you could define it differently, e.g. apply f to all array elements except the last one. Or except the first one. Or both. And in each of these other ways, you still get a functor satisfying all the laws!  So the functoriality is not enough, it is the simplicity or the lowest complexity, e.g. the Kolmogorov complexity if you like :)  The algorithm to define the standard map is shorter, hence the complexity is lower.
The category theory is simply not enough to tell us the difference. We have to use the complexity theory :)
Now, in case of the scan, saying that the reducer is computed exactly whenever the parent stream fires, has lower complexity, than saying it does so BUT also the same reducer is computed at the creation time, even if the parent stream does not emit anything at that moment.
Finally, there is yet another argument. If you really like your reducer to compute on creation, nothing can be easier than that:
scan(reducer, reducer(seed, actions()), actions)

The dead simple composition!
Also very clear and expressive: you apply your reducer to the last action stored and pass it as the new seed.
However, going back the other way is much harder and requires considerable hacks and adding code for no clear benefit.

I consider a stream x conceptually as just a collection of values spread over discrete time moments.

I've ranted about this interpretation of "observables" and marble diagrams, and "arrays over time" at length in the past.  I think we shouldn't think of discrete points in time but a curve, a function, a formula, an infinite continuous curve described by a function.  Why?  Because its more powerful to model our programs using an abstraction that is unaware of discrete points in time.  Its more powerful to take advantage of the abstraction provided instead of focusing on the machinery behind the scene necessary to create it.  If we think of streams as "arrays but over time", or "a Promise but for multiple values" we're defeating the entire point of abstracting over time.
We shouldn't think of individual values, when they arrive, and watching or observing them, reacting to changes and modifying things as a result.  We should think of relationships.
Now back to the problem at hand.  We've got a relationship between a stream a and a scanned stream b.  Our update function can be thought of as a perfect representation of the relationship between a and the resulting outputted b stream.  We shouldn't concern ourselves with individual values, but the constraints formed by our update function.  That constraint is all that matters.
In reality, we can only represent points, single moments and values.  We can't represent the true nature of the relationship, which holds for all values.
What does this update function need, let's look at its signature: ( a, b ) -> a.  It needs two inputs.  Well if our stream a already has an input, and our seed value has also been provided, then we have enough information to emit a value, so it should because otherwise it isn't representing the curve, its representing a slice of a curve, its behavior diverges from its definition.
Now when we say things like "this stream should only emit from this point in time", or "previous value", or even "current value" we're thinking about it all wrong, we're still thinking about time, but that's what we want to abstract over when working with streams.
As I said before, the current behaviour prevents ordering problems and race conditions, it has the same behaviour for both sync and async, and the case you're seeking to prevent would only happen if we're not following best practices of starting our streams separately to our definitions of their relationships.
Note this is all my opinion, and most in the Observable world would disagree with me.  But it's these small, simple points of divergence aggregated that I think make mithril / flyd streams better than the alternatives.  It's not a perfect interface by any means, and there are things I'd like to be change.  But I'm against any core behavior that is aware of time.  That stuff is great in modules for special cases, but it's so much simpler if we can abstract away time and definition order completely.

Note this is all my opinion, and most in the Observable world would disagree with me. But it's these small, simple points of divergence aggregated that I think make mithril / flyd streams better than the alternatives. It's not a perfect interface by any means, and there are things I'd like to be changed. But I'm against any core behavior that is aware of time. That stuff is great in modules for special cases, but it's so much simpler if we can abstract away time and definition order completely.

To comment on this, actually, that is exactly the direction I am trying to head. Abstracting away the time! Only possibly in a different way :)
Take the discrete event model. Forget the timing when the events fired, just keep the order. And now the time is gone and you get the pure array. That is exactly it. The time is abstracted away. We can do everything we do with arrays, no stream, no observable magic.

@JAForbes You might be interested in at least looking at this ES strawman of mine, although that's been put on the back burner while I've been busy with other things, and just rethinking the paradigm in general (I also could use some help making better comparisons).

(n.b. using CoffeeScript here to avoid 100s of parentheses)
I've also been looking into what data types I need for a programming language that's time-independent (it's going to be a GUI-based language for a closed-source project), and so I've been thinking of this a lot. There are several things I've since figured out with that really simplify the model:

There conceptually doesn't need to be an observable difference between a single value and multiple values over time.

You can model constants as just a single value over time, and most stream/observable libraries, and even the ES proposal itself, offer something like Observable.of(value) to emit a single value.
Also, consider the common "end"` event in Node.js event-based APIs. That's only fired once 99% of the time, and usually, if that's the only conceptual "event", a plain callback is accepted.

All values can be viewed as time-independent within some context.

Any time you have an immutable binding, it's guaranteed to be constant for the lifetime of the binding. Same with immutable values and their lifetimes. And when you read a mutable binding not by reference, you will get an immutable value out of it.

All mutable values can be viewed as time-dependent within some context.

Any time you have a mutable value, it can change between reads by very definition of mutability. By corollary, time-dependent values may change between reads, and this is one common way you get race conditions in multithreaded C/C++ programs.
If you also let the setter become observable, and give a subscription access to the binding (even indirectly), you could recursively change it, resulting in similar time-dependent behavior.

You could build most the common stream operators from a small number of primitives:

Source stream

The basic stream data type.

Closeable stream with source stream that emits once on close

This allows the ability to close a stream and observe that closure to, e.g., release acquired resources.

Pipe

Join a source to a transformer.

Read/write cells with source stream that emits the new value on change

This is effectively how mithril/stream and flyd work. You have a single mutable cell that emits the new value on change.

If/Else

Stream that accepts a source stream and on each emit, runs a block and emits to one stream if the block returns true, and another if it's false. In observable terms, it'd be implemented as this:
cond = (observable, test) ->
    o1 = o2 = undefined

    res1 = new Observable (observer) ->
        o1 = observer
        return () ->
          o1 = undefined
          subscription.unsubscribe() unless o2?

    res2 = new Observable (observer) ->
        o2 = observer
        return () ->
          o2 = undefined
          subscription.unsubscribe() unless o1?

    subscription = observable.subscribe
        next: (v) -> (if test(v) then o1 else o2).next(v)
        error: (v) -> o1.error(v); o2.error(v)
        complete: (v) -> o1.complete(v); o2.complete(v)

    return [res1, res2]

Map

Transform a value on change. In observable terms, it'd be implemented as this:
map = (observable, func) ->
    return new Observable (observer) ->
        return observable.subscribe
            next: (v) -> observer.next(func(v)),
            error: (v) -> observer.error(v)
            complete: (v) -> observer.complete(v)

Stream.scan now requires an explicit initial accumulator


Switch to Real SEEREP instance

use the Real SEEREP instance as the data source

We need access to a server on which the seerep can run and will be available for all "digital logbook" instances.

With this we get the build files from the real seerep project
https://github.com/naturerobots/digital_logbook/commit/addae1bb22232b821594bbea01e866e50fafcc69


error: invalid conversion from ‘void*’ to ‘cl_mem {aka _cl_mem*}’

When trying to build with gcc 5.2.0, I get lots of error of this type for src/library/transform/clsparse-csr2coo.cpp (in lines 136, 137, 147, 148, 158, 159, 250, 251, 261, 262). These line involve pCsr and pCoo, which appear to be defined as clsparseCsrMatrixPrivate and clsparseCooMatrixPrivate, respectivelty.
How to fix this?

Hi,
could you please provide more information about your build? Are you using master or develop branch? Are you using OpenCL 2.0?
Thanks.

OpenCL 2.0 and master branch.

The OpenCL 2.0 is not functional yet. Could you please compile it with OpenCL 1.2


Help popup

**** IMPORTANT NOTE FROM Steve: This should not be merged until we've reviewed how well Prismic is going to work for us. *****
Type

[ ] Bug fix
[x] New feature
[ ] Improvement to existing feature

Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-565
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-565
Importance

Description
Added the popup help for species selector and genome browser.
XD:
https://xd.adobe.com/view/d64fc883-dc95-4d08-63a3-483f9c772ec1-a07e/screen/3c8ae70d-629b-4b32-9efb-75a7b58b5d16/help-3a-contextual-2?fullscreen
Views affected

Species selector -> help
Genome browser -> help

Other effects

[ ] I have checked any requirements for Google Analytics
[ ] I have created any required tests
[ ] The PR has as its final commit a WASM/JS update commit if any Rust files were updated.

Possible complications

Need to find out a way to fetch related contents form prismic

refer to: https://github.com/Ensembl/ensembl-client/pull/322 i


refactor MethodConfig by using mocking object created by Mockito

What is the purpose of the change
I noticed that there is a test subclass MethodConfig extends production class AbstractMethodConfig to test the parent production class. This might not be the best priactice in unit testing and can be improved by leveraging mocking frameworks.
Brief changelog

Replace MethodConfig with spying objects created by Mockito.

Checklist

[ ] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8446 (c1c1033) into master (1f64a03) will decrease coverage by 0.72%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8446      +/-   ##
============================================
- Coverage     61.02%   60.29%   -0.73%
+ Complexity      449      446       -3
============================================
  Files          1097     1097
  Lines         44393    44346      -47
  Branches       6469     6437      -32
============================================
- Hits          27092    26740     -352
- Misses        14318    14629     +311
+ Partials       2983     2977       -6

Impacted Files
Coverage Δ

...gcenter/wrapper/CompositeDynamicConfiguration.java
0.00% <0.00%> (-73.34%)
:arrow_down:

...ookeeper/ZookeeperDynamicConfigurationFactory.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...pport/zookeeper/ZookeeperDynamicConfiguration.java
0.00% <0.00%> (-62.86%)
:arrow_down:

...fig/configcenter/TreePathDynamicConfiguration.java
31.42% <0.00%> (-54.29%)
:arrow_down:

.../dubbo/metadata/report/MetadataReportInstance.java
12.50% <0.00%> (-40.63%)
:arrow_down:

.../configcenter/support/zookeeper/CacheListener.java
0.00% <0.00%> (-34.29%)
:arrow_down:

...gistry/client/migration/MigrationRuleListener.java
55.88% <0.00%> (-23.53%)
:arrow_down:

...mmon/config/configcenter/DynamicConfiguration.java
68.18% <0.00%> (-18.19%)
:arrow_down:

...ient/metadata/store/RemoteMetadataServiceImpl.java
38.59% <0.00%> (-17.55%)
:arrow_down:

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
:arrow_down:

... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321789d...c1c1033. Read the comment docs.


[backport] Ensure source array is C-contiguous before copying to CUDAArray

Backport of #5342 by @leofang

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 5c661705ae8107a16123a35cbd9faad874ecf3de, target branch v9) succeeded!


Explore JVM bindings

@tordanik today expressed interest for OSM2World. I just want to start a place where we can have further discussion and track the process of looking into Rust -> JVM bindings.

A quick google tells me that whilst JNI should be easy, its performance is on the way out.
I suggest we align to experiment with JNA: e.g. https://github.com/drrb/java-rust-example or https://github.com/seanjensengrey/rust-jna-example/blob/master/src/main/java/rustjna/Treble.java
Steps would be:

We compile our crate with the C FFI and document the interface
Create an example kotlin or java class to load the library and provide these functions

Should be quick to experiment.


[DRAW-007] Grammatical issues appear in the transcription pop-up tabs

Steps to reproduce:

Navigate to a new transcription.
Select ‘transcribe’ button to prompt transcription pop-up.
Observe each of the tabs (ex: 'Barometer', 'Clouds', etc.).

Recommended result:
Capitalization and punctuation should appear in the transcription pop-up tabs.
Actual result:
Grammatical issues appear in the transcription pop-up tabs.
For 'Temperature and humidity of the Air', the H in humidity should be capitalized. Also, there is a lack of capitalization on the descriptions presently available (under ‘Temperature and humidity of the Air’ and ‘Rain and Snow’ tabs). As such, these descriptions appear completely in lower case, with no punctuation.
Notes:
Tested on:
Google Chrome Version 55.0.2883.87 m, Internet Explorer 11, Firefox version 37.0.1.
Windows 7 Professional x32, Intel Cote i5, ATI Radeon HD 4550.
Repro rate: 5/5.
Screenshots attached: DRAW-007.png
Tiffany Hirsch

This is a content issue, not a bug. These texts are uploaded and editable from the app admin interface


Cartesian: Add infrastructure to support gt4py versioning in future commits

Add infrastructure to support gt4py versioning in future commits.
Changes:

Add version configuration in .bumpversion.cfg
Add version.py submodules with __version__ and __version_info__ attributes to all components
Change setup.cfg and config files in docs to use the proper version value
Add CHANGELOG.md template
Add basic unit tests

bors try


bugfix:fix other orm could not get generated keys

[x] I have registered the PR changes.

Ⅰ. Describe what this PR did

添加RS缓存，防止由于不可scroll导致其他ORM获取不到自增主键值
add rs cache to avoid other orm could not get generated keys when use getGeneratedKeys()

Ⅱ. Does this pull request fix one issue?

fixes #4035
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #4302 (9402ddb) into develop (11d3478) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##             develop    #4302      +/-   ##
=============================================
- Coverage      48.54%   48.54%   -0.01%
- Complexity      3793     3794       +1
=============================================
  Files            724      724
  Lines          24240    24241       +1
  Branches        2971     2972       +1
=============================================
- Hits           11768    11767       -1
- Misses         11230    11232       +2
  Partials        1242     1242

Impacted Files
Coverage Δ

...io/seata/rm/datasource/AbstractStatementProxy.java
84.37% <75.00%> (-1.34%)
:arrow_down:

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
:arrow_down:

...in/java/io/seata/server/session/GlobalSession.java
79.31% <0.00%> (+0.43%)
:arrow_up:

...o/seata/server/coordinator/DefaultCoordinator.java
49.46% <0.00%> (+0.53%)
:arrow_up:


Use httpx instead of requests-async

Is your feature request related to a problem? Please describe.
I just noticed requests-async is mentioned multiple times throughout the project, but the https://github.com/encode/requests-async is archived and https://github.com/encode/httpx is mentioned as a replacement. Perhaps Sanic should recommend httpx instead then?
Describe the solution you'd like
Sanic should mention and work with httpx instead of requests-async.

@honzajavorek Valid point. Let me get this one sorted out later in the day. Thanks for pointing this one out.
When we started using requests-async it was still under development. Looks like we missed the fact that it got archived.

Let me know if I can help.

@honzajavorek PRs are welcome

@honzajavorek  @yunstanford
I did a quick scan on the changes done by the httpx to the requests-async API and there seem to be a considerable difference. Especially on the ASGI side of the things.
Seems like it needs a bit more work than I initially expected. @honzajavorek Please feel free to open a PR. I am more than happy to help you on anything you need.

Sorry guys... that was partially my lapse since I had stepped away for a little bit die to personal reasons. I'm back on this now.
As mentioned, the requests-async package had been under active development. I'll take a look at the changes required because it is a significant requirement for testing. In particular being able to directly reach into the ASGI module without spinning up a server.

Any word on this?

I’m still learning my ways around Sanic. When I’m done with my hobby
project using Sanic I want to take a look at this.
On Thu, 21 Nov 2019 at 02:44, Jay Lucas Mutarevic<EMAIL_ADDRESS>wrote:

Any word on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/huge-success/sanic/issues/1713?email_source=notifications&email_token=AACFGMNGETVDKWW5USCOWVDQUXRZRA5CNFSM4JINLUO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEYDUTQ#issuecomment-556808782,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACFGMJ362GFPRZ5LQOZCTDQUXRZRANCNFSM4JINLUOQ
.

WIP: See #1728

@tomchristie made some greatly appreciated improvements to httpx. Much easier to make it extendable than the previous. I took a first pass to clean up and simplify some of the logic, but there are still some tests that need to be cleaned up.


Add confirm dialog on delete actions

Add confirm dialog modal on delete actions:

users
accounts
storage

Closing as not mergeable in its current state. If the changes requested in the review can be made, we'd welcome a fresh PR! 👍


Conversations panel (inbox)

Gets the inbox panel pretty close. There's a todo to fix up the 'shh' icon but lets do that in a different ticket

@keybase/react-hackers this is ready for a look

@keybase/react-hackers bump

@keybase/react-hackers bump

@keybase/react-hackers bump

github seems fucked


Episode 2: Improved UI for the popup plus...

Episode 2
UI improvements for TodoPopup
also used the new scene unique node system
that Godot 3.5 offers

Done


Update rq_sensor_com.cpp

On some systems, this option was not set properly by default which caused connectivity issues.

Was this already reviewed (internally fi)?

Yes, this was reviewed internally at Robotiq and it is a bug that we had on another code base. We are pushing this on the ROS package as it will certainly improve connectivity for all our users. This was a serial port setting that was not defined and it was therefore "floating" (depending on its existing initialization).


oed: new package at 6.6

Description of package
Portable OpenBSD ed(1) editor. Because all operating systems deserve a good editor.
Checklist

[x] Latest upstream version.
[x] I agree to maintain this package (required).
[x] I agree to notify KISS if I can no longer maintain this package (required).

:+1:


IPv6 connection not working on clients after 24h reconnect

Forum link for reference: https://forum.opnsense.org/index.php?topic=6946.msg31674#msg31674
After the 24 hours reconnect, IPv6 is no more working on the clients. As the forum user mentions it seems that the clients are assigned an old prefix although after reconnect the prefix changed.
I can also confirm that issue. v 18.1_1

Could be #2164, although that was the case since 2016 if true.

I can try to apply opnsense-patch f09eaf7. Will report the next 2-3 days if it helps.

@theq86 thanks! But this will very likely hit 18.1.2 tomorrow anyway.

Ok, we'll keep looking. Thanks for the double-check.

What happens during periodic interface reset? I tried to find out something more about this issue.
First, what I stated earlier is wrong, all clients get the correct IPv6 address. But after periodic interface reset (every morning at 4 o' clock on my box) IPv6 internet stops working.
Some facts:
Client -> LAN address -> ping works
Client -> WAN address -> ping works
Client -> Internet -> does not work.
Then I tcpdump'ed the connections on the client, the opnsense' pppoe1 interface and on the server.
Client: obviously, ping request is shown, response not
OPNsense (pppoe1): same here, request is shown, response is not
internet server: receives ping, sends reply
So the way towards the server is working. but the way back does not, not even the pppoe interface receives the echo reply.

Multiple tickets and patches landing on master at the moment. Can you reevaluate on the development version of 18.1.3 when that is out?

Yes. Tell me when I can test it and how to update/downgrade to/from the dev version.

I've been unspecific regarding commits because there have been a couple that seem to improve things in tandem. You can switch to the dev version from System: Firmware: Settings and hit save and update. Then...
# opnsense-code core
# cd /usr/core && make upgrade

Cheers,
Franco

I can test it at the weekend. These changes will hit 18.1.4 then?

At least all in dev version of 18.1.4. We don't necessarily put them into the release without testing. :)

@theq86 how's 18.1.4 working for you?

I will test it tonight. Until now I still had the full reboots in my crontab.

Unfortunately not better in 18.1.4. :-(

Step by step. How about this? https://github.com/opnsense/core/commit/64057c13
# opnsense-patch 64057c13

64057c1 or 64057c13? Your linked commit does not match the commit in the command ;-)

Same one, github truncates the hash after posting...

Logs should be a lot better now on 18.1.4, too. Can you sanitised post newwanip logs of your next test?

yes. I'll post them here in the evening.

Where does "<IP_ADDRESS>" come from? Can you verify in ifconfig where this is? It picks up the wrong IP, so that's why it fails quite simply oO

If it's not in ifconfig, it's set in a gateway under system: gateways: single maybe...

# grep <IP_ADDRESS> /conf/config.xml

This IP could not be found in the config.xml. It is in fact my Gateway IP. This is the one I get from my ISP.
Now where I rebooted my sense, everything is working. Still have the same IP as my gateway but it does not come from within my configuration.

Ok, will need these to before and after daily reset:
# netstat -nr | grep default

Maybe it lands on the wrong interface after reconnect. :/

Okay, I can provide this info when I'm back from work.
BTW after interface reset IPv4 internet works but I can't connect to openvpn. Maybe it is a firewall thing. But let's first check on the routing.

before:
default            <IP_ADDRESS>       UGS      pppoe0 default                           fe80::5651:1bff:fe83:bbbd%pppoe0 UGS   pppoe0
after:
default            <IP_ADDRESS>       UGS      pppoe0 default                           fe80::5651:1bff:fe83:bbbd%pppoe0 UGS   pppoe0
that's the same output.

Thanks, I think this is deep inside netgraph that makes this fail as someone else reported lately. Was this test with the additional 64057c13 patch or without?

It was including https://github.com/opnsense/core/commit/64057c136f4d579eeeb2dfb565f72fc3f9004b75

Ok, thanks for confirming. To me it seems something is completely broken and it's not our scripting... :(

@theq86 18.1.7 replaced dhcp6c and a race condition in dhcp6c daemon creation. Does that make any difference here?

@fichtner
I just upgraded to 18.1.7 and will have a look on that. I was busy so no pre-testing was possible. I will report back in a few days. :-)

I deactivated the reboot cron. for 2 days now everything is working fine including ipv6.
However, I forgot to reactivate the periodic interface reset at 4 o' clock. I did it now and will report back. but so far so good

okay, tested for four days now. the issue is resolved.

Thanks, great to hear. So 18.1.6 did not work but 18.1.7 does? In that case it was likely the SUGHUP addition for dhcp6c that prevents spawning of new processes which lock each other out. 😊


Paranoid compiler flags -Wall -Wextra -Wshadow -pedantic-errors

This branch try to fix the error messages produced by the paranoid flags below:
CXXFLAGS += -Wall -Wextra -Wshadow -pedantic-errors

Hello @MichalPrincNXP , thank your for merging the pull request so fast :-) It was not intentional to be client side only. I fixed what I have found so far with a 'make test' while removing the comment mark on the CXXFLAGS into mk/flags.mk. How can I test the server side ?
The nest step would maybe be to improve the the C code generator to make it create C files that compile with the paranoid flags.

OK. Looking at changed files I thought that you are solving just the client side as there are client manager files and test sources for the client side changed in your PR. And there are no server-related files updated. I have run the test with removed comment mark on CXXFLAGS and the first error has been reported with the server-related test code. If you are willing to continue solving these compiler issues, please put it into your next PR #139 (I guess this is your intention). Otherwise I will try to finalize the work with the rest files later. Thank you.


About checkpoint

Thanks for your work. I encountered an issue when decompressing ncap_weights.tar.gz. It shows an error, like this. I wonder if there is something wrong with the ncap_weights.tar.gz file.

I just ran the download script scripts/download/download_neurad_weights.sh from a clean repo clone, and it worked (on a Linux machine).
It looks like the file you have has not been fully downloaded. The tar should be roughly 12.56GB in size once downloaded. How big is the one that you have?

Yes you are right. I solved it. Thank you for your reply.


Use graphql-core 3.3.0a3

Summary
Pin the new alpha version to support defer and stream directives
Details: https://www.notion.so/zip-hq/How-to-add-defer-support-to-our-GraphQL-schema-d805fa8dfbf1423f8fb38a1e832c31b8?pvs=4#ea1893c955c44ffca1ffd416bf7dccf4
Testing
pytest tests --cov=graphql-server -vv

Sorry meant to open the PR in my forked repo. Closing out


Missing transformers

Bug Description
Hello, I tried out this awesome project today and straight got into the problem that transformers lib is not being installed.
Can you please add the transformers to the requirements and make a new docker build? That would be very nice of you thanks.
Reproduction
I tried out a classic HuggingFace RAG pipeline of the templates.
Expected behavior

Transformers installed
HuggingFace just working without problems

Who can help?
@zzzming
@NadirJ
@ogabrielluiz
Operating System
Ubuntu Linux 22.04
Langflow Version
1.0.15
Python Version
3.10
Screenshot
No response
Flow File
No response

@simwai Thanks for the suggestion. Ive handled it in #3374. The next release should resolve the issue that your are describing. Closing this issue for now.

Thanks a bunch. 👌


hold, unlock, deny message and reaction roles fix.

Rubish Looks really good but what you could do is make the bot name on the queue command be crossed out if the bot is in the verification server basically to say that someone is already testing it. This is extra, yes

~Rubish~ Looks really good but what you could do is make the bot name on the queue command be crossed out if the bot is in the verification server basically to say that someone is already testing it. This is extra, yes

Great idea! done that and removed the deny embed ;)

~Rubish~ Looks really good but what you could do is make the bot name on the queue command be crossed out if the bot is in the verification server basically to say that someone is already testing it. This is extra, yes

Great idea! done that and removed the deny embed ;)

Great. Looks good


useless line?

Did someone find here has a line?

It seems is a bug of tokyonight.nvim, because when I change other, the line disappear:

        NvimTreeWinSeparator = { fg = c.bg, bg = c.bg },


Move styles out of views and js

Currently styles are scattered over multiple js files and templates

All styles are moved out of JS code, everything that's left either have to stay there (download.html) or requires refactoring of whole view to clean up (rss_content.html)


template export tests

test coverage and code smells seem to have some issues on this branch, hopefully will be correctly calculated after merge


path-To-cladocument property is missing from action.yml

The path-To-cladocument property is missing from the action.yml file, causing this warning when running the github action:
Unexpected input(s) 'path-To-cladocument', valid inputs are ['path-to-signatures', 'branch', 'blockchain-storage-flag', 'label', 'empty-commit-flag', 'allowlist']
I suggest adding something like this:
  path-To-cladocument:
    description: "Fully qualified web link to cla document"

It would probably be preferred if it was lowercase, like path-to-cladocument, but then you probably also need to change url.ts to match

@Shane32, thank you for raising this issue. It is a bug from my side and I am working on it. I will probably fix and draft a new release by tomorrow. I will let you know once I am done 😄 .

It would probably be preferred if it was lowercase, like path-to-cladocument, but then you probably also need to change url.ts to match

Sure, makes sense. I am thinking of this naming path-to-cla-document

I have rolled a new release v1.4.2-alpha and this release should fix this issue :). Thank you for raising this issue once again ..


remove js sources from repo?

instead of polluting the repo (as I originally did) with datable js we might want to simply link to the cdn:
    <link rel="stylesheet" type="text/css" href="http://cdn.datatables.net/1.10.13/css/jquery.dataTables.css">
     <script type="text/javascript" src="http://code.jquery.com/jquery-1.12.4.js"></script>
     <script type="text/javascript" charset="utf8"
    src="https://cdn.datatables.net/1.10.13/js/jquery.dataTables.min.js"></script>

Unless it's critical to be able to see the tables w/o internet connection.
Just a thought.

@doutriaux1 see https://github.com/WCRP-CMIP/CMIP6_CVs/issues/248


Multiple environments at once - as array.

Hey.
So, my WebPack config has crossed the 400th LoC. Holy ... y'know. ITS BIG.
The idea is, to split it into pieces. In order to do so, I looked at this module. Now I have a few questions:

Can I have two environments at once?
WebPack's compiler API allows for an array to be supplied, which just spawns two compilers. That would be useful for taking notes of the differences between dev and production without having to stop the server.

Is there a clear documentation of the functions? I kinda have to puzzle it together from the README.

Kind regards,
Ingwie

@IngwiePhoenix Sorry for delayed response.

Can I have two environments at once?

Just you need to create some configs:
webpack.dev.config.js
module.exports = {};

webpack.production.config.js
module.exports = {};

webpack.config.js
var WebpackConfig = require('webpack-config');

module.exports = new WebpackConfig().extend('./webpack.[env].config.js');

and then you can pass webpack.config.js to webpack compiler.
You can set [env] via:

process.env.*:

env=dev webpack webpack.config.js

API:

var WebpackConfig = require('webpack-config');

WebpackConfig.environment.setAll({
    env: function() {
        return process.env.WEBPACK_ENV || process.env.NODE_ENV;
    }
});

Is there a clear documentation of the functions? I kinda have to puzzle it together from the README.

Yes, it's puzzle. It was automatically generated by jsdoc:
https://github.com/mdreizin/webpack-config/blob/master/docs/API.md#Config
https://github.com/mdreizin/webpack-config/blob/master/docs/API.md#Config.environment

@IngwiePhoenix Please see https://github.com/mdreizin/webpack-config#samples