I have some trouble with parsing in 4.0.2

I parsed following data :
{"rc":"0","rm":"OK","pi":{"tc":0,"rp":0},"rs":{"c":0}"}
You can recognize that there is some syntax error at the end of the value. (key is rs)
It supposed to be handling by error handler but SBJason4 doesn't check the error and doesn't return complete or error status.
       SBJson4ValueBlock block = ^(id v, BOOL *stop) {
                  // not here
         };

        SBJson4ErrorBlock eh = ^(NSError* err) {
                 // not here too
        };

        id parser = [SBJson4Parser multiRootParserWithBlock:block
                                               errorHandler:eh];

        // DATA encoded by base64Encode
        [parser parse:[NSData dataWithBase64EncodedString:@"eyJyYyI6IjAiLCJybSI6Ik9LIiwicGkiOnsidGMiOjAsInJwIjowfSwicnMiOnsiYyI6MH0ifQ=="]];

does anyone who faced with this issue?
asap please

Thanks for the bug report! I am afraid I haven't had a chance to look at
this yet. It would be a lot easier for me to look into if you managed to
add a failing test case to the existing test framework!

Hi @AFSlayer,
Sorry about the time to get back to you. I cannot reproduce the issue, I'm afraid. I added your broken JSON to my test suite in https://github.com/stig/json-framework/pull/221 and it is correctly reported as an error for me. Can you please share more details about how this occurs for you?
Stig

I believe this is probably due to broken UTF8. There was a complete overhaul of the UTF8 validation in v4.0.4, so as I cannot reproduce this I'm going to assume it was fixed there. If you can reproduce this crash with the latest v4 release (v4.0.5 at the time of writing) then please re-open this issue or create a new one!

우리는 이제 시스템에서 제공해주는 파서를 쓰기로 했습니다
[NSJSONSerialization JSONObjectWithData:options:error:];
관심가져주셔서 고맙습니다

environment:
os x 10.12.4
xcode Version 8.3.2 (8E2002)
SBJson 4.0.5
Sorry, but it still doesn't work. I can't catch the callback to SBJson4ValueBlock and SBJson4ErrorBlock.
If there is double quotation mark ( " ) before last close brace ( } ) then can not parse and not occur error neither.
and I tried also following code but it occurs same result.
[parser parse:[@"{\"rc\":\"0\",\"rm\":\"OK\",\"pi\":{\"tc\":0,\"rp\":0},\"rs\":{\"c\":0}\"}" dataUsingEncoding:NSUTF8StringEncoding]];

I attached code and console log screenshot.

JARANARA MEORIMEORI..

Thank you for the updated bug report. I'll re-open the ticket and try to schedule some time to look into it.


Multiple shortcuts per element?

Is it possible to have multiple shortcuts per elements somehow?
I need:

cmd + c to copy
cmd + d to duplicate

Having the attribute multiple times does not work:
 - duplicate attribute: v-shortkey
  - duplicate attribute: @shortkey

Hi,thanks to your issue!
I have received many questions like this and I am working on a feature to bring these features to our plugin

@francois2metz can you test the branch multi_keys? before we pull to master??


Fargate Branch: Fixed scorekeep typo in task def

Fixed scorekeep typo in task def.
s/scopekeep/scorekeep

cc/ @mwunderl

Thanks!


Added hide/show functions to GUI instances to complement open/close

As per feature request #93

Thanks!


Automations don't work until I reload them in .49

Home Assistant release (hass --version):
0.49
Python release (python3 --version):
3.4.2
Component/platform:
Automations
Description of problem:
Upon startup, my automations aren't working until I reload them through the UI.
I am not receiving any errors in my log.
Expected:
Automations should work without reloading them.

Anything in the logs that looks like a problem?

No. I'm clueless as to why it's doing this.

Do you have the amcrest component enabled on .49.0?

Yes I do. I was wondering if that had anything to do with this.

@scottocs11 yes the amcrest component broke the recorder/history component in .49.0. If you upgrade to .49.1, it should resolve all your issues. If you're unable to upgrade, disabling your amcrest component (and restarting twice, I found) will allow you to continue along until you can upgrade.
In either case, you might need to enable your automations one more time to make sure the history component is up to date.


Running multiple animations concurrently

I have requirement where I need to play multiple objects animations (published from Flash as JS animation objects) at a time. This part has been achieved.
The query is :
Each of the objects has a click event which plays the respective animations. For ease of explaining, lets consider 2 objects A and B, on click of object A animation will start for that object.
 But ideally both animations should be playing simultaneously.
I am using  “ this.game.media.playMovie();” to play animations.
Please could you suggest any options to resolve this issue.

this.game.media.playMovie() is intended for singular animations, like a character popping up to deliver some voice acting. If you need to play multiple animations at the same time, you should be using springroll.easeljs.Animator.play() directly.

Thanks @andrewstart . Yes, I have already tried with Animator.play() its playing,but animations are playing faster than actual speed and also its looping even though we have the frame labels.

That's interesting, since media.playMovie() is just a wrapper for Animator.play() with learning events attached..

Animator.play(object, {anim: "", audio: ""}, Oncomplete());  this I have used to play but  speed is more than actual. if I replace with media.playMovie() this works fine.

You could try setting object.framerate to the framerate that it was made at, just to make sure that that value is correct.

Thank you @andrewstart . Its working as expected.


Bump to 4.4.7

We're on 4.4.6

Errr, I guess 4.4.8 isn't public yet....

Just deployed 4.4.7.  Seems to be working.

4.4.7 is showing tons of APOC compatability errors in /var/log/neo4j/debug.log.


Update cronselection.html

Hi @KimSchneider thanks for the PR, we don't have any filters called cronDayName, cronMonthName, etc.  They are just dayName and so forth, to change the name of the filter in the HTML it will need to also change when the .filter() is created in the JS file.  I will close this PR and you can submit a new one changing the names in both locations if you'd like.

Ah just saw your other PR

Closing PR and will make a new one so we don't have to worry about merge conflicts.


Bump version of PrimeFaces to v13.0.8

Bump version of PrimeFaces to v13.0.8, the last available so far.

Test ok


dcm images are not ordered

When opening a folder with multiple dicom images I noted they are not sorted therefore looking at a CT series is problematic.

Thanks for reporting.


Added changes mentioned in issue: #305

I have added changes mentioned in the issue #305

Multiple output formats: JSON, SRT and TXT. Users can select the output format from menu
Users can choose the whisper model.

Fixed bug:

If the output directory already exists, it throws an error. Added a check for that so that it does not create a new directory if one already exists.
Comparison using "is" is replaced with "=="

Hey @ArifShariar
Thanks for the changes 🚀
Happy Hacktoberfest ⭐


az network application-gateway create creates a basic public IP (v2 SKU)

[Enter feedback here]
When providing a name for the --public-ip-address $AGW_PIP_NAME argument for non-existing IP address, the CLI will provision a basic IP address which is not compatible with AG v2 which will cause the command to fail.
Expected behavior to provision a Standard IP address instead.
Deployment failed. Correlation ID: 624f4f0b-a03d-4e18-8d15-986f258df939. {
"error": {
"code": "ApplicationGatewayInvalidPublicIpSku",
"message": "Application gateway /subscriptions/ID/resourceGroups/central-infosec-weu/providers/Microsoft.Network/applicationGateways/devcap-agw-weu with SKU WAF_v2 can only reference public ip with Standard SKU.",
"details": []
}
}
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d85e1042-f9fe-a899-7a64-99796558a7aa
Version Independent ID: 2573afce-d2fa-6f5f-3647-ea8696b8d0e2
Content: az network application-gateway
Content Source: src/azure-cli/azure/cli/command_modules/network/_help.py
Service: virtual-network
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Hi @MyronFanQiu , could you please help with this ?

add to S166.

@mohamedsaif Hello. CLI cannot get such limitation information. We just to create a general default public ip. If you want to create WAF_v2 application-gateway, you'd better to create a standard public ip using az network public-ip create.

@mohamedsaif Hello. CLI cannot get such limitation information. We just to create a general default public ip. If you want to create WAF_v2 application-gateway, you'd better to create a standard public ip using az network public-ip create.

@MyronFanQiu I understand your point. This is not the issue. Issue is when a missing public IP name is sent to az network application-gateway create with a v2 sku, the command will create a new basic public IP (behind the scenes) and then fails (because of the automatically created PIP by the CLI command is basic not standard)


2.x series does not support PHP 8.3

Summary
PHP 8.3 support is needed for 2.x series.
See
https://github.com/cakephp/cakephp/issues/17387
Current behavior
Not installable, probably for no good reason as 8.3 should be compatible out of the box
How to reproduce
See above link
Expected behavior
~8.3 included in the constraint for PHP so folks stuck on that 2.x series of this library can still do 8.3 checking and development of their library code.
Many libraries and frameworks will have to support their major versions for a few years longer, so it is important that they can ship with secure/safe PHP versions in the present and future.
As per semver they cannot just modify their public API and as such are locked within 2.x series for now (no types added etc).
Thank you

I don't think 2.x should be revived: is the adoption (either bump or dependency widening) to 3.x not viable?
Can we perhaps help there instead, if there are any blockers?

@dereuromark

It shows that laminas/laminas-diactoros in all compatible versions to cake 4.4 and 4.5 do not offer 8.3 support due to their bad way of constraining.

What do you mean with "bad way of constraining"?

From your upstream issue:

    - cakephp/cakephp[4.4.17, ..., 4.5.0] require laminas/laminas-diactoros ^2.2.2 -> satisfiable by laminas/laminas-diactoros[2.2.2, ..., 2.25.2].

This is what I'd suggest widening to "laminas/laminas-diactoros": "^2 || ^3" first

@dereuromark

It shows that laminas/laminas-diactoros in all compatible versions to cake 4.4 and 4.5 do not offer 8.3 support due to their bad way of constraining.

What do you mean with "bad way of constraining"?

See https://github.com/laminas/laminas-diactoros/issues/117
It is a past (and present) disagreement from the issue author with our approach to dependency management, which we explained in depth to be well founded, well intended, and I assume well understood now.

BTW, we use --ignore-platform-reqs in some CI pipelines ourselves, where upgrades aren't feasible yet :-)

I don't think 2.x should be revived: is the adoption (either bump or dependency widening) to 3.x not viable?

https://github.com/cakephp/cakephp/pull/17388 shows that this is not possible.
PHP Fatal error:  Declaration of Cake\Http\Response::withStatus($code, $reasonPhrase = '') must be compatible with Psr\Http\Message\ResponseInterface::withStatus(int $code, string $reasonPhrase = ''): Psr\Http\Message\ResponseInterface in /home/runner/work/cakephp/cakephp/src/Http/Response.php on line 619

I am sure tons of other libraries will run into the same issue sooner or later, so this is not about reviving, but providing
reasable minimum compatibility.

BTW, we use --ignore-platform-reqs in some CI pipelines ourselves, where upgrades aren't feasible yet :-)

This will not help in this case for all the libraries, as the constraint is still blocking it beyond the time schedule of stable release of 8.3 - and it creates other side effects as pulling invalid other dependencies that can create noise and make it harder to determine the actual compatibility in regards to this library and PHP 8.3 alone.

@dereuromark it looks like the problem is not with this library, but with the transient dependency on psr/http-message?
Perhaps you need to "require": {"psr/http-message": "^1"} for now?
We support both major versions:
https://github.com/laminas/laminas-diactoros/blob/4db52734837c60259c9b2d7caf08eef8f7f9b9ac/composer.json#L39

This will not help in this case for all the libraries, as the constraint is still blocking it beyond the time schedule of stable release of 8.3

That is fine BTW: we don't plan to release all libraries before PHP 8.3 is released, and in fact, we are working towards improving our dependency upgrades on that when the latest -RC are there, but we are not there yet /cc @Xerkus

I tried the suggested lock for http-message, but then shows the actual issue and why the PHP8.3 support for 2.x series was thought to be the only viable path:
Error: Call to undefined function Laminas\Diactoros\marshalUriFromSapi()

https://github.com/cakephp/cakephp/actions/runs/6653289986/job/18078957898#step:18:183

@laminas/technical-steering-committee do we want to do another 2.x minor? Is that viable?

Did we replace the sapi thing? if so, there might be an alternative. cake could check if function exist to make itself compatible with both versions.
but thats only a brain dump cuz I remember that we did something with the URL marshaling stuff. So there must be an alternative.

Regarding php support of v2, if that is doable without code changes, I would probably not mind backporting it.

The problem with issuing a new minor on v2 is that we then need to support that branch for another 3 years with security fixes. Considering the number of changes in v3, this could potentially be a lot of work for us to maintain.

If the changes are that minimal, you can also just do a patch release on
2.26.x

A minor seems almost overkill to quickly allow something that is quite obvious in nature regarding compatibility and in light of 2023/2024 support of PHP.

@dereuromark  —

I don't think you do, you can also state that in the release.
All people care about is that they can use it with PHP 8.3 - which would be possible without the constraint locking it down.
So allowing it to be there should not have anything to do with any other maintenance to that code.

This is simply not true. We have a published security policy, and it states that we maintain a release branch until the minimum supported PHP version is no longer supported by php.net.
What you think is beside the point here; we are the ones who have to maintain it, and making exceptions to things like security policies loses our users' trust in the project. If we make a new release branch, we have to maintain it.

A minor seems almost overkill

However, again, our policy is that we only add support for new PHP versions in new minor releases. There are a ton of reasons why we do this, and I'm not going to go into them here.
I'm not saying we won't do it; I'm pointing out the ramifications of doing it so that those of us on the steering committee know what we are committing to if we do so.

Regarding php support of v2, if that is doable without code changes, I would probably not mind backporting it.

It seems to work fine with PHP 8.3 without any code changes https://github.com/ADmad/laminas-diactoros/actions/runs/6667118891

@ADmad send a patch against 2.26.x (with composer.lock hash updated, please), please, and I shall prepare a release and see how I can merge it up too.

Resolved via #176

Thanks you guys for this. Really appreciate the fact that the laminas team is willing to make changes to accommodate down stream users.


upgrade a few dependencies

polkadot companion: https://github.com/paritytech/polkadot/pull/2205

@bkchr did impl-trait-for-tuples 0.2 broke const?

@bkchr did impl-trait-for-tuples 0.2 broke const?

I'm not sure what would be the best way to fix web-wasm check.
The problem is that primitive-types indirectly pulls getrandom 0.2, which doesn't compile to wasm32-unknown-unknown unless js feature is enabled.
I could add getrandom as an optional dependency to all crates that we check here https://github.com/paritytech/substrate/blob/71e47d792ff9997e742b8f90e4fb3a8397f502c3/.gitlab-ci.yml#L304-L317
but maybe there is a cleaner way?

I'm not sure what would be the best way to fix web-wasm check.
The problem is that primitive-types indirectly pulls getrandom 0.2, which doesn't compile to wasm32-unknown-unknown unless js feature is enabled.
I could add getrandom as an optional dependency to all crates that we check here https://github.com/paritytech/substrate/blob/71e47d792ff9997e742b8f90e4fb3a8397f502c3/.gitlab-ci.yml#L304-L317
but maybe there is a cleaner way?

Did we used getrandom before?

Did we used getrandom before?

Did we used getrandom before?

yes, but version 0.1, this is a fallout from rand 0.8 upgrade in fixed-hash

Did we used getrandom before?

yes, but version 0.1, this is a fallout from rand 0.8 upgrade in fixed-hash

We could create a meta crate. The "test-wasm-browser-compilation" and all crates we want to test for wasm, we make a dependency of this crate. This way we can also add the getrandom and activate the feature.

We could create a meta crate. The "test-wasm-browser-compilation" and all crates we want to test for wasm, we make a dependency of this crate. This way we can also add the getrandom and activate the feature.

We could create a meta crate. The "test-wasm-browser-compilation" and all crates we want to test for wasm, we make a dependency of this crate. This way we can also add the getrandom and activate the feature.

We already test bin/node/cli this way, it includes most of these crates. I think we wanted to test they compile in separation?

We could create a meta crate. The "test-wasm-browser-compilation" and all crates we want to test for wasm, we make a dependency of this crate. This way we can also add the getrandom and activate the feature.

We already test bin/node/cli this way, it includes most of these crates. I think we wanted to test they compile in separation?

bot merge

bot merge

@ordian Just an FYI, the problem with getrandom is seemingly causing the build for our WASM runtime to break when we try to upgrade to the latest Substrate.
vincent@oryx:~/code/polkadot-ethereum/parachain (vincent/update-dependencies)$ cargo build
...
  error: target is not supported, for more information see: https://docs.rs/getrandom/#unsupported-targets
     --> /home/vincent/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.2.1/src/lib.rs:214:9
      |
  214 | /         compile_error!("target is not supported, for more information see: \
  215 | |                         https://docs.rs/getrandom/#unsupported-targets");
      | |_________________________________________________________________________^

  error[E0433]: failed to resolve: use of undeclared crate or module `imp`
     --> /home/vincent/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.2.1/src/lib.rs:236:5
      |
  236 |     imp::getrandom_inner(dest)
      |     ^^^ use of undeclared crate or module `imp`

  error: aborting due to 2 previous errors

Not sure how to go about fixing it. I tried to add the js feature with the following but it was ignored it seems:
[patch.crates-io]
getrandom = { git = "https://github.com/rust-random/getrandom.git", tag = "v0.2.1", features = ["js"] }

We also pull in getrandom v0.2.1 via ethereum-types which is a dependency of several of our crates.

@ordian Just an FYI, the problem with getrandom is seemingly causing the build for our WASM runtime to break when we try to upgrade to the latest Substrate.
vincent@oryx:~/code/polkadot-ethereum/parachain (vincent/update-dependencies)$ cargo build
...
  error: target is not supported, for more information see: https://docs.rs/getrandom/#unsupported-targets
     --> /home/vincent/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.2.1/src/lib.rs:214:9
      |
  214 | /         compile_error!("target is not supported, for more information see: \
  215 | |                         https://docs.rs/getrandom/#unsupported-targets");
      | |_________________________________________________________________________^

  error[E0433]: failed to resolve: use of undeclared crate or module `imp`
     --> /home/vincent/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.2.1/src/lib.rs:236:5
      |
  236 |     imp::getrandom_inner(dest)
      |     ^^^ use of undeclared crate or module `imp`

  error: aborting due to 2 previous errors

Not sure how to go about fixing it. I tried to add the js feature with the following but it was ignored it seems:
[patch.crates-io]
getrandom = { git = "https://github.com/rust-random/getrandom.git", tag = "v0.2.1", features = ["js"] }

We also pull in getrandom v0.2.1 via ethereum-types which is a dependency of several of our crates.

I don't think this patch will work, you'd have to patch all crates that pull getrandom indirectly if you go this way.
Have you tried adding this to the Cargo.toml crate that is pulling it?
getrandom = { version = "0.2", features = ["js"], optional = true }

See https://github.com/paritytech/substrate/pull/7831/commits/d245f58488125ab5a7a63be537b04a6eb0c9f3f7.

I don't think this patch will work, you'd have to patch all crates that pull getrandom indirectly if you go this way.
Have you tried adding this to the Cargo.toml crate that is pulling it?
getrandom = { version = "0.2", features = ["js"], optional = true }

See https://github.com/paritytech/substrate/pull/7831/commits/d245f58488125ab5a7a63be537b04a6eb0c9f3f7.

Actually, it seems that a rand feature of fixed-hash is leaking where it shouldn't. Let me try to find a source.

Actually, it seems that a rand feature of fixed-hash is leaking where it shouldn't. Let me try to find a source.

I don't think this patch will work, you'd have to patch all crates that pull getrandom indirectly if you go this way.
Have you tried adding this to the Cargo.toml crate that is failing to build?

Thanks! that worked for me.

I don't think this patch will work, you'd have to patch all crates that pull getrandom indirectly if you go this way.
Have you tried adding this to the Cargo.toml crate that is failing to build?

Thanks! that worked for me.

I don't think this patch will work, you'd have to patch all crates that pull getrandom indirectly if you go this way.
Have you tried adding this to the Cargo.toml crate that is failing to build?

Thanks! that worked for me.

Note that this is more of a temporary hack, rather than a fix. The actual fix would be to identify why getrandom is pulled in the first place (I don't think it should, looks like std/feature leakage of some sort).

I don't think this patch will work, you'd have to patch all crates that pull getrandom indirectly if you go this way.
Have you tried adding this to the Cargo.toml crate that is failing to build?

Thanks! that worked for me.

Note that this is more of a temporary hack, rather than a fix. The actual fix would be to identify why getrandom is pulled in the first place (I don't think it should, looks like std/feature leakage of some sort).

@vgeddes FYI

https://github.com/paritytech/parity-common/pull/503
https://github.com/rust-random/rand/pull/1086

@vgeddes FYI

https://github.com/paritytech/parity-common/pull/503
https://github.com/rust-random/rand/pull/1086

Awesome! yeah I think the serialize feature for ethereum-types was also causing my WASM build to break yesterday (after fixing the getrandom issue).  Glad the issue has been confirmed. Luckily I didnt need the serialize feature so I removed it.
Upgrading our cargo resolver to v2 may have helped things too, though not sure.

Awesome! yeah I think the serialize feature for ethereum-types was also causing my WASM build to break yesterday (after fixing the getrandom issue).  Glad the issue has been confirmed. Luckily I didnt need the serialize feature so I removed it.
Upgrading our cargo resolver to v2 may have helped things too, though not sure.


Populate Judge Vulnerability - Part 1

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-1725
Change description

Add a Vulnerability section to the Judge's screens.
Add Order dropdown and date for General Applications Order Screen

DATE FIELD DETAILS
Date label: Date for Order to end
Validation required for date field - no date allowed in the past
Available when application type includes: Extend Time, Stay the Claim
DROPDOWN DETAILS
Dropdown label: For which party?
Dropdown Values: Claimant, Defense
Available when application type includes: Extend Time, Strike Out
Related PR
https://github.com/hmcts/civil-general-applications/pull/207
Read Me
Please take a look at the attached word file
Does this PR introduce a breaking change? (check one with "x")
[x] Yes
[ ] No

Build failure

CIV-1725.docx

Please don't merge it as QA has found some issue

[ ] Fix Issue found by QA


v0.8.8_21: ‘?’ link is missing with the Y axis description

SEVERITY: Minor
MODULE:  Mountain Chart
Platform: iPhone-4G(iOS 7.1.2)/ Safari
RELEASE: v0.8.8
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.8/preview/mountainchart.html
Mountain chart page will be loaded
Note that ‘?’ link is missing with the Y axis description

ACTUAL RESULTS:
‘?’ link is missing with the Y axis description
EXPECTED RESULTS:
‘?’ link should be there with the Y axis description
SCREENSHOT:

https://github.com/Gapminder/vizabi/pull/1005

should be fixed now

Retest Result: Pass
Platform: iPhone-4G(iOS 7.1.2)/ Safari
Testing Environment: http://static.gapminderdev.org/vizabi/develop/preview/bubblechart.html


pf.conf(5) support

This is experimental support for the pf.conf(5) firewall rules file format as of OpenBSD 5.6. I'm not entirely sure how updates to all the custom styles are meant to be managed; for now only the "default" style is changed.

Thanks!


Documentation: Add getting started section to readthedocs

Specifically need:

how to call fit
inputs
outputs
-brief overview of what is meant by K, nPoints, nDim
specific details about format of input data

Related to #69


feat: Artificially clamp range of sequential palettes for colors to be less white

Here we articifically clamp the left side of the sequential color palette as it is
too white and is not visible on maps.
I think I saw somewhere (maybe on GitLab) an issue that was talking about this,
and I experienced the problem myself.
I'd like to have your views on these. cc @rdataflow @anninawalker @bprusinowski

@ptbrowne LGTM let's go with this 👍
Closes: https://github.com/visualize-admin/visualization-tool/issues/538

Let's try this simple and easily reversible solution first, and see if it solves the problem. If in the future, we see that it causes problem, we can very easily go back ;)


”Bumbești-Pițic”, ”Cârligei”, "Poienari" are listed in the drop-down menu

Description:
”Bumbești-Pițic”, ”Cârligei”, "Poienari" are listed in the drop-down menu alongside their corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 3
Type "Cârligei" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Cârligei, GORJ (Bumbești-Pițic)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Poienari" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Poienari, GORJ (Bumbești-Pițic)".


Add Display/Hide week numbers in calendars

Add user's property display_week_numbers

Add display_week_numbers edition in user's profile

Add a column week numbers in a board's calendar view

Add a column week numbers in a card's due date popup calendar

Thank you very much. Merging.


removed prefixing slash from containers name returned by "inspect" cmd

Docker inspect cmd uses FQDN for container names which start with "/"
unfortunately, this is inconsistent with the rest of the CLI commands, which take a non-slashed names as their arguments.
In this PR I removed the "/" from the container name for the containerlab inspect command:
❯ ../container-lab/container-lab inspect -t 1_srl.yml                                                                                ─╯
INFO[0000] Getting topology information ...
+------------------------+--------------------+------+-------+---------+----------------+----------------------+
|          Name          |       Image        | Kind | Group |  State  |  IPv4 Address  |     IPv6 Address     |
+------------------------+--------------------+------+-------+---------+----------------+----------------------+
| containerlab-1srl-srl1 | srlinux:20.6.1-286 | srl  |       | running | <IP_ADDRESS>/24 | 2001:172:19:20::2/80 |
+------------------------+--------------------+------+-------+---------+----------------+----------------------+

Additionally, I removed the default topo file, which I think is a bit misleading

Removing the prefix is fine, but it has some meaning. it means the container is under the local docker daemon.
BTW which other commands you are referring to that take container names ?

@karimra actually I was wrong that leading slash prevents some docker cli from working. I read on an issue in docker repo which referenced this https://github.com/moby/moby/issues/6705#issuecomment-134183456
but I didn't notice this issue was quite old, and recent docker cli can take leading slashes with no problems.
At the same time, I think its still safe to remove the leading slash, as with the remote docker engine the path will still be recognizable if we remove the leading slash?

Yes it's safe to remove, it looks better without "/". and we dont support remote deployment/inspect/destroy/...


Tracker Customization Support

This feature adds support for code customizations to be added to the Tracker by anyone. By default, the Tracker will not have any custom code files or custom code execution.
To obtain this, developers need to install the Custom Code add-on which is a single file. This file allows the developer to hook into specific areas of the Tracker to execute code, similar to an API, but with a bit more control on our end.
Since this is an add-on, this feature is upgrade safe. This means that upgrading that tracker will not overwrite or directly break the custom code support. Also worth noting that this is a first attempt at offering custom code to be used within the Tracker, and as such it is unlikely that this captures every possible use-case that a developer might want. Future updates to this add-on are possible, but will require developers to make those updates to their own custom code file to obtain them.
Given this is an add-on, the CustomCode.lua file is not included in this PR as it won't be included in a normal Tracker download. This file can be found here:

CustomCode.lua.txt

In short, this feature:

Is completely optional, and not included in the regular Tracker download
Exposes "API"-like functions that developers can use to execute code at specific Tracker runtime events
Is upgrade safe; custom code isn't overwritten with each Tracker update

Things to do after this:

Include the CustomCode.lua add-on code file to the next release
Update the Add-on wiki page to explain how to install this
Create a wiki page detailing how this custom code add-on works, and examples for using it

Going to change this up in a bit to work better for sharing custom code.

Done. Thanks for waiting. The CustomCode.lua file is now included in the actual tracker project. I separated out the parts that devs will change into the add-on specific code files, which are attached to this message.

CustomCodeSettings.lua.txt
CodeExtensionTemplate.lua.txt


feat: Added option to unmask/unhide the password

Description
Currently in login activity there is no option to unhide/unmask the password if the user want's to check whether he has typed the password correctly or not. This feature although very basic is very useful to the users.
Related issues and discussion
fixes #816
Screen-shots, if any

Checklist

[x] If you have multiple commits please combine them into one commit by squashing them.

[x] Apply the AndroidStyle.xml style template to your code in Android Studio.

[x] Read and understood the contribution guidelines .

Useful, many thanks


Update comfig.cfg

Did you test this?

Yes. I always played with effects on Very Low setting and I did not get a when playing as Heavy.


Feature: navigation buttons in the Rebound Hub title bar

📄 Description
Add back, forward, and refresh buttons to the Rebound Hub title bar for easier navigation
🗃 Alternative solutions
No response
⚡ API Changes
No response
👥 Intended Use-Case
No response
✅ Tasks
No response
📸 Assets
No response

I don't think there's much point in this, since there's not really much navigation in Rebound Hub anyway. Navigation styles are more important in apps like FluentHub or Files because of the fact that there are near hundreds of views, but Rebound Hub is just a demo of Rebound 11 rather than something that requires proper navigation.

So just keep it in the Control Panel then?

Yes.


RunnerSet not using persistent storage after v0.20.2 -> v0.22.0 upgrade

Describe the bug
When we were using v0.20.2 with ephemeral: false RunnerSets we had docker laying caching working.  After upgrading to v0.22.0 and dropping the ephemeral: false because my understanding from https://github.com/actions-runner-controller/actions-runner-controller/pull/1211/ was that this was not needed, there is no longer any persistent storage for the RunnerSets.
Adding the ephemeral: false back in does not help either.
Perhaps I misunderstood how this is supposed to work and it was either luck or having longer running pods that hid this problem? But the documentation https://github.com/actions-runner-controller/actions-runner-controller/#runnersets does make me think this should work.
One more clue, though the pods have .metadata.labels.runnerset-name: persistent-runner set, their name is persistent-runner-<hash>-0, not at all StatefulSet like.
Checks

[X] My actions-runner-controller version (v0.x.y) does support the feature
[ ] I'm using an unreleased version of the controller I built from HEAD of the default branch

To Reproduce
Steps to reproduce the behavior:

Install/upgrade https://github.com/actions-runner-controller/actions-runner-controller/releases/download/v0.22.0/actions-runner-controller.yaml
have a RunnerSet with this definition:

apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerSet
metadata:
  name: persistent-runner
  namespace: default
spec:
  organization: myorg
  replicas: 2
  # Other mandatory fields from StatefulSet
  selector:
    matchLabels:
      app: persistent-runner
  serviceName: persistent-runner
  template:
    metadata:
      labels:
        app: persistent-runner

Trigger a GHA build with docker layer caching repeatedly
Observe lack of layer caching
Note lack of actual volume mounting:

> k get pods persistent-runner-857b4-0 -o yaml | yq eval .spec.volumes -
- emptyDir: {}
  name: runner
- emptyDir: {}
  name: work
- emptyDir: {}
  name: certs-client
- name: default-token-qzc5m
  secret:
    defaultMode: 420
    secretName: default-token-qzc5m

Expected behavior
Either the above RunnerSet definition should have persistent storage, or the documentation should be updated to not give that impression.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Controller Version [e.g. 0.18.2]
Deployment Method: download https://github.com/actions-runner-controller/actions-runner-controller/releases/download/v0.22.0/actions-runner-controller.yaml and use it with kustomize
Helm Chart Version: not used

Additional context
The upgrade was a bit troublesome with actions-runner-controller.yaml too big to apply and deleting it ran into stuck finalizers. However, k diff -f actions-runner-controller.yaml now only lists changes in managed fields so there should be no issue there.

I think there has been a misunderstanding of how this works.
https://github.com/actions-runner-controller/actions-runner-controller/pull/1211 just changed the flag we are pass by default to a runner which is ephemeral: true (the default) from the legacy --once flag to the new (not that new now) GitHub supported --ephemeral flag. This is seperate and not related to the ephemeral: attribute. This attribute when set to false configures the runner as persistent runner. A persistent runner is just a runner that is not recreated after a job is completed and has neither the --ephemeral or the --once flags set for the runner service. You were getting docker layer caching before because the pod wasn't getting recreated rather than due to anything special about the RunnerSet kind. You could achieve the same thing with a RunnerDeployment with ephemeral: false.
The idea of RunnerSets is you can use the StatefulSet feature set enabling you to use PVCs in conjuction with ephemeral: true allowing for durable storage which brings benefits like docker cache (once PVCs and Docker are configured) whilst retaining the benefits of a determanistic environment (i.e. a new pod after each job completion).

@larstiq Probably toast-gear has answered everything you'd need to know, but anyway treat me as another data point;
ephemeral: true|false and --ephemeral are two different things. If you do want to keep your volumes reused across workflow jobs, do keep using static/persistent runners by setting ephemeral: false.
JFYI, in the context of ARC, --once and --ephemeral are the two different sub-modes of ephemeral: true(=ephemeral runners. --once has been deprecated and being replaced by --ephemeral so ARC 0.22.0 or greater uses --ephemeral by default for ephemeral: true. That's what https://github.com/actions-runner-controller/actions-runner-controller/pull/1211 does. You seems to prefer the behavior of static/persistent runners so you shouldn't use ephemeral runners, hence my answer above.

I think there has been a misunderstanding of how this works.

Right, I was afraid of that.

You were getting docker layer caching before because the pod wasn't getting recreated rather than due to anything special about the RunnerSet kind.

I swore I had seen storage stick after pod restarts, but couldn't confirm so there was a chance I was remembering the wrong thing, alas.

The idea of RunnerSets is you can use the StatefulSet feature set enabling you to use PVCs in conjuction with ephemeral: true allowing for durable storage which brings benefits like docker cache (once PVCs and Docker are configured) whilst retaining the benefits of a determanistic environment (i.e. a new pod after each job completion). The initial implementation had limitations but I think they've all been lifted.

Good, that description is exactly what I want.   Can you confirm the Pod naming persistent-runner-857b4-0 is the determinism that is expected?

You'll need to configure PVs and PVCs on your RunnerSets to get durable storage, we don't implement that as it's going to be highly environment and cluster specific.

Fair enough, the GKE auto-provisioned persistent disks sometimes look like magic but they're not, back to the usual storage provisioning we go.
Thank you for you answer, even if it confirmed that my previous results were wishful thinking and a misunderstanding of an accident, I was braced for that and it's really helpful to get it straight.

@mumoshu hmm, your answer on

If you do want to keep your volumes reused across workflow jobs, do keep using static/persistent runners by setting ephemeral: false.

seems to contradict @toast-gear's answer on

The idea of RunnerSets is you can use the StatefulSet feature set enabling you to use PVCs in conjuction with ephemeral: true allowing for durable storage which brings benefits like docker cache (once PVCs and Docker are configured) whilst retaining the benefits of a determanistic environment (i.e. a new pod after each job completion).

What I want is

persistent storage for caching (docker layers, mainly, so in the docker container)
clean runner environments after each build, seemingly easiest by just restarting the runner, what I hoped to get with ephemeral: true.

I've now added in the volumeClaimTemplates like so:
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerSet
metadata:
  name: persistent-runner
  namespace: default
spec:
  organization: myorg
  replicas: 2
  # Other mandatory fields from StatefulSet
  selector:
    matchLabels:
      app: persistent-runner
  serviceName: persistent-runner
  template:
    metadata:
      labels:
        app: persistent-runner
    spec:
      containers:
        - name: docker
          volumeMounts:
            - mountPath: /var/lib/docker
              name: persistent-runner-data
  volumeClaimTemplates:
    - metadata:
        name: persistent-runner-data
      spec:
        accessModes:
          - ReadWriteOnce
        resources:
          requests:
            storage: 100Gi

And that works to get storage:
> k get pod persistent-runner-k2ksm-0 -o yaml | yq eval .spec.volumes -
- name: persistent-actions-runner-data
  persistentVolumeClaim:
    claimName: persistent-runner-data-persistent-runner-k2ksm-0

But the StatefulSet part doesn't seem to be working, with the 2 replicas I'd expect a -0 and a -1 but instead end up with a new pod/pvc every time a build finishes:
NAME                                                               STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistent-runner-data-persistent-runner-2dkrs-0   Bound    pvc-10e59266-c289-4e3f-ae82-c382bd8cecd3   100Gi      RWO            standard       12m
persistent-runner-data-persistent-runner-6szk8-0   Bound    pvc-c81507c9-5b0c-464b-a2df-7513ead64ac7   100Gi      RWO            standard       22s
persistent-runner-data-persistent-runner-8wrb7-0   Bound    pvc-c89051d1-6c87-4cc7-afae-dfe617c660fe   100Gi      RWO            standard       8m36s
persistent-runner-data-persistent-runner-k2ksm-0   Bound    pvc-7fa3d63c-d612-436e-8c03-8947be7e4286   100Gi      RWO            standard       6m26s
persistent-runner-data-persistent-runner-l8mr2-0   Bound    pvc-2646db7c-5ef1-443e-aa47-dd8d5f220d28   100Gi      RWO            standard       12m

and of course then docker layer caching won't work either.   I don't understand the point of this behaviour?  I can probably make it do what I want by being more careful with where the volumes come from, but in the end I'm still going to need the StatefulSet guarantee of a stable mapping from pod to volume, how do I get that in this case?

Regardless, you seem to prefer the behavior of static/persistent runners so you shouldn't use ephemeral runners, hence my answer above.

Well, I really dislike the fact that the runner pod environment is shared between builds, but if that is the only way to get the docker caching to work I guess I'll have to live with it.  Maybe tell people to do all their builds inside containers and not the runner itself..

When adding ephemeral: false back in I can confirm that there are only 2 StatefulSets (persistent-runner-wmhrb and persistent-runner-bj6jm), the Pods stay up and the docker caching works, at the cost of the runner being polluted over time.
Btw, is there a Slack/irc/chat channel somewhere I could ask these questions instead of filing a Github issue?

@larstiq So what @toast-gear has explained seems to be the pre-0.22.0 behavior.
Since 0.22.0, ARC creates a brand-new statefulset per a runner pod.
It was to make workflows job runs more reliable. Pre-0.22.0, there was race condition between GitHub Actions and ARC- a runner of the same name coming up after an ephemeral runner completion, ARC thinks the runner is not ready yet so terminate it without holding on, while GitHub Actions assigns the job to the runner pod being terminated by ARC, job hangs forever. Creating a brand-new runner pod per job(RunnerDeployment) and a runner statefulset per job(RunnerSet) fixes that.
Would there be any way to retain a PV dynamically created as part of a statefulset, and let another statefulset to reuse/mount it? If that's possible, probably ARC can leverage that to let statefulsets reuse PVs from a pool. (and ARC would manage that pool of PVs, externally to StatefulSet)
Also note that RunnerSet's support for PVC is still useful for dynamically provisioning fast volumes other than host's own volume(the default runner work dir is backed by emptyDir which shares the same iops credit as the host's volume. imagine AWS EBS mounted as a root volume..). So, persisting a runner's state wasn't the only benefit of RunnerSet.

Well, I really dislike the fact that the runner pod environment is shared between builds

I thought a static/persistent actions/runner wiped runner work dir per a job run.  What else do you need to not pollute the build env? To me, sharing /var/lib/docker can be also problematic in some cases (what if a job broke the /var/lib/docker? Every runner reused that /var/lib/docker may fail running docker jobs).

Btw, is there a Slack/irc/chat channel somewhere I could ask these questions instead of filing a Github issue?

We don't have a Slack channel. GitHub Discussions might be the place for questions and discussions.

Right, I see how the race condition is avoided, it's just not what I expect from a StatefulSet.

Would there be any way to retain a PV dynamically created as part of a statefulset, and let another statefulset to reuse/mount it? If that's possible, probably ARC can leverage that to let statefulsets reuse PVs from a pool. (and ARC would manage that pool of PVs, externally to StatefulSet)

The normal mechanisms for that depend on the stable identifier, which we're now explicitly not using by generating a new StatefulSet per job.  Staring at https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#pod-identity I don't see any way to replace that and I fear I'd have to actually read the underlying go code to get some creative ideas.   My mind just keeps coming back to solving the race condition in a different way, but I know that's easier said than done.

I thought a static/persistent actions/runner wiped runner work dir per a job run.

Yes, but that doesn't protect against users doing npm install -g <something> or the like, not cleaning up after themselves.

To me, sharing /var/lib/docker can be also problematic in some cases (what if a job broke the /var/lib/docker? Every runner reused that /var/lib/docker may fail running docker jobs).

That's true, but it is harder to do because there is no direct access to the docker container from the build, and so happens far less frequently (i.e. I need to step in less frequently). Exhausting the storage space is I think the most likely to occur, and that's straightforward to fix.
I do sympathize with your point that it's not safe in all generality, as a consumer of actions-runner-controller it's easier for me to make the call on what fits my environment than for an author of a piece of software to make the call for all possible usecases.

Maybe related, maybe not: although the reclaim policy of the PVs is Delete, they're still sticking around long after the ephemeral: true StatefulSet's are gone:
> k get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                      STORAGECLASS   REASON   AGE
pvc-10e59266-c289-4e3f-ae82-c382bd8cecd3   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-2dkrs-0   standard                7h38m
pvc-2646db7c-5ef1-443e-aa47-dd8d5f220d28   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-l8mr2-0   standard                7h38m
pvc-798f4483-52c4-40ba-906f-5f86ba67dfd5   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-bj6jm-0   standard                7h10m
pvc-7fa3d63c-d612-436e-8c03-8947be7e4286   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-k2ksm-0   standard                7h32m
pvc-8e99b575-1249-491f-ada4-f134a35796ef   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-c66wp-0   standard                7h18m
pvc-c173c538-77dd-4404-ade9-6cd1173c2bf3   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-jmtln-0   standard                7h11m
pvc-c81507c9-5b0c-464b-a2df-7513ead64ac7   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-6szk8-0   standard                7h26m
pvc-c89051d1-6c87-4cc7-afae-dfe617c660fe   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-8wrb7-0   standard                7h34m
pvc-d11b879c-caa1-49ed-91c5-8deb2eb3424b   100Gi      RWO            Delete           Bound    default/persistent-runner-data-persistent-runner-wmhrb-0   standard                7h10m

> k get statefulset
NAME                              READY   AGE
persistent-runner-bj6jm   1/1     7h11m
persistent-runner-wmhrb   1/1     7h11m

Could be something to do with how GKE provisions the PVs, but since I haven't seen that with other StatefulSets before my first suspicion would be with the RunnerSet.

@larstiq I think the problem with your PVs not getting deleted automatically is because, they are still Bound to their respective PVCs. Check if the PVCs are getting removed after the pods get recreated or not.
Also, I'm in the same boat as you. I expected RunnerSet to behave like the standard StatefulSet. I really wish that race condition was solved differently to have a persistent  PVC for each of these RunnerSets.

I really wish that race condition was solved differently to have a persistent PVC for each of these RunnerSets.

Me too. But my conclusion is it's fundamentally impossible without enhancements on GitHub Actions side in the current style.
There might be a possibility if we reimplement the whole StatefulSet-like mechanism with the ability to reuse PVs across pods while the same pod indices never reused. It would cost a lot of development efforts though.

Docs updated and issue raised to enhancement ARC to handle PVC/PV build up, closing this issue as a result.


feat: add Cognito identity provider component

This PR adds a new component sst:aws:CognitoIdentityProvider based on Pulumi component https://www.pulumi.com/registry/packages/aws/api-docs/cognito/identityprovider/
Related issue: https://github.com/sst/ion/issues/562
Please let me know if you have any questions, thanks.

Let me ask the team to review.

Thanks @ianruan!
Made some minor changes to addIdentityProvider - https://ion.sst.dev/docs/component/aws/cognito-user-pool/#addidentityprovider
Also added providers to addClient - https://ion.sst.dev/docs/component/aws/cognito-user-pool/#cognitouserpoolclientargs


Lambda.run cannot be used without explicit types

Steps to reproduce

setup a basic project that uses AWSLambdaRuntime
in your main file, define an Input and Output type that should be used for the Lambda
use the Lambda.run function with the non-Void callback
the body of the run closure MUST have at least one line of code other than invoking the callback

Observed behavior
I get a compiler error: Cannot convert value of type 'Output' to expected argument type 'Void'.
There are 2 overloaded run functions: One takes a closure of type @escaping (Result<Void, Error>) -> Void and the other of type @escaping (Result<Output, Error>) -> Void. I expect the compiler to know that I am using the second function.
Example: Not compiling
import AWSLambdaRuntime

struct Input: Codable {
  let foo: String
}

struct Output: Codable {
  let bar: String
}

Lambda.run { (context, input: Input, callback) in
  context.logger.info("foo bar")
  callback(.success(Output(bar: input.foo.capitalized)))
}

Compiler Error: Cannot convert value of type 'Output' to expected argument type 'Void'
Notice that the order of those lines in the run body is not important, the following yields the same compiler error:
import AWSLambdaRuntime

struct Input: Codable {
  let foo: String
}

struct Output: Codable {
  let bar: String
}

Lambda.run { (context, input: Input, callback) in
  callback(.success(Output(bar: input.foo.capitalized)))
  context.logger.info("foo bar")
}

Example: Compiling
import AWSLambdaRuntime

struct Input: Codable {
  let foo: String
}

struct Output: Codable {
  let bar: String
}

Lambda.run { (context, input: Input, callback) in
  callback(.success(Output(bar: input.foo.capitalized)))
}

As long as the body of run does not contain more than one line I don't get any compiler error. Might be trivial but: Using lines of comments does not result in a compiler error, e.g. the following compiles as well:
import AWSLambdaRuntime

struct Input: Codable {
  let foo: String
}

struct Output: Codable {
  let bar: String
}

Lambda.run { (context, input: Input, callback) in
  // call the callback
  callback(.success(Output(bar: input.foo.capitalized)))
}

Another way to work around this problem is of course just specifying the type of callback. The following compiles without errors:
import AWSLambdaRuntime

struct Input: Codable {
  let foo: String
}

struct Output: Codable {
  let bar: String
}

Lambda.run { (context, input: Input, callback: @escaping (Result<Output, Error>) -> Void) in
  context.logger.info("foo bar")
  callback(.success(Output(bar: input.foo.capitalized)))
}

[EDIT 1: edited the code examples to make them compile if copy&pasted]
[EDIT 2: reworked the examples and explanation to better reflect the problem (now more directed to the compiler error rather than the styling of the code)]

cc @jckarter since most of this is compiler related

Overloading is a bad idea to begin with in general, so if there's a way to get the intended API effect with only one overload, I would suggest that no matter what. The compiler isn't going to do type inference across statements, so you're not going to be able to get it to infer the callback argument from the body of a multi-line closure.

This will be resolved with https://github.com/apple/swift/pull/32223

I believe this should be closed.
Swift 5.7 will enable such syntax, but we’re not using closures any more🤷♂

Closing since these two changes landed.
https://github.com/swift-server/swift-aws-lambda-runtime/pull/111
https://github.com/apple/swift/pull/32223


Added changelog, update docs, fix typo

Added a changelog on what's new, changed, or removed in new version (v2.0.0), add docs on how to update, fixed a typo in a path

@kevindavee added MIGRATE.md to help users migrating


Publish on vscode marketplace?

This is great, why haven't it been published?
Update: oh you already did: https://marketplace.visualstudio.com/items?itemName=pandapip1.eipw-vscode
Let me make it more obvious: #175

But it seems I couldn't trigger this extension to warn me for errors in my VS Code. do I need to do anything other than install it from vs code marketplace?

This was also built with an early version of eipw, so e.g. link checking isn't implemented and warnings are hardcoded. I should release a new version.

That's great. Don't forget to publish the new version on https://marketplace.visualstudio.com/items?itemName=pandapip1.eipw-vscode

That's great. Don't forget to publish the new version on https://marketplace.visualstudio.com/items?itemName=pandapip1.eipw-vscode

CI does that for me.


deleteentity and adjstationjob been broken for a month and nobody notice

Issue in title

Could you elaborate on what "deleteentity" means in context

command deleteentity deletes a role from station manifest.
It helpfull when you need depart some deleted bodys from station manifest

adjstationjob has been moved to the toolshed equivalent station:get jobs:job <job id> jobs:adjust <amount>

adjstationjob has been moved to the toolshed equivalent station:get jobs:job <job id> jobs:adjust <amount>

adjstationjob has been moved to the toolshed equivalent station:get jobs:job <job id> jobs:adjust <amount>

You need to start the command with >  to use toolshed.

station:get jobs:job  jobs:adjust

what about deleting man from manifest?

deleteentity just deletes an entity, it has nothing to do with the manifest.


Proxy SSL certificate renewal needs kong reload to take effect

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong Enterprise <IP_ADDRESS>
Current Behavior
Kong proxy ssl certificate set in  kong.conf   get renewed automatically by cert-manager  , but kong proxy keep serving old certificate unless it restarted or reloaded
Called only once in kong/init.lua
  if config.proxy_ssl_enabled or config.stream_ssl_enabled then
    certificate.init()
  end

Expected Behavior
The proxy ssl certificate should be  updated when it's changed
Steps To Reproduce

Install cert-manager  and setup an issuer ( e.g letsencrypt )
Create a certificate in kong namespace  ( e.g kong-proxy-cert)
Install kong helm chart with override.yaml

   secretVolumes:
   - kong-proxy-cert
   env:
     ssl_cert: /etc/secrets/kong-proxy-cert/tls.crt
     ssl_cert_key: /etc/secrets/kong-proxy-cert/tls.key

   helm install kong-release kong/kong  -f ./ override.yaml --version=2.14.0

Check kong proxy ingress certificate

curl  -vv https://<kong-proxy-ingress> 2>&1  | grep -E  "start|expire"

Renew the certificate using

cmctl renew -n kong  kong-proxy-cert

Check again  kong proxy ingress certificate
Verify that certificate didn't get updated
Run kong reload inside all kong proxy pod ( or rollout restart the deployment )
Re-check kong proxy ingress certificate
Verify that certificate got updated this time

Anything else?
No response

if you deploy Kong with DB-less deployment, see: https://github.com/Kong/charts/blob/main/charts/kong/README.md#db-less-deployment
there’s no good way to rotate ssl certs, since pushing config is entirely up to the controller, and there’s no designated way to manually trigger a push. link: https://discuss.konghq.com/t/how-to-rotate-mtls-certificates-for-upstream-service/7864/2

Nginx ingress controller is able to do this check here , I don't seee why it can't be done in kong runloop

We recommend using Kong Ingress Controller for automating with k8s and k8s-oriented tooling like cert-manager.
If that is not an option for you, please use Kong's Admin API to install the default proxy certificate. You can do so by creating a Certificate resource in Kong via Kong's Admin API and then associating an SNI resource with name as *. See this PR that adds this feature.
Reloading Kong automatically on file changes can lead to unexpected issues so we don't do it and we have not plans to do that.

We are already using kong ingress controller but since ssl termination is handled by the proxy there is not much to tweak on KIC .
Loading proxy through the Admin API is not feasible  the deployment will fails without a certificate .
Is there an API endpoint for reloading kong similar to kong reload commad line  ?
Other options will be through a Plugin , but not sure if possible.

@Kong/team-k8s Is there a way to configure the fallback TLS certificate using a CR in KIC?

There's no need for a CR; the configuration in the OP is correct for the fallback certificate.
In general I'd recommend against using the fallback certificate. Proxy certificates should be managed through their Ingress's configuration. Non-fallback certificates are update on the fly, and cert-manager should be able to manage Ingress-associated certificates as well as the fallback.
There isn't a mechanism to get running instances to load a new fallback if the mounted Secret changes and updates the files in the container FS. Gateway could add something to watch those files and trigger a reload if they change, but I wouldn't expect that to get prioritized. Expected usage is that you use Ingress certs, not the fallback. The fallback is handled by NGINX code, so that's not somewhere I'd expect us to add new functionality.

There's no need for a CR; the configuration in the OP is correct for the fallback certificate.

The fallback certificate can be configured using the Admin API of Kong via a special SNI value of *.
AFAIK, there isn't a way to configure this via Ingress or any of the existing CRs.
Should it not be possible to configure the fallback certificate via a k8s resource, perhaps Gateway API has an answer? Perhaps we can (ab)use Ingress to do that as well?
What I was hoping was for a mechanism that gives KIC enough information so that it can dynamically configure the fallback certificate via the API rather than asking the user to deal with mounting secrets and reloading Kong.

Ingress and Gateway both have proscribed means of configuring certificates, and expected usage is that you use them. Our fallback cert is a vendor quirk and should not be something we recommend as standard configuration.
Gateway API doesn't really provide for a fallback certificate as a defined concept, but AFAIK https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.Listener Hostname does let you specify * if you really want to (you shouldn't, please, at least provide some sort of *.example.com instead) if you so desire.

As per API doc , there still no guarantee that  the certificate will reflect the k8s resource when updated

Dear contributor,
We're closing this issue as there hasn't been any update to it for a long time. If the issue is still relevant in the latest version, please feel free to reopen it. We're more than happy to revisit it again.
Please have a look at our pledge to the community for more information.
Sincerely,
Kong Gateway Team


Google Drive storage handler

Add a storage handler to allow shows to be stored in Google Drive Shared Drives.

The main difference to handle with this is that Google Drive identifies files by ID instead of by path -- indeed, two different files can have the same traditional "path". We therefore need a way to either store the file IDs, or traverse the file structure to find what we want and gracefully handle the possibility of two files having the same path (perhaps we can look at how Google Drive acts in this situation within the Drive app as inspiration).

To handle the fact Google Drive refers to file IDs instead of paths requires larger changes to the system which I'm not sure I have time to get into at the moment. I think as a current solution, I'll write some documentation about how to use rclone to mount any cloud storage of your choice onto a server, and then use the "local" storage system to store the show files. While not as native, it gives the flexibility of supporting all the cloud storage providers rclone does, and means less code to maintain while I'm working on this myself.
I need to test this before finalising on this idea.

The above idea works. You can use [rclone mount](https://rclone.org/commands/rclone_mount/), probably with the --vfs-cache-mode writes option, to mount your cloud storage of choice, then set this tool to use the mounted remote storage as a "local" storage location.


How can I set the different style between actived and inactived cell.

Use the otpFieldStyle property of the Widget:
Example:
otpFieldStyle: OtpFieldStyle(
      focusBorderColor:
          Theme.of(context).primaryColor,
    ),


{DEMO} Test auto reply and set milestone

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command

Describe the bug

To Reproduce

Expected behavior

Environment summary

Additional context

Thanks for the report @wangzelin007! We will look into it ASAP!

Hi @wangzelin007, Since the current milestone time is less than 21 days, this issue will be resolved in the next milestone


Build error when include ScreenCaptureKit

apple-sys = { version = "*", features = ["ScreenCaptureKit"] }

/Users/bigduu/.cargo/registry/src/github.com-1ecc6299db9ec823/apple-sys-0.2.0/ScreenCaptureKit.h:1:2: fatal error: malformed or corrupted AST file: 'duplicate DECL_OFFSET record in AST file'
/Users/bigduu/.cargo/registry/src/github.com-1ecc6299db9ec823/apple-sys-0.2.0/ScreenCaptureKit.h:1:2: note: after modifying system headers, please delete the module cache at '/var/folders/xw/5cb3hk_x61zfbcyf_8ww7zlm0000gn/C/clang/ModuleCache/Z1130PPJ7JDN'
thread 'main' panicked at 'libclang error; possible causes include:

Invalid flag syntax
Unrecognized flags
Invalid flag arguments
File I/O errors
Host vs. target architecture mismatch
If you encounter an error missing from this list, please file an issue or a PR!', /Users/bigduu/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.63.0/ir/context.rs:530:15
stack backtrace:
0: rust_begin_unwind
at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/panicking.rs:579:5
1: core::panicking::panic_fmt
at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/panicking.rs:64:14
2: core::panicking::panic_display
at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/panicking.rs:147:5
3: core::panicking::panic_str
at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/panicking.rs:131:5
4: core::option::expect_failed
at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/option.rs:2045:5
5: core::option::Option::expect
6: bindgen::ir::context::BindgenContext::new
7: bindgen::Bindings::generate
8: bindgen::Builder::generate
9: apple_bindgen::builder::Builder::generate
10: build_script_build::main
11: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

Could you share more details?
I can't reproduce it on macOS 13.3.1 with MacOSX13.3.sdk
Even more, It is libclang error. apple-sys don't have much things to do with libclang error. apple-sys uses bindgen, and bindgen uses libclang.

Please update llvm if your llvm version is an old one.


Feature - Show Jira priority in the Jira Table

Describe the feature
Currently the Jira table shows the Key, Summary, Status and Assignee.
It would be a nice enhancement to add the priority as a column in this table to allow users to quickly idenfiy the highest priority items of unassigned Jiras.
Added value
This enhancement would allow me as a user to use the Jira dashboard more as a central point to view all tickets without having to navigate to Jira to see priority therefore allowing me to assign myself high priority tickets sooner.

Hi @mark-con !
Thank your for your great suggestion. The Axis-Backstage team will discuss this at our next stand-up :+1:
I'll get back to you as soon as I can!

Hi again @mark-con!
I've discussed this feature with the team and it's a great idea. Let's add the Jira priority to the table!
We look forward to an PR. Let us know if you don't have the possibility to implement this and we will add it to our backlog. :1st_place_medal:

Hi @fridajac,
Thanks for taking on the suggestion.
I will begin working on a PR for this change this week.


Incorporate tests from WPT and make parser more compliant

fixes #8
fixes #17
and a bunch of other fixes detailed in the commits.
The test suite still have failures due to lack of "REGION" support
all the files in test/wpt-file-parsing were generated from the WPT test suite, with a slightly modified build.py to also export js files separately
--- a/webvtt/parsing/file-parsing/tools/build.py
+++ b/webvtt/parsing/file-parsing/tools/build.py
@@ -88,6 +88,8 @@ def generate_test(test_path, output_dir):
     vtt_file_path = path.join(vtt_file_dir, vtt_file_name)
     vtt_file_rel_path = path.join('support', vtt_file_name)

+    js_file_path = path.join(vtt_file_dir, test_basefilename + '.js')
+
     # Write html file
     with open(html_file_path, 'w') as output:
         html = (TEMPLATE.replace('%test_name', test_name)
@@ -96,6 +98,8 @@ def generate_test(test_path, output_dir):
                         .replace('%vtt_file_rel_path', vtt_file_rel_path))
         output.write(html)

+    with open(js_file_path, 'w') as output:
+        output.write(test_js)

Wow, cool. I'm inclined to accept this as-is. Is it okay if I squash things? Also, I'm wondering if there's a better home for this project somewhere as I'm not interested in driving this much myself anymore.

Actually, rebase and merge might be good since the commits are all clean.

re new home, I could bring it over in @w3c (with a new repo name given that w3c/webvtt is where the spec is developed); I'm happy to maintain it for now given that it matches an itch I need to scratch
re merging approach, I've tried to keep the commits atomic and meaningful, but I'm happy for you to take the approach you prefer

Sounds reasonable. I can transfer it to you and then you can transfer it there.

It seems like you'll need to delete the fork first.

fork deleted


Some misc updates

Delete generated/unneeded files
Update gradle wrapper to 6.4.1 using git bash
Update buildTools and added Java 1.8 support
Use Java 1.8 lambdas and a few other things
Update README badges

Thanks for the pull request. I'll test it when I get the chance and merge it if there are no issues.


Update the windows pinned toolchain to bcny swift-6.0.0-20241216.0

https://github.com/thebrowsercompany/swift-build/releases/tag/swift-6.0.0-20241216.0
which has the arm64 compiler fixes.

still lgtm


Policy representation: refinement on action is not parsed correctly

Bug Report
Describe the Bug
One of the most popular policies that would be used in data spaces is the one that regards payment obligation.
I tried the typical way that payment is represented in ODRL (inspired by Example 20 in the official odrl model page https://www.w3.org/TR/odrl-model/#duty-policy), which is defined as a refinement on the action of "odrl:compensate", but EDC cannot parse it properly and produces an error during policy creation.
Expected Behavior
ECD was expected to parse and store the following policy during policy creation:
{
    "@context": {
        "@vocab": "https://w3id.org/edc/v0.0.1/ns/",
        "edc": "https://w3id.org/edc/v0.0.1/ns/",
        "rdfs": "http://www.w3.org/2000/01/rdf-schema#",
        "dcat": "http://www.w3.org/ns/dcat#",
        "xsd": "http://www.w3.org/2001/XMLSchema#",
        "foaf": "http://xmlns.com/foaf/0.1/",
        "rdf": "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
        "adms": "http://www.w3.org/ns/adms#",
        "dcmitype": "http://purl.org/dc/dcmitype/",
        "skos": "http://www.w3.org/2004/02/skos/core#",
        "dct": "http://purl.org/dc/terms/",
        "odrl": "http://www.w3.org/ns/odrl/2/",
        "owl": "http://www.w3.org/2002/07/owl#",
        "cc": "http://creativecommons.org/ns#",
        "dalicc": "https://dalicc.net/ns#",
        "dalicclib": "https://dalicc.net/licenselibrary/",
        "osl": "http://opensource.org/licenses/",
        "prov": "http://www.w3.org/ns/prov#",
        "spdx": "http://spdx.org/rdf/terms#",
        "example": "http://www.example.com/"
    },
    "policy": {
        "@type": "odrl:Set",
        "dct:description": {
            "@language": "en",
            "@value":"Payment Once - odrl:compensate"
        },
        "dct:title": {
            "@language": "en",
            "@value": "Payment Once - odrl:compensate"
        },
        "odrl:permission": [
            {
                "@type": "odrl:Permission",
                "odrl:action": {
                    "@id": "odrl:use"
                }
            }
        ],
        "odrl:obligation": [
            {
                "@type": "odrl:Duty",
                "odrl:action":
                {
                    "rdf:value": {
                      "@id": "odrl:compensate"
                    },
                    "odrl:refinement": [
                      {
                        "odrl:leftOperand": {
                            "@id": "odrl:payAmount"
                        },
                        "odrl:operator": {
                            "@id": "odrl:eq"
                        },
                        "odrl:rightOperand": {
                            "@type": "http://www.w3.org/2001/XMLSchema#decimal",
                            "@value": "100.0"
                          },
                        "odrl:unit": "http://dbpedia.org/resource/Euro"
                      }
                    ]
                }
            }
        ],
        "odrl:prohibition": null
    }
}

Observed Behavior
EDC returns the following error during creation:
  [
               {
                 "message": "Failed to construct instance: type",
                 "type": "InvalidRequest",
                 "path": null,
                 "invalidValue": null
               },
               {
                  "message": "ARRAY must be org.eclipse.edc.policy.model.Action but was: unknown",
                  "type": "InvalidRequest",
                  "path": null,
                  "invalidValue": null
              }
]

Context Information
Used version EDC v0.8.0
Possible Implementation
I believe the problem lies in the "rdf:value" property.

This is not a feature we will implement. The DSP specification profiles ODRL, meaning only a subset of the possible serializations are supported.
The specification group is currently refining its JSON Schemas to explicitly not require conformant implementations to support anything beyond the normative serialization.
An implementation may, of course, support this type of extensibility, but the EDC won't, so I am closing this.

Thank you for clarifying these issues. Is it possible to point me to the documentation of the DSP specification profiles ODRL  and the  JSON Schemas from the specification group that the EDC is and will support, so that I can study them and see if and how an equivalent representation of this important policy for our dataspace could be represented within the limitations imposed by the DSP specification profiles ODRL and the EDC implementation?
Thank you in advance.


Add dubbo generic convert example

Motivation:
update sofaboot and rpc  version
update starter version
change sofaboot-* log to *.log
add dubbo generic use demo
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #75   +/-   ##
========================================
  Coverage      55.8%   55.8%
  Complexity      355     355
========================================
  Files            51      51
  Lines          1620    1620
  Branches        274     274
========================================
  Hits            904     904
  Misses          555     555
  Partials        161     161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e67ec9...3d78133. Read the comment docs.


Remove duplicate key from action.yml

I noticed this duplicate key, wanted to help out ;-)

Thank You!


Firefox version

Is it possible to create also a (release) version that works with Firefox?

https://github.com/TheGoddessInari/netflix-1080p-firefox

Problem is that this add on is not signed

Also, it does not have any update for cadmium playercore for the recent U3013 errors.

Maybe you can replace the playercore from the Firefox repo with the one from this repo? Would be worth a shot at least.
I'm personally not using Firefox and have no intention of maintaining even more versions of this extension, sorry.


Should log import errors when using batch.add_object

I spent a while importing millions of objects into weaviate with batch.add_object, without any errors.
Problem is all of my properties didn't conform to the right datatypes (my mistake).
I would've loved for the Weaviate Client to at least print the import errors, it would have saved me a lot of time knowing it was all loading for nothing.
Thanks!

you can do
with collection.batch.dynamic() as batch
    ... do your things...
    if batch.number_errors > 10: # what ever number you like
         break

print(batch.failed_objects)

@dirkkul that's much clearer thanks. Didn't know it was included in the lib.

you're welcome! We are still working on the docs and are continously expanding them :)


Enable single dedicated page for every session

Partially Fixes the issue #1314
Changes:

Provides an option for selecting a single dedicated page for each session or a common page for all the sessions.

Deployment Link

Server: http://secure-meadow-20680.herokuapp.com

Two points are still not completed:

Make the rooms name into a link to the rooms list of the day
Make the tracks name into a link to the track of the day
There are some complications due to which these two couldn't be done in this PR. I will open an issue outlining the problems and possible solutions. But please review this. Thanks!!
@aayusharora @geekyd @mariobehling

What is happening? Why codeclimate is falling on each PR @princu7 @geekyd ?

@aayusharora Don't really know. The added code in the PR will lead to a decrease in the code coverage of the entire project by some margin as visible in the CodeCov comment. Maybe because of it, it is failing.
@aayusharora @geekyd Updated the PR and the server link. Please review. Thanks!!
http://secure-meadow-20680.herokuapp.com

You need to write tests then, these tests should always pass to ensure that the previous functionalities are working.
Please fix it so I can review this PR.
@mariobehling What's your suggestion in this ?

@aayusharora Added tests and resolved conflicts. Please review. Thanks

Can you pass code of tests for this PR, also update the description as 'partially fixes'.
Thanks @Princu7

I have removed most of the codacy issues. The rest of them don't make much sense. Please review. Thanks :)

This contains my commit to in commit history @Princu7 104550a

@aayusharora Yep. Nothing bad. It's just that you updated the branch with the latest changes in the repo via the Github UI so it's showing that commit. Rebasing and sending again :)

@geekyd  can u approve this, @Princu7 can u check the review of @geekyd
It needs to be approved before merging.

@aayusharora Yep. Already made those changes along with the additional requirements. @geekyd Can you please review again? Thanks :)

@Princu7 Great Work :+1: !


added my profile to the team.md file

Description
added my details in team.md

Please make your addition in the table.

Please make your addition in the table.

done, thanks

I think I am getting some formatting issue here


ModuleNotFoundError: No module named 'pyLDAvis.gensim'

Hi Andrew,
I found this ModuleNotFoundError while running the line

from kwx.model import extract_kws

Error description:
25 import pandas as pd
26 import pyLDAvis
---> 27 import pyLDAvis.gensim
28 import seaborn as sns
29 from gensim import corpora
ModuleNotFoundError: No module named 'pyLDAvis.gensim'
But, it can be solved by installing :
pip install pyLDAvis==3.2.2

Hi Abhishek, and thanks for your interest and reporting this!
It looks like later versions of pyLDAvis changed the logic of how the gensim module was passed, and it's now gensim_models or gensimvis - see their history. The environment and requirement files for kwx have a valid 3.2.0 version as a dependency, so I'll leave this for now, but thank you for the documentation on this!
Let me know if there's something explicit you think should happen :)

Or actually, sorry, I will take a look at this and see if there's a way to get this working on the most recent version of pyLDAvis. Will update you on the progress of this, and thanks for reporting :)

Literally was as easy as updating to the most recent version and switching import pyLDAvis.gensim to import pyLDAvis.gensim_models as well as its usage in the code. I've also updated the requirements and environment files to reflect that the most recent version is necessary :) All this is going through in #29.
Thanks again for these issues! Were very helpful 😊

Thanks, Andrew!

@AbhiPawar5, did you do a pip install update, as in:
pip install kwx -U

I did do an update of PyPI (FYI - capital I in PyPI, which is a common mistake 😊). If it's still happening with an update then I'll reopen this and give it another look :)


Add nonce to tx

Details
We would want to send txs with nonce to prevent errors pertaining to stale/duplicate txs

Add a nonce service (copied from content publishing)
Pass nonce to signAndSend

Tests:

[x] run a full migration test

Closes #80

All tests have passed and no errors were seen that were seen before Nonce got introduced.


Add remark about non-glibc based distros in WSL docs

Signed-off-by: Simon Ferquel<EMAIL_ADDRESS>
Proposed changes

This adds a remark about the glibc dependency in Docker Desktop WSL backend.
Related issues (optional)

@stephen-turner do you still have changes in mind (aside from the vocabulary fix we need to plan - with fixing that in the desktop UI as well)

No, no more changes, it looks good to me now.


Additional Mod Incompatibilities that I've discovered

Hello, I know that this addon is still in a current alpha phase, however I wanted to make you aware of some mod incompatibility issues that I've encountered most recently involving some of the mods listed below:

Magnesium/Rubidium Extras [by TeamDeusVult]: "Causes Rendering Errors for Half of Modeled Entities"
(Alternative: Rubidium, Rubidium Extras, and Rubidium Toolkit seems to be a somewhat decent workaround);

Performant [by someaddon]: "Causes Issues with entities colliding with ships/ mobs phase through without collisions"
(Alternative: Have this addon completely uninstalled if you want entity collisions with your ships)

TRansliterationLib [by tr9zw]: "Trying to access config files using a config menu will cause the game to Crash"
(Alternative: Do not open VS/Eureka configs through the a game menu using mods like Catalogue/Configured and etc.)

Use rubidium, VS is only compatible with the latest version of sodium and magnesium is outdated

I also forgot to mention above. this is using Forge 1.16.5-36.2.39;


feat: update golang-github-mwitkow-go-conntrack to 0.0_git20190716.2f06839

Go middleware for net.Conn tracking
Issue: https://github.com/linuxdeepin/developer-center/issues/3965
Log: update repo

/test all


refactor: allow coercion inputs to work with async pipe

We need to accept null and undefined for coercion members
to make them work with the async pipe. The overall problem
remains for other non-coercion inputs, but since the majority
of inputs are coerced, we only make the change to these.
The overall problem applies to all inputs, but it's not clear
yet how this issue can be solved for all inputs. This involves
discussion with the framework team.
More information: https://hackmd.io/@devversion/rkKOD8ZjB

We could consider adding type aliases so that we don't repeat boolean | string | null | undefined everywhere, e.g.: BooleanInput, NumberInput

@mmalerba Sounds like a good idea to me. We can do that as a follow-up if we all think it's reasonable. I'd be happy to switch to that.

Follow-up PR would be good


Update the docker?

Can you update the docker file / docker code. I am unable to run this since the docker changes from microsoft and the .net 5 change.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbdd9c30-1bc1-7af6-158d-f65ad23f45b7
Version Independent ID: c8828014-4369-ead5-2d05-8c3e823fc93e
Content: Create Logic Apps Preview workflows in Visual Studio Code - Azure Logic Apps
Content Source: articles/logic-apps/create-stateful-stateless-workflows-visual-studio-code.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@zimmerab Thanks for the question! We will review and get back to you!

@zimmerab the dockerfile is the same as the one generated for Azure Functions when running func init --docker-only and as the doc mentions in this section, .NET 5 isn't supported and suggests a global.json file to lock the version used.
Also, the local dotnet version wouldn't affect the docker build. Could you share more details on the error that you are seeing?

@zimmerab Just following up here... Hope my previous comment clears things up.
If you are still seeing a problem, could you share more details on the error?

I have gotten my logic app to build in the dockerfile but it doesn't create
a folder in the azure-webjobs-secrets container.  Is there a way to force
secrets to be created in a docker file for logic apps?
FROM mcr.microsoft.com/dotnet/core/sdk:3.1 AS installer-env
COPY . /src/dotnet-function-app
RUN cd /src/dotnet-function-app &&
mkdir -p /home/site/wwwroot &&
dotnet publish *.csproj --output /home/site/wwwroot
FROM mcr.microsoft.com/azure-functions/dotnet:3.0
ENV AzureWebJobsStorage="{secret storage container}"
ENV AzureWebJobsScriptRoot=/home/site/wwwroot
AzureFunctionsJobHost__Logging__Console__IsEnabled=true
FUNCTIONS_V2_COMPATIBILITY_MODE=true
WEBSITE_HOSTNAME=localhost
AZURE_FUNCTIONS_ENVIRONMENT=Development
COPY --from=installer-env ["/home/site/wwwroot", "/home/site/wwwroot"]
On Mon, Dec 28, 2020, 12:04 AM Pramod Valavala<EMAIL_ADDRESS>wrote:

@zimmerab https://github.com/zimmerab Just following up here... Hope my
previous comment clears things up.
If you are still seeing a problem, could you share more details on the
error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/67992#issuecomment-751589857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADVLWHVRRURUQZLPEHRYKDTSXANU7ANCNFSM4VE2CJ4A
.

@zimmerab Ensure the connection string is correct and the environment where the docker container is running allows outbound connections to Azure Storage.
An alternative would be to set AzureWebJobsSecretStorageType to files. This approach is covered in this comment and even includes how you could use your own keys, even in Kubernetes, if you are deploying this container to it.


Dev/err stack

provides stack trace informations
fixes #10

This issue was moved to go-hep/sw#27


Test code ownership

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3594   👈

This comment was auto-generated by Graphite.


can deck.gl read the 3Dtiles city model of caesium?

I want to load the caesium's b3dm file into deck.gl.
I know that there is a tile 3D layer API in deck.gl.
but I don't know how to use it.
The official case is only the 3Dtiles of the point cloud, not the city model

@marc111
Tile3DLayer supports .b3dm tiles. Tile3DLayer is still experimental, it may has some issues.
We are scheduled to release a new version of deck.gl (v8) soon, should have a better version of Tile3DLayer


feat: initial admin key can be either a file or the actual key

read it if it's a file
otherwise parse the keys in SOFT_SERVE_INITIAL_ADMIN_KEY

I changed this around a bit on #68 if you wanna check it out... not sure this would still be necessary


[$250] Remove the New Workspace option from Global Create for members of existing group workspace.

Proposal: Remove the New Workspace option from Global Create for members of existing group workspace.
Background: Thousands of existing OldDot members land in NewDot on a daily basis, whether to interact with services like Guides, Account Managers (AMs), or Concierge. Once in NewDot, Full Story sessions reveal that members commonly explore our new product and the features available.
Problem: When submit employees that already belong to a existing group workspace see the New Workspace option, they unintentionally create more workspaces, which causes confusion and prevents them from submitting expenses to their employer.
Solution: Remove the New Workspace option from Global Create for all members that already belong to a group workspace – streamlining their experience by reducing confusion and preventing accidental workspace creation. Additionally, we’ll universally promote a single way to create your second, third, fourth or an infinite number of workspaces via one centralized flow in Settings > Workspaces.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021851027135757622934
Upwork Job ID:<PHONE_NUMBER>757622934
Last Price Increase: 2024-10-28

Issue OwnerCurrent Issue Owner: @sobitneupane

@sobitneupane Do you mind reviewing this proposal when you're able? This is causing quite a bit of confusion for existing members, I'd like to get ahead of it.

@JmillsExpensify Is there any way to reproduce this bug for the contributor account?

I could not reproduce the issue. @NJ-2020 Were you able to reproduce the issue? Can you please add reproduction steps?

Thanks, @NJ-2020.
If I'm not mistaken, there should also be a #announce room and a workspace chat room when the user is redirected to newDot. It seems like these are missing, which might be related.

@NJ-2020 I don't think that's the case when the user is invited from newDot.

Yes this flow is possible when a member doesn't have a workspace chats enabled workspace, but signed into NewDot. So generally you'd create a workspace on OldDot via user A, then invite user B. Sign in as user B to NewDot and you should see the option to create a New Workspace.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove the New Workspace option from Global Create for members of the existing group workspace
What is the root cause of that problem?
When we create a control WS in OldDot, isPolicyExpenseChatEnabled is false so there are no WS  that match the condition here
https://github.com/Expensify/App/blob/780a236fb9d1bd55790eaf22b1e6ce0a3ba1bfe2/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx#L457
What changes do you think we should make in order to solve the problem?
If we want to not display the New Workspace option when the user already has a WS even isPolicyExpenseChatEnabled is false. To do that we only need to filter out the personal WS here
const chatEnabledPolicies = Object.values(policies ?? {}).filter(
    (policy) => policy?.type !== CONST.POLICY.TYPE.PERSONAL && (!includeOnlyAdminPolicies || policy?.role === CONST.POLICY.ROLE.ADMIN),
);

https://github.com/Expensify/App/blob/66195ad78fd1fab200ee82e2d530ec38e2947587/src/libs/actions/Policy/Policy.ts#L255-L258
What alternative solutions did you explore? (Optional)

@nkdengineer Is there any reason for isPolicyExpenseChatEnabled  to be false? What do you think about missing policy expense chats?

I believe we should set isPolicyExpenseChatEnabled to true even when the policy is created and the user is invited from oldDot, as we want to display the policy expense chat. If there's no specific reason for it to be set to false, we should first check this on the backend.
🎀 👀 🎀 C+ reviewed

Agree with @nkdengineer. We're setting isPolicyExpenseChatEnabled to false by design, as the backend doesn't support the majority of OldDot workspaces. Further BE performance optimizations are needed, and in addition, we have to migrate customer data. So we shouldn't be setting isPolicyExpenseChatEnabled to true but instead respect whatever it's currently set to.

@sobitneupane any final thoughts on @nkdengineer's clarifications?

This can we pick up the pace on this issue? This is one of the biggest sources of customer dissatisfaction, so we've got to get on this one and get a PR in place.

We can proceed with @nkdengineer's proposal for now to resolve this ASAP, but the issue mentioned in https://github.com/Expensify/App/issues/51616#issuecomment-2447236475 will still persist.
cc: @Julesssss

@nkdengineer If there are more than 4 members, do we display #announce room for the workspace created in old dot? Do we display workspace chat?

I think the policy expense chat only displays when isPolicyExpenseChatEnabled is true.

That's correct.

Alright, so we all agree that when isPolicyExpenseChatEnabled is true for the OldDot workspaces the button won't be displayed.

To do that we only need to filter out the personal WS here

Though I'm not sure I agree with the solution yet. If the problem is that members of an OldDot submit workspace are being excluded from the filter, filtering out the personal workspaces wouldn't solve that case, right?
My understanding is that we'll need to set isPolicyExpenseChatEnabled correctly on the backend for the OldDot workspaces that are currently not marked true.
Also this should be independent of whether the chats are showing (as this simply depends on the amount of users in the workspace).

That's a good point @Julesssss. Why wouldn't we simply look for whether the user is a member of any Team or Corporate type policies?

That's a good point @Julesssss. Why wouldn't we simply look for whether the user is a member of any Team or Corporate type policies?

That is what shouldShowPolicy doing

I'm just noting here that the issue only seems to be reproducible if you open the concierge chat before signing into NewDot. While I continue to test out the proposals, does anyone have a theory for why that is? Of course, we will still move forward, but it seems odd, and I'd like to fully understand the underlying issue.

@Julesssss The issue will happen if the user is invited to a WS that is created in OldDot or created a WS in OldDot (which has isPolicyExpenseChatEnabled is false). I think in this case above, you selected Manage my team's expense that will create a new WS in NewDot with isPolicyExpenseChatEnabled as true then New Worksapce button doesn't appear because hasActiveChatEnabledPolicies function is filtering the WS with isPolicyExpenseChatEnabled as true.
https://github.com/Expensify/App/blob/66195ad78fd1fab200ee82e2d530ec38e2947587/src/libs/actions/Policy/Policy.ts#L254-L258
If you sign up in NewDot and don't select Manage my team's expense in the onboarding flow then another user invited you to a WS that is created in OldDot, you can also reproduce this bug.

The issue will happen if the user is invited to a WS that is created in OldDot or created a WS in OldDot
I think in this case above, you selected Manage my team's expense

Thanks. I have been creating both my users and workspaces in OldDot and I also have never selected 'Manage my team's expense' though, so there must be another step I am missing 😕
Are you using private or public domain users?

I'm using outlook email.

Can you share the full video then we can see what is happening.

If you sign up in NewDot and don't select Manage my team's expense in the onboarding flow then another user invited you to a WS that is created in OldDot, you can also reproduce this bug.

This also doesn't work for me. Would you mind listing out the full steps, because I am completely unable to reproduce currently (examples below)

I think in this case above, you selected Manage my team's expense that will create a new WS in NewDot with isPolicyExpenseChatEnabled as true

So isPolicyExpenseChatEnabled was true for me when debugging, but this condition is what caused the button to not display (an undefined action), so perhaps that explains our different results?
https://github.com/user-attachments/assets/d8e5163d-2dab-4d12-a6e8-3a3ac445f7c1
https://github.com/user-attachments/assets/dc6c9b17-7df1-4683-87c7-1b1e2ecfd21c

You need to create a new WS like this to reproduce.
https://github.com/user-attachments/assets/f164aead-9b85-4033-806b-59308a759667

Thank you. Wow that is an annoying gotcha 😩😭
Okay great, I am totally on board with your proposal. Your solution was written way before than @NJ-2020 and @twilight2294's proposals.

Yeah, wow thank you @nkdengineer for clearing this up! Apologies I didn't make this more clear from the beginning.

Payment summary:

Contributor: @nkdengineer $250
Reviewer: @sobitneupane $250

Contributor paid out. Review can complete the checklist and request via NewDot. Closing this issue.

Regression Test Proposal:

Account A: login into OD
A: Create a Workspace and invite new user B
Account B: login to ND
B: Press FAB
B: Verify that: New workspace option is not shown

Do we agree 👍 or 👎

$250 approved for @sobitneupane


xData rename to data

As discussed in Slack.

I think a function here is less likely to have conflicts or provide alternatives to conformers. data is a pretty common word and I've seen it attributed to things like [UInt8].