Update changelog.yml

Switch to actions/checkout@v4
Pre-Review Checklist for the PR Author

[ ] Code follows the coding style of CONTRIBUTING.md
[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[ ] Branch follows the naming format (iox-123-this-is-a-branch)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[ ] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[ ] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[x] Code according to our coding style and naming conventions
[x] Unit tests have been written for new behavior
[x] Public API changes are documented via doxygen
[x] Copyright owner are updated in the changed files
[x] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[x] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes TBD

@mosfet80 thanks for your contribution. Could you please change the commit message to iox-#2011 Upgrade checkout action?
I've created #2011 explicitly to have an ongoing issue which issue number can be used for this kind of PRs. We require this commit message format for traceability reasons since iceoryx will be used in safety critical environments.
It is also possible to have multiple commits per PR. This will also ease the process.

@mosfet80 we really appreciate your contributions but there is a formalism which needs to be followed before this can be merged

@mosfet80 can you please apply the changes I mentioned in my first comment to get this PR merged

@mosfet80 closing this issue since there where more deprecation warnings than the one from this PR. All of them are fixed with https://github.com/eclipse-iceoryx/iceoryx/pull/2181/commits/9b7959f63209d61edd95eb857b49ce8cc87d183d.
We really appreciate your contributions and that you are looking into the CI issues but please also take care of the formalism with your next PR.


The lines are not visible on build

I downloaded the repo and copied the Assets/LineRenderer2D folder to my project. I fixed the shader errors using this commit.
I put MultiLineRenderer2D prefab to the scene and adjusted the points. It is visible in the editor window but when I build the game, it becomes invisible. Is there a way to fix it?

Hi, which version of Unity are you using?
Are you using the Shadergraph version or the shader scripts version of the line renderer 2d?

I tried both P_SG_MultiLine.prefab and P_S_MultiLine.prefab.


Research API implementation

Researched different API implementations, thinking of ExpressJS for API.

Researched different API implementations, thinking of ExpressJS for API.


i18n default as browser lang

Its possible to make browser lang as root?

activate :i18n, mount_at_root: :en

https://middlemanapp.com/advanced/localization/#default-root-language

I was wondering if a guy from spain enter the website, root will be spanish, if is someone from UK will be english.

No, you will be building a static site which has no logic of its own. You can use your web server to detect location and redirect to the correct folder as a result.


fix horizontal-pod-autoscale.md url error

fix custom-metrics-apiserver  repo url

/assign @chenrui333

Thank you for proposing this fix. However, we will not merge partial fixes as per stated in the guideline. To find out what are the upstream changes to be synced, do this:
./scripts/lsync.sh content/zh/docs/tasks/run-application/horizontal-pod-autoscale.md

Thank you for proposing this fix. However, we will not merge partial fixes as per stated in the guideline. To find out what are the upstream changes to be synced, do this:
./scripts/lsync.sh content/zh/docs/tasks/run-application/horizontal-pod-autoscale.md

I execute this script. No changes need to bo synced.

the english version doc:
If you would like to write your own, check out the [boilerplate](https://github.com/kubernetes-sigs/custom-metrics-apiserver) to get started.
the  thanslated :
如果你想自己编写，请从 [boilerplate](https://github.com/kubernetes-sigs/custommetrics-apiserver)开始。
but this translated version contained url can't vistit.
The correct url is https://github.com/kubernetes-sigs/custom-metrics-apiserver

@dabaooline You cannot execute the command in your current branch (which is already "polluted"). Please switch to a clean branch (such as "master") to run the command. Below are outputs from my end for your reference:
$ ./scripts/lsync.sh content/zh/docs/tasks/run-application/horizontal-pod-autoscale.md
diff --git a/content/en/docs/tasks/run-application/horizontal-pod-autoscale.md b/content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
index ff51598f7..763d9ab99 100644
--- a/content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
+++ b/content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
@@ -191,7 +191,7 @@ We can create a new autoscaler using `kubectl create` command.
 We can list autoscalers by `kubectl get hpa` and get detailed description by `kubectl describe hpa`.
 Finally, we can delete an autoscaler using `kubectl delete hpa`.

-In addition, there is a special `kubectl autoscale` command for easy creation of a Horizontal Pod Autoscaler.
+In addition, there is a special `kubectl autoscale` command for creating a HorizontalPodAutoscaler object.
 For instance, executing `kubectl autoscale rs foo --min=2 --max=5 --cpu-percent=80`
 will create an autoscaler for replication set *foo*, with target CPU utilization set to `80%`
 and the number of replicas between 2 and 5.
@@ -221,9 +221,9 @@ the global HPA settings exposed as flags for the `kube-controller-manager` compo
 Starting from v1.12, a new algorithmic update removes the need for the
 upscale delay.

-- `--horizontal-pod-autoscaler-downscale-stabilization`: The value for this option is a
-  duration that specifies how long the autoscaler has to wait before another
-  downscale operation can be performed after the current one has completed.
+- `--horizontal-pod-autoscaler-downscale-stabilization`: Specifies the duration of the
+  downscale stabilization time window. Horizontal Pod Autoscaler remembers
+  the historical recommended sizes and only acts on the largest size within this time window.
   The default value is 5 minutes (`5m0s`).

 {{< note >}}
@@ -383,7 +383,12 @@ behavior:
       periodSeconds: 60

-When the number of pods is more than 40 the second policy will be used for scaling down.
+periodSeconds indicates the length of time in the past for which the policy must hold true.
+The first policy (Pods) allows at most 4 replicas to be scaled down in one minute. The second policy
+(Percent) allows at most 10% of the current replicas to be scaled down in one minute.
+
+Since by default the policy which allows the highest amount of change is selected, the second policy will
+only be used when the number of pod replicas is more than 40. With 40 or less replicas, the first policy will be applied.
For instance if there are 80 replicas and the target has to be scaled down to 10 replicas
then during the first step 8 replicas will be reduced. In the next iteration when the number
of replicas is 72, 10% of the pods is 7.2 but the number is rounded up to 8. On each loop of
@@ -391,10 +396,6 @@ the autoscaler controller the number of pods to be change is re-calculated based
of current replicas. When the number of replicas falls below 40 the first policy (Pods) is applied
and 4 replicas will be reduced at a time.
-periodSeconds indicates the length of time in the past for which the policy must hold true.
-The first policy allows at most 4 replicas to be scaled down in one minute. The second policy
-allows at most 10% of the current replicas to be scaled down in one minute.
The policy selection can be changed by specifying the selectPolicy field for a scaling
direction. By setting the value to Min which would select the policy which allows the
smallest change in the replica count. Setting the value to Disabled completely disables
@@ -441,7 +442,7 @@ behavior:
periodSeconds: 15
selectPolicy: Max
-For scaling down the stabilization window is _300_ seconds(or the value of the
+For scaling down the stabilization window is _300_ seconds (or the value of the
`--horizontal-pod-autoscaler-downscale-stabilization` flag if provided). There is only a single policy
for scaling down which allows a 100% of the currently running replicas to be removed which
means the scaling target can be scaled down to the minimum allowed replicas.

/close


Berkayozenel

Created: CodeController and Updated: deleteReservation on ReservationController

Created: CodeController and Updated: deleteReservation on ReservationController


xcode 8 ios 10

Gives  that warnings !
ViewController.swift:32:22: Result of call to 'showAlert' is unused
ViewController.swift:38:22: Result of call to 'showAlert(_:subTitle:style:)' is unused
like this about 12 warnings

@codeservis  it does not affect anything, its basically just extra code that is not used. You can delete it if you want to.

if i delete them gives red warning

Easy fix:
 _ = self.showAlert(title, subTitle: subTitle, style: style, buttonTitle: "OK")

Easy fix:
_ = self.showAlert(title, subTitle: subTitle, style: style, buttonTitle: "OK")

thanks to fix this warning


Added instructions for a chocolatey installation.

Good change, but holding off until the package fixed.

Is that the edit I current see out there from 5/13: https://chocolatey.org/packages/poshgit/<IP_ADDRESS>50209
If not, I can look at fixing the issue with the Chocolatey package.

Already started on fix, just need to finish: #184

:thumbsup:

The README.md has changed a lot but I have added choco install instructions.  I'm closing this PR but please check the choco install instructions in the updated README.md.  Thanks!


Return value of indexof needs clearification

http://docs.oasis-open.org/odata/odata/v4.0/errata02/os/complete/part2-url-conventions/odata-v4.0-errata02-os-part2-url-conventions-complete.html#_Toc406398121

<IP_ADDRESS>.5 indexof
The indexof function has the following signature:
Edm.Int32 indexof(Edm.String,Edm.String)
The indexof function returns the zero-based character position of the first occurrence of the second parameter value in the first parameter value. The indexOfMethodCallExpr syntax rule defines how the indexof function is invoked.
Example 59: all customers with a CompanyName containing 'lfreds' starting at the second character
http://host/service/Customers?$filter=indexof(CompanyName,'lfreds') eq 1

No mention of what value should be returned when there's no match. -1 or null are both valid assumptions.
It needs to specified to avoid incorrect implementations :)
One could argue that the return type is Edm.Int32 and therefore it should be -1. But I'm not sure if the Edm types are nullable.
In any case https://github.com/OData/WebApi uses null.

@esditm This is a very good suggestion. The protocol does lack such specification. We'd recommend you report this to https://issues.oasis-open.org/browse/ODATA/ so that the TC can keep track of it and add it to the next errata.

I can't create a user on the OASIS site. So I can't create an issue for this.
Anyone with an account that want to do it?

This is already covered by https://issues.oasis-open.org/browse/ODATA-780
We opted for -1

Fantastic! :+1:

You can provide feedback on the OData specification via the odata-comment mailing list, see instructions on https://www.oasis-open.org/committees/comments/index.php?wg_abbrev=odata


[Bug fix]: Panic middleware should placed after logging middleware

Codecov Report

Merging #55 (019eeb7) into master (7de17f0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   95.72%   95.72%
=======================================
  Files          18       18
  Lines         818      818
=======================================
  Hits          783      783
  Misses         25       25
  Partials       10       10

Impacted Files
Coverage Δ

boot/gin_entry.go
96.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de17f0...019eeb7. Read the comment docs.


remove redundant entries in kernels:BUILD for no_mkldnn_contraction_k…

…ernel
Addresses #24414
Since tensorflow_mkldnn_contraction_kernel is set to 0 on line 104, we end up with multiple successful matches in these select structures. The architecture specific entries are currently not needed. If there is a chance that tensorflow_mkldnn_contraction_kernel will be set to 1 in the build config setting default, then we'll need a more robust solution.
This fixes a current build break on ppc64le community builds.

I was hoping bazel-skylark selects:with_or would help here, but that still doesn't solve the problem of two of the keys resolving as true in the select statement.
Perhaps a separate rule altogether for the arch check?

Bazel 0.19.2
Since it's hard to tell what will work for you internally, this PR was mostly for raising attention for this issue (https://github.com/tensorflow/tensorflow/issues/24414) and/or getting a quick fix in to get non-intel builds going again. It just partially reverts this commit (https://github.com/tensorflow/tensorflow/commit/10ef7edc881ee715eaae48656fcb431fe128441f) which includes an insufficient bazel select statement where more than one entry will wind up as true for non-intel platforms. I'm trying a few other things (like the aforementioned selects:with_or from bazel-skylark), but don't have a proper fix yet.
Any suggestions you have would be great!

@penpornk Thanks! I was reworking this PR, but if you have a fix I can wait for that if it's only a few days away. I'll keep this PR open until then.
@ezhulenev Yeah. But you wouldn't accept a PR from me to make that change, would you? (I'd be happy to push one :). My goal is to fix the nightly builds on non-intel arch's.

@jayfurmanek Sorry for the delay, and Happy New Year!
We tried to fix this with https://github.com/tensorflow/tensorflow/commit/20796e6bebb3a411655157f7ee7201af58a7d2fe on Dec 21 but it got rolled back. Just tried again with https://github.com/tensorflow/tensorflow/commit/7c9323bedc48c98be3c07b72ec1d6f4dccdefb35 yesterday and it seems it will stay. Please let us know if this solves your problem!

This looks like it should work. Thanks.


yarn --registry is error command when create new project

Version
3.0.0-alpha.8
Reproduction link
https://github.com/vuejs/vue-cli
Steps to reproduce
command-line output：
Vue CLI v3.0.0-alpha.8
✨  Creating project in /Users/a39/Desktop/profile/new-vue.
🗃  Initializing git repository...
⚙  Installing CLI plugins. This might take a while...

  error: unknown option `--registry'

 ERROR  command failed: yarn --registry=https://registry.npm.taobao.org

What is expected?
when i use yarn and select taobao source
use:
yarn config set registry https://registry.npm.taobao.org

What is actually happening?
when i use yarn and select taobao source
yarn --registry=https://registry.npm.taobao.org

btw: how can i clear the cache of the  taobao source selection?

@ws456999 in ~/.vuerc, set useTaobaoRegistry to false


Bump to version 0.2.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.894%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
699

Relevant Lines:
886

💛  - Coveralls


File "", line 3, in

[~/projects/test/docker/myapp]$ docker-compose build
bundles uses an image, skipping
db uses an image, skipping
Building web...
Traceback (most recent call last):
  File "<string>", line 3, in <module>
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.cli.main", line 31, in main
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.cli.docopt_command", line 21, in sys_dispatch
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.cli.command", line 27, in dispatch
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.cli.docopt_command", line 24, in dispatch
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.cli.command", line 59, in perform_command
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.cli.main", line 119, in build
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.project", line 166, in build
  File "/code/build/docker-compose/out00-PYZ.pyz/compose.service", line 479, in build
  File "/code/build/docker-compose/out00-PYZ.pyz/docker.client", line 436, in build
  File "/code/build/docker-compose/out00-PYZ.pyz/docker.utils.utils", line 80, in tar
  File "/code/build/docker-compose/out00-PYZ.pyz/tarfile", line 1990, in add
IOError: [Errno 13] Permission denied: './vendor/bundle/ruby/2.2.0/gems/nokogiri-<IP_ADDRESS>/ports/archives/libxml2-2.9.2.tar.gz'

Ubuntu 14.04 x64
Dockerfile & docker-compose.yml
P.S. but fig works well

Not sure if it's related, but I noticed you're defining volumes twice in your docker-compose.yml. first time at line 15 and again at line 21.
May be worth checking permissions on the directory and files in the project directory. You're mounting the project directory as a volume in the /myapp directory inside the container. Docker will use the file permissions and ownership of the hosts filesystem when doing that.
Are you using Boot2Docker? And if you do, is the project-directory a VirtualBox shared volume?

@thaJeztah thanks for helping,
I've removed the second volume block. But the issue still happens.
I don't using boot2docker becase there's no description about Linux installation, thus I thought it's not required for linux. Fig worked without it. Or is there a diference between docker-compose and fig ?

[SOLVED]
Short answer: run rm vendor/bundle -rf (under the project directory)
Long answer: seems that happens from previous installation of fig, so just remove old local directory located in /home/your_username/your_myapp/vendor/bundle and the rerun docker-compose build.
Let's going further!
P.S. @thaJeztah you was right with permission issue, thanks one more :+1:

@itsNikolay thanks for reporting back and glad to hear you were able to solve your issue. :+1:


Fixed #31811 -- Add optional timing outputs to the test runner

@carltongibson While this does the job, I'm not sure if this is efficient.
Any thoughts about the TimeKeeper class?

Oh, can I ask you to fix the isort error? (Otherwise I get a twitch...) Ta!

Fixed the isort error (sorry for the twitch)

Could maybe be done in a follow-up.

Can I vote for this? (I'd like to get this in so we can start using it for the parallelisation PRs) (Unless it's going to be quick, in which case ... 😀)

@carltongibson Let me know if there's anything I need to change. This should be good-to-go for merging.
@orf I combined your commit with time_keeper to retain a record of all tests run. Is there anything 'unnatural' about the code as of now?
I'm overriding a private method in unittest.TextTestRunner to inject time_keeper in. Is this risky in the long-term? If so, I'll try to rewrite it

No, this looks good to me @lothemar! Great work.
I will just note that this won't work in Jenkins because it uses the XMLRunner module. Unittest is a bit of a mess and is not very composable.
Lets merge this 🥳

@felixxm Thank you for your comments!
Sorry for the confusing wording of the docs. I'll add a patch for database teardown, I hadn't considered it in the timings.
Currently if you pass --durations=0, it'll show you only the timing outputs such as database creation, database cloning, and total run time, so you can only see these if you don't want to know your N-slowest tests. Passing any value greater than 0 will show you the timing outputs and N-slowest tests. Similarly, neither the test times aren't collected nor the TextTest* subclasses are used unless durations > 0.

Currently if you pass --durations=0, it'll show you only the timing outputs such as database creation, database cloning, and total run time, so you can only see these if you don't want to know your N-slowest tests. Passing any value greater than 0 will show you the timing outputs and N-slowest tests. Similarly, neither the test times aren't collected nor the TextTest* subclasses are used unless durations > 0.

Yes I know, IMO this is confusing, unexpected and out of scope of this ticket (grumbling ... :older_man:), maybe it's clear for others ... :shrug: , if I want to get timing outputs I have to declare the number of slowest tests to display :thinking: . I would prefer to use a boolean flag and chop durations. This change would be much simpler without mixing with showing the slowest tests.

Currently if you pass --durations=0, it'll show you only the timing outputs such as database creation, database cloning, and total run time, so you can only see these if you don't want to know your N-slowest tests. Passing any value greater than 0 will show you the timing outputs and N-slowest tests. Similarly, neither the test times aren't collected nor the TextTest* subclasses are used unless durations > 0.

Yes I know, IMO this is confusing, unexpected and out of scope of this ticket (grumbling ... 👴), maybe it's clear for others ... 🤷 , if I want to get timing outputs I have to declare the number of slowest tests to display 🤔 . I would prefer to use a boolean flag and chop durations. This change would be much simpler without mixing with showing the slowest tests.

We could change it so you only need to use --durations to display the timing outputs. I understand why it's confusing, and I agree it can be.
If you think changing it to --durations is still confusing, I don't mind chopping --durations and reverting back to ``--timing```.  👍

Here is how Pytest approaches this problem. Not saying we should copy - but someone else has given this thought (hopefully) and is the solution they landed on. This comment applies to other comments I'll make on comparisons to Pytest.
pytest --durations=0 — Show all times for tests and setup and teardown
pytest --durations=1 — Just show me the slowest
pytest --durations=10 — Slowest 10, with times, … etc.
https://medium.com/@brianokken/pytest-durations-0-show-all-times-for-tests-and-setup-and-teardown-848dccac85db

One more comment here, on the slowest N proposal... — I'm minded to accept that: lots of people use django-admin test and showing your slowest tests is a nice option.

I'm a bit meh about copying durations. For me, timing is nice. If you change tool, you change tool. (But we can bikeshed for cycle.)
I'd like to be able to do --timing and just get the current output (no slowest N) Could we re-use the same flag, defaulting to 0, or leverage the verbosity settings like @felixxm mentioned... (That last probably works: pass verbosity to TimeKeeper(verbosity)...

Either way, let's handle it separately: the basic feature is what we need here, and that'll help for testing the parallel runner PRs. 👍

I've added in the Creating and Cloning steps. I had to switch to a dictionary to handle the duplicate entries and maintain order of entry. I've also added the relevant docs and tests.

@lothemar Looks like https://github.com/django/django/pull/13224/commits/c474b4a82205a1467d6bf7dddb1a3cfd0ec41720 is necessary. I was thinking not. Didn't think through yet if that's the cleanest, so can you think about it. Ta!

Also, on the extra test case: I guess we'd need to mock out the test runner -- some horrible regress otherwise 😳

Sorry for the relative silence on this ticket. I had an issue with my ISP (it has been resolved now). I'm pushing a patch tonight on this ticket.
Concerning adding a test for the option's output, I think it's reasonable and should be there to detect regressions. I'll add it and push it.
The defaultdict optimization is beautiful! It'll be easy to integrate into the current patch.

How would you want to handle that?

Maybe we can change keywords arguments to keyword-only arguments and document this :thinking: Also we need to update django.test.utils.setup_databases() docs in topics/testing/advanced.txt.

👍👍🐙


Update scalafmt-core to 3.4.1

Updates org.scalameta:scalafmt-core from 3.4.0 to 3.4.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #279 (5f2b0bd) into master (c1e1dc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files           4        4
  Lines         105      105
  Branches        4        6    +2
=======================================
  Hits          101      101
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e1dc1...5f2b0bd. Read the comment docs.

Superseded by #280.


Custom CF template

Hello,
Is it possible to embed custom CF template to the operator via CloudFormationTemplate? Use case would be any AWS resource like RDS, which is not supported yet.
Thanks,
Abulfat

We would like to have this too. Is there any update on this?


resource_retriever: 2.5.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository resource_retriever to 2.5.0-1:

upstream repository: https://github.com/ros/resource_retriever.git
release repository: https://github.com/ros2-gbp/resource_retriever-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.3
previous version for package: 2.4.2-1

libcurl_vendor
* Update libcurl_vendor to the latest version (7.75.0). (#60 <https://github.com/ros/resource_retriever/issues/60>)
* Contributors: Chris Lalancette

resource_retriever

No changes

Please hold for coordinated merge.


daemon: Fix endpoint restore log regarding health endpoint

On each restart, the health endpoint of the previous run cannot be restored.
This is fine as it is supposed to be recreated but it triggers an unnecessary
info message about restore not succeeding.
The cleaning of the state was already taking place as part of
health endpoint being added to state.toClean.
We simply need to get rid of the unnecessary log printed.
Fixes: #4325
Signed-off-by: Manali Bhutiyani<EMAIL_ADDRESS>Fix endpoint restore log regarding health endpoint

This change is

test-me-please

test-me-please

test-me-please

@aanm This log was added 4 months ago as part of commit eea076da4e01e3ac4f2f561872e0b14792e850d8
https://github.com/cilium/cilium/commit/eea076da4e01e3ac4f2f561872e0b14792e850d8
Should I simply add
Fixes: eea076da4e01e3ac4f2f561872e0b14792e850d8 in the commit
? Or something else.

test-me-please

test-me-please

test-me-please


Composer User experience - Bot publishing

HI,
I am using the composer built from source on a windows 10 computer.
i see the composer UI different across documentation examples, screen snips posted by others here on the github issues.
for e.g.
In the case of publishing the bot app built by the composer. The documentation here explains how to use provisionComposer.js to provision the required resources on Azure. And goes on to explain how to add a publish profile (json) to push it to azure.
Both of which are not doable in my scenario since the only files i see under

C:\Users\UserName\Documents\Composer\BotName\scripts

are

create.ps1
deploy.ps1

And no provision to add publish profile, all it shows is recommendation to run couple of PowerShell commands. (does not cover the pre reqs like az cli must be installed)
does not allow me to deploy the bot to an existing resource group or bot application. (name requirements on the RG and bot name)

Even if i were to use the create.ps1 to create new resources it goes onto deploy the whole suite including resources that were not used in the project like the below

LUIS (not used in the project),
cosmos(not used in the project)

@SattaRavi Thanks for your feedback. Can you please tell us what Composer version are you using?
Our docs are currently aligned with Electron version 1.0.1 and might be slightly behind the most recent master branch.

Hi @zxyanliu
i am building from source code, using the steps listed here.
And i believe when i yarn startall it always checks for version updates and makes sure it on the latest version.

Also while trying to make updates and pushing the chnages to the bot does not work too.

script shows publish success, but cannot see any recent deployments made on the RG or the resource.

Ok @zxyanliu
i guess i understand the issue now, most of the documentation is based off of the Composer client app installed (electron app) which does not apply to the build from source code composer.
Can we please publish a feature support matrix between build from source vs the composer client app(electron).
And also calling it out the documentation, like "Applies only to Composer Electron App or Applies only to built from source"

Hi @SattaRavi
The Composer desktop application and web application are the same--there is no matrix of support in terms of features or functionality.
Looking at your screenshots - your version of the application seemed well out of date. We've deprecated the screens you showed entirely.
I hope this helps. I'll close this issue for now. Thank you for trying Composer.


I want to create a new docker image of project

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
So initially my main problem was to bring to kuma status UI to my dashboard by using iframs.
To do that I commented this
on line 98: // const disableFrameSameOrigin = !!process.env.UPTIME_KUMA_DISABLE_FRAME_SAMEORIGIN || args["disable-frame-sameorigin"] || false;
====================AND=====================
on line 129:
// app.use(function (req, res, next) {
//     if (!disableFrameSameOrigin) {
//         res.setHeader("X-Frame-Options", "SAMEORIGIN");
//     }
//     res.removeHeader("X-Powered-By");
//     next();
// });
after this the iframe was working, but now to deploy the project I have to create docker image but it was not working
So I want to create a docker image with this changes please help me.
🐻 Uptime-Kuma Version
1.14.1
💻 Operating System and Arch
Ubuntu 20
🌐 Browser
Chrome
🐋 Docker Version
20.10.14
🟩 NodeJS Version
14.18.3

You should just be able to run the standard docker image with the UPTIME_KUMA_DISABLE_FRAME_SAMEORIGIN=true.
Example:
docker run -d \
    --restart=always \
    -p 3001:3001 \
    -v uptime-kuma:/app/data \
    --name uptime-kuma \
    -e "UPTIME_KUMA_DISABLE_FRAME_SAMEORIGIN=true" \
    louislam/uptime-kuma:1

Thanks for helping


CHANGELOG for 1.13.0

Signed-off-by: David Thompson<EMAIL_ADDRESS>

I didn't include #587, since the change to add the uri/uriabs support is listed on the changelog, and I think it would be a bit redundant to include both the issue for the feature and the issue for the documentation.


Reformat LICENSE file

Coverage remained the same at 100.0% when pulling ac8b01bbee1acc87bf18bfd907cbef21a4ec2f51 on license-reformat into d25ed2ddb49d1388c2873dc665e7d4a425e19f60 on master.


WIP: p-version

Some progress

[x] ElementLinePp
[x] ElementQuadPp
[ ] ElementTriPp
[ ] ElementHexPp

Currently the test solves -u''(x) = 1, u(0) = u(1) = 0 to machine epsilon precision.

I'll most likely leave ElementHexP for later work. I'm now solving some issues with the DOF locations of ElementQuadP, after that I briefly work on ElementTriPp and start merging this.

I'll still add a test for the example. This is how it looks:


Wait for successful pairing

I am running the latest version
I checked the documentation and found no answer

Hi Guys, I posted this on github as well f y i, hope someone can give me some insight!
I'm new to bluetooth and to react native as well and I've encountered a problem that I've spent days on but I haven't gotten anywhere.
I'm developing an app using the react-native-ble-plx library, but I encountered the same issue using react-native-ble-manager. I've been given a requirement that we need to have security level 3 with numeric comparison and in one of the first screens in the app the user should scan a QR code on the printer which gives the bluetooth library scanner the name it should look for so the user shouldn't have to see any other devices.
This works fine but the problem is when the pairing starts, the app should wait until pairing has been completed before going to the next screen but I haven't seen any way to do this. So what happens is that as soon as the device is connected and services are retrieved, the next then-function gets triggered even if the user aborted the pairing because technically I guess the connection is still active because its waiting for the pairing to complete. I've marked out what I mean in a code example.
So summarize, is there a way to wait for a successful pairing before allowing the user to the next stage? They'll be potentially changing to many different devices all on the same day so I can't really count on them just having to successfully pair just once and it'll be fine. Thanks!
bleManager.startDeviceScan(
        null,
        {scanMode: ScanMode.LowLatency},
        (err, device) => {
          if (err) {
            setLoading(false);
            return;
          }

          if (device && device.name === printer.printerName) {
            bleManager.stopDeviceScan();
            device
              .connect({timeout: 10000})
              .then((d) => {
                return d.discoverAllServicesAndCharacteristics();
              })
              .then((d) => {
                //THIS SHOULD ONLY HAPPEN IF PAIRING WAS COMPLETED
                dispatch({
                  type: 'SET_PRINTER',
                  payload: {
                    printerId: d.id,
                    printerName: printer.printerName,
                    isBluetooth: printer.isBluetooth,
                    printerNetworkId: printer.id,
                  },
                });

                setLoading(false);

                navigation.canGoBack()
                  ? navigation.goBack()
                  : navigation.navigate(patientRoute);
              })
              .catch((error) => {
                console.log(error);
                setLoading(false);
              });

I'm having the same issue that it doesn't wait for the peripheral to actually pair before running other logic:
const device = await this.device.connect();
this.device = await device.discoverAllServicesAndCharacteristics();

// other logic

It'll just try to execute all the logic before the device is even paired.

Also seeing the same issue.
Here is the function that should scan, stop scan when target device is found, connect, and then discover services and characteristic after the device.connect() promise resolves successfully. But, error is encountered when trying to perform connected operations.
const connectDevice = ({ address, name }) => {
          setDevicesLoading(true);
          let numScanned = 0;
          manager.startDeviceScan(
              null,
              { allowDuplicates: false },
              (error, scannedDevice) => {
                  if (error) {
                      setDevicesLoading(false);
                      console.error(error);
                      return;
                  }
                  if (scannedDevice != null) {
                      numScanned = numScanned + 1;
                      if (numScanned >= 1500) {
                          manager.stopDeviceScan();
                          setDevicesLoading(false);
                          return;
                      }
                      console.log(numScanned);
                      if (
                          scannedDevice.id == address ||
                          scannedDevice.name == name
                      ) {
                          console.log("target device found");
                          scannedDevice
                              .connect()
                              .then(device => {
                                  console.log("Device connect promise returned.");
                                  device
                                      .discoverAllServicesAndCharacteristics()
                                      .then(device => console.log(device))
                                      .catch(err => console.error(err));
                              })
                              .catch(err => console.error(err));
                          manager.stopDeviceScan();
                          setDevicesLoading(false);
                      }
                  }
              }
          );
      };

Here are the logs:
[Tue Apr 13 2021 07:23:15.812]  LOG      1
[Tue Apr 13 2021 07:23:15.813]  LOG      target device found
[Tue Apr 13 2021 07:23:16.225]  LOG      Device connect promise returned.
[Tue Apr 13 2021 07:23:16.239]  ERROR    [BleError: Device 64:33:DB:BE:3A:80 is not connected]

The issue I had was for android and I fixed it by moving to react-native-ble-manager for android. I ended up bonding the peripheral before connecting and it solved my issues.

I had the same problem of needing to wait until manager.startDeviceScan() was done with scanning and connection.
The solution is to wrap the manager.startDeviceScan() function in a promise and resolve that promise within device.connect().
Here's an adaption of the official intro code:
export const scanAndConnect = new Promise((resolve, reject) => {
  manager.startDeviceScan(null, null, (error, device) => {
    if (error) {
      // Handle error (scanning will be stopped automatically)
      resolve(false);
    }

    if (device.name === 'TI BLE Sensor Tag' || device.name === 'SensorTag') {
      // Stop scanning as it's not necessary if you are scanning for one device.
      manager.stopDeviceScan();

      // Proceed with connection.
      device
        .connect()
        .then((device) => {
          return device.discoverAllServicesAndCharacteristics();
        })
        .then((device) => {
          // Do work on device with services and characteristics
          console.log(
            `[INFO] BLE device connected! name: ${device.name}, id: ${device.id}`
          );
          resolve(true);
        })
        .catch((error) => {
          // Handle errors
          resolve(false);
        });
    }
  });
});

This returns true once the connection is finished. Of course you can return other things with resolve() too.
You can then call this promise in some other part of your application:
scanAndConnect.then((res) => {
  // logic that should be executed after successful connection
  res
    ? console.log("[INFO] connection successful")
    : console.warn("[WARN] connection failed");
});

Some more info on using Promises for those that might be unfamilier with them.

I'm excited to inform you that we've released a new version of react-native-ble-plx. Many of the concerns and bugs have been addressed in this update.
If you encounter any issues or have further suggestions, please don't hesitate to open a new issue.


ARROW-11412: [Python] Improve Expression docs

Slightly improve documentation on how to create and combine expressions
for filtering datasets. Including one example.

I tried to fix the issues you mentioned and also updated dataset.rst to clarify the use of &, | ~ vs and or not

I tried to fix the issues you mentioned and also updated dataset.rst to clarify the use of &, | ~ vs and or not


Incorrect line for type when looking up the typeIndex, when type is a substring

Problem: incorrect type index return for asset when asset-category is given precedence in declaration.
Example:

Fix: update each method to do a full string match, not a prefix match.
https://github.com/openfga/language/blob/7d0da9bc9c63f3885c512795279f0f0a025452b1/pkg/js/util/line-numbers.ts#L23
https://github.com/openfga/language/blob/7d0da9bc9c63f3885c512795279f0f0a025452b1/pkg/go/utils/line-numbers.go#L16
https://github.com/openfga/language/blob/7d0da9bc9c63f3885c512795279f0f0a025452b1/pkg/java/src/main/java/dev/openfga/language/validation/Dsl.java#L50

This would also be present if the same logic is used for relations and conditions, where a prefix match is done.


Fix issue with kube-compare sriov operator template

Issue caused the manifest out put to be invalid if there was multiple selectors
/cc @jnunyez

Only happening when the input metadata.yaml is specified remote github URL. Recommend to use only for now local metadata.yaml files.
/hold

I get the same error whether I use a local or remote reference to metadata.yaml

/unhold

/lgtm


[PDI-18290] - Can't execute a transformation with an ampersand in the…

… name on slave server
@pentaho-lmartins
@pentaho/tatooine

:gear: Build finished in 24m 39s with command:
mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -pl engine

:ok_hand: All tests passed!

Total
Failed
Skipped

3579
0
7

Details

:information_source:  This is an automatic message


Option to turn animations off when workflow is running

So CPU/GPU usage doesn't fight with the backend.

This is working correctly, for me.


🌐 Add Spanish translation for advanced/path-operation-advanced-configuration.md

Awesome, thanks @jfunez! :coffee: :cake:
And thanks @mariacamilagl for the reviews and corrections! :nerd_face: :coffee:


refactored code to separate step of paymaster response

Just tried using this, the paymaster is returning: AA23 reverted (or OOG)

The biggest question is, will old session key work with this or not? This will determine if it's a minor upgrade or a patch. And we would need to inform Synquote

Hmmm no it won't it's because we changed address


publish release

Signed-off-by: daquexian<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (tengine-lite@645df5c). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 8c03e1c differs from pull request most recent head cb95fff. Consider uploading reports for the commit cb95fff to get more accurate results

@@               Coverage Diff               @@
##             tengine-lite       #1   +/-   ##
===============================================
  Coverage                ?   47.52%
===============================================
  Files                   ?        9
  Lines                   ?     2506
  Branches                ?        0
===============================================
  Hits                    ?     1191
  Misses                  ?     1315
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645df5c...cb95fff. Read the comment docs.


Documentation deployment doesn't work anymore

#485
Note: I have included fixes for each of the warnings logged during the docs' build process. According to the warning messages, type annotations wouldn't show up for the specified vars unless the warnings were fixed.
This being my first PR I worked primarily via the advice given in the description of the original bug i.e. narrow down which commit broke the docs. I tried reverting each commit one at a time (after checking out v0.64.2) however the RecursionError would still occur. After taking a closer look at the stack trace, and also messing with the markdown file and noticing that the presence of the identifier (ex: python_on_whales.docker_client.DockerClient) would cause the issue, I focused my efforts towards looking at issues with the mkdocstrings-python package. I couldn't find much about jinja2 breaking mkdocs (except for https://github.com/mkdocs/mkdocs/issues/2799), however I did find good amounts of discussion regarding Griffe causing issues (https://github.com/mkdocstrings/mkdocstrings/issues/382, and https://github.com/mkdocstrings/griffe/issues/79). According to the changelog, mkdocstrings-python enforced a version upper bound on griffe in version 1.3, hence why I chose to bump to this particular version. I tried out 1.2 as well however still ran into the same issue.

Thank you for this thorough investigation. I'll take a look at this PR this week

I just made a copy of your branch and ran the deployment job for the docs from this, and it worked like a charm. Thank you for the version fix and all the other small changes to the docstrings. This is really the kind of pull requests that I love, they just work :)  This PR makes me glad I'm doing open source. Many thanks :)


Clean up readme files and subdirectories of report_queries

Do the top level readme files need to be updated/pruned?  How will we maintain them?
Also consider moving report queries that have not yet been refactored to a deprecated/ subdirectory.

I see 2 reports that need to be pruned.
pick list redshift version
and
the HathiTrust
This HathiTrust report (if I remember correctly) isn't quite working. This was way before our derived tables. I'm working on a new iteration completely.

I see 2 reports that need to be pruned.
pick list redshift version
and
the HathiTrust
This HathiTrust report (if I remember correctly) isn't quite working. This was way before our derived tables. I'm working on a new iteration completely.

For RA/UM, I think we'll want to move out both recalls and requests

For RA/UM, I think we'll want to move out both recalls and requests


tests: POST /login returns same device_id

Signed-off-by: Meenal Trivedi<EMAIL_ADDRESS>

Hi @Kegsay @callahad , Please review the following tests. I have also created a new method to create dummy users to use them for login tests.

Hi @Kegsay , I have the changes you requested please review them

Fixed the deviceID @Kegsay , please review


Update to gclid traffic attribution is missing evaluation for the campaign name "(organic)"

The gclid attribution update in #306 is not considering the campaign value of (organic). "(organic)" is the value I'm seeing in my GA4 datasets

Medium and Source are cleanly updated, but without adding one more line to change (organic) to (cpc), the attribution for the newly recategorized data retains the campaign value of "(organic)" while the source and medium are updated to "cpc". I was able to resolve the issue by adding one line of code to stg_ga4__events.sql
Can someone confirm if they're seeing the same mis-attributed values for (organic) in their datasets with the merged-but-not-yet-published update?
@dgitis
Currently:
detect_gclid as (
    select
        * except (event_source, event_medium, event_campaign),
        case
            when (page_location like '%gclid%' and event_source is null) then "google"
            else event_source
        end as event_source,
        case
            when (page_location like '%gclid%' and event_medium is null) then "cpc"
            when (page_location like '%gclid%' and event_medium = 'organic') then "cpc"
            else event_medium
        end as event_medium,
        case
            when (page_location like '%gclid%' and event_campaign is null) then "(cpc)"
            when (page_location like '%gclid%' and event_campaign = 'organic') then "(cpc)"
            else event_campaign
        end as event_campaign
    from include_event_key
),

Proposed update includes one new line in the campaign-related case statement:
detect_gclid as (
    select
        * except (event_source, event_medium, event_campaign),
        case
            when (page_location like '%gclid%' and event_source is null) then "google"
            else event_source
        end as event_source,
        case
            when (page_location like '%gclid%' and event_medium is null) then "cpc"
            when (page_location like '%gclid%' and event_medium = 'organic') then "cpc"
            else event_medium
        end as event_medium,
        case
            when (page_location like '%gclid%' and event_campaign is null) then "(cpc)"
            when (page_location like '%gclid%' and event_campaign = 'organic') then "(cpc)"
            when (page_location like '%gclid%' and event_campaign = '(organic)') then "(cpc)"
            else event_campaign
        end as event_campaign
    from include_event_key
),

Thanks. I just merged your PR https://github.com/Velir/dbt-ga4/pull/315 which should resolve this. I haven't seen it myself, but your screenshot seems like sufficient proof and it's a harmless check to add.


Feat rc add status models

Setup statuses for both pickups and dropoffs.  Create seeds for adding to production db.  Did not yet have time to setup default values for these, but will do so in the next commit.

Don't mind if I do!


ROX-15434 - [MVP] enable on-prem registry scanning

Description
Enables scanning of all images via the secured cluster
A new environment variable,ROX_FORCE_LOCAL_IMAGE_SCANNING, was added that will cause all images to be treated as if they are accessible by only the secured cluster.
Most dockercfg/dockerconfig secrets will be captured in the existing registry store (in addition to the OCP internal registry secrets)
The enrichment and admission control scanning workflows will leverage the stored secrets to attempt image analysis via the local scanner.  If no stored secrets are found, the workflows assume the registry requires no auth and attempt analysis.
(tech debt) Sensor will now send EnrichLocalImageInternal requests to central when local scanning failures occur so that central can store and show the failures.
Scanning workflows via roxctl, image watches, Jenkins plugins, etc. (non-sensor) were not modified as part of this MVP and will continue to be processed via Central Services.
Checklist

[X] Investigated and inspected CI test results
[X] Unit test and regression tests added
[X] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Unit tests added where applicable
Testing setup involved creating two clusters:

ClusterA = GKE Central Services (installed via Helm)
ClusterB = OCP Secured Cluster Services (installed via Helm w/ env ROX_FORCE_LOCAL_IMAGE_SCANNING = true)

Scanner logs on both clusters were followed while new pods were created on the ClusterB. Confirmed via following logs that only scanner-slim was moving / scanning images
A instance of JFrog Container Registry (JCR) was installed on ClusterB, images were deployed from this registry using the Artifactory service cluster internal IP to ensure ClusterA would not have access. Observed success in scanning with the environment variable set to true, and failure when environment variable set to false.
Testing Observations
While feature was turned on observed the following behaviors that need more attention / troubleshooting

[x] image from new pods/deploys are scanned multiple times and appears twice in central after a single deployment (shows as one active and one in-active)

Fixed, caused by using other ids (specifically manifest ID) in place of image ID when image ID not avail. Forced use of image ID in scan requests

[X] failed deployments (ie: due to ImagePullBackOff) trigger a sensor deployment event and a scan - possibly BAU

Testing with current versions of ACS - this is normal behavior

[X] are many upserts into the registry_store, these may be excessive

Normal behavior - somewhat reduced by new suppression of storing secrets with service account annotation

[x] OCP images ocp-v4.0-art-dev fail to be scanned by default

OCP images required usage of a special 'global pull' secret to access

[X] scan failures are not reported to central

Fixed, modified sensor to always send Enrich request even during failures, modified central to save to DB if not already when errors occur.

/retest

/retest

/retest

/retest


smallstep: 0.13.3 -> 0.14.6

Uses the same workaround as yubikey-agent. Namely build with
https://github.com/go-piv/piv-go/pull/75 to make piv-go build properly

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build step-cli step-ca

Out of interest, why isn’t the piv-go patch needed for step-cli? piv-go is mentioned in the step-cli go.sum but for all I know this could be stale and not actually used.

Good question. I don't know. Let's have a look before merging. It compiled fine without the dependency

Probably best to regenerate the go.sum file and ask the smallstep maintainers about it.

Yeah if go mod tidy removes it from go.sum then we don’t need to worry about it

@arianvp scrolling through their website, it seems they also provide pam and nss modules for user management.
Is this up somewhere too?

Result of nixpkgs-review pr 93711 run on x86_64-darwin 1

2 packages failed to build:

step-ca
step-cli

Please fix the tests with sandbox enabled.
    remote_test.go:48: unknown host smallstep.com: lookup smallstep.com: no such host
--- FAIL: TestGetPeerCertificateServerName (0.00s)
FAIL
FAIL    github.com/smallstep/cli/command/certificate    0.026s
FAIL

Result of nixpkgs-review pr 93711 run on x86_64-linux 1

2 packages failed to build:

step-ca
step-cli

Is this still being worked on?

I'm also interested in this. https://github.com/go-piv/piv-go/pull/75 is included in go-piv/piv-go since v1.6.0, and https://github.com/smallstep/certificates/blob/master/go.mod points to v1.6.0, so this should just work without any patches and the latest release (0.15.6).
@arianvp, do you want to update this?

Feel free to continue on this PR @flokli. I'm currently not in the position
where I have time for it.
On Tue, 22 Dec 2020, 23:42 Florian Klink<EMAIL_ADDRESS>wrote:

I'm also interested in this. go-piv/piv-go#75
https://github.com/go-piv/piv-go/pull/75 is included in go-piv/piv-go
since v1.6.0, and
https://github.com/smallstep/certificates/blob/master/go.mod points to
v1.6.0, so this should just work without any patches and the latest release
(0.15.6).
@arianvp https://github.com/arianvp, do you want to update this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/93711#issuecomment-749815353, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEZNIYQ7B5Q45DKJVGB26LSWEOGXANCNFSM4PF5QYWQ
.

I pushed a new version addressing all the comments.

Simply applying on top of 0.15.3 also doesn't work, so I moved this to the commit introducing the fix.

Given what the error is, it may just need that one Darwin networking flag to be set.

It builds on darwin, the error shown is because nixpkgs-review uses sandboxed builds and the tests fail wanting networking with loopback (allowed on sanbox).
Sandboxing is not fully functional on darwin, so I think we can safely ignore it.


Exercise 2, step 26 - port number does not match security group settings

The security group for the node-security-group does not allow port 3001, but step 26 says to try browsing to http://ww.xx.yy.zz:3001 so does not work. The step should probably say to browse to http://ww.xx.yy.zz:8080

Fixed


Enable Ledger signer tests once #1473 is resolved

Feature Request
Enable Ledger signer tests once #1473 is resolved.

Closing this as it was mentioned in other issue.


Upgrade to opset 14

Hey @chentong319,
Sorry for going a little silent on the opset 14 upgrade. I now have backing from work to take this on.
I noticed that GRU and LSTM only add the layout attribute like RNN. I saw that you updated RNN to 14. So I felt comfortable taking the same approach here with GRU and LSTM. The tests needed a few modifications to match the new builders.
BatchNormalization didn't need any modifications as onnx-mlir only supports inference. The changes in opset 14 to the spec are only specific to training mode, which wasn't supported in the first place.
Like RNN a new attribute is added to Reshape. I updated the inference_backend with   # ==LIM== allowzero not supported. to reflect that we don't have support for the attribute.
I also added shape inference for the two new ops Trilu and HardSwish.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

@jenkins-droid test this please

Thanks for adding the support for the new version of ops. That part looks good to me. However, in order to handle the old models, we need to keep the old version op in IR and add a rewrite rule to convert it to the new version. You change the test case for reshape op for the new Reshape Op. Similarly, we need to handle the models with older op-set. One possible solution is to use converter to convert it  to the current op-set. But the converter may not work from our experience. Solution within onnx-mlir is to keep the op dialect for the old version and rewrite the older version op to the new version. In other words, we are doing the onnx converter work in onnx-mlir, which should be avoided in future. I will add the instructions in the docs/ImportONNXDefs.md on how to do it.

@chentong319,
previous Reshape's will be handled correctly.
The AllowZero attribute has a default value, that defaults to the old behavior of opset 13. This means that when a reshape from the previous opset comes in, it will be handled as it was before.
If you look at the changed test, its only the output that needed to be changed. The input to the test could have come from opset 13. This is what happened with addition of the layout attribute that was added to RNN in opset 14. No additional RNN for opset 13 needed to be defined. I think the ONNX committee updated ops with attributes with default values, whose default values mirror old behavior specifically to help with this issue.
If you disagree with my assessment here, I am happy to make the change you suggested.

FYI, docs/SupportedONNXOps-cpu.md is a generated file. Use make onnx_mlir_supported_ops to regenerate it.

Thanks @philass for taking this on, @chentong319 for looking into it satisfies our backward compatibility requirements. Much appreciated

Thanks @philass for taking this on, @chentong319 for looking into it satisfies our backward compatibility requirements. Much appreciated

Yes, it's fine when the added attribute is with default value.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@AlexandreEichenberger glad I could contribute
@chentong319 Thanks for the review
Could one of you guys run the CI? I fixed the merge conflict with SupportOps-cpu.md. Once it passes I think this should be ready to merge

@philass restarted the CI updated to the latest version.

@philass thanks for the update. Your help is much appreciated.
Just merged it now in the actual repo.

Jenkins Linux amd64 Build #6754 [push] Upgrade to opset 14 (#15... started at 15:51

Jenkins Linux ppc64le Build #5866 [push] Upgrade to opset 14 (#15... started at 16:53

Jenkins Linux amd64 Build #6754 [push] Upgrade to opset 14 (#15... failed after 20 min

Jenkins Linux s390x Build #6769 [push] Upgrade to opset 14 (#15... aborted after 1 hr 49 min

Jenkins Linux ppc64le Build #5866 [push] Upgrade to opset 14 (#15... aborted after 1 hr 49 min


Low-priority validation state management

This manages low-priority validation via the reducer.
With this change, validateField() can cancel validateFormWithLowPriority(), resulting in partially validated forms. That's how it already works, since it abandons validation when the values don't match the props. However, if values previously did match, this could cause an issue.
const breakValidation = () => {
  validateFormWithLowPriority(values);

  // this matches the above, so Formik would previously apply lowpri validation after this completes.
  // but now, validateField will unschedule the low priority validation.
  validateField(values.myValue);
}

theoretically, there may always be another low priority validation waiting for change, blur, or submit, but I need to think about it more. what we may need to do instead, is that if validateField is being called on the same values as were submitted to a currently schedule low-priority validation, validateField is cancelled instead.
here's the sandbox for the issue this solves: https://codesandbox.io/s/formik-codesandbox-template-forked-rozm4?file=/index.js

Looks legit

I guess my only wonder is if we should be even doing the scheduling in the first place. If we just got rid of async validation like in #1524 then I don't even think we need this?

I don't have an example proving it wrong, but I'm not committed to the idea of async validation. Using event callbacks for validation don't seem right to me, because how do you call all of them at once if you need to elsewhere? In my mind, the way we handle validation is not ideal, but in the opposite way. This is how I imagine validation in pseudocode:
const Formik = () => {
  // this is validation as I imagine it in React
  // using refs that are only updated by user interactions or side effects,
  // and NOT RENDERS. see #2828
  const validate = React.useCallback(async () => {
    if (state.values !== refs.lastValidatedValues.current) {
      dispatchLastValidatedValues(state.values);
      const validationResult = await runAllValidationsEtc();
      // check if "future values" are equal to the values we validated or bail
      if (state.values === refs.values.current) {
        setErrors(validationResult.errors);
      }
    }
  }, state.values);
  // imaginary throttle function that only occurs once every Xms,
  // but always calls the last call
  const lowPriorityValidationCallback = useThrottle(
    validate,
    [formik.validateOnChangeDebounce ?? 250]
  );
  useEffect(
    // return void, not Promise
    () => { lowPriorityValidationCallback() },
    [formik.values, validateOnChange, lowPriorityValidationCallback]
  );
}

Then again, I don't think I've ever used async validation, so it's possible I'm overthinking it. If I did need it, I wouldn't want it to be in the onChange hook.

I wasn't able to find any instances where I've used async validations. This PR still solves an issue I have with current Formik release and it should probs be fixed without any API changes. I'm still trying to figure out if the validateField() cancellation would be an issue.

I've been speking with Dan for the last hour or so, we are going to get rid of low priority validation in master since he doesn't believe it's working as expected. We instead going to have a CM mode branch that uses startTransition instead

After some good sleep I definitely rescind my useEffect version of low pri validation.
I think it works kind of as expected. It prevents the validation itself from holding up the next render. This problem may be resolved in concurrent mode, but I think expecting users to adopt concurrent mode to get validations working correctly and performantly is a big ask.
Here's how I see this issue:
Low Pri validation is scheduled on React's internal scheduler which, to my knowledge, occurs before the next render when possible, or after the next render if the callback takes too long, triggering a second render. For renders, Errors and Touched are expected to be in sync. When Touched is changed, the validations must not be stale or there will be a flash when the scheduler isn't able to update validations between renders, because touched will be true but the stale error will remain in errors. To me, there are a few solutions to this.

Trigger touched and validation via the same schedule. This is questionable to me because users may want to know whether the field was touched independent of validation state.

Expand validation API. Validations return a ValidationResult with a shape like { errors: string, isUserRelevant: true }. Or add that info anywhere else, like a sibling to touched. Whether a field is touched and whether a user expects feedback can be two different things, for example a user may only expect feedback after initial form submission attempt, which is a technique I use sometimes, and it prevents me from using touched properly.

const ErrorMessage = ({ name }) => {
  const field = useField(name);
  return field.validationResult.error && field.validationResult.isUserRelevant && <p>{validationResult.error}</p>
}

Now, validateFormWithLowPriority() can set
formik.validationState = fields.each(field =>
  ({ error: validateField(field.name), isUserRelevant: getIn(touched, field.name) });

Check whether validation is scheduled, using the changes in this PR:

const ErrorMessage = ({ name }) => {
  const formik = useFormikContext();
  const isTouched = getIn(formik.touched, name);
  const isValidationScheduled = getIn(formik.touched, name);
  const [isUserRelevant, setIsUserRelevant] = useState(isTouched);

  useEffect(() => {
    if (!isUserRelevant && isTouched && !isValidationScheduled) {
      setIsUserRelevant(true);
    }
  }, [isTouched, isValidationScheduled]);
}

Closing for now, but if we ever return to low priority state management my last comment has the solutions we need.

Agreed. Boomarking this PR for future

@jaredpalmer validationScheduledFor can still be used for normal isValidating to prevent race conditions: #2898
validateField would need to wait until a scheduled validation has resolved to apply over the previous errors.
name: john
age: 21                                  age: 22
    |                                         \ validateField:start      validateField:complete            | validateField:commit /
    \ validateForm:start                                                                  validateForm:end /

Anytime after validateField:start, a change to validationScheduledFor would stop field-level validation from committing.


Fix sorting bug of accessiblity and toilet status filters.

The Map component was sorting status and toilet status filters when comparing arrays for equality. This sorting was mutable and changing the order of given status filters for other components too. The StatusFilter component used the equality of status filters to see if a status filter was selected by user. The changed order broke this comparison.
This PR moves the sorting of accessibility and toilet status filters to the App component (getDerivedStateFromProps) so that all components always have the sorted list of statuses.
See: https://trello.com/c/DOl6ELoV

@opyh Maps now also sort incoming currently active status filters like discussed in Slack.

Added more DRYness and removed the cordova dependency.


Being serious about UTF-8 compatibility

Also copying incoming encoding to string yielded to the passed block.
This replaces #27, except for the autolink changes needed for supporting unicode text.

@grosser https://github.com/zendesk/rinku


Help with wordpress integration

`I know that there is a plugin but it does not have a feature that is important to me...html block on pause.
I think I did everything correctly. The css and js are in the header and I made  a page and put the  tag and javascript in the body, but when I visit the page, the video is playing in the default chrome player and not fluid player.
link to the page: http://sprintkings.com/fluid-player-test/
However, everything works fine when I when I use raw html
link to working version: http://sprintkings.com/fluidtest.html
They are basically the same thing, but I can't get it to work in my blog. Could someone tell me what I am doing wrong?

Hi @jinyus, from checking your fluid-player-test page we can see in the console that there is an error -
*Uncaught SyntaxError: Unexpected token <*
This is occurring due to a
 tag within the javascript. The below code is the snippet where the error can be found.
 var testVideo = fluidPlayer(
'my-video',
        '',
        {
            htmlOnPauseBlock: '',
        }
);

Please remove this tag and see if the issue is resolved.


[IOTDB-4152]Fix tablet split by time partition error

Coverage decreased (-0.003%) to 42.125% when pulling d785a92824bf8cfb35db36ac89d45d1cc4d57704 on fix_tablet_timepartition into 04d6ecd91ef4de8c7205229fc8fd00f4abade0d5 on master.


Simplify checking for bottom

https://github.com/goblint/analyzer/pull/260/files#r662098220 Many
functions have the same matching pattern that checks if one or both of
the operands are bottom. This should be put in a separate function.

What is the purpose of the is_bot function? Could it be used?

or maybe something like this?
let arith2 f ik x y = match x, y with
    | None, None -> bot_of ik
    | None, _ | _, None -> raise (ArithmeticOnIntegerBot (Printf.sprintf "%s op %s" (show x) (show y)))
    | Some (c1, m1), Some (c2, m2) -> f ik x y


Unhandled inline CSS error's is causing node to crash on version 16+

🐞 Bug report
While running docker build command, on RUN yarn run scully the build is encountering some inline CSS errors. As these errors are not handled the node (16) is terminating the entire process, unlike the older version where it just continues the build process.
Also, if we run in local environment, when the routes are being created, the terminal is throwing following message:  could not inline CSS TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string.

Scully Version:
        "@scullyio/init": "^2.1.36",
        "@scullyio/ng-lib": "^2.1.36",
        "@scullyio/scully": "^2.1.36",
        "@scullyio/scully-plugin-puppeteer": "^2.1.36",

🔥 Exception or Error
Below is the error message on encountering the unhandled promise rejections.
DeprecationWarning: Unhandled promise rejections
are deprecated. In the future, promise rejections that are not handled
will terminate the Node.js process with a non-zero exit code.

@homesh-clearcals any luck with the issue? I'm also facing the same issue.


Softrasterizer for Mask from 2D points

Hi,
I want to use your SoftRas in a segmentation project. I have a CNN that claculates a polygon, which describes the boundaries of my segmented object. Now I want to extract the object from the input image. So I want to create a mask with ONES in the inner of the polygon and ZEROS in the outside. Multiplying this mask with my input image pointwise yields the segmented object. Since I want to use this segmented object to calculate the loss, the mask has to be differentiable in regard to the polygon, that the CNN calculates. Therefore I want to use your rasterizer algorithm. Is it possible to use one of your functions for 2D polygons to 2D images, or should I implement my own SoftRas for this problem?

Hi,
Good questions. Yes, you could try to simply set their Z-axis value to 1 (or any number between (near, far)) and pretend it is a 3D mesh.

Hi,
thanks for your reply, but I already started writing somethink on my own. I actually just want to create a mask for a polygon, that is defined by a center point (green pixel in image) and distances to the edges in equally distributed directions (red pixels in image) - this is adapted from the StarDist paper(https://github.com/mpicbg-csbd/stardist). So I have always the same amount of triangles. This is the code I use to create a silhouette

def create_silhouette(
        size, batch_size, edge_points, offset_points, pixel_points, n_rays,
        sigma=.02,
        ):
    """
    Create a differentiable silhouette as mentioned in the SoftRas paper.
    https://github.com/ShichenLiu/SoftRas
    """
    start_points = offset_points
    x = torch.linspace(0, 1, size)
    y = torch.linspace(0, 1, size)
    mx, my = torch.meshgrid(x, y)
    # in the 3rd channel we save, if the pixel belongs to the triangle
    Ps = torch.stack((mx, my))
    # extend grid
    # first we need a grid for each ray
    Ps = Ps.expand(n_rays, 2, size, size)
    # second we need it for each patch in the batch
    Ps = Ps.expand(batch_size, n_rays, 2, size, size)

    # this vector saves the distances and the property of belonging to a
    # triangle for each pixel for each ray for each patch in the batch
    # we have 4 channels: one for the belonging: -1 / +1
    # three for the smallest distances to each line segment
    # in the end we can take the min over the channel axis
    belonging = torch.empty(batch_size, n_rays, 1, size, size)
    distances = torch.empty(batch_size, n_rays, 3, size, size)

    # collapse batch_size and the two size axes
    # put the two sizes in front, because of expand statements in for loop
    Ps = Ps.permute(3, 4, 0, 1, 2)
    belonging = belonging.permute(3, 4, 0, 1, 2)
    distances = distances.permute(3, 4, 0, 1, 2)
    Ps = Ps.flatten(0, 2)
    belonging = belonging.flatten(0, 2)
    distances = distances.flatten(0, 2)
    # do the same with the points C
    C = start_points.expand(size, batch_size, 2)
    C = C.expand(size, size, batch_size, 2)
    C = C.flatten(0, 2)

    # I think we now have to use a for loop to iterate over the different
    # triangles in each patch
    for i in range(n_rays):
        # C is always in the center
        # since the rays are distributed counterclockwise, we always get a
        # triangle, where ABC are in clockwise order
        B = edge_points[:,i,:]
        A = edge_points[:,(i+1)%n_rays,:]
        # now expand these points of the triangles in each patch to image size
        B = B.expand(size, batch_size, 2)
        B = B.expand(size, size, batch_size, 2)
        A = A.expand(size, batch_size, 2)
        A = A.expand(size, size, batch_size, 2)
        # and permute axes
        B = B.flatten(0, 2)
        A = A.flatten(0, 2)

        # lets follow this website
        # https://blackpawn.com/texts/pointinpoly/default.html
        # P = grid without the belonging channel
        P = Ps[:, i, :]
        v0 = C - A
        v1 = B - A
        v2 = P - A

        dot00 = my_dot(v0, v0)
        dot01 = my_dot(v0, v1)
        dot02 = my_dot(v0, v2)
        dot11 = my_dot(v1, v1)
        dot12 = my_dot(v1, v2)

        # Compute barycentric coordinates
        invDenom = 1 / (dot00 * dot11 - dot01 * dot01)
        u = (dot11 * dot02 - dot01 * dot12) * invDenom
        v = (dot00 * dot12 - dot01 * dot02) * invDenom

        # Check if point is in triangle
        belonging[:, i, :] = ((u >= 0) * (v >= 0) * (u + v < 1))*2 - 1

        distances[:, i, :1] = distance_linesegment_no_sqrt(P, A, B)
        distances[:, i, 1:2] = distance_linesegment_no_sqrt(P, B, C)
        distances[:, i, 2:] = distance_linesegment_no_sqrt(P, C, A)

    # after for loop lets reshape all needed tensors to the correct shape
    belonging = belonging.reshape(size, size, batch_size, n_rays, 1)
    distances = distances.reshape(size, size, batch_size, n_rays, 3)
    # and permute
    belonging = belonging.permute(2, 3, 4, 0, 1)
    distances = distances.permute(2, 3, 4, 0, 1)
    # finally take the minimum of the distances to each line segment of triangle
    distances, _ = distances.min(dim=2, keepdim=True)
    # now calculate the probabilities for each triangle
    probabilities = torch.sigmoid(belonging*distances/sigma)
    # substract the probabilities from 1
    probabilities = 1 - probabilities
    # we now have to multiply over the rays axis and substract that from one
    prod = torch.prod(probabilities, dim=1)
    silhouette = 1 - prod

    return silhouette

def my_dot(v1, v2):
#    bs = v1.size[0]
    x = v1[:, 0] * v2[:, 0]
    y = v1[:, 1] * v2[:, 1]
    dot = x+y
    dot = dot.expand(1, -1)
    dot = dot.transpose(0, 1)
    return dot

def distance_linesegment_no_sqrt(P0, P1, P2):
    # we will use this post for the shortest distance of point to triangle
    # https://stackoverflow.com/a/10984080/10106730
    b = P0 - P1
    a = P2 - P1
    r = my_dot(a, b) / my_dot(a, a)

    output = torch.empty_like(r)
    output[r<=0] = my_dot(b, b)[r<=0]

    c = P0 - P2
    output[r>=1] = my_dot(c, c)[r>=1]

    output[(r>0)*(r<1)] = (my_dot(b, b) - r.pow(2) * my_dot(a, a))[(r>0)*(r<1)]
    return output

In your paper you use the interval [-1,1] for the pixel coordinates and a sigma of 3e-5. I use the interval [0,1]. In the attached picture I used a sigma of 1e-5, but you can clearly see in the histogram that there are 2 different values for beeing in the polygon. Is lowering the sigma value the only possibility to get better results?


get current master is not working in one scenario with redis-sentinel configuration

Expected behavior
  Jedis library should get new master after failover

Actual behavior
  Library is never able to get current master.

Steps to reproduce:
My current conf is like :
There are 3 redis-process: M1,R1,R2
There are 3 sentinels : S1, S2, S3 ( all are monitoring M1)
I have configured my java application using RedisSentinelConfiguration as S1, S2 then S3 in order.
PS : My application is a spring-boot application.

Application comes up and tries to make connection with Sentinels and get current master.
Now lets say S1 goes down. At this time I get exceptions in logs about connection timeout to S1, while redis requests are served with M1 as usual.
Now let's say M1 goes down. As a failover process new master is elected, R1 is promoted as new  master, which I confirmed by sentinel command. While at this point, I keep on getting same connection timeout error to S1, but now jedis never able to find new master. So no redis requests are served at this time. Ideally as per documentation at https://redis.io/topics/sentinel-clients, it should try to ask the new master with S2 ( next one in list), but it is not doing.

Redis / Jedis Configuration
Explained above
Jedis version:
3.3.0
Redis server version:
4.0.9
spring-data-redis version:
2.2.3.RELEASE
Java version:
JAVA-11

can someone please help to check this.

We also hit that issue in production.
After some debugging, it seems that the masterAddress is updated via the "+switch-master" subscription in the MasterListener of JedisSentinelPool, or on some connection loss. To quote the sentinel integration documentation: However update messages received via Pub/Sub should not substitute the above procedure, since there is no guarantee that a client is able to receive all the update messages.
Maybe the master update got lost because it was not received via the pub/sub mechanism?


Security and compliance composite resource

Adding below composite resource for security and compliance.
SCRetentionCompliancePolicy
SCRetentionComplianceRule
SCRoleGroup
SCAutoSensitivityLabelPolicy
SCRoleGroupMember
SCDeviceConditionalAccessPolicy
SCDeviceConfigurationPolicy
SCProtectionAlert
SCSecurityFilter
SCAuditConfigurationPolicy
SCAutoSensitivityLabelRule
SCFilePlanPropertyAuthority
SCFilePlanPropertyCategory
SCFilePlanPropertyCitation
SCFilePlanPropertyDepartment
SCFilePlanPropertyReferenceId
SCFilePlanPropertySubCategory
SCRetentionEventType
SCSupervisoryReviewPolicy
SCSupervisoryReviewRule

Thanks for the PR, @karthiksaseedharan90. Can you please update the changelog accordingly?

Hi @raandree, updated Changelog.md

Thanks, @karthiksaseedharan90, the changes need to go to the changelog's unreleased section. The next version is calculated by GitVersion, hence we are not sure what the next version will be.


Orphans should not wakeup select

Fix select with ipconfigTCP_HANG_PROTECTION == 0:
The problem is that a select will not wake up when the
child socket is accepted, but only when some data is received.
However if the server wants to send data immediately after
accpet that will not work.
Also remove the code in prvTCPSocketCopy() which makes the
child socket inherit the socket set of the parent.
This is most likely just a work-around that makes the select
wake up when the first user data is received.
Select should not wake up on a child socket before it is
accepted.
After the socket is accepted the application may want to use
a different socket set.

Description

This is a bug-fix extracted from #229

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hello @bernd-edlinger,
For now, I think I will close this PR. We can always reopen this if required and copy over your suggested changes.
Thanks,
Aniruddha


Examples Framework & Fractal example

Fixes #30

Any chance we could get away with not including cl.hpp as a part of the repo?

Fixed the tabs. Regarding cl.hpp any reason ? examples will be easy to write, otherwise we have to write examples with horrible C API and it is more error prone.

I meant use the system cl.hpp. I'm not sure whether it's guaranteed to be on every machine, that's why I asked if there is a possibility of not having it here.

It wont be there on every machine, especially for CUDA toolkits. NVIDIA doesn't provide the cl.hpp. AMD APPSDK does i think. It is not uniform yet, so if we want to use it we have to provide it.

Ok.

Removed NVVM dependency.

Sorry for pestering, but the tabs are still there in CMakeModules/FindGLEWmx.cmake. I think you only cleared the examples one.
That said, why do we need 2 of the same files?

i did a retab in vim, i wonder how come they are still there. When examples are shipped with installers, wouldn't that need FindGLEW for that ?

oh wait, you said the main FindGLEWmx . ok i didnt touch that file. might have been there from earlier itself.

Fixed tabs in that FindGLEWmx file.

I have sent that white space fix too.

@shehzan10 It is ready for merge now.


refactor: Simplify the secrets API via an enum for the id's entity

Not that convinced from the current proposal. If we change something in this API, we should go a step further and make it type-safe. This could be achieved by introducing value classes for the IDs of organizations, products, and repositories.
I am not sure, does Kotlin support the inheritance of value classes from a sealed interface? Then we could have something like
sealed interface HierarchyId

The repository then only needs one createSecret(id: HierarchyId) function and can decided based on the ID type on which level to add the new secret.

does Kotlin support the inheritance of value classes from a sealed interface?

It does, and I like that idea. I'll probably follow-up on that later.


A simply silly question

Hi,
Latest dnscrypt-proxy version is 2.0.16.
SimpleDnsCrypt uses 2.0.15.
Please, a simply silly question: Is there any expectation about when will be the SimpleDnsCrypt update?
Thank you in advance!
PS: Feel free to close the issue.

@Decopi Well as of Simple DNSCrypt v0.6.0, the included dnscrypt-proxy is version 2.0.19.


[WIP] components/test_rflink.py refactor

Description:
After various modifications, the test_rflink.py class was the last to one left from refactor.
The objective of this PR is to homogenize the class with the rest of the tests of the RFLink components.
Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): N/A
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io N/A

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example). N/A
New dependencies are only imported inside functions that use them (example). N/A
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py. N/A
New files were added to .coveragerc. N/A

If the code does not interact with devices:

Tests have been added to verify that the new code works. N/A

I need some help to fix the errors and doubts generated by the change.
Specifically:

How to refactor the sleep block (line 282)?

await asyncio.sleep(0, loop=hass.loop)

How to solve errors in the tests?

E  RuntimeError: 1 Runtime Warning,
E  /home-assistant/homeassistant/components/rflink.py:497:coroutine 'send_command' was never awaited

In the case of (1), it is the last reference to the asyncio class that prevents the import block from being deleted. I do not know if it is possible to avoid it.
In the case of (2) I'm not sure how to approach it.
The two failing tests intend to validate the correct operation even if the module is configured in no_wait_for_ack mode. The error message seems to indicate that the error is related to the desired behavior ('send_command' was never awaited), but here I enter into speculations and I am not sure if it is an error or a functionality.
And worse, I do not know how to correct the test to make it work.

Remove WIP and ping egen ready.

Done.
@MartinHjelmare thank you very much for the support and for your patience.


Chatbase 'Add collaborators' allows the user to edit or delete the agent

Hi there,
Not sure where else to log these issues. We're trying to add a collaborator to an agent. Having added them with 'view only' mode they are in fact able to edit and even delete the agent. This does not seem right. I don't want a view-only user being able to edit anything!
Also, there does not seem to be any way of now viewing the people I have added as collaborators. We'd need to be able to revoke access etc.

Thanks for reporting this - logging them here is fine.  They certainly should not be able to edit the agent properties, although for now they will be able to see the api_key (which would allow them to send messages).
They should be allowed to delete the agent, but that should only delete it from their account, not globally.  And as for viewing/modifying the collaborators, this is something we haven't been able to do yet, but is certainly a feature we will add. If you would like to do this now, you can email<EMAIL_ADDRESS>and we can assist.
I'll investigate today to see if the 'Add collaborators' functionality is currently working as intended and let you know what I find out.

Thanks @vmkrish.
Okay I understand what you mean in terms of them deleting the agent.
As far as I could see it I was able to edit the agent's name etc.
Would be great if that feature could be fleshed out - editing collaborators.

Hey JP, just an update, I think Ofer talked to you over email, but despite what it seems, it currently doesn't allow "viewers" to edit the agent.  We're working on polishing off some of the UI here so that it's clearer what's happening, and I'll update this bug when that's done.

Hey Viknesh,
Thanks, yes, Ofer did get hold of me & covered the details around collaborators. We’ve added some and they’re using it!
Thanks!
From: Viknesh Krishnan<EMAIL_ADDRESS>Sent: 13 September 2017 07:56 PM
To: google/chatbase-dotnet<EMAIL_ADDRESS>Cc: JP Thorne<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [google/chatbase-dotnet] Chatbase 'Add collaborators' allows the user to edit or delete the agent (#2)
Hey JP, just an update, I think Ofer talked to you over email, but despite what it seems, it currently doesn't allow "viewers" to edit the agent. We're working on polishing off some of the UI here so that it's clearer what's happening, and I'll update this bug when that's done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/google/chatbase-dotnet/issues/2#issuecomment-329247252, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABWK6IKJssaAeCuaEh9D8XVAq_bdintZks5siBcugaJpZM4PQ9cG.


module 'intake' has no attribute 'open_esm_datastore'

Hi, I opened a jupyter notebook on https://ocean.pangeo.io, and when running -
import intake
col = intake.open_esm_datastore("./pangeo-cmip6.json")
col
I got the following error -
module 'intake' has no attribute 'open_esm_datastore'
It has the attribute open_esm_metadatastore though (not sure if that's relevant). "intake.open_esm_datastore" works well on my local laptop.
any idea what the issue could be here? :)
Thanks!
Chuncheng

@ChunchengGuo,
Can you confirm that you have intake-esm installed in your conda environment by running
conda list intake-esm

?

@andersy005
yes, it is installed, e.g. -
(notebook) jovyan@jupyter-0000-2d0001-2d6276-2d6499:~$ conda list intake-esm
packages in environment at /srv/conda/envs/notebook:

Name                    Version                   Build  Channel
intake-esm                2019.8.23                  py_0    conda-forge

That version is an old version of intake-esm. You need to update to the latest version (2019.10.15) or the from the master branch:
conda install intake-esm==2019.10.15

or
python -m pip install intake-esm --upgrade

or
python -m pip install git+https://github.com/NCAR/intake-esm.git

ah, yes..
I somehow overlooked that when 'conda search'
it works now; thanks @andersy005!


Update matter-devices.xml for 5 clusters

Problem
Basic Information, Bridged Device Basic Infoformation, Localization Configuration, Time Format Localization, and Unit Localization clusters needed to be updated in matter-devices.xml.
Change overview
Updated matter-device.xml to spec for the 5 clusters.
Testing
How was this tested? (at least one bullet point required)

None

/rebase


Custom API Question

Hi,
sorry was quite busy in the last couple of weeks. I have looked at the custom API part, however, I am really not a coder so I am a bit lost here. The solution I would like to interface with is https://github.com/dresden-elektronik/deconz-rest-plugin/wiki
If you feel like it and have some time, would be cool to get some guidance.
I have been able to make some progress. This is what my api URL looks like right now
<IP_ADDRESS>/api/59575AFCF3/lights/5/state/"on": true
Probably there is a syntax error, but I am not a coder and I have used Postman to try this out, where it does work. Any hint
Thanks a lot in advance

Do you get an error?

Yes, I do, is there a log file from which I can get the error. I see an error but i am not able to capture it. URI and 404

you can try to open Fiddler before you make the request, if you give me that I may be able to help. 404 usually means you have the uri wrong

Took another look on fiddler. I guess one of the problems is that I need to use PUT instead of post. However there will be more to it. Some guidacnce would be great!

Not sure what guidance I can give you. Can you provide the RAW Fiddler request for your postman call AND PresenceLight.
on a side note, the screenshot you took above should be removed

Hi
PUT http://<IP_ADDRESS>/api/07A3909DDC/lights/5/state HTTP/1.1
Host: <IP_ADDRESS>
Content-Length: 13
{ "on": true}
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Type: application/json; charset=utf-8
Content-Length: 41
ETag: "0feaf979c15c19f9be949d8ec6eb805d"
[{"success":{"/lights/5/state/on":true}}]
hope this is what you are looking for

This is one of them, if you can label them with '>' for instance

This is a quote

and

this is another quote

I got this on the side of the composer
`HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Type: application/json; charset=utf-8
Content-Length: 41
ETag: "0feaf979c15c19f9be949d8ec6eb805d"
[{"success":{"/lights/5/state/on":true}}]`

Which one is which?

Updated the previous comment: with the full entries

Which one fails?

Of these none: I do not get a capture from the presencelight app.

Make sure PresenceLight is completely closed before opening Fiddler. Once Fiddler is running, open PresenceLight, should be able to see it than

Thanks for the patience:
Request
POST http://<IP_ADDRESS>/api/07A3909DDC/lights/5/state/%22on%22:%20true HTTP/1.1 Host: <IP_ADDRESS> Content-Length: 0
Response
`HTTP/1.1 404 Not Found
Access-Control-Allow-Origin: *
Content-Type: application/json; charset=utf-8
Content-Length: 150
[{"error":{"address":"/lights/5/state/"on": true","description":"method, POST, not available for resource, /lights/5/state/"on": true","type":4}}]`

Well it seems that uri is not structured properly, it is not sending an Http body. That and the affect PUT is not wired up in PresenceLight at all is a challenge. I can't build this sadly as I have no HW to test. If you wanted to take a swipe at it I could help.

I am afraid I am not I have never coded. However I will see that I can put my Zigbee Outlet onto the Philipps HUE Bridge. That might be far easier. Question, Can I control with the app simple on / off scenario ? For me it is enough that I can simple turn on a light when I am "busy". a bit like "On-Air" Thanks for the help and the patience

@Spanishu it is far easier to use the custom api implementation with some sort of sortware smart home solution like node red, home assistant, iobroker, fhem or whatever you like. node red and iobroker offer a graphical interface to configure the logic engine which would control your deconz conbee.

I have decided to take a different route.
I have linked my Ikea Tradfri Plug to the Philipps Hue Bridge (direct integration)
Works until here. What I would be missing is a "probably" simple feature:

My status is Red = Light goes on
My status is Green = Light goes off

I have not been able to see this feature, If there is a workaround please let me know... Almost there! Thanks a lot for the help!

This would be custom light controls per status, which was asked in #77. Closing this


fontspec/luatex font weight/optical size issues

This is a little bit related to issue #7.
fontspec when use with luatex, select "wrong" font weights and optical size, here is a minimum example,
\documentclass{article}
\usepackage[no-math]{fontspec}
\usepackage{pgffor}
\setmainfont{Minion Pro}

\long\def\testtext{
  \par\textrm{Normal}
  \par\textit{Italic}
  \par\textsc{SmallCaps}
  \par\textbf{Bold}
  \par\textbf{\textit{BoldItalic}}
  \par\textbf{\textsc{BoldSmallCaps}}
  \par\textsc{\textit{ItalicSmallCaps}}
  \par\textbf{\textsc{\textit{BoldItalicSmallCaps}}}
}

\long\def\testfont{
  \foreach \size in {5, 8.4, 10, 13, 14, 19.9, 24}
  {{\fontsize{\size pt}{\size pt}\selectfont \size pt\par\testtext\par}}}

\begin{document}
  \testfont
\end{document}

Under Mac OS X 10.6.7, with updated TeXLive 2010, luatex is 64bit.
The the automatically selected optical size is simply a mess. Using Acrobat to investigate the selected fonts for each word, it is found that "Italic Caption" and "Bold Caption" are used for 24pt fonts while 14 point fonts are mixed with "Sub head" and "Regular".
Now change the \setmainfont to the following,
\setmainfont[SizeFeatures = {
  {Size =     -8.41, OpticalSize = 8},
  {Size = 8.41-13.1, OpticalSize = 11},
  {Size = 13.1-20.0, OpticalSize = 19},
  {Size = 20.0-,     OpticalSize = 72}}
]{Minion Pro}

With this setup, correct optical fonts are selected. (The reason I use numbers like 8.41 instead of the 8.4 in Minion Pro is that fontspec use X <= s < Y in size range. For example with \fontsize{13}{13}, and the actual fontsize TeX use is 12.97, if I set Size = 8.4-13, then Subhead is used by fontspec, since the 13 >= 13 white the actually used font 12.97 <= 13. So I shifted the range a little bit.)
Anyway, with the above setup, optical size now works fine.
For the weight, Bold{(\textbf), Italic(\textit), Bold Italic(\textbf{\texit{}}) all works fine. But the regular fonts is a mess. And it seems to be platform dependent, so I guess this is more or less a problem with the interaction of fontspec with luatex or purely a problem with luatex.
To be more specific,
On my Mac, the following weights are used for regular fonts (no bold, no italic). In the following I use "Regular" weights to refer to MinionPro-Capt.otf, MinionPro-Disp.otf, etc.
Caption: Regular
Text: Medium
Subh: Medium
Disp: Regular
But on my RHEL 6.1, still with updated TeXLive 2011, the weights chosen are,
Caption: Medium
Text: Regular
Subh: Regular
Disp: Medium
Though "Medium" and "Regular" do differ very little. But this randomness output is just too strange.
I tried to specify specific fonts for each optical size and bold/italic, but as in issue #7, I cannot get it work.
A simple workaround is to exclude the medium weight font when running mkluatexfontdb, so fontspec or luatex won't be confused.

I cannot reproduce this under TeX Live 2018.