Expose WebLN interface via React Context

Supersedes #715 Closes #533 Closes #490 Closes #75
Based on #753, #752, #777, #778
TODO:

[x] [feature] LNbits
[x] [feature] NWC
[x] [bug] Fix occasional NaN in cache update
[x] [UX] use optimistic cache updates to keep site "snappy" (see 463578c)
[x] ~[UX] use second lightning strike as "thunder" or "confirmation" (similar to double check marks in messengers) for WebLN zaps by overlapping them~
[x] ~[UX] adapt first lightning strike based on if payment is pending (WebLN) or done (custodial) - for example, make pending zaps slower, last longer, different color etc.~
[x] ~[UX] investigate if it makes sense to not immediately generate invoices for async providers (NWC); essentially queueing or batching zaps. For example, we could show a notification on their wallet that when clicked shows that zaps are queued. Only when they are ready to pay, we will initiate a payment which they can approve in their wallet then. If zaps are queued, we could also batch them together and create a single invoice for all of them (needs some updates in the backend to allow hash reuse for acts).~ not planned, too much for MVP
[x] [bug] fix empty fields on hard refresh on config page since configs not initialized on first render
[x] [UX] show persistent toast while zap is pending
[x] [bug] toast race condition: invoice cancelation poll vs NWC invoice paid / error on payment
[x] ~[feature] switch between providers~ not needed yet if we only launch with NWC
[x] testing
[x] [bug] cache update is not always undone

Current state of UX:
https://github.com/stackernews/stacker.news/assets/27162016/81219503-ae61-4475-8c99-516abd14240e

being optimistic about WebLN payments by wrapping them with cache updates (see 463578c). In case of failure, the update is undone.
user feedback via second lightning strike that is thicker.
if lightning animation was disabled, toasts are used.

However, what I actually intended was to resemble lightning and thunder. The existing lightning strikes could be used as before. However, for WebLN zaps, they simply mean that the payment was initiated but is still pending.
The second lightning strike is then the "thunder" to confirm the payment. Since we probably shouldn't play sound since we're no longer in the MySpace era (but maybe it could be a fun setting?), I simply made the second lightning strike thicker. But I imagined the second lightning strike to additionally outline the previous one. This would then also feel more like a confirmation of what happened previously.
This is also similar to how messengers work to indicate the status of messages: One check mark means that the message was sent while two mean that the message was received.
If we have two strikes (which completely overlap) then I think this could be quite intuitive for users.

I think your intuition around having two signals is spot on.
however, without the explanation, ie just watching the video, I found the double strike confusing. I couldn't tell why the second strike was happening.
Another variation:

no initial strike
persistent toast pops up while zap is pending

could have an 'undo'/'cancel'/retry button on it and any other state/progress/control mechanism on it

when the zap settles, lightning strike and toast goes away

(2) is something I've been wanting to do for even custodial zaps, giving stackers a chance to cancel zaps.

Okay, I think this is basically done now from a feature and UX perspective.
Only things left to do:

[ ] think about security for MVP: NWC allows budget controls so can we ship NWC using unencrypted local storage? Add warning about XSS which users can understand? Wallets contain similar warnings:

One idea I had was to only store the decryption key on the server which is bound to having a valid session. But I think the single point of failure is always the client in that case. If we automatically decrypt the wallet credentials (for UX reasons), then XSS is still possible. I believe we can only make XSS harder but never prevent it when we store wallet credentials in the client, as you also mentioned here:

but afaict we can only add more steps to potential exploits (better than nothing but still).

related to #770

[ ] hide LNbits in production since it's 100% vulnerable to XSS

[ ] consider E2E testing of approval of NWC invoices but that would mean I need to link my local polar network to a wallet that supports NWC. I thought about Alby but not sure that's worth the effort. If they implement NWC correctly, the code should just work.

I have an appointment now and will think more about this when I am back in a few hours.

Test showcase in multiple parts because I found some bugs and didn't want to re-record everything. Just stopped the capture, fixed the bug and started new capture.
See https://files.ekzyis.com/public/sn/webln

Ok, will look into #770 but since it's independent of this code, I marked this PR as ready for review.
NWC connections still use local storage in this PR since using IndexedDB is more complicated, it's not a long-term solution and not a real defense layer against XSS like encryption or CSP:

In a nutshell, XSS means game over!

-- https://pragmaticwebsecurity.com/articles/oauthoidc/localstorage-xss.html

Regarding UX, especially on mobile:
Would be great if wallets like Mutiny would support push notifications with actions. Then users don't have to switch apps but can simply click Approve or Deny in the push notification. Similar to how you can mark messages as read without opening Telegram or Signal.
/cc @benthecarman @TonyGiorgio

This is a long term plan but requires some architecture changes for us

@ekzyis any advice on getting setup to QA this?

any advice on getting setup to QA this?

Oh yes, good question haha
For testing approvals in a E2E way, I setup LNbits (using the recommended option using poetry) and connected it to a third node in Polar:

For NWC requests, you can use Mutiny wallet and go to settings > connections but since it's running on a different network, the NWC requests show up but you can't test approvals like this (only rejections). I added some code in components/webln.js that can be used to mock the NWC responses:
// XXX set this to mock NWC relays
const MOCK_NWC_RELAY = false

// need big timeout since NWC is async (user needs to confirm payment in wallet)
const timeout = MOCK_NWC_RELAY ? 3000 : 60000
let timer
const resetTimer = () => {
  clearTimeout(timer)
  timer = setTimeout(() => {
    sub?.close()
    if (MOCK_NWC_RELAY) {
      const heads = Math.random() < 0.5
      if (heads) {
        return resolve({ preimage: null })
      }
      return reject(new Error('mock error'))
    }
    return reject(new Error('timeout'))
  }, timeout)
}
if (MOCK_NWC_RELAY) return resetTimer()

I haven't found an easy way to test NWC in a E2E way, too. But the subscription code looks simple enough that it should "just work":
const filter = {
  kinds: [23195],
  authors: [walletPubkey],
  '#e': [request.id]
}
const sub = relay.subscribe([filter], {
  async onevent (response) {
    resetTimer()
    try {
      const content = JSON.parse(await nip04.decrypt(secret, walletPubkey, response.content))
      if (content.error) return reject(new Error(content.error.message))
      if (content.result) return resolve({ preimage: content.result.preimage })
    } catch (err) {
      return reject(err)
    } finally {
      clearTimeout(timer)
      sub.close()
    }
  },
  onclose (reason) {
    clearTimeout(timer)
    reject(new Error(reason))
  }
})

@benthecarman, would you mind to review the sendPayment function in components/webln/nwc.js? That should work as-is, right?

yeah that looks correct to me

I went back to my tab and it no longer recognizes the setting?
https://github.com/stackernews/stacker.news/assets/34140557/d6c2e0f9-355b-4ca1-89ad-ba32cdf11458

I'm using lnbits and all of my payments display as pending despite while seeming to succeed. This might be a UX bug but it immediately confused me so we'll want a solution for it.

Mhh, interesting. The invoices get cancelled for some reason but the toast doesn't update to zap failed. So that's a UX bug. Your LNbits instance seems to return 520 for /api/v1/payments (sending the payment) though. What makes you think the payments succeeded?
Did it work before or is this the first time you tried it?

we probably shouldn't call this all webLn which is a protocol we aren't using here

Mhh, yes, it's not really WebLN since we're not using window.webln like in the WebLN guide but afaict, WebLN is not a protocol, just a standard / interface. Essentially, I called it WebLN in our code since I implemented the same (but incomplete) interface using the React Context API: enabled, getInfo and sendPayment with same return values. So imo, the only difference is useWebLN vs window.webln and that it's incomplete since we don't need anything else.
This integrates a lot better into our code than attaching something to window. Bitcoin Connect also no longer attaches anything to window by default. And they mention this in their README:

This project includes web components for connecting to Lightning wallets and enabling WebLN. Websites only need to interface with WebLN to connect with multiple wallets, just like the Alby extension.

I would say we're doing the same: we are interfacing with WebLN.

my wallet indicator goes red if I put in an incorrect host (good) but I have no way to diagnose (bad)

to be fair with lnaddr I don't even make the indicator red when it's failing, but if we know it failed, it should be trivial to store the reason on the client and surface it for stackers

Good point, that was an oversight. I can add a toast for that.

having an independent context for each wallet source might be okay for now, but it'll be a lot later so maybe begin thinking about how to provide it in one context if not just implement it that way

Not sure if you already looked into the code, but the consuming code only sees one context: the WebLNContext. This context wraps a context per WebLN provider:
export function WebLNProvider ({ children }) {
  return (
    <LNbitsProvider>
      <NWCProvider>
        <RawWebLNProvider>
          {children}
        </RawWebLNProvider>
      </NWCProvider>
    </LNbitsProvider>
  )
}

export function useWebLN () {
  return useContext(WebLNContext)
}

All we need to do to switch between providers is to make provider a state variable with useState() in components/webln/index.js and then use setProvider for switching. I think this is a good pattern since I think this exactly when one should use the Context API: We want to provide WebLN providers to the rest of the application and we want to have a nice interface for them (so we can just call useWebLN where we need them), so these WebLN (context) providers are wrapped by another context provider.

We'll want docs on how to set this up using docker. It took me an hour or two to troubleshoot LNBits config problems.

 Or did you have other problems which I should clarify in the documentation?

I went back to my tab and it no longer recognizes the setting?

Ah yes, the config gets saved immediately but the status check using getInfo is done asynchronously as an effect with useEffect. Might make more sense to make it blocking and also use double toasts for pending status check and it it failed or was successful. Related to missing information on red wallet indicator.

Your LNbits instance seems to return 520 for /api/v1/payments (sending the payment) though. What makes you think the payments succeeded?

That was an old log entry. Notice how the error isn't present later.

Essentially, I called it WebLN in our code since I implemented the same (but incomplete) interface using the React Context API: enabled, getInfo and sendPayment with same return values.

Fair point. I guess so long as the interface is identical we can call it webln.

Not sure if you already looked into the code, but the consuming code only sees one context: the WebLNContext.

I see. That's probably the right way to do this. I hadn't looked at the code much.

That was an old log entry. Notice how the error isn't present later.

As mentioned in Slack, hopefully this was just because the worker not running. I had an issue that looked very like yours just now and running the worker fixed it. The worker is required to mark HODL invoices as held so we can retry the action.

I briefly looked at the function. It looks like you're doing that thing where state update 1 -> side effect 1 -> state update 2 -> side effect 2. While you're revisiting the code, consider if this side effect chaining can be avoided. One way I try to trick my brain into avoiding this is to think of useEffect as an antipattern (like goto in C) and to not use it expect where I have no other choice (I still end up using it more than I should but maybe it'll help you notice it more too).

I'll try to integrate this into formik validation. Makes no sense to close the form and then check fors errors. We should keep the form open until the user entered something that works.

As mentioned in Slack, hopefully this happened just because the worker was not running. I had an issue that looked very like yours just now and running the worker fixed it. The worker is required to mark HODL invoices as held so we can retry the action.

Confirmed. I just didn't have the worker running. I'll push in some lnbits docs as I continue testing then do a line by line review.

When I post with 0 sats, the toast says "zap pending" even though I'm just paying posting fees.

Bug during commenting: when I submit a comment with fees, it says it failed but it actually succeeded.
https://github.com/stackernews/stacker.news/assets/34140557/cca6a0b7-3565-4488-8948-09b9613457a5

Wallet configs are now validated on save:
https://github.com/stackernews/stacker.news/assets/27162016/93f270cc-0f6f-4015-a786-dd0b3896e688
However, I realized that using the info event for validation does not guarantee that the secret is correct since it's not needed to receive the info event. Only the relay URL and the wallet pubkey must be correct.
I will add some static checks though (correct amount of characters etc).

When I post with 0 sats, the toast says "zap pending" even though I'm just paying posting fees.
Edit: same thing on the donation page

Bug during commenting: when I submit a comment with fees, it says it failed but it actually succeeded.

Oh, I noticed I only tested with zaps and forget to test other things that require payment since I added the toasts. Will do that now

Tested paying with attached wallet in cc6c460:

[x] zap
[x] custom zap (using long press)
[x] commenting
[x] donation
[x] post

https://github.com/stackernews/stacker.news/assets/27162016/7860a634-9044-4d52-ae0f-a6d4d3e02467

Will do.
(Apologies for the stray commit. I didn't check before pushing and now I'd have to force push.)
Other changes are:

docs for local lnbits setup in docker
schema allow lnbits on localhost in dev

Confirmed. Works really well now! I'll do a pass over the code. I think the only thing we might want to add before shipping is allowing selection of one send-only wallet or the other as default, so that people can add two.

hide LNbits in production since it's 100% vulnerable to XSS

LNbits has this notion of wallets which are like budgeted accounts so it's not much worse than NWC in that respect. So, I think we can ship with it.
In either case, it might worth adding a warning to either method like

Your wallet's credentials are stored in the browser and never go to the server. Absolutely, positively, listen when we say you should set a budget on the wallet credentials. Also, for the time being, you will have to reenter your credentials on other devices.

LNbits has this notion of wallets which are like budgeted accounts so it's not much worse than NWC in that respect. So, I think we can ship with it.
In either case, it might worth adding a warning to either method like

Your wallet's credentials are stored in the browser and never go to the server. Absolutely, positively, listen when we say you should set a budget on the wallet credentials. Also, for the time being, you will have to reenter your credentials on other devices.

Mhh, makes sense! Since we can not only pay invoices but also fetch their balance with their LNbits admin key, we could additionally enhance this warning if we detect they have 100k+ sats in their wallet (for example). This would also make it clear that SN can see their balance when they use LNbits. They have to trust us that there is no code[^1] running that stores that somewhere.
I'll do this in another PR so you can easily dismiss that change if you don't think that's a good idea.

optional nit: a checkbox to say one send-only provider should be preferred over the other
a warning on these send only methods cautioning folks to make sure they have limited access to funds.

:+1:
[^1]: Even though we're FOSS, "hidden code" could be running which isn't even checked into Github. Verifying which code is actually running on a website is an unsolved problem afaict.

4b95add adds a default payment method checkbox. This required more code (including some useEffect's again :sweat_smile:) than expected. Mostly because there are some cases to consider:

first enabled payment method -> set default
different payment method set as default -> unset default for other payment methods
payment method is no longer enabled -> unset default

But seems to work fine now:
https://github.com/stackernews/stacker.news/assets/27162016/16bed933-1356-42ae-b041-5262c5ad0cd4
Some issues I have with the current implementation:

[UX] there should probably be an indicator on the card what is the default -> use outline with CSS?
[UX] should you be able to unset default payment method if that is the only enabled one?
[code] maybe I can store the default payment method in WebLNContext so the individual providers themselves don't need to know if they are the default provider or not :thinking:

I'll think about this more while I add the warning and eat something.

Added disclaimer in 7a55913:

Looks great. Ready for merge?


Unhandled Exception

Summary:
Error :  Return value of Jikan\Parser\Anime\AnimeParser::getScoredBy() must be of the type int or null, string returned
trace: /var/www/jikan/vendor/jikan-me/jikan/src/Parser/Anime/AnimeParser.php at line 428
Steps to reproduce:
Calling https://api.jikan.moe/v3/anime/40028
Additional Details
status | 500
type | "Exception"
message | "Unhandled Exception. Please follow report_url to generate an issue on GitHub"
trace | "/var/www/jikan/vendor/jikan-me/jikan/src/Parser/Anime/AnimeParser.php at line 428"
error | "Return value of Jikan\Parser\Anime\AnimeParser::getScoredBy() must be of the type int or null, string returned"

Good find, thanks for reporting! I'll look into this soon.
For self-reference, this is possibly due to MAL returning - on the number of Users now.

  Score:
  N/A1 (scored by - users)

    1
          indicates a weighted score.

The parser parses from the data-user attribute here

        N/A

https://github.com/jikan-me/jikan/blob/master/src/Parser/Anime/AnimeParser.php#L423-L439
https://github.com/jikan-me/jikan/blob/master/src/Model/Anime/Anime.php#L218

I believe this could just be fixed by doing:
diff --git a/src/Parser/Anime/AnimeParser.php b/src/Parser/Anime/AnimeParser.php
index 1b67a99..88c393b 100644
--- a/src/Parser/Anime/AnimeParser.php
+++ b/src/Parser/Anime/AnimeParser.php
@@ -424,12 +424,19 @@ class AnimeParser implements ParserInterface
     {
         $scoredBy = $this->crawler->filterXPath('//div[@class="fl-l score"]')->attr('data-user');

-        return str_replace(
+        $scoredByNum = str_replace(
             [',', ' users', ' user'],
             '',
             $scoredBy
         );

+        if (!is_numeric($scoredByNum)) {
+         return null ;
+        }
+
+        return (int) $scoredByNum;
+
+
         //        $rating = Parser::textOrNull($this->crawler->filterXPath('//span[@itemprop="ratingCount"]'));
         //        if ($rating === null) {
         //            return $rating;

I'm not familiar enough with the composer/phpunit environment to be able to debug this to see if thats right though.
Heres a basic test of the function.


Encryption

Is this supported https://www.consul.io/docs/agent/encryption.html ?

We use the encrypt configuration in our config_hash and it starts up with gossip encryption without issue in our setup. Our hiera looks like:
consul::config_hash:
...
  encrypt: ourkeygenvalue
...

As for automatically generating that value for the configuration, I'm not sure that's something that can be done here at the moment.

thanks


Use getRouteKeyName() instead of hardcoded string

In the rare case we would change the route key of the channel model, we would have to remember to also change this in the RouteServiceProvider.
Not sure about creating a new instance each time, but getRouteKeyName() cannot be called statically.

Eh let's let keep it simple for now, if you don't mind.


[Suggestion] Config option to define what tool, or no tool, can be used to harvest trees

Seems a bit silly to me using an axe on a small bonsai tree where as a tool like shears would be better suited.
Would like to see a config option for players and mod pack makers to add in what tools will harvest the trees.
Thanks for all the time and effort you put into this mod.

Good idea. Will implement!


docs: add Auth0 SAML Guide

Hi,
this PR adds the Guide to use Pulumi SCIM with Auth0

@dirien can we get this added to the nav as well?

if you can drop Configuring from the items there while ur there id also appreciate it!

@susanev is this title_tag or title?

ok, changed it @susanev. Let se what happens 😅

Hi @susanev, I have no idea where this navbar entries coming from... Maybe you have a look.

Hi @susanev,

Found the issue and fixed it! Now all should be fine 😄

@dirien @susanev Is this still something we are aiming to land?
cc also @EvanBoyle to make sure this is something we know we are documenting as recommended.

@lukehoban, would love to have this added! Thinking to create an AWS Cognito doc too!

I left a few grammatical comments, however, this looks like we should
land!  Thanks @Engin Diri @.***>
On Mon, Mar 6, 2023 at 12:56 AM Engin Diri @.***> wrote:

@lukehoban https://github.com/lukehoban, would love to have this added!
Thinking to create an AWS Cognito doc too!
—
Reply to this email directly, view it on GitHub
https://github.com/pulumi/pulumi-hugo/pull/2448#issuecomment-1455729342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB77TQXW6IIRSB6OWBKL3Y3W2WREJANCNFSM6AAAAAAULKBGGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks @ericrudder for your feedback! Appreciate this very much! 👍
So this PR is ready, merged all suggestion!


Split PropertyInfo and MethodInfo off from Object into their own separate files.

To avoid cyclic dependencies in a different PR I am working on (https://github.com/godotengine/godot/pull/82198), I need to be able to include PropertyInfo and MethodInfo without also including Object. Additionally, separating out these structs helps keep Object.h/cpp focused on just Object stuff.

Hmm, I'm noticing that the Linux build is failing because Connection already seems to be defined in some third-party file. Should I put connection.h/cpp in maybe namespace Signal to avoid the conflict? Alternatively, I could move Connection to be inside Callable. The only other option I can think of really is to rename Connection to something like SignalConnection.

I actually managed to find a different solution so that structs can work without relying on splitting PropertyInfo, MethodInfo, and Connection into separate files. I think splitting off PropertyInfo and MethodInfo into their own files is still good for code hygiene, but I'll leave Connection attached to Object to avoid the namespace conflicts over Connection.
If others don't like the change of splitting of PropertyInfo and MethodInfo, I'm fine with closing this PR.

I've resolved the conflicts on this branch and left the Connection struct as part of Object.

Makes sense to me conceptually. Could use a rebase to make sure it still works.


Allow orgwide import

Hi @angeliski
Thanks for the great plugin, is there any way to allow these catalog import plugin, on the gcp org level? and we allow service account permissions to allow all these imports to do discovery on the org level? for all the types you specified?

cloud
project
resources
gcp
cloudsql

Hi @nia-potato
Could you elaborate more what are you expecting? I understand the problem (because now we need to find each project and config for that), but I want to understand more what are you expectation here.
What you what to see the import do?
I have plans to work toward a more seamless integration, but now I am looking for early feedback too, so I am happy to listenen your feedback

@angeliski yea sorry for the delay, so this is the current config:
      - project: my-gcp-project-id
        ownerLabel: team # string
        componentLabel: app # string
        cloudsql:
          resourceType: SQL  # string
        redis:
          resourceType: Redis  # string
          location: us-central1 # string
        schedule: # same options as in TaskScheduleDefinition
          # supports cron, ISO duration, "human duration" as used in code
          frequency: { minutes: 30 }
          # supports ISO duration, "human duration" as used in code
          timeout: { minutes: 3 }

i was wondering if it could be like this, where the backstage google service account would then be granted org wide, so we do not need declare it to each project. however the problem how would we extract the ownerLabel  and i think we should also have option to import this as a backstage kind:Resource type:redis , type:spanner, type:cloudsql. idk if this is helpful feedback.
      - orgId: #######  gcp OrgId
        cloudsql:
          resourceType: SQL
        redis:
          resourceType: Redis  # string
        spanner:

        schedule: # same options as in TaskScheduleDefinition
          # supports cron, ISO duration, "human duration" as used in code
          frequency: { minutes: 30 }
          # supports ISO duration, "human duration" as used in code
          timeout: { minutes: 3 }

Thanks @nia-potato very helpful indeed
I will play with some ideas and try to draft a PR for that so we can see an early version with that

Hey @nia-potato I released a new version to try to import from the org using Google API. Could you try and provide some feedback?

We start to use in company and works fine. Some refinements are necessary but we can open new issues to work in that


Default Application : Urgent Help

Hey,
I am working for the first time with RTSP -RTMP streaming. Can someone help me out about how does the default app work given in this project, so I can get a better understand regarding the same. Or maybe if there is a list of steps or a video to help me out figure it, that would be really helpful.
Urgently needed.
Thank you ! Cheers !

Default example is only a code example to stream with default parameters (640x480 resolution and stereo audio with 3200hz).
In that activity you can switch camera (back and front), record a video in a local file and stream to media server.
Edit text is used to indicate endpoint used to stream to media server after press start stream. If you need a server to stream you can use any of this:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/wiki/Media-servers-tested


[proposal] add proposal of multiplexing cloud-edge traffic

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind design
What this PR does / why we need it:
Add a proposal to multiplexing cloud-edge traffic in order to reduce public network costs.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/assign @Fei-Guo @gnunu @Congrool @donychen1134

/lgtm

We'd better to add this feature to Roadmap v0.8.0.

We'd better to add this feature to Roadmap v0.8.0.

@Congrool agree +1, and i will create issues to follow this proposal.


Move isFallback to FileBuildSettings

A refactoring to move isFallback into FileBuildSettings
issue: https://github.com/apple/sourcekit-lsp/issues/861

@swift-ci Please test


Remove markdown-language-features for now

What it does

Remove markdown-language-features for now.
Will be readded as part of #26
How to test

Build should work again
Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

Hi Rob @thegecko
this PR fixes the current build issue that the markdown-language-features plugin can't be downloaded.


Add support for nonactivating panel on MacOS

Context
What I am trying to achieve is to have a window that I can bring to the foreground with a hotkey, similar to Spotlight/Raycase/Alfred on Macos or the Power Toys Run on windows. This window should be the input focus and I can enter something and press enter to close it. For the most part this works but there are some limitations that make the exact behaviour hard to achieve.
Current Behaviour
Specifically, on MacOS, I cannot make the panel visible, bring it to the front and set it focused without activating the application. This means if there are any other windows, they are also activated. The reason for this is that I have to use the Java awt function Desktop.getDesktop().requestForeground(false) to get the window to receive input focus. On windows, changing the visible parameter of window  (something like this Window(         visible = viewModel.trackerOpen,         onCloseRequest = exit,         undecorated = true,         resizable = false,         alwaysOnTop = true,         state = trackerWindowState,         transparent = true     )) is enough to open it and receive focus.
Desired Behaviour
There is a way for my window to receive focus without having to activate the entire application.
Additional Info
It looked like this actually works on windows but is an issue on MacOS.

Thanks for the proposal, we'll discuss it internally and come back with a specific plan.

Did I understand the case correctly:

The application has multiple opened windows, but they are all in foreground (behind another applications, for example)
Should be a way to bring (or create) only one window to foreground without bringing the other windows.

And did understand correctly, that there is a workround, using AWT directly (esktop.getDesktop().requestForeground(false))?

also brings the app into focus which means, when the relevant window is closed, the app is still in focus and the next app window pops to front.

This looks like another bug.
As a workaround, you can try to create the window this way

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


to_bytearray() incorrect

This following is a specific case encountered on NEO TestNet and currently fails for this lib.
        b6 = BigInteger(-48335248028225339427907476932896373492484053930)
        b6ba = b6.to_bytearray()
        self.assertEqual(20, len(b6ba))

It instead it returns 8 bytes

I think initialization is the problem: if type(param) is int: was intended only for int32, not global python ints (which are other types of bigints).
I have an idea, will internally pass as str for all cases, solving all issues.

Passing now:
>>> b6ba = b6.to_bytearray()
>>> len(b6ba)
20


['Microsoft.Synapse/workspaces/bigDataPools@2021-06-01']: cacheSize is shown as a read only field.

Resource Type
Microsoft.Synapse/workspaces/bigDataPools
Api Version
2021-06-01
Issue Type
Property(s) inaccurately marked read-only/write-only
Other Notes
It seems cacheSize is inaccurately marked as Read-only field. I'm able to set that to 0 and it worked fine. It is not showing up in the suggestions as it was set to Read-only field. Please update if it is incorrect.
It is not a read-only field in the previous versions.
Bicep Repro
No response
Confirm

[X] I have read the troubleshooting guide and looked for duplicates.

the cacheSize is marked as "read-only" in this pr https://github.com/Azure/azure-rest-api-specs/pull/22303
@sparatala @ruowan could you please help explain why this change is made? thanks!

The issue is still valid. I can also confirm that updating it works. I was on the verge of creating a deployment script which would do the same thing, so please update to make sure devs are not wasting their time :)

for us cacheSize is ignored, so we end up with Spark Pools having the default value of 50%... 😣

I can also confirm that this bug is still open. cacheSize is ignored and default value 50%. Could someone provide an ETA?

According do Microsoft engineers this is supposed to be fixed by now (without releasing a new API version and without mentioning it in the release notes 🤷♂).
So it should work in 2021-06-01 as I was told (did not test it myself yet).


OTEL_EXPORTER_OTLP_ENDPOINT env variable does not work with a trailing /

Description of the bug
When using the OTEL_EXPORTER_OTLP_ENDPOINT env variable, if the endpoint contains a trailing /, the final URL becomes <endpoint>//v1/traces instead of <endpoint>/v1/traces and traces are not sent to the expected place. Other OTel exporter libraries (e.g. Python, JS) handle endpoints with or without a trailing / so it would be good to keep it consistent with the Ruby exporter as well.
Here's a PR that makes a change to handle the trailing /: https://github.com/open-telemetry/opentelemetry-ruby/pull/1339
Share details about your runtime
Operating system details: MacOS Monterey 12.1
RUBY_ENGINE: "ruby"
RUBY_VERSION: "2.7.2"
RUBY_DESCRIPTION: "ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [arm64-darwin21]"
Share a simplified reproduction if possible
OTEL_EXPORTER_OTLP_ENDPOINT is set to https://localhost:4318/ and so traces are being sent to https://localhost:4318//v1/traces
require 'opentelemetry/sdk'
require 'opentelemetry/exporter/otlp'
require 'opentelemetry/instrumentation/all'

  OpenTelemetry::SDK.configure do |c|
    c.service_name = ENV['SERVICE_NAME']

    # enable all auto-instrumentation available
    c.use_all()

    # add the Baggage and CarryOn processors to thepipeline
    c.add_span_processor(O11yWrapper::BaggageSpanProcessor.new)
    c.add_span_processor(O11yWrapper::CarryOnSpanProcessor.new)

    # Because we tinkered with the pipeline, we'll need to
    # wire up span batching and sending via OTLP ourselves.
    # This is usually the default.
    c.add_span_processor(
      OpenTelemetry::SDK::Trace::Export::BatchSpanProcessor.new(
        OpenTelemetry::Exporter::OTLP::Exporter.new()
      )
    )
  end

Closed by #1339 if someone With Power wishes to push to the Close button.


optional custom index settings in vectorstore

Hi, I have simply added a parameter to the ElasticsearchStore class in order to set default settings at index creation, that is made by the VectorStore helper in the Elasticsearch library. It is just arguments traversing calls, there is not much to test. There is also another minor fix in the doctring.
The main benefit of this parameter is to pre-configure the index when using the Elasticsearch vector store, which implicitly creates an index when first documents are added. One can, for example, set a correct number of replicas for his cluster, so that he has not to change it manually after creation, with all the waste of computational effort this implies

@giacbrd Yes, that is a problem, looks like I missed adding those as dev dependencies in the project files. Thanks.


Parameters missing descriptions

Several of the parameters are missing descriptions and instead have filler text:  For example:
-EnableMeetingEngagement
Current description:
{{Fill EnableMeetingEngagement Description}}
-PublicationBatchDelay
Current description:
{{Fill PublicationBatchDelay Description}}
-EnableViewBasedSubscriptionMode
Current description:
{{Fill EnableViewBasedSubscriptionMode Description}}
-SupportModernFilePicker
Current description:
{{Fill SupportModernFilePicker Description}}
-TelemetryTier
Current description:
{{Fill TelemetryTier Description}}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbf61d7d-bda0-9656-465d-9b519ed17b5e
Version Independent ID: 2bb4825d-eedc-c8e2-3f51-0cafd652eadd
Content: Set-CsClientPolicy (skype)
Content Source: skype/skype-ps/skype/Set-CsClientPolicy.md
Service: skypeforbusiness-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@officedocsbot assign @yogkumgit

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @grtaylo Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


how can i strip readonly via mapped types?

nightly build  of Dec 17
given
interface Point {
   readonly x: number;
   readonly y: number;
}

i need a writable version of it
type WritablePoint = Writable<Point>;

where Writable is
type Writable<T> = {
    // what goes here?
}

I'm running into exactly the same issue.
For example, internal types of some complex tree structure should be immutable in public interface but for the sake of performance there should be a way for direct mutation in internal methods. It's a perfect place for a cast to a Writable<T> or even better Mutable<T>.

Forget about it, readonly properties are useless due to #13002. Focus on something more rewarding.

I don't know whether this will be of any use to you but:
interface Point {
   readonly x: number;
   readonly y: number;
}

declare const x: Point;
declare function stripReadonly<T>(x: Readonly<T>): T;
stripReadonly(x) // { x: number, y: number }

Also see https://github.com/Microsoft/TypeScript/pull/12589

It would have been a good choice it we chose mutable version by default, so that only in few places had we use Readonly <Point>, but the thing with immutability is that it is contagious and has to be a default choice across most of your entities. It spreads from the top level entities all the way down to lower level entities, because say you can't have a readonly Circle with a mutable centre point.
So if I go this route I would have Readonly<...> everyehere. Which is a questionable return for investment.

So if I go this route I would have Readonly<...> everyehere. Which is a questionable return for investment.

@aleksey-bykov Not necessarily. Why can't you define them as following instead?
interface WritablePoint {
  x: number;
  y: number;
}

type Point = Readonly<WritablePoint>;

and then use Point as before without changing references in most places of your code?

@RReverser read my answer above, tldr: when readonly is a default choice, so it should be encoded with a shorter signature

@aleksey-bykov Well, you define type just once anyway and in all the other places you can still use it with short name.

@RReverser you are right, should have read you more closely, yes i guess it might be an option, need to sleep over it

@RReverser i tried it, major problem is that type declarations cannot be inherited like interfaces
type Point = Readonly<WritablePoint>
type Size = Readonly<WritableSize>
interface Box extends Point, Size { // <-- type error
}

interface Box extends Point, Size { // <-- type error
Think type & / intersection solve it 🌹

Agree with @basarat, basically for inheriting type you'll need type Box = Point & Size; which looks less awkward IMO.


chore: do not publish .well-known template file

#428  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


TermsQuery with TermsLookup is not constructed properly

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v7 (for Elasticsearch 7.x)
[x] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
Please describe the expected behavior
When using terms lookup from other index, query should look like
{
  "query" : {
    "bool" : {
      "filter" : {
        "terms" : {
          "proteins" : {
            "index" : "microarrays",
            "type" : "experiment",
            "id" : "experiment1234",
            "path" : "upregulated_proteins"
          }
        }
      }
    }
  }
}

for Golang code
termLookup := elastic.NewTermsLookup().
		Index("microarrays").
		Type("experiment").
		Id("experiment1234").
		Path("upregulated_proteins")
client.Search("index1").Type("doc").Query(elastic.NewBoolQuery().Filter(termLookup))

Please describe the actual behavior
We get a query that looks like
{
"query": {
        "bool": {
            "filter": {
                "id": "experiment1234",
                "index": "microarrays",
                "path": "upregulated_proteins",
                "type": "experiment"
            }
        }
    }
}

which is wrong, because the NewTermsLookup doesn't take name which needs to go in as key into the filter
Any steps to reproduce the behavior?
Manual query construction for this as mentioned in https://www.elastic.co/blog/terms-filter-lookup works fine, trying above golang code doesn't create correct query
Even though I wrap the termLookup in NewTermsQuery, it generates something like termLookupQuery := elastic.NewTermsQuery("proteins", termLookup). I get something like
{
    "query": {
        "bool": {
            "filter": {
                "terms": {
                    "proteins": [
                        {}
                    ]
                }
            }
        }
    }
}

which doesn't work too

You're using elastic.NewTermsLookup as a query, which isn't what it's supposed to do.
Here's a test to illustrate what, I think, you're trying to achieve. Does that help?

That works, thanks for the update, didn't realize TermsQuery itself has the lookup. Thank you!


other/ramdisk.tar.gz: No such file or directory

[] Getting device info...
[] Creating ramdisk
gzip: other/ramdisk.tar.gz: No such file or directory
[-] An error occurred
what is ?

Can you please use --debug and show the error

Can you please use --debug and show the error

yes,
rubens@rubensdev:~/palera1n$ sudo ./palera1n.sh --dfu 15.4.1 --debug
palera1n | Version 1.0.0
Written by Nebula | Some code and ramdisk from Nathan | Patching commands and help from Mineek | Loader app by Amy
[] Getting device info...
[] Creating ramdisk
gzip: other/ramdisk.tar.gz: No such file or directory
[-] An error occurred
rubens@rubensdev:~/palera1n$

Is it in ramdisk/other? The only thing I can think of is that it doesn't like the relative path. Can you modify line 17 of ramdisk/sshrd.sh to be gzip -d $(pwd)/other/ramdisk.tar.gz. Also, throw in echo $(pwd) right above it. Then, show me the output.

d0ne,
[] Getting device info...
[] Creating ramdisk
gzip: /home/rubens/palera1n/ramdisk/other/ramdisk.tar.gz: No such file or directory
[-] An error occurred

Can you clone the repo again? I don't see a reason why it isn't working.

Can you clone the repo again? I don't see a reason why it isn't working.

I discovered!!!
copy paste "ramdisk" inside the "other" folder
sorry me bad english

what? do you mean copying ramdisk.tar.gz into the other folder in the root directory?

now:
100% [===================================================================================================>]
download succeeded
usb_timeout: 5
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID:8010 CPRV:11 CPFM:03 SCEP:01 BDID:0C ECID:000E415818EAED26 IBFL:3C SRTG:[iBoot-26<IP_ADDRESS>.33] PWND:[gaster]
Found the USB handle.
Now you can boot untrusted images.
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
Found the USB handle.
usb_timeout: 5
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID:8010 CPRV:11 CPFM:03 SCEP:01 BDID:0C ECID:000E415818EAED26 IBFL:3C SRTG:[iBoot-26<IP_ADDRESS>.33] PWND:[gaster]
Found the USB handle.
Now you can boot untrusted images.
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
Found the USB handle.
main: Starting...
iOS 14 iBoot detected!
getting get_debug_enabled_patch() patch
getting get_sigcheck_patch() patch
applying patch=0x1800c2d88 : 000080d2
applying patch=0x1800c2ddc : 000080d2
applying patch=0x1800c4758 : 200080d2
main: Writing out patched file to work/iBSS.patched...
main: Quitting...
none
main: Starting...
iOS 14 iBoot detected!
getting get_boot_arg_patch(rd=md0 debug=0x2014e -v wdt=-1  ) patch
getting get_debug_enabled_patch() patch
getting get_unlock_nvram_patch() patch
getting get_sigcheck_patch() patch
applying patch=0x1800c2d88 : 000080d2
applying patch=0x1800c2ddc : 000080d2
applying patch=0x1800b38c8 : 000080d2c0035fd6
applying patch=0x1800b3918 : 000080d2c0035fd6
applying patch=0x1800f0d28 : 000080d2c0035fd6
applying patch=0x1800c4758 : 200080d2
applying patch=0x1800c5d38 : f9473430
applying patch=0x18012e635 : 72643d6d64302064656275673d30783230313465202d76207764743d2d31202000
applying patch=0x1800c8a14 : 1f2003d5
main: Writing out patched file to work/iBEC.patched...
main: Quitting...
none
krnl
main: Starting...
main: Detected fat macho kernel
Kernel: Adding AMFI_get_out_of_my_way patch...
get_amfi_out_of_my_way_patch: Entering ...
get_amfi_out_of_my_way_patch: Kernel-7195 inputted
get_amfi_out_of_my_way_patch: Found entitlements too small str loc at 0x9015f7
get_amfi_out_of_my_way_patch: Found entitlements too small str ref at 0xfc6f30
get_amfi_out_of_my_way_patch: Patching AMFI at 0xfc1df8
main: Writing out patched file to work/kcache.patched...
main: Quitting...
krnl
dtre
rtsc
rdsk
error: allocate
error: Success
[-] An error occurred
rubens@rubensdev:~/palera1n$

Yeah because you aren't supposed to move the files. Have you recloned the repo?

what? do you mean copying ramdisk.tar.gz into the other folder in the root directory?

no, copy the "ramdisk" folder into the "other" folder, = /palera1n/other/ramdisk/other

That wouldn't make sense since gzip isn't even looking for that.

and now?

I told you to reclone the repo.

OK, I deleted everything and cloned it again...
it works!!!
in the end this happens:
100% [===================================================================================================>]
download succeeded
usb_timeout: 5
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID:8010 CPRV:11 CPFM:03 SCEP:01 BDID:0C ECID:000E415818EAED26 IBFL:3C SRTG:[iBoot-26<IP_ADDRESS>.33] PWND:[gaster]
Found the USB handle.
Now you can boot untrusted images.
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
Found the USB handle.
usb_timeout: 5
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID:8010 CPRV:11 CPFM:03 SCEP:01 BDID:0C ECID:000E415818EAED26 IBFL:3C SRTG:[iBoot-26<IP_ADDRESS>.33] PWND:[gaster]
Found the USB handle.
Now you can boot untrusted images.
[libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
Found the USB handle.
main: Starting...
iOS 14 iBoot detected!
getting get_debug_enabled_patch() patch
getting get_sigcheck_patch() patch
applying patch=0x1800c2d88 : 000080d2
applying patch=0x1800c2ddc : 000080d2
applying patch=0x1800c4758 : 200080d2
main: Writing out patched file to work/iBSS.patched...
main: Quitting...
none
main: Starting...
iOS 14 iBoot detected!
getting get_boot_arg_patch(rd=md0 debug=0x2014e -v wdt=-1  ) patch
getting get_debug_enabled_patch() patch
getting get_unlock_nvram_patch() patch
getting get_sigcheck_patch() patch
applying patch=0x1800c2d88 : 000080d2
applying patch=0x1800c2ddc : 000080d2
applying patch=0x1800b38c8 : 000080d2c0035fd6
applying patch=0x1800b3918 : 000080d2c0035fd6
applying patch=0x1800f0d28 : 000080d2c0035fd6
applying patch=0x1800c4758 : 200080d2
applying patch=0x1800c5d38 : f9473430
applying patch=0x18012e635 : 72643d6d64302064656275673d30783230313465202d76207764743d2d31202000
applying patch=0x1800c8a14 : 1f2003d5
main: Writing out patched file to work/iBEC.patched...
main: Quitting...
none
krnl
main: Starting...
main: Detected fat macho kernel
Kernel: Adding AMFI_get_out_of_my_way patch...
get_amfi_out_of_my_way_patch: Entering ...
get_amfi_out_of_my_way_patch: Kernel-7195 inputted
get_amfi_out_of_my_way_patch: Found entitlements too small str loc at 0x9015f7
get_amfi_out_of_my_way_patch: Found entitlements too small str ref at 0xfc6f30
get_amfi_out_of_my_way_patch: Patching AMFI at 0xfc1df8
main: Writing out patched file to work/kcache.patched...
main: Quitting...
krnl
dtre
rtsc
rdsk
error: allocate
error: Success
[-] An error occurred
rubens@rubensdev:~/palera1n$

What distro is this?

LINUX MINT LASTED

What distro is this?

can you show me the output of ls ramdisk/other

can you show me the output of ls ramdisk/other

rubens@rubensdev:~/palera1n$ ls ramdisk/other
bootlogo.im4p  ramdisk.tar
rubens@rubensdev:~/palera1n$

Can you reclone the repo and try again


any_of

Bytter ut ALL_OF med ANY_OF på følgende nøkler:
ID -> ANY_OF
INSTITUTION -> ANY_OF
PUBLISHER_ID -> ANY_OF
STATUS -> ANY_OF
USER -> ANY_OF
USER_AFFILIATION -> ANY_OF

I tillegg til
SCIENTIFIC_REPORT_PERIOD -> added
PUBLICATION_YEAR_SHOULD -> removed (not in use nor useful)

Originally, I raised a concern about the category key. It is not included here. And I am aware that instanceTypeShould works correctly it seems.

When I wrote the description, I overlooked instanceType  (alias -> category & type) , but it was also fixed


Count isn't returning right result when using deleted_at

Description
Count and Find returning different where when using deleted_at in model.
So I'm getting a wrong count when records deleted.
Is this a feature or bug? gorm version is 1.9.12.
func Find(ctx context.Context, db *gorm.DB) (int, error) {

  err := db.Count(&count).Error
  // SELECT count(*) FROM "product" join product_tenant
  // on product_tenant.product_id = product.id and product_tenant.tenant_id='abc'

  err = db.Find(out).Error
  // SELECT "product".* FROM "product" join product_tenant
  // on product_tenant.product_id = product.id and product_tenant.tenant_id='abc'
  // WHERE "product"."deleted_at" IS NULL ORDER BY id DESC LIMIT 5 OFFSET 0

}

sorry, we only accept v2 issues here, and only accept PR for V1

Thanks, switched to v2, got same result. I'll delete deleted_at.
On Tue, Aug 4, 2020 at 9:19 PM Jinzhu<EMAIL_ADDRESS>wrote:

sorry, we only accept v2 issues here, and only accept PR for V1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/go-gorm/gorm/issues/3233#issuecomment-668970768, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFQEDUICRI6LU4LR5N3ZZETR7DMV3ANCNFSM4PVBF56Q
.


Identity issuance crashes

Bug Description
When entering the external flow in the identity issuance, this error appears:

(Happens consistenly in @mh-concordium's mac)
Versions

1.4.0-beta.2
Mac (M1)

@mh-concordium does this also happen to you on the current release (1.3.1)?

I would have to try this specific release. I have used the previous one made for Delegation and that was working.

What version was that?

I believe that the failing one (this issue) was 1.4.0-beta.2.
Working one I have tested before were 1.4.0-beta.0 and 1.4.0-alpha.0.

A user have encountered this error on 1.3.1 (macOS)

Please supply steps/context to reproduce, or close if the issue is deemed to be resolved.

Similar issue after upgrading from DW 1.3.1 to 1.4.1 on macos (intel).

This happens due to the way windows are handled on macOS. If you close the main window (e.g. by pressing the X in the upper-left corner), then we have special macOS handling that keeps the application alive as this is the standard on macOS.  This is why we get an error when trying to register a duplicate handler, and it is also the issue behind the image shown in this issue as it refers to a destroyed object.

Verified on MacOS 1.4.2.
First I have successfully reproduced both issues on v. 1.4.1, afterwards I have installed 1.4.2 and all seemed ok. I didn't see warning reported by Daniel neither warning  I saw before.


UI updates

Brian, you're going to have to only add the parts that don't conflict with your latest changes.

Why don't you rebase and merge for me :)


Add info that python >= 3.5.3 is required

aiohttp has a requirement of >= 3.5.3, therefore we also do. We should update this in our docs, the README and on pypi

I would like to work on it. If the issue is open.

Not sure this is the best issue to work on for a community member -- you can check out issues labelled with help wanted or good first issue though, we'd love a community contribution from you!


indy-base pull access denied in run_demo faber

When trying to run the demo I get this error message:
git clone https://github.com/hyperledger/aries-cloudagent-python
cd aries-cloudagent-python/demo
LEDGER_URL=http://dev.greenlight.bcovrin.vonx.io ./run_demo faber
Preparing agent image...
Dockerfile.demo:1
1 | >>> FROM indy-base
2 |
3 |     ENV ENABLE_PTVSD 0
ERROR: failed to solve: indy-base: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

@usingtechnology — sorry to yank you on this, but can you look at this, immediately?
What has changed that has broken this?  Need to get this fixed ASAP.  I was able to replicate with the latest main.

ok, starting in on it.

The changes here https://github.com/hyperledger/aries-cloudagent-python/pull/2247 made the switch to using indy-base in teh docker file(s).

what is indy-base then? i immediately went to see what was published on docker and then here... nothing.

ok, i see that it is a prelim step in run_demo... looking into why it isn't working

https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/run_bdd#L129

The same build needs to be added here; https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/run_demo#L151-L152

thanks @WadeBarnes.

and have a look to see if there are any other locations using ../docker/Dockerfile.demo without building the indy-base image first.

that seems to be the only place (other than bdd) using Dockerfile.demo


Java Swing application crash due to EXCEPTION_ACCESS_VIOLATION in JavaThread "C2 CompilerThread0"

Please provide a brief summary of the bug
The application is crashing suddenly while running.
Attached there are the hs_err and replay files generated for two different crashes
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007fff5927f413, pid=184384, tid=80332
#
# JRE version: OpenJDK Runtime Environment Temurin-<IP_ADDRESS>+1 (<IP_ADDRESS>+1) (build <IP_ADDRESS>+1)
# Java VM: OpenJDK 64-Bit Server VM Temurin-<IP_ADDRESS>+1 (<IP_ADDRESS>+1, mixed mode, tiered, compressed oops, g1 gc, windows-amd64)
# Problematic frame:
# V  [jvm.dll+0x52f413]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
#

---------------  S U M M A R Y ------------

Command Line: -Djava.io.tmpdir=C:\Users\Brian Jepsen\.tora\com.tora.g2.launchpad\bootstrapper\installations\TORA OEMS PROD\tmp -Dsun.awt.nopixfmt=true -Dsun.java2d.d3d=false -Dsun.java2d.noddraw=true -XX:+UseG1GC -XX:+HeapDumpOnOutOfMemoryError -XX:+PrintCommandLineFlags -XX:+PrintFlagsFinal -XX:+ResizeTLAB -XX:+ScavengeBeforeFullGC -XX:+UseCompressedOops -XX:+UseNUMA -XX:+UseStringDeduplication -XX:+UseTLAB -XX:MaxGCPauseMillis=100 -XX:MaxMetaspaceSize=384M -XX:MaxNewSize=2G -XX:NewSize=2G -XX:StringDeduplicationAgeThreshold=6 -Xlog:gc*::time,uptime,level,tags: -Xlog:gc*::time,uptime,level,tags: -Xms8G -Xmx16G -Xss2m -verbose:gc C:\Users\Brian Jepsen\.tora\com.tora.g2.launchpad\bootstrapper\installations\TORA OEMS PROD\versions\11.25.0\launchers\e395cbe11d6dca29d43bc0b689f8ccddeadd2cfc77f4f585a161a47eaf3c3617.jar -cdist prod/config_gui/cdist_config_all.xml -forceCompression true -forceSSL true -language ENGLISH -launcher launchpad:bootstrapper -listenport 17700 -logmsg true -ping 3000 -title TTS -usageinfotoserver true -screenLocation 980,615

Host: Intel(R) Core(TM) i7-9700 CPU @ 3.00GHz, 8 cores, 63G,  Windows 11 , 64 bit Build 22621 (10.0.22621.1105)
Time: Mon Mar 13 10:20:29 2023 Eastern Daylight Time elapsed time: 1889.917883 seconds (0d 0h 31m 29s)

---------------  T H R E A D  ---------------

Current thread (0x000002236bf2b800):  JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=80332, stack(0x000000d476400000,0x000000d476500000)]

Current CompileTask:
C2:1889918 43789   !   4       javax.swing.plaf.basic.BasicSplitPaneUI$BasicHorizontalLayoutManager::layoutContainer (510 bytes)

Stack: [0x000000d476400000,0x000000d476500000],  sp=0x000000d4764fa8f0,  free space=1002k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [jvm.dll+0x52f413]
V  [jvm.dll+0x52f188]
V  [jvm.dll+0x52e4b0]
V  [jvm.dll+0x21118b]
V  [jvm.dll+0x20add4]
V  [jvm.dll+0x207f6b]
V  [jvm.dll+0x18a3a1]
V  [jvm.dll+0x2178e4]
V  [jvm.dll+0x215b2b]
V  [jvm.dll+0x76e610]
V  [jvm.dll+0x767544]
V  [jvm.dll+0x61dff5]
C  [ucrtbase.dll+0x29363]
C  [KERNEL32.dll+0x126bd]
C  [ntdll.dll+0x5dfb8]

siginfo: EXCEPTION_ACCESS_VIOLATION (0xc0000005), reading address 0x0000000000000008

hs_err_pid11208.log
replay_pid11208.log
hs_err_pid184384.log
replay_pid184384.log
Please provide steps to reproduce where possible
Unfortunately I am not able to reproduce the problem or to isolate the cause of it
Expected Results
application should run
Actual Results
application crashes
What Java Version are you using?
Temurin-<IP_ADDRESS>+1
What is your operating system and platform?
Windows 11
How did you install Java?
No response
Did it work before?
we did not see this error on oracle java 8

Did you test with the latest update version?
No response
Did you test with other Java versions?
No response
Relevant log output
No response

@adriantoganel Can you give the below a try?
This has all the hallmarks of a C2 bug. There's no test case, and 11.0.16 is old so I can't say if this was fixed already.
The submitter can try excluding that specific method from compilation along the lines of these docs
https://docs.oracle.com/en/java/javase/11/tools/java.html#GUID-3B1CE181-CD30-4178-9602-230B800D4FAE
the example syntax there is :-
-XX:CompileCommand=exclude,java.lang.String::indexOf
you'd need to apply that to the method cited in your case.
-XX:CompileCommand=exclude,java.swing.plaf.basic.BasicSplitPaneUI$BasicHorizontalLayoutManager::layoutContainer
I admit I am not sure if the "$" can be used literally .. or if it must escaped ..
If that fixes it, then it is even more likely to be a C2 bug.

Hi,
Thanks for input.
Will give it a try and try to provide you details if it is still happening

Short update.
So far it seems that setting jvm parameter
-XX:CompileCommand=exclude,java.swing.plaf.basic.BasicSplitPaneUI$BasicHorizontalLayoutManager::layoutContainer
is fixing the crash

@adriantoganel Can you try our 11.0.19 build? It may have been fixed as part of https://bugs.openjdk.org/browse/JDK-8285835

it was reproducible with Temurin-11.0.19+7
attached file
replay_pid9595.log
hs_err_pid9595.log

Updated the upstream ticket

Hi @karianna ,
Unfortunately setting jvm parameter:
-XX:CompileCommand=exclude,java.swing.plaf.basic.BasicSplitPaneUI$BasicHorizontalLayoutManager::layoutContainer
is not actually fixing our application, it's just making it crash from somewhere else. Our application crashed again in a similar manner and now the problem seems to be a different method from the same class:
---------------  T H R E A D  ---------------

Current thread (0x0000015ab9877000):  JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=22420, stack(0x000000286bf00000,0x000000286c000000)]

Current CompileTask:
C2:9699782 41389       4       javax.swing.plaf.basic.BasicSplitPaneUI$BasicHorizontalLayoutManager::resetToPreferredSizes (93 bytes)

We were using Temurin-11.0.18+10 on a Windows 11 machine. I'm attaching the hs_err and replay files generated.
Can you please explain us in more details what you mean by "(1) to reproduce with a debug build to check if we hit any (known) asserts". What is a debug build and what assertions should we look for?
Thank you,
Doru Mititean
replay_pid26524.log
hs_err_pid26524.log

Are you able to reproduce that crash with 11.0.19 and -XX:CompileCommand=exclude,java.swing.plaf.basic.BasicSplitPaneUI$BasicHorizontalLayoutManager::layoutContainer set?
If you send those logs in I can submit that to the Oracle folks upstream

Hi @karianna ,
We encountered crashes on version 11.0.19 even with the proposed setting.
This happens less often and is significantly harder for us to reproduce it.
And it is crashing in a different place:
`# A fatal error has been detected by the Java Runtime Environment:

EXCEPTION_PRIV_INSTRUCTION (0xc0000096) at pc=0x000001e3caa04b9f, pid=17204, tid=30896

JRE version: OpenJDK Runtime Environment Temurin-11.0.19+7 (11.0.19+7) (build 11.0.19+7)
`
I've attached 2 hs_err files.
Thank you,
Doru Mititean
hs_err_pid12984.log
hs_err_pid17204.log

https://bugs.openjdk.org/browse/JDK-8309309 - 11.0.20 will have the fix.


Questing about central database HA

Can I deploy HA central database instances to other machines instead of Kubernetes Master Nodes?

Not right now. However, I am going to submit a PR soon that will allow you to do what you are asking. See this document for more information:
https://docs.google.com/document/d/1khkgTNvjSEKgOSrzJOTtApL_mai-f3-pW1NHXOv5Dak/edit?usp=sharing

Thanks @girishmg , that would be great if it can be achived.
Actually I have tried to use external DB but meet errors: #625 .
And it still get same error even I moved the central database to Kubernetes Master nodes .

@girishmg, one more question: What is the role of the "--ha" option of ovnkube?
--ha                              HA option to reconstruct OVN database after failover
It's required when connect to a HA central database?

@ylhyh Ignore --ha option. It means something else.

is fixed by commit 81a3bdf7566abe57df7, so closing


update installation & guide - [merged]

In GitLab by @JackZxj on Apr 1, 2020, 07:35
Merges mydev -> dev

In GitLab by @wknet123 on Apr 1, 2020, 07:52
mentioned in commit d610b6361720556ef85b5468882164e9e53cf107

In GitLab by @wknet123 on Apr 1, 2020, 07:52
merged


Add ArgumentCustomization

We should add ArgumentCustomization to settings.
http://cakebuild.net/api/Cake.Core.Tooling/ToolSettings/50AAB3A8
I can make PR if you approve.

@AleksandarDev both Settings classes for Cake.Squirrel already derive from ToolSettings, so they should both already have access to the ArgumentCustomization method.  i.e. There should be no need for a PR, as it will already work.

@gep13 Great thanks.
Strange it is not shown in documentation... http://cakebuild.net/api/Cake.Squirrel/SquirrelSettings/

@AleksandarDev hmm, that is interesting!  As you can see, on otehr Settings classes it does appear:
http://cakebuild.net/api/Cake.Common.Tools.Chocolatey.Install/ChocolateyInstallSettings/
@daveaglick do you have any ideas as to why it isn't appearing here for the SquirrelSettings class?

@gep13 LOL, again.


Incorrect Value parameter description

The 'Value' parameter does not seem to be 'the output file' as the doc says but the actual value instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ef0ef75-5fa0-55e2-415b-e7b3d0c79a56
Version Independent ID: 5982f1be-d837-2296-9b12-0c353ff1a827
Content: XmlPoke Task - Visual Studio
Content Source: docs/msbuild/xmlpoke-task.md
Service: unspecified
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@rainersigwald Rainer, is the Value always an output file for XmlPoke, or could it be any ITaskItem?

Value should be something like The value to be inserted into the specified path.. Looks like a copy/paste error (in the doc comments in code) that propagated here.


fail to check data correctness in motion_representation

Thanks for you awesome work, I have encountered the problem when processing data

Seems the checked item is

I am wondering do you have any idea why it could happen. I follow the instruction, download SMPL+H Gdata from https://amass.is.tue.mpg.de/download.php.
Thanks

In motion_representation.ipynb, I have the same output warning/error as your notebook
Mine

Yours

I find even though the sum of abs difference is large, the maximum value is small. Is this acceptable?

For cal_mean_variance.ipynb

Are those errors in the normal range?
Thanks

Hi, it is kind of weird. The mean variance seem to be in the normal range. While the sum for reference1 and reference2 are kind of large. Could you visualize yours and the provided and see if they are visually different?

Hi， I got exactly the same sum results as you, did you solve it? @qsh-zh


RTMP not working

Helo
i try to play rtmp stream, but not display image, is this support rtmp streaming?

@azzahrah Yes.

Current version vlc not enable rtmc protocol?

@azzahrah, please provide the rtmp streaming url

Live Streaming
URL: rtmp://<IP_ADDRESS>/live/stream2
above url working using VLC Player, but problem with OTTLivePlayerVLC

VOD Streaming
VOD working fine

I have resolve this problem, by compile latest vlc-android, but sometime  when buffering event.getBuffering() not reach 100, so always waiting incoming packet...

@azzahrah ,all right,i have updated the vlc for android,thanks.


fix(theme): add missing aria-labels to the main and sidebar navs

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.

I did not add any tests.  The PR is too add an aria-label to the main/sidebar nav's.  I visually verified the arial-label was populating correctly on the sidebars and also noticed tests for the translate function located at packages/docusaurus/src/client/exports/__tests__/Translate.test.tsx

Motivation
Looking to make some open source contributions to this repository.  I noticed bug Issue #8308 and figured I would take a stab at it.
This PR adds an aria-label attribute to navigation bars found on https://docusaurus.io/docs allowing assistive technologies like screen readers to identify unique navigation elements.
Test Plan
verify the problem:

navigate to https://docusaurus.io/docs
open your browser developer tools and search for <nav> and verify the first and second nav elements do not contain an aria-label attribute.

verify the fix:

download this branch to your local
checkout this branch and run npm run start
once the application has loaded, navigate to http://localhost:3000/docs, and open your browser inspection tools
search the html for <nav>
verify the first nav element has an aria-label="Main"
verify the second nav element has an aria-label="Docs sidebar"

before:
main nav:

sidebar nav:

after:
main nav:

sidebar nav:

Test links

Deploy preview: https://deploy-preview-8366--docusaurus-2.netlify.app/
Related issues/PRs
#8308

Thanks, that's a good start 👍
As the unit test says, you have to run yarn workspace @docusaurus/theme-translations update once ids/labels are good, so that we can merge the PRs. This updates all our default translation files and make the test pass

Thanks for all the feedback and information.  I'll be working today to update the PR accordingly.

LGTM thanks
Fix https://github.com/facebook/docusaurus/issues/8308


need CI to bind relaton-render to relaton-bib

relaton-render consumes relaton-bib encodings of bibliographic objects. When relaton-bib is updated, if it changes the fields of objects, that can break relaton-render (and has).
I request that relaton-render CI jobs be triggered by updates to relaton-bib

@opoudjis should we check it on releases only or on master/main too?

On main and releases. Thanks!

@ronaldtse @opoudjis I think it's better to have this check on relaton-bib side, in those case developer will note potential issues on early stage https://github.com/relaton/relaton-bib/pull/73


Unclear what "pubspec reference with no conflicts" means on analysis tab

URL: https://pub.dartlang.org/packages/share (the analysis tab)
I see "pubspec reference with no conflicts", which I guess is good :) but unclear what this means.
If everything is "good", then I might suggest just saying "no issues detected", or, don't say anything at all.

The new pana emits better messages.


Moving to use parallel stream for some of the NN operations.

So this does require java 8 but I was seeing speedups of 4x+ which was convenient as I was working on my paper.

So the 4x speedup is very conservative. After more testing I realized it was just due to the number of cores on my machine. I later threw things on a big amazon instance with 36 cores and was seeing 32-35x speedups so it really does parallelize very nicely.

Note of caution: After talking with some other people, if you don't have alot of nodes in your network you may see slowdowns due to the overhead for trying to paralleize things. I have had several hundred nodes in several of my layers so things work out nicely but if you have small networks this may not help you.


Issue 152 smac2 validation

Addressing #6 and #152
Add argument --validation_format with choices from ['SMAC3', 'SMAC2', 'CSV', 'NONE'], defaulting to 'NONE'. So, if validated data should be used, it has to be explicitly specified in this argument. This enables reading validation data in a different format than the original data.
@mlindauer could you run this against your data to see if it works as expected? I cannot easily reproduce the data right now.

Codecov Report

Merging #153 into development will increase coverage by 4.15%.
The diff coverage is 79.78%.

@@               Coverage Diff               @@
##           development     #153      +/-   ##
===============================================
+ Coverage        45.22%   49.38%   +4.15%
===============================================
  Files               25       25
  Lines             2806     2916     +110
===============================================
+ Hits              1269     1440     +171
+ Misses            1537     1476      -61

Impacted Files
Coverage Δ

cave/cavefacade.py
33.74% <ø> (-5.37%)
:arrow_down:

cave/reader/csv2rh.py
59.05% <ø> (+37%)
:arrow_up:

cave/utils/io.py
63.26% <100%> (+19.51%)
:arrow_up:

cave/reader/smac3_reader.py
72.72% <25%> (-17.52%)
:arrow_down:

cave/reader/csv_reader.py
32.83% <42.85%> (+1.58%)
:arrow_up:

cave/cave_cli.py
83.8% <50%> (+0.15%)
:arrow_up:

cave/reader/base_reader.py
82.6% <66.66%> (-2.4%)
:arrow_down:

cave/reader/configurator_run.py
91.66% <87.5%> (+7.53%)
:arrow_up:

cave/reader/smac2_reader.py
92.96% <91.48%> (+69.63%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74de5b5...d449763. Read the comment docs.


gopls, internal/lsp: allow enabling gofumpt extra rules

Add gopls.formatting.gofumptExtraRules option to enable gofumpt's extra rules, equivalent to -extra on the CLI:
https://github.com/mvdan/gofumpt#extra-rules-behind--extra
Closes golang/go#56403

Closing as per discussion in golang/go#56403


Warning... Support for defaultProps will be removed firing  from NextUI components

Describe the bug
I'm getting a Warning: {component X} : Support for defaultProps will be removed pretty much everywhere in my app that I'm using NextUI:
Warning: Unknown: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at v.disableBaseline(webpack - internal:///(sc_client)/./node_modules/@nextui-org/react/cjs/theme/theme-provider.js:1:1972)
...
Warning: NextUI.Modal: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at b(webpack - internal:///(sc_client)/./node_modules/@nextui-org/react/cjs/modal/modal.js:1:1944)
...
Warning: c: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at c(webpack - internal:///(sc_client)/./node_modules/@nextui-org/react/cjs/collapse/collapse-group.js:1:1670)
...
Warning: h: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at h(webpack - internal:///(sc_client)/./node_modules/@nextui-org/react/cjs/collapse/collapse.js:1:2261)
...
Warning: s: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at s(webpack - internal:///(sc_client)/./node_modules/@nextui-org/react/cjs/tooltip/tooltip.js:1:1422)
...
Warning: m: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at m(webpack - internal:///(sc_client)/./node_modules/@nextui-org/react/cjs/tooltip/tooltip-content.js:1:1966)
...
Warning: Slider: Support for defaultProps will be removed from function components in a future major release.
    Use JavaScript default parameters instead.
    at Slider(webpack - internal:///(sc_client)/./node_modules/react-color/lib/components/slider/Slider.js:37:18)
...

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Use any of the errored nextUI components above with React 18, next.js 13
Expected behavior
Upgrade components to use JavaScript default parameters instead of defaultProps
Screenshots or Videos
No response
Operating System Version
macOS
Browser
Chrome

i used nextjs 13 with experimental appDir. i created components Wrapper where used .
and paste this in app>layout.tsx and get similarly Warning

+1

+1 any update on this?

+1

Is there any forecast for the launch of a new release?

+1

+1

+1

+1
I guess this should be fixed for compatibility with NextJS 13+

+1

any update y'all? Still happen in<EMAIL_ADDRESS>app/ router

+1

Clone new Version template to fix-> https://github.com/nextui-org/nextui/discussions/1155#discussioncomment-6197814

+1

+1

+1

+1

+1

Hey guys sorry for the delay please upgrade to V2.


ampersand(&) is HtmlEncoded. Is there way to opt out it

Hi Team,
Is there a way to opt out the HTMLEncode ampersand(&) in the sanitization
For example
Query&Query
will be sanitized to
Query&Query
I don't want to HTMLEncode it. Is there a way to do so?
Thanks
Daniel

No, we generate strictly valid markup.


[BUG] stqdm in for loop with the enumerate function

Describe the bug
stqdm doesn't work on a python loop that uses the enumerate function
To Reproduce
values = ["a", "b", "c"]
for count, value in stqdm(enumerate(values)):
    sleep(1)

doesn't work.
However
values = ["a", "b", "c"]
for value in stqdm(values)):
    sleep(1)

works normally

Also more broadly, even without the enumerate function, it doesn't work when it is iterating over a generator too

Hi @apolinario!
Thanks for the report and for the examples. Sorry for the late reply.

Also more broadly, even without the enumerate function, it doesn't work when the for loop is iterating over any generator it seems
To be exact, it's about iteratables without length.
When you pass your list into enumerate you lose the initial length of the object.

stqdm & tqdm have no way to know when your object will end and can not implement a progress bar.
In this situation, tqdm just return the number of iteration by seconds and the total number of iterations in text.
Like this :
0it [00:00, ?it/s]
1it [00:01,  1.00s/it]
2it [00:02,  1.00s/it]
3it [00:03,  1.00s/it]

I can and will probably implement this in the next release.
Is this what you will be expecting?
If you want the full progress bar tho, you have 2 solutions :

provide the expected number of iterations using total (tqdm API) :

from stqdm import stqdm
from time import sleep

values = ["a", "b", "c"]
for count, value in stqdm(enumerate(values), total=len(values)):
    sleep(1)

in your case,  add the enumerate outside stqdm call so that stqdm/tqdm can take the length of the original object as a default total

from stqdm import stqdm
from time import sleep

values = ["a", "b", "c"]
for count, value in enumerate(stqdm(values)):
    sleep(1)

In the incoming v0.0.5 version, there should be a fix that display the iteration speed without a real progress as there is no total or length.

v0.0.5 is live : https://github.com/Wirg/stqdm/releases/tag/v0.0.5 .
In this version, you will have a text displaying the number of iterations and the iterations speed (like with tqdm).
See example here : https://github.com/Wirg/stqdm/blob/096605ed7b619affd0cabaaf237b98ee6e96e981/examples/stqdm_no_total_no_length.py  .
You won't have a progress bar as there is no knowledge of the length of the iteration. It's often better to provide total=expected_length to the stqdm.__init__ .


Tibialyzer beta v1.4.1 and Tibia 11 - ammunition

Well I don't know if this place is good for this, I just want to let you know that Tibialyzer 1.4.1 doesn't count used ammunition in Tibia 11 Beta (at least it is not shown under "Used items" in summary). Cheers :)

It was with the same problem has already been solved?

Here too. On tibia 11 the ammunition doesn't count on summary.

Yah I would like a solution for this issue

I can confirm that this is not working on 1.4.2 and tibia 11


v6: Remove executeWithLimitedPermission option from spo list list. Closes #3408

Closes #3408
Remove executeWithLimitedPermission option from spo list list command.

This one was based on the main branch, I rebased it on v6.

merged manually


CQC directory archive timeseries

Dataset, R function, and vignette for a dataset containing a year's worth of the archive of CQC location ratings. Contains data on providers, locations, and a column pub_date  to allow users to disambiguate which data was published when.

@chrismainey this could be a dataset that is similar to things in {keras} where it downloads on request, rather than bundling in the package (e.g. https://keras.rstudio.com/reference/dataset_mnist.html). This could cut down on the package size (staying within the CRAN constraints). Suggest we would have functions dataset_* to download and process the datasets. These would need to not be tested (or, we would need to mock) in order to pass CRAN tests reliably. Doing this we could maintain the vignette but remove the .Rda file. Big downside to this approach is maintaining over time if CQC were to move the files. We could rehost the file as it is OGLv3.

We could keep it hosted in the repo. Then exclude from package build using .Rbuildignore file, like you suggest. Function would then download from the repo. @MHWauben would you be happy doing it that way, or would you like us to help?

@MHWauben Still keen to include the data if you want to pick it up again.  We just need to workout the size thing, and more than happy to help. PR closed as I renamed master to main, but by deleted master.  New PR to main would be best.  Do let us know if you'd like a hand.

@all-contributors please add @MHWauben for data
@all-contributors please add @MHWauben for documentation
Although this data wasn't added to the package I'll look into adding the vignette into the NHS-R Community website blog.


Adding event listener on

Is there any way to add an event listener like click or hover on the <SortableElement />?
This doesn't seem to work.
SortableElement({ value, reOrder }) => (

 /* event here */}>Click me

)

It works on buttons only.
SortableElement({ value, reOrder }) => (

     <button onClick={() => /* event here */}>Click me</button>

)

I can't even add an onClick handler for buttons

My problem with buttons earlier was just the z-index. It might be your problem as wel.. @delgiudices

https://github.com/clauderic/react-sortable-hoc#click-events-being-swallowed

@therealedsheenan , this issue could be closed ?

Hi. onClick works in my code. But every time when I click on one of the elements of SortableContainer, it calls onClick handler function for all elements. Can someone help?


Bug 1975432: Resolve InstallPlanStepAppliedWithWarnings alert after some time.

There is an error in the alert expression that causes the alert to
persist indefinitely. The intention of the alert was to fire for
several minutes to inform the administration of the warnings. The
appropriate response to the alert is to stop installing problematic
bundles going forward.

/bugzilla refresh

approved, I think shipping 4.8 without this will lead to a higher case load (the alerts may be alarming / confusing without this change, and they're likely to be triggered)

/lgtm

/override ci/prow/e2e-gcp
e2e-gcp is only failing due to a single known issue tracked here: https://bugzilla.redhat.com/show_bug.cgi?id=1975283 (a test that should be skipped is not)

/retest

/bugzilla refresh

/bugzilla refresh

/override ci/prow/e2e-gcp
e2e-gcp is only failing due to a single known issue tracked here: https://bugzilla.redhat.com/show_bug.cgi?id=1975283 (a test that should be skipped is not)


SWITCHYARD-2908 ClassNotFoundException: javax.jws.WebService from Mod…

…ule org.apache.camel.cxf:main

Can one of the admins verify this patch?

ok to test


Always rerender annotation selector when opening a new image

Codecov Report

Merging #313 into master will increase coverage by 0.18%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   44.96%   45.15%   +0.18%
==========================================
  Files          99       99
  Lines        2693     2695       +2
  Branches       98       98
==========================================
+ Hits         1211     1217       +6
+ Misses       1482     1478       -4

Impacted Files
Coverage Δ

web_client/panels/AnnotationSelector.js
86.66% <100%> (+0.62%)
:arrow_up:

web_client/views/body/ImageView.js
67.52% <0%> (+3.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a512fd8...625c3c3. Read the comment docs.


Skip, Take and Select do not work as expected

Steps to reproduce
Ideally include a complete code listing that we can run to reproduce the issue.
Alternatively, you can provide a project/solution that we can run.
The issue
Describe what is not working as expected.
If you are seeing an exception, include the full exceptions details (message and stack trace).
Exception message:
Stack trace:

Further technical details
EF Core version: (found in project.json or packages.config)
Operating system:
Visual Studio version: (e.g. VS 2013 or n/a)
Other details about my project setup:

Misclick.


Adapt deploy to vespa cloud documentation notebook to run without errors in the CI pipeline

pyvespa documentation page for Vespa Cloud deployment is currently not functional from an integration test point of view. Update the notebook to make it functional.
Take #343 into account as it simplified certificate and key management.

@kkraune suggested looking into the possibility of using vector-search app as the example in the deploy to cloud documentation.

This integration https://github.com/vespa-engine/pyvespa/blob/master/vespa/test_integration_vespa_cloud_vector_search.py does exactly this. Resolving.


Animation Issues

Hi!
The game is able to build and is completely playable but skeletal animations are not working at all. For exporting the fbx Blender 2.93.12 is used and the skelatool version is the one included in this repo. Any obvious things I am doing wrong?
Maybe worth noting that the make command will run into errors during compilation because conveyor.h, table.h and clips.h are not beeing built automatically and have to be built seperately with make but maybe that is just a different issue

I can't say for sure what is wrong. Do the animations simply not play and the objects are stuck in the same pose the entire time?
The compilation errors are probably an issue with the Makefile but probably not related the the animations not working.


add source type field in all odo list variants ( json and standard )

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind feature

Documentation changes: Please include [skip ci] in your commit message as well
/kind documentation
[skip ci]

What does does this PR do / why we need it:
adds sourceType in json output and standard output for odo list.
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/2730
How to test changes / Special notes to the reviewer:
Create a component and before pushing
odo list
odo list --all-apps
odo list --path .
should give SOURCETYPE column and similarly -o json variants should give json output.
Now push the component and try the same.
when a component is not pushed the code path is different as the component is not present on the cluster and hence the reviewer should check if sourceType shows in that case as well or not.

/approve

/hold
the poor bot is trying to restart the tests that are clearly broken :-/

/hold cancel

/lgtm

/retest

/retest


Migrate to OLS4

OLS3 will be off in October 2023 - need to migrate Admin UI to OLS 4: https://www.ebi.ac.uk/ols4

@zperova done


Run test suites in azure ci

This is the more promising option for running tests in macos and windows (thanks god and @alanz at least we have the circle ci for linux)

[X] Linux jobs: all test suites are green

[ ] Windows jobs

[ ] unit-test suite:

Failing tests for CabalHelper using stack-8.6.4.yaml: openend https://github.com/DanielG/cabal-helper/issues/91

[ ] dispatcher-test: flaky, it fails sometimes for all ghcs always with same errors (see below)
[X] plugin-dispatcher: green
[ ] wrapper-test: failing
[ ] functional-test: one failing test for ghc-8.6.4 (Hover.hover works)

[ ] macos jobs

[X] ghc-8.6.*: all test suites green
ghc-8.4.*:

[ ] test hangs after error in dispatcher test (see below)
[ ]  functional test cant be run (func-test: fd:28: hPutBuf: resource vanished (Broken pipe))

Some of these issues should be fixed by #1126, so maybe we can try again to enable azure-ci testing, once that pr has landed.

I am just running the pr in azure with tests enabled: https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=212

Hi, after applying the workaround to avoid the errors compiling cabal-helper at runtime the number of failed tests has decreased sensibly:

master: https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=219

Quite builds have only errors related with liquid haskell and even a linux build succeded: https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=219&jobId=86dfe75d-acf3-5a7d-391c-10fa0ecb27bb

The functional tests suite with the hie-bios branch have more fails:  https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=221. Most of them are like:
haskell-ide-engine>   1) Completion.completions works
haskell-ide-engine>        uncaught exception: ConduitParserException
haskell-ide-engine>        NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "Logging notification" (BothFailed (Unexpected "ConduitParser.empty") (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "Logging notification" (BothFailed (Unexpected "ConduitParser.empty") (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "NotificationMessage ServerMethod PublishDiagnosticsParams" (NamedParserException "Logging notification" (BothFailed (Unexpected "ConduitParser.empty") (Unexpected "ConduitParser.empty")))))))))))))))
haskell-ide-engine>
haskell-ide-engine>   To rerun use: --match "/Completion/completions/works/"

I've rerun tests in azure with actual master: https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=334&view=results

The unit-test suite passes
The dispatcher and plugin-dispatcher suites pass
The functional-test fails due to different behaviour of diagnostics received
The wrapper-test fails due to different output of the stack command

This would be great! maybe we should start poking members of the haskell organizations to enable azure for this project?

Absolutly, do we know who has the permissions to do it, @alanz, @bubba?

I think the haskell committee has control of this. Not sure who specifically.

Ok, maybe we can wait to have the azure setup complete, including green test suites and deploy

Update:

[X] Linux jobs: all test suites are green

[ ] Windows jobs

[X] unit-test suite: green
[ ] dispatcher-test: flaky, it fails sometimes for all ghcs always with same errors (see below)
[X] plugin-dispatcher: green
[ ] wrapper-test: failing
[ ] functional-test: one failing test

[ ] macos jobs

[X] ghc-8.6.*: all test suites green
[ ] ghc-8.4.*: test hangs after error in dispatcher test (see below)

Executions:

https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=344
https://dev.azure.com/jneira/haskell-ide-engine/_build/results?buildId=411

Windows dispatcher-test errors:
Failures:

  test\dispatcher\Main.hs:157:5:
  1) functional dispatch defers responses until module is loaded
       uncaught exception: ErrorCall
       Prelude.head: empty list

  To rerun use: --match "/functional dispatch/defers responses until module is loaded/"

  test\dispatcher\Main.hs:205:7:
  2) functional dispatch instantly responds to deferred requests if cache is available
       expected: ("references",Just [DocumentHighlight {_range = Range {_start = Position {_line = 7, _character = 0}, _end = Position {_line = 7, _character = 2}}, _kind = Just HkWrite},DocumentHighlight {_range = Range {_start = Position {_line = 7, _character = 0}, _end = Position {_line = 7, _character = 2}}, _kind = Just HkWrite},DocumentHighlight {_range = Range {_start = Position {_line = 5, _character = 6}, _end = Position {_line = 5, _character = 8}}, _kind = Just HkRead},DocumentHighlight {_range = Range {_start = Position {_line = 7, _character = 0}, _end = Position {_line = 7, _character = 2}}, _kind = Just HkWrite},DocumentHighlight {_range = Range {_start = Position {_line = 7, _character = 0}, _end = Position {_line = 7, _character = 2}}, _kind = Just HkWrite},DocumentHighlight {_range = Range {_start = Position {_line = 5, _character = 6}, _end = Position {_line = 5, _character = 8}}, _kind = Just HkRead}])
        but got: ("req2",Nothing)

  To rerun use: --match "/functional dispatch/instantly responds to deferred requests if cache is available/"

  test\dispatcher\Main.hs:257:7:
  3) functional dispatch returns hints as diagnostics
       expected: ("r5",Just (PublishDiagnosticsParams {_uri = Uri {getUri = "file:///D:/a/1/s/test/testdata/FuncTest.hs"}, _diagnostics = List [Diagnostic {_range = Range {_start = Position {_line = 9, _character = 6}, _end = Position {_line = 10, _character = 18}}, _severity = Just DsInfo, _code = Just (StringValue "Redundant do"), _source = Just "hlint", _message = "Redundant do\nFound:\n  do putStrLn \"hello\"\nWhy not:\n  putStrLn \"hello\"\n", _relatedInformation = Nothing}]}))
        but got: ("references",Nothing)

  To rerun use: --match "/functional dispatch/returns hints as diagnostics/"

  test\dispatcher\Main.hs:297:7:
  4) functional dispatch instantly responds to failed modules with no cache with the default
       expected: ("req7",Just [])
        but got: ("r5",Nothing)

  To rerun use: --match "/functional dispatch/instantly responds to failed modules with no cache with the default/"

macos error in dispatcher-test for ghc-8.4
haskell-ide-engine> dispatcher-test:
haskell-ide-engine> lookupSymbol failed in relocateSection (RELOC_GOT)
haskell-ide-engine> /Users/runner/runners/2.163.1/work/1/s/.stack/programs/x86_64-osx/ghc-8.4.3/lib/ghc-8.4.3/integer-gmp-<IP_ADDRESS>/HSinteger-gmp-<IP_ADDRESS>.o: unknown symbol `___gmp_rands'

After #1601 there are a new failing unit test in windows:

Windows-Stack-8.6.5

Failures:

  test/unit\\ApplyRefactPluginSpec.hs:42:5:
  1) ApplyRefactPlugin, apply-refact plugin, apply-refact plugin commands, applies one hint only
       uncaught exception: GhcException
       unit-test.exe: could not detect mingw toolchain

  To rerun use: --match "/ApplyRefactPlugin/apply-refact plugin/apply-refact plugin commands/applies one hint only/"

Windows-Cabal-8.4.4

Failures:

  test/unit\\ApplyRefactPluginSpec.hs:134:5:
  1) ApplyRefactPlugin, apply-refact plugin, apply-refact plugin commands, respects hlint config files in project root dir
       uncaught exception: IOException of type NoSuchThing
       .\settings: openFile: does not exist (No such file or directory)

  To rerun use: --match "/ApplyRefactPlugin/apply-refact plugin/apply-refact plugin commands/respects hlint config files in project root dir/"


fix(abort): fixing the result updation for abort

Signed-off-by: shubhamchaudhary<EMAIL_ADDRESS>

Name:         engine-pod-cpu-hog
Namespace:    shubham
Labels:       name=engine-pod-cpu-hog
Annotations:  <none>
API Version:  litmuschaos.io/v1alpha1
Kind:         ChaosResult
Metadata:
  Creation Timestamp:  2020-10-15T08:27:47Z
  Generation:          3
  Resource Version:    45425
  Self Link:           /apis/litmuschaos.io/v1alpha1/namespaces/shubham/chaosresults/engine-pod-cpu-hog
  UID:                 596720f4-10e9-43c4-9a66-56a31b2ad342
Spec:
  Engine:      engine
  Experiment:  pod-cpu-hog
Status:
  Experimentstatus:
    Fail Step:  CPU hog Chaos injection stopped!
    Phase:      Completed
    Verdict:    Stopped
Events:
  Type     Reason   Age   From                      Message
  ----     ------   ----  ----                      -------
  Normal   Awaited  13s   pod-cpu-hog-jtbp3n-q5npw  experiment: pod-cpu-hog, Result: Awaited
  Warning  Stopped  7s    pod-cpu-hog-jtbp3n-q5npw  pod-cpu-hog experiment has been aborted


Search within subdirectories

Maybe my lack of Python knowledge letting me down here, but how do I recursively search through child folders?
face_recognition ./pictures_of_people_i_know/ ./unknown_pictures/

I'd like to search within subdirectories of ./unknown_pictures/.

The current code for the command-line utility doesn't search within nested folders, but it would be fairly easy to make it do that. When I have some free time, I can make that change.

It would be a great if it could be added.

Thanks for the reminder. I can take a look at it.

Hi, is there any update on this? I'd like to run the face_recognition against a massive folder heirarchy containing  a massive amount of images. Right now it is not feasible to have all the images in a single folder. Also, it would be nice to be able to put the known_images in subfolders, so there can be multiple images of each known person to improve accuracy. For example:
/root/known_images
/root/known_images/Angela
/root/known_images/Angela/1.jpg
/root/known_images/Angela/2.jpg
/root/known_images/Angela/3.jpg
/root/known_images/Robert
/root/known_images/Robert/1.jpg
/root/known_images/Robert/2.jpg
etc
Thanks for the great program!

Any update?


Remaining parity features for Runner

[ ] Deep integrations: Vercel/deno (not priority)
[ ] Terminal dimensions (not priority)

This is now contingent on runme/#168, which implements PTY sizing, and #267 , which fixes the deno/vercel integrations, but needs PTY sizing for the deployctl script to work with interactive mode.
PTY sizing currently uses 80 columns as a default so integration client-side is not strictly necessary, but would be nice anyways.


Fix bug with punctuation in canonical display names

Needs https://github.com/kbase/jars/pull/70 for build to pass.