[Bug] Description of background Policy Setting is Misleading

Page link
https://kyverno.io/docs/writing-policies/policy-settings/#:~:text=background%3A controls if rules are applied to existing resources during a background scan. Defaults to “true”
Description

background: controls if rules are applied to existing resources during a background scan. Defaults to “true”.

I think there are 2 levels of issues/solutions here either:

Semantically the word "rules" is too generic and should read "validation rules" and the word "applied" is just incorrect according to the below documentation. Doing some word replacement here might be the quick win.
The entire background description should be rewritten/updated to better match what seems to be the current source of truth (ie. the doc below).

https://kyverno.io/docs/writing-policies/background/
Expected behavior
This is answered in the description.
Slack discussion
https://kubernetes.slack.com/archives/CLGR9BJU9/p1612459243238900

Background also applies to verifyImages rules and not just validation rules. The word "applies" seems accurate to me. The below documentation link you shared states this in the opening paragraph:

The application of policies to existing resources is referred to as background scanning and is enabled by default unless background is set to false in a policy like shown below in the snippet.

We can update the definition of the background field on this page if that makes it clearer.

We can update the definition of the background field on this page if that makes it clearer.

@chipzoller yes, that is my proposal. I am just not the best word smith. Just the code monkey trying to use the docs :) Thanks!

Hi @chipzoller  , I would like to work on this issue can you please assign this to me


[Enhancement] add nap_sleep() to handle sleep a large portion of time

respect AWS_EC2_METADATA_DISABLED if already set in env
BE binary can stop with 10 seconds with this change nap_sleep() change and also AWS_EC2_METADATA_DISABLED=true in non-ec2 env

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[X] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[X] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[X] I have checked the version labels which the pr will be auto-backported to the target branch

[X] 3.1
[X] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

manual backport to branch-3.1 at https://github.com/StarRocks/starrocks/pull/29773

manual backport to branch-3.0 at https://github.com/StarRocks/starrocks/pull/29775


Ml 277 LDA improvements including topic display and topic assignments to docs

@richardkchapman  @ghalliday  Ready for merge

There's a typo (documnet) in the commit message. Also the merge of master should not really be in the branch (rebase is preferred...) but I can fix that during merge.
Is there anyone who is familiar with LDA to review this change?

Zack Bennett in L&P should be familiar enough with the details and can review it Wednesday or Thursday.

I've desk reviewed John's merge request, and tested the inference and topical term output.  Everything looks in order.  Thanks.
@richardkchapman


[Migration] Support same client Id for applications over different tenants

Describe the issue:
Currently in IS client ID is considered to be unique across the server and as a result the same client ID cannot be used in two different tenants. This capability is provided with https://github.com/wso2/product-is/issues/16370 improvement. A migration client should be provided to migrate older users to the new version.
Related issue

https://github.com/wso2/product-is/issues/16370

Details and steps should be added to the migration docs.

Prerequisites on configs (tenant qualified urls and tenanted sessions)
DB constraint update
Schema migrator configs -
version: "7.0.0"
migratorConfigs:
 -
   name: "ClientIdTenantUnificationMigrator"
   order: 1
   parameters:
     location: "step1"
     schema: "identity"

We need to do this once the migration docs are added

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


OpenSSL STATIC for WinCE

I would like to ask if it is possible to build OpenSSL Statically for WINCE.
When I add no-shared it does not work the compilation process.
perl Configure no-idea no-mdc2 no-rc5 no-ssl3 no-weak-ssl-ciphers no-async no-engine no-shared  VC-CE
Then nmake fails
For DLL i used to call: nmake build_generated libcrypto-1_1.dll libssl-1_1.dll
Thanks

What's the failure reported?

If you do not need the openssl application but just the libraries, you can try nmake build_libs

If you do not need the openssl application but just the libraries, you can try nmake build_libs

Thank you very much.
I 've successfully got 2 .lib STATIC
I got these warning, do they affect performance?

But unfortunately the .exe on WINCE 6.0 machine still does not work when i use OpenSSL function

I got these warning, do they affect performance?

In case of the ecp object files this means the optimized ECC implementation for NIST curves is not being built. Possibly no assembler?
Others are not relevant.

But unfortunately the .exe on WINCE 6.0 machine still does not work when i use OpenSSL function

What exe are you talking about? Some application using openssl? What "does not work" exactly means? Unfortunately we are no WINCE experts, I'd suggest trying to find some forum of WINCE developers to seek help.

What exe are you talking about? Some application using openssl? What "does not work" exactly means? Unfortunately we are no WINCE experts, I'd suggest trying to find some forum of WINCE developers to seek help.

Yes, When I use OpenSSL function, the project on VS2005 BUILD successfully, however when i use .exe on WINCE 6.0 it does not show up. Then when I remove from code the OpenSSL function used, the app shows up. So strange.

Marking as inactive, will be closed at the end of 3.4 dev cycle, barring further input


Add Read Account Info Example

Hi Compound Team.
Reading the account info seems to me to be pretty frequently used. Therefore I added this example.
Feedback = Welcome.

Hello @michael-spengler. Thank you for taking the time to make a pull request. There is an example that is quite similar to this one in the readme already. Although there is not a contribution guide for this project at this time, there will be in the future. Pull requests should be made for contributions that are constructive and relevant. I invite you to join the developer community discussion in the Compound Discord https://compound.finance/discord. It is a place where you can discuss constructive changes to repositories like this one.

Hello @michael-spengler. Thank you for taking the time to make a pull request. There is an example that is quite similar to this one in the readme already. Although there is not a contribution guide for this project at this time, there will be in the future. Pull requests should be made for contributions that are constructive and relevant. I invite you to join the developer community discussion in the Compound Discord https://compound.finance/discord. It is a place where you can discuss constructive changes to repositories like this one.


108 - BMI Calculator

#425
Mobile Responsive and UI user friendly

https://bmi-calc-sandy.vercel.app/      you can check here

@StillAbeginnerr
Hey buudy, Please update your folder number to 108 to 109 as I have been created a PR with the reference of 108.
Thanks

@Kumar-Ankit56 ok bhai


FS Fit & Finish Testing: Issue 29

From @AnnaK111 on October 12, 2018 18:5
Submitter:  Jessica Hartono
Description: The phone number area is only meant for 1 phone number.
Browser: Google Chrome Version 68.0.3440.106
Repro steps:  Topics & Resources page

Copied from original issue: Microsoft/Access2Justice#581

What we have to implement here: a validator to allow only 1 number of a form which allows a lot of entered one by one?

@KellyeDC - This is not a development issue as written.  I'm marking as on hold as I don't believe it's a high priority issue to worry about for pilot.


PixyCam2 issues

Hi -
We decided to give PixyCam2 a shot, but we're getting an unknown timeout error sending most commands and reading responses. Any thoughts on what could cause that or the best way to test to make sure it's not a wiring or setup problem?

Would you give me more info to your issues? If you can share your code, I can take a look at it. What kind of timeout error are you seeing? Is it an error from our TRC Library or is it an error from FTC SDK? There are a lot of debugging tool built-in to our library, trace logging and such. If you can identify who's throwing the error, we can use appropriate tools to find out what's wrong.
BTW, are you using our TRC library whole or are you extracting part of it? Did you make any modification to it? All these questions are important to identifying the issue.

Hi - We've copied the whole TRC and FTC library, but are only using this feature. We have debug on, and the trace shows the error in the stack all the way up to the LynxCommand. I've come to believe that it's a problem related to this: https://github.com/ftctechnh/ftc_app/issues/577
The read and write methods in FTCPixyCam2 are both using the I2CDevice.syncread() and .syncwrite(), which require a register. The code FTCPixyCam2 code sends -1 as the register to I2CDevice, which appears to then call a command from the TRCSerialBusDevice? It's unclear what happens from there. Does that work for the PixyCam2, which doesn't use registers at all?
PixyCam1 didn't have these issues, as you put it into Lego I2C mode and it would read register 0x51, as far as I can tell.
We'll play with it more, and turn on more debugging.

Since you are debugging the software, I am assuming the hardware and the wiring are fine. It sounds like you did your research and is on the right path. Yes, an I2C device have a block of registers. A lot of these devices don't require "register address" because it will just read or write the whole block of registers. By specifying -1, it tells TRC library there is no need for register address. TrcSerialBusDevice is a class providing generic support for any serial bus devices including "COM port" (i.e. UART). Some devices would want to have a first-in-first-out request queue, so requiring a request queue is optional. As you can see in FtcPixyCam2's constructor, it created the FtcI2cDevice with "useRequestQueue" parameter set to false. So it will not use request queue which means all reads and writes will be handled synchronously natively (i.e. I2cDeviceSynch). So far, you have it correctly interpreted. Let me know if you need help in going over the trace log.

Thanks. The team met tonight. We also made a "raw" teleop that simply does the send and receive (but using the FtcI2cDevice). Send works fine. The trace log shows that the problem is exactly where I thought - the readData (with -1 as the register) then goes up the inheritance chain to I2cSynchDevice, on to LynxI2cSynch, etc. and we get a timeout. So, the question is whether the -1 (which apparently gets converted to a 0 by the code) in I2cSynchDevice is going to do the read/write without a register address. When we run getblocks, we never get data. When we send get blocks in via the raw code, we seem to get a short array (as far as our telemetry output shows), but I haven't looked carefully at that yet. If Pixy2 has no registers, should the request queue be in play?

Like I said, we haven't use PixyCam for a while now so I don't know what's the latest changes in both PixyCam2 firmware as well as the FTC SDK I2c support. If I remember correctly, at the time we wrote our library, PixyCam2 did not support register reads, so the data block was just a data stream. At that time, I remember FTC SDK requires register address, so by setting register address to 0, it effectively pretends first byte of the block is reg addr 0 and second byte is reg addr 1 ... etc. Since PixyCam2 ignores the register address, it would just read the block in sequence. That's why we mapped -1 to 0 (-1 indicates we don't need register address for the upper layers, then when we get to the lower level where we require a reg address, we change it to 0). I think FTC SDK I2c support has been rewritten in the last two seasons. Something must have changed that it no longer likes what we did. I have PixyCam2 in the shop but since the pandemic, I haven't visited the shop that much. It just happens that I will be going to the shop tomorrow. I will try to get a PixyCam2 home and try this myself. I probably no longer have the wiring harness to connect the pixy cam to the Control/Expansion Hub. So I may have to make one. It could be a while before I can debug it because I am dealing with a furnace malfunction as well as a flooding. Hopefully, you may make progress faster than I can. If you have any question on the trace log, send me a copy and I can look at it with you.
BTW, I do recall there were issues with PixyCam firmware about Pixy LEGO firmware vs non-LEGO firmware but I don't remember if you can flash the PixyCam2 with LEGO firmware that supports register address. I vaguely remember we couldn't.

OK, thank you. For the followup. I think the register 0 thing is not working. We tested it last night, and we tested it was a raw FtcI2cDevice that did nothing but connect and send and receive. But we'll keep debugging and testing - if you happen to find something that works, I'm sure more than just we will be appreciative.
I do agree that I think the Lego firmware is not allow, though I think the Lego I2c mode may work, and there is PixyCam1 emulation. Worst case, we may revert to that, but we'd like to make this work for this and other seasons.
From: Titan Robotics Club<EMAIL_ADDRESS>Sent: Tuesday, December 22, 2020 6:05 AM
To: trc492/FtcSamples<EMAIL_ADDRESS>Cc: Team14423<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [trc492/FtcSamples] PixyCam2 issues (#6)
Like I said, we haven't use PixyCam for a while now so I don't know what's the latest changes in both PixyCam2 firmware as well as the FTC SDK I2c support. If I remember correctly, at the time we wrote our library, PixyCam2 did not support register reads, so the data block was just a data stream. At that time, I remember FTC SDK requires register address, so by setting register address to 0, it effectively pretends first byte of the block is reg addr 0 and second byte is reg addr 1 ... etc. Since PixyCam2 ignores the register address, it would just read the block in sequence. That's why we mapped -1 to 0 (-1 indicates we don't need register address for the upper layers, then when we get to the lower level where we require a reg address, we change it to 0). I think FTC SDK I2c support has been rewritten in the last two seasons. Something must have changed that it no longer likes what we did. I have PixyCam2 in the shop but since the pandemic, I haven't visited the shop that much. It just happens that I will be going to the shop tomorrow. I will try to get a PixyCam2 home and try this myself. I probably no longer have the wiring harness to connect the pixy cam to the Control/Expansion Hub. So I may have to make one. It could be a while before I can debug it because I am dealing with a furnace malfunction as well as a flooding. Hopefully, you may make progress faster than I can. If you have any question on the trace log, send me a copy and I can look at it with you.
BTW, I do recall there were issues with PixyCam firmware about Pixy LEGO firmware vs non-LEGO firmware but I don't remember if you can flash the PixyCam2 with LEGO firmware that supports register address. I vaguely remember we couldn't.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftrc492%2FFtcSamples%2Fissues%2F6%23issuecomment-749485057&data=04|01|risch%40law.villanova.edu|45a395a0f7ec4c21a34808d8a6697884|765a8de5cf9444f09cafae5bf8cfa366|0|0|637442319221027162|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=T7i61rh%2Fu0SxUOOP1h9stR%2FVdh5ERzajGmApDjQQPmU%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOYGF27FWMLQTDUBZN6X2BLSWB4OTANCNFSM4VC2TLIQ&data=04|01|risch%40law.villanova.edu|45a395a0f7ec4c21a34808d8a6697884|765a8de5cf9444f09cafae5bf8cfa366|0|0|637442319221037118|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=RH9je580b18cRpBI3qkLB7aXpNg5aX3NeCOBq42AX84%3D&reserved=0.

So are you saying you have PixyCam1 and our library still works with PixyCam1? Just trying to narrow down the problem. If PixyCam1 still works using our library, it means all the low level communication still works. If it's true that low level communication is broken, I would be surprise PixyCam1 would work because they shared the same low level communication layers. The main difference between PixyCam1 and PixyCam2 is the high level protocol (i.e. the block structure differences).

We have the Pixy2. It has a Pixy1 emulation mode. But your Pixy1 code does not use the same reading method as the Pixy 2 code. The Pixy1 code implements asyncReadData(). The code is as follows:
`public void asyncReadData(RequestId requestId, int length)
{
final String funcName = "asyncReadData";
    if (debugEnabled)
    {
        dbgTrace.traceEnter(funcName, TrcDbgTrace.TraceLevel.API, "Id=%s,length=%d",
                requestId != null? requestId: "null", length);
    }

    pixyCam.asyncRead(requestId, length, null, this::requestHandler);

    if (debugEnabled)
    {
        dbgTrace.traceExit(funcName, TrcDbgTrace.TraceLevel.API);
    }
}   //asyncReadData`

I can trace the back to TrcSerialBus (through FTCI2cDevice):
` public void asyncRead(
Object requestId, int address, int length, boolean repeat, TrcEvent completionEvent,
TrcNotifier.Receiver completionHandler)
{
final String funcName = "asyncRead";
    if (debugEnabled)
    {
        dbgTrace.traceEnter(funcName, TrcDbgTrace.TraceLevel.API, "Id=%s,addr=%d,len=%d,repeat=%s,event=%s",
            requestId == null? "null": requestId, address, length, repeat, completionEvent);
    }

    if (requestQueue != null)
    {
        Request request = new Request(requestId, true, address, null, length, completionEvent, completionHandler);
        requestQueue.add(request, this::requestHandler, repeat);
    }
    else
    {
        throw new UnsupportedOperationException("asyncRead is not support without a request queue.");
    }

    if (debugEnabled)
    {
        dbgTrace.traceExit(funcName, TrcDbgTrace.TraceLevel.API);
    }
}   //asyncRead`

I don't know where requestQueue gets set, but this is definitely a different way of reading than using I2cDeviceSynch.read() - and maybe that's a good thing!

Nevermind about the request queue - I just traced the code back and see that it all boils down to the local "read data" implementation, which requires an address. I haven't found any code that writes directly to the bus, nor have I figured out whether sending in 0 forces the SDK to skip the register. If you want to test, that would be great. BTW, no rush - we decided to just use analog/y and that should work for our purposes. But I'd still like to get to the bottom of this.


i18n(fr): Update guides/integrations-guide/*from #9240

Description (required)
Update guides/integrations-guide/* from #9240

[!NOTE]

Check Links: src/content/docs/fr/guides/integrations-guide/vercel.mdx#L237
Broken fragment link in src/content/docs/fr/guides/integrations-guide/vercel.mdx, line 237: The linked page does not contain a fragment with the name "#request"

Need to edit the reference/api-reference/#request and guides/content-collections/#defining-the-collection-loader (wrong link in mdx.mdx L101.)

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

fr/guides/integrations-guide/alpinejs.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/cloudflare.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/db.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/deno.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/index.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/lit.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/markdoc.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/mdx.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/netlify.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/node.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/partytown.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/preact.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/prefetch.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/react.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/sitemap.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/solid-js.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/svelte.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/tailwind.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/vercel.mdx
Localization changed, will be marked as complete.

fr/guides/integrations-guide/vue.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

[!NOTE]

Check Links: src/content/docs/fr/guides/integrations-guide/vercel.mdx#L237
Broken fragment link in src/content/docs/fr/guides/integrations-guide/vercel.mdx, line 237: The linked page does not contain a fragment with the name "#request"

Need to edit the reference/api-reference/#request.

Otherwise for the broken link you can revert the change and we'll update all those links while updating api-reference.mdx... this is what I've done with some merged PR. Thanks to linkcheck we can retrieve all those links even if they are marked as up to date. 😉

[!WARNING]
Little error link from the file fr/guides/content-collections/#defining-the-collection-loader. Need update for content-collections

Hum... we have a problem here. The PR for content-collections needs integrations-guide/markdoc.mdx to be up to date... another circular dependency! 😅 See: #10145
What we could do to make this PR mergeable: remove the link to content-collection in mdx, I already have a big alert "Notes for myself" in #10145, I can add another one to add back this link...
The PR also depends on the tutorial update (I'm on it), then it should be mergeable. So the link won't be away for long...
What do you think about it?
If this solution suits you, you also need to revert the link to api-reference in vercel.mdx (another broken link), we'll update it at the same time as api-reference.mdx.

Hum... we have a problem here. The PR for content-collections needs integrations-guide/markdoc.mdx to be up to date... another circular dependency! 😅 See: #10145
What we could do to make this PR mergeable: remove the link to content-collection in mdx, I already have a big alert "Notes for myself" in #10145, I can add another one to add back this link... The PR also depends on the tutorial update (I'm on it), then it should be mergeable. So the link won't be away for long...
What do you think about it?
If this solution suits you, you also need to revert the link to api-reference in vercel.mdx (another broken link), we'll update it at the same time as api-reference.mdx.

[!IMPORTANT]
Note for myself, mdx.mdx line 101 : When content-collections will be updated, put this text with good link.
🚨🚨🚨


Type is not comparable error when attempting to sort a list containing null

When evaluating this expression:
define X: ({ 1, 2, 3, null }) A sort asc

the engine throws an error "Type is not comparable", but this should evaluate.
Looking at the spec for the appropriate behavior, section 2.3.3, last paragraph says the nulls should appear at the beginning of the list when it is sorted ascending, and at the end of the list when it is sorted descending.

I also noticed a related bug manifesting in the CQL Runner:
define X: ({ 1, 2, 3, null }) A sort asc
define Y: ({ null, 1, 2, 3 }) A sort asc
define Z: ({ 1, 2, null, 3 }) A sort asc

When the null is the first item in the list like with Y, the "Type is not comparable" message doesn't display at all, whereas when the null is in the middle or the end, like in X or Z, it does display.

Resolved in release 1.2.20


remove iris and vtol with cameras models

This PR removes the iris and vtol models. They are now moved to the PX4 SITL Gazebo repository https://github.com/PX4/sitl_gazebo/pull/358
Some other models used in the past are left in /avoidance/sim/models

yes I opened a PR  #13228

Great, https://github.com/PX4/Firmware/pull/13228 is merged


Fixes non-existing translation PDF export

Short description

Fixes KeyError exception when only non-existing page translations are selected for PDF export
Proposed changes

Adds a function to check, whether at least one translation exists for
the selected pages.
If this is the case, PDF export for the selection is allowed else
denied.

Resolved issues

Fixes: #753
Additional context
This new function should enable both proposed approaches: User dialog or disabled bulk-action-button.

That's a good idea, this will prevent the exception raising again, when we decide to exchange the frontend once


Added basic random examples

Python random library examples

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Made the directory name lowercase.  Still needs a review.

Congrats @Naapi on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


App Crashed when 'await UserDialogs.Instance.ConfirmAsync(config);'

Platform:Android(called in PCL)
I call 'await UserDialogs.Instance.ConfirmAsync(config);' in  a async method
Library Version:
5.0.1(5.0)  ---   App Crashed
4.2.1   ----  Everything is OK
Exception:
UnhandledException:Java.Lang.RuntimeException: Can't create handler inside thread that has not called Looper.prepare()   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <filename unknown>:0    at Android.Runtime.JNIEnv.CallObjectMethod (IntPtr jobject, IntPtr jmethod) [0x00069] in <filename unknown>:0    at Android.App.AlertDialog+Builder.Show () [0x00049] in <filename unknown>:0    at Acr.UserDialogs.UserDialogsImpl.Show (Android.App.Builder builder) [0x00005] in <filename unknown>:0    at Acr.UserDialogs.UserDialogsImpl.Confirm (Acr.UserDialogs.ConfirmConfig config) [0x00040] in <filename unknown>:0    at Acr.UserDialogs.AbstractUserDialogs.ConfirmAsync (Acr.UserDialogs.ConfirmConfig config) [0x00023] in <filename unknown>:0

What version of android did this occur on?  Everything is wrapped in the usual main thread request.

The version of the OS is v4.4.4. Here is the code:
`private ICommand _submitCommand;
public ICommand SubmitCommand
{
get{
return _submitCommand??(_submitCommand=new Command(
async ()=>{
await Task.Run(async ()=>{
var loading=UserDialogs.Instance.Loading("正在提交...");
loading.Show();
loading.Title="正在验证数据...";
						var config = new ConfirmConfig()
						{
							Title = "提示",
							Message = "是否提交?",
							OkText = "提交",
							CancelText = "取消"
						};
						var confirmResult = await     UserDialogs.Instance.ConfirmAsync(config);

}});}`

You're actually spawning 2 tasks here.  Try removing the Task.Run and just use the async from the command.  That may help.
This is still a defect in user dialogs in any case

I have been unable to reproduce this.  However, I have made some updates to the ui thread management.  Try 5.1 and let me know please.  If the problem persists, please reopen this thread with any new info.

Removing Task.Run works,but there are too much places to modify ,so i still use v4.2.1.
I just tried v5.1,the issue still exists.
The command is synchronized ,i use Task.Run to do a heavy work,I come to know that it is not necessary to put  the heavy work  in Task.Run,just behind loading.Show();
Thanks for your excellent work!


data-wow-* not working on scroll container

Animation all working on scroll inside a scroll container. but data attribute thing is not working.

but data attribute thing

???
@GnanaAkilan did you try AOS.js instead?

Thanks


Escape shell cmd before echoing

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

you should use JPI and be added as maintainer :) I have solve most of the problems expresed in this PRs. I based my code on yours (let me know if I can help in anything else, I did my PR to the owners, if you need or want anything let me know)


[SPARK-49405][SQL] Restrict charsets in JsonOptions

What changes were proposed in this pull request?
Following the work of SPARK-48857 for CSV, this PR brings it to JSON options for reading and writing json files.
Why are the changes needed?
To make the charset list consistent across different platforms/JDKs and different plain text file sources
Does this PR introduce any user-facing change?
Yes,

For an invalid charset to both JDK and Spark definitions, UnsupportedCharsetException is replaced by INVALID_PARAMETER_VALUE.CHARSET error
For an invalid charset to Spark definitions only, INVALID_PARAMETER_VALUE.CHARSET will be raised instead of success. legacyJavaCharsets is provided to restore the old behavior

How was this patch tested?
Modified tests
Was this patch authored or co-authored using generative AI tooling?
no

Merged to master.
Thank you @dongjoon-hyun


docs: Describe which tools should be installed to avoid common errors

This PR is included in version 1.92.0 :tada:


Point Cloud and Image do not match

Hey! I had a question about the tutorial notebook. So I was using one of the tfrecords from the Waymo Open Dataset,  training/segment-6813611334239274394_535_000_555_000.tfrecord to be exact. When I try to project the point cloud on to the image in this case, I get a strange mismatch in the case of the stop sign on the right. I was wondering why this might be the case?

Did you try to use our pre-computed projection results? If that is not a problem, you can use our projection lib here. https://github.com/waymo-research/waymo-open-dataset/tree/master/third_party/camera/ops

No, I was following the notebook, testing with this data. How do we use this library? It's not packaged with waymo_open_dataset.

See my reply in https://github.com/waymo-research/waymo-open-dataset/issues/227
I am also going to release a new version. but you can build the package on your own which should be quite reproducible with the provided docker container


It's possible to have html instead string label

Hi,
I would like replace Label String by Icon with this code HTML ('
), it's possible ?

Hi,  html labels are not supported in CHARTJS (and therefore in Charba as well) since everything is done on the canvas.
If you're using an icon font you should be able to set the font family to the icon font, by FontFamily methods.
I'm gonna do some tests as well.

shame, I do not use a real font, but a style css. I could see if I find a glyph make for the flags

In Charba is still missing a feature of Chart.js to create custom axes. :(
I'm gonna implement it as soon as possible.
My goal is to provide an interface that you can implement and register it as new Axes.

@nseb what do you think?
Done by Charba, with some new features, leveraging on plugin.

We are still refactoring the "items" part (to read info from CHART.JS instance) right now... Can you wait some days?

Yes , no problems ;-)

Thanks! I will try as soon as possible

@nseb first of all we have published new version 1.5.
If you copy and paste the source I published here, you have the code of plugin and the activation at chart level.
chart.getPlugins ().add (p) is the statement to activate it.
FYI we have also updated the wiki where we are explaining how to use Charba, plugins as well

Thanks

I testing, the code is called , but nothing is draw ?
In wiki this line not working :  chart.getPlugins().setEnabled("pluginid", true);

I understand , I have negative X and add :  chart.getOptions().getLayout().getPadding().setLeft(100);
But always no image draw

Yes, you should. I usually use ImageResource of Gwt.
I suggest to use onAfterDatasetsDraw

Maybe can help.
See the class in the showcase project related to flags and we managed images.

my code works, I test with a lot of countries with the application on a phone to see the rendering and I shared the result

Very good!

I have a smalll enhancement. I'm trying to make the code more responsive, for tablet and mobile by reducing the padding too much:
 @Override         public boolean onBeforeLayout(AbstractChart<?, ?> chart, JavaScriptObject options) {             boolean b = super.onBeforeLayout(chart, options);             if (chart.getContainer().getOffsetWidth() > 450) {                 chart.getOptions().getLayout().getPadding().setLeft((50));             } else {                 chart.getOptions().getLayout().getPadding().setLeft(25);             }             return b;         }
But the event onBeforeLayout, is not the most suitable, if I resize the screen (= change orientation tablet), this code is not called

@nseb CHART.JS uses the options during the init phase to calculate the sizes for all component. Changing the padding in the plugin, you don't affect the already calculated sizes.
To be able to change padding using options you need to redraw the chart itself.
Let me take some time to propose you a solution.

@Thanks for your reply.
For the moment I fixed flag image size : https://www.ukart.io/#!/events/70

Well, let me say that was a little complex to address your need, because of:

the padding is absolute value and not related to size of chart or any other element ot it
changing otpions into a plugin doesn't have any effect on CHART.JS
changing option you need to redraw the chart (not only update)

First of all, in my example instead of using padding of the chart, you used the padding of ScaleLabel of axis, activating it. The label to show has been set to blank.
To do that, I created a axis (in the constructor or my composite) and set to chart (as YAxes because I'm in HorizontalBar chart), as following:
axis = new CartesianCategoryAxis(chart);
axis.setDisplay(true);
axis.getScaleLabel().setDisplay(true);

chart.getOptions().getScales().setYAxes(axis);

As you can see I didn't set any padding because I wanted to calculate at runtime before chart will be drawn. The axis instance has been set as a field of my composite, as following:
public class HorizontalFlagsBarView extends BaseComposite{

	private static ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class);

	interface ViewUiBinder extends UiBinder<Widget, HorizontalFlagsBarView> {
	}

	@UiField
	BarChart chart;

	CartesianCategoryAxis axis;

To set the padding before chart drawing and to be sure having the width of the chart (maintaining it responsive, that means without setting width or height to canvas), I overrided the onAttach method of the composite,
which contains the chart. In this way I'm setting a options BEFORE chart is started and therefore it can used the right amount of padding.
@Override
protected void onAttach() {
	calculateAndSetScaleLabelPadding(chart.getCanvas().getParentElement().getOffsetWidth());
	super.onAttach();
}

In the method, I got the canvas, and then its parent and got the width by getOffsetWidth of canvas parent.
With the width, I'm callig my method calculateAndSetScaleLabelPadding to calculate a proportional padding based on size of chart:
private void calculateAndSetScaleLabelPadding(int width) {
	int percent = width * PERCENT / 100;
	int padding = Math.min(Math.max(MIN, percent), MAX);
	axis.getScaleLabel().getPadding().setTop(padding);
}

To be very responsive, we should calculate the size of padding as percentage of real width of chart, with MIN and MAX.
For this reason, I set some constants:
	private static final int MIN = 50;

	private static final int MAX = 100;

	private static final int PERCENT = 10;

In my example, the padding is 10% of total width, with MIN of 50px and MAX of 100px.
Below the new method of plugin with new calculation and drawing of flags:
@Override
public void onAfterDatasetsDraw(AbstractChart<?, ?> chart, double easing, JavaScriptObject options) {
	final int padding = 4;

	Context2d ctx = chart.getCanvas().getContext2d();
	ScaleItem scale = chart.getChartNode().getScales().getItems().get(ScalesNode.DEFAULT_Y_AXIS_ID);
	List<String> ticks = scale.getTicks();

	int heightAmongLabels = (scale.getBottom() - scale.getTop()) / ticks.size();
	final int height = Math.min(heightAmongLabels - (padding * 2), MIN);
	final int width = Math.min(60 * height / 40, axis.getScaleLabel().getPadding().getTop() - padding);

	int x = scale.getLeft() + axis.getScaleLabel().getPadding().getTop() - width + axis.getScaleLabel().getFontSize();
	int y = scale.getTop();

	for (String tick : ticks) {
		ImageElement image = null;
		if (tick.equalsIgnoreCase("br")) {
			image = getImageElement(Images.INSTANCE.flagBR());
		} else if (tick.equalsIgnoreCase("de")) {
			image = getImageElement(Images.INSTANCE.flagDE());
		} else if (tick.equalsIgnoreCase("fr")) {
			image = getImageElement(Images.INSTANCE.flagFR());
		} else if (tick.equalsIgnoreCase("gb")) {
			image = getImageElement(Images.INSTANCE.flagGB());
		} else if (tick.equalsIgnoreCase("it")) {
			image = getImageElement(Images.INSTANCE.flagIT());
		} else if (tick.equalsIgnoreCase("us")) {
			image = getImageElement(Images.INSTANCE.flagUS());
		}
		if (image != null) {
			int yToDraw = y + (heightAmongLabels - height) / 2;
			ctx.drawImage(image, x, yToDraw, width, height);
		}
		y = y + heightAmongLabels;
	}
}

That's not enough, because we should take care of resize as well.
Therefore I added a resize handler to catch resize events. But when you are resizing, the handler can receive many events and you don't have any information when the event is last one.
I added a GWT timer which will calculate new padding (based on the size of the chart) only for the last event (waiting for 500ms).
Being the chart already intitialized and I'm changing a option, the timer will redraw the chart in order to be able to use the right padding.
chart.addHandler(new ChartResizeEventHandler() {

	private final Timer t = new Timer() {
		@Override
		public void run() {
			chart.reset();
			chart.draw();
		}
	};

	@Override
	public void onResize(final ChartResizeEvent event) {
		int width = event.getSize().getWidth();
		calculateAndSetScaleLabelPadding(width);
		t.schedule(500);
	}
}, ChartResizeEvent.TYPE);

Attached here the whole source.
package org.pepstock.charba.showcase.client.samples;

import java.util.List;

import org.pepstock.charba.client.AbstractChart;
import org.pepstock.charba.client.BarChart;
import org.pepstock.charba.client.colors.IsColor;
import org.pepstock.charba.client.data.BarDataset;
import org.pepstock.charba.client.data.Dataset;
import org.pepstock.charba.client.enums.Position;
import org.pepstock.charba.client.events.ChartResizeEvent;
import org.pepstock.charba.client.events.ChartResizeEventHandler;
import org.pepstock.charba.client.items.ScaleItem;
import org.pepstock.charba.client.items.ScalesNode;
import org.pepstock.charba.client.options.scales.CartesianCategoryAxis;
import org.pepstock.charba.client.plugins.AbstractPlugin;
import org.pepstock.charba.client.plugins.InvalidPluginIdException;
import org.pepstock.charba.showcase.client.resources.Images;
import org.pepstock.charba.showcase.client.samples.Toast.Level;

import com.google.gwt.canvas.dom.client.Context2d;
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.dom.client.ImageElement;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.resources.client.ImageResource;
import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField;
import com.google.gwt.uibinder.client.UiHandler;
import com.google.gwt.user.client.Timer;
import com.google.gwt.user.client.ui.Image;
import com.google.gwt.user.client.ui.Widget;

/**

 * @author Andrea "Stock" Stocchero
 */
public class HorizontalFlagsBarView extends BaseComposite{

	private static ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class);

	private static final String[] COUNTRIES = {"br","de","fr","gb","it","us"};

	interface ViewUiBinder extends UiBinder<Widget, HorizontalFlagsBarView> {
	}

	@UiField
	BarChart chart;

	CartesianCategoryAxis axis;

	private static final int MIN = 50;

	private static final int MAX = 100;

	private static final int PERCENT = 10;

	public HorizontalFlagsBarView() {
		initWidget(uiBinder.createAndBindUi(this));
		chart.getOptions().setResponsive(true);
		chart.getOptions().getLegend().setPosition(Position.right);
		chart.getOptions().getTitle().setDisplay(true);
		chart.getOptions().getTitle().setText("Charba Horizontal Bar Chart with Flags");

		BarDataset dataset1 = chart.newDataset();
		dataset1.setLabel("Countries");

		IsColor color1 = Colors.ALL[0];

		dataset1.setBackgroundColor(color1.alpha(0.2));
		dataset1.setBorderColor(color1.toHex());
		dataset1.setBorderWidth(1);
		dataset1.setData(getRandomDigits(COUNTRIES.length, false));

		axis = new CartesianCategoryAxis(chart);
		axis.setDisplay(true);
		axis.getScaleLabel().setDisplay(true);

		chart.getData().setLabels(COUNTRIES);
		chart.getData().setDatasets(dataset1);

		chart.getOptions().getScales().setYAxes(axis);

		chart.addHandler(new ChartResizeEventHandler() {

			private final Timer t = new Timer() {
				@Override
				public void run() {
					chart.reset();
					chart.draw();
				}
			};

			@Override
			public void onResize(final ChartResizeEvent event) {
				int width = event.getSize().getWidth();
				calculateAndSetScaleLabelPadding(width);
				t.schedule(500);
			}
		}, ChartResizeEvent.TYPE);

		AbstractPlugin p = new AbstractPlugin() {

			@Override
			public String getId() {
				return "test";
			}

			/* (non-Javadoc)
			 * @see org.pepstock.charba.client.plugins.AbstractPlugin#onAfterDatasetsDraw(org.pepstock.charba.client.AbstractChart, double)
			 */
			@Override
			public void onAfterDatasetsDraw(AbstractChart<?, ?> chart, double easing, JavaScriptObject options) {
				final int padding = 4;
				Context2d ctx = chart.getCanvas().getContext2d();
				ScaleItem scale = chart.getChartNode().getScales().getItems().get(ScalesNode.DEFAULT_Y_AXIS_ID);
				List<String> ticks = scale.getTicks();
				int heightAmongLabels = (scale.getBottom() - scale.getTop()) / ticks.size();
				final int height = Math.min(heightAmongLabels - (padding * 2), MIN);
				final int width = Math.min(60 * height / 40, axis.getScaleLabel().getPadding().getTop() - padding);
				int x = scale.getLeft() + axis.getScaleLabel().getPadding().getTop() - width + axis.getScaleLabel().getFontSize();
				int y = scale.getTop();
				for (String tick : ticks) {
					ImageElement image = null;
					if (tick.equalsIgnoreCase("br")) {
						image = getImageElement(Images.INSTANCE.flagBR());
					} else if (tick.equalsIgnoreCase("de")) {
						image = getImageElement(Images.INSTANCE.flagDE());
					} else if (tick.equalsIgnoreCase("fr")) {
						image = getImageElement(Images.INSTANCE.flagFR());
					} else if (tick.equalsIgnoreCase("gb")) {
						image = getImageElement(Images.INSTANCE.flagGB());
					} else if (tick.equalsIgnoreCase("it")) {
						image = getImageElement(Images.INSTANCE.flagIT());
					} else if (tick.equalsIgnoreCase("us")) {
						image = getImageElement(Images.INSTANCE.flagUS());
					}

					if (image != null) {
						int yToDraw = y + (heightAmongLabels - height) / 2;
						ctx.drawImage(image, x, yToDraw, width, height);
					}
					y = y + heightAmongLabels;
				}
			}
		};
		try {
			chart.getPlugins().add(p);
		} catch (InvalidPluginIdException e) {
			new Toast("Invalid PlugiID!", Level.ERROR, e.getMessage()).show();
		}

	}

	/* (non-Javadoc)
	 * @see com.google.gwt.user.client.ui.Composite#onAttach()
	 */
	@Override
	protected void onAttach() {
		calculateAndSetScaleLabelPadding(chart.getCanvas().getParentElement().getOffsetWidth());
		super.onAttach();
	}

	private ImageElement getImageElement(ImageResource resource) {
		Image img = new Image(resource.getSafeUri());
	    return ImageElement.as(img.getElement());
	}

	@UiHandler("randomize")
	protected void handleRandomize(ClickEvent event) {
		for (Dataset dataset : chart.getData().getDatasets()){
			dataset.setData(getRandomDigits(months));
		}
		chart.update();
	}

	private void calculateAndSetScaleLabelPadding(int width) {
		int percent = width * PERCENT / 100;
		int padding = Math.min(Math.max(MIN, percent), MAX);
		axis.getScaleLabel().getPadding().setTop(padding);
	}
}

@nseb I'd like to inform you in advance that as promised we are developing the extensions of CHART.JS about custom charts (based on controllers).
With this feature, all above code can be move into a controller, without adding onAttach extension and Resize listener.
As usual, please wait for some days because we are completing tests.

@stockiNail  , Thanks , sorry I had time to reply at your previous comment.


Optimize WarpSync process

WarpSync process is performing some actions that it possibly doesn't need to. Ideas to be discussed.

Do not schedule blocks/gossip/add to tip pool when WarpSyncing
Do not cast SpendDAG votes when WarpSyncing
Don’t handle weight propagation when WarpSyncing
Indexer is slow while syncing - Applying slot 12464 with 0 new and 0 consumed outputs took 1.242s
Increase number of workers (done in #897)

I think 2-5 we shouldn't do now as it might introduce complications down the line and 1 is already done in #896


Multi Select with Long Values Doesn't Wrap if Bootstrap Theme is Applied

The following code causes long selections to wrap beyond the boundary of the select:
<!DOCTYPE html>
<html lang="en" ng-app="demo">
<head>
  <meta charset="utf-8">
  <title>Multi Select with Long Values Doesn't Wrap if Bootstrap Theme is Applied Issue</title>

  <script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.js"></script>
  <link rel="stylesheet" href="http://netdna.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.css">
  <script src="http://cdnjs.cloudflare.com/ajax/libs/angular-ui-select/0.13.2/select.min.js"></script>
  <link rel="stylesheet" href="http://cdnjs.cloudflare.com/ajax/libs/angular-ui-select/0.13.2/select.min.css">
  <script>
    var app = angular.module('demo', ['ui.select']);
    app.controller('DemoCtrl', function($scope, $http, $timeout) {

      $scope.availableColors = ['Red', 'Turquoise extremely extremely extremely extremely extremely extremely extremely long text'];

      $scope.multipleDemo = {};
      $scope.multipleDemo.colors = ['Red', 'Turquoise extremely extremely extremely extremely extremely extremely extremely long text'];
    });
  </script>
</head>
<body ng-controller="DemoCtrl">
  <ui-select multiple ng-model="multipleDemo.colors" theme="bootstrap" style="width: 300px;">
    <ui-select-match placeholder="Select colors...">{{$item}}</ui-select-match>
    <ui-select-choices repeat="color in availableColors | filter:$select.search">
      {{color}}
    </ui-select-choices>
  </ui-select>
</body>
</html>

+1

Duplicate of #1278 (contains possible workarounds)


ExecuteQuery: Result documentation doesn't match the actual result.

Documentation says that one of the properties is Result. It's actually Output.

Fixed in version 2.1.3.


Deploy proxy contracts from OpenZeppelin Contracts 5.0

The proxy contracts deployed by the Hardhat Upgrades plugin are currently from OpenZeppelin Contracts v4.
Change the Hardhat Upgrades plugin to deploy proxy contracts from OpenZeppelin Contracts v5.
Currently, to use v5 proxy contracts, users need to deploy them without the plugin, then import them using upgrades.forceImport.

Would be great if someone on the team could comment here, this is a blocker for our us currently.  Any ETA?  Thanks

This is a priority for us and we are aiming to have this available soon.  You can follow the progress in this branch: https://github.com/ericglau/openzeppelin-upgrades/commits/5.0proxies

This is released in<EMAIL_ADDRESS>


add module-info to jca

Hi, @michaelqi793 , could you please investigate the pipeline failure?

I created an issue about keyvault-ci pipeline failure: https://github.com/Azure/azure-sdk-for-java/issues/21677
Let's wait.

Hi, @michaelqi793 ,
This PR https://github.com/Azure/azure-sdk-for-java/pull/21703 is merged, please merge latest master branch to your branch.


fix(script-error): when the script throws an error show the message

:tada: This PR is included in version 1.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


displacement problem

hello sir,
why the displacement is calculated as below ?
displacement = (q_grid.reshape(B * self.n_groups, H * W, 2).unsqueeze(2) - pos.reshape(B * self.n_groups, n_sample, 2).unsqueeze(1)).mul(0.5)
why not
displacement = (pos.reshape(B * self.n_groups, H * W, 2).unsqueeze(2) - pos.reshape(B * self.n_groups, n_sample, 2).unsqueeze(1))

The subtraction of two numbers in [-1, 1] lies in [-2, 2], while the grid_sample operation needs the coordinates to be in [-1, 1].


Pr 426

Closes #426, now with test

@not-a-robot r+

This change looks incorrect to my opinion. According to sdscatfmt, %T modifier means size_t variable. Indeed, len has this type in hiredis.c: size_t len;. In sds.h %T is handled in the following case:
            case 'u':
            case 'U':
            case 'T':
                if (next == 'u')
                    unum = va_arg(ap,unsigned int);
                else if(next == 'U')
                    unum = va_arg(ap,unsigned long long);
                else
                    unum = (unsigned long long)va_arg(ap,size_t);

Hence, before patch, there was a correct format string. Now, on the contrary, it is broken at least on big endian machines where size_t > unsigned int and when values does not fit in unsigned int. Could you please recheck this change?

@vstakhov Uff, not sure I'm following. What values would produce an incorrect result here? (If you bring this up in a new issue referencing this PR I can better track it)

You extract size_t argument using va_arg(ap,unsigned int);. Does it look sane? The previous version did the proper thing - it extracted size_t as size_t: (unsigned long long)va_arg(ap,size_t);. I'm using this PR because it changed the correct behaviour to the incorrect one (at least, I think so).

But I can't re-open a PR to track the potential bug ;)
I take a look at this problem next week. Thanks for bringing it up.


makerst.py does not generate docs for custom modules that override config.py::get_doc_path()

Godot version
3.x
System information
Windows 10
Issue description
I need to generate documentation for my custom module to publish online with makerst.py tool https://github.com/goostengine/goost-docs, which provides online documentation for Goost.
The problem is that when you override config::get_doc_path() in one of the nested modules in Goost, makerst.py is no longer able to generate RST documentation.
It looks to me that "doc_classes" is simply hardcoded, and does not take into account doc paths that could be overridden in config.py:
https://github.com/godotengine/godot/blob/2370fe5c26085a90ca17544ce5912e6b648971a5/doc/tools/makerst.py#L325-L330
I can fix this myself. I asked about this at Godot contributors chat prior to making this bug report, but I haven't received a definitive response regarding whether a pull request that aims to fix this would be welcomed (regardless of concerns surrounding this issue, I'm talking primarily from the standpoint that solutions must be local according to Godot's best practices for engine contributors), so I decided to make a bug report to keep track of this issue instead of a pull request, at least.
Steps to reproduce
With makerst, it's possible to provide several search paths, and in order to generate docs for custom modules, I do something like this:
# goost.py

        subprocess.run([sys.executable,
            "godot/doc/tools/makerst.py",
            "godot/doc/classes", # Godot's own classes, need to specify to do type checks against Goost classes.
            "godot/modules", # Godot's own built-in modules.
            "doc", # Goost's own doc path, for some reason this works, perhaps because Godot also has this.
            "modules", # Goost has nested modules. DOES NOT GENERATE DOCS HERE.
            "--output", output_path,
            "--filter", "^(?!.*godot)", # Prevent writing out Godot classes.
        ])

You can also reproduce this issue by overriding one of the Godot's modules config.py::get_doc_path() to anything else but "doc_classes", and don't forget to rename the actual "doc_classes" folder in a module to the previously overridden value.
For example, you can go to modules/csg and rename doc_classes/ to doc/, and make config.py::get_doc_path() return "doc" value. Then:
PS D:\usr\src\godotengine\godot\gd3> python doc/tools/makerst.py doc/classes modules
Checking for errors in the XML class reference...
ERROR: Unresolved type 'CSGShape', file: NavigationMesh
Errors were found in the class reference XML. Please check the messages above.

As you see above, CSGShape is missing as a dependency for NavigationMesh, because makerst failed to collect the CSGShape.xml in the first place, and others.
Minimal reproduction project
No response

To reiterate my points from RC for posterity...
While, yes, this is an issue with makerst, I don't see much point in leaving the doc path for modules customizable. Customization here makes sense when we can run into name conflicts, but our default value (doc_classes, derived from engine's own doc/classes/ folder) is very unlikely to conflict with anything. As such, I would solve this problem by removing the option to customize the path. Uniformity is only going to help module developers and their contributors.

Customization here makes sense when we can run into name conflicts, but our default value (doc_classes, derived from engine's own doc/classes/ folder) is very unlikely to conflict with anything. As such, I would solve this problem by removing the option to customize the path. Uniformity is only going to help module developers and their contributors.

If you do believe that this suggestion would be an improvement to Godot's buildsystem, feel free to create a proposal for this at GIP.
All I'm asking is whether a PR to fix this specific issue would be welcomed, I'm not interested in making doc and editor icons paths non-configurable. Any large project will definitely require some sort of customization from the buildsystem, as evident with modules such as https://github.com/Zylann/godot_voxel from the organizational point of view.

We don't fix issues and make PRs without considerations, @Xrayez. And a solution to the issue is not always direct. You can look at it this way: customization of the doc path is not currently supported, so the fact that you can override the path is a bug.

We don't fix issues and make PRs without considerations, @Xrayez. And a solution to the issue is not always direct.

@pycbouh I'm totally aware of this, but this does not cancel out what I've said. My personal motivation has nothing to do with consensus. To make this extra clear: I don't put my personal preference above consensus. I'd find this kind of attitude disrespectful. Your assumption that I don't consider other opinions could also be seen disrespectful, because you show myself in a way that undermines my experience, expertise and reputation (I've been contributing to Godot for the past 4 years).
For reference, I have updated the best practices for engine contributors page to reflect that solutions are not always direct, which is indeed true: godotengine/godot-docs#5222.
But again, this specific issue could be fixed quite easily, so I'd prefer a local solution, and this kind of  solution would reflect my specific problem, and in fact would make the feature set coherent and complete. The feature of configurable paths for documentation and editor icons has existed for more than 3 years if I recall correctly, and I've never seen a bug report for that feature so far. Since Godot's development is problem-based, I suggested you to open a proposal to discuss feature removal, that would be more effective rather than discussing semantics here and/or speculating whether this is a bug or a feature:

You can look at it this way: customization of the doc path is not currently supported, so the fact that you can override the path is a bug.


Add support for all valid string literals

Fixes #3. This was the cause for black not being able to support rf strings. Now this forked version of lib2to3 only parses valid string literals as defined by https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals

Pull Request Test Coverage Report for Build 181

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.42%

Totals

Change from base Build 178:
0.0%

Covered Lines:
1378

Relevant Lines:
1524

💛  - Coveralls

Pull Request Test Coverage Report for Build 181

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.42%

Totals

Change from base Build 178:
0.0%

Covered Lines:
1378

Relevant Lines:
1524

💛  - Coveralls

Pull Request Test Coverage Report for Build 181

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.42%

Totals

Change from base Build 178:
0.0%

Covered Lines:
1378

Relevant Lines:
1524

💛  - Coveralls

Thanks! ✨ 🍰 ✨


VDC: add validation on activation service addr before deploying any vdc

Now we should check if the activation service has more than a specific threshold before deploying.. Maybe 15 xlm?

not needed anymore

not needed anymore


Bump ignition experimental to 3.6.0-experimental

Bumping spec versions
This checklist describes bumping the Ignition spec version, base version, and distro versions. If your scenario is different, modify to taste.
Stabilize Ignition spec version

[x] Bump go.mod for new Ignition release and update vendor.
[x] Update imports. Drop -experimental from Ignition spec versions in */translate_test.go.

Bump base version

[x] Rename base/vB_exp to base/vB and update package statements. Update imports.
[x] Copy base/vB to base/vB+1_exp.
[x] Update package statements in base/vB+1_exp.

Bump distro version

[x] Rename config/distro/vD_exp to config/distro/vD and update package statements. Update imports.
[x] Drop -experimental from init() in config/config.go.
[x] Drop -experimental from examples in docs/.
[x] Copy config/distro/vD to config/distro/vD+1_exp.
[x] Update package statements in config/distro/vD+1_exp. Bump its base dependency to base/vB+1_exp.
[x] Import config/vD+1_exp in config/config.go and add distro C+1-experimental to init().

Bump Ignition spec version

[x] Bump Ignition types imports and rename ToIgnI and TestToIgnI functions in base/vB+1_exp. Bump Ignition spec versions in base/vB+1_exp/translate_test.go.
[x] Bump Ignition types imports in config/distro/vD+1_exp. Update ToIgnI function names, util calls, and header comments to ToIgnI+1.

Update docs

[x] Update internal/doc/main.go to add the new stable spec and reference the new experimental spec in generate().
[x] Run generate to regenerate spec docs.
[x] Update docs/specs.md.
[ ] Update docs/upgrading-*.md for the new spec version. Copy the relevant section from Ignition's doc/migrating-configs.md, convert the configs to Butane configs, convert field names to snake case, and update wording as needed. Add subsections for any new Butane-specific features.
[x] Note the stabilization in docs/release-notes.md, following the format of previous stabilizations. Drop the -exp version suffix from any notes for the upcoming release.

Closed by #562


[RFC] Mutation Observer CSUI with inline ShadowDOM injection

How do you envision this feature/change to look/work like?
Add to csui mount some code that can:
1 - watch for DOM change and return element based on query
2 - take the element and use it as the shadowDOM's parent
What is the purpose of this change/feature? Why?
CSUI need to be inline with an element on the page and not just as an overlay
(OPTIONAL) Example implementations
No response
(OPTIONAL) Contact Details
No response
Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

Some preliminary progress:


Build(deps-dev): Bump mocha from 9.2.0 to 9.2.1 (#2824)

Pull request opened by the merge tool on behalf of #2824

Processing this pull request

An unexpected error occurred while processing this pull request. The request might have been partially processed. Caused by: GitHub API query failed: got errors in response: [{'type': 'UNPROCESSABLE', 'path': ['createPullRequest'], 'locations': [{'line': 2, 'column': 9}], 'message': 'A pull request already exists for inmanta:dependabot/npm_and_yarn/mocha-9.2.1.'}]


First pass at using upstream role

girder/cumulus cmake tests all pass for me. I can log in,  hpccloud is available on 8888 etc...  I have not tried any of the integration tests because i'm not sure which currently pass/fail on master.
@cjh1 PTAL thanks!

-2000 lines awesome!


[Bug]: The description of the lab and the activities of the lab don't seem to match

File Name
intro_function_calling.ipynb
What happened?
In the description of the lab (in Why Function Calling), the emphasis is on using functions to reformat output.  None of the examples discussed in the Objectives right below this section seem to have anything to do with reformatting the output.
In looking at those objectives more closely, there also seem to be some problems. The first objective is to get weather for a location.  This is a fairly classic example of function calling, but it's not covered by the description.  And weather isn't included anywhere else in the lab.
In place of the weather example, there's a section in the lab on "Logging example: Using Function Calling for entity extraction only" that's not included in the objectives.
These are fairly major problems IMHO.  I also wish the parts of the lab were organized in the same order as the objectives, but I can search a file, so I managed to find where the objectives were, so this feels less important.
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for the report!

In the description of the lab (in Why Function Calling), the emphasis is on using functions to reformat output. None of the examples discussed in the Objectives right below this section seem to have anything to do with reformatting the output.

At its core, Gemini Function Calling is a mode in Gemini to coerce structured output that includes predicted function names and function parameters. Only after the function names and function parameters are returned by Gemini can a user take action using that data, which happens outside of the Gemini SDK/API. In most cases users will take this data and use it to make an API call. The naming of "Function Calling" is confusing in this regard, since the core functionality is all about structured data outputs rather than actually calling functions (confusing, we know).
All of this makes it difficult to explain Function Calling, structured data outputs, JSON responses from the REST API, extracting parameters, then calling the API, as we do in the Why Function Calling? section. You can see similar language in the Gemini Function Calling docs in Vertex AI. I wish it were easier to explain, and we'll continue to reword, but it's important to explain the structured data responses to clarify that "it doesn't make the function call for you". And "Function Calling" has become a standard term for these type of structured data responses from generative models (e.g., https://python.langchain.com/v0.1/docs/modules/model_io/chat/function_calling/).

In looking at those objectives more closely, there also seem to be some problems.

Thanks for calling this out! Based on change in behavior and/or issues with different versions of Function Calling over the past few months, I had to rework major sections of this sample notebook, and it seems that the objectives section is now way out of sync with the actual sections. I'll create a PR to address this, and see if I can reword any of the language about structured data outputs and function calls in the intro.


ISO 8601 timestamps with milliseconds are not parsed properly

When timestamp strings include milliseconds, the millisecond portion and (more importantly) the timezone information is not correctly parsed.
For example:
>>> from pyswagger import utils
>>> utils.from_iso8601("2016-08-05T03:14:14Z")
datetime.datetime(2016, 8, 5, 3, 14, 14, tzinfo=<pyswagger.utils.FixedTZ object at 0x10e0316d0>)
>>> utils.from_iso8601("2016-08-05T03:14:14.809Z")
datetime.datetime(2016, 8, 5, 3, 14, 14)

Note in the second example, timezone information is missing.
Compare this to dateutil:
>>> dateutil.parser.parse("2016-08-05T03:14:14.809Z")
datetime.datetime(2016, 8, 5, 3, 14, 14, 809000, tzinfo=tzutc())

In my use case, this is causing problems interoperating with a swagger server that gives millisecond timestamps.

The dot is not handled in the regular-expression used to parse the ISO-8601 strings. Thanks for pointing out, I'll add them this weekend.

Thank you! I really appreciate the quick response.
On Fri, Aug 5, 2016 at 1:57 AM, mission.liao<EMAIL_ADDRESS>wrote:

The dot is not handled in the regular-expression used to parse the
ISO-8601 strings. Thanks for pointing out, I'll add them this weekend.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mission-liao/pyswagger/issues/83#issuecomment-237762696,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARrRd7hG8770nMnkNknyZk3zoY9UKIWZks5qctCxgaJpZM4JdWeG
.

This issue should be fixed in latest release. (I forget to include the example string you provided in this issue to test, it would be included in next commit)
BTW, the original reasons to write the part to parse ISO 8601 formatted string instead of using Arrow:

I want to minimize the dependency of this project
I think it shouldn't be hard

Now I need to reconsider the second reason :(


Refactor

Small refactor allowing less lines and more readability per object.

@NicolasBonduel , merge and release?


access violation in bpf_object__open

Describe the bug
The XDP stress test crashed due to an access violation within bpf_object__open.
OS information
17763.1.amd64fre.rs5_release.180914-1434
Steps taken to reproduce bug
Run XDP stress test with eBPF integration.
Expected behavior
The stress test should not crash.
Actual outcome
The stress test crashed.
Additional details
Crash dump: ebpf_av_open.zip
0:011> kn
 # Child-SP          RetAddr               Call Site
00 000000e2`80ffc468 00007ffc`d593f5b1     ntdll!ZwAlpcSendWaitReceivePort+0x14 [minkernel\ntdll\daytona\objfre\amd64\usrstubs.asm @ 1283]
01 000000e2`80ffc470 00007ffc`d593e9a7     ntdll!SendMessageToWERService+0x1a5 [minkernel\ntdll\wer.c @ 491]
02 000000e2`80ffc5d0 00007ffc`d54d8133     ntdll!ReportExceptionInternal+0xe3 [minkernel\ntdll\wer.c @ 627]
03 000000e2`80ffd140 00007ffc`d54d7d2c     kernel32!WerpReportFaultInternal+0x3cf [onecore\windows\feedback\core\faultrep\lib\faultrep.cpp @ 896]
04 000000e2`80ffd260 00007ffc`d252725e     kernel32!WerpReportFault+0xac [onecore\windows\feedback\core\faultrep\lib\faultrep.cpp @ 1313]
05 000000e2`80ffd2a0 00007ffc`d5909240     KERNELBASE!UnhandledExceptionFilter+0x35e [minkernel\kernelbase\xcpt.c @ 685]
06 (Inline Function) --------`--------     ntdll!RtlpThreadExceptionFilter+0x99 [minkernel\ntdll\rtlstrt.c @ 967]
07 000000e2`80ffd3b0 00007ffc`d58efe56     ntdll!RtlUserThreadStart$filt$0+0xaa [minkernel\ntdll\rtlstrt.c @ 1164]
08 000000e2`80ffd3f0 00007ffc`d590582f     ntdll!__C_specific_handler+0x96 [minkernel\crts\crtw32\misc\riscchandler.c @ 352]
09 000000e2`80ffd460 00007ffc`d5864cef     ntdll!RtlpExecuteHandlerForException+0xf [minkernel\ntos\rtl\amd64\xcptmisc.asm @ 132]
0a 000000e2`80ffd490 00007ffc`d590459e     ntdll!RtlDispatchException+0x40f [minkernel\ntos\rtl\amd64\exdsptch.c @ 628]
0b 000000e2`80ffdbc0 00007ffc`b3528f3d     ntdll!KiUserExceptionDispatch+0x2e [minkernel\ntos\rtl\amd64\trampoln.asm @ 749]
0c (Inline Function) --------`--------     EbpfApi!ELFIO::elfio::Sections::operator[]+0x36 [D:\ebpf-for-windows\external\ebpf-verifier\external\elfio\elfio\elfio.hpp @ 962]
0d (Inline Function) --------`--------     EbpfApi!ELFIO::symbol_section_accessor_template<ELFIO::section const >::find_hash_section+0x4a [D:\ebpf-for-windows\external\ebpf-verifier\external\elfio\elfio\elfio_symbols.hpp @ 268]
0e (Inline Function) --------`--------     EbpfApi!ELFIO::symbol_section_accessor_template<ELFIO::section const >::{ctor}+0x75 [D:\ebpf-for-windows\external\ebpf-verifier\external\elfio\elfio\elfio_symbols.hpp @ 37]
0f 000000e2`80ffe360 00007ffc`b352f5e2     EbpfApi!_get_program_and_map_names+0x18d [D:\ebpf-for-windows\libs\api\Verifier.cpp @ 71]
10 000000e2`80ffe6b0 00007ffc`b350f66c     EbpfApi!load_byte_code+0x1152 [D:\ebpf-for-windows\libs\api\Verifier.cpp @ 271]
11 000000e2`80ffe980 00007ffc`b35180d6     EbpfApi!_initialize_ebpf_object_from_elf+0x13c [D:\ebpf-for-windows\libs\api\ebpf_api.cpp @ 1772]
12 (Inline Function) --------`--------     EbpfApi!_initialize_ebpf_object_from_file+0x5c [D:\ebpf-for-windows\libs\api\ebpf_api.cpp @ 1817]
13 000000e2`80ffea60 00007ffc`b3534cb7     EbpfApi!ebpf_object_open+0x1e6 [D:\ebpf-for-windows\libs\api\ebpf_api.cpp @ 2307]
14 (Inline Function) --------`--------     EbpfApi!bpf_object__open_file+0x54 [D:\ebpf-for-windows\libs\api\libbpf_object.cpp @ 101]
15 000000e2`80ffeb20 00007ff7`9cfe2f12     EbpfApi!bpf_object__open+0x67 [D:\ebpf-for-windows\libs\api\libbpf_object.cpp @ 89]
16 000000e2`80ffeb90 00000000`00000000     spinxsk!AttachXdpEbpfProgram+0x282 [D:\xdp\test\spinxsk\spinxsk.c @ 438]

Adding data from a different repro (with ASAN) since #2134 is presumably a duplicate of this issue:
Attached is the ebpfapi.dll and matching PDB to resolve proper symbols: ebpfapi_symbols.zip
==2436==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000000 (pc 0x7ffffcb98f3d bp 0x00ae0b8feb40 sp 0x00ae0b8fea40 T119)
==2436==The signal is caused by a READ memory access.
==2436==Hint: address points to the zero page.
    #0 0x7ffffcb98f3c in libbpf_num_possible_cpus+0x662c (C:\ebpf\EbpfApi.dll+0x180098f3c)
    #1 0x7ffffcb9f5e1 in libbpf_num_possible_cpus+0xccd1 (C:\ebpf\EbpfApi.dll+0x18009f5e1)
    #2 0x7ffffcb7f66b  (C:\ebpf\EbpfApi.dll+0x18007f66b)
    #3 0x7ffffcb880d5 in ebpf_object_get+0xd95 (C:\ebpf\EbpfApi.dll+0x1800880d5)
    #4 0x7ffffcba4cb6 in bpf_object__open+0x66 (C:\ebpf\EbpfApi.dll+0x1800a4cb6)
    #5 0x7ff774b328f9 in AttachXdpEbpfProgram D:\xdp\test\spinxsk\spinxsk.c:440
    #6 0x7ff774b33dab in AttachXdpProgram D:\xdp\test\spinxsk\spinxsk.c:563
    #7 0x7ff774b3b5e9 in FuzzSocketMisc D:\xdp\test\spinxsk\spinxsk.c:1451
    #8 0x7ff774b3ea68 in XskFuzzerWorkerFn D:\xdp\test\spinxsk\spinxsk.c:1885
    #9 0x7ff774b6c519 in __asan::AsanThread::ThreadStart D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_thread.cpp:262
    #10 0x7ff80ebc7ad3 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017ad3)
    #11 0x7ff81137a370 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x18005a370)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: access-violation (C:\ebpf\EbpfApi.dll+0x180098f3c) in libbpf_num_possible_cpus+0x662c
Thread T119 created by T4 here:
    #0 0x7ff774b6af0f in __asan_wrap_CreateThread D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_win.cpp:149
    #1 0x7ff774b40b34 in QueueWorkerFn D:\xdp\test\spinxsk\spinxsk.c:2053
    #2 0x7ff774b6c519 in __asan::AsanThread::ThreadStart D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_thread.cpp:262
    #3 0x7ff80ebc7ad3 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017ad3)
    #4 0x7ff81137a370 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x18005a370)

Thread T4 created by T0 here:
    #0 0x7ff774b6af0f in __asan_wrap_CreateThread D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_win.cpp:149
    #1 0x7ff774b440de in main D:\xdp\test\spinxsk\spinxsk.c:2411
    #2 0x7ff774b9ae38 in invoke_main D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78
    #3 0x7ff774b9ad8d in __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
    #4 0x7ff774b9ac4d in __scrt_common_main D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:330
    #5 0x7ff774b9aead in mainCRTStartup D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:16
    #6 0x7ff80ebc7ad3 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017ad3)
    #7 0x7ff81137a370 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x18005a370)

==2436==ABORTING

This issue is due to not supporting an ELF file with no .symtab section.

@mtfriesen can you send the .o file that was being loaded?

This issue is due to not supporting an ELF file with no .symtab section.

Further analysis:
Verifier.cpp line 187 reads the elf file.
If the load fails, or no .symtab section then asm_files.cpp line 120 should throw and never call the stack shown in this bug.
Otherwise line 269 calls _get_program_and_map_names(), so there must have been a .symtab section.
But in the crash at this point sections 8-16 have no name so it cannot find the .symtab section.
Perhaps they were freed or corrupted somehow?

@mtfriesen - no repro, could you please attach the bpf program, symbols and repro again? thanks.

Sure, I will reopen with the requested artifacts upon the next repro.

@dthaler here is a new crash dump with bpf programs and symbols.
ebpf6.zip

After upgrading to a newer eBPF build, this crash has not occurred. I'm closing this for now and will reactivate if we do get a repro.

We have a repro on a recent build of eBPF in our CI/CD: https://azurewatson.microsoft.com/dumps/7169378350
Faulting module: EbpfApi.dll <IP_ADDRESS> 2023-04-09 07:52:39Z (64326EC7)
ucrtbase!_invoke_watson+0x18 [minkernel\crts\ucrt\src\appcrt\misc\invalid_parameter.cpp @ 224]
ucrtbase!_invalid_parameter+0x81 [minkernel\crts\ucrt\src\appcrt\misc\invalid_parameter.cpp @ 112]
ucrtbase!_invalid_parameter_noinfo+0x9 [minkernel\crts\ucrt\src\appcrt\misc\invalid_parameter.cpp @ 118]
ucrtbase!_close+0x3a381 [minkernel\crts\ucrt\src\appcrt\lowio\close.cpp @ 64]
ucrtbase!_fclose_nolock+0x47 [minkernel\crts\ucrt\src\appcrt\stdio\fclose.cpp @ 61]
ucrtbase!fclose+0x40 [minkernel\crts\ucrt\src\appcrt\stdio\fclose.cpp @ 36]
ebpfapi!std::basic_filebuf_char,std::char_traits_char_ _::close+0x69 [C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\include\fstream @ 392]
ebpfapi!std::basic_filebuf_char,std::char_traits_char_ _::~basic_filebuf_char,std::char_traits_char_ _+0x5a [C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\include\fstream @ 186]
ebpfapi!std::basic_ifstream_char,std::char_traits_char_ _::`vbase destructor'+0x45
ebpfapi!read_elf+0xc7
ebpfapi!load_byte_code+0x1d4 [D:\a\ebpf-for-windows\ebpf-for-windows\libs\api\Verifier.cpp @ 187]
ebpfapi!_initialize_ebpf_object_from_elf+0x13c [D:\a\ebpf-for-windows\ebpf-for-windows\libs\api\ebpf_api.cpp @ 1779]
ebpfapi!ebpf_object_open+0x1e6 [D:\a\ebpf-for-windows\ebpf-for-windows\libs\api\ebpf_api.cpp @ 2314]
ebpfapi!bpf_object__open+0x67 [D:\a\ebpf-for-windows\ebpf-for-windows\libs\api\libbpf_object.cpp @ 91]
```[EbpfApi.dll](https://azurewatson.microsoft.com/?FaultingModule=EbpfApi.dll) [<IP_ADDRESS>](https://azurewatson.microsoft.com/?FaultingModuleVer=<IP_ADDRESS>) 2023-04-09 07:52:39Z (64326EC7)

It looks like the above one is a different call stack than the original issue. I found another instance of the original issue -- https://azurewatson.microsoft.com/dumps/7191372087 where it again there is no .symtab section. But not sure how that is possible, as it should have failed earlier as Dave mentioned earlier.
Maybe this is a bug in ELFIO when we are loading same .o file in parallel?

@mtfriesen Is it possible to get a local repro (and a debugger) for this issue?

It will be hard to repro this on demand, at least right now, because our stress tests are hitting a hang or deadlock in eBPF (#2457) much more frequently than anything else.
In principle, the repro steps are fairly straightforward: run the XDP spinxsk test with eBPF enabled. Here's a command that produces minimal noise, works in the most environments, and enables eBPF: .\tools\spinxsk.ps1 -SuccessThresholdPercent 1 -XdpmpPollProvider FNDIS -EnableEbpf

@mtfriesen is this issue still seen the XDP CI tests?

Nope. I'm on a 0.9.0 build and haven't root caused any bugs to eBPF. Closing as not repro.


Suggestion: Adding some sort of progress output

At the moment the product doesn't provide any progress, there is no way to know if you are 10% through, 50% through or 99% through
The output given to the user is either nothing (if there are no unexpected outcome) or very noisy (if there is a lot of unexpected outcome)
Since the code knows how many file (json) payloads there are, the product can know where it is ... at one progress it is ... Also it can provide some sort of ETA based on previous progress
If you wish I can develop this and offer a PR for it

Relevant code area: all_files_list
This variable knows what payloads we have

Note the best solution, but it works:
completed_list = {}

def progress_result(all_files_list):
    """"""
    start_time = datetime.datetime.now()
    while True:
        total = len(all_files_list)
        left = len(all_files_list) - len(completed_list.keys())
        elapsed = datetime.datetime.now() - start_time
        time_left = 0
        if total - left > 0:
            time_left = elapsed.seconds / (total - left) * left
        if left <= 0:
            print("done")
            break

        print(f"{left}/{total} {(1 - left/total) * 100.0:.2f}%, eta: {time_left:.2f}s")
        time.sleep(1)

        background_progress = threading.Thread(target=progress_result, args=[all_files_list])
        background_progress.start()
        pool = ThreadPool(processes=self.threads)
        pool.map(send_payload, all_files_list)

        def send_payload(json_path):
            try:
                # init
                completed_list[json_path] = 1

would you love  to please show me how the tool actually works please...like the details

@contentgap I am bit confused, your response is related to my suggestion? or in general about the tool? if it is in general about the tool - its best to open a new issue

At the moment the product doesn't provide any progress, there is no way to know if you are 10% through, 50% through or 99% through
The output given to the user is either nothing (if there are no unexpected outcome) or very noisy (if there is a lot of unexpected outcome)
Since the code knows how many file (json) payloads there are, the product can know where it is ... at one progress it is ... Also it can provide some sort of ETA based on previous progress
If you wish I can develop this and offer a PR for it

Thanks for your efforts to make the tool more convenient to use. We implemented the progress bar with ETA (https://github.com/nemesida-waf/waf-bypass/commit/1fd6b5a5c388656548d14c1a9dd457bda6ec9421)


add createDocumentFragment

I saw, that u have this function, that TinyDom is missing, so i'll just grab it :+1:


Fix issue with build-images and deploy not working with Docker if optional buildContext field is not set in Devfile (#5600)

What type of PR is this:
/kind bug
What does this PR do / why we need it:
This makes the build context directory for Docker (and Podman) default to the Devfile parent directory, if not set.
Which issue(s) this PR fixes:
Fixes #5600
PR acceptance criteria:

[x] Unit test

[x] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:
See reproduction steps detailed in https://github.com/redhat-developer/odo/issues/5600#issue-1184803587

/approve

/override ci/prow/v4.10-integration-e2e
Looks like infra problems on Prow, and IBM Cloud tests are passing.

/test v4.10-integration-e2e


alias_method_chain depricated

When using with rails 5 on ruby 2.2.3 the following deprication warning is thrown many times:
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super.

Seems this is fixed in https://github.com/bootstrap-ruby/rails-bootstrap-forms/pull/248

But not merged.

DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from block in class:FormBuilder at /Users/geoff/.rvm/gems/ruby-2.3.0@rails5.0/gems/bootstrap_form-2.3.0/lib/bootstrap_form/form_builder.rb:45)
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from block in class:FormBuilder at /Users/geoff/.rvm/gems/ruby-2.3.0@rails5.0/gems/bootstrap_form-2.3.0/lib/bootstrap_form/form_builder.rb:58)
Please merge the fix ...


Prepare the presentation

link: https://docs.google.com/presentation/d/16klJSjY_S7CYJuov1-jTsfI6KzVML9wJJbKdxlezVNo/edit?usp=sharing

I prepared 3 slides about process supervision, threat model and theory of change


CI: Suite-k8s-1.11.K8sHubbleTest Hubble Observe Test L3/L4 Flow

CI failure
All four Hubble tests fail with different errors, but likely the same (to be determined) root cause.
The cilium pod logs contain the following two concerting messages:
Full event queue:
2020-05-22T14:50:29.146653075Z level=debug msg="Per listener queue is full, dropping message" subsys=hubble

Invalid monitor events:
2020-05-22T14:50:29.154307639Z level=debug msg="failed to decode payload" data="[]" error="empty data" subsys=hubble

Suite-k8s-1.11.K8sHubbleTest Hubble Observe Test L3/L4 Flow
/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:471
hubble-cli-rnq7z/hubble-cli-rnq7z cannot curl metrics "<IP_ADDRESS>"
Expected command: kubectl exec -n kube-system hubble-cli-rnq7z -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 8 <IP_ADDRESS>:9091/metrics -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To succeed, but it failed:
Exitcode: 7
Stdout:
 	 time-> DNS: '0.000020()', Connect: '0.000000',Transfer '0.000000', total '3.061013'
Stderr:
 	 command terminated with exit code 7

/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/hubble.go:175

Suite-k8s-1.11.K8sHubbleTest Hubble Observe Test L3/L4 Flow with hubble-relay
/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:471
hubble observe query timed out on "Exitcode: 1 \nStdout:\n \t \nStderr:\n \t time=\"2020-05-22T14:50:46Z\" level=fatal msg=\"main program execution encountered a fatal error\" error=\"failed to dial grpc: context deadline exceeded\"\n\t command terminated with exit code 1\n\t \n"
Expected
    <*errors.errorString | 0xc000c46cc0>: {
        s: "Expected string \"L3_L4\" is not in the filter output of \"{$.Type}\": 10s timeout expired",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/hubble.go:191

Suite-k8s-1.11.K8sHubbleTest Hubble Observe Test L7 Flow
/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:471
kube-system/hubble-cli-rnq7z cannot curl metrics "<IP_ADDRESS>"
Expected command: kubectl exec -n kube-system hubble-cli-rnq7z -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 8 <IP_ADDRESS>:9091/metrics -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To succeed, but it failed:
Exitcode: 7
Stdout:
 	 time-> DNS: '0.000018()', Connect: '0.000000',Transfer '0.000000', total '3.060095'
Stderr:
 	 command terminated with exit code 7

/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/hubble.go:215

Suite-k8s-1.11.K8sHubbleTest Hubble Observe Test L7 Flow with hubble-relay
/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:471
hubble observe query timed out on "Exitcode: 1 \nStdout:\n \t \nStderr:\n \t time=\"2020-05-22T14:52:47Z\" level=fatal msg=\"main program execution encountered a fatal error\" error=\"failed to dial grpc: context deadline exceeded\"\n\t command terminated with exit code 1\n\t \n"
Expected
    <*errors.errorString | 0xc000d3f6b0>: {
        s: "Expected string \"L7\" is not in the filter output of \"{$.Type}\": 10s timeout expired",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-K8s-oldest-net-next/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/hubble.go:234

https://jenkins.cilium.io/job/Cilium-PR-K8s-oldest-net-next/341/
6536e85f_K8sHubbleTest_Hubble_Observe_Test_L3-L4_Flow.zip

Duplicate of #11699


Build Progress Bar component

Reference: https://flowbite.com/docs/components/progress/

https://github.com/themesberg/flowbite-react/pull/20


Update to Racket 6.9

Since Rosette updated to Racket 6.9 with a few bug fixes.

In progress.

@Mestway 👍


Migrate to the new JS interop layer once it's released

It looks like at some point (.NET 7?) a new JS interop layer will be introduced:

https://github.com/dotnet/runtime/pull/66304
https://github.com/dotnet/runtime/pull/71332

They merged those PR's and added samples of the new interop usage https://github.com/dotnet/runtime/pull/74371

I've looked into the new interop a bit and found an issue which I believe is blocking the migration: the new interop uses source generators, while our solution also generates stuff and it's currently not possible to chain them. It looks like the feature is being considered, but not in the works yet (https://github.com/dotnet/roslyn/issues/57239), so it may take a while.


Json->prepare() should have check on valid json_encode

It took a while to find out why a controller action returned false but it was something in an array that could not be converted to a json. The line $content = json_encode($content) made $content = false.
json_last_error_msg() says "Malformed UTF-8 characters, possibly incorrectly encoded". Something with encoding but I am sure my database table is in UTF8 and all scripts are too. Will look into this.

Hmm, please do let me know what caused this. In the meantime, I think I'll throw an Exception in cases like these. Good find regardless!

Fixed in release 0.12.7 :)


[bug] [v2] npm run tauri migrate grants incorrect permissions.

Describe the bug
I ran npm run tauri migrate and npm run tauri dev.
I got this error.
  Permission clipboard-manager:allow-read not found, expected one of ...(snip)... clipboard-manager:allow-clear, clipboard-manager:allow-read-image, clipboard-manager:allow-read-text, clipboard-manager:allow-write-html, clipboard-manager:allow-write-image, clipboard-manager:allow-write-text, clipboard-manager:deny-clear, clipboard-manager:deny-read-image, clipboard-manager:deny-read-text, clipboard-manager:deny-write-html, clipboard-manager:deny-write-image, clipboard-manager:deny-write-text, ...(snip)...

migrate subcommand is generate permission clipboard-manager:allow-read and clipboard-manager:allow-write but available permission is those.

clipboard-manager:allow-read-image
clipboard-manager:allow-read-text
clipboard-manager:allow-write-html
clipboard-manager:allow-write-image
clipboard-manager:allow-write-text

Maybe we need fix this.
https://github.com/tauri-apps/tauri/blob/11aa7743e7a277ed9ec3e92040dc484afe77d261/tooling/cli/src/migrate/config.rs#L503-L505
Reproduction
git clone http://github.com/mikoto2000/scab-player
cd scab-player
npm i @tauri-apps/cli@next @tauri-apps/api@next
npm run tauri migrate
npm run tauri dev

Expected behavior
This error should not occur.

Thank you for fixing!


FOPTS-228 Added a filter at instances for free SQL2017 Developer version in Azure VM

Description
Added a filter to exclude SQL Server 2017 instances that Microsoft Azure Virtual Machines provides as free
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

Oh Tatiana you are so right. i do the changes now.

Aside of comments, you're missing some data in your PR:

"Issues Resolved" is empty.
You didn't check any checkbox in "Contribution Check List".
There are no labels, you need to put some labels, I recommend "enhancement".
Add few reviewers.

Also, you forgot to update template's version and put your changes in CHANGELOG.md.

Thank you Jorge, ill do the changes


Error: [InjectManifest] 'rollupFormat' property is not expected to be here.

@vite-pwa/sveltekit: 0.2.8
vite-plugin-pwa: 0.16.7
workbox-build: 7.0.0
I am posting here as the issue appears to be in the build process options in this repository and not the sveltekit plugin package.
I am getting an error attempting a production build with injectManifest strategy with injectManifest.rollupFormat: 'iife'. If I remove rollupFormat: 'iife' from my build options then I instead get a runtime error in the browser because the SW is built as a module but workbox-window is using the 'classic' type to register the SW.
Investigating workbox-build source it appears injectManifest.rollupFormat does not exist and that they added a JSON schema validation of the options, resulting in an error. vite-plugin-pwa is looking for this option to control when to build the SW in iife or es format link.
Separate, related issue: workbox-window is being passed type: 'classic' unless devOptions override it but in the ./src/options.ts:resolveOptions devOptions.type is set to 'classic' when viteConfig.command !== 'serve' link so it does not appear to be possible to have workbox-window use type: 'module' in production from this plugin's virtual modules.
These 2 issues seem to be resulting it not being possible to create a working injectManifest production build with workbox-build 7, which is the listed peerDependency.
// vite.config.ts
const config: UserConfig = {
  ...
  plugins: [
    sveltekit(),
    SvelteKitPWA({
      minify: false,
      srcDir: './src',
      mode: process.env.NODE_ENV === 'development' ? 'development' : 'production',
      strategies: 'injectManifest',
      filename: 'sw.ts',
      useCredentials: true,
      injectRegister: false,
      manifest: {...},
      injectManifest: {
        rollupFormat: process.env.NODE_ENV === 'development' ? 'es' : 'iife',
        globPatterns: ['client/**/*.{js,css,ico,png,svg,webp,woff,woff2}'],
      },
      devOptions: {
        enabled: true,
        type: 'module',
        navigateFallback: '/',
      },
    }),
  ],
}

// app.ts
  import { useRegisterSW } from 'virtual:pwa-register/svelte'

  const {} = useRegisterSW({...})

Stacktrace:
error during build:
Error: [InjectManifest] 'rollupFormat' property is not expected to be here. Did you mean property 'globFollow'?
    at validate (/<path>/node_modules/workbox-build/build/lib/validate-options.js:52:11)
    at validateInjectManifestOptions (/<path>/node_modules/workbox-build/build/lib/validate-options.js:121:32)
    at injectManifest (/<path>/node_modules/workbox-build/build/inject-manifest.js:55:74)
    at Object.handler (file:///<path>/node_modules/@vite-pwa/sveltekit/dist/index.mjs:189:37)
    at async PluginDriver.hookParallel (file:///<path>/node_modules/rollup/dist/es/shared/node-entry.js:25461:17)
    at async Object.close (file:///<path>/node_modules/rollup/dist/es/shared/node-entry.js:26721:13)
    at async build (file:///<path>/node_modules/vite/dist/node/chunks/dep-df561101.js:48021:13)
    at async CAC.<anonymous> (file:///<path>/node_modules/vite/dist/node/cli.js:822:9)

@meticoeus the service worker is built now by SvelteKit, since you're are include rollupFormat, vite-pwa-plugin will just provide that configuration to workbox-build module, remove rollupFormat from injectManifest option.
If you want file an issue in PWA Sveltekit repo.

SvelteKit version?

ok, build plugin is not used, should be excluded here: https://github.com/vite-pwa/sveltekit/blob/main/src/plugins/SvelteKitPlugin.ts#L100-L105

We can build for production the example in the repo. If you want to register your service worker using type module, you can add your own logic, here the source code: https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/client/build/register.ts

Sveltekit version: 1.20.2
I made a local copy of https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/client/build/register.ts for now so I can use type: module as a workaround.
I'm using this plugin to build a custom service worker that works in development. Last I checked, the Sveltekit serviceworker build didn't work in development and my app has heavy offline based functionality that requires that serviceworker always exists or many parts of the app don't work.

add this to your pwa options: devOptions: { enabled: true, type: 'module' } https://vite-pwa-org.netlify.app/guide/development.html

The offline mode will not work in dev, try build + preview in your local.

To clarify, I'm testing the serviceworker in dev mode which works perfectly. I'm not testing the offline caching of the page assets, just other functionality of the serviceworker which includes fetch interception and retrieval of local data from indexeddb.

This is actually an x-y problem. I've posted https://github.com/vite-pwa/sveltekit/issues/72 with the actual problem I was tying to solve by using rollupFormat, which was working in an earlier version of this plugin.


full screen mode

Might not seem a useful thing standalone, but when a showterm is embedded as an iframe in another page, this feature becomes pretty useful.

Can we make a deployment?

@prongs Can we hide the [ ] buttons when in an iframe, they don't work.

(but otherwise everything's deployed, thanks again!)


Create an advert for Stackoverflow's free open-source advertising

See here
May link to #33

I did my best: https://meta.stackoverflow.com/a/363095/50151
Please vote for ConTabs!