ue4-docker build 4.22.1 fails on Windows, not enough space, but have plenty

Output of the ue4-docker info command:
PS C:\Users\a_selivanov> ue4-docker info
ue4-docker version:         0.0.31 (latest available version is 0.0.32)
Operating system:           Windows 10 Enterprise Version 1809 (OS Build 17763.503)
Docker daemon version:      18.09.2
NVIDIA Docker supported:    No
Maximum image size:         1000GB
Available disk space:       1.33 TiB
Total system memory:        63.95 GiB physical, 73.45 GiB virtual
Number of processors:       6 physical, 12 logical

Output of the docker info command:
PS C:\Users\a_selivanov> ue4-docker info
ue4-docker version:         0.0.31 (latest available version is 0.0.32)
Operating system:           Windows 10 Enterprise Version 1809 (OS Build 17763.503)
Docker daemon version:      18.09.2
NVIDIA Docker supported:    No
Maximum image size:         1000GB
Available disk space:       1.33 TiB
Total system memory:        63.95 GiB physical, 73.45 GiB virtual
Number of processors:       6 physical, 12 logical
PS C:\Users\a_selivanov> docker info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 49
Server Version: 18.09.2
Storage Driver: windowsfilter
 Windows:
Logging Driver: json-file
Plugins:
 Volume: local
 Network: ics l2bridge l2tunnel nat null overlay transparent
 Log: awslogs etwlogs fluentd gelf json-file local logentries splunk syslog
Swarm: inactive
Default Isolation: hyperv
Kernel Version: 10.0 17763 (17763.1.amd64fre.rs5_release.180914-1434)
Operating System: Windows 10 Enterprise Version 1809 (OS Build 17763.503)
OSType: windows
Architecture: x86_64
CPUs: 12
Total Memory: 63.95GiB
Name: BY1-CABuilds-01
ID: ZAXJ:OC2L:MUXM:QHW3:J4SD:KVW7:KIO6:UY57:GEVO:73PA:J33L:ZQS2
Docker Root Dir: e:\docker_windows
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: -1
 Goroutines: 26
 System Time: 2019-05-31T14:29:17.4748918+03:00
 EventsListeners: 1
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false
Product License: Community Engine

Docker daemon settings
{
  "registry-mirrors": [],
  "insecure-registries": [],
  "debug": true,
  "log-level": "debug",
  "experimental": false,
  "group": "docker-users",
  "data-root": "e:\\docker_windows",
  "storage-opts": [
    "size=1000G"
  ]
}

PS D:\juyd> ue4-docker build 4.22.1 --no-engine
[ue4-docker build] WINDOWS CONTAINER SETTINGS
[ue4-docker build] Isolation mode:               process
[ue4-docker build] Base OS image tag:            ltsc2019 (host OS is Windows 10 version 1809)
[ue4-docker build] Memory limit:                 No limit
[ue4-docker build] Detected max image size:      1000GB
[ue4-docker build] Directory to copy DLLs from:  C:\Windows\System32

[ue4-docker build] GENERAL SETTINGS
[ue4-docker build] Not excluding any Engine components.

Retrieving the Git credentials that will be used to clone the UE4 repo
Username: xxxxx
Password:

[ue4-docker build] Image "adamrehn/ue4-build-prerequisites:ltsc2019" exists and rebuild not requested, skipping build.

[ue4-docker build] Image "adamrehn/ue4-source:4.22.1-ltsc2019" exists and rebuild not requested, skipping build.

[ue4-docker build] User specified `--no-engine`, skipping ue4-engine image build.

[ue4-docker build] Building image "adamrehn/ue4-minimal:4.22.1-ltsc2019"...
Sending build context to Docker daemon  11.78kB
Step 1/22 : ARG NAMESPACE
Step 2/22 : ARG TAG
Step 3/22 : ARG PREREQS_TAG
Step 4/22 : FROM ${NAMESPACE}/ue4-source:${TAG}-${PREREQS_TAG} AS builder
 ---> e37c1dde37fb
Step 5/22 : COPY set-changelist.py C:\set-changelist.py
 ---> Using cache
 ---> 1d2ad652ec17
Step 6/22 : RUN python C:\set-changelist.py C:\UnrealEngine\Engine\Build\Build.version && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.
 ---> Using cache
 ---> 97567c285356
Step 7/22 : COPY patch-filters-xml.py C:\patch-filters-xml.py
 ---> Using cache
 ---> 7bda3ec53ae2
Step 8/22 : RUN python C:\patch-filters-xml.py C:\UnrealEngine\Engine\Build\InstalledEngineFilters.xml && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.
 ---> Using cache
 ---> d9b235cdc8a8
Step 9/22 : ARG EXCLUDE_DEBUG
 ---> Using cache
 ---> a50abc80641b
Step 10/22 : ARG EXCLUDE_TEMPLATES
 ---> Using cache
 ---> dccca9f0d92f
Step 11/22 : WORKDIR C:\UnrealEngine
 ---> Using cache
 ---> 61b6ef03342c
Step 12/22 : COPY exclude-components.py C:\exclude-components.py
 ---> Using cache
 ---> ee9f8c7c5404
Step 13/22 : RUN .\Engine\Build\BatchFiles\RunUAT.bat BuildGraph -target="Make Installed Build Win64" -script=Engine/Build/InstalledEngineBuild.xml -set:HostPlatformOnly=true &&       python C:\exclude-components.py C:\UnrealEngine\LocalBuilds\Engine\Windows %EXCLUDE_DEBUG% %EXCLUDE_TEMPLATES% && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.
 ---> Using cache
 ---> dbe74ba33173
Step 14/22 : RUN C:\copy.py C:\legacy-toolchain-fix.py C:\UnrealEngine\LocalBuilds\Engine\Windows\ && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.
 ---> Using cache
 ---> af9a88661d7c
Step 15/22 : FROM adamrehn/ue4-build-prerequisites:${PREREQS_TAG}
 ---> f1f0f943c9ec
Step 16/22 : COPY --from=builder C:\UnrealEngine\LocalBuilds\Engine\Windows C:\UnrealEngine
failed to copy files: failed to copy directory: write \\?\Volume{e1132e0a-82f1-11e9-ab9d-83e292795455}\UnrealEngine\Engine\Plugins\MovieScene\ActorSequence\Binaries\Win64\UE4Editor-ActorSequence.pdb: There is not enough space on the disk.
[ue4-docker build] Error: failed to build image "adamrehn/ue4-minimal:4.22.1-ltsc2019".

The images produced:
PS D:\juyd> docker images
REPOSITORY                               TAG                                IMAGE ID            CREATED             SIZE
<none>                                   <none>                             af9a88661d7c        16 hours ago        196GB
adamrehn/ue4-source                      4.22.1                             e37c1dde37fb        22 hours ago        65.6GB
adamrehn/ue4-source                      4.22.1-ltsc2019                    e37c1dde37fb        22 hours ago        65.6GB
adamrehn/ue4-build-prerequisites         ltsc2019                           f1f0f943c9ec        23 hours ago        23.7GB
<none>                                   <none>                             e541245ddfb6        24 hours ago        9.21GB
mcr.microsoft.com/dotnet/framework/sdk   4.7.2-windowsservercore-ltsc2019   e3f5f2230c2e        9 days ago          7.76GB

This is the exact same error message produced as that seen when using a version of Docker with the 8GB copy limit bug, although 18.09.2 should include the bugfix. The solution when working with those older Docker versions was to exclude debug symbols, which reduced the overall filesize enough to fall below the 8GB limitation. Out of interest, could you please re-run the build with the flag --exclude debug and see if that still results in the same error message?

Thanks for the fast reply! Sure, will try and report.

Everything is fine, took quite some time to build though. However the fix dated 2018 it seems that it is still not in 18.09.02 (or there is another similar bug). Thanks!
Successfully built 6a04c6ce796d
Successfully tagged adamrehn/ue4-full:4.22.1-ltsc2019
Successfully tagged adamrehn/ue4-full:4.22.1
[ue4-docker build] Built image "adamrehn/ue4-full:4.22.1-ltsc2019" in 20 minutes and 37.2 seconds

[ue4-docker build] Total execution time: 6 hours, 31 minutes and 45.97 seconds

Thanks for testing that. Presumably the fix landed in 18.09.3 then. That's rather frustrating that the latest stable version of Docker for Windows still includes an old version with the bug, since users under Windows Server are already able to update to 18.09.6, which works fine. I've updated the docs to include the relevant information for anyone who might encounter this issue prior to the next release of Docker for Windows.

18.09.6, which works fine. I've updated the docs to include the relevant information for anyone who might encounter this issue prior to the next release of Docker for Windows.

@adamrehn Heads up, the documentation lists 18.09.0 not 18.09.6
The patch that fixes this bug was included in Docker CE 18.09.0, but does not appear to be present in all subsequent builds.

@dskvr that text is still accurate. The bugfix linked by that text was in fact merged into the upstream source code for Docker CE version 18.09.0, but didn't appear to be present in Windows builds until sometime later. Although I know from testing that 18.09.6 seems to include the fix, I don't know for certain which point release was the first that actually contained it under Windows (there's every possibility that it might've been 18.09.3, as suggested above.) The best way to determine whether a given version suffers from the bug is to run ue4-docker diagnostics 8gig, which is what the documentation now suggests.


Make Falcor Routes for semester

Implement the Falcor routes for semesters for teams

Correct me if I'm wrong but it appears this has already been done?

Hmm I think getter routes have been made but not setters, correct?

Ah yes! I'll get on it :)


Create a readme.md for this project

Can I work on this under the GSOC label?

Sure you can work on it. But this issue is not releated to GSOC.

Sure you can work on it. But this issue is not releated to GSOC.

okay thanks

Hi @anubhav1206 are you working on this?

Unassigning @anubhav1206 due to inactivity.


Added default values in User and Question models

Added default values, unique and allowed null in models of User and Question

change type of answer back to string (from JSON)


⚠ Bofrost.lu has degraded performance

In cd1d699, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 969 ms

Resolved: Bofrost.lu performance has improved in b81963b.


Result on the Argoverse 2 leaderboard

Hi,  thank you for releasing the codebase.
I was wondering if you could kindly clarify the following questions?

it seems the leaderboard result is much better than the reported values in the paper (e.g., EPE-3way). would you mind sharing some info on how you made this happen?
I have found several checkpoints. One is available at deflow discussion on leaderboard result , denoted as "seflow_official", and another one is refered to as "seflow_best" available at seflow_repo.  Could you pleae let me know the differences between these two?
If I were about to make a comparison, let us say using the 1x setup without extra data, which one is to use?

I look forward to your reply. Many thanks in advance.

Hi, there is a note in the README: https://github.com/KTH-RPL/SeFlow?tab=readme-ov-file#other-benchmark-models

The paper result is under 2e-6 and epoch 50 to have fair ablation study with same setup on ZeroFlow since we directly use their weight.
seflow_official is the weight I used in the paper result and leaderboard v1 result (since when I'm writing the paper, leaderboard v2 haven't published yet). And seflow_best is the weight I trained with the note said and the result in leaderboard version 2 (we also mentioned this in updated supplementary material.) config: 2e-4 and epoch 20. You can find that also using torch.load(model), all configs are saved in the model weight.
Personally, I will say use the result on the leaderboard and the file name is seflow_best.ckpt.

Thank you for the clarification. Fair points.
One additional question: does the best result on benchmark follow a 1x or 2x setup?

1x dataset size for all results in both leaderboards (v1, v2).


BladeCompiler#compileStatements is never called

I have a package that extends Blade with a directive, but it is not replacing it when the view is rendered.
I've checked the source code and noticed that it is done by the method BladeCompiler#compileStatements.
But when I search for this method in the source code, I noticed that it never gets called, is it right ?

Never mind, just saw how it gets called.

In case anyone else stumbles upon this, make sure to clear your cached views when trying to test your custom directive.


chore: performance monitor

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
Added New Analytics section called performance monitor which includes chart for
Payment Distribution By Connector
Payment Distribution By Payment Method
Connector Wise Payment Failure
Method Wise Payment Failure
Connector + Payment Method Wise Payment Failure

Motivation and Context

How did you test it?
It can't be tested as of now.Its disabled with feature flag performance_monitor

Where to test it?

[ ] INTEG
[ ] SANDBOX
[ ] PROD

Checklist

[ ] I ran npm run re:build
[ ] I reviewed submitted code
[ ] I added unit tests for my changes where possible

Please add Title and subtitle to the page
Borders to the charts to maintain consistency with analytics of other pages
Right align the cards at the same line as the 2nd row is overflowing a bit
Gap consistency
Section heading (to be discussed)

This will be addressed by @sagarnaikjuspay


Documentation does not match implementation (generate typescript)

https://microsoft.github.io/kiota/get-started/typescript.html says
You can then use the Kiota command line tool to generate the SDK classes.

kiota generate -l typescript -d getme.yml -c GetUserApiClient -o ./client

I tried (using the binary install for osx-x64.zip) and got an error.
Unrecognized command or argument 'generate'.

The generate command is not recognized. Should be:
kiota -l typescript -d getme.yml -c GetUserApiClient -o ./client

(BTW, osx is no longer valid (on https://github.com/microsoft/kiota/releases/tag/v0.5.1 ) , it is "macOS" (or macos); i.e. MacOS Monterey is version 12, not 10/X)

Hi @DavidBiesack ,
Thanks for trying out kiota.
The documentation is in advance compared to the version you're using because we have not released those changes yet.
Just remove the generate keyword from the command and it should work. Or clone and build kiota locally until we release it.
I'm not sure I understand the comment regarding OSX, would you mind providing more details please?

Hey @DavidBiesack Long time no chat.  Sorry you hit this mismatch between docs and deployment.  We had to add a generate command because we are in the process of adding a number of other commands that help with the process of finding and filtering OpenAPI descriptions.  Hopefully, we won't make big changes to the commands like this again.

Thanks for the clarification.
This is driven by the dotnet rid in this worfklow
https://github.com/microsoft/kiota/blob/8f7189ea682c2636e480f7e61c5a0c9cb34d8f5d/.github/workflows/create-release.yml#L24
Before we change it, what's the impact of having an older denomination? Would people feel like this binary is not for them?

And also would mac catalyst make more sense? (https://github.com/dotnet/runtime/blob/3e347d7c70713277369d044212489d4b82936748/src/libraries/Microsoft.NETCore.Platforms/src/runtime.json#L2178)
(might only become available once dotnet 7 GAs)

Update: we've released the latest version of kiota. Now the binaries match the documentation.


Fix weave-net CNI plugin to respect podSubnet

Fix weave-net CNI plugin to respect podSubnet

/cherrypick release/v0.9


Broadcast endpoint

Codecov Report

Merging #8 into master will decrease coverage by 4.69%.
The diff coverage is 50%.

@@           Coverage Diff            @@
##           master      #8     +/-   ##
========================================
- Coverage     100%   95.3%   -4.7%
========================================
  Files          17      18      +1
  Lines         309     341     +32
========================================
+ Hits          309     325     +16
- Misses          0      16     +16

Impacted Files
Coverage Δ

app/routes.py
100% <100%> (ø)
:arrow_up:

app/broadcast.py
48.38% <48.38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821faee...b81459c. Read the comment docs.


V3: this._modal.renderCancelling() is still invoked when modal is set to false.

We've encountered a breaking issue in v3 of the SDK that occurs when cancelling an upload if the modal parameter is set to false for custom progress rendering.  An error will be thrown by this._modal.renderCancelling() as it is not wrapped in a conditional to prevent it from being invoked when modal is false, and the modal object will then be undefined.
I've submitted PR #53 to resolve the issue, but until it is merged we'll need to continue using a forked custom build of the SDK with this hotfix included.
Thanks in advance!

I merged this just now. I am working on another (minor) patch for something else and will make a new release tonight.
Thank you for the reminder. I was on vacation last week and only saw the PR now. 👍


throwing apollo-errors from scalar resolvers with graphql-js >= 0.8.0 doesn't work

As seen here: https://github.com/graphql/graphql-js/issues/821
There appears to have been a breaking change with scalar resolver error handling

Closing.  This is off-spec from latest GraphQL, and should be considered an anti-pattern moving forward


Change TokenFilter trait to simplify (a bit) the boxing of filters

I have a preference for this PR instead of this one: #2096
The main difference is that I changed the TokenFilter to make it independent of the Tokenizer trait as a TokenFilter should be defined only by the input token stream and its output token stream.
The main benefit compared to #2096 is that it avoids creating a BoxTokenizer and implementing the Tokenizer trait on it... it does not seem to be a substantial benefit but... except it is cleaner. For example in #2096, I tried to bypass BoxTokenizer and implemented the Tokenizer trait directly on Box<dyn BoxableTokenizer>, but I  got stack overflow as I was calling recursively the same method box_token_stream but the compiler did not tell me anything...
Bench results:
cargo bench --bench analyzer
    Finished bench [optimized + debuginfo] target(s) in 0.12s
warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.22.0
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
     Running benches/analyzer.rs (target/release/deps/analyzer-2a32537b8a3b3efa)
Gnuplot not found, using plotters backend
default-tokenize-alice  time:   [874.40 µs 875.34 µs 876.63 µs]
                        change: [-2.0579% -1.8172% -1.5706%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 16 outliers among 200 measurements (8.00%)
  8 (4.00%) high mild
  8 (4.00%) high severe

default-dynamic-tokenize-alice
                        time:   [1.1158 ms 1.1165 ms 1.1173 ms]
                        change: [-1.9267% -1.6803% -1.4354%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 200 measurements (4.00%)
  2 (1.00%) high mild
  6 (3.00%) high severe

I also ran the benchmark on tantivy 0.19 before the introduction of GATs, box token streams were used everywhere at that time.
default-tokenize-alice  time:   [1.0371 ms 1.0376 ms 1.0383 ms]

So we have a performance regression on the box token filters unfortunately.

Codecov Report

Merging #2101 (f6a6b4a) into main (3b0cbf8) will increase coverage by 0.03%.
The diff coverage is 97.02%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   94.39%   94.42%   +0.03%
==========================================
  Files         321      321
  Lines       60612    60612
==========================================
+ Hits        57213    57235      +22
+ Misses       3399     3377      -22

Impacted Files
Coverage Δ

src/core/segment_reader.rs
90.57% <0.00%> (ø)

src/lib.rs
99.05% <ø> (ø)

src/query/more_like_this/more_like_this.rs
65.91% <0.00%> (+0.24%)
:arrow_up:

src/tokenizer/mod.rs
97.84% <ø> (ø)

src/tokenizer/tokenizer.rs
95.55% <98.38%> (+2.87%)
:arrow_up:

src/directory/ram_directory.rs
90.50% <100.00%> (ø)

src/indexer/segment_updater.rs
95.31% <100.00%> (-0.14%)
:arrow_down:

src/indexer/segment_writer.rs
97.87% <100.00%> (ø)

src/postings/serializer.rs
98.95% <100.00%> (ø)

src/tokenizer/alphanum_only.rs
98.43% <100.00%> (+5.58%)
:arrow_up:

... and 7 more

... and 3 files with indirect coverage changes

HDFS benchmark
tantivy 0.19:
index-hdfs/index-hdfs-no-commit
                        time:   [329.88 ms 332.48 ms 335.11 ms]
                        thrpt:  [63.766 MiB/s 64.272 MiB/s 64.777 MiB/s]
index-hdfs/index-hdfs-with-commit
                        time:   [473.94 ms 478.03 ms 482.20 ms]
                        thrpt:  [44.315 MiB/s 44.703 MiB/s 45.088 MiB/s]

tantivy main-branch, with default tokenizer built with boxed token filters, this is mostly equivalent to what was in tantivy 0.19
index-hdfs/index-hdfs-no-commit
                        time:   [286.20 ms 288.50 ms 290.75 ms]
                        thrpt:  [73.495 MiB/s 74.068 MiB/s 74.665 MiB/s]
index-hdfs/index-hdfs-with-commit
                        time:   [419.36 ms 422.07 ms 424.78 ms]
                        thrpt:  [50.306 MiB/s 50.629 MiB/s 50.956 MiB/s]

tantivy main-branch, with default tokenizer
index-hdfs/index-hdfs-no-commit
                        time:   [221.96 ms 224.18 ms 226.59 ms]
                        thrpt:  [94.309 MiB/s 95.320 MiB/s 96.276 MiB/s]
index-hdfs/index-hdfs-with-commit
                        time:   [352.42 ms 354.94 ms 357.60 ms]
                        thrpt:  [59.756 MiB/s 60.205 MiB/s 60.635 MiB/s]

If I understand the PR correctly, this attempts to get a best of two world situation.
The TextAnalyzerBuilder makes it possible to have a statically linked chain of tokenizers... but it also makes it possible to append a list of dynamic Box. Correct?
You mentioned you are seeing a regression, how do we explain it?

closing in favor of #2110


Pretrained CSRNet

Hey,
By pretrained CSRNet, do you mean Imagenet pretrained Vgg16 layers plus random initialization for rest of the CSRNet layers ? (Looks like the pretrained net is trained on world expo. If that's the case, could you please share the pretrained net as well ? )
Thanks,
Viresh

Hi,
The pretrained CSRNet here refers to the model trained on the WorldExpo'10 dataset and we do have plans for releasing the models for now. However, the pretrained model can be generated using any of the following implementations.

https://github.com/leeyeehoo/CSRNet-pytorch
https://github.com/gjy3035/C-3-Framework

Got it. Thanks !


Added University of South Asia

Institution Name
University of South Asia
Instiution Website
http://www.southasia-uni.org/
IT related course URL
http://www.southasia-uni.org/faculty.php?sub=bcse
http://www.southasia-uni.org/faculty.php?sub=bcsit
Email Users

[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels

[ ] Post-graduate research
[x] Graduate School
[x] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@mdsahib I am sorry for a delay with processing your request.
Pull request merged. Thank you!


Running dotnet run on http project errors with "Cannot enable wasi-http for core wasm modules"

Tried on both local (MacOS M1) & GitHub Codespaces. Am I doing something wrong?

@Zhiyuan-Amos I fixed this, with a newer wasmtime you need the instruction here:
https://github.com/dev-wasm/dev-wasm-dotnet/blob/main/http/http.csproj#L12
or here:
https://github.com/dev-wasm/dev-wasm-dotnet/blob/main/www-wasi/Makefile#L17


Use container-based infrastructure on Travis CI

Travis CI added Docker container support earlier this year (http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/).
Since we've been using Travis CI before 1/1/2015, we must explicitly enable it.
This gives advantages such as:

builds start within 10 seconds
more resources in each build

Since Docker containers use less resources than VMs, their "fair usage policy" might back off a bit too.

Appears to be working
Using worker: worker-linux-docker-a0751c49.prod.travis-ci.org:travis-linux-5


refactor to status pkg

refactors logic for getting the status of keybase from the client package to status so the a keybase1.FullStatus is a single RPC call the GUI can use. The output changed slightly when using the protocol definitions (casing and a few extra fields) but nothing was lost. tested sending with and without a service.
https://github.com/keybase/keybase/pull/3842

merging over TestSetPhoneNumber flake


How to backup dqlite in ha mode

Hi,
I'm running the ha-mode to test it out. Works great so far. When using the standard mode I backup etcd like:
/snap/microk8s/current/etcdctl \
--endpoints=<IP_ADDRESS>:12379 \
--cacert=/var/snap/microk8s/current/certs/ca.crt \
--cert=/var/snap/microk8s/current/certs/server.crt \
--key=/var/snap/microk8s/current/certs/server.key snapshot save backup.db

Is there an equivalent command to backup dqlite?

Hi @sstubbs
We are packaging a migrator tool with the snap that will take care of data migration and backups from/to etcd and dqlite. There is a PR up [1] that adds the backup-dqlite functionality. It should soon be added to the snap.
[1] https://github.com/ktsakalozos/go-migrator/pull/1/files#diff-7ddfb3e035b42cd70649cc33393fe32cR31

That really is great news. This project is amazing.

Hi,
I just wanted to check when will this be available in the ha-preview snap?


typed temporal values are not excepted even if they are valid

If you type a datetime instead of using the calendar selector, the form marks it as an incorrect format even if it is correct.

Fixed recently here: https://github.com/cznethub/dspfront/commit/d0931c981624c9cdd47b7aeeaa4f47ec102048ef, https://github.com/cznethub/dspfront/commit/8713827bd3480c509479fa9058721f0e1f76bded

Confirming resolved, but test_hs_000008_temporal_coverage_persists is still failing due to #71


⚠ Fetchers has degraded performance

In bb5f2d6, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 480 ms

Resolved: Fetchers performance has improved in 127792d.


helpRequested(visibility: ArgumentParser.ArgumentVisibility(base: ArgumentParser.ArgumentVisibility.Representation.default))

Replace this paragraph with a short description of the incorrect incorrect behavior. If this is a regression, please note the last version that the behavior was correct in addition to your current version.
ArgumentParser version: 0.1.0 or the main branch, for example.
Swift version: Paste the output of swift --version here.
Checklist

[x] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues

Steps to Reproduce
I'm building a commandline tool that runs as root and I'm simply attempting to get the '--help' to present when there are no arguments passed into the command line.
I'm running Macbook Pro M1, Xcode Version 14.2 (14C18) as sudo.
Here is my logic in main.swift
let passedArgs = Array(CommandLine.arguments.dropFirst())
if passedArgs.count == 0 {
    do {
        try _ = argParser.parse(["--help"])
        exit(1)
    } catch {
        print(error)
        print(error.localizedDescription)
        exit(1)
    }
}

Expected behavior
Expecting it to print out the Help/Usage summary of each of the commands.
Actual behavior
Console in Xcode just returns:
helpRequested(visibility: ArgumentParser.ArgumentVisibility(base: ArgumentParser.ArgumentVisibility.Representation.default))
The operation couldn’t be completed. (ArgumentParser.ParserError error 0.)

The parse(_:) method that you're calling either returns a parsed instance of your argParser type or throws an error. Since you're passing the --help flag, it can't produce a parsed instance, so it throws an "error" that indicates that a help request has been made.
Once you catch error, you have a couple options:

You can call argParser.exit(with: error) to print the correct message for the error and exit with an appropriate error code — the help screen and 0, in this case.
You can call argParser.fullMessage(for: error) and argParser.exitCode(for: error) to get the message and error code separately, in case you have additional logic you need.

Alternatively, you can replace all of the code you have there with just argParser.main() or by adding @main to your argParser declaration — printing the help screen is the default behavior when no inputs are passed.


makes step increment work properly in schedulerfuelux

Depends on #1531

I can type in a number that is less than the limit, and it will get rounded down below the "one unit" threshold to 0.  Basically using the "convenience rounding to nearest increment" logic to defeat the "don't go below a single increment unit" logic :).  Its like UI control judo :kimono:

Congratulations @futuremint you have found a spinbox bug! That's unrelated to scheduler and unrelated to this pull request, but, I'm fixing it now anyways :)

:joy_cat: do I get a cookie now?


Get rid of the github-markdown-toc submodule

This package is dangerous because it uses the GitHub API. Because of this, shelldoc will not work in a local network environment.
All that the package does is the table of contents.

Check this: https://github.com/kubernetes-sigs/mdtoc


Hadassah friedlaeder

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1fd980c7-ca28-6e00-58d5-6e5d46ec8021
Version Independent ID: 2dc6f4ee-5dc1-82c9-05fd-dd5cdcafe878
Content: Hadassah Friedlaender font family - Typography
Content Source: typographydocs/font-list/Hadassah-Friedlaender.md
Product: typography
GitHub Login: @nihar
Microsoft Alias: alib

Closing the issue as there were no comments.


Elasticsearch connection does not recover after temp ping error

Problematic scenario when using sessionstore with elasticsearch:
Moment T: All is well, ping always succeeds
Moment T+1: One or a few pings fail, because of temporary elasticseach problems
Moment T+2: Elasticsearch is back up, the pings succeed again, but sessionstore keeps 'thinking' it's not connected and will never recover
Reason:
elasticsearch.js:68 means that a 'connect' event will only be emitted once, after startup and never again, since 'callbacked' will be true after that.
Suggested solution:
At line 68: separately handle the state when 'isConnected' is false, but 'callbacked' is true. In that case, you can just set 'isConnected' back to true and emit another 'connect' event (see code suggestion below). It seems to me that this does not break anything and makes the sessionstore much more robust. My own tests show that this works as expected and sessionstore is now able to recover from temp elasticsearch ping errors. If you like, I can create a PR for this.
if (callbacked) {
  // Already callbacked, so only restore connected status.
  self.isConnected = true;
  self.emit('connect');
} else {
  // Not callbacked yet, perform init logic and handle connected status.

Can you do a PR?

See https://github.com/adrai/sessionstore/pull/40

thx, v1.2.16

Nice, thanks for the quick response and fix-release!


Fix key color equals

Equality function for two KeyColor objects needs to use && instead of ||.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@markschlosseratbentley there is no auto-complete setup currently so you'll need to manually complete this.  I'll be adding a GitHub App that adds that functionality shortly.


RuntimeError: Expected 5-dimensional input for 5-dimensional weight 8 4 3 3 3, but got 4-dimensional input of size [4, 256, 64, 64] instead

Hi,
When I want to train on BraTS2018, I use this command line
"python train_brats2018_new.py"
It shows this problem
Summary train Epoch  1:  Loss:0.7025 	 DSC:29.7528  	Background : 0.8263	NCR/NET : 0.0612	ED : 0.2336	ET : 0.0689
Traceback (most recent call last):
File "train_brats2018_new.py", line 75, in
main()
File "train_brats2018_new.py", line 33, in main
trainer.training()
File "/content/drive/My Drive/MedicalZooPytorch/lib/train/trainer.py", line 38, in training
self.validate_epoch(epoch)
File "/content/drive/My Drive/MedicalZooPytorch/lib/train/trainer.py", line 83, in validate_epoch
output = self.model(input_tensor)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/content/drive/My Drive/MedicalZooPytorch/lib/medzoo/Vnet.py", line 150, in forward
out16 = self.in_tr(x)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/content/drive/My Drive/MedicalZooPytorch/lib/medzoo/Vnet.py", line 58, in forward
out = self.conv1(x)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/conv.py", line 480, in forward
self.padding, self.dilation, self.groups)
RuntimeError: Expected 5-dimensional input for 5-dimensional weight 16 4 5 5 5, but got 4-dimensional input of size [4, 256, 64, 64] instead
Could you help me solve that?

I meet the same problem. Have you fixed it?

Sorry for the late reply, the answer of @wangyaojlu  is correct , there was an error with the shape of the data during validation
It has been updated


Add doc and build workflows to GitHub Actions

Coverage remained the same at 74.975% when pulling 939128c0e54ade18daf9d708f13c2525bf60a7d5 on gh_actions_docs_builds into 0d2291e66886057199d7669e4da152c35551d1ad on master.


Specifications: missing version as a concrete property

Each 3GPP ID has a version, e.g. 0.5.0 in 3GPP TR 36.860-13:Rel-13/0.5.0.
Yet, the 0.5.0 part is not captured anywhere in Relaton data. Could it be in a version, edition or something like that?

According to the official 3GPP metadata, this is the "version":
https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=2564

So we should map this value into version.

i.e. 0.5.0 should appear as the version number.

Fixed in v1.19.2


WinUI Design Toolkit Bug: Frame names on the Controls page could use work

WinUI Toolkit Bug Report

Name of component or part of Toolkit:
Top level frames on the “Controls”  page of 2.6
Describe the bug:
The artboards could have better names. For example, the Button artboard is called “Basic input”. The names can be improved on the first 14 top level frames.
Screenshot:

Version Info:
2.6, duplicated Monday August 30.

Hi Wolfr, the artboards are named this way to help in the hierarchy in choosing controls in the asset library and in the asset instance switcher dialog.

Good to know this is intentional! I learned something new. Thank you.


Api view doesn't work in offilne environment

Rancher Version: 1.1.2
Docker Version: 1.10.3 on thinpool
OS and where are the hosts located? (cloud, bare metal, etc): RHEL7 OpenStack VM
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node w/o internet access
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Try to view in API something
Results:
Blank page
Expected:
Api view oened successfully
As I see it tries to fetch some scripts and assets from internet:
https://releases.rancher.com/api-ui/1.0.4/ui.min.css
https://releases.rancher.com/api-ui/1.0.4/ui.min.js
https://netdna.bootstrapcdn.com/bootstrap/3.1.1/css/bootstrap.min.css
https://netdna.bootstrapcdn.com/bootstrap/3.1.1/js/bootstrap.min.js
https://netdna.bootstrapcdn.com/bootstrap/3.1.1/fonts/glyphicons-halflings-regular.woff
As Rancher support offline setups - it should be bundled inside Rancher server.

This is already changed in 1.2.0-dev1 or 2.


Blame page handles deleted resources

Context:  Create a resource, delete it, restore it, then look at the "Blame" page
Before: "Something went wrong"
After: Silently ignore the deleted version when building the blame page.

Coverage increased (+0.0004%) to 94.392% when pulling b4d602f0c13db5c974e6a9cc1ae2c2e08e2c1000 on cody-blame-handle-deleted-resources into 10931b37acd596f4f3507327228860cae50aca0c on main.


android: ./gradlew build doesn't produce debug.apk and release.apk

Godot version:
master
OS/device including version:
Antergos (Arch Linux)
Issue description:
Only some files are created but no apk.
libgodot.android.opt.armv7.neon.so
libgodot.android.opt.armv8.so
libgodot.android.opt.debug.armv7.neon.so
libgodot.android.opt.debug.armv8.so
libgodot.android.opt.debug.x86.so
libgodot.android.opt.debug.x86_64.so
libgodot.android.opt.x86.so
libgodot.android.opt.x86_64.so

Steps to reproduce:
export ANDROID_HOME=/home/user/Android/Sdk
export ANDROID_NDK_ROOT=/home/user/Android/Sdk/ndk-bundle
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk
scons platform=android target=release android_arch=armv7 -j 8 && scons platform=android target=release android_arch=arm64v8 -j 8 && scons platform=android target=release android_arch=x86 -j 8 && scons platform=android target=release_debug android_arch=armv7 -j 8 && scons platform=android target=release_debug android_arch=arm64v8 -j 8 && scons platform=android target=release_debug android_arch=x86 -j 8 && scons platform=android target=release android_arch=x86_64 -j 8 && scons platform=android target=release_debug android_arch=x86_64 -j 8
cd platform/android/java
./gradlew build

They are now placed in /platform/android/java/build :)
On Mon, 29 Apr 2019 at 4:48 am, Linux User<EMAIL_ADDRESS>wrote:

Godot version:
master
Antergos (Arch Linux)
Issue description:
Only libgodot.android.opt.armv7.neon.so files are created but no apk.
Steps to reproduce:
export ANDROID_HOME=/home/user/Android/Sdk
export ANDROID_NDK_ROOT=/home/user/Android/Sdk/ndk-bundle
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk
scons platform=android target=release android_arch=armv7 -j 8 && scons platform=android target=release android_arch=arm64v8 -j 8 && scons platform=android target=release android_arch=x86 -j 8 && scons platform=android target=release_debug android_arch=armv7 -j 8 && scons platform=android target=release_debug android_arch=arm64v8 -j 8 && scons platform=android target=release_debug android_arch=x86 -j 8 && scons platform=android target=release android_arch=x86_64 -j 8 && scons platform=android target=release_debug android_arch=x86_64 -j 8
cd platform/android/java./gradlew build
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/28498, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO262P76O3SFVUXGYTRJ7TPSXWQVANCNFSM4HI7EAIA
.

--
Kindest regards,
Bastiaan Olij
https://www.facebook.com/bastiaan.olij
https://twitter.com/mux213
https://www.youtube.com/BastiaanOlij
https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw
https://github.com/BastiaanOlij

For the record, the full paths (starting from the Godot repository root) seem to be:
platform/android/java/outputs/debug/apk/java-debug-unsigned.apk
platform/android/java/outputs/release/apk/java-release-unsigned.apk

We should probably readd the move operation that @reduz removed.

@akien-mga So is this still a bug or is it fixed?

The location is just different.

@akien-mga isn't it because of the new android export system?

That's due to this change: https://github.com/godotengine/godot/pull/27781/files#diff-c600d7899bdb2ce4bd039383904a8fb7R100
It seems it was intentional, but I'm not sure why. I guess this build.gradle is also used for custom builds, and thus this no longer makes sense?

not sure but it seems documentation issue for me for 3.2 or later.

on windows I don't find debug or release at
\platform\android\java\build\outputs\apk\debug
and here:
\platform\android\java\build\outputs\apk\release
and not in bin folder either the only files in bin folder are:
libgodot.android.opt.armv7.neon.so
libgodot.android.opt.debug.armv7.neon.so

Same as @wamiqurrehman093 Can't find apks on my mac. just .so files in bin directory.

Finally find them in platform/android/java/app/build/outputs/apk.

See the updated documentation, you have to use gradlew generateGodotTemplates: http://docs.godotengine.org/en/latest/development/compiling/compiling_for_android.html#building-the-export-templates


can bindStream support null values Rxn with firestore?

I am trying to create a stream from firestore.  The stream could return a null value.  It doesn't seem that bindStream allows for this.
The error I get is this:
The argument type 'Stream<List<Property>?>?' can't be assigned to the parameter type 'Stream<List<Property>?>'.dart(argument_type_not_assignable)
It seems bindStream only works with Rx but not Rxn values.  However with firestore my understanding is you will usually receive some null values while the stream is being returned initially.
Any suggestions would be appreciated...
import 'package:get/get.dart';
import 'package:my_app/services/services.dart';
import 'package:cloud_firestore/cloud_firestore.dart';

class PropertyController extends GetxController {
  static PropertyController get to => Get.find();
  Rxn<List<Property>>? propertyList = Rxn<List<Property>>([]);

  @override
  void onInit() {
    propertyList?.bindStream(propertiesStream()); //stream coming from firebase
    super.onInit();
  }

  List<Property>? get properties => propertyList?.value;

  Stream<List<Property>?>? propertiesStream() {
    List<Property> _properties = [];
    FirebaseFirestore.instance
        .collection('properties')
        .snapshots()
        .map((QuerySnapshot query) {
      query.docs.forEach((_property) {
        _properties.add(Property.fromMap(_property.data()));
      });
      //print(_properties.toString());
      return _properties;
    });
  }
}

try
Rxn<List<Property>?>? propertyList = Rxn<List<Property>?>([]);

Thanks... I figured out the trouble finally.  I made an error in my code and forgot one additional return in the firestore call.
Stream<List<Property>> propertiesStream() {
    List<Property> _properties = [];
    return FirebaseFirestore.instance
        .collection('properties')
        .snapshots()
        .map((QuerySnapshot query) {
      query.docs.forEach((_property) {
        _properties.add(Property.fromMap(_property.data()));
      });
      //print(_properties.toString());
      return _properties;
    });
  }


Question: use of distinct in cluster filtering

On line 32 of LSH.scala, is there any need to invoke distinct (just before zipWithIndex)? Each vector can only appear in a band at most once anyway; at least, that's how I understand the control flow (still learning Scala).

Prior to distinct(), the sorted list represents the vectors that hash together during one of the bands. Over the course of the banding executions, some (really similar) vectors may hash together multiple times. We sort the vectors and select only the distinct lists as a way to filter out these duplicate occurrences.
Hope this helps!

For there to be duplicates in the list, the previous operation on line 28 where the bands are generated would have to have fully duplicated elements, where ((band #, hash of minhash list), vector id) are precisely identical multiple times in the model.bands RDD. As far as I can tell, that isn't possible.
(I'm basically trying to do a PySpark port of LSH as a way to familiarize myself with the process, so please forgive me if I'm missing something obvious)

The map operation preceding distinct() strips out (band #, hash of minhash list) so you just get the result of the groupby (last part of line 28).
With the sample dataset and the parameters defined in the readme, you'll see that at the end of map() in line 32 and before distinct() there will be a few duplicates.

I think my point of confusion is that distinct is being invoked on the entire lists of vector ids--that is, if the same list of vector ids is duplicated in the RDD, the duplicates are removed. I previously was interpreting distinct() as eliminating duplicate vector ids in a single list, e.g. [1, 1, 2, 3] -> [1, 2, 3], when the operation that is actually happening is [ [1, 2, 3], [1, 2, 3], [4, 5, 6] ] -> [ [1, 2, 3], [4, 5, 6] ].
Is this accurate?

distinct is applied to the RDD as a whole so you second case is correct.

Awesome, thanks. I may have a working prototype soon for PySpark. I really appreciate your insights.


not available after installation

Hi,
I install Uptime Kuma with your Instruction on my Raspberry 3B+. After install i see this Display in Terminal(below)

The Problem is I dont see the Webinterface on Localhost but the Port 3001 is aviable.
Thanks.
timbo036

You need to provide more info, browser error? Which guide did you follow?

I follow this guide:

My Browser Show this:

apache2 is running

Got same problem. Used same steps

Cannot reproduce, please make sure there was no error during installation and start the server with pure node first:
node server/server.js
The last line should be Listening on 3001

node server/server.js
I try this and Syntax Error

Are you using Node.js >= 14 ?

It's working again. Don't know what fixed the problem.

Are you using Node.js >= 14 ?

it was the node.js version... thank you
closed

I have the same issue, followed the same steps.
But using node server/server.js it gives:
bash: /usr/local/bin/node: No such file or directory
Using Option 2 to start Uptime-Kuma works.

What am I missing?
How to install Node.js using 'apk'?

I have the same issue, followed the same steps. But using node server/server.js it gives: bash: /usr/local/bin/node: No such file or directory
Using Option 2 to start Uptime-Kuma works.
What am I missing? How to install Node.js using 'apk'?

Since you can start pm2, I guess you have installed node.js.
Try to restart your terminal.

I restarted (and reboot command) terminal, restarted HA.
No effect.


Submission table: Long manuscript IDs do not wrap, they cross into next column

Truncate or wrap long manuscript IDs

@jabrah  Example of an ID from JScholarship:
Dev: http://pass:8181/xmlui/handle/1774.2/123456
Live: http://jhir.library.jhu.edu/handle/1774.2/123456
Need to double-confirm with @htpvu but this should be displayed as Manuscript ID "1774.2/37577" with the full ID available on hover-over. AccessUrl will be added.

I can confirm!

@karenhanson @jabrah when you guys got that implemented, please send a screenshot of the result so i can show sayeed before finishing it up. to make sure it's cool with him


2D arrays as inputs to a method generate interfaces with incorrect asterisks in their array definitions

I have a class I want to create a proxy interface/proxy for.  It has a method as below:
public void DoStuff(double input, [Out] double[,] output)         {                 //Do some stuff         }
Upon running the code generation, I get an interface which looks like this:
void DoStuff(double input, double[*,*] output);
which does not compile, and is missing the out keyword.  It might be the combination of the out keyword and the 2D array which is causing the issue - not sure yet.

@FatSwords
The out should work fine : see https://github.com/StefH/ProxyInterfaceSourceGenerator/blob/390093d0076d7541f7363df3227d71e7c0c2cdaf/src-examples/ProxyInterfaceConsumerViaNuGet/PersonProxy2.cs#L61
Did you try your code as:
public void DoStuff(double input, out double[,] output) { //Do some stuff }

BTW: It could be that the problem is 2D array, I'll check this.

https://github.com/StefH/ProxyInterfaceSourceGenerator/pull/55

@FatSwords
It's fixed.
A new version will be released shortly.

Awesome - just got that running and it works a treat - thank you!


The response is too short to extract answer on GPQA. What should I set to extend it?

lm_eval --model local-chat-completions --tasks gpqa_main_cot_zeroshot --model_args model=Qwen/Qwen2-72B-Instruct,base_url=https://api.together.xyz/v1 --output_path ./gpqa/result/Qwen2 --use_cache ./gpqa/cache/Qwen2 --log_samples --limit 10 --gen_kwargs temperature=0.7,max_tokens=8192
Using this command, The Qwen2's result just end sooo weirdly like the image below

To be specific, only 256 tokens are generated. I'm wondering why this happens, is there any problem with max_tokens?

same issue here


added missing s to searchEngine

Super tiny typo in context-menu that throws error when no default search engine is selected. Is just a fallback and will probably never run, but you never know.

Thanks!


Use Thread::Mutex to resolve race condition

The problematic sequence:

Add last line to @buffer
Call flush_buffer in flush_timeout_buffer (via periodical timer)
flush_buffer

Sequence 2 and 3 may race.

has this race otherwise been resolved?

This is very rare case. I cannot reproduce this race condition in my environment.


v2.5.2 does not respect WS_PORT env variable

eth-rpc-adapter v2.5.2 does not respect WS_PORT env variable, it ignores and uses 8545
version         : bodhi.js/eth-rpc-adapter/2.5.2

Version 2.5.0 also brok
But Version 2.4.21 works
Sep 29 11:40:41 m2 bash[1025415]:   version         : bodhi.js/eth-rpc-adapter/2.4.21
Sep 29 11:40:41 m2 bash[1025415]:   endpoint url    : ws://localhost:40520
Sep 29 11:40:41 m2 bash[1025415]:   subquery url    : http://localhost:4001
Sep 29 11:40:41 m2 bash[1025415]:   listening to    : http 40525 | ws 40526

Hi, we recently had an updates to combine http and ws port, so there is no WS_PORT option anymore, instead it's PORT. Please check out here for all options https://github.com/AcalaNetwork/bodhi.js/tree/master/eth-rpc-adapter#options

ok, i actually did not realise you could use 1 port for both HTTP and WS.


Rename LICENSE.txt to LICENSE

This is the new default for GitHub and looks much nicer.

Isn't this unfair for Windows users?

Maybe, but GitHub's default is without the file extension. Also, Windows users can open the file using "Open with" so it's not like they can't open it. (Plus, who's dying to read the Apache license yet again? 😄)

Doing some PR cleanup: having a LICENSE.txt file drives me crazy, but I'll live with it. 😄


Can't start the PSService.ps1 service using the LocalService or NetworkService accounts

The updates checked in today allow running the PSService.ps1 service using any user account.
This works fine with "normal" user accounts, provided they have the "Log on as a service" right.
This also works well with the special LocalSystem account, which was the default account used until now.
But this does not work with the special LocalService and NetworkService accounts:
The SCM seems to be perfectly happy about them, and reports success in all cases. Yet, even though the PSService.exe stub starts, the PSService.ps1 -Service instance does not. I don't know why. I've written in the help screen that theses accounts do not have enough privileges to run PowerShell, but this is just a speculation.
I'm still hoping that somebody can find a solution for these two accounts, as they actually are the ones recommended for running services!

A quick note on the last part of the last sentence: the recommended accounts for running services are now virtual service accounts (whether local or not).
This doesn't bode well with the service in its current form, but this can be set with sc.exe once the service is installed, e.g.: &sc.exe config PSService obj= "NT SERVICE\PSService".


There are two search icon in activity bar

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.91.0-insider (system setup)
OS Version: Windows_NT x64 10.0.22635

Steps to Reproduce:

open vscode but do not open any folder

the one of search icon will disappear if open a folder. But the shortcut will be incorrect

Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.

I assume the "Makefile", "Bitbake" etc entries on the context menu in your earlier screenshot no longer appear. What does it now look like?
Do both magnifier buttons in Activity Bar produce the same content in the Sidebar (the SEARCH view, I assume)?

I assume the "Makefile", "Bitbake" etc entries on the context menu in your earlier screenshot no longer appear. What does it now look like?

I do not disable all extensions in the first screenshot.  so there are Makefile, Bitbake etc on the context menu. After you reply me, I disable all extensions, but the situation remains the same

Do both magnifier buttons in Activity Bar produce the same content in the Sidebar (the SEARCH view, I assume)?

One of Search Icon's view is empty, and the other is ok. Please watch the video below, thanks.
https://github.com/microsoft/vscode/assets/8591065/2f3e5618-d020-4019-99dd-dcc461300647

You can fix this by running View: Reset View Locations. Does that help?

You can fix this by running View: Reset View Locations. Does that help?

It's useful. Thank you very much!


installation problem

after those two steps? what else? how do i use the post or open the index?

post doesnt work, foreach of undefined error

So glad to have a issuer here in my repository. I was implementing private/public key and the repository became different from it used to be. I will make a new branch for one which works.

I was busy on contributing to ethereum projects. I will set original branch which works(but not perfect) and start working on documentation.


For Docker environments, a UV_PYTHON_DOWNLOADS env variable would be useful

I'm aware of the python-downloads option, but in Docker builds, it's not always 100% clear what user runs what and when when, so it would be really nice if I could set UV_PYTHON_DOWNLOADS=only-system or UV_NO_PYTHON_DOWNLOADS=1 once in my base image and not think about it anymore.
If any of this exists, I haven't found it neither by searching the docs nor by searching the code. 😬

Pretty sure this shipped in 0.3.2! 🎉


Rephrase the virtualization disabling description

Hi @I-gor-C, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks for the PR, Igor!


Cannot read property 'current' of undefined in the Panel

Hi,
I have an "Cannot read property 'current' of undefined" exception in the Panel when using the Annotator field. I think this was introduced in Kirby 3.3.0 and could be, from what I read, related to the refactoring of the Vuex form store module?
Thank you,
Georg

I'm seeing this with Kirby <IP_ADDRESS> and Annotator version 0.0.1.

I've just released 1.0.5, which you'll need for 3.6+ compatibility.


[Android] Add notification while downloading is in progress and finished

When open a link to download file in XWalkView, it's better the downloading
is visible and shows in the notifications while in progress and after
completion, so the downloaded file can be opened.
BUG=XWALK-6678

@lincsoon @axinging @wuhengzhi @XiaosongWei @fujunwei please help review, thanks

I agree with the patch, but I don't think this solves XWALK-3108, only XWALK-6678.
XWALK-3108 ended up becoming a mixture of different issues reported by different people. Originally, it was only about the user's app supposedly freezing (hard to confirm, the original reporter is marked as inactive) and the error message shown in logcat. I'd like to treat it that way, and leave the "I wish that the users are notified when a download finishes" wishlist item to XWALK-6678. I don't think this patch gets rid of the logcat NOTIMPLEMENTED warning at all.

LGTM, thanks.

LGTM

thanks!


please publish TensorFlowLiteObjC 2.8

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using):
Android 2.8
iOS 2.7
Are you willing to contribute it (Yes/No):
NO

Describe the feature and the current behavior/state.
Will this change the current api? How?
Who will benefit with this feature?
Any Other info.

@v7lin
Can you please fill the issue template.Also can you please elaborate about your feature and please specify the use cases for this feature. Thanks!


fix: use new destination.bucket key in policy

what

use new destination.bucket key in policy

why

Support both deprecated destination_bucket and new destination.bucket
Previous changes created destination.bucket and left destination_bucket for backwards compatibility, as stated in variables.tf, and forgot to include the new value in the IAM policy

references

Closes #228

/terratest


wrong links on http://dev.office.com/code-samples-detail/5792

all source code links on http://dev.office.com/code-samples-detail/5792 are wrong, e.g.  AuthClaimTypes.cs and IdentityToken.xml.  They are causing 404 now.  They should point to Github files.  Please fix them.

Links were fixed but didn't close this issue. Thanks for reporting, @ShuanWang !


define MESSAGE_VERSION 4, to use holographic ICE

This MESSAGE_VERSION indicates that a client has support for holographic ICE.
Tested in Chrome on my desktop.

:thumbsup: (assuming everything was approved on the -lib side)

Yep, the NPM is already published. Thanks!


Add unauthorized check

Add unauthorized check

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b29e963) to head (b270871).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           84        88    +4
  Branches        11        12    +1
=========================================
+ Hits            84        88    +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automated cherry pick of #5301: build: rename docker-build to docker-centos-build

Cherry pick of #5301 on release/3.1.
#5301: build: rename docker-build to docker-centos-build

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@d5096ad). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.1   #5302   +/-   ##
=============================================
  Coverage               ?   6.73%
=============================================
  Files                  ?     547
  Lines                  ?   95797
  Branches               ?       0
=============================================
  Hits                   ?    6451
  Misses                 ?   88808
  Partials               ?     538

Flag
Coverage Δ

#aFlag
6.73% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5096ad...3349dc4. Read the comment docs.

/lgtm
/approve


clarify readme

Clarify samples in Readme.md

On row 44 must be added );
    var car = Car("Telsa", "Model Y", kilometers: 5);     realm.write(() {       realm.add(car);     });

On row 41 there is some old type mistake: "Telsa" must be "Tesla". Otherwise the query will not return the car.
        var car = Car("**Tesla**", "Model Y", kilometers: 5);


Code quit unexpectedly on open

Does this issue occur when all extensions are disabled?: Yes
details.docx

VS Code Version: 1.91.0 (1.91.0)
OS Version: Mac OS X 10.15.7 (19H2026)

Steps to Reproduce:

Download VSCode
Open

/duplicate of pinned issue https://github.com/microsoft/vscode/issues/219893

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Computations creating signals

If a computation computes new signals, i.e. new state e.g. by computing a new S.data signal, are there any rules of which to be aware?  I haven't been successful in exactly understanding the rules.  In a lot of cases it works, but in some rare cases I have to create a new S.root and dispose that root manually in the cleanup method of the computation.
Most of the high level state that drives the rest of the computation of an app can be created  in the main S.root but how to handle cases where you need to create new signals?

Data signals -- what you get from either S.data() or S.value() -- can be created anywhere, and they don't have any special lifecycle.  They're just like any js object,.  You can create, pass, and use them anywhere.  They'll get garbage collected once they're no longer referenced.
Can you say more about the "rare cases" where you saw weird behavior?
I might have a guess.  If you're creating data signals inside computations, the part that sometimes gets tricky is that if the computation updates, new data signals are created, which therefore reset to whatever initial state is assigned, making it seem like their state never changes.
For instance, I once made a component that looked about like this:
function ClickMe() {
    const clicked = S.data(false);
    return clicked() ?
Clicked
 :
 clicked(true)}>Click Me
;
}

So the intent there is that it creates a div that says "Click Me" until you click it, at which point it creates a div that says "Clicked."
But that's not what happens :).  Since <ClickMe /> doesn't just create but also reads clicked(), it has a dependency on clicked().  So when we change clicked(), we think we're saying switch to the other div, but we're actually saying re-run <ClickMe />.  That re-run creates a new clicked() signal, which starts out with the initial state we picked, false.  So the component never switches to the "Clicked" state and always says "Click Me."
The real problem was that I mis-defined <ClickMe />.  I wanted it to switch between two divs, which means its output should be a signal, not a static node.  Signals can change, but the only way to change a static node is to re-run the entire function.  So we can fix it by having it return a computation that picks between the two divs:
function ClickMe() {
    const clicked = S.data(false);
    return S(() => clicked() ?
Clicked
 :
 clicked(true)}>Click Me
);
}

Does that sound relevant to your situation?  If you have a code sample where data signals created in computations weren't working the way you thought they would, post it up and I'll take a look.

It's not the nested signals but the nested computations that are of interest here. Signals can freely be collected when they move out of scope. However with computations it's possible to create dependencies that exist outside of their calling scope. If they are not disposed further changes to signals will continue to trigger them even after you've lost variable reference to them. Luckily S is setup so that on every computation re-run and disposal it disposes of all dependencies and child computations. As you can imagine this cascades since the disposal of the child computation disposes it's dependencies and it's child computations and so on.
So this holds up in the majority of cases. But it also means you are always redoing the work. So consider a conditional in view (this isn't exactly how it works but I think it conveys the point):
const count = S.data(6);
const parentNode = document.createElement('div')

S(() => {
  if (count() > 5) {
    parentNode.textContent = '';
    const node = document.createElement('div');
    S(() => node.textContent = 'Tracked ' + count() + ' times.');
    parentNode.appendChild(node);
  } else {
    parentNode.textContent = 'Too Low';
  }
});

Now your intention here is to only draw the child if the count is bigger than 5 and then update the count in the child div as the value changes. However every time the count changes the outer computation retriggers and every thing is redone. It is possible to hoist this inner work out to make this work but I want to show you the other way which is more the way a specialized if method would work (or the way we could memoize values in an array).
const count = S.data(6);
const parentNode = document.createElement('div')

let dispose;
S.cleanup(() => dispose());
S( prev => {
  const result = count() > 5;
  if (result === prev) return prev;
  dispose && dispose();
  if (result) {
    S.root(disposer => {
       dispose = disposer;
       parentNode.textContent = '';
       const node = document.createElement('div');
       S(() => node.textContent = 'Tracked ' + count() + ' times.');
       parentNode.appendChild(node);
    });
  } else {
    parentNode.textContent = 'Too Low';
  }
  return result;
});

Ok a lot more here. See the problem is to prevent repeat work we need to exit early if value of the condition hasn't changed. The problem is the nested computations would be released on re-run and the nested view wouldn't update anyway. By placing them in their own root the outer computation is no longer responsible for disposing them. However, now you are. So you need to make sure you dispose on re-run where applicable or if the out context would ever re-run.

@adamhaile addressing your response first (holy cow, having a response from both of you so fast is just wonderful)
Yes, that actually sounds exactly the issues with which I am dealing, thank you for being intuitive enough to see into my question.   I was having the exact same issue, I had a little signal machine function (a function that returned some new signals plus computations in a plain JS object), and it was computed in an S.on.  This return object I used to create other computations (in another tick of the S.js rootClock) and those computations worked fine but the computations created in the original object were not firing unless I put setTimeout or S.root around my function.   Anyway, that is probably a tad hard to follow, but yes that is exactly right.
The takeaway I am getting from you Adam is that in these cases it is often necessary to make sure that these types of functions return a computation based on the new state signals, and that returned S.js computation node should then update properly when the new signals changes.
Ok, on to @ryansolid's comment.

Ryan, interesting example.  An equivalent of your first case that does it all in JSX would be:
const count = S.data(6);
const parentNode =
{count() > 5 ?
Tracked {count()} times
 : 'Too Low'}
;

As you say, that would re-create the inner
 each time count() changed.
You could fix some of that by doing:
const count = S.data(6);
const childNode =
Tracked {count()} times
;
const parentNode =
{count() > 5 ? childNode : 'Too Low'}
;

That's still not perfect: childNode gets updated even when count() <= 5, and it gets re-inserted each time count() changes while greater than 5.
You could get the efficiency right at the expense of synchronicity by piping the test into an S.value():
const count = S.data(6);
const isBigEnough = S.value(true);
S(() => isBigEnough(count() > 5));
const parentNode =
{isBigEnough() ?
Tracked {count()} times
 : 'Too Low'}
;

Subclocks would fix the synchronicity issue (though again, they're not quite ready for production):
const count = S.data(6);
const isBigEnough = S.subclock(() => {
    const isBigEnough = S.value(true);
    S(() => isBigEnough(count() > 5));
    return isBigEnough;
});
const parentNode =
{isBigEnough() ?
Tracked {count()} times
 : 'Too Low'}
;

If there were an S utility, called, say, S.expr(), that does the inner work there, you could simplify it all to just:
const count = S.data(6);
const isBigEnough = S.expr(() => count() > 5));
const parentNode =
{isBigEnough() ?
Tracked {count()} times
 : 'Too Low'}
;

That would get maximum efficiency :).

  This is something I really need to be aware of.  I am using Surplus's runtime (brought directly into my app by copying the source :) ) and I set up content and insert renders very successfully over the last few days.  I will keep this in mind as I look into the subtleties of how my little components render and re-render after I read and re-read your answer several times.  :)

Thanks Adam. I chose that example because I figured it was the simplest one I could think of that could use nested roots realizing there were other solutions. In generalizing the solution as a utility function in the same way SArray map methods, is the nested root approach reasonable?

I am looking into S.js source and I am noticing that when calling S.on, the Listener node is set temporarily to null, so I assume no Log records are created and hence no dependencies are set for those signals.    The function I was calling that was creating new signals and computations, was being called from an S.on computation.  I guess that could of been it but still trying to digest why.

@mrjjwright I realize I may have prematurely led you down a rabbit hole in that other issue. I had been working so much on my own library I wasn't thinking about how you'd be likely using S-array. I can explain why you don't see S.root in the Surplus code and you do in the babel plugin. It's because at the point of insert or content in Surplus the memoized lookup has already happened. Those methods are just taking a node array and diffing it to figure out the least number of changes and applying it. The nested S.root in this scenario would happen in the S-array map methods that do the actual lookup and data to DOM transformation.
With Surplus on update there are 3 steps.

You update the data which triggers the computation in the S-array map function to fire.
The map function finds or creates mapped nodes registering disposables for each new root it creates. It sorts and disposes the nodes so that the resulting node list is what you wish the final DOM state to be.
The resulting node array is passed into insert or content and uses the algorithm to make the least changes to the DOM to reflect the list.

The difference with the babel plugin is I combined step 2 and 3 into a single pass. The each binding is essentially S-array mapSample + insert/content.  I do something similar for my when binding which is similar to the psuedo code I posted above. So if you use S-array it is possible you don't need to worry about handling this yourself as it will handle lists and the if case can be handled by hoisting like Adam suggested. Take a look at mapS and mapSample. It might make more sense in this context.

@ryansolid I notice that S-array is not a dependency (or peer dependency) for Surplus so I am assuming that a Surplus user must use mapSample in certain cases that are along the lines of this discussion and I see that this is indeed done by @adamhaile e.g. in the surplus-todomvc example here:
https://github.com/adamhaile/surplus-todomvc/blob/master/src/views.tsx#L25
I also see that in the source for mapSample there is an internal object called mapped that contains S.roots which matches what you are saying.
So I see the general outlines of what you are saying, thank you so much for the clear explanation and I will keep studying to understand more.
I figured out my original problem.   It's really the fundamentals that continue to trip me up, no big surprise since that is true with most anything in life.  In my app, when the user presses a key, I set it on a signal and then run a S.on computation that tests the key and if a certain key is pressed a new UI object is pushed into my app state (in an SArray) with new signals and computation.  So in each subsequent press of the keyboard, and hence on the updates to this S.on computation, where a new path through the key handler computation was being followed,  all the computations I was creating in this function were getting disposed, while all the signals were getting kept, since there were  stored elsewhere.  Also other computations created in other places on my based on these signals would continue to work, which confused me, just not the original computations created within the S.on computation.
The big takeaway for me is to realize that the lifetime of computations is in practice different than the lifetime of signals (as you pointed out, which helped trigger my understanding).   In most cases signals will get stored/referenced in the user's own app, but computations lifetimes are much more handled internally by the S.js internal ComputationNode, Log, RootClock, event, update, disposer mechanisms.
Feel free to state it better if somebody sees any flaws in my understanding.  @adamhaile and @ryansolid, again thank you so much.  I am absolutely in love with this stuff and because both of your code is written so minimally and clearly (unlike the bigger libs of mobx/vue/rxjs), I hopefully have a chance at actually creating bug free code around this that still has great performance.

run a S.on computation that tests the key and if a certain key is pressed a new UI object is pushed into my app state (in an SArray) with new signals and computation.

Yeah, ok, that's a prime case of where S.root() is going to be involve somewhere, because you want computations to live beyond the update cycle of the computation that created them.  I've used two solutions for this scenario in apps:

Let SArray manage it for me.  Instead of creating the new object directly, I push its constructor parameters onto an inits SArray.  That array is mapSample'd to run the actual constructor.  That way the map owns all computations created, and keeps them alive.  If I want the object to be disposed, I remove its constructor params from the inits array and it is removed from the mapping.

const
   inits = SArray[]),
   objects = inits.map(params => new SomeObject(params));

S.on(someEvent, () => inits.push(newObjectConstructorParams));

// ... later, when it's time to dispose it
inits.remove(newObjectConstructorParams);

Use S.root(), get a dispose function, which is passed to the new object.  When we want to get rid of it, we call that dispose method.  Usually I still want to push this object onto some SArray so I can enumerate all such objects.

const objects = SArray([]);

class SomeObject {
    constructor(params, dispose) {
        ....
        this._dispose = dispose;
        objects.push(this);
    }

    dispose() {
        this._dispose();
        objects.remove(this);
    }
}

S.on(someEvent, () => S.root(dispose =>
    new SomeObject(params, dispose)
));

// ... later
object.dispose();

@adamhaile I did almost exactly # 2 of your solutions.  The first solution is super cool!  It was such a relief to understand all this today and once I did I am really flying, app is working great again, so thanks to you all again.  🚀


feat: Connector Template Generator

Closes #392
Run
Run make connector-gen to create executable under ./bin.
Then execute the following:
./bin/cgen base -o microsoftdynamics-example -p msdcrm -n MicrosoftDynamicsCRM
./bin/cgen read contact -o microsoftdynamics-example -p msdcrm -n MicrosoftDynamicsCRM
./bin/cgen write lead -o microsoftdynamics-example -p msdcrm -n MicrosoftDynamicsCRM
./bin/cgen delete lead -o microsoftdynamics-example -p msdcrm -n MicrosoftDynamicsCRM
./bin/cgen metadata admin -o microsoftdynamics-example -p msdcrm -n MicrosoftDynamicsCRM

or shorter version
make connector-gen

./bin/cgen base -p xero
./bin/cgen read contact -p xero
./bin/cgen write lead -p xero
./bin/cgen delete lead -p xero
./bin/cgen metadata account -p xero

Review Output
If you want to see output example for xero see this commit: https://github.com/Cobalt0s/connectors/commit/8b27bfb50aec0090232fc16b52dc803a5c4cd43b

I really, really like this. I've thought of doing something like this but haven't had the cycles to devote. This could be a big timesaver for everyone. I have 2 asks:

Move the connectorgen stuff out of common. Being in common implies that this functionality is meant for general connector runtime, which isn't the case.
Wherever reasonable, move re-usable functions from template functions in to non-template files. For example, boolPtr doesn't need to be copy-pasted in each connector, it would be better to have it in a central location so that future maintenance can be centralized. These re-usable bits can and should live somewhere in common, since those will be used at runtime.

Again, awesome idea, really happy to see this.

I am glad you like it! I moved this package under tools directory. (I think scrapper should move there too. I will create a separate PR for that). I cleaned up those utility methods in another PR https://github.com/amp-labs/connectors/pull/443 as you asked. This is the first step for template generator (which I think should be as simple as possible), it should evolve as more requirements will be coming.
I changed command to imply output directory and provider name (they can be overriden if needed):
make connector-gen

./bin/cgen base -p xero
./bin/cgen read contact -p xero
./bin/cgen write lead -p xero
./bin/cgen delete lead -p xero
./bin/cgen metadata account -p xero

I was trying to remove bin/ locally but wasn't sure why git was still indexing it.... and the reason is that it is present on the main branch. It was commited by mistake by another PR because of different .gitignore files, sorry about that.

The semgrep Github Action is failing, and can be fixed by replacing text/template with html/template, once you do that and fix the merge conflict, you can "squash and merge" (and I believe you should have the appropriate permissions now)

Eh, that semgrep rule is a bit aggressive. text/template is only insecure IF you're using it to render actual HTML. Since that's not the case here, I think it's fine. Probably more appropriate to nolint that particular rule.

The semgrep Github Action is failing, and can be fixed by replacing text/template with html/template, once you do that and fix the merge conflict, you can "squash and merge" (and I believe you should have the appropriate permissions now)

Eh, that semgrep rule is a bit aggressive. text/template is only insecure IF you're using it to render actual HTML. Since that's not the case here, I think it's fine. Probably more appropriate to nolint that particular rule.

Indeed, we are not genereting HTML. We don't want any escaping rules applied that are relevant for it. I found how to ignore semgrep see commit: https://github.com/amp-labs/connectors/pull/391/commits/58ec895de61fe36aebd55357665c6680d8cef6a0. Rebased and there are no more conficts.
If you have some ideas on improving this template generator let me know and I can address those.


all zero output?

https://github.com/hkchengrex/Cutie/blob/2ac7ac21d048e7ff8b2b033a084e0e4ea7b1216c/cutie/inference/inference_core.py#L339C29-L339C40
I obtain all-zero outputs when running scripting_demo.py

Are you using the script without modification? If so, updating PyTorch/just reinstalling it sometimes fixes it.

My fault, I thought it is a panoptic segmentation, only checking the border data(all zero), so it makes me confused
and now I have another question, if some interesting object disappear in the middle of a video, the Cutie will keep tracking it or not?
Thanks

It should. Since that would be a harder case, it might fail more often.


Test with Squirrel SQL

Works in general for scalar value

Configured Driver via Add Driver -> Extra ClassPath
Created New Session,
Worked but gave a warning about 2.1 incompatibility


namespace's info doesn't update with subnet

First i create subnet and bind it with a namespace, then i delete the subnet, the namespace's annotations is also the subnet's info which is deleted.

Good catch, we will try to resolve it, thanks! @qsyqian


Make compatible with modules

Please publish it to NPM if possible.

I'm struggling with the ESLint thing, it seems to bring in too much stuff. Is it really all needed?

@kidonng @cavokz updated

Thanks!

@cavokz would you like to publish it NPM?

@xingrz I'm hesitating because of the public email address thing, I already receive enough spam. Is it NPM such an enabler? Does node.js support WebUSB?

@cavokz Not for node.js. NPM is becoming a good practice for web developers.


Adds tflint --init invoke

:memo:  Brief description
Starting from v0.35.0, tflint does not include bundled plugins. tflint --init is needed to install all plugins defined in config file.

:computer:  Commits

:file_folder:  Modified files

:warning: Additional information

[x] Pushed to a branch with a proper name and provided proper commit message.
[x] Provided a clear and concise description of what the issue is.

Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information

Thanks @pawelaugustyn !  I own you a beer if we have inter-devops meeting after work :)


Image Black Wedges: Over-Rotation

Description
When photos are uploaded, they are over-rotated, often creating black wedges around the edges.

This should be fixed. Let me know iff we are seeing new images with this issue


Toasts inDuration option is not respected

Please look at the Codepen https://codepen.io/alantsui09/pen/oqmagW.
Expected Behavior
Transition in duration should be 10s.
Current Behavior
While transition out is correct, transition in is not. I suspect that it is still the default value 300ms.
Your Environment

Version used: 1.0.0-beta
Browser Name and version: Chrome 65
Operating System and version (desktop or mobile): macOS High Sierra Version 10.13.4
Link to your project (if appropriate): https://codepen.io/alantsui09/pen/oqmagW

Good catch, thanks.
Fixed in 6ea957f8


set target->state = 0 in mysql task to reuse same transaction id

https://github.com/sogou/workflow/pull/1360


Additional languages for login and self-service

The following languages were requested by users of ZITADEL:

[x] Polish
[x] #5585
[x] Czech
[ ] Danish
[x] Swedish
[x] Dutch
[ ] Norwegian
[x] #4222
[x] Portuguese
[x] #3990

Considerations

These languages should be available to end-users (not admins); relates to #4233
We might want to lint/automatize checking for keys in i18n files

you forgot Portuguese

I'd add the need for default translations being instead of "Finish initializing account at Zitadel" to "Finish initializing account at ". Its not fun to go thru x languages and x texts.
What about being able to disable certain languages. Ie you want more customized texts(maybe a legal need to disclose some stuff on registration?), but dont have the personnel to localize 20x languages?
Lastly what about supporting arbitrary languages? Ie admin defined?

you forgot Portuguese

Portuguese from Brazil too, "pt-br"

I will close this issue as we have most of those languages implemented.
If we see a need for a language we will create a dedicated issue for it


Bag opening half off-screen

Addon Version
v0.1.64-1-gf107bab and newer
World of Warcraft Version
Cataclysm
Describe the bug
The bag doesn't open where it is left, when addon is used alone it opens farther up the screen the first time opening after reload/relog. When used with Elvui it moves up and to the right where it starts off half way off the screen.
Steps to reproduce
Download just the addon, base settings.
Open bag and move to where u want it.
Reload.
Open bag and watch it not be in same place.

I can confirm this is happening to me too -- I'll have a patch out today.

Fixed in v0.1.68.


Redo of background colors to improve diff readability

This is a complete rewrite of #286 on top of the current version of difftastic (with the exception of the last cargo update which is causing a compilation error for me #689).

Previous Issues
Hopefully this addresses the issues that @Wilfred mentioned in the last pull request:

We probably don't need to make line numbers red/green with background highlighting: no background highlighting behind line numbers
It looks like subword bold highlighting (the 6 in Version 0.6) and delimiters (the ( before reverse) is missing: not sure about this, please let me know if you still see this issue
I don't think you need cansi, you should be able to calculate lengths before applying colours: got rid of cansi, mostly able to calculate proper lengths without the ANSI stripping step (except for inline view)

Themes
This pull request lays the groundwork for theming of difftastic in the future. The missing piece here is the ability to parse theme information from a config file. Internally, the various styles are stored in a HashMap and a lookup with fallback is performed when retrieving various values.
Notes and Caveats
While this is a decent proof of concept there are probably a few issues in need of attention:

Switched to yansi for rendering colors in the terminal since it has this incredibly useful wrapping functionality. This makes "nesting" of ANSI colors feel possible.
Inline view does not color lines all the way to the right side of the screen. I'm having a rather difficult time tracking down where I need to add padding to make this happen.
Completely blank lines do not have any color. They only indication that they have changed is the color of their line number.
Dark mode is not supported in themes. The idea is to use separate themes for dark and light mode.
Header styles are not fully supported in the themes.
NO_COLOR is not currently supported even though yansi supports conditional styling quite well.

Reasoning
I'm creating this pull request now, in spite of it not being finished, since I'd like feedback on the above.

This looks better.
Do you have a plan to create custom themes? To use git colors is one way I prefer.

Do you have a plan to create custom themes? To use git colors is one way I prefer.

No. If you have more detail about what you'd like to see in custom theme support please share.
Right now, I have implemented this in a way that could support custom themes, specifically yansi::Styles are pulled from a lookup table implemented via a HashMap. The biggest missing pieces are

A format for storing themes on disk: Do we go with TOML, YAML, JSON, etc.
Parsing code to convert user specified theme info into actual yansi::Style types.

@gerhardol Is this what you have in mind?

Git colors are defined in the doc: https://git-scm.com/docs/git-config#Documentation/git-config.txt-colordiffltslotgt
But you do not get the hardcoded defaults from Git what I  know.
Also, getting colors dynamically will be slow (some caching will have to be used).
But using the same names for the slot (with some additions and deletions) would simplify.
Maybe not this PR to define the available slots, but maybe the name of them.
Difftastic is more than Git, but as Git is dominant, at least configuration and documentation is simpler if the concepts ar the same.
In my case to use Difftastic as a difftool from within another tool, I would need some way to control tis at runtime, prefeably with environment variables. So a comma separated list with the Git names of the slots is my preference. A user may want other colors from the command line and use other theme colors when embedded in the app.
A sidetrack...
Will try to build and try this branch myself


api, server, ui: allow host auto-select for migrateVirtualMachineWith…

Description
Fixes #6773
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6785 (SL-JID-2442)

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6785 (SL-JID-2443)

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4323

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland please note I've not done any sort of testing for this yet

@DaanHoogland please note I've not done any sort of testing for this yet

I'll do some when I get around. Do you have any test advice on this? I couldn´t reproduce the  issue on 4.17.

@DaanHoogland To reproduce, I think one needs to just select Automatically assign in the migrate instance form for a vm that has volumes on local storage,

For tests,

we will need to test this case which I feel would fail :-D
test for any regression - user vm migration, systemvm migration, vm storage migration using migrateVirtualMachineWithVolume API and maybe cross-cluster migration

Trillian test result (tid-5059)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6785-t5059-kvm-centos7.zip
Smoke tests completed. 100 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_unsecure_vm_migration
Error
225.92
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
145.08
test_vm_life_cycle.py

test_04_nonsecured_to_secured_vm_migration
Error
153.13
test_vm_life_cycle.py

test_08_upgrade_kubernetes_ha_cluster
Failure
605.48
test_kubernetes_clusters.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
650.62
test_vpc_redundant.py

Nice enhancement

Did you test @weizhouapache ? I didn´t get to it yet.

Nice enhancement

Did you test @weizhouapache ? I didn´t get to it yet.

I have not tested it yet

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6130

Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6054

Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6055

Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6136

@blueorangutan package

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Recreated here https://github.com/apache/cloudstack/pull/7554


"One in a million" server crash

Server crashed.  Log below.  Derp says it's one in a million, happens when the "user logs in just at the exact moment this thing checks for things or, disconnects just at the milisecond the pad advances".
[2016-04-28 15:31:40] SocketServer (debug) ::ffff:<IP_ADDRESS> sent: {"type":"getUsers"}
[TypeError: Cannot read property 'uid' of null]
TypeError: Cannot read property 'uid' of null
    at C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\djqueue.js:237:43
    at C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\playlist.js:84:3
    at C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\YT.js:133:18
    at IncomingMessage.<anonymous> (C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\YT.js:85:18)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:903:12)
    at doNTCallback2 (node.js:439:9)
    at process._tickCallback (node.js:353:17)
[2016-04-28 15:31:41] SocketServer (info) Socket server listening on port 8082

Got another of these "one in a million" crashes.
[2016-05-20 15:28:39] SocketServer (debug) ::ffff:<IP_ADDRESS> sent: {"type":"logout","data":{},"id":79}
[2016-05-20 15:28:39] SocketServer (debug) ::ffff:<IP_ADDRESS> sent: {"type":"chat","data":{"message":"SylvieBi left."}}
[2016-05-20 15:28:39] SocketServer (debug) ::ffff:<IP_ADDRESS> sent: {"type":"getUsers"}
[2016-05-20 15:28:39] SocketServer (debug) ::ffff:<IP_ADDRESS> sent: {"type":"getUsers"}
[TypeError: Cannot read property 'uid' of null]
TypeError: Cannot read property 'uid' of null
    at C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\djqueue.js:237:43
    at C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\playlist.js:84:3
    at C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\YT.js:133:18
    at IncomingMessage.<anonymous> (C:\musiqpad-server\MQP_TRP\node_modules\mqp-server\socketserver\YT.js:85:18)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:903:12)
    at doNTCallback2 (node.js:439:9)
    at process._tickCallback (node.js:353:17)
[2016-05-20 15:28:41] SocketServer (info) Socket server listening on port 8082

Checking the logs, it looks like it also happened on May 12th.  Looks like it happened when a user was logging out each time.