Multiple special weekmasks error

Hello!
I was making a calendar for Kazakhstan Stock Exchange when I ran into a bug. I tried to add several special weekmasks for the extended working weeks before the holidays. According the instructions for creating new calendars, I overrided "special_weekmasks" property and added list of (date, date, str) tuples. But it didn't worked for me. When I tried to invoke "get_calendar" method, I received this error:
> ---------------------------------------------------------------------------
> KeyError                                  Traceback (most recent call last)
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/utils/memoize.py in __get__(self, instance, owner)
>      46         try:
> ---> 47             return self._cache[instance]
>      48         except KeyError:
>
> /usr/lib/python3.10/weakref.py in __getitem__(self, key)
>     415     def __getitem__(self, key):
> --> 416         return self.data[ref(key)]
>     417
>
> KeyError: <weakref at 0x7faad31dde90; to 'XKAZExchangeCalendar' at 0x7faaf6d5fc10>
>
> During handling of the above exception, another exception occurred:
>
> TypeError                                 Traceback (most recent call last)
> /tmp/ipykernel_14416/1278388085.py in <module>
>       4 # nyse = xcals.get_calendar("XNYS", side='left')
>       5 # xkrx = xcals.get_calendar("XKRX", side='left')
> ----> 6 kase = xcals.get_calendar("XKAZ", side='left')
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/calendar_utils.py in get_calendar(self, name, start, end, side)
>     287
>     288         cached = self._get_cached_factory_output(name, **kwargs)
> --> 289         return cached if cached is not None else self._fabricate(name, **kwargs)
>     290
>     291     def get_calendar_names(
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/calendar_utils.py in _fabricate(self, name, **kwargs)
>     183         except KeyError as e:
>     184             raise InvalidCalendarName(calendar_name=name) from e
> --> 185         calendar = factory(**kwargs)
>     186         self._factory_output_cache[name] = (calendar, kwargs)
>     187         return calendar
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/exchange_calendar.py in __init__(self, start, end, side)
>     251
>     252         # Midnight in UTC for each trading day.
> --> 253         _all_days = date_range(start, end, freq=self.day, tz=UTC)
>     254         if _all_days.empty:
>     255             raise errors.NoSessionsError(calendar_name=self.name, start=start, end=end)
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/utils/memoize.py in __get__(self, instance, owner)
>      47             return self._cache[instance]
>      48         except KeyError:
> ---> 49             self._cache[instance] = val = self._get(instance)
>      50             return val
>      51
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/exchange_calendar.py in day(self)
>     574     def day(self):
>     575         if self.special_weekmasks:
> --> 576             return MultipleWeekmaskCustomBusinessDay(
>     577                 holidays=self.adhoc_holidays,
>     578                 calendar=self.regular_holidays,
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/pandas_extensions/offsets.py in __init__(self, n, normalize, weekmask, holidays, calendar, offset, business_days, weekmasks)
>     291                 )
>     292             ]
> --> 293         CompositeCustomBusinessDay.__init__(
>     294             self, n, normalize, weekmask, holidays, calendar, offset, business_days
>     295         )
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/pandas_extensions/offsets.py in __init__(self, n, normalize, weekmask, holidays, calendar, offset, business_days)
>      40             self, n, normalize, weekmask, holidays, calendar, offset
>      41         )
> ---> 42         self.business_days = business_days
>      43
>      44     def __setstate__(self, state):
>
> ~/python_projects/qf_py310_project/qf_py310_venv/lib/python3.10/site-packages/exchange_calendars/pandas_extensions/offsets.py in business_days(self, business_days)
>      88                 2, toolz.concatv(self._business_days_index)
>      89             ):
> ---> 90                 if right.left - left.right > pd.Timestamp(1, unit="D"):
>      91                    # if right.left - left.right > pd.Timedelta(1, unit="D"):
>      92                        interval = pd.Interval(
>
> TypeError: '>' not supported between instances of 'Timedelta' and 'Timestamp'

As I got it, on the line 90 of "offset.py" module, comparison between two periods was meant. So I tried to change "pd.Timestamp" to "pd.Timedelta" like in line 91 of the error log and it worked just fine.

Apologies @PskovitinA - I missed this when you first reported this. Is this still an issue?

Apologies @PskovitinA - I missed this when you first reported this. Is this still an issue?

Not for me. I left this feedback for you and anyone who may stumble into this error.


Installation successful, but import shogun error

I pull shogun docker image from according to installation instruction, and in its bash , I print "python" to python shell, but when import shogun, there is "import error"
root@a7737bb1e387:/# python
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.

import shogun
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named shogun
import sg
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named sg
import modshogun
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named modshogun

### The content of dockerfile is:
FROM ubuntu:16.04 AS build-env
MAINTAINER<EMAIL_ADDRESS>RUN apt-get update && apt-get install -qq software-properties-common lsb-release
RUN add-apt-repository "deb http://archive.ubuntu.com/ubuntu $(lsb_release -sc) multiverse"
RUN add-apt-repository ppa:shogun-toolbox/nightly
RUN apt-get update -qq
RUN apt-get upgrade -y
install shogun
RUN apt-get install -qq --force-yes --no-install-recommends libshogun18
RUN apt-get install -qq --force-yes --no-install-recommends python-shogun
The result of install is successful !
so why the installation is successful, but i can not import shogun successfully ?

I installed the environment from the Dockerfile

As mentioned in https://github.com/shogun-toolbox/docs/blob/master/INTERFACES.md :
The package support to python for shogun is to be enabled by
export PYTHONPATH="path/to/shogun.py:$PYTHONPATH"
following up to which , I did was :
export PYTHONPATH="path/to/shogun.py:$PYTHONPATH"
but still I get :
Traceback (most recent call last):
File "random_forest_regression.py", line 2, in
import shogun
ModuleNotFoundError: No module named 'shogun'
I know the "path" is the real path for shogun, but i install the shogun docker environment, how do i know the path of shogun? I cannot find the shogun in bash shell.

Hi! It is quite unclear what you did, so it is hard to help you. Make sure to read up on how to ask for help, and provide details of what exactly you did

I’m closing this for now as it seems a generic python setup issue. Best to google/understand what PYTHONPATH is


Add help messages similar to virtualenvwrapper

mkvirtualenv --help
should print a help message and not create a virtualenv named --help. The same applies to almost all commands in compat_aliases.fish

This is a good idea. If anyone feels like contributing, I'd accept a pull request that implements this so long as it's implemented in the actual __vf functions in core, and not just in compat_aliases. If not, I'll probably add it myself when I have spare time.

I implemented vf new --help, and thus by extension mkvirtualenv --help, via #159. If someone would like to refer to how I implemented it and do the same for other functions, I would be happy to review and merge said contributions.


Invalid dereferenced expression is @Nullable error in Spring

In Spring Framework ArgumentTypePreparedStatementSetter, we have this constructor:
@SuppressWarnings("NullAway")
public ArgumentTypePreparedStatementSetter(@Nullable Object @Nullable [] args, int @Nullable [] argTypes) {
	if ((args != null && argTypes == null) || (args == null && argTypes != null) ||
			(args != null && args.length != argTypes.length)) {
		throw new InvalidDataAccessApiUsageException("args and argTypes parameters must match");
	}
	this.args = args;
	this.argTypes = argTypes;
}

Without @SuppressWarnings("NullAway"), we get a dereferenced expression argTypes is @Nullable error while IntelliJ IDEA is able to properly analyze the code flow to understand that argTypes.length can't throw a NPE.

I see why this code is safe, but it took me a minute 🙂  NullAway's local dataflow analysis is not sophisticated enough to figure this out.  Handling it requires doing some sort of relational analysis (see the SPA text, Section 7.2), which I am a bit hesitant to add due to the potential increase in running time.  And, if/when we get time to improve the local dataflow analysis, we would probably prioritize fixing #98 first.
As a workaround, I think you could rewrite the if condition as (found with ChatGPT's help):
	if ((args != null && argTypes == null)
         || (argTypes != null && (args == null || args.length != argTypes.length))) { ... }

This makes it more "obvious" that both args and argTypes are non-null when their lengths are checked, and I think NullAway won't warn on this version.

Thanks for your feedback, I have replaced it by a variation of the workaround you proposed I created manually, thanks for the quick feedback!


Help

Hi i have a little problem i dont know how to do it
This my code on swift:
var errorPoint: NSErrorPointer = NSErrorPointer(nil)
var result = sshClient.channel.execute(command2, error: errorPoint)
Is working fine i get the results, but is incomplete i mean if remote command print some on terminal using NSLog is not displaying in result, some one can give me a hand

You should be passing a pointer to an NSError instead of an NSErrorPointer entity as the second parameter:
var sshError: NSError? // note this defaults to nil
var result = sshClient.channel.execute(command2, error: &sshError)

As for the rest of your question, do you mean that result does not contain what you think it should?


Support Public Symbol Searching

Often times I find that I want to look up a particular function or type by name (or at least the part of the name I remember) but I usually fall back on grep or ctags. I've been playing around with ENSIME's public symbol search and it seems to fit what I'm looking for.
The only question I have left before pushing my changes for you guys to review is whether the results should go into the quickfix window or a side buffer. Do either @jvican or @yazgoo have a preference?

I'd like this feature too, the Atom ensime plugin implements it IIRC, with
a pop-up palette. I'd vote for quickfix window—if it's possible (now or in
the future) to scope the search to a single file then location list could
be used in that case and it will be nice and uniform.
It would also be nice if ensime-vim exposed this as an API that could be
hooked/called by Unite, CtrlP, etc.

I see this feature in a quickfix window :smile:

@jvican ready for you to take a look.
I did not expose it as an API, although I'm more than happy to do that in the future.

Let's leave the public API for the future because it's something that it affects quite a lot of features of ensime-vim.


[Bug]: IS NULL operator doesn't work in MySQL

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When writing a SELECT statement in MySQL, using the IS NULL operator returns an error saying Your query failed to execute.
This is supported in MySQL by default but it doesn't work in Appsmith.
Steps To Reproduce
Create a select statement and with a Field set to IS NULL in the WHERE clause. e.g.:
SELECT * FROM users WHERE name IS NULL;
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud / Self-hosted - 1.9.37

@narhzih please try this statement with the prepared statement setting turned off as shown in the screenshot.

More on prepared statements here.


docs!: generate documentation with compiled examples

Issue #, if available:
Description of changes:

Created submodules (per layer)
Created one README per submodule, containing the documentation for all the constructs of this submodule
Created examples (*.lit.ts) that will be compiled by the build process
Referenced these examples from the README
Created a script that takes the output of jsii (.jsii file) and jsii-rosetta (.jsii.tabl.json file) to generate one MD per construct containing the documentation from the README + the code (ts and python) from the examples and put them in the website structure.
Modified the website pages to import the generated pages

Checklist

[x] Update tests
[x] Update docs
[x] PR title follows conventional commit semantics (fix: , feat: , docs: , ...)

Breaking change checklist
submodules => need to change the imports (ok as we are still in RC)
RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We will document the process to add a construct in the doc in another PR

We need to document the process for adding a construct in the doc

as discussed, I will do it in another PR so that we can merge this one quickly and avoid other conflicts


Dashboard error

I got this error in Dashboard page
template: user/dashboard/feeds:30:29: executing "user/dashboard/feeds" at <$push.Commits>: nil pointer evaluating *base.PushCommits.Commits
My setup

Gogs <IP_ADDRESS>5 Beta
Git 1.9.1
Ubuntu 14.04.1 LTS

Thanks your reporting!
What did you do(push) before you see this error?

The issue is gone now.

I am getting this error too. I just migrated to MySQL after having issues with my SQLite database locking up, so there could be any number of things I changed.
I get this on the dashboard as well as the "Public Activity" tab in my profile, but not others' profiles. I can't find the commit log of any repos that cause this error.
Gogs <IP_ADDRESS>5 Beta
git version 2.5.0
Arch Linux (up to date)
Here are the last few lines of my orm log after attempting to load the page
[xorm] [info]  2015/08/03 17:01:38.226839 [sql] SELECT id, lower_name, name, full_name, email, passwd, login_type, login_source, login_name, type, location, website, rands, salt, created, updated, is_active, is_admin, allow_git_hook, avatar, avatar_email, use_custom_avatar, num_followers, num_followings, num_stars, num_repos, description, num_teams, num_members FROM user WHERE lower_name = ? LIMIT 1 [args] [duckbrain]
[xorm] [debug] 2015/08/03 17:01:38.236854 time(4) key[Created]: 2015-03-13 01:13:34 +0000 UTC | sdata: [2015-03-13 01:13:34]
[xorm] [debug] 2015/08/03 17:01:38.238586 time(4) key[Updated]: 2015-06-03 23:14:00 +0000 UTC | sdata: [2015-06-03 23:14:00]
[xorm] [info]  2015/08/03 17:01:38.244114 [sql] SELECT id, lower_name, name, full_name, email, passwd, login_type, login_source, login_name, type, location, website, rands, salt, created, updated, is_active, is_admin, allow_git_hook, avatar, avatar_email, use_custom_avatar, num_followers, num_followings, num_stars, num_repos, description, num_teams, num_members FROM user WHERE lower_name = ? LIMIT 1 [args] [duckbrain]
[xorm] [debug] 2015/08/03 17:01:38.254507 time(4) key[Created]: 2015-03-13 01:13:34 +0000 UTC | sdata: [2015-03-13 01:13:34]
[xorm] [debug] 2015/08/03 17:01:38.256765 time(4) key[Updated]: 2015-06-03 23:14:00 +0000 UTC | sdata: [2015-06-03 23:14:00]
[xorm] [info]  2015/08/03 17:01:38.261326 [sql] SELECT id, user_id, repo_id, mode FROM access WHERE user_id = ? AND repo_id = ? LIMIT 1 [args] [1 33]
None of the other logs update when the page is loaded.

Thanks @Duckbrain , did you forget to migrate content field in action table?
@williamn I think it may because some kind of push does not contain any commit, not commit is too large, I need to do some tests before knowing the answer, but thanks for your reply!

You know what, I think a commit was made to a repository outside of Gogs while someone was trying to get around the locked database. I changed the permissions so Gog's could access the files, but they are not going to be in the database. (@williamn Sorry for taking your issue we can move this to another)

@Duckbrain not sure, but yes Gogs needs a nil value checker in the dashboard. :star:

@Duckbrain no worry, that is GitHub is all about. Social coding.
@Unknwon nil checker will be great

Just added a nil checker to master branch, please help test again! :grinning:

Close as implemented. :tada:

:beers:


Add __in filter

This PR adds support for the __in filter in queries and also includes logic (that I'd love to simplify but haven't found a way yet) for complex searches on missing or empty fields.
Supplies functionality for Princeton-CDH/mep-django#198.

Codecov Report

Merging #30 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    99.16%   99.17%   +0.01%
===========================================
  Files           25       25
  Lines         1681     1706      +25
===========================================
+ Hits          1667     1692      +25
  Misses          14       14


License information

Hello @lzx551402 ,
Thanks for sharing an implementation of your ECCV 2018 paper. Could you please provide license information for this project? Thanks

Added. Thank you for your interest in our project.


Fix order number in Quickpay

This fixes issue https://github.com/Pragmasoft/uCommerce.QuickpayV10/issues/6 so it use OrderNumber from PurchaseOrder instead of ReferenceId on Payment object. At the moment it might works okay when only having one payment per order, but UCommerce also allow multiple payments per order. It also makes more sence to use OrderNumber in QuickPay, where they have a order_id property.
It also makes it much easier the filter/find payments on orders in QuickPay administration.
Furthermore the extension methods wasn't included in the project.
However I am not sure why it include the ToCents extension methods instead of just including the UCommerce namespace. using UCommerce.Transactions.Payments.Common; https://github.com/Pragmasoft/uCommerce.QuickpayV10/issues/8

@dinbror can you have a look at this?

The OrderNumber is by default generated after the payment, which means that payment.PurchaseOrder.OrderNumber will be NULL when mapping the properties in
"void PopulatePaymentProperties(Payment payment)"
This is a problem, unless I'm in the wrong here?

@hardboilr you might be right about this since I noticed this value inside to brackets is empty, when running in test mode and CancelTestOrders is true.
https://github.com/Pragmasoft/uCommerce.QuickpayV10/blob/9ec0dd62eb8e5bc8397dd2b9de0815873543d3a8/src/Pragmasoft.QuickpayV10.Extensions/Services/QuickpayV10PaymentMethodService.cs#L83
Not sure if it is possible to know about the OrderNumber before UCommerce assign it is Checkout pipeline, which run in callback after successful payment, so the order number is probably not "reserved" - potentially Customer no. 1 could go to checkout before Customer no. 2, but Customer no. 2 might complete checkout and payment before Customer no. 1, so in that case the order from Customer no. 2 would get an order number e.g. WEB-1 and WEB-2 for Customer no. 1.


Curve/Arc text on safari disappear.

Please try it again. I've modified the code behind the demo (not committed yet).
https://codepen.io/softwaretailoring/pen/eLNBYz
If the above link doesn't work, please try the debug version.
https://s.codepen.io/softwaretailoring/debug/eLNBYz

still doesn't seem to work on IOS and mac devices. checked it on my iphone the text disappears even on chrome browser.

I'm still struggling with this issue any help will be appreciated.

I tried to solve this yesterday, but no solution yet.
I modified the textPath's attribute because Safari can handle only xlink:href.
https://stackoverflow.com/questions/51404939/svg-textpath-not-working-in-safari
As I see currently Safari cannot handle dynamically generated SVG correctly.
When I use the following code (the end of createWheel), it renders correctly, however, all event handlers go wrong.
if (navigator.vendor.toLowerCase().indexOf('apple') > -1) {
    var wheelSafari = document.getElementById(this.holderId);
    wheelSafari.innerHTML = wheelSafari.innerHTML;
}

I've created a private pen with this, please check it out.
https://s.codepen.io/softwaretailoring/debug/c8cd61f89a8b2b5d8beaef01b64a397f
Do you know a way to Safari re-render a dynamically generated SVG?

And what do you see now on the above link? Maybe Chrome on Mac works now?
This is a quite complicated issue...

I can see the text but doesn't it seem to respond to any event handlers.

Any hacky fix so that i can disable curve text only on safari as the normal text appears to work fine on ios devices.

Thank you its working.

It's great!
May I check your result with wheelnav.js? :)
Can you check my answer on StackOverflow also? ;)

I will share the link once it's live.

Okay, it would be great! I'll place it in the http://wheelnavjs.softwaretailoring.net/spinit.html#worldwidewheel section if you think so. Thank you for SO mark!

That's absolutely fine.
Please find the link below
http://survitecgroup.com/marine/
On Tue, Sep 4, 2018 at 3:25 PM Gábor Berkesi<EMAIL_ADDRESS>wrote:

Okay, it would be great! I'll place it in the
http://wheelnavjs.softwaretailoring.net/spinit.html#worldwidewheel
section if you think so. Thank you for SO mark!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/softwaretailoring/wheelnav/issues/84#issuecomment-418386979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMK6N49UYfLxJvMVZqcarWCn1aOq5ylSks5uXo1ygaJpZM4WRK_V
.

--
Thank You,
Dolphine

Thanks!
I've modified the Worldwidewheel section.
Please check it and let me know if you want to modify something.

Did you get a chance to resolve the curve text issue on IOS devices.

Not yet. :(

Hi, Can you able to help me to sort out this issue?
https://stackoverflow.com/questions/55243617/wheelnav-menu-click-not-working-when-using-curvetext-functionality

This is still not working. I just want to display normal text but it does not work on Mac/ipad/ios.
I am using v1.8.0 with jquery 3.7.1


⚠ Samsung has degraded performance

In f0436a8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2542 ms

Resolved: Samsung performance has improved in 67632aa.


Implement Trending.

Doesn't have to be in 0.2.5.

This will be implemented after 0.2.5 stable release.


[KH-13246] More Errors

Adding more errors to have better granularity. The structure and thought behind these additions is as follows:
Data State Errors
AlreadyExists [NEW]
The resource trying to be created already exists.
ConflictingChanges [NEW]
Changes to a resource cannot be performed due to conflicts with other existing resources.
NotFound
Resource is not found.
Parameter Errors
BadFormat [NEW]
Data provided is of the correct type but is in a format that could not be understood.
InvalidArgument
Data provided was invalid.
MissingAgrument [NEW]
Data was expected but is missing.
UnsupportedType
Data has been provded in an unsupported type.
Uninitialzied [NEW]
A dependency hasn’t been initialized but is required.
General System Errors
IO [NEW]
An I/O operation failed.
DataLoad
Data could not be loaded.
Network [NEW]
Network operation failed.
Permission Errors
AccessDenied [NEW]
Current context does not have permission to access this action.
Disabled [NEW]
The action is disabled (feature flagging, etc) in a way that’s not necessarily specific to this context.
Limited [NEW]
The action has been temporarily limited (rate limiting, etc) in a way that is not based off of the application state.

Oops, wrong fork sorry!

I was wondering why a JIRA ticket was attached. :laughing:


Using KMS or Parameter Store values in a FRONTEND amplify app?

We are hosting a react app on amplify with no backend.
I see in the docs that you can use Parameter Store but it seems like that's only for backend applications?
https://docs.aws.amazon.com/amplify/latest/userguide/environment-variables.html#access-env-vars
Is there anyway to get these into a frontend application? Maybe during a build? These env vars are purely for the frontend and no a security concern.
This is tangentially related to using doppler for env variables. Basically, the vars are synced between doppler and parameter store, but now I'm unclear how to get them into the runtime or build for the frontend amplify application.
Also open to ideas how to get them straight from doppler into amplify, if there's a way to bypass parameters/KMS.

I have the same use case and as @acomito, any updates on this question?

Hi, I just answered with a solution to this issue in https://github.com/aws-amplify/amplify-hosting/issues/3348#issuecomment-1476044689.
The solution works on the frontend build (in my case NextJS+SSR + api routes), and from doppler. In doppler, I've set up the AWS SSM parameter store integration with base path /amplify/<my-app-id>/main/ for my amplify branch main for doppler environment dev (using dev because of testing purposes). Rebuilding resulted in the following frontend build logs (similar to what is shown in the linked comment)
 # Executing command: echo $secrets
 {"DOPPLER_CONFIG":"dev","DOPPLER_ENVIRONMENT":"dev","DOPPLER_PROJECT":"meetmecal-manualsetup","HELLOFROMDOPPLER":"hello there, i'm doppler","test2":"helloworld2"}


Fix Black Screen Transition Issue by Reusing didScreenTransitionEnd in MoneyRequestParticipantsSelector

Details
Reuse the existing didScreenTransitionEnd variable on MoneyRequestParticipantsSelector page to avoid black screen during the transition.
Fixed Issues
$ 31779
PROPOSAL: https://github.com/Expensify/App/issues/31779#issuecomment-1830039239
Tests

Access the FAB (Floating Action Button) and select "Request money."
Add an amount and click "Next" to initiate the transition.
Observe the screen transition from /request/new/manual to the /request/new/participants.
Verify that the black screen issue no longer occurs during the transition.
Check for any lagging or delays in the transition.
Confirm that no transfer errors are present during the transition.

[x] Verify that no errors appear in the JS console

Offline tests
Same as Tests.

[x] Verify that no errors appear in the JS console

QA Steps
Same as Tests.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/95647348/d1382381-f24f-47b6-8269-ecb3195ae3e2

iOS: mWeb Safari

https://github.com/Expensify/App/assets/95647348/7af0dc16-6fd8-4725-b1dc-dbd7981ddf2a

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/95647348/f14cf537-7578-4778-8ec3-db9dd46fa7ad

MacOS: Desktop

https://github.com/Expensify/App/assets/95647348/8ae8ef2d-8b56-4fe0-94c3-5e46b81c2445

I have read the CLA Document and I hereby sign the CLA

@ntdiary assigned for review

@brunovjk your branch is very behind. The 2 components you made changes on are now deprecated.

@brunovjk your branch is very behind. The 2 components you made changes on are now deprecated.

Let me fix it. One moment.

@brunovjk your branch is very behind. The 2 components you made changes on are now deprecated.

@situchan we are using another money request creation flow now, but I tested it and the issue remains.
I believe we can use the same approach on the new components used. I'm still investigating and testing.
But what I do? Do I update my proposal or just the PR? Thanks.

The 2 components you made changes on are now deprecated.

@situchan the refactored money request navigation was merged but the initial issue remains. We can apply the same solution proposed previously.
I updated this PR to apply changes at new components used. Also update the video screenshot.

For native platforms, the current implementation seems to be not perfect yet

I'm having difficulty simulating native application.
But I'm working on it full time. I'll be back as soon as I have an update.

For native platforms, the current implementation seems to be not perfect yet

I'm having difficulty emulating native application.
But I'm working on it full time. I'll be back as soon as I have an update.

For native platforms, the current implementation seems to be not perfect yet.

I can reproduce it now. Working on it.

Hey @ntdiary and @grgia,
While investigating the inconsistency with onLayout={(e)=>{ in native apps, the root cause remains elusive, but I've devised a solution.
I observed a lag tied to its natural delayed onLayout call during the transition process:

Getting height from onLayout callback:

https://github.com/Expensify/App/assets/95647348/e9634e24-e373-4bff-ab1c-927fb72cfb3c

By removing onLayout={(e)=>{} from OptionsListSkeletonView and adopting an alternative height calculation:
  constructor(props) {
    super(props);
    const screenHeight = Dimensions.get('window').height;
    const numItems = Math.ceil(screenHeight / CONST.LHN_SKELETON_VIEW_ITEM_HEIGHT);
    this.state = {
      skeletonViewItems: this.generateSkeletonViewItems(numItems),
    };
  }

The skeleton now loads with the parent, eliminating the delay and resolving our initial issue with skeleton visibility in native apps.

Getting height from Dimentions + constructor:

https://github.com/Expensify/App/assets/95647348/05f938fb-e297-4a79-a055-5265df3d7984

I've run tests and recorded POC videos. Keen to hear your thoughts on this approach.

I'm not exactly sure if this will have any adverse effects.

We can set a threshold (between 0 and 1) for calculating the number of items, like:
const screenHeight = Dimensions.get('window').height;
const numItems = Math.ceil(screenHeight * CONST.SKELETON_VIEW_THRESHOLD_HEIGHT / CONST.LHN_SKELETON_VIEW_ITEM_HEIGHT);

But I understand the concern and agree to investigate further.
There's still a slight lag on iOS.
Also, I've noticed a peculiar behavior in WorkspaceInvitePage where the onLayout event is triggered, but the skeleton isn't visible. I'll try to find if there is an open issue about it.

I've made a few adjustments to the OptionsListSkeletonView component:

Constructor Optimization:

Skeleton items are now generated in the constructor for an immediate visual representation.
The computation for generating skeleton items remains lightweight to ensure swift instantiation.

Dynamic Layout Adjustment:

The onLayout event triggers an update to the skeleton items based on layout changes, ensuring a responsive layout.
Calculations for the number of skeleton items are adjusted dynamically based on the layout height.

These modifications aim to strike a balance between immediate rendering and dynamic adaptation to layout changes. The original code has been minimally modified to maintain its structure and readability.
I'll be conducting more tests, but feel free to review and provide feedback. 👍

For native platforms, the current implementation seems to be not perfect yet. It seems that the onLayout event is triggered late

After an in-depth investigation over the past days, I wasn't able to identify the root cause of the onLayout event not triggering at native. However, I've observed that a PR to modify OptionsListSkeletonView.js has been effective in resolving the layout issue.
https://github.com/Expensify/App/assets/95647348/574b8c53-0737-4d26-8e40-ecccc17ad079
@ntdiary and @grgia considering these findings, I recommend closing our current PR as the black screen problem has been successfully mitigated with the introduction of didScreenTransitionEnd.
I appreciate the feedback and remain available for any clarification or further discussion.

@grgia and @ntdiary friendly bump to review.

Thank you.

thank you :)

Eh, @brunovjk, are you suggesting to close this PR because you saw the introduction of didScreenTransitionEnd in another PR ?

No, I didn't know about it, do you know the PR number? I just wanted to move on with the work, it seems solid to me, but I appreciate your willingness to investigate, I agree, I'm available for anything.

@brunovjk could you clarify what you mean by this comment - https://github.com/Expensify/App/pull/32665#issuecomment-1872139662
It seems like you are implying you'd like to close this PR

It seems like you are implying you'd like to close this PR

Sorry for any confusion. I'm new here, still getting the hang of it. When I said 'close,' I meant if we can incorporate didScreenTransitionEnd to fix the black screen issue. I can still reproduce it, and the changes proposed in this PR fix it, but let's wait for ntdiary's investigation. Looking forward to making my first contribution to Expensify!

@ntdiary could you take another look at this PR

approved/running auto tests!

Thank you very much for the investigation @ntdiary, I will update the videos in a moment.

afraid it may be considered a regression.

I think it's worth controlling the skeleton with an isLoaded state anyway,
What would be the negative side of that? :)

@ntdiary I updated all the videos with my latest changes about move 'isOptionsDataReady' to an 'useState'
If necessary, I revert and redo it, let me know please.
Thanks.

I just found a new problem with the latest changes.

sh**, let me investigate. Do you have any ideas? Maybe revert that last commit. I'm still afraid about possible 'regression'.

Yes, true 😂 Great then, I'll try it here too. I'll come back if I find something, I'm here if you need anything.

Very good @ntdiary.
They changed MoneyTemporaryForRefactorRequestParticipantsSelector.js, hence the conflict. They added a useMemo to the const that uses getFilteredOptions, part of the initial problem, the black screen, was solved, but it is still not perfect, we are having the same problems in relation to the skeleton. I'm testing some methods too, I want it to be the same when you click on FAB > StartChat, I like the behavior of newChatPage, the transition runs smoothly with the skeleton. I'll keep testing here, I will try this call the blur in BaseOptionsSelector you said. I'm focused on making this transition perfect :D
If you have any news, I'm here. Have a good night.

I just want to say, great work so far on this one! @brunovjk @ntdiary
If this PR is not finalized, could we add a [WIP] to the title? Otherwise, may we merge main for reviews? Thanks @brunovjk 😁

Thank you @grgia!!!!
I'm still testing some methods on how to control the skeleton better.
There is even an open PR, I believe they are trying to resolve a regression. However, I tested it and it generates the same problem as this one, the skeleton is still not good.
This PR will read for review soon :D

only one seems to be working (call the blur in BaseOptionsSelector)

@ntdiary, we are refactoring components that use OptionsSelector to switch to `SelectionList:

"This issue keeps track of Phase 3 of the Selection List Refactor."
"Thoroughly discussed in the parent issue: #11795 comment"

But the initial issue of this PR always come back, since in the money request participants selector list refactoring, we never use didScreenTransitionEnds from the parent ScreenWrapper to control the call for OptionsUtils.getOptions appropriately.
I tested the use of didScreenTransitionEnds in the new refactored MoneyResquestParticipantsSelector + SelectionList and now it's looking really good to me.

We also can see other problems caused by this refactoring:

spinner loading not show when we type a new search, instead the skeleton list flicks. **We have a PR for this already, but I tested and did fix the issue, since the RCA is the missing prop isLoadingNewOptions in BaseSelectionList
ReferralProgramCTA component icon has a visual bug. A college will raise a PR, slack conversation, but I went ahead and adjusted the 'icon style' for the MoneyRequestReferralProgramCTA, we still have to search and fix for others components.

Those same problems above can be seen at the SearchPage list refactor and New Chat page list refactor
I fixed those problems by:

Adding back a prop isLoadingNewOptions in BaseSelectionList in order to control the spinner loading when we type a new search.
Adjust  SelectionList props: sections, showLoadingPlaceholder and isLoadingNewOptions in order to control the 'skeleton loading/section list' rendering using didScreenTransitionEnd and isOptionsDataReady.
Added back fill={theme.icon} to the ReferralProgramCTA component.

Committed here, changes requested by @lukemorawski here https://github.com/Expensify/App/pull/34443#issuecomment-1892308955 to resolve https://github.com/Expensify/App/pull/32692#issuecomment-1888223436.

PR Ready for review

@ntdiary PR Ready for review.

@ntdiary PR Ready for review :D

@brunovjk looks good man. Thanks for applying my changes to your PR

Thanks @ntdiary!

please feel free to request another C+ to take over

I dont know 😅 What do you think @lukemorawski @grgia ?

I can take this over if needed

If we want to add isLoadingNewOptions in this PR, perhaps it would also be better to change the condition here

Done.

we can simplify it to return [newSections, {}];

Done.
@ntdiary I tested it again here, and it looks like we're really good now!

The 'Selection List' migration generated some bugs in the list:
Latest 'main' version:

This PR does not introduce nor fix these errors.

Sorry for the mess, yesterday after the merge of a TS migration it generated some bugs and conflicts here. Today they already reversed this migration, which is why there is so much revert commit here.
@grgia and @ntdiary I just tested it and our transition continues to work great.

fewer files may be affected

Sorry, my bad. Now Its all clean :) Thank you :D

Very good @ntdiary, good clarifications.

If you want to submit only the our origin first part in this PR, I think it's acceptable. And then put isLoadingNewOptions, debouncedSearchTerm, and the responding issue in a new PR

I think it's the best option, it was getting too much for just one PR. And as we discussed, we do have other issues, but let's focus on the reuse didScreenTransitionEnd to address the screen transition skeleton issue.
Can I make the necessary changes and submit another commit?

updated code again. :)

Done! I had already done it before hehe I tested and its looking good.
Thank you very much! May you have a great weekend.

Thank you very much @ntdiary, I really appreciate your patience and goodwill :D
Now just wait for @grgia right?

LGTM 👍 thanks for your contribution @brunovjk and your comments/tests @ntdiary.

I think is fixed :D
"Jack
This is fixed now, please merge main in your PRs! #slack_conversation"

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.33-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add some checks for TableRule definition in admin

There's no validation at the moment.

It should run from_yaml/from_json loading, to make sure that rule text is correct

It should check that condtions can be parsed (currently they can be checked by trivial regex).

From my POV that's not going to do it. Rather this should be refactoring as described in this comment


Extra "/" in client when using baseURL as new URL()

https://github.com/sukovanej/effect-http/blob/00238724895a9ed15017fdeff4b8a4d122f68eed/src/internal/client.ts#L30
It looks like new URL().toString() has some interesting behavior...
new URL("http://google.com").toString()
'http://google.com/'

This ends up with the client sending requests to /search as //search
For now we're using a string which works fine.

I remember I was fighting with the URL myself so this issue was a final trigger to prepared a MR where I simply replaced URL by raw strings. @effect/platform uses strings in the public API as well anyway.

Version 0.48 enforces a string for the baseUrl so there should no more surprises with the URL usage.


Matches initial tests

Yeah having a bit of trouble over all getting this matches lib to cooperate, im marking this as a draft as it's nowhere near ready


Method to upload Ultra DMD

No existing problem
I'd like there to be a way to upload Ultra DMDs for tables that use them.
I'm currently remoting into my pinball PC and using file transfer to upload the Ultra DMDs

I have to confess, I haven't used it yet, but the DMD section contains an upload button. There you can upload zip files which contain Ultra and Flex DMDs. Did you try that?
For the next version, I have also moved all upload actions into one menu so that it is more obvious what upload types are available.

I tried with the last FlexDMD table that I downloaded (Futurama), and it told me the file was invalid. There was an UltraDMD before that that I couldn’t figure out how to upload, but I don’t remember which one.
I’ll try with the next one that pops up and let you know.
From: syd711 @.>
Sent: Tuesday, January 30, 2024 2:31 AM
To: syd711/vpin-studio @.>
Cc: Curtis Kaminski @.>; Author @.>
Subject: Re: [syd711/vpin-studio] Method to upload Ultra DMD (Issue #123)
I have to confess, I haven't used it yet, but the DMD section contains an upload button. There you can upload zip files which contain Ultra and Flex DMDs. Did you try that?
For the next version, I have also moved all upload actions into one menu so that it is more obvious what upload types are available.
—
Reply to this email directly, view it on GitHub https://github.com/syd711/vpin-studio/issues/123#issuecomment-1916231455 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCH3LBVCNT472VAYHFAXQLYRCOUJAVCNFSM6AAAAABCQBARF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJWGIZTCNBVGU .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ADCH3LCFWSV4TGFM5NPPUVDYRCOUJA5CNFSM6AAAAABCQBARF6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTSG5PR6.gif Message ID: @.*** @.***> >

Ah, I see. I'll review this upload and also test it with the Futurama table.

Thank.
The problem was that the upload validator check was case sensitive. E.g. for Futurama the folder is called "flexDMD" instead for "FlexDMD". The issue has been fixed and comes with the next version (> 2.11.1).

Re-opened as reminder for myself: there are other tables not using the this lower case syntax, e.g. cyberraceDMD. The check need to be modified so that only the "DMD" suffix is checked.

Softened check, so that all "dmd" suffixes are accepted.

Sorry, still broken.

That have went smoother. Anyway:
The last hotfix did lowercase the target folder and ignored subfolders. Both issues have been fixed.
Tested with cyberrace, futurama and blood machines.
The fix comes with version > 2.11.2


Add Chinese localization files

What Happened
Where is the localized language file, I want to help this tool add Chinese language
How to Reproduce
not
Block Coding Plugin Version
v0.6.2
Godot Engine Version
No response
Operating System
No response
Logs or command-line output
not

Anything else?
not

Thank you @DeepChTi, see also #146.

Hi @DeepChTi  – it is now possible to translate the block coding plugin, though the translations will not be shown until Godot 4.4 due to limitations of 4.3 and older. See the README file for details.

Hi @DeepChTi – it is now possible to translate the block coding plugin, though the translations will not be shown until Godot 4.4 due to limitations of 4.3 and older. See the README file for details.

ok

Hi, @DeepChTi, I saw your request on Transifex to add Chinese (zh). I've declined it because (quoting @dbnicholson from elsewhere):

As it turns out, zh is equivalent to zh_CN in Godot. See https://github.com/godotengine/godot-proposals/issues/11119 for details. A generic zh translation would never be used, which is why Godot doesn't provide one for the editor, either.


Returning to correct URL upon refresh

Which operating system and version is the project developed on?
OSX 10.12.1.beta
Which version of ruby is the project developed on?
ruby 2.3.1p112
Which version of npm is the project developed on?
2.14.12
Which version of ember-cli is the project developed on?
2.9.1
What is the rails version?
4.2.6
What is the ember-cli-rails version (from Gemfile)?
0.8.1 631a161
What is the ember-cli-rails-addon version (from package.json)?
0.8.0
Is your application server multi-threaded (such as puma and unicorn) or is
it multi-process (such as thin and webrick)?
thin
What are the contents of config/initializers/ember.rb?
EmberCli.configure do |c|
  c.app :portfolio, path: "portfolio"
end

What are the contents of the Rails' view that renders the Ember application?
= render_ember_app :portfolio do |head|
  - head.append do
    = csrf_meta_tags

How are the EmberCLI-related routes defined?
mount_ember_app :portfolio, to: "bastion", controller: "bastion", action: "index"
How is the application deployed?
Issue is in development.

When a user refreshes the browser from within my ember app, I'm unable to redirect the user to the same URL that they refreshed. Instead, the user is always returned to the root URL of the ember app.
I can see the relative path to the user's former location in params[:rest] on the controller action that is called by mount_ember_app after the refresh, but I don't know of any way to pass that information back to the ember app to guide the router to redirect to that path. I guess I could pass it via the DOM, but that feels really wrong.
Am I overlooking something obvious here?

As it turns out, I was creating this issue. I had a this.transitionTo() in the Ember app's application route's model function that was intended to move users to root upon login, but was subsequently pushing everything back to root upon refresh.
I'll close this...


[Request] Add Team ID for Channels DVR Team Pass

Would it be possible to add the TeamIDs tag to each event for easy integration into Channels DVR Team Pass?
For example, I have a team pass for Virginia Tech Basketball, but any event from EPlusTV doesn't get scheduled from the pass. I have to manually search for it and schedule the event when I know it will be on an EPlusTV channel.

This is how my pass is set up in Channels DVR.

I'm not sure where Channels DVR gets the index for the TeamID and I could not find a list online, so that might be the limiting factor for implementing this.
I could probably use an Advanced Pass to accomplish what I want, but I have multiple sports and teams set up using the TeamIDs tag and would rather not change them unless necessary.

I'll research this

@tmm1 Where do you get the info for TeamIDs? Something public?

Maybe try setting up your pass like this? You could do EventTitle contains Virginia Tech and then another one for EventTitle contains Basketball to filter out any non basketball events or EventTitle == Virginia Tech Hokies: Basketball if they're always named that way.

Maybe try setting up your pass like this? You could do EventTitle contains Virginia Tech and then another one for EventTitle contains Basketball to filter out any non basketball events or EventTitle == Virginia Tech Hokies: Basketball if they're always named that way.

Thank you for the suggestion. That is essentially what I have done for the ones I really care about, but I have almost 50 team/sport passes already setup using the TeamIDs and would rather not have to edit or duplicate all of them.


Server.Packaging doesn't work without --skip-build

Something about files being locked.

I was experiencing those same errors in https://github.com/space-wizards/space-station-14/pull/25569
I think a simple pc restart fixed it??


Feign OkHttp client configuration

There is another one - Feign OkHttp client configuration.
Pretty simple. One more thing that I was thinking was to somehow made the httpclient and okhttp setup exclusive, so when you turn one explicitly then you will disable the other.
At this point to enable okhttp you would have to setup your application as fallows:
feign.httpclient.enabled=false
feign.okhttp.enabled=true

It would be simpler if setting the feign.okhttp.enabled=true would automatically disable the httpclient.

Merged with a few changes via 966e03ba64d0dbc41860d480511d01c184cc1c41.
The most likely scenario is that you will only have one of feign-httpclient or feigh-okhttp on your classpath, so I changed the @ConditionalOnClass(OkHttpClient.class) to use the feign OkHttpClient rather than the okhttp one. The only scenario where you would need to disable one or the other is if both are on the classpath.


cclib test error. maybe h5py is not pinned?

    Error I get when trying to run via `act` that I don't locally:

| #17 [test 5/6] RUN ./test.bash
| #17 0.160 bash: cannot set terminal process group (-1): Inappropriate ioctl for device
| #17 0.160 bash: no job control in this shell
| #17 0.882 + bash ./.github/scripts/run_pytest.bash
| #17 0.883 + python -m pytest -v --capture=no --cov=cclib --cov-report=term --cov-report=xml:coverage-unit.xml --terse test -k 'not test_method'
| #17 3.161 ImportError while loading conftest '/root/cclib/test/conftest.py'.
| #17 3.161 test/__init__.py:12: in <module>
| #17 3.161     from test import test_data
| #17 3.161 test/test_data.py:16: in <module>
| #17 3.161     import cclib
| #17 3.161 cclib/__init__.py:30: in <module>
| #17 3.161     from cclib import parser
| #17 3.161 cclib/parser/__init__.py:38: in <module>
| #17 3.161     from cclib.io.ccio import ccopen
| #17 3.161 cclib/io/__init__.py:11: in <module>
| #17 3.161     from cclib.io.cjsonwriter import CJSON as CJSONWriter
| #17 3.161 cclib/io/cjsonwriter.py:14: in <module>
| #17 3.161     from cclib.io import filewriter
| #17 3.161 cclib/io/filewriter.py:21: in <module>
| #17 3.161     from cclib.bridge import makeopenbabel
| #17 3.161 cclib/bridge/__init__.py:31: in <module>
| #17 3.161     from cclib.bridge.cclib2pyscf import makepyscf, makepyscf_mos
| #17 3.161 cclib/bridge/cclib2pyscf.py:21: in <module>
| #17 3.161     from pyscf import gto
| #17 3.161 /opt/conda/envs/cclib/lib/python3.8/site-packages/pyscf/__init__.py:113: in <module>
| #17 3.161     from pyscf import lib
| #17 3.161 /opt/conda/envs/cclib/lib/python3.8/site-packages/pyscf/lib/__init__.py:24: in <module>
| #17 3.161     from pyscf.lib import numpy_helper
| #17 3.161 /opt/conda/envs/cclib/lib/python3.8/site-packages/pyscf/lib/numpy_helper.py:27: in <module>
| #17 3.161     from pyscf.lib import misc
| #17 3.161 /opt/conda/envs/cclib/lib/python3.8/site-packages/pyscf/lib/misc.py:32: in <module>
| #17 3.161     import h5py
| #17 3.161 /opt/conda/envs/cclib/lib/python3.8/site-packages/h5py/__init__.py:46: in <module>
| #17 3.161     from ._conv import register_converters as _register_converters
| #17 3.161 h5py/_conv.pyx:1: in init h5py._conv
| #17 3.161     ???
| #17 3.161 h5py/h5t.pyx:293: in init h5py.h5t
| #17 3.161     ???
| #17 3.161 /opt/conda/envs/cclib/lib/python3.8/site-packages/numpy/__init__.py:284: in __getattr__
| #17 3.161     raise AttributeError("module {!r} has no attribute "
| #17 3.161 E   AttributeError: module 'numpy' has no attribute 'typeDict'
| #17 ERROR: process "/bin/bash -l -i -c ./test.bash" did not complete successfully: exit code: 4

Originally posted by @berquist in https://github.com/shivupa/cclib-ci/issues/11#issuecomment-1376729257

I'm not exactly sure but I think its just that we need to try to pin h5py, but I will try to give this a go before tomorrow evening.


Detox Logo

We need a logo for this project. This is in the backlog but if someone would like to assist us, we'd really appreciate it.

One fun idea I had (but not the skillz to design it) was to have a play on the various "detox" shakes that exist, that are supposed to clean the body of … suff. So we could have the logo be a play on that, with the logo somehow representing all the things Detox is meant to clean, such as bugs, slow performance, etc.

What about glass of water,  selenium was introduce to cancel the poison
effect of mercury but too much selenium is also not healthy and can be
removed or extracted out by drinking plenty of water or liquids and water
is the first source to detoxify the body
Yogesh Thanvi
QA Team Lead
Punchh Tech India Pvt Ltd
On Wed, Feb 27, 2019 at 3:06 PM Leo Natan<EMAIL_ADDRESS>wrote:

One fun idea I had (but not the skillz to design it) was to have a play on
the various "detox" shakes that exist, that are supposed to clean the body
of … suff. So we could have the logo be a play on that, with the logo
somehow representing all the things Detox is meant to clean, such as bugs,
slow performance, etc.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wix/Detox/issues/1180#issuecomment-467791953, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AX8BlighWvvJpkNb1TagkvBCk-CvFL3fks5vRlGfgaJpZM4bUFaK
.

Curious to know how you feel about this direction? This is just a proof of concept, taking a shake, vectorizing it and putting the detox brand and elements in. I can improve the quality if you like the direction.

I tried to play off I have green dots representing passes around the "brand" in the middle
Added passes (✓) + fails (×) near the rim of the cup
Used a lemon and berries to signify detoxification

nice awesome work
Yogesh Thanvi
QA Team Lead
Punchh Tech India Pvt Ltd
On Fri, Aug 2, 2019 at 10:23 AM Auston Bunsen<EMAIL_ADDRESS>wrote:

[image: Screen Shot 2019-08-02 at 12 49 01 AM]
https://user-images.githubusercontent.com/93429/62345211-5dfb1500-b4bf-11e9-8036-d44b6f8575c1.png
Curious to know how you feel about this direction? This is just a proof of
concept, taking a shake, vectorizing it and putting the detox brand and
elements in. I can improve the quality if you like the direction.

I tried to play off I have green dots representing passes around
the "brand" in the middle
Added passes (✓) + fails (×) near the rim of the cup
Used a lemon and berries to signify detoxification

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wix/Detox/issues/1180?email_source=notifications&email_token=AF7QDFWBQGD3HHZIFF5FJMDQCO4UJA5CNFSM4G2QK2FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MSNGI#issuecomment-517547673,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7QDFUYXNOAFY52NTELQGLQCO4UJANCNFSM4G2QK2FA
.

Was also considering something like this:

Can we show something like code is getting detoxed
On Fri, 2 Aug 2019 at 10:43 AM, Auston Bunsen<EMAIL_ADDRESS>wrote:

Was also considering something like this:
[image: Screen Shot 2019-08-02 at 1 12 53 AM]
https://user-images.githubusercontent.com/93429/62346046-b253c400-b4c2-11e9-9bf3-c53306973fa0.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wix/Detox/issues/1180?email_source=notifications&email_token=AF7QDFX5VUSZNJV76VPKFPLQCO67XA5CNFSM4G2QK2FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MTOEQ#issuecomment-517551890,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7QDFXZXQTEXDLYYNPJIBLQCO67XANCNFSM4G2QK2FA
.

--
Yogesh Thanvi
QA Team Lead
Punchh Tech India Pvt Ltd

Thanks for the suggestions, guys!
We are generally not very fond of glasses/liquids. 😓
I understand the absurdity of what I just said, but the name was picked as a reaction to a trend that I personally dislike very much (drinks as names for testing frameworks 🤦♂).
On the other hand, we don't have real ideas what a logo should look like.

The issue has been resolved. See the official Twitter of Detox.


repr and str have inefficient implementations

Describe the problem

Printing large dataframes is slow.
Also see #37. We are concatenating full columns, which is very slow for large dataframes. A solution similar to #39 will need to be implemented.
Source code / logs
import modin.pandas as pd

df = pd.read_csv(...)
print(df)

Closed via #41


WIP: Add streaming base classes and streaming statistics

Changing the base class for the StatisticsFilters to the ImageSink with streaming support when very smoothly. More testing and documentation passes are still needed.
Please review the style interface for the StreamingProcessObject and ImageSink classes.
A backwards incompatibility change introduced is that the LabelStatisticsImageFilter and StatisticsImageFilter no longer produce an image as output since they are no longer derived from ImageToImageFilter.

Looking good so far.

I have completed refactoring the classes. I'll write some detailed/corner cases tomorrow to wrap things up.
@romangrothausmann Please check out this PR and test the classes. Thank you!

Many thanks @blowekamp, this is a very great contribution! Your former module for ITK4 has helped us a lot when we were in the need to get statistics of very large datasets and we worried about its missing compatibility with the transition to ITK-5. With this PR this would be solved and its future maintenance ensured. In addition it is great that this PR also includes the ideas of https://github.com/blowekamp/itkStreamingSinc/pull/3.

This patch should be ready to go. I'm just refreshing the CI after one VNL test failure due to time profiling.

Trying to test this with my ITK-CLIs and am hitting the backwards incompatibility that the StatisticsImageFilter no longer produce an image as output. What would be the recommended way to adjust the code accordingly? Basically I would replace e.g.
stat->SetInput(extractor->GetOutput());
adder->SetInput1(stat->GetOutput());
adder->Update();
std::cerr << stat->GetMaximum();

by
stat->SetInput(extractor->GetOutput());
adder->SetInput1(extractor->GetOutput());
adder->Update();
stat->Update();
std::cerr << stat->GetMaximum();

Is there a more elegant way to trigger stat to update if adder is updated, similar to how it was possible before?

Great, thank you for testing!
I take it there is no streaming involved here. All you should have to do is simple call stat->Update(); seems elegant to me. :sunglasses:

Thanks for the feedback. No, no streaming there. I'll just  use the additional stat->Update();
I am hitting this though with Module_ParabolicMorphology=ON:
/opt/itk/include/ITK-5.0/itkParabolicOpenCloseSafeBorderImageFilter.hxx:48:48: error: no matching function for call to 'itk::StatisticsImageFilter<itk::Image<unsigned char, 3u> >::GetOutput()'
     typename TInputImage::SpacingType spcing = m_StatsFilt->GetOutput()->GetSpacing();

Currently trying to find where the sources for that module reside.

Here is a PR to improve that filter: InsightSoftwareConsortium/ITKParabolicMorphology#26

@blowekamp I'm getting warnings like:
WARNING: In /opt/itk/include/ITK-5.0/itkImageSink.hxx, line 88
ImageToHistogramFilter (0x2955840): Unable to convert input "HistogramBinMaximum" to type N3itk5ImageIfLj3EEE

when using ImageToHistogramFilter of this PR with my hist see e.g. the log here for SDI:
https://gitlab.com/romangrothausmann/ITK-CLIs/-/jobs/214553760
and also if not using SDI:
https://gitlab.com/romangrothausmann/ITK-CLIs/-/jobs/214553759
It is unclear to my why and what to do about them. The result is still the same though.

@blowekamp  I am also getting new warnings for every run of my application:
WARNING: In /Shared/johnsonhj/Binaries/20190513/Linux/NEP-14/ITKv5/Modules/Core/Common/include/itkImageSink.hxx, line 88
LabelStatisticsImageFilter (0x278c2d0): Unable to convert input "LabelInput" to type N3itk5ImageIdLj3EEE

WARNING: In /Shared/johnsonhj/Binaries/20190513/Linux/NEP-14/ITKv5/Modules/Core/Common/include/itkImageSink.hxx, line 88
ImageToHistogramFilter (0x279bd70): Unable to convert input "AutoMinimumMaximum" to type N3itk5ImageIsLj3EEE

WARNING: In /Shared/johnsonhj/Binaries/20190513/Linux/NEP-14/ITKv5/Modules/Core/Common/include/itkImageSink.hxx, line 88
ImageToHistogramFilter (0x279bd70): Unable to convert input "HistogramSize" to type N3itk5ImageIsLj3EEE

WARNING: In /Shared/johnsonhj/Binaries/20190513/Linux/NEP-14/ITKv5/Modules/Core/Common/include/itkImageSink.hxx, line 88
ImageToHistogramFilter (0x279bd70): Unable to convert input "MarginalScale" to type N3itk5ImageIsLj3EEE


[Serum-Exchange] initial scaffold commit

This is some scaffolding and parts required for using Serum
I am currently in the process of translating typescript and JavaScript logic to be able to subscribe to Serum in Java. There are several parts to getting this working correctly but I think it makes sense to commit this in parts given it's a lot of logic.
I had to inevitably bring one dependency Java Binary Block Parser (JBBP) because without deserializing the raw bytes is a lot of code/hard to read.

@timmolter

Looks awesome except for the test failures!!

Should be good now


[DEV-1386] add exchangeTx entity

Release Checklist
Pre-Release

[ ] Check migrations

No database related infos (sqldb-xxx)
Impact on GS (new/removed columns)

[ ] Check for linter errors (in PR)
[ ] Test basic user operations

Login/logout
Registration
Update user data
Create/delete payment routes
deactivate blackSquad Mails

Post-Release

Test basic user operations
Monitor application insights log
Update Env

Update Env + deactivate blackSquad Mails before merging in master!


[release/1.6] Updating hcsshim vendoring to 0.9.12 to include an important backported fix

The backport PR:
[https://github.com/microsoft/hcsshim/commit/6749c2f4196edcd51cfbd85dcb0f411613b7de82 / https://github.com/microsoft/hcsshim/pull/2187] (https://github.com/microsoft/hcsshim/pull/2188)
Along with another fix checked in a while ago.

CI is failing because the commit message is missing  DCO sign-off

All CI have passed on this one.


Expected argument type for POSStopFilter() and POSKeepFilter() is unclear

Thanks for a great library!
It seems that POSStopFilter() and POSKeepFilter() don't expect str.
(v0.3.6)
>>> from janome.analyzer import Analyzer
>>> from janome.tokenfilter import *
>>>
>>> s = '吾輩は猫である'
>>>
>>> a = Analyzer(token_filters=[POSKeepFilter(u'助動詞')])
>>>
>>> for token in a.analyze(s):
...     print(token)
...
は	助詞,係助詞,*,*,*,*,は,ハ,ワ
で	助動詞,*,*,*,特殊・ダ,連用形,だ,デ,デ
ある	助動詞,*,*,*,五段・ラ行アル,基本形,ある,アル,アル
>>>
>>> a = Analyzer(token_filters=[POSKeepFilter([u'助動詞'])])
>>>
>>> for token in a.analyze(s):
...     print(token)
...
で	助動詞,*,*,*,特殊・ダ,連用形,だ,デ,デ
ある	助動詞,*,*,*,五段・ラ行アル,基本形,ある,アル,アル

If str is not expected, it's better to update example code in docs to avoid confusion.

https://github.com/mocobeta/janome/blob/0.3.6/examples/usage_analyzer.py#L22

if str is expected, tokenfilter.py should be updated.

https://github.com/mocobeta/janome/blob/0.3.6/janome/tokenfilter.py#L75
https://github.com/mocobeta/janome/blob/0.3.6/janome/tokenfilter.py#L98

For example:
self.pos_list = pos_list

->
if type(pos_list) == str:
	self.pos_list = [pos_list]
else:
	self.pos_list = pos_list

Thank you for pointing it. I fixed usage_analyzer.py on the develop branch.
I like your second option (POSKeepFilter can take list or str,) it will come feature releases. PR is welcome of course!

Thank you for the prompt response! I would be glad if you could update tokenfilter.py someday.
Please close this issue whenever you like.


Align repo with Sous-chef VScode repo

Description
Brings the repo in line with other sous-chef repos (taking inspirations from vscode). Also attempts to setup circle ci and reduce the test matrix a bit to remove unsupported (or soon to be) versions (like ubuntu 14.04)
Future work
I would like to convert the cookbook to be a custom resource only without attributes / recipes and require chef 14 and only keep sous-chef specific versions (as documented here: https://sous-chefs.org/docs/best-practices/)

Looks good, just added a couple small fixes and listed everything out on the circle config (this can be done with a new script in repo management: dokken list -j | ../repo-management/scripts/circleci_maker.rb > ./.circleci/config.yml)

@damacus could you wire up the circleci backend for this one please, and fix my terraform issue?

@Xorima that's been enabled 👍

          1 Warning

:warning:
This is a big Pull Request.

  Generated by :no_entry_sign: Danger

@JanStevens  all yours :+1: , if you need a hand feel free to drop a message in sous-chef slack and I will try to aid you


Battle Factory: Update sets

OU set changes: https://pastebin.com/gsYEEnP6
NU set changes: https://pastebin.com/v3r3LduC https://pastebin.com/6rfDFCJT
PU set changes: https://pastebin.com/Yft1g9L1
LC set removal reasoning:

[1:03 PM] Quote: remove axew, anorith, venipede, tyrunt, cranidos, skrelp, magby, spinarak, darumaka, deerling, dratini, goldeen, inkay, lileep, mankey, natu, sandile, stufful, sandshrew, tentacool, budew, cubone, dewpider, fletchling, honedge, lickitung, remoraid, stunky, treecko, teddiursa, minccino, rowlet
[1:03 PM] Quote: that's mostly a list of shitmons that have no place in BF
[1:04 PM] Kalalokki: wait all of those?
[1:04 PM] Quote: yes. They're all mons that are super low on our VR
[1:04 PM] Quote: or not even on the vr any more
[1:04 PM] Kalalokki: aight

The changes in random-teams.js for items, abilities, and natures allows Pokemon to have multiple natures listed on a set, and this also cleans up the picking for all of them. I removed itemVariants/abilityVariants because they were never defined, modified, or used outside of the changed code and thus didn't do anything.
The change to level comes because OU's Pyukumuku set has it listed as level 96, which is what makes the set optimal.
The megaStone type check was added because people were reporting that Monotype allowed illegal combinations like Mega Altaria or Mega Charizard X on Flying teams.

Ubers has also provided sets for me to update/add/remove, but it requires an entire rehaul of all Ubers sets, so I'm doing that separately, considering this PR is already somewhat large.

I will assume there’s no user errors in the sets.

Our unit tests include a spellchecker for Battle Factory sets! Mostly because I was really annoyed by past typoes.

i test my code :[

To be fair, Battle Factory sets are hard to test. It's not like you're going to reload the game until you get the new sets or something.


Does automating the addition of vendor prefixes to css require JS?

In an effort to find a solution to the TailwindCSS issue, we seem to have a more fundamental issue. That problem is: how are we going to add vendor prefixes to our css code? We can use NodeJS, but that would violate a basic goal of the project.
I have searched for a package on Nuget that would automatically add vendor prefixes to css. What I found is a Nuget package that would use JS, and it seems like some of the dependencies are obsolete, but I'm not sure.

I found another Nuget package, but it doesn't seem like exactly I'd be looking for.


Serve Run 1 data via Data Catalog

Hi @TomGlanzman - are you set up to ingest the Run 1 visit eimages into the Data Catalog as they are made? @jbkalmbach wants to see how his lenses turn out!
Here's the link to the Twinkles Data Catalog - looks like its currently empty, after the test files were cleared away I guess. Great if you can fill this up in some intuitive way, Tom!

The data catalog is currently empty.  Given inevitable start up glitches, do not expect anything sensible until I publish a URL.

Got it. Stand by, Bryce!
On Thu, Feb 18, 2016 at 4:41 PM, Tom Glanzman<EMAIL_ADDRESS>wrote:

The data catalog is currently empty. Given inevitable start up glitches,
do not expect anything sensible until I publish a URL.
—
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/135#issuecomment-185995215
.

Re-posting from @TomGlanzman 's https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/137#issuecomment-189335922:

Five test runs are now complete and the data are available via the data catalog. Navigate to http://srs.slac.stanford.edu/DataCatalog/?experiment=LSST-DESC then to /LSST-DESC/Twinkles/Twinkles-phoSim/singleVisit. The five complete runs include task streams 0,1,2,5,13. The remaining 12 jobs are still running at this time. Note that stream 0 (corresponding to Opsim_obhistid 484933) had its instance catalog stripped down to four sources; at some point, I should rerun that one with the full catalog.

So we are halfway to closing this one :-) @tony-johnson Let us know when there are DM Level 2 products to be browsed as well!

We did not make the DM level 2 products available via the data catalog at present, because it is not obvious how to marry the butler and data catalog. This is an issue which we will follow up with the DM team at SLAC.

Sounds good. Thanks!
On Thu, Mar 17, 2016 at 9:48 AM, Tony Johnson<EMAIL_ADDRESS>wrote:

We did not make the DM level 2 products available via the data catalog at
present, because it is not obvious how to marry the butler and data
catalog. This is an issue which we will follow up with the DM team at SLAC.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/135#issuecomment-197970016


[Ember UI] Partial selection checkbox is not updating when few items are selected

Setup

Rancher version: v2.6-head 68c6c13
Browser type & version: Chrome Build 101.0.4951.64

Describe the bug

When selecting few items in a list, the checkbox in the header does not update to show a partial selection
To Reproduce

Go to any list in Rancher
Select a few items
Verify if checkbox in the header is updated to show a partial selection

Result
The checkbox in the header does not update to show a partial selection

Expected Result

The checkbox in the header should show a partial selection

Deprioritizing this since people should be using the new Dashboard here.

The title says Ember but the screenshots show the dashboard. We should check if the issue exists in v2.6-head.


Bug : scroll up/down clear signature_pad

Hi,everone
When use of the source in mobile/tablet scroll down/up signaturpad cleaning automatic how can fix this bug? Please help me
Thanks

Same issue here.

I just disabled this line, its because mobile chrome triggers the onresize (since it hides the navigation bar)
//window.onresize = resizeCanvas;
But you can also modify the resizeCanvas() function to not clear the pad.

var cachedWidth;
for resize canvase
if(canvas.offsetWidth !== cachedWidth){ //add
    cachedWidth = canvas.offsetWidth;   //add
    var ratio = Math.max(window.devicePixelRatio || 1, 1);
    canvas.width = canvas.offsetWidth * ratio;
    canvas.height = canvas.offsetHeight * ratio;
    canvas.getContext("2d").scale(ratio, ratio);
    if (typeof signaturePad != 'undefined') {
        signaturePad.clear();
    }
}

to temporary save and load a signature when resizing the canvas:
function resizeCanvas() {
	var cachedWidth;
	var cachedImage;

	if(canvas.offsetWidth !== cachedWidth){ //add
		if (typeof signaturePad != 'undefined') { // add
			cachedImage = signaturePad.toDataURL("image/svg+xml");
		}
		cachedWidth = canvas.offsetWidth;   //add
		// When zoomed out to less than 100%, for some very strange reason,
		// some browsers report devicePixelRatio as less than 1
		// and only part of the canvas is cleared then.
		var ratio = Math.max(window.devicePixelRatio || 1, 1);
		canvas.width = canvas.offsetWidth * ratio;
		canvas.height = canvas.offsetHeight * ratio;
		canvas.getContext("2d").scale(ratio, ratio);
		if (typeof signaturePad != 'undefined') {
			signaturePad.clear();
			signaturePad.fromDataURL(cachedImage); // add
		}
	}
}

Please note, when switching between different image ratios, the drawn signature will be dissorted.

I just disabled this line, its because mobile chrome triggers the onresize (since it hides the navigation bar)
//window.onresize = resizeCanvas;
But you can also modify the resizeCanvas() function to not clear the pad.

Sometimes the browser clears the canvas on its own, when resizing. Hopefully this doesn't happen when just scrolling by a canvas.

closing as stale. Nothing this library can do about it.


skipping app.js in coverage report, but only for one project

Hopefully this is a noob issue on my part and not a bug. Summary as per title.
I created a sandbox project with ava and nyc for me to experiment, because I am new to both tools. I was impressed with the ease of generating a quality coverage report. I added an "nyc" section to package.json and it just worked.
Then I added ava and nyc to my in-progress project and copied the "nyc" configuration section from/to package.json. And it just worked -- mostly. There was one odd omission: the main file app.js did not appear in the coverage report. I even added a do-nothing test that requires app.js, but that one file still did not appear.

Link to bug demonstration repository
The project has a ton of code and temporarily has app-secret IDs in text config files, so I cannot create a public repo.

Observed Behavior
The file app.js does not appear in the coverage report of my Actual project, but it does appear in the sandbox project's report.
Observed that with "include":["*.js",...], the other files in the same directory are shown in the report, but not app.js. This is puzzling.
Sandbox Project coverage report
$ npm test

><EMAIL_ADDRESS>test /home/dfvsmdev/workspace/jslab/ava-lab
> nyc ava

  3 tests passed
---------------------|---------|----------|---------|---------|-------------------
File                 | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
---------------------|---------|----------|---------|---------|-------------------
All files            |    3.21 |        0 |    4.76 |    3.32 |
 ava-lab             |       0 |        0 |       0 |       0 |
  app.js             |       0 |        0 |       0 |       0 | 1-41
 ava-lab/routes      |       0 |      100 |       0 |       0 |
  index.js           |       0 |      100 |       0 |       0 | 1-9
  users.js           |       0 |      100 |       0 |       0 | 1-9
 ava-lab/tools       |    3.67 |        0 |    5.08 |    3.81 |
  AdaptableObject.js |       0 |        0 |       0 |       0 | 8-18
  JSON.prune.js      |       0 |        0 |       0 |       0 | 15-175
  appData.js         |       0 |        0 |       0 |       0 | 3-79
  base32.js          |       0 |        0 |       0 |       0 | 3-53
  dataStoreLocal.js  |       0 |        0 |       0 |       0 | 2-176
  uuid.js            |     100 |      100 |     100 |     100 |
---------------------|---------|----------|---------|---------|-------------------

Actual Project coverage report
$ npm test

><EMAIL_ADDRESS>test /home/dfvsmdev/workspace/secure-sign-grp-mgr-lab/securesign-web-app
> nyc ava

  2 tests passed
---------------------------|---------|----------|---------|---------|--------------------------------------------------------
File                       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
---------------------------|---------|----------|---------|---------|--------------------------------------------------------
All files                  |   36.61 |    24.18 |   28.75 |   36.87 |
 securesign-web-app        |   12.07 |     3.57 |       0 |   12.07 |
  graph.js                 |   11.63 |        5 |       0 |   11.63 | 14-105
  tokens.js                |   13.33 |        0 |       0 |   13.33 | 15-20,33-48
 securesign-web-app/routes |   30.77 |     3.85 |       0 |   31.37 |
  auth.js                  |   23.91 |     8.33 |       0 |   24.44 | 16-25,38-46,58-76,84-85,94-100
  calendar.js              |   31.58 |        0 |       0 |   31.58 | 13-48
  groups.js                |   26.09 |        0 |       0 |   26.09 | 13-57
  index.js                 |      50 |        0 |       0 |   55.56 | 12-23
  users.js                 |   66.67 |      100 |       0 |   66.67 | 6-8
 securesign-web-app/tools  |    44.9 |    32.81 |   38.98 |   45.34 |
  AdaptableObject.js       |      20 |        0 |       0 |      20 | 8-14
  JSON.prune.js            |   65.26 |    48.61 |   64.29 |   67.82 | 32,37-45,77-87,102,112,115,119-120,136,149,156-157,175
  appData.js               |   21.21 |     7.14 |      20 |   21.21 | 8-22,33-58,67-73
  base32.js                |       0 |        0 |       0 |       0 | 3-53
  dataStoreLocal.js        |   39.74 |    23.08 |      36 |   40.26 | 9-27,46-57,73-77,86-100,110,115-119,143-151,161-170
  uuid.js                  |     100 |      100 |     100 |     100 |
---------------------------|---------|----------|---------|---------|--------------------------------------------------------

Troubleshooting steps

[ ] still occurring when I put cache: false in my nyc config
[ ] tried with "include": [  "*.js", ...] and "include": [  "app.js", ...], no difference
[ ] added a test with require("app.js") , which successfully executes code in the file, but still the file does not appear in the report output

Environment Information
$ npx envinfo@latest --preset nyc
npx: installed 1 in 1.373s

  System:
    OS: Linux 4.15 Ubuntu 16.04.6 LTS (Xenial Xerus)
    CPU: (12) x64 Intel(R) Xeon(R) CPU E5-2620 v3 @ 2.40GHz
    Memory: 1.49 GB / 47.04 GB
  Binaries:
    Node: 12.16.1 - ~/.nodeenv/n1216/bin/node
    npm: 6.13.4 - ~/.nodeenv/n1216/bin/npm
  npmPackages:
    nyc: ^15.1.0 => 15.1.0

I discovered the proximate cause of the problem. There was a function in the app.js file with a variable named interface. Presumably using a keyword as a variable name broke something inside nyc, or maybe inside AVA.
Please note that nodejs runs with this. I'm not saying the code is good -- it's not and I have changed it.
The expected behavior here would be for nyc to print a diagnostic message: a warning, or error, or something. Silently failing is just confusing.

@pmclee Saved my day, thanks!


feat: added css changes for alex

What I did

fixes: #
How I did it
How to verify it
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

is this dup of https://github.com/ApeWorX/ape/pull/454?

Oh oops yeah, except I ran an auto-formatted (prettier) on mine! Can we do that?

Oh oops yeah, except I ran an auto-formatter (prettier) on mine! Can we do that?

Lol, just merge whichever one is better!


Improvement of CSS portion

I would like to improve the design of the website

Please assign this to me @yashksaini-coder

@noobremon any updates on the issue ??

Yes I have enhanced the CSS part tried to give it attractive interface and now thinking of adding new pages to the website
@yashksaini-coder


Updating for angular 5

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Hi,
will you update this seed for angular 5?
Thanks

At some point we stopped tagging releases because new patch versions get pushed weekly.
Master always contains stable version of the seed. With the previous consistent tagging, I can see that this may create confusion for newcomers to the seed. I will add information about this in the readme.
Thanks for pointing this out!

Thanks you!
In my opinion, it should be usefull this extensions:

A sonar task for the static code analysis and publish on a server
A semver task to add suffix in a  project version

If you need help, I will be happy to contribute for full stack development tools !


Removes Index and Storage from zipkin-cassandra

Cassandra is the last backend using Index and Storage instead of
SpanStore. Eventhough there's work in progress to replace Cassie with
an alternative Cassandra impl, removing this as an interim unlocks our
ability to remove legacy code.
See #483

tested via the following:
``bash
./gradlew :zipkin-aggregate:run
and in separate windows
bin/collector cassandra
bin/query cassandra
bin/web
bin/tracegen
open http://localhost:8080/

going to merge on green eventhough #585 will obviate it. Almost done the cleanup, and this makes that work easier.


Aim clamp needs a rework

Use an aim clamp weapon like the torch
Move your aim to the top
Turn the opposite direction
Notice that your character will be aiming downwards now

Thanks @Ephememory


[Bug]: wrong markdown list checkbox parsing

Before you file a bug report

[X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
[X] This issue is not a troubleshooting question. Troubleshooting questions go here: https://forum.mattermost.com/c/trouble-shoot/16.
[X] This issue is not a feature request. You can request features and make product suggestions here: https://mattermost.com/suggestions/.
[X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] This issue reproduces on the most recent stable version, or the most recent prerelease version of the Mattermost Desktop App.
[X] I have read the contribution guidelines.

Mattermost Desktop Version
5.5.1
Operating System
Windows 11 x64
Mattermost Server Version
No response
Steps to reproduce
- blablaba
  - [x] blabla
  - [x] blabla

- [x] blabla

- blabla

Expected behavior
I expect to see normal list similar as on screenshot

Observed behavior
One of checkboxes remains [x]

Log Output
[2023-10-09 17:33:59.137] [error] Logger Log level set to: info
[2023-10-09 17:33:59.335] [info]  [App.Config] config.autostart has been configured: true
[2023-10-09 17:33:59.380] [info]  [App.Config] config.autostart has been configured: true
[2023-10-09 17:33:59.541] [info]  [ServerDropdownView] init
[2023-10-09 17:33:59.589] [info]  [i18nManager] Set new language ru
[2023-10-09 17:33:59.620] [info]  [App.Config] config.autostart has been configured: true
[2023-10-09 17:33:59.661] [info]  [App.Config] config.autostart has been configured: true
[2023-10-09 17:34:00.138] [info]  [App.Config] config.autostart has been configured: true
[2023-10-09 17:34:04.503] [info]  [UpdateManager] Checking for update
[2023-10-09 17:34:05.130] [info]  [UpdateManager] Update for version 5.5.1 is not available (latest version: 5.5.1, downgrade is disallowed).

Additional Information
No response

This is a webapp issue, transferring to main repo.


Connected tooltip lags and glitches on paired chart

Version
5.1.0 (Firefox)
Steps to reproduce
echarts.connect([chart1, chart2]);

What is expected?
Tooltips animate in unison.
What is actually happening?
The tooltip of the paired chart that the user is not interacting with lags behind the one that the user is interacting with. In 5.1.0, it becomes even worse, starting to "glitch out", by warping to random positions at single frame intervals.
5.0.2 (lag)

5.1.0 (lag and glitching)

@plainheart Is this related to the new transform enhancement in tooltip?

I'm not very sure yet. I have known about this issue since the initial development. But it seems it only occurs when transition: transform is enabled and the dev tool is open.

@plainheart Remind me that we also met some lag performance issues when devtool is open.

@pissang Please note, in the example videos, I am using Firefox. Devtools are not open.
After examining the results in Chrome, I understand why you were talking about the dev tools (developer console). Yes, in Chrome, it seems to work perfectly well unless the developer console is open. However, in Firefox this is a problem all the time, whether the console is open or not. Therefore I think this is quite a serious issue.

Does the tooltip issue only occur in the connected charts? I just ran the simple line demo in Firefox 88, it's even working better than Chrome even if the devtools is open.

Yes, only the connected chart is impacted.

I checked a connected chart in firefox, it looks okay. https://codepen.io/plainheart/pen/KKarOZb

Doesn't look that good to me.

Seems so. I updated the data, it can be reproduced in Firefox.

@plainheart Thank you for making the simple test case. I hope you can figure out a fix.

@Bilge Hi, I updated the ECharts lib used in the demo. I checked it in Firefox, it seems okay. Could you help check it again with your environment? Thanks.

@plainheart It's good 😁 👍

@pissang To find out why the tooltip is lagged and shakes from side to side, especially in the connected charts, I dug slightly into the related source code. Currently, I'm thinking it may be for the method TooltipView#_updatePosition will be very frequently called when mousemove. Only in 4ms, it seems to be called many times. The normal chart can work smoothly, but in the connected chart, it will become worse. As far, I tried to throttle the _updatePosition function in 50ms(the tested result may need to validate), it's working better in both Chrome(with the devtools open) and Firefox even if we use the previous way left/top.
Here is the demo using the ECharts lib based on this temporal solution, it seems to be working well in Firefox and Chrome with the devtools open. https://codepen.io/plainheart/pen/KKarOZb
The branch for this change is https://github.com/apache/echarts/tree/fix-tooltip. Related test case is tooltip-lag-glitch.html.

Hello,
I am figured the same issue but it occurs only in Chrome when I open the devtools console. All is working fine with Firefox.
When the devtools console is closed :

When I open the devtools :

Here is the config : https://pastebin.com/LVLMdn3G

@plainheart Why is this still not merged? I can't upgrade whilst this issue still persists.

@Bilge Sorry for putting this matter on hold. I've opened PR #15683 to make it go ahead.

@plainheart Very good, thank you!


Adds "LCSC Part" as an LCSC property; a "Description" column is shown to the user.

-Adds "LCSC Part" as an LCSC property.
-Adds a "Description" column to the footprint list.
-Adds a new setting for the schematic property name.
-Hooks up the property name setting to the schematic export.

@gonzalop possible to include some screenshots showing what this looks like and comments about why you've made the change?

This is how it looks like:

As for the comments, can you be more specific? One of the commits has the reason to add 'LCSC Part' (easyeda2kicad uses that name when importing footprints and 3dmodels, and this is also the LCSC database column name)

Obsolete due to #551


mat-expansion -  fix 9134 overwrites this fix 9313

This fix 9134 overwrites this fix 9313
Fix 9313 should not be overwritten
Fix 9313 is not working anymore
Affected version:
Material 5.2.2

Closing as #9313 was reverted intentionally by #9580


How to load the customized layer and loss function.

Hi,
I'm training the LSTM-CRF model for NER.
I used the keras_contrib.layers import CRF as the CRF layer. Once I finished the training, I saved the model by model.save('testing_new_all_trainning_words.h5'). But when I tried to load the model by
from keras.models import load_model
model = load_model('testing_new_all_trainning_words.h5')

I got exception:
"ValueError: Unknown layer: CRF"

Required, as usual
from keras.models import load_model
Recommended method; requires knowledge of the underlying architecture of the model
from keras_contrib.layers.advanced_activations import PELU
Not recommended; however this will correctly find the necessary contrib modules
from keras_contrib import *
Load our model
model = load_model('example.h5')
Do try something like above , please refer to the readme file (Front page - last part)

@anand-sonawane It didn't work. I still get the same error. My keras version is 2.1.6

@doggeral Have you solved this issue? I have the same problem now.

from keras_contrib.layers import CRF
from keras_contrib.losses import  crf_loss
from keras_contrib.metrics import crf_viterbi_accuracy

model= load_model('your_model.h5',custom_objects={'CRF':CRF,
                                                  'crf_loss':crf_loss,
                                                  'crf_viterbi_accuracy':crf_viterbi_accuracy})


Fix vmq_admin session show

This should fix the combinator issues we've seen with vmq-admin session.
I'll add more testing

Playing with it I found this example which hangs - I have no idea at all if this is supposed to work or not:
(VerneMQ@<IP_ADDRESS>)3> Q = "SELECT * FROM sessions WHERE client_id LIKE 'cli%'".
"SELECT * FROM sessions WHERE client_id LIKE 'cli%'"
(VerneMQ@<IP_ADDRESS>)4> vmq_ql_query_mgr:fold_query(fun(Row, Acc) -> [Row, Acc] end, [], Q).

I had one offline client at that point:
(VerneMQ@<IP_ADDRESS>)1> Q5 = "SELECT * FROM sessions WHERE  is_online=false".
"SELECT * FROM sessions WHERE  is_online=false"
(VerneMQ@<IP_ADDRESS>)2> vmq_ql_query_mgr:fold_query(fun(Row, Acc) -> [Row, Acc] end, [], Q5).
[#{'__mountpoint' => [],clean_session => false,
   client_id => <<"client">>,deliver_mode => fanout,
   is_offline => true,is_online => false,is_plugin => false,
   mountpoint => <<>>,node =><EMAIL_ADDRESS>   num_sessions => 0,offline_messages => 1,
   online_messages => 0,queue_pid => <0.317.0>,
   statename => offline},
 []]

Oh damn, have to cleanup the deprecated random stuff in the test module.

LGTM!


duf: init at 0.1.0

Motivation for this change
Add duf to nix.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I am a little bit unsure about the similar named duff but I think this is okayish.

Closing in favor of #98396. Should have checked that. :joy:


Ritual skill is visible to players even with SAN hidden, which makes it possible to know your current san.

Title explains most of it, if the players do know how the ritual skill is calculated(in my case they do), they can easily subtract its score from 99 and get their current sanity. Would be neat to hide that score too, didn't find an option to do so in the settings.

@hydrated12  Sorry for the long delay on this one, but hopefully this should be fixed now with v1.0.3 of the system.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_a099016b-eb88-41b2-8bef-d43fc98e4e6d/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_a099016b-eb88-41b2-8bef-d43fc98e4e6d.git

Docs Build status updates of commit c6e75fe:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Question: about ComboBox

Is there a way I can run some code if I press Enter when hovering over a ComboBox?

Figured out that I could use the WarMenu.IsItemSelected API.