calander

@Manishak798 I would like to add a calendar.
So can you please assign me this issue under Hacktoberfest2023?

I can add calender in python ,Can you pls assign me this issue @Anju-Narnolia

Where do you want to add the calendar?

as a part of contribution int the form of code

Where do you want to add the calendar?

@Manishak798 as a project just like the Amazon landing page.
about project and project link.

Where do you want to add the calendar?

@Manishak798 as a project just like the Amazon landing page. about project and project link.

go ahead.


Revert "shell: backends: uart: avoid unnecessary TX IRQs"

This reverts commit d2e5eeb51d3364585c2fec13d5f44784e06da53e.
PR zephyrproject-rtos/zephyr#71172 is causing the bug reported on issue zephyrproject-rtos/zephyr#72598.

@robhancocksed please review.

See comment under https://github.com/zephyrproject-rtos/zephyr/issues/72598 - it seems that the bug is really in the uart_ns16550 driver, if I am interpreting the API definition correctly.

See comment under #72598 - it seems that the bug is really in the uart_ns16550 driver, if I am interpreting the API definition correctly.

It's possible that there is a bug in the NS16550 driver.  However, the change to the shell is blocking our work downstream.  I believe a revert first policy is the correct approach here.  If a fix is identified for the NS16550 driver, then the change to the shell can be re-landed.


No such file or directory: './checkpoints/t2m/length_estimator/model/finest.tar'

Hello,during the replication process, I encountered a stumbling block while executing the gen_t2m.py script. Specifically, the script attempts to load a model file named finest.tar from the directory ./checkpoints/t2m/length_estimator/model/, but I was unable to locate this file in the repository or any documentation related to it.
I was wondering if you could offer some guidance on how this file can be obtained or generated. Is it something that should be manually created, or is there a download link available that I might have missed? Your insights on this matter would be greatly appreciated and would greatly facilitate my progress with replicating the project.
Thank you for your time and assistance. I look forward to your advice and continuing to learn from your work.
Warm regards

In README.md Get You Ready 2. Models and Dependencies, I think you should run
bash prepare/download_models.sh
to download the folder humanml3dmodels, in this folder there exists a length_estimator.
By the way, I still cannot get the kit/length_estimator so I cannot generate demos by my replicated model on KIT.

Following the instructions provided in the README.md under the section "Get You Ready 2. Models and Dependencies," I executed the command bash prepare/download_models.sh to download the necessary models, specifically targeting the humanml3dmodels folder for the length_estimator. However, after the download completed, I could only find the Comp_v6_KLD005 and text_mot_match directories within the humanml3d_evaluator folder, and the length_estimator was conspicuously absent.Could you please provide guidance on how I might resolve this issue?

can you check your humanml3d_models.zip? In my downloaded folder there exists a folder length_estimator.

After double-checking, I realized that I had been looking in the wrong folder for the length_estimator. It turns out that it is located in the humanml3d_models directory, not humanml3d_evaluator as I initially thought.
Thank you for your guidance, and apologies for any confusion caused. I appreciate your support, and I'm excited to continue working with your project.
Best regards

In README.md Get You Ready 2. Models and Dependencies, I think you should run bash prepare/download_models.sh to download the folder humanml3dmodels, in this folder there exists a length_estimator.
By the way, I still cannot get the kit/length_estimator so I cannot generate demos by my replicated model on KIT.

Hi, thanks for your help on addressing this issue. We only train length_estimator for demonstration only on HumanML3D. For KIT dataset, you may train the length_estimator by your own.


auth: Add modularization progress for Identifier, Tenant, TenantManager, TokenGenerator (3/N)

I will be progressively doing PRs into hlazu-modularizing-auth-combined for the modularization effort. The end-result will be similar to that in #992.
This covers: Identifier, Tenant, TenantManager, TokenGenerator

Thanks for the feedback, PTAL :)


[feat]Add offloader stats grafana dashboard

Motivation
Add grafana dashboard of offloader stats which introduced by https://github.com/apache/pulsar/pull/13833

Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Closing and reopening to get Pulsar CI unblocking changes included.

Thanks for contributing, @dao-jun

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.18%. Comparing base (bbc6224) to head (e48e2f2).
Report is 686 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23479      +/-   ##
============================================
+ Coverage     73.57%   74.18%   +0.60%
- Complexity    32624    34331    +1707
============================================
  Files          1877     1943      +66
  Lines        139502   146973    +7471
  Branches      15299    16191     +892
============================================
+ Hits         102638   109029    +6391
- Misses        28908    29519     +611
- Partials       7956     8425     +469

Flag
Coverage Δ

inttests
27.52% <ø> (+2.94%)
:arrow_up:

systests
24.35% <ø> (+0.02%)
:arrow_up:

unittests
73.54% <ø> (+0.70%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 655 files with indirect coverage changes


Failed to connect to <IP_ADDRESS> port 9292: Connection refused

I have similiar problem to issue #26. I've checked <IP_ADDRESS>:9292 and localhost:9292 and <IP_ADDRESS>:9292
I have created instances using docker-machine on osx.
  If not, open a fresh ticket with exact steps to reproduce


White Square

Today I woke up to this white square where the microphone would be. I have the current version of the mod. Please let me know if you need any more info.

nevermind, wrong mod


Special Characters not showing on control label

after version 4

before version 4

Hi @ravishakya , thanks for letting us know this issue :)
Please try this v4.0.15 update: v4.0.15
Thanks :)

Now its working.
Thank You


All horizontal panes

+-----------------------------------+----------------+
| ................................. |                |
| ⋮     vim     ⋮       vim        ⋮ |   tmux pane    |
| ⋮     split 1 ⋮       split 2    ⋮ |                |
| ................................. |                |
+-----------------------------------+----------------+

With an all-vertical or all-horizonal split of tmux-panes/vim-splits, it seems that it's not functioning how I would expect. I see that the tmux pane always resizes, and it's not clear what vim is doing. I feel like sometimes i see both the tmux pane resize as well as the vim split grow/shrink in the correct direction.
I would expect the behavior to mimic, the behavior as though all 3 splits were tmux panes.
i.e. (i think)

focused split 1, with M-l, split 1 would grow
focused split 1, with M-h, split 1 would shrink
focused split 2, with M-l, tmux pane would shrink with split 2 getting bigger
focused split 2, with M-h, split 1 would shink
focused tmux pane, with M-h, split 2 would shink
focused tmux pane, with M-l, tmux pane would shrink, split 2 would grow

fwiw, when running :TmuxResizerProcessList, i do see
S+   /nix/store/65dsr3ng8wiwh12sipfnv3m8cjxb3hmz-neovim-unwrapped-0.4.3/bin/nvim
Ss   -zsh

i.e. missing tmux
tmux: tmux 3.0a
vim: nvim 0.4.3
os: macos mojave

Confirmed this is an issue for me too. I normally don't stack more than 2 vertical or horizontal. I'll try to fix.

@DanCardin I pushed some changes to the underlying way that passing the resize to Tmux is determined. I'm now seeing the same behavior when resizing between vim/tmux (in the layout you have above) as resizing 3 regular tmux panes. Update your plugins and give it a try.
That said, the default tmux behavior I'm seeing isn't exactly the way your comment describes it. Tmux seems to be resizing the pane in the middle by moving only it's right-most border.

Yea, I wasn't sure that the way I was describing it matched exactly the right behavior; as long as it matches the non-vim resize behavior, that's what i meant.
Just updated now, and it i think it totally does! thanks!


chore: secuirty updates

Codecov Report

Merging #1 (c409db2) into master (d9d950b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           43        43
=========================================
  Hits            43        43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d950b...c409db2. Read the comment docs.


OCPBUGS-25104: revert dev cert rotation 4.16

/jira refresh

@tkashem Can you add backport label?
@wangke19 Would you mind adding cherry-pick-approved?

/label backport-risk-assessed


bfc: 1.10.0 -> 1.11.0

Diff: https://github.com/Wilfred/bfc/compare/1.10.0...1.11.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 238301 run on aarch64-darwin 1

1 package built:

bfc


Clarifying that unreleased changes may be reverted

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This clarifies that unreleased changes may be reverted. This is important to note since we continue to actively develop on our master branch.
Does this PR introduce a user-facing change?:
NONE

To clarify a bit further here, I'm not trying to suggest that we should merge things with the intent of reverting them later. Instead I'm trying to ensure that no one relies on our latest commits to any branch. This would be a similar approach to Kubernetes in that nothing should be relied on outside of a published release.


iOS support and mmap

I found the work of Proteas for ios support and expanded a bit on it in this branch.
iOS needs a different API for using shared memory (mmap-based).
I adapted it, refactored some common shared memory handling code into one place, made it the default and tested it for Linux (which has mmap and shmat).
I also extended afl-as.h to support non-llvm-mode (but I am not an assembly programmer).
It would be nice if the adapted programs (afl-as, afl-fuzz, afl-analyze, afl-showmap, afl-tmin, afl-gcc, afl-g++, afl-clang, afl-clang++) could be tested for other platforms (maybe even for iOS).
My hope is that the mmap API is generally more available thus making afl more portable.
TODO: we need to auto detect whether the mmap API is available else fallback to shmat().

I will do the autodetection magic tomorrow

done!
Makefile autodetects if shm_open is availabel or not. plus some other fixes.
now we need to check if it is compiles fine on iphones, android, openbsd, MAC OS, etc.

@all: testing for IOS and Mac OS X as well as Android is still needed. Please use the master for testing, not the branch

Regarding Android: this needs support of ashmem API. Yet another shared memory interface.

@hexcoder- dont we have mmap and ashmem now? does this still needs to be open?

I think yes until someone will test it on iOS

Yes, but I was not able to verify.

I have Macbooks and jailbroken iPhones lying around, anything in particular I should try?

@domenukk - just see if it compiles and test.sh works :)
Mac should work but iOS? I think nobody has ever tried. so to get it working for tha twould be nice!

@domenukk - I never researched what minimum SDK is needed (and where to get it). Too much on my plate already...

For sure the link in the docu how to disable the MacOS crash daemon is broken...
https://github.com/vanhauser-thc/AFLplusplus/blob/master/docs/INSTALL.md#3-macos-x-on-x86

if it would not be broken very likly it would be outdated too :)
anyone with a Mac?

https://github.com/kholia/OSX-KVM
I installed this some days ago, a very simple setup. I had not enough time to play with it but seems to work.

I've tried it on MacOS. Happy to report even Unicorn Mode works. Speed with persistent mode is pretty good.

@domenukk so we can close this? MacOS works? how about iOS?

Mac OS works, however I never got around to test it on iOS as I just don't know how to set this up easily. Will try with my rooted phone later.

It works in iOS if the other shmget implementation is used. I hope we get a PR for this.


[FEATURE] Animal sheets for Bond Famulus/Coterie Sheets

Is your feature request related to a problem? Please describe.
The standard ghoul sheet isn't really useful for Bond Famulus, There's no Coterie sheet
Describe the solution you'd like
A generic sheet that can be used for animal ghouls (with Physical/Mental dice pools, etc) and a sheet for Coterie type/backgrounds/domain
Describe alternatives you've considered
Using the pre-existing ghoul sheets
Additional context
Add any other context or screenshots about the feature request here.

There is a Coterie sheet type.
As for Bond Famulus, I would agree it might be a good QoL idea.

What more would an animal sheet have over an SPC sheet?

Honestly, I think just updating the SPC sheet to have full discipline features like other sheets would be enough (and could be handy for making SPCs too so I can just give them specific powers)


Design an interface to make integrate and quadgaen work on user-defined custom types

Support a way for the user to input custom restriction to axes. I'm not 100% sure how to do that. In particular restriction_type is annoying (because my type has functions in its type parameters, and in some cases the type might depend on along which axis it's restricted), is it feasible to get rid of it?

Let me think about how to expose restriction to make it part of the interface. It should be doable, I need a bit of time to look at the code and propose a solution.

Maybe we should use this issue to discuss a reasonable interface instead of the more specific issue with restriction?

One thing I thought was to have a single phi(x) method, which is called with intervals, duals and intervals of duals, instead of having separate functions. This is equally easy to overload (it's not completely trivial to figure out the how the dual stuff works but you just have to copy/paste it from somewhere), works outside the box with no effort if you don't want to customize anything, and has no additional API surface. For relatively complex functions, it also allows a workflow where you only overload the parts you need and let intervalarithmetic / forwarddiff do the job for you if you don't care. You do have to depend on ForwardDiff and IntervalArithmetic but these are two pretty standard and stable packages so I'd say it's fine.
For restrict, simply have a default restrict(phi, val, dim) = (x -> phi(...)), which again can be overloaded?

Interface proposal:
Suppose phi takes R^N --> R. Then the following interface could work:

phi(x::SVector{N,<:Real}) --> eval
phi(I::SVector{N,<:Interval}) --> bound
phi(x::SVector{N,<:ForwardDiff.Dual{Tg,T<:Real,M}}), M <= N --> eval Jacobian vector product
phi(x::SVector{N,<:ForwardDiff.Dual{Tg,T<:Interval,M}}), M <= N --> bound Jacobian vector product

@antoine-levitt I added some documentation here. Would you mind taking a look and letting me know what you think? Feel free to patch it as you see fit.

I think we can consider this done right? Closing it...


Add Pedestrian Signals field to crossing presets

Added a Pedestrian Signals field to all the crossing presets so that mappers can indicate the presence of crossing signals. The checkbox adds the traffic_signals=yes tag to the way or node.

crossing=unmarked
crossing=marked
railway=crossing

(Apologies for the missing images in these screenshots; please use your imagination.)
This change encourages mappers to provide information about a crosswalk’s signalization, which is important for routing (think ETAs). Both marked and unmarked crossings can be signalized or unsignalized. Prior to this change, mappers were encouraged to indicate whether there are pavement markings (which is primarily relevant to renderers); they could change the Type field to traffic_signals to indicate signalization, but at the cost of losing markedness, and iD would discourage such a change by reverting to the “Unmarked Crosswalk” preset (#5652).
This PR’s choice of traffic_signals=yes diverges from the much more common, documented crossing=traffic_signals tag. However, traffic_signals=yes is the most widely used tagging scheme that’s compatible with the crossing=marked/unmarked scheme adopted in 1ffca3ce85d630539c7ebb11454a91770bd76536. The footway=crossing traffic_signals=* and highway=crossing traffic_signals=* combinations are already used 2,303 times worldwide, mostly in Europe. (traffic_signals:foot is more common, but it’s primarily used in traffic sign mapping, disconnected from any roads or paths.) This PR is also consistent with @nbolten’s draft proposal for crossing=marked/unmarked.
As in https://github.com/openstreetmap/iD/issues/5205#issuecomment-410784580, I was initially concerned that the use of traffic_signals=* on a crosswalk/roadway intersection node could cause the node to be interpreted as a vehicular traffic light by data consumers. However, vehicular traffic lights and crossing signals are mutually exclusive: in the absence of highway=traffic_signals, traffic_signals=* expresses a “has a” relationship, not an “is a” relationship. Moreover, for there to be a conflict, the node would have to be tagged highway=traffic_signals;crossing, which is a poorly supported, officially discouraged tagging style.
This PR only deals with traffic control devices that require pedestrians to wait. Traffic control devices requiring motorists to wait would be covered by a documented flashing_lights tag that can be added in a separate PR. Other follow-up improvements could include support for the traffic_signals:sound, traffic_signals:vibration, and button_operated tags.

I took a look at https://wiki.openstreetmap.org/wiki/Key:traffic_signals
and now I'm furious.
Forget it.
There is no way I'm going to support traffic_signals=yes for pedestrian signals, after the wiki folks aren't even ok with iD using traffic_signals=signal for a normal traffic signal - a tagging that was accepted just not very widespread before iD started doing it.
The OSM Wiki needs to end.   Seriously.   It's ruining this project.

You’re right, that page was over the top, so I reworded it. I’ll go back to the drawing board and find a less controversial way to let mappers indicate signalization, because I continue to believe that it’s a more important aspect of a crosswalk than the present of pavement markings.


fix(anvil): stricter memory limits in interval mining mode

Motivation
The previous max memory setting was pretty high resulting in bloated memory.
This decreases the max in memory limit and also adapts it if in interval mining, in which case it should be drastically decreased. so that only a couple blocks should be stored in mem, since unlikely older state will be requested at all.
this needs a followup to fix https://github.com/foundry-rs/foundry/issues/3623 which concerns disk space.

Solution

approved via #4189


System.Reflection.TargetInvocationException error occured when file being streamed.

System.Reflection.TargetInvocationException: 'Exception has been thrown by the target of an invocation.'
using (var stream = File.Open(filePath, FileMode.Open, FileAccess.Read))
above error comes at the file is being stream (above line)

What is the stack trace for the error? If the exception is thrown by File.Open then it most likely doesn't have anything to do with ExcelDataReader.


[tutorials] fix a bug in the code in datastore.md

Hi @mmurooka
Thanks for the fix. The CI failure is (of course) unrelated but I've pushed the fix to your branch.
Will merge when everything is green.


Enforce code style with rustfmt

Is this a desirable change? Or maybe a better question: is there a reason this hasn't been done before?

I'd like to see it done at some point, but there's a few reasons I haven't pushed for it yet.

I'd also want an enforcement mechanism to ensure we don't regress.
It immediately makes almost every outstanding branch have merge conflicts.

Okey dokes, that makes sense. Let's kill two birds with one stone then: fmt is run on every change and it only runs on the changed files, allowing for an incremental migration. This kind of sucks during the migration period since PRs will include extraneous changes, but I can't think of any better way to do it without completely ripping off the bandaid and breaking the 70 open PRs.
It works: success on no changed files and failure on changed files.

Incidentally I think this approach will still break every open PR, since their builds will fail with formatting changes unless the files they modify are already perfect. Without rustfmt supporting checking only modified lines (i.e. git-specific integration), I don't see a way to truly do this incrementally.
My preference would be that we get the next release out the door (0.24.0) and work through the backlog of mergeable and trivially rebase-able PRs, and then revisit turning on rustfmt. I think formatting the entire repo in one pass is the correct approach, to make it easier to use --ignore-rev/--ignore-revs-file, but I don't think now is the best time for it.

Works for me. I'll let you rip the bandaid and then you can merge this to add enforcement.

Incidentally I think this approach will still break every open PR, since their builds will fail with formatting changes unless the files they modify are already perfect. Without rustfmt supporting checking only modified lines (i.e. git-specific integration), I don't see a way to truly do this incrementally.
My preference would be that we get the next release out the door (0.24.0) and work through the backlog of mergeable and trivially rebase-able PRs, and then revisit turning on rustfmt. I think formatting the entire repo in one pass is the correct approach, to make it easier to use --ignore-rev/--ignore-revs-file, but I don't think now is the best time for it.
@asomers what are your thoughts?

I agree exactly.

Any chances to get this merged? While it will break any non formatted pull request, fixing it is as simple as formatting it again. With editor configured to auto format rust on safe working on non formatted files is very unpleasant.

Closed by https://github.com/nix-rust/nix/pull/1748


Some files have Admin1, Admin2 and Admin3  codes in the Ethiopia

We cannot wikify these at the moment. We should add these code in the wikifier and maybe have the option of annotatiing type=admin1_code, admin2_code or admin3_code

The Spatial units tab of the census dataset has the region, zone and woreda codes. The dataset file Population_Housing_Census_Atlas_of_Ethiopia_2007.xls is in the Ethiopian Data Registration Test shared folder.

The census dataset directly uses the W_CODE:

However, the Annual Producer Price and Annual retail price datasets explodes the woreda code into three columns, and they use string name for the region:

Use admin3 type, no need to use admin3_code.
Done


[JENKINS-37138] added cache to improve performance

I'm happy to test, just not sure how to build the hpi/jpi from your branch. Any tips? Do I need to mvn install from a special directory?

Nevermind, I see the instructions in the README, "./gradlew jpi", testing now... :)

Tested locally first then deployed to our production instance which uses job-dsl to generate few hundred jobs. It's awesome! We have 4 different jobs that generate different DSL from different repos, they went from ~15 min to ~1 min or less. Great work!


NNstreamer-AppTest: Added a locale setting for wget command

The 'wget' command saves a log message with the "-o logfile" option
while downloading files. This commit is to run a locale setting which
supports 'utf-8' to avoid an issue  that some file names in the log
file are broken.

Reference: https://github.com/nnsuite/nnstreamer/issues/1280

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.20190225. Thank you for submitting PR #504. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

The local test is successfully completed.


Improve error message reporting when running into a certificate issue

A colleague of mine ran into this issue when installing a package with uv.

And this was part of a larger install script to install a number of conda and python dependencies. And they concluded that this was an issue with the dependencies.
I made the same assumption as well, and since I had only ran this version on MacOS, I first thought "oh uv is resolving dependencies differently on macos and windows". And then when I tested it on my Windows VM, I didn't experience an issue which made me look at the error message more carefully.
Looking at the error message now, it is obvious it is a certificate issue. It says "Failed to download" and "UnknownIssuer". But it was easy to miss for two people (just two data points, I know)
I think the last line where "help: ..." is printed seems to imply it is because of a dependency version issue? And that might have been the source of confusion.
I'm wondering if there are incremental improvements possible here? Maybe uv can skip the help when running into a certificate issue? Or print a different help message that points the user to theuv docs on how to resolve SSL issues?
Feel free to close this issue if you think it's not worth any changes. After reading the uv docs and if I were to run uv sync from the command line myself, it would be super clear that this was a certificate issue to me. I'm coming at this from the perspective of making an automated install for a user that doesn't have to think about "conda" or "uv" or any of the dependencies involved to setup a project and would like the help messages to be more precise for a user that is using uv for the very first time.

Thanks for the report!
@charliermarsh we may not want to show this message for download failures?
We should also probably special case the certificate errors.


⚠ Bunce Base has degraded performance

In 7b11e1a, Bunce Base (https://base.bunce.so) experienced degraded performance:

HTTP code: 200
Response time: 18841 ms

Resolved: Bunce Base performance has improved in 961ef57 after 18 minutes.


unable to rectify map

I've run into an issue with a map where rectifying fails every time -
http://maps.nypl.org/warper/maps/26776

we're working on issues with the map warper... seems to be a drive space issue

this should be working fine now. thanks!

Retrying it now.. but it seems to be hung

Yeah its hung

ok i will leave it open but it seems like the problem is that this map is massive and covers a huge area of new york/new jersey so the process will just take a while.
we have to let it run until it crashes (if it does) or successfully completes. this process is run in the background so it should not impede other regular tasks.
this does help us determine if more computing resources need to be added to the server.

sounds good. the map has three plates side by side. how do you recommend rectifying the second and third pieces?

there is a little-known feature in the map page called "create inset" which basically duplicates the map. from there you can crop the second plate and so on any subsequent plates:

Thanks for the create inset lead. I'll try that when I get further along.
Checking on the map I'm noticing that a problem I'd experienced earlier has resurfaced. Perhaps it has something to do with the large filesize? The rectifying process have resulted in a distortion where one corner of the map has been pulled to a seemingly arbitrary point.

ok i'm gonna close this because rectification is working.
i think the problem was due to the control points. i added a couple of new control points and the rectification took very little time and produced nice results:

adding more points (or moving some of those i added somewhat hastily) will improve the result

Thanks for straightening things out. I'd thought 6 control points would be enough to get things into the general area. The skew to the far northwest was very unexpected.
Thanks again for the help. I'll try fine tuning things further and creating insets.

i guess it depends on the map. in this case, it seems the math was
producing that weird loop over there... maybe because most points were
concentrated in a small area and then one or two far away... if the point
dispersion is a bit spread out then the math improves
On Wed, Mar 2, 2016 at 4:39 PM, Lou Klepner<EMAIL_ADDRESS>wrote:

Thanks for straightening things out. I'd thought 6 control points would be
enough to get things into the general area. The skew to the far northwest
was very unexpected.
Thanks again for the help. I'll try fine tuning things further and
creating insets.
—
Reply to this email directly or view it on GitHub
https://github.com/nypl-spacetime/nypl-warper/issues/7#issuecomment-191444378
.

Thanks for the tips. I thought I'd bang out the next inset this morning but I'm not seeing the Create Inset option you pointed out.

seems like it might be a feature for admins only so i went ahead and created two insets for you: one, two

awesome - many thanks. i've rectified and cropped these insets.


Analytics related bundles are missing when we start API-M 3.0 with different profiles in distributed deployment

Description:
I'm trying to implement distributed deployment with API-M 3.0, Identity Server-5.9.0 and Analytics 3.0
Issue:
api#am#admin#v0.15 web application is missing in both Publisher and Store (\repository\deployment\server\webapps) after starting the API-M with Publisher and Store profiles. Due to this API's count, Applications count and Subscriptions count always showing as zero in Analytics dashboard.
Steps to reproduce
Create an optimized distributions for all components
-Dprofile=gateway-worker
-Dprofile=traffic-manager
-Dprofile=api-publisher
-Dprofile=api-devportal
I'm using Identity Server-5.9.0 as Key Manager
Start the components in same order
worker.bat --run (Analytics Worker)
wso2server.bat -run (Key Manager)
wso2server.bat -Dprofile=traffic-manager
wso2server.bat -Dprofile=api-publisher
wso2server.bat -Dprofile=api-devportal
wso2server.bat -Dprofile=gateway-worker
dashboard.bat --run (Analytics Dashboard)

@akurathimohan we have fixed this with the upcoming 3.1 release and furthermore the issue is fixed via WUM updates for 3.0 as well. If you have a subscription, please update the distribution and retest this.

related git issue https://github.com/wso2/product-apim/issues/6686


Exporting feature manager keys has changed behaviour - breaking change!

Previously I could press export to copy all keys from one App Configuration (Feature management) to the next one (acceptance -> production). It would merge all the keys on the target, and the state of already existing keys was left untouched. Great, just what I want!
Only now I saw this behaviour has changed, which is breaking for me. Why? Because the keys are used for feature toggling certain new routes and functionality. The state of existing keys in production should not be disturbed, because it causes big problems!
Why has this changed, and why no mention about this change??

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20bcb2f9-a71a-966b-d58f-103b377b39ed
Version Independent ID: a8e296b3-7904-a7c1-5c04-058a5061f19a
Content: Import or export data with Azure App Configuration
Content Source: articles/azure-app-configuration/howto-import-export-data.md
Service: azure-app-configuration
GitHub Login: @lisaguthrie
Microsoft Alias: lcozzens

@upmygit , Thanks for brining this to our attention. We will investigate it further and update you shortly.

Thanks @upmygit - can you open an issue in our regular App Config issues list, rather than on this doc? That way, it will get the attention of the developers. https://github.com/Azure/AppConfiguration/issues

@upmygit, I am trying to understand the scenario that is broken for you. You were exporting feature flags from one App Configuration store to another store and you saw feature flags that only exist in the destination store changed after the export. Is my understanding correct? If so, can you please give me an example of how it's changed?

@lisaguthrie, @zhenlan - I have opened an issue with more informatie (nice table layout)

Thanks, @upmygit.  We will follow up on the new issue https://github.com/Azure/AppConfiguration/issues/318.
This issue here can be closed.

#please-close


chore: update dependencies and fix associated warnings

This is the fix for the warnings that I mentioned in some other comments

What a curious test error.


v0.8.6_24: Data doubt text is not localised

SEVERITY:  Minor
MODULE:  Mountain Chart.
Platform:

Windows 7 / Chrome 48.0
Windows 7 / Firefox  43.0

RELEASE: v0.8.6
STEPS TO REPRODUCE:

Navigate to the URL : http://static.gapminderdev.org/vizabi/release/v0.8.6/preview/mountainchart.html
Mountain Chart will be loaded.
Click switch language button available on the right panel

4)  Click "Data tvivel", see the text in English

**ACTUAL RESULTS:**
By switching language the text is not localised

**EXPECTED RESULTS:**
By switching language the text should be localised

**SCREENSHOT:**

![image](https://cloud.githubusercontent.com/assets/3648190/11088842/99301c90-8865-11e5-9608-b3347a2b409a.png)

duplicate of #772


Added the new article under Value Types and Reference Types

Added a new article on Primitive Values vs Reference Values from freeCodeCamp to the repository. This provides a clear explanation of the differences between these two data types in JavaScript with examples.

Note that this article contains misunderstanding on how primitive values are stored in memory.
#481

@finalchild , Thank you for the detailed feedback. I now realize that the article I contributed on primitive values vs reference values contains some inaccuracies, especially around the distinction between value types and reference types in JavaScript.
Should I proceed with revisions to the article, or would it be better to close the PR and submit a new resource that is factually accurate?

I don't know... The topic itself is wrong, so almost every article in section 3 contains serious misunderstanding. Unless we fix the whole section, including or excluding one article doesn't make big difference.
leonardomso has been ignoring my issue for many months and even closed my PR. Seems he doesn't care.


[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2023-03-15

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

    },

ARM recommends using enums over booleans for new properties, to ensure future proof APIs.
Standard guidance is: replace boolean/switch properties with better enum whenever possible.
A boolean will forever have two valid values (true or false). A string enum is more flexible and future proof option because it allows additional values to be added in the future in a non-breaking way, e.g. [Enabled, Disabled, Suspended, Deallocated].. Also, properties should always ideally provide more meaningful values just than True and False, which are meaningless without context. For example two boolean switches "isTypeA" and "isTypeB" can be replaced with one enum "type": [A, B, DefaultType].
Note: do NOT just define a 'boolean enum' with two values 'True and False'. This might be easier to 'extend' in terms of types, but semantically its still confusing, thanks to the boolean value names. Hint: Try to think of enum value names that look meaningful even without context like 'Unencrypted', 'Encrypted', 'TlsEncrypted' which you can use instead.
[Conversely: do not do breaking changes by change boolean properties in use by customers with existing API versions.]

Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9830 in 9f8ff02. [](commit_id = 9f8ff02adf9db7388e6a0760c35feed70dc43edf, deletion_comment = False)

      "description": "Current buildout status of the region."

What would the possible values of this property mean?

Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9834 in 9f8ff02. [](commit_id = 9f8ff02adf9db7388e6a0760c35feed70dc43edf, deletion_comment = False)

      "description": "Current buildout status of the region."

What are the possible values of this property? What would they mean?
Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9834 in 5bcf280. [](commit_id = 5bcf280, deletion_comment = False)

status here refers to the buildout status of Azure Cosmos DB in a region. For new regions which are still in buildout the status can be Uninitialized, Initializing, InternallyReady, Online, Deleting based on the stage of regional buildout.

    },

ARM recommends using enums over booleans for new properties, to ensure future proof APIs.
Standard guidance is: replace boolean/switch properties with better enum whenever possible. A boolean will forever have two valid values (true or false). A string enum is more flexible and future proof option because it allows additional values to be added in the future in a non-breaking way, e.g. [Enabled, Disabled, Suspended, Deallocated].. Also, properties should always ideally provide more meaningful values just than True and False, which are meaningless without context. For example two boolean switches "isTypeA" and "isTypeB" can be replaced with one enum "type": [A, B, DefaultType]. Note: do NOT just define a 'boolean enum' with two values 'True and False'. This might be easier to 'extend' in terms of types, but semantically its still confusing, thanks to the boolean value names. Hint: Try to think of enum value names that look meaningful even without context like 'Unencrypted', 'Encrypted', 'TlsEncrypted', or 'Allowed', 'NotAllowed' which you can use instead.
[Conversely: do not do breaking changes by change boolean properties in use by customers with existing API versions.]
Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9830 in 5bcf280. [](commit_id = 5bcf280, deletion_comment = False)

For properties isSubscriptionRegionAccessAllowedForRegular and isSubscriptionRegionAccessAllowedForAz there are only two possible values either the subscription will have access or not. That's why we have kept as boolean.
status we can update to use enum since it can multiple values as mentioned above.  Let me know what you think?

    "isSubscriptionRegionAccessAllowedForRegular": {

What does Regular mean? Is ForRegular worth having in the name?
Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9821 in 9f8ff02. [](commit_id = 9f8ff02, deletion_comment = False)

This is the terminology we used for non zonal region restrictions. Since Cosmos DB can have separate level of region restrictions for both zonal and non-zonal in a region. This is used to avoid confusion between the both.

    },

Another way of thinking converting these to enums is:
subscriptionRegionAccessState as enum with values ["NonAvailabilityZonesOnly", "AvailabilityZonesOnly", "All"]
Something like this. What do you think?

Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9830 in 3fc111d. [](commit_id = 3fc111dd8ad541fbf8404e11dec6cdfe920136c3, deletion_comment = False)

    "status": {

If these are known values, then definitely make it enum.

Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2023-03-15/cosmos-db.json:9831 in 3fc111d. [](commit_id = 3fc111dd8ad541fbf8404e11dec6cdfe920136c3, deletion_comment = False)

A couple of suggestions about using enums. Let me know what do you think? I would suggest converting these to enums if possible.

@udit3333 A couple of suggestions about using enums. Let me know what do you think? I would suggest converting these to enums if possible.

@visingla-ms Updated the status property to enum. For isSubscriptionRegionAccessAllowedForRegular and isSubscriptionRegionAccessAllowedForAz it will require to refactor the RP handler and release to roll out. Keeping them as boolean instead.

@lirenhe We got an arm signoff. The Avocado test that's failing is due to APIs present in a much older version (2016) and we would like to get an exception for this.
Additionally, what are the ways we can fix this avocado exception going forward, considering that we don't have these APIs anymore. Should we update the older API version as a last resort?

@lirenhe Can you please merge the PR?

/azp run

@lirenhe Please merge the PR. Thanks.


Add contributing.md and code of conduct.md

Add a code of conduct file
Add a contributing.md file
Use the latest Github's practice while drafting the code of conduct clause

Hey, thanks for reaching out but this repo is exclusively for student who are participating in KSOC, KGEC this year. I'm sorry I cannot assign you the issue as it will be a violation of the terms.


Fix burger menu

fix the burger menu so it closes on its own

Burger menu is fixed up. It now closes when you click on anywhere else on the page


Feature/profile

My profile feature
This code contains the profile feature. Users are now able to add favorite movies to their profile. They are also able to delete these movies.

Looking good 👌


SP4/SP5: Label "last render rectangle" is inaccurate when rotation is used

Issue: When a Text is rotated, the calculation of the LastRenderRectangleCoordinates is not correct. This leads to weird behaviour when trying to grab and drag.
It is not easy to show this in a reproducible example that produces a screen shot, as it is dynamic behaviour. I am including a simple example that puts a plot and label in a state where it is almost impossible to drag the label. You can see this by moving the mouse over and near the label, and it only changes to a drag cursor in a very narrow band of pixels (I will try and show this area in a screen shot.
ScottPlot Version: 4.1.71
**Code Sample:
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            DoTest2();
        }

        private void DoTest2()
        {
            var txt = formsPlot1.Plot.AddText("01234567890123456789\r\n01234\r\n01", 0, 0, 12, Color.Red);
            txt.DragEnabled = true;
            txt.Rotation = 70;
            formsPlot1.Refresh();
        }
    }

When this is run the only area I can grab the label is shown here....

in order to more carefully investigate this I put in some code to actually render the LastRenderRectangleCoordinates immediately after the label, and I animated rotation, and watched the LastRenderRectangleCoordinates change change shape and location is a graceful ballet. This is a screen grab of it around 60 deegrees...

I proved to myself this rendering is correct, as the grab cursor only appears when the mouse is over the red box...

Thanks for reporting this @DaveMartel! I'm definitely going to fix this, but it's a can of worms so I'm trying to knock out some other open high priority issues before looping back to this one.
Related: https://swharden.com/blog/2022-02-01-point-in-rectangle/

This likely remains unfixed but there hasn't been comment on it for several months so I'll close this open issue, but if someone hits this again and is inspired to fix it, I'd be happy to review a pull request in good time and merge it in so it will be in the next release 👍


made reset function in Simulator class reset agent state to initial s…

…tate
Motivation and Context
Made the reset function in the Simulator class of simulator.py reset the agent to its initial state. Issue from here: https://github.com/facebookresearch/habitat-sim/issues/300
How Has This Been Tested
Tested this by instantiating the simulator class and stepping through a few actions before calling reset, then comparing the initial and final state to ensure they were the same.
Types of changes
Created a field in the Agent class called initial_state that gets set when initialize_agent() is called in simulator.py. This makes sure that the initial state is set with a valid position in the scene (not inside a wall or some weird place like that). Then when reset is called, each agent's state is set to its initial state.
Checklist

You need to run the pre-commit in order to fix the python_lint error:
https://pre-commit.com/

I haven't reviewed the code in depth, but I have a high-level comment: changing the default behavior of the reset call might not be a good idea since a lot of user code may already have been built up around the assumption that reset samples a new random initialization position.  I would propose adding an optional parameter to the reset call that allows for reset to the initial state as a way to do this without breaking backwards compatibility.


Margin in the Welcome text-Welcome screen

There is no margin in the Welcome text of the welcome screen

Can you please explain the issue a bit? It would be handy if you add steps of reproduction.

@ayushmankd It will be great if you could add some screenshots :)

This is fixed by #2099

Yeah it has been fixed in the new update!


Bigger candles

This PR is about new fields in candles.
We need a couple of new fields in candles. I'd like you to look over the changes and say what is OK and what needs to change to get this beast merged.
The idea is simple: add 4 new fields to candle data and to the DB schema.
The patch is a bit 'ugly', because I didn't want existing users to worry about this change. I added a version config variable: no version id (or version 1) means candles work as they work now. Version 2 means candles have 4 additional fiels.
If user changes candle versions, he'll have to add these new fields manually to his existing DB. User is intentionally changing config, so he probably knows what he's doing and a short notice or a wiki page would be enough to help him sort out the DB. Normal users won't change this config and will be unaffected. Also, if you change version before creating DB, tables will be created for you correctly.
Since this version variable is a numeric one, you can just increment it  to version: 3 and add other new fields - if you'll ever feel you need some more. What I want to say is that this version thing is expandable.
But.. looking at the patch maybe there's another (better) way. What if we don't add version parameter, but rather an array of additional fields user can have in candles. Fields that are in candle data now are mandatory and cannot be removed. But other fields can be just uncommented and you get them in your next candles.
Maybe something like:
/**
 * Uncomment to enable additional fields
 * in candles. Note that you'll also have to
 * add new fields to DB if you uncomment it later.
 */

config.candleWriter.additionalFields = [
//  'buyVolume',
//  'buyTrades',
//  'lag',
//  'raw'
]

Tell me if you know a better position for version or additionalFields in config. I didn't find any better place but candleWriter node.

One last thing: CandleBatcher class had a single argument (candleSize). I had to change it to take a second parameter (candleVersion).
Calling it looked strange, because you cannot see immediatelly what those parameters mean. Eg:
var cb = new CandleBatcher(2, 1);

so I changed it to take options parameter. Eg:
var cb = new CandleBatcher({candleSize:2, candleVersion:1});

I changed all class invocations and added/changed tests also.

Hey, great idea!
I have been thinking about updated marked data for a while and there are a few things to note:

Gekko already has a versioning system for persisting data, it would be better if we could leverage that instead. The version is driven from the config so Gekko will just use whatever the config has configured.
If we go to a new version, we really need spread information in there! (bestAsk & bestBid). See #678.
If you need different behaviour for the candleBatcher, I rather make a new class (candleBatcherv2 or something). They can point to specific specs about fields. Assuming v0 when a version key can not be found does not sound ideal to me (when config is misconfigured and Gekko assumes you want the old version, things like that are very hard to debug).

Also a tiny nitpick thing (which you could not have known) is terminology wise: Bigger candles
Gekko used to have a concept of smallCandles and bigCandles for over a year. smallCandles used to be 1 minute candles, and bigCandles had the same content but they covered the period configured in candleSize. Everyone coming back to Gekko will be left very confused.
Bigger candles also makes it hard to ever go to v3, will we call them Biggest candles? And what about v4?

Hey, thanks for the feedback, I appreciate it!
I think I pushed too much too quick this time. Let's just talk and forget about the PR for now.
Candle has currently these fields:
     {
       start: (moment),
       end: (moment),
       high: (float),
       open: (float),
       low: (float),
       close: (float)
       volume: (float)
       vwp: (float) // volume weighted price
    },

Let's say I wanted to add number of buy trades that happened in this candle's timeline. What would be the preferred way to do this? Note that we probably shouldn't disturb current users, because 99% of them are not interested in this additional field. But some (1%) are interested and would like to enable it somehow for them also.
This would be the candle emited and saved in the DB after the change.
     {
       start: (moment),
       end: (moment),
       high: (float),
       open: (float),
       low: (float),
       close: (float)
       volume: (float)
       vwp: (float) // volume weighted price,
       buyVolume: (integer) // <-- new field
    },

Thanks! (I know I should have asked all this before doing the PR...)

Yes let's have a quick discussion about this! Sorry for not being able to accept it like it is now...

Let's say I wanted to add number of buy trades that happened in this candle's timeline.

Just to be on the same line: I guess you mean the volume of trades were asks (sell offers) were taken from the orderbook (eg. bought)? Because in every trade there is a buyer as well as a seller.

This would be the candle emited and saved in the DB after the change.

Yes that looks great, we can add extra fields to the database. But we need to keep the following scenarios in mind:

What if someone has been running Gekko (without buyVolume) for a long time and they update to this. Would we then ignore all old data since the DB table doesn't have this buyvolume field? Or should we "migrate" the data (and do a) assume it's half the volume b) set to 0 or c) allow NULL values).
Gekko can connect to 17 different exchanges, do all these exchanges give data about buyVolume? What do we do if an exchange does not? (we could use this file were we already store related information).
If buyVolume what we should go for right now? (Not saying it is not, maybe we should come up with a list of properties that might be useful - I am thinking mainly of spread related properties).

Yes let's have a quick discussion about this! Sorry for not being able to accept it like it is now...

Absolutely nothing wrong with this.

Just to be on the same line: I guess you mean the volume of trades where asks (sell offers) were taken from the orderbook (eg. bought)? Because in every trade there is a buyer as well as a seller.

Yes, exactlty!

What if someone has been running Gekko (without buyVolume) for a long time and they update to this. Would we then ignore all old data since the DB table doesn't have this buyvolume field? Or should we "migrate" the data (and do a) assume it's half the volume b) set to 0 or c) allow NULL values).

I'd go with a notice. If someone is changing his config (assuming that this will be a config variable) then he probably has such knowledge to go look in the wiki and change his tables accordingly. What do you think?
I wouldn't change user tables automatically - I think too many problems can happen. Let user handle his tables.

Gekko can connect to 17 different exchanges, do all these exchanges give data about buyVolume? What do we do if an exchange does not?

We're checking for every trade if it is a buy or sell action. We don't look for specific fields in exchange return because (as you said) not every exchange returns this info. If price is higher then before then it must have been a sell.

If buyVolume what we should go for right now?

I was thinking of array of all possible fields. If someone wants to add another one, he'd have to add it to this list and add a getter function that returns value for it.

How about this new config variable?
config.candleExtraFields = [
  'buyVolume',
  'buyTrades',
  // 'allTrades'
]

As I wrote before, the objective is to allow user to add additional fields to candles: if field is in candleExtraFields array it will be emitted in candle data.
In this example, buyVolume and buyTrades fields are part of candle data, allTrades is commented out and hence it is not part of candle data.
If this seems reasonable we'll move to next discussion (about DB changes). For now, let's agree on config change first.

Sorry for the late reply, swamped with work atm!

Just to be on the same line: I guess you mean the volume of trades where asks (sell offers) were taken from the orderbook (eg. bought)? Because in every trade there is a buyer as well as a seller.

Yes, exactlty!

To know this correctly we would need to watch the orderbook in realtime. Something that comes at a big performance price (though as soon as we do this we can of course provide a lot of other very useful information). Or am I missing something obvious?
Your proposal is build on a main assumption Or if previous trade was a 'buy' and price hasn't changed, we assume users are still buying. which I think is a pretty dangerous one to make. Especially in high volatile times when some exchanges don't provide trades in the order they were executed (I've only seen this in smaller exchanges, but still).

I'd go with a notice. If someone is changing his config (assuming that this will be a config variable) then he probably has such knowledge to go look in the wiki and change his tables accordingly. What do you think?
I wouldn't change user tables automatically - I think too many problems can happen. Let user handle his tables.

The thing is that I am really pushing towards UI usage, where configuring this is a lot harder. The config was great and still is a great way to tweak almost everything Gekko is doing. But I want to go more in a direction where the "default" settings get you pretty far. Turning Gekko a bit more into a "magic box" (where you can still tweak everything, but only if you really need to).
People who want to tweak everything that happens without Gekko would probably just open the code and start hacking anyway.

How about this new config variable?
As I wrote before, the objective is to allow user to add additional fields to candles: if field is in candleExtraFields array it will be emitted in candle data.

The reason why I am a bit hesitant is:
Right now people can simply exchange history databases and everything continues to work. The only reason to add props to the candles is to be able to create strategies that rely on more market data (or not?). But as soon as you do this you need a way to handle strategies trying to run that rely on more data than currently configured. And if they configure their "config" (or UI) to use extra props, these might not be available in already imported datasets.
On top of that there are some discussions (example: #607) about importing data from other sources than exchanges. There are a lot of sources that have candle (OHCL) data, but I don't know any that also include buyTrades. So we need to think about handling cases where people have strategies relying on buyVolume but want to import from a source that does not include this data.
I'm all for more props in candles, but if you make it configurable it will become very hard to support imo.

And about including all the trades in the candles. I'm really against this. We should just expose all trades in a way (budfox already has this data). I wouldn't see why you want to batch these into candles.

Your proposal is build on a main assumption Or if previous trade was a 'buy' and price hasn't changed, we assume users are still buying. which I think is a pretty dangerous one to make. Especially in high volatile times when some exchanges don't provide trades in the order they were executed (I've only seen this in smaller exchanges, but still).

Yes, that's true, it could really be a problem if trades are not in the correct order.

People who want to tweak everything that happens without Gekko would probably just open the code and start hacking anyway.

That's what we're doing now. But it's hard to keep code in sync between the forks.

Right now people can simply exchange history databases and everything continues to work

Good one, I didn't think about this one.

The only reason to add props to the candles is to be able to create strategies that rely on more market data. (or not?)

Yes, definitely!

And about including all the trades in the candles. I'm really against this. We should just expose all trades in a way (budfox already has this data). I wouldn't see why you want to batch these into candles.

Our strategy calculates some additional data from those raw trades. And instead of adding those weird fields to candles, so we just pass all trades. But I see your point, we should stuff trades somewhere else.

Ok, so what do we do now?
Another idea: what about some kind of plugin support? The data for these additional fields (buyVolume, etc...) would be in other DB table(s), so it wouldn't broke main candle table.
And the strategies would then load plugin data with something like:
var pluginData = candle.loadFromPlugin('pluginId');

In the main gekko, we'd only need to add code to support these kind of plugins. I'd have a lot less work keeping branches in sync.

Ok, so what do we do now?

As you've noticed I am quite reluctant to adding code and complexity to hot code paths that won't be needed except for by a few people.

Another idea: what about some kind of plugin support? The data for these additional fields (buyVolume, etc...) would be in other DB table(s), so it wouldn't broke main candle table.

Great idea! So if you look at how Gekko currently works:
There are two main parts: a market and a gekkostream (stuff that deals with candles, strategies etc)

In the picture above we are looking at the live market (called budfox). This is the part that connects to exchanges and makes sure everything else gets fed candles.  Read more about budfox here: https://gekko.wizb.it/docs/internals/budfox.html
Budfox uses a bunch of modules to transform trades into candles (tradeBatcher, candleCreator, , writing candles to DB, etc.) and wraps the whole thing in one node stream that only exposes candles.

The best in this ecase would be to add a new market (that reuses most modules but monkey patches say the candleCreator by copying it to gekko/core/bigCandles/candleCreator or whatever you want to call it and add whatever props you want. You can also choose to not only expose a list of candles but also trades (as they happen for example). If you change what is broadcasted (not just candles but also X) you do need to rewire a lot of other stuff, so this is not recommended.

TLDR: If you want custom behaviour that almost no one else wants I don't want to add that to code being run by everyone (unless it's very trivial). If we can get support for new candle props by more of people we can of course still add it to the main code!
If you have any questions about any part of the codebase feel free to ask :)

Ok, agreed, I'm fine with this. I'll let you know if I have any questions with the new approach.

👍  Sorry for not being able to accept this. And yes please! If you have any questions or ideas just let me know.
I understand how frustrating it is to have to maintain a fork, so I can definitely merge stuff that is not used on default (just like adapters), but I want to do it in a way so that it doesn't complicate / slow down gekko for everyone else!


⚠ ClamAV has degraded performance

In 156d011, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 125 ms

Resolved: ClamAV performance has improved in e56e960 after 542 days, 14 hours, 50 minutes.


Form validation

Hi, I looked at the index.js and cannot see any validation included. How would you validate an individual step?
Any plan to integrate with Redux forms? Thanks.

Hi
validation is left out, this is just a component that allows navigation - you can add validation to your steps in any way you prefer

Since the example features fields, would make sense to have validation in it

agree, just don't have time (or direct need) right now... PR welcome, though :)


Add dockerfiles

Download Arch, Pop_OS!, Debian, Uuntu Kali, Artix, Manjaro and Fedora and EneavourOS dockerfiles, execute and  test.

Won't do


🚀 Feature:

🔖 Feature description
The ability to share a folder/directory
🎤 Pitch
I have had a couple times where I've wanted to send a few folders with their contents to someone, but would create either a couple shares of basically the contents of the directory OR just use onedrive if the folder was small enough and sent it that way. I think it would be greatly beneficial to myself and others to send directories/folders.
Thanks!

@SparroWServ
I don't think this is possible using only JavaScript in a navigator. Indeed the navigator cannot access an entire folder, to search all the files recursively, because it has no authorization to do it, so the navigator only have access to a single file, the one that is given by the user. I might mistake about this but I don't think this is possible.
If you want to send entire folders or multiple files in one, you can zip your content, using 7Zip or WinRAR. You select the files and folders you want to compress, and then it creates a file that you can transfer using Pingvin or any other sharing platform.
Hope that helps.

I honestly can't believe I didn't think about zipping the file. I guess I thought of Zips as Directories. I appreciate the response and will use that in my future sharings.
Thank you!

@stonith404
Well, I've told this guy that we couldn't load a folder, but when we drag n drop a folder, it put all the files, do you think it is possible to get the structure of the ended file by the navigator or we don't have any info about this?

@stonith404,
I've made a big mistake by saying that we couldn't load entire folders. Indeed the FileUpload[] object sent by the Mantine Dropzone sends the full path, from the sent directory. We could then retrieve the folders (only those which are containing files).
Maybe we should consider reopening this issue after setting a correct name.
Here is an example of the sent object:
[
    {
        "path": "/ArduinoData/cache/cache.json",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/cache/downloads.arduino.cc/libraries/library_index.json.gz",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/cache/downloads.arduino.cc/libraries/library_index.json.sig",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/cache/downloads.arduino.cc/packages/package_index.json",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/cache/downloads.arduino.cc/packages/package_index.json.sig",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/library_index.json",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/library_index.json.sig",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/package_index.json",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/package_index.json.sig",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/preferences.txt",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/staging/libraries/Adafruit_BusIO-1.14.1.zip",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/staging/libraries/Adafruit_GFX_Library-1.11.5.zip",
        "uploadingProgress": 0
    },
    {
        "path": "/ArduinoData/staging/libraries/Adafruit_SSD1306-2.5.7.zip",
        "uploadingProgress": 0
    }
]

@pierrbt Oh okay, I didn't know that this is possible

Yes it would be interesting. The problem is that it only shows folders in which there is files. But others services as Wetransfer add a popup to Ask permission, surely to Access empty folders

I would just like to bump this as it'd be a great feature to have.
I am not keen on the idea of having to zip up folders and upload them as it defeats the purpose of just allowing the end user to download the specific file they need. Having a folder structure would be great as it would also save me from creating separate shares for each folder and allow for everything require to be in the one.
Hopefully something to consider for future versions!
Thank you and great job on Pingvin!


Make WorkboxSW a singleton on self.workbox

R: @jeffposnick @addyosmani @gauntface
To address #940, this PR updates workbox-sw to instantiate and only expose a singleton instance of WorkboxSW on self.workbox. To handle custom options, it adds a new .setConfig() method.
Here's an example of what the usage would look like with these changes:
importScripts('path/to/workbox-sw.prod.js');

workbox.setConfig({
  // ...
});

// Now it's safe to run the following code since `workbox` knows to
// dynamcially load all dependencies.
workbox.googleAnalytics.initialize();

Breaking changes:

This no longer supports the idea of a default export handling the majority use cases on the namespace -- instead it's exposed on workbox.packageName.default.
This also removes the disableModuleImports option, as I don't really see a use case for workbox-sw without the loader features.

I made a few updates to incorporate the latest changes and feedback. The primary thing I modified from the previous PR is now all packages have to include workbox.* in their namespace value in package.json. The reason is so workbox-sw can use just workbox without having to have an additional setting to ignore the prefix.

My preference is being explicit about it is better. It also seems a bit counterintuitive to set the namespace field to an empty string and still get a namespace set. But if folks disagree I'm happy to revert.


OSIDB-2693 : Fix Deleted Affects after flaw save

[OSIDB-2693] [Affected Offerings To Be Deleted message stays after deletion]
Checklist:

[ ] Linting passed
[ ] Type checks passed
[ ] Tests suite passed
[ ] Commits consolidated
[ ] Changelog updated
[ ] Test cases added/updated
[ ] Jira ticket updated

Summary:
Affected Offerings To Be Deleted message stays after deletion
Changes:
[Replace with a detailed description of the changes made in this PR, including any new features, enhancements, bug fixes, or refactorings.]
Considerations:
[Replace with any additional considerations, notes, or instructions for reviewers.]

I think it would be simpler to create a function to reset modified and deleted affects after a save. WDYT?

Agree, Thanks for your comment.

I think it would be simpler to create a function to reset modified and deleted affects after a save. WDYT?

Agree, Thanks for your comment.

I think adding the reset function to useFlawAffectsModel and returning it from that function would make it relatively easy to perform cleanup here and here
https://github.com/RedHatProductSecurity/osim/blob/fix/OSIDB-2765-error-recovery-on-flaw-create/src/composables/useFlawModel.ts#L144
https://github.com/RedHatProductSecurity/osim/blob/fix/OSIDB-2765-error-recovery-on-flaw-create/src/composables/useFlawModel.ts#L136

I think it would be simpler to create a function to reset modified and deleted affects after a save. WDYT?

Agree, Thanks for your comment.

I think adding the reset function to useFlawAffectsModel and returning it from that function would make it relatively easy to perform cleanup here and here
https://github.com/RedHatProductSecurity/osim/blob/fix/OSIDB-2765-error-recovery-on-flaw-create/src/composables/useFlawModel.ts#L144
https://github.com/RedHatProductSecurity/osim/blob/fix/OSIDB-2765-error-recovery-on-flaw-create/src/composables/useFlawModel.ts#L136

You mean, we don't need to show deleted affects after flaw save? Also I think we need to call reset after flaw save successfully . I think this place only. https://github.com/RedHatProductSecurity/osim/blob/fix/OSIDB-2765-error-recovery-on-flaw-create/src/composables/useFlawModel.ts#L144

You mean, we don't need to show deleted affects after flaw save? Also I think we need to call reset after flaw save successfully . I think this place only. https://github.com/RedHatProductSecurity/osim/blob/fix/OSIDB-2765-error-recovery-on-flaw-create/src/composables/useFlawModel.ts#L144

I think that's reasonable. My thought was if there was an error during save, just to clean up the clutter on screen to make it easier to track down a problem with the form input data if there was a problem with the data.


Could only pass when I copied and pasted

Challenge Create a Set of Checkboxes has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action="/submit-cat-photo">
  <input type="radio" name="indoor-outdoor"> Indoor
  <input type="radio" name="indoor-outdoor"> Outdoor
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
  <input type="checkbox" name="personality"> Loving
  <input type="checkbox" name="personality"> Loving
  <input type="checkbox" name="personality"> Loving

</form>

@DizzysContent the instructions indicate to add 3 checkbox inputs so that's why you needed three of them. This is intentional.


Replace this code at WinMain() to enable memory checks on windows builds.

Replace this:
#if defined(__ANDROID__)
    // Removing this may cause the compiler to omit the main entry point
    // which would make the application crash at start
    app_dummy();
#endif

With this:
#if defined(__ANDROID__)
    // Removing this may cause the compiler to omit the main entry point
    // which would make the application crash at start
    app_dummy();
#elif defined(_WIN32)
#if defined(DEBUG) || defined(_DEBUG)
    _CrtSetDbgFlag(_CRTDBG_ALLOC_MEM_DF | _CRTDBG_CHECK_CRT_DF | _CRTDBG_DELAY_FREE_MEM_DF | _CRTDBG_LEAK_CHECK_DF); //_CRTDBG_CHECK_ALWAYS_DF)
#endif
#endif

Thx for pointing me at this. Will this work with non-Microsoft Compiler too?

Good question. Actually I've never tried it outside VS , so if you find out please let me know.

The MSDN page might be of interest.
Note that all I know comes from 10min of googling, but I believe this is an MS-specific extension, available only on msvc.
As for the suggested code itself, it's doing something completely unrelated to the Android app_dummy() hack, so it doesn't belong in the same code block, and should be its own block IMHO. I also don't understand the point of the second level #if in the #elif?

That's correct. The nested if/endif block may be pointless as _CrtSetDbgFlag() may do nothing for release builds, though it may compile with no error anyway. It's just a reminder that the code won't do anything on release builds.
For the msvc thing, the thing is that if you use other libs such as mingw, they may still use the msvc runtime under te covers, so it would work anyway. The flags apply to allocations done by the ms memory manager, which is something other compilers may still rely on.

Turns out that when I build Android apps under Visual Studio I still have _WIN32 defined, so making it part of the #ifdef (ANDROID) makes that it doesn't try to compile that line for Android apps. This happens also when trying to build linux apps in VS so I always do:
#if defined(ANDROID)
#elif defined(__linux__)
#elif defined(_WIN32)
#else
// default for unknown platforms
#endif

In that order.

Turns out that when I build Android apps under Visual Studio I still have _WIN32 defined

That doesn't sound right. I'd say your toolchain is broken, but since you're using msvc that's already a well-known fact :stuck_out_tongue_closed_eyes:
Seriously though, that shouldn't be possible. When cross-compiling, only the defines for the target architecture should be defined, otherwise everything project would break and have to be made aware of where it's being built from as well, which would just be a nightmare.

Actually I believe if you build for Android you will have linux defined too.

That's true, as Android contains a Linux kernel ;)

Though most linux developers I know won't hesitate to clarify about android linux: "that's not a true linux". Well, _WIN32 is a flag telling you're using the VS compiler, not that your app is targeted to Windows: note that also for x64 builds you will have the _WIN32 defined, when it's actually not 32 bit at all. For targeting Windows platforms the proper flag you should use is WIN32 -without the underscore- and you should probably declare it yourself, as _WIN32 is intended mostly for the implementation of the compiler libraries.

android linux: "that's not a true linux"

Android Linux is not GNU/Linux, but it's still Linux. It's a different userspace, but the kernel is the same (with some patch, most of which are being upstreamed).

_WIN32 is a flag telling you're using the VS compiler, not that your app is targeted to Windows

That's not how the rest of the world interprets it :]
https://en.wikipedia.org/wiki/Cross_compiler

for x64 builds you will have the _WIN32 defined

That's the result of a bad decision from Microsoft, it has nothing to do with the standards. If they had named it __windows__ instead of _WIN32 and used something else to declare the word size, it wouldn't have been a problem for them.
Almost everyone else made the right choice for this btw: https://sourceforge.net/p/predef/wiki/OperatingSystems/

For targeting Windows platforms the proper flag you should use is WIN32 -without the underscore- and you should probably declare it yourself, as _WIN32 is intended mostly for the implementation of the compiler libraries.

I've never heard that, but then again my interaction with Windows developers is minimal. It would come down to preferences anyway, and knowing Windows devs they probably wouldn't all agree :smirk:
(For instance, at ImgTec (where I work), the Windows team defines WINDOWS)

But isn't the single underscore reserved to implementation of the compiler? In such case, linux would be for use by "the user", while _WIN32 would be a private macro for the compiler libraries themselves, so they can call it whatever they want.

No, what is reserved is defining those macros. Anyone can use them (that's the whole point).

But you're complaining about the wrong decisions of MS but still relying on those decisions for your program. In my opinion one would be much better defining __windows__  oneself and just making use of that define, instead of relying on bad defines born from bad decisions that are incosistent and don't represent what's actually being built (such as 64-bit apps targeting 64-bit or Windows Phone apps)

Ah sorry I missed that part. It seems ImgTec guys are smart about it and defined it themselves.

Been testing around with _CrtSetDbgFlag and with the examples I tested I didn't find any memory leaks. Since this is MSVC specific I'm not going to add this for all examples.


Add diverging loops to diverging function section.

I went with "corresponding break" here since you could have a
break that's inside another loop expression for the inner loop
expression, but that wouldn't change the divergence. That probably
needs to be better fleshed out, but I'd leave the fleshing out
of divergence to the loop item section of the reference.

Thanks!


Change the policy for supporting old Swift language versions

"One full major version" used to be approximately the same as "one year."  But Swift 5 changed that and "one full major version" is becoming increasingly intractable.  This is especially problematic for CI; we've based our CI on the Swift-provided Docker images, but the Swift 5.0 Docker images are no longer able to build protobuf for testing, so cannot run our full test suite.

@Lukasa - Any concerns about this proposed change?

This sounds very similar to what we are doing in NIO. We are supporting the last two minor Swift releases. Right now this ends up being almost the same supported version as the "up to one year old" policy here.

Agreed, this aligns with our policy. I think we technically do a maximum of 18 months (we currently support 5.7, 5.6, and 5.5, where if we assume a six-month-ish cadence of Swift releases 5.5 will end up 18 months old when we eventually drop its support), but that's not a huge delta.

@tbkka good to commit?

Good to pull this over to the 1.x branch?

Just realized we can't pull this to the 1.x branch, as a change to min OS policy would be a breaking change, and thus 2.0, which is trunk. So this will only clear the way for future things, no impact on 1.x.

I don't think it makes much difference either way for 1.x.   That branch is not changing quickly, and I see no need to forcibly remove support for older Swift language versions there.
I suppose the simplest would be to not pull it over and just leave 1.x alone as much as possible.


How to display GUI

I have linked the code to the container and compile the code. If I run the script, how to display the GUI manually adjust parameters.
thanks!

Hi,
To address this issue, I forked this  repo and add a script for docker visualization.
You could check: https://github.com/BayRanger/SensorsCalibration
And the usage has been added to README
Bests,
BR

one mistake; and still not work

you could try using sudo before the command in the container.

Hi, To address this issue, I forked this repo and add a script for docker visualization. You could check: https://github.com/BayRanger/SensorsCalibration And the usage has been added to README
Bests, BR

Thanks! It's ok!

Hello, I have the same issue and have tried almost all the methods I could find.
Finally, I noticed that it may be a better choice to install the required dependencies on the host machine rather than on docker. So, I installed Pangolin on my host machine using source code and solved this issue.

Hello, I have the same issue and have tried almost all the methods I could find. However, none of them can work.
Finally, I noticed that it may be a better choice to install the required dependencies on the host machine rather than on docker. So, I installed Pangolin on my host machine using source code and solved this issue.

没错，使用docker尝试过在远程服务器/本机/虚拟机/有无显卡的机器上测试，均无法实现图形界面显示。最后还是自己安装PCL VTK OPENCV实现可视化界面

Hello, I have the same issue and have tried almost all the methods I could find. However, none of them can work.
Finally, I noticed that it may be a better choice to install the required dependencies on the host machine rather than on docker. So, I installed Pangolin on my host machine using source code and solved this issue.

没错，使用docker尝试过在远程服务器/本机/虚拟机/有无显卡的机器上测试，均无法实现图形界面显示。最后还是自己安装PCL VTK OPENCV实现可视化界面

I also want to visualize the GUI in docker, can you offer some instructions or docker image?

你好，我在本地装了opencv2.4.13，pcl1.9.1但是lidar2camera和radar2camera的手动标定程序总是出错。你本地是怎么安装的啊

没错，使用docker尝试过在远程服务器/本机/虚拟机/有无显卡的机器上测试，均无法实现图形界面显示。最后还是自己安装PCL VTK OPENCV实现可视化界面

你好，我在本地装了opencv2.4.13，pcl1.9.1但是lidar2camera和radar2camera的手动标定程序总是出错。你本地是怎么安装的啊

你好，我也遇到了同样的问题，几乎所有的人都能找到解决办法，但是不能工作。，他们都。
最后，我注意到在主机上而不是在 docker 上安装所需的选择依赖项可能是更好的。所以，我使用源代码在我的主机上安装了 Pangolin 并解决了这个问题。

What version of pangolin is it? My pangolin installation does not support C++11

Ubuntu22 本地安装环境的相关依赖版本：
建议各位在虚拟机中尝试通过后再在实体机中安装，其中会有几个错误需要修改，百度很好解决，古德拉克
pangolin 0.6
PCL 1.12.0
Eigen 3.4.0
VTK 8.2.0
C++ 14 （根据报错情况再修改你跑的项目的cmakelists.txt）
jsoncpp，需要将jsoncpp里包含头文件的json文件夹拷贝到manual_calib的include文件夹中。（这个找到git的项目主页拉下来源码）
VTK的安装依赖比较麻烦，多看看教程

没错，使用docker尝试过在远程服务器/本机/虚拟机/有无显卡的机器上测试，均无法实现图形界面显示。最后还是自己安装PCL VTK OPENCV实现可视化界面

你好，我在本地装了opencv2.4.13，pcl1.9.1但是lidar2camera和radar2camera的手动标定程序总是出错。你本地是怎么安装的啊

没错，使用docker尝试过在远程服务器/本机/虚拟机/有无显卡的机器上测试，均无法实现图形界面显示。最后还是自己安装PCL VTK OPENCV实现可视化界面

你好，我在本地装了opencv2.4.13，pcl1.9.1但是lidar2camera和radar2camera的手动标定程序总是出错。你本地是怎么安装的啊

opencv版本没有问题，问题出在其他的依赖上。本地安装依赖参考我上一个回复。lidar2camera的joint和Manuel都没有问题，radar我没试过，你可以试试看。古德拉克

没错，使用docker尝试过在远程服务器/本机/虚拟机/有无显卡的机器上测试，均无法实现图形界面显示。最后还是自己安装PCL VTK OPENCV实现可视化界面

你好，我在本地装了opencv2.4.13，pcl1.9.1但是lidar2camera和radar2camera的手动标定程序总是出错。你本地是怎么安装的啊

opencv版本没有问题，问题出在其他的依赖上。本地安装依赖参考我上一个回复。lidar2camera的joint和Manuel都没有问题，radar我没试过，你可以试试看。古德拉克

你好，关于运行手动标注segmentation fault报错已经解决了，在CalibrationInit和CalibrationScaleChange函数里面有一行代码：
modification_list_.[i]=tmp; ，改成 modification_list_.push_back(tmp);就可以了。
我觉得这行代码直接用 push_back会更好，用下标方式有时候就可以，有时候就不可以，环境来来回回装了好多次，太折磨人了
我的环境 ubuntu 18.04  opencv 2.4.13  pcl 1.9 eigen 3.3.8 pangolin 0.5
盐的甜
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "PJLab-ADG/SensorsCalibration"                                                                                @.>;
发送时间: 2022年9月1日(星期四) 下午2:37
@.>;
<EMAIL_ADDRESS>主题: Re: [PJLab-ADG/SensorsCalibration] How to display GUI (Issue #7)
Ubuntu22 本地安装环境的相关依赖版本：
建议各位在虚拟机中尝试通过后再在实体机中安装，其中会有几个错误需要修改，百度很好解决，古德拉克
pangolin 0.6
PCL 1.12.0
Eigen 3.4.0
VTK 8.2.0
C++ 14 （根据报错情况再修改你跑的项目的cmakelists.txt）
jsoncpp，需要将jsoncpp里包含头文件的json文件夹拷贝到manual_calib的include文件夹中。（这个找到git的项目主页拉下来源码）
VTK的安装依赖比较麻烦，多看看教程
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Hi, To address this issue, I forked this repo and add a script for docker visualization. You could check: https://github.com/BayRanger/SensorsCalibration And the usage has been added to README
Bests, BR

Thanks! It's ok!

Hi, To address this issue, I forked this repo and add a script for docker visualization. You could check: https://github.com/BayRanger/SensorsCalibration And the usage has been added to README
Bests, BR

Thanks! It's ok!

recommend that you should install ubuntu on a real machine , then run docker environment with nvidia docker container tools installed to shou gui

i have tried to show gui result on ubuntu desktop without nvidia GPU, failed.

Hi, To address this issue, I forked this repo and add a script for docker visualization. You could check: https://github.com/BayRanger/SensorsCalibration And the usage has been added to README
Bests, BR

这个fork有用，我从这里拉取的仓库然后在root用户下编译文件和运行都没有问题。GUI也可以正常显示。

请问一定需要GPU吗

running the demo calibration tool from the local machine it worked successfully but from the docker container it is not working and showing the error
Pangolin X11: Failed to open X display
I tried all the possible solutions but still not working any suggestion?

i have tried to show gui result on ubuntu desktop without nvidia GPU, failed. Is it mandatory have gpu to run this. I am trying to run the radar2camera and facing this issue. the display loads up but as soon as i press enter . it shows this error of Pangolin and windows closes