opengraph sharing content, plus genericize remaining hard-coded content

Thanks vercel preview deploys for allowing me to test the sharing setup w/ internet toolz!

OH because this is dynamic and rendered post-load client-side of course the sharing scrapers aren't getting my meta tags. Sooo.... that points towards going to server-side rendering? Which has disadvantages, and seems overkill since it's mostly static content (from the point of view of a user). Welp, I'm gonna look into it anyway


In my application, I am getting the data from server. So how will I use this library as the row count is zero before getting data. Please help me.

Before you get the data from server you can call
Loader.addLoaderToViews([self.tableview])
and in the completion handler after you successfully get your data call
Loader.removeLoaderFromViews([self.tableview])
If you don't have a completion handler you can just do like this :
   Loader.addLoaderToViews([self.tableview])
    self.posts = ImagePost.fetchPosts(viewController: self, queryLimit: page)
    Loader.removeLoaderFromViews([self.tableview])

When I do this I get the gradient as one single view over my tableview. Any other way to fix the issue?


[Tabs] Missing key ARIA role="tablist"  #9060

This PR addresses issue #9060 by adding role="tablist" to Tab <ul> containers, as documented in the WAI-ARIA Authoring Practice for Tab Panels
cc: @rafibomb @gakimball

@sethkane I think this makes sense?

@Owlbertz yes you should have role="tablist" on the  and you should have role="tab" on the
http://oaa-accessibility.org/example/34/

It's ok to keep the role of tab on the anchor as long as the role of presentation stays on the <li>. The requirement is that tablist contain only tab elements, and presentation will remove semantics from the <li>

Alright, I guess this can be merged then. I think this can go into  develop as it's only changes the ARIA-attributes that are added automatically, although it might of course break the design if someone made up some CSS rules that target those attributes - but imo this should be a rare case.

@Owlbertz Should not have any impact as this is only adding an attribute that looks like was never there.

@kball, maybe you can check and give feedback?

Thanks for this PR! Is this PR already included v6.2.4? (Because the W3 validator says the tabrole is missing on my site)

@Silvester20 it should be part of 6.2.4. Can you provide a link to your site?

@Owlbertz  Thanks for the quick reply. I don't have a domain so I made a fiddle.

@Silvester20 you are right, the change is not part of 6.2.4.
This line is missing in the release version.
This is strange, because the PR got merged on October 17th and the release tag has been created on October 21st.
Maybe @kball knows what's up?

Sorry guys, this didn't quite make it in for 6.2.4... it was merged after we'd branched off the first RC.  It will be in 6.3, the first RC will be in 2 weeks.


Can you build a channel from a plex collection?

When building a station I see my libraries show up and my playlists. But it would be helpful if I can make a station out of a plex collection I already have built.

This is something I actually need for my own use. The only thing stopping me is I don't know how to access collections in the plex api. But it will happen eventually.

thanks!
For another similar thought, if there is a way to go any additional filtering on the libraries (ex: by genre) that would also be really helpful.

0.0.61 supports collections. I am closing it. Please make another issue for the genre filtering. It's not possible at  t he moment, but could be a feature request.


Customising libvirt settings can only be done when creating a box

Adding the below code to the vagrantfile does not have any effect after a 'vagrant reload', the box must be destroyed and recreated. This works fine with virtualbox, so must be a limitation with the libvirt plugin.
config.vm.provider :libvirt do |libvirt|
libvirt.memory = 2048
libvirt.cpus = 4
end

I can change it just fine. Here is a  vagrant file I'm currently working with. Got multiple devices each with different memory requirements. All servers except one use 256MB. One has a 4GB RAM 2 CPU requirement.
 config.vm.provider :libvirt do |domain|
    domain.memory = 256
    domain.nested = true
  end

  # deployment server Uses 256MB RAM
  config.vm.define :deployserver do |node|
    node.vm.hostname = 'deployosad'
    node.vm.box = 'trusty64_2'
      .........
     ........
    end
  end

  # LoadBalancing VM Uses default 256MB RAM
  config.vm.define :haproxy do |node|
    node.vm.hostname = 'haproxy'
    node.vm.box = 'trusty64_2'
    node.vm.synced_folder '.', '/vagrant', :disabled => true
   ....
   ......
  end

  # Requires 4G of RAM and 2 CPUS
  config.vm.define :stackserver do |node|
    node.vm.provider :libvirt do |domain|
      domain.memory = 4096
      domain.cpus = 2
    end
    node.vm.hostname = 'stackserver'
    node.vm.box = 'trusty64_2'
    node.vm.synced_folder '.', '/vagrant', :disabled => true
   ...
   .....
  end

This is my complete vagrantfile (minus the provisioning code), which always gives me 512MB memory and 1 CPU.
# -*- mode: ruby -*-
# vi: set ft=ruby :

# Vagrantfile API/syntax version. Don't touch unless you know what you're doing!
VAGRANTFILE_API_VERSION = "2"

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
  config.vm.box = "naelyn/ubuntu-trusty64-libvirt"
  config.vm.box_check_update = false
  config.vm.provision :shell, path: "http://path.to/provision-script.sh"
  config.vm.network "private_network", ip: "<IP_ADDRESS>"
  config.vm.synced_folder ".", "/vagrant", type: "nfs", nfs_udp: false, nfs_version: 4
  config.vm.provider :libvirt do |domain|
    domain.memory = 2048
    domain.cpus = 2
  end
  config.vm.provision "shell", run: "always",
    inline: "echo 'Updating...'
        # Some bash code to update tools"
end

Nothing obvious for me from config standpoint. I guess you need to debug the plugin and see what is breaking for you. First step is run vagrant with debug option. If that doesn't work I have a blog post on how to run the ruby debugger in the plugin to see what its doing.

Is this of any help (the --debug output)? Not sure what I'm looking for.

http://pastebin.com/hdfy3EpV

your machine is already provisioned. If you want the VM to get the memory setting changes, either edit it using virt-manager (gui) /virsh edit <domain>(cli). Or destroy the VM (vagrant destroy) and recreate it (vagrant up). vagrant does not change memory settings after starting up the VM for the first time.

That's not vagrant. I've changed the settings in the vagrantfile before, and just tested it again, and a simple 'vagrant reload' is all that is needed to change these settings with virtualbox. So, this is a limitation with the libvirt plugin. Atleast I am able to fix it now by recreating the box, but this should still be fixed with the plugin.

I will happy accept your pr ;)
On 22 Jul 2015 11:03, "Sam Bull"<EMAIL_ADDRESS>wrote:

That's not vagrant. I've changed the settings in the vagrantfile before,
and just tested it again, and a simple 'vagrant reload' is all that is
needed to change these settings with virtualbox. So, this is a limitation
with the libvirt plugin. Atleast I am able to fix it now by recreating the
box, but this should still be fixed with the plugin.
—
Reply to this email directly or view it on GitHub
https://github.com/pradels/vagrant-libvirt/issues/418#issuecomment-123630050
.

I'm interested too.
Will make a PR soon. Hope even today :)

@mkutsevol the code in your PR is generating invalid XML. Take the following Vagrantfile:
ENV['VAGRANT_DEFAULT_PROVIDER'] = 'libvirt'
VAGRANTFILE_API_VERSION = "2"
Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
 config.vm.box = "centos71libvirt.box"
 config.vm.box_url = "https://spirit.infernix.net/vagrant/centos71libvirt.box"
 config.vm.provider :libvirt do |v|
  v.storage_pool_name = "vagrant"
  v.storage :file, :size => '2G', :type => 'qcow2'
  v.storage :file, :size => '2G', :type => 'qcow2'
 end
end

This yields the following error on a vagrant up:
Call to virDomainCreateWithFlags failed: unsupported configuration: target must be 0 for ide controller
Generated XML:
<domain type='kvm'>
  <name>vgtest_default</name>
  <uuid>9762b1a5-00db-480c-a347-e09958dffeb7</uuid>
  <memory unit='KiB'>524288</memory>
  <currentMemory unit='KiB'>524288</currentMemory>
  <vcpu placement='static'>1</vcpu>
  <os>
    <type arch='x86_64' machine='pc-i440fx-2.3'>hvm</type>
    <boot dev='hd'/>
  </os>
  <features>
    <acpi/>
    <apic/>
    <pae/>
  </features>
  <cpu mode='host-model'>
    <model fallback='allow'>qemu64</model>
  </cpu>
  <clock offset='utc'/>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>destroy</on_crash>
  <devices>
    <emulator>/usr/bin/kvm</emulator>
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/home/infernix/vagrant-libvirt/vgtest_default.img'/>
      <target dev='vda' bus='sata'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/home/infernix/vagrant-libvirt/vgtest_default-vdb.qcow2'/>
      <target dev='vdb' bus='sata'/>
      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
    </disk>
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/home/infernix/vagrant-libvirt/vgtest_default-vdc.qcow2'/>
      <target dev='vdc' bus='sata'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
    </disk>
    <controller type='usb' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
    </controller>
    <controller type='pci' index='0' model='pci-root'/>
    <controller type='sata' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </controller>
    <interface type='network'>
      <mac address='52:54:00:e1:b9:dd'/>
      <source network='vagrant-libvirt'/>
      <model type='virtio'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </interface>
    <serial type='pty'>
      <target port='0'/>
    </serial>
    <console type='pty'>
      <target type='serial' port='0'/>
    </console>
    <input type='mouse' bus='ps2'/>
    <input type='keyboard' bus='ps2'/>
    <graphics type='vnc' port='-1' autoport='yes' listen='<IP_ADDRESS>' keymap='en-us'>
      <listen type='address' address='<IP_ADDRESS>'/>
    </graphics>
    <video>
      <model type='cirrus' vram='16384' heads='1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>
    <memballoon model='virtio'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </memballoon>
  </devices>
</domain>

Observe the  <address/> lines in the <drive/> definitions. The first two are OK, but the third one:
<address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
Merged in d11b0b970f67a85e5c886066fb5e8967f2d17ba9 I think, it is probably the disk_bus code but I'm not really sure why it is happening. Note that you may need to apply PR #476 to reproduce.

Hello!
Will look into it soon.

My code which may touch  only switches bus in  if it's different and deletes  subelement. Libvirt then make a proper  element for the requested but type.
The relevant code is in start_domain.rb ~36-43.
You may try to switch disk bus and make a vagrant reload. Then switch back and make another vagrant reload. I assume that it may be a workaround for you right now.

@infernix, found, will fix.

@Dreamsorcerer can you confirm that the latest 0.0.32 release is working as expected and close the issue if it does?
Thank you.

Yep, 'vagrant plugin update' and it is working correctly. Great work!


Swipe Up Background Bug

Issue swiping up where a non-transparent background is shown.

See here for an example of issue:

https://user-images.githubusercontent.com/33523248/202024441-52f257b8-5ffd-4396-a9d4-757339a37886.mp4

present function should have its animated parameter set to false.
Issue Resolved


helm charts not having secretKeyRef usage

ideally, helm charts that have sensitive information uses secretKeyRef to decode base64 k8s secret and takes the name of the secret, this improves the usage of helm charts in public gitops based repos which use helm charts.
Can this be added to helm charts?
The best example of it is given here which allows both plain information or secret key reference
https://github.com/minio/minio/blob/master/helm/minio/values.yaml#L344-L348

I'm looking at this same issue for both kubewatch and kubernetes-event-exporter https://github.com/resmoio/kubernetes-event-exporter/issues/48 .  In both cases the API token is intended to be stored in a ConfigMap.
One strategy I've come across is to store the secrets in CI/CD and pass it in during deployment with envsubst but that's not ideal either.

Hey, we don’t support this yet. Would you be interested in opening a PR for it?


Feature Request - Show a loader animation icon

Since run a connection can take several seconds, add a loader animation would be appreciated (especially as the one-click opening instead of a double-click opening surprised me).
startup.webm
It could be a loader:

Or an effect applied on the whole line:
()

Hmm, that takes quite a long time. How long does it take if you connect to it manually, also that long? There will be a few small performance improvements in the next update for the loading time though.
But yeah, adding a loading animation somewhere should be possible.

My terminal takes less than 2s to be displayed outside from Xpipe.

Hmm, we can see whether the startup time improves with the next update

Oh yeah I forgot to mention here that the startup improvement has been delayed a bit last minute because there were some problems with it and I wanted to push out the update. It's definitely in the pipeline, just need to fix a few small things before releasing it.

1.7.16 fixed the delay.

That is great but also sucks that this issue was so prevalent because of a non-sensical reason. I still plan to show better loading animations across the board, it just takes a while to properly implement.

This is now properly resolved through the new terminal launcher in xpipe 8


Add cookie banner/acceptence when signing up

According to WP 29 Opinion 04/2012 on Cookie Consent Exemption 3.2 Authentication cookies simple authentication cookies are exempted from GDPR cookie banner. However, long-term session cookies that persist across browser sessions do need a special consent. This can be implemented as:

The commonly seen method of using a checkbox
and a simple information note such as “remember me (uses cookies)” next to the submit form
would be an appropriate means of gaining consent therefore negating the need to apply an
exemption in this case.

Decision: implement it as such a "remember me" checkbox

Let's wait until nuxt/h3 finally provides session/auth


Message for no access error is displayed at every other attempt for code completion

Ensure the "[feedback] in progress" flag is reset in all scenarios; success and error.

Looks like tests do not have
assert.equal(cancelSuggestionFeedbackSpy.called, false);

scenario only true cases. Is it intended?

@hasys

Looks like tests do not have
assert.equal(cancelSuggestionFeedbackSpy.called, false);

scenario only true cases. Is it intended?

Yes, see https://github.com/ansible/vscode-ansible/blob/71915d564deaf8420eb8a052f09f34a22dc38905/src/features/lightspeed/api.ts#L163
We always ensure the in-flight/in-progress feedback is reset.
We used to only reset it if the "completion" call was successful; which led to the problem @TamiTakamiya reported.

@hasys

Looks like tests do not have
assert.equal(cancelSuggestionFeedbackSpy.called, false);

scenario only true cases. Is it intended?

Yes, see
https://github.com/ansible/vscode-ansible/blob/71915d564deaf8420eb8a052f09f34a22dc38905/src/features/lightspeed/api.ts#L163
We always ensure the in-flight/in-progress feedback is reset.
We used to only reset it if the "completion" call was successful; which led to the problem @TamiTakamiya reported.

If it's always true, should it be removed entirely instead of ensuring it is always true?

@hasys

If it's always true, should it be removed entirely instead of ensuring it is always true?

The problem @TamiTakamiya found was caused by it not being called for both (success and failed) scenarios.
The tests are now asserting that the method was called. Isn't this the point of the test, to check something happened?


private repos

Would it be possible to use this on private repositories as well? Perhaps you could authenticate david-www with oath or something so the package.json can be retrieved?

Any news on this issue? Is it a wontfix because it requires users to give access to private code?

Any commentary on whether david-dm is 'safe' to use for private repos?
I was appalled when I looked at the authorization request scope:

The application doesn't need write access to my repos, so why is he asking!?
If I'm RTFMing correcting, it doesn't look like github oauth authorization scopes support read-only access (docs).
In lieu of github support, is there any type of SLA or privacy policy where david-dm states they won't f*ck my private repos?
I really would prefer just granting read-access to the package.json.

@rmharrison There seems to be a workaround. You can allow access to public repos only by changing the authorization scope from repo to public_repo in URL of a page, when GitHub asks for permissions for David.
See: https://superuser.com/questions/1064723/how-to-connect-to-github-only-for-public-repositories

I'd like to use david-dm for private repos. I understand why read is required; write on the other hand...


override auto-resolved dynamodb endpoint

Set endpoint with cli parameter
What is the problem/feature?
Setting the environment attributeDYNAMODB_LOCAL=true statically sets the DynamoDB URL to http://localhost:8000.
However, when running confd in container and trying to docker run --link dynamodb... to a containerized DynamoDB instance it failes to connect as it does not allow the alternate URL (E.g. http://dynamodb:8000) of the container's hostname.
2017-02-16T16:31:21Z b22901cf46b1 /usr/local/confd/bin/confd[1]: FATAL RequestError: send request failed
caused by: Post http://localhost:8000/: dial tcp <IP_ADDRESS>:8000: getsockopt: connection refused

This is the expected behavior since the container is not listening on <IP_ADDRESS>:8000
How did it get fixed/implemented?

Added the cli flag -endpoint that defaults to '' to preserve existing auto-resolved endpoint.
If -endpoint is set to a value like http://localhost:8000 or http://dynamodb:8000 it will override the backendConfig.Endpoint and set aws.Config.Endpoint
Removed DYNAMODB_LOCAL environment logic

How can someone test/see it?
Testing Changes

git clone git@github.com:johnt337/confd $GOPATH/src/github.com/kelseyhightower/confd

cd $GOPATH/src/github.com/kelseyhightower/confd

switch to the branch or commit

git checkout -b feature/dynamodb-endpoint-via-cli origin/feature/dynamodb-endpoint-via-cli
(or)git reset --hard 43abc77e1734f455cbc7bb9c5ad6a32afee1bb71

./build

Expected Results (building & running with --help)

Populate your local DynamoDB instance

Expected Results (running)

Can I expect it to be merged someday?

Why dont you use the DYNAMODB_LOCAL as value for the endpoint?

@vitorfox the are no plans to add new CLI options for backend configuration. A new mechanism to configure a backend will be introduced.

I recall starting out using the DYNAMODB_LOCAL option, but as soon as I started using a sidekick pattern where the hostname was something other than localhost It didn't work. Its been some time, but I believe that was why. Long story short we forked and ripped out the CLI & config parsing in favor of Cobra & Viper.


Aliasing 'Link' field causes error

This query works okay:
query GoogleMapsLinkQuery {
  prismicCompanyMetadata {
    data {
      google_maps_link {
        url
      }
    }
  }
}

But aliasing google_maps_link results in error:
query GoogleMapsLinkQuery {
  prismicCompanyMetadata {
    data {
      googleMapsLink: google_maps_link {
        url
      }
    }
  }
}

The error is as follows:
{
  "errors": [
    {
      "message": "Cannot read property 'type' of undefined",
      "locations": [
        {
          "line": 4,
          "column": 7
        }
      ],
      "path": [
        "prismicCompanyMetadata",
        "data",
        "googleMapsLink"
      ],
      "stack": [
        "TypeError: Cannot read property 'type' of undefined",
        "    at type (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/gatsby-source-prismic/src/node/generateTypeDefsForCustomType.js:98:41)",
        "    at resolveFieldValueOrError (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:467:18)",
        "    at resolveField (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:434:16)",
        "    at executeFields (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:275:18)",
        "    at collectAndExecuteSubfields (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:713:10)",
        "    at completeObjectValue (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:703:10)",
        "    at completeValue (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:591:12)",
        "    at completeValueCatchingError (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:495:19)",
        "    at resolveField (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:435:10)",
        "    at executeFields (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:275:18)",
        "    at collectAndExecuteSubfields (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:713:10)",
        "    at completeObjectValue (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:703:10)",
        "    at completeValue (/Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:591:12)",
        "    at /Users/ryanditjia/Workspace/unggulsemesta.com/node_modules/graphql/execution/execute.js:492:16",
        "    at process._tickCallback (internal/process/next_tick.js:68:7)"
      ]
    }
  ],
  "data": {
    "prismicCompanyMetadata": {
      "data": {
        "googleMapsLink": null
      }
    }
  }
}

I’m on v3.0.0-beta.10, not sure if the same problem is in v2. Thanks.

I'm running into the same issue. I'm on v3.0.0-beta.9.

Hey Angelo, I'd love to migrate some existing sites to v3 - particularly because of schema support. But refactoring fields I've aliased and plucked down as a props would be a nightmare. How complicated is this to fix?

Hi @AllanPooley, I don't think the issue is too complicated, but I am not sure how to reference alias information within a GraphQL resolver.
The relevant code is here: https://github.com/angeloashmore/gatsby-source-prismic/blob/dacaaaa5c8483675e0c0cc15be7fd1069bc52432/src/node/generateTypeDefsForCustomType.js#L87-L103
Basically, the resolver checks the key of the field and grabs that value from the parent. Because the field is aliased, the name of the key doesn't match what the parent actually contains.
This was written before the most recent improvements to Gatsby's schema customization, so there may be an alternative way to handle this here: https://www.gatsbyjs.org/docs/schema-customization/#foreign-key-fields
If you have time, I'd be happy to review a PR to fix this!

Looking more closely at the example provided, it could be as simple as checking first if value exists before running getNodeById. That may just band-aid the issue so this requires a bit more thought.

Just ran into the same problem with using aliases.
When I try to use an alias for an image field I get the following error

"TypeError: Cannot read property 'localFile' of undefined"

In my case I want to fetch the same image twice, with different transformations applied to it. To do this I need to use an alias.

@mduecker Glad you found a workaround. We'll definitely need to find a real solution to this. I should have time soon to dive into this.


Add integration saved views for Presto

What does this PR do?
Add integration saved views for Presto
Motivation
Saved views are now part of integrations
Additional Notes

https://github.com/DataDog/integrations-core/pull/5713
https://github.com/DataDog/integrations-core/pull/5865
https://github.com/DataDog/integrations-core/pull/5866
https://github.com/DataDog/integrations-core/pull/5870
https://github.com/DataDog/integrations-core/pull/5871
https://github.com/DataDog/integrations-core/pull/5872

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Stagging --> ok


notes from Instructor Training WS nov 2019

how to motivate

what are the goals?

test coverage warrants confidence

intro to linting, testing
broken example with obscure defect

show how a test saves the day (cm vs. inches, imprecise pi)?

scenarios and design patterns for various use cases (fitted with test scopes)

unit tests
parallelization tests
asynchronous tests
systems tests
for each applied language

"not necessary, is investment for future"
how to convince supervisors / end users of benefits?
test-driven development

good for (re-)structuring projects
not suitable for developing existing projects w/o TDD
new WS format: hackathon
write tests, others implement them
reflect on ease of doing this and how to simplify this process (refactoring/separation of concerns)
nice link to modular code development

I've linked this in the instructor guide, so closing this issue.


Remove Python uncaught exceptions doc

This doc is no longer needed because our Python notifier supports sending uncaught exceptions to Airbrake automatically, right out of the box.
Added here: https://github.com/airbrake/airbrake-python/pull/85

Thanks @sgray 👍


Fix serialization

Fixes #1978

@Shredder121 @johnktims @robertandrewbain Could I get a review?

:+1: Sorry, looks fine to me.

Oh, we could also backport this I suppose.


Host is counted twice if it has multiple host tags in Prometheus exporter

Description

If hosts have multiple host tags, the total/up/down hosts in prometheus exporter are not correct.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2132

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2138

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2139

@ustcweizhou @DaanHoogland
Seems like the build failure is because it is unable to resolve HostVO and hostDao isn't injected
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-plugin-integrations-prometheus-exporter: Compilation failure: Compilation failure:
[ERROR] /jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-<IP_ADDRESS>-SNAPSHOT/plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:[103,33] error: cannot find symbol
[ERROR]   symbol:   variable hostDao
[ERROR]   location: class PrometheusExporterImpl
[ERROR] /jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-<IP_ADDRESS>-SNAPSHOT/plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:[103,19] error: cannot find symbol
[ERROR]   symbol:   class HostVO
[ERROR]   location: class PrometheusExporterImpl
[ERROR] -> [Help 1]

@blueorangutan package

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2141

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2147

LGTM, changes are strictly in promethus plugin; merging based on lgtms and travis tests.


Can I run weston with userland?

Description
This might not be an issue, but I am just confused about patches found in this layer, especially ones in the userland recipe, which add support for Wayland and EGL, and so on.
This closed issue also doesn't help :)
https://github.com/agherzan/meta-raspberrypi/issues/243
My main goal is to have an accelerated h264 video playback on a rotated screen on Rpi 3 CM3+.
I've tried everything I could and spent already weeks literally to get this job done without success.
By everything, I mean combinations of:

kernel version 4.19.x, 5.4, and 5.10 (multiple revisions of each)
firmware from 2019 releases up to the latest bullseye
GStreamer versions 1.16 to 1.18
userland/vc4graphics
multiple mesa versions (if applicable)

My conclusion is that the vc4 driver in the kernel is still not mature and bug-free enough to get me there.
Not even in the latest 5.10.x and bullseye firmware. The errors I see in the dmesg are described here:
https://github.com/raspberrypi/linux/issues/3791#issuecomment-850095010
After getting back to the roots with userland, I started having luck, where I could play a video nicely, only with some minor GStreamer error after each loop. I am pretty confident I will resolve this one somehow later on if this is the right way at all. However, this way is more limiting to my other requirements. For example, without Weston running on the vc4 mesa driver, I cannot rotate the screen. I could use display_hdmi_rotate in config.txt though, but this one strangely works only for 720p; on 1080p, the picture is garbled (I have also tried multiple firmware revisions without success). Shall I open a bug for this somewhere?
EDIT: I have opened the issue for 90deg rotation on 1080p screen. I suspect u-boot doing this.
https://github.com/agherzan/meta-raspberrypi/issues/968
So I started digging into a Weston running on the RPI backend, but I found out that this one was dropped long ago.
Newer mind, I found multiple patches, which seems like Weston should run nicely on EGL provided by userland, but that is not my case, unfortunately :(
I would be glad if I could discuss this topic personally with someone on discord or email. However, I think I have to miss some piece of info because my requirements are nothing special, and in my opinion, many people would want the same from their Pies.
Steps to reproduce the issue:

MACHINE="raspberrypi-cm3"
DISABLE_VC4GRAPHICS=1
IMAGE_INSTALL_append = " weston"
set dtoverlay to vc4-kms-v3d to enable /dev/dri/card0

Describe the results you received:
[14:13:39.349] Command line: weston --tty 1
[14:13:39.349] OS: Linux, 5.4.83-v7, #1 SMP Wed Jan 20 09:59:41 UTC 2021, armv7l
[14:13:39.349] Using config file '/etc/xdg/weston/weston.ini'
[14:13:39.350] Output repaint window is 7 ms maximum.
[14:13:39.350] Loading module '/usr/lib/libweston-8/drm-backend.so'
[14:13:39.355] initializing drm backend
[14:13:39.356] logind: failed to get session seat
[14:13:39.356] logind: cannot setup systemd-logind helper (-61), using legacy fallback
[14:13:39.360] using /dev/dri/card0
[14:13:39.360] DRM: supports universal planes
[14:13:39.360] DRM: supports atomic modesetting
[14:13:39.360] DRM: supports picture aspect ratio
[14:13:39.360] Loading module '/usr/lib/libweston-8/gl-renderer.so'
MESA-LOADER: failed to open vc4 (search paths /usr/lib/dri)
failed to load driver: vc4
MESA-LOADER: failed to open kms_swrast (search paths /usr/lib/dri)
failed to load driver: kms_swrast
MESA-LOADER: failed to open swrast (search paths /usr/lib/dri)
failed to load swrast driver
[14:13:39.366] failed to initialize egl
[14:13:39.393] fatal: failed to create compositor backend
Internal warning: debug scope 'drm-backend' has not been destroyed.

Describe the results you expected:
I would like to have Weston running with userland drivers.
Additional details (revisions used, host distro, etc.):
Raspberry Pi Compute Module 3+
yocto poky
mainly dunfell, but I tried recipes from meta-raspberrypi master too

VC4 should be mature enough to use now. I have been working on top of it for a good while now.

Hm, not for me :( do you use some hardware-accelerated video decoding in your projects? The support is better on Rpi4, but on the Rpi3 or ComputeModule 3, there is still a bug in the kernel which prevents me from using the VC4 unfortunately :(
I am trying to push it forward to make it more visible in the linux-raspberrypi GitH, but so far there wasn't a big movement.

Anyway, this question was mainly to prevent confusion. I couldn't find much of the documentation or some better info online. I just wasn't sure whether it was supposed to work or not (Weston with userland drivers). The list of patches seems like it should, but at the same time I think it is now deprecated as Weston has dropped support of an RPI backend. So maybe those Weston patches for userland are now deprecated too. If they were meant for the RPI backend.

I see. That clarifies it now. What is the situation on Raspbian? Could we try to have a comparison with the reference RPi distro?


After the move test network completed the task, the task progress became 0 the next day.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I have done many of tasks, at first it was shown my progress in the guild page,but now nothinig is shown. why?


Fix unit test failure

What's the purpose of this PR
Fix unit test failure
Brief changelog

set trimStackTrace to true for unit tests
reset mock inject in tear down phase to make sure the context is clean

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.

Codecov Report

Merging #3139 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3139      +/-   ##
============================================
- Coverage     51.24%   51.23%   -0.02%
+ Complexity     2236     2234       -2
============================================
  Files           432      432
  Lines         13427    13425       -2
  Branches       1381     1381
============================================
- Hits           6881     6878       -3
+ Misses         6069     6068       -1
- Partials        477      479       +2

Impacted Files
Coverage Δ
Complexity Δ

...mework/apollo/portal/spi/ldap/LdapUserService.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...rk/apollo/spring/property/SpringValueRegistry.java
83.33% <0.00%> (-5.56%)
10.00% <0.00%> (-1.00%)

.../apollo/internals/RemoteConfigLongPollService.java
77.71% <0.00%> (-0.61%)
28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124ceaa...0e32697. Read the comment docs.


[BUG] Not compatible with 0.111.* verision of Hugo

I tried to installed Hugo from source and from apt but didn't work.
[mattos@mysite]$ hugo server
WARN 2024/05/25 17:38:36 Module "hugo-texify3" is not compatible with this Hugo version; run "hugo mod graph" for more information.
Start building sites …
hugo v0.111.0-3fa8bb8318114cd69315eadd35bda169e6a8ca4b+extended linux/amd64 BuildDate=2023-03-01T20:57:44Z VendorInfo=gohugoio

                   | EN
-------------------+------
  Pages            |   1
  Paginator pages  |   0
  Non-page files   |   0
  Static files     | 157
  Processed images |   0
  Aliases          |   0
  Sitemaps         |   1
  Cleaned          |   0

Built in 35 ms
Watching for changes in /home/mattos/mysite/{archetypes,content,data,layouts,static,themes}
Watching for config changes in /home/mattos/mysite/config.toml, /home/mattos/mysite/themes/hugo-texify3/config.toml, /home/mattos/mysite/themes/hugo-texify3/config/_default
Environment: "development"
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at //localhost:1313/ (bind address <IP_ADDRESS>)
Press Ctrl+C to stop
^C[mattos@mysite]$ hugo mod graph
WARN 2024/05/25 17:38:43 Module "hugo-texify3" is not compatible with this Hugo version; run "hugo mod graph" for more information.
project hugo-texify3
[mattos@mysite]$

Environment variables
[mattos@mysite]$ hugo env
hugo v0.111.0-3fa8bb8318114cd69315eadd35bda169e6a8ca4b+extended linux/amd64 BuildDate=2023-03-01T20:57:44Z VendorInfo=gohugoio
GOOS="linux"
GOARCH="amd64"
GOVERSION="go1.20.1"
github.com/sass/libsass="3.6.5"
github.com/webmproject/libwebp="v1.2.4"
[mattos@mysite]$

And I followed this tutorial to install the extended edition of Hugo.
I'm on Linux Mint 21.3 x86_64

The solution was to :
1. Remove the current version of Hugo
If you did it with apt just do
sudo apt-get remove --purge hugo

If you did it manually :
sudo rm /usr/local/bin/hugo
sudo rm -rf /usr/local/share/hugo

2. Build Hugo from source (I'm on Mint)

Note : This will install the extended version of Hugo.

wget https://github.com/gohugoio/hugo/releases/tag/v0.126.1/hugo_0.126.1_linux-arm64.deb
sudo dpkg -i hugo_0.126.1_linux-arm64.deb

3. Install 3 npm packages :
npm install postcss-cli
npm install autoprefixer
npm install postcss-import


Use environment variable to set font size

Hi,
I've been using polybar for quite a while and it's simply the best out there!
I just have one issue that I haven't figure out how to do. I'm trying to set the font size by reading the value from an environment variable, but I can't get it to work.
E.g. I use it to define the bar height as follows:
height = ${env:POLYBAR_HEIGHT:40}
but I can't get it to work for the font size. I'm trying to do it as follows:
font-0 = xos4 Terminus:pixelsize=${env:POLYBAR_FONT_SIZE:20};2
It seems to fall back to some default value as it does not matter what I set the environment variable POLYBAR_FONT_SIZE nor the fallback value afterwards.
Thanks a lot in advance.
A grateful user :)

environment variable substitution only works, if the environment variable is the only thing that is assigned, it can't be part of a larger string. That's why assigning the height works but font-0 doesn't.
The way I solved this in my config is by defining the whole font string inside bash:
export BAR_FONT_0="xos4 Terminus:pixelsize=${POLYBAR_FONT_SIZE:-20};2"

And then use that as the value for font-0:
font-0 = ${env:BAR_FONT_0}

Thanks for your answer, got it working now :)

BTW probably worth adding to the wiki as I didn't seem to find this information there. Maybe I just missed it though.


Getting wrong dates in Ionic Android Project With Crosswalk

Hi, I don't know if this happened with someone before.
I have an app that I'm creating with Ionic and I export the app for Android and iOS. I have a screen that has two date fields with this plugin. In iOS and in the browser (Ionic lab) the dates are correct (when I send them to my API), but when I select and send the dates with an Android device, both dates are one day less.
Example:
When I select the dates From: 12/10/2015 To: 12/25/2015
In browser and iOS the dates stay the same, but when I select the same dates in Android, the dates become:
From: 12/09/2015 To: 12/24/2015
Anyone else experienced this already?

This should not happen. Which timezone you are in?

Brazilian time (UTC-03). I don't know if this is caused by the plugin or if this is caused by some server configuration. I wanted to know if this happened with someone else, but seems that I'm the only one with this problem, so maybe it's not a plugin issue...I don't know yet...

This plugin will return only the selected dates. And also it is not related to any server configuration. Please cross check you system date.

I have the same issue, If i select 17-04-2016 then it return 16-04-2016

I tried selecting those dates, but i didn't had this issue. Please check the screenshot.

The problem occur when i convert this value using "toISOString" method. This is because of the timezone difference.
But i have fixed this issue using the following code.
var dateObj = new Date(val);
$scope.game.date = dateObj.getFullYear()+'-'+("0" + (dateObj.getMonth()+1)).slice(-2)+'-'+("0" + (dateObj.getDate())).slice(-2);

It will return the the date in YYYY-MM-DD format.
Thank you @rajeshwarpatlolla

This will give u the local time. If you want to convert to some other time zone, try to play with the timezone offset. Hope that will help you.


Fix ARM templates EPiServerDB connectionstring

Does not match the database name and sql server

Moved to Bicep. Will close this issue....


Custom B2C Policy: ByPass selfAsserted page during signing from external IDP

I have a use case that some of the expected claims (eg: displayName, familyName, surname) that user must input in selfAsserted page should be prefilled and proceed with next step and not having this page popping to the user (in other words, selfAsserted page should be bypassed),
Please note this is for a sign-in flow from an external IDP. I assume this is something to do with SelfAsserted-Social technical profile. Please advise how to achieve this.
I tried adding <DisplayClaims /> in derived SelfAsserted-Social technical profile and passing empty, but then this is overridden by the InputClaims from TrusFrameworkBase.xml
How can I do this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c33bed9-7e41-92cb-e093-80e5fda0e718
Version Independent ID: 94d903c4-a70f-5357-53b4-6d17afee2aaa
Content: Define a self-asserted technical profile in a custom policy - Azure AD B2C
Content Source: articles/active-directory-b2c/self-asserted-technical-profile.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@nkumars Thank you for your query . we will investigate and update the thread.

Response from @amanmcse in this link, if we set ExecuteActionsIf to false, it does work fine, but the second time the same page is popped up for user input. So, I added another Precondition (as below) to existing Preconditions list
<Precondition Type="ClaimsExist" ExecuteActionsIf="true">
    <Value>objectId</Value>
    <Action>SkipThisOrchestrationStep</Action>
</Precondition>

So my full set of Preconditions will be as below:
<Preconditions>
    <Precondition Type="ClaimsExist" ExecuteActionsIf="false">
        <Value>objectId</Value>
        <Action>SkipThisOrchestrationStep</Action>
    </Precondition>
    <Precondition Type="ClaimsExist" ExecuteActionsIf="true">
        <Value>objectId</Value>
        <Action>SkipThisOrchestrationStep</Action>
    </Precondition>
</Preconditions>

Please confirm if this is the right way to do.

@nkumars  If you never want to execute SelfAsserted-Social technical profile, you can just remove/comment-out the orchestration step and re-sequence the orchestration step order number.
With the above preconditions, you are skipping the orchestration step in both conditions; objectID exists=true and object exists=false which means this orchestration step will never be executed. So rather than making the code complex, you can remove the code which will never execute.

@nkumars closing the thread now. Feel free to tag me in your reply if you have any question.

@amanmcse, this explain all, thanks 👍

Hi @amanmcse , @nkumars
Recently , I was having same requirement . "Completely bypass self-asserted page ".
Deleting Orchestration step associated with SelfAsserted-Social was not stopping the self asserted page as down the steps another Orchestration was present which refering Technical Profile "AAD-UserWriteUsingAlternativeSecurityId".
AAD-UserWriteUsingAlternativeSecurityId Profile persisting claim and if not found prompting again the self-asserted page.
The only way to acheive this to comment out OutputClaim from Technical Profile Id SelfAsserted-Social in TrustFrameworkBase.xml.
i.e. Below is the modified code of Technical Profile "SelfAsserted-Social" and commented out part from output claim marked as bold.

User ID signup

api.selfasserted

@manabendra-panda, not really. I made it work just by commenting the above said CLaimsExchange. AlternativeSecurityId is a must for any user profiles created from other social IDP's to have a unique identifier in our B2C. Hence if the values from AlternativeSecurityId is not set in the pipeline, you must set them explicitly in your TechnicalProfiles.
I would recommend not to touch TrustFrameworkBase.xml for any changes, instead try to override them in your inherited extension files or in the policy files.

Did someone managed to bypass the selfAsserted page when signing from externalIDP and create federated user in B2C ?

Comment the SelfAsserted-Social ClaimsExchange and re order the rest of orchestration steps. This should work

Did someone managed to bypass the selfAsserted page when signing from externalIDP and create federated user in B2C ?

Comment the SelfAsserted-Social ClaimsExchange and re order the rest of orchestration steps. This should work

I already tried that and it ended up with the below error:
AADB2C90037: An error occurred while processing the request. Please contact administrator of the site you are trying to access


InteractItemEvent.Secondary.MainHand fired twice when right clicking entity with item in hand

I am currently running

SpongeForge version: spongeforge-1.12.2-2838-7.1.7-RC3928
SpongeVanilla version: spongevanilla-1.12.2-7.1.7-RC297

As I've noted in the following gist:
https://gist.github.com/ItsDoot/a7bbae7419de6096b2506bc5612ae90d
InteractItemEvent.Secondary.MainHand is fired twice when you right click an entity with an item in hand. I believe the first firing is for when there is no item in hand, but is fired anyways, and the second firing is for when there is actually an item in hand.
Another partially related observation: There is no place where Primary.OffHand of any of the interact events is fired; is there a reason the subinterface exists, besides for uniformity?
Plugin used to test events: https://github.com/ItsDoot/event-tester

Working on it.
It seems the two events are fired because of different packets, namely CPacketUseEntity and CPacketPlayerTryUseItem.

There is no place where Primary.OffHand of any of the interact events is fired; is there a reason the subinterface exists, besides for uniformity?

Regarding that, it's technically impossible to use an off-hand item while left-clicking. From the minecraft wiki:

Players also cannot break blocks or attack with the off-hand, even if nothing is held in the main hand.


feature remove some unused in functioncast  and support some function in nereids

Proposed changes
1 ConvertImplGenericFromString do not need a template StringColumnType
2 remove timev1 in function cast
3 support time_to_sec , sec_to_time in nereids

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.69 seconds
stream load tsv:          508 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>1 Bytes

run feut

2.0上也有这个问题，需要合入


⚠ Bofrost.lu has degraded performance

In 9081690, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1724 ms

Resolved: Bofrost.lu performance has improved in 6fd0d1a.


ldap-ltb-passwd CrashLoopBackOff with default values

Describe the bug
ldap-ltb-passwd keeps crashing because of nginx missing file
To reproduce
Steps to reproduce the behavior:

helm install my-release helm-openldap/openldap-stack-ha

Expected behavior
$ kubectl get pod | grep ldap-ltb-passwd
ldap-ltb-passwd-5494c456c-nkhf4      1/1     Running   0          1m

Screenshots
$ kubectl logs deployment/ldap-ltb-passwd
2022-06-24.09:24:20 [STARTING] ** [nginx] [24] Starting nginx 1.23.0
nginx: [emerg] open() "/etc/nginx/nginx.conf.d/php-fpm.conf" failed (2: No such file or directory) in /etc/nginx/sites.available/ssp.conf:11

the problem is the image in  the deployment fasttrack-ldap-ltb-passwd
which uses Image tiredofit/self-service-password:latest
the latest image is not compatible. Manually editing deployment and setting image to 5.2.1 fixes the problem.

add following lines to values.yaml as the workaround:
ltb-passwd:
  image:
    tag: 5.2.1

Works perfectly, thank you !

Works perfectly, thank you !

why did you close the ticket ? I have just provided a workaround and it must be properly fixed.

I reopen it to provide in the next update the fix for the new version of tiredofit/self-service-password:latest
-> It require to push an additional fine in the container to init nginx


Plugins.txt

Hi,
Is there a way that I can add a plugins.txt file with a team needed plugins somewhere?

hey @bigfoot6uk do you mean Jenkins plugins?

Hey, yes  jenkins plugins

hi @bigfoot6uk - in the chart - the jenkins container image build is driven from this s2i git repository:
buildconfigs.source_repo = https://github.com/rht-labs/s2i-config-jenkins
that has a plugins.txt in it. you could fork this for your own uses to customize it. that is probably the quickest way.
the chart does not expose the plugins.txt for overriding explicitly.
If you dont want to make it part of the build, use INSTALL_PLUGINS env var on the deployment config - this works as well. See https://github.com/openshift/jenkins.

@eformat Thanks so much for your response.

no problem, i will close this for now.


Appending questions to MDNS responses breaks Avahi-Daemon (IDFGH-5736)

This is to loop in this library on the discussion being had here:
https://github.com/Aircoookie/WLED/issues/2009#issuecomment-902983255
and here:
https://github.com/lathiat/avahi/issues/348
Basically, the esp-mdns implementation is echoing th question message in responses, which causes avahi-daemon to discard the response as invalid.
I can see this happening here at line 1085:
https://github.com/espressif/esp-idf/blob/master/components/mdns/mdns.c
Apparently, the proper approach as per the RFC for MDNS is to ignore these responses, so it would stand to reason that the behavior on this side is fine, but I just wanted to link it to the other issues for completeness.

https://github.com/espressif/esp-idf/issues/7124

@negativekelvin Thanks for the reference
@d8ahazard This bug was fixed as

f601cb0 on v4.4
3a588d7 on v4.3
93921e0 on v4.2

Please update the IDF version to include the above commits. It's also possible to work around this bug setting

CONFIG_MDNS_STRICT_MODE to y

@d8ahazard Could you please close the issue?

Thanks for reporting, feel free to reopen.


can't run the tests

This is possibly a win32 issue:
Error: Error: Cannot find module 'c:\dev\vscode_cobol.git\out\test'
Require stack:
- c:\Program Files\VSCodium\resources\app\out\vs\loader.js
- c:\Program Files\VSCodium\resources\app\out\bootstrap-amd.js
- c:\Program Files\VSCodium\resources\app\out\bootstrap-fork.js
	at p._doHandleExtensionTests (c:\Program Files\VSCodium\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:930:522)
	at processTicksAndRejections (internal/process/task_queues.js:94:5)

"c:\dev\vscode_cobol.git\out\test" is an existing folder in the file system with a content of runtTest.js[.map] and a suite folder which looks also fine.

Works for me, when the shell is set to bash but it is much easier just to use "node out\test\runTest.js" as you get the output in the current console rather than the spawned "git-bash" console which shows the running tests and disappears.

Running the tests from the integrated terminal resultied in downloading of the vscode-1.50.1-zip and afterwards a

warning: 'sandbox' is not in the list of known options, but still passed to Electron/Chromium.

A second run works directly out of the box. Also working: running the tests via Terminal->Run Tasks->npm->run tests. (the debug configuration still does not work).
I guess there may be a developer docs that says how to run the tests and listing those two options there somedayTM.

You cannot have any vscode instances running, which means you can not run them from vscode itself.
Microsoft might change this but I suspect not, we just have to live with it.


Invalid output in batch_reader.go

strconv.ParseInt: parsing "number": invalid syntax
Steps to reproduce:

Create a repository with actions enabled
Create a file /.gitea/workflows with the content not a number
Create a file /.github/workflows with the content not a number
Open the page /<owner>/<repo>/actions
If no error is shown, refresh the page multiple times until an error occurs

The reason is this code
https://github.com/go-gitea/gitea/blob/ce9978bfd4e035ed065b02b28e02905674320b6a/modules/actions/workflows.go#L47-L50
which fails in line 179
https://github.com/go-gitea/gitea/blob/ce9978bfd4e035ed065b02b28e02905674320b6a/modules/git/batch_reader.go#L152-L181
If the error occurs the code tries to parse not a number as output of the batch reader. A normal output looks like 8b2bfd3a117fcb7ae93f93616cb2f7a9706c513a tree 104. I don't know how the content of a file can be present here. And even worse is that it does not fail every time. If I create only one workflows file it does not fail but that may just be a timing issue.
Git Version
2.43.0, non-gogit

Stacktrace:
code.gitea.io/gitea/modules/git.ReadBatchLine(0xc0034f5008?)
        /src/modules/git/batch_reader.go:182 +0x1c8
code.gitea.io/gitea/modules/git.(*Repository).getTree(0xc005f8c870, {0x3a90360, 0xc0034f5008})
        /src/modules/git/repo_tree_nogogit.go:19 +0xf0
code.gitea.io/gitea/modules/git.(*Tree).SubTree(0xc004ba2f70, {0x327c01b?, 0x316d8c8?})
        /src/modules/git/tree.go:42 +0x1a5
code.gitea.io/gitea/modules/actions.ListWorkflows(0xc004ba2f70)
        /src/modules/actions/workflows.go:50 +0x85
code.gitea.io/gitea/routers/web/repo/actions.List(0xc004be8c80)
        /src/routers/web/repo/actions/actions.go:74 +0x1d7

cat-file --batch will output <sha> SP <type> SP <size> LF\n<content>
After the test, I notice that:
normally, reader buffer will not be empty after read one line, as we have <content> behind.
but reader buffer will randomly be empty, e.g. we will get <sha> SP <type> SP <size> LF\n without content.
And the content will be read at the next time, which caused this bug.


docs: fix typos readme

Thanks @markholland! It's true that we're hunting witches! haha! Lot's of magic is happening here!


gtk-layer-shell is missing vapi file in dev

Describe the bug
gtk-layer-shell is missing the VAPI file, I found this with a Flake I've been working on.
After I ran a GC on the store, the VAPI file disappeared.
Steps To Reproduce
Steps to reproduce the behavior:

nix-shell -p gtk-layer-shell
find $(pkg-config --cflags gtk-layer-shell-0 | sed -e 's/-I//g' -e 's|include/gtk-layer-shell||g')

Expected behavior
find $(pkg-config --cflags gtk-layer-shell-0 | sed -e 's/-I//g' -e 's|include/gtk-layer-shell||g') should print a line with share/vala/vapi/gtk-layer-shell-0.vapi.
Additional context
gtk-layer-shell generates the VAPI file in meson, at src/meson.build:43-49.
Notify maintainers
@eonpatapon
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.71, NixOS, 22.05 (Quokka), 22.05.3441.fe76645aaf2`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"expidus, nixos-22.05"`
 - channels(ross): `"expidus"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

There hasn't been a release since https://github.com/wmww/gtk-layer-shell/commit/3ac6dbcbd8d53d5f1dadd055680555d08c56368a

Strange. I'm not sure why the VAPI file is gone then.

the code to generate the vapi file is not in any release

Alright, not sure why I am suddenly getting VAPI errors for one of my projects which require the file. I didn't have the problem until I updated the Flake.

gtk-layer-shell reports as 0.6.0 when there's 0.7.0 that has the fix.

v0.8.0 is now out and it has the necessary changes.

nix-shell -p gtk-layer-shell pkg-config
find $(pkg-config --cflags gtk-layer-shell-0 | sed -e 's/-I//g' -e 's|include/gtk-layer-shell||g')

shows /nix/store/xxwyl9hmz1vgbgbm4zzvnm6m3c03dyc8-gtk-layer-shell-0.8.2-dev/share/vala/vapi/gtk-layer-shell-0.vapi now.


CI: Update index.yml manifest on push

https://github.com/pha4ge/primer-schemes/issues/19

Same as https://github.com/pha4ge/primer-schemes/issues/28


no spin safari forms

Spinner doesn't spin in form submissions, but spins elsewhere in Safari. A similar issue was reported here but remains without solution. I'm using Safari 7.0.5.
Any workaround possible?

The SO post has an answer. Comment here if you still are having issues.


Cannot use timmy responsive content images with wordpress responsive images in combination

Currently as a theme editor i need to if i want to use the reponsive content images from timmy or if wordpress should make the images reponsive.
With timmy we can define the reponsiveness of content images in a way more detailed way (as it should be) but it only works if the content editor manually selects the correct image size, which has the inherent risk that a content editor just does not do it for whatever reason which ends up with non optimized images.
On the other hand wordpress can automatically make images reponsive but in a very unflexible way which is basically only helpful for full width images like the cover block.

Until wordpress implements responsive images which a theme editor can really configure i think, in the case where it is not sure that the content editors are always setting the correct image sizes, the best workaround would be:

for normal use cases like 1 or 2 columned images in the post content use timmy, if the editor does not set the correct image size it does not hurt so much
for very important images like the fullscreen cover let wordpress automatically make the image responsive to be sure it is not leave unoptimized

Currently this is not achievable because timmy disables the wordpress reponsive image feature when opting in to the timmy reponsive image feature.
I dont know if there is a good way to make them work together and let wordpress do the optimization stuff if timmy is not finding the correct size.
But at least i wanted to make aware of the situation. Maybe there are other good solutions as well.
Thanks!

Sorry for the late answer. I fully agree with you that’s it’s not an optimal solution right now. It’s hard to explain to content editors which size they should choose for which use case.
That’s why for our websites, we developed our own image block where this case is handled automatically. If used in a column context, we can automatically use the optimal size for the image because we can pass down the number of columns with Block Context. But for this to work properly, we also developed our own column block.
The same goes for cover blocks. We use our own header block so that the featured images can automatically take their optimal size depending on the use case.
Of course developing custom blocks is not for everyone.
I don’t know if there is a good way either. Maybe we would have to completely rework the Responsive Content Images functionality. There’s tons of filters in wp_filter_content_tags() and the underlying functions that we could use. Maybe we could hook into the filters there and process each image individually instead of just disabling that functionality all together.
I didn’t have the resources to look more into that, because we have a solution that is working fine for us using custom blocks. But I’m open to help with finding a good solution for this if someone wants to take this on.


Hide explorer tab when user inside extensions

don't show explorer file tab when user inside extensions

@joaomoreno fyi

Closing as designed.


scrollTo element name does not scroll exactly to element

document.getElementById(id).scrollIntoView(); works perfectly but scroller.scrollTo(id, { containerId: 'container' }) scrolls slightly above and I cannot correct it with offset because the mismatch is not fixed (ie. difference between correct position and scrolledPosition varies).
my Elements are .map()ped like with following render() : <Element name={doc._id} id={doc._id}>content</Element>.

Same problem.

Yes, I have the same problem.

Feel free to make a PR, I Haven't had the time to fix this yet.

Well, maybe it will also help someone,
I've spent some time going through this issue on my end and I've realized that the problem in my case was in the structure of layout.
I have a grid of products with images and text divided by categories, each category is wrapped in Element.  And some of those real images differ in height, by only a 10-20px, but that's enough to offset the layout upon scrolling.
So as far as I understand, when the grid loads it eagerly registers elements in the grid that uses placeholders and when the scroll is initiated placeholders start to get replaced via lazy load mechanism which makes the grid larger on Y-axis and it results in the scroll stopping just some 10-20 pixels above actual element.
I've verified that enforcing height consistency does solve this issue for me.

https://github.com/fisshy/react-scroll/pull/368

Had this issue aswell in the current version.
Thanks to the code in the linked PR I figured out that I needed to set position: relative on the container.


Racerlib

First step towards phildawes/racer#94. The restructuring was all done at high level, so it only involved moving files around and fixing the imports.

Hi @Victor-Savu. Cool! I think you forgot to git-add the bin and test directories though

Thanks! I didn't notice that bin was in the .gitignore. I suggest removing it from there since it is the customary place to put the sources for executable targets.
The tests I think I have added. I just moved the system tests to their own directory. I was following the guidelines from the book (or at least as much as I could remember without actually reading it again). I don't have a strong opinion for where the tests should be, but it makes the separation between crate and module-level testing more clear. Going forwards, it might also help maintain the growing test suite.

Whoops! I managed to break some tests when I added the extra level of indentation for the test module. Should be fixed now.

Looks good to me, merged. Thanks v much @Victor-Savu


RoBERTa is it availaible for French language

Hello guys,
I want to experiment this system for French language and I'd like to know if  RoBERTa is availaible as an NLP ressource for French language.
Thank you in advance,

@hamzaelouiaazzani Bonjour! Have a look at this: https://camembert-model.fr/


Fix bugs in the domain change detection code

call memmove() with the number of bytes (not the number of array
elements)
set the "changed" flag properly (do not reset it to zero)
remove all domains that are no longer needed, even if multiple
domains need to be removed

Urgs. That was written by me? I go and stand in the corner for today...


Implement Compression

What is the purpose of this change? What does it change?
This change implements compression as per #21. In order to do this we need to extend the blob struct layouts in both the packer and the index. Blob now include both actual size and packed size as well as compression method (opening the door for different compressors).
On my system this represent a significant improvement to performance upon initial snapshot. For example when I take a backup of a 40gb VM archiving goes from about 12 min to 8 min. This is because on modern systems CPU performance far exceeds IO bottlenecks so compressing makes it much faster (I have 12 cores - they were all working fully during the initial archive).
The packer format is extended in a backward compatible way:

Previously there was no header length encoded - this means the length had to be calculated.
Previously blobs were all the same size.

This PR adds a header to the pack format that explicitly declares the size of the header (the compressed array of blob records). This allows us to have blob headers of different sizes.
I kept the old DataBlob and TreeBlob types but introduced a new ZlibBlob type which contains extra fields.
When opening an existing pack created by earlier versions, we recognize the old format by looking at the MSB of the last 32 bit int - in the old format this is used as the header length and can not be non 0 (since there is a check that it must be < 16mb) we then just fall back to the old way - converting the existing blobs which can not have compression.
When we see a new style pack we can then parse the different blob types and determine which ones are compressed (it is possible to enable/disable compression on demand).
This is an initial CL to see how this feature would be accepted - since the changes are extensive it would be good to start discussions. In particular it would be good to figure out if compression should be opt in (e.g. via a flag) or the default way it operates.
All the tests currently pass.
Was the change discussed in an issue or in the forum before?
The need for this feature was discussed extensively.
Closes #21
Checklist

[x] I have read the Contribution Guidelines
[x] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[ ] I have run gofmt on the code in all commits
[ ] All commit messages are formatted in the same style as the other commits in the repo
[ ] I'm done, this Pull Request is ready for review

Nicely explained @scudette! But shouldn't all other checkboxes be ticked before ticking the last one?

I was hoping for some comments regarding the direction of the PR - I dont think it is quite ready to merge but it would be nice to have someone review it to see if it is horrendously controversial.

First, very nice, the lack of compression has kept me away from restic.
Took a quick look at this and noticed the use of zlib. It would be nice if a more modern compression algorithm is used, given that zlib hasn't aged well. Its possible to get both similar compression ratios and higher compress/decompress speeds with something like zstd. So if only a single compression algo were chosen, zstd might be a more reasonable choice, if additional code is added to support more than one algorithm then adding lz4, and a couple of the higher compression ratio algorithms might be a good choice. (some nice (if slightly dated) comparison graphs can be found here: https://gregoryszorc.com/blog/2017/03/07/better-compression-with-zstandard/)

One nice thing about zlib is that it has a stdlib Go implementation, while using the official ztsd compressor would require Cgo.

Being able to select different compression algorithms (including none) for different filetypes might also be appropriate. Compression does little for multimedia files, and if you're backing up a large volume of them it would be nice to avoid the CPU overhead.

The nice thing about this pr is that the file format was modified to
support different types of blob and there is a field to specify compression
types. It is therefore possible to extend to different algorithms and even
have some blobs uncompressed at all (eg for multimedia files)
On Fri, Nov 1, 2019, 07:21 Ryan Hitchman<EMAIL_ADDRESS>wrote:

One nice thing about zlib is that it has a stdlib Go implementation, while
using the official ztsd compressor would require Cgo.

Being able to select different compression algorithms (including none) for
different filetypes might also be appropriate. Compression does little for
multimedia files, and if you're backing up a large volume of them it would
be nice to avoid the CPU overhead.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/restic/restic/pull/2441?email_source=notifications&email_token=AA5NRIUXICLXGH62BYUXMQDQRND6LA5CNFSM4JAHLJEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZJFTA#issuecomment-548573900,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5NRIU6GZM42LY44C6FQ2LQRND6LANCNFSM4JAHLJEA
.

Thanks for giving this a try! I'll get to you with more feedback as soon as I find some time, but from the top of my head here are a few (unordered) thoughts:

We've talked about adding compression on IRC the last couple of weeks, there some other things came up that might be necessary to add, like adding the compressed/uncompressed size to the index files
In general I agree with what you implemented: the on-disk format should have compression information per blob, so we can have restic compress one blob in a pack but not the others.
When we change the repository format to add compression (and increment the version field in the config file) it may be a good idea to do other smaller things in the same go, like packing snapshot files and compressing the index files by default.
I think there should be three settings for compression: standard, max, and off, with "standard" being the default. I also think we should not expose the compression algorithm to users, it should be zstd (the Go implementation by Klaus).

I've been testing this branch for a little while and have noticed some issues with silent data corruption. Possibly caused by restic being OOM killed during backups (though I would expect the repo to be resilient to crashes). This is in a repo that has only used this branch, so there's no mixed compressed/uncompressed blobs.
I've gotten it into a state where a restic prune crashes hard:
sh-4.2# restic prune
repository ea011e5d opened successfully, password is correct
counting files in repo
building new index for repo
[7:14] 100.00%  26714 / 26714 packs
repository contains 26714 packs (199267 blobs) with 115.593 GiB
processed 199267 blobs: 29 duplicate blobs, 19.013 MiB duplicate
load all snapshots
find data that is still in use for 108 snapshots
[0:14] 100.00%  108 / 108 snapshots
found 194718 of 199267 data blobs still in use, removing 4549 blobs
will remove 0 invalid files
will delete 125 packs and rewrite 398 packs, this frees 1.666 GiB
decompressing blob 0b2e4bff8d0d60b6c63903a3bf0abe9ade5663e1930ae77ef5b5d2b91461084d failed: zlib: invalid header
github.com/restic/restic/internal/repository.Repack
        /restic/internal/repository/repack.go:96
main.pruneRepository
        /restic/cmd/restic/cmd_prune.go:278
main.runPrune
        /restic/cmd/restic/cmd_prune.go:85
main.glob..func18
        /restic/cmd/restic/cmd_prune.go:25
github.com/spf13/cobra.(*Command).execute
        /restic/vendor/github.com/spf13/cobra/command.go:762
github.com/spf13/cobra.(*Command).ExecuteC
        /restic/vendor/github.com/spf13/cobra/command.go:852
github.com/spf13/cobra.(*Command).Execute
        /restic/vendor/github.com/spf13/cobra/command.go:800
main.main
        /restic/cmd/restic/main.go:86
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1357

However, restic check reports everything as ok:
sh-4.2# restic check
using temporary cache in /tmp/restic-check-cache-557794085
repository ea011e5d opened successfully, password is correct
created new cache in /tmp/restic-check-cache-557794085
create exclusive lock for repository
load indexes
check all packs
pack c1c71e31: not referenced in any index
pack 16138198: not referenced in any index
pack 19f3df11: not referenced in any index
pack 9d5b1ad8: not referenced in any index
4 additional files were found in the repo, which likely contain duplicate data.
You can run `restic prune` to correct this.
check snapshots, trees and blobs
no errors were found

Doing a restic check --read-data though uncovers that a substantial amount of blobs can't be decompressed:
sh-4.2# restic check --read-data
using temporary cache in /tmp/restic-check-cache-474558335
repository ea011e5d opened successfully, password is correct
created new cache in /tmp/restic-check-cache-474558335
create exclusive lock for repository
load indexes
check all packs
check snapshots, trees and blobs
read all data
decompressing blob 05c5307c72b10abd7a00299a3d5baadbabefe9843f969a8b2be710be8be4d260 failed: zlib: invalid header
decompressing blob 1891ce94307f9f882db3d356a4bd24fe4b882c1c6ff755acd1d2c03980cf6ba7 failed: zlib: invalid header
decompressing blob 0b2b74eac94419856c2105db1c0bc7e5efce131c416454b797603cba473f8b5d failed: zlib: invalid header
decompressing blob c308733a30fb5c421ac3f06b99ef1ff908d034ea4620844a65ca7a1455dccf75 failed: zlib: invalid header
decompressing blob 8b51ff4be2cd0f1fbb6c98cfcf8625b6c23822b875d5a8f7e7de9b28771dc3cb failed: zlib: invalid header
decompressing blob 827edd87169cb4b4accde3db6ac281094f18b3d27af3833b9ea9540a2eb696b0 failed: zlib: invalid header
decompressing blob 6c6dd3e41efa3fc74409dd512ea33a850ef8d3da6f4bd6c07d99053c9de03bb1 failed: zlib: invalid header
... <~1000 more invalid header errors> ...

I'm not sure what other information would be useful in tracking down why this happened, but I'll keep the repo around if that would help.
Figured this would be worth reporting in case anyone else is testing this branch or if any part of this implementation will be going ahead (I think I saw above that the compression algorithm at least is set to change).

Any news about compression?
I'm experimenting with a management interface and a new backend, but compression is blocking me on using restic definitely because of potential large volume usage for some type of data (large text and xml files).
I don't know Go, so I can't help you, sorry.

I'd love to see the compression added to restic. One of my issues with restic (and a few other backup solutions) is high bandwidth usage. While I think the main issue is somewhere (since incoming usage is almost as big as outgoing usage, indicating issues in prunning process), adding compression would help decrease it.

I think there should be three settings for compression: standard, max, and off, with "standard" being the default. I also think we should not expose the compression algorithm to users, it should be zstd (the Go implementation by Klaus).

I'd want to disagree with this. There isn't a single "best" compression algorithm - and each data being backed up will have different characteristics.
Recently I've been testing https://github.com/knoxite/knoxite , which allows for no compression or using one of 5 different compression algorithms: zlib, flate, gzip, zstd and lzma. I was surprised to find out that, for my data, zstd was second worst algorithm. It took 17 minutes to backup, where lzma took 42 minutes, no compression took 3 and zlib, flate and gzip took about 6 minutes each. It also had second worst memory usage - not far behind lzma. Each created repository with almost the same size.
Maybe the writer requires more tweaking, maybe my data happened to be the worst-case scenario or my testing methodology is flawed somehow. In any case - I think such decision should be done after gathering benchmarking data.
Maybe have choice of fast, standard (default), max for compression level, and compression type as <name of compression algo> with zstd or maybe gzip as default values?
Not sure how much that'd help, but my initial testing methodology and results are in this gist: https://gist.github.com/Prof-Bloodstone/85b1d3077db7aeb0ac8bcbaa49f730bb
I know my method isn't very scientific - wanted to rerun it in more isolated environment, but found a bug in knoxite. I'll update this comment once I have the time to re-run it.

@Prof-Bloodstone For 98% of the users, no compression at all (given deduplication) is already fine because their "large" files (photos, music, videos) are already compressed with specialized algorithms. Compression in a backup tool can still be useful and I was actually surprised to learn Restic doesn't have it, but I'd venture that for the remaining 2% of users that really need this, again an upper 90s percentage of users would be fine with what was proposed above. Personally I'd even propose lower default compression settings in favor of speed because I don't want my backup tool to be as slow as xz/bzip2 (which trickle compressed data to squeeze out a couple percent lower file size).
I'm not against a proposal of adding various compression algorithms and allowing the user to tweak their parameters, but I also wouldn't want to push back the implementation of basic compression in favor of something with a lot bells and whistles. We can keep in mind that the compression type (algorithm; settings) should be parameters rather than hardcoded (would probably do that anyway), but beyond that I would start with exactly what fd0 proposed: one decent algorithm, set to reasonably fast defaults, with an option to turn it off, and perhaps also an option to turn it up if you prefer smaller files over slower backups.

@lgommans I'd prefer speed over compression too - usually there's diminishing returns when you go up in time spent. IMO the defaults should be a decent, but fast compression - but that's up to project owners to decide.
I just wanted to raise attention to the fact that going blindly for only one "best" compression type isn't the best idea and it should ideally be determined based on some benchmark.
One thing that didn't make it to my comment, is that the project was using zstd implementation that let them have less work redistributing it (AFAIK no need to cross-compile or something? I'm not familiar with Go), so it's possible that the other available alternative library is better.
Sorry if my comment sounded like I'm against the PR - as I said, just wanted to raise attention with some numbers to maybe benchmark a few algorithms and based on that select the first that could be pulled before potentially adding the rest.

Backup database dumps is a perfect use case for compression.

Personally I'd even propose lower default compression settings in favor of speed because I don't want my backup tool to be as slow as xz/bzip2 (which trickle compressed data to squeeze out a couple percent lower file size).

xz is actually quite fast with -0 (compression level) and -T (multithreading). Same for zstd.
Regarding speed, compression could  also improove speed where disk writes or network throughput is limiting.

Ok, people, please hold your horses 😄
Please don't use this PR for discussing the merits of the different compression algorithms. The challenge in getting compression into restic is not the choice of algorithm. Thanks!

There is a Go implementation of ztsd that's still in beta: https://github.com/klauspost/compress

The zstd implementation is out of beta in the meanwhile. I think this should be reconsidered!
There is a nice discussion on reddit summing up all the recent efforts of pure golang implementations of zstd.

There is a Go implementation of ztsd that's still in beta: https://github.com/klauspost/compress

The zstd implementation is out of beta in the meanwhile. I think this should be reconsidered!
There is a nice discussion on reddit summing up all the recent efforts of pure golang implementations of zstd.

any updates?

@jnemeiksis If there were, you would have seen them in this thread. There's little point in asking such a question.

An idea. Disclaimer: This is based on my shallow skimming through pack.go and the design document.
Acknowledge these design limitations:

Storage ID of data is the hash of plaintext so dedup works
Compression info cannot be in tree, otherwise restic cat <blob-id> would be inefficient

Idea:

Let Packer handles crypto and compression.
Avoid adding another set of the blob types (e.g. compressed-tree / compressed-data).

Implementation Strategy:

Refactor to let Packer do crypto in current code.
Add a new PackV2 format which is nested into the current Pack format.

Define a new blob type PackV2 = restic.BlobType(2)
Header contains one entry, the whole nested PackV2

Type_Blob1 = restic.BlobType(2)
Length(EncryptedBlob1)
Hash(Plaintext_Blob1) can be all zero (breaks old restic, but not sure if this will be critical)

Inside PackV2:

Blob1 || Blob2 || ... || BlobN || EncryptedMetadata || EncryptedMetadataLength
Plaintext metadata can be a JSON object, for extensibility.
Metadata can be compressed as well
Metadata describes how BlobN should be extracted
Metadata reuses the concept and semantic of blob type, storage ID, etc

Increase the repo version and whatever necessary

Avoid adding another set of the blob types (e.g. compressed-tree / compressed-data).

What is the point of doing so?

Plaintext metadata can be a JSON object, for extensibility.

This is total overkill to add compression. Which other pack format changes do you expect?

Add a new PackV2 format which is nested into the current Pack format.

It would be much simpler to just set the length field to 0 and then use that as an indication to look for a formatV2 pack header. (Not that I think we really need a new header format.)

Superseded by #3666, I'm closing this issue.


Cannot modify content padding.

Hi! Thanks for the great package! Little issue here. I am not able to see an option to modify the padding/margin around the content of the tooltip. It seems that there is something like a default padding. Maybe I am missing something. Otherwise I would recommend to add a property to control it. Thank you in advance!

 At vero eos et accusam et justoduo dolores et ea rebum. ",
            softWrap: true,
          )),
    );

Something like being able to set this value in the _BubbleShape class.
EdgeInsetsGeometry get dimensions => new EdgeInsets.all(10.0); //this value of ten

Let me see if I manage to find some time to propose a merge for this feature.

x2

@igonzarec @bensonarafat
The issue has been resolved.


custom transitioning view

I have a view that has a button,and 4 imageview. I want the 4 imageviews do Explode transition but I dont want the button do Explode. how to do ?
I have a doubt that the below code need to set before setContentView.
getWindow().setExitTransition(mExplode);
but after setContentView, I get the view id.
then use this code to setTransition.
mExplode.addTarget(mImgRl);
hope your reply !
sincerely

You can do something like:
transition.excludeTarget(findViewById(button), true);

it works！thanks


Add persistent_comment option for /describe

The comment isn't replaced and there is no option to do it when publish_description_as_comment is enabled.

its possible
why do you want to use at all the mode of 'publish_description_as_comment' for describe ?

since we update the description manually and it's sometimes overwritten by the generated one

unclear
What's your use case for using publish_description_as_comment at all ? why not write directly to the PR header ?
It does not overwrite the original content, it adds to it:
https://pr-agent-docs.codium.ai/usage-guide/automations_and_usage/#github-app-automatic-tools-when-a-new-pr-is-opened

Open a PR
Start editing the description manually
PR-Agent generates content based on the content before editing
Finish editing manually
The manual edit or PR-Agent overwrites content of the other

To avoid this issue, we enabled publish_description_as_comment

https://github.com/Codium-ai/pr-agent/pull/837
done

Thanks!


test: add session.end support in nodejs runner

This is a step towards e2e via chromedriver testing.

Add session.end command in nodejs runner.
End session after each e2e test.

https://github.com/GoogleChromeLabs/chromium-bidi/issues/2056


Pytest-xdist

Closes #1622
This PR makes a few changes to the way tests are handled:

Switches to pytest purely  as a test runner.
Adds pytest-xdist
Switches to pytest-cov to generate .coverage files, but leaves coverage.py to process them.

The last point about pytest-cov is due to the simple fact that coverage.py doesn't support xdist as far as I could tell, and pytest-cov did not support manipulating the data after the fact. The intention here is to minimize any changes one might experience in the contributing flow.

Converted this PR to a draft while I figure out why we lost 10% coverage

I figure it's because I've excluded tests from source, hence an overall decrease in coverage. I don't think it makes much sense to have that, since you aren't testing your tests, but I'm willing to hear other's opinions.

I've made another change. I split the test task into two: fast-test and test. test is unchanged, but fast-test has been added to run the tests without coverage, since including coverage can take up 2x the time.
As a sidenote, I now realize the original numbers in the issue are incorrect, as they included coverage for unittests, but not pytest. I've updated the numbers there to reflect that.

Afaik the reason to include the tests themselves in the coverage report is that it becomes easier to find test code that wasn't used, or tests that didn't run, when they probably should have. You may also find yourself patching in a block of code that mocks something and is defined in the tests package; seeing coverage for it may be useful.
I don't know how compelling these arguments are to you, but I remember them from reading Ves' docs on the testing utils they had prepared.

I don't understand the point about files in the tests directory not running. How does a test not run? How does that make it past review? Helpers make more sense, but I don't know if it's a compelling enough reason to add tests as a src.
Regardless, adding them is the path of least resistance, so... fb053e4.

And now the coverage has jumped up 5 percent...
I'll just let it be for tonight.

Why are you passing options to coverage through the command rather than letting it use the .coveragerc file? Does it not support reading from that file?

I removed it when it was no longer needed, and never added it back.
That's been reverted in e2064b4.

Tested and can confirm the branch works on Windows 10 and Linux (ubuntu 20.04. CI also runs ubuntu).

How does a test not run? How does that make it past review?

https://nedbatchelder.com/blog/201908/dont_omit_tests_from_coverage.html
I had a horror story in which pytest-twisted was not installed so most tests were passing without actually scheduling any coroutines or running any assertions


liveIntro event always saying "Kommt auf denn Server drauf!!!"

I had to look it up, but it translates to "It's on the server!!!"
Previously this use to always say what the host has set as the live intro when people join the lives, but recently I noticed it changed to German from a user "Moon-V Official." I briefly looked in the commits but didn't find where this change came into play.
Its only happening when we first connect to the host, when the liveIntro event is fired
{
  "id": {
    "low": -933672160,
    "high":<PHONE_NUMBER>,
    "unsigned": true
  },
  "description": "Kommt auf denn Server drauf!!!",
  "userId": "6802982879527552005",
  "secUid": "<redacted>",
  "nickname": "Moon-V Official",
  "profilePictureUrl": "https://p16-sign-useast2a.tiktokcdn.com/tos-useast2a-avt-0068-euttp/ee8422daed1c7350d0a17382e0d9e7a5~c5_100x100.webp?lk3s=a5d48078&x-expires=1712077200&x-signature=LYVsEHHBVyqwdsdh%2FCWZMWFsKjY%3D",
  "userBadges": [],
  "userSceneTypes": [],
  "userDetails": {
    "createTime": "0",
    "bioDescription": "",
    "profilePictureUrls": [
      "https://p16-sign-useast2a.tiktokcdn.com/tos-useast2a-avt-0068-euttp/ee8422daed1c7350d0a17382e0d9e7a5~c5_100x100.webp?lk3s=a5d48078&x-expires=1712077200&x-signature=LYVsEHHBVyqwdsdh%2FCWZMWFsKjY%3D",
      "https://p16-sign-useast2a.tiktokcdn.com/tos-useast2a-avt-0068-euttp/ee8422daed1c7350d0a17382e0d9e7a5~c5_100x100.jpeg?lk3s=a5d48078&x-expires=1712077200&x-signature=en14eQHTjP2R1nqrzoxpycxVmh8%3D"
    ]
  },
  "isModerator": false,
  "isNewGifter": false,
  "isSubscriber": false,
  "topGifterRank": null,
  "gifterLevel": 0,
  "teamMemberLevel": 0
}

Not happening anymore


Front-end errors are double reported by the VM

Front-end errors from Fasta (e.g., the code in https://github.com/dart-lang/sdk/issues/32871) are double reported when run on the Dart VM.
This does not occur when using the Fasta tool or dart2js, so it seems like an issue in the VM's Fasta API or its use.

This was fixed with cd0c4e4fe1e5b69ac15c0a670f9dde2ee9733fc7 right?
I at least cannot reproduce so I'm closing it for now. Reopen if it's still a problem.


Launch json file is not reloaded untill vscode is relaunched

Node js application where env variables are kept in launch json file
Insert new variable
Rstart application.
Variable does not load into vscode.
Restart vscode
restart application
Works file

/duplicate #102602


✨ Use local dockerfile instead of pre-built image

See https://github.com/ossf/scorecard-action/issues/35, it seems only the docker registry is supported. So instead of finding a way to publish there, let's use a local dockerfile. This PR does just that. It also updates the hash of the scorecard's image to the latest in order to cut a pre-release and start testing.
All in all, this also simplifies the release process for the action. I've updated the release process accordingly in https://github.com/ossf/scorecard-action/issues/33
closes https://github.com/ossf/scorecard-action/issues/35

friendly ping. Any questions?


wrapping around event handler that adds logging

I found this helpful when I was verifying some behavior. I though it might be nice to keep in our toolbox.

Very nice
/lgtm


[bug] TypeError: states is not iterable on z2m logs after upgrading to 5.0.0

Version
Checklist:

[X] I am not using HomeAssistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog problem was not mentioned there.

Build/Run method

[ ] Docker
[ ] PKG
[ ] Snap package
[X] Manually built (git clone - yarn install - yarn run build )

zwavejs2mqtt version: 5.0
zwave-js version: 7.7.3
Describe the bug
Geting errors on z2m logs that I was not getting before on 4.5.2:
`2021-06-11 10:17:44.607 ERROR GATEWAY: Error while discovering value 59-113-0-alarmType of node 59: states is not iterable states is not iterable
at Gateway._getMappedStateTemplate (/home/hass/zwavejs2mqtt/server/lib/Gateway.js:1677:25)
at Gateway.discoverValue (/home/hass/zwavejs2mqtt/server/lib/Gateway.js:1051:34)
at Gateway._onNodeStatus (/home/hass/zwavejs2mqtt/server/lib/Gateway.js:1412:22)
at ZwaveClient.emit (events.js:315:20)
at ZwaveClient.EventEmitter.emit (domain.js:482:12)
at ZwaveClient._onNodeStatus (/home/hass/zwavejs2mqtt/server/lib/ZwaveClient.js:1472:18)
at ZwaveClient._onNodeSleep (/home/hass/zwavejs2mqtt/server/lib/ZwaveClient.js:1579:14)
at ZWaveNode.emit (events.js:327:22)
at ZWaveNode.EventEmitter.emit (domain.js:482:12)
at ZWaveNode.onStatusChange (/home/hass/zwavejs2mqtt/node_modules/zwave-js/src/lib/node/Node.ts:391:9)

2021-06-11 10:17:44.610 ERROR GATEWAY: Error while discovering value 59-113-0-alarmLevel of node 59: states is not iterable states is not iterable
TypeError: states is not iterable
at Gateway._getMappedStateTemplate (/home/hass/zwavejs2mqtt/server/lib/Gateway.js:1677:25)
at Gateway.discoverValue (/home/hass/zwavejs2mqtt/server/lib/Gateway.js:1051:34)
at Gateway._onNodeStatus (/home/hass/zwavejs2mqtt/server/lib/Gateway.js:1412:22)
at ZwaveClient.emit (events.js:315:20)
at ZwaveClient.EventEmitter.emit (domain.js:482:12)
at ZwaveClient._onNodeStatus (/home/hass/zwavejs2mqtt/server/lib/ZwaveClient.js:1472:18)
at ZwaveClient._onNodeSleep (/home/hass/zwavejs2mqtt/server/lib/ZwaveClient.js:1579:14)
at ZWaveNode.emit (events.js:327:22)
at ZWaveNode.EventEmitter.emit (domain.js:482:12)
at ZWaveNode.onStatusChange (/home/hass/zwavejs2mqtt/node_modules/zwave-js/src/lib/node/Node.ts:391:9)`

They look to be happening constantly as I still see them long after z2m is started.
Full dump is attached
dump_11062021.json.txt
To Reproduce
Steps to reproduce the behavior:
I have just updated from 4.5.2 to 5.0.0, on 4.5.2, I wasn't seeing this happening.
Expected behavior
No errors

Instrospecting a bit more of the logs, I can see it is happening with a Yale Lock and a motion sensor always on CC 113 and also only with Alarm Type and Alarm Level.

2021-06-10 22:45:09.879 ERROR GATEWAY: Error while discovering value 59-113-0-alarmType of node 59: states is not iterable states is not iterable
2021-06-10 22:45:09.882 ERROR GATEWAY: Error while discovering value 59-113-0-alarmLevel of node 59: states is not iterable states is not iterable
2021-06-10 22:45:19.924 ERROR GATEWAY: Error while discovering value 17-113-0-alarmType of node 17: states is not iterable states is not iterable
2021-06-10 22:45:19.927 ERROR GATEWAY: Error while discovering value 17-113-0-alarmLevel of node 17: states is not iterable states is not iterable
2021-06-10 22:46:08.975 ERROR GATEWAY: Error while discovering value 59-113-0-alarmType of node 59: states is not iterable states is not iterable
2021-06-10 22:46:08.979 ERROR GATEWAY: Error while discovering value 59-113-0-alarmLevel of node 59: states is not iterable states is not iterable
2021-06-10 22:46:10.128 ERROR GATEWAY: Error while discovering value 59-113-0-alarmType of node 59: states is not iterable states is not iterable
2021-06-10 22:46:10.134 ERROR GATEWAY: Error while discovering value 59-113-0-alarmLevel of node 59: states is not iterable states is not iterable


Index Volumes page, only enabled nodes available when editing a volume.

If you edit an index volume where the node is disabled, the edit popup changes the node to the first available enabled node.
This is likely to cause issues as its pretty easy to miss this change.

Fixed in >b.191


Updates to the kinetis TRNG driver

trng: kinetis: Use statically allocated stack

Change TRNG poller task to use a statically allocated stack; allocating this way uses the same mechanism as other Mynewt standard tasks, and avoids the requirement of a heap.

trng: kinetis: update TRNG to be interrupt driven

When TRNG HW (not RNGA) is present, it can be used in an interrupt driven manner, where interrupts are generated for data available or on errors. With this commit the poller task is updated so it only runs when woken by an interrupt instead of polling constantly to fill in the cache. This fixes issues with task starvation, since the poller task is very high priority and the TRNG is very slow in the standard configuration.
A new syscfg was added to allow faster generation of entropy by changing the value of KINETIS_TRNG_ENTROPY_DELAY.
This commit also refactors the TRNG queue to be simpler and better abstracted.
PS: the commit does not touch the functionality of RNGA based HW (eg K64F) and was tested on both FRDM-K64F and FRDM-K82F.

Strange that we missed local variable in kinetis_trng_start() way back.

We did not, the diff just looks weird, but the variable is in the function above that one.

Strange that we missed local variable in kinetis_trng_start() way back.

We did not, the diff just looks weird, but the variable is in the function above that one.

I meant that code:
static inline void
kinetis_trng_start(void)
{
    struct os_event evt;
...
    evt.ev_queued = 0;
    evt.ev_arg = NULL;
    (void)os_eventq_put(&rng_evtq, &evt);
}

...put evt from stack into the queue rng_evtq and get away with it