Client always disconnects after short time

Hi,
Thanks for writing an awesome python library, it's super useful. I'm having an issue where my client will connect, start sending messages to the server, and then stop sending them, disconnecting after anywhere between 3 and 30 seconds. Consulting google, many people are saying to add ping_interval=None and ping_timeout=None to the websockets.serve function, however doing so does not stop the issue. Are there any other common fixes to this problem? Here's my code.
Thanks!

You're referring to a client but you provided code for a server?

I'm not seeing anything wrong with that code.
I'm aware of the cargo-cult advice of adding ping_interval=None and ping_timeout=None. This is neither useful nor correct in general. It may help only for interacting with buggy implementations, and those are uncommon.
I don't have any other ideas that may help nor actions I could take, so I'm going to close this issue.


smarty3: Init at 3.1.32

Motivation for this change
I'm currently packaging FusionDirectory, and this is a dependency.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Failing check unrelated

@GrahamcOfBorg eval

@GrahamcOfBorg eval

@GrahamcOfBorg  build smarty3

Success on aarch64-linux (full log)
Attempted: smarty3
Partial log (click to expand)
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/39qnyvnax7bv96v3bd8bxa71vl9w3dhr-smarty3-3.1.32
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/39qnyvnax7bv96v3bd8bxa71vl9w3dhr-smarty3-3.1.32
checking for references to /build in /nix/store/39qnyvnax7bv96v3bd8bxa71vl9w3dhr-smarty3-3.1.32...
/nix/store/39qnyvnax7bv96v3bd8bxa71vl9w3dhr-smarty3-3.1.32

Success on x86_64-darwin (full log)
Attempted: smarty3
Partial log (click to expand)
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/n99911yzq799f719mnz9b7hbkszni927-smarty3-3.1.32
/nix/store/n99911yzq799f719mnz9b7hbkszni927-smarty3-3.1.32

Success on x86_64-linux (full log)
Attempted: smarty3
Partial log (click to expand)
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wag04fmf7jk8x57yzi5m67q5wp2zb19l-smarty3-3.1.32
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/wag04fmf7jk8x57yzi5m67q5wp2zb19l-smarty3-3.1.32
checking for references to /build in /nix/store/wag04fmf7jk8x57yzi5m67q5wp2zb19l-smarty3-3.1.32...
/nix/store/wag04fmf7jk8x57yzi5m67q5wp2zb19l-smarty3-3.1.32


Clion popup flickering causing massive CPU spikes

OS: Manjaro Linux x86_64
Kernel: 5.16.0-rc6-230-tkg-cfs
GPU: AMD Radeon Vega 6
Clion Version: 2022.1.3
https://user-images.githubusercontent.com/65631525/179557235-70073a2e-1d2a-4607-881b-4ae8b385a885.mp4

log please

Log right after
[LOG] New XWayland Surface created (class (null)).
[LOG] Registered signal for owner 2aac4970: 2bfc13b8 -> 2aac49d8 (owner: XWayland Window)
[LOG] Registered signal for owner 2aac4970: 2bfc13c8 -> 2aac4a40 (owner: XWayland Window)
[LOG] Registered signal for owner 2aac4970: 2bfc1338 -> 2aac4aa8 (owner: XWayland Window)
[LOG] Searching for matching rules for jetbrains-clion (title: win249)
[LOG] Window got assigned a surfaceTreeNode 0
[LOG] Registered signal for owner 2aac4970: 2bfc1398 -> 2aac4be0 (owner: XWayland Window Late)
[LOG] Registered signal for owner 2aac4970: 2bfc13a8 -> 2aac5070 (owner: XWayland Window Late)
[LOG] Registered signal for owner 2aac4970: 2bfc1348 -> 2aac50d8 (owner: XWayland Window Late)
[LOG] Registered signal for owner 2aac4970: 2bfc13d8 -> 2aac4b10 (owner: XWayland Window Late)
[LOG] Registered signal for owner 2aac4970: 2bfc1478 -> 2aac4b78 (owner: XWayland Window Late)
[LOG] Registered signal for owner 2ab6bb50: 2bfc17f0 -> 2ab6bb58 (owner: SurfaceTreeNode)
[LOG] Registered signal for owner 2ab6bb50: 2bfc17e0 -> 2ab6bbc0 (owner: SurfaceTreeNode)
[LOG] Registered signal for owner 2ab6bb50: 2bfc1800 -> 2ab6bc28 (owner: SurfaceTreeNode)
[LOG] Creating a surfaceTree Root! (pWindow: 2aac4970)
[LOG] Map request dispatched, monitor HDMI-A-1, xywh: 2371.000000 794.000000 302.000000 37.000000
[LOG] Window 2aac4970 unmapped (class jetbrains-clion)
[LOG] Unregistered late callbacks XWL: 2aac4be0 2aac5070 2aac50d8 2aac4b10
[LOG] Callback 1104f00 -> 2aac4970, XWayland Window Late removed.
[LOG] Callback 1104f00 -> 2aac4970, XWayland Window Late removed.
[LOG] Callback 1104f00 -> 2aac4970, XWayland Window Late removed.
[LOG] Callback 1104f00 -> 2aac4970, XWayland Window Late removed.
[LOG] Callback 1104f00 -> 2aac4970, XWayland Window Late removed.
[LOG] Framebuffer created, status 36053
[LOG] Destroying the SubSurface tree of unmapped window 2aac4970
[LOG] Callback 1104e90 -> 2ab6bb50, SurfaceTreeNode removed.
[LOG] Callback 1104e90 -> 2ab6bb50, SurfaceTreeNode removed.
[LOG] Callback 1104e90 -> 2ab6bb50, SurfaceTreeNode removed.
[LOG] SurfaceTree Node removed
[LOG] Window 2aac4970 destroyed, queueing. (class unmanaged X11)
[LOG] XWayland class raw: jetbrains-clion
[LOG] Callback 1104f20 -> 2aac4970, XWayland Window removed.
[LOG] Callback 1104f20 -> 2aac4970, XWayland Window removed.
[LOG] Callback 1104f20 -> 2aac4970, XWayland Window removed.
[LOG] Cleanup: destroyed a window

too little, attach the entire log please

uh huh, no wonder, it spams a window open and close. does it fix itself if you move tha mouse?

A lot of things can happen when I move my mouse.

It closes immediately
It takes a couple seconds to close while still flickering
It closes but CLion freezes completely for a couple seconds. If the freeze is really bad I would have to use killall java and restart CLion again

While the flickering is happening my CPU spikes from around 21% to 80%

oh, it's java, great...

While the flickering is happening my CPU spikes from around 21% to 80%

expected

Not sure if this is relevant but I have the env  _JAVA_AWT_WM_NONREPARENTING=1 which is needed for CLion to even start on wayland and sway. Don't know if that fucks anything up.  https://wiki.archlinux.org/title/Sway#Java_applications.

it shan't

try with d4690a5c5e545877a6704f4376cb4974ad525275

just tested w/Jetbrains Rider and CLion myself, looks to be fixed as i had similar issues as shown in the video before.


Use fast unit tests on PR

What does this PR do?
Migrate our pipeline to use fast unit tests on PR.
It introduces the RUN_UNIT_TESTS variable, that can be set to:

auto: default value that will run only impacted tests on PR
off: completely disable the unit tests, can be useful for pipelines triggered from integrations-core
on : force the execution of all the unit tests

It also introduce a notification mechanism, to alert when a job is run but executed no unit tests.
Requires https://github.com/DataDog/datadog-agent/pull/23333 otherwise we cannot use RUN_UNIT_TESTS: off
For now we do not use fast unit tests on MacOS since we disabled them on PR.

Motivation
Reduce execution time of the unit tests on PR, we do not need to run anything, only what is impacted by the changes
https://docs.google.com/document/d/14yELY-onL5OSPt64SLJjGmIignCIpvifj8qLEAqvI8c/edit#heading=h.1ncu84mu4n6u

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

test

[Fast Unit Test Report]
Warning: On pipeline 123353 the following jobs did not run any unit tests:

toto
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs, if you think tests should have been executed reach out #agent-platform

[Fast Unit Test Report]
Warning: On pipeline 123353 the following jobs did not run any unit tests:

toto

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs, if you think tests should have been executed reach out #agent-platform

[Fast Unit Tests Report]
Warning: On pipeline 1 the following jobs did not run any unit tests:

toto

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs, if you think tests should have been executed reach out #agent-platform

[Fast Unit Tests Report]
Warning: On pipeline 1 the following jobs did not run any unit tests:

toto

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs, if you think tests should have been executed reach out #agent-platform

[Fast Unit Tests Report]
Warning: On pipeline 2 the following jobs did not run any unit tests:

toto

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs, if you think tests should have been executed reach out #agent-platform

/trigger-ci --variable RUN_UNIT_TESTS=off

/trigger-ci --variable RUN_UNIT_TESTS=on

Some NITs

Thanks for the review. Most of the functions were not supposed to be there anymore, I deleted them

/trigger-ci --variable RUN_UNIT_TESTS=on --variable RUN_E2E_TESTS=on

/trigger-ci --variable RUN_UNIT_TESTS=on --variable RUN_E2E_TESTS=on --variable RUN_ALL_BUILDS=true

/trigger-ci --variable RUN_UNIT_TESTS=on --variable RUN_E2E_TESTS=on

/trigger-ci --variable RUN_UNIT_TESTS=on

/merge


Vulnerability roundup 112: archivy-1.4.0: 1 advisory [6.1]

search, files

[ ] CVE-2022-0697 CVSSv3=6.1 (nixos-21.11)

CVE details
CVE-2022-0697
Open Redirect in GitHub repository archivy/archivy prior to 1.7.0.

Scanned versions: nixos-21.11: efea022d6fe.
Cc @siraben

We no longer support nixos-21.11, but this has been fixed in the currently supported NixOS versions:

nixos-22.05: archivy-1.7.2
nixos-unstable: archivy-1.7.3


Update sharepoint-search-rest-api-overview.md

'Refiners'-property in search POST request should be 'string,string', not { results: ['string,string'] }
Category

[x] Content fix
[ ] New article

What's in this Pull Request?
The "Refiners" property expects a comma delimited string of refinable properties, not an array of strings. Fixed code example to reflect that.
See related PnP-JS-Core issue
Guidance

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/sharepoint-search-rest-api-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Kim, sorry for the massive delay. Appreciate the input.


Set monday first column.

Hello!
Can I set in the first column Monday and Sunday set to last?
Thanks!

Nice!
Thanks!


Upgrade to Spring Cloud Finchley M8

Also upgrade to Gradle 4.6

Coverage increased (+0.3%) to 88.396% when pulling 9fa9be84a45733fd03b193496428ba9700b56903 on tgianos:cloudM8 into ce3870ed71e2469335d0652d07b5a1252416ab76 on Netflix:master.


Invalid Declaration of SMARTCARD_EXTENSION.ReaderFunction

Current Declaration is:
NTSTATUS(                 *ReaderFunction[16];
Declaration Should Read:
NTSTATUS (*ReaderFunction[16])(PSMARTCARD_EXTENSION);

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbd9809e-57d5-a8b2-e9ba-78f0e3f9643a
Version Independent ID: 8c83c33c-a0ab-1f14-50eb-c938e56683c3
Content: _SMARTCARD_EXTENSION (smclib.h) - Windows drivers
Content Source: wdk-ddi-src/content/smclib/ns-smclib-_smartcard_extension.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

Working on the fix. Thanks, @dwkaiser

Still waiting for the build team to fix the tool that generates the syntax block. In the meantime, I added the info manually to the member description.
Sorry for the delay.
Eliot


Move uglifycss to dev dependencies

Prevents installing it if not needed

Thanks @zakjan - This was my stupidity


Right-click on File Explorer on Windows system to launch, the new environment variable is invalid

Windows Terminal version
No response
Windows build number
No response
Other Software
Windows 11
Steps to reproduce
Create a new environment variable, right-click in file explorer on windows system to start Windows Terminal, try to execute the environment variable, but it is not valid.
Expected Behavior
No response
Actual Behavior
Right-click to start Windows Terminal in File Explorer on Windows systems, and the new environment variable is invalid, and the other way I know it works. After the computer restarts, file explorer right-clicks to start Windows Terminal.

Was another Terminal already running when you tried to launch the terminal that ultimately didn't have the new environment variable? I'm betting we bounced through the old instance, which didn't have the env var, and lost the updated value.
I think this'll ultimately be fixed by #1125...


A page which list all categories

This PR add a page, accessible for all type of users, which list all the categories. As i don't really know what you expected this is a very minimal stuff, for example the view is basically a part of the categories view from admin_views.ml. I also create a catefory_views.ml file, and i move the Category module in it.
I'm looking forward your thoughts and suggestions !
Screenshots of the page :
For an admin user

For the others type of users :

Ping @gr-im
Thanks!

Hi, sorry for the huge delay (I'll try to be more diligent in the future).
I removed the submodule and i've hidden the functions which aren't used outside of category_views. I upgraded the view of the category page, now we see the number of topics associated to their categories, if a category doesn't have any topic, i do not display it.
The numbers are clickable, if i click on the number of topics of a category C, it redirects to topic/by/category:C
I'm looking forward your thoughts and suggestions (even nitpicking ones, i'm a noob).

Thanks a lot!


Fixes Interaction Sources not properly being registered at startup in some cases

Added delayed initialization in OnEnable to wait until Start in case the InputManager instance isn't ready.

@keveleigh is this closer to what you were talking about?

Much closer! It still ties InitializeSources() to the state of InputManager though. If InputManager's Awake gets called before this scipt, this will still result in other scripts potentially getting a SourceDetected before their Awake has been called. Setting delayInitialization to true initially and changing it to false in Start (while leaving everything else the same) would fix that.

Also, my comment on the other PR about

It's also possible doing this at the beginning of an app might have the InputManager fire two SourceDetected events.

is wrong. The Toolkit's InputManager keeps its own reference of detected sources and takes that into account!

@LocalJoost I'd also like your input if you don't mind. Just want to confirm this also fixes the issue you're running into.

Just came back home. It's evening here. Tomorrow I will have a look. Like I said I have wasted quite some time already because on this issue.
Joost van Schaik
Windows Development MVP
"The world as I envision it in my head is such a more interesting place"

From: Stephen Hodgson<EMAIL_ADDRESS>Sent: Oct 28, 2017 9:58 PM
To: Microsoft/MixedRealityToolkit-Unity
Cc: Joost van Schaik; Mention
Subject: Re: [Microsoft/MixedRealityToolkit-Unity] Fixes Interaction Sources not properly being registered at startup in some cases (#1255)
@LocalJoosthttps://github.com/localjoost I'd also like your input if you don't mind. Just want to confirm this also fixes the issue you're running into.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1255#issuecomment-340215987, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8Bn-zIK3WRxVsVX8W-Y9Z0R-RiEaSPks5sw4dggaJpZM4QKEHb.

Tried in my app, seems to work for me as well. @keveleigh Sorry for the somewhat annoyed reaction, I get that when a bug took so much time. I also was wondering 'who the hell is this guy anyway' - well, someone from Microsoft, not just Joe Random Contributor ;)


pipenv --rm requires a Pipfile

I want to remove a virtualenv created by pipenv, but pipenv --rm says there isn't one unless a Pipfile is present.
Expected result
The virtualenv is found and removed.
Actual result
I get an error saying there is no virtualenv.
Steps to replicate
Setup:
dtucker@dtucker-wkstn:/tmp $ pipenv shell
Creating a virtualenv for this project...
Pipfile: /tmp/Pipfile
Using /usr/bin/python3 (3.5.3) to create virtualenv...
⠋Already using interpreter /usr/bin/python3
Using base prefix '/usr'
New python executable in /home/dtucker/.local/share/virtualenvs/tmp-XVr6zr33/bin/python3
Also creating executable in /home/dtucker/.local/share/virtualenvs/tmp-XVr6zr33/bin/python
Installing setuptools, pip, wheel...done.
Setting project for tmp-XVr6zr33 to /tmp

Virtualenv location: /home/dtucker/.local/share/virtualenvs/tmp-XVr6zr33
Creating a Pipfile for this project...
Launching subshell in virtual environment…
 . /home/dtucker/.local/share/virtualenvs/tmp-XVr6zr33/bin/activate
dtucker@dtucker-wkstn:/tmp $  . /home/dtucker/.local/share/virtualenvs/tmp-XVr6zr33/bin/activate
(tmp-XVr6zr33) dtucker@dtucker-wkstn:/tmp $ exit

Reproduce:
dtucker@dtucker-wkstn:/tmp $ rm Pipfile
dtucker@dtucker-wkstn:/tmp $ pipenv --rm
No virtualenv has been created for this project yet!

Workaround:
dtucker@dtucker-wkstn:/tmp $ touch Pipfile
dtucker@dtucker-wkstn:/tmp $ pipenv --rm
Removing virtualenv (/home/dtucker/.local/share/virtualenvs/tmp-XVr6zr33)...
dtucker@dtucker-wkstn:/tmp $ rm Pipfile

Did some investigation on this and I think the virtualenv is currently coupled with the Pipfile via the virtualenv_exists() method.

Pipenv only knows there is a project it is associated with because of the presence of a Pipfile. For more advanced virtualenv management, check out https://github.com/gtalarico/pipenv-pipes

Bummer... It would be nice if there was a way to get the convenience of pipenv shell without having to have a project or anything to clean up. Maybe something like pipenv shell --no-project could work?
I'm guessing the issue is that Pipenv may not be the only tool to create virtualenvs in ~/.local/share/virtualenvs/? Seems like that wouldn't be an issue if, for example, ~/.local/share/pipenv/virtualenvs/ were used instead.
"Use a separate tool" doesn't seem much different than saying "just use virtualenv and pip"

@dmtucker running pipenv shell with no project would be the same as creating a virtualenv yourself. Many tools exist and handle this precise functionality; pipenv doesn't seek to be the end all be all of flexible virtual environment creation.  Quite the opposite in fact -- pipenv precisely attempts to reduce the number of options and decisions involved in creating a virtual environment and managing its dependencies in the context of a project.
Pipenv is designed to create reproducible environments.  If you want a throwaway virtualenv to activate and do random things with, but you don't want it to be stateful, and you don't want a project, consider that I am telling you this is not what pipenv is meant for and that you should be using another tool.  I don't really have an opinion about whether you should use virtualenv directly or virtualenvwrapper or some other helper (I use https://github.com/adambrenecki/virtualfish personally to manage this exact use case).  So yes, if you want to do things that are unrelated to pipenv, you should consider alternative options.
As for your guess at what the issue is surrounding this, or your resistance to installing additional tooling in the pipenv ecosystem, I'm not really sure how to answer that.  Pipenv isn't built for what you are trying to do.  This is not a bug and it's not a simple failure to consider where we are putting environments


add info in README.md

Add information to README.md for the issue creation process

code add in branch

pull request in main


replace a number of deprecated methods

Most;y by adding explicit charsets, except in the cases where the omission of a charset was what was being tested

Codecov Report

Merging #495 (ee5c9db) into master (43594ce) will decrease coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
- Coverage     84.97%   84.92%   -0.05%
+ Complexity     3372     3370       -2
============================================
  Files           227      227
  Lines          8080     8080
  Branches        953      953
============================================
- Hits           6866     6862       -4
- Misses          960      964       +4
  Partials        254      254

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

-1: We have to test ALL the code we provide. Also, notice this PR decreases the code coverage percentage:
@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
- Coverage     84.97%   84.92%   -0.05%
+ Complexity     3372     3370       -2
============================================
  Files           227      227
  Lines          8080     8080
  Branches        953      953
============================================
- Hits           6866     6862       -4
- Misses          960      964       +4
  Partials        254      254

I think in all cases here each method still tests what it tested before. Only setup and verification code has been rewritten to use non-deprecated methods and to be more platform independent. There were a couple places I left unchanged precisely because they test deprecated method. If I missed one of those, point to it and I'll fix it.
Code coverage numbers are not accurate to three significant figures.

We need to keep the code as is to show it work on Java 18 and up where the default encoding is UTF-8. We should consider undeprecating these methods on Java 18 and up.

That would be nice. Unfortunately, "An implementation may override the default charset with the system property file.encoding on the command line. If the value is COMPAT, the default charset is derived from the native.encoding system property, which typically depends upon the locale and charset of the underlying operating system." so we're going to need to specify charsets for the next 25 years. :-(
We might end up setting up separate JDK 21 CIs, one with UTF-8 and one with something weird like Cp936, to flush out the issues.

We might end up setting up separate JDK 21 CIs, one with UTF-8 and one with something weird like Cp936, to flush out the issues.

That sounds good (and interesting) but this PR should be closed.

I need to take another look at this, but I'm not convinced the existing tests are correct or testing what they think they're testing.

Closing: See above.


Not working on my T9 AIVI PLUS

I installed the plugin successfully and can see all the switches and fan. On the log I could see my Ecovacs T9 AIVI PLus is found at discovery with the correct ID (E0541xxxxxx). However, when I tried to play with the switches and fan in my Home app, the T9 would not respond at all except for the Bip switch. When I turned this sound stateless switch, I would hear a sound from my T9 so I guess the communication between the home app and the T9 should be OK, as well as my configuration. Please update the plugin so it works with the latest model of Ecovacs Deebot T9. Thank you

Hi,
please post full logs in debug mode . Don't know if this model is fully supported by the lib, have to check.

Thank you for your quick response. I got this in the journalctl log of my homebridge instance
[DeebotEcovacs] INFO - stopping deebots discovery, number of deebots found : 1
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Discovered Deebot : E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Edge Cleaning for E05414875C09HHXD0292 : true
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Spot Cleaning for E05414875C09HHXD0292 : true
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - SpotArea Cleaning for E05414875C09HHXD0292 : false
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - CustomArea Cleaning for E05414875C09HHXD0292 : false
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Battery Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Fan Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Main Switch Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Sound stateless Switch Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Motion Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Auto stateless Switch Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Edge stateless Switch Service for E05414875C09HHXD0292
Jun 09 00:01:17 raspberrypi homebridge[15142]: [09/06/2021, 00:01:17] [DeebotEcovacs] INFO - Creating Spot stateless Switch Service for E05414875C09HHXD0292
how can I run in debug mode? thank you

see homebridge doc and activate debug mode : DEBUG=*

This is what I get when I turn on the "Fan" service
Jun 09 01:17:47 raspberrypi homebridge[2215]: 2021-06-08T18:17:47.453Z HAP-NodeJS:EventedHTTPServer:Connection [::ffff:<IP_ADDRESS>] HTTP request: /characteristics
Jun 09 01:17:47 raspberrypi homebridge[2215]: 2021-06-08T18:17:47.453Z HAP-NodeJS:HAPServer [CD:22:3D:E4:CE:36] HAP Request: PUT /characteristics
Jun 09 01:17:47 raspberrypi homebridge[2215]: 2021-06-08T18:17:47.454Z HAP-NodeJS:Accessory [Homebridge-roomba AB63] Processing characteristic set: {"characteristics":[{"aid":12,"iid":15,"value":1}]}
Jun 09 01:17:47 raspberrypi homebridge[2215]: 2021-06-08T18:17:47.462Z HAP-NodeJS:EventedHTTPServer [::ffff:<IP_ADDRESS>] Muting event '12.15' notification for this connection since it originated here.

Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.075Z mqttjs:client _checkPing :: ping response received.
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.337Z mqtt-packet:parser _newPacket: new packet
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.337Z mqtt-packet:parser parse: state complete. _stateCounter is now: 4
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.337Z mqtt-packet:parser parse: packet.length: -1, buffer list length: 0
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.337Z mqtt-packet:parser parse: exited while loop. packet: -1, buffer list length: 0
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.338Z mqttjs:client work :: getting next packet in queue
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.338Z mqttjs:client work :: packet pulled from queue
Jun 09 01:17:48 raspberrypi homebridge[2215]: 2021-06-08T18:17:48.338Z mqttjs:client _handlePacket :: emitting packetreceive

Let me clarify that my T9 setup is not in the same local wifi network with my Pi3 on which I installed the this  plugin (I put my T9 in office while my Pi is at home). Anyway, the bip switch just works fine. The rest are not working, including the battery service.

@huongminh
I only need the follwing line with the class value from the normal log:
[15.5.2021, 18:37:02] [DeebotEcovacs] INFO - getDeebots : [{...,"class":"b2jqs4",...}}]

Should be something like b2jqs4

Let me clarify that my T9 setup is not in the same local wifi network with my Pi3 on which I installed the this plugin (I put my T9 in office while my Pi is at home). Anyway, the bip switch just works fine. The rest are not working, including the battery service.

The Deebot does not necessarily have to be in the same local wifi network.

Sorry I only find these:
[09/06/2021, 01:26:25] [DeebotEcovacs] INFO - stopping deebots discovery, number of deebots found : 1
Jun 09 01:26:25 raspberrypi homebridge[6383]: [09/06/2021, 01:26:25] [DeebotEcovacs] INFO - Discovered Deebot : E05414875C09HHXD0292
Jun 09 01:26:25 raspberrypi homebridge[6383]: [09/06/2021, 01:26:25] [DeebotEcovacs] INFO - Edge Cleaning for E05414875C09HHXD0292 : true
Jun 09 01:26:25 raspberrypi homebridge[6383]: [09/06/2021, 01:26:25] [DeebotEcovacs] INFO - Spot Cleaning for E05414875C09HHXD0292 : true
Jun 09 01:26:25 raspberrypi homebridge[6383]: [09/06/2021, 01:26:25] [DeebotEcovacs] INFO - SpotArea Cleaning for E05414875C09HHXD0292 : false
Jun 09 01:26:25 raspberrypi homebridge[6383]: [09/06/2021, 01:26:25] [DeebotEcovacs] INFO - CustomArea Cleaning for E05414875C09HHXD0292 : false

@huongminh
Please check the line above this one:
[09/06/2021, 01:26:25] [DeebotEcovacs] INFO - stopping deebots discovery, number of deebots found : 1

Here you go, I post some line above and under:
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.394Z mqtt-packet:writeToStream writeNumberCached: <Buffer 00 04>
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.394Z mqtt-packet:writeToStream writeString: MQTT
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.395Z mqtt-packet:writeToStream writeNumberCached: number: 60
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.395Z mqtt-packet:writeToStream writeNumberCached: <Buffer 00 3c>
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.395Z mqtt-packet:writeToStream writeNumberCached: number: 33
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.396Z mqtt-packet:writeToStream writeNumberCached: <Buffer 00 21>
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.396Z mqtt-packet:writeToStream writeString: fffmzhk0d83f8bb5@ecouser/5f033c97
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.397Z mqtt-packet:writeToStream writeNumberCached: number: 24
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.397Z mqtt-packet:writeToStream writeNumberCached: <Buffer 00 18>
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.397Z mqtt-packet:writeToStream writeString: fffmzhk0d83f8bb5@ecouser
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.398Z mqtt-packet:writeToStream writeNumberCached: number: 198
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.398Z mqtt-packet:writeToStream writeNumberCached: <Buffer 00 c6>
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.398Z mqtt-packet:writeToStream writeString: V_2_eyJjIjoiNjA3OTA2OTExMmUyZTlhMmFkOWMxZDMyIiwidSI6ImZmZm16aGswZDgzZjhiYjUiLCJyIjoiNWYwMzNjOTciLCJ0IjoiYSIsImlhdCI6MTYyMzE3NzM1NSwiZXhwIjoxNjIzNzgyMTU1fQ.CNHJS1oLFKoadfpdTNY2jLwL41pjDvCBq7p9tgUHimg
Jun 09 01:35:57 raspberrypi homebridge[9140]: 2021-06-08T18:35:57.399Z mqttjs:client sendPacket :: writeToStream result true
Jun 09 01:35:57 raspberrypi homebridge[9140]: [09/06/2021, 01:35:57] [DeebotEcovacs] INFO - stopping deebots discovery, number of deebots found : 1
Jun 09 01:35:57 raspberrypi homebridge[9140]: [09/06/2021, 01:35:57] [DeebotEcovacs] INFO - Discovered Deebot : E05414875C09HHXD0292
Jun 09 01:35:57 raspberrypi homebridge[9140]: [09/06/2021, 01:35:57] [DeebotEcovacs] INFO - Edge Cleaning for E05414875C09HHXD0292 : true
Jun 09 01:35:57 raspberrypi homebridge[9140]: [09/06/2021, 01:35:57] [DeebotEcovacs] INFO - Spot Cleaning for E05414875C09HHXD0292 : true
Jun 09 01:35:57 raspberrypi homebridge[9140]: [09/06/2021, 01:35:57] [DeebotEcovacs] INFO - SpotArea Cleaning for E05414875C09HHXD0292 : false
Jun 09 01:35:57 raspberrypi homebridge[9140]: [09/06/2021, 01:35:57] [DeebotEcovacs] INFO - CustomArea Cleaning for E05414875C09HHXD0292 : false
Jun 09 01:35:58 raspberrypi homebridge[9140]: 2021-06-08T18:35:58.490Z mqttjs:client writable stream :: parsing buffer
Jun 09 01:35:58 raspberrypi homebridge[9140]: 2021-06-08T18:35:58.492Z mqtt-packet:parser parse: current state: _parseHeader
Jun 09 01:35:58 raspberrypi homebridge[9140]: 2021-06-08T18:35:58.500Z mqtt-packet:parser _parseHeader: packet: Packet { cmd: 'connack', retain: false, qos: 0, dup: false, length: -1, topic: null, payload: null }
Jun 09 01:35:58 raspberrypi homebridge[9140]: 2021-06-08T18:35:58.501Z mqtt-packet:parser parse: state complete. _stateCounter is now: 1
Jun 09 01:35:58 raspberrypi homebridge[9140]: 2021-06-08T18:35:58.502Z mqtt-packet:parser parse: packet.length: -1, buffer list length: 0
Jun 09 01:35:58 raspberrypi homebridge[9140]: 2021-06-08T18:35:58.502Z mqtt-packet:parser parse: exited while loop. packet: -1, buffer list length: 0
Jun 09 01:35:58 raspberrypi h

@huongminh
You have to enable debug Mode in Homebridge settings first:

Startup Options

Homebridge Debug Mode -D

@nicoduj
Why there's INFO in the output of debug log level?
[15.5.2021, 18:37:02] [DeebotEcovacs] INFO - getDeebots : [{...,"class":"b2jqs4",...}}]

I did here as per your request and I could see more logs as I posted:
pi@raspberrypi:/etc/default $ cat homebridge-roomba
Defaults / Configuration options for homebridge
The following settings tells homebridge where to find the config.json file and where to persist the data (i.e. pairing and others)
HOMEBRIDGE_OPTS= -U /var/homebridge-roomba -P /var/homebridge-roomba/node_modules
If you uncomment the following line, homebridge will log more
You can display this via systemd's journalctl: journalctl -f -u homebridge
DEBUG=*

I uncommented the DEBUG=*

I did here as per your request and I could see more logs as I posted:
pi@raspberrypi:/etc/default $ cat homebridge-roomba

This was not my request 😉

Sorry. As I understand I find the Debug=* in that config file for my homebridge service. Pls tell me how I should do the get more logs

Sorry. As I understand I find the Debug=* in that config file for my homebridge service. Pls tell me how I should do the get more logs

https://github.com/nicoduj/homebridge-deebotEcovacs/issues/71#issuecomment-857003193

I , can't check but try this option in config : showInfoLogs to true

Finally I got it. Thank you for your patience. I had to put a -D in the homebridge execution
[09/06/2021, 01:53:44] [DeebotEcovacs] INFO - connected
Jun 09 01:53:45 raspberrypi homebridge[14317]: [09/06/2021, 01:53:45] [DeebotEcovacs] INFO - getDeebots : [{"did":"cb1059e7-ad32-48bb-ae6b-96160793f385","name":"E05414875C09HHXD0292","class":"kw9ayx","resource":"vJ7R","nick":null,"company":"eco-ng","bindTs":1622907128356,"service":{"jmq":"jmq-ngiot-cn.dc.cn.ecouser.net","mqs":"api-ngiot.dc-cn.cn.ecouser.net"}}]


Add i18n/zh_tw translation

Thanks for translating. In the future, it would probably be easier to use the CrowdIn site (https://crowdin.com/project/carpetskyadditions) to translate.


Add support for http/type/enum/extensible

Fixes https://github.com/microsoft/typespec/issues/3996

API change check
API changes are not detected in this pull request.


Additional Description: the latest QUICHE commit depends on broingSSL commit: https://boringssl.googlesource.com/boringssl/+/3d8b8c3df27cc780a49607be6a27f2c518f5c082 which is in chrome dev channel.
Risk Level: low
Testing: existing tests passed

/assign @wu-bin @alyssawilk

/lgtm deps

/retest

/retest

@envoyproxy/dependency-shepherds

/lgtm deps

The deps look OK from a deps hygiene point of view but copying TLS codeowners @lizan @asraa @ggreenway as this is a little unusual as it is pulling in a BoringSSL version from Chrome dev channel vs. the normal stable channel. /cc @htuch

@danzh1989 can you comment on:

this is a little unusual as it is pulling in a BoringSSL version from Chrome dev channel vs. the normal stable channel.

?

@danzh1989 can you comment on:

this is a little unusual as it is pulling in a BoringSSL version from Chrome dev channel vs. the normal stable channel.

?

As noted in PR description the latest QUICHE depends on a new TLS interface from commit https://boringssl.googlesource.com/boringssl/+/3d8b8c3df27cc780a49607be6a27f2c518f5c082. This commit is not in chrome stable yet. We had similar issue before and discussed with @PiotrSikora that in such case bump the boring SSL version is fine.

Sure, trying to help @moderation here with understanding the implications of working on the linux/dev branch. What are the properties that differ from stable? Do we lose any security coverage etc?

Sure, trying to help @moderation here with understanding the implications of working on the linux/dev branch. What are the properties that differ from stable? Do we lose any security coverage etc?

AFAIK, chrome dev channel is used by a smaller percentage of users for a shorter period. These two channels differ in terms of robustness.  But in terms of security, dev channel also went through release and security review. @PiotrSikora may be able to comment more about security aspect.

If we have concerns about the boringssl pull @davidben could probably address as well.

Review-wise, BoringSSL CLs are reviewed before check-in. We do generally aim for HEAD to be usable at any point and generally track HEAD in most of our repositories. "Live at HEAD" and all that. The repositories aren't updated continuously (weekly, biweekly, monthly, etc.), but this is less out of stability and more the time to assemble the update, run everyone's tests, etc. Mistakes may happen, but unit tests and each projects' release cycles tend to work well to catch this stuff.

/lgtm deps
Thanks for the explanations @danzh1989 and @davidben


WIP: Added a chart for elastic cloud on k8s

[ ] Chart version not bumped (the versions are all bumped and released at the same time)
[ ] README.md updated with any new values or changes
[ ] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Hey @LaurentGoderre!
Thanks for working on this. I see you already found the relevant issue in https://github.com/elastic/cloud-on-k8s/issues/938 for this feature request. The reason that we kept that issue open is that we decided that it would make more sense to keep the helm-chart for cloud-on-k8s in that cloud-on-k8s repo itself. The main reason for this being that cloud-on-k8s does not follow the same stack versioning that this project does which would make them very difficult to manage together. Could you open this up in the cloud-on-k8s repo and engage with the maintainers there to see if they are ready to start supporting this?

Alternate PR: https://github.com/elastic/cloud-on-k8s/pull/1906


Use new path for fluent-package

No need to use old path for fluent-package.

Need to rebase with #499

failure on focal and jammy. checking....

It sometimes fails in other PRs as well. (#501)
Is it possible that https://github.com/fluent/fluent-package-builder/pull/489#issuecomment-1587075397 problem still remains?

Is it possible that #489 (comment) problem still remains?

There is a possibility of it. checking...

Try to run the failed job again.

I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet)
maybe waiting appropriate time will work. :thinking:

I'm doubt that this fragile behavior comes from running systemctl immediately. (The state of current status is not synced yet) maybe waiting appropriate time will work. thinking

I wonder if this is the real cause of this problem.
I have tested the following 2 patterns on my local.

Add sleep 3 before systemctl status check like this PR.
Add --wait option to systemctl status check.

However, both patterns fail about 1 in 3 times.
It may be a good idea to add sleep or --wait option just in case, but perhaps it has nothing to do with this problem.

However, both patterns fail about 1 in 3 times.

Thank you for checking.
I'll investigate it again.
Anyway, using --wait option is better, I'll fix it.

changed to use --wait option to sync.


StartCommandLineBuild with -BuildTarget WSAPlayer ignores other command-line options and requires building an appx

Overview
I'd like to use StartCommandLineBuild in order to create automated builds of my MRTKv2 project. However, I just want it to run the Unity project to generate a Visual Studio solution. The rest of my build system will take it from there and build the .appx.
Unfortunately, if your platform is set to UWP, it looks like this code in StartCommandLineBuild will build an .appx for you regardless of the command-line options you have passed. What is the purpose of this special case for UWP, and why isn't the default case's behavior of parsing the command line options used?
Steps to reproduce
Build MRTKv2 by running the Unity editor with -BatchMode -ExecuteMethod "Microsoft.MixedReality.Toolkit.Core.Utilities.Build.UnityPlayerBuildTools.StartCommandLineBuild" -BuildTarget WSAPlayer
Actual Behavior
Builds the Unity project AND builds the appx.
Expected Behavior
Builds the Unity project WITHOUT building the appx. The expected result would be similar to when you click the "Build Unity Project" button in the Build Window.
It doesn't look like it is currently possible to just build the Unity project with the WSAPlayer target.
Personally, I'd prefer this to be the default with a -buildAppx command line option for those who want to create an appx. Thus, the switch statement could be removed and everything would go through what is currently the default case with an explicit command line option used to control whether the appx is built. Alternatively, if folks feel that building the appx should be the default then we'd need to add a -dontBuildAppx switch, which I think is a more confusing option.
Unity Editor Version
2017.3.7f1
Mixed Reality Toolkit Release Version
mrtk_development

@StephenHodgson, FYI.
Do you know why -BuildTarget WSAPlayer and BuildAppx = true are tied together in this way?

Yup that was how I had designed it.
What's the purpose for the extra build step?

#3785

This was fixed by #3785. Thanks @MenelvagorMilsom!


Exception after a split second

After selecting a mesh with all the shapekeys and starting the OSC server, it successfully receives a few frames of face tracking data from VRCFT. Then the addon quickly runs into this exception which causes it to stop:
Exception in thread Thread-19 (recv_and_process):
Traceback (most recent call last):
  File "C:\Program Files (x86)\Steam\steamapps\common\Blender\3.6\python\lib\threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "C:\Program Files (x86)\Steam\steamapps\common\Blender\3.6\python\lib\threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\Jacob\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\VRCFT OSC Receiver\osc_server.py", line 63, in recv_and_process
    process_osc_message(address, osc_data, standard)
  File "C:\Users\Jacob\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\VRCFT OSC Receiver\osc_server.py", line 43, in process_osc_message
    shape_key.value = osc_data
AttributeError: Writing to ID classes in this context is not allowed: Key.001, Key datablock, error setting ShapeKey.value

I tried 3 different models and the same thing happens, but "Key.001" in the exception may be "Key".

FIxed in latest


Create a script to extract metadata on each iRacing endpoints and save it in a formatted markdown file

Objective:
Create a script that extracts the iRacing endpoint parameters and save it in a formatted markdown file.
You can find all the metadata in this json file: api.json
Acceptance Criteria:

[ ] One md file for all the methods and arguments
[ ] The python script itself does not need to be In the package, just the formatted md files
[ ] Save the file under ./docs as methods.md

The format of the markdown:
### car.assets

image paths are relative to https://images-static.iracing.com/

link:`https://members-ng.iracing.com/data/car/assets`

---

### car.get

link: `https://members-ng.iracing.com/data/car/get`

---

### carclass.get

link: `https://members-ng.iracing.com/data/carclass/get`

---

### hosted.combined_sessions

Sessions that can be joined as a driver or spectator, and also includes non-league pending sessions for the user.

| Argument   | Data Type | Description                                                      | Required |
|------------|-----------|------------------------------------------------------------------|----------|
| package_id | number    | If set, return only sessions using this car or track package ID. | False    |

link: `https://members-ng.iracing.com/data/hosted/combined_sessions`

Some useful tips:

use .get() to extract keys from a dictionary
Some notes can be lists
you might need to look for a md library to simplify writing down markdown formatted files and build md tables
This script does not need to follow best practices since its a one time used script

API Reference
car.assets()
  GET https://members-ng.iracing.com/data/car/assets

hosted.combined_sessions()
Note on this API endpoints, insert here
https://members-ng.iracing.com/data/hosted/combined_sessions

Parameter
Type
Description
Required

package_id
number
If set, return only sessions using this car or track package ID.
False

Pull request to merge methods.md file to repo source
You can check out a the code + MD file here

Key changes:

Add H2 subtitle for each apigroup
Create --- dividers after each api group instead of each endpoints
Endpoints with no notes, add a No description
Wrap the API link with http block code

Example

iRacing Garage
A brief description of what this project does and who it's for - TO BE ADDED
Car
car.assets()
Image paths are relative to https://images-static.iracing.com/
https://members-ng.iracing.com/data/car/assets

car.get()
No descrpition.
https://members-ng.iracing.com/data/car/get

Carclass
carclass.get()
No descrpition.
https://members-ng.iracing.com/data/carclass/get

Constants
constants.categories()
Constant; returned directly as an array of objects
https://members-ng.iracing.com/data/constants/categories

constants.divisions()
Constant; returned directly as an array of objects
https://members-ng.iracing.com/data/constants/divisions

constants.event_types()
Constant; returned directly as an array of objects
https://members-ng.iracing.com/data/constants/event_types

Hosted
hosted.combined_sessions()
Sessions that can be joined as a driver or spectator, and also includes non-league pending sessions for the user.

Parameter
Type
Description
Required

package_id
number
If set, return only sessions using this car or track package ID.
False

https://members-ng.iracing.com/data/hosted/combined_sessions

Review the changed made here  and if good, approve pull.
Also added the python script that converted the JSON file to Markdown.
@dangkv


Removed exposing NexusParser class in init for faster importing

This can be merged once Nomad has included the following merge request: https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/710

This is ready to be merged.

LGTM


GKE Stack Driver Trace Reporting By Cluster By Environment By Service By Service Version

I have created a question on stackoverflow tagging spring-cloud-gcp but I didn't got any reply, so that's why re-posting it here again.
https://stackoverflow.com/questions/55320822/gke-stack-driver-trace-reporting-by-cluster-by-environment-by-service-by-service
We have multiple spring boot apps running on top of GKE and for spring boot applications am using spring-cloud-gcp-starter-trace to log traces to stack driver so that I can debug those traces via the stack driver UI.
Am not able to figure out how to add labels like service_name, service_version and cluster_name so that I can filter out only those traces for reporting purposes because right now we have istio configured on one cluster and even with one percent sampling rate it's generating tons of telemetry data and with UN-availability of filters or am missing some configuration, the trace UI has almost become useless for me
I had a look at the documentation for spring-cloud-gcp-starter-trace, they don't have any properties through which I can set these fields/tags.
Does spring-cloud-gcp-tracing library and stack driver tracing service support adding such tags and if yes, what are the touch points where I should add these tags and what are the list of valid tags applicable for GKE environment
Some references on what am talking about:
https://github.com/googleapis/cloud-trace-nodejs/issues/455
https://github.com/googleapis/cloud-trace-nodejs/issues/306
Can some one please let me know how can I achieve this.

I just now went through the documentation and found this property to set the name of the service.
Similarly, am expecting few of other tags to be associated with these traces and stack driver tracing UI should honor these tags i.e allow me to filter the data based on these tags
Already Present:
spring.zipkin.service.name: foo
Expected Tags:
spring.zipkin.service.environment: prod/dev/qa
spring.zipkin.service.version: v1/v2/v3

Hi @rajivml. Thanks for the question. We will look into it shortly. Currently, we're blocked due to another issue with Trace. #1608
cc/ @saturnism

@rajivml You can add custom tags using the brave.SpanCustomizer. Just autowire it in as the bean already exists in the application context.
You can then add tags, like this:
@Autowired
SpanCustomizer spanCustomizer;

...

spanCustomizer.tag("my-tag", "my tag value");

These will turn into labels on you traces in Stackdriver Trace, on which you can search.

@meltsufin thanks for looking into this.
may be a very novice question, right now I don't have any custom code written for generating the traces am using out of box functionalities provided by spring-cloud-gcp library. So, what are the touch points where this change has to be done, can you point to an example in case if any?

The Filter based approach isn't working, will try hardcoding at each API end point and see if it's working
nField customizer in com.uipath.ml.controller.RequestHeaderFilter required a bean of type \u0027brave.SpanCustomizer\u0027 that c ould not be found.\r\n\r\nThe injection point has the following annotations:\r\n\t- @org.springframework.beans.factory.annotation.Autowired(required\u003dtrue)\r\n\r\n\r\nAction:\r\n\r\nConsider defining a bean  of type \u0027brave.SpanCustomizer\u0027 in your configuration.\r\n","context":"default"}
--

@rajivml I'm a little confused about the problem you're facing. Do you have multiple SpanCustomizer beans in the application context? Or, are you unable to add new beans to the application context?
Using the Spring MVC interceptors seems appropriate. I added it to our Trace example. See: #1619.

Thank you very much @meltsufin . I have just now tested it and it's working fine and I can see the tags in stackdriver trace UI.
You can resolve the issue. Appreciate the support !!

I'm glad it worked for you! Thanks for the update.


Documentation: sap.m.p13n.Engine and its helper classes documentation is inconsistent and unclear

OpenUI5 version: 1.120.0
TS Types: 1.120.0
There are a lot of inconsistencies from typescript and API perspective when using sap.m.p13n.Engine.

Let's start from looking into samples from UI5:

sap.m.p13n.Engine.getInstance doesn't exist in the documentation and types.

MetadataHelper doesn't receive any parameters according to types and documentation

But it does in the code and the UI5 Sample:

SelectionController and the rest of the controller constructor according to types and documentation should receive id first and only then the settings, however, the sample and actual library code is different
Sample code from UI5:

Constructor from TS:

Constructor from documentation:

Constructor in the library itself:

Event handlers doesn't have proper types defined:

Long story short, all p13n Engine topic is unusable from TS perspective.

Additionally it is totally unclear how can I control the state of the Engine:

How can I provide the list of already visible columns (or maybe already used sorters)? Doesn't seem that something can be passed to SelectionController, Engine instance doesn't seem to have anything for that as well, except applyState method which is experimental.
What can be passed to Engine -> show method?

Where did "Columns" and "Sorter" come from? According to documentation they are the keys, but there is no information if those keys are something which is predefined, or maybe I should define them by myself. If they are predefined, what are the values? If they are not, where should I specify them?

Absence of answers on those questions makes usage of the Engine tricky.

My current task is to implement column visibility personalization for Grid Table and we are using version 1.108.*. There are 4 options to do it:

Using standard showColumnVisibilityMenu for Grid Table, but it is deprecated since 1.117, so it makes no sense to use it.
Using p13n Engine, but it is totally broken for TS
Implementing totally custom Menu with reimplementation of standard menu items, which is recommended by documentation. Funny recommendation if you ask me :)
Making totally custom p13n dialog.

4 options and all of them are poor. P13n Engine would be the best option, if it would have proper documentation and types.

It would be really nice if this could be fixed as a patch for 1.108.* as well, because I am forced to implement everything fully custom otherwise. Also it would be great if there would be some proper documentation and samples on how to use the Engine, current documentation state, as you can see, is chaotic and unclear.
Thanks in advance!

Hello @iljapostnovs ,
Thank you for sharing this finding. I've created an internal incident DINC0056931. The status of the issue will be updated here in GitHub.
Regards,
Todor

Hello @iljapostnovs,
thank you for the feedback on the personalization topic.
We've recently published two fixes for the documentation to improve the generated type definitions.
I will prepare downports for the according documentation correction and corrseponding type definition generation for the earlier releases, too. I will provide an update soon.
As you are referring to the examples, have you also checked the developer guide which provides a step by step description on the integration and provides further explanations? You can find this guide just below the according object samples which answers the questions you've been asking: https://sapui5.hana.ondemand.com/#/topic/f28025135e0e4527bdfb7c5441647391
Regards
Martin

Hello @iljapostnovs,
thank you for the feedback on the personalization topic. We've recently published two fixes for the documentation to improve the generated type definitions.
I will prepare downports for the according documentation correction and corrseponding type definition generation for the earlier releases, too. I will provide an update soon.
As you are referring to the examples, have you also checked the developer guide which provides a step by step description on the integration and provides further explanations? You can find this guide just below the according object samples which answers the questions you've been asking: https://sapui5.hana.ondemand.com/#/topic/f28025135e0e4527bdfb7c5441647391
Regards Martin

Thank you!
Regarding the guide, they don't really answer on my questions. E.g.

Question regarding handling the state. Yes, there are examples with e.g. applyState, however, as I mentioned before, it is experimental method, which means that I can't trust it.

So what can be used to apply state without experimental features?
Question regarding the keys

"Desired keys" doesn't say a lot. Where do the keys come from? Are those the keys from register method -> controller field? Can I set those keys as any string value? I hope so, because I see no other logical connection. If it is true, it would be nice if that would be mentioned somewhere.

I wanted to inform you about the fixes performed on this issue.
We provided several fixes:
Improve documentation for MetadataHelper: https://github.com/SAP/openui5/commit/f357b9496338c6b06adf827550cde2709d61d236
Improve documentation for p13n assets in general (such as the #getInstance method on the Engine): https://github.com/SAP/openui5/commit/0e165315522f7cfcd6f46cee7cda44c95a4d8907, https://github.com/SAP/openui5/commit/f357b9496338c6b06adf827550cde2709d61d236, https://github.com/SAP/openui5/commit/2275b9a63fe6105cb80ccb8c9659d392ef4aabe7
The above mentioned issues have been adressed in these changes as the according type definitions are generated using the jsdoc.
Your understanding is correct, that these keys are freely provided by the application developer through the registration process, but I agree that this needs to be improved in the according detailed explanation. We will improve the central documentation that I linked earlier to make this more clear.
Since the state needs to be translated into according changes for persistence, the only way right now to apply state which will be reflected in the variant management is using the #applyExternalState API. There are however no further changes to be expected in this API, hence we will consider removing the experimental flag in the upcoming release of UI5, but this can unfortunately not be provided as downport to earlier releases. The documentation enhancements mentioned however have been provided as downport for respective releases 1.120 and 1.108 and will be provided with the next patches.
Please get back to me in case of further questions on concerns in regards of this issue.

Just for my understanding, regarding the state:
Because of the 'dynamic' nature of the state, am I correct in assuming we should implement the parameter signature of the attachStateChange event handler like this:
private registerP13nEngine() {
    // config here

    Engine.getInstance().attachStateChange(this.doTableStateChange.bind(this));
}

private doTableStateChange(event: Event<Record<string, any>, EventProvider>) : void {
    const state = event.getParameter("state") as {
        Columns: MetadataObject[],
        Sorter: MetadataObject[],
        Groups: MetadataObject[]
    };

    // etc...
}

It would be nice if we could have a proper typed state object and/or event, but alas...


Guide to domain fronting

https://en.wikipedia.org/wiki/Domain_fronting#cite_note-1
https://www.bamsoftware.com/papers/fronting/
Wondering where we stand on Domain Fronting with OkHttp.    Some other providers require disabling SNI.  Should we document a working example to support this initiative?

I'd love that. I’m disappointed in Amazon & Google for breaking this. I wonder if Azure does it?

It looks like domain fronting is no longer a viable technique. Ugh.
https://signal.org/blog/looking-back-on-the-front/
No action for us to take here.
Ugh.


[QUESTION] Repetetive warnings and errors in a new longhorn setup

I've setup a completely new k8s cluster with longhorn 1.5.0.
There is nothing special running on that cluster, but I do get multiple warnings like:
time="2023-07-07T14:51:16Z" level=warning msg="Ignoring recurring job labels on Volume pvc-1e1565de-60a0-4dd8-9e7b-30b5d5a90772 PVC prometheus-community-server due to missing source label" controller=longhorn-volume node=worker3

and repetitive errors like this:
time="2023-07-07T14:49:46Z" level=info msg="Forwarding request to <IP_ADDRESS>:9500"
time="2023-07-07T14:49:46Z" level=info msg="CreateSnapshot: req: {\"name\":\"snapshot-275ba4a0-10aa-4024-87d8-2f82a37fb5b0\",\"parameters\":{\"type\":\"bak\"},\"source_volume_id\":\"pvc-7c074207-69ba-44de-af57-fba9cc564130\"}"
time="2023-07-07T14:49:46Z" level=info msg="GetPluginInfo: rsp: {\"name\":\"driver.longhorn.io\",\"vendor_version\":\"v1.5.0\"}"
time="2023-07-07T14:49:46Z" level=info msg="GetPluginInfo: req: {}"
I0707 14:49:46.203466       1 snapshot_controller.go:291] createSnapshotWrapper: Creating snapshot for content snapcontent-275ba4a0-10aa-4024-87d8-2f82a37fb5b0 through the plugin ...
E0707 14:49:46.203420       1 snapshot_controller_base.go:283] could not sync content "snapcontent-275ba4a0-10aa-4024-87d8-2f82a37fb5b0": failed to take snapshot of the volume pvc-7c074207-69ba-44de-af57-fba9cc564130: "rpc error: code = NotFound desc = volume pvc-7c074207-69ba-44de-af57-fba9cc564130 not found"
E0707 14:49:46.203323       1 snapshot_controller.go:124] checkandUpdateContentStatus [snapcontent-275ba4a0-10aa-4024-87d8-2f82a37fb5b0]: error occurred failed to take snapshot of the volume pvc-7c074207-69ba-44de-af57-fba9cc564130: "rpc error: code = NotFound desc = volume pvc-7c074207-69ba-44de-af57-fba9cc564130 not found"
time="2023-07-07T14:49:46Z" level=error msg="CreateSnapshot: err: rpc error: code = NotFound desc = volume pvc-7c074207-69ba-44de-af57-fba9cc564130 not found"
time="2023-07-07T14:49:46Z" level=error msg="Failed to create snapshot" component=csi-controller-server error="rpc error: code = NotFound desc = volume pvc-7c074207-69ba-44de-af57-fba9cc564130 not found" function=CreateSnapshot
I0707 14:49:46.191116       1 snapshot_controller.go:325] createSnapshotWrapper: CreateSnapshot for content snapcontent-275ba4a0-10aa-4024-87d8-2f82a37fb5b0 returned error: rpc error: code = NotFound desc = volume pvc-7c074207-69ba-44de-af57-fba9cc564130 not found

I don't understand the warning and the error. Obviously the volume is not existing, but why is it trying to create a snapshot at all and why is it trying this on a volume which is not existing?
I guess both parts are an issue of misconfiguration.
My values.yaml file:
persistence:
  defaultFsType: xfs
networkPolicies:
  enabled: true
  type: rke2
defaultSettings:
  storageOverProvisioningPercentage: 150
  removeSnapshotsDuringFilesystemTrim: enabled

Environment

Longhorn version: 1.5.0
Kubernetes version: 1.27.2
Node config

OS type and version: ubuntu 22
CPU per node: 4
Memory per node: 8
Disk type NVMe

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal

cc @PhanLe1010

time="2023-07-07T14:51:16Z" level=warning msg="Ignoring recurring job labels on Volume pvc-1e1565de-60a0-4dd8-9e7b-30b5d5a90772 PVC prometheus-community-server due to missing source label" controller=longhorn-volume node=worker3

The warning is fine.

and repetitive errors like this:

Can you provide a support bundle?

@derekbit Thank you for your reply. Here is the support bundle

These volumes such as pvc-d259794e-f52d-41fc-8d43-71f0b8af3ccd and pvc-7c074207-69ba-44de-af57-fba9cc564130 don't exist. That's why csi-snapshotter complains the failed to take snapshot of the volume...not found.

Do you have outdated configurations for taking snapshots of these volumes?

heya, I don't mean to steal this issue but the first warning might be a broader problem:
Since upgrading from v1.4.2 to v1.5.0, I'm getting a lot of them, for what feels like all (52; 38 attached) of my volumes. Since the number of log lines seem to spike every 4 hours, I assume they're related to my 4h-ly snapshot job:

here's a short excerpt from the longhorn-manager logs:

click to expand...
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-fc9dfcfe-c68d-4656-b626-d320b01bb7a0 PVC data-minio-3 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-23c0bee8-18a2-4582-90d5-881d258bda91 PVC data-loki-write-1 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	<IP_ADDRESS> - - [09/Jul/2023:10:49:39 +0000] "GET /v1/volumes/pvc-96836591-4725-461e-bf6e-e3ff776bee2e HTTP/1.1" 200 16659 "" "Go-http-client/1.1"
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-c5d2a149-83c6-4180-b64a-093d0b212dfe PVC data-minio-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f7463826-edda-4e90-81fe-beb5e31af78c PVC smp5-data-staging due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f0ad7c5b-3b10-4ef6-baba-afa251371d55 PVC data-loki-write-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-47b76234-55af-4dec-9385-a59bcfb6458b PVC kps-grafana due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-62627677-d937-45c9-952f-a4876a248194 PVC redis-data-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f7463826-edda-4e90-81fe-beb5e31af78c PVC smp5-data-staging due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-c5d2a149-83c6-4180-b64a-093d0b212dfe PVC data-minio-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:39+02:00	time="2023-07-09T10:49:39Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f0ad7c5b-3b10-4ef6-baba-afa251371d55 PVC data-loki-write-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:40+02:00	time="2023-07-09T10:49:40Z" level=warning msg="Ignoring recurring job labels on Volume pvc-1dc16f90-9b3e-4f46-8655-1e0ac7674693 PVC data-minio-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-1dc16f90-9b3e-4f46-8655-1e0ac7674693 PVC data-minio-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-33e5ec26-4bf3-4c3f-a974-fa1c933a5b8a PVC redis-data-authentik-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-95527332-1510-4546-9d68-433e7a17c8b5 PVC data-coder-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-acce2bf0-0f0a-4361-9588-f8b43f8d6959 PVC paperless-data due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-33e5ec26-4bf3-4c3f-a974-fa1c933a5b8a PVC redis-data-authentik-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-95527332-1510-4546-9d68-433e7a17c8b5 PVC data-coder-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:41+02:00	time="2023-07-09T10:49:41Z" level=warning msg="Ignoring recurring job labels on Volume pvc-95527332-1510-4546-9d68-433e7a17c8b5 PVC data-coder-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:42+02:00	time="2023-07-09T10:49:42Z" level=warning msg="Ignoring recurring job labels on Volume pvc-654216e9-6977-4ee0-a4bf-ceaead69816b PVC data-loki-write-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:42+02:00	time="2023-07-09T10:49:42Z" level=warning msg="Ignoring recurring job labels on Volume pvc-654216e9-6977-4ee0-a4bf-ceaead69816b PVC data-loki-write-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:43+02:00	<IP_ADDRESS> - - [09/Jul/2023:10:49:43 +0000] "GET /v1/volumes/pvc-7fb0f815-c718-4f69-a436-c8be5dc8ecb3 HTTP/1.1" 200 15377 "" "Go-http-client/1.1"
2023-07-09T12:49:43+02:00	<IP_ADDRESS> - - [09/Jul/2023:10:49:43 +0000] "GET /v1/volumes/pvc-acce2bf0-0f0a-4361-9588-f8b43f8d6959 HTTP/1.1" 200 15216 "" "Go-http-client/1.1"
2023-07-09T12:49:43+02:00	time="2023-07-09T10:49:43Z" level=warning msg="Ignoring recurring job labels on Volume pvc-80172caf-ba5e-43f9-a7d5-4dda55738ab0 PVC prometheus-kps-kube-prometheus-stack-db-prometheus-kps-kube-prometheus-stack-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:43+02:00	time="2023-07-09T10:49:43Z" level=warning msg="Ignoring recurring job labels on Volume pvc-80172caf-ba5e-43f9-a7d5-4dda55738ab0 PVC prometheus-kps-kube-prometheus-stack-db-prometheus-kps-kube-prometheus-stack-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-23c0bee8-18a2-4582-90d5-881d258bda91 PVC data-loki-write-1 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-23c0bee8-18a2-4582-90d5-881d258bda91 PVC data-loki-write-1 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f0ad7c5b-3b10-4ef6-baba-afa251371d55 PVC data-loki-write-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-62627677-d937-45c9-952f-a4876a248194 PVC redis-data-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f7463826-edda-4e90-81fe-beb5e31af78c PVC smp5-data-staging due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-47b76234-55af-4dec-9385-a59bcfb6458b PVC kps-grafana due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f0ad7c5b-3b10-4ef6-baba-afa251371d55 PVC data-loki-write-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:44+02:00	time="2023-07-09T10:49:44Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f7463826-edda-4e90-81fe-beb5e31af78c PVC smp5-data-staging due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-96836591-4725-461e-bf6e-e3ff776bee2e PVC mailu-storage due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-b66e781b-0bae-4e64-a132-7df47a70d2d4 PVC data-minio-1 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-6054334b-7ba2-426b-b3cf-5c35ba767cf3 PVC data-nginx-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-bc2bc1e7-fb6c-4e98-9ee6-93108da99cb6 PVC kuma due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-0dff2a1a-1dfc-4763-bf5b-45d5e726e479 PVC data-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-a8940a9b-c9f5-4a31-adf2-f6ba6c54dc14 PVC coder-willy-ravy-mopsdisplay-workspace due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-baa03094-7be1-4916-b8b9-086e1f9d4750 PVC data-nginx-1 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-678e058a-24b8-4042-b099-c14363e40739 PVC data-mailu-clamav-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-cfaf9618-50f1-45fd-b4b7-032208e28abc PVC coder-willy-coder-test-workspace due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-47b76234-55af-4dec-9385-a59bcfb6458b PVC kps-grafana due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-777a26fc-1169-4248-9272-cd34dbf2ca7f PVC warpgate-data due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-95527332-1510-4546-9d68-433e7a17c8b5 PVC data-coder-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-a911a62a-d7b7-48f3-abc4-9c4f3880290a PVC data-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-b65d795a-ffa5-4622-8d18-c5246737639c PVC smp5-data due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f0ad7c5b-3b10-4ef6-baba-afa251371d55 PVC data-loki-write-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-0bfe2332-9a04-4f10-98f4-7eab03e04ef4 PVC data-authentik-postgresql-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-33e5ec26-4bf3-4c3f-a974-fa1c933a5b8a PVC redis-data-authentik-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-6abb67a9-5389-4839-b938-bb34aa81665b PVC wordpress due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-cccb4827-9682-48eb-b191-c9a587905285 PVC data-mariadb-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-e0841e07-d3a1-4403-99e3-bc2f5012faa6 PVC data-nginx-3 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-525808e2-e67c-4df8-8c89-44a2838263bb PVC data-wordpress-mariadb-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-93aa7172-a139-4b89-a9ea-c684510067d1 PVC redis-data-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-80172caf-ba5e-43f9-a7d5-4dda55738ab0 PVC prometheus-kps-kube-prometheus-stack-db-prometheus-kps-kube-prometheus-stack-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-a9bf45db-5756-4465-8b48-d62d37aad1d3 PVC mysql due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-c5758520-9e29-440d-8191-71d601ddbee5 PVC redis-data-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-0670996d-cd3e-4eef-bf85-941d870416e4 PVC redis-data-redis-master-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-c5d2a149-83c6-4180-b64a-093d0b212dfe PVC data-minio-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-23c0bee8-18a2-4582-90d5-881d258bda91 PVC data-loki-write-1 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-654216e9-6977-4ee0-a4bf-ceaead69816b PVC data-loki-write-0 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-663e19b7-85c6-4dd1-b5af-eaafd1c0f9c9 PVC data-loki-backend-2 due to missing source label" controller=longhorn-volume node=k3s-master-0
2023-07-09T12:49:45+02:00	time="2023-07-09T10:49:45Z" level=warning msg="Ignoring recurring job labels on Volume pvc-f7463826-edda-4e90-81fe-beb5e31af78c PVC smp5-data-staging due to missing source label" controller=longhorn-volume node=k3s-master-0

...you get the idea.

this is the job's definition:
apiVersion: longhorn.io/v1beta1
kind: RecurringJob
metadata:
  name: 4h-snapshot
  namespace: longhorn-system
spec:
  concurrency: 1
  cron: 0 0/4 * * ?
  groups:
    - default
  retain: 12
  task: snapshot

It's meant to run on all volumes unless specified otherwise, which works.
From digging through the code a bit, it looks like the recurring-job.longhorn.io/source label is missing somewhere, but I couldn't figure out where exactly or what value it should have.
Is this something longhorn should patch automatically? Unless I've misconfigured something, to me it looks like anyone upgrading to (and per the OP's description: anyone freshly installing) longhorn v1.5.0 will get this message on recurring job runs?
let me know if you need a support bundle from me, 75MB is too big to just attach to a github issue >_<

heya, I don't mean to steal this issue but the first warning might be a broader problem:
Since upgrading from v1.4.2 to v1.5.0, I'm getting a lot of them, for what feels like all (52; 38 attached) of my volumes. Since the number of log lines seem to spike every 4 hours, I assume they're related to my 4h-ly snapshot job:

here's a short excerpt from the longhorn-manager logs:
click to expand...
this is the job's definition:
apiVersion: longhorn.io/v1beta1
kind: RecurringJob
metadata:
  name: 4h-snapshot
  namespace: longhorn-system
spec:
  concurrency: 1
  cron: 0 0/4 * * ?
  groups:
    - default
  retain: 12
  task: snapshot

It's meant to run on all volumes unless specified otherwise, which works.
From digging through the code a bit, it looks like the recurring-job.longhorn.io/source label is missing somewhere, but I couldn't figure out where exactly or what value it should have.
Is this something longhorn should patch automatically? Unless I've misconfigured something, to me it looks like anyone upgrading to (and per the OP's description: anyone freshly installing) longhorn v1.5.0 will get this message on recurring job runs?
let me know if you need a support bundle from me, 75MB is too big to just attach to a github issue >_<

Using trace or debug log level might be better to avoid flooding messages
WDYT? @ChanYiLin @c3y1huang @innobead

@c3y1huang Please help with this. Need to get to 1.5.1.

Removing the v1.3 and v1.4 backport labels because the log is introduced in v1.5.

Verified on master-head 20230815

longhorn master-head https://github.com/longhorn/longhorn/commit/3b04fa8c023b871bc321b84cf9479ebb7215b5df

Result Passed
After Helm installation and manifests, I have checked the following items:

[x]  The logLevel parameter can be configured in the values.yaml file and will be reflected as log-level.
[x]  The value of log-level can be modified.
[x]  The default value of log-level is set to Info.
[x]  We couldn't see any logs related to Ignoring recurring job labels on Volume when the log-level is set to Info. However, after changing the log-level value to Debug, we can observe logs related to Ignoring recurring job labels on Volume.


feat(tutorial): complete step 2 Ottawa

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

No updates in 90 days. Closing.


global variable CACHEDIR

I tested this in main.c
lua_pushstring(L, SDL_GetPrefPath("liters", "lite-xl"));
lua_setglobal(L, "CACHEDIR");

Then when doing print(CACHEDIR) in lite i got this output:
/home/bud/.local/share/liters/lite-xl/
Its not exactly XDG_CACHE_DIR i think, but it was the best the SDL API got.
--
But otherwise we can manually set better cache dirs for the different operating systems, but I have no idea what the defaults on Mac and Windows are?
Originally posted by @budRich in https://github.com/franko/lite-xl/issues/19#issuecomment-782769026

It is nice to have the CACHEDIR to point into a different place than USERDIR. As you said the USERDIR should be git-friendly and shouldn't be polluted with temporary files.
As for the implementation, I didn't know about GSL_GetPrefPath(). It is interesting but lite-xl has its own mechanism in src/main.c. I propose we implement CACHEDIR in main.c keeping the current approach.
I suggest using $HOME/.cache/lite-xl on all unix-like OS, including OSX. I think it should be okay also on windows as long as we use USERPROFILE env variable instead of HOME.
I suggest that we add also a TMPDIR that point to /tmp/.lite-xl on unix like systems and %TEMP%/lite-xl on windows.
So to recap:

USERDIR, where the user store its precious configurations, never polluted and git-firendly
CACHEDIR, where lite-xl store its cache files to be used across sessions
TMPDIR, temporary files, always wiped out at the beginning or end of the session

If you are ok with that @budRich you can go ahead and implement that in the "dev" branch.
Thank you for your help.

Yes I'll implement it, but I want some documented reference to refer to for the default cache directories. I don't see any reason why we should use .cache on windows.
Prefixing files and directories is a failed black magic ritual at bell labs that is one of the few advantages  using windows. And I am sure I have read somewhere that there is a "recommended" way of doing this on windows. I am sure macos also have something, and we should honor xdg-dirs on linux. I will do some research before i dive into the code. It's an easy implementation, but this is one of those things that once they are coded they are tricky to change (well, if they would be updated, then you would need to check for deprectated paths, move or remove files and stuff).

I found something on the source of absolute truth, a random unrelated stack overflow thread:
https://stackoverflow.com/a/41111916
Unix
~/.cache/pip and it respects the XDG_CACHE_HOME directory.

macOS
~/Library/Caches/pip

Windows
<CSIDL_LOCAL_APPDATA>\pip\Cache

to be honest though, i don't feel comfortable adding windows and mac features since I don't have any means of testing them and stuff.

@budRich That looks ok to me. Don't be afraid of writing the code for Windows and OS X. For Windows I will test myself and for OS X it will sit there until someone test it.


Use active theme colors for styled text in the debug console

~Draft because I'm not able to run tests / compile on this machine at the moment, but the code is pretty much done and ready for input.~
A problem with this approach is that after text is logged, if the user changes the theme, the logged text won't change color. One thing I considered was keeping the CSS rules but with CSS variables and dynamically changing the variables, but that seemed like it was introducing a lot of unnecessary complexity for an issue that isn't even much of an issue at all (the debug console is cleared often anyway).
Will fix #63986 and fix #42388.

@iansan5653 ok, let me know when you ran all the tests and they are good.
Did you consider listening onThemeChange and just refreshing the whole repl tree, so the colors get updated. Basically onThemeChange just schedule a refreshScheduler

@isidorn I've gotten everything working, except the tests are failing for apparently no reason. I think it's because the IThemeService instantiated in the test file isn't working. I'm using:
themeService = new TestThemeService();

Is this the correct way to do it for tests?

@iansan5653 that's the proper way to create a TestThemeService.
I can see the more precise errors here https://github.com/Microsoft/vscode/pull/71458/checks?check_run_id=104419801
Check them out.
Maybe you need to improve the TestThemeService, not sure where it exactly fails.
Debug the tests, we even have a launch configuration that runs the unit tests.

Yeah, I've been trying to fix those for a while now. I know the class is being applied because when I compile and run it, I can see the class in the developer tools. I just don't know why the assertion is failing. I'll keep trying to resolve.

Thanks a lot. However we are currently in endgame before the release which means we only accept a limited set of changes. Due to that assigning this to May when I plan to merge it (in about 10 days)

Thanks a lot for this PR. And sorry for merging with a bit of a delay.

No problem! Thanks for the advice and the merge.


Fix missing React import

Hey, I just made a Pull Request!
Fix missing React import in alpha catalog plugin so that eslint checks pass.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Closing as this appears to be due to stale eslint rules.


Test

Description
Please provide a brief description of the issue.
Steps to Reproduce
Please provide a detailed description of the steps required to reproduce the issue.

Expected Behavior
Please describe what you expected to happen.
Actual Behavior
Please describe what actually happened.
Environment
Please provide any additional information about your environment that might be relevant to this issue, such as your operating system or browser version.

Hi


[Bug] Disk mesh from meshgen breaks the tactoid example

2D mesh generated using meshgen has a vertex matrix of dimension [2,N] as opposed to [3,N]. This results in a MtrxIncmptbl error at optimize.morpho:243 while running the conjugategradient function.
To Reproduce
Steps to reproduce the behavior:

Go to examples/tactoid/tactoid.morpho
Replace var m = Mesh("disk.mesh") with the following:

import meshgen
// Domain composed of a single disk
var dom = fn (x) -(x[0]^2+x[1]^2-1)
var mg = MeshGen(dom, [-1..1:0.2, -1..1:0.2], quiet=false)
var m = mg.build()

Run the example.

This is known and I am adding something to MeshTools to enable the user to easily change the dimensionality of the mesh.

Fixed


Unable to mount on devcontainer mcr.microsoft.com/vscode/devcontainers/base:0-jammy

I expect
$ mkdir foo bar
$ sudo mount --bind ./foo/ ./bar/

to work in a codespace launched for this repo using a devcontainer with image
mcr.microsoft.com/vscode/devcontainers/base:0-jammy

just like it works on this branch which uses default universal codespace image.
Actually, I get
$ mkdir foo bar && sudo mount --bind ./foo/ ./bar/
mount: /workspaces/codespace-container/bar: permission denied.

Using strace on the failing command yields:
$ strace sudo mount --bind ./foo/ ./bar/

Effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?

When I try to login as root and run without sudo I get the same error. When I run again under strace I get a different log that I captured here. That second log doesn't contain anything I can make sense of. It seems to be looking for a resource string that it cannot find. Maybe that's why there's no specific error message?
The ability to mount enables use of chroot in codespaces.

Issue is somewhat related to Use suid so the container does not need to be started as root or have sudo configured · Issue #488 · microsoft/vscode-dev-containers (github.com). That issue seems to indicate sudo may not be properly configured depending on how the container is launched. If that were the only issue here then running as root would have worked. CC @felipers

Needed to add
 "runArgs": [
        "--cap-add=SYS_PTRACE",
        "--security-opt",
        "seccomp=unconfined",
        "--privileged",
        "--init"
    ],

I'm gonna suggest we offer a slimmed down version of the universal template.


Work Package wp-iz.csv

Results of Phase 1
wp-iz-results.csv

I would like to work on this please!

Results of Phase 2
wp-iz-results.csv

I completed this work package.


docs: Create Github marketplace documentation for Flank action

Fixes #1600
This is the description of the Flank Github action which goes to Github marketplace.

I just realized that we could not provide a custom description. I will add a link to the description of our main readme


docs: remove broken link

I think this could be explained more clearly as .svelte vs .js which removes the need for the broken link explaining what CSF is

📦 Published PR as canary version: 3.0.8--canary.126.d24e4fb.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v3.0.8 :rocket:


Microk8s not running correctly

Summary

Microk8s seems to not install correctly
When I run "microk8s inspect" it complains about
Inspecting dqlite
Inspect dqlite
cp: cannot stat '/var/snap/microk8s/7394/var/kubernetes/backend/localnode.yaml': No such file or directory
What Should Happen Instead?

I am guessing the file should exist as it messes up the kubernetes network stack
Reproduction Steps

Issue happens on all out Azure vm's where we install microk8s with : snap install microk8s --classic
2. ...
Introspection Report

Inspecting system
Inspecting Certificates
Inspecting services
Service snap.microk8s.daemon-cluster-agent is running
Service snap.microk8s.daemon-containerd is running
Service snap.microk8s.daemon-kubelite is running
Service snap.microk8s.daemon-k8s-dqlite is running
Service snap.microk8s.daemon-apiserver-kicker is running
Copy service arguments to the final report tarball
Inspecting AppArmor configuration
Gathering system information
Copy processes list to the final report tarball
Copy disk usage information to the final report tarball
Copy memory usage information to the final report tarball
Copy server uptime to the final report tarball
Copy openSSL information to the final report tarball
Copy snap list to the final report tarball
Copy VM name (or none) to the final report tarball
Copy current linux distribution to the final report tarball
Copy asnycio usage and limits to the final report tarball
Copy inotify max_user_instances and max_user_watches to the final report tarball
Copy network configuration to the final report tarball
Inspecting kubernetes cluster
Inspect kubernetes cluster
Inspecting dqlite
Inspect dqlite
cp: cannot stat '/var/snap/microk8s/7394/var/kubernetes/backend/localnode.yaml': No such file or directory
Can you suggest a fix?

We manually do the following:

stop microk8s
create the file
chmod/chown the file correctly
start microk8s

Are you interested in contributing with a fix?

Hi @lbarboi, could you please attach the inspection report so as to see what really failed?


[SPARK-33935][SQL][3.0] Fix CBO cost function

What changes were proposed in this pull request?

Changed the cost function in CBO to match documentation.
Why are the changes needed?

The parameter spark.sql.cbo.joinReorder.card.weight is documented as:
The weight of cardinality (number of rows) for plan cost comparison in join reorder: rows * weight + size * (1 - weight).

The implementation in JoinReorderDP.betterThan does not match this documentaiton:
def betterThan(other: JoinPlan, conf: SQLConf): Boolean = {
      if (other.planCost.card == 0 || other.planCost.size == 0) {
        false
      } else {
        val relativeRows = BigDecimal(this.planCost.card) / BigDecimal(other.planCost.card)
        val relativeSize = BigDecimal(this.planCost.size) / BigDecimal(other.planCost.size)
        relativeRows * conf.joinReorderCardWeight +
          relativeSize * (1 - conf.joinReorderCardWeight) < 1
      }
    }

This different implementation has an unfortunate consequence:
given two plans A and B, both A betterThan B and B betterThan A might give the same results. This happes when one has many rows with small sizes and other has few rows with large sizes.
A example values, that have this fenomen with the default weight value (0.7):
A.card = 500, B.card = 300
A.size = 30, B.size = 80
Both A betterThan B and B betterThan A would have score above 1 and would return false.
This happens with several of the TPCDS queries.
The new implementation does not have this behavior.
Does this PR introduce any user-facing change?

No
How was this patch tested?

New and existing UTs

Test build #133678 has started for PR 31042 at commit c821443.

Test build #133678 has started for PR 31042 at commit c821443.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38267/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38267/

Looks fine if the tests pass. Thanks for this fix, @tanelk

Looks fine if the tests pass. Thanks for this fix, @tanelk

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38267/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38267/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38267/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38267/

Test build #133678 has finished for PR 31042 at commit c821443.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133678 has finished for PR 31042 at commit c821443.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133678/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133678/


Update Docs: Intro “start-with-a-template”

Summary
The existing Nuxt boilerplate wasn't built for the latest features in Nuxt.
This is a Nuxt port of the Netlify maintained gatsby starter. And, I've ported the Bulma Kaldi theme used in the gatsby starter using TailwindCSS.
It includes the crawler and @nuxt/content for reading markdown content efficiently. It builds in under half the time of the existing boilerplate as a result.
https://nuxt-starter-netlify-cms.netlify.app/ / https://github.com/lukeocodes/nuxt-starter-netlify-cms
Test plan
Minor text change. Local build fails if there are errors (it built)
A picture of a cute animal (not mandatory but encouraged)
strong assumptions included

I've just fixed some bugs in this which would have made it break.
https://nuxt-starter-netlify-cms.netlify.app/

Closing the PR. Feel free to comment/re-open per my comment

Closing the PR. Feel free to comment/re-open per my comment


remove registry

I don't think this is really needed and a leftover from old OpenShift times

Registry is used at https://github.com/amazeeio/lagoon/blob/main/images/kubectl-build-deploy-dind/build-deploy-docker-compose.sh#L959-L960 to store ?harbor?

@tobybellwood
true, but it's actually set here: https://github.com/amazeeio/lagoon/blob/master/images/kubectl-build-deploy-dind/build-deploy.sh#L62 so I don't think the env variable itself is used.