Graph repository needs to tolerate fully escaped find strings

As discussed, have a look at the following helper methods:

OMRSRepositoryContentHelper::isExactMatchRegex(String)
OMRSRepositoryContentHelper::isContainsRegex(String)
OMRSRepositoryContentHelper::isStartsWithRegex(String)
OMRSRepositoryContentHelper::isEndsWithRegex(String)

These will tell you which "simple" style regular expression is being used (still a perfectly valid Java regex, but will have embedded \Q and \E quote characters that are Java-specific and may not be used in all regex interpretations).  Once you know what you're handling, you can then use this method to strip off the Java-specific pieces and get just the literal string:

OMRSRepositoryContentHelper::getUnqualifiedLiteralString(String)

Just keep in mind that this strips off all of the surrounding regex context.  So, for example:

if isContainsRegex(String) returns true, it means the string looks something like .*\Qsomething.you.should.treat.as.a.literal\E.*
which after sending to getUnqualifiedLiteralString(String) will give back just something.you.should.treat.as.a.literal
so you need to remember whether you're treating it as a contains, startswith, or endswith before un-qualifying it
(and also keep in mind that in this case all the .s in something.you.should.treat.as.a.literal should be treated as the literal character . and not as a regex placeholder for a single character)

Hi @cmgrote - Raluca sent me a debug trace and it is as we suspected - the OMAS is calling getExactMatchRegex() which is 'framing' the search string with \Q \E. This is what is passed to the repo connector. I'm familiar with your constructor and destructor methods which are neat.
For the graph repo I have access to the regex predicates supported by Janus - and I'm trying tp work out how to get those to take heed of the \Q and \E framing. It seems they don't - which would mean that I need to strip them - which is easy but then would mean that any meta-characters in the stripped (unqualified) string would regain special significance.
So for a non-special search string (e.g. any alphanumerics) life is good. But if we want to search literally for a qualifiedName containing 'ab.cd' then I have a problem with the '.' because if I simply unqualified the string then it would match any 5 character string starting 'ab' and ending 'cd'. I would need to re-escape just the special characters.
Will keep investigating and trying to come up with a solution.

Yes, unfortunately this is the kind of thing every engine will need to do to translate Java-specific regex into its own regex language.  (In particular, to recognise whether it can support all of the Java-specific regex characters and meanings in its own regex language...)
If there are other helpers that make sense to add more generally to achieve this that could be handy; I'm just wary that there are many different forms of regex which are all subtly different, so not too keen to try to come up with some generic translation mechanism between all of them...
(Hence going back to my previous comments about the most common scenarios / use cases to know which helpers are likely to have the highest priority...)

I think one key problem is our ability to capture the intent of the OMAS so that the repository connector understands what was intended and can do the right thing.
Suppose as an example we have an entity with qualfiiedName 'abide', another entity with qualifiedName 'abode' and a further entity with qualifiedName 'ab.de'.
The OMAS user/writer may want 'find' to retrieve only the 'abide' entity or 'abode' entity. This is an easy case - they could use the exact match helper to generate \Qabide\E or \Qabode\E and the repo connector could strip it using the getUnqualified..helper method'. The search would only retrieve the desired entity.
The harder case is where the OMAS user/writer wants to
EITHER:

retrieve all 3 entities. This is what they would get if they used 'ab.de' as the search string, whether we frame it in \Q \E or not, since the graph connector seems to need to remove the framing.
OR
retrieve just the specific entity with name 'ab.de'. In this case we would need the OMAS to explicitly escape the '.' character - i.e. using 'ab.de' then the repo connector could do the right search.

If they intend the first behaviour life is good; but if they want to specifically retrieve the entity whose name contains the special character we will currently retrieve too many entities, unless the graph connector can ascertain that was not the intention.
It seems logical in case 1 that the OMAS would not call a helper method  - since it is consciously providing a regex and the '.' character has special significance. And in the second case it seems logical that the OMAS would call an 'exact match' helper - which would individually literalise any special characters.
Is that worth a go? (I'd be happy to write the literalising helper).

@grahamwallis I agree - that is what I coded in the AssetHelper.  I use the exact match helper method when retrieving a specific entity/relationship by qualified name.  If I want all of the assets matching the string then I just pass the search string.
see

The getExactMatchRegex() helper method is literalising the special characters -- the way to do this in Java is to use java.util.regex.Pattern::quote(String), which is exactly how getExactMatchRegex() has been implemented.  (This is implemented natively in Java itself by adding the \Q...\E wrapping.)
Individually literalising / escaping every single potentially-significant character is going be error-prone and resource-intensive.  It also won't solve the issue where how something is specified in a Java regex differs from how the same regex would be defined in PCRE, JavaScript, Python, Golang or any other variations that a given repository back-end may or may not require.  Furthermore, for repositories that need to translate the regex into some other kind of predicate (contains, startswith, endswith, etc), we'd then need to do the reverse (also resource-intensive) to strip all of these escapes back off again.
So in a nutshell I'd be against this: either

a repository supports all of Java regex (and can take the string as-is and doesn't need the helpers), like the in-memory repository
or it doesn't support regex at all, but provides some predicates that can be easily translated to / from simple regexes
or it only supports some other subset of Java regexes -- in which case it's up to that repository to parse the string and see whether it can or cannot support it

OK - I think we are all saying the same things - I'm starting to write a specific literalizer. The existing helpers are good provided one stays on the Java island - but at the edge I need to do the translation into what JanusGraph supports. We're just going to have to cop the extra compute cost.
My point above about capturing the 'intent' of the OMAS may be sufficiently served by looking at whether the search string is framed by some combination of \Q \E and/or prefix/suffixed it with wildcards. My code will need to look at the string (for which I can use the isXXX helper methods) and will have to assert that if it finds the 'exact match' (QE) framing then the OMAS intended an exact match. There's no guarantee that's true but I think it's a reasonable guess. If an OMAS (or anyone) has explicitly framed their string with QE escapes then it's probably also fair to assume that they intended to. My connector will then construct the search string it needs.

OK - I think we are all saying the same things - I'm starting to write a specific literalizer.

I think you're right -- apologies if I took your original suggestion the wrong way (to replace the existing getExactMatchRegex() helper), when what you really meant is defining a separate helper which will escape all the special characters!  Indeed some repositories (like the graph repo) can use this to appropriately construct a search string that's specific to such repositories that support some subset of regexes (by which I mean, since it doesn't support the \Q...\E construct it by definition only supports a subset of Java regex).

My code will need to look at the string (for which I can use the isXXX helper methods) and will have to assert that if it finds the 'exact match' (QE) framing then the OMAS intended an exact match. There's no guarantee that's true but I think it's a reasonable guess.

I'm not sure why this isn't guaranteed?  If a string has been wrapped with \Q...\E it is very specifically saying treat everything within it as an exact match.  The only risk would be someone calling the metadata collection method without sending it a regex -- but that violates the methods' documented interfaces.  Furthermore, as I understand it, we more or less only ever expect an OMAS to call the metadata collection methods (no end-user / application calling directly to OMRS), so I think it's up to us to enforce that OMASes are following the OMRS interface appropriate and only ever sending regex strings (ie. properly escaping them or not depending no the semantic they want to achieve?)

Ah, thinking about this a bit more maybe there are some cases where it isn't so simple, like:
\Qsome.thing\Eand.some.more\E -- not sure how this should be interpreted (?)
But this also brings up the point that your literaliser is probably going to need to handle these \Q...\E pieces in a general way -- that is, the following is a perfectly legitimate Java regex:
.*\Qtake.exact\Eand.not.exact\Qthen.more.exact\E.*

Just a couple more checks for some concerns on my side:

We've found one example of Java regex characters that we can't support in graph repo (\Q...\E), but I think we need a definitive list so that the graph repo can check the string it receives to determine whether it can support it or needs to throw an exception?
Related to (1), presumably for some of these (like the \Q...\E) we will translate them rather than throwing an exception: what's the best way of documenting which ones we'll "support" (natively or translated) and which we won't?
How does the graph repo actually apply the regex to its search?  Is it something native in JanusGraph, that comes with no performance penalty?  Or (purely for extreme illustration) would there be an ability to search directly against an index without any regex interpretation in ~1ms vs sending a processor into the graph to calculate regex match against every object and return only the matches that might take ~1s?  IMHO we need to ensure that the exact match case is as optimal as possible, as a number of OMASes (like Data Engine) will be making 100's of search requests for exact matches for even relatively simple ETL jobs (of which there could be 10 000's) -- even 1-10ms savings on each of these calls will add up to very significant overall savings...  So my concern is if we're treating everything as a regex all the time for code simplicity, but with a potential performance penalty, this could have very significant implications to overall solution performance...

@cmgrote @popa-raluca @lcpopa I have coded up a change to the graph repository connector and unit tested it; will functionally test and post a PR on Monday.

Please see PR #1615

Please see PR #1615

Data Engine OMAS works with these latest changes


implicit argument lists

From @fommil on October 25, 2014 11:24
It is fairly standard practice in implicit-heavy libraries to write implicit parameter lists like this
  def canBuildFromFormat[F, E, T]()(implicit
    cbf: CanBuildFrom[F, E, T],
    ef: SexpFormat[E]
  )

but unfortunately I can't set up scalariform to use this trailing-implicit format. Is this something you could support with a new option?
Note that it is possible to do this sort of thing
  def canBuildFromFormat[F, E, T]()(
    implicit
    cbf: CanBuildFrom[F, E, T],
    ef: SexpFormat[E]
  )

Copied from original issue: daniel-trinh/scalariform#36

From @nairbv on January 1, 2016 1:36
I'm looking for any way to use scalariform without condensing curried function signatures, but the issue isn't just with implicit parameters, it's any kind of currying.
e.g., when I see code like:
def aReallyLongMethodName(thatHasSomeParameters:WithLongTypes)(andThenAnother:ParameterList) = foo

I'd like to be able to write it as:
def aReallyLongMethodName(thatHasSomeParameters:WithLongTypes)
                         (andThenAnother:ParameterList) = foo

But it automatically gets reformatted back to the first one by scalariform.  This prevents me from keeping a tight limit on org.scalastyle.file.FileLineLengthChecker in scalaStyle, and I've often seen single lines of code that get excessively long.
From the preview here it looks like characters aren't monospaced, but what I was getting at in my example is I would typically align the open-paren of my curried parameters, implicit or not.
Ideally I think I'd rather just have scalariform not touch any whitespace between a close and then open paren.  I hadn't considered your style for writing implicit parameters.

From @nairbv on January 1, 2016 17:39
I think I'll create a separate issue for what I'm describing since the option I'm requesting for curried parameters is a bit different.

I have a patch that formats implicits all with the keyword attached to the first parameter:
def foo()(
  implicit a: TypeA,
  b: TypeB
): Unit = {}

This could be leveraged into the filer's format if desired.

I've seen that style, it might be a useful addition.

This works out of the box (0.2.4)
def canBuildFromFormat[F, E, T]()(implicit
  cbf: CanBuildFrom[F, E, T],
  ef: SexpFormat[E]
)

While this is not currently possible
def aReallyLongMethodName(thatHasSomeParameters:WithLongTypes)
                         (andThenAnother:ParameterList) = foo

An alternative solution is
def aReallyLongMethodName
  (thatHasSomeParameters:WithLongTypes)
  (andThenAnother:ParameterList) = foo

Basically, stack param groups and let the library handle indentation.


HUB-98: Update Metadata resolver to check against new CAs

Metadata resolver accepts hub's truststore configuration and identity
providers' truststore configuration so that it can perform certificate
chain validation on hub's certificates and identity providers'
certificates in a metadata file using hub's truststore and identity
providers' truststore respectively. If hub's truststore or identity
providers' truststore is missing, the metadata resolver will not perform
certificate chain validation.
During certificate chain validation, metadata resolver checks hub
certificates and identity providers' certificates against CAs in hub's
trust store and identity providers' trust store, removes untrusted
certificates and leaves trusted certificates in the metadata.
These changes are necessary to allow Matching Service Adaptor (MSA) and
Hub to use an existing or new hub's truststore configuration and a new
identity providers' truststore configuration.
Co-authored-by: Rachel Smith
<EMAIL_ADDRESS>

@chrisholmes I have implemented a version of TrustStorePathMetadataConfiguration that the MSA and Hub use for the configuration of the Verify metadata resolver. This implementation validates that the IDP and Hub trust store configuration properties are set.


Utility function for getting the image URL for a Messenger-style emoji

#467
Example usage:
utils.getEmojiUrl('🐍', 128) returns https://static.xx.fbcdn.net/images/emoji.php/v8/ze1/1.5/128/1f40d.png which is the emoji asset url for the snake emoji:

I think this should be in a separate file and added to https://github.com/Schmavery/facebook-chat-api/blob/master/index.js#L75
(and also to DOCS)

@ravkr is right, if this function is meant for general users (not just internally), then it should be exposed in that way.  Let me know if you need help with that.
Is this a feature that anyone thinks they would use?  Trying to understand the usecase.

@Schmavery My rationale was that if someone wanted to render the messages obtained using this API, they might want to use the same emojis that Messenger uses. I was working on a Messenger log export tool using this library and I wanted to use Messenger-style emojis in the output, so I figured out this function.

Ok, seems reasonable.  Feel free to add a link to your tool to the end of the README  (in a separate PR) when it's ready 😄

Question: getEmojiUrl doesn't require the user to be logged in, but adding it to index.js would require the user to log in before they can use the function. Is that OK?

Can we assume for now that everyone using the api is logging in using it?  I think I'd rather go with that for now.

Sorry for the delay; I've moved the function into its own file and added docs

Thansk @GEOFBOT :)


Make DefaultTagHelperResolver use the correct GetTagHelpersAsync.

Prior to this we weren't overriding the GetTagHelpersAsync method resulting in our TagHelper discovery being executed in-process.
Removed legacy ITagHelperResolver types.

FYI @mkArtakMSFT

🆙 📅


Use Custom models such as Mobilenetv1

Hi,
Thank you for this repository and youtube videos. I want to train a custom model such as Mobilenet V1 on Jetson nano and I am not sure how to do this here. Could you provide some guidance or direct me to certain links in how to approach this?
Thanks!
Nikunj

Hi, see this section for ResNet18 and SSD-Mobilenet:   https://github.com/dusty-nv/jetson-inference#training

From: Nikunj Kotecha @.>
Sent: Thursday, June 10, 2021 6:30:19 PM
To: dusty-nv/jetson-inference @.>
Cc: Subscribed @.***>
Subject: [dusty-nv/jetson-inference] Use Custom models such as Mobilenetv1 (#1097)
Hi,
Thank you for this repository and youtube videos. I want to train a custom model such as Mobilenet V1 on Jetson nano and I am not sure how to do this here. Could you provide some guidance or direct me to certain links in how to approach this?
Thanks!
Nikunj
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-inference/issues/1097, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADVEGK4LPOH745T2BAO2RZTTSE4HXANCNFSM46PP2DAQ.

Thanks for the response. This shows training with PyTorch. I am trying to use Tensorflow. Besides, Mobilenet V1 is not there in Pytorch models. Can you help with working training Tensorflow's model: https://www.tensorflow.org/api_docs/python/tf/keras/applications/MobileNet


ConfigureWinRM.ps1 downloads from non existing urls

Tasks/PowerShellOnTargetMachines/ConfigureWinRM.ps1 script try to download tools from non existing url https://azurergtaskstorage.blob.core.windows.net/winrm/makecert.exe

+1

+1

@RomanDidenko , @zhy2002 , @ignacy130 , Thanks much for reporting the issue.
The issue is fixed, you may retry your script to configure the WinRM.

Closing this issue as it has been resolved by @pavanadepu2


Nnc

Added command line arguments for NN. Need to make sure extra files from nhd traversal weren't removed.

accidentally removed some nhd files need to fix that first


feat: add tree shakeable manager providers

Issue or need

Fixes #960
Proposed changes
Add tree shakeable providers by making them functions instead of consts. This way the code they can be tree shaken if unused.

Except for JSON_LD_METADATA_PROVIDER. Which has been removed as it's essentially the same as provideNgxMetaJsonLd

~Removes non tree-shakeable const providers~ Marks const providers as deprecated and pure. Pure so they can bee tree-shaken if used. Deprecated to favour new functions instead.
Add schematics to migrate automatically from old to new ones in #1005
Other changes:

~Return Provider instead of FactoryProvider. No need to reveal implementation detail of which kind of provider is returned~ Moved to #1045 to reduce diff
~Return Provider instead of Provider[]~. Moved to #1045 to reduce diff
Reorganizers JSON-LD module directories to be consistent with rest
Rename JSON_LD_METADATA_PROVIDER to provideJsonLdInHead (instead of provideJsonLd, to differentiate a bit)
Improves JSON-LD docs
Removes unneeded empty file (Twitter Card creator username)

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#1005
#1004  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite

After adding back const providers, seems that bundle size for Angular v15/16 is almost the same. 2 bytes less to be exact.
However, for Angular v17/18 it went from 162 extra bytes to 242 extra bytes. Hmmm. Taking a look to see if those const providers are still there!

Seems that it's mainly because var  is added before each function declaration. Whilst before, var was used for many variables. For instance: var OPEN_GRAPH_DESCRIPTION_METADATA_PROVIDER=provideOpenGraph(...),OPEN_GRAPH_IMAGE_METADATA_PROVIDER,....
var  -> 4 bytes. Plus the extra ()=>: 4 bytes.
Let's analyze the Open Graph module. There are 11 metadata providers in Open Graph. So 88 bytes for that reason. However seems first provider of each kind (basic / optional and profile) is actually added in same var declaration. So 8 bytes less in there. 80 bytes.
Then, adding up the extra () for each call to the function provider in the module providers: 2*11=22 bytes. Which sum up to 102 bytes, the reported bundle size increase in Open Graph module.
As expected, old consts do not appear in the bundle. When they get removed from the bundle after some time being deprecated, seems that we'll be able to get rid of those extra bytes then.


Small collection of fixes, mostly grammer or consistency

Hello,
This is just a few little fixes I made as I was reading through the library trying to learn. Feel free to pick and choose if you don't like my suggestions it's totally cool.
best regards

Neeeevermind, I see the comment now

Update Credo  …
A bug caused by credo relying on a Hex Util that no longer exists, is
detailed here:
rrrene/credo#210
This commit just updates the minor version to include the patch.

Sorry I missed this earlier, crazy week!
Yay \o/ to making OS authors happy! 👩🚀


Issues when setting bits in registers

In pwm.rs I saw:
pad.gpio[self.pin].write(|w| w.ie().set_bit());
pad.gpio[self.pin].write(|w| w.od().clear_bit());

My understanding of write is that it does:
let w = register.defaults();
let w = closure(w);
register.set_bits(w);

So the second line (clearing od) will undo the effects of the first. This should probably be:
pad.gpio[self.pin].modify(|_r, w| {
    w.ie.set_bit();
    w.od.clear_bit();
    w
});

The default value is 0x56 or 0b01010110 which is bits 1, 2, 4 and 6. This is equal to:

OD = 0 = Output Enabled
IE = 1 = Input Enabled
DRIVE = 0b01 = 4mA
PUE = 0 = Pull-Up Disabled
PDE = 1 = Pull-Down Enabled
SCHMITT = 1 = Schmitt Input Enabled
SLEWFAST = 0 = Slow GPIO Mode

I think this means the two lines I highlighted above are at least /harmless/, as they reset the pin to defaults, and then change one specific bit to a value that it already has in the default.

I mentioned this in matrix but didn't remember to make an issue for it.
This has been noted in a review comment on the PWM rework PR, but it's good to have a reminder that it's not done yet.
https://github.com/rp-rs/rp-hal/pull/61/commits/5b7265e711772668f8ec09845f327b32d9b1faee#r684648303

Fixed in #80


add datadog agent to ECS task defs [SPIKE]

This is a spike effort to test ECS-Datadog integration. Intending to test on rdev only for now.

Leaving this story open, as @alexlokshin-czi and I intend to (try to) get gunicorn integration working before calling this spike done.

Gunicorn integration was working in the end. Closing this spike issue.

@metakuni (cc: @dsadgat):  Discussed with @maniarathi the prospect of enabling Datadog APM in Q2 (original proposal)
The work would involve taking the changes from the associate PR, https://github.com/chanzuckerberg/single-cell-data-portal/pull/3610/files, and getting them on to main (which has progressed considerably since this spike, so it won't be a straight merge), retesting in testing in rdev, and then in dev, etc. And updating some documentation.
For Explorer, similar changes would need to be applied. So this work could either be split between the teams or one person could do it for both teams.  Since DPT is still planning Q2 work, figured it's time to see if we can get this tech work considered. I would expect this would all take <=1 week for 1 engineer. Curious if you think it's possible?


Allow filtering activedocs by Service ID

Implements activedocs list filtering by Service ID.
The original request about this https://issues.jboss.org/browse/THREESCALE-2967 suggested accepting service system name too.
For the moment I've implemented filtering by service ID due to:

Implement filtering by service system name would require performing an additional API call to system to get the associated service id, as the output from ActiveDocs list only returns the service ID and not the service system name
If specified system name does not exist then the API call would return no result/exception, which means we should take a decision of what to do if that happens. Maybe create an internal filter key that we know won't match any returned result? I'd prefer avoiding having special logic for this specific case (as in the future more filters would be demanded)

Pending tests until we know the approach of this PR.
@eguzki I'd like to receive your feedback on this. Thank you.

I would implement filtering by service system_id, even though it required one api call more. Shouldn't be a problem for commands like this.
Regarding empty filter output, then let it be. Like when you request service activedocs and there are none. Only output headers are printed.

Regarding empty filter output, then let it be. Like when you request service activedocs and there are none. Only output headers are printed.

I meant that in case system_name does not exist then the filter would not make sense and ALL of the elements would be shown, not none

Regarding empty filter output, then let it be. Like when you request service activedocs and there are none. Only output headers are printed.

I meant that in case system_name does not exist then the filter would not make sense and ALL of the elements would be shown, not none

Maybe set the filter to "-1" ? This assumes no service_id with id "-1" can exist in system

Maybe set the filter to "-1" ? This assumes no service_id with id "-1" can exist in system

Can work. Other alternative is to replace the filter by service id for a '/dev/null' filter when service is not found. Anyway, warning about the service not found should be printed in stderr.

@eguzki I tried to make the filters reusable across commands in case we need it. Can you review the new implementation and organization at class/module level?
Thank you.

LGTM, but still in WIP, I cannot approve

Tests and documentation added.
Ready for review @eguzki


Resolve single-word REPO as word/word to look up official GitHub repo

E.g. attempt mautic/mautic when invoked with mautic, etc. This will allow reducing search API usage.

Done, but ideally, we do this by fetching releases.atom from the get go... to save on an API call


Some epubs are displayed as completely empty black screen

Hello, I'm having an issue with a few epub books, they dont seem to load up correctly?
Getting a complexity empty black screen while opening them, but they load just fine in web browser.
As some loads up just fine, I'm assuming its not an issue with the server.
is this a known issue?
other than sending one of the epubs in question, i'm not sure what more info I can post.
also getting this one on a few: text works just fine, but image illustrations aren't loaded

phone: samsung galaxy s8 plus
kuboo version: 1.1.3
server version: Ubooquity 2.1.1

I am going to implement a brand new epub reader. The current one is a bare bones place holder as the app was built just for comics in the first place. I hope to make epubs a first class citizen but this is not trivial and takes time as I'm searching for better solutions.
You can still e-mail me the epub if you want me to check it out<EMAIL_ADDRESS>

Sounds good, will send you 2, one which is completely black and one whom the images doesn't load properly.
updated the main post abit.

I see the images, this is a known issue and will not be fixed because I intend to replace the entire epub reader in the future.


Notification - Step 1

First step to resolve #145
This deprecates #429
I plan 2 steps:

[x] Create database table and create/update notifications (this one)
[ ] Actually have UI for notifications

LGTM

LGTM :)


Why is the data from OpenGPT-X not "utf8" encoded but requires "iso-8859-1"

This problem has been open for quite some time. Data derived from OpenGPT-X data infrastructure cannot get decoded via "utf8".
An example is it_20_docs.jsonl.zip
This problem was currently fixed by choosing the default encoding "iso-8859-1".
Related exchanges:

Originally posted by @le1nux in https://github.com/Modalities/modalities/pull/40#discussion_r1478322810
fixed in #24

Closing this, due to https://github.com/Modalities/modalities/pull/40#discussion_r1479996581


[WFLY-16155] Temporary pin org.bouncycastle 1.69 for elytron int test

Fixes https://issues.redhat.com/browse/WFLY-16155
Shall be reverted when https://issues.redhat.com/browse/WFLY-15867
"Upgrade org.xipki.pki/ocsp-server" including test-rewrite has been resolved.

Thanks, @boris-unckel


mandb: fix apropos

Motivation for this change
apropos was broken.
Instructions
For building the system's database, su -l root -c mandb.
For a per-user db, write a ~/.manpath with something like this:
MANPATH_MAP	/home/luser0/.nix-profile/bin	/home/luser0/.nix-profile/share/man
MANPATH_MAP	/home/luser0/.nix-profile/sbin	/home/luser0/.nix-profile/share/man
MANDB_MAP	/home/luser0/.nix-profile/share/man	/home/luser0/var/cache/man

And execute mkdir -p /home/luser0/var/cache/man & mandb -u.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Note: This should be the first step for https://github.com/NixOS/nixpkgs/issues/14472.

travis hangs. not sure why.
If anyone wants to verify manually, it only takes a minute to build on my potato.

It would be better if the manual database generation step could be avoided. It could be probably done here: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/config/system-path.nix#L148

@dezgeg that will only solve the system database. the user database needs ~/.manpath. see https://github.com/NixOS/nixpkgs/issues/14472.
Regardless, this PR will need to be merged first either way. No?

Hmm, this is probably mass rebuild? :/

Build-time deps are often bloated, unfortunately: man-db <- w3m <- xmlto <- opensp <- docbook-xsl <- systemd <- cups <- ...

@vcunat I'm keeping track on mandoc and will hopefully deprecate man-db + groff + bdb out the base system (https://github.com/NixOS/nixpkgs/issues/14472).
It's also why I'm in no rush to write a module.
Thanks!


Update dynamicbase.md

arm32 and arm64 is not supported for this linker switch as ASLR cannot be disabled for these architectures.

@laurenprinn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@laurenprinn
Thanks for the update. Should we make similar clarifications in the /HIGHENTROPYVA linker switch docs? When we mention ARM64, should we also include ARM64EC? And when you build for an ARM platform, do these flags get silently ignored, or do they cause command-line warning D9002 or similar?

@laurenprinn
A follow-up: Currently, you write "This option is not supported for Arm32 or Arm64 architectures." I'm thinking it might be more accurate to say "This option isn't available for ARM, ARM64, or ARM64EC targets because ASLR can't be disabled on these architectures." I'd substitute "is silently ignored" for "isn't available" if that's what actually happens. Is that a valid restatement of your intent?

@corob-msft
Thanks for reviewing the proposed changes. IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

@laurenprinn A follow-up: Currently, you write "This option is not supported for Arm32 or Arm64 architectures." I'm thinking it might be more accurate to say "This option isn't available for ARM, ARM64, or ARM64EC targets because ASLR can't be disabled on these architectures." I'd substitute "is silently ignored" for "isn't available" if that's what actually happens. Is that a valid restatement of your intent?

@corob-msft You have the right idea. /DYNAMICBASE is actually supported just fine as it is the default for the ARM platforms.  It's actually /DYNAMICBASE:NO that is incompatible with them.  In some sense /DYNAMICBASE is silently ignored since it is the default and can't be overridden, but I don't know that we need to say that.  I would focus on /DYNAMICBASE:NO, and, yes, it's because the OS cannot disable ASLR on those platforms.
Regarding /HIGHENTROPYVA, the linker doesn't seem to enforce the same incompatibilities, so I'm not sure we need to change that.  Would need more investigation.

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks, @laurenprinn  and @RussKeldorph. This looks good enough for posting. Let me know if you'd like to clarify anything else. I've put in a matching fix for the linker option (this one just touches the EDITBIN option docs) in Followup cpp-docs 3871 in linker opts.


CodeAi auto-fix of nullpointer

CodeAi was used to generate a fix for the null pointer dereference that was detected. Please provide your feedback on the quality of fixes that was generated by the software.
CodeAi is an intelligence tool that uses static analysis to detect bugs and generate fixes for them. For more information, you can visit our website at qbitlogic.com
ex_cmds2.c.pdf

NULL pointer could not passibly pass win_valid check, so there may not be NULL pointer dereference there.

Hi,
Op 10 mrt. 2017 8:50 p.m. schreef "vika121"<EMAIL_ADDRESS>CodeAi was used to generate a fix for the null pointer dereference that was
detected. Please provide your feedback on the quality of fixes that was
generated by the software.
At that position in the code, wp === curwin (by the if above it), therefore
it can't be == NULL...
Regards,
Christ van Willegen

Also PDF report contains way too unrelated data, link at the top is pointing to invalid location, as well as other links (PDFs do have internal references, so anything but internal reference is invalid since data is also located inside), and there are bugs like

And this:

Without a reproducible example we can only assume this is a bogus fix.


Multiple Idles

Is it possible to have multiple callbacks with different timings?

Hello @chanr32. Do you mean something like multiple instance of vue-idle ? for getting event related to idle in 1minutes / 2 minutes / etc ?

Hello,
If anyone want / need this, I'll be glad to help.
The idea I guess would be to define one idle which listen to mouse event and one other idle which depends on touch event ?
If anyone can provide, real life example. I'll be grateful.
Thanks

@gabrielstuff , There could be plenty of real-life examples. Let say we want to log out the user after 10 mins of inactivity (which is a very common use case).
Now in the same application let say we want to show a help popup after a user is idle on a page for 2 mins.

Hello,
I'm not sure how, we can make this clear with vue.
I'm thinking about binding idle-vue to a component instead of the app then.
In the mean time, you should be able to do this with the vanilla version idle-js and the recently release 1.1.2 version
Cheers,
g
On 6 Feb 2019 at 16:48 +0100, Piyush Beli<EMAIL_ADDRESS>wrote:

@gabrielstuff , There could be plenty of real-life examples. Let say we want to log out the user after 10 mins of inactivity (which is a very common use case).
Now in the same application let say we want to show a help popup after a user is idle on a page for 2 mins.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, I am also wondering if it's possible to have multiple idle time listeners or a way to bind idle-vue to a component instead of the main app? or perhaps both?


Serve multiple directories

Is it possible to serve multiple directories?

it will be very useful possibility to configure simple aliases for eg.: /js => ./static/js

Is there already a way to just serve everything on a subdirectory?

@Phlogi what do you mean by that?

like this: domain.com/myservice/, i.e. adding a subfolder.

AFAIK, it's not possible with http-server out of the box.ecstatic, the core behind http-server, provides an option baseDir.


Fix Get-WinEvent -FilterHashtable to work with named event data field

Now FilterHashtable parameter in Get-WinEvent for named data field:

generates a valid query, ex. @{Logname="System";Param="a"}
generates a valid query for multiple values, ex.
@{Logname="System";Param="a","b"}

Now I need help in creating tests #2368
Close #2327

Hi @iSazonov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

@iSazonov I have manually verified your code changes and it works as expected, thanks for fixing it! Now we are waiting on you to address the PR comments.
At the same time, @JamesWTruher is following up on the .evtx test file (thanks Jim!). Once we have that test file ready and merged, you can add test for this PR.

I was able to construct a set of tests for this - it required an EVTX file - I'll create a PR for that (the test which uses filterhash is commented out - take a look, and if it's good, you can uncomment the test. I don't want to mark it as pending because on linux it means that tests would be marked both pending and skipped which is not allowed.

@JamesWTruher Great test! Thanks!
Required addition.
This test checks only the first part of my fixes.

$filter = @{ path = "$eventLogFile"; Param2 = "Windows x64"}
The second part would look like this
$filter = @{ path = "$eventLogFile"; Param2 = "Windows x64","Windows x32"}
as the named parameter by definition are String[].

Thanks @iSazonov for the updates. The EVTX file is now available, please add another test to cover all your changes. Now we are waiting on you to address the StringBuilder comment and add the additional test.

Hi @iSazonov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Please feel free to add these tests in your PR, since the test code is now all merged, you should be able to add tests you think are good

In reply to: 250667902 [](ancestors = 250667902)

@iSazonov thanks for your replies to the review comments. As for the additional test, please see @JamesWTruher 's comment.

@JamesWTruher I can add second test, but it requires additional events in the evtx file. Now there are only three events, only one is suitable for new test and need at least two.

$filter = @{ path = "$eventLogFile"; Param2 = "Windows x64","Windows x32"}

here for the "Windows x64" there are a event and for "Windows x32" a event does not exists in evtx.

I think you can use DriverName (it's in UserData.SetupInstallPrinterDriver) - it's not Param, but it should still work:
<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'>
...
<UserData>
<SetupInstallPrinterDriver xmlns='http://manifests.microsoft.com/win/2005/08/windows/printing/spooler/core/events'>
...
<DriverName>Microsoft enhanced Point and Print compatibility driver</DriverName>
...
</SetupInstallPrinterDriver>
</UserData>
</Event>

<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'>
...
<UserData>
<SetupInstallPrinterDriver ...
<DriverName>Remote Desktop Easy Print</DriverName>
...
</SetupInstallPrinterDriver>
</UserData>
</Event>

@iSazonov Please see @JamesWTruher's comment about using 'DriverName' to test passing a string array value like $filter = @{ path = "$eventLogFile"; DriverName = "Remote Desktop Easy Print", "Microsoft enhanced Point and Print compatibility driver" }.
And also, could you please rebase your branch? Your PR contains some merge commits.

Sorry for the delay the #2425 it stopped me. Now all test ready.
Sorry for the refuse I only learn git. Now I made rebase.

@iSazonov Thanks for the update! It look mostly good except for one small typo (please see my comment above). Once you fix the typo, the PR will be ready to merge.

@daxian-dbw Small question about planned support of  and use StringBuilder. In fact, we need to build a XML query: is it acceptable to use System.Xml.XmlWriter?

@iSazonov Performance difference between XmlWriter and StringBuilder shouldn't be a consideration here, and they both will avoid generating a bunch of new strings like the current code does (Yay! :)). So you should pick the solution that you think is more maintainable.
XmlWriter make it easier to not generate any malformed XML queries, especially when the query is complex, but on the other hand it possibly will make the code less concise, for example, you may end up repeating following code snippet in many places. So if you decide to go with XmlWriter, please try avoid repeat as much as possible 😄 (for example, maybe put the code snippet below in a method that you can call whenever you need to generate a <Query> element)
$xmlWriter.WriteStartElement("QueryList")
$xmlWriter.WriteStartElement("Query")
$XmlWriter.WriteAttributeString("Id", $Id.ToString())
$XmlWriter.WriteAttributeString("Path", $Path)

$xmlWriter.WriteStartElement("Select")
$XmlWriter.WriteAttributeString("Path", $Path)

@iSazonov Thanks again for fixing this issue with Get-WinEvent!

@daxian-dbw Thanks for help and advices! This is my first code after 20 years 😊


Upgrade to native build tools 0.9.5

As discussed previously, on Gradle side we should try to do this part programmatically in order to remove this from our documentation and start.spring.io:
nativeBuild {
	classpath(processAotResources.outputs, compileAotJava.outputs)
}
nativeTest {
	classpath(processAotTestResources.outputs, compileAotTestJava.outputs)
}

for reference: https://github.com/graalvm/native-build-tools/releases/tag/0.9.5


Sanitize qr-code VCARD input to match regex field specifications (see #187)

This commit sanitizes the qr-code input from "Schnelltest-Profil". Many users are adding spaces on fields where this app does not allow them to be. By sanitizing the input we allow not experienced users to still use the quick-test-frontend (see #187)

@ggrund-tsi Do you have feedback for me on this?

Hi @janhoffmann,
I will point it in next planning.
Thank you for your patience and best Regards, Gordon


paypal phishlets not grabbing password

my PayPal phishlets is not grabbing username and password how can i make it to start grabbing I need help on this

You have discord I might be able to help and I need help with something you might have setup

My discord is Findmeskid#7816

i have added you on discord

Hey guys I'm having some problems to install evilginx please add me on discord dafyman#4877


Fix: ODK version updated in template.

Fixes issue: https://github.com/odk-x/tool-suite-X/issues/187
What changes have been made?

The version has been updated to X in web UI login screen.

@linl33
Kindly review this.


python34 Install on windows error!

Traceback :
File "setup.py", line 23, in
readme = open('README.rst').read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0x94 in position 4932: illegal multibyte sequence
and I found the problem in README.rst file on line 140 ~ line 144, the "—" symbol,change it to "-" and then will run success!

Hey @pamxy, thanks for reporting this. I'll push the fix as soon as I can.
Many thanks
Mishbah

Hey @pamxy Ive updated the README, please let me know if the issue is resolved.


UofT-DSI | pyhton - Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
completed the 3 sections of the assignment 2, Python module
What did you learn from the changes you have made?
reading files: passing a variable associated with a file into another variable (contents), which is of a _csv.reader data type
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
na
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
In the section 2, it took me some time to understand how the return_values are integrated into the function being defined.
I figured out that return_values is a variable that must be assigned for all the subfunctions' results.
How were these changes tested?
in a separate ipynb file with test arrays and with the test cells from the assignment file
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

Hi, there is problem in your code, first where you have to find summary values using numpy library so you will use np.mean rather than data.mean, and in the last part where you have to do error detection in patient data, your function is incomplete, you have to use check_zeros function on the variable you assign patient_summary function, please complete your assignment till Sunday.

Hi Sidra, thank you for your comment!
In the new commit:

Added a cell for all_paths reading all files and importing csv.
Corrected patient_summary function definition: corrected the code for mean values (np.mean() instead of data.mean()).
Collowing Sidra's comment, ran a test for check_zeros function.

Thanks, marked.


R2DBC support

R2DBC (Reactive Relational Database Connectivity) is for reactive programming and containing concise SPI. Looks like it will be very well integrated with the DSL-style frameworks.
See:

R2DBC SPI: https://github.com/r2dbc/r2dbc-spi
JavaDoc: https://r2dbc.io/spec/0.8.0.M8/api

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I wrote a reference implementation.

So..its been almost a year, can we at least get an answer? will/wont do/prs accepted etc

PR's will be accepted :)

@jwgmeligmeyling  - for R2DBC we would need to bump the min version of java to 1.8, would that be ok?

@riba2101 Yes, it's on the roadmap for 5.0.

Yes, and if you implement it in a dedicated module (querydsl-r2dbc) only that module has to be JDK8 afaik. So that also helps while the other modules are still on Java 7. But with 5.x we'll go to Java 8 anyway.

oh sry, was kinda busy - yeah that's how I've started and exactly how it's currently implemented, and yes, you are correct, a single module can have a different compile version

Hey guys, so...the changes are kinda huge...dunno how you guys wanna do this? (atm it's only compiling, need to test is extensively)

If you want to use R2DBC with Querydsl now and are using Spring Data, Infobip Spring Data Querydsl now has R2DBC support.
Example usage:
interface TRepository extends ReactiveSortingRepository<T, ID>, ReactiveQuerydslPredicateExecutor<T>, QuerydslR2dbcFragment<T> {
}

QuerydslJdbcFragment provides access to SQLQuery, SQLUpdateClause and delete with Predicate  support.

If you want to use R2DBC with Querydsl now and are using Spring Data, Infobip Spring Data Querydsl now has R2DBC support.
Example usage:
interface TRepository extends ReactiveSortingRepository<T, ID>, ReactiveQuerydslPredicateExecutor<T>, QuerydslR2dbcFragment<T> {
}

QuerydslJdbcFragment provides access to SQLQuery, SQLUpdateClause and delete with Predicate  support.

Hi all, when will #2610 be merged? Anything remains to be done?

5.0.0.M1 with Java 8 as baseline has been released so that addresses the https://github.com/querydsl/querydsl/issues/2468#issuecomment-638989912.

Hi ! Are there any update on R2DBC support ?
Cheers !

guys, im super busy atm, pls try to support/further as i am currently not able to

I am doing a demo of springboot3, which includes using QueryDSL as the Interface to generate SQL, and the underlying execution is taken over by R2DBC. Reference code: https://github.com/charlesvhe/native-image/blob/main/core/src/main/java/com/github/charlesvhe/nativeimage/QueryDslR2dbcTemplate.java
sample code：https://github.com/charlesvhe/native-image/blob/main/provider/src/main/java/com/github/charlesvhe/nativeimage/provider/ConfigMetaService.java
QBE
 @GetMapping
    public Mono<PagingResponse<ConfigMeta, ConfigMeta>> get(Paging paging) {
        return queryDslR2DbcTemplate.select(q -> q
                        .select(Projections.bean(ConfigMeta.class, QueryDslR2dbcTemplate.buildColumn(paging.getFields(), qConfigMeta.getColumns())))
                        .from(qConfigMeta)
                        .where(QueryDslR2dbcTemplate.buildWhere(paging.getFilter(), qConfigMeta.getColumns(), ExampleMatcher.StringMatcher.CONTAINING))
                        .orderBy(QueryDslR2dbcTemplate.buildOrder(paging.getSort(), qConfigMeta.getColumns()))
                        .offset(paging.getOffset())
                        .limit(paging.getLimit())
                )
                .collectList()
                .map(data -> new PagingResponse(data, paging.next()));
    }

If you want to use R2DBC with Querydsl now and are using Spring Data, Infobip Spring Data Querydsl now has R2DBC support. Example usage:
interface TRepository extends ReactiveSortingRepository<T, ID>, ReactiveQuerydslPredicateExecutor<T>, QuerydslR2dbcFragment<T> {
}

QuerydslJdbcFragment provides access to SQLQuery, SQLUpdateClause and delete with Predicate  support.

Does it handle relationships?

https://github.com/infobip/infobip-spring-data-querydsl?tab=readme-ov-file#R2DBCInnerJoin


Improve moderation page

Summary
Currently the moderation page that moderators see contains an accordion view that splits experiences into different categories. This approach will not work once we have a lot of experiences to moderate.
Deadline
Mid-april 2023
What needs to be done?

To improve the moderation overview page there are a number of improvements

[ ] Split the moderation view into at least 3 sub-views: unmoderated/approved/rejected
[ ] Allow pagination for each of the 3 sub-categories
[ ] Add search functionality

Who can help?

@gedankenstuecke
@helendduncan

Updates

Draft PR to restructure the moderation page into three pages: #484.

So well done @llewelld! 🎉


New feature: segment categories TEDU-58

Thanks for making this PR!
Appreciate some of this was there before however it would be awesome if we can start to be more consistent with the capitalisation of features in Mautic and correct them as we see them. Hope these make sense!

Sure I will keep that in mind

@RCheesley I have resolved all change

@fakela can you please remove the .DS_Store files from the PR? You may want to add that to your .gitignore file.

This seems to be a duplicate of #205 @fakela ? Not sure which one should be retained, please take a look and close one of them :) Thanks!


Filesystem routing doesn't respect routing precedences

Description
Reproduction repo: https://github.com/devunt/vite-plugin-ssr-routing-bug
Codesandbox: https://codesandbox.io/p/github/devunt/vite-plugin-ssr-routing-bug/draft/practical-mestorf
Filesystem routing does not respect rules of routing precedences. Quote from https://vite-plugin-ssr.com/routing-precedence indicates that:

Upon Route String conflicts, vite-plugin-ssr chooses the first route from most specific to least specific

In the reproduction repo, I have following directory structure:
/index.page.tsx <-- works well (obivously)

/1/index.page.tsx <-- works well
<EMAIL_ADDRESS><-- every routes including /1/specific falls to here
/1/specific.page.tsx <-- I cannot access to this page

/2/index.page.tsx <-- works well
<EMAIL_ADDRESS><-- every routes including /2/deep falls to here
/2/deep/index.page.tsx <-- I cannot access to this page

It seems "most specific to least specific" rule doesn't apply to filesystem routing.
I think it should be applied in filesystem routing, too?
P.S.
I sponserd @brillout on the behalf of @ccoli-co, a company I and @XiNiHa work for.
Thank you for making and maintaining great plugin 🎉
We are in the middle of progress of migrating existing Next.js site (which have over hundred pages) to VPS, and it is being a very pleasant experience in both DX and performance. As now VPS is being crucial part of our business and frontend stack, we'd made an choice to sponser its maintainer and ecosystem.
Error Stack
No response

Yea, I agree. Let me have a look.
Thanks a lot for your sponsorship... 💚. It makes a tremendous difference. I'm humbled. Thanks!

Fix released in 0.4.34. I didn't test the fix; let me know if you still run into any issue.


Update glove-gensim.py

Cleaner code with some optimization and avoiding too many re-reading of the glove file

This version is great. It creates a generic program to deal with all the GloVe models.


Add custom headers to webhooks

Brief description: Enable customers to enhance webhook notifications with custom headers.
GitHub or Jira issue URL:
https://kontent-ai.atlassian.net/jira/software/c/projects/DEL/boards/501?selectedIssue=EN-44
https://github.com/kontent-ai/management-sdk-net/pull/258
When do you need the code to go public? Provide a release date such as Jan 23, 2023, and/or explanation.
Do not release before Feb 21, 2024
Is the pull request complete and ready for review? Yes

Hey @lenkaklimcikova, thanks for the PR and proposed changes to the .NET code sample. I considered using more concrete values instead of key1 and value1 but kept it as it was. I'll use more concrete examples in the API reference materials instead. :)
Merging and closing.


No audio on macOS, Safari

Tested using: https://jsmpeg.com/perf.html?file=blade-runner-2049-240p.ts&webgl=1&wasm=1&audio=1
Anybody have a workaround? Thanks!

Hi @alectrocute, The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page. Nowadays all modern browsers block audio playback. You need to trigger a gesture (like a click on a sound button) to resume the Audio Context and re-enable the sound


Check length of bits of NTildej

NTildej received from Pj, should be of length 2048. This PR add such length checking.

Hello friends, you may want to allow some variance in the size of the paillier modulus - it might be 2047, 2046 with some probability and those are still ok

Hello, in our implementation when generating safe primes, we also need the generated value start with "11". So the factor of a paillier modulus >= 21023+21022. While (21023+21022)(21023+21022)>2**2047, the result paillier modulus should be exactly 2048 bit.

Hello friends, you may want to allow some variance in the size of the paillier modulus - it might be 2047, 2046 with some probability and those are still ok

Hello, in our implementation when generating safe primes, we also need the generated value start with "11". So the factor of a paillier modulus >= 21023+21022. While (21023+21022)(21023+21022)>2**2047, the result paillier modulus should be exactly 2048 bit.


Fix job indexing and notifications - testing

Github epic
Basic test plan:

[x] Create a task comment with a unique term and verify that searching on unique term returns job as a result
[x] Update a task comment with a unique term and verify that searching on unique term returns job as a result
[x] Delete a task comment with a unique term and verify that searching on unique term does not return job as a result
[x] Verify appropriate audit log entries are created for create, update, and delete task comment operations

Remaining tasks

[x] Ramp-up @labkey-chrisj
[x] Fix / augment automated tests 3hr
[x] Create test plan? 1hr
[x] Manual Testing 3hr
[x] pull request for automated tests https://github.com/LabKey/sampleManagement/pull/1568
[x] Code review 1hr - @labkey-danield
[x] Code review feedback 1hr
[x] TC review and merge 1hr
[x] pull request for automated coverage in biologics @labkey-chrisj https://github.com/LabKey/biologics/pull/1886
[x] code review
[x] feedback and merge

in Biologics

[x] update job description with unique expression, search finds it
[x] update job description to remove unique expression, search no longer finds it
[x] email notifications are sent when task comments are added or updated

in SM

[x] update job description with unique expression, search finds it
[x] update job description to remove unique expression, search no longer finds it
[x] email notifications are sent when task comments are added or updated

last PR for this needs review

[ ] code review
[ ] incorporate feedback
[ ] merge


sheet corrupted after save

While working on https://github.com/plandem/xlsx/issues/37, I tried to open a truncated version of an example spreadsheet in "not streaming" mode to make my modifications.
Here is the original sheet:
mfi101119holdingslist_100_noissuer.xlsx
The goal is to lookup matches for the "issuer" column in a database of previous entries and select the best match.
To this end I iterate though the sheet using row = rows.Next() collect some fields to use in a database query, then use
cell := match.Row.Cell(mi.IColIssuer)
// everything output by this diagnostic is reasonble
fmt.Println("I", match.Row.Bounds(), mi.IColIssuer, match.Issuer)
cell.SetText(match.Issuer)

to write the data (match.Issuer is of type string).
Finally I save the data; it doesn't seem to be documented whether to call save before or after sheet.Close() so I tried both ways:
sheet.Close()
xl.SaveAs("./foo.xlsx") // also tried this first
xl.Close()

The resulting file is corrupt:
foo.xlsx

let me check what's wrong with file...hadn't any corrupted for ages

Thank you  ... I'm sure I could have done something wrong. :) ... But also perhaps update via iterator isn't well tested? (PS -- save after sheet close is presumably correct? ... how does that work with streaming write? If I do save as after write but there are other sheets, they are all copied, I presume? ... might be good to document somewhere.)

Actually I found a bug in markup - that's a reason for corrupted file. Looks like it's relatively new bug, because I had tested library against your file (not exactly your, but same mfi file) and it worked well in the past.

regarding to Close for sheet, well...right now it's used by read in stream mode mode. For other cases it has no any code under the hood.

Great -- thanks!
I'm the person they go to to automate things, but the rest of the company are excel natives; my mandate is to make things easier for them but not disturb their workflows unnecessarily. They like putting complex features into excel, so they are a good source of challenging spreadsheets for you. (Just wait until I try to automate sheets with pivot tables... :))

complex files to test is totally fine. That's a reason why that library was born. I was in your shoes - some managers of clients used heavy (like really heavy) formatted excel as the source of truth, but the same time they wanted to add some diff feature to compare reports for two months and mark in later one changed rows with keeping all that formatting.

Great -- can confirm that it writes!
NB I get the following message (still) when I open. Is there anything internal to the sheet that says someone is using it? This could be related to fact that I am running in macOS and opening spreadsheet in windows running in parallels.

probably because of parallels. I test everything in OSX.


Error: Cannot find source or destination token account balance change

I have passed the destinationWallet. Getting this error. the destinationWallet passed is having both USDT and USDC balance that means token account has been already created. or i have done something wrong.
FYI
I am passing destinationWallet as string.

and the good thing is even its generating exception txn is going through successfully. dont know what to do.


Upgrade cf acceptance test base image to bionic

What
Upgrade cf acceptance test base image to bionic
This is one of the last places xenial was used. Broke our billing acceptance tests as postgres is no longer providing xenial apt packages.
How to review

Check CI
Deploy in dev env

superceeded by #249 and #250


Stop vendoring protos

Since rules_rust 0.25 introduced prost/tonic rules it's now theoretically possible to remove the entire proto directory and trivially generate the current proto target with this:
rust_tonic_library(
    name = "remote_execution",
    proto = "@remote-apis//build/bazel/remote/execution/v2:remote_execution_proto",
)

Modulo some toolchain setup/configuration and adjustments to bring turbo-cache in sync with the upstream proto this will give us a net gain of over 6k LoC. Fantastic :heart_eyes:
There seems to be one bug remaining in 0.25 that prevents us from implementing this and we'll probably have to wait for 0.25.1 or 0.26, but we're getting close:

https://github.com/bazelbuild/rules_rust/pull/2033#issuecomment-1616796884

I'll have to think about this. I find it useful to have the generated proto files at my finger tips sometimes, especially when debugging complicated code.
I'm not saying no, I'm simply questioning the value it will bring at this point.

I very much agree that this is only a good change if it doesn't complicate debugging. I'll send a draft PR when there is a resolution for https://github.com/bazelbuild/rules_rust/pull/2047, but let's drop this if it turns out to be bad dev-UX.

For a data point, I peeked into the generated files today when making gzip optional (https://github.com/allada/turbo-cache/commit/f4fcff29ea6274356d501b3791940ce5c1346ec7).


⚠ TorrentLeech has degraded performance

In abda01d, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 5970 ms

Resolved: TorrentLeech performance has improved in cd2f841 after 8 minutes.


Add steps and column wise example

Hello,
fixes:- #577
I did the edits you asked for after the merge in #578  .
Added steps

And Edited the example column wise.

@Nupur-Khatri have u checked before sending the PR? Now the page is not opening

@Nupur-Khatri have u checked before sending the PR? Now the page is not opening

Yes I did .. and the screenshots I added were taken from the page only ..you can see the time as well in the screen shots .

@Nupur-Khatri then what is this?

@Nupur-Khatri then what is this?

Hello,
Oh I will see this issue today ... Will definitely resolve ...

@Nupur-Khatri if u r facing any problem u can contact over discord

@Nupur-Khatri if u r facing any problem u can contact over discord
Hello,
Edited changes are still visible on my device and also site is visible and working fine ..
I am creating another pull request again you please try check there ..


where are scripts folder under example?

I don't see the folder existing as described in wiki page.

Hello @hjma29 , the scripts folder was part of a deprecated code and was removed.
The wiki is indeed not yet updated to reflect that.
While the wiki is not updated, please refer to the README file for setup and instructions since that should reflect the current setup well, and check the examples folder for examples on usage of the SDK.

It'll be nice to have some example of using Python library to fully populate a Synergy chassis from ground zero like this example using OneView Powershell
https://github.com/daveolker/Populate-HPE-Synergy/blob/master/Populate_HPE_Synergy.ps1
Also can mention ansible/Python repository in Readme file so users can choose either options.

An end-to-end script like what is mentioned could indeed help users.
It is not something we have planned at the moment though, so I'm leaving the #help_wanted tag up, so that if someone can contribute with some time this can be done.
On a side note, we do have some e2e examples on the oneview-ansible repository, and due to their declarative nature they'll likely be a lot cleaner than pure python examples.


Fix NAs in the metadata output

This is a fix for the issue #85

@HoumanLM I see in your PR the github actions are failing. That;s because the updated workflow is in this PR and is not on master yet. Can you please review this and if it looks good, then merge this branch to master and pull update to your branch so it can pass the actions?

Sure!


Trimmer background color issue

How does one get rid of the charcoal dark grey trimmer background? Or at the very least change its color to match the backgroundColor of the screen?
Note: the green trimmer start and end markers are already at their extremities, these are the beginning and end of the video. So the dark color either side of the markers is the issue.

?

As a workaround, what I did was keep the trimmer at full width at all times, no matter the size of the video, by giving the <Trimmer/> component width={screenWidth}. It also looks prettier.

@BaderSerhan I have tried this, but it doesn't look as good in my opinion. @shahen94 do you know how the color either side of the trimmer can be changed?

There's no implementation currently, but you can pass props down to the Trimmer and receive it in the Swift code
https://github.com/shahen94/react-native-video-processing/blob/master/ios/RNVideoProcessing/RNTrimmerView/RNTrimmerView.swift#L208

What would the props be to isolate the area outside the extremities of the markers?


Improve error message when username/password requires URL encoding

Based on user feedback...
When username/password is embedded in the URL and either of those fields include special characters two things can go wrong:

We might not print the most useful error message.
We might print the password.

Closed by #18


fix issue #77 by importing SQL explicitly

The --auto switch produces code that is not working for fields with extra arguments like default. The output looks like this:
 length_mm = pw.FloatField(constraints=[SQL("DEFAULT 0.0")])

SQL has not been imported in the template so I fixed this by adding the import to the template.

Coverage remained the same at 72.473% when pulling a0169591dca13d5199d219d84f2bee15ffd33e86 on stlehmann:develop into 4c04eb35f5414f98c709f0d00e3bbcaa097e63f8 on klen:develop.

@stlehmann Thank you for the PR, it was fixed before.


Declare public namespace to use classes

I would like to use the ArcGIS for JavaScript classes like that is possible with AngularJS:
$q: ng.IQService
Now it's like this:
First I have to declare the class:
import Map = require('esri/map');
then I can do this:
function (map: Map)
With kind regards,
Cees van Altena

Assuming you're using TypeScript / Esri JS 4.x, unless you're actually creating a new object, you can reference object definitions via the global "__esri" object. In your example, you'd do this:
function (map: __esri.Map)

I tend to use:
import esri = __esri;

At the top of the file, so I can refer to types in the esri namespace:
class A {
  get map(): esri.Map {
  }
}

Note that you can't instantiate types like this, for that you'll need to actually import the module still.


CIF-1557 - Regenerate GraphQL library for Magento 2.4.0

regenerate with Magento 2.4.0 and default extensions (vs. github install)

Generated with https://github.com/adobe/graphql-java-generator/pull/8

Merging without verification, this has been generated and is not a feature.


Additional Point Source Capabilities and More

Can use apparent or absolute magnitude in light components (don't think its backwards compatible, will need review/discussion)
add csv_path option for train_model.py
new data generation options(option to store caustic area, option to select for quads only, option to select for high magnification of point source images)
allow for custom pixel grid kwargs
new sampling distributions for lens center

kwargs_synthesis=None needs to be set when calling lenstronomy.LensModel.profile_list_base_import_class() (not backwards compatible w/ older lenstronomy versions)
numpy typing (i.e. np.int, np.bool) is no longer supported

Closing this large PR to make separate PRs for each feature.


Streaming request recv hang if client interrupted

Version
v0.14.27
Platform
Linux demo <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Tested on several other linux platforms(ubuntu, debian, etc), same issue occurred.
Description
I tried this code: add a stream request handler in the echo example as below.
diff --git a/examples/echo.rs b/examples/echo.rs
index ff757304..6fa05793 100644
--- a/examples/echo.rs
+++ b/examples/echo.rs
@@ -4,10 +4,25 @@ use futures_util::TryStreamExt;
 use hyper::service::{make_service_fn, service_fn};
 use hyper::{Body, Method, Request, Response, Server, StatusCode};

+use futures_util:: StreamExt;
+
 /// This is our service handler. It receives a Request, routes on its
 /// path, and returns a Future of a Response.
 async fn echo(req: Request<Body>) -> Result<Response<Body>, hyper::Error> {
     match (req.method(), req.uri().path()) {
+
+        // Serve streaming body
+        (&Method::POST, "/stream") => {
+
+            let mut payload = req.into_body();
+            while let Some(item) = payload.next().await {
+                let item = item?;
+                println!("payload len: {}", item.len());
+            }
+            println!("stream body finished");
+            Ok(Response::default())
+        }
+

then run it
$ cargo run --example echo --features=full
Compiling hyper v0.14.27 (/home/workspace/hyper)
    Finished dev [unoptimized + debuginfo] target(s) in 3.22s
     Running `target/debug/examples/echo`
Listening on http://<IP_ADDRESS>:3000

Open another terminal, and test against the server by curl:
curl -v -X POST --data-binary @"YOUR_TEST_FILE" --limit-rate 1M http://<IP_ADDRESS>:3000/stream

I expected to see this happen:
Normally logs like below will output by the echo server if curl finished correctly(transfer succeed), which is expected.
...
payload len: 65536
payload len: 65536
payload len: 17317
stream body finished

However, if curl was interruptted by CTRL + C, the stream body finished won't be printed and the session seems hang forever on the server side.
...
payload len: 65536
payload len: 65536
==> hang here

The server itself does not hang when a client close the connection abruptly, but there isn't a good way to see the error in hyper 0.14. In hyper v1.0.1, it will be propagated to the caller as UnexpectedEof
The error propagation stops here: https://github.com/hyperium/hyper/blob/dedcb674f35eaec765a42b550caabe6f694d86d1/src/server/server.rs#L794, and it's only written to debug-level logs.


Missing KEY_BASED option from BatchBuilder for C++ Client

Is your enhancement request related to a problem? Please describe.
When we wanna receive messages with KEY_SHARED mode with Java consumer, we found there is no KEY_BASED option from BatchBuilder for C++ producer. It's kind of frustrated for the integration between C++ & Java programs.
Describe the solution you'd like
Add KEY_SHARED mode for C++ client and KEY_BASED option from BatchBuilder as well.

You can set consumer type of ConsumerConfiguration to use key shared subscription.
C++ client doesn't support key based batching yet.  I did some work about key based batching last month, but I'm a little busy recently so I didn't continue. It's not a difficult feature but it needs much code refactoring for C++ client.

@BewareMyPower

You mean Java consumer with KEY_SHARED mode and C++ producer without KEY_SHARED mode are working well for KEY_SHARED?
Could you please take some time on it? Really appreciate.

@wongkimshing
First make it clear that KEY_SHARED is a subscription mode for consumers, key based batching is a feature of batching for producers. You can send messages without batching by C++ client, and consume these messages using KEY_SHARED subscription by Java client.

I mean C++ consumer can subscribe topics with KEY_SHARED mode.
Yeah, I'd like to continue the development. I may just have more time after this week.

I've just pushed a PR #7996 to support key based batching. There're a lot of changes so it may take some time to review.
You can see KeySharedConsumerTest.cc as an example. Just change the batching type of producer:
            ProducerConfiguration()                                                //
                .setBatchingType(ProducerConfiguration::KeyBasedBatching)          //
                /* set other configs... */

Close this issue since it is supported now.


Ready announcements for Docsy

Change how we support dismissable announcement banners.
Serve the JavaScript code using Hugo Pipes; avoid customizing the head.html partial.
Here's a preview
Helps with issue #41171
/area web-development

Thanks for this. I agree, this brings things more in line with what upstream Docsy is recommending.
/approve

Additional lgtm:
/lgtm

/approve


Use shallow git clone in Dockerfiles

git clone --depth 1 --shallow-submodules ...
EDIT: Looks like have to omit  --shallow-submodules for the version of git in the image. This does not seem to affect the size or the speed.

Will that work if we're operating at a specific commit that's not HEAD for our git repos?

The Dockerfile clones specifies a specific branch at clone time.

Okay, can you give it a try with and without the shallow-submodules option and show us the time difference?

Sorry, I should add this has two benefits:

faster build
more importantly: smaller Docker image. Right now it's > 3 GB.

How much faster?
How is this related to #4116  ?

On my local machine 3.8s vs 12.1
Related; it is one more step to cutting bloat in the image. That one I hope cuts 2+ GB. This one is a more modest 50MB.

@caisq, could you take a look at integrating this. the devel docker image is pretty insanely huge right now. Somebody nearby filled their disk and wedged their machine installing that docker image :).

Any thoughts on this?

On my todo list. Thanks.


Add promise API

Do you think the current callback based API be completely replaced by a Promise-based API or they both exist simultaneously?


[embedded] Initial Swift Concurrency for embedded Swift

PR starts building a (simplified, cut-down) embedded version of the Swift Concurrency runtime library, implements a modified contract between the compiler and swift_task_create() that doesn't rely on metadata, and adds an executable test that exercises a simple task creation showing the setup working (!).
Note that there is definitely a lot of Swift Concurrency functionality still missing, this doesn't achieve full Swift Concurrency parity.
Major parts involved:

SILOptimizer rewrites CreateAsyncTask builtin to use a thin metatype instead of thick
IRGen of CreateAsyncTask builtin synthesizes a set of witnesses for the result type and passes that to the runtime as a new TaskOptionRecord.
swift_task_create() parses the new TaskOptionRecord, forms a ResultTypeInfo (data structure in the runtime can hold either a Metadata*, or the separate witnesses pass down by the compiler)
FutureFragment, PollResult, TaskGroup stop using Metadata* in favor of ResultTypeInfo
CMake for Concurrency starts building a subset of the Concurrency runtime, for macOS only for now.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test Windows platform

@swift-ci please test

Will the embedded configuration be tested in normal smoke tests, so we don't have to hunt for fixing it afterwards?

Yes. It will build as part of regular builds, tests will run as part of regular PR testing too.

@swift-ci please test

@swift-ci please test Windows platform


qt512: fix darwin patches

Motivation for this change
The patches for Qt 5.12 on Darwin no longer apply. Although I cannot test the build on macOS, I can make the Darwin patches apply on all platforms because the patches target only platform-specific files.
See also: https://github.com/NixOS/nixpkgs/pull/107483#issuecomment-752998482
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I'm still waiting on nixpkgs-review to verify that all the dependent packages build.

I'm still waiting on nixpkgs-review to verify that all the dependent packages build.

Have not tested all deps, but this unblocks qtmultimedia :+1:

Have not tested all deps, but this unblocks qtmultimedia :+1:

I didn't find any new failures in the dependent packages.

I didn't find any new failures in the dependent packages.

I will let you know if I see any other darwin related failures in qt.

I will let you know if I see any other darwin related failures in qt.


Apply React.memo twice to ensure that props object reference stays the same

See https://github.com/facebook/react/issues/18901
Ideally, it should be fixed on React side though

Can you clarify exactly what behavior this is trying to fix?  I'm not sure I understand what the problem is.

props, and therefore wrapperProps change by reference each time parent component re-renders, which leads to unnecessary calculations and effects

Can you put together a sandbox that shows how this specifically affects React-Redux?  Also, how does this change affect the React-Redux benchmarks repo results?

Looks like it only adds some more calls to react-redux internal functions, there's no external effect thanks to an additional check
Here's the sanndbox https://codesandbox.io/s/focused-goldberg-jres3?file=/src/App.js
If you open devtools on detached view ("Open in new window"), you can find https://jres3.csb.app/node_modules/react-redux/es/components/connectAdvanced.js file in Sources tab and place a debug point at line 183 which maps to https://github.com/reduxjs/react-redux/blob/master/src/components/connectAdvanced.js#L407
You can observe that this line is only executed if you click "update redux" after "update parent"
I will also check how my change affects React-Redux benchmarks

This won't have any effect because the props object is spread:
<Connect {...props} />

React doesn't compare the props as an object instance, it does a shallow comparison of their values.
If there's something else going on with React not keeping child props memoized between parent re-renders, that's something internal to React. We shouldn't mis-use their APIs to workaround their bug.

React doesn't compare the props as an object instance

But react-redux does

This won't have any effect because the props object is spread:
<Connect {...props} />

Looks like it's only the case for forwardRef: true. Can be solved by applying memo after forwardRef, not before


Add a reusable ArrayList to InternalThreadLocalMap

Motivation:
See #3411. A reusable ArrayList in InternalThreadLocalMap can avoid allocations in the following pattern:
List<...> list = new ArrayList<...>();

add something to list but never use InternalThreadLocalMap

return list.toArray(new ...[list.size()]);

Modifications:
Add a reusable ArrayList to InternalThreadLocalMap and update codes to use it.
Result:
Reuse a thread local ArrayList to avoid allocations.

@trustin @normanmaurer PTAL

@windie LGTM

Cherry-picked into 4.1 (b7415a3307d9a36f2a67339c7596e0ee2b2a5644) .
@windie thanks!


update dimensions of chrome-web-store png

Screenshot of the diff

Thank you for accepting it:)
Have a good day!


Add fixer support for puppet-lint

Certain automated linter fixes (e.g. quoted booleans) can cause problems if
they're automatically applied, but are still worth surfacing for review
by humans
It's probably worth noting that I haven't actually run this against a PR, but the tests are passing. I mostly just copied tests from the Rubocop tests, but they seem reasonable.

Codecov Report

Merging #200 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   89.29%   89.37%   +0.07%
==========================================
  Files          41       41
  Lines        2149     2165      +16
==========================================
+ Hits         1919     1935      +16
  Misses        230      230

Impacted Files
Coverage Δ

lintreview/tools/puppet.py
97.67% <100%> (+1.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2685f...62c7e32. Read the comment docs.


Build as per readme instructions fails

Readme instructions suggest building is as simple as running mvn install, however, this is not the case.
Multiple modules fail to build due to artifacts not being present in mvn central.
Some of these (order and payment modules) can be fixed simply by adding the camunda public repo to the respective poms.
bpmn-monitor is harder to fix, so I gave up trying to do it myself.
It seems to have dependencies on artifacts not present in the camunda repo. I am guessing they come from https://github.com/camunda/camunda-consulting but don't have time right now to try to get them working and submit a PR.
I kindly suggest you try the building according to your readme instructions against an empty local maven repo and default ~/.m2/settings.xml to see the errors it produces.
I'll give this another go if and when I have more time, the project looks super cool and I'd like to be able to demo it to "the business" :-)

I can confirm this. I will add the public repo and remove the bpmn-monitor from the repo - as it requires an camunda enterprise edition to properly show history.

@mihbor Would be great if you can give it another try. I am actually on vacation and just fixed it in between ;-)

Moved the monitor to own repo: https://github.com/berndruecker/flowing-retail-camunda-bpmn-monitor

Awesome, thanks!


Lua errors when renaming [Bug]

Describe the bug
I got the following error pressing F2 in insert mode:
stack traceback:
        ...cal/share/nvim/plugged/renamer.nvim/lua/renamer/init.lua:274: in function '_create_default_popup_opts'
        ...cal/share/nvim/plugged/renamer.nvim/lua/renamer/init.lua:140: in function 'rename'
        [string ":lua"]:1: in main chunk

Environment

Renamer: master
Neovim: *0.9.5 *

I had the exact same problem:
E5108: Error executing lua: ....local/share/nvim/lazy/renamer.nvim/lua/renamer/init.lua:274: attempt to index local 'p' (a nil value)
stack traceback:
        ....local/share/nvim/lazy/renamer.nvim/lua/renamer/init.lua:274: in function '_create_default_popup_opts'
        ....local/share/nvim/lazy/renamer.nvim/lua/renamer/init.lua:140: in function 'rename'
        /home/rw/.config/nvim/lua/kmp.lua:63: in function </home/rw/.config/nvim/lua/kmp.lua:63>

I looked at that code and there was only one possible reason that that variable wouldn't be defined, and it was that require('renamer').setup() had never run. I added opts = {}, to my lazy config and all works well :)


[WIP] [DON'T MERGE] Pokemon, PokemonSpecies facade interfaces and empty DTOs.

The problem is, that we can only allow specific trainers to change the values, so we need to pass the requesting trainer to the service layer (to ensure that a trainer only modifies their own Pokemon). PokemonSpecies has it slightly easier, since that whole interface will be restricted to only a certain role, so these checks need not be performed (see e.g. no PokemonSpeciesRemoveDTO).

Update on this pull - I consider it blocked until corresponding service implementations land, so as not to duplicate effort on exception creation and co.


Adding scripts for nightly pip wheel builds

Description
Adds scripts that are currently running to generate the nightly wheels in https://apache-mxnet.s3-us-west-2.amazonaws.com/dist/index.html
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

This is redundant to the CD solution that exists on Jenkins and would distract the efforts and cause confusion.

I appreciate your perspective @szha, but this is the current CD system (CodeBuild) that has been providing the community with nightly builds for almost 3 months now since December 2019. This is the CD solution that currently exists. The other Jenkins solution is one that is not well maintained by the community, and as such required us to setup the current system in the first place.

@samskalicky this solution doesn't meet the requirement that CD jobs should be open and manageable by all mxnet committers and PMC members.

As discussed on dev@ before, the CodeBuild solution can only be a stop-gap solution to keep the flow, until the open CD pipeline is fixed (see thread). It's one thing that there's no efforts from you or your team on maintaining the agreed-upon long-term solution for the openly managed CD, and it's another to advocate for a closed solution which doesn't lend itself for management by the community. Thus I veto this change to stop further distraction.

The CD solution was recently broken by the incomplete removal of python2 in #15990, which is being fixed in https://github.com/apache/incubator-mxnet/pull/17551. Once the CD pipeline is fixed, the CodeBuild solution should be deprecated and I will update the access control accordingly.


Add a Darwin build of sorbet-staic without a kernel version

This leaves all of the other kernel versioned gmes, but adds one that can be used by any kernel.
Motivation
If you're using nix, most of the time you get ruby from a build cache, and it comes built as RUBY_PLATFORM="arm64-darwin22". This RUBY_PLATFORM is set to 22 even if you're not actually using Ventura, and instead on the previous release of darwin kernel 21. To use a ruby project in nix you use bundix to generate gemsets, and you have to pick a single version of sorbet-static. And so you pick the universal-darwin-22 one, because that's what RUBY_PLATFORM is set to.
And that all works okay for a while. However if you ever miss the nix cache, and build a version of ruby from scratch, it will be built as arm64-darwin21. This can happen if you're trying out a prerelease, or right now when the version of ruby in nixpkgs is still on 3.1.2 and you want to use 3.1.3. Then if ruby is built as arm64-darwin21, bundler wont be able to load the sorbet-static for darwin-22.
Other gems, like nokogiri have dropped the kernel versions from their pre-built releases, and for them there is no problem with bundler selecting it no matter what RUBY_PLATFORM is set to. In my project's gems, Sorbet is the only one still adding kernel versions.
I understand that dropping all of them may be too big of a change, but I hope adding a versionless one is small enough to be acceptable.
Test plan
I've built a local version-less gem and it seems to work.

Sorry for taking so long to get back to you

I understand that dropping all of them may be too big of a change, but I hope adding a versionless one is small enough to be acceptable.

I'm actually kind of down to get rid of the versions. IIUC, it would only happen for new gem releases—old published versions wouldn't be affected.
Is there any downside? Is it like, only certain Ruby or rubygems or bundler versions support omitting the kernel version? I think that the only reason why we had the kernel version in the first place is because we didn't know any better.

I don’t know know for sure. But I have a strong feeling that Sorbet can get away with no versioned gems.
I briefly asked @flavorjones who maintains Nokogiri who said the thing to look for is if it's loading different system libs, but since it's the same binary for all versions, I'd think it's the same on all. I only have darwin-21 to check though at the moment.
WRT only doing new versions that's perfectly good I think.
Also with how often there are new versions of this, I'd say if people complain it'd be quick to go back and add the versions again. It'd only be a problem for a small moment in overall time.

My experience shipping precompiled gems for nokogiri and sqlite3-ruby is that the darwin version does not impact those gems. It's possible that folks who are integrating with Apple libraries may need to be careful here, but for the majority of Rubygems I don't know of any reason to keep the darwin version portion in the gem package name.

Bumping this one up, as we've now hit Sonora and darwin-23
I'm happy to create a separate issue and PR to specifically add 23 support, but this seems like a better solution

This can be closed now


Bugfix/pipeline updates

Added admin mappings for food prices, removed filter on refugee data, updated population data to add non-standard age categories and fix issue in SLV.
While I was editing, I also changed the list in conflict_event to set.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 93.315%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
1340

Relevant Lines:
1436

💛  - Coveralls


Mp4 seeds

Trello
https://trello.com/c/BsSnzw9E/50-make-seeds-contain-mp4s
Seed with MP4s
-We are delivering the final content to users from an S3 bucket as MP4s.
-setting up the video seeds to align with this goal.
-the related song seeds are updated to match
-minimizing differences among environments to improve testability.
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x] Test A - Postman tests of routes to ensure relocation didn't break code
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

this PR ended up piggybacking into PR #23   on  VideosTable_status branch
Already in master. CLosing the pr


GlobalsHelperFn type validation crashes for list types or validation functions

Problem statement
The *Globals classes defined in https://github.com/cloudtools/troposphere/blob/main/troposphere/serverless.py have some properties with their type specified as [T] or as validation functions (e.g. validate_memory_size). They all inherit from GlobalsHelperFn which does not handle those types during runtime type validation, all it does is feed them into isinstance which ends up throwing:
TypeError: isinstance() arg 2 must be a type or tuple of types

Steps to reproduce
from troposphere.serverless import FunctionGlobals
FunctionGlobals(MemorySize=3072)

I've noticed BaseAWSObject has proper handling for such types here for validation functions and here for lists. Something similar needs to be used for the Globals.

I am currently studying the project. Will try to come up with a solution and submit a PR.


Clean up After Test DBs

Cleans up test dbs created during tests.
Moves current "deletes" to defer after creation, which prevents orphan dbs from being left behind when a test errors out.

Coverage remained the same at 71.192% when pulling 41032ee365ee80dc2c5ce336f7fc7ce4b0a7a475 on ryanjyoder:clean_up_test_dbs into 6b4d7cae132ba0ae071f0cb6cdf9f84bb20d60c7 on zemirco:master.

Coverage remained the same at 71.192% when pulling 0a735fea5f3c093b04a59fbf982f67b8c7375b79 on ryanjyoder:clean_up_test_dbs into 6b4d7cae132ba0ae071f0cb6cdf9f84bb20d60c7 on zemirco:master.


make demo failing

Description
I cloned the net plugin repo into my Ubuntu Xenial development machine. "make demo" failed to execute correctly.
Expected Behavior
Make would execute successfully.
Observed Behavior
Make terminated with the following error:
==> netplugin-node1: Skipping Go reinstall
==> netplugin-node1: Removed symlink /etc/systemd/system/multi-user.target.wants/NetworkManager.service.
==> netplugin-node1: Removed symlink /etc/systemd/system/dbus-org.freedesktop.NetworkManager.service.
==> netplugin-node1: Removed symlink /etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service.
==> netplugin-node1: Remove the unneeded ceph repository if it exists
==> netplugin-node1: Loaded plugins: fastestmirror
==> netplugin-node1: Cleaning repos: base docker-main-repo epel extras rdo-qemu-ev updates
==> netplugin-node1:               : yum.dockerproject.org_repo_main_centos_7_
==> netplugin-node1: Cleaning up everything
==> netplugin-node1: Docker 1.12.6 is already installed
==> netplugin-node1: Cleaning up the Docker directory
==> netplugin-node1: Redirecting to /bin/systemctl stop  docker.service
==> netplugin-node1: mkdir: cannot create directory ‘/etc/systemd/system/docker.service.d’: File exists
==> netplugin-node1: [Service]
==> netplugin-node1: Environment="no_proxy=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,localhost,netmaster" "http_proxy=" "https_proxy="
==> netplugin-node1: Redirecting to /bin/systemctl restart  docker.service
==> netplugin-node1: Running provisioner: shell...
netplugin-node1: Running: inline script
==> netplugin-node1: Running provisioner: shell...
netplugin-node1: Running: inline script
==> netplugin-node1: ++ echo '#!/bin/bash'
==> netplugin-node1: ++ echo 'etcd --name netplugin-node1 --data-dir /var/lib/etcd  -heartbeat-interval=100 -election-timeout=5000  --listen-client-urls http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001  --advertise-client-urls http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001  --initial-advertise-peer-urls http://<IP_ADDRESS>:2380,http://<IP_ADDRESS>:7001  --listen-peer-urls http://<IP_ADDRESS>:2380  --initial-cluster netplugin-node1=http://<IP_ADDRESS>:2380,netplugin-node1=http://<IP_ADDRESS>:7001,netplugin-node2=http://<IP_ADDRESS>:2380,netplugin-node2=http://<IP_ADDRESS>:7001,netplugin-node3=http://<IP_ADDRESS>:2380,netplugin-node3=http://<IP_ADDRESS>:7001 --initial-cluster-state new'
==> netplugin-node1: ++ chmod +x /usr/bin/etcd.sh
==> netplugin-node1: ++ cp /opt/gopath/src/github.com/contiv/netplugin/scripts/etcd.service /etc/systemd/system/etcd.service
==> netplugin-node1: cp: cannot stat ‘/opt/gopath/src/github.com/contiv/netplugin/scripts/etcd.service’: No such file or directory
==> netplugin-node1: ++ echo '#!/bin/bash'
==> netplugin-node1: ++ echo 'consul agent -server  -bootstrap-expect=3  -bind=<IP_ADDRESS> -data-dir /opt/consul'
==> netplugin-node1: ++ chmod +x /usr/bin/consul.sh
==> netplugin-node1: ++ cp /opt/gopath/src/github.com/contiv/netplugin/scripts/consul.service /etc/systemd/system/consul.service
==> netplugin-node1: cp: cannot stat ‘/opt/gopath/src/github.com/contiv/netplugin/scripts/consul.service’: No such file or directory
==> netplugin-node1: ++ systemctl daemon-reload
==> netplugin-node1: ++ systemctl enable etcd
==> netplugin-node1: Failed to execute operation: No such file or directory
==> netplugin-node1: ++ exit 1
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
Makefile:132: recipe for target 'start' failed
make: *** [start] Error 1
Steps to Reproduce (for bugs)

$ cd ~/repos/
$ git clone git@github.com:contiv/netplugin.git
$ cd netplugin
$ export GOPATH=pwd
$ make demo

Your Environment

Ubuntu  Xenial operating system
Master branch of netgplugin (latest commit: 7ff78e84a70626b9aee429c83fb357cb81df8a45)

According to our Vagrantfile, if you have a GOPATH set, the netplugin directory needs to be at $GOPATH/src/github.com/netplugin
If you don't have one set, the current directory is shared at the correct location inside the VM.
If you do have a GOPATH set, the expectation is that your entire GOPATH should be shared into the VM in case you are building the code from scratch.  A bunch of the Makefile targets use the same Vagrantfile to bring up a VM used to compile the code.
We should modify the instructions to point out that you must create the netplugin repo in the correct spot if GOPATH is set.

Please reopen the issue if you are still having issue with the instructions in the README


Decide what and how to expose the values

Some decisions have to be made regarding #605

What value should be set and get for each class(databuffer, model, layers, optimizers...)

This directly relates what we should print and save to a model format.

To what extent we are going to expose the values for each classes

This will decide how each object should be printed. (bitflags and presets)

:octocat: cibot: Thank you for posting issue #608. The person in charge will reply soon.