With position:absolute doesn't stop loading

Version
2.4.3
Vue.js version
v2.5.21
Reproduction Link
https://jsfiddle.net/qfb1yL7v/
Steps to reproduce
Change the example to use position:absolute (and add object properties to have a 'top' value).
What is Expected?
That the loading of more data doesn't occur until the user scrolls down the the bottom.
What is actually happening?
Loading all pages occurs immediately.

This problem was caused by the layout, because this component cannot get list height through it's offset position. So you can add position: relative and top value for the InfiniteLoading component, and make sure it always at the bottom of the list, it will works properly.
Note: if you want to use position: absolute for this component, you must declare a valid width for it.


release link 404 :)

Hi, just a heads that the mac dl link on https://automerge.github.io/pushpin/ is a 404. Latest release dmg from gh page works great!

windows dl link also 404.

windows dl link also 404.


scrcpy -S parameter have BUG!!!

After starting with the scrcpy -S parameter, the screen can be turned off to start, but the screen will go black after about four or five minutes, and then the phone must be on to display it in real time...

but the screen will go black after about four or five minutes,

It goes black because it goes to sleep (whether the screen is turned off or not), doesn't it?

但是大约四五分钟后屏幕会变黑，

它变黑是因为它进入睡眠状态（无论屏幕是否关闭），不是吗？

This is indeed the case, thank you!


Demo: Superadmin + Admin details don't work

In the demo, the superadmin and admin login credentials do not work. Probably someone hitting 'forgot password' ?

Hi,
I dropped the forgot password route and refreshed the DB / seeds and it's working again.
Thanks for the update.


FI-3161: ID Token

Summary

Add support for openid and fhirUser scopes.
Return an ID Token in addition to access token. I followed this spec.

~I chose to always return the ID token, regardless of whether the SUT requested the openid and fhirUser scopes. This is because it would add complexity to check which scopes they requested, and I didn't see any harm in always returning an ID Token.~
Update: I added consideration of OpenID scopes to avoid potentially misleading the tester: https://github.com/inferno-framework/davinci-dtr-test-kit/pull/24/commits/221eaf105d347e8f9c948f6c0abe9af39a89eff2

This just hard codes in the Practitioner from the DTR bundle on the reference server

This doesn't mock any kind of identity provider

Expose a new JWKS endpoint, in case the client needs to verify the ID token signature to function.

Testing Guidance

Exercise the SMART App suite's authorization steps, including fetching the smart configuration, fetching the JWKS, make an authorize request, make a token request
Run against the SMART App Launch test kit

Pushed two commits to fix and improve various things with OpenID and verified with the SMART Launch test kit.
Ready for review again @karlnaden

I need better instructions for how to run this using the postman collection. Specifically, the authorize and token requests I wasn't able to get to work.

I need better instructions for how to run this using the postman collection. Specifically, the authorize and token requests I wasn't able to get to work.

In what way were they not working? You should only need to set the base_url variable and then send the requests when the suite is in a wait. If you saw a 404 on the Authorize request(s), that's just because the response to Authorize is a redirect, and Postman attempts to follow the redirect. You can see the 302 if you look in the console.


Find All References Broken For Live Share

Issue Type: Bug
When I had someone connected to my live share session, he reported that Find All References just says loading and it keeps hanging.
VS Code version: Code 1.21.0 (9a199d77c82fcb82f39c68bb33c614af01c111ba, 2018-03-07T11:04:09.969Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz (4 x 3192)

Memory (System)
15.92GB (0.23GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe C:\Development\opie-js

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-npm-source
dku
1.0.0

gitlens
eam
8.1.1

EditorConfig
Edi
0.12.1

tslint
eg2
1.0.28

prettier-vscode
esb
1.2.2

auto-close-tag
for
0.5.6

auto-rename-tag
for
0.0.15

vsliveshare
ms-
0.2.206

debugger-for-chrome
msj
4.2.0

autoimport
ste
1.5.3

JavaScriptSnippets
xab
1.5.0

Reproduces only with extensions

Moved to https://github.com/MicrosoftDocs/live-share/issues/171


[Feature] Classwise metrics for YOLO

Prerequisites
Please answer the following question for yourself before submitting an issue.

[x] I checked to make sure that this feature has not been requested already.

1. The entire URL of the file you are using
https://github.com/tensorflow/models/tree/master/official/vision/beta/scripts
2. Describe the feature you request
A clear and concise description of what you want to happen.
Add classwise AP.
3. Additional context
Add any other context about the feature request here.
4. Are you willing to contribute it? (Yes or No)

Similar implementation:
Definition https://github.com/whizzmobility/models/blob/master/official/vision/beta/evaluation/classification_metrics.py
Usage https://github.com/whizzmobility/models/blob/master/official/vision/beta/tasks/image_classification.py#L214


fix(ui): metadata

:tada: This PR is included in version 1.24.1 :tada:
The release is available on:

GitHub release
v1.24.1

Your semantic-release bot :package::rocket:


[Feature] Raspberry (ARM) support

Hi!
Appsmith is amazing, and it can be incredible if we can install this tool on a Raspberry (Or any other ARM devices). I think i'm not the only one to use the raspberry (or any other alternative) as a server.
Because docker is already supported, you "only" need to create a docker ARM image of Appsmith. If install.sh can also be updated for a fully automated installation, it can be really amazing.
Thanks!

@Hantlowt Do you have any experience with docker on ARM devices? Would love some help here because we have no experience with ARM devices. Perhaps you could make a contribution for this?

Hi @areyabhishek, i have some experience on this device, let me some time to evaluate the necessary work for this feature and i think i can do a pull request :)

@Hantlowt thanks for opening this issue! Have you happened to have any progress on this?


Optimization for partition columns using generation expressions

When a partition column is using a generation expression, for example, a partition column day is defined as cast(eventTime as date), we may be able to generate a partition filter when a query has a data filter (for example, we can generate day <= '2021-12-31' from a filter eventTime < 2021-12-31 23:59:59).

@zsxwing  Is it resolved in Delta 1.2 release?

@gatorsmile yep, it's in 1.2. good catch!


Get a list of articles/translations in a language

I believe there is a WordPress plugin that is similar to Drupal Views, need to see if that is supported by WPML.

This is the plugin similar to Drupal's Views, it also supports WPML.
https://wordpress.org/plugins/content-views-query-and-display-post-page/
I'm adding it on the dev site now: https://dev-science-in-school.pantheonsite.io/wp-admin/admin.php?page=content-views
If we decide to use it, we'll most likely need the pro license to get ACF support and perhaps some other needed features: https://www.contentviewspro.com/features/
It's $39 https://www.contentviewspro.com/pricing/


IME flyout window is far away from application window (DPI issue?)

Environment
Windows build number: 10.0.21331.1000 rs_prerelease arm64
Your Distribution version: Ubuntu 20.04
Your WSLG version: 0.2.13

Steps to reproduce

Pick up a device with HiDPI monitor without vGPU driver installed, e.g. Surface Pro X
Install IME package ibus, ibus-pinyin; Install random app like gedit
Configure ibus in IBus Preferences, confirm to start IBus daemon, add Chinese/Pinyin input method, configure IME switch key to avoid collision with Windows, keep the window open to keep IBus daemon open

In another WSL window, start gedit: GTK_IM_MODULE=ibus gedit
Switch to IME, type something, watching the IME candidate flyout window going randomly everywhere.

WSL logs:

pulseaudio.log
version.txt
weston.log

Expected behavior
It should follow text in the editor as usual. For example:

Actual behavior
The IBus candidate selection flyout window goes everywhere. Also app is in 200% scale while the IME is 100%.

Should this issue be a documentation PR at https://github.com/MicrosoftDocs/WSL ?  I can still see this in WSLg 1.0.42.  I think changing the DPI is a sad solution.

I must point out that I cannot see this problem in Wslg 1.0.45 and microsoft-edge 107.0.1418.42. This seems to be a problem that the application itself needs to solve. I use pengwin WSL and ibus.


Add Twitch extractor

Fix #98

Coverage increased (+0.04%) to 97.676% when pulling 63f0926eb6ac4317ca15903ec8e35882c9a0a142 on extractor-twitch into 30f3405326099c06bef129f0696d55b5d26675f7 on master.


Need ability to distinguish multiple standalone devtool instances

What problem does this feature solve?
We have an application that swaps iframes, so we need to run  multiple versions of the standalone devtools listening on different ports and it's difficult quickly determine which devtools instance matches the currently active iframe.
What does the proposed API look like?
The most simple solution I can think of is simply appending  "- <host>:<port>" to the title bar of the electron shell.

Fixed in 72d00f11de5bb7e57b960377ee41fc8197c2bb16 (display page title)


Illegal Invocation / Infinite Digest on deep $watch if a property is a DOM or jQuery object.

Example JSBin:
http://jsbin.com/favorinava/6/edit
Steps to reproduce:

Create a scope.
Set a property on the scope to a DOM element.
Create a $watch on the scope and set the objectEquality property to true.

angular.module('app', [])
  .controller('SomeCtrl', function($scope) {
    $scope.data = {
      test: document.body
    };

    // No problem
    $scope.$watch('data', function(newVal) {}, false);

    // Problem
    $scope.$watch('data', function(newVal) {}, true);
  })

I do not know what you are trying to do, but watching DOM elements/jQuery elements is not something planned to be supported any time soon

Not to mention horrible performance implications of doing so.... It would be interesting to understand what is going on, though. But yeh, we should actively discourage people from watching DOM objects and their properties as part of the digest loop.

I'm not trying to watch a DOM object and I agree with both of your comments. I noticed this bug with angular-ui-sortable. This module does a deep watch on its sortOptions which can contain a DOM/jQuery object. The intention isn't to watch the DOM object itself but it gets scooped into the deep watch just the same causes the infinite loop and illegal invocation errors.
Here is my bug on that project: https://github.com/angular-ui/ui-sortable/issues/330
I dug deeper into the problem and found I could replicate it with vanilla angular.js so the bug wasn't in ui-sortable but in angular. The problem is causes by the deep watch doing an angular.copy of the scope object, which attempts to do a deep copy of the DOM object. I don't think this is intended functionality and angular.copy should not attempt to copy DOM objects.
Here is my pull request: https://github.com/angular/angular.js/pull/11006

Hi, Sorry, I just do not agree with this issue nor with the solution provided at #11006. In fact, the only real solution would be that if any DOM element goes into angular.copy then we should throw (regardless if this element is the one being copied of within the structure being copied).
This will be a breaking change, so can not happen in a point release.
@petebacondarwin WDYT?

My PR does throw if any DOM element goes into copy.
The other side of this is if you're doing a deep watch on any object if it finds a DOM/jQuery object in that object it will not attempt to copy it.
I don't think this is a breaking change. If anyone has done a copy or deep watch on an object containing a DOM object their application is already broken.

I think we're in agreement, maybe I'm not explaining correctly.

I don't want to copy DOM objects. And don't think you should be able to.
I don't want to watch DOM objects. And don't think you should be able to.
Current angular watch tries to watch and copy DOM objects. Which is impossible because of illegal invocation and infinite digest loop. My PR stops copy on a DOM object. My PR throws an error if you try to copy a DOM object.

Hi, the PR allows this to be valid and not throw
it("should not throw an exception if a copied object contains a DOM and/or Element.", function() {
  var src = {a: document.body, b: angular.element(document.body)};
  var dst = {};
  expect(function() { copy(src, dst); }).not.toThrow();
});

and it should throw. Anything that is part of the DOM should never go into a $watch

It copies a and b to dest but does not attempt to copy document.body recursively.
There is valid cases for having a DOM object on an object being watched though.
https://github.com/angular-ui/ui-sortable/blob/master/src/sortable.js [297 - 332]

@iamchairs this looks simply wrong, deep watching on any structure that ends up in a DOM should be illegal. In this specific case, the right solution is to use $watchCollection and not a deep watch.

Then there needs to be an update to throw when this happens. Otherwise, illegal invocation, infinite digest, browser crashes.

and I would be ok with a change to angular.copy to throw when some elements are being asked to be copied. Eg window, document or a DOM element. This implies that when deep copying a structure that contains any of these elements should throw too.

You can close this out. No need to update my PR because this doesn't solve my problem. Back to angular-ui-sortable!


BUG cdk8s.Include: unable to determine protocol from url: ${url}

Description of the bug:
I am unable to make the Include work in Python to include a .yaml file.
I have tried many things to get it to work.

relative path
absolute path
file:// protocol
single quoting inside the string

Reproduction Steps:
cdk8s.Include(self, "tools", url=f"./manifests/tools-deployment.yaml")

Error Log:
cdk diff --all

/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js:26
    throw new Error(`unable to determine protocol from url: ${url}`);
    ^

Error: unable to determine protocol from url: ./manifests/tools-deployment.yaml
    at Object.<anonymous> (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js:26:11)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
    at node:internal/main/run_main_module:17:47
jsii.errors.JavaScriptError:
  Error: Command failed: /usr/local/Cellar/node/16.8.0/bin/node /private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js ./manifests/tools-deployment.yaml
  /private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js:26
      throw new Error(`unable to determine protocol from url: ${url}`);
      ^

  Error: unable to determine protocol from url: ./manifests/tools-deployment.yaml
      at Object.<anonymous> (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js:26:11)
      at Module._compile (node:internal/modules/cjs/loader:1101:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
      at Module.load (node:internal/modules/cjs/loader:981:32)
      at Function.Module._load (node:internal/modules/cjs/loader:822:12)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
      at node:internal/main/run_main_module:17:47

      at checkExecSyncError (node:child_process:826:11)
      at Object.execFileSync (node:child_process:864:15)
      at loadurl (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/yaml.js:106:28)
      at Function.load (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/yaml.js:75:22)
      at new Include (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/include.js:24:37)
      at /private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/tmpl6if523q/lib/program.js:8367:58
      at Kernel._wrapSandboxCode (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/tmpl6if523q/lib/program.js:8795:24)
      at Kernel._create (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/tmpl6if523q/lib/program.js:8367:34)
      at Kernel.create (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/tmpl6if523q/lib/program.js:8108:29)
      at KernelHost.processRequest (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/tmpl6if523q/lib/program.js:9692:36)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/infra/app.py", line 46, in <module>
    kube_apps = KubeAppsStack(
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/jsii/_runtime.py", line 86, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/infra/infra/apps/kube_apps.py", line 79, in __init__
    SdmChart(
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/jsii/_runtime.py", line 86, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/infra/infra/apps/sdm/sdm.py", line 48, in __init__
    tools = cdk8s.Include(self, "tools", url=f"./manifests/tools-deployment.yaml")
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/jsii/_runtime.py", line 86, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/cdk8s/__init__.py", line 1096, in __init__
    jsii.create(self.__class__, self, [scope, id, props])
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/jsii/_kernel/__init__.py", line 290, in create
    response = self.provider.create(
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/jsii/_kernel/providers/process.py", line 344, in create
    return self._process.send(request, CreateResponse)
  File "/Users/kevinglasson/Development/LITEC/sdm/src/cloud/venv/lib/python3.9/site-packages/jsii/_kernel/providers/process.py", line 326, in send
    raise JSIIError(resp.error) from JavaScriptError(resp.stack)
jsii.errors.JSIIError: Command failed: /usr/local/Cellar/node/16.8.0/bin/node /private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js ./manifests/tools-deployment.yaml
/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js:26
    throw new Error(`unable to determine protocol from url: ${url}`);
    ^

Error: unable to determine protocol from url: ./manifests/tools-deployment.yaml
    at Object.<anonymous> (/private/var/folders/z1/7z6ky5t17dx1mdp9z66rqx000000gn/T/jsii-kernel-A4AAec/node_modules/cdk8s/lib/_loadurl.js:26:11)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
    at node:internal/main/run_main_module:17:47

Subprocess exited with error 1

Environment:
# python
Python 3.9.7

# pip
cdk8s==1.0.0b46

# yarn / npm
cdk8s-cli==1.0.0-beta.50

This is :bug: Bug Report

Okay, this was my fault.
This is a part of a larger 'cdk' application and I was accidentally passing through the wrong 'scope'. Once I changed it to a 'cdk8s.App()' like it's supposed to be it worked fine!


Aggregate Pipeline: sample doesn't seem to work

@Lhdang88 commented on Sun Jun 17 2018
expected Behavior:
collection('a').aggregate([{ $group: {...} },  {$sample: {size: 1}}])

returns 1 random document, from group-stage (results size is > 1)

Behavior:

returns the first/ not random document

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: a2ce2348-ba9d-8af5-7379-50aa7557379d
Version Independent ID: 71513a03-96c9-98da-a97b-59de20ecb335
Content: Azure Cosmos DB-Featureunterstützung für MongoDB
Content Source: articles/cosmos-db/mongodb-feature-support.md
Service: cosmos-db
GitHub Login: @alekseys
Microsoft Alias: alekseys

@v-maudel commented on Mon Jun 18 2018
Hello, @Lhdang88 ,

Thank you for your feedback.

We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hi team,
I'm moving this one from the de-DE repo since the contributor reported a bad example.
Kind regards,
Microsoft DOCS International Team

@CeciAc Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

hello ! Do you have any updates ?

@Lhdang88 Currently Azure Cosmos DB MongoDB API implementation of $sample does not return a random document. This is a bug we will fix in a future update. As a workaround, you could generate a random value on the client side and use it as part of the query to select a random document.

#please-close

Hi,
I have a cosmosdb instance using mongo API. In this db, I have a sharded collection. I am wondering, if aggregation pipeline is supported on a sharded collection?

@Blackbaud-RajRaulji Please see the following Blog Post: Azure #CosmosDB extends support for MongoDB aggregation pipeline, unique indexes, and more
Here is the announcement: Azure Cosmos DB supports aggregate functions

Here is some additional documentation pertaining to the supported Mongo syntax: MongoDB API support for MongoDB features and syntax
If you should happen to have additional questions, please open a new GitHub issue from the last link above (navigate to bottom of page, in Feedback section). Thanks, Mike

hi, have there been any updates in the last two years here? I am using $sample in Cosmo in July 2020 and it still does not seem to work

@SnehaGunda Please help regarding this issue.


Added lazy variadic and and or and also unary not

Codecov Report

Merging #29 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   99.67%   99.68%   +<.01%
==========================================
  Files           1        1
  Lines         607      625      +18
==========================================
+ Hits          605      623      +18
  Misses          2        2

Impacted Files
Coverage Δ

dist/karet.util.cjs.js
99.68% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5255170...83764bb. Read the comment docs.


add rollback explanation to docker service update command document

Signed-off-by: erxian<EMAIL_ADDRESS>Hi, this PR refers to issue https://github.com/docker/docker/issues/29758, adds the explanation of  --rollback option to docker service update command document,  which locates in /docker/docs/reference/commandline/service_upate.md.
- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@aaronlehmann Hi aaronlehmann, very appreciate for all your careful checking, it looks much much better after the correction.  And this is almost the first time I begin to write document ,  I literally feel the great kindness and respect from the open source team, thanks again for your help.

Thanks for making the corrections! I'm happy to see this being added to the CLI reference docs.

@aaronlehmann Thanks for your feedback, I've already updated the docker service update content, please check it.

LGTM


Source
What is your build target?
Mac
Did you edit anything in this build? If so, mention or summarize your changes.
if the folder name counts, then yes, i added -3 to the main folder because thats the third psych engine main folder i have

Me too.


facetByOptions per collection, rather than universally

Description
I have two indexes that share a field name, but would like to sort the facets in one and not the other. Currently I can set this globally in the typesense adapter config.
Perhaps this should be treated similarly to collectionSpecificSearchParameters instead, to allow for collection specific facetByOptions configuration.
Steps to reproduce
facetByOptions: {
	brand: '(sort_by: _alpha:asc)',
},

Expected Behavior
collectionSpecificFacetByOptions: {
	products: {
		brand: '(sort_by: _alpha:asc)',
	}.
},

Actual Behavior
Globally configured/sorted facet lists, rather than collection specific.
Metadata
Typesense Version: typesense/typesense:0.26.0.rc41
<EMAIL_ADDRESS><EMAIL_ADDRESS>

@pixelmaven Just added the ability to specify collectionSpecificFacetByOptions in v2.8.0-4. Could you give it a shot and let me know how it goes?

@jasonbosco Looks good on my end, thanks!

Awesome, thank you for confirming and thank you for catching this!


Clarify UWA (Pheme) maxlength

Clarify that truncation only happens on the change password field and not the login field, which is why the subsequent untruncated login doesn't work. Also highlight maxlength attribute in the inspector screenshot.
I made two additional commits (yawnoc/dumb-password-rules@5f4ad98d, yawnoc/dumb-password-rules@b688cac5) on the uwa branch of my fork. I think GitHub isn't detecting the 4 older commits as already merged since the merge (#326) squashed them into the single commit 2eb2e9f8.
(In hindsight I should have properly synced and made a new branch, or just done everything on master. Sorry!)

Unfortunately it says "These conflicts are too complex to resolve in the web editor". Perhaps I should just redo the PR on master.

Re-opened pull request after resolving conflicts.

Thanks!


Can't $ nvm run

$ nvm run 0.11
Running node v0.11.15      <- "freezes" here, no caret
                           <- pressed enter
                           <- again

2+2                        <- entered expression

^C> undefined              <- pressed Ctrl-C
> undefined
> undefined
> 4
> undefined
>
paqmind@Paqmind:~$

It doesn't depend on node version. Tried $ nvm run 0.11, $ nvm run default, etc.
Same result. OS = last debian. Nvm was installed with linuxbrew (fresh install, everything updated)
$ nvm ls
    v0.10.35
->  v0.11.15
default -> unstable (-> v0.11.15)
stable -> 0.10 (-> v0.10.35) (default)
unstable -> 0.11 (-> v0.11.15) (default)

nvm run by itself is just supposed to open the node repl. Typically, you'd do nvm run 0.11 --version or some other command. Alternatively, you can run nvm exec 0.11 node --version.
However, homebrew is a completely unsupported way to install nvm. Please uninstall it, and use the install command on the readme: curl https://raw.githubusercontent.com/creationix/nvm/v0.23.0/install.sh | bash and then try again?

Please uninstall it, and use the install command on the readme: curl

Done. Same issue. Node on itself is runnable:
paqmind@Paqmind:~$ which node
/home/paqmind/.nvm/v0.11.15/bin/node
paqmind@Paqmind:~$ node
>

Ah - this is because nvm run runs its node command in a subshell, to avoid altering the current shell.
This is either a bug, because nvm run should error out when you provide no arguments, or a broken feature, because "no args" should drop you into the repl.
In the meantime, you can do nvm exec 0.11 node to get a repl in whatever version you like.

Thank you! Confirm that nvm exec 0.11 node works.


Invalid regular expression: Unterminated group - on parentheses

I have a lot of data that I search that has strings with parentheses, eg:
[
{"tag": "CA005", "name": "Los Angeles (California)"},
{"tag": "CA003", "name": "San Diego (California)"},
{"tag": "WA002", "name": "Seattle (Washington)"},
]
The script will detect and find the name well, but if I begin to include the parentheses (or backspace to try to select a new location), the script will error in console with a RegEx error about the unterminated group.
Is there any way we could automatically apply a filter to sanitize the input phrase first and escape characters like Parentheses?  I'd be happy to try to help if you can suggest which function I should try working with.  I'm guessing it's likely the function match() or function findMatch(), but I haven't looked too closely.
Awesome work overall, thank you so much for such a great resource!

I just got the same problem.
I resolved it by using the option "method" of the object "match" like so :
options : {
    match : {
        enabled : true,
        method : function(element, phrase) {
               return element.indexOf(phrase) !== -1;
        }
    }
}

by searching the source code, I found the default method is equivalent to :
function(element, phrase) {
return element.search(phrase) !== -1;
}
and String.prototype.search convert "phrase" to a Regex.
this is not what a end user would expect.


x/playground: nondeterministic errors should not be cached

https://play.golang.org/p/61WfGtE17MQ is an example of a runtime OOM error being cached indefinitely. We don’t distinguish between a compile-time error (deterministic) and runtime error like OOM (nondeterministic).
See golang/tour#541 for examples of this popping up in the tour, but since the playground runs all these snippets, it’s not tour-specific.
@ysmolsky

Can we consider every exit through panic as nondetermenistic or just "fatal error: runtime"?

I wouldn't say every exit through panic should be treated as nondeterministic and not be cached. I think we can look at the bugs linked in the original meta issue (golang/tour#531) and construct a blacklist to look at to determine whether something should not be cached.


golint error for one of the method in etcdops.go

#1661 introduces following, make build is also complaining about the same.
$ make -s build
drivers/shared/etcdops.go:89:39: exported func NewKvStore returns unexported type *shared.etcdKVS, which can be annoying to use

/CC @tusharnt

oops. thanks for catching this.
It's strange that I didn't see this error in either local or CI testing...
Is it a warning or error?

I found the CI testing of this PR:
https://ci.vmware.run/vmware/docker-volume-vsphere/1384
CI returns success while in the beginning it gave this warning:
$ make -s build
drivers/shared/etcdops.go:89:39: exported func NewKvStore returns unexported type *shared.etcdKVS, which can be annoying to use
warning: no packages being tested depend on github.com/vmware/docker-volume-vsphere/client_plugin/drivers/shared
warning: no packages being tested depend on github.com/vmware/docker-volume-vsphere/client_plugin/shared_plugin

Is it possible to fail CI if there is a warning?
And regarding to this warning, it will be gone when we finish the refactoring of the shared plugin.

Hey @luomiao, our build script is not strict for golint or pylint warnings/errors due to time constraints and we have an issue open to make python code to compliant with pylint warning. Post vmworld it is possible to restrict the build incase of such warning till then we have to look manually while proposing the new code change.
It will be great if you can supply a quick fix or include any of your ongoing PR to turn off such warning. Since #1661 merged all our builds are having such warning.

Resolved in https://github.com/vmware/docker-volume-vsphere/pull/1687


Complete the Regex building code

The first commit adds a huge number of tests that were failing because of some unimplemented aspects of Regex string building.
The second commit implements the specific features of the Regex building code to fix the failing tests.
Need to run benchmarks to check if this introduces regressions in the Phonetic conversion code.
Thanks!

Should we go for a more generic name like Matcher instead of Phonetic for our public struct?

Should we go for a more generic name like Matcher instead of Phonetic for our public struct?

Or just Parser, same as the file/module name, following Rust convention?

I have addressed your review, thanks!

Or just Parser, same as the file/module name, following Rust convention?
Parser seems to be conventional :+1:
If we do the naming change, how about changing the name of regex_patterns.rs to regex_parser.rs of simply regex.rs?

I have just pushed the renaming commit- "Phonetic" to "Parser". Please rebase.
Regarding the name of the regex file, it's up to you. Choose whichever makes more sense.

Benchmarks:
group                    after                                  before
-----                    -----                                  ------
okkhor ami               1.02    269.9±3.36ns        ? ?/sec    1.00    265.0±2.42ns        ? ?/sec
okkhor bistarito         1.03    698.0±8.70ns        ? ?/sec    1.00    679.7±7.87ns        ? ?/sec
okkhor kormo             1.02    420.0±7.14ns        ? ?/sec    1.00    411.6±5.12ns        ? ?/sec
okkhor long word         1.03   548.8±10.35ns        ? ?/sec    1.00    532.8±7.03ns        ? ?/sec
okkhor new               1.00     22.5±0.31µs        ? ?/sec    1.00     22.4±0.30µs        ? ?/sec
okkhor sentence 1        1.02  1527.6±15.06ns        ? ?/sec    1.00  1505.0±17.88ns        ? ?/sec
okkhor sentence 2        1.01      5.2±0.04µs        ? ?/sec    1.00      5.1±0.06µs        ? ?/sec
okkhor sonar bangla      1.02  1369.0±13.02ns        ? ?/sec    1.00  1342.0±12.26ns        ? ?/sec


Support replaced modules

The kubernonsense go.mod uses replace to pin their dependencies. This bad technique has leaked into repositories which extend kubernetes. I think we can support this use-case with the following 2 behaviours.

Don't skip replaced modules in gomajor list
If a required module is replaced with the exact same version, gomajor get will update both the required and and replaced version.

Replaced modules are no longer skipped in gomajor list, but I don't think I want to automatically update replace directives.


Bug: Default 'nb_words' value should be set in 'Tokenizer' constructor

Summary
Initializing keras.preprocessing.text.Tokenizer without any arguments results in a MemoryError. This appears to be because the variable nb_words is not set. Setting this to 1000 in the constructor fixes this issue. Suggested fix: if nb_words is not set using an argument it should have a sensible default.
See the script below for an example.
bug.py - script to reproduce error
Run this script after downloading and unzipping the attached data file (17MB). Change the value of the SOURCE_FILE variable to point to the unzipped file.
import io
import json
import keras
from keras.preprocessing import text

SOURCE_FILE = "/tmp/reddit_titles"
with open(SOURCE_FILE, "r") as f:
    data = json.load(f)

data = [d.encode('ascii') for d in data]

tk = text.Tokenizer() # Change this to fix: tk = text.Tokenizer(nb_words=1000)
tk.fit_on_texts(data)
tfidf = tk.texts_to_matrix(data, mode="tfidf")

Traceback (MemoryError)
Traceback (most recent call last):
  File "bug.py", line 13, in <module>
    tfidf = tk.texts_to_matrix(data, mode="tfidf")
  File "/home/sumanas/Documents/python/keras/local/lib/python2.7/site-packages/Keras-1.0.7-py2.7.egg/keras/preprocessing/text.py", line 167, in texts_to_matrix
    return self.sequences_to_matrix(sequences, mode=mode)
  File "/home/sumanas/Documents/python/keras/local/lib/python2.7/site-packages/Keras-1.0.7-py2.7.egg/keras/preprocessing/text.py", line 191, in sequences_to_matrix
    X = np.zeros((len(sequences), nb_words))
MemoryError

Using Keras version:
$ git describe --abbrev=4 HEAD
1.0.7-40-g090b

Desc
Version

OS
Ubuntu 14.04.5 64-bit

Python
2.7.6

Numpy
1.11.1

DATA FILE: reddit_titles.zip (17MB)

This isn't really a bug. If the file you read is too large for your memory, you need to limit it.
If the function would enforce some arbitrary number (making some wrong and soon-to-be outdated assumptions of users' memory capabilities), it would be quite harmful for more powerful machines since it discards data by default and you don't get any warning message. The current implementation forces you to stop and make a decision, so it is more transparent than capping it at "1000".


English menus

Since source code comments and some dialogs are already in English, menus in hsed.exe need to be translated too. They seem to be in poppad.rc file in hsed3 folder. Here is incomplete version, maybe someone can finish it?
Poppad_en.zip

This repository is unofficial mirror.
I forwarded to official tracker.
http://dev.onionsoft.net/mantis/view.php?id=24

Okay. Unfortunately i don't understand japanese (google translated), apparently the link needs account to view.

Merged


promtool: check only exp_labels/exp_annotations

Proposal
Currently tests check that all of labels/annotations match in alert and test descriptions and use reflect.DeepEqual for .
It makes tests inconvenient to work with dynamic labels/annotations.
Would be great if exp_labels/exp_annotations will be checked and other will be just ignored.
For example:
We have annotations set like this:
"summary": "Azure MySQL storage warning",
"description": "Azure MySQL free storage < 20%. You have to increase the storage size or clean it up",
"value": "{{ $value }}"

So we don't wanna test real value annotation value.
So we'll declare test annotations like this:
"exp_annotations": {
  "summary": "Azure MySQL storage warning",
  "description": "Azure MySQL free storage < 20%. You have to increase the storage size or clean it up"
},

What do you think?

That wouldn't be correct, as in the case of labels the full label set are the identity of the alert so you'd miss unwanted labels being let through. Also, how would you test that a label/annotation was missing or empty? Missing and empty labels are the same thing semantically.
For a given test the output of these will always be identical, so it shouldn't be hard to copy&paste to keep things in sync.

I don't understand the problem with missing or empty label. From my pov there is no problem. Can you give some context here?
However I'm not sure about unwanted labels/annotations. May be some kind of strictness flag can help with this.

I don't understand the problem with missing or empty label. From my pov there is no problem. Can you give some context here?

How would you assert that a given label should not be present?

However I'm not sure about unwanted labels/annotations. May be some kind of strictness flag can help with this.

I personally don't see the need, it's not particularly difficult to provide the full set of labels that are generated. The goal of the unittests is to test what the alert is up to after all.

We have looked at this during our bug scrub and decided to close this. We think that the current behaviour is correct and that there are sufficient workarounds (like copy and paste) to deal with this.
Thanks!

@dgl as you are the appointed unit test expert, please reconsider this feature request. I cannot emphanize the points made by @alexanderabramov  enough. We are currently adopting prometheus and have a lot of annotations that do not need to be covered by all test. Copy & pasting is error prone and creates visual noise, which hinders test adoption.

#11033 is implementing a basic regexp matching on annotations.


Set up documentation on readthedocs

With #35 finished, we can set up the docs build on readthedocs.
Follows up on #29

Closed by #45


[Bug] gt_bboxes_ignore is not being used is almost all models

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (master) or latest version (3.x).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
master branch https://github.com/open-mmlab/mmdetection
Environment
sys.platform: linux
Python: 3.8.8 (default, Apr 13 2021, 19:58:26) [GCC 7.3.0]
CUDA available: True
GPU 0,1,2,3: Tesla V100-PCIE-16GB
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 11.1, V11.1.105
GCC: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
PyTorch: 1.9.0
PyTorch compiling details: PyTorch built with:

GCC 7.3
C++ Version: 201402
Intel(R) oneAPI Math Kernel Library Version 2021.2-Product Build 20210312 for Intel(R) 64 architecture applications
Intel(R) MKL-DNN v2.1.2 (Git Hash 98be7e8afa711dc9b66c8ff3504129cb82013cdb)
OpenMP 201511 (a.k.a. OpenMP 4.5)
NNPACK is enabled
CPU capability usage: AVX2
CUDA Runtime 11.1
NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_37,code=compute_37
CuDNN 8.0.5
Magma 2.5.2
Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.1, CUDNN_VERSION=8.0.5, CXX_COMPILER=/opt/rh/devtoolset-7/root/usr/bin/c++, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow
-Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.9.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

TorchVision: 0.10.0
OpenCV: 4.5.3
MMCV: 1.6.0
MMCV Compiler: GCC 7.5
MMCV CUDA Compiler: 11.1
MMDetection: 2.25.0+bacbb47
Reproduces the problem - code sample
all configs
Reproduces the problem - command or script
all configs
Reproduces the problem - error message
all configs
Additional information
The primary purpose of loading gt_bboxes_ignore during the dataset pipelines is so that we can ignore loss computation in those regions of ignore/crowd. However, I see that all the configs in mmdetection do not "collect" gt_bboxes_ignore in the Collect step of the data pipelines. Is gt_bboxes_ignore usually ignored in the trainings?

@levan92 Hi. The mmdet 3.x branch already supports ignore data processing. but most models still don't take this data into account. YOLOv5 in MMYOLO has already implemented ignore processing, you can refer to https://github.com/open-mmlab/mmyolo/blob/main/configs/yolov5/README.md#crowdhuman

Thanks for your prompt reply! It does seems like in the mmyolo implementation of YOLOv5, they have taken account to ignore the grids associated to the ignore regions.
It is interesting to note that we have been ignoring the "crowd" and "ignore" attribute labels all these while, this is not a dataset specific problem, in fact in COCO, there are already images with "iscrowd" boxes. For example (grey bbox is labelled with iscrowd):

From your understanding, does this mean that all these while, during training, if the model predicts a person instance in the "crowd" region and it does match with any GT labels (because it is already covered by the "iscrowd" box), the model is still getting penalised (adds to its loss) for this false "false positive"? Is it the case that such occurrences are not too detrimental to model training?


Update renovatebot/github-action action to v40.1.10

This PR contains the following updates:

Package
Type
Update
Change

renovatebot/github-action
action
patch
v40.1.9 -> v40.1.10

Release Notes

renovatebot/github-action (renovatebot/github-action)
v40.1.10
Compare Source
Documentation

update references to ghcr.io/renovatebot/renovate to v37.296.0 (28c9d13)
update references to renovatebot/github-action to v40.1.9 (e56f8be)

Miscellaneous Chores

deps: update dependency @types/node to v20.12.5 (6493f07)
deps: update dependency @types/node to v20.12.6 (5e0357e)
deps: update dependency @types/node to v20.12.7 (0bab1e7)
deps: update dependency semantic-release to v23.0.8 (d257912)

Build System

deps: update dependency typescript to v5.4.5 (9f91d7c)

Continuous Integration

deps: update renovate docker tag to v37.288.0 (2f815db)
deps: update renovate docker tag to v37.290.1 (bd23b98)
deps: update renovate docker tag to v37.291.0 (723c2d4)
deps: update renovate docker tag to v37.292.0 (e5a18cd)
deps: update renovate docker tag to v37.292.1 (98e5856)
deps: update renovate docker tag to v37.293.0 (5a8e3f9)
deps: update renovate docker tag to v37.295.0 (3c412db)
deps: update renovate docker tag to v37.296.0 (8f9c0fe)
deps: update renovate docker tag to v37.300.0 (3d3b001)
deps: update renovate docker tag to v37.301.5 (19373a3)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[x] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!"  You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Relate 'isLog' to a figure instead of XY axis set?

Currently, the flag 'isLog', which indicates whether the plot is on a linear or logarithmic scale, is associated with each set of axes. This allows users to collect data with different scales (e.g., linear scale on the first axis set and logarithmic scale on the second axis set).
However, I think the scale for each X and Y axis should be associated with the figure as a whole, not with individual axis sets.
Additionally, when considering integration with Starrydata3, there may be discrepancies in the data, as we plan to associate the scale with the entire figure.
The key question is whether there could ever be different scales within a single figure. My assumption is that there wouldn't be. If there were, users could simply treat the data as belonging to separate figures, right?
To clarify, I am thinking of relating both xIsLog and yIsLog with a figure domain which have to be newly created.
What do you think? @t29mato
(we can also discuss in our team MTG)

In Starrydata3, each Figure corresponds to one XY axis. Therefore, when integrating StarryDigitizer with Starrydata3, the functionality for multiple XY axes will need to be turned off.
So, the user needs to change the figure when 1 figure has multiple xy axes.


Broken images in admin menu on Safari

Found a bug? Please fill out the sections below. 👍
Issue Summary
When logging in to admin there are three or four broken images over the left hand menu. It seems to be an issue with Safari browser.
Steps to Reproduce
Log in to admin on Safari v11.0

Technical details

Python version: Run python --version.
2.7.10
Django version: Look in your requirements.txt, or run pip show django | grep Version.
1.9.1
Wagtail version: Hover over the Wagtail bird in the admin, or run pip show wagtail | grep Version:.
1.5
Browser version: You can use http://www.whatsmybrowser.org/ to find this out.
Safari 11.0

Thanks for the report @juliaranne. When we've seen similar issues elsewhere (#3809 #3811), it's just needed a force-refresh to fix - please can you try holding down shift while clicking the refresh button in the location bar?
(Also, you say you're using Wagtail 1.5 but your screenshot shows 1.12.2 - is 1.5 the result of running pip show wagtail | grep Version:? Having two conflicting versions of Wagtail probably wouldn't help here.)

Refreshing, clearing my cache/history doesn't seem to work for this.
Yes, my mistake I'm running version 1.12.1 locally. We have another website using Wagtail version 1.13 where there's no problem, so seems it's just an issue with Safari and Wagtail version 1.12?

Thanks for taking the time to look at this in multiple versions of Wagtail!
This part of the code has been changed a bit in 1.13 as part of the work on the new 404 page, although I don't see how this would have failed before. Reference: #3705, https://github.com/wagtail/wagtail/compare/stable/1.12.x...stable/1.13.x#diff-af73d62081be0b72ac854d96958429fb.
I can't reproduce this in the latest Wagtail (2.0a) either, so I think we can assume it was fixed in 1.13.  Closing.


improving the design of search bar

will enhance the look of the search bar
will align it to the center for the sake of user experience

I want to work on this issue...please assign it to me

Hello, @sourabhsikarwar  I have experience with the technologies involved in working on this issue. I would like to make a valuable contribution to this repo. Can u assign this issue to me ??

Hi , I am contributor under GSSOC'23 and I am eager to showcase my skills and make a meaningful contribution to this project.
Kindly assign me this issue.@sourabhsikarwar

i want work on this


Rz/rename leverage

Title
Changes 👷♀

merge current dev
renaming leverage/Leverage to multiply/openMultiply/OpenMultiply
changed path from leverage to open-multiply

How to test 🧪

- step 1 ...
Definition of done ✔

[ ] Acceptance criteria for each issue met
[ ] Unit tests written where needed and passing
[ ] End-to-end tests for happy path
[ ] Documentation updated
[ ] Project builds without errors
[ ] Non-functional requirements met
[ ] Code reviewed and functionality tested by the reviewer (locally, Heroku, etc.)
[ ] Feature verified and accepted by Product Owner
[ ] Project deployed to production environment

why rz/vault-form  is the base?


[Dialog] full screen demo breaks with long list

The fullscreen dialog demo works fine with limited number of items. However when the list exceeds the screen height, the demo breaks. The title disappears and the list does not scroll.
Below is the fullscreen demo with a list of 100 items:

And the same demo with 5 items:

The code example can be found under https://codesandbox.io/s/kx38pykqkr

Tech
Version

Material-UI
1.0.0-beta.9

I guess we could be adding a flex-shrink: 0 here
https://github.com/callemall/material-ui/blob/f8998c1a04c267ee598f8fc44eb606a5b67f7822/src/AppBar/AppBar.js#L12-L17

Do you want to submit a PR to fix it? :)

I will try and give you feedback today.

Adding flex-shrink: 0 does solve the problem. And I see no harm in adding it to the root style of AppBar though theoretically it does not belong there.
I submitted a PR #8192, but do not know how to reference it in this issue.


[BUG] race condition during mass-backpromote

if multiple targets are selected in mass-backpromote, the copado deploy function will be executed more or less in parallel.
that CAN (with high probability) lead to the errors during git push.
why? the second one to execute git push will be asked to execute git pull first.
solution: we'll have to run git push in a for-loop and optionally execute git pull before until git push succeeded

YOU: git pull
OTHER: git pull
YOU: git commit
OTHER: git commit
OTHER: git push
YOU: git push --> ERROR, need to exec git pull first
--> YOU: git pull, git push (maybe merge in between???)
let success = false;
do {
try {
 git push
 success = true;
} catch(ex) {
if(somebodyElsePushedFirst) {
git pull
}
} while(!success)

instead of we might have to to do

git fetch origin master
git checkout master
git checkout promotion-branch
git rebase master
git checkout master
git merge promotion-branch
git push origin master

not sure about no. 1+2 - I want to update my local master branch?

another approach from Nahuel:
try every second for up to 50 seconds to push merging the changes. In case of git conflicts, this will fail with "exit 1"
for i in {1..50}; do
# fetch the latest changes, if any
git fetch origin "$target_branch" || exit 1
# force to checkout that branch discarding any previous merge
git checkout --force "$target_branch"
# merge the promotion branch, and in case of conflicts
git merge "$promotion_branch" || exit 1
git push origin "$target_branch" || { sleep 1; continue; }
break
fi

what seems like the final code:
# update local reference to online version of master
git fetch origin master

# discard local version of master and reset it to orgin/master
git reset --hard origin/master

# re-do the merge of our promotion branch
git merge promotiont/P-00001


Add scrolling to 'view group'

Codecov Report

Merging #229 (574eeed) into master (029814b) will increase coverage by 1.15%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
+ Coverage     54.65%   55.80%   +1.15%
- Complexity      747      757      +10
============================================
  Files           160      160
  Lines          3297     3322      +25
  Branches        362      369       +7
============================================
+ Hits           1802     1854      +52
+ Misses         1373     1336      -37
- Partials        122      132      +10

Impacted Files
Coverage Δ

...ress/logic/commands/groups/DeleteGroupCommand.java
100.00% <ø> (ø)

...ddress/logic/commands/groups/ViewGroupCommand.java
100.00% <ø> (ø)

...ss/logic/commands/persons/DeletePersonCommand.java
100.00% <ø> (ø)

...ress/logic/commands/persons/EditPersonCommand.java
78.23% <ø> (ø)

...ress/logic/commands/persons/FindPersonCommand.java
100.00% <ø> (ø)

...ress/logic/commands/persons/ViewPersonCommand.java
100.00% <ø> (ø)

src/main/java/seedu/address/model/group/Group.java
33.73% <0.00%> (-0.79%)
:arrow_down:

src/main/java/seedu/address/model/task/Task.java
67.74% <0.00%> (-2.26%)
:arrow_down:

src/main/java/seedu/address/ui/PersonViewCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
76.28% <44.44%> (-3.49%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029814b...574eeed. Read the comment docs.


Distorted images

When I generate my images it expands every layer over the entire canvas leaving a stretched out mess
any ideas on what would cause my error?

i am new to this but your layers need to be the same size. then positioned over one another correctly. so 1000 x 1000 or 100 by 100. good luck


AOE indicator on the field?

Is this a feature on this addon? Or is there any other plugin that does this for the latest raids?

Can you clarify the question? This addon provides a 'radar' window that shows various aoes, it doesn't draw them in game world directly (at least not yet, that shouldn't be particularly hard to implement...)


Error: config.privateKeyPath does not exist at given fs path

Hello.
I'm setting up VS Code with a connection to IBM i and am attempting to connect using SSH. I have generated keys and verified the SSH connection using the terminal with command ssh userID@hostName.  I successfully get into -bash-
But when I try to connect from the server pane and click  the 'connect to IBMi' triangle, I get error "config.privateKeyPath does not exist at given fs path".
I have seen a suggestion to remove the -----BEGIN.... and -----END.... lines from the private key file and re-register it, but this made no difference.
Maybe I need to make a manual adjustment to the config - how do I locate the config file where config.privateKeyPath is registered?
Any suggestions would be appreciated.
James

Context
Version

Code for IBM i version
2.14.3

Visual Studio Code version
1.95.3

Operating System
win32_x64

Active extensions
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.5.0
Configuration Editing (configuration-editing): 1.0.0
Emmet (emmet): 1.0.0
Git (git): 1.0.0
Git Base (git-base): 1.0.0
GitHub (github): 0.0.1
JSON Language Features (json-language-features): 1.0.0
MDOpen for MDCMS 8.5.x (mdopen-8-5): 0.0.35
Merge Conflict (merge-conflict): 1.0.0
NPM support for VS Code (npm): 1.0.1
Node Debug Auto-attach (debug-auto-launch): 1.0.0
TypeScript and JavaScript Language Features (typescript-language-features): 1.0.0
WSL: Recommender (remote-wsl-recommender): 0.0.19

Not connected 🔌

Hi @kemp76, this is a known bug.
See #2361 for the explanation and a workaround.

Thanks so much for your help - very quick :-)

Just an extra comment - I'm running VS Code on Windows and I had to specify the path to private key using double backslash :
"privateKeyPath": "C:\Users\userID\.ssh\id_ed25519"


feat: Add GetCities, GetCityStreets, GetOutagesByAddress APIs

What changes do you are proposing?
feat: Add GetCities, GetCityStreets, GetOutagesByAddress APIs
How did you test these changes?
manually
Closing issues

GetOutagesByAddress - requires a header: recaptchtoken
For now, not sure where to get it from...

/question did my last commit fixed anything?

/reflect_and_review

/answer

No, the data is rather static.
Yes, I want to allow the user to pass either City object (result of get_city for example) or just the UUID (to skip the city fetching if the user already has the ID in hand).
I tested this through the following flow:

        city = await client.get_city("חיפה")
        print(city)

        street = await client.get_city_street_by_name(city, "הרצל")
        print(street)

        outages = await client.get_outages_by_address(city, street, house_num="1")
        print(outages)

/review -i


React 18

Would be nice to try for React 18, any plans? 👍
`npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: wernissage@undefined
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm ERR!   node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/nextportal
npm ERR!       nextportal@"*" from the root project
npm ERR!   1 more (react-dom)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>

Hello, @codcodea. Thanks for raising this issue, I'll look into it. Alternatively, you can also create a PR with the updated dependency.

Hi @codcodea, could you kindly describe how to reproduce the error in detail? Looking at the error logs, I just updated one of my project's react version to 18+ that uses nextportal to check if I get the same error, but it worked just fine. So if you could describe how to reproduce the error, I can inspect and make a fix accordingly. Thank you.


"list your deployment of uPortal alongside  the many others already registered" link is broken

In the Please Register portlet the "list your deployment of uPortal alongside  the many others already registered" link is broken

Question @apetro and @drewwills, Who for uPortal, or in general, has access to update the Apereo website?

It bugs me how much effort it takes to get small changes into the Apereo site.
I'm starting a GitHub pages based redesign that can (hopefully) replace the existing site.
Pull requests are welcome at https://github.com/ChristianMurphy/apereo.foundation


Print the Equivalent Non-interactive Command

closes #56

Prints the equivalent non-interactive command with flags and values
Only does this when in interactive mode (when no flags are set by the user)

Demo:
https://github.com/Melkeydev/go-blueprint/assets/70033855/960ffedb-4fb2-4fd0-9587-1b52373505f0

Let me know what you think of this tiny lil feature I added @Melkeydev, I think it might be useful in the future, tried to make it as future proof as possible.
Also, I'm not sure if I like the message, so feel free to suggest a change, or change the message directly yourself 👍

W rizz


Docs: explain index files for server routing

Describe the feature
The server routes documentation is missing a basic folder structure scenario, implying you are familiar with file-based routing structure.
It doesn't explain you can prefix files with index, like index.get.ts.
It unlocks using a folder for crud operations like:
articles
  - index.get.ts
  - index.post.ts
  - index.delete.ts

Or being able to cover routes like /articles and /articles/upcoming.
articles
  index.get.ts
  upcoming
    index.get.ts

Additional information

[X] Would you be willing to help implement this feature?

PR more than welcome to improve nitro docs 🙏🏼

Awesome I wanted to wait for feedback from the team before starting working on it. I'll land a PR!

@geromegrignon please a PR would be huge for this!
Using your example, I had my routes configured like this:
src/api/v1
  - articles.get.ts
  - articles.post.ts
  - articles.delete.ts
src/api/v1/articles
  - upcoming.get.ts
  - upcoming.post.ts

It drove me crazy because I couldn't find any examples of doing this any other way while having a feeling it was possible and I was missing something. I only found this because my OCD finally had enough and I decided to spend an hour going through nearly every issue until I came across this.

Hi @ilyafish, sure I'll work on it tomorrow! Glad it already helped!


Carousel's index reset when I'm swiping carousel

This is my Code :
    self.carousel = SwiftCarousel(frame: CGRect(origin: CGPointZero, size: CGSize(width: 574, height: 455)))

    try! self.carousel!.itemsFactory(itemsCount: self.eventsStorage.count, factory: {
        choice in
        let baseUrl = "http://www.eventyk.com/events-media/"
        let url = NSURL(string: "\(baseUrl)\(self.eventsStorage[choice].imageNamed)")
        let data = NSData(contentsOfURL: url!)
        let imageView = UIImageView(image: UIImage(data: data!))
        imageView.frame = CGRect(x: 0.0, y: 0.0, width: 574, height: 455)
        print(imageView)
        return imageView
    })

    self.carousel!.resizeType = .VisibleItemsPerPage(1)
    self.carousel!.delegate = self
    self.carousel!.defaultSelectedIndex = 1
    self.carouselView.addSubview(carousel!)

What's wrong?

Hey @aluco100! 🎉 Can't really tell from the code above... Would you be so kind to put it somewhere on github, on the clean project where you can reproduce the bug? It would be a lot easier to investigate the issue and help you resolve it. Thanks! 🐼

Hey @sunshinejr there's my project:
https://github.com/aluco100/Eventyk
Regards

Hey @sunshinejr, Is the above issue fixed. I noticed the same problem.


feat: 🎸 update SubQuery to the latest version

Description
update subquery dependency to the latest version. This resolves an issue where bulkUpdate would not work when workers were enabled
Breaking Changes
BREAKING CHANGE: 🧨 updated_at field removed from tables
JIRA Link
DA-1236
Checklist

[ ] Updated the Readme.md (if required) ?

Approving, but one question -> does this require re-sync as well?

It needs a resync. The migration code isn't compatible since updated_at is required.


MudTextField in mudialog DialogContent it not Font Typo.caption change

Bug type
Component
Component name
Muddialog
What happened?
MudTextField in mudialog DialogContent it not Font Typo.caption change
Help me please
Expected behavior
I want MudTextField in Mudialog DialogContent  Font change
Reproduction link
https://try.mudblazor.com/snippet/mkmouBkndlHDCdnL
Reproduction steps

...
Relevant log output
No response
Version (bug)
7.0.0
Version (working)
7.0.0
What browsers are you seeing the problem on?
Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It looks ok to me

The typo is meant to change the content but not the label


Unable to test multipart/form-data requests with httpc-test

Issue Description:
I'm currently working on a Rust backend using Actix Web, where I have implemented a POST route to handle multipart/form-data requests for saving images to disk. However, I'm encountering challenges when testing this functionality using the httpc-test library.
Issue Description:
I've created a POST route that handles multipart/form-data requests and saves images to disk, but I'm struggling to find documentation or examples on how to effectively test this route using httpc-test. I've also explored the httpc-test source code but couldn't find any solutions that suit my needs.
Request for Help:
I'm looking for guidance or examples on how to test this multipart/form-data request using httpc-test properly. Additionally, I already know how to do this using cURL, and the cURL command I use is as follows:
curl -F<EMAIL_ADDRESS>http://localhost:8080/post --trace-ascii

I want a similar functionality using httpc-test
Thank you for your help in advance!

Now, we exposed the .reqwest_client() and .client_store() as per your suggestion, so, should be ok. See #77cedfb
Feel free to open a new ticket if something is still missing.


Error when Running IKE for Wiki Counterfactual dataset

Hello,
When running
python run_knowedit_llama2.py
--editing_method=IKE
--hparams_dir=../hparams/IKE/llama-7b
--data_dir=./data/test_cf.json
--datatype='counterfact'
I am getting the error
File "/EasyEdit-main/examples/easyeditor/models/ike/util.py", line 15, in encode_ike_facts
neighbors = train_data['locality_prompt']
KeyError: 'locality_prompt'
Should this part of the code be changed for the WikiCounterfactual data?
def encode_ike_facts(sentence_model: SentenceTransformer, ds: Dataset, hparams: IKEHyperParams):
sentences = []
for i, train_data in enumerate(ds):
    new_fact = train_data['prompt'] + ' ' + train_data['target_new']
    target_new = train_data['target_new']
    paraphrases = train_data['rephrase_prompt']
    neighbors = train_data['locality_prompt']
    neighbors_ans = train_data['locality_ground_truth']
    sentences.append(f"New Fact: {new_fact}\nPrompt: {new_fact}\n\n")
    sentences.append(f"New Fact: {new_fact}\nPrompt: {paraphrases} {target_new}\n\n")
    sentences.append(f"New Fact: {new_fact}\nPrompt: {neighbors} {neighbors_ans}\n\n")

embeddings = sentence_model.encode(sentences)
base_path = f'{hparams.results_dir}/{hparams.alg_name}/embedding'
os.makedirs(base_path, exist_ok=True)
safe_model_name = hparams.sentence_model_name.rsplit('/', 1)[-1]
with open(f'{base_path}/{safe_model_name}_{type(ds).__name__}_{len(ds)}.pkl', "wb") as fOut:
    pickle.dump({'sentences': sentences, 'embeddings': embeddings}, fOut,
                protocol=pickle.HIGHEST_PROTOCOL)

Please let me know how should we correct this error.

Hello, IKE currently does not support Wiki counterfact and Wiki recent datasets; we will update the code in the future.
Provisionally, I recommend you change the data format to build the train data memory for easy usage.

Just in your edit() function add one line code:
metrics, edited_model, _ = editor.edit(
    prompts=prompts,
    target_new=target_new,
    subject=subjects,
    locality_inputs=locality_inputs,
    portability_inputs=portability_inputs,
    train_ds=datas,
    keep_original_weight=True
)

you can also push newest code, we also fix it.

Hi, thank you for the guidance, but even if I add train_ds=datas, it gives the following error:

Is it because encode_ike_facts() is not called which actually writes the .pkl file (Error 1 shown below)? and
should train_ds take the training data (train_cf.json) as input (datas is the test_cf.json file right since we are using
python run_knowedit_llama2.py
--editing_method=IKE
--hparams_dir=../hparams/IKE/llama-7b
--data_dir=./data/test_cf.json
--datatype='counterfact'

Error 1
Traceback (most recent call last):
File "EasyEdit-main/examples/run_knowedit_llama2.py", line 301, in
metrics, edited_model, _ = editor.edit(
File "EasyEdit-main/examples/../easyeditor/editors/editor.py", line 221, in edit
edited_model, weights_copy, icl_examples = self.model, {}, self.apply_algo(
File "EasyEdit-main/examples/../easyeditor/models/ike/ike_main.py", line 31, in apply_ike_to_model
with open(f'{hparams.results_dir}/{hparams.alg_name}/embedding/'
FileNotFoundError: [Errno 2] No such file or directory: 'EasyEdit-main/examples/results/IKE/embedding/all-MiniLM-L6-v2_KnowEditDataset_2.pkl'

Yes,you should call encode_ike_facts() to get all-MiniLM-L6-v2_KnowEditDataset_2.pkl
encode_ike_facts() stores the knowledge you previously edited, while the editor inputs the knowledge you currently need to edit.

So how do we solve this error? Since run_knowedit_llama2.py does not call encode_ike_facts(). Is this a bug?
Error
Traceback (most recent call last):
File "EasyEdit-main/examples/run_knowedit_llama2.py", line 301, in
metrics, edited_model, _ = editor.edit(
File "EasyEdit-main/examples/../easyeditor/editors/editor.py", line 221, in edit
edited_model, weights_copy, icl_examples = self.model, {}, self.apply_algo(
File "EasyEdit-main/examples/../easyeditor/models/ike/ike_main.py", line 31, in apply_ike_to_model
with open(f'{hparams.results_dir}/{hparams.alg_name}/embedding/'
FileNotFoundError: [Errno 2] No such file or directory: 'EasyEdit-main/examples/results/IKE/embedding/all-MiniLM-L6-v2_KnowEditDataset_2.pkl'

We haven't tested wiki_counterfact in IKE in our previous experiments, so it has some problems.
I am working to improve this part and will let you know when it's up!
Provisionally, you can refer to run_zsre_llama.py and try to add encode_ike_facts(), good luck!

Now we have support IKE method for KnowEdit.Just pull the newest code, and use the code below for generate your own all-MiniLM-L6-v2_KnowEditDataset_2.pkl,and do not forget change your hparam about  'sentence_model_name' to load right all-MiniLM-L6-v2_KnowEditDataset_2.pkl
from easyeditor import  IKEHyperParams
from easyeditor import KnowEditDataset
from easyeditor.models.ike import encode_ike_facts
from sentence_transformers import SentenceTransformer

hparams = IKEHyperParams.from_hparams('./hparams/IKE/llama-7b.yaml')
train_ds = KnowEditDataset('/mnt/16t/xzk/EasyEdit/data/wiki_counterfact/test_cf.json')
sentence_model = SentenceTransformer(hparams.sentence_model_name).to(f'cuda:{hparams.device}')
encode_ike_facts(sentence_model, train_ds, hparams)

Hi thank you for the update. IKE is now working for Llama2-7b on Wiki Counterfactual dataset but it does not work with GPT2-XL and GPTJ-6B. It produces the following error:
File "/EasyEdit-main/examples/run_knowedit_llama2.py", line 192, in
metrics, edited_model, _ = editor.edit(
File "/EasyEdit-main/examples/../easyeditor/editors/editor.py", line 207, in edit
"pre": compute_icl_edit_quality(self.model, self.model_name, self.hparams, self.tok, [''],
File "/EasyEdit-main/examples/../easyeditor/evaluate/evaluate.py", line 190, in compute_icl_edit_quality
pre_neighbor = icl_lm_eval(model, model_name, hparams, tok, [''], record['locality'][locality_key]['ground_truth'],
File "/EasyEdit-main/examples/../easyeditor/evaluate/evaluate.py", line 249, in icl_lm_eval
target_ids = tokenizer(' ' + target + '\n', return_tensors='pt')['input_ids'].to(device)
TypeError: can only concatenate str (not "list") to str

Now it supports IKE to edit WikiCounterFact, pull the latest code, and try again.
You need to use the training data (train_cf.json) to build the store and I added a new argument train_data_path here.

Thank you, it's working now.


Whitespace is getting stripped from the input when message is edited

4 whitespace added to the beginning of the text renders it as codeblock.
But when edited this message, the whitespace is getting stripped.
This is a compose UI problem.
https://chat.zulip.org/#narrow/stream/3-backend/topic/Use.20of.20**.20aka.20strong

I can work on this.
@zulipbot claim

@mcruz1799 Are you still working on it? Or should I give it a try?

@Pranav2612000 still working on it!

@zulipbot add "area: compose" "bug" "general UI"


Add currency info to the package

Add currency info to the package and update readme file with currency info.

Currency info is added to the package.


no fixed version of self-service-password

I will fordward here as plain as possible some concerns of integrating your container:
https://github.com/zokradonh/kopano-docker/pull/70#discussion_r245222884
I assume that fetching a specific release from should be easily modified by changing this line:
https://github.com/tiredofit/docker-self-service-password/blob/734837f712c8903ce0f97c1a74a44c555e403128/install/etc/s6/services/10-nginx/run#L86
to
git clone --depth 1 --branch v1.3 --single-branch https://github.com/ltb-project/self-service-password /www/ssp
Nevertheless, the second part, the mounting of the service itself in a persistent storage is more difficult in my eyes. We could surely omit the persistent story if this service is stateless and all configuration is passed by the docker env vars. If the service is not stateless, we have to keep the config and should provide update mechanisms when a new ssp version drops in via container update. Do you know about this detail, or should we invite directly https://github.com/ltb-project/self-service-password developers to the discussion?
best,
Christian

Hi, I am the one that raised the "concerns". Just looking through this project for me it actually already feels quite stateless so just rebuilding the config when replacing the container should already work quite good,
The v1.3 in above command also be queried automatically with the following command: git ls-remote --refs --tags https://github.com/ltb-project/self-service-password | sort -t '/' -k 3 -V | awk -F/ '{ print $3 }' | tail -1. Afterwards this would then only need to be tagged in the docker hub.

HI, just to confirm, it is stateless as you have found with the only settings that need to be changed is the configuration file. My production image works in a different manner, where all code is embedded inside the image without the exposed volumes. It could certainly be built like that, however that would limit people from being able to customize any of the images / html templates easily. Moving the install routines into the Dockerfile is quite simple however.
One of the reasons why I've kept it as a static release without always pulling latest release from github is the configuration file. I'm sure there is a much better way to dynamically change any of the options introduced any newer releases. At this time I've kept it to be a pure bash/sed solution, and with each point release has introduced more options to configure. It's dirty and could use some work.
I can also add another tag on Docker Hub to not use my own changelog version number (v1.3), but either a combo (1.3-2.5), or something in between.

Yes I would like to see the installation inside the docker build step, nevertheless I think this is not what we have to focus on. Providing a reproducible state should be the focus. I can live with the point to fetch the repo at runtime, as long as the repo keeps small. Fetching a specific release version should be the main point.
An alternative solution could be to specify the release to fetch via env var. So we could have the split between your configuration set by your image tag and the ssp release version specified by an env var.
So I propose this solution as an minimal invasive one to get the reproducible behavior.


Update Readme to point to http://aka.ms/ros/mrtk for Hololens support

@ooeygui pointed out that the current codebase for using ROS 2 on Hololens is over at http://aka.ms/ros/mrtk_native and http://aka.ms/ros/mrtk, see comment https://github.com/ros2-dotnet/ros2_dotnet/issues/109#issuecomment-1557934885
After looking at it seems the tooling and install instructions over there are way better and more up to date.
Instead of having some duplicate install and setup instructions for UWP/Hololens in the README, we should simply point to the ros_msft_mrtk repo.

@hoffmann-stefan I'd prefer if the references to ros2-dotnet supporting UWP were not removed, I worked quite hard to make sure that all the components in ROS 2 supported UWP (i.e. FastRTPS/FastDDS, rmw, rcl, ros2-dotnet, etc.)
@ooeygui could you clarify what was missing in this repository to support UWP? I asked you in https://github.com/ros2-dotnet/ros2_dotnet/issues/82#issuecomment-945062692 because five years ago we already demoed ros2-dotnet running onboard the Hololens 1, and did all the work to port ROS 2 and ros2-dotnet to UWP

@hoffmann-stefan for reference, this is the talk I gave in 2018 about adding support for UWP to ROS 2 https://roscon.ros.org/2018/presentations/ROSCon2018_ROS2 for Android, iOS and Universal Windows Platform.pdf

@esteve I added a section to the README.md that should better explain the UWP support and how this library contributes to this. The point of this PR is to point to the tooling and install instructions of the Mixed Reality Toolkit for ROS 2, not to remove the references to the UWP support.
Does this address your concerns?


[WIP] Add support for prebuilt libraries, specifically swift-syntax

Following the pattern used for the early Traits work, added a workspace prebuilts manager to co-ordinate detecting when macros are using swift-syntax, downloading the zip file for the resolved swift-syntax version, and extracting it into the scratch directory. We add the necessary information about that to the workspace state. We then morph the Modules that use it to add build settings to find the necessary modules and libraries.

Also, most inspiration comes from binary artifacts. Still signs of the clone in this PR :).
Still lots of clean up to do including taking advantage of the caching and checking checksums.

@swift-ci please test

@swift-ci please test

@swift-ci please test windows

@swift-ci please test.

@swift-ci please test windows.

@swift-ci please test

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

@swift-ci please test

@swift-ci please test

@swift-ci please test windows

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

OK, feels like it's done. Awaiting the tests.

BTW, there will be at least one more PR when I get back from holidays in January to complete the BuildPrebuilts script to add in more docker images and platforms as they come available, and of courses to fix any issues we find during testing, and then to enable this feature by default. I'll post to the forums on how to test with it once this PR finishes review.

All tests pass. Let me know if there's anything else @jakepetroules.


Add script to easily step through buildFetch usage.

Running node --inspect-brk dev/simple-fetch-script.js allows you to more easily step through @data-eden/network's implementation.

unrelated but definitely need to fix the src/dist thing on exports


Animation between activities

Can i use this library for animation between activities? And how?
Thanks in advance

+1

I think it is not so different from play animation in a fragment commit.

Make an activity to be transparent, when play the animation in onCreate method, override the onbackpressed method, play the exit animation and post delay the super.onBackPressed method.


on doc page, some text missing: font color is white the same color with background

hello:
https://lusaxweb.github.io/vuesax/components/notifications.html

ps: my Browser is chrome on windows 10

Ready is already solved the problem is that in the new update of the buttons change the property vs-type


Antialiasing on opengl markers

Reworks few opengl markers to use distance function.
This allow to implement easily antialiasing and fix some floating point glitches.
Before

After

Changelog:

Fixes glitches on OpenGL marker rendering

Looks good, thanks! smoothstep is not available in (old) GLSL 1.20 (OpenGL2.1).
You might end-up with OpenGL2.1 when running through ssh and I'm not sure what version of GLSL you get then.
smoothstep doc provides a corresponding alternative, let's use it.
I can take care of this.

BTW, smoothstep was already used by one of the symbols

smoothstep doc provides a corresponding alternative, let's use it. I can take care of this.

Yes please @t20100 if you know how to do it


Overall docs for CSI Migration feature

Placeholder docs for CSI Migration Alpha: https://github.com/kubernetes/enhancements/issues/625
/cc @davidz627 @leakingtapan

This PR is now ready for docs review.

/lgtm

Good point @msau42. I changed the EBS and Cinder sections for CSI migration to also specify the name. PTAL @leakingtapan

/lgtm

/lgtm

@ddebroy thanks for adding cinder doc
/lgtm

/assign @bradamant3

/lgtm

This now ready to be merged from the docs side.


UWP application new Debug configuration reports TargetedSDKConfiguration = Retail

Steps to reproduce
1.) Use Visual Studio 2017 version 15.9.4 (or above)
2.) Create a new Visual C# -> Windows Universal -> Blank App (Universal Windows)
3.) In Visual Studio's menu select "Build" -> "Configuration Manager..."
4.) In the "Configuration Manager" dialog in the "Configuration" column click the open arrow and select >New...> to create a new configuration
5.) In the "New Project Configuration" dialog enter a name and in the "Copy settings from:" combo box select "Debug" and press "OK"
6.) In Visual Studio's menu select "Tools" -> "Options..."
7.) In the "Options" dialog choose "Projects and Solutions" -> "Build and Run"
8.) In the "MSBuild project build output verbosity:" combo box select "Diagnostic"
9.) Build the newly created configuration
10.) Check the output from the build
Expected  behavior
TargetedSDKConfiguration = Debug
Actual behavior
TargetedSDKConfiguration = Retail
Same problem with C++ UWP.
To workaround the problem you can edit the project file and set explicit   `
 <TargetedSDKConfiguration>Debug</TargetedSDKConfiguration>
for the new configuration's PropertyGroups.
Environment data
Microsoft Visual Studio Enterprise 2017
Version 15.9.4
VisualStudio.15.Release/15.9.4+28307.222
Microsoft .NET Framework
Version 4.7.03190
Installed Version: Enterprise
Visual C++ 2017   00369-60000-00001-AA012
Microsoft Visual C++ 2017
Application Insights Tools for Visual Studio Package   8.14.11009.1
Application Insights Tools for Visual Studio
ASP.NET and Web Tools 2017   15.9.04012.0
ASP.NET and Web Tools 2017
ASP.NET Core Razor Language Services   15.8.31590
Provides languages services for ASP.NET Core Razor.
C# Tools   2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
Extensibility Message Bus   1.1.49 (remotes/origin/d15-8@ee674f3)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.
JavaScript Language Service   2.0
JavaScript Language Service
JavaScript Project System   2.0
JavaScript Project System
JavaScript UWP Project System   2.0
JavaScript UWP Project System
JustDecompilePackage2017 Extension   1.0
JustDecompilePackage2017 Visual Studio Extension Detailed Info
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package
MLGen Package Extension   1.0
MLGen Package Visual Studio Extension Detailed Info
Mono Debugging for Visual Studio   4.13.12-pre (9bc9548)
Support for debugging Mono processes with Visual Studio.
NuGet Package Manager   4.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.
ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
ResourcePackage Extension   1.0
ResourcePackage Visual Studio Extension Detailed Info
ResourcePackage Extension   1.0
ResourcePackage Visual Studio Extension Detailed Info
SQL Server Data Tools   15.1.61810.11040
Microsoft SQL Server Data Tools
TypeScript Tools   15.9.20918.2001
TypeScript Tools for Microsoft Visual Studio
Visual Basic Tools   2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual F# Tools 10.2 for F# 4.5   <IP_ADDRESS>.  Commit Hash: 6e26c5bacc8c4201e962f5bdde0a177f82f88691.
Microsoft Visual F# Tools 10.2 for F# 4.5
Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio Tools for Apache Cordova   15.123.7408.1
Visual Studio Tools for Apache Cordova
Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake
Visual Studio Tools for Universal Windows Apps   15.0.28307.208
The Visual Studio Tools for Universal Windows apps allow you to build a single universal app experience that can reach every device running Windows 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 Software Development Kit.
VisualStudio.Mac   1.0
Mac Extension for Visual Studio
Windows Template Studio   2.5.18319.1
Windows Template Studio quickly builds a UWP app, using a wizard-based UI to turn your needs into a foundation of Windows 10 patterns and best practices.
Xamarin   <IP_ADDRESS> (d15-9@e3f40b477)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.
Xamarin Designer   4.16.13 (45a16efd4)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.
Xamarin Templates   1.1.128 (6f5ebb2)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.
Xamarin.Android SDK   <IP_ADDRESS> (HEAD/8255f42fc)
Xamarin.Android Reference Assemblies and MSBuild support.
Xamarin.iOS and Xamarin.Mac SDK   <IP_ADDRESS> (65ec520)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.
OS info: Win10 1809

@livarcocc: Issue is that Microsoft.Common.CurrentVersion.targets makes an assumption that configuration can be just Debug or Retail:
  <PropertyGroup>
    <TargetedSDKConfiguration Condition="'$(TargetedSDKConfiguration)' == '' and '_$(Configuration)' == '_Debug'">Debug</TargetedSDKConfiguration>
    <TargetedSDKConfiguration Condition="'$(TargetedSDKConfiguration)' == '' and '_$(Configuration)' == '_Release'">Retail</TargetedSDKConfiguration>
    <TargetedSDKConfiguration Condition="'$(TargetedSDKConfiguration)' == ''">Retail</TargetedSDKConfiguration>
    <TargetedSDKArchitecture Condition="'$(TargetedSDKArchitecture)' == ''">$(ProcessorArchitecture)</TargetedSDKArchitecture>
    <TargetedSDKArchitecture Condition="'$(TargetedSDKArchitecture)' == ''">Neutral</TargetedSDKArchitecture>
  </PropertyGroup>

Can you reactivate the issue? It seems that I cannot do that.

@livarcocc , @rainersigwald … Yes, it appears to be UWP-specific code.


chore: test-python-jenkins to 0.0.38

chore: Promote test-python-jenkins to version 0.0.38

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


TST: ndimage: fix test skip typo

https://github.com/scipy/scipy/pull/22130#discussion_r1894348309

I think the correct change here is just to exceptions=["cupy"], leaving the CuPy xfail alone - right @crusaderky ?

I wasn't entirely sure either, this seemed consistent with other tests such as
    @skip_xp_backends(
        np_only=True, reason='inplace out= arguments are numpy-specific'
    )
    def test_binary_erosion28(self, xp):

https://github.com/scipy/scipy/pull/22130#discussion_r1896807930


Implement NickServ.Recover

Before this command is implemented, it must be determined whether or not the desired behaviour should be a kill or a forced nick change.

I think this should be configurable by the user. If the user sets the RENICK property to on, it will make the default action of NickServ.Recover to change nicknames. But if that is not on it will KILL. I think having RENICK set to on by default is a sensible behavior.

I meant to respond to this sooner. I'm not totally sure about allowing the user to configure it to KILL, but I do think that configuration of whether or not to KILL via the configuration file could be a good idea, even if it just sets what the default for a new account is.


Use Rxjs for event handling wrt communication with the server

Why?

For now, to avoid sending a request for each keystroke without reinventing the wheel. Later, if it proves to be useful, we might use it selectively where it makes sense. Anyway, I'm working on a branch.

@ftomassetti @sergej-koscejev I've tested this and it looks fine. It only affects editableCell for now. If it's OK for you, we could merge this.

Could you open a PR, so we could take a look at the diff and better understand the impact?

Done https://github.com/Strumenta/webeditkit/pull/10


urls are not hyperlinks

If I ssh to a server with hyper and start screen, hyperlinks that show in the terminal are no longer active links.

actually they don't work anywhere. Is there a keyboard command to enable http hotlinks? I did not see anything in settings.
In iterm2 I just do cmd+hover on a link to make it a hyper link. Would be nice to have same behavior.

@anthonyettinger Try adding 'hyperlinks' in the plugins section of ~/.hyper.js
https://github.com/zeit/hyperlinks

As @pdxmike said, you can use https://github.com/zeit/hyperlinks :) closing