No notification received in IOS version 2.0.0

Expected Behaviour
Notification must be received in IOS
Actual Behaviour
Token is well registered but no notification received in background and in foreground. In android everything is working.
I observed lot of errors in the logs. Maybe I am doing something wrong
Reproduce Scenario (including but not limited to)
Steps to Reproduce

Create a development certificate
Upload it in the app settings in developer.apple.com
Download the .cer
Generate a p12 certificat
Upload it to firebase
For the rest see code

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
IOS 10.3.2
Cordova CLI version and cordova platform version
Cordova: 7.0.1
ios: 4.5.1
Plugin version
2.0.0
Sample Push Data Payload
{
  "to" : "<Token>",
  "aps": {
        "alert": "Test push"
    },
  "notId": 1 ,
  "priority" : 8
}

Sample Code that illustrates the problem
const OPTIONS: PushOptions = {
 android: {
   icon: "ic_notification",
   iconColor : "#71a3e2"
 },
 ios: {
   alert: "true",
   badge: "true",
   clearBadge : "true",
   sound: "true",
   fcmSandbox : "true"
 },
 windows: {}
};

...
...

this.pushObject = this.push.init(OPTIONS);

     console.log("Launch registration");
     this.pushObject.on('registration').subscribe((data: any) => {
       console.log("device token -> " + data.registrationId);
       this.token = data.registrationId;
       this.sendToken();
     });

     console.log("Launch notification observable");
     this.pushObject.on('notification').subscribe((data: any) => {
       console.log('notification', data);
       this.handleNotificationReceived(data);
     });

     this.pushObject.on('error').subscribe(error => console.error('Error with Push plugin', error));

This is working on android. I am using Ionic
Logs taken while reproducing problem
This is what I found interesting:
When launching the app:
createNotificationChecker
2017-10-01 16:03:47.931488+0200 <APP>[440:185120] not coldstart
2017-10-01 16:03:47.939392+0200 <APP>[440:185120] active
2017-10-01 16:03:47.939503+0200 <APP>[440:185120] PushPlugin skip clear badge
2017-10-01 16:03:47.977461+0200 <APP>[440:185164] libMobileGestalt MobileGestaltSupport.m:153: pid 440 (<APP>) does not have sandbox access for <ACCESS> and IS NOT appropriately entitled
2017-10-01 16:03:47.977515+0200 <APP>[440:185164] libMobileGestalt MobileGestalt.c:550: no access to InverseDeviceID (see <rdar://problem/11744455>)
2017-10-01 16:03:47.995345+0200 <APP>[440:185167] [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add `[FIRApp configure];` (`FirebaseApp.configure()` in Swift) to your application initialization. Read more: https://goo.gl/ctyzm8.
2017-10-01 16:03:47.995 <APP>[440] <Error> [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add `[FIRApp configure];` (`FirebaseApp.configure()` in Swift) to your application initialization. Read more: https://goo.gl/ctyzm8.

Then for registration:

2017-10-01 16:03:56.328358+0200 <APP>[440:185120] Launch registration
2017-10-01 16:03:56.328378+0200 <APP>[440:185120] Launch notification observable
2017-10-01 16:03:56.337614+0200 <APP>[440:185163] Push Plugin register called
2017-10-01 16:03:56.337667+0200 <APP>[440:185163] PushPlugin.register: setting badge to true
2017-10-01 16:03:56.337745+0200 <APP>[440:185163] PushPlugin.register: clear badge is set to 1
2017-10-01 16:03:56.337762+0200 <APP>[440:185163] PushPlugin.register: better button setup
2017-10-01 16:03:56.340662+0200 <APP>[440:185163] FCM Sender ID<PHONE_NUMBER>322
2017-10-01 16:03:56.340699+0200 <APP>[440:185163] Using FCM Notification
2017-10-01 16:03:56.340899+0200 <APP>[440:185163] Using FCM Sandbox
2017-10-01 16:03:56.346085+0200 <APP>[440:185167] [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add `[FIRApp configure];` (`FirebaseApp.configure()` in Swift) to your application initialization. Read more: https://goo.gl/ctyzm8.
2017-10-01 16:03:56.347 <APP>[440] <Error> [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add `[FIRApp configure];` (`FirebaseApp.configure()` in Swift) to your application initialization. Read more: https://goo.gl/ctyzm8.
2017-10-01 16:03:56.351440+0200 <APP>[440:185223] [Firebase/Analytics][I-ACS005000] The AdSupport Framework is not currently linked. Some features will not function properly. Learn more at http://goo.gl/9vSsPb
2017-10-01 16:03:56.351 <APP>[440] <Warning> [Firebase/Analytics][I-ACS005000] The AdSupport Framework is not currently linked. Some features will not function properly. Learn more at http://goo.gl/9vSsPb
2017-10-01 16:03:56.358488+0200 <APP>[440:185167] [Firebase/Analytics][I-ACS023007] Firebase Analytics v.40002000 started
2017-10-01 16:03:56.358 <APP>[440] <Notice> [Firebase/Analytics][I-ACS023007] Firebase Analytics v.40002000 started
2017-10-01 16:03:56.359002+0200 <APP>[440:185167] [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
2017-10-01 16:03:56.359 <APP>[440] <Notice> [Firebase/Analytics][I-ACS023008] To enable debug logging set the following application argument: -FIRAnalyticsDebugEnabled (see http://goo.gl/RfcP7r)
2017-10-01 16:03:56.359427+0200 <APP>[440:185167] [Firebase/Messaging][I-FCM001000] FIRMessaging Remote Notifications proxy enabled, will swizzle remote notification receiver handlers. Add "FirebaseAppDelegateProxyEnabled" to your Info.plist and set it to NO
2017-10-01 16:03:56.359 <APP>[440] <Notice> [Firebase/Messaging][I-FCM001000] FIRMessaging Remote Notifications proxy enabled, will swizzle remote notification receiver handlers. Add "FirebaseAppDelegateProxyEnabled" to your Info.plist and set it to NO
2017-10-01 16:03:56.368085+0200 <APP>[440:185120] FCM Registration Token: <TOKEN>
2017-10-01 16:03:56.399515+0200 <APP>[440:185120] Push Plugin register success: <405ab148 638a9d45 f101e955 a7cdff19 b121a8e2 8eea3182 60e05680 76b88abd>
2017-10-01 16:03:56.400967+0200 <APP>[440:185165] [Firebase/Analytics][I-ACS032003] iAd framework is not linked. Search Ad Attribution Reporter is disabled.
2017-10-01 16:03:56.401 <APP>[440] <Warning> [Firebase/Analytics][I-ACS032003] iAd framework is not linked. Search Ad Attribution Reporter is disabled.
2017-10-01 16:03:56.404703+0200 <APP>[440:185167] [Firebase/Analytics][I-ACS023012] Firebase Analytics enabled
2017-10-01 16:03:56.404 <APP>[440] <Notice> [Firebase/Analytics][I-ACS023012] Firebase Analytics enabled
2017-10-01 16:03:56.405188+0200 <APP>[440:185167] [Firebase/Analytics][I-ACS003007] Successfully created Firebase Analytics App Delegate Proxy automatically. To disable the proxy, set the flag FirebaseAppDelegateProxyEnabled to NO in the Info.plist
2017-10-01 16:03:56.405 <APP>[440] <Notice> [Firebase/Analytics][I-ACS003007] Successfully created Firebase Analytics App Delegate Proxy automatically. To disable the proxy, set the flag FirebaseAppDelegateProxyEnabled to NO in the Info.plist
2017-10-01 16:03:56.414269+0200 <APP>[440:185120] device token -> <TOKEN>

Then I have no logs related to notification received

@speedfl Had the same issue yesterday, solved it by doing what the error log asks to do: Add FirebaseAppDelegateProxyEnabled to Info.plist as Boolean and set value to either NO or YES ;)

Ah thanks I will have a look. But did you put it to YES or NO ?
On what it is based ?

Don't need it (used for mapping APNS/FCM tokens), I set it to NO

Ok tomorrow I will give you a status at the same hour approximatively !

PS: I'm also using gcmSandbox instead of fcmSandbox I think the docs are incorrect, you could try both.

From what I can see in the code it seems to be fcmSandbox

https://github.com/phonegap/phonegap-plugin-push/blob/2a8e3dff3698710b2e5fed8dea91deaa0705bbdc/types/index.d.ts#L202

Strange...
When you look at this part:
https://github.com/phonegap/phonegap-plugin-push/blob/master/src/ios/PushPlugin.m#L311
It seems that fcmSandbox is used....

Yup, either ways I'm facing issue #1986 there's hasn't been a way for me to know either cases..

@speedfl if you are using v2.0.0 or greater it is fcmSandbox. What version of the FCM cocoapod got installed for you?

Hello,
I am currently at work but I will have a look as soon as I will be back to home.
As I am more an Android Developer I have a bit lost with all that ios stuff.
How can I check the FCM cocoapod version?

Cocoapod version is 1.3.1
  FCModel 0.9.0
  FCMutableArray 1.0
  MOLFCMClient 1.3
  SFCMisc 0.1.0

more Podfile.lock
PODS:
  - FirebaseAnalytics (4.0.2):
    - FirebaseCore (~> 4.0)
    - FirebaseInstanceID (~> 2.0)
    - GoogleToolboxForMac/NSData+zlib (~> 2.1)
  - FirebaseCore (4.0.4):
    - GoogleToolboxForMac/NSData+zlib (~> 2.1)
    - nanopb (~> 0.3)
  - FirebaseInstanceID (2.0.0):
    - FirebaseCore (~> 4.0)
  - FirebaseMessaging (2.0.0):
    - FirebaseAnalytics (~> 4.0)
    - FirebaseCore (~> 4.0)
    - FirebaseInstanceID (~> 2.0)
    - GoogleToolboxForMac/Logger (~> 2.1)
    - Protobuf (~> 3.1)
  - GoogleToolboxForMac/Defines (2.1.1)
  - GoogleToolboxForMac/Logger (2.1.1):
    - GoogleToolboxForMac/Defines (= 2.1.1)
  - GoogleToolboxForMac/NSData+zlib (2.1.1):
    - GoogleToolboxForMac/Defines (= 2.1.1)
  - nanopb (0.3.8):
    - nanopb/decode (= 0.3.8)
    - nanopb/encode (= 0.3.8)
  - nanopb/decode (0.3.8)
  - nanopb/encode (0.3.8)
  - Protobuf (3.3.0)

DEPENDENCIES:
  - FirebaseMessaging (~> 2.0.0)

SPEC CHECKSUMS:
  FirebaseAnalytics: ad41720e3e67fc63fbe3d2948d3e26932a8de311
  FirebaseCore: cfc042628ef9f20debe09c0eb683135fcd404cb4
  FirebaseInstanceID: 9fbf536668f4d3f0880e7438456dabd1376e294b
  FirebaseMessaging: 227406c05b0dc9290702d2e9f18ab5528f0c2cf2
  GoogleToolboxForMac: 8e329f1b599f2512c6b10676d45736bcc2cbbeb0
  nanopb: 5601e6bca2dbf1ed831b519092ec110f66982ca3
  Protobuf: d582fecf68201eac3d79ed61369ef45734394b9c

I added FirebaseAppDelegateProxyEnabled NO to my info.plist and I don't have anymore the log:
2017-10-01 16:03:56.359 <APP>[440] <Notice> [Firebase/Messaging][I-FCM001000] FIRMessaging Remote Notifications proxy enabled, will swizzle remote notification receiver handlers. Add "FirebaseAppDelegateProxyEnabled" to your Info.plist and set it to NO

But I still don't receive notification...

I think I found my issue.
I am using aps node in my payload. But I am using fcm as I am in 2.0.0 so I should send to fcm a notification node in my payload (maybe the Payload documentaion must be updated)
However I tried with only data in the payload and I do not receive notofication.
It is probably the same as :
https://github.com/phonegap/phonegap-plugin-push/issues/1986
In fact data (silent) notification are not received.
I will try tomorrow and will confirm you if with notification node in payload I receive the notification. If yes you will be able to close this issue as dupe of 1986.
However a new one must be open to handle the "only data" messages

So I tried and I am well receiving notification message like thie:
{
  "to" : <Token>
  "notification" : {
        "body": "Test push",
        "title" : "Test"
   }
}

However I am not receiving notification data notification. With format:
{
	"to" : "<TOKEN>",
	"data" : {
		"title" : "Title",
		"message" : "Message",
		"someOther" : "stuff"
	}
}

In android it is workin but not in IOS. Do you maybe have an idea?

@speedfl Please read the docs on FCM/GCM: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#gcm-and-additional-data
Also, if you've already read the docs, and it wasn't clear enough that:

android needs the payload to be on the data attribute
ios needs the payload to be on the notification attribute

then please let us know how we can change the docs so it's clearer.

@fredgalvao I will clear this out, if I may.
FCM does not distinguish between iOS and Android message formats, it's the whole point of the service. The format itself is the same, like so:
{
    "to" : "APA91bHun4MxP5egoKMwt2KZFBaFUH-1RYqx...",
    "notification" : {
      "body" : "great match!",
      "title" : "Portugal vs. Denmark",
      "icon" : "myicon"
    },
    "data" : {
      "Nick" : "Mario",
      "Room" : "PortugalVSDenmark"
    }
  }

If you include the data attribute, this will be sent as additional data along with the notification.

If you don't include the data attribute, users will still be notified but the notification message will not include any additional data.

Now here's the part which I believe you're missing out on: FCM supports two message types,  notification and data-only messages, in the case of latter notification alerts are never triggered.

This means, unlike (1) and (2) above, no notification alerts are presented to the user and the data payload (aka what you're confusing with additional data notification data) is relayed directly to the app so it can be processed there.
More information here: https://firebase.google.com/docs/cloud-messaging/concept-options and here https://firebase.google.com/docs/cloud-messaging/concept-options#data_messages
What @speedfl is referring to is use case (3), what made his comment a bit confusing is including the title attribute in his payload example, it should've been someDummyCustomAttribute. So in the case of FCM data-only messages, those do not arrive and he's right about it.
Hope this clarifies things ;)

Thanks @1N50MN14 for your clarification. It was a bit difficult to explain. But this is the point.
If you want to send data-only messages (which will just update app state but without beeing displayed to the user) this will work on android but not in ios.

@1N50MN14 Thanks for the explanation, although I think I was already on par with those points and what they entail.
My point was, by linking the docs, for the distinction between notification payloads and data payloads on the scope of this plugin, not GCM/FCM itself, to be clearer. Regardless of what FCM supports or encourages, notification payloads will not work on android, and data-only payloads will not work on iOS with GCM/FCM. The examples aim at that, and the explanations try to aim at that (but it seems we're not doing a great job at it, seeing the number of people getting them confused). That's why I asked for help on the docs 😉
Now, if your final sum-it-up of @speedfl 's intentions is correct, I can only guess that @speedfl is mixing up apns with GCM at some point still. Or your payload is missing one of the recommendations/points described here: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#background-notifications-1

Regardless of what FCM supports or encourages, notification payloads will not work on android, and data-only payloads will not work on iOS with GCM/FCM.
This is the part that clarifies it. You treat FCM payloads as GCM ones, everything else is disregarded and irrelevant to this plugin.  You support a subset of FCM to avoid breaking GCM on Android. So for those, like me, that expect this plugin to adhere to the intended FCM purpose/behaviour, should move on. Which I will do now. @speedfl should move on too, and the other people with related/similar open issues. You definitely need to be clear in the docs that FCM is partially supported, imho.  Thanks for your timing clarifying this.

My or @macdonst vision on this is biased, that's specially the reason I ask for people to help on the docs. Your vision on the issue/confusion is clearer, you have approached the topic with doubt and different arguments, I really think contribution from users like you are more relevant than me trying to fix the docs.
Also, I'd wait for @macdonst to give his input on this. I feel there's a bunch of details that would make your statement clearer or closer to the truth than I can help with.

@1N50MN14 I'm sorry we can't meet all of your expectations. Unfortunately the way that Google has setup notifications on Android I need for the payload to be in data instead of notification. I realize that is contrary to what Google suggests but we do our best to explain why at:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#notification-vs-data-payloads
If you look at this table you'll see that the onMessageReceived method is not called when you use the notification payload. This means the plugin can't do things like background processing because the plugin is never notified that a message has arrived.
Even if the payload contains notification and data it's not workable because the OS takes over the display of the notification and we can't do fun stuff like action buttons.
So yes, it is unfortunate that we need to use different payloads on Android and iOS but that is where we are at. However, this can be handled pretty easily by segmenting your users into Android and iOS buckets. When you are sending the registration ID back to your push service you just also include what OS the app is running on.

For the moment I was able to avoid using "silent" notifications.
Android is working perfectly with the payload containing only data (like what is explained in your)
On ios I set notification node (with title and body) and yesterday I was able to receive my first notification. I made lot of try and it worked. However today I am again not able (with same payload used yesterday and correct token) to receive notification.
I will try to debug but I did not change anything on my app between today and yesterday. Can it be linked to my push certificate or something else ?
Anyway you are really doing a good job and as explained android worked perfectly and I was able to have push working on android in only some hours. I am pretty sure the issue on Ios is coming from me.

@speedfl when you are testing with FCM on iOS try setting the priority to high. I've seen some devices/apps run into the problem described here:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#gcm-messages-not-arriving

I already put the priority to "hight"...
I will test retest this weekend. For sure I will find something

@macdonst I want send notifications to both Android and iOS, with the same code. In my backend I can't difference between the os of the devices.
I'm using Firebase to send the notifications
If I send this
{
    "to" : "APA91bHun4MxP5egoKMwt2KZFBaFUH-1RYqx...",
    "notification" : {
      "body" : "great match!",
      "title" : "Portugal vs. Denmark"
    },
    "data" : {
      "Info" : "Some value"
    }
  }

Background iOS: Ok
Foreground iOS: Ok
Foreground Android: Ok
Background Android: When I tap the notification, the app will start but  on('notification') handler will not be called
But if I send this:
{
    "to" : "APA91bHun4MxP5egoKMwt2KZFBaFUH-1RYqx...",
    "data" : {
      "body" : "great match!",
      "title" : "Portugal vs. Denmark",
      "Info" : "Some value"
    }
  }

Background iOS: The notification isn't showed
Foreground iOS: Ok
Foreground Android: Ok
Background Android: Ok
Wicht is the right way to send notifications with the same code for Android and iOS?

@tomilofano You can't. There is no way to send a single payload to both GCM/FCM at the same time for iOS and Android. You will have to differ your users on the backend.

Absolutely the same behavior. It's nightmare. Now I need to distinguish device platform on back-end side when I send notification...

It is simple.
I did it. When you register token you just send the platform type. And before sending notification you check the platform to adapt the payload.

@speedfl Agree. It's simple when your backend could be easily adjusted, but in our case we provides to 'notification service' list of tokens without any meta data (platform and etc) and that's why it's not easy to fix (it's improper design of our back-end of course). For example, cordova-plugin-fcm works different and there is no need to send different payload to ios and android. But, unfortunately, it doesn't support badges for android. And that's why we will make refactoring on backend and stay with plugin-push.

Hey guys, i have the same problem but a bit different.
I receive push notifications pretty well on an ipad with iOs 11.0.3 but on an iPhone 6 with iOS 10.3.3 and i dont receive any push notifications ...
My payload :
$payload = [
'registration_ids' => $this->deviceIds,
'priority' => 'high',
'notification' => [
            'title'=> 'Title msg',
            'body' => 'Body msg',
            'subtitle' => 'Subtitle msg'
],
'data' => ['link' => '',
            'badge' => 1,
            'style' => 'inbox',
            'summaryText' => 'summary test',
            'ledColor' => [0, 0, 255, 0],
            'vibrationPattern' => [200, 200, 200, 200]
],
]

Why does my ipad receive notifications but not my iPhone ? Version 2.0.0

@speedfl is this issue resolved for you?

Hello.
Sorry I had lot of stuff to finished on my app.
I wanted to restart testing tomorrow. I will keep you posted.

So I still not receive notifications.
I will uninstall and reinstall the plugin. And keep you posted

Hello,
So it was what I suspected. This was due to communication issue between apns and fcm.
I removed everything for push configuration (p12) and restarted from scratch with p8 (like explained in fcm doc) and now it is working
Thanks for your help
Regards

There's no clear explanation on how to resolve this issue, i've been struggling with this error for days now.
phonegap-plugin-push 2.2.3 "PushPlugin"
The default Firebase app has not yet been configured. Add `[FIRApp configure];


align or add left margin for pre-footer buttons, page last modified info

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
The Create an issue button, Edit this page buttons, Page last modified banner in the pre-footer for most pages, except the home doc page, could be better aligned on the page and with the page footer.
Proposed Solution:
Add margin or align the pre-footer section (two buttons + page modified banner).
Could make the page modified banner text smaller.
Page to Update:
Most content pages.
ex: https://kubernetes.io/docs/reference/

@kbhawkey I would take this up :+1:

Initial workarounds made out. What do you think?
Old version:-

Now:-


Opening vscode from terminal does not work WSL1 - Option 'disableExtensions' is deprecated, please use 'disable-extensions' instead

Does this issue occur when all extensions are disabled?: No

VS Code Version: x64-1.63.0-insider
OS Version: Windows 10 Enterprise 1909 - WSL 1 -> Ubuntu-20.04

Steps to Reproduce:
code-insiders --verbose
Option 'disableExtensions' is deprecated, please use 'disable-extensions' instead
Invoking: cd "/mnt/c/Users/a.hami-merii/AppData/Local/Programs/Microsoft VS Code Insiders" && ELECTRON_RUN_AS_NODE=1 "/mnt/c/Users/a.hami-merii/AppData/Local/Programs/Microsoft VS Code Insiders/Code - Insiders.exe" "resources/app/out/cli.js" "--ms-enable-electron-run-as-node" "--verbose" "--remote=wsl+Ubuntu-20.04"

Using WSL 1 Open Vscode using the code-insiders command
The following message pops up and vscode does not open -> Option 'disableExtensions' is deprecated, please use 'disable-extensions' instead

Note:

vscode opens when trying to run the same command from powershell. (The message is displayed, but vscode still opens)
vscode opens when using the --disable-extensions flag

Happens on mac too:

I'm also seeing this issue on macOS 11.6.1 and it started happening today.

/duplicate
https://github.com/microsoft/vscode/issues/138122


Missing coverage for Azure SQL Management

Azure Ruby SDK has received feedback that the SQL management spec is missing needed operations. Please add these as soon as possible.
Issue: https://github.com/Azure/azure-sdk-for-ruby/issues/307

I was about doing an issue, we have some feedback that SQL management is needed too in Python.

@yaakoviyun, @akromm - Can you please respond?

@yaakoviyun @akromm Any update of this one?

Our team is looking to migrate to Azure SQL ASAP and so we need this support very badly. Is there any timeline that we can expect for delivery?

@yaakoviyun @akromm - The Sql team please respond with a timeline. Where is this blocked?

@amarzavery @thenewwazoo @lmazuel We have dedicated a couple days (Aug 22-23) in which we plan to grab a couple engineers and do our best to get this done then.  If all goes well and we don't run into any unexpected problems the swagger spec should be done around that time.

@akromm - Thanks a ton for this. If you need any help from the SDK Team, then please feel free to let us know.

Hi @akromm, any success? :)

Come on guys, the dreaded AWS has come up in discussions again today due to a lack of basic specs on core Azure operations... Nothing worse than setting an expectation and then going silent on the issue! Can we please get an update? I was fully prepared to do the Autorest side of things for the dotnet sdk but the spec isn't even up to date!

@SaltyDH The work to generate the swagger spec for Azure SQL is underway and you can find the in-progress specs here:
https://github.com/akromm/azure-rest-api-specs/tree/master/arm-sql
It has most of the APIs defined but we are still adding a few more and testing the Spec to ensure that everything is correct.

Additionally if you are using a .Net language we have a fully up-to-date NuGet package that has all the APIs: https://www.nuget.org/packages/Microsoft.Azure.Management.Sql/0.50.0-prerelease

Thanks very much Adam, I'll definitely take a look at the wip specs that's awesome! I was specifically interested in a dot net core compatible package. That's why I came looking for the spec, I was hoping to get the newer auto rest project up and running. Thanks again!

Hi @akromm ! Thanks for the work! I looked at your repo, could you confirm that the SQL client will be a composite client? If so, Autorest accepts relative links in composite file, it will helps us to test it (your link inside the composite file are local links so far).
Thanks!

@lmazuel Yes the SQL client will be a composite client.  The problem with using relative paths is that the tool to generate the code based on the specs uses the current directory when calculating relative paths, so it is very easy to run the tool from the wrong place and end up with "File Not Found" type errors.
I plan to change the paths to absolute paths to the files on GitHub once they are finalized and submitted to the Azure repo.
If you would like to test it feel free to change the links in the compositeSql.json file to match your local folder structure.

@akromm Current recommendation is to use relative paths, like you see for Compute.
The problem with absolute Github path, is when you do a PR to fix something in the future, Travis will generate your file that does not point to the content of the PR, but to an absolute path on the master branch of the repo. We already saw some bug when the PR is green / good to merge, but after merging into master finally it was broken.
I understand your problem about local paths, but it's better for the future. (FYI @amarzavery)

If you use any nightly build of September then relative paths should work fine.

@akromm   To be precise try this version of the generator 0.17.0-Nightly20160914 and relative paths should work fine.

@amarzavery Changing the version of the generator fixed the issue I was having with relative file paths. Thanks!
@lmazuel I have updated my repo to use relative paths.

Hi @akromm,
Can we kindly get an ETA on resolving this issue?
Thanks,
Samer

The majority of SQL operations are now documented in Swagger.

Closing this, lately a large number of operations have been added to the specs and latest generated SDKs should now have higher coverage.
if there are still report on missing features  kindly report them. and I would strongly recommend opening new tickets with detail of the missing operations


[feature] Prevent overwriting existing cluster resources in output directories

What this PR does / why we need it:
This PR prevents accidentally overwriting existing cluster deployment files in any output directory. This can be overruled by passing the -f/--force-overwrite parameter with the deploy command
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
n/a
Release note:

I think the change makes sense from a user's perspective, especially since the _output directory cannot be re-obtained as acs-engine stands right now... I think it'd be good to document the new flag in /docs/deploy.md and clearly state the default behaviour. I think not overwriting by default makes sense and, frankly, is better UX so IMO changing the default behaviour is completely acceptable. Also, the default output directory is the DNS prefix so in most cases (except when a user re-deploys) an existing cluster it should be unique. Only thing we need to verify is whether this change can have an impact on upgrade and scale as they overwrite the output dir with the newest version of the cluster (off the top of my head I don't think so)....

I only added the check to the deploy command especially for the reason of allowing upgrade and scale to work as expected. They read the existing generated apimodel.json so that should be fine. This is merely a safeguard for yourself. (have had two coworkers new to acs-engine complaining about this while they were experimenting with this)

@CecileRobertMichon added docs, ready for a review


Update service worker with a response object

I'm thinking about the ability to update service worker with a Response object. It would give developers more control over service worker.
//fetch data directly
fetch('/service-worker.js').then(response => {
    ServiceWorkerRegistration.updateWith(response).then(() => console.log('Service Worker has been updated'));
});
//or retrieve data from cache storage
CacheStorage.open('main').then(cache => {
    cache.match('/service-worker.js').then(response => {
         ServiceWorkerRegistration.updateWith(response).then(() => console.log('Service Worker has been updated'));
    });
});

I don't think we want to allow this, as it would turn a small XSS into a pretty serious thing.
Same reason we don't allow data or blob URLs.


Support to exclude environments from pinning only frozen cookbooks

We would like to have the option to exclude environments from checking the frozen cookbooks.
If we can define the test environment as playground and pin whatever version of cookbook in there, testing will become much easier and we still benefit from the fact that we can push forward to Acceptance and Production.

Fixed by PR #108 which is released in v0.7.0


Extend BindCommand to allow passing EventArgs for any Event in Xamarin Forms

Do you want to request a feature or report a bug?
Improvement
What is the current behavior?
If you use BindCommand to bind to another event than the default one your command does not receive the command arguments.
Like when I tried to bind to the Swiped Event of Mr.Gesture
this.BindCommand(ViewModel, vm => vm.SwipeCommand, v => v.TouchHandler, nameof(TouchHandler.Swiped));

A XF Command will receive SwipeEventArgs. But a ReactiveCommand doesn't
So there seems to be two shortcomings in the current implementation.

Eventargs are not passed
It's not possible to define custom Eventargs like I can do in Xaml that should be passed

Also I question if passing the EventName of a non standard event is the best solution or if it would be better directly to pass the Control events as we have access in the View to the Control already.
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.
RxUI 7 with Xamarin Forms

Howdy @escamoteur; some quick thoughts. Take a quick peek into the source code behind reactiveui-events and you'll see that there is a convention that should solve your particular problem.
Instead of binding, codegen your extension methods or create them yourself; they are pretty simple and do something along the lines of:
viewCtor()
{
    this.Label.Events().Swiped().[Subscribe/ExecuteCommand]...
}

Ok, that is a sort of Workaround. Still I think if we offer CommandBinding we should be able to deal with this too

Is this also impossible in Windows Forms? I cannot seem to figure it out based on available documentation.

@vector-man the remarks over at https://github.com/reactiveui/ReactiveUI/issues/1228#issuecomment-276359536 apply to windows forms as well. Compose your event stream, subscribe to it and then execute the logic as need be.

@ghuntley so you decided that this issue is no loner worth to consider?


⚠ Bofrost.es has degraded performance

In ae763c9, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1516 ms

Resolved: Bofrost.es performance has improved in cc313a4 after 306 days, 16 hours, 20 minutes.


Use Prometheus metrics instead of Castor telemetry endpoint for monitoring tuple availability

Use castor tuple metrics exposed via prometheus metrics as soon as this is available in Castor.

Depends of availability of Prometheus instrumentation in Castor.


Ensure all examples work before 2.0.0 is released

All examples should be tested to be 100% functional before we tag for 2.0.0.

[x] Chatterbox
[ ] Chest
[x] Digger
[x] Echo
[ ] Graffiti
[x] Inventory
[ ] Jumper
[x] Quitter
[x] Sleeper

Also the test by running npm test

[ ] Test

So :

Echo now works
Digger, ChatterBox and Jumper are starting to work a bit :
** Digger can now dig (but the bot fly through the air)
** Chatterbox correctly display the name of the connected players
** Jumper doesn't crash anymore

The rest is still totally untested so probably crashing and broken.

Chatterbox now works !

Jumper refuse to make the bot move forward
the bot is flying
the inventory is broken

Quitter now works, most of jumper.js now works :

[x] jump
[x] forward
[x] back
[x] left
[x] right
[x] stop
[x] tp
[x] spawn
[x] pos
[x] yp
[ ] sprint
[ ] attack
[ ] mount
[ ] dismount

Digger :

[x] dig
[ ] build
[ ] list
[ ] dirt

ok digger works,
Inventory :

[x] list
[x] look
[x] toss
[x] equip
[x] unequip
[x] food
[x] health
[x] difficulty
[ ] use
[ ] stop
[ ] craft

Sleeper now works.

So, I fixed reading a block in graffiti.js.
Updating is not implemented (must be done after placing a block).
Paintings are not in the block.json enum, are they blocks ?
I think we need to know what's the purpose of graffiti.js before calling it fixed.

So dismount still doesn't work, not sure how to do it, wiki.vg says nothing about that.

sprint is fixed
only dismount left in jumper.js

Ok last example, chest.js :

[x] Chest
[ ] furnace
[ ] dispenser
[ ] enchant

Enchant is broken, and I don't really understand the enchant table (I never used it in the game), so I'm going to let that for later.

https://github.com/andrewrk/mineflayer/blob/master/test/test.js is completely broken except for the chat test.
It's needed to adapt the changed packets in there (at least)

test.js :

[x] chat
[x] entity effects
[ ] blockAt
[ ] gravity + land on solid block + jump
[x] sets players[player].entity to null upon despawn

I don't know how to fix the map chunk format there https://github.com/andrewrk/mineflayer/blob/master/test/test.js#L83
@roblabla maybe you'd know ?

@rom1504 analogous change to https://github.com/andrewrk/mineflayer/commit/dbe6143b0fd10793b0acd29d6e0614be19e5e3b2

I don't understand the chunk format enough to fix this I'm afraid... I bet it doesn't need a lot of changes though, see there https://github.com/andrewrk/mineflayer/blob/master/test/test.js#L73

Should it still be using zlib ?

Nope. compression is now handled on the protocol level

just the offset to fix now https://github.com/andrewrk/mineflayer/blob/master/test/test.js#L84

I'm going to consider test.js (now internalTest.js) working since the remaining test is skipped (https://github.com/andrewrk/mineflayer/blob/master/test/internalTest.js#L72) and is anyway tested better in externalTest.js

dismount done :)

A painting is an entity, see how that applies to graffiti.js

see http://minecraft.gamepedia.com/Data_values/Entity_IDs + https://github.com/andrewrk/mineflayer/issues/207

e15388bca80ae3387c48188d7b8bebff8961218a fix paintings.

Updating a sign is not implemented but graffiti.js is not trying to do it (https://github.com/andrewrk/mineflayer/issues/180#issuecomment-84521477) so let's consider graffiti.js working.

7304a6cce022fb9f9d27d0b5b22069132ceb389b starts working on fixing enchant, but it still doesn't quite work. What's broken :

it seems the slots positions aren't quite correct : put doesn't work every time
enchant 0 doesn't work

If it worked it would be :

enchant -> display what's in the enchantment table
put swordDiamond -> put a diamond sword in the enchantment table and tell use what our enchantment choices are
enchant 0 -> do the enchantment and tell use what happens

might be related with the facts that QUICK_BAR_START (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/inventory.js#L240) and INVENTORY_SLOT_COUNT aren't actually constants.

Since 1.8 enchanting need to put lapis on the enchantment table (http://minecraft.gamepedia.com/Enchanting). This is currently not handled at all by mineflayer and is probably (part) of the problem.

INVENTORY_SLOT_COUNT is actually a constant.

bot.inventory should probably be a function or something, and use the inventorySlotStart of each window

The idea is : only one window can ever be open at the same time, so instead of bot.inventory, maybe a bot.currentWindow would make more sense (or for bot.inventory to be bot.currentWindow)

Enchant is fixed. Issue solved :)


Infinite loop in concat

The following expression diverges when evaluated:
Immutable.List().slice(0, NaN).concat(NaN).
CC @DivyaPrabhakar

This is now fixed in v3.7.5

Thanks!


fix: convert trigger_data to string for in-app-messages api

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#267  👈
#227 : 2 other dependent PRs (#228 , #242 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @connorlindsey and the rest of your teammates on  Graphite


Captions text seems to include timestamps.

Describe the bug
Captions text seems to include timestamps.
Tested with this video: https://www.youtube.com/watch?v=FJOXDCzlGv0
Text that is retrieved
'I0  wish1600  to4000'
'thank0  the10000  Prime12010  Minister14410'
etc..
To Reproduce
const youtube = new Client();
const video = await youtube.getVideo("FJOXDCzlGv0");
const captions = await video?.captions.get('en');

Steps to reproduce the behavior:
Expected behavior
No timestamps in the text.
Screenshots
captions object in VSCode

Actual text

Additional context
Add any other context about the problem here.

Fix published on 1.5.3 👍🏻


Type issue with ActionCreators from createSlice with no payload

I am creating a slice for my state, and one of the actions I want to create does not take a payload. However, when mapping the dispatch to the props in connect, I get a weird type error.

Argument of type 'typeof MyComponent' is not assignable to parameter of type 'ComponentType<Matching<{ loading: boolean; } & { setLoaded: SliceActionCreator<void>; }, MyProps>>'.   Type 'typeof MyComponent' is not assignable to type 'ComponentClass<Matching<{ loading: boolean; } & { setLoaded: SliceActionCreator<void>; }, MyProps>, any>'.     Types of parameters 'props' and 'props' are incompatible.       Type 'Matching<{ loading: boolean; } & { setLoaded: SliceActionCreator<void>; }, MyProps>' is not assignable to type 'Readonly<MyProps>'.         Types of property 'setLoaded' are incompatible.           Type 'SliceActionCreator<void>' is not assignable to type '() => void'.
Here's a minimal reproduction of the issue I'm having:
import React, { PureComponent } from 'react';
import { createSlice } from 'redux-starter-kit';
import { connect } from 'react-redux'

interface MyState {
    loading: boolean;
}

const INITIAL_STATE: MyState = {
    loading: true,
}

const slice = createSlice({
    slice: 'mySlice',
    initialState: INITIAL_STATE,
    reducers: {
        setLoaded: (state) => { state.loading = false; },
    }
})

interface MyProps {
    loading: boolean;
    setLoaded(): void;
}

class MyComponent extends PureComponent<MyProps> {
    componentDidMount() {
        // perform some check for loading
        const setLoaded = this.props.setLoaded;

        setLoaded();
    }

    render() {
        const loading = this.props.loading;
        if (loading) {
            return (

Loading...

            );
        } else {
            return (

Loaded!

            )
        }
    }
}

export default connect(
    (state: MyState) => ({
        loading: state.loading,
    }),
    {
        setLoaded: slice.actions.setLoaded,
    }
)(MyComponent)

If I change the type of the action property in MyProps to take a void payload, then the error goes away, but that's obviously not the correct type:
interface MyProps {
    loading: boolean;
    setLoaded(payload: void): void;
}

Am I doing something wrong, or is there a bug in the typing?

This is indeed a typing bug. I created a PR (#110) which fixes the issue.

Awesome, thanks

Fixed by #133.


Merge color-setting into a colorize file

Pretty happy with this now, although I might still generate the full set of images for monochrome, river, and dark, and check against those

I haven't checked over this at all thoroughly, and also it has a lot of conflicts, but if you check over it with Wraith I'd be pretty happy with it!


Cleanup PlaneData implementation and enable Serialize/Deserialize

The existing PlaneData implementation essentially
replicated the Vec implementation,
so this commit switches the internal implementation
to use a boxed slice.
This allows the removal of some unsafe code.
This also enables implementing serialize/deserialize
in a reasonable way, which is needed for distributed encoding.
This commit has no breaking changes to the public API.

All right, I'll have to do the manual serialize implementation. Have to figure out how to do that without an intermediate allocation.


Wrong Version Syntax in Doc

Usage states v2.1 as action version - this can not be resolved (Error: Unable to resolve action<EMAIL_ADDRESS>unable to find version 'v2.1').

Please remove the 'v' prefix<EMAIL_ADDRESS>

@restackio, please update this.


Fix redis session failed

This will fix #3085.

Codecov Report

Merging #3086 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   33.26%   33.28%   +0.01%
==========================================
  Files         273      273
  Lines       39954    39954
==========================================
+ Hits        13291    13298       +7
+ Misses      24765    24761       -4
+ Partials     1898     1895       -3

Impacted Files
Coverage Δ

modules/setting/setting.go
46.93% <100%> (ø)
:arrow_up:

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

models/repo.go
38.34% <0%> (+0.18%)
:arrow_up:

models/repo_indexer.go
49% <0%> (+3.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a7899...fd462f0. Read the comment docs.

LGTM

LGTM


[Snyk] Fix for 12 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

api/pacman-api-compliance/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity
Reachability

475/1000  Why? Has a fix available, CVSS 6.5
Directory Traversal SNYK-JAVA-COMAMAZONAWS-2952700
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
No Known Exploit
No Path Found

475/1000  Why? Has a fix available, CVSS 6.5
Denial of Service (DoS) SNYK-JAVA-IONETTY-1020439
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
No Known Exploit
No Path Found

460/1000  Why? Has a fix available, CVSS 6.2
Information Disclosure SNYK-JAVA-IONETTY-1070799
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
No Known Exploit
No Path Found

460/1000  Why? Has a fix available, CVSS 6.2
Information Disclosure SNYK-JAVA-IONETTY-1082235
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
No Known Exploit
No Path Found

595/1000  Why? Mature exploit, Has a fix available, CVSS 5.9
HTTP Request Smuggling SNYK-JAVA-IONETTY-1317097
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
Mature
No Path Found

475/1000  Why? Has a fix available, CVSS 6.5
HTTP Request Smuggling SNYK-JAVA-IONETTY-2314893
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
No Known Exploit
No Path Found

550/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 6.5
HTTP Request Smuggling SNYK-JAVA-IONETTY-469234
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
Proof of Concept
No Path Found

600/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
HTTP Request Smuggling SNYK-JAVA-IONETTY-543490
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
Proof of Concept
No Path Found

600/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
HTTP Request Smuggling SNYK-JAVA-IONETTY-543669
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
Proof of Concept
No Path Found

475/1000  Why? Has a fix available, CVSS 6.5
Denial of Service (DoS) SNYK-JAVA-IONETTY-5725787
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
No Known Exploit
No Path Found

600/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
HTTP Request Smuggling SNYK-JAVA-IONETTY-6056419
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
Proof of Concept
No Path Found

490/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Allocation of Resources Without Limits or Throttling SNYK-JAVA-IONETTY-6483812
com.amazonaws:aws-java-sdk:  1.12.234 -> 1.12.713
No
Proof of Concept
No Path Found

(*) Note that the real score may have changed since the PR was raised.
Vulnerabilities that could not be fixed

Upgrade:

Could not upgrade<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Reason could not apply upgrade, dependency is managed externally ; Location: https://maven-central.storage-download.googleapis.com/maven2/software/amazon/awssdk/aws-sdk-java-pom/2.17.230/aws-sdk-java-pom-2.17.230.pom

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
🦉 Denial of Service (DoS)
🦉 Information Disclosure
🦉 More lessons are available in Snyk Learn

Checkmarx One – Scan Summary & Details – 2fdc4b4d-86cd-4f1e-883b-59e00e30b385
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2023-34034
Maven-org.springframework.security:spring-security-web-5.0.7.RELEASE
Vulnerable Package

CVE-2023-34034
Maven-org.springframework.security:spring-security-config-5.0.7.RELEASE
Vulnerable Package

CVE-2023-52428
Maven-com.nimbusds:nimbus-jose-jwt-9.8.1
Vulnerable Package

CVE-2023-6481
Maven-ch.qos.logback:logback-core-1.3.5
Vulnerable Package

CVE-2023-6481
Maven-ch.qos.logback:logback-core-1.2.9
Vulnerable Package

CVE-2023-6481
Maven-ch.qos.logback:logback-core-1.2.3
Vulnerable Package

CVE-2023-6481
Maven-ch.qos.logback:logback-core-1.2.11
Vulnerable Package

CVE-2023-6481
Maven-ch.qos.logback:logback-core-1.1.11
Vulnerable Package

CVE-2024-22243
Maven-org.springframework:spring-web-5.0.8.RELEASE
Vulnerable Package

CVE-2024-22257
Maven-org.springframework.security:spring-security-core-5.0.7.RELEASE
Vulnerable Package

CVE-2024-22259
Maven-org.springframework:spring-web-5.0.8.RELEASE
Vulnerable Package

CVE-2024-22262
Maven-org.springframework:spring-web-5.0.8.RELEASE
Vulnerable Package

CVE-2024-23672
Maven-org.apache.tomcat.embed:tomcat-embed-core-8.5.32
Vulnerable Package

CVE-2024-23672
Maven-org.apache.tomcat.embed:tomcat-embed-websocket-8.5.32
Vulnerable Package

CVE-2024-24549
Maven-org.apache.tomcat.embed:tomcat-embed-core-8.5.32
Vulnerable Package

CVE-2024-29180
Npm-webpack-dev-middleware-5.3.0
Vulnerable Package

CVE-2024-4067
Npm-micromatch-4.0.5
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

Missing User Instruction
/Dockerfile: 2
A user should be specified in the dockerfile, otherwise the image will run as root

Missing User Instruction
/dockerfile: 1
A user should be specified in the dockerfile, otherwise the image will run as root

Missing User Instruction
/dockerfile: 1
A user should be specified in the dockerfile, otherwise the image will run as root

Missing User Instruction
/dockerfile: 1
A user should be specified in the dockerfile, otherwise the image will run as root

Passwords And Secrets - Generic Password
/mysql-check.yaml: 10
Query to find passwords and secrets in infrastructure code.

Add Instead of Copy
/dockerfile: 10
Using ADD to load external installation scripts could lead to an evil web server leveraging this and loading a malicious script.

Add Instead of Copy
/Dockerfile: 10
Using ADD to load external installation scripts could lead to an evil web server leveraging this and loading a malicious script.

CVE-2023-33202
Maven-org.bouncycastle:bcprov-jdk15on-1.67
Vulnerable Package

CVE-2023-33202
Maven-org.bouncycastle:bcprov-jdk15on-1.56
Vulnerable Package

CVE-2024-29025
Maven-io.netty:netty-codec-http-4.1.79.Final
Vulnerable Package

CVE-2024-29025
Maven-io.netty:netty-codec-http-4.1.77.Final
Vulnerable Package

CVE-2024-29025
Maven-io.netty:netty-codec-http-4.1.27.Final
Vulnerable Package

CVE-2024-29025
Maven-io.netty:netty-codec-http-4.1.32.Final
Vulnerable Package

Image Version Not Explicit
/dockerfile: 1
Always tag the version of an image explicitly

Image Version Not Explicit
/Dockerfile: 2
Always tag the version of an image explicitly

Pip install Keeping Cached Packages
/dockerfile: 3
When installing packages with pip, the '--no-cache-dir' flag should be set to make Docker images smaller

Pip install Keeping Cached Packages
/dockerfile: 10
When installing packages with pip, the '--no-cache-dir' flag should be set to make Docker images smaller

Pip install Keeping Cached Packages
/Dockerfile: 4
When installing packages with pip, the '--no-cache-dir' flag should be set to make Docker images smaller

Pip install Keeping Cached Packages
/dockerfile: 4
When installing packages with pip, the '--no-cache-dir' flag should be set to make Docker images smaller

RUN Instruction Using 'cd' Instead of WORKDIR
/dockerfile: 4
When using RUN command 'cd' should only be used for full path. For relative path make use of WORKDIR command instead.

Unpinned Actions Full Length Commit SHA
/codeQl.yaml: 50
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeQl.yaml: 65
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeQl.yaml: 84
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Package Version in Apk Add
/dockerfile: 3
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Apk Add
/dockerfile: 1
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Apk Add
/dockerfile: 10
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Apk Add
/Dockerfile: 4
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Pip Install
/Dockerfile: 4
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Pip Install
/dockerfile: 10
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Pip Install
/dockerfile: 4
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Unpinned Package Version in Pip Install
/dockerfile: 3
Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

Healthcheck Instruction Missing
/dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Healthcheck Instruction Missing
/dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Healthcheck Instruction Missing
/dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Healthcheck Instruction Missing
/Dockerfile: 2
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

IAM Access Analyzer Not Enabled
/CloudFormation.yaml: 2
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

MAINTAINER Instruction Being Used
/Dockerfile: 3
The MAINTAINER instruction sets the Author field of the generated images. The LABEL instruction is a much more flexible version of this and you sho...

MAINTAINER Instruction Being Used
/dockerfile: 2
The MAINTAINER instruction sets the Author field of the generated images. The LABEL instruction is a much more flexible version of this and you sho...

Multiple RUN, ADD, COPY, Instructions Listed
/dockerfile: 144
Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.

Fixed Issues

Severity
Issue
Source File / Package

CVE-2022-38900
Npm-decode-uri-component-0.2.2

Cxab55612e-3a56
Npm-braces-3.0.2

Cxca84a1c2-1f12
Npm-micromatch-4.0.5


Add Hilbert matrix to jax.scipy.linalg

This PR implements the hilbert function which returns a Hilbert matrix of order n.

I will create another PR with all the requested changes, since I could not squash all the commit into a single commit.

It's straightforward to squash all commits into a single commit once you know how – please let me know if you'd like assistance with that next time


We need access to facility names.

@bruskiza ready for review

This should not go public IMHO.

:+1:


Migration to Swift 5

@luispadron could you enable Swift 5 on Travis? :)

Another vote on this one - it's blocking me due to the Swift 5 compile time error

Thanks @darecki for the PR!

Thanks for the PR!
I think all you have to do is change the .travis.yml file to use osx_image: 10.2, however, that version of Xcode doesn't show up here so not sure if it supports Swift 5 yet? We can go ahead and make that change to the travis file and push and it should work if they support it.

While we're waiting pod update a lib may be fixed manually like this
let a = max(ring.outerRingWidth, ring.innerRingWidth)
let b = ((valueKnobStyle?.size ?? 0) / 4)
let c = (borderWidth * 2)
let offSet = a / 2 + b + c

Temporary workaround
pod 'UICircularProgressRing', :git => 'https://github.com/darecki/UICircularProgressRing.git', :branch => 'swift_5'

Thanks for the PR!
I think all you have to do is change the .travis.yml file to use osx_image: 10.2, however, that version of Xcode doesn't show up here so not sure if it supports Swift 5 yet? We can go ahead and make that change to the travis file and push and it should work if they support it.

I just found this: https://blog.travis-ci.com/2019-02-12-xcode-10-2-beta-2-is-now-available
I assume for now it should run on Xcode 10.2-beta and then switch to full version automatically. I'll update my PR

Can we merge this now?

@luispadron Do you think you can merge and release a new version?

Sorry, been busy with school.
Thanks for the great work, I'll merge this and get a new pod and Carthage release out ASAP.

Available now in 6.1.0


tapcfg: allow to configure lnd RPC timeout, increase default val

This fixes an issue where tapd would shut down because querying channels on a slow lnd would time out:
2024-10-30 10:06:21.535 [DBG] STAT: Setting the taproot-assets sub-server as errored: received critical error from sub-server (taproot-assets), shutting down: failed to handle outgoing message: error adding local alias: add alias: error listing local channels: rpc error: code = DeadlineExceeded desc = context deadline exceeded

Will add a similar PR to litd, as there the lndclient is created in a single place for all sub servers, so this daemon specific value would be ignored.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
32 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.02%) to 40.686%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tapcfg/config.go
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

tapcfg/config.go
1
0.0%

commitment/tap.go
1
84.17%

tapdb/addrs.go
2
79.04%

tappsbt/create.go
2
53.22%

tapgarden/planter.go
2
74.87%

tapchannel/aux_leaf_signer.go
3
36.33%

tapdb/universe.go
4
80.91%

tapdb/multiverse.go
7
60.32%

universe/interface.go
10
51.12%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.02%

Covered Lines:
24683

Relevant Lines:
60667

💛  - Coveralls

pending lint / sample conf


[RFE] "tenant" attribute for License class

Summary
BIG-IQ now supports the "tenant" attribute when requesting license assignment. Please add this to the schema.
Justification
For the purpose of identifying and matching an assigned licensed to a BIG-IP user based on a user-defined unique identifier.
Reference
https://clouddocs.f5.com/products/extensions/f5-declarative-onboarding/latest/big-iq-licensing.html
/mgmt/cm/device/tasks/licensing/pool/member-management/example

{
"items": [

    {

        "licensePoolName": "example string",

        "command": "example string",

        "address": "example string",

        "port":<PHONE_NUMBER>,

        "user": "example string",

        "password": "example string",

        "macAddress": "example string",

        "hypervisor": "example string",

        "tenant": "example string",  <----------------!!!!!!!!!!!!!!!!

        "assignmentType": "MANAGED",

        "skuKeyword1": "example string",

        "skuKeyword2": "example string",

        "unitOfMeasure": "example string",

        "chargebackTag": "example string",

        "licenseAssignmentReference": {

            "link": "http://host:port/path/to/resource",

            "isSubcollection": false

        },

        "licenseText": "example string",

        "currentStep": "GET_LICENSE",

----snip----

Can you please provide additional documentation on this new BIG-IQ tenant feature so we can better understand how it works?

Added to our internal product backlog as AUTOTOOL-1635.

This issue should be resolved in the 1.15.0 release.


RetrievalQA: Submit different queries to Retriever and LLM

Feature request
This is related to HyDE.  But I feel my feature request puts the HyDE example in a more realistic context, and naturally extends the RetrievalQA chain.
My suggestion would be allow the text passed to the retriever to be different from the query passed to the LLM.  This would be useful as fallback when the original query, as provided by the user, yields a response of "I don't know" from the LLM; or if it returns no or poor-scoring documents during the retrieval step.
Step 1, Embed original query
Step 2, retrieve candidate documents based on embedded original query
Step 3, pass original query & retrieved documents to LLM for answer
If Step 2 yields 0/low score documents OR Step 3 yields no/low confidence answer...
Step 4, generate an alternate hypothetical answer (i.e., as described in HyDE
Step 5, embed  hypothetical answer
Step 6, retrieve candidate documents based on embedded  hypothetical answer
Step 7, pass original query & newly retrieved documents to LLM for answer
Motivation
Perhaps I have a query that does not yield good retrieval documents from my main knowledgebase corpus.  It is poorly formed, it has spelling errors, it is vague, it is brief.  Even though the corpus does contain the factual answer to the intent of the query.  Instead, a different form of the original query would yield better retrieved documents, and therefore produce the correct & complete answer desired.
For example, very simple questions like "Who's Character X?" may yield a wide range of sub-optimal documents from a QA Retriever.  As a result, the LLM's response may be muddled or impossible to generate.
Your contribution
Happy to refine the suggestion and provide concrete examples.

I have a question about this issue.
Is it possible to rewrite a broad, incorrect, or ambiguous query into an accurate one through a query based on historical data, thus completing the task you described

I have a question about this issue. Is it possible to rewrite a broad, incorrect, or ambiguous query into an accurate one through a query based on historical data, thus completing the task you described

That seems like a neat idea.  And definitely worth exploring.
It is unclear to me if my user base is large enough as to generate different versions of the same question over time.  If not, then it's not going to work.  I suppose I should also look into having the LLM ask clarifying questions before attempting to answer.
But for now, I'd like to explore the possibility of generating a hypothetical user input that successfully retrieves context documents as an extension of the RetrievalQA chain.


Changes the aggregation

Codecov Report
Attention: Patch coverage is 78.12500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 74.84%. Comparing base (81f09fc) to head (e51072d).

Files
Patch %
Lines

...nt/torch_bench/_bash_bench_benchmark_runner_agg.py
78.12%
21 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   74.88%   74.84%   -0.05%
==========================================
  Files         137      137
  Lines       17873    17913      +40
==========================================
+ Hits        13385    13407      +22
- Misses       4488     4506      +18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Migration of Azure adal to azidentity

Is your feature request related to a problem? Please describe.
adal and auth will be deprecated next year.  We should look into migration to azidentity
More info: https://azure.microsoft.com/en-us/updates/support-for-azure-sdk-libraries-that-do-not-conform-to-our-current-azure-sdk-guidelines-will-be-retired-as-of-31-march-2023/
Describe the solution you'd like
Migration guide
Environment
Storage Provider: Azure

Still relevant


Cargo maker should show type hint for mismatched type errors

When the cargo maker is run, the short error shown in the statusline is usually helpful. The exception is for type mismatches, where it will simply show cargo: mismatched types, without communicating what those types are. This was discussed briefly with @fuine in https://github.com/neomake/neomake/pull/613#issuecomment-261745615.
Consider the following rust program:
fn main() {
    let foo: bool = 42;
}

Compiling it gives the following error:
error[E0308]: mismatched types
 --> test.rs:2:21
  |
2 |     let foo: bool = 42;
  |                     ^^ expected bool, found integral variable
  |
  = note: expected type `bool`
  = note:    found type `{integer}`

Unfortunately, the statusline given by neomake just shows mismatched types. Given how common type errors are in Rust development, this hinders development speed (you need to navigate to the line, open the quickfix window to find the types, and then close it again).
Expected behavior
Neomake statusline shows
cargo: mismatched types (expected `bool` found `{integer}`)

Would be fixed by #942

This should now be fixed because #1123 is merged

FWIW: ALE has a ALEDetail command, which displays details for an error (https://github.com/w0rp/ale/blob/c7bd5cc0ba799abb7e382751cdbea49c1b98a429/autoload/ale/cursor.vim#L112).
Maybe we could add something like that for this, too?


[WIP] Add implementation of  TimescaleDB time_bucket

Inspired by this blogpost from timescaledb  Aggregate time-series data with time_bucket .
It is similar but simplified due to the nature of our api. I had a need to be able to compute aggregates for daily, weekly, monthly and yearly reports for my now defunct web analytics project.
Some underlying code is direct port from c implementation on timescaledb see function timeBucket function.  There is a long way to go untill this is ready for review.

Neat!

Closing this for now. Will focus on smaller patches ( perf stuff are more interesting)

It would still be very cool to get to this (even in smaller chunks as you wrote).
Parca currently does this in the application layer: https://github.com/parca-dev/parca/blob/718d30a137dbd5bef8db3f58c798c7fa6e4e4113/pkg/parcacol/querier.go#L628-L641

@metalmatze I see there is a TODO on the link you provided.
Implementing only that use case is possible. I mean only accepting a step which is  time.Duration ,  and time representation ms/s/ns .
It wont cover time_bucket but it can be something close to what Duration expression does.  time_bucket is way nuanced than that, it takes into account for days of the week/month etc .
Happy to resurrect this given enough interest. I am just worried that I will invest a lot of time on things that frostdb team might deem not important, or give maintainers headache reviewing large diffs of irrelevant stuff.
I pretty much just take small tasks that can be reviewed while having a cup of coffee.
Addressing this will also eat a chunk of your time as well, we will probably need to discuss tradeoffs and see what works well with frostdb and parca.

I see.
This looked like the same problem to me or at least similar enough to reuse it. On second thought it seems to be ever so slightly different as you pointed out.
Let's keep both problems separate then.
Nonetheless, the feature in this PR seems interesting!


[WIP] Joshs development

Should only be merged after:
remove bead type branch is merged
base bead remove multiple inheritance branch is merged
Jens file reader branch is merged

This branch adds a new class base molecule, base molecule shared methods that are common both to the csg molecule and the xtp molecule classes, it also inherits from the beadstructure class which provided structural identification functionality.

The local csg molecule was made to inherit from the base molecule.

The base molecule and the beadstructure were converted to templated classes to provide a higher level of flexibility.

The residue class was removed, as it was not needed and was a known source of memory leaks.

Following functions were removed from topology.h file as they were not used anywhere, and their implementations were faulty:

void CreateMoleculesByResidue();
void CreateOneBigMolecule(std::string name);
void Add(Topology *top);

Separate from the residue name beads now also require the molecule name to be passed in when calling their constructor. This was to prevent confusing the residue and molecule names when they are two distinctly different objects.

The add bead methods were changed from:
void AddBead(Bead *bead, const std::string &name);
to
void AddBead(T *bead);

Because it was redundant to pass the name in as a separate variable when the name is already stored in the bead.

Randomly throughout the file readers in csg the bead names are sometimes created with the following syntax:
"ResidueName:ResidueNumber:AtomName"

with colons separating the different fields. Instead the bead was provided with a new method called get label that will automatically generate the appropriate string based on the residue name number and atom name stored in the bead.
9. Memory tests with valgrind were added to cmake

Memory errors were fixed.

@JoshuaSBrown can we delete this branch?


Collection query doesn't work for nested objects

Document:
 'my_document' : {      id: 'xyz',      integrations: {id: '1', type: 'some_type'} }
Query:
db.collection('my_document').where('integrations.id', '==', '1') .where('integrations.type', '==', 'some_type')
There is no result for this query.
Normally firestore resolves dot to nested objects.
As a workaround for testing purposes I have to add integrations.id field to the document.

:tada: This issue has been resolved in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Check If AWS Mahchine Has a Node

Check if AWS Mahchine has a node, before trying to access the node's information.

/lgtm
/hold
couple of Nits, feel free to fix/merge/wait for additional review

/lgtm

/unhold


Lexer+Parser: Consider Moving CanReset & Reset into Marker

Currently, the Marker CanReset and Reset methods live on the Lexer class:

func (l *Lexer) CanReset(m *Marker) bool
func (l *Lexer) Reset(m *Marker) LexerFn

Let's consider moving these into the Marker class:

func (m *Marker) CanReset() bool
func (m *Marker) Reset() LexerFn

EDIT: Having the name Reset ON the marker feels a little odd, since we're not resetting the marker, but instead resetting the lexer.
Perhaps something like Apply would flow better:

func (m *Marker) CanApply() bool
func (m *Marker) Apply() LexerFn

This is complete.
The lexer.CanReset() and lexer.Reset() have been moved into the Marker class and renamed:

marker.Valid()
marker.Apply()

Documentation has been updated and some tests renamed to match.


[simd] Build error on arm64-linux

Hello,
I got a fresh installation of rasberry os lite and cloned and bootstrapped vcpkg. I was able to install another package, but when I tried to install simd, I receive a build error. The logs say something about permission denied. Running it with sudo didn't work because of a missing enviroment variable

I have installed the newest version of cmake ninja and vcpkg and the recommended packages build-essential tar curl zip unzip.

With sudo -E I still get the same error log:
[1/305] "" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fm>
FAILED: CMakeFiles/Simd.dir/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/src/Simd/SimdLib.cpp.o
"" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fmax-error>
/bin/sh: 1: : Permission denied
[2/305] "" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fm>
FAILED: CMakeFiles/Simd.dir/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/src/Simd/SimdBaseAbsDifference.cpp.o
"" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fmax-error>
/bin/sh: 1: : Permission denied
[3/305] "" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fm>
FAILED: CMakeFiles/Simd.dir/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/src/Simd/SimdBaseAbsDifferenceSum.cpp.o
"" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fmax-error>
/bin/sh: 1: : Permission denied
[4/305] "" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fm>
FAILED: CMakeFiles/Simd.dir/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/src/Simd/SimdBaseAddFeatureDifference.cpp.o
"" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fmax-error>
/bin/sh: 1: : Permission denied
[5/305] "" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fm>
FAILED: CMakeFiles/Simd.dir/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/src/Simd/SimdBaseAbsGradientSaturatedSum.cpp.o
"" -DSIMD_INT8_DEBUG_DISABLE -I/home/pi/packages/vcpkg/buildtrees/simd/src/v5.3.128-d09ac2fee4.clean/prj/cmake/../../src -fPIC -g -fPIC -fPIC -std=c++11 -O0 -g -fmax-error>
/bin/sh: 1: : Permission denied
ninja: build stopped: subcommand failed.

sudo is not the answer, and
"" is not an executable program.

See #30604 How to properly report a package build failure.

I tried both
sudo -E ./vcpkg install simd
and
./vcpkg install simd
On the newest version and both did not work
I managed to build it using an older version (git hash a42af01b7) with
sudo -E ./vcpkg install simd
Sudo was in fact the answer here. Without sudo it did not build on that version either.

Sudo was in fact the answer here. Without sudo it did not build on that version either.

No. sudo is part of the problem. You are creating files with owner root when they should be owned by your user account.
And then you cannot modify them without sudo next time.
No to mention that broken or evil build scripts might overwrite everything while running with sudo.
So the system is already broken.
You need to find why the compiler isn't identified correctly. In your user's context. Check the environment variables. There must be a reason why the builds picks the empty string. If it is displayed correctly here, given the absence of markup.

I am aware, that the scripts are supposed to function without using sudo, but in this case it didn't. Thats why I created an issue. It did work with sudo in the older commit but it should not require sudo.
I gave you all the information I have and all the Information that is needed to recreate the behaviour. I used a fresh install of Raspberry OS lite (newest version to that date). Pulled the newest version (same date) of vcpkg, used the bootstrap script and tried to install simd - did not work. I don't know why the compiler was not identified correctly thats again, part of the reason why I created the issue

I gave you all the information I have.

the result of checking your environment variables.
the config logs created in buildtrees/simd.


fixes validation pathing BR-S-08 and BR-Z-08

The issue https://github.com/SimplerInvoicing/validation/issues/13 was fixed by commit https://github.com/SimplerInvoicing/validation/commit/5c2fed4f287920aabc25641646ad9f71a061e038
But it seems that an new commit has accidentaly reverted this fix: https://github.com/SimplerInvoicing/validation/commit/e85addeb30bdffeafda101aa70df0c5cc5c17c61#diff-6dd04cdf48683997bf2d75f64a10c097
And the exact same issue is also to be present in rule BR-Z-08
Reapplying the fix above makes the validation work again.

Apparently my testcase did not include one of the issues, and it looks like the case wasn't fixed for tax category Z in the first place. So thank you for the pull request.
There is an issue with it, however; the .xsl files are generated, so updating them is not enough (usually I don't include generated files in a repository, but this case is an exception for easier download).
The pull request did help me find the correct places in the source though, and I have made another branch that I think fixes it, could you please check that one? 53b57de356e9113f1960b1a237ae8a66ede6294c
(additionally, should you have xml documents that show such errors, and that can be shared, we can always use more for our test set :) )

Thanks for the update. I should have realised the xsl was generated from the schema :)
The branch looks good. It will be appreciated if it can be merged, so our testcases will work again.
I will close this pull request and we will look into some possible xml files to expand the simplerinvoicing/testset.


chore(deps): update syn requirement from 1.0 to 2.0

Superseeds https://github.com/bytedance/monoio/pull/156
Some parts taken from https://github.com/tokio-rs/tokio/pull/5572

Hi~ Thanks for your contribution, could you fix the clippy warning in CI?

Sorry, just have the time to do it, I believe it's fixed now.

There seems to be something wrong with the latest version of clippy. It suggest using Vec<MaybeUninit<T>> when with_capacity() and then set_init() in docs, but infact it gives warning.
Could you please help ignore it like adding #[allow(clippy::uninit_vec)] or some other ways?

I believe this should be fixed in https://github.com/rust-lang/rust-clippy/issues/10565, should we wait?


⚠ TiendaEnLinea has degraded performance

In 3a511bf, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 5113 ms

Resolved: TiendaEnLinea performance has improved in bf79860.


Add baseline for TREC news BL

fix #1012

Add baselines for both 2018 and 2019
Add qrels + topics for TREC BL 18+19
Add link in README.md to the markdown that explains how to generate the baselines.

Note that the topics of last year are not on the TREC website yet. The link needs to be added after they are published there.