[BUG REPORT]

An error occurred
(node:14064) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 closed listeners added to [BrowserWindow]. Use emitter.setMaxListeners() to increase limit
    at _addListener (node:events:601:17)
    at BrowserWindow.addListener (node:events:619:10)
    at BrowserWindow.once (node:events:663:8)
    at _fireToast (C:/Users/SS3/AppData/Local/Programs/bfx-report-electron/resources/app/src/auto-updater/index.js:95:7)
    at NsisUpdater.<anonymous> (C:/Users/SS3/AppData/Local/Programs/bfx-report-electron/resources/app/src/auto-updater/index.js:432:31)
    at NsisUpdater.emit (node:events:527:28)
    at NsisUpdater.dispatchUpdateDownloaded (C:/Users/SS3/AppData/Local/Programs/bfx-report-electron/resources/app/node_modules/electron-updater/out/AppUpdater.js:404:14)
    at Object.done (C:/Users/SS3/AppData/Local/Programs/bfx-report-electron/resources/app/node_modules/electron-updater/out/BaseUpdater.js:30:22)
    at done (C:/Users/SS3/AppData/Local/Programs/bfx-report-electron/resources/app/node_modules/electron-updater/out/AppUpdater.js:516:31)

Debug info

Version
4.8.0

Commit Hash
bab409923e47070ec3bfcc579f820e692b31439d

Commit Date
2023-06-21T12:34:00Z

Electron
21.3.3

Chrome
106.0.5249.199

Node.js
16.16.0

V8
<IP_ADDRESS>-electron.0

OS version
Windows 10 Pro

OS release
Windows_NT x64 10.0.19045

CPUs
Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz x 36

RAM
255.72GB (227.74GB free)

App RAM limit
4095.75Mb (12.89MB used)

Is BFX API Staging used
No

Main log

Worker errors

Worker exceptions

The issue was opened from the electron app

Hi)
thanks for the report
It seems that the problem occurred during auto-update
We'll try to fix the issue for the next release


⚠ Bofrost.at has degraded performance

In 18965bd, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1032 ms

Resolved: Bofrost.at performance has improved in ac1b9cd.


fix npe when inventory object is nil

Fixes #3902

@chanwit are you going to address these issues? if not, I'll happily close this and open a new PR to do it.

I'll continue this week. Sorry I am currently having a technical issue with my box.


Extract common test fixtures

We use the GoogleTest framework for our unit tests. Since the Graaf library supports arbitrary vertex and edge types, we make use of TYPED_TEST_SUITEs to run our tests for different types of graph instances (i.e. directed_graph<int, int>, directed_graph<long, std::string>, ...).
Currently, most tests redefine the same fixtures over and over. For instance, consider dijkstra_shortest_path_test.cpp and a_star_test.cpp, which both define two sets of types (weighted_graph_types and weighted_graph_signed_types) in their anonymous namespace.
The goal of this issue is to extract these types and fixture definitions to a separate file test/utils/fixtures.h. This should make it easier to write tests in the future, as we can simply reuse the existing fixtures.
I would give all test files a once over to identify the fixtures we can extract, but in general I think all fixtures can be consolidated into either a fixture containing unsigned edge weights or a fixture containing signed edge weights.
More info on gtest's TYPED_TEST_SUITE can be found here.

Hey can I work on this?


Change internals to communicate via Documents and context

Right now, we have special methods that read fragments and selection sets from the store, and we also have a special data type for fragment maps, rootId, etc. I think in order to comply with our own design principles, we should simplify the interfaces between different modules, and as much as possible communicate via GraphQL Document objects.
Here's the proposal:

Remove FragmentMap entirely, and simply attach any necessary fragments to a GraphQL Document. Use graphql-anywhere to automate fragment handling so that our code never has to deal with fragment maps again.
Deprecate the readFragmentFromStore method, and replace it with a special query. A good option could be to use the Relay-style node(id: ...) query, and treat that specially as a read for the object in the store with that dataId.
Communicate all other options by attaching them to a context object as proposed by #377, which happens to be built into graphql-anywhere.

I'm game to implement this as part of a move to graphql-anywhere, if #615 is also desired.
I believe these changes will dramatically simplify the code.

I think we've made some good progress on this front. Let's look at it again and see what we still want to do before closing this issue!

We've done a fair bit, going to remove from milestone

I think we're pretty much done here. Fragments will be completely removed in 0.6


Large numbers of projects makes changie unusable

Thanks for submitting a bug report, please fill in the following details.
Description
We are evaluating changie as a possible management tool, but we are essentially a large monorepo with several hundred projects.
When we include the complete list of projects, change becomes unusable. The list projects fills more than the entire screen and only the last page are viewable.
The list is selectable, but you cannot see what you're selecting.
Reproduction Steps
Steps to reproduce the behavior:

Apply attached .changie.yaml (https://gist.github.com/andrewnicols/dbf575afbc3ece30a08f8e4b8b3ccb22)
Run changie new
Bask in the craziness of a large project

What happened
Unable to select a project
Expected behavior
A prompt with pagination, and filtering

Hmm, yea that makes sense. I am currently considering swapping over to the new charm library for forms https://github.com/charmbracelet/huh and I think it would make sense to swap to a filter option over a selection option if you had more then say 5. Thanks for providing a configuration as well, that will be very helpful for testing.

@andrewnicols I played around with huh today and its looking promising, it supports select and multi-select with built in filtering without any custom work. Going to probably make a separate ticket for that, which will also close out this when its ready. ( I submitted a small issue I would prefer to have before moving over )

@andrewnicols  i had prototyped an auto commit message engine

descriptive commits with self contained messages,
provides a hook before committing, and auto justifies the changes, git commit -m "apple ball" not required
changelog can be generated from diff history or manually going through commits before major release version
optionally specify a pull request referencing the code behind feature (WIP)
multi file tracking in message, and control length of message for brevity, may amend previous commits messages for backwards compat.

let me know if it interests you

@andrewnicols  i had prototyped an auto commit message engine

descriptive commits with self contained messages,
provides a hook before committing, and auto justifies the changes, git commit -m "apple ball" not required
changelog can be generated from diff history or manually going through commits before major release version
optionally specify a pull request referencing the code behind feature (WIP)
multi file tracking in message, and control length of message for brevity, may amend previous commits messages for backwards compat.

let me know if it interests you

You are just describing conventional commits which is not at all what this project is.

@miniscruff pardon the ambiguity the idea behind the tool was to offload the cognitive workload of developer to LLM, sometimes user may forget to fully summarize the changes like example https://docs.continue.dev/changelog#intellij-changelog
here the tool can compare the  version in package and git diff per commit on main branch, and prepend it to changelog.md . it is supposed to be used in sync with this tool using bash pipe smartcommit.py | changie - similar logic or cli use options from https://changie.dev/cli/changie_new/. the commits serves like additional  for better change logs...
Questions:
A. can changie edit previous messages or to be manually edit in generated file?
B. how many step required to create a change log, im assuming 3 after watching video.
C. are there any edge cases currently changie does not handle but occured during regular use ? (excluding current thread of text overflow issue)
D. do you identify any drawbacks with my proposed approach, given the development patterns in large+small repos (important).

@miniscruff pardon the ambiguity the idea behind the tool was to offload the cognitive workload of developer to LLM, sometimes user may forget to fully summarize the changes like example https://docs.continue.dev/changelog#intellij-changelog
here the tool can compare the  version in package and git diff per commit on main branch, and prepend it to changelog.md . it is supposed to be used in sync with this tool using bash pipe smartcommit.py | changie - similar logic or cli use options from https://changie.dev/cli/changie_new/. the commits serves like additional  for better change logs...
Questions:
A. can changie edit previous messages or to be manually edit in generated file?
B. how many step required to create a change log, im assuming 3 after watching video.
C. are there any edge cases currently changie does not handle but occured during regular use ? (excluding current thread of text overflow issue)
D. do you identify any drawbacks with my proposed approach, given the development patterns in large+small repos (important).

Would you mind creating a separate discussion instead of reusing this issue that is totally unrelated.

https://github.com/charmbracelet/huh/releases/tag/v0.5.0 dynamic forms are now available. Going to try out and see if we can move over and fix too many options finally.

I lied, they added option and title funcs but the feature I actually need is HideFunc. Sorry about that.


Support for using with storyboards

Is this possible? Maybe I'm not seeing it ;)...

See #12

What we did in my team is to create an empty view in storyboard and then create the button through code inside the view


fix: mWeb - Chat - Uploading an image while offline briefly shows an offline message in the preview.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/42657
PROPOSAL: https://github.com/Expensify/App/issues/42657#issuecomment-2133962910
Tests

Go offline
Open a report
Tap plus icon - upload an attachment image
Verify offline message is not shown

[x] Verify that no errors appear in the JS console

Offline tests

Go offline
Open a report
Tap plus icon - upload an attachment image
Verify offline message is not shown

QA Steps

Go offline
Open a report
Tap plus icon - upload an attachment image
Verify offline message is not shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/8d0affb9-2294-4ec9-91e6-ee94892a66a9

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/fd757aec-e0b5-4f56-8fa5-2175ed3130cf

iOS: Native
https://github.com/Expensify/App/assets/85894871/b392f266-5fcd-4310-87b6-389cfc8fee92

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/ac4b5a26-a579-4c86-b118-4629b19a171b

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/4b571f77-fdb8-4690-8b14-1b80da35f5ee

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/f5436a88-ac0f-49dc-b9fb-eabe58c1fcc8

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.86-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.86-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.86-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


How can we adjust the refresh rate without using JS?

Example:
0

that makes it refresh every 60 seconds or minutes?
If it should refresh every 60 seconds, than this did not work

in miliseconds


Markdown Preview following a file rename errors on old filename.

VSCode Version: 1.5.2
OS Version:  Windows 7 Professional Service Pack 1

Steps to Reproduce:

Rename a Markdown file in Explorer panel that is currently open in an Editor tab.  Note that the filename shown on the Editor tab is properly updated.
With the Editor tab for the file selected, click the Preview button.

Result:  An error message is shown stating that the file (referring to the filename before it was renamed) cannot be opened.

I can reproduce.

Additional steps to reproduce:

Open markdown file
Ctrl+K V
Move file to subfolder
Begin modifying the markdown file
Observe that changes are not reflected

This is fixed in current vscode builds because previews are now dynamic The preview is not updated if you locked it the file that is renamed
Furthermore, even if the preview's file is deleted on disk, we no longer error but keep the preview open until you close it


devicemapper support.

Hi,
This is an awsome project, and I try it on "CentOS Linux release 7.3.1611 (Core)" with docker 1.12.6, but got the following error info.
It look like unsupport the devicemapper, which is the default graphdriver of CentOS, am I right?

[root@localhost kubeadm-dind-cluster]# ./dind-cluster-v1.5.sh up
WARNING: Usage of loopback devices is strongly discouraged for production use. Use --storage-opt dm.thinpooldev to specify a custom block storage device.
WARNING: Usage of loopback devices is strongly discouraged for production use. Use --storage-opt dm.thinpooldev to specify a custom block storage device.

 See "systemctl status docker.service" and "journalctl -xe" for details.
docker failed to start. Diagnostics below:
● docker.service - Docker Application Container Engine
Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
Drop-In: /etc/systemd/system/docker.service.d
└─10-dind.conf, 20-fs.conf
Active: failed (Result: exit-code) since Tue 2017-03-28 06:47:20 UTC; 19ms ago
Docs: https://docs.docker.com
Process: 205 ExecStart=/usr/local/bin/rundocker $DOCKER_EXTRA_OPTS (code=exited, status=1/FAILURE)
Main PID: 205 (code=exited, status=1/FAILURE)

Mar 28 06:47:19 kube-master systemd[1]: Starting Docker Application Container Engine...
Mar 28 06:47:19 kube-master rundocker[205]: Trying to load overlay module (this may fail)
Mar 28 06:47:19 kube-master rundocker[205]: time="2017-03-28T06:47:19.483431970Z" level=info msg="libcontainerd: new containerd process, pid: 217"
Mar 28 06:47:20 kube-master rundocker[205]: time="2017-03-28T06:47:20.492311655Z" level=fatal msg="Error starting daemon: error initializing graphdriver: driver not supported"
Mar 28 06:47:20 kube-master systemd[1]: docker.service: Main process exited, code=exited, status=1/FAILURE
Mar 28 06:47:20 kube-master systemd[1]: Failed to start Docker Application Container Engine.
Mar 28 06:47:20 kube-master systemd[1]: docker.service: Unit entered failed state.
Mar 28 06:47:20 kube-master systemd[1]: docker.service: Failed with result 'exit-code'.
*** kubeadm failed
[root@localhost kubeadm-dind-cluster]#

Exactly that it's the case.
Instead of using device mapper please try overlay2 graph driver (needs change in /etc/sysconfig/docker-storage - this is the path on fedora, probably the same is on CentOS).

Hi @jellonek , thanks for your advice. I use the overlay2 graphdriver. Unfortunate got the same issue:

[root@localhost kubeadm-dind-cluster]# ./dind-cluster-v1.5.sh up

Making sure DIND image is up to date
Trying to pull repository docker.io/mirantis/kubeadm-dind-cluster ...
v1.5: Pulling from docker.io/mirantis/kubeadm-dind-cluster
Digest: sha256:051af9b28a1cb767e91a678d89bbaa36007606b39d1242da68f5a069481d016e
Starting DIND container: kube-master
Running kubeadm: init --skip-preflight-checks
Job for docker.service failed because the control process exited with error code. See "systemctl status docker.service" and "journalctl -xe" for details.
docker failed to start. Diagnostics below:
● docker.service - Docker Application Container Engine
Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
Drop-In: /etc/systemd/system/docker.service.d
└─10-dind.conf, 20-fs.conf
Active: failed (Result: exit-code) since Tue 2017-03-28 11:56:08 UTC; 23ms ago
Docs: https://docs.docker.com
Process: 180 ExecStart=/usr/local/bin/rundocker $DOCKER_EXTRA_OPTS (code=exited, status=1/FAILURE)
Main PID: 180 (code=exited, status=1/FAILURE)

Mar 28 11:56:07 kube-master systemd[1]: Starting Docker Application Container Engine...
Mar 28 11:56:07 kube-master rundocker[180]: Trying to load overlay module (this may fail)
Mar 28 11:56:07 kube-master rundocker[180]: time="2017-03-28T11:56:07.773915271Z" level=info msg="libcontainerd: new containerd process, pid: 205"
Mar 28 11:56:08 kube-master rundocker[180]: time="2017-03-28T11:56:08.804184359Z" level=fatal msg="Error starting daemon: error initializing graphdriver: driver not supported"
Mar 28 11:56:08 kube-master systemd[1]: docker.service: Main process exited, code=exited, status=1/FAILURE
Mar 28 11:56:08 kube-master systemd[1]: Failed to start Docker Application Container Engine.
Mar 28 11:56:08 kube-master systemd[1]: docker.service: Unit entered failed state.
Mar 28 11:56:08 kube-master systemd[1]: docker.service: Failed with result 'exit-code'.
*** kubeadm failed
[root@localhost kubeadm-dind-cluster]#
[root@localhost kubeadm-dind-cluster]# journalctl -xe
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for virbr0.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Withdrawing address record for fe80::42a:9e0d:a1b0:2f05 on ens33.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Withdrawing address record for <IP_ADDRESS> on ens33.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for ens33.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for lo.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Host name conflict, retrying with linux-114
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::3c79:e5ff:fe46:a96f on veth32f3ffb..
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::42:fbff:fe3a:b7f8 on br-530c75b72323..
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on br-530c75b72323.IPv4.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on docker0.IPv4.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on virbr1.IPv4.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on virbr0.IPv4.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::42a:9e0d:a1b0:2f05 on ens33..
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::4341:5582:cd38:9d80 on ens33..
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on ens33.IPv4.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Server startup complete. Host name is linux-114.local. Local service cookie is 358647450.
Mar 28 19:56:12 localhost.localdomain avahi-daemon[708]: Registering HINFO record with values 'X86_64'/'LINUX'.
Mar 28 19:56:19 localhost.localdomain kernel: br-530c75b72323: port 1(veth32f3ffb) entered forwarding state
Mar 28 19:56:22 localhost.localdomain kernel: dind0: port 1(eth0) entered forwarding state
Mar 28 19:56:22 localhost.localdomain dockerd-current[1061]: time="2017-03-28T19:56:22.256622979+08:00" level=error msg="Error trying v2 registry: context canceled"
Mar 28 19:56:22 localhost.localdomain dockerd-current[1061]: time="2017-03-28T19:56:22.256680048+08:00" level=error msg="Not continuing with pull after error: context cancele
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for fe80::3c79:e5ff:fe46:a96f on veth32f3ffb.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for veth32f3ffb.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for fe80::42:fbff:fe3a:b7f8 on br-530c75b72323.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for <IP_ADDRESS> on br-530c75b72323.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for br-530c75b72323.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for <IP_ADDRESS> on docker0.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for docker0.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for virbr1-nic.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for <IP_ADDRESS> on virbr1.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for virbr1.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for virbr0-nic.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for <IP_ADDRESS> on virbr0.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for virbr0.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for fe80::42a:9e0d:a1b0:2f05 on ens33.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing address record for <IP_ADDRESS> on ens33.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for ens33.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Withdrawing workstation service for lo.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Host name conflict, retrying with linux-115
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::3c79:e5ff:fe46:a96f on veth32f3ffb..
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::42:fbff:fe3a:b7f8 on br-530c75b72323..
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on br-530c75b72323.IPv4.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on docker0.IPv4.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on virbr1.IPv4.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on virbr0.IPv4.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::42a:9e0d:a1b0:2f05 on ens33..
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for fe80::4341:5582:cd38:9d80 on ens33..
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering new address record for <IP_ADDRESS> on ens33.IPv4.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Server startup complete. Host name is linux-115.local. Local service cookie is 358647450.
Mar 28 19:56:32 localhost.localdomain avahi-daemon[708]: Registering HINFO record with values 'X86_64'/'LINUX'.
[root@localhost kubeadm-dind-cluster]#

And the docker info & docker ps as followed.
Actually I run the CentOS vm (vmware) on the windows host OS, does this caused the issue?

[root@localhost kubeadm-dind-cluster]# docker info
Containers: 1
Running: 1
Paused: 0
Stopped: 0
Images: 1
Server Version: 1.12.6
Storage Driver: overlay2
Backing Filesystem: xfs
Logging Driver: journald
Cgroup Driver: systemd
Plugins:
Volume: local
Network: bridge host null overlay
Swarm: inactive
Runtimes: runc docker-runc
Default Runtime: docker-runc
Security Options: seccomp selinux
Kernel Version: 3.10.0-514.10.2.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
Number of Docker Hooks: 2
CPUs: 4
Total Memory: 7.624 GiB
Name: localhost.localdomain
ID: GDDD:OSDK:6KW5:CAHK:4LP5:22OG:R56B:FSO7:D4MF:BWGE:6UUS:P4TT
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
<IP_ADDRESS>/8
Registries: docker.io (secure)
[root@localhost kubeadm-dind-cluster]# docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS                      NAMES
45f52d28907a        mirantis/kubeadm-dind-cluster:v1.5   "/sbin/dind_init syst"   5 minutes ago       Up 5 minutes        <IP_ADDRESS>:8080->8080/tcp   kube-master
[root@localhost kubeadm-dind-cluster]#

Switch to fedora, deploy again, then everything is ok:

NAME          STATUS         AGE
kube-master   Ready,master   2h
kube-node-1   Ready          2h
kube-node-2   Ready          2h

Access dashboard at: http://localhost:8080/ui

[root@localhost kubeadm-dind-cluster]# kubectl get pod --all-namespaces
NAMESPACE     NAME                                    READY     STATUS    RESTARTS   AGE
kube-system   dummy-2088944543-20fdn                  1/1       Running   1          3h
kube-system   etcd-kube-master                        1/1       Running   1          3h
kube-system   kube-apiserver-kube-master              1/1       Running   0          3h
kube-system   kube-controller-manager-kube-master     1/1       Running   0          3h
kube-system   kube-discovery-2220406887-d6gsd         1/1       Running   1          3h
kube-system   kube-dns-1873809965-0jnhq               3/3       Running   0          3h
kube-system   kube-proxy-03s71                        1/1       Running   1          3h
kube-system   kube-proxy-1j1f8                        1/1       Running   1          3h
kube-system   kube-proxy-k5tc5                        1/1       Running   1          3h
kube-system   kube-scheduler-kube-master              1/1       Running   0          3h
kube-system   kubernetes-dashboard-3203962772-228xm   1/1       Running   0          44m
[root@localhost kubeadm-dind-cluster]# kubectl get deploy --all-namespaces
NAMESPACE     NAME                   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
kube-system   kube-discovery         1         1         1            1           3h
kube-system   kube-dns               1         1         1            1           3h
kube-system   kubernetes-dashboard   1         1         1            1           3h
[root@localhost kubeadm-dind-cluster]# kubectl get node
NAME          STATUS         AGE
kube-master   Ready,master   3h
kube-node-1   Ready          3h
kube-node-2   Ready          3h
[root@localhost kubeadm-dind-cluster]#

Thanks @jellonek for help.


Update install-additional-r-packages-on-sql-server.md

@sumitkmsft : Thanks for your contribution! The author, @HeidiSteen, has been notified to review your proposed change.

#sign-off


fix: Add automatic type promotion for FX elementwise ops

Description

Implement functionality to cast tensors to alternative types
Add functionality to elementwise ops to promote types and perform necessary casts
Address issues in FX ops where mixed-precision computations can cause errors
Add test cases to validate fix

Fixes #1995
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

Closed as changes were merged into Dynamo #2070


release-doc: document that you have to close before release

Codecov Report

:exclamation: No coverage uploaded for pull request head (pongad-patch-1@71ffd9b).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b933bd9...71ffd9b. Read the comment docs.


304: Support GZIP for decompression

We should also prob include a unit test for this as a sanity check?


Connection issue with scheduler.gl.blckstrm.com over certain WIFI

I am using the Breez SDK in my Bitcoin wallet project called Blitz Wallet. I noticed that when going through the connect to node process on my school wifi I am getting this error
[Error: Service connectivity: (LSP: 026e28eb0986871aaaba21362768daa2124dcd5d1614e9811559a6f91e95235b21) Failed to connect: status: Unavailable, message: "error trying to connect: Connection reset by peer (os error 54)", details: [], metadata: MetadataMap { headers: {} }]

I have also had a user report the same issue: https://github.com/BlakeKaufman/BlitzWallet/issues/37
Note: this does not happen on all wifi's or cell service. If I use my apartment wifi or home wifi I do not receive this error.
Here are the logs produced by the SDK during the failed connection
[DEBUG]: breez_sdk_81f7_default_config
 LOG  [DEBUG]: breez_sdk_81f7_mnemonic_to_seed
 LOG  [DEBUG]: breez_sdk_81f7_connect
 LOG  [INFO]: SDK v0.6.2 (df86eec7b0)
 LOG  [DEBUG]: some migrations defined, try to migrate
 LOG  [DEBUG]: no migration to run, db already up to date
 LOG  [DEBUG]: some migrations defined, try to migrate
 LOG  [DEBUG]: no migration to run, db already up to date
 LOG  [INFO]: Initializing signer for v24.02 (c09c1be59994b35aadfe4747b78bcdc8fffbe45a) (VLS)
 LOG  [INFO]: New node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 5, hsm_wire_max_version: 5 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 5, setting protocol_version to 5
 LOG  [DEBUG]: HsmdInitReplyV4 { hsm_version: 5, hsm_capabilities: ArrayBE([28, 142, 147, 149, 32, 34, 40]), node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323 on bitcoin
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 1, hsm_wire_max_version: 2 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 2, setting protocol_version to 2
 LOG  [DEBUG]: HsmdInitReplyV2 { node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [DEBUG]: Connecting to scheduler at https://scheduler.gl.blckstrm.com
 LOG  [DEBUG]: add_parsable_certificates processed 128 valid and 0 invalid certs
 LOG  [DEBUG]: add_parsable_certificates processed 1 valid and 0 invalid certs
 LOG  [DEBUG]: upgrading credentials
 LOG  [DEBUG]: upgrading credentials succeeded
 LOG  [INFO]: Initializing signer for v24.02 (c09c1be59994b35aadfe4747b78bcdc8fffbe45a) (VLS)
 LOG  [INFO]: New node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 5, hsm_wire_max_version: 5 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 5, setting protocol_version to 5
 LOG  [DEBUG]: HsmdInitReplyV4 { hsm_version: 5, hsm_capabilities: ArrayBE([28, 142, 147, 149, 32, 34, 40]), node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323 on bitcoin
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 1, hsm_wire_max_version: 2 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 2, setting protocol_version to 2
 LOG  [DEBUG]: HsmdInitReplyV2 { node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [DEBUG]: add_parsable_certificates processed 128 valid and 0 invalid certs
 LOG  [INFO]: keep alive started
 LOG  [DEBUG]: resolving host="bs1.breez.technology"
 LOG  [INFO]: Starting existing node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [DEBUG]: connecting to <IP_ADDRESS>:443
 LOG  [DEBUG]: connected to <IP_ADDRESS>:443
 LOG  [DEBUG]: No cached session for DnsName(DnsName(DnsName("bs1.breez.technology")))
 LOG  [DEBUG]: Not resuming any session
 LOG  [DEBUG]: Using ciphersuite TLS13_AES_128_GCM_SHA256
 LOG  [DEBUG]: Not resuming
 LOG  [DEBUG]: TLS1.3 encrypted extensions: [Protocols([6832])]
 LOG  [DEBUG]: ALPN protocol is Some(b"h2")
 LOG  [DEBUG]: Ticket saved
 LOG  [DEBUG]: binding client connection
 LOG  [DEBUG]: client connection bound
 LOG  [DEBUG]: send frame=Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384 }
 LOG  [DEBUG]: Connection; peer=Client
 LOG  [DEBUG]: service.ready=true message=processing request
 LOG  [DEBUG]: send frame=WindowUpdate { stream_id: StreamId(0), size_increment: 5177345 }
 LOG  [DEBUG]: send frame=Headers { stream_id: StreamId(1), flags: (0x4: END_HEADERS) }
 LOG  [DEBUG]: service.ready=true message=processing request
 LOG  [DEBUG]: send frame=Headers { stream_id: StreamId(3), flags: (0x4: END_HEADERS) }
 LOG  [DEBUG]: send frame=Data { stream_id: StreamId(1) }
 LOG  [DEBUG]: send frame=Data { stream_id: StreamId(1), flags: (0x1: END_STREAM) }
 LOG  [DEBUG]: send frame=Data { stream_id: StreamId(3) }
 LOG  [DEBUG]: send frame=Data { stream_id: StreamId(3), flags: (0x1: END_STREAM) }
 LOG  [DEBUG]: received frame=Settings { flags: (0x0), header_table_size: 4096, max_concurrent_streams: 250, initial_window_size: 1048576, max_frame_size: 1048576, max_header_list_size: 1048896 }
 LOG  [DEBUG]: send frame=Settings { flags: (0x1: ACK) }
 LOG  [DEBUG]: received frame=WindowUpdate { stream_id: StreamId(0), size_increment: 983041 }
 LOG  [DEBUG]: received frame=Settings { flags: (0x1: ACK) }
 LOG  [DEBUG]: received settings ACK; applying Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384 }
 LOG  [DEBUG]: received frame=Headers { stream_id: StreamId(1), flags: (0x4: END_HEADERS) }
 LOG  [DEBUG]: received frame=Data { stream_id: StreamId(1) }
 LOG  [DEBUG]: received frame=Headers { stream_id: StreamId(1), flags: (0x5: END_HEADERS | END_STREAM) }
 LOG  [DEBUG]: received frame=Headers { stream_id: StreamId(3), flags: (0x4: END_HEADERS) }
 LOG  [DEBUG]: received frame=Data { stream_id: StreamId(3) }
 LOG  [DEBUG]: received frame=Headers { stream_id: StreamId(3), flags: (0x5: END_HEADERS | END_STREAM) }
 LOG  [DEBUG]: connecting to lsp 026e28eb0986871aaaba21362768daa2124dcd5d1614e9811559a6f91e95235b21@<IP_ADDRESS>:9735
 LOG  [DEBUG]: Connecting to scheduler at https://scheduler.gl.blckstrm.com
 LOG  [DEBUG]: add_parsable_certificates processed 128 valid and 0 invalid certs
 LOG  [DEBUG]: add_parsable_certificates processed 1 valid and 0 invalid certs
 LOG  [DEBUG]: resolving host="scheduler.gl.blckstrm.com"
 LOG  [DEBUG]: connecting to <IP_ADDRESS>:443
 LOG  [DEBUG]: connected to <IP_ADDRESS>:443
 LOG  [DEBUG]: No cached session for DnsName(DnsName(DnsName("scheduler.gl.blckstrm.com")))
 LOG  [DEBUG]: Not resuming any session
 LOG  [DEBUG]: reconnect::poll_ready: hyper::Error(Connect, Os { code: 54, kind: ConnectionReset, message: "Connection reset by peer" })
 LOG  [DEBUG]: service.ready=true message=processing request
 LOG  [DEBUG]: error: error trying to connect: Connection reset by peer (os error 54)
 LOG  [Error: Service connectivity: (LSP: 026e28eb0986871aaaba21362768daa2124dcd5d1614e9811559a6f91e95235b21) Failed to connect: status: Unavailable, message: "error trying to connect: Connection reset by peer (os error 54)", details: [], metadata: MetadataMap { headers: {} }] connect to node err
 LOG  [DEBUG]: Connecting to scheduler at https://scheduler.gl.blckstrm.com
 LOG  [DEBUG]: add_parsable_certificates processed 128 valid and 0 invalid certs
 LOG  [DEBUG]: add_parsable_certificates processed 1 valid and 0 invalid certs
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323 on bitcoin
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 5, hsm_wire_max_version: 5 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 5, setting protocol_version to 5
 LOG  [DEBUG]: HsmdInitReplyV4 { hsm_version: 5, hsm_capabilities: ArrayBE([28, 142, 147, 149, 32, 34, 40]), node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323 on bitcoin
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 5, hsm_wire_max_version: 5 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 5, setting protocol_version to 5
 LOG  [DEBUG]: HsmdInitReplyV4 { hsm_version: 5, hsm_capabilities: ArrayBE([28, 142, 147, 149, 32, 34, 40]), node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [DEBUG]: DeriveSecret(DeriveSecret { info: 626f6c7431322d696e766f6963652d62617365 })
 LOG  [DEBUG]: DeriveSecretReply { secret: ****** }
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323 on bitcoin
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 5, hsm_wire_max_version: 5 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 5, setting protocol_version to 5
 LOG  [DEBUG]: HsmdInitReplyV4 { hsm_version: 5, hsm_capabilities: ArrayBE([28, 142, 147, 149, 32, 34, 40]), node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [DEBUG]: DeriveSecret(DeriveSecret { info:<PHONE_NUMBER>6563726574 })
 LOG  [DEBUG]: DeriveSecretReply { secret: ****** }
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323
 LOG  [INFO]: Restore node 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323 on bitcoin
 LOG  [INFO]: vls_protocol_signer::handler::HandlerBuilder::build:: NodeState::summary 03bf: 0 invoices, 0 issued_invoices, 0 payments, excess_amount 0
 LOG  [DEBUG]: HsmdInit(HsmdInit { key_version: Bip32KeyVersion { pubkey_version: "0x0", privkey_version: "0x0" }, chain_params:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000, encryption_key: None, dev_privkey: None, dev_bip32_seed: None, dev_channel_secrets: None, dev_channel_secrets_shaseed: None, hsm_wire_min_version: 5, hsm_wire_max_version: 5 })
 LOG  [INFO]: signer protocol_version 6, node hsm_wire_max_version 5, setting protocol_version to 5
 LOG  [DEBUG]: HsmdInitReplyV4 { hsm_version: 5, hsm_capabilities: ArrayBE([28, 142, 147, 149, 32, 34, 40]), node_id: 03bf80b86dd14fff3042281eadc8f79abc0aa5ac95c8c9bf8bfe9e34c209cda323, bip32: 0488b21e028e13bce7000000004e72d8ea89749cfc06485b326ccad5facb0920edcba3552df2f6959ce95e810e02d23d1aca89da21433e01651496a3643d71dd4707ae85104511e2679f7c6218d6, bolt12: 0357e3d58b97f0dc57d02e85dfd5d29178457272210d05b059305fa3703a078c81 }
 LOG  [DEBUG]: DeriveSecret(DeriveSecret { info: 636f6d6d616e646f })
 LOG  [DEBUG]: DeriveSecretReply { secret: ****** }
 LOG  [DEBUG]: Storing canned request-response: [0, 27, 0, 19, 98, 111, 108, 116, 49, 50, 45, 105, 110, 118, 111, 105, 99, 101, 45, 98, 97, 115, 101] -> [0, 127, 231, 195, 80, 160, 127, 203, 42, 149, 130, 84, 200, 114, 236, 193, 97, 198, 70, 31, 75, 209, 96, 37, 132, 180, 197, 140, 156, 83, 90, 90, 134, 228]
 LOG  [DEBUG]: Storing canned request-response: [0, 27, 0, 10, 115, 99, 98, 32, 115, 101, 99, 114, 101, 116] -> [0, 127, 77, 85, 100, 146, 170, 173, 159, 27, 209, 144, 154, 193, 193, 177, 151, 101, 181, 188, 154, 7, 35, 162, 160, 81, 103, 24, 94, 55, 21, 245, 86, 81]
 LOG  [DEBUG]: Storing canned request-response: [0, 27, 0, 8, 99, 111, 109, 109, 97, 110, 100, 111] -> [0, 127, 188, 46, 195, 97, 130, 48, 59, 74, 134, 226, 235, 51, 159, 198, 45, 106, 122, 133, 86, 143, 178, 92, 14, 170, 55, 54, 34, 185, 236, 117, 143, 41]
 LOG  [DEBUG]: resolving host="scheduler.gl.blckstrm.com"
 LOG  [DEBUG]: connecting to <IP_ADDRESS>:443
 LOG  [DEBUG]: connected to <IP_ADDRESS>:443
 LOG  [DEBUG]: No cached session for DnsName(DnsName(DnsName("scheduler.gl.blckstrm.com")))
 LOG  [DEBUG]: Not resuming any session
 LOG  [DEBUG]: reconnect::poll_ready: hyper::Error(Connect, Os { code: 54, kind: ConnectionReset, message: "Connection reset by peer" })
 LOG  [DEBUG]: service.ready=true message=processing request
 LOG  [DEBUG]: error: error trying to connect: Connection reset by peer (os error 54)
 LOG  [DEBUG]: Cannot connect to scheduler, sleeping and retrying

We've had this situation a couple of times before. If the connection to scheduler.gl.blckstrm.com is the only affected connection it is likely that your school is using DPI with a custom root certificate installed on the clients, that allows the firewall to decrypt the traffic between client and server. This strips not only the original server TLS envelope, but also the client authentication we use to identify the client.
We documented this in the FaQ here: https://github.com/Blockstream/greenlight/pull/546/files
Can you check with the network admins to see if they are doing DPI, and maybe ask what would be required for an exemption from it?


Update http4s-client, http4s-dsl to 0.23.11

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl

from 0.23.7 to 0.23.11.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #565.


Upload of large files fails due to 32 mb limit

Problem statement
Failing to upload file more than 32mb
Please remove the sections that don't apply
Swagger specification
post:
      tags:
        - ...
      summary: Agent API to upload logs.
      operationId: UploadFile
      consumes:
        - multipart/form-data
      parameters:
        - in: path
          name: id
          type: string
          format: uuid
          required: true
        - in: formData
          name: upfile
          type: file
          required: false
          description: The file to upload.

Steps to reproduce
auto generated curl with file of size bigger than 32mb
Environment
swagger version: 2.0
go version: go1.14.3
OS:  Centos
if err := r.ParseMultipartForm(32 << 20); err != nil { 		if err != http.ErrNotMultipart { 			return errors.New(400, "%v", err) 		} else if err := r.ParseForm(); err != nil { 			return errors.New(400, "%v", err) 		} 	}
fails with 400.
There is a way to upload large file without changing this part?
Thanks a lot.

found an issue caused by using scratch as docker image. It doesn't have /tmp


Create a script for a virtual Python env to run benchmark tasks

Subtask of #1
The idea is to create a script that will be run one time to gather historical data for average of circuit depth and gate count, implemented here.
Once the backfill is complete, this structure can be used to run any benchmark tasks on newer qiskit versions. This automation will be implemented as a separate PR.

Get all qiskit versions from pip command pip index versions qiskit and filter those since 2020-03-24 (last update in metriq), hard code it for one time run to build historical data.
The entry point is a script that creates on tox environment per qiskit version. Input parameter is qiskit version (later on, also python version and the benchmark script - since in the future there can be other tasks).
The script creates a tox environment with the given qiskit version, loads the benchmark script, run it N times (starting at 100) and outputs the average of circuit depth and gate count (first print to screen, later it can output to a file).
Once the job is complete, the environment is shut down and cleaned.

@1ucian0
pip index versions qiskit lists all major and minor versions, is it ok to use them all (since March 2020)?


Android: disable in-app purchases

I wouldn't mind an optional donation IAP (that should go to you, obviously).

I wouldn't mind an optional donation IAP (that should go to you, obviously).

We've detected that this app is using an old version of Google Play Billing. By 1 November 2021, all app updates must use billing library version 3 or newer. Update to billing library 3 before this date

We've detected that this app is using an old version of Google Play Billing. By 1 November 2021, all app updates must use billing library version 3 or newer. Update to billing library 3 before this date


How can we get the added sticker image view updated dimension after scaling?

Currently, there is no public API for accessing it. Not sure but this might help #260 (comment)


Only release build of Android crash with React Native version mismatch error

New Version
0.63.3
Old Version
0.59.9
Build Target(s)
Android emulator and device release build
Output of react-native info
System:
OS: macOS 11.6.1
CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
Memory: 56.03 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 16.2.0 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 7.13.0 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /Users/tahara_satoshi/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK:
API Levels: 26, 27, 28, 29, 30, 31
Build Tools: 23.0.1, 25.0.2, 26.0.2, 26.0.3, 27.0.3, 28.0.1, 28.0.3, 29.0.2, 30.0.2
System Images: android-26 | Google Play Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google Play Intel x86 Atom_64, android-S | Google APIs ARM 64 v8a, android-S | Google APIs Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7935034
Xcode: 13.2/13C90 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_131 - /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.3 => 0.63.3
react-native-macos: Not Found
npmGlobalPackages:
Issue and Reproduction Steps
I've upgraded react native on iOS branch to version 0.63.3 and merged android branch with react native version 0.59.8.
I modified Android specific files manually by upgrade-helper and works fine with iOS debug build, release build and Android debug build.
However only android release build crashes  after launch app with react native version mismatch error.
npx react-native run-android --variant=release
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 1738 file(s) to forward-jetify. Using 8 workers...
info Starting JS server...
info Installing the app...

> Configure project :app
Reading env from: .env.production

> Configure project :@mauron85_react-native-background-geolocation-common
WARNING: The option 'android.enableUnitTestBinaryResources' is deprecated.
The current default is 'false'.
It has been removed from the current version of the Android Gradle plugin.
The raw resource for unit test functionality is removed.

> Configure project :react-native-firebase_admob
:react-native-firebase_admob package.json found at<EMAIL_ADDRESS>:react-native-firebase_app package.json found at<EMAIL_ADDRESS>:react-native-firebase_admob:ads.consent using default value: 1.0.6
:react-native-firebase_admob package.json found at<EMAIL_ADDRESS>:react-native-firebase_admob:version set from package.json: 11.5.0 (11,5,0 - 11005000)
:react-native-firebase_admob:android.compileSdk using custom value: 29
:react-native-firebase_admob:android.targetSdk using custom value: 29
:react-native-firebase_admob:android.minSdk using custom value: 24
:react-native-firebase_admob:reactNativeAndroidDir /Users/developer/Projects/sis/ReactNative/APP/node_modules/react-native/android

> Configure project :react-native-firebase_app
:react-native-firebase_app package.json found at<EMAIL_ADDRESS>:react-native-firebase_app:firebase.bom using default value: 26.8.0
:react-native-firebase_app:play.play-services-auth using default value: 19.0.0
:react-native-firebase_app package.json found at<EMAIL_ADDRESS>:react-native-firebase_app:version set from package.json: 11.5.0 (11,5,0 - 11005000)
:react-native-firebase_app:android.compileSdk using custom value: 29
:react-native-firebase_app:android.targetSdk using custom value: 29
:react-native-firebase_app:android.minSdk using custom value: 24
:react-native-firebase_app:reactNativeAndroidDir /Users/developer/Projects/sis/ReactNative/APP/node_modules/react-native/android

> Task :@react-native-community_netinfo:compileReleaseJavaWithJavac

> Task :@mauron85_react-native-background-geolocation-common:compileReleaseJavaWithJavac

> Task :app:generateReleaseBuildConfig
Reading env from: .env.production

> Task :@mauron85_react-native-background-geolocation:compileReleaseJavaWithJavac

> Task :app:bundleReleaseJsAndAssets
warning: the transform cache was reset.
                 Welcome to React Native!
                Learn once, write anywhere

info Writing bundle output to:, /Users/developer/Projects/sis/ReactNative/APP/android/app/build/generated/assets/react/release/index.android.bundle
info Writing sourcemap output to:, /Users/developer/Projects/sis/ReactNative/APP/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map
info Done writing bundle output
info Done writing sourcemap output
info Copying 241 asset files
info Done copying assets

> Task :react-native-community_toolbar-android:compileReleaseJavaWithJavac

> Task :react-native-device-info:compileReleaseJavaWithJavac

> Task :react-native-fbsdk-next:compileReleaseJavaWithJavac

> Task :react-native-firebase_app:compileReleaseJavaWithJavac

> Task :react-native-fs:compileReleaseJavaWithJavac

> Task :react-native-gesture-handler:compileReleaseJavaWithJavac

> Task :react-native-image-crop-picker:compileReleaseJavaWithJavac

> Task :react-native-image-resizer:compileReleaseJavaWithJavac

> Task :react-native-screens:compileReleaseJavaWithJavac

> Task :react-native-firebase_admob:compileReleaseJavaWithJavac

> Task :react-native-video:compileReleaseJavaWithJavac

> Task :react-native-webview:compileReleaseJavaWithJavac

> Task :rn-fetch-blob:compileReleaseJavaWithJavac

> Task :react-native-video-processing:stripReleaseDebugSymbols
Unable to strip the following libraries, packaging them as they are: libffmpeg.so.

> Task :app:stripReleaseDebugSymbols
Unable to strip the following libraries, packaging them as they are: libavcodec.so, libavformat.so, libavutil.so, libc++_shared.so, libfb.so, libfbjni.so, libffmpeg.so, libffmpeg_mediametadataretriever_jni.so, libfolly_futures.so, libfolly_json.so, libglog.so, libglog_init.so, libhermes-executor-debug.so, libhermes-executor-release.so, libhermes-inspector.so, libimagepipeline.so, libjsc.so, libjscexecutor.so, libjsijniprofiler.so, libjsinspector.so, libnative-filters.so, libnative-imagetranscoder.so, libreactnativeblob.so, libreactnativejni.so, libswscale.so, libucrop.so, libyoga.so.

> Task :app:installRelease
Installing APK 'app-release.apk' on 'Pixel_4_Android_12_API_31(AVD) - 12' for app:release
Installed on 1 device.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m 21s
616 actionable tasks: 266 executed, 350 up-to-date
info Connecting to the development server...
info Starting the app on "emulator-5554"...
Starting: Intent { cmp=com.myapp/.MainActivity }

App was installed successfully but it crashes on launch.
The error of Logcat message is below.
2021-12-15 18:25:17.189 30931-30931/? W/dex2oat64: Mismatch between dex2oat instruction set features to use (ISA: X86_64 Feature string: -ssse3,-sse4.1,-sse4.2,-avx,-avx2,-popcnt) and those from CPP defines (ISA: X86_64 Feature string: ssse3,sse4.1,sse4.2,-avx,-avx2,popcnt) for the command line:
    /apex/com.android.art/bin/dex2oat64 --zip-fd=7 --zip-location=base.apk --oat-fd=8 --oat-location=/data/app/~~MXrpo1tQeuQoRbFspENeiA==/com.myapp-7t0eoFAWoyt7Sm3qwUCD_w==/oat/x86_64/base.odex --input-vdex-fd=-1 --output-vdex-fd=9 --swap-fd=10 --classpath-dir=/data/app/~~MXrpo1tQeuQoRbFspENeiA==/com.myapp-7t0eoFAWoyt7Sm3qwUCD_w== --class-loader-context=PCL[]{PCL[/system/framework/android.test.base.jar]} --compact-dex-level=none --instruction-set=x86_64 --instruction-set-features=default --instruction-set-variant=x86_64 --compiler-filter=speed-profile --compilation-reason=install --max-image-block-size=524288 --resolve-startup-const-strings=true --generate-mini-debug-info --runtime-arg -Xtarget-sdk-version:29 --runtime-arg -Xhidden-api-policy:enabled --runtime-arg -Xms64m --runtime-arg -Xmx512m
2021-12-15 18:25:20.431 31006-31006/? V/fb-UnpackingSoSource: deps mismatch on deps store: regenerating
2021-12-15 18:25:22.201 31006-31120/? E/ReactNativeJS: React Native version mismatch.

    JavaScript version: 0.59.8
    Native version: 0.63.3

    Make sure that you have rebuilt the native code. If the problem persists try clearing the Watchman and packager caches with `watchman watch-del-all && react-native start --reset-cache`.
2021-12-15 18:25:22.273 31006-31126/? E/unknown:ReactNative: console.error: "React Native version mismatch.

    JavaScript version: 0.59.8
    Native version: 0.63.3

    Make sure that you have rebuilt the native code. If the problem persists try clearing the Watchman and packager caches with `watchman watch-del-all && react-native start --reset-cache`.", stack:
    checkVersions@106:306
    <unknown>@105:63
    h@2:1670
    <unknown>@91:92
    h@2:1670
    d@2:868
    global code@1135:4

I've done these solutions below, but does not work.
rm -rf node_modules
rm -rf $TMPDIR/react-native-packager-cache-*
rm -rf $TMPDIR/metro-bundler-cache-*
yarn cache clean
yarn
yarn patch-package
watchman watch-del-all && react-native start --reset-cache
cd android/
./gradlew clean

@vamper424 What did you upload? I can't see your image since link is broken.

Is false.
El dom., 19 de diciembre de 2021 5:45 p. m., DIGITALSQUAD <
@.***> escribió:

@vamper424 https://github.com/vamper424 What did you upload? I can't
see your image since link is broken.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/32765#issuecomment-997498724,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARK2MXL7XUUJX6YUTWSJLKDURZ4ELANCNFSM5KDEKYJQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

0.63.3

That's a really old version of RN. Have you tried updating to the latest? Also have you tried to reproduce this on a fresh RN project?

@cortinico I'm trying to reproduce a fresh project on a new branch and merge components from the main branch into the branch, but it takes a long time to install and set up packages.


How customize the Next, Back and Done button color, default is white

My main screen color is white, So Next, back and done button text/title color is white by default. So, these buttons are not visible. How can we change the text/title color of these buttons?

A solution that I would also appreciate is that both styles.bottomButton.backgroundColor and styles.buttonText.backgroundColor could be set by the user.
However they are only used by 2 out of the 4 buttons...

@golles I'm honestly not a big fan of adding so many new props. To keep it much more customizable I prefer that people implement their own render{x}Button-methods.

@vvavdiya let me know if my approach does not work for you.

HI @Jacse How can i achieve this please guide how can i change colour of NEXT skip button etc

Please Guide me Thanks

There is no option to handle from the main component so I find the solution Just go
(node_modules/react-native-app-intro-slider/Appslider.js) you can customize each and everything from this file
Thanks


Update README.md

After cloning dirname is pdf.js not pdfjs and need to install npm dependecies

Fixed with some added improvements in #5991. Thanks!


Fix the auth failure in v3 api /version and /health.

Coverage remained the same at 70.078% when pulling 81aa76f1fc5e8896660da1a32c4a785a61adc0b1 on little-cui:master into 6a162b4306337503986923c315a521625c92b7eb on ServiceComb:master.

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   65.74%   65.74%
=======================================
  Files          18       18
  Lines        4359     4359
=======================================
  Hits         2866     2866
  Misses       1313     1313
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a162b4...81aa76f. Read the comment docs.


Current Page Number Feature

An EPUB 3 file may contain a page-list nav element which is used quite often in academic settings.
It would be nice if the toolkit made the current page number(s) available to reading system creators for reflowable publications.

Here are download links for two New York University Press Books that have a page list. These are open access books and can be used freely elsewhere.
NYU Press Books


apply: new ApplyState function supporting deletion

Add support to deleting objects, not just to create or updated them. After all, "this object must not be present" is a valid desired state as well.
To minimize risks and API changes, add a new top-level API which supports deletion, augmenting the old API which was only supporting create or update; the old API won't gain delete-support, but will be deprecated when the new one graduates to stable, hopefully later on in this cycle.

/cc @Tal-or

Lets add another commit which actually wiring this function so we can see that it works and tests are passing correctly.

/hold
need to remove the demo commit

/hold
need to remove the demo commit

What are we waiting for? if it's working let's keep it. One less thing to worry for

/hold
need to remove the demo commit

What are we waiting for? if it's working let's keep it. One less thing to worry for

Because I'd introduce the new API in the new HCP-related flow first. There are too many changes in flight already (for the resources we have) and I want to contain the interference radius but still keep improving the codebase.
It's a tradeoff.

/hold
need to remove the demo commit

What are we waiting for? if it's working let's keep it. One less thing to worry for

Because I'd introduce the new API in the new HCP-related flow first. There are too many changes in flight already (for the resources we have) and I want to contain the interference radius but still keep improving the codebase. It's a tradeoff.

Ack. so shall we unhold #1025? I kept the hold only because I thought we want this change, but it won't affect anyway

/hold
need to remove the demo commit

What are we waiting for? if it's working let's keep it. One less thing to worry for

Because I'd introduce the new API in the new HCP-related flow first. There are too many changes in flight already (for the resources we have) and I want to contain the interference radius but still keep improving the codebase. It's a tradeoff.

Ack. so shall we unhold #1025? I kept the hold only because I thought we want this change, but it won't affect anyway since it's not wired.

yes, I'd unhold #1025, then I'll rebase this one on top and port only the new flow to the new API. We will add other improvements later.

CI passed. you may remove the demo commit, i'll approve

/hold cancel

I'll remove all errors.Wrapf in one go in a followup PR:
controllers/kubeletconfig_controller.go:200:			return nil, errors.Wrapf(err, "Failed to set controller reference to %s %s", objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/kubeletconfig_controller.go:203:			return nil, errors.Wrapf(err, "could not create %s", objState.Desired.GetObjectKind().GroupVersionKind().String())
controllers/numaresourcesoperator_controller.go:186:		return false, errors.Wrapf(err, "could not update status for object %s", client.ObjectKeyFromObject(instance))
controllers/numaresourcesoperator_controller.go:206:		return true, ctrl.Result{}, status.ConditionDegraded, errors.Wrapf(err, "FailedAPISync")
controllers/numaresourcesoperator_controller.go:220:		return true, ctrl.Result{}, status.ConditionDegraded, errors.Wrapf(err, "failed to sync machine configs")
controllers/numaresourcesoperator_controller.go:241:		return true, ctrl.Result{}, status.ConditionDegraded, errors.Wrapf(err, "FailedRTESync")
controllers/numaresourcesoperator_controller.go:313:			err = errors.Wrapf(err2, "could not create %s", objState.Desired.GetObjectKind().GroupVersionKind().String())
controllers/numaresourcesoperator_controller.go:341:				err = errors.Wrapf(err2, "failed to set controller reference to %s %s", objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/numaresourcesoperator_controller.go:479:			return nil, errors.Wrapf(err, "failed to update (%s) %s/%s", objState.Desired.GetObjectKind().GroupVersionKind(), objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/numaresourcesoperator_controller.go:483:			return nil, errors.Wrapf(err, "failed to set controller reference to %s %s", objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/numaresourcesoperator_controller.go:487:			return nil, errors.Wrapf(err, "failed to apply (%s) %s/%s", objState.Desired.GetObjectKind().GroupVersionKind(), objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/numaresourcesscheduler_controller.go:149:		return ctrl.Result{}, status.ConditionDegraded, errors.Wrapf(err, "FailedSchedulerSync")
controllers/numaresourcesscheduler_controller.go:238:			return schedStatus, errors.Wrapf(err, "Failed to set controller reference to %s %s", objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/numaresourcesscheduler_controller.go:242:			return schedStatus, errors.Wrapf(err, "could not apply (%s) %s/%s", objState.Desired.GetObjectKind().GroupVersionKind(), objState.Desired.GetNamespace(), objState.Desired.GetName())
controllers/numaresourcesscheduler_controller.go:258:		return errors.Wrapf(err, "could not update status for object %s", client.ObjectKeyFromObject(sched))
pkg/apply/apply.go:50:			err = errors.Wrapf(err, "could not delete object %s", objDesc)
pkg/apply/apply.go:67:			err = errors.Wrapf(err, "could not create object %s", objDesc)
pkg/apply/apply.go:77:		return nil, false, errors.Wrapf(err, "could not merge object %s with existing", objDesc)
pkg/apply/apply.go:81:		return nil, false, errors.Wrapf(err, "could not compare object %s with existing", objDesc)
pkg/apply/apply.go:87:			return nil, updated, errors.Wrapf(err, "could not update object %s", objDesc)
pkg/hash/configmap.go:48:			return "", errors.Wrapf(err, "could not calculate ConfigMap %q hash", key.String())

here: https://github.com/openshift-kni/numaresources-operator/pull/1039


Jasmine's clock mocks can't be used in library specs

🐞 Bug report
Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
Not sure to be honest, but it works if the sample spec is part of the application in the workspace.
Description
Attempting to use Jasmine's clock mocks inside tests of CLI generated libraries throws an error saying 'Jasmine Clock was unable to install over custom global timer functions.'. It seems Jasmine is imported before Zone.js and therefore detects that the global timing functions, such as setTimeout, were changed afterwoods.
The issue is similar to https://github.com/angular/angular-cli/issues/11626.
🔬 Minimal Reproduction

1. npm install --global @angular/cli.
2. ng new test-app
3. cd test-app
4. ng g library time-lib
5. ng test time-lib (passes)

6. Add the following test to a spec file inside the lib-1
 (e.g.: into "time-lib.service.spec.ts"):

 it('should install the clock mock', () => {
    jasmine.clock().install();
    jasmine.clock().uninstall();
  });

7. ng test time-lib (fails)

🔥 Exception or Error

Chrome 74.0.3729 (Windows 10.0.0) TimeLibService should install the clock mock FAILED
        Error: Jasmine Clock was unable to install over custom global timer functions. Is the clock already installed?
            at UserContext. (src/lib/time-lib.service.spec.ts:14:21)
            at ZoneDelegate.push.../../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (C:/DEV/_test_projects/test-app/node_modules/zone.js/dist/zone.js:391:1)
            at ProxyZoneSpec.push.../../node_modules/zone.js/dist/zone-testing.js.ProxyZoneSpec.onInvoke (C:/DEV/_test_projects/test-app/node_modules/zone.js/dist/zone-testing.js:289:1)
            at ZoneDelegate.push.../../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (C:/DEV/_test_projects/test-app/node_modules/zone.js/dist/zone.js:390:1)
            at Zone.push.../../node_modules/zone.js/dist/zone.js.Zone.run (C:/DEV/_test_projects/test-app/node_modules/zone.js/dist/zone.js:150:1)
            at runInTestZone (C:/DEV/_test_projects/test-app/node_modules/zone.js/dist/zone-testing.js:510:1)
            at UserContext. (C:/DEV/_test_projects/test-app/node_modules/zone.js/dist/zone-testing.js:525:1)

🌍 Your Environment

Angular CLI: 7.3.9
Node: 8.11.2
OS: win32 x64
Angular: 7.2.15
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.13.9
@angular-devkit/build-angular      0.13.9
@angular-devkit/build-ng-packagr   0.13.9
@angular-devkit/build-optimizer    0.13.9
@angular-devkit/build-webpack      0.13.9
@angular-devkit/core               7.3.9
@angular-devkit/schematics         7.3.9
@angular/cli                       7.3.9
@ngtools/json-schema               1.1.0
@ngtools/webpack                   7.3.9
@schematics/angular                7.3.9
@schematics/update                 0.13.9
ng-packagr                         4.7.1
rxjs                               6.3.3
typescript                         3.2.4
webpack                            4.29.0

Anything else relevant?
Based on the fix for https://github.com/angular/angular-cli/issues/11626, adding a (e.g.) test-pollyfill.ts to the library source and moving the zone.js import from the library's test.ts file into the test-pollyfill.ts file, then configuring the test architecture of the library's project in angular.jsonto use the file as the 'pollyFills' option seems to be a possible workaround for now.

any update for the fix?

I had a look at this and the problem is indeed that Jasmine is loaded prior to zone.js. To force zone.js to be loaded prior to Jasmine you can use a polyfills file.

creating a polyfills.ts file in the library src folder contain the zone.js import

import 'zone.js/dist/zone';

Remove the import from karma.confg.js
Finally reference the polyfills.ts in the builder configuration

"test": {
  "builder": "@angular-devkit/build-angular:karma",
  "options": {
    "polyfills": "projects/asdasd/src/polyfills.ts",
    "main": "projects/asdasd/src/test.ts",
    "tsConfig": "projects/asdasd/tsconfig.spec.json",
    "karmaConfig": "projects/asdasd/karma.conf.js"
  }
},

As far as I can tell, this is still an issue.
Just a couple of notes on the suggested workarounds:

The import you need to remove is in test.js not karma.config.js
You also need to add a reference to the the test pollyfills file in the files section of tsconfig.spec.json

this is still an issue with Angular 14, and the workaround doesnt work for me :(


Switching back from custom to native title bar style has title bar rendering issues

Steps to Reproduce:

Open VS Code with title bar style set to custom
Go to full screen mode
Change the style to native
Come out of full screen

See how title bar is rendered

Yeah, changing the title bar style needs a full restart and we should just prompt the user that a restart is required after changing this setting.

No longer reproduces.

Still reproes for me, without a full restart -

@roblourens steps?

Exactly @sandy081's original steps

Got it, the steps to reproduce are not correct, I will fix them.

Changing this option is now asking for a restart.


Custom metadata for VersionInfo table is not detected

I have created my custom class implementing the IVersionTableMetaData interface (including the VersionTableMetaData attribute). Unfortunately the migration runner doesn't detect my custom implemention (it used to work in a previous release). I also tried to inherit from the DefaultVersionTableMetaData class, but without luck.
I'm using a custom migration runner, which is embedded in our custom maintenance tool. The code executing the runner looks like this:
private MigrationRunner GetMigrationRunner(IAnnouncer announcer, bool previewOnly)
{
            Assembly assembly = Assembly.GetExecutingAssembly();

            RunnerContext migrationContext = new RunnerContext(announcer)
            {
                Namespace = "xxx.xxx.DbTool.Migrator.Migrations"
            };

            MigrationOptions migrationOptions = new MigrationOptions();
            migrationOptions.PreviewOnly = previewOnly;
            migrationOptions.Timeout = 60;

            SqlServer2005ProcessorFactory factory = new SqlServer2005ProcessorFactory();
            IMigrationProcessor processor = factory.Create(_connectionString, announcer, migrationOptions);

            return new MigrationRunner(assembly, migrationContext, processor);
}

@danehnert Ok tracked it down to this commit
https://github.com/schambers/fluentmigrator/commit/0382e5333c8880bc01c65c7cf86fd031689cf96c
It changes the way types are found but also for the versionmetadata

@istaheev @tommarien, should VersonLoader simply not filter by namespace? It changed again in commit 525e4330, but is still filtering by namespace.

The namespace should be respected too to enable different namespaces for different databases.


Cannot seem to get oVersion to work in Visual Studio 2022

I have installed oVersion through Visual Studio market place, but it doesnt seem to work for me?

I expected it to auto increment, Have I got it wrong?

No it doesn't do that, it just make changing the version easier, as it was released for VS2022 before any other Version changer. that feature may be added in the future.

#5


Custom Plugin in Chat-Copilot Fetching Outdated Data Instead of Up-to-Date Results

Describe the bug
When enabling my custom plugin through Chat-Copilot and running it, the plugin doesn't provide up-to-date results. Specifically, I've created a custom plugin named "Grocery App Plugin," allowing users to add, list, and remove items. While using Swagger to add items to the list, I can retrieve the complete list of items. However, when running the same plugin through Chat-Copilot, it seems to fetch outdated data, appearing as if the planner is providing historical details. I'm utilizing the "Action" Planner /"Sequential" Planner with the gpt-35-turbo model.
To Reproduce
Steps to reproduce the behavior:
1.Enable custom plugin -"Grocery App Plugin"
2.List the grocery items using "Grocery App Plugin."
3.Attempt to add an item using the plugin or Swagger
4.Run the plugin to list the items.
5.Compare the listed items with the actual up-to-date list.
Expected behavior
I expected the plugin to fetch and display the most recent data when using Chat-Copilot, similar to the behavior when interacting with Swagger directly. This would ensure that users receive accurate and current information from the plugin.
Screenshots
Please find the screenshots of the outdated results from Chat-Copilot and the expected up-to-date results from Swagger.

Platform

OS: Windows
IDE: VS Code
Language:  C#, Python
Source: Main branch of repository: https://github.com/microsoft/chat-copilot.git

Additional context
I noticed that this issue is specific to Chat-Copilot's interaction with my custom plugin. Swagger integration seems to work correctly and provides real-time updates. This context could potentially help in identifying whether the problem lies within my plugin's implementation or Chat-Copilot's integration with both "Action"/ "Sequential" Planner along with the gpt-35-turbo model.

Thank you for reporting this.  I'm happy to review chat-copilot's interaction with custom-plug-ins for result handling and ifadditional logging might be helpful.
I'm wondering if the model is cosolidating test, Test, and Test5 as a single logical item: Test.  Is it possible to provide the prompt metrics (click the "information" icon in the chat bubble) and the short/long term memory values from the persona tab.  This may help determine if actual values are provided and if the model then consolidates.

Another test might be to add distincts item such as Cheese, Celery, Catfood, etc...
I look forward to hearing back from you and will also investigate on this end.

Thank you for your prompt response. I appreciate your suggestion to explore whether the model is consolidating similar terms and your interest in examining the prompt metrics and memory values.
I have conducted the tests as you've suggested. I created distinct items such as 'Cheese,' 'Celery,' and other 'Test' to ensure the items are unique. Despite this, the issue persists, and the plugin still fetches outdated data when interacting with Chat-Copilot.
I have attached the screenshots showing the error. The first screenshot demonstrates the outdated results from Chat-Copilot, while the second screenshot displays the prompt metrics and expected up-to-date results from Swagger for comparison. The third and fourth screenshots showcases the additional tests.

In addition, I've captured the short/long term memory values from the persona tab. I hope these details will be helpful in your investigation.

Please let me know if there's any other information or steps you'd like me to take to assist in resolving this issue. Your expertise is greatly valued, and I'm looking forward to your insights.
Thank you once again for your assistance.

Wonderful, thank you for these additional data-points.  I aim to complete my analysis today.

I was able to reproduce your report with a function that adds a new guid to the list upon each invocation:

In my case, the "cached" value is being derived from the chat history.  I suspect something similiar is occuring for you while the function result is being captured as expected.  I am a little uncertain as to which prompt details you've  shared...is that the planner prompt?  I'd the prompt related to the plan/function/plug-in execution to contain the function results.
In anycase, let me raise this to the team for ideas.


Convert non-string names to strings

IMPORTANT: Please search among the Pull request before creating one.
Title
Cast non-string keys to strings.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] New feature (non-breaking change which adds functionality)

Description
Same as above.
How has this been tested?
Modified 1 test and added a new one.
Closes
closes #267

For some reason PETSc failes on Python3.6 - it's unrelated to this issue, though I should investigated further.


Add column address to TreeNode

Add an address column to TreeNode.
How to test

First, delete all rows in the TreeNode table. (This is necessary because we’re adding a non-null column)
Run pnpm -F db migrate:dev to add the column
Run pnpm test_data:populate to update re-populate the test data

@cha0sg0d  To check if an address is in a group, you can use the GET groups/latest endpoint to get all members in a group, and check the inclusion it in the frontend!
(We don't wanna have an endpoint that takes an address and returns true/false re the inclusion, because that'll break pseudonymity.)

@cha0sg0d
Yes! just manually deleted all rows from the TreeNode in both staging/prod so the migration can succeed.


IPFS Station Setup

So this is what I did this morning from the fresh image you sent me.

Copy image using dd and expand on the pi
Setup wifi using this guide
Install nvm with curl
Restart shell
Install node:

$ nvm install 5
$ npm install -g npm # Latest npm

Install station

$ git clone https://github.com/ipfs/station.git
$ cd station
$ npm install
$ npm start

This is fantastic, I just remade a new version of the Fullnode OS and we're looking good. I think I must have had a dodgy internet connection before. Danke schön.
And feel free to add it to the Setup Guides folder if you want. Otherwise I will add it on the next round of updates.


Body encoding lost, text lost in case on 8-bit content-transfer-encoding with non-ASCII content

The same problem as in issue #47 - I have mail with 8-bit body content.
Force specific encoding while reading stream AND while parsing body helped. I set ImapClient.StreamEncoding = Encoding.GetEncoding("windows-1251") and my message reads ok.

There is a fork of S22.Imap which fixes the issue:
Install-Package S22.ImapWithUTF8


Add missing syntax highlighting, remove unnecessary indentation

I noticed that the penultimate change log entry was missing syntax highlighting, and that some entries had extra indentation, unnecessarily padding them on the left. This PR fixes both.
Do I need to run CI, even though this is a changelog-only PR? Wondering if there's a way for the build scripts to detect Markdown-only changes and return early?

@swift-ci Please smoke test

@swift-ci Please smoke test

Wondering if there's a way for the build scripts to detect Markdown-only changes and return early?

That has been brought up in a couple of discussions and would be the ideal =]

@swift-ci Please smoke test MacOS Platform


Prefetch direct dependencies during init

The initial caching of the repositories can be slow, and doesn't print any output because it's happening as a side-effect of the other init logic. We used to explicitly prefetch the repositories and log a message, but that was lost at some point over the past months.
https://github.com/golang/dep/pull/194/files#diff-b14a2eb16f1efbc6aa9f1ffdad724265R241
Let's start doing this again during init (most likely in getDirectDependencies), and cap the concurrency at 4.
Original comment that inspired this issue: https://github.com/golang/dep/issues/1129#issuecomment-327533935.

note that an impl of this should almost certainly use golang.org/x/sync/errgroup, which we'll be introducing in #1155

@carolynvs I can pick this up. I worked on the original log message story after all 😄


npm installs global package in wrong node version folder

I have node version 10.9.0 installed with nvm. Then I try installing a global package (or linking a cli package with npm)
The package gets installed under v8.9.3
v10.9.0 # as you can see, I have node version 10.9.0 installed
➜  (local) terria-cli git:(develop) npm link
audited 1653 packages in 3.067s
found 15 vulnerabilities (3 low, 5 moderate, 6 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
/Users/alexandruluca/.nvm/versions/node/v8.9.3/bin/index.js -> /Users/alexandruluca/.nvm/versions/node/v8.9.3/lib/node_modules/my-cli-app/bin/index.js
/Users/alexandruluca/.nvm/versions/node/v8.9.3/lib/node_modules/my-cli-app -> /Users/alexandruluca/workspace/my-cli-app

As you can see, it installs the package in node/v8.9.3, I would have expected (it is expected) to be installed under 10.9.0

Check your ~/.npmrc - if you have a prefix line, delete it.

I wonder if vscode sets an npm config env var or something - in general tho, if something works on a real terminal, but not in vscode’s, it’s a bug with vscode.

Maybe helpful for others
https://github.com/Microsoft/vscode/issues/36987 Although I did have
"terminal.integrated.shellArgs.osx": []

and it didn't work for me.
Feel free to close the issue. Thanks!


Server should send a message to a channel when a user joins or parts

@AnthonyHewins @dyladan sorry to change this on you, but I think the best way to implement this might actually be to maintain a list of users in each channel and then updating+sending the list when someone joins or parts. This would be the easiest way to maintain an accurate list clientside. Thoughts?


etcdctl v3 - keys lease ID should be in hex?

Hi, guys!
I'm wondering why "lease" is not HEX value in GET response?
ETCDCTL_API=3 /usr/local/bin/etcdctl  get foo -w json
{"header":{"cluster_id":14841639068965178418,"member_id":10276657743932975437,"revision":3096,"raft_term":3},"kvs":[{"key":"Zm9v","create_revision":3096,"mod_revision":3096,"version":1,"value":"YmFy","lease":7587818290816322434}],"count":1}

In order to use it in any lease <cmd> command I have to convert it to HEX first.
ETCDCTL_API=3 etcdctl lease revoke<PHONE_NUMBER>816322434
Error:  bad lease ID arg (strconv.ParseInt: parsing "7587818290816322434": value out of range), expecting ID in Hex

Do you have any plans to fix this inconsistency?

This is inconsistency since the output format is not default. It is from json. I do not think we should fix this. We can add a flag to range to output the lease of a key and output the lease id in hex format.

Yeah printing out range response with lease in hex sounds better.

Maybe the best option - to add an option for lease command to recieve lease ID in int64 format? Just curious, what was the reason for HEX? :)
Otherwise you should also support HEX output in other commands, where lease ID may occur, like:
ETCDCTL_API=3 etcdctl lease timetolive 4F325888AB411E3D --keys -w json
{"cluster_id":1217629517487190609,"member_id":7566429884247002930,"revision":1032,"raft_term":2,"id":5706721021843807805,"ttl":4,"granted-ttl":5,"keys":["Zm9v"]}

Maybe the best solution - to add an option for lease command to recieve lease ID in int64 format? Just curious, what was the reason for HEX

HEX is short. All lease commands in etcdctl output HEX. JSON format is not the default output. And we do not plan to make it the default.

OK, got it :)
Then it would be great to add a new field with HEX. "lease_id" or "lease_hex" as it's more clear :)
And even no additional flag is needed, because there is no compatability break in adding a new field.
Looking forward for it!

@mwf If you have time, can you contribute to this flag in range request?

Yeap, would be glad to!
Let's make a decision about the field name ("lease_id" or "lease_hex")? And do we really need additional flag since the backwards compatability is not broken?

@mwf
we print out the get result here: https://github.com/coreos/etcd/blob/master/etcdctl/ctlv3/command/get_command.go#L74
The display func does not print out leaseID. So you have to get the json header.
We need to keep backwards compatability. I suggest to have a --lease-id flag added into get sub command. Once it is enabled, we print out lease id after value. If no lease id is attached, print out 0. All in hex format. We always print out and receive ID in hex format, except non-default format like JSON which we do not control.

Ah, I see now, you want to add lease ID to the default output, not json. So additional flag is really needed.
But why not to add it to JSON output? Or this JSON is a plain gRPC response from etcd, encoded in JSON? That's why we can't add a new field there?

@mwf We cannot json output. json should not represent int as hex i think.

@heyitsanthony recently add the field format that will output lease in hex format. so closing this issue.

Thanks to him!
I think it's the best option, covering all possible needs.


Timezone-aware datetimes are no longer supported

I am trying to upgrade from 1.5.0 to 1.8.0, and my unit tests are failing because of a "TypeError: Type datetime64[ns, Timezone('UTC')] was not understood." on a non-index column. Here's a quick reproduction. This works on 1.5.0 and fails on 1.6.0 and 1.8.0. (pyspark 3.0.2 and pandas 1.1.5)
from databricks import koalas
import datetime
import pandas

df = pandas.DataFrame({
    "time": [datetime.datetime.now(tz=datetime.timezone.utc)],
})

koalas.from_pandas(df)
# TypeError: Type datetime64[ns, UTC] was not understood.

Originally posted by @ashwin153 in https://github.com/databricks/koalas/issues/2102#issuecomment-864146498

IMO this feels more like a regression than an enhancement.

Any update on this?

The previous implementation was not really correct. So this is disabled for now. To mimic the previous behaviour, you can manually localize it by converting UTC to your local timezone (without timezone), and use it for now.


Fixes inability to override spark conf; prefers spark-submit names

Before we couldn't override spark properties via CLI. This fixes that
and prefers spark-submit names for settings we provide.
Ex. the last property is the same as you'd pass to spark-submit, except
prefixed with zipkin.sparkstreaming.conf:
$ java -jar sparkstreaming-job/target//zipkin-sparkstreaming-job-0.1.1-SNAPSHOT.jar \
  --zipkin.storage.type=elasticsearch \
  --zipkin.storage.elasticsearch.hosts=http://<IP_ADDRESS>:9200 \
  --zipkin.sparkstreaming.stream.kafka.bootstrap-servers=<IP_ADDRESS>:9092 \
  --zipkin.sparkstreaming.conf.spark.eventLog.enabled=false

Fixes #29

you can also test this by setting an invalid variable like below and watch it crash!
--zipkin.sparkstreaming.conf.spark.eventLog.enabled=faK1

Thanks for the changes @adriancole. I tried it on our Spark cluster (running on Mesos) and it worked as expected.

@adriancole is it okay if I delete fix-property-setter branch?

@naoman just deleted it. yeah you can assume post-merge any PR branches can/should be deleted