Replace all NoWarn compiler options with WarningsNotAsError

This will allow warnings to surface without breaking CI

@christothes Just to make sure I understand this issue you want us to move to WarningsNotAsError instead of NoWarn so we are aware of the gaps and not be completely blindsided or is there any other motivation of this change?

I don't recall the motivation behind this one, so I'll go ahead and close it since it's been a couple years.


[Bug report]: Unable to claim a token

Platform
Desktop
Version
Stardust Beta 2.0.3
Description
Unable to claim a token. Wallet does not allow me to claim this token as received, even after multiple attempts (click on claim button)

Expected behaviour
Should process same way as other tokens claimed
Actual behaviour
Unable to claim a token. Wallet does not allow me to claim this token as received, even after multiple attempts (click on claim button)
Can the issue reliably be reproduced?
No
Steps to reproduce the issue
No response
Operating System
Windows
Diagnostics
No response
Developer Profile
Yes
Profile Type
Software (Stronghold)
Staking
No response
Crash Status
None of the above
Error Messages
No response
Error Logs
No response
Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yeah happened to me after closing and reopening FF. Seems like the state is not being saved?

Resolved with:
https://github.com/iotaledger/firefly/pull/4106


Speedup non-SSL connections

Before the patch (https://github.com/giampaolo/pyftpdlib/commit/52798a915cf385d60666eb57e43b00616b8090c3):
~/svn/pyftpdlib {master}$ ./scripts/ftpbench -u user -p 12345 -H localhost -P 2121 -b concurrence -n 10 -s 10M -d
10 concurrent clients (connect, login)                 0.01 secs
STOR (1 file with 10 idle clients)                   338.56 MB/sec
RETR (1 file with 10 idle clients)                  1456.26 MB/sec
10 concurrent clients (RETR 10.0M file)                0.06 secs
10 concurrent clients (STOR 10.0M file)                0.23 secs
10 concurrent clients (QUIT)                           0.00 secs

After the patch:
~/svn/pyftpdlib {master}$ ./scripts/ftpbench -u user -p 12345 -H localhost -P 2121 -b concurrence -n 10 -s 10M -d
10 concurrent clients (connect, login)                 0.01 secs
STOR (1 file with 10 idle clients)                   412.35 MB/sec
RETR (1 file with 10 idle clients)                  2030.04 MB/sec
10 concurrent clients (RETR 10.0M file)                0.07 secs
10 concurrent clients (STOR 10.0M file)                0.33 secs
10 concurrent clients (QUIT)                           0.00 secs


Print to STDERR so that this doesn't  end up in rollback script when redirecting to file.

https://github.com/hirak99/yabsnap/blob/deb4d2ef9332511470ae3e4ba430e76431fe15ce/src/code/main.py#L137-L143

Thanks, this should be fixed in v1.07.1.


Make access to benchmarks dashboard public

Now that we are using Power BI, we can make the results public like the ASP.NET team. We should probably come up with some useful views over the data, e.g. that compare EF Core and EF6, different versions of EF Core, etc.
See https://github.com/aspnet/EntityFrameworkCore/issues/8285#issuecomment-382626375.

We got customers at build asking for this. It can be useful to drive adoption of EF Core.

@divega Move to 3.0 for further tracking?

@ajcvickers okay


Considerably more detail in example or just docs

Much of the readme in the example is unclear.
I don't have an ios/Runner/Runner.entitlements. Do I just add it? What should the rest of the file look like?
"Make sure the deployment target for Runner.app and the share extension is the same." Don't know what that means. Your example extension appears to be called Share Extension. Your example app is named receive_sharing_intent_example in its pubspec. I'm confused about how you say these names are supposed to match when they don't seem to. Maybe name and deployment target are different?
Your example adds "SharePhotos" to the main plist file for iOS. How do I add other types? What other types are there?
Where you have group.com.kasem.sharing, what should I have?
"3. Add Runner and Share Extension in the same group": I don't know what is YOUR_HOST_APP_BUNDLE_IDENTIFIER.
Please understand that I, and probably many of the folks wanting to use this, am neither an iOS nor an Android developer — that's why I'm using Flutter!
Thanks very much for putting this together.

@gisborne yes, the docs can definitely be improved.
To answer your questions:
A share extension is an app extension. Hence, you should have a main app for which you want to create a corresponding share extension. In the README.md this is often referred to as host app.

I don't have an ios/Runner/Runner.entitlements. Do I just add it? What should the rest of the file look like?
Yes, create one. For the beginning just copy & paste it from example/ios/Runner/Runner.entitlements into your main app.

Make sure the deployment target for Runner.app and the share extension is the same.
I am confused by this, too. I think you should just take care to use and reference the same name everywhere, e.g. if your share extension is called myapp share extension you should reference it the same way everywhere.

Your example adds "SharePhotos" to the main plist file for iOS. How do I add other types?
I recommend looking in the example/ios/Sharing Extension/ShareViewController.swift and example/ios/Sharing Extension/Info.plist of the example for that. It includes text, url, video, photos and files. If you are still having trouble to understand it, feel free to ask :-)

Add Runner and Share Extension in the same group & Where you have group.com.kasem.sharing, what should I have?

YOUR_HOST_APP_BUNDLE_IDENTIFIER refers to the bundle id of your main app. So if your main app bundle id is com.gisborne.myapp your group id becomes group.com.gisborne.myapp. It references the org in flutter, e.g. if you created your app with flutter create --org com.gisborne myapp, then the bundle id is com.gisborne.myapp.
Hope that this helps you :-)


Redesign the Footer to be a sticky footer

As you can see, we currently have a relative footer. But to be more beautiful we would like to have a sticky footer.

If you are interested in re-designing the footer to be a sticky footer, please let us know.
What is a sticky footer? 🤷♂

CSS-Tricks Sticky Footer
Mozilla Developer Networks -Sticky footers

PS: This issue is related to issue #4.

I'd like to work on this :)

Ah, nice. @jaspervhaastert I'll assign you to this task.
Remember to sync your fork by using the following command.
$ git pull upstream master


Missing ldlm pool stats?

Someone please double check (I don't have access to a Lustre system right now):
lustre_exporter (master) $ git grep "pool/" sources/procfs.go
sources/procfs.go:                      {"pool/granted", "granted", "Number of granted locks", s.counterMetric},
sources/procfs.go:                      {"pool/grant_rate", "grant_rate", "Lock grant rate", s.counterMetric},
sources/procfs.go:                      {"pool/cancel_rate", "cancel_rate", "Lock cancel rate", s.counterMetric},
sources/procfs.go:                      {"pool/grant_speed", "grant_speed", "Lock grant speed", s.counterMetric},

However, in the Lustre source code:
lustre-release (master) $ git grep -A2 'lprocfs_counter_init('  |grep -A2 LDLM_POOL
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "granted", "locks");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "grant", "locks");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "cancel", "locks");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_RATE_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "grant_rate", "locks/s");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_CANCEL_RATE_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "cancel_rate", "locks/s");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "grant_plan", "locks/s");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SLV_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "slv", "slv");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_REQTD_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "shrink_request", "locks");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_SHRINK_FREED_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "shrink_freed", "locks");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_RECALC_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "recalc_freed", "locks");
--
lustre/ldlm/ldlm_pool.c:        lprocfs_counter_init(pl->pl_stats, LDLM_POOL_TIMING_STAT,
lustre/ldlm/ldlm_pool.c-                             LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c-                             "recalc_timing", "sec");
lustre-release (master) $ git grep -A2 'lprocfs_counter_init('  |grep LDLM_POOL |wc -l
      11

Hmm, we didn't see any of those stats in our environment. Let us know if you see a use case for any of these in your environment, and actually see them populated.

So it looks like the ones we are not currently tracking are the following:
grant
cancel
grant_plan
slv
shrink_request
shrink_freed
recalc_freed
recalc_timing

@knweiss I am not finding much information on the grant and cancel metrics, do you happen to have any information or examples on them? Otherwise, I created PR #79 which addresses the other metrics.

Caveat: I'm not very familiar with the Lustre source code so please take this with a grain of salt.
@roclark  After taking a glance at the ldlm_pool.c I came to this conclusion: The grant and cancel metrics are per pool counters that get increased in ldlm_pool_add() and ldlm_pool_del() respectively each time a lock is granted/canceled.
AFAICS this metric invariant holds:
granted == grant - cancel

However, his begs the question: Is granted a gauge and not a counter? There's definitely an atomic_dec():
void ldlm_pool_del(struct ldlm_pool *pl, struct ldlm_lock *lock)
{
[...]
        atomic_dec(&pl->pl_granted);
[...]
}

OTOH there's only a single lprocfs_counter_add() to the LDLM_POOL_GRANTED_STAT and I don't see how its argument granted could become negative:
static void ldlm_pool_recalc_stats(struct ldlm_pool *pl)
{
[...]
        int granted = ldlm_pool_granted(pl);             // reads pl_granted
[...]
        lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
                            granted);
[...]
}

Also, this makes me wonder if some metrics should be dropped from the lustre-exporter as Prometheus could calculate them instead? (If the user knows these relationships that is...)
A similar case is mentioned in http://wiki.lustre.org/Lustre_Monitoring_and_Statistics_Guide

dlm lock grant speed = grant_rate - cancel_rate. You can use this to derive cancel_rate 'CR'. Or you can just get 'CR' from the stats file I assume.

@knweiss Thanks for the detailed dive into the code! I've been looking at the source as well, and to me, it sounds like granted should be a gauge. I was also looking at the equation granted == grant - cancel. Unless I am misinterpreting the source, I don't believe you can have a cancel without at least one grant, otherwise there is nothing to cancel. So, grant should always be greater than or equal to cancel in my mind, but they can increase asynchronously (to an extent). Take the following example where the numbers refer to various operations:
grant 1    -> granted == 1 - 0 = 1 (increase)
grant 2    -> granted == 2 - 0 = 2 (increase)
grant 3    -> granted == 3 - 0 = 3 (increase)
cancel 1   -> granted == 3 - 1 = 2 (decrease)
grant 4    -> granted == 4 - 1 = 3 (increase)
cancel 2   -> granted == 4 - 2 = 2 (decrease)
cancel 3   -> granted == 4 - 3 = 1 (decrease)

Not sure if you agree or if I am way off, but this is how I understand the granted stat and why I see it as a gauge instead of a counter (agreeing with your initial thoughts).
As for removing items from the lustre_exporter, I am all for it if they are direct calculations. Although...

If the user knows these relationships that is...

This is the key point in your statement to me. At least to me, grant speed isn't immediately obvious that it is grant_rate - cancel_rate, though it is logical once known. I'm not sure if it would be wise to document this anywhere or just to keep it. Calculations like these could easily be done in Grafana/Prometheus as opposed to the exporter. I will let @joehandzik add any input on whether he thinks we should keep/remove the metrics.

@roclark Yes, that's my understanding as well but what do you think about this line?
        lprocfs_counter_add(pl->pl_stats, LDLM_POOL_GRANTED_STAT,
                            granted);

If granted is always positive this add can only increase LDLM_POOL_GRANTED_STAT. That's what confuses me and I wonder if I'm missing something here.

Hmm... you've convinced me. I don't see any reason why it wouldn't be a counter from that line... If you're missing something, I must be too.
In short... are we all agreeing to set this as a counter?

Fine with me!


Improve code style

Me being a JS expert

This would be so much nicer with ES6 arrow functions.

I broke it... not as much JS expert as I thought

Nah, we're not set up to run PRs from 3rd party, probably won't ever be - this looks good to me 👍


Transition from wxPython to PyQt5 for Enhanced Compatibility

This pull request addresses the transition of the ESP_Flasher GUI from wxPython to PyQt5. The primary reason for this change is to mitigate the frequent complications and compatibility issues that arise with wxPython in newer versions.
Key Changes:

GUI Framework Transition: The entire GUI has been re-implemented using PyQt5 instead of wxPython. This change aims to provide a more stable and compatible user experience across different operating systems and Python versions.

Enhanced Compatibility: PyQt5 is known for its robust support and frequent updates, making it a more reliable choice for modern applications. This transition ensures that the ESP_Flasher tool remains functional and user-friendly with the latest system updates.

Code Refactoring: Along with the framework change, significant portions of the code have been refactored to adhere to PyQt5 conventions and best practices. This includes the restructuring of UI components, event handling, and threading mechanisms.

Benefits:

Improved Stability: By switching to PyQt5, users are less likely to encounter the compatibility issues that are prevalent with wxPython, especially on newer systems.
Better Support: PyQt5 has a large community and extensive documentation, providing better support for future development and troubleshooting.
Modern UI Features: PyQt5 offers a range of modern UI components and features that enhance the overall user experience of the ESP_Flasher tool.

Additional Information:

Dependencies: Updated the project dependencies to include PyQt5 and removed wxPython.
Testing: Extensive testing has been performed to ensure that the new PyQt5-based GUI works seamlessly across different platforms.

We believe this transition will significantly enhance the reliability and usability of the ESP_Flasher tool. We welcome any feedback and suggestions regarding these changes.

Thx a lot for this awesome PR. Looks good. Will test tomorrow and merge after.

@michaelkandziora I dont have any logs shown in the GUI console.

Does not start. This error is shown
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: cocoa, minimal, offscreen, webgl.

@michaelkandziora The logs is still not shown in the APP.

Seems the Programming Copilot AI isnt perfect ;-)
import distro -> ModuleNotFoundError: No module named 'distro'

No reason to excuse :-)
Log is now in App Window. Seems working. Will do more tests

Tested compiled binarys on Windows and Mac. Since you have developed on Ubuntu, every version should be okay.


Refactor distribution service to inject the dependency

This will make it easier to write a integration test so do that while you're at it too.

Done.


Radio buttons not working with numeric value

I've read the docs and implemented a form with radio buttons, but when you click on a radio button, the form state is not updated.
Here is a simplified code example.
const entities = [
  { id: 1, label: 'one' },
  { id: 2, label: 'two' },
];

type RadioForm = {
  entityID: number;
};

<For each={entities}>
  {(entity) => (
    <Field name="entityID" type="number">
      {(field, props) => (
        <label>
          <input
            {...props}
            type="radio"
            value={entity.id}
            checked={field.value == entity.id}
          />
          {entity.label}
        </label>
      )}
    </Field>
  )}
</For>
Current value: {getValue(radioForm, 'entityID')}

Manually adding onChange={(e) => setValue(radioForm, 'entityID', parseInt(e.target.value))} to the input fixes the issue, but I'm guessing that's not the correct use, since no other input type requires manually setting the new value.
The full example is available on Stackblitz.
Is this a bug?

What framework are you using? I am happy to share a working example from our playground with you.

I'm using SolidJS. Right, in the StackBlitz example above, I used the  playground as the basis.
The issue is that when I use number it breaks the radio buttons. I am assuming numeric values should be working too?

I don't think <input type="radio />" supports the .valueAsNumber property. When using number, the library doesn't do any transformation itself, it just reads the value of the HTML element.

I see. Would a PR that implements conversions be welcomed? I think this is an unnecessary caveat

No, because I plan to rewrite the library. I will take this into account when rewriting. For now, I recommend to stick with string and transform it afterwards.

I reopen it so that I don't forget this when rewriting the library.

Glad I found this. I got stuck on this for a while this morning.


Fix sp-tab-page scrolling bugs.

Resolves #409
The primary issue here was that both .wrapper and .sd-tab-page were considered scrollable. .wrapper is bound to the panel window height, and would become scrollable when the contents overflowed.
however .sd-tab-page was unbound. It grows instead of overflowing, but it would still capture scroll events and block them from bubbling up to .wrapper. So the only way you could scroll the page was by hovering over anything that was not .sd-tab-page (the scrollbar, or after the end of the content on any page.)
This fix restores display: none, which works fine, and commits to .wrapper being the scrollable element. I also removed some unnecessary styles on .sd-tab-page that weren't doing what we thought they were doing.

I also may be open to do some aggressive cleanup to the js/ts codebase if you're interested. lmk.

Awesome work! thank you for taking care of this issue.

I also may be open to do some aggressive cleanup to the js/ts codebase if you're interested. lmk.

I’m still working on the TypeScript conversion, about 95% done. Once that’s wrapped up, we could start working on cleaning up the codebase.

Sick. i'll try to keep a eye out for when that's wrapped and i'll take another look. I imagine some of the things I was struggling with (global vars, autocompletion) will disappear, but i like what you're doing here and want to help where i can.


Delete unimplemented article_pattern_search.rb

This Query subclass turned out to be very helpful - I copied it verbatim for Glossary pattern searches.
However, it's unimplemented for Articles.
@JoeCohen, who originally wrote the Article query classes, is in favor of deleting it.

Coverage: 93.525% (-0.002%) from 93.527% when pulling d56c03ab48f2a12afd5c5fc0e1061eeb7dd30f83 on nimmo-delete-article-pattern-search into 4f05d9bffb43c278285785bf982e820d1db29672 on main.


Prevent opening new windows

There is electrons "new-window" event. But i can not call event.preventDefault() in C# code (event browserWindow.OnNewWindowForTab). How am i be able to prevent opening new windows of my application? (for example when the user middle-mouse-clicks a link)
However, it is marked deprecated in the documentation in favor of this function on the webContents class. So how can i access that? There are plenty of methods that are not implemented in Electron.Net.
Related to #434

you have to do that in the javascript on the page itself.  You can't do everything in .net.
Here is the code I use to prevent navigating away.  For other similar scenarios I would suggest doing a google search.  You have somewhat more freedom in the electron world than a standard browser.
// this prevents the window from navigation away.
  document.addEventListener('DOMContentLoaded', () => {
    document.addEventListener('click', (e) => {
      if (e.target.href && e.target.host != window.location.host) {
        e.preventDefault();
        e.stopPropagation();
        setTimeout(() => {
          // do something else here
        }, 100);
        return false;
      }
    }, true);
  });


Enhancement: add JSON output format

The output of the commands that list / show things use tables, which doesn't display properly in some terminals as the tables are pretty wide and wrap several times in smaller monitors.
Another issue with tables is the output is not very good for automating processes. It will be great  to provide the output in JSON with a parameter like "--output json/table (default)"
It would be great to apply that to all outputs but if that's not possible, at least on the ones below:

show-defaults
search
list-contracts
list-products
list-groups
list-cpcodes
list-edgehostnames
check-activation-status

--json is used in other CLI packages like firewall and CPS. So i would for the same, to be consistent across packages.

Yes, actually you can do
akamai pipeline set-default --format json
you can choose json or table


Wi-Fi signal appears as 0dBm

Describe the bug
Wi-Fi signal appears as 0dBm when it should be positive.
Expected behavior
Non-zero value for wifi strength.
Screenshots

Tested on commit 11a129102c3f86a8cf00b877d8426b6ab40bd2ec, rM1.

rM1, rM2 or both?

rM1

Anybody with an rM2 able to replicate?

I confirm.

Can confirm as well.


multilib-capable clang, multilib tests

Motivation for this change
Closes #24136.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Send to staging? Or split out the cc-wrapper.nix change (which doesn't seem fundamental) and send that to staging?

Oh, right.  That would cause a mass rebuild on Darwin, wouldn't it? :laughing:
Will send to staging, then!

Thanks 😄

Nix prints a warning about pkgs.clang_multi when invoked as nix-env -f . -qa --meta --xml >/dev/null:
derivation ‘clang-wrapper-4.0.1’ has invalid meta attribute ‘override’
derivation ‘clang-wrapper-4.0.1’ has invalid meta attribute ‘overrideDerivation’

I don't know the source of the new attributes and how to fix this.
/cc @vcunat, @Ericson2314


Closing in favor of just adding directly to dev branch


Rust

Rust language support.
This one has some extensive changes, because update_header was not working correctly with  double slashes used in rust commenting.
But after I refactored that, I realised it would be better to use block comments for the header.
If you don't like those changes, I can always just undo them and just simply add rust to the rest of c like languages.

update_header function was written bad and already needed to be revised. It looks all good now. Thanks for cleaning up :+1:

glad to help
On Mon, Jul 10, 2017 at 1:50 PM, H.Alper Tuna<EMAIL_ADDRESS>wrote:

update_header function was written bad and already needed to be revised.
It looks all good now. Thanks for cleaning up 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alpertuna/vim-header/pull/16#issuecomment-314095812,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHVTGKskwWXs2FuxvKeBtGWXNfrtHqYzks5sMh4qgaJpZM4OSoqj
.


Using pool to avoid stack and frames memory allocation

#412

I see this being useful for extremely short running scripts (anything that's small enough to run less than double digit microseconds), but the larger a script the less the impact of this as the GC is likely to clean up the pool. Also for runs that take over double digit microseconds the allocation cost should be minimal compared to the runtime itself.
perhaps try your benchmarks with a longer running example like:
fib := func(x) {
	if x == 0 {
		return 0
	} else if x == 1 {
		return 1
	}

	return fib(x-1) + fib(x-2)
}
out := fib(20)

Given that, I'm not entirely convinced that this adds much real value in real world usage.
The code does look safe, but I'm leery against reusing the stack from past runs without any cleanup in future runs and the possibility of that being exploitable. The tradeoff might be worth it if the performance improvement is significant in real world usage, but as it is, I'm not convinced.
The other possibility might be that it's the pointer usage that's giving part of the performance gains. If possible also benchmark this in a long running case to see if there's any difference. If that is partly faster without the usage of pools, it would be a safer bet without having to reuse the same objects.
@d5  thoughts?

What happens if one of the runs is aborted by Abort() function? Compiled.RunContext may call VM.Abort if the context is canceled.

Any new run would still start with stack pointer 0 so it should be fine, but the stack itself wouldn’t start out empty. I don’t see any obvious way the items in the stack would be accessible but it’s not ideal.

Any new run would still start with stack pointer 0 so it should be fine, but the stack itself wouldn’t start out empty. I don’t see any obvious way the items in the stack would be accessible but it’s not ideal.

yeah... considered it already

Any new run would still start with stack pointer 0 so it should be fine, but the stack itself wouldn’t start out empty. I don’t see any obvious way the items in the stack would be accessible but it’s not ideal.
By adding such lines, we could clear the stack and frames array literally, and only cost few extra cpu time, though it makes no sense for VM.Run()

		*v.stack = [len(v.stack)]tengo.Object{}
		*v.frames = [len(v.frames)]frame{}

Any new run would still start with stack pointer 0 so it should be fine, but the stack itself wouldn’t start out empty. I don’t see any obvious way the items in the stack would be accessible but it’s not ideal.

By adding such lines, we could clear the stack and frames array literally, and only cost few extra cpu time, though it makes no sense for VM.Run()
		*v.stack = [len(v.stack)]tengo.Object{} 		*v.frames = [len(v.frames)]frame{}

Any new run would still start with stack pointer 0 so it should be fine, but the stack itself wouldn’t start out empty. I don’t see any obvious way the items in the stack would be accessible but it’s not ideal.

By adding such lines, we could clear the stack and frames array literally, and only cost few extra cpu time, though it makes no sense for VM.Run()
		*v.stack = [len(v.stack)]tengo.Object{}
		*v.frames = [len(v.frames)]frame{}

But does that still provide any gains of the pool?

All the pool's target is to reduce the overhead of memory allocation.
These two lines would not make extra memory allocation if you doubt about that.
		*v.frames = [len(v.frames)]frame{}

Perhaps I'm not explaining this correctly. My concern is more that if you add up the fact that the pool objects can be GC'd non-deterministically, additional cycles takes for clearing the stack frames, indirect access to stack and frames during the VM run, I'm not sure the gains in memory allocation cost are offset enough to make a difference.
Can you please add a benchmark that demonstrates the actual gains using the pool here provides?


test(partition): add marble tests for partition operator

relates to #309
Replace existing test to marble test, migrating RxJS4 test also.

We still have a few missing tests for this operator. It looks like this was meant to just rewrite the existing tests, would you like to tackle the rest @kwonoj?
The ones I can think of that are missing are:

empty
throw
error thrown in predicate
never
predicate never matches anything
predicate always matches everything
no predicate passed (should error I think?)

Absolutely. As mentioned this PR was intended to 'migrate' only, but it makes more sense to add additional coverage. I'll cover them up and update PR.

Updated PR by adding additional test coverage.

merged with 0fcf52e... Thanks @kwonoj!


ms2pip_tools folder not installed

When install the module via
/usr/bin/python3.6 setup.py install -O1 --skip-build --root /builddir/build/BUILDROOT/python-ms2pipC-1.1.0-1.el7.x86_64
the ms2pip_tools module will not installed to the system python module folder.
Only the the cython part are installed.

Hi @tuxmaster5000,
Right now, installing MS²PIP as a package is not supported. It is something we are planning in the near future, though. The setup.py file is only used to compile the Cython modules and is called when compile.sh is ran.
You can, however, also use the precompiled Cython files (that are posted on the releases page), as compiling can take a while with the latest models. Just unzip the files and put them in the cython_modules folder.


Add support for the container scan option

Adds the --container scan option to the action parameters. Documentation will follow in subsequent PRs.

@dstiliadis you want to merge this or wait for repo association support?

@dstiliadis you want to merge this or wait for repo association support?

@peter-cg I have updated the PR according to the latest changes in endorctl. Now --project-name is not mandatory. @IAmATeaPot418 Can you please take a look as well.


Local copy of patient entries in TargetedDataSubPanel (TDSP)

Addresses JIRA-1024: [Full] Initial implementation of TargetedDataSubpanel's copy of patient object, using that to determine return value of "shouldComponentUpdate"
In addition to storing a local copy of the patient entries (sans notes) I had to store a few other key elements that play into whether or not the TDSP, including:

The current clincal event (visualizers and minimap update when the number
The number of signed entries (as values get signed, their underlines in visualizers change)
Whether or not the TDSP isWide (width changes the way some visualizers like tabular and bandedlinechart are displayed)

Compare the performance of typing text in our editor with that of fluxnotes.org or master. Let me know if there are any cases I've missed for updates, if you're not seeing the performance boost, if you'd like anything in my code to change or if there's anything else on your mind!
Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (N/A) and :white_check_mark:.
Submitter:
Running the Application

[x] Manually tested in Chrome
[x] Manually tested in IE

Documentation

[x] This pull request describes why these changes were made
[x] Recognizes any potential shortcomings/bugs in the description
N/A Cheat sheet is updated
N/A Demo script is updated
N/A Documentation on Wiki has been updated
N/A Additional technical components and libraries are documented and added to wiki as needed

NoteParser

N/A Note parser has been updated if structured phrases change

Code Quality

[x] 4-space indents - convert any tabs to spaces
[x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };
[x] Code is commented

Tests

[x] Existing tests passed
N/A Added UI tests for slim mode
N/A Added UI tests for full mode
N/A Added backend tests for fluxNotes code
N/A Added note parser examples to test new functionality

Reviewer 1: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

This looks good! I definitely see an improvement in the performance when you type! I haven't found anything that isn't updating, besides the one thing you fixed even before a JA1! 💯 I am getting one test to fail when I run all the tests, which didn't used to happen. I've tested it myself and run it using test.only and it passes, so I'm not sure why that's happening or if it's happening for anyone else. This is the test: Entering disease status information updates the data in the targeted data panel to indicate that the disease status information is unsigned 1) AssertionError: expected false to be truthy.

Everything looks good and all tests pass on my end.  So much faster!
Just two things:

Should we use arrow functions in the reduce functions?
Lines 73 and 80, can you add a space between the 'if' and '('?

I'll take your approval as a yes 😄

I don't know why that test is failing some times, but it passes now.

Just waiting for Travis.


Replace LinkedList with ArrayList even if the size is unpredicateable

Reference:

Won't do. Just wait for Valhalla to eliminate redundant objects.
It's hard to decide to use an ArrayList for unlimited objects (e.g. a user queries his friends. We cannot know how many there are. So keep simple for these common scenarios and just use LinkedList)


feat(node): new Full Node type

Just a new Full Node type with Full availability

No merge until next release.


Public folder not found for caddy

Info:

Docker version ($ docker --version): 17.03.1-ce
Laradock commit ($ git rev-parse HEAD): bf4a5beb0be77eb952a5012c27f7e538f950c274
System info (Mac, PC, Linux): Windows
System info disto/version: Windows 10

Issue:
ERROR: for caddy  Cannot start service caddy: oci runtime error: container_linux.go:247: starting container process caused "chdir to cwd ("/var/www/public") set in config.json failed: no such file or directory"
ERROR: Encountered errors while bringing up the project.
What seems to be going wrong?
I want to point to another folder than public folder because I have another structure.
When I have an empty public folder in my directory everything works fine, but when I delete it caddy throws an error on start up.

Expected behavior:
What should be happening instead?
I changed all necessary paths in caddy (Caddyfile and Dockerfile) and it works with the other folders as long as the empty public folder exists.

Reproduce:
How might we be able to reproduce the error?
point the root folder not to /var/www/public but /var/www/foobar
delete the public folder
start caddy container

Is there another package that caddy is using that is pointing to the public folder that I have to change?

I was getting the same error. Your question, however, is also a solution in itself, at least in me case.
My project is on Laravel, and there is a 'public' directory in Laravel project anyway. So I just have to set up a project, before starting the caddy container. I also changed:
root /var/www/public
to
root /var/www/laravel/public
in Caddyfile (the project name is 'laravel')
and
APPLICATION=../
to
APPLICATION=../laravel
in .env (copied from env-example)
Is your project not Laravel that this wouldn't work for you as well?

I found out that you have to rebuild the project. For normal changing at the caddy file it's not necessary, but a rebuild for caddy removed the error.


Odd Subscription error

I'm trying to add a sort to a paginated subscription and I keep receiving this error "Expected not to find a document already present for an add" when I change the sort direction.
The relevant code:
$scope.subscribe('someSubscription', function() {
        return [
            $scope.getReactively('searchValues', true),
            $scope.getReactively('sort'),
            $scope.getReactively('page'),
            $scope.getReactively('perPage')
        ]
    }

Meteor.publish("someSubscription", function (searchValues, sortDirection, page, perPage) {
    let query = prepareSearch(searchValues);
    Counts.publish(this, 'ourCount', SomeModel.find(query),  {noReady: true});
    return SomeModel.find(query, {
        sort: {creation: sortDirection}, limit: perPage, skip: perPage * (page - 1)});
});

Is there anything particular I am doing wrong that would cause this?

@cglace you might try using the this.subscribe syntax as described on the subscribe docs

Is this a server error or browser console error?  If I had to wildly guess it looks like something is getting confused in the livequery (database <=> mergepool) or the ddp sync between the mergepool and minimongo

The error is client side. The results are correct server side but end up incorrect on the client. Right now the only workaround is to disable sort on that page.

Paginating with skip can be tricky because on the client-side it can be difficult to tell which items in the collection came from the publication with skip in it (if more than one publication involve documents from the same collection....)
Is this the only publication sending to that collection? If so, your helper query on the client side is not using skip correct?
If all else fails, you may want to go to an infinite-scroll type of pagination instead of actual discrete pages, it is easier to implement.

There is only one publication using this collection so I am not using skip on the client, just sort.

closing due to inactivity and cleanup after tons of new updates in the recent month


Tab Order is not Persisted

Hi,
I like to have my wallet tabs in a particular order, starting with a hot wallet followed on the right by cold wallets. I have found the controls to move each of the tabs but after I log out and log back in, the tabs have rearranged themselves.
Is there a way, the position of the tabs could be saved please?
Thanks in advance
S

Title should be "tab order is not persisted". Else, the issue reads like a duplicate of #476

Thanks

Fixed in c9d6bb350d77b14c7fb68f9b24f7b9576370dd64.


Double-Tap will cause a unclose-able sticky window unless manually focused and escaped

Description
With the default configuration, using the base command twice (e.g. <space><space>) will open a window which then will often-times not be focused.  This window will remain there even when activating the window again by using the command once and escaping out of that window.  This window must be manually focused (I've only been able to do that with the mouse properly) and then escaped out then.  See the video for an example.
Note: This happens mainly when the keys being pressed are not present in the assigned keys (e.g. gg is default for vim and I didn't manually assign it or <space><space> doesn't exist in any of my dictionaries or assigned keys.
Example
Steps to reproduce
In the video:

I did the command: <space><space> for example one and then gg for example 2
Then I saw: A window which caused weird interactions as described
Error: The window remained and I had to manually target it with the mouse, click into it, and then press my escape key to force it to close.

Expected behavior
I would expect the window to pop up with <space><space> as the input rather than the current behavior.
Environment

Neovim version: [Nightly]
wf version: [Latest]
Plugin clash: [Uncertain]

Note: This happens mainly when the keys being pressed are not present in the assigned keys (e.g. gg is default for vim and I didn't manually assign it or <space><space> doesn't exist in any of my dictionaries or assigned keys.

Hello @JoshBenn,
Thank you for issuing!
I have tried to reproduce the issue with the latest Neovim, but I couldn't.
VIM v0.9.5
Build type: Release

Can you reproduce the issue with bellow minimal setting.
I think that your local setting or another plugin is interfering wf.nvim.
You can run the bellow configuration with;
$ nvim -u minimal.lua

minimal.lua

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({
		"git",
		"clone",
		"--filter=blob:none",
		"--single-branch",
		"https://github.com/folke/lazy.nvim.git",
		lazypath,
	})
end
vim.opt.runtimepath:prepend(lazypath)

vim.g.mapleader = " "

-- install plugins
local plugins = {
	-- do not remove the colorscheme!
	"folke/tokyonight.nvim",
	-- add any other pugins here
	{
		"Cassin01/wf.nvim",
		-- version = "*",
		-- branch = "Fixes#105",
		config = function()
			require("wf").setup()
			local which_key = require("wf.builtin.which_key")

			-- Which Key
			vim.keymap.set(
				"n",
				"<Leader>",
				-- mark(opts?: table) -> function
				-- opts?: option
				which_key({ text_insert_in_advance = "<leader>" }),
				{ noremap = true, silent = true, desc = "[wf.nvim] which-key /" }
			)
			vim.keymap.set(
				"n",
				"<Leader>f",
				function() print("ok") end,
				{ noremap = true })
			end,
	},
}

require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

-- add anything else here
vim.opt.termguicolors = true
-- do not remove the colorscheme!
vim.cmd([[colorscheme tokyonight]])

Sorry for Inconvenience.

I'll be able to in a few days, though please note that my entire setup has changed significantly as I was trying to get an initial setup completed (I've moved back to whichkey due to the issues I was having with wf).  That being said, I don't have time just yet but I'll try to test out the requested config when I can and get back to you with the updates.

Hello @JoshBenn


Client Allocation Request for: euid

Client Allocation Questions
Core Information

Name: euid
Website / Social Media: euid.com, (@euid, Twitter)
Region: Oceania
DataCap Requested: 32 GiB
Addresses to be Notarized: f2532973298393627437546385399324
Notary Requested: Irene Young

This user’s identity has been verified through filplus.storage


netflow data via goflow corrupted/missing

When testing via https://github.com/kosho/nfgen or https://github.com/nerdalert/nflow-generator all data thats ingested is empty

Its not broken, the testdata is just invalid


Crashing on large files

Hey there, first of all, thanks so much for doing this.
On large files (150MB+), the program sadly just closes after ~5 seconds of loading.
I'm testing this out with the game Rust at the moment, to extract sounds, so I can add them to my video project :P
Here is the audio bundle file from the game: https://we.tl/t-IgtlSgKdpH
Any help here is appreciated :)

I tested your file and it was able to open both in the second release and the latest build. Does it crash when clicking the info button or when initially opening the file?
Also there's no audio export plugin yet, so I would suggest using AssetStudio to get audio.

Can't reproduce the crash, so I'm closing this issue. Reopen this if you still have issues.


🌐 Add Korean translation for docs/ko/docs/tutorial/body-multiple-params.md

This PR translates tutorial/body-multiple-params.md in Korean
related: #2017

Would it be better to translate 'body' to '본문' or leave it 'body'?
Body를 그대로 Body로 둘지, 본문으로 번역 할 지에 대한 의견 부탁드립니다.

Would it be better to translate body to 본문 or leave it body?
Body를 그대로 Body로 둘지, 본문으로 번역 할 지에 대한 의견 부탁드립니다.

I prefer 본문 to 바디 because

latter is not translated
all translation PR(including not merged) use latter
former has more appeared in MDN Korean docs (both are used, though 🧐)

It is just a personal opinion, but I think you(@PandaHun) should leave them. 😃

📝 Docs preview for commit c6130d21eb323041c16208da549458d5231e50f8 at: https://6499c97e1d7654037c04dcaa--fastapi.netlify.app

Thanks for your contribution! @PandaHun 👨💻
And thanks for the review @hard-coders 💯


Update RStudio Connect docs

Update broken link to SAML section in the RStudio Connect documentation
Document the need for an HTTPS connection to RStudio Connect

@rstub : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Add Function::Call wrapper

I'm using this code in a project and somewhere between v0.10 and v0.12 the recv function was changed from Object to Value so I'm going to change the parameter type in the pre_46 ifdef in my code.
I'm not familiar enough with the progression of v8/node to know. Do you know if this ifdef needs to be modified slightly to build properly on v0.12?

No, Object is a descendant of Value. I've updated the branch.


investigating circleci cache

I am thinking this might be related to local development on node 8 and circles's node-7 image.

OK, I think that might have done it. Now they have the same key ⬇


added int.toFloat

Fixes #254

@yegor256/z everybody who has role REV is banned at #255; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 6min)

Job gh:cqfn/eo#255 is not assigned, can't get performer


When?

Im using Rxjava2 but including Rxjava1 to use this library.
Do you need help?

Hi pcegarra,
thank you for using this library 💪
I have some good news for you, the Rx2 version will be published this week!
It would be awesome if you could test it when it comes out :)

Good news! Im going to be the first trying this version, Thanks!

Closing this issue with the release of Rx2Animations v0.9.0.  🚀


./kafka-acls.sh  cannot be used in broker POD

I have a question.  Kafka commands cannot be used in Broker POD. Is this normal?
'''
kubectl get pod -n kafka
test-pass-ssl-0-tj4hx                          1/1     Running   0          18m
test-pass-ssl-1-qrrl9                          1/1     Running   0          17m
test-pass-ssl-cruisecontrol-696bdd9846-8czmr   1/1     Running   0          9m4s
'''
'''
kubectl exec -it -n kafka  test-pass-ssl-0-tj4hx bash
root@test-pass-ssl-0:/opt/kafka/bin# ./kafka-acls.sh
Exception in thread "main" java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndStartAgent(Unknown Source)
at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndCallPremain(Unknown Source)
Caused by: java.net.BindException: Address already in use
at java.base/sun.nio.ch.Net.bind0(Native Method)
at java.base/sun.nio.ch.Net.bind(Unknown Source)
at java.base/sun.nio.ch.ServerSocketChannelImpl.netBind(Unknown Source)
at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(Unknown Source)
at java.base/sun.nio.ch.ServerSocketAdaptor.bind(Unknown Source)
at jdk.httpserver/sun.net.httpserver.ServerImpl.(Unknown Source)
at jdk.httpserver/sun.net.httpserver.HttpServerImpl.(Unknown Source)
at jdk.httpserver/sun.net.httpserver.DefaultHttpServerProvider.createHttpServer(Unknown Source)
at jdk.httpserver/com.sun.net.httpserver.HttpServer.create(Unknown Source)
at io.prometheus.jmx.shaded.io.prometheus.client.exporter.HTTPServer.(HTTPServer.java:190)
at io.prometheus.jmx.shaded.io.prometheus.jmx.JavaAgent.premain(JavaAgent.java:31)
... 6 more
*** java.lang.instrument ASSERTION FAILED ***: "result" with message agent load/premain call failed at ../src/java.instrument/share/native/libinstrument/JPLISAgent.c line: 422
FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed
'''

None of the kafka tools can be run from within a broker pod as all these try to bind to a port which is already in use by Kafka. Run all these tools from a separate pod. (e.g. deploy a pod using ghcr.io/banzaicloud/kafka:2.13-3.1.0 image, than exec into that pod and run the kafka-acls.sh tool from that pod).

You can also try:
$unset KAFKA_OPTS
./kafka-acls.sh

Closing this issue since there is no update from the reporter and it has been verified that the ./kafka-acls.sh can be run within the broker pod


Encode manifest version in manifest

          Yes - it's typical to store a 'manifest version' in the manifest so compatibility can be flagged if breaking changes are made. This avoids semantic misinterpretation, making it easy to ahead-of-time surface "buffrs is out of date" rather than surfacing "some field is missing".

e.g. store
manifest-version: "1.2"

and if buffrs reads a manifest it can't interpret (because it uses some incompatible feature) you can error that the manifest is out of date.
Originally posted by @j-baker in https://github.com/helsing-ai/buffrs/pull/38#discussion_r1331132029

I think this is a good idea – but way to early. For now i would like to break things frequently to keep technical debt as low as possible until we reach v1

I think you have it backwards here. The version is what gives you the ability to make breaking changes, rather than the thing which stops you from doing so.

Without the version, you ship some break. Your users' scripts now may or may not work when resolving dependencies. Errors may be meaningless. You spend lots of time supporting users.
With the version, you ship some break. You increment the manifest version. Users receive an error saying 'manifest version incompatible - you need to update buffrs'. Intended action much easier, much less support for you, much less pain for them. Users are comfortable with you stabilising a bit later, are comfortable with you making bigger breaks.

Does that make sense?

@j-baker yes of course. My point was that I would like to prevent us having tens of manifest versions. We could do a unstable.xyz version which we then use to form a meaningful 1.0?
What do you think?


Remove pthread header from SVMLightOneClass

dunno what's happening with travis but i think this one is really safe to merge....


New article

Corrected style guide violations and passed all tests locally.

Thanks for the submission, @msorre2.
As mentioned in the contributing guidelines, I can only accept a pull request made to your branch. This behavior deviates from most projects (where a pull request to the master branch may be expected) in order to replicate this experience for multiple people.
Click here to open this pull request to your branch


Properties Panel (RFC #1289)

About the Contributor

This pull request is posted on behalf of the BBC.
Type of Contribution
This is a: Feature

New Behavior

An optional property has been added for blueprints to configure: userEditProperties. This property can be added to Segments, Parts and Pieces. 3 parts of the properties can be configured: pieceTypeProperties, these are properties that depend on the user choosing a piece type i.e. a camera number depends on the user configuring the piece/part as a camera. The piece types are styled based on a Source Layer type. globalProperties, these are properties that are always available regardless of the piece type that the user chooses. Operations, these are UserEditOperations that are exposed as buttons on the Properties Panel. The properties are described by JSON Schemas.
The user can interact with the Properties Panel in a couple of ways:

Double clicking a Segment Title selects that segment
Right clicking on a Segment Headers, the user can choose to "Edit Segment Properties"
Double clicking a Piece selects that piece
Right clicking on a Piece, the user can choose to "Edit Segment Properties" or Edit Part Properties"

When an element is selected, it will display with a glowing border around it.
To close the Panel the user can double click the selected element in the UI, click on the X on the right top of the panel or click Cancel.
In the Properties Panel the user can change any properties that are made available by the blueprints. When the users clicks the "Save" button, a UserEdit Operation of type DefaultUserOperationsTypes.UPDATE_PROPS will be issued with the updated properties as a payload. The blueprints must then process this operation accordingly. A "restore from NRCS" button is available, when clicked this will send a UserEdit Operation to Blueprints instructing it to revert changes to either the Segment or the Part.
The Properties Panel can be disabled entirely from an option in the Studio Configuration.

Testing
Unit tests for the properties panel have been added.
Affected areas

The Blueprints API has a new optional property, which should not affect existing operations.
The UI has been updated with the Properties Panel component, which has also modified the RundownView component.

Time Frame

No specific requests, just leaving this as an early christmas present 🎁
Other Information

This PR adds tests for the Properties Panel, it is a bit messy in the test file because of the many mocks but this seemed to be the easiest way to keep this mocks limited to this specific test suite. If we are to add unit tests for other components it would probably be wise to move these to a more central place but I am hardly the expert to do that.
Status

[x] PR is ready to be reviewed.
[x] The functionality has been tested by the author.
[x] Relevant unit tests has been added / updated.
[ ] Relevant documentation (code comments, system documentation) has been added / updated.

Additional info about this should probably made available under the "For Developers" section but I think a second PR could be made for that too

Hello!
Thanks for this Contribution! It'll for sure be a very good addition to Sofie!
The developers have approved the implementation, the only thing that's holding this up now is that we want to confirm with our users that the functionality of double-clicking pieces (to edit instead of playing when having activated the feature-flag) is acceptable.
We expect to get back to you on January the 17th.
/Rannveig (NRK Sofie team)


Feature request: Relative date options

I'm not sure if this is the place for this, but I don't know where else to put it!
I've been a fan of Moment.js for years. It's a library that you can use for various date calculations/formatting in different languages. Now, Power Fx handles calculations & formatting pretty well. There's only one thing missing to me: relative dates. I would love Power Fx to have that as well (without a lot of formula usage...).
I would love to see some formula or extra formula where we can input a date and then it will calculate how long that's from the current date: 1 hour ago, 2 days ago, in 2 days, in 2 hours, etc.
Is this an option for Power Fx?

hi,
does this meet you needs?
https://docs.microsoft.com/en-us/powerapps/maker/canvas-apps/functions/function-dateadd-datediff
Russell

Hi @russgove,
It does meet it partly, the difference with moment.js is that you don't have to think about if it's minutes, hours, days, or months. That will go automatically. So it saves a lot of if statements.
Daniel


[Feature request] Support templates for workspaces

Hello,
We all know the command --disable-extensions which disables all the extensions when opening VSCode via terminal.

Yes, we also know the option --extensions-dir, but if we have to do it with this option, we have to create multiple folders prefixed with .vscode-* and symlink some extensions.
And for the command --disable-extension – it allows disabling only one extension and not more than extensions.

The ideal is that, we would like to open VSCode only with few extensions and excluding/disabling all other to optimise the performance due to the #89300, which showed that, with many extensions, searching and replacing all files at once will slow down the performance of VSCode and of the PC.
So we would add the new command --enable-extensions <id> <id> <id> ....

Hello @bpasero, @JacksonKearl, @roblourens  @sandy081 and @Tyriar  !
I have read another topic about the workspaces with few extensions (#15611). According to you, the enabled extensions in each workspace are locally stored in the cache folder Code - Insiders/User/workspaceStorage/, the problem is that we want to back up the workspaces and the settings and it is useless to copy the whole workspaceStorage folder full of many unnecessary previous caches and states. For example, lets us call two computers A and B:

I will copy the .code-worskapce files from the computer A to the computer B;
In the computer B, I will open .code-workspace with VSCode, but you see that all extensions are enabled, because the workspaceStorages and caches are available only on the computer A.
So, in the computer B, I have to redo what I did in the computer A. It is a waste of time. Too much repetitive.

It is why you should add --enable-extensions or let us config only the extensions we can enable in the .code-workspace file.

May I know why you would like to backup user data (settings etc)? Is it for syncing across machines?
Is your request similar to this - https://github.com/microsoft/vscode/issues/40239 ?

May I know why you would like to backup user data (settings etc)? Is it for syncing across machines?

Yes, it is. I use @shanalikhan's Settings Sync. It backs up the workspace folder, but does not back up the workSpaces folder.

Is your request similar to this - #40239 ?

Reading this topic...:

In @michaeljota's and @ramya-rao-a's case, he and she want to disable some extensions. In my case, I want to enable some and disable *all other. Their case is team-specific;
In @JordyScript's case, it is project-specific instead of workspace-specific. Not global. I want to set the specific workspace for every project, for example: A workspace called "PHP Projects" with PHP-specific extensions for any PHP project;
Regarding @Sti2nd's summary, it is mostly team-specific and project-specific, I am the only user that wants to sync across multiple machines of mine, need to apply it to a specific workspace for any project made in a specific language;
Regarding @aaronpowell's extension VSCode Profile Switcher, what I said and what @TheryFouchter said, we have to create multiple folders and multiple symlinks, but multiple user-data increases the file size. Only the new command --enable-extensions and .code-workspace with enabled extensions and all disabled extensions will save the file size. Note that @shanalikhan's Settings Sync does not back up the profiles generated by @aaronpowell's extension VSCode Profile Switcher.

I do not want to use recommendations because they will not install or not enable automatically them.

Hi @sandy081!
What is your decision?

FYI we are currently working on providing sync OOB and since your requirement is to sync workspaces, I would tag this as a sync request.

Hello @sandy081 !
There is a small problem.
I do not want to add folders to the workspaces because each workspace is for any project.

Not sure if I understand what you meant. Can you please elaborate?

Not sure if I understand what you meant. Can you please elaborate?

The folders are always saved in the workspace. When I open the workspace, the projects are there. I do not want to add or save them, I want an empty workspace, because the workspace is for any project, not just for added or saved project.

Then what does the workspace configuration file shall contain?

Then what does the workspace configuration file shall contain?

{
	"folders": [
		{
			"path": "/home/gusbemacbe/Templates/Alan Silva"
		}
	],
	"settings": {
		"liveServer.settings.multiRootWorkspaceName": "Formulário com Validação"
	}
}

Look at folders. I do not want the workspaces to keep or save these folders for the next times.

It means you only want settings to be synced? If so how different this is to have this setting in user settings and get synced?

It means you only want settings to be synced? If so how different this is to have this setting in user settings and get synced?

Yes, with JSON of enabled extensions, similar to Sync Settings. Only it will not download the extensions. It will check if which extensions should be enabled and not enabled when I open the workspace.
If you have difficulty to understand my explanation due to language barrier, maybe  @shanalikhan will explain better or I will explain with JSON.

Yeah it is difficult to understand your requirement. Can you please explain your use case with an example?

Yeah it is difficult to understand your requirement. Can you please explain your use case with an example?

@sandy081
Here is how should .code-worksapce:
{
  "settings":
  {
    "extensions":
    {
      "dart-code.dart-code": "disabled",
      "dbaeumer.jshint": "disabled",
      "dustinsanders.an-old-hope-theme-vscode": "enabled",
      "ms-vscode.atom-keybindings": "enabled",
      "pranaygp.vscode-css-peek": "disabled"
    },
    "folders":
    {
      "addFolderToWorkspace": false,
      // or
      "saveFolderToWorkspace": false,
      "path": ""
    }
  }
}

Sorry still unclear to me. Please explain me the end to end scenario.

Hello @sandy081
I simplified a bit, removing settings. I will explain each part. The whole code:
{
	"folders":
	[
		{
			"path": "",
			"saveFolderToWorkspace": false,
		}
	],
	"extensions":
	[
		{
		  "dart-code.dart-code": "disabled",
	      "dbaeumer.jshint": "disabled",
	      "dustinsanders.an-old-hope-theme-vscode": "enabled",
	      "ms-vscode.atom-keybindings": "enabled",
	      "pranaygp.vscode-css-peek": "disabled
		}
	]
}

In this part, if I set false to saveFolderToWorkspace, the added folder will never saved to workspace when I close the workspace or VSCode and when I open the workspace or VSCode next time:

"folders":
[
	{
		"path": "",
		"saveFolderToWorkspace": false,
	}
]

This is important for the user who opens different PHP projects with a same PHP-specific workspace without getting bothered with a formerly saved/added folder/project, so he does not have to remove that project from workspace. Opening is different of adding. Adding bothers more the user because it always saves the folder or projects to the workspace.
If I set true, the added folder will be always be saved to the workspace when you close or open the workspace or VSCode, like:
"folders":
[
	{
		"path": "/home/gusbetuga/Projects/PHP-Workspace",
		"saveFolderToWorkspace": false,
	}
]

In another part, setting disabled or false means the extension is disabled, and setting enabled or true means the extension is enabled, so the user does not have to enable and disable manually the extensions the extensions in each workspace in a new machine:

[
	{
		"dart-code.dart-code": "disabled",
	  "dbaeumer.jshint": "disabled",
	  "dustinsanders.an-old-hope-theme-vscode": "enabled",
	  "ms-vscode.atom-keybindings": "enabled",
	  "pranaygp.vscode-css-peek": "disabled
	}
]

I see there are two requests.

You want a workspace template.
You want to persist extensions enablement for a workspace. This is a separate request which is tracked already.

This issue will be tracked for workspace template.

@sandy081
I think it will not be moved to the backblog as it will not receive votes, as the vscodebot has said.

Yeah it is true as mentioned in the documentation.

@sandy081,
I'm going to close the issue as it does not have less than 20 votes. I'll create several workspaces folders by language and symlimk some specific language extensions for each workspace folder.
Or I must migrate from VSCode to another lightweighting text editor with very low memory requirements.


Extend drawing in lifecycles in iOS

We're stopping animations too soon and restarting animations too late on iOS during native view transitions.
On the way out, we stop the animator on the engine side right at viewWillDisappear. It's probably too early since the next view controller's transition animation still leaves the flutter view partly visible.

Probably easier fix, just defer the call for the right effect in the engine directly. Though it would still be nice to introduce a new AppLifecycleState for users to know (or reuse inactive?).
On the way back, we don't recreate a surface on the engine side or requests frames on the framework side until viewDidAppear when the transitions settled.

Would be nice to add a new AppLifecycleState for this as well. It's currently not handled or transmitted to the framework.
Send to framework and let the framework start requesting frame on new signal.

Seems like the "in the background but still visible" state that we already have (inactive) describes the two new states you describe above pretty well, so I'd re-use it for both (and update the docs accordingly). @cbracken may have opinions.

For record, on the way out, Android does more or less the same thing. The animations stop as soon as the native transition is started. But the transition is fast enough that it's not noticeable.
On the way in, Android goes to resumed as soon as the second activity goes away.
I was somewhat worried about merging OS signals viewWillDisappear and applicationWillResignActive into one dart-side signal in case the user wants to react differently without writing native code.
Though it's also somewhat edge case-y since I think the only way the user will end up in this situation (wanting to do something special with viewWillDisappear)  is if the user already wrote a hybrid app with native code. And we already merge view and app lifecycles with 'paused' and 'resumed' on iOS and Android. Will reuse and update docs.

The problem with having three enum values for these three states is that it'll mean that people will implement the logic in one of the states and not the other two and their app will be buggy.
What's the use case for doing something different in these three states?

Which 3 states are you referring to? I think we're already saying the same thing :)
I'll reuse the inactive state for both application will resign and view will disappear.
Have a fix in-progress that mostly works the way expected on simulator. Has a bug on physical devices where the rendering scales are off. Still trying to figure out.

The three states I was referring to are "application is visible in background but does not have focus, because the phone is up", "application is visible but an animation is in progress to hide it", and "application is visible and an animation is in progress to fully show it".

I meant we'll have one state like you suggested for all 3 you stated in https://github.com/flutter/flutter/issues/11421#issuecomment-318519429 (since there's already prior art for both merging directionality and view + app lifecycle events).
Turns out the issue for the scaling problem was due to the sequentiality of the OS calls to viewWillAppear, viewDidLayoutSubviews and viewDidAppear. It wasn't affecting simulators because some elements from viewDidLayoutSubviews were not used.
Because the operations originating from viewDidLayoutSubviews are posted on the UI queue and now possibly behind all the other tasks that come from creating the surface during viewWillAppear, it's possible an entire frame is fully rendered with the wrong viewport dimensions before the correct values are updated.
Fix in https://github.com/flutter/engine/pull/3934


Week 19 Review Ticket

Hacks

[x] Model/DB Hacks
[x] API Hacks

Our project, Jamal's Stats is unique in its backend code because of our implementation of an API. Instead of creating instances of each  class through post requests, instances of each class are created with each result from the f1 API. Hence, I implemented post, put, delete, and get through use of comments, likes, and dislikes. The user CREATEs (Posts) a comment, the user can READ (Get) data from the formula 1 API that is stored within our database, the user can UPDATE (put) the likes and dislikes of a driver, and the user can DELETE (Delete) a comment.

[X] CPT Scoring

1 API
1 DB
.9 CPT
-.1 video over time


Continue #100: Test process do not merge 2

This is the continuation of PR #100.

Test only. Closing without merging.


Fix Random Cards / Lockup / Update README

Fix a problem with lack of randomness of cards from chests/mana in CardAddition Rule.
Fix a lockup caused by a looping OnMoved event when board syncing.
Update README.md to show correct link to the latest RoomFinder

Fixed, thanks!


Will not start up for me

Hello, I can't get Matterbridge to start up - my log is as follows;
Add-on version: 2.9.0-PSA-121
You are running the latest version of this add-on.
System: Debian GNU/Linux 12 (bookworm)  (amd64 / qemux86-64)
Home Assistant Core: 2024.10.0b1
Home Assistant Supervisor: 2024.09.1
Please, share the above information when looking for help
or support in, e.g., GitHub, forums or the Discord chat.
s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service fix-attrs successfully started
#############################
CURRENT CONFIGURATION:
{
"homeAssistant": {
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
"url": "http://supervisor/core",
"accessToken": "a759d8232c69d5027ee98aa10b43b048ece64a25aed14a4c566c028ee4cb1f25f849e9e17416ebb32f7522d748638b361c22527ee640730c",
"matcher": {
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
"includeDomains": [],
"excludeDomains": [],
"includePatterns": [],
"excludePatterns": [],
"includeLabels": [],
"excludeLabels": [],
"includePlatforms": [],
"excludePlatforms": []
}
},
"overrides": {
"domains": {},
"entities": {}
}
}
#############################
CLI: Matterbridge.loadInstance() failed with error: Error: [node-persist][readFile] /root/.matterbridge/storage/.matterbridge/d01917a070027b55bce538a96fa2004f061de6fe1644f402a321c6db8c71b9ba does not look like a valid storage file!
CLI: Matterbridge.loadInstance() failed with error: Error: [node-persist][readFile] /root/.matterbridge/storage/.matterbridge/d01917a070027b55bce538a96fa2004f061de6fe1644f402a321c6db8c71b9ba does not look like a valid storage file!
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service base-addon-log-level: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service base-addon-log-level successfully stopped
s6-rc: info: service base-addon-banner: stopping
s6-rc: info: service base-addon-banner successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

Hi,
that means the storage got ruined for some reason (hardware or software issues).
You can replace the storage directory with the backup or just delete the storage directory and start over.
In ha you find it in /addons/matterbrige/.matterbridge.
Let me know if you need help with that.
My best

Thank you, that did the trick!
I can't get it to update though (Update v.1.5.0 to v.1.5.9) hit update but does not do it.

Great!.
All your issues are caused by the addon you are using...
Read this please https://github.com/Luligu/matterbridge/blob/dev/README.md#advanced-configurations
Run matterbridge as an home assistant add-on with the official add-on
Advanced configurations
Other Home Assistant Community Add-ons
The other Home Assistant Community Add-ons and plugins are not verified to work with Matterbridge. I strongly advise against using them. If you do use them and encounter an issue (which is likely because some do not meet the Matterbridge guidelines), please do not open an issue in the Matterbridge repository.
My best.


Cron doesn't work

Hi,
I tried to  use Cron with sails js. But, it doesn't work.
My OS is ubuntu 14.04.1.
I launched ths command : "sudo service cron restart"
I installed these modules :
https://www.npmjs.com/package/cron
https://www.npmjs.com/package/node-schedule (http://www.worldnucleus.com/2014/12/run-cron-job-in-sailsjs.html )
https://www.npmjs.com/package/sails-hook-schedule
But none of theses modules work.
Did i forget something to config in Sails js framework or a command to launch ?.
thank you in advance

sails-hook-schedule doesn't use cron, it merely uses the cron-style format for configuring the schedule.
In order to run the scheduler, you'll need to run sails and keep it running 24/7. When node-schedule runs the job at the specified time, the code you configured as the task will be run.
Restarting the cron service would have no effect, since no jobs are being registered there.
For example, I run a sails web server that is always online. Each day at midnight, it runs a task to import some data from a third party which goes through a sails service and uses the ORM to perform the inserts into my DB.

Thanks. it works well.


Scattered data support without requiring labels

This was fixed in the original react-chartjs however there are a few long standing issues on that one and I was redirected here. However it doesn't appear that your library works in the same way for what i am trying to acheive.
On react-chartjs using chart.js v2 I am able to produce the below chart where I haven't specified an array of  labels and it has been able to scale the labels out based on my time.unit value;

See end for example code that works with the react-chartjs library but produces an error with react-chartjs-2 # which is  when you are trying to map the labels for the legend.

If I change labels field in code below to "labels: ['Dataset']". Then the chart renders but no data and y axis:

    var data = {
        labels: 'Dataset',
        datasets: [{
            data: [
            { datetime: moment().hour(8).minute(0).format('X'),  rate: 1.1757},
            { datetime: moment().hour(8).minute(2).format('X'),  rate: 1.1797},
            { datetime: moment().hour(8).minute(9).format('X'),  rate: 1.1697},
            { datetime: moment().hour(8).minute(11).format('X'), rate: 1.1717},
            { datetime: moment().hour(8).minute(22).format('X'), rate: 1.1715},
            { datetime: moment().hour(8).minute(29).format('X'), rate: 1.1747},
            { datetime: moment().hour(8).minute(35).format('X'), rate: 1.1691},
            { datetime: moment().hour(8).minute(45).format('X'), rate: 1.1797},
            { datetime: moment().hour(8).minute(49).format('X'), rate: 1.1817},
            { datetime: moment().hour(9).minute(1).format('X'),  rate: 1.1857},
            { datetime: moment().hour(9).minute(12).format('X'), rate: 1.1847},
            { datetime: moment().hour(9).minute(33).format('X'), rate: 1.1877},
            { datetime: moment().hour(10).minute(0).format('X'), rate: 1.1957},
            { datetime: moment().hour(11).minute(0).format('X'), rate: 1.1857}
        ];
        }]
    };

  var options = {
        legend: {
            display:false,
        },
        // showXLabels: 10,
        responsive: true,
        maintainAspectRatio: false,
        scales: {
            xAxes: [{
                type: 'time',
                position: 'bottom',
                time: {
                    parser: 'X',
                    unit: 'hour',
                    tooltipFormat: 'LT',
                    max: moment().hour(11).minute(0).format('X'),
                    displayFormats: {
                        'hour': 'LT'
                    }

                }
            }]
         }
    };

Hello @dmason30 ,
Apologies for not reaching back before, it's a hectic time.
Will be checking this soon.
Thank you,

Hello @dmason30 ,
Have you checked how Mixed chart was done.
Example is at http://gor181.github.io/react-chartjs-2/
Source at https://github.com/gor181/react-chartjs-2/blob/master/example/src/components/mix.js
If it doesn't help please try to make a fiddle with just chart.js being used.
Thanks

https://jsfiddle.net/qf1ff67j/
@gor181 I have managed to use the same options as above and chart.js renders fine. I'm sorry its been so long I was hoping react-chartjs would actually update at some point but it seems abandoned, so I am reconsidering switching to your repo.


Flatten fields during ingestion

This is a followup task to https://github.com/apache/incubator-pinot/issues/5135
Transform functions support was added recently (b20ace081fc8566490d5e8addc211537843c8a9a). This supports simple column transformations using Groovy script, during ingestion.
Next step would be to support flattening fields during ingestion.
Contributions welcome

Initial thoughts:
Groovy functions are capable of handling non-flat objects (list, map, complex object). The only piece missing right now is the RecordExtractors expect single value or Collection. A complex object will not be correctly forwarded to the Transformer. If RecordExtractors correctly pass forward the complex objects, groovy should flatten it. This is partially being done in AVRORecordExtractor, where we also handle Map.

Is this for supporting complex/nested data types (json with hierarchical data) in Pinot and query processing on such types
I have an on-going POC here https://github.com/siddharthteotia/incubator-pinot/commits/nested

@siddharthteotia no, this is just pure flatten + extraction during ingestion.

This is supported using the complex type transformer right? Or is task talking about something else?

Yes. @rseetham Thanks for the pointer. Closing this one


Attempting to fix broken rsync

Hey @rafaelfsilva I noticed that you had commented out the rsync tests in main. They are broken in main after you refactored a few things. I just wanted to make sure you knew how to test them if you need to. I'll try to fix them in this pr. The tests are set to run between two of the vms on CADES Cloud that Ketan set up. One of them has an env variable defined that points to the SSH key you need to run the tests. The last 2 digits of the IP for that machine are 48.

@rafaelfsilva I noticed that you changed the run methods arguments to plugins, I have also adapted to the check() method in this case so that it is consistent to what you changed this was part of the problem.

@rafaelfsilva please merge this if you are happy with it.


Git 2+ and rake release

Hello!
After building a new gem using bundler, and commiting changes to a repo, I am unable to use rake release due to a change in how git 2+ handles the push subcommand.
When I run rake release, I receive the following error:
 be rake release[origin]
testgem 0.1.0 built to pkg/testgem-0.1.0.gem.
Tagged v0.1.0.
Untagging v0.1.0 due to error.
rake aborted!
Couldn't git push. `git push origin 2>&1' failed with the following output:

warning: push.default is unset; its implicit value has changed in
Git 2.0 from 'matching' to 'simple'. To squelch this message
and maintain the traditional behavior, use:

  git config --global push.default matching

To squelch this message and adopt the new behavior now, use:

  git config --global push.default simple

When push.default is set to 'matching', git will push local branches
to the remote branches that already exist with the same name.

Since Git 2.0, Git defaults to the more conservative 'simple'
behavior, which only pushes the current branch to the corresponding
remote branch that 'git pull' uses to update the current branch.

See 'git help config' and search for 'push.default' for further information.
(the 'simple' mode was introduced in Git 1.7.11. Use the similar mode
'current' instead of 'simple' if you sometimes use older versions of Git)

fatal: The current branch master has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin master

Details:
bundler -v: Bundler version 1.11.2
gem -v: 2.2.2
ruby -v: ruby 2.1.1p76
git --version: git version 2.7.2

I think this is coming out of this file: https://github.com/bundler/bundler/blob/master/lib/bundler/gem_helper.rb, as this is where git commands are defined. Any ideas on how to fix this would be appreciated.

You need to set an upstream branch for your local branch to track

Thank you! That fixed it :+1:


[entropy_src] Recoverable "FIELD" alerts firing continuously

This issue is similar to #10134, in that it involves recoverable alerts that are firing continuously.  In this case it is the 11 different *_FIELD_ALERTS which are designed to check whether a bad MuBi has been received.   Once a bad MuBi has been written the alert fires continuously until the bad MuBi has been corrected.
This was not caught previously because the up to now the only sequence that performed such tests did not use scoreboarding.  However now that this class alert events is being added to the scoreboard however, this is causing troubles with verification.  The alerts are firing continuously and do not stop until the bad register has been corrected.  However, there is no time for the sequence to identify the problem before the alert refires.  (Image below)

This should be resolved by making the input to the alert primitives an edge sensitive quantity.

@mwbranstad, could you please take a look at #13747 as a possible fix to this?


Is tantivy suited for 1-5 billions web pages?

Hi, I'm trying to see if tantivy is suited for indexing/searching a 1-5 billion web pages. eg Typesense loads all index in memory and it must fit, so it won't work.
You mention 'distributed' is not supported by default.  Adding toshi or bayard on top would be a good solution?
What would you recommend?
Is there a doc similar to https://github.com/valeriansaliou/sonic/blob/master/INNER_WORKINGS.md ?
Thanks!

Absolutely. I personally indexed more than a billion page and a desktop with 8GB of RAM :).
But nothing is helping you for distribution at this point.
Bayard and Toshi won't help because, AFAIK they do not support sharding yet.
However, implementing distributed search is rather easy... Especially due to the way collector are implemented.
If you have 30mn to casually discuss your use case, feel free to book a meeting with me,
I'd love to know more about your use case.
https://calendly.com/paul-quickwit/30min


[msal-angular] Update readme and docs

This PR:

Updates MSAL Angular v2 readme to include new samples
Updates Multi-tenant doc to include dynamically changing authorities

Looks good, feel free to merge when ready.


[fix][broker] Fix namespace deletion if __change_events topic has not been created yet

Fixes #18802
Motivation
Sending the event to the __change_events topic is useless if the namespace is deleted (or in the process of).
Also during the namespace deletion procedure, it's not possible to create new topics so if it doesn't exist yet it throws an error.
Modifications

Skip sending events for topic policies if the namespace has been deleted

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #18804 (56b34d6) into master (68ca60c) will decrease coverage by 13.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #18804       +/-   ##
=============================================
- Coverage     50.05%   37.04%   -13.01%
+ Complexity    11024     1969     -9055
=============================================
  Files           703      209      -494
  Lines         68814    14425    -54389
  Branches       7378     1574     -5804
=============================================
- Hits          34446     5344    -29102
+ Misses        30621     8494    -22127
+ Partials       3747      587     -3160

Flag
Coverage Δ

unittests
37.04% <ø> (-13.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rg/apache/pulsar/client/impl/PulsarClientImpl.java
43.47% <0.00%> (-1.33%)
:arrow_down:

.../service/SystemTopicBasedTopicPoliciesService.java

...oker/transaction/buffer/metadata/v2/TxnIDData.java

...ersistentStreamingDispatcherMultipleConsumers.java

...oker/stats/prometheus/AggregatedProducerStats.java

...fload/jcloud/provider/JCloudBlobStoreProvider.java

...ar/broker/protocol/ProtocolHandlerDefinitions.java

...sar/broker/service/plugin/EntryFilterMetaData.java

.../main/java/org/apache/pulsar/PulsarStandalone.java

...che/bookkeeper/mledger/ManagedLedgerException.java

... and 486 more

@gaoran10 @Technoboy- PTAL


API docs: use Dart sample for NgZone

Fixes #267
Full example committed via https://github.com/dart-lang/site-webdev/pull/508
cc @kwalrath

@matanlurey any idea why https://travis-ci.org/dart-lang/angular2/jobs/217031298 failed?

@kwalrath – seems these are just new errors with the latest Dart
See https://travis-ci.org/dart-lang/angular2/jobs/216538815 on the master branch...

@kwalrath + @matanlurey filed an issue against analyzer: https://github.com/dart-lang/sdk/issues/29221

Anything needed before this is merged?

Nope!


Undefined variable: index . Invalid expression: [a:string[index:]]

getting this error when hitting F12
Error detected while processing function quickmenu#toggle[24]..<SNR>187_menu_expand[2]..<SNR>187_expand_text: line    6: E121: Undefined variable: index: E15: Invalid expression: [a:string[index:]]

That's impossible, index has been defined in line 495. are you using the latest version ? 1.1.13.
Would you please provide me your quickmenu#append config ?

I see, you were running vim 7.3 right ??

Please update to the latest release.
incompatible issues have been fixed.

I installed the plugin via vundle. The latest vommit I see in my local repo is:
`commit d03ad08aa084b04722607455e8ea48af1a7ee5fa
Author: skywind3000<EMAIL_ADDRESS>Date:   Fri Jul 14 01:05:05 2017 +0800
update quickmenu`

I also changed the Key to F8 but see the same issue there.
I use vim 7.4
⇒  vim --version VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr  4 2017 18:14:54)

d03ad08 is still incompatible with earlier vim 7.4, see here
you need :PluginUpdate and restart vim

@skywind3000 yep, that helped - thanks!


Clarity on scope of benefits

It's taken me a while to realise something that's perhaps obvious, so it might be worth clarifying in this page? I've got a VS subscription on domain A, with an alternate account on domain B. The B account has been added to a client's ADO organisation + project, and so when I log in to VS with the A account, I expected the list of ADO servers available to include the client's instance, hoping that VS would list ADO instances for both accounts. I can't login to VS directly using the B account, because I'm using a cloud-hosted box (for D365 F&O development), and the B domain is restricted to corporate devices. I believe the answer is that we need the client to add account A directly to their ADO organisation: the alternate account is getting the subscription benefits, but the primary account isn't getting the alternate account access/privileges.  I think the Note about signin at my.visualstudio.com goes a tiny bit of the way to explaining this "non-reciprocal" relationship, but still would like it to be clear what does & doesn't happen by account association. Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b8a5f5e2-2957-f296-5551-750ff9d0cff1
Version Independent ID: 88a13bf8-eddc-3e72-0c97-93d7013854ac
Content: Use connected identities in Visual Studio subscriptions
Content Source: subscriptions/use-connected-identities.md
Product: visual-studio-family
Technology: vs-subscriptions
GitHub Login: @evanwindom
Microsoft Alias: amast

@rrhkpmg -- thank you for your feedback.
@evanwindom -- please look into this issue.

@rrhkpmg Thank you for reaching out.  I would expect it to be exceedingly rare for a subscriptions admin to assign a subscription to one identity and then their Azure DevOps access to another.  I'm concerned that trying to explain the ramifications of such a niche situation could inject complexity into the document that would cause more confusion than it solves.

@evanwindom I'll let you folks make that call. It's a scenario I see for dozens of colleagues literally every day, and I've had multiple employers who only allow their domain accounts to authenticate on domain-joined machines, but concede it's only in the last five years that I've encountered so much cloud-hosted VM use, so I appreciate this experience may still fall into the category of "exceedingly rare" across the entire audience for this page. Would it be accurate to say that the benefits only flow in one direction?

@rrhkpmg Thanks for the feedback.  We'll keep an eye on this and see if others have the same question.  If they do, we'll revisit it.

#please-close

@WilliamAntonRohm Can you close this, please?

#please-close


Error in console on Windows regarding comboboxes

On Windows, editing a combobox (take e.g. the PointCloud display and edit the topic name), a warning gets added to the console:
rviz_common::properties::EditableComboBox::setProperty: Property "currentText" invalid, read-only or does not exist
This can be eliminated by eliminating the class rviz_common::ComboBox with apparently no change in functionality. This class seems to limit the writability of ComboBoxes, yet they can be edited nevertheless. Can this be deleted?

I would say it shouldn't be deleted, but instead it sounds like disabling editing is broken (perhaps that was missed in the port to Qt5).


WASM backend having issue

Issue Description
when we are trying use WASM backend we are getting the following error message
tfjs-backend-wasm-simd.wasm:0xaa3 Uncaught (in promise) RuntimeError: memory access out of bounds
at tfjs-backend-wasm-simd.wasm:0xaa3
at tfjs-backend-wasm-simd.wasm:0x1b3ef
at Wk.move (human.js:4613)
at Wk.write (human.js:4613)
at rc.makeTensor (human.js:11)
at Kr (human.js:11)
at dn (human.js:11)
at Object.Z5 (human.js:11)
at x7.loadSync (human.js:40)
at x7.load (human.js:40)
Steps to Reproduce
We are running human inside webworker and when we set the backend to webgl or cpu it works fine. Our front end is in react anad we have added the following 2 script tags to our index.html

<script<EMAIL_ADDRESS>
Our WASM path is specified as
"https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>We are importing the human script
self.importScripts(
<EMAIL_ADDRESS>);

Fixed when I looked at the demo I saw that the WASM backend was point to 3.9 and I updated it and it is working

correct, version of wasm binaries must match version of tfjs used - and i've upgraded to tfjs 3.9.0 earlier this week
to avoid versioning issues, i've added dynamic default for wasm path if there is no user setting:
(if wasmpath is set in user config, it will override default value)
defaults.wasmPath = `https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>


GGUF/GPTQ models for LLaVA-1.5

Question
Hello,
Is anyone aware of the 4-bit quantized models for LLaVA-1.5 available on Hugging Face?
Thanks in advance!

Se ggerganov/llama.cpp#3436 for GGUF (llama.cpp) version

what are the system requirement for that? (running solely on CPU?)

https://huggingface.co/mys/ggml_llava-v1.5-7b
https://huggingface.co/mys/ggml_llava-v1.5-13b
7b works better than 13b for now.
Use the llama.cpp repo and run the make command and use ./lava
Runs on CPU. More info on this PR

The bug seems to be fixed in https://github.com/ggerganov/llama.cpp/pull/3645
Now the quality for both 7b and 13b are improved.
Closing this now.


Make symbol visibility explicit in our test/demo BMI modules

See comments here

https://gcc.gnu.org/wiki/Visibility
https://gist.github.com/ax3l/ba17f4bb1edb5885a6bd01f58de4d542
Current behavior
We're setting a compiler flag to make all symbols in the relevant modules visible
Expected behavior
Modules have the symbols actually necessary for BMI operation marked as exported, and everything else left to defaults.

Question... is the explicit visibility marking something that makes more sense in bmi.hxx? Would that work? Or would we have to mark the same methods explicitly in the concrete subclass anyway?


add package: terraform

Have you seen the go-packages.nix and buildGoPackage machinery? It seems like it would simplify this and help us keep a consistent pattern. I realize that consul currently uses the old pattern but I don't think we should keep using that one unless we have to.

I have seen it, but I failed in trying to use it. Maybe if you could give me an example for one dependency I could use it properly. I ended up creating a .nix file for every dependency I had which was totally overkill.


[FEATURE]

💡 Describe the feature

🆕 New component or addition to an existent one?

Hi there,
Tbh at this point all of the sudden some ideas storming and going to defenitly share as soon as I have precise plan.
🖼 Support images

NA
🙋♀ Do you want to build the feature?

[x] Yes
[ ] No

Hey @foundex,
thanks for opening this issue, but as it is now, I'm going to close it since it doesn't provide any value and just "intention" to share "an idea" in the future.
Issues must be descriptive enough, providing actionable work items that can be transformed into features, bug fixes, enhancements, etc. An effective way to create a descriptive and valid issue is to file the issue-template with all the info requested in there.
Please, whenever you find something that can add value, feel free to create a new valid issue.
Thanks,
Cesar

Hi Cesar,
Hope you're having a great wonderful day I'm really grateful that you
respect me and appreciate for the guidance I really need that please feel
fdeeply suspiciously to guide me and let me know whenever I did a mistake
or did you know I needed some proper advice he advanced I appreciate all
the help and thanks again I try my best to learn more and as you know I
understand the joint and I'm trying to learn and you guys that are teacher
so I appreciate if you be a little bit patient with me and teach me things
that you know I really great for that Thank you sincerely  Kian
On Wed, Jun 1, 2022, 05:01 Cesar Valiente @.***> wrote:

Hey @foundex
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffoundex&data=05|01|kmcrod1%40my.bcit.ca|2b82e080b84f45b1e4c708da43ad5381|8322cefd0a4c4e2cbde5b17933e7b00f|0|0|637896708943660473|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=auRw6a9g7ymJh%2BAMDwwlrK0Rv17iDRSdEcqW86o2ni0%3D&reserved=0
,
thanks for opening this issue, but as it is now, I'm going to close it
since it doesn't provide any value and just "intention" to share "an idea"
in the future.
Issues must be descriptive enough, providing actionable work items that
can be transformed into features, bug fixes, enhancements, etc. An
effective way to create a descriptive and valid issue is to file the
issue-template with all the info requested in there.
Please, whenever you find something that can add value, feel free to
create a new valid issue.
Thanks,
Cesar
—
Reply to this email directly, view it on GitHub
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fsurface-duo-dual-screen-experience-example%2Fissues%2F58%23issuecomment-1143328237&data=05|01|kmcrod1%40my.bcit.ca|2b82e080b84f45b1e4c708da43ad5381|8322cefd0a4c4e2cbde5b17933e7b00f|0|0|637896708943660473|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2F5aCXZUyXkp2Gvpdn9pIQu6Orju6%2BW2o7MaJzR%2FUkK8%3D&reserved=0,
or unsubscribe.
You are receiving this because you were mentioned. Message ID:
<microsoft/surface-duo-dual-screen-experience-example/issues/58/1143328237
@github.com>


web demo: moving the windows is very slow (since 0.18?)

Moving the windows in the web demo has always been fast for me.
To my surprise now (since 0.18?) on macOS it is very slow. It's not good in Firefox and unbearable in Safari.

This may be only on my system. It's better after a reboot. Not sure why it's only showing up in the web demo.


📝 chore(docs): Add Guides section

Current dependencies on/for this PR:

new-dawn

PR #1074   👈

This stack of pull requests is managed by Graphite.


D3D9 support?

Now it's missing. Any plan to add the support for D3D9 rendering path? (It's the only way to get MSAA working on NVidia GPUs or through dgVoodoo2 for every GPU).

Up!

No, it's not planned. You should be able to use other means of anti-aliasing together with the mod.

That's too bad. Most post processing AA methods are fairly poor compared to their traditional counterparts; in fact it's the only feature the D3D11 renderer is lacking in. Understandably though, writing for two renderers would be a pain.

You might potentially have some luck with third party solutions to inject AA, but if that doesn't help then I don't think I have other ideas.