Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?

Yes
Module Owner's GitHub Username (handle)
ilhaan
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @ilhaan,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

NOTE:

This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @ilhaan,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
We just want to ask you to double check a few important things and take the next steps before you start the development.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - to name your module
TelemetryIdPrefix - to be used in your module's telemetry

For your module's repository:

Repository name and folder path are defined in RepoURL
Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns and grant them permissions as described here.

In case of a Bicep module, please let the AVM core team know when you created these teams, and we'll help you with assigning the necessary permissions as described here.
In case of a Terraform module, follow the instructions here and assign the necessary permissions.

Grant the right level of permissions for  the AVM core team and PG teams on your GitHub repo as described here.
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

NOTE:

This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@ilhaan,
Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.
The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!
Please see the new naming convention in:

RMNFR1 for resource modules
PMNFR1 for pattern modules

Please note that the Telemetry ID and name of GitHub Teams haven't changed.
If you feel uncertain about any details, please check the Bicep modules indexes.

@matebarabas thanks for letting me know. I have created the following GitHub teams for this module:

https://github.com/orgs/Azure/teams/avm-res-network-applicationgatewaywebapplicationfirewallpolicy-module-owners-bicep
https://github.com/orgs/Azure/teams/avm-res-network-applicationgatewaywebapplicationfirewallpolicy-module-contributors-bicep

I've just requested the -owners- team to be added to the -technical-reviewers- team. Please approve.

@ilhaan, I just would like to check back on this issue and ask how far do you think you are? Can you please share your expected timeline on publishing this module? Is there anything you need help with?
Thank you!
CC: @jeanchg

@matebarabas I should have an initial PR for this out by the end of next week.

Awesome, thanks for the update!

Still working on this

Still working on this

@matebarabas I will help @ilhaan with this one, please add me a assignee.

In PR: https://github.com/Azure/bicep-registry-modules/pull/1471

@matebarabas @ilhaan PR has been merged

[x] Module published.
[ ] GitHub teams are available and assigned to their parents. The avm-res-network-applicationgatewaywebapplicationfirewallpolicy-module-contributors-bicep team is not assigned to its respective parent (avm-module-contributors-bicep) yet. @ilhaan can you please initiate the assignment so we can close this issue? Thank you!
[x] CODEOWNERS file updated.

Thank you for your work @krbar!

GH team setup issue resolved. Closing.


Issue wiht playing YouTube Videos

A case in point is this trailer for "The beauty and the beast" hosted in this url ( https://www.youtube.com/watch?v=SqQvZ_VUtg8 ) .  when passed to the video player, it gives a bad url error and when i tracked the cause, it turns out it transforms the upper case letters to lower case so the url being read by the player is "https://www.youtube.com/watch?v=sqqvz_vutg8" which is invalid.
Any help on this issue will be deeply appreciated.

This project use ijkplayer to play video, it can not play youtube url, that url is not point at video file.
I do not know how to play youtube videos, do you have example I will learn it before.

i came across this repository while looking for an alternative to the YouTube API intent and that's why am asking. But when i find a work around, I'll update you.

This project with Ijkplayer can not play youtube video directly by that url .

try version 5.+ maybe support


Support JUnit platform reporting entries

When a failing test also publishes report entries, those should be displayed.
Expected Behavior
The junit platform TestExecutionListener has a method reportingEntryPublished which is called when tests report additional data. Those entries should be displayed/logged in gradle's output when a test fails. They should also show up in the generated html report.
Current Behavior
Nothing is shown.
Context
IntelliJ, Eclipse, Maven and the junit-platform-gradle-plugin actually report the entries.
Those entries usually give important additional information to interpret test results.
For example, jqwik (http://jqwik.net) uses those entries to report the random seed
which is needed to reproduce errors.
Steps to Reproduce (for bugs)
Running the following test through gradle should not only report a failure but also something
like timestamp = 2018-03-06T15:40:33.704, key = value (IntelliJ's output)
@Test
void failingTestWithReporting(TestReporter reporter) {
	reporter.publishEntry("key", "value");
	org.junit.jupiter.api.Assertions.fail("Fails with an additional report entry");
}

Your Environment
OSX, Java 8, Gradle 4.6

As mentioned on the #4716:
We should overhaul our test logging infrastructure holistically. We have already added display names, but only to the html report and console log. Now we are considering JUnit 5's reporting entries.
We should decide what things we want to support in a cross-cutting way (so that other test frameworks can be adapted to it). A display name makes a lot of sense. A Map<String, String> of "additional data" also seems like something other test frameworks might be interested in.
This information should be exposed to

Build scans
TestListeners
Tooling API (so IDEs can display it)
Console
HTML report

@blindpirate before we continue here we should have a small design spec that addresses the above and proposes an API. We should make sure this API also makes sense for the native tests frameworks for instance.
We should not just add reporting entries as test output, because otherwise people might start depending on this implementation detail and try to parse that output. Then we'd be stuck if we wanted to change it to something more strongly modeled. Let's do some design first.

Please keep in mind that reporting features like display names and reporting entries (via a map of key-value pairs) will end up in the new reporting format from the Open Test Alliance. So that should make them mainstream... once that new format is supported.

@sbrannen is there already a spec for the format?

No, unfortunately not (yet).
That will be discussed here: https://github.com/ota4j-team/opentest4j/issues/9
So feel free to chime in there with comments.

Any updates on this one?
With JUnit platform 1.3.0 looming, the old gradle plugin will no longer be supported and there's no way to run up-to-date junit 5 engines with reporting support.

Any updates on this one?

I'm afraid not. We're busy working on Gradle 5.0 at the moment. I hope to tackle this and other JUnit Platform issues (e.g. #6453) in the 5.1 timeframe.

What a bummer. Especially since I don't see any workaround.

You could register a TestExecutionListener that prints them to stdout where Gradle should pick them up and add them to the test report.

Is there anyway to get stdout added to Gradle console output in case of a test failure? That's what I'd actually need since the test report is a few clicks away.

@sbrannen @marcphilipp Both things together should make a simple mechanism possible. I'll see what I can figure out.

This is actually what I resorted to as Maven is also lacking support for report entries and we really like JUnit 5 and jqwik :)

There's a simpler way for jqwik: https://jqwik.net/docs/current/user-guide.html#jqwik-configuration
If you set useJunitPlatformReporter = false jqwik will do its own reporting to stdout.

This issue sounds valuable to me.

We need a solution for this.

No, unfortunately not (yet).
That will be discussed here: ota4j-team/opentest4j#9
So feel free to chime in there with comments.

A proof-of-concept was published as a result: https://github.com/ota4j-team/open-test-reporting. That's a step forward. What should its status be for Gradle to start working on it?

Hi
Any update on this issue?
I am having Junit gradle setup for my backend tests and am publishing request response log using
testReporter.publishEntry(testName + "" + key, value);
context.publishReportEntry(testName + "" + key, value);
The logs are not getting displayed in the Junit reports in local and also not in Azure devops pipeline build.


Bug: Toolbar heading dropdown menu not reacting to scroll properly (stays fixed)

Behavior:
https://user-images.githubusercontent.com/91459898/233331365-7efc78c4-569b-4d46-b41a-c0d3316926ff.mov
Code: https://codesandbox.io/s/vibrant-nightingale-172df9?file=/src/Editor.js
Expected behavior: Dropdown menu to follow rich text editor position.
Can someone help me with this problem?

Sorry, this is a UI issue, not a lexical one. You can use any number of open source dropdown elements in your toolbar, or you can modify this one to work in your UI context. Unfortunately we just don't have the capacity to help with things like this right now.


Build with poetry-dynamic-versioning-plugin failure

Hello trying this out but running into a problem.
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Build and publish to pypi
        uses<EMAIL_ADDRESS>        with:
          pypi_token: ${{ secrets.PYPI_TOKEN }}
          plugins: "poetry-dynamic-versioning-plugin"

Is what my yaml looks like but i get this:
Using version ^0.4.0 for poetry-dynamic-versioning-plugin

Updating dependencies
Resolving dependencies...

Package operations: 4 installs, 0 updates, 0 removals

  • Installing markupsafe (2.1.3)
  • Installing dunamai (1.18.0)
  • Installing jinja2 (3.1.2)
  • Installing poetry-dynamic-versioning-plugin (0.4.0)

Writing lock file

No module named 'poetry.core.semver'

Any ideas?

I'm getting this error too

Looks like the issue is with poetry-core version 1.7 which removed poetry-core-semver. See the plugin for updates that resolve this: https://github.com/mtkennerly/poetry-dynamic-versioning/releases/tag/v1.0.1

@NickSebClark I was able to publish by forcing the poetry version via:
        with:
          poetry_version: "==1.5.1"

@natekspencer Thank you for helping out! :hugs:

@NickSebClark @natekspencer poetry-dynamic-versioning-plugin is super old, which is why you are getting this error. What you actually want is poetry-dynamic-versioning[plugin].
From the readme:

If you've previously installed the deprecated poetry-dynamic-versioning-plugin package, be sure to uninstall it before proceeding.

@NickSebClark @natekspencer poetry-dynamic-versioning-plugin is super old, which is why you are getting this error. What you actually want is poetry-dynamic-versioning[plugin].
From the readme:

If you've previously installed the deprecated poetry-dynamic-versioning-plugin package, be sure to uninstall it before proceeding.

Ahh, ok. It's the README of this repo that is causing the confusion. It still references poetry-dynamic-versioning-plugin rather than poetry-dynamic-versioning[plugin].

Updating it, thank you :pray:


spek: unstable-2018-12-29 -> 0.8.4

Description of changes
https://github.com/alexkay/spek/releases/tag/v0.8.4
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks!


.mfmc files unable to open with file explorer

If you double click a .mfmc file from file explorer, it opens your last used file, instead of the opened file.
Steps To Reproduce
Steps to reproduce the behavior:

Save a MobiFlight Configuration (Config 1)
Save a second MobiFlight Configuration, or save changes on an existing one (Config 2)
Open the first Configuration (Config 1)
Last used configuration shows (Config 2)

Expected behavior
MobiFlight would open the file double-clicked in file explorer.
Actual behavior
MobiFlight opens the last edited file.
Details

MobiFlight Version: 9.0.0
FlightSim: Any [Tested with FS2020]
AddOn: Any

Additional context
To my knowledge, MF used to open configs in previous versions.

This should also work with mcc files. But it doesnt at the moment.


[BEAM-3489] DataflowRunner to read PubsubMessage if getNeedsMessageId is true

Make sure PUBSUB_SERIALIZED_ATTRIBUTES_FN is set if getNeedsMessageId is true. Based on a comment in https://issues.apache.org/jira/browse/BEAM-3489?focusedCommentId=17110444&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17110444.
R: @lukecwik

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Dataflow ValidatesRunner

Run Java PreCommit

retest this please

retest this please

Run Java PreCommit

Run Java PreCommit

retest this please

retest this please

retest this please

Hi aaltay, thanks for your help!
I'm not able to see the error in the jenkins log so not sure how to proceed.
Do you have any pointers to resolve this issue?
Thank you,
Thinh

Tests look like they aborted after a timeout. I am not sure, but probably not related to your change. Maybe we can rerun the tests.

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit


General Code Cleanup

Coverage decreased (-0.03%) to 95.179% when pulling cd15126b5069c7a778a034cc236591b17c055d79 on verhas:CLEANUP into 4f3d3b4318add50a7e45feab3005621773e7e4cb on apache:master.

"Coverage decreased (-0.2%) to 94.965% when pulling 5e197f3 on verhas:CLEANUP into 4f3d3b4 on apache:master."
This simply shows that the tested code became shorter. Yes, I also deleted a test that actually did nothing, it was asserting that a returned boolean value is either true or false (what else?).
So if anyone takes the effort to review this pull request then do not blindly toss it aside because of the coverage in terms of percentage (which is not a good measure really for the very reason demonstrated here) decreased.


flannel does not get rid of unused config in etcd

When Flannel manages a lot of subnets there will be a lot of data created in etcd. I see that this data is always kept, even though the subnets do not exist anymore. I did not find configuration for making flannel cleaning up etcd data over time. How is this supposed to work? IMO Flannel should take care of the state within etcd and should curate orphaned data from time to time. WDYT?

Thanks for raising this but it doesn't match my understanding. Flannel shouldn't be leaving any state data in etcd - can you give me a specific example of what you're seeing?

@xh3b4sd I'm going to close this issue as I think flannel is getting rid of unused config in etcd. If you're still seeing this problem then please reopen the issue


the result was computed repeat when in a search with two aggregations in one field

the search query like this:
query := bluge.NewBooleanQuery().AddMust(bluge.NewMatchAllQuery())
searchRequest := bluge.NewTopNSearch(1, query).WithStandardAggregations()
searchRequest.AddAggregation("my-agg-min", aggregations.Min(search.Field("rating")))
searchRequest.AddAggregation("my-agg-avg", aggregations.Avg(search.Field("rating")))
searchRequest.AddAggregation("my-agg-sum", aggregations.Sum(search.Field("rating")))

in this case, my-agg-sum result value large than the real value 3 multiple. equal to rating field appear times. it seems computed repeat.

Yes, you are correct, that if you compute multiple aggregations on the same field, the code we have to try and accumulate the list of field we care about will contain duplicates.
Do you know if this actually causes problematic behavior?  Like, do we do extra work 3 times because it appears multiple times in that list?
I'm fine with the fix, but I think we should try to add a test case to illustrate the problematic behavior.

I did remember one more detail related to this.
One concern I had at the time I originally wrote this part, was that because aggregations can be nested, enumerating the fields required involves enumerating the fields required for all child aggregations as well.  I didn't like the idea that we de-duplicate this list at every level, especially when we immediately merge it with another list, and the have de-duplicate that again.  Based on that thinking, I figured, so what if this method returns duplicates, if any caller is going to use this list to do real work, they should do one de-duplication pass at the very end.
So, I'm pretty sure that's why this method does not do any de-duplication today.  It would help to know more precisely how this current behavior is problematic, as maybe there is some other solution...

i saw the flow on aggregation, one documentMatch will deeply flow in every nested aggregation, so one field should be compute one time, this is still a problem.
i fixed in my pull cetainly will de-duplicate at every level, i will try to find other better solution.


Fix feed query parameter not using at-uri.

Since https://github.com/bluesky-social/feed-generator/commit/bc753388c3c02cebeee961ec456cca07ec8bc19d the app.bsky.feed.getFeedSkeleton Lexicon has been using the at-uri format and not a string, breaking the current feed query parameter, this PR fixes that.
https://github.com/bluesky-social/feed-generator/blob/bc753388c3c02cebeee961ec456cca07ec8bc19d/src/lexicon/lexicons.ts#L4552-L4558

@dholms resolved this with https://github.com/bluesky-social/feed-generator/commit/2bff86cb4e402141855a8a073db1409cb49a0e32.


Redesign Front-end

Screen shot for references

Not closing the issue here as these are some of the CSS improvements. There is scope for a lot more design improvements.Most importantly making the site responsive.

@arnav-t Kindly review.

@arc9693 I've left a review.
Also, if you are here from KWoC, please join this GItter channel.
We can further discuss the design there.

Response to suggestions:

 Would really like to keep the title as it is. If change is strictly needed , then OK
 Title size correction - OK
 Readable font for subheadings - OK
 Sidebar looks highlighted with black color also it differentiates the sidebar section as well. Would like you to be more specific regarding changes.
 Gradient  for the highlighted subjects - OK
 Will change the font for uploaded file names

Response to suggestions:

 Would really like to keep the title as it is. If change is strictly needed , then OK
 Title size correction - OK
 Readable font for subheadings - OK
 Sidebar looks highlighted with black color also it differentiates the sidebar section as well. Would like you to be more specific regarding changes.
 Gradient  for the highlighted subjects - OK
 Will change the font for uploaded file names

Response to suggestions:

 Would really like to keep the title as it is. If change is strictly needed , then OK
 Title size correction - OK
 Readable font for subheadings - OK
 Sidebar looks highlighted with black color also it differentiates the sidebar section as well. Would like you to be more specific regarding changes.
 Gradient  for the highlighted subjects - OK
 Will change the font for uploaded file names

@arnav-t
Hope we are good to go now! Kindly review. :smile:


Critical dependency: the request of a dependency is an expression - Dynamic import

Version
4.5.7
Reproduction link
https://github.com/babel/babel/issues/11607
Environment info
  System:
    OS: Linux 4.19 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
  Binaries:
    Node: 14.3.0 - ~/.nvm/versions/node/v14.3.0/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v14.3.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    @ky-is/vue-cli-plugin-tailwind: ^2.0.0 => 2.0.0
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-helper-vue-transform-on:  1.0.0-rc.2
    @vue/babel-plugin-jsx:  1.0.0-rc.3
    @vue/babel-plugin-transform-vue-jsx:  1.1.2
    @vue/babel-preset-app:  4.5.7
    @vue/babel-preset-jsx:  1.1.2
    @vue/babel-sugar-functional-vue:  1.1.2
    @vue/babel-sugar-inject-h:  1.1.2
    @vue/babel-sugar-v-model:  1.1.2
    @vue/babel-sugar-v-on:  1.1.2
    @vue/cli-overlay:  4.5.7
    @vue/cli-plugin-babel: ^4.5.7 => 4.5.7
    @vue/cli-plugin-eslint: ^4.5.7 => 4.5.7
    @vue/cli-plugin-router:  4.5.7
    @vue/cli-plugin-vuex:  4.5.7
    @vue/cli-service: ^4.5.7 => 4.5.7
    @vue/cli-shared-utils:  4.5.7
    @vue/component-compiler-utils:  3.2.0
    @vue/preload-webpack-plugin:  1.1.2
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^7.0.1 => 7.0.1
    vue: ^2.6.12 => 2.6.12
    vue-avatar-component: ^1.3.1 => 1.3.1
    vue-click-outside: ^1.1.0 => 1.1.0
    vue-eslint-parser:  7.1.0
    vue-force-next-tick: ^1.1.0 => 1.1.0
    vue-global-events: ^1.2.1 => 1.2.1
    vue-goodshare: ^1.5.1 => 1.5.1
    vue-gtag: ^1.9.1 => 1.9.1
    vue-hot-reload-api:  2.3.4
    vue-i18n: ^8.22.0 => 8.22.0
    vue-inline-svg: ^2.0.0 => 2.0.0
    vue-lazyload: ^1.3.3 => 1.3.3
    vue-loader:  15.9.3 (16.0.0-beta.8)
    vue-loading-overlay: ^3.4.2 => 3.4.2
    vue-meta: ^2.4.0 => 2.4.0
    vue-multipane: git https://github.com/MediaComem/vue-multipane.git => 1.0.1
    vue-resize:  0.4.5
    vue-router: ^3.4.6 => 3.4.6
    vue-static: 0.0.5 => 0.0.5
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.12 => 2.6.12
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.5.1 => 3.5.1
    vuex-persist: ^3.1.3 => 3.1.3
  npmGlobalPackages:
    @vue/cli: 4.5.7

Steps to reproduce
Upgrading from 4.3.1 to 4.4.0 (theoretically. It was tested with the latest version only: 4.5.7.)
What is expected?
No warning
What is actually happening?
A webpack warning at the end of the dev build: Critical dependency: the request of a dependency is an expression.
Modules or files using dynamic import are impacted and doesn't load anymore.

Forcing the resolutions of babel-plugin-dynamic-import-node to 2.3.0 fix the issues (vue-cli from 4.4.0 to 4.5.7use 2.3.3).
According to Babel community (https://github.com/babel/babel/issues/11607), vue-cli should not use babel-plugin-dynamic-import-node (or should use the webpack version babel-plugin-dynamic-import-webpack).

But Vue CLI won't enable this plugin unless NODE_ENV equals test or you are invoking the test:unit command. What's your configuration?

Thanks for your quick reply. You actually gave me a good hint. My .env was based on an old configuration provided by vue-element-admin which with vue-cli 3 promoted the use of VUE_CLI_BABEL_TRANSPILE_MODULES for faster compilation which doesn't work as expect with vue-cli 4 according to their doc: https://github.com/PanJiaChen/vue-element-admin-site/blob/master/docs/es/guide/advanced/lazy-loading.md#vue-cli3-the-plan-has-been-eliminated


Use /bin/sh in the disk monitor integration test

:notebook_with_decorative_cover: Description
/bin/bash doesn't work on NixOS, but /bin/sh is mandated by Posix and does work. Since we're not using any bashisms I went with /bin/sh over /usr/bin/env bash.
:memo: Checklist

[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions
Trivial.

POSIX FTW.

Is echo $(($np + 1)) really POSIX? (The arithmetic, that is.)


Map editor

wahbaboy
https://trello.com/b/j4hGynMQ/mapping-todo

reopen once you are actively working on this


CI for Node

Contains the compiled JavaScript (4 ms)
Initializes with two players (3 ms)
Starts the game with a random player (1 ms)
Sets the current player to be whoever it is not (1 ms)


riak: added extraAdvancedConfig option to service module

Motivation for this change
Added the option to modify the advanced.config file in the /etc folder for riak. Need this for specific Riak CS configurations.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @LnL7

Thanks @LnL7 !


MJPEG not working on hi3518ev100 + ov9712 on recent builds

On recent builds (in past few months) of majestic, on hi3518ev100 + ov9712, the mjpeg/jpeg does not work
This was working on majestic in my last openipc custom build, which was from February.
When turning on mjpeg support (.jpeg.enabled: true), then I see this in the logs, and the /mjpeg endpoint does not work.
14:28:36  <       majestic> [     hal] HiSi_HAL_VENC_CreateChn@245   Cannot create VENC chn 1
14:28:36  <       majestic> [     hal] HiSi_HAL_VENC_CreateChn@245   ERR_VPSS_ILLEGAL_PARAM: The VPSS parameter is invalid

I have tried .isp.blkCnt from 4 to 10, but does not change.
root@openipc-hi3518ev100:/tmp/majestic-hi3516cv100# ./majestic
14:28:35  <       majestic> [    main] main@237                      Majestic Lite for HiSilicon, version master+c9ab4db, built on 2024-07-03
14:28:35  <       majestic> [watchdog] watchdog_start@94             Detected Hisilicon Watchdog
14:28:35  <       majestic> [watchdog] watchdog_start@115            Watchdog timeout set to 300 seconds
14:28:35  <       majestic> [   httpd] start_web_server@379          Set server path: /var/www
14:28:35  <       majestic> [   httpd] new_http_server@367           HTTP server started on :::80
14:28:36  <       majestic> [    main] init_sdk@66                   Loading main configuration: /etc/majestic.yaml
14:28:36  <       majestic> [     sdk] try_sensor_config@3295        SENSOR=ov9712
14:28:36  <       majestic> [     sdk] find_sensor_config@3263       matched sensor config: ov9712_i2c_dc_720p.ini
14:28:36  <       majestic> [     sdk] start_sdk@386                 Using /etc/sensors/ov9712_i2c_dc_720p.ini sensor configuration file
14:28:36  <       majestic> [     sdk] start_sdk@391                 App was built with MPP version: Hi3518_MPP_V1.0.B.0.
14:28:36  <       majestic> [     sdk] start_sdk@396                 Current MPP version: HI_VERSION=Hi3518_MPP_V1.0.B.0
14:28:36  <       majestic> [     sdk] start_sdk@424                 sensor ov9712
14:28:36  <       majestic> [     sdk] start_sdk@432                   dev [1280x720]@0x0 15fps, BGGR
14:28:36  <       majestic> [  sensor] try_to_load@19                trying to load /usr/lib/sensors/libsns_ov9712_i2c_dc.so
14:28:36  <       majestic> [     hal] hisi_free_mem_ex@753          Free MMZ mem before allocation: 23676KB
14:28:36  <       majestic> [     sdk] dump_vb_configuration@2193    VB configuration:
14:28:36  <       majestic> [     sdk] dump_vb_configuration@2196      [0]: 1413120 x 10
14:28:36  <       majestic> [     hal] hisi_free_mem_ex@753          Free MMZ mem after allocation: 9856KB
14:28:36  <       majestic> [     sdk] init_sensor@2388              Sensor driver loaded
14:28:36  <       majestic> [     sdk] log_venc_chn@1250             h264 1280x720@15fps 1024kbit 15gop
14:28:36  <     iq_monitor> [     sdk] monitor_thread@313            Loading IQ profile /etc/sensors/iq/default.ini
14:28:36  <       majestic> [     sdk] create_vpss_chn@995             venc_chn: 0, vpss_grp: 0, vpss_chn: 0
14:28:36  <       majestic> [     sdk] start_video@1936                venc took 3400KB of MMZ [675]
14:28:36  <       majestic> [     sdk] log_venc_chn@1250             MJPEG 1280x720@5fps 50q
14:28:36  <       majestic> [     sdk] create_vpss_chn@995             venc_chn: 1, vpss_grp: 0, vpss_chn: 1
14:28:36  <       majestic> [     hal] HiSi_HAL_VENC_CreateChn@245   Cannot create VENC chn 1
14:28:36  <       majestic> [     hal] HiSi_HAL_VENC_CreateChn@245   ERR_VPSS_ILLEGAL_PARAM: The VPSS parameter is invalid
14:28:36  <       majestic> [     sdk] start_sdk@544                 HiSilicon SDK started
14:28:36  <       majestic> [     hal] hisi_free_mem_ex@753          Free MMZ mem finally: 2292KB
14:28:36  <       majestic> [    rtsp] rtsp_init@28                  RTSP server started on port 554
14:28:38  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:40  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:42  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:44  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:46  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:48  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:50  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:52  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:54  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:56  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:28:58  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:00  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:02  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:04  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:06  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:08  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:10  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:12  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:14  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:16  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:18  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:20  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:22  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:24  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:26  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:28  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:30  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:32  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0
14:29:34  <       majestic> [     sdk] venc_read@915                 Timeout from venc channel 0

root@openipc-hi3518ev100:/tmp/majestic-hi3516cv100# cat /etc/majestic.yaml
system:
  webPort: 80
  httpsPort: 443
  logLevel: debug
  buffer: 1024
  plugins: false
isp:
  blkCnt: 10
  antiFlicker: disabled
image:
  mirror: false
  flip: false
  rotate: 0
  contrast: 50
  hue: 50
  saturation: 50
  luminance: 50
video0:
  enabled: true
  codec: h264
  fps: 15
  bitrate: 1024
  rcMode: avbr
  gopSize: 1.0
  gopMode: smart
  size: 1280x720
  sliceUnits: 0
video1:
  enabled: false
  codec: h264
  size: 704x576
  fps: 15
jpeg:
  enabled: true
  qfactor: 50
  fps: 5
osd:
  enabled: false
  font: "/usr/share/fonts/truetype/UbuntuMono-Regular.ttf"
  template: "%d.%m.%Y %H:%M:%S"
  posX: 16
  posY: 16
audio:
  enabled: false
  volume: 30
  srate: 8000
  codec: opus
  outputEnabled: false
  outputVolume: 30
rtsp:
  enabled: true
  port: 554
nightMode:
  colorToGray: true
  irCutSingleInvert: false
  lightMonitor: false
  lightSensorInvert: false
motionDetect:
  enabled: false
  visualize: false
  debug: false
records:
  enabled: false
  path: "/mnt/mmcblk0p1/%F/%H.mp4"
  maxUsage: 95
outgoing:
  enabled: false
watchdog:
  enabled: true
  timeout: 300
hls:
  enabled: false

for comparison, example majestic log from previous, working version:
root@openipc-garage:~# majestic
09:44:32  <       majestic> [    main] main@240                      Majestic Lite for HiSilicon, version master+4ea93cf, built on 2024-02-25
09:44:33  <       majestic> [watchdog] watchdog_start@91             Detected Hisilicon Watchdog
09:44:33  <       majestic> [watchdog] watchdog_start@111            Watchdog timeout set to 60 seconds
09:44:33  <       majestic> [   httpd] start_web_server@386          Set server path: /var/www
09:44:33  <       majestic> [   httpd] new_http_server@375           HTTP server started on :::80
09:44:33  <       majestic> [    main] init_sdk@66                   Loading main configuration: /etc/majestic.yaml
09:44:33  <       majestic> [     sdk] try_sensor_config@3378        SENSOR=ov9712
09:44:33  <       majestic> [     sdk] find_sensor_config@3345       matched sensor config: ov9712_i2c_dc_720p.ini
09:44:33  <       majestic> [     sdk] start_sdk@386                 Using /etc/sensors/ov9712_i2c_dc_720p.ini sensor configuration file
09:44:33  <       majestic> [     sdk] start_sdk@391                 App was built with MPP version: Hi3518_MPP_V1.0.B.0.
09:44:33  <       majestic> [     sdk] start_sdk@396                 Current MPP version: HI_VERSION=Hi3518_MPP_V1.0.B.0
09:44:33  <       majestic> [     sdk] start_sdk@424                 sensor ov9712
09:44:33  <       majestic> [     sdk] start_sdk@432                   dev [1280x720]@0x0 15fps, BGGR
09:44:33  <       majestic> [  sensor] try_to_load@19                trying to load /usr/lib/sensors/libsns_ov9712_i2c_dc.so
09:44:33  <       majestic> [     hal] hisi_free_mem_ex@752          Free MMZ mem before allocation: 19580KB
09:44:33  <       majestic> [     sdk] dump_vb_configuration@2258    VB configuration:
09:44:33  <       majestic> [     sdk] dump_vb_configuration@2261      [0]: 1413120 x 5
09:44:33  <       majestic> [     hal] hisi_free_mem_ex@752          Free MMZ mem after allocation: 12668KB
09:44:34  <       majestic> [     sdk] init_sensor@2453              Sensor driver loaded
09:44:34  <       majestic> [     sdk] log_venc_chn@1240             H.264 1280x720 15fps 1500Kbit  15 GOP
09:44:34  <     iq_monitor> [     sdk] monitor_thread@314            Loading IQ profile /etc/sensors/iq/default.ini
09:44:34  <       majestic> [     sdk] create_vpss_chn@984             new venc: 0   vpss_grp: 0,   vpss_chn: 0
09:44:34  <       majestic> [     sdk] start_video@2001                venc took 3400KB of MMZ [675]
09:44:34  <       majestic> [     osd] init_osd@97                   OSD initialized
09:44:34  <       majestic> [     sdk] start_sdk@509                   OSD took 176KB of MMZ
09:44:34  <       majestic> [     sdk] start_sdk@536                 HiSilicon SDK started
09:44:34  <       majestic> [     hal] hisi_free_mem_ex@752          Free MMZ mem finally: 4936KB
09:44:34  <       majestic> [    rtsp] rtsp_init@28                  RTSP server started on port 554
09:44:34  <       majestic> [   night] setup_gpio_listener@200       Starting monitor for light sensor
09:44:34  <       majestic> [   night] set_night_mode@115            Change mode to NIGHT
09:44:34  <       majestic> [    gpio] set_gpio@26                   set_gpio(76, 1)
09:44:34  <       majestic> [    gpio] set_gpio@26                   set_gpio(79, 0)
09:44:34  <       majestic> [    gpio] set_gpio@26                   set_gpio(73, 1)
09:44:34  <       majestic> [    gpio] set_gpio@26                   set_gpio(76, 0)
09:44:34  <       majestic> [    gpio] set_gpio@26                   set_gpio(79, 0)
09:44:34  <       majestic> [  client] RtspClient_before@402         RTSP OPTIONS rtsp://<IP_ADDRESS>/stream=0 CSeq=1 from <IP_ADDRESS>:61927
09:44:34  <       majestic> [  client] RtspClient_before@402         RTSP OPTIONS rtsp://<IP_ADDRESS>/stream=0 CSeq=2 from <IP_ADDRESS>:61927
09:44:34  <       majestic> [  client] RtspClient_before@402         RTSP DESCRIBE rtsp://<IP_ADDRESS>/stream=0 CSeq=3 from <IP_ADDRESS>:61927
09:44:34  <       majestic> [     nal] NalCodec_describe@126         RTSP chn 0 sps_len 0
09:44:34  <       majestic> [     nal] NalCodec_describe@129         RTSP chn 0 pps_len 0
09:44:34  <       majestic> [     nal] NalCodec_describe@137         RTSP chn 0 profile_level_id 000000
09:44:34  <       majestic> [  client] RtspClient_before@402         RTSP SETUP rtsp://<IP_ADDRESS>/stream=0/video CSeq=4 from <IP_ADDRESS>:61927
09:44:34  <       majestic> [  client] RtspClient_setup@313          TCP RTSP SETUP done, stream_id=0 from <IP_ADDRESS>:61927
09:44:34  <       majestic> [  client] RtspClient_before@402         RTSP PLAY rtsp://<IP_ADDRESS>/stream=0 CSeq=5 from <IP_ADDRESS>:61927
09:44:39  <       majestic> [     sdk] init_chn@1275                 JPEG snapshot snapshot venc_chn 1  1280x720
09:44:39  <       majestic> [     sdk] start_jpeg@1357                 jpeg_enc took 916KB of MMZ [900]
09:44:39  <       majestic> [    jpeg] sdk_take_jpeg@82              take jpeg venc_chn(1)   1280x720  q:50
09:44:39  <       majestic> [    jpeg] VENC_SaveJpeg@265             JPEG 15201 bytes received from hardware encoder
09:44:39  <       majestic> [  on_jpg] send_regular_jpeg@55          JPEG was sent to client

corresponding majestic.yaml:
root@openipc-garage:~# cat /etc/majestic.yaml
system:
  webAdmin: enabled
  buffer: 2048
image:
  mirror: false
  flip: false
  rotate: 0
  contrast: 40
  hue: 50
  saturation: 50
  luminance: 40
osd:
  enabled: true
  template: "%F %T"
  posX: -16
  posY: 16
nightMode:
  enabled: true
  nightAPI: false
  irSensorPin: 77
  backlightPin: 73
  irSensorPinInvert: false
  irCutPin1: 76
  irCutPin2: 79
  irCutSingleInvert: false
records:
  enabled: false
  path: /mnt/mmcblk0p1/%F/%H.mp4
  maxUsage: 95
video0:
  enabled: true
  bitrate: 1500
  fps: 15
  rcMode: avbr
video1:
  enabled: false
jpeg:
  enabled: true
mjpeg:
  size: 640x360
  fps: 5
  bitrate: 1024
audio:
  enabled: false
  volume: auto
  srate: 8000
  speakerPinInvert: false
  codec: alaw
  outputEnabled: false
rtsp:
  enabled: true
  port: 554
hls:
  enabled: true
youtube:
  enabled: false
motionDetect:
  enabled: false
  visualize: false
  debug: false
ipeye:
  enabled: false
watchdog:
  enabled: true
  timeout: 60
isp:
  blkCnt: 5
onvif:
  enabled: true

I can confirm this issue: Used to work, now it is broken.

Please provide the output of:
cat /dev/logmpp

this is logged when majestic starts
root@openipc-hi3518ev100:~# cat /dev/logmpp
<3>[    rc] [Func]:RcCheckAttr [Line]:416 [Info]:<3>[    rc] fixqp I set 0 error for out of [1,99]
<3>[    rc] [Func]:RC_CreateChn [Line]:2145 [Info]:<3>[    rc] chn 1 user attr err.
<3>[  venc] [Func]:VencCreateChn [Line]:1025 [Info]:<3>[  venc] rc create chn error

Please test this build: hi3516cv100-lite

For me that seems to fix it. Also the segmentation faults, that I have seen before after about 15 minutes of running, seem to be fixed.

working for me now with latest build - thanks for quick turnaround!


himitsu-firefox: mark as broken

Description of changes
himitsu-firefox now depends on : hare-json, which is not in nixpkgs. (See https://github.com/NixOS/nixpkgs/pull/231400)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

among other things, this PR packages the needed hare-json dependency to nixpkgs. no guarantees it'll work OOTB for himitsu-firefox, but i see that Alpine has both of these packages, and the hare-json over in that nixpkgs PR matches the version in Alpine, so it should be workable.


feat(eslint): adds eslint generator

What
Introduces Lob's own Yeoman  generator for creating Node modules.
The first subcommand of the generator is yo lob:eslint which does the following to your project:

generates our stock .eslintrc and .eslintignore files
adds eslint and eslint-config-lob to your project's dev dependencies.
adds the npm script "lint": "eslint ." to your package.json

In future iterations we can get fancy and prompt the user to configure the files to their exact liking.
For reference, here's Yeoman's guide to creating generators: http://yeoman.io/authoring/
Why
I've noticed that our wiki's New Repo Setup guide gets woefully out of date very quickly. Meanwhile we've been creating a lot of new repos lately, and doing it manually which is not fun and leads to a lot inconsistencies.
A custom Yeoman generator turns a stale wiki guide into a living useful thing, and in turn helps us keep our new repos up to date with our latest best practices.
This first command yo lob:eslint makes it really easy to move existing projects to the new linter. Eventually we can add enough commands that yo lob will scaffold an entire node module.
Usage
For this CR:
$ npm i -g yeoman
$ git clone git@github.com:lob/generator.git
$ cd generator
$ git checkout eslint
$ npm i
$ npm link
$ cd wherever
$ yo lob:eslint

Once this module is published, you can install globally for easier use.
Note
Name ideas for the repo/generator?

This is awesome! LGTM.

LGTM


Embedded Cluster Operator Addon

Adding an addon for the recently created chart https://github.com/replicatedhq/helmvm-operator/tree/main/charts/embedded-cluster-operator which deploys a configmap containing metadata about the helmvm install

This isn't quite working yet. Will request another review once i push a fix


API

From a design standpoint is it nicer to have an API that looks like:
universe.primitive_atoms

or
universe.get_primitive_atoms(inplace=True)
universe.primitive_atoms

In the former approach, primitive_atoms (dataframe) is a property that will be computed if it doesn't exist. In the latter it must first be explicitly computed before it can be accessed. Also, in the latter note that the default is to return the primitive_atoms rather than attach them to the universe.

if the property is only computed when called for, it seems simpler to have the former. However, if a table such as primitive atoms is something you would want to compute but not store (fast enough to just do on the fly), the flexibility of being able to not attach it to the universe would be useful. I suppose more flexibility is better and somewhat mimics the pandas API.

How about a mix? (and primitive_atoms is just an example here; any dataframe will behave this way)
universe.primitive_atoms

If the data doesn't exist it will call get_primitive_atoms with inplace=True. But get_primitive_atoms will still be available if the user wants to return the dataframe elsewhere.

Closing in favor of the mixed approach detailed above.


Cut, Copy, Paste and Clear

Introduced CanvasHelpers to provide calculations for the Canvas component
Added button stubs, but no functionality yet (coming soon in future PR)
Hot keys:

Ctrl + C -> Copy
Ctrl + X -> Cut
Ctrl + V -> Paste
Ctrl + A -> Select all
Ctrl + D -> Clear

Closing in favor of smaller PRs


 Accessed via Vagrant.
Steps to reproduce the issue:

Create a valid Dockerfile (in my case, for a node service). DO NOT consume the build-arg we will pass in next.
Build the docker image passing in an unused build-arg
docker build --build-arg VERSION=3.1.4 -t hello-error .

Describe the results you received:
Docker build fails with this error:
Step 11 : EXPOSE 80
---> Using cache
---> aed38f6ddf88
Step 12 : CMD npm start
---> Using cache
---> c33d33264d01
One or more build-args [VERSION] were not consumed, failing build.
Describe the results you expected:
Build should succeed.
Additional information you deem important (e.g. issue happens only occasionally):
I think it makes more sense for build-args to be optional. We have a CI build script that runs the docker build command. It's shared across our org. Not everyone needs the variable we pass in.

This is one of those philosophical issues.
Personally I see that having a flexible system is good, but it's also good to have precise builds.
If you provide a variable that goes unused then from the standpoint of reliable build results this is an error... ie, you gave us something that we couldn't use, so we are telling you about it so you can correct it.
What's nice here is the image does get built so if you re-run w/o the un-consumed argument it should just use the cache.

User DanielDent appears to be on my side of the philosophical divide, based on his comment here.
https://github.com/docker/docker/issues/14634

When writting script to build many images, where some may required the build arg in question and some don't, having this "build arg not consume" stop the script from being simple such as:
for all build step
docker build $BUILD_ARG ...
Because of this severe validation, one has to figure out which build require which variable and must sequentially build the docker image using the proper $BUILD_ARG.
Can you add an option to allow a developer to turn off the this validation?
This way everyone becomes happy and efficient in writing script can be restored.

We discussed this in the maintainers meeting, and we're ok with changing the error to just a warning, so anyone that wants to open a PR, it'll likely get accepted

If so, we should revisit the entire requirement to have ARG in there at all since a warning is about as good as ignoring it.  ARG serves no purpose but to cause extra steps for people - an implicit ARG for each build-arg specified on the command line should be sufficient.

If so, we should revisit the entire requirement to have ARG in there at all

No, this is the other way round; only args defined with ARG are consumed, but other args don't fail the build. Not requiring ARG would result in any environment variable to be set in the image during build, which is not the same

@thaJeztah Is there already an issue tracking an enhancement request for such a feature?

@mgomezch yes, this one :smile:

I meant this feature, though:

Not requiring ARG would result in any environment variable to be set in the image during build, which is not the same

It’d be nice to be able to specify build environment variables using --build-arg for variables not specified in the Dockerfile, and have them consumed and applied to the environment made available to commands in RUN instructions during the build.  My use case would be the same as that specified in the aforementioned comment in #14634.  Indeed this would be useful to access cached resources during builds in CI infrastructure for build systems that don’t use the “standard” variables that have been included in BuiltinAllowedBuildArgs.
I understand this issue as specific to the feature of yielding only a warning, not a build failure, if the build command is provided a --build-arg option that does not match an ARG instruction in the built Dockerfile, but this issue falls short of requesting that such --build-arg options produce environment variables available to RUN instruction commands.  Or does this issue cover both features?

@mgomezch probably best to open a new issue / feature request for that

#dibs


Input 0 of layer max_pooling2d is incompatible with the layer: expected ndim=4, found ndim=5. Full shape received: (None, None, None, None, 16)

my generator codde is:
IMG_HEIGHT=256
IMG_WIDTH=256
MASK_HEIGHT=256
MASK_WIDTH=256
IMG_CHANNELS=3
generator fxn
def Generator(X_list, y_list, batch_size = 4):
c = 0
while(True):
    X = np.empty((batch_size, IMG_HEIGHT, IMG_WIDTH,IMG_CHANNELS), dtype = 'float32')
    y = np.empty((batch_size, MASK_HEIGHT, MASK_WIDTH,1), dtype = 'float32')

    for i in range(c,c+batch_size):
        image = X_list[i]

        mask =  y_list[i]

    X = X[:,:,:,np.newaxis] / 255   # normalization
    y = y[:,:,:,np.newaxis] / 255   # normalization

    c += batch_size
    if(c+batch_size >= len(X_list)):
        c = 0
    yield X, y

and model code is:
#Build the model
inputs = tf.keras.layers.Input((IMG_HEIGHT, IMG_WIDTH, IMG_CHANNELS))
s = tf.keras.layers.Lambda(lambda x: x / 255)(inputs)
#Contraction path
c1 = tf.keras.layers.Conv2D(16, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(s)
c1 = tf.keras.layers.Dropout(0.1)(c1)
c1 = tf.keras.layers.Conv2D(16, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c1)
p1 = tf.keras.layers.MaxPooling2D((2, 2))(c1)
c2 = tf.keras.layers.Conv2D(32, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(p1)
c2 = tf.keras.layers.Dropout(0.1)(c2)
c2 = tf.keras.layers.Conv2D(32, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c2)
p2 = tf.keras.layers.MaxPooling2D((2, 2))(c2)
c3 = tf.keras.layers.Conv2D(64, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(p2)
c3 = tf.keras.layers.Dropout(0.2)(c3)
c3 = tf.keras.layers.Conv2D(64, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c3)
p3 = tf.keras.layers.MaxPooling2D((2, 2))(c3)
c4 = tf.keras.layers.Conv2D(128, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(p3)
c4 = tf.keras.layers.Dropout(0.2)(c4)
c4 = tf.keras.layers.Conv2D(128, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c4)
p4 = tf.keras.layers.MaxPooling2D(pool_size=(2, 2))(c4)
c5 = tf.keras.layers.Conv2D(256, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(p4)
c5 = tf.keras.layers.Dropout(0.3)(c5)
c5 = tf.keras.layers.Conv2D(256, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c5)
#Expansive path
u6 = tf.keras.layers.Conv2DTranspose(128, (2, 2), strides=(2, 2), padding='same')(c5)
u6 = tf.keras.layers.concatenate([u6, c4])
c6 = tf.keras.layers.Conv2D(128, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(u6)
c6 = tf.keras.layers.Dropout(0.2)(c6)
c6 = tf.keras.layers.Conv2D(128, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c6)
u7 = tf.keras.layers.Conv2DTranspose(64, (2, 2), strides=(2, 2), padding='same')(c6)
u7 = tf.keras.layers.concatenate([u7, c3])
c7 = tf.keras.layers.Conv2D(64, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(u7)
c7 = tf.keras.layers.Dropout(0.2)(c7)
c7 = tf.keras.layers.Conv2D(64, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c7)
u8 = tf.keras.layers.Conv2DTranspose(32, (2, 2), strides=(2, 2), padding='same')(c7)
u8 = tf.keras.layers.concatenate([u8, c2])
c8 = tf.keras.layers.Conv2D(32, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(u8)
c8 = tf.keras.layers.Dropout(0.1)(c8)
c8 = tf.keras.layers.Conv2D(32, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c8)
u9 = tf.keras.layers.Conv2DTranspose(16, (2, 2), strides=(2, 2), padding='same')(c8)
u9 = tf.keras.layers.concatenate([u9, c1], axis=3)
c9 = tf.keras.layers.Conv2D(16, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(u9)
c9 = tf.keras.layers.Dropout(0.1)(c9)
c9 = tf.keras.layers.Conv2D(16, (3, 3), activation='relu', kernel_initializer='he_normal', padding='same')(c9)
outputs = tf.keras.layers.Conv2D(1, (1, 1), activation='softmax')(c9)
when i am trying to train this model using:
results1 = model.fit(train_gen, steps_per_epoch=steps_per_epoch, epochs = epochs,
validation_data = val_gen, validation_steps = validation_steps,callbacks=[checkpoint1], verbose=2)
i am getting this error:
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/training.py:805 train_function  *
return step_function(self, iterator)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/training.py:795 step_function  **
outputs = model.distribute_strategy.run(run_step, args=(data,))
/usr/local/lib/python3.7/dist-packages/tensorflow/python/distribute/distribute_lib.py:1259 run
return self._extended.call_for_each_replica(fn, args=args, kwargs=kwargs)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/distribute/distribute_lib.py:2730 call_for_each_replica
return self._call_for_each_replica(fn, args, kwargs)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/distribute/distribute_lib.py:3417 _call_for_each_replica
return fn(*args, **kwargs)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/training.py:788 run_step  **
outputs = model.train_step(data)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/training.py:754 train_step
y_pred = self(x, training=True)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/base_layer.py:1012 call
outputs = call_fn(inputs, *args, **kwargs)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/functional.py:425 call
inputs, training=training, mask=mask)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/functional.py:560 _run_internal_graph
outputs = node.layer(*args, **kwargs)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/base_layer.py:998 call
input_spec.assert_input_compatibility(self.input_spec, inputs, self.name)
/usr/local/lib/python3.7/dist-packages/tensorflow/python/keras/engine/input_spec.py:223 assert_input_compatibility
str(tuple(shape)))
ValueError: Input 0 of layer max_pooling2d is incompatible with the layer: expected ndim=4, found ndim=5. Full shape received: (None, None, None, None, 16)

how to resolve this issue?

@vjamishi
I  reproduced the code shared but facing a different error .Could you please share the colab gist with all the dependencies to analyze the issue reported here and also Please specify the tensorflow version used.Thanks

@vjamishi
I don't  understand your Generator function but I think you have to replace
 X = X[:,:,:,np.newaxis] / 255   # normalization
 y = y[:,:,:,np.newaxis] / 255   # normalization

with
 X = X / 255   # normalization
 y = y/ 255   # normalization

Explanation: np.newaxis creates a new axis increasing the tensors n_dim from 4 to 5 which leads to an error as max_pooling2d expects a shape of 4 dims (batchsize, image_height, image_width, n_channels)

@vjamishi
I don't understand your Generator function but I think you have to replace
 X = X[:,:,:,np.newaxis] / 255   # normalization
 y = y[:,:,:,np.newaxis] / 255   # normalization

with
 X = X / 255   # normalization
 y = y/ 255   # normalization

Explanation: np.newaxis creates a new axis increasing the tensors n_dim from 4 to 5 which leads to an error as max_pooling2d expects a shape of 4 dims (batchsize, image_height, image_width, n_channels)

Thanks for the suggestion it worked for me


Fork with additional features

Hi all, just letting you know that I've done some work on a fork to add additional features.
So far I've:

Added MVC structure
Moved routes to config/routes.js
Added Webpack & Gulp asset pipeline
Added Pjax
Added CORS support

Please let me know what you think, or if you have any requests - I've more features on the way.
https://github.com/niallobrien/briskjs

Thanks for sharing @niallobrien, but this is not the right place for it. I would like to keep it as a place for bugs and issues with the project.
I am glad however to see the project still going strong and people still fork it to make their own custom project boilerplate.


WIP:Better dependency management (poetry)#12

I got an error while running poetry install
movie-surfer/movie_surfer does not contain any element


renderTarget: tab no longer works

Describe the bug
Usage with tab rendering no longer works in the demo here.
I suspect this is caused by this PR. I think the tab addons does not support function titles.
How to reproduce the bug?

Navigate to tab demo here.
Observe that design tab does not render.

Expected behaviour
Design tab should render
Affected versions
6.1.0
Storybook versions
6.4.9

Thank you for reporting. I released<EMAIL_ADDRESS>which includes a patch for the bug.

Thank you!

Slow

Hello this seems broken again in the latest version. We had to revert to v6.2.1 where it seems to work just fine.

Would you mind opening a new ticket?


Cannot trace error using 'ceedling test:all --trace'

Hello,
I have an issue with a test where all compilation seems ok, however the process seems to fall over at the linker stage, I have tried using the --trace option but it doesn't show any further information;
ceedling test:all --trace
Test 'test_eng_display.c'
Generating runner for test_eng_display.c...
Compiling test_eng_display_runner.c...
Compiling test_eng_display.c...
Compiling unity.c...
Compiling eng_display.c...
Compiling cmock.c...
rake aborted!
TypeError: no implicit conversion of nil into String
C:/Ruby30-x64/bin/ceedling:25:in load' C:/Ruby30-x64/bin/ceedling:25:in '
Tasks: TOP => ceedling/build/test/results/test_eng_display.pass => ceedling/build/test/out/test_eng_display.exe
(See full trace by running task with --trace)

OVERALL TEST SUMMARY
No tests executed.

Use ceedling verbosity[4] test:all

Thanks but I’ve tried this and also;
ceedling debug test:all
But these still do not show any detail as to why rake exits.
On Tue, 5 Apr 2022 at 21:21, Crt Mori @.***> wrote:

Use ceedling verbosity[4] test:all
—
Reply to this email directly, view it on GitHub
https://github.com/ThrowTheSwitch/Ceedling/issues/672#issuecomment-1089292419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIUTU6S4KGLTHVB635OPF3TVDSOETANCNFSM5SSKBGAQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I strongly suspect it's a configuration problem with the custom tools, but I haven't figure it out yet.

Hi,
I believe it is a problem with the tool chain. I’m using msys2 mingw64.
However for some reason the errors created by gcc are not displayed. I can
see that it is not compiling all of the dependencies. I don’t understand
why at the moment. I don’t see where the linker command is executed but if
I makeup the command line manually using the compiled object files it is
missing various other symbols etc.
On Tue, 5 Apr 2022 at 22:14, Mark VanderVoord @.***>
wrote:

I strongly suspect it's a configuration problem with the custom tools, but
I haven't figure it out yet.
—
Reply to this email directly, view it on GitHub
https://github.com/ThrowTheSwitch/Ceedling/issues/672#issuecomment-1089358546,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIUTU6QLJUDW43HBEFAWMN3VDSUKHANCNFSM5SSKBGAQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


[SPARK-23736][SQL][FOLLOWUP] Error message should contains SQL types

What changes were proposed in this pull request?
In the error messages we should return the SQL types (like string rather than the internal types like StringType).
How was this patch tested?
added UT

Test build #89927 has started for PR 21181 at commit 5660de8.

It makes sense. Thanks!

Test build #89927 has finished for PR 21181 at commit 5660de8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89927/
Test PASSed.

Merged build finished. Test PASSed.

Merged to master.


[SPARK-30696][SQL] fromUTCtime and toUTCtime produced wrong result on Daylight Saving Time changes days

What changes were proposed in this pull request?
Before this patch, fromUTCtime and toUTCtime produced wrong result on Daylight Saving Time changes days
For example, in LA in 1960, timezone switch from UTC-7h to UTC-8h at 2AM in 1960-09-25 but previous version have the cutoff at 8AM
Why are the changes needed?
correctness
Does this PR introduce any user-facing change?
yes, as correct the result produced by those two functions
How was this patch tested?
Add test

Can one of the admins verify this patch?

@dgd-contributor, please take a look at https://github.com/apache/spark/pull/32666/checks?check_run_id=2671403546 and enable Github actions for your forked repository.

Can anyone review this?

@cloud-fan could you review it?

@MaxGekk should probably be one of the best persons to review.


Plugin crashes runelite when entering Priff

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
I think this probably has to do with my computer configuration. When I teleport to Priff, the game crashes. When I try to sign back in, it still does not work, if I toggle this plugin off then sign in, it works fine, but I can't turn the plugin back on.
If it helps, I had been experiencing this for a long time with the GPU plugin as well, but that's been more rare as of late, and it was inconsistent anyway.
To Reproduce
Steps to reproduce the behavior:

Teleport to Priff
Runelite freezes and you have to kill it

Expected behavior
I teleport to Priff and it does not freeze
Environment (please complete the following information):

Windows 10
RuneLite version: 1.7.24
Launcher version: 2.1.7
GPU: RTX 2070 Super
Shadow Play disabled
Driver is up-to-date
Processor: 9900k
I launch via command line because otherwise I have artifacting happen in runelite (I have a comment in this thread: https://github.com/runelite/runelite/issues/11727#issuecomment-858176618), and it could be related
32GB of RAM. I see it looks like an out of memory exception, but not seeing memory issues in my task manager, maybe video memory
3x27" Monitors 1440p@60hz, gsync enabled, full screen layout (obviously only play on one monitor)

Additional context
Logs associated with crash:

2021-09-13 16:06:30 [main] INFO  net.runelite.client.RuneLite - RuneLite 1.7.24 (launcher version 2.1.7) starting up, args: none
2021-09-13 16:06:31 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached vanilla client
2021-09-13 16:06:32 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached patched client
2021-09-13 16:06:32 [Preloader] INFO  net.runelite.client.rs.ClientLoader - client-patch<PHONE_NUMBER>.255
2021-09-13 16:06:36 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,538,240,1484x931,layout=java.awt.BorderLayout,title=RuneLite,resizable,normal,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,1484x931,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@11f9b20,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
2021-09-13 16:06:58 [Client] ERROR net.runelite.client.RuneLite - Uncaught exception:
java.lang.OutOfMemoryError: null
at java.base/jdk.internal.misc.Unsafe.allocateMemory(Unknown Source)
at java.base/java.nio.DirectByteBuffer.(Unknown Source)
at java.base/java.nio.ByteBuffer.allocateDirect(Unknown Source)
at rs117.hd.GpuFloatBuffer.allocateDirect(GpuFloatBuffer.java:76)
at rs117.hd.GpuFloatBuffer.ensureCapacity(GpuFloatBuffer.java:62)
at rs117.hd.SceneUploader.pushFace(SceneUploader.java:1203)
at rs117.hd.SceneUploader.uploadModel(SceneUploader.java:136)
at rs117.hd.SceneUploader.upload(SceneUploader.java:234)
at rs117.hd.SceneUploader.upload(SceneUploader.java:94)
at rs117.hd.HdPlugin.uploadScene(HdPlugin.java:1983)
at rs117.hd.HdPlugin.invokeOnMainThread(HdPlugin.java:2363)
at rs117.hd.HdPlugin.onGameStateChanged(HdPlugin.java:1972)
at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
at net.runelite.client.eventbus.EventBus.post(EventBus.java:223)
at net.runelite.client.callback.Hooks.post(Hooks.java:169)
at client.yf(client.java:19313)
at cc.ed(cc.java:2053)
at client.i(client.java:1868)
at at.jr(at.java:380)
at at.run(at.java:359)
at java.base/java.lang.Thread.run(Unknown Source)

It's still very early in testing, but this appears to be fixed by the answer given here: https://github.com/runelite/runelite/issues/11727#issuecomment-916476018
I'm not sure if this can be fixed in the HD plugin as well or not, and I'll update if I have more crashes. But hopefully somebody else may find this helpful in the future if it works for me

Closing since you seem to have resolved this :)


Dropdown aria-label broken

Describe the bug
The aria-label attribute is straight up broken.
To Reproduce
Steps to reproduce the behavior:
Use the <RadzenDropDown /> component. Even the demo has the issue.
Alternatively link your repo with a sample project that can be run.
Expected behavior
I'm assuming the value of aria-label was intended to be the TextProperty value of the option.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: MacOS
Browser Safari & Chromium
Version Safari 14.5 & Edge 104.0.1293.47

I don't believe this is fixed. I am still encountering the problem.


docs: remove comma

What this PR does / why we need it:
Remove comma

please fix latest and v1.1 then run make -k gen-check

@muffl0n can you also fix  the same issue in site/content/en/latest/tasks/quickstart.md & site/content/en/v1.1/tasks/quickstart.md

Sure thing!


Make Transformer tolerate missing layers for PP

Stack from ghstack (oldest at bottom):

#318
-> #322
#321

A few small changes here lets manual PP frontend 'reconfigure' a whole
transformer model to a stage's portion simply by setting undesired
layers to None (in cases of top level layers) or deleting them from the
ModuleDict (for 'layers.*').
These changes don't impact the FQNs of the remaining layers, which is
critical for checkpoint load/save compatibility.

Nice. But it is less intuitive than I originally thought. Especially the int/str conversion part. Not sure if that's a best UX for pippy or a customized PipelineModuleList will be easier for users.

One downside to using ModuleDict is that now the model print does not collapse TransformerBlocks together, making the model print very long.


Add Rent sysvar type

Added Rent sysvar, still missing some implementations like default, calculate burn...

Looking good, I think you are currently missing adding the module declaration to sysvars/mod.rs

Oh I thought I added that. i was rushing out as communicated


Remove "Add support for prepared statements" from the Readme

Prepared statement support seems to have been added, if so this should be removed from the todo list.

Nvm, it seems to be only partially implemented

I'm trying to use a prepared statement but seems I'm doing something wrong.
Also I've noticed that a prepared-statement expects: Query(args []driver.Value)
But sql drivers expects Query(args ...interface{})
This is a problem when trying to stub code.
Is there any example I can use as reference?


fix(connected-position-strategy): multiple places to specify direction

Currently, if the consumer wants to handle layout direction in a connected overlay, they have to specify it in two places: via the OverlayState.direction and the ConnectedPositionStrategy.withDirection. This can be confusing and easy to overlook. These changes remove the ConnectedPositionStrategy.withDirection method, in favor of passing in the overlay state direction.
Makes a few underscored properties private since they weren't being used anywhere outside of the ConnectedPositionStrategy class.

BREAKING CHANGE: This will be a breaking change if somebody was using the withDirection method and the way to fix it is to only pass the direction to the OverlayState. If we want to be safer about it, I can put the method back in and mark it as deprecated.

@crisbeto do you want to leave this as-is (avoiding the breaking change) and address it with the new position strategy?

I'm fine with addressing it in the new positioning, we haven't had any reports about this one, it was just something I noticed.


Issue: Add new metadata to document_ids already saved in vectorstore (FAISS)

Issue you'd like to raise.
Hi. I've a vectorstore which has embeddings from chunks of documents. I've used FAISS to create my vector_db.  As metadata I've 'document_id', 'chunk_id', 'source'.
But now I want to run a summarizer to extract a summary for each document_id and put it as a new metadata for each chunk.
How can I do it?
The only way I've found out was to process everything all over again, but now extracting the summary as a new step from the pipeline...but that's not ideal....
Suggestion:
No response

Thank you. That was the attribute I was searching for, docstore. I can explore FAISS with index, docstore, and index_to_docstore_id. Docstore has update (vectordb.docstore.update). I didn't try it yet, but it's a very good start.


Media Gallery for Configurable Childrens

It adds media_gallery for configurable children. So when we fetch configurable with childs, we have direct access to Childs' images.
Based on reVLis's solution sent on VSF Slack. His version was not compatible with the newest  indexer.

Thanks for PR, I won't be merging changes.
We will be working on more flexible solution in #105


ci: dynamic CI demo

discussion in: #87
this is a demo, don't merge

Close this due to unstable CI


add rgba and hsla

address https://github.com/davidmerfield/randomColor/issues/18
what is this?
We wanted to have alpha values. Here is the asked for rgba. Double bonus! :sparkles: also added hsla
how to test
does setting the format return rgba and hsla correctly?
// Returns a dark RGB color with random alpha
randomColor({
   luminosity: 'dark',
   format: 'rgba' // e.g. 'rgba(9, 1, 107, 0.6482447960879654)'
});

// Returns a light HSL color with random alpha
randomColor({
   luminosity: 'light',
   format: 'hsla' // e.g. 'hsla(27, 88.99%, 81.83%, 0.6450211517512798)'
});

Thanks Riley!


pass testdocs

$-.test-fail “() +“2” -()”;“{"total":33,"pass":11,"fail":22}”;
$-.test-fail “() +“7” -()”;“{"total":13,"pass":7,"fail":6}”;
$-.test-fail “() +“[.head 0b101; .tail 0b01100;]” -()”;“{"total":38,"pass":11,"fail":27}”;
$-.test-fail “() +“{0b1 0b0}” -()”;“{"total":21,"pass":10,"fail":11}”;
$-.test-fail ““#  inline comment # 4321” +() -“1234””;“{"total":6,"pass":5,"fail":1}”;
$-.test-fail ““.Bit <0b0, 0b1>;” +() -“(Bit)””;“{"total":19,"pass":10,"fail":9}”;
$-.test-fail ““.BitStream <[@Bit]>; # Variable-length Sequence of a specific type” +() -“(enum123)””;“{"total":30,"pass":11,"fail":19}”;
$-.test-fail ““.Byte <8@Bit>; # Fixed-length sequences” +() -“(Byte)””;“{"total":31,"pass":11,"fail":20}”;
$-.test-fail ““.false ()” +() -“false””;“{"total":24,"pass":11,"fail":13}”;
$-.test-fail ““.the-answer 42;” +() -“(the-answer)””;“{"total":9,"pass":6,"fail":3}”;
$-.test-fail ““.true <>” +() -“true””;“{"total":25,"pass":11,"fail":14}”;
$-.test-fail ““<.x, .z> [.x 1; .y 2; .z 3;] # Selector” +“[1, 3]” -“<x, z, [(x); (y); (z);]>””;“{"total":36,"pass":11,"fail":25}”;
$-.test-fail ““@enum123 4” +“$@enum123<1,2,3> 4” -“enum123””;“{"total":35,"pass":11,"fail":24}”;
$-.test-fail ““AppendZero” +() -“(AppendZero)””;“{"total":20,"pass":10,"fail":10}”;
$-.test-fail ““BitSplitter3 0b10101100” +() -“(BitSplitter3)””;“{"total":37,"pass":11,"fail":26}”;
$-.test-fail ““[.a 1; .b 2;].a” +“1” -“$!.name-missing “$:FrameArray.1164.a”;””;“{"total":23,"pass":11,"fail":12}”;
$-.test-fail ““[0b101, 0b010] .& AppendZero” +“[0b1010, 0b0100]” -“[0b1000, 0b1000]””;“{"total":28,"pass":11,"fail":17}”;
$-.test-fail ““[0b101, 0b010] .| AppendZero” +“0b10100100” -“0b10000010””;“{"total":29,"pass":11,"fail":18}”;
$-.test-fail ““`Expression1`,`Expression2`” +“`Expression1`,`Expression2`” -“(`Expression1`, `Expression2`)””;“{"total":15,"pass":8,"fail":7}”;
$-.test-fail ““`Hello`` World`” +“`Hello World`” -““Hello World”””;“{"total":8,"pass":6,"fail":2}”;
$-.test-fail ““`Statement`;” +() -“(`Statement`)””;“{"total":16,"pass":8,"fail":8}”;
$-.test-fail ““enum123.<>” +“<1,2,3>” -“$!.name-missing “$:FrameNumber.1652.”; .++ [<>];””;“{"total":34,"pass":11,"fail":23}”;
$-.test-fail ““enum123” +() -“(enum123)””;“{"total":32,"pass":11,"fail":21}”;
$-.test-fail ““false .? `Yes` .: `No`” +“`No`” -“$!.name-missing “$:HCTest.117.false”; .++ [?, `Yes`, :, `No`];””;“{"total":27,"pass":11,"fail":16}”;
$-.test-fail ““the-answer” +() -“(the-answer)””;“{"total":12,"pass":7,"fail":5}”;
$-.test-fail ““ther-answer” +“$ther-answer” -“$!.name-missing “$:HCTest.117.ther-answer”;””;“{"total":11,"pass":7,"fail":4}”;
$-.test-fail ““true .? `Yes` .: `No`” +“`Yes`” -“()””;“{"total":26,"pass":11,"fail":15}”;

ALSO: why does "-t" have to be at the end?
Is this the right benchmark?
Should we be doing urbit first?

node lib/src/cli/hc.js hc/hc-paper-enp.hc -t
$-.test-fail “() +“Language Definition” -()”;“{"total":1,"pass":0,"fail":1}”;
$-.test-fail ““frame0” +“value0” -“$!.name-missing “$:HCTest.115.frame0”;””;“{"total":2,"pass":0,"fail":2}”;
$+.test-pass “““Hello, Quine!”” +““Hello, Quine!”””;“{"total":3,"pass":1,"fail":2}”;
$+.test-pass “““Hello, ” “Homoiconicity!”” +““Hello, Homoiconicity!”””;“{"total":4,"pass":2,"fail":2}”;
$+.test-pass “““The Answer” “: ” 42” +““The Answer: 42”””;“{"total":5,"pass":3,"fail":2}”;
$-.test-fail ““2 “Repeats”” +““RepeatsRepeats”” -““Repeats”””;“{"total":6,"pass":3,"fail":3}”;
$-.test-fail “““Self Expression”,” +() -“(“My Statement”)””;“{"total":7,"pass":3,"fail":4}”;
$-.test-fail “() +““Self Expression”” -()”;“{"total":8,"pass":3,"fail":5}”;
$+.test-pass “““Want ” 2 “Live” # evaluates left to right” +““Want 2Live”””;“{"total":9,"pass":4,"fail":5}”;
$-.test-fail “““Want ” 2“Live” # evaluates 2“Live” first” +““Want LiveLive”” -““Want 2Live”””;“{"total":10,"pass":4,"fail":6}”;
$-.test-fail “““Want ” (2 “Live”) # evaluates grouped expressions first” +““Want LiveLive”” -““Want Live”””;“{"total":11,"pass":4,"fail":7}”;
$+.test-pass ““[1, 1, 2, 3, 5] 8” +“[1, 1, 2, 3, 5, 8]””;“{"total":12,"pass":5,"fail":7}”;
$-.test-fail ““{42; “Life, ” “The Universe, ” “Everything.”} ()” +““Life, The Universe, Everything.”” -“(42)””;“{"total":13,"pass":5,"fail":8}”;
$-.test-fail ““{} [“Life, ” “The Universe, ” “Everything.”]” +“{ “Life, ” “The Universe, ” “Everything.” }” -“(“Life, The Universe, Everything.”)””;“{"total":14,"pass":5,"fail":9}”;
LexPipe.perform.pop.failed: already at top level
$-.test-fail ““mag []” +“25” -()”;“{"total":15,"pass":5,"fail":10}”;


Reduce docker image size

WHAT
Reduce docker image size using debian:jessie for base image.

before: 803.4 MB
after: 151.6 MB

WHY
To shorten the time to notify with docker box

wow.. Thats a huge decrease


support cockroachdb + yugabytedb as additional engine support

Is your feature request related to a problem? Please describe.
This is a feature.
Postgres is a great database, however it's a SPOF.  Both cockroachdb and yugabyte are solutions for this issue.
Unfortunately neither support xid8 type.
I do see that SpiceDB (to support cockroachdb) uses a normal timestamp to sidestep this issue.
Describe the solution you'd like
Would be awesome if both cockroachdb and yugabyte are supported to give others options.  Looking at the migration files, once one is completed.  It's a copy and paste for the other.
Additional context
Would the work entail?

Creating a new folder in the internal / storage directory with migrations tailored for another database.
Changing migration.go to support the other engines.
Changing the database interactivity insert/update/delete to support the other engines?

I suspect it could be a minimal change, due to both databases mimic a postgres connection?
Thanks!

I had a bit of free time yesterday to finalise this for myself.  I now have Yugabyte working with permify.
https://github.com/paulm17/permify
I've added [yugabyte] as a new engine and have found the relevant functions and types for version 11.  Hopefully this won't cause any unnecessary conflicts or issues.
Eventually Yugabyte will upgrade to 15: https://github.com/yugabyte/yugabyte-db/issues/9797


TypeError from getRegistrantByEmail

From \DalPraS\OAuth2\Client\Resources\Registrant
If getRegistrantByEmail has no result, it returns null. This results in a TypeError since the function is typed to return an array.

thanks, now fixed

Thank you!


python312Packages.langchain-community: 0.0.33 -> 0.0.34, python312Packages.anthropic: 0.19.1 -> 0.25.6, python312Packages.langsmith: 0.1.48 -> 0.1.51, python312Packages.instructor: 0.6.8 -> 1.2.3

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 307684 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

32 packages built:

pentestgpt
pentestgpt.dist
python311Packages.anthropic
python311Packages.anthropic.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python312Packages.anthropic
python312Packages.anthropic.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
shell-gpt
shell-gpt.dist


Adding installation instructions

Adds installation instructions, since the Adafruit_Python_DHT dependency now
(unfortunately) causes our installation to be kind of complicated.

This change is

Coverage remained the same at 79.71% when pulling 9147c2ddf9a1edffa09ffd0a29865f7c15e40d8d on mtlynch:install-instructions into<PHONE_NUMBER>796696cfbe4070369dce31719cde10 on JeetShetty:master.

Coverage remained the same at 79.71% when pulling 9147c2ddf9a1edffa09ffd0a29865f7c15e40d8d on mtlynch:install-instructions into<PHONE_NUMBER>796696cfbe4070369dce31719cde10 on JeetShetty:master.


@see tag not clickable in hover window

VS Code Version: 1.54.2
OS Version: macOS 11.2.3

Steps to Reproduce:

Define a valid @see tag

Notice it working in the source code

Notice it not working in the tooltip

Duplicate of https://github.com/microsoft/TypeScript/issues/35524


Update credits in README

Add contributing section
Use new "About thoughtbot" section

I don't think we need to specify copyright as a range.


Clean up the Context class

Remove the context manager and the mock context in favor of a concrete class.

Context manager fixed in #662. The removal of the mock context manager will have to wait until after jupyter/jupyter-js-services#190.

I don't think this is a 0.9 issue, as it only affects the test suite, moving to 1.0, feel free to revert if you disagree.


Ensure global config is valid before creating network

When global config (espeically fwd mode) is not set, we shouldn't
allow creating network. The network created at that moment is may
not having enough data to proceed.
Signed-off-by: Wei Tie<EMAIL_ADDRESS>

build PR

build PR

build PR

build PR

build PR

build PR

@g1rana @rchirakk @srampal: Can one of you take a look as well, please?

squashed

build PR

👍


[Bug]: C compilation breaks when using gcc 12

What happened?
I'm working on integrating support for gcc 12.2.0. I added the relevant entries to _TOOLCHAINS in toolchain/defs.bzl and built an updated sysroot, also updating _SYSROOTS in the same file to point to my local archive. Things work mostly as expected, however, there is one issue when compiling a C source file that includes stdatomic.h. Since gcc 12.2.0 adds (some) support for C++23, there is a file stdatomic.h as part of the C++ headers. Since all directories are added to the gcc call via -isystem, a C-only built finds that header as well, and due to the preprocessor guards in there it does nothing. Digging a bit further and asking on the libstdc++ mailinglist, I found out that a C compilation is not supposed to see that header in the first place. When using only --sysroot and dropping the -nostdinc and -isystem arguments, gcc actually does the right thing. So it looks like the natural fix for this is to do exactly that: use --sysroot and drop the -nostdinc and -isystem arguments. Unfortunately, it's not entirely straightforward, because gcc uses stddef.h and stdarg.h from the toolchain archive and then those paths are made absolute ones in the .d file, making Bazel complain about undeclared includes.
The easiest workaround is patching the C++23 stdatomic.h, so it does #include_next when included from C code. However, it looks like the better solution here is to properly use --sysroot. I'm not sure why gcc makes some paths absolute in the .d file, but I can imagine that using a single archive with compiler and sysroot would make things much easier.
Why do you have the custom sysroot and explicitly remove the one from the Bootlin toolchain? Also, when you build gcc yourself as part of the sysroot, why do you even use the Bootlin toolchain?
Version
Development (host) and target OS/architectures:
Output of bazel --version:
bazel 5.3.1
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
patched main
Language(s) and/or frameworks involved:
C, C++
How to reproduce
I can put up an example to repro. But understanding the rationale behind the custom sysroot would be very helpful as a start.

Any other information?
No response
Fund our work

[ ] Sponsor our open source work by donating a bug bounty

I have made some progress here. We need to use the absolute path with --sysroot for the linker to find all required files. That is probably the reason why the wrapper script makes the path absolute. Using -isysroot additionally with a relative path we can make some paths in main.d relative, so Bazel is happy. However, it looks like some more -isystem is still required to make gcc output only relative paths.
Splitting the C and C++ includes is probably the way to go. I ended up with a hard-coding most things now. A generic solution could look like this:

Change includes() from sysroot/flags.bzl to support two lists: one for C only, another one for C++. Could also make sense to have to separate functions here.
Split cc_toolchain_config's includes into c_includes and cxx_includes. When invoking cc_toolchain_config(), pass the results from functions edited in the previous step.
Instead of using a single include_feature, split it into two, one for C only (with C compile actions), one for C++ (with C++ compile actions).

I'm still unsure why you use a custom sysroot. My guess is that you don't like the glibc that comes with the default Buildroot ones. But I understand now that this part is separate from the issue with gcc 12.

Hi @ahans, thanks for the detailed report! You are right that we have a separate sysroot because of glibc. There's some thought behind it that I put here: https://blog.aspect.dev/hermetic-c-toolchain. The major goal is to produce binaries that are linked against old symbols in order to make them more portable.
We have this mix of sysroot and bootlin compilers because of historical reasons. We initially used bootlin only to avoid the trouble of using a custom-built solution. It helped up to a certain extent. I don't think the current state of this repository is the final state I envision. To also support macOS (https://github.com/aspect-build/gcc-toolchain/issues/93), we will have to dump the bootlin toolchains in any case.
Having said that, I'd be open to take a patch for what you described, but eventually we will ditch bootlin, so not sure if it's worth your time.

The reason you saw those errors was due to the gcc version mismatch. You need to update this line and recreate the sysroot to match your GCC version.


Add prometheus HTTP server metrics

This is most of the work of #OBS-49, what's missing is http_server_request_size_bytes and http_server_response_size_bytes histograms which will come in its own PR.
💸 TL;DR
This adds HTTP server metrics for Prometheus.
📜 Details
Goals are detailed in https://github.snooguts.net/reddit/baseplate.spec/blob/master/component-apis/prom-metrics.md
🧪 Testing Steps / Validation

To manually test create a pyramid endpoint with a route, e.g configurator.add_route("hello_world", "hellworld/{world}/edit", request_method="GET").
Expected output on :6060/metrics:
# HELP http_server_active_requests Multiprocess metric
# TYPE http_server_active_requests gauge
http_server_active_requests{http_endpoint="/",http_method="GET",pid="83477"} 0.0
[snip snip snip]
/edit",http_method="GET",http_success="true",le="2.384185791015625"} 2.0
http_server_latency_seconds_bucket{http_endpoint="hellworld/{world}/edit",http_method="GET",http_success="true",le="5.9604644775390625"} 2.0
http_server_latency_seconds_bucket{http_endpoint="hellworld/{world}/edit",http_method="GET",http_success="true",le="14.901161193847656"} 2.0
http_server_latency_seconds_bucket{http_endpoint="hellworld/{world}/edit",http_method="GET",http_success="true",le="+Inf"} 2.0
http_server_latency_seconds_count{http_endpoint="hellworld/{world}/edit",http_method="GET",http_success="true"} 2.0

✅ Checks

[ ] CI tests (if present) are passing
[ ] Adheres to code style for repo
[ ] Contributor License Agreement (CLA) completed if not a Reddit employee

@KTAtkinson

Can you provide a code sample? This naming just seems really odd to me and I'm curious if we can come up with a better name.

It's called from here https://github.com/reddit/baseplate.py/blob/dbf57a5333343df70f9ed90cad2533fd81618e89/baseplate/observers/prometheus.py#L101-L103
and named that way because that's what the Thrift part is called https://github.com/reddit/baseplate.py/blob/192bd4c0bbf2052f5f416c135e506e4ab04667c6/baseplate/lib/prometheus_metrics.py#L57-L62
The name of the metric "_{server,client}_latency_seconds" is idiomatic Prometheus naming (it's the latency, and the unit is seconds). The thinking behind this function name is that it fetches that particular metric from the registry, but I agree that it ends up looking kinda weird.

@KTAtkinson I'm blocked from merging since you're marked as requesting changes


Don't create empty Manifest.toml

close #365
Having an empty Manifest.toml seems to provoke a (slightly misleading) warning
This change works fine on v1.8... but I imagine we did this for a reason, so i expect this will now fail CI on some old Julia version... since old Julia versions don't work on my laptop i'll rely on CI to complain. Probably we'll need an if VERSION < ... block [EDIT: nope seems fine as is 🤷 ]

Looks like this actually works fine, since v1.0 CI passes
But CI has been consitently failing on v1.8 for the last month 😞

LGTM --- maybe bump the patch version? that will rerun the tests, and if those pass we could probably merge it down immediately.

i'd love someone to take this over! feel free to use this branch or start afresh


Help docs refactor

This PR moves the Style Guide and How To md files into the English folder and exposes them in the topnav of the public-facing site.  It fixes the content of these files to be up-to-date with the new public-facing Hugo site features.
The contents of the CONTRIBUTING.md file was incorporated into the home and how-to pages.
The README.md file of the repo was also updated.
There are other help docs in the repo that seem old and not particularly useful anymore.  I have not done anything with them for now but perhaps they should be deleted or incorporated into the above docs.

glossary.md
persona.md

This PR also includes a few minor edits to fix the copy on the 404 page, the footer Copyright text, make the definition subheadings consistently capitalized and things like that.

LGTM, just a couple nits

Copyright should be "Cloud Native Glossary Authors"

Licensed under CC BY 4.0 in the footer text, see kubernetes.io as an example

LGTM


How to start Kafka?

org.apache.kafka.clients.NetworkClient   : [Consumer clientId=consumer-Trade1-3, groupId=Trade1] Connection to node -1 (localhost/<IP_ADDRESS>:19092) could not be established. Broker may not be available.

I have this problem too. Have you found a solution?

org.apache.kafka.clients.NetworkClient: [Consumer clientId=consumer-Trade1-3, groupId=Trade1] Не удалось установить соединение с узлом -1 (localhost/<IP_ADDRESS>:19092). Брокер может быть недоступен.

I found the reason why kafko does not start, add in the file: docker-compose.yaml stock: - KAFKA_CFG_NODE_ID=1

Thank you


Allow changing authentication service of an address space

Just recording my comment made in another channel:
Is the comparison of the authservice name sufficient?  what if I updated say a host/port number on an external authservice? I don't think that would get detected/propagated.

@k-wall See https://github.com/EnMasseProject/enmasse/pull/3543


[BUG] Room temperature is not being displayed correctly

room temperature is not being displayed correctly
if I remember correctly it was working in previous versions of the plugin, but in the current version (0.8.2) it is not being updated
additionally, there is a UI issue which is probably not related directly to this plugin:
I have changed the settings of the a/c so that I can modify the target temperature by 0.5 °C
I have set the target temperature to 24.5 °C, however the UI shows 25 °C (note, current temperature is not 28 °C):

When I look at the detailed information (pressing the three dots), I see the correct target temperature:

Issue about room temperature was already discussed in other thread. When do you think it was working properly? Are you able to confirm this, may be installing previous version?
About target temperature I will check, but seems a problem related to UI and not integration.

How would like me to confirm this?
Is there a specific previous version I should install (I'll have to check how to install older versions using HACS)
regarding the target temperature, if it is UI related - what is the relevant development repo? I would like to open an issue (or perhaps prepare a PR)

How would like me to confirm this?
Is there a specific previous version I should install (I'll have to check how to install older versions using HACS)

In HACS you can select specific version to install. AC support is available just from version 7.0, but the only version where I introduced a change to try to fix issue is 0.8.1. Should be very strange that other version update room temperature properly.

regarding the target temperature, if it is UI related - what is the relevant development repo? I would like to open an issue (or perhaps prepare a PR)

This is a standard  HA UI. Refer to HA repository.

There was a problem. The air conditioner does not turn on if I press the on button, but you can turn it off. If I click on the cooling or ventilation icon, the air conditioner turns on.

This is not an issue, expected behavior in HA control. Already discussed in issue #156

Hello, I have the samen problem. Room temperature is nut updating in HA. It will update the temperature in HA when I open the LG thinq app.

Same thing, temps are not being updated unless I open the app on my phone and as soon as I do it updates in the hass ui

Hello, I have same problem like geysent. Here is no data updated until I open thinq app on mobile. But still many thanks for your work.

Can someone sniff the command sent to LG cloud when ThinQ app is opened? I don't have LG Climate, I cannot fix this without additional info.

Tried to grab a trace using packet capture app but looks like android has changed some things since i last did a packet capture and its having trouble decrypting ssl. might be able to look at this more this afternoon as it seems i have to apply a cert with root.

Tried to grab a trace using packet capture app but looks like android has changed some things since i last did a packet capture and its having trouble decrypting ssl. might be able to look at this more this afternoon as it seems i have to apply a cert with root.

Unfortunately using Android is complex. More simple if you have an Apple device and MitMiProxy

Closed this issue, with last release it should be fixed.