AppDaemon, set_state, no customizations with 20171215?

Checklist

[X] I'm running the latest version of CustomUI (Update guide) or using a specific release that is not marked as "Broken".
[X] I tried to force-refresh (Ctrl+Shift+R / Ctrl+F5) the browser
[X] (Optional, but recommended) I'm using Chrome or tried to reproduce the feature on Chrome.

Browser + Version: Chrome 63
CustomUI version: 20171215
Home Assistant release (hass --version): 0.60.0 (and previous version)
Problem-relevant configuration.yaml entries:
sensor.living_room_temp:
  friendly_name: 'Living Room Temperature'
  unit_of_measurement: '°F'
  group:
    group.group_livingroom:
      friendly_name: 'Temperature'

Problem-relevant Home Assistant log entries:
None

Any errors from browser Javascript console:
None

In some cases, the customizations are not being applied.
I have some WirelessTags sensors that does an HTTP post into AppDaemon with temperature, humidity and battery voltage. Because these things are chatty and have a limited api, I have them all into AppDaemon and do some cleanup.
In a nutshell, AppDaemon will get the existing state (if any), using get_state, then it will check for a difference (temperature comes in like 6 decimal places and I trunc to 2) and if it is different, it will then do a set_state.
This was working before the update to CustomUI that uses templates. I think the updates don't play well with me calling set_state.
Other customizations are applied to other entities, just not these.

Are you preserving all attributes between get_state and set_state?
Check the resulting attributes /dev-state panel.

I wasn't before the change. I tried updating my app to try to preserve
them, but when I did a get_state all, I didn't get anything.
I am going to roll back the UI update to be 100% sure.
There are no attributes in the dev settings.
I will try to get better information either this evening or tomorrow
evening.
On Dec 19, 2017 2:29 PM, "Andrey"<EMAIL_ADDRESS>wrote:

Are you preserving all attributes between get_state and set_state?
Check the resulting attributes /dev-state panel.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/andrey-git/home-assistant-custom-ui/issues/62#issuecomment-352877344,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHXpa6GKYdcD5EEWWwryFFSYcOzY6t99ks5tCBy0gaJpZM4RGY_d
.

I rolled back to 20171129 and I have the same problems. I'm not sure what has changed, but it doesn't look like it is a CustomUI problem. Sorry about that.

If the only attributes are from the customization file, should I see them with a get_state api call?

Yes, get_state should return all attributes including those set via customization

Ok, I guess I need to keep digging. I run this in docker so I rolled back and tried 59.1, 59.2 and 60.0 with 20171129 and still not working. The AppDaemon get_state has an empty attributes dictionary.
Now to go triple check my customization file to make sure something isn't amiss there.

I gave up trying to figure out why it stopped working. I created a new component, a new sensor type called appdaemon that is basically a template sensor without a template. It has no state logic in it and relies solely on appdaemon to set it.
It seems to be working. My 10 minute "fix".

Marking as closed...


Handling problematic RSS URLs

As an example, when I attempt to use the following RSS URL from NewsAdvance.com:
http://www.newsadvance.com/search/?q=&t=article&l=10&d=&d1=&d2=&s=start_time&sd=desc&c=news/local*&f=rss
I receive an error in the console that it is not an RSS URL. It appears to be one, but I think because it is formatted as a query and not a direct XML/RSS , it's not able to be parsed. Is there a different way these URLs need to be handled, or a way for the script to "pull" the actual RSS file from that query URL and then use that to grab the feed?
Edit
Actually, I noticed a URL like this works fine:
https://www.wsls.com/feeds/rssFeed/feedServlet?obfType=GMG_RSS_TEASERS&siteId=800011&categoryId=80041&nbRows=20&FeedFetchDays=10&includeFeeds=True
So I am curious what it does not like about the URL from NewsAdvance.

A difference I spot straight away between the two URLs is that the first one is not SSL. Is SSL set to false? Could that be causing the issue?

That's possible. Sorry for the delay in getting back on this. I'll check if that may have been it

I'll close this issue because the feed no longer exists. Feel free to re-open the ticket if you experience issues with other URLs


ESRP Releases fail on long paths

Long package names create very long path names on ESRP agents.   Because ESRP hasn't enabled long paths on their windows agents, their processes get IO exceptions when trying to work with a release containing a long path.
We can either rework our pre-publish tasks to create shorter paths for the ESRP task to zip, or we can wait for ESRP to enable long paths on their agents.
Failing pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2708757&view=logs&j=ed89cf04-e547-5b58-1335-f2601379f5b3&t=b04bc0d4-143f-52cb-cbbf-c1e486ec0974
Error message in ESRP's release portal:
Could not find a part of the path 'M:\SvcFab\_App\MS.Ess.PackageManager.Publisher_App2\temp\ee3cf008-f8f6-4464-9a37-f1c01cadc8d7\com\azure\resourcemanager\azure-resourcemanager-postgresqlflexibleserver\1.0.0-beta.6\azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.6-changelog.md.asc.md5'.

n ESRP dri said that they will add support for long paths in the morning (India), 5/18/2023.


Make Hyprlock work like SDDM

Description
If configured, it can replace SDDM.
Also take SDDM's ALL the features.

Hyprlock is a lockscreen, not a display manager. It can't and never will be able to replace SDDM.
For limited purposes like autostarting Hyprland and auto-launching hyprlock as a "login screen", this works, sure.

Thanks...
So I need to take ML4W's dotfiles then edit it a lot. (cause i cannot make that GUI text thingy)
I already configured Hyprland for it

The best learning resource is creating your own configs that work for you. It will also be much easier to debug when things don't work.
Closing.

But there IS a issue...
Also, you know? When Hyprlock DIES, it gives you a message that its died.
I got to rescue it in like 5 MINUTES!
So its MUCH more harder.

Well it shouldn't die often. If you configure it (or your system) properly it should work fine.

The only conceivable way would be to use greetd-ipc and make hyprlock function as a greeter. Would not be easy though.
I think greetd uses an unprivileged user to run the greeter, which is nice, but also means that label commands will run as a different user.
One would roughly need to implement the following:

allow either session-lock-v1 or greetd ipc protocols
implement drawing either on sessionlock surfaces or on normal ones. (greeter would run within a basic wayland compositor. gtkgreet uses cage for example)
add a bunch of options to allow selecting the session and the user to login with. (passted via greetd-ipc)
add a way to disable widgets on either launch method.
??

Combined with the amount of restructuring needed, it would probably come down to rewriting a bunch of stuff.


Data overwriting

In instances where data is written over multiple lines for each subject (e.g. a row for admission, a row for outcome, and a row for each day they were in hospital), data is being overwritten in certain instances.
E.g. for antiviral type with schema code
[visit.treatment_antiviral_type]
    combinedType = "set"
    excludeWhen = "none"
    fields = [
      { field = "daily_antiviral_type___1", values = { 1 = "Ribavirin" } },
      { field = "daily_antiviral_type___2", values = { 1 = "Lopinavir/Ritonavir" } },
      { field = "daily_antiviral_type___3", values = { 1 = "Interferon alpha" } },
      { field = "daily_antiviral_type___4", values = { 1 = "Interferon beta" } },
      { field = "overall_antiviral_dc___1", values = { 1 = "Ribavirin" } },
      { field = "overall_antiviral_dc___2", values = { 1 = "Lopinavir/Ritonavir" } },
      { field = "overall_antiviral_dc___3", values = { 1 = "Interferon alpha" } },
      { field = "overall_antiviral_dc___4", values = { 1 = "Interferon beta" } },
...
      ]

if the 'overall' columns are filled only once, and in an earlier row than the daily columns for a given patient, adtl returns whichever antiviral was administered last in the data table, not a combined list which accumulates across rows. This is an issue previously touched on in #131 (got around by adding the dates to each row in the data) but is more of an issue here.
2 Options:

Only use the 'overall' variables in this case. These are only filled in once, so no overwriting risk, and should contain all the data. The risk is that if these were completed manually by clinicians, administered drugs might have been missed which would be caught by mapping the daily values.
Edit adtl to store the long format tables for each group ID and merge them during data parsing, rather than assuming 1 row per patient which allows overwriting.

May also need thinking about in the context of moving to a new format... when parsing data into FHIR/OMAP this issue may disappear.
I noticed this when looking at the Malaysia dataset, but I'm sure it's an issue in other parsers as well.

@abhidg @sadiekelly thoughts on approaches to this?

hi @pipliggins! so if daily_type___1 is indicated (Ribavirin) and overall___4 also indicated (Interferon beta) only Interferon beta would show in the adtl? Also if both overall___2 and overall___4 are indicated only overall___4 would show? Or is it only specific for the daily variables that are on different rows in the raw data?
Regarding the daily vs overall completion, I had a look at the Malaysia data and the antiviral type variables completed at daily and overall, to see to what extent daily variables are indicated as 'medication received' (response = 1) when there is either no indication (form not completed) at overall, or the response at overall is 'medication not received' (0) (although to also remember these are checkbox variables so '0' doesn't necessarily mean 'not received'). There are just under 200 cases where a medication is indicated as received in a daily form but indicated as not received in the overall form. Additionally there are 50 cases where medication is indicated as received in a daily form but the overall form has not been completed. So we could miss these ~250 cases by not mapping the daily variables, representing 1.5 % of the total number of records with data available for these variables. It is a more common occurrence to have '0' for the daily variable and '1' in the overall form (7244 cases). This refers to a dataset of ~6500 patients so the number of cases missed could scale up if this occurs frequently across many of the datasets, which I think is very likely.
My thoughts are that we should try to capture as much as we can, so that if a medication is indicated in a daily form but not at overall (or vice versa) then this should be recorded so that all instances of medication received are represented. There could be many reasons why either the daily or the overall form could be incorrect or not completed across the different datasets and I don't think we should apply a blanket decision for all datasets and make a decision on determining the source of truth during curation of the data.

Subjid
redcap_day
daily_type___1
daily_type___2
daily_type___3
overall_type___1
overall_type___2
overall_type___3

1
admission

1
discharge

1
0
1

1
day1
1
0
0

1
day2
0
0
1

2
admission

For this simplified data, for subject 1 adtl would only output "Interferon alpha" in the final civ, rather than the correct ["Ribavarin", "Interferon alpha"] output, because it's only saving the final row (or, more accurately, the last non null data for each field).
I would tend to agree about trying to save the data...

This is an issue with adtl, will have a think about what's the best way to resolve this.
For FHIR, this is less of an issue as each row represents one fact, so Interferon alpha and Ribavirin would be on different rows, something that adtl should be able to do with a oneToMany type. This would raise the issue of duplicates, if the medication is mentioned in both daily and overall, but that is an easier fix.

Closed by globaldothealth/adtl#90

Closed by globaldothealth/adtl#90


Allow Helix tests to use internal assets

Summary
Allow Helix test setup to get the blob storage internal container token to read packages and files from the container.

Release Notes Entry

/backport to release/8.x

/backport to release/8.x

/backport to release/8.x


Quaternion closest arc

All fixed.

Done

Added another test to re-use the function. Good now?

Woot!

Sweet!

woohoo! \o/


Adding auto generation from Rust to Dart for toString() and compareTo() methods

Is your feature request related to a problem? Please describe.
I can not find a way to override default Dart toString() and compareTo() method for my Rust struct that implements custom Display (or ToString) Eq, PartiqlEq, Ord, PartialOrd traits.
Describe the solution you'd like
Adding auto generation of code for Display (or ToString) Eq, PartiqlEq, Ord, PartialOrd traits to Dart class

Currently you can provide arbitrary extra Dart code via https://cjycode.com/flutter_rust_bridge/guides/miscellaneous/dart-code.
Also related: https://cjycode.com/flutter_rust_bridge/guides/miscellaneous/eq-hash#custom-arbitrary

Thanks, it works!


Add script for mega menu link checking

This new command line script allows for checking of mega menu links on a running cf.gov server. To run against www.consumerfinance.gov:
cfgov/scripts/validate_mega_menu.py

or to run against an alternate server:
cfgov/scripts/validate_mega_menu.py http://localhost:8000

The script checks each link in the mega menu (as it appears on the homepage) and validates that the link can be fetched with a 200.
How to test this PR
To test, run a local server, edit the English menu (http://localhost:8000/admin/mega_menu/menu/edit/en/) and add a broken link. Run this script against localhost and it will fail.
Checklist

[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines

One interesting site note is that external links that get fed through the /external-site/ logic will never trigger a failure, but I don't that's really a concern of ours here.

Ah, interesting. I didn't think of that. But, yes, I agree. As it happens we don't have any links like that, because the one external link is .gov, which doesn't go through the interstitial. It's probably a safe bet that we wouldn't have any non-.gov links in our site mega menu?

It's probably a safe bet that we wouldn't have any non-.gov links in our site mega menu
Yep, even that one non-cfpb link is kinda surprising to me (rather than a cfpb wagtail page with more easily editable content that itself links to the gpo page). So yeah, :ship:


[Feature] Add ProfileConfig support for GCP Cloud Job Run Execution Mode

Description
Currently, configuration of profile mapping with ProfileConfigs are not supported with GCP Cloud Job Run Execution Mode. We can enable this similar to what was done in https://github.com/astronomer/astronomer-cosmos/pull/1347 for Docker Execution Mode.

Use case/motivation
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes, I am willing to submit a PR!

Thank you for submitting this feature request. I’ve added it to the 1.9.0 milestone for now.


Reduce test verbosity

Reference Issues/PRs

closes #3073
What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.
[ ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Question, @lmmentel: when something goes wrong, we'll still see the traceback, correct?
If not, I'm against this change, but I suppose we still get tracebacks?

We should still the full diagnostic output for failing tests but less so for the passing tests.


Snake game additin

Aim

It is a game where the snake(player) has to get max no. of food items

Details

There is a score function to keep track of how many food items are obtained.
Restart option available so the user doesn't have to run the code again and again.
Easy-to-understand code, for the user to manipulate according to their use. In order to alter the speed of the snake or to alter the size of the snake.

Please assign this under GSSoC'23 label :)

Go Ahead @Akanksha-202


[flash_ctrl] Change FIFO interrupts to status type

This fixes #21211
Note that the DV / DIF side has note yet been aligned.

@msfschaffner I thought prog_lvl, rd_lvl will be high when fifo_depth == level.
Currently, it is high when depth <= level.

@msfschaffner,  compared to #21632
txfifo:  less than water mark
rxfifo: greater than equal to water mark.
To align with this, In flash,
rxfifo: ProgLvl which is correct.
txfifo: RdLvl : should be
assign intr_event[RdLvl]     = reg2hw.fifo_lvl.rd.q < sw_rfifo_depth;
WDYT?

Hey @jdonjdon, thanks for pointing that out - yes, one of comparisons needs to be flipped.
But shouldn't it be the other way round?
I.e., make the prog fifo behave like TX (where we want to know if it has been drained to a certain level), and make the read fifo behave like RX (where we want to know if it has been filled to a certain level)?
One other thing, should we use inclusive thresholds or not?
I believe before the change they were inclusive since we compared with equality...
@a-will do you have any opinions on this?

But shouldn't it be the other way round?
I.e., make the prog fifo behave like TX (where we want to know if it has been drained to a certain level), and make the read fifo behave like RX (where we want to know if it has been filled to a certain level)?

Agreed.

One other thing, should we use inclusive thresholds or not?
I believe before the change they were inclusive since we compared with equality...
@a-will do you have any opinions on this?

No opinion. The current docs suggest the thresholds would be inclusive, but an interrupt for rd_lvl of 0 wasn't possible before (and does sound nonsensical). Probably inclusive for prog_lvl and exclusive for rd_lvl would match the prior behavior.

But shouldn't it be the other way round?
I.e., make the prog fifo behave like TX (where we want to know if it has been drained to a certain level), and make the read fifo behave like RX (where we want to know if it has been filled to a certain level)?

Agreed.

Oh Doubly confused. prog fifo is written by the host and rtl is consumer. Is that the definition of TX fifo?

Yes. Software wants to be left alone until the HW has made sufficient progress (draining the FIFO). So when prog_level <= threshold.

But shouldn't it be the other way round?
I.e., make the prog fifo behave like TX (where we want to know if it has been drained to a certain level), and make the read fifo behave like RX (where we want to know if it has been filled to a certain level)?

Agreed.

Oh Doubly confused. prog fifo is written by the host and rtl is consumer. Is that the definition of TX fifo?

Yes. Software wants to be left alone until the HW has made sufficient progress (draining the FIFO). So when prog_level <= threshold.

Thanks for the clarificaiton :)

CC @GregAC @vogelpi @andreaskurth @alees24
The alignments in the first two commits should come in handy for other blocks that have status type interrupts that are asserted by default.

@jdonjdon I did not yet fix all block-level tests yet.
I suggest we do that in a follow-up PR so that we can unblock interrupt alignments on other blocks.

@msfschaffner flash_ctrl block dv cleanup is updated here


feat: support kubectl diff

In order to permit the API server to call the webhook in "dry run" mode,
it must either announce that it has no side effects or, in the rare case
that it does, knows how to inspect the "dry run" flag and skip those
actions in that mode. The default of "UNKNOWN" means the api-server
fails safe and does not call the webhook.
Since these are simple side-effect free webhooks, we can flag them as
such.

@sethp-nr - this breaks everything in ways that I'm not I fully understand or why. Let me know if you need some more assistance in getting it identified

Hmm, yeah, this is usually how go.mod works for me – I try a bunch of seemingly unrelated stuff until something works, and then I try to work backwards.

I'm not sure what's up with that last security check – it's been scanning for quite a long time now.
I think this is RFR otherwise.


README: Consistent use of GCLOUD_PROJECT

Elsewhere we in the codebase we use GCLOUD_PROJECT but in README.md there were some examples with GCLOUD_PROJECT_ID.
/cc @JustinBeckwith

Coverage remained the same at 100.0% when pulling 4c9c83f937e478b30888fa86e35c81a1a051a6d4 on ofrobots:patch-1 into ca8305e881d41a71e3462aba011620a692322442 on GoogleCloudPlatform:master.

Thank you!


html/indexeddb_5_test fails on IE10

See:
http://build.chromium.org/p/client.dart.fyi/builders/dart2js-ie10-win8-html/builds/458/steps/dart2js tests failures/logs/stdio
I will disable in status file.

Closing this since IE10 is no longer supported by our web targets.


different result of t.test in type II error simulation

Hi, Prof. Rafa!
I'm using R 3.6.3 version and doing some false negative demonstration based on edX PH525x course.
i'm using exactly same code with the lecture video and the book. Here is it
`
dat <- read.csv("mice_pheno.csv")
controlPopulation <- filter(dat,Sex == "F" & Diet == "chow") %>%
select(Bodyweight) %>% unlist
hfPopulation <- filter(dat,Sex == "F" & Diet == "hf") %>%
select(Bodyweight) %>% unlist
mu_hf <- mean(hfPopulation)
mu_control <- mean(controlPopulation)
mu_hf - mu_control
[1] 2.375517
(mu_hf - mu_control)/mu_control * 100 # percent increase
[1] 9.942157
'
So far the result still the same with the video.
After that:
'
set.seed(1)
N <- 5
hf <- sample(hfPopulation,N)
control <- sample(controlPopulation,N)
t.test(hf,control)$p.value
the result supposed to be0.1410204, but my result is 0.5806661`. I retried for several times and several generating value method, but the result hasn't changed.
Seeing that this material was last edited 4 years ago, then I think that there is a logarithmic difference in the 'set.seed()' function.
Glad if you help me

Please say exactly where you find the result given as 0.1410204 - please give
a URL that shows exactly where it can be found.  If it is an exercise solution in edx
give the full URL and name of section and subsection.  Thank you.


Update GitHub pages Issue #709

Hello.
cc @rickr
Updated github templates Issue #709.
If there is anything else I can add please do let me know!
-Thank you.

@rickr Yes, will do so asap!

Hey @rickr any update on this?

@rickr I will fix these changes asap! Sorry about that.

Thank you.

Hey @rickr I did a rebase, but I am not sure if it worked or not.
-Thank you.


No version of tensorflow will install on python 3.7.9 x64 / pip 20.1

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): OS X 11.1 (PC)
TensorFlow installed from (source or binary): pip
TensorFlow version: 1.15 or any other
Python version: 3.7.9
Installed using virtualenv? pip? conda?: pip

Describe the problem
installed python 3.7.9 as compatible platform with TF 1.15 via pyenv
no version of tf will install at all:
:~$ python3 -VV
Python 3.7.9 (default, Feb 24 2021, 13:04:10)
[Clang 12.0.0 (clang-1<IP_ADDRESS>)]
:~$ python3 -c 'import sys;print("%x" % sys.maxsize, sys.maxsize > 2**32)'
7fffffffffffffff True
:~$ python3 -m pip install tensorflow==1.15
ERROR: Could not find a version that satisfies the requirement tensorflow==1.15 (from versions: none)
ERROR: No matching distribution found for tensorflow==1.15

same output with just pip3 install tensorflow
Is there something else I am overlooking as far the python/pip version/build type?

@abolotnov,
TensorFlow 1.x is not actively supported. Please try installing the latest stable version of TensorFlow v2.4.1 using the below command.
pip install --upgrade tensorflow
Thanks!

Not sure how exactly I fixed it, but I got it fixed somehow.


Fix section levels and one link in README

I am a pedant at heart. :-\

Thanks! Me either.
P.S.: You can add [skip ci] to commit message to do not trigger CI build when editing files like readme. It works for both travis and appveyor.

[skip ci]

Thanks for the tip. :+1:


Update to atom 1.0 api (fixes #552)

I am usually a heavy (m)vim user but today I tried to play with atom and generally like it... The big bug I hit was not being able to see my search input as I typed.. I am only somewhat confident this makes sense but it looks right given atom core code/deprecation warnings.

Thanks for the PR! It looks like some of the tests are failing. I'll try to look into why when I get a chance.

#545 has the same changes and I just got the tests to work FWIW. It seems a little ugly how it's traversing the text editor component though

Looks like this was fixed by fc24df5be327b1ff7643f648c5f68910231cc7a4?

Yeah, this has been taken care of now. Thanks for looking into it though, @lightsofapollo.


Best hyperparameters

Thank you so much for publishing this resource! It’s very helpful.
If possible, could you, please, publish the best hyper-parameters for each method and dataset? This would be immensely useful for further extensions.

Thank you for acknowledging our work! We have organized and uploaded the best hyper-parameters for ~80% of the experiments, which can be found in the example_datasets/best_hyperparameters.json file.
Since our experiments were run on multiple servers, it takes time to organize, and we will upload the remaining hyperparameters in the future.

@mkmaa Thank you for sharing the tuning results! I found that n_bins is tuned in modernNCA configs, however there is no data_num_enc in modernNCA's method, which is the sole function using n_bins.

@mkmaa Thank you for sharing the tuning results! I found that n_bins is tuned in modernNCA configs, however there is no data_num_enc in modernNCA's method, which is the sole function using n_bins.

Sorry for the confusion. This was due to the fact that in our exploration of numerical encoding, we added the n_bins hyper-parameter to all experiments for convenience. However, our final results are based on the default setting with no extra numerical encoding, so this hyper-parameter can be disregarded. We have updated the hyper-parameters.

Thanks for the quick reply!


Fix MCO index check in HAL_RCC_MCOConfig

MCOConfig did not check the MCO index properly meaning that outputting MCO signal to either MCO2 or MCO3 would fail without the user knowing it
IMPORTANT INFORMATION
Contributor License Agreement (CLA)

The Pull Request feature will be considered by STMicroelectronics after the signature of a Contributor License Agreement (CLA) by the submitter.
If you did not sign such agreement, please follow the steps mentioned in the CONTRIBUTING.md file.

Hi @mdiepart,
Thank you for this report. The issue you pointed out is confirmed. An internal tracker has been logged and a fix will be implemented and made available in the frame of a future release. Thank you once again for your report.
With regards,

ST Internal Reference: 119947


Error about "Chromium revision is not downloaded. Run BrowserFetcher.DownloadAsync or download Chromium manually"

Description
There is a method ,named OpenChromiumPage(), which open Chromium page as headless=true. While opening chromium, download zip file with revision number but its size 0KB.
After that, the method threw an exception with message says that "Chromium revision is not downloaded. Run BrowserFetcher.DownloadAsync or download Chromium manually"
Sometimes zip file extracted but when try to download chromium, giving the same error.
Should I update or add any code to below method?
My code located below.
         public static async Task<Page> OpenChromiumPage()
        {
            var browserFetcher = new BrowserFetcher(new BrowserFetcherOptions
            {
                Path = "C:\\Chromium"
            });
            await browserFetcher.DownloadAsync(BrowserFetcher.DefaultRevision);
            var browser = await Puppeteer.LaunchAsync(new LaunchOptions
            {
                Headless = true,
                Timeout = 0
            });
            return await browser.NewPageAsync();
        }

Expected behavior:
Zip file extracted and Chromium works
Actual behavior:
"Chromium revision is not downloaded. Run BrowserFetcher.DownloadAsync or download Chromium manually"
Versions
Version of PuppeteerSharp : v1.19.0 but latest versions give same result.
.NET runtime and version: .NET framework 4.6.2
Additional Information
I tried to set a value for ExecutablePath property which is chromium.exe file path. Then download and works.
Is there any other solution or What should I update my code?

You have to pass ExecutablePath to Puppeteer.LaunchAsync. It will look like this:
     public static async Task<Page> OpenChromiumPage()
    {
        var browserFetcher = new BrowserFetcher(new BrowserFetcherOptions
        {
            Path = "C:\\Chromium"
        });
        await browserFetcher.DownloadAsync(BrowserFetcher.DefaultRevision);
        var browser = await Puppeteer.LaunchAsync(new LaunchOptions
        {
            Headless = true,
            Timeout = 0,
            ExecutablePath = "c:\\....\\chrome.exe"
        });
        return await browser.NewPageAsync();
    }

If you do not pass Path in BrowserFetcher, the you do not need to add ExecutablePath because it will automatically look into default download location.

Chrome is downloaded in its own version folder
C:\ChromiumDL\Win64-706915 (folder created by the downloaded)
How do you specify that folder in the executable path?

BrowserFetch will always create its own folder. You can get that folder if you call GetRevisionInfo and get the ExecutablePath property from there.

Thanks, having trouble figuring out how to call GetRevisionInfo..

Closed due to inactivity. Feel free to reopen it if needed.

Little off-topic. Is there a possibility to not include the Chromium with my application and leave it to be downloaded with BrowserFetcher, BUT somehow to configure BrowserFetcher to fetch seme specifi version of the Chrome.
To have consistent behavior of my application which will not be affected by future Chromium engine updates.

@kinguru  If you use the DefaultRevision.  Puppeteer will download the same revision unless you upgrade the library.

thanks @kblok !


chore: clean up stale branches on the repo

This repo now has 50 Git branches.
The scope here is to:

clean up existing branches
enable the automation, if not already enabled, to automatically delete branches once merged (Github settings)

A branch cleanup was performed last year that resolved this.


Clear Selection causes Toolkit to roll over

Name of Defective Feature

Problem with clear selection option

System Settings (Required)

ToolKit Version: 2.3.0
Operating System (Mac/Windows/Etc): Windows 10
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: Version 65.0.3325.181 (Official Build) (64-bit)
Other Extensions: many!

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"\"0\""},{"key":"AccountsEmphasizedOutflows","value":true},{"key":"AccountsStripedRows","value":false},{"key":"AdditionalColumns","value":true},{"key":"AdjustableColumnWidths","value":true},{"key":"AutoDistributeSplits","value":false},{"key":"BetterScrollbars","value":"\"0\""},{"key":"BudgetProgressBars","value":"\"0\""},{"key":"BudgetQuickSwitch","value":true},{"key":"CalendarFirstDay","value":"\"1\""},{"key":"CategoryActivityCopy","value":true},{"key":"CategoryActivityPopupWidth","value":"\"0\""},{"key":"ChangeEnterBehavior","value":true},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":true},{"key":"CollapseSideMenu","value":true},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CurrentMonthIndicator","value":true},{"key":"CustomFlagNames","value":false},{"key":"DaysOfBuffering","value":false},{"key":"DaysOfBufferingHistoryLookup","value":"\"0\""},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"\"0\""},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"\"0\""},{"key":"EnableRetroCalculator","value":true},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":false},{"key":"GoalWarningColor","value":false},{"key":"GoogleFontsSelector","value":"\"0\""},{"key":"HideAccountBalancesType","value":"\"0\""},{"key":"HideAgeOfMoney","value":true},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"ImportNotification","value":"\"0\""},{"key":"IncomeFromLastMonth","value":"0"},{"key":"LargerClickableIcons","value":false},{"key":"MonthlyNotesPopupWidth","value":"\"0\""},{"key":"NavDisplayDensity","value":"\"0\""},{"key":"Pacing","value":"\"0\""},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"\"0\""},{"key":"QuickBudgetWarning","value":true},{"key":"ReconciledTextColor","value":"\"0\""},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"\"0\""},{"key":"RowsHeight","value":"\"0\""},{"key":"RunningBalance","value":"\"1\""},{"key":"SeamlessBudgetHeader","value":false},{"key":"ShowCategoryBalance","value":true},{"key":"ShowIntercom","value":true},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":true},{"key":"ToggleMasterCategories","value":true},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"0"},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"goalIndicator","value":true},{"key":"highlightNegativesNegative","value":false},{"key":"l10n","value":"\"0\""},{"key":"pacing","value":"\"0\""},{"key":"popupCalculator","value":true},{"key":"reports","value":true}]

Steps to Reproduce the Behavior

Selected a number of transactions, right-clicked, mark as cleared (which worked fine), then deselect / clear selection prompted a dialogue box "YNAB toolkit is having a problem with clear selection - please submit an error report"
as above
as above

Expected Behavior

Selection would be cleared
Actual Behavior

Toolkit error dialogue box and prompt to submit this bug report

Hey @dbaldon the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".


Add display waveform function

Adds display waveform function which accepts a sound and displays it using the curves library

Yes, very nice function. I'm happy with it and have seen it in action.
A suggestion for discussion: How about using a relative number as parameter: number_of_points_per_second instead of the absolute number_of_points ?
That way the user can relate the number directly to the sample rate used in audio processing. For example, common values would be as given here:
https://en.wikipedia.org/wiki/Sampling_(signal_processing)#Sampling_rate

Pull Request Test Coverage Report for Build 2937

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.815%

Totals

Change from base Build 2935:
0.0%

Covered Lines:
2585

Relevant Lines:
6286

💛  - Coveralls

Yes, very nice function. I'm happy with it and have seen it in action.
A suggestion for discussion: How about using a relative number as parameter: number_of_points_per_second instead of the absolute number_of_points ?
That way the user can relate the number directly to the sample rate used in audio processing. For example, common values would be as given here:
https://en.wikipedia.org/wiki/Sampling_(signal_processing)#Sampling_rate

Agreed, that would be more meaningful for students


added check for maximumFractionDigits=0

Fixes #379

Travis is reporting test failures - can you look into those?

Okay.

Hi @arvind-kalyan, I have also left a couple of comments above. Just let us know when you have updates. So, we can do another review round.

Hi, made the changes. Build is failing again. I'll check the code again.

Two test cases need to have the expected values updated. Feel free to do
it. Thanks

--
+55 (16) 98138-1582, +1<PHONE_NUMBER>, skype: rxaviers
http://rafael.xavier.blog.br

I tried to push changes from another location. I'll fix this in 4-5 hours when I reach home.

Looks like everything is fine, despite the failures: The CLA check failed since you pushed with different git author information, but once squashed that will disappear, and the other commits are valid. The Travis build is failing due to invalid commit messages - again, squashing commits into one and updating the commit message can address that. I'll leave it to @rxaviers to do that - I may have missed something.

Hi, I have made the changes.
@rxaviers  Kindly check.
@jzaefferer What is the correct format for commit messages?

That's documented here: http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines

:+1:


Replace a panic with returning an error when an unsupported call is used

Fixes #5773.

Thanks @jsternberg - that fixed it for me in my test server.

LGTM :+1:


next dev with purs?

The package.json created by this template looks like this.
  "scripts": {
    "dev": "next dev",
    "build": "npm run build:spago && npm run build:next",
    "build:spago": "spago build",
    "build:next": "next build",

So I can build the project in one step: npm run build.
But when I run npm run dev, the next.js watcher doesn't rebuild my .purs files when necessary. Is there a way to configure next dev to rebuild the .purs files?

If you are using VSCode then the purs ide server should automatically build the purs files and next should pick up the changes. Maybe try restarting the purs ide server in vscode?
Otherwise you could do something like
"dev": "next dev && spago build -w",

but if the ide server works properly this shouldn't be necessary..

If you are using VSCode then the purs ide server should automatically build the purs files and next should pick up the changes

I do use VSCode and I’ve noticed that sometimes the next dev watcher does pick up the PureScript changes, but mostly it doesn’t work. I think maybe there is a race condition somewhere in here.

I save Page.purs.
PureScript IDE detects the change to Page.purs, compiles to output/.
next dev detects the change to output/, compiles “client and server.”

I save Page.purs.

PureScript IDE detects the change to Page.purs, compiles to output/.

next dev detects the change to output/, compiles “client and server.”

This should be fine as it is a change.   I just checked and in my .next.config.js I also have the folllowing:
/** @type {import('next').NextConfig} */
const nextConfig = {
  reactStrictMode: true, // Recommended for the `pages` directory, default in `app`.
  experimental: {
    appDir: true,
  },
  webpack: (config, options) => {
    config.resolve.modules.push("output");

    config.snapshot = {
      ...(config.snapshot ?? {}),
      // Add all node_modules but @next module to managedPaths
      // Allows for hot refresh of changes to @next module
      managedPaths: [/^(.+?[\\/]node_modules[\\/])(?!@next)/],
    };
    return config;
  },
};

Maybe this is missing


Service principal clientID not found in Active Directory tenant...

Did anything change in the implementation the past few weeks? This documentation used to work, but now getting this error despite all the arguments being correct.  Details: Service principal clientID: XXXX not found in Active Directory tenant XXXXX, Please see https://aka.ms/aks-sp-help for more details.

Note the clientID: referenced in the error is the value of argument --aad-client-app-id
bash-4.4$ az --version
azure-cli                         2.0.61 *

acr                                2.2.3 *
acs                               2.3.20 *
advisor                            2.0.0
ams                                0.4.3 *
appservice                        0.2.16 *
backup                             1.2.2 *
batch                              4.0.0 *
batchai                            0.4.8 *
billing                            0.2.1
botservice                         0.1.9 *
cdn                                0.2.1 *
cloud                              2.1.1
cognitiveservices                  0.2.5
command-modules-nspkg               2.0.2
configure                         2.0.20 *
consumption                        0.4.2 *
container                         0.3.15 *
core                              2.0.61 *
cosmosdb                           0.2.9 *
dla                                0.2.5
dls                                0.1.8 *
dms                                0.1.3
eventgrid                          0.2.2 *
eventhubs                          0.3.4 *
extension                          0.2.4 *
feedback                           2.1.4 *
find                               0.3.1 *
hdinsight                          0.3.2 *
interactive                        0.4.2 *
iot                                0.3.7 *
iotcentral                         0.1.6
keyvault                          2.2.13 *
kusto                              0.2.1 *
lab                                0.1.6 *
maps                               0.3.4
monitor                           0.2.11 *
network                            2.3.5 *
nspkg                              3.0.3
policyinsights                     0.1.2 *
profile                            2.1.4 *
rdbms                              0.3.9 *
redis                              0.4.2 *
relay                              0.1.4
reservations                       0.4.2
resource                          2.1.12 *
role                               2.4.3 *
search                             0.1.1
security                           0.1.1
servicebus                         0.3.4 *
servicefabric                     0.1.15 *
signalr                            1.0.0
sql                                2.2.0 *
sqlvm                              0.1.1
storage                            2.3.2 *
telemetry                          1.0.2
vm                                2.2.17 *

Python location '/usr/local/Cellar/azure-cli/2.0.61/libexec/bin/python'
Extensions directory '/Users/xxxx/.azure/cliextensions'

Python (Darwin) 3.7.3 (default, Apr  8 2019, 14:57:53)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]

Legal docs and information: aka.ms/AzureCliLegal

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a47c6df7-5103-1336-eb0b-68f95155e6c8
Version Independent ID: f4420b08-9b57-f581-fcb4-f069afdd5b0c
Content: Integrate Azure Active Directory with Azure Kubernetes Service
Content Source: articles/aks/azure-ad-integration.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! We are currently investigating and will update you shortly.

Possibly related to #32873 and https://github.com/Azure/azure-cli/issues/9585
@bitsofinfo  please following the above issues for updates.

@MicahMcKittrick-MSFT The issue this points to is not the same issue as is described by @bitsofinfo. This issue is about the Azure AAD integration with AKS. This did work in the past, but it doesn't anymore.

I got past the error by deleting the cached sp secrets file located here C:\Users\username.azure\aksServicePrincipal.json.  I hope this helps someone.

Still encountering the exact same issue!
Not sure why this kind of thread is being closed with no valid solution, just redirecting to other issue doesn't solve it.
-> https://github.com/Azure/azure-cli/issues/9585
-> https://github.com/MicrosoftDocs/azure-docs/issues/32873
"Thanks for that. I am following that issue as well so we can see what the CLI team can do :)"
WTH!?


Add 2022 draft

Added new VFX 2022 Draft images with the following versions:
* python-3.9.5
* tbb-2020_U3
* boost-1.75.0
* cppunit-1.15.1
* log4cplus-1.1.2
* glew-2.1.0
* glfw-3.1.2
* qt-5.15.2
* pyside-5.15.2
* cmake-3.20.5
* openexr-3.0.5
* blosc-1.5.0
* alembic-1.8.2
* oiio-<IP_ADDRESS>
* ocio-2.0.1
* opensubdiv-3_4_3
* ptex-2.4.0
* openvdb-8.1.0
* usd-21.05
* partio-1.14.0
* osl-<IP_ADDRESS>
* otio-0.13
* numpy-1.20
* hdf5-1.8.21
Stopped active maintenance of VFX 2018 images (images are still available on dockerhub, but will not be rebuilt anymore, the OS packages and sonar utilities will become stale over time!)

I had to change my strategy to add the imath package, it is now a dummy empty package for v2 instead of containing ilmbase as I tried first (I had to use autotools to build ilmbase without openexr and that failed in different ways for years 2019/2020/2021!).
This way is both simpler and closer to what we had before.


Added delete operation in simple-cli example

Added deleteTable command option & added the same to test.sh as well.
Updated README.md for create table( as it was giving no columnfamily found exception if we only follow the instructions) & added delete command description at the bottom.
Shifted Filter expressions under scan-instruction to make more readable. (earlier It seemed like end of instructions and start of some new content).
Updated bigtable version to 1.9.0 & other dependenices to latest available.

@sduskis  Could you please have a look at this PR.


Failing "make build"

Hi,
I am just trying to get "make build" running. There is an error with cfssl. How to avoid this?
docker build -t aztack .
Sending build context to Docker daemon  637.4kB
Step 1/12 : FROM golang:1.9
 ---> ef89ef5c42a9
Step 2/12 : RUN go get -u github.com/dgrijalva/jwt-go/cmd/jwt
 ---> Using cache
 ---> 0a0a6da8c447
Step 3/12 : RUN go get -u github.com/cloudflare/cfssl/cmd/...
 ---> Running in e829a2adc0f7
# github.com/cloudflare/cfssl/csr
src/github.com/cloudflare/cfssl/csr/csr.go:272:26: cert.URIs undefined (type *x509.Certificate has no field or method URIs)
src/github.com/cloudflare/cfssl/csr/csr.go:387:7: tpl.URIs undefined (type x509.CertificateRequest has no field or method URIs)

The command '/bin/sh -c go get -u github.com/cloudflare/cfssl/cmd/...' returned a non-zero code: 2
make: *** [prereqs] Error 2

Exactly same issue, did you sort it out ?
Thanks


Card.api_retrieve() will crash if the customer associated with the card has been deleted

Situation: Calling on_delete_subscriber_purge_customer on a customer that has already been deleted by Stripe.
Eventually, we enter Customer.purge() which hits for source in self.sources.all(): source.remove().
However, if the customer has already been deleted, calling remove() on a source whose customer has already been deleted will crash, because it first calls retrieve() on the card object. This is caused by the StripeCard.api_retrieve method:
    def api_retrieve(self, api_key=settings.STRIPE_SECRET_KEY):
        # OVERRIDING the parent version of this function [...]
        return self.customer.api_retrieve(api_key=api_key).sources.retrieve(self.stripe_id, expand=self.expand_fields)

Now, what happens if self.customer.api_retrieve(...) returns a deleted customer? See for yourself:
>>> customer = Customer.retrieve(id="cus_ACOAhvtRVLJTDT", api_key=settings.STRIPE_SECRET_KEY)
>>> customer
<Customer id=cus_ACOAhvtRVLJTDT at 0x7fd435fffae8> JSON: {
  "deleted": true,
  "id": "cus_ACOAhvtRVLJTDT"
}
>>> "sources" in customer
False
>>> customer.sources.retrieve(...)
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/home/vagrant/env/lib/python3.4/site-packages/stripe/resource.py", line 135, in __getattr__
    raise AttributeError(*err.args)
AttributeError: sources

This is pretty hard to fix without reworking the djstripe api because api_retrieve() is always expected to either return a real object, or a native stripe error.
We can check for if "sources" not in customer... but then what to do with that? raise our own error? return none? neither of those are handled anywhere.

Something like this should work:
diff --git a/djstripe/stripe_objects.py b/djstripe/stripe_objects.py
index 600bfd8..161b0bb 100644
--- a/djstripe/stripe_objects.py
+++ b/djstripe/stripe_objects.py
@@ -1199,10 +1199,13 @@ Fields not implemented:
     def api_retrieve(self, api_key=settings.STRIPE_SECRET_KEY):
         # OVERRIDING the parent version of this function
         # Cards must be manipulated through a customer or account.
-        # TODO: When managed accounts are supported, this method needs to check if either a customer or
-        #       account is supplied to determine the correct object to use.
-
-        return self.customer.api_retrieve(api_key=api_key).sources.retrieve(self.stripe_id, expand=self.expand_fields)
+        # TODO: When managed accounts are supported, this method needs to check if
+        # either a customer or account is supplied to determine the correct object to use.
+        customer = self.customer.api_retrieve(api_key=api_key)
+        if "sources" not in customer:
+            # The customer has most likely been deleted and doesn't have a sources attribute
+            raise InvalidRequestError("No such source: %s" % (self.stripe_id))
+        return customer.sources.retrieve(self.stripe_id, expand=self.expand_fields)

     @staticmethod
     def _get_customer_from_kwargs(**kwargs):


UHF-9202: Add ploughing_schedule

UHF-9202

What was done

Added Ploughing schedule React search

How to install

Make sure your instance is up and running on latest dev branch.

git pull origin dev
make fresh

Update the Helfi Platform config

composer require drupal/helfi_platform_config:dev-UHF-9202_Ploughing_schedule_search

Run make drush-updb drush-cr

How to test

[ ] Check other PRs (HDBT) for testing instructions
[ ] Check that code follows our standards

Other PRs

https://github.com/City-of-Helsinki/drupal-hdbt/pull/855
https://github.com/City-of-Helsinki/drupal-helfi-kymp/pull/759

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09b0a1a) 13.07% compared to head (d2ac5a4) 13.07%.

:exclamation: Current head d2ac5a4 differs from pull request most recent head 2fa0d70. Consider uploading reports for the commit 2fa0d70 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #664   +/-   ##
=========================================
  Coverage     13.07%   13.07%
  Complexity      241      241
=========================================
  Files            28       28
  Lines           941      941
=========================================
  Hits            123      123
  Misses          818      818

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cert V2 firewall fixes

Handle all ICMPv6 traffic with identical rules to ICMP
Correct intepretation of port numbers on UDP traffic wrt incoming vs outgoing (I'd like to add a test for this as well, but there's no .Marshal() for IPv6 headers)

blerg, wanna go fmt rq


Update crossslidingstate.md

Testing PR auto-assignment. Please do not merge.

#assign: @msatranjr
@msatranjr - not sure you need to do anything here, but for your awareness.
@MancunianBandit - auto assign uses the 'author' metadata tag and this file doesn't have one so it didnt' work. please close the pr when you're done with it. thanks!
thanks!


Externalize wildmenu

@bryphe following on from #1127, I've added an external wild menu which I've also placed behind an experimental flag experimental.wildmenu.mode: false.

It's a much simpler thing to externalise as there is no cursor to deal with. I've left it pretty minimal and used theme values for styling but as to icons etc. its pretty bare bones.
Also whilst implementing it, it occurred to me that I'm able to navigate it smoothly as i have the following settings in my vimrc
"pressing Tab on the command line will show a menu to complete buffer and file names
set wildmenu
set wildchar=<Tab> "Key to use to navigate wild menu
set wildmode=full       " Shows a menu bar as opposed to an enormous list
set wildcharm=<C-Z>

this basically allows me to scroll the wild menu by hitting tab, not sure what the experience would be for a user new to vim i.e. arrow keys etc. I was thing we could add these settings to the init.vim though they might be controversial and might be better left to the user, but this I imagine wont work properly without some init.vim settings.

Cool, it's looking neat!

Also whilst implementing it, it occurred to me that I'm able to navigate it smoothly as i have the following settings in my vimrc

It actually worked OK for me too (I didn't have any settings for this in my init.vim). I wonder if some of these are set by default?

this basically allows me to scroll the wild menu by hitting tab, not sure what the experience would be for a user new to vim i.e. arrow keys etc. I was thing we could add these settings to the init.vim though they might be controversial and might be better left to the user, but this I imagine wont work properly without some init.vim settings.

It'd be great if we could avoid settings in init.vim if possible - especially for these externalized features. For this, do you think we could control the selection of the item from the Oni side? For example, add a keybinding like command.next - sort of like how we have menu.next? Or even reuse the menu.next binding? I'm thinking we could style it to look similiar to our other menus - like the quick open / command palette, and in that case, it would make sense for it to have the same input experience as those menus.

Also, I'm cool to bring this in as-is since it's behind an experimental flag -  we can continue to refine incrementally. Let me know if you're all set or if there is anything else you wanted to do as part of this PR.

@bryphe all done for now 🌮
Agreed re styling it down the line, as its a bit bland perhaps a little later I can have a look at having it look more or less the same as the quickOpen menu.
Re controlling the selection, as far as I can see that all comes from neovim so any oni binding would likely be a wrapper for whatever command default neovim uses to navigate the wildmenu, maybe the default wildchar, but as with the commandline window it isn't so much us actually sending input from the component so much as too me it feels like eavesdropping on a conversation lol

@bryphe all done for now 🌮
👍

Re controlling the selection, as far as I can see that all comes from neovim so any oni binding would likely be a wrapper for whatever command default neovim uses to navigate the wildmenu, maybe the default wildchar, but as with the commandline window it isn't so much us actually sending input from the component so much as too me it feels like eavesdropping on a conversation lol

Makes sense. I wonder if there is a way for us to 'abuse' that command line functionality, or at least move a bit outside the box. One naive approach to get an experience that would be similiar to our existing scenarios would be, for every keystroke, we clear out the command line, and then send the new command line + <TAB> (or whatever the default wildmenu expand is). That way, as I'm typing like :vsp, I'm implicitly expanding as I go. I imagine this might break more advanced functionality, but it might be good enough - and if it wasn't, the user could always 'eject' and turn off the commandline/wildmenu externalization.

Will bring this in! Nice work @Akin909 , thanks for all you did here!

@bryphe re. the replacing input of the cmdline, that might be a good approach for the cmdline but for the wild menu it would essentially treat each attempt at that as a new wild menu, which I think would make it very hard to use, also re. implementation each time a user hit the binding they would make a new request for a wildmenu's options which would need to be sorted and is possibly not likely to look the same i.e. the same results.
I think a user who's likely using the wild menu has probably spent a bit of time with vim and likely has a mapping or can add one.
If they're a new user then at a certain point they're going to have to start adding mappings to vim itself, otherwise I think this could put oni in the situation of circumventing vim mappings by working around them.
I think a better way to address this would be through the #1135 aka teaching people how to add them or maybe oni having some interface for that as some point.


Card background color depending on kind

Closes #18

Codecov Report

Merging #26 (290c951) into master (1ff97b0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          308       308
  Branches        12        12
=========================================
  Hits           308       308

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff97b0...290c951. Read the comment docs.

Codecov Report

Merging #26 (290c951) into master (1ff97b0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          308       308
  Branches        12        12
=========================================
  Hits           308       308

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff97b0...290c951. Read the comment docs.


Pin pyarrow version at 0.17.0 as a workaround for an Arrow bug

This pull request temporarily pins the version of our pyarrow dependency at 0.17.0 as a workaround for the problems reported in #28 . The changes to requirements.txt and the env.sh script are in commit 613b231
I also needed to change the SpaCy-related regression tests a bit to get them to pass with the latest version of the SpaCy English small language model. I've included those changes as a second commit, 4ffe713.
Once pyarrow 1.0.0 is released, we will want to update requirements.txt to use that version, which has a fix for the Arrow bug that is the root cause of #28 .

Looks good to me.


HOO-Option-Group columns

Is your feature request related to a problem? Please describe.
Find a way to specify number of columns for the option group using css/css variable? Also needs to be responsive.

Completed Core and React updates in 2.1.x release


cannot be installed without a certificate

Failed to install the application, prompting that the application cannot be installed without a certificate.(HarmonyOS)

Thanks for the report! I'll dig into this and see how can we solve it

Found the guide to sign the APK, leaving it here for development https://reactnative.dev/docs/signed-apk-android.html#adding-signing-config-to-your-app-s-gradle-config


Add support for BlackMagicProbe

Description/Motivation/Screenshots
This adds three things:
gef-bmp-remote command, to connect to a black magic probe. This is its own command because it connects to a tty instead of a host/port.
GefBMPRemoteSessionManager, which handles connecting and such.
ARMBlackMagicProbe, a new arch, which handles its own memory management and has different register names that e.g. openocd.
How Has This Been Tested ?
Using my black magic probe to connect, attach, and successfully debug a target.

[ ] x86-32
[ ] x86-64
[x] ARM
[ ] AARCH64
[ ] MIPS
[ ] POWERPC
[ ] SPARC
[ ] RISC-V

Checklist

[x] My code follows the code style of this project.
[ ] My change includes a change to the documentation, if required.
[ ] If my change adds new code,
adequate tests have been added.
[ ] I have read and agree to the
CONTRIBUTING document.

Can you add some docs? For new people to use it


Trigger on any change

@GuyHarperDay I don't remember this PR, but it seems like whatever we were trying to do here we have since implemented anyway (plus, the path in this code is outdated now). Is it safe for me to close, or am I missing something?


Create Architecture (Internal?) Docs

This is in reference to Micronaut at large. And is an enhancement request not a bug.
Reference to this issue
https://github.com/micronaut-projects/micronaut-core/issues/445
@graeme suggested that there could be separate issue raised for creating architecture docs.
The rationale for the same could be:

It will give more contributors to the project, may be?, cause the consumers of this would be core developers / contributors at large and thus it's not just user guide.
It will also help in self led contribution from other projects let's say @nats_io for example who have expertise in their project but don't have heady start in micronaut.
It will give the good looking architecture diagram too :) in short
It will be a good nice back also to ASM, and APT

A random view on who should take this PR / do it?
I can also help, but I am not very well versed with ASM, and Annotation Processing (and I am not bringing the groovy and kotlin support here)
Individual effort so far have taken me to io.micronaut.annotation.processing. BeanDefinitionInjectProcessor just to build on, my idea is to reach to a component level diagram in the end with the explanation text of course, to give out the doc that how does the framework boots up.

@akamanocha I think your intention was to raise this ticket in the Micronaut project instead of the picocli project. You may want to raise a new ticket in the Micronaut project.
It sounds like an interesting effort. Graeme’s recent presentation may be useful.
Slides: https://www.slideshare.net/graemerocher/micronaut-deep-dive-devoxx-belgium-2019
Video: https://www.youtube.com/watch?v=S5yfTfPeue8

Oh yes! such a bad start to week. Awful Monday morning. But many thanks! I will correct the mistake.

@akamanocha No problem at all. Please try picocli in your projects, you may like it! :wink:


Inquiry about multivariate / covariate / endogenous / exogenous variable support

There're already quite some inquires or latent demand on such feature(s), albeit I'm possibly not summarizing it in academically precise manner:
#24 How to add future covariates
#49 请问各位大佬，用自己的数据集训练都需要改什么呢？
#73 TimeMixer是否适合私有数据集的协变量预测任务？
Nixtla/neuralforecast#1137 TimeMixer Model - exogeneous variables support

Take the multivariate dataset PEMS08 for example. It has the shape (17856, 170, 3), I'd assume it means (batch, number of detectors, variates), whereby the variates may include flow, occupy, and speed, per this kaggle notebook.
However, as I debug into the exp_long_term_forecasting.py, turns out that the batch_x.shape becomes (32, 96, 170), for which I'd assume meaning (batch, seq_len, variate). It seems that only one of the multiple variates (in this case 3) is used for training the model.

Thanks for your attention to our work. I apologize for not understanding your specific meaning. TimeMixer for the PEMS dataset is a multivariate time series prediction, which means it processes multiple time series simultaneously.


Domain-independent heuristics

This pull request contains:

Stable implementations of the domain-independent heuristics MOMs (for initial scoring of atoms) and VSIDS (for dynamic scoring of atoms). Parts of the implementation are inspired by clasp.
Experimental implementation of new VSIDS derivative DependencyDrivenVSIDS, building on ideas described in our research paper Introducing Heuristics for Lazy-Grounding ASP Solving.
A refactoring of ChoiceManager, extracting some parts of it to the new ChoiceInfluenceManager class.

Due to merging #164 this PR has conflicts now. Please resolve those, so we can get this important contribution into master.

Due to merging #164 this PR has conflicts now. Please resolve those, so we can get this important contribution into master.

done.

Due to merging #164 this PR has conflicts now. Please resolve those, so we can get this important contribution into master.

Done.

@AntoniusW thank you for your comments, which allowed me to improve this PR a lot.
All of your comments have now been addressed.

@AntoniusW the change that we discussed today has now also been done.


Try using php linter

- name: PHP Syntax Checker (Lint)
  uses<EMAIL_ADDRESS>  with:
    dir: './src'

name: 'php linter'

on:
  push:
    branches: [ "main" ]
  pull_request:

permissions:
  contents: read

jobs:
  terraform:
    name: 'lint'
    runs-on: ubuntu-latest
    environment: production

    # Use the Bash shell regardless whether the GitHub Actions runner is ubuntu-latest, macos-latest, or windows-latest
    defaults:
      run:
        shell: bash

    steps:
      uses<EMAIL_ADDRESS>      with:
        dir: './src'


Use-after-move in ServerHandlerImp.cpp when logging RPC error

Problem:
We move the result object on line 779 and then use it to log the error and error message right after on line 781

This is a bug. Nice find! We will fix this.

Thanks for fixing the bug @HowardHinnant


Please add ONLYOFFICE support in peek

Description of the new feature / enhancement
Just like peek opens docx, pptx, xlsx format files when "Microsoft Office" is installed, it should open in same way for "ONLYOFFICE" also.

Scenario when this would be used?
When "Microsoft Office" isn't installed in user's PC & "ONLYOFFICE" is installed
Supporting information
No response

Note for everyone: We don't have native support for MS Office. Peek uses the Explorer preview pane handler from MS Office.

@lovwanshichetan you could use QL-Win/QuickLook for your use case right now until peek embeds something..
QuickLook has an embedded office previewer plugin..

/dup https://github.com/microsoft/PowerToys/issues/26210


MetalLB does not work if it is set to use IPs in service network

Describe the bug
I haven't tested it, though.
I just heard it.
If metallb_ip_range is set to ip addresses in service network,
it does not work.
Please test metallb with service network ip.

I tested on my testbed.
I configured the service network ip - <IP_ADDRESS>/32 for metallb
ipAddressPool.
    root@btx-0:/# k get ipaddresspool -n metallb-system
    NAME      AUTO ASSIGN   AVOID BUGGY IPS   ADDRESSES
    primary   true          false             ["<IP_ADDRESS>/32"]

And I set service type to LoadBalancer in nginx web service.
    ---
    apiVersion: v1
    kind: Service
    metadata:
      name: nginx
      labels:
        app: nginx
    spec:
      ports:
      - port: 8999
        name: web
        targetPort: 8080
      type: LoadBalancer
      selector:
        app: nginx
    root@btx-0:/# k get svc nginx -n default
    NAME    TYPE           CLUSTER-IP      EXTERNAL-IP      PORT(S)          AGE
    nginx   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   8999:30940/TCP   3h23m

Now connect to <IP_ADDRESS>:8999 using curl from my dev machine.
    jijisa@jijisa-dev:~$ curl <IP_ADDRESS>:8999/

This is web-0 area

There is no problem to set the ip in service network
for metallb ipaddresspool.
I will close this issue #247.


[MWPW-131948] Hero color block

[MWPW-131948]
Description

Built a new block called called 'hero-color' for the colors page

Test URLs:

Before: https://main--express--adobecom.hlx.page/express/colors/red?lighthouse
After: https://mwpw-131948--express--adobecom.hlx.page/express/colors/red?lighthouse

Last round:

I've pushed a new sprite sheet to the branch. Use the desktop version of the color-marquee svg with viewBox only and instead of loading a different svg:

set the svg height to the content container height

update the svg height when matchMedia change triggers

Also, give the content-container a max-width of 1440px, and move the background color from the content-container to the block level.


Promote CoreDNSQueryRewriting feature gate to GA

How to categorize this PR?

/area networking
/kind enhancement
What this PR does / why we need it:
Promote CoreDNSQueryRewriting feature gate to GA and locks it to its default value (true).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

The `CoreDNSQueryRewriting` feature gate has been promoted to GA. It was already enabled by default and can now no longer be turned off. The feature gate will be removed in a future release.

/cc @DockToFuture @axel7born

/lgtm

/approve


Miss the default ACL option in the 'Manage Access' dialog for one ADLS Gen2 folder

Storage Explorer Version: 1.19.0-dev
Build Number: 20210313.6
Branch: main
Platform/OS: Windows 10/ Linux ubuntu 18.04/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to Reproduce

Expand one ADLS Gen2 storage account -> Blob Containers.
Open one blob container -> Create a new folder.
Right click the folder -> Click 'Manage Access Control Lists...'.
Check whether the default ACL option shows in the 'Manage Access' dialog.

Expected Experience
The default ACL option shows in the 'Manage Access' dialog.

Actual Experience
Miss the default ACL option in the 'Manage Access' dialog.

Verified on build 20210319.2. This issue has been fixed. So we close it.


Copy promble, both in edit window or terminal .

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:58:12.954Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

python
donjayamanne
0.6.0

xml
DotJoshJohnson
1.7.0

code-runner
formulahendry
0.6.15

changeEncode
lanmj2004
0.0.8

cpptools
ms-vscode
0.10.5

sublime-keybindings
ms-vscode
2.0.1

Steps to Reproduce:

open a large text in VScode
2.try to copy text over one page, then you can only copy part of it.

@Liudx1985 I can open a file which has more than one page of content and I can do select all (ctrl+a) and copy it entirely (ctrl+c). In other words, this works for me. Is there some more information you can include to help me reproduce?

Closing after a number of days without a response.


add extraAttributes in Navigation Group

Description
Adding support for extraAttributes, in NavigationGroup. I need to pass some CSS classes to specific navigation group
example usage:
return $panel
->navigationGroups([
        NavigationGroup::make()
            ->label('App')
            ->extraAttributes(['class'=>'highlighted']),
        ])

[ ] Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

[x] composer cs command has been run.

Testing

[x] Changes have been tested.

Documentation

[x] Documentation is up-to-date.

running composer cs cases weird issues and some code deleted! so I revert it

all done 👍

I've changed my mind, the attributes that apply to a topnav dropdown would probably not be useful to apply to a sidebar group, which is used on mobile devices. Let's replace extraAttributes() with extraSidebarAttributes() and extraTopbarAttributes()?

hey @danharrin .
np, should I create a new trait for extraSidebarAttributes and extraTopbarAttributes?
or add the methods in the NavigationGroup class

done, hope this what you have in mind! let me know.
also if can you double check the docs 06-navigation.md if needs improvement :)

Thanks


[GHSA-2j4q-9fff-236j] Apache Struts XSS Vulnerability

Updates

Affected products
References

Comments
Add patch links related to CVE-2016-2162.

I accepted https://github.com/apache/struts/commit/fc2179cf1ac9fbfb61e3430fa88b641d87253327 because the commit's purpose is consistent with solving the problem described in https://cwiki.apache.org/confluence/display/WW/S2-030.


Validate empty rays

Validate empty rays based on the number of elements. If ray_indices is empty, use the first ray and set its start and end to zero. This validation avoids errors and will not influence the training process when rays are empty.
Before:

After:

LGTM!


Highlight ready to complete withdrawals in withdrawal table

Story
As a user
I want to see which withdrawals in the withdrawal table are now ready to complete
So that I am prompted to withdraw
Acceptance Criteria

[ ] Withdrawals that are pending completion due to withdrawal delays and then become available to complete during the users session are highlighted.

Note: This ticket does not include the indicator in the tab
Tasks

[x] Explore and sketch
[ ] Team and stakeholder review
[ ] Visual Design
[ ] Dev
[ ] Test

Sketch

Additional details / background info

The available to complete timestamp can be calculated by using the created time stamp plus the delay timestamp.
If current time surpasses the 'available to complete' timestamp we can change the cell state to highlight it

We should also improve error message for a case when a user clicks on "Complete withdrawal" but it's not connected to any etc wallet - now it only tells "You're on the wrong network" which is true, because no network is wrong network but 🤣


 component appears in inspector but is blank/white (iOS simulator)

  <Image source={require('image!name')} />
When I run this, I think it's being recognized because the dimensions seem to be right, however it is blank.
   <Image source={require(./images/name.png)} />
I tried this initially but it throws an error saying that it cannot find the module. This error recommended I run three commands. I did not have any success after following facebook's instructions.
I completely remade the project and have recreated the same problem.

We are experiencing the same issue, but on an iPad Pro instead of the simulator. Did you find any workaround?


Add to README how to use MonitoringAspect

Feature scope
README
Describe your suggested feature
Would be great if README included the default setup on how to use MonitoringAspect as this is preferred to have add monitoring to each resource created.

N/A Seems this is covered as monitorScope.


body content is crammed to the left of the screen in chapter2:watchers

Adding the following to CSS the content of the page is crammed to the left of the screen when the modal opens, but why?
body.modal-open {
    overflow: hidden;
    position: fixed;
}

Sorry for the late reply. That shouldn't happen. Can you link me to your code and I will attempt to debug for you.

I solved that by  removing the second line, it should look like this:
body.modal-open {
    overflow: hidden;
}

Yes, this is an error. @meeglos solution is correct.


Importer: add SARIF format #3445

SARIF parser
SARIF represents a leap forward in the usability of static analysis tools. Many organizations in the safety and security communities use several competing tools on their code. SARIF will allow them to combine and compare the results more easily to gain a sharper picture of the issues in their code that need to be addressed. Engineering teams will be able to easily access a broad range of potential defects and vulnerabilities in compliance with privacy and accessibility standards. SARIF will support the development of products whose code spans languages and operating systems.
OASIS TC
Official Spec
Sample File
From spec github:
https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Documents/ScratchSamples/179-311.sarif
https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Documents/ScratchSamples/314-338.sarif

Thanks. Is there any way we can store/show what scanner is being imported? Maybe set test.title?

@valentijnscholten will work on that. I have few ideas. Basicaly SARIF carry a lot of details about the system that generated the report.
What do you wanna see in this title ?

@valentijnscholten I added the Test title data.
Could you assign this PR to me and review it?
Also, the Integration tests fail is the last commit. But it's a chrome related issue, no link with my modifications.

This format is interesting. I didn't know about it. Still thinking about how to best integrate it in defect dojo. Maybe we just merge this as a first iteration and gain some experience. In the end we may want to map the tool name / title to a specific test type in defect dojo so all tests of the same type can be grouped / deduplicated etc.

@valentijnscholten interresting point of view. Honestly from an implementation perspective I managed it like just another format to support. so My patch is ok :D
What you describe is more linked to the fact that more than one tool use the same format. So there should be a concept of "Tool" + "version" and some features around that.
Just to be clear, the dudplication works with this integration as I followed and implemented "file_path"+"line" + "title" + "cwe"

I see no problem integrating a first iteration as it stands today. The parser could possibly also support a zip file upload, which would then be extracted and imported if several sarif files are to be processed?
It could be the first parser to eventually be a sort of meta-parser.


Specify compilers only for cross-compilation

This should fix https://github.com/servo/saltfs/issues/683.

This change is

@bors-servo r+

:pushpin: Commit 48ec756 has been approved by SimonSapin

:hourglass: Testing commit 48ec756a6df510a85d6c671fbe8a737c939b92ac with merge ffd86d379ebc2d559a85d7ae58903e9fac721820...

:sunny: Test successful - status-travis
Approved by: SimonSapin
Pushing ffd86d379ebc2d559a85d7ae58903e9fac721820 to master...


weird behavior when opening vim in a wide window

I tried to take a screenshot:

That whiteish (should be red, I blame the theme) bar should be all one line on the far right. I have this problem at other scales as well. I haven't been able to reliably edit a file in vim because of this.
Edit: I guess I would say that it's not always rendering certain kinds of whitespace?

@jfhbrook Did you try in the curent master?

I tried master as of July 19th, and then walked away cause I had to do work.
If you think current master fixed this problem (knowing why you think this would be 💯), I can certainly try using vim with hyperterm sometimes in the next few days.

this is in latest master, and vim lines are super messed up (this is split pane). I imagine there's some character vim is using that's not been rendered correctly? or some term command

Fixed in our v2


Stop using object-literal-sort-keys

This rule is disabled in 133 files! Wouldn't it be easier to just disable it in the config?

omg please remove this. I can't even get the disabling to work well in vscode. To me, the ordering of imports is personal and up to the dev.

I would suggest to add a --fixer for this.
it would sort it as needed..
well ordered sorted keys in the code looks awesome :stadium: and clean.

I can't imagine anyone wanting this rule turned on without an auto-fix for it ...?  Would a feature-request bug to create the auto-fix for object-literals-sort-keys be helpful?

We generally accept auto-fixer contributions for all rules, so a separate Github issue tracking it is not necessary.
Note that this original ticket was filed to track the enabling of object-literal-sort-keys in this source repo, not in TSLint distributions.

We generally accept auto-fixer contributions for all rules

Auto-fixer for object-literal-sort-keys could produce very hard to debug errors. Read this https://github.com/prettier/prettier/issues/1096

I personally don't like this rule because sometimes it's not intuitive to write keys in alphabetical order. As an example if there is a schedule object,
{ start: '', end: '', frequency: '' }
order make more sense to me than
{ end: '', frequency: '', start: '' }.
I know it's a personal preference and that's the whole point to remove this rule from recommended preset.

any idea why this config would still have the rule applying and preventing me from compiling?
{
  "extends": ["tslint:recommended", "tslint-react", "tslint-config-prettier"],
  "linterOptions": {
    "exclude": ["config/**/*.js", "node_modules/**/*.ts"]
  },
  "rules": {
    "object-literal-sort-keys": false,
    "no-console": false
  },
  "jsRules": {
    "object-literal-sort-keys": false
  }
}

I personally don't like this rule because sometimes it's not intuitive to write keys in alphabetical order. As an example if there is a schedule object,
{ start: '', end: '', frequency: '' }
order make more sense to me than
{ end: '', frequency: '', start: '' }.
I know it's a personal preference and that's the whole point to remove this rule from recommended preset.

The rationale behind match-declaration-order is to implement this order.

The discussion here has gotten a little off topic 😊 closing for housekeeping purposes.
tl;dr:

If you don't want the rule, disable it in your tslint.json with an "object-literal-sort-keys": false" line
See https://palantir.github.io/tslint/rules/object-literal-sort-keys/ for configuration options that can make it more palatable


GVim:  not working when there is an insert-mode  mapping

Steps to reproduce
gvim --clean
set dictionary=/usr/share/dict/words
inoremap <c-k> <cmd>echom 'hello'<cr>

In insert mode, type "a", then enter <c-x><c-k> for dictionary completion.
Expected behaviour
Expected: A popup would show that displays completion items, matching the behavior of command-line Vim.
Actual: No popup shows, and the <c-k> mapping executes.
Version of Vim
8.2.4500
Environment
Kubuntu 21.10
Terminal Konsole 21.08.1
Value of $TERM: xterm-256color
Shell: bash
Logs and stack traces
No response

This appears to be specific for the GUI.  In a terminal it works OK.

Duplicate of #8799.
Regression introduced in patch 8.2.0851.

Regression introduced in patch 8.2.0851.

This patch is also responsible for https://github.com/vim/vim/issues/8792.

Regression introduced in patch 8.2.0851.

This patch is also responsible for https://github.com/vim/vim/issues/8792.

Does the patch for this issue also fix that one?
--
hundred-and-one symptoms of being an internet addict:
161. You get up before the sun rises to check your e-mail, and you
find yourself in the very same chair long after the sun has set.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Does the patch for this issue also fix that one?

Unfortunately, it does not.  However, it does fix https://github.com/vim/vim/issues/8799 .


More information in Spin API

We need the metadata information when GET a Spin

Can you define what metadata you need?


Cordon a tenant for maintenance

Describe the feature
Inspired by  the kube-anchor project, it would be nice to leave the cluster admin to "cordon" a tenant for maintenance during a Production Freeze Window.
Some possible use cases:

Avoid accidental resource modification(s) including deletion during a Production Freeze Window
During Kubernetes upgrade, to prevent any workload updates
During incidents or outages
During planned maintenance of a dedicated nodes pool in a BYOD scenario

What would the new user story look like?

The cluster admin has to schedule a Production Freeze Window for maintenance
He informs the tenant owners that their tenants will be frozen for a while. During this window, no CREATE/UPDATE/DELETE operations are permitted in the impacted tenants.
The cluster admin places a label to the tenant, eg.

$ kubectl label tenant oil capsule.clastix.io/cordon=enabled
tenant oil labeled

Expected behavior
When a tenant is cordoned by cluster admin, a Capsule Admission WebHook denies all CREATE/UPDATE/DELETE user's requests in the cordoned tenant's namespaces. A meaningful message should be displayed to the tenant owner informing that during the maintenance window, no CREATE/UPDATE/DELETE operations are permitted.

Seems an interesting feature, I'm just concerned regarding the ValidatingWebhookConfiguration required that would be a catch-all for all the underlying resources, doesn't look so confident to me.
I'm ok with the label, although since this change would require a new field in the CRD specification, we could add it effortlessly.

Got a question regarding this: should we block all API actions from any user or just the ones from the Tenant owner?
Because I'm thinking the case when QoS, PodPriority, and Preemption kick in: if we block all the requests, an anchored Tenant could disrupt other ones or the Kubernetes critical components itself.
The idea to avoid this sort of deadlock would be to block all requests except the ones with a Service Account coming from system:serviceaccounts:kube.

Also regarding deletion of a Tenant performed by a Cluster Administrator: should be it allowed when a Tenant is frozen?
I'd say no, an unfreeze would be required since it's the actor involved and they have to play by the rules.

I'm ok with the label, although since this change would require a new field in the CRD specification, we could add it effortlessly.

yes, label is effortless without change the tenant CRD

Got a question regarding this: should we block all API actions from any user or just the ones from the Tenant owner?

Imho, the latter one. The intention of this feature is to block write activity from tenant owners during maintenance windows, for example, cluster or dedicated node pools upgrade. In a multitenacy scenario, likely a public CaaS, it becomes hard for the cluster admin to keep discipline among all tenant users, emailing them id not enough.

The intention of this feature is to block write activity from tenant owners during maintenance windows, for example, cluster or dedicated node pools upgrade.

We should also block operations on behalf of the underlying Service Account, not only the Tenant Owners.


Update Owners

Owners file needs to be updated, based on the actual contributions.

/lgtm

/lgtm

/lgtm

/approve


Fix a bug in SPICE console init.

https://bugzilla.redhat.com/show_bug.cgi?id=1272454

@chessbyte : Nothing for travis to test on this one. I am fixing a silly cut-n-paste bug I made in previous fixes to this area. Would be nice to have this in.
For review/test, I can provide test credentials to RHEVM.

@martinpovolny In the future, if Travis is a no-op put [skip ci] somewhere in the body of the commit message.