Fix cmake and compiler warnings

This fixes the cmake warning about mismatched case in package search, proper case should be LibAIRSPY.
CMake Warning (dev) at FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (LibAIRSPY).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  FindLibAIRSPY.cmake:1 (INCLUDE)
  CMakeLists.txt:16 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

Also uses REQUIRED on find_package(LibAIRSPY) to get explicit error messages instead of failing implicitly later on.
-- Checking for module 'libairspy'
--   No package 'libairspy' found
CMake Error at FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find LibAIRSPY (missing: LibAIRSPY_LIBRARIES
  LibAIRSPY_INCLUDE_DIRS)

(Note the mention of LibAIRSPY_LIBRARIES and LibAIRSPY_INCLUDE_DIRS, case does matter for e.g. build scripts.)
Adds Clang compatibility for compiler options. Bumps to a minimum of cmake 2.8.12 (Oct 2013) so we can use
add_compile_options to proper order -Wall -Wextra vs -Wno-unused-parameter which add_definitions won't do.
This gets rid of all the warning: unused parameter 'foo' [-Wunused-parameter]

@guruofquality is it okay if I touch up the cmake build like this, possibly in other modules as well?
I might later add a Github Action to check PRs and report build warnings to contributors.

@guruofquality is it okay if I touch up the cmake build like this, possibly in other modules as well?
I might later add a Github Action to check PRs and report build warnings to contributors.

oh totally, that sounds great :100:


Unable to upgrade NK3 from v1.5.0 to v1.7.1 from latest nitropy

Traces of actions taken for replication under https://github.com/linuxboot/heads/pull/1684#issuecomment-2122930206 with logs provided there.

https://github.com/linuxboot/heads/pull/1684#issuecomment-2133784078


Multiple slugs for the same model?

I've seen that the field where slugs are stored is an array. Is it possible to have multiple slugs for the same model?
I couldn't find any documentation about this.

Have you tried using slug :xyz multiple times? It could just work. Lets document this or implement it, please contribute!


Remove Broadway integration

Broadway should integrate with the eventstore-client, like the symfony package does. I don't know the reason why it was designed like this, but eventually this should be reversed.
I'd gladly provide a pull-request to both packages. Additionally, the implementation of the Broadway repository is flawed since the order of events is wrong (newest events come first).

Ok, I'll extract its history using filter-branch and create a new repository for it. Stay tuned

I have talked to the guys from Broadway in the meantime, they agreed to this and actually wanted to contact you guys about this. So we're good to go! Not sure if I can get it done today, but certainly within tomorrow.


fix: handle 12AM when converting to local time

Issue #, if available:
Description of changes:
Problem: When the customer inputs 12AM in either the timestamp field or the date time field, the value would not persist and their field would reset to blank. This was because 12AM was being converted to the 24th hour by Intl.DateTimeFormat in chrome (related issue) and the datetime-local type input element could not handle this.
The workaround is to replace hourCycle: 'h12' with `
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #901 (541d780) into main (166f92b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   93.06%   93.06%
=======================================
  Files         117      117
  Lines        5047     5047
  Branches     1485     1485
=======================================
  Hits         4697     4697
  Misses        329      329
  Partials       21       21

Impacted Files
Coverage Δ

.../codegen-ui-react/lib/utils/forms/value-mappers.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166f92b...541d780. Read the comment docs.


optimize php functions call

refs: https://veewee.github.io/blog/optimizing-php-performance-by-fq-function-calls/

Thanks!
Do you use any tool to automaticaly update this or at least inspect code in order to check it?

you're welcome ;). I use this to check https://github.com/kelunik/fqn-check . There is also php backslasher but it also apply backslash to value like null or false https://github.com/nilportugues/php-backslasher

Thanks! ;)


Vqgan training

This is a draft pr for adding the vqgan training. It's still quite rough around the edges but might be able to do ok after some bug fixes.

Tested out on random noise and it runs. I'll try adapting to webdataset on some clusters and see how it does!

I found https://arxiv.org/abs/2212.03185 thanks to Laion(Ryu) which improves on movq.
The main ideas are

Add in perceptual loss from lower layers(which we are already doing)
entropy maximization so the codebook usage is 100%

I'm starting to add the projected gan technique from here. This seems to still have state-of-the-art in quite a few datasets although it is from 2021. The main idea is instead of plugging in images to the generator/discriminator, plugging in timm computed hierarchical features which makes training converge faster.

Other news is I was finally able to add the imagenet training dataset so I will be testing the movq/spectral norm added f16 pre-trained model soon


Fix bug in redirect function call

According to dojo/utils.py, the function redirect has 2 parameters.
https://github.com/DefectDojo/django-DefectDojo/blob/279debf699ed2512f0af53696df5b95bcf02597f/dojo/utils.py#L1670-L1674
This means that these calls are bugs:
https://github.com/DefectDojo/django-DefectDojo/blob/279debf699ed2512f0af53696df5b95bcf02597f/dojo/endpoint/views.py#L445
https://github.com/DefectDojo/django-DefectDojo/blob/279debf699ed2512f0af53696df5b95bcf02597f/dojo/reports/views.py#L321

I used isort. all the imports in all files are a mess. can we start to clean them?

I used isort. all the imports in all files are a mess. can we start to clean them?

yes, but in a dedicated PR.

yes, but in a dedicated PR.

@valentijnscholten fixed

@valentijnscholten fixed


Added XCode Environment for easy building and debugging on Mac.

Made this work a few months ago.  Might as well share it as I remember it being difficult to set up.

No updates for 1y now, closing


NameError in "tagger_proto_mlp.py" when running "main.py" [NameError: name 'dim_red_bool' is not defined]

Hello Mr. Hase,
I am working with your code from the "InterpretableNLP-ACL2020" repository and encountered a NameError when running the main.py script with the ProtoMLP model configuration. The exact command I used is as follows:
"python main.py --model ProtoMLP --save-name proto-20-push80 --push-after 80"
While the MLP model ran successfully without any error, when using the ProtoMLP model, I received the following traceback:
"Traceback (most recent call last):
File "main.py", line 117, in
tagger = TaggerFactory.create(args, data_encoder, tag_seq_indexer)
File "/content/InterpretableNLP-ACL2020/tabular/src/factories/factory_tagger.py", line 59, in create
similarity_function_name = args.similarity_function_name
File "/content/InterpretableNLP-ACL2020/tabular/src/models/tagger_proto_mlp.py", line 70, in init
self._initialize_weights()
File "/content/InterpretableNLP-ACL2020/tabular/src/models/tagger_proto_mlp.py", line 231, in _initialize_weights
if dim_red_bool:
NameError: name 'dim_red_bool' is not defined"
I am working on Google Colab, I followed the setup instructions provided in the repository, ensuring all dependencies were correctly installed.
I have tried to troubleshoot this further but have not been able to resolve the issue. As such, I am reaching out to you for assistance. Could you please help me understand what might be causing this error and how to resolve it?
Thank you very much for your time and any assistance you can provide.
Best regards,
Faiza Malik

Hi Faiza,
Thanks for raising the issue. It looks like this could have been from a forgotten assignenment self.dim_red_bool = dim_red_bool during initialization of the class. I just updated the file to do so. Could you try now?

Hello Mr. Hase,
Thank you for your quick response to my previous question.The initial error has been resolved. Unfortunately, I've encountered a new issue, a RuntimeError regarding tensor sizes:
"RuntimeError: The size of tensor a (50) must match the size of tensor b (16) at non-singleton dimension 1"
I made a change to the "_initialize_frozen_dim_red" function which appears to have fixed the issue. However, I'm observing a significant decrease in token-level accuracy. Could you please review the changes I've made and confirm if they are appropriate? Here is the updated function for your reference:
python
def _initialize_weights(self):
# ... other initialization methods ...
def _initialize_lin_layer(self):
    # ... other initialization methods ...

def _initalize_frozen_dim_red(m):
    if isinstance(m, nn.Linear):
        identity_like = torch.zeros_like(m.weight)  # Create a zero matrix with the same shape as m.weight
        identity_like.fill_diagonal_(1)  # Fill its diagonal with 1's
        m.weight.data.copy_(identity_like)

Any insight you could provide would be greatly appreciated, especially regarding the low token-level accuracy.
Best regards,
Faiza Malik

I'm not sure what the deal is with the frozen dim reduction, because it just looks like an identity transform. I'd have two recs:

Try not use dim reduction
Based on lns 232-233, make sure the code is using a random projection and not the _initalize_frozen_dim_red

Hello Mr. Hase,
I hope you're doing well. I've made the adjustments you recommended to the model configuration. Unfortunately, even after implementing those changes, I'm observing a token-level accuracy of 69.60%, which still falls short of the expected 81.90%.
Could you advise me on any further steps I might take to resolve this discrepancy?
Thank you for your continued support.
Best,
Faiza Malik

Hi Faiza, I'm not sure what the issue would be at this point. I would try replicating the results for the MLP model that doesn't use prototype features first to ensure that the overall training process is working correctly. If the standard MLP works but not the prototype MLP, you could try replicating results with text rather than tabular data. However, the tabular data is pretty simple and the prototype MLP should be competitive with the standard MLP there.


MIMXRT1060 custom board support for NXP HAL modules

Hi,
I have created a custom (out-of-tree) board for IMX RT 1061 based on MIMXRT1060_EVK Board.
I followed all the steps from this guide https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html.
The application builds but does not link to the NXP HAL from modules directory and returns an error: "...  undefined reference to `dcd_data'" whenever I try to configure the CODE_LOCATION.
choice CODE_LOCATION
    default CODE_FLEXSPI
endchoice

I have also noticed that there is a CMakeLists and hal_nxp.cmake files in modules/hal/nxp/mcux folder which adds more configurations and includes directories based on the known NXP boards.
for example,
#include device specific drivers
if (${MCUX_DEVICE} MATCHES "MIMXRT1[0-9][0-9][0-9]")
  zephyr_include_directories(mcux-sdk/devices/${MCUX_DEVICE}/xip)
endif()

elseif (${MCUX_DEVICE} MATCHES "MIMXRT10[0-9][0-9]")
   include_driver_ifdef(CONFIG_PM_MCUX_GPC        gpc_1        driver_gpc_1)
   include_driver_ifdef(CONFIG_PM_MCUX_DCDC        dcdc_1        driver_dcdc_1)
   include_driver_ifdef(CONFIG_PM_MCUX_PMU        pmu        driver_pmu)
endif()

What is the easiest way to add a new custom (out-of-tree) board to these make files?
I know I could probably create copies of the same files and use them in my board configuration. But it seems like a lot of work to make it work. I was wondering if NXP has a better, clean solution to do this.

following

Hi @Aragorn.Etiorir ,
As you found, Zephyr support for the NXP boards uses hal_nxp.cmake to include board-specific files into the builds for the in-tree boards.  This includes the dcd.c source file that is missing for your board build.  The board-specific files are pulled in from the MCUXpresso SDK folders in hal_nxp, using the variable MCUX_BOARD.  Once you create your own board and change the board name, this hal_nxp.cmake will no longer find these board-specific files.
These files are board-specific for a reason.  I would want to own those files, and keep them in my custom board folder, in my private repo.  Once located in your board folder, you can modify the CMakeLists.txt file in your board folder to include your board-specific files.  Based on the lines in hal_nxp.cmake using MCUX_BOARD related to RT1xxx, it appears these are the lines you want in your local board file.  Remove the board variables here, and just point to your files/folders:
if (${MCUX_BOARD} MATCHES "evk[b]?[bm]imxrt1[0-9][0-9][0-9]")
  list(APPEND CMAKE_MODULE_PATH
    ${CMAKE_CURRENT_LIST_DIR}/mcux-sdk/boards/${MCUX_BOARD}/xip
  )
  include_ifdef(CONFIG_BOOT_FLEXSPI_NOR driver_xip_board_${MCUX_BOARD}${MCUX_BOARD_MOD})
  zephyr_library_sources_ifdef(CONFIG_DEVICE_CONFIGURATION_DATA mcux-sdk/boards/${MCUX_BOARD}/dcd.c)
  zephyr_include_directories(${CMAKE_CURRENT_LIST_DIR}/mcux-sdk/boards/${MCUX_BOARD})
endif()

A good example of this is boards\arm\teensy4\CMakeLists.txt.  This is a board using the RT1062 that is not from NXP, and this file includes the local board source files.
Best regards


MSBuild properties for vcpkg directories

Are there msbuild macros to point to directories within VCPKG? I would hate to have to rely on developers/build servers having the same directory structure.
More specifically I have a project which uses libwebm and I need the libwebm.dll to get copied to the output of any project which references my project. Fortunately libwebm.dll is copied to the output directory of the project which references it so I can do a hack like the following to ensure it is always copied:
<ItemGroup>     <Content Include="$(SolutionDir)$(Configuration)\libwebm.dll">       <Link>libwebm.dll</Link>       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>     </Content> </ItemGroup>
However, another situation has come up with a managed C# project needing a copy of the binaries from a VCPKG port (OpenSSL). I would rather not have to copy these dlls into the codebase for the C# project. If there was a macro I could do something like the following:
<ItemGroup>     <Content Include="$(vcpkg)\packages\openssl_x86-windows\bin\libeay32.dll">       <Link>libeay32.dll</Link>       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>     </Content> </ItemGroup>

Hi @rossbrower,
For C++ MSBuild projects using either the user-wide integration or our per-project NuGet, we inject the targets file located at scripts\buildsystems\msbuild\vcpkg.targets. This targets file defines several variables of use; for your situation, I think VcpkgRoot would be the best, which expands to installed\$(VcpkgTriplet)\.
However, we have had issues in the past with trying to use this targets file in C# projects, so I don't think it is as simple as an <Include....
We'd like to improve the situation here, so more details about your particular scenario would be very helpful! How are you pulling in Vcpkg for your C++ project (user-wide, NuGet, direct targets file, manually)?

Thanks, I was poking around in the source and missed that targets file.
To answer your question I have been using the user-wide integration on the build server and on my development machine.
In the first case above I have a C++ project which wraps the libwebm port (to expose to C#). When this C++ project builds, the libwebm.dll is correctly copied to the output directory. However, the libwebm.dll is not copied to the output of C# projects which reference the wrapper. This is not a new problem for me with C# projects so the .csproj hack above works pretty well. It would be cleaner to use the macros which you've now brought to my attention. Ideally your targets file could do something similar so this hack is not needed.
In the second case, I have a C# project which uses P/Invoke to call the dll provided by the port. I need to pull that dll into the output of the C# project. The dll can't be referenced from C# so it must be added as content. Rather than putting the dll into the source code of the C# project I would like to pull it from the output of the VCPKG port. However, this location might be in a different place for different developers or on the build server. If I could use the macros from vcpkg.targets I could ensure that the dll is correctly copied to the output of the C# project and to the output of any other C# projects which reference it.
I hope that helps.

@rossbrower We do have $(VcpkgInstalledDir):
https://github.com/microsoft/vcpkg/blob/030cfaa24de9ea1bbf0a4d9c615ce7312ba77af1/scripts/buildsystems/msbuild/vcpkg.targets#L21-L23
does that give you what you need?

@rossbrower, please reopen this issue if it still be problem for you.
VcpkgInstalledDirectory (Installed Directory)


Adds support for pre fetching translations

Adds support for pre fetching translations which is about to expire.

@naueramant wow, much comment

@PaulFarver ;^)


Qingwei/ohlc streaming

Coverage decreased (-1.0%) to 39.796% when pulling e1a9241aa61463b5fbd10020dc3037869b85b479 on qingweibinary:qingwei/ohlc_streaming into a997028e277e62781a33107a3ec20b60d6a1a33b on binary-com:master.


Fails to build on Ubuntu 20.04

Following the console dump of the build error:
[  9%] Linking CXX shared library libplugin_manager.so
/usr/bin/ld: cannot find -lBoost::thread
/usr/bin/ld: cannot find -lBoost::system
/usr/bin/ld: cannot find -lBoost::thread
/usr/bin/ld: cannot find -lBoost::system
collect2: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/plugin_manager.dir/build.make:127: src/libplugin_manager.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:117: src/CMakeFiles/plugin_manager.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

I think that the libs that can't be found Boost::* result from the dependency to class_loader:
pkg-config --libs class_loader
-L/home/malte/Development/artemis/install/lib -lclass_loader Boost::thread\;Boost::system\;/home/malte/Development/artemis/install/lib/libbase-logging.so\;/usr/lib/x86_64-linux-gnu/libPocoFoundation.so\;dl -l -lbase-logging

i.e. class loader outputs a .pc file which contains incorrect entries.
I'm posting this here, as class_loader is a ros package with a complex branch/tag structure, and I can't judge which of these branches/tags are suitable for plugin_manager.
Per rock-core package set class_loader is currently set to indigo_devel branch.
Side note: the other library in my workspace that uses class _loader is envire_core.

The boost issue should be fixed by https://github.com/dfki-ric/tools-plugin_manager/pull/7.


Is there a way to retry failed tests a number of times

This will help us deal with some flakiness until we resolve the root cause.
is there something  like this: https://mochajs.org/#retry-tests ?

ok looks like this should work https://devexpress.github.io/testcafe/documentation/using-testcafe/command-line-interface.html#-q---quarantine-mode. closing.


ScrollWheelUp and ScrollWheelDown maps don't seem to work

nnoremap <c-ScrollWheelUp> echo "foo"
nnoremap <c-ScrollWheelDown> echo "bar"

Hold ctrl and scroll mouse, nothing happens.

interesting. Seems like control here is the missing bit. Does this work on other neovim uis?

Works in terminal. Not sure about other uis.

https://github.com/neovide/neovide/pull/968 finally got around to looking into this. @drzel if you are still interested, I would appreciate a test of this PR


Remove spaces after lim and log

Removes space after lim: lim_{4} instead of lim _{4} Fixes https://github.com/doberman/pearson-math-ios/issues/26
Removes space after log: log_{2}10 instead of log _{2}10
Version Bump to 1.1.3

~TODO in a separate PR remove space for all trig functions: cos(10) instead of cos (10)~

Merged another branch with the changes to remove the extra space for all trig functions Fixes https://github.com/doberman/pearson-math-ios/issues/21

Is this considered a problem as of now or is it more a question of making it look more readable in the code? All problems that are using these functions seems to work in the current version sent to mathpix and to the math engine.

In my review with Pearson, it seems to necessary for some special cases. Particularly around trig function with exponents.

In my review with Pearson, it seems to necessary for some special cases. Particularly around trig function with exponents.

@jonasbeck , you know anything about this? In any case, as long as this does not break any current expectations on the format we should merge it?

Closing this since #2 fixes all issues with lim


IGAPP-363: Hide NavigationTiles if only Local Information are displayed

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

This can be tested for example in Deutschlandvorlage 2019


Migrate extension-managed local (Docker-based) resources to use DIRECT connection type

We're currently using the LOCAL connection type, but we should switch to the DIRECT connection type (and continue using a static connection ID).
This will also require passing the new kafka_cluster_config and schema_registry_config objects and updating them when new resources are started, as we dynamically assign ports: https://github.com/confluentinc/ide-sidecar/blob/36d9bf4fbcca74eeff1093416488263e59cfee32/src/generated/resources/openapi.yaml#L574-L584

One problem here is we'll need to refactor how the resource loading works for the Resources view.
For each of the "Confluent Cloud", "Local", and "Other" items, they look up their associated connection types (CCLOUD, LOCAL, DIRECT, respectively) before firing off any resource-specific GraphQL queries.
Changing the local resources to use a DIRECT connection type will require updating the loadLocalResources() and loadDirectConnectResources() to instead filter by connection ID (include/exclude LOCAL_CONNECTION_ID) before fetching resources via getDirectResources().


How to migrate from local to server?

I couldn't find any documentation to migrate from local to server
Goal is to only backup and move necessary folders
All other files and folders (optional) are recreated from new pull
Which folder is used by Misskey to store files?
Which files are newly created by Misskey after initial setup?

If you are going to be migrating local to Server you really only need to be  taking the. /files folder. That’s where all the Photos and Videos are uploaded everything else is in the Database. I have moved a couple of times between servers and it seems pretty straight forward.

Rsync your Local /files to the server in the “misskey” folder. I moved about 50 gigs in no time.
Next Dump your Database and import to your new server.
then you can just finish the Misskey install as normal and when you INT the Database it should pick up right where you left off on the local server.

if you followed the Misskey Tutorial your files should be in /misskey/misskey/files

One folder and a DB dump is great news! I'll give it a try.
Thanks for sharing the details.

Ya, seems pretty simple. I would just get the server setup to step 5 and build Misskey. Then move your files and database into place. Updated your config for the new user on postgres and you should be good to go to finish off the install and get it running


Update cask commands

Brew cask  is no longer valid. These have been updated to brew  --cask to resolve errors and fix those functions.

Awesome, thank you @adamwhiles !


chore(CI): Remove coveralls

We're not using it at the moment, we don't have many inline tests
anyway.
Remove it to save some time on CI.

@not-a-robot r+


Unity3D environment

Hey
Do you plan to make a wrapper for Unity ml-agents ?

Hi,
We have looked into it in the past, but currently, unfortunately, we have no such plans. We would be happy to merge in a PR for supporting ml-agents, together with a preset solving one of the pre-built scenarios. Documentation for adding a new environment into Coach can be found here.


KE-42784 Fix vulnerability, Upgrade org.apache.avro:avro to version 1.11.3

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

LGTM

retest this please

ut重跑两次都还过不了，需要排查一下原因

retest this please

retest this please

环境问题，与版本升级无关，ut已过


Revisit ExchangeRateProvider instead of LiquidityCurve and LiquidityPoints

We need to revist the ILQP implementation and determine a proper interface for the LiquidityQuoteResponse.
Some options:

Create a more general interface for org.interledger.ilqp.LiquidityCurve that has functionality on it like getAmountFor(BigInteger sourceAmount). This would allow us to replace the implementation with either an ExchangeRateProvider or just a curve of BigInteger.
Move to ExchangeRateProvider in the actual interface, and use that for LiquidityCurves.
Don't use ExchangeRateProvider at all.

ILQP is no longer part of ilp-core. Closing this.


Content Management System for iGOT Karmayogi

Ticket Contents
Content Management System
A CMS that integrates with the iGOT Platform’s multiple portal (Learner, MDO, SPV etc.) and gives a flexibility to SPV to be able to update media content on the Platform.
Feature Value
SPV shall be able to update the following via CMS:

Banners on different Portal of iGOT
User Nudge Messages
Videos and How-Tos
Update Gyaan Karmayogi documents
Similar such media content on the platform

Feature Vision

The CMS shall give such level flexibilities to SPV so as to be able to update themes of the platform dynamically at any given point in time.
Portal shall be instantly updated with the changes with minimal delay.
SPV should not have to make full code deployments to make changes to the platform.

Goals & Mid-Point Milestone

Develop a Content Management System (CMS) integrated with the iGOT platform's multiple portals.
Empower SPVs (State Project Managers) with the ability to update various media content on the platform, including banners, user nudge messages, videos, documents, etc.
Enable dynamic theme updates for the platform, providing flexibility and customization options without requiring full code deployments.

Setup/Installation
No response
Expected Outcome

Improved agility in updating and managing media content across different portals of the iGOT platform.
Enhanced user engagement through timely and relevant updates to banners, messages, and media content.
Reduced dependency on technical teams for platform customization, leading to faster implementation of changes.

Acceptance Criteria

CMS successfully integrated with iGOT platform, allowing SPVs to access and update media content.
SPVs able to update banners, nudge messages, videos, documents, and other media content through the CMS interface.
Changes made by SPVs reflect instantly across the platform with minimal delay.
Theme updates can be applied dynamically without requiring full code deployments.
User feedback indicating improved usability and effectiveness of the CMS for content management.

Implementation Details
The project has to be built from scratch and is tech stack agnostic.
Mockups/Wireframes
No response
Product Name
Karmayogi
Organisation Name
MeitY
Domain
Learning & Development
Tech Skills Needed
Other
Mentor(s)
@Anushkabh
Category
Backend

@Vanshikabhatotia I wish to discuss the project as I'm unable to get an idea on what the project actually is. Could you please spare some time to explain me?

Hi @Vanshikabhatotia, @Anushkabh ,I'm Prefinal year student of B.Tech (CSE) and highly interested to work on this project I have previously worked on a Integration project using SQL as Database and have quite well knowledge of software engineering and am well versed with Tech like Python, Java, DBMS, WebDev and figma looking forward to get my draft proposal reviewed soon.

@jangir10  @GARVIT0203  go through the above ticket once. After this, if you have any doubt, ask specific questions , and I'll guide you.

@Vanshikabhatotia
hey, should we use wagtail CMS ?

Hi @Anushkabh @Vanshikabhatotia ,
I am Shubham Vishwakarma, a prefinal year BTech student with extensive experience in MERN, Django, ML, and Next.js. I am planning to leverage this experience to develop a custom Content Management System (CMS) for the iGOT platform. This CMS will be designed using the MERN stack and Next.js, enabling SPVs to dynamically manage and update media content efficiently across various portals. Here are the planned implementation details across different components, incorporating specific technologies:
Content Management:
->I will develop user-friendly interfaces using React and Next.js for updating banners, user nudge messages, videos, and documents.
->I plan to implement dynamic theme capabilities with MongoDB, allowing SPVs to change the platform's appearance without full deployments.
Integration:
->I will ensure seamless integration with the existing iGOT platform through secure RESTful APIs crafted with Node.js and Express.
->I intend to enable real-time updates across platforms using WebSocket technology, integrated into the Node.js environment for immediate content synchronization.
Testing:
->I will conduct extensive testing using Jest and React Testing Library to ensure responsiveness and performance of the CMS across all device types.
->I will implement security and data integrity tests, using Mongoose for MongoDB interactions to safeguard user data.
Documentation:
->I will compile detailed documentation using Markdown and Docusaurus, detailing the usage, features, and integration steps for the CMS.
->I will provide comprehensive code examples and best practices for future scalability and maintenance.
Publication:
->I will prepare the CMS for deployment using Docker, which will help minimize downtime and ensure continuity of service.
->I plan to set up CI/CD pipelines with GitHub Actions to automate testing and deployment processes.
This CMS is set to significantly enhance the iGOT platform's flexibility, agility, and user engagement, facilitating an efficient content management process. I look forward to your feedback and am eager for your approval to proceed with this crucial update.

This is starting example of CMS build from scratch for iGOT platform(will include the theme of iGOT)

@Anushkabh @Vanshikabhatotia hey, should we use wagtail CMS ?
Now, should you provide more details for integration of CMS and IGOT ?

yes you can use it

Hi @Anushkabh @Vanshikabhatotia ,
I am Shubham Vishwakarma, a prefinal year BTech student with extensive experience in MERN, Django, ML, and Next.js. I am planning to leverage this experience to develop a custom Content Management System (CMS) for the iGOT platform. This CMS will be designed using the MERN stack and Next.js, enabling SPVs to dynamically manage and update media content efficiently across various portals. Here are the planned implementation details across different components, incorporating specific technologies:
Content Management: ->I will develop user-friendly interfaces using React and Next.js for updating banners, user nudge messages, videos, and documents. ->I plan to implement dynamic theme capabilities with MongoDB, allowing SPVs to change the platform's appearance without full deployments.
Integration: ->I will ensure seamless integration with the existing iGOT platform through secure RESTful APIs crafted with Node.js and Express. ->I intend to enable real-time updates across platforms using WebSocket technology, integrated into the Node.js environment for immediate content synchronization.
Testing: ->I will conduct extensive testing using Jest and React Testing Library to ensure responsiveness and performance of the CMS across all device types. ->I will implement security and data integrity tests, using Mongoose for MongoDB interactions to safeguard user data.
Documentation: ->I will compile detailed documentation using Markdown and Docusaurus, detailing the usage, features, and integration steps for the CMS. ->I will provide comprehensive code examples and best practices for future scalability and maintenance.
Publication: ->I will prepare the CMS for deployment using Docker, which will help minimize downtime and ensure continuity of service. ->I plan to set up CI/CD pipelines with GitHub Actions to automate testing and deployment processes.
This CMS is set to significantly enhance the iGOT platform's flexibility, agility, and user engagement, facilitating an efficient content management process. I look forward to your feedback and am eager for your approval to proceed with this crucial update.
This is starting example of CMS build from scratch for iGOT platform(will include the theme of iGOT)

Go ahead and write a proposal .

@Anushkabh  Where is the repository's reference GitHub link located?


Make boolean "false" a valid attribute value

before:
 =>

after:
 =>

Useful for attributes such as draggable and for custom data-attributes.
The does not affect props like checked and they will continue work as previously.
Hope this change also decrease library size on a few bytes :)

I need to do a bit more testing to make sure this does not break other stuff.
Good job @frenzzy!

Oh.. looks like this PR introduces inconsistency between client and server side rendering because on server side we can't check if attribute belongs to element without whitelisting. It is much easier to just not render falsey attributes. See react-dom/src/shared/DOMProperty.js

After this PR only non-standard attributes will render false as a string:

 =>

<button disabled={false} /> => <button></button>

@SkaterDad I have a feeling this has been discussed before and we agreed with each other.

For some attributes, like disabled, it's preferable (to me) to remove it completely when false...

Why was that again? 🤔

@frenzzy This needs more tests and also more cowbell. 🐮🔔

@frenzzy After this PR only non-standard attributes will render false as a string:

Can you put tests to verify this?
When I code this:
    h('input', { oncreate: (el) => { el.setAttribute('disabled', false)} })

Chrome renders this, which is still a disabled element functionally:
<input disabled="false">

Yes, I'm scared about this change too. But do not have a real app to test this yet.

@SkaterDad there are check in code:
if (attributeName in element) {
  element[name] = value
} else {
  // use element.setAttribute
}

https://github.com/hyperapp/hyperapp/blob/c1a22ae45817f681a43059db27730d82d2704632/src/index.js#L140-L141

@frenzzy Thanks for pointing that out.   I must have missed that hyperapp distinguished between props and attributes again! :+1:
My use cases shouldn't be affected by this PR, then, since I'm not doing any SSR currently.

I gonna close this PR because it introduces mismatching between client and server side rendering and does not help in any case to render boolean false as a string to reserved DOM attributes like draggable, you need to pass "false" as a string anyway.


Remove hardcoded "[reakit]" string from warning()

Enable third-party callsites to use warning() for their specific warnings without tagging them as "[reakit]".
Closes #475
Does this PR introduce a breaking change?
Yes

warning()'s label argument has been turned into a regular message. Existing callsites should update the first message after the condition to include a label, if required.
Before:
warning(!!condition, 'Button', 'warning message');

After:
warning(!!condition, '[reakit/Button]', 'warning message');

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   95.23%   95.23%
=======================================
  Files          95       95
  Lines        1449     1449
  Branches      462      462
=======================================
  Hits         1380     1380
  Misses         69       69

Impacted Files
Coverage Δ

packages/reakit/src/Popover/Popover.ts
100% <ø> (ø)
:arrow_up:

packages/reakit/src/Tab/TabList.tsx
100% <ø> (ø)
:arrow_up:

...akit/src/Dialog/__utils/useEventListenerOutside.ts
92.3% <ø> (ø)
:arrow_up:

packages/reakit/src/Radio/RadioGroup.tsx
100% <ø> (ø)
:arrow_up:

packages/reakit/src/Dialog/__utils/useFocusTrap.ts
97.01% <ø> (ø)
:arrow_up:

packages/reakit/src/Menu/Menu.tsx
100% <ø> (ø)
:arrow_up:

...ckages/reakit/src/Dialog/__utils/useFocusOnHide.ts
100% <ø> (ø)
:arrow_up:

...akit/src/Checkbox/__utils/useIndeterminateState.ts
77.77% <ø> (ø)
:arrow_up:

packages/reakit/src/Rover/Rover.ts
94.73% <ø> (ø)
:arrow_up:

packages/reakit/src/Dialog/Dialog.tsx
94.59% <ø> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6befa...3a21cae. Read the comment docs.


about kitti odometry calib data

Hi, When I try to run the code, I see that there is no correct file for calib，and the link https://s3.eu-central-1.amazonaws.com/avg-kitti/data_odometry_poses.zip is about odometry. When I downloaded the Kitti Odometry dataset, its calib file reads as follows:

so, Can you provide the calib file that comes with the code?

@fzhiheng  I encountered the same problem. I find the calib file in /KITTI/calib/000000.txt, but It is not a calibration file for kitti odometry，I can not get right results for "camera2world_all" when use the calib file, and the python train.py running error.
can you give some advice about kitti odometry calib file? Thanks

The original calib file is from here. The purpose is simply to do a transformation from the camera pose to get the vehicle pose. The attached file can be used temporarily.
000000.txt

@fzhiheng  Thanks for your rapid reply.  The code runs fine on kitti seq 00.
The results are much worse on kitti than nuscene. bev_image  has very good results on nuscene.
The main reason for the poor effect is the fewer number of cameras (6 vs 2) or the lack of lidar？Thanks


Android: swap positions of search and mark read button

See https://getsatisfaction.com/newsblur/topics/android-swap-positioning-of-mark-all-as-read-and-search-buttons

The only gotcha here is that Android draws action bar buttons as a stack
out from right to left, in priority order. The most important buttons have
to be on the left, generally speaking. Thus, in order to make MAAR move to
the right of search, it means MAAR is less important and will be bumped off
the bar and into overflow before search on smaller screens. I judged MAAR
most important, so it is in a position to more likely be shown.
On 3 Feb 2016 2:05 pm, "Samuel Clay"<EMAIL_ADDRESS>wrote:

See
https://getsatisfaction.com/newsblur/topics/android-swap-positioning-of-mark-all-as-read-and-search-buttons
—
Reply to this email directly or view it on GitHub
https://github.com/samuelclay/NewsBlur/issues/873.

Is there a way to cheat a bit? Do you know if a button is knocked off? If you can find out, then swap positions so MAAR is first, otherwise make it second.

Did a bit of digging, and there isn't any above-board way around the order being defined all at once.  There might be some way to just not populate the menu at all until runtime, measure the screen, guesstimate what would fit, and then populate it in the preferred order.
That, however, has a code smell that reeks a mile away.  If we are truly unhappy with the default system menu behaviour, I think we should prefer just blowing away the system actionbar and replace the whole thing with something of our own (like we did for the actionbars in the feed list activity).  Of course, that flexibility comes with all the same pitfalls of what we did on the feed list w.r.t. needing to write some custom code, and potentially defeating accessibility features.
A third, cheaper option would be to force-draw the actionbar icons the way we want them.  If there isn't really room for both, it will start eating into the space used by the feed incon and feed title, potentially clipping either or both.

I'm fine with eating away at the title. Let's do the cheaper option by just force drawing those two icons.

Per a discussion we had elsewhere, we have a good motivation to roll our own title/menu bar for the story list just like we did with the feed list.  That will give us the flexibility to implement this just as we like.

This has been out in the wild for so long, I fear switching locations would be incredibly risky and we haven't had recurring complaints about ordering.  If we ever decide to re-do the story list menuing system, it will probably be a bigger overhaul than just this, to avoid confusion.


Expose transaction method

The transaction allows you to run multiple queries in a single transaction.
Example:
fastify.mysql.tx()

I can take this one if it is fine with you

Hey @cogluca, of course! Get in touch if you need need a hand.

Closed by #11


Update build.cmd to avoid usage of curl, and to instead shell out to …

…PowerShell, which uses Invoke-WebRequest.
This fixes issues on systems that either don't have Curl installed, or Curl is not in PATH.

Hi @aholmes, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@aholmes, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Thanks for the tip!

LGTM. @aholmes Thanks for contributing!


Include static for prefix _rc

Hi, I wonder if there is any possibility of being inserted in the "Prefix _rc" the "defaultProps" and put both as static? I cloned the repository and add a new prefix called "_rcd" with these changes .. thanks

@felisio If you have a solution then create a PR, because I'm not sure I understand what you are trying to achieve. A snippet is worth a thousand words :)


How to Programmatically Update Editor State in verbum

Hello verbum maintainers,
I am currently working with verbum in a React project and I have encountered a challenge with updating the editor state programmatically.
Goal: I need to update the editor state every 1 second with new content.
Issue: Based on my understanding, verbum does not seem to directly expose Lexical's editor.update() method or similar functionality, making it unclear how to update the editor state from outside the component.
Questions:

Is there a recommended way to programmatically update the editor state using verbum?
If direct manipulation of the editor state is not possible with verbum, could you suggest any alternative approaches or workarounds?

Any guidance or recommendations on this matter would be greatly appreciated.
Thank you for your time and assistance.
Best regards,
Jordan

Hello @jordanleewei,
You always have access to the latest instance of the editor via onChange method. Here is a minimal example for you to understand how to update the state;
export const UpdatingEditor = () => {
  const [editorInstance, setEditorInstance] = React.useState<LexicalEditor>();

  const onChange = (editorState: string, editorInstance?: LexicalEditor) => {
    setEditorInstance(editorInstance);
  };

  setInterval(() => {
    if (editorInstance) {
      editorInstance.update(() => {
        const root = $getRoot();
        const selection = $getSelection();
        const paragraphNode = $createParagraphNode();
        const textNode = $createTextNode('Hello world ' + Math.random());
        paragraphNode.append(textNode);

        root.append(paragraphNode);
      });
    }
  }, 1000);

  return (
    <EditorComposer initialEditorState={initialState}>
      <Editor onChange={onChange}>
        <ToolbarPlugin>
          <FontFamilyDropdown />
          <FontSizeDropdown />
          <Divider />
          <BoldButton />
          <ItalicButton />
          <UnderlineButton />
          <CodeFormatButton />
          <InsertLinkButton />
          <TextColorPicker />
          <BackgroundColorPicker />
          <TextFormatDropdown />
          <Divider />
          <InsertDropdown enableYoutube />
          <Divider />
          <AlignDropdown />
        </ToolbarPlugin>
      </Editor>
    </EditorComposer>
  );
};

Hello @jordanleewei, you always have access to the current instance of editor via onChange method, here is a minimal example for you to understand how to update the editor state;
export const FullEditor = () => {
  const [editorInstance, setEditorInstance] = React.useState<LexicalEditor>();

  const onChange = (editorState: string, editorInstance?: LexicalEditor) => {
    setEditorInstance(editorInstance);
  };

  setInterval(() => {
    if (editorInstance) {
      editorInstance.update(() => {
        const root = $getRoot();
        const selection = $getSelection();
        const paragraphNode = $createParagraphNode();
        const textNode = $createTextNode('Hello world ' + Math.random());
        paragraphNode.append(textNode);

        root.append(paragraphNode);
      });
    }
  }, 1000);

  return (
    <EditorComposer initialEditorState={initialState}>
      <Editor onChange={onChange}>
        <ToolbarPlugin>
          <FontFamilyDropdown />
          <FontSizeDropdown />
          <Divider />
          <BoldButton />
          <ItalicButton />
          <UnderlineButton />
          <CodeFormatButton />
          <InsertLinkButton />
          <TextColorPicker />
          <BackgroundColorPicker />
          <TextFormatDropdown />
          <Divider />
          <InsertDropdown enableYoutube />
          <Divider />
          <AlignDropdown />
        </ToolbarPlugin>
      </Editor>
    </EditorComposer>
  );
};

Hi, @ozanyurtsever! First of all, thanks for this library! 💯
Secondly, any news about this feature? I too would like to be able to use the Editor as a controlled component. If you don't have time to make the change I can try on my own to make a PR 😄


Lower case filenames for class files

We go through a category listing table, and generate a class file for each linked html file.
We should force the generated class files (unit_daf.dita) to be lower-case.
I don't know the best place to make this fix, but the following insertion of .lower() fixed it for me.  Note:  we may wish to switch the object to lower-case earlier in the process.
    file_name = os.path.basename(class_file_src_path.lower().replace(".html", ".dita"))
    file_path = f"{class_file_target_path}/{file_name}"

Drop this.  We need to maintain mixed case in order for maintainers to find files of interest.

Cancel this.  Lots of data-files use case as a separator WorkingSample.html, FranceLegacyBravo.html - they will lose their readability if we convert to lower-case: workingsample.dita, francelagacybravo.dita.


Infinite scrolling broken

I think something broke down in infinite scrolling after last update.
Today when I wanted to check unread posts when I scrolled down first page the second page loaded fine but then when I scrolled down second page it loaded again and then it kept loading second page over and over again.
Also I don't remember how it worked before but when I scroll down to next page the page counter on the top of the page is behaving strange (like it shows page number that is not always correct).
Also I noticed that now I have to scroll the page to the bottom and then scroll again to load next one (but I assume this is intentional for it to work like scrolling up?)
I don't have too much time to test it more so for now I'm just creating this issue as a reminder.

Hmm... I didn't get this behaviour when I was testing it myself, nor can I seem to replicate this. What do your settings look like?

At the moment like this:

I can confirm that with your settings, the bug does occur. I suspect it may have something to do with the Hide SCS option, as when I use your settings, but set it to not hide then the bug doesn't occur. Will need to do more testing to find a fix.


[Proposal]support aliases of repo names in requirements.yaml

Use case
If a repository has been added to the repository index with its repo name and URL, and the following command "helm repo list" outputs the mapping from the repo name to the repo URL, the full repository URL given in requirements.yaml should be able to be replaced with its repo name as an alias. The use of repo name as an alias will be a more effective and perceptive way to represent the full URL.
Specification
If the command "helm repo list" has outputs include the following mapping:
NAME  	URL
stable	https://kubernetes-charts.storage.googleapis.com/

The syntax of using a repo alias in requirments.yaml will be like this.
dependencies:
- name: mariadb
  version: 0.5.x
  repository: alias:stable

or like this.
dependencies:
- name: mariadb
  version: 0.5.x
  repository: @stable

Both "alias:" and "@" will be recognized as an alias representation of a repository.
When helm client loads the requirement.yaml, it will firstly examine the existence of the repo name and repo URL in the index file. If the repo name does not exist, an error will be raised to report unrecognized alias.

The implementation described above sounds great to me. If you would prefer to only implement one of alias: and @, that is fine. I will leave that up to you.
This would satisfy the last request in #1733.


Web adapter

If fcgi is not available to connect to (e.g. shared hosting) its possible with the web adapter to execute files trough http.

Can you add tests?

I've added a test but needed to refactor the adapter to be able to mock the http call.

@gordalina anything I can help you with reviewing (and merging) the pr?

@gordalina anything left I can do to get this PR merged?


chore: add leaf preimage handling for update

#57  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite

Merge activity

Apr 4, 3:42 AM EDT: @pepyakin started a stack merge that includes this pull request via Graphite.


Tooltip.js doesn't properly handle blur event on mobile

CodePen demo

No CodePen needed, since it does not work even on the homepage of tooltip.js
https://popper.js.org/tooltip-examples.html
Steps to reproduce the problem

Open the given homepage on iPhone and scroll to see "It just works Hover me to see 4 tooltips!" text
Touch this text and observe nothing

What is the expected behavior?
I expect that all 4 tooltips will show up (it works on Android, Windows Mobile and everywhere I could test except iPhone)
What went wrong?
Tooltip does not show up.
Any other comments?
Tested on iOS 6 with Safari, Chrome and Firefox and nothing.
It does work only when element is <a>

On iOS, the element needs to be focusable or clickable to trigger any mouse events.
So you'd need to add tabindex="0" / or make it a button (which should be done for tabbing/accessibility), or give it cursor: pointer. A quick hack is to apply cursor: pointer on the body element so that touching anywhere will fire mouse events, which makes it behave like Android.

tabindex = "0" did the trick and it Tooltip does show up, however I have a problem to actually close it now. Normally clicking outside of the element, tooltip should dissapear but it does not on iPhone. Any ideas @atomiks ?

Are you using Tooltip.js or Popper.js directly?

@FezVrasta, yes, like this:

let tooltip = new Tooltip(myElement, {
            title: myTitle,
            html: true,
            placement: myPlacement
            offset: '0,10,0,0'
        });

        element.tabIndex = 0;

@grzegorztomasiak as I said you need to add cursor: pointer to the body, which allows mouse events to occur anywhere on the page.
// A common test for detecting iOS
// You can also wrap this in `document.addEventListener('touchstart')` for futher confirmation
if (/iPhone|iPad|iPod/.test(navigator.platform) && !window.MSStream) {
  document.body.style.cursor = 'pointer'
}

@atomiks, I have tested that previously and it does unexpected behavior on the entire app, like blinking the whole body when you touch the screen so i cannot afford have those quirks on all mobile devices including iPhone.

Have you tried making -webkit-tap-highlight-color transparent?

Hi, I'm interrupting the development of the tooltip.js library to focus on the development of @popperjs/core (Popper.js v2).
Please consider switching to Tippy.js, which is a way better alternative to Tooltip.js and is well maintained. Tippy.js still uses Popper.js under the hood, so you will find all your favourite features.
I'll close this issue.


[Question]: Where do I set "View Header"?

Describe the bug
Thanks for your great plugin which reminds me a little bit to Tiddlywiki. ;-)
What do you mean with "View Header"? Where can I find and activate it?

Relevant errors (if available)
At the moment I don't see the symbols in the page header - but I have seen them before(!)

The problem occured, after I opened an other vault on my drive P:\

All icons were in the very first line of the window, hiding/overlaying the (here: green) buttons.

![image](https://user-images.githubusercontent.com/4138869/202280103-c6c4f56c-bfdb-4699-95e2-a515d7a45a6b.png)

When I scroll 1 mm down, I don't see this:

but this:

Steps to reproduce
I open Obsidian and there are no buttons anymore.
Expected Behavior
No response
Additional context
Installed Plugins:

Operating system
Windows

Found it:


SQL Blobs are not implemented in BQL.

https://github.com/probcomp/bayeslite/commit/b482b5128d33b0895f40013896834043a423db1e#commitcomment-13668077

Please add an example use case to the bug? Would be awesome if it related to Satellites.

No relation to satellites.  Blobs are octet sequences, and are written with x'0123456789abcdef' notation; see https://www.sqlite.org/datatype3.html for details.

Right, so why/when should we prioritize it?

As needed.  It is conceivable that one might want to operate on a database with blobs in it.  The need has yet to arise.

Then this sounds like a nice-to-have for the analysis milestone, where we expect people might try analyzing their own data, and expect support for their datatypes.


Feature/9316 scanner tab/9629 scanner button

Description
Introduces the new universal QR code scanner button in the tab bar. Also updates the existing tab bar items with the new images and home tab title.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-9629
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-9631
Screenshots

Is it only me or are these tab bar icons pretty android-ish/are those from android and get later replaced?


Review BPR

Description

Better explanation of BPR, in particular the pairwise ranking
Related Issues

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] This PR is being made to staging branch and not to main branch.

Codecov Report

Merging #1704 (ebd879f) into staging (4106333) will increase coverage by 23.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging    #1704       +/-   ##
============================================
+ Coverage     0.00%   23.41%   +23.41%
============================================
  Files           87       88        +1
  Lines         9132     9142       +10
============================================
+ Hits             0     2141     +2141
- Misses           0     7001     +7001

Flag
Coverage Δ

nightly
?

pr-gate
23.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

recommenders/datasets/mind.py
0.00% <0.00%> (ø)

recommenders/datasets/movielens.py
66.37% <0.00%> (+66.37%)
:arrow_up:

recommenders/datasets/download_utils.py
90.00% <0.00%> (+90.00%)
:arrow_up:

recommenders/evaluation/spark_evaluation.py
87.11% <0.00%> (+87.11%)
:arrow_up:

recommenders/models/newsrec/io/mind_iterator.py
0.00% <0.00%> (ø)

recommenders/models/newsrec/models/base_model.py
0.00% <0.00%> (ø)

recommenders/__init__.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4106333...ebd879f. Read the comment docs.

FYI @fazamani

@anargyri could you please review this again?


feat: add opencensus tracing/stats support

Fixes #109

@mayurkale22, would you be able to take a quick look at this PR to see if OpenCensus is being used correctly? Thanks heaps.

@mayurkale22 PTAL

@elharo PTAL

@elharo gentle ping

@BenWhitehead  @elharo  PTAL


How to edit URL directly inside address bar? How to change the order of address bar suggestions?

Is there a way to edit URL directly inside address bar without opening the full screen search?

How to change the order of address bar suggestions? (bookmark, history, search engine suggestions, etc)

These things are possible in Habit and in my opinion they are very nice. I couldn't figure out how to do these in Yuzu, excuse me if I'm wrong.

Item 2 is dup of Issue 22.


Poor compat with *EID mods

For *EID i mean NEID, JEID and the new REID.
This is a long lasting issue from the og lostcities that mcjty said it's not fixable. See https://github.com/McJtyMods/LostCities/issues/308
So it may still be a dead end even for Squared, however imma just put it here for possible luck.
I also opened an issue on REID's side since it's an actively maintained modern fork of JEID.

Dev-5 is adding another check for REID to disable optimized chunk gen, as currently it only checks for JEID and NEID.
Im also 90% sure the palette system needs a rewrite, as its very hardcoded and bad, but that's gonna take a hot minute
Thanks for making a bug report! I wasn't even aware other people are were using this!


How to change Camera from Master in KVS

I have used WebRTC Sample Demo. It works really well in my machine. I would like to modify a bit further. in this process, I want to change camera to be streamed. I want to start streaming from a camera which is connected(wired or wireless) to my machine instead of my webcam. Is it possible? Or it would be better If I have option like streaming from an RTSP or HLS. Any hint would be Appreciable.

@thasin96 yes, this is possible. What you need to do is simply enumerating the connected devices using, https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/enumerateDevices. Then, you can find the device that you're interested in, and extract the device id. Later, when you call getUserMedia, make sure that you specify the device id, https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints.

Since the issue has gone stalled, I'll mark this as resolved. Please feel free to reopen it for further assistance!

Hi @lherman-cs
Could you explain how can I read images from a folder and upload it from one device to a Kinesis Signaling channel?
Actually, the use case exactly is an autonomous mobile robot and I'm trying to stream the video data to AWS Kinesis Signaling channel but I'm not able, so I'm thinking to use rosjs with this sdk to stream the data to the signaling channel.
Hope you'll be able to help with this use case.

@mhaboali signaling channel is used for signaling and not data or media transfer. Perhaps you want to cut a new issue and detail your scenario. Take a look at the samples. Also, not sure what you mean by send images. Do you have your encoded video frames on the drive somewhere? Is this similar to the master sample application scenario from the Embedded WebRTC C SDK?

Thanks, @MushMal for the explanation!
Yeah, I'm looking for signaling the robot's video stream to be viewed in realtime from the user's side. I'm trying to do exactly what this pkg does but this pkg works only with the normal Kinesis Streams not-WebRTC and it has around 4 seconds latency.
Yeah, I've checked that WebRTC C-sdk but I can't run this example with ROS which uses C++ and OOP stuff, so my idea is to use this js-sdk instead of c-sdk.

And for the encoding, I'm using this pkg

The issue is that JS solution is not really an implementation of a WebRTC - it's an implementation of a signaling with the built-in WebRTC so you might not be able to access the media pipeline.
You could think about using data channel to send your stream but then the question is whether you want to build all custom solution afteral. Anyway, this issue is already closed and is irrelevant to your case. Please do some research and cut more targeted issues to get more help

Ok got what you mean, I thought it's related because it's about changing the camera source. Alright, I'm opening a new issue as suggested.
Thanks for your help/time :)


Modified convertedToSnakeCase to match the Xcode behaviour

There is no unanimous agreement on the right way to treat numbers while converting to snake cases.
”PDF2Text".convertedToSnakeCase could have been giving pdf2text, pdf2_text or pdf_2_text.
Today, the second option is used but, arguably, according to the development tools on the Mac platform, the last option seems to be more natural.
Indeed, when increasing, sub-word by sub-word, the selection of this camelCased formatted identifier (1), Xcode will detect 3 parts : PDF, 2 and Text — hence this modification proposal.
(1) check by placing the caret at the beginning of the identifier and, holding down the alternate and shift keys simultaneously, press the right arrow key.

Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

I agree that it's hard to say which outcome is correct, primarily because we don't know whether the number is an independent entity, as in PDF2Text, or if it belongs to the preceding or following word. Given that, and based on some highly scientific polling data, I agree that the default should be to switch to your second option.
That said, this would be a breaking change (not source-breaking, but interface-breaking) for existing users of the library, so I'm going to wait a bit before integrating this.

@fblondiau On further consideration, I've decided to not take this change at this time. While I can see the argument in your initial post, there are plenty of counter-examples that are made worse by breaking before numbers. In addition, the current behavior matches the behavior of JSONDecoder/Encoder, so it is the most consistent behavior for users, if that claim can be made of any default behavior.
Thanks again for opening this PR!


[jss-default-unit] feature: use is-number to be able to accept strings

you can use http://npm.im/is-number ;] But be aware of that it have bug currently (https://github.com/jonschlinkert/is-number/issues/3) and returns true for ' '.

It wasn't necessary so far. Currently if you want to get a default unit, use numbers. Let's see if cssx will get the fix soon https://github.com/krasimir/cssx/issues/6

I think we should auto add units to numeric values. Not touching a string gives us a way to avoid auto unit plugin. Closing it for now until this becomes a problem.


NullReferenceException in ControllerFinder.OnEnable when using the HoloLensCamera

This occurs due to there not being a motion controller attached to the camera.
The fix is to check whether or not the motion controller singleton has initialized rather than assuming it is safe to use the instance.
Mixed Reality Toolkit Release Version
2<IP_ADDRESS>

The HoloLens camera prefab is depreciated.
Probably best to remove.

@StephenHodgson,
While I agree that the HoloLens camera should probably be removed, we should still harden the controller finder, in case someone removes the controller from the MixedRealityCamera prefab (ex: HoloLens only projects)

People shouldn't be removing things from prefabs anyway.

Using the MixedRealityCamera prefab will also cause this issue (though it might be good to deprecate that as well and going down to one configurable camera prefab instead).

@StephenHodgson, it could be argued that if people are removing things (that they don't need or that their target platform does not support) from prefabs the prefabs have too much on them by default.

Yup, that's why we're taking the configuration profile approach in vNEXT.

This was released in the 2<IP_ADDRESS> release candidate


Porting linux builder to windows

This branch fixes Linux App Builder on Windows and Linux Simulators.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How can change filter condition from equal to contain?

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Your Environment

Tech
Version

Material-UI

MUI-datatables

React

browser

etc

Like I have a filterOptions ['WA', 'CA'. 'NY'] with multiple select type,  the target column has a combination string, like "WA, NY", when I choise WA, the "WA, NY" is not returned as expected. Could you please help?

thank you~~ping!!

You cannot do this at the moment, but the functionality is on its way, as this relates to an older issue: https://github.com/gregnb/mui-datatables/issues/430#issuecomment-493275272.

thanks Gabriel!

This should be available as of 2.4.0 via filterOptions with the new logic option, which allows you to set custom filter logic. I can re-open if there's a different use case here.


Twitter cards still rendering old logo

Twitter cards are the previews you get when you share links on twitter.
You can check them at https://cards-dev.twitter.com/validator
Every sign page URL I enter pulls the old logo.

Needs to be updated here https://github.com/MoveOnOrg/mop/blob/751fd2f0e5d918cc525a0130b5545a3f411f9991/petitions/template_context.py#L21


Can i use delay before play media file?

@dekardkrr
currently there is no option to add delay before media file is played.
but you can insert silence at the start of your media file like this:
$ sox input.wav output.wav pad 5 0

(adds 5 seconds of silence to the beginning).
NOTE: next time please include a bit more information in the description :)
it is a bit hard to try to guess what you want from just one line of text.


Add an ES module entrypoint

Once/If #252 lands, this will let module-aware bundlers (Rollup, Webpack 2) do tree-shaking stuff. I'm showing this shaves off a KB or two from bundle sizes, which is always a good thing.

OK, rebuilt this against v3 instead. Webpack 2 and Rollup are picking up steam, so this should be helpful when v3 lands.

Thx!


Pass the full event object as $event to ngClick and ngSubmit callbacks

Angular's ngClick and ngSubmit directives expose the full event object as $event within the scope of the expression. Using promise-btn breaks this and passes just the string 'click' or 'submit' instead. This patch fixes this behaviour.

Coverage remained the same at 100.0% when pulling 88798cde241eed100cd8c28be531881559e67a05 on georgiyordanov:master into 48958de5efb24c47dbd20b634b5186474e4d1dcc on johannesjo:master.

Thank you very much!


Resolve annotated outputs using MRO

Fixes #328

[x] Adds test

Looks good and tests are green. Merging.


Update JAVA version

Updating the Java version from 1.6 to 1.7 to resolve the error "com/uphyca/gradle/android/AndroidAspectJPlugin : Unsupported major.minor version 51.0"...

Hi, thank you for your contribution.
However, this project is no longer maintained, please use other libraries instead, like https://github.com/HujiangTechnology/gradle_plugin_android_aspectjx


Fastembed v2

Closes #5 ONNX Support
Closes #22 torch optional

fastembed as backend besides ct2 or torch
returns "backend"
makes torch an optional dependency
calculates "min" sleep time dynamically on startup
default model is now "BAAI/bge-small-en-v1.5"

Hello, is fastembed always supported as backend ? i can't see it

@dev1ous It has been discontinued, as optimum was providing a near identical option.

@michaelfeil Well you totally true ! and actually infinity is incredible useful for me cause i run my dense model on optimum !
But i was thinking more about some "exclusive" solution provided by Qdrant, like BM42 for example.
Its a been difficult to totally extract the solution from fastembed as the IDF part for example is done inside the engine.
Well i think at the end i could just adapt infinity to reimplement fastembed but i was just curious about your opinion on it


Update Composer dependencies (2023-07-29-00-12)

Visual regression test passed!
View the visual regression test report


Dispatch from reducer?

Hi - first of all, this library is great, and I hope you keep working on it. I'm kind of a beginning in swift development, and this is realllllly helping me get my feet under me.
I was wondering if it was possible to dispatch from a reducer function? My current playground use-case is there is a single AppState, and it has a bunch of sub-states. Each substate initializes itself, and the AppState keeps track of the master "the whole app is initialized" boolean. It also has a list of strings of the overall state of each sub-state init. So, when each sub-state changes its init status, or the list of strings describing it, I wanted to dispatch to the main app state to go inspect each sub-state, and update the global init flag and set of init messages to display.
Obviously, I might be thinking about this all wrong, and there's already a solution for this that I'm not picking up on. If so, my apologies, and a pointer to that would be greatly appreciated.
Again - keep it up, man. This is great.

Hi, and thank you! It does sound like you might be doing too much work managing state. If you haven't seen it, you should take a look at my todo reference app. The AppState in that example is a struct that contains substates as properties. Each substate is initialized in its parent's init function.
The idea is that you have a single store with a root state. This state propegates changes down to substates using pure functions (reducers) like branches on a tree. It may sound expensive to rebuild the tree each time an action is dispatched, but Swift is very good at managing the memory of value types like structs. In fact, it's so good that SwiftUI was built around it.
I may need to see the code you've written to completely understand. Maybe your substates are lazily loaded some how?

Yes, the substates initialization are async - they get values from an api, perhaps. In my case, they start an audio engine (audiokit.io), and retrieve stuff from firebase. So, i have an init spinner screen when the app starts, where it (currently) is monitoring a single boolean in the root state. As each of the sub-states finish their init, I'd like to dispatch an action that says "update your global app init state".
Alternatively, my init screen could monitor each of the sub-states init flags, but it feels cleaner to me to keep the overall app in one flag, know what I mean? Also, it feels like this might be a pattern useful for other things - when one action is handled, I might want to dispatch other actions that follow on from it.
For far-left-field reference, I've been doing frontend web stuff with clojurescript and re-frame (https://github.com/day8/re-frame) which allows this. I'm of course not saying you necessarily should follow that pattern, but it's been super useful to me. I also don't have 100% grasp on Combine yet, so this might all be something I just don't know yet.
I can try to come up with a simple example of this, if you think it would be helpful in any way.
Thanks!

I initially designed this library around redux and elm, but I'm open to what works best with SwiftUI. I've heard of re-frame, but haven't used it myself.
With the library as it is, it sounds like it might be useful to have two actions that are placed inside an action plan. One action initiates the substate, and the other action tells the root state about it. Events from the auditkit.io API can then dispatch the action plan.
Another route would be middleware that subscribes to store changes. It would dispatch an action to notify the root state whenever the substate is initialized.

Yep, after some experience, I think I'm in good shape. Thanks so much for your help, and your library.


BP Vehicle not defined in BlueprintLibrary carla ue5

I'm using carla on unreal engine 5.3
Not all the bluperint of vehicle can be spawn because they are not defined in the blueprint library.
Like for the Tesla, the blue print is existing but not in the world.get_blueprint_library() so we can not spawn it.
even if we add it in the VehicleFactory, it don't take the changes into account.
I wanted to know how we can add these vehicle like the tesl or the toyota into the bluprint library ?

Hi,
In version 5.3, we updated and improved some of our vehicles to better align with the enhanced visual quality of Town10. While we’ve added a few unmodified vehicles to maintain diversity, we also removed some older or low-poly vehicles from the Vehicle Factory.
To add a vehicle to the factory, the process has changed. You now need to recreate the entire Blueprint for the vehicle, as the existing one is not compatible due to the switch from Chaos to PhysX. Once the new Blueprint is created, you can add it to the Vehicle Factory.
To do so, you’ll need to use the VehicleParameters.json file, where all the necessary parameters for the vehicle should be defined.
Let me know if you need further clarification!


WordBazaar - create vote steps design

closed with https://github.com/aeternity/superhero-ui/pull/974

closed with https://github.com/aeternity/superhero-ui/pull/974


Isolate runs and steps feels mostly frustrating

I'm continually surprised by the behavior of steps limiting visible runs to those run by the steps parents. This very much defeats the use of --needed to skip re-running upstream runs. To get --needed to work you need to set isolate-runs to no for both the upstream step and all of the downstream steps that use it. That's frustrating.
Possible changes to address this:

Change the default isolate-runs to no and require explicit set to yes to enforce isolation. This would make --needed work out of the box.
Provide a default-isolate-runs operation attribute that can be used to no to avoid this.

I think option 1 is better.

This problem actually applies at the command level. The decision to run or re-use an existing run is a matter of knowing what runs already exist. The operation definition has no idea. This should probably be a run option --isolate-xxx (this applies to steps as well as batch parents - e.g. in the case of optimization runs).


Il mismatch between 'P1' version '20221215' and 'P2' version '20220715'

Description
This is the same error that appeared a while ago (#6107) after updating the runner image, just with newer versions. I guess there is again a component update for VC missing to match compiler and Visual Studio version.
I did not found a current equivalent to #6091, but I guess these repos have the same issues as well.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
20230625.1.0
https://github.com/widelands/widelands/actions/runs/5424202817/jobs/9870401742
Is it regression?
20230612.1 https://github.com/widelands/widelands/actions/runs/5370020940/jobs/9741885143
Expected behavior
Linking should succeed.
Actual behavior
NMAKE : fatal error U1077: '"C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --intdir=CMakeFiles\test_ai.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests -- C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1435~1.322\bin\HostX64\x64\link.exe /nologo @CMakeFiles\test_ai.dir\objects1.rsp @C:\Users\RUNNER~1\AppData\Local\Temp\nmE99E.tmp' : return code '0xffffffff'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\nmake.exe" -s -f src\ai\test\CMakeFiles\test_ai.dir\build.make /nologo -SL                 src\ai\test\CMakeFiles\test_ai.dir\build' : return code '0x2'
Stop.
glbinding.lib(functions_d.cpp.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
fatal error C1900: Il mismatch between 'P1' version '20221215' and 'P2' version '20220715'
LINK : fatal error LNK1257: code generation failed
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\nmake.exe" -s -f CMakeFiles\Makefile2 /nologo -S                  all' : return code '0x2'
Stop.
C:\ProgramData\Chocolatey\lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\bin\strip.exe: './src/widelands.exe': No such file

Repro steps
I guess it affects other Visual Studio builds as well.

Hello @matthiakl, thanks for reporting. We will investigate possible issues with latest VC version not being picked up.
Could you try following workaround?
- run: |
          Set-Location "C:\Program Files (x86)\Microsoft Visual Studio\Installer\"
          $InstallPath = "C:\Program Files\Microsoft Visual Studio\2022\Enterprise"
          $componentsToRemove= @(
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ARM"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ARM.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ARM64"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ARM64.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.x86.x64"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.x86.x64.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ATL"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ATL.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ATL.ARM"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ATL.ARM.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ATL.ARM64"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.ATL.ARM64.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.MFC"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.MFC.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.MFC.ARM"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.MFC.ARM.Spectre"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.MFC.ARM64"
            "Microsoft.VisualStudio.Component.VC.<IP_ADDRESS>.MFC.ARM64.Spectre"
          )
          [string]$workloadArgs = $componentsToRemove | ForEach-Object {" --remove " +  $_}
          $Arguments = ('/c', "vs_installer.exe", 'modify', '--installPath', "`"$InstallPath`"",$workloadArgs, '--quiet', '--norestart', '--nocache')
          # should be run twice
          $process = Start-Process -FilePath cmd.exe -ArgumentList $Arguments -Wait -PassThru -WindowStyle Hidden
          $process = Start-Process -FilePath cmd.exe -ArgumentList $Arguments -Wait -PassThru -WindowStyle Hidden

Yes, with the workaround it does compile (https://github.com/matthiakl/widelands/actions/runs/5447149035/jobs/9908868829)

There seems to be an ongoing issue with how Microsoft.VCToolsVersion.v143.default.txt is defined when multiple VC tools workloads are available. We also had issues with some broken workflows on 14.36* VC tools, so 14.35* was added back. Depending on your build tool, there should be a way of specifying which VC tools version to use or unnecessary workloads can always be removed on runtime.
I will close the issue, feel free to reach out in case of further concerns.


Organization signup should tell them where to go if they are in the wrong place to signup

Current error if I signup with a non-org email address,

We should make this more clear and tell them, "If you are not part of NYU, please go to cartodb.com/signup to create a free account"

It's there, but looks like dissapearing in the mobile view @matallo

actually it's there both on desktop and mobile, we can add an error field below, as well as the current header warning


fail on file not found for shim reconnect on containerd restart

Previously for windows, when containerd restarts and attempts to reconnect to shim pipes, if the pipe file is not found for a shim, containerd would wait up to 5 seconds before returning a failure. If containerd is still attempting to connect to shims after 30 seconds, the windows service manager will kill containerd. This work breaks up the cases of connecting to shims into two cases: shim starting and shim reconnecting. In the former, containerd will still wait up to 5 seconds for a pipe to be served by a starting shim. In the latter, containerd will return file not found immediately when attempting to connect to a nonexistent or dead shim.
Signed-off-by: Kathryn Baldauf<EMAIL_ADDRESS>

Codecov Report

Merging #3659 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3659      +/-   ##
==========================================
- Coverage   42.39%   42.34%   -0.05%
==========================================
  Files         127      127
  Lines       14048    14063      +15
==========================================
  Hits         5955     5955
- Misses       7193     7208      +15
  Partials      900      900

Flag
Coverage Δ

#linux
45.9% <0%> (-0.01%)
:arrow_down:

#windows
37.23% <0%> (-0.05%)
:arrow_down:

Impacted Files
Coverage Δ

runtime/v2/shim/util_windows.go
0% <0%> (ø)
:arrow_up:

runtime/v2/shim/util_unix.go
0% <0%> (ø)
:arrow_up:

runtime/v2/shim_unix.go
77.77% <0%> (ø)
:arrow_up:

runtime/v2/shim_windows.go
17.77% <0%> (ø)
:arrow_up:

runtime/v2/shim.go
1.18% <0%> (ø)
:arrow_up:

runtime/v2/binary.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87bff67...b4211d9. Read the comment docs.

LGTM


How will namespaces affect auto-generated runtime APIs, such as P4Runtime API, TDI, etc.?

The most straightforward answer to propose that I can think of is that the user's P4 program is the default namespace, and then use the full namespace name as a prefix to any objects imported from a namespace as part of the default name that is auto-generated as part of such a runtime API.
The @name annotation already exists for allowing developers to override these default name choices, which works well for their own P4 code in files they write, but does not seem like a workable solution for code in namespace written by others that one is importing.
More examples of actual proposed uses, and any problems that arise, would be more useful here, I believe, than making general statements in the absence of examples.

Example of a hopefully weird corner case that no one will want to hit, but I wanted to raise the question at least.
Suppose someone creates a namespace ns1 that defines an action a1 with an annotation @name("custom_action_name").
Someone imports ns1, and also in their program they have an action a2 with annotation @name("custom_action_name").
Should this be a compile time error?  Or at least an error in the part of compilation that generates a file like P4Info for P4Runtime API, and/or similar files for TDI or other control plane API?
If it isn't a compile time error, what do you expect to happen in this case?
Similarly if two actions or tables in different namespaces have the an @id(<some_integer>) annotation with the same number in different namespaces.
My first reaction on thinking about this is that if someone asks for conflicting ids or names, then that should be an error while attempting to generate the appropriate control plane API files.


Reduce code duplication in workloadannotator

We added support for SELinux profile binding:https://github.com/kubernetes-sigs/security-profiles-operator/pull/854
However, there are some code duplications in
https://github.com/kubernetes-sigs/security-profiles-operator/blob/de3017ad869867efb9743a1c387398e7741fd3cc/internal/pkg/manager/workloadannotator/workloadannotator.go#L200
Since we will also add profile binding in the future for AppArmor. Under the current method, we will have more duplication.
we should create an interface that all security profiles that support bindings would implement and then pass a variable implementing that interface to the update function.

/assign Vincent056

Awesome, thank you for considering to work on this @Vincent056! :pray:

/remove-lifecycle stale
@Vincent056 I propose we look at this after in ~3 weeks (after our upcoming sprint)

/remove-lifecycle stale


Migrate Docker check to generic metrics provider

What does this PR do?
Migrate the docker check implementation to the new generic processor. Being one of the first implemented, the docker check is one of the most complete one and does report more metrics than its generic container counterpart.
To deal with that while allowing to reuse the new infrastructure, an extension mechanism was put in place.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
The change is pretty significant. The docker check being used widely, the QA needs to be thorough.
The list of generated metrics can be found in the unit tests (seepkg/collector/corechecks/containers/docker), the idea is to verify the correctness and the backward compatibility by:

Deploying a version N-1 Agent for 1 hour
Deploying the new version N Agent for 1 hour
Comparing the metrics reported (no change is expected)

It must be done on several environments (Docker, ECS, Kubernetes) + Windows.
I can share a Notebook to help validate.
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] The appropriate team/.. label has been applied, if known.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[x] If applicable, the need-change/operator and need-change/helm labels have been applied.
[x] If applicable, the config template has been updated.

@djmitche I think you're the only left with comments so that I can merge this PR


.NET Core runtime has no implementation of ApplicationException

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I'm closing this as I fixed this in a previous commit (thus a merge conflict) thanks for submitting this fix :)


Inconsistency between package.json and package-lock.json "name"

package.json:
https://github.com/readium/readium-desktop/blob/a39e7dfbeffa0d8c33f5d0cbe0dbe875e41d1136/package.json#L2
vs. package-lock.json:
https://github.com/readium/readium-desktop/blob/a39e7dfbeffa0d8c33f5d0cbe0dbe875e41d1136/package-lock.json#L2
Also note src/package.json:
https://github.com/readium/readium-desktop/blob/a39e7dfbeffa0d8c33f5d0cbe0dbe875e41d1136/src/package.json#L2
My guess is: the package-lock.json is out of date, it should really always correspond to its associated package.json. I recommend rm -rf node_modules && rm package-lock.json && npm install to ensure the latest minor dependency updates are pulled into the project. I have done this in the Pull Request that updates the r2-xxx-js packages:
https://github.com/readium/readium-desktop/pull/234
Also note the fix for TypeScript strict checking:
https://github.com/readium/readium-desktop/commit/3e36af097c7d6f5d1aa1da60fd1a54d1552e5d0c

Also note the version mismatch: 1.0.0-alpha.4 vs. 1.0.0-beta.1.

FYI: this has been fixed in a recent merge (updated package-lock.json).


TFRS - Prevent fuel suppliers from creating draft compliance & exclusion reports for 2024 and beyond

Describe the task
Remove the ability for BCeID users to create draft compliance & exclusion reports for 2024. We also want to prevent suppliers from creating draft compliance & exclusion reports for 2025, which the system will allow them to do on January 1, 2024.

Purpose
The new Low Carbon Fuels Act brings significant revisions & additions to compliance & exclusion reporting beginning in the 2024 compliance period. The current draft compliance report for 2024 is not accurate in terms of the reporting requirements and associated compliance unit calculations. We want to hide this report until development of the new Act changes & additions is complete.
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

Appears to be a duplicate with #2416


Add parameters : for exemple to disable forbidden 4XX

Hi
I was using your lib for two things :

Clarify errors in validation as well for client or server side.
Make additionalProperties: false working by send an error to server side when result contain not declared fields in schemas

So, it work absolutely, BUT this lib do other things that i dont want.

Add a stacktrace to validation error (not wanted)
Refuse to send HTTP 4XX (only 500), Return 500 instead of a 422 due to :

    // No validator, it means the HTTP status is not allowed
    const validator = validators[statusCode]

    if (!validator) {
      throw createError(StatusCodes.INTERNAL_SERVER_ERROR, validationMessagesFormatters.invalidResponseCode(statusCode))
    }

(this is due to the fact that i only declare 200 in schema, but no other http code, so may be the option is to only validate 200 for response ?)
I have tried to reimplement theses point by using hook but it add a lot of code.
I am thinking of forking this library to delete all theses features i didn't want, but think it may be cool if you add configurations parameters to the lib for this.
To sum up, i only want clear error object and respect of additionalProperties (or error), for the rest of features i didn't need, i just want an option for disable it.
Thank you

Hi!
Thanks for the very nice feedback.
About the second issue, which is allowing responses not defined in the schema, I'm adding a new option, called allowUndeclaredResponses that enables this behavior. Note that if a response is defined it will still be validated.
You can see and test the behavior in #4.
About the first issue, instead, I don't see the stack in my tests. Which kind of validation error are you throwing?
Can you please post a little repo example so I can fix it?

@giraudvalentin Any update on this?

@giraudvalentin I've released v2.2.0 which adds allowUndeclaredResponses. If you need anything else, feel free to reopne the issue. For now I'm closing this.
PS: Note that the package has been renamed to fastify-http-errors-enhanced. The use is the same.


Negative number not supported

Test code
ivananu x = -10;
x para;

ISSUE
Error during execution: Unexpected token Token('MINUS', '-') at line 1, column 13.
Expected one of:
        * LPAR
        * STRING
        * NUMBER
        * IDENTIFIER
Previous tokens: [Token('EQUAL', '=')]

Oh ok, I will add negative numbers too. Thanks for pointing it out


feat: whitespace agnostic for client-preset / gql-tag-operations

fixes: #9415
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Related # (issue)

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] client-preset - prevent duplicate operations - modified the fixture to include a one-line query. Both queries result in a same one-line query string

Test Environment:

OS: macOS 13.1
@graphql-codegen/gql-tag-operations: 3.0.1
NodeJS: v18.14.0

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

This is not really needed and will degrade the TypeScript performance. You can just run codegen in watch mode instead.


Replit issue when I try to Run it

2024-02-03 17:45:38 - root - INFO - BING_COOKIE loaded from ./cookie.json
2024-02-03 17:45:38 - root - WARNING - Allow everyone mode
2024-02-03 17:45:38 - root - WARNING - You set BING_COOKIE to not None, but you allowed everyone to use this bot
2024-02-03 17:45:39 - httpx - INFO - HTTP Request: GET https://www.bing.com/turing/conversation/create "HTTP/1.1 200 OK"
Traceback (most recent call last):
File "/home/runner/PyroEdgeGPTBot/main.py", line 130, in
"bot": tmpLoop.run_until_complete(EdgeGPT.Chatbot.create(proxy=PROXY_BING, cookies=BING_COOKIE)), # 共用一个 cookie.json 文件
File "/nix/store/xf54733x4chbawkh1qvy9i1i4mlscy1c-python3-3.10.11/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/home/runner/PyroEdgeGPTBot/.pythonlibs/lib/python3.10/site-packages/EdgeGPT/EdgeGPT.py", line 41, in create
self.chat_hub = ChatHub(
File "/home/runner/PyroEdgeGPTBot/.pythonlibs/lib/python3.10/site-packages/EdgeGPT/chathub.py", line 42, in init
conversation_signature=conversation.struct["conversationSignature"],
KeyError: 'conversationSignature'
how to fix this issue?

You can fix this issue by changing the requirements.txt just remove the edgegpt and this url


RecordWMetadata -> EncryptedRecordWMetadata converter

for record by record encryption
I relaxed the emptyOrNull constraint in ForkOperatorUtils.getPropertyNameForBranch() so I can call getPropertyName("", ) to get the suffix that would be added on to all config parameters for a given branch

Updated with new SerializedRecord (w content-type concept). One thing that is kind of confusing: SerializedRecordWithMetadata can be read two different ways: SerializedRecord With Metadata, which is what it actually is, or Serialized (RecordWithMetadata). Don't know if there is a better naming scheme so it's obvious how to break the phrases up.


Where can I find the install list?

Hello, thanks for your software, it definitely makes life easier. It's just that after a deb file has been created and I extract it to view the content, I cannot find the install file containing the manifest of the app.
Basically, it's a list similar to:
app /usr/bin/
app-s /usr/bin/
app.py /usr/bin/
app.desktop /usr/share/applications/
share/icons/app.png /usr/share/icons/hicolor/48x48/actions/

I apologize for not responding sooner. I haven't been active with Debreate much over the past year.
I'm not familiar with a manifest file for deb packages, but I will look into it. There is an option to create an MD5 hash file when you build the package. Not sure if that is what you are looking for though. It should be located in the "DEBIAN" sub-directory when you extract.

Yeah that works too :smiley:


Problem with ExcelExportHelper

Hi,
Does anyone had issues with Excel exporting?
I might be missing something but I am getting the following "Resource not found" error when using exporting to Excel.

My code is the following:
 protected override List<ToolButton> GetButtons()
            {
                var buttons = base.GetButtons();
                buttons.Add(Common.ExcelExportHelper.CreateToolButton(this,
                GreidaBeintService.BaseUrl + "/ListExcel", this.OnViewSubmit));
                buttons.RemoveAt(0);
                return buttons;
            }

I would really appreciate if someone knows a quick fix for this :)

Too difficult, or learning to learn it

Did you add the action Endpoint FileContentResult ListExcel to greidabeing or waht ever module ?

@107295472 Yin stop commenting on all topics. If it is so difficult, try your luck with something else. Start with English maybe.

@biggikalli If you don't implement ListExcel action in your GreidaBeintEndpoint, it won't find resource.

Start  English

Thank you for your quick answers. Worked like a charm as always.
According to your suggestions, I referred to how the Northwind.Order Endpoint is set up.
And Yin, thank you for the motivation - if you could do it, then the rest of us can :)
Everything is possible with a little patience!