fix: PR merge for CI systems using Checks API

Issue
Github Actions Workflows use the Checks API, as opposed to the Statues API, to post the status of a Workflow.
Current behavior of using the /repos/{owner}/{repo}/statuses/{sha} API to check if a PR is ready to be merged naturally only works for CI systems that use the Statues API (Jenkins?). One hack for GH Actions Workflows is to have a step that posts to the Statuses API, but that gets pretty tiresome after the second workflow.
Right now octopilot also needs read-only repository admin permissions to be able to GET /repos/{owner}/{repo}/branches/{branch}/protection/required_status_checks for a list of required status checks configured as part of the branch protection rules.
Fix
Use the PR mergeable_state field to determine when a PR is ready to be merged. This field is not documented very well, but a value of clean should mean all branch protection rules are satisfied.
This should cover both the Statues API & Checks API. Added bonus is any other branch protection rules (e.g. required approvals). Also, reduces the scope of the permissions needed.

@jashandeep-sohi Thank you for this! Solves exactly the problem I saw/explained over at:

https://github.com/dailymotion-oss/octopilot/issues/280#issuecomment-1818470120

I'll see if I can give this a try at some point.

Let us know how it goes. I did run some tests on a test repo.
I also have a patch for the auto-merge feature, but didn't want to conflate
the two. I'm thinking both methods should be available, with the auto-merge
one being opt-in. That method can also be asynchronous, i.e. you don't have
to wait around for the checks to pass. GitHub will do it for you.
On Wed, Dec 6, 2023, 08:22 Victor Sollerhed @.***>
wrote:

@jashandeep-sohi https://github.com/jashandeep-sohi Thank you for this!
Solves exactly the problem I saw/explained over at:

#280 (comment)
https://github.com/dailymotion-oss/octopilot/issues/280#issuecomment-1818470120

I'll see if I can give this a try at some point.
—
Reply to this email directly, view it on GitHub
https://github.com/dailymotion-oss/octopilot/pull/290#issuecomment-1843232748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN2GABDUGFYHCZYLLBV333YICLTJAVCNFSM6AAAAABAGL6IUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGIZTENZUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

yep exactly, I totally agree with you. Feel free to share your other patch if you want to discuss it.
and thanks again for your contributions!

FYI: I raised #293, as this change broke --pr-merge for us.


[MINOR] add impala release and spark partition discovery

Minor doc edit

👍 @garyli1019

@garyli1019 it would be nice to add more context about the pr next time : )


Including monaco-vue to build would cause out of memory

In some situation I need to include monaco-vue as a submodule from https://github.com/rebornix/monaco-vue/ .
But unfortunately, it would always cause a 'out of memory' when building in both standalone and external version. And I found that this OOM error will certainly appear as long as monaco-vue and monaco-typescript are both included.
Now my temporary solution is to increase the memory by using like this in package.json:
"build:standalone": "cross-env NODE_ENV=production node --max_old_space_size=20000 ./node_modules/webpack/bin/webpack.js --config webpack.config.standalone && npm run typings:standalone",     "build:external": "cross-env NODE_ENV=production node --max_old_space_size=20000 ./node_modules/webpack/bin/webpack.js --config webpack.config.external && npm run typings:external",
But the size of index.js is 17.5MB in standalone version.
Is there any suggestion to reduce the size?

Hi @Fuji-sunny – sorry for the late reply. This was only meant as an experiment while the Monaco team work on webpack compatibility.
There has recently been a lot of activity from the Microsoft guys to get the monaco editor working with webpack. It looks like there should be an officially-supported webpack build coming soon so I'd recommend using the official build as soon as that's ready.

update as of today : the official react-monaco-editor available on npm works out of the box with webpack.


Minor typos in diagram and text

In the "Good/Better/Best" diagram for authentication methods, in the "Best" column, it says "Window Hello". I think it should be "Windows Hello" (with an "s").

And in this "following authentication methods..." list, there's a parallel construction issue: the first item ends with a full stop even though it is not a complete sentence, but the second and third items do not. Maybe they should all have full stops; that seems to be more the Azure document house style.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b8f14188-98ec-5c94-f408-162ee1baa076
Version Independent ID: 41ed4874-e1e6-56d3-4de4-39c024d1e06c
Content: Authentication methods and features - Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/authentication/concept-authentication-methods.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@apjanke-demex
Thanks for your feedback! We will investigate and update as appropriate.

@apjanke-demex
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

@Justinha
Can you please check and add your comments on this doc update request as applicable.

@ManoharLakkoju-MSFT can I update the typo

sorry for delay and thanks for raising this. I created an internal work item for SMEs to review and update the topic as needed. #please-close


[cluster-test] Log rotate libra.log

This diff uses log file created in https://github.com/libra/libra/pull/1584 and rotates this log on every deploy
Why do log rotation on deploy? Since we wipe db here, we pretty much start from "clean plate", so logs can be invalidated at this point
Depends on https://github.com/libra/libra/pull/1584, please do not use r+, use delegate+ instead

@bors-libra delegate+

:v: @andll can now approve this pull request

@bors-libra r=ankushagarwal

:pushpin: Commit f445b8b has been approved by ankushagarwal

:hourglass: Testing commit f445b8bae144a353626cd79cf7e145349d30adca with merge e383a0b056725eb28fc43c0ddb0f2c7aac829b69...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing e383a0b056725eb28fc43c0ddb0f2c7aac829b69 to master...


How can model latency be minimized?

I'd like to train a model that has low latency (produces detections as quickly as possible for a given frame after that frame is input to the model). What are the hyperparameters that impact latency, and where can I find and alter them in the code? In particular, I'm guessing that feature selection plays a large role. For a target frame (keyframe) at time t, we'd only want reference features from early frames, t-1, t-2, t-3, ..., and NOT from frames at t+1, t+2, ...
@YuHengsss, can you comment?

Not sure if number of reference frames used during training/inference would affect the latency or not but you can try playing around with the gframe hyperparameter in the model config files and see the avg inference time after 1 epoch by setting the validation interval to 1. Maybe the input image size and multiscale range also plays a part but I am not sure as I have not tried, they're all in the model config files
Regarding this For a target frame (keyframe) at time t, we'd only want reference features from early frames, t-1, t-2, t-3, ..., and NOT from frames at t+1, t+2, ... from issue #113 the sampling method is in the photo_to_sequence function in YOLOV/yolox/data/datasets/vid.py
And switching it from 'random' mode to 'uniform' mode makes it such that the frames are not randomly sampled globally but sampled with uniform intervals in between, however I am not sure about the t-1, t-2, t-3 thing as I have asked about which frame in the list is the current keyframe but still no replies so far, the author is probably busy but if you find out, please let me know!


Remove or adjust license note in footer

Right now it says "Data available are CCby4 license" but that's not true; it's CCby4 unless otherwise assigned by primary data sources... which we've got on our Data page.  Is that sufficient, can we remove that from here?

"CCby4 unless otherwise assigned by primary data sources... which we've got on our Data page" feels sufficient to me!


feat:adds 5 additional constraints to the gke hardening bundle

new bundle create for gke-hardening i.e. gke-hardening-v2022.03
fixes for missed documentation
minor update the generate_docs fn to support kpt fn eval

@morgante - please take a look


tests: Add docker inspect test

This will test the docker inspect option as part of the integration tests
Fixes #218
Signed-off-by: Gabriela Cervantes<EMAIL_ADDRESS>

lgtm

@devimc changes applied thanks for the feedback

lgtm


npm(3.x) install throws Maximum call stack size exceeded

I ran
react-native init ReactNativeSample
rm-rf node_modules/
npm install

and it throws this error
npm install
npm ERR! Darwin 15.0.0
npm ERR! argv "~/.nvm/versions/node/v5.6.0/bin/node" "~/.nvm/versions/node/v5.6.0/bin/npm" "install"
npm ERR! node v5.6.0
npm ERR! npm  v3.6.0

npm ERR! Maximum call stack size exceeded
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:

I tried many different combinations of node 4, 5 along with npm 3.x
I attach below some parts of npm-debug.log
58984 silly build<EMAIL_ADDRESS>58985 silly build<EMAIL_ADDRESS>58986 silly build<EMAIL_ADDRESS>58987 silly build<EMAIL_ADDRESS>58988 silly build<EMAIL_ADDRESS>58989 silly build<EMAIL_ADDRESS>58990 silly build<EMAIL_ADDRESS>58991 silly build<EMAIL_ADDRESS>58992 silly build<EMAIL_ADDRESS>58993 silly build<EMAIL_ADDRESS>58994 verbose stack RangeError: Maximum call stack size exceeded
58994 verbose stack     at Tracker.completed (/Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:87:40)
58994 verbose stack     at /Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:27:47
58994 verbose stack     at Array.forEach (native)
58994 verbose stack     at TrackerGroup.completed (/Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:26:19)
58994 verbose stack     at /Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:27:47
58994 verbose stack     at Array.forEach (native)
58994 verbose stack     at TrackerGroup.completed (/Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:26:19)
58994 verbose stack     at /Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:27:47
58994 verbose stack     at Array.forEach (native)
58994 verbose stack     at TrackerGroup.completed (/Users/naver/.nvm/versions/node/v5.6.0/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:26:19)
58995 verbose cwd /Users/naver/dev/ReactNativeSample
58996 error Darwin 15.0.0
58997 error argv "/Users/naver/.nvm/versions/node/v5.6.0/bin/node" "/Users/naver/.nvm/versions/node/v5.6.0/bin/npm" "install"
58998 error node v5.6.0
58999 error npm  v3.6.0
59000 error Maximum call stack size exceeded
59001 error If you need help, you may report this error at:
59001 error     <https://github.com/npm/npm/issues>
59002 verbose exit [ 1, true ]

even  npm install -g react-native fails with node 5.6.0, npm 3.6.0

Hm, I have node 5.6.0 and npm 3.6.0, but I can't reproduce this issue.
Also, I'm not sure why you need to install react-native globally (do you mean react-native-cli?).
Probably it'll help if you re-install npm (because are-we-there-yet is a dependency of the npm itself also). Try this:
$ npm i npm -g
$ npm i react-native-cli -g

I think it should solve your issue.

I made a typo there I mean just npm install react-native.
Even I'm failing to initialize react-native project like below.
$ react-native init AwesomeProject

This will walk you through creating a new React Native project in /Users/sweetest/dev/AwesomeProject
Installing react-native package from npm...

npm ERR! Darwin 15.0.0
npm ERR! argv "/usr/local/Cellar/node/5.7.0/bin/node" "/usr/local/bin/npm" "install" "--save" "react-native"
npm ERR! node v5.7.0
npm ERR! npm  v3.6.0

npm ERR! Maximum call stack size exceeded
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/naver/dev/AwesomeProject/npm-debug.log

`npm install --save react-native` failed

npm i npm -g did not helped also.

seems like there's an infinte loop, attached is the last part of npm-debug.log
59069 silly build<EMAIL_ADDRESS>59070 silly build<EMAIL_ADDRESS>59071 silly build<EMAIL_ADDRESS>59072 silly build<EMAIL_ADDRESS>59073 verbose stack RangeError: Maximum call stack size exceeded
59073 verbose stack     at emitOne (events.js:90:13)
59073 verbose stack     at emit (events.js:182:7)
59073 verbose stack     at null.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:9:18)
59073 verbose stack     at emitOne (events.js:90:13)
59073 verbose stack     at emit (events.js:182:7)
59073 verbose stack     at null.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:9:18)
59073 verbose stack     at emitOne (events.js:90:13)
59073 verbose stack     at emit (events.js:182:7)
59073 verbose stack     at null.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npmlog/node_modules/are-we-there-yet/index.js:9:18)
59073 verbose stack     at emitOne (events.js:90:13)
59073 verbose stack     at emit (events.js:182:7)
59074 verbose cwd /Users/naver/dev/AwesomeProject
59075 error Darwin 15.0.0
59076 error argv "/usr/local/Cellar/node/5.7.0/bin/node" "/usr/local/bin/npm" "install" "--save" "react-native"
59077 error node v5.7.0
59078 error npm  v3.7.3
59079 error Maximum call stack size exceeded
59080 error If you need help, you may report this error at:
59080 error     <https://github.com/npm/npm/issues>
59081 verbose exit [ 1, true ]

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/npm3x-install-throws-maximum-call-stack-size-exceeded
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


Implement parallel fuzzing

It is possible to run multiple fuzzing processes at the same time, thus
improving fuzzing speed signinficantly. One problem with the built-in
fuzzing is that it is bad at displaying information on the go.
Therefore we implement our own process mangement (using the awesome
tokio) and print results from all of them on the fly.
Also fixes the CLI for --target.

cc @Manishearth @frewsxcv for a review.

bors r=frewsxcv


AdditiveCollection not defined for Seq?

Why isn't AdditiveCollection defined for Seq itself? It makes it pretty much impossible to use sized Seqs, since all of the underlying methods require an AdditiveCollection type class.

Seq only requires an ordering of it's elements, it doesn't require the additive behaviour that AdditiveCollection requires ... instances of the latter are defined ad hoc for concrete data types which do behave appropriately. Stream would be problematic, for instances. And there's nothing to stop someone from defining a Seq subtype with ordered-set-like behaviour.

Stream already has an applicable AdditiveCollection though? Stream is a LinearSeq, for which an AdditiveCollection conversion exists.

It seems that this question can be used to get started? @joroKr21


add violations count

Feature Request

Q
A

New Feature
yes

RFC
no

BC Break
no

Summary

Could a violations count be added in the phparkitect output?
It seems to me that at the moment it is not there.

that's probably a good addition, makes sense to me

@ricfio, do you want to try to add this feature?

sure, it's very simple.
see https://github.com/phparkitect/arkitect/pull/235

closed by #237


Add fisherman

NOTE: Each discrete (stand-alone) request should be in its own issue.
Put "Add ____" as Title
[x] Done
Provide a link to the proposed addition.
https://github.com/fisherman/fisherman
Explain why it should be added
Fish is on the list and so is bash-it and Oh my zsh. So why not? ;)
Additional context
None
Issue Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the issue. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before responding to the issue.

[x] I have checked for other similar issues
[x] I have explained why this change is important
[x] I have added necessary documentation (if appropriate)

It was deleted in #431 because fish has a dedicated awesome list and fisherman is there

Airght thanks


add:Divya N

Description

Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

Hi @DivyaN10 , thanks for your interest in contributing to DevDisplay!
Before we proceed, we noticed you adding your profile on #DevDisplay but forgot to star the repo. It's like making an amazing sandwich and forgetting to take a bite! -- I think our repo's feeling a little lonely without your 🤗 So, be sure to star the DevDisplay GitHub Repository. 🌟
💌 This is a mandatory step for all contributors. & It's is the first priority of contribution in DevDisplay 💌
🚀 We look forward to your contribution once these steps are completed. 🚀
Thanks 👍🏻


CPU usage crash on calling the flush API

Describe your environment. Describe any aspect of your environment relevant to the problem, including your SDK version, platform, OS version, etc. If you're reporting a problem with a specific version of a library in this repo, please check whether the problem has been fixed on main brach.
OneDS SDK Version: 3.6.187
Steps to reproduce.
Describe exactly how to reproduce the error. Include a code sample if applicable.
This is mainly happening on the [ODWLogManager flush] call with lock wait. Not able to repro. But we are getting reports from internal users. PFA for the symbolicated logs.

What is the expected behavior?
What did you expect to see?
No crash due to CPU usage
What is the actual behavior?
What did you see instead?
Seeing CPU usage crashes on the flush API call
Additional context.
Add any other context about the problem here.
Crash.txt

Related issue: #754

@lalitb - although may not related, I noticed that about 1.5 years ago there was a change in the shutdown sequence (zombie loggers-related), that could cause the SDK to get into state where it waits for upload, but doesn't actually upload anything. Although that should not cause any negative consequences, it'd appear that the app is "frozen" while idle-waiting for the flush and teardown timer to expire.. I hit it in some tests with my product and I might have a patch that allows to push-thru event faster, thus exit the app faster without waiting for the entire flush and teardown duration.

@maxgolov Is the patch part of the OneDS SDK or the client app? Could you share more details on this.

@lalitb @maxgolov Gentle reminder on this

@lalitb @nishchith-cp - I don't think it was actually the same issue. The bug that I'm observing is spinning in FlushAndTeardown without uploading anything. In my case the code doesn't get stuck on file write, and doesn't stuck on Flush. The associated bug is  #1120 . Sorry for confusion.


Map visualization: add clustering

Implement loops visualization in the map:

loops should be displayed as blurred circles
loops centre point should  be set by the coordinates of the loop location stored in db
loops radius value should be the one set by the user in NewChainLocation.tsx flow (this is still in building process, can be hardcoded for now)
loops should have different colours based on their category
when zooming out the map, cluster nearby loops into a single circle and display the loops count

Note for reference (and self): I just realized that since this is a clustering problem I might consider using clustering algorithm i.e. Machine Learning algorithm. I am eyeing at DBSCAN algorithm.

Mapbox has built-in map clustering functions - https://docs.mapbox.com/mapbox-gl-js/example/cluster/
What do you think of this?

Thanks Giulia, I don't know MapBox has clustering under their hood already. Looks good and it will definitely be more performant than self-implemented.
But the issue is that we will need to have GeoJSON format for our coordinates. Shouldn't be a big issue but I'll update if there is major issue


CI: K8sValidatedHealthTest failure

Build link: https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/783/
Failure output:
/home/jenkins/workspace/cilium-ginkgo_cilium_master-QVKDPVJ2A6E272IRUX7X6DCB5FBLCQDKRTOMHPZS7ZECX3RM5C3A/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:312
Expected
    <bool>: false
to be true
/home/jenkins/workspace/cilium-ginkgo_cilium_master-QVKDPVJ2A6E272IRUX7X6DCB5FBLCQDKRTOMHPZS7ZECX3RM5C3A/src/github.com/cilium/cilium/test/k8sT/Health.go:101

Console output from when test failed:
time="2018-05-07T19:05:47Z" level=debug msg="running command: kubectl exec -n kube-system cilium-193nt -- cilium status -o jsonpath='{.cluster.nodes[*].primary-address.*}'"
time="2018-05-07T19:05:53Z" level=debug msg="running command: kubectl exec -n kube-system cilium-193nt -- cilium status -o jsonpath='{.cluster.nodes[*].primary-address.*}'"
time="2018-05-07T19:05:58Z" level=debug msg="running command: kubectl exec -n kube-system cilium-dm0w6 -- cilium status -o jsonpath='{.cluster.nodes[*].primary-address.*}'"
time="2018-05-07T19:06:04Z" level=debug msg="running command: kubectl exec -n kube-system cilium-dm0w6 -- cilium status -o jsonpath='{.cluster.nodes[*].primary-address.*}'"
STEP: checking that `cilium-health --probe` succeeds
time="2018-05-07T19:06:04Z" level=debug msg="running command: kubectl exec -n kube-system cilium-193nt -- cilium-health status --probe -o json"

Logs:
test_results_master_783.zip

There appears to be a connectivity issue between a node and the health endpoint on the same  node in this instance (note that the failing endpoint connectivity is nested within the localhost node entry on each of the nodes):
k8s2:
cilium-health status
Probe time:   2018-05-07T19:06:00Z
Nodes:
  k8s2 (localhost):
    Host connectivity to <IP_ADDRESS>:
      ICMP:          OK, RTT=1.748268ms
      HTTP via L3:   OK, RTT=1.381342ms
    Endpoint connectivity to <IP_ADDRESS>:
      ICMP:          Connection timed out
      HTTP via L3:   Connection timed out
  k8s1:
    Host connectivity to <IP_ADDRESS>:
      ICMP:          OK, RTT=2.013951ms
      HTTP via L3:   OK, RTT=858.307µs
    Endpoint connectivity to <IP_ADDRESS>:
      ICMP:          OK, RTT=1.934839ms
      HTTP via L3:   OK, RTT=1.059953ms

k8s1:
cilium-health status
Probe time:   2018-05-07T19:06:35Z
Nodes:
  k8s1 (localhost):
    Host connectivity to <IP_ADDRESS>:
      ICMP:          OK, RTT=412.863µs
      HTTP via L3:   OK, RTT=384.713µs
    Endpoint connectivity to <IP_ADDRESS>:
      ICMP:          Connection timed out
      HTTP via L3:   Connection timed out
  k8s2:
    Host connectivity to <IP_ADDRESS>:
      ICMP:          OK, RTT=462.714µs
      HTTP via L3:   OK, RTT=946.984µs
    Endpoint connectivity to <IP_ADDRESS>:
      ICMP:          OK, RTT=601.307µs
      HTTP via L3:   OK, RTT=1.088815ms

@joestringer we haven't seen this for some time; can we close?

@ianvernon I don't have anything actionable to do for this, I think if it shows up again then we need more information about the nature of the connectivity issue to the local cilium-health instance.
Closing, feel free to reopen if this is seen again.


How to resize CoSOD3k and CoCA to 224 * 224 for testing?

How to resize CoSOD3k and CoCA to 224 * 224 for testing? Can you please share you code for resizing the images or provide a link to your google drive so that I may download it?

 More specifically, we use the function "cv2.resize()" from "opencv-python (import cv2)" to achieve this goal. The code is shown below:
import cv2
from os import listdir
from os.path import join
if name == 'main':
for dataset in ('CoSOD3k', 'CoCA'):
for img_type in ('img_bilinear_224', 'gt_bilinear_224'):
base = '/mnt/jwd/data/{}/{}/'.format(dataset, img_type)
dir_names = listdir(base)
for dir_name in dir_names:
dir_path = join(base, dir_name)
names = listdir(dir_path)
for name in names:
img_path = join(dir_path, name)
img = cv2.imread(img_path)
img = cv2.resize(img, (224, 224))
cv2.imwrite(img_path, img)


Some tools won’t open

I tried installing default one and hardened kernel image and both times these apps refuse to open powersploit,payloadsallthethings,Fuzzdb,SeclistsMimikatz,securitywordlists and a few others . Is there something that I can do to fix this

I tried installing default one and hardened kernel image and both times these apps refuse to open powersploit,payloadsallthethings,Fuzzdb,SeclistsMimikatz,securitywordlists and a few others . Is there something that I can do to fix this

Hey @Kushy420 Remember that on Athena, for optimizing disk space, when you access the first time to a resource, it asks you for installing/downloading the resource itself. Are you connected to Internet?
If you wish, reach me on Discord (link on main GitHub page) so we can give a look together.

Theme is not installing.
How do i install it?
tnx :)


sysbuild: Add SB_OVERLAY_CONFIG

This fixes a minor issue in sysbuild, where -DOVERLAY_CONFIG=... would be applied not only to the main application, but also sysbuild itself. This was incorrect, because sysbuild imports a different Kconfig tree than normal Zephyr builds, so the same Kconfig fragment file would not necessarily be valid for both.
This adds a new variable SB_OVERLAY_CONFIG to resolve this ambiguity. It functions along the lines of SB_CONF_FILE, with both being sysbuild-specific versions of existing variables.
To ensure that OVERLAY_CONFIG is still passed on to the main application verbatim, its value is now loaded in configuration_files.cmake, rather than kconfig.cmake. This is because the former file is not imported by sysbuild, and it is where the related variables, such as CONF_FILE and DTC_OVERLAY_FILE, are loaded as well.

I don't believe this is accurate. OVERLAY_CONFIG would be applied to the main application, but also applied to sysbuild (which this commit is fixing).

True, thanks for catching this. I rewrote the commit message to explain the issue better; please check if it's correct.


new template - YAML documents should contain a required key

New Template
Hello, I'm Andres from Colombia.
I work in a enterprise where we are going to use yaml plugin in order to validate some yaml files inside software projects. I have created a new template that I want to share you.
Sometimes we need that a specific yaml file contains some required key, perhaps because it is a good coding practice.
To instance, Look this kubernetes yaml file:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 3
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx:1.7.9
        ports:
        - containerPort: 80

This yaml could be better if it contains the readinessProbe and livenessProbe keys, because they guarantees stability for our microservices. So, this new template could validate that keys exists in that file.
This template require 3 parameters:

key-name: Key name: e.g: kind
value-key: Value for key: e.g: Deployment
required-key: Required key. e.g: readinessProbe

The key-name and value-key parameters are required because not all yaml files must to have the required-key, so it will filter yaml files.
So, I have created this template that I hope other people can use it.
I'm going to attent some question that you could to have.

Hello,
Yes: the problem comes from the deprecation of Oracle's Java 8 Docker image.

Build passed ;)

Thanks =)


[Feature-#5258][Bin] Add .bat script for all shell script.

Purpose of this pull request
Add .bat script for all shell script.

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

@lvyanquan @EricJoy2048  PTAL

Overall, looks good to me.


Throws buckets of errors when running on system startup

Would there be a way to delay the first run of raspibolt-pulse until after all essential components have started?

I fooled around with making a systemd raspibolt-pulse.service file that would run After=lnd.service but couldn't figure out how to get it to display in the terminal.. any other ways to make it run in a delayed fashion?

Regarding the buckets of errors, when do the errors appear..? any specific cases?

Concur. Goal should be to allow the script to run, and quickly, but catch and suppress any errors inline while gathering information, and instead report to the relevant sections.
Any log output you can capture would be helpful in identifying what isn't being handled well, but otherwise we will need to look at each call.

RaspiBolt 3: Sovereign ₿itcoin full node
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
[lncli] rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:10009: connect: connection refused"

When LND is down, the script output this error message in yellow.
Could we remove these lines from the output? It can causes unnecessary concerns for newbies when they see that.

There are assorted places where stderr output is not being redirected to stdout or /dev/null.
These can be redirected or suppressed as appropriate.


Add Support for includeFolders option in ListObjects

Add Support for manual managed folders feature includeFolders. More details see internal doc Note: This is only the manual addition for includeFolders. No other part is relevant.

feature needed for GA launch March 12, 2024

https://github.com/googleapis/java-storage/pull/2445

https://github.com/googleapis/java-storage/pull/2445


Added table of contents

please check if formatting needs work, or headings too vague
NOTE: for future headings, cannot have same heading names or linking would not work, please specify to have different headings i.e. cannot have two subsections named M5

we dun deserve youuuuu


Handled BOM character for Unicode-based encodings file uploads

Codecov Report

Merging #20 (9ab6003) into main (498e166) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   71.61%   71.63%   +0.02%
==========================================
  Files        1817     1817
  Lines      115364   115370       +6
  Branches    16709    16718       +9
==========================================
+ Hits        82613    82641      +28
+ Misses      31635    31609      -26
- Partials     1116     1120       +4

Flag
Coverage Δ

e2e-tests
66.50% <ø> (-0.06%)
:arrow_down:

unit-tests
63.47% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ghost/members-csv/lib/parse.js
81.81% <100.00%> (ø)

... and 20 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Typo in the description of sqlfluff.executablePath

There is a typo in the description of sqlfluff.executablePath.
Instead of "executable", "exectuable" is currently used.
See package.json, line 95:
"description": "Points to the sqlfluff exectuable."

Fixed in v2.3.2


[VT-60] vit; fails to redraw on xterm resize

David Patrick on 2013-01-01T23:04:41Z says:
Start vit in a smaller xterm, now maximize that window and vit stays small.
It should issue it's own ^l after xterm changes size.

Migrated metadata:
Created: 2013-01-01T23:04:41Z
Modified: 2014-02-09T02:23:41Z

steve rader on 2013-03-24T14:38:27Z says:
Having Vit "auto-resize" is not desireable because the underlying operating
system sends many SIGWINCH (window change) signals during resize operations.


Fixes for llm-monitoring

Fixes current implementation of the llm-monitoring . Potentially we want to add monitoring of the vLLM model as well in additional changes

@trujillm Please review and merge . It will need to be tested

lgtm


⚠ Bofrost.de has degraded performance

In 5bf082f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1035 ms

Resolved: Bofrost.de performance has improved in 67175c9 after 6 minutes.


pdf.js doesn't support non-Identity CMap encodings

For example, this PDF text is completely garbled.
http://www.kurims.kyoto-u.ac.jp/~terui/pssj.pdf
The octet sequence is interpreted as UTF-16BE rather than Shift_JIS.
8C76 8E5A 985F 82CC 8CBB 8DDD 8146
'P' 8296 8293 'NP' 96E2 91E8 82C6 82CD 89BD 82A9 8148
wrong:
豶蹚顟苌費距腆
P芖芓NP離釨苆苍覽芩腈
expected:
計算論の現在：
PｖｓNP問題とは何か？

Character are encoded using 90ms-RKSJ-H - Microsoft Code Page 932 (lfCharSet 0x80), JIS X 0208 character set with NEC and IBM® extensions.
Font data are not present; so font presents itself as standard font (that's bad).
Probably, (ftp://ftp.unicode.org/Public/MAPPINGS/OBSOLETE/EASTASIA/JIS/JIS0208.TXT)

Here's a more direct mapping table for Microsoft Code Page 932.
ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/MICSFT/WINDOWS/CP932.TXT
It is more preferable because JIS mappings do not contain NEC and IBM extensions.


Fix slack/teams notification of fields

Fix slack/teams notification of fields.

Thanks @stefanprodan for the review and merge!


Add support for more than 16 format args

Isn't this a limitation of C++ before C++11?

Support for more than 16 arguments has been added in #141. It requires C++11 variadic templates though.


Implementation for Smart Cards

I've been jumping around the internet for a few days and can't find a good solution for smart card data reading. I have a reader and card that are both detected by windows but into two categories (unsurprising) -Smart Card readers and -Smart cards. Can anyone assist me in trying to discover and read the data with this library? Thank you!

CCID is the USB smart card class I've heard of. Wikipedia says Windows comes with drivers for CCID, no idea if there are existing Node bindings for those drivers. If you want to read the CCID spec and write your own driver in JS, you could bind the device to WinUSB instead of Windows'  default CCID driver and use this library.


[Feature]: Update Docker image base

Feature description
The Dockerfile is currently pinned to an old SHA: https://github.com/puppeteer/puppeteer/blob/d9f2b659e8f19735d80e39351e1e4bacb702a88c/docker/Dockerfile#L1
This version has more Critical and High severity CVEs than the latest node:20 tag.
Could the SHA be bumped again?

Thanks for the suggestion, it looks like the dependabot was not finding the dockerfile. The base will be updated in the next release that we plan to make in the next couple of days.


Gpu

@CodiumAI-Agent /review

PR Review 🔍

 ⏱ Estimated effort to review [1-5]
3, because the PR involves changes across multiple files including configuration, training scripts, and layer implementations. The changes are moderate in complexity, involving parameter adjustments, removal of warnings, and deletion of a significant script. Understanding the impact of these changes requires a good understanding of the project's architecture and the specific functionalities being modified.

 🧪 Relevant tests
No

 ⚡ Possible issues

Possible Bug: The removal of the entire train_gpu.py script might lead to issues if other parts of the project depend on it. This needs verification.

Redundancy Issue: The repeated pattern of removing warning messages across different files suggests a change in how warnings are handled, which might be better addressed in a more centralized manner.
 🔒 Security concerns
No

 Code feedback:
relevant filedinov2/layers/attention.py
suggestion

Consider handling the ImportError more gracefully by providing a fallback or more informative error message, rather than just raising the ImportError. This could improve the robustness of the module when xformers is not available. [important]

relevant lineraise ImportError
relevant filedinov2/run/train/train_gpu.py
suggestion

If the deletion of train_gpu.py is intentional and its functionalities are covered elsewhere, ensure that all references to this script are updated or removed from documentation and other scripts to avoid confusion. [important]

relevant line-import torch.multiprocessing as mp
relevant filedinov2/distributed/__init__.py
suggestion

Ensure that the formatting changes in the enable function signature do not affect any calls to this function where arguments are passed positionally. This could potentially lead to runtime errors. [medium]

relevant lineallow_nccl_timeout: bool = False,
relevant fileREADME.md
suggestion

Update the example command in the README to reflect best practices or more common scenarios if the current changes are specific to a less common configuration. This ensures that new users have the most relevant information. [medium]

relevant line`torchrun --standalone --nproc_per_node=4 dinov2/train/train.py --config-file dinov2/configs/train/vitl_cellsim_register.yaml --output-dir /your/output/dir`

@CodiumAI-Agent /describe


Create animepahe.ru.js

add animepahe.ru.js
can select resolution between 1080,720,480

@appdevelpo are you in telegram group?


Bump version 0.8.0

Fixing the pyfluent version in dependencies, similar to pyfluent-parametric PR https://github.com/ansys/pyfluent-parametric/pull/253

Should rebase and target the PR to release/0.8 rather than main, correct?

Should rebase and target the PR to release/0.8 rather than main, correct?

Right, thanks


Update request/request

Hello,
See https://github.com/request/request/issues/2874.
Thanks,

Oh, my bad, I didn't see it's deprecated.


Quick stab at implementing ETag

Do you think we can add some negative tests for Etag failures?

I had to do something pretty hack-ish to make a strong unit test - I'm proud of it.

thanks @jeoffman

LOL, what a difference 1 word can make....  I'm NOT proud of it.  😝


Errors relating to resource_quota_controller seen in rancher server logs

Rancher server version - Build from master - Feb 25
Steps to reproduce the problem:
Bring up a single node rancher server setup.
rancher server logs has the following errors relating to resource_quota_controller:
E0226 01:11:43.152412       9 resource_quota_controller.go:460] failed to sync resource monitors: [couldn't start monitor for resource {"management.cattle.io" "v3" "projectnetworkpolicies"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectnetworkpolicies", couldn't start monitor for resource {"management.cattle.io" "v3" "clusterroletemplatebindings"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clusterroletemplatebindings", couldn't start monitor for resource {"management.cattle.io" "v3" "clusterregistrationtokens"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clusterregistrationtokens", couldn't start monitor for resource {"management.cattle.io" "v3" "multiclusterapprevisions"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=multiclusterapprevisions", couldn't start monitor for resource {"project.cattle.io" "v3" "sourcecodecredentials"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=sourcecodecredentials", couldn't start monitor for resource {"management.cattle.io" "v3" "clusterloggings"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clusterloggings", couldn't start monitor for resource {"management.cattle.io" "v3" "monitormetrics"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=monitormetrics", couldn't start monitor for resource {"management.cattle.io" "v3" "clusteralertrules"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clusteralertrules", couldn't start monitor for resource {"management.cattle.io" "v3" "projectroletemplatebindings"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectroletemplatebindings", couldn't start monitor for resource {"management.cattle.io" "v3" "projectcatalogs"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectcatalogs", couldn't start monitor for resource {"project.cattle.io" "v3" "apps"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=apps", couldn't start monitor for resource {"project.cattle.io" "v3" "pipelineexecutions"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=pipelineexecutions", couldn't start monitor for resource {"management.cattle.io" "v3" "globaldnses"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=globaldnses", couldn't start monitor for resource {"management.cattle.io" "v3" "clustercatalogs"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clustercatalogs", couldn't start monitor for resource {"management.cattle.io" "v3" "etcdbackups"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=etcdbackups", couldn't start monitor for resource {"management.cattle.io" "v3" "catalogtemplateversions"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=catalogtemplateversions", couldn't start monitor for resource {"extensions" "v1beta1" "networkpolicies"}: unable to monitor quota for resource "extensions/v1beta1, Resource=networkpolicies", couldn't start monitor for resource {"project.cattle.io" "v3" "pipelinesettings"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=pipelinesettings", couldn't start monitor for resource {"management.cattle.io" "v3" "projects"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projects", couldn't start monitor for resource {"management.cattle.io" "v3" "projectalertgroups"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectalertgroups", couldn't start monitor for resource {"project.cattle.io" "v3" "sourcecoderepositories"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=sourcecoderepositories", couldn't start monitor for resource {"management.cattle.io" "v3" "preferences"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=preferences", couldn't start monitor for resource {"management.cattle.io" "v3" "nodes"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=nodes", couldn't start monitor for resource {"management.cattle.io" "v3" "clusteralertgroups"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clusteralertgroups", couldn't start monitor for resource {"management.cattle.io" "v3" "podsecuritypolicytemplateprojectbindings"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=podsecuritypolicytemplateprojectbindings", couldn't start monitor for resource {"management.cattle.io" "v3" "clustermonitorgraphs"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clustermonitorgraphs", couldn't start monitor for resource {"management.cattle.io" "v3" "projectloggings"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectloggings", couldn't start monitor for resource {"management.cattle.io" "v3" "projectmonitorgraphs"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectmonitorgraphs", couldn't start monitor for resource {"management.cattle.io" "v3" "projectalertrules"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectalertrules", couldn't start monitor for resource {"management.cattle.io" "v3" "notifiers"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=notifiers", couldn't start monitor for resource {"project.cattle.io" "v3" "apprevisions"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=apprevisions", couldn't start monitor for resource {"project.cattle.io" "v3" "sourcecodeproviderconfigs"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=sourcecodeproviderconfigs", couldn't start monitor for resource {"management.cattle.io" "v3" "nodepools"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=nodepools", couldn't start monitor for resource {"management.cattle.io" "v3" "nodetemplates"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=nodetemplates", couldn't start monitor for resource {"management.cattle.io" "v3" "globaldnsproviders"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=globaldnsproviders", couldn't start monitor for resource {"management.cattle.io" "v3" "multiclusterapps"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=multiclusterapps", couldn't start monitor for resource {"project.cattle.io" "v3" "pipelines"}: unable to monitor quota for resource "project.cattle.io/v3, Resource=pipelines", couldn't start monitor for resource {"management.cattle.io" "v3" "clusteralerts"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=clusteralerts", couldn't start monitor for resource {"management.cattle.io" "v3" "catalogtemplates"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=catalogtemplates", couldn't start monitor for resource {"management.cattle.io" "v3" "projectalerts"}: unable to monitor quota for resource "management.cattle.io/v3, Resource=projectalerts"]
I0226 01:11:43.444623       9 controller_utils.go:1027] Waiting for caches to sync for garbage collector controller
I0226 01:11:43.645014       9 controller_utils.go:1034] Caches are synced for garbage collector controller

A duplicate of https://github.com/rancher/rancher/issues/16633


Custom got agent

Hello.
Is it possible to use a wrapped agent like in this got example: https://github.com/sindresorhus/got/blob/main/documentation/examples/uppercase-headers.js
My use-case is that I have to work with servers that don't follow the RFC properly and need headers in specific casing.
I created a got fork that does not use their helper to lowercase header keys (https://github.com/SugoiDev/got) but would rather not have to maintain forks for this (would have to maintain got, httpyac and vscode-httpyac forks).
Thanks a lot for all the work on this.
Update: I managed to get it working somewhat with the CLI, but when I run requests with these options with the extension in VSCode, it will just sit there forever and never finish
const http = require('node:http');
const https = require('node:https');

class WrappedAgent {
    constructor(agent) {
        this.agent = agent;
    }

    addRequest(request, options) {
        return this.agent.addRequest(request, options);
    }

    get keepAlive() {
        return this.agent.keepAlive;
    }

    get maxSockets() {
        return this.agent.maxSockets;
    }

    get options() {
        return this.agent.options;
    }

    get defaultPort() {
        return this.agent.defaultPort;
    }

    get protocol() {
        return this.agent.protocol;
    }
}

class TransformHeadersAgent extends WrappedAgent {
    addRequest(request, options) {
        const headers = request.getHeaderNames();

        for (const header of headers) {
            request.setHeader(this.transformHeader(header), request.getHeader(header));
        }

        return super.addRequest(request, options);
    }

	transformHeader(header) {
		return header.toUpperCase();
    }
}

const wrappedHttpAgent = new TransformHeadersAgent(http.globalAgent);
const wrappedHttpsAgent = new TransformHeadersAgent(https.globalAgent);

module.exports = {
    request: {
        agent: {
            http: wrappedHttpAgent,
            https: wrappedHttpsAgent
        }
    }
}

In the settings of vscode there is a setting proxy support with value override. Change this settings to none(?). Vscode override all http requests with a customized Agent (yeah great idea from MS). That is the reason why vscode httpyac uses HTTP/1 as default and cli prefers HTTP/2. It should solved your immediate Problem. I will take a look at it, if I got more free time

Thanks for the help, disabling the proxy support setting to "off" did the trick and I can now use the overridden agent.

Managed to get it working a bit better.
All headers from the headersList list will have preserved case.
It would still be better to have a setting in "got" for this, but this was the next best thing I could get, without having to maintain another fork.
const http = require('http');
const https = require('https');

function transformHeader(headerKey) {
    //all headers from this list will be sent exactly as they are in the list
    //matching is done in lowercase
    //for example, "CHANNEL", "channel", etc, will all be sent as "Channel"
    const headersList = [
        "Channel",
        "TEST-HEADER-KEY-UPPERCASE"
    ];

    const newKey = headersList.find(h => h.toLowerCase() === headerKey.toLowerCase()) ?? headerKey;
    return newKey;
}

function overrideSetHeader() {
    const originalSetHeader = http.ClientRequest.prototype.setHeader;
    http.ClientRequest.prototype.setHeader = function(name, value) {
        const transformedName = transformHeader(name);
        originalSetHeader.call(this, transformedName, value);
    };

    //override https equivalent by reaching through https module's request
    const originalHttpsRequest = https.request;
    https.request = function(options, callback) {
        if (options.headers) {
            const transformedHeaders = {};
            for (let header in options.headers) {
                transformedHeaders[transformHeader(header)] = options.headers[header];
            }
            options.headers = transformedHeaders;
        }
        return originalHttpsRequest.call(this, options, callback);
    };
}

overrideSetHeader();

module.exports = {
    request: {
        agent: {
            //fresh instances
            http: new http.Agent(),
            https: new https.Agent({rejectUnauthorized: false})
        }
    }
}


Proposal for shortcut description

Hi. @maartenba .
I have a proposal, will you listen to it?
Problem Statement

The description of the shortcut keys in the workshop is limited to the VisualStudio style for ReSharper.
This is often confusing for users who are new to the JetBrains IDE, especially those who are starting to use Rider.

Proposed improvement
I came up with the following three ideas.
Please let me know what you think.

Include typical shortcut keys in all places (VisualStudio Style in ReSharper, and Default IntelliJ Style in Rider).
Create a link to the keymap correspondence table and do not include specific shortcuts in the workshop, just the function names (ex. Search Everywhere).
Maintain the current ReSharper's VisualStudio Style, but prepare a script for batch replacement according to the Keymap used, so that users can build the text according to their own environment.

@sun-flat-yamada Good suggestions! I believe a combination of option 1 and 3 could be interesting.
I'd prefer to have the first option, so the comments at least show commonly used shortcuts for one or two keymaps, without the need for additional tools or lookups.
Option 3 sounds interesting, and I believe this is also what @khalidabuhakmeh had in mind when staring to use <shortcut id="...." on the last revision of this workshop.
So I think definitely 1 would be preferred, and at some point having a tool to replace all <shortcut id=""> based on your keymap would be useful.

Hello. @maartenba .
Thank you for your reply.
OK. I understand your opinion.
I have already adopted the method 1 (Include typical shortcut keys) in the Japanese translation.
Specifically, I recognize that the following two are typical keymaps.

ReSharper VisualStudio Keymap
Rider Default IntelliJ Keymap

For example, the following is a part of it.
    // <shortcut id="File Member">Alt+\    (ReSharper VisualStudio Keymap)</shortcut>
    // <shortcut id="File Member">Ctrl+F12 (Rider Default IntelliJ Keymap)</shortcut>

https://github.com/JetBrains/resharper-rider-samples/blob/192fb73ae63d12e6851234a02ae195b7e02bee72/localized/ja/01-Navigation/1-Navigate_to_something_you_know/1.5-Go_to_file_member.cs#L7
I'm going to proceed in this way of writing, does it look good?
If it is OK, I will keep in mind to reflect the parts I noticed in the English version as well.

That seems perfect, these two are commonly used and should help people along quite a bit. Thanks!

Hi, @maartenba .
By the way, is there an appropriate place to consult for the problem you are experiencing with Resharper?
I do not use ReSharper on a daily basis.
I'm using the evaluation version just to check this Japanese translation, and the trial period will be expiring soon.
However, I would like to help out as much as I can within the trial period, since other humans may face the same problem.

@sun-flat-yamada can you email me at maarten @ jetbrains .com?

@maartenba I have sent an email from sun . flat . yamada @ ...


Add files via upload

Changed script logic so it only includes heroes with >5% games played in the particular position.
I wanted to add the selectivity because this week Tidehunter was in the number one spot for safelane, but only with 49 games (out of his 2390 total). I primarily use the configs generated by this script to evaluate hero choices and to get a sense of the current meta, especially for roles I am less familiar with, and having experimental outliers included with other safer, more viable picks was making me call into question the reliability of the results.
Since I coded it anyway, here it is if you wanted to include any options for selectivity for ease of use.
Love the script!

Cleaned up the code a lot, moved the matches comparison into the initialization of hero_ranks instead of as a separate for loop.

Cleaned up the code a lot, moved the matches comparison into the initialization of hero_ranks instead of as a separate for loop.


[Symfony] Remove environment variable from docker-compose.yml

Remove  environment variable from docker-compose.yml, this is take from ./app/.env
https://github.com/mmaximo33/efde/blob/1.1.1/environments/symfony/docker-compose.yml#L20-L22

Fix in
https://github.com/mmaximo33/efde/releases/tag/1.1.1


Make set/variant an optional attribute

A current shortcoming of this gem is that a set/variant is required. Some supported libraries don't have multiple variants (maybe just “solid” or “outline”).
Also any custom added library might not have one, giving the user mental overhead to come up with a name. It should also be fairly straight-forward to skip it.
Places it is used:

https://github.com/Rails-Designer/rails_icons/blob/main/lib/rails_icons/icon.rb#L7
https://github.com/Rails-Designer/rails_icons/blob/main/lib/rails_icons/icon.rb#L29
https://github.com/Rails-Designer/rails_icons/blob/main/lib/rails_icons/icon.rb#L50 (could use a small refactor too)
https://github.com/Rails-Designer/rails_icons/blob/main/lib/rails_icons/icon.rb#L75

I would like to give this a try 😄

Implementing this may cause issues with the new sync engine (#12) as it relies on the variant key to run.  I can see having a suggestion of solid/outline/etc already in the placeholder for the configuration a simpler solution to this.


Implement Share button on Each Application

Issue: Add Share Button on Application Cards
Description
The current application management lacks a direct sharing feature for individual cards. Adding a "Share" button on each card will enhance user experience by allowing seamless sharing of application details with friends or contacts.
Proposed Solution
Integrate a "Share" button/icon on every application card, enabling users to easily send application details via various communication channels (email, messaging apps, etc.) to their contacts, fostering collaboration and networking opportunities.
Benefits

Facilitates networking: Users can effortlessly share job opportunities with friends or contacts.
Enhances collaboration: Allows for easy exchange of application details, fostering a collaborative approach to job hunting.
Improves user engagement: Encourages users to interact more with the app, increasing its usability and value.

Outcome/Result
Upon successful implementation, users will have a convenient "Share" feature on each application card, enhancing the app's usability and encouraging collaborative job hunting.
Readme Update
Addition: Share Button on Application Cards

Added a "Share" button/icon on each application card for easy sharing of application details with friends or contacts.
Improved user experience by facilitating seamless communication and collaboration in the job hunting process.
Updated functionality details available in the documentation for a better user understanding.

I think we would need to configure an email for this , shall we create a new service email for career flow @amritav

Yes, we can do that. Use<EMAIL_ADDRESS>

Done


Fix Lossless+Progressive JXL and add debug options.

Setting CODEC_DEBUG in the JXL Makefile will produce a debug build (with
error messages enabled).
Rebased from #847

I think I'd prefer not to include the debug changes in Makefile. If you can run make directly, then you can pass necessary flags from the command line like make CXXFLAGS="-g -DJXL_DEBUG_ON_ALL_ERROR=1 -s ASSERTIONS=1" or any other set useful for a particular build.
My earlier suggestion to add things to Makefile was meant to be as a temporary quick measure to avoid having to pass those through to the Docker container.

I think I'd prefer not to include the debug changes in Makefile. If you can run make directly, then you can pass necessary flags from the command line like make CXXFLAGS="-g -DJXL_DEBUG_ON_ALL_ERROR=1 -s ASSERTIONS=1" or any other set useful for a particular build.
My earlier suggestion to add things to Makefile was meant to be as a temporary quick measure to avoid having to pass those through to the Docker container.

I think there is some value in having an easy way to come up with a debug build (and I'm not sure CXXFLAGS would be passed to jxl).
If you have a strong opinion I can revert this though.

and I'm not sure CXXFLAGS would be passed to jxl

Yeah it would be, CMake reads them from the environment (maybe you need CXXFLAGS="..." make instead of what I wrote though).

I reverted the DEBUG mode changes.


IndexCreate won't work anymore - Promise Issue

Warning: a promise was created in a  handler but was not returned from it
    at Term.run (/Users/chriscates/projects/rydr/node_modules/rethinkdbdash/lib/term.js:145:15)
    at /Users/chriscates/projects/rydr/app.js:94:10
    at fn (/Users/chriscates/projects/rydr/node_modules/async/lib/async.js:741:34)
    at /Users/chriscates/projects/rydr/node_modules/async/lib/async.js:1208:16
    at /Users/chriscates/projects/rydr/node_modules/async/lib/async.js:166:37
    at /Users/chriscates/projects/rydr/node_modules/async/lib/async.js:701:43
    at /Users/chriscates/projects/rydr/node_modules/async/lib/async.js:167:37
    at /Users/chriscates/projects/rydr/node_modules/async/lib/async.js:1204:30
    at /Users/chriscates/projects/rydr/app.js:85:9

And the code
if (tableExists == false) {
      r.db('rydr').tableCreate('users')
        .run()
        .then(function(result) {
          finished(null, false);
        })
        .error(function(err) {
          finished(err);
        })
    } else {
      finished(null, true);
    }

Hmmm nevermind seems to be an issue with async.js

Can you provide a full script that produce this error. I'm not convinced that this is an issue in rethinkdbdash.

https://github.com/neumino/rethinkdbdash/issues/179 for reference.


"invalid_grant" after redirect

After redirect to app I got this error "invalid_grant".
How I can fix it?

Hi, I hope you were able to get past this issue.
As we will be deprecating this package, we will not be diving into this issue.
If you need further help, you might try asking a question on Stack Overflow.
Best of luck & thank you for the error report!

Hi, I hope you were able to get past this issue.
As we will be deprecating this package, we will not be diving into this issue.
If you need further help, you might try asking a question on Stack Overflow.
Best of luck & thank you for the error report!


Create a Graph for Lighthouse score history

We recently added tasks to generate a Lighthouse score everyday, we should plot this information in the detail page (maybe also include other metrics from the Lighthouse report)

I am testing with the Annotation Chart:


Log in to AWS ECR automatically using the cluster-provided credentials.

As discussed in fluxcd/image-reflector-controller#139
This mostly restores the flux v1 functionality (for me)
if the environment variable USE_ECR is set, logs in to the AWS Elastic
Container Registry in the image URL by fetching a temporary token from
AWS.

This looks like it needs to be rebased before it can be approved. (Is there any other feedback that was left here, which still needs to be addressed?)

@kingdonb I am very sorry for the long inactivity, I am quite busy atm... I'll try to follow squaremos rebase tutorial above ASAP.

Sorry for the interruption! This PR got a mention in our bug scrub event today, I think there is no urgency, it was just the right age and staleness for this issue to come to the top of our list and get our attention, I'm glad to see it moving ahead.
Thank you for doing the rebase; it looks like the next step is for a maintainer to approve the test execution and have another look for review.
Also, 🙌  first time Flux contributor high-five!

Hello all,
Nice work being performed here, we are looking forward to using it. As of now, we use a pods that retrieves a token every 6 hours and stores it as kubesecret to be used by the image reflector controller.
Do you have any idea when this PR could be merged?
Thanks.

I'm going to rebase this and put it in another PR -- usually I would rebase and push to the fork, but I don't want to mess with someone's main. @MartinEmrich you will still get the credit, don't worry ;-)

@squaremo sure, do whatever you have to, no worries! :)
THB, navigating all these processes with git, forks, branches, rebases, checks, reviews and stuff seems to be more hassle than implementing these few lines of code... Maybe I'm getting old, but in hindsight diff -Naur+email was easier.
So I apologize if my ignorance held this up more than necessary.

Maybe I'm getting old, but in hindsight diff -Naur+email was easier

Ha yep, fair enough. I think it's worth brushing up on git in general, and all those things you mention get easier, but it is steep hill to climb to scratch just one itch*, that's true.
(*A mixed metaphor should be derailed, no matter how it sings!)


Version question

Which version is currently stable for production?
The readme refers to mgechev/angular-seed.git for start and update, but the last release is releases/tag/4.0.0.

The seed uses latest Angular. We're keeping the code in master stable.


Cookie authentication does not work when host URL includes a path

Repro Steps

Create new ASP.NET Core web application from the new project template in VS 2017. Use 'individual accounts' authentication.
dotnet ef database update, if needed.
Add .UseUrls("http://localhost:5000/testapp") in program.cs to set the URL for the host to listen on.
Switch to Kestrel host, F5, and navigate to http://localhost:5000/testapp

Actual behavior:
The web application loads fine and all assets are retrieved properly (despite the URL in the path). New users can be registered. However, logging in a user fails. After logging in, the web app acts as if no user is logged in. The Kestrel log says:
info: Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationMiddleware[7]
      Identity.Application was not authenticated. Failure message: Unprotect ticket failed

Expected behavior:
Users can properly log in even when the web host listens on a URL including a path.
If "/testapp" is removed from the URL (so that it doesn't include any path but the root), then logging in works again, as expected.

It should be noted that Kestrel has removed support for application root paths (e.g. /testapp in UseUrls). https://github.com/aspnet/Announcements/issues/230
That said, the application root path should not have anything to do with the data protection context. The path is set on the response cookie, but it's not part of the protection. https://github.com/aspnet/Security/blob/305ccf9cc5d2ce777e5fb147013966924c9aca8e/src/Microsoft.AspNetCore.Authentication.Cookies/CookieAuthenticationHandler.cs#L151
https://github.com/aspnet/Security/blob/305ccf9cc5d2ce777e5fb147013966924c9aca8e/src/Microsoft.AspNetCore.Authentication.Cookies/CookieAuthenticationHandler.cs#L81
We'll need to reproduce this and see what's going on.

Ah, I didn't realize that application root paths weren't supported in UseUrls anymore; thanks for the pointer!
For what it's worth, I just tried UsePathBase and everything works as expected when I go that route. So, this is probably lower priority since the recommended scenario is working. Still would be interesting to understand why it didn't work with an application root path in UseUrls, though, since that also seems like it should work.

@mjrousos there shouldn't have been any difference between what kestrel was doing and what UsePathBase does. But since the feature is now removed then I'll close this.


Freight CRD

While working on the QueryFreight API, it made me realize that freight is just metadata that we are constantly carrying over from Stage to Stage. And so the implementation of QueryFreight, is a bit awkward. It iterates all Stages first to collect all freight in each Stage. Then it does a bunch of deduplication code to prevent duplicates from returning. Which btw, is not fool-proof: there's nothing to stop someone from editing their stage's freight contents and messing up the result. Principally, we consider freight as something immutable.
For this reason, I started to wonder if we should start treating freights as a first-class resource in Kargo with its own CRD.
Here are some of the benefits I see:

Easier to query. The QueryFreight API would be improved to just deal with the CRs.
Freight would become more immutable. We would treat the Freight CR as something that should only ever be created and deleted (for GC), but never updated or patched. We could use kubernetes RBAC to ensure this is the case.
Lifecycle of Freight would be decoupled from lifecycle of stages. In other words, we could recreate a Stage without losing Freight.
We would reduce the amount of duplicate metadata in the Stage status, since details of the freight (e.g. image tag) would be kept in the CR.
We could keep more freight history. Currently, we limit to 10 freight per Stage. But by putting it into a different CR, we could keep an indefinite amount of freight.
When it is a kubernetes object, we could be more creative on how to take advantage of that property. For example, we could:

use ownership references to indicate the freight is still in use and prevent garbage collection.
label and index freights with the way we intend to query against them
have other things besides Stages, deal with and reference Freight

Let's have this be the main topic of discussion at next week's meeting.

Sure, though I don't want to get too distracted with the proposal since it's not blocking any functionality. And I'm also not suggesting we do this for v0.1.0.

Oh. Thank you for clarifying.

Off today, but had some thoughts about this that I wanted to capture for future discussion.
I'm not 100% sure of this, but the thought has crossed my mind -- what if Freight is a CRD, but Promotion is not?
I'm trying to look at this through a pets vs cattle lens. Freights seem to be named things that we care about. i.e. Pets. Promotions only seem to be the time a Stage spends transitioning between two Freights. I don't think they're noteworthy over the long term. i.e. Cattle.
I think this could also move us closer to the Kubernetes ideal in terms of the declarative vs imperative dichotomy.
So image:

Stage reconciler for a "zero stage" (subscribed directly to repos) finds new Freight, just like it does today, but instead of making it "available" within the Stage's status, it just creates a CR to represent the new Freight.

Stage spec specifies the desired Freight. (We don't do this today.)

Stage status doesn't need to directly track what freights are available, but it can still maintain history of what Freights have moved through the Stage.

Freight reconciler tracks qualification of each Freight across all stages in Freight status. i.e. Freight controller is constantly asking, "In what stages has this Freight becomes fully healthy?" Any time a Freight qualifies for the first time in a new Stage, that new qualification makes it available to Stages immediately downstream from that one. For Stages where auto-promotion is enabled, promotion is then effected by the Freight reconciler updating the desired freight in the

Manual promotion also is just a matter of updating Stage spec with a reference to the desired Freight.

Just some ideas for later.
fwiw, I also estimate that effort-wise, this isn't too much of a pivot.

In terms of RBAC, we keep everything as it is today, using the "dolphin verb" promote to denote special ability to mutate the desired Freight in a given Stage spec. That will then be enforced with a validating webhook that monitors changes to that field.

but instead of making it "available" within the Stage's status, it just creates a CR to represent the new Freight.
Stage status doesn't need to directly track what freights are available, but it can still maintain history of what Freights have moved through the Stage.

Yes. This is exactly what I am thinking.

what if Freight is a CRD, but Promotion is not?
Stage spec specifies the desired Freight
Manual promotion also is just a matter of updating Stage spec with a reference to the desired Freight.

This is an interesting proposal. I would want to know how pull request promotion would work which is imperative by nature. I do think having a Promotion object lying around in the system with a record of how it failed, links to the pull request, etc... is still useful to keep around. I also think that Promotions are simple today, but may be user-defined and will be complex tomorrow.

using the "dolphin verb" promote to denote special ability to mutate the desired Freight in a given Stage spec.

Yes, one of the original reasons for a Promotion CRD was to have separate RBAC for CRUD on stage vs. promoting. e.g. kubectl create a promotion object. We've since learned that dolphin verbs can support this without an actual CRD.

I would want to know how pull request promotion would work which is imperative by nature. I do think having a Promotion object lying around in the system with a record of how it failed, links to the pull request, etc... is still useful to keep around.

I wouldn't want to lose any of that either. I would put in in the Freight's status, keyed by Stage name.
"Did this Freight qualify for Stage x? Yes? Great! No? Here's structured details on what went wrong."

I wanted to capture some more thoughts I just had that a Freight CRD will enable.
Today, a zero environment can subscribe to one or more of:

image repos
git repos
helm repos

When thinking about this, these things are just just mechanisms that produce freight.
I wonder if we could change our mentality a bit, and instead of Stages subscribing to these specialized implementations (image, git, helm), Stages could be subscribed to a stream of Freight, without caring about how they were produced since it was done elsewhere.
This would result in some changes:

We would need a way for users to define something that produces Freight (e.g. FreightFactory)
Stages would no longer have syntax to subscribe to image/git/helm explicitly but rather a selector of freight. Though, I still like the syntax of subscribing to upstream Stages.

The benefits I see are a decoupling the Stage reconciler's responsibility for understanding how to produce freight (clone git, etc...) and focus more on other things like verification, health, and initiating promotions.

Agree with all of that!

In terms of visualization, I would still want to see all the repos that supply the freight on the far left of the DAG.

In terms of visualization, I would still want to see all the repos that supply the freight on the far left of the DAG.

something like this:


[RESOLVED] High ICMP ping loss

Problem started at 16:19:14 on 2023.08.01
Problem name: High ICMP ping loss
Host: ZO-FG
Severity: Warning
Operational data: Loss: 66.67 %
Original problem ID: 34526
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23124&eventid=34526

Problem has been resolved in 4m 0s at 16:23:14 on 2023.08.01
Problem name: High ICMP ping loss
Host: ZO-FG
Severity: Warning
Original problem ID: 34526


Shellygill/auth profile doc ref

@TADraeseke - some minor updates to the Authentication Profile sample, just to add a guide code code snippet reference, and while I was there I reformatted to the standard, moved strings to resources, and updated to Java 8.

Thanks @TADraeseke - pushed some updates.


App creating CRASHPAD MINIDUMP when running threejs based site

Steps to reproduce

I copy the test html/js file (I put them in 1 file for testing) to https://ordinarai.com/e/
open the website using webview_flutter
error occured

note: you can get the html/js source code from here: https://ordinarai.com/e/index.html.txt
note: rarely I can open the website without problem, so it's kinda intermittent, but most of the time, it produce error
Expected results
should not crash, just like if opening https://ordinarai.com/e/ using web browser, no problem at all.
Actual results
the app crashed.
Code sample
Code sample

late final WebViewController webViewController;
String url = "https://ordinarai.com/e/";

late final PlatformWebViewControllerCreationParams params;
params = const PlatformWebViewControllerCreationParams();
final WebViewController controller = WebViewController.fromPlatformCreationParams(params, onPermissionRequest: (resources) async {
  return resources.grant();
});
controller
  ..setJavaScriptMode(JavaScriptMode.unrestricted)
  ..setNavigationDelegate(
    NavigationDelegate(
      onProgress: (int progress) {
      },
      onPageStarted: (String url) {
      },
      onPageFinished: (String url) {
      },
      onWebResourceError: (WebResourceError error) {
        debugPrint('''
          Page resource error:
          code: ${error.errorCode}
          description: ${error.description}
          errorType: ${error.errorType}
          isForMainFrame: ${error.isForMainFrame}
      ''');
      },
      onNavigationRequest: (NavigationRequest request) {
        return NavigationDecision.navigate;
      },
      onHttpError: (HttpResponseError error) {
      },
      onUrlChange: (UrlChange change) {
      },
      onHttpAuthRequest: (HttpAuthRequest request) {
      },
    ),
  )
  ..addJavaScriptChannel(
    'FLUTTER',
    onMessageReceived: (JavaScriptMessage message) {
      //FROMJS(message.message); //call function FROMJS to process the message
    },
  )
  ..addJavaScriptChannel(
    'PRINT',
    onMessageReceived: (JavaScriptMessage message) {
      print("[JS] "+message.message);
    },
  )
  ..loadRequest(Uri.parse(url));

AndroidWebViewController.enableDebugging(true);
(controller.platform as AndroidWebViewController).setMediaPlaybackRequiresUserGesture(false);

webViewController = controller;

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
I guess the error dump is too long, I put them here: https://ordinarai.com/e/error-dump.txt

Flutter Doctor output
Doctor output
C:\am\ss>flutter doctor -v
[✓] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22631.4317], locale en-US)
    • Flutter version 3.24.3 on channel stable at c:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (7 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\yohan\AppData\Local\Android\sdk
    • Platform android-35, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio1\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop Windows apps (Visual Studio Build Tools 2022 17.8.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Visual Studio Build Tools 2022 version 17.8.34330.188
    • Windows 10 SDK version 10.0.22621.0

[✓] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)

[✓] Android Studio (version 2023.2)
    • Android Studio at C:\Program Files\Android\Android Studio1
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874)

[✓] VS Code, 64-bit edition (version 1.87.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • SM T225 (mobile)  • R9RT101A1SM • android-arm64  • Android 13 (API 33)
    • Windows (desktop) • windows     • windows-x64    • Microsoft Windows [Version 10.0.22631.4317]
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 130.0.6723.92
    • Edge (web)        • edge        • web-javascript • Microsoft Edge 130.0.2849.46

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I checked this on Android (app) but the model is loaded as expected without crashing (tested on Pixel 7, Android 14)

Demo screenshot/video

Which device are you seeing the issue with? (OS, model name). Please provide the versions of webview_flutter and webview_flutter_android (you should find this inside pubspec.lock file)
Another test is to run on Android native webview project on the same device to see if the crash appears or not.


VSC - the GUI problems (many icons)

Here is how looks my VSC GUI

I have not enough place for file cards and problems to find them, easy managment.
The cards are in conflit with open editors from Explorer
https://github.com/microsoft/vscode/issues/83127
In related problem I sugested changes to turn on horizontal menu for icons, and for this type maybe we need menu toolbar with normal icons, shortcut to hide this toolbar and icons
https://github.com/microsoft/vscode/issues/20485
(https://cloud.githubusercontent.com/assets/25403861/22858261/07e83abc-f0b8-11e6-99f5-0617d8852cf9.png)
There is other problem with VSC and cognitive thinking/mindset. The all menu in top don't have icons. Try understand that "Reading" is "Observing" proces, thats mind any sign of word is graphical and visual efect and tranlated to database of sense, thats mind that we "working" to recognize functions many times..waste "human resoureces" - thats why icons are more friendly, thats shortcuts icons are "nice". VSC need some kansei thinkig and mindset.. UX specialist?

@misolori I remember when we initially designed this experience (cc @stevencl) that we never wanted to show more than 3 actions until we put the rest into overflow menu. I have a feeling since there is no way to disable UI contributions individually, we might need to enforce this experience when we detect too many icons.
Should we force actions to appear in the "..." menu if we see > 3?
@ManPython the only workaround for you currently is to:

either disable extensions individually that add these actions
maybe disable tabs (via settings) so that you get the full width of the editor for the title

I do think it's worth setting a limit on the number of actions shown and placing the rest in the overflow menu (that's a common pattern). Though I'm not sure what the right number would be, as certain cases require more than others:

I would also expect this to be configurable via a user setting, and also allow users to right-click on icons and hide them just as we do in the activity bar, status bar, and panels.

Related: https://github.com/microsoft/vscode/issues/46403

I think that the best solution is to move these part with icon to special menu as toolbar or made class that colectin icons from eny ext as part of toolbar and offer to colect this type toolbars in global class and for this offer show/hide toolbars from menu view as in classic GUI in other software. Then we have freedom for cards as normaly. In setting we can offer option to hide some toolbar icons maybe.

IMO, the best option would be to allow the user to easily decide if an icon should be in the "toolbar" or in the menu. And then I would also go further to allow users to hide/remove menu contributions.

just add an option allow all icons hide in "..."

Let's fold this into https://github.com/microsoft/vscode/issues/46403


Debug Hover: Allow keyboard to search through properties

When hovering over an object (while the breakpoint is triggered) you can get a list of properties. Sometimes that list is very long. Is it possible to have a similar experience to the Explorer (in the side bar), where typing a letter moves the focus to that property?
For example in the gif below i would expect to type "me" and be taken down to "memoizedProps"

When the hover has focus the keyboard doesn't change content in the editor anyway so this should be safe to add without changing people's workflow.

@jasonwilliams good catch, thanks for opening this issue. Now we support that you can click in the debug hover and type the name of the variables to be navigated to them. This already works in the variables view.
To verify: open debug hover, click on it, start typing the name of the variable from the hover and make sure that variable gets focused

This is great to see, but I think we might need a little polish here when dealing with sorting. We should not make the hover smaller when filtering down to a smaller tree, otherwise if your mouse it outside of it this can happen:

I agree, my expectation would be moving towards the target but keeping the hover window the same size

@jasonwilliams yeah that is the default behaviour
@connor4312 we should just disable filtering in the debug hover. I have now done that, and we are only supporting the "simple keyboard navigation" = no filter, focus just jumps based on pressed keybingind.

@isidorn can you go straight to top straight to bottom via the keyboard? (Sorry this may need to be a separate request if not)

@jasonwilliams is the rest of the implementation working ok right now?
If so, I think we can set this issue to verified (or z-author-verified), since a new Stable is shipping soon, and we'd like to get various issues verified before then.
Meanwhile, I think you can write https://github.com/microsoft/vscode/issues/127716#issuecomment-873220290 onto a new feature request, and link it back to this issue.

I can verify

I won’t be at my machine for a few days so would need to delegate verifying to @connor4312

@jasonwilliams yeah, home or cmd + left for first element, end or cmd+right for last element.


Running top level promises may terminate the node process early.

Given some code like this:
import { fork } from 'effection';

fork(function*() {
  console.log("start");
  yield someController();
  console.log("finish");
});

I'd expect this to always print finish, no matter how controller is implemented, but this is actually not the case! If controller doesn't do anything which creates a listener, then node will shut down before the controller has a chance to finish. This seems a bit surprising to me.
For example listening to an EventEmitter does not create a listener. Which is a bit surprising!
IMO, calling fork in the global context should prevent node from exiting until the fork completes, but the question is how would we implement this?

Here's my full example code with an event listener which demonstrates the bug
import { fork, timeout, Controller } from 'effection';
import { EventEmitter } from 'events';

let someEmitter = new EventEmitter();

function controller(): Controller {
  return (execution) => {
    let resume = () => { execution.resume("foo") };
    someEmitter.on("thing", resume);
    return () => {
      someEmitter.off("thing", resume);
    }
  };
};

let myFork = fork(function*() {
  console.log("start");
  yield controller();
  console.log("finish");
});

I think that node might be right in that there is no way that the code could actually ever run, because there is no native event OS event, timer, socket data, etc... that could ever run that would  trigger that event, so the process exits.

Hmm probably. Let's close this then!


Refactor and destructure resData after performing fetch API calls

resData is a massive object parsed by res.json(). To pull anything from it, a lot of property drilling is required. Destructure those properties for better code clarity.
In most lines, we can replace
.then((resData) => {
for
.then(({errors, data: {graphQL-resolver: {all-properties}}}) => {
and then only replace graphQL-resolver with whatever query/mutation we are actually calling for and then all-properties for the individual properties we need. Obviously, we also need to update those properties in this,setState.
This issue is merely for readability improvement and offers no function processing performance upgrades.

This issue is now completed thanks to PR #3.


Remove XMBC from interface strings

XMBC was renamed to Kodi almost 6 years ago. Probably, no one is still using versions before 14 up to now.
Shouldn't "XMBC" be dropped from interface strings like this one? https://github.com/xbmc/Kore/blob/e24dcca1ce2e3349f014f898deb4eed786abac78/app/src/main/res/values/strings.xml#L81

Sure, just send a PR.


Use warnings in checkflag on common interface

Instead of throwing a Julia error, the common interface will now warn. This makes Sundials compatible with the addon functionality like parameter estimation which can choose parameters that diverge. Before, this would make Sundials throw an error, which would error the higher level routine. Now it will return the current solution at the time of the error, which the parameter estimation techniques know how to handle.

Example that used to not work:
using DiffEqParamEstim, OrdinaryDiffEq, ParameterizedFunctions,
      DiffEqBase, RecursiveArrayTools
using Base.Test

# Here's the problem to solve

f = @ode_def_nohes LotkaVolterraTest begin
  dx = a*x - b*x*y
  dy = -c*y + d*x*y
end a=>1.5 b=1.0 c=3.0 d=1.0

u0 = [1.0;1.0]
tspan = (0.0,10.0)
prob = ODEProblem(f,u0,tspan)
sol = solve(prob,Tsit5())

# Generate random data based off of the known solution

t = collect(linspace(0,10,200))
randomized = [(sol(t[i]) + .01randn(2)) for i in 1:length(t)]
data = vecvec_to_mat(randomized)

fit = lm_fit(prob,t,vec(data),[1.0],CVODE_BDF(),show_trace=true,lambda=10000.0)

import Optim
result = Optim.optimize(obj, [1.0], Optim.BFGS())

Optim's BFGS goes into a parameter regime where the Lotka-Volterra equations diverge. This makes it so that way Sundials fails. The previous failure would cause the whole parameter estimation routine to exit. However, now it just calculates a high cost in the cost function, so Optim continues.
Down the line, the warning mechanism will be replaced with a verbosity command to turn on/off warnings and retcodes. This will be the standard DiffEq setup, but the retcodes are not implemented yet so we'll stick with this for now.

This PR is built off of the branch from #113.

Coverage increased (+0.3%) to 18.53% when pulling 62ee1b1c522dceaa96bdddf8d5a70180fb9bf0ad on common_warn into cf0634d867961c834872849a909c015d70fa59f3 on master.

Coverage increased (+0.3%) to 18.53% when pulling b35bbd7d4b918c07a5ea372983a00166f6ba12b8 on common_warn into cf0634d867961c834872849a909c015d70fa59f3 on master.

Moved this to #116 so that way it's not on a branch dependent on #113

Coverage increased (+0.3%) to 18.53% when pulling daf110c1b33604a2d9b84e8eba856fc134895d57 on common_warn into 2022a4b6d69d6a3eedb61944f98d7c07bdf4f56f on master.

Coverage increased (+0.3%) to 18.53% when pulling daf110c1b33604a2d9b84e8eba856fc134895d57 on common_warn into 2022a4b6d69d6a3eedb61944f98d7c07bdf4f56f on master.


Make sidebar responsive

I want to make sidebar responsive.
[GSSOC'21]
Screenshot:

Pleased assign me this issue @sairish2001

@sairish2001 Please assign me this issue

Go ahead
Deadline 10 May,2021


Practice Dashboards not loading on staging site

e.g. http://staging.openprescribing.net/practice/K84010/

Probably related to #567


⚠ Bofrost.be has degraded performance

In d9ae297, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1605 ms

Resolved: Bofrost.be performance has improved in 2e362dc after 6 minutes.


not RBAC friendly?

I'm using kubernetes 1.7.1, and have a following problem:
time="2017-07-26T15:36:02Z" level=info msg="elasticsearch operator starting up!"
time="2017-07-26T15:36:02Z" level=info msg="Using Variables:"
time="2017-07-26T15:36:02Z" level=info msg="   baseImage: upmcenterprises/docker-elasticsearch-kubernetes:5.3.1"
time="2017-07-26T15:36:02Z" level=info msg="Using InCluster k8s config"
panic: User "system:serviceaccount:default:elasticsearch-operator" cannot get thirdpartyresources.extensions at the cluster scope. (get thirdpartyresources.extensions elasticsearch-cluster.enterprises.upmc.com)
goroutine 1 [running]:
github.com/upmc-enterprises/elasticsearch-operator/pkg/k8sutil.(*K8sutil).CreateKubernetesThirdPartyResource(0xc420186b10, 0x10, 0xc420157fe0)
	/Users/slokas/godev/src/github.com/upmc-enterprises/elasticsearch-operator/pkg/k8sutil/k8sutil.go:285 +0x1b2
github.com/upmc-enterprises/elasticsearch-operator/pkg/controller.(*Controller).init(0xc420523e70, 0x7f69c66044b0, 0x0)
	/Users/slokas/godev/src/github.com/upmc-enterprises/elasticsearch-operator/pkg/controller/controller.go:69 +0x2e
github.com/upmc-enterprises/elasticsearch-operator/pkg/controller.(*Controller).Run(0xc420523e70, 0xc420157fe0, 0xc4203f6960)
	/Users/slokas/godev/src/github.com/upmc-enterprises/elasticsearch-operator/pkg/controller/controller.go:58 +0x2f
main.Main(0xc4200001a0)
	/Users/slokas/godev/src/github.com/upmc-enterprises/elasticsearch-operator/cmd/operator/main.go:85 +0x340
main.main()
	/Users/slokas/godev/src/github.com/upmc-enterprises/elasticsearch-operator/cmd/operator/main.go:110 +0x22

Does that mean that RBAC rules are missing?

Hey @sokoow, currently I don't have the RBAC rules in place, I'm working on it now and should have this week, unless you want to take it on and push up a PR. Will touch base back soon!

Hey @sokoow, I found some missing pieces in the rbac rules and updated them. The breaking change is you need to make sure to reference the service account in the namespace where the operator will run.

...also just tested on my production 1.7.2 cluster and getting the same error, but my testing on 1.7.0 inside minikube worked fine.

Minikube is not always a good way to test things... ;)


Adapted testsuite for jdk17

WIP adapting branch currently used to test JBoss EAP

This version of RESTEasy is not in EAP and will not be in EAP.

I see e.g. jboss-eap-8.0/modules/system/layers/base/org/jboss/resteasy/resteasy-client/main/resteasy-client-4.7.4.Final-redhat-00001.jar .... what is the correct version and branch to use for testing?

@tommaso-borgato It will be 6.1.0.Final, currently 6.1.0.Beta1 in WildFly Preview. That version is for Jakarta EE 8, 6.1 is for Jakarta EE 10.
I also do no think we should be adding these arguments. RESTEasy does not require these as they are for WildFly. While we do test on WildFly, I don't see a requirement to provide the JVM arguments required. If RESTEasy itself requires a new argument we need to know.


Validate commands in multiparser

It was reported in https://github.com/sbt/sbt/issues/4808 that compared
to 1.2.8, sbt 1.3.0-RC2 will truncate the command args of an input task
that contains semicolons. To address this, I slightly reworked the
multiparser to only accept multi commands if the each semicolon
delimited part is a valid command. This was achieved by changing
(s.combinedParser & cmdPart) | cmdPart to (s.combinedParser & cmdPart).
This fixes the issue because say the user is running an input task, foo,
with the arguments bar;baz, then the multi parser will parse it as:
List("foo bar", "baz"). If "baz" isn't a valid command, it gets rejected and we fallback on the remaining parsers defined for the state.
This isn't a perfect solution, because certain multi commands that
theoretically could work do not (this is illustrated in the last
scripted test), but it should at least resolve #4808.

Superceded by #4811


Flashing a Sonoff Basiczbr3

Hello,
Just discovered this firmware and I am new to the whole Zigbee DIY ecosystem, only had experience with ESP8266 so far.
I am thinking of buying the Sonoff Basiczbr3, but I have a Philips Hue Hub and I know by default it does not work.
Is it possible to flash it with this firmware, and if so, how?
Thank you and sorry if this is not the right place to ask this.

+1 I am also wondering if "router" Z-Stack-firmware by @Koenkk can be flashed on Sonoff Basic ZBR3?
https://www.itead.cc/sonoff-basiczbr3.html
As I understand Sonoff BASICZBR3 uses a CC2530 or CC2531 Zigbee chip from Texas Instruments and as such probably has an older (1.2.x) version of Z-Stack firmware, but the latest custom Z-Stack firmware by Koenkk also supports running a custom 3.x version of the Z-Stack firmware on CC2530 and CC2531 chips, meaning that hopefully the custom Z-Stack router firmware from Koenkk could probably, in theory, be modified to run the new Sonoff Basic ZBR3?
If possible then these could possibly be great as "routers" to extend the range in a Zigbee mesh-network.
FYI, I also sent this question in as a to request directly to Jerry Shi at Itead/Sonoff who at least replied saying that he would forward the request to the engineers in their research department.

https://www.reddit.com/r/sonoff/comments/elpueo/sonoff_basiczbr3_could_support_zigbee_30_or/

More information:

https://notenoughtech.com/home-automation/sonoff-basic-r3-zigbee/
https://notenoughtech.com/home-automation/sonoff-basic-r3-teardown/

Sonoff BASICZBR3 is always a router, why else flash it?

Sonoff BASICZBR3 currently comes with Z-Stack 1.2 firmware with a "Zigbee Home Automation" profile so it does not support the Zigbee 3.0 profile. Therefore, I want to flash it with Z-Stack 3.x firmware because I want it to be a Zigbee 3.0 profile router instead of just a router for the "Zigbee Home Automation" profile.
Other than making Sonoff BASICZBR3 act as a Zigbee 3.0 router another benefit to non-Zigbee2mqtt users is that it should as well make it compatible with other hubs/gateways/bridges that do not support the "Zigbee Home Automation" profile, such as the Philips Hue Bridge, (I am also pretty sure IKEA Trådfri Gateway do not support Sonoff BASICZBR3 because it uses a "Zigbee Home Automation" profile).

@Gamester17
Sorry for the off-topic but I've just realised that I don't fully get one thing. Do this firmware: Koenkk/Z-Stack-firmware/tree/master/router/CC2530_CC2591/bin support Z-Stack 3.0? I thought that it's Z-Stack 1.2. Or are you talking about coordinator firmware (Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_3.0.x/bin?
Thanks! And sorry for OT once again.

@fi-sch See https://github.com/Koenkk/Z-Stack-firmware/issues/153 Summery; No, there is not yet a Z-Stack 3.0 (3.0.x) based router firmware available for CC2530 and CC2531

I am wrote article about alternative firmware for this Sonoff :)
But in russian https://habr.com/ru/company/iobroker/blog/495926/

Any chance that you can post binary hex file(s) that are ready to be flashed by non-developers too?
Zigbee router firmware hex for Sonoff BASICZBR3 (a.k.a. Sonoff BASIC ZBR3 / Sonoff BASIC ZB R3)?
Would be nice if also could submit to Koenkk repo:

https://github.com/Koenkk/Z-Stack-firmware/

Moved firmware request discussion to #176