Investigate adding markdownlint

Not sure how many FPs we'll get.

After fixing bullet inconsistencies...
README.md:196 MD045/no-alt-text Images should have alternate text (alt text)
README.md:197 MD045/no-alt-text Images should have alternate text (alt text)
README.md:198 MD045/no-alt-text Images should have alternate text (alt text)
README.md:199 MD045/no-alt-text Images should have alternate text (alt text)
README.md:200 MD045/no-alt-text Images should have alternate text (alt text)
README.md:201 MD045/no-alt-text Images should have alternate text (alt text)
README.md:202 MD045/no-alt-text Images should have alternate text (alt text)
README.md:203 MD045/no-alt-text Images should have alternate text (alt text)
README.md:204 MD045/no-alt-text Images should have alternate text (alt text)
README.md:205 MD045/no-alt-text Images should have alternate text (alt text)
site/content/docs/5.0/about/license.md:12:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
site/content/docs/5.0/components/button-group.md:22 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/components/button-group.md:22 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Ensure correct `role` and provide a label"]
site/content/docs/5.0/components/buttons.md:108 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/components/buttons.md:108 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Link functionality caveat"]
site/content/docs/5.0/components/dropdowns.md:805 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h4; Actual: h5]
site/content/docs/5.0/components/dropdowns.md:805 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### `data-toggle="dropdown"` still required"]
site/content/docs/5.0/components/navs.md:231 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Working with flex utilities"]
site/content/docs/5.0/components/popovers.md:102 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "#### Specific markup required for dismiss-on-next-click"]
site/content/docs/5.0/components/popovers.md:139 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Making popovers work for keyboard and assistive technology users"]
site/content/docs/5.0/components/popovers.md:294 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "#### Data attributes for individual popovers"]
site/content/docs/5.0/components/scrollspy.md:261 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "#### Resolvable ID targets required"]
site/content/docs/5.0/components/scrollspy.md:267 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "#### Non-visible target elements ignored"]
site/content/docs/5.0/components/tooltips.md:96 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/components/tooltips.md:96 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Overflow `auto` and `scroll`"]
site/content/docs/5.0/components/tooltips.md:113 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h4; Actual: h5]
site/content/docs/5.0/components/tooltips.md:113 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Making tooltips work for keyboard and assistive technology users"]
site/content/docs/5.0/components/tooltips.md:291 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "#### Data attributes for individual tooltips"]
site/content/docs/5.0/content/reboot.md:134 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "{{< /markdown >}}"]
site/content/docs/5.0/content/reboot.md:437 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/content/reboot.md:437 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### jQuery incompatibility"]
site/content/docs/5.0/content/tables.md:622 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/content/tables.md:622 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Vertical clipping/truncation"]
site/content/docs/5.0/customize/optimize.md:46:3 MD034/no-bare-urls Bare URL used [Context: "https://medium.com/dwarves-fou..."]
site/content/docs/5.0/customize/optimize.md:47:3 MD034/no-bare-urls Bare URL used [Context: "https://lukencode.com/2018/07/..."]
site/content/docs/5.0/extend/icons.md:29 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- [{{ .name }}]({{ .website }}..."]
site/content/docs/5.0/forms/layout.md:343 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Alternatives to hidden labels"]
site/content/docs/5.0/forms/overview.md:59 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/forms/overview.md:59 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Associating form text with form controls"]
site/content/docs/5.0/getting-started/introduction.md:121:37 MD034/no-bare-urls Bare URL used [Context: "https://twitter.com/{{<"]
site/content/docs/5.0/getting-started/introduction.md:128:48 MD034/no-bare-urls Bare URL used [Context: "https://twitter.com/{{<"]
site/content/docs/5.0/getting-started/javascript.md:29 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Incompatible plugins"]
site/content/docs/5.0/getting-started/javascript.md:49 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Selectors"]
site/content/docs/5.0/getting-started/javascript.md:72 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## jQuery events"]
site/content/docs/5.0/getting-started/javascript.md:155 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h5]
site/content/docs/5.0/getting-started/javascript.md:155 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "##### Third-party libraries"]
site/content/docs/5.0/getting-started/rfs.md:11:32 MD034/no-bare-urls Bare URL used [Context: "https://github.com/twbs/rfs/tr..."]
site/content/docs/5.0/getting-started/rfs.md:17:132 MD034/no-bare-urls Bare URL used [Context: "https://github.com/twbs/rfs/tr..."]
site/content/docs/5.0/getting-started/rfs.md:86:138 MD034/no-bare-urls Bare URL used [Context: "https://github.com/twbs/rfs/tr..."]
site/content/docs/5.0/utilities/colors.md:47 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.bg-gradient-{{ .name }}`"]
site/content/docs/5.0/utilities/colors.md:53 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]
site/content/docs/5.0/utilities/colors.md:53 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "#### Dealing with specificity"]
site/content/docs/5.0/utilities/flex.md:26 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.d{{ .abbr }}-flex`"]
site/content/docs/5.0/utilities/flex.md:71 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.flex{{ .abbr }}-row`"]
site/content/docs/5.0/utilities/flex.md:124 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.justify-content{{ .abbr }}..."]
site/content/docs/5.0/utilities/flex.md:178 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.align-items{{ .abbr }}-sta..."]
site/content/docs/5.0/utilities/flex.md:232 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.align-self{{ .abbr }}-star..."]
site/content/docs/5.0/utilities/flex.md:258 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.flex{{ .abbr }}-fill`"]
site/content/docs/5.0/utilities/flex.md:289 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.flex{{ .abbr }}-{grow|shri..."]
site/content/docs/5.0/utilities/flex.md:415 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.flex{{ .abbr }}-nowrap`"]
site/content/docs/5.0/utilities/flex.md:440 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.order{{ $bp.abbr }}-{{ . }..."]
site/content/docs/5.0/utilities/flex.md:452 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.order{{ $bp.abbr }}-{{ . }..."]
site/content/docs/5.0/utilities/flex.md:615 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.align-content{{ .abbr }}-s..."]
site/content/docs/5.0/utilities/float.md:35 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `.float{{ .abbr }}-left`"]

https://github.com/twbs/bootstrap/runs/1417773283:
 markdownlint-cli2 v0.0.11 (markdownlint v0.21.1)
Finding: **/*.md !**/node_modules/**
Linting: 102 file(s)
Summary: 17 error(s)
site/content/docs/5.0/components/toasts.md:160 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
site/content/docs/5.0/components/tooltips.md:116 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]
site/content/docs/5.0/content/reboot.md:116:1 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* Lorem ipsum dolor sit amet"]
site/content/docs/5.0/content/reboot.md:118:1 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* Integer molestie lorem at ma..."]
site/content/docs/5.0/content/reboot.md:120:1 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* Nulla volutpat aliquam velit"]
site/content/docs/5.0/content/reboot.md:122:3 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* Purus sodales ultricies"]
site/content/docs/5.0/content/reboot.md:124:3 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* Ac tristique libero volutpat..."]
site/content/docs/5.0/content/reboot.md:126:1 MD037/no-space-in-emphasis Spaces inside emphasis markers [Context: "* Aenean sit amet erat nunc"]
site/content/docs/5.0/customize/optimize.md:51 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]
site/content/docs/5.0/getting-started/introduction.md:154:37 MD034/no-bare-urls Bare URL used [Context: "https://twitter.com/"]
site/content/docs/5.0/getting-started/introduction.md:161:48 MD034/no-bare-urls Bare URL used [Context: "https://twitter.com/"]
site/content/docs/5.0/getting-started/javascript.md:80 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]
site/content/docs/5.0/getting-started/rfs.md:11:32 MD034/no-bare-urls Bare URL used [Context: "https://github.com/twbs/rfs/tr..."]
site/content/docs/5.0/getting-started/rfs.md:17:132 MD034/no-bare-urls Bare URL used [Context: "https://github.com/twbs/rfs/tr..."]
site/content/docs/5.0/getting-started/rfs.md:86:138 MD034/no-bare-urls Bare URL used [Context: "https://github.com/twbs/rfs/tr..."]
site/content/docs/5.0/layout/columns.md:160 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]
site/content/docs/5.0/layout/columns.md:177 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]

Unfortunately, there's no way to ignore specific lines and most of these are false positives because we are using Hugo-specific markup.
Let's leave this open so that we track the issue.


[Feature] Need 'emphasis' option for 'line3D' type chart

What problem does this feature solve?
Currently, we have an 'emphasis' property for line type charts, to highlight a series upon hover.
But the same functionality is not available for line3D type charts.
This will help us highlight the line series upon hover.
If there is any other way to highlight the line series on hover, please let us know.

What does the proposed API look like?
Currently the options for line3D type chart looks like this:

Can we have a 'emphasis' option (like in line type charts):

Thank you.

hi, any update?

hi, any update?


UWP project Fails to add package

I can add the nuget package to every target plaform and the portable except UWP project.
When trying to add the package through the nugget manager I get the following error:

Failed to retrieve information from remote source 'C:\Program Files\Microsoft SDKs\Service Fabric\packages'.			0

That error looks unrelated to sqlite-net or SQLitePCL.raw, and I haven't seen it before.  It kinda looks like a config problem with your tooling.
Can you add any nuget packages to your UWP project?

No, I am sorry I wasted your time, I did not need to add one before. Can you point me in the right direction though?

No worries.
But I don't think I have enough info to point you in the right direction.  :-(
If you can't add any nuget packages to a UWP project, then probably something with your dev environment (Visual Studio, I assume) is messed up.  You might need to check your configuration or even reinstall.

It sounds like your dev environment is causing the problem. I'm going to close this in the hopes that you got it worked out.


update custom_components.md to use Kotlin and reflect current API

use Kotlin instead of Java in the docs
reflect current API
align with existing sample

Really nice, thanks for the PR @wiryadev


Uri doesn't honour http-specialities

VSCode Version: 1.14.2
OS Version: any

Steps to Reproduce:

Create and MD file and paste the following link:
https://azure.microsoft.com/en-us/?ru=https%3A%2F%2Fmicrosoft.com%2F%3Fparam1%3Dvalue1%26param2%3Dvalue2

Preview and click on the link. You will be sent to https://azure.microsoft.com/en-us/?ru=https://microsoft.com/%3Fparam1=value1&param2=value2

Notice that the url parameter ru is an encoded link. VSCode decodes the parameter and the final link becomes incorrect. Just compare to how GitHub works when you click on the link in step 1.
Reproduces without extensions: Yes

I don't think this is markdown specific. I see the same behavior when clicking on that link in the editor. Root cause seems to be our Uri parsing logic:
URI.parse('https://azure.microsoft.com/en-us/?ru=https%3A%2F%2Fmicrosoft.com%2F%3Fparam1%3Dvalue1%26param2%3Dvalue2')

returns
https://azure.microsoft.com/en-us/?ru=https://microsoft.com/%3Fparam1=value1&param2=value2

Root cause seems to be our Uri parsing logic:

The parsing logic doesn't return a string as that comment suggest but simply parses an input string into URI components (scheme, auth, path, query, fragment). The toString-method does percent encoding everything (without looking at the scheme for more specialised encoding tricks). When called with false the toString-method does only encode & and ? because those are needed to parse it again.
Assuming that the result of toString can always be used in http or any other specialised protocol is not correct.

dupe of #25852


Refine the new encoding schema

This pull request includes a performance improvement to refine the new encoding schema. It updates the encoding strategy for peer_idx field in the EncodedChange and EncodedOp struct. This leaves more room for further optimazation.
It also replace the derived FromPrimitive and ToPrimitive traits with manual impl for the ValueKind enum.

In my vscode, there is an error from_u16 no such associated item before. Does this PR fix this?

Yeah. It's actually an error in RA. But anyway


Fastnlight: Watch bsbforensic[\W_]*+c(?:o|0)m(?<!bsbforensic.com)

Fastnlight requests the watch of the watch_keyword bsbforensic[\W_]*+c(?:o|0)m(?<!bsbforensic\.com). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bsbforensic[\W_]*+c(?:o|0)m(?<!bsbforensic\.com) has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


No license

Hello,
Would love to use this but there is no license for this work meaning you own all the copyrights for it and I can't use it legally.
Thanks,
Michael Brune

Hi @MJBrune There is no license for this. Feel free to use it in your projects.

Hey Ryan,
Would feel a lot better if you had a license on this in clear terms, Even if its just http://www.wtfpl.net its better than no license as no license assumes you retain all rights in the USA so I couldn't legally use your code. There is a bit of a wiki page on some of the US law https://en.wikipedia.org/wiki/Software_copyright#United_States_practice if interested.
Thanks again,
Michael Brune

Hi @MJBrune ,
As per your request, I've added a License to this project. You can see it here: https://github.com/ryanjon2040/UE4-Map-Editor/blob/master/LICENSE

Hey @ryanjon2040 Thank you a ton! Not only have you made your code mode usable to me you have turned me to a new license I've not heard before. Thanks again! :D


Published Records validations

Validations are currently at the Job level, but what about validations we may want to employ across all published Jobs/Records?
One example was notifying users if published records contained > 1 dpla_isShownAt fields.  If so, that would imply duplicate records, at least insofar as what generally makes documents unique in DPLA.
Question is whether these would be:

opinionated

automatic check for dpla_isShownAt field
possible DPLA specific

scenario-based

like other validations, provide a mechanism by which validations could be applied

A key difference, might be validation across all published records.  This is something that hasn't been addressed yet.  All validations have been scoped to a single Record, they are not aware of Record beyond themselves.

FWIW, this could be done via an published analysis job?
Pro

workaround available now

Cons

analysis job does not update with publishing changes
duplication of Records for analysis job


C# port v0.2.0

Closes #5
Compared with the js and c++ version
license: same as the rest of the repo.

Thanks a lot!
I'm sorry for the delay in reviewing this PR, but for some reason GitHub is not notifying me of new PR via email, nor in my main profile page. Must find out why this is happening.


Add wait mechanism in preprocess between append and subsequent get_field

I consistently encounter a KeyError for the "token_..." field when using the 'elastic' output_type.  I can see that the field exists if I manually view an individual document in the browser, but it appears there is some lag between appending the tokenized document and actually being able to retrieve it back.  I added a 1-second wait after the append loop and that appears to have solved the problem.

OK, please do a PR.

fixed by 'fix_elastic_token_append' branch (merged).


Order folder by groups

It would be great to be able to order the folders by groups.

Which folders and groups are you talking about?

I mean folders on explorer window.
On VSCode each folder is like a project. But I'd like to group several folders (projects) under one group.

It sounds like you're asking for something similar to https://github.com/Microsoft/vscode/issues/396 or #2686


Encryption on save doesn't work anymore in 0.2.0

I can open a sops-encrypted file correctly, but when I save, even though the little popup in the bottom left says that the file was encrypted, it doesn't save it to the original file (and I don't know where it is saved..)
I appears to be a regression because this used to work. I have VSCode 1.50.1, and a friend with VSCode 1.50.0 can see it working on his end.
Any idea how I can help you debug that?

We had exact the same problem, somehow we fixed it by installing node.js in your WSL (in my case Ubuntu). So, hopefully it works for you too.

Hi, sorry about that. I didn't notice any problem during my yesterday testing before release v0.2.0. I tested it on node.js version v12.16.2.
Could you please send me the versions of node.js which it didn't work and which version it works now?
The reason is probably some upgrade of dependency which stopped supporting old node.js versions.
I try to get rid of node.js requirement on the next release.
Additionally, I'd like to have a way how to canary release beta versions before I release stable one however VSCode extension environment doesn't support it yet. You can vote here ;) https://github.com/microsoft/vscode/issues/15756

@misak113 , I hadn't installed jsnode in my WSL yet. I now have node.js v10.19.0 installed (works fine).
I was replicating the setup off my colleague (works for him), but we missed this one. So, that's probably a large part of the blame why we couldn't find the issue.


Ensured that the validate_user function performs as expected.

Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Manual pages are missing from the tagged release artifacts

Tagged releases have a different file upload pattern from just goreleaser causing etime.1 to not upload as a released artifact https://github.com/zimeg/emporia-time/blob/2b6f19d73e62294dee4702a78f65a52b4ae4e759/.github/workflows/release.yml#L129-L130
Example release:

https://github.com/zimeg/emporia-time/releases/tag/v1.1.0

https://cli.github.com/manual/gh_release_upload


Harden against invalid connectorId for setChargingProfile/clearChargingProfile.

Describe your changes
The validity of the connectorId is checked for setChargingProfile.
If present the validity of clearChargingProfile is checked.
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have made corresponding changes to the documentation
[ ] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
[x] I read the contribution documentation and made sure that my changes meet its requirements

Closed in favor of https://github.com/EVerest/libocpp/pull/925


Move cache save after is downloaded

this change  avoid download flink binary again if tests fails..
as now it uses archive this could be 10m of time

@eskabetxe I think @zentol had a similar idea with https://github.com/apache/flink-connector-shared-utils/commit/2f47df76f83d5e07e5e736b0344585d77cf51c85

I already have that change, but if tests fails, the save step is not done.
I'm only moving the step "Cache Flink Binary" before "Compile and test"


Spolpred wrapper

As far as I know the wrapper works properly, so I figured I'll do a pull request for whenever the cpp gets fixed

Sample output:

When I run with the default values, I get the following warning message:
WARNING: Screening Stop option must be switch on first ([-s on]).
Using -a default value: 50
Sample name:	/opt/galaxy/database/files/000/dataset_225.dat
Output name:	output.txt
Read Lenght:	75
Mode:	direct reads
Read Lenght:	75
Number of read-spacer matches below which absence is assigned:	4
Stop Reads Screening: OFF
It "screening stop" should be turn on by default.


AU 005-1-invalid-au appears to be making non-conformant call to agent profile

In execution of 005-1-invalid-au, a call is made to the agent profile API.  The call does not include an agent and is rejected by the LRS, making it impossible to complete the test.
Call  is made to:
lrs_endpoint//agents/profile?profileId=cmi5LearnerPreferences
Note: Not a typo, the call has two slashes.
Payload is:
{languagePreference: "en-US,fr-FR,fr-BE", audioPreference: "on"}
Our version was downloaded 12/9/21.  Is there a newer version?

The lack of an agent parameter is intentional. The request is used to verify

<IP_ADDRESS>-1
The Agent used in xAPI Agent Profile requests MUST match the actor property generated by the LMS at AU launch time.

And is verifying that the LRS returns a 400 status code (bad request). There is a newer version, latest is Jan 28, and I believe prior to this the status codes were either not checked or checked differently. See history at:
https://github.com/adlnet/CATAPULT/commits/main/lts/pkg/src/005-1-invalid-au/005-1-invalid-au.js

Thanks @brianjmiller, we will try out the newer version.


Issue Reporting

I would like to seek your assistance, on how we can add the custom email address for the issue reporting for instance our customer send an email to<EMAIL_ADDRESS>then it will automatically create a issue task for us. but however I cannot find any documentation about it.
That would be helpful if someone can share the information how to do it.
Thank you in advance.
Regards,
Ryan

Thanks for contacting us. Can you point us to the doc page you're referring. It helps us assign the issue to the correct writer.

@lrjbrual  Thanks for contacting us.
If you have a question about the Power Apps documentation, then provide us a link to the specific topic.
Unfortunately, we're unable to handle Support requests for the product here. To contact Support, see here: https://powerapps.microsoft.com/support/
This issue will be closed in a few days if we do not hear back from you..

Closing the issue.


Network: Adds address forwards

Build finished.

@stgraber aside from the changes discussed here https://discuss.linuxcontainers.org/t/lxd-floating-ip-addresses/11801/43?u=tomp this will soon be finished, so if you have chance to take a quick first-pass look before its finalised that would be appreciated.

Testsuite passed

Testsuite passed

@stgraber I ran out of time to add docs but will add tomorrow, other than that its ready for review.

@stgraber added docs now, ready for review.

@stgraber ready for review again

Testsuite passed

@stgraber rebased, also now im onto adding network forwards to bridge networks, and whilst reviewing your BGP branch, it occurred to me that network forwards might actually need to be node-specific (at least for bridge networks), what do you think (and if so, can you hold off merging the ovn branch so I can apply the schema changes needed)?


pytest.ini: Remove tests from addopts

Otherwise, it will always run all tests even if you the user gives arguments to py.test. In fact, it will run the specified tests twice.
This and #335 fix #333.

flake8 target fails because of the issue solved by 407. Otherwise, tests are passing:

#347 Completely removes addopts for obvious reasons.

I'm okay with merging #347 instead of this.

#347 merged. This isn't needed anymore.


Completion: Improve behavior for pre-selecting options

Some suggestions that were broadly agreed with:

"<dalog" should include a completion for "dialog" (but does not today).  Cyrus specifically wrote this in Roslyn to be a linear scan of the word so it should be cheap.
"<dv" should include a completion for "div". This is really just a subset of the above item, but there is some special casing about length so we should verify it separately. There is also a behavior difference between cshtml and razor files here which it would be good to smooth over.

The behavior here should be consistent between Roslyn (non-LSP) and the LSP client, so if and when the LSP Client makes an update for this Roslyn needs to be notified so they can do a fast follow/simultaneous insertion.

Matching should prefer a case-sensitive matching. IE, "<d" should select "<datalist" before it selects "<DataAnnotations". (it does the reverse right now).

Where we did not find firm opinions was around when Razor should and should not be in "Suggestion Mode". Roslyn enters Suggestion Mode whenever both existing options and "random" new options are legal. This is unfortunately the case any time you type "<" in a Razor file because html allows undefined tags (and you may be typing a Razor tag you haven't created yet), so following that rule would result in suggestion mode always being on for Razor.
To quote @jimmylewis though: "Using the VS telemetry monitor for the LSP messages in the <dv scenario, there is only one completion request sent when < is typed, and the rest are completionItem/resolve requests as the filtering is applied. Order here is not linear because the app tries to group request/response pairs, but you can see that each server only gets one textDocument/completion request for the whole 3-keystroke interaction.  The rest of the behavior (filtering, selection) is done purely on the client using that first completion list."
To re-state, this means that changes to the behavior for #1 and #2 (and #3 if I understand the scenario correctly) would have to come from the LSP client and would therefore affect all Language Servers.

I think we should do a spike and remove space from being a commit character for any html completion item and see how it feels. At least we're in charge of that scenario :)

If you remove space from being a commit character, you should make sure it dismisses the completion session.  Otherwise if the session stays open you can keep typing out a full tag e.g. <div class="foo"> (best partial match/selected completion is still "div") and the next trigger character (e.g. >) will commit the completion item, which replaces the full completion session span and gives you just <div>.

If you remove space from being a commit character, you should make sure it dismisses the completion session

It does!


fix: Use actual EIP4361 ABNF grammar

Fix #16
How it was verified against what is reported in #16 :
I created a js package (referenced as testing package below) that uses the code from the issue, with a slight change to compare actual strings:
console.log(message === ceramicMessage);

It reported false. Then I built a code in this PR, copied it to corresponding file in node_modules of my testing package.
It started to report true.
Adds a threshold date 2022-09-20. If a CACAO is issued after that, it must conform to the new format. If it is issued before the date, both new and old versions are accepted.

Do we need to update the Solana namespace with the new ABNF?

Solana and Ethereum share the same ABNF and serialization logic. We are fine for Solana. And, as we did not expose Solana publicly, the Ethereum kerfuffle does not affect Solana SIWx CACAOs.

Ok, so no changes to https://github.com/ChainAgnostic/namespaces/blob/main/solana/caip122.md is needed?

https://github.com/ChainAgnostic/namespaces/blob/main/solana/caip122.md

OMG. Yes, I forgot about that!!


Semantic Configuration Checks

DO NOT MERGE
Currently the values and regexes are derived from the current configuration files and are NOT final. They still need to be cross-checked with stakeholders and others.

Is this still in draft or shall we make this PR ready for review @UnchartedBull?


Changing vtctl and vtworker remote API to also return an error.

that way we don't depend on calling errFunc() before it actually should be called.
@michael-berlin @enisoc

LGTM


Issue using Oracle DB as superset database - Error running a migration script

Make sure these boxes are checked before submitting your issue - thank you!

[i] I have checked the superset logs for python stacktraces and included it here as text if any
[i] I have reproduced the issue with at least the latest released version of superset
[i] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.19.1
Expected results
"superset db upgrade" command completes
Actual results
Error running one of the migration scripts
It is worth noting that this works fine when I use the default SQL Lite instance. It is only when I change to use Oracle.
Steps to reproduce
1. Set db connection in superset_config.py
SQLALCHEMY_DATABASE_URI = 'oracle://user:password@hostname:1521/XE'
Oracle db instance is Oracle XE 11g.
**2. Run superset db upgrade
Log error:

Loaded your LOCAL configuration at [/etc/superset/superset_config.py]
INFO  [alembic.runtime.migration] Context impl OracleImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> 4e6a06bad7a8, Init
INFO  [alembic.runtime.migration] Running upgrade 4e6a06bad7a8 -> 5a7bad26f2a7, empty message
INFO  [alembic.runtime.migration] Running upgrade 5a7bad26f2a7 -> 1e2841a4128, empty message
INFO  [alembic.runtime.migration] Running upgrade 1e2841a4128 -> 2929af7925ed, TZ offsets in data sources
INFO  [alembic.runtime.migration] Running upgrade 2929af7925ed -> 289ce07647b, Add encrypted password field
INFO  [alembic.runtime.migration] Running upgrade 289ce07647b -> 1a48a5411020, adding slug to dash
INFO  [alembic.runtime.migration] Running upgrade 1a48a5411020 -> 315b3f4da9b0, adding log model
INFO  [alembic.runtime.migration] Running upgrade 315b3f4da9b0 -> 55179c7f25c7, sqla_descr
INFO  [alembic.runtime.migration] Running upgrade 55179c7f25c7 -> 12d55656cbca, is_featured
INFO  [alembic.runtime.migration] Running upgrade 12d55656cbca -> 2591d77e9831, user_id
INFO  [alembic.runtime.migration] Running upgrade 2591d77e9831 -> 8e80a26a31db, empty message
INFO  [alembic.runtime.migration] Running upgrade 8e80a26a31db -> 7dbf98566af7, empty message
INFO  [alembic.runtime.migration] Running upgrade 7dbf98566af7 -> 43df8de3a5f4, empty message
INFO  [alembic.runtime.migration] Running upgrade 43df8de3a5f4 -> d827694c7555, css templates
INFO  [alembic.runtime.migration] Running upgrade d827694c7555 -><PHONE_NUMBER>35, log more
INFO  [alembic.runtime.migration] Running upgrade<PHONE_NUMBER>35 -> 18e88e1cc004, making audit nullable
INFO  [alembic.runtime.migration] Running upgrade 18e88e1cc004 -> 836c0bf75904, cache_timeouts
INFO  [alembic.runtime.migration] Running upgrade 18e88e1cc004 -> a2d606a761d9, adding favstar model
INFO  [alembic.runtime.migration] Running upgrade a2d606a761d9, 836c0bf75904 -> d2424a248d63, empty message
INFO  [alembic.runtime.migration] Running upgrade d2424a248d63 -> 763d4b211ec9, fixing audit fk
INFO  [alembic.runtime.migration] Running upgrade d2424a248d63 -> 1d2ddd543133, log dt
INFO  [alembic.runtime.migration] Running upgrade 1d2ddd543133, 763d4b211ec9 -> fee7b758c130, empty message
INFO  [alembic.runtime.migration] Running upgrade fee7b758c130 -> 867bf4f117f9, Adding extra field to Database model
INFO  [alembic.runtime.migration] Running upgrade 867bf4f117f9 -> bb51420eaf83, add schema to table model
INFO  [alembic.runtime.migration] Running upgrade bb51420eaf83 -> b4456560d4f3, change_table_unique_constraint
INFO  [alembic.runtime.migration] Running upgrade b4456560d4f3 -> 4fa88fe24e94, owners_many_to_many
INFO  [alembic.runtime.migration] Running upgrade 4fa88fe24e94 -> c3a8f8611885, Materializing permission
Traceback (most recent call last):
File "/usr/local/bin/superset", line 15, in
manager.run()
File "/usr/local/lib/python3.6/site-packages/flask_script/init.py", line 412, in run
result = self.handle(sys.argv[0], sys.argv[1:])
File "/usr/local/lib/python3.6/site-packages/flask_script/init.py", line 383, in handle
res = handle(*args, **config)
File "/usr/local/lib/python3.6/site-packages/flask_script/commands.py", line 216, in call
return self.run(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/flask_migrate/init.py", line 244, in upgrade
command.upgrade(config, revision, sql=sql, tag=tag)
File "/usr/local/lib/python3.6/site-packages/alembic/command.py", line 254, in upgrade
script.run_env()
File "/usr/local/lib/python3.6/site-packages/alembic/script/base.py", line 425, in run_env
util.load_python_file(self.dir, 'env.py')
File "/usr/local/lib/python3.6/site-packages/alembic/util/pyfiles.py", line 93, in load_python_file
module = load_module_py(module_id, path)
File "/usr/local/lib/python3.6/site-packages/alembic/util/compat.py", line 64, in load_module_py
module_id, path).load_module(module_id)
File "", line 399, in _check_name_wrapper
File "", line 823, in load_module
File "", line 682, in load_module
File "", line 251, in _load_module_shim
File "", line 675, in _load
File "", line 655, in _load_unlocked
File "", line 678, in exec_module
File "", line 205, in _call_with_frames_removed
File "/usr/local/lib/python3.6/site-packages/superset/migrations/env.py", line 101, in
run_migrations_online()
File "/usr/local/lib/python3.6/site-packages/superset/migrations/env.py", line 94, in run_migrations_online
context.run_migrations()
File "", line 8, in run_migrations
File "/usr/local/lib/python3.6/site-packages/alembic/runtime/environment.py", line 836, in run_migrations
self.get_context().run_migrations(**kw)
File "/usr/local/lib/python3.6/site-packages/alembic/runtime/migration.py", line 351, in run_migrations
% step)
alembic.util.exc.CommandError: Migration "upgrade 4fa88fe24e94 -> c3a8f8611885, Materializing permission" has left an uncommitted transaction opened; transactional_ddl is False so Alembic is not committing tran
sactions

Hi,
If it helps, I have dockerised this so it should hopefully be straightforward to reproduce.

The Oracle docker image was taken out of the box from "wnameless/oracle-xe-11g"
The Superset docker image has been customised from "amancevice/superset" to include the oracle drivers.

Also - I can confirm that this is all hanging together and that when I use the standard SQL Lite database for the superset db, the db upgrade works and I can log in as admin and add the Oracle database as a data source and query it successfully.
Finally, it is worth mentioning that I am running my Docker instance on Windows.
The setup is as follows:
./Dockerfile.superset:
FROM amancevice/superset

USER root
RUN pip install cx_Oracle --upgrade
RUN apt-get install libaio1
COPY instantclient_11_2 /lib/oracle_instantclient_11_2
ENV LD_LIBRARY_PATH="/lib/oracle_instantclient_11_2:${LD_LIBRARY_PATH}"

USER superset

Important: Before you build that image, you need to download the Oracle instant client (11G version) from the Oracle website. I downloaded the zip and unzipped into the same folder as my docker file.
URL for download is: http://www.oracle.com/technetwork/topics/linuxx86-64soft-092277.html
File name is: instantclient-basiclite-linux-x86-64-<IP_ADDRESS>.0.zip
./docker-compose.yml
version: '3'
services:
    oracledb:
        container_name: oracledb
        image: wnameless/oracle-xe-11g
        volumes:
            - ./data/oracle:/docker-entrypoint-initdb.d
        ports:
            - "49161:1521"
            - "49160:22"
            - "8081:8080"
        environment:
            - "ORACLE_ENABLE_XDB=true"
            - "ORACLE_ALLOW_REMOTE=true"
    superset:
        container_name: superset
        image: awp/superset
        volumes:
            - ./data/etc/superset:/etc/superset
        ports:
            - 8088:8088
        links:
            - oracledb

./data/etc/superset_config.py
ROW_LIMIT = 5000
SUPERSET_WORKERS = 4
SUPERSET_WEBSERVER_PORT = 8088
SECRET_KEY = '\2\1thisismyscretkey\1\2\e\y\y\h'
SQLALCHEMY_DATABASE_URI = 'oracle://XDB:xdb@oracledb:1521/XE'
WTF_CSRF_ENABLED = True
DRUID_IS_ACTIVE = False
DEBUG = True

I notice that in line 77 of env.py it states the following:
    if engine.name in ('sqlite', 'mysql'):
        kwargs = {
            'transaction_per_migration': True,
            'transactional_ddl': True,
        }

https://github.com/apache/incubator-superset/blob/master/superset/migrations/env.py
I therefore modified that if statement to include 'oracle' but that caused all sorts of errors.
I changed it so that for oracle it only sets 'transactional_ddl': True and it got past the "Materialising permissions" script successfully

    if engine.name in ('sqlite', 'mysql'):
        kwargs = {
            'transaction_per_migration': True,
            'transactional_ddl': True,
        }
    if engine.name in ('oracle'):
        kwargs = {
            'transactional_ddl': True,
        }

but failed further down:

INFO  [alembic.runtime.migration] Running upgrade 4fa88fe24e94 -> c3a8f8611885, Materializing permission
INFO  [alembic.runtime.migration] Running upgrade c3a8f8611885 -> f0fbf6129e13, Adding verbose_name to tablecolumn
INFO  [alembic.runtime.migration] Running upgrade f0fbf6129e13 -> 956a063c52b3, adjusting key length
INFO  [alembic.runtime.migration] Running upgrade 956a063c52b3 -> 1226819ee0e3, Fix wrong constraint on table columns
WARNI [root] Could not find or drop constraint on columns
INFO  [alembic.runtime.migration] Running upgrade 1226819ee0e3 -> d8bc074f7aad, Add new field 'is_restricted' to SqlMetric and DruidMetric
INFO  [alembic.runtime.migration] Running upgrade d8bc074f7aad -> 27ae655e4247, Make creator owners
INFO  [alembic.runtime.migration] Running upgrade 27ae655e4247 -> 960c69cb1f5b, add dttm_format related fields in table_columns
INFO  [alembic.runtime.migration] Running upgrade 960c69cb1f5b -> f162a1dea4c4, d3format_by_metric
INFO  [alembic.runtime.migration] Running upgrade f162a1dea4c4 -> ad82a75afd82, Update models to support storing the queries.
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1182, in _execute_context
context)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/default.py", line 470, in do_execute
cursor.execute(statement, parameters)
cx_Oracle.DatabaseError: ORA-00904: : invalid identifier
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/bin/superset", line 15, in
manager.run()
File "/usr/local/lib/python3.6/site-packages/flask_script/init.py", line 412, in run
result = self.handle(sys.argv[0], sys.argv[1:])
File "/usr/local/lib/python3.6/site-packages/flask_script/init.py", line 383, in handle
res = handle(*args, **config)
File "/usr/local/lib/python3.6/site-packages/flask_script/commands.py", line 216, in call
return self.run(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/flask_migrate/init.py", line 244, in upgrade
command.upgrade(config, revision, sql=sql, tag=tag)
File "/usr/local/lib/python3.6/site-packages/alembic/command.py", line 254, in upgrade
script.run_env()
File "/usr/local/lib/python3.6/site-packages/alembic/script/base.py", line 425, in run_env
util.load_python_file(self.dir, 'env.py')
File "/usr/local/lib/python3.6/site-packages/alembic/util/pyfiles.py", line 93, in load_python_file
module = load_module_py(module_id, path)
File "/usr/local/lib/python3.6/site-packages/alembic/util/compat.py", line 64, in load_module_py
module_id, path).load_module(module_id)
File "", line 399, in _check_name_wrapper
File "", line 823, in load_module
File "", line 682, in load_module
File "", line 251, in _load_module_shim
File "", line 675, in _load
File "", line 655, in _load_unlocked
File "", line 678, in exec_module
File "", line 205, in _call_with_frames_removed
File "/usr/local/lib/python3.6/site-packages/superset/migrations/env.py", line 107, in
run_migrations_online()
File "/usr/local/lib/python3.6/site-packages/superset/migrations/env.py", line 100, in run_migrations_online
context.run_migrations()
File "", line 8, in run_migrations
File "/usr/local/lib/python3.6/site-packages/alembic/runtime/environment.py", line 836, in run_migrations
self.get_context().run_migrations(**kw)
File "/usr/local/lib/python3.6/site-packages/alembic/runtime/migration.py", line 330, in run_migrations
step.migration_fn(**kw)
File "/usr/local/lib/python3.6/site-packages/superset/migrations/versions/ad82a75afd82_add_query_model.py", line 44, in upgrade
sa.PrimaryKeyConstraint('id')
File "", line 8, in create_table
File "", line 3, in create_table
File "/usr/local/lib/python3.6/site-packages/alembic/operations/ops.py", line 1120, in create_table
return operations.invoke(op)
File "/usr/local/lib/python3.6/site-packages/alembic/operations/base.py", line 318, in invoke
return fn(self, operation)
File "/usr/local/lib/python3.6/site-packages/alembic/operations/toimpl.py", line 101, in create_table
operations.impl.create_table(table)
File "/usr/local/lib/python3.6/site-packages/alembic/ddl/impl.py", line 194, in create_table
self._exec(schema.CreateTable(table))
File "/usr/local/lib/python3.6/site-packages/alembic/ddl/oracle.py", line 22, in _exec
result = super(OracleImpl, self)._exec(construct, *args, **kw)
File "/usr/local/lib/python3.6/site-packages/alembic/ddl/impl.py", line 118, in _exec
return conn.execute(construct, *multiparams, **params)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 945, in execute
return meth(self, multiparams, params)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/sql/ddl.py", line 68, in _execute_on_connection
return connection._execute_ddl(self, multiparams, params)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1002, in _execute_ddl
compiled
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1189, in _execute_context
context)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1402, in _handle_dbapi_exception
exc_info
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
reraise(type(exception), exception, tb=exc_tb, cause=cause)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/util/compat.py", line 186, in reraise
raise value.with_traceback(tb)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1182, in _execute_context
context)
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/default.py", line 470, in do_execute
cursor.execute(statement, parameters)
sqlalchemy.exc.DatabaseError: (cx_Oracle.DatabaseError) ORA-00904: : invalid identifier [SQL: '\nCREATE TABLE query (\n\tid INTEGER NOT NULL, \n\tclient_id VARCHAR2(11 CHAR) NOT NULL, \n\tdatabase_id INTEGER NOT NULL, \n\ttmp_table_name VARCHAR2(256 CHAR), \n\ttab_name VARCHAR2(256 CHAR), \n\tsql_editor_id VARCHAR2(256 CHAR), \n\tuser_id INTEGER, \n\tstatus VARCHAR2(16 CHAR), \n\tname VARCHAR2(256 CHAR), \n\tschema VARCHAR2(256 CHAR), \n\tsql CLOB, \n\tselect_sql CLOB, \n\texecuted_sql CLOB, \n\tlimit INTEGER, \n\tlimit_used SMALLINT, \n\tselect_as_cta SMALLINT, \n\tselect_as_cta_used SMALLINT, \n\tprogress INTEGER, \n\trows INTEGER, \n\terror_message CLOB, \n\tstart_time NUMERIC(20, 6), \n\tchanged_on DATE, \n\tend_time NUMERIC(20, 6), \n\tPRIMARY KEY (id), \n\tFOREIGN KEY(database_id) REFERENCES dbs (id), \n\tFOREIGN KEY(user_id) REFERENCES ab_user (id), \n\tCHECK (limit_used IN (0, 1)), \n\tCHECK (select_as_cta IN (0, 1)), \n\tCHECK (select_as_cta_used IN (0, 1))\n)\n\n']

Looking at that SQL for creating the query table - the issue is that it is attempting to use a reserved word "rows" as a column name.
I believe you can add double quotes around the column name to bypass this and with some tweaking SQL Alchemy can do this.

I think the SQLAlchemy dialect has a list of reserved words it needs to quote as well. It's probably the best place to put this into.

Thanks for that.
In the latest stack trace, the issue is that Oracle does not auto increment primary key columns.
See http://docs.sqlalchemy.org/en/latest/dialects/oracle.html
From reading this, it suggests that you should use a sequence. This looks like it might be a quite invasive change.
Can I therefore ask if supporting use of the Oracle database for the superset tables is something you want and plan to do, or is the recommendation to use the standard SQL Lite db?
Cheers,
John

We recommend MySQL, MariaDB or Postgres. SQLLite isn't production worthy.
Ideally Oracle support would come through SQLAlchemy with no customization on our end. I think people have made it work, it may require creating sequences manually. If that's the case, either SQLAlchemy/Alembic should take care of that, or we can document it here in this issue or in a section of the docs "Setting up against Oracle".
In any case the core dev team doesn't really care about Oracle specifically and our take is to use at your own risk. We can enable documentation and hooks and things like that, but should be minimal and/or live somewhere else. We're not in the business of db engine compatibility for our metadata db.
Keep in mind that there's no way for us to build or run our continuous integration against Oracle, so that means we cannot make any guarantees. To make any guarantees we'd have to have someone else make these guarantees, maybe in the way of our release process which we'd rather keep simple as much as possible.
But it seems like any somewhat modern environment should have an easy way to pop a MySQL or Postgres instance, I'd go with that option.

I'm not sure Oracle can be used without code changes - I think you need to tell SQLAlchemy to use sequences for id generation, otherwise it expects there to be auto increment behaviour. I am not that familiar with it (coming from a Java background) so I can't say I'm 100% confident of that.
Apart from the sequence issue, to make Oracle work you also need to:

Set transactional_ddl = true
Update dialect to includes "rows" as a reserved word.

Regarding support of Oracle - I understand that you cannot expect to support all databases and it would lead to a high overhead for you. Can I therefore suggest that you call out the list of supported / tested databases in the documentation for installation & configuration?
Thanks,
John

The knowledge as to what database work well as a backend database should be community contributed as all we know is around what we can test/build against. We should add a section about that in the installation istructions.

Agreed

Notice: this issue has been closed because it has been inactive for 214 days. Feel free to comment and request for this issue to be reopened.

I´m also fighting to get superset working with oracle.  I created sequences for every table on the model, added rows as reserved word, edited the line
engine.name in ('oracle'):
but now I´m having this issue:
    step.migration_fn(**kw)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/superset/migrations/versions/e68c4473c581_allow_multi_schema_metadata_fetch.py", line 24, in upgrade
    default=True,
  File "<string>", line 8, in add_column
  File "<string>", line 3, in add_column
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/alembic/operations/ops.py", line 1565, in add_column
    return operations.invoke(op)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/alembic/operations/base.py", line 319, in invoke
    return fn(self, operation)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/alembic/operations/toimpl.py", line 123, in add_column
    schema=schema
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/alembic/ddl/impl.py", line 172, in add_column
    self._exec(base.AddColumn(table_name, column, schema=schema))
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/alembic/ddl/oracle.py", line 22, in _exec
    result = super(OracleImpl, self)._exec(construct, *args, **kw)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/alembic/ddl/impl.py", line 118, in _exec
    return conn.execute(construct, *multiparams, **params)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 948, in execute
    return meth(self, multiparams, params)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/sql/ddl.py", line 68, in _execute_on_connection
    return connection._execute_ddl(self, multiparams, params)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1009, in _execute_ddl
    compiled
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1200, in _execute_context
    context)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1413, in _handle_dbapi_exception
    exc_info
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/util/compat.py", line 186, in reraise
    raise value.with_traceback(tb)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/engine/base.py", line 1193, in _execute_context
    context)
  File "/opt/analytics/anaconda3/envs/superset/lib/python3.5/site-packages/sqlalchemy/engine/default.py", line 507, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.DatabaseError: (cx_Oracle.DatabaseError) ORA-00972: identifier is too long [SQL: 'ALTER TABLE dbs ADD allow_multi_schema_metadata_fetch SMALLINT'] (Background on this error at: http://sqlalche.me/e/4xp6)

Anyone knows a good way to go around this identifier length problem? oracle only allows 30.


background

that background was not catchy!! usually black backgrounds attract more people to stay more time on your webpage

This won't change the background. It will only change the cover of posts/cards.


Errno::ENOENT: No such file or directory @ unlink_internal on bundle update

Questions

What did you do?
I updated the bundler to 16.0 and ran bundle update rspec-rails on our project. Both of our projects throw the error below now.

What did you expect to happen?
I expected Bundler to update the rspec-rails to the latest version

What happened instead?
The gem was updated, as well as Gemfile.lock file, but on step Removing outdated .gem files from vendor/cache the bundler tried to remove rspec-rails gem twice:

Removing outdated .gem files from vendor/cache
  * rack-test-0.7.0.gem
  * rspec-rails-3.7.1.gem
  * rspec-rails-3.7.1.gem
Unfortunately, an unexpected error occurred, and Bundler cannot continue.

Have you tried any solutions posted on similar issues in our issue tracker, stack overflow, or google?
I tried...

Backtrace
Errno::ENOENT: No such file or directory @ unlink_internal - /vagrant/project/vendor/cache/rspec-core-3.6.0.gem
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:235:in `delete'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:235:in `block in prune_gem_cache'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:233:in `each'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:233:in `prune_gem_cache'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:155:in `prune_cache'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/runtime.rb:147:in `cache'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/cli/update.rb:62:in `run'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/cli.rb:266:in `update'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/cli.rb:27:in `dispatch'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/cli.rb:18:in `start'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/exe/bundle:30:in `block in <top (required)>'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/lib/bundler/friendly_errors.rb:122:in `with_friendly_errors'
  /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/bundler-1.16.0/exe/bundle:22:in `<top (required)>'
  /home/vagrant/.rbenv/versions/2.4.2/bin/bundle:23:in `load'
  /home/vagrant/.rbenv/versions/2.4.2/bin/bundle:23:in `<main>'

Environment
Bundler       1.16.0
  Platforms   ruby, x86_64-linux
Ruby          2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
  Full Path   /home/vagrant/.rbenv/versions/2.4.2/bin/ruby
  Config Dir  /home/vagrant/.rbenv/versions/2.4.2/etc
RubyGems      2.6.13
  Gem Home    /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0
  Gem Path    /home/vagrant/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0:/home/vagrant/.gem/ruby/2.4.0
  User Path   /home/vagrant/.gem/ruby/2.4.0
  Bin Dir     /home/vagrant/.rbenv/versions/2.4.2/bin
OpenSSL
  Compiled    OpenSSL 1.0.1f 6 Jan 2014
  Loaded      OpenSSL 1.0.1f 6 Jan 2014
  Cert File   /usr/lib/ssl/cert.pem
  Cert Dir    /usr/lib/ssl/certs
Tools
  Git         1.9.1
  RVM         not installed
  rbenv       rbenv 1.1.1-2-g615f844

  chruby      not installed

Bundler Build Metadata
Built At          2017-10-31
Git SHA           10f20fa33
Released Version  true

Gemfile
Gemfile
...
  gem 'rspec-rails', '~> 3.5'
  gem 'rspec-its'
  gem 'rspec-collection_matchers'
...

RUBY VERSION
ruby 2.4.2p198
BUNDLED WITH
1.16.0

That happened due to https://github.com/hashicorp/vagrant/issues/8788


Update request: llvmPackages_16 16.0.1 → 16.0.4

Package name: llvmPackages_16
Latest released version: 16.0.4

Current version on the unstable channel: 16.0.1
Current version on the stable/release channel: 16.0.1

[x] Checked the nixpkgs pull requests

Notify maintainers

@Ericson2314
Note for maintainers: Please tag this issue in your PR.

See #235219.

Thank you for your efforts!


embit bump version to 0.8.0

Description
Describe the change simply. Provide a reason for the change.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:

[ ] New feature
[ ] Bug fix
[ ] Code refactor
[ ] Documentation
[x] Other

Checklist

[x] I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

[ ] No, I’m a fool
[ ] Yes
[x] N/A

I have tested this PR on the following platforms/os:

[x] Raspberry Pi OS Manual Build
[x] SeedSigner OS on a Pi0/Pi0W board
[ ] Other

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

SeedSignerOS emit v0.8.0 update: https://github.com/SeedSigner/seedsigner-os/pull/72


sys.safe_path with Command line parameter -P and environment variable PYTHONSAFEPATH

https://docs.python.org/3/using/cmdline.html#cmdoption-P
https://github.com/RustPython/RustPython/pull/4537/files#diff-cb42fd26146ec61cb2242243494a9f314667a9a39153ad17e37465ff5a8a8000R536

[x] add sys.flags.safe_path #4568
[ ] add command line parameter -P to set flag
[ ] use environment variable PYTHONSAFEPATH to set flag
[ ] actual implementation of safe_path

I didn't check the actual implementation, but other 3 tasks are easy tasks

I'll take this issue

@youknowone - just FYI, tasks 2 and 3 are also completed - https://github.com/RustPython/RustPython/blob/main/src/settings.rs#L245-L249
After diving into the code, I don't see where it is implemented, but it seems like it is after testing it out.
Could you please close this issue for future people like me?
Thanks


stops working after 4-6 song

System OS
Windows
Python Version
3.10 (CPython)
Install Source
pip / PyPi
Install version / commit hash
3.9.6
Expected Behavior vs Actual Behavior
it stops working after 4-6 songs and it doesnt work again until restarted program

Steps to reproduce - Ensure to include actual links!
1.open spotdl
2.download some songs of spotify
3.after 4-6 it dont working
Traceback
Updating web app
INFO:     Started server process [11008]
14:41:20 - INFO - Started server process [11008]
INFO:     Waiting for application startup.
14:41:20 - INFO - Waiting for application startup.
INFO:     Application startup complete.
14:41:20 - INFO - Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8800 (Press CTRL+C to quit)
14:41:20 - INFO - Uvicorn running on http://<IP_ADDRESS>:8800 (Press CTRL+C to quit)
INFO:     <IP_ADDRESS>:62534 - "GET / HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62534 - "GET /assets/index.fe127150.js HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62534 - "GET /assets/index.d96dcc94.css HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62534 - "GET /assets/vendor.7698a149.js HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62534 - "GET /api/settings HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62534 - "GET /assets/spotdl.5dcb64c0.svg HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62534 - "GET /favicon.ico HTTP/1.1" 200 OK
INFO:     ('<IP_ADDRESS>', 62539) - "WebSocket /api/ws" [accepted]
14:41:22 - INFO - ('<IP_ADDRESS>', 62539) - "WebSocket /api/ws" [accepted]
INFO:     connection open
14:41:22 - INFO - connection open
INFO:     <IP_ADDRESS>:62536 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F6RbC38oDCIXD8V2AOU1Tjr%3Fsi%3D189bedac9fed4299 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62537 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F22GbAGb80ZZNgm2yrBMnpR%3Fsi%3D99cead2d247c4f98 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62560 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F0QV3swr7L8MZr72lL2izV1%3Fsi%3De27a56e0642749ad HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62573 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F38fIaph07Kd8ZIN6l17ZJs%3Fsi%3D991fc82bcb164067 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62581 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F5JAnXx5BBES4FEf4d4t4CC%3Fsi%3D7775855a53e34221 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62581 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F5JAnXx5BBES4FEf4d4t4CC&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 500 Internal Server Error
INFO:     <IP_ADDRESS>:62536 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F6RbC38oDCIXD8V2AOU1Tjr&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62537 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F22GbAGb80ZZNgm2yrBMnpR&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62573 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F38fIaph07Kd8ZIN6l17ZJs&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62560 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F0QV3swr7L8MZr72lL2izV1&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62604 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F5JAnXx5BBES4FEf4d4t4CC%3Fsi%3D7775855a53e34221 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62604 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F5JAnXx5BBES4FEf4d4t4CC&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 500 Internal Server Error
INFO:     <IP_ADDRESS>:62605 - "GET /api/download/file?file=Metallica,%20Marianne%20Faithfull%20-%20The%20Memory%20Remains.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62605 - "GET /api/download/file?file=Metallica,%20Marianne%20Faithfull%20-%20The%20Memory%20Remains.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62609 - "GET /api/download/file?file=Metallica,%20Marianne%20Faithfull%20-%20The%20Memory%20Remains.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62610 - "GET /api/download/file?file=Metallica%20-%20Wherever%20I%20May%20Roam.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62610 - "GET /api/download/file?file=Metallica%20-%20Wherever%20I%20May%20Roam.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62614 - "GET /api/download/file?file=Metallica%20-%20Wherever%20I%20May%20Roam.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62618 - "GET /api/download/file?file=Metallica%20-%20Hardwired.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62618 - "GET /api/download/file?file=Metallica%20-%20Hardwired.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62622 - "GET /api/download/file?file=Metallica%20-%20Whiplash%20-%20Remastered.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62623 - "GET /api/download/file?file=Metallica%20-%20Whiplash%20-%20Remastered.mp3&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62637 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F5JAnXx5BBES4FEf4d4t4CC%3Fsi%3D7775855a53e34221 HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:62637 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F5JAnXx5BBES4FEf4d4t4CC&client_id=8f903001-0da0-4124-ac2f-cab95afd8996 HTTP/1.1" 500 Internal Server Error

Other details
No response

@xnetcat @phcreery When you can, please look into this

mmmm, i believe its about ram of device and trash is not taken care of, code didn't specify limit

mmmm, i believe its about ram of device and trash is not taken care of, code didn't specify limit

Nope I think it's a bug in the web API. Python doesn't use that much memory and all ffmpeg processes are immediately closed after finishing. Temporary files are also removed from the disk even when the download fails.

14:05:30 - ERROR - Exception in callback _ProactorBaseWritePipeTransport._loop_writing(<_OverlappedF...hed result=28>)
handle: <Handle _ProactorBaseWritePipeTransport._loop_writing(<_OverlappedF...hed result=28>)>
Traceback (most recent call last):
  File "C:\Users\jakub\AppData\Local\Programs\Python\Python310\lib\asyncio\events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "C:\Users\jakub\AppData\Local\Programs\Python\Python310\lib\asyncio\proactor_events.py", line 377, in _loop_writing
    assert f is self._write_fut
AssertionError

@phcreery I've found this error while trying to download some songs using web ui. I can't find the source of this error tho (can't repro with --log-level DEBUG).

Thanks

fixed on dev branch


fix: add missing variable to example env file

Checklist

[x] Ensure PR title matches the conventional commits format.

CodiumAI Agent Commands
As required run the following CodiumAI Agent commands:

Request PR review using @CodiumAI-Agent /review (and if required, request an incremental update with @CodiumAI-Agent /review -i)
Request PR improvement suggestions with @CodiumAI-Agent /improve --extended
Request PR update using @CodiumAI-Agent /describe

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Adding a missing variable to the example environment file
📝 PR summary: The PR adds a missing variable, ASANA_WORKSPACE_NAME, to the .env.example file. This variable is likely used to specify the name of the Asana Workspace.
📌 Type of PR: Bug fix
🧪 Relevant tests added: No
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is straightforward and doesn't seem to introduce any issues. However, it would be beneficial to include a brief comment in the PR description explaining why this variable was missing and what impact its addition will have.

 🤖 Code feedback:

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@dependabot squash and merge


Using master.cf

Looking at using master.cf

[ ] I would like some feedback concerning a use case

Description
I'm trying to modify the existing master.cf file so that I can run a script after a message is sent.  I'm no postfix wizard, so it could very well be something I'm doing wrong.  I have a very basic setup of the docker container and have very little customized.
As a test, I have created and added the following to the postfix-master.cf file...
smtp      inet  n       -       -       -       -       smtpd
-o content_filter=myhook:dummy
myhook unix - n n - - pipe
flags=F user=root argv=/tmp/postfix.sh ${sender} ${size} ${recipient}
In the postfix.sh, I have it just touch a file in /tmp to see if it works, but doesn't.  There's also nothing in the maillog that indicates it running, but it may not be logged there.
I was wondering if there's any other things I need to do to get the docker version to recognize the configs in this file?  Is there any debugging I can see to see if it's running?
Thanks!

Honestly I'm not sure, if you can find a tutorial for Postfix it should work here as well. I'll flag it help wanted to see if someone has done something similar.

Thanks for the response.  I think I was close to getting it working and there was an issue with the postfix-master.cf file.  I say this because it didn't seem to be inserting the lines into the postfix configuration, and I was getting this error:
postfix/qmgr[]: warning: connect to transport private/myhook: No such file or directory
When docker would start the instance, I was also getting an error with the postfix-master.cf file. I know it's not much help if I can't provide the message...I'll try to work on getting the error message later on.
I wanted to migrate over to the docker-mailserver but had to get a new OS install finished last night with a working mail server so I just installed it within the OS instead of using the docker image.  I'll probably try to go back to this project in the future, but for now, I had to go back to how things were working before.  I'm still interested to see if the line entered above is still the right syntax, just so that I can get things up and running later with it all.
Thanks!

@4325123 alright. I will close this then. Please feel free to re-open when you come back to this.


[opentitanlib] Log USB open failure as warning

Signed-off-by: Alphan Ulusoy<EMAIL_ADDRESS>

Closing in favor of #16277


ArgumentException: Conversion from DateTime to Timestamp requires the DateTime kind to be Utc Parameter name: dateTime

I am reading from MySQL and adding that dynamic object to Firebase.
for each (dynamic a in ABC)
            {
                DocumentReference document = collection.AddAsync(a).Result;
            }

The problem is it doesn't work.  It's showing error ArgumentException: Conversion from DateTime to Timestamp requires the DateTime kind to be Utc
Parameter name: dateTime
Someone, please check it it's an issue, the date in MySQL table is 25 Jan 2018. it's not invalid neither it's null.
the object am I entering is reading from the database using dapper  (dapper's ienumerable)

whoever see trouble like this, use this
abc.a= DateTime.SpecifyKind(abc.a, DateTimeKind.Utc);

That's the right approach if the date actually represented UTC already. It isn't always the right way - it depends on the context. This important point is that you need to come up with a UTC value, in whatever way makes sense for you.
Will close this issue now as I don't believe any changes are required in the code.

If someone comes here from a search, I suggest you choose 2 option ( I didn't try it since I have moved on from this issue).
you can either do something with  dapper so all DateTime will be set as  UTC
https://stackoverflow.com/questions/12510299/get-datetime-as-utc-with-dapper
or you can modify your connectionstring to set the timzone UTC in MySQL, here is a nice answer on stackoverflow for doing it https://stackoverflow.com/a/36793896/713789


add in hooks where we expect them to execute

DO NOT MERGE THIS. THIS PR IS STRICTLY FOR VIEWING PURPOSES.

As we can see in this PR, the hooks are in the places where we expect them to execute. However, all hooks are executed before the tests run.

hooks were implemented in #10


Add shot block test cases

I've been learning about shot blocking and I realized through testing that the MPF docs are incorrect (on https://github.com/missionpinball/mpf-docs/blob/main/docs/config/shot_profiles.md ) about the default behavior of Block.
In order to prove that the default behavior is as block: False instead of True, I've added test cases for the False and True options. (config_spec:1617 for shot_profiles:block shows the default to be false as well)

It looks like the three failures in linting are preexisting on dev


Adding network interface control over REST API in the implementation of a joiner REST API

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is.
Hello, I would like to expand the current REST API by adding an interface to control the border router's joiner to securely join a new network. However, this requires the network interface to be up and the thread protocol to be disabled. As far as I can tell it is not currently possible to control these two independent of each other through the current REST API.
Describe the solution you'd like A clear and concise description of what you want to happen.

Am I missing something; is it possible to control the network interface independently via the REST API?
Advice on the most preferable way to facilitate this.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
The solutions I can think of are:

Add another endpoint /node/iface, /node/interface, or /node/network which accepts PUT and GET requests to set the interface up/down or to get the interface state respectively.
A PUT request on the new /node/joiner/state endpoint to start the joiner, will automatically set the network interface up if not already.

I'm open to alternative solutions.
Additional context Add any other context or screenshots about the feature request here.

Hello, I would like to expand the current REST API by adding an interface to control the border router's joiner to securely join a new network.

I don't get it, could you provide more context about what you want to support?

Hi @wgtdkp I want to support being able to join a new border router to a pre-existing network (without having to manually provide the dataset), through the commissioning protocol using the REST API. Basically bringing the ot-ctl functionality of joiner start <pskd> into the REST interface.

Thanks for the info, I got it!

A PUT request on the new /node/joiner/state endpoint to start the joiner, will automatically set the network interface up if not already.

This looks more reasonable to me.


Query optimization issues

Query optimization seems to have some issues.  Here's an example...  We're trying to query a type that has 3.4M vertices.  The type has two indices defined, the first is a UNIQUE_HASH_INDEX on the 'identifier' column (string with guids).  This is to do fast lookups with a known 'identifier'.  The other index is a NOTUNIQUE index on a 'timestamp' column (a date).  The index on 'timestamp' is for fast date range queries.  Queries that only use one column or the other are, as expected, fast.  Examples:
The following query returns 2072 results in ~5 seconds.  Not too bad...
SELECT * FROM Acquisition WHERE timestamp > '2014-02-16' and timestamp < '2014-02-19' LIMIT 5000
This one returns one result in .1 second.  Also, not too bad.
SELECT * FROM Acquisition WHERE identifier = '10100100125F5300' LIMIT 5000
This one, however, returns 9 records in 30+ seconds.  Not good.
SELECT * FROM Acquisition WHERE timestamp > '2014-02-16' and timestamp < '2014-02-19' AND identifier like '10100100125F5%' LIMIT 5000
When I run an 'EXPLAIN' on the first and third query, both show the same 'involvedIndexes' (the index on 'timestamp').  However, the first query shows 'evaluated'=2072 while the second query shows 'evaluated'=874234.  Why would the index return more results for the third query than for the first?  Is there a way to optimize the query using a different type of index or something comparable to hints?

The third query is using a "like" query which is possibly why the query is returning more number of records.
To optimize the query, try changing the query into a sub-query:
``sql
select from (select from Acquisition WHERE timestamp > '2014-02-16' and timestamp < '2014-02-19') where identifier like '10100100125F5%' LIMIT 5000

This should ensure that the timestamp index is used within the sub-query. The outer query will still likely not use the index, as it is a "like" query (I could be wrong on this).

I'm seeing the same behavior with a sub-query.  Response time is 30+ seconds.


Build fails because of scancode.

Scancode is not working with the latest common code.
See: https://github.com/nexB/scancode-toolkit/issues/2368
Related to #31

Pinned scancode commoncode version to fixed version.
https://github.com/philips-software/license-scanner/commit/7cba6c6f32e88582209e73a6720a255edaa816d4


Successful Choco Install (install-utilities.ps1) is causing Vagrant to exit

Operating System Version: MacOS / Linux
Provider (VirtualBox/VMWare): Both
Vagrant Version: 2.2.4
Are you using stock boxes (downloaded) or were they built from scratch using Packer? Stock
Is the issue reproducible or intermittent? Reproducible

Description of the issue:
Vagrant thinks an error occurred while running install-utilities.ps1
Link to Gist Containing Build Logs:
https://gist.github.com/clong/fb0d0d7a83b01a08b820c597fccb4d40

I believe this was actually an artifact of using import reg which emitted stderr of The operation completed successfully.. This doesn't appear to be an issue anymore.


Optional panel state settings for direct project links

Implement optional panel state settings for direct project links (vs. navigation to /). Configuring this setting may be problematic with localStorage based settings, as with #7

This can probably actually just be a boolean value in PageData - "was this a direct link"? Then we can proceed accordingly client-side.


Support Request:

Describe Your Problem
Config now asks for Secret
Relevant log output
Config now asks for Secret. I have looked in Help/documentation on Github and can't find any information on this.

Config for homebridge-switchbot
No response
Screenshots

Device & Model
Config
Node.js Version
v16.14.0
NPM Version
8.3.1
Homebridge Version
1.5.0
Homebridge SwitchBot Plugin Version
v2.0.0
Homebridge Config UI X Plugin Version
4.50.1
Operating System
MacOS

@siobhanellis sorry about that. This is part of the API Change from v1.0 to v1.1. Once you input that from the app you will be good to go.

Where do I find this in the app?
Siobhan

same place you found the token, in Developer Options.

All good. Working now.
Siobhan
IOT: Practical HomeKit: ( https://practicalhomekit.blogspot.com )
Charity Fundraising: Lammie Drive: ( lammiedrive.blogspot.comhttp://lammiedrive.blogspot.com/ )
From: Donavan Becker @.>
Date: Thursday, 13 October 2022 at 11:16
To: OpenWonderLabs/homebridge-switchbot @.>
Cc: siobhanellis @.>, Mention @.>
Subject: Re: [OpenWonderLabs/homebridge-switchbot] Support Request: (Issue #512)
same place you found the token, in Developer Options.
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenWonderLabs/homebridge-switchbot/issues/512#issuecomment-1277375208, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH5APBIOQ7FFFYWITRS7D2LWC7OPBANCNFSM6AAAAAAREAO5EU.
You are receiving this because you were mentioned.Message ID: @.***>


Renaming of tabs

One feature I miss in extraterm when compared with ConEMU/Cmder is the possibility to rename the title on tabs by right clicking on the tab.
Is this on the horizon or already possible and I just could not figure it out?
Thanks

Related to tab renaming, I'd love the possibility of assigning colors to tabs in a similar ways as in iTerm2 where you can just right click a tab and select a quick color. (The active tab title is completely of the selected background color while the others tabs just display a line under the title of the assigned color - if there is one). This allows to easily recognize and group the tabs when there are more of them open.
Thanks for the great work so far!

Keeps the ideas coming. With Extraterm I'm also working towards having an extension/plugin system which would allow for all kinds of customisation such as how tab title should work.

This was made possible in v0.43.

I am not sure if this is a request or I just can't find how to do it. Is it possible to show the current path in the tab name? I tried something like ${term:path} but without luck. It would be very helpful as default name as right now all my tabs are named the same and I don't even rename them anymore because every time I close extraterm the session is lost anyways.

@krzysztof-callstats  Making the tab title format configurable where the session is configured, is planned at some stage.
By default, you should be seeing the current directory of your shell in the tab title. Are you also using the shell integration?

@sedwards2009 yes, I am using shell integration for zsh, and my default tab name is zsh with some keyboard icon

Is it a bug or expected behaviour?


Add clean-url option

...for vitepress.

The migration is completed

I haven't tested this. But I believe that you have tested this, and so I'll merge for now.


Release Aug 8 2024

Changes

feat: add org oauth scopes #cloud/13076 https://github.com/neondatabase/neonctl/pull/258

:tada: This issue has been resolved in version 1.35.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


jest 24 with babel 6 and babel-jest 23

Hi, thanks for advance.
My project has babel 6.x . So i installed<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Because according to docs babel 6 is required jest 23.x or jest 24.x with babel-jest 23.x.
But when i run test code with jest, i got fail with error message like this
Plugin/Preset files are not allowed to export objects, only functions. In C:\workspaces\lbd2\lbd2_vue\node_modules\babel-preset-stage-2\lib\index.js

My question is when i use babel 6, is it right to install jest 24.x with babel-jest 23.x? Or is there something that i misunderstand?

Please follow the templates (particularly include a reproduction). Happy to reopen once a reproduction is added

The issue can be reproduced if Babel setup uses some presets (I suppose they're kinda "old-style" or something like that):
$ cat package.json
{
  "name": "jest-reproduction",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "jest"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "babel-core": "^6.26.3",
    "babel-jest": "^23.6.0",
    "babel-preset-env": "^1.7.0",
    "babel-preset-es2015": "^6.24.1",
    "babel-preset-react": "^6.24.1",
    "babel-preset-stage-1": "^6.24.1",
    "jest": "^24.5.0",
    "react-hot-loader": "^4.8.0"
  }
}

$ cat .babelrc
{
  "presets": ["es2015", "react", "stage-1"]
}

Any of the presets in the example above (and stage-2 as we can see from the original issue description) produce the error:
$ npm jest
Plugin/Preset files are not allowed to export objects, only functions. In  \jest-reproduction\node_modules\babel-preset-es2015\lib\index.js

@SimenB I've created a reproduction repo, can you please re-open? Thanks!
https://github.com/jochakovsky/Jest-24-Babel-6-preset-bug - just need to clone, run yarn install and yarn run test.
One workaround I've found is to add "resolutions": {"babel-jest": "23.6.0"} to package.json, though this is hacky and yarn-specific.


Plugin decaf load failed

Hey :)
When importing the plugins the decaf plugin always fails loading. I'd like to use this plugin, any chance someone can help me figuring out why it fails?
I am working in Google Colab with a python version of 3.10.12 and synthcity version of 0.2.9. I checked the dependencies and I don't think they are the problem.
I am trying:
from synthcity.plugins import Plugins
Plugins(categories=["generic", "privacy"]).list()
All other plugins are listed, the problem solely exists with decaf.

Thank you @robsdavis! Works now :)


dependencies in Makefiles so composer deps are up to date

untested :stuck_out_tongue:

This will automatically run composer install when executing any task that depends on composer dependencies being up to date. It does that by comparing the timestamps of the vendor folder with those of the files composer.lock and composer.json.
Have made this change 'blindly' with github web-editor, but I am using that quite succesfully e.g. here https://github.com/tolry/bcr/blob/master/Makefile

tanks @tolry  :)


Cluster password policy and user management support

What is the goal of this PR?
Add functionality relevant to the changes made in https://github.com/vaticle/typedb-cluster/pull/456:

Optional password expiry in days for each user.
The ability for admins to set passwords of other users
User password update, which requires old and new password

What are the changes implemented in this PR?
We've added the functionality that is being added in a recent TypeDB Cluster pull request:

Support updating password now requiring both the old and the new password.
Add support for retrieving the user password expiry in days. This is optional, depending on whether password expiration is enabled on the server.
Allow updating password as the admin requiring only a new password.

Left 2 minor comments you can address - approving now conditional on those being changed.

Done! Quantity of commits was due to rebasing on master.


Fix potential null pointer dereference in ARIA implementation

Fixed null pointer deference.

Merged, thanks.

Subject is actually misleading, because key->rd_key is not dereference. It could as well be an (ARIA_u128 *)key. But that's not what I'd like to discuss. Question is why check for key being NULL at all? I dare to assert that this check is nothing but a copy-paste artefact from elsewhere, e.g. aes_core.c (which in turn can also be a copy-paste artefact). In other words question is not really "why in aria.c", but it's more general. One might still argue that check might be meaningful in set_key, but it definitely makes no sense in aria_encrypt. One can wonder if any of NULL checks are sensible in aria_encrypt. Well, one might argue that check for in == NULL && out == NULL (&& is not typo!) can be meaningful. But other than that it's either programmer's mistake (i.e. caller should be held responsible), or sign of memory corruption (in which case application can as well just crash already).

It is a style issue. You either like checking for simple NULLs or you don't. The coding style is silent on the topic. And team member views differ. I for one check for that simple normal context always. Rich never checks. It is a choice. And the code should be consistent - which it wasn't. And the author was happy with the update (as am I).

It is a style issue. You either like checking for simple NULLs or you don't.

And my question is if this is right/appropriate/adequate. To leave it to matter of like-ness that is. As a practical example. aria_encrypt doesn't return value. And caller has no way of telling if it actually did something. And in such case passing buf, buf, NULL would make caller conclude that buf is encrypted. But this conclusion has catastrophic consequences, specifically more catastrophic than crashing application.

The coding style is silent on the topic.

Is it carved in stone of something? It being silent about something doesn't mean that it can't be discussed and/or all bets are off. Because you can't always formulate rule that covers all cases. Besides, I'm not even sure that this matter belongs in style guide.

It being silent about something doesn't mean that it can't be discussed

This is too weak statement. Mere presence of style guide doesn't mean that its content can't be discussed. I rather meant that can one really dismiss somebody else's argument with "style guide is silent about it"? You rather do it with own arguments as "style guide is silent, so I'm going to be". And once again, I'd argue that this can't be matter of style, because it's not about formatting or readability, but about things actually happening or not. Wouldn't it be appropriate to say that style is about something that doesn't affect actual functionality. Style is really about readability, and when we speak of readability we actually speak about humans. While what we discussing here is actually what computer does.

I'm confused...  key->rd_key is a dereference of the pointer key, surely?
Anyway, since we have a check that key is a valid pointer, it certainly looks like a programming error to try to use it before the check, no?  Kinda counter intuitive...

key->rd_key is a dereference of the pointer key

Well, "dereference" is kind of slippery term. But in the context, more specifically with suggestion key->rd_key would cause SEGV (or equivalent of) if key is NULL, "dereference" is viewed as "reaching out for data pointer points to". And key->rd_key doesn't reach for any data, it simply adjust pointer with offset of rd_key[] within the structure. Offset is zero here, that why I wrote that it could as well be simple cast.

Anyway, since we have a check that key is a valid pointer, it certainly looks like a programming error to try to use it before the check, no?

And my remark was about subject of commit message being misleading. In other words I'm not saying that modification itself was unjustified. It's fine, it improves readability. What I said is that subject creates wrong impression, because there was no risk of SEGV. And then I questioned legitimacy of NULL checks in this and other similar cases.

I argued for NULL checks on all pointers on all user accessible functions. Views varied. So it didn't go in one way or the other. That's how we have a style that is a consensus approach - where there were strong views in either direction it got left out. Happy to revisit but the views won't have changed and it will come down to voting on a pile of style things if we want to select a single approach. The style has been out long enough another round up updates is probably prudent.

all user accessible functions

BTW, ARIA is not user accessible. aes_core.c is, but I'd still argue that pointer sanity should caller's responsibility.

we have a style that is a consensus approach

... on STYLE. I.e. how do we lay down code to make it more readable, not what to do. And by "what to do" I mean code that actually affects binary [in a meaningful way].

we have a style that is a consensus approach

... on STYLE.

Quiting: "Coding style is all about readability and maintainability" [emphasis is mine].

I'm with @levitte here, this PR fixes a bug in the code.  The sequence:
x->blah
if (x == NULL) ...

can and will be optimised to:
x->blah

The NULL check is there at the moment and it should work.

Once again, here key->rd_key does not reach out for memory, there is no instruction generated that would trigger SEGV. If you don't find reference to cast compelling, consider that it's equivalent of &key->rd_key[0]. You argue that it might confuse optimizer to the level when it optimizes the check away. It might, I don't know, and don't have to know, because, once again, I do not question legitimacy of this modification, only the subject line. Well, you might argue that this possible optimization justifies the subject. But note that I'm not suggesting to change it. I'm only using this opportunity to question the premise for this check and similar to this one. Yes, you can blame me for "thread stealing"... :-)

BTW, two questions in context.

If it's argued that it risks confusing optimizer, was it actually OP's original reasoning? @jon-oracle?

How come another similar occurrence is not addressed?

Questions might appear mean. Are they? My social skill radar is somewhat weak, sorry for that...

Perhaps we should have a discussion about checking for null pointers as a general style issue?
As you know, my view is that crashes are more likely to get fixed than run-time errors and the C library does not check for NULL on things like fprintf.
And also the 128/192/256 check. :)

richsalz added the ready label 3 hours ago

Well, it's actually past "ready", because it's actually committed already :-) From this viewpoint it can as well be closed...

@dot-asm In answer to your questions 1) yes that was my reasoning, 2) I was poking around in this particular code and saw the bug - I'm happy to fix other occurrences but was concentrating on the ARIA work I was doing. 3) Not really!

I was poking around in this particular code and saw the bug - I'm happy to fix other occurrences but was concentrating on the ARIA work I was doing.

But "another similar occurrence" [note singular form] is reference to aria_encrypt function in same file.

yes that was my reasoning,

I fail to see that referred article actually applies in this case. Article discusses different order of optimization passes causing different outcomes, but specifically in context of actual dereference. Unfortunately it doesn't seem that there is a way to control order from command line. But it's possible to prevent compiler from removing dead assignment. Like this:
void contains_null_check(int *P) {
  volatile int *V = P;
  int dead = *V;
  if (P == 0)
    return;
  *P = 4;
}

If you examine generate code, you'll actually observe if-condition being eliminated. But if you remove dead assignment, you'll observe if-condition kept. But let's consider example that resembles this case more closely:
typedef struct { int rd_key[1]; } ARIA_KEY;

void contains_null_check(ARIA_KEY *P) {
    volatile int *V = P->rd_key;
    int dead = *V;
    if (P == 0)
        return;
    P->rd_key[0] = 4;
}

It behaves exactly as previous snippet. I.e. with dead assignment in place if-statement is removed, and without it - kept. [Actually you don't have to modify snippet to remove dead assignment, you can as well compile without or with -Dvolatile= option.] In other words P->rd_key does not substitute dereference and consequently should have no effect on optimizer. At least not the kind discussed in referred article. One can still wonder if P->rd_key constitutes defined behaviour even in cases when P is NULL. Well, if it wasn't [defined], then you wouldn't be able to define offsetof(type,member) as (type *)0->member...
But once again, I do not question legitimacy of this modification, it's fine, it does improve readability.


tablet / ipad

requested icon
tablet / ipad

released in v2
https://github.com/CyCraft/pepicons/releases/tag/v2.0.0


Add an intermediate List component

This adds a <List> component which currently doesn't do anything and proxies all props (and its ref) to the FlatList from Views. I think it's a good idea for a few reasons:

It lets us constrain the FlatList usage across the app down to things we actually rely on
It lets us add custom props and logic across all usages (something I might want to do soon)
It lets us narrow down the types a bit more (or fix clunky types, as in this PR)

I kept the forks in Views (which pretend to be API-compatible with RN FlatList) but later might move some of our custom logic into the List instead. E.g. non-standard props like desktopFixedHeight would better fit in the List.
Test Plan
Walked around the app.

merged via https://github.com/bluesky-social/social-app/pull/2200#pullrequestreview-1780856732