Github redirect uri not match. When i use https,how to deal with it?

This is my configs

Oh,it is so awful!

Same problem using Discord as provider
https://github.com/Atinux/nuxt-auth-utils/issues/81#issuecomment-2145146892

I failed to use it and there are few documents，so I prepare to develop my own oath2 application.😭😭😭😭

After thorough investigation (10 minutes playing with it), I found that something is downgrading the https request to http. Adding a log after this line will show us that the request the GitHub handler receives is flagged as http.
// getRequestURL(event) prints out:
{ href: 'http://localhost:3000/auth/github',
  origin: 'http://localhost:3000',
  protocol: 'http:',
  username: '',
  password: '',
  host: 'localhost:3000',
  hostname: 'localhost',
  port: '3000',
  pathname: '/auth/github',
  search: '',
  searchParams: URLSearchParams {},
  hash: '' }

Since this package uses the href returned by getRequestURL, it's pretty obvious why GitHub rejects it.
Any thoughts @Atinux? Is this Vite/Nuxt dev server?

PS: I made sure the navigation from UI to Nuxt Auth Utils' GitHub end-point was https. Tested on both Safari and Firefox on macOS.

Is your project behind a proxy?
If so, it might be because we don't specify the xForwardedProto option 🤔
https://github.com/unjs/h3/blob/3249ca7ff5a430d59de6f9948478284dce395c97/src/utils/request.ts#L335

I haven't set up one manually.
This is my whole nuxt.config.ts:
export default defineNuxtConfig({
  devtools: { enabled: true, componentInspector: true },
  devServer: {
    https: true,
  },
  css<EMAIL_ADDRESS>"~/assets/css/main.css"],
  modules: [
    "shadcn-nuxt",
    "@unocss/nuxt",
    "nuxt-auth-utils",
    "nuxt-icon",
    "@vueuse/nuxt",
    "@hebilicious/vue-query-nuxt",
  ],
  vueQuery: {
    queryClientOptions: {
      defaultOptions: {
        queries: {
          staleTime: 1000 * 60 * 5, // 5 minutes
        },
      },
    },
  },
});

Does devServer: { https: true } set up a proxy?

Is your project behind a proxy?
If so, it might be because we don't specify the xForwardedProto option 🤔
https://github.com/unjs/h3/blob/3249ca7ff5a430d59de6f9948478284dce395c97/src/utils/request.ts#L335

Yes,I set a nginx proxy for this application port and  I bind it to my domain dev.brl0.top.

Same issue for me -- I am using nignx to forward my port 80 traffic to Nuxt running on port 3000, and I notice the redirect_url is http, which is a mismatch. 🤔

Similar to https://github.com/Atinux/nuxt-auth-utils/issues/117#issuecomment-2258052448
For such case where Nuxt cannot guess the protocol because it run behind a reverse proxy, use the authorizationParams.redirect_uri to overwrite it in production with your domain:
export default oauthProviderEventHandler({
  config: {
    authorizationParams: import.meta.dev
      ? {}
      : {
          redirect_uri: 'https://my-prod-website.com/auth/provider',
        },
  },
  async onSuccess(event, { user }) {
    // ...
  }
})

Imo this shouldn't be closed.
As @raggesilver points out in comments, he's not running under a proxy.
I have the same problem.
It looks like more a bug than an expected behavior.


clang-analyzer is identifying some minor issues that should be resolved

The Clang Static Analyzer when used on mbed TLS is identifying some minor issues that should be resolved.
@NWilson has raised a Pull Request #457, which fixes those issues he's seen.

ARM Internal Ref: IOTSSL-706

Closed since it was outdated, fixed and merged.
If you feel this was wrongfully closed, you may reopen this issue


[Suggestion] Remove the single quote when executing the rename symbol

OS: Win10
Build: 20200429.10
Repro Steps:

Open any template file, e.g. new-vm.json.
Right click a parameter or variable ->  Rename Symbol.
Observe the result.

Expected:
Only show the name.
Actual:
Show the name and extra single quote.

More Info:

This issue doesn't reproduce in the parameter file.
This issue doesn't reproduce for parameter definition.

Weird...  I then get an error saying that it can't be renamed.

Not a regression


enable one-off donation

Open Collective only allows recurring; could we have something like Regex101 with one-off?

I see a "Or make a one time donation" in opencollective. have you tried it?

totally missed! my bad 🗿

just donated :)

Awesome. Thanks!


fix header link in account

CR @saleiva

Frontend tests were OK :+1: (details)

retest this, please

Frontend tests were OK :+1: (details)

bump!

I take that as a :+1:


Test/Debug story http proxy

The minimum viable deployment of spark-streaming is likely

an embedded http stream factory #23
either a storage consumer (ex mysql) or a http consumer (ex reporter to a zipkin server)

In this case, the starter arch could be a single sparkstreaming process run in dev mode, pointed at a single in-memory zipkin server. you post spans to the spark job and view or download the json from the zipkin server,
[POST localhost:19411/api/v1/spans]
    -> [sparkstreaming adjustment happens]
        -> [POST localhost:9411/api/v1/spans]

wdyt? cc @openzipkin/devops-tooling

either a storage consumer (ex mysql) or a http consumer (ex reporter to a zipkin server)

It think its a good idea to add zipkin server as a sparkstreaming consumer. I thought it's already part of zipkin-storage. Is there a reason we didn't built a storage module for zipkin server? or was it not needed before?

It think its a good idea to add zipkin server as a sparkstreaming
consumer. I thought it's already part of zipkin-storage
https://github.com/openzipkin/zipkin/tree/master/zipkin-storage. Is
there a reason we didn't built a storage module for zipkin server?
We have a different package for reporting to zipkin
https://github.com/openzipkin/zipkin-reporter-java

or was it not needed before?
When we had a discussion before about an http "storage", it boiled down to
a proxy use case. A normal http proxy is simpler as it requires no code,
and is more flexible, too. The stackdriver storage module is http (well
grpc), but that's because its storage layer only has an http api.

At any rate, I think it is fair game to put a Reporter consumer, as that
would let us slap http or any other supported transport on the other side
of it. For example, this could be a way to accomplish more powerful
sampling, tee'ing off to vizceral, etc, as well the simple arch setup where
this snaps into a well understood basic zipkin deployment.


[FEAT] Support XDG Base Directory-respecting Nix user configuration

Wanted features:
Currently, Fastfetch will not pick up Nix user packages if the folder (or symlink) ~/.nix-profile is not present (i.e. Nix is set to respect XDG Base Directory). For example, if nix.settings.use-xdg-base-directories is set to true in Home Manager, Home Manager will not create the folder ~/.nix-profile,[1] causing this behavior. The XDG Base Directory equivalent of ~/.nix-profile is $XDG_STATE_HOME/nix/profile.
Motivation:
Hyfetch had a similar issue, which I reported and that got fixed. I tried out Fastfetch today and noticed it had the same issue. The fix used there was to check ~/.nix-profile if it exists, otherwise falling back to $XDG_STATE_HOME/nix/profile.

@xoltia Can you take a look at this one?


Backup process

Is your feature request related to a problem? Please describe.
I just updated to the most recent version and noticed that the whole backup (PostgreSQL dump) GUI process has changed. Now when I click "Proceed" the whole modal dialogue dissapears and the task in moved into the background task. I don't know if this is a bug or by design but I am very annoyed by the new approach. I much preffered the old one.
Describe the solution you'd like
Improve the whole backup GUI process to be more interactive with the user.
Describe alternatives you've considered
There are none except to accept the new approach which is not the best but it does the job. The lack of feedback about the whole dump process is what bothers me.

Thank you for your report


I want to use jade in angular-meteor

I had use jade in angular-meteor.like this
using package
meteor add mquandalle:jade

directory structure
myApp
|-- index.ng.jade
|-- index.jade
|-- app.js

Error code
   While building the application:
   index.ng.jade: Jade syntax error: Tag must be in a template on line 1
   packages/compileJade/plugin/handler.js:54:1: Cannot read property 'head' of
   undefined (compiling index.ng.jade) (at fileModeHandler)

Could you tell me.please

@endows Check out my package https://github.com/civilframe/meteor-angular-jade

@civilframe Thank you Alex.The problem was solved.


fix: Add additional template render convenience functions

This change is primarily intended to establish a development pattern and workflow for embedding pure-Lua render-time convenience functions. The goal is to be able to 'natively' extend the Swift-provided incontext table in a way that is seamless to the template author.

@tomsci I'd really appreciate your thoughts on this one. I'm pretty sure I've got the embed and require working correctly, but I think your implementation of makeSandbox is just too good. 🙃
What do you think the best approach is to preserve the sandbox but add this additional functionality in a lightweight way?


Write after end

Getting a pipe error in the server; suspect it's because of errors / unpipe events not handled correctly
  Error: write after end
      at writeAfterEnd (_stream_writable.js:220:12)
      at PassThrough.Writable.write (_stream_writable.js:271:5)
      at Socket.sibyl.stderr.on.data (/Users/anon/src/stencila/sibyl/server/server.js:49:11)
      at emitOne (events.js:115:13)
      at Socket.emit (events.js:210:7)
      at addChunk (_stream_readable.js:252:12)
      at readableAddChunk (_stream_readable.js:239:11)
      at Socket.Readable.push (_stream_readable.js:197:10)
      at Pipe.onread (net.js:588:20)

Ah yeah, so I suspect koa is closing the through stream

Closed by #18


Opening a tab for a shell that is not installed anymore does not notify user that something went wrong

Environment
Windows build number: 18363.418
Windows Terminal version: 0.5.2762.0

If a profile is defined with an invalid commandline, or if the shell specified has been uninstalled by the user, trying to open a tab with that profile will not show any warning about the failure to launch the shell process.
If the profile is defined with "closeOnExit":false, the tab will wait forever for the shell to get connected instead of showing an error message. If the profile is defined with "closeOnExit":true, the tab will immediately close with no explanation.
Steps to reproduce
Create a profile with a non-existing shell such as the following:
{
// A non-existing shell
"guid": "{0225F6B6-EC1C-4746-8384-A83DB214D13A}",
"closeOnExit": false,
"name": "dummy",
"commandline": "dummyshell.exe",
"hidden": false
},
Expected behavior
If the commandline cannot be launched, an error should notify the user that the process couldn't be created, so they know they have to look at the command line more closely.
Actual behavior
Instead of some error message, Windows Terminal keeps the tab open and cursor waiting with no hint that something went wrong launching the shell, or simply silently closes the tab if "closeOnExit":true.

Hey @PhMajerus, thanks for the report!
This is actually a dupe of #2563, for which we've got a couple plans.
Cheers!

/dup #2563


Update boot loader

Updated README.md and made changes to boot loader

OS has been restarted, no longer valid


Reference Swift WebUI

I want to write a SwiftKitUI using the system's UIKit and AppKit support for the low version. But I don't know how to write it. I don't know if I can read it according to the source code of SwiftWebUI.

Sorry, I don't understand your question. Could you try to rephrase it?

@helje5 Because Apple's SwiftUI does not support low versions. I want to make a compatible library that is packaged like Apple's SwiftUI. In fact, I also want to contribute to SwiftWebUI, but I will not develop it myself. I think some of the core code of SwiftWebUI can be borrowed from the library I developed. And there are still Swift grammar questions that need to be consulted. Thank you in advance if you can help me.
SwiftKitUI

Still no idea what you actually want as part of this issue. Good luck w/ your SwiftKitUI!


Threshold value?

Is there any option to set threshold in pix-diff?

There is, see the test spec here. The default value is 500 pixels.

Thanks a lot!!

Is it possible to set it on the declaring the pix-diff globally instead on the matched?

Not at this time. I'll look to add it in the next release as I agree it would be quite useful.


GUVNOR-2783: [Guided Decision Table] Exception thrown during handling Boolean cells

See https://issues.jboss.org/browse/GUVNOR-2783
New columns can have the default value for boolean cells set to null
@karreiro Could you please bare this in mind with the changes you are making for column definition?
A boolean column should not really permit null default values; only true or false (unless, or until, we support tri-state boolean fields, null, true and false - but it's unsupported atm).

Ok, @manstis. I'll keep that in mind.
+1

Hi @manstis. I would like to ask just for clarification. You said null values are not supported atm. Does it mean, that if I define condition column that compares some boolean field (lets say mandatory) for equality, then all generated rules will contain either mandatory == true or mandatory == false?

@jomarko Yes that is correct. We've never supported the (really needed) "tri-state" in any of the editors where boolean is concerned; only true or false.


[mailbox] Error loading the mailbox component with our demo account

Background
We have a strange inconsistency in the Nylas threads endpoint where a thread exists with a message that has no to, from, or other expected fields. While this seems to be more of a API issue, our components currently break because we made the assumption that such fields should always exist for messages.
Implementation

[x] Filtered out messages that do not have a TO or FROM value when fetching threads
[ ] Added unit tests to check regressions

Story details: https://app.shortcut.com/nylas/story/80543

This change has already been merged, closing this PR


Broken link

The second zoology blog post has this text:

we compare the PyTorch reference implementation provided here, with the CUDA code and observe the following speedups! Note that the PyTorch code runs out of memory at N=32768 and BS=4. Experiments are run on an 80GB A100 GPU.

Unfortunately that link doesn't seem to work anymore!
On a related note, is the CUDA code available?

Hi they got removed in a refactor -- here you go: https://github.com/HazyResearch/zoology/tree/d0c2fa46005c638b525f29fdeb9fc6ece06fdd28/based_refs
We will release the CUDA code with full release! The structure of ```linear_attn_ref.py''' at the link above shows the python forward and backward pass for the CUDA algorithm we use.


Context Menu component has the wrong module

Looking at Storybook, it seems the Context Menu component has the wrong import module.
It says "ContextSwitcherModule", but it should be "ContextMenuModule"?

Thanks for reporting this @lSilvani! Would you like to contribute this fix? :)
You would update the following line to the correct module and restart storybook (npm run storybook):
https://github.com/carbon-design-system/carbon-components-angular/blob/ebb57a98147b5d2f7a357c24feb2d97c075dbe15/src/context-menu/context-menu.component.ts#L15


tracing/exec: fix missing parents in exec events

After installing via the helm chart, we are seeing lots of missing parents on exec events. From metrics:
isovalent_errors_total{type="exec_missing_parent"} 333

A cursory exploration of the pod indicates that procRoot is indeed mounted and that Tetragon configs are pointed to the right mount point, so something else is going on here.
Filing this as a tracking issue while I investigate.

I made a bit more progress on debugging this. Added a metric that counts missing parent exec ids and found that they all decode to either of these on my system:
tetragon-dev-control-plane:0:397223
tetragon-dev-control-plane:0:397528

The corresponding processes are kindnetd and kube-proxy.
Suspicious that it's only these two, but haven't found a root cause just yet...

Okay so I believe I have found the problem. We are populating procRoot from the procfs mounted inside the kind node docker container but setting the host pid when generating events. So any procfs entries from the kind node will be wrong as far as tetragon is concerned.
Now to think about if/how we want to fix this...

Closing this as wontfix. It's exclusive to kind, only impacts events that are not exported by default, and can be worked around by mounting the host procfs inside the kind node.


Added mirror methods.

closes #5

replaced concat with push - hugely improves performance.

It looks like the image type is hard-coded to JPEG. Is that right?

@oliver-moran: sorry, made initial pull request from master, later realized that all the future commits are appended automatically. Thanks for adding the flip method. Closing this one.
And I have 2 more feature requests (I'll submit pull requests if you wish):

Сonstructor that takes byte array. Image might be coming as part of POST request and therefore stored in memory. Use path to determine mime type only.
Image rotation: https://github.com/ekulabuhov/jimp/commit/5493dbc662570bd03d4c3f2d129bc1136cbee2fd

Done. A new rotate method is added based on your code. And you can now construct like this:
var image = new Jimp(data, "image/png", function () {
    // ready
});


how to execute the project

The environment is set up, and the data is prepared. How should this project be executed?How to execute the project to generate a checkpoint? Could you provide a detailed step-by-step guide?Execute the command bash scripts/train_align_lora.sh, but there is no response.Executing other .sh files under the scripts directory also does not result in any changes.

8 NVIDIA RTX 4090 24GB graphics cards.

You need to figure out the type of your server first. If it is based on SLURM, you can launch jobs via mode=submitit, which is the default option. If it is not, you can launch jobs via mode=accelerate for distributed training. The option mode=python only supports single-GPU running.


Just wanted to say thanks! This is the best rating view out there!

You're most certainly welcome! :-)


Broken link in developper guide

In the module tutorial there's a link "We've also written a document on how we organize large apps at Google." > https://docs.angularjs.org/guide/module
Sounds really interesting but the article just doesn't load on the blog :/
Consider put it back (I'd like to read it !) or remove the link.
Cheers

It works with this address: http://angularjs.blogspot.de/2014/02/an-angularjs-style-guide-and-best.html
Strange. But then again, blogspot isn't Google's finest piece of software.

Thanks :)

Looks like the angularjs.org forces https, but the content is http, and modern browser don't like that.

The link has been replaced by a link to @johnpapa's style-guide, so nothing to fix any more :smile:


Make ConvertError and variants public

This permits matching on the error variant, and ensures that the variants are rendered in rustdoc.
Makes progress on #1139.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   87.76%   87.76%
=======================================
  Files          14       14
  Lines        5158     5158
=======================================
  Hits         4527     4527
  Misses        631      631

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature Request: Express Least to Most Privileged Permissions in Permissions API

Is your feature request related to a problem? Please describe.
The permissions table in Microsoft Graph Docs, lists permissions from "Least to Most Privileged".

DevX API returns a list of permissions for the endpoint /users without expressing the idea of least to most privileged. However, DevX API returns Permissions in the following order, I also suspect that the order is not enforced and it can change depending on the underlying datastore and query.
DeviceManagementApps.Read.All DeviceManagementManagedDevices.Read.All DeviceManagementServiceConfig.Read.All Directory.Read.All User.Read.All User.ReadBasic.All
Describe the solution you'd like
Expressing the idea of least to most privileged would be useful in Raptor when selecting a Permission to use in PowerShell Scripts especially for Delegated Permissions.
Either by an assurance that Permissions API will be deterministic in the order that it returns Permissions
To add a field indicating level of privilege, where say 1000 indicates very high and 1 very low.

Related to #1077


Upgrade com.spotify:docker-client:8.9.1 -> 8.14.1

This upgrades the docker-client to the latest release.
I ran into https://github.com/spotify/docker-client/issues/1016 after pulling in the docker-junit-rule dependency from a classpath conflict. Updating the docker-client to the latest resolved the problem. If you're open to it, it'd be great to have the rule itself pull in a more recent version of the client.

Closing due to inactivity


Return Unicode string from keyvi python API

fixed unit tests to be compatible with new unicode format
added OutputStdStringUnicodeConverter for return string types

Coverage remained the same at 93.517% when pulling aba0586a519e8565b0905ce06ad5f80ab1f2b012 on narekgharibyan:unicode into b3d5186f2d3374ec2486e690c894b9d8cb7e9b87 on KeyviDev:master.


issue around naming in preprod

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.45%. Comparing base (9450389) to head (b3755bd).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1056   +/-   ##
=========================================
  Coverage     84.45%   84.45%
  Complexity     3688     3688
=========================================
  Files           381      381
  Lines         12419    12419
  Branches       1055     1055
=========================================
  Hits          10488    10488
  Misses         1451     1451
  Partials        480      480

Flag
Coverage Δ

84.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


JSON Performance: Avoid quadratic encoding for maps

OSS-Fuzz found that TextFormat encoding could degenerate into quadratic behavior for certain cases.  This fixes a similar issue with the JSON encoder.
Specifically, when encoding map fields, the JSON encoding visitor would construct a child visitor using the same underlying encoder. This results in multiple references to the backing byte array which triggers copy-on-write for that array.
To avoid that, we modify the JSON encoding visitor to construct a child visitor with a new empty encoder, and then append the contents of that encoder back to the parent.  This avoids the quadratic behavior in this case.
To try to prevent this from regressing, I've added tests that are tuned to take less than 1s on an M1 MacBook Pro with the new code and more than 30s with the old code. If this does regress, that should be a dramatic enough slowdown to attract someone's attention.

This is the equivalent of #1322 for JSON.

@thomasvl   Are you familiar with the MessageSet support ?  It looks like that might have the same issue, and likely could be fixed with the same approach used here.

@thomasvl   Are you familiar with the MessageSet support ?  It looks like that might have the same issue, and likely could be fixed with the same approach used here.

I won't be able to look this week, but wouldn't be surprised if it has the same issue. I'll try to look late next week if you don't beat me to it.

@thomasvl   Are you familiar with the MessageSet support ?  It looks like that might have the same issue, and likely could be fixed with the same approach used here.

I won't be able to look this week, but wouldn't be surprised if it has the same issue. I'll try to look late next week if you don't beat me to it.

Opened up https://github.com/apple/swift-protobuf/pull/1329 from taking a quick look at this.  I believe the existing code was ok because of how simple the types were, but that PR might make it less likely that future changes to the types could make this expensive.


make sure admins of the host of the event can see expense attachment

Fixes https://github.com/opencollective/opencollective/issues/1013

Coverage remained the same at 72.289% when pulling 4ef973009b7db9fd5fc3ee37cba0aee126e2e7ed on fix1013 into cbf245bf133c50301788a5f9d3ef5a32cd518fa2 on master.


Multichain routes

[x] Ability to switch chains within one domain (no need for 5 builds anymore)
[ ] Redirects to support existing external links

Preview URLs:
https://beefy-app-git-fork-wivern-co-uk-feat-multichain-beefyfinance.vercel.app/bsc
https://beefy-app-git-fork-wivern-co-uk-feat-multichain-beefyfinance.vercel.app/heco
https://beefy-app-git-fork-wivern-co-uk-feat-multichain-beefyfinance.vercel.app/avax
https://beefy-app-git-fork-wivern-co-uk-feat-multichain-beefyfinance.vercel.app/polygon
https://beefy-app-git-fork-wivern-co-uk-feat-multichain-beefyfinance.vercel.app/fantom

Would it be possible/easier to have the 5 subdomains all point to one build, and then do the window.REACT_APP_NETWORK_ID thing based on domain rather than path.
That way none of the links need updated and we don't need to ensure that cross-network links force a reload (if they are made via react router/history.push then redux state, among other things, will probably be wrong).

Would it be possible/easier to have the 5 subdomains all point to one build, and then do the window.REACT_APP_NETWORK_ID thing based on domain rather than path.
That way none of the links need updated and we don't need to ensure that cross-network links force a reload (if they are made via react router/history.push then redux state, among other things, will probably be wrong).

Having app under one domain is crucial for decentralised beefy future, where app will be having multiple mirrors to ensure high-availability.
Development expirience is much better when it's easy to switch networks even locally.
Cross-network links are regular links, so no issues with app state already
Beefy V2 done similar way, so this PR is upgrade preps.

Closed in favor of https://github.com/beefyfinance/beefy-app/pull/729


Blog post for Bazel 4.0

In general, it looks good to me once the updates and comments from others are resolved.

In general, it looks good to me once the updates and comments from others are resolved.

This looks great, thank you all so much!

This looks great, thank you all so much!


"Stiebel Eltron ISG Return Temperature" gets a wrong value

Hi everyone,
"Stiebel Eltron ISG Return Temperature" seems to get wrong data, it is stuck between 29.1 and 29.5C°, depending on the compressor, if it is running or not.
There might be a field in Modbus, which is not picked up correctly?

From the documentation:
511 ISTTEMPERATUR HK 2 x x x 0 90 2 °C r
512 SOLLTEMPERATUR HK 2 x x x 0 65 2 °C r
513 VORLAUFISTTEMPERATUR WP x x x MFG, sofern vorhanden 2 °C r
514 VORLAUFISTTEMPERATUR NHZ x x x MFG, sofern vorhanden 2 °C r
From code:
            result[ACTUAL_TEMPERATURE_HK2] = get_isg_scaled_value(                 decoder.decode_16bit_int()             )             result[TARGET_TEMPERATURE_HK2] = get_isg_scaled_value(                 decoder.decode_16bit_int()             )             result[FLOW_TEMPERATURE] = get_isg_scaled_value(decoder.decode_16bit_int())             decoder.skip_bytes(4)             result[RETURN_TEMPERATURE] = get_isg_scaled_value(                 decoder.decode_16bit_int()             )
is the decoder.skip_bytes(4) on the correct position?

Hmm...
In my case, Flow Temperature as well as Return temperature is between ~18 and ~52 (when the heat pump is heating the water).
Flow Temperature is mapped to register 513 and Return Temperature is mapped to 516. 514 and 515 are skipped by the skip_bytes(4). In my case 515 and 517 do not contain any values.
Could you try to download the diagnosis information (Click on the 3 dots below "Device Information"). You will get a json file in which you find "system_values" towards the end. Does any of the registers contain the correct value?

While return temperature is common for all type of devices, flow temperature depends whether MFG or any other type of NHZ is installed. All in all I would suggest to use 516 for return and 515 for flow temperature.
In the office I have one WP with HSBC and MFG and one with HSBC without MFG.
I'll try to understand whether it makes a difference.

for unit without MFG
Protocol configuration: MODBUS/TCP, FC4
Slave configuration...: address = 1, start reference = 501, count = 20
Communication.........: <IP_ADDRESS>, port 502, t/o 1.00 s, poll rate 1000 ms
Data type.............: 16-bit register, input register table
-- Polling slave...
[501]: -32768
[502]: -32768
[503]: -32768
[504]: -32768
[505]: -32768
[506]: -32768
[507]: -39
[508]: 262
[509]: -32768
[510]: 131
[511]: -32768
[512]: -32768
[513]: -32768
[514]: -32768
[515]: -32768
[516]: 226
[517]: -28672
[518]: -32768
[519]: -32768
[520]: -32768
for unit with MFG
Protocol configuration: MODBUS/TCP, FC4
Slave configuration...: address = 1, start reference = 501, count = 20
Communication.........: <IP_ADDRESS>, port 502, t/o 1.00 s, poll rate 1000 ms
Data type.............: 16-bit register, input register table
-- Polling slave...
[501]: -32768
[502]: -32768
[503]: -32768
[504]: -32768
[505]: -32768
[506]: -32768
[507]: -4
[508]: 262
[509]: -32768
[510]: 88
[511]: -32768
[512]: -32768
[513]: 269
[514]: 264
[515]: -32768
[516]: 270
[517]: 300
[518]: 270
[519]: 88
[520]: 159
Clearly the flow temperature without MFG returns out of scale, unless it's a cascade with common manifold sensor.
Common manifold sensor in a cascade is optional.
I would recommend using 542/543, which works in all cases (for heat pump 1 in a cascade) +7 for each further unit in a cascade.

In my case 542/543 does not work (I have a WPM 3i). So we probably need to check if we have a valid value in 513 and read 543 only if this is not the case.

Makes sense. WPM3i actually don't have 542/543, you're right. So I'll try to fix it.


Update styles.md

Fixed example for "drop superfluous _..."

[X] Please sign Adobe's CLA if this is your first time contributing to an Adobe open source repo. Thanks!

ty! ❤


Ensure individual documentation job failures are marked as entire workflow failures

This workflow has been converted from a matrix workflow to a standard workflow and the issue should now be resolved.


Command Not Found on Line 30 for build-iso.sh

eighti@console:~/Downloads/linux-unattended-installation-master/ubuntu/18.04$ sudo ./build-iso.sh
[sudo] password for eighti:
--2018-07-16 19:28:01--  http://archive.ubuntu.com/ubuntu/dists/bionic/main/installer-amd64/current/images/netboot/mini.iso
Resolving archive.ubuntu.com (archive.ubuntu.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to archive.ubuntu.com (archive.ubuntu.com)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 67108864 (64M) [application/x-iso9660-image]
Saving to: ‘./netboot.iso’

./netboot.iso       100%[===================>]  64.00M  9.98MB/s    in 8.4s

2018-07-16 19:28:10 (7.58 MB/s) - ‘./netboot.iso’ saved [67108864/67108864]

./build-iso.sh: line 30: : command not found
eighti@console:~/Downloads/linux-unattended-installation-master/ubuntu/18.04$ ls
build-disk.sh  build-iso.sh  custom

Sorry if I am missing something simple

solution for missing dependencies:
sudo apt install dos2unix p7zip-full

p7zip-full is already mentioned here https://github.com/core-process/linux-unattended-installation#prerequisites.
dos2unix needs to be added to the readme.md.

It does indeed! Clever work Niklas : )


Fix table legend formatting

- and * were not shown, back tick fixes that.

This used to work -- I wonder if GitHub changed how its parses markdown?  I wonder if there is some way to address this without using fixed-width text?


bug: Provide more context when links open in a new window/tab [screen reader accessibility]

Hi,

Relates to :~ #3655.

Screenshots

Version

WebChat.js version :~ 4.10.1;
JS :~ https://cdn.botframework.com/botframework-webchat/4.10.1/webchat.js;

Describe the bug
As a screen reader user, when I follow a link from within a WebChat-based Chat-bot, it is set to open in a new window/tab in my browser, which will confuse me and mean that my Back button doesn't work.

Steps to reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
I need extra text (visually hidden) within the link, warning me that the link will open in a new window. For example:

        Find out more about learning disabilities
         Opens in a new window

CSS example - twbs/bootstrap ~ _visually-hidden.scss:
.sr-only,
.visually-hidden {
    position: absolute;
    width: 1px;
    /* ... */
}

I suggest that this should be implemented in renderMarkdown.js.
I'm currently investigating a possible implementation.

Additional context

Yours,
Nick
[Bug]

Hi @compulim, can you review this issue?

Hi @compulim, can you review this issue?

We only support plain text and Markdown content. For this type of work, I recommend you to pass a custom Markdown renderer to do so.
This is a topic outside of Web Chat, but out of my personal experience, you could use Markdown-It to achieve the job.

Parse the Markdown into a tree of token
Walk the tree of token, add sr-only as needed
Render the Markdown back into a string
Wrap step 1-3 into a function and pass it to Web Chat as using renderMarkdown option

We only support plain text and Markdown content. For this type of work, I recommend you to pass a custom Markdown renderer to do so.
This is a topic outside of Web Chat, but out of my personal experience, you could use Markdown-It to achieve the job.

Parse the Markdown into a tree of token
Walk the tree of token, add sr-only as needed
Render the Markdown back into a string
Wrap step 1-3 into a function and pass it to Web Chat as using renderMarkdown option

Hi @compulim,

We only support plain text and Markdown content.

Yes, the example HTML above was output, not Markdown passed into a Bot.

For this type of work, I recommend you to pass a custom Markdown renderer to do so.

The "I" in my report above is the end-user, not me specifically. Apologies if that wasn't clear.
I'm not concerned about my implementation specifically. I'm trying to help WebChat support better, more accessible behaviour by default ... most implementors are not going to bother passing a custom Markdown renderer.
Please can you re-open this bug report?
Thank you!
Nick

Hi @compulim,

We only support plain text and Markdown content.

Yes, the example HTML above was output, not Markdown passed into a Bot.

For this type of work, I recommend you to pass a custom Markdown renderer to do so.

The "I" in my report above is the end-user, not me specifically. Apologies if that wasn't clear.
I'm not concerned about my implementation specifically. I'm trying to help WebChat support better, more accessible behaviour by default ... most implementors are not going to bother passing a custom Markdown renderer.
Please can you re-open this bug report?
Thank you!
Nick

This is a duplicate of #3087. Closing as dupe.

This is a duplicate of #3087. Closing as dupe.


webpack-serve doesn't auto reload page when a new bundle is detected and compiled

Operating System: Windows 10 64-Bit Pro
Node Version: 9.4.0
NPM Version: 6.0.0
webpack Version: 4.8.1
webpack-serve Version: 0.3.2

This issue is for a:

[ ] bug
[ ] feature request
[ ] modification request

Code
CLI Command
  $ webpack --watch

  $ webpack-serve ./webserve.config.js

webpack.config.js
  module.exports = {
    mode: 'production',
    devtool: 'inline-source-map',
    entry: './dist/build/index.js',
    output: {
        filename: 'mainPack.js',
        path: __dirname + "/dist/build/",
        publicPath: "/dist/build/"
    },
    resolve: {
        extensions: ['.ts', '.tsx', '.js']
    },
    module: {
        rules: [

            { test: /\.css$/, use: ['style-loader', 'css-loader'] },
            { test: /\.tsx?$/, use: 'ts-loader' }
        ]
    },
};

Expected Behavior
The browser reloads as soon as it repacks with changed file contents.
Actual Behavior
Nothing on the page changes until a manual page refresh.
How Do We Reproduce?
(Both webpack.config.js and webserve.config.js contain the same code)

Build appropriate directories for the config to use
Build a bundle based off TypeScript Preact (Can use https://preactjs.com/guide/getting-started#components as a test.
Run webpack -watch and then in a seperate terminal webpack-serve ./webserve.config.js
Make change in TypeScript, compile it, watch bundle rebuild and no change made on the webpage.

@BlackHoleFox Thanks for the issue :beer:
Unfortunately what you have here is a misunderstanding of the tools you're using. webpack-cli and webpack-serve don't work in tandem. webpack-serve uses webpack-dev-middleware to handle the building and serving of the bundles (it does that in memory, not on disk) and doesn't pay attention to bundles written to disk. If you want to accomodate that scenario, I'm afraid you're going to have to write quite a bit of code to make that happen.

So there is no native "hot reloading" then with webpack-serve?

@mariogillazaro for stuff that is very clearly acting up we typically ask for a basic, simple example repo. one that is the smallest possible size to reproduce the issue. 9 times out of 10, it ends up being something in your config, outside of webpack-serve.

@shellscape Makes total sense. Actually reading through closed issues I found out my issue was the static files precedence thing, for some reason I didn't know about that

That keeps popping up. As a convenience we add the process.cwd() to the list of static files to serve, and that may need to be changed not to in the next major version, as it seems to confuse more than it helps.

I found that only html will not be refreshed,  it works for css or js .

Is there any updates? I have the same issue

@timurmaio if you don't see any updates on this issue, then there are no updates. that applies for the whole of github.

@shellscape that was my first reply on github, thanks for the explanation :)

@shellscape I still have a question. Searched for all issues and didn't find an answer. This issue is closed, so that means the issue is solved? But I don't see an answer.
I use webpack-serve with html-webpack-plugin. When I change any file I see webpack-serve recompiles everything, but it doesn't refresh the page.
Should I start another issue with all information about the issue or I just can't understand and the answer is there?
I will be very grateful for the answer 🙂

@timurmaio no worries. issues are closed when it's determined that an issue is resolved, not a bug, or caused by something which has a workaround or is preventable.
we don't offer support in the issues for the project (nor does any webpack-contrib project really). I would recommend asking about the issue on Stack Overflow and tagging webpack, or on the webpack gitter at https://gitter.im/webpack/webpack. For either or both, it would help people to have a link to your repository. From your description it sounds like you have your app configured incorrectly, your app may not be accepting hmr changes (you would see messages in the browser console), or you may be suffering from the same issue mentioned in this comment. You can also try rebuilding your app from a simple starting point (you can check out the test apps for this project as a base) and adding portions of your app back in to identify where the problem may be.

For people in the future suffering this issue as I did, the "static files precedence thing" was also the root of my problems. In this case, I had set webpack-serve's content option to be the place where I was outputting my webpack files that were built with the cli. webpack-serve takes the js files etc produced by the cli on disk with greater precedence than the ones it compiles in memory. The ones produced by the cli do not have any of the hot module replacement code injected so do not reload. The solution for me was to not set the content option at all.
All in all, I found this very confusing. It would have helped immensely to have a warning when a static file is chosen over an in memory one.

Has anyone been able to get their page to actually reload when a change is made? I always have to manually refresh. I'm running the latest version of Chrome, and here is what I'm doing:
I run webpack-serve --config webpack.config.dev.js where that config file has the following entry:
serve: {     host: '<IP_ADDRESS>',     port: 9000,     open: true   }
My browser's console has the following (from initial load through modifying a file):
｢hot｣ Hot Module Replacement Enabled. Waiting for signal.
｢hot｣ WebSocket connected
｢hot｣ App updated. Recompiling src/app/patients/list/patientList.js
｢hot｣ webpack: Compiling (<unnamed compiler>)
｢hot｣ App Updated, Reloading Modules
｢hot｣ Checking for updates to the bundle.
｢hot｣ No Modules Updated.
｢hot｣ App is up to date.

I'm not sure what I'm missing here... Is it telling me that even though that file changed, there are no modules that have changed, so the app is already up to date? In the browser I have the page open that uses the file I modified, so I would have expected to see the change. If I manually refresh the browser, I do see the change.
Any help would be greatly appreciated. This had been working great with webpack-dev-server, with basically the same setup (just different config options that were needed by it).

@mrobrian I would recommend taking a look at the test apps in https://github.com/webpack-contrib/webpack-serve/tree/master/test/apps. You'd start them via node test/apps/config for example. Those all have reloads working, and are minimum viable apps you can use to verify that webpack-serve does indeed reload and perform HMR patching in realtime. ｢hot｣ is a message from webpack-hot-client, which acts as a webpack build commands. If there were no updates detected, that's webpack telling the client module as much.

Same issue here and I don't know where to debug from this point.
My config for serve:
module.exports = () => ({
	clipboard: false,
	dev : {
		logLevel: 'warn'
	},
	port: 3000,
	hot: {
		autoConfigure: true,
		port: 3001
	},
	host: 'localhost'
})

I have a single entrypoint index.js with 1 line of console.log and changing the logged value there. No reload, getting same message as above mentioned.

Try the beta.
Also, autoConfigure is true by default 😉  If all else fails, take a look at the test apps and what they're doing differently than what your setup is doing. Sometimes a simple comparison can yield where the error's origin lies.

@shellscape (and anyone else running into this) for me, the problem is that we use entry to separate out vendor scripts.
To test my theory I created a simple project that reflects my typical environment (React, Typescript, Webpack). If I set my entry to just ['./app.tsx'] it works fine. I can change files and the page reloads. If I set my entry to something like:
{
  vendors: [ list of vendor scripts ],
  app: './app.tsx'
}

then code changes do not cause the page to reload.
Since all of my projects are configured with a vendors entry, none automatically reload. With the single entry I just get one big chunk, so to solve for that I added this section:
  optimization: {
    splitChunks: {
      cacheGroups: {
        vendor: {
          test: /node_modules/,
          chunks: 'all'
        }
      }
    }
  }

So now, at least in my tiny little sample app, I get 2 bundles and page reloading works. My other projects are far more complex, so I'll see if I get it working there, but I imagine there will be other people who upgrade from a previous version of webpack and migrate from webpack-dev-server and are wondering why their page doesn't reload anymore.

@mrobrian that's some great info. this is probably due to webpack-hot-client automatically configuring the client script for entries on the first entry only. See: https://github.com/webpack-contrib/webpack-hot-client#allentries

If true and autoConfigure is true, will automatically configures each entry key for the webpack compiler. Typically used when working with or manipulating different chunks in the same compiler configuration.

You can also turn off autoConfigure and add the client scripts to needed entries manually.
I'm open to suggest on how to make that more clear and easier to discover for users.

I'm facing the same issue, but my stack is a bit different.
I have a .serverc.json in my project folder:
{
  "open": true,
  "hotClient": {
    "autoConfigure": true,
    "allEntries": true
  },
  "port": 9000
}

And hot-reload works with this webpack configuration:
module.exports = {
  entry: ['@babel/polyfill', './src/app'],
  ...

But stop working when setting webpack.config.js this way:
module.exports = {
  entry: {
    polyfill: '@babel/polyfill',
    main: './src/app',
  },
  ...

So it stops when entry points are more than one.
What do I have to set to solve this situation?
Thanks

@mariogillazaro gotta read them docs, this is in the webpack-hot-client README. webpack-hot-client only automatically adds the entry script to the first entry described if an entry property is an Object. If you want to change that behavior, you can put your primary as the first property, use allEntries: true or autoConfigure: false an manually inject the entry script where you need it.

Of course I read the docs, and your comment too, but I still can't get the point. I'm sorry.
Docs says:

allEntries: If true and autoConfigure is true, will automatically configures each entry key for the webpack compiler.

Ok, in my configuration both options are set to true, entry property in my second webpack configuration is an object... but hot reload doesn't work.
So, isn't that the entry property docs are talking about? Or do I have to declare those entries into a specific webpack-hot-client option?
Thanks

It's probably important to include the version of webpack-serve used... I'm using version 1.0.4, which was the latest at the time I posted my messages above. That version had a dependency on webpack-hot-client of ^3.0.0, but webpack-hot-client didn't start supporting allEntries until version 4. So if you're on version 1.x of webpack-serve, it won't matter what you set allEntries to, it won't work. I'm assuming it will work in 2.x, but I haven't upgraded yet.

I have same issues. I have multiple entry points and I was hoping to migrate from webpack-dev-server to webpack-serve. A config which works OOTB with webpack-dev-server simple doesn't trigger any reloads with webpack-serve.
Manual reload always shows a good fresh version so recompiling is working properly.

Previously with webpack-dev-server I was using the following entries:
entry: {
    Main: [
        `webpack-dev-server/client?http://localhost:${port}`,
        "webpack/hot/only-dev-server",
        path.join(__dirname, "..", "Source", "Index.tsx"),
    ],
    Agent: path.join(__dirname, "..", "Source", "Services", "Agent", "Index.tsx"),
}

After trying out webpack-serve I have this variant:
entry: {
    Main: path.join(__dirname, "..", "Source", "Index.tsx"),
    Agent: path.join(__dirname, "..", "Source", "Services", "Agent", "Index.tsx"),
},

Unfortunately though HMR isn't injecting itself nor reporting in the DevTools console. What is the correct module to prepend to my entry manually?

I resolved my issue surprisingly quick - since I am not packing for the web but for Electron I had to add a new target like so:
serve: {
    hotClient: {
        validTargets: ["electron-renderer"],
    },
},

Having the same issues with multiple entries/modules/bundles. In client side log there are info pushed out:
｢hot｣ App updated. Recompiling src/marko/index.marko
log.js:59 ｢hot｣ webpack: Compiling (<unnamed compiler>)
log.js:59 ｢hot｣ App Updated, Reloading Modules
log.js:59 ｢hot｣ Checking for updates to the bundle.
log.js:59 ｢hot｣ No Modules Updated.
log.js:59 ｢hot｣ App is up to date.

But it decides there are no changes (oh, but there are). A reload exposes the changes.
I've tried with the options for allEntries:
serve: {
    content: [path.resolve(__dirname, "dist")],
    port: 5001,
    hotClient: {
      allEntries: true
    },
  }

I'm with:
webpack-serve: 2.0.2
webpack: 4.16.5
(webpack-hot-client: 4.1.1) - transitive only

It's definitely true that HMR only works for the first module listed in webpack config. In my case I can get my js changes pushed simply by going from:
entry: {
    materialize: path.resolve(__dirname, 'src/materialize/kb-materialize.scss'),
    marko: path.resolve(__dirname, 'src/marko/marko-bootstrap'),
 },

to
entry: {
    marko: path.resolve(__dirname, 'src/marko/marko-bootstrap'),
    materialize: path.resolve(__dirname, 'src/materialize/kb-materialize.scss')
  },

However, I'm now stuck with css changes not reloading instead :)
Setting allModules: true does NOT change this at all.
@matteoferigo Did you solve this?


Write MeiliSearch tech standards

This is done, in Notion for now but I think there is a task for @react-learner to add this into the documentation for contributors.


Error while trying to call snps " UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 948: ordinal not in range(128)"

Hi,
I am trying to call snps from bam fil generated by minimap2, but I got an error
NanoSV BC01_sorted.bam -o BC01.vcf
I got this error message
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 948: ordinal not in range(128)
Here is the complete output
Traceback (most recent call last):
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/bin/NanoSV", line 7, in <module>
    from nanosv.NanoSV import main
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/site-packages/nanosv/__init__.py", line 1, in <module>
    from .utils import *
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/site-packages/nanosv/utils/__init__.py", line 1, in <module>
    from . import coverage
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/site-packages/nanosv/utils/coverage.py", line 8, in <module>
    import NanoSV
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/site-packages/nanosv/utils/../NanoSV.py", line 29, in <module>
    cfg.read(args.config)
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/configparser.py", line 697, in read
    self._read(fp, filename)
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/configparser.py", line 1015, in _read
    for lineno, line in enumerate(fp, start=1):
  File "/Users/tarekmagdyshehatamohamed/miniconda3/envs/bioinfo/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 948: ordinal not in range(128)

See #45

Thanks for the reply
I added the two lines in my bashfiles, but did not work

Did you source your .bashrc or restart your terminal?

Any other suggestions?

Maybe you can try to make the following bash file (eg. nanosv.sh)
#!/usr/bin/bash

export LC_CTYPE=en_US.UTF-8
export LANG=en_US.UTF-8

NanoSV BC01_sorted.bam -o BC01.vcf

And try to execute this bash file like ./nanosv.sh

I tried it and unfortunately I got the same error message !

Can you check your environment variables to be sure:
echo $LANG
echo $LC_ALL

Both should give en_US.UTF-8 as output.
You can also try this export LC_ALL=en_US.UTF-8.
And you also check the default encoding language in your python:
import sys
sys.getdefaultencoding()

Hi,
export LC_ALL=en_US.UTF-8 worked, but I have one more question  now.
I need to generate a bed file for hg38 with chrx notation.
I got simple_repeats_file is from http://hgdownload.cse.ucsc.edu/goldenPath/hg38/database/simpleRepeat.txt.gz
and gaps_file is from http://hgdownload.cse.ucsc.edu/goldenPath/hg38/database/gap.txt.gz
I then unziped the files and renamed then gap.bed and  simpleRepeat.bed
genome = { 1: 248956422, 2: 242193529, 3: 198295559, 4: 190214555, 5: 181538259, 6: 170805979, 7: 159345973, 8: 145138636, 9: 138394717, 10: 133797422, 11: 135086622, 12: 133275309, 13: 114364328, 14: 107043718, 15: 101991189, 16: 90338345, 17: 83257441, 18: 80373285, 19: 58617616, 20: 64444167, 21: 46709983, 22: 50818468, 23: 156040895, 24: 57227415 }
simple_repeats_file = '/Users/tarekmagdyshehatamohamed/Downloads/gap.bed' gaps_file = '/Users/tarekmagdyshehatamohamed/Downloads/simpleRepeat.bed'
I then ran the .py file and I got this error message
$ cd /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles ;env "PYTHONIOENCODING=UTF-8" "PYTHONUNBUFFERED=1" /Users/tarekmagdyshehatamohamed/miniconda3/envs/pythontwopointseven/bin/python /Users/tarekmagdyshehatamohamed/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/PythonTools/visualstudio_py_launcher.py /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles 58853 34806ad9-833a-4524-8cd6-18ca4aa74f14 RedirectOutput,RedirectOutput /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles/create_human_hg38_bed.py
Traceback (most recent call last):
File "/Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles/create_human_hg38_bed.py", line 63, in
read_bed(simple_repeats_file)
File "/Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles/create_human_hg38_bed.py", line 46, in read_bed
ch, start, end = line.split("\t")
ValueError: too many values to unpack

This is because the download file are not a proper bed file. First you need to convert the .txt file to a .bed file.
cut -f 2,3,4 gap.txt > gap.bed
cut -f 2,3,4 simpleRepeat.txt > simpleRepeat.bed

Maybe you should also remove the chr notation in front of the chromosome names, depends on the bam file, if this has also the chr notation or not.

These are my bed files
$ cat gap.bed | head -n 10
chr1	0	10000
chr1	207666	257666
chr1	297968	347968
chr1	535988	585988
chr1	2702781	2746290
chr1	12954384	13004384
chr1	16799163	16849163
chr1	29552233	29553835
chr1	121976459	122026459
chr1	122224535	122224635

$ cat simpleRepeat.bed | head -n 5
chr1	10000	10468
chr1	10627	10800
chr1	10757	10997
chr1	11225	11447
chr1	11271	11448

When I run the .py file  I got this error
$ cd /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles ;env "PYTHONIOENCODING=UTF-8" "PYTHONUNBUFFERED=1" /Users/tarekmagdyshehatamohamed/miniconda3/envs/pythontwopointseven/bin/python /Users/tarekmagdyshehatamohamed/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/PythonTools/visualstudio_py_launcher.py /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles 50921 34806ad9-833a-4524-8cd6-18ca4aa74f14 RedirectOutput,RedirectOutput /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles/create_human_hg38_bed.py Traceback (most recent call last):   File "/Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles/create_human_hg38_bed.py", line 79, in <module>     for mask_start in sorted(mask_regions[randchr]): KeyError: 5

It can't find chromsome 5 in the bedfile, because in the bed it has this chr notation.
Remove the chr notation in the bed file or add the chr notation to the chromsomes in the genome dictionary.

I modified the genome dictionary as follows,
genome = { 'chr1': 248956422, 'chr2': 242193529, 'chr3': 198295559, 'chr4': 190214555, 'chr5': 181538259, 'chr6': 170805979, 'chr7': 159345973, 'chr8': 145138636, 'chr9': 138394717, 'chr10': 133797422, 'chr11': 135086622, 'chr12': 133275309, 'chr13': 114364328, 'chr14': 107043718, 'chr15': 101991189, 'chr16': 90338345, 'chr17': 83257441, 'chr18': 80373285, 'chr19': 58617616, 'chr20': 64444167, 'chr21': 46709983, 'chr22': 50818468, 'chr23': 156040895, 'chr24': 57227415 }
I ran the .py file multiple times, it gave me the same error with different unfound chr
for mask_start in sorted(mask_regions[randchr]): KeyError: 'chr18'
'for mask_start in sorted(mask_regions[randchr]):
KeyError: 'chr11'
I checked the bed files for these chrs
`$ cat gap.bed | grep 'chr18' | head -n 5
chr18	0	10000
chr18	15410899	15460899
chr18	15780377	15780477
chr18	15788380	15791047
chr18	15797755	15797855
$ cat gap.bed | grep 'chr11' | head -n 5
chr11	0	10000
chr11	10000	60000
chr11	50821348	50871348
chr11	50871348	51078348
chr11	51090317	51090417
 $ cat gap.bed | grep 'chr18' | head -n 5
chr18	0	10000
chr18	15410899	15460899
chr18	15780377	15780477
chr18	15788380	15791047
chr18	15797755	15797855
$ cat gap.bed | grep 'chr11' | head -n 5
chr11	0	10000
chr11	10000	60000
chr11	50821348	50871348
chr11	50871348	51078348
chr11	51090317	51090417
`

There was a minor bug in the script. This should be fixed by now, in the newest version of NanoSV (v.1.2.1)

I modified the genome dictionary as follows,
genome = {
    'chr1': 248956422,
    'chr2': 242193529,
    'chr3': 198295559,
    'chr4': 190214555,
    'chr5': 181538259,
    'chr6': 170805979,
    'chr7': 159345973,
    'chr8': 145138636,
    'chr9': 138394717,
    'chr10': 133797422,
    'chr11': 135086622,
    'chr12': 133275309,
    'chr13': 114364328,
    'chr14': 107043718,
    'chr15': 101991189,
    'chr16': 90338345,
    'chr17': 83257441,
    'chr18': 80373285,
    'chr19': 58617616,
    'chr20': 64444167,
    'chr21': 46709983,
    'chr22': 50818468,
    'chrX': 156040895,
    'chrY': 57227415
}

Then I ran the new .py script several times in python 3.6.3 after modifying genome.itertitems() to genome.items()
I git this error
Traceback (most recent call last):
  File "/Users/tarekmagdyshehatamohamed/miniconda3/pkgs/nanosv-1.2.0-py36_1/lib/python3.6/site-packages/nanosv/bedfiles/test02.py", line 75, in <module>
    randchr = randchr.replace('chr','')
AttributeError: 'int' object has no attribute 'replace'

I also tried it by removing the chr notation from my two bed files with the original genome dictionary, and I got the same error as above.
genome = {
1: 248956422,
2: 242193529,
3: 198295559,
4: 190214555,
5: 181538259,
6: 170805979,
7: 159345973,
8: 145138636,
9: 138394717,
10: 133797422,
11: 135086622,
12: 133275309,
13: 114364328,
14: 107043718,
15: 101991189,
16: 90338345,
17: 83257441,
18: 80373285,
19: 58617616,
20: 64444167,
21: 46709983,
22: 50818468,
23: 156040895,
}

cat simpleRepreat.bed | sed s/chr// > simpleRepeate_nochr.bed
cat gap.bed | sed s/chr// > gap_nochr.bed

$ cat gap_nochr.bed | head -n 5
1	0	10000
1	207666	257666
1	297968	347968
1	535988	585988
1	2702781	2746290

$ cat simpleRepeat_nochr.bed | head -n 5
1	10000	10468
1	10627	10800
1	10757	10997
1	11225	11447
1	11271	11448

Sorry but there were still some bugs in the script. Can you try it again with the newest version (1.2.2)

Any thoughts ?

And if you try this on a subset of your bed file:
$SAMTOOLS depth $BAM -b $BEDFILE | awk '{print $3}'

Do you get any result?

yes I got some results
$ samtools depth BC01_sorted.bam -b hg38_withchr02_xyy.bed | awk '{print $3}' | head -n 5
1
1
1
1
1

Did you use the same samtools path (I see samtools and /Users/tarekmagdyshehatamohamed/miniconda3/pkgs/samtools-1.8-3/bin/samtools? NanoSV execute the previous command to calculate the distribution and if it returns an empty list than you will get this error. But is seems that it will returns a list, so it should work.
I think the problem is samtools and the libdeflate.so library.


Document Chronograf swagger documentation available at :8888/docs

Chronograf swagger documentation is available at the /docs path in Chronograf
http://localhost:8888/docs

@russorat mentioned that endpoints in the Chronograf API are often in flux and broken and that it may be better to leave this undocumented. Should I close this issue?

@sanderson 00 -- I think we can close this for now and re-evaluate when Chronograf API is more stable in new platform.


can not zoom in in latest chrome

What you expected to happen?
It can zoom out and zoom in in chrome.
What happened?

It can zoom out but can't zoom in after I've updated chrome to 73.0.3683.103(the latest version)
and web  console:
[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See
How to reproduce it?

scope launch and use chrome version 73.0.3683.103(the latest version) to  open http://<IP_ADDRESS>:4040 and rolling.
Anything else we need to know?

It works in firefox and older versions of the chrome
(I didn't go back to the older versions of the chrome, but it was fine a few days ago).
It can't zoom out and zoom in in safari.
Versions:

$ scope version
Weave Scope version 1.10.2
$ docker version
$ uname -a
Darwin zuilideMacBook-Pro.local 17.7.0 Darwin Kernel Version 17.7.0: Wed Feb 27 00:43:23 PST 2019; root:xnu-4570.71.35~1/RELEASE_X86_64 x86_64
$ kubectl version

Logs:
$ docker logs weavescope

or, if using Kubernetes:
$ kubectl logs <weave-scope-pod> -n <namespace>

resolved

Thanks for opening the issue @leavest!

resolved

We don't usually close issues until the PR that resolves them has been merged with master, so I will reopen this one.


Fixes to emit / format for codeFix

Fixes #18437
Fixes #18434
This is basically a sequel to #18284 -- we need to remember to call callbacks for an empty list (e.g. from an empty case statement). We also can't look assume that parent exists in formatting rules, because synthesized nodes don't have parents.
@mhegazy This might be a good idea to get in for 2.5.3.

let's port it to release-2.5 as well.


Components (Events, Todos) serialized non-deterministically

When one serializes e.g. Calendar to icalendar using to_string(), fields within individual events get shuffled over multiple runs of one's program. This is almost surely because icalendar-rs uses HashMap to store component properties, which has arbitrary (randomized across runs) iteration order.
While this is not incorrect, it is rather impractical, for example for writing integration tests.
This could be solved by explicit sorting or maybe better yet by using e.g. BTreeMap instead of HashMap, which has sorted iteration order.
I'm about to code this, but wanted to get acknowledge before starting work.

that sounds like a good idea


build: add github actions ci workflow for PR

make sure the code created by the contributor is working. I have added some CI steps:

setup go version 1.17
checkout the code
get or install dependencies
run the unit test

#6

it works :))


[RFC] support background opacity with css var

Clear and concise description of the problem
currently if i have
preflight that returns an css var :   --primary=0 0 0 1
hsla(var(--primary)) defined in theme, and use it as  bg-primary/5 , this won't work, opacity isn't applied
i think nested boxShadow does not work also,  shadow-border-light
repro:
https://unocss.dev/play/?html=FAHgJglgbgBARgcwLQHcAWEAuBTGM1IBmArgDal4w4AemSAxtgHY4BOMhp21MAztl3p0mAeya4AhuQBcmVhKa8sEMUgAsABg3wRrMNlbqdeg0lbYwSAKxaYAPmB5w0PmglgRKJHF37DpCAQ0TBgAW2okCWJMEUoaOjhSCXoAazwfE0M1Yz8zCyQARls7HF5MEAB6SCgHRydqmHok3l4AXgAiXjcPLwzcgKCQ8Mjo2Lx47yTU9N9TbL7Tc0si7UQkAAdWCFCJVgBPCoBmDXaYdpLsMoAmSuqHW%2BgHIA&config=JYWwDg9gTgLgBAbwFBzgEwKYDNgDsMDCEuOA5gDQpxhQYDOGMAgjDFMAEYCuMwWAnpVQ16jAJIBjYnSHVaDGAFVcESgF84WKBBBwA5FxUS6dPUiQYAHpFjpsAQy4AbeJhz4iJYKQAUyVFDO9ABccADaVKhhehJcdDA6ALSBThh65IhwUk7QoXq0aHpwagC6VCVCIlhO3gAWMHShEaj%2BqHCkjAQAyl2hfnAwtRggGMUAlHAAvAB8cAAGkajB2hAwrW2JiTSg9lD8oQBMRwB0BxkALADsx%2BcApBkAjA%2Bnt3DkAAzHAKwA3Iuom22IF2-AeoUu70eAGZIXBLg8-m1UGpFgtkUgKlQ6LVoDBYg1Qut9LF4klsbj8Xo8jArDBEk5SANaYloPZcB04DiAG4YKDBGmWOk0%2BxOMzI2QiBSNcKLSWMZQQHxjWTCeSMFhsTg8Pj8JUquSiGCSaR%2Bf5wOgSEUYULPM5miRoXB5eowMCNAD07voIGO2PdYraamV5Vkg2G1qJ2WgjSJqAAkECQYSkHHU3HPQARACiADEmIoADIAFWddCc9h8XN2PkB7GBezGY3SKbT2bzhZL%2BigpA4FarUBrWzrIIejebabjWGgGFI2kMaFL5cr1drOz2iSntFnEHnY5bcZRSLU%2BtTHAgli6tXsaAgAHdk2maqR6ry8t3ez5YV%2BMp8HgA2CZ3jASw4AeYC4HOYDx1TJ96jfHsKwATkQjJkNQlC4E%2BA5APAg5wIADnAoDLGguM6DAXYGGCfc43yBDPx-RjMNOL4cJAr5IPYr5gIyd8K2-TCf2OB5sMw8DEhE8CYR4uA%2BIYwSFN-UTiIg8C-xkuSBK-YTLjY0C8JAh4oQ0%2BitKE95EL0xJjPY4CflIs8oEwPlEBo2CYHgj8zOY-89LAkDON4nsfC%2BB4MlC8LRzEkCVJUmzSLjdzXxo2jNKY7SHl06K4ESA4bLgA5uJi8C8AUIKvPSoSHlY7LrPUkDpOKkDSsYcr%2BMqnyrMuRDwPOWKStwMrZNMjrPneADsoM0CTIqxTzMs7LOIKmb2rm5iLL0wiApW%2BStOODbsv-Aidu8saFriqajpI-cUVTQ9iiQIMkCAA&css=Q&options=N4IgLgTghgdgzgMwPYQLYgFwKgGzgUwF8g
Suggested solution
https://tailwindcss.com/docs/customizing-colors#using-css-variables
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the README.md of using the package.
[X] Already used the Interactive Docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

This seems to be possible through presets, such as unocss-preset-palette


Add unchecked methods, fix _mm_extract_epi* return types

Adds extract_unchecked + replace_unchecked + len (#222 )
Fixes the return types + uses extract_unchecked for:

_mm_extract_epi8
_mm_extract_epi16
_mm256_extract_epi8
_mm256_extract_epi16

Minor changes to the other extract_epi* intrinsics for style consistency

These should now zero-extend the extracted int and behave appropriately. An old typo makes these a bit confusing, See this llvm issue.

@governortarkin sorry for taking this long, I thought the test were broken but it seems that those failures are spurious! Feel free to ping us directly if this ever happen again!
@governortarkin could you remove the ::len associated function? I feel that its addition hasn't been discussed enough (e.g. do we really need this, if so, should it be an associated function, associated const, etc.). Or how do you feel about that @BurntSushi ? If you are ok with it we can always merge this and change it later.

@governortarkin thanks for doing this!
@BurntSushi I've marked the len issue as a release blocker, we can remove/rename the len associated function or change it to an associated const later, but we should do so before the next release.


Schdeduler hangs when executing sched actions

Description
When a Virtual Machine has more than one sched action in repeat mode, the scheduler sometimes hangs finding the next action to execute.
To Reproduce
Have a virtual machine with more than one sched action and mark them as repeat.
Expected behavior
It shouldn't hang.
Details

Affected Component: Scheduler
Version: any.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

This issue has been fixed in this commit.


File Missing Missing

i cannot find the test file python zbzocr/ocr-gui.py as wriiten in docs

It needs to be rewritten for Python 3. I haven't worked on this from past 3 years. Feel free to fork it and submit a PR to update.


Fix unused-function warnings and enable -Wunused-function

Move functions in .h files to .cpp files where appropriate; align prototypes and definitions; and remove functions that are not used.
Signed-off-by: Sven van Haastregt<EMAIL_ADDRESS>

Qualcomm would like some more time to review this change.

Merging as discussed in the December 13th teleconference.


Connector commits before doing a potential merge

connector framework should commit local changes before calling BriefcaseDb.pullAndMergeChanges() to prevent a potential merge from failing.

@Mergifyio update


Seaching camel-case words returns invalid results

Entering a ReadTimeout (camel-case) is interpret as read timeout.
I found a way to reproduce this issue in requests project:

read timeout (separated words), returns 2 hits: https://requests.readthedocs.io/en/master/search/?q=read+timeout

ReadTimeout (one word), returns the exact 2 hits: https://requests.readthedocs.io/en/master/search/?q=ReadTimeout

Although, in the second example, it should return something about https://requests.readthedocs.io/en/master/api/#requests.ReadTimeout as https://requests.readthedocs.io/en/master/search/?q=TooManyRedirects does.

Finally, readtimeout (lower case) returns exactly the result that I would want for ReadTimeout (camel case): https://requests.readthedocs.io/en/master/search/?q=readtimeout

I noted two more things here:

the results that you can see in the images, all of them are in Italic but the last one is highlighted in yellow
only the last image has reStructuredText on its response

@humitos Tried reproducing this but the search results vary in my local deployment where I have built the docs of requests using the Github URL of my fork.
Search query read timeout:

Search query ReadTimeout:

Search query readtimeout:

Am I missing something?

I think you need to setup elastic search on your local instance

I have the exact version as mentioned in the docs setup already.

@safwanrahman were you able to test this out with the new changes you were making to the whole search? Did you notice any difference with current production version?

@humitos I did not get chance, I will look into it as soon as we deploy.

I suspect its related to the Domain object indexing. requests.ReadTimeout is a domain object. As we are not indexing domain object separately, it will not work on the upgraded search also.
It will  be fixed with #4289


Navigo UI - Test Update 4

Added "waitForAngular" to 2 tests.

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #185   +/-   ##
======================================
  Coverage    71.3%   71.3%
======================================
  Files         245     245
  Lines       15558   15558
  Branches     1663    1663
======================================
  Hits        11093   11093
  Misses       4465    4465

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bbfc7...5e5b283. Read the comment docs.


Implement axis type

Implement a property to control the type of an axis

Possible values according to https://www.chartjs.org/docs/3.0.2/axes/cartesian/:

linear
logarithmic
category
time
timeseries

Released with version 3.22.07


[connectors] - feature(microsoft): implement PDF file handling

Description
This PR aims at adding support for PDF file in Microsoft connector.
References:

https://github.com/dust-tt/dust/issues/5744

Risk

Deploy Plan

On hold until we introduce Apache Tika (has pdf2text) is a bit inconsistent and flaky


Set stroke width when using iconoir css implementation.

Hi,
Is there any way to set the stroke width to a custom value when using the css implementation?

Unfortunately, not currently since the stroke-width is hard-coded in the CSS SVG mask. I'm not entirely sure it's possible, either, to include CSS variables inside a mask.

Ok it's what I thought. Thank you


Path specification query

i have some queries regarding your git hub EEG-Emotion-classification code  https://github.com/Raghav714/EEG-Emotion-classification  . I have run your code and got the error at this line in load_deap.py file.
fname = "/data_preprocessed_python/data_preprocessed_python/s"+str(name)+".dat"
x = pickle.load(open(fname, 'rb'))
The error is which i am getting is:
File "C:/Users/Rahama Tahir/Desktop/new/EEG-Emotion-classification/load_deap.py", line 19, in
x = pickle.load(open(fname, 'rb'))
FileNotFoundError: [Errno 2] No such file or directory: '/data_preprocessed_python/data_preprocessed_python/s01.dat'
Can you please help me out with this. By explaining it in more detail, how to exactly make it run and what are you trying to store in fname. I am using Pycharm to run your files.
Kindly help me out it would be of great help

Hi Raghav714
I have the same issue for regarding your git hub EEG-Emotion-classification code https://github.com/Raghav714/EEG-Emotion-classification . I have run your code and got the error at this line in load_deap.py file.
fname = "/data_preprocessed_python/data_preprocessed_python/s"+str(name)+".dat"
x = pickle.load(open(fname, 'rb'))
The error is which i am getting is:
Traceback (most recent call last):
File "load_deap.py", line 19, in
x = pickle.load(open(fname, 'rb'))
FileNotFoundError: [Errno 2] No such file or directory: '/c/Users/Chih-Hsing Lin/Downloads/EEG-Emotion-classification-master/s01.dat'
Can you please help me out with this. By explaining it in more detail, how to exactly make it run and what are you trying to store in fname. I am using Pycharm to run your files.
Kindly help me out it would be of great help

Can you help with this issue?

Hi Raghav714 @Raghav714
I have the same issue for regarding your git hub EEG-Emotion-classification code https://github.com/Raghav714/EEG-Emotion-classification . I have run your code and got the error at this line in load_deap.py file.
fname = "/data_preprocessed_python/data_preprocessed_python/s"+str(name)+".dat"
x = pickle.load(open(fname, 'rb'))
The error is which i am getting is:
Traceback (most recent call last):
File "load_deap.py", line 19, in
x = pickle.load(open(fname, 'rb'))
FileNotFoundError: [Errno 2] No such file or directory: '/c/Users/Chih-Hsing Lin/Downloads/EEG-Emotion-classification-master/s01.dat'
Can you please help me out with this. By explaining it in more detail, how to exactly make it run and what are you trying to store in fname. I am using Git Bash to run your files.
Kindly help me out it would be of great help

Hi Raghav714 @Raghav714
I have an issue regarding your git hub EEG-Emotion-classification code https://github.com/Raghav714/EEG-Emotion-classification . I have run your code and got the error in load_deap.py file.
The error is which i am getting is
FileNotFoundError: [Errno 2] No such file or directory. I'm attaching the screenshot of error. PFB
Could you you please help me out with this. By explaining it in more detail, how to exactly make it run and what are you trying to store in fname. I am using VS Code to run your files.
Kindly help me out it would be of great help

Regards,
Azhar Yaseen N J
<EMAIL_ADDRESS>


Document limitations use of docker container

GitHubs documentation states these can only be used on Linux virtual hosts
https://help.github.com/en/articles/workflow-syntax-for-github-actions#jobsjob_idstepsuses

yagni. rewrote in typescript for to support all virtual hosts


Use SSH pub key in order to allow access to a repository

Hello,
As I'm looking to mount a private Docker registry server, I'd like to limit the access not with user/password authentication system but with SSH key like Git does today.
Is there any plan to do this or am I the first one to request this ? :smile:

I guess I have just faced with a need of the same feature. +1.

:+1:
Here's what I've done in the mean time...
# Server 1: Registry Server
docker run -d -p <IP_ADDRESS>:5000:5000 registry:2

# Server 2: SSH Auth Server
ssh -N -L 5000:localhost:5000 user@registry_server_address -g

# Client: Test, should fail
curl http://server-1_registry_server_address:5000/v2/_catalog

# Client: Test, should pass
curl http://server-2_ssh_auth_server_address:5000/v2/_catalog

And now only those with SSH pub keys on Server 2 have access to the registry.

+1

really need it +1

I agree, docker is becoming as essential to development as git.

+1

@ph-One now ssh authentication (user or key) is requried to establish the tunnel, but the access to the HTTP endpoint is still open to everyone, so you end up in the situation where you started. Also restricting the forwarding to a specific IP-Adresse (client) is not really a viable solution. IN cases you open your system not the whole world, but a whole network behind NAT.

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

/me hears crickets chirping..

D***** is dead soon anyway :)
https://www.youtube.com/watch?v=BeRr3aZbzqo&t=1940s

+1

+1

+1

+1

+1


Possible for callbacks in an organizer?

Was suprised that I could not find a way to have an organizer perform callbacks.
Somewhat contrived example, but say I have a organizer that calls on a few interactors that work differently depending on the context:
class DriveMotorcycleToGroceryStore
  include Interactor::Organizer

  organize GetDirections, EngageVehicle, ParkInSpot

  before do
    context.car = "motorcycle"
    context.start_time = Time.now
    ...
  end
end

Possible to do this?
class DriveFancyCarToGroceryStore
  include Interactor::Organizer

  organize GetDirections, EngageVehicle, ParkInSpot

  before do
    context.car = "lamborghini"
    context.start_time = Time.now
    ....
  end
end

Sorry, it appears it is possible

Glad you got it figured! I was getting worried! 😄


Application hangs when destroying a File.createWriteStream() stream to abort the upload

Environment details

OS: Mac OS Ventura 13.5
Node.js version: 16.19
npm version: 8.19
@google-cloud/storage version: 7.6.0

Steps to reproduce
So I am trying to implement an endpoint on my server that would pass the incoming data to a File write stream and save it to GCS, and I want to halt the upload if during streaming file turns out to be bigger than expected. Here's a snippet of how it is implemented:
const MAX_TRANSACTION_IMAGE_SIZE_BYTES = 10 * 1024 * 1024;

async function test(body: NodeJS.ReadableStream) {
  let receivedBytes = 0;
  const cancelStream = new AbortController();

  const bucketName = 'bucket';
  const file = this.storage
    .bucket(bucketName)
    .file('image.png')
    .createWriteStream();

  const validateStream = new PassThrough();
  validateStream.on('data', (chunk) => {
    receivedBytes += chunk.length;
    if (receivedBytes > MAX_TRANSACTION_IMAGE_SIZE_BYTES) {
      // this correctly aborts everything in a pipeline, and destroys the streams, but
      // the underlying streams still seem to hang
      cancelStream.abort(new PayloadTooLargeException('Image too large'));
    }
  });

  await pipeline(body, validateStream, file, {
    signal: cancelStream.signal,
  });
}

I have checked the code and I see that calling .destroy() on the returned write stream does not really result in anything being passed to the underlying emitStream or writeFileStream, so they stay hanging. Is this a bug on the SDK side? Is there a way to abort the upload request?

I have since tried to DELETE the resumable upload by crc32 when I destroy my write/validate streams but it also doesn't affect the underlying streams, so the handle stays open.

Not sure if this is the same behaviour I'm seeing or not.
I'm seeing streams aren't closing when using WebStream apis in Node.
To me, it feels like the same problem, the handler on the web stream side completes correctly, but the event is not emitted on the GCS lib side.
This has the effect of any means of closing the stream does not work... Either destroy or end... Neither actually closes the handle.

Here's a little example of what I mean.
I tested this on node v20.10.0 using ts-node.
import { join } from 'path';
import { createReadStream } from 'fs';
import { Writable, Readable } from 'stream'
import { TransformStream } from 'stream/web'

import { Storage } from '@google-cloud/storage'

const _sourcePathname = join(process.cwd(), 'test/people-2000000.csv');
const _storage = new Storage({ keyFilename: './secrets/gcp.json' });
const _bucket = _storage.bucket('journeywise_test_bucket');

const sourceFile = createReadStream(_sourcePathname, { encoding: 'utf-8' })
const _readable = Readable.toWeb(sourceFile);

const destinationFile = _bucket.file('output.csv');
const destinationStream = destinationFile.createWriteStream();
const _writable = Writable.toWeb(destinationStream);

const assertSize = (assertSize: number) => {
	let size = 0;
	return new TransformStream({
		transform(chunk, ctrl) {
			size += chunk.length;
			ctrl.enqueue(chunk);
		},
		flush() {
			console.log('Closed stream. Size match?', size == assertSize);
		}
	})
}

_readable
	.pipeThrough(assertSize(235121126))
	.pipeTo(_writable)
	.then(() => console.log('stream completed successfully'))

Apologies for my delay in getting to look at this. I have successfully recreated the problem and see what the issue is. I will work on a fix and update this issue accordingly.

I will get this merged and released after Cloud Next has finished.


Add optional x_jitter to dependence_plot

Optionally add random noise to feature values if feature has less than 20 unique values.  May increase plot readability when feature is non-continuous.
Attached example picture with noise set to 0.33.
Without the noise, most of the dots overlap, especially where X == 2.0

Thanks @ihopethiswillfi ! This looks good, we should name it x_jitter though since jitter is the name of this kind of noise and we are only adding it to the x-axis. The vectorization suggestions from @JacobMcc are great, you can also consider using np.unique.
One other thing, I am not sure about the limit on 20 unique values. It seems that we shouldn't assume a user doesn't want jitter for 30 values (especially if they make a wider plot). It is also a bit strange to turn on jitter only to have it turn off automatically. If at some point in the future we auto-detect categorical features then we could auto turn on jitter for those.
Once these changes are in I am happy to merge :)

@slundberg Agreed with everything there.

will rename to x_jitter
will remove arbitrary cap of 20.  I also wasn't sure about that either when committing it.  I originally thought I needed this to get what I wanted but I now found a way around it.  I can just detect the number of unique values of a feature before I call dependence_plot and base my jitter decision on that.

Thanks! The windows test fail has to do with an unrelated C++ VLA stack issue.
I have been thinking more about this, and since it happens for categorical data perhaps we should just add a flag denoting categorical data. With categorical="auto" by default. Then we could jitter automatically for small category counts. This would be similar to your 20 threshold, but it would also then enable us to do interesting things with the x jitter, such as doing non-uniform jitter to show the number of samples in each category (width of the jitter can be proportional to sample counts). This would simultaneously convey histogram information without adding mush visual complexity, since the width of the jitter would be the same as the height of a category histogram. Anyway, let me think about this a bit more before merging, because if we go with a categorical flag then that would change this api.


Releases page should link to AWS templates

The EarlyAccess box should link to: https://downloads.dcos.io/dcos/EarlyAccess/aws.html as well as the dcos_generate_config.sh it currently does

Should it link to Azure marketplace too?

Probably, although that doesn't get updated continuously / as we promote new builds to EarlyAccess

@cmaloney something we can do here? cc: @TimonVS

I think this probably needs to be designed first.
@ashenden: Got any ideas about how to show the AWS templates?
I'm not very excited about linking to that very engineering-y AWS templates page from the release page without going through the cloud install steps, but maybe you have an idea about how to do it?
/cc @pyronicide @mhausenblas

Good call @karlkfi.  We should mirror the behavior we use to have on the mesosphere.com site.  It looked like this (http://cl.ly/363x0l273h2b).
Where do we link to this page currently?

The only link to it is https://dcos.io/docs/1.7/administration/installing/cloud/aws/ (Step 2) AFAIK.
If we add a new way to get to the templates we'll need to update the install docs too.

Which install docs are you referencing?  Link?
Given this link lives in the docs, triggering a pop-up modal like the one in the video above is pretty unlikely.  We could, however, place a nicer version of this (https://downloads.dcos.io/dcos/EarlyAccess/aws.html) directly in the documentation.  How would this be maintained?

I linked to the install doc.
If you want something like the video you made it would have to be a part of dcos-website, and then the docs would just walk you through using it.
That list page is generated by the dcos release builder. If you want it nicer you'll have to update the release builder itself.

@ashenden the page source is: https://github.com/dcos/dcos/blob/master/gen/aws/templates/aws.html

@kevinkalle @TimonVS @davidvanleeuwen any ideas on how we could pull this off in a clean way?  Basically we have 3 options...

Update this page styling -- https://downloads.dcos.io/dcos/EarlyAccess/aws.html
Update the doc page referencing thing link in #1 (https://dcos.io/docs/1.7/administration/installing/cloud/aws/) to include all the content from the link in #1 in a nice styled table.
Create some sexy page/modal on dcos.io that functions like this (http://cl.ly/363x0l273h2b) and can be invoked from any docs link or direct/dedicated URL.

@ashenden I really like option 3. But I'm not really sure if it adds any value as opposed to option 2. Since we're putting it in the docs I think option 2 makes more sense.
But I'm interested to hear other opinions :).

The docs are rather verbose. I like the idea of a curated, "good UX" option 3, with verbose walkthrough docs that show how to use it for people that want their hand held.

I like option 3 as long as we can update it automatically. Maybe have it read from some JSON hosted on downloads.dcos.io?

I do like option 3. But I don't like having it in the docs to be honest. We could make a separate page for it if that makes sense?

Yeah, a separate page or a modal that lives globally on dcos.io and can be invoked from any page would be ideally.  What's most important is that we can link into the modal (and/or) page from anywhere.

@ashenden to get this straight, right now it's only for AWS, but in the future this may also include Azure, right? In that case I'd prefer a page because that's a lot of info for a modal.
In general I'd prefer a page because that'd make linking to it easier (linking to a modal is kind of a no-go for me).

Makes sense.  If we have azure, this would a different page with likely a different flow.  But for now AWS is the only platform we need templates for.  Can you guys work on putting this together?  I'd like to pull heavily from this direction (http://cl.ly/363x0l273h2b).  Rather than big messy table like this (https://downloads.dcos.io/dcos/EarlyAccess/aws.html), we have something a little more UX friendly.

Yes, I'll discuss with Martijn about the design today :).

Design:

When we add other services like Azure for example, we can add an segmented control on top of this page to switch between the different services. This allows us to have different flows for services without having a separate page for every service.

Sounds good.  Seems strange though to have this all in a box in the middle of the page.  What I'd rather us have is move the "DC/OS EA AWS CloudFormation" as the title of the page -- likely worded better.  The description could sit in the header or on page, and then page itself is tailored with the correct content.
If we have other platforms in the future, the pages and the instructions will probably be pretty different, so recycling this page probably won't happen.  Let's optimize just for AWS right now.

Would like it all to be above the fold on a laptop screen if possible.

Is that for the aws.html page or dcos.io page? If it's for aws.html I want to note that the page needs to be fully self contained and published by the release tools.
For the "release" page the bigger question is how does that look like as the extra buttons inside hte boxes on: https://dcos.io/releases/

@cmaloney we are suggesting a standalone page on dcos.io to replace this endpoint - https://downloads.dcos.io/dcos/EarlyAccess/aws.html.

That endpoint is going to continue existing (It is really, really useful from an engineering side).
To make a separate page on dcos.io we probably need to publish as part of the release some JSON data of where all the buttons should point? (If so this isn't going to be doable before 1.8)

Proposal...

Redirect that URL to something like dcos.io/install/aws
You and or someone else manually updates those links on dcos.io
(future) We work with Awkward (dev partners) to propose a simple JSON format you can expose to dcos.io to dynamically populate so you no longer have to manually do it.

Keep in mind, up until recently, these button links were hard-coded and manually maintained on mesosphere.com/amazon/setup

We create that page / set of buttons for every PR to dcos/image, they link to very specific artifacts which are critical for being able to develop / work on the AWS templates. It's not redirecting or going away. Most of the pages we build of that are not "published" releases.
I strongly believe that manually updating the page will result in things being forgotten or messed up. Currently the release process generates that page with the release, and has a strong guarantee everything inside of it is correct / matching up. Hand building all the links is very likely to go wrong.
for the individual channels there are the "Well known" urls which can be used which is what the mesosphere.com "Install AWS" page linked to. Those are the sort of button that really should just live in the release page. People who are looking to get the new CF template need the buttons / templates directly, not a tutorial.

Ok.  Work with me on this.  What I want is a better looking version of that page.  Creating it as a standalone page, requires standalone styles, and then that also becomes difficult to maintain.
Since you already generate that page dynamically, could you not generate a JSON blob manually that we tap into and render the content as desired on dcos.io?
Looking for solutions here that do not require us to build markup styling directly on https://downloads.dcos.io/dcos/EarlyAccess/aws.html

I agree on the better looking version. Just trying to note that there are elements of that page which are very engineering internal. Making it pretty but loosing critical functionality isn't a good idea.
Yes, we can definitely generate a JSON blob, that would land sometime in 1.8 which was my point with it earlier. It's not going to happen for 1.7-Open EA or GA (So the EarlyAccess and "stable" channels for this release cycle won't have it). It would be in the "master" branch sooner / whenever we land the code to make it.

Ok.  Let's have Awkward build out the page with a sample JSON blob.  We won't publish it, but can use it as an example of how it would look and how we'd need the JSON to be formatted.
Ultimately, I would hope to replace the page with this new page.  So, if we can work together to make that the goal, that would be ideal.

Eng wise every single time someone makes a PR to https://github.com/dcos/dcos that PR gets built and gets one of those aws.html pages which is critical to being able to test that PR inside of AWS. Those PRs shouldn't show up on dcos.io/releases (or separate / new pages inside of there). There is also some benefit to those not looking like "professional" / whole releases, since it is arbitrary development code submitted by third parties which hasn't necessarily been reviewed yet.

Thats fine, as long as the links for the version referenced in the docs is styled nice and references something stable.

@TimonVS: Do you need anything from me for this issue?

@ashenden Styling is ready. Could you provide me with the JSON blob?

@cmaloney: you wanna sketch out what the build.json metadata is gonna look like? We could just hardcode one for EA until it's auto-generated.

@cmaloney can you provide us with a time estimate so we can plan this one accordingly? Want to get most of this done this week.

https://github.com/dcos/dcos-website/issues/705


Added authorization.

GitHub Issue: (https://github.com/Islandora/documentation/issues/1447)
What does this Pull Request do?
FFMpeg had been failing on files that were not visible to anonymous viewers.  This adds token-based authentication.
What's new?
Not much.  I grabbed the token from the incoming request object and jammed it (© Danny Lamb  ) into ffmpeg as a header.
How should this be tested?
Create an Audio media in a non-open filesystem.  A service file should generate.  If there are any problems you'll see them in the homarus.log
Interested parties
@Islandora/8-x-committers @Natkeeran @dannylamb

@ajstanley So the 512 character limit is not an issue?

@whikloj -It doesn't seem to be.  The character limit came up in a discussion group, but I was unable to find any other reference to it.  This one works for me.

I'm concerned that this could lead to restricted-access content being leaked without some way of having the derivative media inherit the permissions of the source media/node. However, access management is still a relatively young area and we don't have consistent use-cases we can count on.
That said, I don't want to prevent sites from having this if they have addressed the issue locally. Could we add a setting in the config file to include authorization or not? E.g.
homarus:
  use_authorization_token: true