[SPARK-29162][SQL] Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))

What changes were proposed in this pull request?
Rewrite
NOT isnull(x)     -> isnotnull(x)
NOT isnotnull(x)  -> isnull(x)

Why are the changes needed?
Make LogicalPlan more readable and  useful for query canonicalization. Make same condition equal when judge query canonicalization equal
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Newly added UTs.

Can one of the admins verify this patch?

gentle ping @juliuszsompolski
I agree a lot that we should simplify these expression. It's really useful for judge query canonicalization equal. Meet this problem when I am doing some cache framework .

Can one of the admins verify this patch?

ok to test

Test build #111122 has started for PR 25878 at commit 9bf2d7c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16202/
Test PASSed.

Test build #111122 has finished for PR 25878 at commit 9bf2d7c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111122/
Test PASSed.

Test build #111131 has started for PR 25878 at commit a75c2ef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16210/
Test PASSed.

Test build #111133 has started for PR 25878 at commit cb9cef2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16212/
Test PASSed.

@AngersZhuuuu . Thank you for your contributions. I left two minor comments. Please address them.

@AngersZhuuuu . Thank you for your contributions. I left two minor comments. Please address them.

Thank you for your advise.  All for better job.

Test build #111131 has finished for PR 25878 at commit a75c2ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16221/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111131/
Test PASSed.

Test build #111142 has started for PR 25878 at commit f71698d.

Test build #111133 has finished for PR 25878 at commit cb9cef2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111133/
Test PASSed.

Test build #111142 has finished for PR 25878 at commit f71698d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111142/
Test FAILed.

@AngersZhuuuu . Thank you for your contributions. I left two minor comments. Please address them.

Can you trigger restart test. Thanks .

retest this please

Test build #111156 has started for PR 25878 at commit f71698d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16235/
Test PASSed.

Test build #111156 has finished for PR 25878 at commit f71698d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111156/
Test PASSed.


Adapted application to execute without external tomcat installation.

Applicable Issues
Today RemRem require external Tomcat instance.
Configuration is not as simple as it could be and it is not possible to test application locally.
Description of the Change
Adapt application so it is possible to execute it without external Tomcat.
Add possbility to configuret Spring from Java arguments and properties and take a application properties as input configuration.
This simplifies a lot the configuration of RemRem in a container environment.
STATUS:
Works:
- Executing Spring from war file works.
Executions examples:
java -jar service/target/generate-service-0.10.7.war --server.port=8037
env "server.port=8037" java -jar service/target/generate-service-0.10.7.war
- 'mvn spring-boot:run' works
Executions examples:
mvn spring-boot:run  -Dspring-boot.run.jvmArguments="-Dserver.port=8037"
- RemRem-genereat war file in TomCat installation with Java Spring properties works.
- RemRem-generate war file in TomCat installation with catalina.home properties works.
Provide the catalina.home property before start catalina.sh, e.g. 'catalina.home=/usr/local/tomcat' and property file should be placed at this path: /usr/local/tomcat/conf/config.properties
Sign-off

Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by:

Changelog md file updated. Stepped version in pom file.


[Prisma] Relation query function does not get context passed to it

According to the docs, if a function is provided to the query option of a relation it should receive both the field's arguments and the request context. As of @giraphql/plugin-prisma 0.1.10, this is not the case, as the arguments are passed correctly but request context is undefined (presumably as it is not passed in).
The following relation does not execute as ctx is undefined:
t.relation("classes", {
  query: (_args, ctx) => ({
    where: {
      teachers: {
        some: {
          id: ctx.user.id,
        },
      },
    },
  }),
})

@hayes Works in my application now, thanks for the fix

fixed should be released now


Show the "Synchronize Changes" button when in a single repository (Source Control)

It would be great to have the Synchronize Changes button alongside the Commit and Refresh buttons when in a folder with only 1 repository. Currently, the button shows only when there are 2 or more git repositories, like in the images below.
Only 1 repository:

More than 1 repository:

I use it a lot when pulling and pushing, and although it's not something absolutely needed, I think this should be easy to implement (because it already works where there are more than 1 source control repository, but I can't say for sure).
An alternative solution would be to make the Source Control View works the same way for a single repository as it works when there are multiple repositories (could be a setting, similar to scm.alwaysShowActions that shows actions that are applied to the repository files, like Discard All Changes and  Stage All Changes, but in this case a new setting to apply to the repository itself).

/duplicate
See https://github.com/microsoft/vscode/issues/102118#issuecomment-657592896


Terraform locals aren't evaluated in the payload by KICS

Here's an simple query which valide the existance of a bucket tag in a ressource aws_s3_bucket
package Cx

import data.generic.common as common_lib

CxPolicy[result] {
   resource := input.document[i].resource.aws_s3_bucket[name]

   not common_lib.valid_key(resource.tags, "bucket")

   result := {
      "documentId": input.document[i].id,
      "searchKey": sprintf("aws_s3_bucket[{{%s}}].tags.bucket", [name]),
      "issueType": "MissingAttribute",
      "keyExpectedValue": sprintf("aws_s3_bucket[%s].tags.bucket is set and not null", [name]),
      "keyActualValue": sprintf("aws_s3_bucket[%s].tags.bucket is missing or null", [name]),
   }
}

When I use a variable in Terraform, the payload computed by KICS contains an evaluated resource tags.
## file nagative3.tf

variable "tags" {
  type = map(string)
  default = {
    bucket = "kfc"
  }
}

resource "aws_s3_bucket" "negative2" {
  bucket = "kfc"

  tags = var.tags
}

{
	"document": [
		{
			"id": "f22a0590-a2e0-46fc-884f-d75ffdcd0834",
			"resource": {
				"aws_s3_bucket": {
					"negative2": {
						"bucket": "kfc",
						"tags": {
							"bucket": "kfc"
						}
					}
				}
			},
			"variable": {
				"tags": {
					"default": {
						"bucket": "kfc"
					},
					"type": "${map(string)}"
				}
			},
			"file": "/Users/jycamier/workspace/kics/custom_queries/check_s3_mandatory_tag/test/negative2.tf"
		}
	]
}

The Output
{
    "CxPolicy": []
}

However, it seams that terraform locals aren't interpreted by KICS for the payload
Here's an exemple with locals :
## file nagative2.tf

locals {
  tags = {
    bucket  = "kfc"
  }
}

resource "aws_s3_bucket" "negative2" {
  bucket = "kfc"

  tags = local.tags
}

The paylaod looks like that :
{
	"document": [
		{
			"id": "e8ba3469-38b6-4cf1-95f4-bf92ce4b0a44",
			"locals": {
				"tags": {
					"bucket": "kfc"
				}
			},
			"resource": {
				"aws_s3_bucket": {
					"negative2": {
						"bucket": "kfc",
						"tags": "${local.tags}"
					}
				}
			},
			"file": "/Users/jycamier/workspace/kics/custom_queries/check_s3_mandatory_tag/test/negative2.tf"
		}
	]
}

The output :
{
    "CxPolicy": [
        {
            "documentId": "023abda0-de0a-45c9-9594-b451dc51a1cf",
            "issueType": "MissingAttribute",
            "keyActualValue": "aws_s3_bucket[negative2].tags.bucket is missing or null",
            "keyExpectedValue": "aws_s3_bucket[negative2].tags.bucket is set and not null",
            "searchKey": "aws_s3_bucket[{{negative2}}].tags.bucket"
        }
    ]
}

Hi @jycamier, hope you are doing well.
Currently we don't support terraform locals due to it's parsing complexity, but we'll research it and check if it can be added in the future.

Hi @joaorufi
Thanks for your answer.
So, I hope to see this new feature very soon.

Hi ! Any updates on this ?


core:schema:warn Default value null does not match type string in component a-keyboard

Hi,
<a-entity a-keyboard id="keyboard" scale="4 4 5" position="0 0 -3"></a-entity>
I get below warning in firefox browser with aframe version 1.0.0
core:schema:warn Default value null does not match type string in component a-keyboard

Hello!
Thank you for reporting this issue, I'll look into it and see what I can do to fix it

The latest PR I merged should fix this warning, let me know if anything doesn't work out well

Great thanks, it works  :)


post use cases in the readme

I saw the repo and it looks interesting but I cant see a practical reason for its use.
Is it just to avoid dependency issues?

If you think of docker images as "universal server executables" it sorta makes sense. You can run the exact same "executable" regardless of the underlying operating system. But yeah, I would also like to see some actual use cases.

Yeah, good point it's not very clear why it is useful. It's particularly good for stuff with horrendous dependencies: https://mobile.twitter.com/bfirsh/status/824688876056895489


Serialize the object as an built-in type

Hi! I have a need to include a third-party class object in the model that needs to serialize as an integer. But I haven't found any examples of this in the documentation.
>>> class MyClass:
        some_var: some_type
        def some_method(self):
            return 123

>>> class Model(BaseModel):
        var: MyClass

>>> m = Model(var=MyClass())
>>> m.json()
{
    "var": 123
}

I think the Exporting models > JSON encoders section of the docs might be what you're looking for.

It is possible in V2 and here is a working example in V2:
from pydantic import BaseModel, ConfigDict, field_serializer

class MyClass:
    pass

class Model(BaseModel):
    var: MyClass

    @field_serializer('var')
    def serialize_var(self, _v , _info):
        return 123

    model_config = ConfigDict(arbitrary_types_allowed=True)

m = Model(var=MyClass())
print(m.model_dump_json())  # {"var":123}


Login Page

Login Page /Sign up

Currently in the process of finishing up the login page, will update soon

Login works! Next step is fixing app.js to change states after logging in!


fix for #1568

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Details are in #1568
What is the new behavior?
fixed.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

@marjan-georgiev can you please merge this? we can't use ngx-datatable with Angular Universal until this syntax/import error is fixed.

Merging. Thank you! 👍

H,
have you already scheduled a release date for this fix ? 🤘


Cusom formatter is used as file/directory extension

If you use custom report formatter like
<configuration>
  ...
  <format>com.some.Formatter</format>
  ...
</configuration>

It causes generated classes look like this:
@RunWith(Cucumber.class)
@CucumberOptions(
plugin = {"com.some.Formatter:target/cucumber-parallel/1.com.some.Formatter"},
public class Parallel01IT {
}

Could you please fork, and create a test to demonstrate the problem and expected behaviour

Closing as no test case provided


Update coding-style.md

Thanks, but the translations for coding-style.md is already available at /docs-translations/pt-BR/development/coding-style.md.


Merge pull request #2 from superadona119/main

Merge pull request #2 from goldtech119/main

Final commit


🐛 Handling of large anchor data of Gov Actions

Area
Voting Pillar
Domain
sanchogov.tools
Which wallet were you using?
N/A
Context
Handling large anchor data (validation and rendering) is problematic on GovTool, ranging from insufficient display to browser crashing.
Here are some test cases:

Test no
Name
GovTool Output
Comments
Action Id

1
Simple valid file
All OK
All OK
059fdaf7919525863f2e7625aaf959301e4e56176617ce7283435ee137c56e26#0

2
Out of context file
Data Formatted Incorrectly
Gov tool doesn't support invalid json that is outside of cips context
8b8fe0ff42c9718caa7a05441eed4e1d75274350a319575031302f1cc71e0107#0

3
Title greater than 80
Data Formatted Incorrectly
Expected but proper error could be shown to inform what was wrong
d3ad66dad758696180850f9f090138c9c35de3717fe337875b5f7de37349876e#0

4
Abstract greater than 2500
Data Formatted Incorrectly
Expected but proper error could be shown to inform what was wrong
4de5fbb44b6336298fd6ef7daf1a1ef75c47c532b0cd13a1e48c3aab86e1d701#0

5
100KB content rationale
Read/Parse OK but ->
Rationale text is truncated
2a76c7f9b35de7571528872fca4502656f006143863c5321c3801b28f8100d3b#0

6
1MB content rationale
Read/Parse OK but ->
Rationale text is truncated
8ac3d199f41eda85120d0d64b4ba02bf9b090a93e11193c66e86a871600409f8#0

7
10MB content rationale
Except rationale other fields are parsed
Clicking on view details and vote feel laggy. No text shown on rationale.
987ed32dd01b363ad3dad7d7b09556c70ddc143f1ad7c4b4afc95ade3628518b#0

8
100MB content rationale
Browser crahsed
Likely high memory usage
3ded0413648c1abb1e34cd03e1b545555069b78a02d4c33c7414b31da940717a#0

9
1GB content rationale
-

9da679f7e4c5a436025cb39cb655c23aede3afe623f04e8788624e93a009dbcc#0

Steps to reproduce

On sanchonet deployment, compose the governance_actions URL using the Action ID.
{BASE_URL}/connected/governance_actions/{ACTION ID}
For eg. case 2: 8b8fe0ff42c9718caa7a05441eed4e1d75274350a319575031302f1cc71e0107#0
Observe the rendering of the governance action on GovTool.
With the increasing content size, the loading of the page and responsiveness seems to diminish and finally crashes (browser).

Actual behavior

Missing proper error messages
Text truncation can be better
Browser crashes for large content

Expected behavior

Lazy loading or warning on large content processing on the frontend
Browser does not crash

We should add a metadata size limit to the CIPs, to prevent large bandwidth costs from pulling this data for governance tooling

This is handled by the validation service.


Custom 404 pages

if someone tries to access a URL which has not been published yet, display a custom error message (ie "this is a work in progress, check back soon for {{whatever that URL is supposed to display}}). This will be different from the default "404: Page Not Found."

Estimate: 100


CI testing

It would be good to get the test suite running on CI.
Is there a strong preference for platforms?

There's a pytest run already set up: https://github.com/PMBio/mudata/blob/master/.github/workflows/pythonpackage.yml.
Or did you mean something else?
I've now added a hook to run it on PRs too (135a935).

Great, just only saw linting run on my PR, will merge master


Events: Added event to emit when gas-less transaction is signed

As part of a project that I am working on, we want to show a different UI state when the transaction is signed vs when the transaction is pending signature.
I added EventEmitter to trigger an event that the consumer to listen to.

Looks great, thanks for the contribution @ximxim
Let us know when you're setup the constants file with the event keys. We'll want to make sure they're properly exported so folks outside the sdk can import them.
Looking forward to merging this, there are lots of spots we can emit events in the sdk.

@atbe updated the PR with event names extracted to its file and exposed to SDK consumers.

This is great @ximxim
One last request, if you don't mind. Could you emit an event when the biconomy request succeeds? We can emit the transaction hash that's returned from biconomy. The response text from biconomy looks like this:
{
  "code": 200,
  "message": "Meta transaction sent to blockchain",
  "txHash": "...",
  "flag": 200,
  "log": "Meta transaction sent to blockchain",
  "retryDuration": 158
}

Emitting the txHash property would be very valuable.


Support documentSymbol Highlight

As title

I'm afraid I don't understand what you mean; could you elaborate?
If possible, provide existing examples.

color schema (catppuccin) with symbol highlight

color schema (midnight) without symbol highlight

If it's just a search highlight, midnight.nvim already does this.

But I'm guessing that you have a plugin that highlights document symbols using LSP. Can you check and let me know? I probably did not add support for that plugin yet.
Could you execute :Inspect when the cursor is on a highlighted symbol (with catppuccin colorscheme enabled) and post the output here?

I use "vim-illuminate"
{
        "RRethy/vim-illuminate",
        event = "VeryLazy",
        config = function()
          require("utils.lsp").on_attach(function(client, _)
            require("illuminate").on_attach(client)
          end, { group = "_illuminate_attach", desc = "attach illuminate" })
        end,
 },

Inspect output when use catppuccin

Let me know if this adds the highlights you wanted. :)
Cheers ~


Brew: Update dependencies, upgrade deprecated APIs, fix lint

Description
In this pull request, I have:

Upgraded all dependencies to their latest versions
Updated the project template files (e.g., .gitignore, package.json, tsconfig) to the versions used by the current new extension template
Removed the eslintignore file as it is no longer necessary
Fixed the lint errors that arose after the dependencies were upgraded
Replaced the use of the deprecated accessoryTitle prop of List.Item with the recommended accessories prop

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

The only thing I noticed is that there are now deprecation warnings when running npm install

Yes, I noticed those too. These are all transitive dependencies of ESLint 8. ESLint 9 is now available, but @raycast/eslint-config does not yet work with it, so we can't get rid of these deprecation warnings just yet.


Decide how we measure the success of the initiative

We should specify some way of determining whether the use of Codespaces is an improvement.

Dependent on #8

New ticket created to measure Codespaces usage - #42.
Otherwise, I think we'll need to seek out feedback from copilots and researchers in a few months.


Help no calculation for SO2 in Python library

I already using CO, NO2 and work well. but the library not detect SO2. After checking inside the python library, I see no calculations for SO2 sensor.

Thanks for your feedback, it has now been added


Batch shape is too large than data

python eval.py rbpn --video --cuda --pretrain=..\RBPN_x4.pth -t RAW --save_dir dod --data_config G:\VideoSuperResolution-master\Tests\data\fake_datasets.yml

Test:   0%|                                                                                | 0/1 [00:00<?, ?it/s]Traceback (most recent call last):
  File "eval.py", line 118, in <module>
    main()
  File "eval.py", line 110, in main
    t.benchmark(ld, config)
  File "g:\videosuperresolution-master\VSR\Backend\Torch\Framework\Trainer.py", line 161, in benchmark
    for items in tqdm.tqdm(it, 'Test', ascii=True):
  File "E:\programs\WPy64-3680\python-3.6.8.amd64\lib\site-packages\tqdm\std.py", line 1104, in __iter__
    for obj in iterable:
  File "g:\videosuperresolution-master\VSR\DataLoader\Loader.py", line 124, in __next__
    hr4, lr4 = crop((hr3, lr3), shape=self.shape[1:]) if crop else (
  File "g:\videosuperresolution-master\VSR\DataLoader\Crop.py", line 19, in __call__
    return self.call(img_pair, shape)
  File "g:\videosuperresolution-master\VSR\DataLoader\Crop.py", line 29, in call
    raise ValueError("Batch shape is too large than data")
ValueError: Batch shape is too large than data
Test:   0%|                                                                                | 0/1 [00:15<?, ?it/s]

it's a yv12 file 720x480 60000/1001 fps


Surprising Time Spent on Running msvc-dev-cmd@v1 on windows-latest

I'm suddenly seeing repositories take over 4 minutes on running msvc-dev-cmd@v1, while just a couple days ago they were taking less than a minute. What variables could be causing the increased time? Is there something I can tweak? Does it have to do with changes to windows-latest? Thanks in advance for any insight.
Below is our yml file and the step that is becoming perversely long is "Setup Developer Command Prompt"
name: Build and Test

on:
  push

jobs:

  build-and-test-windows:
    name: Build and Test on Windows
    runs-on: windows-latest
    timeout-minutes: 5

    steps:
      - name: Setup Developer Command Prompt
        uses: ilammy/msvc-dev-cmd@v1
      - name: Check Out Source Code
        uses: actions/checkout@v2
      - name: nmake Build
        run: nmake
      - name: Run Executable
        run: .\assignment4.exe

  build-and-test-linux:
    name: Build and Test on Linux
    runs-on: ubuntu-latest
    timeout-minutes: 5

    steps:
      - name: Check Out Source Code
        uses: actions/checkout@v2
      - name: GNU make Build
        run: make
      - name: Run Executable
        run: ./assignment4

Hm... That's most likely due to v1 being updated to recently released v1.4.0. I am sorry, I did not notice the build time increase :disappointed: Indeed, it seems to take way more time than necessary, it's not clear why.
As a mitigation, I have reverted the v1 tag back to more stable v1.3.0 which it still fast. (That is, ilammy/msvc-dev-cmd@v1 should be fast now.) The v1.4.0 is also demoted to pre-release state, until the next version does something about the execution speed.

Thank you @ilammy. Appreciate the work you have done on msvc-dev-cmd and the quick response.

I can reproduce this issue. v1.3.0 used to take less than 10 seconds to complete (see any Windows job here: https://github.com/qbittorrent/qBittorrent/actions, for an example of this), while v1.4.0 consistently takes an additional 4 minutes. So for now v1.3.0 is definitely the one to use.

@davecom, @FranciscoPombal, I've just published v1.4.1 which should fix this issue. Could you please give it a try?
If that works for you, I'll bump v1 to that version.

@ilammy Thanks, that fixed it!

Alrighty. I've bumped v1 to the latest release. It seems that's it :tada:


[CWS] merge {Scalar,Pattern,Glob,Regexp}CaseInsensitive in StringCmpOpts

What does this PR do?
Those fields are all used differently, but shouldn't really have different values. This PR cleans this up by just using a simple CaseInsensitive.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


[feature] allow edit / reorder items / groups / subtasks

I often misstype my item... it's too bad we can't edit them
same for ordering, high priority on top, low on bottom, right now I manage to to this by marking them as done and undoo the marking... but this works only to make the item go up into the list...
subgrouping is also needed, when you have a "buy list" and you want to group them by location (supermarket, butcher....)
and when a task is too big, it could be nice to be able to split it....

You can edit the item by swiping it left.
Custom ordering will be implemented one day https://github.com/lolo-io/OneList/issues/32
Subgoups wont be implemented.
Splitting a list won't be implemented.
This is a minimalistic ilst app. Lots of users like it for its simplicity. I won't add a lot of overwhelming features.


Remove persistence from Redis on docker-compose

This is not needed, caching redis does not need to be persistent and spend time recording to disk

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.092%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5748

Relevant Lines:
6525

💛  - Coveralls

You are right, I will close this PR


I'm not sure why I added those periods to be real though.

About this PR: I prefer to keep current API for Capture#initialize to not break compatibility.
But, a default value for iface parameter may be set. New definition will be:
def initialize(iface=Pcap.lookupdev, options={})
end

May this proposal reply to #34?

I think that makes a lot of sense. 👍

Finally, iface as an option is a really good idea. I will try to implement it while being compatible with previous API:
def initialize(iface_or_options={}, options={})
end

with iface_or_options being or a String (interface name) or a Hash (option hash). If first arg is a String, second arg is used as option hash.


Adding useful API

An useful API to third party

Done :+1:
GET all records of daily average data from a location
Retrieve all records from a location called Burjassot
http://[serverIP]:[PORT]/days/find?Locations=Burjassot
http://<IP_ADDRESS>:1337/days/find?Locations=Burjassot
$ curl -i -H "Accept: application/json" "<IP_ADDRESS>:1337/days/find?Locations=Burjassot"
GET daily average data from a location and certain date
Retrieve all data from a location called Burjassot certain on fiveteen of Agoust 2003
http://[serverIP]:[PORT]/days/find?Locations=Burjassot&Date(dd-mm-yyyy)=15:07:2003
http://<IP_ADDRESS>:1337/days/find?Locations=Burjassot&Date(dd-mm-yyyy)=16:04:2013
$ curl -i -H "Accept: application/json" "<IP_ADDRESS>:1337/days/find?Locations=Burjassot&Date(dd-mm-yyyy)=16:04:2013"
GET daily average data from all locations and certain day
Retrieve all data from all locations on fiveteen of Agoust 2003
http://[serverIP]:[PORT]/days/find?Date(dd-mm-yyyy)=15:07:2003
http://<IP_ADDRESS>:1337/days/find?Date(dd-mm-yyyy)=15:07:2003
$ curl -i -H "Accept: application/json" "<IP_ADDRESS>:1337/days/find?Date(dd-mm-yyyy)=15:07:2003"
GET daily average data from all locations with more than certain elevation
Retrieve all data from points with elevation >= 1000 meters
http://[serverIP]:[PORT]/days?where={"elev":{">=":1000}}
http://<IP_ADDRESS>:1337/days?where={"elev":{">=":1000}}
$ curl -g -i -H "Accept: application/json" '<IP_ADDRESS>:1337/days?where={"elev":{">=":1000}}'
GET daily average data from all locations with more than certain elevation and certain day
Retrieve all data from points with elevation >= 1000 meters on fiveteen of Agoust 2003
http://[serverIP]:[PORT]/days?where={"Date(dd-mm-yyyy)":"15:07:2003","elev":{">=":1000}}
http://<IP_ADDRESS>:1337/days?where={"Date(dd-mm-yyyy)":"15:07:2003","elev":{">=":1000}}
$ curl -g -i -H "Accept: application/json" '<IP_ADDRESS>:1337/days?where={"Date(dd-mm-yyyy)":"15:07:2003","elev":{">=":1000}}'
GET daily average data when Water(cm) variable is equal or greater than certain value
Retrieve all data when Water(cm) variable is equal or greater than 2.5 cm
http://[serverIP]:[PORT]/days?where={"Water(cm)":{">=":2.5}}
http://<IP_ADDRESS>:1337/days?where={"Water(cm)":{">=":2.5}}
$ curl -g -i -H "Accept: application/json" '<IP_ADDRESS>:1337/days?where={"Water(cm)":{">=":2.5}}'


Updated the demo css and implemented the editor panel

Updated the code editor number logic, its styling and repair some of the demo styling

looks good bro


Windows: OKTA_PROFILE not respected, always have to pass --profile

Describe the bug

Even though OKTA_PROFILE is set before the initial call to AWS, it doesn't seem to be used when creating the profile.
Further calls to okta-aws always require the profile to be passed in and OKTA_PROFILE is not read. Leading to weird issue when you forget to pass it in.

Example: okta-aws s3 ls will create a new profile named s3 and return an error because 'ls' is not an appropriate command

To Reproduce
Steps to reproduce the behavior:

Run the PowerShell bootstrapper on a fresh install
Modify config.properties to include OKTA_PROFILE
? What do we type to initiate the session with the default profile name we specified in #2? Or a derived one?
Making any call to okta-aws will require a profile passed in as the first parameter

Expected behavior

It's not clear how to make the tool just use a default credential, even with just one credential created, the tool requires you to pass it in as the first argument for every single call: okta-aws default s3 ls works, but okta-aws s3 ls does not. Ironically, after you are authenticated and the cookie is set, straight up aws s3 ls works fine.
The documentation is not clear here, and there is a hodgepodge instructions with the new way to use the tool okta-aws and the old way, which required a batch script in your PATH awscli. This should be cleaned up and any references to the old way should be removed.
If a profile needed to be derived, it would probably be easiest to just default to the last segment of the roleArn:

arn:aws:iam::160639289719:role/Test-Developer
becomes
Test-Developer

Additional context
I love this tool. I absolutely love it, it's just very difficult to get it set up and the settings don't work like they are described. If a PR is needed, let me know.

Thank you for reporting this.
There are definitely gaps in the docs, particularly around the renaming of commands from the previous versions.
I’ll take a deeper look at this and help get past this.
If you already have specific changes to the docs to recommend, a PR is definitely welcome :)

It's not clear how to make the tool just use a default credential, even with just one credential created, the tool requires you to pass it in as the first argument for every single call: okta-aws default s3 ls works, but okta-aws s3 ls does not. Ironically, after you are authenticated and the cookie is set, straight up aws s3 ls works fine.

You can use the default profile as follows:
okta-aws default s3 ls

okta-aws s3 ls won't work as it would be creating a profile named s3 and then try to run aws --profile s3 ls under the hood. That's why you get that error message.
It works like this:
General usage:
okta-aws profile-name aws-cli-subcommand

Example of listing all S3 buckets:
okta-aws test s3 ls

Subsequent calls to okta-aws with the same profile name should use cached AWS credentials (unless OKTA_ENV_MODE is set to true).
The first of these should prompt for Okta credentials, the others should just run:
okta-aws test s3 ls
okta-aws test s3 ls
okta-aws test s3 ls

The documentation is not clear here, and there is a hodgepodge instructions with the new way to use the tool okta-aws and the old way, which required a batch script in your PATH awscli. This should be cleaned up and any references to the old way should be removed.

I'm not sure where awscli usage is still documented/referenced. Can you point me to where you seeing that? I'd like to remove it.

If a profile needed to be derived, it would probably be easiest to just default to the last segment of the roleArn:
The awscli command will still work if you have the script. It will generate predictable profile names if you don't supply OKTA_PROFILE:
Example:

awscli s3 ls

In general, arn:aws:iam::AccountNumber:role/RoleName becomes RoleName_AccountNumber.
It will turn arn:aws:iam::160639289719:role/Test-Developer into Test-Developer_160639289719.

It's not clear how to make the tool just use a default credential, even with just one credential created, the tool requires you to pass it in as the first argument for every single call: okta-aws default s3 ls works, but okta-aws s3 ls does not. Ironically, after you are authenticated and the cookie is set, straight up aws s3 ls works fine.

You can use the default profile as follows:
okta-aws default s3 ls

I know how to set the default credential, but if I still have to name it for every subsequent call, it's not a default, it's just another profile. Is this just a situation where the new way of doing things (okta-aws) doesn't look at OKTA_PROFILE but the old way (awscli) did?

The documentation is not clear here, and there is a hodgepodge instructions with the new way to use the tool okta-aws and the old way, which required a batch script in your PATH awscli. This should be cleaned up and any references to the old way should be removed.

I'm not sure where awscli usage is still documented/referenced. Can you point me to where you seeing that? I'd like to remove it.

It's not directly referred to in the latest readme, but in the manual install section of the readme, there is bit about copying the \bin folder to somewhere in your path. As far as I can tell, nothing in the bin folder is needed to make this work anymore because okta-aws and withokta are now loaded into the PowerShell or Bash profiles as user functions and don't need to be separate bat/sh scripts.

Copy scripts from .okta/bin to somewhere on your PATH.

If a profile needed to be derived, it would probably be easiest to just default to the last segment of the roleArn:
The awscli command will still work if you have the script. It will generate predictable profile names if you don't supply OKTA_PROFILE:
Example:

awscli s3 ls

In general, arn:aws:iam::AccountNumber:role/RoleName becomes RoleName_AccountNumber.
It will turn arn:aws:iam::160639289719:role/Test-Developer into Test-Developer_160639289719.

That's how I would expect it to work, but why doesn't aws-okta work the same way?
Maybe I am misunderstanding the entire idea of this project. Is the intended usage to use okta-aws profilename s3 ls to create the session, then use the AWS SDK directly aws s3 ls for subseqent calls. Or should all AWS CLI calls go through okta-aws?

okta-aws is intended to be used with an explicit profile name every time it is called. The way it is written makes it very difficult to omit the profile name from the call.
Now that I've seen more use cases, I realize that isn't the best fit for everyone. It isn't the best fit for things I do myself anymore.
I actually use a config like this in ~/.config/fish.config:
function okta-fish
    set -x OKTA_ENV_MODE true
    java -Djava.net.useSystemProxies=true  -classpath ~/.okta/okta-aws-cli.jar com.okta.tools.WithOkta "fish" $argv
end

For bash, this should work:
function okta-bash {
    export OKTA_ENV_MODE=true
    java -Djava.net.useSystemProxies=true -classpath ~/.okta/okta-aws-cli.jar com.okta.tools.WithOkta "bash" $@
}

For PowerShell, this should work:
function Okta-New-Session {
    Write-Host $args
    $OriginalOKTA_ENV_MODE = $env:OKTA_ENV_MODE
    try {
        $env:OKTA_ENV_MODE = $True
        $InternetOptions = Get-ItemProperty -Path "HKCU:\Software\Microsoft\Windows\CurrentVersion\Internet Settings"
        if ($InternetOptions.ProxyServer) {
            ($ProxyHost, $ProxyPort) = $InternetOptions.ProxyServer.Split(":")
        }
        if ($InternetOptions.ProxyOverride) {
            $NonProxyHosts = [System.String]::Join("|", ($InternetOptions.ProxyOverride.Replace("<local>", "").Split(";") | Where-Object {$_}))
        } else {
            $NonProxyHosts = ""
        }
        java "-Dhttp.proxyHost=$ProxyHost" "-Dhttp.proxyPort=$ProxyPort" "-Dhttps.proxyHost=$ProxyHost" "-Dhttps.proxyPort=$ProxyPort" "-Dhttp.nonProxyHosts=$NonProxyHosts" -classpath $HOME\.okta\* com.okta.tools.WithOkta powershell @args
    } finally {
        $env:OKTA_ENV_MODE = $OriginalOKTA_ENV_MODE
    }
}

I run okta-fish and it prompts me for Okta credentials (unless I have a session) and then prompts me for an AWS Role each time (unless I set OKTA_AWS_ROLE_TO_ASSUME)
It lets me bring up a fish shell with temporary credentials as environment variables that I can use as long as the shell is running and the session has not expired.

There is another option.
Run okta-aws default sts get-caller-identity to set up stored credentials for the default role and print out what role that is.
Run aws s3 ls or other AWS CLI commands to use the default role as stored.

I use the last option - I have a okta-aws being called from a bat file on my desktop - I double click and it sets "default" - then I can launch powershell aws tools or cli (on a windows machine). I also found it useful to do this for each AWS account I connect to - as I run ElasticBeanstalk (EB CLI) for one account a lot - this method allows me to set the EB CLI profile when I run the EB bat file - and then run EB as normal. Took a little to get set up, but now that it's working - I have several others using this method at my org as well.

There is another option.
Run okta-aws default sts get-caller-identity to set up stored credentials for the default profile and print out what role that is.
Run aws s3 ls or other AWS CLI commands to use the default role as stored.

This is what I'm doing. If that is the intended behavior, perhaps the documentation should reflect it as an alternative use case in 'Usage'

I use the last option - I have a okta-aws being called from a bat file on my desktop - I double click and it sets "default" - then I can launch powershell aws tools or cli (on a windows machine). I also found it useful to do this for each AWS account I connect to - as I run ElasticBeanstalk (EB CLI) for one account a lot - this method allows me to set the EB CLI profile when I run the EB bat file - and then run EB as normal. Took a little to get set up, but now that it's working - I have several others using this method at my org as well.

I would love to know how you got EB CLI working with this? i am facing a similar issue


Unable to get RHL3 to work

Hello,
I'm trying to upgrade this boilerplate to use Webpack2 and RHL3. Webpack2 is pretty stable now and babel-preset-react-hmr is no longer maintained. I was able to get Webpack2 up and running but failed to make RHL3 work. I keep getting this:

If anyone has successfully intergrated RHL3 with this boilerplate, it would be greatly appreciated if you can share some tips!

Ah! Found the culprit. Decorated components cannot be hot-loaded. See 279


Import router-data redirects for browse pages and topics

Now that we can model these here it makes sense to do so and reduce the volume of redirects in router-data.
This PR also adds a uniqueness constraint to the Redirects table to help avoid duplicates.

This should be reviewed alongside https://github.gds/gds/router-data/pull/450.
Additionally https://github.gds/gds/router-data/pull/444 also removed some redirects that are included here.


[confcom] adding stopsignal, refactoring tests

Adding stopsignal feature from docker, refactoring tests so they are easier to maintain, and pinning dependency versions. Also changing default value for allow_properties_access in policies.
This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

confcom

/azp run


no data in "INSERT/UPDATE/DELETE Traffic" graph

Hello,
I have a problem with the "Insert/Update/Remove Traffic" graph. There is no data as you can see in the image below.
Maybe the problem is in the rendering of the graph, as pgbadger seems to detect the queries (56 queries/sec peak).
I use CloudSQL. I generate reports with this command line :
pgbadger -f jsonlog -o pgbadger_report.html 05/*

Thank you.

Is it related to #590 ?

Yes :) Now, it's working for all others graphs, except this particular graph.

Commit cd05708 fixes the "General Activity" report where READ/WRITE queries count/duration was not reported.
About the "INSERT/UPDATE/DELETE Traffic" graph I think this is normal, this graph unlike the previous in this page, doesn't report the min/max/mean of the write queries but the average per 5 minutes. If they are all at 0 this is because the ratio queries/300s is near or equal to 0.


Optionally show just Sunrise or Sunset or both in Sunrisesunset

This change adds the ability to optionally show just the sunset, or just the sunrise, or both.
When both are selected, the widget renders as it did before. When only 1 is selected, the data is rendered along with a title.
/cc @alan-fleming @betterengineering
Both

Sunrise

Sunset

None

I have read the CLA Document and I hereby sign the CLA

🤔 I can't quite make out what the linter does not like. Is there a linter I should run against changes locally?

did you run make lint on your computer?

Seems to be a format issue on sunrisesunset.go? I'm unclear about this, as this file was not changed.
apps/sunrisesunset/sunrisesunset.go:1:3: syntax error near //
apps/sunrisesunset/sunrisesunset.go # reformat

but did you run make lint on your computer? That formats the lint file. I'm guessing it's mad about some spacing somewhere.
If you run it on your computer it should tell you where the error is.  I think you just need to run make lint and if there are no formatting errors and what not you'll see it return buildifier -r ./ and then you just need to recommit.
Because you are right as you said you didn't change that file, but you have to run make lint to get the lint request to pass.

Ah! When running it, it didn't return anything. So I thought it wasn't detecting any issues. I see now that it re-formatted for me. Thanks!

No problem, yeah make lint just formats the .star file and stuff (not the lint file like in my previous comment), glad it worked!


Support new team names

Fixes #462

@cwendt94 any change we could get this reviewed/merged before the start of the NFL season?

Yeah, I will have this in and publish changes today! Thanks for fixing this @dtcarls

@dtcarls @mkirby528 This fix should now be in version 0.31.0 pip install espn-api==0.31.0

Wonderful! Thank you both so much!


Make tests runnable in parallel

To debug and fix flaky tests, it useful to run them many times in parallel (using stress usually). However, some tests break down when doing this.
This issue tracks updating all of our unit tests to support this

Known broken:

TestADSC_Run
TestADSC_Save
TestStartEnvoyShouldSucceed
TestStartTwiceShouldDoNothing
TestHotRestart
TestCommandLineArgs
TestShutdown
TestKillEnvoy
TestCancelContext
TestConfigDump
TestXdsProxyHealthCheck
TestWorkloadHealthChecker_PerformApplicationHealthCheck

Known broken:

TestADSC_Run
TestADSC_Save
TestStartEnvoyShouldSucceed
TestStartTwiceShouldDoNothing
TestHotRestart
TestCommandLineArgs
TestShutdown
TestKillEnvoy
TestCancelContext
TestConfigDump
TestXdsProxyHealthCheck
TestWorkloadHealthChecker_PerformApplicationHealthCheck

/assign

/assign

not stale

not stale, but also not high priority


Descriptive error messages

PR Description:
Hey team, quick update on the changes for the Descriptive error messages task. I've updated consentErrors them from a string array to an array of objects with name and label properties. This should give users clearer directions on which fields have issues. It might be worth letting our clients know about this update, especially those using custom registration fields.
I've noticed that some consents without labels weren't showing errors. I'm thinking of fixing this by adding generic error messages based on the consent type. For example, a 'select' field would get a "Please select an option" message, and a 'checkbox' would get "Please check this box," etc.
Also, I've tweaked the renderInput function to include aria-attributes like aria-invalid, aria-describedby, and aria-required. Aimed for something descriptive yet not too repetitive. Plus, the HelperText component now accurately points to the related input/select/checkbox fields for error state reflections.
Todo:

[x] Fix failing tests
[x] Check if the dom reflects the input state when the field is invalid.

There's a heads-up: this PR might clash with another task I'm on. I suggest we merge this into the feat/a11y-form-error-announcements-enhancement-for-screen-readers branch, sort out any conflicts there, and then move it all into feat/a11y-sprint-2.
That's about it. Thanks!

I think you need to rebase this branch on the target branch.

Only the snapshots need to be updated :-)

Mergy, mergy


Write Lesson, Module and Task Builders + testcases

Codecov Report

Merging #250 into master will increase coverage by 0.47%.
The diff coverage is 60.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6e1bd...b9ae0ab. Read the comment docs.

Hi @simonteozw . Actually this PR is kinda simple and there is not much to review, yet I still request your review so that you can know about the newly added test skeleton! Thank you!


Support in stac-pydantic

There may be some confusion about links and the STAC spec?
https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/issues/247
https://github.com/stac-utils/stac-pydantic/pull/144

I don't understand the issue?! This is an extension and has no relation to stac-pydantic. Maybe open an issue in their repository? If I misunderstood, please comment with a clarification what the purpose of the issue is. Thanks.


False return

Try the example. It seems the status is always "success" even when the api never sends email out.  For example, when the email address is false. From the sendinBlue dashboard, the request is never made even the status="success"
client.send_email(data).on('complete', function(msg) {
	var obj=JSON.parse(msg);
	console.log(obj);

	var status=obj.code;
	if (obj.code='success') {
		console.log('send message successfully');

	}
	else console.log('message was not sent');

	//return cb();

});

As part of the sendinblue API version 2 deprecation plan this repository is no longer supported. Please refer to its updated version 3: https://github.com/sendinblue/APIv3-nodejs-library


SoundCloud throws warning when reloading

SoundCloud.js:93 throws this warning when reloading page:
Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the SoundCloud component.
The code used is here: https://github.com/belongapp/belong/commit/3897f6c9d97213a60f170026101816c71dfae51b

Yeah I have noticed this but not pushed my fix up yet, as there are quite a lot of updates to come. Good spot though!


Changing travis yml to remove push stage

This may allow PRs from external collaborators to go through. Tagging @edawson and @sameerd for interest

This should help pass the checks hopefully! Should I wait till you push this to master? or should I generate a PR off the remove_push_stage branch?

Let's hold off until this is merged into master so that we don't create duplicate PRs. Thanks!


Add new state for water heater

I have a water heater with 2 tanker, but several information are not raised to Home Assistant.
This pull request add sereval missing states, based on these diagnostics information:
water_heater_diag.json.txt

Hi, thx you for your contribution 👌
I can see we have an issue with our checks. That's not related to your PR.
@iMicknl that's OK for you too?


Cherry-pick "Respect OS for performance test history and flakiness handling"

Cherry-pick of #28039

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.


balances are not populated after genesisBuilder

Describe the bug
Running Gnosis Beacon Chain and building the state from genesis the resulting state was incorrect because state.balances was empty. Apparently pushing to state.balanceList the changes are not propagated to state.balances. May they refer to different trees?
Expected behavior
Populate
Steps to Reproduce

Run Gnosis Beacon Chain from Genesis, guide to TBD

or

In a unit test, create an empty CachedBeaconState
push to state.balanceList and
query state.balances

@dapplion can you look into PR #3602, there should be some different setup to reproduce the issue?

genesisBuilder code has been refactored since this issue


Loot capacitors can be combined to produce insane amounts of power in a Stirling Generator

Issue Description:
When combining the capacitors found in loot chests it is possible to get obscene values for the Stirling Generator power gen, which results in the generator producing large amounts of RF (millions to billions). This is possible even with very few capacitors (4-5), as long as they have the correct distribution of lows and highs.
What happens:
Loot capacitors explode in terms of Stirling Power Gen value, growing much faster than any of the combined capacitors value.
What you expected to happen:
Loot capacitors can be combined to create capacitors which are roughly as good as the two it was made of combined.
Steps to reproduce:

Spawn 3 capacitors using the following command:
/give <playerName> enderio:itemBasicCapacitor 3 3 {eiocap:{level:2,stirling_power_gen:3f}}
Spawn 1 capacitor using the following command:
/give <playerName> enderio:itemBasicCapacitor 1 3 {eiocap:{level:2,stirling_power_gen:0.1f}}
Combine one of the first capacitors with the second in an anvil.
Combine the result with one of the first until all capacitors have been combined into one.
Put the capacitor in a Stirling Generator and watch it produces immense amounts of power

Affected Versions:

EnderIO: 1.10.2-3.1.193
EnderCore: 1.10.2-<IP_ADDRESS>-beta
Minecraft: 1.10.2
Forge: <IP_ADDRESS>6

Your most recent log file where the issue was present:
https://hastebin.com/opiluhiwaj.sql
Note: This issue is much easier to replicate when using a mod to view the info of the loot capacitors. Therefore AnalyzeIO was also included in the world, though it does not seem to actually cause the issue.

Ok, what was happening here is that combining 2 caps that have the same key should give you a value for that key that was between "better value - difference (but at least worse value)" and "better value + difference (but no more than 4.75)" with a gaussian distribution centred on "better value". However, it gave you "better value + difference (but at least worse value)" in the "it gets lower" case---which is a higher number with no limit on its size.
Or in other words: The distribution is made by 2 half-bells because the bells' centre is is not in the middle between min and max. Those bells are cut off at the min and max. But the lower half-bell was inverted---before it was cut off.

Just curious, but did the tags change from 1.10 to 1.12?  Just wondering about that give command and how it'd work for spawner speedup.

What part of the spawner?

Powered spawner spawn rate.  Like, how fast it spawns.

That would be energy used. More energy used the faster it spawns. You can do that with a generic capacitor level or the specific..

Yes, the tags changed. I remembered making it so it still recognized the old ones, but I'm not sure if that is still the case.
Adding a parameter for the efficiency (energy per spawning) may be a good idea. I'll have a look at the code and think about it further next week.

PS: Please don't necro bug reports, we have a perfectly fine Discord for asking questions ;)


Added the missing "to" to fix issue.

Pre-Submission Checklist

[*] Your pull request targets the staging branch of freeCodeCamp.
[*] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[*] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

NOTE: I wasn't able to check off this last box because I did the change on-line rather than on my computer. For the record, the only change made to the file was the addition of one word of text in an area that contains text. I didn't change any JavaScript or other code.
Type of Change

[*] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[*] Closes currently open issue (replace XXXX with an issue no): Closes #14403

Description

Added "to" to the sentence in question in issue 14403.

@Ellyria Tested locally and LGTM. Congratulations on making your first contribution to freeCodeCamp! 👍 💯 🎉

Yay, thanks to everyone for all the help!

When does the fix show up? If I go to the https://www.freecodecamp.com/challenges/comparison-with-the-less-than-or-equal-to-operator page, it's still the way it was. Do these bug fixes go to a future version that won't go live until later?

@Ellyria the beta site is updated every couple of weeks based on the newly merged PRs. It will be there eventually.


Added more comprehensive docstrings to values, using helm-docs tool

Added extra descriptions in the helm documentation for the values.yaml file. Auto generated a README in the helm repository containing this information in a table.
Perhaps we should setup a CI job to do this, as part of this PR? I think this should also be done for the nexus-filewriting-service.

Note: on github currently the README looks a little squished and I'm not sure the best way of fixing this... https://github.com/DiamondLightSource/blueapi/tree/helm-docs/helm/blueapi

For a lot of these, it may be worth re-running helm create and seeing what comments are present, stick with what is readily available if sufficient and not roll our own.


Stats logging may break clustering

If the name of the area is too long, the stats output in server/algorithms/src/stats.rs#L77 throws an exception due to an integer underflow, and kills returning the clustering results.

...how long of a name are we talking here?

I guess it's something in the range of 55 characters? The problem is that WIDTH[..(WIDTH.len() - text.len())] at
server/algorithms/src/stats.rs#L66 will underflow if text.len() is greater than WIDTH.len(). Since it's a unsigned 64 bit value, it causes an index out of bounds panic at 2^64.


Use secrets for username and password in docs

Hey!
Thanks for your work on this custom component!
This is a small PR that changes readme - instead of hardcoding username and password in config we suggest to use secrets.yml instead ;)

Thanks, Pawel. I haven't done it this way, because I think everybody should know about.


Sort order on custom fields out of order

I'm not entirely sure if this is a bug, or me simply missing the point!
I've added a couple of custom fields, exported from KiCAD V6's netlist - and whilst they show just fine in the HTML output, clicking the column header to sort by Ascending or Descending does not seem to actually sort the data.
For example, I have a custom field "Place Sequence" used to sort the BOM in order of component placement, where a defined pattern of placement is desired.

If I sorted ascending, I get 9, 10, 130 165 and on....
Descending gives 99, 98, 97, 96, 95, 94, 93, 92, 91, 90, 9, 89, 88 (but note, the BOM contains entries 250+, so it's starting in the wrong place too).
KiCAD 6.0.5, Windows 10, plug in installed today (30/06/22).

Adding to this, columns containing alphabetical characters only appear to sort correctly, as does the numerical quantity column generated by KiCAD.

It works as expected, the data is compared as strings, in lexicographical order.
You should pad your single and double digit numbers with zeroes and then it will work as you want, i.e. 001 002 003 etc.

Great, thanks. This worked as you say and allowed me to sort by desired build order.
I must say, this tool is absolutely fantastic. I assembled 1x complex SMD board with ~450 parts, that I built 2x a year ago or so, and brought the assembly time down from 5 hours to 2 hours using this, it's fantastic. Your decision to open-source this is greatly appreciated, and will lead me to make another donation to KiCAD given I see you don't take donations directly.
However, I do think with this sorting - it would make more sense from a user point of view if padding was not required - simply because whilst sorting in lexicographical order is technically expected behaviour, it is not typically expected behaviour from an end user point of view - especially when there is a quantity column next to it, which you can sort in numerical order without padding zeros.

Glad you like this tool.
I agree that this can be unexpected for end user. The difference between quantity and custom fields is quantity is known to be an integer and can be treated as such while custom fields can be anything. And more often than not they are not plain numbers.
Still, I could check if the whole column can be parsed as integers and then convert them, it's a nice addition.

Fixed in 2f38736, you shouldn't have to pad with zeros anymore.
If you want to get this fix before next version is released make sure to download latest from github and remove the plugin from the plugin manager, they can't coexist.


Bug: When add or modifying permissions, an exception will be thrown

I tested two docker image casbin/casdoor-all-in-one:latest and casbin/casdoor:latest
Same problem with both images.

Add new organization
Add new application
Add new user
Add new model
Add new role
Add new permission with new Adapter named 'jike_rule'
Throw this exception:

casdoor:runtime error: invalid memory address or nil pointer dereference
Request Method:	POST
Request URL:	/api/update-permission?id=organization_jk/get-orders
RemoteAddr:	<IP_ADDRESS>
Stack
/usr/local/go/src/runtime/panic.go:1038
/usr/local/go/src/runtime/panic.go:221
/usr/local/go/src/runtime/signal_unix.go:735
/go/pkg/mod/github.com/casbin/casbin/v2@v2.30.1/model/policy.go:130
/go/pkg/mod/github.com/casbin/casbin/v2@v2.30.1/model/policy.go:137
/go/pkg/mod/github.com/casbin/casbin/v2@v2.30.1/internal_api.go:233
/go/pkg/mod/github.com/casbin/casbin/v2@v2.30.1/management_api.go:314
/go/pkg/mod/github.com/casbin/casbin/v2@v2.30.1/management_api.go:286
/go/src/casdoor/object/permission_enforcer.go:143
/go/src/casdoor/object/permission.go:127
/go/src/casdoor/controllers/permission.go:100
/usr/local/go/src/reflect/value.go:543
/usr/local/go/src/reflect/value.go:339
/go/pkg/mod/github.com/beego/beego@v1.12.11/router.go:897
/usr/local/go/src/net/http/server.go:2879
/usr/local/go/src/net/http/server.go:1930
/usr/local/go/src/runtime/asm_amd64.s:1581
beego 1.12.3 (beego framework)

golang version: go1.17.5

docker ENV:
dataSourceName	user=aaa_dev password=aaa_dev host=<IP_ADDRESS> port=5432 sslmode=disable dbname=JiKeDev_Auth
dbName
driverName	postgres
PATH	/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
runmode	dev

@forestmgy

I suppose that you use an incorrect model definition. You can read docs, there are many model definition examples, this may works fine. But you can explore more

@forestmgy Thank you.
It would be better if no exception was thrown, but with specific error content


Trying to fix live branch

Docs Build status updates of commit 3a182f5:
:warning: Validation status: warnings
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update Kubernetes clusters to v1.4.7

Update static and self-hosted Kubernetes clusters to v1.4.7
Start bootkube start via systemctl, don't require a persistent SSH connection during the script run
Combine rktnetes Ignition into Kubernetes static cluster (just set the container_runtime metadata to docker or rkt)

note: Still requires this bootkube patch (updated) to allow DNS node names has been updated.

Static and self-hosted Kubernetes examples running happily in lab. https://github.com/dghubble/metal/commit/08216c0929ef62c087bb262c0641c01c7c91a885


Rename params to opts

In some places we were using opts and in other params.
I've normalize it to opts everywhere. No code changes

Coverage remained the same at 100.0% when pulling 6d2e073a549fb73a77480b5078c2c594ee574aac on juanjoDiaz:rename_params_to_opts into fb7ad5390c471eda3263fd9f1954e0cc794cdd00 on zemirco:master.


(feat) use multi-module generator in integration tests

Description
The tests using flow-maven-plugin now use generator-maven-plugin and the build process is adapted to allow it to run.
The plugin replacement should be discussed as by doing so, the old plugin is no longer part of the integration tests. Maybe at least a basic test should be kept on it.
Fixes #414

Fails due to #458


Preload metadata in the same directory

If the current file or directory is not in the cache, we can load the metadata of all files and dirs in the parent directory in advance to avoid multiple metadata loading.

This will cause performance degradation.

Thanks for your comments. This feature is suitable for scenarios where the same directory is appended, so that metadata does not need to be loaded when accessing other new files in the same directory. Maybe it's better to add a option. what do you think?

i am worried that during a large amount of concurrency requests, many getstatus will be triggered under the same directory which causing multiple listStatus happening together. When the parent folder contains a large number of files, this change may significantly impact the performance.
Can you provide more information about your workload and how much percentage this change improves the performance?


[GOBBLIN-2025] Add always false predicate

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-2025

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
For some use cases of predicates, we want an alwaysFalse semantic. Normally this is easy to import from Guava via Predicate.alwaysFalse() but due to Gobblin relying on classloading this is not feasible.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Trivial class added that can only be enabled via configuration

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.43%. Comparing base (058d23d) to head (9c14d5a).
Report is 2 commits behind head on master.

Files
Patch %
Lines

...n/data/management/copy/predicates/AlwaysFalse.java
0.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3903      +/-   ##
============================================
- Coverage     48.19%   47.43%   -0.77%
+ Complexity     9024     8144     -880
============================================
  Files          1765     1554     -211
  Lines         68165    61613    -6552
  Branches       7336     6990     -346
============================================
- Hits          32851    29224    -3627
+ Misses        32485    29681    -2804
+ Partials       2829     2708     -121

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Migrate data to oacore/content, connect NetlifyCMS

See details in the commit history

Sure, I missed the instructions bit for this PR, sorry.
You can use Vercel preview link posted above to access the preview of the current branch deployed. The CMS is located under /edit.
It allows to edit only team members information at the moment but you can freely try editing your personal info and share your impressions here. The CMS should also provide you live preview link after saving the draft. I still didn't figure out how it works though, there might be some issues in the CMS itself.


How to hide volume button on Mobile only?

I have been trying to figure out why the volume is shown on one website we using plyr but on another site in mobile view it is visible.
How does one enforce it to not show on mobile please?

Apologies, I see I had this, maybe someone else finds it useful...
@media(max-width: 767px) { 	.plyr__volume { 		display: none !important 	} }


How to add php to beautify?

Operating System (+Version):  Windows 10
VS Code Version:  1.33.1
beautify Version: 1.5.0

I added this code to my settings.json
"beautify.language": {
        "js": {
          "type": ["javascript", "json"],
          "filename": [".jshintrc", ".jsbeautifyrc"]
          // "ext": ["js", "json"]
          // ^^ to set extensions to be beautified using the javascript beautifier
        },
        "php": {
            "type": ["php"],
            "filename": [".php"]
            // "ext": ["js", "json"]
            // ^^ to set extensions to be beautified using the javascript beautifier
          },
        "css": ["css", "scss"],
        "html": ["htm", "html", "blade.php", "php"]
        // ^^ providing just an array sets the VS Code file type
      }

Action performed
I want to format my php code in my Laravel app in Controller which has extension Controller.php
when i press ctrl + shift + p and select Beautify selection I can only choose between: HTML, CSS and JavaScript.
Expected results
Expected results is to have PHP in Beautify selection.
Actual results
when i press ctrl + shift + p and select Beautify selection I can only choose between: HTML, CSS and JavaScript. How can I add PHP?

Beautify doesn't support PHP.
If you want beautify PHP files, you have to use different addon, example:

https://marketplace.visualstudio.com/items?itemName=kokororin.vscode-phpfmt

Additionally, read this Stackoverflow post , maybe it can help you because it's about blade files:

https://stackoverflow.com/questions/41330707/how-to-format-php-files-with-html-markup-in-visual-studio-code

Apart from your question, read about PSR-2:

https://www.php-fig.org/psr/psr-2/


:bug: Explicit CGO_ENABLED=1 on make build

Golang SQLite lib does not work with CGO_ENABLED=0 so setting this explicitly in the make build target.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 1.01%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
18

Relevant Lines:
1783

💛  - Coveralls


CRUD Editing Inline Cell Demo doesn't seem to work ?

material-react-table version
^3.0.1
react & react-dom versions
^18.3.1
Describe the bug and the steps to reproduce it
Trying out the CRUD inline cell editing from the documentation but I can't seem to get the newly submitted edited cell values so I cannot submit it to my API.
Minimal, Reproducible Example - (Optional, but Recommended)
mutationFn doesn't have the new values so I can't access the new values in the useUpdateUsers hook.
https://codesandbox.io/p/devbox/friendly-alex-v2c2yn
Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
None
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

probably use row._valueCache instead of row.original. Don't remember why the example uses row.original.


error in setActiveAIChannels

Received via slack, copying the error description here. I believe this error might be on floesche's branch feature-panelscontroller

I'm testing all the new run protocols and I'm having an issue with the streaming I thought you might be able  to  help with?
In the streaming protocol, I use the command ctlr.setActiveAIChannels(aibits); to turn on the input channels. I was getting an error everytime I tried to submit the startLog command that looked like this:
Error using  :
Colon operands must be in the range of the data type.

Error in PanelsController/expectResponse (line 1031) response = char(self.iBuf(pat.start(i):pat.end(i)));
Error in PanelsController/startLog (line 329) resp = self.expectResponse(0, 65, [], 10);
Error in G4_default_run_protocol_streaming (line 193) log_started = ctlr.startLog();
Error in G4_conductor_controller/run (line 711) eval(run_command);
Error in G4_conductor_view/run_exp (line 621) self.con.run();
Error in G4_conductor_view>@(varargin)self.run_exp(varargin{:}) (line 141) 'units', 'pixels', 'Position', [15, >self.fig_size(4)- 305, 115, 85],'Callback', @self.run_exp);

I figured out that this error was because pat.start was bigger than pat.end, and that it went away if I started the log running BEFORE doing the AI Channels command
So I moved my command to start the AI channels to after teh start log command. But it turns out that no matter where I call the command to start the  AI channels, the very next controller command  returns a similar error. So now, when I try to submit the pattern ID for the pretrial,  I'm getting this error:
Error using  +
Integers can only be combined with integers of the same class, or scalar doubles.
Error in PanelsController/expectResponse (line 1027) pat.end = pat.start + self.iBuf(pat.start);
Error in PanelsController/setPatternID (line 404) resp = self.expectResponse([0 1], 3, [], 0.1);
Error in set_controller_parameters (line 11) ctlr.setPatternID(p{2});
Error in G4_default_run_protocol_streaming (line 223) set_controller_parameters(ctlr_parameters_pretrial);
Error in G4_conductor_controller/run (line 711) eval(run_command);
Error in G4_conductor_view/run_exp (line 621) self.con.run();
Error in G4_conductor_view>@(varargin)self.run_exp(varargin{:}) (line 141) 'units', 'pixels', 'Position', [15, self.fig_size(4)- 305, 115, 85],'Callback', @self.run_exp);

Slightly different but same general issue - in this case, pat.end is empty. I think it has to do with the fact that the buffer is not empty or something? Because  I am collecting data from it?
Actually it's not the first controller command after ctlr.setActiveAIChannels(aibits); that's returning an error, it's the second. The set control mode command is called directly before the pattern id command and it seems to work fine.

Received via slack:

I still get the erro, but not always. The first time I ran it, I got this during the first intertrial:
Error using  +
Integers can only be combined with integers of the same class, or scalar doubles.
Error in PanelsController/expectResponse (line 1029)
                   pat.end = pat.start + uint64(self.iBuf(pat.start));
Error in PanelsController/setControlMode (line 389)
           resp = self.expectResponse([0 1], 16, [], 0.1);
Error in set_controller_parameters (line 10)
   ctlr.setControlMode(p{1});
Error in G4_default_run_protocol_streaming (line 283)
                   set_controller_parameters(ctlr_parameters);
Error in G4_conductor_controller/run (line 711)
           eval(run_command);
Error in G4_conductor_view/run_exp (line 621)
           self.con.run();
Error in G4_conductor_view>@(varargin)self.run_exp(varargin{:}) (line 141)
               'units', 'pixels', 'Position', [15, self.fig_size(4)- 305, 115, 85],'Callback', @self.run_exp);

It seems like pat.start is a double 1x2 and can't be added to the uint64. However, I paused here at other times throughout the experiment and it seems like when pat.start  is a double, but only one number (like 1), it works fine.
The second time I ran it, it went through the entire experiment with no errors.
The third time I ran it, on the second trial I got the same error as before, and again pat.start is a 1x2 double.

I can't reproduce the issue at this point.
Also, in the two most recent cases the error happens in a call from the function set_controller_parameters().
I don't know why this happens there, but I think this function is better integrated as a method into the controller object. That would allow easier debugging as well as more detailed access to the internal state of the controller. Currently this function looks like a workaround, duct taped to the object.
I'll need to pull your changes to my branch at some point to debug this.
In the meantime, building on your intuition of the double vs uint64, I added another type cast on my side with the this commit. Now we shouldn't be getting an overflow error anymore…

By controller object do you mean the Panels controller or do you mean the Conductor controller? The run protocols have historically not been a method of the Conductor controller because they were meant to be user accessible for editing and customization, whereas the class is not. So I created a modules folder which has all the common code between all the run protocols in it as standalone functions which can be called by any run protocol (but also easily edited if desired). Since we are now providing a limited number of run protocols, rather than assuming the user will be accessing and customizing them, I could re organize it so that even the run protocols are controller methods if that'd be beneficial.
The error only happens in this function because almost all the calls to the panel controller occur in this function, and it's the next panel controller command after some tiny delay that produces the error.

The error is fixed with the latest commit. Thank you! I will write a PanelsController method to replace my set parameters function.


Support Django 2.0

This pull request aims to provide support for all supported versions of Django and Djano REST Framework.(affecting #175). The support now offered is summarised in the table below:

DRF 3.4
DRF 3.5
DRF 3.6
DRF 3.7

Django 1.10
x
x
x
x

Django 1.11
x
x
x
x

Django 2.0

python 3.4+

where 'x' indicates support for python 2.7, 3.4, 3.5 and 3.6.
Support has dropped for Django 1.8 and 1.9, as well as python 3.2 and 3.3. I believe this is for the best, as Django 1.9 and below are considered insecure, and python 3.2 and 3.3 are not supported from Django
1.9 onwards.
Compatibility between Django 1.x and 2.x is achieved by adding a compatibility layer, in a similar manner to that of Django REST Framework
Testing for the various supported configurations is done using tox.

Oops, I wasn't familiar with the Travis CI process. Final 2 commits should have fixed that

I tested it, works fine! Thank you for this contribution. Hope that it will be merged soon.

Thank you, @jasperlittle!

Thank you @jasperlittle!!!

Technically, Django 1.8 still has extended support, but this is only until 1 April. And besides we have a much newer LTS in Django 1.11, so dropping 1.8 is a good decision IMO.

Is there any prevision for merge?

Also watching this. Really hope this great lib can carry on!

Have tested it and get some regex problems in the template so that the user is not able to test the api there:

Hi guys, I just created a new lib supporting Django 1.x and 2.x: django-rest-framework-redocs.
It's also a zero configuration automatic API doc page generator, please take a look and help me make it better!

Is this still a thing?

I believe so, but I'm not sure if someone is working on a fix for the reg-ex problem. I am a newbie myself, so I'm not sure if I can really help.

Hey, guys, why the branch have not been merged? who can help with this?

Will love to contribute @jasperlittle @manosim
Keep this alive. been using this for a long time!

merge?

Is there anything else that needs to be done for this to be merged?

@jasperlittle @manosim Hi, friends, can you give the merge access to me? I don't why there still not merge the branch.

Waiting for this merge as well.
I really need a working, interactive API that supports tokens, as browsable API does not.

+1 on this 😬

@cwirz I just fixed it.

Any ETA on merging and releasing this ?

:+1:

👍

@jasperlittle Can you push and merge? You have the access.
@manosim What about pypi? Can @jasperlittle also update on pypi?

updates on this?

@newsuk any update on this?


Formrecognizer ignore custom field getters in deserialization

Formrecognizer ignore custom field getters(i.e getValueAsDate(), getValueAsLong() etc) when deserializing values to avoid class cast exceptions.
Ref: #31172

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-formrecognizer


syntax correction

Example 3 references a non-existent function Get-FirewallRule when it should reference the topic of this page Get-NetFirewallRule

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca016e79-1b11-8004-99aa-362cf6c082e9
Version Independent ID: 2c7f3269-445e-b9dd-a382-5f64f44ab770
Content: Get-NetFirewallPortFilter (netsecurity)
Content Source: docset/winserver2012r2-ps/netsecurity/Get-NetFirewallPortFilter.md
Product: powershell
Technology: powershell
GitHub Login: @brianlic
Microsoft Alias: brianlic

@officedocsbot assign @e0i

Hello, @fatherjack
The issue is under investigation and you will be notified with any changes on the way.
Thank you for providing feedback.

@fatherjack
With the help of your feedback, the content has been updated with relevant changes accordingly. Thanks.


Add performance audit

In this PR, I:
✔ Added the email column to the owners' table
✔ Added data to the visits' and to the owners' tables
✔ Ran the "explain analyse" query on the visits counts for the animal with id=4, Execution time: 1133.868 ms (see screenshot 1); the vet with id = 2, Execution Time: 1129.756 ms (see screenshot 2) and for the owner with email =<EMAIL_ADDRESS> Execution Time: 2775.187 ms (see screenshot 3).

✔ Found a way to decrease the execution time of the first query based on the hints given in the materials.
✔ Found a way to improve the execution time of the other two queries.
✔ While making changes, I checked if they helped by running EXPLAIN ANALYZE. Once I succeeded, took a screenshot of the EXPLAIN ANALYZE result showing that time actually decreased.
✔ Added any changes to the database schema to the schema.sql file and committed in a new pull request.
✔ Included screenshots with EXPLAIN ANALYZE results in my PR description (before and after I improved the speed) for each of the 3 problematic queries.

In this Milestone, I added the schema capture.


@every(minutes=10) don't trigger a new on_start()

pyspider version:'0.3.9'
Operating system:linux
Start up command:

Expected behavior
run function on_start() every 10 minuts。

Actual behavior
on_start() only run once when i click the button run

How to reproduce

i think it run more than once but it didn't run every 10 minutes.


Sending an attribute with a malformed syntax in sort at search time does not raise an invalid_sort error

With sortable-attributes
["title", "rates"]

If I send sort in this way at search time (missing :asc/:desc)
{
    "sort": ["title"]
}

or if I send sort in this way (malformed :asc/:desc)
{
    "sort": ["title:deesc"]
}

The API response is
{
    "message": "invalid criterion title:deesc",
    "errorCode": "internal",
    "errorType": "internal_error",
    "errorLink": "https://docs.meilisearch.com/errors#internal"
}

As a user, I would like to receive an invalid_sort error indicating a syntax error in the sort parameter.

@irevoire. The patch of the spec describes the message we need :)
https://github.com/meilisearch/specifications/pull/68#pullrequestreview-747136355


Update sources

:robot_face: Updating sources to the latest version.
Commits touching OCaml packages:
Diff URL: https://github.com/NixOS/nixpkgs/compare/d28249cfd262baa408d840d91ff2b46d9578ce34...9d28889ac87433e34a8085c08eb2909369a971ec

seems broken


examples: add RTK example

This shows how RTCM corrections can be sent using the Rtk plugin.
This will only work starting with MAVSDK server version https://github.com/mavlink/MAVSDK/releases/tag/v1.4.16 and thus MAVSDK-Python v1.4.8.

Looking good! Maybe we could extend this with some code reading the RTCM data from an actual GPS device, like a ublox chip? Or would that be too specific?

@dayjaby yes please, if you could add something like that, that would be fantastic. Or maybe there is some pip package that helps with connecting to ntrip.

@julianoes sure, but feel free to bring your example already in. I will create another PR for that.


Question:

Why did you make this mod? I mean you apparently can make mods, so why waste time on something like this? I have never criticized what type of mod a mod developer has made in their entire life before, but this just seems shitty. The world is currently in a bad situation, and I honestly don't think in any way that this mod or idea is in any way whatsoever funny.  I have dark humour as well, but I honestly cannot and will never understand why you made this, or decided to publish it that is. Sorry not sorry.

@LokeYourLord Cause some people suggested it, it's my first mod and I thought it could be a cool way to learn.

Alright I see, I guess it makes sense for learning purposes.

Also, even if it wasn’t as a learning experience, what’s wrong with someone making something they like?


⚠ T:Riza Api has degraded performance

In f53d0a1, T:Riza Api (https://infra.triza.dev/api) experienced degraded performance:

HTTP code: 200
Response time: 2885 ms

Resolved: T:Riza Api performance has improved in 997387a.


Exception when using BlobClient.download_blob with MSI authentication: AttributeError: 'NoneType' object has no attribute 'status_code'

Which service(blob, file, queue) does this issue concern?
Blob Service
Which version of the SDK was used? Please provide the output of pip freeze.
azure-common==1.1.24
azure-core==1.1.1
azure-functions==1.0.7
azure-identity==1.2.0
azure-keyvault-secrets==4.0.0
azure-storage-blob==12.1.0
cryptography==2.8
msal==1.1.0
msal-extensions==0.1.3
msrest==0.6.10
py==1.8.1
pytz==2019.3
pywin32==227
requests==2.22.0
Shortened for relevance
What problem was encountered?
When constructing a blob client like so:
cities_config_url = os.environ["CITIES_CONFIG_URL"]
blob_credential = ManagedIdentityCredential()

def create_blob_client(url):
    """Create blob client from URL to read/write blobs to Azure"""
    blob_client = BlobClient.from_blob_url(url, credential=blob_credential)
    return blob_client

And using it to download a blob like so:
def get_polygonsJSON():
    """Gets JSON definition file of city polygons from Azure Blob Storage"""
    polygon_blob_client = create_blob_client(cities_config_url)

    try:
        # Download polygon JSON blob from Azure Storage
        polygons_filestream = polygon_blob_client.download_blob()
        polygons_file = polygons_filestream.readall()
        polygons_json = json.loads(polygons_file)

I get the following error:
Exception: 'NoneType' object has no attribute 'status_code'
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\storage\blob\_download.py", line 366, in _initial_request
    **self._request_options
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\storage\blob\_generated\operations\_blob_operations.py", line 163, in download
    pipeline_response = self._client._pipeline.run(request, stream=True, **kwargs)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\_base.py", line 208, in run
    return first_node.send(pipeline_request)  # type: ignore
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\_base.py", line 80, in send
    response = self.next.send(request)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\_base.py", line 80, in send
    response = self.next.send(request)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\_base.py", line 80, in send
    response = self.next.send(request)
  [Previous line repeated 3 more times]
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\_base.py", line 78, in send
    _await_result(self._policy.on_request, request)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\_base.py", line 47, in _await_result
    result = func(*args, **kwargs)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\pipeline\policies\_authentication.py",
line 82, in on_request
    self._token = self._credential.get_token(*self._scopes)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\identity\_credentials\managed_identity.py",
line 152, in get_token
    raise ClientAuthenticationError(message="IMDS endpoint unavailable")
azure.core.exceptions.ClientAuthenticationError: IMDS endpoint unavailable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\jamesgr\Desktop\TEAL\teal-ml\traffic-collection\__app__\SharedCode\blobutils.py", line 39, in get_polygonsJSON
    polygons_filestream = polygon_blob_client.download_blob()
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\core\tracing\decorator.py", line 62, in wrapper_use_tracer
    return func(*args, **kwargs) # type: ignore
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\storage\blob\_blob_client.py", line 601, in
download_blob
    return StorageStreamDownloader(**options)
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\storage\blob\_download.py", line 316, in __init__
    self._response = self._initial_request()
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\azure\storage\blob\_download.py", line 385, in _initial_request
    if self._start_range is None and error.response.status_code == 416:
AttributeError: 'NoneType' object has no attribute 'status_code'

Have you found a mitigation/solution?
Not yet: there's an error getting the MSI token which is leading to a second error within the blob SDK trying to use the status_code field when the response object is returned null - there should be some handling for this eventuality within the SDK

The original error caused by MSI is localised to consumption plans on Linux - see separate issue raised here: https://github.com/Azure/Azure-Functions/issues/1486

I had the same problem... for me the solution was quite easy: i provided the correct credentials.
It seems that you will get an instance of e.g. BlobClient with wrong credentials but you can not interact with it. The result was the same exception as you provided:
AttributeError: 'NoneType' object has no attribute 'status_code'
So, check your credentials and use for tests maybe your access key or a sas token. This was my "solution"... :)

I had the same problem... for me the solution was quite easy: i provided the correct credentials.
It seems that you will get an instance of e.g. BlobClient with wrong credentials but you can not interact with it. The result was the same exception as you provided:
AttributeError: 'NoneType' object has no attribute 'status_code'
So, check your credentials and use for tests maybe your access key or a sas token. This was my "solution"... :)

Fix has been deployed on the linked issue. This issue can be closed.


bind and unbind error (TZ-781)

Answers checklist.

[X] I have read the documentation ESP Zigbee SDK Programming Guide and tried the debugging tips, the issue is not addressed there.
[X] I have updated ESP Zigbee libs (esp-zboss-lib and esp-zigbee-lib) to the latest version, with corresponding IDF version, and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
5.1.3
esp-zigbee-lib version.
1.2.3
esp-zboss-lib version.
1.2.3
Espressif SoC revision.
ESP32-H2 & ESP32-C6
What is the expected behavior?
the expected behavior is for both commands to work as they should
What is the actual behavior?
there are 2 different problems

binding error
In this case the error is found when performing the binding, the method correctly calls the command and the callcack is also called, but it responds with an error message 133 corresponding to a timeout, this error occurs quite often but not always
Below is an excerpt of the implemented code

void zigbeeDeviceBindReq(uint16_t rid,esp_zb_ieee_addr_t src_addr,esp_zb_ieee_addr_t des_addr,uint16_t cluster_id,uint8_t src_ep,uint8_t des_ep){
    esp_zb_zdo_bind_req_param_t bind_req;
    uint16_t *user_rid = malloc(sizeof(uint16_t));
    *user_rid=rid;
    bind_req.cluster_id=cluster_id;
    bind_req.dst_addr_mode=ESP_ZB_APS_ADDR_MODE_64_ENDP_PRESENT;
    memcpy(bind_req.src_address,src_addr,sizeof(esp_zb_ieee_addr_t));
    memcpy(bind_req.dst_address_u.addr_long,des_addr,sizeof(esp_zb_ieee_addr_t));
    bind_req.dst_endp=des_ep;
    bind_req.src_endp=src_ep;
    bind_req.req_dst_addr=esp_zb_address_short_by_ieee(src_addr);
    esp_zb_zdo_device_bind_req(&bind_req, bind_cb, (void *)user_rid);
}
static void bind_cb(esp_zb_zdp_status_t zdo_status, void *user_ctx)
{
ESP_LOGE("ZIGBEE","CALLBACK BIND");
free(user_ctx);
}

unbinding error
On the other hand, this error corresponds to unbind . and there is no response when calling it, not only that but I placed a log inside the unbind callback and it is never called
Below is an excerpt of the implemented code

void zigbeeDeviceUnbindReq(uint16_t rid,esp_zb_ieee_addr_t src_addr,esp_zb_ieee_addr_t des_addr,uint16_t cluster_id,uint8_t src_ep,uint8_t des_ep){
esp_zb_zdo_bind_req_param_t bind_req;
uint16_t *user_rid = malloc(sizeof(uint16_t));
*user_rid=rid;
bind_req.cluster_id=cluster_id;
bind_req.dst_addr_mode=ESP_ZB_APS_ADDR_MODE_64_ENDP_PRESENT;
memcpy(bind_req.src_address,src_addr,sizeof(esp_zb_ieee_addr_t));
memcpy(bind_req.dst_address_u.addr_long,des_addr,sizeof(esp_zb_ieee_addr_t));
bind_req.dst_endp=des_ep;
bind_req.src_endp=src_ep;
bind_req.req_dst_addr=esp_zb_address_short_by_ieee(src_addr);
esp_zb_zdo_device_unbind_req(&bind_req, unbind_cb, (void *)user_rid);
}
static void unbind_cb(esp_zb_zdp_status_t zdo_status, void *user_ctx)
{
ESP_LOGE("ZIGBEE","CALLBACK UNBIND");
free(user_ctx);
}

Steps to reproduce.
perform binding and unbindings
More Information.
No response

@diazmanuel

binding error
In this case the error is found when performing the binding, the method correctly calls the command and the callcack is also called, but it responds with an error message 133 corresponding to a timeout, this error occurs quite often but not always
Below is an excerpt of the implemented code

Regarding the issue, I have checked your code, which appears to be correct. However, the binding request is extensively used in the esp-zigbee-sdk examples. Could you double-check the addresses in the binding request? Alternatively, could you please provide me with a simple reproducing code?

hello @xieqinan,
After carrying out more tests I was able to identify that the binding problem is linked to using repeaters and subjecting the end device to stress tests, that is, disconnecting the coordinator and the repeaters repeatedly, at some point it begins to fail, I will leave this to you.  I understand that the problem is entering and leaving the network continuously.
Regarding the unbind issue, I created an example to demonstrate the problem, in this case the problem as I mentioned before happens all the time, the example runs a coordinator on the ESP32C6 and an end device with the ESP32H2, when pressing the button on the board development of the end device, it sends a bind and when you press it again it sends an unbind and this is repeated cyclically when you continue pressing it.
What is happening is that the binding callback is called correctly with status 0 but when calling unbind it does not enter its callback so it is not being executed. Below I leave the log of these bindings and unbinding and attach the example so you can test it.
E (781) ESP_ZB_ON_OFF_LIGHT: mac address: 60:55:f9:ff:fe:f7:73:de
E (781) ESP_ZB_ON_OFF_LIGHT: mac address: 40:4c:ca:ff:fe:45:3b:9c
E (781) ZIGBEE: ready for BINDs
E (5131) ZIGBEE: Sending BIND
E (5131) ZIGBEE: CALLBACK BIND status 0
E (6641) ZIGBEE: Sending UNBIND
E (10291) ZIGBEE: Sending BIND
E (10291) ZIGBEE: CALLBACK BIND status 0
E (15041) ZIGBEE: Sending UNBIND
E (19621) ZIGBEE: Sending BIND
E (19621) ZIGBEE: CALLBACK BIND status 0
E (23941) ZIGBEE: Sending UNBIND

custom_test_mod.zip


Add examples to illustrate the rules

Hi,
Great styleguide, it's nice to have it written down on paper to share it with fellow developers.
I think some examples (good vs wrong) would really help people to adopt your style guide.
Cheers,
Damien

hi
sorry for the delay, PR are welcome!


Login Fallback when unable to bind

When I am developing at home I cannot connect to the company LDAP server because of VPN and firewall issues. Therefore I receive a BindException. Would it be possible to have graceful degradation such that instead of a BindException the package would first try to fallback to local credentials, and then only if both attempts (bind and fallback) fail, throw an exception? I've already synced with AD while at work and would like to be able to transition between home and the office without having to mess with the auth setup.

If you set auto_connect to false and login_fallback to true in the adldap configuration files, you'll be able to develop without access to your LDAP server.

#RTM
Thanks. Cooking with gas now.

No problem! If you encounter anything else please create another issue :).


Add Trezor support for Pirl, Ether-1 and AtheiosChain

Pirl, Ether-1 and Atheios are now supported in TREZOR ONE firmware version 1.6.3
https://blog.trezor.io/trezor-one-firmware-update-1-6-3-73894c0506d
@gamalielhere if we could merge and deploy this ASAP, it can help prevent any user confusion after reading today's announcement from Trezor.

@mkrufky mind rebasing this into #2040? I'll merge them afterwards. Closing this PR

@gamalielhere done. thanks in advance