feat: Add support for tokens in toml files

Description
Currently, the only way to specify tokens is using JSON, however there are some unique benefits to using the TOML format for design tokens. TOML is a format for configuration files that resembles the ini but can support richer nested data. It has been embraced as the default format by Python for pyproject files and by Rust for it's Cargo.toml files.
There are a couple of reasons why it's particularly good for the usecase of design tokens.

It has a simpler way of representing deeply nested data

Design tokens are deeply nested and in JSON it can get a bit clumsy to represent this. To take a particularly deeply nested value, we have other.content.form.control.checkbox.indicator.icon-checked.base which is 8 levels deep. The JSON for such deeply nested values can be pretty verbose and can be hard to follow. In comparison with TOML this is just:
[other.content.form.control.checkbox.indicator.icon-checked.base]
value = "..."
type = "..."
source = "..."

The above dot notiation very easily maps to the final variable name, and you can quickly do a search for such nested data without checking the full heirarchy.

The order of nested TOML documents can be arbitrary

In the above example, if you wanted to add value for other.content.form you can simply do that at any point
in the document. Unlike JSON where you'd need to have it nested in the correct hierarchy.

Changes in nesting can be done much quicker

If in the above example, you wanted to change from the checkbox.indicator to checkbox-indicator or move from other.content.form to other.form only for this value without affecting other values, you can do that with just a single change without impacting any otherpart of the hierarchy. With JSON if you rename an attribute that automatically affects all the values in that heirarchy, so you'd have to move this bit of the document to a new attribute. TOML really simplifies refactoring.

TOML has native support for comments

While design tokens can support comments via field, this is part of the document and will be processed as such. This is not a huge issue, but still a nice to have.
NOTE: This PR merely adds a way to support TOML for design tokens. It is not a recommendation to switch the entirety of the token system to use toml instead of JSON.
While doing some work on design tokens I had to deal with a lot of cases where I'd expressed the hierarchy of values incorrectly and it was a pain to make the changes. I found this much easier with toml so began converting JSON to TOML to make the changes and then convert back. I figured it would be nice to simply add support to Paragon itself since it was a small enough change.
Testing
You can test this by creating a minimal setup for design tokens.

Create a new directory with the following directory structure inside it: themes/light . (e.g. /tmp/toml-tokens/
Inside the light folder create a toml file with some design tokens, for example: [color.testing]
 value = "#123456"

Check out this version of Paragon, install the dependencies and run:  ./bin/paragon-scripts.js build-tokens --source  /tmp/toml-tokens/ --build-dir  /tmp/toml-tokens/build --source-tokens-only
Check the output build directory in the folder and you'll see a file called themes/light/variables.css that has a css variable called --pgn-color-testing with the above value.

Deploy Preview
NA
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

@adamstankiewicz Could we get your thoughts on this?

@bradenmacdonald I have added this to the agenda for tomorrow's Paragon WG meeting.

We discussed this in the working group meeting last week and the benefits of toml are absolutely worth merging this for!

NOTE: This PR merely adds a way to support TOML for design tokens. It is not a recommendation to switch the entirety of the token system to use toml instead of JSON.

This lines up perfectly with what was discussed in the working group - in the meeting notes we noted:

Supporting toml for brand package overrides makes a lot of sense

Specifically being able to set one.value.nested.quite.deeply without creating a giant empty json structure is a huge benefit.

We should keep the base tokens in json

The style dictionary documentation uses json which makes cross-referencing easier
The nested structure is beneficial in with working with all of the tokens and not just a subset

@xitij2000 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

Thanks for looking into this and merging it!


[CP Staging] Use selected currency when utilising tax rate

Details
Use selected currency when utilising tax rate.
Fixed Issues
$ https://github.com/Expensify/App/issues/42047
PROPOSAL: https://github.com/Expensify/App/issues/42047#issuecomment-2107476499
Tests

Set default tax as 0 and foreign tax as some value like 5%.
Go to submit expense flow.
Try to change the tax amount.
It should change to the new amount if it is below the 5% limit.

QA Steps

Set default tax as 0 and foreign tax as some value like 5%.
Go to submit expense flow.
Try to change the tax amount.
It should change to the new amount if it is below the 5% limit.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@ShridharGoel TS errors.

Yes, I think we should update all usages

Looks like transformedTaxRates needs only the transaction currency. Thoughts?

👍 we can leave it. Thanks for checking!

@allroundexperts over to you

Hm... isn't the lint failing?

@ShridharGoel could you please fix the lint errors

Just a small feedback, as a reviewer force pushing commits make difficult to know what has been updated since last commit as it deletes commit history.

@ShridharGoel Are you done?

Can you please mention reproduction steps? Isn't it the same issue as mentioned in https://github.com/Expensify/App/issues/42047

what! I am seeing it correctly? You should not be able to update currency for tax amount.

No, the issue is

When saving a valid tax amount, error shows up. The maximum rate amount in the error message still follows the previous tax rate (Workspace currency default). User will need to save 0 tax amount and return to Tax amount after saving to save the new tax amount.

User is only allowed to update amount(number) and not currency in tax amount field.
If tax amount is $50, user is only able to edit 50 and not $
The issue occurs when user is trying to update tax amount and currency(associated with expense amount and not tax amount)

The video mentioned in issue shows the tax currency being changed. I think then we should just disable the changing option there?

I believe it is already the case. Looking...

It's a regression from https://github.com/Expensify/App/pull/40159/files
Currency for tax amount is uneditable

Nice, thanks!
So what is remaining to get final review on this PR. Could you please summarise?

Thanks for letting us know. I'm on the review.

@ShridharGoel Can you please update the screen recordings?

Changing the currency resets the tax amount. Is that expected?

Changing the currency resets the tax amount.

Can you please explain "reset". Perhaps with an example

@MonilBhavsar Notice how the tax amount changes from 5 to 5.76 after I change the currency at the end.
https://github.com/Expensify/App/assets/30054992/002ccd65-dc66-4866-aaff-5bc90cf7a764

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

CPing 👍

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.73-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add Configurable Company API to wiki

Adding Configurable company API by Ansuz/AMRV to the wiki since many developers may find it easier to understand it from here than from thunderstore wiki or github wiki.
The wiki is part of the Modding APIs wiki section.
I reworked the contents of those existing wikis to provide more information in a friendly manner.
The API itself is not related to any other API in the wiki so I created both an overview and pages for each type of builder and complex feature that the developer might need to use the plugin correctly.
Github
Thunderstore

Updated :)


[enhancement] Support Django 1.11

I just ran into #122 ("NoneType object is not callable"). Creating this issue to get updates on support for Django 1.11.
In the meantime, perhaps add the Django versions you support to the README? As far as I can see that's >= 1.8 and < 1.11 (whoops, it's there already as pointed out below)

Look at the file README.rst

django-ldapdb supports Django versions 1.8 to 1.10, and Python 2.7/3.4/3.5.

But I totally agree with you that we have to support soon Django 1.11, because the mainstream support for 1.10 is over. See here the roadmap.

I'm also working on django 1.11 and tried using django_ldapdb.  Looking forward to updates to django_ldapdb.
Thanks!


Missing k3s folders and files in rpi images

Kairos version:
NAME="openSUSE Leap"
VERSION="15.5"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.5"
PRETTY_NAME="openSUSE Leap 15.5"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.5"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
DOCUMENTATION_URL="https://en.opensuse.org/Portal:Leap"
LOGO="distributor-logo-Leap"
KAIROS_NAME="kairos-kairos-opensuse-leap-arm-rpi"
KAIROS_VERSION="v2.4.0-k3sv1.27.3+k3s1"
KAIROS_ID="kairos"
KAIROS_ID_LIKE="kairos-kairos-opensuse-leap-arm-rpi"
KAIROS_VERSION_ID="v2.4.0-k3sv1.27.3+k3s1"
KAIROS_PRETTY_NAME="kairos-kairos-opensuse-leap-arm-rpi v2.4.0-k3sv1.27.3+k3s1"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues"
KAIROS_HOME_URL="https://github.com/kairos-io/kairos"
KAIROS_IMAGE_REPO="quay.io/kairos/kairos-opensuse-leap-arm-rpi"
KAIROS_IMAGE_LABEL=""
KAIROS_GITHUB_REPO="kairos-io/provider-kairos"
KAIROS_VARIANT="kairos"
KAIROS_FLAVOR="opensuse-leap-arm-rpi"
CPU architecture, OS, and Version:
Linux localhost 5.14.21-150500.55.19-default #1 SMP PREEMPT_DYNAMIC Tue Aug 8 22:15:01 UTC 2023 (9908c29) aarch64 aarch64 aarch64 GNU/Linux
Describe the bug
I installed the current rpi images - tried both the Ubuntu and the opensuse leap versions - on a raspberry pi 4 as described her (https://kairos.io/docs/installation/raspberry/) and as I have done several times before. To setup the node I make use of Ansible playbooks.
When my playbooks failed I realized that apart from elder versions of these images several k3s related folders and their containing files are missing from the image.
The following two folders

/etc/rancher/k3s/
/var/lib/rancher/k3s/

are missing and especially the following file is not part of the image:

/etc/rancher/k3s/k3s.yaml

To Reproduce
Install the latest version of kairos on a raspberry pi as described here: https://kairos.io/docs/installation/raspberry/
Expected behavior
The listed files and folders should exist
Logs

Additional context

This issue was supposedly fixed here: https://github.com/kairos-io/packages/commit/59fabf5527028c646cf5337b4697efe913ed8907 and includedin 2.4.0 release which you seem to be using. Let's try toi reproduce, maybe we missed something.

Regarding /etc/rancher/k3s/k3s.yaml, I think this is a file that gets generates when k3s starts. There is a bug that prevents k3s from starting on rpi because the persistent partition is not expanded thus it's remains too small for k3s to start. Maybe that's the reason you don't see that file.
In any case, let's debug this.

I built an image from kairos master branch with the persistent partition expansion fix. k3s starts fine and the /etc/rancher/k3s/ directory gets created along with the files in it.
The issues seems to be the expansion bug preventing k3s form starting and creating those files and directories. Should be fixed in the next patch release.
I'll keep this open to verify when that release is out.

Thanx @jimmykarily for digging into this issue. Highly appreciated. So I will wait patiently for the next patch release.

v2.4.1 is now out and it fixes this issue. I'm closing this. @felixmw please re-open if you encounter any issues. Thanks for reporting.


https://spinnaker.io/community/stats/ needs some love

Page: /community/stats/
Feedback:

The link to the Linux Foundation Telemetry Data Collection and Usage Policy is broken: https://www.linuxfoundation.org/telemetry-data-collection-and-usage-policy/
The public dashboard simply shows a dataset configuration error:

Who can we ask for information about how this is setup?

@spinnakerbot remove-label to-be-closed

Who can we ask for information about how this is setup?


Fix bugs of ACF and featured media

This PR fixes the following.

wp_make_content_images_responsive()  is deprecated and the wp_make_content_images_responsive hook was removed.

Use wp_filter_content_tags() and the wp_filter_content_tags hook instead.

Fix ACF bug with repeater fields

We are using the wrong hook to get the value. We have to get the value before formatted and overwrite it after formatted via acf/format_value/type={$type}.

Fix bugs of saving featured images via REST API (i.e. Block Editor)

We have to use the rest_pre_insert_{$post_type} hook to get the featured image ID

Thank you!


Process Hacker crashed when switch to "Modules" tab in property of a UWP process

Double click any UWP process to open the property window, and switch to Modules tab, Process Hacker will pop up a dialog say it has crashed with error code 0xC0000005(memory location access invalid). Then Process Hacker is unable to view any process' modules.
Don't view UWP's module but only view traditional Win32 process' modules have no problem.
Any process doesn't in AppContainer but inside a package (e.g. Windows Terminal) will also affected by this problem. The only exception I found is OpenConhost.exe in Windows Terminal.
Environment info:
Process Hacker: 3.0.3295
Windows 10 x64 10.0.18363.1016

After a system reboot, I found this problem is not always occurred. I've created some minidump according to Process Hacker.
Process Hacker Minidump.zip

Fixed with commit https://github.com/processhacker/processhacker/commit/dd9d5ced038a865c3237a9567ce519fdafad0d07


Enable evaluation of step strings

The syntax would be something like evaluateStepString(stepString: string, sizes: number[]).
evaluateStepString(LLsLLLs, [L: 9/8, s: 256/243]) would result in Pythagorean Ionian.

SonicWeave doesn't have objects/dictionaries. If you want those I'm inclined to the syntax {L: 9/8, s: 256/243}. That should be a separate issue, though.
As for current state of affairs: realizeStepString("LLsLLLs", [9/8, 256/243]) is possible to implement.

We could also use makeshift records like:
realizeStepString("XXyXXXy", [["X", 9/8], ["y", 256/243]])

One of the steps should be omittable to stack up to an octave by default e.g.
realizeStepString("XXyXXXy", [["X", 9/8]])

would produce the same result.


Animations not working with custom placeholders.

showLoadingAnimation prop not working with custom placeholders.
render() {
   <ReactPlaceholder showLoadingAnimation ready={ready} customPlaceholder={<TextRow />}>

             {children}

    </ReactPlaceholder>
}

Hi,
Same issue here:
        customPlaceholder={awesomePlaceholder}
        showLoadingAnimation
        ready={false}
      >

test

      </ReactPlaceholder>```

`reactPlaceholder.css` is called in my Component but I don't see any animation.

Did I miss something?

Thank you!

Hi @mskasal and @DaPo, sorry for the late answer!
Talking about the issue, I'm not sure fully understand it: when you say "custom placeholders" are you referring to components completely custom or built with react-placeholder's exported components?
If it's the second case we may be able to find a fix, but for the first one I don't see any possible way as it's your duty to pass the right className to your completely custom component

Hi @FrancescoCioria,
It was indeed with react-placeholder's exported components, like this:
const awesomePlaceholder = (

       <RectShape
         color="#EEEEEE"
         style={{ flexShrink: 0, width: 184, height: 270 }}
       />
       <TextBlock
         rows={7}
         color="#EEEEEE"
       />

 );

Then:
return (
  <ReactPlaceholder
    customPlaceholder={awesomePlaceholder}
    ready={false}
    showLoadingAnimation
  >

  </ReactPlaceholder>
);

Please don't mind the empty DIV tag that will have my loaded component, it's just a test case here.
So as you can see, I tried to make the showLoadingAnimation working but it seems like it won't load the className in the DOM if we have custom markup.
So the workaround until the bug is fixed: I added a className="show-loading-animation" to my wrapper in my const and copy/paste your keyframes in one of my CSS files.
That's it!
I hope my answer is clear, my english is pretty bad.
Thank you for your job and have a nice day.

Thank you @DaPo , perfectly clear :)
I'll review the open PR to see if it's a suitable fix

@FrancescoCioria thank you very much!
See you.


DataGrid.RowCount: Exception when ItemSource is empty collection

DataGrid.RowCount throws InvalidOperationException here when ItemSource is empty collection.
public override T GetItem<T>(int row, int column, Func<BasicAutomationElementBase, T> wrap)
{
    var nativeItem = Com.Call(() => this.NativePattern.GetItem(row, column));
    if (nativeItem == null)
    {
        throw new InvalidOperationException("Did not find item.");
    }

    return wrap(new UIA3BasicAutomationElement((UIA3Automation)this.BasicAutomationElement.Automation, nativeItem));
}

If set CanUserAddRows="False" it works fine.

We should probably spexialcase it, not sure what is best, maybe just write the simplest we can come up with and throw some tests at it?


Fixes moderate bug when reading Stockholm files

Fixes #1334
Handles multi-line trees without id correctly, adds multi-line
tree tests.

Thanks @Kleptobismol, just had a few minor comments

Looks great, thanks @Kleptobismol for the fix!


Added Eto.Forms and Firebird.NET

Due to conflicts I needed to refork. Please ignore other PR.

Due to conflicts I needed to refork. Please ignore #89.

Thank you :+1:


Added translation

Added the translation on the block that already had the Spanish language id.
Copied the info for "post_date" from the other block, since it showed 'null'.

Thank you!
Please let me know whenever I can help you... regardless of the month 😉
B
On Nov 13, 2017 6:52 AM, "Jan Lenoch"<EMAIL_ADDRESS>wrote:

@JanLenoch approved this pull request.
Hi Bee, great job! This content item is one of those that contain rich
text content elements. But, you might have noticed that in the .json file,
there was no rich text data. That's because currently, our content
management API does not support exporting/importing this kind of elements.
We're working on adding the support in the coming days. Once the feature is
out, I'll prepare a brand new set of .json files so that you can clearly
see the rich text elements that remain to be translated. Muchas gracias!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Kentico/cloud-sample-app-react/pull/53#pullrequestreview-76089540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVmnvtuNrAWrHjcutLTfrGHCPb1eH61Sks5s2DuZgaJpZM4QRrwZ
.


[ci] Run Miri tests on multiple threads

Use cargo nextest to run Miri tests on twice the number of threads as there are CPU cores.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.84%. Comparing base (3aef801) to head (9f70cd3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   87.84%   87.84%
=======================================
  Files          15       15
  Lines        5191     5191
=======================================
  Hits         4560     4560
  Misses        631      631

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CI: Update mac os runner versions

macos-latest is macos-14: https://github.com/actions/runner-images
macos-15 is ARM, and also in beta.

coverage: 98.783%. remained the same
when pulling 20114cecc734bbf024d41c8987a98c301eccc89c on isaacbrodsky:update-macos-runners
into e45b999bbddcc4736abf8cca1996101d16e53c11 on uber:master.


WIP Test xid wraparound

This test uses test_consume_xids() and takes about 15min to complete.
Another way to test xid wraparound is to use pg_resetwal -x, but it turned out to be too hacky and hard to debug. And also it doesn't test clog truncation.
The commit also contains a few fixes to update_next_xid() function to restore nextXid properly.

@hlinnaka, I guess the error caught here is related to #502
IIUC, the problem is that we don't see SLRU segment that was created after drop.
I don't think it is clog-specific, it's just hard to catch in other tests because we rarely (never?) reuse filenames.

The commit also contains a few fixes to update_next_xid() function to restore nextXid properly.

Have you seen postgres/postgres@74cf7d46?

@lubennikovaav so what with that? should we commit it or close it?

As discussed moving to draft.


[iOS] Fix build with Xcode 15.

Add a workaround for linker bug (same as https://github.com/godotengine/godot/pull/81968)
Bump iOS min. version to 12.0, since SDK for 11.0 is no longer included or supported.
Remove some deprecated code.

We should fix the build issue on 4.1/4.0 and 3.x/3.5, but ideally there I would like to preserve iOS 11 support (at least for release branches, for 3.x we could bump to 12).

@akien-mga
@bruvzg
I noticed that it is not possible to downgrade xcode to version 14.x.
The newest version (Xcode 14.3.1) is not compatible with Macos Sonoma 14.0.
Therefore, if the bug is not fixed, users with Macos Sonoma will not be able to export the Godot project to iOS.
Only Xcode version 15 runs on macos sonoma.

but ideally there I would like to preserve iOS 11 support

I'll take a look if it's possible, but I do not think there's any reason to support it. Unlike iOS 12, iOS 11 is completely obsolete and does not receive security updates for 5 years, no one should use it.

Ok, let's drop iOS 11 then, if Apple forces our hand there's no reason to fight them.

Thanks!

Cherry-picked for 4.1.2.

I came here to inform that i tested on brand new 4.2-dev6 and cannot perfectly build it in xcode 15 with macbook with Apple Silicon yet....
But now, minimum iOS version is 12.0.
Errors:

Complete project and configuration can be found here:
https://github.com/godotengine/godot/issues/82551
but now de Godot version is 4.2-dev6
@akien-mga

With this issue still existing, what is currently the best combo versions of Godot 4/Xcode to export iOS with plugins with?

Facing same issue currently with v4.2.2.stable.official [15073afe3]

Which Xcode version do you have? The upstream bug was fixed in 15.2.

Facing same issue currently with v4.2.2.stable.official

Are you trying to run it in the simulator on Apple Silicon Mac? Official templates include only x86_64 simulator and arm64 device libs, but not arm64 simulator lib (it's build with OSXCross, and it still not capable of building it). You can run it on the real iOS device, or select "This mac" instead of simulator, or run Xcode under Rosetta to use x86_64, or build a custom template.


Better default styling for material parameter lists

Currently the styling of the tables used for parameter lists in the material style allows long type names
to squash the description column, making it harder to read:

I think this can be fixed with the appropriate CSS magic, but it would be nice if this project provided
a better default style rule to give the description column more space.
--
I am currently using mkdocs 1.30, mkdocs-material 8.2.9, mkdocstrings 0.18.1, mkdocstrings-python-legacy 0.2.2
from conda-forge.

The new handler looks much better! Simply having the different layout options is a huge improvement. Good job!

Closing, feel free to comment further!


feat(label): add support for top label position in groups

What
Closes #
https://github.com/patternfly/react-topology/issues/139
Description

Adds top label position in group node
Type of change

[x] Feature

Screen shots / Gifs for design review
Collapsed Group:

Expanded Groups:

Pipeline task groups:

.

@karthikjeeyar DefaultNode should also be updated to react to the new label positions.

LabelPosition.left shows the label on the bottom.


Use official features to assemble official devcontainers

In order to reduce maintenance and increase the number of users of devcontainer features (from https://github.com/devcontainers/features and https://github.com/devcontainers-contrib/features) it would be great if the provided official images would the base image with a set of features added on top. If some features are missing (like C++), add them.

Hey @mering! Many of our images do utilize Features (one example) where it makes sense.  All of the images in this repo are built with the dev container CLI and the source of truth for the images is the associated devcontainer.json.
Let me know if i'm missing some nuance to your question, but I believe we're already employing your suggestion :)

I would like to assemble a dev container for C++ and Python. While there is a great Python feature which is also used in the Python image, there is none for C++ and the C++ image is installing them manually in the Dockerfile. Same manual installation in the universal image.

Thanks for opening @mering!
We seek to keep the set of images and features we host in the dev containers org relatively slim, to avoid too heavy a maintenance burden, and this way the experts in various languages or toolsets have greater ownership over them and can update them more freely!
As it sounds like this is a request for additional features in the dev containers org, I don't anticipate us taking on many more here.
Please let us know if you have other questions, and thanks for your feedback and thoughts!

to avoid too heavy a maintenance burden

This is exactly why I am proposing this: Instead of having to maintain the same C++ toolchain in multiple images, you would have to maintain it only on one feature.

FYI: there are now community features for CMake and LLVM.


Add python 3 support

hello, could you please port the code to support py3, you have no contributing doc, I can help if you need?

Sure, would love for you to help. Are you up for it?


Suggestion: VerticalLayout with size 0

When using VeritcalLayout with for example MegaTitle / Title1 etc you get both margin from the text element and the gap from VerticalLayout (atm the smallest is 8 px).
It would be nice to have the possility to set gap as 0 while still getting the "column layout behaviour" if elements in the layout have their own margin

Sounds good to me!

I'm thinking a "none" option to reflect css terminology, do you think that works or should we use something more aligned with the other values like "xs", "md" etc? @filiptammergard

On the other hand, size = "none" is a bit misleading. Maybe size = "0" | "zero" or similar would be better

Implemented here: #247

Thanks! Why is the prop named size? You mentioned keeping stuff aligend with css-terminology and for me it would make more sense if the name was gap. I'm just curious, nothing you need to fix

Thanks! Why is the prop named size? You mentioned keeping stuff aligend with css-terminology and for me it would make more sense if the name was gap. I'm just curious, nothing you need to fix

Valid point! This is only named size because that's the name of the same prop in <VerticalSpacing>. But while the prop name makes sense in that component it doesn't really make sense here.
gap="none"|"sm"|... would make sense here.
The only thing we need to consider here is that this would be a breaking change.

Ah okey. I understand. It makes more sense in <VerticalSpacing> to name it size. Otherwise it would be height for vertical and width for horizontal :thinking:
Anyway, don't rename it if it is breaking.  (Maybe we could stack up breaking changes and do a lot of the in the same patch)
Going forward I think, just as @jenseo mentioned it would be nice to try to keep css-terminilogy were it is applicable and make sense

Since it's breaking and since we're not utilizing npm yet (right?), should we go with adding the size = "none" option for now and then when we have better version control in place do the switch from size -> gap? I'm not sure how it's used by the teams at the moment but breaking changes should be easier to introduce when we use the npm repo I guess


Can't pause and enter fullscreen mode on iOS

Hi, in my app when I try to pause video or enter in fullscreen mode the video just make a blink and nothing happens. But in Android it's working fine. I search this issue solution with no luck. Any idea?

I have the same problem, but my pause is working fine.
Sadly no response, the plugin seems to be good.

I solved my problem.
I just didn't noticed that my iOS app didn't had support for other screen modes (landscape).
What I did:
change in ios > runner > info.plist
UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait

to
UISupportedInterfaceOrientations

UIInterfaceOrientationPortrait
UIInterfaceOrientationPortraitUpsideDown
UIInterfaceOrientationLandscapeLeft
UIInterfaceOrientationLandscapeRight

@willvwa Working fine. but the status bar getting half in IOS.


Open Log file with a specific log parser

I have some use-cases where the auto-detection of the log parser is not sufficient. This PR adds a menu entry for all known log parsers, that allows you to open a log file with a given parser.

Would be really useful.


Add cxyfreedom's profile

What type of PR is this? (check all applicable)

[x] 🚀 Added Name
[ ] ✨ Feature
[x] ✅ Joined Community
[ ] 🌟 ed the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
I've updated my Github Profile, including a counter like a divergence meter. Can you add my link to the list?
Add Link of GitHub Profile
https://github.com/cxyfreedom

爱了


TypeError: Wrong number or type of arguments for overloaded function 'Rule_extract'

With Python 3.12, hext.Rule('').extract('') gives the error:
  File "python3.12/site-packages/hext/__init__.py", line 139, in extract
    return _hext.Rule_extract(self, html, max_searches)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Wrong number or type of arguments for overloaded function 'Rule_extract'.
  Possible C/C++ prototypes are:
    Rule::extract(Html const &,std::uint64_t) const
    Rule::extract(Html const &) const

I am of course also getting this error with a more real-life example. At this time I cannot use hext for anything new.

Rule.extract does not accept a string, only hext.Html.
import hext
rule = hext.Rule("")
# (1) Ok, the argument for extract is of type hext.Html
results = rule.extract(hext.Html(""""""))
# (2) Error, the argument for extract is of type string:
results = rule.extract("""""")

If this was possible in a previous version of Hext (≥1.0.0), please let me know, as this would be a breaking change in the API.
The error message is unfortunately very unhelpful, and I will fix that in a future release with #28.
Thank you for creating this issue.

If this was possible in a previous version of Hext (≥1.0.0), please let me know, as this would be a breaking change in the API.

This was not possible in 0.8 (just re-tested to be sure). AFAIK you always needed to pass a Html object.

As an aside, I think there really needs to exist at least one comprehensive page (or tabs) per supported programming language in the documentation. It would contain various necessary examples to train the user to use hext effectively.

I agree and have added another issue for this: #29.


[Bug] GraphQL resolvers authentication

Right now there is no protection on the mutations nor queries, need to make specific ones protected.

Will be added in 1.4


feat(module:i18n): add kk_KZ to i18n

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

No kk_KZ i18n
What is the new behavior?
Add kk_KZ i18n
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@YenbakhtovMaxim  Could you also update docs/i18n.zh-CN.md and docs/i18n.en-US.md?


ryujinx: 1.1.960 -> 1.1.968

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for ryujinx is: Experimental Nintendo Switch Emulator written in C#
meta.homepage for ryujinx is: https://ryujinx.org/
meta.changelog for ryujinx is: https://github.com/Ryujinx/Ryujinx/wiki/Changelog
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.965 with grep in /nix/store/hzxjabaxf7lc5fbfyfyfwnr9l9pbygz5-ryujinx-1.1.965
found 1.1.965 in filename of file in /nix/store/hzxjabaxf7lc5fbfyfyfwnr9l9pbygz5-ryujinx-1.1.965

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
ryujinx

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hzxjabaxf7lc5fbfyfyfwnr9l9pbygz5-ryujinx-1.1.965 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ryujinx https://github.com/r-ryantm/nixpkgs/archive/76c693def0cef04fd2ad767c1182fe01f5c0aaab.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hzxjabaxf7lc5fbfyfyfwnr9l9pbygz5-ryujinx-1.1.965
ls -la /nix/store/hzxjabaxf7lc5fbfyfyfwnr9l9pbygz5-ryujinx-1.1.965/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ryujinx

Maintainer pings
cc @IvarWithoutBones @06kellyjac for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for ryujinx is: Experimental Nintendo Switch Emulator written in C#
meta.homepage for ryujinx is: https://ryujinx.org/
meta.changelog for ryujinx is: https://github.com/Ryujinx/Ryujinx/wiki/Changelog
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.968 with grep in /nix/store/b5cppzwqanxdk3dds4yxlmkwfd8m32xa-ryujinx-1.1.968
found 1.1.968 in filename of file in /nix/store/b5cppzwqanxdk3dds4yxlmkwfd8m32xa-ryujinx-1.1.968

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
ryujinx

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b5cppzwqanxdk3dds4yxlmkwfd8m32xa-ryujinx-1.1.968 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ryujinx https://github.com/r-ryantm/nixpkgs/archive/1356b2292ba5572c70fd5fdb4a54009fc702fff7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b5cppzwqanxdk3dds4yxlmkwfd8m32xa-ryujinx-1.1.968
ls -la /nix/store/b5cppzwqanxdk3dds4yxlmkwfd8m32xa-ryujinx-1.1.968/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ryujinx

Maintainer pings
cc @IvarWithoutBones @06kellyjac for testing.


Improve count with intent to add to CI

Improve ./mfc.sh count with intent to add to CI. Removes comment lines from count but includes openacc directives.

Really want this to print the line count different between master and current

Really want this to print the line count different between master and current.
Example https://github.com/tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

Really want this to print the line count different between master and current.
Example tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

I would like to know how many lines are being added or subtracted via a PR. I see some PRs where it's not immediately clear that a refactor actually reduces line count. The GitHub PR linecount diff includes all sorts of things that we don't care about.

Really want this to print the line count different between master and current.
Example tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

I would like to know how many lines are being added or subtracted via a PR. I see some PRs where it's not immediately clear that a refactor actually reduces line count. The GitHub PR linecount diff includes all sorts of things that we don't care about.

I see. For the specific case where you make a code-only refactor, you can subtract the + and - lines as shown on the PR's Github page since when you only modify a line, it counts as both a deletion and an addition. I just realized that things like adding (not changing) golden files do skew results, although they don't have many lines.

Really want this to print the line count different between master and current.
Example tinygrad/tinygrad/actions/runs/7306212421/workflow?pr=2886

Do you have a use-case in mind?

I would like to know how many lines are being added or subtracted via a PR. I see some PRs where it's not immediately clear that a refactor actually reduces line count. The GitHub PR linecount diff includes all sorts of things that we don't care about.

I see. For the specific case where you make a code-only refactor, you can subtract the + and - lines as shown on the PR's Github page since when you only modify a line, it counts as both a deletion and an addition. I just realized that things like adding (not changing) golden files do skew results, although they don't have many lines.

Yes this mostly does the job. Though I figure the CI mechanisms used for this would also be useful for other presumably more important things.

@henryleberre I think this is the best this PR is going to get without more serious effort. The commit-bot is a no-go as you noticed. I was thinking that one could add an argument to ./mfc.sh count that allows a diff between two versions of MFC/src/* but this seems like more work/tricks than I can muster at the moment (I don't quite understand how it's going through and making those nice line count tables to begin with).


CI should test clang + libstdc++, newer compilers

libstdc++ is the STL used on most linux targets, and clang will default to libstdc++ on practically all of them.
At the same time, incompatibilities may be more common particularly around new language features, as libstdc++ is developed against the language support of g++ foremost - see e.g. https://github.com/llvm/llvm-project/issues/54052 for a recent example.
I would propose adding a new CI workflow based on an up to date distro (my goto for this is fedora) to test the latest gcc and clang versions - the stock Ubuntu image offered by Github is and will always be outdated since it's on a 2 year LTS schedule.
Is that roughly to your liking? I would work on a PR if so.

I regularly test on Linux + GCC 13 and Linux + GCC 12 locally; this is how all the development occurs.  CI handles older GCCs.  I definitely would like to have coverage for Clang 15 and Clang 16, on Linux and elsewhere.  So yes, that would be very much to my liking. :)  I am currently using Github actions and Drone testing provided by the C++ Alliance to Boost repos, and neither one covers recent Clangs as far as I can tell.


After pressing "Done" on iOS in landscape orientation on iPhone 6S, the view is blank/white

Bit of a strange bug here. I've tested it across a couple of devices here and can only reproduce it on an iPhone 6S running iOS 11.
If you use this plugin to open and close a page in portrait orientation, it works fine. If you try it in landscape it loads the page, and when you return to the view back with your main application in it is completely white.
If you wait for a couple of seconds or trigger an orientation change it then catches up and renders correctly. However, if you start interacting with the blank view (in my circumstance) you get a blank white scrollable page which is the width of the height of the view (something to do with a standard portrait sized webview perhaps?) and from that point it won't re-render. You then have to go back to the home screen and re-enter the app for it to then render correctly (Triggering a pause/resume event).
I've had other reports of the same issue happening from users on the iPad Pro, not sure what OS version or orientation the device was held in.

It happens exactly as described above on an iPad Pro running 10.3.3 as well.

It's a bit of a hack, but utilizing the cordoba-plugin-screen-orientation plugin, I was able to force my way through the issue by plugging the following into Eddy's example code:
						// this success handler will be invoked for the lifecycle events 'opened', 'loaded' and 'closed' 						function(result) { 							if (result.event === 'opened') { 								// console.log('opened'); 							} else if (result.event === 'loaded') { 								// console.log('loaded'); 							} else if (result.event === 'closed') { 								// console.log('closed'); 								setTimeout( function() { 									currentOrientation = screen.orientation.type; 									if ( currentOrientation.indexOf("landscape") >= 0 ) { 										screen.orientation.lock('portrait'); 										screen.orientation.lock('landscape'); 									} else { 										screen.orientation.lock('landscape'); 										screen.orientation.lock('portrait'); 									} 									screen.orientation.unlock(); 								}, 500); 							} 						},

Hey @dtc7240 thanks for your input! I think I have come across a similar issue but with another plugin. Check out this thread: https://issues.apache.org/jira/browse/CB-12141

Hey @CookieCookson, thanks a million!!  By the time I saw your response 6 days later and checked the statusbar issue you linked above, that issue had been resolved by statusbar v2.4.0 just 22hrs earlier.  I popped statusbar 2.4.0 in and the issue from this thread is now gone!!!!  No more silly flopping the screen orientation back and forth in front of the user ... thank you so much for the research and the heads up!
And thanks as always to @EddyVerbruggen for EVERYTHING he does in the Cordova community!!

@dtc7240 Sounds great! I'll give it a go here and update the thread if it solves things my end.

I can confirm that upgrading to<EMAIL_ADDRESS>solves the issue above 🎉


Publish to npm

Hi! Thanks for the lib. It would be extremely useful to publish it into npm. Here is the little instruction: https://zellwk.com/blog/publish-to-npm/
In 2 words it's just npm publish being authorized.

Oh, sorry. It's already there.. decided that it's not after looking at readme :)


Added support to both Old and new APIs

Fixes #1759
Link to review the changes: https://openeveweb.herokuapp.com/

@mariobehling @geekyd please review.

Works well for me.
@geekyd What do you think?

@geekyd done but the tests are failing due to saucelabs timeout issue on brokenLinks count test, I removed that test and the travis is passing.Please check https://travis-ci.org/fossasia/open-event-webapp/builds/351635906?utm_source=github_status&utm_medium=notification
So should I keep that test or remove that from the test suite?

@agbilotia1998 The test is passing but there are a few codacy issues still pending. Please have a look at them

@geekyd the pending codacy issues are related to API keys we have used like 'license_url' those cannot be changed.Also, the tests are passing after removing the check broken links in navbar and footer test.

@geekyd I am merging this as work in progress. Let's work with everyone and get things merged faster to keep the flow.


Allow hot file host to be configure

My PR was closed, opening an issue to explain my issue further.
adding
server: {
        https: true,
        host: 'foo.test',
        port: '8080',
}

does not resolve the host correctly. resolveDevServerUrl returns a hard coded ${protocol}://${host}:${port}. It resolves to https://[::]:8080 not https://foo.test:8080, but even then if I wanted to set host: 'foo.test', to host: '', it will still resolve to 'https://[::]:8080' not ''.
Even if I add host: 'foo.test', to my vite config and it did resolve correctly, I would still be running into an issue. I have vite on a reverse proxy on a different port, the vite server is listening on http://localhost:8080 (not publicly accessible to the internet) and but the public url is https://example.com, I am forwarding everything from https://example.com/resources*, https://example.com/@vite*, etc. to the vite server, but because the I cant override the hotfile. It tries to load from https://[::]:8080 witch I can not access publicly. There should be a way to override the hotfile host (even if undocumented) for edge cases like this.
Just to break it down a bit more:
I want to load resources/main.ts from the vite server, https://example.com/resources/main.ts forwards to http://localhost:8080/resources/main.ts (via a reverse proxy) the hotfile says the vite host is on https://[::]:8080, https://[::]:8080 can not be accessed from the internet, it throws a 404 the site does not load. If I set the hot file to '' it will now load from https://example.com/resources/main.ts.
Now there is an argument to "Don't run a dev server exposed to the internet" but in my case I am actually running this on an intranet for clients to get fast feedback on small incremental changes to the front end design.

@nurdism thanks for following up about this after I closed the PR.
I'm unable to replicate this on my local machine, so I might need some additional information for you about your setup.
For example, running the following script I get the expected contents in the hot file that I mentioned.
composer create-project laravel/laravel vite-test \
  && cd vite-test \
  && npm install \
  && echo "import { defineConfig } from 'vite';
import laravel from 'laravel-vite-plugin';

export default defineConfig({
    plugins: [
        laravel({
            input: ['resources/css/app.css', 'resources/js/app.js'],
            refresh: true,
        }),
    ],
    server: {
        https: true,
        host: 'foo.test',
        port: '8080',
    }
});" > vite.config.js \
  && npm run dev

The output in my console...

and the contents of the hot file...

@timacdonald I'm actually getting an error from vite when I attempt to run your example
error when starting dev server:
Error: getaddrinfo ENOTFOUND foo.test
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:109:26)

After looking at the vite docs, the host option is supposed to resolve to an ip address:

Specify which IP addresses the server should listen on. Set this to <IP_ADDRESS> or true to listen on all addresses, including LAN and public addresses.

not a domain, a better option to grab from would be server.origin

Looking at the plugin again, I see you are overriding the origin and transforming it later. I don't thing this is a very good approach and now the underlying software (vite) does not preform as intended. I'm going to experiment with this and see if I can come up with a workable solution, is there a particular reason the origin has to be so strictly enforced to ${protocol}://${host}:${port} and is being overridden like this?

@nurdism you should just switch foo.test with whatever IP / domain you want the server to listen on. foo.test works on my machine because I have it configured to work with .test domains.
That functionality you have linked to is the essence of the Laravel plugin. Without it, the Laravel integration simply would not work across the boundaries that exists between the PHP process and the Node process.


MGMT-13573: Propagate agent's spec sync error to status

backport of https://github.com/openshift-assisted/assisted-ui-lib/pull/1974

hi all,
how is this propagated if using AI with Kubernetes API (so working together with ACM)?


Add new timings and configuration options to startup script

@DrewScoggins PTAL

test ci please

I have kicked off a CI run to make sure this goes through in the CI.  If that works LGTM.

Run looks good and it uploaded correctly.  I saw one issue during crossgen though.    All rights reserved. 15:50:02  15:50:02 Error: Could not load file or assembly 'System.Data.SqlClient, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. (Exception from HRESULT: 0x80070002) 15:50:02 Error compiling C:\j\workspace\perf_JitBench---e5fbb0f7\JitBench\src\MusicStore\bin\Release\netcoreapp20\publish\Microsoft.EntityFrameworkCore.SqlServer.dll: Could not find or load a specific file. (Exception from HRESULT: 0x80131621) 15:50:02 Error: compilation failed for "C:\j\workspace\perf_JitBench---e5fbb0f7\JitBench\src\MusicStore\bin\Release\netcoreapp20\publish\Microsoft.EntityFrameworkCore.SqlServer.dll" (0x80131621) 15:50:02 crossgen.exe failed.

This has been fixed in the aspnet repo.  @davmason is going to rebase that onto his dev branch and it will fix this.


docs: temporarily disable intersphinx integration with SciPy

Summary
See also scipy/scipy#17316
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.825%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
643

Relevant Lines:
848

💛  - Coveralls


Occures TypeError when trying to dismiss a notiication.

JS Console log
angular.js:13283 TypeError: Cannot read property 'fadeOut' of null
at Object.dismiss (ng-notify.js:137)
at dismiss (ng-notify.js:552)
at Object.dismiss (ng-notify.js:620)
at jkfe.js:255
at m.$digest (angular.js:16728)
at m.$apply (angular.js:16992)
at HTMLHtmlElement. (angular.js:13032)
at HTMLHtmlElement.dispatch (jquery.min.js:3)
at HTMLHtmlElement.r.handle (jquery.min.js:3)

Also encountering this error. My alert pops up and dismisses as expected, however any subsequent page navigation will produce this error. My best guess is that ng-notify incorrectly thinks it is still open, and fails when it attempts to close the alert.


Is it possible to load fontawesome from FXML with SVGGlyph

I saw this: https://github.com/jfoenixadmin/JFoenix/issues/169#issuecomment-251038144.
I want to load an icon from FXML instead of from Controller Class.
But you're using <FontawesomeIconView> in your main demo.
So is it possible to do that without adding Fontawesomefx?

Unlike fontawesome, SVGGlyph requires the svg path of the icon. So no, you can not use SVGGlyph to load font awesome icons. For example, creating a decrement arrow using SVGGlyph:
SVGGlyph glyph = new SVGGlyph("M298 598l214-214 214 214h-428z");
Currently you can create SVGGlyph in FXML, however the svg path should be set through css using "-fx-shape" property. Will update SVGGlyph to allow setting the path in FXML too.


feat(docker): secure Dockerfile

This PR tries to make the Dockerfile slightly more secure by preventing the running user from changing sources (by not chowning files node:node in the first place.

As a side note - this will prevent any changes to the fs in the image, so if we depend on that being possible (like types, migrations or lock files) we need to account for that.

As a side note - this will prevent any changes to the fs in the image, so if we depend on that being possible (like types, migrations or lock files) we need to account for that.

I think this is fine. We actually copy the app in $APP_HOME(i.e. /opt/app) then we chown node:node ..
This is OK because Dockerfiles using this image as base are supposed to copy the platformatic app in /opt/app, and here we need to have write permissions (e.g. for schema lock files) but this is up to the user of the image.
We don't need to change the fs where platformatic is actually installed (PLT_HOME=$HOME/platformatic/)


removes extra colon delimiter before componentid

without this change, the VEX.GenerateCanonicalID function produces a string like:

:1671745003::pkg:oci/example@sha256:47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c

without this change, the VEX.GenerateCanonicalID function produces a string like:

1671745003:pkg:oci/example@sha256:47fed8868b46b060efb8699dc40e981a0c785650223e03602d8c4493fc75b68c

since the string is hashed, the extra colon delimiter changes the hash in a meaningful way.
the reason for this behavior is that the cstringFromComponent function produces a string with a leading colon, and those strings were then joined into a string with another leading colon.

will defer to @puerco


Add GeoJSON endpoint

We would like to have an API like https://stats.storjshare.io/nodes_geo.json but using the GeoJSON format.
AC:

Refactor nodes_geo.json  data to GeoJSON format

Notes:
Example on how to create GeoJSON output: https://gist.github.com/kaloyan-raev/c3dd95f2347a8d49f882b5576508f294

Currently, https://stats.storjshare.io/nodes_geo.json reports the coordinates separately for every satellite. It is best to have a single valid GeoJSON object - perhaps, one aggregated for all satellites.
This way, we could load it directly to compatible tools with a direct URL:
https://geojson.io/#data=data:text/x-url,http%3A%2F%2Fstats.storjshare.io%2Fnodes_geo.json
Note, to make the above URL work, we also need to enable CORS on https://stats.storjshare.io.


Technical Debt Tracker

This issue is a tracker for technical debt accumulated after IBC 1.0 for the purpose of maintaining backward compatibility.

[x] Indirect Iteration Keys needed for efficient iteration while not breaking ICS-24 paths which are inefficient for iteration: https://github.com/cosmos/ibc-go/pull/125
[x] Maintaining FrozenHeight in clientState even though it will not be used except as a boolean (non-zero vs zero height): https://github.com/cosmos/ibc-go/pull/141
[x] Maintaining DEPRECATED packet_data attribute, users should switch to packet_data_hex: https://github.com/cosmos/ibc-go/pull/144
[x] IBC client/consensus states for upgrades are set in the Upgrade Keeper
[x] v0.42.0 SDK to ibc-go v1.0.0 migration code ie legacy/v100 ref: #205
[x] solo machine bypass for timestamp check #214

tendermint#6403 may influence which attribute should be deprecated between packet_data and packet_data_hex. We can discuss with relayers which is preferred when the time comes

All the PRs mentioned above haven been merged and I believe the upgrade keeper is already used to set client/consensus states. Thus I will close the issue now.

I believe the upgrade keeper is already used to set client/consensus states.

This is correct. The original issue is a bit hard to follow, but the intention was to note technical debt, so the fact that the client/consensus states being set by the upgrade keeper is actually a problem. Ideally they would exist under the client keeper.
I think a couple of the other issues mentioned are not addressed:

frozen height is still maintained in the client state? (it should be a boolean)
duplicate event emission for packet_data is still maintained (should be removed)
Indirect Iteration Keys needed for efficient iteration while not breaking ICS-24 paths which are inefficient for iteration (we should upgrade connections to allow for efficient iteration of consensus keys, thus making the indirect iteration keys useless)


Add conductor application button for forum popup

Adds an Apply Now button to the Conductor Program page under the Ready to Become a Conductor? section, clicking this button will popup a tally forum where users can apply!

LGTM!


router.transitionTo ignores query string

Say we are at url: "http:/site.com/index/?a=1"
This code will fail
var path = this.context.router.getCurrentPath();
this.context.router.transitionTo(path);

Resulting url will be like  "http:/site.com/index/a=1" which is not right.

#1148

duplicate ^
thanks


QoL changes to genTestCert.go

Howdy folks. The following is a little bit of house cleaning to help improve test data generation. This past weekend I found myself spending far more time carefully generating certs than actually working on lints, so this change addresses the three biggest issues I had.

Generating the cert, creating the file by hand, copying the data into the file, and pointing the test to correct file is cumbersome.
Generating test data for not effective date is painful without access to the util package.
newLeaf was too far down into the file, leading to excessive scanning up and down.

As such, this change...

Created a new facility for automatically dumping generated results into zlint/v3/testdata/<NAME>.pem
Imported ZLint itself into the command (relative to the working directory rather than to the github repo) so that the dates under util can be easily utilized to generate test certs with dates that exercise requirement dates more precisely.
Moved newLeaf to the top of the file. Generating leaf certificates is the most common use case and should be at the top.

Addresses #665

@cardonator could I solicit for a hand reviewing some of these quality-of-life changes to the repo? This one is a low-risk, low-hanging fruit, that just helps generate test data more easily. Although we have have several more (most notably a feature for configuring individual lints) that are in danger of dying on the vine so I may ask for help taking a look at those as well.


Inconsistent language usage

I recently encountered the following page: https://stasemsoft.github.io/softwarematerial/docs/basic/methoden/training_methodmarathon
and I strongly disagree with the content, the language use (en, nl) is inconsistent, the first few 'assignments' ask the students to write function names in English and then the parameter of this function is defined in Dutch. This occurs multiple times and even switches a few times. The use of roman numerals is also confusing and harder to reference back to (why not just use numbers?)
Even for start semester students, learning to write code in dutch should be discouraged since this does not match the real world at all or the company in question is very, very, old-fashion. I also don't see the purpose of the quotes, it doesn't really help the student.
Kind regards,
Hugo

Dear Hugo,
Thanks for your feedback! I partly agree with you: in general we should not mix EN and NL: be consistent within one piece of text. These texts come from different sources, were put together. Everyone can create a pull request to improve. When a teacher looks to improve a text they try to improve this also. So ... in time ... (yes, that can take a long time...) it will get better. Please feel free to create a pull request to suggest specific improvements!


CI: investigate versioning improvements

[ ] Should we start using releases / labels to flag official build versions?
[ ] Investigate: can we use releases / labels to trigger official version package in nuget?
[ ] Investigate: Git versioning: should we adopt this if so how does it work

Done


Improve CI caching

[x] Add Jest caching (ref. https://github.com/simple-icons/simple-icons/pull/5912)
[x] Add restore-keys for build cache

@developStorm, any thoughs no this? :slightly_smiling_face:


handleRedirectObservable returns only the HANDLE_REDIRECT_END when using the redirect url from a new tab.

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.22.1
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.1.2
Public or Confidential Client?
Public
Description
We have the MSAL login with the redirect option implemented in angular, which is working fine if everything is happening in the same tab. but if we copy the redirected url to a new tab and login using valid credentials, handleRedirectObservable method only returns the HANDLE_REDIRECT_END without any token info.
and when ever we invoke the login function again manually we get the login success as Normal.
I want user to get the login success as normal event if they uses the url in a new tab.
MSAL Configuration
auth: {
        clientId: clientId,
        authority: "B2C_1A_SIGNUP_SIGNIN",
        redirectUri: '/',
        navigateToLoginRequestUrl: false
    },
    cache: {
        cacheLocation: "LocalStoarage",
        storeAuthStateInCookie: false
    }

Relevant Code Snippets
No response
Identity Provider
None
Source
External (Customer)

@HansakaSS I'm not sure I understand your scenario. Can you give me a step by step?

@tnorling thanks for the reply.
yes. whenever we use the redirect option to login, and after we redirected to the login page and we copy the page url to a new tab and continue the login i can face this issue.
it redirect me back to my application but i don't have the success login. also i can see the state and client_info on the address after the redirect back to the application.

invoke redirect login
from the login page copy the URL to a new tab
login using the valid credentials
getting redirect back to the  application but I'm not getting the msal:loginSuccess. only gets the msal:handleRedirectEnd from handleRedirectObservable.

This is not a supported scenario. Login must be initiated and completed from within the same session (tab). Can you tell me a little more about why you need to open the login page in a new tab?

thanks for the clarification. Its not that we are opening the login in a new tab. problem occurs if we use a password vault to log in. for example zoho.

Its not that we are opening the login in a new tab.

I'm a bit confused by this statement because this seems to conflict what you stated in your previous comment:

from the login page copy the URL to a new tab

Can you please clarify?

problem occurs if we use a password vault to log in. for example zoho.

Can you please go into more detail about this? I don't understand how this relates.


Fix Array bridges error && update swift3 syntax

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

#36

Thanka @zhongwuzw. There's some legit unit test failures happening with your PR:
❌  /Users/travis/build/uber/signals-ios/UberSignalsTests/SwiftTests.swift:112:44: cannot call value of non-function type '((String!, NSNumber!) -> Void)!'
        observer.onSwiftDoubleSignal.fire()("1", NSNumber(value: 2))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
** BUILD FAILED **

@artman , I have been updated to Swift3.

@zhongwuzw, with that change 8.x simulators aren't available anymore. Mind changing the .travis.config and just remove the 8.x simulators for CI to pass this PR? Thanks!

@artman , I update the travis.yml to remove iOS8.x

Thanks!


bottomsheet shows only partial layout

I have a regular LinearLayout with a recycler view and a button below it. The problem is
when I show bottomsheet using myBottomSheet.showWithSheetView(sheet) it shows recyclerview completely but the button is only partially visible.
I have to pull the bottom sheet up to see the button completely. I don't want this bottomsheet behaviour. I want bottomsheet to fully show all elements in my layout.
Can anyone suggest a solution?

You can set how far the bottomsheet peeks in pixels by calling setPeekSheetTranslation. You can also trigger the sheet to open completely by calling expandSheet() right after showWithSheet.


fix(ci): add build script to fix latest builds

this should fix our latest build.
test this: no need to test, the stage was successful and DC/OS PR is (was, if we merge anything else) green 👍
Successful stage: https://jenkins.mesosphere.com/service/jenkins/blue/organizations/jenkins/frontend%2Fdcos-ui-oss-pipeline/detail/jgieseke%2Fadd-build-to-latest/2/pipeline/77
PR: https://github.com/dcos/dcos/pull/2741/files

🤞


EDC - Concept of authentication delegation in the management api

Description
As an EDC operator,
I want to delegate the validation of the authentication information for the management api to an external identity provider
The current practice of managing an api-key within the EDC has the disadvantage, especially for a EDC aaS provider, that many different EDC services manage their own key, which makes them in principle an identity provider. This contradicts the general strategy to reduce the number of identity providers ideally to one. The reason for that is, that processes like key rotation are simplified to one service. In addition, security audits typically involve to a large degree the identity providers and check the configuration of those. With many EDC services running, this increases the efforts for such audits.

[ ] Create a list of Catena-X requirements in regard of an external identity provider
[ ] Define an implementation plan that describes the final state of the development and steps that allows to add this feature to the EDC as non-breaking changes
[ ] Prepare follow up tasks to create the features

Current ideas (as input):

Delegate the validation of the existing api-key to an external identity provider like Keycloak
Use an OAuth based authentication mechanism

Impact
In general, the outcome of this feature is a concept for later development. Therefore, this is not a breaking change by default. Nonetheless, the idea is to make the changes in steps, that prevent breaking changes for each step, but require throughout the process changes of an operator in order to get to the final state of the implementation.
Additional information

[x] I'm willing to contribute to this feature

Requirements

The connector does not manage authentication information for the management API, instead it relies on an external service to provide such information.
Ideally, the check, whether provided authentication information is valid is done by an external service.
The external service supported should be a standard tooling that supports features like token rotation, authentication renewal out of the box.
The connector must not be aware of changes in authentication information, i.e., if, e.g., a token is renewed, the complete process is handled outside of the connector.
The usage of an external service should be configurable, it should still be possible to use the EDC as today.
Ideally, the switch to use an external service should be transparent to an external user of the management api.

Hello @lgblaumeiser
Since the feature is a 24.08 feature and the development phase is coming to an end, we need a status on the feature.

[ ] Currently you are assigned (Responsible) → Is this correct? If not, please assign the correct contact person
[ ] Please check whether the status (backlog, work in progress ...) is set correctly
[ ] Please check whether there is an assignment to a committee or expert group (supported-by) to be found on the board
[ ] Please comment on the current status of the feature
[ ] Are all SubTasks (issues from other repositories that deal with the feature) linked? → The easiest way is to mention the feature here in the issue (via the ID) so we can see which teams/repositories are involved.

If you need any clarification, please get in touch, thank you very much.
Stephan

2024-06-11: Requirements are identified, discussion has started.

Concept and Implementation plan documented here: https://github.com/eclipse-edc/Connector/issues/4261

Feature for Catena-X planning: https://github.com/eclipse-tractusx/sig-release/issues/707


[18.03 backport] Rolling back the port configs if failed to programIngress() (ENGCORE-914)

This is a backport of #2069, which was cherry-picked from the 17.06 backport (https://github.com/docker/libnetwork/pull/2381).

git cherry-pick -sx 2ce42422aba7b17c6822b

Clean cherry-pick (from 17.06), no issues.

@dani-docker @arkodg @euanh PTAL

LGTM 👍

@selansen PTAL


build webpack error

I'm using sample project, and when I run yarn gatsby develop it appears this error

@phucledien Thanks for raising the issue. I am working on a fix.

@phucledien Not sure why this is happening. I tried updating the package name in npm to gatsby-greenboard and now it is working for that package name. For now, you can use gatsby-greenboard package for this. I need some time to figure out why the name is causing the error.
I have updated the docs.

ok, thank you very much  👍


E2E tests: dump failure information

Dump relevant information when a test fails.

lgtm. I validated the reports locally on my end.


Add a simple function to install upstream dependencies without RStudio addin

Yesterday I could not use RStudio, so tried to use staged dependencies just from the R console. However I did not find the function to call quickly to install upstream dependencies. Also looking at the output from the addin:

it seems like there is no quick simple function call that one can use.
Generally I would recommend to get a bit more independent of the RStudio IDE so that also users from other IDEs or console can use staged.dependencies nicely.

staged.dependencies is independent of RStudio IDE. They provide functions to do everything the plugin can do and more.
Here are the docs: https://openpharma.github.io/staged.dependencies/reference/index.html
And here's my wrapper around staged.deps that I use on a daily basis in VSCode:
staged.install <- function(package) {
  staged.dependencies::install_deps(staged.dependencies::dependency_table(package))
}

where package is the system file path to the package being installed.

Thanks @kpagacz ! That is a nice start. I would suggest then to add something like staged.install() directly to the package.


IntoStream for vec

This WIP PR implements IntoStream for Vec, adding three new stream types for vec: vec::Stream, vec::IntoStream, vec::StreamMut. We may want to extend this patch to also cover slice, because if we'd follow std, vec should use Stream and StreamMut types from slice::*.
Ref #129.
cc/ @stjepang @sunjay
Error
I'm currently blocked on a problem with our bounds. Namely we do:
impl<I: Stream + Send> IntoStream for I {
    type Item = I::Item;
    type IntoStream = I;

    #[inline]
    fn into_stream(self) -> I {
        self
    }
}

Which is causing the following error to show up:

I'm confused why this is happening, as std::iter has a similar impl. I'm worried this is some kind of orphan rule thing, but I don't quite get it. Getting help with this would be greatly appreciated!

@yoshuawuyts is this a specialization problem? e.g. https://github.com/rust-lang/rust/issues/31844 ?
Is this because Vec<T> could be Stream, so there would be two implementations, which means both of these impls would match (for example):
  --> src/vec/into_stream.rs:10:1
   |
10 | impl<T: Send> crate::stream::IntoStream for Vec<T> {

  ::: src/stream/into_stream.rs:28:1
   |
28 | impl<I: Stream + Send> IntoStream for I {

okay, I'm very confused by this. Rayon has a similar impl as we do, and they're not having the same problem. It seems like this may be something rather nuanced.

From conversations over chat, the next thing we should test is if it matters that we're using a foreign trait as part of the trait bound. Rayon doesn't do this, and we should check if only to cross it off.

The thing that confuses me about this is that the following code compiles:
trait IntoStream {}
trait Stream {}

impl<T: Send> IntoStream for Vec<T> {}
impl<T: Stream + Send> IntoStream for T {}

These are exactly the same impls as what you seem to have. This is also exactly the same as what rayon has and it works for them.
This is probably not the issue at all, but have you tried removing the crate::stream prefixes from IntoStream? I'm getting into the "it's a compiler bug" mindset and wondering if that will fix it for some odd reason. If that doesn't work (and it shouldn't!) I can probably look into this more in a day or so and see if I can get it to work.

This behavior is not a bug. For example, if Vec comes to implement futures_core::stream::Stream, there is a conflict, so it is correct that this is a compilation error.
Refs: https://github.com/rust-lang/rust/pull/43426

Oh I didn't realize that Stream isn't defined in this crate. That's my bad then. Yes this isn't a bug.

Even when working around this by making the bound our own Stream type in #214, this rule still seems to be triggered (which is good!) but bad news for us. @taiki-e is entirely right, and if we want to keep compat out of the box between async-std and futures-rs then the only way to add this feature is by moving the implementation to futures-rs; possibly even futures-core because that is where the Stream trait is defined.
Conversation about this has been happening in https://github.com/rust-lang-nursery/futures-rs/issues/1879, but perhaps we should have a dedicated issue for this?

Closing this PR because it isn't possible for all the reasons @taiki-e has listed. I've posted a summary of this PR in the streams tracking issue: https://github.com/async-rs/async-std/issues/129#issuecomment-533093186.
My hope is that we can add IntoStream to futures-core so this can be possible. Thanks all!


[CTA - Card, type Video] Web Component:  Prod QA testing of change that allows poster image to be turned off

User Story

As a [user role below]:
developer using the ibm.com Library CTA - Card, type Video

I need to:
have a version of the component that has been tested for accessibility compliance as well as on multiple browsers and platforms

so that I can:
be confident that my ibm.com web site users will have a good experience

Additional information

Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile
Mobile iOS versions: 13.1, 13.3 and 14
Mobile Android versions: 9.0 and 10
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, QQ Browser
Accessibility testing guidance
Accessibility Checklist
Creating a QA bug
See the Epic (#6413 ) for the Design and Functional specs information
Web Components Dev issue (#7063 )
Once development is finished the updated code is available in the Web Components Canary Environment for testing.
React canary environment
** Web Components Wrapper test env URL**

Acceptance criteria

[ ] Accessibility testing is complete.  Component is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded

Closed, Prod QA not needed.

@Praveen-sr This component is ready to be tested.
cc:  @IgnacioBecerra

Started Prod QA testing.

Prod QA testing finished.  Closing.


Issue #201: Improve recently merged suites

Also, reorder test cases in one_node_two_pods_ldpreload_iperf.
Signed-off-by: Vratko Polak<EMAIL_ADDRESS>

Coverage increased (+0.05%) to 61.42% when pulling f9531cc04906d4a61e79e7693b3760cfd3420d87 on vrpolakatcisco:contiv201_200 into c338227a1175ec10438b23e65b9a7e552a7742ff on contiv:master.

More edits are needed to avoid getting stuck.


Added a decode+resize benchmark and cuda decoder

Make the generate_readme_data.py script not regenerate the videos when the parent dir exists.
Add a benchmark column for "dataloader style" benchmark that measures throughput of a batch of videos that are decoded and resized.
Add a bar for cuda decoder which is nothing but torchcodec_public with device="cuda"

Benchmark results show cuda decoder is faster than CPU decoder at dataloader style benchmark.

Ideally we would also update the README description, as once this PR is merged, the chart is live. But we can also do that on a follow-up. That is, a 22-core Linux system with whatever kind of GPU.

I tweaked the README.md file as well. Later on we can put the machine info in the chart itself so this doesn't have to be kept manually up-to-date.


Type load error on start

I just pulled master, built, ran, and I get this exception:
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
at System.Reflection.RuntimeAssembly.get_DefinedTypes()"
It happens on line 91 in RoslynHost.cs
The content of LoaderExceptions is:
Could not load type 'Roslyn.Utilities.PooledObject`1' from assembly 'Microsoft.CodeAnalysis.Workspaces, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.

Hmm, I did a clean pull and didn't get that. Can anyone else verify this?

Cannot reproduce the issue when running latest master from VS 15.7.1 (rebuilt + tested debug and release builds)

@aelij @paralaxsd I'll give it another try. I'm on VS 15.7.0

Still getting it, although I also encountered this issue:
No default constructor found for type 'RoslynPad.MainWindow'. You can use the Arguments or FactoryMethod directives to construct this type.
at start. I recall getting this last time as well. I just made the MainWindow ctor public to get around it.
What I don't understand is why the internal ctor works for you guys.

I deleted my repo and started over. This time it built and started fine. No clue..
Thanks!

I am getting the same issue, I was told to get a clean clone but isnt that just cloning it into Visual Studio or am I missing something?

@PtrStruct Delete your entire source tree and start over.

I created a new clone of the master branch.  The build succeeds for all 14 projects with 3 warnings:  RoslynPad.Host32, RoslynPad.Host64, RoslynPad; Found conflicts between different versions of "System.Collections.Immutable" that could not be resolved.
When I try to run I get System.Reflection.ReflectionTypeLoadException
HResult=0x80131602
Message=Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
Source=mscorlib
StackTrace:
at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
at System.Reflection.RuntimeAssembly.get_DefinedTypes()
at RoslynPad.Roslyn.RoslynHost.<>c.<.ctor>b__20_0(Assembly x) in F:\Users\passp\Source\Repos\RoslynPadMaster\src\RoslynPad.Roslyn\RoslynHost.cs:line 91
at System.Linq.Enumerable.d__172.MoveNext()    at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext()
at System.Composition.TypedParts.TypedPartExportDescriptorProvider..ctor(IEnumerable1 types, AttributedModelProvider attributeContext)    at System.Composition.Hosting.ContainerConfiguration.CreateContainer()    at RoslynPad.Roslyn.RoslynHost..ctor(NuGetConfiguration nuGetConfiguration, IEnumerable1 additionalAssemblies, RoslynHostReferences references) in F:\Users\passp\Source\Repos\RoslynPadMaster\src\RoslynPad.Roslyn\RoslynHost.cs:line 94
at RoslynPad.UI.MainViewModelBase.b__37_0() in F:\Users\passp\Source\Repos\RoslynPadMaster\src\RoslynPad.Common.UI\ViewModels\MainViewModelBase.cs:line 117
at System.Threading.Tasks.Task`1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()

I also performed Tools | Options | NuGet Package Manager | General | Clear All NuGet Cache(s). Same result: "Unable to load one or more of the requested types..."


Improve adblock check with pixel bait

This one adds pixel bait for adblockers. Checking for its visibility can detect some blockers which let advertising.js load.
Still, no match for µBlock (:heart:)

Seems legit b