Use shiki for code highlight

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Motivation
Have you guys ever considered switching to Shiki for code highlight, instead of Prism?
I find Shiki a lot nicer, with much better grammars that are able to highlight much more code than Prism does.
Also, Shiki is being actively maintained, while Prism seems a little bit abandoned. However, even if Shiki wasn't being maintained, its themes would never stop improving since they are taken from VS Code anyway.
Here is a quick comparison I did:
Prism (dracula - the default theme from Docusaurus):

Shiki (dracula):

PS: I'm aware of docusaurus-preset-shiki-twoslash, and that's what I used for the example above (https://github.com/felipecrs/shiki-docusaurus-test). This is to suggest a better default for the project as a whole.
Maybe it's a good breaking change candidate for Docusaurus v3?
Self-service

[ ] I'd be willing to do some initial work on this proposal myself.

Several things, based on my experience with Shiki, do correct me if I'm wrong:

Shiki is server-side and generates static markup during Markdown parsing (using a Rehype plugin, IIRC), so there's no way to use it on a React page.
Shiki doesn't support as many languages as Prism, neither is it as easy to add them.
Shiki being purely server-side means it cannot be used in live code blocks, so there's inconsistency out-of-the-box.

What do you think?

Several things, based on my experience with Shiki, do correct me if I'm wrong:

Shiki is server-side and generates static markup during Markdown parsing (using a Rehype plugin, IIRC), so there's no way to use it on a React page.
Shiki doesn't support as many languages as Prism, neither is it as easy to add them.
Shiki being purely server-side means it cannot be used in live code blocks, so there's inconsistency out-of-the-box.

What do you think?

How about Highlight.js?

You mentioned docusaurus-preset-shiki-twoslash. It works by injecting a remark-shiki-twoslash plugin into our content plugin's config. This plugin is a Remark plugin, so it runs on server side. Basically, it takes a Markdown string and spits out a bunch of JSX. However, this transformation is done once and only once when the Markdown is compiled to JSX, but not if your code was authored in JSX to start with.
Now there could be a way to migrate all this logic to client side, sure; but that's not how any existing solution in the wild works, and it will need a lot of prototyping in the community before we can consider its feasibility to be recommended to everyone. There's nothing stopping you from implementing it yourself, or asking the Shiki folks to try it.

Alright. That makes sense!
Right now I will not be working on implementing it myself, and I believe Shiki folks are busy working towards Shiki 1.0. Maybe I can follow up with them after.
Thanks for the feedback, I'll close this issue for now (and reopen if something changes).
@SuperManito, I'd recommend you open a separate issue to discuss/propose Highlight.js.

There's also https://bright.codehike.org/
We'll figure out what is the best solution after migrating to server components.
For now the current solution is good enough and the system is flexible enough for you to use Shiki if you want.

There's also https://bright.codehike.org/

OMG that's amazing!

May I suggest you make a library agnostic way of overriding the code highlighter.
For different languages people will always want different highlighters. If you give them an extensible method of simply plugging in their own, they will do it. My personal preference is codemirror :)

@ryanhamilton we have 4 ways of doing that:

implementing your own theme
providing a remark plugin that process code blocks in Markdown AST, possibly highlighting code at build time instead of runtime
providing your own @theme/MDXComponents renderer for code blocks
swizzling the built-in @theme/CodeBlock and modifying it to not use Prism for some languages

That's probably largely enough extension points, we are not coupled to Prism, it is only used in one theme, but you can swap it for something else at multiple levels

It looks like Shiki got a complete revamp for 1.0: https://github.com/shikijs/shiki/releases
Apparently things that were previously only server side can now run client side.

Shiki may become the industry's best solution for code highlighting.

I'm actually really keen on Shiki, but the Docusaurus integration of https://github.com/shikijs/twoslash/tree/main/packages/docusaurus-preset-shiki-twoslash unfortunately has issues that mean (much as I'd like to) I've been unable to make use of it on my own site at present:
https://github.com/shikijs/twoslash/issues/120

I don't think docusaurus-preset-shiki-twoslash was updated to work with Shiki 1.0 yet, nor Docusaurus 3.0.

I'm +1 on investigating integration, but I think it would greatly help us if there's a community proof-of-concept. I'm mainly interested because Shiki can do other fun things like showing type/linting errors.

@Josh-Cena I currently have it implemented the slightly older shikiji-rehype plugin on cosmonic.com/docs (example here with wit highlighting) and am in the process of adding it for wasmcloud.com. It took a little wrangling, so if there's interest I can make it into a docusaurus preset.

It would be hard to make Shiki the default option of Docusaurus considering we probably want by default to be consistent between the regular code block and the live code block (both using Prism) and afaik live code block is not really an option (nor a good idea?) with Shiki.

We usually don't create official plugins for things we don't use ourselves.
However, it's probably worth it to explore how to use Shiki/Twoslash to enhance the experience on our own website, and create an opt-in plugin that users can turn on with some code block metastring on Docusaurus v3.x?
```ts shiki
const hello = "World"
```

```ts shiki twoslash
// @module: esnext
// @filename: maths.ts
export function absolute(num: number) {
  if (num < 0) return num * -1;
  return num;
}
// @filename: hello.ts
const hello = "World"
//    ^?
```

Note:

Shiki recently released v1.0 (after merging back the Shikiji fork): https://github.com/shikijs/shiki/releases/tag/v1.0.0
Twoslash also has a new repo/org/docs and is now integrated as a Shiki transformer: https://github.com/twoslashes/twoslash
Both tools are in active development
Shiki now provides a rehype plugin instead of a remark one like previously

@lachieh thanks for your proposal, I'm curious to see how you implement such preset.
To be honest, I think Docusaurus is missing a few primitives to make it possible to implement this as a robust plugin or preset, so it's probably better if we work on it in the main repo, but I'd be curious to look at your solution.

Thanks, @slorber. That all makes sense. I'll hold off on making the preset for now but if anyone finds their way here from a search, the PR below shows one way to integrate the @shiki/rehype plugin with Docusaurus 3.
https://github.com/wasmCloud/wasmcloud.com/pull/297/files

TIL about https://expressive-code.com, that looks interesting.
I'll investigate and try to figure out if we should use this instead of Shiki directly

TIL about expressive-code.com, thanks that looks interesting. I'll investigate and try to figure out if we should use this instead of Shiki directly

Hi, @slorber, any success with this?

Code Hike could be another alternative. There's an example of how to use it with Docusaurus (v3.5.0+) here: https://github.com/code-hike/examples/tree/main/with-docusaurus

Indeed, thanks for suggesting it
Also showing what can be built in userland! We don't necessarily need to build first-class support and the community can work on it too.

Note Josh Comeau provided useful feedback on Shiki:
https://www.joshwcomeau.com/blog/how-i-built-my-blog-v2/

As much as I love Shiki, it does have some tradeoffs.

Because it uses a more powerful syntax-highlighting engine, it’s not as fast as other options. I was originally rendering these blog posts “on demand”, using standard Server Side Rendering rather than static compile-time HTML generation, but found that Shiki was slowing things down quite a bit, especially on pages with multiple snippets. This problem can be solved either by switching to static generation or with HTTP caching.

Shiki is also memory-hungry; I ran into an issue with Node running out of memory(opens in new tab), and had to refactor to make sure I wasn't spawning multiple Shiki instances.

The biggest issue, however, is that sometimes I need syntax highlighting on the client. For example, in my Gradient Generator, the snippet changes based on how the user edits the shadows:There’s no way to generate this at compile-time, since the code is dynamic!
For these cases, I have a second Shiki highlighter. This one is lighter, only supporting a small handful of languages.

It's possible that making Shiki the default for Docusaurus would slow down the build time and increase memory usage, in addition to the inability to use it in live code blocks. This confirms my initial intuition that we should keep Prism as the default highlighter for now, and Shiki should be an optional plugin.

Indeed, thanks for suggesting it
Also showing what can be built in userland! We don't necessarily need to build first-class support and the community can work on it too.
Note Josh Comeau provided useful feedback on Shiki:
https://www.joshwcomeau.com/blog/how-i-built-my-blog-v2/

As much as I love Shiki, it does have some tradeoffs.

Because it uses a more powerful syntax-highlighting engine, it’s not as fast as other options. I was originally rendering these blog posts “on demand”, using standard Server Side Rendering rather than static compile-time HTML generation, but found that Shiki was slowing things down quite a bit, especially on pages with multiple snippets. This problem can be solved either by switching to static generation or with HTTP caching.

Shiki is also memory-hungry; I ran into an issue with Node running out of memory(opens in new tab), and had to refactor to make sure I wasn't spawning multiple Shiki instances.

The biggest issue, however, is that sometimes I need syntax highlighting on the client. For example, in my Gradient Generator, the snippet changes based on how the user edits the shadows:There’s no way to generate this at compile-time, since the code is dynamic!
For these cases, I have a second Shiki highlighter. This one is lighter, only supporting a small handful of languages.

It's possible that making Shiki the default for Docusaurus would slow down the build time and increase memory usage, in addition to the inability to use it in live code blocks. This confirms my initial intuition that we should keep Prism as the default highlighter for now, and Shiki should be an optional plugin.

Shiki can sync use now #sync-usage

@SuperManito There are plenty of examples of Shiki on Docusaurus 3, including in this thread. Are you having a particular issues with it?

The plugin docusaurus-preset-shiki-twoslash doesn't support Docusaurus 3.

That's correct. It's a community preset that was created with the pre-1.0 version of Shiki.js before maintainership was taken over by Anthony Fu. There is already an issue about that on the old repo. That change is unlikely to happen since Shiki 1.0 is already supported as a rehype plugin, and therefore can be implemented directly into Docusaurus 3.0.

I have yet to see any examples of Shiki on Docusaurus 3 that actually just work.

Here is a guide on installing @shiki/rehype with the latest version of docusaurus. The only necessary part is the first section of which the TL;DR is "install the packages and add the plugin to your config".
https://lachieh.github.io/docusaurus-with-shiki-rehype/docs/intro
The following section shows how to add a dark/light mode, and the site itself includes examples on how to use some of the transformers from @shiki/common-transformers.

Thanks for the demo @lachieh
It's a good starting point so that we can think about how we could simplify this setup in the future

@slorber yeah, no worries. Is this something that could be bundled into a theme or a preset? Which would work better assuming most would likely try to install alongside preset-classic?

We plan to introduce a global markdown config and plugin customization API to register global remark/rehype plugins, so this can be implemented as a plugin. We can figure out a solution where our theme components offer a "pass-through" mode so that you don't have to swizzle them to unplug Prism runtime code blocks.

I'd be interested in contributing to that effort!

I am running into a import error about some of the submodules not exporting the main. When I tried your example in stackblitz it failed to run. Running it locally with yarn it worked. I saw that you had to patch one of the libraries. Any idea why this error is happening and if it lies with the way docusaurus is importing the library or if it is an issue with they way shiki is exporting itself. I am trying to use this in a project that is using npm so it isn't possible to directly patch the library with our using an external package, but manually patching it in the node_modules folder it had the same issue in another one of the sub libraries

Here is a guide on installing @shiki/rehype with the latest version of docusaurus. The only necessary part is the first section of which the TL;DR is "install the packages and add the plugin to your config".
https://lachieh.github.io/docusaurus-with-shiki-rehype/docs/intro
The following section shows how to add a dark/light mode, and the site itself includes examples on how to use some of the transformers from @shiki/common-transformers.

I am running into a import error about some of the submodules not exporting the main.

This one?
[ERROR] Error: Docusaurus could not load module at path "/home/felipecrs/repos/website/docusaurus.config.ts"
Cause: No "exports" main defined in<EMAIL_ADDRESS>    at loadFreshModule (/home/felipecrs/repos/website/node_modules/@docusaurus/utils/lib/moduleUtils.js:36:15)
    at loadSiteConfig (/home/felipecrs/repos/website/node_modules/@docusaurus/core/lib/server/config.js:36:62)
    ... 6 lines matching cause stack trace ...
    at async file:///home/felipecrs/repos/website/node_modules/@docusaurus/core/bin/docusaurus.mjs:44:3 {
  [cause]: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in<EMAIL_ADDRESS>
Because this is what I get when I try it. I believe it has something to do with my package.json having type: module. @lachieh, any ideas?

I thought i had removed that patch actually, sorry about that.
Did some digging, it should be a pretty simple solve. Docusaurus uses jiti to enable esm/cjs/json/ts imports but isn't able to import @shikijs/vscode-textmate for some reason. This was resolved in jiti@v2 so I'll open a PR to update that dependency.

I thought i had removed that patch actually, sorry about that.
Did some digging, it should be a pretty simple solve. Docusaurus uses jiti to enable esm/cjs/json/ts imports but isn't able to import @shikijs/vscode-textmate for some reason. This was resolved in jiti@v2 so I'll open a PR to update that dependency.
Nov 25 Update: Created a PR which is waiting on a potential bug in jiti.

Is there a good workaround in the meantime?

Did some digging because we're currently using Shiki on wasmcloud.com with no yarn patch or anything. Apparently, the last version of Shiki that works with Docusaurus is 1.22.2. I've updated my example instructions, but the TL:DR; is this:
npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>


Sticky scroll catches Python function decorator rather than function name

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.2
OS Version: OS X 12.0.1 (Monterey)

Steps to Reproduce:

enable sticky scroll feature in version 1.70.2
scroll through a python file with that contains functions with a decorator

^ catching @staticmethod decorator rather then the function name

/duplicate of #157180

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


[#44] String[] ElementCollection support

Oh wow! This is a lot of work. It's going to take me some time to review it though!

Oh wow! This is a lot of work. It's going to take me some time to review it though!

Out of curiosity: why did you limit it to String[]? Aren't other array element types the same?

Out of curiosity: why did you limit it to String[]? Aren't other array element types the same?

Closing this PR and resubmitting in a bit with better commits/cleaned up code based on comments

Closing this PR and resubmitting in a bit with better commits/cleaned up code based on comments


Program won't wait for me to enter a code LinkedIn emails me

The program is crashing because it won't stop for me to enter the code it emails to me.

PR: https://github.com/IggsGrey/linkedin-easy-apply-bot/pull/14


Add Day 4 content on Data Type

Select the Day of Content
Day 4
What information is missing?
I would like to add the content of Day-4. On Day 4, we can introduce data types, variables, constants and literals.

I have updated the site structure. Also Included the Task in Every Day section.. With Added Image Assets. Do the Changes Accordingly. Day 04 Curriculum Check here


Add stk8ba58 crate to supported list

I made the stk8ba58 crate implementing the accelerometer.rs traits, and I'm requesting to add it to the list of supported driver crates.
Not all the functionality of the accelerometer is implemented yet, although I plan to update it soon.

Thanks!


How to Stereo Calibrate more than 2 cameras?

Hi, I was trying 3D human pose estimation using $3$ cameras: i.e., first finding 2D keypoints from each of the $3$ camera frames and triangulating to get the 3D pose. In such a case, how to get the camera extrinsic parameters?
Specifically, suppose for $3$ cameras, should we use $[C1, C2]$, $[C2, C3]$ pairs or should we use $[C1, C2]$, $[C1, C3]$ to find the extrinsic matrix of the cameras?
How to use the GUI for the same?

Hi @aviralchharia. Just saw this sitting here in the issues. Sorry for the delay in noticing it. You bring up a big question. For more than two cameras you can no longer rely on opencv functions and must use a process called "bundle adjustment". This is an optimization that relies on SciPY.  It's  a can of worms to get into, but hopefully just having the word "bundle adjustment" can help get you started down the google/ChatGPT rabbit hole.
In a couple weeks I'll start rolling out a rough version of this project and when I have the README updated and an intro tutorial put together, I will send a notice your way.


Proposal: generate MARATHON_NETWORK_NAME envvar when networkInfo.name is not empty

Frameworks running as apps in Marathon may be configured to run on a particular virtual network. If that framework launches tasks then those tasks should likely be configured to run on the same virtual network. In order to accomplish this the framework needs to discover the name of the virtual network upon which it is running.
Proposal:

Marathon will generate a MARATHON_NETWORK_NAME environment variable that captures the name of the network (see mesos protobuf field NetworkInfo.name) only if it is non-empty
update Docs to reflect the change

https://mesosphere.github.io/marathon/docs/task-environment-vars.html

since this is an auto-generated envvar it should probably pick up any user-specified prefix (see command line flags)

/cc @gkleiman @sargun @mgummelt @adam-mesos

But then if those apps/tasks register with Mesos as a scheduler themselves (e.g. Spark), how do they know to pass the network name on to the tasks they launch?

Rather than forcing the scheduler to tell its tasks what network they're in, can't we do this at the Mesos level?  Mesos could look at the network the scheduler is running in, and by default launch tasks in that network.

Yea, I figured, but I think that's the correct solution.  For example, your OS knows that your process is running as adam, so it knows to implicitly launch subprocesses under adam.

Marathon has also been asked to support apps belonging to multiple container networks. So we'd need a slightly different envvar naming scheme to accommodate.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2100. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2100. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Message Forbidden

Hi,
I've tried other APIs for scrapping the sec fillings from the Edgar website however this has been the most stable one. However recently as of the 5th of April, I am facing a forbidden error message from the API.

@meh369 When was the first time you noticed this started happening? I am wondering if we need to start adding a header to our requests.

So up until Friday the queries were working fine and I was able to extract the fillings, I noticed this from today (Didn't try on weekends) all day the queries didn't work.

I'm also seeing this, seems to be quite recent.

@jamiehannaford @meh369 can you try running your code on the most recent version from GitHub and let us know if it works now?

@jackmoody11 Yep, this works great. Thanks for the fix 👍


Invalid redirect URL error when authenticating to private gitlab

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
I'm getting an 'Invalid redirect URL' error when attempting to authenticate against private gitlab instance.
To Reproduce
Steps to reproduce the behavior:

Attempt to authorize via a private GitLab instance
See error on GitLab page

Expected behavior
Authentication should work
draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 14.6.11

Desktop (please complete the following information):

OS: Windows
Browser: Chrome, Firefox
Version: current

Additional context
Looking at the URL sent to GitLab, the redirect_uri parameter is 'https://diagrams.{mydomain}/gitlab'. In the last version in which this worked, the value was 'https://diagrams.{mydomain}/gitlab.html' (which is also the configured redirect URL in GitLab).
Changing the redirect URL in GitLab to '.../gitlab' instead of '.../gitlab.html' fixes the error on the GitLab side, but authentication still fails because Diagrams doesn't respond to the '.../gitlab' URL, it wants the '.html' extension.
Downgrading to v14.6.2 fixes this, so there was a regression in constructing the redirect_uri since then.

how are you configuring diagrams.net to reference that private gitlab?

I'm setting window.DRAWIO_GITLAB_URL in PreConfig.js (as well as DRAWIO_GITLAB_ID).
Note that the redirect to GitLab works fine, but it fails when GitLab tries to redirect back to Diagrams. Also, this has been working for some time but started failing in a recent upgrade.
I believe this broke in V14.6.8, the redirect path from GitLab back to Diagrams changed from /gitlab.html to /gitlab, but Diagrams is returning a 400 error for /gitlab

I've also experiencing this issue since around the same time as OP while using the Docker image.

Not sure if it's a separate issue, but similarly, (since about the same time as OP) I've also been getting 404s when trying to create or open a new diagram. Diagrams loads just fine, but no diagrams can be created or opened. Diagrams makes requests to /gitlab (causing a 404) when they should be to /-/draw/gitlab (which still returns a response successfully). Downgrading seems to work fine.

https://github.com/jgraph/drawio/commit/9425639430927146ef0c52a5dc34f20f0044008b#diff-d0228d4493180df3ed996671a721b16049e6de41f10fdb20752f1d781a3a8573R44 should be /gitlab.html, I think.

I'm fairly sure that just changing /gitlab to /gitlab.html here: https://github.com/jgraph/drawio/blob/d7cf67c98191c693c80e1bf60ac59bac7bb4b8ff/src/main/webapp/js/diagramly/GitLabClient.js#L44 will fix this, but I haven't tested this

I have tried adding the .html and it seems to work, but the following happens:
Describe the bug
The redirection back from my self-hosted gitlab to my diagrams application returns access denied.
To Reproduce
Steps to reproduce the behavior:
1-.Go to save diagrams in gitlab
2-.Click on create new diagram, and click blank diagram, create. Click authorize.
3-.Authorize redirects to sign up private gitlab, enter the user and password. The url that I get: " https://gitlab.genos.es/oauth/authorize?client_id=my_id}&scope=api%20read_repository%20write_repository&redirect_uri=https%3A%2F%2Fmy.company.com%2Fdiagrams%2Fgitlab.html&response_type=code&state=cId%3D{my_id}%26domain%3Dmy.company.com%26token%3D%3C!DOCTYPE%20html%3E%0A%3Chtml%3E%0A%09%3Chead%3E%0A%09%09%3Ctitle%3E%3C%2Ftitle%3E%0A%09%3C%2Fhead%3E%0A%09%3Cbody%3E%0A%09%09This%20window%20will%20be%20closed%20automatically.%0A%09%09%3Cscript%3E%0A%09%09%09if%20(window.opener%20!%3D%20null%20%26%26%20window.opener.onGitLabCallback%20!%3D%20null)%0A%09%09%09%7B%0A%09%09%09%09try%0A%09%09%09%09%7B%0A%09%09%09%09%09var%20search%20%3D%20window.location.href%3B%0A%09%09%09%09%09var%20idx1%20%3D%20search.indexOf(%27access_token%3D%27)%3B%0A%09%09%09%09%09var%20code%20%3D%20null%3B%0A%09%09%09%09%09%0A%09%09%09%09%09if%20(idx1%20%3E%3D%200)%0A%09%09%09%09%09%7B%0A%20%20%20%20%20%20%20%20%20%20%20%20%09%09%09var%20idx2%20%3D%20search.indexOf(%27%26%27%2C%20idx1)%3B%0A%09%09%09%09%09%09code%20%3D%20search.substring(idx1%20%2B%2013%2C%20idx2)%3B%0A%09%09%09%09%09%7D%0A%0A%09%09%09%09%09%2F%2F%20Continues%20execution%20of%20main%20program%20flow%0A%09%09%09%09%09window.opener.onGitLabCallback(code%2C%20window)%3B%0A%09%09%09%09%09window.close()%3B%0A%09%09%09%09%7D%0A%09%09%09%09catch%20(e)%0A%09%09%09%09%7B%0A%09%09%09%09%09alert(%27GitLab%20error%3A%20%27%20%2B%20e.toString())%3B%0A%09%09%09%09%09window.close()%3B%0A%09%09%09%09%7D%0A%09%09%09%7D%0A%09%09%3C%2Fscript%3E%0A%09%3C%2Fbody%3E%0A%3C%2Fhtml%3E ".
4-. Click on "authorize" and redirect to my application and error appear: Error Access Denied.
Expected behavior
Gitlab should give me permission.
Additional context
I think the url parameters are not correct, Is it possible? We have the last version.
Thanks

Gitlab authentication is changed to use server secret instead of the insecure implicit authentication
As I understood, this issue is related to self-hosted draw.io, please note that the new authentication method requires running the Java backend (cannot be hosted as a fully static html site). In addition, you need to create an app in Gitlab and set the app client id/secret in the files:
gitlab_auth_url
gitlab_client_id
gitlab_client_secret
We'll try to update the docker image soon to handle Gitlab
Meanwhile, @plinss let us know the exact setup you are using to run draw.io

I'm using the jgraph/drawio docker image behind a simple Nginx reverse proxy for TLS termination. I'm mounting a local PreConfig.js and PostConfig.js (Method 3 in the docs) and am setting window.GITLAB_URL and window.GITLAB_ID in PreConfig.js. We have a local GitLab instance. This setup works with version 14.6.6 and before of the Docker image.

Everyone needs to read this comment https://github.com/jgraph/drawio/issues/1992#issuecomment-860238380 . Implicit grants (pre 14.6.7, I think) and not allowed any longer by Gitlab, https://gitlab.com/gitlab-org/gitlab/-/issues/288516.
They have security problems, so Gitlab are switching them off. You need to:

create a project at the applications page
copy the ID and secret to the files mentioned
set the github auth url to the correct path for your Gitlab instance. The public instance is https://gitlab.com/oauth/token
set the callback URL to https://YOUR_DOMAIN/gitlab
set confidential to yes
add scopes:
api (Access the authenticated user's API)
read_repository (Allows read-only access to the repository)
write_repository (Allows read-write access to the repository)

@davidjgraph First, maybe I missed something, but this is a significant change to have slipped into a minor release with no obvious warning or documentation. And while I respect your being proactive in supporting GitLab's change, and the more secure authentication mechanism, the current mechanism does still work and won't be removed from GitLab for several more releases.
Second, I tried following your instructions, and it still fails (with V14.7.8) (and is this process documented anywhere?). When GitLab redirects back to Diagrams I get a blank page and a 500 error (with no further information in the dev tools, I'm happy to check logs if you tell me what would help here). FWIW, I'm authenticating against a local GitLab instance running the current release.
Third, @ashrafteleb mentioned the Docker image needing to be updated, so is this simply not working yet when running from that? (as I am)

@plinss What I meant is we need to test the Docker image and write the proper documentation similar to Google Drive/OneDrive and do any needed changes if any.
Meanwhile, you can help us by checking tomcat logs inside the container

@plinss Yeah, fair point. Our existing versioning is based around the version we deploy, it's not designed for the case of a custom deployment. It's pretty out of date in that regard, we'll have a think how to improve it.

had to change the "http-nio-7070" port because of a conflict when running locally (puma ?)
Catalina is started via a "run"  (not "start") so logs all are going to stdout[0], albeit at the default verbosity level.
Also tried to follow the comment/instructions and it also fails using version 14.8.5 after the gitlab "Authorize drawio to use your account?"
Using:
 docker run -it --rm -e DRAWIO_GITLAB_ID='*' -e GITLAB_CLIENT_SECRET='*'  -e GITLAB_AUTH_URL=https://gitlab.domain.com/oauth/token --name="draw" -p 7070:7070 drawio
and using the call back / redirect url with out the .html, to give a blank page with status code 400. The favicon loads after it.
The last entires in the log are:
  08-Jul-2021 23:40:52.138 INFO [http-nio-7070-exec-4] com.mxgraph.online.AbsAuthServlet.doGet AUTH-SERVLET: [<IP_ADDRESS>] Found cookie state (*  -> *)
and the last uRL is  http://localhost:7070/gitlab?code=&state=cld=&domain=localhost&token=*
[0] https://stackoverflow.com/a/50730492/2568021

had to change the "http-nio-7070" port because of a conflict when running locally (puma ?)
Catalina is started via a "run" (not "start") so logs all are going to stdout[0], albeit at the default verbosity level.
Also tried to follow the comment/instructions and it also fails using version 14.8.5 after the gitlab "Authorize drawio to use your account?"
Using:
 docker run -it --rm -e DRAWIO_GITLAB_ID='*' -e GITLAB_CLIENT_SECRET='*' -e GITLAB_AUTH_URL=https://gitlab.domain.com/oauth/token --name="draw" -p 7070:7070 drawio
and using the call back / redirect url with out the .html, to give a blank page with status code 400. The favicon loads after it.
The last entires in the log are:
 08-Jul-2021 23:40:52.138 INFO [http-nio-7070-exec-4] com.mxgraph.online.AbsAuthServlet.doGet AUTH-SERVLET: [<IP_ADDRESS>] Found cookie state (* -> *)
and the last uRL is http://localhost:7070/gitlab?code=&state=cld=&domain=localhost&token=*
[0] https://stackoverflow.com/a/50730492/2568021

if i run this on my own website, what environment variable should i confiure for authorizing from github?is there any doc for OAUTH ?

This is a thread about gitlab, not github.

FWIW I'm still seeing this issue with v16.2.4


support use UIStackView on iOS9 and later, FDStackView on iOS9 ealier

Won't use compatibility_alias, because we want exactly UIStackView class symbol.


Set cluster versions by default to be based on the recommended rapid channel version

Use https://cloud.google.com/sdk/gcloud/reference/container/get-server-config to determine the clsuter versions available
Use default version to create CP and nodes.
For additional node pools added, check that the current CP version is present in the node version list if not, pick the next GKE CP version.

This is improving the default static version behavior

Seeing version issues again today, making this change to make xpk adaptable


[WIP]Datasync prototype

PR is in very early stages :)
User-side API will change, some feedback on that would be :fire:
Planned

[x] Custom Conflicts with soft deletes
[ ] Proper Server-side conflict resolution
[ ] TESTS

What works

Custom Conflict field and resolution strategy with soft deletion, almost everything else is WIP

How to test functionality
// templates/ts-apollo-mongodb-datasync-backend/src/index.ts
import { createDataSyncMongoDbProvider, createDataSyncCRUDService, DataSyncPlugin, VersionConflictEngine } from '@graphback/datasync'
.
.
const { typeDefs, resolvers, contextCreator } = buildGraphbackAPI(modelDefs, {
    dataProviderCreator: createDataSyncMongoDbProvider(db, VersionConflictEngine),
    serviceCreator: createDataSyncCRUDService({ pubSub: new PubSub() }),
    plugins: [
      new DataSyncPlugin(VersionConflictEngine)
    ]
  });

VersionConflictEngine

This should be default. While having ability to swap detection mechanism I think that our entire ecosystem needs to base on some solid default etc.

I will redo this PR, will summarize what I understand here that will need to change, feel free to reply to add to this:

Conflict will be based on function that receive object and return if there is conflict
Sync will use base table
Version field will always stay

Besides this, I have a few other questions:

Will we always have delta table?
Will we always have conflicts?
What about deletes?
Multiple providers or single provider? If Multiple, do we separate them on strategy(softdelete only versus softdelete plus delta table) or something else?

As for actual implementation I would love you to check if we can:

Leave current master untouched and work the same way all the times
Add conflict as additional data layer (with ability to configure it to support server side conflict, configure TTL and anything else you would like for conflict in future)

Basing on limited investigation I think that will be:

Simple to understand
Simple to implement
Easy to maintain
Minimize number of variations for testing.
Do not affect performance as conflict is addition, not entire new implementation.

If you take look at offix plugin that we wrote in 0.11 it was literally doing that - despite we did not had any means to support deletes and server side conflict at that time. If we just extend what we had then we should be good.

CC @craicoverflow @machi1990 diversity of opinions.

Thanks for the work @ssd71 and the ping. I'll sit and review this properly early tomorrow.

Ignore review for the moment. We have call tommorow to get this over the line

This is outdated and the work is irrelevant.


POC Request?

There aren't so many details on this CVE like always with CVEs so I assumed a few things to make the POC working against your challenge:
POST /api/posts/comments HTTP/1.1
Host: <IP_ADDRESS>
Origin: http://<IP_ADDRESS>
Content-Type: application/x-www-form-urlencoded
Connection: Content-Length
Content-Length: 100
Transfer-Encoding: chunked

21
postId=1&name=af&comment=test

0

Maybe the meant is something like this or whatever it is I can't find the exact right payload,
Using Content length only doesn't work too, can you insert more details about that?

Hi, you are on the right track. There are some more details in chapter 8.3.2 of my thesis. I'm on my phone so can't test right now but only CL without the chunks should work

Hi, Thanks for the response.
I have tried something like what your thesis details without TE at first but this alone caused Varnish to return a Bad Request where the request wasn't even relyed to apache
POST http://<IP_ADDRESS>/api/posts/comments HTTP/1.1
Host: <IP_ADDRESS>
Content-Type: application/x-www-form-urlencoded
Accept-Language: en-US,en;q=0.9
Cookie: csrftoken=hf0toxB2oBcheR4yZTmQKPDQrPTgBzvB
Connection: Content-Length, keep-alive
Content-Length: 195

postId=1&name=test&comment=ves

POST http://<IP_ADDRESS>/api/posts/comments
Host: <IP_ADDRESS>
Content-Type: application/x-www-form-urlencoded
Content-Length: 100

postId=1&name=test&comment=ves

Can you please take another look?

When you list the content-length header as hop-by-hop, varnish will remove it when forwarding the request. That means when you send the request above, varnish will forward something like this:
POST http://<IP_ADDRESS>/api/posts/comments HTTP/1.1
Host: <IP_ADDRESS>
Content-Type: application/x-www-form-urlencoded
Accept-Language: en-US,en;q=0.9
Cookie: csrftoken=hf0toxB2oBcheR4yZTmQKPDQrPTgBzvB

postId=1&name=test&comment=ves

POST http://<IP_ADDRESS>/api/posts/comments
Host: <IP_ADDRESS>
Content-Type: application/x-www-form-urlencoded
Content-Length: 100

postId=1&name=test&comment=ves

The back-end (spring-boot), will interpret this as a POST request with an empty message body followed by an invalid request. You need to send something like this:
POST / HTTP/1.1
Host: localhost
Connection: Content-Length
Content-Length: 149

POST /api/posts/comments HTTP/1.1
Host: localhost
Content-Length: 300
Content-Type: application/x-www-form-urlencoded

postId=1&name=a&comment=a

Then Varnish will forward something like this:
POST / HTTP/1.1
Host: localhost

POST /api/posts/comments HTTP/1.1
Host: localhost
Content-Length: 300
Content-Type: application/x-www-form-urlencoded

postId=1&name=a&comment=a

spring-boot will interpret this as a POST request with an empty message body followed by an incomplete POST request to /api/posts/comments. Then when the victim sends his request, it's interpreted as the remaining bytes for the second request above (and his cookie is stored as comment). Hope that makes sense ^^

When Sending the request with Connection: Content-Length, keep-alive, Varnish doesn't forward the request to the backend instead it does the following:

Removes the Content-Length because it's made hop-by-hop
The request looks incomplete to Varnish so it responds with Bad Request without reaching out to Spring-boot

That's the issue that I am having, I am using the lab environment in the repo without modifications

I don't know if they have reuploaded the docker container back then with a patch, but something is not right


Calculate BaselineWorkflowRunId as part of "Determine Projects To Build" Action

Tested on 2 of my repositories, which yesterday didn't work correctly - works now


Compute all groups for group by queries with only filtered aggregations

Fixes https://github.com/apache/pinot/issues/12647 and https://github.com/apache/pinot/issues/13982.
Both the above issues have a good description of the problem but the TLDR is that for group by queries with only filtered aggregations, we currently only compute the groups based on the rows that match the query's main filter and the rows that match at least one of the aggregation filters.
This is good for performance, since in cases where the group by query doesn't have a main filter and there are only filtered aggregations (i.e., no non-filtered aggregations), indexes can be used and a full scan is avoided. However, this leads to results that are not SQL compliant, since all groups (computed over the results of the main query filter) are expected to be returned even for queries with only filtered aggregations.
For the single-stage query engine, this actually appears to be a regression from https://github.com/apache/pinot/pull/10356, prior to which all groups should have been returned by default.
For the multi-stage query engine's group by executor, this appears to always have been an issue.
This patch takes a different approach for both the query engines - in the single-stage engine, the default behavior remains the same, but the standard SQL behavior of returning all groups can be enabled using a new query option. In the multi-stage engine, however, all groups will be computed by default. The reasoning is that Pinot has historically chosen performance over standard SQL behavior for the v1 engine in such cases where the behavioral difference might not be too significant. For the multi-stage query engine, however, we have been moving towards standard SQL behavior regardless of potential performance impact.
For the v1 engine's executor, the fix is to simply put an additional AggregationInfo with an empty AggregationFunction array and the main query filter. This ensures that the GroupByExecutor will compute all the groups (from the result of applying the main query filter) but no additional unnecessary aggregation will be done.
For the v2 engine's executor, the fix is similar. Before this patch, all the group keys are only computed if there is at least one non-filtered aggregation. For group by queries with only filtered aggregations, groups were computed over the rows matching the aggregation filters. Now, all the groups will be computed even for group by queries with only filtered aggregations.

The PR description explains the rationale behind choosing different default behavior for the v1 and v2 query engines here. However, this currently means that there's no way to disable this behavior for the multi-stage query engine to improve query performance (and get non-standard behavior as a tradeoff). If we want to instead keep the behavior of the two query engines consistent, we have two options:

By default, always compute all groups for group by queries with only filtered aggregations. Add an option / performance hint to disable this behavior and improve query performance at the cost of non-standard behavior. The disadvantage of this option is that performance will suffer by default.
Keep the older behavior by default. Add an option to enable this standard SQL behavior of returning all groups at the cost of performance. The disadvantage of this is that the multi-stage query engine behavior in this case won't be SQL compliant by default (which is what we've been evolving it towards).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (1b4c8fd).
Report is 1176 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (1b4c8fd). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (1b4c8fd)

integration
7
2

integration2
3
2

temurin
12
2

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14211       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Downloading the trained weights

Hi, thanks for the nice work! Could you please maybe also share your trained models to some other platforms, e.g. Baidu cloud, for those who have no access to google drive?

Hi~ We have shared trained models in Baidu Drive. Please see README.

Thanks a lot! 多谢大佬！


UST file doesn't show up in game

Describe the bug
I created a UST file, but it won't show up in game. I've triple-checked everything I could think of that could be wrong, but it just refuses to even appear in the UST menu.
To Reproduce
Steps to reproduce the behavior:

Create a UST file.
Open the game.
Open the UST options in game.

Expected behavior
The file appearing.
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Mod version: 1.4.4

Send the logs

Send the logs

I assume you mean the BepInEx logs, so here:

Very late but just use https://github.com/ZedDevStuff/USTMaker or https://ustmakerweb.zeddevstuff.dev/ if you don't wanna download anything


Add SUSE Enterprise Linux and openSUSE provision

Add support for SUSE Enterprise Linux and openSUSE.
Code revised to build against current master.
Signed-off-by: Flavio Castelli<EMAIL_ADDRESS>

This is an updated PR made after https://github.com/docker/machine/pull/1436 failed to build against latest master code.
ping @dmp42

Thanks a lot @flavio - I know this has been lingering for some time...
Any doc or tests we can add for this?

I don't think we need to update the documentation, this has not been done for the other provisioners. Am I right?
About the tests, I don't think a unit test would be really useful. Probably an integration test would be better. Unfortunately that would take some time to be written (I have to understand how the Red Hat and the Rancher ones work).
We are however testing that internally at SUSE, I know it's not really great but at least it's something...

LGTM
This is building and doesn't impact the rest.
I don't see a reason not to merge this.
@nathanleclaire are you happy with it?

@nathanleclaire is there anything I can do to help you make the final decision? We have already reached 0.5.0 rc3; I would really love to have this PR finally merged into 0.5.0. :pray:

Yup, I think it's OK as it's likely to be low impact on other parts of the code, LGTM

@nathanleclaire thanks a lot!

:+1:


ghcWithPackages collision with haskellPlatform

$ echo '(import <nixpkgs> {}).haskellPackages.ghcWithPackages (s: [ s.haskellPlatform ] )' | nix-build -
these derivations will be built:
  /nix/store/8v4i9drfi38zp6hnfqw7x2zqz4fv3h4g-haskell-env-ghc-7.6.3.drv
building path(s) `/nix/store/if59xaf439336xdvihj3zn9cv9shzv09-haskell-env-ghc-7.6.3'
building /nix/store/if59xaf439336xdvihj3zn9cv9shzv09-haskell-env-ghc-7.6.3
collision between `/nix/store/zfzba7vvd2mkqyrmdfjwv0b86w1i1ik6-ghc-7.6.3/bin/haddock' and `/nix/store/qbw53yfah0n6gsrysq8cri0lhlfsracg-haskell-haddock-ghc7.6.3-2.13.2/bin/haddock' at /nix/store/9z6d76pz8rr7gci2n3igh5dqi7ac5xqj-builder.pl line 72.
builder for `/nix/store/8v4i9drfi38zp6hnfqw7x2zqz4fv3h4g-haskell-env-ghc-7.6.3.drv' failed with exit code 2
error: build of `/nix/store/8v4i9drfi38zp6hnfqw7x2zqz4fv3h4g-haskell-env-ghc-7.6.3.drv' failed

The removal of haskellPlatform fixed this issue for us, I suppose. :-)


merging oplogs with until to specific date options

would be nice to add date filter for merging oplogs,
something like this
e.g. mongo-oplog-backup merge --until string
the options can accept an rfc 3339 date, a unix timestamp, or a duration string (e.g. 5h ago).

Yes, that would be useful. Pull requests are welcome.

This project is not being maintained anymore - closing all issues.


Explicitly bump istanbul to newer versions

Summary
See last comments in #4519.
This is just making it explicit so deduping and upgrading doesn't leave users on old versions.

Test plan
Same versions internally in jest as before, so should be good.

Codecov Report

Merging #4616 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4616   +/-   ##
=======================================
  Coverage   56.17%   56.17%
=======================================
  Files         194      194
  Lines        6544     6544
  Branches        3        3
=======================================
  Hits         3676     3676
  Misses       2867     2867
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44d2c6...0a457a9. Read the comment docs.


EV 355: part II: update schemas and enforce required property

This PR:

update OCPP 201 standardized schema via script:
add variable WebsocketPongTimeout in schema (already used in ChargePoint / manually added to
corrects usage of required "SecurityCtrlrIdentity" in "SecurityCtrlr" (key must be property key not variable name)
add new struct RequiredComponentVariable as subclass of ComponentVariable for required variables (via script)
adjust usages in ChargePoint:

get_latest_meter_value_filtered requires "RequiredComponentVariable" (no further adaptions required)
authorize_req does not set cacheExpiryDateTime if AuthCacheLifeTime not set (in accordance with spec; this would have failed before if this non-required variable had not been given)

@Pietfried : applied your changes, rebased and tested again


WIP: Bootstrap / Component setup async

Description:
This make the hole start of hass 50% - 75% faster.

We don't lost the setup order but It should it make correct on magic of async
All dependencies are considered
After setup_component it is all present like before
We do not lock anythings
We support now discovery in setup too

Todo

[ ] Fix some test
[ ] Protect for circular dependencies

Simplified bootstrap even more
Addressed my own comments
Addressed @MartinHjelmare comments

I've also added a time log entry that prints how fast Home Assistant started up. Tested on Core i7 2.3Ghz.
On this branch:
17-02-27 21:41:59 INFO (MainThread) [homeassistant.bootstrap] Home Assistant initialized in 0.69s

On dev:
17-02-27 21:43:40 INFO (MainThread) [homeassistant.bootstrap] Home Assistant initialized in 0.9s

See my comment above. I don't know why it's shown as outdated.

Probably because that line has moved in a new diff.

Okay we are ready to merge

I have also no a small improvemnt with new restore Feature that can lock a executor. I will change that and we are more faster.

All platfrom have now a new add_device callback they not block the setup_platform. Otherwise we run into a executor deadlock with new restore feature.
So the component add_entities have not change, only the platform callback.

I fix now also automation they setup trigger before hi add to statemachine and that give a error. Now he add this to device callback and after that it start the trigger.

Okay. I have local tested and I very happy with it. For me is okay to merge now

🎉  🐬


⚠ ClamAV has degraded performance

In 768a843, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 08ccad2.


revision transition threshold

ARM (Control Plane) API Specification Update Pull Request
add new revision transition threshold property

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[x] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

confirmed with team that the breaking BreakingChange python sdk error is not related to my change and caused by another PR that was already approved https://github.com/Azure/azure-rest-api-specs/pull/30782 and that this should not block my PR.
This PR is ready for review

@smzeng - Signing off for ARM with comments. Please take a look and consider adding the additional properties to the int32 format before merging.

@mentat9 added min and max :), ty for the comment & approval


Add client side checks for CoinJoin

This includes:

Maximum CoordinationFee = 0.03%
Maximum CoinJoinMiningFeeRate = 300 sats/vByte
Minumum MinInputCount = 6 input

TODO: I need to check and fix the unit tests.


Models are downloaded repeatedly despite being available in cache

I am encountering an issue with the vidore/colqwen2-v1.0 model. Every time I run my script, the model downloads two versions:
models--vidore--colqwen2-v1.0
models--vidore--colqwen2-base
This occurs even though I have the two models already saved in my ~/.cache/huggingface/hub directory.
I have tried specifying the HF_HOME environment variable to point to the cache directory, but it still creates a .cache directory in the current working directory and downloads the models there.
I would like to be able to provide the absolute paths to the two model directories:
~/.cache/huggingface/hub/models--vidore--colqwen2-v1.0/snapshots/d6601e2379896aaa912c176eab8927a9b961a0e4
~/.cache/huggingface/hub/models--vidore--colqwen2-base/snapshots/fa8c8a27704510c9e4fa79b187141a1db76f50e7
However, I'm not sure how to do this correctly. Can you please help me understand how to prevent the repeated downloads and use the cached models directly?
Thank you for your assistance.

Hey!  I hope this reference will help -> link.
Don't forget to

Edit the adapter_config.json in the colqwen2-v1.0 directory
Change the base_model_path to point to your local base model


Fix enable/disable logic.

We need to check if the test is enabled or disabled before any modification of the test list.

This PR is related to review from #529. If we want to move all [enable|disable]_by_feature logic to enable and disable methods, we need to make sure first that we use their results while creating the test set.

That's great news! I'll read the code and close this PR as not needed anymore.

I examined the recent change and sadly this is not the case:
Thiago's commit https://github.com/opendcdiag/opendcdiag/commit/432f0e8465a059fc31769e1ceac32c9d7a8c7af1 changes some names but it doesn't change how the interface works.
Right now add/remove methods apply only to --enable and --disable
If the framework builds the runtime test set from built-in test list, or from provided test list file, or from available test content it doesn't use add/remove methods.

Oh, I totally missed this change: https://github.com/opendcdiag/opendcdiag/commit/abfc013a0f08ffe860d6eb335d25d21d95f453fb
Closing this for now, until I'll do my homework.


SetUpdateIntervalForType broken?

Describe the bug
when attempting to write an app that just displays data from the accelerometer of my phone. the setUpdateIntervalForType function appears to trigger a "TypeError" as shown in the provided screenshot.
To Reproduce
Steps to reproduce the behavior:

Copy example code into a project
Run app
See error

Expected behavior
the app should display a text object with a number from the accelerometer of the phone
Desktop (please complete the following information):

React Native Version: 0.61.5
Device: Samsung s9+
Version: 5.3.3

Additional context
I have added the file I made into this. and i also get a diffrent error if i just comment out the "setUpdateIntervalForType" call. about it not know what React is ?!? seems odd.
CODE: https://pastebin.com/JwvgtXsE

sorry, i forgot to add the screenshot

I see, we should improve the validation / error messages. If you have time I think this would be a great first PR :)
So the problem is that it has to be SensorType.accelerometer (https://github.com/react-native-sensors/react-native-sensors/blob/fa1cb601a795247ca0eb53d24c697c899297da33/examples/KeepTheBallGame/App.js#L11)
Because you have the wrong type there you pass an undefined, which can't do toLowerCase.
Best would be if we could add checks at these places, so the error message is not that cryptic: https://github.com/react-native-sensors/react-native-sensors/blob/ab93f61a69294002bea58ec0b4dc4b81ee88b321/src/rnsensors.js#L27

oh yea, that seems right. would be more helpful with a proper error message yes.
as with the PR, im currently making a project for my exam, so i wont be able to work on that now, sadly

but thanks for the quick response


Fix yarn exec command usage

Closes https://github.com/11ty/eleventy/issues/3522. yarn exec consumes the --serve option and does not pass it to Eleventy as an argument:
Passing yarn exec the echo command and then the test argument results in test being echoed.
$ yarn exec echo test
yarn exec v1.22.22
test
✨  Done in 0.03s.

Passing yarn exec the echo command and then the --test argument/option/flag results in nothing being echoed.
$ yarn exec echo --test
yarn exec v1.22.22

✨  Done in 0.03s.

This can however be fixed by using -- to designate the end of options and the remainder are interpreted as arguments:
$ yarn exec echo -- --test
yarn exec v1.22.22
--test
✨  Done in 0.02s.

Thank you!


Read float from lmdb (caffe)

Hi,
Is there an easy fix to read float lmdb (features from caffe)?

Check the caffe datum converter in the readme


Remove Travis CI Support

The performance of Github Actions is better than Travis CI.
Once Github Actions will be setup, it is necessary to remove the integration with Travis CI.

Removed integration


--expand-war

I have an old Grails app runining on Heroku and trying to deploy recently gives me an error of ERROR: Context 'file:/app/--expand-war' does not exist.
The command that's being run is Starting process with command "java -Xmx384m -Xss512k -XX:+UseCompressedOops -jar server/jetty-runner.jar --expand-war $RUNNER_OPTS --port 17783 --uri-encoding UTF-8 target/*.war" and I think it's the --expand-war causing the problems, this wasn't there in previous working commands.  Any idea what might be going wrong?

It looks like the buildpack thinks you are running with webapp-runner, but your cache has jetty-runner. This is probably due to a very old version of the buildpack that set your app this way, and now things are different.
I think the solution is to create a system.properties file and put the following in it:
grails.application.container=jetty

Please give that a try. Thanks

Tried that already and it didnt work.  In the application root folder right?  Will try again to double check.

Did you commit that file to Git?

Just tried again.  Defo committed and the result is the same :(

I think your next best bet is to purge your cache. But before doing this, it might be good to test with a fresh app. That is, create a new app with heroku create and git push heroku master to that app. See if you get the same problem or not.
If that clears things up, you can just keep the new app. Or you can purge the cache of your existing app with the heroku-repo plugin.

Great idea, thanks.

This is resolved now, I set it to use the legacy branch of the build pack.  Thanks for you help,


No method is accessible in class edb.Cell

Reproduce the problem by below code
import clr

clr.AddReference('System.Xml')
from pyaedt.edb import Edb

aedb_path = "Galileo.aedb"
edb = Edb(edbpath=aedb_path, edbversion="2021.1")
edb.edb.Cell.Create()

Traceback (most recent call last):
  File "C:/Users/hzhou/AppData/Roaming/JetBrains/PyCharmCE2020.1/scratches/json_test.py", line 10, in <module>
    edb.edb.Cell.Create()
AttributeError: Create

I would suggest to try using:
edb.edb.Cell.Create(edb.db,  edb.edb.Cell.CellType.CircuitCell, "MyNewCell")

I would suggest to try using:
edb.edb.Cell.Create(edb.db, edb.edb.Cell.CellType.CircuitCell, "MyNewCell")

I still get this error
Traceback (most recent call last):
File "C:/Users/hzhou/AppData/Roaming/JetBrains/PyCharmCE2020.1/scratches/scratch.py", line 8, in
edb.edb.Cell.Create(edb.db, edb.edb.Cell.CellType.CircuitCell, "MyNewCell")
AttributeError: Create

it is because you are missing one level
the right command should be (with two Cell levels)
edb.edb.Cell.Cell.Create(edb.db, edb.edb.Cell.CellType.CircuitCell, "MyNewCell")

Anyway we may add a create_cell method in Edb Class

@ring630 can you close this issue since my last comment worked for you?

Thanks!


Circle tool

Have you got a plan to develop a circle tool? If so, when could we get this?
Best regards.

Hi @ufuk23,
interesting timing for this question :-) I just now merged a pull request that adds a circle selection tool! If you build Annotorious yourself from source now, the circle tool is already there.
Until the next release, however, I'll refactor the project a bit. Annotorious will not get any additional selection tools. Instead there will be a new plugin (probably called annotorious-selector-pack). The circle tool will be the first tool to go into this new selector pack. I'll prepare all the docs when this gets released officially.

Hi @ufuk23,
interesting timing for this question :-) I just now merged a pull request that adds a circle selection tool! If you build Annotorious yourself from source now, the circle tool is already there.
Until the next release, however, I'll refactor the project a bit. Annotorious will not get any additional selection tools. Instead there will be a new plugin (probably called annotorious-selector-pack). The circle tool will be the first tool to go into this new selector pack. I'll prepare all the docs when this gets released officially.

@rsimon, I made a circle tool for annotorious-openseadragon 2.1.4 version. now I get 2.4.1 version but I could not implement my circle tool with this version. The codes change rapidly and I could not change my circle tool. When I try to do that I get different runtime errors. I need a circle tool and I dont want to do it acoording to new versions.
Best regards.

If I had known about your tool, I could have sent your a warning that the tool API would change.
But as I said, a new circle tool is now part of the main branch, ready to use (if you build from source). With the next release, it will be available as official plugin for versions 2.4+.

Ah - another thing: the recent pull request that's now part of the main branch uses a non-standards-compliant format to store the circle shapes. I'll fix that before the official release. But just to let you know: circle annotations created with the current main branch will not be readable with the official release.

I have just implemented the current main branch for the circle tool :) It looks great, at least it's better than mine, so please keep it in the main branch. The circle is so important and necessary tool I think there is no need to develop another tool. Now I am looking forward to get the new release. Take it easy!

Great, I'm already working on fixing the standards compliancy issue. Should be done soon!

Please be aware that there are still a few issues with the current implementation of the circle selection tool, so use this at your own risk until improvements have been made.
The main issue right now is that the circles are non-standard compliant. May not seem too important to you, but the implementation I had made (based on the work of @AlaEmrani) did not take into account the fact that CircleFragmentSelector is not a part of the W3C annotation model. As such, the CircleFragmentSelector will have to become an SvgSelector. Any stored circle fragments made with the current code will break once this change is released,
There are also two visual bugs, although they are relatively minor compared to the one above:

No visual mask has been implemented yet (dimming of the outer layer outside the circle when drawing or selected).
When you drag a circle's handle all the way beyond the opposite handle, the handle disappears.

However, I currently won't be submitting any pull requests to fix these two bugs until the code has been refactored and I receive the go-ahead from @rsimon.

Hi @Hero-Solutions, the standards-compliance issue has a few implications on my own current code. (The SvgSelector implementation silently assumes that the SVG will always contain polygon. That clearly shouldn't be the case and needs fixing). But don't worry about it - I'm already working on it. I'll post an update to this thread as soon as I'm done.

I had tried to rework the SvgSelector code to make it work with both a circle and polygon, but it's proven too much of a challenge for me. I didn't know that you were already working on the compliancy yourself. I'll leave this one to you. Many thanks for following this up so quickly!

Done - the Circle tool now works with standards-compliant SvgSelectors :-) I'll refactor this into a plugin eventually, as I said. But meanwhile, do feel free to make changes and send PRs if there's anything you want to fix.
Many thanks again to everyone for making this happen, @Hero-Solutions and @AlaEmrani!

Awesome, thank you so much! I'll get to work with this right away to fix the two outstanding issues with the circle tool.
I would also like to include an ellipse and a free drawing and perhaps also a point selector. For now, I can simply develop these in my own fork without submitting them as pull requests, but I suppose others might have a use for these as well in the future.
To this end, is there anything that I should know before developing the extra selectors, so that merging them into this repository (or rather, the future plugin) isn't too much of a hassle?

Fixed the two outstanding issues with circle selection :) https://github.com/recogito/annotorious/pull/133

Thanks @Hero-Solutions,
For info: as planned, I moved the circle tool over to the new (Annotorious Selector Pack plugin project)[https://github.com/recogito/annotorious-selector-pack]. The plan is to make this plugin a collection of generally useful tools that people can optionally import into their projects.

Great! I do have a few questions regarding this new plugin:

There is still a shape-related CSS rule present in the main repository (https://github.com/recogito/annotorious/blob/main/src/ImageAnnotator.scss#L28). Is there a way to generalize this, do we want to move these CSS rules into the plugin repository or do we have to alter this CSS rule each time a new shape is added in the selector pack plugin?
New CSS rules may have to be added (or existing rules altered) for new selectors, as was the case with the circle selector (faaba8f19cec8f3c00dab08e8cbc5109b352e163). How do we deal with this?
Calculation of the area of a shape still happens in in the EmbeddedSVG selector in the main repository (https://github.com/recogito/annotorious/blob/main/src/selectors/EmbeddedSVG.js#L96). Do we leave this as-is or are we going to look for a way to move these calculations into the selector pack plugin?
The circle shape is still included in the main repository (https://github.com/recogito/annotorious/blob/main/src/tools/circle). Do we want to remove this now that the circle is contained in its own plugin repository?
Are you planning to move the polygon into the shape repository? I'm guessing the answer would be no, even if it was just for backward compatibility, but I figured I'd ask to make sure.

As far as I'm concerned, I don't really have a problem with shape-specific CSS rules and EmbeddedSVG code being in the main repository, but I want to be sure you're okay with these implications or if this needs to be worked out yet to make sure the selector pack plugin can operate entirely independent from the main repo.

Good points!

I think the CSS rules should be moved over to the selector plugin. They are probably small, so can be embedded directly into the JS file. (No need to ship a separate CSS file with the selector pack I guess.)

The area computations can remain in EmbeddedSVG I guess. My thinking behind this is that these are concerns specific to all the SVG shape elements that exist - but not specific to the drawing tools. There could be drawing tools that work in totally different ways, but all produce polygons, for example. (In fact that's already the case: the Tilted box tool generates a polygon selector, just had different interaction.) Therefore I think it makes sense to keep these "SvgSelector-but-not-tool-specific" concerns with the core code.

yes, the circle tool can be removed from the main code. Didn't delete it just yet, as long as the plugin isn't technically ready yet. But the whole circle folder will definitely be dropped before the next release.

good question about the polygon selector. I'm open to hearing opinions. But might be inclined to keep it, for backwards compatibility add you say.

Sounds good, thank you for the input! I can definitely agree with the shape-related area calculation being in EmbeddedSVG class, since different selectors don't necessarily produce different shapes.

* I think the CSS rules should be moved over to the selector plugin. They are probably small, so can be embedded directly into the JS file. (No need to ship a separate CSS file with the selector pack I guess.)

Upon second thought, if you plan on keeping shape-specific area calculations in the core code, wouldn't it make sense to also keep shape-specific CSS rules inside the core code?

Good question... I don't have strong opinions about this. I assume different tools might want to apply different styles (even for the same shape types), which would be an argument for keeping the styles in the tools. On the other hand, it probably makes sense to include sane base styles in the core distribution.

@rsimon, thanks for your fast developments. We use the annotorious-openSeaDragon 2.4.1, how could I use the selector-pack with that? I tried the annotorious-selector-pack project alone but got some js errors. I think I must use these codes below with openSeadragon, right?
OpenSeadragon.Annotorious.SelectorPack(anno, {});
anno.setDrawingTool('circle');

@ufuk23 The following javascript code should do the trick:
Annotorious.SelectorPack(anno, {});

That's what worked for me, anyway.
And if you want to use the circle tool as default, you may indeed want to call anno.setDrawingTool('circle');.

Including the selector-pack.min.js and adding the code "Annotorious.SelectorPack(anno, {});" is not enough for me, because I get some js errors like above.
It works in case I put the circle folder into the tools folder and add it ToolRegistery.js like the previous version v2.4.1

Hi @ufuk23, I haven't published an updated version of the OpenSeadragon plugin yet. That's probably why you're seeing the issue. I'll see if I can roll a new release this evening.
Cheers,
R

Updated releases for Annotorious, AnnotoriousOSD and the Selector Pack are now on npm 🎉 Which means I think we can successfully close the issue. Thanks everyone!!


⚠ ESPN has degraded performance

In 568feef, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 650 ms

Resolved: ESPN performance has improved in a429897.


Preserve Video Settings Across Image Detail Transitions

When changing between a video and an image, video player settings reset. We should preserve those settings.

Added mute/unmute as a persistent option. Removed Fullscreen control on video. Instead fixed Fit mode on the sizing menu for the same results which will also persist across images and program open/close.


chore(deps): Update primeng to v18-rc1

Waiting for breaking issue to be resolved: https://github.com/primefaces/primeng/pull/16783
https://github.com/primefaces/primeng/issues/16827

It is really valueable that you add those referances, thanks 🙏🏻
https://github.com/primefaces/primeng/issues/16827#issuecomment-2498068507

fyi

Finally, here’s the exciting news: we’re planning to release 18.Final this week, and 19-rc.1 a week after that. Thank you for your understanding! Always bet on Prime!

Sure, already saw the update and did a quick test if it works, but it seems to need some more migration of some components we use. I will try it next week!


add lazy test to iter2map_converter

Fixes #753
This PR adds a test to ensure the converter behaves lazily in multiprocessing by checking the._map attribute after loading data.

And for lint Error, can you please follow the instruction here to fix it?

And for lint Error, can you please follow the instruction here to fix it?

Ok, thanks to your patient guidance. I will do it now

The failing tests are not related to your PR. Will merge the PR shortly.

LGTM, thank you

Thanks to your and NivekT guidance, I can't use words to express my gratitude.


Log nice message about missing hostname

Log nice message about missing hostname, otherwise, it can be
confusing.
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1221707

@ladas see #5502

@Fryguy right, I was asking @blomquisg in the BZ if I can close this, seem I can, right?


File a catch for npm3

@RichardLitt had npm 3 installed (as npm), but not npm3 program
gruntfile requires precisely the npm3 program
the error message is not clear, needs to be obvious to the user. something like:> grunt build
... stuff ...
error: npm3 tool not found.
please install npm3 by running:  npm install npm3

that reminds me, lets make sure nothing requires npm install -g and it's all local (i.e. it puts the bins in node_modules/.bin and uses them from there. may need to add node_modules/.bin to $PATH in gruntfile, or hardcode it in the paths.

Thanks for filing the issue! I'm working on to fix this and get rid of npm3 wrapper altogether.

Sorry; I used ghi to quickly open this, was planning to fill it out later. Better to have it here than to forget to do it.

This is fixed now.


iOS Button is not showing in real device

I am working with this package.  Everything is fine on my simulator but when I run it on my real device, then button is not visible.

@AbirAhsan Have the same problem. Did you solve it?

I'm also having this issue.

@AbirAhsan please check Apple Pay is not support in many countries so check your country support apple pay or not

@ravilimbani2203 so if I'm in a non supported country the button will only show on the simulator?

Yes

@ravilimbani2203 so if I'm in a non supported country the button will only show on the simulator?

Yes

But if have to develop for a country that has Apple Pay, but it's not currently supported in my country, how can I test it on a real device? is there any workaround?

Same issue here, button is showing on simulator but not showing on real device, how to solve it? I also get apple_pay.cert but not know where to place that certificate.

I'm from Mexico, I have the same problem, I've been trying to solve it for weeks and I just haven't succeeded, I've already done everything that the Apple documentation asks for

This issue doesn't seem to be relevant to this package.
This StackOverflow post has some more info on how Apple Pay handles test accounts.

@AbirAhsan Have the same problem. Did you solve it?

Hi,
https://stackoverflow.com/questions/43120587/apple-pay-works-on-simulator-but-not-on-device
Second answer where it says to set up a sandbox user, sign in via apple id with that sandbox user then add a card to the wallet on the real device solved this for me.

Hi @AbirAhsan
I am developer in Vietnamese I using lib google pay but IOS button not showing in real device . I research problem .
I read document Sandbox Testing then nation no support Sandbox testing ? I am from Vietnamese .
Please hep me .

Hi @DinhNguyen992, Apple Pay does not seem to support transactions for Vietnam at the moment.
Closing the case, since the original issue is resolved.

@JlUgia
Thanks I find document apple vs read this .


Firewall4

Now that openwrt:master has option of new firewall: firewall4, luci-app-firewall should depend on either firewall or firewall4.

@jow-
Any ideas about the best solution here?
Should firewall4 provide "firewall"?
And should the old firewall package be similarly named to firewall3 and just provide "firewall" ?
I tried compiling the build with firewall4 and noticed that although I disabled firewall3 from the main config, LuCI still pulled it in. Getting it out of the build required editing luci-app-firewall.

Yes, it should be solved via PROVIDES eventually.

I have modified my luci-app-firewall to support fw4, first I though se should variate fw3/fw4- but it would be better idea to variate luci-app-firewall due to path inconsistencies.
Lähetetty iPhonesta

Hannu Nyman @.***> kirjoitti 1.4.2021 kello 22.23:

@jow-
Any ideas about the best solution here?
Should firewall4 provide "firewall"?
And should the old firewall package be similarly named to firewall3 and just provide "firewall" ?
I tried compiling the build with firewall4 and noticed that although I disabled firewall3 from the main config, LuCI still pulled it in. Getting it out of the build required editing luci-app-firewall.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

fw4 has a fw3 symbolic link, but if I remember correctly, it’s located in /sbin/fw3 in firewall package - when on firewall4, fw4 binary is in /usr/sbin, and so is symbolic link fw3, so even though applications are compatible between each other, changes have to be made to either, firewall4 or luci-app-firewall or by making variant luci-app-firewall4 provididng luci-app-firewall.
There’s also a helper file which luci-app-firewall depends on, which assists when simpler firewalling rules are made for applications more or less simpler than creating rules, I’ve never before this even known about this, but just found out about this when studying why luci-app-firewall didn’t show in luci; these files are also in different locations, even though it’s paths last directory difference x/x/firewall <—> x/x/firewall4. Pseudos here are since I am bit busy right now and won’t be doing true comparison at the moment..
AND if I remember correctly, there was also a 3rd similar difference. Anyway, my luci-app-firewall at the moment supports fw4 - and changes are not made on running system, changes are on package’s sources so that I can simple build package in my buildroot, if we agree that variant should be on luci’s side - I can easily create a branch for fw4 variant and do a PR - even better would be to support both on a single package, but I wasn’t able to make a depends rules that would had actually worked, although reason for this might had been elsewhere. That kind of package although might be impossible to archieve, since once of these changes were in a rpcd rule file, which cannot be dynamic afaik.
So let me know your opinions where this variation should be. Other way ofcourse would be to change fw3 link’s location in fw4, but I’d rather loose that link there completely separating these packages completely from each other. Helper file’s location could be worked out on a lua file making it support both locations.

On 2 Apr 2021, at 0:54, Jo-Philipp Wich @.***> wrote:
Yes, it should be solved via PROVIDES eventually.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/openwrt/luci/issues/4947#issuecomment-812192589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFEHVOOMFW3AU6SBV7EDLTGTTSJANCNFSM4Z5YYOGQ.

Okay.
I also tried to make a variant in another file, that unfortunately won't work either.
Why not make luci-app-firewall support both, fw3 and fw4? That's quite difficult as well, as both are depending on rcpd acl and menu, where items showing up in interface depend on existence of binary, which is in fw3: /sbin/fw3 and in fw4: /usr/sbin/fw4, later also makes a symlink /usr/sbin/fw3 -> fw4 for compatibility, but this won't help as path must also remain same. rpcd and menu file do not support OR.
Another changes have to be made inside function of file in lici-base that retrieves firewall's helpers. Without this change, page might open but troubles ahead.
Also there seems to be error in code in that file that I will later on open a new ticket.
Hopefully someone will take a look at this idea. Currently I have my own build where luci-app-firewall and luci-app-firewall4 are separate packages, luci and luci-nginx are made to no longer depend on luci-app-firewall, so one needs to choose between them and install either one, but this is not a solution to production version....


Day54: 1832. Check if the Sentence Is Pangram - HashTable

Check if the Sentence Is Pangram
https://leetcode.com/problems/check-if-the-sentence-is-pangram/
A pangram is a sentence where every letter of the English alphabet appears at least once.
Given a string sentence containing only lowercase English letters, return true if sentence is a pangram, or false otherwise.

Example 1:
Input: sentence = "thequickbrownfoxjumpsoverthelazydog"
Output: true
Explanation: sentence contains at least one of every letter of the English alphabet.
Example 2:
Input: sentence = "leetcode"
Output: false


docs: readme BPF graphic says tc ingress twice

Should be "tc ingress -> network stack -> tc egress".

Is this fixed? I can't find where is this located.

@nebril I think Daniel is referring to the bpf-overview.png in the README file. If you look at the green boxes titled netdevice you should see TC Ingress beside. One of them should instead say TC egress.

Thanks, I was grepping through the repo and thinking about what I was missing :D


async call not work when use zipkin

dubbo version 2.6.x
zipkin plugin version 5.6.1

result.hasException() will call future.get() to wait result

@chickenlj   can we disscus this

result.hasException() will call future.get() to wait result

Sorry, but I don't understand why result.hasException will trigger future.get().
Can you provide the complete code implementation which the above snippet belongs to?

@chickenlj
i am sorry, i use dubbo 2.7.0-SNAPSHOT.

but 2.7.0-RELEASE already fix it.

Is this necessary?
oneway and async are difference.

call tracing   consumer--->provider1--->provider2
use async call
but i can't wait result.

@chickenlj  can i do something?

but 2.7.0-RELEASE already fix it.

Yes, the bug you reported will be fixed in 2.7.1 release.

Is this necessary?

You can use RpcContext.getCompletableFuture() and add callback to CompletableFuture directly.
And I would recommend you record the Finish Span in Filter.onResponse, it works for both sync and async scenario, you do not need to register any callback. Whenever onResponse is called, indicates the actual result returns.


Deploy an existing app when upgrading

I'm testing Deis migration upgrade, this upgrade method provisions a new cluster running in parallel to the old one.
If both clusters share the same S3 external storage and database, how can I deploy existing applications in the new cluster without a "git push"?

If both clusters share the same S3 external storage and database, how can I deploy existing applications in the new cluster without a "git push"?

Running deis scale <type>=0 -a <app> && deis scale <type>=1 -a <app> in the new cluster.

It works. Thanks!


Bookstore: styling

In this branch, I have added the following;

[ ] Add the missing JSX elements to the project (without adding extra functionality).
[ ] The final design matches the Bookstore design in Zeplin. (this includes all elements + the same styling),
[ ] I used the CSS rules detailed in Zeplin to style the website.

@huseyinbiyik, Thank you! :hugs:


Cursor jumps to start of vim buffer (if fugitive and projectionist installed)

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Problem / Steps to reproduce
Thanks for this great tool!  This issue seems to be an interaction between fzf.vim, vim-fugitive and vim-projectionist.  I am posting the issue here first because it is triggered when running a fzf command.  I'll cross-post it to those other projects if this doesn't jump out as an issue with fzf.
Problem
fzf.vim commands work as expected but when the fzf window is closed, the cursor in the buffer has jumped to the top.  This only happens if the vim-fugitive and vim-projectionist vim plugins are also installed and enabled.
Steps

Install vim-plug
Install vim-fugitive, vim-projectionist, fzf and fzf.vim plugins (see below for a minimal .vimrc to repro)
Open a buffer and move the cursor so it's not at the first character
Run :Maps (or any of the other built in fzf commands) to open a fzf window
Close the fzf window (Ctrl-c)
Check the cursor position

Expected: The cursor is where you left it.
Actual: The cursor is at the start of the buffer.
(The following screen capture shows the issue, then how disabling one of the tpope plugins seems to fix the issue.)

Environment

Vim: Huge vim without GUI (see below for version output)
Terminal emulator: Reproduced in iTerm2, Alacritty, and Terminal.app

Minimal .vimrc:
set nocompatible

call plug#begin('~/.vim/plugged')
Plug 'tpope/vim-fugitive'
Plug 'tpope/vim-projectionist'
Plug 'junegunn/fzf'
Plug 'junegunn/fzf.vim'
call plug#end()

Vim version
$ vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Oct 24 2020 22:29:54)
macOS version
Included patches: 1-1900
Compiled by Homebrew
Huge version without GUI.    I'm moving this issue to fzf.vim.)


Fix failing tests from the ScaladocParserSuite

Superseeds https://github.com/scalameta/scalameta/pull/727


bug: files with syntax error incorrectly reported as well-formatted

Bug Report
Cairo version:
Using the current main at 5435626.
Steps to reproduce:
Create an empty folder containing only an unparseable cairo file. Then try to run a formatter check:
$ mkdir fmt_test && cd fmt_test
$ echo "asdf" > file.cairo
$ formatter_cli --check
$ echo $?

Current behavior:
The formatter does indeed report an error regarding the issue: A parsing error occurred in file: ./file.cairo. The file was not formatted.
However, the exit code is 0, indicating a success:
$ echo $?
0

This would cause CI workflows to give false negative on format errors, since CI workflows would only check the exit code. Editors would also interpret the result as successful and replace file content with the error message.
Expected behavior:
The exit code should be non-zero.
Related code:
This is what's causing the false negative.
https://github.com/starkware-libs/cairo/blob/5435626b17538dbbec6ae1f7706abc8bec212863/crates/formatter/src/bin/cli.rs#L26-L33
Other information:
N/A

For context, cargo fmt returns 1 if it encounters files with syntax errors.

lgtm


Better error message while cake nuget task or msbuild taks is trying to execute wrapped exe

If the nuget exe is missing you will get:
An error occured when executing task.
Error: Path cannot be empty.
Parameter name: path

Perhaps something along the lines of "cant find exe nuget, searched in system PATH and in ./tools"
Similar thing occurs when executing msbuild task (and the specific msbuild is missing)

:+1:

Actually, I've been looking at this and it will actually say NuGet: Could not locate executable. so I guess that the error must be something else.
I tried the repository you provided in #396 and I cannot reproduce this error. Is there anything missing in your reproduction steps?

Remove the tools folder and don't have nuget in path? Maybe this is already fixed in dev?

This behavior has been there forever. Just tried deleting the tools folder in your repository and I get the NuGet: Could not locate executable message.

That's weird. I'll close this since you cant reproduce it.

@wallymathieu My guess is that the error is the result of something else. Normally the Path cannot be empty. is thrown when creating a FilePath or DirectoryPath with an empty string. :/

Indeed. That's why it's so confusing.

I would like to find the cause of this so we can fix it. Can you reproduce it now somehow?

after making sure that there definitelly is no nuget in path i try running Cake on a windows 10 machine:
D:\projects\cake-build-test [what_happens_when_there_is_no_nuget]> .\packages\Cake.0.5.3\Cake.exe

========================================
Clean
========================================

========================================
Restore-NuGet-Packages
========================================
An error occured when executing task.
Error: Path cannot be empty.
Parameter name: path

If I switch to the master branch where nuget.exe is in the ./tools folder, then I don't get any errors.
I have vs 2013 community edition, vs 2015 community edition and windows sdk installed. I have msbuild in path, but that shouldn't change anything.

Ok, will take a look at this later tonight. Thanks!

There is no packages folder. How do you restore the packages.config in .nuget?

I used nuget exe from another lib:
> ..\some_other_dotnet_lib\src\.nuget\NuGet.exe restore

I tried debugging with the source, but it crashed vs2015.

Ok. Can you try doing a git clean -xdf in the repository and then (after restoring packages like you did) go to the Cake directory and enter the following:
C:\git\cake-build-test\.nuget\Cake.0.5.3 [what_happens_when_there_is_no_nuget]> .\Cake.exe ../../build.cake -verbosity=diagnostic

And paste the output here.

Compiling build script...

========================================
Clean
========================================
Executing task: Clean
Creating directory D:/projects/cake-build-test/test_cake/bin/Release
Finished executing task: Clean

========================================
Restore-NuGet-Packages
========================================
Executing task: Restore-NuGet-Packages
An error occured when executing task.
Error: System.ArgumentException: Path cannot be empty.
Parameter name: path
   at Cake.Core.IO.Path..ctor(String path)
   at Cake.Core.Utilities.Tool`1.GetToolPath(TSettings settings, FilePath toolPath)
   at Cake.Core.Utilities.Tool`1.RunProcess(TSettings settings, ProcessArgumentBuilder arguments, FilePath toolPath, Pro
cessSettings processSettings)
   at Cake.Core.Utilities.Tool`1.Run(TSettings settings, ProcessArgumentBuilder arguments, FilePath toolPath, ProcessSet
tings processSettings, Action`1 postAction)
   at Cake.Common.Tools.NuGet.Restore.NuGetRestorer.Restore(FilePath targetFilePath, NuGetRestoreSettings settings)
   at Submission#0.<.ctor>b__2()
   at Cake.Core.ActionTask.Execute(ICakeContext context)
   at Cake.Core.DefaultExecutionStrategy.Execute(CakeTask task, ICakeContext context)
   at Cake.Core.CakeEngine.ExecuteTask(ICakeContext context, IExecutionStrategy strategy, Stopwatch stopWatch, CakeTask
task, CakeReport report)
   at Cake.Core.CakeEngine.RunTarget(ICakeContext context, IExecutionStrategy strategy, String target)
   at Cake.Scripting.BuildScriptHost.RunTarget(String target)
   at Submission#0..ctor(Session session, Object& submissionResult)
   at Submission#0.<Factory>(Session session)
   at Roslyn.Scripting.CommonScriptEngine.Execute[T](String code, String path, DiagnosticBag diagnostics, Session sessio
n, Boolean isInteractive)
   at Roslyn.Scripting.Session.Execute(String code)
   at Cake.Core.Scripting.ScriptRunner.Run(IScriptHost host, FilePath scriptPath, IDictionary`2 arguments)
   at Cake.Commands.BuildCommand.Execute(CakeOptions options)
   at Cake.CakeApplication.Run(IEnumerable`1 args)
D:\projects\cake-build-test\packages\Cake.0.5.3 [what_happens_when_there_is_no_nuget]>

The text before this section is describing how it's downloading roslyn and importing namespaces.

Ok, perfect. Will take a look at this tonight/tomorrow. Thanks.

No problem. Hope it helps.

@patriksvensson how did go? 😉

Closed due to inactivity.


Rewrite WebGL rendering modules without wasm-bindgen

[ ] context initialization

[ ] vertex array buffer
[x] compile shaders
[x] fetch shaders
[ ] initialize framebuffer and renderbuffer

[x] texture api

[x] force textures to RGBA-format
[x] perform texture packing
[x] uploading
[x] unloading

[x] correct canvas and viewport size handling
[ ] shader rewrite for texture atlas rendering
[ ] instanced drawing
[ ] final cleanup

Changes in this PR shall also include some optimizations and a better implementation.
For example the glBlitFramebuffer-function will be used instead of the 2-render-passes system.

When reviewed, "shader rewrite for texture atlas rendering" can be checked :P


[BUG]safetensors model unable fully cache to RAM which leads to frequent pulling from EFS when the model  switched quickly.

What happened:
safetensors model unable fully cache to RAM which leads to frequent pulling from EFS when the model  switched quickly.
To Reproduce
Steps to reproduce the behavior:
Sending payload containing different sd_checkpoint model will trigger this issue.
Environment:
def generate_random_payload():
    payload = {
    "alwayson_scripts": {
        "task": "text-to-image",
        #"sd_model_checkpoint": random.choice(selected_models),
        "sd_model_checkpoint": random.choice(['realisticAsiaDollPeeing_v10.ckpt', 'braBeautifulRealistic_brav3.ckpt','dreamlike-diffusion-1.0.ckpt','dreamlike-photoreal-2.0.ckpt','openjourney-v4.ckpt']),
        "id_task": "7008",
        "sd_vae": "",
        "uid": "123",
        "save_dir": "outputs"
    },

As we have verified, memory pressure on the node caused this. Use g5.4xlarge or g5.8xlarge instances solve this issue.


How do I use 3x3 artoolkit markers for multi-marker area learning.

As the title suggests, how do I use 3x3 artoolkit markers for multi-marker area learning.
I've been able to use 3x3 markers by themselves but the area training seem to use different source files.
My training json looks like this
{
  "backURL": "https://<IP_ADDRESS>:8125/api/AR.js-2.0.0/three.js/examples/multi-markers/examples/player.html#%7B%22trackingBackend%22%3A%22artoolkit%22%7D",
  "trackingBackend": "artoolkit",
  "detectionMode": "mono_and_matrix",
  "markersControlsParameters": [
    {
      "type": "barcode",
      "barcodeValue": "0"
    },
    {
      "type": "barcode",
      "barcodeValue": "1"
    },
    {
      "type": "barcode",
      "barcodeValue": "2"
    },
]}

When I set debug to true I can see that the markers are detected.

However I can't seem to get them to detect normally. What am I doing wrong?

Hint: Put three back ticks before and after code (a so called code fence).

能不能别给我发邮件了？真的打扰我的生活了...
| |
muli_bupt
|
|
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
On 10/25/2019 00:54, André Jaenisch wrote:
Hint: Put three back ticks before and after code (a so called code fence).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Ryuno-Ki I know. It was removing the whitespaces and new lines from the json file.
@Rmuli , just unsubscribe!

Not sure, whether you can apply code fences via reply-by-mail.
It would look like this via Web UI:
{
  "backURL": "https://<IP_ADDRESS>:8125/api/AR.js-2.0.0/three.js/examples/multi-markers/examples/player.html#%7B%22trackingBackend%22%3A%22artoolkit%22%7D",
  "trackingBackend": "artoolkit",
  "detectionMode": "mono_and_matrix",
  "markersControlsParameters": [
    {
      "type": "barcode",
      "barcodeValue": "0"
    },
    {
      "type": "barcode",
      "barcodeValue": "1"
    },
    {
      "type": "barcode",
      "barcodeValue": "2"
    },
]}

Google Translate gives me some weird translation by @Rmuli. I assume for now that it was not inserted manually.

Umm guys, can we please get back to the problem at hand ? 😅
On Fri, 25 Oct, 2019, 3:54 AM André Jaenisch<EMAIL_ADDRESS>wrote:

Not sure, whether you can apply code fences
https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks
via reply-by-mail.
It would look like this via Web UI:
{
"backURL": "https://<IP_ADDRESS>:8125/api/AR.js-2.0.0/three.js/examples/multi-markers/examples/player.html#{"trackingBackend"%3A"artoolkit"}",
"trackingBackend": "artoolkit",
"detectionMode": "mono_and_matrix",
"markersControlsParameters": [
{
"type": "barcode",
"barcodeValue": "0"
},
{
"type": "barcode",
"barcodeValue": "1"
},
{
"type": "barcode",
"barcodeValue": "2"
},
]}
Google Translate gives me some weird translation by @Rmuli
https://github.com/Rmuli. I assume for now that it was not inserted
manually.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/627?email_source=notifications&email_token=ACYOZJVCGWU2BUO6FNZLTQTQQH4OBA5CNFSM4JEWVPR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGHO4A#issuecomment-546076528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYOZJWXIWZWQ4HVPNEQQPLQQH4OBANCNFSM4JEWVPRQ
.

we can continue discussing this at new repo address: https://github.com/AR-js-org/AR.js/
feel free to re-open there