Mongoid support

This pull is trying to address #36.
I looked inside devise gem to try to understand a proper way to organize the testing part for Activerecord and Mongoid.
I still have a problem with a failing test (for both ORM).
To setup your ORM you have to provide DEVISE_ORM env variable
DEVISE_ORM=active_record (default)
or
DEVISE_ORM=mongoid

Pull Request Test Coverage Report for Build 218

222 of 305 (72.79%)  changed or added relevant lines in 38 files are covered.
161 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-19.3%) to 73.08%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test/dummy/config/application.rb
8
9
88.89%

test/test_security_question_controller.rb
2
3
66.67%

lib/devise-security.rb
8
10
80.0%

lib/devise-security/models/password_archivable.rb
0
2
0.0%

test/dummy/app/models/application_record.rb
3
5
60.0%

test/dummy/app/models/mongoid/mappings.rb
10
12
83.33%

test/dummy/app/models/secure_user.rb
1
3
33.33%

test/dummy/app/models/widget.rb
1
3
33.33%

test/dummy/app/models/user.rb
8
11
72.73%

test/dummy/config/initializers/migration_class.rb
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

lib/devise-security/hooks/expirable.rb
2
33.33%

lib/devise-security/hooks/paranoid_verification.rb
2
33.33%

lib/devise-security/models/secure_validatable.rb
3
86.96%

lib/devise-security/patches/controller_security_question.rb
4
63.64%

lib/devise-security/models/expirable.rb
4
50.0%

lib/devise-security/hooks/session_limitable.rb
4
15.38%

lib/devise-security/models/database_authenticatable_patch.rb
7
23.53%

test/test_password_expired_controller.rb
8
52.94%

lib/devise-security/models/password_archivable.rb
10
58.97%

test/test_password_archivable.rb
11
64.29%

Totals

Change from base Build 208:
-19.3%

Covered Lines:
847

Relevant Lines:
1159

💛  - Coveralls

Pull Request Test Coverage Report for Build 218

222 of 305 (72.79%)  changed or added relevant lines in 38 files are covered.
161 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-19.3%) to 73.08%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test/dummy/config/application.rb
8
9
88.89%

test/test_security_question_controller.rb
2
3
66.67%

lib/devise-security.rb
8
10
80.0%

lib/devise-security/models/password_archivable.rb
0
2
0.0%

test/dummy/app/models/application_record.rb
3
5
60.0%

test/dummy/app/models/mongoid/mappings.rb
10
12
83.33%

test/dummy/app/models/secure_user.rb
1
3
33.33%

test/dummy/app/models/widget.rb
1
3
33.33%

test/dummy/app/models/user.rb
8
11
72.73%

test/dummy/config/initializers/migration_class.rb
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

lib/devise-security/hooks/expirable.rb
2
33.33%

lib/devise-security/hooks/paranoid_verification.rb
2
33.33%

lib/devise-security/models/secure_validatable.rb
3
86.96%

lib/devise-security/patches/controller_security_question.rb
4
63.64%

lib/devise-security/models/expirable.rb
4
50.0%

lib/devise-security/hooks/session_limitable.rb
4
15.38%

lib/devise-security/models/database_authenticatable_patch.rb
7
23.53%

test/test_password_expired_controller.rb
8
52.94%

lib/devise-security/models/password_archivable.rb
10
58.97%

test/test_password_archivable.rb
11
64.29%

Totals

Change from base Build 208:
-19.3%

Covered Lines:
847

Relevant Lines:
1159

💛  - Coveralls

Pull Request Test Coverage Report for Build 218

222 of 305 (72.79%)  changed or added relevant lines in 38 files are covered.
161 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-19.3%) to 73.08%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test/dummy/config/application.rb
8
9
88.89%

test/test_security_question_controller.rb
2
3
66.67%

lib/devise-security.rb
8
10
80.0%

lib/devise-security/models/password_archivable.rb
0
2
0.0%

test/dummy/app/models/application_record.rb
3
5
60.0%

test/dummy/app/models/mongoid/mappings.rb
10
12
83.33%

test/dummy/app/models/secure_user.rb
1
3
33.33%

test/dummy/app/models/widget.rb
1
3
33.33%

test/dummy/app/models/user.rb
8
11
72.73%

test/dummy/config/initializers/migration_class.rb
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

lib/devise-security/hooks/expirable.rb
2
33.33%

lib/devise-security/hooks/paranoid_verification.rb
2
33.33%

lib/devise-security/models/secure_validatable.rb
3
86.96%

lib/devise-security/patches/controller_security_question.rb
4
63.64%

lib/devise-security/models/expirable.rb
4
50.0%

lib/devise-security/hooks/session_limitable.rb
4
15.38%

lib/devise-security/models/database_authenticatable_patch.rb
7
23.53%

test/test_password_expired_controller.rb
8
52.94%

lib/devise-security/models/password_archivable.rb
10
58.97%

test/test_password_archivable.rb
11
64.29%

Totals

Change from base Build 208:
-19.3%

Covered Lines:
847

Relevant Lines:
1159

💛  - Coveralls

Pull Request Test Coverage Report for Build 218

222 of 305 (72.79%)  changed or added relevant lines in 38 files are covered.
161 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-19.3%) to 73.08%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test/dummy/config/application.rb
8
9
88.89%

test/test_security_question_controller.rb
2
3
66.67%

lib/devise-security.rb
8
10
80.0%

lib/devise-security/models/password_archivable.rb
0
2
0.0%

test/dummy/app/models/application_record.rb
3
5
60.0%

test/dummy/app/models/mongoid/mappings.rb
10
12
83.33%

test/dummy/app/models/secure_user.rb
1
3
33.33%

test/dummy/app/models/widget.rb
1
3
33.33%

test/dummy/app/models/user.rb
8
11
72.73%

test/dummy/config/initializers/migration_class.rb
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

lib/devise-security/hooks/expirable.rb
2
33.33%

lib/devise-security/hooks/paranoid_verification.rb
2
33.33%

lib/devise-security/models/secure_validatable.rb
3
86.96%

lib/devise-security/patches/controller_security_question.rb
4
63.64%

lib/devise-security/models/expirable.rb
4
50.0%

lib/devise-security/hooks/session_limitable.rb
4
15.38%

lib/devise-security/models/database_authenticatable_patch.rb
7
23.53%

test/test_password_expired_controller.rb
8
52.94%

lib/devise-security/models/password_archivable.rb
10
58.97%

test/test_password_archivable.rb
11
64.29%

Totals

Change from base Build 208:
-19.3%

Covered Lines:
847

Relevant Lines:
1159

💛  - Coveralls

Pull Request Test Coverage Report for Build 218

222 of 305 (72.79%)  changed or added relevant lines in 38 files are covered.
161 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-19.3%) to 73.08%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

test/dummy/config/application.rb
8
9
88.89%

test/test_security_question_controller.rb
2
3
66.67%

lib/devise-security.rb
8
10
80.0%

lib/devise-security/models/password_archivable.rb
0
2
0.0%

test/dummy/app/models/application_record.rb
3
5
60.0%

test/dummy/app/models/mongoid/mappings.rb
10
12
83.33%

test/dummy/app/models/secure_user.rb
1
3
33.33%

test/dummy/app/models/widget.rb
1
3
33.33%

test/dummy/app/models/user.rb
8
11
72.73%

test/dummy/config/initializers/migration_class.rb
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

lib/devise-security/hooks/expirable.rb
2
33.33%

lib/devise-security/hooks/paranoid_verification.rb
2
33.33%

lib/devise-security/models/secure_validatable.rb
3
86.96%

lib/devise-security/patches/controller_security_question.rb
4
63.64%

lib/devise-security/models/expirable.rb
4
50.0%

lib/devise-security/hooks/session_limitable.rb
4
15.38%

lib/devise-security/models/database_authenticatable_patch.rb
7
23.53%

test/test_password_expired_controller.rb
8
52.94%

lib/devise-security/models/password_archivable.rb
10
58.97%

test/test_password_archivable.rb
11
64.29%

Totals

Change from base Build 208:
-19.3%

Covered Lines:
847

Relevant Lines:
1159

💛  - Coveralls

I've cleaned the code and addressed your requested changes. I also pulled and merged last changes from upstream/master. The active_record tests should be all green, while the mongoid test are failing. When I test locally I still have two failing tests:
  1) Failure:
TestPasswordArchivable#test_updating_a_record_updates_the_time_the_password_was_changed_if_the_password_is_changed [/Users/g.scicolone/prj/devise-security/test/test_password_expirable.rb:67]:
Expected false to be truthy.

  2) Failure:
TestWithoutSecurityQuestion#test_When_security_question_is_not_enabled_it_is_not_inserted [/Users/g.scicolone/prj/devise-security/test/test_security_question_controller.rb:87]:
--- expected
+++ actual
@@ -1 +1 @@
-"You will receive an email with instructions for how to unlock your account in a few minutes."
+nil
50 runs, 135 assertions, 2 failures, 0 errors, 0 skips

On travis I saw a stackoverflow error inside every mongoid travis job, but i don't know how to replicate it. Even with wwtd runned from local I don't see that problem.
Any advice?

@scicco please enable the 'Allow Edits from Maintainers' option on your PR and I'll try to spend some time helping to fix some of the issues.

@scicco ok, I've made some progress.  Still getting the stack too deep error, but there is another class of errors to address as well.  Those have to do with differences between the way active record and mongoid handle dirty record tracking.

@scicco the 'stack level too deep' was caused by the password_archiveable callback.  It was adding an OldPassword to the User document when the password changed.  This re-triggered the before_update callback, which would attempt to re-archive the password.  There are some subtle differences in how callbacks work in active_record vs. mongoid.

Thank you @olbrich for your help. Now there are just two failing test (test1, test2). They seems connected to the same issue related a missed unlock procedure. If i cleanup the mongoid models the tests seems to pass.

You may consider to use database_cleaner instead of my ugly mongoid related hacks.

👍 Exactly my plan.

@scicco take a look at the readme and add any additional information that might be useful to someone starting to use mongoid.  Also feel free to add yourself to the contributors list.

@olbrich thank you again for your help. I was wondering if we can add a way to avoid to explicitly set DEVISE_ORM, or set the default value based whether mongoid gem is loaded or not, something like this
DEVISE_ORM = ENV.fetch('DEVISE_ORM', defined?(Mongoid) ? :mongoid : :active_record)
I saw that Devise uses this declaration inside his config file to select the proper ORM.
# ==> ORM configuration
  # Load and configure the ORM. Supports :active_record (default) and
  # :mongoid (bson_ext recommended) by default. Other ORMs may be
  # available as additional gems.
  require 'devise/orm/mongoid'

Any ideas?

@olbrich thank you again for your help. I was wondering if we can add a way to avoid to explicitly set DEVISE_ORM, or set the default value based whether mongoid gem is loaded or not, something like this
DEVISE_ORM = ENV.fetch('DEVISE_ORM', defined?(Mongoid) ? :mongoid : :active_record)
I saw that Devise uses this declaration inside config file to select the proper ORM.
# ==> ORM configuration
# Load and configure the ORM. Supports :active_record (default) and
# :mongoid (bson_ext recommended) by default. Other ORMs may be
# available as additional gems.
require 'devise/orm/mongoid'

Any ideas?

I'm reluctant to implement this since Devise itself does not.  This may lead to some odd behavior if devise is loaded before devise-security.
Right now I think it is possible to have both active_record and mongoid loaded and have devise use active_record as it's ORM.  Your proposal would break that use case.
It would be pretty easy to lock a rails app to set DEVISE_ORM=:mongoid in application.rb before devise and devise-security are required or bundler loads all of the other gems.

I see. I added a Rails example inside the README.md file.


use lowercase for 'article' tag

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Congrats @Amabel on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


signalr-client.js not found

hi
i create new asp.net core project
add
Microsoft.AspNetCore.SignalR            1-23269
Microsoft.AspNetCore.SignalR.Client  1-23269
no file signalr-client.js in folder http://localhost:59456/Home/lib/signalr-client/signalr-client.js

tell me pls where get signalr-client.js and another files for signalr
thanks

It looks like it'll be packaged via npm. But I can't find it on there yet. You'll probably have to build your own from source.

For now you need to build and copy yourself. It is not being packaged and published anywhere yet. The easiest way is to clone the SignalR repo and run build.cmd and you will find it in the artifacts folder. The fastest way is to clone the SignalR repo, npm install, go to src/Microsoft.AspNetCore.SignalR.Client.TS folder and run gulp.

We are now publishing the client as npm module. The module contains a browserified version of the client. You can install it using the following command:
npm install signalr-client --registry https://dotnet.myget.org/f/aspnetcore-ci-dev/npm/


Questions

First of all, I want to thank you for the excellent documentation of the work. It's very impressive. Regarding to the repo and the paper, I have several questions listed below.

Regarding the machine learning task presented in the paper, are there any specific tasks that would be most appropriate for the specific physical systems, for example, for the SHG system? Did the same system show any limitations when trained for other ML tasks?

In the example code of the multilayer net for coupled pendula, I noticed that in the forward model the PNN is constructed by propagating the input through pendula 1, pendula 2, and pendula 3 using the same underlying neural networks. I was wondering why a three-times loop of one pendula is not used in In [30]? What if I would like to simulate a relatively deeper network, can I use a loop?

For the simulation of Coupled Pendulas and other tasks, I noticed that the user needs to define a way to extract the output in order to have a meaningful interpretation of the ML result. For instance, in Coupled Pendula, the output (final layer) is selected as to be the angle of the middle pendula. May I ask if this is a tricky part of training a PNN? Does the definition of the last layer matter a lot in terms of training? Do you have any suggestions on how I should define the last layer given a certain physical system?

Thanks for your time and patience!

Hi, thank you for the interest and the questions:

As far as we know, a particular physical system might be good at some machine learning tasks and bad at others. When we trained the SHG system to perform MNIST handwritten digit classification, we struggled with the inability of the SHG process to implement a linear operation, while a linear layer alone can achieve around 90% on MNIST. This was a clear limitation of the SHG PNN: It has to do MNIST classification without that 90% "baseline", which is why it was well suited to a demonstration of digital layers and SHG working in conjunction. Almost trivially, the closer the mathematical process that generated the ML data to the physical system, the more suited the system will be to solve the task, taken to the extreme in the self-simulation analysis we did in the appendix. As to whether there are relevant machine learning tasks that are particularly appropriate to the SHG system, we are unsure.
You could use a for loop to call identical pendula 1, pendula 2, and pendula 3, but we found that by introducing heterogeneity in the parameters of the pendula, we could get slightly better performance. Pendula 1, 2, and 3 have slightly different frequencies and coupling constants. This is a good point though--our syntax is very clumsy for an operation that, conceptually, is just repeated 3 times. I will think about how to make the code easier legible. Please let me know if you have ideas. I had in mind the notation usually used in pytorch, where different layers of a NN have different names (e.g. fc1, fc2,...):

def forward(self, x):
    x = F.relu(self.fc1(x))
    x = self.fc2(x)

When designing the output layer of a physical system, we were cognizant that the output layer of one layer could be the input to another layer, without too much postprocessing. I.e. the output angle can relatively easily translate to an input angle. We put the output pendulum into the middle so that it would equally couple to both inputs on the left and right. In principle, the final output measurement can give you a powerful nonlinearity, as used in the oscillating plate PNN, where despite linear physics, the position of the maximal amplitude is not a linear function of the input.

I hope these answers are helpful and we are happy to keep discussing!

Thanks for the reply, Martin.
Do we have to have a digital twin model implemented before the PNN? I tried to skip training of the digital twin part in the example code and set the load_dt = False and train only the PNN and got the error:
AttributeError: 'DigitalTwin' object has no attribute 'mean_dt'
Is there a way to bypass this requirement?


NTR: heme transmembrane transporter activity

descendant of
heme transporter activity (GO:0015232)
def: standard TM transporter + heme
parent of
GO:0015439    ATPase-coupled heme transmembrane transporter activity
(for a non ATPase heme transporter)
ref PMID:29549126

Or rejig GO:0015232 if all are TM?

Looks like all proteins annotated to GO:0015232 heme transporter activity are TM transporters, except for http://amigo.geneontology.org/amigo/gene_product/GeneDB:Tb927.6.440:mRNA
which may be an endocytic receptor - can you check ? I can't access the paper.
Thanks, Pascale

@Achchuthan Can you please check if GeneDB:Tb927.6.440:mRNA is a cargo receptor? In that case we would need to create a child of 'GO:0038024 cargo receptor activity' to capture the activity.
Thanks, Pascale

Changed label to 'heme transmembrane transporter activity'

@deustp01
The following Reactome mappings could be more precise:

R-HSA-917979
R-HSA-5683355
R-HSA-382560
R-HSA-1369065

-> Suggest to use GO:0015439 ATPase-coupled heme transmembrane transporter activity
Thanks, Pascale

Yep for T. briucei  it looks like
GO:0140312   cargo adaptor activity
endocytic adaptor activity | narrow

Yes, the more exact term works for all four Reactome instances. The changes will appear in our June 2020 release.
This is the sort of QA that we hoe to generalize applying GO reasoners to GO-CAM versions of Reactome pathways to detect instances where an alternative GO term looks better - here, transport plus ATP consumption suggests ATPase-coupled transport.

Now that Reactome has addressed this I will close the ticket.


DSM7-Repair packages getting Invalid file format

Getting this on the following:
Synocli disk tools
Synocli monitor tools

The others Synocli packages updated fine.

Reported in concerned repository


The container XXX could not be found. (hope someone can help)

Hey all,
hope someone can help before i go crazy :-) until yesterday i was able to add artifacts from other VSTS projects, this suddenly stopped. Initially i thought it was an issue with my GIT repo so tried rebuilding with no success, now i have tried setting up a test project with below settings.
VSTS test project1 -> GIT repo with a folder containing a single ps1 file (scripts\helloworld.ps1) ->
i have created a build definition (helloworld) with build step (Copy Publish artifact):
copy root: blank
contents: scripts**
artifact name: helloworld
artifact type: server
i have within "same project" created a release definition and linked above artifact i have added following task:
powershell script:
Type: file path
Script path: $(System.DefaultWorkingDirectory)/helloworld/helloworld/helloworld.ps1
from another project i have created another release definition with following settings:
Artifacts: helloworld
type: build
project: test project1
source (build definition): helloworld
source alias: helloworld
task:
powershell script:
Type: file path
Script path: $(System.DefaultWorkingDirectory)/helloworld/helloworld/helloworld.ps1
But when i run this i get the following errors:
Downloading artifacts failed: Microsoft.VisualStudio.Services.FileContainer.ContainerNotFoundException: The container 1081070 could not be found.
The container 1081070 could not be found.
iam am now totally lost can some help and maybe give and answer to why this was working perfectly yesterday?

@allanmoller - Could you pl. clarify if the release was able to download the artifacts from "test project1" build definition before and it started to fail later on?
Also, could you share your account name?

@allanmoller - Could you also confirm that the build used for the release is not deleted?

before it started not to work i was able to consume artifacts from anther project (Azure PS scripts) but now it dosnt, only difference is that i tried adding some files (using VSTS) to GIT rep (test project 1) after which i cannot consume artifacts from this project!

Thanks for the update. We will investigate and get back to you with our findings.

Yes, we are experiencing the exact same problem. This seems to be a fairly recent break, it was working about 2 weeks ago.

We have fixed the issue & it will be available as part of 2.115.0 version of agent:
https://github.com/Microsoft/vsts-agent/releases/tag/v2.115.0
Apologies for the inconvenience.


Randomly crashes when using tabs/slits

Always crashes when:

renaming splits

Sometimes crashes when:

switching tabs
deleting tabs
removing splits

also seems to happen more often when switching into a channel that is very active

If you delete the splits from the page before deleting the page then some crashes won't happen anymore like closing a tab when there are still splits open.
Also crashes when:
Empty Tab -> Press "Add chat" / CTRL+T -> Close/cancel the dialog -> Close tab -> Crash


Saving All The Chats in a project

Is your feature request related to a problem? Please describe:
Please make it where all the chat in a project is saved after existing Bolt.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

This is being tracked in #39


Out of date notice

Pinging @ByteSudoer to lyk that the Nix package is outdated -- couldn't reach you by email lol

a PR has been issued and merged https://github.com/NixOS/nixpkgs/pull/344187

Tysm!


Prevent a call to update from running before data has been initialized.

Debugging through this failure, i found occasionally the "update" call would be triggered by
Language Change events before the old data had been initialized.
this would cause the previously loaded data to be replaced with an array of nulls.
This should address #375 / #381

@mikebryant Just want to call your attention to this one. If you have a moment to take a look at this, it would be great if we can fix this critical bug.

I'm running a copy of mikebryant/master with this merged in on my own server, and it seems to have entirely fixed the problem. +∞ to merge this. @mikebryant @theRTC204

Closes #375 and Closes #381


Change column width doesn't work, when there are merged cells

Change column width doesn't work, when there are merged cells in the same column.

The column width of the blue cell isn't changeable, because there are merged cells in the row before.

.ql-editor table {     table-layout: fixed;     width: 100%; }
width: unset;  cover width: 100%;

@attoae Thanks a lot this solves my issue


[windows] [cws] Make FIM processing configurable.

For current release, make FIM processing configurable, and disabled by default.
Motivation
disable feature for initial release
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Install agent.
Enable CWS
on default config, note that FIM is not enabled.
Enable FIM
runtime_security_config:
  fim_enabled: true

Note warning level message in log that it's enabled.
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Regex deprecation warning in Ruby 2.7

When using RubyXL with Ruby 2.7.0.preview1, the following deprecation warning is present when working with cells containing integers:
rubyXL-3.4.6/lib/rubyXL/objects/sheet_data.rb:95: warning: deprecated Object#=~ is called on Integer; it always returns nil

A related error is present for accessing a cell with float data as well.

This is fixed in 3.4.8


Update UI, Bicep file, github validation and set JDK version on the i…

Update UI, Bicep file, github validation and set JDK version on the instance for PAYG SingleVM, MultiVM Cluster and VMSS.

All the validation tests went through:
https://github.com/azure-javaee/rhel-jboss-templates/actions/runs/9799760971
https://github.com/azure-javaee/rhel-jboss-templates/actions/runs/9799759611
https://github.com/azure-javaee/rhel-jboss-templates/actions/runs/9799758415

Tests


buffer overflow

The issue lies in csp_transaction_persistent and csp_ping, identical to the one described here: https://github.com/libcsp/libcsp/pull/503. I believe csp_buffer_get()/csp_buffer_get_isr() should be deprecated (at least with attribute((deprecated))) to prevent similar issues in the future. I would suggest that the current usages of csp_buffer_get()/csp_buffer_get_isr() be examined carefully.

I think it would be a good idea to mark the function parameter deprecated since we don't use it anymore in libcsp.
I was previously thinking of removing the current value pass to csp_buffer_get()/csp_buffer_get_isr() in libcsp to make all of them to 0 😅
We could also define something like CSP_UNUSED_INT_PARAMETER. To make sure user understand that the parameter isn't used in the function...


Add jedrzejboczar/possession.nvim and jedrzejboczar/toggletasks.nvim

Checklist:

[x] The plugin is specifically built for Neovim.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] It's not already on the list.
[x] If it's a colorscheme, it supports treesitter syntax.
[x] The title of the pull request is Add `username/repo`  when adding a new plugin.

Not sure if plugins like yabs.nvim/toggletasks.nvim are best suited for "code runners" (maybe "job/task/external runners") but I left it in "code runners" as this is still pretty similar.

Thanks for the PR!


[WIP] .net standard 1.3 port

Hello everyone,
@ektrah (more or less willingly 😋) and me are currently working towards providing an official binary distribution of libsodium for .net through the new runtimes/native/ nuget machinery (see jedisct1/libsodium#504).
I've done the initial work to support this new nuget package which has the potential to eliminate the Baseclass.Contrib.Nuget.Output dependency. Furthermore I've made the (implementation of the) libsodium abstractions compatible with the .net standard 1.3. The public API hasn't been touched by this and I tried to make the necessary implementation changes as nonintrusive as possible (from my point of view, for more details see the commit messages; if there're better solutions to any of the compat fixes I will integrate them).
As part of the .net standard port I had to replace your DynamicInvoke solution with traditional DllImports and addressed the native bitness issue of the full .net framework the same way Microsoft did for Microsoft.Data.Sqlite and SQLitePCL.raw: For a net46 application, the libsodium nuget package puts the libsodium.dll binaries in the corresponding x86 and x64 directories and at runtime the correct binary gets loaded by RuntimeShim.PinDllImportLibrary() through LoadLibraryEx(). (see also this stackoverflow answer)
My initial tests of the above method have been working very well so far, but I haven't had time to take a look at Mono or think about shadow copying. The tests haven't been ported yet, but I'm not sure how far NUnit's .net core support has progressed (still need to read http://www.alteridem.net/2017/05/04/test-net-core-nunit-vs2017/)
TODO:

[ ] comply with any changes requested
[ ] decide whether this should replace the existing project or live in its own package
[ ] finish remaining work tracked over here: .net core port github project

fixes #148
fixes #121
(probably) obsoletes #150
/xref jedisct1/libsodium#504
instructions on how to build the libsodium nuget package

travis build failures are due to xbuild not understanding the new project format 😓

FYI I've derived issues from the actionable TODOs in my github fork and organized them in a github project which will hopefully provide better trackability of the remaining work.

@bitbeans @adamcaudill do you want me to preserve the old project and the DynamicInvoke hack? Or can I go ahead and replace the old one?

The DynamicInvoke hack is very much that, a hack. It was done to make it easier to deal with libsodium-net being AnyCPU, and libsodium being CPU-specific, which is further complicated by NuGet's awful handling of unmanaged DLLs. It's made use for full .NET applications work well, give or take some that had issues with ASP.NET.
Today, things are more complex, and DynamicInvoke isn't the right solution anymore. So, here's how I see it:

We can't break applications that work today. If someone is using it now, and it works, it should keep working.
It should keep working with Mono.
It should work on the widest range of .NET versions as possible.
Ideally, it should work with .NET Core.

Change is needed, we just need to make sure that we follow these priorities when making changes.

I've done some testing of this stuff on (arch-)linux and my results were:

building the net46 assemblies on linux requires Mono 5.0 due to the new project format, but using them with any Mono version supporting net46 should be fine
the dotnet sdk cannot build cannot build the net46 target on linux (not an issue due to Mono)
tests pass with mono and .net core on linux and windows without any errors 🎉

We can't break applications that work today. If someone is using it now, and it works, it should keep working.

I removed the DynamicInvoke and LazyInvoke classes which might break applications illegally relying on them, is this a problem?

Those classes were never meant to be used outside of the library; I am fine with removal. If anyone was using them, they can grab the code from git history, and use them directly.

I think this is ready to be reviewed.
Please note that the travis build failure on mac osx with dotnet core happens during the package restore step which seems to overwhelm the travis worker.

Also: https://github.com/bfriesen/LibsodiumDotNetStandardSpike /cc @bfriesen

@BurningEnlightenment What is the status of this relative to the main branch? I have this working in .NET Standard 2.0 with minor adjustments, though the 1.0.12-preview-01 libsodium package is not resolving correctly, and so will only work on Windows builds.

I've merged the change - we may need to make some further changes to get things where we want them, but at least we can get this into master so we are making some progress.


Enable TSLint for tests

We should run TSLint over our unit tests. Particularly rules like no-floating-promises which ensure you properly await a promise. It's easy to mess that up and get weird behavior in a test.
I'd suggest doing this by adding a new script to each of clients\ts\signalr\package.json and clients\ts\signalr-protocol-msgpack\package.json that lints the tests, and then have the test script in clients\ts\package.json run those commands before running jest.

I'd also strongly suggest waiting for #2388 to land first since it will conflict hard.

#2388 done


Plugin manager looking in wrong directory for PyCharm 2020.1

On macOS, PyCharm 2020.1 is installed in $HOME/Library/Application Support/JetBrains/PyCharm2020.1, but the plugin manager is looking in $HOME/Library/Application Support/PyCharm2020.1. The result is the user is unable to install the plugin.

Here is a list of installation paths that Sergey has compiled: https://kite.quip.com/Igi0AhSbIvIY/Editors-distributions-support-list#LAPACAohWqV

thanks for the fix 👍


cannot determine Numba type of <class 'numba.dispatcher.LiftedLoop'>

Numba version:
numba==0.44.1
System:
armhf (arm 32bits) build of debian stretch running on an aarch64 kernel.
I experienced some problem to properly import jit from numba, but it appeared to be solved at the end of https://github.com/numba/llvmlite/issues/497
MWE:
from pywi.processing.transform import starlet
import scipy.misc as misc
img=misc.face()[:,:,0]
t = starlet.wavelet_transform(img, number_of_scales=5)

Actual log:

python3
Python 3.5.3 (default, Sep 27 2018, 17:25:39)
[GCC 6.3.0 20170516] on linux
Type "help", "copyright", "credits" or "license" for more information.

from pywi.processing.transform import starlet
import scipy.misc as misc
img=misc.face()[:,:,0]
t = starlet.wavelet_transform(img, number_of_scales=5)
/home/rock/.local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py:237: NumbaWarning:
Compilation is falling back to object mode WITH looplifting enabled because Function "wavelet_transform" failed type inference due to: Internal error at <numba.typeinfer.CallConstraint object at 0xedcb6030>:
--%<----------------------------------------------------------------------------
Traceback (most recent call last):
File "/home/rock/.local/lib/python3.5/site-packages/numba/errors.py", line 661, in new_error_context
yield
File "/home/rock/.local/lib/python3.5/site-packages/numba/typeinfer.py", line 455, in call
self.resolve(typeinfer, typevars, fnty)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typeinfer.py", line 474, in resolve
sig = typeinfer.resolve_call(fnty, pos_args, kw_args)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typeinfer.py", line 1314, in resolve_call
return self.context.resolve_function_type(fnty, pos_args, kw_args)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typing/context.py", line 186, in resolve_function_type
res = self._resolve_user_function_type(func, args, kws)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typing/context.py", line 238, in _resolve_user_function_type
return func.get_call_type(self, args, kws)
File "/home/rock/.local/lib/python3.5/site-packages/numba/types/functions.py", line 214, in get_call_type
out = template.apply(args, kws)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typing/templates.py", line 225, in apply
sig = generic(args, kws)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typing/templates.py", line 778, in generic
sig = method_resolver(self, ty, args, kws)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typing/arraydecl.py", line 442, in resolve_astype
assert not kws
AssertionError

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/rock/.local/lib/python3.5/site-packages/numba/typeinfer.py", line 144, in propagate
constraint(typeinfer)
File "/home/rock/.local/lib/python3.5/site-packages/numba/typeinfer.py", line 455, in call
self.resolve(typeinfer, typevars, fnty)
File "/usr/lib/python3.5/contextlib.py", line 77, in exit
self.gen.throw(type, value, traceback)
File "/home/rock/.local/lib/python3.5/site-packages/numba/errors.py", line 669, in new_error_context
six.reraise(type(newerr), newerr, tb)
File "/home/rock/.local/lib/python3.5/site-packages/numba/six.py", line 659, in reraise
raise value
numba.errors.InternalError:
[1] During: resolving callee type: BoundFunction(array.astype for readonly array(uint8, 2d, A))
[2] During: typing of call at /home/rock/.local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py (298)
--%<----------------------------------------------------------------------------
File ".local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py", line 298:
def wavelet_transform(input_image,

input_image = input_image.astype('float64', copy=True)
^

@jit
/home/rock/.local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py:237: NumbaWarning:
Compilation is falling back to object mode WITHOUT looplifting enabled because Function "wavelet_transform" failed type inference due to: cannot determine Numba type of <class 'numba.dispatcher.LiftedLoop'>
File ".local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py", line 315:
def wavelet_transform(input_image,

for scale_index in range(number_of_scales - 1):
^

@jit
Traceback (most recent call last):
File "/home/rock/.local/lib/python3.5/site-packages/numba/errors.py", line 661, in new_error_context
yield
File "/home/rock/.local/lib/python3.5/site-packages/numba/lowering.py", line 258, in lower_block
self.lower_inst(inst)
File "/home/rock/.local/lib/python3.5/site-packages/numba/pylowering.py", line 176, in lower_inst
raise NotImplementedError(type(inst), inst)
NotImplementedError: (<class 'numba.ir.StaticRaise'>, <numba.ir.StaticRaise object at 0xedc40350>)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/rock/.local/lib/python3.5/site-packages/numba/dispatcher.py", line 370, in _compile_for_args
raise e
File "/home/rock/.local/lib/python3.5/site-packages/numba/dispatcher.py", line 327, in _compile_for_args
return self.compile(tuple(argtypes))
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler_lock.py", line 32, in _acquire_compile_lock
return func(*args, **kwargs)
File "/home/rock/.local/lib/python3.5/site-packages/numba/dispatcher.py", line 659, in compile
cres = self._compiler.compile(args, return_type)
File "/home/rock/.local/lib/python3.5/site-packages/numba/dispatcher.py", line 83, in compile
pipeline_class=self.pipeline_class)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 955, in compile_extra
return pipeline.compile_extra(func)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 377, in compile_extra
return self._compile_bytecode()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 886, in _compile_bytecode
return self._compile_core()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 873, in _compile_core
res = pm.run(self.status)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler_lock.py", line 32, in _acquire_compile_lock
return func(*args, **kwargs)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 254, in run
raise patched_exception
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 245, in run
stage()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 463, in stage_objectmode_frontend
cres = self.frontend_looplift()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 435, in frontend_looplift
lifted=tuple(loops), lifted_from=None)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 1017, in compile_ir
lifted_from=lifted_from)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 385, in compile_ir
return self._compile_ir()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 893, in _compile_ir
return self._compile_core()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 873, in _compile_core
res = pm.run(self.status)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler_lock.py", line 32, in _acquire_compile_lock
return func(*args, **kwargs)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 254, in run
raise patched_exception
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 245, in run
stage()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 711, in stage_objectmode_backend
self._backend(lowerfn, objectmode=True)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 687, in _backend
lowered = lowerfn()
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 659, in backend_object_mode
self.flags)
File "/home/rock/.local/lib/python3.5/site-packages/numba/compiler.py", line 1148, in py_lowering_stage
lower.lower()
File "/home/rock/.local/lib/python3.5/site-packages/numba/lowering.py", line 177, in lower
self.lower_normal_function(self.fndesc)
File "/home/rock/.local/lib/python3.5/site-packages/numba/lowering.py", line 218, in lower_normal_function
entry_block_tail = self.lower_function_body()
File "/home/rock/.local/lib/python3.5/site-packages/numba/lowering.py", line 243, in lower_function_body
self.lower_block(block)
File "/home/rock/.local/lib/python3.5/site-packages/numba/lowering.py", line 258, in lower_block
self.lower_inst(inst)
File "/usr/lib/python3.5/contextlib.py", line 77, in exit
self.gen.throw(type, value, traceback)
File "/home/rock/.local/lib/python3.5/site-packages/numba/errors.py", line 669, in new_error_context
six.reraise(type(newerr), newerr, tb)
File "/home/rock/.local/lib/python3.5/site-packages/numba/six.py", line 659, in reraise
raise value
numba.errors.LoweringError: Failed in object mode pipeline (step: object mode frontend)
Failed in object mode pipeline (step: object mode backend)
(<class 'numba.ir.StaticRaise'>, <numba.ir.StaticRaise object at 0xedc40350>)
File ".local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py", line 302:
def wavelet_transform(input_image,

msg = "The data should be a 2D array."
raise WrongDimensionError(msg)
^
[1] During: lowering "raise <class 'pywi.processing.transform.starlet.WrongDimensionError'>('The data should be a 2D array.')" at /home/rock/.local/lib/python3.5/site-packages/pywi/processing/transform/starlet.py (302)
This should not have happened, a problem has occurred in Numba's internals.
Please report the error message and traceback, along with a minimal reproducer
at: https://github.com/numba/numba/issues/new
If more help is needed please feel free to speak to the Numba core developers
directly at: https://gitter.im/numba/numba
Thanks in advance for your help in improving Numba!

Even worse, the simple numba examples are returning wrong values:
>>> from numba import jit
>>> import random
>>> @jit(nopython=True)
... def monte_carlo_pi(nsamples):
...     acc = 0
...     for i in range(nsamples):
...         x = random.random()
...         y = random.random()
...         if (x ** 2 + y ** 2) < 1.0:
...             acc += 1
...     return 4.0 * acc / nsamples
...
>>> monte_carlo_pi(65536)
3.2379e-319
>>> monte_carlo_pi(1000000)
2.216501094359597e-301
>>> monte_carlo_pi(1)
2.2165010939451453e-301

Thanks for the report, the original error is a duplicate of https://github.com/numba/numba/issues/4185, https://github.com/numba/numba/pull/4224 fixes.

@gnthibault RE the "wrong values", I cannot reproduce:
$ cat issue4255.py
from numba import jit
import random

@jit(nopython=True)
def monte_carlo_pi(nsamples):
    acc = 0
    for i in range(nsamples):
        x = random.random()
        y = random.random()
        if (x ** 2 + y ** 2) < 1.0:
            acc += 1
    return 4.0 * acc / nsamples

print(monte_carlo_pi(65536))
print(monte_carlo_pi(1000000))
print(monte_carlo_pi(1))

$ python issue4255.py
3.1439208984375
3.141248
4.0

Is this on the self-compiled LLVM on aarch64 from here https://github.com/numba/llvmlite/issues/497?

@stuartarchibald  Yes it is, but it is actually a armhf (32bits) version that I compiled. The aarch64 is the kernel.

My speculation is that somehow Numba is querying platform properties (pointer widths, calling conventions, etc) and getting values for the kernel (64-bit) and not the process (32-bit).  The values you are seeing look like uninitialized floats, suggesting some offsets in the stack are just wrong.

Ouch... this might be much harder to fix then...

Yeah, we're still thinking about how to troubleshoot this.  We don't have a mixed 32/64 bit ARM system currently.

Ok continuing investigating this problem, I tried to recompile and 'make check-all' on my llvm build.
I have 2 failing tests:

Failing Tests (2):
LLVM :: tools/llvm-objdump/eh_frame-coff.test
LLVM :: tools/llvm-profdata/memop-size-prof.proftext

Do you have any idea about what this is and if it can explain why numba is failing in my case ?

I don't think either of those tools impact the JIT functionality, so I don't think LLVM is at fault here.  (Or at least, not in a way their tests can detect.)  We don't have any test environments where kernel pointer size != process pointer size, so it is quite possible some assumptions have crept into the Numba code base.
We ship with the test suite, so you can run the unit tests this way:
python -m numba.runtests -m &> test_results.txt

The second -m tells it to run multiprocess, since there are 8000 tests.  If things seem to be crash or freeze, you might need to drop that and run single process.  Our Raspberry Pi 3 takes 70-80 minutes to complete the test suite in multiprocess mode.
Feel free to post that to a gist and it might give us some more ideas as to where compilation is going wrong.

I will report the output here. Thank you very much for your support !

Here are the results, apparently there are a lot of failures:
test_results.txt

Ok I also tried to rebuilt python+ all dependancies inside of a fully aarch64 chroot.
Unfortunately, numba does not work inside of a chroot apparently:

/usr/local/lib/python3.5/dist-packages/numba/npyufunc/parallel.py:243: UserWarning: Could not obtain multiprocessing lock due to OS level error: [Errno 38] Function not implemented
A likely cause of this problem is '/dev/shm' is missing orread-only such that necessary semaphores cannot be written.
*** The responsibility of ensuring multiprocessing safe access to this initialization sequence/module import is deferred to the user! ***
warnings.warn(msg % str(e))
Can't read /proc/cpuinfo: No such file or directory
Can't read /proc/cpuinfo: No such file or directory
Can't read /proc/cpuinfo: No such file or directory
Can't read /proc/cpuinfo: No such file or directory
QXcbConnection: Could not connect to display

Any other option ?

The lack of semaphore based locking is not disastrous, it's there to make concurrent launches of the threading backends safer but they'll work in most cases without. That you cannot read /proc/cpuinfo is of concern, did you mount /proc in the chroot dir (and probably mounting /dev/shm there too would sort the semaphore problem out)?

Ah, I completely forgot that I could just mount those two, thank you for the suggestion

#4224 is in mainline and fixes the reported bug, closing.


Improve Docs' inheritance tree icons after newline

This PR is a follow-up to https://github.com/godotengine/godot/pull/64847.
It uses a Non-Breaking Space to prevent the icon from detaching from the name on a newline, improving the look considerably.

I find it looks lovely, just like I imagined it! 💙

Thanks!


Do not terminate if interface deleted under our feet.

Also minor comment tidy ups after fixing commenting of that routine.
Fixes issue #316.

Matt - assigned you because you are in the same time zone; relatively trivial fix, but let me know if you need more background. Thanks.

Looks fine.


Support a default branch different than master

Currently some of seniore commands rely on an existing master branch to, for example, clear a branch after sending PR.
We should rely on new git features to detect a local repository default branch.

@liferay-echo


[Epic] waku relay (browser)

Problem
See #13. Dapps and wallets are web apps running in desktop and mobile browser.
Solution
To enable developers using waku relay as a communication protocol, js-waku needs to support browser environment.
Acceptance Criteria

[ ] test suite can run in browser environment
[ ] Primitive web chat app demonstrates the usage of the API

Steps

[x] Render list of chat messages
[ ] Render chat messages (timestamp, handle, message)
[ ] React on waku relay messages
[ ] Send messages

Blocker when trying to integrated waku in the react web app: https://github.com/libp2p/js-libp2p/issues/909
Several ways to move forward

Wait for libp2p 0.31 release
Use resolutions with npm-force-resolutions but it failed to override the versions. TODO: Try again without **/
Use resolutions with yarn, however migrating to yarn failed because of ts-proto

At this stage, I am going to aim for 1. In the meantime, I can create a WakuMock and move forward with the react app and then replace the WakuMock once 1 is done or spend more time on workarounds.

Note that for 3, ts-proto 1.79.3 should fix the issue: https://github.com/stephenh/ts-proto/pull/275


TypeScript 4.x issue with esri/request

Hi,
Maybe I'm missing something but I get an error in the typings file for esri/request:
ERROR in [at-loader] typings\globals\arcgis-js-api\index.d.ts:7181:12
'request' only refers to a type, but is being used as a namespace here.
All the rest works fine, so I think something is wrong with this typing?

hi there @fhissink!
this will be fixed in 4.2. please check out the info in #43 to resolve the problem now.

Thanks @jgravois!
Sorry for the repost.
(btw, nice work at the DevSummit in Berlin :))

no worries! :honeybee:


Global CSS cannot be imported from within node_modules.

When I import the library I got the css error. Kindly anyone help to resolve this issue. I am using nextJs
./node_modules/react-apple-signin-auth/dist/AppleSigninButton/AppleSigninButton.css

What does the error say? @Fahad67
Can you replicate in a repo with a simple nextJS app?

What does the error say? @Fahad67
Can you replicate in a repo with a simple nextJS app?

I have the same problem in my React project

I have the same problem in my React project

did you manage to solve? @Fahad67

did you manage to solve? @Fahad67

@victufell No, I just use alternative because shortage of the time.

@victufell No, I just use alternative because shortage of the time.

@A-Tokyo It was css importing error while importing library in any component.

@A-Tokyo It was css importing error while importing library in any component.

@victufell @Fahad67 Can you provide a way to reproduce? Is it create react app? If so which version?

@victufell @Fahad67 Can you provide a way to reproduce? Is it create react app? If so which version?

@A-Tokyo I provided a repo for you where you can reproduce the issue:  https://github.com/skoppers/apple-sign-in-next-example
In the error message, nextjs mentions to "Reach out to the maintainer and ask for them to publish a compiled version of their dependency." https://github.com/vercel/next.js/blob/master/errors/css-npm.md
Currently a work around is to comment require("./AppleSigninButton.css"); in AppleSignInButton.js, followed by importing the css in the _app.js page like so:
import '../node_modules/react-apple-signin-auth/dist/AppleSigninButton/AppleSigninButton.css'
Lastly, since the library only works on the client side, you need to dynamically import it so that it is not used in server side rendering:
import dynamic from 'next/dynamic'

const AppleSignin = dynamic(
  () => import('react-apple-signin-auth'),
  { ssr: false }
)

Fixed here https://github.com/A-Tokyo/react-apple-signin-auth/pull/27 will be auto released in a bit as "0.0.8"


100% code coverage

We're currently at about 96% overall for coverage, with aiosmtpd/smtp.py the worst offender.  Here's the output of tox -e py35-cov.  Let's get this to 100%
Name                           Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------
aiosmtpd/__init__.py               0      0      0      0   100%
aiosmtpd/controller.py            47      0      4      0   100%
aiosmtpd/handlers.py             108      1     44      0    99%   27
aiosmtpd/lmtp.py                  11      0      2      0   100%
aiosmtpd/main.py                 105      0     22      0   100%
aiosmtpd/smtp.py                 345     22    154     11    93%   92-95, 129-130, 132-133, 145-146, 149-151, 209-211, 227, 384-386, 408-409, 420, 432, 122->exit, 128->129, 131->132, 144->145, 148->149, 226->227, 383->384, 407->408, 414->429, 419->420, 431->432
--------------------------------------------------------------------------
TOTAL                            616     23    226     11    96%

I'll just add a comment from GL #4 since that issue has been edited to really be one of coverage, so falls under this issue after the move.  And the GL project will eventually go away.  Here's what Guido had to say over there.

Actually, connection_lost() should not be a coroutine. This is a method defined in the Protocol interface; none of its methods are coroutines. You don't have to implement it, but if you do, it will be called (by the protocol) as a regular method. It should not try to block.
So how do you do something blocking in connection_lost()? You don't. You just schedule a task and let it go. The transport doesn't care anyway -- it's going to mark the connection as closed regardless of what connection_lost() does. But if connection_lost() were to block, the entire event loop would be blocked with it.
In this case I'm not even sure what you are trying to do to self._handler_coroutine (and apparently it doesn't matter, since all your tests pass :-). You might want to call its cancel() method (which won't block, and is ignored if it's already complete), since you probably don't care about whatever that coroutine does any more. Or perhaps you only want to cancel it if the exc argument is not None -- if it's None, the connection was cleanly closed (perhaps because you called close() on your end) so yo may want to just let the handler finish whatever it is doing. In any case, while you might want to wait for the handler to complete, but this is not the place to do it.
PS. One reason why your coverage shows connection_lost() is shown as never called in your coverage, even though the transport definitely calls it, may be that you accidentally made it a generator (by adding a yield). Calling a generator just creates the generator-iterator object and primes it so that when its next() method is called the generator function's body starts executing -- but the coverage machinery probably can't intercept the generator creation. But I probably shouldn't need to explain this to a bunch of core devs. :-)


ImageProxyClient: Use create-hmac package instead of crypto

We're using the ImageProxyClient also in the browser, and because of it's crypto requirement we have to polyfill the whole crypto module, which is huge and adds a lot of size to the Javascript bundle.
Since we need only the createHmac method from crypto in ImageProxyClient, I've replaced the usage of crypto in ImageProxyClient with the create-hmac module, which implements just that one function equivalently, but is much smaller.
I've tested this locally and it works well, I'm getting the same proxied URLs as before.

Nice. But IMHO it would be preferable not to use ImageProxyClient on client and generate the HTML on server, to avoid bundling these modules to clients altogether. The speed of page loads directly affects ranking on Google.

@fnesveda what happened to this? :)


Missing Course?

I tried to find the Math 300 (A & B) courses for University of Alberta on Schedule Storm, (it exists on the University site) but the search did not return any results. Anyone know how this can be solved?

Im not seeing Math 300A or 300B in the course catalog on Bear Tracks, but I do see Math 300 and that is showing up on Schedule Storm.

yes, you're right that it exists, I saw it for fall 2018
I forgot to specify, I was looking at the spring/summer 2018 terms.

Ok yup theres definitely something wrong with the scraper. I'll take a look.

Issue fixed #8


modal can't be centered

modal can't be centered, even manually (uncomment 'center_login_modal()' in the fiddle)
https://jsfiddle.net/y550z70f/5/
How to center the modal? Thanks in advance.

Modals already include logic to center them. Traditionally I would do this with
transform: translateX(-50%) translateY(-50%);

But in this case it would affect transitions that use 3d translate, like scale and flip.

As you see in the fiddle, the modal doesn't center itself automatically.
And originally I don't want to extra animation effect.
The problem is to center the modal, what about to add some parameters like: top, left, widht ,height.
Thanks.


Print exception validating msg input stream

This will help detect validation and message transformation errors in VCR

Codecov Report
Patch coverage has no change and project coverage change: +38.96 :tada:

Comparison is base (7af85ae) 14.48% compared to head (4df91f4) 53.45%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2461       +/-   ##
=============================================
+ Coverage     14.48%   53.45%   +38.96%
- Complexity     2348     7425     +5077
=============================================
  Files           773      778        +5
  Lines         60340    61934     +1594
  Branches       7384     7604      +220
=============================================
+ Hits           8740    33105    +24365
+ Misses        51093    25912    -25181
- Partials        507     2917     +2410

Impacted Files
Coverage Δ

...ambry/messageformat/MessageSievingInputStream.java
61.11% <ø> (+61.11%)
:arrow_up:

... and 527 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


setting collision between specific characters

how can I set up collision between specific player character and npc, or player and objects, so that players cannot walk over it? (See attach for example)

?

Hey @k88885180
collisions with objects can either be achieved by using the tilemap like explained here OR by placing objects as if they were characters. Just use gridEngine.addCharacter() and make sure you set collides to true in the character config.
Characters are colliding with each other automatically if they have the collides flag enabled in their configs.

Thanks so much for the quick response! On the same subject, is there a way to only set collision to specific groups of characters? As in, have players not collide with npcs, but both groups collide with objects (for example, players can walk past npcs, but neither can walk past trees).

While there are no collision layers yet, there is a feature that is called character layers.
While I think collision groups are a cool feature for the roadmap (in fact I just added this #220), you can achieve this with a workaround:
You could have one character layer for players and one for npcs. Then npcs would collide with each other and players with each other but not players with npcs. However, one problem with that approach is, that you can place only one of those groups (players or npcs) on the character layer connected to the tilemap layer.
For example let's say you have a character layer ground with a tilemap layer containing some ground tiles like rocks and trees that should collide with players and npcs. Then you can either place npcs or players on that ground layer. If you want both groups to collide with the ground tiles but not with each other, you could place an invisible tile layer called collision layer with the same tiles colliding as the ground layer. However, this is not optimal since you have to keep both layers in sync.

I see, thank you for the suggestion, I'll try this for now. Looking forward to this feature in the future!!

Hey @k88885180, I think I will start working on it now. There are more people asking for it so I think it should be the most important thing. I think it should be finished soon 👍

@k88885180 i just had the same situation today where I wanted friendly NPCs to be able to walk through the player and the new collision group feature makes this easily doable https://annoraaq.github.io/grid-engine/examples/collision-groups.html

I will close this issue because it is solved with collision groups in 2.13.0.


feature: remote volume driver

Signed-off-by: Eric Li<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Now pouch only supports local/tempfs/ceph volumes. Docker can support more volumes  with the help of volume plugin mechanism. In this PR，we implement remote volume driver, which also use volume plugin mechanism. Pouch volume plugin is compatible with docker, So we can use existing mature docker volumes drivers.
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
1. install local-persist volume plugin

installation：https://github.com/CWSpear/local-persist

After start the local-persist volume plugin, it will create local-persist.sock in /run/docker/plugins/
2. create a local-persist volume
pouch volume create -d local-persist --name test_vol -o mountpoint=/data/test_vol
CreatedAt:    2018-5-16 17:31:45
Driver:       local-persist
Labels:       map[]
Mountpoint:   /data/test_vol
Name:         test_vol
Scope:
Status:       map[mount:/var/lib/pouch/volume mountpoint:/data/test_vol sifter:Default]

#pouch volume ls
DRIVER          VOLUME NAME
local           local1
ultron          ultron_vol1
local-persist   test_vol

3. run container with the volume
#pouch run -d -t -v test_vol:/mydata reg.docker.alibaba-inc.com/busybox:latest sh
d599b56108f67e097a1f9914d79985f524e44eb17e5c394ca9b397818bf0f917

[root@pouch-test-7u-vm /root]
#pouch volume inspect test_vol
[
    {
        "CreatedAt": "2018-5-16 17:31:45",
        "Driver": "local-persist",
        "Labels": {
            "backend": "local-persist",
            "hostname": "pouch-test-7u-vm"
        },
        "Mountpoint": "/data/test_vol",
        "Name": "test_vol",
        "Status": {
            "mount": "/var/lib/pouch/volume",
            "mountpoint": "/data/test_vol",
            "ref": "d599b56108f67e097a1f9914d79985f524e44eb17e5c394ca9b397818bf0f917",
            "sifter": "Default"
        }
    }
]

the volume Status has a ref filed, which is  the container id
4. remove container and volume
#pouch rm d599b5 -f
d599b5

#pouch volume remove test_vol
Removed: test_vol

#pouch volume ls
DRIVER   VOLUME NAME
ultron   ultron_vol1
local    local1

Ⅴ. Special notes for reviews

Codecov Report

Merging #1326 into master will decrease coverage by 0.9%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
- Coverage   17.33%   16.42%   -0.91%
==========================================
  Files         189      182       -7
  Lines       11815    11304     -511
==========================================
- Hits         2048     1857     -191
+ Misses       9619     9311     -308
+ Partials      148      136      -12

Impacted Files
Coverage Δ

plugins/plugins.go
0% <ø> (ø)
:arrow_up:

daemon/mgr/volume.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container_types.go
25.31% <0%> (-4.54%)
:arrow_down:

pkg/utils/utils.go
69.79% <0%> (-2.6%)
:arrow_down:

cli/exec.go
0% <0%> (ø)
:arrow_up:

ctrd/container.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container.go
0% <0%> (ø)
:arrow_up:

client/container.go
0% <0%> (ø)
:arrow_up:

apis/server/container_bridge.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/spec_mount.go
0% <0%> (ø)
:arrow_up:

... and 26 more

Is there any way to add some integration test? @shaloulcy

@allencloud I think we can add some integration tests using the local-persist volume driver

modify some logging and add more comments. I will add more unit-tests and integration tests in other pull requests

LGTM

LGTM


Feature/startup-list

Filterable and searchable list of startups added below the timeline section.

Mobile View:

With linking to startup detail page.

Absolutely love how this is turning out. Would like to add similar info cards like y combinator directory has for company socials and founders. Feel free to use my design from the team page pr as starting point.

A tab for open positions for each company and culminated on the directory page, in other words, being able to search for open positions is definitely also a cool feature that a few startups have shown interest in 👀😁

Super minor thing, button color for filter could be either TUM.ai violet or orange-500 or so to be in the middle of the color transition (yellow-red)

Absolutely love how this is turning out. Would like to add similar info cards like y combinator directory has for company socials and founders. Feel free to use my design from the team page pr as starting point.

This only concerns the startup detail page, right? Then this would belong to the other pull request.

A tab for open positions for each company and culminated on the directory page, in other words, being able to search for open positions is definitely also a cool feature that a few startups have shown interest in 👀😁

Could you give us an example how this should look like on the directory page / startup list. Also similar to the tags we already added or somehow different?

@zausin33 there are definitely a lot of different ways but for better oversight I would start thinking about a second nav bar.
We currently have e-lab page, startups, team and open jobs. That's already a lot for a single page, so I would suggest divide and conquer haha
I like the added filter for is hiring including the integration of startup positions in each company next to a news sub page for the respective company where we could add fundraising rounds and so on. (Ref Y Combinator foto from earlier)
Additionally I wouldn't add these jobs to the startup directory directly and rather add them as separate open jobs/ startup jobs directory on a separate sub page with filters like, sales, engineering, design, project management, marketing, founders associate, ect.
Feel free to be inspired by y comb and other incubators

Ps. Don't forget to pull new changes from team page before merge conflicts arise 👀

Absolutely love how this is turning out. Would like to add similar info cards like y combinator directory has for company socials and founders. Feel free to use my design from the team page pr as starting point.

Indeed, this is an issue related to the Startup Detail Page. I will address it there.

Some things are missing regarding Data used in the Ticket. Therefore we wait on the data beeing exchanged.


Moonphase widged

Here is my contribution to your work.
A moon-phase widget, whose numeric code is derived from
https://github.com/sighrobot/Moon/blob/master/src/com/abe/moon/MoonPhase.java
The widget is icon-only, no text string because moon phases have very long spellings in english, and I was unable to fit them on screen.

Awesome work! Thank you for your request.
Why you made a new widget but you also use the GreatWidget?

Hi, you probably need only the widget.
I fiddled with GreatWidget trying to make space for longer strings, but I didn't succeed.

Ok, perfect. I will go through the code to select one of them next time I have some free time.
Thanks for the pull!


crash when starting

my game does not open, it crashes when I try to open

I would need to have the crashlog to start debug this issue.
Also I would need MC version and mod version.


No outwall.txt anymore?

Why there is no outwall.txt in output dir anymore?
Thanks

sorry about that. I've been busy w/ other stuff recently, so when I refactored the code last time, I forgot to refactor the module/ func that generates outwall.txt.
But, the thing is, i've already checked in ipaddr_util.py, and you could look into it to write your own code that generates outwall.txt. Further, you would be more than appreciated if you can submit a pull request. 😃

i just checkout c116403 to generate outwall.txt. because I dont know anything about coding.
thanks

i just checkout c116403 to generate outwall.txt. because I dont know anything about coding.

Dear friend @debiansid
May I ask why you need the list of overseas IP addresses?
Although this python repo is simple and naive, it's just a component of a larger plan rather than a standalone tool. Besides,  this repo intended for advanced users only, which means I expect end-users learn how to configure IP table rules .
That is to say, even if the requested outwall.txt is provided (either manually or programmatically)  to you, you can do very little stuff with it.  That's why I am strongly interested.....

I need outwall.txt in my ss-local as its acl to proxy all outside China IP address. Does it make any sense  to you?

I need outwall.txt in my ss-local as its acl to proxy all outside China IP address. Does it make any sense to you?

do you need just ipv4? or both v4 and v6?

@debiansid
problem resolved in<PHONE_NUMBER>74e6554d40ccb2666da19b186c0dd4
closing this ticket


Detect browser support

While testing the library I found that it does not work on Safari 10.0.3.
Is there any way to detect the support of the browser before running the test?
File API is available on Safari, buy maybe there is other dependency.
http://caniuse.com/#feat=fileapi

Thanks for raising this, I'm not aware of a reason why it wouldn't work in Safari, I'll label as bug.
I won't look into this myself but am happy to review a Pull Request.

This issue is still present and it's due to the value of the "crossorigin" value you are setting: if you remove, it it works fine.
I think you don't have to set it if it is not a cross-origin request.


[Improvement][UI] the process name or task name is not displayed completely

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
On the task definition page, the task name is not displayed completely. If the name is very short, it will not even be displayed.
A string of the same length should be displayed.
The font box should be larger, like the 2. x UI.
任务定义页面，任务名称显示不全，如果名称很短的话，甚至会不显示名称。
应该显示一样长度的字符串。
字体框最好可以再大一些，就像2.x的版本的ui。

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

it seems good on my computer

Browser problem, just change to Google Browser.

We used the 3.1.0 version of the UI to test. Because the name is too short, the problem of displaying completion no longer exists.However, when the name is greater than 22 characters, the end of the name will not be displayed completely.
Compared with version 2. x, at least 32 characters are displayed. 1. x version, displaying at least 60 characters. In addition, 1. x and 2. x will display more characters as the browser page zooms to less than 100%
At present, the characters displayed in the 3.1.0 UI are too short and cannot be displayed more characters as the page scale decreases, so it is not convenient to find tasks in the UI.
我们使用3.1.0版本的ui测试，由于名称过短而显示补全的问题已经不存在了。但是当名称大于22个字符，名称结尾的就显示不全了。
对比2.x版本，至少显示32字符。1.x版本，至少显示60个字符。而且1.x和2.x会随着浏览器页面缩放小于100%，从而显示更多的字符
目前3.1.0的ui，显示的字符过短，且不能随页面比例缩小显示更多字符，所以不方便在ui查找task。
希望ui中的名称能至少显示40个字符，且最好也能随页面缩放显示更多字符
-- version 3.1.0

-- version 1.4.5

it's seem good on my computer

We used the 3.1.0 version of the UI to test. The problem of incomplete display due to short names no longer exists. However, when the name is greater than 22 characters, the following characters will not be displayed.
Whether it is possible to optimize the display of at least 40 characters, and it is better to display more characters as the page zoomss
我们使用3.1.0版本的ui测试，由于名称过短而显示不全的问题已经不存在了。但是当名称大于22个字符，后面的字符就不显示了。
是否可以优化至少显示40个字符，且最好也能随页面缩放显示更多字符


In need of help: awesome-cli (and soon awesome-bot)

I saw something about creating a bot that would detect if a list is suitable for posting. I've quickly created awesome-cli to do just that. Currently it only checks if the README is there, but when I wake up I will do much more. Please contribute! https://github.com/jacc/awesome-cli

There's already https://github.com/sindresorhus/awesome-lint ;)

@sindresorhus I tried!


Failed to install GTK (and all needed libraries)

Hi.
I'm trying to install GTK using vcpkg in a Windows 7 Entreprise with Visual Studio 2017 Professional Edition and a windows 10 SKD 10.1.17763.132. After a sucesfully configuration of vcpkg, I obtain the following error after executing the following command  vcpkg install gtk:x64-windows in C:\vcpkg\buildtrees\libepoxy\x64-windows-rel\meson-logs\meson-log.txt

Build started at 2019-06-03T13:56:02.075278
Main binary: C:\vcpkg\downloads\tools\python\python3\python.exe
Python system: Windows
The Meson build system
Version: 0.50.0
Source dir: C:\vcpkg\buildtrees\libepoxy\src\1.5.3-d7b9d32fcb
Build dir: C:\vcpkg\buildtrees\libepoxy\x64-windows-rel
Build type: native build
WARNING: Unknown options: "enable-egl, enable-glx"
Project name: libepoxy
Project version: 1.5.3
Appending CFLAGS from environment: ' /DWIN32 /D_WINDOWS /W3 /utf-8  /MD /O2 /Oi /Gy /DNDEBUG /Z7'
Appending LDFLAGS from environment: ' /DEBUG  /INCREMENTAL:NO /OPT:REF /OPT:ICF'
Appending CPPFLAGS from environment: ' '
Appending CFLAGS from environment: ' /DWIN32 /D_WINDOWS /W3 /utf-8  /MD /O2 /Oi /Gy /DNDEBUG /Z7'
Appending LDFLAGS from environment: ' /DEBUG  /INCREMENTAL:NO /OPT:REF /OPT:ICF'
Appending CPPFLAGS from environment: ' '
Sanity testing C compiler: cl
Is cross compiler: False.
Sanity check compiler command line: cl C:\vcpkg\buildtrees\libepoxy\x64-windows-rel\meson-private\sanitycheckc.c /FeC:\vcpkg\buildtrees\libepoxy\x64-windows-rel\meson-private\sanitycheckc.exe
Sanity check compile stdout:
sanitycheckc.c
Microsoft (R) Incremental Linker Version 14.16.27031.1
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:C:\vcpkg\buildtrees\libepoxy\x64-windows-rel\meson-private\sanitycheckc.exe
sanitycheckc.obj
LINK : fatal error LNK1104: cannot open file 'kernel32.lib'

-----
Sanity check compile stderr:
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27031.1 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

-----

meson.build:1:0: ERROR: Compiler cl can not compile programs.

In another computer with Windows 10 Professional edition and Visual Studio 2017 Entreprise it works.

vcpkg env --triplet x64-windows

where $LIB:kernel32.lib
?

@Voskrese I obtain the following error:
INFORMATION: no files could be found with the specified pattern
I tried to define manually the enviroment variable LIB = C:\Program Files (x86)\Windows Kits\10\Lib\10.0.17763.0\um\x64 but it doesn't work:

If I write in a CMD:

> where $LIB:kernel32.lib
>  C:\Program Files (x86)\Windows Kits\10\Lib\10.0.17763.0\um\x64\kernel32.Lib

If I write in a CMD:

> vcpkg env --triplet x64-windows
> where $LIB:kernel32.lib
> INFORMATION: no files could be found with the specified pattern

install Win SDK ?

I did it and it doesn't works :-(

Is this issue resolved?

Please feel free to reopen this issue if you still encounter it. Thank you!


Cleanup in create wallet flow (error handling,add docstrings, deadcode)

What current issue(s) does this address?, or what feature is it adding?

remove some unnecessary code
adds/updated docstrings as per #63
add some return value checks/decisions

How did you solve this problem?
see above
How did you make sure your solution works?

python -m unittest discover neo

Did you add any tests?
no
Did you check your pycodestyle?
yes
Are there any special changes in the code that we should be aware of?
no
Are you making a PR to a feature branch or development rather than master?
development

Coverage increased (+0.003%) to 67.735% when pulling 2dd7892024d56f35a873445330afc67e246a54b6 on ixje:development into daf700d9c365a64d619148b3c029eb827863a260 on CityOfZion:development.

Coverage increased (+0.003%) to 67.735% when pulling 405b6f93a2ccf9b6e985dbb79a17cc04b9d24a45 on ixje:development into daf700d9c365a64d619148b3c029eb827863a260 on CityOfZion:development.

Coverage increased (+0.006%) to 67.738% when pulling 97ecbb99c74c2a690f01118b9ec74e3b95bb7a72 on ixje:development into daf700d9c365a64d619148b3c029eb827863a260 on CityOfZion:development.

Coverage increased (+0.006%) to 67.799% when pulling aa20dbda20603f8d74f2ff11a33b252f0fe85c57 on ixje:development into b67dcace0540a65080facd71e4739e16bc2dae1b on CityOfZion:development.

Coverage increased (+0.003%) to 67.796% when pulling 2c11abed38a82d61a58a233ad1bd3a33c1b69ac0 on ixje:development into b67dcace0540a65080facd71e4739e16bc2dae1b on CityOfZion:development.

Coverage increased (+0.003%) to 67.843% when pulling db617bf37e7ea303c9fa2fabd81584cf418f1756 on ixje:development into 58ee377043934e4fe8e7674d7ab0ced470c664fe on CityOfZion:development.

This PR still says 'changes requested', but it looks like that has been resolved. @metachris is this ok to merge?

We're working on it! 3 things I would like to still improve:

https://github.com/CityOfZion/neo-python/pull/92/files#diff-f1c26fe160bdce08834e51e99d427cefR909
https://github.com/CityOfZion/neo-python/pull/92/files#diff-8acf03fcba903c22586f9efc6a394aa0L111
https://github.com/CityOfZion/neo-python/pull/92/files#diff-51c9e721b63b4d4727f5d7f5423a5017R226 -- there is an ongoing discussion about handling this

Should soon be there.

Coverage decreased (-3.4%) to 64.234% when pulling b48982dbaae72a8be8ad2dada2ea8de8e3bebb38 on ixje:development into 3b4441c53dffa93b8bb11d4a76dfda7e4932b981 on CityOfZion:development.

Coverage decreased (-0.006%) to 67.639% when pulling b48982dbaae72a8be8ad2dada2ea8de8e3bebb38 on ixje:development into 3b4441c53dffa93b8bb11d4a76dfda7e4932b981 on CityOfZion:development.

Coverage decreased (-0.003%) to 67.642% when pulling 79d5e0c816812ed61cf0dc36731471135d1c33ad on ixje:development into 3b4441c53dffa93b8bb11d4a76dfda7e4932b981 on CityOfZion:development.

Looks good to me now 👍

Coverage decreased (-0.003%) to 67.642% when pulling f062cfe1667dee00aebdd06267672d21119f2c3b on ixje:development into 3b4441c53dffa93b8bb11d4a76dfda7e4932b981 on CityOfZion:development.

This is a great collaboration, thanks @ixje and @metachris !


Spike: Identify Why Notifications Take Over 4 Hours

User Story - Business Goal
There is a cron job Celery task that runs every 15 minutes, looking for notifications that were created over 4 hours ago but have not been sent.
User Story(ies)
As a service using VA Notify
I want my messages to send within a few minutes of my POST being accepted
So that I can give timely notifications to Veterans
Additional Info and Resources
NOTE: This has been narrowed down to almost certainly be related to a "race condition" between persist_notification and some other methods in our code (such as looking up the communication item id). The API creates an adhoc notification object but a celery task creates the persistent Notification object. It is possible for the request to be processed before the Notification object has been populated.
AWS Search parameters: "to the delivery queue because the notification" -"message"

Code:

Datadog search parameters: message:*to\ the\ delivery\ queue\ because\ the\ notification*
NOTE: This is over 1 week so I could see how many notifications we see at peak (48 in this case)

Staging has the following notification that was stuck in this status ea57b880-cb2b-4c38-ad5b-a930f4146b27

MJ Notes:

Last week when we were looking into a production issue, Dave noticed the following exception in the logs for BVA: raised unexpected: NoResultFound('No row was found when one was required')

https://github.com/department-of-veterans-affairs/notification-api/blob/master/app/dao/communication_item_dao.py
This should mean that we attempted to look up the communication item id for the applicable notification template in our database and were unable to find a matching row

After looking into this, we identified the notification which was stuck in "created" status, traced it back to the applicable SMS template, and confirmed the communication item id on the notification template was valid
After the 4 hour mark, upon being retried by the celery task referenced in this ticket, the notification was successfully delivered

Acceptance Criteria & Checklist

[ ] We have identified and documented (in future tickets) what leads to these falling through the cracks
[ ] Learnings have been shared with the team, and decisions have been documented
[ ] Tickets for next steps have been identified and created

Completed research addresses the problems and/or answers the questions below:

Why are notifications getting stuck in a created status and getting reprocessed after 4 hours?
How can we fix the root cause(s) to reduce the amount of notifications falling back into this retry pattern?

Timebox
1 day

Hey team! Please add your planning poker estimate with Zenhub @EvanParish @justaskdavidb2 @k-macmillan @kalbfled @ldraney @nikolai-efimov @cris-oddball


Add test of run_ogusa_example.py

We should have a unit test to ensure that run_ogusa_example.py runs.  At least one version of this test should be short and just test that the script executes for at least 5-10 minutes.

@jpycroft is working on a timed version that maybe suitable for Travis CI.
I'm also trying to update the test_run_ogusa.py module so that it tests the full run of the example script.  I've tried:
from subprocess import call

@pytest.mark.full_run
def test_run_ogusa_example():
    file_to_run = os.path.join(CUR_PATH, '..', '..', 'run_examples',
                               'run_ogusa_example.py')
    call(["python", file_to_run])
    assert True

But the behavior is not as expected - and has resulted in a system failure when running.

This test has been added with PR #639


Attempt to fix broken image links in Discovery book

This PR pools together PRs #130 and #131 from @ChouzArt and adds 2 more commits that I created to correct other failing links missed by the first 2 and to modify the Travis verification steps to skip the checking of print.html - @ChouzArt has previously pointed out that https://github.com/rust-lang-nursery/mdBook/issues/789 causes mdbook to generate an incorrect print.html file when relative links are used in the book content. Skipping verification of print.html during Travis runs means that we will still have a bad image links in print.html but the main Discovery book pages will have working images again and they will show up here on GitHub as well. I realize that this isn't a perfect solution but I thought that people might find it better than the current situation.
The main reason I am creating this PR is to:

See if it will pass Travis.
Get people's feedback on this half solution.

If we decide to take this PR then there are a few other things that need to be done:

Create a new issue to track the fact that we should revert this ignoring of print.html during link checking once the mdbook issue is resolved.
Make a similar change to the Bookself version of the Travis script.

I should also point out that running a sed script on print.html can fix most of the link issues that it contains so that the images will at least show up in a printout. Something like:
cp book/print.html print.html
sed 's: src="\.\./assets/: src="assets/:g' <print.html >book/print.html
rm print.html

I guess Travis doesn't really check much. Is it bors that runs the actual checking part of ci/script.sh? If so, who is allowed to ask it to just try a test pass and not push up to master?
Thanks!

@adamgreen Yes, you can do bors try. I believe anyone can do that.
bors try

@therealprof Thanks! Seems like it worked around the print.html failures. That makes me happy!

bors r+


Added list empty Run Code link

Added the rest of the list Run Code links.
Also fixed some errors in the splice example.


Changes to support ICS network on windows

We were missing some basic properties. Added that.
Signed-off-by: Sandeep Bansal<EMAIL_ADDRESS>

LGTM

@sanimej PTAL

@mrjana @mavenugo PTAL. We have moved to self hosting ICS networks and this is causing issues with docker startup

LGTM (not a maintainer on this repo).

LGTM


Hook function error - Keyboard Joystick

Initializing...
2Failed to hook a function: KeyboardJoystick_HandleHud
The console stays open but says that it failed to hook a function
How can i fix this?

Are you playing the game with a controller?

Are you playing the game with a controller?

Since this issue is inactive, I'm closing it for now

Since this issue is inactive, I'm closing it for now

I am just using a keyboard and mouse, no controller

I am just using a keyboard and mouse, no controller

Okay and does the cheat works even with error ?
What version of the game do you have ?

Okay and does the cheat works even with error ?
What version of the game do you have ?

Latest version of the game, from steam

Latest version of the game, from steam

And the cheats do not work

And the cheats do not work

There is an answer here #24 #29 #27 #8 #30 #3 or here https://github.com/Escartem/AmongUsCheatClient#supported-versions
Basically I need to update the cheat to work on newer versions


Feat/manual changesets

Part-1 of manual approach -> allow contributors and maintainers to optionally install the Github App and create the changesets manually
Pending Part-2 of manual approach -> enforce that changesets manually created by a user follow the rules defined
Other updates:
Refactoring of main.js done for better readability

I Like the refactor. Its so much easier to read. A few overall comments:

Try not to combine multiple changes in a single PR makes it harder to understand which change is relevant to the actual feature.
You right! It is my mistake. But for this specific case, it is sort of annoying to do the testing in Github itself or add commit messages for every atomic change. I would like your feedback on this. Feeling that I loose too much time creating atomic commits. But you have indeed an important point!
Splitting the main file would have been nice, but i like the code splitting so far.
Just finish this. Took me a while. Now is much cleaner.
Nice job on making sure that there are tests on this!
This will take tons! I have a friend that wants to collaborate on OpenSearch. I told him best way is to work with me on this feature. I will give you more updates after talking with him.

You right! It is my mistake. But for this specific case, it is sort of annoying to do the testing in Github itself or add commit messages for every atomic change. I would like your feedback on this. Feeling that I loose too much time creating atomic commits. But you have indeed an important point!

You dont need to make atomic commits, just splitting the refactor out into its own PR would be sufficient

Mmmm I see. So you mean that the best practice is to work on each new feature or refactor in a separate PR, correct?

This looks good to me! Lets merge it!

Perfect. Continuing to merge!


Change strlen to mb_strlen

fix remaining strlen usages

Can you also add  mbstring extension requirement to composer.json file?
"require": { "ext-mbstring": "*"}
It's not enabled by default in many cases.


add reference to mobile agent spec

minor addition here. @bmorelli25 wanted to get your input on wording.


When no GTFS file exists, upload a "dummy zip": GTFS_PLACEHOLDER.zip

 When no GTFS file exists, upload a "dummy zip": GTFS_PLACEHOLDER.zip


Missing DOM HTML elements

These HTML element classes are defined in Google Chrome but missing from dom.js definitions:

[ ] HTMLAreaElement
[ ] HTMLBodyElement
[ ] HTMLContentElement
[ ] HTMLDataListElement
[x] HTMLDetailsElement
[ ] HTMLDialogElement
[ ] HTMLDirectoryElement
[x] HTMLFieldSetElement
[ ] HTMLFontElement
[ ] HTMLFrameElement
[ ] HTMLFrameSetElement
[ ] HTMLHeadElement
[ ] HTMLHtmlElement
[x] HTMLLegendElement
[ ] HTMLMapElement
[ ] HTMLMarqueeElement
[ ] HTMLMeterElement
[ ] HTMLModElement
[ ] HTMLObjectElement
[ ] HTMLOutputElement
[ ] HTMLParamElement
[ ] HTMLPictureElement
[ ] HTMLProgressElement
[ ] HTMLQuoteElement
[ ] HTMLShadowElement
[ ] HTMLTableColElement
[ ] HTMLTitleElement
[ ] HTMLTrackElement

This list was generated with:
Object.getOwnPropertyNames(window).filter(n => /^HTML/.test(n)).join("\n")

@mislav I implemented the HTMLObjectElement class. Should I open a pull request?

@ghodir Always feel free to open a pull request!
Keep in mind that adding some tests for this could be useful. See existing tests/dom/*.js files. Re-run tests with make && ./runtests.sh bin/flow dom. Record new test expectations with ./runtests.sh -r bin/flow dom.

https://github.com/facebook/flow/commit/7b971fbd7b0ec8c66613459eac6cfd31a0237b26 added a bunch, I updated the checklist above

@mroch Fantastic; thank you

HTMLSummaryElement is not on this list! Should I open a new issue or can we add it to this one?

@romeovs The specs suggests that <summary> does not have its own HTMLSummaryElement interface and that it instead uses HTMLElement https://html.spec.whatwg.org/multipage/interactive-elements.html#the-summary-element
Similarly, Google Chrome does not seem to have HTMLSummaryElement defined either.


Correcting QPROF explain plan + DC SLOW EVENT

Closes:
https://jira.verticacorp.com/jira/browse/VER-94645?filter=-1 https://jira.verticacorp.com/jira/browse/VER-94644?filter=-1
https://jira.verticacorp.com/jira/browse/VER-93871?filter=-1

@afard @vikash018 and @mail4umar I need your help to correct the tests from this PR. My changes should not affect the other tests, it is related to numpy versions apparently.


Code search support

It would be a nice feature to have

We plan on opening up the API we use for Codeium Search soon. At that point in time it will be possible to support search in our other extensions, like emacs. We might need some help from the community to actually implement this feature.


Is there expand_all_subnodes?

I have seen the built-in action close_all_subnodes, but the expand_all_subnodes seems to be missing. How can we expand one directory recursively?

there is one in the wiki under https://github.com/nvim-neo-tree/neo-tree.nvim/wiki/Recipes#emulating-vims-fold-commands

Hi,
@ghostbuster91 suggested solution didn't work exactly as intended for me. I had keep pressing the corresponding key to expand the node one extra level each time while I wanted all the sub directories to be expanded at once.
Looking into the code to debug it I found that the implementation already exists.
Here is my solution for those coming around here before this makes its way into the plugin:
local function open_all_subnodes(state)
  local node = state.tree:get_node()
	local filesystem_commands = require("neo-tree.sources.filesystem.commands")
	filesystem_commands.expand_all_nodes(state, node)
end

require("neo-tree").setup({
  window = {
    mappings = {
      ["O"] = open_all_subnodes,
    },
  },
})

@paulroseau Sorry, I forgot to follow up here. Yes that solution got broken at some point. I then fixed it in https://github.com/nvim-neo-tree/neo-tree.nvim/pull/957


You may wanna upgrade your Chrome

Looks like it's got an update waiting...

What?

That's what the green indicator means in this screenshot on your readme.


Streak broke

The following two problems occured for the javascript course
I was going for a full month streak on freecodecamp and I was surprised that my submitted solution)one solution) yesterday was removed for some reason and when I came back today I saw that the question is not marked as solved even though I submitted it yesterday and passed!
The second issue that I solve ordered questions(same order as freecodecamp curriculum) but one of the questions that I solved two days ago was marked as not solved as well!
Affected page
Add a Link to the page with the problem.
https://www.freecodecamp.org/mkhasib
Expected behavior
A clear and concise description of what you expected to happen.
I was expected for the results to be saved not to be lost and the streak to break
Screenshots
If applicable, add screenshots to help explain your problem. you can drag and drop, png, jpg, gif, etc. in this box.

System (please complete the following information):

Device: [e.g. iPhone6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.4]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]

Additional context
Add any other context about the problem here.

Thanks for reporting.
Do you mind emailing us at<EMAIL_ADDRESS>from your registered email as well while we look into this? You do not need to add too many details other than a link to this issue for now.

Hey @scissorsneedfoodtoo could you let us know how this went, is this a bug on ourside?

Hey @scissorsneedfoodtoo could you let us know how this went, is this a bug on ourside?
I don't know why the problem happened but I broke the streak yesterday(didn't submit any challenges)
Thanks for your time guys, I really appreciate it !

@raisedadead, I wasn't able to determine if it's a bug on our side or not. Looking at @MKhasib's record everything seems fine -- there were no obvious gaps in progressTimestamps or completedChallenges, at least as far as I could tell.
It may have been a temporary connection issue when the challenge in question was submitted.

Awesome. Thanks for confirming.


[KNI] Makefile: build: use shared libraries

In some cases we don't really need the fully static compilation and we can depend on system libraries.

What is the benefit of this change?

/lgtm
/approve
We had offline discussion about the benefits

/hold cancel
let's not backport this yet (if ever)

/cherry-pick release-4.13


Join button is below the screen on landing page

May need to rearrange the text or shrink the landing page graphic.

Going ahead and taking this... @rickr

@hollomancer looks like we've resolve this with the email/zip code on landing. We can re-open if need be.

Closing due to redesign


Adding ability to send version info header on HTTP requests.

Added an "extra headers" feature to enable this. I am not a fan
of changing Connection() so haphazardly, but I hope to
completely re-factor / destory Connection() in the near-term
so I am less worried.
This only adds the storage and datastore header info, for the
purposes of a simple review. Once we agree on the approach,
I can add support in the other subpackages.

Thanks @tseaver. Will hold off for @lukesneeringer review before merging

Will follow up with a PR for all other HTTP impls and then a separate PR getting this to work with GAPIC generated surfaces


RTMP stream not playing

I am trying to embed the rtmp stream rtmp://<IP_ADDRESS>/vod. But it's not working. In my console, following error is displayed:
http://pot.hpcashewnuts.com/custom-post/liop/build/mediaelement-flash-video.swf Failed to load resource: the server responded with a status of 404 (Not Found)
http://pot.hpcashewnuts.com/custom-post/liop/ is my website post url
Please can you help me with this?

Do I need to include a pluginPath option in my js?
I am using mediaelement.js in the WordPress plugin and it seems that it is not getting the correct path
http://pot.hpcashewnuts.com/wp-includes/js/mediaelement/mediaelement-flash-video.swf

Adding pluginPath: '/wp-includes/js/mediaelement/' in js options resolved my issue

Adding pluginPath:  '/wp-includes/js/mediaelement/' resolved the issue in Chrome but still not working in Firefox and Mobile browser Safari

I am using this link for testing: rtmp://<IP_ADDRESS>/vod/mp4:bigbuckbunny_1500.mp4

RTMP won’t work on iOS since it requires flash and Apple doesn’t support Flash

Thanks but RTMP plays neither in FireFox nor on Internet Explorer.

@Himani3010 is this issue still present in 4.2.14 ?


run continues after setup_openmm fails

Here is an example:
Setup incomplete!
GPUindex must be an integer, or "default". Given:
Try rerunning setup_openmm again.
Since the sim can still run, we need to rethink this message and the impacts setup_openmm failing

added numerous checks.  see commit 34155fc


[Bug]: Enable widget renaming using keyboard shortcut on the entity explorer

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Extension of #9413
Fix from #9413 enables widget renaming by pressing on F2 when in focused mode. The widget also goes into focused mode when user selects the widget from the entity explorer and pressing on F2 at this time causes widget name on property pane to be highlighted. This can be confusing since performing an action on the entity explorer is causing a reaction in a different area of the screen (property pane). In addition, we currently allow widget renaming from entity explorer hence a keyboard shortcut would go hand-in-hand to this feature.
Steps To Reproduce

Select a widget from the entity explorer and press F2 to rename the widget. Observe the widget name on property pane is highlighted instead of the entity explorer.

Environment
Production
Version
Cloud

Stats

Stat
Values

Reach
300

Effort (months)
1