10/13/2022 Publish

Learn Build status updates of commit 1d53a18:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

2017-03-09-profile/docs-ref-autogen/aks.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/iot/central/device-template.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/iot/central/export.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/iot/central/export/destination.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/iot/central/job.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/p2s-vpn-gateway.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vhub.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vhub/bgpconnection.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vhub/connection.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vhub/routing-intent.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vpn-gateway.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vpn-gateway/connection.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vpn-site.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2017-03-09-profile/docs-ref-autogen/network/vwan.yml
:bulb:Suggestion
View (azure-cli-2017-03-09-profile)
Details

2018-03-01-hybrid/docs-ref-autogen/aks.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/iot/central/device-template.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/iot/central/export.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/iot/central/export/destination.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/iot/central/job.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/network/p2s-vpn-gateway.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/network/vhub.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/network/vhub/bgpconnection.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/network/vhub/connection.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/network/vhub/routing-intent.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

2018-03-01-hybrid/docs-ref-autogen/network/vpn-gateway.yml
:bulb:Suggestion
View (azure-cli-2018-03-01-hybrid)
Details

This comment lists only the first 25 files in the pull request.

2017-03-09-profile/docs-ref-autogen/aks.yml

Line 1172, Column 39: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'target' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 1193, Column 290: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'target' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/iot/central/device-template.yml

Line 34, Column 170: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Device' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 180, Column 170: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Device' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/iot/central/export.yml

Line 209, Column 167: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Export' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/iot/central/export/destination.yml

Line 237, Column 172: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Destination' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/iot/central/job.yml

Line 44, Column 162: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Job' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/p2s-vpn-gateway.yml

Line 184, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 190, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vhub.yml

Line 208, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 211, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vhub/bgpconnection.yml

Line 179, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 182, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vhub/connection.yml

Line 219, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 222, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vhub/routing-intent.yml

Line 165, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 171, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vpn-gateway.yml

Line 172, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 178, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vpn-gateway/connection.yml

Line 221, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 224, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vpn-site.yml

Line 221, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 228, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

2017-03-09-profile/docs-ref-autogen/network/vwan.yml

Line 145, Column 93: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'indexToRemove' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 151, Column 116: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'value' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


HighRes Image Loading Failure in iOS 18 with KFImage in List/ForEach

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
What
On iOS 18 (Xcode 16.0), KFImages frequently fail to show up when used inside List/ForEach.
I have high quality images and use the DownsamplingImageProcessor, but only some of them load successfully, while the rest remain stuck in a loading state, and I see the following log:
nw_connection_add_timestamp_locked_on_nw_queue [C1] Hit maximum timestamp count, will start dropping events
Interestingly, if I switch from WiFi to 5G, the images start loading again, but the loading stalls once more after a few additional images, showing again the same message log.
Reproduce
@State var allImages: [String] = //the content of this array is in https://oldschool.cat/allImages.swift please copy paste here the content

    var body: some View {
        NavigationStack {
            List {
                ForEach(allImages, id: \.self) { release in
                    if let image = URL(string: release) {
                        KFImage(image)
                            .placeholder {
                                ProgressView()
                            }
                            .retry(maxCount: 3, interval: .seconds(3))
                            .setProcessor(DownsamplingImageProcessor(size: CGSize(width: 100, height: 100)))
                    }
                }
            }
        }
    }

Other Comment
You can check the behaviour in this video: https://youtu.be/043Uy0i9LcE

Upon investigating the URLs provided, I found that the server is returning HTTP status code 429 (Too Many Requests), indicating that the requests are being rate-limited.
Error: responseError(reason: Kingfisher.KingfisherError.ResponseErrorReason.invalidHTTPStatusCode(response: <NSHTTPURLResponse: 0x6000003116a0> { URL: https://i.discogs.com/....NC5qcGVn.jpeg } {
    Status Code: 429, Headers
{
    "Alt-Svc" =     (
        "h3=\":443\"; ma=86400"
....
}

This status code 429 is specifically designed to indicate when a user has exceeded the allowed number of requests within a given time period. The server implements these rate limits to prevent excessive concurrent requests (such as multiple simultaneous image loads). This explains why switching networks temporarily resolves the issue - the new network connection presents a different client IP address to the server, effectively resetting the rate limit counter.
Since this is a server-side rate limiting mechanism rather than a Kingfisher-related issue, I recommend closing this ticket. Please don't hesitate to reach out if you have any additional questions or concerns.

Thanks for the answer @onevcat , that make sense now. I've checked the server rate limits and it says:
Your application should identify itself to our servers via a unique user agent string in order to achieve the maximum number of requests per minute.
I guess i'll configure the user-agent in ImageDownloader to get the maximum quota.


Fix rotations for debug wireframes

Fix orientation of wireframe not lining up with orientation of shape. Also, change the halfExtents default so that it matches the default shape of a box.

Thanks!


Could not release on artifactory

Bug description
We used jfrog/artifactory (cloud) as registry for private crates.
We can cargo fetch  ... cargo publish.
But when we try to use release-plz we got error to retrieve metadata
On github runner  (ubuntu-latest):
Caused by:
    0: timeout while publishing axum-extra-derive
    1: failed fetching sparse metadata
    2: error sending request for url (https://mycompany.jfrog.io/artifactory/api/cargo/mycompany-cargo-local/index/ax/i-/axum-extra-derive)
    3: client error (Connect)
    4: error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:ssl/record/rec_layer_s3.c:907:SSL alert number 120
    5: error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:ssl/record/rec_layer_s3.c:907:SSL alert number 120

On local (macos x86):
  2024-09-09T10:58:34.754858Z ERROR  can't determine if package is published

Caused by:
    0: timeout while publishing axum-extra-derive
    1: failed fetching sparse metadata
    2: error sending request for url (https://mycompany.jfrog.io/artifactory/api/cargo/mycompany-cargo-local/index/ax/i-/axum-extra-derive)
    3: client error (Connect)
    4: Fatal alert

Stack backtrace:
   0: std::backtrace::Backtrace::create
   1: std::backtrace::Backtrace::capture
   2: anyhow::error::<impl core::convert::From<E> for anyhow::Error>::from
   3: <tokio::time::timeout::Timeout<T> as core::future::future::Future>::poll
   4: release_plz_core::cargo::is_published::{{closure}}
   5: release_plz_core::command::release::release_package_if_needed::{{closure}}
   6: <tracing::instrument::Instrumented<T> as core::future::future::Future>::poll
   7: release_plz::run::{{closure}}
   8: tokio::runtime::park::CachedParkThread::block_on
   9: release_plz::main
  10: std::sys::backtrace::__rust_begin_short_backtrace
  11: std::rt::lang_start::{{closure}}
  12: std::rt::lang_start_internal
  13: _main
  14: <unknown>

Timeout is not the root cause, because it failed immediately, the wrong error message/context is another topic.
I guess both errors are related because the request uses native-tls that imply a different behavior on mac & linux regarding SSL and HTTP 2.0

Would you like to work on a fix? Y

I have a workaround, I can make a PR

On my local fork I forced the use of HTTP 1.1 to retrieve metadata, it works on Mac but seems slow.
As a more general proposal, I'm exploring http2 as currently but retry with HTTP 1.1 if there is an error during the request (slower for people like me, but no impact for crates.io and others)
Can I open a PR to discuss the details?

To Reproduce
Steps to reproduce the behavior:

setup a cargo registry sparce+index over HTTP 1.1 (not only http2), or use artifactory (commercial version)
try to release a crate on it

Expected behavior
No error
Environment

OS: macos x86 and gihub runner
release-plz version: 0.3.87
registry: jfrog/artifactory cloud (sparce+index)

Can I open a PR to discuss the details?

Sure!

Thanks for the release, I'll test on github runner with our jfrog to check if it also solve the ssl issue as expected


Update to Cats 0.7.0 and catbird snapshots (do not merge)

:+1: looks like good changes. I hope we can do a few more PRs before the next release.


Add a desktop platform

Why don't you create a desktop platform (say, based on SDL or GLFW) to make it easier for development?
If you're interested in this, I may try adding it too. Just say if you care whether SDL or GLFW (or something else) should be used as the underlying platform independent layer.

A desktop platform is really out of scope for this project, and I'm not show how it would make development easier.
If you're making an app that works on both desktop and mobile, using both GLFW and GLFM is a pretty good idea, since they are pretty similar.

Of course if you want to release to a desktop platform glfm doesn't have enough features for all configurations (like for example GLFW does). My point is that during development is often much easier and faster to debug a native application, than deal with simulators and emulators (or, even worse, browsers). The ability to use your favorite debugger is a big advantage and time-saver in development.
A glfm desktop platform wouldn't be meant for releasing to a desktop target but for fast development, where the programmers can spend most of their time using their favorite IDEs and debuggers.
A big additional feature is hot-swapping code, which is often impractical to impossible on glfm's current target platforms, but relatively easy on desktop ones. Hot-swapping is typically reserved for the development cycle and disabled in releases, which have binaries linked into a single executable for optimization.

Wouldn't a GLFW backend do fine?

This idea is really out of scope for this project, and could potentially cause more problems than it solves. (GLES contexts may not be available on all systems, for example)
If you don't want to use Xcode, Android Studio, or the simulators for everyday development, I'd recommend using GFLW instead, and later port the app to GLFM.


Upgrade solidity generator

Will not address before v2 release. So much has changed we might as well start anew.


forgejo: 8.0.0 -> 8.0.1, forgejo-lts: 7.0.6 -> 7.0.7, forgejo,forgejo-lts: fix passthru.updateScript

Description of changes
https://codeberg.org/forgejo/forgejo/releases/tag/v8.0.1
https://codeberg.org/forgejo/forgejo/milestone/7682
diff: https://codeberg.org/forgejo/forgejo/compare/v8.0.0...v8.0.1
https://codeberg.org/forgejo/forgejo/releases/tag/v7.0.6
https://codeberg.org/forgejo/forgejo/milestone/7682
diff: https://codeberg.org/forgejo/forgejo/compare/v7.0...v7.0.6
Fixes a XSS vulnerability. See the respective milestones for more details.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

aarch64
/nix/store/mpgdbibvr11r190i6gc0vd785iwm6cvj-vm-test-run-forgejo-mysql
/nix/store/w1iskpjxq4921jszvp4vlisva7cgjziw-vm-test-run-forgejo-postgres
/nix/store/bm0mwsxlj09r2mbjgc9y6f9cdnzqxhhp-vm-test-run-forgejo-sqlite3
/nix/store/y0fpmknwl462n31yp5413g2iksaj8bqd-vm-test-run-forgejo-mysql
/nix/store/469drvzg7l83d95zn82g55wq6r5dypfk-vm-test-run-forgejo-postgres
/nix/store/ipq2299pflx02ylqn9pvipmavsmfarf1-vm-test-run-forgejo-sqlite3


Update stable.txt url

It looks like we need to update the URL for stable.txt file, the one on the googleapis is supposed to be gone (or not updated automatically any more).
The new URL is: https://dl.k8s.io/release/stable.txt
PS: I will create another PR to update it on kubernetes-sigs/verify-conformance repo as well.
/cc @BobyMCbobs

Thank you, good find!
/lgtm
/approve


[P_UI] Added django settings for p_ui

This PR improves a few things:

adds the ability to define normal Django settings that can be used in P_UI
adds the proxy option to the vite config, that way we the api and vite dev server run on the same url
added current url als default server
make host list configurable via Django settings
added option to don't render the host list edit button
use polling only for wsl

@matmair Can you help me here with the remaining issues?

Would be ready for merge from my POV, I added the translating commands to the netlify build process so that the ui previews right.

@SchrodingersGat this would be ready for review and merge

@SchrodingersGat just a gently ping on this pr.

@wolflu05 thanks for the reminder :)
Can you run me through how the settings get from .py to .ts? Are they simply rendered into the index.html page?
If so, does this get rendered "live" by the server? What happens if the backend settings change?

Are they simply rendered into the index.html page?

Yes, they get rendered into the index.html page accessible on the global window object.

If so, does this get rendered "live" by the server? What happens if the backend settings change?

Settings change in the config file/env variable requires a server restart until the new settings are available. Due to the implementation from @matmair the server list settings only get changed if they are not already saved in the local storage. So you need to clean your local storage until the new server list takes affect or use a new private tab for testing each time.

Ok, happy with that. Thanks for getting this up and running :)


[bug]: test suite stop if application stops

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
Testing stops with the application (system under test) if it crashes.
Steps to reproduce

Record tests (some should make app crash)
Run test suites
Tests after the crashes aren't executed

Environment
Deploy preview
Version
Local

closes by PR: (https://github.com/keploy/java-sdk/pull/31)


Pin mkdocs lower then 1.5 since it fails

mkdocs fails in 1.5 and 1.5.1, there is already an issue: https://github.com/squidfunk/mkdocs-material/issues/5772
hopefully this PR fixes it: https://github.com/squidfunk/mkdocs-material/issues/5778
When the above is merged we can test to remove the pin.

@tjeerddie, FYI, I've removed this pin in the branch feat/partner-meeting-doc-updates as it seems to be building docs just fine locally on 1.5.3.


Add support for more languages

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Your project is available only for assistants in these languages: ["en", "de", "pl", "es", "it", "fr", "pt", "hi"]
Otherwise it appears as disabled, and can't be used.
I don't see why all of them couldn't be added to this list, since it just makes robot sounds anyway.
Describe the solution you'd like
For my use case, at least support Croatian (ISO "hr")
Describe alternatives you've considered
No real alternatives. The only option I have is to use English for the whole Assistant, but that is not what I want.
Additional context
Here is the code:
https://github.com/vigonotion/tts.astromech/blob/81286b37eb5c9bea42824a29e04308441211ce46/custom_components/astromech/tts.py#L76

See PR https://github.com/vigonotion/tts.astromech/pull/5#issue-2376272067


How to dismiss the presented Model view by clicking on some button ?

I was wondering if I could dismiss the presented Model  view by clicking on button like cancel button ?

Have you tried this on IBAction of Cancel button:
delegate.isDismissEnabled = true

Absolutely, but nothing happened.
I meant what to do after this to dismiss the Model ?


Update ArcGIS to latest API

As per
https://developers.arcgis.com/rest/geocode/api-reference/geocoding-find-
address-candidates.htm the find operation has been deprecated. This
migrates to the findAddressCandidates operation but utilising the
singleLine functionality which mirrors the old find operation.

I've created another PR based on this, because git push to this branch is not allowed to me.
@jmb thank you for this! Closing in favor of #287


attempt custom css

not quite sure this works, but it should be a good start

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@cf094c5). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   58.35%
=======================================
  Files           ?        9
  Lines           ?     1119
  Branches        ?        0
=======================================
  Hits            ?      653
  Misses          ?      466
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore: add cors headers

This LGTM, but for the invitation form to work we'll also need the headers to be present on the OPTIONS /users request that is not handled by our backend but by the API gateway directly I think


/rr region doesn’t work

/rr region [name]
It does not work, it will always say that there is no region with that name.

Hi there!
Are there any Logs? Does the command auto-complete?

No further response from reporter.


fix: Patch incrementing

Fix increment patch to pull current patch from existing generated file if it exists.

Working now. see https://github.com/balancer/tokenlists/pull/1664#pullrequestreview-2358346882
This is a little funky in that it ignores the present patch version in the metadata.ts file, but not sure how else to handle it. Makes sense that applications may not pull updates without a bump in version number.
@garethfuller this work?

@franzns added you as somehow it was not showing up that there was an approved review yet.  Once I added you turned green.  LMK if you have questions about this.  Just making our tokenlist easier for others to import.  See here #1658 for some ideas how to add some validation if you rebuild this  logic somehow.

Just mentioning that this tokenlist might become deprecated soon.


Improve package.json example

Show the enclosing importSort key so users can copy-paste into their package.json
Fix the link to the eslint rule
Mention the example projects
Remove comment about previous versions

Thanks for the improvements!
I removed the links to example projects, because they are not really good examples right now.


Payload V3

Any plans to adapt to V3 of payload?

Any plans to adapt to V3 of payload?

In progress already.


Direct adjoint out

fixes BlockOperator direct and adjoint methods with and without out parameter.

it says 48 files but it is only 3 BlockOperator, test_Operator and ScaledOperator, the rest is untracking the build directory.


[SPARK-41937][R] Fix error in R (>= 4.2.0) for SparkR datetime column comparing with Sys.time()

What changes were proposed in this pull request?

Added the base R all function (or any, as appropriate) while doing the check of whether class(.) is Column or not; e.g., if(all(class(.) == "Column")), or if(inherits(., "Column")) is proposed instead of the current approach if(class(.) == "Column").
Also added relevant SparkR test cases to verify no warning or error is resulted on the updated functions.
Only R scripts have been modified.

Why are the changes needed?
Base R 4.2.0 introduced a change ([Rd] R 4.2.0 is released), "Calling if() or while() with a condition of length greater than one gives an error rather than a warning."
The below code is a reproducible example of the issue. If it is executed in R >=4.2.0 then it will generate an error, or else just a warning message. Sys.time() is a multi-class object in R, and throughout the Spark R repository 'if' statement is used as: if(class == "Column") - this causes error in the latest R version >= 4.2.0. Note that R allows an object to have multiple 'class' names as a character vector (R: Object Classes); hence this type of check itself was not a good idea in the first place.
{
SparkR::sparkR.session()
t <- Sys.time()
sdf <- SparkR::createDataFrame(data.frame(x = t + c(-1, 1, -1, 1, -1)))
SparkR::collect(SparkR::filter(sdf, SparkR::column('x') > t))
}
#> Warning in if (class(e2) == 'Column') {: the condition has length > 1
#> and only the first element will be used
#> x
#> 1 2023-01-07 20:40:20
#> 2 2023-01-07 20:40:20
{
Sys.setenv(_R_CHECK_LENGTH_1_CONDITION_ = "true")
SparkR::sparkR.session()
t <- Sys.time()
sdf <- SparkR::createDataFrame(data.frame(x = t + c(-1, 1, -1, 1, -1)))
SparkR::collect(SparkR::filter(sdf, SparkR::column('x') > t))
}
#> Error in h(simpleError(msg, call)): error in evaluating the argument 'x'
#> in selecting a method for function 'collect': error in evaluating the
#> argument 'condition' in selecting a method for function 'filter': the
#> condition has length > 1

Does this PR introduce any user-facing change?
No.

How was this patch tested?
Added multiple relevant SparkR unit test cases to verify the fix; the Jira ticket number is added in the new test_that block.

Thanks for contribution @atalv . Mind taking a quick look at https://github.com/apache/spark/pull/39454/checks?check_run_id=10505372181 please?

@HyukjinKwon Somehow that "build on pull request " job did not trigger earlier. Now it is triggered as I made one push in my branch again from local to remote. Awaiting the completion of the actions.

Merged to master.


User should be able to process double click on the aggregated data cell

User should be able to process double click on the aggregated data cell
Added a call back in config object , for Ex.
DoubleClick: function(){console.log("In cell double click");}

Tem


Use Ingress to expose Harvester and support Certificates configuration

https://github.com/harvester/harvester/issues/761
https://github.com/harvester/harvester/issues/1475
Depend on PR https://github.com/harvester/harvester-installer/pull/173

Use a secret controller to ensure the VIP is added to TLS SAN.
Expose Harvester service using ingress. Set the default SSL certificate of ingress controller so that domain name is not required.
On certificate setting changes, update ingress controller configurations.

Not sure if it's caused by this PR, I can't get VIP working:
logs of kube-vip-cloud-provider-0
I1125 15:08:49.841110       1 event.go:291] "Event occurred" object="kube-system/ingress-expose" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
I1125 15:08:49.841145       1 event.go:291] "Event occurred" object="kube-system/ingress-expose" kind="Service" apiVersion="v1" type="Warning" reason="UnAvailableLoadBalancer" message="There are no available nodes for LoadBalancer"
I1125 15:08:49.848347       1 loadBalancer.go:149] syncing service 'ingress-expose' (e6219481-e694-41f7-9ec1-9b39c9109e66)
E1125 15:08:49.848365       1 loadBalancer.go:154] Unable to retrieve services from configMap [kubevip[], [unexpected end of JSON input[]
I1125 15:08:49.848374       1 loadBalancer.go:229] No cidr config for namespace [kube-system[] exists in key [cidr-kube-system[] configmap [kubevip[]
I1125 15:08:49.848381       1 loadBalancer.go:232] No global cidr config exists [cidr-global[]
I1125 15:08:49.848544       1 loadBalancer.go:251] No range config for namespace [kube-system[] exists in key [range-kube-system[] configmap [kubevip[]
I1125 15:08:49.848556       1 loadBalancer.go:254] No global range config exists [range-global[]
E1125 15:08:49.850198       1 controller.go:275] error processing service kube-system/ingress-expose (will retry): failed to ensure load balancer: No IP address ranges could be found either range-global or range-<namespace>
I1125 15:08:49.850335       1 event.go:291] "Event occurred" object="kube-system/ingress-expose" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: No IP address ranges could be found either range-global or range-<namespace>"
I1125 15:13:49.851708       1 event.go:291] "Event occurred" object="kube-system/ingress-expose" kind="Service" apiVersion="v1" type="Normal" reason="EnsuringLoadBalancer" message="Ensuring load balancer"
I1125 15:13:49.851726       1 event.go:291] "Event occurred" object="kube-system/ingress-expose" kind="Service" apiVersion="v1" type="Warning" reason="UnAvailableLoadBalancer" message="There are no available nodes for LoadBalancer"
I1125 15:13:49.856200       1 loadBalancer.go:149] syncing service 'ingress-expose' (e6219481-e694-41f7-9ec1-9b39c9109e66)
E1125 15:13:49.856215       1 loadBalancer.go:154] Unable to retrieve services from configMap [kubevip[], [unexpected end of JSON input[]
I1125 15:13:49.856221       1 loadBalancer.go:229] No cidr config for namespace [kube-system[] exists in key [cidr-kube-system[] configmap [kubevip[]
I1125 15:13:49.856226       1 loadBalancer.go:232] No global cidr config exists [cidr-global[]
I1125 15:13:49.856231       1 loadBalancer.go:251] No range config for namespace [kube-system[] exists in key [range-kube-system[] configmap [kubevip[]
I1125 15:13:49.856235       1 loadBalancer.go:254] No global range config exists [range-global[]
E1125 15:13:49.856255       1 controller.go:275] error processing service kube-system/ingress-expose (will retry): failed to ensure load balancer: No IP address ranges could be found either range-global or range-<namespace>
I1125 15:13:49.856358       1 event.go:291] "Event occurred" object="kube-system/ingress-expose" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: No IP address ranges could be found either range-global or range-<namespace>

vip configmap
apiVersion: v1
data:
  enabled: "true"
  hwAddress: ""
  ip: <IP_ADDRESS>
  loadBalancerIP: ""
  mode: static
  serviceType: LoadBalancer
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: harvester
    meta.helm.sh/release-namespace: harvester-system
    objectset.rio.cattle.io/id: default-mcc-harvester-cattle-fleet-local-system
  creationTimestamp: "2021-11-25T13:46:50Z"
  labels:
    app.kubernetes.io/managed-by: Helm
    objectset.rio.cattle.io/hash: e852fa897f5eae59a44b4bfe186aad80b10b94b3
  name: vip
  namespace: harvester-system
  resourceVersion: "3327"
  uid: 32a088f6-a5de-457c-8f9b-765a88336243

@bk201 Fixed via https://github.com/gitlawr/harvester/commit/8d59716691cfe9dfd3619c6cdcf511cfb7ed2a65#diff-b8916dccf848e9983fc1caeded29a01d766b8e0191877b6b857808f7e43ab54fL8

Updated

The certificate settings on the ingress part work well. But I can't get rancher-system-agent work:
$ systemctl restart rancher-system-agent.service
$ journalctl -u rancher-system-agent.service
Nov 30 02:35:45 node4 systemd[1]: Started Rancher System Agent.
Nov 30 02:35:45 node4 rancher-system-agent[27469]: time="2021-11-30T02:35:45Z" level=info msg="Rancher System Agent version v0.1.1-rc4 (18e623a) is starting"
Nov 30 02:35:45 node4 rancher-system-agent[27469]: time="2021-11-30T02:35:45Z" level=info msg="Using directory /var/lib/rancher/agent/work for work"
Nov 30 02:35:45 node4 rancher-system-agent[27469]: time="2021-11-30T02:35:45Z" level=debug msg="Instantiated new image utility with imagesDir: /var/lib/rancher/agent/images, imageCredentia>
Nov 30 02:35:45 node4 rancher-system-agent[27469]: time="2021-11-30T02:35:45Z" level=info msg="Starting remote watch of plans"
Nov 30 02:35:45 node4 rancher-system-agent[27469]: panic: error while connecting to Kubernetes cluster: Get "https://<IP_ADDRESS>/version": x509: cannot validate certificate for <IP_ADDRESS>>
Nov 30 02:35:45 node4 rancher-system-agent[27469]: goroutine 19 [running]:
Nov 30 02:35:45 node4 rancher-system-agent[27469]: github.com/rancher/system-agent/pkg/k8splan.(*watcher).start(0xc00048c180, 0x1757da0, 0xc000420dc0)
Nov 30 02:35:45 node4 rancher-system-agent[27469]:         /go/src/github.com/rancher/system-agent/pkg/k8splan/watcher.go:96 +0xc74
Nov 30 02:35:45 node4 rancher-system-agent[27469]: created by github.com/rancher/system-agent/pkg/k8splan.Watch
Nov 30 02:35:45 node4 rancher-system-agent[27469]:         /go/src/github.com/rancher/system-agent/pkg/k8splan/watcher.go:57 +0xbe
Nov 30 02:35:45 node4 systemd[1]: rancher-system-agent.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Nov 30 02:35:45 node4 systemd[1]: rancher-system-agent.service: Failed with result 'exit-code'.

Maybe it's because the rancher-system-agent use the connection info file:
node4:/var/lib/rancher/agent # cat /var/lib/rancher/agent/rancher2_connection_info.json
{
  "kubeConfig": "apiVersion: v1\nclusters:\n- cluster:\n    certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUJwakNDQVUyZ0F3SUJBZ0lCQURBS0JnZ3Foa2pPUFFRREFqQTdNUnd3R2dZRFZRUUtFeE5rZVc1aGJXbGoKYkdsemRHVnVaWEl0YjNKbk1Sc3dHUVlEVlFRREV4SmtlVzVoYldsamJHbHpkR1Z1WlhJdFkyRXdIaGNOTWpFeApNVE13TURJeE56QXdXaGNOTXpFeE1USTRNREl4TnpBd1dqQTdNUnd3R2dZRFZRUUtFeE5rZVc1aGJXbGpiR2x6CmRHVnVaWEl0YjNKbk1Sc3dHUVlEVlFRREV4SmtlVzVoYldsamJHbHpkR1Z1WlhJdFkyRXdXVEFUQmdjcWhrak8KUFFJQkJnZ3Foa2pPUFFNQkJ3TkNBQVRrb2ZiRFowbStyRkluSDRQMEV1S2JHb0lMMjlhYldZRkFrWHlNNmd0dQpxWkpEczltNXdyYXBaN05iWVdNMVdpTWFIenlYVkxSc1l1MSt5SUt3Z3pLWW8wSXdRREFPQmdOVkhROEJBZjhFCkJBTUNBcVF3RHdZRFZSMFRBUUgvQkFVd0F3RUIvekFkQmdOVkhRNEVGZ1FVTTlnSEp1TTBta1ZQRExBcnoxYzUKaWpuZE5QVXdDZ1lJS29aSXpqMEVBd0lEUndBd1JBSWdBbGVJeHFYVC82QTJ5QXROS0RIUnNxbG16RFdGeEJaOApqV2luaUNYU0dXb0NJRHFuMXJTV1U3cGJWdnJnSkxjQUs0T1VCcEtHQmhHb0hVMlhkMUZHa1pvVQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==\n    server: https://<IP_ADDRESS>\n  name: agent\ncontexts:\n- context:\n    cluster: agent\n    user: agent\n  name: agent\ncurrent-context: agent\nkind: Config\npreferences: {}\nusers:\n- name: agent\n  user:\n    token: eyJhbGciOiJSUzI1NiIsImtpZCI6IkVOVHc4ZmM0amFsbHNYMDhPa1ltSTBSRGRXZ1ljN3l1cjNaUDlYR2l2QlEifQ.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJmbGVldC1sb2NhbCIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VjcmV0Lm5hbWUiOiJjdXN0b20tZGFmZTViZDNjYmQxLW1hY2hpbmUtcGxhbi10b2tlbi1namNxcSIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50Lm5hbWUiOiJjdXN0b20tZGFmZTViZDNjYmQxLW1hY2hpbmUtcGxhbiIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50LnVpZCI6IjRhMjc0OTEzLTg5ZjEtNGNmOC05MWUyLTM3ZWRkM2Q2ODYxZiIsInN1YiI6InN5c3RlbTpzZXJ2aWNlYWNjb3VudDpmbGVldC1sb2NhbDpjdXN0b20tZGFmZTViZDNjYmQxLW1hY2hpbmUtcGxhbiJ9.Mog_4ozxdiITPK9Tk7w0ERmuoMUs3-JMOt5JHrteH7QSYtYBUhdZ0SQmEG3TPhume5_njRRhEyOra6Vdecntk3wdZHhfGShBB0RvnoHEqLgbC1jMGswHDDscPdn6o6waX6Lu9P4SFq_uMibfxqqljh2xys3HCL6Idghmu3PbeWFeMD1ljZQ6dS8lD1bFHX2z9Pq41FRbtHiet7MB4MB-sqcDH-Pxwcx7610SbSPeY4ixOcbnA4W7DXgetIeEYcDEM4GBLRwT_vuHoWfxAqvjdYKqm7tMqtcF_QVZbJn5lAgNEv7mM0VPWt5XLBVdOxjShvqL5iZF6coihPLT--m7hw\n",
  "namespace": "fleet-local",
  "secretName": "custom-dafe5bd3cbd1-machine-plan"
}

@bk201 Fixed by the last commit.
Cause:
In system agent SUC job, it uses the internal url to prepare the connection info file .
https://github.com/rancher/rancher/blob/ec31e6456d4068899460bb83640b63c83eaa72c6/pkg/controllers/provisioningv2/rke2/managesystemagent/managesystemagent.go#L98-L100
When the agent get the connection kubeconfig, it always uses the internal CA because the access is from the internal url. But it uses server-url if the setting is set.
https://github.com/rancher/rancher/blob/ec31e6456d4068899460bb83640b63c83eaa72c6/pkg/provisioningv2/rke2/configserver/server.go#L114-L128
Solution:
Remove server-url initialization. system-agent connects the internal url when it is empty.
Context:
We set the server-url setting because it is used in generated kubeconfig: https://github.com/rancher/rancher/blob/release/v2.6/pkg/api/norman/customization/cluster/actions_kubeconfig.go#L54
If server-url is not set and users access harvester using one-harvester-node:, the request url will be used as the server of kubeconfig which is not included in certificate SANs.
I think this is an acceptable tradeoff given that

we moved the kubeconfig to support page.
we don't encourage accessing harvester using node IPs.
Users can edit the server url in kubeconfig to fix if they get a wrong one.

@gitlawr what happens after the user re-config the server-url back manually, will the new joined node be able to use the server-url properly? thanks

The latest UI has added ssl-certificates setting. You can take the latest UI to test whether the function is available.  @gitlawr

@guangbochen No, we would expect server-url to be empty

@guangbochen No, we would expect server-url to be empty

sound like a bug that should be fixed on the Rancher side, can we please help to file a bug of it? I think we can tolerate not using the server-url in the current stage, also need to make sure this setting config is not pop-up on the UI bootstrap stage.


Project Initialization using aspnet-core

This is the approach I selected initially as it is the easiest to start with. The technology stack includes using MVC 6 in ASP.NET Core, ef core, Model Validation and TagHelpers
This approach is based on Pluralsight course "aspdotnetcore-efcore-bootstrap-angular-web-app"

Links of interest
tagEditor
pixabay
10 Best Tools to Tag MP3s and Edit Metadata
TagSpaces  - https://github.com/tagspaces/tagspaces
How to set the hosting environment in ASP.NET Core
Authorization in ASP.NET Core : Simple, role, claims-based and custom


Exception happens and MQQT values not send if SOC is reported as 0%

DALY BMS don't have correct SOC information and often shows 0%, but the real capacity is 10-20%.
In this case, there is a division to zero in file bmslib/bms.py Line: 52
capacity = round(charge / soc * 100)

I just released 0.0.45, which doesn't compute capacity if soc is near 0


Added configurable noise to Lidar sensor

Description
Other sensors, such as the IMU and GPS, have configurable noise. This PR adds configurable noise to the Lidar sensor.
The noise is simulated by randomly perturbing each point along the vector of the laser ray. In effect, this simulates a Lidar with perfect angular positioning of each ray, but noisy distance measurements.
The scale of this noise is controlled by the new noise_stddev attribute. It defaults to 0, so the default behavior is identical to the old behavior.
Where has this been tested?

Platform(s): Ubuntu 18.04
Python version(s): 2.7, 3.6
Unreal Engine version(s): 4.24

Possible Drawbacks
This noise model might not be completely accurate to real life Lidar sensors, which presumably also have some noise in the angular position of each raycast. However, it is probably a good first step.

This change is

Hi @ItsTimmy
Really well integrated, thanks for that great work!
We were discussing with @DSantosO about the performance impact of too many randoms since we're just added some more rand operations to discard points, did you experienced some frame drop?
I'll test your code soon but so far looks good to me!

For my needs, I always run Carla in synchronous, fixed time-step mode (0.005s time-step), and because my laptop is fairly low-powered, it runs very slow (~1/15 real time). So I don't get dropped frames, and I haven't measured the actual performance impact of this. Sorry that I can't be more helpful here!

Great! Thanks for the update!
Can you rebase master that will fix an issue related to Travis?

I rebased, but Travis is still failing. Is there something I can do to fix this, or is this an unrelated issue?

@ItsTimmy
Don't worry, Travis is failing everywhere because some dependency we have to fix in Python3.
I'm currently testing your code to merge it.


🐛 BUG: miniflare internal error on incoming request - failed: expected maybeModuleInfo != nullptr; No such module ";

Which Cloudflare product(s) does this pertain to?
Miniflare
What version(s) of the tool(s) are you using?
<EMAIL_ADDRESS>What version of Node are you using?
20.2.0
What operating system are you using?
Mac
Describe the Bug

When upgrading to<EMAIL_ADDRESS>our API encounters an internal miniflare error (see error logs below) whenever it attempts to route a request
This works without issues up until (and including<EMAIL_ADDRESS>
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
workerd/util/symbolizer.c++:98: warning: Not symbolizing stack traces because $LLVM_SYMBOLIZER is not set. To symbolize stack traces, set $LLVM_SYMBOLIZER to the location of the llvm-symbolizer binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
workerd/jsg/util.c++:275: error: e = workerd/jsg/_virtual_includes/jsg/workerd/jsg/modules.h:533: failed: expected maybeModuleInfo != nullptr; No such module "; specifier = node-internal:internal_inspect; ".
stack: 10073916b 100953e27 10072eb63 10072eadf 10132f13f 10132d143 101364773 101424777 101353f87 10132aff7 1015f0307 1015f0c6f 1015f0e4f 101604b47 1016049a3 100921f8f 1009f4a6f 1009f5a0b 1009f577f 10229d837 1022a2323 1022a56b7 10229c68b 100450d2b 100454317 100454153 10045413b 1023059bf 102305d07 102304467 102304237; sentryErrorContext = jsgInternalError
workerd/jsg/util.c++:275: error: e = workerd/jsg/_virtual_includes/jsg/workerd/jsg/modules.h:533: failed: expected maybeModuleInfo != nullptr; No such module "; specifier = node-internal:internal_inspect; ".
stack: 10073916b 100953e27 10072eb63 10072eadf 10132f13f 10132d143 10132d143 10132e087 101364697 1014248f7 1013540bf 10132aff7 1015f0307 1015f0c6f 1015f0e4f 101604b47 1016049a3 100921f8f 1009f4a6f 1009f5a0b 1009f577f 10229d837 1022a2323 1022a56b7 10229c68b 100450d2b 100454317 100454153 10045413b 1023059bf 102305d07; sentryErrorContext = jsgInternalError
[mf:err] Error: internal error
    at Object.logError (/Users/bk/repos/walletconnect/explorer-api/src/utils/HelperUtil.ts:41:13)
    at Object.handleError (/Users/bk/repos/walletconnect/explorer-api/src/utils/HelperUtil.ts:56:18)
    at *** [redacted] (/Users/bk/repos/walletconnect/explorer-api/src/index.ts:122:23)
    at async jsonError (/Users/bk/repos/walletconnect/explorer-api/node_modules/wrangler/templates/middleware/middleware-miniflare3-json-error.ts:22:10)
[mf:inf] GET /v3/logo/lg/dce1ee99-403f-44a9-9f94-20de30616500 500 Internal Server Error (56ms)

@bkrem Thanks for submitting this bug, I think there's enough context for this to be triaged but if you could provide more information on how you're invoking dev/setup that might help us find the issue

Hi @jspspike, Hi @mrbbot,
Apologies if the context I provided here initially was somewhat lacking here, but I think @mrbbot is on the money.
This worker implementation is a bit older and still uses the addEventListener('fetch', (event) => {... syntax in index.ts syntax which I believe makes it a service worker? Whereas some of our newer workers that leverage https://hono.dev/ do not have any issues with<EMAIL_ADDRESS>
This should be fixed in the next Wrangler release, which will hopefully be going out soon. In the meantime, I recommend you pin to<EMAIL_ADDRESS>
Thank you, we will pin 3.14.0 for this specific worker as advised and await a patch 🙏


fixing error in generating random optimistic Unchoking

This place should generate an random candidate optimistic unchoking peer, but with original source code, it will generate same number every time.

This commit mainly focus on the error in generating random number.

Please build and test (run "go test" in the project directory) before offering a pull request. Your code doesn't compile.

Superceded by 111, closing.


Grouped expression with single expression sometimes is a block

Description
Currently the following snippet is parsed as a :__block__ by Code.string_to_quoted, but I'm not sure why
(!false)

I have asked a question to core to resolve what the behavior should be: https://github.com/elixir-lang/elixir/issues/13324

Closed by 6a37c61e884179d1cd1f9acc31aa11108b19e813


Make mobile repo public

This should likely have squashed history limited to current models

Do you want to:

Create a new mobile_open repo and deprecate mobile?
Replace master branch with squashed version and make mobile repo public?
Make mobile repo public as-is?

Do we need this for 1.1?

I thought we needed it immediately to enable other participants. Its not
tied to 1.1
On Fri, Sep 10, 2021 at 11:14 AM Relja Markovic @.***>
wrote:

Do we need this for 1.1?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mlcommons/mobile_app_open/issues/61#issuecomment-917110762,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGPDQ2VPJ6SFDLWCNTEY3TUBJDIPANCNFSM5DZWY4CQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Makes sense. Does this impact 1.1 in any way? E.g. if we create
mobile_open, and leave mobile as-is, that should be fine, right? I would
like to keep mobile intact for now for history reasons, and we can delete
it in a year if it's not needed, similar to mobile_app.
On Fri, Sep 10, 2021 at 9:31 PM Mark Charlebois @.***>
wrote:

I thought we needed it immediately to enable other participants. Its not
tied to 1.1
On Fri, Sep 10, 2021 at 11:14 AM Relja Markovic @.***>
wrote:

Do we need this for 1.1?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/mlcommons/mobile_app_open/issues/61#issuecomment-917110762
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAGPDQ2VPJ6SFDLWCNTEY3TUBJDIPANCNFSM5DZWY4CQ
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mlcommons/mobile_app_open/issues/61#issuecomment-917158447,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR3JFWAM7N5ULXDF5IZQT73UBJMI5ANCNFSM5DZWY4CQ
.

Doesn't impact 1.1. Agree with your plan

Created https://github.com/mlcommons/mobile_open


Switch to React

The title says it all but let me explain the issue: I have tried to help with the update from mircocomponent to nanocomponent and also tried to improve the existing test situation. And while choo is certainly not a bad framework, I have to say that it made getting into dat-desktop harder. Most of the issues that I have found stem from unclear state management and render triggers (example: the whole list of items gets re-rendered when only the network state changed).
With choo I have yet to find a good way on how to do good propagation of updates in child components in order for parent components to trigger an update  (example: if the hex-icon changes state that the whole row needs to be redrawn). The implementation in the nanocomponent feels hacky at best, both in the child and in the parent.
It is possible to work around such issues but seeing as the time working on dat is limited to me I would rather like to focus on improving the desktop than on trying to fix older issues. I have no-one in my local community that I can ask about choo but several people engaged into React development and this is probably true for a lot of other possible contributors. Thus I would like to ask if its okay to send a PR that switches from choo to react.
I am not sure this is needed but here is a short summary of reasons I feel would make it worth to switch:

Choo doesn't support composite elements, and that makes tracking of changes in subcomponents difficult. (see mentioned above)
React is more stable (through the sheer amount of users) and comes with UI debug tools.
The choo eventbus system is nice for business logic but problematic when used in wizards like the tutorial. (see https://github.com/dotloom/dat-desktop/commit/81769f0129e22e6f4a222807b4281b9eae3ee054#diff-44c825eae9fb38934a22b1f6a61b8b95)

From that project it looks like this is pretty close to done, is that right? It's just a matter of getting all the tests to pass?

@simonv3 - There are some issues with adding dats, some build settings are not yet added again. But other than that it should be mostly finished.

This is done!


Correctly discard only inactive streams.

Motivation:
Long-lived connections that have many inactive streams would cause
crashes. Crashes are, in my professional opinion, less than ideal
when they occur under expected usage cases.
Modifications:

Fixed an inverted boolean check that would discard only active
streams.
Added tests.

Result:
Fewer crashes, better software.

No need to apologise @MrMage, more code review is always valuable. I've addressed both your comments.

@weissi Want to re-review?

(I'm just a bystander, but) Bump: @weissi this PR fixes an issue discovered in https://github.com/grpc/grpc-swift/pull/281 - just adding a friendly bump for a re-review here :-)


Selecting an item within the App Drawer brings up an additional item

Selecting an item within the App Drawer brings up an additional item
to hide said application alongside the current "Uninstall" / "Info" options.

@User2564 I am tracking the times here, if thats okay: https://github.com/Osiris-Team/openlauncher/issues/1

@Osiris-Team, that is completely fine.
Noted for the future thanks.
Good news, this MR and https://github.com/User2564/openlauncher/pull/3 works as expected.


CAMEL-15310 S3 Component failing test

Failing test for https://issues.apache.org/jira/browse/CAMEL-15310.
Background :
When an endpoint is configured to use given credentials, for eg :
from("aws-s3://MyBucket?accessKey=RAW(XXX)&secretKey=RAW(XXX)")

And there is a client in the registry ( but for the purpose of it to be used on another endpoint ), the current behaviour is that the S3 component will use by default the registry client, instead of creating a new one from the parameters given on the endpoint.

Merged

Thanks


Multi-GPU training

Hi,
Thanks for releasing the code! I am working on retraining the model using pytorch lightning. It works perfectly when I use a single A100 GPU, but I always get NaN loss when using multiple GPUs. The strategy I am using is DDP and it works well for other methods. What could be the reason?

Hi! Please try to use bfloat16 or small learning rate.

I also found the same problem, when I set up multi-card running, it is always inefficient.

Adjusting the learning rate or using bfloat16 doesn't work for me.


Allow to define exclude patterns

Sometimes it is more convenient to also to specify an exclude pattern instead of a complicated exclude pattern. (See also discussion in #7)

Available in version 2.1.0 (2015-10-18)

Bug fix release 2.1.1 available as 2.1.0 was incomplete


Application crash

I'm using Carnac 2.1.142 to capture Visual Studio shortcuts (for screencasting). Sometimes it crash with exception:
System.Threading.AbandonedMutexException was unhandled
Message: An unhandled exception of type 'System.Threading.AbandonedMutexException' occurred in Squirrel.dll
Additional information: Leaked a Mutex!

I simply started debugging session after crash. I know that this is caused by third party library  but I want to to let you know first. Hopes this will help you.

Hey @GKotfis,
Sorry to hear you are having these issues, but thanks very much for letting us know! I'll take a look and see what I can find and hopefully get a fix out as soon as possible.
Thanks,
Henrik


generate one methodbind implementation per function type

Currently one "raw function call" function is generated for every single method, for example
pub unsafe fn LinkButton_get_text(obj_ptr: *mut sys::godot_object) -> GodotString

The body of that method call is pretty much the same for all Godot methods that take no arguments and return a string, except for the MethodBind object.
The C++ bindings already only generate those so-called "icalls" (internal call) for function types and have a MethodBind parameter instead. That reduces the amount of generated code.
Here this might cut down the compile times a little bit as less code is generated that needs to be checked.
So the example from the top would then look like this:
pub unsafe fn icall_void_ret_string(obj_ptr: *mut sys::godot_object, method: *mut sys::godot_method_bind) -> GodotString

This function could then be used by all getters of String type and all other Godot methods that take no argument and return a string.

Good idea! Implementation should be fairly straightforward too: we can just keep a HashMap of signatures to identifiers, and generate a new icall if there isn't one already.

@halzy If you intend to work on this, could you also try using syn and quote just for the new parts as detailed in #407? It'll help us put the possible performance impact into perspective.


Update the Vale-at-Red-Hat online web app with the latest rules

There have been significant updates and enhancements to reduce false positives in vale-at-red-hat rules recently.
This issue raises the need to update the Vale-at-Red-Hat online web app with the latest Red Hat rules.
The app is a valuable tool that Red Hat writers can use to run Vale and check source content for RH-style compliance, especially when initially onboarding to Vale.

@gaurav-nelson  - FYI.

Thank you; however, I’m running that app’s backend on my cloud and cannot share the credentials. Alternatively, I can implement CI to do this, but it isn’t sustainable.
I was also toying with the idea of having a desktop app, but I wonder if it is required because VScode integrates quite well with Vale.


Fix wallet state transition functions to properly account for script validation failures.

Issue Number
ADP-1039
Summary
This PR:

breaks up wallet state transition functions into smaller functions for easier testing.
adds function isOurTx, which returns True if and only if a transaction is relevant to the wallet.
adjusts the withdrawal sum computation within applyOurTxToUTxO to correctly account for script validation failure.
adds a property test for applyOurTxToUTxO that relates it to isOurTx and applyTxToUTxO.
fixes the termination logic of applyOurTxToUTxO so that it returns a result only when appropriate.

bors r+

bors r+


feat: add jina_search as new websearch provider

Pull Request Checklist
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[x] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[x] Testing: Have you written and run sufficient tests for validating the changes?
[x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description

Added Jina search functionality using the jina search api, providing a new option for web search capabilities. You can find more details about Jina AI here

Added

New Web Search Provider: I have added Jina Search as a new option for web search providers, giving you more choices for your search needs.

LGTM, Thanks!


python312Packages.homematicip: 1.1.3 -> 1.1.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.homematicip is: Module for the homematicIP REST API
meta.homepage for python312Packages.homematicip is: https://github.com/hahn-th/homematicip-rest-api
meta.changelog for python312Packages.homematicip is: https://github.com/hahn-th/homematicip-rest-api/releases/tag/1.1.5
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.5 with grep in /nix/store/58bbr5jjpnxp88aj38m7p84p4w6v9p00-python3.12-homematicip-1.1.5
found 1.1.5 in filename of file in /nix/store/58bbr5jjpnxp88aj38m7p84p4w6v9p00-python3.12-homematicip-1.1.5

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

home-assistant-component-tests.homematicip_cloud
python311Packages.homematicip
python312Packages.homematicip

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/58bbr5jjpnxp88aj38m7p84p4w6v9p00-python3.12-homematicip-1.1.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.homematicip https://github.com/r-ryantm/nixpkgs/archive/6587ed6ea8fa907bb16142ffa7d297026bef6b4a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6587ed6ea8fa907bb16142ffa7d297026bef6b4a#python312Packages.homematicip

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/58bbr5jjpnxp88aj38m7p84p4w6v9p00-python3.12-homematicip-1.1.5
ls -la /nix/store/58bbr5jjpnxp88aj38m7p84p4w6v9p00-python3.12-homematicip-1.1.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 5 packages built:

home-assistant-component-tests.homematicip_cloud
python311Packages.homematicip
python311Packages.homematicip.dist
python312Packages.homematicip
python312Packages.homematicip.dist

Maintainer pings
cc @fabaff for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Duplicate of #362729


Exception at lwip/core/tcp.c:1953

I am hunting down a problem in my application and finding that we crash in LWIP logic.  Here is the backtrace as reported by gdb:
Remote debugging using /dev/ttyUSB0
tcp_netif_ipv4_addr_changed (old_addr=0x3fff04c0, new_addr=0x3ffdfc20)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/tcp.c:1953
1953	      if (!IP_IS_V6_VAL(lpcb->local_ip)) {
(gdb) bt
#0  tcp_netif_ipv4_addr_changed (old_addr=0x3fff04c0, new_addr=0x3ffdfc20)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/tcp.c:1953
#1  0x400ea341 in netif_set_ipaddr (netif=0x3fff04bc, ipaddr=0x3ffdfc20)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/netif.c:452
#2  0x400ea382 in netif_set_addr (netif=0x3fff04bc, ipaddr=0x3ffdfc20, netmask=0x3ffc5a10,
    gw=0x3ffc5a14) at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/netif.c:330
#3  0x400ee3e1 in dhcp_bind (netif=0x3fff04bc)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/ipv4/dhcp.c:1140
#4  0x400eed18 in dhcp_timeout (netif=0x3fff04bc)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/ipv4/dhcp.c:521
#5  0x400eed65 in dhcp_fine_tmr ()
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/ipv4/dhcp.c:476
#6  0x400ea6c6 in dhcp_timer_fine (arg=0x0)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/timers.c:178
#7  0x400ea74c in sys_timeouts_mbox_fetch (mbox=0x3ffbd750 <mbox>, msg=0x3ffc5ad0)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/core/timers.c:575
#8  0x400ed12f in tcpip_thread (arg=<optimized out>)
    at /home/kolban/esp32/esptest/esp-idf/components/lwip/api/tcpip.c:101
(gdb)

I have nothing as yet further to add but am raising this issue in the hopes that if others search, it may show a pattern of issues/solutions.

Where is the register dump and exception message?  Have you tried enabling stack overflow check in menuconfig?

My Component Config > FreeRTOS > Check for stack overflow is set to default which is "check by stack pointer value".
Here is the register dump an exception message ... if you have any knowledge on how to interpret this stuff I'd be very grateful to learn from you ...
Guru Meditation Error of type LoadProhibited occurred on core  0. Exception was unhandled.

The issue appears to be currently very recreatable.

Can you provide steps to reproduce? If you're unable to publish code publically, would you be able to email me directly? Thanks.

The code for reproduction is embedded with a HUGE amount of code now ... however I "solved" the cause of the puzzle ... in that I found out what I was doing wrong ... but it doesn't really sit well with me the result.
At a high level, I have a primary FreeRTOS task that does 95% of the work.  This includes setting up the ESP32 as a station to an access point.  However, for debugging purposes, I also have a second FreeRTOS task that sets itself up as a socket server.  By that I mean pseudo code like the following:
socket()
bind()
listen()
while(1) {
   accept()
   do something
   close client ...
}

What I had accidentally done was started that task BEFORE setting up the WiFi connection.  Apparently attempting to do those sockets APIs with no WiFi connection didn't cause any logging at those APIs and they apparently "ran" and did "something".   However, while that task was running in the background, the primary task which initializes WiFi then ran and attempted to create my WiFi connection.   When the remote DHCP server returned an IP address for my ESP32 to use ... it appears to be at THAT point that the exceptions described previously occur.
So the core of this puzzle is "What (if anything) does it mean to try and use sockets APIs to form a listener before forming a WiFi connection?   Should those APIs fail? (they apparently didn't)  Do we consider this a "garbage in/garbage out"?  Do we have to "bullet proof" getting into the state of trying to use sockets before we have WiFi?   I honestly don't know ... but as we see ... the failures were introduced by mistakes in my logic ... but the mistakes were not coding errors (i.e. all the bits I did were correct ... just in the wrong order/timing).
 I'd probably say "We have bigger fish to fry" ... and you won't find any objection from me.  I'll leave it for you to decide whether we pursue this or not any further.  But at least now we have a trail to examine ... if we see this exception pattern again in the future, we can ask "Are there any existing socket listeners currently running while WiFi is changing?".

Closed for just now ...


Ball "rolls" when hitting the corner of the paddle in the wrong way

Steps to replicate: play the game. Due to its random nature and how little control the player has it is difficult to replicate on purpose.
If the ball hits the corner of the paddle, it will sometimes stick to the paddle and move with it instead of bouncing. So far, I have only observed this behavior occurring in a rightward direction. This is likely a small edge case in the collision logic that it is unsure of how to treat.

I found that behavior to be true too. Since I ran out of time I declared it a feature


DDCE-5826 Scala 3 Upgrade

just a few small changes I think that can be done like updating the implicits to use given or using keywords. Think there is about 3 implicits that can change in the codebase.


Project does not have an installer

Description
WHAT:  Project does not have an installer which is not a good experience
WHERE: https://github.com/aerogear/mobile-core.git
WHEN: to install is required to clone the repo, then checkout a fixed tag then run a script.
IMPACT: It is not a good experience, and it does not pass confidence, and it means that the user needs to checkout tags when would like to get a new version, and it makes hard the usability, etc..
What is expected?

The project has an installer as for example brew cask install minishift or pip install ansible or brew install <project/app>
The installer be responsible to perform to all required steps.

In additional:

Be possible check the version as for example mobile-core --version
Be possible update the version as for example mobile-core update
Be possible check if the current version is the latest version published

Environment
Operating system: iOS
OpenShift versions:
Steps to reproduce
Follow up the documentation.

@evanshortiss create the following project as a POC/for his tests.

https://github.com/evanshortiss/mcup
https://github.com/evanshortiss/mcup/blob/master/src/mobile-core.ts#L138

Usually, all our client tools are made in NodeJS which could make the things really easier here to solve this issue. For example  npm install mobile-core and run mobile install and done. Also, if we used yargs as in other projects you could have easer have a help and many other facilities.

Started this topic about this issue: https://groups.google.com/forum/#!topic/aerogear/BdQb3p0wDH0

Hi @camilamacedo86,
Thanks for your feedback. This repo is now deprecated and is replaced by Mobile Developer Console. Could you please give it a try and if you still experience the same problem, please open a new issue in that project.
Thanks.


Enhance paste event

Paste event is not really implemented...

Yes, thats sucks, switching to another colorpicker)


mariadb has gcc in runtime closure

Hello everyone! This is maybe a bug, but more of a plea for help from someone with knowledge of GCC libs and the pam_* stuff.
Describe the bug
GCC is present in the runtime closure of mariadb, which makes it >200MiB larger.
Additional context
Files containing GCC's hash:

${mariadb}/share/pam/lib/security/pam_mariadb_mtr.so
${mariadb}/share/pam/lib/security/pam_user_map.so

Those files, in turn, refer to the paths:

${gcc}/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/crtbeginS.o
${gcc}/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/crtendS.o

I don't know what these object files or the pam libs are, so I'm asking here for help with identifying and removing them.
One reason why it would be nice to remove GCC from the closure is for building container images. Currently an image built with dockerTools.buildImage containing only mariadb has ~850MB which is twice the size of docker.io/library/mariadb.
Notify maintainers
@thoughtpolice
Metadata

system: "x86_64-linux"
host os: Linux 5.10.45, NixOS, 21.05.1268.21b696caf39 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.12
channels(kpg): ""
channels(root): "nixos-21.05.1268.21b696caf39"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: mariadb
# a list of nixos modules affected by the problem
module:

For what it worth, it is still true. It actually also depends on less(1), which also looks out-of-place.

only a gcc.lib dependency remains which is ok
/nix/store/dg8rnzij70blnn9cqxdvan1wwmqg167b-mariadb-server-10.6.12            	206.8M	453.6M
the less dependency is intentional and added in wrapProgram


How can we help?

Hi, there.
This project and shadcnui are amazing. It makes so easy for people to migrate from one ui lib to another and keep the customisability at the same time.
I see this project is still at initial stage, would be nice you can put out a list of work items so that the community and submit PRs accordingly. Something like https://github.com/fabian-hiller/valibot/issues/287

Sorry for the late response, but super busy at the moment.
This is a really good suggestion and I'll get round to it soon hopefully, as there is a few areas I am not sure I have the time to tackle on my own. Thanks!


Add make poetry-update, upgrade djlint

updates now supports poetry as well so we can use it for a new make poetry-update to update all poetry dependencies.

Now also includes an update to djlint generated via this new target.

we do have peotry now ?!?
it only is for python projects as far as i know

We use poetry to run python tools. Currently the templates linter. Likely yamllint as well in the future.


Cancel old ongoing workflows

These lines of code will basically cancel pre-existing workflows once you upload new changes, and will avoid running unnecessary workflows.
Use case:

You commit and push some changes
Workflow is triggered
You find out a minor typo/change while the workflow is still running
You commit and push the typo/change

In these circumstances, it is more than probable that you will have two workflows running on parallel, though you are not interested in the older one. This way, GitHub cancels the old workflow and just retains the new one.

This is very good to be implemented in other projects.

Fully agree. @RobPasMue, please open an issue in the dev-guide and write it down.

@RobPasMue this not affect code static analyzer. I don't think it is a big deal (I wouldn't bother to change that) but I just want to leave paper trace about that.
Otherwise good job!


Use only blocks

Can we make use of --no-symlink flag? We had introduced this for a reason similar to this.
I could be wrong, I am not certain on the padding issue that you are talking about.
On Oct 24, Pierre Peltier wrote:

Peltoche commented on this pull request.

@@ -184,8 +184,15 @@ pub fn build() -> App<'static, 'static> {
.multiple(true)
.number_of_values(1)
.require_delimiter(true)

           .possible_values(&["permission", "user", "group", "size", "date", "name"])

           .default_value("permission,user,group,size,date,name")

           .possible_values(&[

               "permission",

               "user",

               "group",

               "size",

               "date",

               "name",

               "name-with-symlink",

"name-with-symlink" ? For now it sadly is because the padding rules and the formatting change between a name and a name-with-symlink.  I will try to re-merge them but it require a generic way to give parameters to blocks.
I should be able to remove in a next commit inside this PR I hope
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/Peltoche/lsd/pull/289#discussion_r338434595

--
Regards:
Abin Simon (Developer)
meain.io -<EMAIL_ADDRESS>

Can we make use of --no-symlink flag? We had introduced this for a reason similar to this. I could be wrong, I am not certain on the padding issue that you are talking about.

I just have restored the no-symlink  flag like before and you can forget my previous response, I was on a false issue with an incorrect solution.

This PR is bigger than usual but I don't see how to reduce the size while keeping the program working. Yet there is still a lot of stuff to do but this PR is already fare too big but they will be done in some other PR.
@meain what do you think of this PR? Do you think it's ok to merge it?

I have not had time to take a look at the PR yet. I will take a look at it this weekend.
Since it is, at the end of the day a single refactor around how things get rendered(as far as I can tell) I think it would be better to merge it as one single PR.

@Peltoche The code looks good. But there seems to be mess when using -l with --tree. It seem to only respect -l
One more thing, Maybe we should reduce the spacing between the icon and the name of the file and increase the spacing before by one. Ideally two space before the icon and one after.
diff --git a/src/display.rs b/src/display.rs
index 5223306..401fcec 100644
--- a/src/display.rs
+++ b/src/display.rs
@@ -38,7 +38,7 @@ fn inner_display_grid(

     let padding_rules = get_padding_rules(&metas, flags);
     let mut grid = Grid::new(GridOptions {
-        filling: Filling::Spaces(1),
+        filling: Filling::Spaces(2),
         direction: if flags.layout == Layout::OneLine {
             Direction::LeftToRight
         } else {
diff --git a/src/icon.rs b/src/icon.rs
index 3d7b42f..f78a516 100644
--- a/src/icon.rs
+++ b/src/icon.rs
@@ -16,7 +16,7 @@ pub enum Theme {
     Unicode,
 }

-const ICON_SPACE: &str = "  ";
+const ICON_SPACE: &str = " ";

 // In order to add a new icon, write the unicode value like "\ue5fb" then
 // run the command below in vim:

before
after

@Peltoche The code looks good. But there seems to be mess when using -l with --tree. It seem to only respect -l

Fixed

One more thing, Maybe we should reduce the spacing between the icon and the name of the file and increase the spacing before by one. Ideally two space before the icon and one after.

The way --size short is displayed has changed. There is now an extra space between the value and the unit.

The way --size short is displayed has changed. There is now an extra space between the value and the unit.

All the spacing between blocks have changed from one space to two. This is due to the fix for your previous comment about the two spaces before the icons.
I revert the two spaces separator

The way --size short is displayed has changed. There is now an extra space between the value and the unit.

berfore
after

I am talking about the space between 3 and K when displaying size.
About the grid spacing, we should have two space for normal lsd and one space when running with -l flag. That is how everyone else seems to do it.

@Peltoche I think we should go with two spaces for grid when not having -l and for long format, we could change to 1 space. That seems to be what gnu ls does.
That is the only change I think we need for this and we could merge this in.

@Peltoche Sorry if I starting to sound like a broken record about the whole spacing stuff. What I was saying was that we could use two different sizes based on the layout.
Something like this:
let mut grid = match flags.layout {
    Layout::OneLine => Grid::new(GridOptions {
        filling: Filling::Spaces(1),
        direction: Direction::LeftToRight,
    }),
    _ => Grid::new(GridOptions {
        filling: Filling::Spaces(2),
        direction: Direction::TopToBottom,
    }),
};

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@76aa327). Click here to learn what that means.
The diff coverage is 33.71%.

@@           Coverage Diff            @@
##             master    #289   +/-   ##
========================================
  Coverage          ?   65.9%
========================================
  Files             ?      18
  Lines             ?    1704
  Branches          ?       0
========================================
  Hits              ?    1123
  Misses            ?     581
  Partials          ?       0

Impacted Files
Coverage Δ

src/icon.rs
96.37% <ø> (ø)

src/meta/indicator.rs
97.29% <ø> (ø)

src/app.rs
100% <ø> (ø)

src/core.rs
0% <0%> (ø)

src/meta/owner.rs
41.66% <0%> (ø)

src/meta/name.rs
95.65% <100%> (ø)

src/meta/date.rs
92.22% <100%> (ø)

src/display.rs
26.53% <5.47%> (ø)

src/meta/size.rs
66.98% <50%> (ø)

src/flags.rs
66.26% <59.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76aa327...c268735. Read the comment docs.


Remove JSON Schema from algorithms

Summary
Details and comments

The modified and newly added functions all have type hinting, both for input and output type. Is this a convention we want to use throughout Aqua (or algorithms?), or just for the initializers and functions used therein, i.e. such as self._validate_algo?

Hi @Cryoris,
Some months ago we all received an email form the Qiskit team asking us to start using type hints whenever possible. Since I am removing json schema which has type information. I decided to jump start and add type hints to all algorithms init methods. If there is no objections, I will do the same for all the other classes init that still have json schema on them. I do intend to start adding type hints to methods and classes I create in the future but it is not in my current the plan to go back to the whole Aqua and do it for every method there.

Thanks for the clarification, I was not aware of such an email. I'll start adding them too 👍but you're right about adapting all of Aqua that'd be a lot to do!


add the enableUserWorkloadMonitoring configmap

@JasonPowr @omveda
I suppose we really need a test for this but it's OpenShift specific so will be a follow-up

I need to modify this PR- since sometimes the monitoring cm already exists & since it's not managed by helm, helm complains

updated this to add instructions in enable-grafana-monitoring.md


[SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash

What changes were proposed in this pull request?
This PR proposes to port Scala's bugfix https://github.com/scala/scala/pull/7693 (Scala 2.13) to address https://github.com/scala/bug/issues/10495 issue.
In short, it is possible for different product instances having the same children to have the same hash. See:
scala> spark.range(1).selectExpr("id - 1").queryExecution.analyzed.semanticHash()
res0: Int = -565572825

scala> spark.range(1).selectExpr("id + 1").queryExecution.analyzed.semanticHash()
res1: Int = -565572825

Why are the changes needed?
It was found during the review of https://github.com/apache/spark/pull/27565. We should better produce different hash for different objects.
Does this PR introduce any user-facing change?
No, it's not identified. Possibly performance related issue.
How was this patch tested?
Manually tested, and unittest was added.

cc @JoshRosen, @cloud-fan, @mengxr, @WeichenXu123

Test build #118527 has started for PR 27601 at commit f5d4871.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23283/
Test PASSed.

It's good to avoid hash collision, but I don't think it's a correctness issue.

I corrected the description accordingly.

Test build #118531 has started for PR 27601 at commit eacf7f3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23286/
Test PASSed.

Test build #118527 has finished for PR 27601 at commit f5d4871.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #118531 has finished for PR 27601 at commit eacf7f3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118531/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118527/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23312/
Test PASSed.

Test build #118558 has started for PR 27601 at commit c94fa84.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23313/
Test PASSed.

Test build #118558 has finished for PR 27601 at commit c94fa84.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118558/
Test FAILed.

Test build #118580 has started for PR 27601 at commit c94fa84.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23334/
Test PASSed.

Test build #118580 has finished for PR 27601 at commit c94fa84.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118580/
Test PASSed.

thanks, merging to master/3.0

This issue is present in branch-2.4. It's a good to have but not critical, can we still backport it to branch-2.4?
cc: @cloud-fan @dongjoon-hyun

At that time, this was decided like the following. Given that, I guess we need some concrete reason like a performance number.

It's good to avoid hash collision, but I don't think it's a correctness issue.


Case sensitive

My observation is that the class name of the TagHelper is case sensitive. If you use the classname "EmailTagHelper", you have to use  tags.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19ecfbee-8b84-9ef2-65b6-8c2542f6370f
Version Independent ID: 9a0cbaa2-65c9-1618-1003-5fd2e7f6192f
Content: Author Tag Helpers in ASP.NET Core
Content Source: aspnetcore/mvc/views/tag-helpers/authoring.md
Service: unspecified
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Ikarus76  the Razor Markup is not case sensitive. Is there anything in particular in the document you feel is incorrect or incomplete?
You can test case-insensitivity by with the built in templates.

Hi,
I derived my class from SelectTagHelper. Implemented the c'tor and the Process method. Classname is 'myselectTagHelper'. In the view I can use the myselect-tag. When I use 'MySelectTagHelper' as class name, myselect in lower case doesn't work. Maybe it's because I derived from SelectTagHelper and not from TagHelper...

C# is case-sensitive, Razor tags are not.


Make sure to star the parse-server repo on GitHub!

why?

This message is announced your parse server is working now successfully.
That's it all.

How can i start it then ???


fix(grammar): adapt to upstream regex change

Upstream switched to Rust regex in recent tree-sitter, so regex patterns now need to escape the braces. This fixes :TSInstallFromGrammar.
Also remove conflicts reported as unnecessary by tree-sitter CLI.

(Tree-sitter supports the case-insensitive flag now, by the way, so you could probably simplify the grammar quite a bit.)

Alright, thank you for the fix!
The case-insensitive situation should be a simple change, but I can't get things to build with the correct version; I'm completely out of the loop as for TS.
If you see it make a drastic change for the better then I'll gladly accept it.

That's probably above my paygrade, but if one of the other tree-sitter folks (@amaanq @ObserverOfTime) have some time they could take a stab at it.
I'm surprised setting up the right tree-sitter version is so difficult (I just do brew update...); do you have specific tooling around that parser? Otherwise I'd recommend looking at the upstream tooling, especially https://github.com/tree-sitter-grammars/template and https://github.com/tree-sitter/workflows.


Typographical improvements

I've done two simple things to improve readability:

added SFMono-Regular to the default font stack
upped the font size slightly from 13px to 14px

This is related to my request in #1 .

This looks great! Thank you very much for your contribution 🙏🏻


ZH-trans: merge release-1.16-temporary to release-1.17

/cc @chenrui333 @markthink @zhangxiaoyu-zidif @idealhack @SataQiu

Should be good by just adding content/zh/examples/controllers/nginx-deployment.yaml
9:45:21 AM: Error: Error building site: "/opt/build/repo/content/zh/docs/concepts/workloads/controllers/deployment.md:22:1": failed to render shortcode "capture": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/codenew.html:14:16": execute of template failed: template: shortcodes/codenew.html:14:16: executing "shortcodes/codenew.html" at <readFile $filename>: error calling readFile: file "content/zh/examples/controllers/nginx-deployment.yaml" does not exist
9:45:21 AM: Function Dir: /opt/build/repo/functions
9:45:21 AM: Skipping functions preparation step: /opt/build/repo/functions not found

Should this change actually target the master branch? That's what most localizations seem to merge into when finishing a milestone.

Should this change actually target the master branch? That's what most localizations seem to merge into when finishing a milestone.

master #18217
release-1.16 #18216

/lgtm
/approve


"error"="updating SeccompProfile: updating SeccompProfile

What happened:
apiVersion: security-profiles-operator.x-k8s.io/v1alpha1
kind: SeccompProfile
metadata:
name: whitelist
namespace: default
spec:
defaultAction: SCMP_ACT_ERRNO
targetWorkload: custom-profiles
architectures:

SCMP_ARCH_X86_64
syscalls:
action: SCMP_ACT_LOG
names:

_llseek
_newselect
accept
long list here

kubectl create -f whitelist.yaml
kubectl get seccompprofile -o wide
NAME        STATUS   AGE   LOCALHOSTPROFILE
whitelist   Active   19m   operator/default/custom-profiles/whitelist.json
kubectl logs security-profiles-operator-2n7wx -n security-profiles-operator
E1213 16:36:52.535201       1 controller.go:246] controller "msg"="Reconciler error" "error"="updating SeccompProfile: updating SeccompProfile: Operation cannot be fulfilled on seccompprofiles.security-profiles-operator.x-k8s.io "whitelist": the object has been modified; please apply your changes to the latest version and try again" "controller"="pods" "name"="busyboxsecc" "namespace"="default" "reconcilerGroup"="" "reconcilerKind"="Pod"
Files is in correct place: ls  /var/lib/kubelet/seccomp/operator/default/custom-profiles/whitelist.json
/var/lib/kubelet/seccomp/operator/default/custom-profiles/whitelist.json
kubectl get pods
NAME          READY   STATUS   RESTARTS   AGE
busyboxsecc   0/1     Error    0          27s
What you expected to happen:
Profile being loaded and Pod being running
How to reproduce it (as minimally and precisely as possible):
Happened also after re-install of security-profiles-operator.
Anything else we need to know?:
Environment:

Cloud provider or hardware configuration: selfmade KVM K8s
OS (e.g: cat /etc/os-release): Debian 10
Kernel (e.g. uname -a): Linux master1 4.19.0-13-cloud-amd64 #1 SMP Debian 4.19.160-2 (2020-11-28) x86_64 GNU/Linux
Others: cri-o runtime, kube version 1.20.0

Can you check if the file is in the correct place for every node, especially the node where the pod is scheduled? That would indicate that the error message in the logs is unrelated since the profile was actually applied. I created a PR to help with those misleading logs: https://github.com/kubernetes-sigs/security-profiles-operator/pull/171
If the profile is deployed everywhere, then there is something wrong with the pod. Can you show your pod's YAML manifest, and the events in kubectl describe pod <pod>, and any logs from the pod itself? The pod might be referencing the wrong profile, or maybe one of the syscalls it is making is not in the whitelist, or maybe something else.

I did fresh operator install
I deployed below seccomp profile
cat audit.yaml
`---
apiVersion: security-profiles-operator.x-k8s.io/v1alpha1
kind: SeccompProfile
metadata:
name: audit
namespace: default
spec:
defaultAction: SCMP_ACT_LOG
targetWorkload: custom-profiles
architectures:

SCMP_ARCH_X86_64`

kubectl apply -f audit.yaml
seccompprofile.security-profiles-operator.x-k8s.io/audit created
kubectl get seccompprofile -o wide
NAME    STATUS   AGE    LOCALHOSTPROFILE
audit   Active   4m8s   operator/default/custom-profiles/audit.json
audit.json was in every node: /var/lib/kubelet/seccomp/operator/default/custom-profiles/audit.json
cat busybox-seccomp.yaml
`---
apiVersion: v1
kind: Pod
metadata:
name: busyboxsecc
creationTimestamp: null
labels:
app: busyboxsecc
spec:
securityContext:
seccompProfile:
type: Localhost
localhostProfile: operator/default/custom-profiles/audit.json
containers:

name: busybox
image: busybox
command:

sleep
"86400"
imagePullPolicy: IfNotPresent
restartPolicy: Never`

There was some errors still in operator logs:
kubectl logs security-profiles-operator-bv8ss -n security-profiles-operator
E1215 12:03:47.526818       1 profile.go:386] profile "msg"="could not update seccomp profile for pod" "error"="updating SeccompProfile status: exceeded 5 retries: Operation cannot be fulfilled on seccompprofiles.security-profiles-operator.x-k8s.io "audit": the object has been modified; please apply your changes to the latest version and try again" "namespace"="default" "pod"="busyboxsecc"
E1215 12:03:47.527057       1 controller.go:246] controller "msg"="Reconciler error" "error"="updating SeccompProfile pod references for new or updated pod: updating SeccompProfile status: exceeded 5 retries: Operation cannot be fulfilled on seccompprofiles.security-profiles-operator.x-k8s.io "audit": the object has been modified; please apply your changes to the latest version and try again" "controller"="pods" "name"="busyboxsecc" "namespace"="default" "reconcilerGroup"="" "reconcilerKind"="Pod"
kubectl describe pod busyboxsecc
Annotations:  seccomp.security.alpha.kubernetes.io/pod: localhost/operator/default/custom-profiles/audit.json
Now the last line in operator logs is:
I1215 12:17:36.503457       1 profile.go:323] profile "msg"="Reconciled profile from SeccompProfile" "namespace"="default" "profile"="audit" "name"="audit" "resource version"="59356"
Now I'm not sure what is status here, is my audit.json used or not or is it still using runtime/default? From the node logs I can see some syscalls but not all of them as I expected?

It seems that profile operator is doing its job as expected and my problems are related to something else, so this issue can be closed.


refactor(storybook): improve playground navigation

Closes #1048
Proposed Changes
Changed storybook documentation structure to allow for instant navigation to playground when component sidebar item is clicked. This better reflects expected behavior by the user.
https://github.com/inovex/elements/assets/48513535/d9c49062-d837-466c-8073-e4877190ff8a
https://github.com/inovex/elements/assets/48513535/dd7448a7-2036-4e87-9515-3682c74e546d

Waiting for #1063 to be merged, so all these formatting changes will be resolved

This change is pretty useful! Removes a lot of unnecessary clicks, but are we sure that we want to remove the navigation points /Structure, /Input, /Graphic, /Button and /Notification?
As our component library is quite extensive, I feel that removing the navigation points is a step backwards. Without the navigation points, you lose the overview of the functionalities of the individual components, as not everyone who visits the documentation for the first time immediately has a deeper understanding of the components.
The components feel disorganized now, partly following the alphabet (or not) or collected into coherent groups of components that work together (pattern like).
I find the grouping into pattern-like groups (e.g. /ino-list, /ino-table, /ino-nav, /ino-segment-group, /ino-tab-bar) a welcome change, as in our current structure this is only given within a large functional group (e.g. /Structure) and related elements are only arranged under each other (example: ino-list-divider, ino-list-item and ino-list).
Unfortunately, these new groups are lost in this representation. It would be better to either list the individual components collectively above the groups or to merge them back into functional groups. The pattern-like groups can also be listed under the function groups or have their own points in the navigation.

@MariaLStefan  that's true, it would be great to keep those sections. I think the true culprit lies in our extra documentation files which will be deleted in #1090 anyway. Our navigation should work as expected once they are gone. So let's keep this open until #1090 is done and check again if it doesn't work.

as expected, can be closed because we've removed all documentation files. Storybook now recognizes everything as stories and opens those on first click