Why is the disk usage much larger than the available space displayed by the df command after disabling ext4 journal?

Describe the bug
A clear and concise description of what the bug is.
Environment details

Image/version of Ceph CSI driver : cephcsi:v3.5.1
Helm chart version :
Kernel version :

🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel) uname -a
Linux k1 3.10.0-1127.el7.x86_64 #1 SMP Tue Mar 31 23:36:51 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
krbd or rbd-nbd) : krbd
Kubernetes cluster version :

🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel) kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.7", GitCommit:"b56e432f2191419647a6a13b9f5867801850f969", GitTreeState:"clean", BuildDate:"2022-02-16T11:50:27Z", GoVersion:"go1.16.14", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.7", GitCommit:"b56e432f2191419647a6a13b9f5867801850f969", GitTreeState:"clean", BuildDate:"2022-02-16T11:43:55Z", GoVersion:"go1.16.14", Compiler:"gc", Platform:"linux/amd64"}

Ceph cluster version :

🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)ceph --version
ceph version 15.2.16 (d46a73d6d0a67a79558054a3a5a72cb561724974) octopus (stable)

Steps to reproduce
Steps to reproduce the behavior:

Create a storageclass with storageclass
Then create pvc, and test pod like below

➜ /root ☞ cat csi-rbd/examples/pvc.yaml
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: rbd-pvc
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 50Gi
  storageClassName: csi-rbd-sc

🍺 /root ☞cat pod.yaml
apiVersion: v1
kind: Pod
metadata:
  name: csi-rbd-demo-pod
spec:
  containers:
    - name: web-server
      image: docker.io/library/nginx:latest
      volumeMounts:
        - name: mypvc
          mountPath: /var/lib/www/html
  volumes:
    - name: mypvc
      persistentVolumeClaim:
        claimName: rbd-pvc
        readOnly: false

The following steps are executed in ceph cluster

🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)rbd ls -p pool-51312494-44b2-43bc-8ba1-9c4f5eda3287
csi-vol-ad0bba2a-49fc-11ed-8ab9-3a534777138b

🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)rbd map pool-51312494-44b2-43bc-8ba1-9c4f5eda3287/csi-vol-ad0bba2a-49fc-11ed-8ab9-3a534777138b
/dev/rbd0
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)lsblk -f
NAME            FSTYPE      LABEL UUID                                   MOUNTPOINT
sr0
vda
├─vda1          xfs               a080444c-7927-49f7-b94f-e20f823bbc95   /boot
├─vda2          LVM2_member       jDjk4o-AaZU-He1S-8t56-4YEY-ujTp-ozFrK5
│ ├─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
│ └─centos-swap swap              d59f7992-9027-407a-84b3-ec69c3dadd4e
└─vda3          LVM2_member       Qn0c4t-Sf93-oIDr-e57o-XQ73-DsyG-pGI8X0
  └─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
vdb
vdc
rbd0            ext4              e381fa9f-9f94-43d1-8f3a-c2d90bc8de27
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)mount /dev/rbd0 /mnt/ext4
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)df -hT | egrep 'rbd|Type'
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/rbd0               ext4       49G   53M   49G   1% /mnt/ext4
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)umount /mnt/ext4
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)tune2fs -o journal_data_writeback /dev/rbd0
tune2fs 1.46.5 (30-Dec-2021)
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)tune2fs -O "^has_journal" /dev/rbd0
tune2fs 1.46.5 (30-Dec-2021)
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)e2fsck -f  /dev/rbd0
e2fsck 1.46.5 (30-Dec-2021)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
/dev/rbd0: 11/3276800 files (0.0% non-contiguous), 219022/13107200 blocks
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)mount /dev/rbd0 /mnt/ext4
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)df -hT | egrep 'rbd|Type'
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/rbd0               ext4       64Z   64Z   50G 100% /mnt/ext4
Actual results
the disk usage much larger than the available space displayed by the df command after disabling ext4 journal
🍺 /root/go/src/ceph/ceph-csi ☞ git:(devel)df -T | egrep 'rbd|Type'
Filesystem              Type                1K-blocks                 Used Available Use% Mounted on
/dev/rbd0               ext4<PHONE_NUMBER>7711028224<PHONE_NUMBER>7659475512  51536328 100% /mnt/ext4
Expected behavior
The df command could show disk usage normally.

@microyahoo looks like you are doing nothing with cephcsi driver apart from creating the image, it is good to ask this in ceph mailing list instead of cephcsi
cc @idryomov

OK, thanks.

This doesn't seem to have anything to do with RBD either.  I suspect you would see the same behavior on a loop device on that kernel.

I tried to create a loop device on the local node, it is normal. In addition, I found a very strange phenomenon, if I only create pvc, and then do the above operations, it is normal, but if I apply this pvc in a pod, the above problem will occur. @idryomov

Did you supply mkfs options that Ceph CSI hard-codes: -m0 -Enodiscard,lazy_itable_init=1,lazy_journal_init=1 when trying with a loop device?

if I only create pvc, and then do the above operations, it is normal, but if I apply this pvc in a pod, the above problem will occur. I suspect that the file system options setup by k8s or csi caused this problem

Did you mount the filesystem before doing these operations when trying with a loop device?  Applying the PVC does more than just mount of course, but that's the most obvious difference.  Note that Ceph CSI may be passing some mount options as well.

Did you supply mkfs options that Ceph CSI hard-codes: -m0 -Enodiscard,lazy_itable_init=1,lazy_journal_init=1 when trying with a loop device?

Yes, I followed your commands and it's normal like below.
[root@k1 ~]# truncate -s 50G backingfile
[root@k1 ~]# losetup -f --show backingfile
/dev/loop0
[root@k1 ~]# lsblk
NAME            MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sr0              11:0    1 1024M  0 rom
vda             252:0    0  100G  0 disk
├─vda1          252:1    0    1G  0 part /boot
├─vda2          252:2    0   59G  0 part
│ ├─centos-root 253:0    0   93G  0 lvm  /
│ └─centos-swap 253:1    0    6G  0 lvm
└─vda3          252:3    0   40G  0 part
  └─centos-root 253:0    0   93G  0 lvm  /
vdb             252:16   0   50G  0 disk
vdc             252:32   0   50G  0 disk
loop0             7:0    0   50G  0 loop

[root@k1 ~]# mkfs.ext4 -m0 -Enodiscard,lazy_itable_init=1,lazy_journal_init=1 /dev/loop0
mke2fs 1.46.5 (30-Dec-2021)
Creating filesystem with 13107200 4k blocks and 3276800 inodes
Filesystem UUID: 1a89454f-38c6-445a-a2b4-762ec64cbbd9
Superblock backups stored on blocks:
	32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208,
	4096000, 7962624, 11239424

Allocating group tables: done
Writing inode tables: done
Creating journal (65536 blocks): done
Writing superblocks and filesystem accounting information: done

[root@k1 ~]# mount -o rw,relatime,discard,stripe=1024,data=ordered,_netdev /dev/loop0 /mnt/ext4/
[root@k1 ~]# df -hT | egrep "Type|ext"
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/loop0              ext4       49G   24K   49G   1% /mnt/ext4

I created a rbd image throug k8s PVC, then map and mount it.
[root@k1 ~]# rbd ls -p pool-51312494-44b2-43bc-8ba1-9c4f5eda3287
csi-vol-da7f0cdc-4a3a-11ed-8ab9-3a534777138b
[root@k1 ~]# lsblk -f
NAME            FSTYPE      LABEL UUID                                   MOUNTPOINT
sr0
vda
├─vda1          xfs               a080444c-7927-49f7-b94f-e20f823bbc95   /boot
├─vda2          LVM2_member       jDjk4o-AaZU-He1S-8t56-4YEY-ujTp-ozFrK5
│ ├─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
│ └─centos-swap swap              d59f7992-9027-407a-84b3-ec69c3dadd4e
└─vda3          LVM2_member       Qn0c4t-Sf93-oIDr-e57o-XQ73-DsyG-pGI8X0
  └─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
vdb
vdc
[root@k1 ~]# rbd map pool-51312494-44b2-43bc-8ba1-9c4f5eda3287/csi-vol-da7f0cdc-4a3a-11ed-8ab9-3a534777138b
/dev/rbd0
[root@k1 ~]# mkfs.ext4 -m0 -Enodiscard,lazy_itable_init=1,lazy_journal_init=1 /dev/rbd0
mke2fs 1.46.5 (30-Dec-2021)
Creating filesystem with 13107200 4k blocks and 3276800 inodes
Filesystem UUID: 33ca621a-1da3-4997-9acc-f0f41d063e81
Superblock backups stored on blocks:
	32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208,
	4096000, 7962624, 11239424

Allocating group tables: done
Writing inode tables: done
Creating journal (65536 blocks): done
Writing superblocks and filesystem accounting information: done

[root@k1 ~]# lsblk -f
NAME            FSTYPE      LABEL UUID                                   MOUNTPOINT
sr0
vda
├─vda1          xfs               a080444c-7927-49f7-b94f-e20f823bbc95   /boot
├─vda2          LVM2_member       jDjk4o-AaZU-He1S-8t56-4YEY-ujTp-ozFrK5
│ ├─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
│ └─centos-swap swap              d59f7992-9027-407a-84b3-ec69c3dadd4e
└─vda3          LVM2_member       Qn0c4t-Sf93-oIDr-e57o-XQ73-DsyG-pGI8X0
  └─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
vdb
vdc
rbd0            ext4              33ca621a-1da3-4997-9acc-f0f41d063e81
[root@k1 ~]# mount -o rw,relatime,discard,stripe=1024,data=ordered,_netdev /dev/rbd0 /mnt/ext4/
[root@k1 ~]# df -hT | egrep "Type|ext"
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/rbd0               ext4       49G   24K   49G   1% /mnt/ext4
[root@k1 ~]# umount /mnt/ext4
[root@k1 ~]# tune2fs -o journal_data_writeback /dev/rbd
rbd/  rbd0
[root@k1 ~]# tune2fs -o journal_data_writeback /dev/rbd
rbd/  rbd0
[root@k1 ~]# tune2fs -o journal_data_writeback /dev/rbd0
tune2fs 1.46.5 (30-Dec-2021)
[root@k1 ~]# tune2fs -O "^has_journal" /dev/rbd0
tune2fs 1.46.5 (30-Dec-2021)
[root@k1 ~]# e2fsck -f  /dev/rbd0
e2fsck 1.46.5 (30-Dec-2021)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
/dev/rbd0: 11/3276800 files (0.0% non-contiguous), 219022/13107200 blocks
[root@k1 ~]# mount -o rw,relatime,discard,stripe=1024,data=ordered,_netdev /dev/rbd0 /mnt/ext4/
[root@k1 ~]# df -hT | egrep 'rbd|Type'
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/rbd0               ext4       50G   24K   50G   1% /mnt/ext4

OK, it sounds like the issue is caused by something else that happens as part of "applying the PVC", not the mount itself.  @Madhu-1 can you investigate?

@idryomov Thanks for checking i will look into it.

This problem can be stably reproduced when pvc is applied in pods.
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) rbd map pool-51312494-44b2-43bc-8ba1-9c4f5eda3287/csi-vol-8a32112e-4a3e-11ed-8ab9-3a534777138b
/dev/rbd0
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) lsblk -f
NAME            FSTYPE      LABEL UUID                                   MOUNTPOINT
sr0
vda
├─vda1          xfs               a080444c-7927-49f7-b94f-e20f823bbc95   /boot
├─vda2          LVM2_member       jDjk4o-AaZU-He1S-8t56-4YEY-ujTp-ozFrK5
│ ├─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
│ └─centos-swap swap              d59f7992-9027-407a-84b3-ec69c3dadd4e
└─vda3          LVM2_member       Qn0c4t-Sf93-oIDr-e57o-XQ73-DsyG-pGI8X0
  └─centos-root xfs               5e322b94-4141-4a15-ae29-4136ae9c2e15   /
vdb
vdc
rbd0            ext4              618f048e-a7f6-47fb-90e5-fb3afd9248a3
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) mount /dev/rbd0 /mnt/ext4
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) df -hT | egrep 'rbd|Type'
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/rbd0               ext4       49G   53M   49G   1% /mnt/ext4
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) umount /mnt/ext4
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) tune2fs -o journal_data_writeback /dev/rbd0
tune2fs 1.46.5 (30-Dec-2021)
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) tune2fs -O "^has_journal" /dev/rbd0
tune2fs 1.46.5 (30-Dec-2021)
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) e2fsck -f  /dev/rbd0
e2fsck 1.46.5 (30-Dec-2021)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
/dev/rbd0: 11/3276800 files (0.0% non-contiguous), 219022/13107200 blocks
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) df -hT | egrep 'rbd|Type'
Filesystem              Type      Size  Used Avail Use% Mounted on
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) mount /dev/rbd0 /mnt/ext4
🍺 /root/go/src/deeproute.ai/smd ☞ git:(pool) df -hT | egrep 'rbd|Type'
Filesystem              Type      Size  Used Avail Use% Mounted on
/dev/rbd0               ext4       64Z   64Z   50G 100% /mnt/ext4

Thanks for your advice and help @idryomov @Madhu-1

For 50Gb pvc
[🎩]mrajanna@fedora rbd $]kubectl execectl exec -it csirbd-demo-pod -- sh
# df -h
Filesystem      Size  Used Avail Use% Mounted on
overlay          28G  4.3G   22G  17% /
tmpfs            64M     0   64M   0% /dev
tmpfs           2.0G     0  2.0G   0% /sys/fs/cgroup
/dev/vda1        28G  4.3G   22G  17% /etc/hosts
shm              64M     0   64M   0% /dev/shm
/dev/rbd0        49G   53M   49G   1% /var/lib/www/html
tmpfs           3.9G   12K  3.9G   1% /run/secrets/kubernetes.io/serviceaccount
tmpfs           2.0G     0  2.0G   0% /proc/acpi
tmpfs           2.0G     0  2.0G   0% /proc/scsi
tmpfs           2.0G     0  2.0G   0% /sys/firmware
# exit
[🎩]mrajanna@fedora rbd $]kubectl get pvc
NAME      STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS      AGE
rbd-pvc   Bound    pvc-b75cdad1-01fc-40f5-9ed0-a7a8e0e89fe7   50Gi       RWO            rook-ceph-block   68s

Hi @Madhu-1 , you could disable ext4 journal option after creating pods.

create pvc and pod
delete pod, because e2fsck should make sure the disk is not used.
map the rbd image in ceph cluster
disable ext4 journal, then run e2fsck.
mount the block device in ceph cluster or recreate the pod again.
check the output of df.

@microyahoo why ext4 journal option need to be disabled?

Because  jdb2 process caused the high IO, I want to disable ext4 journal to optimize it.

Below is the test it did, i hope this is what you need to do to follow to disable journaling
[🎩]mrajanna@fedora rbd $]kubectl execectl exec -it csirbd-demo-pod -- sh
# df -h
Filesystem      Size  Used Avail Use% Mounted on
overlay          28G  4.3G   22G  17% /
tmpfs            64M     0   64M   0% /dev
tmpfs           2.0G     0  2.0G   0% /sys/fs/cgroup
/dev/vda1        28G  4.3G   22G  17% /etc/hosts
shm              64M     0   64M   0% /dev/shm
/dev/rbd0        49G   53M   49G   1% /var/lib/www/html
tmpfs           3.9G   12K  3.9G   1% /run/secrets/kubernetes.io/serviceaccount
tmpfs           2.0G     0  2.0G   0% /proc/acpi
tmpfs           2.0G     0  2.0G   0% /proc/scsi
tmpfs           2.0G     0  2.0G   0% /sys/firmware
# exit
[🎩]mrajanna@fedora rbd $]kubectl get pvc
NAME      STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS      AGE
rbd-pvc   Bound    pvc-b75cdad1-01fc-40f5-9ed0-a7a8e0e89fe7   50Gi       RWO            rook-ceph-block   68s
[🎩]mrajanna@fedora ceph-csi $]kubectl delete po csirbd-demo-pod
pod "csirbd-demo-pod" deleted

sh-4.4# rbd ls replicapool
csi-vol-ab596f94-4a44-11ed-8af4-d2297377c19c
sh-4.4# rbd map replicapool/csi-vol-ab596f94-4a44-11ed-8af4-d2297377c19c
/dev/rbd0
sh-4.4# tune2fs -O "^has_journal" /dev/rbd0
tune2fs 1.45.6 (20-Mar-2020)
sh-4.4# e2fsck -f  /dev/rbd0
e2fsck 1.45.6 (20-Mar-2020)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
/dev/rbd0: 11/3276800 files (0.0% non-contiguous), 219022/13107200 blocks
sh-4.4
sh-4.4# rbd unmap /dev/rbd0
sh-4.4# exit
exit
[🎩]mrajanna@fedora rook $]kubectl create -f deploy/examples/csi/rbd/pod.yaml
pod/csirbd-demo-pod created
[🎩]mrajanna@fedora rook $]kubectl get po
NAME              READY   STATUS    RESTARTS   AGE
csirbd-demo-pod   1/1     Running   0          5s
[🎩]mrajanna@fedora rook $]kubectl exec -it csirbd-demo-pod -- sh
# df -h
Filesystem      Size  Used Avail Use% Mounted on
overlay          28G  4.4G   22G  17% /
tmpfs            64M     0   64M   0% /dev
tmpfs           2.0G     0  2.0G   0% /sys/fs/cgroup
/dev/vda1        28G  4.4G   22G  17% /etc/hosts
shm              64M     0   64M   0% /dev/shm
/dev/rbd0        50G   53M   50G   1% /var/lib/www/html
tmpfs           3.9G   12K  3.9G   1% /run/secrets/kubernetes.io/serviceaccount
tmpfs           2.0G     0  2.0G   0% /proc/acpi
tmpfs           2.0G     0  2.0G   0% /proc/scsi
tmpfs           2.0G     0  2.0G   0% /sys/firmware
#
sh-4.4# dmesg | grep EXT4
[    4.682295] EXT4-fs (vda1): mounted filesystem with ordered data mode. Opts: (null)
[  449.667910] EXT4-fs (rbd0): mounted filesystem with ordered data mode. Opts: (null)
[  623.732915] EXT4-fs (rbd0): mounted filesystem with ordered data mode. Opts: (null)
[58541.333193] EXT4-fs (rbd0): mounted filesystem without journal. Opts: (null)

Isn't the journal used to write data to the ext4 filesystem? If you disabled the journal, would not an other process do the same I/O? Or maybe the workload is very filesystem metadata intense, in that case the app might benefit from some optimizations for storage...
If you really want to disable the journal, you could consider using ext2 as filesystem type instead. ext2 does not have journalling at all.
We might want to support a parameter in the StorageClass that contains options for mkfs, that would be an alternative path to disable journalling for certain volumes.

Thank you for your investigation. I have two environments that can be reproduced stably. I am not sure if it is related to the system. @Madhu-1
[root@node01 smd]# uname -a
Linux node01 3.10.0-1160.45.1.el7.x86_64 #1 SMP Wed Oct 13 17:20:51 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

🍺 /root ☞ uname -a
Linux k1 3.10.0-1127.el7.x86_64 #1 SMP Tue Mar 31 23:36:51 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Thanks for your advice, I will try it. @nixpanic


Issue warning when file to include from upstream is not found

Suppose we have the following bender vendor package configuration:
# Bender.yml

vendor_package:
  - name: musl
    target_dir: sw/math
    upstream: { git: https://github.com/kraj/musl.git, rev: 7a43f6fea9081bdd53d8a11cef9e9fab0348c53d } # v1.2.4
    include_from_upstream:
      - "arch/riscv32/bits/alltypes.h.in"

Since the file listed under include_from_upstream does not exist upstream, the bender vendor init command will not copy anything, but it still succeeds and explicitly logs:

Copying musl files from upstream

It would be great if it could issue a warning for files not found, e.g.:

arch/riscv32/bits/alltypes.h.in not found upstream

Fixed in #131 by https://github.com/pulp-platform/bender/pull/131/files#diff-ecd71321930028c655de9efd0eb4e3cd8816f7688daa11e3643cd24c057e395fR303-R319


Support for scrolling

How can I attach navigation bar to coordinator layout?

Hello. Thanks for issue. What exactly do you need in CoordinatorLayout?

Should work like FAB button.
Show hide bottom bar on scroll and should be compatible to handle  CoordinatorLayout features.

Ok. I am trying to handle this.

thanks

Hello. Check out sample how to achive your effect. Just wrap NTB into AppBarLayout and create what you want.


I hereby consent to the Individual CLA provided in assets/cla/individ…

…ual_cla.md
Change http client in fetchMetadataURL to use the client that uses proxy from environment

Hello there,
While trying to use the plugin I noticed that the fetchMetadataURL request was not respecting ProxyFromEnvironment I believe this fixes that issue as it is similar to how other request are being done.
Please let me know what you think @greenpau.
Cheers!

@nejipt , thank you for the PR! 👍 The change itself LGTM!
However, please review https://github.com/greenpau/go-authcrunch/blob/main/CONTRIBUTING.md and check you are in compliance.
I am working on Github Action to check PRs automatically. In the meantime, please use the checklist over her: https://github.com/greenpau/contributor-compliance-action#overview
A sample commit message:
oauth: browser client uses browser with proxy settings

Resolves: greenpau/caddy-security#111111

Signed-off-by: Foo Bar<EMAIL_ADDRESS>
The 111111 is the issue associated with this PR.

@nejipt , thank you for contributing 👍


Steps to reproduce:

Confirmed on arch linux fe3cd5175589c27c3564224b317bbc0177a5a735

The bug does not occur if the array of points is resized up then down before deletion..

This issue is also present when deleting the first element of of a collisionpolygon's array list, so this is an issue with that editor button not being initialized or something, not with CSGPolygon

The bug is caused by:

delete button is pressed on array list item
in editor_properties_array_dict.cpp the button is deleted on the pressed signal
after the pressed signal is emitted, the button_up signal is emitted, but this happens after the object has been freed
segfault


How to make ios like blur effect with Acrylic？

I want to create a  widget (like commandbar)  with blur of ios style. My code is like this:
  @override
  Widget build(BuildContext context) {
    return ConstrainedBox(
      constraints: const BoxConstraints(maxWidth: 250),
      child: Container(
        // Add the line below
        clipBehavior: Clip.antiAlias,
        decoration: BoxDecoration(
          borderRadius: BorderRadius.circular(15.0),
          // border: Border.all(color: Colors.green, width: 2.0)
        ),

        child: Acrylic(
          blurAmount: 20,
          // shape: RoundedRectangleBorder(),
          child: CommandBar(
            overflowBehavior: CommandBarOverflowBehavior.clip,
            isCompact: true,
            primaryItems: [
              ...simpleCommandBarItems,
              const CommandBarSeparator(),
              ...moreCommandBarItems,
            ],
          ),
        ),
      ),
    );

But the result of Acrylic turns out to be  more white at center, and more transparent at the edge---I need to make it evenly blurred.  Though I can make it totally transparent, but this is not the blur effect I want.
If Acrylic is not the right way, is there some other suggestion to make this effect?

You can take a look at the source code of the cupertino widgets library, more specifically to the CupertinoDialog
Acrylic is the implementation of Fluent Acrylic.


Use opportunistic zero-copy strategy in send

Use ffi.from_buffer more aggressively when the data type and CFFI version
support it.  Older versions of CFFI don't support commonly used types
like bytes but do work for some variants of memoryview.  Instead of
instance and version checking all the permutations this patch attempts the
fast path first and catches TypeError as a condition to degrade to the slow
path of ffi.new.
See: http://cffi.readthedocs.io/en/latest/ref.html#ffi-buffer-ffi-from-buffer
Fixes #34

Thank you for getting this done!


docs: add document on accessing gke clusters from local machines

As discussed in Mattermost today, this documents collects the steps I needed to take when setting up GKE cluster access from my local machine today.

@tarrow Updated this according to your feedback,


Swift Package Manager doesn't work

Xcode Version 11.2.1 (11B500). Trying to add File->Swift Packages-> Add...
Expected: package added
Actual: see screenshot

made it working in fork https://github.com/rinat-enikeev/LightRoute


Add API and dependency call times as graphs

What does this pull request do?
Adds these two graphs to our Grafana dashboard:
Longest API requests (99th percentile)
topk(10, quantile(0.99, 300*rate(http_server_requests_seconds_sum{namespace='$namespace'}[5m])) by (uri))

Dependency call times (99th percentile)
quantile(0.99, 300*rate(http_client_requests_seconds_sum{namespace='$namespace'}[5m])) by (clientName)

What is the intent behind these changes?
To surface

What API endpoints are slow
What dependency calls are slow

so that we can immediately tell

if external dependencies are contributing to issues we see
what endpoints are affected

Thanks! 🙇♂


Mistake in assertion statements in rc2lonlat

e.g. line 219
assert (lat >= -90.) & (lon <= 90.), f'latitude in {self.name} grid should be between -90 and 90'

"lon" should be "lat"
Also, I was initially confused when I got an error at the corners of the grid (row=0,col=0).  I my version, I
changed the code to return a np.nan in this case, but maybe Ok to leave as is and use try/except instead

You are right, CarlMears, I will fixed it as soo as possible.


Support for ActionController::Live

Rails 4 introduced ActionController::Live, and it would be perfect for gon.watch, since it uses another thread and does not overheads the main process.

@gazay If you have some time available for a related issue:   I presume gon is breaking the functionality for ActionController::Live, described here https://github.com/rails/rails/issues/31200#issuecomment-373538396
And I've put up a stripped down demo project for this issue alone: https://github.com/rcugut/xlsxtream_playground
Whenever the gon gem is present in Gemfile, things stop working. I'm still digging to find out why.  You can see the exact versions in the Gemfile.lock


Command: hide_panel

Reopening old Issue in relevant Repo
https://github.com/limetext/lime/issues/28

Ugh, old commit references limetext/lime/#54 not this one.


Project Day One Tasks

After Project approval work on the following
Data design: What kind of models will your project have - what sort of shape will they be?
What about the routes?
Visual design: What will the front end look like? How does that influence the number of routes that serve content and the routes the user might need to call?
A task list
Create the repo with a protected main branch
Deploy the most bare bones hello world page you can to Heroku

Done!


fix malformed markdown on README.md, fixes #16

Here is what the file will look like on Github after this change:
https://github.com/mikehenrty/TheDigitalStandard/blob/fix-readme/README.md

Disconnect, can you have a look?


Support for multiple bali gateways

Users may have multiple bali gateways and this plugin does not currently support this. Users can create multiple child bridges though.
Need to research how feasible it is to build multi-gateway support into this plugin. If its not going to be straightforward, then record a video guide on setting up multiple child bridges in HomeBridge.

Some tough testing shows that this is definitely possible and much easier than expected. It will require a configuration change and for users to recreate their homebridge-bali configuration. TBH, I'm not sure if there's a way to migrate configurations automatically or not.

Support added in https://github.com/bostrt/homebridge-bali-blinds/releases/tag/v1.0.0-beta.1


Not functioning?

Have enabled SNMPv1 & SNMPv3 on the APC & created user profiles to allow SNMP traffic. SNMP test passes on the APC to the Companion host.

I found I had to add the public as a readonly snmp account.


Flag optional arguments on methods that differ from their interface declarations

Consider the following case:
public class Foo : IFoo
{
    public void Bar(int value = 2) => Console.WriteLine(value);
}
public interface IFoo
{
    public void Bar(int value = 1);
}

public static void Main(string[] args)
{
    IFoo foo1 = new Foo();
    foo1.Bar();
    var foo2 = new Foo();
    foo2.Bar();
}

Output:
2
1

I would propose that the coding standard be
DO NOT: declare optional arguments on class methods that are implementing an interface.

Rational:

If these value are not in sync it will cause behavior as shown above.
It is possible to declare a constant and share it in both places. However, if you have an interface for accessing the class, why is there code bypassing it? If you want to invoke the method using the default value, simply go through the interface.

The line above should probably read
public void Bar(int value = 2) => Console.WriteLine(value);
This is an interesting problem. I can see why one would want to have it defaulted in the interface, but maybe that pushes it toward a base class.
... Now that I am thinking about it, what is the purpose of this? The argument must be implemented by the class. If one implements it as required, the default value on the interface is irrelevant. If implements it as optional then we get into the situation you are in above. This appears to be by design. Not sure I understand what the team was thinking on this one side from the odd behavior being intentional.
Maybe we should go with something like this...
BEWARE: When implementing a method whose interface has an optional argument, providing a different default value from what is specified in the interface will cause different behavior depending on how the calling object is cast.

Optional parameters are not part of a methods signature, therefore there is no requirement that a class' method may choose to implement every argument as optional, no arguments as optional, or some mix in the middle. the key here is that because optional arguments are implemented at the call site, the variable type of the caller is what determines what value the compiler inserts.

As per discussion we should add a coding guideline to the web site that says:
DO NOT: Declare interface methods with optional arguments.
Guidance: If this behavior is needed favor overloading or extension methods to achieve the same result.

#115 should be handled before this is added.

One #123 is complete, this guideline can be added to the created xml file


opcache fails to compile php7.4.30, linux/amd64

Building with
$ php --version
PHP 8.2.10 (cli) (built: Sep  4 2023 08:11:43) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.10, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.10, Copyright (c), by Zend Technologies

bin/spc build bcmath,openssl,tokenizer,sqlite3,pdo_sqlite,ftp,curl,phar,pdo,pdo_mysql,xml,gd,openssl,mbstring,apcu,fileinfo,session,filter,ctype,dom,simplexml,opcache --build-cli --build-fpm
eventually results in failure to compile:
[23:58:08] [INFO] [EXEC] make -j16 EXTRA_CFLAGS='-g -Os -fno-ident -Xcompiler -march=corei7 -Xcompiler -mtune=core-avx2' EXTRA_LIBS='/usr/local/src/static-php-cli/buildroot/lib/libonig.a /usr/local/src/static-php-cli/buildroot/lib/libpng16.a /usr/local/src/static-php-cli/buildroot/lib/libxml2.a /usr/local/src/static-php-cli/buildroot/lib/libiconv.a /usr/local/src/static-php-cli/buildroot/lib/libcharset.a /usr/local/src/static-php-cli/buildroot/lib/libcurl.a /usr/local/src/static-php-cli/buildroot/lib/libsqlite3.a /usr/local/src/static-php-cli/buildroot/lib/libssl.a /usr/local/src/static-php-cli/buildroot/lib/libcrypto.a /usr/local/src/static-php-cli/buildroot/lib/libz.a ' EXTRA_LDFLAGS_PROGRAM=' -all-static' fpm
[23:58:25] [INFO] Entering dir: /usr/local/src/static-php-cli/source/php-src/sapi/fpm
[23:58:25] [INFO] [EXEC] strip --strip-all php-fpm
[23:58:25] [INFO] Deploying fpm file
[23:58:25] [INFO] [EXEC] cp '/usr/local/src/static-php-cli/source/php-src/sapi/fpm/php-fpm' '/usr/local/src/static-php-cli/buildroot/bin/'
[23:58:25] [INFO] running cli sanity check
[23:58:25] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "echo \"hello\";"
[23:58:26] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('bcscale'));"
[23:58:26] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('curl_init'));"
[23:58:26] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('gzcompress'));"
[23:58:26] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('gd_info'));\$info = gd_info();assert(\$info['PNG Support'] ?? false);assert(\$info['GIF Create Support'] ?? false);assert(\$info['GIF Read Support'] ?? false);"
[23:58:26] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('filter_var'));"
[23:58:26] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(class_exists('\\DOMDocument'));\$doc = new DOMDocument();\$doc->loadHtml('<meta charset=\"UTF-8\"><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\">Hello');assert(\$doc->getElementById('app')->nodeValue === 'Hello');"
[23:58:26] [CRIT] Build failed with SPC\exception\RuntimeException: extension opcache failed compile check
[23:58:26] [CRIT] Please check with --debug option to see more details.

Thanks for this great initiative!

What is your compilation environment? If you have run the compilation command before, it is recommended to delete the source and buildroot commands before trying to compile using the build command.
I have no problem compiling locally on my Ubuntu.

I'll work on getting something you can demonstrate it with. The build is happening in a Dockerfile build, so is dependent on what's been installed there and the host's kernel. This particular one was linux/amd64 based on Debian Bullseye; I have a variety of other problems with linux/arm64. I know you can't debug until I get something easy to demonstrate for you.
I'm working on a DDEV add-on that will let people use a specific PHP patch version, https://github.com/rfay/ddev-php-patch-build; the actual build is in https://github.com/rfay/ddev-php-patch-build/blob/main/web-build/Dockerfile.php-patch-build (but opcache is removed because of the failure)

I have many different distro OS and arch to test. I'm open to see more information.. BTW, if something doesn't work well in a particular environment, it's a better idea to submit a separate Issue or include a list in the Issue to solve it one by one, regardless of whether the problem raised is valid.

This was definitely reproducible, but I'm not having trouble with a php 8.2.6 build. I'm pretty sure this one was a 7.4.x
With PHP 8.2.6 source and
bin/spc build bcmath,openssl,tokenizer,sqlite3,pdo_sqlite,ftp,curl,phar,pdo,pdo_mysql,xml,gd,openssl,mbstring,apcu,fileinfo,session,filter,ctype,dom,simplexml,opcache --build-cli --build-fpm
I get a successful build.
I'll try building 7.4.30 and 7.4.28 and see if they demonstrate the problem
I'm not sure why I don't seem to have reported the PHP version I was trying to build.

I can definitely recreate this with php 7.4.30 on linux/amd64.
bin/spc build bcmath,openssl,tokenizer,sqlite3,pdo_sqlite,ftp,curl,phar,pdo,pdo_mysql,xml,gd,openssl,mbstring,apcu,fileinfo,session,filter,ctype,dom,simplexml,opcache --build-cli --build-fpm
fails with
467.1 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "echo \"hello\";"
467.1 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('bcscale'));"
467.2 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('curl_init'));"
467.2 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('gzcompress'));"
467.2 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('gd_info'));\$info = gd_info();assert(\$info['PNG Support'] ?? false);assert(\$info['GIF Create Support'] ?? false);assert(\$info['GIF Read Support'] ?? false);"
467.3 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(function_exists('filter_var'));"
467.3 [23:03:06] [INFO] [EXEC] /usr/local/src/static-php-cli/buildroot/bin/php -r "assert(class_exists('\\DOMDocument'));\$doc = new DOMDocument();\$doc->loadHtml('<meta charset=\"UTF-8\"><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\">Hello');assert(\$doc->getElementById('app')->nodeValue === 'Hello');"
467.3 [23:03:06] [CRIT] Build failed with SPC\exception\RuntimeException: extension opcache failed compile check
467.3 [23:03:06] [CRIT] Please check with --debug option to see more details.

I'll try to get a simple docker image repro situation for you.

This may be a problem that cannot be easily solved at present. Because the current support for opcache is based on the patches of the phpmicro project, it currently does not provide support for older PHP versions such as 7.4.
See: https://github.com/dixyes/phpmicro/tree/master/patches

So working opcache versions like deb.sury.org only work with 7.4 because of patches applied?
I'm absolutely naive on this... but wasn't I using opcache in the 7.4 days?

Of course opcache can be used, but no matter what package management installs PHP, it generally dynamically links various extensions, including opcache. In the case of dynamic linking, all extensions are available. However, this project compiles PHP into a single file using static compilation, and many extensions cannot be compiled directly together.
At the same time, because opcache is special, it is a Zend extension and cannot generally be used in statically linked PHP. But through some patch codes, it can work in static-php. Currently, except for opcache, there are currently no other zend extensions that can be statically compiled into php, such as Xdebug, pcov, etc.
I don't know much about PHP's zend. Maybe I (or dixyes, the author of phpmicro) could find a way to patch the 7.4 version of opcache, but for now, we can't simply patch it.

Thanks, so opcache should work in general with php 8.x+, right?
I would do a PR to https://static-php-cli.zhamao.me/en/guide/extensions.html saying opcache is 8.x+ but it's not clear to me where that is. It looks like it's not in this repo.

It's probably pain, but you might consider doing what you do with unsupported extensions as well, and just fail the build saying they're unsupported on x.x.

It's probably pain, but you might consider doing what you do with unsupported extensions as well, and just fail the build saying they're unsupported on x.x.

I'm working on it, but currently I have limited time to do with various different error message. I will write the documentation.

Your work here is very much appreciated! I think some people will like that add-on when I get the tests going. Sometimes people just "have to have" a patch version.


Convert Hugo shortcodes

The Hugo shortcodes folder was originally removed during the initial Docusaurus set up and the corresponding shortcodes have not been converted for compatibility with Docusaurus.
E.g. {{< release-channel >}} on https://docs.ranchermanager.rancher.io/getting-started/installation-and-upgrade/install-upgrade-on-a-kubernetes-cluster/upgrades#for-upgrades-with-cert-manager-older-than-080

This is addressed by https://github.com/rancher/rancher-docs/pull/24


coreos-base/coreos-init: Make sshkeys.service more robust

This pulls in
https://github.com/flatcar/init/pull/112
to only run<EMAIL_ADDRESS>when not masked and also retry on failure.
How to use
Backport to Beta (via flatcar-3745-backport)
Testing done
See linked PR

[x] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Ok, did it in a separate commit for easier backporting


az image create will not work without location

To below command you have to add --location at the end. It will not work without it.
az image create
--resource-group myResourceGroup
--name myImage
--source myVM \
Without location you will see error:
(NotFound) Source Virtual Machine 'name-of-your-machine' specified in this request does not exist in this Azure location.
Please correct the script on this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5cfcc831-2add-15de-8278-024d30b6dbef
Version Independent ID: 94a05591-7cfb-4959-8d91-0ddbaea302ea
Content: Capture a managed image of a Linux VM using Azure CLI - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/capture-image.md
Service: virtual-machines
Sub-service: imaging
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for brining this to our attention. We will investigate it further and update you shortly.

@drazkiewicz - Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Runtime exit handler error

Sometimes runtime exit handler will report:
Error:2020/07/31 07:49:23 logger.go:49: failed to get truncate exit info, err: failed to truncate the exit info
Error:2020/07/31 07:49:23 logger.go:49: runtime failed to handle exit info fatal: dumping summary info: failed to truncate the exit info
Need to investigate why this happens

@Binyang2014 , could you explain the root cause here?

The root cause is:
When truncate log, we calculate the number of characters to be truncated based on current_exit_info_size_in_yaml_format - expect_exit_info_size . Then we truncate the log in each filed.
We don't recalculate the exit_info_size_in_yaml_format after truncate each field. But there is a gap between yaml-formatted-size and non-yaml-formatted-size .
Suppose we can truncate n  characters  in field A. After format the exitInfo into yaml, the reduced size will be large than n, especially when log file content is large.
So we recalculate the exitInfo size after truncate each filed. If we still failed to truncate the log, we will return a minimal exitInfo, which only contain exitCode , originalUserCode and matchedGpuInfo.


Path not found

Hi, I see errors with the script running without args, not sure what I'm doing wrong - error below. Thanks.
(last line encapsulated to avoid auto-format)
Get-ChildItem : Cannot find path 'C:\Users<USER-TRUNCATED>~1\AppData\Local\Temp\FWJSON13042022113004' because it does not exist.
At C:\users<USERNAME>\Downloads\Test-IntuneFirewallRules-main\Test-IntuneFirewallRules.ps1:1750 char:21
'+         $RuleJSON = Get-ChildItem $exportpath*.json'

The same problem here on fresh installed VMs with Windows 10. Any solution?


Can we please have GPU support?

Is your feature request related to a problem? Please describe.
Not a problem, but GPU utilization would make a good performance boost.
Describe the solution you'd like
OpenCV offers types like cv::GpuMat via the CUDA module, which bindings could be implemented to.
Describe alternatives you've considered
GPU is THE alternative to CPU image processing.
Additional context
The following graphic from here should say all you need to know.

Yes, it's in consideration. But it's just not easy and lots of works todo, and i have no much time, will work on in the future.

what needs to be implemented to make it work? maybe i can help in it when i get time too

@abdelaziz-mahdy basically something like https://github.com/hybridgroup/gocv/tree/release/cuda
and of course, a nvidia GPU is required to test it🤣

@abdelaziz-mahdy basically something like https://github.com/hybridgroup/gocv/tree/release/cuda
and of course, a nvidia GPU is required to test it🤣

Mission failed for me then 😂

me too. I am developing on a laptop without a NVIDIA GPU equipped, so not active on this.
If any one want to work on this, refer to https://github.com/hybridgroup/gocv/tree/release/cuda

@abdelaziz-mahdy basically something like https://github.com/hybridgroup/gocv/tree/release/cuda
and of course, a nvidia GPU is required to test it🤣
Why do you recall CUDA if mobile devices have their own GPUs, not related to CUDA?

Why do you recall CUDA if mobile devices have their own GPUs, not related to CUDA?

@abdelaziz-mahdy basically something like https://github.com/hybridgroup/gocv/tree/release/cuda
and of course, a nvidia GPU is required to test it🤣

I think he wants it for windows and Linux,
Mobile gpu support can be achieved using vulkan, but it's performance is still not that good I think and I don't know if matgpu supports it or not

Well, GPU backends such as OpenCL and Vulkan on mobile devices have been supported.

How to enable GPU processing in? Is GPU-processing implemented in opencv_dart API?

Well, GPU backends such as OpenCL and Vulkan on mobile devices have been supported.

How to enable GPU processing? Is GPU-processing support implemented in opencv_dart API?

Well, GPU backends such as OpenCL and Vulkan on mobile devices have been supported.

What processing? if you mean the methods like "cv::cuda::threshold", they are not supported by opencv on mobile devices.
GPU backends like OpenCL are used for dnn-related inferences, they are supported both in opencv_core and opencv_dart for now. If you want to enable them, please refer to the document of opencv.


System Prompt Does Not Utilize dspy.Signature Docstring (__doc__)

The dspy.Signature class docstring (doc) is not dynamically parsed or integrated into the system prompt.
 Your task is to solve the given issue or perform the actions to interact with the Kubernetes cluster.
    Use tools or kubectl commands to achieve the desired outcomes.

    Try to identify the following variables from the provided task or issue:
    - Cluster name
    - Resource type (e.g., Pod, Service, Deployment)
    - Resource name
    - Namespace
    """

    task: str = dspy.InputField(
        desc="The task or issue to address within the Kubernetes cluster."
    )
    answer: str = dspy.OutputField(
        desc="The final solution or output for the given task."
    )

Run the following code:

lm = dspy.LM(
    model="llama-3.1-70b-versatile",
    api_base="https://api.groq.com/openai/v1",
    api_key=os.getenv("GROQ_API_KEY"),
)
with dspy.context(lm=lm):
    react = dspy.ReAct(KubeEngineer, tools=[kube_executor_with_configs.kubectl_cmd])
    result = react(
        task="***"
    )
print(lm.history)

The system prompt in the output

{
  "prompt": None,
  "messages": [
    {
      "role": "system",
      "content": "Your input fields are:\n1. `task` (str): The task or issue to address within the Kubernetes cluster.\n2. `trajectory` (str)\n\nYour output fields are:\n1. `reasoning` (str)\n2. `answer` (str): The final solution or output for the given task.\n\nAll interactions will be structured in the following way, with the appropriate values filled in.\n\n[[ ## task ## ]]\n{task}\n\n[[ ## trajectory ## ]]\n{trajectory}\n\n[[ ## reasoning ## ]]\n{reasoning}\n\n[[ ## answer ## ]]\n{answer}\n\n[[ ## completed ## ]]\n\nIn adhering to this structure, your objective is: \n        Given the fields `task`, produce the fields `answer`."
    },
    {
      "role": "user",
      "content": "...."
    }
  ]
}

Current Behavior:
The system prompt does not include the docstring from the KubeEngineer class.
Expected Output:

{
  "prompt": None,
  "messages": [
    {
      "role": "system",
      "content": "You are a Kubernetes engineer. Your task is to solve the given issue or perform the actions to interact with the Kubernetes cluster. Use tools or kubectl commands to achieve the desired outcomes.\n\nTry to identify the following variables from the provided task or issue:\n- Cluster name\n- Resource type (e.g., Pod, Service, Deployment)\n- Resource name\n- Namespace ..."
    },
    {"role": "user", "content": "...."}
  ]
}

Hey @yanmxa ! Thank you so much for opening an issue & PR for this.
I think you're observing this in ReAct only, not in general. The issue can be addressed by editing predict/react.py

We need to pass instructions to this constructor:
https://github.com/stanfordnlp/dspy/blob/698d0acb0766ef2e84fc211d8912fea2b811d3c7/dspy/predict/react.py#L67

Thanks, @okhat! You got it! This issue occurs when using the ReAct module. Are there plans to address this? If so, I can draft a PR to resolve it.

Thank you, @yanmxa ! A PR would be welcome :D The change should be a one-liner but you may need to check that it does work.
For line 67, it should become:
dspy.Signature({**signature.input_fields, **signature.output_fields}, signature.instructions)

@okhat Thank you for the prompt response!


Option to sanitize mail content (pmt_content)

Feature request to sanitize mail content so will always comes through to a job as text/plain.
Something like.
#transform configuration
contentType=plain  (default=asSent)

Thinking about it, it could also be worth sanitizing pmt_replyTo as well, so you can use it direct in ext email plugin, ${pmt_replyTo} in recipients for example, so maybe either having a general sanitize flag in the mailbox plugin settings itself or have
#transform configuration
contentType=plain (default=asSent)
replyTo=plain (default=???)

Not quite sure what you want to achieve... do you want access to both the "text/plain" and "text/html" versions of the email? (and why?)
Regarding the pmt_replyTo - I've just added some code (can't find a reference atm) so that instead of "Nick Foobar<EMAIL_ADDRESS>it just uses<EMAIL_ADDRESS>Checkout 1.022.

No, not both, either one or the other, it's for cases where an email would contain other artefacts other than key value pairs so that some groovy script in a job could do extra bits, but coming through as html, there's a lot more that would need sanitising from the job side, it's a feature more than anything.
Great stuff regarding email.
From: Nick Grealy<EMAIL_ADDRESS>Sent: 05 April 2016 15:11
To: jenkinsci/poll-mailbox-trigger-plugin<EMAIL_ADDRESS>Cc: Paul Tankard<EMAIL_ADDRESS>Subject: Re: [jenkinsci/poll-mailbox-trigger-plugin] Option to sanitize mail content (pmt_content) (#10)
Not quite sure what you want to achieve... do you want access to both the "text/plain" and "text/html" versions of the email? (and why?)
Regarding the pmt_replyTo - I've just added some code (can't find a reference atm) so that instead of "Nick Foobar nickfoobar<EMAIL_ADDRESS>it just uses "nickfoobar<EMAIL_ADDRESS>Checkout 1.022.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/jenkinsci/poll-mailbox-trigger-plugin/issues/10#issuecomment-205827341
Paul Tankard
[Sumo-Logo]     [Tel] +44 (0)1142426766
[Web]www.sumo-digital.com
[Address]32 Jessops Riverside, 800 Brightside Lane, Sheffield, S9 2RX, United Kingdom
[------------------------------------------------------------------------------------------------------------------------------]
[Facebook]https://www.facebook.com/SumoDigital [Twitter] https://twitter.com/sumodigitalltd  [LinkedIn] https://www.linkedin.com/company/sumo-digital
The contents of this email are confidential and may not be copied, disclosed to other parties or used by anyone other than the intended recipient. If you received this email in error, please contact Sumo Digital Ltd by email<EMAIL_ADDRESS>or by calling +44 (0)114 2426766. Quote the name of the sender, your email address and then delete this email from your system.


update TLSCipherSuite

https://github.com/osixia/docker-openldap/blob/master/image/environment/default.startup.yaml#L34
According to https://testssl.sh/ you may want to update your TLSCipherSuite default Setting.
At the moment you don't allow TLS 1.3, have no Cipher server order, are potentially VULNERABLE to LUCKY13 and use
Obsoleted CBC ciphers (AES, ARIA etc.).
however Overall Grade is still A+
i would recommend:
TLSCipherSuite: SECURE256:SECURE192:SECURE128:-VERS-DTLS-ALL:-VERS-TLS-ALL:-SHA1:+VERS-TLS1.3:+VERS-TLS1.2:%SERVER_PRECEDENCE:%SAFE_RENEGOTIATION
Detailed breakdown:

key
discription

SECURE256:SECURE192:SECURE128
prefer more secure Ciphers over older Ciphers

-VERS-DTLS-ALL and -VERS-TLS-ALL
disable All TLS Protocols

-SHA1
disable SHA1 MACs

+VERS-TLS1.3 and +VERS-TLS1.2
(re)enable only TLS1.2 and TLS1.3

%SERVER_PRECEDENCE
force server cipher order

%SAFE_RENEGOTIATION
force Secure Renegotiation (RFC 5746)

i only tested this with on debian10 slapd 2.4.47 and gnutls 3.6.7 so you may want to test this setting first.

If you are coming here to figure out how to configure openldap to only use TLS1.3, note that the string given above is for gnutils and not openssl; openldap can be configured to use either. So that string will not work for openssl.  I am still searching for the "TLSv1.3 only" string for openssl...


Add a Nullable wrapper type to handle NULLs.

Solution to https://github.com/extendr/extendr/issues/138
Wrapper for handling potentially NULL values.
    let s1 = r!(1);
    let n1 = <Nullable<i32>>::from_robj(&s1)?;
    assert_eq!(n1, Nullable::NotNull(1));
    let snull = r!(NULL);
    let nnull = <Nullable<i32>>::from_robj(&snull)?;
    assert_eq!(nnull, Nullable::Null);

    assert_eq!(r!(Nullable::<i32>::Null), r!(NULL));
    assert_eq!(r!(Nullable::<i32>::NotNull(1)), r!(1));

To be clear how this interacts with NA, could you add an example where a nullable value is set to NA?
Would it be something like this?
let s1 = r!(NA);
let n1 = <Nullable<Option<i32>>>::from_robj(&s1)?;
assert_eq!(n1, Nullable::NotNull(None));

To be clear how this interacts with NA, could you add an example where a nullable value is set to NA?
Would it be something like this?
let s1 = r!(NA);
let n1 = <Nullable<Option<i32>>>::from_robj(&s1)?;
assert_eq!(n1, Nullable::NotNull(None));

I'll try to get an NA example in.as in r!(NA_INTEGER).
On Sun, Jan 31, 2021 at 9:10 PM Ilia<EMAIL_ADDRESS>wrote:

@Ilia-Kosenkov approved this pull request.
No objections from me, but I agree with @clauswilke
https://github.com/clauswilke that at least one test showing how it
works (and verifying conversions) should be added.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/163#pullrequestreview-579935140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAL36XGXRRAGKQFN2UMN6WDS4XBMNANCNFSM4W3V3HKQ
.


Fix invalid trait implementations

Fixes invalid trait implementations like
#[derive(Clone)]
pub struct Proof<H>(pub Vec<Branch<H::Hash>>)
where
    H: Hasher;

where Clone would only be implemented if the Hasher was Clone.  I had a think about a better way to accomplish this though and couldn't come up with anything. No way to tell derive to ignore the generic type.
You could probably remove the Hasher generic and implement the methods that require that through a trait, but that solution brings up a bunch of other problems. This will have to do :p

This crate seems to solve the problem. Do you think it's worth the dependency?


[Alert Manager] Irrelevant fields are shown as null in GET alert source

Issue/Feature Description:
Alert source can be configured with versions v2 and v3 and again for v3, based on security_model,
some fields are irrelevant. Currently, all such fields are shown as null. Instead they can be shown as ""
Some examples:

V3 configuration and community_string is irrelevant

V2 configuration and v3 fields are irrelevant

Why this issue to fixed / feature is needed(give scenarios or use cases):
Need to be fixed to improve readabilty
How to reproduce, in case of a bug:
Refer issue description
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

Having 'null' in response does not break functionality. keeping as low priority for June

null is ok to be in response.. customizing for all fields is not required.


Immutable constraints that treat null and missing values as different

Currently, when a property or element is declared as immutable, values that are either null or missing/undefined are treated as equal to each other. In other words, if a property's value was originally missing and then a new revision attempted to set the same property to null (or vice versa), it would be allowed when immutable is set to true for that property.
This is generally desirable as the default behaviour since many programming languages are incapable of distinguishing between null and missing values. Consider that, in such languages, if a JSON deserializer encounters a missing value, the corresponding property in the resulting object will be null. Furthermore, it is up to a JSON serializer to decide whether to omit a null value (i.e. in the resulting JSON, the property in question would be missing altogether rather than set to null) or to write it as null. In the face of this uncertainty, it is logical to, by default, favour a definition of immutability that treats null and missing values as equal, as is the case with the immutable and immutableWhenSet constraints.
However, some languages (e.g. JavaScript) are capable of distinguishing between null and missing values, so in an attempt to better support them, offer an immutability constraint that treats null and missing/undefined as different values.
For example (not to be considered final):
propertyValidators: {
  foobar: {
    type: 'object',
    immutableStrict: true
  },
  barbaz: {
    type: 'object',
    immutableWhenSetStrict: true
  }
}

Satisfied by #132


clarify Pebble JS execution context

Thank you! I'm barely a day old in this ecosystem and clearly misunderstood the context. (And this is great news, makes more things possible 👍


fix: bun dev dependency button uses incorrect flag

To install a package as devDependency in bun we need to use a -d instead of -D. Using -D does nothing and simply adds the package to regular dependencies.
It's kinda annoying to copy the command from nopy, then edit the -D out with -d to install as dev dependency for Bun.
As per it's CLI help message 👇

Thank you 😀

Ah! Thank you 🙏 I'll create a new release with this fix ASAP 😍


Remove extra param in Docs from metric Precision

In the docs there is beta param, which does not correspond to any param of Precision.

@Borda the metrics + docs are being overhaul in #4842 which also removes this error.
Should this instead target master for quick fix the docs right now?

@Borda the metrics + docs are being overhaul in #4842 which also removes this error.
Should this instead target master for quick fix the docs right now?

@SkafteNicki so you suggest closing this one just let it merge as a small bugfix...

@SkafteNicki so you suggest closing this one just let it merge as a small bugfix...

@Borda yes, change target to master and let it pass as a bugfix (I would say that we usually let pure doc fixes pass directly to master)

@Borda yes, change target to master and let it pass as a bugfix (I would say that we usually let pure doc fixes pass directly to master)

I guess duplicae https://github.com/PyTorchLightning/pytorch-lightning/pull/5532/?

I guess duplicae https://github.com/PyTorchLightning/pytorch-lightning/pull/5532/?


Create gentropy doc pages for the quality control flags

There is a growing number of quality flags indicating concerns about studies and study-loci. The interpretation of these quality flags not always trivial, and in general there should be a documentation on them. The scope of this ticket is to create new doc. page for gentropy (https://opentargets.github.io/gentropy) to list and explain these flags.
Tasks:

[ ] Review current set of quality control flags.
[ ] Amend description and docstring wherever it needed.
[ ] Create new pages in the documentation

Na, this is not an issue, the documentation is already there:


Update uap-core to latest

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          75     75
  Branches        6      6
=====================================
  Hits           75     75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fad79...4cf4474. Read the comment docs.


Effects by theme.

Hello.
The plugin you have made is very useful, thank you.
Now, I have one complaint about this plugin.
When I change the theme (color scheme) or set it to dark or light mode, it also affects the Marp preview.
If I output to PDF or other formats, it exports normally.
Is it possible to avoid the effect of the theme on the preview?

Hello. Thank you for the plugin also. I have a question complementary to this one: is it possible to export PDF just the way it looks in the preview (i.e. using the same theme/look as the one set of Obsidian) ?

As for applying the Obsidian theme to the output, I find it difficult.
This is because it is not the Obsidian theme that is referenced in the output, but the Marp theme!
I read somewhere an introductory article about this plugin.
I read somewhere that this plugin is referenced by the Marp commands, which means that the Marp theme is referenced.
Marp does not support the ability to reference Obsidian themes, so unless you find the same theme in Marp, it would be difficult.
Sorry for being an outsider.


proxy: record request Body for retry (fixes #1229)

Hey @tpng, thanks for the PR! Really glad you're helping out. :smile:
Did you see the fix for a similar issue in flynn? https://github.com/flynn/flynn/pull/875/files - they make "Close()" fake so that they only close it when they really mean to. What do you think of that approach instead of cloning? Seems to be a little simpler. (I haven't looked super thoroughly into the issue, but it seems like their problem was pretty much the same one.)

The reason for clone is that the request body maybe read by upstream already. In this case, fake close will end up with a dirty body for us to retry the request. It seems it is not possible for us to replay the downstream request without recording the body as it is read.

I think we don't need to clone it every retry, we can just record the downstream body once and reuse it.

@mholt PR updated.

@tw4452852 Thanks! PR updated.

I think we'd better add a test case in proxy_test.go for issue #1229.

Any idea on how to write the test case for #1229?

@tw4452852 Test added for #1229.

Sorry for late. LGTM.


Regression: TFLiteConverter changes output order again since 2.7

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Ubuntu 20.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
N/A
TensorFlow installed from (source or binary):
Binary
TensorFlow version (use command below):
2.7.1
Python version:
3.8.10
Bazel version (if compiling from source):
N/A
GCC/Compiler version (if compiling from source):
N/A
CUDA/cuDNN version:
11.2
GPU model and memory:
1080TI, 11G

Describe the current behavior
tf.lite.TFLiteConverter.from_keras_model changes output order.
Describe the expected behavior
Should keep the same order as the keras model.

Do you want to contribute a PR? (yes/no):
No

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
This is a regression bug. Please find an example here: https://github.com/tensorflow/tensorflow/issues/33303

Hi @chunduriv ! Could you please look at this issue ? It is replicating in  2.7 , 2.8 and nightly ( 2.9.0dev) .Thanks!

Hi @chao-camect
The issue is that TFLite converter uses saved model underneath, saved model doesn't guarantee order/names of tensors when loading the model, and that causes the issue.
Actually if you searched github you will even find other issues on older TF releases.
How to fix it ?
Because of this ordering / naming issue, TFLite now supports signature concept so you don't need to care about the tensors order or the tensor name.
Instead you deal with the defined signature on the model and the input / output names.
The mapping between the readable names and the actual tensors is done by TFLite and you don't need to care about them changing if the implementation underneath caused any order changes.
An example of using signatures
# Load the TFLite model in TFLite Interpreter
interpreter = tf.lite.Interpreter('/tmp/my_mode.tflite')

# If the model has only  1 signature defined
# then it will return it by default.
# If there are multiple signatures then we can pass the name as an argument.
my_signature = interpreter.get_signature_runner()

# my_signature is callable with input as arguments.
output = my_signature(x=tf.constant([1.0], shape=(1,10), dtype=tf.float32))
# 'output' is dictionary with all outputs from the inference.
# Assuming we named it in the original model as 'result' we can then pass it here.
print(output['result'])

See more details here and API for other models.
Please let us know if you are having any issues.


Remove https-overlay task since the files are not in 0.7.1 release

An FAQ page has a pointer to the http-overlay page it appears...

Good point, removed as well.

why not just add a pointer to whichever file is missing ?
also which file is missing/why ?


Add Confederation College

Main URL: https://www.confederationcollege.ca/
Proof of Program: https://www.confederationcollege.ca/program/computer-programming/courses
Proof of email: https://www.confederationcollege.ca/admissions/how-confirm-your-offer/college-email-instructions-admissions

@CaptainWhite95 Pull request merged. Thank you!


Help suggests order of arguments that halp does not accept.

Describe the bug
When run with --help or without a CMD the help suggests the syntax halp [OPTIONS] [CMD] <COMMAND>.
But running halp anycmd plz which follows that order errors with
error: the following required arguments were not provided:
  <CMD>

Usage: halp plz <CMD>

For more information, try '--help'.

To reproduce
halp anycmd plz

Expected behavior
Either the help should not list the arguments in the wrong order (I think that's the proper solution) or it should accept the suggested syntax.
Software information

Project version: halp 0.1.5

And likely irrelevant but here you go:

Operating system: Arch GNU/Linux x86_64 6.2.10-arch1-1
Rust version: rustc 1.69.0 (84c898d65 2023-04-16)

I think you're confusing [CMD] with  here.
[CMD] is the optional (hence the `[]') subcommand, which right now only accepts "plz".
<COMMAND> is the non-optional program name you want to get help for.
So your query halp anycmd plz is in halp <COMMAND> [CMD] order, which is incorrect.

In that case the other guidances is off/inconsistent because in the line above halp [OPTIONS] <CMD> is suggested and
Arguments:
   <CMD> Command or binary name

is the only explanation of CMD anywhere.

I couldn't find out where you got this output from
That's just the output of halp --help

I know, I worded that very wrongly haha. What I meant is I can't figure out where in the codebase this output is programmed. I assume it's being auto-generated somewhere seeing I can't find it with grep, but so far I haven't been able to figure it out.

I see the issue here. That help/usage text should be somehow "overridable" via clap options I think. Needs a bit of digging.

Updated the help text in f84930542b908ece5e1144b76da8975862902c53


ci(travis): allow Greenkeeper to run

Fixes #5

@raix I think it still requires some action by you - https://account.greenkeeper.io/account/raix


Fix CEF crashing inexor on win/wine64

When CEF is started on wine/64 it crashes because of a SEGFAULT in libcef.dll. Investigate and fix.
Please verify whether this also occurs on windows.

Are we talking about just starting inexor.exe? If yes, then I can't confirm that for Win7.

Can someone try to verify this error? Maybe it's caused by the same problem as in #226 and can therefore be closed?

No answer from @koraa in quite some time.
Not reproducable at any time and we don't support Wine.
Bottom line: Was never a bug.


Questions regarding the code for Metropolis-adjusted Langevin

Hi, thanks for the repo! I have three questions regarding the code for Metropolis-adjusted Langevin:

When a proposal is rejected, why is the gradient not reset (i.e., self.grad[1].data = self.grad[0].data)?
https://github.com/alisiahkoohi/Langevin-dynamics/blob/495de3a6004c07fef1f9b1c3922451f97854736d/langevin_sampling/samplers.py#L212-L214

When computing the density of the proposal distribution, why isP[1] used for both directions? Shouldn't it be P[idx^1]?
https://github.com/alisiahkoohi/Langevin-dynamics/blob/495de3a6004c07fef1f9b1c3922451f97854736d/langevin_sampling/samplers.py#L228-L233

Why are the rejected samples discarded? Shouldn't MH keep both accepted and rejected samples in the list?
https://github.com/alisiahkoohi/Langevin-dynamics/blob/495de3a6004c07fef1f9b1c3922451f97854736d/langevin_sampling/samplers.py#L198

grad[0] represents the gradient in the last accepted sample, and the gradient in the unaccepted sample is not required anymore.
What is meant by "direction"? P[1] (preconditioner) acts as the (squared) covariance of the additive noise distribution at the proposed sample and needed for computing the acceptance ratio.
The rejected samples themselves are not needed but the duplicates of the accepted samples per rejection might be saved. Feel free to submit a pull request with pointers to references in the comments.


Updated as requested.

Thanks Martin, this library is proving very useful to me.

I'm glad :). Thanks for the kind words :)


Why does func.cron() not duplicate jobs but rq.get_scheduler().cron() does?

I'm using Flask-RQ2 behind Gunicorn, which creates (let's say) 2 worker processes of the Flask app.
Each Flask app schedules a RQ cron job inside the create_app() factory. Because there are 2 worker processes, the same cron job is scheduled twice.
When I use:
@rq.job
def example_job():
    with open('./example_job_log.txt', 'a') as f:
        f.write(f'Example job ran at: {datetime.datetime.now()}\n')

example_job.cron('* * * * *', 'example_job')

Then the example_job.cron() line runs twice, but the job is NOT duplicated. example_job runs once a minute.
However, if I use:
def example_job():
    with open('./example_job_log.txt', 'a') as f:
        f.write(f'Example job ran at: {datetime.datetime.now()}\n')

scheduler = rq.get_scheduler()
scheduler.cron('* * * * *', func=example_job)

Then example_job is duplicated and runs twice a minute. Why is this the case?

For anyone else wondering about this, I believe the answer is that example_job.cron('* * * * *', 'example_job') actually calls rq.get_scheduler().cron(...) with an id parameter for the cron job.
rq-scheduler then deduplicates cron jobs with the same id. So the second example should work if you do:
def example_job():
    with open('./example_job_log.txt', 'a') as f:
        f.write(f'Example job ran at: {datetime.datetime.now()}\n')

scheduler = rq.get_scheduler()
scheduler.cron('* * * * *', func=example_job, id='example_job')

(Note: rq-scheduler and the rq queue handle this differently. You can enqueue as many jobs as you want with the same job id, and all of them will run.)


Swift/auth2

This change is

Reviewed 24 of 25 files at r1.
Review status: 20 of 21 files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Classes/NewCredentialHandler/Authentication/OauthToken2.swift, line 36 at r1 (raw file):

    func isExpired() -> Bool {
        //If the value on the left (now) is not less than the value on the left (expirationDate)

Value on left less than value on left...?

Comments from Reviewable

Review status: 20 of 21 files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Classes/NewCredentialHandler/Authentication/OauthToken2.swift, line 36 at r1 (raw file):
Previously, ecbrady (Erik Brady) wrote…
Value on left less than value on left...?

Done.

Comments from Reviewable

Reviewed 1 of 25 files at r1.
Review status: 20 of 21 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


feat: add bouncebit mainnet(v1.3.0)

Network Name: BounceBit Mainnet
RPC Url: https://fullnode-mainnet.bouncebitapi.com/
Chain ID: 6001
Currency Symbol: BB
Block explorer URL: https://mainnet.bbscan.io/

Thanks!
Also, I really appreciate including the RPC URL in the PR description - it made verifying the deployments easier for us :smile:.


server: add --enable-core-dump flag

This ensures Envoy can core dump when the dumpability bit might have
been unset (e.g.: running inside a container with fewer capabilities
than the ones Envoy itself has).
Fixes #15242.
Signed-off-by: Raul Gutierrez Segales<EMAIL_ADDRESS>

I've got --enable-core-dump running internally, works great 👌

/retest

@mattklein123 this is ready for another pass, I moved the platform specific bits into their own files and reduced the use of ifdefs to a minimum (used in one test). Thanks!

Ah, the bazel bits to split Linux from rest of Posix I am less sure about...

I actually had that but got rid of it to game the coverage failure 😂
I'll add info/warn back.
On Thu, Mar 4, 2021, 12:01 PM Matt Klein<EMAIL_ADDRESS>wrote:

@mattklein123 commented on this pull request.
In source/exe/main_common.cc
https://github.com/envoyproxy/envoy/pull/15245#discussion_r587648250:

// Process the option to disable extensions as early as possible,
// before we do any configuration loading.
OptionsImpl::disableExtensions(options.disabledExtensions());

// Enable core dumps as early as possible.
if (options_.coreDumpEnabled()) {
auto ret = platform_impl_.enableCoreDump();

Yeah fair enough. A soft failure is fine. Can we at least split the logic
and warn if it can't be enabled vs. info for enabled?
/wait
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/15245#discussion_r587648250,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKJSA6YUDEKD7AYBZVRATTTB64G3ANCNFSM4YM6KTDA
.

/retest

/retest


fix(create-robo): sometimes .gitignore isn't generated

Don't spend too much time on this if you can't replicate it.
Basically, there's a chance that the .gitignore file is not copied over when running create-robo and I have no idea why. I just ran into this when creating the robo-server project in the plugin-api benchmarks. However, attempting to do the same afterwards showed the .gitignore being generated correctly every time.
The options chosen were:

TypeScript
ESLint, Prettier, API Plugin
Skip

I've tried different combinations as well to no avail. I have a gut feeling that the TypeScript is affecting this somehow for some reason, probably because that decides which template directory is copied.
This is not the first time it has happened either, others in our Discord server have reported this happening to them in the past.

It may help to work on this alongside #163 as that will give you several combinations and find the cause.

expierenced  this too


Transformations should use the provided BitmapPool

In many cases Bitmaps can be obtained from or returned to the BitmapPool rather than being allocated or recycled.

Hi.
What would be the best thing to do?
thanks.

Usually when you call Bitmap.createBitmap(width, height, config) you can instead run:
Bitmap bitmap = bitmapPool.get(width, height, config);
if (bitmap == null) {
    bitmap = Bitmap.createBitmap(width, height, config);
}

And when you call bitmap.recycle(), you can instead run:
if (!bitmapPool.put(bitmap)) {
    bitmapPool.recycle()
}

Ideally you'd never call Bitmap.createBitmap unless you get a null result from the BitmapPool. You can find some more info on Glide's wiki. The BitmapPool docs may also be helpful.

Thank you for your advice.
I will a try it in the next version.  :+1:


Fix "metal.h" missing file error on iOS for TFlite 2.3.0+

Add explicit reference to iOS metal headers

See:
https://github.com/shaqian/flutter_tflite/issues/139
https://github.com/shaqian/flutter_tflite/issues/184
https://www.tensorflow.org/lite/performance/gpu#ios_with_xcode
https://github.com/am15h/tflite_flutter_plugin/issues/100
Seems like on TFLite 2.3.0+ metal.h is in a different package.


Error for optional variable "Path"

I am trying to install Viseron:latest.
As defined in documentation (camera configuration), path variable is optional. However, if I don't give it, then I get error.
voluptuous.error.MultipleInvalid: required key not provided @ data['cameras'][0]['path']
As I have already provided name, host (ip Address), port, stream format, username and password, I was expecting that rtsp link is constructed from this. rtsp://admin:password@ip_address:554//h264Preview_01_main
I have tried several ways to give path. But every time it failed with error 401 (authentication failure). I have confirmed that the link, login ID and password is correct by using it in VLC. This is resolved. But above issue regarding PATH is still valid. My proposal is to give some more examples in document. e.g. in rtsp path could should be /h264Preview_01_main
Can someone help me to know what is wrong and how to move forward. Many thanks.

Sorry you are having issues!
path is only optional if your stream is accessible directly from the IP adress of the camera.
What do you suggest for the documentation? Right now its specified pretty much the way you propose it unless i am missunderstanding you.
See snippet below from README

Name
Type
Default
Supported options
Description

path
str
optional
any string
Path to the camera stream, eg /Streaming/Channels/101/

Now when you mentioned it, I see it ! I agree.
Still considering Reolink cameras, link is rtsp://admin:password@ip_address:554//h264Preview_01_main. This can not be change. See Reolink documentation here.
So if someone want to use Reolink cameras, path should be //h264Preview_01_main, else it will not work and one will get error shown above. My proposal is to document this for the path.

This wont be feasible without having some sort of database with paths for different cameras, which i wont have the time to maintain, i will close this issue


feat: ability to override titles of specific pages

also

removing --unstable since it's no longer necessary
removing most of the safelist, due to PR 2266 in fresh
switching from as to satisfies in the fixture configs

there's some coverage debt missing here and in https://github.com/deer/fresh_blog/pull/31 that i'll fix later


BVH fix pairing AABB init and mask checks

Fix bug whereby AABBs were reused from previous items due to use of a pool, resulting in missed collisions.
Also use full mask collision checks for all cases except generic update.
All these bugs have not been in the BVH itself, but in the collision pairing, which is an extra layer on top of the BVH to meet the interface of 3.2. In 4.0, the pairing is currently done externally to the spatial partitioning. The pairing is quite error prone, as it relies both on masks and can be sensitive to the order of operations. The mask checks could be done everytime, but this would unnecessarily slow down collision detection, so in the long run it is worth working through these difficult bugs.
Notes

I now think the previous PR was only working in a test case by accident - the bug exhibits much like a race condition and is timing dependent.
The AABBs not being reset on reuse in the pool explains why forcing the pool to not reuse items cured the bug (however it resulted in a memory leak instead, so this proper fix was required).
The need for a full mask collision check was resulting rarely in some incorrect pairings when a cheaper no mask test was being used.
Full mask collision checks are more expensive, so it can be a good idea to avoid them when not strictly necessary. For that reason full mask collision checks are used in all flushes, except the regular frame update. This means the regular frame update should be cheap, as move objects will only be moving and not changing their masks on a frame to frame basis.
It is possible that the full mask check is not needed in some of the other situations, but I've always used it for safety at the moment, due to the bugs created being so difficult to solve.

Fixes #45461
(I hope! :grinning: )
May fix #45292
Fixes #45543

Thanks!

Thanks!


SSLCertVerificationError

Attempted to use your project to visualize some implied volatility surfaces today regardless of the ticker I the interpreter kept returning an SSLCertVerificationError.
"SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:1000)"
Running on windows, python 3.12.0.
edit: just tried with python 3.11 && same result. Looks like its coming from the site/api?

Thanks for your message. It looks like Yahoo has made some updates to their HTML in the last few months so some of the data scraping wasn't working anymore. I've just uploaded a new version (1.1.10) that should fix this. A virtual environment running Python version 3.10 as per the README instructions should work (you shouldn't use Python 3.12 though as it's not compatible with matplotlib version 3.5.3).

3.11 isn't compatible with mpl 3.5.3 either so that won't work. I've just tested the below to be working now:
$ py -3.10 -m venv .venv
$ .venv\scripts\activate
$ (.venv) python -m pip install --upgrade pip
$ (.venv) python -m pip install matplotlib==3.5.3
$ (.venv) python -m pip install spyder
$ (.venv) python -m pip install volvisualizer
(Within Spyder):
from volvisualizer.volatility import Volatility
imp = Volatility(ticker='^SPX', start_date='2024-05-06', wait=1, monthlies=True, q=0.0135)


Update Russian translation

I've translated all the missing messages into Russian and edited some of the old ones. Some further editing might be necessary to make the tone and terminology consistent.
Continuation of https://github.com/Syncplay/syncplay/pull/363.
Fixes https://github.com/Syncplay/syncplay/issues/361.
@Et0h

It's good to see something which addresses #361, and the other changes seem like a nice bonus. I'll need to find time to test it before it is merged, but I had a peek at the file changes and it looks good at first glance.


registries.yaml and imagePullSecret

Environmental Info:
K3s Version:

k3s version v1.27.3+k3s1 (fe9604ca)
go version go1.20.5
Node(s) CPU architecture, OS, and Version:

Linux agent-medium-nbg1-spj 6.4.2-1-default #1 SMP PREEMPT_DYNAMIC Mon Jul 10 10:03:25 UTC 2023 (b97b894) x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:

1 master, 2 nodes
Describe the bug:

Using a registries.yaml with mirror (for registry.gitlab.com) & credentials (for the mirror)

crictl pull on the node works.

BUT in kubernetes:

kubectl run --image=... works (without any imagePullSecret)
Creating a Deployment with same image, containing imagePullSecret for registry.gitlab.com gives an ImagePullError
Adding a imagePullSecret for the mirror also breaks.
imagePullSecret only containing the mirror-credentials works!

So it seems the mirror is only useable if there is no imagePullSecret defined for the Pod?
Steps To Reproduce:

setup a mirror/pull-through docker-registry that requires authentication
setup k3s with a registries.yaml:

mirrors:
  docker.io:
    endpoint:
      - "https://core.harbor.$TLD"
    rewrite:
      "^(.*)": "proxy.docker.io/$1"
  gcr.io:
    endpoint:
      - "https://core.harbor.$TLD"
    rewrite:
      "^(.*)": "proxy.gcr.io/$1"
  registry.k8s.io:
    endpoint:
      - "https://core.harbor.$TLD"
    rewrite:
      "^(.*)": "proxy.registry.k8s.io/$1"
  registry.gitlab.com:
    endpoint:
      - "https://core.harbor.$TLD"
    rewrite:
      "^(.*)": "proxy.registry.gitlab.com/$1"

configs:
  "core.harbor.$TLD":
    auth:
      username: "xyz"
      password: "xyz"

block registry.gitlab.com (e.g. with /etc/hosts containing <IP_ADDRESS> registry.gitlab.com)
create a deployment/pod with image + imagePullSecret for registry.gitlab.com.
see pod failing with ErrImagePull
add credentials for the mirror to the pod
see pod still failing to authenticate against the mirror

Expected behavior:

Kubernetes should be able to authenticate and pull from the mirror when an imagePullSecret is defined.
Actual behavior:

Kubernetes fails authenticating to the mirror. It seems to be always only using the original credentials if present and ignore imagePullSecret for the mirror.
Additional context / logs:

I can pull those images fine directly with docker login & pull,  or crictl pull on the node, but k3s fails to do so when there is an imagePullSecret attached. Sadly this makes the mirror kind of unusuable for private registries if i have to delete all imagePullSecrets from a pod.
And Yes it is possible to ONLY add the pullSecret for the mirror, but then the "upstream" server will be ignored completey, which defeats the purpose of a fallback-mirror.
66m         Normal    Pulling                  pod/workers-scheduler-9b766fd95-skkr7                                      Pulling image "registry.gitlab.com/xyz:tag"
66m         Warning   Failed                   pod/workers-scheduler-9b766fd95-skkr7                                      Failed to pull image "registry.gitlab.com/xyz:tag": rpc error: code = Unknown desc = failed to pull and unpack image "registry.gitlab.com/xyz:tag": failed to resolve reference "registry.gitlab.com/xyz:tag": unexpected status from HEAD request to https://core.harbor.$TLD/v2/proxy.registry.gitlab.com/xyz/manifests/$tag?ns=registry.gitlab.com: 401 Unauthorized

I would recommend opening an issue at https://github.com/containerd/containerd. The K3s's registries.yaml is just used to build a containerd configuration file, which you can find at /var/lib/rancher/k3s/agent/etc/containerd/config.toml. The actual pulling of images from configured endpoints, use of credentials, and so on is all handled by containerd.


Create NHRI

@xycalm7 lib/domains/cn/NHRI: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@xycalm7 First stage of verification passed, official domain is nhri.cn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@xycalm7 I am sorry, this domain seems to represent a research institution, not a specific single university or a college. Please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging. Please send us a message to<EMAIL_ADDRESS>if I misunderstood the domain ownership or the nature of this organization.
Thank you for your understanding!


Support Bluetooth Controllers (connected to headset)

It would appear that bluetooth controllers connected to the headset do not work, which is to say I've tried it and found that it does not work.
It would be great if support for this could be added, that way the Oculus GO can remain portable even when using it with ALVR.
Thanks!

I am facing the same problem, the oculus controller works great but when I link the xbox one s controller it does nothing.
I saw tutorials that you have to link the xbox controller to the PC, that does work but I tend to be in other rooms in my house with my oculus go then the controllers bluetooth doesn't reach the PC.

Same issue here, tested with a Nintendo Switch Pro controller. Thought it was an issue with the controller, since it kept making the lights flash the same way as when searching for a connection. Glad I saw this thread to save headache.


Made some changes as discussed to folder structure and CONTRIBUTIONS md

This looks good. Thanks for checking the formatting.


fix(otel/metrics): add otel. prefix to host and some kafka metrics in the Converged Agent

What does this PR do?
Updates opentelemetry-mappings-go metrics configurations to include the WithOTelPrefix option. This option will append otel. prefix to all system.*, proccess.*, and a subet of kafka.* metrics received via OTLP.
Motivation
This change will resolve conflicts between opentelemetry and datadog metrics names.
Additional Notes
The converged agent is unreleased. This change does not require a release note.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

cc @dineshg13

4. tel.system.cpu.load_average.15m

I ran the converged agent locally and am I able to see the otel.* prefix on metrics.

Looks like you need inv tidy

/merge


Remove SCSS stack?

The scss stack was added mostly so I could easily nest/scope the water.css stylesheet into the readme pages, to get some basic styling in. I also just like how is more modular/readable. It does mean that the build/install process is more complicated for the main Spicetify repo if/when the marketplace is merged in.
I'm wondering if we are able to add a GitHub action to compile the css on release or when it's changed. Otherwise we might have to pick through water.css and strip anything extra, and end up with a lot of messy css for the custom app.

We could look into a pre-commit hook or something, to see if it's possible to automatically compile the css before committing/pushing. This could also potentially open the door to using more modern tooling like TS or JSX.
Reference:
https://blog.logrocket.com/build-robust-react-app-husky-pre-commit-hooks-github-actions/

We're going to be converting the app to use Spicetify Creator, so this issue is no longer valid.


Releaes notes?

I see the version being incremented, but before upgrading I like to see what the release notes are for each version.
I can't seem to find them for this project. Am I missing them?

Brilliant! Thanks @jamesmontemagno


tokens

Run the following command：
jscpd src -r json -o './maintainability-report-duplicate-temp/'

The tokens field in duplicates is always zero:

As a temporary solution，do I have any way to calculate the token length of a code snippet?


consolidate author name across timeline

PR is trying to fix different visuals of user's name in the timeline (see images below) I was experimenting with different styles and size but GH's is looking best.
before

after

it's one of many UI changes after https://github.com/go-gitea/gitea/pull/10972

Please undo the changes to all locales except locale_en-US.ini. Those locales are updated by Crowdin and will be overwritten without mercy after each merge to master by our CI process.

@guillep2k done

please fix lint

This will break other languages translations.

@lunny but I don't think that makes this PR breaking

I don't think this is breaking because we have changed translations before like this and not marked it breaking. I know translations will be empty for this option in other languages, but in crowdin once put back in it'll be the same.

well at this point old v1.11 versions cant just copy current locales from master


FastZip.ExtractZip only uses WindowsNameTransform.

FastZip works on windows but not on other platform.
So I checked out the source.
It only uses WindowsNameTransform, so dir\b.txt is saved as filename 'dir\a.txt' as is.
Please fix this.
Anyway. Thank you for the nice library.

This is a duplicate of #54

This issue was resolved when PR #65 was merged into master at e01215507cf25a5978a0bd850c9e67dbabf515b7
-Neil


xtickslabel does not work in display, but in figure export

I am not sure whether this is a bug or a principal limitation or nothing of both...
f=plt.figure(figsize=[10,10])
ax=plt.subplot(1,1,1)
ax.set_xlabel('Time')
ax.set_ylabel('Neurons')
tr_im=plt.imshow(trace1.df_f[labels,:],extent=[0,trace1.n_t,0,len(labels)],aspect='auto')
tr_im.set_interpolation('nearest')
plt.gca().set_xticks(range(0,len(trace1.timestamps),500))
plt.gca().set_xticklabels(trace1.timestamps[::500])
plt.colorbar()
tr_im.set_cmap('coolwarm')
tr_im.set_clim([0,0.2])

if I export the figure with plt.savefig, the xticks commands work and give the right results, in the notebook things are unchanged.
Many Thanks for this great package!

This is a known bug. mpld3 does not support fixed tick labels. See https://github.com/jakevdp/mpld3/issues/278

Ok, then I am sorry.Closed


Not able to ping between containers on different hosts.

Server version - V 0.19.2
Steps to reproduce the problem:
Create container1 in host1.
Create container2 in host2.
Not able to ping container2 from container1.
I see that the the ip address of container1 is programmed in Network Agent of host2 but not in host1.
In my set up , I have been doing some testing withlink services to check for DNS resolution. When containers where on different host , DNS resolution was getting a connection error.  This is when I noticed that the containers are not able to ping each other across hosts.
Note- DNS resolution works as expected when all the instances that it resolves to are in the same host as the client container from which we are accessing the DNS.

This issue is not reproducible all the time.
In a fresh set up I have , I am able to ping containers across hosts.
Also the DNS resolution works for containers across host.

As far as I can tell the overlay network works fine.. Reopen if you have a reproducible problem.


Updated readme #1

Description
Added labels and logo of the program as well as contributors section too.
Fixes #1
Type of change
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this :

[x] Improve the readme of any project

Domain of Contribution
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this
Checklist ✓
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] l have performed a self-review of my own code or work.

[x] My changes generate no new warnings

[x] I'm HSOC'22 contributor

Screenshots/Gif (Recommended)

@khushimarothi  do the same changes as i said in the Web3.0-World .. repo
about the logo and also update the contributor section
Thank u

@khushimarothi do the same changes as i said in the Web3.0-World .. repo about the logo and also update the contributor section Thank u

@khushimarothi  update the branch to the newest as it behind from mine .

What kind of the updation in contributors section?

What kind of the updation in contributors section?

Nothing i thought u haven't created this section . Sorry for this . Update the logo.

Yup will do it till Tomorrow. Cause my laptop have some issues.

Yup will do it till Tomorrow. Cause my laptop have some issues.

Ok no problem ..

Updated.Please check.

Great


frontend : fix overflowing of alert-word-status-text when the window narrowed

when a window is narrowed the alert-word-status-text overflow out of the alert-success.
Testing plan: Tested locally
GIFs or screenshots:
Before

After

@ritikchauhan-01 can you post an "after" screenshot to show this change working without a reviewer needing to test manually?  Also, it'd be nice if you fixed the commit message to have a shorter title.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

@timabbott can you review it.

Merged, but I think structurally we may want this CSS on that class of component.


AdvancedVerticalStackPanelConstraints UIView extension

Vertical stack panel constraints with support for children independent left, right and top margins
and a multiplier factor for all margins applied. The multiplier can be useful when dealing with ipad screens.
It will respect the global margins specified in the Margins object.
The children specific margin will only be applied when it´s bigger than the global margin.
This is tested and it´s been very handy for the app I´m doing.
Example:
scrollView.AddConstraints(scrollView.AdvancedVerticalStackPanelConstraints(null,
     childrenLeftMargins: new float[] { 15, 0, 15, 0, 0, 15 },
     childrenTopMargins: new float[] { 15, 5, 15, 5, 8, 15, 22, 8, 8, 28, 28 },
     marginMultiplier: 2f,
     views: scrollView.Subviews)

Can you add some layouts to the sample project that demonstrate this in action?

Sure.
BTW, the example navigation gets broken once you navigate back from any screen

Done.

Thanks for adding the sample!

As the "Avanced" version does basically the same but adding margins, I can use the VerticalStackPanelConstraintsjust as a proxy. Please, see the last commit

I picked out your changes on top of the latest in master since there was a merge conflict here, commit 17e050f
Thanks for contributing!


Contribution list title modified

Contribution list modified by @cseshohag

@ratanparai bro... you can merge this PR.

@ratanparai bro.. i am not able to merge PR. Please merge this PR. or give me Administrative permission.