NotImplementedError: Cannot copy out of meta tensor; no data!

I am following along on this notebook for Llama 2 finetuning.
https://github.com/generative-ai-on-aws/generative-ai-on-aws/blob/9155632d0c30ae40a0d60240b95495db73b4d7e1/05_finetune/01_fine_tune_dolly_llama2_huggingface.ipynb
I am running a AWS Sagemaker studio with an ml.g5xlarge instance and Sagemaker Distribution 1.2.
All cells execute without error until the training step. I don't make any modifications to the code except for allowing pip to install the latest versions
!pip install peft
!pip install accelerate

When running the training cell I get the following error
# Define training args
output_dir = "./tmp/llama2"
training_args = TrainingArguments(
    output_dir=output_dir,
    per_device_train_batch_size=args.per_device_train_batch_size,
    bf16=args.bf16,  # Use BF16 if available
    learning_rate=args.lr,
    num_train_epochs=args.epochs,
    gradient_checkpointing=args.gradient_checkpointing,
    # logging strategies
    logging_dir=f"{output_dir}/logs",
    logging_strategy="steps",
    logging_steps=10,
    save_strategy="no",
)

# Create Trainer instance
trainer = Trainer(
    model=model,
    args=training_args,
    train_dataset=lm_dataset,
    data_collator=default_data_collator,
)

# Start training
trainer.train()

NotImplementedError                       Traceback (most recent call last)
Cell In[10], line 18
3 training_args = TrainingArguments(
4     output_dir=output_dir,
5     per_device_train_batch_size=args.per_device_train_batch_size,
(...)
14     save_strategy="no",
15 )
17 # Create Trainer instance
---> 18 trainer = Trainer(
19     model=model,
20     args=training_args,
21     train_dataset=lm_dataset,
22     data_collator=default_data_collator,
23 )
25 # Start training
26 trainer.train()
File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:499, in Trainer.init(self, model, args, data_collator, train_dataset, eval_dataset, tokenizer, model_init, compute_metrics, callbacks, optimizers, preprocess_logits_for_metrics)
497 # Quantized models doesn't support .to operation.
498 if self.place_model_on_device and not getattr(model, "is_quantized", False):
--> 499     self._move_model_to_device(model, args.device)
501 # Force n_gpu to 1 to avoid DataParallel as MP will manage the GPUs
502 if self.is_model_parallel:
File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:741, in Trainer._move_model_to_device(self, model, device)
740 def _move_model_to_device(self, model, device):
--> 741     model = model.to(device)
742     # Moving a model to an XLA device disconnects the tied weights, so we have to retie them.
743     if self.args.parallel_mode == ParallelMode.TPU and hasattr(model, "tie_weights"):
File /opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py:1900, in PreTrainedModel.to(self, *args, **kwargs)
1895     raise ValueError(
1896         ".to is not supported for 4-bit or 8-bit models. Please use the model as it is, since the"
1897         " model has already been set to the correct devices and casted to the correct dtype."
1898     )
1899 else:
-> 1900     return super().to(*args, **kwargs)
File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1145, in Module.to(self, *args, **kwargs)
1141         return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None,
1142                     non_blocking, memory_format=convert_to_format)
1143     return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
-> 1145 return self._apply(convert)
File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:797, in Module._apply(self, fn)
795 def _apply(self, fn):
796     for module in self.children():
--> 797         module._apply(fn)
799     def compute_should_use_set_data(tensor, tensor_applied):
800         if torch._has_compatible_shallow_copy_type(tensor, tensor_applied):
801             # If the new tensor has compatible tensor type as the existing tensor,
802             # the current behavior is to change the tensor in-place using .data =,
(...)
807             # global flag to let the user control whether they want the future
808             # behavior of overwriting the existing tensor or not.
File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:797, in Module._apply(self, fn)
795 def _apply(self, fn):
796     for module in self.children():
--> 797         module._apply(fn)
799     def compute_should_use_set_data(tensor, tensor_applied):
800         if torch._has_compatible_shallow_copy_type(tensor, tensor_applied):
801             # If the new tensor has compatible tensor type as the existing tensor,
802             # the current behavior is to change the tensor in-place using .data =,
(...)
807             # global flag to let the user control whether they want the future
808             # behavior of overwriting the existing tensor or not.
[... skipping similar frames: Module._apply at line 797 (2 times)]

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:797, in Module._apply(self, fn)
795 def _apply(self, fn):
796     for module in self.children():
--> 797         module._apply(fn)
799     def compute_should_use_set_data(tensor, tensor_applied):
800         if torch._has_compatible_shallow_copy_type(tensor, tensor_applied):
801             # If the new tensor has compatible tensor type as the existing tensor,
802             # the current behavior is to change the tensor in-place using .data =,
(...)
807             # global flag to let the user control whether they want the future
808             # behavior of overwriting the existing tensor or not.
File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:820, in Module._apply(self, fn)
816 # Tensors stored in modules are graph leaves, and we don't want to
817 # track autograd history of param_applied, so we have to use
818 # with torch.no_grad():
819 with torch.no_grad():
--> 820     param_applied = fn(param)
821 should_use_set_data = compute_should_use_set_data(param, param_applied)
822 if should_use_set_data:
File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1143, in Module.to..convert(t)
1140 if convert_to_format is not None and t.dim() in (4, 5):
1141     return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None,
1142                 non_blocking, memory_format=convert_to_format)
-> 1143 return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
NotImplementedError: Cannot copy out of meta tensor; no data!

I am aware that I am not running a p4d instance as suggested (I could not get the quota yet). if that is the source of the error, is there a workaround to make it work on other instance types?

Thanks very much.

I found this related forum. It seems to be insufficient VRAM. I will wait for a larger AWS instance and try again.
https://github.com/tloen/alpaca-lora/issues/368
When loading the model using device_map="auto" on a GPU with insufficient VRAM, Transformers tries to offload the rest of the model onto the CPU/disk. The problem is, the model is being loaded in float16 which is not supported by CPU/disk (neither is 8-bit). So, torch offloads the model as a meta-tensor (no data). In other words, parts of the model are missing.

Solutions:

Using the -g and -r arguments: gives Accelerate a manual config for where it should offload the model. Accelerate takes care of the dtype.
Loading the model using either float32 or bfloat16 should work. Note, I haven't tested this one out myself but it should work.
Using a larger GPU. This prevents offloading in the first place.

The next section on PEFT shows some tips on how to use smaller instances to fine tune llama2.


[ENHANCEMENT] Freeplay DJ changes if you select BF or Pico

Currently a WIP.
In simple terms: If the character is a valid entry in the Player Registry and has Freeplay DJ data, then Funker Selector will swap out the current DJ with the character's own DJ.
Demonstration
https://github.com/user-attachments/assets/57c87381-5c84-4fa4-8cad-6a06623864e6
Issues

Switching between Boyfriend and Pico too many times causes the DJ to disappear.
Exit Movers don't get applied properly when the DJ is re-added.

TODO

Replace the DJ when (re-)entering Freeplay as well.

I think I'll push this to v2.0.0 instead of v1.5.0, to coincide with the custom BF animations.

The messy commit history is now gone.

This PR is pretty much ready to go. There are still a few changes I want to make, but I'll do them in the develop branch.


The image rights should be displayed under the image rather than on overlay

Example: https://ada.silknow.org/object/329ae1a1-f6a1-3e5b-91f5-5336512f1d80
The right of this image seems to be http://data.silknow.org/object/329ae1a1-f6a1-3e5b-91f5-5336512f1d80/right : "propriété de la commune (fr)"
It should be displayed under the image and not as an overlay on the image.
@tschleider given the URI pattern used, it seems that the rights is attached to the object rather than the image. Is it intended?
I think we should check as we could have rights attached to the entire record (D1) / or attached to the images.

The image rights are now displayed under the image.
Regarding the KG question I suggest that we open an issue on silknow/converter if it requires an action.


Add Indonesian translations

I Will Take care of this :smile:

Thank you so much matey ❤ ❤ ❤ ❤ ❤ ❤ ❤ ❤

@sasongkoadi hi! write please if you are ready to translate.


Snowy Tundra biome playing wrong biome sounds

Mod Version: DynamicSurroundings-1.16.4-<IP_ADDRESS>.jar
Forge Version: 36.1.0
Link to client log: https://pastebin.com/C7gFPpY2
Link to crash log: The game does not crash.
As title says. minecraft:snowy_tundra biome does not play the appropriate biome sound. It sounds like something that would play in the nether.
Video: https://youtu.be/0fXbEn9byoE
Only this mod is installed, using curseforge client.

Not able to view the video - it is marked private for some reason.  To be clear no datapacks involved?

Video is fixed. you should be able to view it now. You might want to use headphones.
There are no other mods or datapacks involved.

Ok- that is the arctic wind sound which is the correct sound for the biome.  Is your volume sliders are 100%?

Hmm. they are. maybe it was just me but it sounds sinister and bass heavy

I have been looking for a decent replacement for the sound for a while but have yet to find one that I could use.  There are elements to the current sound clip that I am not to keen on.


ci: fix revision

Codecov Report

Merging #61 (c9f9b0e) into master (ae55ce5) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #61   +/-   ##
======================================
  Coverage    8.32%   8.32%
======================================
  Files          27      27
  Lines        1585    1585
======================================
  Hits          132     132
  Misses       1436    1436
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae55ce5...c9f9b0e. Read the comment docs.


Task 5.4.3 does not completely implement the settings required by CIS

Describe the Issue
Wrong implementation of the settings required by CIS
Expected Behavior
CIS clearly states in its assessments that for this rule ("Ensure password reuse is limited")  the password required pam_pwhistory.so use_authtok remember=5 line should be placed directly above the password [success=1 default=ignore] pam_unix.so obscure yescrypt line in  the "/etc/pam.d/common-password file".
Actual Behavior
With the current situation, only this line password [success=1 default=ignore] pam_unix.so obscure gets edited in the file by adding remember=5. CIS does not consider this as compliant.
Control(s) Affected
5.4.3 Ensure password reuse is limited
Environment (please complete the following information):

branch being used: [e.g. devel]

Additional Notes
Anything additional goes here
Possible Solution
The solution will be provided in a PR.

hi @DianaMariaDDM
Thank you for taking the time to raise this issue and related PR. I have been looking for the configuration you are referring. While we are aware it needs the pwhistory library added. This Is not shown in the remediation steps for downloaded pdf for the benchmark for released 1.0.0, the artifact <IP_ADDRESS> is only available on the online version
While looking at the online version of the same document it mentions the configurations you have mentioned and the pwhistory library.
We will investigate this issue further and look to get the PR approved asap.
many thanks
uk-bolly

I believe that this issue has been addressed and the fix merged?
I will close this issue, please feel free to reopen or raise a new one if this particular problem still exists.
Many thanks
uk-bolly


Delete all selected lines using the "delete line" shortcut in script editor

Currently hotkey deletes only single line in an editor, now all selected lines are deleted

Thanks for your contribution.
Would you mind amend your commit with a more descriptive message ?
Also it seems that the email address you used to author you commit is not the same as your Github address, thus it look in Github that you're not the commit author. You might want to change the commit's author.

thanks for the tips, done :)

Thank you. There are some styling issues. The changes didn't comply with clang-format. Please use clang-format -i <filename> and git commit --amend. (PR workflow)

done


Reliable initialization of keyboard and pointer bindings

We should review the messaging mechanism of various bindings (keyboard and pointer) and make them reliable. The current process, where the embedding blindly sends events to the framework, might cause message loss at initialization and state instability, especially during hot restarts.
Analysis
Take keyboard as an example. Currently, when the app is started,

The Flutter view creates both a keyboard manager and a dart VM.
The keyboard manager immediately starts listening to system key events and send messages through the embedder API, FlutterSendKeyEvent.
It takes a short while for the dart VM to boot and run through all static statements, such as assigning a listener to the framework API onKeyData.
If a key event happens between the creation of the keyboard manager and the initialization of the framework, since the listener is still null, the message is lost.

Since the keyboard system only sends events, not the entire state, packet losses are critical and lead to state instability.
Now, we have managed to alleviate this issue by making the keyboard system send messages through the binary messenger to make use of the message buffer (https://github.com/flutter/engine/pull/29795). But the message buffer only has a depth of 1, and it's not difficult to reproduce a case that overflows the buffer (https://github.com/flutter/flutter/issues/89748). We can increase the buffer, but that only makes the problem "harder" to occur, not impossible.
The same problem is also found in the pointer event system (https://github.com/flutter/flutter/pull/102453#issuecomment-1117898221). We decided to temporarily alleviate this problem by relaxing the assertions.
Moreover, if the framework decides to reconstruct the keyboard manager or pointer manager, there is no way to synchronize the states.
Proposal
There are two options to fix this issue.

Send states, not deltas. By always sending the entire keyboard/pointer state on every change, state stability is guaranteed, and the 1-depth message buffer can be used as intended. However these states can get really big. The user might smash the keyboard, pressing 30 keys at the same time, which becomes 60 uint64s per message, and the framework also needs to compare the state difference to figure out events.
Initiate messaging/synchronization by framework. The framework will send an establishment message when it first assigns a listener, and the engine will reply this message with a full state. This method complicates the API protocol, but keeps the followup messages light.

Both of the two options will possibly be a breaking change to the current embedder API.

+cc @jason-simmons @gspencergoog

It'd also be great to hear @stuartmorgan 's opinion, since when we were planning for the keyboard API, we decided to put it into embedder.h to mark it "stable", and now we might have to break it. The problem is:

The APIs outside of embedder.h should be as stable as the ones in it. Event if the API had been written in message channels instead, any changes to them will still cause a breakage.
Putting APIs in embedder.h does not guarantee the stability either, since embedder.h only defines the messages from the embedding to the framework, but not the other way around.
The keyboard system, after https://github.com/flutter/engine/pull/29795, is essentially using a binary message channel, but it has to re-implement the binary encoder, because the encoding has to be written in embedder.cc.

We can increase the buffer, but that only makes the problem "harder" to occur, not impossible.

Keyboard messages are small; is there a reason these events specifically can't use an unbounded buffer? How much memory are we realistically talking about here?

Both of the two options will possibly be a breaking change to the current embedder API.

Why would they be breaking changes? If you want to send full state, the accumulation of that state from deltas can be done under embedder.h from the current information. If you add a new callback, when it's not set the behavior is the current behavior (no initial state).

It'd also be great to hear @stuartmorgan 's opinion, since when we were planning for the keyboard API, we decided to put it into embedder.h

Adding @chinmaygarde who wanted to do that since before I joined Flutter.

to mark it "stable"

It wasn't just to mark it stable. It makes the API more consistent, much easier to use (compile-time, typed enforcement of data passed), and decouples the stable API from implementation details of marshalling (see below).

The APIs outside of embedder.h should be as stable as the ones in it.

This is true, but it's much harder to keep track of.

2. embedder.h only defines the messages from the embedding to the framework, not the other way around.

The fact that some things haven't been converted to embedder.h APIs yet isn't an argument against it, it just means we should convert those too 🙂 Registering callback methods is already a common pattern in embedder.h.

3. but it has to re-implement the binary encoder, because embedder.cc can not use the encoders.

The alternative is:

Every single embedder must implement the encoder we use. For instance, the Windows embedder implemented and is shipping a JSON encoder for the sole purpose of dealing with a few system channels that use an encoding we don't even want to be using any more (but can't easily change because it's a de-facto part of the API surface)
We can never change the serialization details. We can't change codecs, as mentioned, but also can't change the exact format. Consider the pointer serialization for example: it's very space-efficient, but also extremely fiddly. Would you force every embedder to do all those details correctly? Or would you make it a key-value structure that's less error-prone, but probably an order of magnitude larger? We shouldn't have to make tradeoffs between API usability and marshalling efficiency.

Keyboard messages are small; is there a reason these events specifically can't use an unbounded buffer? How much memory are we realistically talking about here?

I don't think ChannelBuffers supports unbounded buffer at all. Also, although a key event might be small, there can be a lot: at worst case the user can hold all 108 keys at start up and we'll have to send each of them as an initializing event. (Which doesn't matter if we add a synchronizing API.)

Why would they be breaking changes? ...

You're right. I can call it something like "synchronize state" and nothing will be broken.

It makes the API more consistent, much easier to use...

Can you illustrate why we require ABI stability for embedder.h? Do we compile to a .dll or something? I thought we static linked everything so if, for example a field in a struct defined in embedder.h is changed from a int64 to a double, the engine compiler would have caught it. Everything should work fine as long as the engine and the framework are using matching versions.

Every single embedder must implement the encoder we use...

Off topic but in the foreseeable future we have to keep them.

Can you illustrate why we require ABI stability for embedder.h?

I'm not sure what you mean by "illustrate". We require it because it's our explicit, documented policy that the embedder.h API, which is public, preserves ABI.

Do we compile to a .dll or something?

We do compile a DLL with that API surface, yes. https://github.com/flutter/flutter/wiki/Custom-Flutter-Engine-Embedders
Any anyone else is welcome to as well.

I thought we static linked everything so if, for example a field in a struct defined in embedder.h is changed from a int64 to a double, the engine compiler would have caught it.

This is true for our own uses of the API. It is not true in general.


jetbrains.rider: 2021.1 -> 2021.1.1

Motivation for this change
From the release notes:

Rider 2021.1.1 is here to fix the license issue which was unfortunately introduced in the recent 2021.1 update

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119384 at 66fc4b01 run on x86_64-linux 1

1 package built successfully:

jetbrains.rider

1 suggestion:

warning: no-uri-literals
URI literals are deprecated.
Near pkgs/applications/editors/jetbrains/default.nix:147:20:
    |
147 |         homepage = https://www.jetbrains.com/mps/;
    |                    ^


Reproduction

Hello author, Thanks for your excellent work!
I have some questions about code reproduction to ask you. I retrained for 16 epochs on a single 48GB GPU without using distributed training. The reproduced results were: acc:0.4411, comp:0.4156, overall:0.4284, and these metrics did not meet expectations. Is this due to training with a single GPU? Or could there be other reasons？
I would greatly appreciate your answers to my questions!

Thank you very much for your answer. I will analyze from the perspective of loss curve.
Do you think that training with a single 48GB GPU will affect the training effect?

Hello, while reviewing your code, I noticed that the mask used for calculating Iccloss is a randomly generated filter_mask. Additionally, during the image-level data augmentation process, you not only add Bernoulli noise but also apply the randomly generated filter_mask to the reference image again. This seems inconsistent with the description in the paper. What is the reasoning behind this approach? Below is the relevant source code:
ref_img, filter_mask = random_image_mask(ref_img, filter_size=(ref_img.size(2) // 3, ref_img.size(3) // 3))


Issue: New NativeEventEmitter requires a non-null argument

Describe the bug
Getting issue while following the steps what was mentioned on the readme file for ios app chime integration. I copy the files that are required for bridging in my ios folder. And added the permission info.plist and as well as added the line   pod 'AmazonChimeSDK-Bitcode', '0.19.1' to pod file as well but while running the app and loading the screen its hows New NativeEventEmmiter requires a non-null argument error as shown in the image

Additional context
I run this demo repo and its working fine only while implementing in my project giving error. The version of react and react studio is same as in the demo app ..
Please help me resolving the issue please

Hi do you mind providing minimal repo that causes this issue since you said demo is working, but not your project, it might be some dependencies.

Hi @hokyungh here is the url https://github.com/sambeetsahu/ioschime

Hi @sambeetsahu , I have looked at the code and it seems that you did not add m and h files to xcode project. See the code you have vs our code. Try to open Xcode project and add this file.

Feel free to reopen if you still have issue after adding files.

Hi @sambeetsahu , I have looked at the code and it seems that you did not add m and h files to xcode project. See the code you have vs our code. Try to open Xcode project and add these files.

Hi @hokyungh i have copy and paste the .m file and .h file to the ios folder directly.. becuse of that i guess the refrrence of the file is nit showing as u highlighted in that file m and h files are missing
Can you please guide me the steps to create this m and h files in xcode .. that will be helpfull

Thanks @hokyungh finally it got resolved.

Hey @sambeetsahu how did you resolve it?

@yashukla47  I am guessing u are also doing the same thing like copy and paste the file directly in to the ios folder.
if you do like this then the file reference will not added as mentioned above in message thread.
So you need to create first header file and empty file for (.m file) inside the ios/your project folder for header file and .m file


code folding triangles are shown in an empty script and force cursor to jump back and some other

When editing a new script for an object, GLX2 now shows line numbers and also already placeds code folding triangles at line 1, 6, 14, 18,20
It is not possible to press Enter in line 6 as long as line 6 is empty. The cursor jumps back.
If line 6 contains text and one is able to press enter to jump to line 7. And there again it is not possible to press enter until some text is in line 7 and so on.
Opening an existing script those wrong triangles are also shown , but also correct ones.
When opening/creating a 2nd script in GLX2, regardless if new or already existing,  while the first script is still opened in GLX, then the font size of the new script is smaller (maybe the default size) than the configured one and typing is almost impossible as it is awfully slow, but all triangles are missing, even the correct ones.
Here´s a screen recording show the described behaviours.
https://livecode.dermattes.de/glx2/GLX2_4_14.mp4

I believe this is all fixed now with the latest version.


Deploy history JSON on Request page should only show deploy info

...not entire task info
@tpetr

LGTM, thanks


Extract files from volumes in chunks instead of entire file at once

Consider creation of standardized function for this either that either lives in ArchiveUnpacker or maybe attached to FileStreamWriter.

I'd like to work on this in the future. I think maybe after HANDLE is removed from VolFile.


Cannot connect over http to test nodes

Hello! I'm new to the awesome QM. I am following the quick-start to deploy a test network on my mac. I'm using the latest docker and QM. After running 'docker-compose up' I navigate to the the following URLs in chrome\safari without any response back. Do I need to configure something extra? I don't have any anti-viruses or firewall apps installed.
http://<IP_ADDRESS>:22004
http://<IP_ADDRESS>:22004
----- Full copy-paste from the terminal -----
Please select an option:

Create Network
Join Network
Attach to an existing Node
Setup Development/Test Network
Exit
option: 4
Please enter a project name[Default:TestNetwork]:TestNetwork
Please enter number of nodes to be created[Default:3]:
Creating TestNetwork with 3 nodes. Please wait...
##################################################
Project TestNetwork created successfully. Please execute docker-compose up from TestNetwork directory
macs-MacBook-Pro:quorum-maker mac$ ls
LICENSE		TestNetwork	doc		lib		setup.sh
README.md	Vagrantfile	img		qm.variables
macs-MacBook-Pro:quorum-maker mac$ cd TestNetwork/
macs-MacBook-Pro:TestNetwork mac$ docker-compose up
Creating network "testnetwork_vpcbr" with driver "bridge"
Creating node1 ... done
Creating node3 ... done
Creating node2 ... done
Attaching to node2, node1, node3
node2    | Waiting for Node 1 to deploy NetworkManager contract...
node1    | {"level":"info","msg":"Node Manager listening on :22004...","time":"2018-08-17T00:41:50Z"}
node3    | Waiting for Node 1 to deploy NetworkManager contract...
node1    | {"level":"info","msg":"Deploying Network Manager Contract","time":"2018-08-17T00:41:51Z"}
node2    | {"level":"info","msg":"Node Manager listening on :22004...","time":"2018-08-17T00:41:55Z"}
node3    | {"level":"info","msg":"Node Manager listening on :22004...","time":"2018-08-17T00:41:55Z"}
node1    | {"level":"info","msg":"Adding whitelisted IPs","time":"2018-08-17T00:41:55Z"}
node2    | {"level":"info","msg":"Adding whitelisted IPs","time":"2018-08-17T00:41:57Z"}
node3    | {"level":"info","msg":"Adding whitelisted IPs","time":"2018-08-17T00:41:57Z"}

Hi @karapish. In the Readme we've mentioned the following regarding test networks on Mac.
Note: If you create a Development/Test Network on Mac, the ports are automatically exported in sequential number, starting 20104, 20204 and so on for each you node created.
Could you  kindly try with these ports

Yes! The ports you mentioned do serve html content on Mac. Excuse me for not reading the instructions carefully enough.


Riot.js v4

Hi
I implemented RealWorld with Riot.js v4.
I have confirmed that all of these functional requirements have been met.
Thank you for your review🙏.

title
content

Repository
https://github.com/iq3addLi/riot_v4_realworld_example_app

Demo
https://riot-v4-realworld.addli.co.jp

@anishkny
Sorry for the iteration.
May I ask for this review as well?
Thx!😆


[DBZ-1643] Manage sql server timestamp timezone

https://issues.redhat.com/browse/DBZ-1643
This pull request try to manage the sql server timezone in the transaction timestamp (ts_ms).
Currently, the server timestamp extracted by SqlServerConnection.timestampOfLsn() is a DateTime and don't own any timezone information. Because of that, if the client (debezium connector) and the server use different timezones, the transaction (ts_ms) timestamp is wrong.
One property has been added : database.server.timezone

The default value (CLIENT) don't change the current debezium connector behavior
The property can be set to any valid Java/IANA timezone
Setting the property to SERVER will try to extract the timezone from the server.
The current method to extract the timezone from the server is a little bit naive. It is actually a 'best effort' approach. Any suggestion to improve this is welcome

First It use the xp_regread function : maybe this function is not always available..?
Second the conversion from Windows timezone to Java timezone just loop on the timezone displayname. And the two timezone dictionnaries are not bijectives.

Thanks a lot, @jvenant!
Could you file a bug report in JIRA please and refer to its number in the commit message?
@grzegorz8, @jpechane, any ideas on this one:

The current method to extract the timezone from the server is a little bit naive. It is actually a 'best effort' approach. Any suggestion to improve this is welcome

@jvenant Hi, may I ask why this function cannot be used? https://docs.microsoft.com/en-us/sql/t-sql/functions/current-timezone-transact-sql?view=sql-server-ver15 ?
Also what level of privileges the Debezium user needs to be able to execute the query you've proposed?
Thanks for the contribution!
J.

Hi @jpechane,
I'm definitely not a SQL Server expert. But in my mind, accessing Windows registry keys from an SQL Server client is a little bit weird and dangerous. So I suppose the access to the xp_regread function is limited. But I didn't find anything clear about that.
The only thing I found is the query to grant the xp_regread execution :
GRANT EXECUTE ON xp_regread TO public
Of course the SQLServer server itself need read permissions on the registry

Maybe the SERVER is too ambitious ?
Maybe we should just have a java timezone in database.server.timezone.
If set use this timezone otherwise use the client timezone

@jvenant I think it is fine, I'd just use SELECT CURRENT_TIMEZONE () and if not working then warn user to use explicit setting.

I can try to do that, but I see 2 issues on my side :

It will work only on Azure SQL Server and I don't have such kind of setup available to test
The Sql server timezone to java timezone mapping seems even more hazardous than with xp_regread

@jvenant Hi, the standard SQL Server image we are using in tests should definitely support the function in question.
Regardin 2. - yes the mapping can be problem so maybe it would really be better to just drop to automatic approach. I googled about xp_regread function and it is offically uncupported and recommended to disable as security risk so I am really not sure how much we can realy on it.

Done.
Now, database.server.timezone only accept valid timezone.
If not set, the client timezone is used

@jvenant I've added two comments. Generally this looks fine to me. If possible please correct the two issues, squash commits into a single one and use commit message in for of DBZ-1643 Manage sql server timestamp timezone`.
Thanks a lot!

All feedback have been taken in account.
Thanks to all of you for your great work on Debezium

So we gave up on obtaining the server TZ from the server? Why is that? Note the issue with TZ shift of one hour after transition from DST to wintertime is present here as well, unless you reconfigure your connector and restart it right at that time. I wished we could get around exposing yet another option for something which seems automateable. 🤔

So we gave up on obtaining the server TZ from the server? Why is that?
I see 4 reasons :

xp_regread function should be disable for security reason. So we can't rely on it
CURRENT_TIMEZONE is only available on limited flavor of sql server.
Mapping between Windows timezone and Java timezone is very hazardous
Changing the timezone of a bdd server should be done with caution and is not something happening on a day to day base. So auto detection might be overkill. Especially considering that because of the mapping issue the detected timezone could be a wrong one.

Note the issue with TZ shift of one hour after transition from DST to wintertime is present here as well, unless you reconfigure your connector and restart it right at that time. I wished we could get around exposing yet another option for something which seems automateable. thinking

I don't think the wintertime issue is present if you use a timezone. Because timezone as opposed to offset
know the offset of an instant with winter/summer time consideration
ZonedDateTime.of(LocalDateTime.of(2020,03,29,1,45), ZoneId.of("Europe/Paris")) = 2020-03-29T01:45+01:00[Europe/Paris]
ZonedDateTime.of(LocalDateTime.of(2020,03,29,1,45), ZoneId.of("Europe/Paris")).withZoneSameInstant(ZoneId.of("UTC")) = 2020-03-29T00:45Z[UTC]

// please note that 2020-03-29T02:45+01:00[Europe/Paris] don't actually "exists" and is converted to 2020-03-29T03:45+02:00[Europe/Paris]
ZonedDateTime.of(LocalDateTime.of(2020,03,29,2,45), ZoneId.of("Europe/Paris")) = 2020-03-29T03:45+02:00[Europe/Paris]
ZonedDateTime.of(LocalDateTime.of(2020,03,29,2,45), ZoneId.of("Europe/Paris")).withZoneSameInstant(ZoneId.of("UTC")) = 2020-03-29T01:45Z[UTC]

ZonedDateTime.of(LocalDateTime.of(2020,03,29,3,45), ZoneId.of("Europe/Paris")) = 2020-03-29T03:45+02:00[Europe/Paris]
ZonedDateTime.of(LocalDateTime.of(2020,03,29,3,45), ZoneId.of("Europe/Paris")).withZoneSameInstant(ZoneId.of("UTC")) = 2020-03-29T01:45Z[UTC]

Consider the last scenario :

you udpate your database at 2020-03-29 (1:45AM GMT+1) (0:45 UTC)
transaction end datetime = 2020-03-29 (1:45AM) (no offset or zone stored)
you ingest the change in kafka after the shift through debezium
get the transaction date 2020-03-29 (1:45AM) (no offset or zone stored)
get the timezone from the config (or whatever) -> CET
set the timezone of the timestamp : 2020-03-29 (1:45AM-CET) == 2020-03-29 (0:45AM-UTC)

Ok, so I think I've found a solution which avoids the config option, at least on SQL Server 2016 and newer.
The trick is to normalize the obtained timestamp to UTC by means of the AT TIME ZONE option introduced in that version. Then it's not needed to configure the timezone connector option.  I've pushed one commit to this PR for implementing this.
I've still left the option you added in place, but it should only needed on 2014 and older. It's also described as such in the docs. Could you give this a try and let me know whether it works for you, @jvenant, @jpechane? Thanks!

I like your approach. It works for me :+1:

I am sorry guys, I was adding a test and managed break this PR :-(. The follow up -s in https://github.com/debezium/debezium/pull/1181


How to use Icon ?

I've installed the library with npm install material-ui .
When i use the component <FontIcon className='mui-icon-sort' /> , there is no icon to show.
Do you know how to resolve this ?

@checkraiser You need to add the Google font library in your project in order to use icons with <FontIcon> method . Alternatively you can add Google material icons from Google web fonts <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">  and use the icons as mentioned below:
<RaisedButton>
    sort
</RaisedButton>

<FloatingActionButton>
    sort
</FloatingActionButton>

Thanks @mairh - There's also this issue to provide support for the google font library inside the library. See #829

Hi, anybody has sample how to include roboto into webpack builds? Mus we use cssloader and fileloader for css and font? and can we just include ttf or all the formats too ? thanks


Improove rows count visibility, and selected column number

SQL Operations Studio Version:
0.27.3

When you run a query, result shows row count.
This forces me to keep messages tab open, and causes me to loose some valuable space on my window (my laptop resolution is 1366 x 768).
Plus, when you select a cell in results grid, there is no column index anywhere. This usually helps when you try to order results by a column, and this column is a subquery. I usually write order by "column index". Right now, in SQL Operations Studio I have to count column position.

@luismiguelgilbert have you tried setting "sql.messagesDefaultOpen": false in the User Settings.  This will make the messages pane collapsed by default unless there is an error in the query.  It may help a little with the first issue you've mentioned.

Whats does the rowcount in the purple bar counts?


data persistence

I can't get the image to work with data persistence (-v). I think it might be a user permissions issue, but since I'm not very familiar with Linux, I can't propose a solution. Have you encountered this problem?

I have fixed a few bugs in the documentation. The user is sftpuser and the ssh key docker_rsa.
Assuming that you are using docker desktop try creating a volume called sftp-uploads then run the following command:
Build the image:
docker build -t my-sftp-server .
Run the container:
docker run -d -v sftp-uploads:/home/sftpuser/sftp/upload --name my_sftp_container -p 2222:22 my-sftp-server
Let me know if you run into other problems.
Cheers


The instructions for the Allow CORS extension should be updated

In the instructions, viewers are referred to setting 4. In the extention's settings, this has changed to now be setting number 5.

#10


Fix pics under theme

Coverage remained the same at 90.774% when pulling c055c44798150f796967297602a624842097c6e4 on khooroko:Fix_UserGuide_pics into 0a9a38ec562a61fc0ddce08de96c60a0e7cb1106 on CS2103AUG2017-T17-B1:master.


list: save and restore cursor positions

Harpoon was not remembering the cursor position after quitting nvim.
Ensure that the cursor information is always saved and applied so that
we get back to exactly where we last were in the harpooned file.
Closes: #441

@ThePrimeagen could you please review this PR? It addresses a long-awaited fix.

This seems like an improvement, but doesn't appear to work unless you first navigate to the file using harpoon. I have tested this with sync_on_ui_close both true and false.
For example:

vim A.txt
Add mark on line 5
Quit
vim A.txt
Move to line 10
Quit
vim B.txt
navigate to A.txt in harpoon
Should be on line 10 and not line 5

Adding this autocmd appears to fixe this issue with the default config.
        vim.api.nvim_create_autocmd({ "QuitPre" }, {
            pattern = "*",
            callback = function()
                local bufnr = vim.api.nvim_get_current_buf()
                local path = vim.api.nvim_buf_get_name(bufnr)
                for _, it in ipairs(Harpoon:list().items) do
                    local value = it.value
                    if value == path then
                        Harpoon:list():append() -- now Harpoon:list():add()
                        break
                    end
                end
            end,
        })

However, I still have an issue with the position not updating when switching between files (not using harpoon) and then navigating to the file using harpoon. Easy example of this is make a mark, move down, go to alternate file, go back using harpoon and you will be where the mark is and not where you last left off. I guess this is a different issue since it isn't while quitting, but it seems similar.

I have done a lot of work on getting cursors to save constantly. The latest update does a distributed file style based on settings key, this allows saving upon every change
I would first make sure the latest harpoon2 still has the issue you're looking for

@ThePrimeagen I just checked with latest, harpoon2 does still have the issue.
I was able to update the changes @davvid made to work with the latest harpoon2. Those changes along with the now much simpler autocmd seem to be working.
        vim.api.nvim_create_autocmd({ "QuitPre" }, {
            pattern = "*",
            callback = function()
                -- Do this for all your lists
                Harpoon:list():sync_cursor()
            end,
        })

I tried putting it in harpoon/init.lua and using _for_each_list, but it did not work.
The problem is that _for_each_list does not run callbacks for any lists when I open up a file, move around, but never interact with harpoon at all.
my updated branch https://github.com/maxrzaw/harpoon/tree/sync-cursor seems to be working. There might be some redundancies with the combination of the new changes to harpoon2 and the changes from this PR.

Thanks for the heads-up @maxrzaw -- I've rebased this branch and updated to the latest harpoon2.
make test passes for me locally so I'm looking into the CI results above since they seem to disagree. Interestingly, they're the out-of-bounds tests, and the changes in this branch make it so that setting an out-of-bounds cursor is gracefully handled and ignored.

I have done a lot of work on getting cursors to save constantly. The latest update does a distributed file style based on settings key, this allows saving upon every change
I would first make sure the latest harpoon2 still has the issue you're looking for

For me the position isn't being saved when I quit, regardless of whether I save the buffer or not. The only way I've found to make it work is by toggling the Harpoon list again (leader + h), selecting the same file from the list that's already open, and then quitting. Doing this saves the current position, allowing me to jump back to it when quitting Nvim and reopening the file via Harpoon. All other solutions don't work including AutoCmd suggested by @maxrzaw.
BTW, I'm on the latest commit.

I have done a lot of work on getting cursors to save constantly. The latest update does a distributed file style based on settings key, this allows saving upon every change
I would first make sure the latest harpoon2 still has the issue you're looking for

For me the position isn't being saved when I quit, regardless of whether I save the buffer or not. The only way I've found to make it work is by toggling the Harpoon list again (leader + h), selecting the same file from the list that's already open, and then quitting. Doing this saves the current position, allowing me to jump back to it when quitting Nvim and reopening the file via Harpoon. All other solutions don't work including AutoCmd suggested by @maxrzaw. BTW, I'm on the latest commit.

Latest commit of which branch? I was using latest on harpoon2 with additional changes from this branch. https://github.com/maxrzaw/harpoon/tree/sync-cursor to be exact.

Thanks for the heads-up @maxrzaw -- I've rebased this branch and updated to the latest harpoon2.
The out-of-bounds cursor tests had to be updated with these changes, which I suspect is okay since the results are getting updated to match the file bounds. That's probably worth another look.
@maxrzaw is the expectation that users will need to install the QuitPre autocmd themselves if they want a top-to-bottom fix?
The behavior is better for more scenarios with these changes at least. w/out these changes the cursor position is lost even when switching between two harpooned files. For example, move around in one file, harpoon to a 2nd file, and then harpoon back and the cursor will be in a different position from whence we came. It's in the correct position when using this branch.
Things :bNext and :bPrev do seem to reset the cursor, though, but at least this is better than it was before.
Curious, which scenario does the autocmd handle? I don't see any change in behavior when using save-cursor-position w/ and w/out the autocmd, though maybe that's because I have these options set?

        opts = {

            settings = {

                save_on_toggle = true,

                sync_on_ui_close = true,

            },

        },

These steps:

vim A.txt
Add mark on line 5
Quit
vim A.txt
Move to line 10
Quit
vim B.txt
navigate to A.txt in harpoon
Should be on line 10 and not line 5

The key is that I open a harpooned file and move the cursor, but do nothing at all to interact with harpoon, then quit, this results in _for_each_list not working as expected.

Let me double check everything, I think I know what happened.
I should get some time this week to go over everything

I have done a lot of work on getting cursors to save constantly. The latest update does a distributed file style based on settings key, this allows saving upon every change
I would first make sure the latest harpoon2 still has the issue you're looking for

For me the position isn't being saved when I quit, regardless of whether I save the buffer or not. The only way I've found to make it work is by toggling the Harpoon list again (leader + h), selecting the same file from the list that's already open, and then quitting. Doing this saves the current position, allowing me to jump back to it when quitting Nvim and reopening the file via Harpoon. All other solutions don't work including AutoCmd suggested by @maxrzaw. BTW, I'm on the latest commit.

Latest commit of which branch? I was using latest on harpoon2 with additional changes from this branch. https://github.com/maxrzaw/harpoon/tree/sync-cursor to be exact.

harpoon2

I have done a lot of work on getting cursors to save constantly. The latest update does a distributed file style based on settings key, this allows saving upon every change
I would first make sure the latest harpoon2 still has the issue you're looking for

For me the position isn't being saved when I quit, regardless of whether I save the buffer or not. The only way I've found to make it work is by toggling the Harpoon list again (leader + h), selecting the same file from the list that's already open, and then quitting. Doing this saves the current position, allowing me to jump back to it when quitting Nvim and reopening the file via Harpoon. All other solutions don't work including AutoCmd suggested by @maxrzaw. BTW, I'm on the latest commit.

Latest commit of which branch? I was using latest on harpoon2 with additional changes from this branch. https://github.com/maxrzaw/harpoon/tree/sync-cursor to be exact.

harpoon2

On branch harpoon2
Your branch is up to date with 'origin/harpoon2'.
nothing to commit, working tree clean


[glyphs] Generate tuples instead of bincode

This removes the need to deserialize bincode in order to load the data. Ideally we could just generate the types directly but my various (extensive) attempts to do that kept running into extremely slow compile times; this is a compromise.

Per f2f we landed #1066


Draft: PAPP-18386: SymantecCas: To Py3

What's expected:

Used 2to3 script to convert this app to Py3.
Ensure the app can be compiled and installed. Should be able to build Tar file and Compile&Install remotely.
Update Copyright. (Used mongoDB copyright as reference - https://cd.splunkdev.com/phantom-apps/phmongodb/-/blob/next/mongodb_connector.py#L4). Ensure main files have Copyright info.

Test

[ ] PyTest is passing on 4.10
[ ] PyTest is passing on 4.9
[ ] Latest asset is working (i.e. Test connectivity is passing)

Closing as stale since ticket is closed


fix: resolve next js build time environment variables from .env.local

This is related to #388 and I think also fixes #535.
The issue with next js build not having the environment variables is caused by how next js looks up environment variables. It requires a .env.local to be present, which is not present in the docker build step. The reason is that it's included in the .dockerignore, so the context doesn't have a .env.local.
This change creates an explicit .env.local created for the next build (under npm run build).
It uses docker secrets to make sure none of the other secrets leak into the cached images.

Does not resolve 535.


Including language around UDR support for V2 SKU

The question around "why doesn't V2 sku support UDR" has been asked more than one time at the partner level, in discussions with Microsoft.  Each time someone references this document, and someone from PM states it's on a backlog.  We can't really depend on that statement here.  The effort is to clarify for folks that UDRs are not supported at General Availability, which hopefully leads one to believe that it is possible the support will show up post-GA, and instead ask the question of when.  Rather than reading the statement as finite, that it is not supported and no one is working on bringing it to v2 SKU.  The note below it states why using UDRs is not a good practice if you want back-end health, logs, and metrics, but people will do what the system allows, at their level of risk acceptance.
This also makes the statement that if you require UDR you shouldn't move to v2 (with the expectation that support will show up any time soon).  That you should continue with v1.  This would be the correct "practice" for customers until public committments of support are made by Microsoft.

@johnwildes : Thanks for your contribution! The author, @vhorne, has been notified to review your proposed change.

@johnwildes One more small change and then we can merge.

@johnwildes : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


🐛  Update README.md

Fix broken link to BasicTutorial

I fixed it yet another time. I hope you don't ind i pushed straight to your branch

No worries, and thanks for re-fixing. Feel free to merge when you're happy.


Update snapps.mdx

Add Universal Oracles to potential use cases and link evan's post

Website is no longer in this repo. Closing.


Security sprint: Update content that features the ROPC Flow

This PR updates content that features the ROPC flow and related issues identified in the MSAL.NET docset.
Cc: @SHERMANOUKO @CelesteDG

@localden Not related to the updates in this PR, but I see a couple of broken links from the Link Checker run results summary, which I'll go ahead and fix.
A quick look shows that they're stemming from a recently archived sample - https://github.com/Azure-Samples/active-directory-dotnet-v1-to-v2. I'd prefere not pointing to an archived repo, but I don't see a more recent sample that demos migration from ADAL to MSAL.


Could you add juCi++?

This is juCi++: https://gitlab.com/cppit/jucipp
It supports MSYS2 but I don't know why MSYS2 doesn't already have a package for it:
https://gitlab.com/cppit/jucipp/-/blob/master/docs/install.md#windows-with-msys2-httpsmsys2githubio

An attempt was already started, but no success yet.
See: https://github.com/brechtsanders/winlibs_recipes/blob/main/recipes_work_in_progress/jucipp.winlib


Move the check in transaction::check::sapling_balances_match to V4 deserialization

Motivation

The sapling::ShieldedData type structurally validates the value_balance consensus rule. Therefore, the transaction::check::sapling_balances_match function is redundant for serialization.
But we still need to do the check during deserialization.
Solution

Remove the redundant transaction::check::sapling_balances_match function, and add extra documentation to the sapling::ShieldedData::value_balance field to link to the consensus rule and describe how it is structurally validated. This solution was described in #1980.

[ ] during V4 sapling deserialization, return an error if ShieldedData is None, and the value balance is non-zero

copy the consensus rule into that function?

[ ] create a byte test vector with a non-zero value_balance, but no spends or outputs

The code in this pull request has:

[x] Documentation Comments
[ ] Unit Tests and Property Tests

Review

@teor2345 outlined the solution.
Related Issues

Part of #1980.
Follow Up Work

We'll also need a test here, because we missed this check during a previous refactor:

create a byte test vector with a non-zero value_balance, but no spends or outputs


"or" is not supported in FHIRPath .where() function in STU3

Describe the bug
Unable to use an 'OR' condition within the where function in DSTU3 whereas the same operation works for R4.
To Reproduce
Steps to reproduce the behavior:

Set up the system with DSTU3
Add a SearchParameter similar to the below-
{
"resourceType":"SearchParameter",
"id":"patient-phoneUnformatted",
"title":"Phone number without formatting",
"url":"hssc-smilecdr-d.clemson.edu:28000/SearchParameter/phoneUnformatted",
"name":"phoneUnformatted",
"status":"active",
"code":"phoneUnformtted",
"base":["Patient"],
"type":"token",
"description":"Phone number without any formatting",
"expression":"Patient.telecom.where(system='phone' and (use='home' or use='mobile')).value.select(replaceMatches('[^0-9]+',''))",
"xpathUsage":"normal"
}
The error returned:

"HAPI-1119: The expression "Patient.telecom.where(use='home'" can not be evaluated and may be invalid: HAPI-0607: org.hl7.fhir.dstu3.utils.FHIRLexer$FHIRLexerException: Error at 1, 1: The token null is not expected here - either a "," or a ")" expected"
Note: If we change it to just be an 'and' as follows, it creates the SearchParameter successfully. Also, working fine with the R4 version.
"expression":"Patient.telecom.where(use='home' and use='mobile').value.select(replaceMatches('[^0-9]+',''))",
Expected behavior
The 'OR' expression should help create the SearchParameter successfully.
Screenshots

Environment (please complete the following information):

HAPI FHIR Version [ HAPI FHIR // 6.0.0-PRE3-SNAPSHOT / build c9b87d7c67 2022-02-25]
Browser  [chrome]

Additional context
Add any other context about the problem here.

@dotasek


Add a minimal example using validators and Errors

One thing I wanted to do in here but did not was add an error class to the input element, it seems that this isn't really straightforward without implementing a custom component and field class wrapper since the Control is responsible for re-rendering the input and it doesn't really seem very extensible through other means.
Along the way I also noticed that the Errors documentation had an incorrect code example and I made a corresponding comment in the gitbook https://davidkpiano.gitbooks.io/react-redux-form/content/errors_component.html

Thanks, corrected the gitbook!


Refresh of documentation

Fixed a spelling mistake or two
Rewrote some sentences in more natural English

Thank you very much @gerryhocks!

So sorry that I totally forgot to merge this...

No trouble! It is easy to lose track of repositories :)


Add SHADO from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of LuizChacon, to add SHADO to CKAN.
Please direct questions about this pull request to LuizChacon.

Closing/adding to #1860


Cert naming

Thank you for your simple client.
I helped me how the acme protocol works.
Would it be possible to provide templates for cert names? %s-public.pem
https://github.com/veeti/manuale/blob/master/manuale/issue.py#L78-L81

I think the simple solution is to rename them afterwards.

Sorry, not entirely sure what you mean. Do you mean changing the output filenames from the command line, or something else?

Do you mean changing the output filenames

Yes. I mean it.

I'm not against the idea. What sort of switch would you like in particular? Can you give me an example?

--chain-template "combined-%s.pem" --certificate-template "pub-key-%s.pem" --intermediate-template "intermediate-%s.crt" --privatekey-template "priv-key-%s.key"

Meanwhile I've get used to your naming :)


C- BASIC SYNTAX [Documenatation]

Description
Basic syntax of a C program.
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign

/assign


Added Spry Fox Networks to Maintainers

What type of PR is this?
Add one of the following kinds:

documentation

What this PR does / why we need it:

Added Spry Fox Networks to the Maintainers list.

Which issue(s) this PR fixes:

@sfnuser totally supportive, especially looking on your track record of contributions here in the project.
Can you confirm that this is a personal account? Maintainers should be persons, not companies.
I will ask for short confirmation by the current maintainers on our call on Friday.

@sfnuser totally supportive, especially looking on your track record of contributions here in the project. Can you confirm that this is a personal account? Maintainers should be persons, not companies.

@hdamker Thanks. Yes, it is my personal account.

Sorry, I missed this point in the call. Dear fellow current maintainers, can you shortly show with your approval your support of @sfnuser?
@emil-cheung, @SylMOREL (or @patrice-conil instead), @jlurien (or @jpengar), @eric-murray, @SyeddR (or @maheshc01), @ToshiWakayama-KDDI


Create New Member not working in v3

Gibbon (v3 branch) is working for me for viewing lists:
      mailchimp_list = gibbon.lists("8459999c08").members.retrieve

but not for creating a new member of the list:
      gibbon.lists("8459999c08").members.create(body: {email_address: "email_address", status: "subscribed", merge_fields: {FNAME: "First Name", LNAME: "Last Name"}})

It is giving me a 400 error:
     Gibbon::MailChimpError (the server responded with status 400):
     app/controllers/orders_controller.rb:152:in `payment'

Any ideas?

Hmm, that looks correct. Is there any more detail to the error? I'll take a look tonight.

Okay, I gave it a shot and it worked fine for me:
g.lists(my_list_id).members.create(body: {email_address<EMAIL_ADDRESS>status: "subscribed", merge_fields: {FNAME: "First Name", LNAME: "Last Name"}})

One note is if the email is already registered, the API will return an error. In that case you need to call update instead of create. To troubleshoot this in the future, rescue Gibbon::MailChimpError when you make a call. Then examine it's title, detail, and body attributes. You'll see what the API is returning.
I'm guessing the email is already registered.

Example output:
{"type"=>"http://kb.mailchimp.com/api/error-docs/400-invalid-resource", "title"=>"Invalid Resource", "status"=>400<EMAIL_ADDRESS>is already a list member.  Use PATCH to update existing members.", "instance"=>"f806a7ca-00bc-4e67-901c-e02acdbb6eae"}

For anyone who comes along later, I also ran into this. The error JSON was:
{
  "type": "http://kb.mailchimp.com/api/error-docs/400-invalid-resource",
  "title": "Invalid Resource",
  "status": 400,
  "detail": " is already a list member.  Use PATCH to update existing members.",
  "instance": "<UUID HERE>"
}

Notice how there is no email address listed. <blank> is already a list member.
I dug into it it turned out that MailChimp doesn't like @example.com addresses and gives this error if you try to use one. I suppose that makes sense... but I would prefer<EMAIL_ADDRESS>is not a valid email address." or similar :)


PA sometimes broken Again.

Description
On some round starts the port and starboard emitters are not detectable and require admin respawning the whole PA to get them to sync on the console.
Reproduction
Is hard reproduction as I am just seeing this every so often in aHelps:
But the screenshot illustrates the broken state. Its all wired and screwed down correctly, just cant sync those last two, even if they are independently respawned just the emitters.
Screenshots

Additional context
This was an issue about 2-3 months ago now but it looked like it was resolved. Unsure it its map specific or corner case regression bug. This was on bagel map.

Just tested and it works, assuming fixed.


Add partner group to organization. Add new partner for seed

Resolves #4679
Description

Add to the seed a partner group, "Group 2", that has all the item categories in "Pawnee Diaper Bank" organization
Add a new partner "Second Street Community Outreach"

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested this by following these setps:

Login as<EMAIL_ADDRESS>Go to Inventory > Items and Inventory
Go to the item categories tab and check if all 3 categories of the organization exists

Tested the creation of partner by logging in and checking if it exists in all partners

Screenshots

@cielf , added the details to CONTRIBUTING.md as well


[Feat]: Add privacy policy page

Is your feature request related to a problem? Please describe.
Add privacy policy page with required clauses which are not hard to understand for the users.
With proper formatting and updated looks.
Describe the solution you'd like.
Add privacy policy
Additional context.
Kindly assign this issue to me.
Show us the magic with screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

issue is already resolved.


Implement MLP

Use the provided training set to train an MLP with one hidden layer. Apply the trained MLP
to classify the test set. Perform cross-validation with the following parameters:

Optimize number of neurons in the hidden layer (typically in the range [10,100]).
Optimize learning rates (typically in the range [0.1,1])
Optimize number of training iterations. Plot a graph showing the error on the training
set and the validation set, respectively, with respect to the training epochs.
Perform the random initialization several times and choose the best network during cross-
validation.

https://pypi.python.org/pypi/bob.learn.mlp

Use MLP implementation of scikit-learn:
https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/neural_network/multilayer_perceptron.py

Alternative: https://pypi.python.org/pypi/scikit-neuralnetwork

Done with 2f010ff173e2abc25fe4d28ff4e21b1c645e474e


Highlight all errors in VBA flow - Personal information and Additional information steps

Details
Changes:

isValidIdentity became validateIdentity, which returns an object with the errors.
Show all highlighted errors together in Personal information Step (/bank-account/personal-information)
Show all highlighted errors together in Additional information Step (/bank-account/contract)
Updated errors in reimbursementAccountPropTypes to accommodate beneficial owners errors in "Additional information Step (/bank-account/contract)"

Fixed Issues
$ https://github.com/Expensify/App/issues/4785
We are working in this issue step by step. This PR updates the error handling specifically for the company information step in the VBA flow.
Tests AND QA Steps
Setup

Create account and verify it
Login in NewDot, create workspace and start the flow to add VBA
Do the first step "Add bank account" using any option (Log into your bank / Connect manually). Use data from step (2) or (3) of this SO.
Fill Company Step form with the available information from the SO, missing fields can be filled with anything that passes validations, then, click "Save & Continue"
You should be in the "Personal Information" step (/bank-account/personal-information)

Personal Information Step

Click "Save & continue" before filling anything, all fields are mandatory and all of them should have inline errors:

Start filling the different fields. Each field's inline errors should disappear as soon as they are changed. Use Alberta as first name and Charleson as last name.

Choose as "Date of birth" a recent date, example:2021-10-10

Click "Save & continue". The "Date of birth" should have the error "Requestors must be over 18 years old"

Choose as "Date of birth" a date older than 18 years, example: 2000-10-10

Click "Save & continue". If all fields pass the validation, we should get to the "Additional information" step (/bank-account/contract)

Additional information Step (beneficial owners)

Click "Save & continue", you should see the following errors:

Clicking any of the mandatory checkbox should remove the inline error of the clicked checkbox.

Check the checkbox next to "Somebody else owns more than 25%..."

Click the link below the new form with the text "Add another individual who owns..."

You should have two nested forms asking for information on the "Additional beneficial owner":

Scroll down and click "Save & continue", all mandatory fields should have inline errors:

Filling information on fields should clear the inline errors on them. Verify that filling a field in one "Additional beneficial owner" removes only the error for that nested form and not for any other "Additional beneficial owner" form.

Fill all mandatory fields with valid information and click "Save & continue".

We should be on the next step: Validate

Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Pending:

Update ACHContract step
Date of birth field has two different validations which end up in two different errors. With the newer way of handling errors, how do we handle this case?

https://github.com/Expensify/App/blob/0f4abe1b5e7dab43db892e13bd943102fdc3e618/src/libs/ValidationUtils.js#L103-L113
Maybe the errors object should have the translated error message instead of true as value. For example:
errors.dob = translateLocal('bankAccount.error.age');

@marcaaron , before continuing further, can I have your thoughts on this:

Store string values in reimbursementAccount.errors instead of booleans. Why? because that would add support for fields that can have more than one error message. If you look at the ValidationUtils.js here, dob has two possible different errors

Store string values in reimbursementAccount.errors instead of booleans. Why? because that would add support for fields that can have more than one error message. If you look at the ValidationUtils.js here, dob has two possible different errors

That feels kind of like we are moving backwards and will have to change a lot to make it all consistent. It might be something we could consider for the design doc we are planning, but not something I'd probably not implement in this PR.
Rather than store the error text could we have the input handle multiple error keys somehow?

Rather than store the error text could we have the input handle multiple error keys somehow?

Yes, I would say is possible without too much effort and uglyness, it is just one field that has this problem.
I'll change them to boolean again and handle dob errors with different keys.

The error for missing State uses two lines, taking up too much space:

I think we should use a shorter text

Nice catch, since the feature is not being broadly promoted yet, I maybe would suggest creating a new issue for this and continuing to focus on solving the multiple errors issue.

Is there a reason we don't require First name, Last name and Personal address for additional beneficial owners? Those feel like important fields to me.

Is there a reason we don't require First name, Last name and Personal address for additional beneficial owners? Those feel like important fields to me.

Had this same doubt while testing, I would have to ask someone that knows more about the process.

@flodnv 's PR removed the error message "Requestors must be over 18 years old"
I'm introducing it again because of this slack comment, but changing the "requestor" wording.

Testing now and everything looks good except "First name" "Last name" and "Personal address" fields on the beneficial owners step look to be not required when a form is submitted without any info?
I'm not sure that's right. I think we need this information? But it would be good to have someone from ops verify.

I think we should just go ahead and add a isRequiredFulfilled for each of those checks since I can't think of why they would not be required. 🤔

Another weird thing is that even though I've entered no date of birth I see this:

Which implies that a valid date has been entered in the first place.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Another weird thing is that even though I've entered no date of birth I see this:

Which implies that a valid date has been entered in the first place.

I'll look into it

Testing now and everything looks good except "First name" "Last name" and "Personal address" fields on the beneficial owners step look to be not required when a form is submitted without any info?
I'm not sure that's right. I think we need this information? But it would be good to have someone from ops verify.

Asked in #ops, Katie also thinks this should be required information.
https://expensify.slack.com/archives/C6PHQ660K/p1633368748485700?thread_ts=1633368702.484800&cid=C6PHQ660K

🚀 Deployed to staging by @marcaaron in version: 1.1.4-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Support for existing encryption keys referenced by CRN

Description
Enable support for using an existing key referenced by CRN in the override.json (key_management.keys element).
This will allow to use a cross-account KeyProtect / HPCS Instances where there may be no full visibility to the KMS instance, but the keys are available by CRN.

If a CRN of a key is provided, no KMS instance should be required to look up the key, the key CRN is just included in the key map to be used in other modules referencing it by name
The landing zone should support a scenario where no KMS instance is supplied but a set of existing keys with CRNs is provided in override.json (key_management.keys element)
The landing zone should support a mixed scenario where some keys are supposed to be created while some are provided with CRNs.

New or affected modules

kms/variables.tf - add crn attributes as optional(string) to the variable schema
kms/outputs.tf - key_map should be a union of keys created with references of existing keys that CRNs were provided for
kms/dynamic_values/main.tf - key_management_keys, key_rings, and key_management_key_policies should only include items for which keys would be actually created. Key items with existing CRNs are omitted from those lists.

By submitting this issue, you agree to follow our Code of Conduct

@in-1911 ,
When a kms instance is not provided slz goes ahead and creates the kms instance as it is required by the cluster as we need to attach a Key Protect instance to the cluster.
https://registry.terraform.io/providers/JonWoodlief/ibm/latest/docs/resources/container_vpc_cluster#create-a-kms-enabled-kubernetes-cluster
So, I think its not possible to not pass a kms instance, but we can use existing kms instance or create a new one.
I can go ahead and implement the feature of using existing key crn.

@in-1911 Looking at the api (https://cloud.ibm.com/apidocs/kubernetes/containers-v1-v2#createkmsconfig) it shows required for instanceID and crkID, however it does support passing accountID which is supposed to be used if the KMS instance is in another account. We have created an enhancement request with the IBM terraform provider to see if they will add support to pass an account ID for this use case -> https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4745

@in-1911 In order to encrypt the cluster using a KMS key from a different account, a cross account auth policy would need to be created. Is this something you feel SLZ should create too when we add cross account encryption support. I'm guessing yes since it currently supports creating all the local auth policies?

I do not think the cross account access policy would be created via SLZ. It needs to be done in a different account and probably by a different team. I.e. when a "business unit" deploys a landing zone in a sub-account, the Service Hub admins will need to grant access to the central KMS. For other services (like COS) the Hub admins would also need to create the keys and pass the CRNs to the "business unit" team.
I am completely fine if the cross-account grant or key creation in Service Hub is a prerequisite to deploying Landing Zone with central KMS instance.

Yes good point, the auth policy creation would have to be done in the account where the KMS instance exists. So this will have to be a prerequisite that we can document.
I'll work with @Aashiq-J and team internally to design a solution here.

@in-1911 Wanted to give you a quick update on our findings...
Currently the IBM provider does not support passing an account ID in the cluster encryption block. It only supports:
  kms_config {
      instance_id = "12043812-757f-4e1e-8436-6af3245e6a69"
      crk_id = "0792853c-b9f9-4b35-9d9e-ffceab51d3c1"
      private_endpoint = false
  }

We are going to create an enhancement request with the provider on this.
The provider does however support passing an account ID for the encryption of the worker nodes boot volumes:

However, SLZ actually doesn't currently have support in the code to encrypt the boot volumes. This is something we are not going to add.
While we wait for provider support to pass an account ID for cluster encryption, we are going to add support to the override.json for VSI and VPC to use a root key crn from a different account. Once implemented, I will share the details on how to consume with you.

PR under review for this https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/pull/542/files

@ocofaigh @Aashiq-J - sorry for a bit of mix-up, I did not notice a new PR by @Aashiq-J and went ahead with my own, although taking some pointers from @Aashiq-J work. I think I did resolve a couple of additional issues in my code as well, so a review of #553 would be appreciated.

Hi @in-1911 ,
We have decided to go ahead with this approach(https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/pull/547).
Appreciate you for your PR, but its missing a lot of components, which are addressed in  this PR
Could you please list the issues you found in this PR, so that we can address it.
Thanks.

@Aashiq-J - no problem with going ahead with #547 , but you might take a few points from mine (#553) to address some of the minor issues:

The condition for S2S authorization needs to use something directly related to inputs, otherwise TF complains about the count condition in some scenarios - I set local.target_key_management_service  to null in (dynamic_values/config_modules/service_authorizations/service_authorizations.tf) if no KMS name is provided   [see here](https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/pull/553/files#diff-21b57eb683b6b06d1bbf54b6717d14ae1c079439bc60efa7dcab3c7802dfefee). Then you checklocal.target_key_management_service` instead of the KMS guid in the counts for s2s authorizations.
The KMS dynamic values unit tests do not need to be disabled, but you need to pass the name attributes when a "resource" test is done - see here
I added some notes on the key parameters and the KMS instance logic in the README
I did not include that, but if you are changing the cos module, use the kms_key_crn parameter instead of key_protect (see note above the example)

The rest of my changes are pretty much identical to yours

Status: The PR is under internal team review.

PR merged. Feature available in latest release.
https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/releases/tag/v4.9.0


Prevent XSS on Account Conversion Page

Critical Changes
Changes

Security Issues addressed on Account Conversion page.

Issues Closed
New Metadata
Deleted Metadata

@seanpat09 - Oops, not sure how I missed those! Thanks, I will fix that up now.

@rponti-sforg - This is ready for testing when you are. Thanks!


Add support for JSDoc-style markup

I wanted to flag a feature request here - it would be nice to have support for parsing JSDoc-style commenting. Such that this project could support doc generation from source code markup like this:
/**
 Returns a shiny new object.

 @param name The name of the object.
 @param options The options for the object.
 @return An initialized new shiny object.
 */

Where currently I can only markup source code like this:
/**
Returns a shiny new object.

- Parameters:
  - name: The name of the object.
  - options: The options for the object.
- Returns: An initialized new shiny object.
*/

Other than that I'm really satisfied with this library so far, thanks so much!

Hi @captainbarbosa! Thank you for your request.
Unfortunately, neither Xcode nor Swift compiler support JSDoc documentation, which are used to build and extract documentation from the code.
Thank you,
Eneko


Remove all related to arrangement versions

Cleanup for tekton

CLOUDBLD-6299

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[n/a] JSON/YAML configuration changes are updated in the relevant schema
[n/a] Changes to metadata also update the documentation for the metadata
[n/a] Pull request has a link to an osbs-docs PR for user documentation updates

There are some more occurrences in docs, make_mock_json.py and tests. Not sure which can be removed already and which are blocked by removing the inner templates

There are some more occurrences in docs, make_mock_json.py and tests. Not sure which can be removed already and which are blocked by removing the inner templates

removed also from make_mock
leaving it in test_api (to get correct inner files), test_arrangements (to test plugins order)

rn updated


Investigate Changing dates by keyboard

Sometimes the input is not recognized as a valid date.
If the value is then set by clicking on the input, the edit button keeps being disabled.

The first problem is probably related to Locale problems.

This is an angular material issue with the date adapter and needs to be fixed on the implementing side by configuring the material-moment-adapter:
https://github.com/angular/components/issues/14291


[FEATURE] Create Transport API for clusterService required for creating AD detector

Is your feature request related to a problem?
IndexAnomalyDetectorTransportAction requiresaddSettingsUpdateConsumer from clusterService.getClusterSettings() that adds a settings consumer that accepts the values for two settings.
What solution would you like?
A clear and concise description of what you want to happen.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

For the initial phase of creating the detector as we are not taking Security in place. Keeping the work on hold and the initial draft PR for OpenSearch is here and for SDK is here.

We have the support now for addSettingsUpdateConsumer now. Closing this issue.


Proposed 1.1.0-b4

Jenkins Build Summary
Built from this commit
Built at 20180625 - 22:32:10
Test Results

Build Type
Log
Result
Status

rpm
logfile
1034 cases, 0 failed, t: n/a
PASS :white_check_mark:

msvc.debug
logfile
1032 cases, 0 failed, t: 565s
PASS :white_check_mark:

coverage
logfile
1035 cases, 0 failed, t: 685s
PASS :white_check_mark:

docs
logfile
1 cases, 0 failed, t: 2s
PASS :white_check_mark:

msvc.debug, PROJECT_NAME=rippled_classic
logfile
1032 cases, 0 failed, t: 1236s
PASS :white_check_mark:

gcc.release.unity -Dassert=true, MANUAL_TESTS=true
logfile
1101 cases, 0 failed, t: 804s
PASS :white_check_mark:

clang.debug.unity
logfile
1035 cases, 0 failed, t: 251s
PASS :white_check_mark:

clang.debug.unity, PARALLEL_TESTS=false
logfile
1035 cases, 0 failed, t: 494s
PASS :white_check_mark:

msvc.release
logfile
1031 cases, 0 failed, t: 515s
PASS :white_check_mark:

gcc.debug.unity
logfile
1035 cases, 0 failed, t: 246s
PASS :white_check_mark:

clang.debug.nounity
logfile
1033 cases, 0 failed, t: 703s
PASS :white_check_mark:

clang.release.unity -Dassert=true
logfile
1034 cases, 0 failed, t: 336s
PASS :white_check_mark:

gcc.debug.nounity
logfile
1033 cases, 0 failed, t: 699s
PASS :white_check_mark:

gcc.release.unity -Dassert=true
logfile
1034 cases, 0 failed, t: 355s
PASS :white_check_mark:

gcc.debug.unity -Dstatic=true
logfile
1035 cases, 0 failed, t: 247s
PASS :white_check_mark:

Codecov Report

Merging #2605 into develop will increase coverage by 0.02%.
The diff coverage is 78.06%.

@@             Coverage Diff             @@
##           develop    #2605      +/-   ##
===========================================
+ Coverage     70.8%   70.82%   +0.02%
===========================================
  Files          697      698       +1
  Lines        54506    54367     -139
===========================================
- Hits         38591    38506      -85
+ Misses       15915    15861      -54

Impacted Files
Coverage Δ

src/ripple/nodestore/impl/ManagerImp.cpp
81.39% <ø> (-1.59%)
:arrow_down:

src/ripple/overlay/impl/ConnectAttempt.h
0% <ø> (ø)
:arrow_up:

src/ripple/beast/utility/src/beast_Journal.cpp
54.54% <ø> (-1.6%)
:arrow_down:

src/ripple/ledger/detail/ReadViewFwdRange.h
100% <ø> (ø)
:arrow_up:

src/ripple/json/impl/json_valueiterator.cpp
49.18% <ø> (-0.06%)
:arrow_down:

src/ripple/peerfinder/impl/SlotImp.cpp
50% <ø> (-2.39%)
:arrow_down:

src/ripple/overlay/Message.h
3.57% <ø> (ø)
:arrow_up:

src/ripple/ledger/View.h
100% <ø> (ø)
:arrow_up:

src/ripple/overlay/impl/PeerSet.cpp
63.15% <ø> (-1.25%)
:arrow_down:

src/ripple/protocol/impl/PublicKey.cpp
88.18% <ø> (ø)
:arrow_up:

... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ab98c...aa2fce4. Read the comment docs.


Delete .github/ISSUE_TEMPLATE/bug_report.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update azure-stack-install-visual-studio.md

"Cloud Explorer" should be under "View" menu instead of Edit.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@xiaofmao : Thanks for your contribution to the Azure documentation! The author, @heathl17, has been notified to review your proposed change.

#sign-off


UPDATES motion-ui instructions in generated 'foundation_and_overrides scss'  file

Instructions that are in the readme added to the generated foundations_and_overrides file.

:+1:


android carsh

Hi @lihuayu315 this is the only case of this I've heard about. Could you try the same code with just a plain <FlatList /> (or <ListView />) and see if you can isolate the issue. Also posting the error you're seeing would help a lot

Closing as inactive, please reopen if you still have issues


Merge in working travis-ci code & coverage reporting.

Current coverage is 100.00%

Branch #2 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


Display versioning relationships on the public page for private resources

The discover page is being changed to shows the most recent published/public or discoverable resource (per #4015 ).  Versioning in HydroShare is implemented using relationships

isVersionOf to indicate that a resource is a newer version of a previous resource
isReplacedBy to indicated that a resource has been replaced or superseded by another resource

These do not address access control.  Thus it is possible to have

A published resource replaced by a resource that is still private.  In this case Discover will find the published resource.  This is the desired behavior.
A published resource (lets say resource A) replaced by a resource that is private (say resource B), which itself is replaced by a resource that is Discoverable/Public/Published (say resource C).  Resource C will indicate that it has resource B as a prior version. But as resource B is private, users are unable to access it, to see that it has a prior version (resource A).

To allow users to “discover”, i.e. get back to resource A which is published, the chain from resource C to resource A needs to be open.  I thus suggest that even for private resources that versioning relationships be presented on the resource landing page.  This is a small policy change, in addition to implementation change.  It makes versioning information for private resources no longer private.
Illustration
Current page for a resource that is private where the user does not have access

Proposed change

Related https://github.com/hydroshare/hydroshare/issues/4015 (obsoleted resources)

Related https://github.com/hydroshare/hydroshare/issues/4015 (obsoleted resources)

@alvacouch please review and is this part of a current fix

Addressed via backend changes in pending PR.


Material-UI: The value provided to useAutocomplete is invalid.None of the options match with  You can use the getOptionSelected prop to customize the equality test.

i have the same warning but i already added getOptionSelected, it make infinity console warning
Material-UI: The value provided to useAutocomplete is invalid.
None of the options match with `{"id":"geonames:6429478","name":"Périgueux"}`.
You can use the `getOptionSelected` prop to customize the equality test.

the code:

  let {
    getRootProps,
    getInputLabelProps,
    getInputProps,
    getListboxProps,
    getOptionProps,
    groupedOptions,
    getOptionSelected,
    focused,
    setAnchorEl,
    anchorEl,
    inputValue
  } = useAutocomplete({
    value: selectedOption || {},
    options: options,
    getOptionLabel: (option) => {
      return option.name || "";
    },
    getOptionSelected: (option, value) =>{
       console.log({value,option});
       // I added id comparaison because in option.name accent char are replaced ( éàè....)
        return  option?.name.toLowerCase() === value?.name.toLowerCase() || option?.id === value?.id
    },
    selectOnFocus: true
  });

the log from getOptionSelected :
option: {
  id: "geonames:6616167",name: "Mareuil en Perigord"
}
value: {
  id: "geonames:6616167",
  name: "Mareuil en Périgord"
}

Any idea please ?

Looking into possible solutions in #21985, I've gone the route of adding the interfaces manually until it's fully supported in the library.

Hi @alainib,
I'm having the same issue. Did you manage to solve this? Thanks :)

Hi @alainib,
I'm having the same issue. Did you manage to solve this? Thanks :)

try with this :
let {
    getRootProps,
    getInputLabelProps,
    getInputProps,
    getListboxProps,
    getOptionProps,
    groupedOptions,
    getOptionSelected,
    focused,
    setAnchorEl,
    anchorEl,
    inputValue
  } = useAutocomplete({
    value: selectedOption || {},
    options: options,
    getOptionLabel: (option) => {
      return option.name || "";
    },
    getOptionSelected: (option, value) => {
      return option?.id === value?.id || option?.name.toLowerCase() === value?.name.toLowerCase();
    },
    selectOnFocus: true
  });


Updates to Identity reference archtectures

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/identity/adds-extend-domain.md
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/adds-forest.md
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/ad-forest-trust.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-extend-domain.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-extend-domain.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-forest.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-forest.svg
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/identity/adds-extend-domain.md
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/adds-forest.md
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/ad-forest-trust.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-extend-domain.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-extend-domain.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-forest.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-forest.svg
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/identity/adds-extend-domain.md
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/adds-forest.md
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/ad-forest-trust.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-extend-domain.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-extend-domain.svg
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-forest.png
:white_check_mark:Succeeded
View

docs/reference-architectures/identity/images/adds-forest.svg
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Removed the unnecessary method codeGenerator

The method codeGenerator was not needed as the class CodeGenerator has more functionalities. The test suite has been run as well and all the desired tests are passing

Cool, sounds good that the tests passed and no breakage was observed. LGTM


Nylas starting but not showing on macOS

Nylas is starting, but not showing up on macOS 10.12.3.
It has been working fine for about a week. I've recently installed a Nylas update, but I'm not sure if that's related.
I tried reinstalling from the .dmg download at Nylas.com, but to no avail.
Are there any related issues?
It's the exact same as #2778, but on macOS.
What operating system are you using?
macOS 10.12.3
What version of Nylas Mail are you using?
1.0.48
Do you have any third-party plugins installed? If so, which ones?
None.
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
No.
Is the issue reproducible with a particular attachment, message, signature, etc?
The app simply won't open.

I think macOS has corrupted a Nylas db file when macOS crashed earlier today. When I start Nylas, I get the following output in Console:
Mar 30 18:57:44 M84803 Nylas Mail[1280]: Streaming log data to /var/folders/96/yzxs4d0n2f9gzs7bv243qqmh0000gp/T/Nylas-Mail-1280.log
Mar 30 18:57:44 M84803 Nylas Mail[1280]: App load time: 336ms
Mar 30 18:57:44 M84803 Nylas Mail[1280]: Error: SQLite: database disk image is malformed
	    at Error (native)
	    at Database.db.on (/src/database-helpers.es6:12:10)
	    at emitNone (events.js:86:13)
	    at Database.emit (events.js:185:7) {}
...

Removing ~/.nylas-mail solved the issue, although I've lost all configuration in the process.

Same issue here.

I had this same problem. I also had to remove ~/.nylas-mail

Also have this issue, don't want to lose my configuration so I'm going to wait for a fix.

Seems to be a common problem on my Mac right now.

was waiting for a fix for some time; then gave up and deleted ~/.nylas-mail and reconfigured

Same issue here as well. OSX 10.12.4 crashed in its sleep and the DB is corrupt.

Ditto, same thing here. Had to nuke ~/.nylas-mail - luckily I only have two accounts to reconfigure...

Same. Not super excited about leaving my laptop on for 3 days to sync 17G of emails. Nylas needing to sync all your email is rough to begin with, but if it has to do that again when it crashes? Gonna lose users.

Thanks for the report everyone! We're going to look into this!

Hi, is this the reason why,  I installed this a couple of hours ago on Windows 10, but my .sqlite files keep hammering the disk?
I have 4 accounts, the .sqlite files keep growing...
http://pasteboard.co/4dvL5q2yl.png
If this is synchronizing all mail that is just wrong. Several mail clients give you the option to do this for the last 2 weeks, 1 month, 3 months, a year, etc... even windows mail app (which is crap).
Should I be worried about the ever growing .sqlite files and disk usage?

Same behavior.
Tried downgrading as well since I thought it was the upgrade from ver 1.x.x to 2.x.x upgrade that caused the problem. Nothing.
Deleted ~/.nylas-mail and Im up and running again.

Hi all! These issues should be fixed in version 2.0.15 (it should correctly inform you that the database is corrupted and rebuild it).
Let me know if you continue having issues!

Got it on the last version
2017-04-19 08:42:31.411 Nylas Mail[814:18675] Streaming log data to /var/folders/d_/21j44nrx6v5ctgs7v_8xpx8r0000gp/T/Nylas-Mail-814.log
2017-04-19 08:42:31.594 Nylas Mail[814:18675] App load time: 326ms
2017-04-19 08:42:31.624 Nylas Mail[814:18675] Error: SQLite: database disk image is malformed
at Error (native)
at Database. (/src/database-helpers.es6:39:12)
at emitNone (events.js:86:13)
at Database.emit (events.js:185:7) {}

Hi @kvacquier , are you sure this is version 2.0.15?

Yes : Version 2.0.15 (2.0.15)
Updated yesterday (after the reception of the email) and crashed this morning

Thanks! So the app doesn't start at all, correct? Do you see a dialog like this one at any point?

 But i didn't get the the pop-up last time

@jstejada: I just had this same issue with 2.0.32. Deleting edgehill.db fixed it.
Symptoms were:

App would launch, but menu bar would show only File->Quit. No windows.
Console indicated a SQLite format error.
Deleting edgehill.db in Terminal got me back to the login screen

Log Entry
Jun 29 14:14:22 Diorama Nylas Mail[31180]: Error: SQLite: database disk image is malformed
	    at Error (native)
	    at Database.<anonymous> (/src/database-helpers.es6:39:12)
	    at emitNone (events.js:86:13)
	    at Database.emit (events.js:185:7) {}

Computer Info
  Model Name:	MacBook Pro
  Model Identifier:	MacBookPro13,3
  Processor Name:	Intel Core i7
  Processor Speed:	2.6 GHz
  Number of Processors:	1
  Total Number of Cores:	4
  L2 Cache (per Core):	256 KB
  L3 Cache:	6 MB
  Memory:	16 GB

  System Version:	macOS 10.12.5 (16F73)
  Kernel Version:	Darwin 16.6.0

Can confirm I got this error on version 2.0.32 today. Deleting edgehill.db fixed it as well.

Seeing this issue with 2.0.32. I did try to delete the edgehill.db but of no use.


Disable view modes?

Whenever you click on the calendar title in the header, it takes you to the "months of the year" view mode. Is there a way to disable the ability to view other view modes or turning off the link without editing the plugin file?
My project requires people selecting dates between certain months of the current year, so it would be nice to have that link disabled, to avoid accidental clicks.

Hi, sorry for the late reply.
If you didn't find out by now, you should be able to do such setting the option maxViewMode to days:
$('#sandbox-container input').datepicker({
    maxViewMode: 'days'
});


with_terminal() example outdated?

This is under with_terminal examples:
with_terminal(dump, [1,2,[3,4]])

But it gives error
MethodError: no method matching with_terminal(::typeof(dump), ::Vector{Any}), so maybe it is outdated?

I think I fixed it by adding args... to the function. Created pull request #150