Update New-ADUser.md

Removed the add,remove/replace values as they cannot be used on new-aduser parameter

Issue#https://github.com/MicrosoftDocs/windows-powershell-docs/issues/2014

Docs Build status updates of commit 3dcc7f7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@dariomws @get-itips @tseward
Peer review needed for this PR. Thanks.

Agree that we need to not only remove but also replace with the current accepted syntax

I think we should add some detail like "Use the following syntax: ,,.... If the values contain spaces or otherwise require quotation marks, use the following syntax: "","",...""." and apply the same for -Certificates parameter.

Thank you @dariomws and @get-itips . I have added the syntax as per your suggestion. let me know if it looks good so that I can apply it on the other versions as well.
Thanks
Sri

Docs Build status updates of commit 23918f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Good to go with @tseward and @get-itips 's approval.

I think we should add some detail like "Use the following syntax: ,,.... If the values contain spaces or otherwise require quotation marks, use the following syntax: "","",...""." and apply the same for -Certificates parameter.

Thank you @dariomws and @get-itips . I have added the syntax as per your suggestion. let me know if it looks good so that I can apply it on the other versions as well.
Thanks
Sri

@msbemba the latest update is wrong, when I copied and pasted the description from the New-Mailbox article, there was a problem with the markdown format. Now I think it should be ok:
To enter multiple values, use the following syntax: <value1>,<value2>,...<valueX>. If the values contain spaces or otherwise require quotation marks, use the following syntax: "<value1>","<value2>",..."<valueX>".

I think we should add some detail like "Use the following syntax: ,,.... If the values contain spaces or otherwise require quotation marks, use the following syntax: "","",...""." and apply the same for -Certificates parameter.

Thank you @dariomws and @get-itips . I have added the syntax as per your suggestion. let me know if it looks good so that I can apply it on the other versions as well.
Thanks
Sri

@msbemba the latest update is wrong, when I copied and pasted the description from the New-Mailbox article, there was a problem with the markdown format. Now I think it should be ok:
"To enter multiple values, use the following syntax: ,,.... If the values contain spaces or otherwise require quotation marks, use the following syntax: "","",...""."

Thank you @dariomws , I have made changes as per your suggestion.

Good to go with @tseward and @get-itips approval.

Docs Build status updates of commit b81a0f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 344fbcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Current description for -Certificates in New-AdUser is wrong, it seems it was copied from AccountExpirationDate, can you please correct it? New-AdComputer has it ok.

Also, I tested  the -Certificates parameter an it is expecting an array of X509Certificate objects
$cert1 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test1.cer"
$cert2 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test2.cer"
$certs = $cert1,$cert2
New-AdUser -Certificates $certs

Please test this and change the required format accordingly.
Thanks

Thank you, Andres. The Type is already set to X509Certificate[] and we have an example (1) which shows how to use the parameter. We have added the syntax to use when there are multiple values for certificates.
I have also changed the Description for certificate parameter in new-aduser.
Thanks,
Sri
From: Andres Mariano Gorzelany<EMAIL_ADDRESS>Sent: Monday, July 20, 2020 6:51 PM
To: MicrosoftDocs/windows-powershell-docs<EMAIL_ADDRESS>Cc: Sriraman M S<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/windows-powershell-docs] Update New-ADUser.md (#2049)
Also, I tested the -Certificates parameter an it is expecting an array of X509Certificate objects
$cert1 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test1.cer"
$cert2 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test2.cer"
$certs = $cert1,$cert2
New-AdUser -Certificates $certs
Please test this and change the required format accordingly.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/windows-powershell-docs/pull/2049#issuecomment-661035230 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AK63OZHGTXY2INGPZ65VXJTR4RAD3ANCNFSM4OYF7T7Q .  https://github.com/notifications/beacon/AK63OZC3DLTDODYJVC7DDRTR4RAD3A5CNFSM4OYF7T72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE5TJRXQ.gif

Docs Build status updates of commit 80bd7a8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Thank you, Andres. The Type is already set to X509Certificate[] and we have an example (1) which shows how to use the parameter. We have added the syntax to use when there are multiple values for certificates. I have also changed the Description for certificate parameter in new-aduser. Thanks, Sri

I understand, however, Does -Certificates supports supplying more than on array of X509Certificate on a list array?
like this:
$cert1 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test1.cer"
$cert2 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test2.cer"
$certsA = $cert1,$cert2

$cert3 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test3.cer"
$cert4 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test4.cer"
$certsB = $cert1,$cert2

New-AdUser -Certificates $certsA,$certsB

Can you kindly test that?
Thanks

Docs Build status updates of commit 41acdcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Thank you, Andres. The Type is already set to X509Certificate[] and we have an example (1) which shows how to use the parameter. We have added the syntax to use when there are multiple values for certificates. I have also changed the Description for certificate parameter in new-aduser. Thanks, Sri

I understand, however, Does -Certificates supports supplying more than on array of X509Certificate on a list array?
like this:
$cert1 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test1.cer"
$cert2 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test2.cer"
$certsA = $cert1,$cert2

$cert3 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test3.cer"
$cert4 = New-Object System.Security.Cryptography.X509Certificates.X509Certificate "C:\Certs\Test4.cer"
$certsB = $cert1,$cert2

New-AdUser -Certificates $certsA,$certsB

Can you kindly test that?
Thanks

Thank you, @get-itips  I get the below error when using New-AdUser  GlenJohn -Certificates $certsA,$certsB

If i use the below it works.
PS C:\Users\Administrator> New-ADUser GlenJohn -Certificate (new-object System.Security.Cryptography.X509Certificates.X5
09Certificate $certsa,$certsb)

Ok thanks for that testing @msbemba so this is not true for Certificates, right?
To enter multiple values, use the following syntax: ,,.... If the values contain spaces or otherwise require quotation marks, use the following syntax: "","",...""."

Yes, I'm not able to add multiple values in one cmdlet like  "","",...""."
I'll update the document accordingly for the certificate section.
On Tue, Jul 21, 2020 at 1:28 AM Andres Mariano Gorzelany <
<EMAIL_ADDRESS>wrote:

Ok thanks for that testing @msbemba https://github.com/msbemba so this
is not true for Certificates, right?
To enter multiple values, use the following syntax: ,,.... If the values
contain spaces or otherwise require quotation marks, use the following
syntax: "","",...""."
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-powershell-docs/pull/2049#issuecomment-661301901,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK63OZFFSMYA35GHCSUVJQLR4SOW7ANCNFSM4OYF7T7Q
.

--

Sriraman Srinivasan
If Plan "A" Doesnt work there are 25 other letters:) Stay Cool !

Docs Build status updates of commit 9ff3b4d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a0f77ed:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/windows/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012-ps/activedirectory/New-ADUser.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADComputer.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/New-ADUser.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


claim search filiter for free vs paid content

Can do this via:
            --fee_amount=<fee_amount>       : (decimal) content download fee (supports equality constraints)

This should be possible in claim search and lighthouse searches

This is now available.


Add license.md

Is this MIT ?

don't you see it in the package.json

Ok, it is there, but usually, projects also put this in a file called licence.md, it makes things clearer I think

you are right. you can make a pr

Yep , see #43


Collapsing window issue

Hello, I have an issue when I collapse a window when i'm using functionalProgramming.window, the window disappeared and is replaced by a debug window.
I have no problem when i'm using begin() with end().
Example :
functionalProgramming.window("Test", null) {
  button("test button")
}

Hi,
However, cpp code crashes when I collapse that
I dont know which are the conditions under which you should use that construct, but I can tell that you should use withWindow
    if (!begin(name)) {
        ...
    }
    end()

window is the shortcut for
    if (!begin(name)) {
        ...
        end()
    }

In general, all the plain name involve always an if, all those that start instead with with* have a begin/end construct
Let me know if it works

Yes it works, thanks for the information and sorry for the inconvenience.

You are welcome, no inconvenience at all
I'll expand the wiki with that sooner or later :)


gRPC-web

As discussed in https://github.com/istio/pilot/issues/928 it would great if Pilot could enable Envoy's gPRC-web filter so that browsers can interact with backend gRPC services directly (useful for admin interfaces etc).
Also, in general, it would great to get a bit more control over Envoy config for filters etc, being a more useful ingress, getting closer to to nginx ingress for usefulness!

Issue moved to istio/istio #1368 via ZenHub


Export directories (and other container files) by enabling support for /containers/full route

TL;DR:  Make export() more robust for containers.

Calling client.Container.export() fails when exporting to the default serialization format, "application/x-hdf5".
This PR fixes that functionality with the following updates:

CatalogContainerAdapter.items_range() now supports slicing for item generators (in addition to previously supported subscriptable items).
serialize_hdf5() now support both async and sync reads, including CatalogArrayAdapter.read().

Additionally exporting selected "fields" now works correctly, using client.Container.export(..., fields=...) or GET /container/full?field=...:

/container/full routes now pass requested fields to CatalogArrayAdapter.read() as originally intended.
ensure_awaitable() now correctly handles **kwargs for synchronous callables.

These changes are tested with several Tiled containers:

Directory of files
Excel file with multiple spreadsheets
Zarr group with multiple datasets
HDF5 file with multiple top-level objects

By adding some xfail tests to the suite, it became clear that the results of test_metrics depend very much on which tests were run before it. That test inspects ALL metrics generated during the entire testing session, rather than only the metrics generated during the test.
I'll push an update that isolates the metrics inspected by test_metrics.

Near the beginning of test_metrics a baseline of the total_request_time is now computed from a /metrics endpoint call before the true testing begins. I did not see a simple way to clear the metrics, so this seemed like a reasonable alternative.

I was getting an error while trying to save 2 bluesky runs in on hdf5 file. On the client side, I was getting a 500 error, but I saw that the code stopped while trying to access one of the nodes here.
https://github.com/jmaruland/client_tools/blob/multiple-scan-exporter/client_exporter.py#L100
But this should help to unblock the issues affecting my code.
Thanks @padraic-shafer


Add ARG to allow appsody to pass docker-options for build-arg - WIP DO NOT MERGE

Checklist:

[ ] Read the Code of Conduct and Contributing Guidelines.

[ ] Followed the commit message guidelines.

[ ] Stack adheres to Appsody stack structure.

Modifying an existing stack:

[ ] Updated the stack version in stack.yaml

Contributing a new stack:

Describe how application dependencies are managed:

Explain how Appsody file watcher is utilized:

Describe other Appsody environment variables defined by the stack image:

Describe any limitations and known issues:

Related Issues:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ragu Kattinakere seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@raguibm - Thanks for raising this. Please could you raise this as two separate PR's? (one for microprofile and one for open liberty)


Ask node red status (read data from node red)

Hi everyone,
In addition to sending commands from Alexa to node red, is it possible to read the values present on the node red?
I have a DHT11 (temperature and humidity sensor), on my P0 raspb with node red.
I want to ask Alexa what the temperature and humidity of my room are or I want to know if a switch is ON or OFF.
Thanks

I have tutorial for my 'Room Aware' thermostats, that also covers getting data from an Entity and/or Sensors.
Take a look: https://youtu.be/25-VCm66tVs


fix(compiler-sfc): defineProps() should work with multiple declarations

Fix: #3739

See a slightly more efficient fix in 62c1b2f7 (avoids filter and indexOf calls)


Publishing NPM & Deno Package

Since we have freezed the feature set and functionalities, We are now at v1.0.
@sripravan Can you please work on publishing packages to npm and deno.

The package is published to NPM : https://www.npmjs.com/package/@yakshavingdevs/datadance
And trial and error to upload to npm swallowed 2 versions(1.0.0,1.0.1) :sweat_smile: :disappointed:


Ikiru

Source name
Ikiru
Source link
https://ikiru.me
Source language
Indonesia
Other details
Rebranding of mangatale
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

Ikiru is old https://mangatale.id . Template is identical. Just make just to download image without referer, cdn dont like it.


Pytorch 2.0 + Latest xformers and cuDNN

I tried to create a Colab notebook with Python 3.10.6,  Pytorch 2.0 + Latest xformers and cuDNN libraries to get better performance without any success.
Is it even achievable on colab? On my local windows machine it was really easy, but I have 8GB of VRam only and decided to try it on Colab.

try conda inside colab
https://github.com/conda/conda
https://anaconda.org/
https://github.com/conda-incubator/condacolab


chore(lidar_centerpoint): add trained model of centerpoint

Signed-off-by: yukke42<EMAIL_ADDRESS>Description
Update the trained model of lidar_centerpoint.  The inference execution time increased when running the package with sensing even though no packages requiring GPU executed. The cause haven't been identified yet.

DNN inference time [ms]

w/ sensing
33.53

w/o sensing
19.49

centerpoint_tiny
GPU Memory [MiB]: 1493
Exec Time [ms]: 47.59 ± 5.73
https://user-images.githubusercontent.com/24660808/176686033-2382d49c-bb71-40a0-bc7f-77ea82fde56f.mp4
centertpoint
GPU Memory [MiB]: 1615
Exec Time [ms]: 63.31 ± 10.05
https://user-images.githubusercontent.com/24660808/176686338-e62c6837-c80c-4803-9386-0550d2eaa5db.mp4
Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Is this improved? :pray:
I didn't feel it is improved and seemed to increase false positives.

Is this improved?
I didn't feel it is improved and seemed to increase false positives.

@yukkysaito
Yes, it looks almost the same performance in a sample-bag, but the evaluation performance gets better in our internal dataset.

@yukke42 can you share the movie?

@tkimura4 @yukke42 can you test the real vehicle since the calc cost is increased?

@yukke42 can you share the movie?

Yellow: previous model
Green: this model
The large vehicles detection isn't perfect yet, but it's getting better.
https://user-images.githubusercontent.com/24660808/177090109-aa56ab24-95de-44d3-accb-5dcf05eb0c6d.mp4

I will add the previous model as the default model and add option to use the updated model. Then I will create other PR to deal with the computational issue.

I will add the previous model as the default model and add option to use the updated model. Then I will create other PR to deal with the computational issue.

Done.

@yukkysaito I want to merge this PR If reviewers confirm that updated codes have no problem, before we check that the added model runs on real vehicle without any issue, because the default model of lidar_centerpoint is the same as before.

@yukke42
I confirmed two models were working properly. However, I couldn't find any obvious difference between centerpoint and centerpoint-tiny.
Please give me some more time to confirm.


Remove port from nodeurl and clienturl (docs, sample config and examples)

eg if you specify
nodeurl = "http://<IP_ADDRESS>:8888/"
nodeport = 7777

the url actually used will be http://<IP_ADDRESS>:7777
The examples, sample config and docs all make them the same eg
nodeurl = "http://<IP_ADDRESS>:8081/"
nodeport = 8081

same for clienturl/clientport

Hi, I would like to work on this issue. Can you assign this issue to me?

Hi, I would like to work on this issue.

Hello sir, I have created a pull request. In the pull request all the test cases have passed except one. The test case not passed are for the docker.md file, I made changes in the file according to the mentioned issue. can you please review it?

Apologies for being ambiguous in the description. We still need the nodeport value but remove the port from the nodeurl value
eg
nodeurl = "http://<IP_ADDRESS>/"
nodeport = 7777

I think if you make this change throughout, the docker step should pass.

@macfarla is this issue still relevant, or should it be closed?

the easy workaround is to make them the same ie leave as is.


Position interface velocity abs

CodeReview PR for on-code discussion

I picked the changes from this branch to a new branch improve_trajectory_command_behavior


Add .clang-format

This includes (requires) #403.
The idea to introduce .clang-format was based off a discussion in #394.
I have applied clang-format on a handful of files to show the effects (I didn't want to break everything by doing all files).
Command line:
clang-format -style=file -i coincontrol.h db.h noui.cpp addrman.cpp allocators.h mruset.h protocol.h version.cpp checkpoints.h db.cpp init.h key.h addrman.h

This formatting looks good. It's easy to read. This should be a trivial change as it should not break any features in the software.

I like it apart from my inline comments.

If we chose to use clang on the entire repo; we'd have a lot to go through and sort. It'd be worth it for future. A lot of the code within Paycoin is currently messy and could do with looking smarter.

@jwrb I agree with the exception of my comments.

Hmm I knew this was possibly going to be an issue with my pull but my clang-fu isn't up to scratch. I'll have to investigate those comments further but I'm not sure if it's possible or not and if we do find a fix the there is also the possibility that the fix might actually cause imperfections in other places.
Could be a lesser of two evils type commit. Let me know your thoughts before I dive in too deep...

@mitchellcash that's why I generally don't rely entirely on format tools. They're great for fixing format sometimes but once you've got the bulk of it fixed there's almost always something you want to tweak manually afterwards lol

Agreed. I don't mind either way. Do we want this or not?

I'd still prefer right aligned pointers. @IngCr3at1on?

@jwrb semi-indifferent but that's how I would normally write them.

@IngCr3at1on Agreed. I always use right-side pointers when I'm working. It looks nicer in my opinion too.


Examples: new line or not

"One of these examples:

delete 1
delete n/John Doe
delete n/John Doe<EMAIL_ADDRESS>


Data Export Feature

As a signed-in user
I should be able to export all of my data in CSV format

How's it going? This is my first time contributing to an open source project and I was hoping to help out with this issue. If there is someone else working on it already just let me know and I'll see if I can't help out somewhere else. Thanks!

hey @anubiskhan  It looks like there is a PR up for this issue.
In general, look for the "help wanted" tags. Those usually mean that the issues have been vetted and are ready to be worked on.
Have you joined the slack channel? https://rubyforgood.herokuapp.com/ I strongly recommend signing up there. It's a great way to communicate with people.

@chiefkikio Thanks, I'll check out some of the ones with 'help wanted' tags and I will definitely join that Slack.


streamdeck-ui: 3.1.0 -> 4.1.2

Description of changes

For reviewers: Review the first commit since that is the actual change. The other commit is just the result of running nix run .\#nixfmt-rfc-style pkgs/applications/misc/streamdeck-ui/default.nix. Let me know if you want me to revert that commit.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 318899 run on x86_64-linux 1

2 packages built:

streamdeck-ui
streamdeck-ui.dist

Been running this today and it works well and even works on my StreamDeck+ (which was the reason I wanted to update it). The main hurdle now is to get a OK on the code.

Package needs to be migrated to by-name.
From pkgs/applications/misc/streamdeck-ui/default.nix to pkgs/by-name/st/streamdeck-ui/package.nix.

Package needs to be migrated to by-name. From pkgs/applications/misc/streamdeck-ui/default.nix to pkgs/by-name/st/streamdeck-ui/package.nix.

Is there anything other than moving it and changing all-packages.nix?


dnd is broken if using eventPropGetter function

Take the dnd example, and modify to use an eventPropGetter returning a style object, attempt to use dnd functionality.
It seems to fail because some of the dnd props are being overridden or something ?
The event passed in to eventPropGetter has no extra information available to it, so unsure how to give the props it wants.

works if selectable is disabled, but clicking on the event causes errors in the logs.

Thanks for the issue, sorry for the Delay. I don't really maintain the addons code, since they are extra functionalities provided but others and i include them here as a convenience. Please feel free to submit a PR fixing this if it's relevant to your needs thanks!


Slack Team organization

Some notes to organize our Slack Team:

[x] rename general to resources,
[x] restrict to resources to admins
[x] make @mary-grace an admin
[x] create a questions channel, auto invite users

teamwork ftw!


Make z-index higher than redbox-react

Right now you can't use redbox-react and devtools together because redbox has a much higher z-index:
https://github.com/commissure/redbox-react/blob/cfba6df1ac4a7ecdc50dedd0990be1a2ad4e1dab/src/style.js#L14
Can we bump the index on this project to go above it?

This repo doesn't add any html elements. I guess you want to implement it on redux-devtools-dock-monitor or redux-devtools-log-monitor or any other monitor you're using.
However,<PHONE_NUMBER> is the maximum value of z-index in most of browsers.

Oops, you are right I meant the monitors.  But that is unfortunate that they set it to the max value.   Not being able to use the DevTools makes redbox-react unusable for me.  I'll create an issue for them

A solution would be to open DevTools in a new window or to use the browser  extension.


ConfigurationBinder binds empty array as null

Example:

I have a class AppSettings with property public string[] SomeValues { get; set; }.
My appsettings.json is {"SomeValues": []}.

When I bind an instance of AppSettings to the configuration like this: configurationBuilder.AddJsonFile("appsettings.json").Build().Bind(appSettings), property SomeValues is null. I expect empty array.
Note that if I change appsettings.json to {"SomeValues": ["val1", "val2"]}, SomeValues does get set to the expected string array. So generally binding is working.

I think the binder doesn't tough a property when the configuration source doesn't yield any value for the property.
SomeValue is null because you didn't initialize it. Try
public string[] SomeValues { get; set; } = new string[0];

Thanks @MichaCo. This solves the specific issue I described, but creates another. If property is declared as public string[] SomeValues { get; set; } = new string[0]; and appsettings.json is {"SomeValues": null}, SomeValues stays as empty array. Expected null.
I can obviously work around both scenarios, but the expected behaviour is that I do not have to give default values to the properties, and ConfigurationBinder sets them to whatever I see in appsettings.json (provided there are no other config sources of course).

This mostly just due to how config works, you can't store null values in config today, as there's no way to determine if config has a "key" just with a null value today.  So the binder works as @MichaCo describes, it basically just uses reflection on properties and checks if there is a value in the config with the matching key, if a null value is returned, that property is left alone.

@HaoK thank you for the detailed explanation. I have one last question:

Is this behaviour of ConfigurationBinder impossible to change because of

We are unlikely to change the binder at this point no.  What behavior are you looking for?

What behavior are you looking for?

As I described above, the naturally expected behaviour is "what you see is what you get". If appsettings.json has SomeValues set to null or empty array, I expect the SomeValues property of my AppSettings class to be set to null or empty array correspondingly.
That should happen even if the property has been declared with a default, e.g. public string[] SomeValues { get; set; } = new string[] {"val1", "val2"};. The property should retain its default only if appsettings.json does not contain the SomeValues key at all.

How would you imagine this working if config doesn't let you distinguish between "SomeValues" = null and it just never being set?

If that ability was added to config, then you could ask for the appropriate binder change

@HaoK here's the behaviour I expect:

Whatever is in the json file, gets applied to the class properties, including nulls and empty arrays.
If there's a property in the class that does not have a matching key in the json file, the property retains its default value if defined, or it will be the default of the type if not defined.

How would you imagine this working if config doesn't let you distinguish between "SomeValues" = null and it just never being set?

I do not think I want or need to be able to distinguish. When I define SomeValues in the class, I know whether it's nullable or not, and if not, what the default of the type is. Then I can decide on the behaviour I want if SomeValues is not present in json or if it's present as null.
Here are some examples of what I would expect:

SomeValues is nullable type with no default. If it's not present in the json file, or present as null, the prop value is null.
SomeValues is nullable type with a non-null default. If it's not present in the json file, the prop is the defined default. If it is present in the json file as null, the prop value is null.
SomeValues is non-nullable type with no default. If it's not present in the json file, the prop is the default of type. If it is present in the json file as null, I get a runtime error.
SomeValues is non-nullable type with a default. If it's not present in the json file, the prop is the defined default. If it is present in the json file as null, I get a runtime error.

Hope the above makes sense.

Yeah I don't think that's an improvement over todays behavior, that would basically result in every property being null if its not defined in config.

Not sure what you mean, that's not the improvement I'm asking for. It already works like that right now:

every nullable property not defined in config will be null,
every not nullable property not defined in config will be default of type.

@HaoK I feel there's still a lack of understanding of what I'm asking for, so I'll try to explain again, in a slightly different way:

When a class gets instantiated, all its properties get set to their relative defaults of type. And those properties that have explicitly defined default values, get set to those default values.
Now as we have an instance of the class, we start updating its properties from config. For each property:
If config does NOT have a key that matches the prop by name, we leave the prop value as is.
If config DOES have a key that matches the prop by name, we update the prop value to the value in the config.

The last scenario above is currently not working as expected. We currently do NOT update the prop value to the value in the config, if the value in the config is null or empty array.

As I said before, there's no way for you to make the binder work like this (3 vs 4) without the ability to tell if a config key is defined vs just not set.  If you feel you can make this work, feel free to submit a PR demonstrating this and we can discuss from there if you like

You don't actually even need to submit a PR to the binder, you can just write the code to distinguish between steps 3 and 4 using IConfiguration

Same issue here: null and [] is not the same.

I agree with @andrewslavin .
Take the following settings file as an example:
{
	"Whitelist": null
}

For me this has the meaning that NO whitelist exists and so everybody is allowed to do something.

{
	"Whitelist": []
}

But this means for me that nobody is allowed to do something,
because there IS a whitelist with no elements in it.

What I want to say is that in this example the meaning of null and [] is the opposite and not the same.

I hope you get my point.
Thanks.

@HaoK Status of this issue?

Nothing to be done here, this is just how the binder works, it ignores null values and doesn't set properties


added signed response example + logging headers example

e75b9f0 (#148) This seems like a mistake.

e75b9f0 (#148) This seems like a mistake.

Removed this plugin because Ian mentioned it doesn't work properly for # mdx links. Should install and create a PR for it?

I think this should be ready to merge now


Replace com.google.api.client.util.Lists with Guava's Lists

Do you think it's worth adding to this CL related changes, i.e. changing com.google.api.client.util.DateTime in BucketInfo to joda?
Two additional cleanup changes could include:

BucketInfo uses the wrong checkNotNull static import
BlobInfo uses api client DateTime

BucketInfo and BlobInfo use DateTime because the proto objects timestamps are actually DateTime fields.

Fixed checkNotNull inclusion in 6e87fa9

Looks like there are merge conflicts, but other than that, looks good to me.


Description – Explainers

Created by Olivia Boldt via monday.com integration. 🎉

@jordanlambrecht
Explainer videos break down a complicated concept into something easily digestible for your audience. Using animation and voiceover, we can help simplify your business ideas, products, and the story you want to tell.


Regular expression issue in validator

When using regular expression in a validator
Package version
4.1.0
Node.js and npm version
node 11.8.0
npm 6.5.0
Sample Code (to reproduce the issue)
 get rules() {
    return {
      password:
        'required|regex: /^(?=.*[A-z])(?=.*[A-Z])(?=.*[0-9])(?=.*[$@])(?!.*[iIoO])S{6,12}$/'
    }
  }

Getting Error:
Invalid flags supplied to RegExp constructor '12}$/'

Hey @mritgupta! 👋
From your code sample, it seems that you have a syntax error with the quotes.

I suggest just through the docs of Indicative, it's documented https://indicative.adonisjs.com/docs/syntax-guide#_limitations

Yes, I got what is the issue.
Thanks a lot, Harminder


feat: clin_sig spell

New spell to visualize the clinical significance

Just as a general info: There is no need to open up a new PR if there is a new change. Simply push another commit to the branch of the currently opened PR and the one already open will update.

To get the tests passing some changes are required. Here is a summary as I do not have write access and github suggestions would get a bit out of hand.

test_*.yaml and data*.tsv must be placed in a subdirectory called tests
test*.yaml:

files need an underscore e.g test_*.yaml
url and path need to be relative to the yaml-file's location
the column name should match the one set in the data*.tsv

data*.tsv: choose a more generic column name as this is just an example e.g. some clinical significance column (optional)
meta.yaml:

type needs to be column as it is not a description field
check for correct indentation and spelling of test-data
adjust the path after moving the yaml-file into a subdirectory

spell.yaml: the function must not have a name to be called

To me this looks good now.

@johanneskoester should the directory more contextual like bio/clin_sig or annotation/clin_sig?

@johanneskoester should the directory more contextual like bio/clin_sig, ~vep/clin_sig~ or annotation/clin_sig?

bio/clin-sig I would say.

Looks got to me.


[5.9] Remove unused parameter in saveSession method

Remove unused function parameter let function more readable.

Is it not the case that this param is passed so that anyone overriding this protected method will have access to the current request?

@GrahamCampbell When I see the name saveSession, I will think it just save what I write to session, it only do save. If I want to use some data of request to write to session, I may write another function to do this. It make function more clearer.
I think you are right. Maybe I can write a function that is saveRequestDataToSession to do save request data to session!

What Graham said seems pretty valid.


Fixed deployment templating for kubePlex.image

Deployment fails with templating error due to incorrect key identifier in deployment.yaml for kubePlexImage.repository, kubePlexImage.tag and kubePlexImage.pullPolicy.
I've updated the key to kubePlex.image.* and it's working again.
M

Thanks for this.
I have only just noticed this PR, and #27 fixes this plus adds an extra externalIPs field, so to save rebases I have merged that instead 😄


Issue with 'run_bulkModule.sh'

Hi,
I cloned the repository and hopefully satisfied all the software installation requirements.
I ran ./install/validate.py config/bulk-config.json --ignore-input-output --software  without any errors.
But when I run:
./run_bulkModule.sh config/bulk-config.json GATA1_D7_30min_chr11
I get:
./run_bulkModule.sh: line 20: jq: command not found
./run_bulkModule.sh: line 21: jq: command not found
./run_bulkModule.sh: line 22: jq: command not found
organism_build should be one of hg38, hg19, mm10 or mm9

Should I download and install jq separately?
Attached is my bulk-config.json file.
bulk-config.txt
Some tips appreciated, thanks!

Yes that is the issue. You configuration file seems good. jq should be installed by default in linux system but you could install it by yourself.

Thanks for the reply, I'm working on a cluster server and do not have sudo access.
However, I downloaded the appropriate jq executable file for linux 64 and I run it:
jq
jq - commandline JSON processor [version 1.6]

Usage:	/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/jq [options] <jq filter> [file...]
	/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/jq [options] --args <jq filter> [strings...]
	/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/jq [options] --jsonargs <jq filter> [JSON_TEXTS...]

jq is a tool for processing JSON inputs, applying the given filter to
its JSON text inputs and producing the filter's results as JSON on
standard output.

The simplest filter is ., which copies jq's input to its output
unmodified (except for formatting, but note that IEEE754 is used
for number representation internally, with all that that implies).

For more advanced filters see the jq(1) manpage ("man jq")
and/or https://stedolan.github.io/jq

Example:

	$ echo '{"foo": 0}' | jq .
	{
		"foo": 0
	}

For a listing of options, use /dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/jq --help.

And I added the path of this jq to my ~/.bashrc file.
But when I run ./run_bulkModule.sh config/bulk-config.json GATA1_D7_30min_chr11 I get the same error:
./run_bulkModule.sh: line 20: jq: command not found
./run_bulkModule.sh: line 21: jq: command not found
./run_bulkModule.sh: line 22: jq: command not found
organism_build should be one of hg38, hg19, mm10 or mm9

I wonder if you run separately on compuational node. Can you try to add jq to PATH in your summited script using something like export PATH=/path/to/jq:"$PATH"

I'm actually not queueing it any scheduling script, just running the command on command line.
You mean add the export command in ./run_bulkModule.sh?
Thanks!

I changed jp to absolute path/jq and the pipeline runs finally!
But the exampledata sample fails and so does my sample.
Please see below:
(cutruntools2) [f0042dk@discovery7 CUT-RUNTools-2.0]$ ./run_bulkModule.sh config/bulk-config.json SL_04_S4
==================================== Bulk data analysis pipeline will run ==============================================================
## Input FASTQ folder:            /dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/human
## Sample name:                   SL_04_S4
## Workdir folder:                /dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4
## Experiment name:               SL_04_S4
## Experiment type:               CUT&RUN
## Reference genome:              hg38
## Spike-in genome:               FALSE
## Spike-in normalization:        FALSE
## Fragment 120 filtration:       TRUE
=================================================================================================================================
[info] Input file is SL_04_S4_R1_001.fastq.gz and SL_04_S4_R2_001.fastq.gz
Wed Jun 30 16:39:16 EDT 2021
[info] Trimming file SL_04_S4 ...
Wed Jun 30 16:39:16 EDT 2021
[info] Second stage trimming SL_04_S4 ...
Wed Jun 30 17:34:19 EDT 2021
[info] Aligning file SL_04_S4 to reference genome...
Wed Jun 30 17:59:37 EDT 2021
[info] Bowtie2 command: --dovetail --phred33
[info] The dovetail mode is enabled [as parameter frag_120 is on]
[main_samview] fail to read the header from "-".
[info] FASTQ files won't be aligned to the spike-in genome
[info] Filtering unmapped fragments... SL_04_S4.bam
Wed Jun 30 17:59:38 EDT 2021
[main_samview] fail to read the header from "/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/aligned/SL_04_S4.bam".
[info] Sorting BAM... SL_04_S4.bam
Wed Jun 30 17:59:38 EDT 2021
INFO	2021-06-30 17:59:40	SortSam

********** NOTE: Picard's command line syntax is changing.
**********
********** For more information, please see:
********** https://github.com/broadinstitute/picard/wiki/Command-Line-Syntax-Transition-For-Users-(Pre-Transition)
**********
********** The command line looks like this in the new syntax:
**********
**********    SortSam -INPUT sorted/SL_04_S4.step1.bam -OUTPUT sorted/SL_04_S4.bam -SORT_ORDER coordinate -VALIDATION_STRINGENCY SILENT
**********

17:59:42.439 INFO  NativeLibraryLoader - Loading libgkl_compression.so from jar:file:/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CUT-RUNTools-2.0/install/picard-2.8.0.jar!/com/intel/gkl/native/libgkl_compression.so
[Wed Jun 30 17:59:42 EDT 2021] SortSam INPUT=sorted/SL_04_S4.step1.bam OUTPUT=sorted/SL_04_S4.bam SORT_ORDER=coordinate VALIDATION_STRINGENCY=SILENT    VERBOSITY=INFO QUIET=false COMPRESSION_LEVEL=5 MAX_RECORDS_IN_RAM=500000 CREATE_INDEX=false CREATE_MD5_FILE=false GA4GH_CLIENT_SECRETS=client_secrets.json USE_JDK_DEFLATER=false USE_JDK_INFLATER=false
[Wed Jun 30 17:59:42 EDT 2021] Executing as<EMAIL_ADDRESS>on Linux 3.10.0-1160.11.1.el7.x86_64 amd64; OpenJDK 64-Bit Server VM 1.8.0_292-b10; Deflater: Intel; Inflater: Intel; Provider GCS is not available; Picard version: 2.21.7-SNAPSHOT
INFO	2021-06-30 17:59:42	SortSam	Finished reading inputs, merging and writing to output now.
[Wed Jun 30 17:59:42 EDT 2021] picard.sam.SortSam done. Elapsed time: 0.01 minutes.
Runtime.totalMemory()=83165184
[info] Marking duplicates... SL_04_S4.bam
Wed Jun 30 17:59:43 EDT 2021
[info] Removing duplicates... SL_04_S4.bam
Wed Jun 30 17:59:48 EDT 2021
[info] Filtering to <120bp... dup.marked and dedup BAMs
Wed Jun 30 17:59:49 EDT 2021
[info] Creating bam index files... SL_04_S4.bam
Wed Jun 30 17:59:49 EDT 2021
[info] Reads shifting
Wed Jun 30 17:59:49 EDT 2021
[info] Your data won't be shifted as the experiment_type is specified as CUT&RUN...
[info] Peak calling using MACS2... SL_04_S4.bam
[info] Logs are stored in /dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/logs
Wed Jun 30 17:59:49 EDT 2021
[info] Peak calling with BAM file with NO duplications
[info] macs2 narrow peak calling
[info] macs2 broad peak calling
[info] Getting broad peak summits
Traceback (most recent call last):
  File "/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CUT-RUNTools-2.0/install/get_summits_broadPeak.py", line 14, in <module>
    f = open(sys.argv[1])
FileNotFoundError: [Errno 2] No such file or directory: '/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/macs2.broad/SL_04_S4_peaks.broadPeak'
[info] SEACR stringent peak calling
Traceback (most recent call last):
  File "/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CUT-RUNTools-2.0/install/change.bdg.py", line 12, in <module>
    f = open(sys.argv[1])
FileNotFoundError: [Errno 2] No such file or directory: '/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/seacr/SL_04_S4_treat_pileup.bdg'
Calling enriched regions without control file
Proceeding without normalization of control to experimental bedgraph
Using stringent threshold
Creating experimental AUC file: Wed Jun 30 17:59:59 EDT 2021
Calculating optimal AUC threshold: Wed Jun 30 17:59:59 EDT 2021
Using user-provided threshold: Wed Jun 30 17:59:59 EDT 2021
Error in read.table(argsL$exp) : no lines available in input
Execution halted
Unable to access /dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/seacr/SL_04_S4_treat.stringent.bed
Traceback (most recent call last):
  File "/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CUT-RUNTools-2.0/install/get_summits_seacr.py", line 14, in <module>
    f = open(sys.argv[1])
FileNotFoundError: [Errno 2] No such file or directory: '/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/seacr/SL_04_S4_treat.stringent.bed'
[info] Generating the normalized signal file with BigWig format...
Wed Jun 30 18:00:01 EDT 2021
cp: cannot stat '/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/macs2.narrow/SL_04_S4.cpm.norm.bw': No such file or directory
cp: cannot stat '/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/macs2.narrow/SL_04_S4.cpm.norm.bw': No such file or directory
[info] Your bigwig file won't be normalized with spike-in reads
[info] Input file is /dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CutNRun_6-18-21/SL_04_S4/peakcalling/macs2.narrow/SL_04_S4_peaks.narrowPeak
cat: SL_04_S4_peaks.narrowPeak: No such file or directory
cat: SL_04_S4_summits.bed: No such file or directory
[info] Get randomized [1000] peaks from the top [2000] peaks...
[info] Filtering the blacklist regions for the selected peak files
[info] Getting Fasta sequences
Warning: the index file is older than the FASTA file.
[info] Start MEME analysis for de novo motif finding ...
[info] Up to 10 will be output ...
Log::Log4perl configuration looks suspicious: No loggers defined at /dartfs-hpc/rc/home/k/f0042dk/miniconda3/envs/meme/lib/site_perl/5.26.2/Log/Log4perl/Config.pm line 325.
Starting getsize: getsize random1000/MEME_SL_04_S4_shuf/SL_04_S4_summits_padded.fa 1> $metrics
/dartfs-hpc/rc/home/k/f0042dk/miniconda3/envs/meme/libexec/meme-5.0.2/getsize: error while loading shared libraries: libicui18n.so.58: cannot open shared object file: No such file or directory
getsize exited with error code 127
getsize failed me... at /dartfs-hpc/rc/home/k/f0042dk/miniconda3/envs/meme/bin/meme-chip line 748.
[info] De Novo motifs can be found: random1000/MEME_SL_04_S4_shuf ...
[info] Loading the De Novo motifs ...
Traceback (most recent call last):
  File "/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CUT-RUNTools-2.0/install/read.meme.py", line 92, in <module>
    ss = read_summary(this_dir + "/summary.tsv")
  File "/dartfs-hpc/rc/lab/L/LeachLab/HIMANSHU/CutNrun/CUT-RUNTools-2.0/install/read.meme.py", line 7, in read_summary
    f = open(n)
FileNotFoundError: [Errno 2] No such file or directory: 'random1000/MEME_SL_04_S4_shuf/summary.tsv'
[info] The signficance cutoff of Fimo scaning is 0.0005...
[info] Motif files can be found: random1000/MEME_SL_04_S4_shuf/motifs
[info] Filtering the blacklist regions for the selected peak files
[info] Getting Fasta sequences
Warning: the index file is older than the FASTA file.
[info] Scaning the De Novo motifs for each peak
ls: cannot access 'random1000/MEME_SL_04_S4_shuf/motifs': No such file or directory
[info] Output can be found: fimo.result/SL_04_S4
#
#        Congrats! The bulk data analysis is complete!
#
--------------------------------------------------------------------------

It's stopping at the alignment step, any insights into the matter would help me a lot. Thanks again!

I changed jq to absolute/path/jq in run_bulkModule.sh and the pipeline runs finally!
I've been getting other issues, checking logs and changing things. I'll do some more trial runs.
Thanks for your help!

Yes that is the issue of the genome path. It should work after remove the 'genome'.
If you follow my tutorial to download the reference genome, the genome file with FASTA format should have the same name (genome.fa) for different genome versions (hg19 or hg38). If users use their own data, sometimes the rule of naming is different which can cause the problem.

Hi,
I'm having issues with the MEME analysis for de novo motif finding.
Could you help me with what the issue is?
Thanks for the amazing tool!
slurm-97220.out.txt


Add AOT target for Key Vault SDK

Resolves #38500

API change check
API changes are not detected in this pull request.

@m-redding I'm still getting some warnings, but are these expected? I shouldn't actually be using these types in my tests, though. E.g., Key Vault is old and doesn't support DynamicData so it shouldn't be calling/using it.
ILC : Trim analysis warning IL2026: [Azure.Core]Azure.Core.Serialization.DynamicData: Using member 'Azure.Core.Serialization.DynamicData.DynamicDataJsonConverter.DynamicDataJsonConverter()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using DynamicData or DynamicDataConverter is not compatible with trimming due to reflection-based serialization. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\Shared\RequestContentHelper.cs(42): Trim analysis warning IL2026: Azure.Core.RequestContentHelper.FromEnumerable(IEnumerable`1<BinaryData>): Using member 'System.Text.Json.JsonSerializer.Serialize<JsonElement>(Utf8JsonWriter,JsonElement,JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\Shared\RequestContentHelper.cs(42): AOT analysis warning IL3050: Azure.Core.RequestContentHelper.FromEnumerable(IEnumerable`1<BinaryData>): Using member 'System.Text.Json.JsonSerializer.Serialize<JsonElement>(Utf8JsonWriter,JsonElement,JsonSerializerOptions)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. JSON serialization and deserialization might require types that cannot be statically analyzed and might need runtime code generation. Use System.Text.Json source generation for native AOT applications. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\Shared\RequestContentHelper.cs(82): Trim analysis warning IL2026: Azure.Core.RequestContentHelper.FromDictionary(IDictionary`2<String,BinaryData>): Using member 'System.Text.Json.JsonSerializer.Serialize<JsonElement>(Utf8JsonWriter,JsonElement,JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\Shared\RequestContentHelper.cs(82): AOT analysis warning IL3050: Azure.Core.RequestContentHelper.FromDictionary(IDictionary`2<String,BinaryData>): Using member 'System.Text.Json.JsonSerializer.Serialize<JsonElement>(Utf8JsonWriter,JsonElement,JsonSerializerOptions)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. JSON serialization and deserialization might require types that cannot be statically analyzed and might need runtime code generation. Use System.Text.Json source generation for native AOT applications. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\RequestFailedException.cs(262): Trim analysis warning IL2026: Azure.RequestFailedException.TryExtractErrorContent(Response,ResponseError&,IDictionary`2<String,String>&): Using member 'System.Text.Json.JsonSerializer.Deserialize<ErrorResponse>(String,JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\RequestFailedException.cs(262): AOT analysis warning IL3050: Azure.RequestFailedException.TryExtractErrorContent(Response,ResponseError&,IDictionary`2<String,String>&): Using member 'System.Text.Json.JsonSerializer.Deserialize<ErrorResponse>(String,JsonSerializerOptions)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. JSON serialization and deserialization might require types that cannot be statically analyzed and might need runtime code generation. Use System.Text.Json source generation for native AOT applications. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\RequestFailedException.cs(263): Trim analysis warning IL2026: Azure.RequestFailedException.TryExtractErrorContent(Response,ResponseError&,IDictionary`2<String,String>&): Using member 'System.Text.Json.JsonSerializer.Deserialize<ResponseError>(String,JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
X:\azure-sdk-for-net3\sdk\core\Azure.Core\src\RequestFailedException.cs(263): AOT analysis warning IL3050: Azure.RequestFailedException.TryExtractErrorContent(Response,ResponseError&,IDictionary`2<String,String>&): Using member 'System.Text.Json.JsonSerializer.Deserialize<ResponseError>(String,JsonSerializerOptions)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. JSON serialization and deserialization might require types that cannot be statically analyzed and might need runtime code generation. Use System.Text.Json source generation for native AOT applications. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]
ILC : Trim analysis warning IL2026: [Azure.Core]Azure.Core.Json.MutableJsonDocument: Using member 'Azure.Core.Json.MutableJsonDocument.MutableJsonDocumentConverter.MutableJsonDocumentConverter()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using MutableJsonDocument or MutableJsonDocumentConverter is not compatible with trimming due to reflection-based serialization. [X:\azure-sdk-for-net3\sdk\keyvault\Azure.Security.KeyVault.Secrets\aot\Azure.Security.KeyVault.Secrets.Aot.csproj::TargetFramework=net7.0]

The RequestFailedException warnings will be fixed by: https://github.com/Azure/azure-sdk-for-net/pull/38996
The DynamicData / MutableJsonDocument warnings are expected and should be baselined. It's a bit of a complex issue but to try to summarize very briefly, both types have problematic JsonConverters that introduce a "hole" (aka a way that they could be used unsafely with no warning) so to be safe we can't suppress those warnings. However, since keyvault doesn't use them, they are only visible when using the <TrimmerRootAssembly /> to analyze the whole assembly (the analyze is aggressive).  when an application actually uses an app with AOT those warnings won't get reported
Lastly, the RequestContentHelper.cs warnings can be resolved by adding a net6.0 target to target frameworks in the csproj file. Monitor OpenTelemetry exporter ran into the same problem

@m-redding thanks. So, in addition to adding net6.0 to TargetFrameworks, there's nothing else needed here? Do you recommend we merge this PR and save the project, or did you have some other plans for regression testing?

Ah I'm so sorry that's my bad - I meant you have to add a net6.0 target to the Keyvault package - https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Azure.Security.KeyVault.Secrets.csproj#L11
At least this is how the Monitor exporter team fixed it, the discussion about this was here:

I figured it out. The file RequestContentHelper.cs is compiled into Azure.Monitor.OpenTelemetry.Exporter which only builds for netstandard2.0, it doesn't target net6.0. So it uses the "old" code which produces the warning.
...
There are other warnings from the AOT test which originate in the OTel Exporter, this one just doesn't look like it because it's from the shared code - but it does originate there as well. To fix this, we need to target that project to net6.0 as well.

https://github.com/Azure/azure-sdk-for-net/pull/37734#discussion_r1320358985
So it looks like the warning is coming from core but it's actually coming from KeyVault, in a sense, since it doesn't target net6.0.

Adding an explicit target to our nupkg - adding yet another binary - seems like overkill just to satisfy a warning that might impact a few people, and seems like it might not even be a real problem for people compiling their apps for AOT.

It's kind of a weird case because the problem doesn't have anything to do with the attributes, it's this code (and another line in the same file):
L39:
#if NET6_0_OR_GREATER
                    content.JsonWriter.WriteRawValue(item);
#else
                    JsonSerializer.Serialize(content.JsonWriter, JsonDocument.Parse(item.ToString()).RootElement);
#endif

The net6.0+ code is trim safe, but the else is not trim safe. Since keyvault doesn't have a net6 target, then my understanding is that it will only ever run the unsafe code, even if the app using keyvault is targeting net6+.
It may likely be the case that this warning won't get reported by an application using keyvault that isn't including the whole assembly, I need to look into if that particular method is on a hot path or not.

that isn't including the whole assembly

That seems to be the differentiator here, and probably can be ignored then. Key Vault SDK itself shouldn't use any of the types that are not trim-safe, so it's only because the analytics is whole-assembly we're seeing these. So I think this PR is effectively done.
Do you, @m-redding, @jsquire, or @pallavit think I should merge this PR to add this AOT-regression-checking project, or do you have something better planned at least for Core? The risk is low that Key Vault itself would regress AOT, but I'm not opposed to having a project to make sure if we know it'll get used somehow.

I think you can merge it, this is what I'm working on for core - https://github.com/Azure/azure-sdk-for-net/pull/38634 (it is still very much a WIP) but I need to fix up a couple issues, get some input and feedback on the setup, and figure out how to test it in the actual pipeline. In the meantime, and for any unit tests you'd like to add, I think this would be helpful.

@m-redding we could remove this project when your PR is ready, or feel free to take the Packages.Data.props changes I did here for yours.

I've merged to get the Packages.Data.props change in for you to rebase on. We can remove the project later, but it may be handy for now. Cleans up my active PRs too.


Binary Search using Java

Hi Avinash!
I would like to add Binary Search using Java
Could you please assign this issue to me?
Thank You!

@Yasas4D only 2 issue per day on a some repo so closing the issue .
contribute to other repo also