Increase recoveryCallback function

Hi @ryanjbaxter
When the ribbon retries fail to return information usually is an exception,sometimes this may not be friendly. spring retry provides a callback mechanism (when the retry fails, the user can customize the return message instead of returning a exception).When we just use ribbon (without integrating Hystrix), I think this callback mechanism is useful.
So I submitted a PR, hoping to increase this function. I hope you can help me review the code, and give your advice, look forward to your reply. best wishes : )

Hi @ryanjbaxter
First of all thank you very much for responding to me :)
The reason why I added this feature is as follows:

We did not provide a fallback mechanism when an exception occurred when the project only used ribbon (no hystrix was integrated). To implement the fallback mechanism, we must integrate the hystrix with the ribbon (to be able to use the hystrix fallback mechanism). I think this may result in a certain coupling (why just use the hystrix fallback feature (a part of the Hystrix feature), we need to integrate the entire Hystrix into our project).

When we implement RecoveryCallback, we can get some information from the RetryContext(such as the number of retries, etc. ) I think this information is helpful to the user and we can not get that information from the hystrix fallback method .

I think we should provide this fallback mechanism for using ribbon only which helps users to fallback even without using hystrix. As for the fallback mechanism using ribbon or hystrix, or both, I think this is user-determined.

This is my reason, it may not be very correct, I hope you can give your advice. Looking forward to your reply, best wishes！

@ryanjbaxter  ping...

Please stop pinging

I am not convinced.  If users want to protect themselves from errors when making remote requests than they will need to add Hystrix to do that.  I have not seen anyone complain about having to do this before so I don't think it is an issue really.  As far as the additional information provided by the RetryContext I dont see that being particularly useful in any way.  In addition the user would have configured this anyways so they should know for example how many times the request was retried before it ultimately failed.  I also prefer Hystrix because it is not tied to the retry implementation, and can be used to protect the app from other types of remote requests (for example DB requests).


code health Documentation updates

[x] documentation is added or updated

Fix capitilistion of list items.
Wrap long lines.
Add full stops to the ends of sentances.

Merged. c4de074e6385a86a43a30fee574e77f9dcabb022


Hawkular transactions livemetrics

This PR includes #8860, #9081 and #9104. It will be rebased once the previous ones are merged.
The goal of this PR is to extend LiveMetrics configuration to allow to add metrics of children.
By default, LiveMetrics is targeted into a single resource, but in Hawkular there is a corner case where metrics of a sub-resource are shown at parent level.
With this change now we can cover this specific use case to support "transactions" metrics at "MiddlewareServer" level.
@miq-bot add_label providers/hawkular
@miq-bot add_label enhancement

@lucasponce If you don't mind I'm going to hold review for all this until after the ManageIQ summit.  I've been trying to focus on blockers and darga/yes stuff for the upcoming release.  Thanks for your patience with me! 😄

@lucasponce is this rebased after all the rest have been merged?

Yes, this is rebased with a master from this morning.
I had to resolve some conflicts due the older PR and changes.
Still polishing the miq-bot issues.

@abonas This is rebased and travis looks fine.
Please, can you lead it for merging ?
Thanks.

@miq-bot assign @blomquisg

@blomquisg @chessbyte anything else is needed in your opinion before it can be merged? imo it is ready, and there are several other PRs depending on this one...


Would you mind doing a brief screencast on how to setup and use caddy-hugo?

Would you mind doing a brief screencast on how to setup and use caddy-hugo? It would be extremely helpful to see how you install and setup and use Hugo for Caddy.

Sure thing.  I'll try and have one up by wednesday.  Here's what I consider the most important things:

Get caddy with hugo from (http://caddy.org)[caddy's] web site

Hello @bzerangue! Like to hear that someone is using (or trying to use) caddy-hugo! Hope you enjoy and hope @faddat can help! Thanks for helping @faddat :)

Sure thing!  Thinks for the awesome tool, @hacdias!

You're welcome :D

With Docker, it's easy.

Awesome!
On Wed, Feb 24, 2016 at 8:02 PM, Jacob Gadikian<EMAIL_ADDRESS>wrote:
Screencast coming some time this hour :).
—
Reply to this email directly or view it on GitHub
[https://github.com/hacdias/caddy-hugo/issues/50#issuecomment-188560293] .[https://github.com/notifications/beacon/AABqG8-OdBfjgAO2CsPvrwebhPwKF2Jcks5pnlg7gaJpZM4HfPgT.gif]

@ozzadar has been making awesome videos on windows lately-- anyone know a great video editor for Linux?  Goal:  "out-class Corel Video"

Maybe one hour from now.... work.....
On Feb 25, 2016 9:03 AM, "Brian Zerangue"<EMAIL_ADDRESS>wrote:

Awesome!
On Wed, Feb 24, 2016 at 8:02 PM, Jacob Gadikian<EMAIL_ADDRESS>wrote:
Screencast coming some time this hour :).
—
Reply to this email directly or view it on GitHub
[https://github.com/hacdias/caddy-hugo/issues/50#issuecomment-188560293]
.[
https://github.com/notifications/beacon/AABqG8-OdBfjgAO2CsPvrwebhPwKF2Jcks5pnlg7gaJpZM4HfPgT.gif]
—
Reply to this email directly or view it on GitHub
https://github.com/hacdias/caddy-hugo/issues/50#issuecomment-188560399.

Does anyone have a good guide for doing screencasts?  I've made this one twice now but it takes an hour to show what shouldn't be longer than 15 minutes....

I've never done that so I can't help you with that :(

I'll close this issue right now because of the lack of the activity on it. If you want to reopen it, just tell me. :+1:

I know this is 8 mos old, but I'd like to see this screencast. I've been reading through the issues and documentations, etc and I am still having some trouble getting caddy + hugo  hosted on github to work properly :(

Hello @liz-miller, if you really need it, I could do it in the weekend probably, but tell me: what have you already done and where is it failing? 🙂

I've completed the following:

installed Hugo
created a Hugo site & content
created a GitHub repo to host using gitpages
configured my domain to point to the GitHub pages URL
made my site live (www.queenflex.com)

Now what I want to do is add caddy-Hugo for the ability to blog anywhere.

It's probably something simple I'm missing...

On Feb 7, 2017, at 14:41, Henrique Dias<EMAIL_ADDRESS>wrote:
Hello @liz-miller, if you really need it, I could do it in the weekend probably, but tell me: what have you already done and where is it failing? 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

To use caddy-hugo you'll need to have it set up on your own server but it seems you're using Github Pages. Anyway, if you can send me the Caddyfile I can check if it has got any error related to hugo 😄

I see. Well that could be the reason for my problems. I didn't realize I couldn't host using github -_-

On Feb 7, 2017, at 14:54, Henrique Dias<EMAIL_ADDRESS>wrote:
To use caddy-hugo you'll need to have it set up on your own server but it seems you're using Github Pages. Anyway, if you can send me the Caddyfile I can check if it has got any error related to hugo 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

You can host a Hugo website using Github Pages but you can't use Caddy + this plugin with github pages.

will Caddy + Caddy-Hugo work with hosting on AWS?

I'm not sure how does AWS work (never used it). But if it's like a VPS it will work for sure.


Search f

I don't have anything to write but you have to enable the search function!

Yep, it's a mandatory feature and should have a  high priority.

@lisaraj2009 @R3voA3 Search is a very important feature, and is very high on our list. We are tracking this issue here #333.


Is it possible to encode more than one video at a time?

I have a Quadro p400 and an Nvidia 1080 ti on separate unraid servers.  I would like to encode multiple videos at one time as my graphics cards support up to 3 streams at a time. Is this possible?
Thank you for your hard work!

Currently, this container doesn't support Nvidia hardware encoding acceleration...

repeating my answer on the original thread, why not just start two docker containers of handbrake??
given upstream has not implemented it for more than 4years+ Isn't this what docker is for, orchestrating multiple instances of containers?


WIP: [nginx-ingress-controller] Add external authentication using auth_request

fixes #1492

This change is

Saw the related discussion on the bug, can you add an example of how to use this, and how that enables further integration with things like the oauth_proxy? (fine if you want to do this in a follow up)

I think your failure is legit
# k8s.io/contrib/ingress/controllers/nginx/nginx/authreq
controllers/nginx/nginx/authreq/main_test.go:86: t.Run undefined (type *testing.T has no field or method Run)

controllers/nginx/nginx/authreq/main_test.go:86: t.Run undefined (type *testing.T has no field or method Run)

oops I forgot to use go 1.6 features (t.Run is a new thing in 1.7)


New build-complete job for required checks

I'll change branch protection to build-complete afterwards.


optimize geometries default num_cpus should be 1

There is some evidence from experimentation on a test dataset that the optimize_geometries step performs best with a single core. Both the cumulative walltime (observed * n cpu) and even observed walltime are higher with more cores:

This phenomena should probably also be highlighted in the docstring

fixed in #77


Updated AMI IDs and changed repo source to ECR public in Dockerfile

Description of changes:
Updated AMI IDs and changed repo source to ECR public in Dockerfile
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

/do-e2e-tests


Fix webpack chunk loading with STATIC_URL_PREFIX (#11526)

Backport of https://github.com/go-gitea/gitea/pull/11526 to 1.12.

make lg-tm work


Recommend Error Messages distinguish between gateway and returned from peer

On Node If I have a problem with connection to a gateway from the client I get these messages
14 UNAVAILABLE: Connection dropped
1 CANCELLED: Call cancelled

I would be nice if these were qualified as coming from the gateway api as they look similar to errors returned by the gateway if the gateway had issues communicating with other nodes.
Assume this would be the same for Java and Go clients as well.

If the error had originated from another node, then it would be included in the 'details' section of the error that is returned by the gateway.  If the 'details' array is empty, then the error would have originated in the gateway.
That's the theory anyway - let me know if you find one that doesn't follow that pattern.
Proposed docs: https://andrew-coleman-fabric.readthedocs.io/en/gateway_doc/gateway.html#errors

@andrew-coleman In this case these errors originate from the client gateway, not the peer gateway I think it would be handy to be able to distinguish client side errors vs errors returned back by the gateway peer, useful for a support team for example

The gRPC UNAVAILABLE status code indicates that the service is currently unavailable, and is most likely a transient condition that you may be able to retry. That should remain true whether the point of failure was the client connection to the Gateway peer, or some outage at the server end preventing the Gateway peer from invoking services on other nodes, so I think this behaviour is reasonable.
If you are seeing UNAVAILABLE returned for conditions where a retry would be inappropriate, or status codes other than UNAVAILABLE returned for conditions where a retry would be appropriate, that is a problem that should be fixed.

Relates to this gRPC issue: grpc/grpc-go#3328


Make indicator of Tor offline when http listener is on "Local and Internet"

Currently when the HTTP listener is configured on "Local and Internet", Users can't receive on the wallet via TOR but the tor indicator is in green which mislead the user, letting him thinking he can receive via tor.
I'm proposing to switch the indicator of Tor to offline when http listener is on "Local and Internet". And print to the users that he need to switch to "Local Service" or make it automatically if he starts TOR listener.

Tor with Local and Internet works fine with current release

Just tested all http setting vs tor. I don't see any issues. UI direct user for all edge cases

@bayk, Verified with the latest build and observed that the TOR listener status is green while HTTP listener is configured with "Local and Internet".

@Viv-dev-mwc ,  Tor is expected to work for "Local and Internet".  That what we want

For me also TOR is activated when I switched to local & internet...Closing as per the above comment.


Run pre-commit in parallel

Because I don't like waiting for things, and neither should you.

Landed in #1571


Errors take 3

This is the 3rd take at creating a unified Exception in the DruidException.  Given that I had input on the previous two attempts, I figured I'd take the next stab at offering something that matches the input that I had provided.
DruidException and ErrorResponse have class level javadoc discussing how it's all setup and why, so I would recommend starting there.  Then branch out and look at some of the points where DruidExceptions are created (DruidPlanner and various of the other places).
There is a compatibility layer in this PR that tries to continue mimicing the old way that QueryException was getting serialized out, but the current PR treats that as best-effort.  Specifically, anything that started its life as a DruidException will be an "unknown" error type when serialized back as a QueryException.  The error message should make it through, but the type characterization will be different.  This should only happen in the middle of roll-forward/roll-back processes, so it will be short-lived and, given that it preserves the message, is hopefully a decent compromise.
Additionally, as I was adjusting tests, I got tired of the SQL tests taking roughly 5 minutes to run through the entire suite, so I looked into why it was doing that and through moving some initialization around and fixing some time-based async tests to be based on latches instead, was able to get that timing down to ~1.5 minutes, so some of those changes are mixed in here as well.
Release note
A new unified exception for surfacing errors to users has been introduced.  It is partially compatible with the old way of reporting error messages, response codes remain the same, all fields that previously existed on the response will continue to exist and be populated, including the errorMessage.  But some error messages have changed to be more consumable by humans and some cases will have the message restructured.  Any clients that are actively looking at the error message to make decisions on what to do should explore the changes to the error messages that they care about, but if all a client looks at is the response code, there should be no impact.
This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@abhishekagarwal87
On your suggestion about encouraging an action be included.  You gave a great example that explains what this PR is all about.  Specifically, think of this error message
org.apache.druid.java.util.common.ISE: No default server found!

If someone said that it was "Persona.USER", I would hope that the reviewer would be like, "uhhh, why will a user know what a default server is?  Your message is not well aligned with your persona" and ask for the message to be updated.
If I were to adjust that exception to this new model and not change the message, I would likely make it Persona.DEVELOPER because it's so obtuse, only a developer would be able to actually make sense of what it means.  Of course, the exception is actually happening at a point where there is some behavior that is meaningful for the end user.
We could adjust the message to be an ADMIN persona message and say
Router unable to find a broker, check that brokers are up and active

Or a USER persona message and say
Cannot find a queryable server, contact your cluster administrator to validate that all services are operational

Both of these include an action, like you suggest, but that action becomes apparent and clear once we actually identify the persona.  My hope is that by identifying the persona, reviewers will start to validate that the exception messages align with the intended persona and we all police each other for creating good error messages.  I.e. I'm hoping that just identifying the persona is enough to help us do better.
Alternatively, for USER-facing messages, I could add the requirement for yet-another field which is "potential actions" (or something similar) which should be populated with a message describing actions that can be taken.  I'd personally like to keep it to just a message and code-review based policing.  But I'm also willing to add the field if I'm in the minority...
Tagging other people whose name also appears in the conversation part of this PR to see if there are opinions one way or the other: @gianm @kfaraz @clintropolis

Now I am also wondering how we will pick a persona :) For example, in this case, I would like to tell the user that you really need to go and check the logs of the broker service. The action of checking error logs is something that an admin persona can do. But most people when they are setting up druid for the first time, are end-users as well as an admin. The error occurs directly in response to something that an end-user is doing.
I can return a user-persona-facing error saying that "Contact your cluster administrator to make sure that services are operational" but it's difficult for new users to figure out where to go from there.
So, in this case, maybe we return an error message meant for the admin persona even though this error is in user-initiated request-response path. We leave it to cluster admins if they want to filter messages that match admin persona, in case they are not exposing druid directly. For a new user setting up druid for first time, however they will get all these messages unfiltered. If you have something similar in mind, we should ideally document that developers should avoid adding potentially sensitive information in messages that are meant for user persona.

@abhishekagarwal87 once again, you've provided a great example!  Essentially, you went through the thought process that I'm hoping we can just do as a part of every exception message that we generate.
In this case, making it ADMIN-focused and having more details about server names and stuff makes a lot of sense to me.  And the argument that someone who is trying to "hide" Druid should be able to siphon off this message makes a lot of sense to me too.  So, I think that I'm now convinced that the message in question should be targeting the ADMIN persona and specifically mention that you should check that the brokers are up and running.
To me, this type of conversation, back-and-forth and your eventual conclusion is the whole goal of the adjustments to the error messages.  And, once we change that exception to be ADMIN focused, the code will include the fact that this is an ADMIN-focused message.  So any future person who comes across it can clearly see the intentions of who gets the message and why, if they feel the message needs updating, they can have their own internal dialog and motivate their feelings by either saying it should target a different persona OR it needs more details to target the current persona.
So anyway, I think that yes, you are thinking along the same lines that I'm thinking at this point.  I'm all for adding documentation about whatever, but I'm unclear on where you think it would be added for the most impact.  Ultimately, this has to become part of the culture of the project rather than be a pure documentation thing, but I can document it anywhere you think it can help ;)

Re culture, I agree. I think we add these bits in the APIs javadocs, that should be more than enough. And then reviewers can just say, "The error message isn't so great. please read the javadocs for reference"

Okay, had a clean bill. Aside from some static checks.  Going to push those up.  @abhishekagarwal87 @clintropolis I'd love to get this merged today or tomorrow if possible, please do what you need to do to feel comfortable approving.

also, should there be any web-console changes to go with the adjustments to error response?

The last run of the tests was near complete (there processing tests for jdk11 and jdk17 still running, everything else, including ITs had passed), so I went ahead and merged instead of risk another set of conflicts cropping up and causing yet another CI run.


update the server.js file

File is still a copy of an in class assignment. Needs some more required dependencies and sessions/cookies setup.
In order to do this you will also need to put a secret key in the .env file.

completed


Contact form gets 401 error

Is this a BUG REPORT or FEATURE REQUEST?:
bug (or user problem?)
What happened:
After setting up the Contact fragment for use with Formspree, I'm getting a 401 error from Formspree that includes "Referrer Policy:no-referrer-when-downgrade".  This is from my site that's hosted on Gitlab Pages, not just when served via localhost.
What you expected to happen:
To not get the 401 error and for Formspree to process my request
How to reproduce it (as minimally and precisely as possible):
I copied the contact.md from the example site (exampleSite/content/dev/blog/_index/content.md), modified it by commenting out the "post_url", putting my address in "email", setting "netlify" to false, and commenting out the [recaptcha] section.
Anything else we need to know?:
I'm sure I'm missing something, I just can't figure out what.  Any help is appreciated.
Environment:

Syna Theme version:  15.0
Hugo version:  58.2
Others:

So it turns out that if I remove all of the data-validation, data-validation-regex, and data-validation-error-msg modifiers to the  tags, Formspree works as expected.  Is there any way to get the data validation checks working with Formspree?


core dump used with timm 0.3.2

🐛 Bug
core dump used with timm 0.3.2 and pytorch 1.8.1
Please reproduce using the BoringModel
import torch
import timm
import pytorch_lightning as pl

Run above code, it will core dump.
import torch
import pytorch_lightning as pl
import timm

However, run this code, it's ok.
To Reproduce
Use following BoringModel and post here

Expected behavior
Both codes should be ok.
Environment
Note: Bugs with code are solved faster ! Colab Notebook should be made public !

IDE: Please, use our python bug_report_model.py template.

Colab Notebook: Please copy and paste the output from our environment collection script (or fill out the checklist below manually).

You can get the script and run it with:
wget https://raw.githubusercontent.com/PyTorchLightning/pytorch-lightning/master/tests/collect_env_details.py
# For security purposes, please check the contents of collect_env_details.py before running it.
python collect_env_details.py

CUDA:
- GPU:
- GeForce RTX 2080 Ti
- available:         True
- version:           10.2
Packages:
- numpy:             1.18.5
- pyTorch_debug:     False
- pyTorch_version:   1.8.1+cu102
- pytorch-lightning: 1.2.8
- tqdm:              4.55.0
System:
- OS:                Linux
- architecture:
- 64bit
- ELF
- processor:         x86_64
- python:            3.8.5
- version:           #75~18.04.1-Ubuntu SMP Tue Feb 23 19:17:50 UTC 2021

Additional context

import torch
import albumentations
from albumentations.pytorch.transforms import ToTensorV2
import pytorch_lightning as pl
import timm

And this will core dump too
albumentations              0.5.2

import torch
import timm
import pytorch_lightning as pl

no issue for me :(
Both with timm==0.3.2 (as reported) and latest 0.4.
Try to install a fresh environment with only torch, timm, and lightning?

CUDA:
- GPU:
- GeForce RTX 3090
- GeForce RTX 3090
- GeForce RTX 3090
- GeForce RTX 3090
- GeForce RTX 3090
- GeForce RTX 3090
- GeForce RTX 3090
- GeForce RTX 3090
- available:         True
- version:           11.1
Packages:
- numpy:             1.20.2
- pyTorch_debug:     False
- pyTorch_version:   1.8.1+cu111
- pytorch-lightning: 1.3.0rc2
- tqdm:              4.60.0
System:
- OS:                Linux
- architecture:
- 64bit
- ELF
- processor:         x86_64
- python:            3.8.8
- version:           #64-Ubuntu SMP Wed Dec 9 08:16:25 UTC 2020

yes, it's fine, thanks


Starting roscontrol_sot_talos with start_talos_gazebo_16_04.py not working

Starting the SoT with TALOS in gazebo is not working in 16.04 in latest binary release.

It's not working in 18.04 either. ref https://github.com/stack-of-tasks/talos_integration_tests/issues/3

oops, that is actually another issue, my bad.


Changed GitHubClient.prototype.maxFileSize to 50MB

Solves #2755

Changed in dev repo, thanks for suggestion.


I18n::InvalidLocale error when :en is not included in config.i18n.available_locales

It's not a bug, but possibly a new feature! 😄
My issue:
I'm building a French-only application with solid_errors and I get this error I18n::InvalidLocale.
My application will be available in different languages, but for now, the only locale available is :fr.
In solid_errors the locale is forced in the ErrorsController by around_action :force_english_locale!
I patched it with this initializer, added the locale keys to my locale file and everything works fine:
Rails.application.config.to_prepare do
  SolidErrors::ErrorsController.class_eval do
    skip_around_action :force_english_locale!
  end
end

My suggestions:
I think about two solutions :

Changing the hardcoded :en locale and rely on the application's default locale.
Add the SolidErrors configuration to manually set the locale with :en as fallback.

Let me know if this feature catches your attention, I'm ready to help.

Hmm... You are right, I don't love this. That change originated with PR #36 which was added to avoid missing translations:

because the engine is using the custom "datetime.distance_in_words.short" translation set, which doesn't exist on rails-i18n.

So, what we need, I think, is a localization flexible approach to the views. But I would love to make the localization story in Solid Errors much better, and I am happy to see your take on it.


How to Run InputDataFrameExample

In order to test InputDataFrameExample , i tried  to run this cmd on cypher-for-apache-spark folder :
mvn scala:run -DmainClass=spark-cypher-examples.src.main.scala.org.opencypher.spark.examples.DataFrameInputExample

but i get this exception :
 [INFO] --- scala-maven-plugin:3.2.1:run (default-cli) @ okapi ---

  java.lang.ClassNotFoundException: spark-cypher-  examples.src.main.scala.org.opencypher.spark.examples.DataFrameInputExample
  at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
  at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
  at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
  at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
  at scala_maven_executions.MainHelper.runMain(MainHelper.java:154)
  at scala_maven_executions.MainWithArgsInFile.main(MainWithArgsInFile.java:26)
  [INFO] ------------------------------------------------------------------------
  [INFO] Reactor Summary:
  [INFO]
  [INFO] Okapi - openCypher query compilation API and pipeline 1.0.0-SNAPSHOT FAILURE [ 11.993 s]

so how to run DataFrameInputExample ?

Try mvn scala:run -DmainClass=org.opencypher.spark.examples.DataFrameInputExample inside of the spark-cypher-examples folder. I really recommend you give IntelliJ a try, that's a lot more convenient.

You need to run mvn install on the main project so the examples module finds the dependencies for the other modules.

Do you have an existing Hadoop installation that might have a version conflict?
Vijay @ StackOverflow:
This error generally occurs due to the mismatch in your binary files in your %HADOOP_HOME%\bin folder. So, what you need to do is to get hadoop.dll and winutils.exe specifically for your hadoop version.

Get hadoop.dll and winutils.exe for your specific hadoop version and copy them to your %HADOOP_HOME%\bin folder.

what i have is C:/winutils/bin/winutils.exe and i set that in the Path  to be able to use spark.

Is the Hadoop version compatible?

AFAIK Spark 2.2.1 that we use in out tests depends on Hadoop 2.6.5

i have put a hadoop.dll  with the same version as winutils.exe in the Hadoop_home path.
now the previous error disappear and new errors in test function appears:
1.
  org.opencypher.spark.api.io.csv.HdfsCsvDataSourceAcceptance *** ABORTED ***
   java.lang.NullPointerException:
   at java.lang.ProcessBuilder.start(ProcessBuilder.java:1012)
  at org.apache.hadoop.util.Shell.runCommand(Shell.java:483)
 at org.apache.hadoop.util.Shell.run(Shell.java:456)
 at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722)
 at org.apache.hadoop.util.Shell.execCommand(Shell.java:815)
 at org.apache.hadoop.util.Shell.execCommand(Shell.java:798)

     2018-07-19 18:56:53,538 WARN  [ScalaTest-main-running-EdgeListDataSourceTest]  streaming.FileStreamSink (Logging.scala:logWarning(66)) - Error while looking for metadata directory.
- should return the test graph *** FAILED ***
  java.lang.IllegalArgumentException: Pathname /C:/Users/Ahmed/AppData/Local /Temp/caps_edgelist_15320193128256615490085103964651edgelist from hdfs://<IP_ADDRESS>:59876/C:/Users/Ahmed/AppData/Local/Temp/caps_edgelist_15320193128256615490085103964651edgelist is not a valid DFS filename.
 at org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:197)
 at org.apache.hadoop.hdfs.DistributedFileSystem.access$000(DistributedFileSystem.java:106)
 at org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:1305)
 at org.apache.hadoop.hdfs.DistributedFileSystem$22.doCall(DistributedFileSystem.java:1301)
 at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81

org.opencypher.spark.api.io.csv.MultipleFilesPerTableDataSourceAcceptance *** ABORTED ***
  java.lang.NullPointerException:
 at java.lang.ProcessBuilder.start(ProcessBuilder.java:1012)
 at org.apache.hadoop.util.Shell.runCommand(Shell.java:483)
 at org.apache.hadoop.util.Shell.run(Shell.java:456)
 at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722)
 at org.apache.hadoop.util.Shell.execCommand(Shell.java:815)
at org.apache.hadoop.util.Shell.execCommand(S

 DefaultFileSystemTest:
  - creates a data source root folder when it does not exist yet *** FAILED ***
  java.lang.IllegalArgumentException: Pathname /C:/Users/Ahmed/AppData/Local  /Temp/junit5746941656606926400/someNewFolder1/someNewFolder2 from C:/Users/Ahmed/AppData/Local/Temp/junit5746941656606926400/someNewFolder1/someNewFolder2 is not a valid DFS filename.
  at org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:197)

   LocalCsvDataSourceAcceptance:
   org.opencypher.spark.api.io.csv.LocalCsvDataSourceAcceptance *** ABORTED ***
   java.lang.IllegalArgumentException: Wrong FS: file://C:\Users\Ahmed\AppData\Local   \Temp\junit7578503280587451291, expected: hdfs://<IP_ADDRESS>:59876
   at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:647)

   org.opencypher.spark.api.io.csv.MultipleFilesPerTableDataSourceAcceptance *** ABORTED ***
   java.lang.NullPointerException:
  at java.lang.ProcessBuilder.start(ProcessBuilder.java:1012)
  at org.apache.hadoop.util.Shell.runCommand(Shell.java:483)
  at org.apache.hadoop.util.Shell.run(Shell.java:456)
  at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722)

Run completed in 1 hour, 32 minutes, 3 seconds.
Total number of tests run: 805
Suites: completed 71, aborted 3
Tests: succeeded 803, failed 2, canceled 0, ignored 35, pending 0
*** 3 SUITES ABORTED ***
*** 2 TESTS FAILED ***

Can only give a quick reply: it seems that the temporary directory used by JUnit in Windows contains spaces in a folder name, which I think disallowed by HDFS. Can't look into it atm, but I think it would be most promising to look into changing the temporary directory used by JUnit. Alternatively we could look into if there's a way to convert the JUnit directory name with spaces to a valid HDFS directory. Or use a different way to generate a temporary directory.

That means the project can't be useful on win 10 environment for this month ?

The Same thing happen with Intellij IDEA on windows 10 ; with intellij IDEA's Terminal

there is no run as scala application in Intellij IDEA

Do you have the Scala plugin installed?

finally after the mvn clean install success in #566 mvn scala:run -DmainClass=org.opencypher.spark.examples.DataFrameInputExample success too :
 [INFO] ------------------------------------------------------------------------
 [INFO] BUILD SUCCESS
 [INFO] ------------------------------------------------------------------------
 [INFO] Total time: 02:42 min
 [INFO] Finished at: 2018-07-25T01:00:01+01:00
 [INFO] Final Memory: 39M/427M
 [INFO] ------------------------------------------------------------------------

i won't close this issue yet because i still have question on how that works with neo4j

Hi @pstutz ,
in #549 you told me that in order to store the graph created i need to add this lines to the code :
val neo4jDS = GraphSources.cypher.neo4j(yourNeo4jConfig)
  neo4jDS.store(Neo4jPropertyGraphDataSource.defaultGraphName, yourGraph)

but i really  didn't understand what you mean by the Neo4j Config is it the password ??

i have asked that question on slack and they answered me for the Neo4j Configurations:
import java.net.URI
import org.opencypher.spark.api.io.neo4j.Neo4jConfig
val boltURI: URI = new URI("bolt://<IP_ADDRESS>:7687")
val neo4jConfig: Neo4jConfig = new Neo4jConfig(boltURI, "my_user_name", Some("my_password"), true)
i have added that to the code, now the problem comes from the code you suggested :
Cannot resolve 'GraphSources'
Cannot resolve 'store'
Cannot resolve 'Neo4jPropertyGraphDataSource'
is there some missing imports that i need to add ?

Again thanks to the help i get from slack i could resolve my problem of imports and connections to Neo4j with this code :
 import org.opencypher.spark.api.CAPSSession
 import java.net.URI
 import org.opencypher.spark.api.io.neo4j.Neo4jPropertyGraphDataSource
 import org.opencypher.spark.api.io.neo4j.Neo4jConfig
 import org.opencypher.okapi.api.graph.GraphName

 val session: CAPSSession = CAPSSession.local()

  val boltWriteURI: URI = new URI("bolt://localhost:7687")

  val neo4jWriteConfig: Neo4jConfig = new Neo4jConfig(boltWriteURI, "neo4j", Some("my_password"), true)

  val neo4jResult: Neo4jPropertyGraphDataSource = new   Neo4jPropertyGraphDataSource(neo4jWriteConfig)(session)

 val neo4jResultName: GraphName = new GraphName("neo4jgraph");

 neo4jResult.store(neo4jResultName, yourGraph);

Now i can store and visualize the  graph created with from dataframe in Neo4j . 👍


Complex_Calculator 258092

The functions are added and modified in src, inc folders.

Good implementation with few changes required. Do the suggested changes and add only the link to your repo under the README.md file and Create a PR.
Thank you
Bharath

Good implementation with few changes required. Do the suggested changes and add only the link to your repo under the README.md file and Create a PR.
Thank you
Bharath

Closing this PR as I have added your solution to README file.


Unable to connect and getting the error as attached.

Unable to connect and getting the error as attached.

![Login error](https://github.com/user-attachments/assets/e666771e-18d3-422c-972c-dcf73b5e8c9e)

Context
Version

Code for IBM i version
2.13.0

Visual Studio Code version
1.93.0

Operating System
win32_x64

Active extensions
Code for IBM i Walkthroughs (vscode-ibmi-walkthroughs): 0.5.0
Configuration Editing (configuration-editing): 1.0.0
Emmet (emmet): 1.0.0
Extension Authoring (extension-editing): 1.0.0
Git (git): 1.0.0
Git Base (git-base): 1.0.0
GitHub (github): 0.0.1
JSON Language Features (json-language-features): 1.0.0
Merge Conflict (merge-conflict): 1.0.0
NPM support for VS Code (npm): 1.0.1
Node Debug Auto-attach (debug-auto-launch): 1.0.0
TypeScript and JavaScript Language Features (typescript-language-features): 1.0.0

Not connected 🔌

were you able to connect to the server via SSH from a Terminal (command terminal for windows) using the command SSH username@servername ?

Hi,
I have tried with putty and I am getting an 'Access denied' message.
My admin team member was able to login, so I'm not sure what the issue here.
Thanks,
Madan
On Wed, Sep 25, 2024 at 11:48 AM Madan Gunasekaran <
@.***> wrote:

I have not tried it yet but, will let you know.
On Wed, Sep 25, 2024 at 10:05 AM Sathish Kumar @.***>
wrote:

were you able to connect to the server via SSH from a Terminal (command
terminal for windows) using the command SSH @.*** ?
—
Reply to this email directly, view it on GitHub
https://github.com/codefori/vscode-ibmi/issues/2270#issuecomment-2374361809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLR5OF532VEJUFMN7FKF4ITZYLGMVAVCNFSM6AAAAABOZJCHSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZUGM3DCOBQHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Duplicate test execution with monorepo/workspace setup

Describe the bug
Using VSCodes xxx.code-workspace file and setting the ROOT folder up as well, leads to vitest running the tests twice.
[INFO 2:51:23 PM] Tests run start
[INFO 2:51:23 PM] [Workspace "ROOT] Run tests from workspace
[INFO 2:51:23 PM] [Execute Vitest] /myproject/node_modules/.bin/vitest /myproject/frontend/src/editor/complete4.test.ts -t options default functions
[INFO 2:51:23 PM] [Workspace "frontend] Run tests from workspace
[INFO 2:51:23 PM] [Execute Vitest] /myproject/node_modules/.bin/vitest /myproject/frontend/src/editor/complete4.test.ts -t options default functions
[INFO 2:51:23 PM] Start api process at port 61934
[INFO 2:51:23 PM] [RUN] /myproject/node_modules/.bin/vitest /myproject/frontend/src/editor/complete4.test.ts -t options default functions
[INFO 2:51:23 PM] [RUN.cwd] /myproject
[INFO 2:51:23 PM] Start api process at port 61935
[INFO 2:51:23 PM] [RUN] /myproject/node_modules/.bin/vitest /myproject/frontend/src/editor/complete4.test.ts -t options default functions
[INFO 2:51:23 PM] [RUN.cwd] /myproject/frontend

With this .code-workspace it runs the tests twice as shown above:
{
  "folders": [
    {
      "name": "ROOT",
      "path": "../"
    },
    {
      "name": "backend",
      "path": "../backend"
    },
    {
      "name": "frontend",
      "path": "../frontend"
    }
  ],
  "settings": {}
}

If I remove the ROOT folder the tests are only executed once.
To Reproduce
See setup above. Create a (npm) monorepo with vscode workspaces setup while including the ROOT folder as well.
Use the VSCode extension to run in test in a submodule.
Expected behavior
Shouldn't run the tests two times.
Screenshots
n/a
Environment

OS: macOS
VSCode version: 1.82.2
Vitest version: 0.34.4
Vitest plugin version: v0.2.42

Additional notes
As a side effect it seems to produce https://github.com/vitest-dev/vscode/issues/47 sporadically.

I'm facing the same issue.

This should be greatly improved with #241, #232 and #231. I no longer get these issues.

Let's re-open this if it re-occurs for someone.


[SPARK-33812][SQL] Split the histogram column stats when saving to hive metastore as table property

What changes were proposed in this pull request?

Hive metastore has a limitation for the table property length. To work around it, Spark split the schema json string into several parts when saving to hive metastore as table properties. We need to do the same for histogram column stats as it can go very big.
This PR refactors the table property splitting code, so that we can share it between the schema json string and histogram column stats.
Why are the changes needed?

To be able to analyze table when histogram data is big.
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing test and new tests

cc @wzhfy @wangyum

Test build #132898 has started for PR 30809 at commit ed0dee1.

Test build #132898 has finished for PR 30809 at commit ed0dee1.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37500/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132898/

Test build #132930 has started for PR 30809 at commit e161298.

Test build #132930 has finished for PR 30809 at commit e161298.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37533/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132930/

Test build #132944 has started for PR 30809 at commit 0722f60.

Test build #132947 has started for PR 30809 at commit 4e8e984.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37547/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37550/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37550/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37550/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37547/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37547/

Test build #132947 has finished for PR 30809 at commit 4e8e984.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132947/

Test build #132944 has finished for PR 30809 at commit 0722f60.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132944/

Test build #132955 has started for PR 30809 at commit ef4358d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37558/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37558/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37558/

Test build #132955 has finished for PR 30809 at commit ef4358d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132955/

Test build #132996 has started for PR 30809 at commit 7ea6d8b.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37595/

Test build #132996 has finished for PR 30809 at commit 7ea6d8b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132996/

retest this please

Test build #133020 has started for PR 30809 at commit b1c9e78.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37619/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37619/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37619/

Test build #133020 has finished for PR 30809 at commit b1c9e78.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133020/

Merged to master.


Fix: receiving unknown flag --api, switched to --web flag to end web …

…backend

What does this PR do?

Fixes the example for quickstart. When running docker-compose received this error:
Error parsing command: unknown flag: --api
Error here : unknown flag: --api

Changed to --web flag instead
Motivation

More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

Thanks for your interest in Traefik 😃
I think you are using an old version of Traefik (<1.4).
--web is deprecated sine 1.4 when --api has been added.
Try to pull a new version: docker pull traefik:1.5


[0.12.3] M7 Update: Catacombs level above 50

Description
Closes #1168
Examples

@DuckySoLucky if you can merge/do this https://github.com/DuckySoLucky/SkyCrypt/pull/2 then for me this is ✅

@DuckySoLucky if you can merge/do this DuckySoLucky#2 then for me this is ✅

Forgot about that, ty


nocode -V

The best way to write secure and reliable issues. Write nothing; deploy nowhere.

Nocode CLI: nothing
Nocode Web: nothing
Nocode Components: nothing


Git bash exe path select is not clear

It's not clear why the whole settings modal is opened if app only asks for the git bash exe path to be specified.
Suggestion: Ask for the git bash exe path on the first App run, not on the first cammand run.
Suggestion: Check if selected exe is a real Git bash exe.

Suggestion: Check if selected exe is a real Git bash exe.
Was converted to TODO in the code.


pull request for e2e test at 12/26/2016 09:45:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Calling PropTypes validators directly is not supported by the prop-types package.

Gertting this error in console with Linkify:

Warning: Failed propType: Calling PropTypes validators directly is not supported by the prop-types package. Use PropTypes.checkPropTypes() to call them. Read more at http://fb.me/use-check-prop-types Check the render method of Readmore.

My code:

                         <Linkify properties={{target: '_blank'}}>
{'Lorem ipsum dolor sit amet, postea scripta accusam in vel, duo at eros simul appareat, nam ei accusam adipisci reformidans. Duo fabulas moderatius contentiones in, cu vis duis oportere. Eum paulo assentior et. Semper integre ei quo, ius et semper vidisse tibique.Dicta perpetua gloriatur has et, te nostro electram efficiantur eum. Ius minim causae honestatis an, nam id vide duis probo, congue libris cu eos. No usu habeo forensibus, at nam evertitur torquatos. Moderatius accommodare ad nec. Essent apeirian eu vix, ne everti civibus salutatus vix. Ea eros ferri est, sit aliquando contentiones cu. http://google.com'}
                         </Linkify>

However it works but the console error is annoying.

Could you please provide a github repo that reproduces the issue?

same here - react 0.14.3 and linkify 0.2.1. will try to reproduce when i have a second

You can try to use codesandbox.io if it helps

Guau, qué herramienta impresionante Pablo!
Anyway yes, I could easily recreate this. I thought it might have had to do with using the properties prop of Linkify but it doesn't seem so.
https://codesandbox.io/s/66x8qk4ER?module=%2FHello.js

@pablolmiranda https://stackblitz.com/edit/react-ebfaso

@ledhed2222 @robertftw, found the issue.
The problem here is the prop-types module is not build to work with a React <= 15.5.0.
To not see this error anymore you need to update your React to version >= 15.5.0.


Use b"" instead of bytes(). Don't use str on a string.

Description
https://docs.astral.sh/ruff/rules/native-literals/
Fixed using
ruff check --exclude="script*" --exclude="tools*" --select "UP018" --fix

Performance improvements:
In [1]: %timeit b""
6.85 ns ± 0.222 ns per loop (mean ± std. dev. of 7 runs, 100,000,000 loops each)

In [2]: %timeit bytes()
41.1 ns ± 0.245 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

In [3]: %timeit "Azure"
6.75 ns ± 0.037 ns per loop (mean ± std. dev. of 7 runs, 100,000,000 loops each)

In [4]: %timeit str("Azure")
25.8 ns ± 0.124 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

Hi @atombrella thank you for the pr! For SB/EH this looks good to me
The CI failures seem to be pre-existing failures in the confidential-ledger pipeline.

@l0lawrence @kashifkhan Just to remind you, I do not have merge rights

/check-enforcer override
Pylint failure in confidential ledger is unrelated


User controller create

Hi team 👋!
In this PR I :

Setup routes for user.
Add the create action in the user controller.

Thanks for your time!

Hi @kensteph, the branch has conflicts... being the only branch to check out, do you want me to check it out first or after resolving the conflicts?

Hi @MarcoAurelioAntonio , yes you can check it out and let me know please


AttributeError: 'Adam' object has no attribute '_name'

I am having the above errro while running the dqn_cartpole example.
I am using the below versions
tensorboard                        1.13.1
tensorflow                         2.0.0b0
tensorflow-estimator               1.13.0
Keras                              2.3.0
Keras-Applications                 1.0.8
Keras-Preprocessing                1.1.0
keras-rl                           0.4.2
keras-rl2                          1.0.3
gym                                0.10.5
Please let me know what should be done as due to this issue I wont be able to utilize the DQNAgent in keras-rl

Hello! I haven't posted at all here but I got the same problem as you and recently and I solved it by downgrading a lot of packages though pip. You may want to give it a shot:
pip install keras==2.0.6
pip install numpy==1.16.4
pip install keras-rl==0.3.1
pip install tensorflow==1.13.1
You may get an error saying keras-rl requires tensorflow 2.0, but ignore it, the Cart example should run just fine.

I added a fake attribute called _name to the optimizer and the error disappeared.
from tensorflow.python.keras.optimizers import Adam
Adam._name = 'hey'
If it is only a name, It should not affect the operation of the package.

I added a fake attribute called _name to the optimizer and the error disappeared.
from tensorflow.python.keras.optimizers import Adam Adam._name = 'hey'
If it is only a name, It should not affect the operation of the package.

I added a fake attribute called _name to the optimizer and the error disappeared.
from tensorflow.python.keras.optimizers import Adam Adam._name = 'hey'
If it is only a name, It should not affect the operation of the package.
timothe, you are a certified life saver.


PP: Need to work out how we serve the need for applying for multiple permits

@kaydale Could you write some info about this please? I think you've thought about it a lot more than I have.

Actually this is a duplicate of #33 - Let's add thoughts there


[Bug] Custom CSS doesn't always load into editor

I've noticed from opening MarkEdit randomly from time to time that my custom CSS doesn't always load. Opening up a new file will almost always not have my custom CSS applied. The current remedy I'm using is opening a new file, save, quit, and then reopen MarkEdit. This seems to kick the custom CSS into applying. Unsure if this is a general issue, or something to do with iCloud syncing introduced in https://github.com/MarkEdit-app/MarkEdit/issues/537 (feel free to blame me 😂).
Not an urgent issue, just something I've noticed the last few times from opening the app. Thanks for making such a tight editor!

That's odd, I've granted access again but still seeing the issue. Screenshot here shows a saved file on the left and a new untitled file on the right. The inspector shows the CSS in the left but not in the right. Steps were:

Cold open MarkEdit
MarkEdit opens an untitled (unsaved) document. I have the following settings:

New Window Behavior: New Document
Window Restoration: Quit always keeps windows

Use Open Recent… to open the saved file which has the CSS applied

Maybe the difference here is the settings I have enabled? The untitled / unsaved doc maybe opening up before the CSS has a chance to be added?

Damn that was fast! Would you like me to test?

Can confirm works as expected. Nice one!


addon install: add must-gather option

Depends on https://github.com/RedHatQE/openshift-python-utilities/pull/297
Add must-gather-output-dir flag incase addon installation fails

/verified


Updating how we display messaging to unsupported browsers

Proposed changes
IE and Legacy Edge never actually displayed the messaging
because ember failed to bootstrap due to a 'define' is undefined
error.
This adds a script to our index.html which controls weather we'll
display the messaging or finish bootstrapping ember.
This also adds Chromium edge to the list of unsupported. We may
want to walk this back however.
Types of changes

Bugfix (non-breaking change which fixes an issue)

Linked Issues
rancher/rancher#27021
Further comments
IE

Legacy Edge

Edge

Firefox

Chrome

I've removed Chromium Edge and I've opened rancher/rancher#27802 to track the Edge investigation.

Surely nobody is regularly testing it, but the old engine Edge (which is Edge/?) used to work fine.  If someone wants to test that it's basically functional I don't see a need to hard block it.  But if major/obvious stuff is broken then it's not worth putting much time into fixing.
The Chromium-based current Edge (Edg/?) should definitely work and should be allowed in like any other chrome variant.
The error message could use more sad-ie.png.

@codyrancher when you're ready can you open a 2.4 pr as well? Ticket is targeted at 2.4.6.

Just FYI, commented out some lines in UI code.
Then UI works in old Edge work.
https://github.com/loganhz/ui/commit/09340f2232c5c1b54be95c5dd07f7e806940a50a

Isn't url-regex the thing you were looking at replacing anyway because of an unrelated problem @westlywright ?

IE and Legacy Edge never actually displayed the messaging because ember failed to bootstrap due to a 'define' is undefined error.

FWIW this obviously broke at some point, but it did actually work and show the page in the 1.x days at least.  A separate standalone script is a much better way to do it though.

I should've been more accurate and said it hasn't worked at least since July 2019 since that's as far back as I tested.


Create pull_request_template.md

Closes #48
Added a pull request template to standardise the contributions & PRs

Lgtm thank you for contributing


globalDifferent: different winner or different order?

globalDifferent is incremented if there are any differences in the final standings of the code, need to add a way to check solely for different winners.

different winner is detecting if candidate 'a' ranks differently, not if there are different winners


Single slide intro calculates wrong background color

If you create an activity with a single slide, the background color ends up some odd translucent semi-random color. Adding a second slide seems to fix it.
Adding enableLastSlideAlphaExitTransition(true) also fixes this problem.

https://github.com/TangoAgency/material-intro-screen/issues/64


Update ember-collapsible-panel for ember >= 3.3.0

Fixes #47
This PR updates the ember-collapsible-panel documentation in order to work properly in light of this issue: https://github.com/emberjs/ember.js/issues/16826
In short, p as an argument to blocks no longer works, so all usages have been update to use panel. This should help new users not be confused about why attempting to copy and paste from the docs doesn't work.

@iand675 Maybe we can separate the doc changes from the update changes?
They aren't dependent on each other.

@Alonski I don't understand why you'd want to? If the docs are wrong, then people can't effectively use the addon. In any case, they're separate commits so they'd show up separately when you merge the PR.

@samselikoff What do you say about getting this merged in?
I don't think the failing tests make sense. Can you rerun Travis?

@Alonski just kicked off the build again.
I'm realizing that we don't really use this addon, we inherited from when we built it at TED several years ago but at this point we're not really in a spot to be maintaining it. Would you have an interest in taking over maintenance?
If not we can start putting out a wider call to look for maintainers.

@samselikoff I'd love to take it over 😁 I think I offered to a few months ago.
I use it heavily in my apps.

Yes I remember! Sorry I have the short term memory of a fish.
I think at the time we had plans to do more maintenance but we’re trying to eliminate some things and refocus on others. Will get back to you soon.
Sent from my iPhone

On Apr 4, 2019, at 3:08 PM, Alon Bukai<EMAIL_ADDRESS>wrote:
@samselikoff I'd love to take it over 😁 I think I offered to a few months ago.
I use it heavily in my apps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@iand675 I have taken over maintaining the addon. Sorry but I made a few merge conflicts :)
Can you please merge/rebase and push again?

Closed via #60
Thanks @iand675 for the initial work!


Checkout returning code PY0001

When I try to do a checkout, its returning:
array:2 [▼
  "code" => "PY0001"
  "message" => "A problem is encountered. Please contact your system administrator."
]

It was working last time. I tried all of the API keys here: https://developers.paymaya.com/blog/entry/checkout-api-test-credit-card-account-numbers
But none of  them works.

Any update on this?

Any update on this?

Hi @akosibentoy ,
I tested this again and it's working now. Can you share your code here?
And what API keys are you using?
I'm using:
PUBLIC_API_KEY=pk-lNAUk1jk7VPnf7koOT1uoGJoZJjmAxrbjpj6urB8EIA
SECRET_API_KEY=sk-fzukI3GXrzNIUyvXY3n16cji8VTJITfzylz5o5QzZMC

@aceraven777 using that keys, mine is working now.

Hi @akosibentoy ,
I tested this again and it's working now. Can you share your code here?
And what API keys are you using?
I'm using:
PUBLIC_API_KEY=pk-lNAUk1jk7VPnf7koOT1uoGJoZJjmAxrbjpj6urB8EIA
SECRET_API_KEY=sk-fzukI3GXrzNIUyvXY3n16cji8VTJITfzylz5o5QzZMC

how did you got these keys?

We got it from the PayMaya site.
API Test Merchants and Test Cards: https://developers.paymaya.com/blog/entry/api-test-merchants-and-test-cards

@poldiwa
We got it from the PayMaya site.
API Test Merchants and Test Cards: https://developers.paymaya.com/blog/entry/api-test-merchants-and-test-cards

@aceraven777 thanks for the quick response, everything is working now.
if ever someone on the team can read this. the link on https://developers.paymaya.com/blog/entry/paymaya-checkout-faq#Keys is outdated


Number format for Y-axis data

I am Using Bar and  have number for data section which are shown against Y-axis.
How can I format the number display?
e.g For Y-axis when I have 2034 I want to display like 2,034.

I found the way using following:
ticks: {
callback: function(label, index, labels) {
return label.toLocaleString(navigator.language, { minimumFractionDigits: 0 });
}
}


Cannot read property 'length' of undefined

ERROR: Cannot read property 'length' of undefined
ERROR: If you think that this error shouldn't occur, please fill up bug report here: https://github.com/maciejtreder/ng-toolkit/issues/new
but my codes are true!

I just completed the angular tutorial Tour of Heroes (https://angular.io/tutorial). Then I tried to add the @ng-toolkit/universal and I got the same error.
Sad panda is sad.

I have the same issue. The package.json doesn't have the scripts for deploy
  "scripts": {     "ng": "ng",     "start": "ng serve",     "build": "ng build",     "test": "ng test",     "lint": "ng lint",     "e2e": "ng e2e",     "compile:server": "webpack --config webpack.server.config.js --progress --colors",     "serve:ssr": "node local.js",     "build:ssr": "npm run build:client-and-server-bundles && npm run compile:server",     "build:client-and-server-bundles": "ng build --prod && ng run website:server:production",     "server": "node local.js",     "build:prod": "npm run build:ssr",     "serve:prerender": "node static.js",     "build:prerender": "npm run build:prod && node dist/prerender.js"   },

In my new project when i am trying to add angular universal with this command ng add @ng-toolkit/universal i am getting the same error

Same here, any update on this ?

same issue for me

same issue for me

Just a poll, Have you guys installed serverless?
I observed that when I try to install universal after installing serverless it gives me the above error.
But I was able to install universal after uninstalling serverless and clearing node-modules. Everything worked perfectly.

+1

This bug among others shall be fixed with the next release.
Closing now for housekeeping purposes.


Schema-Registry JAAS config not set

Output of helm version:
Client: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:36:19Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
I've deployed a Kafka with SASL_SCRAM enabled and now I would connect my Schema-Registry to that broker. But when I deploy the helm script, it throws an Exception that the
java.security.auth.login.config is not set.
[main] ERROR io.confluent.admin.utils.cli.KafkaReadyCommand - Error while running kafka-ready. org.apache.kafka.common.KafkaException: Failed create new KafkaAdminClient 	at org.apache.kafka.clients.admin.KafkaAdminClient.createInternal(KafkaAdminClient.java:370) 	at org.apache.kafka.clients.admin.AdminClient.create(AdminClient.java:62) 	at io.confluent.admin.utils.ClusterStatus.isKafkaReady(ClusterStatus.java:138) 	at io.confluent.admin.utils.cli.KafkaReadyCommand.main(KafkaReadyCommand.java:150) Caused by: java.lang.IllegalArgumentException: Could not find a 'KafkaClient' entry in the JAAS configuration. System property 'java.security.auth.login.config' is not set 	at org.apache.kafka.common.security.JaasContext.defaultContext(JaasContext.java:133) 	at org.apache.kafka.common.security.JaasContext.load(JaasContext.java:98) 	at org.apache.kafka.common.security.JaasContext.loadClientContext(JaasContext.java:84) 	at org.apache.kafka.common.network.ChannelBuilders.create(ChannelBuilders.java:119) 	at org.apache.kafka.common.network.ChannelBuilders.clientChannelBuilder(ChannelBuilders.java:65) 	at org.apache.kafka.clients.ClientUtils.createChannelBuilder(ClientUtils.java:88) 	at org.apache.kafka.clients.admin.KafkaAdminClient.createInternal(KafkaAdminClient.java:346) 	... 3 more
Here's my values-override.yaml
kafka:   enabled: false kafkaStore:   overrideBootstrapServers: SASL_PLAINTEXT://cl-kafka:9092 sasl:   scram:     enabled: true     clientUser: "kafka-broker"     clientPassword: "kafka-broker-secret" configurationOverrides:   host.name: "cl-schema-registry"   zookeeper.sasl.enabled: false   kafkastore.security.protocol: "SASL_PLAINTEXT"   kafkastore.sasl.mechanism: "SCRAM-SHA-512"   kafkastore.connection.url: "cl-zookeeper:2181"
Can someone help me with this Issue/Configuration problem?

Hello @ebcFlagman,
it might be too late but we ran into the same issue. We had to set 2 ENV-Variables to get it working
The JAAS-Config file has to passed to the clients as system property java.security.auth.login.config. It can be derived from an env-variable
Actually there are 2 places where the jaas-config is needed
First in the kafka-ready command - that one needs it in KAFKA_OPTS. Second for the registry itself
You can set it in your helm-chart values
  schemaRegistryOpts: "-Djava.security.auth.login.config=/etc/kafka-config/kafka_client_jaas.conf"
This creates the required ENV-Vars

Thanks @iceman91176
I saw, that the helm chart has been updated and supports now my case.
Thanks anyway for your hint.


error in sample code

in the section Retrieve diagnostic activities in your tenant
the code sample is as follows
Get-RdsDiagnosticsActivities -TenantName
Diagnostics should not be plural
the correct command is
Get-RdsDiagnosticActivities -TenantName

@DeanCefola To assist you better on your query could you provide us with the link to the document you are referring to ?
In case your query in not related to document content, open a new forum thread either in MSDN or StackOverflow as it could be better place to get help on your scenario where the community members could provide their expert guidance to you based on their experience.

Sorry, thought I did
https://docs.microsoft.com/en-us/azure/virtual-desktop/diagnostics-role-service#retrieve-diagnostic-activities-in-your-tenant
and
https://docs.microsoft.com/en-us/azure/virtual-desktop/diagnostics-role-service#retrieve-detailed-diagnostic-activities


Remove external node dependencies

https://github.com/CesiumGS/cesium/pull/11773 should remove the need to list the external node dependencies. Once this is in this example can be updated to remove that configuration.

Closed by https://github.com/CesiumGS/cesium-webpack-example/pull/56


Setup automatic versioning

semver (git versioning)
automatically update assembly versions (or is this a bad idea, according to the .NET library FOSS docs?)
git tag
basically, a good strategy!

(Kind of related to #3)

Take a look at dotnet pack --version-suffix <VERSION_SUFFIX>

https://khalidabuhakmeh.com/a-dotnet-five-guide-from-idea-to-nuget-package


Player lock state prevents an item on inventory cursor from being automatically dropped on disconnect

The item on the player's inventory cursor should be dropped when the player closes an open inventory or disconnects. However, HuskSync prevents this behavior on disconnect as the DropItem event is cancelled when the player is locked for data saving. A special case ought to be added here to ensure the cursor item is properly dropped when the user disconnects/changes server.

When a user leaves, check if HumanEntity#getItemOnCursor is not empty, then drop it with World#dropItem

When a user leaves, check if HumanEntity#getItemOnCursor is not empty, then drop it with World#dropItem

Yeah, pretty much. Just have to be careful to not accidentally introduce duplication issues with this. PR's welcome!

The code from @ItsWagPvP works. You can close the issue


Chained HasNoNullFieldsOrPropertiesExcept should have the same effect as using it once

Summary
hasNoNullFieldsOrPropertiesExcept can be chained, hence, it looks like it should account for all the values on the different places where it is used before stating the result(s).
Example
@Test
void instantiate() {
  // Actor inherits id, createdOn, updatedOn, and version
  // filmActors is a member of Actor
  final Actor actor = new Actor("first-name", "last-name");
  Assertions.assertThat(actor)
      .hasNoNullFieldsOrPropertiesExcept("id", "createdOn", "updatedOn", "version")
      .hasNoNullFieldsOrPropertiesExcept("filmActors")
      .satisfies(it -> {
        Assertions.assertThat(it.firstName).isEqualTo("first-name");
        Assertions.assertThat(it.lastName).isEqualTo("last-name");
        // ...inherited fields
      });
}

If filmActors is placed on the first hasNoNullFieldsOrPropertiesExcept everything is fine.

By default AssertJ stops at the first failing assertion, to get a report will all failed assertions you have to use soft assertions https://assertj.github.io/doc/#assertj-core-soft-assertions.
Is that what you are looking for?


test: add integration test to check backend errors ends in adapter and k8s api errors

Closes https://github.com/newrelic/newrelic-k8s-metrics-adapter/pull/49
We want to check that when the NR backend returns an error response that is being reflected with an error in the metrics adapter. We also perform an API call that simulates the call a HPA would do to k8s, to check that it also ends up in error when there's no metric.
Note: This is kind a of a POC of the test to check if this makes sense at all. There are some missing points to address like code duplication, add table driven tests for different error status codes and a little refactor of some helpers.
More context here https://github.com/newrelic/newrelic-k8s-metrics-adapter/pull/49#issuecomment-1089070687

Add all the suggestions/improvements here 28f3107e43e4dcb0f2c3f47c75a629316a869165


Remove site identity parameter from SPO BYOK Commandlets

The "Customer Controlled Key" Feature in SPO no longer uses these parameters. The site identity is taken from the currently connected SPO site context.

Docs Build status updates of commit b4b5496:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Register-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Update-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b4b5496:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Register-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Update-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@tseward

@tseward

Docs Build status updates of commit b748fc3:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b748fc3:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b748fc3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Register-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Update-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b748fc3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Register-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Update-SPODataEncryptionPolicy.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Kateyanne Please merge this PR. Thanks

@Kateyanne Please merge this PR. Thanks


pure go lib for git

What do you think about https://github.com/src-d/go-git , i use it for some git operations like pull, clone and other and it works fine. As i know gogs work with git via adaptor package, so i can try to create replacement for git operations in pure go. Does this acceptable or not ?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/40402318-pure-go-lib-for-git?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

If it can entirely replace the git cli and doesn't depend on cgo I'm fine with that

take care about the performance ;)

Why go-git instead of https://github.com/libgit2/git2go ? Imo libgit2 is really good

Because it requires cgo and libgit.

The first version of Gogs is based https://github.com/gogits/git. We have tried to use pure Go. But it developments slowly and run slower than git command. If the https://github.com/src-d/go-git is full-featured and almost the same performance with git command, I prefer that.

It would be worth using an interface for git operations and support either pure-go implementation or libgit2, with a build tag. The sqlite backend is also cgit so I don't see why not allowing it in codebase...

Great idea, we indeed need an interface on go-gitea/gitea and let go-gitea/git become as the default implementation.

@lunny I'd rather put the interface in go-gitea/git and have the build-tag there TBH, otherwise we'd end up in a state where we need an interface in gitea, a wrapper for go-git and a wrapper for gitea/git

@bkcsoft How about mixed the two methods since https://github.com/src-d/go-git maybe not full-feature?

Hence the proposal for having both in the same repo (go-gitea/git), that way we can have commit_exec.go and commit_pure.go where we can, and only repo_merge_exec.go where src-d/go-git isn't viable 🙂

+1 for doing this in go-gitea/git

Continued from #1511
@strk

If I read correctly the code in its current version does not support merges ?

Yes.

See https://github.com/src-d/go-git
Also, are you suggesting to use this as one of the implementations of the go-gitea/git interface as proposed somewhere else or as the primary API for git work ?

My proposal was to use it as the primary API replacing go-gitea/git/
The approach using go-gitea/git as the interface is okay to me. But such abstraction can be eliminated in the long term.

Did you test performance compared to libgit ?

No. I assume it would have good, if not better, performance than other alternatives if the cgo overhead doesn't matter that much. But cgo does affect the developer experience to some extent.

A performance compare on a git sub command is welcome. For example, get releases page is too slow, if we use this library will retrieve better performance, it's great!

It should be fairly simple to test performance gains like this:

Add benchmark to current forking command
Add pure-go command with benchmarks
Run both benchmarks and compare

Just a heads-up: I actually made some effort in this direction, it is discussed in issue #491 along with links to my code and some performance numbers.

If I was to work on integrating gitea with https://github.com/src-d/go-git, where do I start?

@pjebs I think you could send PRs to https://github.com/go-gitea/git to instead git commands to pure go library. I think it's easier to do it step by step.

Incrementally implementing the exported APIs of https://github.com/go-gitea/git seems to be a good idea.

@pjebs Follow the suggestion by @typeless and @lunny. I already have a branch where I started doing that, so if you split the git module changes and gitea changes and help upstream it I'd be more than grateful. https://github.com/filipnavara/gitea/tree/perf-read

@pjebs I think there are some part has used https://github.com/src-d/go-git and @filipnavara contributed a lot. You can go to modules/git to find them.

since we use both (go-git and a git warper) and it doesn't look like go-git can take up for all git tasks I'll close this for now.
It can be reconsidered in the future if things change ...


Toggling data series off/on causes chart height to expand

Hello, I've noticed a bug with the chart legend toggling functionality. Specifically, if you toggle a data series off and then on again, the height of the chart increases by a few pixels when it's redrawn. This process repeats each time you toggle a series. You can see it in action on the examples page on the last few charts, though it seems to stop after a few times there. In my app, it keeps expanding for an infinite number of clicks. I haven't seen any errors associated with this. I'm using Angular 1.5.5 and the latest release of line-chart. I'm using D3 3.5.7.

Hi @danielbonnell, I fixed this by setting a fixed height for the container, like in the examples you linked to.
  width: 600px;
  height: 300px;
}```


Upgrade to Bevy 0.12

Seems pretty straightforward, thanks to the previous effort to delete most of the rendering code.

Completely forgot that the bevy-main branch exists.


🐞 [BUG] - Adding backtotop icon to the main web page

Issue Verification

[X] I have verified that this is a new bug report.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Describe the bug
Adding back to top icon will help in quick navigation from bottom of the page to top
Expected behavior
No response
Steps to reproduce
No response
Additional Context
@jfmartinz I would like to work on this issue

duplicate


Sync attribute on empty model field

Hi
Is it possible to add feature for syncing AD attributes only for empty field in laravel model?
Something like this in config:
'sync_attributes_on_empty' => [
    'mail' => 'email',
],

See PR for discussion.


Cardiovascular Health dataset colors

Overview

Wait until data is done loading before selecting layers
This is a temporary fix so colors will display correctly
I will create a separate ticket to investigate the root cause and fix the services

How it was tested

Did a local merge with #98 and ran Cardio app with Logica Open
Tested a patient with Home measurements and checked that colors display correctly
There is a slightly longer delay before data is shown, but this is acceptable for now. Will revisit this later.

Checklist

[x] The title contains a short meaningful summary
[x] I have added a link to this PR in the Jira issue
[x] I have described how this was tested
[ ] I have included screen shots for changes that affect the user interface
[ ] I have updated unit tests
[ ] I have run unit tests locally
[ ] I have updated documentation (including README)


[PackerBuildV0/V1] - Migrate task to Node20

Task name: PackerBuildV0/V1
Description:
-- Migrated task using build config generator
Documentation changes required: N
Added unit tests: N
Attached related issue: WI 2115940
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

We'll use buildConfig Node20-229-6 for tasks owned by @bishal-pdMSFT , could you switch it from Node20-229-2 to Node20-229-6, once this PR is merged #19210, thank you!

@qianz2 Fixed, thanks!


Add JS as a target for kmp-nativecoroutines-core

Part of https://github.com/rickclephas/KMP-NativeCoroutines/issues/17 and https://github.com/rickclephas/KMP-NativeCoroutines/pull/43
Doesn't add update any of KSP, but implements all expects and gets tests passing for JS 😄

Not sure if you want to merge this individually or wait until we add the logic to KSP

@rickclephas Not sure if you want to merge this individually or wait until we add the logic to KSP
IMO merging it now makes sense so we can make sure things don't drift too much as other changes get merged

Hmm looks like the coroutines-test classes aren't working as expected on JS 🤔

Hmm it was green before switching JS from coroutineContext[Job]?.children?.forEach { it.join() } to runCurrent

@rickclephas I figured it out! runCurrent runs the tasks that are pending for the current virtual timestep, but doesn't run any tasks that would be running in a future time step
What we really want to do is run all pending tasks until there are no more tasks to run. advanceUntilIdle looks like it's designed to do that 😄
Replacing runCurrent() with advanceUntilIdle() fixes the JS tests


Scala Common Enrich: externalize referer-parser file

duplicate of #3830 ? Although I know that I am delayed reviewing that java code. I will do tomorrow.


Move scan and scanMerge to stream module

This follows up on https://github.com/lhorie/mithril.js/issues/1700

LGTM, but I don't know the initial rationale for putting the functions apart

Also fine with this, so according to the new laws of the land I believe it's mergable!


Optimize POJO deserialization

I had problems with MapDB performance on DBs that contained many POJOs. This PR contains the changes I needed to make in order to make all the uses of reflection disappear from my profiling. The most important change is that we should not deserialize the ClassInfo[] once for every POJO we want to deserialize. My changes to avoid calling Class.forName getContextClassLoader are less important but still yield a nice speedup.

Bit complex, will have a look in a few days.

Nice work, thanks.


Modify AboutUs

Codecov Report

Merging #16 (49bba93) into master (ccb7ee9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb7ee9...49bba93. Read the comment docs.


[luci] Decommision the coverage shard

Description
Per https://github.com/flutter/flutter/issues/31615, we'd like to run coverage along framework tests.
I will remove the coverage shard from LUCI first to avoid breaking LUCI.
Related Issues
Fix https://github.com/flutter/flutter/issues/31615
Tests
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

Has this already been removed from flutter/infra?

This is blocked on https://github.com/flutter/infra/pull/71 that removes the shard from LUCI.

How do we upload or merge the coverage data?
@jonahwilliams The upload is broken at the moment: https://github.com/flutter/flutter/issues/45271

I don't understand the goal of this PR.
We need to run a bunch of tests with and without coverage, to make sure both work.
As far as I can tell we wouldn't want to run most tests with coverage, because that makes them much slower and uses much more RAM.
We need to upload the coverage data from the framework tests, because the longer we run without updates the more out of date anyone using the lcov files will be.

Hi Dan, I'm not sure what should be done to this PR. Could you take a look at Ian's comment above and give some suggestions? @dnfield

We still need to run coverage somewhere.
Coverage is fast enough that we could run it anywhere now.  We don't necessarily need a separate shard on Luci for it

Is this PR still relevant? Should we close it?


docs/dev-docs/testing/main.md

Explain how to write tests for dapps/contracts, using aztec.js.
Perhaps this might be covered in the dapps/ section of the docs (@PhilWindle, @spalladino might know?), but if not, someone can pick this up :)

That should be covered here. Maybe we need to move it out of the dapp section then..?

An argument for moving it out of dapp would be that testing blows up to become a huge subject in its own right?
(Incidentally, I notice you did a small section on 'cheat codes' - there's a doc on cheat codes here: https://aztec-docs-dev.netlify.app/dev_docs/testing/cheat_codes).

Closing, as doc progress is being tracked differently by devrel now.


/dev/* Error 500 instead of 404

Affected Version
SS 4.0.1
Description
I mistyped /dev/task and got a server error (500)
Shouldn't this return a 404 error when the page doesn't exist?
Steps to Reproduce
When going to any url https://www.mysite.com/dev/anything

Fixed with https://github.com/silverstripe/silverstripe-framework/pull/8015


Remove region name throughout endpoint

There is now only one place where the region name is passed to any class in endpoint.py and that is with EndpointCreator's create_endpoint because if you want to create an endpoint from scratch you need the region to help resolve the host. However, any of the region deciding logic on how to sign the request is moved out of the Endpoint class and into the client class. The get_endpoint and get_endpoint_complex public methods were removed to encourage creation of endpoints through the endpoint creator.
cc @jamesls @danielgtaylor

Coverage decreased (-0.01%) to 95.62% when pulling f378b8299b9bed4a16b0d1cd8f9d3c6c81de0204 on kyleknap:endpoint-remove-region into 16c8f69fb3be1b75734ba767098d5ea2bb077f14 on boto:clients-only.

I updated the pull request to include region_name in the client config object. As to precedence, it takes precedence over environment variables and the config file, but not if region_name is specified in the create_client call.
Let me know what you think.

Coverage decreased (-0.03%) to 95.61% when pulling 8d5176d3c3c3f4a64d1693805876c3f161ebdd32 on kyleknap:endpoint-remove-region into 16c8f69fb3be1b75734ba767098d5ea2bb077f14 on boto:clients-only.

Note that there is not much I can do about the small dip in coverage. All relevant lines that  I added is covered but I removed more relevant lines (which were all covered) than I added.

Other than the nitpicks above this looks good. :ship:-it!

Coverage decreased (-0.0%) to 95.63% when pulling b1e8aaf7242c7c07f60ebdab3e7564a4c6f90690 on kyleknap:endpoint-remove-region into c2d056498030f4a16fcbebbf49f6a8d8fa550637 on boto:clients-only.

Coverage decreased (-0.0%) to 95.63% when pulling b1e8aaf7242c7c07f60ebdab3e7564a4c6f90690 on kyleknap:endpoint-remove-region into c2d056498030f4a16fcbebbf49f6a8d8fa550637 on boto:clients-only.

LGTM :ship:-it

:shipit:  We should also document the precedence of region_name vs. Config(region_name) somewhere, either in the session's create_client or at least in the ClientCreator.

Cool. I updated the session's doc string for the client config value. Merging.


Hard-coded language to extract data flow graph for Code Translation use case

Hi, first of all, thank you for providing the code for your experiments. It made it very easy for me to reuse and experiment with it.
I'm trying to fine-tune the GraphCodeBert model for the code-to-code translation use case. While going through the run.py script, I realized that while parsers are initialized for individual languages, during tokenization the language is hard-coded to Java, and only its parser is used
https://github.com/microsoft/CodeBERT/blob/2e2e231a6e0ebf83a31c91db8fd2d60ae3b49a78/GraphCodeBERT/translation/run.py#L182
Shouldn't this be the language of the source code examples, or am I missing something?

Yes, you are right. Since I give an example whose input is java, I write hard-coded language here. When you run C#, you need to change to c_sharp. I will modify it, thanks.


Update contributing guide with release flow

Similar to https://github.com/carbon-design-system/carbon-components-svelte/pull/1627, this repo should:

Update CONTRIBUTING for consistency
Add steps on how to upgrade the icons dependency
Add a maintainers section on the release flow

Done via 39c797e


🚀 [REQUEST] - Support blackbox_exporter

Reference Issues
No response
Summary
Since your script already has most of the necessary functions, it would be nice to support blackbox_exporter and possibly even snmp_exporter setup.
Basic Example
something like INSTALL_BLACKBOX_EXPORTER=true env var ? Or even a --setup-blackbox-exporter option.
Drawbacks
A bit more code, and a new option to install blackbox_exporter

We can choose between two options:

Create two repo(s) that is similar to this but dedicated to blackbox_exporter and snmp_exporter
Rename this repo to exporter_installer with 3 scripts, one for each *_exporter.
Rename this repo to exporter_installer and modify the script to support the two new exporters increasing the number of options (multiple options, i.e. the version must be replicated three times)

The two first options create a new burden, being code duplication and more maintenance work IMO.

Now that I'm thinking, I prefer the section option for the following reasons:

Mixing all the installers into a single one file is a burden to maintain. Moreover, by default: install all or you must select each one to install?
Create a common __commons.sh where all the common configuratons/functions are located. Then, for each installer source it via . "./__commons.sh".
Create a new release whenever a script file is modified. This is very very useful also for backward compatibility.
Before release, the scripts are automatically inlined via inline.sh script.

PS: Currently, I don't have much time to add new installers script and modify the repo.

I've worked that path too in some of my scripts, having a "function collection" I'm carrying between scripts. The point is that your script becomes less portable, since you'll need to download two files.
I've resolved this by doing the following in my script, which downloads a copy of my function set and directly loads it into memory
function self_setup {
	echo "Setting up ofunctions"

	# Download copy of ofunctions.sh so we get Logger and ExecTasks functions
	source <(curl -L https://raw.githubusercontent.com/deajan/ofunctions/main/ofunctions.sh)
	# Don't polluate RUN_DIR since we won't need alerts
	_LOGGER_WRITE_PARTIAL_LOGS=false
}

Another solution I had was using a merge.sh script that replaces a placeholder with the actual code directly on github, see https://github.com/deajan/osync for an example.
PS: Just an idea, no hurry, I just happen to often install node_exporter and blackbox_exporter on the same machines

Yup. The inline.sh (see https://github.com/carlocorradini/inline) script does exactly what you are describing. When developing, simply source common script. However, the final release script is inlined with commons.sh on top. Simples: all three scripts will be the same at first because they are inlined with the common script.

Exactly like my ofunctions.sh collection, except that my implementation has a lot of other functions that grew into it over the last 10 years or so, like parallel timed executions etc, and that I can select what part of ofunctions I want to inline via placeholders in my main script.
Anyway, I don't have more time myself to mod your script too... Sorry.
Guess this will remain a feat request for some time ;)