v3 release

If you notice any problems in the new release, please post them here 👍

Will there be a v3 tag?

Will there be a v3 tag?

Sorry, didn't read the release notes to carefully

We'll no longer maintain mutable major and minor version tags for the action. There will be no v3 target for the action, just v3.0.0 and other exact versions.

Will there be a v3 tag?

Sorry, didn't read the release notes too carefully

We'll no longer maintain mutable major and minor version tags for the action. There will be no v3 target for the action, just v3.0.0 and other exact versions.

No worries ☺ I could be convinced otherwise, but what we've done in the past is just tag every patch release with the equivalent of v3, which in practice means everyone's on latest, and means you break everyone if you introduce an issue, which is inevitable.
Dropping the mutable tags seems like it should:

Give us more time to catch and fix new issues, before they reach too many people
Makes it less likely that users will experience an issue, since it'll likely be fixed before most people upgrade

If you're worried about falling behind on action versions, I can recommend using dependabot for github actions, like we do here 👍 It will open a PR with the relevant release notes when there's a new action version available.
Let me know if this misses out on some other benefit of a v3 tag that I haven't considered!

Everybody does it differently regarding tags and mutable tags. I personally prefer mutable tags for major-tag and minor-tag (examples v3, v3.1) which gives the freedom for the end user to choose what kind of tag to use. As long as SemVer 2.0 is followed regarding the interface (input/output variable names and type/format), then I wouldn't effectively be targeting the main branch when using the major mutable tag. At the same time, I could target minor mutable tag to lock in on a specific state, but still get all patch fixes.
I am personally maintaining a few github actions and reusable github action workflows which are located in several private git repos, and I would like to share my workflow for PR merges which implements what I discussed above. I am not saying that you should implement it yourself, as I get that it is hard to test all scenarios for a small/medium sized opensource project.
on:
  pull_request: # on merge to main only, see if-statement: github.event.pull_request.merged == true
    branches:
    - main
    types:
    - closed

jobs:
  pr_merge:
    if: github.event.pull_request.merged == true
    runs-on: ubuntu-latest
    steps:
    - name: Checkout repo
      uses: actions/checkout@v4
      with:
        fetch-depth: 0 # due to paulhatch/semantic-version step below

    - name: Get next semver version
      id: get_version
      uses<EMAIL_ADDRESS>      with:
        tag_prefix: "v"
        version_format: "${major}.${minor}.${patch}"
        major_pattern: "(MAJOR)"
        minor_pattern: "(MINOR)"
        search_commit_body: true

    - name: Create release
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        gh release create "${{ steps.get_version.outputs.version_tag }}" \
          --repo="$GITHUB_REPOSITORY" \
          --title="${{ steps.get_version.outputs.version_tag }}" \
          --generate-notes

        git tag --force v${{ steps.get_version.outputs.major }}
        git push origin v${{ steps.get_version.outputs.major }} --force

        git tag --force v${{ steps.get_version.outputs.major }}.${{ steps.get_version.outputs.minor }}
        git push origin v${{ steps.get_version.outputs.major }}.${{ steps.get_version.outputs.minor }} --force

    - name: PR comment
      uses: actions/github-script@v7
      with:
        retries: 3
        script: |
          github.rest.issues.createComment({
            issue_number: context.issue.number,
            owner: context.repo.owner,
            repo: context.repo.repo,
            body: 'Release [${{ steps.get_version.outputs.version_tag }}](https://github.com/${{ github.repository }}/releases/tag/${{ steps.get_version.outputs.version_tag }}) created on SHA ${{ github.sha }}.\n\n' +
                  'Tag [v${{ steps.get_version.outputs.major }}](https://github.com/${{ github.repository }}/releases/tag/v${{ steps.get_version.outputs.major }}) created on SHA ${{ github.sha }}.\n\n' +
                  'Tag [v${{ steps.get_version.outputs.major }}.${{ steps.get_version.outputs.minor }}](https://github.com/${{ github.repository }}/releases/tag/v${{ steps.get_version.outputs.major }}.${{ steps.get_version.outputs.minor }}) created on SHA ${{ github.sha }}.'
          })

Keep up the good work, and I will definitely check out the dependabot example you supplied. Thanks!

I am having issues defining a rule that would remove every outdated images but the skipped ones: The previous config looked like this:
image-names: metric
cut-off: One month ago UTC
keep-at-least: 1
account-type: personal
skip-tags: base, production
token: ${{ secrets.GITHUB_TOKEN }}
token-type: github-token

The new:
account: user
token: ${{ secrets.GITHUB_TOKEN }}
image-names: metric
image-tags: * !base !production
cut-off: 4w
keep-n-most-recent: 1

But this does not work.

Please try image-tags: !base, !production or image-tags: !base !production @raszi 👍 The wildcard is implicit as long as no positive matchers (expressions without ! prefixed) are specified.

That does not work either. 😔 Now it is complaining about the with: line.

See this example which does the same thing.
Is your workflow public?

That example is not exactly the same, because that has an explicit wildcard. With the explicit wildcard, I get the error when I use *, as I pasted above. Without the explicit wildcard, I get the error on the with:. level. If I use an explicit wildcard that looks like the example you linked (like t*), it has no errors, but that is not the same behavior.
No, unfortunately, the workflow is not public.

I would guess that you need to make the yaml property it into a string not not get that with error, like
account: user
token: ${{ secrets.GITHUB_TOKEN }}
image-names: foo
image-tags: "!base !production"
cut-off: 4w
keep-n-most-recent: 1

I am unsure how the YAML file is handled by this project, but will that work the same way? Wouldn't it try to ignore images with tags base !production?

It should work the same way, but I'd suggest running the action with dry-run: true if you want to be sure

This is my current step definition:
  clean-old-images:
    name: Delete old unused images
    runs-on: ubuntu-latest

    steps:
      - name: Delete old images
        uses<EMAIL_ADDRESS>        with:
          account: user
          token: ${{ secrets.GITHUB_TOKEN }}
          image-names: foo
          image-tags: "!base !production"
          cut-off: 4w
          keep-n-most-recent: 1

As a quick tip: you can run the action with rust-log: container_retention_policy=trace to get a more detailed look at what's going on. See the Delete old images step in https://github.com/snok/container-retention-policy/actions/runs/9664048758/job/26657757575 for an example

Hi,
not sure if my question belongs to the v3 release or not.
Just wanted to let you know, about my experience, when I tried to use v3.0.0 with a GitHub App token.
Based on the README image-names section, I expected to use a GitHub App for cleanup a image name like bla/*
Readme snippet:
These operators are only available for personal- and GitHub app-tokens. See the token parameter section for more info.

Unfortunately, when I tried to use it as documented in the GitHub App token sample, I got the following response:
2024-07-29T09:34:18.768949Z DEBUG container_retention_policy: Logging initialized
2024-07-29T09:34:18.769670Z DEBUG parse input: container_retention_policy::cli::models: Recognized token as temporal token
2024-07-29T09:34:18.770018Z DEBUG parse input: container_retention_policy::client::builder: Constructing base urls
2024-07-29T09:34:18.770047Z DEBUG parse input: container_retention_policy::client::builder: Constructing HTTP headers
2024-07-29T09:34:18.770065Z DEBUG parse input: container_retention_policy::client::builder: Creating rate-limited services
2024-07-29T09:34:18.770328Z DEBUG fetch rate limit: container_retention_policy::client::client: Retrieving Github API rate limit
2024-07-29T09:34:18.842278Z DEBUG fetch rate limit: container_retention_policy::client::client: There are [15](https://github.com/bosch-adas-genai/actions/actions/runs/10141744949/job/28039764262#step:4:16)000 requests remaining in the rate limit
thread 'main' panicked at src/client/client.rs:46:17:
Restrictions in the Github API prevent us from listing packages when using a $GITHUB_TOKEN token. Because of this, filtering with '!' and '*' are not supported for this token type. Image name cache/* is therefore not valid.

Looking at the latest history, I saw a commit, that mentions GitHub App tokens behave like temporal tokens.
I tried using building and running the 3.0.0 release candidate, where the GitHub App tokens was not treated as temporal token. Then my GitHub App token didn't have the needed scopes:
The token does not have the scopes needed. Tokens need `read:packages` and `delete:packages`. The scopes found were none.

My GitHub App has packages:write permission and is installed on the org with access to all repositories. I didn't find a packages:delete option for GitHub Apps.
I'm not 100% sure, if I just used the action wrong or my App has wrong settings. But if it is not possible to have wildcard image names with GitHub App tokens, perhaps the README can be updated.
As soon as I switched to using a classical PAT, the workflow stated to work as expected.

Quoting the values is fine.

Yes, this worked! Thanks!

Hi, not sure if my question belongs to the v3 release or not. Just wanted to let you know, about my experience, when I tried to use v3.0.0 with a GitHub App token.
Based on the README image-names section, I expected to use a GitHub App for cleanup a image name like bla/* Readme snippet:
These operators are only available for personal- and GitHub app-tokens. See the token parameter section for more info.

Unfortunately, when I tried to use it as documented in the GitHub App token sample, I got the following response:
2024-07-29T09:34:18.768949Z DEBUG container_retention_policy: Logging initialized
2024-07-29T09:34:18.769670Z DEBUG parse input: container_retention_policy::cli::models: Recognized token as temporal token
2024-07-29T09:34:18.770018Z DEBUG parse input: container_retention_policy::client::builder: Constructing base urls
2024-07-29T09:34:18.770047Z DEBUG parse input: container_retention_policy::client::builder: Constructing HTTP headers
2024-07-29T09:34:18.770065Z DEBUG parse input: container_retention_policy::client::builder: Creating rate-limited services
2024-07-29T09:34:18.770328Z DEBUG fetch rate limit: container_retention_policy::client::client: Retrieving Github API rate limit
2024-07-29T09:34:18.842278Z DEBUG fetch rate limit: container_retention_policy::client::client: There are [15](https://github.com/bosch-adas-genai/actions/actions/runs/10141744949/job/28039764262#step:4:16)000 requests remaining in the rate limit
thread 'main' panicked at src/client/client.rs:46:17:
Restrictions in the Github API prevent us from listing packages when using a $GITHUB_TOKEN token. Because of this, filtering with '!' and '*' are not supported for this token type. Image name cache/* is therefore not valid.

Looking at the latest history, I saw a commit, that mentions GitHub App tokens behave like temporal tokens. I tried using building and running the 3.0.0 release candidate, where the GitHub App tokens was not treated as temporal token. Then my GitHub App token didn't have the needed scopes:
The token does not have the scopes needed. Tokens need `read:packages` and `delete:packages`. The scopes found were none.

My GitHub App has packages:write permission and is installed on the org with access to all repositories. I didn't find a packages:delete option for GitHub Apps.
I'm not 100% sure, if I just used the action wrong or my App has wrong settings. But if it is not possible to have wildcard image names with GitHub App tokens, perhaps the README can be updated.
As soon as I switched to using a classical PAT, the workflow stated to work as expected.

Hmm, it sounds like we're assuming you're using $GITHUB_TOKEN when you're acually fine. Perhaps we should add a test to see whether requests like this will work or not, or find another way to differentiate the two token types.
As for the token permissions, I think these exist for PATs, but they may not do for app tokens?

keep-at-least has apparently been removed in v3 but it's not documented in the migration guide.

keep-at-least has apparently been removed in v3 but it's not documented in the migration guide.

It was renamed to keep-n-most-recent: https://github.com/snok/container-retention-policy/blob/main/action.yaml#L30. Sorry, you're right, I missed that in the release note. I'll add it now 👍

in this code example in root reame.md:
https://github.com/snok/container-retention-policy/blob/4f22ef80902ad409ed55a99dc5133cc1250a0d03/README.md?plain=1#L489
it should be
- name: Fetch multi-platform package version SHAs
  id: multi-arch-shas
  run: |
    package1=$(docker manifest inspect ghcr.io/package1 | jq -r '.manifests.[] | .digest' | paste -s -d ' ' -)
    package2=$(docker manifest inspect ghcr.io/package2 | jq -r '.manifests.[] | .digest' | paste -s -d ' ' -)
    echo "multi-arch-digests=$package1,$package2" >> $GITHUB_OUTPUT

- uses: snok/container-retention-policy
  with:
    skip-shas: ${{ steps.multi-arch-shas.outputs.multi-arch-digests }}.  <--- names here were swapped multi-arch-shas with multi-arch-digests

no?

Seems right @simonjur, good catch! Would you be interested in creating a PR with a fix?

@sondrelg ok sure

ok, you were faster than me. thank you for fixing it!

No problem!
Since a bit of time has passed since the v3 release I'll close this issue for now. If anyone has anything to report, please open a new issue 👍


generate types for tracking api/models

generated from https://github.com/terraware/terraware-server/pull/790
we can get this in since there will be parallel effort on top of this

@constanzauanini we can't generate types for tracking off current BE on main. I have a PR out to enable that.
I generated these types/models off my BE PR.
We can get this in and work on it in parallel - has all models and api coded in.
Let me know.

Excellent!

Thanks, I’ll get this in now so you have it.


info_density: Refactor pills to follow font-size.

This PR aims to make pills participate in user-adjustable information density by tying their dimensions to the font-size in use.
Additionally, the PR begins by implementing better, more uniform spacing around pills in the recipient box in the compose area. Pills themselves become "dumb" about their spacing, and instead pill containers can use a combination of their own padding and the gap property to better control how pills are laid out--especially when they span onto multiple rows.
(A follow-up PR will improve the pill containers elsewhere in the UI.)
CZO discussion
Screenshots and screen captures: (updated 21 June 2024)

Before, Legacy
After, Legacy

Before, 16/140
After, 16/140

Screenshots with previous pill design

Pills, before
Pills, after (without layout commit)

Pills, before
Pills, after (with layout commit)

Search pills, before
Search pills, after (no change at legacy sizes

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks fine to me! @karlstolley raised a design question on CZO, but I think it's not a blocker for moving forward here.

Merged, thanks @karlstolley!


Horizontal Center Items When Less Than 'Full'

Hi there, amazing plugin.
I'm trying to figure out how to center all the items within a carousel if there's not enough items to fill it up. I'm using Owl Carousel to house the thumbnails for a video playlist.
For example, if my carousel has enough width to contain 8 thumbnails, but there's only 4 items in any given playlist, is there a way to have those 4 thumbnails center within the carousel?

Hi Owl,
first of all - amazing plugin! Is the centering available via an option as of 2015? I've got two carousels, one for "hot" products and one for latest. I'd like to display the big picture (hot product) centered - http://take.ms/BhgHn


[3.x] [HTML5] Editor plugin now hides unsupported features.

Alternative to #49540.
Quite hacky, but doesn't mess up with the editor code.
Opinions?

There's a somewhat less hacky the item handling could be done, as you give PopupMenu items a custom id (e.g. from an enum) and retrieve those items with e.g. set_item_disabled(get_item_index(EDITOR_FEATURE_VCS), true), etc.
There's still all the hacks need to actually get to this PopupMenu though, which would need to be exposed properly through EditorInterface probably so that this can be done without hacks.
May not be worth the pain, but I wanted to mention that there are options for de-hardcoding some of these magic numbers.


image preview

how add image preview ?

E.g. by use of custom directive:
angular.module('app')
.directive('thumbnail', ['$window', function ($window) {
return {
restrict: 'A',
template: '',
link: function (scope, element, attributes) {
function onLoadFile(event) {
var img = new Image();
img.onload = onLoadImage;
img.src = event.target.result;
}
function onLoadImage() {
var width = params.width || this.width / this.height * params.height;
var height = params.height || this.height / this.width * params.width;
canvas.attr({width: width, height: height});
canvas[0].getContext('2d').drawImage(this, 0, 0, width, height);
}
var params = scope.$eval(attributes.thumbnail);
var canvas = element.find('canvas');
var reader = new FileReader();
reader.onload = onLoadFile;
reader.readAsDataURL(params.file);
}
};
}]);
and then in your HTML file:

@Banananan You are declaring a thumbnail directive but not using it anywhere in your template.

@Banananan  that's a good idea, I would add it to the next version to have a directive like thumbnail="dataUrls" which would assign the selected files dataURLs to the model.

@nfantone, yeah, you're right. Here's example:
'''

'''

var width = params.width || this.width / this.height * params.height;
var height = params.height || this.height / this.width * params.width;

On these two lines I had to use this.width and this.height directly as params.width and params.height didn't exist and threw an error.
Any idea how this could be adapted to be used when it falls back to the Flash uploader (if it's even possible?) When this falls back to the flash uploader it fails on this line:
reader.readAsDataUrl(params.file);

because params.file is not a blob.

params.file[0]?

That doesn't work either...here's how  params.file looks when forcing the flash fallback:

It's not a big deal I modified it to only show a preview now when it is using the native HTML5 viewer. But just something to keep in mind if you do end up using some kind of directive like this in the project.

Try this directive
'use strict';
angular.module('app').directive('thumbnail', function () {
return {
    restrict: 'E',
    replace:true,
    template: '',
    link: function (scope, element, attributes) {
        var preview = element[0];
        var files = scope.$eval(attributes.file);
        var file = files.file[0];
        var reader  = new FileReader();

        reader.onloadend = function () {
            preview.src = reader.result;
        };

        if (file) {
            reader.readAsDataURL(file);
        } else {
            preview.src = "";
        }
    }
};
});

@Banananan  http://prntscr.com/6xxp70 no't working .

Added feature in version 4.0.x. You can use .

Is this feature still available? ngf-thumbnail. I can't see any documentation about it.

@trd use <img ngf-src or <div ngf-background instead

The problem is that the browser crashes if there are many big images. A thumbnail would be very useful.

Added ngf-thumbnail to version 7.3.0

Thank you very much!

Hello!
I have the below code:

= 0">

The thumbnail size is equal than the original image. What am I doing wrong?

set a css size for your img element.

So I don't understand what is the purpose of ngf-thumbnail. I think that should show small image preview.

It depends on how small you want to show it.

ngthumb is not previewing image file over 15mb
how to fix it ???

@emranch31 try ngf-src instead

@danialfarid It will be usefull to bind the file reader onload event when ngf-src and -ngf-thumbnail are used.
For exemple we can add something like ngf-src-onload and ngf-thumbnail-onload. This will allow for exmple to add spinner icon while the file is loading and then remove it when one of that callback is called.
What you think about that?

@danialfarid is there a way to return the full image path after it was selected?

@r4nc1d full path is not provided by the browser because of security reasons.
@simonepri the feature is gonna be available in angular2 and will be ported back to angular 1 at some point. For now you can use ngf-before-model-change on the file select/drop to know when the files are selected and the thumbnail processing begins.

Unable to show Image preview of JPEG file using ngf-src


Wasm API Tests: Rendering in Kotlin

Kotlin particles are now passing Wasm API tests for rendering
Summary

99cb26b Changed Particle.kt and Kotlin Interop to allow nullable templates and models (Impl other direction for WasmNullableString)
7e33bbc Updated mock slotComposer to listen to new rendering system

Question for Reviewers: What should Particle.kt's default handle behavior be? By default, when a handle is updated or synced, should we call renderOutput? Specifically, should the final Particle.kt commit be 17394ab or 8a80159?

@googlebot I fixed it.


BIRs become corrupted if build command is cancelled

Description:
$subject. While the build is ongoing, if I cancel the command and retry to build, it says the following:
error: failed to load the module 'registry/semver.com.github.zafarkhaja.semver:2.0.4' from its BIR

The particular package is picked from local repo.
Affected Versions:
SL BETA2
OS, DB, other environment details and versions:
Mac

We should continue to compile even if the BIR is corrupted.

In this case, probably the BIR is corrupted due to a partial write from the first compilation. In the second run, the compiler uses corrupted BIR to generate the symbol table.
Instead of doing this, the first project API can validate a BIR using a BIR verifier, and if it is only valid, then we can load symbols from the BIR. If not we can recompile the source from Bala and generate a new BIR.
The compiler doesn't have a BIR verifier and we can easily validate this using the Kaitai format. @hevayo @sameerajayasoma @manuranga

As a temporary (maybe even permanent) low cost solution, can we write the file to a temporary file and rename it ones the buffer is closed.


Attributes vs. Properties

Currently, there's no distinction between attributes and properties-- attributes are used as attributes in HTML and as properties in the browser. This is necessary for things like "value" to work-- setting the "value" attribute in the browser doesn't change the content, and it's not possible to set properties in HTML AFAIK. However, this causes weirdness for things that have both an attribute and property with different names, such as "class" and "className". Elm special-cases a bunch of these names in order to apply them differently, but that's really messy. Attribute/property keys could be changed to an enum and matched on, but this has the unfortunate side effect of restricting keys to a predefined set, as well as requiring an import for each attribute used.

After some thought, I'm probably just going to special-case certain strings, ala Elm. It's the easiest on users of the library, and it only imposes a tiny runtime cost (a single match statement).

an enum seems to be the way to go design-wise. it would not restrict to a predefined set, if you add one variant to the enum typed Other(String).


Implement DISTINCT ON from Postgres

Which issue does this PR close?
Closes #7827.
Rationale for this change
While in principle the output of DISTINCT ON can be emulated by combining several aggregation, projection and sorting queries/operators, in practice this is very verbose and impractical for users, unlike DISTINCT ON which is quite succinct. On the other hand that does mean that DISTINCT ON can be optimized into the equivalent representation under the hood during logical planning, while at the same time providing the compact syntactical interface.
What changes are included in this PR?

A new logical plan sub-variety for handling the DISTINCT ON from Postgres.
Parsing and planning for it
Optimization which converts it into the equivalent representation using the more common logical plan primitives
Proto serialization
Tests

Are these changes tested?
Yes, there are also new SLTs.
Are there any user-facing changes?
SQL support extends to encompass DISTINCT ON queries.

I am sorry -- I have seen this PR but I am somewhat backed up on reviews

I am a little worried about the TODO and the seemingly incorrect results,

@alamb thanks for bearing with me here! I agree, ideally #8008 gets some kind of a resolution prior to merging this.

Ok, the last commit (8ebdc13cee54bdd10003b3d7549a3eb7fe157da7) resolves #8008, so I think this might actually be mergable now.

Thank you @gruuya  -- this is on my review queue


Fixes hire-us page on safari

Fixes hire-us page on safari
Removes max-width from team grid in favor of horizontalGrid--limited

Other than the comment :+1:


"Recent Scripts" menu isn't working properly

Godot version:
master: 7d0212f
Issue description:
The "Recent Scripts" menu (Script -> File -> Open Recent) only adds items when the scripts are closed, not opened, and completely resets if "Open Recent" is selected, and after the editor is closed as well.

[x] I searched the existing GitHub issues for potential duplicates.

Doesn't happen anymore, closing it.


Simplify repo naming for secrets command

Currently repo name is split to --owner and --name instead let’s have both combined on a single arg --name

The arg should be --name rather than --repo_addr.


BuildPackage presents list with all currently opened projects...

... when no project was specified and multiple projects are open.
However, it should not present projects that do not carry a file apl-package.json inn their root: one cannot build a package from them.
Not every project is a Tatin package.

Fixed in 0.103.0


Fix automatic provisioning link

There was a space in the Markdown that caused the link to not be a link.

@Eilon : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Numeric Ramp: line-color

hi!
I was making a bivariate point map of earthquakes in Nepal where the symbol size is based on the magnitude and the line color, based on the depth. I've forced the line-width to 3 buckets, but I'm seeing 5.
Here is the map with the 5 outline classes labeled (its hard to see the lightest color against the background):

And here's my TURBO :) cartocss
#layer {
  marker-placement: point;
  marker-allow-overlap: true;
  marker-line-opacity: 1;
  marker-line-width: 3;
  marker-line-color: ramp([depth],colorbrewer(PuRd),3);
  marker-opacity: 1;
  marker-fill: #000;
  marker-fill-opacity: 0.5;
  marker-width: ramp([mag], 6, 24, 5);
}

Just in case: to set the number of buckets in color brewer you need to do it in the colorbrewer function: https://github.com/CartoDB/turbo-cartocss/blob/6999d2900ad52af3054ec986cc620062b2a45d9a/docs/quickstart.md#change-number-of-color-brewer-data-classes :-)

oops! ugh, sorry. missed that detail


Should Genotype allow for multiple Variants / alleles?

@arahuja implied there had been some discussion around this in the past.
AFAICT there is no good way right now to capture there being two non-reference alleles at one locus, having one Variant per Genotype.
In the immediate term I will work around this by emitting two lines / Variants in my VCFs, but I'm curious whether we should support the other way here. Thanks!

Ping for an update.  Is there anything here to consider for #108?

I don't think there is. I'd be fine closing this.

Closing as WontFix


Pattern: Content block - with cards:   Design QA testing

User Story

As a [user role below]:
DDS Designer and Developer

I need to:
test the Content block - with cards

so that I can:
be sure the developer's code correctly works as designed

Additional Information

Dev Issue (#1855 )
Design specs issue (#2033  )
Visual and design specs Box link
Functional specs issue (#1832  )

Tasks
Ensure the Content block - with cards pattern has been tested and reviewed by design + dev.
Acceptance criteria

[ ] Pattern is reviewed by designer and design defects are identified
[ ] New issues are opened to log individual defects
[ ] Screenshots of as-is and to-be design should be added to the issue when needed
[ ] Developer associated with building the pattern is assigned to the new issues
[ ] Appropriate labels are added to the issue  eg.  bug, dev

@RobertaJHahn Design QA is done and all issues have been logged:
https://github.com/carbon-design-system/ibm-dotcom-library/issues/2417
https://github.com/carbon-design-system/ibm-dotcom-library/issues/2418


New Quantized Model Request

Thank you for your valuable contributions to the community; your work looks great! I came across this 70B model: Llama-3.1-Nemotron-70B-Instruct, and its benchmark results are impressive. Could you please provide the quantized weights for this model?

Nemotron-70B
yes


feat(api): add fibonacci with tracing

For #690

Pull Request Test Coverage Report for Build 1702

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.793%

Totals

Change from base Build 1701:
0.0%

Covered Lines:
101

Relevant Lines:
152

💛  - Coveralls


Include "Editor Default Resources"

Editor Default Resources is a special directory in Unity that allow UI scripts to retrieve and use assets. The problem is that it is required to be located at the root of the project, thus it is not currently included in this repository.
For packaged releases, it's a simple matter to include that folder in the package. For contributors in the other hand, currently it's required that they export the icon PNG files from the /Editor/Art/Hivemind.sketch Sketch file.
A possible solution would be to include a build script that uses the Sketch Tool to automatically export the icons.

For now I just included the generated files in /Editor/Art/Hivemind/. Ideally a build step should copy them over to /Editor Default Resources/, or use the method above.
For now, users can simply copy the /Editor/Art/Hivemind/ directory to /Editor Default Resources/Hivemind/.


A dataset not found when I run "python script/pretrain.py -c config/pretrain/mc_gearnet_edge.yaml --gpus [0]"

It seems that the file located in "https://ftp.ebi.ac.uk/pub/databases/alphafold/latest/UP000006548_3702_ARATH_v2.tar" really doesn't exist. When I entered this url in my browser, it also noticed me that the file doesn't exist.
14:43:55   Downloading https://ftp.ebi.ac.uk/pub/databases/alphafold/latest/UP000006548_3702_ARATH_v2.tar to /home/horace/scratch/protein-datasets/alphafold/UP000006548_3702_ARATH_v2.tar
Traceback (most recent call last):
  File "script/pretrain.py", line 50, in <module>
    dataset = core.Configurable.load_config_dict(cfg.dataset)
  File "/home/horace/.conda/envs/drug/lib/python3.7/site-packages/torchdrug/core/core.py", line 269, in load_config_dict
    return cls(**new_config)
  File "/home/horace/.conda/envs/drug/lib/python3.7/site-packages/decorator.py", line 232, in fun
    return caller(func, *(extras + args), **kw)
  File "/home/horace/.conda/envs/drug/lib/python3.7/site-packages/torchdrug/core/core.py", line 288, in wrapper
    return init(self, *args, **kwargs)
  File "/home/horace/.conda/envs/drug/lib/python3.7/site-packages/torchdrug/datasets/alphafolddb.py", line 122, in __init__
    tar_file = utils.download(self.urls[species_id], path, md5=self.md5s[species_id])
  File "/home/horace/.conda/envs/drug/lib/python3.7/site-packages/torchdrug/utils/file.py", line 31, in download
    urlretrieve(url, save_file)
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 247, in urlretrieve
    with contextlib.closing(urlopen(url, data)) as fp:
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 641, in http_response
    'http', request, response, code, msg, hdrs)
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 503, in _call_chain
    result = func(*args)
  File "/home/horace/.conda/envs/drug/lib/python3.7/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

Oh, I found that it turns to v4 instead of v2. So If I just used v4 dataset, will it have an effect on the experiments?

I think it's okay to use v4 instead of v2. The pre-training dataset doesn't have a large effect on the final performance.

I think it's okay to use v4 instead of v2. The pre-training dataset doesn't have a large effect on the final performance.

I have downloaded the v4 dataset and put it into the correct directory. However, when I tried to run the command python script/pretrain.py -c config/pretrain/mc_gearnet_edge.yaml --gpus [0], the program still started to download the v2 dataset. I don't know how to deal with this condition.

Sorry for the inconvience! This is because I set the default files as v2 datasets instead of v4 datasets. The easiest way to change this is to inherit the datasets.AlphaFoldDB class and rewrite the urls and md5s attributes here. The class will check the downloaded files according to filenames in urls and check the md5 values.

I think this url issue is resolved in the updated version(0.2.1)
Installing the updated torchdrug using: pip install torchdrug==0.2.1


Short solution needed: "How to delete word" (vim)

Please help us write most modern and shortest code solution for this issue:
How to delete word (technology: vim)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

How to delete word


Optimize front page animation

It's been a few years and a few versions of two.js since i've seriously looked at this. Probably (definitely) needs a performance pass to make sure it's not eating up too many system resources.
also:

alter presentation based on system resources? fewer dots etc etc
lock framerate?
figure out why it drops down to a handful of dots instead of selfreplenishing as it should (iirc)

could also just: https://developer.mozilla.org/en-US/docs/Web/API/OffscreenCanvas
see: https://gist.github.com/michaschwab/0ff51ee36fbd0af9cd58a215d0672472 <-- this two.js worker test


Command line parameter "-vmargs" not working

Description
When use the -vmargs parameter, i.e. -vmargs -Xmx2048m, Dbeaver does not start
Example:
%USERPROFILE%\DBeaver\dbeaver_current\dbeaver.exe -reuseWorkspace -nl en -vmargs -Xmx2048m
After this command, shows a popup:

If the -vmargs is removed, Dbeaver starts with no issues:
%USERPROFILE%\DBeaver\dbeaver_current\dbeaver.exe -reuseWorkspace -nl en
DBeaver Version
Community Edition 23.2.1
Operating System
Windows 11
Database and driver
No issues with databases and drivers.
Steps to reproduce

Run the command line:
%USERPROFILE%\DBeaver\dbeaver_current\dbeaver.exe -reuseWorkspace -nl en -vmargs -Xmx2048m

A popup is shown instructing you to check the log. Dbeaver does not start.

Run the command line without the -vmargs:
%USERPROFILE%\DBeaver\dbeaver_current\dbeaver.exe -reuseWorkspace -nl en

Dbeaver starts with no issues.

Additional context
The command line is executed by the shortcut pinned to the Windows taskbar.

Hello, @AdrianoBortoloto . Thanks for your report.
We have a similar ticket in the current sprint. It should work from version 23.2.2

#21299

Could you please download the latest EA version and see if the issue is gone there?
https://dbeaver.io/files/ea/

Thanks for the update @AdrianoBortoloto


Makefile: Add multi-arch support for cilium images

Add tags for different architectures;
Add script to create and push manifest list.
Signed-off-by: Jianlin Lv<EMAIL_ADDRESS>Fixes: #9898

This change is

Coverage decreased (-0.008%) to 44.783% when pulling 9997557aeee112059e716391a4bd188751634783 on iecedge:multi-arch into 394e72478a8d120dab0bff2c41db77695877ce57 on cilium:master.

test-me-please

test-me-please

Looks like the CI is still looking for the images named like cilium/cilium:latest.

Looks like the CI is still looking for the images named like cilium/cilium:latest.
I notice that CI build passed, I can't catch your meaning.
Would you please provide more information for me to improve this patch?

@iecedge The Cilium-Ginkgo-Tests CI target failed: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17422/ ; If you follow through the "Pipeline steps" you can find some failures around image push due to the naming.

@iecedge The Cilium-Ginkgo-Tests CI target failed: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17422/ ; If you follow through the "Pipeline steps" you can find some failures around image push due to the naming.

Got it, sorry, I didn't consider jenkins CI before,
The solution I thought of was not to change the contents of jenkins, but tag the built cilium to latest;
I am working on CI support Arm64, and subsequent work will involve jenkins optimization.
how about your opinion?

@iecedge the "failing checks" section at the bottom of this page highlight that this PR in its current form break the runtime (end-to-end) tests, and that's where I got the Jenkins link from (See the "Details" link for the test with the red cross). I believe that this failure is because the image name is changed but the test/ directory and/or install/ is not updated. There may be other places in the git tree that rely upon the current image name. We use ginkgo/jenkins to validate the runtime behaviour of Cilium, so this will need to be fixed before we merge the PR.
There's more details about how to use the end-to-end testing environment here: http://docs.cilium.io/en/latest/contributing/testing/e2e/ ; otherwise if something is not clear from the documentation then you're welcome to jump on the Slack instance to ask questions or ask questions here. If you make changes that you want to test and you're not able to run the tests in your own environment, then feel free to ping one of us either in #development on Slack or directly here, and we can run the CI again for you.

Also, in case it wasn't obvious from my comment above, this was the failure I saw:
02:06:04      k8s1-1.11: Successfully built 00f322aae209
02:06:04      k8s1-1.11: Successfully tagged cilium/cilium:latest-amd64
02:06:04      k8s1-1.11: echo "Push like this when ready:"
02:06:04      k8s1-1.11: Push like this when ready:
02:06:04      k8s1-1.11: echo "docker push cilium/cilium:"latest"-amd64"
02:06:04      k8s1-1.11: docker push cilium/cilium:latest-amd64
02:06:04      k8s1-1.11: building cilium/operator container image...
02:06:04      k8s1-1.11: pushing cilium/cilium image to k8s1:5000/cilium/cilium-dev...
02:06:04      k8s1-1.11: Error response from daemon: No such image: cilium/cilium:latest

https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17422/execution/node/114/log/

Also, in case it wasn't obvious from my comment above, this was the failure I saw:
02:06:04      k8s1-1.11: Successfully built 00f322aae209
02:06:04      k8s1-1.11: Successfully tagged cilium/cilium:latest-amd64
02:06:04      k8s1-1.11: echo "Push like this when ready:"
02:06:04      k8s1-1.11: Push like this when ready:
02:06:04      k8s1-1.11: echo "docker push cilium/cilium:"latest"-amd64"
02:06:04      k8s1-1.11: docker push cilium/cilium:latest-amd64
02:06:04      k8s1-1.11: building cilium/operator container image...
02:06:04      k8s1-1.11: pushing cilium/cilium image to k8s1:5000/cilium/cilium-dev...
02:06:04      k8s1-1.11: Error response from daemon: No such image: cilium/cilium:latest

https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/17422/execution/node/114/log/

Thanks, this bug has been found , I modified my patch just now,
I plan to retain the original image name and tagged with Arch, as
"$(CONTAINER_ENGINE_FULL) tag cilium/cilium:$(DOCKER_IMAGE_TAG) cilium/cilium:$(DOCKER_IMAGE_TAG)-${ARCH}"

@iecedge the "failing checks" section at the bottom of this page highlight that this PR in its current form break the runtime (end-to-end) tests, and that's where I got the Jenkins link from (See the "Details" link for the test with the red cross). I believe that this failure is because the image name is changed but the test/ directory and/or install/ is not updated. There may be other places in the git tree that rely upon the current image name. We use ginkgo/jenkins to validate the runtime behaviour of Cilium, so this will need to be fixed before we merge the PR.
There's more details about how to use the end-to-end testing environment here: http://docs.cilium.io/en/latest/contributing/testing/e2e/ ; otherwise if something is not clear from the documentation then you're welcome to jump on the Slack instance to ask questions or ask questions here. If you make changes that you want to test and you're not able to run the tests in your own environment, then feel free to ping one of us either in #development on Slack or directly here, and we can run the CI again for you.

Many thanks for your patience and cooperation.
This is very helpful for me to doing support CI on Arm64.

test-me-please

test-gke K8sDemosTest.*

test-me-please


Package source files when publishing to NPM

Hi, I want to use the source of the icons for a tool, however, the NPM package does not contain the sources, only the final script. I guess you probably did this to avoid shipping a lot of files with the package, but that's an issue my bundler would deal with. Please include the SVG files with the package, or at least provide a separate package with the sources.
Thanks! Great job.

You can use https://www.npmjs.com/package/@discordapp/twemoji, which forked this repo and added the SVG files back.

Thanks for chiming in with an alternative @Menci; closing this since we don't plan to bundle the SVG files with the package.


Slf4JEventListener support custom key

see #158

Hello?
@jonatan-ivanov @marcingrzejszczak

I'm still wondering about this - do you want to use this with Spring Boot? I'm wondering cause you can't modify these when using Brave and we would like to be pretty consistent I guess, WDYT @shakuzen @jonatan-ivanov ?

Hey we discussed it with the team and we will merge this, however we're not planning to add any additional support for this in Spring Boot. You will need to create a bean of this type and use the new constructor if you want to use different keys in MDC.

I'm still wondering about this - do you want to use this with Spring Boot? I'm wondering cause you can't modify these when using Brave and we would like to be pretty consistent I guess, WDYT @shakuzen @jonatan-ivanov ?

I am still new to the Brave. I think I can fix this , but not right now


Java Logic for Work / Break Cycles

This is the core functionality of the app.
Required
There are 2 kinds of breaks in the pomodoro technique, 1. Short and 2. Long.
At the end of each complete work session the user starts a short break with a button click. Except, at the completion of every 4th work session the user takes long break.
Each of the work duration, short break duration, and long break duration values are taken from the respective spinner selection made in SettingsActivity. (Values are stored as SharedPreferences)
Expected Behaviour

A single Toggle Button handles all states.

Each completed session is counted and at the end of every completed work session the user is allowed to either start a short or long break. Counts to be maintained as shared preferences.

Cancelled Work sessions should not be counted.

Clicking COMPLETE button counts towards number of completed sessions.

While the toggle button only has two states: checked and unchecked, the single timer_button_main, will serve to fulfill all states. The following table indicates the button tap behaviour:

Serial
unchecked
checked
re-unchecked

1.
Start Pomodoro
Cancel Pomdoro
1.

2.
Start Short Break
Cancel Short Break
1.

3.
Start Long Break
Cancel Long Break
1.

Note: Whenever any state is cancelled, the next state is always Start Pomodoro. i.e.

This is a challenging issue and may be broken down into several smaller issues.
Instead of taking up the whole issue as a whole, take up a small part of it and comment below on what you will be working on (a corresponding issue will be created after your comment). Better still, create an issue and reference that issue from the comments below.
Comments on this issue should be used to coordinate joint effort.

Interested in taking up this issue? Leave a comment expressing you interest along with your @slack id.abnd.
Each issue expects a 24hr turnaround time by default. In case where a student doesn't come back with an update after 24 hours have elapsed, the issue is up for grabs by anyone.

I would like to work on this issue.
Slack ID - @tirth.abnd


Array minRows sometimes return number 1 instead of object in data

Bug Report
When I add minRows, in this situation minRows = 1 to my array field, I randomly get validation error. I console log the data object in beforeChange hook and when this error occurs, value from that field is returned with value 1. When operation is successful, returned value is regular object with data from that array field.

The last one in this screenshot causes the error.

Field definition
Steps to Reproduce

Create array field
Add minRows = 1
Try to add multiple entries to collection

Other Details
Payload version 1.1.19

Hey @wloodar I am not able to recreate this, but I went ahead and took a screen-recording so you could see what I've got going on:
https://user-images.githubusercontent.com/15735305/204378446-80a9f597-13cf-4f0a-9d11-f65690209c9e.mp4
I do see you are firing a request out to revalidate your front-end, probably in an afterChange hook. Try temporarily removing that and see if your bug continues. Otherwise, can you send me your full config so I can try and replicate your setup exactly?


Equivalent to preloadAll

I was upgrading our existing app from react-loadable to @loadable/components. In my previous server-side configuration I was relying on preloadAll from react-loadable to initialize all of the loadable components before starting my app.
Looking at the server-side example for loadable-compoents you are doing something similar in nodeExtractor.requireEntrypoint().
My problem: My app is set up slightly differently than the example and using requireEntrypoint would mean a significant refactor.
Why? Long ago we made the decision to build the entire express server using webpack/babel. In the example you build the react app twice with the exact same entrypoint and build the express server separately. That's an interesting approach but it's not the only approach.
Why preloadAll? You have recognized this issue on the client and provided a dedicated loadableReady function. On the server it would be nice to be able to resolve all loadables prior to running the app. Using requireEntrypoint only works if you're initializing a separately built app. Something like preloadAll allows you to initialize the app from within the bundle itself.
preloadAll is pretty clever. It works by keeping an internal reference for every loadable. It would be like adding to an array every time loadable is called. It then loops through those references recursively when preloadAll is called. Because it resolves each loadable recursively it's able to initialize the entire tree without the need to have a separate stats file for the server build.
In a server-side context the penalty is a brief pause while the server is initializing. Having something like preloadAll available would make it far easier to integrate loadable-components into a project that had been successfully running react-loadable 5.
Chicken and egg: There are some interesting issues with the way preloadAll works if you don't use node-externals in your server bundle. In the past I had designed apps to work more similarly to the server-side example and had issues with preloadAll. Something like requireEntrypoint would've made my life easier. However, I was able to solve the issue by re-exporting preloadAll from my entrypoint to ensure that it was referencing the version of react-loadable in the bundle. That way my server was able to import App and preloadAll to initialize the bundle before using it.
Example:
const { default: App, preloadAll } = require(path.resolve(
  __dirname,
  '../../public/dist/node/main.js',
))
const webStats = path.resolve(
  __dirname,
  '../../public/dist/web/loadable-stats.json',
)

app.get(
  '*',
  (req, res) => {
    const extractor = new ChunkExtractor({ statsFile: webStats })
    const jsx = extractor.collectChunks(<App />)

    const html = renderToString(jsx)

    res.set('content-type', 'text/html')
    res.send(`<!DOCTYPE html>

${extractor.getLinkTags()}
${extractor.getStyleTags()}

${html}

  ${extractor.getScriptTags()}

`)
  },
)
preloadAll().then(() => {
  app.listen(9000, () => console.log('Server started http://localhost:9000'))
})

I also need a preloadAll, my server makes a page empty the first time and works for all subsequent times.

I don't need a preloadAll (for usage without) if I replace https://github.com/smooth-code/loadable-components/blob/0d3e7dee3045737be1709ffa300aca083aef457c/packages/component/src/createLoadable.js#L166-L171
with
    Loadable.preload = function (props) {
      if (typeof window === 'undefined') {
        if (typeof ctor.requireSync === 'function') {
          return ctor.requireSync(props)
        }
        throw new Error('`preload` cannot be called server-side')
      }

      return ctor.requireAsync(props)
    };

The dynamic naming works with Node, with Webpack it's confusing at the time of the build but Node has everything to make a require that works at the time of the execution.
If there is a variable in the name, it is resolved in Node, not for webpack.
This code works perfectly with my modification if the part variable is not bad:
const App = loadable( () => import( `./containers/App.${part}` ) );

And it will work for full-dynamic as well.


receive: Add e2e test for multi-tenancy.

It would be awesome to add extra test for writing data for 2 different tenants into single receive instance. This path is currently missing in our e2e tests: https://github.com/thanos-io/thanos/blob/066150a6d1e2df3c2398f76ee91a7b0f2c0f80ae/test/e2e/receive_test.go#L20
Help wanted!

Can I take up this issue?

@Chans321 Of course, go ahead, please :) Thanks

#3474 resolves this issue :)

Wow, amazing! :muscle:
Thanks!


Allow handlers to provide a mapping of error message to context url.

There have been a fair number of comments asking why certain cops are making suggestions. For rubocop most of the answers come from https://github.com/bbatsov/rails-style-guide.
We should add a naïve mapping between error text and link for the text that each handler can define. When present the text of the message becomes a link to the url.
In some cases having more than one URL may be useful. Perhaps we can use the [1, 2] syntax in those cases.

Closing as I'm not planning to implement since we are moving away from using farcy.


Why don't you pass-on the props from Observer down ?

Observer takes in an "Argumentless" function, but what if I want to use this with props injected ?
Why not this:
<Observer {...someprops}>
    {(someprops) => {...}}
</Observer>

Do you have a good use case? You can access them from the closure anyway. I don't see a real need and I do see potential confusion :-)

You're right, you can access them from the closure. I don't remember the exact use-case I had, I used observer() in the end to solve the issue.


Accordion multi_expand: Closing an open panel removes the 'active' class in all dd tags

If you have multiple panels open and close one of them the 'active' class is removed from all the dd tags, the panel stays open since it depends on the 'active' class inside the panel which is not removed.

We added this to our "known issues" section in our planning board for the next version. A PR would be valuable to the community, otherwise It will be addressed then. You can see and vote on the proposed updates here: https://trello.com/b/QBPKlQqf/foundation-sites


refactor: move functions to helpers.tsx

What's changed
per issue #43, All the functions that are related to detections and getting inference data are moved out to helpers.tsx so that those can be shared in different components.

Yep! You got it!

Oh, that reminds me.   Labels should be a property of the component.  We should review.  Let's zoom and chat.


feat(cli): add txtx auth login command

What's our take on
$ txtx cloud login

?
Having a cloud namespace we can reuse (open, new, etc) could be nice.


Bot shows wrong profit

Its possible the bot says I'm losing g money since not selling all coins he bought ?

It's actually correct.
So the bot buy/sell as

buy: 10.691*1=10.691
sell: 11.139*0.9=10.0251

You won't be able to sell all coins in the Binance.
It will always leave some.

Alright, thanks for clearing this out.
I guess I need to use larger amounts to see profit


[feature] Optional observation space in info of dictionary

Implement interface ThetanArenaEnv.step() in MineShaft/ThetanArenaEnv.py under branch develop
getting started

fork the repository
create new branch from develop (e.g. feature/explore-space) to implement new feature of extra observation space
assign this issue to yourself/leave comment to this issue identifying you the developer working on this
discuss info dictionary format in this issue
create pull request after you tested it works
leave comment to this issue request for merging

acceptance criteria

[ ] Developer should be able to set io_mode as IO_MODE.SIMPLIFIED when creating instance of class ThetanArenaEnv
[ ] The return in step() would be empty observation and a dictionary object info should be full of info about the things on the screen (e.g. enemy location, resources, HP etc.)
[ ] Define the info dictionary format in the comment before your implement and pull request
[ ] Good API spec (clear docstring in description with example in code how to use the feature)

I just fount that observation space is also possible to be dict in this reference
spaces = {
  'position': gym.spaces.Box(low=0, high=100, shape=(2,),
  'orientation': ...
}
dict_space = gym.spaces.Dict(spaces)


Look into support for code radio integration

Describe the solution you'd like
Be able to bop some tunes thru discord from FCC's code radio
https://coderadio.freecodecamp.org/
Describe alternatives you've considered
The current approach I've thought of for this feature requires:

traditional "play music" bot. (I'm sure docs on this exist out there)
have music "streamed" from FCC's code-radio directly (may require looking into that projects source code)
no "media" buttons should be needed, bot can just keep streaming non-stop as long as people are listening
Bot should be the only role who has access to a chat room, no other user can "talk". This should be handled at the discord-role level, not at the bot level.

Additional context
It might make sense to tackle this feature in 2 phases. 1 is to play any music file thru discord, the 2nd is to "stream" from the fcc-radio server.
This way we can figure out how to integrate discord/roles to the discord server without fully connecting to the fcc-radio client.

As an FYI, from what I've read Heroku doesn't play well at all with music features.

How does Heroku's architecture affect the playback of music thru the discord bot's api?

It sounds like it just doesn't like to play the audio - from what I've seen, most of the audio features people have tried require a library like FFMPEG, which Heroku doesn't like. 🤔
Here's some stuff I found.
SO 1 | SO 2 | SO 3

That sucks, we may have to change hosting providers for the test bot in the mean time to run the bot. I've been messing around with Digital Ocean, which I'm almost 100% sure would work, but costs 5$ a month, and requires more manual handling.
I'll start looking around. If anyone has any suggestions of other platforms/workarounds that are as cheap or cheaper than DO please suggest em :)

What we can do though is using the bot to fetch the song that is currently playing in codradio.freecodecamp.org and then use ytdl library to fetch a youtube video and play it that way.
Using this method, we can even give the user the ability to add specific music they want. Just a suggestion...

The concern with that, though, is allowing users to add specific music. We'd then have to moderate that music selection, whereas streaming coderadio would not require moderation. :)

So we're just going to use the coderadio... But is there anyway to fetch what music is currently playing on the site?

a normal fetch might not be the right approach for how coderadio works. I would think its some kind of stream of data. I'm not 100% sure about the architecture of coderadio, but the react client (repo is above) should end up working similar as the bot, except the bot will also have to "pipe" whatever audio it gets into discord like any other music bot.
This does mean most examples out there (which play music from files I assume) wont fully apply.

From what I saw while poking around in the source files...
The website uses a websocket connection with the nchan package to get the current song stream from this URI.

So techincally we can get the current song stream and then search it on youtube and play it.

So techincally we can get the current song stream and then search it on youtube and play it.

I'm not sure if the videos are on youtube. The URI's point to files, which when gone to, load up an audio stream it seems.

I know it's not, but what I can do is using a library to do a search on youtube's database for a video for that music. Then play it

I know it's not, but what I can do is using a library to do a search on youtube's database for a video for that music. Then play it

We can talk about that feature in another issue instead of this one. This one is specifically for adding first party support with FCC's code radio :)

I'm going to see if I can start checking this out, would be the "killer feature" of the bot... if its possible... and if it works haha

@nhcarrigan beat me to this, and started on a POC for this feature. Piping music is pretty easy from coderadio urls, and it seems pretty easy.
For the feature itself I was thinking of the following:

User's can't start/stop as if one person stops it, it stops for everyone
No members should be able to talk in the code-radio channel, only the bot. (people can join the voice channel, but no one can talk) This can be handled in discord via the roles
When a new song starts, the bot needs to be able to display a message in the "song-playing" channel, and play the new song in the room
The bot will require at least 2 environment variables for this feature to work.

the name of the "song-playing" channel to show whats playing
the name of the actual voice channel

When no users are in the room, the bot should automatically stop playing and display a "stopped" message in the song-playing channel.

This one can be handled post-migration, I believe.

Probably not going to do this due to #202. Can re-open in the future if approved.


Twig context update

@justjohn Could you review it and, if it's okay, merge and release a new version?

I'll take a look this evening and get a release out.


iOS builds fails 'FirebaseAuth-Swift.h' file not found cordova 6.1.x

Bug report

CHECKLIST

[x] I have read the issue reporting guidelines

[x] I confirm this is a suspected bug or issue that will affect other users

[x] I have reproduced the issue using the example project or provided the necessary information to reproduce the issue.

[x] I have read the documentation thoroughly and it does not help solve my issue.

[x] I have checked that no similar issues (open or closed) already exist.

Current behavior:

I have a Cordova project that is using cordova-plugin-firebasex. I want to use cli to build the iOS apps. I can build the app if I use the code.
I can reproduce the issue using the example project but using "cordova-ios": "github:apache/cordova-ios#6.1.x".
I get build errors on iOS. I am using cocoapods version 1.15.2. See error log below:
/Users/user/project/cordova/app/platforms/ios/MyApp/Plugins/cordova-plugin-firebasex/AppDelegate+FirebasePlugin.h:3:9: fatal error:
      'FirebaseAuth-Swift.h' file not found
#import "FirebaseAuth-Swift.h"
        ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Expected behavior:

Should build without errors.

Steps to reproduce:

Go to the project and run cordova build ios --debug

Environment information

Cordova CLI version

12.0.0<EMAIL_ADDRESS>

Cordova platform version

ios 6.1.1

Plugins & versions installed in project (including this plugin)

branch-cordova-sdk 5.1.0 "branch-cordova-sdk" com.adjust.sdk 4.35.1 "Adjust" com.xtreme.plugins.XtremePush 4.5.7 "XtremePush" cordova-plugin-app-version 0.1.14 "AppVersion" cordova-plugin-apprate 1.8.0 "AppRate" cordova-plugin-dialogs 2.0.2 "Notification" cordova-plugin-firebasex 18.0.3 "Google Firebase Plugin" cordova-plugin-inappbrowser 4.1.0 "InAppBrowser" cordova-plugin-ionic-webview 5.0.0 "cordova-plugin-ionic-webview" cordova-plugin-nativestorage 2.3.2 "NativeStorage" cordova-plugin-printer 0.8.0 "Printer" cordova-plugin-safariviewcontroller 2.0.0 "SafariViewController" cordova-plugin-splashscreen 5.0.4 "Splashscreen" cordova-plugin-uniquedeviceid 1.3.2 "UniqueDeviceID" cordova-plugin-whitelist 1.3.5 "Whitelist" cordova-plugin-wkwebview-inject-cookie 1.1.5 "WKWebViewInjectCookie"

Dev machine OS and version, e.g.

OSX

ProductName:            macOS ProductVersion:         14.7.1 BuildVersion:           23H222

iOS build issue:

Node JS version

v20.11.1

XCode version

Version 15.4 (15F31d)

@rencsikmarian Try using older node version, it might be different issue for you, but i was facing similar issue but issue got resolved after building the project using cordova-ios 6.3.0 and Node 14.

I have the same issue.
XCode 15.2
NodeJS v18.20.5 or v22.12.0


Initial setup of CI using GitHub Actions

The objective here is to get a working CI workflow setup using GitHub Actions as a replacement for Travis CI. This is prep work for additional changes in the pipeline, i.e. sun setting older Django versions and supporting newer ones and any other changes.
I wanted to have the tests passing (using tox) under the supported Python versions (3.7, 3.8, 3.9). An example of a successful run is here: https://github.com/emiel/django-lifecycle/actions/runs/2585559370.
The "Lint" job is an example of what could be done and we'd need to decide on what exactly we want to enforce. I tried to mimic what was already there for Travis. It is allowed to fail at the moment and we should come back to this.
See the individual commit messages for more details.
Addresses issue #100.
Let me know if you need more info.

Hi @rsinger86. I was away on holiday for a while. Was curious if you had a chance to look at this PR? Thanks!


Support for AppBarLayout

Is there an example on how to use the CAB when using AppBarLayout? Since AppBarLayout is a LinearLayout and not a frame layout the positioning and some other things don't work as expected.
It would also be interesting to know if the CAB can be used in conjunction with the TabLayout.

+1 for both

Hide/Show actionbar works for me on Callback in case of AppBarLayout.

I also found a way to get it working. My XML looks like this:
<android.support.design.widget.AppBarLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
<EMAIL_ADDRESS>
    <android.support.v7.widget.Toolbar
        android:id="@+id/activity_main_toolbar"
        android:layout_width="match_parent"
        android:layout_height="?attr/actionBarSize"
        android:background="?attr/colorPrimary"
        app:layout_scrollFlags="scroll|enterAlways"
<EMAIL_ADDRESS>
    <ViewStub
        android:id="@+id/cab_stub"
        android:layout_width="match_parent"
        android:layout_height="?actionBarSize"/>

    <android.support.design.widget.TabLayout
        android:id="@+id/activity_main_tabs"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"/>

</android.support.design.widget.AppBarLayout>

And then I just hide / show the Cab whenever I want to and it overlays over the Toolbar.


libfabric: 1.21.0 -> 1.22.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ofiwg/libfabric/releases.
meta.description for libfabric is: Open Fabric Interfaces
meta.homepage for libfabric is: https://ofiwg.github.io/libfabric/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.22.0 with grep in /nix/store/m9cfx85gh9nax3za8i3rp5wkf4b9l6fb-libfabric-1.22.0
found 1.22.0 in filename of file in /nix/store/m9cfx85gh9nax3za8i3rp5wkf4b9l6fb-libfabric-1.22.0

Rebuild report (if merged into master) (click to expand)

337 total rebuild path(s)

337 package rebuild(s)

First fifty rebuilds by attrpath

ants
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
bicgl
bicpl
c3d
cdo
cloudcompare
conglomerate
costa
cp2k
dbcsr
dl-poly-classic-mpi
dtcmp
ebtks
eccodes
elastix
elmerfem
elpa
entwine
ezminc
febio
fftwMpi
freecad
frigate
gdal
getdp
globalarrays
gmt
gnudatalanguage
gplates
grass
gromacsCudaMpi
gromacsDoubleMpi
gromacsMpi
haskellPackages.haskell-mpi
haskellPackages.hgdal
haskellPackages.mpi-hs-binary
haskellPackages.mpi-hs-cereal
haskellPackages.mpi-hs-store
hdf5-mpi
highfive-mpi
hp2p
hpcg
hpl
hypre
inormalize
ior
itk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m9cfx85gh9nax3za8i3rp5wkf4b9l6fb-libfabric-1.22.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libfabric https://github.com/r-ryantm/nixpkgs/archive/af61496e9e9c450fd73d3ea361f6c1b0a58b80cf.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/af61496e9e9c450fd73d3ea361f6c1b0a58b80cf#libfabric

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m9cfx85gh9nax3za8i3rp5wkf4b9l6fb-libfabric-1.22.0
ls -la /nix/store/m9cfx85gh9nax3za8i3rp5wkf4b9l6fb-libfabric-1.22.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 120m and timed out

Maintainer pings
cc @bzizou for testing.

Result of nixpkgs-review pr 330329 run on aarch64-darwin 1

3 packages built:

libfabric
libfabric.dev
libfabric.man

https://github.com/ofiwg/libfabric/blob/v1.22.x/NEWS.md

@GrahamcOfBorg build mpich
@GrahamcOfBorg test slurm


Add chess engine support to build mode

Have newest stockfish engine available on your website.
If possible with the UCI engine allow to play against engine mode to create openings.
Also, if possible allow UCI engine to pick random moves in openings (not necessarily the best move the engine has calculated)

More user feedback: "WOuld it be possible to have engine support while building the repertoire and a library of Grand Master games !"


Support home-manager plugin paths

Musnix currently sets plugin path environment variables for plugins either declared in environment.systemPackages or installed through nix-env, but not plugins declared in home-manager's home.packages. For example, LV2 plugins installed that way are stored in /nix/var/nix/profiles/per-user/<user>/home-manager/home-path/lib/lv2 and /etc/profiles/per-user/<user>/lib/lv2/.

No objection here.  I don't use home manager myself, so PRs welcome!


Snz main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: eduard-nz:x: sam-hepenstalYou have signed the CLA already but the status is still pending? Let us recheck it.


build janus videoroom

Pull Request Test Coverage Report for Build 2241

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.1%) to 79.992%

Files with Coverage Reduction
New Missed Lines
%

pkg/ice/candidatepair.go
2
91.53%

pkg/ice/candidate.go
2
92.22%

dtlstransport.go
4
75.71%

Totals

Change from base Build 2223:
-0.1%

Covered Lines:
3858

Relevant Lines:
4823

💛  - Coveralls

Moved to #454 to fix the CI issues.


Update cgmath to v0.7

I’m wondering if there’s any particular reason for not updating cgmath. Thanks!
Regards,
Ivan

Thanks! Sorry for the delay.


Small Feature Request - Show state of themeId on theme watch

This is very opinionated but I had added it to my fork of gulp-shopify-upload before moving to ThemeKit, and found it very helpful.
Its awesome that when you run theme watch it lets you know the themeId. e.g.
Watching for file changes for theme 123456789 on host mysite.myshopify.com
What I found very helpful, and eliminates some second guessing when moving between published and unpublished themes was to also expose the state of the themeId. e.g.
Watching for file changes for theme 123456789 ( main ) on host mysite.myshopify.com
Watching for file changes for theme 123456789 ( unpublished ) on host mysite.myshopify.com
Its a tiny little thing but at a glance makes it easy to know if the changes we're about to make are going to the right spot. There's been many times I have run the wrong command by accident, or didn't swap out to a new theme id before running theme watch and had a brief 'oh crap that was close' moment.
Just throwing this out there. I don't know GO so I'm pretty much useless there. Would contribute if I could.
Thanks for all the great work on ThemeKit, it rocks!

+1 on this and an addition:
The Ruby CLI had the command theme open which opens the shop in a browser with ?preview_theme_id=THEME_ID. This is extremely helpful when you are using the workflow with multiple themes on 1 shop.
The Ruby CLI did not output the URL though, which is annoying when needing to share with other people because Shopify does a redirect and removes the query string.

Hey thanks for the suggestions, @justinmetros I should be able to do this no problem.
@sdn90 I should be able to do this. I can also output the link to the console as well as open it.

Hey so with PR #260 that finishes up these request, these features will be in the next release.


Fixes #723 Views now are notified when they are added or removing.

If a view have several views the events will get called for each one and in the event parameter will have the view being added or being removing. If there is no need to execute more than once it only need to add a flag to the event that was already executed.

Can you share what is the rationale for this change?
Generally, I would like to keep with the original UIKit idioms if possible, and if so, I would add a 'ViewWillBeAdded" virtual method, and a "ViewWillBeRemoved".   I see that this is being done via events, and I am wondering what is the scenario that would require this.

It is to notify the view that already added to the SuperView. About the names I prefer let @tig comment.

Can you share what is the rationale for this change?
Generally, I would like to keep with the original UIKit idioms if possible, and if so, I would add a 'ViewWillBeAdded" virtual method, and a "ViewWillBeRemoved". I see that this is being done via events, and I am wondering what is the scenario that would require this.

Virtual methods are useful for derived classes (like ComboBox). Events are useful for clients.
In this case, you are correct, the use-case is for a derived class, and thus virtual method should be sufficient.
If we also apply the tenet "Only Add APIs where there is a real, clear, use-case" then we should ONLY add the virtual method for when a view is added in this PR, because that is all @fergusonr requires to make ComboBox work.

On names: The actual implementation is synchronous and the call to the virtual method (or the event) happens as the view is being added. In the PR, the call to the virtual function happens AFTER the call to subviews.Add. Thus the proper tense is "past tense". Thus the name of the virtual function (and event if it's required) should be past tense: "Added".
Since this refers to another method, where "View" is not included in the name, we should not include "View" in the name here either. Thus the virtual function, being consistent with the rest of the project, should be "OnAdded".

Really great work!

If the Dispose method on a view is called, would subviews expect to have Removed be called?
In my IDisposable PR, View has this Dispose method:
/// <inheritdoc/>
protected override void Dispose (bool disposing)
{
	foreach (var subview in InternalSubviews) {
		subview.Dispose ();
	}
	base.Dispose (disposing);
}

I'm trying to merge this PR into that one, and I've found the place where my instincts were screaming Removed is a bad idea.
As coded above, subviews will never had Removed get called when their parent gets cleaned up, because Remove is never explicitly called. However they ARE definitely removed (implicitly).
I think there are four ways to fix this (maybe more):

Remove Removed from the API until someone really needs it and can say what they want to happen in the case of Dispose.
Change the code above to pass through InternalSubviews calling Remove (subview); this has to be done with a copy of the List because you can't Remove an item in a List while enumerating it. This adds complexity.
Change the definition of Remove such that it destroys (calls Dispose) on the subview.
Don't fix it - Clients that depend on the Removed event will not be certain the event will be fired.

Please guide me. Thanks.

Ok @tig I will study this. I really already have ideas about using the Removed event for some things and one of the reasons that led me to change from Removing to Removed was to think that the subscriber who wants to use it if called after the view has been removed would give a null argument exception but that is not what happened, because what is being removed is the List<View> item and not the view itself. Only the view.container is set to null. So, if there is an error in IDispose it has nothing to do with this event but because of the iteration with the List<View> which then detects that the list has been changed. In this case, use for loop.

@tig you can do more or less this:
		protected override void Dispose (bool disposing)
		{
			List<View> vToDispose = new List<View> ();
			foreach (var subview in InternalSubviews) {
				subview.Dispose ();
				vToDispose.Add (subview);
			}
			foreach (var v in vToDispose) {
				Remove (v);
			}
			base.Dispose (disposing);
		}

Here is the unit test:
		[Fact]
		public void Added_Removed_IDispose ()
		{
			var v = new View (new Rect (0, 0, 10, 24));
			var t = new View ();

			v.Added += (View e) => {
				Assert.True (v.SuperView == e);
			};

			v.Removed += (View e) => {
				Assert.True (v.SuperView == null);
			};

			t.Add (v);
			Assert.True (t.Subviews.Count == 1);

			t.Dispose ();
			Assert.True (t.Subviews.Count == 0);
		}

If decreasing, it would be like this:
		protected override void Dispose (bool disposing)
		{
			IList<View> vToDispose = new List<View> ();
			foreach (var subview in InternalSubviews.Reverse ()) {
				subview.Dispose ();
				vToDispose.Add (subview);
			}
			foreach (var v in vToDispose.Reverse ()) {
				Remove (v);
			}
			base.Dispose (disposing);
		}


[# 7 TES 1.1 Spec compliance]  Adding streamable flag to tesInput

Adding streamable flag to tesInput CoA PR 444

Relevant tool to test with: https://gatk.broadinstitute.org/hc/en-us/articles/360036883491-GenomicsDBImport

This was regressed by #404


Size adjustable

Problem
I am trying to use this as an alarm set on a small tablet near my bed but it is too small to really use.  I am looking for ways to increase the box size.  I have found ways to adjust the font by putting this in a custom button card but then the numbers run outside the boxes.
Suggested feature / solution
Can there be a setting to adjust the proportions of the elements.

This is a great idea!
I have had to modify the .css code in the time-picker-card.js file to get mine looking good.
I tried to change the css with the card-mod integration, but it just wouldn't change anything.

I added a theme variable time-picker-control-padding that will enable you to control the padding of the elements - making their hitboxes larger. Released in 1.2.0
You can try something like: --time-picker-control-padding: 12px or --time-picker-control-padding: 12px 16px.
I'm not entirely sure this is the best solution, but it's a start. Let me know if it works for you or if you were looking for something different.


Redux 09 - Ambiguous wording

Hey! Thank yall for putting these together; I'm doing the Redux modules to finally get my hands dirty with Redux and these are super helpful 👍 👍
I just wanted to bring attention to some of the wording on the Redux 09 challenge. The beginning of the instructions reads:

Write the store.subscribe() method, passing in a function which logs a message to the console everytime the store receives an action.

I think what would be more clear would be to say something like:

Write a callback function that logs a message to the console every time the store receives an action, and pass this function in to the store.subscribe() method.

As it stands currently, it kind of sounds like the test is asking you to write the store.subscribe method itself, when what it's really looking for is just a callback function that gets passed to store.subscribe. Hope that makes sense! I'd be happy to submit a PR with the changes if others feel similarly 💃

Yeah, I think this is a good improvement! I just changed it to the sentence you suggested and updated it. Thanks for this, we haven't gotten a lot of people reviewing Redux and React/Redux so please add any other comments or feedback you come across.


AndWhere()/OrWhere() improvements

Hi, i try  to build cypher query dynamically.
For example
var query =_client.GraphClient.Cypher.Match($"(user:{Neo4jNode.User})-[:{Neo4jEdge.Watched}]->(entity:{Neo4jNode.Movie})");

query = ApplyFilter(query, filterModel);

public ICypherFluentQuery ApplyFilter(ICypherFluentQuery query, MovieFilterRequestModel model)
{
	if (model.Category != default)
	{
		query = query.AndWhere((MovieGraphModel entity) => entity.MovieType == model.Category);
	}

	if (model.FromYear != default)
	{
		query = query.AndWhere((MovieGraphModel entity) => entity.Year >= model.FromYear);
	}

	if (model.ToYear != default)
	{
		query = query.AndWhere((MovieGraphModel entity) => entity.Year <= model.ToYear);
	}

	if (model.AgeLimit != default)
	{
		query = query.AndWhere((MovieGraphModel entity) => entity.AgeLimit >= model.AgeLimit);
	}

	return query;
}

Cypher client generate incorrect query in my case because i never called Where() before AndWhere()
So i propose add check (in case if Where() newer called insert where auto) for methods   AndWhere() and OrWhere() to prevent situation like my
I can fx (and i fx) this issue by adding .Where("true") on the start of query, but its looks bad.
Thanks

Have the same problem and I'm also always using bad looking workarounds.

Hi both,
The TL;DR; is that I won't do this as that would make the client write queries that the user didn't ask for.
If I write .Cypher.AndWhere("code") I would expect to have AND WHERE in my output, not WHERE 1=1 AND WHERE code - the client shouldn't add things that are not asked for.
Your workarounds are being done because it's easier to put everything as AndWhere instead of checking yourself for the use of a .Where, and I get that, it makes the code a lot simpler, but as a side to that - you'll have to use the Where("true") workaround - or keep track yourselves.
All the best
Chris

What if the client just drops the AND if there haven't been a WHERE before so it will not add things not asked for but also not produce a cypher that will not work. I know we all could keep track of that ourselves but this really produces lots of unnecessary code. If you don't want to break to get what's expected, what about a new Method something like .OptionallyAndWhere which could be used perfectly for such looping scenario.

Dropping the AND is the same as changing the query - I asked for AND WHERE not WHERE.
I would say it's not unnecessary code, in fact, it's the exact opposite - you need to keep track of the Where - as if you don't, it errors. Luckily there is a shortcut which saves you having to do it, but you know what you write is what is being sent to the server.
The code for an OptionallyAndWhere would require adding a lot of tracking code into the client - where it wouldn't know all the use-cases and as a consequence is substantially more complex and time consuming, and invariably when you do things like this - there are edge cases that pop up that require more time to develop - this is not the case with Where("true").
This comes down to wanting to replace:
.Where("true") with
.OptionallyAndWhere()
Which is in my view far less clear. Do you mean that it's optional that the Where occurs? Optional And? if there is a where before - does this mean it can be done, but might not?
For the sake of 13 characters vs the amount of code to add into the client - it's something I am quite happy to live with.

Chris, sorry, your right, I didn't had the .Where("true") in mind as I never used it before. Unlucky, my approaches were a bit more complex ;-) The .Where("true") really should be enough and thanks to @Rocket18 I learned that today.

you are welcome @Clooney24


Failed to implement HA by installing Keepalived in a container

I installed Keepalived in virtual machine and successfully got a VIP. Then I try to implement this in a Docker container but failed to get a VIP.
I thought the reason why I didn't got the VIP is a Docker container can't control its network configuration freely but something weird occurred.
After using service keepalived start I got different results below with command ps -ef|grep keepalived
In virtual machine:
root 99687 1 ... /usr/sbin/keepalived -D
In Docker container:
root 8921  1 ... /usr/sbin/keepalived -d

In Keepalived, para D stands for detailed log but para d stands for dumping config data. I found that I got two totally different results with same installation and configuration. Besides, even I use /usr/sbin/keepalived -D in the Docker container to start Keepalived I still get no log in /var/log/messages which can show log of Keepalived on virtual machine.
I wonder whether Keepalived in Docker can work well. If the answer is yes, please tell me your solutions.
Thank you!

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Besides, even I use /usr/sbin/keepalived -D in the Docker container to start Keepalived I still get no log in /var/log/messages

Logging to /var/log/messages is generally controlled by a syslog daemon. For messages to appear in /var/log/messages on the host, you need to allow the container some way of connecting to the syslog daemon, such as -v /dev/log:/dev/log (though this is not without issues). For messages to appear in /var/log/messages inside the container, you need to start a syslog daemon inside the container.

@dieuroi Thanks for reporting, however this is not quite the right forum for support related questions.
Please use the docker-user mailing list, #docker on IRC, or forums.docker.com
Thanks!


Add option to disable warnings .svelte editors

The warnings are a distraction because things work fine without addressing them.

I believe you're mentioning erroneous warnings that were caused by lacking compatibility of this plugin with Svelte 3.
In the new version (1.0.0) of this plugin, any error/warning that you see should be an actual problem.
If really you want to disable even non-erroneous warnings, this would be done in the linter package. (Unfortunately, at the time of writing, disabling the kind of linters provided by this plugin is not supported in the linter, which is what I personally use -- don't know if this applies to your situation).
I'm closing this because the formulation "because things work fine without addressing them" makes me think that the actual request was about erroneous warnings, which should be fixed now.
If someone is really interested in a "disable diagnostics" feature, this might be doable. Please open a new issue and we'll consider it.

Should be fixed in v1.1.0, that adds options to disable diagnostics for ts, js, or svelte.


Add drawing line or basic shapes method to Image

For debugging.
Ideally, it would be possible to develop a prototype without preparing images.

Let's use shaders to draw lines or circles!

Path interface:

BeginPath
StrokePath
MoveTo
LineTo
BezierCurveTo
QuadraticCurveTo
Arc
ArcTo
Ellipse
Rect
Clip?

Image methods:

FillPath
StrokePath

It sounds nice if these are in exp (experimental) package.

It seems hard to implement filling in a polygon (especially on WebGL).

DrawPoints
DrawLines
DrawBezierCurves
DrawQuadraticCurves
DrawArcs
DrawPies
DrawEllipses
DrawRects
FillPies
FillEllipses
FillRects

How about cardinal spline?

Actually added:

DrawLine
DrawLines
DrawRect
DrawRects
FillRect
FillRects

I think that's enough so far for v1.2. I'll add other methods if required.

It seems hard to implement filling in a polygon (especially on WebGL).

NOTE: I found it's possible if I use stencil buffers. In this case, the filling algorithm would be even-odd.


Advance filtering

Being able to not only sort but also filtering by:

Name of instance
Name of username
Is on a specific list
Is not on a list
Is a bot

Ideally it will support AND OR operations, for example
Filter accounts not on the list IRL AND that are in the instance friends instance

I don't know what this means, but I'd love to sort/filter by follows/followers and posting frequency. (I know, that's hard to define. But maybe can be estimated by "how long ago was the 10th post"?)
Thanks for building this! List management is sorely lacking in many clients and frontends.

@gerwitz just added an option to sort by number of posts and last post on 0.1.6

Love that you defined non-goals 😃


Installation failed

npm i @tailwindcss/custom-forms

PS E:\src\project\orbicall2> npm i @tailwindcss/custom-forms
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/tailwindcss
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@tailwindcss/custom-forms
npm ERR!   @tailwindcss/custom-forms@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\AXA\AppData\Local\npm-cache\eresolve-report.txt for a full report.
npm ERR!      C:\Users\AXA\AppData\Local\npm-cache_logs\2021-09-01T10_37_04_826Z-debug.log

# REPORT :  npm resolution error report

2021-09-01T10:37:04.820Z
While resolving: undefined@undefined
Found<EMAIL_ADDRESS>node_modules/tailwindcss
dev<EMAIL_ADDRESS>from the root project
Could not resolve dependency:
peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>node_modules/@tailwindcss/custom-forms
@tailwindcss/custom-forms@"*" from the root project
Fix the upstream dependency conflict, or retry
this command with --force, or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.
Raw JSON explanation object:
{
"code": "ERESOLVE",
"current": {
"name": "tailwindcss",
"version": "2.2.9",
"whileInstalling": {
"path": "E:\src\project\orbicall2"
},
"location": "node_modules/tailwindcss",
"isWorkspace": false,
"dependents": [
{
"type": "dev",
"name": "tailwindcss",
"spec": "^2.2.7",
"from": {
"location": "E:\src\project\orbicall2"
}
}
]
},
"currentEdge": {
"type": "dev",
"name": "tailwindcss",
"spec": "^2.2.7",
"from": {
"location": "E:\src\project\orbicall2"
}
},
"edge": {
"type": "peer",
"name": "tailwindcss",
"spec": "^1.0",
"error": "INVALID",
"from": {
"name": "@tailwindcss/custom-forms",
"version": "0.2.1",
"whileInstalling": {
"path": "E:\src\project\orbicall2"
},
"location": "node_modules/@tailwindcss/custom-forms",
"isWorkspace": false,
"dependents": [
{
"type": "prod",
"name": "@tailwindcss/custom-forms",
"spec": "*",
"from": {
"location": "E:\src\project\orbicall2"
}
}
]
}
},
"peerConflict": null,
"strictPeerDeps": false,
"force": false
}

Use @tailwindcss/forms instead, this project (tailwindlabs/tailwindcss-custom-forms) is not compatible with Tailwind CSS v2.0+ and has been deprecated.


Add Console to log4j2.xml

With the console setup for log4j we can make a choice about logging and Advice going to multiple loggers and assure visibility of important information.

Actually there is some fine tuning here.


fix(aws-alb-fargate): change container used to launch integ tests

Issue #, if available:
#961
Description of changes:
These integration tests now use a minimal container available publicly in our account so they pass a health check and the integ stack launches when being refreshed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 83e1323ce33cc31bb1c9b1d2c1fb2bbc4dbe342d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 9d79d9b193030c941777a9bef8b3e44e17541189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 396efd221c7fd3727a249746cc3e78a985316f5d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Data Science Tutorial Folder

Adding Data Science Tutorial Folder, in this folder it contains:

Basic Python Tutorial scripts.
Pandas Practice Scripts.
Numpy Practice scripts.
EDA
Data Visualization
Scikit Learn (for intermediate level in data science)

accepted


Venv naming with space fix

Fixed venv names with spaces breaking.
Additonally added a check for venv existing such that the nodes will not function before a venv is selected.
In addition also added "default" to the version displayed when entering the venv configuration for the first time to make it clearer that it is an option.

Thank you @FrederikPM !
I intended to run the node without setting venv-config for backward compatibility, but if I get an error that it is not set, I think it is fine even if I can't run it.
I have checked that the version is set to "default".

In a previous Pull Request #6 , there was a case that I could not execute due to a difference in the quotation type.
In this case, the same error occurred in the Windows environment.
Single quotes were treated as part of the string.

Double quotes resulted in the expected folder name.
I also checked that it can be created even if there is a space in the name.

Also, if "default" is entered in this.version in venv-config.js, the virtual environment cannot be created.
This is because when it should be -3.8, etc., it becomes -default like below.
python -default -m venv pyenv
If "default" is not set in this.version in venv-config.js, the virtual environment can be created.

The modified program for venv-config.js is as follows.
Could you try it in your environment ?

module.exports = function(RED) {
    function venvConfig(config) {
        RED.nodes.createNode(this, config)
        this.venvname = config.venvname
        this.version = config.version

        const path = require('path')
        const fs = require('fs')
        const execSync = require('child_process').execSync
        const setupPath = path.join(path.dirname(__dirname), 'setup.py')
        let venvPath = path.join(path.dirname(__dirname), this.venvname)

        let command = `python ${setupPath} "${this.venvname}"`
        if(typeof this.version !== 'undefined' && this.version !== '' && this.version !== 'default') {
            command += ` ${this.version}`
        }
        execSync(command)

        this.on('close', function(removed, done) {
            if (removed) {
                fs.rmSync(venvPath, { recursive: true, force: true })
            }
            done()
        })
    }
    RED.nodes.registerType("venv-config",venvConfig)
}

Ah I didn't notice how the default environment was actually parsed to a version. I've added your changes to the PR :)

Thank you @FrederikPM !
I confirmed that it works correctly.
I merge this Pull Request, and modify README.


Error when running with PromptGen_Large_v2.0  (base is okay though)

# ComfyUI Error Report
## Error Details
- **Node Type:** Miaoshouai_Tagger
- **Exception Type:** Exception
- **Exception Message:** data did not match any variant of untagged enum ModelWrapper at line 259572 column 3
## Stack Trace

File "/home/ComfyUI/execution.py", line 323, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "/home/ComfyUI/execution.py", line 198, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "/home/ComfyUI/execution.py", line 169, in _map_node_over_list
process_inputs(input_dict, i)
File "/home/ComfyUI/execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
File "/home/ComfyUI/custom_nodes/ComfyUI-Miaoshouai-Tagger/nodes.py", line 144, in start_tag
processor = AutoProcessor.from_pretrained(model_path, trust_remote_code=True)
File "/home/ComfyUI/venv/lib/python3.10/site-packages/transformers/models/auto/processing_auto.py", line 317, in from_pretrained
return processor_class.from_pretrained(

Receiving same result

same result

update your transfomer

update your transfomer

Following this method, the problem is solved, thank you very much

My transformers version is 4.43, which meets your requirement of transformers >= 4.38.0. However, I still got this error message. I really don't know what to do next. Looking forward to your reply. Thank you!

我的transformers也升级到了4.43，也是出现同样的问题，求解答

我的transformers也升级到了4.43，也是出现同样的问题，求解答

版本过高也不行，我测试安装4.38.0或者4.39.0都可以解决这个bug，

我的transformers也升级到了4.43，也是出现同样的问题，求解答

版本过高也不行，我测试安装4.38.0或者4.39.0都可以解决这个bug，

多谢提示，尝试了几个版本的transformers，但是还是同样的错误

i have the same error when my transformers 4.44.2，but when i upgrade transformer to the leatest 4.46.2，it's solved the error.

i have the same error when my transformers 4.44.2，but when i upgrade transformer to the leatest 4.46.2，it's solved the error.

worked for me too