default scan profile for a k8s 1.15 cluster is incorrect

On 2.5-head - commit id: 48254f944  and ui-dashbaord-index pointing to: releases.rancher.com/dashboard/release-2.5.4
cisoperator:
    repository: rancher/cis-operator
    tag: v1.0.3-rc5
  securityScan:
    repository: rancher/security-scan
    tag: v0.2.2-rc5

Deploy CIS v2 on a cluster. k8s v 1.15
The Create scan CR
Default scan profile is CIS 1.5 instead of rke permissive 1.5 profile

As per @mantis-toboggan-md 's comments: The issue I'm having picking a default profile on the UI side is that for this 1.15 RKE cluster, the default-clusterscanprofiles configmap shows rke: rke-profile-permissive-1.6 which is not a valid profile for 1.15

@mantis-toboggan-md I have added PR to fix the default-clusterscanprofiles configmap to carry multi-line value for the key rke as follows:
kind: ConfigMap
apiVersion: v1
metadata:
  name: default-clusterscanprofiles
  namespace: {{ template "cis.namespace" . }}
data:
  # Default ClusterScanProfiles per cluster provider type
  rke: |-
    <1.16.0: rke-profile-permissive-1.5
    >=1.16.0: rke-profile-permissive-1.6
  rke2: "rke2-cis-1.5-profile-permissive"
  eks: "eks-profile"
  gke: "gke-profile"
  default: "cis-1.6-profile"

Thus this Configmap will carry the  default rke profiles mapped to the k8s major version to be used. Can UI read this info and show appropriate profile that matches the given cluster's k8sversion?


push_snapshot doesn't keep the promoted files csv

Hi,
thank you for your useful tool. I have a problem when I used push_snapshot to create a new data source from Dremio 1 to Dremio 2. It finished well but I figured out that all the files csv promoted on Dremio 1 now not promoted anymore on Dremio 2. Do you have any idea ?
thanks

Hi,
Is your data source protected with credentials? If so, Dremio does not expose credentials via API. As a result, when you created a snapshot, it did not contain credentials and now push_snapshot cannot create a new data source without proper credentials. Please let us know if it resolved the issue.
Thanks


Navbar is not responsive

Navbar is not at all responsivle as well as there is no hamburger for smaller screens it will not show the options or sections in the navbar on smaller screens.

@PSS2134 I also want to work on this issue, can you please assign it to me?


Integrate gaussian splatting?

Hi! Any chance you can implement this approach
https://github.com/graphdeco-inria/gaussian-splatting/tree/main
Into the unreal plugin?
It gives great results and is quick to train.
Thanks!

https://www.unrealengine.com/marketplace/en-US/product/410c8105b3aa41d38ab68660295bd7f3?lang=en-US
3D Gaussians Plugin in UE5 market, $99.99

Thanks!


Wrong rancher container started after os update

Hi,
I updated Rancher from 0.24 to 0.25 using the method described in the documentation. I kept the 0.24 container under the name original rancher and started 0.25 under the name latest_rancher doing a volume_from original rancher;
That worked perfectly fine.
Now each time I do a RancherOS upgrade and have to reboot, the original_rancher container is launched but not the latest_rancher. Which mean I have to manually stop and start container to have the latest version running.
It's a bit of a pain, especially when updating regularly like now with the beta going on.

@moimael This does suck...  The problem is that if you have --restart=always on the container, even if the container was stopped when the Docker daemon is restarted Docker will start it back up.  I don't think that is the correct behavior.  I'll take that up with the Docker team and see what they think.  For a fix for your issue I'd do the following:
docker create --volumes-from orignal_rancher --name rancher-data rancher/server
docker run --restart=always --volumes-from rancher-data -p 8080:8080 rancher/server

@deniseschannon Our instructions should probably tell people to create a rancher-data container from the original.
Then you can delete original_rancher.  Now going forward just keep the rancher-data container around and the current rancher server.

Thanks ! I'll try this ASAP. I agree on updating the doc, because it is very confusing when you begin updating rancher.

@moimael We've updated the documentation to reflect creating a data container for upgrading.


Question: Best use of NullAway in specific scenarios

Dear, NullAway sourcerers! First of all, thanks for such a great tool.
I have two questions related to NullAway issues I've been seeing in our codebase.
First, if a class has methods like hasX() which checks that field X (which is nullable) isn't null, NullAway doesn't understand it. And so, it complains about follow-up usage of X. The @Contract annotation doesn't work in this case, as no parameters are passed to hasX. I also don't think the annotation has support for fields in its specification, to be honest.
Second, it's truly great that NullAway understands that the get() operation of a Map can return null. However, in some pieces of code, the algorithm ensures that the get() will always returns a value. Extracting the get() to a private method which does the checks or wrapping the call up with Objects.requireNonNull works but doesn't look nice, aesthetically speaking.
I wonder if there's a best way to solve these two issues without having to suppress the warning. If you see some improvement that can happen in NullAway to support these cases, I'm happy to follow your guidance and try and do it myself.
Thanks for the help!

Thanks for the questions!

First, if a class has methods like hasX() which checks that field X (which is nullable) isn't null, NullAway doesn't understand it. And so, it complains about follow-up usage of X. The @Contract annotation doesn't work in this case, as no parameters are passed to hasX. I also don't think the annotation has support for fields in its specification, to be honest.

You're correct we don't have support for this right now.  We actually do support @RequiresNonNull and @EnsuresNonNull for instance fields (I'm working on updating the wiki docs now), but you would need something like Checker Framework's @EnsuresNonNullIf for this case.  I'm open to supporting this if you'd like to make a contribution!

Second, it's truly great that NullAway understands that the get() operation of a Map can return null. However, in some pieces of code, the algorithm ensures that the get() will always returns a value. Extracting the get() to a private method which does the checks or wrapping the call up with Objects.requireNonNull works but doesn't look nice, aesthetically speaking.

Here I'd like to see an example to understand better.  We do have logic to support get() calls that are guarded under a call to containsKey().  But it sounds like your case is something different.

Hi, @msridhar, thanks for the response!
For 1, EnsuresNonNull solves our case! Great!
For 2, we do have a good number of maps that we create based on, say, enum keys, and later, we get() based on key, so, we are sure there's always a value for that key.

For 1, EnsuresNonNull solves our case! Great!

Honestly I'm a bit surprised :-)  If hasX() is just returning a boolean, but is not actually initializing the field if it is null, I would expect an error reported on the hasX() method (since it doesn't ensure the field is non-null).  I can test this later.

For 2, we do have a good number of maps that we create based on, say, enum keys, and later, we get() based on key, so, we are sure there's always a value for that key.

Yeah, unfortunately we don't have built-in handling for this.  My best suggestion is adding a castToNonNull method and using that.  If you pass the -XepOpt:NullAway:CastToNonNullMethod option, NullAway will make sure that you only cast expressions that are @Nullable, which can be a good sanity check.

For 1, I said "it solved our case", but I haven't tried that in practice yet. I'll reach out to the engineer that had this issue and try it together with him 😆 I'll get back to you.
For 2, yeah, that's the solution I also see! Ok, I'll be suggesting that!

@msridhar It indeed doesn't work! If you give me a few pointers, I'd like to try implementing something like VerifiesNonNull("field") boolean hasField() which then tells the method that field can't be null after the call.

A quick brain dump of thoughts here.

I think we'd want to call the annotation @EnsuresNonNullIf to match the Checker Framework naming.  See their Javadoc.  We can just support instance fields of the receiver to start I think.
We need to use the information from this annotation at call sites to learn that a field is non-null if the call returns a certain boolean.  You can see how things are done for EnsuresNonNull here.  We'd probably want an EnsuresNonNullIfHandler that does something similar, but only modifies the thenUpdates or elseUpdates as appropriate.
We need to verify the annotation is correct for the annotated method.  This requires checking that for all return statements, if they may return the boolean indicated in the annotation, then the relevant fields are definitely not null.  I don't know if we have code exactly like this, but the code for checking nullability for filter operations on streams might be the closest thing, here.

Hope that's enough to get you started 🙂

@msridhar I have a simple draft ready, with a few open questions! Should we continue the conversation in the PR?

Yup, I've commented there!

I am closing this issue since it's solved by PR #1044!


[IMPROVEMENT] Hint users there are resources remaining on the node or disk after eviction

Is your improvement request related to a feature? Please describe (👍 if you like this request)
Currently, we support manually evict BackingImages and Replicas on the node or disk by setting

Scheduling = disable
Eviction Request = True

There are cases that the resources won't be evicted

Failed to evict replica for now since there is no other healthy replica
Failed to evict backing image copy on disk for now since there is no other healthy backing image copy

Users have to check themselves to see if there are resources remaining.
Describe the solution you'd like

Add conditions to Node and Disk
When the node or disk is under eviction requested, Longhorn checks if there are resources remaining and update the condition
We can show the condition to the UI, so users can easily check the results of eviction.

Describe alternatives you've considered
.
Additional context
cc @derekbit

Waiting for https://github.com/longhorn/longhorn/issues/8757 to be finished
So we can also check the remaining backing image on the evicted node/disk

Best effort in v1.8.0.

Move to v1.9 and best effort in v1.8


Fix issue #140

Simply check if up.sql and down.sql exists. Ignore all other files.

If this were to go through based on the discussion in #140 you would need to update or remove the directory_containing_unknown_files_is_not_valid_migration_dir() test.


Increase b:changedtick for changes to quickfix / location list windows

Using :laddexpr or calling setloclist() should increase b:changedtick for the quickfix / location list, if the list was modified.
This way it could be used to invalidate a cache etc.

Hi,
On Wed, Jul 12, 2017 at 11:09 AM, Daniel Hahler
<EMAIL_ADDRESS>wrote:

Using :laddexpr or calling setloclist() should increase b:changedtick for
the quickfix / location list, if the list was modified.
This way it could be used to invalidate a cache etc.

Can you try the attached patch? If there are no issues, I will send out
a patch with tests and doc update.

Yegappan

diff --git a/src/quickfix.c b/src/quickfix.c
index 3889a9565..76e068044 100644
--- a/src/quickfix.c
+++ b/src/quickfix.c
@@ -3088,6 +3088,7 @@ ex_copen(exarg_T *eap)
* Fill the buffer with the quickfix list.
*/
qf_fill_buffer(qi, curbuf, NULL);

CHANGEDTICK(curbuf) = 1;
curwin->w_cursor.lnum = qi->qf_lists[qi->qf_curlist].qf_index;
curwin->w_cursor.col = 0;
@@ -3289,6 +3290,7 @@ qf_update_buffer(qf_info_T *qi, qfline_T *old_last)
qf_update_win_titlevar(qi);

qf_fill_buffer(qi, buf, old_last);

++CHANGEDTICK(buf);
if (old_last == NULL)
{

Using  :laddexpr  or calling setloclist() should increase b:changedtick for the quickfix / location list, if the list was modified.

Sorry, I disagree.  The way I understand it, b:changedtick was meant to keep track of undoable changed to the buffer, not to the loclist / quickfix list.  Making setloclist() update b:changedtick would break at least syntastic, which uses it to avoid unnecessarily running linters if the buffer hasn't changed since the last run.  Perhaps you can do your own bookkeeping based on b:changedtick and a QuickFixCmdPost?  Trying to manipulate loclists outside the standard stack is already a pain as it is, please don't make it even more so.

@lcd047 b:changedtick has nothing to do with undo, it is meant to keep track of changes to the buffer, without the “undoable” adjective. And if I understand what patch is doing and what @blueyed is suggesting then it increases b:changedtick for the buffer which shows the quickfix/location list, not for a buffer which happened to be current when :laddexpr was run. If syntastic has any problems with this (I really doubt so) it is utterly broken.

b:changedtick has nothing to do with undo

Whatever.  What I said stands regardless.

And if I understand what patch is doing and what @blueyed is suggesting then it increases b:changedtick for the buffer which shows the quickfix/location list, not for a buffer which happened to be current when :laddexpr was run.

Apples and oranges.  I don't particularly care about :laddexpr.  I have a problem with changing b:changedtick from setloclist(), particularly because there is currently no way to parse errors with errorformat while leaving the loclist stack alone.  I need to do that because I need to munge the resulting loclist before showing it to the user.  setloclist() needs to be called before displaying the final loclist.  It can be called multiple times, because the user may decide to close the error window, then re-open it (I'm simplifying here; there's a messy bookkeeping involved to work around various unwanted interactions between autocmds).  Calling setloclist() shouldn't ever imply a buffer has changed.

If syntastic has any problems with this (I really doubt so) it is utterly broken.

Hi,
On Wed, Jul 12, 2017 at 9:45 PM, LCD 047<EMAIL_ADDRESS>wrote:

Using :laddexpr or calling setloclist() should increase b:changedtick for
the quickfix / location list, if the list was modified.
Sorry, I disagree. The way I understand it, b:changedtick was meant to keep
track of undoable changed to the buffer, not to the loclist / quickfix list.

If the buffer displayed in the quickfix/loclist window is changed, then
the b:changedtick variable is updated.  This behavior seems logical
as the buffer contents are changed. Note that this changes only the
b:changedtick variable of the buffer displayed in the quickfix/loclist
window and not for any other buffer displayed in other windows.
If you close the quickfix window and reopen it, then the b:changedtick
variable will be reset.

Making setloclist() update b:changedtick would break at least syntastic,
which uses it to avoid unnecessarily running linters if the buffer hasn't
changed since the last run.

I am assuming that the syntastic plugin checks the b:changedtick
variable for the non-quickfix buffers. So this change should not
affect the syntastic plugin.

Yegappan

Perhaps you can do your own bookkeeping based on
b:changedtick and a QuickFixCmdPost? Trying to manipulate loclists outside
the standard stack is already a pain as it is, please don't make it even
more so.

Note that this changes only the b:changedtick variable of the buffer displayed in the quickfix/loclist window and not for any other buffer displayed in other windows.

Ah, I missed that, sorry.  But then b:changedtick for this buffer seems to be the wrong thing to monitor for detecting loclist changes, because:

If you close the quickfix window and reopen it, then the b:changedtick variable will be reset.

So you can potentially get both false negatives and false positives.

Hi,
On Wed, Jul 12, 2017 at 11:29 PM, LCD 047<EMAIL_ADDRESS>wrote:

Note that this changes only the b:changedtick variable of the buffer
displayed in the quickfix/loclist window and not for any other buffer
displayed in other windows.

Ah, I missed that, sorry. But then b:changedtick for this buffer seems to be
the wrong thing to monitor for detecting loclist changes, because:

If you close the quickfix window and reopen it, then the b:changedtick
variable will be reset.

So you can potentially get both false negatives and false positives.

The b:changedtick variable for the quickfix buffer indicates how many
times the buffer has been changed/updated after it was displayed in
the quickfix window. For example, after executing the following series
of commands:
 cexpr ""
 cexpr ""
 cexpr ""
 copen
 colder
 colder
 cnewer
 cnewer

The b:changedtick variable will be set to 6. In the above case the
quickfix list itself is not changing, only the buffer showing the quickifx
list is getting updated.

Yegappan

Thank you, Yegappan.
My use case is displaying info in the statusline, e.g. the count of items - and I've noticed that it makes sense to cache it, since getloclist() seems to be rather slow on large (2k items) lists.
There should probably be a better way, e.g. an API to get just the count of items (instead of using len(getloclist(0)), but this simple patch is good to have already.

There should probably be a better way, e.g. an API to get just the count of items (instead of using len(getloclist(0)), but this simple patch is good to have already.

Or just add functions that work on loclists in memory, detached from the stack, and use the stack only when you need to show said loclists in a window.  Then len(getloclist(0)) becomes len(loclist).

@lcd047
Agreed, but that is considered to be a separate issue - managing b:changedtick still makes sense.

Hi all,
On Thu, Jul 13, 2017 at 7:30 AM, Daniel Hahler
<EMAIL_ADDRESS>wrote:

Thank you, Yegappan.
My use case is displaying info in the statusline, e.g. the count of items -
and I've noticed that it makes sense to cache it, since getloclist() seems
to be rather slow on large (2k items) lists.
There should probably be a better way, e.g. an API to get just the count of
items (instead of using len(getloclist(0)), but this simple patch is good to
have already.

I am attaching a patch that implements this along with doc update and
a test.

Yegappan

diff --git a/runtime/doc/quickfix.txt b/runtime/doc/quickfix.txt
index 0ca52aa06..e555451b5 100644
--- a/runtime/doc/quickfix.txt
+++ b/runtime/doc/quickfix.txt
@@ -425,7 +425,9 @@ EXECUTE A COMMAND IN ALL THE BUFFERS IN QUICKFIX OR LOCATION LIST:
which will indicate the command that produced the
quickfix list. This can be used to compose a custom
status line if the value of 'statusline' is adjusted

  	properly.

  	properly. Whenever this buffer is modified by a

  	quickfix command or function, the |b:changedtick|

  	variable is incremented.

  					*:lop* *:lopen*

:lop[en] [height]	Open a window to show the location list for the
diff --git a/src/quickfix.c b/src/quickfix.c
index 3889a9565..320d46ea6 100644
--- a/src/quickfix.c
+++ b/src/quickfix.c
@@ -3289,6 +3289,7 @@ qf_update_buffer(qf_info_T *qi, qfline_T *old_last)
qf_update_win_titlevar(qi);
qf_fill_buffer(qi, buf, old_last);

++CHANGEDTICK(buf);
if (old_last == NULL)
{
diff --git a/src/testdir/test_quickfix.vim b/src/testdir/test_quickfix.vim
index b3cc6891a..4dbb64e6e 100644
--- a/src/testdir/test_quickfix.vim
+++ b/src/testdir/test_quickfix.vim
@@ -2263,3 +2263,28 @@ func Test_resize_from_copen()
augroup! QF_Test
endtry
endfunc

+" Tests for the quickfix buffer b:changedtick variable
+func Xchangedtick_tests(cchar)

call s:setup_commands(a:cchar)

new | only

Xexpr "" | Xexpr "" | Xexpr ""

Xopen
Xolder
Xolder
Xaddexpr "F1:10:Line10"
Xaddexpr "F2:20:Line20"
call g:Xsetlist([{"filename":"F3", "lnum":30, "text":"Line30"}], 'a')
call g:Xsetlist([], 'f')
let cur_count = getbufvar('%', 'changedtick')
call assert_equal(8, cur_count)
Xclose
+endfunc

+func Test_changedtick()

call Xchangedtick_tests('c')
call Xchangedtick_tests('l')
+endfunc

managing b:changedtick still makes sense.

I'm not convinced it does.  You're attaching a meaning to something that has no other reason to exist, and it doesn't even solve the problem you're trying to solve in all possible cases.  This looks like a hack at best.  Why is b:changedtick better than setting a dirty flag from an autocmd on QuickFixCmdPost and recomputting the statusline when this flag is set?

Why is b:changedtick better than setting a dirty flag from an autocmd on QuickFixCmdPost and recomputting the statusline when this flag is set?

Actually autocmds on QuickFixCmdPost don't save the problem either, since loclist commands can be run with silent.
Rather than updating b:changedtick, perhaps the solution is to add a generation number to loclists and quickfix lists.  This number will be increased by :laddexpr and friends, and the user would be able to query it with getloclist().  Unlike b:changedtick however, it wouldn't be tied to a buffer.

Rather than updating b:changedtick, perhaps the solution is to add a generation number to loclists and quickfix lists.  This number would be increased by :laddexpr and friends, and the user would be able to query it with getloclist().  Unlike b:changedtick however, it wouldn't be tied to a buffer.

A better implementation: there would be a global unsigned long number, let's call it a generation seed.  Whenever any loclist is created or changed the seed would be increased, then it would be copied to the generation number of the changed loclist.  getloclist() would still retrieve the generation number from the loclist (not the seed).
This is better than the previous idea because loclists would be different if and only if their generation numbers are different.  In turn this would have many other uses.

closed by 8.0.0735


Simplify contract language

With these patches, we drop support for transactions of generic assets and instead focus only on tokens. The difference is basically that if you add two tokens, you get another token, whereas if you add two generic assets, you get a set of two assets. Maintaining that subtle difference (unique assets vs anonymous assets) turns out to be more painful than anticipated. I wrote it that way to show off the generality of proof-of-history, and we don't actually need anything that general in the near-term.

Codecov Report

Merging #66 into master will decrease coverage by 0.37%.
The diff coverage is 92.95%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   92.65%   92.28%   -0.38%
==========================================
  Files          14       15       +1
  Lines        1171     1127      -44
==========================================
- Hits         1085     1040      -45
- Misses         86       87       +1

Impacted Files
Coverage Δ

src/lib.rs
100% <ø> (ø)
:arrow_up:

src/accountant_stub.rs
88.42% <100%> (ø)
:arrow_up:

src/transaction.rs
100% <100%> (+2.22%)
:arrow_up:

src/event.rs
32.14% <100%> (ø)
:arrow_up:

src/accountant.rs
94.95% <100%> (-0.1%)
:arrow_down:

src/accountant_skel.rs
92.13% <100%> (ø)
:arrow_up:

src/plan.rs
89.13% <89.13%> (ø)

src/logger.rs
94.59% <0%> (-0.28%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e054238...f4e0d1b. Read the comment docs.

Also, the simpler contract language here has fewer edge cases to worry about. You can see in that first commit that I started to go down the route of allowing a spending plan to make multiple payments. That opened up the ability to create a Race spending plan that will pay out on both branches until one completes (that's bad!) I closed that hole by changing the Race instruction to race two conditions instead of two spending plans. It's now safe to add back an instruction for multiple payments, but that's not done here because we don't yet have a hard requirement for that.


perl534Packages.Wx: migrate to wxGTK32

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 222087 run on aarch64-darwin 1

6 packages built:

perl534Packages.AlienWxWidgets
perl534Packages.Wx
perl534Packages.WxGLCanvas
perl536Packages.AlienWxWidgets
perl536Packages.Wx
perl536Packages.WxGLCanvas

Result of nixpkgs-review pr 222087 run on aarch64-linux 1

9 packages built:

perl534Packages.AlienWxWidgets
perl534Packages.AppMusicChordPro
perl534Packages.Wx
perl534Packages.WxGLCanvas
perl536Packages.AlienWxWidgets
perl536Packages.AppMusicChordPro
perl536Packages.Wx
perl536Packages.WxGLCanvas
slic3r

@ofborg eval


a Warning/ Note/Tip specifying the change of enabling security defaults for "Existing Customers".

[Enter feedback here]
According to this doc: https://techcommunity.microsoft.com/t5/microsoft-entra-azure-ad-blog/raising-the-baseline-security-for-all-organizations-in-the-world/ba-p/3299048 , the change to existing customers is also rolled out.
There should be a note stating something like below:
Based on usage patterns, Microsoft will start with organizations that are a good fit for security defaults. Specifically, we will start with customers who aren’t using Conditional Access, haven’t used security defaults before, and aren’t actively using legacy authentication clients.
Global admins of eligible tenants will be notified through email and the Microsoft 365 Message Center. Then, starting in late June, they’ll receive the following prompt during sign-in:

Global admins can opt into security defaults right away or snooze for as many as 14 days. They can also explicitly opt out of security defaults in this time(during that 14 days). Once opted out, Microsoft will not enable the feature after 14 days.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cfac0ecf-e5a9-c5ff-f8c2-ce27789708f5
Version Independent ID: 0f5e0cc9-a54f-a5c8-192d-d60a6a4db3ff
Content: Providing a default level of security in Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/fundamentals/concept-fundamentals-security-defaults.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@GudlaPreethi
Thanks for your feedback! We will investigate and update as appropriate.

@MicrosoftGuyJFlo I would like to see if this doc can be updated.

Will add this to a future planned update to the content. #please-close


Create caclulator.py

Output :

Add your file in python folder

Add your file in python folder

Done


Docs hosting

Looks like the docs hosting has an error - https://reactnicedates.hernansartorio.com/

Thanks, fixed now!


Excel references do not support relative paths

Originally mentioned here
Humorously... this is a complicated thing to fix!

This has likely been addressed and will be in version pre-release <IP_ADDRESS>.A1.

Do you develop on head, or is there a different branch if I want to be an alpha tester?

Mostly on head unless it's super dangerous. The changes have been merged so you can pull it down & build. Be sure to backup your project just in case it wrecks something! 😟
I'll be doing another test pass sometime soon and then make a new release.

Should be part of the latest pre-release: https://github.com/nhmkdev/cardmaker/releases/tag/v.<IP_ADDRESS>-unstable.v.a1


MC Forums comment section color bug

i went browsing popular forums and websites looking for bugs because i was bored, then i stumbled upon a glitch/bug, basically two rules interfere with each other.
MC Forums: http://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1273024-1-4-dod-s-sounds-for-sdk-guns
MC Forums rule:
compiled.css ((line 2))
html, button, input, select, textarea {
	font-family: sans-serif;
	color: #222;
}

ShadowFox rule:
userContent.css ((line 112))
html:not(#ublock0-epicker), html:not(#ublock0-epicker) body, #newtab-customize-overlay {
	background: var(--primary-dark-color) !important;
	color: var(--primary-light-color) !important;
}

Example: Before | After

Hmmm...that's interesting given the userContent rule you pointed to is contained within
@-moz-document regexp("^about:(?!reader).*"), url(https://www.mozilla.org/credits/) {
I unfortunately can't get to the comment screen without creating a steam account.

I'll gladly accept a pull request for a fix here, but I unfortunately can't justify creating a Twitch and Minecraft account for this


Use MapIt for authority lookups

We recently added govuk_slugs for local authorities to MapIt. This means we can get these slugs directly from MapIt rather than rely on the local 'authorities.json' file. We remove the file in this PR and update the  AuthorityLookup class to make MapIt requests. As a consequence we have to stub these MapIt calls in our tests. We remove some unused methods from AuthorityLookup. Finally we update the LocationIdentifier subclasses to be more readable and remove the legacy term geostack from the code.
As part of this PR we add some code only to delete it in later commits. We've chosen to keep this in the git commit history (rather than squash commits) so that the refactoring is easier to follow.
For https://trello.com/c/YZEWeHwX/404-switch-frontend-to-get-la-slugs-from-mapit-instead-of-authorities-json-3
Note that the tests will not pass before https://github.com/alphagov/gds-api-adapters/pull/524 is merged and we bump 'gds-api-adapters', which exposes the MapIt endpoint for /code/<code_type>/<code>.
Paired with @issyl0

Good stuff!  Happy to merge once we've done the gds-api-adapters stuff.

Your refactoring of the LocationIdentifier subclasses makes the intent much clearer 👍
There's now quite a bit of similarity between the two subclasses - I wonder if it's worth moving the shared methods into LocationIdentifier to avoid the duplication?

@jennyd We pulled the common methods from the LocationIdentifier subclasses into the parent class in https://github.com/alphagov/frontend/pull/970/commits/30e417b7457681d8fc2b88660abfed23f2a0aec1. However we're undecided whether this sacrifices readability for less code duplication. When reading one of the subclasses, one has to jump between parent and child class a couple of times now in order to understand what it's doing. What do you think?

Looks good.  Merging.


Overloaded method GreaterThanOrEqualTo doesn't render the same result

Hi, I experience a strange behavior and I'm trying to figure out why this:
this.RuleFor(m => m.Quantity).GreaterThanOrEqualTo(10);
renders this:
<input data-val-range-min="10" id="Quantity" name="Quantity" type="text" value="10"">
but the overloaded version of the same method:
this.RuleFor(m => m.Quantity).GreaterThanOrEqualTo(m => m.QuantityMin);
renders this (data-val-range-min is empty):
<input data-val-range-min="" id="Quantity" name="Quantity" type="text" value="10"">
I tested it a little bit and when I changed the code to something like this:
this.RuleFor(m => m.Quantity).GreaterThanOrEqualTo(m => this.GetMin(m));

function GetMin(ConfigurationView view)
{
    return view.QuantityMin;
}

and set breakpoint inside the function, it won't stop there when I'm debugging. It won't go to the function at all (when rendering a view with a model with a validation class assigned).
I know that the LessThanOrEqualTo and GraterThanOrEqualTo don't support client validation - or at least they didn't. All the articles I found are couple years old and maybe it's not the case anymore? Anyway, I don't really care about the client validation, just the data attribute. And I'd like to know the reason why one version of the same method doesn't render the value in HTML.

Hi, this is the expected behaviour.
Clientside attributed for these rules can only be generated when using a constant value. MVC generates the attributes from metadata only - there's no context available to invoke the lambda, as there's no model instance to act upon.
The lambda-based overloads for these methods are serverside only.
And just to clarify, the attributes and clientside validation are the same thing. This is how MVC's clientside validation works.

Hi, can I please get a little bit more explanation. Because I thought that you implement the
public interface IClientValidatable
{
    IEnumerable<ModelClientValidationRule> GetClientValidationRules(ModelMetadata metadata, ControllerContext context);
}

And you can access the instance of the model from the context parameter:
var model = context.Controller.ViewData.Model;
Or is it something else that protects you from invoking the delegate methods?
Thank you.

ViewData.Model may be null or of a different type. Generation of clientside rules is based on metadata only - MVC doesn't guarantee a valid model instance will be available.

In this case ViewData.Model shouldn't be null but I understand it can be a different type in case there is an advance model with nested complex properties. But there's also:
var model = metadata.Container
That contains the instance of the "parent" object of the validated property. I can imagine other issues, like complex models with complex properties and complicated lambda expressions passed to the GreaterThanOrEqualTo method but it's possible to test whether the lambda expression is a MemberExpression - meaning it doesn't contain anything else but
m => m.QuantityMin
And it that case it would be save to invoke the method against the metadata.Container object.
I'm sorry if I sound pushy but I've been using the FluentValidation for years and it's an amazing project but this has been bugging me for some time and I'm just trying to figure out if it's possible to do something with that.
Thank you.

I'm afraid metadata.Container is not a reliable way to do this. Think for example of a "Create" view. At this point, there is no record created, so there is no instance available to invoke. The clientside rules are generated based on the type of model instance that will be created...there isn't one available at this point.
You also identified the other issues to do with complex properties, or complex expressions. To have this in some cases but not others is inconsistent and confusing.
You are of course welcome to fork/extend the FluentValidationModelValidatorProvider if you really want to add this behaviour in your own project, but it's not something that's going to go into the core product as it's not reliable, and introduces confusing inconsistencies.
Thanks for understanding & good luck with your project.


additional changes for prelogin page

additional changes for prelogin page

Also please address errors in Web Testing and Linting.

At Footer, fonts colour looks different.
With pre login its only copyright , but I just checked the footer in other pages , they seems to be different. could you please check ?

At Footer, fonts colour/ size looks different. With pre login its only copyright , but I just checked the footer in other pages , they seems to be different. could you please check ?

Hi Shilpa , used Gellix medium for both header and footer, and font weight and color is also same as per figma.


fix aggregation not push down

What problem does this PR solve?
https://github.com/pingcap/tispark/issues/2313
What is changed and how does it work?

Fix pushdown logical

fix the wrong pattern match in PromotedSum.unapply and SumNotNullable.unapply, so that sum and avg can be pushed down
fix SumNotNullable.apply to return the correct SpecialSum

Fix Request TiKV

push down the correct type for sum (for example: sum(bigint) needs decimal type). TiKV will check dataType after this pr https://github.com/tikv/tikv/pull/5429.
(Reference this TiDB code）

Fix return data type

fix sumRewrite  in TiAggregationImpl to cast decimal back to the long when using specialsum

fix TiDAGRequest so that explain will show the right info

Results

sum can pushdown
count can't pushdown
avg can pushdown after count can pushdown

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests tidb=v6.0.0 tikv=v6.0.0 pd=v6.0.0

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/merge

/cherrypick release-2.5


Need help setting up

Just wondering if I can get some assistance in setting this up. I'm using a windows machine (Windows 8) to connect to an application running on a windows server (Windows Server 2012 R2).
I have the php.ini set up as stated on this page https://atom.io/packages/php-debug. I have checked my phpinfo, and XDebug is loaded and running. I have set the firewall on the server to allow both incoming and outgoing on Port 9000. In my config.cson I have some pathmaps setup, local is just to the local folder that I am programming in, remote is to a network attached drive that references the exact same code I'm working on in my local folder. I'm using the chrome xdebug helper extension.
I've noticed that when I first checked my phpinfo, my IDE Key was something weird, after I tried debugging with atom, it changed to XDEBUG_ATOM. So some communication must be happening, but my line breaks aren't being triggered. I'm not quite sure what I'm doing wrong, and was hoping someone might be able to help me out.

+1
$ php -v
PHP 5.6.13-1+deb.sury.org~trusty+3 (cli)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
    with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans
    with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2015, by Zend Technologies

/etc/php5/cli/php.ini     &&     /etc/php5/apache2/php.ini
[Xdebug]
xdebug.remote_enable=1
xdebug.remote_host=<IP_ADDRESS>
xdebug.remote_connect_back=1    # Not safe for production servers
xdebug.remote_port=9000
xdebug.remote_handler=dbgp
xdebug.remote_mode=req
; xdebug.remote_autostart=true
xdebug.remote_autostart=false

zend_extension="/usr/lib/php5/20131226/xdebug.so"

This issue is over a year old, if you are still experiencing issues with the latest release please reopen.


ingressClass support

This PR extends the charts with the possibility of using ingressClassName for ingress resources instead the deprecated ingress.classname annotation.

Thanks!


[Arrow] Update to 1.0.0

Update Arrow from 0.17.1 to the recently released 1.0.0.
Built and successfully tested on x64-windows-static, x64-linux and x64-osx as part of https://github.com/G-Research/ParquetSharp/pull/146.
Changes:

Added dependency on utf8proc (new dependency added in 1.0.0, enabled by default).
Added explicit Shared/Static config flags for some of the dependencies; these are now needed for correct linkage (and for CMake to find the correct libraries).
Simplified part of the patches.

(The dependencies handling by Arrow upstream CMake files is a bit of a hit and miss, there is little consistency. Nothing new here, but it does mean that most of the existing patches are still necessary.)
(I've also reported the lack of UTF8PROC_STATIC definition upstream: https://issues.apache.org/jira/browse/ARROW-9541)

Note that Arrow 1.0 is not released yet, you should not use Github as a source as the 1.0 is moved until a release is done.

Thanks for the clarification @xhochy. I didn't realise this was only a Release Candidate (I checked the chatter on arrow-dev mailing list). I'll update the PR when the Final release is done (I wouldn't expect many changes, so we'll be ready).

According to https://arrow.apache.org/install/, the release candidate has now been promoted to final release. I'm happy for this PR to be merged to master.

/azp run

Something is wrong with itk on x64-osx; unsure what.
Thanks @GPSnoopy!


dattcore: Wallet: Create spend TX to send money to comment

We need to be able to create a transaction spending bitcoin to the bitcoin address in a comment. We do not yet need to worry about splitting the money between user, curator, node, etc.

Closed by https://github.com/dattnetwork/datt/commit/2360f89a39af9f1799a702a4fade5f98147146b8


update training of WNet3D

rename, and a bit of simplification
remove old(er) notebooks
[ ] suggestion: add inference (only) with demo data on Colab

For suggestion : see #80


Feat: Enhancing Navbar Design and Adjusting Size with Border Radius

Describe the feature
The feature entails revamping the design of the navbar to make it more visually appealing and engaging. This includes implementing changes to the size and border radius to enhance the overall aesthetic and user experience. By enhancing the navbar design, we aim to create a more attractive and modern appearance that aligns with the website's theme and enhances navigation for users.
Please assign me this issue
Add ScreenShots
Now Looks Like :

After Changes It will look like:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned @dhruv389
Make sure to star the repo before working on it! Happy open-source contributing!


Attempt to use typings property in package.json

relates to #251

added this as part of the upgrade to typescript 2


Add SEO to the index

Context
In order for site crawlers to detect the new CAMPD domain, the index file needs to include the information below .
This work will index to the CAMPD home page
Dev Tasks
Ensure that the index page  has the following items in the header tag:

[ ] Title
[ ] metadata
[ ] page description

Refer to the content documents below:
CAMPD home page content document


feat: update generator-react-sdk dependency

Description
We are not using markdown-it and upgraded generator-react-sdk.

Already solved by latest version bump


functional test scaffolding

WIP, don't merge.

This ended up being massive amount of changes.
Some of the things done here:

Moved from urfave/cli to alecthomas/kingpin
Added functional tests (but ran into an issue with kafka)
Added integration tests + docker-compose
Fixed various overlooked bugs (misspellings, docs, output conversion logic)


Embedding/argmax are O(n^2)

This is making GPT-2 slow

This comes down to cumsum being O(n^2), a fix could be having the special case of cumsum used in arange for the indexes of just +1 each time be fast.

I'll dive into this, I want to find the most generic way to fix this. I think there will be something clever.


webview_flutter not working for Angular web app url's

The webview_flutter component is not working for all URL's. Some URL's that we tried work, but when we want to show an existing Angular web app inside a flutter app, then nothing is shown, just a white background.
The url is:
https://aquasense.birdy.life/
Is this by design, a bug or should we do something extra?

Have you tried setting the javascriptMode to JavascriptMode.unrestricted?

Hi, just want to check if this is still a problem for you.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Enable Random Prefix Caching in Serving Profiling Tool (benchmark_serving.py)

Prefix-caching is an important feature but not supported in vllm's serving profiler. This PR extends random data generator in benchmark_serving.py to create requests with fixed prefix context. The newly added --random-prefix-len specifies the prefix in every random request; the total context length per request is random_prefix_len + random_input_len.

/ready

@comaniac, please help merging when you have time. Thank you.


Task expunge mechanism writes into ZooKeeper as non-leader

The task expunge mechanism writes to the ZooKeeper database even when it's not the leader. It expunges the tasks (all of them!) and the leader falls over it when the next TASK_RUNNING messages arrive. Because those tasks cannot be found in the task store, the leader will kill them.
=> kaboom. You have an empty cluster.
On the non-leader:
Jan 19 14:17:54 srv003 marathon[12628]: [2015-01-19 14:17:54,278] INFO Not leader therefore not reconciling tasks (mesosphere.marathon.MarathonSchedulerService:311)
Jan 19 14:18:24 srv003 marathon[12628]: [2015-01-19 14:18:24,285] INFO Not leader therefore not reconciling tasks (mesosphere.marathon.MarathonSchedulerService:311)
Jan 19 14:18:24 srv003 marathon[12628]: [2015-01-19 14:18:24,287] INFO Expunging orphaned tasks from store (mesosphere.marathon.tasks.TaskTracker:170)
Jan 19 14:18:24 srv003 marathon[12628]: [2015-01-19 14:18:24,320] INFO Expunging orphaned task with key task:app-master_databases_redis:app-master_databases_redis.aa0b622d-9fe4-11e4-8a66-4adee68efb3d (mesosphere.marathon.tasks.TaskTracker:178)
Jan 19 14:18:24 srv003 marathon[12628]: [2015-01-19 14:18:24,341] INFO Expunging orphaned task with key task:app-master_services_beat:app-master_services_beat.c033fdc0-9fe4-11e4-8a66-4adee68efb3d (mesosphere.marathon.tasks.TaskTracker:178)
Jan 19 14:18:24 srv003 marathon[12628]: [2015-01-19 14:18:24,383] INFO Expunging orphaned task with key task:app-master_services_flower:app-master_services_flower.90e11f57-9fe4-11e4-8a66-4adee68efb3d (mesosphere.marathon.tasks.TaskTracker:178)

On the leader:
Jan 19 14:18:51 srv002 marathon[19022]: [2015-01-19 14:18:51,993] INFO Received status update for task app-staging_services_beat.02e73ab4-9fe6-11e4-8f20-b6a514b75aa4: TASK_RUNNING (Reconciliation: Latest task state) (mesosphere.marathon.MarathonScheduler:148)
Jan 19 14:18:52 srv002 marathon[19022]: [2015-01-19 14:18:52,013] WARN Task for ID app-staging_services_beat.02e73ab4-9fe6-11e4-8f20-b6a514b75aa4 already running, ignoring (mesosphere.marathon.tasks.TaskTracker:85)
Jan 19 14:18:52 srv002 marathon[19022]: [2015-01-19 14:18:52,014] WARN Couldn't post event for value: "app-staging_services_beat.02e73ab4-9fe6-11e4-8f20-b6a514b75aa4"
Jan 19 14:18:52 srv002 marathon[19022]:  (mesosphere.marathon.MarathonScheduler:188)
Jan 19 14:18:52 srv002 marathon[19022]: java.lang.Exception: Task for ID app-staging_services_beat.02e73ab4-9fe6-11e4-8f20-b6a514b75aa4 already running, ignoring
Jan 19 14:18:52 srv002 marathon[19022]: #011at mesosphere.marathon.tasks.TaskTracker.running(TaskTracker.scala:86)
Jan 19 14:18:52 srv002 marathon[19022]: #011at mesosphere.marathon.MarathonScheduler.statusUpdate(MarathonScheduler.scala:180)
Jan 19 14:18:52 srv002 marathon[19022]: [2015-01-19 14:18:52,014] WARN Killing task value: "app-staging_services_beat.02e73ab4-9fe6-11e4-8f20-b6a514b75aa4"
Jan 19 14:18:52 srv002 marathon[19022]:  (mesosphere.marathon.MarathonScheduler:189)

Thanks, this should be a quick one.

 Should be a one-liner as far as I see.

Yes, will do. I'l change it a bit, so that the periodic tasks will not be executed on non-leaders.

the periodic tasks have the is-leader guard already. only the expunge line misses it.

Yes, but why should the timer even be running on non-leader nodes?

True. Can be moved into the leadership elect/defeat logic.

Exactly ;-)

Btw, my hope is that this had to do somehow with the 1970 tasks. The old behaviour was that on TASK_RUNNING for non-existing tasks those invalid 1970 MarathonTasks were created. @ConnorDoyle and I were wondering who would corrupt the task store to trigger this.

Interesting.

Though I would have expected that all tasks would have been 1970 tasks after this expunge incident.


PT-161093359 Size gas in primops

PT-161093359
PT-161340434 - Also included in this PR.
This PR adds size gas to the primops. Before, the primops had only state gas (computed from TTL). The primops have higher gas now, it's sum of the state gas and size gas. Size gas is computed from a related serialized transaction.
The protocol PR will follow.

Discussed a bit with Ulf, there should be some cost (for encoding and decoding the data) but it should be a different kind of cost (it is a "VM cost" rather than a "chain storage" cost) so probably it should be related to the the size of Data in aevm_ae_primops:call_ perhaps...

@lucafavatella could you have a look? The ticket says:

The gas of VM primops is the sum of the following components:

Base static gas if any.
For oracles, gas considering TTL of state object. (AENS not tracked in this ticket.)
Element proportional to the serialized equivalent transaction.

Yes, the ticket says Element proportional to the serialized equivalent transaction not Exactly the same size computation as normal transactions that are stored on the chain... That is what you have implemented. Changing size_gas implementation to something reasonable is probably enough :-)


question 158:

https://github.com/spring-projects/spring-net/issues/158

I think that instead of documenting a workaround, we should investigate how to get better detection of MSBuild location so there would be no need to manually alter the files.

I think that instead of documenting a workaround, we should investigate how to get better detection of MSBuild location so there would be no need to manually alter the files.

Agree! But all my attempts at detecting vs2017 installation directory   failed.


doc: RecordBatchReceiverStreamBuilder::spawn_blocking does not abort threads

Describe the bug
https://docs.rs/datafusion/latest/datafusion/physical_plan/stream/struct.RecordBatchReceiverStreamBuilder.html#method.spawn_blocking docs say

Spawn a blocking task that will be aborted if this builder (or the stream built from it) are dropped

There's no aborting happening, and I don't think one can do that safely (no abort in https://doc.rust-lang.org/std/thread/struct.Thread.html).
What actually happens is that tx.blocking_send and friends start to give errors, and the caller-provided closure is responsible for returning when that happens.
It's probably worthwhile checking whether this is also true for the async variant, or whether it actually aborts the tokio task at any await point.
https://docs.rs/tokio/latest/tokio/sync/mpsc/struct.Sender.html#method.blocking_send
To Reproduce
use datafusion::arrow::array::{ArrayRef, UInt64Array};
use datafusion::arrow::datatypes::{DataType, Field, SchemaBuilder};
use datafusion::arrow::record_batch::RecordBatch;
use datafusion::arrow::util::pretty::print_batches;
use datafusion::error::DataFusionError;
use datafusion::physical_plan::stream::RecordBatchReceiverStreamBuilder;
use futures::StreamExt;
use std::sync::Arc;
use std::time::Duration;

fn make_dummy_record_batch() -> Result<RecordBatch, DataFusionError> {
    let a: ArrayRef = Arc::new(UInt64Array::from(vec![1, 2]));
    let record_batch = RecordBatch::try_from_iter(vec![("a", a)])
        .map_err(|error| DataFusionError::External(Box::new(error)))?;
    Ok(record_batch)
}

#[tokio::main]
async fn main() {
    let schema = {
        let mut builder = SchemaBuilder::new();
        builder.push(Field::new("a", DataType::UInt64, false));
        builder.finish()
    };
    let mut stream = {
        let mut builder = RecordBatchReceiverStreamBuilder::new(Arc::new(schema), 1);
        {
            let tx = builder.tx();
            builder.spawn_blocking(move || loop {
                let record_batch = make_dummy_record_batch()?;
                match tx.blocking_send(Ok(record_batch)) {
                    Ok(()) => (),
                    Err(_sent) => {
                        // If we ignore this error, nothing "aborts" us.
                        eprintln!("ignoring send error for demonstration purposes");
                    }
                };
                println!("tick");
                std::thread::sleep(Duration::from_millis(300));
            });
        }
        builder.build()
    };

    for i in 0..3 {
        let record_batch = stream.next().await.unwrap().unwrap();
        println!("Record Batch #{i}");
        print_batches(&[record_batch]).unwrap();
    }

    // Docs claim this will abort the producer.
    drop(stream);

    // If it were aborted, we should stop seeing "tick" messages any moment now!
    tokio::time::sleep(Duration::new(5, 0)).await;
    println!("is it still going? bailing out.");
    std::process::exit(0);
}

Expected behavior
The behavior makes sense, but should be documented.
Additional context
No response

It seems to me that a blocking task is actually aborted / cancelled on drop, but once a blocking task starts it can't be interrupted.
So for example, if the task hasn't started yet it will never start. However,  once the  blocking task starts running, it will run to completion as it never yields control back to tokio (via await)

I think we can summarize the discussion on this ticket into the doc comments and that would make a good first issue

take


use aware datetime + better schedule storing

Hello @mixkorshun ,
the PR proposal solve two little issues with scheduler interaction:

use aware datetime solve an issue with last_run date if timezone is configured (in fact after the first reload the stored datetime was interpreted as UTC also if it was relative to a timezone)

changed a bit the interaction between the scheduler and the store. Now changes on beat_schedule config are synced correctly. This solve the issue #2 too.

Have a nice day

@auvipy just now I am in Vacation and without a  computer, I Will do it as soon as I can.


Add devise

In this milstone I did the following:

Setup up devise with reference to issue https://github.com/KayLemba/Receipe-App/issues/1

Thanks for the review @charlesgobina


nit: README.md - add temp.log to original list of files

The first example should include temp.log. It's only explicitly excluded in the later example.

Closing… tired of seeing this in https://github.com/pulls 😂


[Feature Request] Adding a swipeable area to dismiss the modal

Hi @maxs15, found your plugin to work just perfectly & very smoothly so I'm currently using it in my project.
Right now you can either enable or disable the swipe to dismiss feature. My problem is, my modal contains a scrollview, with much more content (ie. comments) than the modal hold.
I'm left with two solutions : Either I enable the swipe to dismiss, but then I'm unable to scroll inside my scrollView OR I disable the swipe to dismiss - which lead to a perfectly scrollable scrollview - but no ability to dismiss with a simple swipe down.
While looking for modals alternative, I found this : https://github.com/fomahaut/React-Native-Swipeable-Modal#readme
This modal is way less performant than this one but - as you can see - has a "swipeableAreaStyle" which allow the user to customize the are to be swiped.
What do you think?
Cheers

Hey @JonathanWi
I was actually thinking about adding such a property.
I will try to commit that today if I find some time ;)

Awesome! I'll be waiting then, thanks a lot!

Feature released in the version 1.1.5 ;)


feature: Add a Button to Redirect Users to Mapped Videos on harkirat.classx

Is your feature request related to a problem? Please describe.
Currently, videos are uploaded to both app.100xdevs (our in-house LMS) and harkirat.classx. However, when a video does not work on app.100xdevs, users do not have a straightforward way to navigate to the same video on harkirat.classx.
Describe the solution you'd like
Add a button on app.100xdevs that redirects users to the corresponding video on harkirat.classx. This would provide a simple and manual fallback for users when a video fails to work on the LMS.
Describe alternatives you've considered

Informing users to manually search for the video on harkirat.classx through its search bar (less user-friendly).

Additional context
I would like to work on this issue. It will require:

Establishing a mapping between video IDs on app.100xdevs and harkirat.classx.
Adding a UI element (button) in the video player or error state to navigate to the mapped video on harkirat.classx.

@devsargam can we add this ?

Yes actually this should be great

I’d like to work on this issue @devsargam . My initial thought is to add a field for video links in the videoMetadata model and follow a similar process as used for slides. Let me know if this approach works or if there are additional considerations.

Sorry I didn't realize it earlier but I don't think it's possible in a good way. We can't assume a user has certain course so it's uncertain which url to put


Custom analytics JS

Please, add ability to put custom analytics JS

What would be the difference from using custom HTML ?

Custom HTML puts code in top of body. this ext. puts code in bottom of header

I don't think it's a use case we want to solve with this extension. A "custom HEAD content" extension would be more logical I think. And it shouldn't be complicated to make.
You can even inject content in HEAD without an extension by using extend.php. I can't think of the code you need right now but it's a single call to an existing extender.


Add volume controller

Volume controller that handles both clicks and wheel (trackpad) movement when mouse is hovering the controller 😎
Closes #56

Nice PR, but I would like to see us use and skin the native range input element, that will allow us to read the value from the native element.

@MichielDeMey fair point, I absolutely forgot that input[type=range] exists 👍

Let's also persist the volume level (but not the "muted" state) to localStorage when the user closes the application, I believe that would improve UX a bit.

@MichielDeMey just pushed changes that implement all your suggestions 👍

Just wondering if anything prevents this PR from being merged? ☺

Whoops, we totally lost track of this issue.
Thank you for your contribution!

Just came here looking for volume control support. Thanks for doing this! 🙌

Released as v0.8.0

Thanks for all the hard work!!


Add PR/issue templates

Let me know if I've missed any bits we need to remember to update for PRs/releases

💪
make fmt in the PR template?

💪
make fmt in the new feature template?

@james2791 CI will fail anyway and won't be able to merge it and I think thats a nicer way. If all these steps could be codified into CI that would be even better!

💪
make fmt in the new feature template?

@james2791 CI will fail anyway and won't be able to merge it and I think thats a nicer way. If all these steps could be codified into CI that would be even better!

Thats fair - LGTM then 👍


Fix typo

a -> an

@changeworld : Thanks for your contribution! The author, @rayne-wiselman, has been notified to review your proposed change.

Merging typo fix.


Request for opening solution file outside working directory

Hello, I'm trying to open .sln outside source folder but it doesn't work. For example,
Working path: C:\src\proj\test.cs
Project path: C:\solution\test.sln
I tried to open one folder and added the other folder on vscode but it only searches a solution file in the root of source path. Can I open a source folder and load a solution file in different location?
Thanks

This is by design. The extension expects the solution/project file to be in or beneath the open folder.


Increase YouTube cache time from 24h to 48h

Pull request checklist:

[ ] CHANGELOG.md was updated, if applicable

Description

Out of interest: What was the reason for this change? Did we hit the request limit on the YouTube API?

Yes, we hit the request limit. This is a short term fix. Preferably this value would be configurable in the config file but no time to do that now


Recommended Docker configuration stopped working, resulting in failure to launch due to no usable sandbox

Steps to reproduce
Tell us about your environment:

Puppeteer version: 3.2.0
Platform / OS version: Docker node:12.16.1 image
URLs (if applicable):
Node.js version: 12.16.1

What steps will reproduce the problem?
Please include code that reproduces the issue.
My Dockerfile includes the following:
RUN npm ci \
    && groupadd -r pptruser && useradd -r -g pptruser -G audio,video pptruser \
    && mkdir -p /home/pptruser/Downloads \
    && chown -R pptruser:pptruser /home/pptruser \
    && chown -R pptruser:pptruser /app

This was working until recently, but after I rebuilt the Docker image today without changing any dependencies or Dockerfile contents, then I call puppeteer.launch() in my JS code
What is the expected result?
Browser launches
What happens instead?
Error: Failed to launch the browser process!
[1009/032320.966900:FATAL:zygote_host_impl_linux.cc(116)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.
#0 0x55b47b44a399 base::debug::CollectStackTrace()
#1 0x55b47b3ab2a3 base::debug::StackTrace::StackTrace()
#2 0x55b47b3bcc95 logging::LogMessage::~LogMessage()
#3 0x55b47cc9940e service_manager::ZygoteHostImpl::Init()
#4 0x55b47af75060 content::ContentMainRunnerImpl::Initialize()
#5 0x55b47afd65e7 service_manager::Main()
#6 0x55b47af73631 content::ContentMain()
#7 0x55b47afd580d headless::(anonymous namespace)::RunContentMain()
#8 0x55b47afd550c headless::HeadlessShellMain()
#9 0x55b4789c95a7 ChromeMain
#10 0x7f10185b62e1 __libc_start_main
#11 0x55b4789c93ea _start

Received signal 6
#0 0x55b47b44a399 base::debug::CollectStackTrace()
#1 0x55b47b3ab2a3 base::debug::StackTrace::StackTrace()
#2 0x55b47b449f35 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f101eb600e0 (/lib/x86_64-linux-gnu/libpthread-2.24.so+0x110df)
#4 0x7f10185c8fff gsignal
#5 0x7f10185ca42a abort
#6 0x55b47b448e95 base::debug::BreakDebugger()
#7 0x55b47b3bd132 logging::LogMessage::~LogMessage()
#8 0x55b47cc9940e service_manager::ZygoteHostImpl::Init()
#9 0x55b47af75060 content::ContentMainRunnerImpl::Initialize()
#10 0x55b47afd65e7 service_manager::Main()
#11 0x55b47af73631 content::ContentMain()
#12 0x55b47afd580d headless::(anonymous namespace)::RunContentMain()
#13 0x55b47afd550c headless::HeadlessShellMain()
#14 0x55b4789c95a7 ChromeMain
#15 0x7f10185b62e1 __libc_start_main
#16 0x55b4789c93ea _start
  r8:<PHONE_NUMBER>000000  r9: 00007ffd53951040 r10:<PHONE_NUMBER>000008 r11:<PHONE_NUMBER>000246
 r12: 00007ffd539522f8 r13: 00007ffd539512d0 r14: 00007ffd53952300 r15: aaaaaaaaaaaaaaaa
  di:<PHONE_NUMBER>000002  si: 00007ffd53951040  bp: 00007ffd53951280  bx:<PHONE_NUMBER>000006
  dx:<PHONE_NUMBER>000000  ax:<PHONE_NUMBER>000000  cx: 00007f10185c8fff  sp: 00007ffd539510b8
  ip: 00007f10185c8fff efl:<PHONE_NUMBER>000246 cgf: 002b000000000033 erf:<PHONE_NUMBER>000000
 trp:<PHONE_NUMBER>000000 msk:<PHONE_NUMBER>000000 cr2:<PHONE_NUMBER>000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md

    at onClose (/app/node_modules/puppeteer/lib/launcher/BrowserRunner.js:181:20)
    at Interface.<anonymous> (/app/node_modules/puppeteer/lib/launcher/BrowserRunner.js:171:65)
    at Interface.emit (events.js:323:22)
    at Interface.close (readline.js:409:8)
    at Socket.onend (readline.js:187:10)
    at Socket.emit (events.js:323:22)
    at endReadableNT (_stream_readable.js:1204:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

Is there something that changed in the version of Chrome that Puppeteer downloads that could be causing this?

I'm going to add --no-sandbox as a temporary workaround for this, since I'm not running any third party code, but it would be a lot better if I could get it working the way it was before.

@richardkazuomiller where do you use this param?

@stefanocudini https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#setting-up-chrome-linux-sandbox
As the documentation says, you should only do this if you absolutely trust the content you open in Chrome


do not close channels in function conatinerLog

it is better to avoid closing channels
https://issues.redhat.com/browse/ECOPROJECT-837
Signed-off-by: Yaron Dayagi<EMAIL_ADDRESS>

/dog


run_bridge.py doesn't work because HONDA_CIVIC sets pcmCruise to True

Describe the bug
Thanks for fixing #32010 . This issue fixed fingerprint from CIVIC to HONDA_CIVIC and now the run_bridge.py can be properly launched.
But, there is a still problem that openpilot cannot be engaged. Even when cruise_button is set to DECEL_SET (or RES_ACCEL), self-driving doesn't start.
To my inspection, this is because now HONDA_CIVIC sets pcmCruise to True but the bridge doesn't support this mode.
( selfdrive/car/honda/interface.py )
    if candidate in HONDA_BOSCH:
      # ...
    else:
      # ...
      ret.pcmCruise = True

The older version (I'm not sure) of openpilot sets ret.pcmCruise = not ret.enableGasInterceptor here.
When I set False instead of True here, the bridge works properly.
I don't think it is a good way to change to ret.pcmCruise = False . Ideally, the bridge should support pcmCruise mode, I think.
OS Version
Ubuntu 20.04
openpilot version or commit
bbd08baacd4898f1f78cdd7e72709cae7fce73cc
Additional info
No response

Duplicate of https://github.com/commaai/openpilot/issues/31919


Stop maintaining type defs

It is not best practice to maintain types if projects are not written in TypeScript:

If your types are generated by your source code, publish the types with your source code. Both TypeScript and JavaScript projects can generate types via --declaration.
Otherwise, we recommend submitting the types to DefinitelyTyped, which will publish them to the @types organization on npm.

If you move your types there, you will get tests for the types and strong support by TypeScript experts. Maintaining types with a JS project is very error prone.

Hey @Levino, I know this is an old issue, but here's a quick update.
@prismicio/react v2 was just published and is now written completely in TypeScript. Going forward, all types will be maintained alongside the source code and in @prismicio/types.
Thanks for your feedback!


Updates queries to use double quotes

Fixes #2912
This updates the queries in doc to use double quotes.
It was discovered that in certain shells, single quotes wouldn't complete the query correctly. So far this is only in CMD and all other shells work regardless the quoting. For this reason, we should have the standard be double quotes in examples.

Docs Build status updates of commit 27f74c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/query-azure-cli.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks for making these edits, @chasewilson .  This is part of Azure DevOps work item 1908883


[ Can be added ] Prevent IE Edge Meta Tag from Breaking Images in Live Mail

https://www.emailonacid.com/blog/article/email-development/prevent-ie-edge-meta-tag-from-breaking-images-in-live-mail

Hey @jitendravyas, thanks for the suggestion, we'll investigate this!

It will be shipped in the next release 👍

It's now available in 3.1 👍


env: add include, platinclude and srcdir to the environment

Signed-off-by: Filipe Laíns<EMAIL_ADDRESS>

@FFY00 Do you have any background for this? What problem does it solve?
We should also probably set up towncrier or something similar for changelog management. Otherwise it will be very hard to write up our changelogs when it comes to release time.

It fixes building some native packages, which rely on these folders. It is part of #53.
I am aware of the changes, so when it is time I can write a changelog. But we could definitely set up towncrier, it is just not my priority right now.

Closing because this got merged in #56. Tests are added in #70.


Move SBT Plugin documentation to Sphinx

So that the plugin documentation lives with all our other extensions documentations.

Good idea. I have had a number of gatling users contact me directly about using gatling-sbt as they were unaware of the demo app.


no solution file

On Mac, following the instructions, I did
dotnet new grpc -o GrpcGreeter
cd GrpcGreeter

This page then says:

From Visual Studio, select File > Open, and then select the GrpcGreeter.sln file.

but there is not *.sln file anywhere in the GrpcGreeter folder.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d298a6c-8ddc-dbc8-d219-0fa7138442c2
Version Independent ID: b96be346-958a-cfcd-d80a-c352d64223e8
Content: Create a .NET Core gRPC client and server in ASP.NET Core
Content Source: aspnetcore/tutorials/grpc/grpc-start.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @JunTaoLuo
Microsoft Alias: johluo

It should say to select the project file (.csproj). Thanks for reporting this.


Mobile form

[ ]  Add in all fields placeholder text.
[ ]  Add in all fields the correct type.
[ ]  Add a Name field that accepts up to 30 chars.
[ ]  Add an Email field that accepts only emails.
[ ]  Add a message field that accepts up to 500 chars.

Thanks for approving @Favourezeugwa


⚠ Bofrost.de has degraded performance

In d6a4a06, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1609 ms

Resolved: Bofrost.de performance has improved in b9817e2.


Make game playable on mobile

Guess coolest thing is with touch.
Which will  transform to some movement over multiple game ticks. It does need to know where thr player is for it be able to deside

Not going to do this as the game is not performing enough


The DDEV_URL variable is not set. Defaulting to a blank string.

I started getting this notice one every command run inside ddev
"The DDEV_URL variable is not set. Defaulting to a blank string."
Can't find anywhere to set it in config?

Thanks for opening this issue.
In v1.9, DDEV_URL was obsoleted as it had no usage and no purpose. So you have a docker-compose..yaml that uses it, and it hasn't changed, and so your third-party service is making that noise at startup. You can just remove that line from your docker-compose..yaml.

I see.
Thanks.


Changelog 5.0

Coverage remained the same at 51.267% when pulling 9009af253c3107a6989cc16ff89f0d7202b3e97b on v-kaywon:changelog_5.0 into a0896f2da9318bee32c4d8c665dd6cdda7e54e5d on Microsoft:dev.

Coverage decreased (-17.5%) to 33.801% when pulling 9009af253c3107a6989cc16ff89f0d7202b3e97b on v-kaywon:changelog_5.0 into a0896f2da9318bee32c4d8c665dd6cdda7e54e5d on Microsoft:dev.

Coverage remained the same at 51.267% when pulling 9009af253c3107a6989cc16ff89f0d7202b3e97b on v-kaywon:changelog_5.0 into a0896f2da9318bee32c4d8c665dd6cdda7e54e5d on Microsoft:dev.

Travis failing with a network issue, this PR is updating the md file and doesn't touch code or test


breaking: drops content injection features.

Currently we support SecContentInjection and the actions around it, however there is a general feeling that manipulating the body is not something WAF as core should do, instead connectors should take care of that. This is specially inconvenient depending on the connectors lifecycle. For example, in proxy-wasm we can't modify the size of the response body as by the time we want to modify or resolve a phase 4, the headers have been sent already and hence the content length. It is better to drop this feature (only supported in Modsec 2.5) rather han having a half baked solution.
Context https://owasp.slack.com/archives/CBKGH8A5P/p1674675047931819
CC @airween @dune73

Codecov Report
Base: 77.56% // Head: 77.82% // Increases project coverage by +0.25% :tada:

Coverage data is based on head (ea00728) compared to base (bb55a14).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           v3/dev     #589      +/-   ##
==========================================
+ Coverage   77.56%   77.82%   +0.25%
==========================================
  Files         145      143       -2
  Lines        7404     7328      -76
==========================================
- Hits         5743     5703      -40
+ Misses       1419     1393      -26
+ Partials      242      232      -10

Flag
Coverage Δ

default
73.28% <ø> (+0.21%)
:arrow_up:

examples
28.28% <ø> (+0.27%)
:arrow_up:

ftw
55.42% <ø> (+0.56%)
:arrow_up:

ftw-multiphase
55.52% <ø> (+0.56%)
:arrow_up:

tinygo
71.29% <ø> (+0.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

actions/actions.go
97.61% <ø> (-0.11%)
:arrow_down:

config.go
60.46% <ø> (+2.68%)
:arrow_up:

internal/corazawaf/transaction.go
79.08% <ø> (-0.04%)
:arrow_down:

internal/corazawaf/waf.go
90.83% <ø> (ø)

internal/seclang/directives.go
67.59% <ø> (+0.19%)
:arrow_up:

waf.go
61.97% <ø> (+2.51%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Doesn't indent @keyframes correctly in SCSS

Hello
@keyframes infinite-spinning {
  from {
    transform: rotate(0deg);
  }
  to {
    transform: rotate(360deg);
  }
}

Gets beautified to
@keyframes infinite-spinning {
    from {
        transform: rotate(0deg);
    }

to {
        transform: rotate(360deg);
    }
}

Sass/SCSS is handled by Pretty Diff: https://github.com/Glavin001/atom-beautify/blob/master/src/languages/sass.coffee#L21
I would recommend forwarding this issue over to @prettydiff at https://github.com/prettydiff/prettydiff/issues
Add a link back to this Issue on Atom Beautify when you create the new Issue on Pretty Diff: that way we can see if it is closed on Pretty Diff. Thanks!

I am not able to reproduce the error in the Pretty Diff tool.

Hmm. @najela could you run Atom Beautify: Help Debug Editor from the command palette, create a Gist, paste those results into a Markdown Gist (extension .md), and provide the link here for debugging. Thanks!

This is the link to the gist https://gist.github.com/najela/09c57d78f8853df1bf1e

Should be fixed in prettydiff/prettydiff#142

Once Pretty Diff has merged the pull request, and published a new release to npm, you can trigger Atom to update Atom Beautify's dependencies by uninstalling and reinstalling Atom Beautify. Be sure to restart Atom, in case there are problems cleaning up the old loaded package.

This looks like a long resolved issue.


[Bug Report] Lavaplayer crashes with certain YouTube tracks.

Describe the bug
Bot quickly joins and disconnects from the voice channel and an exception is thrown in the logs. This is probably because the said song is age restricted. From my testing it looks like bumping com.sedmelluq.lavaplayer version to 1.3.66 fixes this problem.
To Reproduce
Steps to reproduce the behavior:

Play https://www.youtube.com/watch?v=iJ4IX-E9240

Logs
[13:58:00] [WARN] [LocalAudioTrackExecutor]: Suspicious exception for playback of iJ4IX-E9240

com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Track information is unavailable.

	at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeTrackDetailsLoader.loadTrackBaseInfoFromEmbedPage(DefaultYoutubeTrackDetailsLoader.java:199)

	at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeTrackDetailsLoader.loadBaseResponse(DefaultYoutubeTrackDetailsLoader.java:83)

	at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeTrackDetailsLoader.load(DefaultYoutubeTrackDetailsLoader.java:54)

	at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeTrackDetailsLoader.loadDetails(DefaultYoutubeTrackDetailsLoader.java:40)

	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.loadBestFormatWithUrl(YoutubeAudioTrack.java:76)

	at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.process(YoutubeAudioTrack.java:42)

	at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:105)

	at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$executeTrack$1(DefaultAudioPlayerManager.java:349)

	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)

	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)

	at java.base/java.lang.Thread.run(Thread.java:834)

Caused by: java.lang.IllegalStateException: Expected player config is not present in embed page.

	... 11 common frames omitted

Debug Info
System Properties:
  java.version = 11.0.9
  java.vm.name = OpenJDK 64-Bit Server VM
  java.vm.specification.version = 11
  java.runtime.name = OpenJDK Runtime Environment
  java.runtime.version = 11.0.9+11-Ubuntu-0ubuntu1
  java.specification.version = 11
  os.arch = amd64
  os.name = Linux

JMusicBot Information:
  Version = 0.3.2
  Owner =<PHONE_NUMBER>84699393
  Prefix = .
  AltPrefix = null
  MaxSeconds = 0
  NPImages = false
  SongInStatus = false
  StayInChannel = false
  UseEval = true
  UpdateAlerts = true

Dependency Information:
  JDA Version = 4.2.0_214
  JDA-Utilities Version = 3.0.5
  Lavaplayer Version = 1.3.55

Runtime Information:
  Total Memory = 31
  Used Memory = 17

Discord Information:
  ID =<PHONE_NUMBER>79550722
  Guilds = 5
  Users = 4

do you mind showing how to run the bot with the new version?

Duplicate of #574, this will be fixed in the next release


v4 NPE guard on primitive type

The case is async returns e.g. Mono<Integer> and sync return int.

Based on https://github.com/Azure/autorest.java/pull/588


linux: cleanup common-config after drop of 4.9

linux-4.9 was dropped on 8d9133c67d25c15348ec12720ee2ce90762d4d4c / #200218
next lowest version in nixpkgs is 4.14 so cleaning up options
Description of changes
whenOlder < 4.14 x  => remove option
whenAtLeast <= 4.14 => remove conditional
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please note the following comment: https://github.com/NixOS/nixpkgs/pull/200218#issuecomment-1310122845

We can drop them after the branch-off if we are worried about downstream usage. I think that would be a reasonable trade-off.

On 6.0.Z the following options are unused:
warning: unused option: ANDROID
warning: unused option: DEBUG_INFO_BTF
warning: unused option: DEBUG_STACKOVERFLOW
warning: unused option: EXT4_ENCRYPTION
warning: unused option: F2FS_FS_ENCRYPTION
warning: unused option: INET_DIAG_DESTROY
warning: unused option: INET_MPTCP_DIAG
warning: unused option: INET_RAW_DIAG
warning: unused option: INET_TCP_DIAG
warning: unused option: INET_UDP_DIAG
warning: unused option: IO_STRICT_DEVMEM
warning: unused option: MODULE_ALLOW_BTF_MISMATCH
warning: unused option: RCU_PERF_TEST

On 6.0.Z the following options are unused:
warning: unused option: ANDROID
warning: unused option: DEBUG_INFO_BTF
warning: unused option: DEBUG_STACKOVERFLOW
warning: unused option: EXT4_ENCRYPTION
warning: unused option: F2FS_FS_ENCRYPTION
warning: unused option: INET_DIAG_DESTROY
warning: unused option: INET_MPTCP_DIAG
warning: unused option: INET_RAW_DIAG
warning: unused option: INET_TCP_DIAG
warning: unused option: INET_UDP_DIAG
warning: unused option: IO_STRICT_DEVMEM
warning: unused option: MODULE_ALLOW_BTF_MISMATCH
warning: unused option: RCU_PERF_TEST

We can land this without it, but it'd be great to:

If the option just changed names, then update the name
If the option is gone (e.f. CONFIG_ANDROID) then gate it to not be applied to kernels >= 6.0

@lovesegfault it seems like there are 2 already open PRs related to those unused options.
https://github.com/NixOS/nixpkgs/pull/141505
https://github.com/NixOS/nixpkgs/pull/164906

Now that the branchoff has happened this is ready

@fabianhjr Could you cherry-pick them together with this one, that way we can land one large cleanup?

Sure

Cherry-picked #164906

:| don't know how I feel about this @lovesegfault, I would rather this Merge Request be more on the 0 rebuilds side.

@K900 it seems like for this particular case it does work as a 0 rebuild change. :3

Oh, sorry, I thought you were removing unused options here too.

:| don't know how I feel about this @lovesegfault, I would rather this Merge Request be more on the 0 rebuilds side.

I'll make sure all the kernels build, give me a moment


unable to form bulk upsert query

in v 1.3.3
query := "INSERT INTO TABLE_VALUES (`tid`, `uid`, `count`, `deposit`, `ver`) VALUES (:tid, :uid, :count, :deposit, :ver) ON DUPLICATE KEY UPDATE `tid`=VALUES(`tid`), `uid`=VALUES(`uid`), `count`=VALUES(`count`), `deposit`=VALUES(`deposit`), `ver`=VALUES(`ver`)"
args := []map[string]interface{}{
        {"tid": 1, "uid": 1, "count": 1, "deposit": 0, "ver": 0},
        {"tid": 2, "uid": 1, "count": 1, "deposit": 0, "ver": 0},
    }
query, argsOut, err := sqlx.Named(query, args)
_, err = db.ExecContext(ctx, query, argsOut...)

got sql: expected 5 arguments, got 10 error.

Any update on this?

I think version >= 1.3.4 should has already fixed this

yes, version >= 1.3.4 is ok.

I can confirm, this works on v1.3.5!
Maybe close this issue?

I got the same problem with 1.3.5 version

same problem on 1.4.0


whose view is not in the window hierarchy!

I receive this warning when try to put the ad before to play a video from stream.
Warning: Attempt to present Warning: Attempt to present <GADInterstitialViewController: 0x1994ce80> on <MainViewController: 0x155b1f60> whose view is not in the window hierarchy!

your cordova-ios and plugin version please?

@floatinghotpot
cordova -v 5.0.0
cordova-plugin-admobpro 2.8.0 "AdMob Plugin Pro"
Regards.

I re-tested it on ios, and cannot reproduce your problem.
can you tell me the steps to re-produce the issue?

    $scope.playVideo = function(videoUrl){

        var options = {
            successCallback: function() {

            },
            errorCallback: function(obj) {
                $cordovaDialogs.alert('No se puede reproducir el canal en estos momentos', 'Canal fuera del aire', 'Ok');
            }
        };
        window.plugins.streamingMedia.playVideo(videoUrl, options);
        $timeout( function(){ $cordovaGoogleAds.prepareInterstitial( {adId:AdMob.admobid.interstitial, autoShow:true} ); }, 30000);

    };

I think it's probably caused by the streamingMedia plugin, which changed the Cordova view hierarchy.


U673/memory usage disable sound. 34MB~ less

Should be merged into memory usage without a pull request, however i want it tested properly first.


New event.detail.request is ignored in before-try

I'm trying to use a before-try listener to replace the server URL with a proxy URL. Am I assigning it wrong or missing something?
Thanks!
Problem: The docs (https://mrin9.github.io/RapiDoc/api.html#methods) state that the Request object can be modified during before-try and used to make the request. However, the Request object is immutable. If I replace event.detail.request with a new Request object (that contains my new URL), the old/default URL is still used instead.
Steps:

Code example below.
The handler runs before the request is made.
The handler successfully creates the new object.

Expectation: The request URL should be my new, modified proxy URL.
Example:
function handleBeforeTry(event) {
  console.log('before try...')
  if(!event?.detail?.request) {
     return;
  }
  const proxyBaseUrl = 'http://localhost:3000/doc-proxy';  //rapidoc URL
  try {
    /** Create proxy URL. **/
    const apiUrl = new URL(event.detail.request.url);
    const proxyUrl = new URL(`${proxyBaseUrl}${apiUrl.pathname}${apiUrl.search}`);
    /** Clone the request, but use the new URL. **/
    const request = new Request(proxyUrl.toString(), event.detail.request);
    event.detail.request = request;
    console.log(event);
  } catch {
    console.log(event);
    console.error('Failed to create the proxy URL from the request.');
  }
}

current.addEventListener('before-try', (e) => {
  handleBeforeTry(e);
});

you may not replace Request object which you are trying to do by creating a new request object. Instead you may modify the existing request object (i,e) change its attributes etc.


Upgrade the repository to .NET 6.0

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Please update the repository to be compatible with .NET 6.0. There are two requirements:

CI should install .NET versions 6.x and 3.x side-by side, as in this example. This can be accomplished by updating to the latest version of ci-mgmt or manually if this repository is no longer using ci-mgmt.

Any .NET examples should migrate to 6.x also. Here is an example. This can be done manually, or via search-replace, but it's also automated as a source migration in ci-mgmt so if that's an option, updating to the latest ci-mgmt will make this happen.

Affected area/feature

https://github.com/pulumi/pulumi-aws/blob/master/sdk/dotnet/Pulumi.Aws.csproj#L13 well this looks to be done.


[Sidebar] [v2.2.14] Menu disappears and reappears when clicking in the burger menu on IE11

Hi,
I think there's an animation issue when clicking the burger menu in the sidebar with IE11.
Only IE11 has the problem. Tested with Chrome, Firefox and Edge.
When clicking the burger menu, the menu disappear while the sidebar opens and when the sidebar is open, the menu reappears. I think IE11 has issues rendering the animation.
I made a jsfiddle for demonstrating the issue.
Thanks

I updated semantic for v2.3.1 and the bug it still there.


Update poetry source in devcontainer build

@andrii-balitskyi

the diff might be messed up, I just see a lot of deleted files

ah thanks! supposed to be a one line change.... on it


New version: LibreWolf.LibreWolf version 129.0.1-1

Pull request has been created with komac v2.4.1 :rocket:
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Automatic Validation ended with:
(Automated response - build 888.)


Azure CLI curl package removed as default in 2.54.0

Describe the bug
We have noticed that curl is missing in Azure CLI version 2.54.0 which is present in all previous versions as default.
This can be replicated using following github workflow :
name: AzureCLI
on:
  pull_request:
    branches:
      - main
jobs:
  check-cli-curl:
    runs-on: ubuntu-latest
    steps:

    - name: Add the runner
      uses: azure/CLI@v1
      with:
        azcliversion: 2.53.1
        inlineScript: |
          set -x
          IP=`curl https://api.ipify.org`
          echo "RUNNER_IP=$IP" >> $GITHUB_ENV

    - name: Add the runner
      uses: azure/CLI@v1
      with:
        azcliversion: 2.54.0
        inlineScript: |
          set -x
          IP=`curl https://api.ipify.org`
          echo "RUNNER_IP=$IP" >> $GITHUB_ENV

Related command
curl https://api.ipify.org
Errors
curl not found in latest version
Issue script & Debug output
NA
Expected behavior
It should return IP address
Environment Summary
2.54.0
Additional context

Thank you for opening this issue, we will look into it.

This is expected, see https://github.com/Azure/azure-cli/pull/27567

@bebound, I might be completely off base but how is a breaking change acceptable without a version change to enable users to migrate when an expected change breaks existing functionality?

Thanks @bebound , But, somehow its missing in release notes of latest version which is confusing or if I have missed it.

Thanks @bebound , But, somehow its missing in release notes of latest version which is confusing or if I have missed it.

yes that's true. during last couple months in each azure cli version I have been struggling with the pipelines. at least it needs to be documented

I don't understand why a breaking change such as previously functional cmdlets inside of the az cli action should require someone to investigate why they stop working out of the blue. If someone is going to make a major change to functionality, why not do a version step? Some of us aren't developers and finding out why our pipeline broke is not fun.

It's in the release note

[BREAKING CHANGE] Remove unnecessary packages in docker image


Calendar button is not showing up.

Hello,
I am able to load the component successfully but I am not able to get the calendar button to click and select the date
Component.html -
<ng2-datepicker [(ngModel)]="date">
Component.ts -
dataForm: FormGroup;
constructor(private formBuilder: FormBuilder) {
}
ngOnInit() {
this.dataForm = this.formBuilder.group({
date: ''
});
}

Can anybody help on this?

its using ionicons ,u need to import that also.

Thank you. I figured it our yesterday. It is working now. Thanks for the response.

Why is this not mentioned as a requirement?

@jkuri this should be mentioned in requirements

hi guys. my plan is to include inline SVG icons so this will not be needed anymore. very short on time but will try to squeze this in for the weekend.

Just include bootstrap and font awesome icons integration :)
Manish Kumar

On 25-Feb-2017, at 17:40, Jan Kuri<EMAIL_ADDRESS>wrote:
hi guys. my plan is to include inline SVG icons so this will not be needed anymore. very short on time but will try to squeze this in for the weekend.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Feature: Added transitions between pages

Description

Added some cool new transitions between pages and among other elements, including:

Regular pages crossfade between each other
When transitioning between the main blog page and individiual blog posts, the title and thumbnail of each post animate between their position in each page smoothly.
The marker indicating the current docs page in the docs sidebar animates between selected items

Please comment if you have any ideas for what we can add; I'm so excited about this I'd love to just experiment and see what's possible.
Motivation and Context

SvelteKit recently added support for the onNavigate lifecycle function, which unlocked the usage of the View Transition API.
This API makes visually appealing, app-like transitions easily possible on the web, and I saw the opportunity and jumped on it.
Fixes #532
Screenshots (if appropriate):

https://github.com/files-community/Website/assets/65342367/79ec2c1a-1a0c-4e4a-8059-79a13e53df43
https://github.com/files-community/Website/assets/65342367/1d9682d1-c333-49c3-b741-61012ec653ee

Was the blog page layout reversed?

Yes, I discussed it with @mdtauk and we agreed that it makes the transition look more natural.

I think this is really cool, thanks for implementing this. Given that we now animate the page header when opening a blog page, would it be worth scrolling the top when opening a specific blog post? I know that the blog page being visible in the middle was present beforehand, however with the animation I feel like this oddity is made even worse.

@chingucoding removing the scroller class from the <body> element did the trick, all pages now scroll to the top after navigating. Here's how this looks with the transitions:
https://github.com/files-community/Website/assets/65342367/ce8f6b18-b54b-458e-b3d1-fa6d91754063


Easy way to close class to new attributes (perhaps with attr.evolve syntactic sugar)

I'm not sure this is a feature or bug in attrs, but like all python classes, attrs classes are open to creation of new attributes:
import attr

@attr.s
class Test(object):
    pass

test = Test()
test.a = "bla"
test
# Test()
test.a
# 'bla'

Problem
It would be nice to be able to close a class to new attributes for two reasons:

Sometimes I like to pass around data structures in my scientific analyses.  I use classes for that purpose and I find it very helpful to have one place where all possible attributes of the class are defined.
It is a common error mode of mine that I misspell an attribute when I assign to it, and then I'm off bug hunting for a while until I find the typo.  Sure, modern IDE's like Pycharm will highlight these kinds of mistakes, but it would be nice to be able to use a basic editor on some python code without having the feeling that I'm walking on a tightrope without a net...

Currently I use this code to close a class to new attributes:
class FrozenClass(object):
    __isfrozen = False

    def __setattr__(self, key, value):
        if self.__isfrozen and not hasattr(self, key):
            raise TypeError("Cannot set {}: {} is a frozen class".format(key, self))
        object.__setattr__(self, key, value)

    def _freeze(self):
        self.__isfrozen = True

Other considerations

I realize that attrs has a frozen=True option, but that also closes an object to reassigning attributes.  Sure, I could use something like i1 = attr.evolve(i1, y=3) for attribute assignment, but that's quite clunky.  I guess what I'm asking for is a class initialization flag that wraps all attribute assignments of a frozen class with attr.evolve?
There is another feature request (https://github.com/python-attrs/attrs/issues/133) to freeze individual attributes, but that feature is orthogonal to what I am proposing.

In  regards to point 1. of "Other considerations", it looks like assigning to self inside a method does not do what I hoped it would -,-. That is, self = attr.evolve(self, name=value) would not work...

How about something a long the lines of this?
class A:
    def __setattr__(self, name, value):
        if name in __dict__:
            # set attribute here
            # Not sure how to do that in attr
        else:
            raise ClosedInstanceError('{} is closed to new attributes'.format(self.__class__.__name__))

That honestly sounds more like a separate decorator?  Your implementation for example doesn’t need access to the attributes at all?

Good point! I'll have a go at that.

In case anyone else would like to do the same thing, I modified this code to get:
import attr
from functools import wraps

def closed_to_new_attrs(cls):
    cls.__frozen = False

    def frozensetattr(self, key, value):
        if self.__frozen and not hasattr(self, key):
            raise TypeError("Class {} is closed to new attributes. Cannot set {} = {}"
                            .format(cls.__name__, key, value))
        else:
            object.__setattr__(self, key, value)

    def init_decorator(func):
        @wraps(func)
        def wrapper(self, *args, **kwargs):
            func(self, *args, **kwargs)
            self.__frozen = True

        return wrapper

    cls.__setattr__ = frozensetattr
    cls.__init__ = init_decorator(cls.__init__)

    return cls

and it appears to work if I use it like this:
@closed_to_new_attrs
@attr.s
class C(object):
    a = attr.ib()

c = C(a = "foo")
c.b = "bar"
# Traceback (most recent call last):
#  File "<stdin>", line 1, in <module>
#  File "<stdin>", line 6, in frozensetattr
#TypeError: Class C is closed to new attributes. Cannot set b = bar

Could you just use a slot class instead?

I have not really used slots before, but it appears that you are correct!
>>> import attr
>>> @attr.s(slots=True)
... class C(object):
...     a = attr.ib()
...
>>> a = C("bla")
>>> a
C(a='bla')
>>> a.b = 'blarb'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'C' object has no attribute 'b'
>>>

This should only work for classes that don't inherit from non-slot classes, but that's good enough for me at this point.