Saved model, KeyError: 'serving_default'

Have I written custom code: N/A
OS Platform and Distribution: Ubuntu 18.04
TensorFlow installed from : pip3
TensorFlow version 1.14.0
Bazel version 1.1.0
CUDA/cuDNN version: 10.1 / N/A
GPU model and memory GeForce GTX 1050
Exact command to reproduce : Describe below
I try to use that generated model:
http://eugen-lange.de/download/ssd-4-traffic-sign-detection-frozen_inpherence_graph-pb/
Here is my program:
class TFEngine:
    def __init__(self, model_name):
        self.model = None

        if "ssd4tsd_full" in model_name:
            self.load_model_local("/home/xavier/Downloads/"+model_name + "/saved_model")
        else:
            self.load_model(model_name)

    def load_model(self, model_name):
        base_url = 'http://download.tensorflow.org/models/object_detection/'
        model_file = model_name + '.tar.gz'
        model_dir = tf.keras.utils.get_file(
            fname=model_name,
            origin=base_url + model_file,
            untar=True)
        model_dir = pathlib.Path(model_dir) / "saved_model"
        model = tf.saved_model.load(str(model_dir))
        self.model = model.signatures['serving_default']
        return model

    def load_model_local(self, model_dir):
        model = tf.saved_model.load(str(model_dir))
        self.model = model.signatures['serving_default']
        return model

    def DetectWithImage(self, image):
        image = np.array(image)
        image = np.asarray(image)
        # The input needs to be a tensor, convert it using `tf.convert_to_tensor`.
        input_tensor = tf.convert_to_tensor(image)
        # The model expects a batch of images, so add an axis with `tf.newaxis`.
        input_tensor = input_tensor[tf.newaxis, ...]

        # Run inference
        output_dict = self.model(input_tensor)

        # All outputs are batches tensors.
        # Convert to numpy arrays, and take index [0] to remove the batch dimension.
        # We're only interested in the first num_detections.
        num_detections = int(output_dict.pop('num_detections'))
        output_dict = {key: value[0, :num_detections].numpy()
                       for key, value in output_dict.items()}
        output_dict['num_detections'] = num_detections

        # detection_classes should be ints.
        output_dict['detection_classes'] = output_dict['detection_classes'].astype(np.int64)

        # Handle models with masks:
        if 'detection_masks' in output_dict:
            # Reframe the the bbox mask to the image size.
            detection_masks_reframed = utils_ops.reframe_box_masks_to_image_masks(
                output_dict['detection_masks'], output_dict['detection_boxes'],
                image.shape[0], image.shape[1])
            detection_masks_reframed = tf.cast(detection_masks_reframed > 0.5,
                                               tf.uint8)
            output_dict['detection_masks_reframed'] = detection_masks_reframed.numpy()

        return output_dict

.....

image_size = list([720, 1280])
tf_engine = TFEngine(model_name)
output_dict = tf_engine.DetectWithImage(frame)
obj_img = append_objs_to_img(frame, output_dict, category_index)

I get the error:
   return self._signatures[key] KeyError: 'serving_default'
I think the model is not in savedModel format so I try to convert it into savedModel :
python ~/dev/tensorflow/tensorflow/python/tools/saved_model_cli.py convert --dir /home/xavier/Downloads/ssd4tsd_full/ --output_dir /home/xavier/Downloads/ssd4tsd_full/saved_model/ --tag_set serve --signature_def serving_default usage: saved_model_cli.py convert [-h] --dir DIR --output_dir OUTPUT_DIR                                   --tag_set TAG_SET                                   {tensorrt} ... saved_model_cli.py convert: error: invalid choice: 'serving_default' (choose from 'tensorrt')
I don't know how to solve it.

@xav12358, Tried replicating issue, looks like code is incomplete.
Please find the gist and provide more information to replicate the reported issue. Thanks!

I have a query regarding
model_fn = model.signatures['serving_default']
What purpose does it serve?
My intention is to run prediction only when a particular condition is satisfied..
The comment line in the code mentions that the line is mentioned above does the prediction part utilizing the model.So I think I'm supposed to go inside this 'signatures' function and modify.
Please help me out with this.

That question belongs to Stack Overflow.


Won't launch

When ever I try to launch this, I get the following error message:
'/home/my-user-name/.tmux/plugins/tmux-fzf/scripts/.sh' returned 127

I notice the part of the filename before the extension is missing.
I'm running tmux 2.6 on WSL.

Please checkout #1 branch to see if it solves this problem.

Yeah, its launching as expected now.

Many thanks for fixing this.

I've merged #1 to master, now you can checkout master branch and update this plugin.

Hey @sainnhe, I'm running into the same issue. I'm on the latest version of the plugin.
Tmux Version: 2.3
OS: Debian 10

@leveled Very sorry, I've tried tmux 2.3 on my surfacepro/archlinux, but still cannot reproduce.
Please try minimal tmux configuration(with installation command only), and reinstall this plugin.
Btw, I think this may be related to the version of bash. What's your bash version?

I can confirm the issue on at least three setups. All of them run on the same .tmux.conf with minimal requirements (tpm + tmux-fzf). Moreover I should note that I use the tmux zsh plugin (including autostart).

Raspbian GNU/Linux 9 (stretch), 4.19.66-v7+ #1253 SMP Thu Aug 15 11:49:46 BST 2019 armv7l GNU/Linux

zsh 5.3.1 (arm-unknown-linux-gnueabihf)
GNU bash, version 4.4.12(1)-release (arm-unknown-linux-gnueabihf)
tmux 2.3

WSL, Debian GNU/Linux 9 (stretch), 4.4.0-17134-Microsoft #706-Microsoft Mon Apr 01 18:13:00 PST 2019 x86_64 GNU/Linux

zsh 5.3.1 (x86_64-debian-linux-gnu)
GNU bash, version 4.4.12(1)-release (x86_64-pc-linux-gnu)
tmux 2.8

Linux Mint 19.2, 4.15.0-65-generic, #74-Ubuntu SMP Tue Sep 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

zsh 5.4.2 (x86_64-ubuntu-linux-gnu)
GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)
tmux 2.6

I don't see any common denominator here, but if I find the time, I'll start some debugging.

It seems that some people still have this problem, but I'm unable to reproduce this on my Arch Linux on PC and Debian Server(debian 9.11 stretch). I have no idea what is going on.
Help wanted.

Okay, so here's what I've got so far:
The mentioned error occurs when ITEM is empty at main.sh:18. This can basically only happen if something is going wrong in .fzf-tmux. My first guess was that the embedded script might be outdated (and it is) but that's not the issue.
In my case, the issue is that tmux could not find fzf (more on that below). This results in the fallback at .fzf-tmux:10 which sets fzf="$(dirname "$0")/fzf. This fallback makes perfectly sense for the original script along with the compiled binary which is stored at this exact location. Obviously though, the fzf binary is not present in this folder (since it's not part of this repo), so the next line fails with fzf executable not found. This error however is printed to stderr, so it's not only not propagated up to the calling command substitution but also eaten up by tmux (i.e. tmux doesn't print stderr, e.g. tmux run-shell 'echo foo >&2' has no output). This made the error very difficult to spot.
So why is fzf not found? To begin with, I'm currently running zsh as my default shell and configured zplugin to manage lots of scripts, tools and helpers, one of which is fzf. Zplugin is very careful to not pollute global directories, so it stores all binaries in user-local paths and only propagates them to the current shell. The problem is that tmux somehow still uses bash instead of zsh, so zplugin is not loaded and therefore fzf is not in $PATH. The only thing I still don't get is why (any hints on this are appreciated). I've set the corresponding options (at least the ones I know of) but it doesn't work:
~ $ tmux show-options -g | grep default-
default-command "/usr/bin/zsh"
default-shell "/usr/bin/zsh"
~ $ tmux run 'echo $SHELL'
/bin/bash

So technically, it's not an issue with tmux-fzf, but all of the above is very specific to my case. For others it might be best to start checking whether tmux is able to find fzf: tmux run-shell 'command -v fzf'

@Gerrit-K Very helpful. Thanks! I've updated README.

I finally got it to work on all my setups. In the end I it was not the wrong shell being executed but rather a combination of zplugin's turbo mode (which delays plugin loading and executes it in the background to improve shell startup time) and the autostart setting of the tmux zsh plugin (which automatically starts a tmux session or attaches to an existing one on plugin load). So basically tmux was started automatically before the zplugin background process was able to load fzf into the PATH. I currently fixed it by simply disabling the turbo mode for fzf again.
To me, this issue is fixed now (as it never actually was an issue with tmux-fzf), but I'm happy to help out anyone else who is still having issues.

I'm running into this same issue
/Users/username/.tmux/plugins/tmux-fzf/scripts/.sh' returned 127

Tmux version 3.0a on OSX in ZSH.
tmux run-shell 'command -v fzf' returns /usr/local/bin/fzf
Is this plugin not working with Tmux 3?
Thanks!

@optijon Did you install gnu-sed on mac OS? #5

I did.
sed --version
=> sed (GNU sed) 4.8

@optijon Oh, I just noticed that you are using zsh right? Did you install GNU bash? It's listed in Requirements.
If you've installed bash, but still encounter this problem, you may need to debug this plugin by yourself because I can't reproduce this.

First of all, check if /path/to/tmux-fzf/scripts/.fzf-tmux works. You can test it using this command: ls | /path/to/tmux-fzf/scripts/.fzf-tmux
If it works, then debug /path/to/tmux-fzf/main.sh. To debug a specific line, you can simply comment out other lines and execute this script.

All of the required dependecies have been installed. I did some debugging and I was able to get this script to work. I'm very confused as to why it's working and my bash script-foo is not the greatest so maybe you can do something with this?
On line 113 in .fzf-mux if I add any arbitrary command in quotes above the FZF call like so:
if [[ -z "$TMUX" || "$opt" =~ ^-h && "$columns" -le 40 || ! "$opt" =~ ^-h && "$lines" -le 15 ]]; then
   "${ls}"
  "$fzf" "${args[@]}"
  exit $?
fi

And it works.
If you remove the line, $? shows a 2 status. Could this be some sort of timing issue?

@optijon The scripts/.fzf-tmux is a modified version of the original fzf-tmux in the official repository. I use a modified one because the original one doesn't work before, but the it seems to work now(I don't know why, but it works).
So I created a branch named original-fzf-script which uses the original fzf-tmux, could you checkout this branch and get it a try?
Also, if the problem is caused by fzf-tmux script, you can try the fzf-tmux command in your shell directly, like this:
ls -a ~ | fzf-tmux

This command is provided by fzf, see here for detailed guide.
Sorry but I can't provide more help, because this script is not written by me, it's copied from the official repository. If this issue can be reproduced using the original one, maybe you can consider to open an issue in junegunn/fzf.

I finally got it to work on all my setups. In the end I it was not the wrong shell being executed but rather a combination of zplugin's turbo mode (which delays plugin loading and executes it in the background to improve shell startup time) and the autostart setting of the tmux zsh plugin (which automatically starts a tmux session or attaches to an existing one on plugin load). So basically tmux was started automatically before the zplugin background process was able to load fzf into the PATH. I currently fixed it by simply disabling the turbo mode for fzf again.
To me, this issue is fixed now (as it never actually was an issue with tmux-fzf), but I'm happy to help out anyone else who is still having issues.

Life saver 😄

In my case, tmux run-shell 'command -v fzf' also returned 127 => fzf could not be found.
You can check via
tmux run-shell -b 'echo $PATH'
if  tmux should be able to find fzf in $PATH.
If not, check if you set the $PATH variable in the tmux configuration wrong (set-environment -g PATH "...") or if the $PATH of the tmux default shell (set-option -g default-shell _shell_) has fzf included.


Run ktlint from repository root

This is the result of running ktlint from the repository root. We have
ktlint running on pre-commit and CI on changed files, but these
violations slipped through the cracks.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I'll submit a follow-up PR upgrading ktlint to the latest version.

Provided we can upgrade Kotlin version to 1.6.20.


Add V4L2 MJPEG encoder and example

Split out H264 encoder from V4L2 encoder
Also fix broken imports on video examples

Signed-off-by: Chris Richardson<EMAIL_ADDRESS>

I really like how there's now a V4L2 base class that takes care of almost everything, very tidy! Do you want me to merge it?

:) Cheers, that'd be good


Filter clipboard data appended to file.

Filter clipboard data appended to file.
Example of valid data to record: /jumploc 2928.40 509.95 2421.73 271
The clipboard needs to include "/jumploc" or it should not write the clipboard data to file.

implemented with 1.1.0


Unused variables ExtendedParforDiagnostics

Flake8 error:
./numba_dppy/dppy_parfor_diagnostics.py:99:40: F821 undefined name 'fadj'
                region_id = print_nest(fadj, nadj, pf_id, reported, region_id)
                                       ^
./numba_dppy/dppy_parfor_diagnostics.py:99:46: F821 undefined name 'nadj'
                region_id = print_nest(fadj, nadj, pf_id, reported, region_id)
                                             ^

@1e-to git shows that it is your code.

Fixes #461


Feat: Food recommendation system using Machine Learning

Issue Template

Issue type

Feature request

Description
Create a Machine learning model that will recommend food to student based on their age, weight, etc.

My name is Dipayan Majumder .I want to do this project . Can you give me the dataset or i will create this using GenAI .

My name is Dipayan Majumder .I want to do this project . Can you give me the dataset or i will create this using GenAI .
@dipayan22
You can start working on this issue.
You can create your own dataset. Make sure you create a small documentation regarding the algorithms used in it.

@dipayan22
Are you done working on this issue ?

yes i am working in this issue , please give me some time because i have my exams this week .

@dipayan22
Any updates ?

@dipayan22


Null reference exception is wrapped in unsupported exception

Found a strange bug, after debugging for a long time.
Basically if you have a property which is of any class which has say an int property on it (i suspect any type would work). Any call to that nested property will throw a Specified method is not supported. exception.
Marten.Linq.MartenExpressionParser.Value(Expression expression)
Marten.Linq.MartenExpressionParser.buildSimpleWhereClause(DocumentMapping mapping, BinaryExpression binary)
Marten.Linq.MartenExpressionParser.GetWhereFragment(DocumentMapping mapping, BinaryExpression binary)
Marten.Linq.MartenExpressionParser.ParseWhereFragment(DocumentMapping mapping, Expression expression)
Marten.Linq.DocumentQuery.buildWhereClause()
Marten.Linq.DocumentQuery.ToCommand()
Marten.Linq.MartenQueryExecutor.BuildCommand(QueryModel queryModel)
Marten.Linq.MartenQueryExecutor.Remotion.Linq.IQueryExecutor.ExecuteCollection[T](QueryModel queryModel)
Remotion.Linq.Clauses.StreamedData.StreamedSequenceInfo.ExecuteCollectionQueryModel[T](QueryModel queryModel, IQueryExecutor executor)
Remotion.Linq.Clauses.StreamedData.StreamedSequenceInfo.ExecuteQueryModel(QueryModel queryModel, IQueryExecutor executor)
Remotion.Linq.QueryModel.Execute(IQueryExecutor executor)
Remotion.Linq.QueryProviderBase.Execute(Expression expression)
Remotion.Linq.QueryProviderBase.System.Linq.IQueryProvider.Execute[TResult](Expression expression)
Remotion.Linq.QueryableBase`1.GetEnumerator()
System.Linq.Buffer`1..ctor(IEnumerable`1 source)
System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
HyRes.Website.Modules.Account.AlbumsModule.<>c__DisplayClass0_0.<<-ctor>b__0>d.MoveNext() AlbumsModule.cs: line: 28

Here's a basic test (written but I haven't run it because I haven't got Marten tests running locally yet :disappointed:)
public class TestExceptionScenario
{
    public class TestClass
    {
        public int Id { get; set; }
    }

    public TestClass TestNullObject { get; set; }

    [Fact]
    public void When_Property_Is_Null_Exception_Should_Be_Null_Reference_Exception()
    {
        using (var session = store.OpenSession())
        {
            Assert.Throws<NullReferenceException>(() => session.Query<TestClass>().Where(x => x.Id == TestNullObject.Id).ToArray());
        }
    }
}

Something like this.
So the property TestNullObject is never initialized. So when the query is executed I expect a null reference exception because it cannot work out what the value of TestNullObject.Id is in order to build the query.

So this is really an issue of having a confusing exception message more than anything, right?

Correct. Just worried someone will run here saying "OMG WHY IS THIS UNSUPPORTED" when its a user error. Better to give them an exception telling them to fix their code.


Update Coderabbit cypress practices suggestions about using const assertions instead of strings

Setup is added. Due to lack of evidence keep updating to newer version instructions


langchain.chat_models import fails

System Info
Langchain: 0.0.81
Python: 3.11.5
System: Ubuntu
Trying to install Langchain and run the basic Quick Start sample code. Importing langchain.chat_models thows a ModuleNotFoundError.
$ python3
Python 3.11.5 (main, Aug 25 2023, 07:43:52) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from langchain.llms import OpenAI
>>> from langchain.chat_models import ChatOpenAI
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'langchain.chat_models'

Any suggestions?
Who can help?
No response
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
Steps to reproduce:

pip install langchain[all]
run python3 REPL
try to import langchain.chat_models

Expected behavior
chat_models import succeeds.

It was solved with updating LangChain to new version.


Camera2 Pass Images from ImageReader to MediaRecorder

Hi!
I'm trying to create a Camera2 CameraCaptureSession that is capable of four outputs:

On-screen preview (SurfaceView, up to 1080p)
Photo capture (ImageReader, up to 8k photos)
Video Capture (MediaRecorder/MediaCodec, up to 4k videos)
Frame Processing (ImageReader, up to 4k video frames)

Unfortunately Camera2 does not support attaching all of those four outputs (Surfaces) at the same time, so I'm going to have to make a compromise.
The compromise that seemed most logical to me was to combine the two video capture pipelines into one, so that the Frame Processing output (#4, ImageReader) redirects the frames into the Video Capture output (#3, MediaRecorder).
How do I write the Images from the ImageReader:
val imageReader = ImageReader.newInstance(4000, 2256, ImageFormat.YUV_420_888, 3)
imageReader.setOnImageAvailableListener({ reader ->
  val image = reader.acquireNextImage() ?: return@setOnImageAvailableListener
  callback.onVideoFrameCaptured(image)
}, queue.handler)

val captureSession = device.createCaptureSession(.., imageReader.surface)

..into the Surface from the MediaRecorder?
val surface = MediaCodec.createPersistentInputSurface()
val recorder = MediaRecorder(context)
..
recorder.setInputSurface(surface)

I'm not too familiar with OpenGL, so any help here would be appreciated.

在OPENGL环境中创建OES texture->Surfacetexture->Surface   ，用这个surface去configSession
预览帧来了之后会绑定到OES texture中，然后你可以绘制到MediaRecorder或者imageReader的surface上


errors when compiling the project

Getting bunch of errors - https://www.evernote.com/l/ADn0Vp91dwRN45Q-9Tz4yndbV4cRFOxaO48 when running the pod.
XCode 7.3, Swift 2.2

Hey @odedharth, just pushed our version 1.0.7 to CocoaPods.
Let me know if it works!

I'm not able to download it from cocoapods
[!] Unable to satisfy the following requirements:

Pager (= 1.0.7) required by Podfile

None of your spec sources contain a spec satisfying the dependency: `Pager (= 1.0.7)`.

You have either:
 * out-of-date source repos which you can update with `pod repo update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by default.

We're on 1.0.8 now...

@odedharth did it work?

I'm gonna close it.. Lemme know if it doesn't work


[DOCS] Static website loaded in Chrome becomes page unresponsive

Describe the issue

PDK documentation website loaded in Chrome will become responsive. Has consistently occurred multiple times. Tested in firefox it took a few seconds but loaded.
Links
https://aws.github.io/aws-prototyping-sdk/typescript/cdk-graph/index.html
https://aws.github.io/aws-prototyping-sdk/java/open-api-gateway/index.html

Hi @em-xqm - are you still experiencing this issue? I am unable to reproduce this locally.

Closing as this has been unable to be reproduced locally and have not received updated correspondence. Please re-open if you are still experiencing this issue.


Stan updates

Resolves #3410
Changes
Updated Stan highlighter for Stan version 2.28

complex and array types
complex numbers
added all new functions and distributions

Improvements over previous

highlighting of constants
highlighting for user defined distributions
highlighting for truncation

Checklist

[x] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md

I'm going to have to break out distributions. Hold on to review until I've pushed the next update.

the only thing this doesn't have anymore is highlighting for user defined distributions but I think I can try to tackle that in a different PR

This is good to review. That multi-match stuff is great. Got truncation working and UDFs

Oh line 10 is broken that's weird.

🎉

Thanks all for the great work!


Support Ranged-Formatting

While working on https://github.com/google/vim-codefmt and adding buildifier support, we discussed adding ranged-format, which is standard for many formatters, and which is useful for formatting diffs.
This isn't a big problem since formatting the whole file works pretty well, but would be nice if it were easy to add.

What is ranged formatting?
On Sun, Jan 22, 2017 at 4:00 PM, Josh Hoak<EMAIL_ADDRESS>wrote:

While working on https://github.com/google/vim-codefmt and adding
buildifier support, we discussed adding ranged-format, which is standard
for many formatters, which is useful for formatting diffs.
This isn't a big problem since formatting the whole file works pretty
well, but would be nice if it were easy to add.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/buildifier/issues/40, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALF-0vhYoV-XuwBFPng88scopkjunCzGks5rU8OIgaJpZM4LqgIo
.

Oh, do you mean: format only a sub-range of this BUILD file?
I can see how that makes sense for other languages: since you want to
format what you have changed, but not get blamed for other lines of code.
But with BUILD files, we really want them to always be completely formatted
correctly.
On Mon, Jan 23, 2017 at 9:49 AM, Paul Bethe<EMAIL_ADDRESS>wrote:

What is ranged formatting?
On Sun, Jan 22, 2017 at 4:00 PM, Josh Hoak<EMAIL_ADDRESS>wrote:

While working on https://github.com/google/vim-codefmt and adding
buildifier support, we discussed adding ranged-format, which is standard
for many formatters, which is useful for formatting diffs.
This isn't a big problem since formatting the whole file works pretty
well, but would be nice if it were easy to add.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/buildifier/issues/40, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALF-0vhYoV-XuwBFPng88scopkjunCzGks5rU8OIgaJpZM4LqgIo
.


Add GithubUtils and generateVersionComparaisonURL

@roryabraham will you please review this?
[Explanation of the change or anything fishy that is going on]
I added the class GithubUtils and its method generateVersionComparisonURL.
I installed the following missing packages 'semver' and '@actions/core'.
PS: Also for the tests I needed to use async/await else I got some timeout. Also I tried different workaround for example expect(Promise).resolves.toBe(url) but it was not working correctly. At least with async/await we are sure the tests are working correctly.
Fixed Issues
$ https://github.com/Expensify/Expensify.cash/issues/1577
Tests
For repository with the following tags 2.2.2, 2.2.1, 2.1.0-1, 2.1.0, 2.0.0-1, 2.0.0, 1.2.2-2, 1.2.2-1, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0 and 0.0.1
MAJOR comparison
-- if we pass the tag 2.2.2 as param it should return https:///1.2.2...2.2.2
-- if we pass the tag 1.2.0 as param it should return https:///0.0.1...1.2.0
MINOR comparison
-- if we pass the tag 2.2.2 as param it should return https:///2.1.0...2.2.2
-- if we pass the tag 1.1.0 as param it should return https:///1.0.4...1.1.0
PATCH comparison
-- if we pass the tag 2.2.2 as param it should return https:///2.2.1...2.2.2
-- if we pass the tag 1.0.0 as param it should return https:///0.0.1...1.0.0
BUILD comparison
-- if we pass the tag 2.1.0-1 as param it should return https:///2.1.0...2.1.0-1
-- if we pass the tag 1.2.2-2 as param it should return https:///1.2.2...1.2.2-2
QA
If the generateVersionComparisonURL return the good url following the parameters passed.

I have read the CLA Document and I hereby sign the CLA

recheck

@SombreroElGringo Looks like you've got some merge conflicts to resolve.

Just a couple minor suggestions + the async/await -> promise changes. All minor stuff!


Dispose the AsyncSignalWaiter before setting it to null

Fixes a memory leak within AsyncSignalWaiter when setting the signal on an AsyncSignal instance. See #1584 for more details.

Thanks for your contribution. Good work 👍


Error during deployment

Error while creating Queries and Widgets: Illegal characters in path.

Hi,
Please share the template name that you've tried.
Thanks


[GURPS] 2.9.14

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Added a toggle for ST, DX, IQ, Per, and Will attributes. Clicking the toggle will show/hide a reason for modifier box.
Melee tab, roll modifier tool dialog box. Fixed bug where selecting the posture doesn't update the modifiers. Reported by valkray
Roll Modifier Dialog Box. Added tooltip for the Traits heading and added a section titled Temporary Traits, which will cover cases such as spells and other mitigators.

Character Sheet Info Roll20 Internal Use only.


Lazily parse document in semantic tokens edit.

A user reported that while Razor documents were open their CPU would constantly spin. They decided to profile what was happening in VS and part of the profile indicated that Razor was constantly re-parsing on every semantic token edit poll. Found that we were aggressively generating a code document so just moved the code document calculation logic down a few steps to allow our caching layer to cache without re-parse.

Part of https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1286124

I cannot express how relieved I am to see this fix!  Thank you so much for all your efforts out there.  It is very much appreciated. 🙏


Update request.js

Typo fix in request util parameter definition

The CI failure is obviously not related to this so I'll merge this PR. Thanks @Gargol for taking the time to fix this, much appreciated! :pray:


Use reallocarr on NetBSD (GH #80)

This PR uses reallocarr in xmallocarray on NetBSD.
NetBSD 8.1 is not finding the declaration of reallocarray even with _OPENBSD_SOURCE defined. It is causing a noisy compile. Stepping back a bit, the NetBSD reallocarray(3) man page say to use reallocarr. This PR follows the NetBSD advice.
According to NetBSD's man page,  reallocarr handles overflow properly. There is no need for the reallocarray wrapper:
 The reallocarray() function will return NULL if there was overflow or if
 realloc(3) failed setting errno to EOVERFLOW or preserving the value from
 realloc(3).

Also see Issue 80, util.c:267:24: warning: implicit declaration of function 'reallocarray'.

Yes this looks good, and #80 then does not need that fix, even though that must be wrong still.  The configure.ac bit could be AC_CHECK_FUNCS([reallocarr]) instead, which is just shorter for nearly the same.

Please let me know if that AC_CHECK_FUNCS works for you?  Then, if NSDBSD recommends this, we could merge this PR, but since we don't use the 'keep it around on failure', instead free it anyway, that does not really use the reallocarr features.  Having the _OPENBSD_SOURCE define work instead would solve the issues.


Motor get_database method additional kwargs support

Relates to #70

pymongo is a dependency of motor, but importing objects from pymongo make build / static-analysis (pull_request) failed
Seems it's a new issue for static-analysis stage

Since motor depends on it, you can add it to the known third party of isort. It will then be aware that this package should be considered like that.
Otherwise if you run isort locally, with task lint for example, it should add it automatically there.

This should close #118


Missing an installed package (scipy)

trains-agent  experiment run  is missing one of the installed packages (scipy). Hence it aborts.
Please let me know in case you need more information
python3.6/site-packages/keras_preprocessing/image/affine_transformations.py", line 281, in apply_affine_transform
raise ImportError('Image transformations require SciPy. '
ImportError: Image transformations require SciPy. Install SciPy.

Hi @agunapal , this is somewhat similar to #8 #9
In short when executing your code "manually" inside a python (pip) environment , the trains package records all the environment dependencies (python packages and versions).
Then you can clone the experiment in the UI (and if needed edit the packages, see Execution -> "Installed Packages"),
The trains-agent will take the "Installed packages" list, create a new virtual environment (every time you run the experiment) and install the requested packages into the newly created virtual environment, once done it will update back the experiment to contain all the packages used in the virtual environment (as opposed to the initial list that included only the directly imported packages).
This behavior ensures:

trains-agent  will not ruin any existing environment on the host machine
When cloning an already executed (by trains-agent) experiment, it will create an exact copy of the entire python environment.

Makes sense ?


Fix logstash client hosts

I found that when I'm using hosts with ssl=True and also I had multiple workers then opensearch the client doesn't work properly
My logs: https://{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>{:host=>...
PR to fix it: https://github.com/jgough/logstash-filter-opensearch/pull/3
Solution from elasticsearch-plugin

Thanks for the PR!

Hi @jgough! Could please tell me if you have any opportunity to push new version to rubegems?

Hey, try that now!  Thanks for your help fixing this issue.

it works, thank you!


Footer containing the skillboard logo and link to github repository.

A footer suiting the theme of the website, which will have the logo of skillboard and the link to the skillboard Github repository.
These two items will be responsive too for viewing on various screens.
I would like to work on this issue if possible.

Hi @sneha-pujari, do you still want to work on it or should I mark it as open for contribution for others?

hey @tejasmorkar is this issue still open to contribute to ?

Yes, it is.

Hey @tejasmorkar please check the proposed footer solution at https://vedant-c.github.io/skill-board/login.html . I have created a pull request for the same. Please let me know if there any changes required. Thank you.

check the proposed footer solution at https://vedant-c.github.io/skill-board/login.html
@vedant-c

Looks great! I've reviewed the PR and have requested some changes on the same. You can go through them and let me know if you have any queries by dropping a reply here.


Application freezes after taking many pictures

The application freezes after taking/posting many pictures. UI locks up, basically. No exception, though. Any suggestions on fix?

Does it happen with the demo app?
More generally, you may be doing some picture processing in the main thread, try using Grand Dispatch Central to do it in other threads with lower priority.

I was not able to get down to the bottom of what seems like a deadlock. I am doing some image processing on the main thread. Here is my code:
[NBUImagePickerController startPickerWithTarget:self options:options customStoryboard:nil resultBlock:^(NSArray *imagesOrMediaInfos) {

    id mediaObject = [imagesOrMediaInfos firstObject];
    if ([mediaObject isKindOfClass:[UIImage class]]) {

        UIImage *image = (UIImage *)mediaObject;
        UIImage *transformedImage = [image transformToSquareImage];

        [self.btnSelectPhoto setImage:nil forState:UIControlStateNormal];

        self.imageView.image = transformedImage;

        self.pngData = UIImageJPEGRepresentation(transformedImage, 0.9);
    }
}];

And here is the method in my UIImage category:
- (UIImage *)transformToSquareImage {

     float currentImageWidth = self.size.width;
     float currentImageHeight = self.size.height;

     float diff = currentImageWidth - currentImageHeight;

     if (diff == 0) {
         return self;
     }

     CGSize desiredSize = CGSizeMake(MAX(currentImageWidth, currentImageHeight), MAX(currentImageWidth, currentImageHeight));

     UIGraphicsBeginImageContext(desiredSize);

     UIImage *image1;
     UIImage *image2;

     if (diff > 0) {

         // Width is greater than the height
         image1 = [UIImage createImageWithColor:[UIColor blackColor] size:CGSizeMake(currentImageWidth, diff / 2)];
         image2 = [UIImage createImageWithColor:[UIColor blackColor] size:CGSizeMake(currentImageWidth, diff / 2)];
         [image1 drawInRect:CGRectMake(0 ,0, image1.size.width, image1.size.height)];
         [self drawInRect:CGRectMake(0, image1.size.height, currentImageWidth, currentImageHeight)];
         [image2 drawInRect:CGRectMake(0, image1.size.height + currentImageHeight, image2.size.width, image2.size.height)];

     } else if (diff < 0) {

         // Height is greater than the width
         image1 = [UIImage createImageWithColor:[UIColor blackColor] size:CGSizeMake(-diff / 2, currentImageHeight)];
         image2 = [UIImage createImageWithColor:[UIColor blackColor] size:CGSizeMake(-diff / 2, currentImageHeight)];
         [image1 drawInRect:CGRectMake(0 ,0, image1.size.width, image1.size.height)];
         [self drawInRect:CGRectMake(image1.size.width, 0, currentImageWidth, currentImageHeight)];
         [image2 drawInRect:CGRectMake(image1.size.width + currentImageWidth, 0, image2.size.width, image2.size.height)];

     }

     UIImage *finalImage = UIGraphicsGetImageFromCurrentImageContext();

     UIGraphicsEndImageContext();

     return finalImage;
}

With this code, I would assume that the main thread would only temporarily be blocked until the processing is finished. Am I missing something?

Yes, it should "just" temporarily freeze your app, which isn't good, but shouldn't stop the app altogether.
Try debugging in Xcode by hitting pause when your app gets frozen. Then check the stack trace to see what it was doing.

As for the picker, once it calls your resultBlock it is dismissed and shouldn't be doing anything else. In other words, I'm pretty sure it's on your side.


Avoid exception when parsing arrays in raw data

Overview
This is the same change as #1904 targeted at ogr/develop
Connects #1903
Testing Instructions
Skip testing because the change is identical in both branches.
Checklist

[x] fixup! commits have been squashed
[x] CI passes after rebase
[x] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
[x] This PR is targeted at the correct branch (develop vs. ogr/develop)
[x] If this PR applies to both OAR and OGR a companion PR has been created

Merging without review because the change is the same across branches.


Question: does astronomy relations enforce reference integrity?

Pretty self explanatory question.
Also, sorry for the questions, some parts of the doc are kind of incomplete.
Awesome package man.

What do you mean?

I mean, if I try to add some _id which isn't present in the related collection, will it work or will it throw an error?

It will work. It doesn't make such checks.

Great, thanks man!


celery: only accept msgpack content

SECURITY Forces Celery to only accept msgpack content when using standard configuration. This disallows pickle messages which can be used for remote code execution. (closes #3003)
I didn't write extra documentation as mentioned in #3003, because our standard configuration is secure now and you deliberately change the configuration to something insecure now. If you select pickle as your config then it's clearly your fault.
Rebased against: maint-2.0

Looks good. Can I get you to fix kwalitee issues from http://kwalitee.invenio-software.org/inveniosoftware/invenio/branches/e5d101fd020a8582680ab4c533a4e12f0485ec76/crepererum:fix/celery_pickle2 (sorry, I know it's annoying to fix other old code formatting problems :-) Thanks a lot.

Just to check, you want this to go in maint-2.0 right and not master?

So there are pros and cons for the main-2.0.
Pro:

It's a security patch.
None of our parts uses the other possible serialization methods.

Con:

It's a breaking change in case someone uses external software with our broker.

The decision part is the following: Is the broker an API (documented or undocumented)? How high is the probability that someone uses it with another serialization method? And finally: is this amount high enough to satisfy that we postpone a security patch?
My own opinion is that admins or devs who are using our broker with external software (and other serialization methods) will understand the clearly marked change and can just set the right config flag. For installations which use the standard way, this is clearly a standard security update.
(kwalitee fix will follow)

:shipit:

maint-2.0 it is. Last change, can you add the following the commit message (just so that admins know what to do if they change something):
* INCOMPATIBILITY If you use any Celery serializer other than msgpack, you must
  update configuration variable CELERY_ACCEPT_CONTENT to include that
  serializer.

Ready to go


[Grouping] "visible data" export - column order doesn't match

When exporting "visible data" when grouping is active, the column order of the export may not match the column order of the grid.
This is due to grouping using a column processor to change the order of the grid columns; Grouping moves the grouped-by columns to the left side of the grid. The exporter doesn't use the visible column cache (output from the column processors) when building the visible column list.
http://plnkr.co/edit/MsgkxosmlXMojCOVPY96?p=preview

I just put this into grouping, because that is where we will hit it in our app. I haven't looked into the cause yet, but is this a more general problem with export respecting column processors?
We need to examine this more closely with a user defined column processor which changes the order.

I think it's a more general issue with export respecting column processors. A custom column processor + export test case would work great here.

Export does actually respect column order, I've added it to the 312 tutorial as an example.
The problem is that it can only respect column order for visible columns - because those are the ones in the visible column cache.  If it exports all columns then it has difficulty in getting them from the visible column cache, as that would only give the visible columns (I think strictly speaking the visible column cache may have all the columns in it with some marked invisible, but that is not guaranteed to continue - we did a performance optimisation on rows to remove all the invisible rows and we may do the same to columns).
In short, if you want the columns in visible column order, the you should export visible columns.  If you want all columns then you're stuck with getting them in the base column order.

Going back to the Plunkr on the original issue post, looks like it might be a grouping-specific export issue then? When I export visible columns per your explanation, the export still isn't in the same order as it is in the grid.

OK, I see the problem.  Actually it's using the columns in both cases, and grouping moves the columns dynamically through a columns processor - it doesn't update the columns array (which allows us to go back to the column location pre-grouping when you ungroup again).
Let me change the export to use visible column cache when exporting visible.

Thanks for your work on this. In the plunkr on the original post, looks like this may not be fixed, still. The header order is correct now, but the body is out of order.


Delete command should not error out if there are no existing snapshots

I had a case where I just created a new EC2 Instance and configured ec2-snapper to run on a periodic basis to backup that instance and to clean up old backups. However, when I ran the delete command the first time, having not created any backups before that, I got an error. I’ve updated the code to have the delete command exit gracefully if there are no backups to clean up.

@josh-padnick This is a pretty trivial change, so I'm going to merge it in.


IndexError if all recipients have keys

The IndexError is thrown in utils.py, line 54
What works for me is changing utils.py, line 75 from
unencrypted = [[addr for addr in addr_to if addr not in key_addresses]]

which may become [[]] to
unencrypted = list(filter(None, [[addr for addr in addr_to if addr not in key_addresses]]))

Fixed long time ago in empty unencrypted list bug fix.


Linux 4.14 and nerves_system_br 1.5.4

Fixes
https://github.com/LeToteTeam/kiosk_system_rpi3/issues/39
https://github.com/LeToteTeam/kiosk_system_rpi3/issues/38


Handle missing getter info

Find getters itself is working fine!
There are two issues that could possibly affect it

buildable references are broken potentially breaking isAssignable() -> findGetter().
buildable constructor detection is also broken. This means that sundrio may pick up the wrong constructor and start looking for fields that are not supposed to have getters.

I think is a safe defensive test if there is nothing to iterate over so...

ok I am blind! Didn't realize this was a PR! LoL


Adjust mobile sides

This PR increases the side padding above 768px for .r-section-wrapper

Cool! I'm looking forward to cleaning up this file, but good to see some ms values making their way in!


Error in running CoSpar on the Lung differentiation dataset

Hi,
This method is very fascinating, and I am trying to reproduce the tutorial results with the Lung differentiation dataset.
I created a new conda environment and installed all the packages on the conda environment.
When I executed these two commands with CoSpar, I got these errors:
>>> cs.tl.fate_coupling(
    adata_orig,
    source="X_clone",
    selected_fates=["iAEC2", "PNEC", "Gut", "NLE", "Endoderm"],
)

normalize by X_clone
each selected cluster has a unique time point. Normalize per time point
/home/bhyu/anaconda3/envs/cospar/lib/python3.9/site-packages/cospar/tool/_utils.py:75: RuntimeWarning: invalid value encountered in double_scalars
  X[j, k] = X[j, k] / (diag_temp[j] * diag_temp[k])
Results saved as dictionary at adata.uns['fate_coupling_X_clone']

>>> cs.pl.fate_coupling(adata_orig, source="X_clone")

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bhyu/anaconda3/envs/cospar/lib/python3.9/site-packages/cospar/plotting/_map.py", line 87, in fate_coupling
    ax = pl_util.heatmap(
  File "/home/bhyu/anaconda3/envs/cospar/lib/python3.9/site-packages/cospar/plotting/_utils.py", line 353, in heatmap
    Z = hierarchy.ward(data_matrix + pseudo_count)
  File "/home/bhyu/anaconda3/envs/cospar/lib/python3.9/site-packages/scipy/cluster/hierarchy.py", line 834, in ward
    return linkage(y, method='ward', metric='euclidean')
  File "/home/bhyu/anaconda3/envs/cospar/lib/python3.9/site-packages/scipy/cluster/hierarchy.py", line 1065, in linkage
    raise ValueError("The condensed distance matrix must contain only "
ValueError: The condensed distance matrix must contain only finite values.

Could you please help me with this issue?
Thank you.
Best,
Bohyeon

Hi, Bohyeon
This erroneous behavior is due to the presence of a cluster ('Endoderm') that has no clones in it. I fixed it by removing any clusters without clones in the coupling calculation. If you git clone the lastest version of CoSpar (with git tag: eb3745e), this problem will be resolved!

Hi, @ShouWenWang
Thank you so much for your immense help!!!
Cospar is working well now.


MAUI iOS devices. RecognizeOnceAsync returns SPXERR_MIC_ERROR starting from the second call.

Describe the bug

First call. Everythink is ok. await speechRecognizer.RecognizeOnceAsync() returns  Reason = RecognizedSpeech and recognized text.
Second and following calls. await speechRecognizer.RecognizeOnceAsync() hangs device for a second and then returns Reason = Cancelled. CancellationDetails = Reason: Error ErrorDetails: 0x15 (SPXERR_MIC_ERROR)

To Reproduce
var speechConfig = SpeechConfig.FromSubscription(_configurations.Value.Key, _configurations.Value.Region);
speechConfig.SpeechRecognitionLanguage = _configurations.Value.Language;

using (var audioConfig = AudioConfig.FromDefaultMicrophoneInput())
{
    using (var speechRecognizer = new SpeechRecognizer(speechConfig, audioConfig))
    {
        var speechRecognitionResult = await speechRecognizer.RecognizeOnceAsync();
        var cancellationDetails = CancellationDetails.FromResult(speechRecognitionResult);
        if (speechRecognitionResult.Reason == ResultReason.RecognizedSpeech)
        {
            return new SpeechSynthesisRecognizeSpeechResultDto
            {
                Status = SpeechSynthesisStatus.Ok,
                Text = speechRecognitionResult.Text,
                Duration = speechRecognitionResult.Duration
            };
        }
        else
        {
            return new SpeechSynthesisRecognizeSpeechResultDto
            {
                Status = SpeechSynthesisStatus.Error,
                ErrorMessage = $"Reason = {speechRecognitionResult.Reason}; CancellationDetails = {cancellationDetails}",
                Duration = speechRecognitionResult.Duration
            };
        }
    }
}

Version of the Cognitive Services Speech SDK

Microsoft.CognitiveServices.Speech nuget 1.32.1

Platform, Operating System, and Programming Language

.NET 7. MAUI. Real iOS devices. Tested on iPhone 12 and iPad 6

Additional context

on Windows and Android is working fine.

Sorry. I found out that the errors happens after I first time call this library https://github.com/jfversluis/Plugin.Maui.Audio.
It seems that the library doesn't release microphone correctly in iOS.
So the bug doesn' related to the cognitive services.
How it happens in my app:

I call  speechRecognizer.RecognizeOnceAsync().  It seems that SpeakTextAsync somehow breaks microphone on iOS:

I call speechRecognizer.RecognizeOnceAsync(). I get Text
Then I call speechSynthesizer.SpeakTextAsync(Text) and save result to byte[]
Then I call speechRecognizer.RecognizeOnceAsync() again and it returns SPXERR_MIC_ERROR

Step 2 code is similar to SynthesisToResultAsync() example from https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/master/samples/csharp/sharedcontent/console/speech_synthesis_samples.cs
var speechConfig = SpeechConfig.FromSubscription(_configurations.Value.Key, _configurations.Value.Region);
speechConfig.SpeechSynthesisVoiceName = _configurations.Value.Voices.FirstOrDefault(x => x.DisplayName == voiceDisplayName)?.Name;

using (var speechSynthesizer = new SpeechSynthesizer(speechConfig, null))
{
    var speechSynthesisResult = await speechSynthesizer.SpeakTextAsync(text);
    if (speechSynthesisResult.Reason == ResultReason.SynthesizingAudioCompleted)
    {
        return new SpeechSynthesisSpeakTextResultDto
        {
            Status = SpeechSynthesisStatus.Ok,
            AudioData = speechSynthesisResult.AudioData
        };
    }
    else
    {
        return new SpeechSynthesisSpeakTextResultDto
        {
            Status = SpeechSynthesisStatus.Error,
            ErrorMessage = $"Reason = {speechSynthesisResult.Reason};"
        };
    }
}

My first guess would be a thread context issue with the audio config object.
using (var audioConfig = AudioConfig.FromDefaultMicrophoneInput())
Is it possible that audioConfig is disposed of by the time the second call to RecognizeOnceAsync() is made?

My first guess would be a thread context issue with the audio config object.
using (var audioConfig = AudioConfig.FromDefaultMicrophoneInput())
Is it possible that audioConfig is disposed of by the time the second call to RecognizeOnceAsync() is made?

No it is not possible. Anyway I can call RecognizeOnceAsync many times in a row and it works fine. But after I make a single call to SpeakTextAsync RecognizeOnceAsync starts to return SPXERR_MIC_ERROR

Finally, I found the source of the issue.
I used this snippet of code https://github.com/jfversluis/Plugin.Maui.Audio/wiki :

How to make the audio play even though the hardware silent/mute switch is toggled?
Add this snippet before you start playing audio in your .NET MAUI app:

#if IOS
    AVFoundation.AVAudioSession.SharedInstance().SetCategory(AVAudioSessionCategory.Playback);
#endif

And it somehow breaks microphone. So it is not related to cognitive speech services from azure team.


cmake.configureSettings should not take effect on the remote computer

Brief Issue Summary
cmake.configureSettings in user settings.json will works on both local and remote. But this config may include path or something else which is related to specific computer.
For example, to use vcpkg, CMAKE_TOOLCHAIN_FILE have to be added into. But it will stop configuration on remote. Thus, we cannot guarantee that the remote has an out-of-the-box environment while guaranteeing the local. Unless the local configuration is overwritten on each remote computer.
Therefore, cmake.configureSettings should not take effect on the remote computer.

We discussed this previously in https://github.com/microsoft/vscode-cmake-tools/pull/2047, but ultimately decided against it for now unless we get a lot of requests to change it.  The reason why we didn't like the solution is because it requires you to reconfigure settings for every remote (e.g. you can't reuse the settings across multiple remotes).  We'll leave this issue open for a while to track community interest.

I just ran into this with cmake.cmakePath.  It seems incorrect to assume that a path on one system will apply to another.  At least for paths, I think #2047 should be revisited.


remove variants with owl:imports included

https://ekgf.github.io/dprod/ has these links

DPROD Ontology --- JSON-LD --- Everything included
DPROD Ontology --- RDF Turtle --- Everything included
DPROD Ontology --- RDF/XML --- Everything included

I thought that's the ontology + shapes. But looking at the start of this file, I see imported ontologies.
Please describe what exactly is included.

Agree: it's not needed. Protege (etc) do the imports anyway.
Changed description.

Alright, will remove it


Docs states that Drawers has props not actually available

Link to the Page
https://www.skeleton.dev/utilities/drawers?tab=properties
Describe the Issue (screenshots encouraged!)
DrawerSettings type contains those props
export interface DrawerSettings {
    open?: boolean;
    /** A unique identifier, useful for setting contents. */
    id?: string;
    /** Pass arbitrary information for your own persona use. */
    meta?: any;
    /** Set the anchor position.
     * @type {'left' | 'top' | 'right' | 'bottom'}
     */
    position?: 'left' | 'top' | 'right' | 'bottom';
    /** Backdrop - Provide classes to set the backdrop background color*/
    bgBackdrop?: string;
    /** Backdrop - Provide classes to set the blur style.*/
    blur?: string;
    /** Drawer - Provide classes to set padding.*/
    padding?: string;
    /** Drawer - Provide classes to set the drawer background color.*/
    bgDrawer?: string;
    /** Drawer - Provide classes to set border color.*/
    border?: string;
    /** Drawer - Provide classes to set border radius.*/
    rounded?: string;
    /** Drawer - Provide classes to set box shadow.*/
    shadow?: string;
    /** Drawer - Provide classes to override the width.*/
    width?: string;
    /** Drawer - Provide classes to override the height.*/
    height?: string;
    /** Define the Svelte transition animation duration.*/
    duration?: number;
    /** Drawer - Enable/Disable opacity transition */
    opacityTransition?: boolean;
    /** Provide arbitrary classes to the backdrop region. */
    regionBackdrop?: string;
    /** Provide arbitrary classes to the drawer region. */
    regionDrawer?: string;
    /** Provide an ID of the element labeling the drawer.*/
    labelledby?: string;
    /** Provide an ID of the element describing the drawer.*/
    describedby?: string;
}

zIndex is not available as stated in the documentation.
I don't know if the error is in the documentation or if it's a bug in the code in the Drawer component.

@centomila the interface you've included here are not related to props. They're programmatic settings passed when triggering a drawer. Two separate things.
Here's an example of prop usage:
<Drawer padding="p-10" />

And here's an example of DrawerSettings:
const drawerSettings: DrawerSettings = {
	// ...
	bgDrawer: 'bg-green-500'
};
drawerStore.open(drawerSettings);

Props are great when you want to set default values for all instances of the Drawer (ex: always have X color background). While DrawerSettings are set per each time a drawer is opened. It's mirroring the same pattern we use for Modals.
I'll go ahead and close this as everything is working as intended. But feel free to respond if I can clarify anything.

Sorry 😔. I saw some properties like bgBackdrop in DrawerSettings and Drawer were the same, and I mistakenly thought that the norm was they needed to always be available in both.
Thanks for your assistance.

No worries, easy mistake to make. That's why we're here to help! :)


Langfuse flow traces lack information about token usage and cost, multiple traces get logged per one flow run

Bug Description
I've stumbled upon a weird behaviour when using Langfuse tracing:
Scenario 1:
I setup connection to Langfuse via dotenv component or by setting the env variables in docker compose. For each flow run, I get a flow trace and additional trace for every generation call I make.
For example this simple flow had two calls to OpenAI and I got 3 traces in total:

I am not sure if those OpenAI-generation traces are even supposed to be there:
Langfuse-Langflow integration docs have link to your video that shows Langfuse integration and the OpenAI-generations are not there, nor are the token counts or cost visible in the traces. However if you scroll a bit there is a picture that shows this trace.
Scenario 2:
I setup connection to Langfuse via dotenv component or by setting the env variables in docker compose. Then I change this connection to different project by setting new secret key and public key.
The flow trace goes to the correct project, but the OpenAI-generation traces still go to the project that was configured first.   The only solution I've found is to restart the container so all the traces go to the correct Langfuse project.
I've managed to kinda reproduce the multiple traces issue it with langfuse sdk - call to LLM gets logged even though its outside of decorated function and invoke call doesn't even have langfuse langchain callback handler set:
import os
from langchain_openai import ChatOpenAI
from langfuse.decorators import langfuse_context, observe

# if we import this, the openai generation will show up in langfuse
# if not there will only be a trace of test function as expected
from langfuse.openai import openai

langfuse_context.configure(
    public_key=os.getenv("LANGFUSE_PUBLIC_KEY"),
    secret_key=os.getenv("LANGFUSE_SECRET_KEY"),
    host=os.getenv("LANGFUSE_HOST"),
    enabled=True,
)

@observe()
def test():
    pass

test()
x = ChatOpenAI(model="gpt-4o")
x.invoke("Hello world")
langfuse_context.flush()

I've checked the codebase and couldn't find this import so its likely caused by something different or its completely unrelated to this.
Couple of questions:
What should I expect to see in Langfuse after running a flow that makes a call to LLM?
Is it discouraged to change Langfuse project once Langflow is already running?
Reproduction

Run Langflow v1.1.1 and connect to Langfuse
Run a flow that contains LLM call
Check Langfuse

Expected behavior
Not sure what the expected behaviour is supposed to be, but it would be nice if there was only one trace with cost/token usage information.
Who can help?
No response
Operating System
Langflow v1.1.1 image & latest Langfuse image
Langflow Version
v1.1.1
Python Version
None
Screenshot
No response
Flow File
No response

Well, i think it would be great to be able to get additional information from components about token usage, actually the information that is given by API


Add accessLogger aspect to mixer.

This PR establishes an access logging aspect (as distinct from the generic logger aspect) for use by Istio. This aspect will be used to generate access logs (think Common Logging Format).
Addresses issue #164.

This change is

Current coverage is 69.45% (diff: 100%)

Merging #172 into master will not change coverage

@@             master       #172   diff @@
==========================================
  Files            32         32
  Lines          1113       1113
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            773        773
  Misses          320        320
  Partials         20         20

Powered by Codecov. Last update bc06a25...2ffb9ce

PTAL.
I've updated aspectlogger.Entry to include a Labels field.
I believe this matches our discussion from this afternoon. This should enable aspect config to control LogFormat AND Label selection (attribute downscoping) without prescribing how the Access Log entries will be encoded by the backend adapters.
Also, as discussed, for now, Labels is map[string]interface{}. We will likely want to move to something like a scoped attribute bag in the near future.

This (and the associated issue) came out of discussion at the stand-up Tuesday. It was felt that having a distinct accessLogger aspect was a key point in the design reviews and is separate (in users' minds) from generic logger.
There is certainly going to be a lot of overlap -- but it is likely we can provide better defaults for accessLogger than we can for generic logger, etc.
Thoughts?

A logger is a logger is a logger.
If we want to provide an explicit stackDriverAccessLogger adapter, that's
all fine and dandy. But I don't see why the interface to this adapter needs
to be different than the interface to other logging adapters.
Let me put this another way: If this case requires a new aspect manager,
than we should stop pretending that we actually have an abstraction layer.
We should just get rid of aspect managers as a whole and put all the logic
directly into the adapters.  A single aspect must be able to
cover multiple distinct adapters.
On Fri, Jan 20, 2017 at 12:33 PM, Douglas Reid<EMAIL_ADDRESS>wrote:

This (and the associated issue) came out of discussion at the stand-up
Tuesday. It was felt that having a distinct accessLogger aspect was a key
point in the design reviews and is separate (in users' minds) from generic
logger.
There is certainly going to be a lot of overlap -- but it is likely we can
provide better defaults for accessLogger than we can for generic logger,
etc.
Thoughts?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/mixer/pull/172#issuecomment-274172885, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHXemWPvxs9L25lwKVLdAg2h5HIYGks5rURoFgaJpZM4LocFL
.

I'm confused a bit by the mapping you are suggesting.  In my head, we have accessLogger and logger aspects.  Then, stdioLogger adapter implements both aspects. It would provide both Log([]logger.Entry) and LogAccess([]accessLogger.Entry).
We could definitely have the logger aspect manager take config that covers both types of logging, but I'm not sure that makes things simpler / easier to understand.
For instance, I don't think we will have access logs described by LogEntryDescriptors (they don't have payloads in the same sense). We could add the format bits to logger config and have it generate TextPayloads and cram the access log into the logger.Entry struct.  Having accessLogger separates the two and might make it simpler to understand the two distinct classes of logs that flow through the system.
Let me finish the accessLogger config proto and add it to this PR and then we can discuss how this would co-exist with logger. Sound OK?

Since aspects are user visible we should operate at a level of abstraction that our users are comfortable with.  AccessLogs and Logs are 2 very different things from an end user perspective.  Logs are free form, and initiated by intentionally thru a log.Info or similar statement.
AccessLogs on the other hand have well known formats. (Apache / common / combined etc)
So I think accesslog as a separate aspect makes sense.

OK. I've added an initial stab at what the aspect configuration would look like for an aspectLogger aspect.
PTAL and let me know how this looks.

@geeknoid should we have a quick chat re: accessLogger aspect. I want to make sure we are all in agreement before moving forward.

Nah, I give up. I don't believe it is desirable or necessary, but I think
we need to move forward a bit for this to become evident to everyone else.
So let's move forward, and then we'll delete it :-)
On Fri, Jan 20, 2017 at 2:33 PM, Douglas Reid<EMAIL_ADDRESS>wrote:

@geeknoid https://github.com/geeknoid should we have a quick chat re:
accessLogger aspect. I want to make sure we are all in agreement before
moving forward.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/mixer/pull/172#issuecomment-274198042, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHYyYTDarThNC9Xs_By_mboKVFZWCks5rUTZRgaJpZM4LocFL
.

Once we have the expression language in place, there could be convergence here.
Until then go template, as painful as it is to use, is easy to implement.


[mempool remove txns for broadcast ACKs in full nodes

Summary
With this PR, full nodes clean out txns for ACKed broadcasts
To handle ACKs from multiple upstream peers that may cause collisions in the transactions cleaned out, range functionality has been added to core_mempool
Test Plan
Added new shared mempool tests testing broadcast ACK-triggered cleaning out of mempool

@bors-libra: r+

:pushpin: Commit d244415 has been approved by phoenix-antigravity

:hourglass: Testing commit d2444159832e98afa7e71025428ae5ad226b5d77 with merge 599ec5fe51bd4ebcd8990d753dfda2c38f8b4ccb...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: phoenix-antigravity
Pushing 599ec5fe51bd4ebcd8990d753dfda2c38f8b4ccb to master...


F: Database Query of Connector Status

It would be great to have a column displaying the status of the connector at the database level.  Specifically, in Postgres, the connector's status in the pg_replication_slots function.
Consideration:
MSSQL vs MongoDB vs PostgresDB in the same environment.

Shelving this feature since we now run PGAdmin as a website.


engine: fix raft-engine encryption key deletion order

What is changed and how it works?
Issue Number: Close #14761
What's Changed:
Fix a race between encryption key and raft log file deletion that can cause server unable to boot.

Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test

Release note
Fix a race between encryption key and raft log file deletion that can cause server unable to boot.

/merge


MS lesions masks outside the SC mask

Description
139 subjects of the 180 MS subjects in the basel-mp2rage database have lesion segmentation pixels (lesion-manualNeuroPoly mask) that are outside the SC segmentation
Here an example:
sub-P121

List of subjects with this issue: sub-P001, sub-P003, sub-P004, sub-P005, sub-P006, sub-P007, sub-P010, sub-P011, sub-P012, sub-P013, sub-P014, sub-P016, sub-P019, sub-P021, sub-P022, sub-P023, sub-P024, sub-P025, sub-P026, sub-P027, sub-P028, sub-P030, sub-P031, sub-P033, sub-P034, sub-P035, sub-P036, sub-P037, sub-P038, sub-P039, sub-P040, sub-P041, sub-P042, sub-P044, sub-P045, sub-P047, sub-P050, sub-P051, sub-P053, sub-P055, sub-P056, sub-P057, sub-P058, sub-P059, sub-P061, sub-P062, sub-P063, sub-P065, sub-P066, sub-P067, sub-P068, sub-P069, sub-P070, sub-P071, sub-P072, sub-P075, sub-P078, sub-P079, sub-P082, sub-P084, sub-P085, sub-P086, sub-P087, sub-P088, sub-P094, sub-P095, sub-P096, sub-P097, sub-P098, sub-P099, sub-P100, sub-P101, sub-P103, sub-P104, sub-P106, sub-P108, sub-P109, sub-P110, sub-P111, sub-P112, sub-P114, sub-P116, sub-P117, sub-P119, sub-P120, sub-P121, sub-P122, sub-P124, sub-P125, sub-P129, sub-P130, sub-P132, sub-P134, sub-P138, sub-P139, sub-P141, sub-P142, sub-P144, sub-P145, sub-P146, sub-P148, sub-P149, sub-P151, sub-P153, sub-P156, sub-P157, sub-P160, sub-P161, sub-P165, sub-P167, sub-P169, sub-P170, sub-P173, sub-P174, sub-P175, sub-P176, sub-P178, sub-P179, sub-P180, sub-P181, sub-P182, sub-P183, sub-P185, sub-P187, sub-P188, sub-P190, sub-P191, sub-P192, sub-P194, sub-P197, sub-P199, sub-P200, sub-P241, sub-P242, sub-P243, sub-P244, sub-P246, sub-P249, sub-P250
Maybe we should redefine the SC masks by making a union of the MS lesions and current SC masks

@Nilser3 this issue refers to the data, not to the model-- can you please move this issue to https://github.com/neuropoly/data-management/issues and I will then comment there-- thanks!

This issue is closed, and a new one is opened in the correct repo
(the issue could not be transferred because they are different organizations ivadomed/model_seg_ms_mp2rage    and neurpoly/data-managemment )


[Feature] Implement ability to prefill for all languages/operating systems/architectures

Implement multi language support in InstallFileHandler.HandleInstallFileAsync() and DownloadFileHandler.DetermineTagsToUse()

Closing this as in the 9 months this has been released, there have been no requests to prefill non-english languages.


Compilation Problem

Hi,
Thanks a lot for sharing the codes for the constant Fermi-level method implemented within VASP.
I tried to modified the VASP code and compiled (vasp.5.4.4 + VASPSOL) that but met with the following error message:
pot.F(63): error #6401: The attributes of this name conflict with those made accessible by a USE statement.   [COMM_INTER]
      TYPE (communic)    COMM_INTER
-------------------------^
pot.F(403): error #6405: The same named entity from different modules and/or program units cannot be referenced.   [COMM_INTER]
         CALL M_bcast_d(COMM_INTER, SV(1,ISP), GRID%RL%NP)
------------------------^

I used the mpi/intel-2019 and intel-suite/2019.4 for compiling. Could you please help with this problem?
Best Regards

It does not look like that this error relates to VASPSol or TPOT at all. Are you able to compile without VASPSol and TPOT?
I have used many versions of intel compilers and also with gnu compiler without a similar problem,

It does not look like that this error relates to VASPSol or TPOT at all. Are you able to compile without VASPSol and TPOT? I have used many versions of intel compilers and also with gnu compiler without a similar problem,

Hi,
Thanks a lot for your reply.
I have successfully compiled VASP with VASPsol with the version without TPOT (and without modification of the VASP code). I found the aforementioned error after modifying the pot.F file following the guide.

Please send me an email. I was not able to reproduce the issue.

Resolved #acc009e


Handle leader leaving during election procedure

Borrowing ideas from #284. We check whether the elected leader is still present in the current view. If the leader has left, the voting thread continues running, collecting proposals from the new view.
The first commit includes a test for the case the leader left before the coordinator applied the result locally. The test reproduces the issue described in #280.
The third commit contains a check when handling the LeaderElected message. The node verifies if the leader is present in the current view.

Multi-threads problems are very hard to explain, please see my comment, I don't know if it is clear.
protected void runVotingProcess() {
        if (!isMajorityAvailable()) { // TODO access volatile view separately
            if (log.isDebugEnabled())
                log.debug("%s: majority (%d) not available anymore (%s), stopping thread", local_addr, raft.majority(), view);

            // TODO if reach majority at this point, and startVotingThread won't start because it's running.

            stopVotingThread();
            return;
        }

        View electionView = this.view;
        long new_term=raft.createNewTerm();
        votes.reset(electionView.getMembersRaw());
        num_voting_rounds++;
        long start=System.currentTimeMillis();
        sendVoteRequest(new_term);

        votes.waitForAllResponses(vote_timeout);
        long time=System.currentTimeMillis()-start;

        int majority=raft.majority();
        if(votes.numberOfValidResponses() >= majority) {

            // TODO At this point this.view could be any thing even a single node view, the elected leader could be unqualified(Don't have the longest log for example)
            Address leader=determineLeader(); // TODO access volatile view separately

            log.trace("%s: collected votes from %s in %d ms (majority=%d) -> leader is %s (new_term=%d)",
                    local_addr, votes.getResults(), time, majority, leader, new_term);

            raft.setLeaderAndTerm(leader, new_term);
            sendLeaderElectedMessage(leader, new_term);

            synchronized (this) {
                if (isLeaderInView(leader, view)) // TODO without checking the majority if reached
                    stopVotingThread();
                else if (log.isTraceEnabled())
                    log.trace("%s: leader (%s) not in view anymore, retrying", local_addr, leader);
            }
        }
        else
            log.trace("%s: collected votes from %s in %d ms (majority=%d); starting another voting round",
                    local_addr, votes.getValidResults(), time, majority);
    }

    protected void handleView(View v) {
        // TODO get the leader before assign the new view for the potential running voting thread
        // TODO assume there is running voting thread got the elected leader (not in the new view) and haven't applied it to raft yet
        Majority result=Utils.computeMajority(view, v, raft().majority(), raft.leader());

        log.debug("%s: existing view: %s, new view: %s, result: %s", local_addr, this.view, v, result);
        List<Address> joiners=View.newMembers(this.view, v);
        boolean has_new_members=joiners != null && !joiners.isEmpty();
        boolean coordinatorChanged = Utils.viewCoordinatorChanged(this.view, v);

        // TODO before assign the new view, voting thread didn't detect the leader has left, in the meantime the result of computeMajority is "no_change"
        this.view=v;

        switch(result) {
            case no_change:
                // the leader resends its term/address for new members to set the term/leader.
                if(raft.isLeader() && has_new_members)
                    sendLeaderElectedMessage(raft.leader(), raft.currentTerm());

                // Handle cases where the previous coordinator left *before* a leader was elected.
                // See: https://github.com/jgroups-extras/jgroups-raft/issues/259
                else if (coordinatorChanged && isViewCoordinator() && isMajorityAvailable() && raft.leader() == null)
                    startVotingThread();
                break;
            case reached:
            case leader_lost:
                // In case the leader is lost, we stop everything *before* starting again.
                // This avoids cases where the leader is lost before the voting mechanism has stopped.
                // See: https://github.com/jgroups-extras/jgroups-raft/issues/259
                if(isViewCoordinator()) {
                    log.trace("%s: starting voting process (reason: %s, view: %s)", local_addr, result, view);
                    startVotingThread();
                }
                break;
            case lost:
                stopVotingThread(); // TODO unstable
                raft.setLeaderAndTerm(null);
                break;
        }
    }

About unset the leader under lost majority case, please check my comments:
https://github.com/jgroups-extras/jgroups-raft/issues/280#issuecomment-2177641988
and
https://github.com/jgroups-extras/jgroups-raft/pull/284#issuecomment-2180004605

@yfei-z, amazing work! I'll try to get some tests for the comments this weekend. If the work becomes "patching holes", I believe we're better off serializing the handling of view updates. But I have a few ideas I want to try once the tests are in place.

I think my pull request has resolved them all

I've pushed with some more tests and covered the comments.

Instead of checking for the majority at the beginning of the voting thread, we let the concrete implementation handle it, and check if the thread is interrupted to exit earlier;
After determining the leader from the collected votes, we acquire the intrinsic lock (other threads can not start/stop the voting thread). Holding the lock, we check if the view still has a majority (if not stop, and set leader null) and if the leader is still in view (if so, stop the voting thread). Otherwise, the voting thread keeps running, until the leader is elected or the thread is interrupted.
Check the view before accepting the LeaderElected message.

In point 1, I added that check thinking it would be a safeguard, but it brought more difficulty. We could even remove the interrupt check.
In point 2, as long as we have the majority, we'll elect a qualified leader. The majority guarantees there is an overlap with committed entries.
Let me know what you think. After this is done, we can look into the other issue with LevelDB.

@jabolina
    protected void runVotingProcess() {
        if (Thread.interrupted()) return; // TODO Right after the running status has be checked, not so useful.

        View electionView = this.view;

        // TODO No majority check, may initiate an unnecessary invalid voting round

        long new_term=raft.createNewTerm();
        votes.reset(electionView.getMembersRaw());
        num_voting_rounds++;
        long start=System.currentTimeMillis();
        sendVoteRequest(new_term);

        votes.waitForAllResponses(vote_timeout); // TODO It can't be interrupted before timeout. votes.reset() could end the waiting but can't ensure the thread is terminated.
        long time=System.currentTimeMillis()-start;

        int majority=raft.majority();
        if(votes.numberOfValidResponses() >= majority) {
            Address leader=determineLeader(); // TODO Access view separately, may choose an unqualified leader
            log.trace("%s: collected votes from %s in %d ms (majority=%d) -> leader is %s (new_term=%d)",
                    local_addr, votes.getResults(), time, majority, leader, new_term);

            raft.setLeaderAndTerm(leader, new_term);
            sendLeaderElectedMessage(leader, new_term); // send to all - self

            synchronized (this) {
                if (!isMajorityAvailable()) {
                    log.trace("%s: majority lost (%s) before elected (%s)", local_addr, view, leader);
                    stopVotingThread(); // TODO Self stop and join, always wait until timeout.
                    raft.setLeaderAndTerm(null);
                    return;
                }

                if (isLeaderInView(leader, view)) {
                    stopVotingThread();
                    return;
                }

                if (log.isTraceEnabled())
                    log.trace("%s: leader (%s) not in view anymore, retrying", local_addr, leader);
            }
        } else if (log.isTraceEnabled())
            log.trace("%s: collected votes from %s in %d ms (majority=%d); starting another voting round",
                    local_addr, votes.getValidResults(), time, majority);
    }

    protected void handleView(View v) {
        View previousView = this.view;
        this.view = v;
        Majority result=Utils.computeMajority(previousView, v, raft().majority(), raft.leader());
        log.debug("%s: existing view: %s, new view: %s, result: %s", local_addr, previousView, v, result);
        List<Address> joiners=View.newMembers(previousView, v);
        boolean has_new_members=joiners != null && !joiners.isEmpty();
        boolean coordinatorChanged = Utils.viewCoordinatorChanged(previousView, v);
        switch(result) {
            case no_change:
                if(raft.isLeader() && has_new_members)
                    sendLeaderElectedMessage(raft.leader(), raft.currentTerm());

                else if (coordinatorChanged && isViewCoordinator() && isMajorityAvailable() && raft.leader() == null)
                    startVotingThread();
                break;
            case reached:
            case leader_lost:
                if(isViewCoordinator()) {
                    log.trace("%s: starting voting process (reason: %s, view: %s)", local_addr, result, view);
                    startVotingThread();
                }
                break;
            case lost:
                // TODO The VIEW message will be sent after this in coordinator, and the VIEW message will trigger the
                // TODO view change event and come to here again in participants to unset the leader.
                // TODO Assuming the stopVotingThread is timeout, then the VIEW message is sent, and the running voting thread
                // TODO send the leader after the VIEW message, the participant will unset the leader first then set the
                // TODO leader then
                stopVotingThread(); // TODO Need to make sure it is stopped (leader message won't be sent after this)
                raft.setLeaderAndTerm(null);
                break;
        }
    }

Sorry for the delay, I was a bit sidetracked. I've pushed one last change with some tests. This should be handling all of the problems above.

The Thread.interrupted() test is just a best-effort optimization to identify when the thread is interrupted somewhere. In safety terms, there are no problems in case of unnecessary terms and the coordinator (or followers) have a higher term. Participants might be completely unaware of terms in the cluster.
The BaseElection#determineLeader method utilizing the class view instead of the election view also causes no problem. As long the coordinator receives a majority of responses, it should not be possible to elect an unqualified leader violating the election restriction. If the cluster loses the majority of members, we verify it while holding the intrinsic lock. We stop the thread and clear everything if we lose the majority, and the thread continues running if only the leader has left.
The LeaderElected message should be handled. We utilize the view to verify if the installation is permitted. If the node accepts the message before a new view, it should be OK due to the handleView method. If a new view is installed, and later the node receives the message, we verify if the leader is still in the view with a majority in place. This should avoid installing the leader of a previous term later in time.

This should be handling all the issues mentioned.

Verifying the view and leader when participant nodes received the LeaderElected message seems resolved all problems, participant nodes could handle the election result correctly no matter LeaderElected and VIEW message who arrive first.
At first I was a little concerned that the verification in handleLeaderElected was not atomic, it could goes wrong if VIEW message and LeaderElected message are processed concurrently when the TP.message_processing_policy is "submit", but seems NAKACK2 could detect the existing processing thread and make sure those messages will be processed serially.


Transient Attributes Dataset link not working

Hey there,
I am studying your repo, I just cross that link here for Transient Attributes Dataset not working.
"Download Transient Attributes Dataset here."

Please refer to this link: http://transattr.cs.brown.edu/

Please refer to this link: http://transattr.cs.brown.edu/


Feature/info request and response

Now, we have InfoRequest and InfoResponse that will handle the response and request logic of /info
Usage:
info = InfoRequest.new
reponse = info.get  #=> will return InfoResponse object

This PR also adds in vcr capabilities.
Note that we will have to address error handling.

Went through the tests, looks pretty good so far! At least not conflicts! Let's see what we can do within the next few days. I will try to push out some changes on Friday, I have an exam coming up on Thursday so it might take a bit.


feat(GRO-664): styles one trust cookie consent banner

Draft for a bit until we resolve a few questions; but basically: this does allow us to style the banner using our themed values.
I left a comment on the actual code but yeah, this thing would be funny if it wasn't so sad.
Since we're outside of react we don't actually have access to the 'current theme' so we have to pull values out of the static theme object. Not a huge deal.
The main question I have is: do we merge this or do we just use this to 'develop' the style sheet then extract that and paste it into the CSS override in OneTrust's web interface. The main reason I ask this is that this seems like a big ugly chunk of CSS to load when it won't apply most of the time.
https://user-images.githubusercontent.com/112297/146075365-fad6ebd5-f434-43db-9101-35ca194fac46.mov

Now with modal:
I left the toggle switches alone, which are pretty ugly, but probably more trouble than they are worth.
https://user-images.githubusercontent.com/112297/146452184-ecca3655-6af9-49c0-a6f3-916eba8d30d5.mov

So once you accept they add a cookie OptanonConsent which contains some things like a timestamp and a consentId.
I suspect reverse engineering this to conditionally include the styles would be error-prone/brittle.
I'm kind of thinking we just merge this for now and maybe come back to it to extract the styles once it's launched and 'settled'.

merge this for now

yeah seems legit 👍

Woops didn't realize this was failing

Very odd, this is causing the specs to time out. Maybe if I add a global mock.

I... did not merge this. Not sure what happened.


Unable to resolve module electric-sql/react

Hey, I'm trying to get this to work on my react-native app: 0.72.7.
But I'm keep getting this error while running the app. Any ideas on how to fix it?
I've tried re-installing node_modules already.
error: Error: Unable to resolve module electric-sql/react from
Template/src/sql/ElectricProvider.tsx: electric-sql/react could not be found within the project or in these directories:
  node_modules
   7 |
   8 | import { electrify } from 'electric-sql/op-sqlite';
>  9 | import { makeElectricContext } from 'electric-sql/react';
     |                                      ^
  10 |
  11 | const { ElectricProvider, useElectric } = makeElectricContext<Electric>();

We have a react-native example you can look at to compare integrations.
I suspect that your issue is that your bundler does not support package exports that the Electric npm package uses.
If you're using the Metro bundler, you can enable an experimental feature for resolving package exports, see here for an example on how to do this.
The alternative is to configure the Metro resolver to point to the correct directory when resolving electric-sql/react.
See this past issue which might be relevant to what you're experiencing https://github.com/electric-sql/electric/issues/981

We have a react-native example you can look at to compare integrations.
I suspect that your issue is that your bundler does not support package exports that the Electric npm package uses.
If you're using the Metro bundler, you can enable an experimental feature for resolving package exports, see here for an example on how to do this.
The alternative is to configure the Metro resolver to point to the correct directory when resolving electric-sql/react.
See this past issue which might be relevant to what you're experiencing #981

Thanks buddy, this) together with pod install fixed my problem.


use year instead of license per year

the year was saved as a "license"

Thank you for catching this!
Could you please run dune build @fmt --auto-promote to fix the formatting and make the CI happy?

Done :)
Also, can I ask for a bit more on the graphql example?
Maybe how we branch/merge?
I'm trying irmin out because we want to use it in our company project, and I'm not that familiar with OCaml so it's a slow process for me to figure it out.
Thank you.

Thank you :+1:
Did you have a look at this blog post? It contains more examples (including branches and merges) that might help you.

GraphQL's Int values are signed 32 bits integers, so you would need to keep year as an int32 to comply to that.
Was there a specific reason for changing it?

GraphQL's Int values are signed 32 bits integers, so you would need to keep year as an int32 to comply to that.
Was there a specific reason for changing it?

I just couldn't make it compile otherwise. Like I said, I have very little understanding of ocaml.
I'll add a commit and see if it's correct.

Thank you +1
Did you have a look at this blog post? It contains more examples (including branches and merges) that might help you.

Will take a look now.
Thank you!

Thank you +1
Did you have a look at this blog post? It contains more examples (including branches and merges) that might help you.

Will take a look now.
Thank you!

I think that guide is outdated, or my copy of irmin has a problem, because I cannot reproduce the first query the guide shows :(

/cc @andreas who wrote the blog post

CI looks happy – modulo an existing issue with configuration – so merging; thanks for the fix!


Make setting the Content-Type header optional

Hello!
Any chance that setting the Content-Type header could be made optional? It would probably be enough if the ResponseTemplate::set_body_raw function would accept and be able to deal with an Option<&str>, although that's a breaking change...
Most HTTP servers do set the content type header these days but at the same time there's nothing really preventing them from omitting it. It'd be good to have a way of testing what the HTTP client does in such cirumstances.

Okay looked into implementing this, turns out it's far from being simple. The http-types crate is too smart and doesn't allow an empty Content-Type in its Response at all.
Might be able to configure the MockServer itself to strip certain headers before the response is returned 😃.

Yeah, http-types makes a lot of things "correct by construction" which is great for the general case but less so when you want to test a degenerate scenario 😛
We could add a method to remove a header on ResponseTemplate if that makes it viable.

I don't think changes in ResponseTemplate will have any effect. It produces a http_types::Response. Tried removing the Content-Type header on that response object in the ResponseTemplate::generate_response function and it still falls back to application/octet-stream 😃. Might have missed something though...
At one point, in mock_server/hyper.rs, headers are converted into hyper compatible headers so could do something "smart" there. Seems quite hacky though.

That is borderline too hacky I'd say - maybe open an issue on http_types to see if they know of a way to make it happen by manipulating the response?

Haha, thought it might be 😄.
These are some very niche tests that we have so it looks like the simplest solution will be to just use a separate mocking library for those. Closing this for now, but will check http-types again.


COBOL Working Group Annual Review- 08/24

Please share any additional details on this topic
COBOL Working Group Annual Review
Detail what actions or feedback you would like from the TAC
COBOL Working Group Annual Review
How much time do you need for this topic?
None

Renewed via tac vote 8/24


Typo in challenge description Redux_11.js

Just fixing a typo :)

@MrDulka looks great — thanks for finding this!


Fix documentation building through setup.py to build rst first

Currently, build_sphinx is used, but this doesn't actually do what we want. Ideally, what we would like to have is the rst built first before html. Instead, it appears to just build the html without the rsts. This likely will require a custom build step.

This might be possible by checking for the build_sphinx argument and building the rst through sphinx-apidoc like what is done with bdist_conda.


Leaflet errs while fitting bounds and stops loading

Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.
leaflet.js:5 Uncaught Error: Bounds are not valid.
    at e.fitBounds (leaflet.js:5:29198)
    at index.js:48:9
fitBounds @ leaflet.js:5
(anonymous) @ index.js:48
DevTools failed to load source map: Could not load content for https://ironmaps.github.io/mapinurl/scripts/leaflet.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

@funnelferry came across this, trying to reproduce.

Fixed with https://github.com/ironmaps/mapinurl/commit/64a69f2df5b00125d27ee476a497990a1b428e83


Develop

Well done!
Bonus points for the clean and dynamic UI, logging, and organized file management.
120/100


Website search function is broken

This is a...

[ ] Feature Request
[ x] Bug Report

Problem:
The website search function does not return results. When I search for "Pod" the following happens:

Proposed Solution:
Fix the search function to find and/or display results
Page to Update:
http://kubernetes.io/docs/search

@guineveresaenger 👋 Thanks for opening this. We're aware of it and looking for what went wrong.

Fixed, this was caused by a bad PR on my part. I reverted it, search should be working again.

Still broken :(

@Bregor Function looks normal to me. Refresh and try again?

Can confirm that it works for me. Thank you!

Yep, works now.
Sorry for buzzing


stage1: flavor=src: fix git clone directory

When compiling the src flavor, systemd will be cloned from the URL given
in $RKT_STAGE1_SYSTEMD_SRC. The Makefile assumed that
$RKT_STAGE1_SYSTEMD_SRC ends with "systemd" but that might not be the
case. Fix the Makefile.

LGTM.


Is the app starting? The app is bouncing strangely in the dock...

Have a look:
(animated GIF)

Closing as duplicated of #49


Course Final changes

This is the issue which tracks the last minute changes after merging of #100.
Please add all needed changes to this issue so we can finalize on Friday, September 6, around 14-16 UTC.

I think we are good to close this out with the release and finalization of the schedule 👍

Great idea 😄  I am so excited to see everyone!!


docker start fails after a crash

After finding a docker container down, trying to start it always results in this error. At this point, I have to export the image to a tar, modify the startup script to remove the code that does this check and manually start the memsqld process.
*** Running /etc/my_init.d/00_regen_ssh_host_keys.sh...
*** Running /etc/my_init.d/executor...
2016-10-10 17:03:01,276 [INFO] kazoo.client: Connecting to zookeeper:2181
2016-10-10 17:03:01,284 [INFO] kazoo.client: Zookeeper connection established, state: CONNECTED
2016-10-10 17:03:01,309 [INFO] main: Starting MemSQL Executor
2016-10-10 17:03:01,325 [INFO] memsql_framework.executor.main: Downloading MemSQL Ops
2016-10-10 17:03:02,020 [INFO] memsql_framework.executor.main: Unpacking MemSQL Ops
2016-10-10 17:03:02,494 [INFO] memsql_framework.executor.main: Installing and starting MemSQL Ops
2016-10-10 17:03:03,071 [ERROR] main: Fail
Traceback (most recent call last):
File "/memsql_framework/bin/executor", line 33, in
driver.start()
File "/memsql_framework/memsql_framework/executor/main.py", line 56, in start
run([ "/tmp/memsql_ops/install.sh", "--host", self.agent_host, "--port", self.agent_port, "--no-cluster" ])
File "/memsql_framework/memsql_framework/executor/main.py", line 26, in run
raise Exception("Command failed\n%s\n%s" % (stdout, stderr))
Exception: Command failed
Installing MemSQL Ops in /var/lib/memsql-ops
/var/lib/memsql-ops already exists and is nonempty
Starting Executor
*** /etc/my_init.d/executor failed with status 1
*** Killing all processes...

its unclear to me from the docs how mesos requests docker volumes - its possible that it is retrieving an old volume which was used by a previous task and so the directory already exists.
can you verify if that is the case?


Add Github Actions build workflow

Adds a Github Actions build workflow that automates making debug and release builds for all platforms. The workflow is taken from the official https://github.com/godotengine/godot-cpp-template repository.

Wow, this is very cool. I didn't know you could do this. I'll have a look over this at the weekend and hopefully get it merged. Thanks.


Warning in log after update to HA 2023.2

Detected integration that called async_setup_platforms instead of awaiting async_forward_entry_setups; this will fail in version 2023.3. Please report issue to the custom integration author for bodymiscale using this method at custom_components/bodymiscale/__init__.py, line 105: hass.config_entries.async_setup_platforms(entry, PLATFORMS)

The update is ready. I'll post it tonight.
Simple update https://developers.home-assistant.io/blog/2022/07/08/config_entry_forwards/

update available


Remind to call "done()" on test timeouts

I understand the reason the done() callback is required, but I've tripped myself up multiple times forgetting to add it to the end of a test. In each case, I assumed it was an issue with my code, not the test itself.
It would be nice if the test timeout error message had some kind of reminder to make sure done() was somewhere in the test.

And this should also be stressed in the documentation as well!

I see. Would a reminder message in the error be good enough, or would you suggest scanning the code for the use of the callback?

I think a reminder is easier to implement immediately. Digging through the stack to ensure a callback would be more foolproof, but would it catch every case?

Digging through the stack? But the problem is detecting if the code has any line that executes the callback, right?
On Feb 1, 2015 10:21 PM, Soviut<EMAIL_ADDRESS>wrote:I think a reminder is easier to implement immediately. Digging through the stack to ensure a callback would be more foolproof, but would it catch every case?
—Reply to this email directly or view it on GitHub.

Yes, verifying that a callback exists somewhere in each test. To be honest, I was guessing about "checking the stack" since I didn't think it would be done via actual source.

I think there is no other way to discern between an actual timeout vs forgetting to execute the callback if you don't scan the code.

We can easily get the file and line number in which the test's function was declared.

It might be even easier to just use function.toString() to get the function code for each test and scan it for the callback.

I feel so fool about missing that since it's one of the functions I checked today...
This will be a cool and useful addition, I'll add the labels. Let us know if anyone cares to prepare a PR!

In the mean time, perhaps just updating the timeout messaged would be a good stopgap measure. A reminder like "Timeout 2000ms. Is the done() callback being called?" or "Ensure the done() callback is called in your test".

I will do so asap.

I could do a PR.

PR ready to go https://github.com/mochajs/mocha/pull/1523

Merged, lacking the actual check.

Yeah, that PR satisfies this current issue. I'll create another issue about checking for the done() method within tests.