Collection install from git does not install correct version

Issue Type

Bug report

Molecule and Ansible details
ansible 2.10.6
  config file = /home/segu/.ansible.cfg
  configured module search path = ['/root/dev/openshift-ansible/roles/lib_openshift/library', '/root/dev/openshift-ansible/roles/openshift_facts/library', '/root/dev/openshift-ansible/roles/lib_utils/library']
  ansible python module location = /home/segu/.local/lib/python3.8/site-packages/ansible
  executable location = /home/segu/.local/bin/ansible
  python version = 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0]
molecule 3.2.4 using python 3.8
    ansible:2.10.6
    delegated:3.2.4 from molecule
    docker:0.2.4 from molecule_docker

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
I expect that the latest version of a collection defined in a requirements.yml is installed:
---
collections:
  - name: git+https://github.com/ansible-collections/community.mysql.git
    type: git
    version: main

Actual Behaviour
The latest tagged release (v1.3.0 in this case) gets installed:
COMMAND: ansible-galaxy collection install --collections-path /home/segu/.cache/molecule/hardening/mysql_hardening/collections --force --requirements-file molecule/mysql_hardening/requirementss.yml -vvv         ansible-galaxy 2.10.6                                                                                config file = /home/segu/.ansible.cfg                                                                                configured module search path = ['/root/dev/openshift-ansible/roles/lib_openshift/library', '/root/dev/openshift-ansible/roles/openshift_facts/library', '/root/dev/openshift-ansible/roles/lib_utils/library']    ansible python module location = /home/segu/.local/lib/python3.8/site-packages/ansible                                                                                executable location = /home/segu/.local/bin/ansible-galaxy                                                                                python version = 3.8.5 (default, Jan 27 2021, 15:41:15) [GCC 9.3.0]                                                                                Using /home/segu/.ansible.cfg as config file                                                                                Reading requirement file at '/home/segu/dev/collections/ansible_collections/devsec/hardening/molecule/mysql_hardening/requirementss.yml'                                                                           Starting galaxy collection install process
Process install dependency map
Processing requirement collection 'git+https://github.com/ansible-collections/community.mysql.git'                                                                                archiving ['/usr/bin/git', 'archive', '--prefix=community.mysql/', '--output=/home/segu/.ansible/tmp/ansible-local-207360lf2ruqn/tmp3vav2sbp.tar', 'main']
Skipping '/home/segu/.ansible/tmp/ansible-local-207360lf2ruqn/tmpjiulymjr/community.mysql/galaxy.yml' for collection build
Starting collection install process
Installing 'community.mysql:1.3.0' to '/home/segu/.cache/molecule/hardening/mysql_hardening/collections/ansible_collections/community/mysql'
Skipping '/home/segu/.ansible/tmp/ansible-local-207360lf2ruqn/tmpjiulymjr/community.mysql/galaxy.yml' for collection build
Created collection for community.mysql at /home/segu/.cache/molecule/hardening/mysql_hardening/collections/ansible_collections/community/mysql
community.mysql (1.3.0) was installed successfully

Hi @rndmh3ro. Are you sure things do not work? Because looking at the command output, it seems that Ansible did install the collection from git. But because the galaxy.yml file in community.mysql still contains version 1.3.0, this version is reported when installing it.

I just checked and you're right, the correct version gets installed.
The first time I tried this I had an error from which I concluded that 1.3.0 instead of latest was installed. However I just re-checked and this was a problem on my side (forgot to add the requirements-file config into molecule).


gRPC probes with the different security configurations of the endpoints

This is a Feature Request
Starting 1.23, gRPC probes are built-in to k8s. https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-grpc-liveness-probe
It will be great to expand documentation explaining which secure endpoint settings will be respected and which wouldn't. Built-in gRPC probe will ignore certificate for TLS, but will likely not work with mutual TLS.
Need to work thru various configurations of endpoint setting and list whether it is supported by the built-in gRPC probe.
/sig node
KEP: https://github.com/kubernetes/enhancements/issues/2727
/help

also can publish recommendation on testing gRPC endpoints by exposing plaintext endpoint and using TCP check. Like here: https://cloud.google.com/traffic-director/docs/security-proxyless-setup#create-health-check

/assign

/remove-lifecycle stale

/remove-lifecycle rotten
/reopen

Not yet triaged as accepted
/remove-help


Fix typo.

Thanks! Looks like this PR got behind so I manually applied the change.

This issue was moved to gmailgem/gmail#111


Settings sync in github.dev has no base

using safari
visit github.dev
settings sync has a conflict
conflict indicated that there is now base

I am seeing the very consistently over the last days, almost every day/time I use github.dev

/duplicate
Closing this in favour of https://github.com/microsoft/vscode/issues/159037. Both are same


Lost xlm when transferred to coinbase

Not sure what happens but my funds are missing. I did not see a place to add a memo address and sent a small amount $25 to coinbase from the ledger and the funds never made it. Please help I really just want to exit my entire XLM position. Help help

It’s been 2 days now...

It’s been 2 days now...

Please check #278

Please check #278


More refactoring make module

This continues refactoring the ModuleObj by allowing true OOP by doing module.addTorquetube() and module.addCellModule().
TODO:

[x] Get all tests passing
[x] Update notebooks
[x] Whatsnew

@shirubana  - I think this one is ready to get merged.  I've double checked all notebooks, pytests and checked for backward compatiblity from previous scripts.


Add 2021 Virtual Talks section in Subspace group page

A new folder in /img was added to save there the images from the subspace group.

Approving update to BSIsubspace page.


Pasting SQL changes language mode to Powershell

Issue Type: Bug
Pretty regularly when I copy valid SQL from one tab and paste it into another tab, the new tab has its language mode automatically changed to Powershell. This is incredibly annoying because if I try to change the language mode back to SQL I get a message telling me that I cannot change the language mode on an unsaved script.
Azure Data Studio version: azuredatastudio 1.35.0 (e9c8eb8564f537726b36b5f15c7f35e62f229284, 2022-02-23T17:36:02.883Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.92GB (3.90GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

@lambertaa-churchaccount  could you please share the query that can reproduce the issue? also were you coping query to a query editor (within it there is a toolbar with these actions: run query, connect )?

I cannot as it contains sensitive information, but I have this happen about once a week. I was copying from one tab to another. Both tabs were query editors.
From: Alan Ren @.>
Sent: Wednesday, March 23, 2022 10:46 AM
To: microsoft/azuredatastudio @.>
Cc: Aaron Lambert @.>; Mention @.>
Subject: Re: [microsoft/azuredatastudio] Pasting SQL changes language mode to Powershell (Issue #18800)
@lambertaa-churchaccounthttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flambertaa-churchaccount&data=04|01|lambertaa%40churchofjesuschrist.org|fe912ba7797c4807ce3008da0cec927e|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637836507477178856|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=wPT7UToRiGnkAYp8GMvMmUP3MALyyNwiYkYZz3WQlVg%3D&reserved=0 could you please share the query that can reproduce the issue? also were you coping query to a query editor (within it there is a toolbar with these actions: run query, connect )?

Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazuredatastudio%2Fissues%2F18800%23issuecomment-1076559531&data=04|01|lambertaa%40churchofjesuschrist.org|fe912ba7797c4807ce3008da0cec927e|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637836507477178856|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=E6TmFljY7BVX5tII9FN%2FrZMDq0RhTrNuvssnDWEpvgc%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXQKHYMIWRMCY26Z4WZGS6TVBNDDPANCNFSM5RMHYM7Q&data=04|01|lambertaa%40churchofjesuschrist.org|fe912ba7797c4807ce3008da0cec927e|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637836507477178856|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=BpL431hKetyvF84LJf0SeD8fiFK9ZZ1QrDLmqoaAzOQ%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

This one just happened to me and does not include sensitive information. I pasted the following into a query editor and the type changed to "Markdown". It is repeatable for me. I undo all changes until the language type says SQL again (since I get an error when trying to change it manually), then clear everything with CTRL-A and Del or backspace, then paste the below code, and it switches again to Markdown.
select pe.PropertyNumber as PropertyNumber,
pet.*
from PropertyEntity pe
join PropertyEntityType pet on pe.PropertyEntityTypeId = pet.PropertyEntityTypeId
PropertyNumber,
FacilityType, --Property, Structure, Space
StructureNumber, -- 5000130-01 or null
SpaceNumber,  -- 5000130-01 or null
AddressType, -- Physical Location, Delivery Location, Mailing
StreetAddress1,2,3,
PostalCode,
Location1Type,
Location1,
Location2Type,
Location2,
Location3Type,
Location3,
Location4Type,
Location4,
Location5Type,
Location5,
Latitude,
Longitude
From: Alan Ren @.>
Sent: Wednesday, March 23, 2022 10:46 AM
To: microsoft/azuredatastudio @.>
Cc: Aaron Lambert @.>; Mention @.>
Subject: Re: [microsoft/azuredatastudio] Pasting SQL changes language mode to Powershell (Issue #18800)
@lambertaa-churchaccounthttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flambertaa-churchaccount&data=04|01|lambertaa%40churchofjesuschrist.org|fe912ba7797c4807ce3008da0cec927e|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637836507477178856|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=wPT7UToRiGnkAYp8GMvMmUP3MALyyNwiYkYZz3WQlVg%3D&reserved=0 could you please share the query that can reproduce the issue? also were you coping query to a query editor (within it there is a toolbar with these actions: run query, connect )?

Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazuredatastudio%2Fissues%2F18800%23issuecomment-1076559531&data=04|01|lambertaa%40churchofjesuschrist.org|fe912ba7797c4807ce3008da0cec927e|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637836507477178856|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=E6TmFljY7BVX5tII9FN%2FrZMDq0RhTrNuvssnDWEpvgc%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXQKHYMIWRMCY26Z4WZGS6TVBNDDPANCNFSM5RMHYM7Q&data=04|01|lambertaa%40churchofjesuschrist.org|fe912ba7797c4807ce3008da0cec927e|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637836507477178856|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=BpL431hKetyvF84LJf0SeD8fiFK9ZZ1QrDLmqoaAzOQ%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

finally, I am able to reproduce the issue, it has to be in an editor from a previous session (open an new editor and reopen azure data studio), newly opened editor in current session won't have such problem. are you seeing the same behavior? @lambertaa-churchaccount
I have a fix for it and the fix will be shipped in our next release.


add test for backward prefixed enumerations with starting key

i have problem with backward enumeration with prefix and starting key. I've written failing test for that. Can anybody help me with this?

#31

Fixed with 0dbac139d90d0759432c5108a71cc52b0907bb67 and merged. Thanks!


Docker  - error: argument -a/--auth_service is required

Expected Behavior
Avator to run
Actual Behavior
error: argument -a/--auth_service is required
Steps to Reproduce
maybe a dumb question....
how come we have so many config.json from the docker command ?
In the wiki it ask us to run the below....
docker run --name=pokego-bot1 --rm -it -v $(pwd)/configs/config-account1.json:/usr/src/app/configs/config.json pokemongo-bot
I believe the first "configs/config-account1.json" refers to the json file, how about the second "configs/config.json" ??
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

/usr/src/app/configs/config.json refer to the josn inside the container.
By doing -v $(pwd)/configs/config-account1.json:/usr/src/app/configs/config.json, you replace /usr/src/app/configs/config.json by your $(pwd)/configs/config-account1.jsoninside the container

@Lunik I am also getting this error. After building, and executing the run command without the -v flag, it gives me this error:
Command Executed:
docker run --name=pokego-bot1 --rm -it $(pwd)/configs/config-account1.json:/usr/src/app/configs/config.json pokemongo-bot

Result:
docker: Error parsing reference: "~/PokemonGo-Bot/configs/config-account1.json:/usr/src/app/configs/config.json" is not a valid repository/tag.
See 'docker run --help'.

(replaced my home path with ~/)

And if I execute python pokecli.py it gives me this error:
Traceback (most recent call last):
  File "pokecli.py", line 38, in <module>
    import requests
ImportError: No module named 'requests'

thanks Lunik ...   so in $(pwd)/configs/config-account1.json should I replace (pwd) with my password which is already in the json file (currently its named under configs/config-account1.json??

You should also the -v option parameter: $(pwd)/configs/config-account1.json:/usr/src/app/configs/config.json

It worked executing
$ docker run --name=pokego-bot1 --rm pokemongo-bot -cf configs/config-account1.json

The -cf flag was needed, for some reason whenever I used the -a flag it said unknown, but it wanted me to put it... Thanks!

Although now it's saying
IMPORTANT: Rename and configure release_config.json.example for your Pokemon release logic first!

when I've renamed release_config.json.example to release_config.json

@datitisev - what is the filename of your config file ??
config-account1.json or configs/config-account1.json ?

Sorry I didn't update on this, but it now works using this command:
docker run namlehong/alpine-pgo:dev -a tcp -u username -p 1234 -l "Atlantic Ocean"

However I want to say something about the Docker image.
We use python:2.7-onbuild if I'm right.
But after doing docker build -t pokebotgo ., the configs/config.json is not copied into the container...
Is it my mistake ?

come to slack chat #help and someone can help you
NOT A BUG


Task : Running Test on Real Smart Card on Windows Environment

I have installed FIDO2Applet on real smart card.
But I am not able to run python_tests on the smart card.
I tried following steps on ws2 ubuntu because apparently on windows I cannot start the tests due to some dependency of fnctl library which is not there on windows. So I installed wsl and ubuntu and I am trying to build and run the python_tests.
But I am facing many challenges related to libraries and stuff. Which I am trying to solve but I feel I am still a long way to run the python_tests.
Is it somehow possible on guiding on (I believe I am asking for a lot, but its worth a shot):

what configuration/file to change in the project so that I am able to connect to smart  card (I am using Gemalto USB smart card reader)
in order to run the python_tests on windows, is there any possibility ? to avoid wsl and ubuntu stuff ? if yes then how?
Apparently, some compatibility issues are also coming between different python libraries, most resent with pyscard. Is it somehow possible to find which libraries other then mentioned in requirements.txt are requried to execute the tests on windows?

First off, the tests in this repository rely on each test suite installing the applet fresh. They are not designed to be a generic compatibility suite for an installed applet, they're designed to check the applet code itself is working. That said...

ctap_test.py line 91 should be PCSC instead of RAW if you're trying to use a real smart card
1b. You will need to rewrite the setUp, setUpClass, tearDown, and softResetCard methods of JCardSimTestCase in ctap_test.py because you're planning not to use JCardSim
1c. ctap_test.py line 292 needs to change to use a filter matching your real card
There's nothing Linux-specific in the repository, so if your Windows Python setup is fine it should work. It's just not going to be a super good developer experience because Windows generally isn't great at, you know, Python
The requirements.txt lists fido2[pcsc], which pulls in the pyscard dependency. You do need pyscard installed and working. That's what determines whether the tests can connect to your smartcard reader or not.

But the tests in this repository are not designed to run against a real installed applet, they're designed to run against a software emulation of one. You can make the changes above if you like, but right now the tests take a couple seconds and require no human intervention. On a real card they'd take minutes and you'd have to be there to plug the card in and out.

Closing due to inactivity.


java.net.ConnectException: Connection refused Running maestro

Describe the bug
I installed maestro 1 day ago and it works, but now every time I try to run a maestro studio command I get this error:
java.net.ConnectException: Connection refused
at java.base/sun.nio.ch.Net.connect0(Native Method)
at java.base/sun.nio.ch.Net.connect(Net.java:579)
at java.base/sun.nio.ch.Net.connect(Net.java:568)
at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:593)
at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
at java.base/java.net.Socket.connect(Socket.java:639)
at java.base/java.net.Socket.connect(Socket.java:588)
at java.base/java.net.Socket.(Socket.java:512)
at java.base/java.net.Socket.(Socket.java:292)
at dadb.adbserver.AdbServer.listDadbs(AdbServer.kt:67)
at dadb.adbserver.AdbServer.listDadbs$default(AdbServer.kt:60)
at dadb.Dadb$Companion.list(Dadb.kt:244)
at dadb.Dadb$Companion.list$default(Dadb.kt:243)
at maestro.cli.device.DeviceService.listAndroidDevices(DeviceService.kt:140)
at maestro.cli.device.DeviceService.listDevices(DeviceService.kt:124)
at maestro.cli.device.DeviceService.listConnectedDevices(DeviceService.kt:114)
at maestro.cli.device.PickDeviceInteractor.pickDeviceInternal(PickDeviceInteractor.kt:40)
at maestro.cli.device.PickDeviceInteractor.pickDevice(PickDeviceInteractor.kt:17)
at maestro.cli.session.MaestroSessionManager.selectDevice(MaestroSessionManager.kt:116)
at maestro.cli.session.MaestroSessionManager.newSession(MaestroSessionManager.kt:65)
at maestro.cli.command.StudioCommand.call(StudioCommand.kt:51)
at maestro.cli.command.StudioCommand.call(StudioCommand.kt:19)
at picocli.CommandLine.executeUserObject(CommandLine.java:1933)
at picocli.CommandLine.access$1200(CommandLine.java:145)
at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2332)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2326)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2291)
at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2159)
at maestro.cli.DisableAnsiMixin$Companion.executionStrategy(DisableAnsiMixin.kt:22)
at picocli.CommandLine.execute(CommandLine.java:2058)
at maestro.cli.AppKt.main(App.kt:117)
To Reproduce
Steps to reproduce the behavior, e.g.:

Start the simulator
Run maestro test ... or maestro studio

Expected behavior
Maestro should run the test or open the studio
Screenshots
If applicable, add screenshots to help explain your problem.
Environment information (please complete the following information):

Maestro version [e.g. v1.36.0]
Platform: Android 14
Framework: React Native
Device model and OS version: Android Pixels 5 (emulator)
Emulator
Host Mac M2

that means your adb server or adbd binaries are having problems - not maestro.
run adb devices and use emulator's ID to open a shell to it like adb -s "emulator-5554" shell  and see if you can reach them, get to it's logcat. If you can get there while maestro can't connect, then take a look at the emulator's logcat while trying to connect to see any relevant logs.
If still no luck, run adb kill-server from terminal , then run adb start-server and see if that solves your problems.
Or simply restart it, it sounds like your adb executables are stuck or something.

I was having the same problem, before I installed ADB on the window, not the WSL. So when Run adb devices did not accept any virtual machine. After I linked the path from the window to the command of  sudo ln -s /mnt/c/Users/{YOUR-USERNAME}/AppData/Local/Android/Sdk/platform-tools/adb.exe /usr/bin/adb . Then when running the adb devices command realized the virtual machine, but the Maestro command was involved in the title. Who has a fix?


Topology interface should become more user-friendly

The current design pushes the load-chart out of the screen if the topology has many nodes:

This is due to the fact that the topology 'window' scales according to the number of nodes to display. At the moment this scaling is independent of the 'zoom-level' of the topology:

One of the consequences is that the user must spend some time to re-adjust his view and drag/zoom the topology inside the newly scaled window.
I (humbly) propose to make to changes:

Put the topology and the chart besides each other (instead of on top of each other)
Keep the size of the topology window fixed. The user can either 'drag' the topology over the window or use a scrol-bar to view different parts of the network.

This could look something like this:

And if the network has many nodes like this:

Re-assigning to @dennisschoenmakers so he can shine his light on this and find someone to make this happen.


rawkv: permit empty value

Close #613
Changes

Remove empty value check in Put, BatchPut, and CompareAndSwap.
Convert nil to []byte{} for Get, BatchGet, Scan, and ReverseScan to distinguish empty value from not existed. As well as for mocktikv.
Add or modify related integrated test cases.
Change Github workflow to add test for API v2.

@iosmanthus PTAL, thanks~


[SPARK-12796] [SQL] Whole stage codegen

This is the initial work for whole stage codegen, it support Projection/Filter/Range, we will continue work on this to support more physical operators.
A micro benchmark show that a query with range, filter and projection could be 3X faster then before.
It's turned on by default, automatically fallback to old behavior if the compile stage failed to compile (could because the generated Java source code is too large, over 64k Loc).
Here is the call graph of three SparkPlan, A and B support codegen, but C does not.
    *
    *   SparkPlan A            SparkPlan B          SparkPlan C
    * ===============================================================
    * -> doExecute()
    *     |
    *  doCodeGen()
    *     |
    *  produce()
    *     |
    *  doProduce() -------->   produce()
    *                             |
    *                          doProduce()  -------> produce()
    *                                                   |
    *                                                doProduce() (fetch row from upstream)
    *                                                   |
    *                                                consume()
    *                          doConsume()  ------------|
    *                             |
    *  doConsume()  <-----    consume()
    *     |
    *   consume() (omit the rows)
    *
    * SparkPlan A and B should override doProduce() and doConsume().

Test build #49298 has started for PR 10735 at commit f05524c.

Test build #49298 has finished for PR 10735 at commit f05524c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49298/
Test FAILed.

Merged build finished. Test FAILed.

@davies can you include the generated code for the benchmark?

Test build #49344 has started for PR 10735 at commit 43139a8.

Test build #49344 has finished for PR 10735 at commit 43139a8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49344/
Test FAILed.

Test build #49348 has started for PR 10735 at commit 67e81d4.

Test build #49348 has finished for PR 10735 at commit 67e81d4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49348/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49362/
Test FAILed.

    /* 007 */
    /* 008 */   private Expression[] expressions;
    /* 009 */   private boolean initRange0;
    /* 010 */   private long partitionEnd1;
    /* 011 */   private long number2;
    /* 012 */   private boolean overflow3;
    /* 013 */   private UnsafeRow unsafeRow = new UnsafeRow(0);
    /* 014 */
    /* 015 */   public GeneratedIterator(Expression[] exprs) {
    /* 016 */     expressions = exprs;
    /* 017 */     initRange0 = false;
    /* 018 */     partitionEnd1 = 0L;
    /* 019 */     number2 = 0L;
    /* 020 */     overflow3 = false;
    /* 021 */   }
    /* 022 */
    /* 023 */   protected void processNext() {
    /* 024 */
    /* 025 */     if (!initRange0) {
    /* 026 */       if (input.hasNext()) {
    /* 027 */         // number2 and partitionEnd1
    /* 051 */       } else {
    /* 052 */         return;
    /* 053 */       }
    /* 054 */       initRange0 = true;
    /* 055 */     }
    /* 056 */
    /* 057 */     while (!overflow3 && number2 < partitionEnd1) {
    /* 058 */       long value4 = number2;
    /* 059 */       number2 += 1L;
    /* 060 */       if (number2 < value4 ^ 1L < 0) {
    /* 061 */         overflow3 = true;
    /* 062 */       }
    /* 063 */
    /* 070 */       long primitive8 = -1L;
    /* 071 */       primitive8 = value4 & 1L;
    /* 074 */       boolean primitive6 = false;
    /* 075 */       primitive6 = primitive8 == 1L;
    /* 076 */       if (!false && primitive6) {
    /* 081 */         currentRow = unsafeRow;
    /* 082 */         return;
    /* 085 */       }
    /* 087 */     }
    /* 089 */   }
      */

Test build #49375 has started for PR 10735 at commit 73fe074.

Test build #49375 has finished for PR 10735 at commit 73fe074.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49375/
Test FAILed.

Test build #2381 has started for PR 10735 at commit 73fe074.

Test build #2382 has started for PR 10735 at commit 73fe074.

Test build #2382 has finished for PR 10735 at commit 73fe074.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #2381 has finished for PR 10735 at commit 73fe074.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #49388 has started for PR 10735 at commit 32309e1.

Test build #49388 has finished for PR 10735 at commit 32309e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49388/
Test PASSed.

/* 007 */
/* 008 */   private Expression[] expressions;
/* 009 */   private boolean initRange0;
/* 010 */   private long partitionEnd1;
/* 011 */   private long number2;
/* 012 */   private boolean overflow3;
/* 013 */   private UnsafeRow unsafeRow = new UnsafeRow(0);

--> Do we need this? Seems we can just make the super class one protected.
/* 014 /
/ 015 /   public GeneratedIterator(Expression[] exprs) {
/ 016 /     expressions = exprs;
/ 017 /     initRange0 = false;
/ 018 /     partitionEnd1 = 0L;
/ 019 /     number2 = 0L;
/ 020 /     overflow3 = false;
/ 021 /   }
/ 022 /
/ 023 /   protected void processNext() {
/ 024 /
-- Can we split this section out? Prepare()/Open(). It's annoying to do this check every next. The check is probably cheap but it bloats the function size and having more structure I think makes it easy to understand.
/ 025 /     if (!initRange0) {
/ 026 /       if (input.hasNext()) {
/ 027 /         // number2 and partitionEnd1
/ 051 /       } else {
/ 052 /         return;
/ 053 /       }
/ 054 /       initRange0 = true;
/ 055 /     }
/ 056 */
Can we do better with variable naming? It might be nicer if it was prefixed with the operator it came from. This is going to be hard to reason about.
/* 057 /     while (!overflow3 && number2 < partitionEnd1) {
/ 058 /       long value4 = number2;
/ 059 /       number2 += 1L;
/ 060 /       if (number2 < value4 ^ 1L < 0) {
/ 061 /         overflow3 = true;
/ 062 /       }
/ 063 /
/ 070 /       long primitive8 = -1L;
/ 071 /       primitive8 = value4 & 1L;
/ 074 /       boolean primitive6 = false;
/ 075 /       primitive6 = primitive8 == 1L;
/ 076 /       if (!false && primitive6) {
/ 081 /         currentRow = unsafeRow;
/ 082 /         return;
/ 085 /       }
/ 087 /     }
/ 089 */   }
*/

This looks good. How are we going to test this? I'd prefer if we could more explicitly verify that we are running the codegen path and hte number of operators that are combined.
Do we have test cases that combine stages that are codegened with not?

+1 to adding some SparkPlanTests.  This is another case where having an explicit whole stage codegen operator would make things easier.

Test build #49449 has started for PR 10735 at commit 38029bc.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49448/
Test FAILed.

Build finished. Test FAILed.

Do we have to do the renaming in this pr? It distracts the main diff flow. If you really want to do the renaming here, maybe you can submit a separate pull request just for the renaming, and we can merge that one first quickly.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49450/
Test FAILed.

@rxin https://github.com/apache/spark/pull/10767

Test build #49451 has started for PR 10735 at commit c1dd60a.

Test build #49451 has finished for PR 10735 at commit c1dd60a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49451/
Test FAILed.

Test build #49449 has finished for PR 10735 at commit 38029bc.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class ExprCode(var code: String, var isNull: String, var value: String)
class CodegenContext
case class FakeInput(child: SparkPlan) extends LeafNode
case class WholeStageCodegen(plan: SparkPlan, children: Seq[SparkPlan]) extends SparkPlan
     class GeneratedIterator extends org.apache.spark.sql.execution.BufferedRowIterator

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49449/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49461/
Test FAILed.

Test build #49462 has started for PR 10735 at commit d453081.

Test build #49462 has finished for PR 10735 at commit d453081.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49462/
Test FAILed.

Test build #49463 has started for PR 10735 at commit 34a0a6f.

Test build #49467 has started for PR 10735 at commit 908c8cb.

Test build #49463 has finished for PR 10735 at commit 34a0a6f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49463/
Test FAILed.

Merged build finished. Test FAILed.

Test build #49471 has started for PR 10735 at commit 1feab20.

Test build #49467 has finished for PR 10735 at commit 908c8cb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait SupportCodegen extends SparkPlan
case class InputAdapter(child: SparkPlan) extends LeafNode with SupportCodegen
case class WholeStageCodegen(plan: SupportCodegen, children: Seq[SparkPlan])
case class Project(projectList: Seq[NamedExpression], child: SparkPlan)
case class Filter(condition: Expression, child: SparkPlan) extends UnaryNode with SupportCodegen

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49467/
Test FAILed.

Merged build finished. Test FAILed.

Test build #49471 has finished for PR 10735 at commit 1feab20.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49471/
Test FAILed.

Merged build finished. Test FAILed.

@rxin @nongli @marmbrus  Had followed the discussion yesterday, could you take another look?

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49486/
Test FAILed.

Merged build finished. Test FAILed.

Test build #49487 has started for PR 10735 at commit 7c05703.

Test build #49487 has finished for PR 10735 at commit 7c05703.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait CodegenSupport extends SparkPlan
case class InputAdapter(child: SparkPlan) extends LeafNode with CodegenSupport
case class WholeStageCodegen(plan: CodegenSupport, children: Seq[SparkPlan])
case class Filter(condition: Expression, child: SparkPlan) extends UnaryNode with CodegenSupport

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49487/
Test FAILed.

Test build #49493 has started for PR 10735 at commit 0b40106.

Test build #49493 has finished for PR 10735 at commit 0b40106.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49493/
Test PASSed.

Test build #49518 has started for PR 10735 at commit 79a8f25.

Test build #49518 has finished for PR 10735 at commit 79a8f25.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49518/
Test FAILed.

Merged build finished. Test FAILed.

Test build #49519 has started for PR 10735 at commit 594939f.

Test build #49519 has finished for PR 10735 at commit 594939f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49519/
Test FAILed.

Test build #2386 has started for PR 10735 at commit 3e05fec.

Test build #2387 has started for PR 10735 at commit d12a8da.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49520/
Test FAILed.

Test build #2386 has finished for PR 10735 at commit 3e05fec.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #49521 has started for PR 10735 at commit d12a8da.

Test build #2387 has finished for PR 10735 at commit d12a8da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #49521 has finished for PR 10735 at commit d12a8da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49521/
Test PASSed.

I'm going to merge this into master, any new comments will be addressed by follow up PR.


Use ngStyle to support CSP

Problem
If a strict Content Security Policy (CSP) is enabled, it will block modals from being opened because the template in simple-modal-wrapper.component.ts contains an inline style.
Workaround:
Allow "unsafe-inline" for styles in the CSP.
Proposed solution in this PR:
Use [ngStyle] instead of style=. [ngStyle] is not blocked by the browser even with a strict CSP.
Possible drawbacks:
[ngStyle] cannot set !important.

I'll check this in the Stackblitz demo later today but actually seems like a good change AND the !important inside the style was a hangover from the original project I think


Remove default "main" cluster

Is your feature request related to a problem? Please describe the impact that the lack of the feature requested is creating.
[A clear and concise description of what the problem or need is. E.g. I need to...]
I have an empty main cluster due to overriding default kubeconfig
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
I wonder to complete an in-cluster deployment with customs kubeconfig files without main cluster
What users will benefit from this feature?
[What type of users may be interested in this feature? What kind of Headlamp setup is likely used. (e.g. WSL users / Helm chart users / In-Cluster users / Plugin developers)]
In-Cluster users (may be others also)
Are you able to implement this feature?
[Yes (I will propose a PR) / No.]
No

Do you want to help implement this feature? Please see our contribution docs. For any non-trivial contributions, we advise you to join our our slack channel to discuss the implementation with Headlamp's core developers.
No

Additional context
[If needed, add any other context or screenshots about the feature request here.]

@nsagnett Thanks for reporting. We need more context. Can you tell us more about how your setup is done? (i.e. are you running with -in-cluster but also specifying a -kubeconfig and you do not want the cluster named main to be visible?)

Of course! So yes, indeed, it's in cluster setup and I override "default" kubeconfig, but even with that, "main" stay visible

The problem is this param is automatically added when I deploy the chart on cluster


WIP Fixes #2364 - add C++11 support by including it from math's makefiles.

Submisison Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Declare copyright holder and open-source license: see below

Summary
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@seantalts, this isn't high priority, right? It looks like it breaks the Windows tests. I'll need to log in to get to the bottom of it, I think.

It's not high priority from my perspective.
Interesting error message... Don't immediately see the connection. Hm.

Oh wait, I thought this was the one on the Math repo. This needs the math repo one first! I'll mark it WIP while it's waiting on that.

Jenkins, retest this please.

So this appears to be failing on g++ on Travis because the compiler runs out of memory (in the Travis logs it just says it hit an internal compiler bug, but when testing on my local Trusty VM it tells me that it's because it ran out of memory).
Anyone know what to do about this? This has seemingly only changed with the addition of the --std=c++1y flag.

@syclik I think this is ready for review (will trigger Jenkins tests again - was focusing on fixing travis the past few times so I'd been killing the Jenkins ones). The one worrying thing is that I had to turn down the parallelism on a bunch of these tests because GCC was taking more memory than the Travis VMs had available.
Jenkins, retest this please.

All the changes look straightforward.
Thanks for dealing with Travis. It's tricky and time-consuming. Glad you worked it out.


code cleanup: Clean up subs.js code (including tests).

This is indirect prep for changing how we send subscriber payloads.

This is a great direction; posted a few comments on details.  Thanks @showell!

This should be ready for review again.  (I responded to your questions.  I didn't change any code.)

Merged, thanks @showell!


Add dialog share

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

i18n-check

The following components have not been translated
component.dialog-share.view (ru)component.dialog-share.view (en)component.entry-context-menu.view (ru)component.entry-context-menu.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
component.entry-context-menu.view (ru)component.entry-context-menu.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
component.entry-context-menu.view (ru)component.entry-context-menu.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check

The following components have not been translated
component.entry-context-menu.view (ru)component.entry-context-menu.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.


Change gen_icsp_single_vote to iterative version

When generating a dataset with a large number of alternatives (say 1000) with the Single Peaked Impartial Culture method, maximum stack recursion depth is reached. The following pull request should remedy this.
The following test proves both versions produce the same results:
# Return a Tuple for a IC-Single Peaked... with alternatives in range 1....range.
def gen_icsp_single_vote_new(alts):
	a = 0
	b = len(alts)-1
	temp = []
	while a != b:
		if random.randint(0,1) == 1:
			temp.append(alts[a])
			a += 1
		else:
			temp.append(alts[b])
			b -= 1
	temp.append(alts[a])
	return tuple(temp[::-1]) # reverse

# Return a Tuple for a IC-Single Peaked... with alternatives in range 1....range.
def gen_icsp_single_vote(alts):
	random.seed(1)
	res = tuple(gen_icsp_recurse(0, len(alts)-1, alts))
	random.seed(1)
	iterver = gen_icsp_single_vote_new(alts)
	assert res == iterver
	return res

Thanks aksiazek!  I'll pull this into the Dev branch.  I am refactoring a large part of Dev to work with a more object based framework so when I roll this out I'll use your version which removes the tail recursion.


Canary-release fix for broken git on Windows

Description

It turns out that a recent update to conda's dependencies (adding m2-patch) results in a broken git. To fix this we need to run conda install git after conda install conda-build.
Xref https://github.com/conda/conda/issues/11758
Checklist - did you ...

[x] ~Add a file to the news directory (using the template) for the next release's release notes?~

[x] ~Add / update necessary tests?~
[x] ~Add / update outdated documentation?~

wow, yikes


[network] Revert criterion version to 0.3.0 to allow plotting in log scale for network benchmarks

Motivation
The 0.3.1 version of criterion causes the benchmark library to panic for some (yet unknown) reason. Reverting to 0.3.0 fixes the issue for now.
Test Plan
cargo x bench finishes without panic.
Related PRs
#2516

@bors-libra r+

:pushpin: Commit 533f9bc has been approved by phlip9

:hourglass: Testing commit 533f9bcdac0890f2520e59631ebcbf3ee5f29e9b with merge eac2cf3542077b435c8e82e404b36e7a054b3f56...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit 533f9bcdac0890f2520e59631ebcbf3ee5f29e9b with merge 0b3a4a0a21fb6dee4d18fbe256f7550e1a8d8d9e...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: phlip9
Pushing 0b3a4a0a21fb6dee4d18fbe256f7550e1a8d8d9e to master...


Archive unused documentation and website repositories

The two documentation repositories and old website repository are no longer used by the project, and should be archived
https://github.com/adoptium/documentation-services
https://github.com/adoptium/documentation
https://github.com/adoptium/adoptium.net
Archiving requires ensuring that any issues in those repos that are still valid be moved into another repo area. After that they can probably be renamed to indicate they are obsolete and marked read-only (bonus points for moving to a new org with reduced permissions or somesuch)

Looks like they have been marked as archived + read-onlky by someone.
They still have open issues, therefore I will leave this open for now.

Hmm, I wonder who did that?
We can't move the issues while they are archived, so may need to create new dupes - I only see a couple of issues that remain valid in the new world.


fix: check the asset's existence before running filter

Fixes https://github.com/vuejs/vue-cli/issues/4572
Apparently, the getAsset() call is possible to return an undefined value.
https://github.com/webpack/webpack/blob/9c6b36787fe43581d6c568e64b71656274c04881/lib/Compilation.js#L2058-L2060
What kind of change does this PR introduce?
A bugfix
Did you add tests for your changes?
Not sure how to get a minimum reproduction of this case but it's an emergency fix.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
Nothing.

This is not the only one, a few lines later the next break:
https://github.com/webpack/webpack/blob/e4c7d8c0ae0c93306f07920bc28fe72119bc098a/lib/performance/SizeLimitsPlugin.js#L69-L72

https://github.com/webpack/webpack/pull/9701


Reading pin

Hi there,
i wery like Your package. but I found one problem.
If i set my pin value to high and i trying to read it it always set pin direction to input
and always return false, but documentation says that you can read value does not matter set to input or output.

Hi doncebiti,
You're right, I do set it back to input. My goal was to make it super easy to use, I was assuming that if you are reading the value, obviously it's pin input. To fix your scenario though, I've updated the package to 4.3.0 with a fix. PinValue now won't set the direction to In if it is already set to out. You should be able to read the value without the direction changing now ;)
Tyson


Make "Operations" field optional on Transaction Model and block_identifier optional in BlockResponse

Summary: Make "Operations" field on Transaction Model optional so we can efficiently return /search/transactions response with just the tx hashes instead of calling /block/transaction on EACH tx to get the operations data
AND
Make block_identifier optional in BlockResponse: https://www.rosetta-api.org/docs/models/BlockTransaction.html
Motivation
The recent addition of /search/transactions indexer api opened up a use case of getting "all txs by an address".
We currently enable this by storing all txs by address in a  mongo database
"address": {
   id: "232323"
  "transactions": [ hash1, hash2 ]
}

Notice that we only store the hashes not the full transaction data. Now getting this data is easy.
POST /search/transactions
{
    ...
     "account_identifier": {
        "address": "addr_12312112112"
    }
}
Response:
{
    ....
    "transactions": [
        {
            "transaction_identifier": {
                "hash": "hash1",
            }
        },
        {
            "transaction_identifier": {
                "hash": "hash2"
            }
        }
    ]
}

However https://www.rosetta-api.org/docs/models/Transaction.html states that "operations" field is required in the response of transaction. Which means we will have to query /block/transaction by this hash for EVERY tx in our list. This could be thousands of query for some addresses.
Also sometimes we don't care about the operations value and just want to get the list of transaction hashes by account so its quite inefficient to return all the operations when not needed.
With the same logic https://www.rosetta-api.org/docs/models/BlockTransaction.html the "block_identifier" should be optional as returning this for each tx would require extra db calls
Proposal:
Make "Operations" field optional in https://www.rosetta-api.org/docs/models/Transaction.html
This doesn't break  any implementations as they were already sending it anyways. And for the /search/transactions  api we will omit sending it saving us thousands of extra api calls.
AND
Make block_identifier field optional in https://www.rosetta-api.org/docs/models/BlockTransaction.html

However https://www.rosetta-api.org/docs/models/Transaction.html states that "operations" field is required in the response of transaction. Which means we will have to query /block/transaction by this hash for EVERY tx in our list. This could be thousands of query for some addresses.

We added "paginaton" fields so that any indexer implementation could limit the number of items returned in a single query (regardless of what the caller specifies in the request). Did you not feel this was sufficient to prevent these thousands of queries?

Also sometimes we don't care about the operations value and just want to get the list of transaction hashes by account so its quite inefficient to return all the operations when not needed.

Could you elaborate on when they wouldn't be needed? Returning the fully populated Transaction in the response was an optimization to remove the need to make another call to /block/transaction when populating a view.

With the same logic https://www.rosetta-api.org/docs/models/BlockTransaction.html the "block_identifier" should be optional as returning this for each tx would require extra db calls.

I'd recommend always storing BlockIdentifier with TransactionIdentifier in your database. Some networks (even Bitcoin) have blocks that contain TransactionIdentifiers seen in other blocks. Without BlockIdentifier included, it is impossible to differentiate between which transaction a query refers to.

Proposal:
Make "Operations" field optional in https://www.rosetta-api.org/docs/models/Transaction.html
This doesn't break any implementations as they were already sending it anyways. And for the /search/transactions api we will omit sending it saving us thousands of extra api calls.
AND
Make block_identifier field optional in https://www.rosetta-api.org/docs/models/BlockTransaction.html

To make this happen, we'd need to define a new SearchTransaction model to replace the BlockTransaction model currently being used where certain fields could be made optional. We use BlockTransaction extensively with the Data API and don't want to give the impression that certain fields are no longer required (when they would really only optional for the Indexer API).

@patrick-ogrady thanks. I agree on all your points now. Upon putting more thoughts on this I decided to just use pagination and limit the results. So this request should be closed.

Could you elaborate on when they wouldn't be needed? Re...
I was considering like an explorer page where we only rendered the list of transactions/addresses ids and then when the user clicked on one then we fetched the full details. In that case just returning the tx hashes or the addresses list would have been faster.

But I agree this will complicate the api a lot and we can get by just by using limits/offsets. Let's close this.
Thanks for the consideration.


x/tools/gopls: gopls.add_dependency workspace edits not working?

What version of Go are you using (go version)?

$ go version
go version devel +e9c9683597 Tue Feb 9 18:40:13 2021 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.1.1-0.20210204180613-842a9283d6c6
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20210204180613-842a9283d6c6

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/myitcv/gostuff/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel +e9c9683597 Tue Feb 9 18:40:13 2021 +0000"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build474152825=/tmp/go-build -gno-record-gcc-switches"

What did you do?
This is a follow up to #44035. Thanks very much @heschik for addressing that issue in golang/tools@706a59c.
I've just tried this out, but I'm still not seeing workspace edits for go.mod. Given your change had test coverage, I suspect this is a configuration issue of some sort but I can't see what that might be.
I started with the same setup as before:
-- go.mod --
module example.com/repro

go 1.16
-- main.go --
package main

import (
	"fmt"

	_ "golang.org/x/tools/imports"
)

func main() {
	fmt.Println("hello, world!")
}

i.e. the requirement on golang.org/x/tools/imports is missing from go.{mod,sum}.
Loading main.go in Vim (using govim) gives error diagnostics as expected:
main.go|6 col 4| could not import golang.org/x/tools/imports (no required module provides package "golang.org/x/tools/imports")
main.go|6 col 4| golang.org/x/tools is not in your go.mod file

If we ask for suggested fixes at main.go:6 we get a code action response with the gopls.add_dependency command.
If we execute the gopls.add_dependency command, go.{mod,sum} change beneath the editor and gopls, i.e. we don't see any workspace edits, despite the changes in golang/tools@706a59c.
Log files:

gopls.log
govim.log

Is there something we (govim) are not doing right here?
As a side note, I suspect the tempModfile option is no longer valid given that we have allowModfileModifications? Because I initially had tempModfile: true and this resulted in the error message:
-modfile is unsupported for this Go version

But I can raise this as a separate issue if needs be.
What did you expect to see?
gopls.add_dependency resulting in workspace edits for go.{mod,sum}.
What did you see instead?
The files changing beneath the editor, and that change getting detected by the govim file watcher

cc @stamblerre @heschik
FYI @leitzler

Sending workspace edits for a closed file causes VSCode to open it and leave the edits unsaved, which is undesirable, particularly for go.sum. To avoid that, gopls still directly edits closed files. You should see workspace edits if you open go.mod first.

I did try out Pauls example (using the defaults; tempModFile: true / allowModfileModifications: false) according to:

Open main.go
Apply the suggested fix, i.e. calling execute for the provided gopls.go_get_package:

[Trace - 23:56:03.030 PM] Sending request 'workspace/executeCommand - (5)'.
Params: {"command":"gopls.go_get_package","arguments":[{"URI":"file:///private/var/folders/j4/l2j99h6d5qd6knjlllql0bb80000gn/T/tmp.7WMpQpFw/main.go","Pkg":"
golang.org/x/tools/imports","AddRequire":true}]}

Send didChangeWatchedFiles for go.mod and go.sum as the file watcher detects the updates:

[Trace - 23:56:04.156 PM] Sending notification 'workspace/didChangeWatchedFiles'.
Params: {"changes":[{"uri":"file:///private/var/folders/j4/l2j99h6d5qd6knjlllql0bb80000gn/T/tmp.7WMpQpFw/go.mod","type":2}]}

[Trace - 23:56:04.157 PM] Sending notification 'workspace/didChangeWatchedFiles'.
Params: {"changes":[{"uri":"file:///private/var/folders/j4/l2j99h6d5qd6knjlllql0bb80000gn/T/tmp.7WMpQpFw/go.sum","type":1}]}

Then I get a couple of other go.sum diagnostics back for both main.go and go.mod:
[Trace - 23:56:04.805 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///private/var/folders/j4/l2j99h6d5qd6knjlllql0bb80000gn/T/tmp.7WMpQpFw/main.go","version":1,"diagnostics":[{"range":{"start":{"line":5
,"character":1},"end":{"line":5,"character":31}},"severity":1,"source":"compiler","message":"error while importing golang.org/x/tools/imports: missing go.su
m entry for module providing package golang.org/x/mod/module (imported by golang.org/x/tools/internal/imports); to add:\n\tgo get golang.org/x/tools/interna
l/imports@v0.1.0"},{"range":{"start":{"line":5,"character":1},"end":{"line":5,"character":31}},"severity":1,"source":"compiler","message":"error while impor
ting golang.org/x/tools/imports: missing go.sum entry for module providing package golang.org/x/mod/semver (imported by golang.org/x/tools/internal/gocomman
d); to add:\n\tgo get golang.org/x/tools/internal/gocommand@v0.1.0"},{"range":{"start":{"line":5,"character":1},"end":{"line":5,"character":31}},"severity":
1,"source":"compiler","message":"error while importing golang.org/x/tools/imports: missing go.sum entry for module providing package golang.org/x/sys/execab
s (imported by golang.org/x/tools/internal/gocommand); to add:\n\tgo get<EMAIL_ADDRESS>

[Trace - 23:56:04.805 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///private/var/folders/j4/l2j99h6d5qd6knjlllql0bb80000gn/T/tmp.7WMpQpFw/go.mod","diagnostics":[{"range":{"start":{"line":4,"character":
0},"end":{"line":4,"character":33}},"severity":1,"source":"compiler","message":"error while importing golang.org/x/tools/internal/gocommand: missing go.sum
entry for module providing package golang.org/x/mod/semver (imported by golang.org/x/tools/internal/gocommand); to add:\n\tgo get golang.org/x/tools/interna
l/gocommand@v0.1.0"},{"range":{"start":{"line":4,"character":0},"end":{"line":4,"character":33}},"severity":1,"source":"compiler","message":"error while imp
orting golang.org/x/tools/internal/gocommand: missing go.sum entry for module providing package golang.org/x/mod/semver (imported by golang.org/x/tools/inte
rnal/gocommand); to add:\n\tgo get golang.org/x/tools/internal/gocommand@v0.1.0"},{"range":{"start":{"line":4,"character":0},"end":{"line":4,"character":33}
},"severity":1,"source":"compiler","message":"error while importing golang.org/x/tools/internal/gocommand: missing go.sum entry for module providing package
 golang.org/x/sys/execabs (imported by golang.org/x/tools/internal/gocommand); to add:\n\tgo get golang.org/x/tools/internal/gocommand@v0.1.0"},{"range":{"s
tart":{"line":4,"character":0},"end":{"line":4,"character":33}},"severity":1,"source":"compiler","message":"error while importing golang.org/x/tools/interna
l/gocommand: missing go.sum entry for module providing package golang.org/x/sys/execabs (imported by golang.org/x/tools/internal/gocommand); to add:\n\tgo g
et golang.org/x/tools/internal/gocommand@v0.1.0"},{"range":{"start":{"line":4,"character":0},"end":{"line":4,"character":33}},"severity":1,"source":"compile
r","message":"error while importing golang.org/x/tools/internal/imports: missing go.sum entry for module providing package golang.org/x/mod/module (imported
 by golang.org/x/tools/internal/imports); to add:\n\tgo get golang.org/x/tools/internal/imports@v0.1.0"},{"range":{"start":{"line":4,"character":0},"end":{"
line":4,"character":33}},"severity":1,"source":"compiler","message":"error while importing golang.org/x/tools/internal/imports: missing go.sum entry for mod
ule providing package golang.org/x/mod/module (imported by golang.org/x/tools/internal/imports); to add:\n\tgo get<EMAIL_ADDRESS>0"}]}

Is there something I'm missing out? (full log at https://gist.github.com/leitzler/d189c42bdb0dae8562682b47325938e2).

Just to add to the above, I expected that applying the suggested fix would have the ~same effect as running go get golang.org/x/tools v0.1.0 before I open main.go.
If I do run go get before, then I only get one diagnostic (warning) telling me that the require line should be direct (ideally gopls would fix that as well executing gopls.go_get_package).

@leitzler: I don't see how your problem is related to workspace edits, but it is a real (and rather embarrassing) mistake on my part, so I'll file a new bug. Thanks for the report.

Thank you and apologies for the issue hijacking. Didn't see that it was unrelated.

That issue was https://github.com/golang/go/issues/44307, and it is now resolved. Can we close this?

Yes, this can be closed.


Do not let users select negative numbers for Max Papers

Users should not be able to select negative numbers when setting a custom max paper limit.

Could this be due to this line? @melisabok
https://github.com/openreview/openreview-py/blob/f49ec3f45358a6fa35ebea2d92cd7b13b2c33fd4/openreview/venue/matching.py#L148-L152


Add emitDependency caching and fix pnpm symlinks

This removes the resolve caching introduced in https://github.com/vercel/nft/pull/237 and replaces it with caching the entire emitDependency call so that all nested operations shouldn't need to be cache separately.
This provides much better performance than the previous caching as testing against a couple large apps showed these results:

vercel.com: before(70 - 100 seconds) after(20 - 30 seconds)
private project: before(170 - 200 seconds) after(50 - 60 seconds)

Great improvements, and looks good to me, didn't read all the code but could just ask a few questions if it would help:

How the gains are achieved here? If it is primarily disk, what were the misses on the previous PR? And if it is primarily due to compute, that would be very surprising since 1000s of dependencies should be fully iterable in well under 5 seconds.
With the caching stuff it's also worth putting some thought to lifetimes - what's nice about the stat cache etc is they are easier to mutate / coordinate on for longer period caching, whereas approaches like these PRs move towards more opaque caching. Or possibly doing a separation of node_modules caching from user code caching. What sort of cache lifetime applies to these types of builds?

It seems eliminating iterating over the dependencies reduces the time significantly on large projects e.g. thousands of dependencies with > 100 separate runs of nodeFileTrace sharing the same cache.

This really is very surprising to me, as it is fully possible to iterate 1000s of modules in well under a second. So there must be something else going on. Could be worth digging into some further analysis there, but this PR is good to land too of course.


fix vespa-get-config exit status

@baldersheim please review

Wonder what hidden errors will surface and blow .....

Some system tests were not to happy with this, but not that many. Needs fix or revert.

Tests will be fixed.


irmin-pack: docs + example for gc

This PR adds documentation and examples for the new GC feature in irmin-pack. Closes #1960
WIP but I welcome early feedback, particularly on the correctness of my documentation/comments

Codecov Report

Merging #1973 (2a7adb4) into main (d69da1b) will increase coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 2a7adb4 differs from pull request most recent head afb17df. Consider uploading reports for the commit afb17df to get more accurate results

@@           Coverage Diff           @@
##             main    #1973   +/-   ##
=======================================
  Coverage   63.78%   63.79%
=======================================
  Files         129      129
  Lines       15516    15516
=======================================
+ Hits         9897     9898    +1
+ Misses       5619     5618    -1

Impacted Files
Coverage Δ

src/irmin-fs/unix/irmin_fs_unix.ml
67.74% <0.00%> (-0.65%)
:arrow_down:

src/irmin-fs/irmin_fs.ml
82.42% <0.00%> (+1.21%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Lack of documentation

MythicDrops is a really, really awesome plugin. It is complex, yes, but due to this there are just so many features, it's all I'd have ever wanted from a plugin like this. Except - that there is a horrible lack of documentation fo MythicDrops. Especially complex plugins like MythicDrops need to be well documented, but i was unable to find anything up-to-date which explains the config. Yes, you can learn many things by just looking at the default config, but it doesn't explain everything. For example, I'd like to know, what exactly the bonusLore is, and when it is applied. What are optimalDistance and maximalDistance? And I could go on. MythicDrops needs a good documentation of the config. Really.

Agree this needs documentation there is nowhere to explain what things are or what they mean or do

Agreed!


Create deno.yml

@MarcelRaschke cool! I have not put a deno project into production, does Rodeo work out of box with Deno?


[BUG] Dead-end when user selects limited permission and continues with allow none

Bug description

On android 14 which introduces limited asset access and lets user select specific assets to limit access to all media from device if user opts for "limited access" and without selecting assets clicks on "allow none" this leads to dead-end with no option to change settings

How to reproduce
Initiate following code on any android 14 device
      final asset = await AssetPicker.pickAssets(
        context,
        pickerConfig: AssetPickerConfig(
          maxAssets: 5,
          requestType: RequestType.image,
          specialPickerType: SpecialPickerType.noPreview,
        ),
      );

Steps to reproduce the behavior:

Initiate above code
On first invoke it will ask for permission select "Limited access permission"

System pop-up will appear to select asset don't select any asset and click on "Allow none" option

Empty screen with no option to update permission will appear

Expected behavior

There should be at-least option to open settings to change permission
If user selects new media from settings it should be updated without closing and reopening again
Using already available overlay for android as-well would nice

What happens

Once "Allow none" option is selected user will not have any options to update permission, even after closing and re-opending screen will lead to empty and option-less screen

https://github.com/user-attachments/assets/4d74aeae-5105-46af-92b8-93e8e5b40484
Version information

Device: Realme GT 2
OS: Android 14
Package Version: 9.2.1
Flutter Version: 3.22.3

I got PermissionState.denied on my OnePlus 11 Android 14.

Which means the error has been thrown instead of the incorrect result:
E/flutter ( 8854): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Bad state: Permission state error with PermissionState.denied.
E/flutter ( 8854): #0      AssetPickerDelegate.permissionCheck (package:wechat_assets_picker/src/delegates/asset_picker_delegate.dart:40:7)


Get-CsOnlineVoiceApplicationInstance

Hello,
the Set-Command exists, but there is currently no way to query an OnPremTelephoneNumber set for an Application Instance.
As this is vital to verify its application (outside the Web portal), can this one please be provided?
Thank you,
David
EDIT: Sorry, found that Get-CsOnlineApplicationInstance shows the PhoneNumber set with Set-CsOnlineVoiceApplicationInstance. I expected it to be shown differently. Please close.

@officedocsbot assign @yogkumgit

@DEberhardt Thank you very much for the contribution and sharing this explanation. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Scottwhi sbx creds

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/hotel-service/get-started.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Navbar need add phpdoc @method begin() and Nav need add @method widget()

What steps will reproduce the problem?
I Installed yii-demo , and open the project in vscode. views/layout/main.php
What is the expected result?
intelephense show message
Undefined method 'brandLabel'
Undefined method 'currentPath'

Please try updating and check again. Thanks.

@samdark
Thank you.


Deepcopy maps, arrays and optional fields when converting to/from ARM types

Before this some of the fields in a converted object were deepcopied (in the process of converting the generated types to their ARM equivalents) but other reference-type fields (maps/arrays/optionals of enums or primitive types) would be shared between the ARM object and the kubernetes one. That seems a lot more error-prone - it would be easy to inadvertently update some shared data because we'd been lulled into a false sense of security by the other fields that weren't shared.
Fixes #286.

Coverage increased (+25.4%) to 73.544% when pulling 406d1dbde7ebe4737adc029839b7cfcef68df6ff on babbageclunk:copy-string-maps into 0178ee9b3fa1b64ebd9f188d0ff001cce545ca89 on Azure:master.


Please make the description of the --tags parameter clearer.

The description of the --tags parameter is confusing.

It is misleading that [] is required.
For example, I did not understand that the tag name including the space is specified as follows.
--tags "Department Code=784500"
Would you please describe it in an easy-to-understand manner?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ce5e4a8-6bd4-cb82-4709-8d9ed53e41b2
Version Independent ID: 3d808e36-e1fe-6e2d-c812-63df2bc6b732
Content: az monitor alert-processing-rule
Content Source: latest/docs-ref-autogen/monitor/alert-processing-rule.yml
Service: monitoring-and-diagnostics
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

monitor

Hi：
@ahanafusa As the way to use tags, you can refer below examples:
1.Add or update tags: az image update -n ImageName -g ResourceGroup --tags tag1=val1 tag2=val2
2.Remove all tags：az image update -n ImageName -g resourceGroup --tags
Best wishes.


[BUG] Mining rig doesn't seem work

Description:
The mining rig seems not to work.
When I power it up, give it a drill and a data card it cycles once (not giving any ores, just drill head circle passing once) and then stops. When I try to reinsert the data card, it doesn't even cycle once. If I remove the drill and then add it again, it says drill inactive.
Is something in my setup wrong, or is it just a bug?
Steps to Reproduce:
Minecraft 1.18.2 or 1.19.2
indrev 1.14 or 1.15
Technical Information:

Minecraft: 1.18.2 or 1.19.2
Fabric API: 0.61 for 1.19.2
Industrial Revolution: 1.14 or 1.15
Modpack: Standalone or in All of fabric 5

Details:

i fing out what is happening
if you just take out item pipes and place chest next to mining rig computer it will just place ores into chest so problem was in pipes

Nice! That's good to know - can at least use it :D
Confirmed this on AOF5 1.18.2.
THX!


chrY vcf download info are missing for gnomad v4 genomes

What you did:
I cannot see the download info for chrY in gnomad v4 genomes but it is available for exomes callset.  The urls for chrY are valid but only missing in the frontend UI.
https://storage.googleapis.com/gcp-public-data--gnomad/release/4.0/vcf/exomes/gnomad.exomes.v4.0.sites.chrY.vcf.bgz
https://storage.googleapis.com/gcp-public-data--gnomad/release/4.0/vcf/exomes/gnomad.exomes.v4.0.sites.chrY.vcf.bgz.tbi
Please see the screenshot attached herein. I found this issue in Safari and Chrome in macOS 13.6.

Thanks for filing this issue! Just opened a short PR to fix it, this should get merged and deployed in relatively short order.


Document programmatic cluster administration

The rethinkdb admin tool is undocumented on the website, and users are having trouble with figuring out how to administer clusters when manual administration isn't feasible (see https://github.com/rethinkdb/rethinkdb/issues/1792 for an example set of questions).
We should have a page "Programmatic cluster administration" (or something of the sort) in the docs that gives a primer for rethinkdb admin.

Closing because this is outdated.


Automated Updates: add a simple Maven registry API client

This PR adds a simple Maven registry API client which sends requests to Maven Central Repository.
For now, this client can only be used to fetch a Maven project. We are able to extend the client to fetch other data (versions, dependencies, etc) in the future.

Codecov Report
Attention: Patch coverage is 33.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 60.07%. Comparing base (aa771d2) to head (5fe7b19).
Report is 5 commits behind head on main.

Files
Patch %
Lines

internal/resolution/datasource/maven_registry.go
33.33%
9 Missing and 5 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   59.78%   60.07%   +0.29%
==========================================
  Files         136      137       +1
  Lines       11266     8791    -2475
==========================================
- Hits         6735     5281    -1454
+ Misses       4102     3072    -1030
- Partials      429      438       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove distinction for reference script UTxOs

Currently, both the API and implementation treat UTxOs with reference scripts as distinct from regular UTxOs. This is both contrary to the spec, and blocks certain use cases.

@t4ccer


[doc] update the jvm tutorial to 1.6.1 [skip ci]

I don't think this is necessary.

I don't like users to try xgboost4j-spark-gpu 1.6.0 version. please help to merge and update the page. Thx


refactor(specs): minor style modification in specs

Coverage remained the same at 98.175% when pulling d2af4b6379cf4f4d89342d6323f1e7a64294a736 on develop into 79b00f60b606cb72d90154a108150dd18d9e86d8 on master.


Build with GTK3 and cleanup recipe

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #129.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

@conda-forge-admin please rerender

this kinda works, we need to change one gdk import

This doesn't seem really sanctioned by upstream:
https://gitlab.com/graphviz/graphviz/-/issues/1848

the reason i was interested in this is that I thought I was getting some gtk squashing warnings....

Does anybody know how to test a GTK2/3 feature???? I'm somewhat tempted to test this since gtk2 clobbers with gtk3
https://github.com/conda-forge/gtk2-feedstock/issues/24

Does anybody know how to test a GTK2/3 feature???? I'm somewhat tempted to test this since gtk2 clobbers with gtk3 conda-forge/gtk2-feedstock#24

Is this still an issue? Can we close this one? Sorry I'm can't help much here.

Well I think we should build with gtk3.
Upstream thinks there is more to do than my tiny patch. But didn’t offer much guidance and seems to think their gym tool doesn’t get much usage.

Oh this was pulled into 12!!!!!
https://gitlab.com/graphviz/graphviz/-/commit/70632d8f43f5b79c747b10f09a1689023943465b


implement interp_like

[x] Closes #2218
[x] Tests added
[x] Tests passed
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API.

This adds interp_like, that behaves like reindex_like but using interpolation.

Slightly wondering the case when an object has non-numeric dimensions.
The current implementation raises TypeError, even when the target destination is just a subset of the current one.

Slightly wondering the case when an object has non-numeric dimensions.
The current implementation raises TypeError, even when the target destination is just a subset of the current one.

Do you have an example?
It might make sense to interpolate on numeric dimensions, and directly reindex on non-numeric dimensions.

Do you have an example?

We raise a TypeError in the following example, because the dataset has datetime-type dimension.
In [3]: ds = xr.tutorial.load_dataset('air_temperature')

In [4]: ds
Out[4]:
<xarray.Dataset>
Dimensions:  (lat: 25, lon: 53, time: 2920)
Coordinates:
  * lat      (lat) float32 75.0 72.5 70.0 67.5 65.0 62.5 60.0 57.5 55.0 52.5 ...
  * lon      (lon) float32 200.0 202.5 205.0 207.5 210.0 212.5 215.0 217.5 ...
  * time     (time) datetime64[ns] 2013-01-01 2013-01-01T06:00:00 ...
Data variables:
    air      (time, lat, lon) float32 241.2 242.5 243.5 244.0 244.09999 ...
Attributes:
    Conventions:  COARDS
    title:        4x daily NMC reanalysis (1948)
    description:  Data is from NMC initialized reanalysis\n(4x/day).  These a...
    platform:     Model
    references:   http://www.esrl.noaa.gov/psd/data/gridded/data.ncep.reanaly...

In [5]: ds.interp_like(ds.isel(lat=[0, 1, 2]))  # -> TypeError

It might make sense to interpolate on numeric dimensions, and directly reindex on non-numeric dimensions.

I agree for the object type dimension, such as string, reindex is be appropriate and users might expect it.
But for datetime dimension, I think users expect the interpolation rather than reindexing.

Thanks for the review :) merged.


Update free-programming-playgrounds.md

Added Miscellaneous section and a playground link. Misc should contain playgrounds/interpreters that host a variety of languages, not purely one.
What does this PR do?
Add Resource(s)
For resources
Python
Description
Adds a new Misc sections along with a playground for that section.
Why is this valuable (or not)
It aids in finding quality playgrounds/interpreters that don't support only one language, but multiple.
How do we know it's really free?
It is free, however they offer subscriptions for trivial related benefits. Used for it's basic intended purpose, you can create online code repositories for free without an account.
For book lists, is it a book?
No, it's a playground
Checklist:

[ ] Not a duplicate
There is a heading that uses repl.it for Java specifically, however repl.it has a broader array of languages other than Java. I'll leave it up to the maintainer to decide whether or not this should be pushed for non-specific language playgrounds.
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

check_urls=free-programming-playgrounds.md

it's a duplicate. perhaps we need to revisit how we handle multi-language playgrounds


inline no longer removes keys

Previously inline would remove all inlined keys. This was causing problems in the distributed scheduler (see https://github.com/dask/distributed/issues/363), as it would accidently remove keys that were still needed by the output. One solution would be to add an output keyword, but this would bind a the distributed scheduler to the latest version of dask. A different (but equally good option) is to not remove keys in inline, instead opting for other operations for culling unneeded keys. This keeps the signature the same, requiring no changes in the distributed repo.
This change required changes in a few other places:

Things that inline functions now handle key removal locally. This is
fine and cheap to do, just a simple del operation.
The behavior of dealias is changed to collapse aliasing chains, but
not rewrite with (identity, key). This makes the implementation
simpler, matches the new definition of a dask graph (which allows
aliases), and also seems more correct with the desired behavior. Note
that since dealias isn't used anywhere anymore, it's unclear if this
change is needed, or if the code should just be deleted.

Failure is due to the known s3 credentials issue.

cc @eriknw


ImportError: cannot import name 'CpuViterbiPath' from 'flashlight.lib.sequence.criterion'

When I run this command:
python3 examples/speech_recognition/infer.py (with other parameters)
I get the following error:
ImportError: cannot import name 'CpuViterbiPath' from 'flashlight.lib.sequence.criterion'
Then I go deeper into the problem and find out in infer.py file that when I import in python
from flashlight.lib.text.dictionary import create_word_dict, load_words
it works fine. However when I try to import
from flashlight.lib.sequence.criterion import CpuViterbiPath, get_data_ptr_as_bytes
it raises an exception of
ImportError: cannot import name 'CpuViterbiPath' from 'flashlight.lib.sequence.criterion'
I am using the latest fairseq, sequence and text packages.

Duplicate of https://github.com/flashlight/sequence/issues/19. Fix is landing now.


Add Graphite data port for easy use by nc

I had to make changes to push in data via nc as described in the Graphite tutorial here.
http://graphite.readthedocs.io/en/latest/feeding-carbon.html

@ScalaWilliamTeralytics  thanks for proposing this PR


"Could not find the preLaunchTask 'npm: watch'." issued when failed to parse 'package.json'

I was developing an extension.
After I had accidentally added a comment line like '//...' in the package.json, pressing F5 wouldn't start the debugger.
The error information was "Could not find the preLaunchTask 'npm: watch"
I understand comment should not appear in json file. However, maybe more comprehensive error message could be given, then I would have discovered the problem easier.

VSCode Version: Version 1.17.2 (1.17.2)
OS Version: 10.13 (17A405)

Steps to Reproduce:

add a comment line like '//...' in 'package.json'
run 'code .' in the source folder of an extension
press F5 to start the debugger mode
Error is issued with message "Could not find the preLaunchTask 'npm: watch'."

Reproduces without extensions: No

this problem tell me,package.json not allow '//'

@isidorn, @dbaeumer  just use this package.json:
{
  // an illegal comment
  "name": "corrupt",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "test": "echo hello"
  }
}

and this launch.json:
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${workspaceFolder}/test.js",
            "preLaunchTask": "npm: test"
        }
    ]
}

F5 results in this error:

All tasks in a package.json with syntax errors are invalid and should result in a more informative error message.

The npm task provider is now rejecting the promise and the task framework is exposing the failure in the output channel.

Verified that the package.json parsing error shows up in the output channel:

However, the error message is still not helpful.
@egamma @dbaeumer @isidorn would it make sense to add 'Please check
the Output channel for errors.' to the message?


License and Readme updates

Need to merge license and readme updates to master

I guess an easier way would be to rebranch master from development?


FW-935 FW-1046 Create unpublished changes service, endpoint operation, enricher

These changes create a service which can be used to check if there are unpublished changes on a document. In addition to the service an endpoint and enricher are provided.
The endpoint is called FVCheckUnpublishedChanges and returns a boolean true if unpublished changes exists. The endpoint calls the service to do the check.
The enricher calls the service and adds a json object which has a key "unpublished_changes_exist" and a true value if the document has unpublished changes, otherwise false.  The enricher could be further developed in the future to return information detailing what items within the document are unpublished.  To use the enricher simple add a call to it in a frontend header such as this line and inspect the fetch response.
eg. change the line to

'enrichers.document': 'ancestry,word,permissions,unpublished_changes',

@davidlacho The requested changes have been made.  Several of the tests have been changed to use abstract test utils classes. Thanks for the review!


enable support for enum arrays

@kns98 thank you so much for PR. This is for stable branch and will be handled in a further moment.
I'm try to catch up to 2.0 project status as now.
Stay tuned and thanks again.
Regards,
Giacomo

What's the status on this please?

Just another request for an update on this


RHIROS-600  Executive report

Description
Jira: https://issues.redhat.com/browse/RHIROS-600
Demo
https://drive.google.com/file/d/18C9-L8u4E2GTl6T4LgShS6cwgPHxXRmu/view?usp=sharing

@PreetiW - As to get PSI enabled systems info will take some time can we include line of information under tables which applies to every situation?
Under pressure conditions can be encountered when systems are having PSI enabled

@kgaikwad  have added the message and pushed the changes 🚀


Rubocop

hound will quickly drive you nuts heheh...  It is really cathartic to yell at though. What's the advantage of adding Rubocop to Travis? I would think that'd have the same effect.

heheheh, maybe hounci should be renamed...
same effect in keeping merges from happening unless rubocop is happy, but without the noise on pull request comments. you only see that travis failed, and when checking the build you'll see the compiled list of rubocop offenses.
that would be just for safety from contributors not running rubocop locally, which is the ideal. Hence my suggestion to add guard-rubocop. be sure to configure it so it only runs once your tests are passing, else you'll find yourself serially catharting and will soon become known as Howling Will from Civic Hall. Or Catharting Bill
("Catharting" has double meaning, btw. Worth googling it)

hahahahahahaha


Not showing disqualified or ejected players if more than one

I have the following code:

	games = nflgame.games(2016, week=9, kind='REG')
	plays = nflgame.combine_plays(games)
	all_penalty = plays#.filter(penalty=True)

	for penalty in all_penalty:
		lowered = str(penalty.desc).lower()
		if "disqual" in lowered or "eject" in lowered:
			print('')
			print "Play: ", lowered
			print  "Players in play: ", penalty.players
			print('')
		pGSIS_ID = str(penalty.drive.game.eid)
		pQuarter = str(penalty.time)[:2]
		pPenalty_yds = str(penalty.penalty_yds)

It comes back with the following data:
Play:  (12:55) (no huddle, shotgun) c.kessler pass incomplete short left to a.hawkins. penalty on dal-d.irving, disqualification, offsetting. penalty on cle-c.erving, disqualification, offsetting. both dal #95 irving and cle #74 erving  are ejected
Players in play:  [C.Kessler, A.Hawkins]

Play:  (11:18) (shotgun) n.foles pass incomplete short middle to t.kelce (p.amukamara). penalty on kc-t.kelce, unsportsmanlike conduct, 15 yards, enforced between downs. penalty on kc-t.kelce, disqualification, 15 yards, enforced between downs.
Players in play:  [N.Foles, T.Kelce, P.Amukamara]

As you can see, if only one player was ejected, then it shows correctly, but if more than one player is ejected, it won't show those player as part of the play.
Is there something I'm doing wrong, or a better way of doing this?

One other thing.  I'm also using NFLDB, so if that would be better, please let me know how I should code that.

The first step to debug this is to look at the raw JSON data. If the player isn't recorded there, then nflgame has no hope of doing it correctly. Please remember that the undocumented JSON that nflgame uses from NFL.com isn't 100% accurate. You'll need to dig and figure out where the discrepancy is.

Kelce recorded a stat on the play you list (he recorded a .receiving_tar).
Neither Irving nor Erving recorded any statistics in the play they were involved in. As far as nflgame is concerned, they were involved in that play just as much as you or I was.

Okay.  Thanks for the info.


Elasticsearch 5.x bulk response

Items returned in Elasticsearch 5.x might have a property "index" instead of "create" - both should be checked.
https://github.com/mcollina/pino-elasticsearch/blob/master/pino-elasticsearch.js#L56

https://github.com/mcollina/pino-elasticsearch/commit/358a3d746cfbc56a6e03c7cff68fdfc40273dc79 included in PR https://github.com/mcollina/pino-elasticsearch/pull/5

Fixed in #5


Event log priority validation

[ ] Recently observed event logs are getting logged with high priority only.

[ ] Had a suspect and requested @SrideviRamesh to try out that and based on the test even recoverable error also logs as high priority only.

This is taken care in development code and verified in GUI as well,  where I had opened a GHE issue. So closing it.


can't use  $_SESSION global variable in the Pusher class.

i'm going to make a private chat so for example i have usr1 and usr2 to chat with each other.
In function onSubscribe() i set $subscribedTopics array key to be "usrid1,userid2" to broadcast to them any message sent to this topic.
So in the onSubscribe() function when user1 subscribes the array key will be set using userid2 concatenated to $_SESSION variable (which contains user1 id).
but problem is that $_SESSION variable is empty when i use it in the Pusher class.
there is other issue : i want to change the id of Topic object because if i set the topic as "usrid1,usrid2" in usr1 client script then this topic must set exactly the same and in the same order in the usr2 client script so it can't be "usrid2,userid1".

All global $_ variables can not be used in a Ratchet application. Those variables are typically filled via FCGI on a per-user bases but Ratchet applications house more than one user session; the scope of global variables is that of the application not of an individual user.


Reflectively invoking composables pt 1 - SDK

Reflectively invoking composables pt 1 - SDK
tmp dir
ignore reflective test
Data model
Adjustments for parameterized test
Adjust/safe
Use parameterized for reflective invoker

#126
#125
#124
#123  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Photos do not always fill view

I am having an issue where the animated photo will start in a position that leaves white space around the photo that is being animated. The animation usually moves the photo to fill the space. This happens regardless of the isLandscape flag.
I am using the version from cocoaPods.

I have the same problem with low-resolution images.

I have the same problem. We should always check that the image is actually in the screen.
I also have empty space sometimes.


[Suggestion] Update the Milvus bootcamp page.

Note: This repository is ONLY used to solve issues related to DOCS.
For other issues, please move to other repositories.

Is there anything that's missing or inappropriate in the docs? Please describe.
Please update the Milvus bootcamp page by adding DNA Sequence classification.
Describe your suggestion
For EN site:
Title: (EN) DNA Sequence Classification
Text: Build a DNA sequence classification model using Milvus paired with CountVectorizer
For CN site:
Title: (EN) DNA 序列分类
Text: 使用 Milvus 与 CountVectorizer 搭建 DNA 序列分类模型。
Additional reference
! We might also need the help from UED team to provide the graphic icon for this new bootcamp.

I have submitted PR #655.
In addition,  it needs to provide an icon named DNA_CLASS, which is the iconType I defined in the PR.


Corrections for direct printer firmware typeface flags

What steps will reproduce the problem?

1. Epson.set('center','A','NORMAL',2,2)

   ( The typeface is tall and not wide;
     double width and height is a single 0x30 flag,
     not 0x10 and 0x20 in sequence;
     0x20 ends up cancelling 0x10. )

2. Epson.set('center','U2','NORMAL',2,2)

   ( a stale constant for turning off Italic remains;
     this is not defined in constants.py; therefore,
     delete this line )

What is the expected output? What do you see instead?

1. For text that should be quad area, I see
   Text that is tall, and not wide

2. For normal weight with strong underline,
   I see A NameError:

>>> Epson.set('center','A','U2',2,2)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/escpos/escpos.py", line 206, in set
    self._raw(TXT_ITALIC_OFF)
NameError: global name 'TXT_ITALIC_OFF' is not defined

What version of the product are you using? On what operating system?

$ hg summary
parent: 12:849dabb63ce0 tip
 Added syntax to have print working on windows
branch: default
commit: 2 modified, 5 unknown
update: (current)

$ uname -imrs
FreeBSD 9.2-RELEASE i386 GENERIC

Please provide any additional information below.

  diff attached in hg-diff-escpos.txt;

  constants.py:
    1. I have introduced a suggested fix for quad area characters,
    in the form of a new constant, "TXT_4SQUARE".

  escpos.py:
    1. For quad-area characters, reset to normal first,
    then send only one flag to activate double width and height.

    2. The deprecated constant, "TXT_ITALIC_OFF", is removed.

This was verified on an Epson TM-H6000, IEE-1284 (parallel)
  Epson = printer.File("/dev/lpt0")

Thank you for this library. I look forward to extending it
if I am able to.

Thanks as well to the developers of Mercurial;
an R.C.S that works, just as the developers intended.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 10 Dec 2013 at 4:03
Attachments:

hg-diff-escpos.txt

main issue should already be fixed in master

Hello,
First of all thank you for the hexadecimal commands they have been helpful. However, I'm encountering an issue with slip mode printing. I would like users of my application to be able to print checks. However, I can't seem to rotate the content for printing from top to bottom. I used the command "0x1B,0x54,0x03," but it doesn't seem to work.
Any ideas ?
``const command = {
SET_PRINT_ROLL:[0x1B,0x63,0x30,0x03],
SET_PRINT_SLIP:[0x1B,0x63,0x30,0x04],
PAPER_SLIP_OUT:[0x1B,0x4B,0xC0],
ALIGN_RIGHT:[0x1B,0x61,0x02],
SET_VERTICAL_PRINT:[0x1B,0x54,0x03],
}
const connectSlip = async () =>{
console.log('ok')
//connexion to slip mode
await new Promise((resolve) => {
    serialPort.write(command.SET_PRINT_SLIP, resolve);
});

//align the text to the right
await new Promise((resolve) => {
    serialPort.write(command.ALIGN_RIGHT, resolve);
});

//active the page mode
await new Promise((resolve) => {
    serialPort.write([0x1B,0x4C], resolve);
});

//rotate the text
await new Promise((resolve) => {
    serialPort.write(command.SET_VERTICAL_PRINT, resolve);
});

//send the message to print
await new Promise((resolve) => {
    serialPort.write('Hello', resolve);
});

//throw the paper out
await new Promise((resolve) => {
    serialPort.write(command.PAPER_SLIP_OUT, resolve);
});

//send back to the receipt mode
await new Promise((resolve) => {
    serialPort.write(command.SET_PRINT_ROLL, resolve);
});

}
``


TMP try-catch

Functionality has been verified. Dialog box shows up and the updater is still active.

Great call with this function.