Reintroduce buttons in top toolbar

Compared to version 4.8.1, in version 4.9.0 the buttons related to file actions, such as open, save, and save as, as well as the undo/redo buttons were removed.
Why? From your perspective, what are the benefits for users not having these items easily accessible?
In my opinion the usability suffers, now that one needs to constantly use the file menu items to open a bmpn or dmn file in the last used folder, for example.
If there are good reasons to remove the buttons by default, please make the toolbar at least configurable, so that users can readd them as they deem necessary.
Otherwise, please revert to the previous top toolbar where open, save, save as, and undo redo buttons where available.
Thank you!

What you're seeing shipped with v4.9 is the first step towards a toolbar-less modeler and I'm happy you share your feedback here.
Could you use the bug report template and add a little bit more context? Especially the details regarding your operation system would be interesting.
As a follow up question, are you aware of the keyboard shortcuts for all these actions?

Are you aware of the keyboard shortcuts for all these actions?

Any chance to follow up on my question?

I added a post in Camunda Forum before see this issue because after some days working with 4.9.0 I still need buttons back :-D

Are you aware of the keyboard shortcuts for all these actions?

Yes, but it isn't the same thing.

The benefit once the toolbar is gone entirely is that you as the user will have additional space to do the actual work.

Personally I prefer to have the toolbar with the tools I use more than additional space to do the actual work

/CC @andreasgeier

Maybe you could make the toolbar optionally toggleable?

Thank you for your feedback.
Which OS do you use? Under Linux and Windows, these actions are just 20px away in the app menu if you don't like keyboard shortcuts.
As nikku already mentioned we are planning to move the Modeler towards a modeling IDE with a lean UI and exciting new features for developers. If you look at other IDEs such as VSCode, Atom, etc. you won't find space-consuming toolbars with standard actions like open, save, undo etc.
We hope this will be appreciated by our users and we will carefully listen to all voices over the next months to understand how well this and upcoming changes will be received.

Thanks for jumping in @andreasgeier.
I'll close this issue as wontfix for the moment. We'll carefully listen to further feedback.


Add quill html editor

Tutorial didn't say how to show full toolbar. The get started guide only gives two button toolbar.


unexpected crash in input_coeffs.py

Some months ago I used pyfda to create a halfband decimator filter, and I saved it into a .npz file.
Everything worked fine.
Now I can load the same file, but when I click on "b,a"

pyfda crashed immediately.
In my Windows 10 terminal I can see the following error messages
[   INFO] [pyfda.libs.pyfda_io_lib:1357] Successfully loaded filter
        "D:/.../halfband_fir_decimator_by2.npz"
Traceback (most recent call last):
  File "C:\Users\username\AppData\Local\Programs\Python\Python39\lib\site-packages\pyfda\input_widgets\input_coeffs.py", line 325, in process_sig_rx
    self.load_dict()
  File "C:\Users\username\AppData\Local\Programs\Python\Python39\lib\site-packages\pyfda\input_widgets\input_coeffs.py", line 661, in load_dict
    self.qdict2ui()  # set quantization UI from dictionary
  File "C:\Users\username\AppData\Local\Programs\Python\Python39\lib\site-packages\pyfda\input_widgets\input_coeffs.py", line 795, in qdict2ui
    self.refresh_table()
  File "C:\Users\username\AppData\Local\Programs\Python\Python39\lib\site-packages\pyfda\input_widgets\input_coeffs.py", line 583, in refresh_table
    self.quant_coeffs_view()
  File "C:\Users\username\AppData\Local\Programs\Python\Python39\lib\site-packages\pyfda\input_widgets\input_coeffs.py", line 448, in quant_coeffs_view
    if fb.fil[0]['fxqc']['QCB']['fx_base'] == 'float':
KeyError: 'fx_base'

I attach here the zip archive with my file halfband_fir_decimator_by2.npz
halfband_fir_decimator_by2.zip

Thanx for reporting and sorry for the delay. I cannot exactly reproduce your error but I do get other errors (I dimly remember fixing something related to the key 'fx_base') so I will look into the issue!

I see this crash with the last official release v0.7.1.
Maybe this is the reason why you can't reproduce it.

Hm, could you perhaps try running the latest release (self-extracting executable for Windows and OSX, Flatpack for Linux)? There will be a new official release soon.

Can you share the link of the release I should try?

I had to rewrite the part for reading and writing filters as numpy arrays with irregular shapes ("ragged arrays") are discouraged / deprecated (https://numpy.org/devdocs/release/1.24.0-notes.html) and have become difficult to handle. Therefore, pyfda v0.8.0 no longer crashes but it also cannot read the old filter format anymore. Sorry aboout that!

Hi @chipmuenk

Therefore, pyfda v0.8.0 no longer crashes

This is not 100% true, unfortunately.
If I open my old halfband_fir_decimator_by2 filter, pyfda shows the error message
[ ERROR][14:43:34.367] [pyfda_io_lib.py:1576] Missing key 'zpk' or wrong data type!
and it doesn't crash.
This is ok.
But as soon as I clock on b,a tab, pyfda crashes with the following error
Traceback (most recent call last):
  File "C:\Users\<username>\AppData\Local\Programs\Python\Python39\lib\site-packages\pyfda\input_widgets\input_coeffs.py", line 159, in displayText
    if fb.fil[0]['fxqc']['QCB']['fx_base'] == 'float':
KeyError: 'fx_base'


/etc/kubernetes/azure.json usage & security implications

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
I was reviewing the helm chart and noticed that the hostPath /etc/kubernetes/azure.json was mounted into the AGIC. This file contains sensitive data such as the cluster identity and secret. See https://github.com/Azure/application-gateway-kubernetes-ingress/blob/ef4765e206de581d4b7b8b796cae1fc3cc0ed99e/helm/ingress-azure/templates/deployment.yaml#L79-L82
AGIC should not require this level of elevation or access. I dug into the code based and found this PR merge https://github.com/Azure/application-gateway-kubernetes-ingress/pull/585/files that added the mount. It sounds like this was done to retrieve some environment data. A preferred approach would be to ask for the data as a helm chart input.

Mounting the above hostPath has implications when using PodSecurityPolicies. A policy specific to AGIC needs to be developed to allow the access to the host file

When enabling Azure Policy for AKS this also causes non-compliance with the 'Kubernetes cluster pod hostPath volumes should only use allowed host paths' policy definition.


Clean up transaction scope in job load script for MySQL

Coverage increased (+0.07%) to 88.609% when pulling a6393d5ea04c2c9b2c55846dd7f689ca5aa85a3f on tgianos:cleanupLoadScript into f956282ea3a3bb3bc86a00a19d734a086a409573 on Netflix:master.


Responsive images with .embed-responsive

Hi!
I've added object-fit: cover to .embed-responsive-item. It's useful, when you want to responsive images with exact ratio.
Demo:
http://jsfiddle.net/jhybufos/
Preview:

Code:

Hi @codecalm,
This is a nice feature, but object-fit: cover is not supported by IE.
Also see https://github.com/twbs/bootstrap/pull/27082


Redigned some node textures and changes a lang file for consistancy

Made the nickel and platinum nodes more consistant with their deepslate counterparts and changed "resource node redstone" in en_us file

Its trying to recommit files I already PR'd just accept this after the other one


Modifying the copy_dir function

Disagree. Do not approve. Retain the current content directory as /home/training.


Add table virtualization

Resolves #63

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a31c02d) 99.06% compared to head (cd0dddd) 98.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   99.06%   98.84%   -0.22%
==========================================
  Files          50       50
  Lines         748      781      +33
  Branches      149      158       +9
==========================================
+ Hits          741      772      +31
+ Misses          2        1       -1
- Partials        5        8       +3

Files
Coverage Δ

jest-setup.js
100.00% <100.00%> (ø)

src/components/ButtonView/ButtonView.tsx
100.00% <100.00%> (ø)

src/components/OptionsVariable/OptionsVariable.tsx
100.00% <100.00%> (ø)

src/components/TableView/TableView.tsx
100.00% <ø> (ø)

src/hooks/useRuntimeVariables.ts
100.00% <100.00%> (ø)

src/types/variable.ts
100.00% <ø> (ø)

src/utils/table.ts
97.72% <100.00%> (+0.13%)
:arrow_up:

src/hooks/useTable.tsx
96.19% <90.90%> (-0.90%)
:arrow_down:

src/utils/variable.ts
98.07% <94.11%> (+3.34%)
:arrow_up:

src/components/Table/Table.tsx
95.23% <83.33%> (-4.77%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Compiler should be able to recompile a file

Problem
Currently, the compiler expects a clean-slate environment and builds the entire program from scratch. However, in the LSP, we want to build the project once and then recompile individual files with the same Context. This isn't possible currently because the compiler returns immediately if it sees a CrateID in the def_map.
Happy Case
We should be able to create a Context once and build the entire project once, then afterwards we should be able to compile a single file given the stored Context.
Alternatives Considered
No response
Additional Context
Ref https://github.com/noir-lang/noir/pull/1891
Would you like to submit a PR for this Issue?
No
Support Needs
No response

+1 Having a checksum for build artifacts is a good stepping-stone here


type: update loading type definition

Please make sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[ ] Make sure you are merging your commits to dev branch.
[ ] Add some descriptions and refer relative issues for you PR.

Stop
Sent from Yahoo Mail on Android
On Mon, May 20, 2019 at 10:23 PM<EMAIL_ADDRESS>wrote:
Deploy preview for element ready!
Built with commit 3401ac1
https://deploy-preview-15635--element.netlify.com
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mizzunderstood72  some detail, please?


Nullable Parameters and .Missing

I have explained the issue quite well here:
https://github.com/aspnetboilerplate/aspnetboilerplate/issues/2355#issuecomment-317635377
Basically, if an attribute is used inside a class which has methods which have nullable parameters (int?) then this causes Castle.Windsor to error because it doesn't seem to want to use null, and instead replaces it with Missing.

I do not know how to properly use Windsor myself, as I have always been using it through Abp.
What's more I do not know if this is MVC controller related, but I can bet that it is.
This is a really standard use case though, and I see it was actually reported a long long time ago by Abp owner himself,
https://github.com/castleproject/Core/issues/45


add interval so that won't DLQ invocation messages

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #585 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   69.62%   69.63%   +<.01%
==========================================
  Files         219      219
  Lines       12317    12319       +2
==========================================
+ Hits         8576     8578       +2
  Misses       3134     3134
  Partials      607      607

Impacted Files
Coverage Δ

cli/cli.go
78.68% <100%> (ø)
:arrow_up:

cli/messages.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3983845...f74f6d3. Read the comment docs.

@samsalisbury Thanks, added CL


Set up workflow to publish Docker images

Copies the workflows and actions from https://github.com/runtimeverification/z3-images
Sets up the Dockerfile to install riscv-gnu-toolchain
Adds a smoke test

@Baltoli any ideas why the test-pr workflow isn't being run here?

Freeman will need to click a button:

Activated now, @Scott-Guest You'll need to kick it to start a run.

@Scott-Guest it looks like the toolchain is too big to run on GitHub-hosted runners, so I've moved it over to self-hosted

You also probably need to make install in the workflow here (shame it takes so long to realise this!).


DeleteMessagesAsync throws 'System.InvalidOperationException'

"Failed to generate the bucket id for this operation"

We'll need a full stack for this.

System.ArgumentOutOfRangeException occurred
HResult=-2146233086
Message=Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
ParamName=startIndex
Source=mscorlib
StackTrace:
at System.Text.StringBuilder.Append(String value, Int32 startIndex, Int32 count)
InnerException:

I wasn't able to reproduce that specific exception, but please check if https://github.com/RogueException/Discord.Net/commit/30067959d74e148e35c3cce3d447b68fb2039125 resolves this.

It still happens

How about https://github.com/RogueException/Discord.Net/commit/84980ad203421f48405ebb9cbab3040b2aedebbf?

That fixed it

Awesome


Bump up dependency versions and cleanup

Summary
This PR bumps up artifact versions dependencies and Maven plug-ins.
This PR also removes unused pom configurations.
Background, Problem or Goal of the patch
N/A.
Design of the fix, or a new feature
N/A.
Related Issue, Pull Request or Code
https://github.com/asakusafw/asakusafw/pull/689
Wanted reviewer
N/A.

BUILD SUCCESS. <jenkins-prb-asakusafw-sdk-104>


my first commit

first commit

@piyushjha97   thnx for contributing , try this year aswell with updated repo and make sure to follow me and star this repo so that you don't miss updates regarding the new changes and issues during Hacktoberfest 2020.


Explicitly test that the number of returned values matches expectations

Current dependencies on/for this PR:

main

PR #29   👈

PR #30

PR #31

This comment was auto-generated by Graphite.

Merge activity

Oct 29, 6:36 PM: @eguiraud started a stack merge that includes this pull request via Graphite.


⚠ Bofrost.de has degraded performance

In b3b7ba5, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1312 ms

Resolved: Bofrost.de performance has improved in 81fbbeb.


751 Email buyers about their recently closed briefs

Ticket: https://trello.com/c/poIdAQc0/751-3-create-script-to-send-emails-to-buyers-with-recently-closed-briefs-at-scheduled-intervals
We want to send emails via Notify to buyers of briefs that closed 4 weeks ago, telling them to award their brief. If they have not responded after 8 weeks (i.e. the brief is still closed), send another email.

Top level script with

required args: the Data API, Notify API, Notify template ID
optional args: list of buyer IDs (for resending failures), date_closed (to send for briefs closed on a specific date), offset days (to allow either 4 weeks or 8 weeks), dry run (to log without calling Notify)

Script to query closed briefs (filtering by user ID list if supplied) and build the context dict to send to the Notify API
2 Notify templates have been created (to allow the 8-week email to be sent to the same user, which Notify would not allow if we used the same template)
Some refactoring of existing functions for DRYness

TODO:

some commits need squashing.
we need to add a 1-liner to the README/docs
Jenkins jobs https://github.com/alphagov/digitalmarketplace-jenkins/pull/34
Change landing page 404 to error message if brief has already been awarded (Briefs FE)
GA events for the award flow forms (in the Briefs FE) https://github.com/alphagov/digitalmarketplace-briefs-frontend/pull/36

@TheDoubleK I've addressed the comments David left - do you want to take a look over this? I can walk you through it tomorrow if necessary. (Some of the commits probably need squashing but I will do that last in case there are any other changes.)

Just realised that we're not sending the lot-slug to Notify so the URL is going to be wrong for some briefs 🙀.

All looks good now, let's get this in... it's been a marathon!
:+1:

Woohoo! Thanks again Kev for your part in this marathon slog of a PR...


feat: add cookies from http session to ws

Why are these changes needed?
As noted in the below issue session affinity doesn't work as expected in a Kubernetes environment if the cookies aren't shared between the http and wss requests. AutoGen is likely to try to establish a WS connection with a kernel that was created in a different pod.
Related issue number
Closes #3311
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Thanks for the fix! Any way to add a test to "replicate" the error you saw with Kubernetes? Even a mock is good enough

Thanks for the fix! Any way to add a test to "replicate" the error you saw with Kubernetes? Even a mock is good enough

Thanks! In regards to testing, I think JupyterClient unit tests would be the easiest approach, though I don't see any explicit tests for that class. We could mock the Jupyter gateway server response to include the set-cookie headers and make sure the WS use them. The problem stated more broadly is about sessions, not specifically Kubernetes. There could be other situations, e.g. auth, where the current implementation would cause problems as well.


Use Decrypt9 for CTR transfer rather than GodMode9

Godmode9 doesn't work for a lot of black screen issues, but Decrypt9 does. Can the CTR transfer guide use Decrypt9 instead?

From what I know, Decrypt9 can work with the NAND header. GodMode9 can do this as well, but it's a manual process

Can there be steps added for this part then? So it could say, if you were doing this because you got a black screen on boot or were otherwise bricked, if you still get a black screen, then do these extra steps? At the moment the only way anyone would ever know to use Decrypt9 to fix it is if they asked on Discord and someone on there knew to tell them, or gbatemp.

There is an issue already for an unbricking guide. #1278

Alright, trying to get a grasp of this. You're talking about using GM9 CTRtransfer to fix a brick, right? That can work, and it also may not. GM9 CTRtransfer was mainly designed to be a less intrusive means of doing a region switch (or otherwise resetting your console)
As far as unbricking goes - that's not what D9 CTRtransfer was designed for either, but it seems to have some limited success there. Still, I won't take 5 minutes to find a brick it cannot fix. The real be all, end all solution here is the Lazarus 3DS script for GM9, which may be part of the guide soon.
Will that solve your issue?

Probably, I don't know much about it, but as it stands you need a working console to get the files required (so it won't work on its own unless the required files are available by torrent), and it says it screws up super-stable 3D on N3DS.

Well... we don't want to go too much off-topic here, right? Just let me say that the "this needs another console" argument is moot. As you know yourself, so does the CTRtransfer, but there, conveniently someone has provided the files for you. Also, Lazarus3DS does not screw up super-stable 3DS on N3DS - whatever bricked you does, and in these edge cases, D9 CTRtransfer won't work anymore anyways. Lazarus3DS just saves what it can (and that's more than D9 does).
Back on-topic - what this issue really is about is: you need a as-good-as-possible unbricking method, and the method currently in the guide does not deliver, corrrect?

The issue is not with GodMode9 or Decrypt9, the issue is how bad your brick is and how lacking the CTR Transfer images are.
CTRTransfer images were designed for downgrading or region switching already functional consoles. They are missing very important things a bricked console may need, such as a proper NAND header, the TWL master boot record, the TWL nand and TWL photos partitions, a working movable.sed, a working SecureInfo and LCD calibration files for your particular 3DS.
 In the absolute worst case scenario where your NAND is so messed up that absolutely no files can be recovered from it, only then the Super Stable 3D on a n3DS would be affected, and that's not due to the process of the revive but due to the severity of your brick.
In most bricks the super stable 3D on n3DS units would be perfectly fine as long as the HWCAL0 and HWCAL1 files are still accessible on your NAND.
I do have pre-prepared images for the Lazarus3DS script that may get added to the guide via torrent for people to use, similar to CTRTransfer images. If a CTRTransfer is not working for you, then please wait to see if an additional "Unbricking" section is added to the guide, modifying the CTRTransfer instructions aren't going to help much.

The issue is that there is a bunch of people with N3DS console on 2.1 (downgraded back during a9lh days and either bricked or forget about it) and that now manage to restore their console thanks to bootNTR. Luma boots into a "failed to mount ctr nand" screen and doing a ctr transfer with gm9 does not restore the original nand header that decrypt9 would store. Doing the ctr transfer with d9 fixes this issue.
The people don't need another 3ds to provide them sensitive unbricking files, they have their secureinfos and lfcs etc., they just need the tool to restore their original nand header backup that is still saved.
And yes, this happens a lot, several times a week.

You got a point there about the header replacement. On the other side... "this happens a lot"? All known methods of downgrading  to 2.1 basically forced you to make a NAND backup, and what you're supposed to do is restore that to your console.
As A9LH and downgrades to 2.1 are by now considered legacy, there really shouldn't be a relevant number of users who did that and managed to lose their NAND backups coming in anymore. (Actually, was there ever? Even back in the days these cases were considered edge cases.)
I'll discuss the further course of action with @Plailect, I guess.

For a long time they didn't force you to make a NAND backup. People didn't make them and I remember people saying "well the guide says to make a backup and people wouldnt skip that would they?" when it was suggested to make the backup mandatory.
Then SafeCTRTransfer came, forced you to make one and (the guide) told you to delete it of the sd after backing it up. A lot of people didn't back it up, deleted it off of the sd -> no backup. Or people panicked on 2.1 and deleted everything off of the sd because "if I empty the sd I'm sure the 3ds will work again".
In the 3ds-assistance channels on the discord server these cases were never "edge cases". As a matter of fact, when I wrote my response 2 hours ago I was helping someone with this exact issue. A quick search in discord shows that there have been 4 of such cases in the past 7 days (possibly excluding those of people that didn't manage to type the error message correctly). Eight months ago I'm willing to bet there were several a day. Sure, it's not as many cases as it used to be, but it still happens.
And yes, I know that there shouldn't be a need for a CTRTransfer at all, but we aren't exactly dealing with the most tech-savy of users at times... so we have to deal with it one way or the other.
I'd be fine with a section in troubleshooting specifically talking about "Failed to mount CTR NAND" and linking to D9 in that one... or maybe a gm9 script or similar can be made to restore the old header backup and we can tell people to do that instead.

I would use a manual GM9 method or script before resorting to outdated and unsupported software. I'll look at this more this weekend.

@olliz0r  it isn't just "Failed to mount CTR-NAND" that Decrypt9 fixes and GodMode9 doesn't. I had an Old 3DS with a black screen/blue light that GodMode9 didn't fix, but Decrypt9 did (which is what prompted me to make the issue).
This might all be a moot point if the unbricking page comes soon (with Lazarus & associated files). If it doesn't, it would be great to get the script with torrents to the required files added to the troubleshooting page so we can direct people there.
One more thing I just thought of, it would be handy to have a page that describes all common bootup problems and how to fix them or links to the correct page. The troubleshooting page could have an entry "bootup issue" that directs them to this page. The ctr transfer page could have a warning on top saying "this page is for upgrading/downgrading, not for fixing bootup issues, please see (link)". Some bootup issues are not proper bricks (e.g. missing/wrong boot.firm or home menu extdata) and others require different solutions to each other.

One of the main things dc9 does with nand backups and restores and ctrtransfers is NAND header backup and restore to 0x400 in NAND which can easily be restored with scripts. (note that gm9 also backs up the NAND header here with the essential.exefs backup however if it detects the existing current NAND header is mismatched like in a 2.1 n3ds then it won't make that backup and the dc9 header is still intact)
# allow nand writes
allow S:/nand.bin
# backup current nand header
inject S:/nand.bin@0:200 0:/nand_hdr_orig.bin
# inject dc9 nand header into current nand header
inject S:/nand.bin@400:200 S:/nand.bin@0


How to get error message when createUserWithEmailAndPassword

In order to get result and error message from 'createUserWithEmailAndPassword', in iOS, we can know exactly the error message from  NSError. How can we do this on Android?
[[FIRAuth auth] createUserWithEmail:email password:password                              completion:^(FIRUser * _Nullable user, NSError * _Nullable error)

When you attach a failure listener to a Task you get an Exception.  For auth operations this will be an instance of FirebaseAuthException
You can use instanceof to see if it's an instance of a specific direct subclass you're interested in like the following:

FirebaseAuthActionCodeException
FirebaseAuthInvalidCredentialsException
FirebaseAuthInvalidUserException
FirebaseAuthRecentLoginRequiredException
FirebaseAuthUserCollisionException

Hope that helps!

Sorry for my poor expression.
Actually, my question is: Can API  correctly feedback  an appropriate message for following cases rather than exception?  (in iOS, these feedback messages could used to show an alert dialog to tell users what to do next)
create

user name has been used
password is too simple

sign

user name does not exist
password is not correct


Purge Database Tables

Currently, the inventory database tables are not purged.  So, they stay in place, and grows over time.  Which makes it harder to navigate and exceeds the database's capacity.  So, we need to provide a way for users to purge these tables.  Possibly by a config value that users can specify.

This is a problem we would like to solve as well :) I'm commenting to remember to get back with ideas later

@blueandgold I am interested in picking this up - my thought is to provide a retention_days property in the inventory section of forseti config, that will cause inventory scan to clean up any snapshot tables older than that time period (basically delete tables like '%_cycle_timestamp')
Is there any other dimension than age in days that should be considered?
Also - do we think the corresponding rows within snapshot_cycles should be cleaned up too? I am not sure if there is any kind of audit benefit of leaving those around, I was leaning toward leaving them just in case because it shouldn't take up much space (<9000 rows per year).
This would be my first contribution to Forseti, let me know if you need any additional artifacts

Hi Victor, thank you for your input here!  Yes, I think that your approach to using a retention_days is more flexible and comprehensive, and will also cover angelo's use case as well.  Please make sure to default it to a state where no data will be purged (perhaps with -1).
Keeping the snapshot data makes sense to me, and preferable as it might be helpful for people to have a sense of when forseti has run previously.  As you pointed out, this is very inexpensive to do as well.
Looking forward to your PR, and please ask any questions!

This also looks good to @angelomellos in PR #1103 .

Already submitted #1129 - per your comment around defaulting, I do this if the directive is missing, but I put a non-zero default in the forseti_conf.yaml.in - would you prefer if I set that to 0 instead of 30 days?

Fixed by #1129


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-23-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 897

Questions ?
Please refer to the Backport tool documentation


how to load spm9998_3.model file?

Dear Mr. Liu,
I'm studying your paper “Hierarchical Transformers for Multi-Document Summarization” and code, and I'm a new learner in this task. Recently, I wanna use your code to run my task which language is Chinese. Now, I have a question and need your help. In your code, there is a file named spm9998_3.model, but I do not konw how to load it and the contents in it.  Could you tell me how to load this file?

Hi, @LGDEMO
In the README file, there is a link to download the vocabulary.
The sentencepiece vocab file is at: https://drive.google.com/open?id=1zbUILFWrgIeLEzSP93Mz5JkdVwVPY9Bf

This is the spm9998_3.model. So you can put the path in the command or set VOCAB_PATH then in command just change to $VOCAB_PATH

Hi, @LGDEMO
In the README file, there is a link to download the vocabulary.
The sentencepiece vocab file is at: https://drive.google.com/open?id=1zbUILFWrgIeLEzSP93Mz5JkdVwVPY9Bf

This is the spm9998_3.model. So you can put the path in the command or set VOCAB_PATH then in command just change to $VOCAB_PATH


I have an issue with this plugin

[2018-4-19 17:53:23] [WeatherStation] Found no current observations
[2018-4-19 17:53:23] [WeatherStation] { response:
   { version: '0.1',
     termsofService: 'http://www.wunderground.com/weather/api/d/terms.html',
     features: { conditions: 1, forecast: 1 },
     results: [ [Object], [Object], [Object] ] } }
[2018-4-19 17:53:23] [WeatherStation] Found no forecast

I use "Valencia, Spain" as location
SOLVED: "location": "pws:IVALENCI181"

The city name should work as well. Maybe just "Valencia".


ai-dialog-open class removed with multiple dialogs

If you open more than one dialog, then closing just one of them will remove the ai-dialog-open css class from body.
The class should not be removed, if there's still a visible dialog.

I'm not sure that opening multiple dialogs is a supported use case.  Asking for some feedback from others on this as it's generally a bad UX pattern.

@jedd-ahyoung Is this fixed by the last change for multiple dialogs?

@PWKad No. Those changes only address the controller and service layers. None of my changes actually addressed any of the renderer concerns - display and rendering of the DOM elements - as I understand that there are future changes coming in. I assumed that those changes would probably fix many of the issues related to display and rendering.

A pretty common use case is having a bigger dialog, e.g. in order to edit something, and then asking for confirmation when the user closes it without saving or so.


Comment out networking section

ship-it

@mesosphere-mergebot ship-it

👿

It looks like it can understand only one command.  Let's enable others.  :-)
This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot integrate-it


Visual Studio Code for MAC automatically remove carriage return when saving the file.

I am using Visual Studio Code 1.41.1 for MAC.
Visual Studio Code for MAC automatically remove carriage return from every line if I save the file. This is an issue if I compare in GIT.
HEX value shows (Example)
0D0A -- original (carriage return + line feed)
0A -- if I save the file in visual studio code
0D0A - if I use another editor (ex: text editor)
Local setup

Remove all extensions
Auto format disabled when save
Open an existing .cs file in VS Code, add few lines  (carriage return + line feed)
Compare files  (mine don't shows carriage return but shows only line feed)

By default we will choose the line feed to use based on OS, you can disable this feature by setting files.eol to \r\n for your workspace.


Update monitor-blob-storage-reference.md

Checked with SME's

[!NOTE]
There is no way to calculate the append blob used capacity directly from the Azure Portal. But you get the Used Capacity of an Append blob by removing the total used capacity of a Block blob capacity from the total used capacity of a page blob, Or through any API.

Also created a WI
https://msazure.visualstudio.com/One/_workitems/edit/17360827

@normesta
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Attempting to follow up internally. Closing for now, pending a response.
#please-close


0.4.1

waiting on https://github.com/kitbagjs/router/pull/202
pushed with git push --follow-tags, looks like it might be pushing the tags from previous releases as well
https://stackoverflow.com/a/3745250/3511012

I believe you'll want to redo this after your other PR is merged to main. Tags reference specific commits. So I bet your tag here is referencing the current HEAD of main and won't include the latest commits when merged.


Text to cad enter key reloads page on prod now (webapp)

https://github.com/user-attachments/assets/00b7b7ab-938a-45e9-aef7-3165846f69fe

this is working fine in chrome, we dont support firefox


Using .NET SNS with Phonegap

Hello,
I have phonegap app and i want to use Amazon SNS service for push notification.
Can't find any good example which is easy to understand and implement. Amazon docs are really confusing in terms of topics, directing user to to google website for GCM etc.
Is there any good end to end working example, blog etc available ?

I have limited knowledge of Phonegap but as I recall it is HTML and JavaScript based so I'm not sure what this has to do with .Net. You should ask on the SNS forums
https://forums.aws.amazon.com/forum.jspa?forumID=72


Perfect Vision in combination with Advanced Drawing Tools breaks the Drawing config

Reported by @WilStead.

Foundry version 10.284
Foundry desktop client
Windows 11 x64
The error below occurs when the modules Advanced Drawing Tools, libWrapper, and Perfect Vision are enabled.
If only Advanced Drawing Tools and/or libWrapper are enabled, no error occurs and the property page opens.
If only libWrapper and Perfect Vision are enabled, no error occurs and the property page opens.
 Fixed in 4.0.3.


Compiling tests with -O3

I enabled -O3, which revealed that the build was failing due to the way float/double conversions were carried out.
$ make test-c
gcc \
	    -Wall \
	    -Wextra \
	    -Wpedantic \
	    -Wlogical-op \
	    -Wdouble-promotion \
	    -Werror \
	    -std=c99 \
	    -O3 \
	    tests/main.c \
	    tests/files/c_source/motohawk.c \
	    tests/files/c_source/padding_bit_order.c \
	    tests/files/c_source/vehicle.c \
	    tests/files/c_source/multiplex.c \
	    tests/files/c_source/multiplex_2.c \
	    tests/files/c_source/floating_point.c \
	    tests/files/c_source/no_signals.c \
	    tests/files/c_source/choices.c
tests/files/c_source/multiplex_2.c: In function ‘multiplex_2_extended_types_encode’:
tests/files/c_source/multiplex_2.c:495:13: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
             s10 = ftoi(src_p->s10);
             ^
tests/files/c_source/multiplex_2.c:509:9: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
         s9 = ftoi(src_p->s9);
         ^
tests/files/c_source/multiplex_2.c: In function ‘multiplex_2_extended_types_decode’:
tests/files/c_source/multiplex_2.c:557:13: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
             dst_p->s10 = itof(s10);
             ^
tests/files/c_source/multiplex_2.c:571:9: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
         dst_p->s9 = itof(s9);
         ^
cc1: all warnings being treated as errors
tests/files/c_source/floating_point.c: In function ‘floating_point_message1_encode’:
tests/files/c_source/floating_point.c:55:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     signal1 = dtoi(src_p->signal1);
     ^
tests/files/c_source/floating_point.c: In function ‘floating_point_message1_decode’:
tests/files/c_source/floating_point.c:91:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     dst_p->signal1 = itod(signal1);
     ^
tests/files/c_source/floating_point.c: In function ‘floating_point_message2_encode’:
tests/files/c_source/floating_point.c:117:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     signal1 = ftoi(src_p->signal1);
     ^
tests/files/c_source/floating_point.c:118:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     signal2 = ftoi(src_p->signal2);
     ^
tests/files/c_source/floating_point.c: In function ‘floating_point_message2_decode’:
tests/files/c_source/floating_point.c:155:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     dst_p->signal1 = itof(signal1);
     ^
tests/files/c_source/floating_point.c:156:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     dst_p->signal2 = itof(signal2);
     ^
cc1: all warnings being treated as errors
make: *** [test-c] Error 1
The command "make test-c" exited with 2.

This change uses a memcpy instead.
I'm not sure if this is truly a portable approach, since apparently float and double representations are implementation defined. I think the DBC assumes an IEEE 754 floating point implementation for encoding/decoding signals. But that's technically not worse than the current behaviour, and I don't know if it's worth the hassle to support implementations of float/double that aren't IEEE 754.

Coverage remained the same at 93.329% when pulling 469f1cf4e430583c045a33e76658c5e7c4ba6a83 on karlding:compiling_with_o3 into d65426be1b608ee709f811b4c0001e8f36ee1e0d on eerimoq:master.


Validation is being ran on unset fields

Versions

NodeJS: 12.7.0
Typegoose(NPM): 5.8.1
mongoose: 5.6.2
mongodb: newest? (its ran on Mongo Atlas)

Code Example
I have an optional field that lets say holds a middle name of a person. It is validated with a regex.
class PersonModel {
	@prop({ validate: /^[A-Z][a-z]+$/ })
	middleName?: string
}

Mongoose allows unsetting fields by assigning undefined to it. Like so:
const person = await PersonModel.findById(userId)

if (!person) throw new Error('error')
person.middleName = undefined
await person.save()

However this fails because: Error [ValidationError]: Person validation failed: Validator failed for path 'middleName' with value 'undefined'
Do you know why it happens?
My guess would be the validation is still being run even tho the field is being unset.

To clarify, setting undefined did unset the field before I added a validation regex to it

validation is not an issue with typegoose, the regexp in this case is passed to mongoose and mongoose runs the validation, sorry

To fix it I added { validateBeforeSave: false } to the .save() call.
@hasezoey if i find time i will check if this happens in mongoose too.

@Ben305 this can be closed as "not an issue with typegoose"

@Ben305 Bump to close


Allow window title color to distinguish between multiple windows

I often have multiple directories open in separate VSCode windows, and wish I could at a glance distinguish between them (like with a random color present in the UI)—although the directory name is already in the title of the window, it often takes me a bit to reorient myself because there is so much text on screen already. Any suggestions on how to more easily distinguish between multiple open files/a possibility to include a feature like this?

Assuming we want a cross platform solution, this requires native API to decorate the window frame color.

If there are too many projects open, colouring the editor window will not work well. I think its best to have project management utility built in which can help you switch between multiple projects. Like an autocomplete for recent and active projects.

https://github.com/Microsoft/vscode/issues/16363


Support Parquet data for HNSWDenseVector

Overview
Adds functionality to run HNSW Indexer with Parquet data. Main functionality added:

json_to_parquet.py
ParquetDenseVectorCollection
ParquetDenseVectorDocumentGenerator

Tested on nfcorpus and robust04 datasets with evals matching.
Steps to reproduce
Env setup

conda create -n parquet && conda activate parquet
cd src/main/python/parquet
pip install -r requirements.txt

Convert data to parquet format and run indexing
Run the following commands from repo root.
Download raw data
wget 'https://www.dropbox.com/scl/fi/1qnwq7s56muwudetqxgez/bge-base-en-v1.5-robust04.tar?rlkey=sd8zt0qnopwgbel43an46bggc&dl=0' -P collections/

Create parquet data
python src/main/python/parquet/json_to_parquet.py --input collections/robust04 --output collections/robust04.parquet/ --overwrite

Create index
bin/run.sh io.anserini.index.IndexHnswDenseVectors -collection ParquetDenseVectorCollection -input collections/robust04.parquet/ -generator ParquetDenseVectorDocumentGenerator -index indexes/parquet-robust04 -threads 16 -M 16 -efC 100 -memoryBuffer 65536 -noMerge

Run retrieval on index
bin/run.sh io.anserini.search.SearchHnswDenseVectors \
  -index indexes/parquet-robust04/ \
  -topics tools/topics-and-qrels/topics.beir-v1.0.0-robust04.test.tsv \
  -topicReader TsvString \
  -output runs/parquet-robust04.txt \
  -generator VectorQueryGenerator -topicField title -removeQuery -threads 16 -hits 1000 -efSearch 1000 -encoder BgeBaseEn15

Run evals
bin/trec_eval -c -m ndcg_cut.10 tools/topics-and-qrels/qrels.beir-v1.0.0-robust04.test.txt runs/parquet-robust04.txt
bin/trec_eval -c -m recall.100 tools/topics-and-qrels/qrels.beir-v1.0.0-robust04.test.txt runs/parquet-robust04.txt
bin/trec_eval -c -m recall.1000 tools/topics-and-qrels/qrels.beir-v1.0.0-robust04.test.txt runs/parquet-robust04.txt

@valamuri2020 good job!
Compare against the safetensor implementation? I'm interested in collection size and also indexing time.

Also -

Submodule tools

Update to latest in master please.

I think it's already updated to the latest? This is what I see at the top of the git log, the commit hash matches what's on the tools repo.
commit 3a2b3cc5cfd915d707408aa5c4567185e9e4544f (HEAD -> master, origin/master, origin/HEAD)
Author: Ronak<EMAIL_ADDRESS>Date:   Wed Aug 7 14:20:18 2024 -0400

    Add RAG 24 Test Topics (#81)

I was just briefly looking at the discussion above, and was wondering whether a subset of the dependencies might be sufficient?
See here: https://github.com/apache/parquet-java?tab=readme-ov-file#add-parquet-as-a-dependency-in-maven
They list 4 separate dependencies, maybe it can work without using the hadoop one?

Also -

Submodule tools

Update to latest in master please.

I think it's already updated to the latest? This is what I see at the top of the git log, the commit hash matches what's on the tools repo.
commit 3a2b3cc5cfd915d707408aa5c4567185e9e4544f (HEAD -> master, origin/master, origin/HEAD)
Author: Ronak<EMAIL_ADDRESS>Date:   Wed Aug 7 14:20:18 2024 -0400

    Add RAG 24 Test Topics (#81)

Yes, this is indeed HEAD. Not sure why your diff is showing this then:

Are you missing a git submodule update somewhere?

Are you missing a git submodule update somewhere?

Nope, running that command didn't update anything.

I was just briefly looking at the discussion above, and was wondering whether a subset of the dependencies might be sufficient?

See here: https://github.com/apache/parquet-java?tab=readme-ov-file#add-parquet-as-a-dependency-in-maven
They list 4 separate dependencies, maybe it can work without using the hadoop one?
Thanks for the idea @arjenpdevries! I gave that a try and it took some digging into. Unfortunately, it seems that hadoop is still tightly involved under the hood. The top level API uses LocalInputFile instead of the HadoopFile, but everything under that is still using hadoop, ex. the configuration. I read through the PR and GitHub Issues, it seems like they plan to decouple them in the future, but nothing that is low-bloat and easy to use right now.

@valamuri2020
% ls -lh target/anserini-0.37.1-SNAPSHOT-fatjar.jar
-rw-r--r--  1 jimmylin  staff   179M 26 Aug 19:23 target/anserini-0.37.1-SNAPSHOT-fatjar.jar

What's the latest update on bloat? 220MB? Is that the best we can do? And have we tried excluding as much as we can?

Yep, 226 MB to be exact. That is pretty close to the best we can do - I went through the mvn dependency tree and removed as many of the transitive dependencies as possible.

Perhaps... https://github.com/strategicblue/parquet-floor (I have not checked myself how good this is)


Added relative imports to vis module for python 3 support

I needed to add these relative imports to get it to work for me on python 3.5.  Are you using 2.x?  Up to you if you want it or not, but I figured since I did it I'd give you the opportunity to use it.
Thanks for the great library!

Thanks for the PR. I was using 2.7, so didn't notice this.


Fix importing patch_decoder

After the latest package fix the patched_decoder cannot be imported. The error when executing the code is
File ~/dev/ml-workspace/timesfm/src/timesfm.py:38
        /dev/ml-workspace/timesfm/src/timesfm.py:36) from praxis.layers import normalizations
        /dev/ml-workspace/timesfm/src/timesfm.py:37) from praxis.layers import transformers
---> /dev/ml-workspace/timesfm/src/timesfm.py:38) from . import patched_decoder
        /dev/ml-workspace/timesfm/src/timesfm.py:39) from utilsforecast.processing import make_future_dataframe
        /dev/ml-workspace/timesfm/src/timesfm.py:41) instantiate = base_hyperparams.instantiate

ImportError: attempted relative import with no known parent package```

This small change will fix the import. I've tested this locally.

Thanks for the fix.


UI/UX - Double click viewport to toggle between full size and grid layout

Hello,
In most commercial PACS viewers you can double click an image (a single viewport) to toggle between the grid layout (eg. 4x4) and full size (single viewport) on that image.  This is useful if measurement is needed to make a single viewport full size.
This question has been asked earlier post by David Connaughton however, no helpful response was given.  Wondering if anyone could shed some light.
Thanks!

Please give an update or any solution for this

Can this be implemented in OHIF V2 ?

Hello, I have implemented this in a branch of my fork of OHIF v2 (https://github.com/jensen0914/Viewers/tree/saincepacs-ohif-viewer). The code is dependent upon other changes, such as reference lines and syncing slices but allows users to double-click on regular and 2D MPR viewports to switch back and forth from full-screen and also adds a toolbar button/command for this.
Todd Jensen, PhD
Jensen Informatics LLC

Hello, Thank you for your help... It would be helpful if you point me to the commits or the files that needs to be changed in order to add the feature to my current viewer, Yogesh Jadhav,Web Dev Sent from Mail for Windows From: Todd JensenSent: 02 June 2023 17:28To: OHIF/ViewersCc: Yogesh Jadhav; CommentSubject: Re: [OHIF/Viewers] UI/UX - Double click viewport to toggle between full size and grid layout (#2269) Can this be implemented in OHIF V2 ?Hello, I have implemented this in a branch of my fork of OHIF v2 (https://github.com/jensen0914/Viewers/tree/saincepacs-ohif-viewer). The code is dependent upon other changes, such as reference lines and syncing slices but allows users to double-click on regular and 2D MPR viewports to switch back and forth from full-screen and also adds a toolbar button/command for this.Todd Jensen, PhDJensen Informatics LLC—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID<EMAIL_ADDRESS>
I highlighted a commit you can start with in the screenshot in my last comment: commit fecf77. Also look at 686de7, 849c5b.

Hi, Thank you for the Help.Implemented the feature in V2.   Yogesh Jadhav,Web Dev From: Todd JensenSent: 02 June 2023 18:08To: OHIF/ViewersCc: Yogesh Jadhav; CommentSubject: Re: [OHIF/Viewers] UI/UX - Double click viewport to toggle between full size and grid layout (#2269) I highlighted a commit you can start with in the screenshot in my last comment: commit fecf77. Also look at 686de7, 849c5b.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID<EMAIL_ADDRESS>
This is implemented already in master branch
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


remove mega_gallery__refresh_time superseded by hot_mode_dev_cycle__benchmark

For code/edit experience we now use hot_mode_dev_cycle__benchmark.
For AOTC we use flutter_gallery__build and complex_layout__build.
/cc @devoncarew

👍 lgtm


Assert that connectedDisplays exist when using description utteranceQueue.

Perhaps like this
Index: js/accessibility/pdom/ParallelDOM.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/accessibility/pdom/ParallelDOM.js b/js/accessibility/pdom/ParallelDOM.js
--- a/js/accessibility/pdom/ParallelDOM.js	(revision 1c6facfc2ecaddfe504f7914db370d7ae80fd35f)
+++ b/js/accessibility/pdom/ParallelDOM.js	(date<PHONE_NUMBER>258)
@@ -2673,6 +2673,11 @@

         const connectedDisplays = this.getConnectedDisplays();

+        // If you run into this assertion, talk to @jessegreenberg and @zepumph, because it is quite possible we would
+        // remove this assertion for your case.
+        assert && assert( connectedDisplays.length > 0,
+          'must be connected to a display to use UtteranceQueue features' );
+
         for ( let i = 0; i < connectedDisplays.length; i++ ) {
           const display = connectedDisplays[ i ];
           if ( display.isAccessible() ) {
@@ -2685,13 +2690,18 @@

       /**
        * Apply a callback on each utteranceQueue that this Node has a connection to (via Display). Note that only
-       * accessible Displays have utteranceQueues that this funciton will interface with.
+       * accessible Displays have utteranceQueues that this function will interface with.
        * @param {function(UtteranceQueue):} callback
        * @public
        */
       forEachUtteranceQueue: function( callback ) {
         const connectedDisplays = this.getConnectedDisplays();

+        // If you run into this assertion, talk to @jessegreenberg and @zepumph, because it is quite possible we would
+        // remove this assertion for your case.
+        assert && assert( connectedDisplays.length > 0,
+          'must be connected to a display to use UtteranceQueue features' );
+
         for ( let i = 0; i < connectedDisplays.length; i++ ) {
           const display = connectedDisplays[ i ];
           if ( display.isAccessible() ) {

Tagging https://github.com/phetsims/utterance-queue/issues/13

Implemented above.


Overhaul Pages and Bytes types

Problems with previous types were found during fuzzy testing.
These types make it simpler to fix linear memory allocation problems in wasmi for 32-bit and 64-bit architectures for edge cases.
Also we get rid of the memory_units dependency which did a lot more things that we actually needed in wasmi.

Codecov Report

Merging #449 (3f8f7ff) into master (8fd6464) will decrease coverage by 0.05%.
The diff coverage is 70.51%.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   79.38%   79.33%   -0.06%
==========================================
  Files          72       72
  Lines        6198     6241      +43
==========================================
+ Hits         4920     4951      +31
- Misses       1278     1290      +12

Impacted Files
Coverage Δ

core/src/units.rs
66.66% <66.66%> (ø)

wasmi_v1/src/engine/executor.rs
98.12% <66.66%> (-0.29%)
:arrow_down:

wasmi_v1/src/memory/byte_buffer.rs
72.72% <68.18%> (-6.23%)
:arrow_down:

wasmi_v1/src/memory/mod.rs
59.34% <77.77%> (-0.66%)
:arrow_down:

wasmi_v1/src/module/utils.rs
86.36% <100.00%> (ø)

wasmi_v1/tests/spec/context.rs
77.98% <100.00%> (ø)

wasmi_v1/src/store.rs
70.54% <0.00%> (-2.85%)
:arrow_down:

..._v1/benches/wasm/wasm_kernel/src/rev_complement.rs

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CRITERION BENCHMARKS

BENCHMARK
MASTER
PR
Diff

compile_and_validate_v1
5.5011 ms
5.4499 ms
:white_circle:  -0.8252%

execute_count_until_v1
2.0224 ms
1.9880 ms
:white_circle:  -1.3218%

execute_factorial_iterative_v1
920.26 ns
965.89 ns
:red_circle:  +5.0415%

execute_factorial_recursive_v1
1.2443 µs
1.2750 µs
:red_circle:  +2.4554%

execute_fib_iterative_v1
4.8087 ms
4.8859 ms
:red_circle:  +1.6495%

execute_fib_recursive_v1
11.140 ms
11.521 ms
:red_circle:  +3.4126%

execute_global_bump_v1
2.8159 ms
2.7106 ms
:green_circle:  -4.0504%

execute_host_calls_v1
30.944 µs
31.985 µs
:red_circle:  +3.4415%

execute_memory_fill_v1
4.0582 ms
4.0828 ms
:white_circle:  +0.6461%

execute_memory_sum_v1
3.8010 ms
3.8462 ms
:red_circle:  +1.1487%

execute_memory_vec_add_v1
8.0508 ms
8.0662 ms
:white_circle:  +0.1672%

execute_recursive_is_even_v1
2.2377 ms
2.2760 ms
:red_circle:  +1.6090%

execute_recursive_ok_v1
295.42 µs
300.36 µs
:red_circle:  +1.6719%

execute_recursive_scan_v1
356.99 µs
366.62 µs
:red_circle:  +2.7166%

execute_recursive_trap_v1
25.476 µs
25.968 µs
:red_circle:  +2.2106%

execute_regex_redux_v1
1.3963 ms
1.4004 ms
:white_circle:  +0.4005%

execute_rev_complement_v1
1.3919 ms
1.3978 ms
:white_circle:  +0.7223%

execute_tiny_keccak_v1
1.2336 ms
1.2493 ms
:red_circle:  +1.3615%

execute_trunc_f2i_v1
1.8026 ms
1.8128 ms
:white_circle:  +0.5401%

instantiate_v1
73.530 µs
73.327 µs
:white_circle:  -0.3675%

Link to pipeline

Could you also consider to extract memoryEntity type as a new crate?

Could you also consider to extract memoryEntity type as a new crate?

i do not see a reason for this. also what does this has to do with this PR?

Could you also consider to extract memoryEntity type as a new crate?

i do not see a reason for this. also what does this has to do with this PR?

I think it may be better to put Pages/Bytes into a wasmi_memory  crate.

Could you also consider to extract memoryEntity type as a new crate?

i do not see a reason for this. also what does this has to do with this PR?

I think it may be better to put Pages/Bytes into a wasmi_memory crate.

Yeah I got that but can you give me a compelling example as to why?

Yeah I got that but can you give me a compelling example as to why?

No examples, simply because I need this crate too :(

Cannot you use wasmi_core instead?


build: fix size check failures

Fixes the size check failures that are breaking master.

Changing to minor because the PR that affected this was not cherry-picked into 10.0.x


fix: file not found in autoload

fix error: Cannot open load file: No such file or directory, emacs/vc/autoload

Thanks for the help!


Parallel build waiting for package forever

E.g. http://ci.ros2.org/job/ci_osx/1874/console and http://ci.ros2.org/job/ci_osx/1875/console
This looks like a bug in the parallel building logic.

Closing since the repo is archived.


Support  HTTPs Active  Health Checks For TLS Passthrough Upstreams

Description
Envoy gateway supports health checks for applications using TLS termination by creating an HTTPRoute and a  BackendTrafficPolicy](https://gateway.envoyproxy.io/latest/api/extension_types/#backendtrafficpolicy).
However, this setup does not work for TLS passthrough. When we define a health check for a TLS passthrough Listerner that has an associated TLSRoute we get the following error.
2024-08-09T01:45:23.429Z        ERROR   gateway-api     runner/runner.go:186    unable to validate xds ir, skipped sending it   {"runner": "gateway-api", "error": "field HTTPHealthChecker.Host should be specified"}
TLS passthrough is common in many organizations where app teams dont want to share the cert in the cluster where envoy gateway is running or where latency is a concern and they do not wish to decrypt and rencrypt.  It is common for an organization to have a common CA cert chain that can be used to validate any certificates created by the compnay's CA, in such cases, appt teams can configure it via a configmap or it can be supplied by cluster admins by default.
This feature request aims to add support for active health checks for tls passthrough applications by using the same mechanism as TLS termination listeners with HTTPRoutes.
The fix seems simple in theory but the devil is on the details. We need to setup the health check hostname for TLS routes just as we do for HTTPRoutes.

HTTPRoute Implementation
TLSRoute Implementation

Validation Function

I would like to work on it. It might take a little while before I am allowed by my compnay's policy to contribute to it

seems like a valid use to support
we probably need to add this line https://github.com/envoyproxy/gateway/blob/eeb62c88f8949f8da8a1278ec5515ffa1a004444/internal/gatewayapi/backendtrafficpolicy.go#L400 for TCP

@arkodg it does not seem that straight forward after looking into it because ir.TCPRoute struct does not have a Hostname filed. Adding one is an option but it would mean creating a separate ir.TCPRoute for each hostname in the TCP listener similar how it is done for HTTPRoutes where a separate ir.HTTPRoute is created per hostname in the listener.
A separate option but perhaps not ideal is set the hostname entry on the health check based on the first SNI hostname inside ir.TCPRoute.TLS.TLSInspectorConfig.SNIs . That however does not seem super stable because there is always a possibility that the first hostname in the SNI config is no longer present in one of the application cert's SANs
What do you think?

hey @muzcategui1106, I think it's fine to set the hostname to ir.TCPRoute.TLS.TLSInspectorConfig.SNIs[0] if ir.TCPRoute.TLS != nil && .......
if that assumption made is wrong, we can revisit the HealthCheck API in the future
wdyt @envoyproxy/gateway-maintainers

@muzcategui1106 does the feature work if we delete the ErrHCHTTPHostInvalid check ?

@arkodg no it does not. there is no hostname field in the health check and the endpoint just becomes UNHEALTHY
I tried doing the the SNI fix we proposed above. That sort of worked, the endpoints became HEALTHY and I saw traffic flowing to my upstream pod coming from envoy-proxy. However, the TLS passthrough listener broke. See the below output. Not sure what is going on there yet.
curl -v --resolve "passthrough.example.com:6443:<IP_ADDRESS>" https://passthrough.example.com:6443 --cacert ca.crt
* Added passthrough.example.com:6443:<IP_ADDRESS> to DNS cache
* Hostname passthrough.example.com was found in DNS cache
*   Trying <IP_ADDRESS>:6443...
* Connected to passthrough.example.com (<IP_ADDRESS>) port 6443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
*  CAfile: ca.crt
*  CApath: /etc/ssl/certs
* TLSv1.0 (OUT), TLS header, Certificate Status (22):
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* (5454) (IN), , Unknown (72):
* error:0A00010B:SSL routines::wrong version number
* Closing connection 0
curl: (35) error:0A00010B:SSL routines::wrong version number

For context we can replicate this by

Setting up this example . Add a SAN to the cert otherwise the healthcheck wont work
create a configmap with the ca cert so you can run the health check TLS verification
Create the following objects

apiVersion: gateway.networking.k8s.io/v1alpha3
kind: BackendTLSPolicy
metadata:
  name: tlsroute
  namespace: default
spec:
  targetRefs:
  - group: ''
    kind: Service
    name: passthrough-echoserver
  validation:
    caCertificateRefs:
    - name: ca
      group: ''
      kind: ConfigMap
    hostname: passthrough.example.com
---
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: BackendTrafficPolicy
metadata:
  name: tlsroute
  namespace: default
spec:
  healthCheck:
    active:
      healthyThreshold: 1
      http:
        path: /
        method: GET
        expectedStatuses: [200, 302]
      interval: 2s
      timeout: 10s
      type: HTTP
      unhealthyThreshold: 3
  targetRef:
    group: gateway.networking.k8s.io
    kind: TLSRoute
    name: tlsroute

@muzcategui1106 can you make the health check e/p http only ?
the addition of BackendTLSPolicy for passthrough-echoserver is adding another tls socket to the cluster which is breaking tls passthrough (which is pure tcp)

@arkodg not sure if I follow. I have the following TLSRoute
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: TLSRoute
metadata:
  name: tlsroute
  namespace: default
spec:
  hostnames:
  - passthrough.example.com
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: eg
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: passthrough-echoserver
      port: 443
      weight: 1

the backend service ultimately directs to an echo server that expects a TLS connection. I can create another port within the service to go the the httpPort but that does not help me here because I cannot configure the TLSRoute to go to a port that expects TLS and a port that doesnt. When connecting to the listener I will ultimately intermittent failures because I would be hitting the http port half of the time
I can configure another TLS route but that would ultimately defeat the purpose of the health check because I am not health checking the targets of the TLS route that is attached to the TLS listener.
Let me know if I am completely wrong here

youre right @muzcategui1106, for TLS Passthrough, the healh check is limited to tcp checks with the current API

what would be your recommendation to enable this in incremental steps. I would not mind working on smaller features first to accomplish this goal. But yeah the way the API is designed does not seem to make it trivial to do :/

Seems like we can use transport_socket_match_criteria  at the healthcheck level. I am going to try to use EnvoyPatchPolicy to see if I can patch the envoy proxy configuration with a new transport socket to match the healthcheck
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/health_check.proto

Seems like we can use transport_socket_match_criteria at the healthcheck level. I am going to try to use EnvoyPatchPolicy to see if I can patch the envoy proxy configuration with a new transport socket to match the healthcheck
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/health_check.proto

yeah that option should help here.
I'm a -1 on exposing this at the API level, because this is not a common use imo, but hoping you can still achieve this using EnvoyPatchPolicy.
lets keep this issue open and see if any others in the community also have such a requirement


[TE] Refactor detection & preview API for better debugging

Looks like there are some issues on detection yaml translation caused by this PR. I'll submit a follow up PR.


[Docs] basic/advance operations and examples; drbd helm charts install; applications

This PR adds following items to the doc

basic/advanced operations and examples
DRBD installation by helm charts
Application scenarios of Minio and TiDB

LGTM


Add missing comma

Add missing comma to the addPlugin with options statement.

Wow, oops, thank you🤦♂.

Released in v1.0.7.
Thanks for catching this and apologies for the inconvenience.


[FEATURE] Security Plugin Navigation Changes

Is your feature request related to a problem?
Coming from: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7029, security dashboards should conform to the new navigation changes coming from core. We should register under the category "Data Administration"
What solution would you like?
Registering under "Data Administration" group if the feature flag Nav Groups is enabled
What alternatives have you considered?
None
Do you have any additional context?
No

[Triage] Hi @derek-ho thank you for filing this issue. Going to mark as triaged.


compression/decompression error

When compressing and then decompressing a test file, I don't get the original file back:
$ ./zstd -V
*** zstd command line interface 64-bits 0.6.0, by Yann Collet ***
$ ./zstd test -o test.zst
Compressed 10688440 bytes into 4209313 bytes ==> 39.38%
$ ./zstd -d test.zst -o test.decoded
Successfully decoded 10688440 bytes
$ cmp test test.decoded
test test.decoded differ: byte 2588022, line 3678
$ ls -l test*
-rw-r--r-- 1 ghood staff 10688440 Apr 19 14:12 test
-rw-r--r-- 1 ghood staff 10688440 Apr 19 14:25 test.decoded
-rw-r--r-- 1 ghood staff  4209313 Apr 19 14:24 test.zst
$ md5sum test*
21c75c134b09e734bd4d5b78e749b1fd  test
6e5dcc872da801fd07103fba6a7ee097  test.decoded
83dad083093ae38d3838de71666ff024  test.zst
$ uname -a
Linux axon 3.13.0-43-generic #72 SMP Mon Jan 12 10:50:11 EST 2015 x86_64 x86_64 x86_64 GNU/Linux
The zipped test file is attached.
test.zip
Anyone know what is going wrong?
Thanks.
--Greg

Looks the but was introduced with v0.4.6, it works as expected with v0.4.5

I confirm both reports : the test file fails round-trip test at -1 setting for all versions starting v0.4.6.
Now onto bug chasing ...

Preliminary assessment :
This looks like an error in the huffman decoder.
The guilty byte is right in the middle of a long literal section. So the problem seems unrelated to match finding and decoding. It could happen with any compression mode, and it just randomly happens here at -1 setting and after v0.4.6 changes "by chance".
huff0 has an internal fuzzer to experience and test as many strange situations as possible, but somehow it did not found this one. I believe a first task would be to create a test which reproduce the problem. This would make it possible to both control its correction and continuously check in future versions that it remains safe.

The guilty code is the quad-symbol huffman decoder.
I quickfix is to disable this code (typically by commenting this line .
Now, of course, a better fix is to find the bug and fix it.
And as said, an even better outcome is to find a way to trigger the bug without relying on a 3rd party data blob. Which is not that easy : this really looks like a limit condition which is not trivial to create by hand.

The good news is it's not data corruption. Thanks for the workaround. BTW, I don's notice speed difference.

The quad-symbol decoder is only enabled when certain conditions are met (large huffman block, good enough compression ratio). Therefore in many circumstances, it's not even used. Even when it is, the difference in total decompression speed is typically small, because it's only a fraction of the work. Only pathological cases can see noticeable speed differences.

Thanks for the workaround!  After commenting out that line, I have so far put about 1TB through the decompressor without errors.

Latest update of the "dev" branch should fix this issue,
both for current decoder, and for legacy decoders.

Fixed in v0.6.1


Blueprints get duplicate namespace prefixes in tests

I am initializing the app several times in my tests, and after upgrading to 0.23.0 I noticed that the tests have started to fail, with procrastinate.exceptions.TaskNotFound:
ERROR [procrastinate.worker] Task was not found:
    Task cannot be imported.

Traceback (most recent call last):
  File "/Users/krisb/Library/Caches/pypoetry/virtualenvs/file-processing-trigger--C-Yay8K-py3.9/lib/python3.9/site-packages/procrastinate/worker.py", line 206, in find_task
    return self.app.tasks[task_name]
KeyError: 'mediabank_ingest:trigger_ingest'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/krisb/Library/Caches/pypoetry/virtualenvs/file-processing-trigger--C-Yay8K-py3.9/lib/python3.9/site-packages/procrastinate/worker.py", line 169, in process_job
    await self.run_job(job=job, worker_id=worker_id)
  File "/Users/krisb/Library/Caches/pypoetry/virtualenvs/file-processing-trigger--C-Yay8K-py3.9/lib/python3.9/site-packages/procrastinate/worker.py", line 213, in run_job
    task = self.find_task(task_name=task_name)
  File "/Users/krisb/Library/Caches/pypoetry/virtualenvs/file-processing-trigger--C-Yay8K-py3.9/lib/python3.9/site-packages/procrastinate/worker.py", line 208, in find_task
    raise exceptions.TaskNotFound
procrastinate.exceptions.TaskNotFound:
    Task cannot be imported.

I noticed when debugging the tests that my tasks had duplicated their prefixes:

I have a function scoped fixture that returns the app, which is created this way
def get_worker_app(connector):
    app = procrastinate.App(connector=connector)
    app.open()
    app.add_tasks_from(debug_to_disk.bp, namespace=module_to_namespace(debug_to_disk.__name__))
    app.add_tasks_from(mediabank_ingest.bp, namespace=module_to_namespace(mediabank_ingest.__name__))
    return app

@pytest.fixture
def app():
    app = get_worker_app(connector=InMemoryConnector())
    yield app
    # Reset the "in-memory pseudo-database" between tests:
    app.connector.reset()

So this gets called multiple times. It seems like the blueprint persists the name of the task, including the prefix.
Here's the blueprint:
bp = Blueprint()

@bp.task(name="write_to_file")
def write_to_file(path: str, content: str):
    pathlib.Path(path).write_text(content)
    logger.info(f"Wrote content to: {path}")

I've been able to work around this by having a reset_blueprint fixture, that I'm using now:
@pytest.fixture
def reset_blueprints():
    # rerun imports, to get a reset blueprints, else they will persist data from previous runs
    importlib.reload(file_processing_trigger.tasks.debug_to_disk)
    importlib.reload(file_processing_trigger.tasks.mediabank_ingest)

@pytest.fixture
def app(reset_blueprints):
    ...

I'm not sure if this is a bug, or something else but importlib.reload seems like a workaround.
Sorry about no proper reproducer, let me if that's needed and I can try to set that up.

Hello !
Thanks for the bug report ! I'm not that surprised to see thins kind of behaviours as the namespacing feature had not been written with the tests in mind. I'll see if I can get a fix out there.

Here's how it's done in the procrastinate codebase, and it's suboptimal :/
https://github.com/procrastinate-org/procrastinate/blob/a30a514cc68a7535e67729baba5d692ef21f4a5b/tests/conftest.py#L170-L175

Ok, so the problem is that when we register a task, its name is updated with the new name.
This side-effect is problematic, but it's necessary to do task.defer()
One simple (but wrong) solution could be to adapt the utils.add_namespace function to not do anything if the namespace is already present on the function. But I believe it would be the wrong solution.
I believe there might be a solution where we keep a (weak) ref to blueprints & apps in the tasks, and compute the name dynamically depending on what self.blueprint points to.
I've made a failing test, now it's time to brainstorm :)


chore(deps): update goreleaser/goreleaser docker tag to v1.21.2

This PR contains the following updates:

Package
Update
Change

goreleaser/goreleaser
patch
v1.21.0 -> v1.21.2

Release Notes

goreleaser/goreleaser (goreleaser/goreleaser)
v1.21.2
Compare Source
Changelog
Bug fixes

26fed97: fix(git): error when pushing to a git repo with no branch (@caarlos0)

Full Changelog: https://github.com/goreleaser/goreleaser/compare/v1.21.1...v1.21.2
Helping out
This release is only possible thanks to all the support of some awesome people!
Want to be one of them?
You can sponsor, get a Pro License or contribute with code.
Where to go next?

Find examples and commented usage of all options in our website.
Reach out on Discord and Twitter!

v1.21.1
Compare Source
Changelog
Bug fixes

8220049: fix: git client should respect specified branch (#4324) (@caarlos0)
41ce3c0: fix: git.ignore_tags not working (#4322) (@caarlos0)
41c21dc: fix: only log skips if something is actually being skipped (@caarlos0)
74eba9e: fix: skips log on goreleaser build (@caarlos0)

Other work

e194d4c: docs: draft 1.21 announcement (#4310) (@caarlos0)
74b226d: docs: reword (@caarlos0)
800ee69: docs: update announcement blog post (@caarlos0)

Full Changelog: https://github.com/goreleaser/goreleaser/compare/v1.21.0...v1.21.1
Helping out
This release is only possible thanks to all the support of some awesome people!
Want to be one of them?
You can sponsor, get a Pro License or contribute with code.
Where to go next?

Find examples and commented usage of all options in our website.
Reach out on Discord and Twitter!

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 5.2.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Split "MATCHES" filters and sets the value to lowercase

Matches filters stop working when there are spaces in the query, they don't
match anything.
One workaround is to split by spaces and use a separate query:
e.g. tags.display_name LIKE "foo bar" =>
( tags.display_name matches foo and tags.display_name matches bar )
Setting it as draft, because not sure if this is what we really want, having spaces in this filter won't match the values in order:
e.g. foo bar will match ETCfoo barETC and ABCfooETC bla barblabla

I don't think we want to consider hosts that have spaces in the name. Which is what i was using to test. closing for now.

I don't think we want to consider hosts that have spaces in the name. Which is what i was using to test. closing for now.


Is the code Tensorflow 1.x or tensorflow 2.x?

I would like to thank you for your interesting work.
Is the code Tensorflow 1.x or tensorflow 2.x?

I only test under tf 1.15 and tf 2.1.


computeTargetMesh_test_samples.py cannot generate .ply file

Hi, thank you for publishing this excellent work.
I followed the installation steps in the README.md, and when I ran the eval_samples.sh script, only 1a0q_protein_processed_8A.pdb was generated. Additionally, the computeTargetMesh_test_samples.py seems to generate a 1a0q_protein_processed_8A.ply file.
To troubleshoot, I added the line print(f"Error processing {target_filename}: {e}") in the except block of computeTargetMesh_test_samples.py to capture specific error messages. The output showed the following error:
Error processing /home/fancy/SurfDock-master/data/eval_sample_dirs/test_samples/1a0q/1a0q_protein_processed.pdb: [Errno 2] No such file or directory: '/home/caoduanhua/softwares/transfer/APBS-3.4.1.Linux/bin/msms'.
It seems like the script is looking for msms at a specific location. Do I need to install msms in order to run the eval_samples.sh script properly?
I'm new to this field, so my questions may seem basic, but I appreciate any guidance you can provide.

I encountered exactly the same issue as you and took the same approach. Would it be convenient to exchange contact information for further discussion?

Hi, thank you for publishing this excellent work.
I followed the installation steps in the README.md, and when I ran the eval_samples.sh script, only 1a0q_protein_processed_8A.pdb was generated. Additionally, the computeTargetMesh_test_samples.py seems to generate a 1a0q_protein_processed_8A.ply file.
To troubleshoot, I added the line print(f"Error processing {target_filename}: {e}") in the except block of computeTargetMesh_test_samples.py to capture specific error messages. The output showed the following error: Error processing /home/fancy/SurfDock-master/data/eval_sample_dirs/test_samples/1a0q/1a0q_protein_processed.pdb: [Errno 2] No such file or directory: '/home/caoduanhua/softwares/transfer/APBS-3.4.1.Linux/bin/msms'.
It seems like the script is looking for msms at a specific location. Do I need to install msms in order to run the eval_samples.sh script properly?
I'm new to this field, so my questions may seem basic, but I appreciate any guidance you can provide.

I tried installing the Docker version of Masif separately and successfully generated the PLY files. However, I haven't figured out the ligand preprocessing method yet.

Hi, thank you for publishing this excellent work.
I followed the installation steps in the README.md, and when I ran the eval_samples.sh script, only 1a0q_protein_processed_8A.pdb was generated. Additionally, the computeTargetMesh_test_samples.py seems to generate a 1a0q_protein_processed_8A.ply file.
To troubleshoot, I added the line print(f"Error processing {target_filename}: {e}") in the except block of computeTargetMesh_test_samples.py to capture specific error messages. The output showed the following error: Error processing /home/fancy/SurfDock-master/data/eval_sample_dirs/test_samples/1a0q/1a0q_protein_processed.pdb: [Errno 2] No such file or directory: '/home/caoduanhua/softwares/transfer/APBS-3.4.1.Linux/bin/msms'.
It seems like the script is looking for msms at a specific location. Do I need to install msms in order to run the eval_samples.sh script properly?
I'm new to this field, so my questions may seem basic, but I appreciate any guidance you can provide.

hi , thanks for your issue , you need to install APBS-3.0.0, pdb2pqr-2.1.1 on your computer. Then set the msms_bin, apbs_bin, pdb2pqr_bin, and multivalue_bin path directly in your ~/.bashrc, or just set them in the scripts when creating the surface file from the pdb file.


TestPlan format

Current test plan that is in pdf format has all the columns scatted and it is bit difficult to view together for the listed feature and correlate corresponding description, test & checkers and comment columns information.
https://github.com/chipsalliance/caliptra-rtl/blob/main/docs/Caliptra_TestPlan.pdf
Would it be possible to upload xls format (may be the one which contains coverage metrics as well).
I tried to convert pdf to xls format but the outcome is pretty much similar.
Thanks,
Ramesh RP
Quest-Global.

Sent as an email on 6/16


fix(common): show more detailed info about error logged in console

This closes #2854 and closes #2863

I wanted to add tests, but I met same problems with run tests like here:
https://github.com/karma-runner/karma/issues/2903#issuecomment-349901235

Travis build fixed.
See problem with AppVeyor, but seems to not be related with this pull request content

@dignifiedquire
I noticed that AppVeyor fails because it's using master version of useragent (don't know why no one from yarn.lock). I reported this issue in useragent repository:
https://github.com/3rd-Eden/useragent/issues/120

@dignifiedquire any update on AppVeyor build ? It fails on another pull requests as well.

thank you


should move return out of for-loop

https://github.com/LiuXiaolong19920720/simple_net/blob/8ad5f0a38c47ac78fa374b43e6f1b42646a2f264/src/Net.cpp#L389

@nalinaly Fixed.  Thank you.


chore: remove redundant word in comment

Motivation
remove redundant word in comment

Solution

Hi @wangjingcun, thanks for your contribution
Unfortunately it is stated in our contribution guidelines that we do not accept corrections to spelling / grammer due to misuse, see: https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#contributions-related-to-spelling-and-grammar
You are welcome to make other contributions

Thanks for your reply.


DI gym_anytrading reward and profit functions are wrong..?

In https://github.com/opendilab/DI-engine/tree/main/dizoo/gym_anytrading/envs the profit and reward function logic is all wrong..?

In the profit calculation you would have to multiply the profit from long trades with that of short trades (not add them together).
Also, reward for long would be:
log((close_curr / close_pre) * cost) - wouldn't it?
And for short:
log((close_pre / close_curr) * cost) ?
Am I wrong here or does the current logic not make any sense? Also, what is the reason for taking the natural logarithm? Why not keep reward as (close_curr / close_pre) * cost for long and (close_pre / close_curr) * cost) for short?

1.Indeed, it's right to multiply the profit from long trades with that of short trades. Thank you for your correction, we will make modifications.
2.For the calculation of short selling, imagine two timestamps t1 and t2:
The closing price is close1 at time t1 and close2 at time t2.
At t1, agent has capital M in hand, it can borrow M/close1 stock from the broker and sell it, and it needs to buy M/close1 stock at t2 to pay back the broker. The net profit of agent from t1 to t2 is $\frac{M}{close1} * close1 - \frac{M}{close1} * close2$,
and the yield rate is (net profit + M)/M, so for short:
$\frac{\frac{M}{close1} * close1 - \frac{M}{close1} * close2 + M}{M} = 2 - close2/close1$
3.The effect of natural logarithm is to transform multiplication into accumulation. The optimal goal of reinforcement learning is to maximize cumulative reward. We set reward = log(profit), so that maximizing $\Sigma reward$ is equivalent to maximizing $\prod profit$


Redux Integration (ControlledRouter)

Hi, we are starting to migrate from Angular to React+Redux, and we are planning on using a routing system, but the old version of ReactRouter had some issues when using Redux. V4 seems a lot better for that, and in the faqs you talk about a ControlledRouter close to being published, but I can seem to find it.
We (me and the other developers) would like to help you with the development, since is essential to out product, where can we find the ControllerRouter and how can we help??
Cheers
PS: I mention @JulianMayorga since he is one of my teammates.

We don't have anything here. But it would be a great addon library. I would be more than happy to give up the react-router-redux repo or have it live on that project.

From the FAQ:

We have a  close to being published that makes redux integration with React Router the same as ... uh ... integrating an  with Redux.

I'm a little confused now.

@nhagen There's nothing here, as in "on this repo" here. Addons like ControlledRouter or static, top-level routes are not going into the core of 4.0. They will be externalized in same way. This might end up being a monorepo (Babel-style) or they might get their own separate repos. Nothing's been decided yet and all of this stuff is still very much in progress.

I know that @ryanflorence has done some work on a <ControlledRouter> and was planning to release it as an addon. But we could possibly put it in the react-router-redux project too.

I'm a little confused now.

Don't be :) The API for a <ControlledRouter> looks like this:
<ControlledRouter location={ pathname: '/' }/>

You can think of <ControlledRouter location> like <input value>. When you set it, the router automatically reflects that value.

We where thinking on how to implement the API that @mjackson mentioned:
class ControllerRouter extends Component {
  componentDidUpdate() {
    //Make some check to avoid pushing the same route many times
    browserHistory.push(this.props.location.pathname)
  }
}

Is it as easy as this??
browserHistory#push was the only way we found to change routes from the code

If you do a PUSH every time you'll increase the history stack. It would be like every time you give your <ControlledRouter> a new location, someone clicked on a link, which isn't what you always want. Sometimes you may want to go back, for example. Or undo the most recent location change.

https://gist.github.com/steida/16da36887e6e6b466e12ba3a4ae6ce87

I have the code, just need to package it up. on vacation with family but
maybe after los niños are in bed I can do it, if not, I'll just post a gist
you can use
On Fri, Sep 16, 2016 at 6:30 PM Daniel Steigerwald<EMAIL_ADDRESS>wrote:

https://gist.github.com/steida/16da36887e6e6b466e12ba3a4ae6ce87
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ReactTraining/react-router/issues/3879#issuecomment-247741333,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaOxoC9nuW-bAL75Zq8WByTWn-1EWks5qq0KtgaJpZM4J-9cN
.

Just gist us what you have and enjoy the vacation with your family unwired. There is no show stopper in RR4.

Based on @steida's version we've created (with @JulianMayorga) a version that change react to state changes
https://gist.github.com/donnanicolas/3d76397a92551f449637590bf0413133

I'll put something on react-router-redux as a 5.0 branch soon. We'll settle on a particular "best" implementation soon, but @donnanicolas has the right idea.

sorry everybody, I just keep forgetting to put code up, at least you'll
appreciate it more after trying yourself!
On Thu, Sep 22, 2016 at 1:07 PM Tim Dorr<EMAIL_ADDRESS>wrote:

I'll put something on react-router-redux as a 5.0 branch soon. We'll
settle on a particular "best" implementation soon, but @donnanicolas
https://github.com/donnanicolas has the right idea.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ReactTraining/react-router/issues/3879#issuecomment-249013519,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaD_N1fDU_CyQy2-9A09sQL7k5JJUks5qsuAZgaJpZM4J-9cN
.

don't know if this is a right place to ask or should open another issue.
tl;dr;  How to integrate async data loading on server for universal app with react-router^4 ?
common task that we now have to do is to fetch some data on server before render, put it into redux state (so using ControlledRouter it seems with ^4), then sync stuff on client.
as one lib that does something like this - Redial. https://github.com/markdalgleish/redial
This is not the only option out there but basically all of them depend on match and renderComponents.
Would be great if you guys supply some way of supporting this. Maybe someway to promisify render for ControlledRouter?

@dlebedynskyi I do this https://github.com/este/este/commit/47efea50fcee5761cf406f2240bdeda8f75c1031 No library is needed.

Tracking a possible implementation here: reactjs/react-router-redux#460 Thoughts, improvements, major refactors are all welcome!

Hi @dlebedynskyi ,
Just shared my codes which build universal app successfully with react-router^4 & redux:
`// server.js
...
import Express from 'express'
import { ServerRouter, createServerRenderContext } from 'react-router'
...
const app = Express()
app.get('/team', handleRender)
function handleRender(req, res){
Promise.then(function(response){
let initialState = {...}
const context = createServerRenderContext()
let store = configureStore(initialState)
let html = renderToString(

)
res.send(renderPage(html, initialState))
})
}
 // client.js
...
import { BrowserRouter } from 'react-router'
...
const initialState = window.INITIAL_STATE
let store = configureStore(initialState)
let rootElement = document.getElementById('root')
ReactDOM.render(

,
rootElement
)
`
`// container/Team.js
export default class Team extends Component {
constructor(props) {
super(props)
}
render() {
return (

)
}
}
`
It works as expected if i visit one of the link under TeamList component which points to '/team/123'

@steida Thanks this looks like a good approach. I'll check it out

Created a ControlledRouter based on @steida's gist: https://gist.github.com/gaelduplessix/050e5cce31f9fabb1030f4ba47663db5
Currently porting my React/Redux app with it, seems to work fine :)

FYI, Ryan posted his ControlledRouter here: https://github.com/ReactTraining/react-router/issues/3905#issuecomment-250991161

@dlebedynskyi I made a library for exactly what you're looking for (I think). I had the same issue but with MobX - should work for either. https://github.com/alisd23/react-async-actions

Can anybody please provide an example how to integrate the ControlledRouter from Ryan (#3905)  with Redux?

@bdudelsack I don't believe that piece of code really works also RR4alpha4 has its own issue. I recommend do not migrate yet.

@alisd23 yeah we ended up with something similar. note that react is strongly thinking of ditching componentWillMount in favor of constructor.

A real controlled router is coming, the enthusiasm is great but please
remember we're still in alpha with this stuff.
On Thu, Oct 6, 2016 at 7:23 PM dlebedynskyi<EMAIL_ADDRESS>wrote:

@alisd23 https://github.com/alisd23 yeah we ended up with something
similar. note that react is strongly thinking of ditching
componentWillMount in favor of constructor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ReactTraining/react-router/issues/3879#issuecomment-252138439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaH9718Z1sMuuuM45WJz4951WDba5ks5qxa0EgaJpZM4J-9cN
.

Yup, thanks for your work @ryanflorence but I think we've been a bit too enthusiast right now. We already migrated some of our code to v4  (and loved it!) but I guess we're gonna have to revert to the previous version for now :(

This is now available as an addon. I've also got the next version of react-router-redux started on a similar path. So, we've got some options for everyone now.


Text font weight does not work properly

Current Behavior
<View>
  <Text color={'black'} fontWeight={'300'}> Some Text</Text>
</View>

in the above code

Setting fontWeight from 100 to 600 has no effect on the font weight.
Setting fontWeight from 700 to 900 makes the text bold, but the boldness doesn't change across those values, resulting in the same appearance for 700, 800, and 900.

Expected Behavior
The fontWeight prop of the Text component should linearly increase the font weight from 100 to 900, resulting in progressively bolder text as the value increases by an interval of 100.
Tamagui Version
- Tamagui version: **1.88.18**

Platform (Web, iOS, Android)
I have tested this thing on iOS and android

Reproduction
<View>
<Text fontWeight={100}>100</Text>
<Text fontWeight={300}>300</Text>
<Text fontWeight={500}>500</Text>
<Text fontWeight={700}>700</Text>
<Text fontWeight={800}>800</Text>
<Text fontWeight={900}>900</Text>
</View>

//the started-code doesn't have tamagui integrated and since the bug is this small the above code is fairly easy to reproduce

System Info
System:
    OS: macOS 13.4
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
    Memory: 267.36 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - /usr/local/bin/node
    Yarn: 4.0.2 - /usr/local/bin/yarn
    npm: 9.5.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 121.0.6167.184
    Safari: 16.5
  npmPackages:
    @babel/core: ^7.23.3 => 7.23.7
    @expo/metro-runtime: 3.1.1 => 3.1.1
    @react-native-async-storage/async-storage: 1.21.0 => 1.21.0
    @react-navigation/native: ^6.0.2 => 6.1.9
    @shopify/flash-list: 1.6.3 => 1.6.3
    @tamagui/animations-moti: ^1.89.3 => 1.89.3
    @tamagui/config: ^1.88.18 => 1.88.18
    @tamagui/metro-plugin: ^1.88.18 => 1.88.18
    @types/react: ~18.2.14 => 18.2.47
    babel-preset-expo: ^10.0.1 => 10.0.1
    expo: 50.0.5 => 50.0.5
    expo-font: ~11.10.2 => 11.10.2
    expo-image-picker: ~14.7.1 => 14.7.1
    expo-linking: ~6.2.1 => 6.2.2
    expo-router: ~3.4.6 => 3.4.6
    expo-splash-screen: ~0.26.4 => 0.26.4
    expo-status-bar: ~1.11.1 => 1.11.1
    expo-system-ui: ~2.9.3 => 2.9.3
    expo-web-browser: ~12.8.2 => 12.8.2
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    react-helmet-async: ~2.0.4 => 2.0.4
    react-native: 0.73.2 => 0.73.2
    react-native-gesture-handler: ~2.14.0 => 2.14.1
    react-native-reanimated: ~3.6.2 => 3.6.2
    react-native-reanimated-carousel: ^3.5.1 => 3.5.1
    react-native-safe-area-context: 4.8.2 => 4.8.2
    react-native-screens: ~3.29.0 => 3.29.0
    react-native-web: ^0.19.9 => 0.19.10
    tamagui: ^1.88.18 => 1.88.18

can you share your tamagui.config.ts file probably some issue with your config

I'll close this issue as no one else reported it.
if you still have this issue, please create a re-production


Upgrade go to 1.12 and some packages used for testing

Support for websockets using reverse proxy was introduced in go 1.12
Using go 1.12 image in circle ci and upgrading some packages which were broken when using go 1.12

@sandlis can you force push to trigger CI tasks to run.  I have updated the circleci config so that PRs from forks trigger builds

@woodsaj build_accept_deploy passed, others are still blocked.

i fixed the repo settings.  after adding the circleci "checks" integration, all checks are listed with the single "build_accept_deploy" name.


logging in throws database error => throw new DatabaseError();

I have had a lot of trouble with the login function, and finally tried it on test.php, and it fails their as well.  I really like the program and hope to be able to use it, but this is a showstopper.  http://drops.campfirepixels.info/qo1X.
I cloned the source, ran npm install, composer install and gulp.

Thanks for your appreciation and for the detailed information on this problem!
I’m sure there will be a simple solution, since this library should be working fine if the setup is correct. That means we need to know what your setup is exactly:

What database software are you using? MariaDB, MySQL, PostgreSQL or SQLite?
What version of the specific database software are you currently running?
(What PHP version are you executing this on?)
(What is the version of this library listed in composer show for your project?)

Thanks!
(By the way, running npm or gulp isn’t necessary, since they are not used in this project.)

I have determined it to be the database itself, but I don't know why.  I created a new database and it works with a limited program.  I replaced it with what we are using and it does not work.
We are using local by flywheel

mysql  version 5.6.34
php 7.1.4
delight-im/auth   v8.0.0 Authentication for PHP. Simple, lightweight and secure.
delight-im/base64 v1.0.0 Simple and convenient Base64 encoding and decoding for PHP
delight-im/cookie v3.1.0 Modern cookie management for PHP
delight-im/db     v1.2.0 Safe and convenient SQL database access in a driver-agnostic way
delight-im/http   v2.0.0 Hypertext Transfer Protocol (HTTP) utilities for PHP
filp/whoops       2.1.14 php error handling for cool kids
kint-php/kint     2.2    Kint - debugging tool for PHP developers
psr/log           1.0.2  Common interface for logging libraries

This was just testing data so it is not a big deal to reproduce.  That is nice to know about modifying the error to be more verbose.  I am the instructor and we are doing this as a class project.  The problem was found by adding the $e to Auth on line 164.  We can close this ticket, as it was not caused by the software, but by passing the database around and getting it corrupted.


Runtime Error

I'm getting the following runtime error when running locally and after installing all the npm packages with npm i, as well as creating a venv for the python packages and installing all the requirements with pip.
"Unhandled Runtime Error
TypeError: event.target.file is undefined"

Updated Readme now with the steps, check it out


[req] vscode integration

would be great to see a vscode integration of this linter

Me too! I've yet to get much experience building VSCode integrations, however. I'd love this to be picked up by someone if they have time.
I won't be able to get to this for a while, January or February at the earliest.

I might look at this myself, found this blog of someone documenting their journey implementing an openapi linter extension for vs code https://medium.com/ringcentral-developers/build-a-linter-extension-for-visual-studio-code-368a65a95545 looks like they potentially wrapped Spectral up for this so might be a drop in replacement in a fork of their repo

This is now in motion with #322

This is now available:
https://quobix.com/vacuum/vscode/
https://marketplace.visualstudio.com/items?itemName=pb33f.vacuum