test_physical_and_logical_replication_slot_not_copied might fail when replica is lagging

A recent failure of test_physical_and_logical_replication_slot_not_copied:
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9670/11972586622/index.html#testresult/d54dbeb891b2e48
test_runner/regress/test_physical_and_logical_replicaiton.py:42: in test_physical_and_logical_replication_slot_not_copied
    assert s_cur.fetchall()[0][0] == n_records
E   assert 99999 == 100000

apparently shows that this code:
    s_con = secondary.connect()
    s_cur = s_con.cursor()

    for pk in range(n_records):
        p_cur.execute("insert into t (pk) values (%s)", (pk,))

    s_cur.execute("select count(*) from t")
    assert s_cur.fetchall()[0][0] == n_records

lacks waiting for replica synchronisation (wait_replica_caughtup?).
I could produce a failure, which at least looks similar:
>       assert s_cur.fetchall()[0][0] == n_records
E       assert 99380 == 100000

with the following modification:
--- a/test_runner/regress/test_physical_and_logical_replicaiton.py
+++ b/test_runner/regress/test_physical_and_logical_replicaiton.py
@@ -32,2 +32,3 @@ def test_physical_and_logical_replication_slot_not_copied(neon_simple_env: NeonE
         endpoint_id="secondary",
+        config_lines = ["recovery_min_apply_delay = 100ms"]
     )

I've run the whole regress suite, with the default value of recovery_min_apply_delay changed from 0 to 1000, and got only a single failure of this kind:
=================================== FAILURES ===================================
______ test_physical_and_logical_replication_slot_not_copied[debug-pg17] _______
...
>       assert s_cur.fetchall()[0][0] == n_records
E       assert 97733 == 100000

test_runner/regress/test_physical_and_logical_replicaiton.py:42: AssertionError
...
= 1 failed, 575 passed, 38 skipped, 12 deselected, 1 warning, 2 errors in 19776.34s (5:29:36) =

So as of 0713ff317 (a commit I tested at), this the only test with such a defect.


General improvements and fixes

Mainly made some adjustments based on the change to using Gatsby.js to host the guide.
Changes are:

Making copy-chapters.sh script executable
Adding instructions to install node packages in local dir
Adjusting the contribution.md for self-host instructions

The changes LGTM.
I am ok with merging the PR

I'll merge the changes tomorrow if there's nothing else left!


how to use llm-graph-builder as an api

https://neo4j.com/labs/genai-ecosystem/llm-graph-builder/
the ui is cool, and to use this as a tool in agent frameworks, im trying to find a way to use it as an api.
to have all the functionality of the https://llm-graph-builder.neo4jlabs.com, as an api
any help? thanks!

You can host the backend your self and all availabel api endpoints are in this file https://github.com/neo4j-labs/llm-graph-builder/blob/main/backend/score.py

also do you have an idea whats the difference between using llm-graph-builder vs the graphRAG accelerator from microsoft for graphRAG (https://github.com/Azure-Samples/graphrag-accelerator)
I prefer neo4j for making use of graph databases extensively in my project on top of the graphRAG. so its an easy choice for me if both are essentially providing the similar graph powered RAG feature for llms.
its hard to find at which layer neo4j adds value to end user when i.plementing graphRAG following the microsoft method.
if you can shed some light, will be helpful. thanks!

Sorry I am not familiar with MS graphRAG accelerator, but as far as I know you can do some extra analysis with Neo4j GDS library and also it looks like you probably have to use MS Azure cloud with MS graphRAG accelerator together.

@seshubonam, for more details about integrating GraphRAG with NEo4j, pls refer to the blog: https://neo4j.com/developer-blog/microsoft-graphrag-neo4j/

thanks

Hi @seshubonam if you are satisfied with the answer please close the issue


Add usbutils to development OS version

usbutils package is useful when doing development on the various machines (i.e. the lsusb utility especially)

See https://github.com/resin-os/meta-resin/pull/852


Explore distribution of custom element JS/CSS with the plugin

In order to avoid a hard dependency on a CDN, we should consider a configuration where the custom element JS and CSS is distributed with the plugin. In addition to quelling any privacy concerns about loading external assets (as have been raised with Google Fonts), this also will also ensure that the version of the component used in the editor matches the version used on the frontend: currently the plugin bundles the React component from npm, but loads the custom element from the CDN.

Might be difficult to get the same version for the custom element without it being distributed via npm.

It's probably something that's best done before plugin distribution:

Run npm update to ensure you're using the latest version
Download CSS & JS from CDN and put into the plugin
🚢

Filed an issue here: https://github.com/ampproject/amphtml/issues/35554

It's probably something that's best done before plugin distribution:

Ah yes, exactly. I meant as part of the build step, not at runtime.

Just pushed some changes to the plugin to make use of the new self-hosting capabilities since there's been great progress on that from the AMP side.
Also caught up with all the component renaming etc. that happened.


Incorrect entity data for spawned entity

Valence Version
8759a2163210403821c64a9e18f248a44ad71034
What You Did
From discord:
commands.spawn(VillagerEntityBundle {
    location: Location(inst_ent),
    position: Position::new([0.5, 104.0, 0.5]),
    ..Default::default()
});

commands.spawn(VillagerEntityBundle {
    location: Location(inst_ent),
    position: Position::new([0.5, 104.0, 3.0]),
    villager_villager_data: VillagerData({
        valence::entity::VillagerData {
            kind: valence::entity::VillagerKind::Jungle,
            profession: VillagerProfession::Armorer,
            level: 5,
        }
    }),
    ..Default::default()
});

What Went Wrong
One of those villagers is on fire(!)
Additional Information
Something with TrackedData or one of the systems that initializes the tracked data is probably bugged.
There is a separate issue where tracked data is initialized with incorrect default values from other entities, but this looks like a different problem.

commands.spawn(VillagerEntityBundle {
    location: Location(inst_ent),
    position: Position::new([0.5, 104.0, 3.0]),
    villager_villager_data: VillagerData({
        valence::entity::VillagerData {
            kind: valence::entity::VillagerKind::Jungle,
            profession: VillagerProfession::Armorer,
            level: 5,
        }
    }),
    ..Default::default()
});

This one spawns an on fire villager


adds users without taking into account IP addresses of disabled users

on the last screenshot the fix option

I think this is fixed with the new version. @VladimirKoh


Update theme.css

I was using the Style Setting options for the fonts but they didn't seem to change anything so I modified this code and it seemed to fix it. I'm new to CSS so don't know if it's the best solution. :)

Hey everyone! Sorry, but trust me this was not forgotten. i'm fixing fonts (slowly, haha) so i'm just going to pull this in really quickly as i work on that. Thank you both so much 💖


Improved text-button-rounded

Background color change on click
Before:
https://play.tailwindcss.com/Gud429YYmY
After:
https://play.tailwindcss.com/UWYhNqbyEv

Before and After are the same

Before and After are the same

Did you check by clicking? The background color should change on click.

Before and After are the same

Did you check by clicking? The background color should change on click.

But It does not follows the button design system so, there is no requirement for this


Project Info Subgraph Fallback

Description
Addressed #974 . The project info is available on the polygon-bridged-carbon subgraph, so the subgraph is used in place of the cms endpoint mentioned in the issue.
I kept the contract calls as a last fallback. So for project info it will currently check the api, if api fails -> subgraph, if subgraph fails -> rpc call.
Related Ticket

Resolves #974

Checklist

[X] I have run npm run build-all without errors
[X] I have formatted JS and TS files with npm run format-all

Replaced by cleanups that were in https://github.com/KlimaDAO/klimadao/pull/1640


[LANDGRIF-1000] Methodology doc and modal change

General description
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Provide minimal instructions on how to test this PR.

Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

[ ] Branch name / PR includes the related Jira ticket Id.
[ ] Tests to check core implementation / bug fix added.
[ ] All checks in Continuous Integration workflow pass.
[ ] Feature functionally tested by reviewer(s).
[ ] Code reviewed by reviewer(s).
[ ] Documentation updated (README, CHANGELOG...) (if required)

@mariasola

In the design I can see checkboxes, why did you implement radio inputs?


Concrete example of ack not finding a pattern it should.

Example of ag not working on the open source repository https://github.com/twosigma/beaker-notebook.
ag "JerseyLogger" finds a pattern when launched from beaker-notebook/core/src, but not from beaker-notebook/core. "grep -R" or "ack" find a pattern from both directories.

That's because ag is obeying the .gitignore in beaker-notebook/core.


There's a code injection vulnerability of net.bramp.ffmpeg.FFmpeg.<constructor>

Affected Version
The latest version 0.7.0 and below.
Describe the vulnerability
net.bramp.ffmpeg.FFmpeg.<constructor> is designed to create an FFmpeg object. However, passing an unchecked argument to this API can lead to the execution of arbitrary codes. For instance, following codes can lead to the execution of malicious program:
new FFmpeg("C:/Windows/System32/calc.exe");

To Reproduce
Just execute above codes would reproduce it.
Fix Suggestion
Check the parameter of FFmpeg.<constructor> strictly.

It is by design that a user can provide the path to the binary they wish to call for ffmpeg/avconv
What would you suggest instead? As-in what is a concrete suggestion for more strict checking?

It is by design that a user can provide the path to the binary they wish to call for ffmpeg/avconv
What would you suggest instead? As-in what is a concrete suggestion for more strict checking?

Much thanks for your reply. Actually, we've sent a mail months ago to discuss this problem, but we got no reply.
I'll close this issure right now.

CVE-2023-39018 was assigned to this bug. Now that @bramp confirmed this is not a bug, but instead a design choice, someone should ask MITRE to withdraw this CVE ID. I can file the request for that, any objection?

Hi, thanks for your opinion! @bramp @StayPirate
I'm working with @LetianYuan . We have done some research on these kinds of bugs, and we believe it is a bug for the following reasons.

This API (FFmpeg.<constructor>) violates the principle of least privilege. The purpose of the API is to instantiate an FFmpeg object for further use. However, it is not necessary to actually run the provided application at the stage of instantiation, because none of the FFmpeg functionalities is required at this point. Thus, the version() call should be omitted from the constructor.
Since the API invokes the given application directly, users should do security checks before passing parameters to this API. However, the users can hardly be aware that this API will execute given command right away, since the API name and the javadoc don't give any information about it. As a result, untrusted inputs can be passed to the API in some circumstances, leading to remote command execution.
We believe that this kind of implementation obscures the responsibility of security checks between the developers and the users of libraries, which has been confirmed by some developers. For example, the Google Jib library fixed the unnecessary command executions with a file existence check (cf. CVE-2022-25914, and https://github.com/GoogleContainerTools/jib/commit/67fa40bc2c484da0546333914ea07a89fe44eaaf ). Besides, the well-known log4j vulnerability is also introduced because of the unawareness of library users.

Because of the reasons above, I suggest that the version() call in the constructor can be removed or replaced with an execution permission check.
I'd be very happy if you could share your further opinions with me. Thank you!

Hi,
CVE-2023-39018 refers to 0.7.0 as being the version that this vulnerability was introduced in, but there's no such tag for it that, just 0.7.1
Based on that, is that the version in question?

Thanks for the followup @lzher

That sounds reasonable. The main reason it was checked that, is because you only construct the FFmpeg object, when you actually want to invoke it.  e.g
FFmpegBuilder builder =
    new FFmpegBuilder()
        ...
        .done();

FFmpeg ffmpeg = new FFmpeg("/path/to/ffmpeg");
FFmpegExecutor executor = new FFmpegExecutor(ffmpeg, ffprobe);

But you are right it could be deferred until the FFmpegExecutor executes it.

The user here is the developer. I never expect them to let the user give them a random path to a binary. But you are right, I can document this behaviour, and/or slightly modify it.

I think it's pretty clear to the developer that new FFmpeg("/path/to/ffmpeg"); will eventually invoke /path/to/ffmpeg, unlike log4j where a option the developer never saw caused the problem. So I don't think these are remotely similar.  This is more akin to saying "Be careful running bash /your/binary because Bash is going to invoke your binary.

Anyways, next steps

Clearer documentation
Considering removing the version() call from the constructor.

Thanks for your kind reply.
We agree the attack surface is limited. But in some cases developers can allow their users to control a part of the binary path. For example, if a developer allows users to choose different versions of FFmpeg, the version input from untrusted users can be directly concatenate into the path, resulting in an path injection and then arbitrary command execution.
We cannot predict how developers use your APls, so it is important to make sure the Apls satisfy the principle of least privilege and are well documented.
Thank you again for sharing your opinion with us!

Is there any action done to unflag this from the CVE databases?
I am aware that this CVE is smoke and not real...
It still shows up in the vulnerabilty databases...
This may eventually make some people nervous.

@AlexanderSchuetz97
I suspected this issue...
Is there a CVE for this library, or is it a pattern match?

https://www.cve.org/CVERecord?id=CVE-2023-39018
IntelliJ is also showing this. Its also shown for v 0.8.0.
whoever submitted this CVE gave a "*" for a version.
Ive read all comments in this issue. By @LetianYuan logic the class "ProcessBuilder" is a vulnerability. I am assumeing that LetianYuan submitted this CVE, if this is not the case then the following is not directed at you but rather whoever submitted it to mitre.
Also the reason why I am assumeing this is or was bad faith is because most vuln trackers flag this as critical and easily exploitable with 0 user interaction. This is really not the case at all. Its almost as if someone malicoisly fed the CVE all the things so it would show up this way.
Could you please remove this CVE before countless engineering hours are wasted explaining to non tech savy people that this CVE is complete bs?
Comparing a framework that 90% of people intended to write logs to a file where someone considered it smart to parse said log and load random classes from a url if the input matched, to this library where its sole purpose is to run a elf/pe binary with complex arguments is beyond me. It is completely obvieus to everyone immedeatly what this library does and that it at some point will run the provided binary.
99% of users of this library probably extract or download ffmpeg and write it to %TEMP% and then pass this path directly to the library. Anyone who lets the user choose this path arbitrarily does so full well knowing what he is doing.

@AlexanderSchuetz97 Thanks for the analysis.
@bramp I just contacted Mitre about this; I'll update...

For all coming here due to the CVE, this was filed in bad faith, and we're trying to work with Mitre to resolve it.
For this to impact you meaningfully, you must instantiate the FFmpeg object without using the instance.
Additionally, you would have to let the user override the application you referenced to inject your executable or allow the user to upload his executable into a directory with higher priority on the PATH.
This means:

The attacker has access to the service user and can't escape it (no problem)
The attacker is root (You have a problem, but it's not this library)
You allowed users to override arbitrary system files (You have a problem, but it's not this library)

You will have to execute shell commands to use this library meaningfully (and the FFmpeg class in particular).
Saying this is a thread is the same as saying sudo bash -c "rm -rf /*" is one.
Last but not least, neither the CVE description nor the version is correct.

Minor update: The CVE is now marked as disputed.
From the CVE entry: This is disputed by multiple third parties because there are no realistic use cases in which FFmpeg.java uses untrusted input for the path of the executable file.


disable pua and gpos checks for emoji

For the fun of it, let's actually use a classical Chinese text sample.

I would rather change this to check for existence of the specific PUA emojis we need for backward compatibility and making sure there's no other PUA characters in the font.

So, that set is exactly fe4e5-fe4ee fe82c fe82e-fe837?
NotoEmoji (which Android doesn't use, right?) has the keycap emoji at e023
(#) and e030-e039.  Should they not be there at all?  Or should they be
mapped to fe82c fe82e-fe827?
On Thu, Nov 19, 2015 at 5:45 PM, Roozbeh Pournader<EMAIL_ADDRESS>
wrote:

I would rather change this to check for existence of the specific PUA
emojis we need for backward compatibility and making sure there's no other
PUA characters in the font.
—
Reply to this email directly or view it on GitHub
https://github.com/googlei18n/nototools/pull/118#issuecomment-158255210.


Catch when student implementation fails due to an error

PyBryt should notify an instructor when a student implementation errors out during execution. The current implementation continues executing despite errors, but does not notify the instructor.

@ranigb I'm thinking of raising a UserWarning with a message like Executing the student notebook produced one or more errors. What do you think of this? Or should it raise an error?

Raise a warning, and add a field for all error messages to the StudentImplementation. Also add a field for keeping track of the output notebook?


How can I backup and restore without pain?

Hello, Im trying to backup my system and restore it from a zip file.
All examples are from the docs http://www.orientechnologies.com/docs/last/Backup-and-Restore.html
In Windows I get following error:
orientdb> connect remote:<IP_ADDRESS>/test root root

Disconnecting from the database [null]...OK
Connecting to database [remote:<IP_ADDRESS>/test] with user 'root'...
Error: com.orientechnologies.orient.core.exception.OStorageException: Cannot open local storage 'E:/software/orientdb-community-2.0.6/databases/test' with mode=rw

Error: com.orientechnologies.orient.core.exception.OSerializationException: Cannot load database's configuration. The database seems to be corrupted.

Error: java.io.IOException: The process cannot access the file because another process has locked a portion of the file

after reading that remote backup & restore commands are only available in the enterprise edition I tried to do it with plocal but I get this:
orientdb> connect plocal:..\\databases\\test root root

Connecting to remote Server instance [plocal:..\\databases\\test] with user 'root'...Cannot connect to the remote server/database 'remote:plocal:..\\databases\\test/'
com.orientechnologies.common.io.OIOException: Cannot open a connection to remote server: plocal:..\\databases\\test/
        at com.orientechnologies.orient.client.remote.OStorageRemote.getAvailableNetwork(OStorageRemote.java:1849)
        at com.orientechnologies.orient.client.remote.OStorageRemote.beginRequest(OStorageRemote.java:1812)
        at com.orientechnologies.orient.client.remote.OServerAdmin.connect(OServerAdmin.java:89)
        at com.orientechnologies.orient.console.OConsoleDatabaseApp.connect(OConsoleDatabaseApp.java:233)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at com.orientechnologies.common.console.OConsoleApplication.execute(OConsoleApplication.java:381)
        at com.orientechnologies.common.console.OConsoleApplication.executeCommands(OConsoleApplication.java:246)
        at com.orientechnologies.common.console.OConsoleApplication.run(OConsoleApplication.java:135)
        at com.orientechnologies.orient.graph.console.OGremlinConsole.main(OGremlinConsole.java:62)

Error: com.orientechnologies.orient.core.exception.OStorageException: Cannot connect to the remote server/database 'remote:plocal:..\\databases\\test/'

Error: com.orientechnologies.common.io.OIOException: Cannot open a connection to remote server: plocal:..\\databases\\test/

then I tried the backup.sh with following options:
.\backup.sh plocal:../databases/test root root test.zip
and get this curious message:
Error: com.orientechnologies.orient.core.exception.OSecurityAccessException: User or password not valid for database: 'test'
Can anybody show me how can I restore and backup my db really straight forward without blocking my db?
Thank you!

When I create a user seperatly for the db and use the credentials, it works! I thought the root user has the privileges.

I think the problem here is the usage of \\. Could you try using / instead?

@StarpTech  plz try
.\backup.sh plocal:../databases/test admin admin test.zip

I noticed that for remotely created database (lets say with root) I was able to log in with admin? account when I used plocal


Advantages of Azure Security Center vs normal MDSC onboarding for OnPrem servers?

Hello - from reading, the advantage of onboarding On-Premise servers to Azure Security Center for Windows Defender ATP is that the servers would be visible through the Azure Security Center pane of glass?  Besides that, it appears Azure Security Center directly references the Microsoft Defender Security Center?
Are there any other advantages I am missing?  Is there somewhere that can provide additional detail besides those 3 bullet points outlined?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05da473f-3b1d-8b8b-ea7a-68d0e7e62c31
Version Independent ID: e5e40276-c0cd-fa51-4eb4-93e21c57a065
Content: Windows Defender Advanced Threat Protection with Azure Security Center
Content Source: articles/security-center/security-center-wdatp.md
Service: security-center
GitHub Login: @monhaber
Microsoft Alias: v-mohabe

@oniled Thanks for your feedback! We will investigate and update as appropriate.

@oniled You can refer to Azure Security Center extends advanced threat protection to hybrid cloud workloads blog for additional details.

@oniled We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[REQUEST] Autosave config in a temporary file

Hi,
i was debugging my config and i wrote a wrong loliscript command :
(i was trying to find a shorter way to check if a file exists and write a line if it was not exist)

then OB got freeze,i was not saved my config and i lost all my edits :(
please make OB to create a temporary file and save config with last changes automatic
to not losing config when OB hangs (because of this or huge source or any other reason)
THANKS

And maybe a Error when syntax is wrong
to prevent this problems?


Where can I find the code for graphoper？

Is there any code for Graphhopper? Where can I find it?

we will try to upload it within a week or so...


fix back behavior

@Tkko I make 2 change

fix the back behavior:
when user delete a number, the cursor still in the same square, not move back to previous square
call _checkClipboard whenever _copyFromClipboard() to get the lastest string from clip board
Please review my pr 🙇


[core] Clean TableScan related codes

Purpose
Delete useless DataTableScan and StreamDataTableScan.
Add a internal option.
Tests
Original Tests.
API and Format
No.
Documentation
No.

Verified.

Verified.

Verified.


Ecto Stream Errors

I might not understand something related to Ecto streams and transactions but this code was working with mariaex. I've distilled the base case down to this code in order to reproduce it. Basically I always receive an error tuple when I expect an ok tuple as a response. Please let me know if there is anything else I can help you with, sorry if this is not enough info.
https://gist.github.com/k-cross/c3a0bb2a2c6b32ae0da548e9b634b63b

Thanks for the report, unfortunately I'm not able to reproduce this locally.
By always returning error tuple, do you mean the transaction is always rolled back? If you remove the rescue clause, what's the exception being raised?
Another way to move this forward would be to create a small repo that reproduces the issue with a script/test? You can use this repo as a starting point: https://github.com/wojtekmach/ecto_example

Okay, I will create the sample project to move forward. Yes, this kept producing roll backs. I just get %ArgumentError{message: "argument error"}.

What is the stacktrace for the ArgumentError?

Sorry to lead you down a bad path, this was a Jason decoding issue. There still might be a difference in how this is handled but I'll diagnose that issue further. Thank you for your help!

No worries!


⚠ Bofrost.at has degraded performance

In b4b3d41, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 866 ms

Resolved: Bofrost.at performance has improved in 4a081af.


RuntimeErrorNCCL error

The first time I was able to run the program, the second time I had this problem
Thank you for your help and look forward to your reply.
RuntimeError: NCCL error in: /pytorch/torch/lib/c10d/ProcessGroupNCCL.cpp:825, unhandled system error, NCCL version 2.7.8
ncclSystemError: System call (socket, malloc, munmap, etc) failed.

Hi, this does not seem related to the repository. If the problem persists please check pytorch repository for similar issues.


ttwatch: 2017-09-26 -> 2017-10-31

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg ttwatch

@disassembler use @grahamcofborg build ttwatch in the future :)


NSObject protocol is forward declared in BMPreference.h, why?

Hello, why don't you import #import <Foundation/NSObject.h> here?
 Probably I miss some point.
You oblige developers to import NSObject.h before #import <BloodMagic/Preference.h>, otherwise, they get a compiler error.

Hi @DanSkeel, thank you for your feedback.
There is no specific reason why the import is omitted, just a 'typo'.
Would you mind to send a pull request?

Yeah, sure)


Is there a way to access theme inside a component?

If I use withTheme is there a way to do something like that:
<Grid container spacing={(theme.spacing.unit * 3)}>{list}</Grid>
For now I see theme is passed only to a custom themes object which I can only use for CSS styling

@ilyador you can use withTheme for that purpose.

Why shouldn't this work? When using withTheme you should get the whole theme as props.theme if i get the docs right.
https://material-ui-next.com/customization/themes/#accessing-the-theme-in-a-component

Oh! I didn't know theme is being passed as a prop, all works fine now.

In version 1.4.0, theme is not passed as a prop when using the annotation :
@withStyles({ ... })
class CustomComponent extends Component {
  render() {
    const {
      theme,
      ....
    } = this.props;

    console.log(theme);  // undefined !

    return (
      ....
    );
  }
}

CustomComponent.propTypes = {
  theme: PropTypes.object.isRequired,   // ERROR! Failed prop
};

I have tried @withStyles({ ... }, { withTheme: true }) but it still doesn't work.

Could you please check that the MuiThemeProvider is on top of the parent component?

I have figured that, when using withStyles or withTheme in annotation, the wrapper is executed after the component constructor. So, the CustomComponent.propTypes are checked before the annotations set the property unto the instance. It is a problem with React that should check for these props when the component is mounted, not when it is created.

Indeed, these solutions do not work. In our project we had this code in the root component:
 ReactDOM.render(
        <Provider store={store}>
            <MuiThemeProvider theme={theme}>
                <CssBaseline>
...

and from there, we used withStyles for all the components. What worked for me was to do this as well for the component.

https://stackoverflow.com/a/60599662/10268122

@material-ui/core - v4.1+
we'll be using the useTheme() hook in our component to get the theme property:
import { withTheme } from "@material-ui/core/styles";

const default () => {
   // Hook here
   const theme = useTheme();

  return (
      <Divider style={{ background: theme.palette.divider }} />
  );
}

https://stackoverflow.com/questions/43281020/reference-to-themes-primary-color-instead-of-a-specific-color-in-material-ui/63058508#63058508

withTheme HOC
For use in class or function components:

import { withTheme } from '@material-ui/core/styles';

function DeepChildRaw(props) {
  return {`spacing ${props.theme.spacing}`};
}

const DeepChild = withTheme(DeepChildRaw);

useTheme hook
import { useTheme } from '@material-ui/core/styles';

function DeepChildRaw(props) {
  const theme = useTheme()
  return {`spacing ${theme.spacing}`};
}

const DeepChild = withTheme(DeepChildRaw);

Upvote the anwer
https://stackoverflow.com/questions/43281020/reference-to-themes-primary-color-instead-of-a-specific-color-in-material-ui/63058508#63058508


Make 73 numeric constants actually const, moving them into the .rdata section

Description of the changes:
This change makes the 73 variables in ratconst.h actually const, which allows them to
move from the mutable .data section of the executable, and into the read-only .rdata section of the executable.
Moving data to the .rdata section has a number of benefits, such as preventing possible corruption
due to stray writes, or other memory corruption.
Additionally, the initialization at run-time start-up is no longer needed, so there is also a
reduction in the .text (code) section as well.
As a result the overall size of the Calculator.exe binary (on x64 Release) decreases by 1,536 bytes (or ~1.5 KB) with no change in behavior other than a small performance benefit.
How changes were validated:

Manually verified by testing.

Why not constexpr though?
I would also like to ask to limit the subject line of commit to less than 70 chars (ideally < 50), see https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

Why not constexpr though?

I actually tried using constexpr first, but it seems that MSVC doesn't support using constexpr on structures that contain variable length arrays. (I get compiler errors)
The mant member of the NUMBER struct is variable in length.
Maybe in the future when MSVC supports this it could be changed.

I would also like to ask to limit the subject line of commit to less than 70 chars (ideally < 50), see https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

Sure, how does "Make 73 numeric constants const, moving them into .rdata" sound?

variable length arrays

Ouch.
The commit message looks fine to me

LGTM

Why not constexpr though?

I actually tried using constexpr first, but it seems that MSVC doesn't support using constexpr on structures that contain variable length arrays. (I get compiler errors).
The mant member of the NUMBER struct is variable in length.
Maybe in the future when MSVC supports this it could be changed.

A quick note on RATs and NUMBERs - the Rational and Number classes were introduced as a standard C++ implementation of the C-style RAT and NUMBER structs. For now, they exist as wrappers. I would like to see the functionality of ratpak migrated into the Rational and Number classes, eventually deprecating the dynamically allocated ratpak types entirely.

Hey @jefgen, could you leave a comment on this PR to restart the license check?  See https://github.com/cla-assistant/cla-assistant/issues/415

Hm, I think this might be because I used a different email address in the commit than the PR.
I think I'll just squash the two commits and then change the email address. Hopefully that makes the CLA bot happy. :)


Docker build not working in v0.61.0

When building the docker container from source the build fails with the following error:
Step 8/30 : RUN go build -ldflags "-X github.com/treeverse/lakefs/pkg/version.Version=${VERSION}" -o lakefs ./cmd/lakefs  ---> Running in b383faa96159 pkg/db/migration.go:17:2: no required module provides package github.com/treeverse/lakefs/pkg/ddl; to add it: 	go get github.com/treeverse/lakefs/pkg/ddl pkg/api/ui_handler.go:18:2: no required module provides package github.com/treeverse/lakefs/pkg/webui; to add it: 	go get github.com/treeverse/lakefs/pkg/webui

Hey @dakotah-jones-techngs , how did you try to build the container?
Try running make build-docker.

Hey @dakotah-jones-techngs -- there are non-Dockerized steps in the build, so you should try make build-docker.  If it still doesn't work PLEASE re-open!


Implement --filter

Implement #105

Looking really powerful! I can't wait to try this out in the canary :)

Some review notes:

Some pieces of the RFC are not yet implemented. In particular, --test-pattern and --filter-prod are not implemented. The existing --ignore flag is respected as --changed-files-ignore-pattern.
Docs are still a TODO. I'm open to suggestions on how much detail to include in the help text for run. I suspect that including a full syntax reference for filters might be too much, but we ought to have a link to the docs at the very least.
We added an extra piece of syntax to pnpm's syntax: the ability to specify leading ... before a commit reference. When specified, we use a different algorithm for selecting packages: first we filter all packages that match package and directory filters. Second, we further filter that list of packages to include only the packages whose dependencies have changed since the specified commit. This enables the usecase of selecting a package if it or any of its dependencies have changed.
The algorithm in filter.go is largely a port of the corresponding filtering in pnpm, with the exception of filterSubtreesWithSelector, which implements the above additional feature.
filter_test.go is largely a port of pnpm's test for filter
parse_target_selector_test.go is a port of pnpm's test for parsing selectors
match_test.go is a port of pnpm's matcher test

@gsoltis How much do you think is left for this PR? I am wondering if I could help you in someway

@weyert Thanks for your interest. Probably the most helpful thing right now would be some QA. I've ported a good chunk of the tests from the equivalent pnpm modules, but it's helpful to try with actual commands someone would run. So, can you try building from this branch and see if you are able to express the commands you would want? Especially with --dry, you should be able to verify that the targets you expect are getting run.

@gsoltis Yeah, I have build for the Mac. I haven’t been able to make a build for Linux yet. Maybe a canary build would help to test this PR? Can imagine that would be useful for @pablo-abc too

@gsoltis Will it support the upcoming --filter change in NPM v7?

Filtering by path is done by globs.
In pnpm v6, in order to pick packages under a certain directory, the following filter was used: --filter=./apps
In pnpm v7, a glob should be used: --filter=./apps/**
Source: https://github.com/pnpm/pnpm/releases/tag/v7.0.0-beta.2

I would like to release one version first and the next version to support the changes in pnpm v7, we have been waiting for this feature for too long


Make 0.2.1 release

Conda-forge release missing

Was this version released or not?

Yes

Are you working on 0.3 now?

Are you working on 0.3 now?

Yes


Add option for configuring HPA with custom/external metrics

What this PR does:
Add an option to auto-scale on custom and external metrics.
Which issue(s) this PR fixes:
No issue opened yet
Test values.yaml:
nginx:
  autoscaling:
    enabled: true
    customMetrics:
    - type: External
      external:
        metric:
          name: queue_messages_ready
          selector:
            matchLabels:
              queue: "worker_tasks"
        target:
          type: AverageValue
          averageValue: 30
    - type: External
      external:
        metric:
          name: queue_workers_ready
        target:
          type: AverageValue
          averageValue: 10

Result:
---
# Source: cortex/templates/nginx/nginx-hpa.yaml
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: release-name-cortex-nginx
  namespace: default
  labels:
    helm.sh/chart: cortex-2.1.0
    app.kubernetes.io/name: cortex
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v1.15.1"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/component: nginx
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: release-name-cortex-nginx
  minReplicas: 2
  maxReplicas: 30
  metrics:
    - type: Resource
      resource:
        name: cpu
        target:
          type: Utilization
          averageUtilization: 80
    - external:
        metric:
          name: queue_messages_ready
          selector:
            matchLabels:
              queue: worker_tasks
        target:
          averageValue: 30
          type: AverageValue
      type: External
    - external:
        metric:
          name: queue_workers_ready
        target:
          averageValue: 10
          type: AverageValue
      type: External
---

Checklist

[x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Hi @nschad and @kd7lxl , could you take a look at this PR?

thanks!


Implement ways to put notebooks (and lakehouse) under version control, at least make it easier to save code locally

It is possible, to access the local notebook, using the "Reveal in File explorer". This works.
There could be a more intuitive way, for example: "export notebook" or a "save as" or a "save locally", instead of browsing to the working folder in the file explorer.
And it would be great if we could store notebooks (and other stuff) under source control. Maybe, this is already on the roadmap, because a workspace already can be connected to an Azure DevOps git repository. But currently only Power BI reports are under source control. For me, it is essential, to have all my development under source control. Currently, it is hard or even impossible to have fabric development under source control.
The extension shows Lakehouse tables. Hoovering over tables, there is even a tooltip. But the tooltip is only shown, the content can't be used, can't be copied. This could be improved.
It would be fine if we would be able to create some code, which will create the table (sql, PySpark), In SSMS I can generate scripts to generate tables. Something like this would be very helpful.
In General it would be even better, if the online GUI for lakehouse and notebooks would be improved. To enable to save (export?) notebooks as file, lakehouse tables as script, and so on.

@aisbergde apologize for the late reply, please check the update/answer as below
for the version control part, it is under the roadmap and actually the notebook will be supported with Git very soon. similarly as PowerBi Report, you can put your notebook under version control via the Git support in the portal.
for the tooltip part, thanks for the suggestion, we will consider it in our next integration, also we would consider the feedback around directly generating some code from the lakehouse/table.


Get all handles

Hi Mina.
Your changes included .js compiled files, the tsconfig should output results in a build directory which is ignored from .gitignore. Not sure what happened here, but please remove those .js files, and remove any changes to the files you didn't need to change CodeforcesClient.ts for example.


Update dependencies and remove deprecation warnings

This pull request updates dependencies that either used deprecated Elixir APIs (e.g. HashDict) or included other deps in their trees that did.
The Poison dependency was also updated in the mix.lock file because it was locked to a very old version.
The PR also updates the mix.lock file to the new hex.pm format, which happens automatically when running mix deps.get with a recent version of hex. For example:
-  "cowlib": {:hex, :cowlib, "1.0.2", "9d769a1d062c9c3ac753096f868ca121e2730b9a377de23dec0f7e08b1df84ee", [:make], []},
+  "cowlib": {:hex, :cowlib, "1.0.2", "9d769a1d062c9c3ac753096f868ca121e2730b9a377de23dec0f7e08b1df84ee", [:make], [], "hexpm"},

Also dropped support for Elixir 1.3, because the up-to-date dependencies have dropped support for it (Elixir 1.5 is around the corner), and the tests would fail on travis when run with Elixir 1.3.

Hi,
Thanks for PR. Unfortunately, I don't think it should be merged.
Comparing your branch with master, list of warnings seems to be same for both. (For comparison I created clean mix project using newest elixir 1.5.0-rc.0 and erlang 20.0)
Droping support for 1.3 because of dev/test dependencies doesn't seem to be good idea.
Also mix.lock doesn't make any difference for users, it isn't included in hex package.

Hi, thank you for the feedback, but I'm not sure about the comments.

Comparing your branch with master, list of warnings seems to be same for both.

Can you be more precise, please? If I look at the latest master build I can see loads of deprecation warnings. Some are for modules that are deprecated in recent versions of Elixir (e.g. HashDict and HashSet), others are because of style warnings added to the Elixir compiler (e.g. missing parentheses). They all come from the dependencies that I have upgraded. On the build for this branch there are no warnings.

For comparison I created clean mix project using newest elixir 1.5.0-rc.0 and erlang 20.0

1.5.0-rc.0 is a pre-release yet. I'm targeting 1.4, the latest stable release.

Droping support for 1.3 because of dev/test dependencies doesn't seem to be good idea.

That's not the reason I'm proposing to drop it. At the moment this library relies on outdated dependencies that will soon cease to work on modern Elixir releases. I've updated these libraries, which in turn have dropped support for Elixir 1.3. The fact that the Travis tests break with Elixir 1.3 is just a proof that the up-to-date dependencies would not work on modern Elixir, in production nor in dev. I mentioned the travis test only to point it out and because it's easy to check the output of the failed build, not to justify dropping 1.3.

Also mix.lock doesn't make any difference for users, it isn't included in hex package.

I know it's not included in the released package, but it does make a difference.

The mix.lock format update is applied by mix deps.get, automatically. Anyone who clones the repo today and installs the dependencies will have to deal with it. Since master still contains the old format, the new updated mix.lock file will be seen by git as an update, which is a hassle if people want to work on something more narrow and send a PR. I'm just saying that the new format should be part of master.
The mix.lock describes the libraries and versions that are installed when running mix deps.get, and as it is now it locks the project to old dependencies. This is an issue because library developers (owners or people sending PRs) will work and run the tests with an old and outdated dependency tree that likely does not reflect the environments used in the wild. For example, at the moment this library is locked to hackney 1.7.1 and poison 2.2.0, which means that the library author develops and tests code against those versions, and the same applies to the automated tests in Travis. If people want to use tesla today, however, they will likely use it with the latest versions of those libraries. For example I am using it in a project where I'm requiring hackney 1.8 and poison 3.1. I can use them because Tesla's mixfile allows it (~> and >=`), but the fact that the library is developed and tests with old versions gives me zero confidence that it will actually work properly with the current ones.

Ok, I'll try to explain this step by step
Lets create new project
mix new foo

and add tesla to dependencies in mix.exs
defp deps do
    [
      {:tesla, github: "teamon/tesla", branch: "master"}
    ]
end

then get deps and compile project. List of compilation warnings for 1.5.0-rc.0 looks like this:

Dependencies you are trying to update are dev/test dependencies, they are used only during tesla development to help test things. They aren't included when someone adds tesla to his own project or even listed in hex as part of package. Getting rid of warnings from them is not worth dropping support for one of elixir versions.

Ok, I'll try to explain this step by step

Hey, thanks, but this is not necessary and to be honest it's a bit condescending.
I don't need this explained step by step. I understand what you're saying, don't worry. The problem is still that you're missing the point, and you're trying to explain things that are really not relevant.

Lets create new project
...
and add tesla to dependencies in mix.exs

I don't know how to reply to this. I guess "... ok, sure".

then get deps and compile project. List of compilation warnings for 1.5.0-rc.0 looks like this:

Those are all new deprecations introduced in Elixir 1.5. They have nothing to do with what I'm doing here in this PR. I am trying to remove old deprecation warnings. You're looking at new, different deprecation warnings. And you can see them because you're using a pre-release version of Elixir that I'm not even considering in this PR.

Dependencies you are trying to update are dev/test dependencies, they are used only during tesla development to help test things. They aren't included when someone adds tesla to his own project or even listed in hex as part of package.

Not really. I also updated Poison and hackney in the mix.lock file, which are runtime dependencies. I have already explained in my previous message why I think it's important to update them in the lockfile.
With regard to dev/test-only dependencies, I get that as long as the tests run (and test the right things), an outdated test dependency is fine. I still think that one should try to take care of deprecations proactively, rather than waiting for something to break. I appreciate that people can have different opinions on this.

Getting rid of warnings from them is not worth dropping support for one of elixir versions.

Elixir 1.3 was dropped by Poison, not by a test dependency. I think I've already explained why I think it's a good thing to develop and test the library with up-to-date dependencies.

I believe there's far more people using elixir 1.3 than people contributing to tesla who can't live with these warnings

Maybe, but that's why you have library versions. People stuck on Elixir 1.3 can keep using Testa 0.7.1, and people on a more modern Elixir can use a newer version of Tesla. I'm not saying to yank (retire) the current versions of Tesla and prevent people on Elixir 1.3 from using it. I'm asking to release a new version.
Also, most people today will start new projects with Elixir 1.4 (soon 1.5), and will want to use recent versions of libraries. Because, you know, new features and bug fixes.

At the moment this library relies on outdated dependencies that will soon cease to work on modern Elixir releases.
They won't cease to work until elixir 2.0

Good to know, thanks.

Hey, thanks, but this is not necessary and to be honest it's a bit condescending.

Sorry, didn't meant to. I just wanted to be sure that it's clear what I'm comparing.

Those are all new deprecations introduced in Elixir 1.5.

Ok, let's leave this. Adding tesla to project with 1.4.x doesn't generate any additional warnings.

Not really. I also updated Poison and hackney in the mix.lock file, which are runtime dependencies. I have already explained in my previous message why I think it's important to update them in the lockfile.

Diffs on mix.lock are not easiest to read... acknowledged.

Elixir 1.3 was dropped by Poison, not by a test dependency. I think I've already explained why I think it's a good thing to develop and test the library with up-to-date dependencies.

Still it doesn't seem good reason to drop 1.3 for me. It's optional dependency. Some people may don't need json middleware at all or use exjsx, which allows elixir: ">= 0.13.3". It may be annoying for them.

Maybe, but that's why you have library versions. People stuck on Elixir 1.3 can keep using Testa 0.7.1, and people on a more modern Elixir can use a newer version of Tesla.
I still see issue here... most PRs are just new middlewares. Let's assume in next month we'll merge support for multiparts. For people using 1.3 this would mean they need to either update elixir for whole project (which probably will cause even more warnings for them) or copy new module from github (which seems poor solution).

Hi,
thank you for taking the time to get back to me on this and explain your position.
I understand where you're coming from, but I'm afraid that I'm not really convinced. I could reply with examples of people using this library today or tomorrow, and encountering bugs because they're using it with recent versions of the other libraries, but I guess that you have already considered that.
This is a very useful library and it seems to be working fine for me even with the latest dependencies. So, thanks and keep up the good work.

It's also worth noting that you can force whichever packages you want across the board with override: true (obviously weird bugs cropping up you are on your own) so I'm really not understanding why this is an issue with the versions made in this package.


Document features on docs.rs

It will show on docs.rs which features are required for the function/type to be available.
Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

@NobodyXu Just to confirm, you're referring to these right? https://gyazo.com/55d9ce84a5c355c3994fbd87a382bf40
If so, awesome!

Yes, that's right.


USART code doesn't clear UARTFRG reset

The USART code uses UARTFRG (via BaudRate), but doesn't make sure that the peripheral reset for UARTFRG is cleared. While I think this is a bug, it doesn't necessarily manifest itself, as the UARTFRG reset is cleared by default.
I think the correct solution to this problem is to add a type parameter to UARTFRG to track whether it's initialized, but that leads to another problem: The methods on syscon::Api can be used to assert or clear the UARTFRG reset, circumventing any type state.
This isn't a problem for the full-blown peripherals, as those have a clear distinction between types that implement ResetControl et al. and public API types that carry type state, and the former are owned by the latter. Maybe the same mechanism should be used for the other types that implement ClockControl, ResetControl, and AnalogBlock.
I did some experimentation in that direction, but decided that the details deserve some further thought. For now, I'm going to add documentation to state that UARTFRG must not be reset, and leave this fix for later.

I'm going to remove the bug label and replace it with enhancement. The USART code is not doing something wrong, it's just not enforcing one of its (documented) requirements. I haven't called this kind of thing a bug in other cases, and I see it more as a missing feature.
Maybe at a later stage, when the API is more bullet-proof than it is now, such issues would be classified as bugs.


Added Entire Sync Section

Mutexes

implemented no-overhead mutexes (init(), lock(), unlock() - without extra memory allocation)
used direct type (int) to reduce performance lost from indirection
used native int size to maximize performance
added p_cpu_relax to reduce load and cycle wastage during lock contention (when possible)
utilized architecture optimized assembly (when possible)

Atomics

implemented using fairly portable extensions (these are as far as I checked, more platforms are actually supported in reality):

GCC

Intel

x86
x86_64

ARM

armv2
armv3
armv4
armv5
armv6
armv7

AArch64

armv8

IBM

PowerPC
Power7
Power8

Clang

x86
x86_64

Intel Compiler Collection

x86
x86_64

implemented for all common integer sizes (8, 16, 32, 64)
supports both signed and unsigned integers

p_fence

used an actual memory fence (printf() is not a real memory fence)
amended function signature (memory fences work across processor - object specificity doesn't do anything & nothing to return)
utilized highly portable extension (see above list for supporting compiler/platforms)

cc @olajep @aolofsson


Create cost details toolbar component with filter, sort, and export button.

The intent is to setup the basic pieces within the page from the PF3 library
Next step is to wire up the interactions of the toolbar with the filtering/ordering/export functions

Deploy preview for koku ready!
Built with commit 5ee603c29815e1e26a0531191e2ed56dc714256e
https://deploy-preview-101--koku.netlify.com

Deploy preview for project-koku ready!
Built with commit 5ee603c29815e1e26a0531191e2ed56dc714256e
https://deploy-preview-101--project-koku.netlify.com

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   83.78%   83.78%
=======================================
  Files         113      113
  Lines        1178     1178
  Branches      145      145
=======================================
  Hits          987      987
  Misses        177      177
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc58f34...5ee603c. Read the comment docs.

@dlabrecq I pushed changes for the PropTypes and to swap out FormControl with TextInput and PF3 Button for PF4 Button.
Styling isn't great for TextInput. I tried to set a className to try and override the lineHeight and fontSize but when I refreshed it still seemed to take from textInput.styles.ts maybe you or @boaz1337 know the quick fix for this, but I figured it doesn't have to be a blocker.

Fixed the styling issues by instead styling some of the PF3 items to match PF4 better:


Adding target (as optional argument) to build-wheel action

Although one typically builds the wheel of a project by pointing at its necessary dependencies, one could also build a wheel of a package taking into account optional dependencies. For example:
Default (typical) case:
pip wheel . -w wheelhouse

Wheel with optional targets:
pip wheel .[my-target] -w wheelhouse

This use-case is specially interesting for the pyansys metapackage, since we are interested in generating the wheels of the all target - that is, all PyAnsys packages inside it.
Consider adding it and bumping version. I will be implementing it shortly. This argument should definitely be optional - since it is not the typical use case.

Sounds great @RobPasMue .

This was solved after several attempts in the end... Look at https://github.com/pyansys/actions/blob/main/build-wheelhouse/action.yml for final solution


Use macro in exp_log.{cc/cu}

Simplify device implementation of Exp, Log and Log10.

Jenkins, test this please.

Jenkins CI test (for commit 802b1f55440b8598dc203919e46c2dda7517a97d, target branch master) failed with status FAILURE.

Jenkins, test this please.

LGTM!


espflash: add installShellCompletion

Description of changes
Some QoL improvement in the form of shell completions.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 288279 run on x86_64-linux 1

1 package built:

espflash

Result of nixpkgs-review pr 288279 run on x86_64-linux 1

1 package built:

espflash

Rebased and added a check for cross-compilation that I've seen used for other packages' shell completion generation.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1507


FR: allow coboleditor:copybookdirs to be passed to a task

Currently the include directories have to be set for both the extension and the paths. It would be good to somehow be able to have a special args that take care for it. This would also solve the issue with the different dialects.
Possible example solution:
Instead of:
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "gnucobol - cobc (single file)",
            "type": "shell",
            "command": "cobc",
            "args": [
                "-fsyntax-only",
                "-I${workspaceFolder}\\CopyBooks",
                "-I${workspaceFolder}\\CopyBooks\\Public",
                "${file}"
            ],
            "problemMatcher" : "$gnucobol-cobc"
        }
    ]
}

have:
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "gnucobol - cobc (single file)",
            "type": "shell",
            "command": "cobc",
            "args": [
                "-fsyntax-only",
                "${file}"
            ],
            "argsInclude": [
                { "type": "multiple" },
                { "value": "-I${copyBookDir}" }
            ],
            "problemMatcher" : "$gnucobol-cobc"
        }
    ]
}

and instead of
{
    "label": "mf cobol (single file)",
    "command": "cobol",
    "args": [
        "${file}",
        "noint",
        "nognt",
        "noobj",
        "noquery",
        "errformat(2)",
        "COPYPATH($COBCPY;${workspaceFolder}\\CopyBooks;${workspaceFolder}\\CopyBooks\\Public)",
        ";"
    ],
    "group": {
        "kind": "build",
        "isDefault": true
    },
    "options": {
        "cwd": "${workspaceRoot}"
    },
    "presentation": {
        "echo": true,
        "reveal": "never",
        "focus": true,
        "panel": "dedicated"
    },
    "problemMatcher": "$mfcobol-errformat2"
}

have
{
    "label": "mf cobol (single file)",
    "command": "cobol",
    "args": [
        "${file}",
        "noint",
        "nognt",
        "noobj",
        "noquery",
        "errformat(2)"
        ";"
    ],
    "argsInclude": [
        { "type": "repeat" },
        { "separator": ";" },
        { "value": "COPYPATH($COBCPY;${copyBookDir}${separator)" }
    ],
    "group": {
        "kind": "build",
        "isDefault": true
    },
    "options": {
        "cwd": "${workspaceRoot}"
    },
    "presentation": {
        "echo": true,
        "reveal": "never",
        "focus": true,
        "panel": "dedicated"
    },
    "problemMatcher": "$mfcobol-errformat2"
}

Sorry, the format of the tasks is fixed.
If you want the flexibility, I would use a single task that goes to a makefile, this way you can also handle copybook dependencies and only build/check syntax when you need to.

The makefile approach is reasonable but the main issue for this task was that there's a setting the editor needs (coboleditor.copybookdirs) and a setting the task needs (no matter if you have it hidden in a makefile or not).
Can you please provide an option to pass this setting via args?

This task is not part of this extension, so I can't extend it or change it.
On Tue, 28 Apr 2020 at 08:37, Simon Sobisch<EMAIL_ADDRESS>wrote:

The makefile approach is reasonable but the main issue for this task was
that there's a setting the editor needs (coboleditor.copybookdirs) and a
setting the task needs (no matter if you have it hidden in a makefile or
not).
Can you please provide an option to pass this setting via args?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/121#issuecomment-620435843,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNWWGFN3Y6XMDPDYDEZLJTRO2BVHANCNFSM4MSQFMJA
.

--
Stephen Gennard
<EMAIL_ADDRESS>

That's reasonable, just to recheck: the extension cannot set any variable that may be referenced in there (as ${file} or $gnucobol-cobc?

I wish it could.
environment variable support has only just been extended into the
embedded terminal support.
On Tue, 28 Apr 2020 at 09:38, Simon Sobisch<EMAIL_ADDRESS>wrote:

That's reasonable, just to recheck: the extension cannot set any variable that may be referenced in there (as ${file} or $gnucobol-cobc?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

--
Stephen Gennard
<EMAIL_ADDRESS>

With the recent multiple reads of https://code.visualstudio.com/docs/editor/variables-reference it looks like this may be already possible and if not: be possible to add.
The docs say:

You can reference VS Code settings ("configurations") through ${config:Name} syntax (for example, ${config:editor.fontSize})

Maybe ${config:coboleditor.copybookdirs} is usable (or can be made so)?

The ${config..} items are expanded automatically others don't appear to be.
So you use them in the config, area but I struggle to see how useful it is
to create a copybook search path.
Especially, if you use ${config:coboleditor.copybookdirs} with a
${config:coboleditor.copybookdirs} area, I expect it might go recursive or
something like that.
On Fri, 8 May 2020 at 22:40, Simon Sobisch<EMAIL_ADDRESS>wrote:

With the recent multiple reads of
https://code.visualstudio.com/docs/editor/variables-reference it looks
like this may be already possible and if not: be possible to add.
The docs say
https://code.visualstudio.com/docs/editor/variables-reference#_configuration-variables
:
You can reference VS Code settings ("configurations") through
${config:Name} syntax (for example, ${config:editor.fontSize})
Maybe ${config:coboleditor.copybookdirs} is usable (or can be made so)?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/121#issuecomment-626032813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNWWGC7FGOCTTVDWFDRVNTRQR333ANCNFSM4MSQFMJA
.

--
Stephen Gennard
<EMAIL_ADDRESS>

Sorry, I stand corrected, it is not expanded.
Invalid Search directory :
/home/spg/src/CICS-Assignment/myDir_${config:editor.fontSize}
On Fri, 8 May 2020 at 23:19, Stephen Gennard<EMAIL_ADDRESS>wrote:

The ${config..} items are expanded automatically others don't appear to be.
So you use them in the config, area but I struggle to see how useful it is
to create a copybook search path.
Especially, if you use ${config:coboleditor.copybookdirs} with a
${config:coboleditor.copybookdirs} area, I expect it might go recursive
or something like that.
On Fri, 8 May 2020 at 22:40, Simon Sobisch<EMAIL_ADDRESS>wrote:

With the recent multiple reads of
https://code.visualstudio.com/docs/editor/variables-reference it looks
like this may be already possible and if not: be possible to add.
The docs say
https://code.visualstudio.com/docs/editor/variables-reference#_configuration-variables
:
You can reference VS Code settings ("configurations") through
${config:Name} syntax (for example, ${config:editor.fontSize})
Maybe ${config:coboleditor.copybookdirs} is usable (or can be made so)?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/121#issuecomment-626032813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNWWGC7FGOCTTVDWFDRVNTRQR333ANCNFSM4MSQFMJA
.

--
Stephen Gennard
<EMAIL_ADDRESS>
--
Stephen Gennard
<EMAIL_ADDRESS>

The point is to not use the config options in the extension settings but the extension settings in the task defintions (for example in args).

Just rechecked with the setting
settings.json
  "coboleditor.copybookdirs": [
    "${workspaceFolder}",
    "${workspaceFolder}/src/cpy/common",
    "${workspaceFolder}/src/cpy/files",
    "${workspaceFolder}/src/cpy/screens",
    "${workspaceFolder}/../Release Components/common/cpy/common",
    "${workspaceFolder}/../Release Components/common/cpy/files",
    "${workspaceFolder}/../Release Components/common/cpy/screens"
  ],

and test tasks
tasks.json
        {
            "label": "Test Task",
            "type": "shell",
            "command": "echo ${config:coboleditor.copybookdirs}"
        },
        {
            "label": "Test Task args",
            "type": "shell",
            "command": "echo",
            "args": [
                "${config:coboleditor.copybookdirs}"
            ],
        }

The variables ${workspaceFolder} are passed (seen on the "Executing task" output in the terminal) and correctly replaced (one time quoted, one time not), so this is the most one can get out of it.
To be actually usable in the compiler task the compiler must understand it in either this format (none I know of do) or the arguments have to be split by an input parameter (a shell script that is executed)... But shell input is something that's not available in vscode yet.


--help

We should implement --help.

Partially fixed in 1daf426ad1864dbe7a8cad660305f020aa19e3b9, but since minimist doesn’t automatically generate a nice formatted help, we’ll have to repeat ourselves (again).


Allow to skip specific cleanups

Executing the AppImage of remote-ssh-tunnel-controller-qt (a PySide2 application) results in Segmentation fault from AppDir/usr/conda/lib/python3.8/site-packages/shiboken2/libshiboken2.abi3.so.5.14 when the AppImage is created without exporting CONDA_SKIP_CLEANUP=yes (the default behaviour); otherwise the app runs fine but with a bigger AppImage.
The issue is triggered by the line find -type f -iname '*.so*' -print -exec strip '{}' \; so I thought it would be useful to be able to skip specific cleanup tasks.
These changes allow the user to optionally skip some cleanup tasks by listing its id's as the value of CONDA_SKIP_CLEANUP variable while maintaining backward compatibility (as far a possible because until now it was allowed any value of this variable) with current uses of it.

Thank you!


Manipulating stats with additional args

Description
I'd like to know if it's possible to force stats to print as each file completes instead of all at once. If not, then I would like to submit this for a feature, with some additions.
I would also like to be able to control what is printed, such as truncating the file path to explicitly state how many parent directories are shown, if any, and the ability to control the color of the output. While many people may not care, I like to take the time to style output and try to keep things consistent, especially for in-house tools I will use frequently.
An optional addition would be to add 1 more stat: the time it takes to complete each file. This is a personal preference. I just like to know how long it takes for things to complete.
Why?
I'm using this with python programs and would like the output to be consistent with the rest of the program. This cli tool is excellent because it blocks, so I can call it with a simple command, let it run, and python will wait until it's done. However, the lack of feedback for each file completion can make one wonder if they are completing, especially when testing or when using large files.
Specifically, I'm using this with an in-house automation system that has multiple shells open at once, those terminal windows have a set width, and the paths are breaking lines making it difficult to read them at a glance. The colors don't jive with my styling, which also makes it more difficult to read than the rest of my output.
Suggested Solution
Additional args to manipulate the output as described above.
For directory output:
This could be something like: --stat-parents 3 or --stat-parents 0. --dir-parents or --parents would also suffice.
For people who only care about the end stats or want more granular control over what is displayed, you could also include an option for --stat-type all --stat-type stats --stat-type paths --stat-type files --stat-type total.
--stat-type stats would include just the filename without the directory path plus the KB info. For granular control, they could be combined: --stat-type paths,1,stats,total
For colors:
--stat-colors "color1, color2, color3" or simply --colors "color1, color2, color3" or --colors red,blue,yellow without quotes or spaces. Docs/help could explain the order and available colors. I think using escape characters would make it too cumbersome, so a comma separated list of color names in a string seems reasonable.
Including dim or bright versions would be a nice touch, but not a deal breaker. This I would represent with a dot naming of the colors: --stat-colors "gray, blue.dim, yellow.bright". The order should follow the order things are printed. If not enough colors are specified to set everything that's printed, the unspecified ones would remain default. I would suggest that the path and filename be set as separate colors. That's how I personally like to style my output, so the filename pops and I see it right away, and the directory(ies) is there if I need to double check.
For completion time:
Short timecode would suffice for me using minutes and seconds, such as: 01:24 or 00:10. Could make it an option with --time or --stats time.
Sum up:
If all this seems too cumbersome, I'd be comfortable with setting everything under one flag like --stats.
--stats "paths, p3, time, gray, gray.dim, blue, gray, yellow.bright". As long as things were logical it wouldn't bother me, though I can imagine some would detest such a thing all crammed under one flag.
Help Needed
I do not have the skills to code this in the slightest, only enough functional gray matter to make suggestions on how to implement it on the user side, test it, and use it in my projects.

force stats to print as each file completes instead of all at once

This would be great, I agree, but the desktop apps which imageoptim-cli controls don't output that information until they've completed, so this is out of my control.

be able to control what is printed, such as truncating the file path to explicitly state how many parent directories are shown, if any, and the ability to control the color of the output

I have to be honest with you and admit that I don't want to include this feature in the CLI, I don't think anyone else would have a need for it. The best thing to do for something like this would be to pipe the output of imageoptim-cli into another CLI whose job it is to perform all these transformations on the log output.
imageoptim | your-thing --stat-parents 0 --stats time --stat-colors "gray, blue.dim, yellow.bright"


Fix missing link references in docs

Tweak to add missing link references. Appears that when some content was moved between files, some references weren't copied through. I had a look for other instances, but this was all I found.

The docs job appears to be failing due to some missing branch in a Git repo dependency.

Hey @raehik. Welcome to xgcm and many thanks for raising this PR! This failure seems to be related to a PR @TomNicholas submitted upstream. It seems like the feature was merged recently.
Let me try to unpin this dependency and if that works you can rebase this?

#517 was just merged. Can you try to merge the latest changes into this branch and then we can hopefully merge this. Thanks for your patience @raehik.

Oh amazing. Again, big thanks for bringing this to out attention. I will close this now.

Did you mean to close without merging? I don't mind the specifics, but merging here would probably be most straightforward to getting the changes in

Sorry I messed


Add ant flag force.builddocs

This change adds a property force.builddocs to the build script that
controls whether a failure to successfully execute Jekyll constitutes
a build failure or not. It defaults to false. In Jenkins we will set
it to true so that builds fail if they cause jekyll to fail. This way
people who do not have Jekyll installed can continue to work with the
sources. Since everything needs to pass Jenkins before being merged,
maintainers can run Jekyll to update the docs prior to merging.
Change-Id: I9fb22eea7582fb5ba5a83069778c23a40c14aaa8

@AppInventorWorkerBee retest this please to check that the property takes effect.


S3 head_bucket() returns empty Unknown error if bucket doesn't exists

Testing was done on Minio Docker image RELEASE.2018-08-02T23-11-36Z.
Running head_bucket(..) method like that:
let head_bucket = HeadBucketRequest {
    bucket: bucket_name.to_string(),
};
println!("{:?}", client.head_bucket(head_bucket).sync());

Results in Err(Unknown("")) while it should return NoSuchBucket("The specified bucket does not exist").
Trying to `put_object(..) into that bucket gave me:
Err(Unknown("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error>NoSuchBucket<Message>The specified bucket does not exist</Message><Resource>/testing/test.txt</Resource><RequestId>154C1E00AE9E2568</RequestId><HostId>3L137</HostId></Error>"))

Likely same root cause as in #716 for HeadObject.

https://github.com/rusoto/rusoto/pull/1146 has a stopgap solution: please take a look and provide feedback. 👍

As far as I could tell, on a 404, S3's head-bucket response yields an empty string body. Rusoto should probably infer NoSuchBucket on the status code alone rather than expect a well-formed XML document (see parsing code).
One workaround is to match on the status code in the response object passed into RusotoError::Unknown(resp: BufferedHttpResponse).


DEP Decouple from silverstripe/framework

Issue

https://github.com/silverstripe/silverstripe-config/issues/81

Could you rebase this PR, please.

Just small question, why do we say Will be removed without equivalent functionality to replace it in MiddlewareCommon when we have __serialize and __unserialize methods?

Because we stuffed up 😅
Technically that's not part of this PR but I'll fix it here to save us some time.


Produce SHA checksums for binaries

Expected Behaviour

Produce SHA checksums for binaries
Current Behaviour

Not available and could be generated easily.
Possible Solution

Copy the approach of the one of the following projects' build scripts
https://github.com/alexellis/inlets/
https://github.com/openfaas/faas-cli

Fixed in: https://github.com/teamserverless/license-check/releases/tag/0.3.4


feat: add user model

Adds user model with login, registration, and email verification.

[x] Localized routes and language switcher
[x] User model and migrations
[x] Login and registration views and controllers (via Fortify)
[x] Dashboard view
[x] User account admin and user settings views and controllers
[x] Looseleaf styles for basic layout

Testing

Create new Laravel application.
Follow README instructions (up to date in this PR) to add and install Hearth to the application.
Test:

User registration
Email verification
User account editing (name, email, password)
User account deletion
User settings management (changing default language)

Additional Info
There's a lot in here and correspondingly lots of room to clean up and improve. I'd like to get this merged and then create a number of follow-up issues to iron out some of the details.
Related Issues

#9

A quick first pass:
Sails on Docker for Windows/WSL Notes
As we've discussed, using Sails via Docker for Windows/WSL2 works well, and is mostly seamless with these notes:

commands that need to execute in the container context for dependencies that may be in the container but not the WSL environment should be run as follows: sails npm install
to access the running app from Windows via the APP_URL defined in the .env file, you need to create an entry in the Windows host file like <IP_ADDRESS> eds-app.test - https://docs.rackspace.com/support/how-to/modify-your-hosts-file has instructions for this

Test Results
User registration
With a clean install of Hearth, this creates the user but throws a Swift_TransportException "cannot send message without a sender address", and does not send the verification email.
After some Googling, I was able to resolve this by changing MAIL_FROM_ADDRESS in the .env file from a null value to<EMAIL_ADDRESS>From what I can tell, it is only required that it be a validly formatted email address, but it needs to be present.
Email verification
This worked once the issue mentioned above was resolved.
User account editing (name, email, password)

Able to log in and edit name and email via "Settings"
Able to log in and change password via "Account"

User account deletion

Able to delete an account via "Account"

User settings management (changing default language)

Able to log in and change default language to francais via "Settings"

User registration
With a clean install of Hearth, this creates the user but throws a Swift_TransportException "cannot send message without a sender address", and does not send the verification email.
After some Googling, I was able to resolve this by changing MAIL_FROM_ADDRESS in the .env file from a null value to<EMAIL_ADDRESS>From what I can tell, it is only required that it be a validly formatted email address, but it needs to be present.

I've documented this requirement here: https://github.com/fluid-project/hearth/blob/95c2a5b74f7bc1c30759d494ae9050f9691bc05b/README.md#emails

@waharnum Updated with a bit more boilerplate CSS to properly layout the navigation, login screen, etc.

An issue I noticed while working on this: https://github.com/chinleung/laravel-multilingual-routes/issues/54


provide fallbacks for when ARB_direct_state_access is not available

https://github.com/liquid600pgm/rapid/issues/4#issuecomment-514731775

Fixed, the engine doesn't use this GL extension anymore.


Escape syntax

Ref #18, #109
It's now possible to escape ] inside strings, using a backslash: \]
Should we allow escaping other characters too, eg :, <, } ?

You can try this in the escape branch. Tell me if it breaks anything.

Yes please!

I hope this doesn't break anything.


Add Windsor High School

Add Windsor High School from Windsor Colorado.
https://whs.weldre4.org/

Hi, should I assign any reviewer for this PR? Not sure how long it usually takes to be review/approved. Thanks!

@dalmirdasilva Thank you for your patience while waiting for a review and processing your request. Pull request merged.


automatically add all non-draft PRs in "To Review" (from retro)

In other words:
any PR in any of the repositories under epinio org, if not a draft, it should appear in the "To Review" column of the epinio project

done


nixos/sddm: allow running on wayland without xserver enabled

Description of changes
I've only ever tested this with #286522, so we are going to wait until that is merged.
Next step would be to move things not related to xserver out of the xserver setting and to something more generic.
Some history irrelevant history to to this: I am thinking about decoupling wayland from xserver since at least September last year motivated by @tanneberger
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I wonder if the GNOME folks have some useful information on what parts of services.xserver.enable = true are needed for a pure Wayland session, given that GDM/GNOME already lacks the assertion and should support running on Wayland without the X server too.

For some reason, SDDM now does not start automatically on boot on my machine.

Discetting the relevant parts out of xserver is as PR description out of scope of this PR and will done later to keep the scope manageable.

I wonder if the GNOME folks have some useful information on what parts of services.xserver.enable = true are needed for a pure Wayland session, given that GDM/GNOME already lacks the assertion

That shouldn't be that hard, we basically need the following but in another PR:
hardware.opengl.enable = mkDefault true;
environment.systemPackages = with pkgs; [ nixos-icons xdg-utils ];
xdg = {
  autostart.enable = true;
  icons.enable = true;
  menus.enable = true;
  mime.enable = true;
};
# The default max inotify watches is 8192.
# most apps require a good number of inotify watches,
# the value below is used by default on several other distros.
boot.kernel.sysctl."fs.inotify.max_user_instances" = mkDefault 524288;  boot.kernel.sysctl."fs.inotify.max_user_watches" = mkDefault 524288;
systemd.defaultUnit = "graphical.target";
fonts.enableDefaultPackages = mkDefault true;

should support running on Wayland without the X server too.

I leave that up to the gnome people. If I didn't do a mistake, there should be no change in functionality and all other display manager need to opt into the new things in explicitly.

That shouldn't be that hard, we basically need the following but in another PR:
hardware.opengl.enable = mkDefault true;
environment.systemPackages = with pkgs; [ nixos-icons xdg-utils ];
xdg = {
  autostart.enable = true;
  icons.enable = true;
  menus.enable = true;
  mime.enable = true;
};
# The default max inotify watches is 8192.
# most apps require a good number of inotify watches,
# the value below is used by default on several other distros.
boot.kernel.sysctl."fs.inotify.max_user_instances" = mkDefault 524288;  boot.kernel.sysctl."fs.inotify.max_user_watches" = mkDefault 524288;
systemd.defaultUnit = "graphical.target";
fonts.enableDefaultPackages = mkDefault true;

Yes, that's what I meant above in one of the comments that's now folded. These are basically required to restore a working system when actually using the functionality of this PR.

I leave that up to the gnome people. If I didn't do a mistake, there should be no change in functionality and all other display manager need to opt into the new things in explicitly.

Oh, I didn't mean that you should change something for GNOME, but that GNOME may already have some things that have been overlooked here because they seem to support running without the X server already.

I get the following error:
       error: attribute 'setupCommands' missing
       at /nix/store/zbxf8dvm2mv47d41n80b4frszsz7skgw-nixpkgs/nixos/modules/services/display-managers/sddm.nix:24:7:
           23|     ${cfg.setupScript}
           24|     ${dmcfg.setupCommands}
             |       ^
           25|   '';

Fyi That should be covered by commit in https://github.com/NixOS/nixpkgs/pull/291913#discussion_r1531216665

Pushed a bunch of fixes here so that at least the tests eval properly again: https://github.com/alois31/nixpkgs/tree/sddm-wayland-only

The mate-wayland test still emits a warning and gnome doesn't even eval. I pushed relevant fixes to my branch again.

The GDM module still warns, when you integrate that fix everything should be good.

@ofborg eval

Are there any comments left or something I, @alois31 or @Shawn8901 missed? We want to merge this?

From my side everything that I noticed was addressed an I am using that now since some time with sddm in Wayland only setup.

Using this for some time now as well. I have not noticed any difference in system behavior.

Can we merge this pr?

Don't hit me if this goes wrong 🙈

@ofborg eval

Anyone has an idea why eval-lib-tests fails? It looks really random to me.

as r-ryantm prs also have that issue it seems also quite unrelated to me.

Okay, since ofborg was green before the retrigger and this seems to be a general issue, I think we can ignore this right now.

Here goes nothing :shipit:

https://github.com/NixOS/nixpkgs/commit/476b8c276e2ae4c98efd1d8d759029e170c5ca98 broke my config with a message that services.xserver.displayManager.sessionPackages does not exist.
Found this PR and updated to remove xserver.

breaks for me
i only use
              xserver = {
                # Enable the X11 windowing system.
                enable = true;
                # Enable the GNOME Desktop Environment.
                # services.xserver.displayManager.lightdm = {enable = true;
                # greeter.enable = false;

                # };

                displayManager = {
                  gdm = {
                    enable = true;
                    autoSuspend = false;
                  };
                };
                desktopManager.gnome.enable = true;

                # services.xserver.displayManager.autoLogin.user = "moot";
                # Configure keymap in X11

                layout = "us";
                xkbVariant = "";
              };

  services = {
    xserver = {
      # boot.initrd.kernelModules = ["amdgpu"];
      videoDrivers = ["amdgpu"];
      # videoDrivers = [
      #   "modesetting"
      # ];
      xrandrHeads = [
        "DP-2"
        {
          output = "DP-1";
          primary = true;
        }
      ];
      exportConfiguration = true;
    };
  };

hyprland

 sudo nixos-rebuild boot --flake .    --show-trace   --max-jobs 2 --keep-going --cores 20  --option eval-cache false
warning: Git tree '/home/moot/dev/depot_space' is dirty
warning: input 'flake-utils' has an override for a non-existent input 'nixpkgs'
warning: input 'mk-shell-bin' has an override for a non-existent input 'nixpkgs'
error:
       … while calling the 'seq' builtin

         at /nix/store/skrr54jsvr8qdsfd1jghmylvbqkcajlp-source/lib/modules.nix:322:18:

          321|         options = checked options;
          322|         config = checked (removeAttrs config [ "_module" ]);
             |                  ^
          323|         _module = checked (config._module);

       … while calling the 'throw' builtin

         at /nix/store/skrr54jsvr8qdsfd1jghmylvbqkcajlp-source/lib/modules.nix:298:18:

          297|                     ''
          298|             else throw baseMsg
             |                  ^
          299|         else null;

       error: The option `services.xserver.displayManager.sessionPackages' does not exist. Definition values:
       - In `/nix/store/skrr54jsvr8qdsfd1jghmylvbqkcajlp-source/flake.nix':
           {
             _type = "if";
             condition = false;
             content = [
               <derivation qtile-wayland-session>
           ...

      repl is also broken any advice?

Please take a look at #303186

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/enable-plasma-6/40541/24

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/enable-plasma-6/40541/30


Update swift 3 branch to work with Xcode 8 beta 4

It was working with some renaming, but beta 4 has this error that I'm not seeing how to fix it. Maybe someone can help me:

Change the "Error" after the colon to Swift.Error.

Thanks I'm closing this because of #201


Vickel: Watch newdayconstruction.co

Vickel requests the watch of the watch_keyword newdayconstruction\.co. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

newdayconstruction\.co has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Router breaks when using the NPM build of React Router

See my original Stack Overflow on this issue: http://stackoverflow.com/questions/28818286/react-router-typeerror-oldelement-store-is-undefined/28841423#28841423
Not sure if this is something to do with my specific setup, but I thought I would draw your attention to this, if it helps anybody else.  Thanks for the excellent work on this!

Any chance you had a duplicate react installed in node_modules/react-router/node_modules/react? Two Reacts on a page would conflict.

It is a duplicate react issue.  I'm not sure what is actually at fault, but I'm getting one React.js and a second react.js loaded in the browser.  Browserify doesn't seem to want to shim the require('react') inside of react-router.

Actually, I did not have a duplicate react installed in react-router or any other NPM dependency, I just checked.
Here's what my npm-installed react-router looks like in my project:

Can you share your project, or at least the failing part so we can repro?

fwiw, I'm using react-router with npm + browserify without issue.

Bottom line, don't mix your package managers.  In my case it was a combination of using bower to load a global react, and browserify-shim to supply the require result from the global.  I just bit the bullet and only use npm and browserify, and skip over the bower step.
The root issue was my browserify output was as large as 4MB before uglify.  Which is why I was trying to use the global React and ReactRouter.

4MB?!
Out of curiosity, what does your package.json "dependencies" entry look like?


Add ability to generate 'model_class_type' errors for model subclasses in strict mode

Right now, the only way to create an error of type 'model_class_type' is to use dataclasses. I discovered this while working on the docs and it seemed weird to me, so I copied the logic from the dataclasses validator.
That said, I think we still need to improve the error message you get if you do the same thing in non-strict mode (since now it says you should be giving it a dict, which is a very confusing error message).
Also, it definitely seems weirdly inconsistent to me that you can validate a dict of data for a model in strict mode, but can't for dataclasses. I'm sure this got discussed before but .. I think it's maybe worth reconsidering before the official v2 release.

Codecov Report

Merging #703 (b2cd7a1) into main (c1c27d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   93.73%   93.74%
=======================================
  Files          99       99
  Lines       13806    13825   +19
  Branches       25       25
=======================================
+ Hits        12941    12960   +19
  Misses        859      859
  Partials        6        6

Impacted Files
Coverage Δ

pydantic_core/core_schema.py
96.63% <ø> (ø)

src/errors/types.rs
83.65% <ø> (-0.05%)
:arrow_down:

src/validators/dataclass.rs
98.32% <ø> (ø)

src/input/input_abstract.rs
86.48% <100.00%> (+0.37%)
:arrow_up:

src/input/input_python.rs
98.07% <100.00%> (+0.01%)
:arrow_up:

src/validators/model.rs
98.49% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c27d4...b2cd7a1. Read the comment docs.

I think we used to not allow dicts in strict mode for BaseModel and we changed that not too long ago to accommodate response validation in FastAPI. We probably just forgot to do it for dataclasses.

It looks like we don't generate model_class_type errors any more anywhere, so I'm going to close this PR as out-of-date. Maybe it got renamed or something, but anyway we can revisit if it comes up, otherwise I'm happy to ignore this.


Change location of .Site.Params.homepage

Putting the homepage link into the next line looks clean and easy to find home.

Since this is a design preference rather than bug fix/enhancement, I will not merge it to the master theme.


Typescript types aren't exported. Can't import types without importing everything.

Not too good with TS, but typically I see packages exporting their types and forgo the declare module bit in favor of just exporting/importing types from one or many files. The type definitions for axios are a good simple example.
Would you accept a PR to refactor to something like that?
Here's some more context...
IDE (phpstorm/webstorm) complains that it can't resolve loadStripe or Stripe.
import {loadStripe, Stripe} from '@stripe/stripe-js'

async function initStripe() {
    const stripe = await loadStripe('pk_123')

    if (stripe) {
        initElements(stripe)
    }
}

function initElements(stripe: Stripe) {
    // ...
}

Workaround is to import everything like so
import * as StripeJs from '@stripe/stripe-js'

async function initStripe() {
    const stripe = await StripeJs.loadStripe('pk_123')

    if (stripe) {
        initElements(stripe)
    }
}

function initElements(stripe: StripeJs.Stripe) {
    // ...
}

loadStripe is perfectly getting imported on mine


Documentation build fails on docs.rs

We need GEOS >= 3.11, but docs.rs only has GEOS 3.10.2: https://docs.rs/crate/geoarrow/0.3.0-beta.1/builds/1334705. Do we know if https://github.com/geoarrow/geoarrow-rs/blob/32c82fc9d787ae191d0716138a4544dce7596a47/Cargo.toml#L73 a hard floor, or could we bump that down one MINOR to (hopefully) get docs.rs building?
The other alternative is to remove all geos-enabling features from docs.rs builds, which isn't ideal.

Hmm can you try setting v3_10_0 and see if it compiles?
We use CoordSeq::new_from_buffer here: https://github.com/geoarrow/geoarrow-rs/blob/32c82fc9d787ae191d0716138a4544dce7596a47/src/io/geos/scalar/coord/interleaved.rs#L9
But apparently that's in v3_10_0: https://github.com/georust/geos/blob/12b5889032c78042b570278a4fc86486186b7f11/src/coord_seq.rs#L177

Worked locally ... I tried to get docs.rs local builds set up but ended up being a too much of a rabbit hole. So, #707 bumps us to beta.2.

Fixed! https://docs.rs/geoarrow/0.3.0-beta.2/geoarrow/index.html

Feature flags are now in the docs, e.g. https://docs.rs/geoarrow/0.3.0-beta.2/geoarrow/io/index.html:


Principal attribute option is not set on form

I am sending the data for this field (if I'm looking at the right one) as
userAttrProvider: {
    type: "attr"
    value: "groupMembership"
    valueAnon: ""
    valueAttr: "groupMembership"
}

When I to a get back though I get the type as "default" again even though the value has properly been sent. Please check this on your end.

The block would need to be either:
"userAttrProvider" : {
      "value" : "aGVsbG93b3JsZA==",
      "type" : "anon"
    },

OR
    "userAttrProvider" : {
      "value" : "cn",
      "type" : "attr"
    },

OR
    "userAttrProvider" : {
      "value" : null,
      "type" : "default"
    },

Pushed a fix to account for the attr option.

Yeah, I understand that valueAnon and valueAttr are just extras I created. Appears to be working now except that under Username Attribute Provider Options the Salt Setting string is being converted from what I saved to something else when I re-load the same Edit Service.

Pushed fix.


Script Editor over expanding when using "Search & Replace"

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Build 3453bf5
Issue description:
When using the "Search & Replace" tool, if no matches are found, the editor will over expand to the side:

This is likely due to lack of space, my max resolution is 1366x768 but I think if the "No Matches" warning was moved down, this could be easily fixed, here is my complete window:

I tried to look at this issue and found that this seems to be the default behavior when text is clipped. For example in the screenshot below the long code is clipping out of the editor box.

I think i might have fixed this, could you test again?

@reduz Nope, fresh build, still happens.

This seems to have been fixed now. Closing it.