Implement 3D collision detection using bounding box

Now that we have 3D transformations, the next step is to consider simple collision detection in 3D using bounding (3D) boxes.
This needs to be done before integrating FXyz, i.e. #901
The API should match what already exists for 2D, ideally through BoundingBoxComponent

[ ] BoundingShape has box2d Shape converter which doesn't work for 3D shapes, so API needs to be tweaked
[ ] BoundingBoxComponent::checkCollision for 3D needs to be refactored to be GC-free.
[ ] BoundingBoxComponent::checkCollision currently only works for local origin 0,0,0 and HitBox has no Z aspect


Fix discovery package README with the right --cluster* flags

docs-review was skipped for #16229 but the README was not updated to include the new flag names.
/cc @icecrime
Signed-off-by: Alexandre Beslic<EMAIL_ADDRESS>

thanks @abronan LGTM

@thaJeztah @moxiegirl could you pls review full docs from #16229 ?

@LK4D4 Thank you for the heads up.  I'll go review those.  I've already talked with @mavenugo  about updating the network docs.  So, I'll include those in them.

@moxiegirl thanks. but the discovery feature is not networking specific.
As @LK4D4 pointed out, I think this must be reviewed as an independent feature. Multi-host networking will be dependent heavily on this one though.

@mavenugo ah, thanks for the clarification.  I'll do that.

Bit confused; is this still needed, or will this be included in another docs update?

@thaJeztah this is needed here and also in updated docs.
LGTM

thanks for explaining, LGTM

ping @moxiegirl I just noticed you didn't LGTM yet here, think it's okay, but apologies :-)

No worries.


Mutlithreading in python

Closes #10

@baffelli Please double-check that my commit updates the skeleton of exercise 1 correctly. I used the code from the latest version of the old branch. Without these changes, the notebook could not run.

I set the PR "ready for review" since in fact it has been reviewed.

I set the PR "ready for review" since in fact it has been reviewed.

Wait, there are a couple of things that should be fixed still. Some of the problems with running the code that @despadam had should be investigated.

Wait, there are a couple of things that should be fixed still. Some of the problems with running the code that @despadam had should be investigated.

But "Ready for review" means only that it is ready for review, nothing more than that. We merge things only when they are approved.

Yes, just reviewing for now. Not merging yet, but it shouldn't be a draft anymore.

For me the examples in the section High-level interface: Process pools cannot run. I get the following error in the console:
Process SpawnPoolWorker-1: Traceback (most recent call last):   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\process.py", line 314, in _bootstrap     self.run()   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\process.py", line 108, in run     self._target(*self._args, **self._kwargs)   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\pool.py", line 114, in worker     task = get()   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\queues.py", line 367, in get     return _ForkingPickler.loads(res) AttributeError: Can't get attribute 'task' on <module '__main__' (built-in)> Process SpawnPoolWorker-3: Traceback (most recent call last):   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\process.py", line 314, in _bootstrap     self.run()   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\process.py", line 108, in run     self._target(*self._args, **self._kwargs)   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\pool.py", line 114, in worker     task = get()   File "C:\Users\adde\AppData\Local\miniconda3\envs\python-tutorial\lib\multiprocessing\queues.py", line 367, in get     return _ForkingPickler.loads(res) AttributeError: Can't get attribute 'task' on <module '__main__' (built-in)>

As agreed with @baffelli, it is best to merge and see if the examples and exercises will work on Binder, as this is the most pressing matter. It appears that the errors as OS dependent, so let's make sure that it will work online and then we can discourage the participants from running the tutorial locally, for this section at least.

Let's try it here

Binder is unfortunately down now, and the error @despadam mentioned happens on my two machines as well. Not sure what we can do.

Binder is unfortunately down now, and the error @despadam mentioned happens on my two machines as well. Not sure what we can do.

That's really unfortunate. It seems to be highly OS dependent or maybe it's just a special case that runs on VSCode with the Jupiter extension. It might be that they implement a different Ipython kernel. I hope it works on Binder tomorrow, if not I'll try to walk people through examples in order to fill at least 1.5 hours

Minor changes to the text. Still, I cannot make the notebook work with any Python version I tested. I'm sure I'm missing something in the setup, but for me the entire notebook is in a "broken" state.


gulp.watch stops watching files after first detection

After the first modification to index.html, gulp.watch will stop detecting changes to the file. This issue does not exist for me on 3.9.1.

gulp.task('watch', watch);

function reloadBrowserSync(cb) {
  console.log('sssssssssssssssss');
  cb();
}

function watch(done) {
  gulp.watch(['/home/one/github/one-drop/src/index.html',
             '/home/one/github/one-drop/src/app/**/*.html'], reloadBrowserSync);
}

one@development ~/github $ node --version
v4.2.2
one@development ~/github $ npm --version
2.14.7

one@development ~/github/drop $ gulp -v
[15:11:54] CLI version 1.2.2
[15:11:54] Local version 4.0.0-alpha.2

Reference issue 1783

Please stop opening support questions here. This issue tracker is for bugs. Support questions should be directed to StackOverflow.

sorry, this isn't a bug since gulp 3.9.1 does not have this issue with the same exact code?

No, it's changed behavior with the way the watch method works. When using a semver major bump, you can't expect things to go unchanged.

@phated I'm having the same issue and so others. Could you point out some documentation about why/what did it changed?

@phated Do we have documentation for this behavior? Also wondering what changed here

Hey guys, we just found a strange solution. I was writing my gulp tasks using ES6, so tasks were defined using arrow functions:
// The args object is just a bunch of paths
gulp.task('watch', ['watch:html'])
gulp.task('watch:html', _ => {
  gulp.watch(args.html.watch, ['build:html'])
})
gulp.task('watch:css', _ => {
  gulp.watch(args.css.vendor.src, ['build:css'])
})

Replacing the arrows with normal anonymous functions suddenly solved the issue of gulp.watch() firing only once:
gulp.task('watch', ['watch:html'])
gulp.task('watch:html', function () {
  gulp.watch(args.html.watch, ['build:html'])
})
gulp.task('watch:css', function () {
  gulp.watch(args.css.vendor.src, ['build:css'])
})

So now I'm not completely sure if those errors are related. It's also weird.

@contra this was fully documented at https://github.com/gulpjs/glob-watcher/blob/master/README.md with the 3.0.0 release of that library.

@joelwallis if you are using that syntax, you aren't using gulp 4

@phated I don't see this behavior documented there. .watch(globs, fn) should call fn every time a file matching the globs changes as long as the fn signals completion, right? This issue is saying that isn't what is happening.

The author updated his sample after I closed it and likely didn't actually test because he was spamming us at the time. It behaves as documented: the fn is fired or queued given async completion and a 200ms default debounce.

@contract and as I noted, the other person that jumped in this thread isn't using gulp 4...

Sorry, I replied with the answer but for some reason I can not find that reply. Perhaps I looked on preview and forgot to save.
I found the answer to this issue here: http://stackoverflow.com/questions/28681491/within-docker-vm-gulp-watch-seems-to-not-work-well-on-volumes-hosted-from-the-h
Most likely, if that person is transpiling the time gap is enough to cause his issue in which polling and interval options would fix this.

@phated Yeah, didn't see it prior to the edit so was confused about why his code wouldn't be working. Don't think there's anything else to discuss then.

@alexisdiel thanks for that!


Add QoS for network interface

Signed-off-by: Pengfei Ni<EMAIL_ADDRESS>Signed-off-by: Lai Jiangshan<EMAIL_ADDRESS>

LGTM


Does fastapi have a maximum defined http interface limit?

I have defined 23 interfaces in fastapi，When I want to add the http interface to fastapi again, it is not displayed in http://hostname:port/docs, and it is returned
{
"detail": "Not Found"
}
when requested
I didn’t find the relevant description in the document, I was full of ...

Reopen the project, the problem is solved, I don’t know why

Thanks for reporting back and closing the issue 👍


Improve PHPUnit tests

Changed log

Adding the php-5.5 and php-7.4 version tests during GitHub Action building.
Removing Travis CI building file.
Using the ^4.8.36 for PHPUnit version to use PHPUnit\Framework\TestCase namespace.
Fixing class namespace for tests/HttpAdapter/CurlAdapterTest.php and tests/HttpAdapter/GuzzleAdapterTest.php classes.

I am currently working on an overhaul/modernization of this library, which will require a minimum PHP version of 7.4, so I'm closing this PR.


Update RedBeanPHP to 5.7 and apply a hack to fix failing tests

Seems to work fine on an actual server, and the tests are passing. I'll merge this.
I also put an issue in with RedBeanPHP asking for help on the issue we were experiencing, if we can figure it out we can switch to the composer version of it


Fuzzing integration

Hi guys. Proposing to add integration with a fuzzing service. Fuzzit gives free service to open source projects.
This patch fuzzes the Eval() method.
The build will fail due to an absent API key. I've run successful tests under my own Travis account. If you're interested the setup is like this:

In Fuzzit create a target yaegi.
In Fuzzit settings grab an API key. In repo settings in Travis paste it to an envvar FUZZIT_API_KEY.

 Going to post the data and some examples.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Here's the data from go-fuzz. It outputs this crashers directory with a set of files for each crash.
crashers.zip

Some example crashes.
i.Eval("*.0.S")

panic: reflect: FieldByName of non-struct type [recovered]
	panic: 1:29: CFG post-order panic: reflect: FieldByName of non-struct type

goroutine 1 [running]:
github.com/containous/yaegi/interp.(*Interpreter).cfg.func2.1(0xc000098b00)
	/home/user/go/src/github.com/containous/yaegi/interp/cfg.go:317 +0xba
panic(0x5e44c0, 0x66fd70)
	/usr/share/go/src/runtime/panic.go:522 +0x1b5
reflect.(*rtype).FieldByName(0x5e2a80, 0x7c3c33, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/usr/share/go/src/reflect/type.go:942 +0x135
github.com/containous/yaegi/interp.(*itype).lookupBinField(0xc00006bee0, 0x7c3c33, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/home/user/go/src/github.com/containous/yaegi/interp/type.go:602 +0xa9
github.com/containous/yaegi/interp.(*Interpreter).cfg.func2(0xc000098b00)
	/home/user/go/src/github.com/containous/yaegi/interp/cfg.go:1168 +0x398b
github.com/containous/yaegi/interp.(*node).Walk(0xc000098b00, 0xc000049d80, 0xc000049db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:114 +0xaf
github.com/containous/yaegi/interp.(*node).Walk(0xc000098a00, 0xc000049d80, 0xc000049db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:111 +0x70
github.com/containous/yaegi/interp.(*node).Walk(0xc000098900, 0xc000049d80, 0xc000049db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:111 +0x70
github.com/containous/yaegi/interp.(*node).Walk(0xc000098800, 0xc000049d80, 0xc000049db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:111 +0x70
github.com/containous/yaegi/interp.(*Interpreter).cfg(0xc00009e120, 0xc000098800, 0xc00001a220, 0x4, 0x0, 0x0, 0x4)
	/home/user/go/src/github.com/containous/yaegi/interp/cfg.go:39 +0x1b2
github.com/containous/yaegi/interp.(*Interpreter).Eval(0xc00009e120, 0x63291a, 0x5, 0x0, 0x0, 0xc00009e120, 0x7c3be0, 0x5e27c0)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:253 +0x135
main.main()
	/home/user/go/src/github.com/containous/yaegi/test.go:11 +0x8b
exit status 2

i.Eval("0=0")

1:28: panic
panic: reflect: reflect.Value.Set using unaddressable value [recovered]
	panic: reflect: reflect.Value.Set using unaddressable value

goroutine 1 [running]:
github.com/containous/yaegi/interp.runCfg.func1(0xc0000700f0, 0xc000098900)
	/home/user/go/src/github.com/containous/yaegi/interp/run.go:107 +0x1e9
panic(0x5e44c0, 0xc000010590)
	/usr/share/go/src/runtime/panic.go:522 +0x1b5
reflect.flag.mustBeAssignable(0x82)
	/usr/share/go/src/reflect/value.go:234 +0x13a
reflect.Value.Set(0x5e3bc0, 0x7f4900, 0x82, 0x5e3bc0, 0xc00001a230, 0x82)
	/usr/share/go/src/reflect/value.go:1467 +0x2f
github.com/containous/yaegi/interp.assign.func3(0xc0000700f0, 0x63dbe8)
	/home/user/go/src/github.com/containous/yaegi/interp/run.go:258 +0xb6
github.com/containous/yaegi/interp.runCfg(0xc000098900, 0xc0000700f0)
	/home/user/go/src/github.com/containous/yaegi/interp/run.go:112 +0x70
github.com/containous/yaegi/interp.(*Interpreter).run(0xc00009e120, 0xc000098800, 0x0)
	/home/user/go/src/github.com/containous/yaegi/interp/run.go:93 +0x129
github.com/containous/yaegi/interp.(*Interpreter).Eval(0xc00009e120, 0x6325e7, 0x3, 0x0, 0x0, 0xc00009e120, 0x7c3be0, 0x5e27c0)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:285 +0x2ff
main.main()
	/home/user/go/src/github.com/containous/yaegi/test.go:11 +0x8b
exit status 2

i.Eval("0<nil>0")

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: 1:28: CFG post-order panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x98 pc=0x5859e7]

goroutine 1 [running]:
github.com/containous/yaegi/interp.(*Interpreter).cfg.func2.1(0xc0000b8b00)
	/home/user/go/src/github.com/containous/yaegi/interp/cfg.go:317 +0xba
panic(0x5f4b40, 0x7cf400)
	/usr/share/go/src/runtime/panic.go:522 +0x1b5
github.com/containous/yaegi/interp.isInt(...)
	/home/user/go/src/github.com/containous/yaegi/interp/type.go:797
github.com/containous/yaegi/interp.isNumber(0x0, 0x0, 0x1)
	/home/user/go/src/github.com/containous/yaegi/interp/type.go:835 +0x27
github.com/containous/yaegi/interp.(*Interpreter).cfg.func2(0xc0000b8b00)
	/home/user/go/src/github.com/containous/yaegi/interp/cfg.go:529 +0x7d46
github.com/containous/yaegi/interp.(*node).Walk(0xc0000b8b00, 0xc0000a9d80, 0xc0000a9db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:114 +0xaf
github.com/containous/yaegi/interp.(*node).Walk(0xc0000b8a00, 0xc0000a9d80, 0xc0000a9db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:111 +0x70
github.com/containous/yaegi/interp.(*node).Walk(0xc0000b8900, 0xc0000a9d80, 0xc0000a9db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:111 +0x70
github.com/containous/yaegi/interp.(*node).Walk(0xc0000b8800, 0xc0000a9d80, 0xc0000a9db8)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:111 +0x70
github.com/containous/yaegi/interp.(*Interpreter).cfg(0xc0000be120, 0xc0000b8800, 0xc0000780f8, 0x4, 0x0, 0x0, 0x4)
	/home/user/go/src/github.com/containous/yaegi/interp/cfg.go:39 +0x1b2
github.com/containous/yaegi/interp.(*Interpreter).Eval(0xc0000be120, 0x632ddf, 0x7, 0x0, 0x0, 0xc0000be120, 0x7c3be0, 0x5e27c0)
	/home/user/go/src/github.com/containous/yaegi/interp/interp.go:253 +0x135
main.main()
	/home/user/go/src/github.com/containous/yaegi/test.go:11 +0x8b
exit status 2

Hello,
Fuzz tests are interesting but for now we don't want to add another saas tool in our workflow.
Thank you for your interest in the project.

Thanks for looking at it @ldez.

Hi!
Sorry for unburying this PR,
Why not fuzzy-testing Yaegi? Running go-fuzz locally for a few minutes uncovered more than 300 inputs that made the interpreter panic
2019/11/20 10:12:55 workers: 8, corpus: 567 (1m55s ago), crashers: 314, restarts: 1/68, execs: 6964781 (4643/sec), cover: 3023, uptime: 25m0s

Once Yaegi is integrated into Traefik, I'm pretty sure no one wants the interpreter to be the source of crashes 😁
How can we proceed? I'll try to smash some of these bugs 🙂
Maybe we can begin with having a Fuzz function in a fuzz.go in the interp package, similarly to what is done in github.com/golang/go? It's fine if people have to run go-fuzz manually at first; then maybe a proper CI integration can be thought of


feat: update template structure []

After working on the tasks-app, we found a few improvements that we would like to have in the general template.
Commits:

feat: change template to have a deeper structure
feat: configure default testId in template for testing-library
feat(template): update imports and improve types
feat(template): enhance gitignore

Do you think that making the folder structure more deeply nested really helps developer onboarding? To me it seems like we're making code discover marginally harder with little obvious benefit.

Do you think that making the folder structure more deeply nested really helps developer onboarding? To me it seems like we're making code discover marginally harder with little obvious benefit.

I would say it really depends whether you want to use this template for a small use case with a few lines of code or if it's meant to be used for massive product development (like tasks-app or workflows-marketplace-app). In both cases, we're bootstrapping with this repo but then rewriting a lot of code and config. Instead, I would love to see better coding practices (like max. 10 files per folder) in this template as it's also used by our customers.

@Jwhiles Hey John, let me know if you any further questions on this, so I can unblock it (after fixing the tests) :)

Hey @Chaoste - I think some members of the team @andipaetzold and @loweisz are looking into making some more far reaching changes to CCA, and that making these changes to the structure of the output are just adding extra churn to something that will be changing more dramatically anyway.
I think if you're happy to remove the structural changes, we'd be happy to add the test-id, gitignore, and type improvements.

Hey @Chaoste - I think some members of the team @andipaetzold and @loweisz are looking into making some more far reaching changes to CCA, and that making these changes to the structure of the output are just adding extra churn to something that will be changing more dramatically anyway.
I think if you're happy to remove the structural changes, we'd be happy to add the test-id, gitignore, and type improvements.

Thanks for the feedback. I removed the folder structure and added a fix to the tests to remove TS errors(cma prop was missing)


fix: fix decode bytes for scan_files_from_file

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.10%. Comparing base (e9a49c3) to head (1b4dd24).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   69.10%   69.10%
=======================================
  Files          15       15
  Lines         670      670
  Branches       77       77
=======================================
  Hits          463      463
  Misses        188      188
  Partials       19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Artifact download links are slightly different between 1.3.3 and 1.3.5

https://github.com/containerd/containerd/releases/download/v1.3.5/containerd-1.3.5-linux-amd64.tar.gz
https://github.com/containerd/containerd/releases/download/v1.3.3/containerd-1.3.3.linux-amd64.tar.gz
Note the -linux and .linux.
Question is: Do we want to keep the new one or go back to the old one?
cc @dmcgowan @estesp

This was introduced by https://github.com/containerd/containerd/pull/4280
AFAICT travis used the Makefile, which used https://github.com/containerd/containerd/blob/master/Makefile#L67
New: https://github.com/containerd/containerd/blob/release/1.3/.github/workflows/release.yml#L115

In discussing with @dims, while this change was not intentional with the switch in release artifact methods, we prefer the hyphen-separated filename for consistency. Given that, if downstream users can handle the change, we already know that we've released 1.4.0 betas with this model, and will attempt not to make any future changes to the filename pattern.

Thanks @estesp


[chaotic-good] Client & server transport

Adapts work from https://github.com/grpc/grpc/pull/34728 and previous changes from @nanahpang, implements new v3 filter/transport interface, and brings up the core of the chaotic good transport.
The next change will bring a more complete test suite (for this and inproc).

@Vignesh2208 thanks for the review! Addressed comments, and fixed the failing tests (a bug slipped into promise based endpoint that I've now addressed)


add link

Add a helpful link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Extendability of multi-provided classes

Currenlty the multi-provided classes like normalizers or http interceptors are often provided with the option useClass, which hardcodes the class reference and doesn't allow for any extendability, nor for switching off those classes.
To solve those issues, we should simply provide those tokens with the option useExisting instead of useClass and and mark the class with providedIn: 'root' in the @Injectable decorator.
Example:

file product-occ.module.ts
Instead of:
{
  provide: PRODUCT_NORMALIZER,
  useClass: ProductNameNormalizer,
  multi: true,
},

let's do:
{
  provide: PRODUCT_NORMALIZER,
  useExisting: ProductNameNormalizer,
  multi: true,
},

and

file product-name.normalizer.ts
Instead of:
@Injectable()
export class ProductNameNormalizer ...

let's do:
@Injectable({ providedIn: 'root' })
export class ProductNameNormalizer ...

Link to the original discussion in the slack: https://spartacus-storefront.slack.com/archives/CD16V16FR/p1568635837012900

https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/5374

Closed #5374 as the change should only apply to case where multiple providers may be present. Opened https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/5380.

QA: This is not really testable by QA other than that there should be no negative impact to the storefront and all the tests should pass.

Running the e2e tests on dev10 had many failures.
Therefore did some quick smoke tests manually. Looks ok.
the one e2e test that i tried manually because it failed on cypress is the consignment tracking, but i think it's just data issue.


how to get model name, its field information and type using prisma client?

model User {
  user_id  Int      @id @default(autoincrement())
  name     String?
  email    String   @unique
  isAdmin  Boolean  @default(false)
}

how to get model name, its field information(e.g user_id,name..) and type(int, string,..) using prisma client?

Hi,
Currently you can only get this fields via the DMMF(datamodel meta format) which the client exposes but it is not an ideal way. Here how you can do it:
import { dmmf } from "@prisma/client";

console.log(dmmf.datamodel.models);

But I would like to know your use case for accessing this information as ideally you would know the model that you are going to query in your application.


Added Personalized Hello,Bye and Help Messages

Added Personalized Hello,Bye and Help Messages

Merged in 156fa1a509853e5ae97c8a592ddee312d5281750

Thanks @UshalNaidoo! 👍


Add fingerprints for all fingerprintdb issues in ooni/pipeline

We currently have over 50 issues labeled fingerprintdb.
As part of https://github.com/ooni/pipeline/issues/136 we should add all of these to the pipeline and re-run the pipeline to flag them as confirmed.
See: https://github.com/ooni/pipeline/blob/master/docs/reprocess-report.md#case-new-html-blockpage-fingerprint

This has been done.

Thanks to @anadahz from magma for the great work in documenting the blockpage fingerprints and filing the many issues that lead to this PR being merged!
It's very much appreciated! 🎉


python38Packages.google-crc32c: 1.1.2 -> 1.1.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.google-crc32c is: "Wrapper the google/crc32c hardware-based implementation of the CRC32C hashing algorithm"
meta.homepage for python38Packages.google-crc32c is: "https://github.com/googleapis/python-crc32c"
meta.changelog for python38Packages.google-crc32c is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.1.3 with grep in /nix/store/jzgyznwj17p52psdi4cs7vks0zndp148-python3.8-google-crc32c-1.1.3

found 1.1.3 in filename of file in /nix/store/jzgyznwj17p52psdi4cs7vks0zndp148-python3.8-google-crc32c-1.1.3

directory tree listing: https://gist.github.com/c51bf525d4a2f63492b300eff6bfa03f

du listing: https://gist.github.com/b7c93f7a21b438638a0d4066127fc66c

Rebuild report (if merged into master) (click to expand)

96 total rebuild path(s)

24 package rebuild(s)

24 x86_64-linux rebuild(s)
24 i686-linux rebuild(s)
24 x86_64-darwin rebuild(s)
24 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dvc-with-remotes
python38Packages.gensim
python38Packages.google-cloud-automl
python38Packages.google-cloud-bigquery
python38Packages.google-cloud-storage
python38Packages.google-crc32c
python38Packages.google-resumable-media
python38Packages.pathy
python38Packages.smart-open
python38Packages.spacy
python38Packages.spacy-transformers
python38Packages.textacy
python39Packages.gensim
python39Packages.google-cloud-automl
python39Packages.google-cloud-bigquery
python39Packages.google-cloud-storage
python39Packages.google-crc32c
python39Packages.google-resumable-media
python39Packages.pathy
python39Packages.smart-open
python39Packages.spacy
python39Packages.spacy-transformers
python39Packages.textacy
snakemake

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jzgyznwj17p52psdi4cs7vks0zndp148-python3.8-google-crc32c-1.1.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.google-crc32c https://github.com/r-ryantm/nixpkgs/archive/d97f0e95d0dc1aba2af9e12b4586c0c68fe965d2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jzgyznwj17p52psdi4cs7vks0zndp148-python3.8-google-crc32c-1.1.3
ls -la /nix/store/jzgyznwj17p52psdi4cs7vks0zndp148-python3.8-google-crc32c-1.1.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages failed to build:

python38Packages.spacy
python38Packages.spacy-transformers
python38Packages.textacy
python39Packages.spacy
python39Packages.spacy-transformers
python39Packages.textacy

18 packages built:

dvc-with-remotes
python38Packages.gensim
python38Packages.google-cloud-automl
python38Packages.google-cloud-bigquery
python38Packages.google-cloud-storage
python38Packages.google-crc32c
python38Packages.google-resumable-media
python38Packages.pathy
python38Packages.smart-open
python39Packages.gensim
python39Packages.google-cloud-automl
python39Packages.google-cloud-bigquery
python39Packages.google-cloud-storage
python39Packages.google-crc32c
python39Packages.google-resumable-media
python39Packages.pathy
python39Packages.smart-open
snakemake

Maintainer pings
cc @freezeboy @SuperSandro2000 for testing.

Probably some parallelism issue like it is often.


[Kernel][Expressions] Make the default expression handler evaluation lazy

Feature request
Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[X] Kernel
[ ] Other (fill in here)

Overview
The expression handler should short-circuit on logical operators.
First step: Convert all comparators (e.g. =, > etc) to be lazy.
Rough idea on how to do that is:

Create a comparator based on the data type of inputs. Both inputs are expected to have the same inputs.

interface VectorComparator {
   /*
    * Compare the entry at given `rowId` in `left` and `right` vectors and return the comparison
    * result (-1, 0, 1)
   int compare(ColumnVector left, ColumnVector right, int rowId)
}

We need utility method that can create these comparator. Pseudo code looks like below

  DataType dataType = left.getDataType();

   if (dataType instance BooleanType) {
      return new VectorComparator() {
        int compare(ColumnVector left, ColumnVector right, int rowId) {
            boolean leftResult = left.getBoolean(rowId);
            boolean rightResult = right.getBoolean(rowId);
            return Boolean.compare(leftResult, rightResult);
        }
     } else if (dataType instance of IntegerType) {
    ....
     }
     .. more types...
   }

Return a ColumnVector that wraps the above created comparator and returns result based on the comparator operator type

return new ColumnVector() {
   public getDataType() { return BooleanType.BOOLEAN;}

   public getSize() { argResults.leftResult.getSize(); }

   public isNullAt(int rowId) {
       boolean isLeftNull = argResults.leftResult.isNullAt(rowId);
       boolean isRightNull = argResults.rightResult.isNullAt(rowId);
       return (isLeftNull && !isRightNull) || (!isLeftNull && isRightNull);
   }

  public getBoolean(int rowId) {
      // check both are null. if yes return true, otherwise..

     // `==` will change depending upon the operator we are evaluating.
      compartor.compare(leftResult, rightResult, rowId) == 0
   }
}

Willingness to contribute
The Delta Lake Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature?

[ ] Yes. I can contribute this feature independently.
[ ] Yes. I would be willing to contribute this feature with guidance from the Delta Lake community.
[x] No. I cannot contribute this feature at this time.

FYI , I am working on this right now per recommendation from https://github.com/delta-io/delta/pull/2830#issuecomment-2032311536
Will submit a PR in a few days
Thanks :)

Hi @vkorukanti  I added lazy evaluation support for comparator expressions
https://github.com/delta-io/delta/pull/2853
I have some question on the behavior of null comparison, if you have time can you take a look
Thank you


🚀Release To Preview - v1.0.0-preview.11

Preview Release PR Description
This pull request performs a preview release for version v1.0.0-preview.11
How Has This Been Tested?

[ ] Testing Application (Manual)
[ ] No Testing Required

Development Checklist:
Types Of Changes:

[ ] Bug Fix(es)

[ ] A bug label has been added to the PR

[ ] Contains breaking change(s)

💡 This would force library users to change there code.  This would involve a public facing API change, behavior that would force a change to the users code base, or even an update in behavior that could force a change to the library users code base.  Sometimes this it is unclear if the change is a breaking change.  If it is unclear, reach out so we can discuss and investigate if it is indeed a breaking change.

[ ] Additional feature and/or behavior added.

[ ] An enhancement label has been added to the PR

[ ] I have changes related to workflows (CI/CD)

💡 These kind of changes are only done by the project owner and maintainers that are aloud to make changes to workflows
[ ] An workflow label has been added to the PR

Documentation:

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.
[ ] A documentation label has been added to the PR

Testing:

[ ] My change requires unit tests to be written

[ ] I have added tests to cover my changes.

[ ] I have manually tested my changes to the best of my ability

Review Checklist:

[x] PR title matches the example below with the correct version

💡 Example: 🚀Release To Preview - v1.2.3-preview.4

[x] The [add version here] text in the PR description replaced with the version.
[ ] Issue[s] exists and is linked to this PR.
[ ] My code follows the coding style of this project.

💡 This is enforced by the .editorconfig files in the project and displayed as warnings.  If there is an edge case with coding style that should be ignored or changed, reach out and lets discuss it.

[ ] All tests passed locally.

💡 Status checks are put in place to run unit tests every single time a change is pushed to a PR.  This does not mean that the tests pass in both the local and CI environment.

[ ] Update library version by updating the <Version/> and <FileVersion/> tags in the Velaptor .csproj file.

💡 Every change to a PR will run a status check to confirm that the version has the correct syntax, a tag does not exist, and that it has not already been published to nuget.org
💡 Make sure to add the -preview.<number> syntax to the end of the version

Example:<Version>1.2.3-preview.4</Version>
<FileVersion>1.2.3-preview.4</FileVersion>

[ ] I have updated the release notes by creating a new preview release notes file and adding it to the ./Documentation/ReleaseNotes/PreviewReleases folder
[ ] A preview label has been added to the PR

After doing some investigation into issue #66, the end result is that there are no code changes to the libraries at all.  All changes are to workflows and documentation itself.  This means there is no need or requirement to perform a release.
This PR will simply be closed without merging in the changes.  All of the commits on the preview/v1.0.0-preview.11 branch will be cherry picked to the version/v1.0.0 branch with no release performed.
The preview/v1.0.0-preview.11 branch will simply be deleted.


DateRange - minute vs. minutes

I tried to create a DateRange in five minute steps.
In [40]: DateRange(datetime(2011,11,11), datetime(2011,11,12), offset=DateOffset(minute=5))
The %CPU is 100  and it consumes a lot of memory but nothing happens, no result and no error. I continued to experiment and realized that i wrote 'minute' instead of 'minutes'
In [41]: DateRange(datetime(2011,11,11), datetime(2011,11,12), offset=DateOffset(minutes=5))
My suggestion is to maybe add some kind of argument check.

Thanks for pointing this out. The problem is DateOffset takes as parameters anything that relativedelta from dateutil does. i think we should disallow this for 0.8

Should be easy to catch the infinite loop. I'll take a look

I already fixed this on 1/26 in https://github.com/pydata/pandas/commit/daf0c67da7449ba3fc7efe7b8d8230e26c1ad50c . Will be in 0.7.1 release


ProgrammingError: column t1.given_name does not exist

I have an Openshift v4.3.9 cluster (3 x masters, 3 x workers) and trying to use Quay operator.
The install seems to be ok with the basic config plus with Clair enabled.
Checking the logs of the POD: example-quayecosystem-quay-config-xxx I can see many errors like the following:
.
.
.
2020-05-06 06:43:40,861 [61] [DEBUG] [peewee] ('SELECT "t1"."id", "t1"."uuid", "t1"."username", "t1"."password_hash", "t1"."email", "t1"."verified", "t1"."stripe_id", "t1"."organization", "t1"."robot", "t1"."invoice_email", "t1"."invalid_login_attempts", "t1"."last_invalid_login", "t1"."removed_tag_expiration_s", "t1"."enabled", "t1"."invoice_email_address", "t1"."given_name", "t1"."family_name", "t1"."company", "t1"."location", "t1"."maximum_queued_builds_count", "t1"."creation_date", "t1"."last_accessed" FROM "user" AS "t1" LIMIT %s', [1])
gunicorn-config stdout | 2020-05-06 06:43:40,861 [61] [DEBUG] [peewee] ('SELECT "t1"."id", "t1"."uuid", "t1"."username", "t1"."password_hash", "t1"."email", "t1"."verified", "t1"."stripe_id", "t1"."organization", "t1"."robot", "t1"."invoice_email", "t1"."invalid_login_attempts", "t1"."last_invalid_login", "t1"."removed_tag_expiration_s", "t1"."enabled", "t1"."invoice_email_address", "t1"."given_name", "t1"."family_name", "t1"."company", "t1"."location", "t1"."maximum_queued_builds_count", "t1"."creation_date", "t1"."last_accessed" FROM "user" AS "t1" LIMIT %s', [1])
2020-05-06 06:43:40,873 [61] [DEBUG] [data.database] Disconnecting from database.
gunicorn-config stdout | 2020-05-06 06:43:40,873 [61] [DEBUG] [data.database] Disconnecting from database.
2020-05-06 06:43:40,873 [61] [ERROR] [gunicorn.error] Error handling request /api/v1/superuser/config/createsuperuser
Traceback (most recent call last):
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/gunicorn/workers/base_async.py", line 56, in handle
self.handle_request(listener_name, req, client, addr)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/gunicorn/workers/ggevent.py", line 160, in handle_request
addr)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/gunicorn/workers/base_async.py", line 107, in handle_request
respiter = self.wsgi(environ, resp.start_response)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 2463, in call
return self.wsgi_app(environ, start_response)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 2449, in wsgi_app
response = self.handle_exception(e)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/init.py", line 269, in error_router
return original_handler(e)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 1866, in handle_exception
reraise(exc_type, exc_value, tb)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/init.py", line 266, in error_router
return self.handle_error(e)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/utils/cors.py", line 35, in wrapped_function
resp = make_response(f(*args, **kwargs))
File "/quay-registry/config_app/config_endpoints/api/init.py", line 26, in handle_error
return super(ApiExceptionHandlingApi, self).handle_error(error)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 2446, in wsgi_app
response = self.full_dispatch_request()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 1951, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/init.py", line 269, in error_router
return original_handler(e)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 1820, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/init.py", line 266, in error_router
return self.handle_error(e)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/utils/cors.py", line 35, in wrapped_function
resp = make_response(f(*args, **kwargs))
File "/quay-registry/config_app/config_endpoints/api/init.py", line 26, in handle_error
return super(ApiExceptionHandlingApi, self).handle_error(error)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 1949, in full_dispatch_request
rv = self.dispatch_request()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/app.py", line 1935, in dispatch_request
return self.view_functionsrule.endpoint
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/init.py", line 458, in wrapper
resp = resource(*args, **kwargs)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask/views.py", line 89, in view
return self.dispatch_request(*args, **kwargs)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/flask_restful/init.py", line 573, in dispatch_request
resp = meth(*args, **kwargs)
File "/quay-registry/config_app/config_endpoints/api/init.py", line 140, in wrapped
return func(self, *args, **kwargs)
File "/quay-registry/config_app/config_endpoints/api/suconfig.py", line 178, in post
if config_provider.config_exists() and not database_has_users():
File "/quay-registry/config_app/config_endpoints/api/suconfig.py", line 35, in database_has_users
return model.has_users()
File "/quay-registry/config_app/config_endpoints/api/suconfig_models_pre_oci.py", line 17, in has_users
return bool(list(User.select().limit(1)))
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 6655, in iter
self.execute()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 1812, in inner
return method(self, database, *args, **kwargs)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 1883, in execute
return self._execute(database)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 2054, in _execute
cursor = database.execute(self)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 3018, in execute
return self.execute_sql(sql, params, commit=commit)
File "/quay-registry/data/database.py", line 195, in execute_sql
cursor = super(RetryOperationalError, self).execute_sql(sql, params, commit)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 3012, in execute_sql
self.commit()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 2783, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/peewee.py", line 3005, in execute_sql
cursor.execute(sql, params or ())
ProgrammingError: column t1.given_name does not exist
LINE 1: ...s", "t1"."enabled", "t1"."invoice_email_address", "t1"."give...
^
gunicorn-config stdout | 2020-05-06 06:43:40,873 [61] [ERROR] [gunicorn.error] Error handling request /api/v1/superuser/config/createsuperuser
.
.
.

It seems noone really cares this problem :-(
In the last 6 month I was not able to do consistent successful installs of quay.
Now my Openshift is on 4.5 and quay-operator is 3.3, but I still have the same problem.
Postgresql reporting this column does not exist error and quayecosystem tells:       message: >-
Failed to create superuser: invalid character '<' looking for beginning
of value
In the last 2 days I've tried with and without precreated superuser secret, also tried with skipSetup and giving all parameters manually on quay config page (then I was not able to specify some required fields, however those were given at the creation of Quayecosystem object).
I'm quite disappointed with this now :-(

@lniesz the operator went through a massive rewrite from version 3.3 to version 3.4. Are you still unable to deploy the latest versions?

@ricardomaraschini
Hi, I have not tried it recently

This seems to be a problem during the database "migration" (or initialization). I can't reproduce it in the latest release so I recommend you to upgrade to it (v3.6.2). I am closing this issue as it refers to a very old version. Feel free to reopen if you think it is still relevant.


Backup INJINU info

Hello. Sorry for confusing you. As you can see, I added INJINU token yesterday.
Now our token info was changed by other guy, so It shows invalid token name and logo.
https://explorer.injective.network/asset/?tokenType=tokenFactory&denom=factory/inj1vjppa6h9lf75pt0v6qnxtej4xcl0qevnxzcrvm/INJINU
That's why I send new PR. Our token was listed on CoinGecko & CoinHall.
https://www.coingecko.com/en/coins/inj-inu
https://coinhall.org/injective/inj1fdqmqvgyyqr7h73l8lq07578fqfmrslsgdpfle
Please consider again and accept this PR.

Hello. Please approve my PR.
As you know, that was not me who changed our token info.
Kinja token guy modified our token info. It maybe his mistake or malicious purpose.
Anyway, I want to back up my token info. Our users ask me about that.
I hope your understanding.

okay, I'll add you token

Thanks


RAC - MenuTrigger executed on press start, causing unexpected behaviour

Provide a general summary of the issue here
The MenuTrigger component is executed on press start. If another element is rendered under the pointer on press end then it is triggered unintentionally.
🤔 Expected Behavior?
Releasing the pointer after launching the menu should not trigger other events on the page.
😯 Current Behavior
If another element is rendered under the pointer on press end then it is triggered unintentionally.
💁 Possible Solution
Change the behaviour so that MenuTrigger event is executed on press end. If it is essential to keep the current behaviour then press end events should be prevented during the same interaction.
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/s/elated-panini-gxzjnr?file=/src/App.js
This CodeSandbox demonstrates the issue. Clicking the button and then releasing immediately closes the menu.
Version
"react-aria-components": "1.0.0-beta.2"
What browsers are you seeing the problem on?
Chrome, Safari
If other, please specify.
No response
What operating system are you using?
macOS 12.6.5
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

This behavior is intentional and I don't think we would necessarily want to change this default behavior:
https://github.com/adobe/react-spectrum/blob/0e7d746f0f1424a22b3b31b98fcc16cb322ea286/packages/%40react-aria/menu/src/useMenuTrigger.ts#L111-L112
That being said, we could potentially add a new trigger option. Currently we have 'press' | 'longPress' but we could potential add pressend to handle use cases like this.
It seems like we could also look at treating the pressend differently based on how long the press was. I'm looking at this example from floating-ui and it seems to have good behavior that handles both cases.

I think we could also consider using pointer capture to prevent the press end from getting to the elements in the overlay
https://developer.mozilla.org/en-US/docs/Web/API/Element/setPointerCapture

Thanks. I think both approaches are good and could be complementary. Pointer capture would solve the issue for the current press behaviour. Adding pressend as an additional trigger option also seems reasonable as this may be preferable for a particular use case.


Choose a Shadow Dom Strategy

Per: http://blog.thoughtram.io/angular/2015/06/29/shadow-dom-strategies-in-angular2.html

I'm in for this. Anyone who knows more want to join in?

Yes! Let's chat about this.

We're recommending the EmulatedScopedShadowDomStrategy .

:+1:
/cc @willbuck The default is to scope styles in angular. It is set that way so that outer styles can't contaminate inner scoped items.


Tooltips Fixes / Text Mesh Pro Assets

Overview
Updates Tooltip prefabs to use more performant settings by default and replaces their TextMesh components with TextMeshPro components.
Also brings in some related Text Mesh Pro assets and fixes:

Single Pass Instanced compatible TMP shader from @Cameron-Micka
Standard Text Mesh Pro font assets from @cre8ivepark

Other improvements / fixes:

Tooltips now validate their hierarchy and auto-generate any missing transforms
Removed circular dependency that caused ToolTipConnector to add a second ToolTip component
Added handles for manipulating pivot and anchor
Added Bezier ToolTip prefab

Amazing, thank you!


chore: minor UX edits to autocomplete example

Two small adjustments here:

Change placeholder from bubbletea (as it's not actually completable)
Add autocomplete keys to the help text

Thank you so much!


__loop method not working in Karate version: 0.9.2

Hi Peter,
I am trying the same way mentioned via below link, but still unable to loop:
https://stackoverflow.com/questions/51017356/how-to-loop-with-in-the-feature-file-in-karate
Please do let me know in case I am missing anything.
Feature:
Background:

def jsonPathTest = Java.type('com.test.utility.FileUtility').getNames()

Scenario:

def jsonName = karate.get('jsonPathTest[' + __loop + ']')

NOTE : We are not allowed to snippet the code outside of any forums so referred this link for your reference, but I tried the same way mentioned above but unable to loop and script failing.

closing as duplicate of #1545
I'm sorry we insist on the rules. but first read the documentation: https://github.com/intuit/karate#built-in-variables-for-call

Hi Peter,
I read the document you mentioned and followed the same way, but looks like I am missing something and unable to loop.
The example mentioned to store values in json and iterate --- e.g. kittens
but what i am trying to do is to get the values from the excel sheet and iterate that row accordingly. For iterating the rows, I tried to use __loop method to get the row number via iteration value and fetch the data from excel accordingly. That's where I am facing the issue on iterating the rows accordingly.
Please help if you have any better solution to iterate the values via excel row by row.

yes, read the docs: https://github.com/intuit/karate#data-driven-features


Dark Theme Not Applying

Describe the bug
The app is stuck on light mode. Choosing to follow the system's theme or manually opting for the dark change nothing. Restarting the app or reinstalling it didn't change a thing either.
To Reproduce
Steps to reproduce the behavior:

Open the app
Make sure it should be on dark mode
Look at the app

Expected behavior
Dark mode.
Screenshots
Smartphone (please complete the following information):

Device: Doubt it matters
OS: Android 11 OneUI 3.1
Version: 1.0.2 (2001)

Additional context
Downloaded from IzzyOnDroid, but since it server the apk from GitHub, I doubt it matters.

Apologies for the oversight. I didn't thoroughly test everything before the app release. I'll be pushing an update soon to address the bug.
Thank you!

Hey! This issue has been fixed in the latest release #27. So, I'm closing this issue.
Thank You!


Bau tidy find fund round

Change description
Continuing from previous BAU PR to add unit tests for find fund and round, now reusing those methods for the content URLs, and added tests.

[x] Unit tests and other appropriate tests added or updated
[n/a] README and other documentation has been updated / added (if needed)
[x] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

LGTM. please update the PR with changes from here

Same functionality implemented by this: https://github.com/communitiesuk/funding-service-design-frontend/pull/359/files#diff-26c57520a7ad57757832d0b605d7864d158e27af4996e589dd9b311dde826a22R133-R138


return rating metadata even if there are no ratings for the spec

Is this related to a 13b issue?

This removes the join with virtual and transitional ratings.  Not saying that those worked perfectly but I was hoping we'd build that out not remove it

That is worth verifying. I suggest opening an issue with a little more detail about exactly what needs to be tested there.


lints: fix comment typos for IPv6 arpa zone.

Flagged in a review on the already merged PR by @DrMattChristian.

@cpu Thanks for the quick PR on these comment nits. Your changes look correct to me.


Process to consolidate all chapters into 1 single PDF book

Your issue content here.

Is there a readme / script to compile all chapters into a consolidated pdf book/ blog format?

https://jupyterbook.org/en/stable/advanced/pdf.html


Fix create partition of an exist topic doesn't throw RestException

Motivation
Currently creating a partition of an existed partitioned topic was created doesn't throw any exception. However it should be an invalid behavior. The reason is that when a non partitioned topic was created, it only checks whether the number of partitions is positive. However, no matter the topic doesn't exist or the topic is an existed partition, the number of partitions is 0. This PR is to distinguish these two cases and throw a RestException when the non-partitioned topic is an existed partition.
Modifications

When creating a non-partition topic that is an existed partition, throw a RestException and add a test to verify it.
Add a test provider to ensure backward compatibility that users can still create missed partitions by creating non-partitioned topics of the missed partition.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added PersistentTopics#testCreateExistedPartition
Added another test provider to PartitionCreationTest#testCreateMissedPartitions

@hangc0276 PTAL, this fix will expose the wrong repeated metadata initialization code of KoP.

@hangc0276 PTAL, this fix will expose the wrong repeated metadata initialization code of KoP.

I've changed another way to fix the issue and the backward compatibility could be retained, PTAL again, @zymap

I've changed another way to fix the issue and the backward compatibility could be retained, PTAL again, @zymap

By the way, when a AdminResource was created with a full topic name, the internal topicName would be initialized with a wrong name. eg for persistent://public/default/my-topic, the internal topicName is persistent://public /default/persistent://public/default/my-topic. This wrong behavior should be fixed.

I am curious about this, when will this behavior happen? As I know, the rest API is defined as tenant/namespace/topicname. So that means this case will happen when you name your topic name as persistent://public /default/topic explicitly.

Currently creating a partition of an existed partitioned topic was created doesn't throw any exception. However it should be an invalid behavior. The reason is that when a non partitioned topic was created, it only checks whether the number of partitions is positive. However, no matter the topic doesn't exist or the topic is an existed partition, the number of partitions is 0. This PR is to distinguish these two cases and throw a RestException when the non-partitioned topic is an existed partition.

About this issue, I am using master code to test and it shows I can't create a non-partitioned topic with a name that contains the -partition-
 bin/pulsar-admin topics create persistent://public/default/tttest-partition-0
08:46:49.633 [AsyncHttpClient-7-1] WARN  org.apache.pulsar.client.admin.internal.BaseResource - [http://localhost:8080/admin/v2/persistent/public/default/tttest-partition-0] Failed to perform http put request: javax.ws.rs.ClientErrorException: HTTP 412 Precondition Failed
Can't create topic tttest-partition-0 with "-partition-" followed by numeric value if there isn't a partitioned topic tttest created.

Reason: Can't create topic tttest-partition-0 with "-partition-" followed by numeric value if there isn't a partitioned topic tttest created.

So could you please give me more information about this case?

By the way, when a AdminResource was created with a full topic name, the internal topicName would be initialized with a wrong name. eg for persistent://public/default/my-topic, the internal topicName is persistent://public /default/persistent://public/default/my-topic. This wrong behavior should be fixed.

I am curious about this, when will this behavior happen? As I know, the rest API is defined as tenant/namespace/topicname. So that means this case will happen when you name your topic name as persistent://public /default/topic explicitly.

Currently creating a partition of an existed partitioned topic was created doesn't throw any exception. However it should be an invalid behavior. The reason is that when a non partitioned topic was created, it only checks whether the number of partitions is positive. However, no matter the topic doesn't exist or the topic is an existed partition, the number of partitions is 0. This PR is to distinguish these two cases and throw a RestException when the non-partitioned topic is an existed partition.

About this issue, I am using master code to test and it shows I can't create a non-partitioned topic with a name that contains the -partition-
 bin/pulsar-admin topics create persistent://public/default/tttest-partition-0
08:46:49.633 [AsyncHttpClient-7-1] WARN  org.apache.pulsar.client.admin.internal.BaseResource - [http://localhost:8080/admin/v2/persistent/public/default/tttest-partition-0] Failed to perform http put request: javax.ws.rs.ClientErrorException: HTTP 412 Precondition Failed
Can't create topic tttest-partition-0 with "-partition-" followed by numeric value if there isn't a partitioned topic tttest created.

Reason: Can't create topic tttest-partition-0 with "-partition-" followed by numeric value if there isn't a partitioned topic tttest created.

So could you please give me more information about this case?

@zymap You're right for the 1st issue. It only affects my tests code:
        final String partitionName = TopicName.get(topicName).getPartition(0).toString();
        try {
            persistentTopics.createNonPartitionedTopic(testTenant, testNamespace, partitionName, false);

I should use the local name in tests instead of in the validateTopicName.
For the 2st issue, the intention for creating non-partitioned topic with -partition- suffix is to create missed partitions. So you should first create a partitioned topic.
Here's an example:
# 1. A partition was somehow deleted or not created successfully
$ ./bin/pulsar-admin topics create-partitioned-topic xyz -p 3
$ ./bin/pulsar-admin topics delete xyz-partition-0
$ ./bin/pulsar-admin topics list public/default
"persistent://public/default/xyz-partition-2"
"persistent://public/default/xyz-partition-1"
# 2. Then we can create a non-partitioned topic to create missed partitions
$ ./bin/pulsar-admin topics create xyz-partition-0
$ ./bin/pulsar-admin topics list public/default
"persistent://public/default/xyz-partition-2"
"persistent://public/default/xyz-partition-0"
"persistent://public/default/xyz-partition-1"
# 3. However, if you create a existed partition, there's no error, this is what I want to fix
$ ./bin/pulsar-admin topics create xyz-partition-2

The rule is from https://github.com/apache/pulsar/pull/5148.

@zymap You're right for the 1st issue. It only affects my tests code:
        final String partitionName = TopicName.get(topicName).getPartition(0).toString();
        try {
            persistentTopics.createNonPartitionedTopic(testTenant, testNamespace, partitionName, false);

I should use the local name in tests instead of in the validateTopicName.
For the 2st issue, the intention for creating non-partitioned topic with -partition- suffix is to create missed partitions. So you should first create a partitioned topic.
Here's an example:
# 1. A partition was somehow deleted or not created successfully
$ ./bin/pulsar-admin topics create-partitioned-topic xyz -p 3
$ ./bin/pulsar-admin topics delete xyz-partition-0
$ ./bin/pulsar-admin topics list public/default
"persistent://public/default/xyz-partition-2"
"persistent://public/default/xyz-partition-1"
# 2. Then we can create a non-partitioned topic to create missed partitions
$ ./bin/pulsar-admin topics create xyz-partition-0
$ ./bin/pulsar-admin topics list public/default
"persistent://public/default/xyz-partition-2"
"persistent://public/default/xyz-partition-0"
"persistent://public/default/xyz-partition-1"
# 3. However, if you create a existed partition, there's no error, this is what I want to fix
$ ./bin/pulsar-admin topics create xyz-partition-2

The rule is from https://github.com/apache/pulsar/pull/5148.

The test is now broken, I'll fix it first.

The test is now broken, I'll fix it first.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

It looks like the BrokerServiceAutoSubscriptionCreationTest is affected by this PR. I'll fix it soon.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

The failed tests may be caused by this PR, I'm trying to fix them.

I ran the functions integration tests in my local environment and got the similar error:

19:57:06.676 [docker-java-stream-1645855842:org.apache.pulsar.tests.integration.utils.DockerUtils$2@221] INFO  org.apache.pulsar.tests.integration.utils.DockerUtils - DOCKER.exec(PulsarFunctionsProcessTest-apuqq-pulsar-broker-1:tail -f /var/log/pulsar/broker.log): STDOUT: 11:57:06.237 [pulsar-web-43-7] ERROR org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Topic persistent://public/functions/assignments already exists
11:57:06.246 [pulsar-web-43-7] INFO  org.eclipse.jetty.server.RequestLog - <IP_ADDRESS> - - [03/Feb/2021:11:57:06 +0000] "PUT /admin/v2/persistent/public/functions/assignments?authoritative=true HTTP/1.1" 409 38 "-" "Pulsar-Java-v2.8.0-SNAPSHOT" 18

It looks like the functions worker container tries to create existed public/functions/assignments, which leads to the failure of test setup.

There're still 3 tests that failed.

[ERROR]   Run 17: PulsarFunctionsProcessTest.testSerdeFunction » ServerSideError HTTP 502 Bad Ga...
[ERROR]   Run 19: PulsarFunctionsProcessTest.testSlidingCountWindowTest » ServerSideError HTTP 5...
[ERROR]   Run 21: PulsarFunctionsProcessTest.testTumblingCountWindowTest » ServerSideError HTTP ...

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Now all tests passed, PTAL again, @jiazhai @sijie @zymap @codelipenghui


Proposal: descriptionKey should also accept a function

We create a dynamic form, where the fields and labels are delivered by the server. So we actually don't know the name of the field. If descriptionKey would accept a function, we could get the description name from the model.
const Validations = buildValidations({
  value: validator('presence', {
    presence: true,
    disabled: Ember.computed.readOnly('model.isDisabled.content'),
    descriptionKey(model) {
         return model.get('fieldName');
    }
  })
});

I just discovered, that this issue is actually related to the description property of cp-validations itself. This would only make sense, if the translation key is dynamic, which is probably not a very common case.


Fix the rake update_depedencies task to respec the bundler version

We live in an unfortunate world of mixed bundler versions right now. Our gemfile.lock currently is 1.17 locked. What that means is even if bundler 2.x is used it should fall back to 1.17 and any bundle updates won't bump that locked version. This works fine on the CLI, but isn't honored programmatically in our rake task. This results in Expeditor bumping the gemfile.lock and any PR it opens to update dependencies must be closed.

Closing this out as bundler 2 has eaten the world


convert3DToZ could be exported? update proposal

@lpatiny, we have an updated code for the same kind of function in brukerconverter. could we move this code here and export the function to be used in brukerconverter.

Yes please make a PR


InstallerType: Mozilla.Thunderbird v91.5.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

Just checked and this is true of Firefox as well. This may take a while.

yeee i know, kinda wanted to wait for a update, but i guess its best to do it now since you got that trigger finger 🤔
Is there a RSS feed for Firefox/Thunderbird?


Issues with DELL U3419W

This is funny.
Everything works as expected when the monitor is connected to an old Mac mini, which has a mini display port.
Nothing works when the same monitor is connected to a Mac Book Pro (13-inch, 2018, Four Thunderbolt 3 Ports) via any of the thunderbolt ports.
Nothing works = the UI shows the progress bars for both brightness and volume but neither brightness nor volume values actually change (neither using the keyboard shortcuts, nor using the sliders in the menu bar app).
In both cases I am using the same HDMI port. Both machines run macOS 10.14.6.
Happy to provide more details if needed. If you have an idea of how I could start investigating this, please let me know.

First thing you should definitely try in this case is a different cable when possible. You could be unlucky and have an unsupported display but in quite a lot of cases HDMI doesn't work while something like displayport does.

Thanks for your help. I ended up returning the monitor because it didn’t fit my needs :(


API update

This issue reviews the current Wave ML API and proposes the next direction.
Motivation
ML libraries/APIs tends to have a different approach of creating and working with objects comparing to Wave ML. Take H2O-3 for example (to be clear it's not related just to H2O-3):
fit_h2o = H2OSingularValueDecompositionEstimator(export_checkpoints_dir=checkpoints_dir, seed=-5)
fit_h2o.train(x=list(range(4)), training_frame=arrests)

It instantiates an Estimator directly, i.e., it's not using a factory function. The idea is to follow a similar pattern so ML folks can stand on common ground.
Current status
A direct model instantiation is not available in Wave ML. To get a model, build_model() function needs to be called, which returns a common Model:
from h2o_wave_ml import build_model
...
m = build_model()
m.predict()

This function is great for several reasons:

The name implies functionality; it's clear what it is for.
It looks simple and readable in code.
Function can choose what model is appropriate for a given environment.

However, from the way build_model() is actual used, users tend to specify DAI/H2O-3 in build_model() anyway through model_type argument. This leaves the function rather baseless.
Also, the function might not be easy to pick up anymore due to a large amount of arguments (we have the code examples to mitigate this).
The last thing, IMO, It packs too many operations behind the scenes. It might be better to split it up.
Solution
We can keep the build_model() function and refactor code to support direct instantiation of models as well:
from h2o_wave_ml import DAIModel
...
m = DAIModel()
m.build()

This would also give us room to incorporate feature such as direct client access (in the roadmap):
from h2o_wave_ml import DAIModel
...
m = DAIModel()
dai_client = m.client
dai_client.datasets.create()

Or to actually split training process and support a prediction on standalone DAI:
from h2o_wave_ml import DAIModel
...
m = DAIModel()
m.build()
predictions = m.predict()  # Predictions made on standalone DAI.
m.deploy()
predictions = m.predict()  # Predictions made on deployment.

This way, we might be able to integrate h2o_wave_ml.utils into API more fluently. Since we are not working with a common Model anymore, we can pick and enable features for a particular model:
from h2o_wave_ml import DAIModel
...
m = DAIModel()
m.build()
file_path = m.save_autodoc()

Notes

This clearly is a refactoring task. It might take some time.
It would be good to do a quick POC to identify problems.
Refactor should not touch an existing API.

Thanks @vopani for the early discussion.
Comments are welcomed.
cc @lo5 @mmalohlava @mtanco @tkmaker @AakashKumarNain

I have a working concept on a branch: refactor/issue-69 for anyone who wants to try this out. There is no change to API that's not compatible with the current (v0.8.1) workflow.
What's added:

DAIModel and H2O3Model can be imported from h2o_wave_ml:

from h2o_wave_ml import H2O3Model

It can be instantiated afterward and .build can be invoked:

m = H2O3Model()
m.build()

If the model is DAI, the client is accessible and autodoc is available from within object:

m = DAIModel()
client = m.get_dai_client()
client.datasets.create()  # Do whatever.

m = DAIModel()
m.build()
m.save_autodoc()

I hesitate to merge this, for now, as I'm not convinced this is the step in the right direction.

I played a bit with this. I think its great!
Find this structure far more simpler and intuitive to use since it follows the basic structure of most ML modelling pipelines.
I also like this because its very to pick up already existing codes (say that use a sklearn model) and just replace the model instantiation line with a Wave Model.


"rope" composite type is deprecated

Hi,
Something was changed in my requirements list, and now I am getting this error that was a warning before, any idea what was upgraded or what needs to be changed to allow "rope" composite?
"ValueError: XML Error: The "rope" composite type is deprecated. Please use "cable" instead"

Hi @matansudry, it's not supported anymore in MuJoCo 3. It has been replaced by either the composite cable (for unstretchable cables) or the flex 1d (for stretchable cables with no bending/twist).


Pass config params into node on creation.

-Adding configParameters explicitly to node constructor
-(configParameters passed into the NodeRunner are private and not accessible)
-Fixes 2/4 tests in CustomNodeBuilderTests (these have had Skip attribute removed)

Preferred: @dangershony @bokobza

I am questioning whether we need those tests actually, or maybe just move to be unit tests (no need to start a whole node just to check config params.
@fassadlr @maciejzaleski @quantumagi  thoughts ?

@dangershony , @thefazzer and I spoke about the WalletCanRecoverOnStartup and BlockStoreCanRecoverOnStartup tests that fail due to the same PeerConnector time out issue in these tests. The fixes that Fazz made isn't guaranteed to fix the tests.
I would also propose that we remove these and rewrite them in unit tests.

This entire class CustomNodeBuilderTests.cs  can be a unit test actually.

Closing as this needs to be rewritten to unit tests.


higher resolution bee video

I downloaded one (4-second) bee video and annotated 2 (slow moving, not waggling) bees in it.
This PR adds code for loading the data.
This PR also includes the simple annotation tool that I wrote to do the annotations.
Here is an example notebook that displays the data: https://colab.sandbox.google.com/drive/1M2MRDNWGufFbamZlo3d0dZM-OV5CgE0E#scrollTo=me1CsMBYDm8P

Wow, let me check on this!

@marcrasi Appears that the bboxs are in different orientation than the old ones?

Yeah. It shouldn't really affect anything. I can flip them around to be consistent with the older ones though.

I have adjusted the orientation to match the other bee bounding boxes.


Side bar error

When a select the theme "personal-web" in my config.toml file my side bar appears duplicated.

The solution to this problem is the version of the hugo ( You have to use the extended version )


Eventing

This patch (with test) adds a navigate:{routeName} to the Router which is triggered regardless of whether {trigger:true} is passed to myRouter.navigate() or not.
I needed a unified way to respond to changes in the url and since route:{routeName} is only fired when the callback is invoked (ie, when landing on the page or backbuttoning) there wasn't an easy way to do this.

Sorry, but if the URL hasn't changed, then the user hasn't gone anywhere. If you'd like to call a particular function ... just call that function.

Hi Jeremy, Thanks for looking at the request. My difficulty isn't the invocation of a function on the router, but rather the fact that the url can changed without the router notifying subscribers to that interesting event. If router.navigate is called by app code, then parties which subscribed to route:{name} can't respond...for example, I have a breadcrumbs component which subscribes to 'route:customer'. This works fine if hitting the page with that hash or using backbutton, but not if the router is being called using the navigate fn.
What I am achieving in the patch is an event which you can rely on for changes to the url and its parsed args regardless of whether called from app code or browser. Since other BB components publish interesting events like 'change' it seems reasonable to get an event on the Router that similarly publishes a state change to the application location consistently regardless of the caller.

Can't you simply always pass trigger: true if that's the behavior you desire?
Full disclosure here -- the preferred thing to do in a Backbone app is to never pass trigger: true. Instead of serializing your state changes through a URL, treat .navigate as simply a way to drop a bookmark from time to time -- and call your state change function yourself.

I had considered that, but I like the convention Backbone uses regarding separation between route invocation and navigation bookmarking. Since I have a global EventAggregator that facilitates pub/sub across my views in a CommonJS module setup, it is difficult to subscribe to that bookmarking event (again, a point of interest for the breadcrumbs component in the example above). I don't want to hold a ton of references inside my router and have it determine whether breadcrumbs should be viewed for the new url. It seems like the extra reliable event would help prevent 'god object' routers. Maybe the name could be bookmark:{route}? I know it seems like I am trying to get BB to bend to my story, but it seems like providing an event for state change on the router is reasonable.

I've taken time to see where I was complicating matters. I was having my View implementations respond to DOM events and make calls on their Models. The Router was listening to events being fired from those models and responding in kind with .navigate. By inverting this so that the url is changed by an anchor (instead of buttons => code) my router invokes the behavior on the Models. This seems to be more in line with BB.
Thanks for bearing with me - I am still sorting out the pieces.

No worries -- glad you got it sorted.


Remove unneeded whitespace from SuperBass.java

Dev: @chenan02
QA: @whuang1
PM: @jmckesso

Please attach the issue number and link to this PR


Using the recommended emit attribute removes the event namespace from the component attributes

Version
3.2.29
Reproduction link
stackblitz.com
Steps to reproduce
Create a component.
In the component add the emits option: emits: ['onDelete']
In the components template add an if statement to determine if the event is bound to the component v-if="$attrs.onOnDelete"
In the parent add an event handler such as @click="onDelete"
What is expected?
In the Vue3 docs it recommends to define what events a child component can emit to the parent https://v3.vuejs.org/guide/migration/emits-option.html#overview
If the parent binds the event onDelete I would expect the component to be displayed.
What is actually happening?
The component is not displayed.

See the discussion here: https://stackoverflow.com/questions/70272335/vue3-check-if-event-listener-is-bound-to-component-instance/70358655?noredirect=1#comment125169175_70358655

Declare it as as prop onDelete:  Function. You will be able to check for existence, and still use emit('delete')
duplicate - https://github.com/vuejs/core/issues/5220

Declare it as as prop onDelete: Function. You will be able to check for existence, and still use emit('delete')
duplicate - #5220

Agreed, there are a few work arounds. However I feel that lacking a way to check what is an allowed emit, per the documentation, especially as it pertains to more complex examples with multiple events, makes the recommendation of using the emits to define what can be emitted a bit useless.

Vue 3 now offers an emits option, similar to the existing props option. This option can be used to define the events that a component can emit to its parent.

Wouldn't it add value to this feature to add the allowed emitted values to the attrs? Or, access them via $emits or $emittable.
What is the technical or performance limitation to do so?

make your case in the RFC discussion, if it wasn't already made.
https://github.com/vuejs/rfcs/discussions/397

Duplicate of https://github.com/vuejs/core/issues/5220


Basic snapshot support for go-v8

New go function: NewIsolateWithSnapshot()

I guess you could do something like append "var js_hash_XXXX__worked =
true;" and check for that when you create the isolate.
On Tue, Dec 13, 2016 at 11:22 AM Keunwoo Lee<EMAIL_ADDRESS>wrote:

@keunwoo commented on this pull request.
In v8isolate.cc https://github.com/fluxio/go-v8/pull/3:

v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = &allocator;
isolate_ = v8::Isolate::New(create_params);
}

+V8Isolate::V8Isolate(const char* snapshot_js_str) {

startup_data = v8::V8::CreateSnapshotDataBlob(snapshot_js_str);
if (startup_data.data == NULL) {
throw BadSnapshotDataException();

So there's no way to detect whether the JS in your snapshot initialization
succeeded? That's horrible.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fluxio/go-v8/pull/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AApS1fPhvjFMHwA6adqJ11pm1LJb192Rks5rHuJdgaJpZM4LLV_i
.


Bit shifting causing intermittent bit corruption

https://github.com/trinamic/TMC-API/blob/3da0cec86d2f14c3f1b6f29950df6fe2cc41624b/tmc/ic/TMC5160/TMC5160.c#L53
Sometimes when reading a spi value the upper 16 bits are all 1's.  I noticed this line of code and changed it like so and the problem was resolved.
Shifting bits with types smaller than the shift can cause undefined behavour.  At least on our processor, the msp430 it needs this fix.
	uint32_t v[5] = {0};
	for (uint32_t i = 0; i < 5; i++) {
		v[i] = data[i];
	}

	uint32_t value = (v[1] << 24) | (v[2] << 16) | (v[3] << 8) | (v[4]);
	return value;
	```

Good catch!
You could also skip the uint32_t array, and the hard-coded shift sizes (untested):
uint32_t value = 0;
for (int i = 5 - 1; i >= 1; i--) {
    value <<= 8;
    value |= data[i];
}
return value;


feature/logging gui by process

Changes:
This is re-newed draft and is not final version but is at least working version instead of current logging gui.
Changes to be able show logs by process and all logs from the process at once.

Not sure working is the right word :)

I seem to be missing all the logs now.

fixed merged develop to branch


adding sort by column and search

Hi,
Thank you for this amazing plugin. I opened this issue to suggest two features would be nice to have:

Clickable table headings that would sort all the data alphabetically according to the clicked column.
A search field that allows to filter the displayed data.
If I have time to read your source code and find the good way to implement these features, I will do it soon.

Hey Amine, thanks for the kind words!
Search & Sort is out of scope for this plugin, but it should be easy to combine it with other plugins, that provide search and/or sort. Could you give that a try first?

Yeah sure. I'll try that first


[Feature Request] System.Text.Json.JsonObject is not supported

Describe the bug
Using Topaz with System.Text.Json namespace types like JsonValue/JsonArray/JsonObject doesn't work as of now. When testing with JsonObject I didn't get an error, but also didn't get the right result.
Expected behavior
The code below should return 123, but returns null instead.
To Reproduce
var engine = new TopazEngine();

// JsonObject does not work
var jObject = (JsonObject)JsonObject.Parse("""
    { "a": {"b": "123" }}
    """);

// TestDto does work
//var jObject = new TestDto();

engine.SetValue("ob", jObject);

var result = engine.ExecuteExpression("ob.a.b");
Console.WriteLine($"'{result}'");

public class TestDto
{
    public TestAnotherDto a { get; set; } = new TestAnotherDto { b = 123 };
}

public class TestAnotherDto
{
    public int b { get; set; }
}

Desktop

Operating System: Windows
Topaz Version: 1.3.6

Thanks @warappa for reporting this issue.
My short note:
This is not a bug but a feature request. Currently Topaz does not implement specific handling of JsonObjects.
Could you test if the following solution works for you?
var jObject = new JSONObject().parse("""
    { "a": {"b": "123" }}
    """);
engine.SetValue("ob", jObject);
engine.ExecuteExpression("ob.a.b");

Alternatively, you could write your own JsonElement converter and use it before exposing objects into Topaz Engine runtime.
There is an internal class for converting any JsonElement into JsObject.
Please see Tenray.Topaz.API.JsonElementJsObjectConverter

Sorry, I also changed this for feature request.
Yes, your code works with JSONObject. As I work with System.Text.Json.JsonObject I will have to try the converter way. My (untested) concern is, that this conversion may lead to other issues (bad performance, manipulating just a copy instead of the real thing,...).
How realistic do you see it to support System.Text.Json types natively?

You didn't encounter any errors with this call: engine.ExecuteExpression("ob.a.b");
This is because the engine.Options.AllowNullReferenceMemberAccess option is enabled by default.
If you wish to receive null reference exceptions, you can disable this option

Topaz configurable interfaces enables creating custom behavior for specific types.
The following is a draft sample that routes property access to JsonObject without converting them.
It is not a complete sample but just a draft to give the idea.
Adding additional proxy implementations for other Json classes are needed and edge cases are not handled.

var engine = new TopazEngine();
engine.ObjectProxyRegistry.AddObjectProxy(typeof(JsonObject), new JsonObjectProxy());

public class JsonObjectProxy : IObjectProxy
{
    public bool TryGetObjectMember(object instance, object member, out object value, bool isIndexedProperty = false)
    {
        value = null;
        if (instance is not JsonObject jsonObj)
        {
            return false;
        }

        if (isIndexedProperty)
        {
            // TODO: implement indexed property access.
            return false;
        }

        var memberName = member?.ToString() ?? "null";
        if (!jsonObj.TryGetPropertyValue(memberName, out var jsonNode))
        {
            return false;
        }

        try
        {
            value = jsonNode.AsObject();
            return true;
        }
        catch
        {
        }

        try
        {
            value = jsonNode.AsValue();
            return true;
        }
        catch
        {
        }

        try
        {
            value = jsonNode.AsArray();
            return true;
        }
        catch
        {
        }
        return false;
    }

    public bool TrySetObjectMember(object instance, object member, object value, bool isIndexedProperty = false)
    {
        throw new NotImplementedException();
    }
}

For other extension opportunities, please refer to TopazEngineSetup

I am closing this feature request in alignment with the Open-Closed Principle, one of the fundamental principles of SOLID design.
Topaz does not directly implement or maintain code for specific libraries; instead, it offers powerful extension capabilities for users to integrate and customize functionality as needed.


Don't use sourceMapTarget option

Babel throws a fit if you set this option now.

https://github.com/nathantreid/meteor-typescript-babel/issues/7

Thanks!


Chrome extension: Safer, prettier, more usable

Mostly incremental improvements:

Use a custom safeHTML(...) rather than deprecated escape(...)
Remove detour note from the README (not relevant now that the previous PR is merged)
Toggle chat widget if the reply button is clicked again.
Confirm before closing if there is a message written.
Toggle the nudge text is nudge is unchecked.
Show some indication of progress (submit button gets disabled and switched to "Sending...").
A place for error messages (our pinkish red text below the submit button, for now).

Ping @keybase/react-hackers, anyone up for a review?

@chrisnojima Thanks for the review! Added some fixes.
There are numerous places where the extension breaks if the reddit DOM changes. I'm kind of on the fence of trying to capture all of them right now, vs just letting it break. What do you think?

We can be safer later I guess. That seems fine in the short term cc: @malgorithms


fix the problem when Change.getRemoved() returns other mapped instances than get()

That issue breaks JFX charts with current MappedList implementation.
(BTW nice to meet you again ;)

Since this project sadly doesn't seem to be active any more #16, I've created a fork and continued development there:  https://github.com/tobiasdiez/EasyBind.
I wasn't sure which bug you tried to fix, and if it still exists in the forked repo. Thus, I've not included your PR there, but please feel free to create a new PR if your fix still applies!


Smartmi Standing Fan 2S not responding

My Mi Stand fan S2 (zhimi.fan.za4) can no longer be controlled with the plugin.
It shows up in Homebridge and Apple Homekit, but does not respond.
Fan was completely reset, new token entered and still does not work.
A tower fan (dmaker.fan.p9) and a Mi hot air fryer work fine.

Please post the homebridge debug log from the startup so i can check what is happening.


More than one rows in export file for one street

If same street has more than one maintenance dates in export file, only last one will stay.

should mainentance data separated into its own table?

Tried to fix with updating only next day data, but run into problems:
2016-01-28,Melkonkatu,"Parillinen puoli 12-18",00210,60.1506801,24.8828643
2016-01-28,Melkonkatu,"Pariton puoli 7-12",00210,60.1506801,24.8828643
So it will need maintenance table to handle multiple information


Fix the docs build after renaming

I think the docs build is failing because of the UUID change, but I'm not sure. Testing now.

That didn't fix things so I reverted back to the new UUID, deleted ACEpotentials from the docs project, and then re-added it such that the UUID updated.

That seemed to work, merging.


hangs while downloading asar file

Describe the bug
When using v1.0.0-hotfix installer, the install gets stuck on the "Downloading asar file" stage.  My network traffic monitor shows virtually zero traffic on the network interface, so this isn't even a slow download issue like described in #191.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/BetterDiscord/Installer/releases
Download https://github.com/BetterDiscord/Installer/releases/download/v1.0.0-hotfix/BetterDiscord-Linux.AppImage
Run it
Click through to the install process
Observe it hanging on the "Downloading asar file" stage.

Expected behavior
The install proceeds and completes in a reasonable timeframe.
Screenshots

System Information:

OS: Linux (openSUSE Leap)
Discord Version: 0.0.15

Duplicate of #35

I agree it looks like it's duplicate, but in practice it's not, because I don't have any antivirus or firewall software which could be blocking this.

I see from #173 that there is an issue with the use of phin for downloads, but #179 indicates that this issue only applies with non-hotfixed installers, and I see the problem with the hotfix (although weirdly I'm pretty sure the same hotfix installed has worked for me on two other machines running very similar openSUSE Linux distributions).
I should also mention there's no issue with my network.  It's a fast connection with pure fibre-optic end-to-end, provided by the most reliable ISP in the UK.

I attempted to do the same today using a reliable internet connection and found the same or a similar error, screenshot attached. Also have no active antivirus.

@Elepicos Is clearly not the same issue. The issue that you have is already pinned and closed #174

Are there any visible errors in console? (You can access DevTools using Ctrl + Shift + I with the installer focused).

Nothing relevant, no.  The only message which appears at all is
DevTools failed to load SourceMap: Could not load content for file:///tmp/.mount_BetterhbVtjk/resources/app.asar/renderer.js.map:

which appears early on and is pretty obviously unrelated.

The installer being stuck on asar download is the same issue as before. The hotfix version didn't touch any of that, hence the original issues are still open.

Which original issues are those?  I can't see any in this repo reporting the same thing.

Issue #35 was closed by the user that posted it because it was fixed for him but the issue is still present.
It should still be open until it gets fully fixed in the next installer update because it was already fixed in Phin a few days ago https://github.com/ethanent/centra/pull/12

Issue #179 is still open and it mentions 2 issues about Phin:

This was already fixed in 384bef6. This is the one that is not a big issue after the hotfix.

phin won't follow redirects by default which broke the download after the App repo was moved to the organization. This is a lesser problem, after the hotfix

This one is the issue mentioned in #35

Phin has this nasty bug where it will never resolve/reject a promise when the server aborts the connection

Ah, those ones.  As I mentioned above, #35 is not an exact duplicate of this - even though the symptom is the same problem, it has a different root cause (or at least contributing factor) since it was resolved after the user disabled their firewall and anti-virus.
I also mentioned above that #179 claims to apply only to the non-hotfixed installer, which I'm not using.  I'm a little confused whether the followRedirects fix in 384bef63e9d6 is present in the non-hotfixed installer, or the hotfixed one, or both.  It seems like an obviously beneficial change with no obvious downsides, so I'm not sure why it wouldn't be present in both.  Is this a possible cause of the hang I am seeing in the hotfixed installer?
Regarding Phin failing to gracefully handle an aborted connection, I can understand that being a problem in some cases, but I don't see why my installer would be aborting the connection 100% of the time, so I'm guessing that is unrelated to my issue.
In summary, even though I'm aware of those known issues, I'm still no closer to knowing how to get past this hang.  Some advice on solving that would be really appreciated.  Thanks!

I also mentioned above that #179 claims to apply only to the non-hotfixed installer, which I'm not using. I'm a little confused whether the followRedirects fix in 384bef6 is present in the non-hotfixed installer, or the hotfixed one, or both. It seems like an obviously beneficial change with no obvious downsides, so I'm not sure why it wouldn't be present in both. Is this a possible cause of the hang I am seeing in the hotfixed installer?

Even tho it claims to apply only to the non-hotfixed installer neither of the 2 issues mentioned are fixed in the hotfixed version.
Is just that the first issue is not a huge problem now in the hotfixed update.
If your connection is fine it could be related to issue #137
You can also try a manual installation
Or using betterdiscordctl

Thanks, betterdiscordctl looks like a great option!

I'm hoping to get a build out soon with the updated version of phin to see if this alleviates some of the download-hanging issues

I agree it looks like it's duplicate, but in practice it's not, because I don't have any antivirus or firewall software which could be blocking this.

I don't know if you already solved the problem, but I'm also an openSUSE Leap user, and I also had this problem, I opened YaST > Firewall > I disabled "Start at boot" and restarted the system. It worked for me.

Problem still exists, so I installed with betterdiscordctl install

I had this issue too, just re-launched the installer

I got around this by killing Discord using killall Discord or killall DiscordPTB. I then re-launched the installer and it managed to install just fine. I think the download step might also be trying to kill the Discord process but is not able to, so killing it manually works.

apparently this happens because of issues with files and stuff, like creating directories, first is uninstalling betterdiscord if you tried installing it, then tweak the permissions of the installer allowing to run it as an executable and also allowing it to read and write, that's what worked with me, hope i help someone.

What fixed it for me was opening the console at the agreement window., check the disable cache checkbox under network, then continue the normal installer. Keeping the console open all the time.


Transaction and bookeeping tests

Codecov Report

Merging #196 (efbaf7c) into master (2c08136) will decrease coverage by 0.41%.
The diff coverage is 42.10%.

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
- Coverage     74.42%   74.00%   -0.42%
- Complexity      769      770       +1
============================================
  Files            99       99
  Lines          2170     2185      +15
  Branches        305      311       +6
============================================
+ Hits           1615     1617       +2
- Misses          431      437       +6
- Partials        124      131       +7

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/model/ModelManager.java
83.45% <25.00%> (-1.85%)
:arrow_down:

...main/java/seedu/address/model/TransactionList.java
61.29% <33.33%> (-17.66%)
:arrow_down:

...in/java/seedu/address/commons/util/StringUtil.java
93.54% <100.00%> (ø)

...a/seedu/address/model/order/TransactionRecord.java
77.77% <100.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c08136...efbaf7c. Read the comment docs.


apoc.export.csv.graph incorrectly exports properties with datatype 'float'

 Issue by p0macs
Thursday Dec 19, 2019 at 18:20 GMT
Originally opened as https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/1369

When using the apoc.export.csv.graph with the parameter useType:true, then the FLOAT properties are not exported.
When using useType:false (the default) the the FLOAT property exported as string.
Expected Behavior (Mandatory)
The property value should be exported and the header should contain "propname:float" for the property with type FLOAT
Actual Behavior (Mandatory)
The header contains "propname:int" and the value is empty string
How to Reproduce the Problem
CREATE (n:TestNode) SET n = {valFloat:toFloat(123), name:'NodeName'};
CALL apoc.graph.fromCypher("MATCH (n:TestNode) RETURN n", {}, 'TestNode.csv',{}) YIELD graph
CALL apoc.export.csv.graph(graph, null, {stream:true,useTypes:true}) YIELD properties, rows, data
return properties, rows, data;
Specifications (Mandatory)
Currently used versions
Versions

OS:
Neo4j: 2.5.5
Neo4j-Apoc: <IP_ADDRESS>

 Comment by cmaart
Tuesday May 17, 2022 at 07:19 GMT

How has this never been fixed? This makes useTypes config completely useless when values are missing in the csv export


feat(checkbox): Adding the checkbox field

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Back button for feedback template

Fixed parameters for feedback template in TaskController (accidentally broke in pr #134 )
Added an option to return to the editor view.

Feedback template still lacks tests. Those should be imported when we finish the "fake sandbox" task.

Coverage increased (+0.1%) to 64.995% when pulling 5a26b102234d202a4756a9c46b46333eb8d9d9ac on laurpulk:back-button into 750bb4a8959d80fddbac45956359bc5b463e5ff8 on tdd-pingis:master.


npm release

Hi,
I'm wondering if Temml will ever see an npm release. I think this software is great and being on npm would improve the developer experience, especially for those using frameworks with server side rendering.
Thanks so much for your work.

Temml is already on npm.  See https://www.npmjs.com/package/temml
Is there something lacking in that release?