Android randomly resets Redux state

Expected Behavior
App state should never reset without direct user action.
Current Behavior
This was reported by @marekolszewski

Valora account reset unexpectedly...

Disk space doesn't seem to be the issue. The user had 70% of free disk space.
Deleting the app and reinstalling it fixes the issue.
We don't have logs yet.

Hi @jeanregisser i have verified issue on Android play store (internal build) v1.4.0<PHONE_NUMBER>) and found the following:
Devices used : Samsung Galaxy m40 (10)

User is able to restore account after reset valora from setting screen.
User is able to restore account after clearing app data from device setting.

Can you please let me know is it device specific issue or specific steps to repro the issue ?

I have been able to reproduce this randomly on an Android emulator. I unfortunately don't have the logs though.
I was relaunching/killing the app many times, and after around 40 attempts, I got this problem. Basically the persisted Redux state got reset and I couldn't restore my account anymore because the key was already in the geth keystore.
This seems to indicate there's some kind of race condition with the Redux state persistence mechanism.

Just to clarify here:

User installs Valora, create an account after successful onboarding
User gets randomly logged out from the account at some point they launch the app? At this point geth actually still has the account in it, but in redux we do not know about that?

Split out the inability to restore from Account Key into a separate issue (#6235). This issue now solely relates to the random account resets that appear to be happening only on Android.

This should have been fixed by https://github.com/celo-org/celo-monorepo/pull/6273 I'll just keep open for a bit to monitor and make sure it is actually fixed before closing.

I'm going to close this for now to represent the progress we've made. We can reopen if we encounter this issue again


[Feature Request] Support custom http client

Refer : https://github.com/AzureAD/microsoft-authentication-library-for-go/pull/117#discussion_r553532502

This should hold until a customer gives a use case we can't support in another way.

This should hold until a customer gives a use case we can't support in another way.

If added at some point, should look like:
// HTTP provides an HTTP client that will be used for all HTTP calls. This interface is not covered by any
// compatibility promise. Additions to the stdlib http.Client will be added here and may break compatibility without
// a semantic version change.
type HTTP interface {
    CloseIdleConnections()
    Do(req *Request) (*http.Response, error)
    Get(url string) (*http.Response, error)
    Head(url string) (*http.Response, error)
    Post(url, contentType string, body io.Reader) (*http.Response,error)
    PostForm(url string, data url.Values) (*http.Response,error)
}

If added at some point, should look like:
// HTTP provides an HTTP client that will be used for all HTTP calls. This interface is not covered by any
// compatibility promise. Additions to the stdlib http.Client will be added here and may break compatibility without
// a semantic version change.
type HTTP interface {
    CloseIdleConnections()
    Do(req *Request) (*http.Response, error)
    Get(url string) (*http.Response, error)
    Head(url string) (*http.Response, error)
    Post(url, contentType string, body io.Reader) (*http.Response,error)
    PostForm(url string, data url.Values) (*http.Response,error)
}

There's no need to add Get(), Head(), Post(), and PostForm() as they're convenience methods which aren't applicable to our needs given they don't honor a user-provided context.
I think we can also omit CloseIdleConnections(), at least for now until some compelling use-case makes it a requirement (for reference, in the Go SDK we've defined our client interface with just the Do() method and have had no need for this in 4+ years).

There's no need to add Get(), Head(), Post(), and PostForm() as they're convenience methods which aren't applicable to our needs given they don't honor a user-provided context.
I think we can also omit CloseIdleConnections(), at least for now until some compelling use-case makes it a requirement (for reference, in the Go SDK we've defined our client interface with just the Do() method and have had no need for this in 4+ years).

There's no need to add Get(), Head(), Post(), and PostForm() as they're convenience methods which aren't applicable to our needs given they don't honor a user-provided context.
I think we can also omit CloseIdleConnections(), at least for now until some compelling use-case makes it a requirement (for reference, in the Go SDK we've defined our client interface with just the Do() method and have had no need for this in 4+ years).

There's no need to add Get(), Head(), Post(), and PostForm() as they're convenience methods which aren't applicable to our needs given they don't honor a user-provided context.
I think we can also omit CloseIdleConnections(), at least for now until some compelling use-case makes it a requirement (for reference, in the Go SDK we've defined our client interface with just the Do() method and have had no need for this in 4+ years).

A couple things here:
Do we have a current customer for this, if not we should punt this? If that is Joel, you already have code that needs this?
If so, then let's move forward, but if not, we should punt on this.
Joels is right in that we can use just Do() instead of Get(), Head(), Post(), and PostForm().
We cannot do without CloseIdleConnections().
This goes back to the rule: you should never (almost) have a public interface a user can implement.
Here's why:
HTTP design for today:
type HTTP interface{
  Do(req *Request) (*http.Response, error)
}

Our Client's implementation:
type HTTP struct {
  client *http.Client
}

func (h *HTTP)  Do(req *http.Request) (*http.Response, error) {
  // Do some custom stuff in here.
  return client.Do(req)
}

HTTP design tomorrow:
```go
type HTTP interface{
  Do(req *Request) (*http.Response, error)
  CloseIdleConnections() // <-added here
}

This immediately breaks our clients, as their client is no longer compatible.
So now we have to roll a major version change.  Our language here protects us from when we need to add support because Go team adds a method we require (however, the chance of that is extremely low).
But if we need to add any method in the future, we are either going to break our clients when we didn't have to (and use language to protect ourselves, which is bad if we can help it) or we are going to roll a major version (let's never do this, its painful for everyone).

A couple things here:
Do we have a current customer for this, if not we should punt this? If that is Joel, you already have code that needs this?
If so, then let's move forward, but if not, we should punt on this.
Joels is right in that we can use just Do() instead of Get(), Head(), Post(), and PostForm().
We cannot do without CloseIdleConnections().
This goes back to the rule: you should never (almost) have a public interface a user can implement.
Here's why:
HTTP design for today:
type HTTP interface{
  Do(req *Request) (*http.Response, error)
}

Our Client's implementation:
type HTTP struct {
  client *http.Client
}

func (h *HTTP)  Do(req *http.Request) (*http.Response, error) {
  // Do some custom stuff in here.
  return client.Do(req)
}

HTTP design tomorrow:
```go
type HTTP interface{
  Do(req *Request) (*http.Response, error)
  CloseIdleConnections() // <-added here
}

This immediately breaks our clients, as their client is no longer compatible.
So now we have to roll a major version change.  Our language here protects us from when we need to add support because Go team adds a method we require (however, the chance of that is extremely low).
But if we need to add any method in the future, we are either going to break our clients when we didn't have to (and use language to protect ourselves, which is bad if we can help it) or we are going to roll a major version (let's never do this, its painful for everyone).

Yes this is needed by azidentity to use our pipeline middleware for providing retries, logging etc.
You are right about adding it later, my bad.  But I'm not yet convinced that this is required in the interface.  When do you envision this being called?

Yes this is needed by azidentity to use our pipeline middleware for providing retries, logging etc.
You are right about adding it later, my bad.  But I'm not yet convinced that this is required in the interface.  When do you envision this being called?

Roger on the need.
I don't envision it being called.  But I don't want to pay for my lack of vision.  That looks like it hurts and I'm allergic to pain.
If we find the need for whatever the reason in the future, we break clients.  As this can't be duplicated with Do(), we need require for the future to protect ourselves.
This is why I don't like user implementable interfaces, you gotta cover all the bases.

Roger on the need.
I don't envision it being called.  But I don't want to pay for my lack of vision.  That looks like it hurts and I'm allergic to pain.
If we find the need for whatever the reason in the future, we break clients.  As this can't be duplicated with Do(), we need require for the future to protect ourselves.
This is why I don't like user implementable interfaces, you gotta cover all the bases.

Being versioning-tolerant has convinced me, will include this in the implementation.

Being versioning-tolerant has convinced me, will include this in the implementation.

Fixed in dev


Support Django 5.0

Check changelog and add tests for Django 5.x

As discussed in the meeting:

since we don't pin django, we are already testing 5.x
we should also run tests (at least on CI) with django pinned to ~=4.2.0 (LTS).

only django-related tests should be included in this new job


Change include-json's include to not "zoom in" to the included object when there is only a single include path.

I use include-json's include feature in my docs.
I show a json object, filtered down to a single top-level property. Here's there real example:
{
  "liquibase": {
    "enabled": true,
    "dataSourceMigrations": [
      {
        "dataSourceName": "h2-tcp",
        "migrationFileName": "migrations.xml",
        "migrationFileLocation": "classpath",
        "contexts": []
      }
    ],
    "dryRun": false
  }
}

I found that when I include a single path include: "$['liquibase']", then the root object is now the inner object, I have to change my paths to be relative to the inner object, and the output renders like this:
{
  "enabled": true,
  "dataSourceMigrations": [
    {
      "dataSourceName": "h2-tcp",
      "migrationFileName": "migrations.xml",
      "migrationFileLocation": "classpath",
      "contexts": []
    }
  ],
  "dryRun": false
}

Since I want it to render the first way, I experimented and came up with a workaround. I can include a second property, which is fake/absent, and Znai will render my docs the way I like.
:include-json: test-example.json5 {
title: "example.json5",
include: "$['absent', 'liquibase']",
}

I'd like to have a way to filter the json properties without changing the root object. One recommendation would be to have separate directives for choosing a root object and filtering properties. In my case, I'd leave it absent or set to the root. Something like this:
:include-json: test-example.json5 {
title: "example.json5",
root: "$",
include: "$['liquibase']",
}

@motlin I can't find a proper way to do it with the library Znai uses (https://github.com/json-path/JsonPath)
Workaround you can try is using encloseInObject: https://testingisdocumenting.org/znai/snippets/json#enclose-in-object


[BUG] After using wtype, the keyboard layout is forgotten

Describe the bug
I use bemoji to insert emoji into the text using wtype, and it momentarily changes the layout to different one, because it essentially switches to a new keyboard. After this, the change is normally reverted and I can you the previous layout. With hyprland-per-window-layout, once I switch back and forth between two windows, it doesn't switch to the correct one.
To Reproduce
Steps to reproduce the behavior:

Switch to non-English US layout
Use wtype
Switch between apps (to some other and back)
Layout set to English US

Expected behavior
Proper layout.
Linux Distro (please complete the following information):

NixOS 24.05 running version 2.4 of hyprland-per-window-layout

Additional context
activelayout>>liliums-lily58,English (US)
activelayout>>liliums-lily58,Czech (QWERTY)
activelayout>>wlr_virtual_keyboard_v1,English (US)
activelayout>>wlr_virtual_keyboard_v1,English (US)
activelayout>>wlr_virtual_keyboard_v1,error
activelayout>>asus-keyboard-2,Czech (QWERTY)
activewindow>>Alacritty,Alacritty
activewindowv2>>someid
activelayout>>liliums-lily58,English (US)
activelayout>>asus-keyboard-2,English (US)
activewindow>>org.telegram.desktop
activewindowv2>>someid
activewindowv2>>someid
workspace>>2

Ok, check 2.5 version, should be fixed now

Unfortunately, the problem still persists. I am adding additional logs. That said, I don't know whether this isn't partially caused by some Hyprland behavior.
activewindow>>org.telegram.desktop,Saved Messages
activelayout>>liliums-lily58,Czech (QWERTY)
openlayer>>rofi
closelayer>>rofi
activewindow>>,
activewindowv2>>,
activewindow>>org.telegram.desktop,Saved Messages
activelayout>>liliums-lily58,English (US)
activelayout>>wlr_virtual_keyboard_v1,English (US)
activelayout>>wlr_virtual_keyboard_v1,English (US)
activelayout>>wlr_virtual_keyboard_v1,error
activelayout>>liliums-lily58,Czech (QWERTY)
activelayout>>hp-hp-usb-c-dock-g5-system-control,Czech (QWERTY)
activelayout>>asus-keyboard-2,Czech (QWERTY)
activewindow>>dev.deedles.Trayscale,Trayscale
activelayout>>liliums-lily58,English (US)
activelayout>>hp-hp-usb-c-dock-g5-system-control,English (US)
activelayout>>asus-keyboard-2,English (US)
activewindow>>org.telegram.desktop,Saved Messages

I'm not sure if you have updated version. I was able to reproduce and fix the bug based on the request "After using wtype". Now it ignores wlr_virtual_keyboard_v* and I can't reproduce it anymore.
Please double-check you don't have multiple instances running, updated to latest version and help me find steps to reproduce

I tested with bemoji and can confirm that when use bemoji, something switching layout to English for the current active window. I took a quick look at the bemoji repository, but didn't find confirmation of this. But, as I see logs, the only problem is switching to En after select something with bemoji.
After that, I can switch layouts again and hyprland-per-window-layout keeps it.
It seems that this will not be fixed.
If bemoji need English - let it have it. From the hyprland-per-window-layout side, I don't have possibility to separate this event

Thank you for checking. I will try to find a way to overcome this.
Have a great day!

As future reference for someone. I found replacement for bemoji, which utilizes wtype, but the layout switching works like a charm.
Now, I use rofimoji.


Support postfix completion like Intellij IDEA.

It is a very useful feature.

@zgqq Postfix completion has been mentioned in the past in #92 but the discussion seems to have stalled a bit.

it is already possible to implement postfix completions with the current API, although it's not the prettiest code to write.

https://github.com/rust-analyzer/rust-analyzer/blob/38e8f35855efac144373c1b5aab3af050e47e594/crates/ra_ide/src/completion/complete_postfix.rs#L19-L187
https://github.com/rust-analyzer/rust-analyzer/blob/38e8f35855efac144373c1b5aab3af050e47e594/crates/rust-analyzer/src/to_proto.rs#L134-L155i

Though, I think this can be improved UI-wise. It would be cool to make a certain completion item as a postifix snippet, so that the client could implement the following, less-intrusive behavior for advanced users (via setting opt-in):

hiding postfix completions from the completion list, unless there's a conflict between postfix and non-postfix
accepting postfix completion only if there's exact match.


[feature request] support for mt-cell + picker?

case:

init: load default value from picker data
action: mt-cell.click->show picker->pick value->update cell model value

Any chance of supporting this feature? 😄
Maybe implement via adding a property(passing a pre-defined picker id) to <mt-cell>?
<mt-cell :value-picker="#picker1"></mt-cell>

or mt-cell+html select?

@Leopoldthecoder 你看下？

If I'm getting it right, features like this should be handled by the user. You can do it by encapsulating a custom component with mt-cell, mt-picker and mt-popup.


Submit event not preventing on complex validations (2.2.0-rc4)

Example
http://parsleyjs.org/doc/examples/events.html
not working. And my validation, based on this example, too. :(
Form just submits

Oh, this example is out of date. Just return false...
I'll try to support it and deprecate that.

Actually, return false works only on form:submit. Better set validationResult to false.
The example has been fixed, sorry for that.

Thanks for opening this issue. Next version will allow the old way of interrupting things, and issue a deprecation warning.


Bump version to 2.5.1 build 476

Summary
Bump build to 476 and version to 2.5.1
Ticket Link
None
Release Note
NONE

Cherry pick is scheduled.


TBX1

Two cases are somehow showing biallelic allelic requirement, a strange error.

Fixed, the problem was a duplicate identifier. Added code to check for uniqueness of identifiers.


[BUG]: LaTeX inside callouts

Describe the bug
When adding LaTex formatting inside a callout, the background matches the theme colour instead of the callout's.
Expected behavior
To be fully transparent or matching the callout colouring.
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Obsidian version: 1.15.12 (Installer: 1.15.11)
Theme version: 19.5.0

Thanks for letting me know @YannMiro. Please check theme version 19.5.1. Let me know if it is working well for you.
All the best

If it is working ok. You can close this issue. Thanks
All the best

Sure, thanks 😀


[publish-solution]: Add ability to inject environment variables

I'd like to see the ability to inject environment variables into a solution in a workflow that is deployed as a managed solution into a target environment, not sure if this is on the publish-solution or export-solution action.

@garrytrinder this support was recently added as part of #131 and will be part of the upcoming October refresh (due out early next week)

Great news! Thanks @davidjenni 👍


Add unit test

Add unit test

Codecov Report

Merging #1952 into dev will increase coverage by 6.89%.
The diff coverage is 47.52%.

@@             Coverage Diff              @@
##                dev    #1952      +/-   ##
============================================
+ Coverage     20.22%   27.11%   +6.89%
- Complexity        0     1383    +1383
============================================
  Files           290      312      +22
  Lines         14082    16680    +2598
  Branches       2376     2056     -320
============================================
+ Hits           2848     4523    +1675
- Misses        10908    11679     +771
- Partials        326      478     +152

Impacted Files
Coverage Δ
Complexity Δ

...inscheduler/server/master/config/MasterConfig.java
18.18% <ø> (ø)
3 <0> (?)

...he/dolphinscheduler/server/utils/ProcessUtils.java
17.03% <ø> (+17.03%)
8 <0> (+8)
:arrow_up:

...nscheduler/dao/quartz/DruidConnectionProvider.java
0% <ø> (ø)
0 <0> (?)

...hinscheduler/api/controller/ProjectController.java
3.44% <ø> (+3.44%)
2 <0> (+2)
:arrow_up:

...duler/server/worker/task/ShellCommandExecutor.java
85% <ø> (+85%)
4 <0> (+4)
:arrow_up:

...che/dolphinscheduler/dao/entity/ResourcesUser.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...pache/dolphinscheduler/dao/entity/ProjectUser.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...e/dolphinscheduler/dao/quartz/QuartzExecutors.java
0% <ø> (ø)
0 <0> (?)

...che/dolphinscheduler/common/log/TaskLogFilter.java
33.33% <ø> (ø)
2 <0> (?)

...e/dolphinscheduler/common/log/WorkerLogFilter.java
33.33% <ø> (ø)
2 <0> (?)

... and 375 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e607d...5ccebbf. Read the comment docs.


"Windows Defender Firewall" want to block communication of testhost.exe

Hi,
i am testing the migration from Mongo2Go to EphemeralMongo. I am getting a "Windows Defender Firewall" block when using it. This does not seem to happen when using Mongo2Go. Also when i decide to ignore this message or cancel it; it does not have any negative effect on the testrun.

Any idea were this could come from?
Regards
Thomas

Hi @ThomasTosik ,
testhost.exe is a Microsoft process that is copied to the build output and used during dotnet test [...].
I might be wrong, but I don't believe this is related to EphemeralMongo or Mongo2Go. This already happened to me when I cloned and compiled projects outside of directories that are already trusted by my Windows Defender settings. And it was not related to these libraries.
I can still explain the main difference between EphemeralMongo or Mongo2Go when it comes to processes:

Mongo2Go uses .NET Process class to start mongod.exe from the %userprofile%\.nuget\packages package cache
EphemeralMongo also uses .NET Process class to start mongod.exe from your project output directory.

Hmm actually I understood why Windows Defender Firewall gave you a warning.
That's because EphemeralMongo creates a new mongod.exe process which opens an random available port. The firewall kicks in when mongod.exe starts. Basically you have to allow mongod.exe (which is a child process of testhost.exe) to use a port on your machine.
It targets the testhost.exe process because when you start your tests, there's a hierarchy of processes that looks like this:

Parent process: testhost.exe (started by your IDE)

Child process 1: dotnet.exe

Child process 2: mongod.exe


'is_monotonic' Series implementation

What do these changes do?

[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #1263 #1264 #1266
[ ] tests added and passing

Thanks @dchigarev, I can follow what is happening, but why doesn't this work in query compiler:
is_monotonic_increasing = MapReduceFunction.register(
    lambda df: df.apply(s: is_monotonic_increasing(s)), pandas.DataFrame.all
)
is_monotonic_decreasing = MapReduceFunction.register(
    lambda df: df.apply(s: is_monotonic_decreasing(s)), pandas.DataFrame.all
)

I do not see why the edge cases were necessary.

Let's say that our Series contains [1, 2, 3, 1, 2, 3, 1, 2, 3] and in ModinFrame it splited into partitions [1, 2, 3], [1, 2, 3], [1, 2, 3] so, when we apply is_monotonic to every partition we will get [True, True, True] and then all function will return to us True. But from the source Series we see, that it's incorrect result.
That's why we also check for monotonic Series that created from edge elements

@dchigarev Yes I see, thank you it makes sense.


Does not work as a CocoaPod

If you try to use this as a CocoaPod, you don't have access to any of the classes since they are not public

@schayes04 Many thanks!
I rewrote this library as RecurrencePicker, you can use it instead.


rewritten cdap processor

Completely rewritten cdap processor following strategy outlined in #116 reimplemented cdap as a series of batch vectorized calculations

Awesome!  How much faster is it??

@fscottfoti - benchmarking it now. I think it is faster. Also, since the previous version didn't implement the max hhsize 5 cutoff, it ran out of memory trying to handle households with lots of members. For a household with 14 members, there are 3^14 alternatives, which makes for 4,782,969 columns or alternatives, which is a stretch for pandas!

Coverage decreased (-0.9%) to 95.773% when pulling c8264580f84f37a824e0b210eb99d275eb71be95 on cdap2 into 72034dacdcc2ea10bb32779947a2b939c4f0f870 on master.


feat: Implement Provision Watcher System Events

publish system events for provision watcher add/update/delete
remove the REST callbacks

close #4329
Signed-off-by: Ginny Guan<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[x] I have opened a PR for the related docs change (if not, why?)
https://github.com/edgexfoundry/edgex-docs/pull/960

Testing Instructions

build and run core-metadata with other services
find the correct logs
(optional) subscribe the redis messagebus system event topic and receive the correct messages

add a provision watcher

level=DEBUG ts=2023-02-13T09:48:21.487595056Z app=core-metadata source=provisionwatcher.go:37 msg="ProvisionWatcher created on DB successfully. ProvisionWatcher ID: 705136c5-6228-494a-8e27-f0946e1d2554, Correlation-ID: 71129ebb-344b-4799-96ec-150cd7028705 "
level=DEBUG ts=2023-02-13T09:48:21.488277751Z app=core-metadata source=notify.go:225 msg="Published the 'add' System Event for provisionwatcher 'provisionwatcher-1' to topic 'edgex/system-events/core-metadata/provisionwatcher/add/device-simple/Simple-Device'"

update a provision watcher

level=DEBUG ts=2023-02-13T09:50:54.282282186Z app=core-metadata source=provisionwatcher.go:163 msg="ProvisionWatcher patched on DB successfully. Correlation-ID: 08da17e3-2bf8-4fc2-8800-952ea5d9c9e4 "
level=DEBUG ts=2023-02-13T09:50:54.283518303Z app=core-metadata source=notify.go:225 msg="Published the 'update' System Event for provisionwatcher 'provisionwatcher-1' to topic 'edgex/system-events/core-metadata/provisionwatcher/update/device-simple/Simple-Device'"

delete a provision watcher

level=DEBUG ts=2023-02-13T09:54:02.068393209Z app=core-metadata source=notify.go:225 msg="Published the 'delete' System Event for provisionwatcher 'provisionwatcher-1' to topic 'edgex/system-events/core-metadata/provisionwatcher/delete/device-simple/Simple-Device'"

New Dependency Instructions (If applicable)

recheck

recheck

recheck

recheck


Code to reformat table generates unwanted characters

While investigating an issue of Table Editor, I noticed that several lines around this tries to insert | while the purpose is unclear.
I made some changes in this commit and hope it is the right way to resolve the issue.

Thanks for the bug report.
I will check it out.

Does the "list" described in this bug report  refer to the "Cell" in the table?
(The term "list" gets mixed up with the way it's displayed here , so I'll just call it "Cell" as in Excel.)
The double "|" is not a bug, it is intentional to create a line break when rendered.
If there is a single "|", the text will be displayed as two lines in reStructuredText, but when it is converted to HTML, it will be concatenated into one line.
This causes the problem of different display.
I believe that the display of reStructuredText and the display when converted to HTML, etc. should match as much as possible.
(I understand that you may want to write on a new line to make it easier to understand...)
So, unfortunately, I cannot agree with this change.
If there is a way to make both single and double |, I may develop a new one.
Do you have any good ideas?
(Do you want to allow users to choose between single and double in the user definition?)

Close for lack of progress.

Thanks for explaining the original design. I can now see why || is important in formatting, so I will revert the changes (which now turns out to be on the wrong direction).


⚠ Fortnite has degraded performance

In eea0904, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1694 ms

Resolved: Fortnite performance has improved in 68fcf5b.


Draft: Singlenode short-chain setup for transaction testing

Here is a non-final PR just to illustrate where the changes were made to enable Zcash_Tx_Tool

Thanks! This is related to https://github.com/ZcashFoundation/zebra/issues/8280

This was redundant now that all of the hard-coded changes can be set as part of Zebra's configuration.


Update service questions for DOS 5

Trello: https://trello.com/c/yWkgqyPL/325-2-update-dos5-application-content-in-the-frameworks-repo
We need to make a number of changes following the accessibility review and CCS requests. See the spreadsheet linked from the Trello card for details.
This PR now covers all the service question changes requested, except the reports of error oddities. I've not been able to reproduce them. Let's get this into Preview and see if they show up there.
Don't try and review this all together. I'd recommend going through commit by commit instead - they're all independent of each other.

My review checklist
I've:

[ ] looked at the changes
[ ] tested locally

@lfdebrux - thanks for the review. I think I've dealt with everything you noticed. Does this look better now?
I'm hoping to get this merged and released by the end of the day.


window.onbeforeunload不能正常工作

Version
2.3.3
Reproduction link
https://jsfiddle.net/busyhe/2942rr5m/
Steps to reproduce
打开网页点击关闭按钮没有反应，手动缩小网页界面再关闭页面就可以
What is expected?
关闭页面直接响应
What is actually happening?
不知道

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow.
I also recommend you to read MDN doc. https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload

Note also, that various browsers ignore the result of the event and do not ask the user for confirmation at all. The document will always be unloaded automatically.


Fill readmes with content and proper headlines

We have a lot of readme.md files around that have not been filled with content properly yet. That's why our TOC looks like this at the moment.

It would be cool if we could check the headlines of our sections and write at least one introductory sentence in all readme.md files.
Thanks!

It might make sense to write explanatory sentence such as "In this section we will to X which is good for Y" X can be linked to a wikipedia-article for example explaining what it is.

Please also check if the links to the slides work. Thanks!

Should be in order now


Fixed the image repeater firefox issue and removed console.log() which was left mistakenly.

Nice!
Thanks, merged. :+1:


Fix overriding session's option when using full-stack app.

If developer is not using api mode, session's middleware configuration is up to a developer.
Otherwise it will overwrite configuration.
Fixes #3048

I think all the middleware insertion should be configurable, because other than Rack::Pjax, all these are already present in a standard rails app and are therefore being duplicated, as can clearly be seen in the output of rails middleware. The overriding of cookie configuration is only the most egregious example.
Perhaps the middleware insertion belongs in the application's config/initializers/rails_admin.rb where it can be developer-managed, and not in the engine.rb where it is hard-coded.

It looks like ActionDispatch::Cookies and ActionDispatch::Flash would still be duplicated, as they are in Rails Admin 1.4 today.

59478af9 will do the job, please check the master branch.


Override cloud regions

Problem
See https://github.com/infracost/infracost/issues/1779 for an example where users need to specify a region manually. We've ran into this with other users, often when Infracost can't detect a region from the user's project and falls back to the pre-defined default we've hardcoded in the CLI code.
Questions:

Should users be able to define the default using the infracost usage-file or config-file? I lean towards the usage-file as that has other usage information, whereas config-file is used for multi-project runs. A config-file can reference multiple usage-files, so if we add it to the config-file, we'd probably need to have it as a per-project setting.

Should users be able to override the region, or set the default region that is used as a fallback? It seems like the main use-case is the latter, but being able to override the region might be helpful if users want to compare costs between regions in a given cloud vendor?

Proposed solution
See this comment.
Community note
Please add a comment with what you prefer.
Also, 👍 or subscribe to the issue for updates.

We often deploy the same terraform code to multiple regions by changing the environment terraform runs in. Having an environment variable to set the region would be my preferred approach. But still, that can just be an additional override to setting it in a config file.
Something like: environment var -> config/usage file -> provider
where -> means an override.
This way we can use good defaults in provider or config and override per env var if required.

@exoemay great point! We already have override/precedence for env vars. So for this issue, we can pick the region based on this order:

INFRACOST_AWS_REGION env var (new env var we can add for this issue)
aws-region config/usage-file (same thing as above but in config/usage-file)
terraform provider
default fallback that is hard-coded in the Infracost CLI.

In the future, if the above env doesn't fully address the use-case, we can also add a INFRACOST_AWS_DEFAULT_REGION similar to how AWS does.

That would be great.
Thanks

we have an .envrc file that sets the AWS_REGION, based on the directory. it would be good if there was an option that looked for this AWS_REGION or AWS_DEFAULT_REGION value when determining the region.
at the moment, infracost is unusable for us until this is fixed.

Let em add a use case scenario:
I have a multi-region setup wehere terraform iterates through a list of regions.
Several resources are created using for_each and indexed by region.
For dependency reasons, I always refer to resource locations using the the location property of a parent resource rather than using the region variable. So in my case I'm kaing it hard for infracost to get it.
What if we either:

Allow overriding regions in the usage file
Implement a terraform code annotation for infracost allowing us to pass directive to infracost

e.g. #INFRACOST#LOCATION#eastus#
When infracost finds this would know that the resource desribed immediately after shuld use location eastus

The new ENV vars were merged to master and will go out with the next release.

@vdmgolub can you possibly add a link to the docs PR so users who want to try it early can do it by setting the env vars and following this then this step?

@carmeloriolo, @gurpalw, @noriko3, and @pacorreia this has now been released in v0.10.14. Thanks for all your ideas and input 🙏 -  the docs for it can be found here.


Removing code to cut search results of hybrid search in the priority queue

Description
This PR removes the code where we cut the results of hybrid search while fetching topDocs(). Due to this piece of code the user gets a perception that pagination works in hybrid search however it does not. Therefore, to make cx experience better I am removing it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Will wait for @martin-gaievski to review this PR.

please add a unit test for case when from param is set in the search query to make sure we're throwing exception

Looks good to me, thanks Varun


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-07-20)
Features

allow ignoring specific models/fields in zeal_ignore (#13) (e51413b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.0
:sunflower:


Race condition in test_sync_safekeepers, when safekeeper starts up

There's a race condition in test_sync_safekeepers test (at least; I didn't check if other tests are affected). When safekeeper starts up, it first writes the PID file, and only after that binds to listen on the port. The test only waits for the PID file to appear. So if there's a delay between writing the PID file and binding to the port, the test might race ahead and try to connect to the port before it's bound, causing a connection failure. I think that's what happened here:
https://app.circleci.com/pipelines/github/zenithdb/zenith/2484/workflows/e06b8974-344b-4742-808c-c4e1a7e35277/jobs/18290
psycopg2.OperationalError: could not connect to server: Connection refused
	Is the server running on host "localhost" (<IP_ADDRESS>) and accepting
	TCP/IP connections on port 15202?
could not connect to server: Connection refused
	Is the server running on host "localhost" (<IP_ADDRESS>) and accepting
	TCP/IP connections on port 15202?
could not connect to server: Cannot assign requested address
	Is the server running on host "localhost" (::1) and accepting
	TCP/IP connections on port 15202?
batch_others/test_wal_acceptor.py:272: in test_sync_safekeepers
    res = wa_factory.instances[i].append_logical_message(
fixtures/zenith_fixtures.py:873: in append_logical_message
    with closing(psycopg2.connect(connstr)) as conn:
../../.local/share/virtualenvs/test_runner-sNYEMCQ_/lib/python3.8/site-packages/psycopg2/__init__.py:122: in connect
    conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
E   psycopg2.OperationalError: could not connect to server: Connection refused
E   	Is the server running on host "localhost" (<IP_ADDRESS>) and accepting
E   	TCP/IP connections on port 15202?
E   could not connect to server: Connection refused
E   	Is the server running on host "localhost" (<IP_ADDRESS>) and accepting
E   	TCP/IP connections on port 15202?
E   could not connect to server: Cannot assign requested address
E   	Is the server running on host "localhost" (::1) and accepting
E   	TCP/IP connections on port 15202?

This can be easily reproduced locally by adding a delay:
diff --git a/walkeeper/src/bin/wal_acceptor.rs b/walkeeper/src/bin/wal_acceptor.rs
index 529b799..b387369 100644
--- a/walkeeper/src/bin/wal_acceptor.rs
+++ b/walkeeper/src/bin/wal_acceptor.rs
@@ -132,6 +132,8 @@ fn start_wal_acceptor(conf: WalAcceptorConf) -> Result<()> {
             Ok(_) => info!("Success, daemonized"),
             Err(e) => error!("Error, {}", e),
         }
+
+        thread::sleep(std::time::Duration::from_millis(500));
     }

     let mut threads = Vec::new();

cc @arssher @petuhovskiy

So, the problem here is that tests are not properly waiting until safekeeper is ready to accept connections.
I looked at how we handling 'wait till ready' in our other services. In tests we're using zenith_cli to start other services, and the logic is following:

Compute is started with pg_ctl, which is waiting until database is ready internally.
Pageserver has /status http handler, which responds with 200 OK and is used for healthcheck. zenith_cli waits for this handler to respond with 200 OK, which means that pageserver has initialized everything and is ready to accept connections.

The latter approach seems more fitting, especially in k8s world and because we already have http_listener in safekeeper, which is used for metrics. I think we should add /status handler in safekeeper and use it to wait for startup in tests.


Support Cache-Control extensions

I'm thinking specifically about https://bitsup.blogspot.fr/2016/05/cache-control-immutable.html.
Maybe add a dict str -> (str or None) which maps the extension name to the optional payload?

@mitsuhiko and other maintainers, would you accept a PR implementing Cache-Control: Immutable?

Any progress on this? This would be valuable!

This is still marked experimental on MDN, I'm not sure I want to add that yet. Werkzeug already provides the tools to include whatever experimental options you want:
# cache_control is also a dict
response.cache_control["immutable"] = False

# or add the property
from werkzeug.datastructures import ResponseCacheControl, cache_property

ResponseCacheControl.immutable = cache_property("immutable", None, bool)


Remote method validation bug in latest 1.20.0 version

Your environment

Version of jquery-validate: 1.20.0
Browser name and version: Firefox - 115.12.0esr (64-bit), Google Chrome - Version 109.0.5414.120 (Official Build) (64-bit), Microsoft Edge - Version 109.0.1518.140 (Official build) (64-bit)

Current behavior
There appears to be a validation bug when using the remote method (https://jqueryvalidation.org/remote-method/) in the latest 1.20.0 version of the plugin.
It can be triggered a number of different ways, but the steps below are one simple way of triggering it (using the demo code provided):

Click or tab inside the field, and enter 20 (an invalid number), then click or tab outside the field.
A validation failure message should appear.
Click or tab inside the field again, this time highlight the 0, and overwrite it with 1, to update the number to 21 (a valid number), then quickly click or tab outside the field before the AJAX function returns a result.
The field should now be valid, but the previous validation failure message does not disappear, the field is not considered valid, and the form can not be submitted.

Or you can do the reverse, enter 21, update it to 20, then the field is invalid, but is considered valid, and the form can be submitted.
It's worth noting the bug will not be triggered when:

Deleting and retyping the numbers, as opposed to overwriting them.
Overwriting a 1 digit number with a 2 digit number, etc.
Waiting for the AJAX function to complete before clicking or tabbing outside the field.

The bug does not appear to be present when using the 1.19.5 version of the plugin.
Expected behavior
Validation should function correctly when following the steps above.
Live demo
HTML / jQuery:
<!DOCTYPE html>

    <meta charset="utf-8">
    <title>jQuery validation - test - v1.20.0</title>

    <form class="test_form" id="test_form" method="get" action>
      <fieldset>

          Enter a number greater than 20:
          <input id="test_field" name="test_field" type="text">

          <input class="submit" type="submit" value="Submit">

      </fieldset>
    </form>

PHP for remote AJAX function (using Wordpress):
function ajax_test_function_1() {
  $test_field_val = $_POST['test_field_val'];
  if( $test_field_val > 20 ) {
    echo json_encode(true);
  } else {
    echo json_encode('Error - number is not greater than 20');
  }
  die();
}
add_action( 'wp_ajax_test_function_1', 'ajax_test_function_1' );
add_action( 'wp_ajax_nopriv_test_function_1', 'ajax_test_function_1' );

Might have been fixed by https://github.com/jquery-validation/jquery-validation/pull/2481

@sipitai check https://github.com/jquery-validation/jquery-validation/releases/tag/1.20.1

This version does appear to fix the issue. Cheers!


Add support for WebFlux RouterFunction in spring-boot.

@ryanjbaxter: is this what you had in mind?
Note, this is still affected by #222.

Yes this covers the non Spring MVC WebFlux use case.  The other use case I can think of is if Spring Cloud Gateway is on the classpath.

@ryanjbaxter: can you provide more info about the case where scg is in the classpath? Should we just treat it like we do with sck? Would you like to take a stab at it?


[Feature request] React Native support

Emotion has an @emotion/native which has a very similar API, but with the basic React Native components.
for example:
import styled, { css } from '@emotion/native'

const Container = styled.View`
  display: flex;
  justify-content: center;
  align-items: center;
  margin: 50px;
`

const Description = styled.Text({
  color: 'hotpink'
})

const Image = styled.Image`
  padding: 40px;
`

const emotionLogo = 'https://cdn.rawgit.com/emotion-js/emotion/main/emotion.png'
const App = () => (
      <Container
        style={css`
          border-radius: 10px;
        `}
      >
        <Description style={{ fontSize: 45, fontWeight: 'bold' }}>
          Emotion Primitives
        </Description>
        <Image
          source={{
            uri: emotionLogo,
            height: 150,
            width: 150
          }}
        />
      </Container>
    )
  }
}

The prop types can be safely copied from rescript react native.
I am not very familiar with ppxes, but I would be able to contribute with, for example, documentation if needed.

Hi @davisuga, Thanks for opening the issue :D
There are a few things that need to happen to support React Native in styled-ppx.
First, we should look into adding support on bs-css (1. adding the binding, 2. add properties that are supported only in native?) or maybe we could not use emotion out of the box and bind directly to inline styles: https://github.com/rescript-react-native/rescript-react-native/blob/main/src/apis/Style.res
Second, we could add all components from React Native as valid primitives on styled.xxx ppx.


vcpkg install gtk fail

vcpkg install gtk fail when install libepoxy
compiler crash ?
the console message:
$ ./vcpkg.exe install gtk
The following packages will be built and installed:

atk[core]:x86-windows
bzip2[core]:x86-windows
cairo[core]:x86-windows
dirent[core]:x86-windows
expat[core]:x86-windows
fontconfig[core]:x86-windows
freetype[core]:x86-windows
gdk-pixbuf[core]:x86-windows
gettext[core]:x86-windows
glib[core]:x86-windows
gtk[core]:x86-windows
harfbuzz[core,glib,ucdn]:x86-windows
libepoxy[core]:x86-windows
libffi[core]:x86-windows
libiconv[core]:x86-windows
libpng[core]:x86-windows
pango[core]:x86-windows
pcre[core]:x86-windows
pixman[core]:x86-windows
ragel[core]:x86-windows
zlib[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/21: libepoxy:x86-windows
Building package libepoxy[core]:x86-windows...
-- Using cached F:/msys64/home/dry_ruijie/vcpkg/downloads/anholt-libepoxy-1.4.3.tar.gz
-- Using source at F:/msys64/home/dry_ruijie/vcpkg/buildtrees/libepoxy/src/1.4.3-d354d88b66
-- Configuring x86-windows-rel

Hi @dry-git, thank you for posting the issue, does the issue still occur? Can you provide the install log?

I have the same problem.

and no log output (log file 0 KB)

PS D:\WorkSpace\C++\vcpkg> .\vcpkg install gtk:x64-windows
The following packages will be built and installed:
gtk[core]:x64-windows

pango[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/2: pango:x64-windows
Building package pango[core]:x64-windows...
-- Using cached D:/WorkSpace/C++/vcpkg/downloads/pango-1.40.11.tar.xz
-- Using source at D:/WorkSpace/C++/vcpkg/buildtrees/pango/src/1.40.11-f997ae867d
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_build_cmake.cmake:202 (message):
Command failed: D:/Program Files/CMake/bin/cmake.exe;--build;.;--config;Debug;--target;install;--;-v
Working Directory: D:/WorkSpace/C++/vcpkg/buildtrees/pango/x64-windows-dbg
See logs for more information:
D:\WorkSpace\C++\vcpkg\buildtrees\pango\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/pango/portfile.cmake:25 (vcpkg_install_cmake)
scripts/ports.cmake:71 (include)
Error: Building package pango:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: pango:x64-windows
Vcpkg version: 2018.11.23-nohash
Additionally, attach any relevant sections from the log files above.

Please help me .I have no idea.

区域语言要改成英文的，同事vs也把需要改成英文，试试看。------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年5月19日(星期天) 上午10:35
收件人<EMAIL_ADDRESS>抄送: "dry-git"923151719<EMAIL_ADDRESS>主题: Re: [microsoft/vcpkg] vcpkg install gtk fail (#6145)
Please help me .I have no idea.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Change language to english [vs2019] and get "pango:x64-windows build failed"
log->
install-x64-windows-dbg-out.log

#6622

Hi @dry-git, can you update vcpkg and rebuild pango again?
Thanks.

Thanks for posting this issue. Please open a new issue if this is still a problem for you.


App crash on launch

Hi,
Was interested in getting your example running and ran into the following issue where after I run the final react-native run-android the app crashes with the following logs. Looking for ideas on how I can troubleshoot and fix. I am using an Android Emulator, thanks!
2019-03-06 01:18:01.446 6061-0/com.avatardemo E/Go: panic: runtime error: invalid memory address or nil pointer dereference
2019-03-06 01:18:01.446 6061-0/com.avatardemo E/Go: [signal SIGSEGV: segmentation violation code=0x1 addr=0x14 pc=0xd52d2ba9]
2019-03-06 01:18:01.446 6061-0/com.avatardemo E/Go: goroutine 17 [running, locked to thread]:
2019-03-06 01:18:01.446 6061-0/com.avatardemo E/Go: github.com/ipsn/go-ghostbridge.(*Bridge).Port(0xa4c449e0, 0xd53b0f60)
2019-03-06 01:18:01.446 6061-0/com.avatardemo E/Go: 	C:/Users/username/go/src/github.com/ipsn/go-ghostbridge/ghostbridge.go:103 +0x19
2019-03-06 01:18:01.446 6061-0/com.avatardemo E/Go: main.proxyghostbridge_Bridge_Port(0xffffffe8, 0xa4c003c8, 0x3)
2019-03-06 01:18:01.447 6061-0/com.avatardemo E/Go: 	C:/Users/username/AppData/Local/Temp/gomobile-work-318865607/src/gobind/go_ghostbridgemain.go:49 +0x46
2019-03-06 01:18:01.447 6061-6080/com.avatardemo E/GoLog: panic: runtime error: invalid memory address or nil pointer dereference
2019-03-06 01:18:01.447 6061-0/com.avatardemo E/Go: main._cgoexpwrap_f91d87702665_proxyghostbridge_Bridge_Port(0xffffffe8, 0x24d6, 0xf0392084)
2019-03-06 01:18:01.447 6061-0/com.avatardemo E/Go: 	_cgo_gotypes.go:188 +0x1b
2019-03-06 01:18:01.447 6061-6061/com.avatardemo A/libc: Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 6061 (com.avatardemo), pid 6061 (com.avatardemo)

How does your java file look like? Could you paste it here?

Apologies - I was being a spud and did not create the go avatars package as per the instructions.
Got it working, it's awesome - thanks!

@ejdoh1 would you mind to provide me a sample repo? I'm trying to make it work here.


Prepublish hook is not executable without sh

While testing code for elm-live I've noticed publishing (or in this case npm link-ing) the repository on Windows fails because the prepublish hook is written in shellscript.
One way around this would be to use something like shelljs and port the script to a javascript file.

Yeah, well to be honest the prepublish hook also uses man to compile the help. So it’s very unlikely we can get it to run natively on Windows.
So far we’ve been getting around this by only releasing from a Unix computer. Releasing from a CI server instead seems to be the way to go – if anyone wants to help, we’ll very much appreciate it!

I think a good solution for this would be to start transitioning Elm-live to a command-line tool like commander. It will help with argument management and remove the need for man to run during prepublish

Issue should be resolved now. However, if that is not the case please open a new issue and we can get it figured out.


fix:used UpgradeTimeout instead of TimeoutHeight and TimeoutTimestamp

Description

closes: #3410
Commit Message / Changelog Entry
fix:used UpgradeTimeout instead of TimeoutHeight and TimeoutHeight

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md).
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the module structure standards and Go style guide.
[x] Wrote unit and integration tests.
[x] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[x] Added relevant godoc comments.
[x] Provide a commit message to be used for the changelog entry in the PR description for review.
[x] Re-reviewed Files changed in the Github PR explorer.
[x] Review Codecov Report in the comment section below once CI passes.

Thank you for the PR @vishal-kanna. I believe these changes are now redundant as a different direction has been proposed in https://github.com/cosmos/ibc-go/pull/3438
I'll close this PR and the associated issue


Add Acider Runner

About the PR

The one and only acid rouny.
Why / Balance

parity!
Technical details

Changes were made to the xeno energy system for custom popups and laying down/late infected logic to not give energy.
CorrodibleComp needed a bool added for tagging something as a structure, and made a public function for applying acid to something in the XenoAcidSystem as that was also needed. Also made it work with energy and checking said structure thing. And also for acid applying mods because rouny is fast at aciding.
XenoAcidSlash system applies a comp (supposed to be acid) on hit. pretty simple.
XenoForTheHiveSystem and it's shared variant do...alot. There's a client side visualizer system for swapping the sprites out and making the animation speed a bit faster. Not sure how noticable the latter is. The sound from starting the bomb also gets louder the closer it is to boom but also kinda hard to tell how much it's scaling. The action event triggers the appearance change and glow and stuff and starts a countdown only the player sees. Once it reaches 0 without them dying (the update func just skips over the dead like in CM) They go boom. Radius depends on store acid, its circular unlike CM's squares because distance functions but shouldn't matter too much I hope. There's an acid range and burn range. Acid range acids barricades with normal level acid and mobs with the acid effect. Damage is based on Range with max damage being right on the rouny and decaying from there. Once a rouny dies this way they either almost immediately respawn from their corpse if there is no hive core or wait 5s to respawn at hive core. If hive core disappears in this time they spawn like burrowed larva for now. I think they're supposed to fail and not give a burrowed larva in that case but that'll have to be implemented later.
Speed values should somewhat match CM, least sprite speed. Someone might want to make sure it's right though. Damage and range of the explosion differ a bit because CM uses an...interesting distance function and the whole square thing.
TLDR they go boom
Media

https://github.com/user-attachments/assets/07947677-0ad5-49c3-8715-d570c01df1cc
(Note for the Hive's shout has been corrected since this)
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

add: Added Acider Runner, who can apply acid to marines on hit, and gains acid reserves which they can spend on boiler-level acid that can be applied quickly or become a living time bomb For The Hive!

finally rouny suiciding to survivors can have a purpose :trollface:

maybe it should jitter around violently when it's counting down to explode, i think that conveys "this thing is going to fucking explode" quite well

Don't think it's needed with the color + anim, green glow (not visible because NV in the video) and sound.


Mechanism for revocation of a published sample result

I think we need to add a mechanism to the standard to revoke a published sample result if it is discovered after-the-fact that a result is not valid due to an issue like malfunctioning/miscalibrated test equipment, improper collection technique that may have resulted in contamination, or some other issue.

A revokes object has been added as a water quality sample object.
Revocation: A record issued in this standard can indicate that a previously issued record has been effectively "revoked". This is useful in instances where a publishing entity or organization is correcting previously issued record data, or is issuing new record data using more precise/accurate measurement methods. For example, a record issued using a predictive modelling method and be revoked by a second record when laboratory sample data becomes available.
Please note that it is considered a violation of the standard to revoke a GUID from another organization. The reverse FQDN portion of the original record and the revoking record should match before an entity or organization processing ingested records should consider the revocation valid. The validation schema makes no direct attempt to prevent cross-organization revocation from occurring, but consuming entities or organization are encouraged to account for this prohibition when processing ingested records.
The reference array allows for sample/s related to the revocation to be referenced directly.
For more info see the Sample Result Revocation and Referencing in the Reference document
Closing this issue.


More strong Promise in lib.es6.d.ts

I think it would be good to be able to define the type of error in Promise type. I suggest promise type to be something like this:
interface Promise<T,U> {
    /**
    * Attaches callbacks for the resolution and/or rejection of the Promise.
    * @param onfulfilled The callback to execute when the Promise is resolved.
    * @param onrejected The callback to execute when the Promise is rejected.
    * @returns A Promise for the completion of which ever callback is executed.
    */
    then<TResult>(onfulfilled?: (value: T) => TResult | PromiseLike<TResult>, onrejected?: (reason: U) => TResult | PromiseLike<TResult>): Promise<TResult>;
    then<TResult>(onfulfilled?: (value: T) => TResult | PromiseLike<TResult>, onrejected?: (reason: U) => void): Promise<TResult>;

    /**
     * Attaches a callback for only the rejection of the Promise.
     * @param onrejected The callback to execute when the Promise is rejected.
     * @returns A Promise for the completion of the callback.
     */
    catch(onrejected?: (reason: U) => T | PromiseLike<T>): Promise<T>;
    catch(onrejected?: (reason: U) => void): Promise<T>;

    [Symbol.toStringTag]: string;
}

Or at least have a Promise<T, U> type which extends Promise<T>.

This is another good use-case for implementing #2175.
interface Promise<T, U = Error> {
 ....
}

You didn't update the types of PromiseLike and Promise returned from then and catch. If you had, you'd see the error type becomes larger and larger, since all promises in a chain contribute to the error type (unlike the result type where only the last promise contributes to it).
Consider:
// A promise that resolves to string value or rejects with number value
var promise: Promise<string, number>;

// A promise that uses previous promise to resolve to string value or fail with Error value,
// and lets failure of previous promise fall-through.
var promise2 = promise.then(result => {
    if (result.length === 0) {
        throw new Error("");
    }
    return result;
});

The type of promise2 needs to be Promise<string, number | Error>. The error type will grow as more promises are added to the chain.

Without explicit type annotation, TS cannot know to append | Error to the error type since it does not know to modify the type of the callback (and by extension the generic specialization of the promise.then() call) based on throw statements in the body of the function.

So at a minimum (i.e., the best you can do with current TS syntax) you'd need to do this:
    then<TResult, TError>(onfulfilled?: (value: T) => TResult, onrejected?: (reason: U) => TResult | PromiseLike<TResult>): Promise<TResult, U | TError>;

// Explicitly need to pass in specialization of TError = Error since it is unbound otherwise.
// Even if neither callback throws a different type than U (or throws at all), this will still be needed.
var promise2 = promise.then<string, Error>(...);

To have TS bind TError implicitly, you'd need some kind of throws TError annotation on each callback's signature:
    then<TResult, TError>(onfulfilled?: (value: T) => TResult throws TError, onrejected?: (reason: U) => TResult | PromiseLike<TResult> throws TError): Promise<TResult, U | TError>;

and then require TS to be able to consider throw statements to infer the throws-type for functions and for generic specialization.
This then basically becomes checked exceptions which bring all of their associated problems (like being unable to be used with higher-ordered functions).

Surely we can add the error generic and it will default to any? This would mean promises can continue to be used how they are today, but with the added ability to specify the error generic in a type annotation if wanted.
For context, I am using the browser’s fetch function, and in my .catch I lose all type safety because the error is typed as any. It is easy enough to specify the parameter type in the callback, but if we improved Promise typings as suggested, this could work out of the box:
fetch('foo').catch(e => {
  e.message // string
})

Without explicit type annotation, TS cannot know to append | Error to the error type since it does not know to modify the type of the callback (and by extension the generic specialization of the promise.then() call) based on throw statements in the body of the function.

I see, however TypeScript would know to append | Error to the error type if the callback returned a promise?

Workaround for fetch is to specify your own Promise interface and annotate the promise as needed:
/**
 * Represents the completion of an asynchronous operation
 */
interface Promise<T, U> {
    /**
     * Attaches callbacks for the resolution and/or rejection of the Promise.
     * @param onfulfilled The callback to execute when the Promise is resolved.
     * @param onrejected The callback to execute when the Promise is rejected.
     * @returns A Promise for the completion of which ever callback is executed.
     */
    then<TResult1 = T, TResult2 = never>(onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | undefined | null, onrejected?: ((reason: U) => TResult2 | PromiseLike<TResult2>) | undefined | null): Promise<TResult1 | TResult2, U>;

    /**
     * Attaches a callback for only the rejection of the Promise.
     * @param onrejected The callback to execute when the Promise is rejected.
     * @returns A Promise for the completion of the callback.
     */
    catch<TResult = never>(onrejected?: ((reason: U) => TResult | PromiseLike<TResult>) | undefined | null): Promise<T | TResult, U>;
}

const promise: Promise<any, Error> = fetchPromise('foo')
promise.catch(e => e.message);

This should be consistent with synchronous exceptions, i.e. this should be done if and only if https://github.com/Microsoft/TypeScript/issues/13219 gets implemented

I agree the ideal solution would be to have typed exceptions and then being able to correctly type Promises... but seeing that it may take a looooong time to have typed exceptions, I created a library that works likes promises but with a subtle difference that allows me to have typed errors and a pretty good error inference. Been using it on production for more than 6months and I'm really happy with the results.
The whole problem arises because we can't forbid a function from throwing, and we cant know the type that it's thrown, so what I did is favour the idiomatic way of returning an error, which is returning a rejected "Promise" and if for some reason a function throws, i put the error inside an UnknownError class, with an unknown property.
Here's the library https://github.com/ts-task/task and here is a video explain in it with more detail https://www.youtube.com/watch?v=T7O1T1wmw00


crash when saving illegal json string to JSONField

When saving illegal json string to a JSONField, ValueError raised. ValidationError raised excepted.

please try with the github version and if you still have problems provide more information (including reproducible test case)

I don't think it needs a test case. It's obvious that it should raise ValidationError in method to_python, not ValueError.
db/fields/json.py:84 I think we should catch ValueError and raise ValidationError here.

It's not obvious to somebody reading the ticket.
Since there is no traceback or alike information.
The reproducible case is so that somebody that wants to create a PR can get
going without having to figure out what exactly you need to do to trigger
your problem.
Regards,
Trbs
On Mon, Dec 14, 2015 at 3:02 AM, craynic<EMAIL_ADDRESS>wrote:

I don't think it needs a test case. It's obvious that it should raise
ValidationError in method to_python, not ValueError.
db/fields/json.py:84 I think we should catch ValueError and raise
ValidationError here.
—
Reply to this email directly or view it on GitHub
https://github.com/django-extensions/django-extensions/issues/778#issuecomment-164322218
.


Inconsistent input and output characters

I have two computers. Computer 1 is remotely connected to Computer 2 through VDI. I wrote a WPF program to output the input string to the Notepad of Computer 2 by calling the SimulateTextEntry method. This function works normally on Computer 1 and can output the correct string. However, when I enable the software on Computer 1, call the same method, and move the mouse cursor to Notepad of Computer 2, the output string does not match the input character. In English input method, the input string "11111" becomes "nnnnn=9" on computer 2

Hi! Thanks for posting this issue! This certainly seems weird, but could it be possible that it's an issue with an underlying Windows API, and not with SharpHook?
Could you please try using SendInput directly to simulate text entry to see whether there is the same problem? If there is, then I don't think I'll be able to do much about it.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Runtime.InteropServices;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
namespace CRApp {
    public static class KeyboardInput {
        [DllImport("user32.dll")]
        static extern uint SendInput(uint nInputs, [MarshalAs(UnmanagedType.LPArray), In] INPUT[] pInputs, int cbSize);
        [StructLayout(LayoutKind.Sequential)]
        struct INPUT {
            public uint type;
            public MOUSEKEYBDHARDWAREINPUT mkhi;
        }
        [StructLayout(LayoutKind.Explicit)]
        struct MOUSEKEYBDHARDWAREINPUT {
            [FieldOffset(0)]
            public HARDWAREINPUT hi;
            [FieldOffset(0)]
            public KEYBDINPUT ki;
            [FieldOffset(0)]
            public MOUSEINPUT mi;
        }
        [StructLayout(LayoutKind.Sequential)]
        struct KEYBDINPUT {
            public ushort wVk;
            public ushort wScan;
            public uint dwFlags;
            public uint time;
            public IntPtr dwExtraInfo;
        }
        [StructLayout(LayoutKind.Sequential)]
        struct HARDWAREINPUT {
            public uint uMsg;
            public ushort wParamL;
            public ushort wParamH;
        }
        [StructLayout(LayoutKind.Sequential)]
        struct MOUSEINPUT {
            public int dx;
            public int dy;
            public uint mouseData;
            public uint dwFlags;
            public uint time;
            public IntPtr dwExtraInfo;
        }
        public static int InputText(string text) {
            if (string.IsNullOrEmpty(text)) {
                return 0;
            }
            INPUT[] inputs = new INPUT[text.Length * 2];
            for (int i = 0, j = 0; i < text.Length; i++, j += 2) {
                ushort ch = text[i];
                inputs[j] = new INPUT {
                    type = 1,
                        mkhi = new MOUSEKEYBDHARDWAREINPUT {
                            ki = new KEYBDINPUT {
                                wVk = 0,
                                    wScan = ch,
                                    dwFlags = 0x0004,
                                    time = 0,
                                    dwExtraInfo = IntPtr.Zero
                            }
                        }
                };
                inputs[j + 1] = new INPUT {
                    type = 1,
                        mkhi = new MOUSEKEYBDHARDWAREINPUT {
                            ki = new KEYBDINPUT {
                                wVk = 0,
                                    wScan = ch,
                                    dwFlags = 0x0004 | 0x0002,
                                    time = 0,
                                    dwExtraInfo = IntPtr.Zero
                            }
                        }
                };
            }
            uint result = SendInput((uint) inputs.Length, inputs, Marshal.SizeOf(typeof(INPUT)));
            return result > 0 ? text.Length : 0;
        }
    }
}

I used the above code, but it still doesn't work properly on computer 2. When I tried using Python code, it worked fine on computer 2. Therefore, I envisioned converting strings into hexstrings, and Python code only needed to map hexstrings.
demo
from pynput.keyboard import Key, Controller, KeyCode
import time
import binascii

keyboard = Controller()

time.sleep(1)

kMap = {
    '~': '`',
    '!': '1',
    '@': '2',
    '#': '3',
    '$': '4',
    '%': '5',
    '^': '6',
    '&': '7',
    '*': '8',
    '(': '9',
    ')': '0',
    '_': '-',
    '+': '=',
    '{': '[',
    '}': ']',
    '|': '\\',
    ':': ';',
    '\"': '\'',
    '<': ',',
    '>': '.',
    '?': '/',
}

def type(s:str):
    for c in s:
        if ord(c) > 127:
            continue
        if c == '\n':
            c = Key.enter

        shift = kMap.get(c) is not None
        if shift:
            c = kMap.get(c)

        if shift:
            with keyboard.pressed(Key.shift):
                time.sleep(0.01)
                keyboard.tap(c)
                time.sleep(0.01)
        else:
            keyboard.tap(c)
            # time.sleep(0.01)

s =  """你好"""

type(s)

Apparently, SendInput doesn't send Unicode characters correctly through VDI, at least that's what I think. Your code seems correct - if it doesn't work, then I don't really think I can help here, as I've never worked with VDI and currently don't have time to research it. I think you will have more luck asking around on forums related to VDI, why this happens.
Regarding the Python code - it appears to do something completely different - it just simulates pressing and releasing the specified keys (and you've also added basic Shift handling), but correct me if I'm wrong though. This is not what SharpHook (and SendInput) does when simulating text entry - it simulates the Unicode characters directly so there is no dependency on whether the Shift key is pressed or not, or a dependency on the current keyboard layout.
I'm going to keep this issue open for some time, but as I've said, I don't think I'll be able to do anything about it, so any help is appreciated.

I'm closing this issue due to inactivity and inability to fix it, but we can continue the discussion, and I will reopen it if anything comes up.


[Bug]: Chorus Modal Track Info

The track info in the modal is flexible thus it causes the modal height to vary. I want a constant height, thus I would prefer if the tack info text scrolls when the text is larger than the container instead of wrapping. This is already implemented in the Popup UI, so that's a great starting point.

I went ahead and implemented this already within #177.


[CARBONDATA-2753] Fix Compatibility issue with Preaggregate table

Problem: User creates maintable and load data and create preaggregate datamap on maintable using old version and loads data into maintable using new version and dataload fails.

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Retest this please

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/6061/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5919/


Change Binance DEX config url

Load balancer points to .../api/  and in order to utilize private env var ATLAS_BINANCE_DEX current changes required.

Current implementation is correct, not changes required for this.


JARs include empty "dist" folder

Since moving the frontend files to a designated folder in deb99541e95d47f2c690f1e522dbe25dacc3e2d6 , the JARs include a empty folder. No idea where that comes from, since there is no more "dist" folder in the project

I can't find that empty folder in the jar file. Maybe try to freshly clone the project again and create the jar that way.

@t-buss have you looked into this again? Can you confirm that this is a non-issue?


[MXAPPS-581] Disable an additional long test in the SD nightly.

Disable an additional test in the SD nightly that also takes over the
timeout.

This is an additional test that should have bene disabled in to https://github.com/apache/incubator-mxnet/pull/12326
Confusingly this test is failing just for Python 2. I will revisit and adjust the timeouts.
Here is the log message:
[StraightDope: Python2 Single-GPU] .INFO:root:Running notebook 'chapter08_computer-vision/visual-question-answer'
[StraightDope: Python2 Single-GPU] INFO:traitlets:Executing notebook with kernel: python2
[StraightDope: Python3 Single-GPU] ERROR:traitlets:Timeout waiting for execute reply (600s).
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[* ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ *] Changes are complete (i.e. I finished coding on this PR)
[ *] Code is well-documented:
[* ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@szha This also needs to go in 1.3 branch. Will create PR for release branch to get this commit in after this is merged

Created a tracking Github issues for these whitelisted tests. We need to reenable them. https://github.com/apache/incubator-mxnet/issues/12345


DO NOT MERGE YET Reduce core dependencies on big things

PR in progress for CI. Do not merge yet.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2419/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3140/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2421/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3142/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2422/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3143/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2423/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3144/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2424/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3145/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2425/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3146/
Test PASSed.

OK it's complete.
Review by @nicolasstucki

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2426/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3147/
Test PASSed.

LGTM


Fixed Issue by balancing round brackets in tests string

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #12739

Description

Fixed the issue by balancing round brackets in the test string of the challenge

@shubham1996 this didn't seem to fix the test. I tried it locally and the correct code still does not pass. Is it passing for you?

I did not actually test the code locally because it seemed like a very trivial error as the regex expressions were valid and only thing which was being missed out was the round bracket.
I know I am a little late in replying back but I'll test this update the PR in some time

Closing this PR and deleting my comment from the issue so that someone else can work on this.


Flow control on RestTemplate doesn't intercept URLs with parameters

Component: Sentinel
Description:
A resource flow control (http://localhost:8002/{id}) was set, but did not take effect on RestTemplate when access the url: http://localhost:8002/123, while feign did.
STR:

set the rule as following:
{
"resource": "GET:http://localhost:8001/{id}",
"controlBehavior": 0,
"count": 1,
"grade": 1,
"limitApp": "default",
"strategy": 0
}
Use RestTemplate to access http://localhost:8001/123 as following:

String user = restTemplate.getForEntity("http://localhost:8001/{id}", String.class, Collections.singletonMap("id", id)).getBody();

You'll see the rule doesn't take effect to intercept the url.

Investigation:
The logic of how to fetch the resource is different in SentinelProtectInterceptor and SentinelInvocationHandler. It's easy to get the accurate resource for feign in SentinelInvocationHandler because it's explicitly defined on the annotation, but it's hard to get it in SentinelProtectInterceptor for RestTemplate because the request has been evaluated before intercepted.
It's hard, but the info is really there as you can see in the step 2 of STR.

It seems we could not get wildcard characters in ClientHttpRequestInterceptor.
Maybe we could create a class like UrlCleaner to clean url.

Is there any plan to fix/enhance it in 0.2.2?

Creating UrlCleaner:
public interface UrlCleaner {
    String clean(String originUrl);
}

Adding UrlCleaner in SentinelProtectInterceptor to clean url:
// ...
String newResource = urlCleaner.clean(hostWithPathResource);
SphU.entry(newResource, EntryType.OUT);
// ...

Then you could implement the path matching algorithm with UrlCleaner.

Is there any plan to fix/enhance it in 0.2.2?

Not yet, maybe next version.

Is there any plan to fix/enhance it in 0.2.2?

Not yet, maybe next version.

This is very important feature. Without this, it's nearly no way to use client-side flow control because the rule can't be defined for those RestTemplate has already been widely used.
Hope it can be enhanced in 0.2.2.

Is there any plan to fix/enhance it in 0.2.2?

Not yet, maybe next version.

This is very important feature. Without this, it's nearly no way to use client-side flow control because the rule can't be defined for those RestTemplate has already been widely used.
Hope it can be enhanced in 0.2.2.

Why not use Open-Feign?

Is there any plan to fix/enhance it in 0.2.2?

Not yet, maybe next version.

This is very important feature. Without this, it's nearly no way to use client-side flow control because the rule can't be defined for those RestTemplate has already been widely used.
Hope it can be enhanced in 0.2.2.

Why not use Open-Feign?

Some URLs may be dynamic and specified by configuration after deployment. OpenFeign can only be used on the scenario that we know the APIs during coding.


Update links to current domaintools locations.

Hi Cmikk!
Questions around these changes:
Generally: what's the plan around the https://github.com/farsightsec/
references?
Are those going to be changed to a publicly available DomainTools github.com
page?
Regarding README.md ....

Some of the new DomainTools pages point to pages that were authored by
former employees. I think it's appropriate to leave (for example) Ben
April's name on Ben Aprils' stuff, but I know in some cases references to
no-longer employed authors has been stripped. Not saying that's good or
bad, just flagging the issue for consistency sake.

Contrast:
https://www.domaintools.com/resources/blog/farsights-network-message-loss-tracking-explained/
(authored by "Farsight Security" now, formerly Mike Schiffman)
with
https://www.domaintools.com/resources/blog/visualizing-the-incidence-of-ipv4-addresses-in-farsights-dnsdb/
(authored by Ben, and still shown as such)

Some of the URLs are pretty dang long. For example:

https://www.domaintools.com/
resources/blog/new-farsight-white-paper-available-for-download-building-a-demo-
gui-front-end-for-dnsdb-api-in-scala/
Would it be worthwhile considering shorter links for URLs of that length?

After lines 69-70, no link to the Bang Question report. (I've rolled a
copy of the report out to
https://domaintools.atlassian.net/wiki/spaces/~122736944/pages/4190994448/Bang+Question+Report
if you need to recover a copy of it)

Regarding: sie_get/sie_get.1

Pointer to
https://www.domaintools.com/resources/user-guides/security-information-exchange-feed-guide/

I think that should be "Channel Guide" not "Feed Guide" (document URL is to
the right document, but the document was renamed somewhere along the line,
shouldn't have been)
Thanks for the chance to look this over. I'll hold off on approving until I
hear on the above.
Thanks,
Joe
On Mon, Mar 25, 2024 at 1:53 PM Chris Mikkelson @.***>
wrote:

@cmikk https://github.com/cmikk requested your review on: #6
https://github.com/farsightsec/blog-code/pull/6 Update links to current
domaintools locations..
—
Reply to this email directly, view it on GitHub
https://github.com/farsightsec/blog-code/pull/6#event-12240646245, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOQ6LQ2EUHVHGKCJN2RH6LY2CFE5AVCNFSM6AAAAABFHW6F56VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGI2DANRUGYZDINI
.
You are receiving this because your review was requested.Message ID:
@.***>

Good questions.
Regarding the github.com/farsightsec repos, to the best of my knowledge we are not planning to move / merge these with DomainTools's github presence. This could change in the future, but was not in scope for this update (which focused on resolving broken links).

Noted. I've left the initial attributions in links here. I think the distinction is whether the authors were ever employed at DomainTools, and thus got a domaintools profile.

I would prefer not to engage a URL shortener, so I'll go with the link length dictated by the destination website.

It looks like this report was never linked in this github repo. If it's ever linked publicly, we can fix this.

As with (0) and (2), I'm focusing on fixing broken links. For now, the "feed guide" page is the best destination for the SIE channel guide.


Migrate favicon to svg

As svg icons are supported in all modern browsers right now, maybe we can update it.
Some references:

https://medium.com/swlh/are-you-using-svg-favicons-yet-a-guide-for-modern-browsers-836a6aace3df
https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs
https://catalin.red/svg-favicon-light-dark-theme/

Would be nice to also addresses light and dark themed:
https://catalin.red/svg-favicon-light-dark-theme/


Ballerina push required to push given module and its imported modules as well.

Description:
ballerina push currently push only module. We need to support pushing its imported modules in the project as well.

Closing as per PR merged


A question about the dynamic prior in stage 2 training.

From the config, I know the dynamic prior in stage 2 training fixed on 1.

I wonder why don't you set the dynamic prior multi-combinated, just the same as the stage 1 training？

Thanks. I also want to ask where I can set the probailities of the dynamic prior. I don't find similar value in the configs.

@zhoujiawei3
The probabilities for each type of conditioning are set here: https://github.com/OpenDriveLab/Vista/blob/6ff19b805c646e050414567425728aac4257d767/vwm/modules/diffusionmodules/loss.py#L74-L77

@zhoujiawei3 The probabilities for each type of conditioning are set here, namely, weights:
https://github.com/OpenDriveLab/Vista/blob/6ff19b805c646e050414567425728aac4257d767/vwm/modules/diffusionmodules/loss.py#L74-L77

Thank you very much for your help！


Main

The link to added project have been added to the main home page.

Hey the project on click leads to no repo, can you fix it

Hey the project on click leads to no repo, can you fix it

It is done.
Sorry for the error.

@fykaa
Please check once


improve "open /etc/subuid: no such file or directory" error message

Existing openSUSE deployments will run into the issue that /etc/sub{g,u}id are not present as no (base) package added those; useradd and usermod don't create those files. I've fixed this via the shadow package now adding those files so that new installs and new users have proper entries but that doesn't solve the issue for existing users.
In other words, existing users don't have this file and will always run into Podman failing with "open /etc/subuid: no such file or directory". I think Podman should catch those errors and guide the user a bit more, maybe even printing the corresponding section from podman (1).

should we move this issue to containers/storage?  The logic for handling /etc/sub{g,u}id is there

SGTM

I opened https://github.com/containers/storage/issues/231. I suggest keeping the issue here open until https://github.com/containers/storage/issues/231 is merged and vendored.

@rhatdan SGTM

I am okay with both solutions :+1:

I think we need more documentation, for different platforms as the evolve.  RHEL and Centos also do not  fully support podman as non root yet.

@vrothberg @TomSweeneyRedHat Any movement on this?  Better documentation in man pages?

@rhatdan, for me https://github.com/containers/libpod/pull/1795 solved the issue. I am not sure if we could improve the situation besides making that clear in the RHEL docs.

Ok closing.


How to calibrate the curtain module?

Hello community,
I recently got the tuya zigbee curtain module installed. But it is set on a percentage open and closed which does not match the curtain I have. Is there a way to calibrate the curtain module and how?
Ps. I’m at beginner level in homey.

Hi @Majebo, currently there is not. Working on it.

Hi Johan, thx for your reply. Any idea when u think it will be ready?
Couple weeks or months? Then I don’t buy other modules.
Op za 4 mrt. 2023 om 00:30 schreef Johan Bendz @.***>

Hi @Majebo https://github.com/Majebo, currently there is not. Working
on it.
—
Reply to this email directly, view it on GitHub
https://github.com/JohanBendz/com.tuya.zigbee/issues/253#issuecomment-1454261165,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A44MJROS4RNK2M6MIB5EP4DW2J5I5ANCNFSM6AAAAAATFM5AHY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Typo - ressource should be resource

ressource should be resource throughout the repo

Can you open a PR with the fix?


Move all of the implementation into one file

...so that people can just copy the one file without having to use pip.

[x] Incorporate files into __init__.py

[x] sro.py
[x] syllabics.py
[x] __version__.py

[x] Document how to "install" by copying the single file
[x] Figure out what will happen with __main__.py it got deleted!

Fixed as of a38d80874557d647af415e73055caf2f72e9ec24.


Can't get edit to work

can't get testing to work now that i am using render and classes.

› 3 snapshots failed.
Snapshot Summary
› 3 snapshots failed from 1 test suite. Inspect your code changes or run npm test -- -u to update them.
Test Suites: 1 failed, 1 total
Tests:       3 failed, 3 total
Snapshots:   3 failed, 3 total
Time:        0.348 s, estimated 3 s


MacOS has suddenly started failing

https://github.com/graphviz-perl/Graph/runs/1483639131 shows
Run shogo82148/actions-setup-perl@v1
  with:
    distribution: strawberry
    perl-version: 5
Warning: The strawberry distribution is not available on this platform. fallback to the default distribution.

This is a breaking change, previously specifying "strawberry" was a no-op on non-Windows.
Edited to add: Also, your CI has been failing since 2 days ago?

And now it fails with no distro specified on both Windows AND MacOS: https://github.com/graphviz-perl/Graph/runs/1483701921

I just published v1.9.0, but it is currently unavailable.
Because of the problem of my releasing flow https://github.com/shogo82148/actions-setup-perl/issues/493
Please wait a little. I'll notify you when v1.9.0 is available.

Thank you for waiting.
Uploading binaries has finished, and v1.9.0 is now available.
Please try it!

Thank you, I can confirm it's working again! Are you aware of @perl-actions btw? We have in mind to expand it to have more than just module-installation actions.

Yes, I do


New update on progress

Updating to show the latest info on progress, plus adding the link to the forum.

Normally I just edit the date of existing posts when there is an update (instead of creating a new post). I added your changes in this commit. Thank you 🙂

Thanks @frabrunelle.
How do you do that? I didn't find where to put the new date and assumed that the way to do it was to rename the file with the new date as I did.

It's OK that Git sees the renamed post as a new file. But it should also delete the post with the old name.


Review "Setup automation for dex via dex-operator" documentation

The documentation to set up automation for Dex via Dex operator may need to be reviewed and possibly extended.
Recently we received a few support cases when GS engineers encountered issues with SSO configuration when setting up a new installation. For example:

It is not always clear how to create a config for Dex operator using an existing one from a different installations
One step of the authentication setup requires admin approval and it is not always clear what to do in that case

More context: https://gigantic.slack.com/archives/C053JHJC99Q/p1692953495490229

I have looked at this but I think I'll need help from the expert. @ssyno can you see if anything needs to be updated in this doc? Maybe include a link to your existing ops recipes for dex if any of the content is the same, rather than duplicating it here


Volume control exceeds maximum call stack on audio player

Hello
I started to get "maximum call stack exceed" while playing audio in all browsers. It was actualy working but can't remember what caused that. It may jQuery upgrade or another else but i have identified problem.
Plugin couldn't unbind attached '.vol' events. I have changed code as below. $(doument) replaced by volumSlider . I am using it jQuery 1.9.1 .
        volumeSlider
			.bind('mouseover', function () {
			    mouseIsOver = true;
			})
			.bind('mousedown', function (e) {
			    handleVolumeMove(e);
			    volumeSlider //it was $(document)
					.bind('mousemove.vol', function (e) {
					    handleVolumeMove(e);
					})
					.bind('mouseup.vol', function () {
					    mouseIsDown = false;
					    volumeSlider.unbind('.vol');//it was $(document)

					    if (!mouseIsOver && mode == 'vertical') {
					        volumeSlider.hide();
					    }
					});
			    mouseIsDown = true;

			    return false;
			});

It is clear that $(document).unbind('.vol') line not able to unbind .

@YakupIpek Closing old issues. If you'd like to reopen this, let us know. Thanks!


Mutually recursive components break type checking

When you create two components that render each other, Volar's type checker will "give up".
Example
Create two components: mutual-recursive-a.vue and mutual-recursive-b.vue.
mutual-recursive-a.vue:
<template>

{{ title }}

  <button @click="showB = true">Show B</button>
  <MutualRecursiveB v-if="showB" />
</template>

mutual-recursive-b.vue:
<template>

{{ title }}

  <MutualRecursiveA />
</template>

Expected behavior
These components can successfully be compiled. And they work fine in the browser. Thus, I expected Volar also to have no problems with such components.
Actual behavior
On Volar 0.28.10, you get the following:

Is there any way to fix this on my side (e.g. by performing the imports in another way)?

This is TS limitation, you need to avoid it on the implementation level.
In your case you can use single component and recursive itself.
<template>

{{ title }}

	<button @click="showB = true">Show B</button>
	<template v-if="showB">

{{ titleB }}

		<mutual-recursive-a></mutual-recursive-a>
	</template>
</template>

Duplicate of #644


script in JOERN is not working properly .

when i am writing script in JOERN  library to parse the files and saving its CPG's in graphml format in the folder named as that of thiers  but getting error.?
what i must change here?

You put a shell script inside a scala function, so, that can't work. You would have to execute that script directly on the shell, that is, put it in a file called script.sh and run that with sh script.sc. The @main def exec() = { and the last } would need to be removed.

@fabsx00  can you suggest me , which format is best for generating embeddings like graphson(json) or graphml(xml) ?

@anushka192001 Please be mindful of Joern contributors' time. You have cross-posted this exact question on 15 other repositories

While this might be urgent to you in your own mind, actual OSS contributors here don't share the same urgency - they don't function like this or owe you anything - and are volunteering their time. There are humans on the other side of what you write. I cannot speak for individual projects you X-posted on, but I request you to read documentation and code of Joern - see how its developed and structured. If there is something missing, ask amicably on discord on public channels only to see if there is a feature which is not documented.  If you feel the feature is not existing, be willing to work through code and suggest early work, patches etc.


net/http: ErrContentLength not returned for too-long HTTP/2 body writes

// ErrContentLength is returned by ResponseWriter.Write calls
// when a Handler set a Content-Length response header with a
// declared size and then attempted to write more bytes than
// declared.
ErrContentLength = errors.New("http: wrote more than the declared Content-Length")

Writing too many bytes to an HTTP/2 body doesn't return ErrContentLength, however, for two reasons:

The HTTP/2 ResponseWriter returns a different error when detecting a too-long body.
The accounting for how many bytes have been written can fail to detect a too-long body until after the ResponseWriter.Write call has returned.

The existing test TestIdentityResponse fails when run in HTTP/2 mode.

Hey @neild, can I give it a try? :relaxed:

Hey @neild, can I give it a try? ☺

Please do! I'm happy to review a CL.


Fix/Ecto high number of batches

Fix Dataloader.Ecto.run_batches/1 function for high number of batches
As stated by the Elixir doc, Maps’ keys do not follow any ordering. In practice it is especially true starting at 32 elements.
Therefore the batches' results were not in the same order as the batches' keys which resulted in an error when fetching a batch result.

Great catch!


Add body field in Rest.request

To see the discussion that precedes the pull request: #8
Happy to change anything you think should be updated!

Hi, sure no problem!
I pushed a commit splitting up the tests for request body from the tests for the regular post.
Could you please take a look?

Hi @jihchi sorry the delay again! I fixed the comments you made, splifiying them! thanks for the review!

@vloth Thanks very much for contribution!
The changes has been released in v0.6.0


New branch

Adding LinkedIn questions

Hi @rishabh115, have fixed the formatting issues. Let me know if any more changes are needed.

Hi @rishabh115, have fixed the formatting issues. Let me know if any more changes are needed.

There is one more issue in the last line. Please fix it and then it is ready to merge.

Hi @rishabh115, have fixed the formatting issues. Let me know if any more changes are needed.

There is one more issue in the last line. Please fix it and then it is ready to merge.

Fixed


Start Pandas notebook, add sample data, and .gitignore

closing this and will re-push from a different branch


Run background-sync tests in a SW environment

R: @jeffposnick
This PR is the first step in moving our unit tests from running in node to running in a real service worker environment. In this PR the workbox-background-sync unit tests previously in the /tests/workbox-background-sync/node directory and been moved to the /tests/workbox-background-sync/sw directory and all node-based imports have been removed.
To make this work, I've added a few templates and routes, so that you can start the test server (gulp test-server) and navigate to the following URL and see the tests run:
http://localhost:3004/test/workbox-background-sync/sw/
When navigating to this URL, three main things are happening:

The templates/test-sw.html.njk template is rendered...
which registers a service worker file at templates/test-sw-runner.js.njk...
and that imports the test bundle via the routes/sw-bundle.js endpoint

The tests are currently being run via webdriver in the integration tests. In the future we might want to consider separating this out into its own gulp test-unit tasks, but while this is still a work in progress, running them via the integration tests tasks seems fine.
Note: this setup required very few changes to the test files themselves, so hopefully it's a rather painless process to switch them all over.

Coverage decreased (-1.6%) to 81.081% when pulling bf3d4031abb23381d00fdc170db29d64098dca06 on sw-testing-changes into b56962a8eef05ec49f60ab233b267a46f4ce20fa on master.