Add check EyesPose.IsSupported to only call APIs when supported

Overview
Even if the API is present, it's possible eye tracking isn't actually supported on the current device. This ensures we don't actually call the APIs unless they're both present and supported.
@jwittner it'd be good if you can test this in your scenario! I wasn't able to repro your stack exactly, but did see other exceptions in your same scenario that this fixes.
Changes

Fixes: #7482

/azp run

Alright, tried to build the packages, but I only have VS 2019 installed. Attempted to work around by updating things, but hitting the below error. I'm installing VS 2017 now and will try again tomorrow.
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0\8.21\Microsoft.Windows.UI.Xaml.Common.targets(86,90): error MSB4057: The target "_CalculateXbfSupport" does not exist in the project.  C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0\8.21\Microsoft.Windows.UI.Xaml.Common.targets [C:\Users\jowitt\source\MixedRealityToolkit-Unity\MSBuild\Projects\Microsoft.MixedReality.Toolkit.Async.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0\8.21\Microsoft.Windows.UI.Xaml.Common.targets(86,90): error MSB4057: The target "_CalculateXbfSupport" does not exist in the project.  C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0\8.21\Microsoft.Windows.UI.Xaml.Common.targets [C:\Users\jowitt\source\MixedRealityToolkit-Unity\MSBuild\Projects\Unity.TextMeshPro.csproj]

Here are the changes I tried to get VS 2019 working, made it past several missing file errors, but still foiled.

Ok, the VS2017 install was pretty quick so I tried it again. Got much farther, but now I'm failing to retarget assets with:
Failed to retarget assets.
UnityEngine.DebugLogHandler:Internal_Log(LogType, String, Object)
UnityEngine.DebugLogHandler:LogFormat(LogType, Object, String, Object[])
UnityEngine.Logger:Log(LogType, Object)
UnityEngine.Debug:LogError(Object)
Microsoft.MixedReality.Toolkit.MSBuild.AssetScriptReferenceRetargeter:RetargetAssets() (at Assets\MixedRealityToolkit.Tools\MSBuild\Scripts\AssetScriptReferenceRetargeter.cs:78)

(Filename: Assets/MixedRealityToolkit.Tools/MSBuild/Scripts/AssetScriptReferenceRetargeter.cs Line: 78)

FileNotFoundException: C:\Users\jowitt\source\MixedRealityToolkit-Unity\MSBuild\Publish\InEditor\WindowsStandalone32\Microsoft.MixedReality.Toolkit.Editor.ClassExtensions.dll does not exist
  at System.IO.File.Copy (System.String sourceFileName, System.String destFileName, System.Boolean overwrite) [0x000b6] in <e1319b7195c343e79b385cd3aa43f5dc>:0
  at Microsoft.MixedReality.Toolkit.MSBuild.AssetScriptReferenceRetargeter.ProcessCompiledDLLs (System.String temporaryDirectoryName, System.String outputDirectory, System.Collections.Generic.Dictionary`2[TKey,TValue] asmDefMappings) [0x00081] in C:\Users\jowitt\source\MixedRealityToolkit-Unity\Assets\MixedRealityToolkit.Tools\MSBuild\Scripts\AssetScriptReferenceRetargeter.cs:342
  at Microsoft.MixedReality.Toolkit.MSBuild.AssetScriptReferenceRetargeter.RunRetargetToDLL () [0x0003b] in C:\Users\jowitt\source\MixedRealityToolkit-Unity\Assets\MixedRealityToolkit.Tools\MSBuild\Scripts\AssetScriptReferenceRetargeter.cs:95
  at Microsoft.MixedReality.Toolkit.MSBuild.AssetScriptReferenceRetargeter.RetargetAssets () [0x0000d] in C:\Users\jowitt\source\MixedRealityToolkit-Unity\Assets\MixedRealityToolkit.Tools\MSBuild\Scripts\AssetScriptReferenceRetargeter.cs:73
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
Microsoft.MixedReality.Toolkit.MSBuild.AssetScriptReferenceRetargeter:RetargetAssets() (at Assets\MixedRealityToolkit.Tools\MSBuild\Scripts\AssetScriptReferenceRetargeter.cs:79)

Any idea why that file wouldn't exist?
Here's the full log for this failed stage.

Alright, nuget packages are building for me off of release/2.2.0, which is the package our project is leveraging. Tomorrow I'll pull this change into that and give it a shot. =)

/azp run

Cherry picked the commit into release/2.2.1, built the nuget packages, and updated our project and the issue is indeed fixed! Thanks so much @keveleigh !!!


Add a configuration with external tf-js

My issue is i would like to use this code as an external package with my other tfjs models.
Currently you can only have one tensorflowjs script instance any other that gets loaded after the first one breaks.

Hmm i didnt try that yet, what would be required to make that work? Can you not bundle this package together with you own?
In case it helps, tf core is also exported via facepi.tf

I'm going to close it, managed to do it by changing the types to any and removing the tf reference


Android studio doesn't recognize my real iOS device(iOS 17)

Describe the bug
I want to run my app on a real ios device, but Android studio does not show my real device. I can run the app on my real device in xcode, and I also filled in the TEAM_ID, but it cannot show my device in Android studio
Affected platforms
Select one of the platforms below:

iOS

Versions

Kotlin version*: 1.9.10
Compose Multiplatform version*: 1.5.1
OS version(s)* (required for Desktop and iOS issues): 14.0 (23A344)
OS architecture (x86 or arm64): x86
JDK (for desktop issues): 17

To Reproduce
Select the target device in Android studio
Screenshots

Could you please check that you have the latest (Version 0.6.1(222)-14) KMM plugin installed? https://plugins.jetbrains.com/plugin/14936-kotlin-multiplatform-mobile

Yes, I have installed it and it is version 0.6.1(223)-18.  I am not sure whether it has anything to do with Apple developer account, I see that redeme mentioned that you need to register the device in xcode.  But I can run the program to me from Xcode

I'm having the same issue. My iPhone 15 Pro Max is not listed as an execution target even though it is working in Xcode. I have an iPhone X that does show up as an execution target, so I wonder if the problem is specifically with the iPhone 15. I have tried the latest Android Studio canary with the latest dev version of the KMM plugin, but still nothing. I also tried deleting the .idea directory.

I'm having the same issue. My iPhone 15 Pro Max is not listed as an execution target even though it is working in Xcode. I have an iPhone X that does show up as an execution target, so I wonder if the problem is specifically with the iPhone 15. I have tried the latest Android Studio canary with the latest dev version of the KMM plugin, but still nothing. I also tried deleting the .idea directory.

Probably not, because I have an iPhone 12 that is also unrecognizable, which may not have much to do with the phone

What Android Studio version are you using ?

Can you also please try to install and execute kdoctor command:
brew install kdoctor
kdoctor
And check is it some problems with your environment

I am currently using Android Studio version is Android Studio Giraffe | 2022.3.1 Patch 2. After I checked the environment with kdoctor, everything was normal:
[✓] Operation System
[✓] Java
[✓] Android Studio
[✓] Xcode
[✓] Cocoapods

Maybe you can give me some more detailed steps to run a real device and I'll check if any of them are wrong.

Thanks!
I found what there are a little scroll offset if AndroidStudio device menu:

So, I just scrolled a little bit to the top.
Can you please check the same?

I checked.  I can't scroll up any more.  Another thing that comes to mind, is it related to ios 17?

I seem to have found the cause: devices running iOS 17 are not recognized.
I downgraded my other iPhone 12 system to iOS 16.6.1, and then my Android Studio was able to recognize my iPhone 12.

According to another friend's(@brewin ) description, his iPhone 15 pro max was also not recognized, Apparently, the iPhone 15 Pro Max runs on the latest iOS 17.

So I feel it is not compatible with iOS 17 and hope to fix this in the next KMM plugin.(@dima-avdeev-jb )

My iPhone X running iOS 16.7 is recognized in Android Studio 2022.3.1 Patch 2, but my 15 Pro Max running iOS 17.0.2 is not. Both work in Xcode 15. I noticed that "Connect via network" is enabled by default in Xcode for the 15 Pro Max and can't be disabled. I don't know if that has anything to do with it, but it is a difference.

Same problem for me too, hope it gets resolved soon

Made Issue on YouTrack: https://youtrack.jetbrains.com/issue/KT-62267/Android-Studio-KMM-plugin-cant-find-real-iOS-17-device

does anyone know when this bug will be fixed?
It's been reported for more than two months now

does anyone know when this bug will be fixed?
It's been reported for more than two months now

It seems to be working again. I am on Android Giraffe.
Did you update the kmm plugin?

does anyone know when this bug will be fixed?
It's been reported for more than two months now

It seems to be working again. I am on Android Giraffe. Did you update the kmm plugin?

I have updated both Android Giraffe and kmm plugin,
but I still don't see the physical devices with ios 17, to run the project on the physical device

I have updated both Android Giraffe and kmm plugin,
but I still don't see the physical devices with ios 17, to run the project on the physical device

Do you see it from Xcode?

I have updated both Android Giraffe and kmm plugin,
but I still don't see the physical devices with ios 17, to run the project on the physical device

Do you see it from Xcode?

yes from xcode I can see it without problems

Do you see
yes from xcode I can see it without problems

Humm not sure what could be it. Try restarting the AS,  clean, create a new iosApp configuration in Edit Configurations that sort of stuff.

Made Issue on YouTrack: https://youtrack.jetbrains.com/issue/KT-62267/Android-Studio-KMM-plugin-cant-find-real-iOS-17-device

According to the issue tracker on YouTrack, the issue is already being fixed and will be released soon
@pablichjenkov @joemockdao

According to the issue tracker on YouTrack, the issue is already being fixed and will be released soon

Oh great 😃 I didn't noticed it because I my device is in iOS 16 yet 🤷🏻♂

Made Issue on YouTrack: https://youtrack.jetbrains.com/issue/KT-62267/Android-Studio-KMM-plugin-cant-find-real-iOS-17-device

According to the issue tracker on YouTrack, the issue is already being fixed and will be released soon
@pablichjenkov @joemockdao

Running into same issue. Hope https://youtrack.jetbrains.com/issue/KT-62267/Android-Studio-KMM-plugin-cant-find-real-iOS-17-device will be released soon

Running into this issue after update from RC to stable build in Android studio Hedgehog. I have iphone 11 with ios 16.5 and it is visible in xcode but not in Android Studio. When I downgraded KMM plugin to version 0.8.0(231)-16 it started working again.

This issue was already fixed with:

Android Studio Iguana | 2023.2.1 Canary 18
Kotlin Multiplatform Mobile plugin 0.8.1(232)-18

Android Studio Iguana | 2023.2.1 Canary 18
Kotlin Multiplatform Mobile plugin 0.8.1(232)-18
iPhone 8   iOS 16
This problem still exists。

@Caij
Initially problem was only with iOS 17
I think you have another one Issue. Can you please create new Issue for this?
And provide MacOS version and Xcode version.

I have a similar issue with Android Studio. It doesn't show any item in the Execution target list, and I can't run iosApp.
I've tried Release, Beta and Canary versions with the latest Kotlin multiplatform plugin. However, I can run from Fleet and Xcode!
I've tried new projects created via KMP and my previous projects, which have worked fine!
I'm using Xcode Version 15.2 (15C500b).
kdoctor
Environment diagnose (to see all details, use -v option):
[✓] Operation System
[✓] Java
[✓] Android Studio
[✓] Xcode
[✓] CocoaPods

Conclusion:
  ✓ Your operation system is ready for Kotlin Multiplatform Mobile Development!

Android Studio Jellyfish | 2023.3.1 Canary 7
Build #AI-233.13135.103.2331.11360849, built on January 26, 2024
Runtime version: 17.0.9+0-17.0.9b1087.9-11255266 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.3
GC: G1 Young Generation, G1 Old Generation
Memory: 8192M
Cores: 10
Metal Rendering is ON
Registry:
ide.balloon.shadow.size=0
debugger.new.tool.window.layout=true
search.everywhere.structure=true
search.everywhere.settings=true
ide.experimental.ui=true
editor.minimap.enabled=true
ide.images.show.chessboard=true
Non-Bundled Plugins:
dev.j-a.swift (<IP_ADDRESS>-233)
com.vecheslav.darculaSolidTheme (1.0.3)
wu.seal.tool.jsontokotlin (3.7.4)
idea.plugin.protoeditor (233.13135.65)
com.jetbrains.kmm (0.8.2(233)-8)
com.squareup.sqldelight (2.0.1)
com.github.copilot (<IP_ADDRESS>15)
com.mallowigi (94.1.0)
Kotlin Multiplatform version 0.8.2(233)-8

I confirm that this issue occurs when I reinstalled Android Studio (fully deleted it, then downloaded it again and placed it in /Applications/. Anyone worked around it ?

@bidadh @yuroyami
Do you have Apple VisionPro simulator installed?
If yes - then please follow this issue

@dima-avdeev-jb I think I don't have the VisionPro simulator installed. Android Studio Jellyfish Canary 4 used to detect my iPhone XS (iOS 17.3.1, macOS Ventura) normally after I installed Xcode 15.2. However, after I deleted Android Studio and replaced it with Canary 11 it's not longer detecting my physical device, just the simulators.

@dima-avdeev-jb I think I don't have the VisionPro simulator installed. Android Studio Jellyfish Canary 4 used to detect my iPhone XS (iOS 17.3.1, macOS Ventura) normally after I installed Xcode 15.2. However, after I deleted Android Studio and replaced it with Canary 11 it's not longer detecting my physical device, just the simulators.
EDIT: When I connect the iPhone with a USB wire, Android Studio detects it. But it doesn't work over wireless, although it used to work before when I had Xcode 14.2, Android Studio Hedgehog, and iOS 16.3.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Thanks! I found what there are a little scroll offset if AndroidStudio device menu:

So, I just scrolled a little bit to the top. Can you please check the same?

You can't even imagine my reaction when this advice worked. I can't believe it! It was such a simple solution.
Thank you!


Fix comic reader animation

Animation wasn’t really even complete, so not really a fix lol but the animation needs LOTS of tlc. I'm trying to mimic Panels animation
See ImageBasedReader.tsx -> AnimatedImageBasedReader

What do you mean by Panels animation ?

If you don't mind @aaronleopold, I like to go back and see old issues, to check if they are still a thing.

Yeah of course, I don't mind at all


Chore/lesq/update mv downloads version

Description

List of changes

Issue(s)
Fixes #
How to test

Go to https://deploy-preview-1967--oak-web-application.netlify.thenational.academy
Click on _______
You should see _______

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

:tada: This PR is included in version 1.265.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Deliver action keep in Waiting for all the screenshots to finish being processed forever

I run deliver action with the following options:
deliver(
submit_for_review: false,
skip_app_version_update: true,
force: true,
team_id: "TEAM_ID",
precheck_include_in_app_purchases: false,
overwrite_screenshots: true,
)
all store data updated but the screenshots keep waiting for processing forever.
Note: I use app_store_connect_api_key for authentication
fastlane env output:
🚫 fastlane environment 🚫
Stack

Key
Value

OS
12.3

Ruby
3.1.2

Bundler?
false

Git
git version 2.35.1

Installation Source
/usr/local/Cellar/fastlane/2.209.1/libexec/bin/fastlane

Host
macOS 12.3 (21E230)

Ruby Lib Dir
/usr/local/Cellar/ruby/3.1.2_1/lib

OpenSSL Version
OpenSSL 1.1.1q  5 Jul 2022

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
13.3

Swift Version
5.6

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Description of what the lane does"

  lane :upload do

    app_store_connect_api_key(
        key_id: "xx",
        issuer_id: "xx",
        key_filepath: "xx",
        duration: 1200, # optional (maximum 1200)
        in_house: false # optional but may be required if using match/sigh
    )

    deliver(
        submit_for_review: false,
        skip_app_version_update: true,
        force: true,
        team_id: "xx",
	    precheck_include_in_app_purchases: false,
	    overwrite_screenshots: true,
    )

    end
end

`./fastlane/Appfile`
app_identifier("") # The bundle identifier of your app
apple_id("") # Your Apple email address

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.209.1
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

error_highlight
0.3.0

did_you_mean
1.6.1

atomos
0.1.3

rexml
3.2.5

CFPropertyList
3.0.5

claide
1.1.0

colored2
3.1.2

nanaimo
0.3.0

xcodeproj
1.22.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.8.0

terminal-table
1.8.0

plist
3.6.0

public_suffix
5.0.0

addressable
2.8.1

multipart-post
2.0.0

word_wrap
1.0.0

optparse
0.1.1

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

artifactory
3.0.15

babosa
1.0.4

colored
1.2

highline
2.0.3

commander
4.6.0

excon
0.92.4

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.2.6

gh_inspector
1.1.3

json
2.6.1

mini_magick
4.11.0

naturally
2.2.1

rubyzip
2.3.2

security
0.1.3

xcpretty-travis-formatter
1.0.1

dotenv
2.8.1

bundler
2.3.11

simctl
1.6.8

jwt
2.4.1

uber
0.1.0

declarative
0.0.20

trailblazer-option
0.1.2

representable
3.2.0

retriable
3.1.2

mini_mime
1.1.2

memoist
0.16.2

multi_json
1.15.0

os
1.1.4

signet
0.17.0

googleauth
1.2.0

httpclient
2.8.3

webrick
1.7.0

google-apis-core
0.7.0

google-apis-playcustomapp_v1
0.10.0

google-apis-androidpublisher_v3
0.25.0

google-cloud-env
1.6.0

google-cloud-errors
1.2.0

google-cloud-core
1.6.0

google-apis-iamcredentials_v1
0.13.0

google-apis-storage_v1
0.17.0

rake
13.0.6

digest-crc
0.6.4

google-cloud-storage
1.38.0

emoji_regex
3.2.3

jmespath
1.6.1

aws-partitions
1.620.0

aws-eventstream
1.2.0

aws-sigv4
1.5.1

aws-sdk-core
3.132.0

aws-sdk-kms
1.58.0

aws-sdk-s3
1.114.0

set
1.0.2

forwardable
1.3.2

logger
1.5.0

pathname
0.2.0

shellwords
0.1.0

cgi
0.3.1

date
3.2.2

timeout
0.2.0

stringio
3.0.1

securerandom
0.1.1

uri
0.11.0

openssl
3.0.0

digest
3.1.0

io-nonblock
0.1.0

ipaddr
1.2.4

io-wait
0.2.1

zlib
2.1.1

resolv
0.2.1

time
0.2.0

open-uri
0.2.0

mutex_m
0.1.1

net-protocol
0.1.2

net-http
0.2.0

ostruct
0.5.2

english
0.7.1

erb
2.2.3

strscan
3.0.1

abbrev
0.1.0

io-console
0.5.11

tempfile
0.1.2

delegate
0.2.0

fileutils
1.6.0

tmpdir
0.1.2

base64
0.1.1

singleton
0.1.1

open3
0.1.1

nkf
0.1.1

prettyprint
0.1.1

pp
0.3.0

find
0.1.1

yaml
0.2.0

psych
4.0.3

generated on: 2022-09-03

It seems like you have not included the output of fastlane env To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

done

Same here

there is a part of my images uploaded  and appear on app store and other not appear with this message
"this file has been uploaded and is processing"

I have the same issue. My solution is to go to the portal, delete the greyed screenshots, keep the successfully uploaded screenshots and run fastlane with overwrite_screenshots set to false. Keep the process until all screenshots are uploaded.

We are having the same issue.

Fastlane continued for me after cancelling the images with "this file has been uploaded and is processing" and uploading them manually.

Having the same issue, started occurring ~4 days ago.  Manual upload of same images also works.

We are also facing the same issue
There are still incomplete screenshots - {"UPLOAD_COMPLETE"=>5, "COMPLETE"=>3}

Same issue.
[⠋] Waiting for all the screenshots to finish being processed... DEBUG [2022-09-06 01:34:51.31]: There are still incomplete screenshots - {"COMPLETE"=>2, "UPLOAD_COMPLETE"=>4}

Fastfile

    upload_to_app_store(
      force: true,
      overwrite_screenshots: true,
      skip_binary_upload: true,
    )

I am having the same issue.

facing the same issue

Same issue here, any workaround for the meantime?

Recently we are facing the exact same issue.

Facing the same issue

is is a reoccurring issue with apple i've noticed over at least the past 4 years.
my guess has always been apple is rolling in server changes to the fleet, and some get caught with the old code and can't resolve.  i recall it normally taking a couple days to a week for the issue to disappear on its own.

I am facing the same issue. Is there any workaround? 🙂

We're facing the same issue for quite some time already.
Is there some kind of a workaround?

Same issue here

Hi Team, Do you have any workaround or can you please let us know about any ETA?

Experiencing the same issue (as per my comment in: https://github.com/fastlane/fastlane/issues/20625)

Happening to me too. Would love a workaround or ETA for a fix...

We noticed our builds getting stuck on "Waiting for screenshots to finish uploading" September 1st. I suspect the same or similar as https://github.com/fastlane/fastlane/issues/20619#issuecomment-1238492501 and hope it is an issue on Apple's side that will resolve any day now.

Facing the same issue too
deliver(
    submit_for_review: false,
    automatic_release: false,
    force: true,
    skip_binary_upload: true,
    skip_metadata: false,
    skip_screenshots: false,
    overwrite_screenshots: true,
    precheck_include_in_app_purchases: false,
)

This does seem to be an Apple issue, when I logged into App Store Connect 10 hours later, some of the screenshoots were still showing a blank placeholder with the message "This file has been uploaded and is processing."
I can remove the placeholders and manually upload the missing screenshots directly in App Store Connect, and that doesn't seem to incur this processing delay. But after doing so, when I try to submit to app review, it fails with an error message saying "There are still screenshot uploads in progress."
Ugh.

for now we have just skipped uploading screenshots using fastlane and doing it manually which sucks, but couldn't find a different way

I tried again just now and it seems to have worked with same script !

It seems to be working for us as well! Oh Apple 🍏

Yes working
Thank you all

not working for me

hit and miss, must be still rolling out slowly.

noticed that i hadn't updated to fastlane 2.209.1 yet, retesting.

We were already using the 2.209.1 fastlane version, and we did not changed anything on our fastlane scripts. It started to work again today for us.
$ fastlane --version
fastlane installation at path:
/Users/fhperuchi/.rvm/gems/ruby-3.1.2/gems/fastlane-2.209.1/bin/fastlane
-----------------------------
[✔] 🚀
fastlane 2.209.1

@sonjz I think this is a problem with Apple -- I manually uploaded the build via xcode & when I try to update the pricing on AppStore Connect, it throws an error

@saggio89 i received the same but think it cleared up last night.
i was able to save it as Free and rerelease without issue.

@sonjz  same! I submitted an issue to Apple yesterday, looks like they fixed it since then. Happy coding!

I tried it again today and everything seems to be fine. I was finally able to realease the app using the same fastlane script as always. Looks like apple has solved the issue. 🙂

Is this happening again for anyone else?

@markmuniz

Is this happening again for anyone else?

No. Everything seems to be working fine. 👍

This is still happening for me...

This is still happening for me...

Worked after deleting all existing screenshots from App Store Connect.

Is this happening again for anyone else?

After some time when working fine, started appearing again today.

I've seen a couple random recurrences of this. It definitely seems like there's something flaky in whatever queue Apple's using to process these uploads? Not sure there's much Fastlane can do to work around that.
Our CI process for submitting builds is granular enough that we have a specific job just for uploading screenshots. The times we've experienced this issue in the last couple of weeks, retrying just that job has always succeeded, so ... at least the problem isn't as big or consistent as it was when this all started.

Just happened on our end again.

Same here, it seems to be stuck in a loop with the screenshots never finishing:
[⠹] Waiting for all the screenshots to finish being processed... DEBUG [2022-10-07 14:29:45.85]: There are still incomplete screenshots - {"COMPLETE"=>439, "FAILED"=>17, "UPLOAD_COMPLETE"=>36}
[⠸] Waiting for all the screenshots to finish being processed... DEBUG [2022-10-07 14:29:52.12]: There are still incomplete screenshots - {"COMPLETE"=>439, "FAILED"=>17, "UPLOAD_COMPLETE"=>36}
[⠹] Waiting for all the screenshots to finish being processed... DEBUG [2022-10-07 14:29:58.31]: There are still incomplete screenshots - {"COMPLETE"=>439, "FAILED"=>17, "UPLOAD_COMPLETE"=>36}

Still happening for me.  I beleive fastlane should offer a timeout option to not keep the process stuck.

Today has been such a day again. Our runners have been stuck the last 5h waiting for the processing to finish.

Still happening for me. I believe fastlane should offer a timeout option to not keep the process stuck.

just use a timeout from bash or your scripting language and wrap it.
bash has timeout and ruby has Timeout
check the error it throws and respond appropriately...

In regards to the timeout ⬆ I recommend doing this: https://support.circleci.com/hc/en-us/articles/4411204604059-Automatically-cancel-build-after-set-amount-of-time
This is a CircleCI specific doc, but this should be doable elsewhere.

to each their own, but if i  already knew my timeout time, i would rather wrap the process in a timeout vs creating another job to poll it and send the kill signal.

Its still happening :(

Apple seems to have trouble in regard to the screenshot processing lately.
What we did is separate the deliver job for screenshots from the submission one. This helped tremendously as we can just retry the screenshot upload as often as we need to.

1 Question for those who faced this error.
If I am stuck for 2 hours in this step, Is it better to keep the process running, or restart the process?
I mean was the issue fixed for anyone just by restarting the fastlane process for the same app? Or we should just keep waiting?

1 Question for those who faced this error.
If I am stuck for 2 hours in this step, Is it better to keep the process running, or restart the process?
I mean was the issue fixed for anyone just by restarting the fastlane process for the same app? Or we should just keep waiting?

Waiting never worked for us. When you go to ASC you can see that the resources are just stuck in the processing loop forever.
The only solution for us was either manually uploading the screenshots with ASC's media manager or restarting the job.

I experienced the same problem today.
Relaunching the same lane without changing anything worked out for me.

No, also happened to us recently.

Has anyone a workaround for this issue?
Here is my routine for uploading screenshots which works but is still painful:
I always upload all screenshots (overwrite_screenshots: true).
Most of the time this will result in an endless loop like this:
[⠇] Waiting for all the screenshots to finish being processed... DEBUG [2023-05-02 16:35:00.45]: There are still incomplete screenshots - {"COMPLETE"=>538, "UPLOAD_COMPLETE"=>6, "FAILED"=>15}
[⠇] Waiting for all the screenshots to finish being processed... DEBUG [2023-05-02 16:35:00.45]: There are still incomplete screenshots - {"COMPLETE"=>538, "UPLOAD_COMPLETE"=>6, "FAILED"=>15}
[⠇] Waiting for all the screenshots to finish being processed... DEBUG [2023-05-02 16:35:00.45]: There are still incomplete screenshots - {"COMPLETE"=>538, "UPLOAD_COMPLETE"=>6, "FAILED"=>15}

The FAILED ones are not a problem, fastlane will re-upload them (in App Store connect those will have a red exclamation mark).
But the UPLOAD_COMPLETE ones are just stuck. So what I do is I go to App Store Connect, click through all the locales and find those (6 in this case) that are stuck (they will have a gray cloud symbol). I delete those. Then fastlane will continue and upload the missing and failed ones.
I tried using the new sync_screenshots, this worked the first time but this failed to do the update the second time...
It seems the screenshot upload needs a timeout for the images in state UPLOAD_COMPLETE...

All the logic to re-upload the screenshots seems to be there and a change as simple as this might do the trick of not waiting endlessly for the uploads to complete: https://github.com/fastlane/fastlane/commit/6168384629dd5e4a3935b0829c6ab9831b0d8c8a

@ralfebert Are you considering creating a PR for your fix?

hello, any news on this? i am facing same issue.

The best 'solution', I have is to go to the Media Manager, here's an url for my app: https://appstoreconnect.apple.com/apps/6453164382/appstore/ios/version/inflight/media-manager (simply swap the app id and it should work for you). Force refresh the site without a cache and go through each language and then you can find the unprocessed screenshots, remove them yourself and reupload the screenshots yourself. Fastlane is able to pick it up again:
[19:31:27]: Uploaded './fastlane/screenshots/cs/iPhone 8 Plus-06.png'... (3.93246 secs)
[✔] Waiting for all the screenshots to finish being processed...
[19:47:41]: ./fastlane/screenshots/sv/iPhone 14 Pro Max-02.png is missing on App Store Connect.

As you can see this took me more than 15 minutes, since I have 3 different sizes with 25 languages.
In the meantime - fastlane must know this - would it be possible to print out which exact screenshots (file path is suffice) are missing?

Lately this is happening so much again.

Stills happening, with this error at the end:
[13:40:22]: Uploaded './fastlane/screenshots/tr/2_APP_IPHONE_65_2.png'... (3.193515 secs)
[⠏] Waiting for all the screenshots to finish being processed... #<Thread:0x00007fb8702b19e0@/Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/deliver/lib/deliver/app_screenshot_iterator.rb:24 run> terminated with exception (report_on_exception is true):
/Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/models/app_store_version_localization.rb:103:in `rescue in get_app_screenshot_sets': it (Spaceship::AppStoreScreenshotError)
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/models/app_store_version_localization.rb:99:in `get_app_screenshot_sets'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/deliver/lib/deliver/app_screenshot_iterator.rb:25:in `block (3 levels) in each_app_screenshot_set'
/Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:188:in `rescue in with_asc_retry': undefined method `refresh!' for nil:NilClass (NoMethodError)
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:165:in `with_asc_retry'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:105:in `get'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/tunes/tunes.rb:493:in `get_app_screenshot_sets'
        from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/forwardable.rb:230:in `get_app_screenshot_sets'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/models/app_screenshot_set.rb:129:in `all'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/models/app_store_version_localization.rb:101:in `get_app_screenshot_sets'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/deliver/lib/deliver/app_screenshot_iterator.rb:25:in `block (3 levels) in each_app_screenshot_set'
/Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:244:in `handle_error': Authentication credentials are missing or invalid. - No valid credentials found in the request. (Spaceship::UnauthorizedAccessError)
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/client.rb:932:in `block in send_request'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/client.rb:687:in `with_retry'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/client.rb:928:in `send_request'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/client.rb:772:in `request'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:106:in `block in get'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:166:in `with_asc_retry'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/api_client.rb:105:in `get'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/tunes/tunes.rb:493:in `get_app_screenshot_sets'
        from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/forwardable.rb:230:in `get_app_screenshot_sets'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/models/app_screenshot_set.rb:129:in `all'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/spaceship/lib/spaceship/connect_api/models/app_store_version_localization.rb:101:in `get_app_screenshot_sets'
        from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.216.0/deliver/lib/deliver/app_screenshot_iterator.rb:25:in `block (3 levels) in each_app_screenshot_set'
+------------------------------------+
|            Lane Context            |
+------------------+-----------------+
| DEFAULT_PLATFORM | ios             |
| PLATFORM_NAME    | ios             |
| LANE_NAME        | ios deliver_ios |
+------------------+-----------------+
[15:07:54]: it

+---------------------------------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
| 💥   | deliver          | 5438        |
+------+------------------+-------------+

[15:07:54]: fastlane finished with errors

[!] An exception occurred for locale: it. Check the screenshot requirements here: https://help.apple.com/app-store-connect/en.lproj/static.html#devd274dd925

@vhartikainen @efraespada @assembleMHN @jjochen @vanniktech  @rocketnik @AlkanV
I've made a PR that addresses the issue with screenshots uploading https://github.com/fastlane/fastlane/pull/21693.
Could you check it with your setup and give the feedback? I would be grateful.
You can adjust your Gemfile in this way:
gem "fastlane", git: "https://github.com/mikhailmaslo/fastlane",  branch: "feature/introduce-timeout-for-screenshots-upload"

Then, you can use deliver to upload screenshots
deliver(
	api_key: api_key,
	skip_binary_upload: true,
	skip_screenshots: false,
	skip_metadata: true,
	skip_app_version_update: true,
	force: true,
	overwrite_screenshots: true,
	run_precheck_before_submit: false,
	screenshot_processing_timeout: 120
)

Note the screenshot_processing_timeout parameter, which defines the timeout for screenshots processing awaiting. In this example, it's set to 2 minutes. All unprocessed screenshots are deleted from App Store Connect and then re-uploaded again with the same timeout of screenshot_processing_timeout
In my experience, one re-uploading loop is sufficient to upload all screenshots. I've tested with ~200 screenshots.

I tested it, but in my first couple of tries, the upload didn't get stuck, but worked on the first try 🙄
Will try some more.

Thanks for your PR @mikhailmaslo ! 🙏
I'd also like to ask as many people as possible to test @mikhailmaslo 's PR, here: https://github.com/fastlane/fastlane/pull/21693
There are testing instructions at the bottom of the PR description to help you test this 😊  thank you everyone! ❤


Suggestions

Hi there! I took a look into some code parts and implemented a couple of things, that mostly aim to avoid extra heap allocations. Also, I checked some clippy warnings and added Default implementation for Requirement. Not sure if it is better to split these changes into separate PRs, but I'd be happy to do so if you'd prefer it this way :) Let me know what do you think!
Cheers

Wow, thank you so much!


add single include file, so compile explorer can include it

it allowes godbold.org to include the file over https
e.g.
I've created this file just by copying and pasting the content of files instead of the #include "" statements.
once you create this file, push it and open it in github press the y-key (the url will change) and then select the raw view, the raw view url now can be included in compile explorer,

Hi, thank you! I will add an automatic way of generating a single header, this is useful!


Is Cloud Functions support planned?

The README says that it isn't currently supported, but it's unclear on whether it will be in the future.

Thanks for your interest in this project.
At this time, we do not have a roadmap that we can share in this forum.  Meanwhile:

You can deploy functions based on this framework to Cloud Run

See this guide for details.

If you are using CloudEvent, you can use eventarc to setup triggers for Cloud Run

See this guide for details.

Please send us any feedback you might have, including whether we support your use-case well or we could do better.

Closing as there does not seem to be further questions.


[AVATAR + PSENCRYPTION] Avatar and Change Password Command with Encryption

Coverage decreased (-1.1%) to 78.057% when pulling 25b3183b73f5ce4cb1bb01d263b35bef6a3f82ab on charlesgoh:avatar2 into 8b258e004fc3d92cc2019ddcb0e1f6e06018e7ba on CS2103AUG2017-W09-B2:master.

Coverage decreased (-1.2%) to 77.982% when pulling 8ec8b1cf533dfbd3d486c441f28547c30f81d6f8 on charlesgoh:avatar2 into 8b258e004fc3d92cc2019ddcb0e1f6e06018e7ba on CS2103AUG2017-W09-B2:master.

Coverage decreased (-1.1%) to 78.057% when pulling 8ec8b1cf533dfbd3d486c441f28547c30f81d6f8 on charlesgoh:avatar2 into 8b258e004fc3d92cc2019ddcb0e1f6e06018e7ba on CS2103AUG2017-W09-B2:master.

Features will be frozen after merging this PR

Coverage decreased (-2.5%) to 74.159% when pulling fb100dd08aa581380d283f78df5b1561c0a5d68d on charlesgoh:avatar2 into dc28e8dc6cad5821d67694ebcc61ac2c63a42898 on CS2103AUG2017-W09-B2:master.

Coverage decreased (-2.1%) to 74.566% when pulling c2b3aa80944c466336eb16234eea83185953298f on charlesgoh:avatar2 into dc28e8dc6cad5821d67694ebcc61ac2c63a42898 on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.9%) to 75.762% when pulling 6f69bce7b4912c4cbc1b5f170f3f173de9c6ccbf on charlesgoh:avatar2 into dc28e8dc6cad5821d67694ebcc61ac2c63a42898 on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.9%) to 75.778% when pulling 75de7f38002dee6ae7eb6f08aaf42de8cc4ab1ab on charlesgoh:avatar2 into dc28e8dc6cad5821d67694ebcc61ac2c63a42898 on CS2103AUG2017-W09-B2:master.


Define the scope of release 0.9.0

Background Information
Create a list of features that would be part of the next release in December.
Highlight which would be the highest priority.
Definition of Done
List of desired features/ updates available

@bms63 @thomas-neitmann @millerg23 FYI here's some early ones to add to the list that we'd appreciate consideration to be prioritised for next release from a Roche selfish perspective...

https://github.com/pharmaverse/admiral/issues/1338
https://github.com/pharmaverse/admiral/issues/989 (TRTEMFL) - i was speaking to Gordon and we were thinking maybe best for @bundfussr to pick this one up as we need to also create an admiralroche version of this later as we have a subtle company-specific addition to the rules here that wouldn't be applicable for admiral
https://github.com/pharmaverse/admiral/issues/1337 & https://github.com/pharmaverse/admiral/issues/1336 (@tamarasenior already assigned to)
https://github.com/pharmaverse/admiral/issues/1041
using {parttime} as a dependency for the datetime parsing if it's ready in time: https://github.com/pharmaverse/admiral/issues/1315
bring admiraltemplate in line with admiral latest conventions: https://github.com/pharmaverse/admiraltemplate/issues/37
all the pieces discussed with @cicdguy around using admiralci directly for the workflows and enabling multi-version docs so that anyone can view the latest site from devel anytime without all the links breaking

Creating another demo video for the youtube channel should be added
Merger Vignette #734
Bring boards together from admiral.test, admiraci, admiraldev and admiral core

#1235 Address 2 issues created around library(pkg_name) and pkg_name::function()

and https://github.com/pharmaverse/admiral/issues/1295 on similar note

Note from our meeting:
general theme: development focus
some issues are needed for admiralRoche
issues needed for ADLB
admiral dev code coverage boost up to 80%
admiral.dev
PK - potentially a separate extension package
push on adoption side - event/hackathon across industry
additional videos: admiral intro, how to build additional datasets

Have a discussion wrt translating documentation to other languages. If this is something we eventually want done, then attempt to translate one portion of the documentation (ReadMe?) from English to another language and figure out how that and subsequent translations can be managed.

Have a discussion wrt translating documentation to other languages. If this is something we eventually want done, then attempt to translate one portion of the documentation (ReadMe?) from English to another language and figure out how that and subsequent translations can be managed.

Does Google Translate help here? One can easily embed translation features into the pkgdown docs.

Have a discussion wrt translating documentation to other languages. If this is something we eventually want done, then attempt to translate one portion of the documentation (ReadMe?) from English to another language and figure out how that and subsequent translations can be managed.

Maybe one more for down the line? I'd personally still say we have plenty of common template/function gaps I'd prefer us cover above this like hy's law, questionnaires, what to do with crossover/periods, etc.

I tried to translate the admiral page to German with google translate. Most of the text is readable but I would prefer reading the original version. (Some parts are funny but not helpful, e.g., google tries to translate the argument names on the function documentation pages.)
I agree with @rossfarrugia that there are more important topics. I think the main question is if we have resources to work on them.

I think the main question is if we have resources to work on them.

Still working on new resources... trying to bring 2.5 more devs our way over next month or 2 🤞

As for resources, there are apparently 5 new hires out of SSF that are keen to contribute to our next gen tools. I'd like to get them involved with writing unit tests for {admiraldev} first. Once they get the hang of our process I'm sure they'd be eager to contribute to issues within {admiral}. I'll keep ypu posted on updates.


Lines don't update when new fields mapped via mapping-details and expression

Currently the line machine is controlled by the document-definition component.  Since additional mapped fields can be added by the search box in the mapped details section and by the '@' insert node dropdown we must support the ability to trigger the mapping redraw event from outside of document.
Good chance to clean up the line machine a little.  Caught this is the demo prep.

Yeah that sounds bad. The mapping change event must be centralized and line machine should just subscribe it.


Introduce SingleColumnTableType as DataType of SelectSymbol.

This is is a preparation step to be able to support subselects
as value expressions in IN() and ANY().

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@32c65e9). Click here to learn what that means.
The diff coverage is 71.76%.

@@            Coverage Diff            @@
##             master    #6086   +/-   ##
=========================================
  Coverage          ?   83.09%
  Complexity        ?    12472
=========================================
  Files             ?     1439
  Lines             ?    47153
  Branches          ?     5808
=========================================
  Hits              ?    39184
  Misses            ?     5265
  Partials          ?     2704

Impacted Files
Coverage Δ
Complexity Δ

core/src/main/java/io/crate/types/ArrayType.java
86.15% <ø> (ø)
26 <0> (?)

core/src/main/java/io/crate/types/SetType.java
64.4% <0%> (ø)
21 <1> (?)

...ecutor/transport/SingleRowSingleValueConsumer.java
83.33% <100%> (ø)
7 <6> (?)

.../crate/analyze/expressions/ExpressionAnalyzer.java
91.68% <100%> (ø)
27 <0> (?)

...o/crate/operation/scalar/ScalarFunctionModule.java
100% <100%> (ø)
6 <0> (?)

...ain/java/io/crate/analyze/symbol/SelectSymbol.java
80% <100%> (ø)
7 <0> (?)

core/src/main/java/io/crate/types/DataTypes.java
94.11% <100%> (ø)
28 <4> (?)

...io/crate/executor/transport/TransportExecutor.java
97.24% <100%> (ø)
6 <0> (?)

...e/src/main/java/io/crate/types/CollectionType.java
71.42% <50%> (ø)
6 <4> (?)

...ain/java/io/crate/types/SingleColumnTableType.java
64.1% <64.1%> (ø)
14 <14> (?)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c65e9...b6312ac. Read the comment docs.

@dobe @mibe I've addressed your comments in the following commits:
937e3e1 fixup! move note to inner method
c59d839 fixup! cosmetic cleanup in equals
995c19c fixup! revert back to Streamer empty constructor
a151b98 fixup! correct comment
7b34d33 fixup! correct doc string
a2643fc fixup! explain mutable list comment
77434f6 fixup! rename SingleColumnConsumer to FirstColumnConsumer
55d65e2 fixup! add note about swallowed exception
acd241d fixup! rename resolver
8c2b660 fixup! narrow type check in single value function
ce0cc01 fixup! remove createInfo on AnyEqOperator
bfaa0e9 fixup! override normalizeSymbol, throw UnsupportedOperationException instead of UnsupportedFeatureException
a8b525e fixup! adjust javadoc
2524658 fixup! Handle null values correctly / decouple streamer implementation
ba2d5ec fixup! add TableType serialization test
e4ba476 fixup! add test for SingleValueFunction


Troubleshoot server crash

This results in a 502 error and takes a few minutes to fix itself / restart.
The last time this happened was sometime around 8:50PM PST on August 9, 2024.

Happened again at 3:37 PST on September 23, 2024..

Perhaps related to #759.

Maybe this will be fixed with #830

Still happens regularly.


Allow not providing values to selected configurable variables through CLI and add support to union types that has null as a member type

Purpose

A bug in the CLI does not allow users to leave out values for configurable variables that have an unsupported type (by not providing values) and caused an error. This PR fixes that issue.
Additionally, the CLI does not support accepting values for configurable variables with a union type that has null as a member type (ex: int?). This PR adds that support.

Fixes #42859
Approach
Bug fix
When considering unsupported configurable values in the CLI, there could be two cases:
Case 1
A type that is not supported through the CLI is used as a configurable variable but the value is not provided through the CLI. This should not be a problem and the CLI should allow leaving the value for that out as long as a default values is provided through the code.
Case 2
A type that is not supported through the CLI is used as a configurable variable but the value for that is provided through the CLI. This should cause and error stopping the program.
Checking whether the variable value is null before executing the checks regarding the type can produce the expected outcome.
Improvement
The Ballerina spec mentions the following regarding the supported types for configurable values.

Configurable values can be supplied with the built-in command-line option -C,
-Ckey=value
Key syntax:
key:= [[org .] module .] variable
Define S as:
type S boolean | int | float | decimal | string | xml
In the first phase, only the configurable variables with type S? are supported. We can support anydata[], map<anydata> and table<map<anydata>> later as needed.

Therefore types such as int? should be supported through the CLI. This can be achieved by accepting the () type as a valid member type within union types.
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Let's shorten the PR title as well. We can elaborate on it inside the description and approach.


Fixed makefile parsing issue that failed to stop at EOF

Latest change to the Makefile included "DEVELOP_DIRECTORY" which is an expression the parser searches for. In doing so, it tried to parse the string from this point and failed to account for the null terminator, and hence failed to stop at the end of the string.

Thanks!


[Enhancment] Add MorselsCount and TabletCount to profile of scan operator

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Problem Summary(Required) ：

Add MorselsCount and TabletCount to profile of scan operator.

@Mergifyio backport branch-2.3

if SharedScan in profile is true, TabletCount will be dop*real_tablets_count.

Why the TabletCount couldn't be equal to the  real_tablets_count?

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

if SharedScan in profile is true, TabletCount will be dop*real_tablets_count.

Why the TabletCount couldn't be equal to the real_tablets_count always?

Fixed it.

run starrocks_be_unittest

run all


why block gas limit in privatenet,but appear normal in development mode

and, how can I add peers in privatenet ?

blockchain.json:
"privatenet": {
"networkType": "custom",
"genesisBlock": "config/privatenet/genesis.json",
"rpcHost": "localhost",
"mineWhenNeeded": true,
"rpcPort": 8545,
"datadir": "yourdatadir",
"rpcCorsDomain": "http://localhost:8000",
"networkId": "123",
"nodes": [],
"account": {
"password": "config/privatenet/password"
}
}

and how can I deploy new contracts in web?
I hope there will be more information about config files..
Thanks!

hi,

why block gas limit in privatenet,but appear normal in development mode

I'm not sure what do you mean by here exactly,. what issues are you finding? note that the gas limit can be set in the genesis.json config of your private chain.

and, how can I add peers in privatenet ?

It's the nodes:[] option which is the equivalent of "--bootnodes value" in geth. however it's currently missing, will be added to 2.4.0

and how can I deploy new contracts in web?

Do you mean how to deploy more contracts on the web/client side? in that case you can do SimpleStorage.deploy().then(function(anotherSimpleStorage) {}); as described here

I hope there will be more information about config files..

The documentation is being built here please don't hesitate to contribute and/or point out what could be improved

Thank you for answering my questions!
I have solved the first issue by using ethereum-bootstrap to build a private net.
Thanks again!


fix(badge): alignment fixed

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 7 (28.57%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 83.653%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/badge/src/Component.tsx
2
7
28.57%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
9011

Relevant Lines:
9928

💛  - Coveralls


git-fast-export: 200213 → 210917

Motivation for this change
Currently broken:

Last successful build 2021-06-16 20:37:05 from https://hydra.nixos.org/build/148919251

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

Since #141812 got merged after this gets merged then mercurial_4 could be removed (has been broken for a while and this is the last user of mercurial_4)


Node.js tests failing

Happens at least on Travis CI. For example: https://travis-ci.org/flowhub/the-graph/builds/454191240
Because of this they are currently disabled in Grunt.

Now using node v10.12.0 (npm v6.4.1)
Running "exec:jest" (exec) task
>> FAIL __tests__/editing.js
>> Editor navigation
>> dragging on background
>> ✕ should pan graph view (59ms)
>>     mouse scrolling up
>> ✕ should zoom in (17ms)
>>     mouse scrolling down
>>       ✕ should zoom out (17ms)
>>     multitouch pinch
>>       ✕ should zoom in/out (13ms)
>>     hovering an node
>>       ○ skipped 1 test
>>     hovering an edge
>>       ○ skipped 1 test
>>     hovering exported port
>>       ○ skipped 1 test
>>     hovering node group
>>       ○ skipped 1 test
>>   Editor
>>     dragging on node
>> ✕ should move the node (15ms)
>>     dragging on exported port
>>       ○ skipped 1 test
>>     dragging from node port
>> ✕ should start making edge (14ms)
>>     dropping started edge on port
>>       ✕ should connect the edge (18ms)
>>     dropping started edge outside
>> ✕ should not connect the edge (18ms)
>>     clicking exported port
>>       ○ skipped 1 test
>>     clicking unselected node
>> ✕ should add node to selection (20ms)
>>     clicking selected node
>>       ✕ should remove node from selection (12ms)
>> clicking unselected edge
>>       ○ skipped 1 test
>>     clicking selected edge
>> ○ skipped 1 test
>>     selected nodes
>>       ○ skipped 1 test
>> when dragging the box
>>         ○ skipped 1 test
>>     node groups
>> ○ skipped 3 tests
>>       when dragging on label
>>         ○ skipped 1 test
>>       when dragging on bounding box
>> ○ skipped 1 test
>>     right-click node
>>       ○ skipped 1 test
>> right-click node port
>>       ○ skipped 1 test
>>     right-click edge
>> ○ skipped 1 test
>>     right-click exported port
>>       ○ skipped 1 test
>> right-click node group
>>       ○ skipped 1 test
>>     right-click background
>> ○ skipped 1 test
>>     long-press
>>       ○ skipped 1 test
>>   Editor menus
>> node menu
>>       ○ skipped 5 tests
>>       clicking port
>> ○ skipped 1 test
>>     node port menu
>>       ○ skipped 1 test
>> edge menu
>>       ○ skipped 2 tests
>>     exported port menu
>> ○ skipped 1 test
>>     node selection menu
>>       ○ skipped 2 tests
>> editor menu
>>       ○ skipped 1 test
>> ● Editor navigation › dragging on background › should pan graph view
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › dragging on background › should pan graph view
>>
>>     TypeError: Cannot read property 'state' of undefined
>>
>>       at Object.it (__tests__/editing.js:57:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › dragging on background › should pan graph view
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › mouse scrolling up › should zoom in
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › mouse scrolling up › should zoom in
>>
>>     TypeError: Cannot read property 'state' of undefined
>>
>>       at Object.it (__tests__/editing.js:70:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › mouse scrolling up › should zoom in
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › mouse scrolling down › should zoom out
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › mouse scrolling down › should zoom out
>>
>>     TypeError: Cannot read property 'state' of undefined
>>
>>       at Object.it (__tests__/editing.js:82:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › mouse scrolling down › should zoom out
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › multitouch pinch › should zoom in/out
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>> at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:47:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › multitouch pinch › should zoom in/out
>>
>>     TypeError: Cannot read property 'state' of undefined
>>
>>       at Object.it (__tests__/editing.js:93:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor navigation › multitouch pinch › should zoom in/out
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:51:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dragging on node › should move the node
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dragging on node › should move the node
>>
>>     TypeError: Cannot read property 'props' of undefined
>>
>>       at Object.it (__tests__/editing.js:152:22)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dragging on node › should move the node
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dragging from node port › should start making edge
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dragging from node port › should start making edge
>>
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>
>>       at Object.it (__tests__/editing.js:172:18)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dragging from node port › should start making edge
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dropping started edge on port › should connect the edge
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (no
>> de_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dropping started edge on port › should connect the edge
>>
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>
>>       at Object.it (__tests__/editing.js:185:29)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dropping started edge on port › should connect the edge
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dropping started edge outside › should not connect the edge
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dropping started edge outside › should not connect the edge
>>
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>
>>       at Object.it (__tests__/editing.js:206:7)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › dropping started edge outside › should not connect the edge
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › clicking unselected node › should add node to selection
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.notifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › clicking unselected node › should add node to selection
>>
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>
>>       at Object.it (__tests__/editing.js:225:20)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › clicking unselected node › should add node to selection
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › clicking selected node › should remove node from selection
>>
>>     TypeError: Cannot read property 'clearRect' of null
>>
>>       at Object.renderCanvas (the-graph/the-graph-app.js:554:9)
>>       at Object.componentDidUpdate (the-graph/the-graph-app.js:547:12)
>>       at Object.componentDidMount (the-graph/the-graph-app.js:485:12)
>>       at Object.chainedFunction [as componentDidMount] (node_modules/create-react-class/factory.js:665:11)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:262:25
>>       at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:73:12)
>>       at node_modules/react-dom/lib/ReactCompositeComponent.js:261:11
>>       at CallbackQueue.n
>> otifyAll (node_modules/react-dom/lib/CallbackQueue.js:74:22)
>>       at ReactReconcileTransaction.close (node_modules/react-dom/lib/ReactReconcileTransaction.js:78:26)
>>       at ReactReconcileTransaction.closeAll (node_modules/react-dom/lib/Transaction.js:207:25)
>>       at ReactReconcileTransaction.perform (node_modules/react-dom/lib/Transaction.js:154:16)
>>       at batchedMountComponentIntoNode (node_modules/react-dom/lib/ReactMount.js:124:15)
>>       at ReactDefaultBatchingStrategyTransaction.perform (node_modules/react-dom/lib/Transaction.js:141:20)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:60:26)
>>       at Object.batchedUpdates (node_modules/react-dom/lib/ReactUpdates.js:95:27)
>>       at Object._renderNewRootComponent (node_modules/react-dom/lib/ReactMount.js:317:18)
>>       at Object._renderSubtreeIntoContainer (node_modules/react-dom/lib/ReactMount.js:399:32)
>>       at Object.render (node_modules/react-dom/lib/ReactMount.js:420:23)
>>       at Object.render (node_modules/enzyme-adapter-react-15/build/ReactFifteenAdapter.js:186:50)
>>       at new ReactWrapper (node_modules/enzyme/build/ReactWrapper.js:130:16)
>>       at mount (node_modules/enzyme/build/mount.js:21:10)
>>       at Object.beforeEach (__tests__/editing.js:133:15)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › clicking selected node › should remove node from selection
>>
>>     TypeError: Cannot read property 'getElementsByClassName' of undefined
>>
>>       at Object.it (__tests__/editing.js:234:20)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>>
>>   ● Editor › clicking selected node › should remove node from selection
>>
>>     TypeError: Cannot read property 'unmount' of undefined
>>
>>       at Object.afterEach (__tests__/editing.js:146:27)
>>           at new Promise (<anonymous>)
>>       at process._tickCallback (internal/process/next_tick.js:68:7)
>> PASS __tests__/basics.js
>>   Basics
>>     loading a simple graph
>>       ✓ should render 2 nodes (3ms)
>>       ✓ should render 1 edge
>>       ✓ should render 1 IIP (1ms)
>> Test Suites: 1 failed, 3 skipped, 1 passed, 2 of 5 total
>> Tests:       10 failed, 51 skipped, 3 passed, 64 total
>> Snapshots:   0 total
>> Time:        1.527s, estimated 3s
>> Ran all test suites.
>> Exited with code: 1.
>> Error executing child process: Error: Process exited with code 1.
Warning: Task "exec:jest" failed. Use --force to continue.

Now using node v8.12.0 (npm v6.4.1)
Running "exec:jest" (exec) task
>> PASS __tests__/editing.js
>> Editor navigation
>> dragging on background
>> ✓ should pan graph view (562ms)
>>     mouse scrolling up
>> ✓ should zoom in (22ms)
>>     mouse scrolling down
>>       ✓ should zoom out (19ms)
>>     multitouch pinch
>>       ✓ should zoom in/out (25ms)
>>     hovering an node
>>       ○ skipped 1 test
>>     hovering an edge
>>       ○ skipped 1 test
>>     hovering exported port
>> ○ skipped 1 test
>>     hovering node group
>>       ○ skipped 1 test
>>   Editor
>>     dragging on node
>> ✓ should move the node (19ms)
>>     dragging on exported port
>>       ○ skipped 1 test
>> dragging from node port
>> ✓ should start making edge (23ms)
>>     dropping started edge on port
>> ✓ should connect the edge (24ms)
>>     dropping started edge outside
>>       ✓ should not connect the edge (20ms)
>> clicking exported port
>>       ○ skipped 1 test
>>     clicking unselected node
>> ✓ should add node to selection (20ms)
>>     clicking selected node
>> ✓ should remove node from selection (13ms)
>>     clicking unselected edge
>>       ○ skipped 1 test
>> clicking selected edge
>>       ○ skipped 1 test
>>     selected nodes
>> ○ skipped 1 test
>>       when dragging the box
>>         ○ skipped 1 test
>> node groups
>>       ○ skipped 3 tests
>>       when dragging on label
>> ○ skipped 1 test
>>       when dragging on bounding box
>> ○ skipped 1 test
>>     right-click node
>>       ○ skipped 1 test
>> right-click node port
>>       ○ skipped 1 test
>>     right-click edge
>> ○ skipped 1 test
>>     right-click exported port
>>       ○ skipped 1 test
>> right-click node group
>>       ○ skipped 1 test
>>     right-click background
>> ○ skipped 1 test
>>     long-press
>>       ○ skipped 1 test
>> Editor menus
>>     node menu
>> ○ skipped 5 tests
>>       clicking port
>>         ○ skipped 1 test
>> node port menu
>>       ○ skipped 1 test
>>     edge menu
>> ○ skipped 2 tests
>>     exported port menu
>>       ○ skipped 1 test
>>     node selection menu
>> ○ skipped 2 tests
>>     editor menu
>> ○ skipped 1 test
>> PASS __tests__/basics.js
>>   Basics
>> loading a simple graph
>>       ✓ should render 2 nodes (3ms)
>>       ✓ should render 1 edge (1ms)
>>       ✓ should render 1 IIP
>> Test Suites: 3 skipped, 2 passed, 2 of 5 total
>> Tests:       51 skipped, 13 passed, 64 total
>> Snapshots:   0 total
>> Time:        2.174s
>> Ran all test suites.

Done.

As you can see, passes on Node 8 LTS, but fails on Node 10

Thats great info. But that failure is actually separate from what happens on Travis, which is from grunt mochaTest (not part of grunt test/npm test since 5 minutes ago). Below is error copied from Travis:
Running "mochaTest:nodejs" (mochaTest) task
the-graph-render
with no options
1) should output PNG file
requesting JPEG
2) should output JPEG file
requesting SVG
- should output SVG file
0 passing (4s)
1 pending
2 failing

the-graph-render
with no options
should output PNG file:
Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
at ChildProcess.emit (events.js:182:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
at ChildProcess.emit (events.js:182:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
Error: Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
  at ChildProcess.exithandler (child_process.js:289:12)
  at ChildProcess.EventEmitter.emit (domain.js:442:20)
  at maybeClose (internal/child_process.js:962:16)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

the-graph-render
requesting JPEG
should output JPEG file:
Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --format jpeg --quality 1 --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
at ChildProcess.emit (events.js:182:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (/home/travis/build/flowhub/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
at ChildProcess.emit (events.js:182:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
Error: Command failed: /home/travis/build/flowhub/the-graph/bin/the-graph-render /home/travis/build/flowhub/the-graph/spec/fixtures/photobooth.json --format jpeg --quality 1 --output /home/travis/build/flowhub/the-graph/spec/temp/rendered.tmp
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (node_modules/jsjob/src/runner.coffee:343:15)
at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
  at ChildProcess.exithandler (child_process.js:289:12)
  at ChildProcess.EventEmitter.emit (domain.js:442:20)
  at maybeClose (internal/child_process.js:962:16)
  at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

Yes - but if the main tests fail on node 10, then maybe whatever is breaking the mocha ones is also effecting these :)

I'll run those through both nodes to confirm

If you try to run the command outside of mocha directly, you get the same error:
/Users/carlsd01/Code/the-graph/bin/the-graph-render /Users/carlsd01/Code/the-graph/spec/fixtures/photobooth.json --format jpeg --quality 1 --output /Users/carlsd01/Code/the-graph/spec/temp/rendered.tmp
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (/Users/carlsd01/Code/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
Error: PhantomJS exited with 1 null 'Unknown PhantomJS error':...
at ChildProcess. (/Users/carlsd01/Code/the-graph/node_modules/jsjob/src/runner.coffee:343:15)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)

Should the coffeescript in jsjob not be transpiled ?

I've been doing some testing on jsjob - there's a lot of failing tests on it's master branch.
(I also had to include coffeescript as a dependancy, as it was looking for coffee-script - the package has been renamed).

This issue is not fixed yet. Is anyone working on this ? Request kind help.


B #4329: use default encoding if not found

Applies to 5.10 too

please ship it to 5.10.4

Hello @kvaps
We have also merged it into 5.10 branch, so it will be available in the future 5.10.4 release.


Added CaseIterable to Gradients enum

@kennyDang thank you for your PR. nice work 👍
SE-0194
Gradients.allCases


Add more convenient lite-weight interfaces

This PR introduces two simple and lite weight interfaces:

ping to trigger heartbeats without ticking,
status_ref to borrow the progress set instead of cloning.

LGTM.


https://chmln.github.io/flatpickr/ doesn't work in Internet Explorer

On website https://chmln.github.io/flatpickr/ doesn't work Flatpicker in Internet Explorer (tested on version 9, 10, 11).
In my projects works in IE correctly.

The demo is still using 2.2.2.
IE issues were resolved in 2.2.3 - see #414

Problem isn't in flatpickr, but in example script.
In file site.js with this line causes crash:
disable: [date => date.getDate() %6 === 0]

Hello,
Thanks for pointing this out.
I'll hook up a transpiler very soon.

Done.


Fix problems while using local installed packages

update CPM.cmake version too
This should fix this issue https://github.com/TheLartians/ModernCppStarter/issues/176

@TheLartians Would you like to review this MR?


What license is this released under?

I haven't found a LICENSE file, nor have I found any mention of licensing on https://phlexui.com/. I would like to use this component kit on an open source project of mine, but I need to know the license before hand. Thanks!

https://github.com/PhlexUI/phlex_ui/blob/main/LICENSE.txt
Just added the license but its MIT licensed.


.Net: Investigate how to register a template engine

One option is using service collection to store the template engine

Draft PR for the investigation is here: https://github.com/microsoft/semantic-kernel/pull/2666
Going to close this and it will get continued in a later sprint once we decide on the pattern we want to use.


Traslate YDB concepts

Changelog category

Documentation (changelog entry is not required)

also, "This branch has conflicts that must be resolved"


RC test: Gases Intro 1.0.2-rc.1

@KatieWoe , @arouinfar, gases-intro/1.0.2-rc.1 is ready for RC testing.
This release does not include PhET-iO or a11y.
Document issues in https://github.com/phetsims/gas-properties/issues (not in gases-intro) and link to this issue.
Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Check this LoL spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version
If there is a console available, check for errors and include them in the Problem Description.

Focus and Special Instructions
Complete testing of Gas Properties 1.0.1-rc.1 (https://github.com/phetsims/QA/issues/415) before starting this RC test.

Issues to Verify
There issues can be spot checked on a few platforms. There is no need for a full test matrix.

[x] revisit performance on Win10 + Chrome
[x] Fire/ice layering is inconsistent
[x] Minor performance improvements to container rendering

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is "status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

Simulation
iFrame
XHTML
Test Matrix (N/A)
Legends of Learning Harness

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

moving down to medium priority for now

1.0.2 was inadvertently published for patch phetsims/phet-core#64.  Over in #415, we decided that we'd live with that, and terminate this RC test.
Closing.


Add the completes edge from class impl to class decl [phab:D1077]

Created by salguarnieri at 2016-09-22 01:01:20:

salguarnieri wrote at 2016-09-22 01:13:54:

clang format

zarko accepted this revision at 2016-09-22 18:00:04

salguarnieri closed via commit c599734316adbf077e0f8c531643a52eb86398d8 at 2016-09-22 18:02:01


Always pass info to Field.get-result

This pull request tries to fix regression caused by #1044.
This needs still more testing and changes to strawberry-django package as well. See https://github.com/strawberry-graphql/strawberry-graphql-django/tree/wip/fix-strawberry-regression.

@patrick91 , do these changes make sense? I'd like to hear your feedback before I continue?

@patrick91 , do these changes make sense? I'd like to hear your feedback before I continue?

Will check this tonight!

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)