parallel execution of read/write operations (paper vs implementation)

In Algorithm 1 of FlashAttention: Fast and Memory-Efficient Exact Attention with IO-Awareness, the inner loop starts by loading from HBM in SRAM a tile from tensor O into Oi. It then do some ops and save Oi from SRAM into HBM tensor O. For each iteration of the outer loop, the inner loop do a full round and therefore there is a full read / write of O tensor.
If the outer loop (j) is executed serially, it should provide the correct result.
But when we execute in parallel the outer loop, it seems that we would have concurrent access to O for both reading and writing.
Therefore, if we strictly follow the algorithm 1 and "just" parallelize the outer loop, the output should not be correct.
In the triton implementation, they have switched inner and outer loop, therefore they don't need to load Oi, they start with a zeroed one, do all computation and save to HBM the final result. Therefore they don't have any concurrent access issue on this variable.
Can you please clarify the way the parallelization is implemented in CUDA? Is there something missing in the description above which may explain why algorithm 1 would work in parallel?

That's a great observation!
The CUDA code implements the algorithm as written in the paper, we do not parallelize the outer loop.
Instead, we parallelize over the batch and nheads dimension (each threadblock computes 1 head). This is sufficient if batch * nheads is large enough (around >= 80) so we have enough parallel work for each threadblock to do.
One could also swap the order of the inner and outer loop (as done in Triton).

Thank you it's very clear.

One could also swap the order of the inner and outer loops (as done in Triton).

Hi tridao, sorry for bothering you in a closed issue again. As Triton swaps the order of the loops,
ori:
for 1 ≤ 𝑗 ≤ 𝑇𝑐 do
    Load K𝑗, V𝑗 from HBM to on-chip SRAM.
    for 1 ≤𝑖 ≤ 𝑇𝑟 do
        Load Q𝑖, O𝑖 ,ℓ𝑖, 𝑚𝑖 from HBM to on-chip SRA

swapped:
for 1 ≤𝑖 ≤ 𝑇𝑟 do
    for 1 ≤ 𝑗 ≤ 𝑇𝑐 do
        Load K𝑗, V𝑗 from HBM to on-chip SRAM.
        Load Q𝑖, O𝑖 ,ℓ𝑖, 𝑚𝑖 from HBM to on-chip SRA

It seems that the loading of K/V increases to 𝑇𝑟 times for the Triton version?

Yes, but now one only needs to load Q once (instead of T_c times) and one can keep the output O on SRAM instead of having to repeatedly writing to / reading from HBM.
Overall the HBM reads/writes will be around the same, but one version might be faster / easier to implement.

Thanks for your reply~
so the Triton version exactly swaps
// executed in parallel outside over the batch and nheads dimensions
for 1 ≤ 𝑗 ≤ 𝑇𝑐 do   // executed serially
    Load K𝑗, V𝑗 from HBM to on-chip SRAM.
    for 1 ≤𝑖 ≤ 𝑇𝑟 do   // executed serially
        Load Q𝑖, O𝑖 ,ℓ𝑖, 𝑚𝑖 from HBM to on-chip SRA
        ...
        Write O𝑖 ,ℓ𝑖, 𝑚𝑖 to HBM

to
for 1 ≤𝑖 ≤ 𝑇𝑟 do  // executed in parallel
    Load Q𝑖 from HBM to on-chip SRA
    Initialize O𝑖 ,ℓ𝑖, 𝑚𝑖 to on-chip SRAM
    for 1 ≤ 𝑗 ≤ 𝑇𝑐 do  // executed serially
        Load K𝑗, V𝑗 from HBM to on-chip SRAM
        ...
    Write O𝑖 to HBM

Do I understand it correctly?

Yes, that's right.

For reference, the CUDA implementation now parallelizes over the seqlen_q dimension (in addition to the batch and nheads dimension), in both the forward and backward pass. It significantly speeds up the case of small batch size or small number of heads.
[There's a blogpost coming soon]

For reference, the CUDA implementation now parallelizes over the seqlen_q dimension (in addition to the batch and nheads dimension), in both the forward and backward pass. It significantly speeds up the case of small batch size or small number of heads. [There's a blogpost coming soon]

Thanks for the explanation. I was wondering if you applied loop unrolling along the seqlen_v dimension?

There are multiple thread blocks, each thread block takes care of attention wrt 1 block of Q (e.g. 128-256 rows of Q) for 1 head and 1 batch (this is the parallelism mentioned above). To do this, each thread block loops over blocks of K and V at a time (i.e. processing attention wrt 128-256 rows of K & V).

There are multiple thread blocks, each thread block takes care of attention wrt 1 block of Q (e.g. 128-256 rows of Q) for 1 head and 1 batch (this is the parallelism mentioned above). To do this, each thread block loops over blocks of K and V at a time (i.e. processing attention wrt 128-256 rows of K & V).

Thanks for the reply! I understand it now!


added validation of fib data and l2 entries

Coverage remained the same at 77.114% when pulling c22979f832d4b5aefa7b600bccb683e7f9e8cc12 on omegaman123:contiv-crd into e48e99afd0106063e83bb83f02e702a3fd11a8a3 on contiv:contiv-crd.


LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored

zss@zss:~/DA-RNN$ ./experiments/scripts/rgbd_scene_multi_*.sh $GPU_ID

set -e
export PYTHONUNBUFFERED=True
PYTHONUNBUFFERED=True
export CUDA_VISIBLE_DEVICES=./experiments/scripts/rgbd_scene_multi_depth.sh
CUDA_VISIBLE_DEVICES=./experiments/scripts/rgbd_scene_multi_depth.sh
export LD_PRELOAD=/usr/lib/libtcmalloc.so.4
LD_PRELOAD=/usr/lib/libtcmalloc.so.4
++ date +%Y-%m-%d_%H-%M-%S
ERROR: ld.so: object '/usr/lib/libtcmalloc.so.4' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
LOG=experiments/logs/rgbd_scene_multi_color.txt.2018-01-11_19-51-45
exec
++ tee -a experiments/logs/rgbd_scene_multi_color.txt.2018-01-11_19-51-45
ERROR: ld.so: object '/usr/lib/libtcmalloc.so.4' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
echo Logging output to experiments/logs/rgbd_scene_multi_color.txt.2018-01-11_19-51-45
Logging output to experiments/logs/rgbd_scene_multi_color.txt.2018-01-11_19-51-45
./tools/train_net.py --gpu 0 --network vgg16 --weights data/imagenet_models/vgg16_convs.npy --imdb rgbd_scene_train --cfg experiments/cfgs/rgbd_scene_multi_color.yml --iters 40000
ERROR: ld.so: object '/usr/lib/libtcmalloc.so.4' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib/libtcmalloc.so.4' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Traceback (most recent call last):
File "./tools/train_net.py", line 13, in
from fcn.train import get_training_roidb, train_net
File "/home/zss/DA-RNN/tools/../lib/fcn/train.py", line 11, in
from gt_data_layer.layer import GtDataLayer
File "/home/zss/DA-RNN/tools/../lib/gt_data_layer/layer.py", line 12, in
from gt_data_layer.minibatch import get_minibatch
File "/home/zss/DA-RNN/tools/../lib/gt_data_layer/minibatch.py", line 17, in
import scipy.io
ImportError: No module named scipy.io
Could anyone help me about the problem ?
Thank you very much!

sudo apt-get install google-perftools


Passing RGB into Core.Color Returns Incorrect Color

When passing in RGB values into Corale.Colore.Core.Color(), the values of the color are wrong.  This has something to do with our conversion to AABBGGRR.
Currently I pass in BRG to get the desired color.

Was this on all RGB constructors or only certain types?

I'll double check my test.

Led to believe this was caused by incorrect input data.


Update react-native symlink resolving and add support for flow

Issue:
The symlink resolving for react-native does not work all the time. react-native tools moved over to a new way of resolving symlinks last year: https://github.com/facebook/react-native/commit/39f83c4a12b8350e331c3a6c575a2cab64950d7a#diff-d939fe299a50129184bf6b4208f6d497
What I did
I moved over to the new symlink method according to the react-native PR
How to test
Run storybook on a project depending on external projects in a workspace monorepo. Make sure roots are all there (just like for react-native start) and storybook is the first root.
Is this testable with Jest or Chromatic screenshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.

Done
On Wed, Mar 28, 2018 at 5:53 PM Daniel Duan<EMAIL_ADDRESS>wrote:

@danielduan requested changes on this pull request.
looks reasonable. we're adding flow support as a default here too but
that's fine by me.
@meros https://github.com/meros please fix the lint errors, I think you
can ignore the global requires with a // eslint-disable-line global-require
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/pull/3306#pullrequestreview-107739504,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbfBh-NlYtIIp8eucPfcFebOrbeZMLDks5ti7HkgaJpZM4S-fp0
.


Add support for .env config files #110

I implemented a env validator using go-envparse package, also added a good.env and bad.env to test the env validator.
Closes #110

I can work on it again if you didn't like my implementation.

Thanks for the contribution @HakanVardarr ! Looks like you're just missing a few lines in the test data struct to test your .env file validator.

@kehoecj Oh I didn't see that struct :) I am going to look that right now

Interesting addition to the project, thanks


Generator metatag

I think it would be cool if refinery added a generator metatag.
Just adding something to the header like
 <meta name="generator" content="RefineryCMS 1.2.3">

Would make it easy to track the success of refinery "in the wild" :)

I'm sorry but I don't agree.. I just don't think it serves any useful purpose to have this tag and Refinery tries to be as minimally invasive as possible and this could have negative implications; the example I'm thinking of here is that a version of Refinery might have an exploit possible and this tag would make it far easier to attack websites using that version. Thanks for the suggestion :-)


java_version not shown

https://github.com/kvendingoldo/semver-action/blob/035bb70e332b635d81bf5d96397676b924d00853/main.py#L209

fixed in version 1.10; Pipeline example:
name: ci
on:
  push:
    branches:
      - main
jobs:
  main:
    runs-on: ubuntu-20.04
    steps:
      -
        uses<EMAIL_ADDRESS>        with:
          fetch-depth: 0
      -
        name: Set application version
        id: set_version
        uses<EMAIL_ADDRESS>        with:
          primary_branch: main
      -
        name: Generated version
        run: echo ${{ steps.set_version.outputs.version }}
      -
        name: Safe version
        run: echo ${{ steps.set_version.outputs.safe_version }}
      -
        name: Java version
        run: echo ${{ steps.set_version.outputs.java_version }}

Output:


Pylance does not report @abstractmethod not being implemented

Environment data
pylance version: v2024.5.1
python: 3.12
Code Snippet
from abc import abstractmethod
from datetime import datetime
from typing import Optional

from pydantic import Field
from src.agent_store.common.models.column_base_model import ColumnBaseModel

class ColumnBaseModel:
  @abstractmethod
  @classmethod
  def column_schema(cls) -> str:
    pass

class DateCreated(ColumnBaseModel):
  date_created: Optional[datetime] = Field()

  @classmethod
  def column_schema(cls) -> str:
    return "date_created TIMESTAMP"

class DateModified(ColumnBaseModel):
  date_modified: datetime = Field(default_factory=datetime.now)

class DateLastUsed(ColumnBaseModel):
  date_last_used: datetime = Field(default_factory=datetime.now)

## should trigger not implemented abstract class
data = DateModified()

#######

It doesn't work with classmethods or instancemethods.
Repro Steps
The above code in pylance strict mode should generate an error for an abstract method not being implemented.  Below is the pyproject.toml
vscode also has strict enabled
[tool.pyright]
include = ["apps/**/*", "packages/**/*"]
typeCheckingMode="strict"
ignore=["**/.venv/**", ".venv"]

useLibraryCodeForTypes=false
autoSearchPaths=true

reportMissingTypeStubs=false
reportUnknownVariableType=false
reportUnknownMemberType=false
reportUnknownArgumentType=false

reportUnusedVariable="warning"
reportUnusedImport="warning"
reportIncompatibleMethodOverride="error"

# extra strictness
reportImplicitOverride = "warning"
reportCallInDefaultInitializer = "warning"
reportMissingSuperCall="information"
reportImportCycles="information"
reportPropertyTypeMismatch="warning"
reportShadowedImports="information"
reportUnnecessaryTypeIgnoreComment="information"

XXX

Expected behavior
XXX
Actual behavior
No checks happen
XXX
Logs

XXX

related issues:  https://github.com/microsoft/pyright/issues/644

You're not seeing a diagnostic there because ColumnBaseModel doesn't inherit from abc.ABC. If you add ABC as a base class, the diagnostic will appear as expected:
class ColumnBaseModel(ABC):
  @abstractmethod
  @classmethod
  def column_schema(cls) -> str:
    pass

@debonte
I still do not see that error even with that change

from abc import ABC, abstractmethod
from datetime import datetime
from typing import Optional, override

from pydantic import Field

class GraphColumnBase(ABC):
  @abstractmethod
  @classmethod
  def graph_node_columns(cls) -> str:
    pass

class DateCreated(GraphColumnBase):
  date_created: Optional[datetime] = Field()

  @override
  @classmethod
  def graph_node_columns(cls) -> str:
    return "date_created TIMESTAMP"

class DateModified(GraphColumnBase):
  date_modified: datetime = Field(default_factory=datetime.now)

  @override
  @classmethod
  def graph_node_columns(cls) -> str:
    return "date_modified TIMESTAMP"

class DateLastUsed(GraphColumnBase):
  date_last_used: datetime = Field(default_factory=datetime.now)

  @override
  @classmethod
  def graph_node_columns(cls) -> str:
    return "date_last_used TIMESTAMP"

## should trigger not implemented abstract class
data = DateModified()

I believe in your latest example, it is implementing the abstract method:
class GraphColumnBase(ABC):
  @abstractmethod
  @classmethod
  def graph_node_columns(cls) -> str:
    pass

class DateModified(GraphColumnBase):
  date_modified: datetime = Field(default_factory=datetime.now)

  @override
  @classmethod
  def graph_node_columns(cls) -> str:
    return "date_modified TIMESTAMP"

@debonte thanks!  @rchiodo thanks!  i was having a doh moment!


merge package template from Kronos-Tools/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
chore(devDependencies): add<EMAIL_ADDRESS>from template
docs(package): remove keyword null

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #72   +/-   ##
======================================
  Coverage    92.3%   92.3%
======================================
  Files           1       1
  Lines          26      26
======================================
  Hits           24      24
  Misses          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6781fe1...f434287. Read the comment docs.


Add GCIS

Insert URLs to the project here:
https://github.com/USGCRP/gcis

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@justgo129 @lomky


feat(clerk-js,shared): Add a navigateWithError utility for SignIn (#2043)

Backporting #2043 to the release/v4 branch
(cherry picked from commit 0d1052ac284b909786fd0e4744b02fcf4d1a8be6)

seems like linting failed

Weird, given that the original PR didn't have this issue.

!snapshot


Support absolute sorting in grids

Certain types of values (e.g. pnl values) are more useful sorted by absolute value. This is a custom feature we added to the Ext toolkit which we should bring to the react toolkit.
Columns should support an absSort flag. When enabled, sorting a grid column by clicking on its header would loop through 3 sort states (ascending, descending and absolute descending). Will likely require some UI customisation to display an appropriate sort icon when abs sorted.

Implemented using a custom header component, and a custom column comparator.
https://github.com/exhi/hoist-react/pull/662
https://github.com/exhi/toolbox/pull/83

Fixed in https://github.com/exhi/hoist-react/issues/659


Details about training dnn_age_predictor_v1.dat.bz2

Hi, team, may I ask, you said about dnn_age_predictor_v1.dat.bz2 model: "This model is thus an age predictor leveraging a ResNet-10 architecture", so you just use ResNet-10 architecture (dnn_age_predictor_v1.dat.bz2 model has been trained from scratch, no pretrained weights from other models) or use pretrained ResNet-10 model (transfer learning)?
It would be very good if there are some document, describing the detailed process of training this model and metrics on test dataset.
I ask about that, because ResNet-10 model (description about this model I found here: https://github.com/BVLC/caffe/wiki/Model-Zoo) has been trained on ImageNet. As ImageNet does not allow commercial use, therefore models, which are fitted on this dataset, do not allow commercial use (I am actually not a lawyer, I just think about that like this). But dnn_age_predictor_v1.dat.bz2 model might use ResNet-10 pretrained model and is released under CC0-1.0, which allows commercial use. So, there might be a conflict. (I just think about that like this)

It's trained from scratch.  No pretraining.
On Mon, Dec 12, 2022 at 2:04 AM perets-dev @.***> wrote:

Hi, team, may I ask, you said about dnn_age_predictor_v1.dat.bz2 model:
"This model is thus an age predictor leveraging a ResNet-10 architecture",
so you just use ResNet-10 architecture or use pretrained ResNet-10 model
(transfer learning)?
—
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib-models/issues/47, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPYFRZ2YSZBGJ2TXVRJIKLWM3E6LANCNFSM6AAAAAAS3SBKAE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks

Excuse me, davisking, I have edited this question a bit a while ago before you answered to this question (this: https://github.com/davisking/dlib-models/issues/47#issue-1491148893), so, you saw (may be) a previous version of the message. Could you view this question again, thanks) (on github)

I don't know anything more about it beyond what is said here https://github.com/davisking/dlib-models#dnn_age_predictor_v1datbz2

Thanks for the reply


Encode asset manifest as binary rather than JSON

Context
When loading an asset for the first time, the framework has to load a file called the asset manifest, which contains information about assets available to the app (for example, where to find higher-res variants of images). This file is in the JSON format.
Reading the file from storage, decoding into UTF, and parsing it as JSON is generally slower than we'd like, especially since this is will all likely happen on first paint (since many apps include images on their first screens).
The asset manifest (AssetManifest.json) is created at build time.
Change
The asset manifest will now be in a binary format rather than JSON. In particular, we'll use the standard_message_codec package for encoding the manifest at build time and decoding it at runtime. This will achieve a significant speedup for first asset load, especially on less powerful devices.
Here are the results from running the load_and_parse_large_asset_manifest benchmark on a Galaxy S9 (SM G960U) before and after the change:

Before: 8543ms, 8677ms, 8689ms (average 8636.3ms)
After: 2625s, 2602ms, 2619ms (average 2615.3ms)

The result is a ~70% reduction in runtime.
TODO

Make the new version of the asset manifest into a Map<String, List<SomeNewType>> instead of a Map<String, List<String>>. This way we gain the ability to add properties to variants in the future should we desire them (e.g. light/dark theme variants) without breaking customer code.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Right now, I've somehow made first manifest load slower rather than faster (according to the benchmark), so I'm trying to figure that out.

Oh yeah, my apologies for leaving that out. I'm running the new benchmark, setting the number of iterations to 1. On master, the benchmark completes in about ~125ms, and on this branch it runs in ~140ms. This is on a Samsung Galaxy S9. IIRC from Friday, the new method is faster, but only with a higher number of iterations.

Its possible that with 1 iteration you're mostly measuring the time to load the asset. Since both are about the same size, perhaps you should move that out of the benchmark?

Are you loading the bytes outside of the benchmark in the JSON case: https://github.com/flutter/flutter/blob/master/dev/benchmarks/microbenchmarks/lib/foundation/decode_and_parse_asset_manifest.dart#L23

@jonahwilliams. LUCI is unhappy with me including the test asset manifest (money_asset_manifest.bin) because it's not UTF8. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8799564695396497569/+/u/Analyze/analyze/test_stdout. I see two ways forward, but I'm not thrilled by either of them:

Move the file to some other repo as the error message suggests.
Include the asset manifest file in some other format (e.g. go back to using JSON) and then, when setting up the test, read it and re-encode it in the standard message format.

Do you have any thoughts or other options I am not aware of?

You should add an exception to the analysis test - we have some other examples of doing it. The intention of that check is to prevent folks from checking in large binary assets accidentally
see dev/bots/test.dart

Talked with @jonahwilliams yesterday and wanted to summarize my takeaways for my own record. Also, while I'm happy with the current approach in the change, I can't help but (re)ask some questions.
This change will deprecate the AssetBundle.loadStructuredData API, replacing it with a more general form that operates directly on ByteData, loadStructuredDataBinary. If we are OK with deprecating loadStructuredData, I can't help but think about how loadStructuredData might be currently used and whether or not it should have ever been exposed to begin with. As I understand it, the primary intent of loadString and loadStructuredData is to provide built-in caching of string and structured data (e.g. JSON) assets respectively (loadString also conveniently provides UTF-8 decoding). The idea to me, then, is if there are disparate codebases that access the same (text/structured data) asset, then the app will benefit from caching. I still am not sure about the idea (how often are disparate codebases requesting text/JSON assets?), but changing it now could risk unexpected performance degradation for not much gain, so I don't think it's worth worrying about now.
Caching aside, outside of the tool itself, is there a known use case of loadStructuredData aside from reading the asset manifest (e.g. google fonts for figuring it out if it can avoid loading fonts over the network because they are already available)?

If there is no such use case, would the google fonts use case be better as something we explicitly support with additional APIs (e.g. an API that determines whether or not a font with a particular name is available)? I ask this because the idea of external code loading and inspecting AssetManifest.json directly feels like reverse-engineering. If we plan to deprecate loadStructuredData and thus break that means of accessing AssetManifest.json, then, I feel like, while we are at it, we may as well improve the API here so folks don't have to reach into flutter internals like AssetManifest.json (or AssetManifest.bin).
If there is such a use case, then do we really want to deprecate loadStructuredData? If folks, for example, want to include JSON (or similar) files as assets, then why inconvenience them by having them switch to loadStructuredDataBinary and then prepend UTF8 decoding into their parser function? Why not just keep both APIs around?

Heya @Hixie. Per this line of code in analyze.dart, I wanted to ask you about adding a new file to _legacyBinaries. For the purpose of benchmarking, this PR adds an asset manifest file (which is now binary rather than JSON with this change). This file is a little under 120KB. Do you have any reservations about me adding this file?

We shouldn't add a 120KB binary file. Binary files end up being very expensive for every user of Flutter forever, because of how we distribute our code. We have other repositories for that kind of thing. In this case though it seems like it would be even better to generate the manifest on the fly for the test? These manifest files should never be checked in to any repos in normal production environments right?
(Side note, we should presumably add this file to our default .gitignore?)

I was sort of hoping we could get away with it since most of the data is actually utf8 encoded strings and in theory should have the same diff behavior as a large file filled with strings. If not, thats OK - we can change the app under test to generate the synthetic manfiest by encoding it as JSON and then converting it to SMC on the fly.
We don't need to add this file to the .gitignore because its normally generated as a side effect of the build and not user visable.

actually @andrewkolos you should probably be sure to not delete the original JSON file, otherwise we won't be able to modify the binary SMC file without writing a separate helper program to parse it again

I was sort of hoping we could get away with it since most of the data is actually utf8 encoded strings and in theory should have the same diff behavior as a large file filled with strings.

It's not at all clear to me how well that would work, binary git deltification is a bit of a mystery to me. But in general, any large file is always a problem regardless, just because it's large.

If not, thats OK - we can change the app under test to generate the synthetic manfiest by encoding it as JSON and then converting it to SMC on the fly.

How was the synthetic data created in the first place?

We don't need to add this file to the .gitignore because it's normally generated as a side effect of the build and not user visible.

If it's already .gitignored by virtue of being put somewhere that's already in .gitignore then that's great.

Can we document this binary format?

Yes, we should document the format (at least starting here in the asset code), including which keys we support today, and which ones we intend to add in the future

How was the synthetic data created in the first place?

I took the existing asset manifest of an internal app (money) and wrote an ad-hoc program to obfuscate it (though I don't believe the data to be sensitive in any way) and convert it to the binary format we will use going forward.

I'm updating more tests now. I should do a pass myself, but if you are eager to review then go for it!
Question: For the tests involving asset manifests, should we temporarily keep the tests involving AssetManifest.json and just make duplicates for the binary version? I feel like that's the right thing to do, but wanted to run it by you before I make the effort.
Also FYI I updated the manifest format so that each asset is no longer a variant of itself--to reduce parsing time.
That is {"images/foo.jpg":["images/foo.jpg"] is now {"images/foo.jpg":[]}.
The default dpr image resolution logic should remain unchanged (i.e. if targeting a dpr if 1.0, we should still pick the main/default version of the asset). This should be fine unless we want room to one day make the keys only logical/symbolic ones (i.e. they no longer represent actual file locations).

Question: For the tests involving asset manifests, should we temporarily keep the tests involving AssetManifest.json and just make duplicates for the binary version? I feel like that's the right thing to do (given that the json is being deprecated--not removed), but wanted to run it by you before I make the effort.

What would be the value of the benchmark then? If the old JSON benchmark regressed would you drop what you are doing to fix it? Or would we say "well, we're moving away from this anyway, and we know its slow 🤷♂ ". (Probably the latter).
Everything else SGTM.

Question: For the tests involving asset manifests, should we temporarily keep the tests involving AssetManifest.json and just make duplicates for the binary version? I feel like that's the right thing to do (given that the json is being deprecated--not removed), but wanted to run it by you before I make the effort.

What would be the value of the benchmark then? If the old JSON benchmark regressed would you drop what you are doing to fix it? Or would we say "well, we're moving away from this anyway, and we know its slow 🤷♂ ". (Probably the latter).
Everything else SGTM.

I wasn't referring to the benchmark. I'm referring to tests like those found in asset_bundle_package_test.dart and asset_bundle_variant_test.dart that make sure the manifests we are generating contain the correct data.

Ah yes, in that case definitely keep them around. We'll delete them eventually

@jonahwilliams I'm looking at this test I broke: https://github.com/flutter/flutter/blob/56c4e3cdd8a11ba373979e05f48836d1440e7d25/packages/flutter/test/widgets/image_resolution_test.dart#L262-L271
This test was added with https://github.com/flutter/flutter/pull/11564. The idea behind it makes enough sense, but when I try to load an image that only has variants, the result is an error (on stable).

repro (macos)
Repro link

To your knowledge, is it possible for an image to only have variants?

I've not tried. its possible that this was implemented and then broke and some point in the future.

Ready for review again. I held off on running flutter upgrade-packages since that would muddy up the diff. Let me know if some of the diffs of the test files prove to be a bit much. I prioritized being able to quickly remove tests that are no longer needed once AssetManifest.json is gone for good.

@jonahwilliams Could I borrow your experience with the Completer API? My latest change adds logic for falling back AssetManifest.json in the case AssetManifest.bin is missing (code). However, it seems to only work the first time an image is loaded (e.g. load a route with an image on it, pop the route, nav into it again and the image won't show up).

Could I borrow your experience with the Completer API? My latest change adds logic for falling back AssetManifest.json in the case AssetManifest.bin is missing (code). However, it seems to only work the first time an image is loaded (e.g. load a route with an image on it, pop the route, nav into it again and the image won't show up).

The issue appears to stem from use of onError. If I comment out the onError chain for falling back to the json asset manifest, it appears to work again.

@andrewkolos I think the google testing shard is stuck. You'll need to investigate and/or ask for help on what is going on

google testing is stuck, i've asked @andrewkolos to click submit

actually turns out its not stuck, we just messed up applying the fix!

@jonahwilliams See previous commit.
https://github.com/flutter/flutter/blob/eed94ec255add02bc8c3bf8e5f03000323710ffb/packages/flutter/lib/src/painting/image_resolution.dart#L294-L302
The commented out onError doesn't work as I expect (see test failures in image_resolution_test.dart), yet the "identity then" with an onError argument that I'm currently employing does 😕

Looks like after merging, this branch is still upgrading package:archive past the pin I added. I would suggest reverting all the pubspec.yaml changes from this branch relate to upstream, and then re-adding the new dependency and then re-running: flutter update-package --force-upgrade.

We've branched and this should be safe to land.

I was hoping FRoBs would be fixed soon so that Google testing could finish, but testing did pass three commits ago, so I will go ahead and land this.

Manually merged since FRoB is down.

SkiaPerf is reporting a nice improvement here: https://flutter-flutter-perf.skia.org/e/?begin=1670172924&end=1670276486&keys=X2c1c806b3584886f3337add1a572b1ea&num_commits=50&request_type=1&xbaroffset=32385

Woohoo!


Before() failures don't trigger After() functions

What are you trying to achieve?
Tests to retry gracefully after failing in before step
What do you get instead?
Tests failing inside the Before() step aren't triggering the After() conditions.
What I see in the allure report is that when a test fails in the Before() stage, it just tries to initiate the before again without triggering the after conditions to reset the state.

Provide test source code if related

Before(async () => {
  await I.startHAR();
  await I.checkResponseFromStatusEndpoint();

  await I.accessURL(await urlMother.homePageUrl(domain));
  await tryTo(() => footer.acceptCookies());

  I.waitForElement(subpageHeader.personalInfoHeaderText, 20);
});

Scenario('should be able to update newsletter preferences', async () => {
  Test data here
})

After(async () => {
  await I.stopHAR();
});

Details

CodeceptJS version: 3.4.1
NodeJS Version: 16
Operating System:
puppeteer
Configuration file:

  retry: {
    Feature: process.env.E2E_TEST_RETRIES,
    Scenario: process.env.E2E_TEST_RETRIES,
    Before: process.env.E2E_TEST_RETRIES,
    After: process.env.E2E_TEST_RETRIES,
  }

Comment
Is my configuration wrong on the retries for the Before / After?
Does it need to function differently for when the part of the test inside before fails?

This is very philosophical question
We don't know at what point Before failed. What if it fails before startHAR is finished, would we need stopHAR in this case?
I would recommend you to use Custom Helper for this case
Helpers will execute no matter what on corresponding hooks


Deploy multiple packages provided

Tasks like aemDeploy, aemUpload , aemInstall aemActivate could consider more packages to be installed instead of one predefined in config.packageLocalPath or build by aemCompose task.
What if these tasks will perform actions for multiple packages provided by:

all tasks extending ComposeTask
all paths specified in packageLocalPaths (plural)

implemented as
tasks {
    named<Compose>(Compose.NAME) {
        packages = aem.packagesDependent(this)
        packages += file("any-package-i-want-to-deploy.zip")
    }
}

instances now controlled in the same manner.
to be released within 6.x

to deploy any package on any instance simply write custom task and use AEM extension / DSL API:
tasks {
    register("myDeploy"), {
        val instances = listOf(aem.instance("local-author"), aem.instance("http://<IP_ADDRESS>"))
        val pkgs = listOf(file("any-pkg1.zip"), file("any-pkg2.zip"))

        aem.sync(instances, packages) { pkg -> deployPackage(pkg) }
    }
}


Questions about some errors when running simulation or tests

Hello! I'm not sure if I missed a dependency somewhere (or needed to do anything else to get things working), but I'm trying to run make test and make simulation in the respective pre-built /builds/RV64... directories and getting a couple of different errors.
I'm currently on M1 Mac OS Ventura.

I tried running make simulation in the iverilog directories, but it seems like it was still expecting verilator / bsc to be installed, so I installed Verilator but now it seems to be failing with :

%Error-NEEDTIMINGOPT: Verilog_RTL/mkPLIC_16_2_7.v:25483:4: Use --timing or --no-timing to specify how delays should be handled
                                                         : ... note: In instance 'mkTop_HW_Side.soc_top.core.plic'
25483 |    #0;
      |    ^
                      Verilog_RTL/mkCore.v:2314:1: ... note: In file included from 'mkCore.v'
                      Verilog_RTL/mkSoC_Top.v:1127:1: ... note: In file included from 'mkSoC_Top.v'
                      Verilog_RTL/mkTop_HW_Side_edited.v:227:1: ... note: In file included from 'mkTop_HW_Side_edited.v'
%Error: Exiting due to too many errors encountered; --error-limit=50

I'm not sure if I missed anything there.

When I run make test , I get an error saying :

elf_to_hex.c:15:10: fatal error: 'gelf.h' file not found
#include <gelf.h>
         ^~~~~~~~
1 error generated.
make[1]: *** [elf_to_hex] Error 1

I tried fixing the path to my compiler, but it didn't seem to have any effect. I'm not sure the best way to debug this and tried with clang/gcc/g++.
Sorry for the amount of questions, and thank you for any guidance!

@rsnikhil can correct me if I'm wrong about either of these:

The repo was written when the latest Verilator was v4, but you have v5 installed which needs an additional flag to be provided (--no-timing).  Also, when this repo was created, BSC didn't support compiling and linking for Verilator, so special scripting was necessary for that.  BSC now natively supports Verilator and would call Verilator with the necessary flags.  I believe that @rsnikhil is intending to push changes to simplify the build scripts to now use BSC, but that hasn't been done yet.  Until then, you can add --no-timing to the assignment of VERILATOR_FLAGS at line 37 in builds/Resources/Include_verilator.mk:

VERILATOR_FLAGS = --stats -O3 -CFLAGS -O3 -LDFLAGS -static --x-assign fast --x-initial fast --noassert --no-timing

Building the elf_to_hex program requires "libelf" and the C compiler needs to be able to find it.  On macOS, you can install it with Homebrew using brew install libelf and on Ubuntu with apt install libelf-dev.  However, the location where Homebrew installs the library may not be visible to the C compiler.  You probably need to provide -I and -L flags to specify the directories, which can be determined by asking pkg-config for the necessary flags.  This is something that should be fixed in the Makefile in Tests/elf_to_hex/:

LIBELF_CFLAGS=$(shell pkg-config --cflags libelf)
LIBELF_LIBS=$(shell pkg-config --libs libelf)

elf_to_hex: elf_to_hex.c
    gcc -g  -o elf_to_hex  $(LIBELF_CFLAGS)  elf_to_hex.c  $(LIBELF_LIBS)

I will submit a PR to fix the Makefile.  And hopefully @rsnikhil can add the libelf dependency info to the READMEs, and eventually update the Makefiles to support Verilator v5 (mostly easily by upgrading to use BSC to call Verilator instead of doing it manually, now that that's possible).  However, the tools like elf_to_hex are  also in other repos (like Piccolo), I believe there is an intention to pull them out and put them into a common shared repo; it could be that these fixes have been held off, waiting for that reorganization to happen, but there hasn't been time to get to that yet.

thank you! those changes did work.


debugger hijack node-pty stdout in debug mode

VSCode Version: 1.36.1
OS Version: Windows_NT x64 10.0.18362

We have a project that uses node-pty (background) + xterm(js)  (UI) to access linux shell. The debugger works before upgrading, namely, when launching the system in the vscode debugger, the linux shell appears on a visiting browser because the data can be captured by the data event of the child process (launched by the node-pty) and send to the browser xterm via a websocket.
After the upgrading, the said data output is hijacked by the debugger stdout via a pipe and appears on the console window of the debugger. The said data event above no longer fires ...
I am not sure this is a bug or there is additional setting to be made?

What do you mean by "upgrading"?

@weinand I mean changing from an older version to the newest version at the moment (of writing the above message) ... But I am not sure which one of the older versions is the last one that works since I might had skipped a few before discovering the defect

Sorry, I don't understand your problem and I do not know how to reproduce this.
Please try again with the latest VS Code 1.43.2 and I will reopen the issue if the problem still occurs.


fix descriptions of credentials and verification app options

Looking for a way to provide extra untrusted certs for chain building during TLS server cert verification
I found that for both s_client  and s_server the documentation of the certificates given with the -cert_chain option attributes them as 'trusted' while in fact they are just untrusted additional certs to use for chain building.
On the other hand the documentation of most of the -chainCAfile, -chainCApath, -chainCAstore, -verifyCAfile, -verifyCApath, and -verifyCAstore options failed to make clear that all the certificates addressed by them are trusted.
When correcting this I found and fixed some mistakes in the file format options and their descriptions.
I've also slightly improved the description of the crl_download and nameopt options.
Moreover, the order of the description of these and related options was somewhat inconsistent, which is fixed as well in this PR.

BTW, how can one provide untrusted certs to help verifying peer certs, to use in case a peer does not send (all of) its cert chain?

Thanks @beldmit for your very swift approval!
Do you know if/how one can provide untrusted certs to help verifying peer TLS certs, to use in case a peer does not send (all of) its cert chain?
I found this possibility only for the verify app and direct use of X509_STORE_CTX_init().

I don't know either :(
Not sure if it's a reasonable option because in real life (e. g. browsers) we don't have such a store so servers must include a full chain to avoid errors

I agree that for web scenarios pre-known untrusted certs make little sense,
but in managed (e.g., industrial) scenarios it can make much sense,
in particular with limited bandwidth where it would be nice to avoid sending the same untrusted certs over and over.

This is going to be an RFC soon, it's just waiting for text editing: https://datatracker.ietf.org/doc/draft-ietf-tls-certificate-compression/?include_text=1

Nice, but this just compresses the certs being transmitted, but does not stop sending them.
And transmission size is not the only potential reason why a TLS node may need to augment the cert chain it receives from a peer.

Rebased and partly squashed.
Given that the approval was done two days before, can I merge this PR right away?

It is missing OTC member approval.

Using extra certs for chain building can come into play when the server is sending a potentially valid chain but you want to use a different one, e.g., chaining up to a different or cross-signed root.

Ping for OTC approval

Rebased this PR. It still needs an OTC approval.

The review/approval by @jaym05700 does not count here.

Pinging again on a OTC member approval.

This pull request is ready to merge

Merged - thanks!

I just found that the merge did not really happen, likely due to some misspelling or the like.
Now it's actually merged.


cannot view all sub organizations

scenario

go to organization tab

when multiple sub organizations are created there is no scroll bar

What browser were you using @lzonneke ?


Loading other models (fishhead, impeller) crashes server

This appears to be caused by a segfault after attempting to load the client:
info: CAD.js API Server listening on: 8080
GET / 200 634 - 128.805 ms
GET /v3/nc/state/loop/ 200 29 - 2.603 ms
GET /log 200 1987 - 4.863 ms
Segmentation fault: 11

Present in 1.2.0 as well

This is caused by the Inspection portion of a stpnc file. By manually removing the inspection workingsteps I was able to get files to load @Sam-son

fixed in StepNode PR 102


Non-determinism in Scoring / Tuning

Currently dev checkpointing is non-deterministic, with the best model producing a different score when reloaded and evaluated at the end of a training loop. The model is also evaluated twice at the end of the loop.
....
[E:46]	Train Loss: 0.008	Dev score: 0.598
Saving model at iteration 47 with best score 0.612
[E:47]	Train Loss: 0.008	Dev score: 0.612
Saving model at iteration 48 with best score 0.622
[E:48]	Train Loss: 0.008	Dev score: 0.622
[E:49]	Train Loss: 0.007	Dev score: 0.593
Restoring best model from iteration 48 with score 0.622
Finished Training
Accuracy: 0.829
Precision: 0.470
Recall: 0.887
F1: 0.615
        y=1    y=2
 l=1    55     62
 l=2     7     279
Tuner - using validation_metric=f1
F1: 0.612
        y=1    y=2
 l=1    56     65
 l=2     6     276

In general, scoring is non-deterministic. Can scoring setup to be deterministic conditioned on the user provided seed, with something like:
# save rng state, seed for deterministic evaluation
rng_gpu = torch.cuda.random.get_rng_state_all()
rng_cpu = torch.random.get_rng_state()
torch.cuda.random.manual_seed_all(self.seed)
torch.random.manual_seed(self.seed)

# evaluate model here

# restore rng state to all devices
torch.cuda.set_rng_state_all(rng_gpu)
torch.random.set_rng_state(rng_cpu)

@jason-fries thanks for catching this!  I'll take a look later today

Hey @jason-fries I'm assuming the example above is with the GPU, and the LSTM? Do you know if it occurs without the GPU?  And could you let me know how you had the model configured?
I'm a bit behind but going to try to isolate and correct as suggested on this branch
Thanks,
Alex

Just checked -- it's also non-deterministic on CPU.

Thanks! And could you share the model class (LSTM?) and kwargs / config used?

Perhaps I don't follow how the RandomSearchTuner is configured but there are couple things that seem weird/buggy to me.
For random seeding, I'd expect:

A user-provided seed for model weight initialization that's fixed during hyperparameter search.
A fixed, separate seed for sampling hyperparameters.

If I pass a single seed into the model search grid (see below) and set a different fixed seed for the RandomSearchTuner initialization, then the same hyperparameters settings are sampled for each trained model. If you remove the seed from the search space, then every model config gets a new seed by default (which seems weird).
The best model also seems to be chosen using accuracy not matter what is chosen as 'validation_metric'. How do you specify that the best model should be selected based on validation_metric?
Model config dictionary
{'input_module': lstm,
 'lstm_reduction': 'attention',
 'middle_modules': [Dropout(p=0.5],
 'seed': 123,
 'show_plots': False,
 'train_config': {'batch_size': 64,
                  'checkpoint': True,
                  'checkpoint_config': {'checkpoint_min': -1,
                                        'checkpoint_runway': 0},
                  'data_loader_config': {'batch_size': 16, 'num_workers': 8},
                  'disable_prog_bar': True,
                  'l2': 0.00166,
                  'n_epochs': 5,
                  'optimizer_config': {'adam_config': {'betas': (0.9,
                                                                 0.999)},
                                       'optimizer': 'adam',
                                       'optimizer_common': {'lr': 0.01},
                                       'sgd_config': {'momentum': 0.9}},
                  'print_every': 1,
                  'scheduler_config': {'exponential_config': {'gamma': 0.9},
                                       'lr_freeze': 0,
                                       'plateau_config': {'factor': 0.5,
                                                          'min_lr': 1e-05,
                                                          'patience': 1,
                                                          'threshold': 0.0001},
                                       'scheduler': 'reduce_on_plateau'},
                  'validation_freq': 1,
                  'validation_metric': 'f1'},
 'use_cuda': False,
 'verbose': True}

and
search_space = {
        'lr': {'range': [0.001, 0.01], 'scale': 'log'},
        'seed':[args.seed]
}

searcher = RandomSearchTuner(EndModel, seed=args.seed + 1, log_writer_class=TensorBoardWriter,  **log_config)
end_model = searcher.search(search_space,
                                dev_loader,
                                train_args=[train_loader],
                                init_args=init_args,
                                init_kwargs=init_kwargs,
                                train_kwargs=model_config['train_config'],
                                max_search=args.n_model_search)

@jason-fries looking into this now; one more question, has the issue only occurred when using the tuner, or also when just training the model with dev set checkpointing?

Okay well either way, I now have a basic model determinism test that is failing just with the LSTM on CPU, so probably need to fix the seeding in that module; doing this first

@jason-fries LSTM with randomly initialized embeddings just needs to be seeded for determinism; passing tests now on model-determinism branch. Moving on to random tuner

Fixed by PR #105


[ClangImporter] Assert when we're expecting a definition

No functionality change. Just want to make sure we don't misuse these functions.

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 67b8a3d2fb971b484d4f365fe27084a9bababae3
Test requested by - @jrose-apple

@swift-ci Please test macOS

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 67b8a3d2fb971b484d4f365fe27084a9bababae3
Test requested by - @jrose-apple

@swift-ci Please test macOS

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 67b8a3d2fb971b484d4f365fe27084a9bababae3
Test requested by - @jrose-apple

@swift-ci Please test


[BUG] spring boot service bus application getting java.lang.IllegalStateException: The following classes could not be excluded because they are not auto-configuration classes: - com.azure.spring.autoconfigure.aad.AADAuthenticationFilterAutoConfiguration error

Describe the bug
Followed the steps as mentioned on the documentation for sending and recieving messages to an azure service bus queue,
https://docs.microsoft.com/en-us/azure/developer/java/spring-framework/configure-spring-boot-starter-java-app-with-azure-service-bus
But while spring boot start up its failing with the error,
java.lang.IllegalStateException: The following classes could not be excluded because they are not auto-configuration classes: - com.azure.spring.autoconfigure.aad.AADAuthenticationFilterAutoConfiguration error
I have also tried excluding AADAuthenticationFilterAutoConfiguration  from autoconfiguration as i am not using it i got the below error,
java.lang.IllegalStateException: The following classes could not be excluded because they are not auto-configuration classes:
- com.azure.spring.autoconfigure.aad.AADAuthenticationFilterAutoConfiguration
Is it mandatory to define/configure something specifically for AADAuthenticationFilterAutoConfiguration ? If so please provide me the details if i am missing something.
Exception or Stack Trace
Add the exception log and stack trace if available
. ____ _ __ _ _
/\\ / ' __ _ () __ __ _ \ \ \ \
( ( )\__ | '_ | '| | ' \/ ` | \ \ \ \
\\/ )| |)| | | | | || (| | ) ) ) )
' || .__|| ||| |\, | / / / /
=========||==============|/=///_/
:: Spring Boot :: (v2.0.2.RELEASE)
2021-03-10 18:00:30.012 INFO 15224 --- [ main] com.att.cdo.Application : Starting Application on HVDIVD22CF01256 with PID 15224 (H:\git\environment-check-030921\target\classes started by km923h in H:\git\environment-check-030921)
2021-03-10 18:00:30.022 INFO 15224 --- [ main] com.att.cdo.Application : No active profile set, falling back to default profiles: default
2021-03-10 18:00:30.180 INFO 15224 --- [ main] ConfigServletWebServerApplicationContext : Refreshing org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@6293abcc: startup date [Wed Mar 10 18:00:30 IST 2021]; root of context hierarchy
2021-03-10 18:00:30.505 INFO 15224 --- [ main] o.s.c.a.ConfigurationClassParser : Properties location [classpath:authentication.properties] not resolvable: class path resource [authentication.properties] cannot be opened because it does not exist
2021-03-10 18:00:30.505 INFO 15224 --- [ main] o.s.c.a.ConfigurationClassParser : Properties location [file:${external.config.dir.base}/application.properties] not resolvable: Could not resolve placeholder 'external.config.dir.base' in value 'file:${external.config.dir.base}/application.properties'
2021-03-10 18:00:30.506 INFO 15224 --- [ main] o.s.c.a.ConfigurationClassParser : Properties location [file:${external.config.dir.base}/config.properties] not resolvable: Could not resolve placeholder 'external.config.dir.base' in value 'file:${external.config.dir.base}/config.properties'
2021-03-10 18:00:30.506 INFO 15224 --- [ main] o.s.c.a.ConfigurationClassParser : Properties location [file:${external.config.dir.base}/authentication.properties] not resolvable: Could not resolve placeholder 'external.config.dir.base' in value 'file:${external.config.dir.base}/authentication.properties'
2021-03-10 18:00:31.046 ERROR 15224 --- [ main] o.s.boot.SpringApplication : Application run failed
java.lang.IllegalStateException: The following classes could not be excluded because they are not auto-configuration classes:

com.azure.spring.autoconfigure.aad.AADAuthenticationFilterAutoConfiguration

at org.springframework.boot.autoconfigure.AutoConfigurationImportSelector.handleInvalidExcludes(AutoConfigurationImportSelector.java:200) ~[spring-boot-autoconfigure-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.autoconfigure.AutoConfigurationImportSelector.checkExcludedClasses(AutoConfigurationImportSelector.java:185) ~[spring-boot-autoconfigure-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.autoconfigure.AutoConfigurationImportSelector.selectImports(AutoConfigurationImportSelector.java:100) ~[spring-boot-autoconfigure-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.autoconfigure.AutoConfigurationImportSelector$AutoConfigurationGroup.process(AutoConfigurationImportSelector.java:386) ~[spring-boot-autoconfigure-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.context.annotation.ConfigurationClassParser$DeferredImportSelectorGrouping.getImports(ConfigurationClassParser.java:830) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.annotation.ConfigurationClassParser.processDeferredImportSelectors(ConfigurationClassParser.java:563) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.annotation.ConfigurationClassParser.parse(ConfigurationClassParser.java:188) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.annotation.ConfigurationClassPostProcessor.processConfigBeanDefinitions(ConfigurationClassPostProcessor.java:316) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.annotation.ConfigurationClassPostProcessor.postProcessBeanDefinitionRegistry(ConfigurationClassPostProcessor.java:233) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanDefinitionRegistryPostProcessors(PostProcessorRegistrationDelegate.java:273) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanFactoryPostProcessors(PostProcessorRegistrationDelegate.java:93) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:694) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:532) ~[spring-context-5.0.6.RELEASE.jar:5.0.6.RELEASE]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:140) ~[spring-boot-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:759) [spring-boot-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:395) [spring-boot-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:327) [spring-boot-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1255) [spring-boot-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1243) [spring-boot-2.0.2.RELEASE.jar:2.0.2.RELEASE]
at com.att.cdo.Application.main(Application.java:28) [classes/:na]
2021-03-10 18:00:31.051 INFO 15224 --- [ main] ConfigServletWebServerApplicationContext : Closing org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@6293abcc: startup date [Wed Mar 10 18:00:30 IST 2021]; root of context hierarchy
To Reproduce
Steps to reproduce the behavior:
Create a spring boot project defining the below library dependancy,

	<dependency>
	    <groupId>com.azure.spring</groupId>
	    <artifactId>azure-spring-boot-starter-servicebus-jms</artifactId>
	    <version>3.1.0</version>
	</dependency>

Write methods to send and JMSListener annotiation function for reciever for messages. Build and run the spring boot application.
Code Snippet
Add the code snippet that causes the issue.
while using this dependency in pom,

	<dependency>
	    <groupId>com.azure.spring</groupId>
	    <artifactId>azure-spring-boot-starter-servicebus-jms</artifactId>
	    <version>3.1.0</version>
	</dependency>

Expected behavior
A clear and concise description of what you expected to happen.
Spring boot application should come up without this error and message send and recieve to the queue on service bus should happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS] Windows 10
IDE : [e.g. IntelliJ] Eclipse 3
Version of the Library used 3.1.0

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Bug Description Added
[ ] Repro Steps Added
[ ] Setup information Added

@stliu @hemanttanwar can you please take a look?

Hi,@karthikmsc05
Thanks for your reporting.
Here is the sample azure-spring-boot-sample-servicebus-jms-topic and the sample azure-spring-boot-sample-servicebus-jms-queue
I'm thinking is it possible for you to create a minimal project or provide your pom.xml file so I can help to find the problem?

Hi Team,
Thanks for your response. I have followed the same reference as you have given. Here is the POM of mine attached FYR.
pom.zip

Hi,@karthikmsc05
I tried your pom file. Upgrading spring-boot-starter-parent to 2.4.3 will work normally.
    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.4.3</version>
    </parent>

Hi Team,
I had updated the dependency as per you mentioned to the supported version and the build got succeeded.


By default ignore 'ActionDispatch::Http::MimeNegotiation::InvalidType'

If a user-agent sends an Accept or Content-Type header with a mal-formed mime-type, then Rails raises. this happens in my app a lot as a result of what seems to be security vulnerability scanning, people sending Accept headers like "../../../../../../../../../../etc/passwd{%00
Rails is not vulnerable, everything is fine, but it raises. And Honeybadger than catches and reports.
Prior to Rals 6.1, the exception class was non-specific so it was hard to ignore/filter. But Rails 6.1 introduces an exception class just for this. Honeybadger should by default ignore it, it fits in with the other Rails stuff Honeybadger ignores by default.
Before submitting a pull request, please make sure the following is done:

If you've fixed a bug or added code that should be tested, add tests!
Run rake spec in the repository root.
Add an entry to the CHANGELOG.

doh meant to PR this upstream of course


openssl-3.0.7 VC-WIN32 Installed successfully

Having completed the install, without any errors using the Quick start steps, in the NOTES-WINDOWS.md file, if I run the command VERSION in an OPENSSL session, I see this:
OpenSSL> version
OpenSSL 1.1.1i  8 Dec 2020
OpenSSL>
Is this correct? Should not the version be 3.x?
Thanks in advance.

Most probably you have multiple openssl versions installed on your system and you're running the 1.1.1i version instead of the 3.0.7 you've just installed.

@t8m I did check the Windows Environment PATH (System and User) to confirm I am pointing to the 3.0.7 install location before opening this case. My previous version was 1.0.2 so I am not sure where the 1.1.1i version came from if not from the 3.0.7 package :) . Anyway I will dig further into this. Thanks for confirming I should expect the version command in OPENSSL to output 3.0.7.
Cheers

May I suggest using the command where to find out which openssl.exe cmd finds along PATH?
https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/where

@levitte Turns out Perl has an OPENSSL executable which I wasn't aware of. Thanks.


Dark mode for Lepton

The implementation is based on @DNLHC 's theme manager. https://github.com/hackjutsu/Lepton/issues/206
Add a new config field theme in ~/.leptonrc. Two supported values, "light" and "dark". "light" is the default value.
{
  "theme": "dark"
}

I'm a new user, I placed the file
C:\Users\NAME\AppData\Local\Programs\Lepton\ .leptonrc
I changed the code inside this file to
{
"theme": "dark"
}
But when I start Lepton, the dark mode doesn't appear to take effect. I'm using 1.8.0
Can you please guide me what to do further? Am I missing something?

Hi @WrongGuy , you might want to put this file in your home directory. https://gist.github.com/hackjutsu/1ad7e4968eb64d881ec9dedd6c0f400b

Hi there, I downloaded the .leptonrc file and put it in Linux Home directory. When I change the theme and default_private keyword, it doesn't make a difference. How should I activate those new features?

@hackjutsu Also, I set the default indent as 4, but when I hit tab, it seems only give 2, how to fix it?

@zlyin Would you mind creating a new issue? Thanks.

我是Mac OS的用户，我看到你并没有说明Mac如何切换至Dark主题，经过查找，发现你在Template for .leptonrc（https://gist.github.com/hackjutsu/1ad7e4968eb64d881ec9dedd6c0f400b）只说明来Liunx和windows上的教程，并没有Mac OS

I am a Mac OS user, I saw that you did not explain how the Mac switched to the Dark theme. After searching, you found that you are only in the Template for .leptonrc (https://gist.github.com/hackjutsu/1ad7e4968eb64d881ec9dedd6c0f400b) to Liunx.
And tutorials on windows, and no Mac OS

I am a Mac OS user, I saw that you did not explain how the Mac switched to the Dark theme. After searching, you found that you are only in the Template for .leptonrc (gist.github.com/hackjutsu/1ad7e4968eb64d881ec9dedd6c0f400b) to Liunx.
And tutorials on windows, and no Mac OS

you can refrence linux setting


Adding Images and Transitions in College Chapter Section to Improve UI

I would like to add some images, transitions and overall improve the UI of the college chapters section using card view/grid view

Yes sure @jasleen1316 , but make sure to add required screenshots in PR, so that we can review them easily.

Hey, Can I work on this issue? I am really interested.

Hi , I am contributor under GSSOC'23 and I am eager to showcase my skills and make a meaningful contribution to this project.
Kindly assign me this issue.@akshathar-navada

Yes sure, go ahead @tripathishipra

Thankyou

Can you please reassign me this project.
Sorry I accidentally removed the assignment.
On Sat, 3 Jun, 2023, 10:20 pm Akshatha R, @.***> wrote:

Assigned #129
https://github.com/OSCode-Community/OSCodeCommunitySite/issues/129 to
@tripathishipra https://github.com/tripathishipra.
—
Reply to this email directly, view it on GitHub
https://github.com/OSCode-Community/OSCodeCommunitySite/issues/129#event-9421907518,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY6HZPYVTRUUNR76W4WYSBDXJNTMZANCNFSM6AAAAAAYJHXVME
.
You are receiving this because you were assigned.Message ID:
<OSCode-Community/OSCodeCommunitySite/issue/129/issue_event/9421907518@
github.com>

Improving the UI of College chapter page is open to all. Open a PR with required screenshots, we will review it soon!

Can I work in this again ? you can reassign me. @akshathar-navada

This is open to all, u can go ahead and open a PR with required screenshots, we will review it soon!


Added Haxorus

Added Haxorus

Hey @parresh77 , i really appreciate you wanting to contribute to the project but i think there are some conflicts in your PR. It might be beacuse of merging of other PRs and not your fault. So i will close all your PRs for now but you can refork or upstream the repo to make another valid PR.


renovatebot(deps): update dependency org.apache.cxf.services.sts:cxf-services-sts-core to v3.3.3

This PR contains the following updates:

Package
Update
Change

org.apache.cxf.services.sts:cxf-services-sts-core
patch
3.3.2 -> 3.3.3

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(languages): add support for JSX and TSX

Small changes for JSX and TSX

TSX

JSX

Not sure about the colours for JSX. Maybe yellow fits better since it's Javascript?

oOf looks like I'll have to fix the ascii art tomorrow

Looks great @Luke-zhang-04
Unless you're not done, make your PR "Ready for review" and I'll merge it.

Oops


Why is historic data different for each request?

The sum of every column of a request returns a different value except the time value?
This data should be constant, right?
https://runkit.com/jammer/5aa48476cf969b001299fb7b

Is this not a big issue for people? Seems like a bug to me. It's pretty annoying.

The API References documents this:
https://docs.gdax.com/#get-historic-rates

Historical rate data may be incomplete.

Historical rates should not be polled frequently.

If data points are readily available, your response may contain as many as 300 candles and some of those candles may precede your declared start value.

In other words, it appears that this endpoint is designed to be non-deterministic in a way. I'm not sure why. Perhaps it's caching-related or some kind of best effort implementation.
@fb55 might be able to shed more light here, but because it's somewhat documented already, I have doubts there's anything we can do about it.

This should be fixed.

If it does not get fixed then their is an obvious reason for that. Guess what it is. Hint, read the legal disclaimer.


doc: application: add details on example-application

Mention example-application as a reference application.

I think this needs more discussion and infrastructure around the release process.
I am against this change unless we use example-application branches or tags whose manifests will be pinned to the release version of zephyr they were tested on.
So I'm saying for example:

the zephyr 2.6 docs build should point to an example-application manifest that imports zephyr with revision: v2.6.0 (or v2.7.1, v2.7.2, etc.)
the zephyr 2.7 docs build should point to an example-application manifest that imports zephyr with revision: v2.7.0, etc.
zephyr main can point to an example-application manifest that imports with revision: main

I think it should be sufficient to make example-application follow Zephyr versioning and mention that in both Zephyr docs and example app README.

Can you explain what that means? Right now we don't have anything except a single branch with a manifest that points to zephyr main (in the example-application repository).

I mean, Zephyr docs should just link to https://github.com/zephyrproject-rtos/example-application independently of the Zephyr version. example-application should make explicit that it follows Zephyr versioning (I assume the idea is to make example-application v2.6.0 point to Zephyr v2.6.0).

example-application should make explicit that it follows Zephyr versioning (I assume the idea is to make example-application v2.6.0 point to Zephyr v2.6.0).

I think I agree, but "should" is a key word here. Right now it doesn't do anything like that, and I think we should sort that out before merging this.

example-application should make explicit that it follows Zephyr versioning (I assume the idea is to make example-application v2.6.0 point to Zephyr v2.6.0).

I think I agree, but "should" is a key word here. Right now it doesn't do anything like that, and I think we should sort that out before merging this.

Agreed, maybe a quick sentence here or in the example application .md @gmarull?

@gmarull
As part of this PR, can you also add a line in the "major enhancements" section of the release notes with something along the lines of: "Added an example standalone Zephyr application in its own Git repository"

example-application should make explicit that it follows Zephyr versioning (I assume the idea is to make example-application v2.6.0 point to Zephyr v2.6.0).

I think I agree, but "should" is a key word here. Right now it doesn't do anything like that, and I think we should sort that out before merging this.

Agreed, maybe a quick sentence here or in the example application .md @gmarull?

Will the example-application follow Zephyr versioning? I understand this has not been formally decided yet (maybe I missed it).
If you guys confirm this will be the rule I can update example-applicacion readme. We should likely include the procedure as part of the release process, too.

Added an example standalone Zephyr application in its own Git repository

done

example-application should make explicit that it follows Zephyr versioning (I assume the idea is to make example-application v2.6.0 point to Zephyr v2.6.0).

I think I agree, but "should" is a key word here. Right now it doesn't do anything like that, and I think we should sort that out before merging this.

Agreed, maybe a quick sentence here or in the example application .md @gmarull?

Will the example-application follow Zephyr versioning? I understand this has not been formally decided yet (maybe I missed it).

I believe we did decide that, yes. I was not able to find the relevant comment after a search, but why wouldn't we do this? This is now part of the release, and so it should be tagged all the same.

If you guys confirm this will be the rule I can update example-applicacion readme. We should likely include the procedure as part of the release process, too.

If this PR makes it to 2.6, then let's update: https://github.com/zephyrproject-rtos/zephyr/issues/32293

I believe we did decide that, yes. I was not able to find the relevant comment after a search, but why wouldn't we do this? This is now part of the release, and so it should be tagged all the same.

I agree we should follow the same versioning, we just need to make sure it's properly documented.

I believe we did decide that, yes. I was not able to find the relevant comment after a search, but why wouldn't we do this? This is now part of the release, and so it should be tagged all the same.

I agree we should follow the same versioning, we just need to make sure it's properly documented.

Let's push a PR to the example-application repo stating that fact then, I do not foresee any controversy.

Let's push a PR to the example-application repo stating that fact then, I do not foresee any controversy.

https://github.com/zephyrproject-rtos/example-application/pull/9


FastQC hangs forever on Travis CI

Describe the bug

FastQC hangs forever on Travis CI (or at least more than 10 min)

To Reproduce

Relaunch any Travis CI jobs that is currently failing

Expected behavior

FastQC should finish in just a couple of minutes (or even less)

System (please complete the following information):

Hardware: TravisCI
Executor: local
OS: TravisCI
Version TravisCI

Nextflow (please complete the following information):

Version: 0.32.0

Container engine (please complete the following information):

Engine: Docker
version: TravisCI

Container (please complete the following information):

tag: latest

Sarek (please complete the following information):

version: dev

Additional context
[30/4e318f] Submitted process > RunFastQC (1234-1234N_M1)
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

Here you go: https://github.com/bioconda/bioconda-recipes/pull/12616


[NEW ICON] Gsap and some

Skill Name
GSAP, Jira and Zoom
Why?
They are now widely used tools and Gsap is one of the most widely used libraries at the moment.
Reference Image

Hey @isiahzac, can you please make also an issue on the rolling release repository that has been rewritten in go for better performance. Thank you :)

Done :) and thank you for your job.


⚠ Bofrost.fr has degraded performance

In 3da93e3, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2053 ms

Resolved: Bofrost.fr performance has improved in e74b9b5.


chore: Add gRPC validation for EscrowAddress

Description
Added gRPC validation for EscrowAddress in apps/transfer/keeper
ref: #4140
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against the correct branch (see CONTRIBUTING.md).
[x] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[x] Code follows the module structure standards and Go style guide.
[x] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[x] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[x] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

New Features

Enhanced validation for gRPC request parameters in the transfer service, including checks for channel existence and validation of port and channel identifiers.

Bug Fixes

Improved error handling in the escrow address retrieval process.

Tests

Added a new test case to cover scenarios where a channel is not found during a transfer operation.

E2E failure looks unrelated, we can re-run it :+1:


Not able to get the libraries

1.Hi...I am using Qt editor . I downloaded the given SDK and I'm trying to include one of the header files which s3Client.h . It is not able to include those files which are included within this files though I gave the proper INCLUDEPATH in the .pro file
2.After downloading this package I did not find any link or guideline mentioning how to install this package . If in case I need not include any package , then how do I fetch the library??

If you use visual studio, this whole process is automated for you via NuGet. If you use cmake for your project, you can use our cmake exports file.  I believe Qt Editor also has CMake support, and you can probably pass our exports file to that. However, we recently discovered a bug in our export process. We'll have a bug fix going out for that shortly.

Is this still an issue for you? Or have you figured out how to do what you need to do?

Closing due to inactivity. Reopen if issue still persists.


Middleware Fails when called from gateway

With this config:
<?xml version="1.0" encoding="UTF-8"?>
<middleware xmlns="urn:katana:middleware" name="api" version="1.0.0" protocol="urn:katana:protocol:http" request="true" response="true">
    <info title="Auth" description="Response middleware for API requests and responses" terms="https://tech.example.com/docs/middleware-api">
        <contact name="API" url="https://tech.example.com/docs/middleware-apii"<EMAIL_ADDRESS>        <license name="License" url="https://tech.example.com/docs/middleware-api"/>
    </info>
    <external-docs description="API middleware docs" url="https://tech.example.com/docs/middleware-api"/>
    <engine runner="urn:katana:runner:node" path="../runner.js"/>
    <http-response code="401" description="The access credentials were invalid" mime="application/problem+json">
        <http-example>
            <![CDATA[
            {
              "type": "https://tech.example.com/api/errors#401-Unauthorized",
              "detail": "The access credentials used on this request are not valid",
              "status": 401,
              "title": "Unauthorized"
            }
            ]]>
        </http-example>
    </http-response>
</middleware>

And this code:
const Middleware = require('katana.sdk').Middleware;
const middleware = new Middleware();

middleware.request((request) => {
    return request;
});

middleware.response((response) => {
    return response;
});

middleware.run();

The gateway calls return this error on any type of request:
2017-06-09T07:58:40.104Z [ERROR] [SDK] Error running callback: response. Cannot read property 'v' of undefined TypeError: Cannot read property 'v' of undefined
at Mapper.getHttpRequest (/home/vagrant/dev/katana/middleware-api/node_modules/katana.sdk/sdk/mapper.js:101:20)
at Middleware._getResponse (/home/vagrant/dev/katana/middleware-api/node_modules/katana.sdk/sdk/component.js:234:20)
at Middleware._processCommand (/home/vagrant/dev/katana/middleware-api/node_modules/katana.sdk/sdk/middleware.js:30:33)
at Middleware._processMessage (/home/vagrant/dev/katana/middleware-api/node_modules/katana.sdk/sdk/component.js:142:10)
at emitThree (events.js:116:13)
at emit (events.js:194:7)
at Socket._flushRead (/home/vagrant/dev/katana/middleware-api/node_modules/zmq/lib/index.js:638:15)
at Socket._flushReads (/home/vagrant/dev/katana/middleware-api/node_modules/zmq/lib/index.js:676:23)
at _zmq.onReadReady (/home/vagrant/dev/katana/middleware-api/node_modules/zmq/lib/index.js:297:10)

If I run katana middleware request -c config/katana.xml -u http://test.com/1.0/auth/facebook it works as expected.

Note, this happens on all forks, including the async fork with done() calls instead of returns.

@orestes any news on this? This is quite a major blocker, I've been checking the code for the past hours and can't figure much out. What I did see from debugging is that for some reason the payload gets logged twice into the console from the mapper, the first time correctly and the second time is undefined. Let me know and we can pair and fix this asap.

ping @orestes I have not tested this yet on latest release. but I see no mention or reference to this issue. Did you check anything regarding it?

Just managed to recover the vm, and this is still broken. I thought the new version would fix this but it seems unrelated. Looking into it now.

thanks.

I'm running into a problem where it looks like the timeout is not being respected by katana, it timeouts right away. Getting sidetracked by this but still looking into it

@orestes, we would need an example to replicate it. There are various ways of setting timeouts. I am assuming you are using the CLI options but you would have to confirm. After that I can try it with the python SDK.

@jeronimoalbi @orestes any updates on this? This is causing important issues since the behaviour for middlewares is not stable.
@orestes I think this is SDK related, the following message is always shown when trying to retrieve the Service Schema from a middleware:
2017-07-19T18:28:44.628Z [ERROR] [SDK] Error running callback: request. Cannot get service schema. No mapping provided Error: Cannot get service schema. No mapping provided```
I've debugged this line https://github.com/kusanagi/katana-sdk-node/blob/master/sdk/api.js#L157 and the **servicesMapping** property is always empty.

Fixed by #18


Fix windows build issue

There was a couple of issues with the path resolutions when build was done in windows.
Added a fix for that.

Closes: https://github.com/TIBCOSoftware/flogo-cli/issues/46


fix(linter): fix fixer panic in typescript/consistent_indexed_object_style

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4165  👈
#4163
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


GTestAdapter

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.104%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
621

Relevant Lines:
633

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 97.262%

Files with Coverage Reduction
New Missed Lines
%

__w/mimicpp/mimicpp/include/mimic++/Reporter.hpp
8
96.4%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
675

Relevant Lines:
694

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 97.262%

Files with Coverage Reduction
New Missed Lines
%

__w/mimicpp/mimicpp/include/mimic++/Reporter.hpp
8
96.4%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
675

Relevant Lines:
694

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 97.695%

Files with Coverage Reduction
New Missed Lines
%

__w/mimicpp/mimicpp/include/mimic++/Reporter.hpp
5
97.75%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
678

Relevant Lines:
694

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 98.415%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
683

Relevant Lines:
694

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 98.413%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
682

Relevant Lines:
693

💛  - Coveralls


categorize configuration showed in vdk config-help

What is the feature request? What problem does it solve?
Many plugins can provide configuration variables for vdk. This can cause tens and even hundreds of configuration variables/options for users. Which are a lot. We need some way for users to be able to find those relevant for them and their current problems easier. Currently, users can see this by prefix (INGEST_XXX, DB_XXX, PRESTO_XXX). But this relies on all plugin developers following the pattern (which is not likely) and also does require manually searching for them (ctrl +f or using grep)
Suggested solution
Categorize configuration .
When adding new configuration https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/src/vdk/internal/core/config.py#L144 . User can set category.
If unset we can try to detect it using following options
A) Try to detect the plugin which adds it
B) try to detect the package which adds it.
We should allow for multiple categories.
Then users can do something like vdk config-help --category ingest - and it will show all ingest related variables.

Triaged. We will keep it, as being a feature that we would like to address.


Header: Choice of file format

I think this was probably discussed to some extent in earlier threads, but it's worth separating into its own thread and reaching a clear consensus.
In the current specification proposal, YAML is used for the header file. I think I had commented elsewhere that since BIDS uses JSON, many neuroimaging softwares will already have in place the requisite libraries for reading & writing JSON, and therefore using YAML instead may unnecessarily introduce a new dependency. From memory the primary argument for YAML was that it is supposedly more human-readable than JSON: I don't have a huge amount of experience with the YAML; personally I think JSON is "human readable enough".
Open to any and all opinions, or introduction of confounds that I've not thought of.

I was originally leaning towards YAML since it's supposed to be more human-readable, which I really value.  Having read a bit more about the format, I have to say that it's actually a bit of a dog's breakfast... This article goes through a lot of the issues. One of the key issues: it's actually far too complex - reflected in this quote from the article above:

The YAML spec is 23,449 words; for comparison, TOML is 3,339 words, JSON is 1,969 words, and XML is 20,603 words.

So on reflection, I would also support using JSON rather than YAML, on the grounds that it's actually far simpler to parse and validate.

I will switch back to json. These are good point, I personally like json too. I switched at the time because you proposed it and it took 5 minutes. I will make the changes soon.

Not advocating for it (I haven't used it yet) but I recently stumbled upon Hjson (Human JSON). It supports comments and is more human-proof (e.g., deals with missing commas).


Default scales in GUI

Flow:  -50     100
Volume   -200   800

Implemented in my working directory, will submit a pull request after a few other changes


build(wip): add scripts to generate list of custom errors/events and functions

WIP

What does this PR introduce?
📦 Build
Add custom scripts to export list of function selectors, errors selectors and event topic hashes.
These are extracted from the contract interfaces listed in the package in hardhat.config.ts + the Natspec comments are extracted from the build info of each contract sources.


Search: trigger the modal with a modifier (e.g. Ctrl + K)

In #56 we implemented a way to change the key used to show the modal. However, it does not allow to define a modifier like Ctrl, Shift or Meta. It would be good to add another attribute show-modal-modifier to specify this.

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode

Take a look at this comment, https://github.com/readthedocs/readthedocs-client/pull/58#discussion_r1179633226

This can now be done with the hotkeys addon by defining the API response as Ctrl + k 😉
The question about if it's useful to make this configurable via HTML attributes still remains, tho: https://github.com/readthedocs/addons/issues/43#issuecomment-1715449663


Allow icon button constructor to specify a left or right icon

Currently we can not create Buttons with an icon at the right, well we can if we build it by our own, but flutter already have one constructor to help with that, the missing part is that it only allows you to put icons at the left of the button.
I was thinking to add the code and create a PR so I wanted to get some feedback before.
Current
FlatButton or others have a named constructor FlatButton.icon which lets you specify an icon.
This icon is always on the left, the code looks like:
https://github.com/flutter/flutter/blob/8f3a12f1447b4baad06910eadd48b30a0a95e305/packages/flutter/lib/src/material/flat_button.dart#L300-L307
Expected
Have one way to show it in the left or in the right, possible options:

Add two named constructors, leftIcon and rightIcon.
Add two parameters, leftIcon and rightIcon and only one of those can be supplied.

allow icon button to align in left or right side

I think this is important, I may be able to do a pull request.

Add two parameters, leftIcon and rightIcon and only one of those can be supplied.

I would prefer a boolean called isRightIcon by default false and is optional

How about a parameter for the IconButton called iconAlignment which takes an enum IconAlignment which could be either IconAlignment.left(the default) or IconAlignment.right?

How about a parameter for the button called iconAlignment which takes an enum IconAlignment which could be either IconAlignment.left(the default) or IconAlignment.right?

I think it will be a great solution and is scalable also. I will start working on it

One question though, since the IconAlignment will be used multiple times. Do I create a file for it or copy and paste it?

I think that should be defined at the same file as the class from which all buttons inherit their properties.
I'm not sure, but such change might require to be included twice in different places:

For old buttons(FlatButton, RaisedButton, and OutlineButton) in flutter/packages/flutter/lib/src/material/button.dart.
For new buttons(TextButton, ElevatedButton, and OutlinedButton) in flutter/packages/flutter/lib/src/material/button_style_button.dart.

Also, it might be great if this change depends on directionality(LTR or RTL text direction).

@RoyARG02 can you take a look at my PR and suggest things if it is possible

Thanks @RoyARG02 for your efforts

Also, it might be great if this change depends on directionality(LTR or RTL text direction).

For RTL suport yuo can wrap a button with Directionality() widget and give it textDirection of TextDirection.rtl which makes everything start from right. That is why in PR I named the alignment properties start and end.

To reverse the default order in which the icon and label widgets appear, why not just write
TextButton.icon(label: bar, icon: foo)

instead of
TextButton.icon(label: foo, icon: bar)

Also noted here: https://github.com/flutter/flutter/pull/71984#issuecomment-758280967

To reverse the default order in which the icon and label widgets appear, why not just write
TextButton.icon(label: bar, icon: foo)

instead of
TextButton.icon(label: foo, icon: bar)

Also noted here: https://github.com/flutter/flutter/pull/71984#issuecomment-758280967

@HansMuller does it mess up the semantics?

All ButtonStyleButton widgets now have an iconAlignment property. Hence closing this issue.


pull request for e2e test at 12/13/2016 09:56:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fineract-1652: Account Balance and Transaction running balance is wrong

Description
FINERACT-1652.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[x] Create/update unit or integration tests for verifying the changes made.

[x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@logoutdhaval build is failing, please fix it first.

@logoutdhaval build is failing, please fix it first.

There are some issues with interest posting job with configuration set same as FINERACT-1652
I am working on that to make this PR mergeable.


[proposal] make name of new/make function consistent

Currently, there are various functions to construct the value of some types in moonbitlang/core:

T::new() T::make(): create a new collection without any arguments
T::with_capacity(capacity : Int), T::make(capacity : Int), T::new(~capacity): create a new collection with an initial capacity.
T::make(Int,T) T::new(Int,T): create a new collection with N initial elements.
T::make(Int,() -> T): create a new collection with N initial elements, all generated by a callback.
T::new_with_index(Int,(Int) -> T): create a new collection with n initial elements, each generated by the callback with an index parameter.

Proposed Naming Convention

Part 1. Use T::new(), T::new(~capacity), T::new(...) for:

Mutable collection types to create a new, empty collection without any argument, or with just one optional capacity argument.
Types with only one new/make function, e.g. Rational::new(Int64,Int64)

Part 2. Use T::make(Int,T), T::make_with(Int,() -> T), T::make_with_index(Int, (Int) -> T) for:

Collection types to return a new instance with N initial elements, where the elements can be generated by callback function. e.g. Array::make(Int,T) Bytes::make(Int, ~initial)

What could be the difference between Bytes::new(Int, ~initial) and T::make(Int,T)?

What could be the difference between T::new(...) (like Bytes::new(Int, ~initial)) and T::make(Int,T)?

Some mutable collections like Array, there are functions such as new(~capacity) and make(Int, T), Since function overloading is not allowed, they must have different names.  For types that have only one new/make function, and the function type does not resemble f(Int, T) -> Self, f(Int, () -> T) -> Self, or f(Int, (Int) -> T) -> Self, I suggest using the name new to ensure that the IDE completion can always provide a "constructor" when the user types T::new.

I'd suggest we only keep
make -> T::make_with(Int,() -> T) and makei -> T::make_with_index(Int, (Int) -> T)
which is also analogous to map and mapi

The make(Int,T) and make(Int,() -> T) is difference because the elements of first one are physically equal.

For 0 or 1 arguments, use new.
For 2 arguments, use make.
For standard library, user should able to "guess" what they are looking for, thus consistency > correctness, even consistently wrong! @bobzhang

make_with_index/capacity

[ ] deuqe
[ ] array
[ ] immut/array

[ ] UninitializedArray::make

[ ] arraycore: make_uninit -> new_uninit

per discussion with @bobzhang, for part 2, we will remove APIs like make_with and rename make_with_index to makei to align with map/mapi.


Bugfix ros timestamp humble

Also includes updated images in README and fixes from https://github.com/luxonis/depthai-ros/pull/198 and https://github.com/luxonis/depthai-ros/pull/212

@ros-pull-request-builder please test this PR.


Support explicit view title in left-hand sidebar?

Given the following DSL:
workspace {

    model {
        u = person "User"
        s = softwareSystem "Software System"

        u -> s "Uses"
    }

    views {
        systemContext s {
            include *
            autoLayout lr
            title "Foobar"
        }
    }
}

The explicitly defined view title 'Foobar' is honored in the view rendering but not in the LHS view list:

Is it possible to support both?

Look forward to seeing this when its ready! :)

Confirmed that this is working in the latest build... terrific! And thank you  :-)