Modify selection filter

1.Sort select filters;
2.Test and Fix errors;

Hello dd,do not directly submit code to the main branch please

ok ，i have changed submit it to dev.


Clients disconnecting from IoT Hub when publishing telemetry

I am encountering client disconnects when publishing telemetry and have 2 clients (1 device  and 1 module) publishing telemetry data.  I have increased Packet pool by ~25% (40 -> 48 packets) and increased NX_AZURE_IOT_TLS_PACKET_BUFFER_SIZE from 7kB to 10kB and the problem still persists.
My application:
NetxDUO v 6.1.7
STM32F429 host
Cellular network connection - x-cube-cellular 7.0.0
sample_azure_iot_embedded _sdk_with_retry .c  - edited to connect 1 module and 1 device client
The console out put is attached and also a snippet is provided below (Base is the device IoT client, VTL-1 is the module IoT client:
26-05-2022 / 16:37:40
Connected to IoTHub. Client name: Base
IoTHub Host Name: development1.azure-devices.net; Device ID: stm32F429_engg1.
Module ID: VTL-1.
26-05-2022 / 16:37:41
26-05-2022 / 16:37:41
26-05-2022 / 16:37:41
26-05-2022 / 16:37:42
26-05-2022 / 16:37:42
26-05-2022 / 16:37:43
26-05-2022 / 16:37:43
26-05-2022 / 16:37:43
26-05-2022 / 16:37:44
[INFO] Azure IoT Security Module message is empty
Connected to IoTHub. Client name: VTL-1
Disable Pre-emption for monitoring!: Thread Name: Demo
26-05-2022 / 16:37:45
26-05-2022 / 16:37:46
26-05-2022 / 16:37:46
26-05-2022 / 16:37:47
26-05-2022 / 16:37:48
Telemetry message send: Client: VTL-1, msg: {"Message ID":0}.
26-05-2022 / 16:37:49
26-05-2022 / 16:37:50
26-05-2022 / 16:37:51
26-05-2022 / 16:37:52
26-05-2022 / 16:37:53
Telemetry message send: Client: Base, msg: {"Message ID":1}.
Disconnected from IoTHub!: Client: Base, error code = 0x0002000c
Restoring Pre-emption for monitoring!: Thread Name: Demo
reconnecting iothub, after backoff
26-05-2022 / 16:37:54
26-05-2022 / 16:37:55
26-05-2022 / 16:37:56
26-05-2022 / 16:37:56
26-05-2022 / 16:37:57
26-05-2022 / 16:37:57
26-05-2022 / 16:37:58
Telemetry message send: Client: VTL-1, msg: {"Message ID":2}.
26-05-2022 / 16:37:58
26-05-2022 / 16:37:58
26-05-2022 / 16:37:59
26-05-2022 / 16:38:00
26-05-2022 / 16:38:01
Connected to IoTHub. Client name: Base
Disable Pre-emption for monitoring!: Thread Name: Demo
26-05-2022 / 16:38:02
Telemetry message send: Client: Base, msg: {"Message ID":3}.
26-05-2022 / 16:38:03
26-05-2022 / 16:38:04
26-05-2022 / 16:38:05
26-05-2022 / 16:38:05
26-05-2022 / 16:38:06
VTL-1 not connected, skipping telemetry
26-05-2022 / 16:38:07
26-05-2022 / 16:38:08
26-05-2022 / 16:38:09
26-05-2022 / 16:38:10
26-05-2022 / 16:38:11
26-05-2022 / 16:38:12
26-05-2022 / 16:38:13
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
26-05-2022 / 16:38:14
Disconnected from IoTHub!: Client: VTL-1, error code = 0x0002000c
Restoring Pre-emption for monitoring!: Thread Name: Demo
reconnecting iothub, after backoff

I have confirmed the following:

that if I disable the telemetry thread and only connect the 2 clients (device and module) I do not see any disconnects
Leave telemetry enabled and only enable the device client I do not see any disconnects

This testing points to a lack of memory allocation for some resource but I'm not sure which one to adjust. I reviewed the stack usage and didn't see anything out of the ordinary.
I have redacted the name of my iot hub but that can be provided by some other secure means for verification
Thanks
2 clients - frequent disconnects.txt
IoT Client source.zip

I have to mention to comment out the following 2 lines in sample_config.h to match the code to my output log
#define DISABLE_MODULE_CLIENTS
#define DISABLE_MODULE1

Hi @dsilva-vd I used your sample and I was able to reproduce this issue, after debugging, I found the issue that you used the same metadata buffer for both connections, then I changed the code (see attachment) using different metadata buffer for different connection, the sample works. Could you try it on your side?
sample_azure_iot_embedded_sdk_with_retry.zip

@bo-ms  THank you for the help. That did solve it and I found a copy paste error in my telemetry client when publishing data for the module client also
Just to confirm you created a second iot stack variable but you never used it in the code. Just confirming I didn't miss anything, correct?

@dsilva-vd  Good to know it works. I created a second stack and used it as below for a quick test.

Closing, @dsilva-vd feel free to reopen if you have any further issue.


auto array not working correctly

This test case generates bad code:
main() {
auto a[10];
a[1] = 1234;
putnumb(a[1]);
}

Oops. No push access to outsiders.
I have fix in hand.

In file b0.c, routine defvec(), edit the first printf() statement:
old:   printf("\t%%esp,%%eax\n");
new: printf("\tmov\t%%esp,%%eax\n");
In file b0.c, routine blkhed(), add the following after the call to defvec()
new: bs->offset = al;

Regards,
jm-mh

Thanks for catching that, applied your fix now. It's been a while since I've worked on this code so I just trust your patch works.


Fix patient print

Coverage increased (+0.02%) to 57.67% when pulling 018fab6fffabbad400ae325cf7d6b72655b0093d on ynurmahomed:fix-print into 98005518b93d8b035c4e8efc4220d0937d2ecb97 on esaude:master.

@edrisse can you review? :grin:


Seems it doesn't work with Cyberark version 10.2

Hi All,
I previously used "Accounts_Onboard_Utility.ps1" script with version 9.10 and 10.1 as well, It was working fine.
However recently i migrated to 10.2 and it seems script is not working any longer, every time i get below error message :
Logon Token is empty : Cannot logon.
I have tried with Swagger UI with 10.2 and i am able to get token and perform further activities.
Has anyone tested this with version 10.2 yet ?
Any help will be much appreciated in this regard.

Hello @Sunil20noi ,
Thanks for letting us know.
Did you change the logon URL?
Or are you using the same as in the script?
Thanks,
Assaf

Hi Assaf,
I have tried with both with same result:

Using the same as in script as https://X.X.X.X/PasswordVault/WebServices/auth/Cyberark/CyberArkAuthenticationService.svc/Logon

URL taken from Swagger and hardcoded in script as
https://X.X.X.X/PasswordVault/api/Auth/cyberark/Logon

Am i missing something here, has anything changed in 10.2 ?
Thanks
Sunil

Hi @Sunil20noi ,
From your examples above, I assume that you are using IP Address and HTTPS.
Does your SSL certificate include the IP address of the server or only the name?
Try running the script in Verbose mode (just add -Verbose to the end of the command), you might see the following message:
The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
If this is the case, try running the script with a PVWA URL that matches the SSL certificate
Please update us if that solves this issue
Thanks,
Assaf

Hey Sunil,
since you are using the new authentication module, the token response has change.
Can you please change the following line in the Get-LogonHeader function:
$logonToken = $logonResult.CyberArkLogonResult
to:
$logonToken = $logonResult
and try again?
Thanks,
Assaf

Hi Assaf,
After doing above changes it seems to be working. But let me carry out complete testing and i will let you know the outcome.
However, any idea how many calling API URL cyberark has changed, i could change logon and logoff url in script.
Regards
Sunil

Hi Sunil/Assaf,
I am new in scripting so please help me on this. I am getting bellow error.
Invoke-Rest : Not Found
At E:\DOC\Documentation\10.3\API\My API Script\epv-api-scripts-master\Create_User_and_Add_as_Owner_to_Safes.ps1:101 char:18

... gonResult = Invoke-Rest -Command Post -Uri $URL_CyberArkLogon -Body $ ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Invoke-Rest

Logon Token is Empty - Cannot login


Change frame height of extension view after using setExtensionView

When I change the height of the extension view after calling setExtensionView, the contractionAmount and expandCenter of extensionController remain unchanged.
What should I do after updating the extension view frame height?

I had the same problem, but I just took the same approach as you would a table view header, i.e. you remove it then re-add it, worked fine for me:
[self.shyNavBarManager setExtensionView:nil];

Change header height....

[self.shyNavBarManager setExtensionView:header];


"Uncaught ReferenceError" webpack compatibility

that's not a sheet-router issue
https://github.com/yoshuawuyts/sheet-router/issues/28
node v4.4.7 (npm v2.15.8)
webpack 1.13
{
  "name": "webpack-choo-testfield",
  "version": "1.0.0",
  "description": "",
  "main": "./src/loader.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "dev": "webpack-dev-server"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "autoprefixer": "^6.3.7",
    "babel-core": "^6.10.4",
    "babel-loader": "^6.2.4",
    "babel-plugin-transform-runtime": "^6.9.0",
    "babel-preset-es2015": "^6.9.0",
    "babel-preset-stage-0": "^6.5.0",
    "coffee-loader": "^0.7.2",
    "coffee-script": "^1.10.0",
    "css-loader": "^0.23.1",
    "exports-loader": "^0.6.3",
    "extract-text-webpack-plugin": "^1.0.1",
    "handlebars": "^4.0.5",
    "handlebars-loader": "^1.3.0",
    "html-webpack-plugin": "^2.22.0",
    "nib": "^1.1.0",
    "postcss-loader": "^0.9.1",
    "postcss-short": "^1.4.0",
    "raw-loader": "^0.5.1",
    "style-loader": "^0.13.1",
    "stylus": "^0.54.5",
    "stylus-loader": "^2.1.1",
    "webpack": "^1.13.1",
    "webpack-dev-server": "^1.14.1"
  },
  "dependencies": {
    "babel-polyfill": "^6.9.1",
    "babel-runtime": "^6.9.2",
    "choo": "^3.0.2",
    "faker": "^3.1.0",
    "lodash": "^4.13.1",
    "moment": "^2.14.1"
  }
}

Tbh I've got no idea what kind of black magic webpack pulls to overload require in Node and render applications. As a maintainer I really don't want to deal with webpack because of issues like this.
I'd be happy to recommend alternative tools such as budo. Perhaps someone else has interest in both webpack and choo and is willing to dig into this, but that person is not me. Sorry about that, and heaps good luck!

FWIW, I had a issue running choo with webpack when the devtool was set to eval. I changed it to source-map and things started working fine.

thanks @drewschrauf
i ll try it~

it works~

i've tested, that is a chrome bug
https://github.com/webpack/webpack/issues/2756#issuecomment-232272889
with cheap-eval safari work


UIImage+Filter.m category conflicts with standard UIControls

This category method:
@implementation NGImage (Filter)
- (CIImage *)CIImage {
  return [CIImage imageWithCGImage:self.CGImage];
}

Has problems with views containing either UISegmentedControl or UISwitch.
For UISegmentedControl, under iOS 8 there is a crash (EXC_BAD_ACCESS inside [UIImage imageWithRenderingMode:]). Under iOS 7 there is no crash, but the UISegmentedControl is badly rendered onscreen.
For UISwitch, under iOS 8 the switch is rendered badly onscreen.
I've created a small sample project that illustrates these issues. (It currently contains a UISegmentedControl in its main storyboard. You can replace that with a UISwitch to confirm the iOS 8 issue there.)
I'm wondering whether the - (CIImage *)CIImage method is still necessary under iOS 7 and/or 8. Perhaps it can be conditionally compiled, or eliminated altogether?

@dgoldman-ebay I apologize—my company email address changed and it resulted in some dropped Github notifications.
Does this issue remain?

Thanks for catching this, @jameswomack.
I don't know of anything relevant that might have changed in the past couple of weeks, so I presume that the problem remains, as described above.

@dgoldman-ebay Still looking into the matter. This may be relevant in the interim: https://stackoverflow.com/questions/26065808/bsxpcmessage-received-error-for-message-connection-interrupted

@dgoldman-ebay I can see that Apple has now implemented some of the methods from this project. That's what's causing this issue and I'll get it fixed.

Using a category method seems to fix it. I've committed this change.

Thanks, @jameswomack, I appreciate your effort. I'll give your new code a try tomorrow.
At first glance it looks like you're using a compile-time test to determine whether to proceed as for iOS 8 or for pre-iOS 8. But since the same binary might be run on any version of iOS, don't you need a runtime test instead? (Also, see the original description above re iOS 7 rendering issues.)

@dgoldman-ebay Code updated, and now also published to CocoaPods. There's no longer a build-time check. I haven't seen any rendering issues on 7 or 8 since I namespace CIImage and imageClampingToExtent.

Looks good, @jameswomack! Thanks.


Error: couldn't find version "1.18.3" for platform "darwin/arm64"

Describe the bug
I do not have an Envoy configuration file, so I am using the option to start the admin port. When I run func-e run using the JSON provided in the documentation, I get an error.
To Reproduce
Steps to reproduce the behavior:

Run curl https://func-e.io/install.sh | bash -s -- -b /usr/local/bin to install func-e
Run func-e run --config-yaml "admin: {address: {socket_address: {address: '<IP_ADDRESS>', port_value: 9901}}}" to use the admin port

Expected behavior
I expected to get the latest version of Envoy. MacOS should be able to run application for amd64 on Rosetta 2.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the relevant information):

OS: MacOS 11.3.1 (M1)
Envoy Version: n/a

To get around this issue, we created our own manifest file and added an entry for arm64 that simply pointed to the amd64 binary. It's a hack but a workaround.
$ export ENVOY_VERSION_URL=https://raw.githubusercontent.com/hashicorp/demo-consul-101/5845000a614aae67c4d94edba2f9ecc2f1a737a6/envoy-manifest.json
$ curl https://func-e.io/install.sh | bash -s -- -b /usr/local/bin
$ func-e run --config-yaml "admin: {address: {socket_address: {address: '<IP_ADDRESS>', port_value: 9901}}}"

maninfest.json
{
  "latestVersion": "1.18.3",
  "versions": {
    "1.18.3": {
      "releaseDate": "2021-05-11",
      "tarballs": {
        "darwin/amd64": "https://archive.tetratelabs.io/envoy/download/v1.18.3/envoy-v1.18.3-darwin-amd64.tar.xz",
        "darwin/arm64": "https://archive.tetratelabs.io/envoy/download/v1.18.3/envoy-v1.18.3-darwin-amd64.tar.xz",
        "linux/amd64": "https://archive.tetratelabs.io/envoy/download/v1.18.3/envoy-v1.18.3-linux-amd64.tar.xz",
        "linux/arm64": "https://archive.tetratelabs.io/envoy/download/v1.18.3/envoy-v1.18.3-linux-arm64.tar.xz",
        "windows/amd64": "https://archive.tetratelabs.io/envoy/download/v1.18.3/envoy-v1.18.3-windows-amd64.tar.xz"
      }
    }
  },
  "sha256sums": {
    "envoy-v1.18.3-darwin-amd64.tar.xz": "cb27be135f0d48167b756d17fa9117ed6295ee3f69e4db7900b94ddffef463e1",
    "envoy-v1.18.3-darwin-arm64.tar.xz": "cb27be135f0d48167b756d17fa9117ed6295ee3f69e4db7900b94ddffef463e1",
    "envoy-v1.18.3-linux-amd64.tar.xz": "10e1c6bc354018578f02c97358d3bbc9a26d4989cf752963611e69dac52656f4",
    "envoy-v1.18.3-linux-arm64.tar.xz": "367d61bf246d56cc24949574977edefa4649ad2072c08d57a8bd63c44d991d25",
    "envoy-v1.18.3-windows-amd64.tar.xz": "1274f55b3022bc1331aed41089f189094e00729981fe132ce00aac6272ea0770"
  }
}

interesting and wow thanks for sharing. I didn't know about this work-around.
Is there a way we can detect presence of Rosetta until someone fixes the envoy build and make arm64 work by default cc @musaprg
easy ways would be a file with a stable path, an ENV variable or output from a command like uname that would change if Rosetta 2 is installed

I found this, though it might be a little hairy because for example, envoy should be fixed at some point and we'd have to know that the intent is to run emulated or not.
https://github.com/electron-userland/electron-builder/blob/71d37044d348ab0cd8f0f9f7754bf6ebaa4b996c/packages/electron-updater/src/MacUpdater.ts#L33-L41

one way is we could force the platform. This would remove ambiguity at the cost of being explicit. @trujillo-adam would you hate it if you specified --platform darwin/amd64 or some env? At least until we find a solid way to detect and test this..

@codefromthecrypt We discussed this option, and we think having the ability to specify a platform would be neat. This could be an environment variable. Adding it as an environment would be pretty easy to implement.

cool. let's do it now a global flag (app.go) and carried around in GlobalOpts. Global flag avoids mushing flags envoy should read and also makes sure use and list operate properly.
ex --platform and FUNC_E_PLATFORM which populate GlobalOpts.Platform, defaulted to GlobalOpts.CurrentPlatform. GlobalOpts.CurrentPlatform is no longer read at call sites because GlobalOpts.Platform is
would you like to go for it or should I?

@codefromthecrypt I might be wrong, but I think we still need to add some logic to installIfNeeded(), mainly because of this logic:

		tarballURL := ev.Versions[v].Tarballs[p] // Ensure there is a version for this platform
		if tarballURL == "" {
			return "", fmt.Errorf("couldn't find version %q for platform %q", v, p)
		}

It can default to GlobalOpts.Platform

The main logic change is signatures like this:
o, globals.CurrentPlatform

to
o

as o.Platform will be available. In other words the result of this change is that globals.CurrentPlatform is only read once, to default the flag when empty. To do that indeed is some signature refactoring!

all logic is intentionally internal, so it isn't a problem to change the signatures in other words, even on a patch release.


fsr causes heavy aliasing

when i use fsr it cause aliasing and ways to fix it and is sharping not part of fsr

No logs = no help


Custom validation?

simple-mongo-schema supports only a few validation options. Adding support for your own validation method is a must I think.
BTW, great project, I was looking for something simple and clean like this :)

Good idea, will be best to add this functionality into simple-mongo-schema and then it will automatically be available in Robe.

Am closing this, tracking in hiddentao/simple-mongo-schema#1


Missing **kwargs

/Users/deissim/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/decorator.rb:16: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/deissim/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/decorator/invocation_tracker.rb:10: warning: The called method `method_missing' is defined here

I should also mention that we did a bunch of work to fix the keyword arg warnings in factory_bot 6.1.0 (https://github.com/thoughtbot/factory_bot/pull/1415), so if you haven't upgraded to that version you may need to do so.


Beheim/release0.7

Documenting the features coming in with 0.7

Docs Build status updates of commit eaa3d04:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/language/type-model.md
:warning:Warning

Details

articles/techniques/toc.yml
:warning:Warning

Details

articles/language/expressions.md
:white_check_mark:Succeeded

articles/language/statements.md
:white_check_mark:Succeeded

articles/techniques/operations-and-functions.md
:white_check_mark:Succeeded

articles/techniques/type-model.md
:white_check_mark:Succeeded

articles/language/type-model.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.language.statements".

articles/techniques/toc.yml

Line 0: [Warning] Invalid file link:(~/techniques/type-model.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d02355e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/language/type-model.md
:warning:Warning

Details

articles/techniques/toc.yml
:warning:Warning

Details

articles/language/expressions.md
:white_check_mark:Succeeded

articles/language/statements.md
:white_check_mark:Succeeded

articles/techniques/operations-and-functions.md
:white_check_mark:Succeeded

articles/techniques/type-model.md
:white_check_mark:Succeeded

articles/language/type-model.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.language.statements".

articles/techniques/toc.yml

Line 0: [Warning] Invalid file link:(~/techniques/type-model.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d02355e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/language/type-model.md
:warning:Warning

Details

articles/techniques/toc.yml
:warning:Warning

Details

articles/language/expressions.md
:white_check_mark:Succeeded

articles/language/statements.md
:white_check_mark:Succeeded

articles/techniques/operations-and-functions.md
:white_check_mark:Succeeded

articles/techniques/type-model.md
:white_check_mark:Succeeded

articles/language/type-model.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.language.statements".

articles/techniques/toc.yml

Line 0: [Warning] Invalid file link:(~/techniques/type-model.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Looks good to me, other than the two broken links from the build report (see below). Marking as requesting changes for those two links.

Docs Build status updates of commit f62b924:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/language/type-model.md
:warning:Warning

Details

articles/language/expressions.md
:white_check_mark:Succeeded

articles/language/statements.md
:white_check_mark:Succeeded

articles/techniques/operations-and-functions.md
:white_check_mark:Succeeded

articles/techniques/toc.yml
:white_check_mark:Succeeded

articles/techniques/type-model.md
:white_check_mark:Succeeded

articles/language/type-model.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.language.statements".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit f62b924:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/language/type-model.md
:warning:Warning

Details

articles/language/expressions.md
:white_check_mark:Succeeded

articles/language/statements.md
:white_check_mark:Succeeded

articles/techniques/operations-and-functions.md
:white_check_mark:Succeeded

articles/techniques/toc.yml
:white_check_mark:Succeeded

articles/techniques/type-model.md
:white_check_mark:Succeeded

articles/language/type-model.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.language.statements".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 178e437:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/language/type-model.md
:warning:Warning

Details

articles/language/expressions.md
:white_check_mark:Succeeded

articles/language/statements.md
:white_check_mark:Succeeded

articles/techniques/operations-and-functions.md
:white_check_mark:Succeeded

articles/techniques/toc.yml
:white_check_mark:Succeeded

articles/techniques/type-model.md
:white_check_mark:Succeeded

articles/language/type-model.md

[Warning] 1 invalid cross reference(s) "microsoft.quantum.language.statements".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fixed #27392 -- Remove "Tests that", "Ensures that", etc. from test docstings

I am re-working on this PR 8648.

Closing due to inactivity.


Add selection to DataView

RHCLOUD-32251

added selection to DataView using the BulkSelect from component-groups
enhanced the docs and examples
added test coverage

Preview: https://react-data-view-pr-data-view-9.surge.sh


Improve setup documentation

Need to add database setup info and probably some other stuff.

This will be easier once #85 and the sqlite PR are in. I can do the rest of the setup docs, all I would need from you is a base database structure (sql dump without the actual data in). Would you be able to throw that over some time?

Yeah, sure!


Feature Idea: Every Return Statement needs a comment

Sometimes i'm not sure what is being returned from a method, or even what a return statement is.
Comments can clear this up for us. I've seen this in the wild, and I think every codebase would benefit from enforcing describing how a method exits.

I'll open up another feature idea enforcing every try should have an empty catch block.

Comments can clear this up for us. I've seen this in the wild, and I think every codebase would benefit from enforcing describing how a method exits.

Understanding fundamental language syntax is an incredibly unfair expectation to have for professional enterprise software developers. Having comments each time we do something is a good idea.


ModuleNotFoundError: No module named 'ofa.imagenet_codebase'

I encounter an error again when searching. An error is reported when the configured ofa version is ofa 0.1.0-202012082159. Then try ofa 0.0.4-2012082155 but the same error still occurs.
Traceback (most recent call last):
File "msunas.py", line 8, in
from evaluator import OFAEvaluator, get_net_info
File "/data8T/nsganetv2-master/evaluator.py", line 8, in
from codebase.networks import NSGANetV2
File "/data8T/nsganetv2-master/codebase/networks/init.py", line 1, in
from ofa.imagenet_codebase.networks.proxyless_nets import ProxylessNASNets, proxyless_base, MobileNetV2
ModuleNotFoundError: No module named 'ofa.imagenet_codebase'

@mikelzc1990

I tried a lower version of OnceForALL, the above problem no longer appears, but a new error appears. Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
My current pytorch version is 1.6.0. It may be a problem with the pytorch version. I try to use pytorch 1.5.1.
In addition, another error occurred:
Traceback (most recent call last):
File "msunas.py", line 355, in
main(cfgs)
File "msunas.py", line 310, in main
engine.search()
File "msunas.py", line 79, in search
acc_predictor, a_top1_err_pred = self._fit_acc_predictor(archive)
File "msunas.py", line 180, in _fit_acc_predictor
acc_predictor = get_acc_predictor(self.predictor, inputs, targets)
File "/data8T/nsganetv2-master/acc_predictor/factory.py", line 6, in get_acc_predictor
acc_predictor.fit(inputs, targets)
File "/data8T/nsganetv2-master/acc_predictor/rbf.py", line 29, in fit
dim=train_data.shape[1], kernel=kernel(), tail=tail(train_data.shape[1]))
TypeError: init() missing 2 required positional arguments:'lb' and'ub'
@mikelzc1990

I tried a lower version of OnceForALL, the above problem no longer appears, but a new error appears. Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.
Try to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.
My current pytorch version is 1.6.0. It may be a problem with the pytorch version. I try to use pytorch 1.5.1.
In addition, another error occurred:
Traceback (most recent call last):
File "msunas.py", line 355, in
main(cfgs)
File "msunas.py", line 310, in main
engine.search()
File "msunas.py", line 79, in search
acc_predictor, a_top1_err_pred = self._fit_acc_predictor(archive)
File "msunas.py", line 180, in _fit_acc_predictor
acc_predictor = get_acc_predictor(self.predictor, inputs, targets)
File "/data8T/nsganetv2-master/acc_predictor/factory.py", line 6, in get_acc_predictor
acc_predictor.fit(inputs, targets)
File "/data8T/nsganetv2-master/acc_predictor/rbf.py", line 29, in fit
dim=train_data.shape[1], kernel=kernel(), tail=tail(train_data.shape[1]))
TypeError: init() missing 2 required positional arguments:'lb' and'ub'
@mikelzc1990

Hey, missing the lb and ub do you solve them?

did you solve this?

Try this version:
pip install git+https://github.com/mit-han-lab/once-for-all@afdb78dea1ca0c12a7cb8f803ac7a576cac7ce18

I had a similar problem, maybe it's because the module you need is not in ofa.imagenet_codebase, I suggest you check the module location.

I encounter an error again when searching. An error is reported when the configured ofa version is ofa 0.1.0-202012082159. Then try ofa 0.0.4-2012082155 but the same error still occurs. Traceback (most recent call last): File "msunas.py", line 8, in from evaluator import OFAEvaluator, get_net_info File "/data8T/nsganetv2-master/evaluator.py", line 8, in from codebase.networks import NSGANetV2 File "/data8T/nsganetv2-master/codebase/networks/init.py", line 1, in from ofa.imagenet_codebase.networks.proxyless_nets import ProxylessNASNets, proxyless_base, MobileNetV2 ModuleNotFoundError: No module named 'ofa.imagenet_codebase'

I had a similar problem, maybe it's because the module you need is not in ofa.imagenet_codebase, I suggest you check the module location.


Personalization examples

Based on the user's logged-in state, fetch personalized recommended products, last viewed products, "buy again" for past purchases

As part of this, also update the amp-access page to be inclusive of non-publisher related sign-in flows: https://ampbyexample.com/components/amp-access/


Add retry-after header

That header is standard, and crawling bots (including feed readers)
honor this header properly compared to x-headers
Fix #38

I think this PR should also update GovernorConfigBuilder::use_headers method documentation
https://github.com/benwis/tower-governor/blob/e6781a7f7582020cdae8f230345d03731cca4324/src/governor.rs#L233-L242

see #44


ValueError: 'twitter.com' does not appear to be an IPv4 or IPv6 address

Issue Template
Please use this template!
Initial Check

If the issue is a request please specify that it is a request in the title (Example: [REQUEST] more features). If this is a question regarding 'twint' please specify that it's a question in the title (Example: [QUESTION] What is x?). Please only submit issues related to 'twint'. Thanks.

Make sure you've checked the following:

[] Python version is 3.6;
[] Updated Twint with pip3 install --user --upgrade -e git+https://github.com/twintproject/twint.git@origin/master#egg=twint;
[] I have searched the issues and there are no duplicates of this issue/question/request.

Command Ran

Please provide the exact command ran including the username/search/code so I may reproduce the issue.
https://colab.research.google.com/drive/1AOXQxkOWbq7KEHWVBRiOrYhTOSg3QTqq#scrollTo=1lZrarvrzsVT
from https://github.com/twintproject/twint-utils/blob/master/mufos.py

and twint -u NullByte
Description of Issue

Please use as much detail as possible.

finding followers...(ignore errors)

CRITICAL:root:twint.get:User:'str' object has no attribute 'isascii'

---------------------------------------------------------------------------

ValueError                                Traceback (most recent call last)

/usr/local/lib/python3.6/dist-packages/yarl/__init__.py in _encode_host(cls, host)
    666             ip, sep, zone = host.partition("%")
--> 667             ip = ip_address(ip)
    668         except ValueError:

17 frames

ValueError: 'mobile.twitter.com' does not appear to be an IPv4 or IPv6 address

During handling of the above exception, another exception occurred:

AttributeError                            Traceback (most recent call last)

/usr/local/lib/python3.6/dist-packages/yarl/__init__.py in _encode_host(cls, host)
    669             # IDNA encoding is slow,
    670             # skip it for ASCII-only strings
--> 671             if host.isascii():
    672                 return host
    673             try:

AttributeError: 'str' object has no attribute 'isascii'

cli example:
twint -u NullByte
CRITICAL:root:twint.get:User:'str' object has no attribute 'isascii'
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/yarl/__init__.py", line 667, in _                                                               encode_host
    ip = ip_address(ip)
  File "/usr/lib/python3.6/ipaddress.py", line 54, in ip_address
    address)
ValueError: 'twitter.com' does not appear to be an IPv4 or IPv6 address

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/twint", line 11, in <module>
    sys.exit(run_as_command())
  File "/usr/local/lib/python3.6/dist-packages/twint/cli.py", line 303, in run_a                                                               s_command
    main()
  File "/usr/local/lib/python3.6/dist-packages/twint/cli.py", line 295, in main
    run.Search(c)
  File "/usr/local/lib/python3.6/dist-packages/twint/run.py", line 292, in Searc                                                               h
    run(config, callback)
  File "/usr/local/lib/python3.6/dist-packages/twint/run.py", line 213, in run
    get_event_loop().run_until_complete(Twint(config).main(callback))
  File "/usr/lib/python3.6/asyncio/base_events.py", line 484, in run_until_compl                                                               ete
    return future.result()
  File "/usr/local/lib/python3.6/dist-packages/twint/run.py", line 154, in main
    await task
  File "/usr/local/lib/python3.6/dist-packages/twint/run.py", line 198, in run
    await self.tweets()
  File "/usr/local/lib/python3.6/dist-packages/twint/run.py", line 137, in tweet                                                               s
    await self.Feed()
  File "/usr/local/lib/python3.6/dist-packages/twint/run.py", line 57, in Feed
    response = await get.RequestUrl(self.config, self.init, headers=[("User-Agen                                                               t", self.user_agent)])
  File "/usr/local/lib/python3.6/dist-packages/twint/get.py", line 119, in Reque                                                               stUrl
    response = await Request(_url, params=params, connector=_connector, headers=                                                               headers)
  File "/usr/local/lib/python3.6/dist-packages/twint/get.py", line 147, in Reque                                                               st
    return await Response(session, url, params)
  File "/usr/local/lib/python3.6/dist-packages/twint/get.py", line 152, in Respo                                                               nse
    async with session.get(url, ssl=True, params=params, proxy=httpproxy) as res                                                               ponse:
  File "/usr/local/lib/python3.6/dist-packages/aiohttp/client.py", line 1012, in                                                                __aenter__
    self._resp = await self._coro
  File "/usr/local/lib/python3.6/dist-packages/aiohttp/client.py", line 380, in                                                                _request
    url = URL(str_or_url)
  File "/usr/local/lib/python3.6/dist-packages/yarl/__init__.py", line 170, in _                                                               _new__
    val.username, val.password, host, port, encode=True
  File "/usr/local/lib/python3.6/dist-packages/yarl/__init__.py", line 688, in _                                                               make_netloc
    ret = cls._encode_host(host)
  File "/usr/local/lib/python3.6/dist-packages/yarl/__init__.py", line 671, in _                                                               encode_host
    if host.isascii():
AttributeError: 'str' object has no attribute 'isascii'

Environment Details

jupyter notebook
same/similar things happend when using win10 and ubuntu18.04 (python3.6.9)
also ocurred when trying to use cli
same thing happend when trying to use the container version https://github.com/twintproject/twint-docker

The error that you are having seems not to be related to Twint itself


python311Packages.llama-index-core: 0.10.46 -> 0.10.47

Diff: https://github.com/run-llama/llama_index/compare/refs/tags/v0.10.46...v0.10.47
Changelog: https://github.com/run-llama/llama_index/blob/0.10.47/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Record with a parent is deleted/suppressed in the varfields/fixed fields indexes

This would be useful – you could filter out values that will never be used to build wc.org/works.

Closing – this is less possible than I thought it was, e.g. an item that's linked to a deleted bib.


[Feature] listing apps for RESIDENT/NORMAL modes

Hi,
This is a suggestion for making the integration of win-vind in Windows more streamlines. The idea is to filter/define the specific apps in which win-vind will automatically enter RESIDENT mode and with it will automatically enter INSERT mode. This mechanism already works when switching to a vim app, where there is no need for win-vind to work, and it automatically switches to RESIDENT. Having a full control on the apps for which either INSERT / RESIDENT modes are turned on would make it ideal.
I think this would make the ongoing use of win-vind easy and fault-free. For example, I definitely need win-vind to work when I type documents in Microsoft Word, but when not when I switch to Adobe Acrobat and not when I switch to a web browser. When I switch back to Word, it would be ideal to have win-vind automatically turn on in INSERT mode so I can start working with it again. A lot of issues with the <esc> mapping for switching modes would naturally be resolves this way.
The implementation can be simple, with allowing to define a "default" mode for win-vind on entry to an app for which no specific mode was specified, as in:
set default_mode = to_resident

and then allow to define specific apps for specific modes, as in:
set to_insert_apps = [LIST OF APPS]

With the above, easy implementation, I could navigate freely between apps and putting to use win-vind seamlessly.
I hope this makes sense. Let me know your thoughts.
Love win-vind!
Best
Gil

Thanks for the suggestion. This seems to make a lot of sense. The current automatic mode change is terrible, like a toy, so needs to be enhanced.
I have two concerns.

whether each name of applications should be executable name, or full path, etc.
how to represent the listings. For example, in .vimrc notation, we write list something like set fileformats=unix,dos,mac, but in Vim script it is let v=[a, b, c].

In my opinion, it is better to use 1 is a regular expression for the path, and 2 should be the same notation as in .vimrc.
Please let me know your opinion.
Thanks.

Now, let's make 1) an exe name so that it will be recognized as a path if we put / or \\.
With 2), the .vimrc format is used for arrangewin_ignore.
ref. https://pit-ray.github.io/win-vind/cheat_sheet/options/
Thanks.

Yes, both of these look good to me!

(#89, #100)
I plan to employ automatic commands using events like Vim.
For example, in the following format.
autocmd AppSelect edge to_insert
autocmd AppSelect mspaint.exe to_gui_normal
autocmd AppSelect "C:\Program Files\Mozilla Firefox\firefox.exe" to_resident

Yes, looks great. But is it still possible to list more than one app for one autocmd?

Also, might add 'AppSelectDefault' for catchall/default mode, for all the apps that are not specified?

With 'AppSelectDefault' no app should be specified, only the default mode:
'autocmd AppSelectDefault to_insert'

@gilbh
How about using regular expressions like in Vim?
autocmd AppSelect * to_insert
autocmd AppSelect *vim to_resident

I think that is a bit confusing, for the following reasons:

The above two lines are not mutually exclusive: * includes *vim.
The wildcard * could potentially clash with a path specification.
It is unclear how to list multiple items.

I would suggests going with the previous system.
Let me know your thoughts.
best!

@gilbh
After careful consideration, the default value using autocmd AppSelect *was indeed a bad idea.
I want Vim users not to have to learn anything new, so I would to avoid the concept of Default as much as possible.
How about the following style command?
" .vindrc
autocmd WinLeave * to_insert
autocmd WinEnter "C:\Program Files\Mozilla Firefox\firefox.exe" to_resident
autocmd WinEnter vim to_resident
autocmd WinEnter notepad.exe to_edi_normal

It is similar to Vim notation.
" .vimrc
autocmd WinLeave * stopinsert
autocmd WinEnter *.txt startinsert

Thanks.

Yes, this looks really good! Thanks for developing this.

Now then, I'll implement along this policy.

@gilbh @alexn-s
Implemented in 5.3.0.

I am testing now 5.3.0 and I have a few questions:

This works:

autocmd AppEnter *notepad* <to_edi_normal>

-- but this doesn't:
autocmd AppEnter notepad.exe <to_edi_normal>

Is this deliberate or a bug?

How to specify multiple apps in one autocmd line?

There is a bug (not sure if always reproducible). From the first time I enter notepad and vind switched to NORMAL, it will happens on any  switching, and also on  (switching to desktop). I am getting NORMAL switch from that moment onward  on any app switch ...

Thanks!!

@gilbh
Thank you for trying this feature.
1, 2.
It was neither a bug nor an intended one, and was not implemented. I will add it in the next version.
3.
This is a bug that only occurs when switching to desktop. I will fix it.

Fixed in v5.4.0


always reload page after blocks created and modal closed

Not nice having to go around so many corners, but at least it is working in my tests.


Clarification:

It seems that the output  ( I used: python Exporter.py --username 'barackobama' --maxtweets 100) returns tweets by other users @barackobama instead of tweets by barackobama. Is it possible to get tweets by the user using this?

Hi @ksk438, thanks for your issue, it seems that twitter changed a little bit the search behavior, you can try without quotes that you get your desired results (python Exporter.py --username barackobama --maxtweets 100). I will fix it in the code next update.

I have updated the repo @ksk438, now it should work fine even with quotes.

Great! Will take a look when I have a moment
On Sep 8, 2016 4:55 PM, "Jefferson Henrique"<EMAIL_ADDRESS>wrote:

Closed #29
https://github.com/Jefferson-Henrique/GetOldTweets-python/issues/29.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jefferson-Henrique/GetOldTweets-python/issues/29#event-783063747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU_5REPpCLhhesZ0YtBG2rEku9ONmjpyks5qoHZUgaJpZM4J1bV1
.


Short dates in ScheduleFragment

Actual Behaviour
In ScheduleFragment the TabTitles are complete dates eg 2017-03-17.
Expected Behaviour
It is better if we ignore the year and display the name of the month eg 17 Mar
Screenshots of the issue
Proposed style

Would you like to work on the issue?
I have solved the issue but cannot send a PR. My laptop is not connecting to the internet. Please assign this to someone else.

I'd like to do it

@iamareebjamal
Make sure if the date is 03 Jan it is displayed as 3 Jan.
Actually, I missed that.

Ok. Thanks for the suggestion @free4murad


iterative.ai mlem.api.save() | AttributeError: name. Did you mean: 'ne'?

Goal: Save a model as a mlem model, without sample_data.
I plan on loading in mlem model files, in deployment, like so:
from mlem.api import load

model = load('models/mlem-model')

To do this, I need to load in existing models and then save() them as a mlem model.
save() creates a model binary and a mlem metadata file.
models/
    ├── mlem-model
    └── mlem-model.mlem

I've trained models, so don't pass sample_data as a paramter to save().

Code
from fastai.vision.all import *
import mlem

model = load_learner('models/model.pkl', cpu=True)
model.load('models/weights.pth')

mlem.api.save(model, 'models/mlem-model')  #, sample_data=df)

Traceback
(venv) me@laptop:~/BitBucket/project$ python3 tools/export_pickle_as_mlem.py
Traceback (most recent call last):
  File "/home/me/BitBucket/project/tools/export_pickle_as_mlem.py", line 18, in <module>
    mlem.api.save(model, 'models/my-model-mlem')
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/mlem/telemetry.py", line 50, in inner
    return f(*args, **kwargs)
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/mlem/core/metadata.py", line 122, in save
    meta = get_object_metadata(
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/mlem/core/metadata.py", line 53, in get_object_metadata
    return MlemModel.from_obj(
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/mlem/core/objects.py", line 740, in from_obj
    model_type = model_hook.process(model)
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/mlem/contrib/callable.py", line 213, in process
    s = Signature.from_method(
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/mlem/core/model.py", line 236, in from_method
    name=override_name or method.__name__,
  File "/home/me/miniconda3/envs/imagedxapp/lib/python3.10/site-packages/fastcore/basics.py", line 497, in __getattr__
    raise AttributeError(k)
AttributeError: __name__. Did you mean: '__ne__'?

Hi @danielbellsa! Thanks for reporting! I know @mike0sv was working on implementing fastai support, so I think he can help us figure this out!

FastAI is very hard to integrate with because it's authors are very "creative". You can try exporting to torch or maybe provide a callable function instead of learner (maybe something learner.predict or declare a custom function).
I will try to investigate it in the mean time

Sorry @mike0sv - didn't get your point about the screenshot. Do you mean it's an example of a "creative" code? Do we plan to ever integrate with FastAI then? 🤔

@danielbellsa - sorry - based on what Mike said, it looks like we can't just support that for now. Did you use some workaround or decided to skip using MLEM in this case?
Btw, about sample_data - to serve model with FastAPI or Streamlit (and deploy the model somewhere), you'll have to pass sample_data - so MLEM can figure out data schema to build an API for your model.

The point is that fastai is lot of pain. I will get back to this in #268


Create IMPORT/BACKUP examples without cloud storage

A user on our community Slack:

I'm looking at the docs about importing a database from an existing database dump from another database type, what's the easiest way without cloud storage and just a few containers? I'm just trying to test an import. I looked at the nodelocal stuff but not sure I fully understand how that works or whether it's what I need

My response:

we really need to improve our end-to-end IMPORT guidance for different scenarios, including using local storage. Have you seen the options here https://www.cockroachlabs.com/docs/stable/import.html#import-file-location
Option 1, using a local file server, might be easiest: https://www.cockroachlabs.com/docs/stable/create-a-file-server.html. Unfortunately, we don’t have explicit instructions on leveraging that for IMPORT. I’ll make sure we get that docs work on the backlog.

This comes up fairly regularly, I think, for import, backup, and restore testing.
Related 20.1 roadmap items:

https://github.com/cockroachdb/docs/issues/6010
https://github.com/cockroachdb/docs/issues/5905

Related docs improvement requests:

https://github.com/cockroachdb/docs/issues/3724
https://github.com/cockroachdb/docs/issues/4814

cc @rolandcrosby

More details from the Slack thread, from @dt:
Anyway, in 19.x, my suggestions would be
a) single-node cluster while  nodelocal and copying to extern dir woks as expected.

c) multi-node cluster and use nodelocal after manually copying every file to every extern dir

Related issue: #6086

fwiw, in 20.1, this is going to be much simpler -- you will be able to just put files on any one node and then reference them -- so if the docs changes discussed here wouldn't be happening in 19.x docs anyway, we might want to just hold off and document the new flow when it lands?

From https://github.com/cockroachdb/docs/issues/6086:

Nodelocal information for doing import is not intuitive. Based on conversations in the community slack, good to create official document until a more permanent solution is being developed in the future release. Here's a good starting point.


merge my fork's cst-changes into this repo's cst-changes

i accidentally pushed to my fork instead of this repo, so i'm merging the changes from there into here
also had buildscript v2 stuff but i reverted all that

@CST1229 use git merge locally instead next time

@CST1229 use git merge locally instead next time

was too lazy to do that


SecondCacheLevel association and inheritance update problem

I have a entities like this (I just document the minimum needed):

/**
 * @Entity
 * @Cache("NONSTRICT_READ_WRITE")
 * @DiscriminatorColumn(name="type", type="string")
 * @DiscriminatorMap({"child" = "ChildClass"})
 */
class BaseClass
{
}

/**
 * @Entity
 * @Cache("NONSTRICT_READ_WRITE")
 */
class ChildClass extends BaseClass
{
  /**
  * @Cache("NONSTRICT_READ_WRITE")
  */
  private $associations;
}

When changing the ChildClass->associations value and persisting it the data in the cache is not removed.
Investigating I found that the Doctrine\ORM\Cache\Persister\Entity\AbstractEntityPersister is using the entityName (that will be ChildClass) but that the Doctrine\ORM\Cache\Persister\Collection\NonStrictReadWriteCachedCollectionPersister is using the $this->sourceEntity->rootEntityName (that will be BaseClass) So it doesn't clear the proper key entry.
Pretty easy to change but might be risky...
If you consider that I am on the good track I can give it a try to make the unit test for it.

Looks for me similar to the problem reported here:
https://github.com/doctrine/doctrine2/issues/5562

Yes i think the the problem is the same thing since both is related to inheritance and second level cache.

Hi all, is there any update on this bug?

I believe that #6028 fixes this.

No it doesn't

@mpoiriert weird, what kind of relation do you have? I can investigate this  today.

Sorry for the delay really busy at the time.
This is the class override I have to fix the issue on my side
`use Doctrine\ORM\Cache\CollectionCacheKey;
use Doctrine\ORM\PersistentCollection;
/**

This is to fix this bug:

@see https://github.com/doctrine/doctrine2/issues/5793
/
class NonStrictReadWriteCachedCollectionPersister extends \Doctrine\ORM\Cache\Persister\Collection\NonStrictReadWriteCachedCollectionPersister
{
/*

{@inheritdoc}
*/
public function delete(PersistentCollection $collection)
{
$ownerId = $this->uow->getEntityIdentifier($collection->getOwner());
$key     = new CollectionCacheKey($this->sourceEntity->name, $this->association['fieldName'], $ownerId);
$this->persister->delete($collection);
$this->queuedCache['delete'][spl_object_hash($collection)] = $key;
}

/**

{@inheritdoc}
*/
public function update(PersistentCollection $collection)
{
$isInitialized = $collection->isInitialized();
$isDirty       = $collection->isDirty();
if ( ! $isInitialized && ! $isDirty) {
return;
}
$ownerId = $this->uow->getEntityIdentifier($collection->getOwner());
$key     = new CollectionCacheKey($this->sourceEntity->name, $this->association['fieldName'], $ownerId);
// Invalidate non initialized collections OR ordered collection
if ($isDirty && ! $isInitialized || isset($this->association['orderBy'])) {
$this->persister->update($collection);
 $this->queuedCache['delete'][spl_object_hash($collection)] = $key;

 return;

}
$this->persister->update($collection);
$this->queuedCache['update'][spl_object_hash($collection)] = array(
'key'   => $key,
'list'  => $collection
);
}
}`

and
`<?php
namespace UgroupMedia\Bundle\CommonBundle\Doctrine\ORM\Cache\Persister\Collection;
use Doctrine\ORM\Cache\CollectionCacheKey;
use Doctrine\ORM\PersistentCollection;
/**

This is to fix this bug:

@see https://github.com/doctrine/doctrine2/issues/5793
/
class ReadWriteCachedCollectionPersister extends \Doctrine\ORM\Cache\Persister\Collection\ReadWriteCachedCollectionPersister
{
/*

{@inheritdoc}
*/
public function delete(PersistentCollection $collection)
{
$ownerId = $this->uow->getEntityIdentifier($collection->getOwner());
$key     = new CollectionCacheKey($this->sourceEntity->name, $this->association['fieldName'], $ownerId);
$lock    = $this->region->lock($key);
$this->persister->delete($collection);
if ($lock === null) {
return;
}
$this->queuedCache['delete'][spl_object_hash($collection)] = array(
'key'   => $key,
'lock'  => $lock
);
}

/**

{@inheritdoc}
*/
public function update(PersistentCollection $collection)
{
$isInitialized = $collection->isInitialized();
$isDirty       = $collection->isDirty();
if ( ! $isInitialized && ! $isDirty) {
return;
}
$this->persister->update($collection);
$ownerId = $this->uow->getEntityIdentifier($collection->getOwner());
$key     = new CollectionCacheKey($this->sourceEntity->name, $this->association['fieldName'], $ownerId);
$lock    = $this->region->lock($key);
if ($lock === null) {
return;
}
$this->queuedCache['update'][spl_object_hash($collection)] = array(
'key'   => $key,
'lock'  => $lock
);
}
}
`

As you can see the only thing I had to change is to use
$this->sourceEntity->name
instead of
$this->sourceEntity->rootEntityName
I never did a pull request with that fix since I didn't have time to follow protocol and I did want to make sure it's working. We are using this fix since the 20th April

@mpoiriert did you try your mapping with 2.6.x-dev?
The persisters must use the rootEntityName so your fix might break something else we build.
You could also send us the mapping you have so we can try it out and find the problem.

@mpoiriert sorry, you were right that the problem wasn't solved.
It was also notified on #5562.
I'm sending a PR today that fixes it for good 😉

Great thanks. We are planning to upgrade all our stack in the next couples of months so I'll be glad to remove all my factory/override when I'll pass to 2.6.0

@mpoiriert nice, I'll close this issue since we merged #6244.
Would be amazing if you could test your mapping using 2.6.x-dev and report us any other issue.


Adding SRI support for FireFox Mobile

See: https://github.com/mozilla/srihash.org/pull/93

@Fyrd out of interest how come the latest Firefox android isn't in the list?

Yeah, oversight on my part. Have updated it now and it includes the SRI support, so closing this PR. Thanks for pointing it out!


Whitelist/BlackList

Hi all,
Is there any way to stablish a whitelist or blacklist in order to enable registry only microservices deployed in several hosts?
I know that we could use AWS zones, but currently we have deployed all microservices in our internal intranet.
Thanks & Regards

You mean like create a whitelist of services are allowed to talk to Eureka?

You mean like create a whitelist of services allowed to talk to Eureka?

Yes, that's exactly what we are looking for but it seems there is no way to perform it. Isn't it?
Thanks!

There are two properties that control if the instance should register with eureka and if the instance should fetch the registry. These can be flexed on those hosts you do not want to participate with eureka.
https://github.com/Netflix/eureka/blob/743af8be0fa37118a3a9ee0d39f3ba8a89621119/eureka-client/src/main/java/com/netflix/discovery/EurekaClientConfig.java#L273-L284
https://github.com/Netflix/eureka/blob/743af8be0fa37118a3a9ee0d39f3ba8a89621119/eureka-client/src/main/java/com/netflix/discovery/EurekaClientConfig.java#L451-L456

@troshko111 Yes, that's exactly what we are looking for but it seems there is no way to perform it. Isn't it?
Thanks!

In addition to what @mattnelson has mentioned, depending on your requirements and reliability of the solution I'd suggest to explore:

If deployed to a cloud provider infra, look into network control like security groups on AWS and equivalent on Azure/GCP.
Put on a reverse proxy in front of Eureka instances and require mTLS (terminating it at the reverse proxy), make the proxy verify the client identities against the whitelist or just use special certs.
Use a firewall of some sort, iptables should do.

This is really outside of the service concerns.

Hi both,
Thanks for your help. We will check it now.


[Feature] Static field.

Hi guys, i already made PR about this.The static field is very useful in update case for example where the user does not have enough permissions to update this fields or just the fields should not be edited in any way. You can make text type disabled but a user with some basic knowledge in web development will be able to change the value and submit it. You can make sure that this will not happen  with FormRequest, but i think will be easier just to make the field static so it does not get posted. Thanks

Just today I needed a field to be read only after its saved once, and because it was Unique it was trying to save over it and giving me an error.

@dobromir-hristov
Readonly fields in HTML still post to the server.
Disabled fields do not. This is the HTML spec
You can try making it disabled to solve your issue, or remove it from the request before doing a mass update. Which could easily be done via this PR https://github.com/Laravel-Backpack/CRUD/pull/283 - so until that's merged you'll have to figure out a different way to handle it

@OwenMelbz I am sure that static fields does not post to the server

I'm talking about input fields with disabled or readonly attributes, I'm not sure what you mean by static fields tbh

{{$field['value']}}
 from Twitter Bootstrap 3

I did it like this:

    {!! $field['label'] !!}

    {{$entry->{$field['name']} }}

Just copied the text input and changed <input> to

Just incase you didnt know you can have something like
$this->crud->addField([
'name' => 'some field',
'label' => 'some label',
'attributes' = ['disabled' => 'disabled]
]);
this would create a field that displays the data but cannot be changed, that doesnt need any custom code/adjustments

Hmm... I have to agree with @OwenMelbz on this one. We already have the text and textarea field types that can do that, if you give them the disabled attribute, so I don't think separate field types are necessary for this.
Perhaps we should better document this feature, rather than add new fields. I'll see where I can include this in the docs.
Cheers!

how to disable field_name in laravel backpack?
$field_name = [
'name' => 'name',
'label' => 'City Name',
'disabled' => 'disabled'
];
$this->crud->addField($field_name,'both');
this is not work,,,

@Rinaldi91 read up ^^^

@OwenMelbz do you mean to use something like this?
$this->crud->addField([
'name' => 'some field',
'label' => 'some label',
'attributes' = ['disabled' => 'disabled]
]);
i try to use this, but not work


Unclear instruction

Challenge http://www.freecodecamp.com/challenges/waypoint-use-an-id-attribute-to-style-an-element has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

"Make sure your form element has both an id attribute."   if you say 'both', it would mean an id attribute AND something else, right?

On it.


Add cursor to visitor

This lets us do stuff that depends on knowing where the node we're visiting is.
For example, I noticed <v:roundrect /> is invalid but React.createElement('v:roundrect') is fine, so wrote some code like <v$roundrect /> & a function that can find/replace $ with : after an intermediate build step.
const React = require('react')
const ReactWalker = require('./reactTreeWalker').default

const ReactMapper = async (element, f) => {
  let root
  let next = new Map()
  await ReactWalker(
    element,
    (e, _0, _1, _2, cursor) => {
      if (typeof e.type === 'function') return
      if (e.type && e.type.toString().includes('react.fragment')) return

      const parent = cursor.filter(e => typeof e.type === 'string').slice(-1)[0]

      let ni
      if (typeof e.type === 'string') {
        ni = f(e)
        ni.children = []
        next.set(e, ni)
      }
      if (parent) next.get(parent).children.push(ni || e)
      if (!root) root = ni
    },
    {}
  )

  const recursive = el => {
    if (typeof el === 'string' || typeof el === 'number') return el
    const {type, props, children} = el
    return React.createElement(type, props, ...children.map(recursive))
  }

  return recursive(root)
}

const repairNamespaces = async element => {
  element = await ReactMapper(element, e => {
    const type = e.type.replace('$', ':')
    const props = e.props
    return {type, props}
  })

  return element
}

This seems like a super interesting idea and could open up some powerful ideas. I'll need to give it a thorough bashing before we merge, but i feel like it holds a lot of promise. Thanks so much for this proposal!

@ctrlplusb how's the bashing going?


Return undefined + give proper error messages, if types could not be followed

Request for a proper handling, when a type is a built in one, or from a non transformed module, where we have no RTTI.
Returning any and passing the validation is no good from a security perspective ;)
import { reflect } from 'typescript-rtti';

class A {
    foo() { return window }
}

console.log(reflect(A).getMethod('foo').returnType.toString()); // Got: "any", expected: an Error, returnType is undefined / indicate that type could not be followed
console.log(reflect(A).getMethod('foo').returnType.matchesValue("abc")); // Got: true, expected: an Error, that the type could not be followed

Yeah, I'm interested in the same, but it is difficult to imagine how we'd do it efficiently. The transformer can definitely introspect all these types, but if we put them in the emitted typestore for every file, the result is absolutely massive.
Right now there is a hard check to avoid emitting type information for builtin types (those defined in a .lib.d.ts). As soon as you remove that check, you pretty much immediately start pulling in the entire standard library into every file emitted by TSRTTI.


adopters.md: remove Eliot project

remove project from ADOPTERS as it is now inactive.
Follow up of : https://github.com/containerd/containerd.io/pull/203

/cc @samuelkarp


Create release docs, and include wheel and sdist

Something like a check list for a release. Include the wheel so users don't have to re-compile anything to install it in their environments. And also sdist for Conda, etc.

https://github.com/kinow/pccora/wiki/Releasing


Add git commit hash etc to log

Currently (commit 3b385d5), the log file riboviz.date-time.log notes the python version it was run under. It might be additionally helpful to know which version of riboviz ran it, i.e. to log the commit hash in the log file. That would make it easier for users who've run riboviz on a dataset to return and run an identical version, i.e. reproduce results.
Should we also log versions of any other dependencies?

I've a script in install/environment.sh which dumps info on versions of OS, Python, R (and their packages) and third-party tools. This could be migrated to a Python function.

Relates to #123

Branch provenance-90-115-123 branched from remove-sample-prefix-114 addresses this plus elated tickets #115, #123.

Commits to 6dd1cd4 updates Python and R tools to invoke new provenance.py/provenance.R get_version functions which get commit hash and date. These use gitpython and git2r respectively. For example:
$ PYTHONPATH=~/riboviz python -m riboviz.tools.demultiplex_fastq
demultiplex_fastq.py version commit 8e6c97e4fbae2892e66616e2fcec0d60416d1f22 date 2019-12-20 02:56:02-08:00
...
$ Rscript riboviz/rscripts/bam_to_h5.R -h
[1] "bam_to_h5.R version commit 611240029d02b62b697a3d05c948611c4a0a836d date 2019-12-20 12:46:25"
...

Example if run in RiboViz directory with no .git repository folder:
$ PYTHONPATH=~/riboviz-nogit/ python -m riboviz.tools.demultiplex_fastq
demultiplex_fastq.py version unknown
...

$ Rscript riboviz-nogit/rscripts/bam_to_h5.R -h
[1] "bam_to_h5.R version unknown"
...

#90, #115, #123 are done - will create pull request in new year.

Merged via pull request #126.


event informations

Hi,
First, thanks for this great project. Showing what's happeing on a k8s cluster is very useful.
I started testing kubewatch, and I have two example about sent messages which is not so informative.

A Node in namespace `` has been Updated:
It would be great if we have more info about that.

A Event in namespace graylog has been Created:
graylog-mongodb-0.173e2cfeb153ed44
This is better, so I can see the event id.
kubectl get event graylog-mongodb-0.173e2cfeb153ed44 -n graylog
LAST SEEN   TYPE      REASON      OBJECT                  MESSAGE
5m15s       Warning   Unhealthy   pod/graylog-mongodb-0   Readiness probe failed: command "/opt/scripts/readinessprobe" timed out
I think it would be even better if kubewatch send the event contents. Or it is configurable and I'm missing something?

Hey, thanks for the feedback.
You can send the full information via the cloudevents handler. (The source code has full reference for what's sent.)
If you want an easy to use solution that also formats the results, we also maintain Robusta which wraps KubeWatch and provides higher-level forwarding. (You can do full filtering on what is sent and template the messages.)


Feature request: Show log retention time for Security/Test-ProxyLogon.ps1

Is your request related to a problem? Please describe.
It might be a problem, that Security/Test-ProxyLogon.ps1 checks logfiles which don't date back to a potential exploitation. If the logs are gone, nothing can be done about it, but at least it should be clear, that if the logs just go back for e.g. 3 days, it doesn't cover the perdiod until 26th Feb when the exploiting started.
Describe The Request
Please include the few lines of code to show the date range covered by the checked logfiles:
$exchangePath\Logging\ECP\Server*.log
$exchangePath\Logging\OABGeneratorLog
$exchangePath\Logging\HttpProxy
Additional context
There are It providers, which have discovered, that disk space costs money and unless the clients pays extra for it, they reduce the log retention time to some days or even hours. That might cover basic debugging needs but not security.
We're not even talking about attackers which might have deleted parts of the logs ;)

that was quick, thanks!


SOCKS5 support

Is it within the scope of this library to eventually support SOCKS5 proxies?
I had a look through your code and the tests suggest it's not supported currently.

Currently, we don't have any plans for implementing the SOCKS5 support. However, PRs are more than welcome :) I'm closing the ticket for now.


[Bugfix][Core]: Guard for KeyErrors that can occur if a request is aborted with Pipeline Parallel

This is a quick and dirty solution to #6586 wherein a vLLM server running a model with pipeline parallel can crash if streaming requests are aborted during the processing.
I think an ideal solution would be to fully abort the output processing in this case instead of just guarding for the KeyErrors in the places they arise, but I couldn't come up with a nice way to do that 😅.
(PR is currently a Draft to see if we can find a better solution)
FIX #6586
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks @tjohnson31415!

@youkaichao recommend to merge this if it tests pass


[Suggestion] Add "Table_Prefix" in config

Hello,
Is it possible to add "Table_Prefix: servervariables_" in the database config please? :)

All tables are already created with that prefix:

servervariables_players
servervariables_players_variables

Yes, but I want to set a custom prefix, is for that!


Document multi get behaviours

Have pushed a squash here.  Will keep open till we know if https://github.com/nats-io/nats-server/pull/5158 lands


Completely remove drag-and-drop components from tab that are throwing…

… validation errors. r=linclark
Fixes #336

Coverage decreased (-0.02%) to 47.034% when pulling 8806bdec62d186ae45ca16408d31de32d467422a on jsantell:fix-drag-errors into b9e31e368b238e3a07efbac4fee6c675b43938d6 on mozilla:master.

This looks good. One thing I noticed, there is a WebkitAppRegion: 'drag' in navbar.jsx... is that anything that should be changed?
Other than that question, LGTM!

The WebkitAppRegion property is for being able to drag the full window around in the OS, so that should stay in this case, I think.
Thanks!


Enable better runtime failure messages

The implementation was done quite a while ago.
Now, that we have support in lldb (https://github.com/apple/llvm-project/pull/773), we can enable it by default in the compiler.
LLDB now shows the runtime failure reason, for example:
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x0000000100000f0d a.out`testit(a=127) at trap_message.swift:4:12
   1
   2   	@inline(never)
   3   	func testit(_ a: Int8) -> Int8 {
-> 4   	  return a + 1
   5   	}
   6

For details, see https://github.com/apple/swift/pull/25978
rdar://problem/51278690

@swift-ci test

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 904fe55385e0690745b902cbf055f9979c3d6ea8

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 56ecb8fc9b23866e15475a152da7bbdb0ae16cf8


Inject results with WillFinishObserver to avoid race condition

When injecting results using a DidFinishObserver, there is a race condition when the dependent operation becomes ready and executes after its dependency finishes but before the dependency's DidFinishObserver is triggered. This means the dependent operation occasionally executes before its dependency's result is injected and fails due to a missing requirement.
Switching this to a WillFinishObserver ensures that the result is injected before the dependency finishes, and before the dependent operation is allowed to execute.

Great catch @estromlund. Thanks!
I think would probably have been a regression in 2.7.0, as originally the did finish event was actually triggered where will finish is now triggered.


BetterMC2 [FABRIC] Modpack not running

Pretext:
I have the BetterMC modpack imported using packwiz curseforge import PATH and then did packwiz mr export in order to find out all the mods that packwiz couldn't download (It shows a list of the ones it couldn't download). Then I manually removed all the mods that couldn't be downloaded and uploaded the pack to github. Then I added the correct link and tried running it. But when the server starts, it gets a crashing loop and stops at the 5th crash (normal behaviour). I tried the packwiz modpack in a singleplayer world and everything worked fine... oh and the server works fine without, or just with a small amount of, mods
Questions:
Can I see the crashlogs anywhere? and
Do you have any idea why it crashes?
Modpack: https://github.com/Vartroc/bettermc/tree/main

Crash logs are loaded at /srv/minecraft/servername, along with the rest of the server files. I don't have any information about why it might be crashing until I get crash logs.

Of course, here are all the files (except .fabric, because there are the .jars from the mods and that would conflict with many licenses of the mods...)
https://github.com/Vartroc/hexagonal_planar_6
https://paste.gg/p/anonymous/a596befc24da488381762c87a106298a - latest.log (is included in git repo, but I created the paste before making the repo, so maybe it's some use to you idk)
https://paste.gg/p/anonymous/f516acc3bdbe4eea9599466c70ac61d7 - output of tree .fabric

Logs 1 and 2 indicate that configureddefaults is the one causing the crash. Logs 3, 4, and latest seem to be fine(?)


Update to JMeter 5.6.2

Update the BackendListener to be usable with JMeter 5.6.2.
Also I enhanced the error output to detect, that some Samples have no hostname (in my case,  Transaction Sampler). To use this Plugin, the hostname can be null.

Hi @dgetzlaf thanks for the contribution! Could you please have a look at the comments above?

@ludeknovy
I created the jar file using “gradle clean jar”, so perhaps I had an easier way to look at it (build it without errors and use it in JMeter).
Thank you very much for your feedback! :)


Monitor crash after request is showed on a list

After a while from getting the request, monitor is crashed with the following error:
Objects are not valid as a React child (found: object with keys {_hex}). If you meant to render a collection of children, use an array instead.     in td (at Request.tsx:24)     in tr (at Request.tsx:19)     in Request (at RequestList.tsx:75)     in tbody (at RequestList.tsx:66)     in table (at RequestList.tsx:65)     in RequestList (at App.tsx:16)     in div (at App.tsx:9)     in App (at src/index.tsx:8)

The bug it's related with web3 issue#2562. From some time errorCode for Request is a BigNumber instead of Number.

Solution comes with:
https://github.com/EspeoBlockchain/gardener-monitor/pull/8


Switch to boost::variant2

boost::variant only supports up to 20 types (MPL limit). boost::variant2
has no such limit; switch to it.
Where has this been tested?

Platform(s): Linux/ubuntu 18.04, Windows 10
Python version(s): 3.8 (windows and linux)
Unreal Engine version(s): 4.26

Possible Drawbacks

None known.

This is a wholesale conversion of variant->variant2, most important for rpc::Command. Also, using get_if allows the use of typeid to be removed.

Hi @anrp-tri, thank you for your contribution, this is certainly a positive update. We are running the PR though our continuous integration pipeline. If it passes all checks we will proceed to merge.


🐛 BUG: AnimatePresence animation between routes is not working

Expected behavior
Animation between routes (pages)
Actual behavior
Pages are overlapping each other and the animation between them is not working
Reproduce the issue

Go to the production

Click the button Create your pizza to go to another route
Note: You can notice that the page was not animated on exit
Note 2: If you continue to other routes, they will overlap each other

Commit 110a9ad7f01b1cb3d70f6e268b6f45c4f875ac38 → fix: update routing

[ ] Remove unnecessary location property instance in react-router-dom's Switch


netstd: Log errors in processor via standard logger

netstd: Log errors in processor via standard logger

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

I made the logger optional to a) not break existing code (including the Test suite) and b) not to force people into using it.

I may miss the idea, but how is it optional when there is an output directly to console?

Main reason for the change was that you added the logger argument in a way that broke existing code. You could have easily recognised this yourself just by trying to build the code we have. Since logging is a non-mission critical task to Thrift the very obvious solution was to make the argument option by adding = default and of course take care of that case when the logger is used. That way you are free to provide a logger but are not forced to do it, in which case it simply behaves as before. I'd consider this as the optimum solution. Whether or not someone is using docker or not is of no relevance here.

Ah, ok. I'll change the code.
My point was that the logger/console in current implementation is not optional in any way. It just prints unformatted text to a console and that brings some problems in use

I already merged you PR, in case you did'nt notice. Further PRs welcome of course.

Great, thanks


C Implementation doesn't produce "best looking" blurhash

I have just compared the blurhash TypeScript module and the C module (I was about to write a blurhash node module based on the C implementation for performance).
The two blurhashes from the modules look different:

C Implementation
TS implementation (better)

Has a dark spot in the top left corner
matches the image really well

LTEfiu4UEe-p0M-oxuRQnhtkRQR*
UEE:Ct005i~C00^%%MIUr;%yMyNG^R9uRP%M

The original image used, with x: 4, y: 3 components:

Can someone explain the difference? Shouldn't the both modules create (nearly) the same output?
I think that the result from the TS implementation looks better and the result from the C module should match this.

Just a guess, but something tells me it either has to do with sRGB<->Linear color-space conversions or an issue with image addressing causing it to alias the color samples differently.

typescript generate a larger hash(28 vs 36), I think there are some differences in the algorithm.


Cannot zoom in on firefox wayland

Describe the bug
When I use firefox I cannot zoom in with the touchpad on wayland this works in wayfire.

Coul'dnt find an option (here)[https://wayland.freedesktop.org/libinput/doc/latest/configuration.html]

Also it would be nice to have natural scroll on touchpads but normal scroll on mouase

I just tested this as well. I can confirm that this is reproducible.

I can confirm this is Hyprland specific and is not present on other tested Wayland compositors - this is also not associated with Firefox's zoom setting, as zoomin is allowed by default. Can't think of a reason why.

should be fixed in ef24329495d173b195a830727bfe7191c1761d12
lmk, as i dont own a touchpad.

Testing in a minute.

Seems to be working on the latest commit.

Yay


merge: stage to master

:tada: This PR is included in version 0.71.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ Bofrost.es has degraded performance

In 0121cec, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1530 ms

Resolved: Bofrost.es performance has improved in 5945457 after 14 minutes.


Add sources to project, instead of the target

Ensures that the fiels will continue to show up in Xcode's 'Project
Navigator

Ensures that the same files will not show up in any target's
'Compile Sources' build phase

What impact does this have on indexing & debugging functionality?

Hey @segiddins, the short answer is that we're not sure yet (and it very well may break indexing, debugging, or some other IDE features) -- we're trying to grok how the "compile sources" phase fits into those features right now.
Wiley opened this PR to demonstrate a possible solution to an issue we posted about in ios-dev-at-scale (we're hitting ARG_MAX because we have too many files in a single target & the legacy build system appears to not use an argument file when compiling), but this might be the wrong approach.

Going to check on the impact of removing compile source phase but most likely this is going to break indexing.
Will pull down this branch to test soon because I want to investigate if compile source phase can help us with getting a health check on indexing.

to check on the impact of removing compile source phase but most likely this is going to break indexing.
Will pull down this branch to test soon because I want to investigate if compile source phase can help us with

Thanks so much @gyfelton - as @jschear noted above, this is more of a conversation starter than a legit pull request - we're trying to get up to speed on how all this stuff works.

Thanks for starting this discussion! A couple thoughts:

I would guess that this breaks indexing but will give it a whirl. Xcode's indexer needs to (1) be turned on in order for autocomplete to work and (2) needs to successfully be able to compile source files that are opened/edited. In order to know which compile flags to pass for the source file, xcode looks at the target build settings for that source file.
If a developer adds files to the xcodeproject target, note that Xcode will add a new compile sources phase to the target with this source file in it. Assuming you stub out clang, you probably wouldn't hit an argmax issue under those conditions, but it would be very weird to see just one source in the target phase.
Maybe the right thing to do here is to explore switching the new build system. (The other reason to switch to new build system is because someday the old one is going to go away!) The original version of the xcode rule was generating projects that ran against new build system ... but I switched it over to use the old build system and here was the reason for it: https://github.com/bazel-ios/rules_ios/pull/42#issuecomment-629967829 The last time I checked, Tulsi was also using the old build system.

I will confirm that this does in fact break indexing and revisit using the new build system.

Thanks for starting this discussion! A couple thoughts:

I would guess that this breaks indexing but will give it a whirl. Xcode's indexer needs to (1) be turned on in order for autocomplete to work and (2) needs to successfully be able to compile source files that are opened/edited. In order to know which compile flags to pass for the source file, xcode looks at the target build settings for that source file.
If a developer adds files to the xcodeproject target, note that Xcode will add a new compile sources phase to the target with this source file in it. Assuming you stub out clang, you probably wouldn't hit an argmax issue under those conditions, but it would be very weird to see just one source in the target phase.
Maybe the right thing to do here is to explore switching the new build system. (The other reason to switch to new build system is because someday the old one is going to go away!) The original version of the xcode rule was generating projects that ran against new build system ... but I switched it over to use the old build system and here was the reason for it: #42 (comment) The last time I checked, Tulsi was also using the old build system.

I will confirm that this does in fact break indexing and revisit using the new build system.

Hi all! I have put up a draft PR that seems to successfully switch out xcode projects to using the new build system: https://github.com/bazel-ios/rules_ios/pull/141


Check for explicit boolean expression checking for true and false

this could check cfelseif, cfloop conditions etc as well.


Configure SSL

I mounted a TLS secret successfully. But, I can't set up permissions for postgres to access the file. Is there any way to set fsGroup? Also, is there any way to set init containers?

Thank you for your message.
Could you please share the contents of the Kubegres configurations resources that you have created (ConfigMap, YAML of kind Kubegres, ...) and also the error message that Postgres displays when trying to access to the file?

I just did. Same error:
`apiVersion: kubegres.reactive-tech.io/v1
kind: Kubegres
metadata:
name: wpg-kubegres
namespace: watcher
spec:
volume:
volumes:
- name: certs
secret:
secretName: wpg-sdstage01-kcftech-com-tls
defaultMode: 0644
volumeMounts:
- mountPath: /var/lib/postgresql/certs
name: certs
replicas: 3
image: postgres:14
customConfig: wpg-conf
database:
size: 75Gi
env:
- name: POSTGRES_PASSWORD
valueFrom:
secretKeyRef:
name: wpg-secret
key: superUserPassword
 - name: POSTGRES_REPLICATION_PASSWORD
   valueFrom:
      secretKeyRef:
         name: wpg-secret
         key: replicationUserPassword`

Thank you.
The file tls.crt is a symlink pointing to a file in the folder data.
Could you please do a ls -a on the file located in the data folder?

Could you please move the certificate file to that folder?

PostgreSQL won't start; the pods get stuck in CrashLoopBackOff.

Ok, understood. Thank you!

That would be awesome! ty!

Sorry for the delay. I tested defaultMode 644 and got the following error.
`ubuntu@ip-10-0-1-219:~$ kubectl -n pgvirtuoso logs -f -l app=ivdb
PostgreSQL Database directory appears to contain a database; Skipping initialization
2021-10-31 00:02:25.250 GMT [1] FATAL:  private key file "/var/lib/postgresql/data/certs/tls.key" has group or world access
2021-10-31 00:02:25.250 GMT [1] DETAIL:  File must have permissions u=rw (0600) or less if owned by the database user, or permissions u=rw,g=r (0640) or less if owned by root.
2021-10-31 00:02:25.250 GMT [1] LOG:  database system is shut down
I changed to 640 and got this error:ubuntu@ip-10-0-1-219:~$ kubectl -n pgvirtuoso logs -f -l app=ivdb
PostgreSQL Database directory appears to contain a database; Skipping initialization
2021-10-31 00:06:24.820 GMT [1] FATAL:  could not load server certificate file "/var/lib/postgresql/data/certs/tls.crt": Permission denied
2021-10-31 00:06:24.820 GMT [1] LOG:  database system is shut down
`
Is there an option to deploy init container?

There is no option to deploy init container. I am happy to review a PR if a developer from the community would like to add this feature.
I released a "beta" version in the main branch which allows to specify the field "securityContext" . To install it and test it please run:
kubectl apply -f  https://raw.githubusercontent.com/reactive-tech/kubegres/main/kubegres.yaml

I tested it locally with the following config in the YAML:
apiVersion: kubegres.reactive-tech.io/v1
kind: Kubegres
metadata:
  name: mypostgres
  namespace: default
spec:
...
 securityContext:
   runAsNonRoot: true
   runAsUser: 999
...

Under securityContext, you can specify fsGroup as well.

What would you use as a code/script if it was possible to have a deploy init container?

I was thinking of a bash script to change file ownership and properties. AKA, chmod and chown.

BTW, it worked!!!! Thank you! SSL is on. (I used cert-manager with let's encrypt certificate and connected with full verification)

Nice one!
Thank you for sharing all the details which allowed you to get there.
I am closing this issue.

Note that Kubegres version 1.13 is available with the support for the new field securityContext.
Please see the release page:
https://github.com/reactive-tech/kubegres/releases/tag/v1.13
I updated the documentation by adding details about the new field 'securityContext':
https://www.kubegres.io/doc/properties-explained.html
To install Kubegres 1.13, please run:
kubectl apply -f https://raw.githubusercontent.com/reactive-tech/kubegres/v1.13/kubegres.yaml

Thank you!!!!

To get this working locally we had to specify the following in our kubegres config;
apiVersion: kubegres.reactive-tech.io/v1
kind: Kubegres
metadata:
  name: mypostgres
  namespace: default
spec:
   replicas: 3
   image: postgres:14.1
   database:
      size: 10Gi
   customConfig: mypostgres-conf
   securityContext:
     fsGroup: 999
   volume:
     volumeMounts:
       - mountPath: "/mypostgres/.postgresql"
         name: mypostgres-server-tls
         readOnly: true
     volumes:
       - name: mypostgres-server-tls
         secret:
           secretName: mypostgres-server-tls
           defaultMode: 0400
   env:
     - name: POSTGRES_PASSWORD
       valueFrom:
         secretKeyRef:
           name: mypostgres-secret
           key: superUserPassword
     - name: POSTGRES_REPLICATION_PASSWORD
       valueFrom:
         secretKeyRef:
           name: mypostgres-secret
           key: replicationUserPassword

Of particular importance is that only fsGroup was specified to the securityContext as specifying runAsNonRoot / runAsUser resulted in the following error:
mkdir: cannot create directory ‘/var/lib/postgresql/data/pgdata’: Permission denied

Also note defaultMode is specified as volume parameter, omitting this results in:
2022-01-06 21:15:59.609 GMT [1] FATAL:  private key file "/mypostgres/.postgresql/tls.key" has group or world access
2022-01-06 21:15:59.609 GMT [1] DETAIL:  File must have permissions u=rw (0600) or less if owned by the database user, or permissions u=rw,g=r (0640) or less if owned by root.

Finally if defaultMode is specified but fsGroup is not specified, you will get the following error:
2022-01-06 21:16:47.837 GMT [1] FATAL:  could not load server certificate file "/mypostgres/.postgresql/tls.crt": Permission denied

Only through the combination specified above were we able to get it working. We will elaborate more momentarily in another issue (feature request to add ssl option)

@movitto thank you for sharing this!
It will be helpful for the community.