View Page - page behavior

- see screenshot for typography and overall interaction question
- Is there any reason why using a "tab" view for annotation and deep zoom? I know toggle buttons in spec are nor the best solution. We can discuss?
- unbale to test annotations (could you remind me which book contains annotation entries that we could test?)

- we can produce better controllers for these deep zoom functions. are they form an esisting viewer?

@xinyil I didn't realize the sidebar was collapsible or that there wasn't a footer for this page - I can work on that.
It's really odd that you aren't getting a computed size for the sidebar. The odd font-size: 0.85714em; should be right because the font size for the body is 14px.
I can switch the "tabs" for the switches - when they were switches, I thought they would be able to both be active. However, that wouldn't work with the overlays. In effect they will still be tabs, but I can style the buttons to look like switches. That shouldn't take much effort.
The controls for the deep zoom are from the existing viewer.

update:

annotation type tags seems extra large
the overlaying color is the same shade of red for the annotation page, see zeplin for the numbers and opacity. active selected one has outline.
I notice you added shadow to help differentiate the card, but we don't use shadow elsewhere on the site, let's try a darker background for this page? we did have a different art direction option using shadows, then the team decided to go with the current one, more flat, with divider lines. Now I think we don't need the close button to close each annotation card (in Zeplin), maybe we can just use lines so they are more like the annotation card? @rlskoeser could also weigh in.

@kevinglover

I'm getting 0.85714em, and too large. em is associated with the browser I think, default to 16px.
you're right, we decided these 2 options will not be both active. see comment on zeplin:  the deep zoom will turn annotation off, so these two will never be on at the same time.
can we modify the control icons?

@xinyil
The link icon is the anchor for the annotation, if you wanted to share it. You could copy that link and send it to somebody else. @rlskoeser let me know about that requirement.
The cards are the same as the ones on the admin annotation creation and share styles, thus the box-shadows. I didn't think about removing them since they were being used there as well, but I can do that. If it's too light, I'll try making the background darker.
It's very strange that you are getting a font size that is too big. Em is relative to the body, which is set to 14px here - I didn't want to have to depend on the browser default. I can just set it to the absolute px for that element - I've tested it in Chrome and Safari, so I don't know what is happening.

It would make more sense to me for the annotation cards here to look like the annotation cards in the search results than using the styles from the admin annotation data entry interface, since most users won't ever see that view.
I'm not sure toggles makes sense since the two modes can't be toggled independently.  (In theory you could turn off annotations without switching to deep zoom, but I'm not sure it's worth coding or makes sense to do.)  If we wanted to go with a style that is used elsewhere on the site, perhaps we could use tabs like we have on the book detail page?  But I'm not sure how that would look here, and I'm also not sure if it mirrors the behavior there.  I think the current style is ok.
It is possible to switch out custom icons for the deep zoom controls.  We customized them in readux, but I think we also customized the layout as well to integrate them into our existing control panel links.  I believe there is a simple config option to just supply different icons for the existing controls.  @xinyil did you have particular icons in mind?

I'll add a story to document the anchor link - that was something I thought was important from web architecture perspective and also make things citable.  I was wondering this morning if we needed something similar for the references, but I don't think there is a need to cite them in the same way as the annotations.

@xinyil do we want to include the shadow on the sidebar here or do we want to have it more flat?

It's not clear what the link icon stands for – I didn't get it even after clicking on it. We could make it more straightforward and say something like "copy reference link" that directly tell you its function?
I'll produce a new mock up reflect card changes and controllers.
@kevinglover We wouldn't use shadow for the sidebar. You can also hold off this till we have the updated mock up.

@xinyil the link icon is a fairly standard one - e.g., I've seen things like that in technical documentation for linking to a section of the text (sometimes only visible on mouse over of the title).  I don't know whether or not our audience would be familiar with it or not.  Would title (hover) text for the link be sufficient to indicate its purpose?  Alternatively, we could label it "permalink" or something like that.

@rlskoeser I've seen ones near headings of a long text, but because this one is on a card, I'd expect it opens some new page. permalink sounds reasonable in the library setting. Does it copy the link or just show the link the browser?

@rlskoeser @xinyil Copying a link to the clipboard is fairly supported across browsers, but is not supported on Safari for iOS. https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand
One solution is to create a popup window displaying the text to be copied.

Some version of Safari also are reported to have issues with executing a copy from js.

Thanks @kevinglover .  Given that information and that browsers all provide a way for users to copy a link, I say we just leave it as a link and not complicate things.

@kevinglover can the changes here be tested independent of the style changes to this page?  (i.e., is this still ready for review once the changes are on the test site?)

@xinyil there's a lot of back and forth on this issue, could you check and summarize/identify what still needs to be fixed?  We can make a check list in the issue description to track.  I created a separate issue for the nav issue, didn't realize it was documented here #185

[ ]   there are extra spaces at the bottom of the page. sidebar and annotation card should be scrollable, but the whole page should fit to the height of the viewport. sort of like asana. the whole page should not be scrollable because it conflicts with zoom in and zoom out.
[ ]   only show the vertical scrollbar upon scrolling
[ ]   expand the width of the annotation card to avoid the horizontal scrollbar. looks like this is done?
[ ]   add rollover states to display annotation / deep zoom switch, use the blue text and outline for rollover
[ ]  by default, collapse sidebar when switching to deepzoom
[ ]  use hamburger button when the side panel is collapsed
[ ]  height of the header part seems too much?

Another issue not related to behavior but I think it'd a qcuik fix so putting it here:
The separation mark between page names is interpunct /Middle Dot, not a bullet. Same as the dot separating publication year and copy label. I haven't seen one on the site to test.

http://graphemica.com/·

@xinyil everything in the above checklist plus the middle dots should now be implemented.

- overview image page name section should have the same indent as the rest of the page numbers

- spacing between labels
- color is already different maybe we dont't need bold "anchor text"

- the selected permalink underline has some extra shadow
-why did we include book title in navigation?

a kind of unrelated one, see the color of the underline of permalink is light grey, this is the correct color for all the other grey underlines: book titles, sorting buttons, and banner links. currently all the other underlines are darker.

@thatbudakguy
the header size issue still exists. to make space for the page image, we want to minimize the height of the navigation and the back and deep zoom toggle. also moving up the starting position of image and annotation cards will be helpful.
@rlskoeser we talked about the size of the page image, currently it's set to 70vh, and looks really small with poor readability.
Is it possible to set the height to 100% viewer height minus 120 px (or whatever the header height ended up to be)

@xinyil whoops, noticed the header is flexible size. I'll limit it correctly.
re: the image; I set to 70vh because using the 100%-120px makes it extend off the screen for short but wider screens. can revisit to make it extend farther to the right, but I think some of the images are tall enough that it's tough without stretching them or having them go off the bottom of the page.

@thatbudakguy the footer on this page with copyright and manifest logo are overlapping the admin suppress form and making the button and second option unclickable in certain cases (probably depends on number of items in the left sidebar and size of monitor).  Maybe this is what Katie was running into ?

"turn on deep zoom will hide side bar by default"
going to deep zoom will actually open the side bar if it was collapsed already in annotation page...

yeah, I need to add to logic to check if the sidebar is already open. what do you mean by it becoming the open/collapse button?

new behavior:

when switching to deep zoom, if the sidebar is open it will close
when switching to annotation view, if the sidebar is closed it will open
sidebar doesn't toggle otherwise unless you tell it to

Tested:

switched to deep zoom with sidebar open, it automatically closed
switched from deep zoom to annotation, it automatically opened
hide the sidebar in annotation view and switch to deep zoom, it stays closed
open the sidebar in deep zoom view, it opens and behaves as I would expect.

I did notice a weird white block on the top-right corner of the deep zoom view that goes away when I open the side menu - it's almost as if the menu is showing up over there.

[ ] fix white bar on deep zoom view when sidebar is closed

White bar is now gone from deep zoom view.


Data Preprocessing

Steps on how to clean and preprocess voice recordings so that the data is standardized and ready for analysis
Acceptance criteria:
Apply resampling techniques to standardize the sampling rate, remove background noise using filtering algorithms, and perform Fourier Transform for frequency domain analysis.

@SaketMunda - For our reference https://www.kdnuggets.com/2020/02/audio-data-analysis-deep-learning-python-part-1.html


Use Optional in docs

As part of https://github.com/tiangolo/typer/issues/124, I updated the initial docs that introduce Optional for values that default to None.
We should have all the docs that have CLI arguments or CLI options with a default value of None to be declared using Optional[some_type], that way the editor will be able to help to detect unsafe operations that assume that the value is not None.
The quick intro to Optional is now here: https://typer.tiangolo.com/tutorial/#python-types

will be working on it 🥰

Thanks @rkbeatss ! :rocket: :cake:


{seq,index}_scan_executor should fail when operation failed

In https://github.com/cmu-db/peloton/blob/master/src/backend/executor/seq_scan_executor.cpp#L141 and https://github.com/cmu-db/peloton/blob/master/src/backend/executor/index_scan_executor.cpp#L182, when the executor uses the txn manager to perform read, the txn manager may return false (e.g. 2PL txn manager may fail to acquire read lock). If so, the executor should check the result of PerformRead and also report failure

@ranxian issue solved?

Solved in this commit:
https://github.com/cmu-db/peloton/pull/96/commits/e2fbb9e0668d12f3302e3457809f166e5c3a17d3


Unexpected server response when I'm following the tutorial

Hi,
I've tried to follow the node tutorial here:
https://dev.mixer.com/guides/chat/chatbot.html
and I'm getting this as a response:

Socket error
Error: unexpected server response (400)
at ClientRequest.response (C:\node_modules\ws\lib\WebSocket.js:719:15)
at Object.onceWrapper (events.js:277:13)
at ClientRequest.emit (events.js:189:13)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:556:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
at TLSSocket.socketOnData (_http_client.js:442:20)
at TLSSocket.emit (events.js:189:13)
at addChunk (_stream_readable.js:284:12)
at readableAddChunk (_stream_readable.js:265:11)
at TLSSocket.Readable.push (_stream_readable.js:220:10)

This is my code (minus the token)
https://gist.github.com/lee-brown/a2332fd8861c156a5987c1b22667eae8
Is this an issue with the node client/api or is it a problem with my code? Any help would be greatly appreciated thank you!

Just to add on to this issue, I get exactly the same error when I literally copy and paste the code on the tutorial which has my authenication token.

I have the same issue. Is there a workaround other than just use plain websockets?


Quick PR to get main up to date with prediction models branch

This PR updates the main branch with 2 small commits that should have been included in #110

@cstillwellusgs: I think this code difference is why you were seeing outdated targets when you tried to copy the _targets and /out/ folders.


[!] ReferenceError: identifier 'xxx' undefined

when hook a method, This error always happens.

Hey, do you still have this issue? Can you provide a test case so I can try to reproduce this? I will re-open the issue once i have more information


Add Erwinson Mesa to Contributors list

Hi  @erwinsonljc, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hi @Roshanjossey , Thank You for this great tutorial, it's very helpful for me to understand git. Anyway this is my first journey in git and open source community.
I feel very excited when doing every step in this tutorial and very happy when finally make my first pull request (until you merged it of course).

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Not fully working on iOS 8.4

Hi,
I tried using this Plugin, but it fails to find my beacon. I typed in the UUID and Major / Minor but the app doesn't display an alert, even though it's right next to the beacon. Bluetooth is enabled. I'm using the example Project, almost unmodified.
Any help?
Also XCode keeps posting this over and over in the Log:
 HelloCordova[42913:1593298] Loading Location authentication...
 HelloCordova[42913:1593298] This app is authorized to use location.

Hello,
I just test the example on iOS 8.4 and it's working for me.
Be sure that you have added all the Cordova plugins required with the cordova plugin add command.
Be sure that you have specified the correct infos and give an ID to each beacon in the ibeacon.initialize method.
Note that it does not work on emulator, you have to test it on a real device.
On which device did you tested ?
If this did not work, feel free to send me a zip of your project.
Best.

Thanks for the quick reply.
Unfortunately none of the tips mentioned helped me. I re-downloaded your Example Project, removed and reinstalled all plugins, added Cordova Platform iOS, changed the script in Index.html to reflect the UUID of my beacon and the major / minor numbers as well, and then ran the App successfully on my iPhone 6, iOS 8.4. The Beacon is right next to the iPhone and all I see is "Look at my awesome iBeacon app!" but no alert popping up. There is nothing in the WebView Console either, no Errors, no Warnings.

Send me your sample project, I will compare it with mine.

I have forked your repo and uploaded my changes there. Basically I just changed the IDs and the rest remains untouched. Like I said, no alerts, whatsoever. The Beacon is right next to the iPhone... :/

I was about to ask you the same question. I use also the last version of Cordova : 5.1.1.
What is your OS X and Xcode version ?

Did you enabled locations services and authorize the application to access location services ?

The last thing I thing about is the ibeacon itself. Do you have the ability to test on another ibeacon ?
Personnaly, I use this one : http://ibeacon.accent-systems.com/shop/ibks105-kits.
Let me know.

Hi, thank you for your help and incredible work on the Project.
After cracking my head open and trying out Beacons on my iPad, I realised that it must be something specific to my iPhone 6 Set-up. Both the iPad and iPhone were jailbroken, but the iPad was showing Beacons effortlessly. Further investigating the issue led me to the fact I had a Tool from Cydia installed called "Fake GPS". Apparently it was causing the iPhone to not see Beacons, even though it was turned off. Disabling the Cydia Substrate Library of this Tool made your project work flawlessly. Thank you very much again (:


Character Controller: Slerp position

Currently, when the controller moves it has a subtle jank between the physics component and the threejs ones.
I didn't notice this as much to items anchored to the anchor constraint visually, but definitely the capsule.
This may be a problem if it's setting position by using a BodyState as position and interpolation are managed by the BodySystem
but if it uses a threeObject with direct manipulation on a physics step timer. (which I think it is) we can do it

Closed in #83


Added msservice metadata to resolve build warnings

Docs Build status updates of commit 8716aae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-5.0.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-5.0.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e9443e5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-0.10.0/context-persistence.md
:bulb:Suggestion
View (azps-0.10.0)
Details

docs-conceptual/azps-0.10.0/get-started-azureps.md
:bulb:Suggestion
View (azps-0.10.0)
Details

docs-conceptual/azps-0.10.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-0.10.0)
Details

docs-conceptual/azps-1.8.0/context-persistence.md
:bulb:Suggestion
View (azps-1.8.0)
Details

docs-conceptual/azps-1.8.0/get-started-azureps.md
:bulb:Suggestion
View (azps-1.8.0)
Details

docs-conceptual/azps-1.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-1.8.0)
Details

docs-conceptual/azps-2.8.0/context-persistence.md
:bulb:Suggestion
View (azps-2.8.0)
Details

docs-conceptual/azps-2.8.0/get-started-azureps.md
:bulb:Suggestion
View (azps-2.8.0)
Details

docs-conceptual/azps-2.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-2.8.0)
Details

docs-conceptual/azps-3.8.0/context-persistence.md
:bulb:Suggestion
View (azps-3.8.0)
Details

docs-conceptual/azps-3.8.0/get-started-azureps.md
:bulb:Suggestion
View (azps-3.8.0)
Details

docs-conceptual/azps-3.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-3.8.0)
Details

docs-conceptual/azps-4.8.0/context-persistence.md
:bulb:Suggestion
View (azps-4.8.0)
Details

docs-conceptual/azps-4.8.0/get-started-azureps.md
:bulb:Suggestion
View (azps-4.8.0)
Details

docs-conceptual/azps-4.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-4.8.0)
Details

docs-conceptual/azps-5.0.0/context-persistence.md
:bulb:Suggestion
View (azps-5.0.0)
Details

docs-conceptual/azps-5.0.0/get-started-azureps.md
:bulb:Suggestion
View (azps-5.0.0)
Details

docs-conceptual/azps-5.0.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-5.0.0)
Details

docs-conceptual/azps-0.10.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/azureps-in-docker.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/formatting-output.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/install-az-ps-msi.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/manage-subscriptions-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-az-1.0.0.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-az-2.0.0.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-az-3.0.0.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-from-azurerm-to-az.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/new-azureps-module-az.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/queries-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/uninstall-az-ps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/using-psjobs.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-1.8.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/formatting-output.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/install-az-ps-msi.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/manage-subscriptions-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/migrate-az-1.0.0.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/migrate-from-azurerm-to-az.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/new-azureps-module-az.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/queries-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/uninstall-az-ps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/using-psjobs.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-2.8.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/formatting-output.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/install-az-ps-msi.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

This comment lists only the first 50 files in the pull request.

docs-conceptual/azps-0.10.0/context-persistence.md

Line 47, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Get-AzSubscription?view=azps-1.8.0

docs-conceptual/azps-0.10.0/get-started-azureps.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-conceptual/azps-0.10.0/release-notes-azureps.md

Line 1281, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 2521, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-1.8.0/context-persistence.md

Line 47, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Get-AzSubscription?view=azps-1.8.0
Line 51, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Set-AzContext?view=azps-1.8.0
Line 69, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/az.accounts/set-azcontext?view=azps-1.8.0

docs-conceptual/azps-1.8.0/get-started-azureps.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-conceptual/azps-1.8.0/release-notes-azureps.md

Line 794, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-2.8.0/context-persistence.md

Line 47, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Get-AzSubscription?view=azps-1.8.0

docs-conceptual/azps-2.8.0/get-started-azureps.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-conceptual/azps-2.8.0/release-notes-azureps.md

Line 502, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 1742, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-3.8.0/context-persistence.md

Line 47, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Get-AzSubscription?view=azps-1.8.0

docs-conceptual/azps-3.8.0/get-started-azureps.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-conceptual/azps-3.8.0/release-notes-azureps.md

Line 1376, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 2616, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-4.8.0/context-persistence.md

Line 47, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Get-AzSubscription?view=azps-1.8.0

docs-conceptual/azps-4.8.0/get-started-azureps.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-conceptual/azps-4.8.0/release-notes-azureps.md

Line 2294, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 3534, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-5.0.0/context-persistence.md

Line 47, Column 1: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /powershell/module/Az.Accounts/Get-AzSubscription?view=azps-1.8.0

docs-conceptual/azps-5.0.0/get-started-azureps.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-conceptual/azps-5.0.0/release-notes-azureps.md

Line 2469, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 3709, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 70eb6c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-0.10.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-0.10.0)
Details

docs-conceptual/azps-1.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-1.8.0)
Details

docs-conceptual/azps-2.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-2.8.0)
Details

docs-conceptual/azps-3.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-3.8.0)
Details

docs-conceptual/azps-4.8.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-4.8.0)
Details

docs-conceptual/azps-5.0.0/release-notes-azureps.md
:bulb:Suggestion
View (azps-5.0.0)
Details

docs-conceptual/azps-0.10.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/azureps-in-docker.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/context-persistence.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/formatting-output.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/install-az-ps-msi.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/manage-subscriptions-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-az-1.0.0.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-az-2.0.0.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-az-3.0.0.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/migrate-from-azurerm-to-az.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/new-azureps-module-az.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/queries-azureps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/uninstall-az-ps.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-0.10.0/using-psjobs.md
:white_check_mark:Succeeded
View (azps-0.10.0)

docs-conceptual/azps-1.8.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/context-persistence.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/formatting-output.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/install-az-ps-msi.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/manage-subscriptions-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/migrate-az-1.0.0.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/migrate-from-azurerm-to-az.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/new-azureps-module-az.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/queries-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/uninstall-az-ps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/using-psjobs.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-2.8.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/context-persistence.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/create-azure-service-principal-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/formatting-output.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/install-az-ps-msi.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/manage-subscriptions-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/migrate-az-1.0.0.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/migrate-az-2.0.0.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/migrate-from-azurerm-to-az.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/new-azureps-module-az.md
:white_check_mark:Succeeded
View (azps-2.8.0)

docs-conceptual/azps-2.8.0/queries-azureps.md
:white_check_mark:Succeeded
View (azps-2.8.0)

This comment lists only the first 50 files in the pull request.

docs-conceptual/azps-0.10.0/release-notes-azureps.md

Line 1281, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 2521, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-1.8.0/release-notes-azureps.md

Line 794, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-2.8.0/release-notes-azureps.md

Line 502, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 1742, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-3.8.0/release-notes-azureps.md

Line 1376, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 2616, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-4.8.0/release-notes-azureps.md

Line 2294, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 3534, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

docs-conceptual/azps-5.0.0/release-notes-azureps.md

Line 2469, Column 1: [Suggestion-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```). NOTE: This Suggestion will become a Warning on 1/29/21.
Line 3709, Column 0: [Suggestion-sensitive-language] Term 'whitelist' is sensitive and should not be used in content or code. Usage: '* Added new sizes to the whitelist of VM sizes for which accelerated networking will be turned on when using the simple param set for '

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Categorical variables need to be hashable

I've have a scikit-learn compatible model that receives some pretty complex parameters.
For example, if implementing a neural network it can receive the layers definition as a list of sizes, the list has the number of neurons in each layer (I know this would be hard to optimize with skopt and maybe a different approach would be better, but imagine it has to be like this for the sake of the argument). When I try to give BayesSearchCV a categorical search space dimension with each category corresponding to a different neural network architecture I get the following error:
TypeError: unhashable type: 'list'

Traceback (most recent call last):
...REDACTED...
  File \"/opt/conda/lib/python3.6/site-packages/skopt/space/space.py\", line 423, in __init__
    self.transformer.fit(self.categories)
  File \"/opt/conda/lib/python3.6/site-packages/skopt/space/transformers.py\", line 53, in fit
    self.mapping_ = {v: i for i, v in enumerate(X)}
  File \"/opt/conda/lib/python3.6/site-packages/skopt/space/transformers.py\", line 53, in <dictcomp>
    self.mapping_ = {v: i for i, v in enumerate(X)}
TypeError: unhashable type: 'list'

I've looked at the code and I understand the need for the CategoricalEncoder to then use a one-hot encoding and the quite-standard implementation in skopt/space/transformers.py works great for many cases but not for unhashable types.
I propose relaxing the constraint that categories in a categorical search space need to be hashable to just having an equality relation defined. I realize that such an implementation would make the transform function slower but it is barely called in skopt so I think it could be a good tradeoff. Moreover, that sort of implementation could be a fallback in case hashing doesn't work.
What do you think?
I might have time soon to make a sample pull request.

The hashable constraint comes from Python's dictionary which we use to map from index to actual value and back. We'd have to rewrite this with a custom data structure that allows unhashable types.
A workaround could be using tuples instead of lists in your complex types. Tuples are immutable which means they are hashable (and can be used as key in a dictionary).

Yes, rewritting with a custom data structure is what I’m proposing. And maybe only use it when types are not hashable while raising a warning.
I’m using tuples now as the library underneath supports it, but it is a bit of a pain as my data comes from a json file and I have to recursively convert nested lists to nested tuples. If it were just this usecase I’d agree to leave my workaround but I think there could be other usecases in which this problem would come up.
For example, a categorical dimension could be a list of custom loss functions, or a list of cross-validation objects, or any other thing not hashable and not easily convertible to a hashable type. Not to mention that in some cases the underlying estimators would have to be wrapped to undo the conversion (or some other mehtod such as gp_minimize would have to be used).
All in all, I think the restriction, although enforced by python’s dict class, is too strong. And I’m willing to try build an implementation if you think you would accept such a thing.
Thanks!

Hard to decide if this is a change to accept or not. My personal starting point is that a lot of thinking has gone into dict and its design. There are a lot of corner cases to handle/think about to create a replacement that works everywhere a dict works and works for additional use cases. Combined with the experience that the complexity that comes with making something more general grows exponentially.
So without a proposed solution I would say writing individual small bits of glue for the cases where code really insists on a list instead of a tuple and you know that it is safe to convert back and forth is the way to go. Less exciting but overall quicker.
As an example of why you can't use a list as key:
my_key = [1, 2, 3]
clever_dict = {my_key: 'abc'}
my_key[1] = 42
print(clever_dict.keys())

what should the last line print? I am not sure I know a good answer to that question.

Having the same problem. Surely there are quite a number of use cases that require non-hashable Categorical values, making this a very useful feature.

Just one another example when it's required non-hashable 'Categorical` values:
### Search spaces  vec_search = {     'union__vec': Categorical([CountVectorizer(), TfidfVectorizer()]),     'union__vec__tokenizer': Categorical([nltk_tokenize, None]),      'union__transformer_weights': Categorical(({'vec': 1.0, 'text_stats': 1.0},                                                                          {'vec': 2.0, 'text_stats': 1.0})) }
Last line raises TypeError: unhashable type: 'dict'.
Here, I want to use BayesSearchCV for tuning transformer_weights in sklearn.compose.ColumnTransformer.

In case this is useful to someone: I had issues with the parameters for scikit learn's vectorizers. F.eks. HashingVectorizer takes a n_gram_range parameter of type tuple, and this isn't supported by skopt. My solution was to subclass the vectorizer so that it could take strings, which I then convert to tuples. It's important to understand that scikit learn estimators must not play with the input parameters in the init method, but you are free to do that in the fit method:
class HashingVectorizerCustom(HashingVectorizer):
    def fit(self, X, y=None):
        if isinstance(self.ngram_range, str):
            self.ngram_range = eval(self.ngram_range)
        return super().fit(X,y)

Recently, I faced the same issue.
I want to search different class_wieght for a classifier.
I find one workaround is defined HashableDIct class yourself
There a lot of ways to do it.
https://stackoverflow.com/questions/1151658/python-hashable-dicts
class HashableDict(dict):
    def __hash__(self):
        return hash(tuple(sorted(self.items())))

## search space
 sgd_search_params = {
   'clf__loss': Categorical(['log', 'modified_huber']),
   'clf__class_weight': Categorical([HashableDict({0: 0.3, 1: 0}), HashableDict({0: 0.8, 1: 0}))
}
##

I ran into the same issue and solved it by creating a CategoricalList to extend the Categorical class. This way I can use something like [[1, 2, 3], [ 1, 4, 16], [1, 5, 25]] to tune for one of the three sublists.
Parameters can be defined like this:
htune_params = {
    'mlp_architecture': CategoricalList([[32, 16], [16]]),
}

This is my implementation of CategoricalList:
from skopt.space import Categorical

class CategoricalList(Categorical):
    def __init__(self, list_):
        super().__init__(self._convert_hashable(list_))

    def _convert_hashable(self, list_of_lists):
        return [self._HashableListAsDict(list_)
                for list_ in list_of_lists]

    class _HashableListAsDict(dict):
        def __init__(self, arr):
            self.update({i:val for i, val in enumerate(arr)})

        def __hash__(self):
            return hash(tuple(sorted(self.items())))

        def __repr__(self):
            return str(list(self.values()))


Improve language in server.en.yml

Proper capitalisation, spelling/grammar fixes, more consistent examples.

Thank you very much!

Quick turnaround! Thanks @jfromaniello!


Contract interactions V2

Is your feature request related to a problem? Please describe.
PR https://github.com/0xs34n/starknet.js/pull/498 refactored and fix contract interactions, but did not change basic concepts of calling contracts.
Contract class work with an array of compiled data
.mint(['123','567'...])

or arguments
.mint(a,b,c)

in both cases argument key is lost, only function that handle keys do not validate agains abi CallData.compile({a:123, b:567, ...})
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Issue https://github.com/0xs34n/starknet.js/issues/140 clearly represents the problem when the user wants to ensure key: value pairs are exactly matched against abi.
Describe the solution you'd like
To ensure such a case user should be able to call the Contract method with an object argument containing data.
.min({a: 123, b:567})

How to implement

Contract build need to be able to handle ...args in such a way that it can distinguish between arguments and object invocation.
Problem is that first rgument can be an object if it is a struct data and in such a case we can't distinguish between these two.
It can be also an array of arguments or one argument of type array
Update validator to check key pairs between abi and provided object, and throw an error in case of mismatch, more parameters or fewer parameters.

It can be done by implementing an additional method, ex. CallDara.args(), in such case we can flag data as object arguments. The call will look like this:

contract.min(CallData.args({a: 123, b:567, ...}));

After some experiments, the only way to implement this would be to create a method like
CallData.prepare(args: object, abi) that will validate arguments and flag as prepared
and then use them for calling contracts like:
const data = {
a: 1,
b : tuple(1,2)
}
contract.args(data).somemethod();

But a better effort would be to just skip this and implement TS ABI types validation.

Closed in favor of https://github.com/0xs34n/starknet.js/issues/140


refs #47 Fix for ActiveModel::Error deprecation warnings on Rails 6.1

Fix for deprecation warnings like this
DEPRECATION WARNING: Calling `<<` to an ActiveModel::Errors message array in order to add an error is deprecated. Please call `ActiveModel::Errors#add` instead. (called from ...

@ta-ando  Thanks!
I just want to add more tests for TelNumber and UrlTest.
I will create another PR.


Fix deletion code example in populators for collections

in http://trailblazer.to/gems/reform/populator.html at the "delete" section this code is incorrect:
collection :songs,
  populator: ->(fragment:, **) {
    # find out if incoming song is already added.
    item = songs.find { |song| song.id.to_s == fragment["id"].to_s }

    if fragment["delete"] == "1"
      songs.delete(item)
      return skip!
    end

    item ? item : songs.append(Song.new)
  }

return skip! crashes with a LocalJumpError.

@kofronpi what version of Ruby are you using?

@myabc 2.4.0

@kofronpi I believe this down to a regression in Ruby 2.4.0 where you cannot return from a lambda. See bug #13090: https://bugs.ruby-lang.org/issues/13090
I hit the same issue and had to work around it (https://github.com/trailblazer/roar-jsonapi/commit/c6b49332940de2dbce7e169127b1a6c323dbe3b2)
This has been fixed on HEAD: https://github.com/ruby/ruby/commit/91587f6b63df794db6b4b2ce8f94f78344044ff2

@myabc very interesting, thanks. I hope they release 2.4.1 soon !


Add Julia demo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Probably would benefit fromhttps://github.com/parca-dev/parca-agent/pull/1051 as well

Hey @vchuravy, thank you for sharing this! You are right, parca-dev/parca-agent#1051 would be needed as Julia/LLVM appears to support JITDUMP only, no Perf map.
And similarly to libperf-jvmti.so (#20), the dump is created in a directory that would need to be discovered by the agent, pattern: ${JITDUMPDIR:-${HOME:-.}}/.debug/jit/llvm-IR-jit-YYYYMMDD.XXXXXX/jit-${PID}.dump

Also the perf LLVM module saves temporarily debug objects in ~/.debug/jit, remember to clean that folder frequently.

https://github.com/llvm/llvm-project/blob/llvmorg-15.0.6/llvm/lib/ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp#L297-L336


Add etag header to responses.

[x] update content providers to return a contentId in addition to content
[x] update handlers to use new content providers
[x] update handlers to respond to HEAD requests & set ETag header.
[x] add routes for HEAD requests.
[x] add tests for HEAD requests.
[x] add a ticket to push etag generation into the data provider so both network hits & db hits are avoided.

Resolved in PR #60


Update readme.md

Readme file could use an update for current usage of the charm, description of using with/without kubeflow bundle, etc.

readme updated by #29


Named import

For multiple icons usage, it's better to have named import.
So instead of:
import BsBox from "svelte-icons-pack/bs/BsBox";
import Bs123 from "svelte-icons-pack/bs/Bs123";
import BsActivity from "svelte-icons-pack/bs/BsActivity";

We can import it:
import { BsBox, Bs123, BsActivity } from "svelte-icons-pack/bs";

hi

Try version 3.x
https://www.npmjs.com/package/svelte-icons-pack

<script>
  import { Icon } from 'svelte-icons-pack';
  import { AiOutlineNodeExpand } from 'svelte-icons-pack/ai';
</script>

<Icon src={AiOutlineNodeExpand} />


lint/format typescript files in pre-commit hook

not sure how we've managed to not notice this for so long :thinking:

Warnings

:warning:

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS against 40e109cf64e5a0b1ab902d30bb17964692dab7f7


IE Javscript compatibility

Is it possible tu use Microsoft Edge webview to execute javascript instead of MSHTML or use a polyifill for common js documents methods?

@Guertz Unfortunately, MS Edge has no API for embedding like MSHTML. However, I can confirm that babel.js works in IE10/IE11 and can be injected into webview on start (see counter-go ReactJS example). There should no problems with using latest ES features with Babel.js. Are there any particular functions/APIs that you lack?

I needed support to work with HTML5 template element and features like Object.assign. Babel.js solved the problem
Great work!! Thanks a lot


user consent withdrawal date regression

reverts bug introduced by https://github.com/uwcirg/truenth-portal/pull/4343 , which incorrectly started using the oldest (not most recent) user_consent as last valid consent prior to withdrawal.
includes migration to clean up problem cases. required careful re-assessment of consent/withdrawal dates for a number of patients found to have qb_timeline revisions after applying patch above. see https://movember.atlassian.net/browse/IRONN-210 for more detail.
(this is #4358 redone, as required with branch renaming)

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file manage.py:

Line 931:80: E501 line too long (88 > 79 characters)

In the file portal/migrations/versions/3c871e710277_.py:

Line 171:80: E501 line too long (87 > 79 characters)
Line 186:80: E501 line too long (86 > 79 characters)

In the file portal/migrations/versions/edb52362d013_.py:

Line 38:80: E501 line too long (96 > 79 characters)
Line 80:80: E501 line too long (92 > 79 characters)

In the file portal/views/patient.py:

Line 508:80: E501 line too long (85 > 79 characters)
Line 509:80: E501 line too long (81 > 79 characters)

In the file portal/views/user.py:

Line 901:80: E501 line too long (82 > 79 characters)

@ivan-c , the bulk of the work here you've already seen in the two additional branches that were cut deeper off of this one.  a review here is primarily a rubber stamp.


Check protocol witnesses using access scopes.

...rather than relying on the access-as-spelled, which may be greater than the effective access due to parent scopes.
(Some of this will get cleaned up with SR-2209.)
rdar://problem/27663492

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test

@slavapestov or @CodaFi, mind reviewing this?

Oops, broke a crash case (in addition to the phantom copyforward issue that all the bots are seeing).

@swift-ci Please test

Passed OS X.
But Linux timed out, like all the others

@swift-ci Please test Linux platform

@swift-ci Please smoke test OS X platform

@swift-ci Please test Linux platform

@swift-ci Please smoke test OS X platform

@swift-ci Please smoke test OS X platform

@swift-ci Please test Linux platform

Okay, this got all the way to Foundation tests on Linux, merging.

Review ping for @slavapestov or @rjmccall?

Looks good.


Supporting forward slashes in topic names

Since there is an upcoming DDS spec that will allow forward slashes in topic names, ROS 2 is planning to move away from using {partition + topic} for our "namespacing" concept (see https://github.com/ros2/rmw_opensplice/pull/176) and use just topic names without partitions instead.
The other vendors we support for ROS 2 (Connext, FastRTPS) currently allow forward slashes in topic names: are you open to allowing slashes in OpenSplice in advance of the new spec?

There is a proposal for a change of supported characters in topic names:
http://issues.omg.org/issues/lists/dds-rtf5#issue-42236
This issue has not yet been discussed and it is therefor not a given that the proposed characters will indeed be added.
I'll start an investigation into the forward slash to see if we can add this to our product, will get back to you on this.

Thanks for clarifying that it's not certain yet, and for looking into it.

I'll start an investigation into the forward slash to see if we can add this to our product, will get back to you on this.

@michielb-prismtech Any news on this?

@dirk-thomas I've ran into an issue with one of our services working on a solution

@michielb-prismtech Any update on this?

@dirk-thomas sorry forgot to mention on this ticket, '/' support is in the master branch

'/' support is in the master branch

That is great news - thank you.
For Linux we can re-roll our own Debian package with that change. How about the installers for macOS and Windows. Can you somehow provide us with an updated version of those (which should be also publically downloadable for ROS users)?

Sorry missed the previous mail notifcation.
I can create a set of new installers, do you want me to cherry-pick the metaconfig.xml rename to ospl_metaconfig.xml in this installer as well?

We have built the new Debian package from the latest commit of the master branch. For consistency I would say it makes sense to use the same across all platforms.
I would rather not pick additional changes from future versions. While the name of the config isn't great atm it seems to work fine.

A related question: the next ROS 2 release in June - Bouncy - will target Ubuntu 18.04 as well as Visual Studio 2017. Do you think it would be feasible to provide binaries for those by that time?

@michielb-adlink Friendly ping.

@dirk-thomas some testing indicates that it should be possible to compile OpenSplice with some minor changes on both Ubuntu 18.04 and Visual Studio 2017. Waiting for approval for new build systems

@michielb-adlink Any update on this?

@dirk-thomas
Almost done, had a setback with vs2017
Just pushed the ubuntu1804 support (only buildsystem changes)

@michielb-adlink Do you have a timeline for the VS2017 binaries? Or do you expect that the VS2015 ones will be just fine?

@dirk-thomas available now

Thanks, I deployed the Visual Studio 2017 binaries on our executors.


Updating desispec

This PR makes the necessary changes to work with https://github.com/desihub/desispec/pull/713 and https://github.com/desihub/desispec/pull/725

New target PR https://github.com/desihub/desispec/pull/734

@felipeaoli I had to make a few changes on your plots to make it work with the new version of QL please take a look at this part of the code: https://github.com/desihub/qlf/pull/284/files#diff-74e3bf6df75d105e97ac44e22c55aca7R345


tsProject.src() is too slow

Hi,
I have a test project within paeckchen which shows the usage with gulp-typescript.
While setting up a watch task I've discovered that it is very slow to use tsProject.src() instead of gulp.src(...).
Maybe thats because of caluclating the base path? But why is it so much slower than gulp with that task?

See #326, which is blocked by glob-stream#24. It's probably necessary to not use globs with gulp.src to resolve all files.

And it was concat!
Performance issues solved on my side. Thank you for the lead!

#326 has been fixed in the latest release.


NEXT.JS: Editor redirects to unknown.html after servlet errors out [bug]

Describe the bug
I am trying out the remote SPA feature together with NEXT.JS. I have seen that the same issue was in a previous issue but apparently this is still not resolved.
The issue has something todo with the initialisation of the ModelManager.
I have tried this with the WKND-App-Sample-Project and created a new page based on the next.js-template. After setting up the connection to localhost and switching to edit mode, the following error occures:

Also the editor redirects to http://localhost:4502/editor.htmlundefined.html
Package version
AEM-Version: Adobe Experience Manager 2021.12.6151.20211217T120950Z-211100
Sample repo:
https://github.com/Tylopilus/aem-nextjs-sample
To Reproduce
Steps to reproduce the behavior:
0. Install WKND

Insall https://experienceleague.adobe.com/docs/experience-manager-learn/assets/wknd-app.all-1.0.0-SNAPSHOT.zip?lang=en
Create new page /content/wknd-app/us/en/next.html as nextjs-page
Set SPA-Host to http://localhost:3000
clone repo from above and install with npm i
I needed to make changes to the next-assets-manifest-bundle, so a postinstall-script runs!
Start server with npm run dev
Go into edit mode of /content/wknd-app/us/en/next.html

Expected behavior
Page loads fine and lets editor place allowed components

Solved by bumping spa core version to 1.3.8


⚠ Bofrost.nl has degraded performance

In 47e222d, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 971 ms

Resolved: Bofrost.nl performance has improved in e774fa4 after 6 minutes.


Add survey event

This is still a work-in-progress, but I need some guidance. It's based on #26197.
Edit: I moved the event to sendProjectTelemetry, got rid of the url property, and added the test based on @sheetalkamat's in-person review.

@sheetalkamat the CI failure looks like my new unit tests cause the existing large file tests to crash. Any idea how they could be interfering?

@sandersn are those tests duplicate of existing tests that you have there by mistake ?

OK, I think this is in much better shape now. Thanks @sheetalkamat for your help.


buildPythonPackage: Add support for running tests in a separate derivation

Description of changes
Introduces a new argument to buildPythonPackage called separateChecks.
A passthru.tests.python attribute is added where the tests are run separately from building the package.
By removing check inputs from the main derivation we can drastically reduce build closures & reduce issues with circular dependencies.
For more motivations see the related tracking issue.
This work is a part of #272178.
Implications
With tests no longer running in the same derivation as the build it can be harder to find issues early.
OTOH debug cycles can be cut shorter as you don't need to wait for a package rebuild to find out that a test failed because it lacked networking access.
With tests running separately I expect iteration cycles to be quicker, once the new workflow has been adopted.
passthru.tests is evaluated by OfBorg. Checks for nixpkgs contributions should be fine.
It's possible we may want to add another Hydra attrset so it can find tests, or make Hydra smart enough to explore passthru.tests.
In this PR only one derivation has been converted as a PoC. Locally I have converted many more and also found some issues.
This seems to work out fine for most pure Python packages, but Pandas was problematic. I think that particular issue is because of a bug in pytest that I will take a closer look at.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm marking this as draft: Not because I don't think it's ready for review but because I think we need to have a discussion around the implications it has to remove python test running from the critical path in nixpkgs.

passthru.tests is evaluated by OfBorg. Checks for nixpkgs contributions should be fine.
It's possible we may want to add another Hydra attrset so it can find tests, or make Hydra smart enough to explore passthru.tests.

I think it would be useful to introduce a convention such as passthru.tests.package or passthru.tests.source to denote the tests that are part of the source.

I'm marking this as draft: Not because I don't think it's ready for review but because I think we need to have a discussion around the implications it has to remove python test running from the critical path in nixpkgs.

I think if we introduce such a convention, and then update our release* sets so Hydra pick these up that we're good to go.

Rebased & marked ready for review.

Considering the number of rebuilding packages, should this PR target the staging branch instead?

One thing I like about packageOverrides is that all tests are run again, which should ensure intercompatibility of the pinned versions. We'd lose this if a package doesn't depend on its test (and if we get rid of packageOverrides).

One thing I like about packageOverrides is that all tests are run again, which should ensure intercompatibility of the pinned versions. We'd lose this if a package doesn't depend on its test (and if we get rid of packageOverrides).

This is what I meant by:

I think we need to have a discussion around the implications it has to remove python test running from the critical path in nixpkgs.

I'm not sure what the fix for that is.
One thing I was considering to get some of those benefits is to push the responsibility of aggregating tests to buildPythonApplication/toPythonApplication (together with https://github.com/NixOS/nixpkgs/pull/272179), though that would only run tests for libraries depended on by applications, not loose libraries.

My suggestion is that the derivation produced by this new implementation adds automatically some passtrhu.test attribute or similar. This way we can simply run those tests if available, but still have no direct dependency over them. If we depend on them, then there's no gain: we'd need to rebuild always too.

@adisbladis, would there be a chance to learn about the considerations behind closing this PR? I look forward to it, and many people approve of the idea.

@adisbladis, would there be a chance to learn about the considerations behind closing this PR? I look forward to it, and many people approve of the idea.

I have burnt out on trying to accomplish meaningful change in the nixpkgs Python infra and I'm spending all that energy towards pyproject.nix & it's builders instead.


Export attributes

We currently store "mathematical attributes" independent of "object attributes". This doesn't really make much sense when it comes to exporting/importing GraphML. This will likely be blocked until https://github.com/graphp/graph/issues/114 is merged and we store everything in attributes.


Update version: CologneCodeCompany.XYplorer version 26.30.0400

Pull request has been created with komac v2.6.0 :rocket:

Resolves #186075

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


.gitignore is missing Intellij files

The current .gitignore is missing configuration files for the Intellij IDE (mainly the .idea folder). This is already present in other repositories such as nalgebra.

Would it make sense for intellij users to put /.idea in their personal global git ignores instead?

Probably, but many people don't set one up.

@jmeggitt Sounds like a good idea. Would you like to make a PR?


reverse_words: add --data_path, make save_path optional

Signed-off-by: Amit Beka<EMAIL_ADDRESS>

I changes it to 'reverse_words' without suffix because it creates multiple files (model and log)

Oops, I thought I had answered, that reverse_words.zip is preferable because reverse_words clashes with the directory name.

Thanks! A hint for the future: I do not receive any message when one makes a commit, so in order to notify me that something has been done, please post a reply here.

this explains it - thanks :)
On Sun, Jul 5, 2015 at 2:53 PM, Dmitry Bogdanov<EMAIL_ADDRESS>wrote:

Thanks! A hint for the future: I do not receive any message when one makes
a commit, so in order to notify me that something has been done, please
post a reply here.
—
Reply to this email directly or view it on GitHub
https://github.com/mila-udem/blocks-examples/pull/14#issuecomment-118615299
.


Make sure the correct types are returend for invoiceTemplate field

Resolve https://github.com/opencollective/opencollective/issues/5810
Related to https://opencollective.freshdesk.com/a/tickets/105406, https://opencollective.freshdesk.com/a/tickets/106697
Related PDF PR: https://github.com/opencollective/opencollective-pdf/pull/869

@Betree : Remove the graphql changes and made the invoiceTemplate field to the root Transaction interface.


Fix notations of loopback addresses

<IP_ADDRESS>/8 refers to only a single IPv4 address "<IP_ADDRESS>" that have the subnet mask <IP_ADDRESS>, but doesn't to <IP_ADDRESS>.
<IP_ADDRESS>/8, which is the exact definition of the loopback addresses [1][2], includes what the regex says (<IP_ADDRESS>-<IP_ADDRESS>).

Thanks!


Add PolicyException CRD

Signed-off-by: Matias Charriere<EMAIL_ADDRESS>Checklist

[x] Update changelog in CHANGELOG.md.

I guess this change is required for testing charts with PolicyExceptions when using app-test-suite

Yes, exactly. Sorry I forgot to mention it in the PR description :)


gpio_cdev way

There are two interface to access gpio pins: sysfs and gpio character device abi. I have tested them both:
device: rpi4, kernel: 4.19, crates: sh1106+linux-embedded-hal
let dc = Pin::new(24);
dc.export().unwrap();
while !dc.is_exported() {}
dc.set_direction(Direction::Out).unwrap();
dc.set_value(1).unwrap();

device: rpi4, kernel: 5.5, crates: sh1106+linux-embedded-hal(git version, with gpio_cdev feature enabled)
let mut chip = Chip::new("/dev/gpiochip0").unwrap();
let line = chip.get_line(24);
let handle = line.request(LineRequestFlags::OUTPUT, 1, "test").unwrap();
let dc = CdevPin::new(handle).unwrap();

The second one does not work.
Other code are exactly the same:
let mut spi = Spidev::open("/dev/spidev0.0").unwrap();
let options = SpidevOptions::new()
            .bits_per_word(8)
            .max_speed_hz(400_000)
            .mode(SpiModeFlags::SPI_MODE_0)
            .build();
spi.configure(&options).unwrap();

// get dc ...

let cs = sh1106::builder::NoOutputPin::new();
let mut display: GraphicsMode<_> = Builder::new().connect_spi(spi, dc, cs).into();
display.init().unwrap();
display.flush().unwrap();

// draw some text ...

I am not sure whether it is a bug or I made some mistakes.

I'm afraid I'm not familiar with either of the GPIO interfaces you mentioned so I can't offer much help. Do you have a logic analyser or scope handy? It would be useful to confirm that data is being output on the SPI bus and the DC pin correctly.

Unfortunately, I am actually not familiar with (low-level) embedded things.

What if you use the old sysfs method on the newer kernel? It's deprecated but AFAIK it should still work. If it works then, you can at least narrow out the SPI device from being the problem.
Additionally do you have any kind of tool to measure voltage? You could write a test program using both methods that just toggles the pin on and off every second, and use something like a multimeter or even just an LED (with a resistor - don't burn your chip!) to see if the correct pin is being toggled.

I cannot find anything related to gpio in /sys on newer kernel, most likely only /dev/gpiochip0 can be used.

Things usually don't get removed immediately when they're deprecated. I think it's just a kernel compilation option that's been turned off, but if you've not compiled your own kernel it might be annoying to change.
What about that measurement tool? Got a multimeter? LED and resistor?
To test the SPI bus you could even use a pair of headphones with a normal audio jack and a resistor in series. I used headphones to debug a video signal by listening to the frequency back when I didn't have an oscilloscope, and if you slow down the SPI bus to a very low frequency you should be able to hear it.


Enable console for installers and improve docs

Let's enable console in installers and add few words about enabling of console.

Would be perfect to have a console enabled by default for debug builds! I made this wish for a New Year :)

Would be perfect to have a console enabled by default for debug builds! I made this wish for a New Year :)

Well, some kind of this was open for a while here https://github.com/lf-edge/eve/pull/2975. But during discussion with @eriknordmark and @mikem-zed we decided that we should find better way to compose "debug builds", e.g. using conposition of yml templates or so. Before stabilization of such approach we should at least have doccumentation, which I added here.

As I said, this is just a wish, and wishes not always come true:)

As I said, this is just a wish, and wishes not always come true:)

+1 for the wishes about have console enabled for debug builds...


jsonify function overrides headers when no arguments are passed

If there is no status_code or headers kwarg passed to the jsonify function, it should not override the status_code and headers set by flask.jsonify
This is an issue introduced by updates in Flask 1.0

resolved by pr #10


[Bandcamp]: ValueError: unknown url type

Hello,
I started getting an error when trying to download bandcamp mp3 files with youtube-dl. For example, if you try to grab this URL  http://phonelosers.bandcamp.com/track/i-need-my-medication you will get an error that looks something like this: ValueError: unknown url type: //popplers5.bandcamp.com/download/track...
Thanks!

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


Clarify relation of custodhist and acqhist now that they no longer nest

Submitted on Friday, September 27, 2013 - 1:28am
Submitted values are:
Name:  Nicola Frean
Affiliation: Alexander Turnbull Library, National Library of New Zealand
Does this represent an official comment from your affiliated group? No
Comment:
These comments are based on a brief group discussion around Michael Rush's
eamils to the EAD listserv (thankyou Michael!):

Disentangling Descriptive Elements'
Is the last element of Custodhist automatically the same as immediate source
of acquisition, or is it to be repeated?

Description and see also references on both elements make usage clear in TL.


BUG: Calculate mean returns by date before mean return by quantile

Compute mean return by date. If by_date flag is false, then compute
and return the average of the daily mean returns (and also the
standard error of these daily mean returns).
Resolves: Issue #309

It looks like one of the issues is that in older versions of pandas, you can't groupby an index level by specifying the name of the level. I'll look into it a bit later.

The remaining failed unittests don't seem to come from any of the code I edited. They seem to result from a problem in commit e444e8da74a524ce42b172f9931c62597508a749. My logic is as follows:
Below is one of the failed test cases:
ERROR: test_average_cumulative_return_by_quantile_0 (alphalens.tests.test_performance.PerformanceTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/testenv/lib/python2.7/site-packages/parameterized/parameterized.py", line 392, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "/home/travis/build/quantopian/alphalens/alphalens/tests/test_performance.py", line 920, in test_average_cumulative_return_by_quantile
    0, after + 1), filter_zscore=False)
  File "/home/travis/build/quantopian/alphalens/alphalens/utils.py", line 754, in get_clean_factor_and_forward_returns
    filter_zscore)
  File "/home/travis/build/quantopian/alphalens/alphalens/utils.py", line 304, in compute_forward_returns
    period_len = diff_custom_calendar_timedeltas(start, end, freq)
  File "/home/travis/build/quantopian/alphalens/alphalens/utils.py", line 912, in diff_custom_calendar_timedeltas
    actual_days = np.busday_count(start, end, weekmask, holidays)
TypeError: Iterator operand 0 dtype could not be cast from dtype('<M8[us]') to dtype('<M8[D]') according to the rule 'safe'

It seems there is an issue in the way pandas stores dates. (https://stackoverflow.com/questions/31917964/python-numpy-cannot-convert-datetime64ns-to-datetime64d-to-use-with-numba)
I tested this using the following virtual environment configs (matching what was in the unittest):
conda create -q -n testenv --yes python=2.7 ipython flake8 numpy scipy nose matplotlib pandas=0.20.3 statsmodels seaborn

I tried checking out prior commits and got the error when testing on every commit going back to the e444e8da74a524ce42b172f9931c62597508a749 commit. The commit before that did not generate the error.
This might need to be listed as a separate issue, but I'm not sure why it would just be showing up now on the unittests, and not on prior commits.
Please let me know if I seem to be off track here.

Thanks for tracking this done @MichaelJMath, I bet you are right. Want to do another PR with your fix?

@MichaelJMath I believe the issue has arisen because we don't enforce a particular version of each module Alphalens uses. Currently we only force few pandas and python versions but the other modules might change with time, when new module versions are released. This issue might be due to a new numpy version then.

And the previous comment makes me think we might want to test few specific numpy versions too, as we do we pandas. So that we are sure Alphalens works fine with a specific subset of numpy/pandas/python versions, currently we are only sure about pandas/python versions.

@luca-s Sounds like a good idea, as long as we also test with the most recent version to detect regressions like these.

@twiecki I checked both pyfolio and zipline and they do not force a particular numpy version, so let's keep it this way. As you said, in this way we are able to detect regressions in more recent version of numpy.

@twiecki, I'll work on submitting another pull request this weekend.

@MichaelJMath Appreciate it!

I'll give it a shot. I probably won't get to it this weekend, but I'll put it on my to-do list for next weekend.

@twiecki we can still merge this PR, can't we?

Thanks guys!

@MichaelJMath This weekend I have some time to work on the missing test, so don't worry, I will do it.


gogland: fix debugger

Motivation for this change
gogland debugger was not working
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

also backported to 17.09.


Bullseye Update Needed

An update to python3 that would work on Bullseye is much needed.
I tried installing python2 on Bullseye to get this to work but ran into some issues getting rpi.gpio to build.  This in on an aarch64 Raspberry Pi OS install.

Same thing ! Please, an update is needed !
It seems to work after I modify the "/usr/share/pidesktop/python/pd-fixrtc.py" file.

adding the () at each "print" command
open files in text mode instead of binary everywhere there are opened ! "wb" or "rb" replace by "wt" or "rt"

This file is for python2, the "print" command and the "count" method on string, don't work the same way.
After modifying the file, I run "sudo dpkg --configure pidesktop-base" and all seems to be fine.
pd-check show the following status "install ok installed"
Before the modifications, it was "installed ok half-configured"

The script I modified, don't work well. The existing value of dtoverlay in "/boot/config.txt" is flush !
It's good to know, in ordrer to have the pi camera working !


[android] Migrate to Android X

React Native 0.60 will use AndroidX by default; because of this the dependencies are no longer available and causes webview to fail to build:

To fix this I've replaced all usages of the support libs to now use AndroidX and have enabled AndroidX usage in the gradle.properties file.
Notes

The android.support.FILE_PROVIDER_PATHS usage in the AndroidManfiest.xml remains the same on AndroidX - no changes needed
AndroidX requires a minimum compileSdkVersion version of 28 - which this library is already set to - however, if anyone overrides this (getExtOrDefault) to a lower version this will cause build issues. Should this be a major version?
The alternative to not using AndroidX would be to explicitly add the v4 support libs to the library dependencies, but I took the migrating to AndroidX approach.

Test Plan
App with these changes builds and displays a WebView on Android:

verify it doesn't build with RN 0.60 on master

@jamonholmgren First build screenshot on description was with me building from RN.60 and latest webview
Second build screenshot was building on RN.60 with this change applied.

This failure can be viewed quickly on the RN.60 version of the init template using the following:
npx @react-native-community/cli@next init --template=@invertase/template <myProjectName>
cd <myProjectName>
yarn add react-native-webview
react-native run-android

(uses auto-linking - so no changes required to link webview)


Normalise stemcell versions for v2 manifests

This was already done for v1 manifests where stemcells are specified/merged
into the resource_pools block. But not for v2 manifests where a top-level
stemcells block is used:

https://bosh.io/docs/manifest-v2.html#stemcells

The result of this was that commands such as bosh recreate would warn that
there are deployment changes present without listing any such changes:
/tmp/build/e55deab7 # bosh recreate api/1
Acting as user 'admin' on deployment 'dcarley' on 'my-bosh'
You are about to recreate api/1

Detecting deployment changes
----------------------------
Releases
No changes

…

Stemcells
No changes

Cannot perform job management when other deployment changes are present. Please use '--force' to override.

Adding a breakpoint and printing diff#summary revealed the cause:
From: /usr/local/bundle/gems/bosh_cli-1.3232.0/lib/cli/deployment_helper.rb @ line 119 Bosh::Cli::DeploymentHelper#inspect_deployment_changes:

    114:           nl
    115:         end
    116:       end
    117:
    118: require 'pry'
 => 119: binding.pry
    120:
    121:       diff.changed?
    122:     rescue Bosh::Cli::ResourceNotFound
    123:       say('Cannot get current deployment information from director, possibly a new deployment'.make_red)
    124:       true

[1] pry(#<Bosh::Cli::Command::JobManagement>)> puts diff.summary
± stemcells:
  - {"alias"=>"default", "name"=>"bosh-aws-xen-hvm-ubuntu-trusty-go_agent", "version"=>"3232.11"}
  + {"alias"=>"default", "name"=>"bosh-aws-xen-hvm-ubuntu-trusty-go_agent", "version"=>3232.11}

Thanks for the PR! At this point, ruby CLI is frozen and we're no longer publishing new gems while we focus on finishing up the new bosh-cli. I'm going to close this PR, but please feel free to give the new CLI a try when you get a chance - I don't think it exhibits this bug, and we'd appreciate your feedback.


pull request for e2e test at 12/23/2016 11:26:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ekf: return beta test ratio in get_innovation_test_status

Also requires changes on the firmware side

Looks good to me. Can you push to a branch in the upstream repo and reference it in your Firmware PR so that testing and merging can be coordinated.

@CarlOlsson I will merge it now. Please update https://github.com/PX4/Firmware/pull/8489.


Use torch.jit.scripts to save the quantized inception_v3 error

🐛 Bug

To Reproduce
Steps to reproduce the behavior:
import torch
import torchvision.models.quantization as models

model = models.inception_v3(pretrained=True, progress=True, quantize=False)
model.to('cpu')
model.eval()

# Fuse Conv, bn and relu
model.fuse_model()
torch.jit.save(torch.jit.script(model), 'inception_v3_quantized_float.pth')

Traceback (most recent call last):
  File "resnt18.py", line 193, in <module>
    torch.jit.save(torch.jit.script(myModel), saved_model_dir + scripted_float_model_file)
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/__init__.py", line 1255, in script
    return torch.jit._recursive.recursive_script(obj)
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/_recursive.py", line 534, in recursive_script
    return create_script_module(nn_module, infer_methods_to_compile(nn_module))
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/_recursive.py", line 296, in create_script_module
    return create_script_module_impl(nn_module, concrete_type, cpp_module, stubs)
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/_recursive.py", line 340, in create_script_module_impl
    create_methods_from_stubs(concrete_type, stubs)
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/_recursive.py", line 259, in create_methods_from_stubs
    concrete_type._create_methods(defs, rcbs, defaults)
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/_recursive.py", line 574, in compile_unbound_method
    create_methods_from_stubs(concrete_type, (stub,))
  File "/usr/local/lib/python3.6/dist-packages/torch/jit/_recursive.py", line 259, in create_methods_from_stubs
    concrete_type._create_methods(defs, rcbs, defaults)
RuntimeError:
Module 'QuantizableInception3' has no attribute 'AuxLogits' :
  File "/usr/local/lib/python3.6/dist-packages/torchvision/models/inception.py", line 161
        aux_defined = self.training and self.aux_logits
        if aux_defined:
            aux = self.AuxLogits(x)
                  ~~~~~~~~~~~~~~ <--- HERE
        else:
            aux = None
'QuantizableInception3._forward' is being compiled since it was called from 'QuantizableInception3.forward'
  File "/usr/local/lib/python3.6/dist-packages/torchvision/models/quantization/inception.py", line 196
        x = self._transform_input(x)
        x = self.quant(x)
        x, aux = self._forward(x)
        ~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
        x = self.dequant(x)
        aux_defined = self.training and self.aux_logits

Expected behavior

Successfully saved
Environment
Collecting environment information...
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Ubuntu 18.04.1 LTS
GCC version: (Ubuntu 6.5.0-2ubuntu1~18.04) 6.5.0 20181026
CMake version: version 3.14.7
Python version: 3.6
Versions of relevant libraries:
[pip3] numpy==1.18.0
[pip3] pytorch2sg==0.1.0
[pip3] torch==1.4.0
[pip3] torchvision==0.5.0
[conda] Could not collect
Additional context

Hi,
Thanks for the report!
This has been fixed in for GoogleNet in https://github.com/pytorch/vision/pull/1949, but not for Inception I believe.
cc @eellison


Auth_FAIL | NordVPN - OpenVPN

sorry i noticed that i have created this issue in wrong repo. I will create another one there.
###################################
Hi there,
I've noticed that over the past few months, other people have experienced the same issue. It seems to be related to NordVPN, possibly due to changes in encrypted passwords. However in my case I jus copied and paste the username and password from my account and I am sure that they're valid.
I am using gluetun as a service my downloader compose like this:
gluetun:
  container_name: gluetun
  image: qmcgaw/gluetun:latest
  cap_add:
    - NET_ADMIN
  ports:
    - 6880:6880 #aria-ng
    - 6800:6800 #aria2pro
    - 6888:6888 #aria2pro
    - 6888:6888/udp #aria2pro
  environment:
    - VPN_SERVICE_PROVIDER=nordvpn
    - OPENVPN_USER=valid-username
    - OPENVPN_PASSWORD=valid-password
    - SERVER_COUNTRIES=Austria,Germany,Netherlands
    - TZ=Europe/Berlin
  restart: unless-stopped

and here are my logs:
2023-12-01T19:47:35+01:00 INFO [openvpn] SIGUSR1[soft,auth-failure] received, process restarting
2023-12-01T19:47:45+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:47:45+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:47:45+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:02+01:00 INFO [healthcheck] program has been unhealthy for 31s: restarting VPN (see https://github.com/qdm12/gluetun-wiki/blob/main/faq/healthcheck.md)
2023-12-01T19:48:02+01:00 INFO [vpn] stopping
2023-12-01T19:48:02+01:00 INFO [vpn] starting
2023-12-01T19:48:02+01:00 INFO [firewall] allowing VPN connection...
2023-12-01T19:48:02+01:00 INFO [openvpn] OpenVPN 2.5.8 x86_64-alpine-linux-musl [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Nov  2 2022
2023-12-01T19:48:02+01:00 INFO [openvpn] library versions: OpenSSL 3.1.4 24 Oct 2023, LZO 2.10
2023-12-01T19:48:02+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:02+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:48:02+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:05+01:00 INFO [openvpn] TLS Error: Unroutable control packet received from [AF_INET]<IP_ADDRESS>:1194 (si=3 op=P_ACK_V1)
2023-12-01T19:48:05+01:00 INFO [openvpn] [at108.nordvpn.com] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:06+01:00 ERROR [openvpn] AUTH: Received control message: AUTH_FAILED
Your credentials might be wrong 🤨
2023-12-01T19:48:06+01:00 INFO [openvpn] SIGUSR1[soft,auth-failure] received, process restarting
2023-12-01T19:48:16+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:16+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:48:16+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:39+01:00 INFO [healthcheck] program has been unhealthy for 36s: restarting VPN (see https://github.com/qdm12/gluetun-wiki/blob/main/faq/healthcheck.md)
2023-12-01T19:48:39+01:00 INFO [vpn] stopping
2023-12-01T19:48:39+01:00 INFO [vpn] starting
2023-12-01T19:48:39+01:00 INFO [firewall] allowing VPN connection...
2023-12-01T19:48:39+01:00 INFO [openvpn] OpenVPN 2.5.8 x86_64-alpine-linux-musl [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Nov  2 2022
2023-12-01T19:48:39+01:00 INFO [openvpn] library versions: OpenSSL 3.1.4 24 Oct 2023, LZO 2.10
2023-12-01T19:48:39+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:39+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:48:39+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:39+01:00 INFO [openvpn] [de1028.nordvpn.com] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:45+01:00 ERROR [openvpn] AUTH: Received control message: AUTH_FAILED
Your credentials might be wrong 🤨
2023-12-01T19:48:45+01:00 INFO [openvpn] SIGUSR1[soft,auth-failure] received, process restarting
2023-12-01T19:48:55+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:48:55+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:48:55+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:01+01:00 INFO [openvpn] [de1028.nordvpn.com] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:02+01:00 ERROR [openvpn] AUTH: Received control message: AUTH_FAILED
Your credentials might be wrong 🤨
2023-12-01T19:49:02+01:00 INFO [openvpn] SIGUSR1[soft,auth-failure] received, process restarting
2023-12-01T19:49:12+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:12+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:49:12+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:20+01:00 INFO [healthcheck] program has been unhealthy for 41s: restarting VPN (see https://github.com/qdm12/gluetun-wiki/blob/main/faq/healthcheck.md)
2023-12-01T19:49:20+01:00 INFO [vpn] stopping
2023-12-01T19:49:20+01:00 INFO [vpn] starting
2023-12-01T19:49:20+01:00 INFO [firewall] allowing VPN connection...
2023-12-01T19:49:20+01:00 INFO [openvpn] OpenVPN 2.5.8 x86_64-alpine-linux-musl [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Nov  2 2022
2023-12-01T19:49:20+01:00 INFO [openvpn] library versions: OpenSSL 3.1.4 24 Oct 2023, LZO 2.10
2023-12-01T19:49:20+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:20+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:49:20+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:26+01:00 INFO [openvpn] TLS Error: Unroutable control packet received from [AF_INET]<IP_ADDRESS>:1194 (si=3 op=P_ACK_V1)
2023-12-01T19:49:27+01:00 INFO [openvpn] [at124.nordvpn.com] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:28+01:00 INFO [openvpn] TUN/TAP device tun0 opened
2023-12-01T19:49:28+01:00 INFO [openvpn] /sbin/ip link set dev tun0 up mtu 1500
2023-12-01T19:49:28+01:00 INFO [openvpn] /sbin/ip link set dev tun0 up
2023-12-01T19:49:28+01:00 INFO [openvpn] /sbin/ip addr add dev tun0 <IP_ADDRESS>/24
2023-12-01T19:49:28+01:00 INFO [openvpn] UID set to nonrootuser
2023-12-01T19:49:28+01:00 INFO [openvpn] Initialization Sequence Completed
2023-12-01T19:49:28+01:00 INFO [healthcheck] healthy!
2023-12-01T19:49:28+01:00 INFO [ip getter] Public IP address is <IP_ADDRESS> (Austria, Vienna, Vienna)
2023-12-01T19:49:41+01:00 INFO [healthcheck] unhealthy: dialing: dial tcp4: lookup cloudflare.com: i/o timeout
2023-12-01T19:49:49+01:00 INFO [healthcheck] program has been unhealthy for 6s: restarting VPN (see https://github.com/qdm12/gluetun-wiki/blob/main/faq/healthcheck.md)
2023-12-01T19:49:49+01:00 INFO [vpn] stopping
2023-12-01T19:49:49+01:00 INFO [vpn] starting
2023-12-01T19:49:49+01:00 INFO [firewall] allowing VPN connection...
2023-12-01T19:49:49+01:00 INFO [openvpn] OpenVPN 2.5.8 x86_64-alpine-linux-musl [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Nov  2 2022
2023-12-01T19:49:49+01:00 INFO [openvpn] library versions: OpenSSL 3.1.4 24 Oct 2023, LZO 2.10
2023-12-01T19:49:49+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:49+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:49:49+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:51+01:00 INFO [openvpn] [de964.nordvpn.com] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:49:52+01:00 ERROR [openvpn] AUTH: Received control message: AUTH_FAILED
Your credentials might be wrong 🤨
2023-12-01T19:49:52+01:00 INFO [openvpn] SIGUSR1[soft,auth-failure] received, process restarting
2023-12-01T19:50:00+01:00 INFO [healthcheck] program has been unhealthy for 11s: restarting VPN (see https://github.com/qdm12/gluetun-wiki/blob/main/faq/healthcheck.md)
2023-12-01T19:50:00+01:00 INFO [vpn] stopping
2023-12-01T19:50:00+01:00 INFO [vpn] starting
2023-12-01T19:50:00+01:00 INFO [firewall] allowing VPN connection...
2023-12-01T19:50:00+01:00 INFO [openvpn] OpenVPN 2.5.8 x86_64-alpine-linux-musl [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Nov  2 2022
2023-12-01T19:50:00+01:00 INFO [openvpn] library versions: OpenSSL 3.1.4 24 Oct 2023, LZO 2.10
2023-12-01T19:50:00+01:00 INFO [openvpn] TCP/UDP: Preserving recently used remote address: [AF_INET]<IP_ADDRESS>:1194
2023-12-01T19:50:00+01:00 INFO [openvpn] UDP link local: (not bound)
2023-12-01T19:50:00+01:00 INFO [openvpn] UDP link remote: [AF_INET]<IP_ADDRESS>:1194

best regards and thank you for your great work.
Shahram

NordVPN has by far a LOT of servers, and since Gluetun supports, is by far also the most unstable.
Without changing your credentials it even managed to connect:
2023-12-01T19:49:28+01:00 INFO [openvpn] Initialization Sequence Completed
2023-12-01T19:49:28+01:00 INFO [healthcheck] healthy!
2023-12-01T19:49:28+01:00 INFO [ip getter] Public IP address is <IP_ADDRESS> (Austria, Vienna, Vienna)

So it's unlikely a problem with your config or Gluetun, and most likely a problem on their end, again.
Note you can try Wireguard which is natively supported by Gluetun for Nordvpn, that might solve your issue, at least as a workaround.
Finally, opening an issue like this one on the Gluetun repository was actually better, this gluetun-wiki repository is for documentation, but I appreciate the dedication to open the issue at the right place 👍 !


Add workaround for issue #1292

Works around the problem of string conversions for integer and float arg values by temporarily creating a string.

When I run the engine, I get an immediate crash in VS2012 Windows 7 x64 on line 1760:
         sval = (char *) dRealloc(sval, newLen);

Same happens on Ubuntu 14 with gcc. It appears to happen while exec'ing a material.cs.

Hmm odd, taking a look

Not seeing a problem here. Could you be more specific with your reproduction instructions?

Checked wrong branch, whoops

Fixed. Registered console values use the dataPtr variable which conflicts with sval.
Also tidied up the handling of sval so it only checks bufferLen instead of deducing its allocated based on type.

Checks out on Ubuntu, checking Windows.

Looks like it works for me as well.

TODO: merge into release-3.7. Need to cherry-pick instead of merging directly.

Cherry-picked in d9436e6