Not working on RPI2 B Model (Jessie)

Fresh install of Jessie on RPI2 B model (40 Pin GPIO)
Almost everything installed perfect... Did run into a snag with the SECRET_KEY not generating at the end.  I was able to resolve this by manually running the cmd and redirectly the output to the app.cfg.  I am able to hit webserver page.
I have GPIO pin 7 configured to a relay.   Currently I am seeing not seeing the Open button (when clicked/confirmed) trigger the GPIO pin 7.    To confirm my wiring and hardware, I installed webiopi (w/patch for v1.7.x) and this was able to trigger the relay.
Also worth mentioning is....  The CPU/GPU temps are not registering.
Was hoping this would work, but appears there is something missing, perhaps a config?

This is the section that fail during install, do not have actual screenshot anymore, but it reported a syntax related error.
  # Copy default config file over and generate key if
  # config file doesn't already exist.
  if [ ! -f "${INSTANCE_DIR}/app.cfg" ]; then
    cp "${RESOURCE_DIR}/default_app.cfg" "${INSTANCE_DIR}/app.cfg"
    **python "${SETUP_DIR}/generate_secret_key.py" >> "${INSTANCE_DIR}/app.cfg"**
  fi

#cat generate_secret_key.py
import os
secret_key = os.urandom(24)
**print "SECRET_KEY = %r" % (secret_key)**

Ah, this looks like a Python versioning issue. I think Jessie may have changed the default Python interpreter from 2 to 3. I may have to fix the setup script since this project requires 2.
At a fresh terminal type the following and paste the results.
python -V

pi@webcam03:~ $ python -V
Python 2.7.9
for Jessie, python3 is installed, but the system still defaults to version 2.x since they have not adopted all OS related objects/scripts to use pure v3.x.
Not sure what is causing the disconnect to make it not run.

Hmm. That's the right version. Did you use sudo to run the install script? You shouldn't and maybe the root user has a different default for some reason.
That syntax error would be a breaking change introduced with the print statement in Python 3.

did not use sudo, as I recall.... it will prompt that you should not run as sudo?....
The first couple lines say this....
if [ $(id -u) -eq 0 ]; then   echo "This should not be run with sudo. Try again without running with sudo."

that is in your online_install.sh.    running as sudo would make it exit.
However, I did not run it as root.... I can re-run the script as root and see if that resolves anything...

looks like running as root is not recommended either:
root@webcam03:/home/pi/garage_pi/setup# ./online_install.sh This should not be run with sudo. Try again without running with sudo.

Can you try manually editing generate_secret_key.py and changing the line we're having trouble with to this (note the added parentheses).
print("SECRET_KEY = %r" % (secret_key))

That should at least get you through the install. I'm worried that when the virtual environment is created it might use the wrong version of python but I guess we'll tackle that when/if it happens.

Nevermind. I looked through the setup script and realized that at that point we've already activated the virtual environment and are running in python3. I'll fix the script. In the meantime, the above edit should get you through. I'll keep this issue open until I've pushed a fix.

So I removed /home/pi/garage_pi completely, then re-ran the cmd you have to perform an online install:
curl -s "https://raw.githubusercontent.com/nathanpjones/GaragePi/master/setup/online_install.sh" | bash
The installation went perfect (no errors).
But still seeing issues:
I have GPIO pin 7 configured to a relay and pin 17 to the reed switch. Currently I am seeing not seeing the Open button (when clicked and confirmed) trigger the GPIO pin 7 (relay is not firing). To confirm my wiring and hardware, I created a simple python script to trigger the pins, along with using the reed switch.  Everything is logically working with this simple script.
Also worth mentioning is.... The CPU/GPU temps are not registering, I only see a question mark/degrees.

I have 1 left course of action to take, which I am performing now....    I had a friend lend me his RPI model-A (has the full size sdcard and 26 pin GPIO).  I am installing Wheezy on it and will redo your online install to see if there is any change.   Not really the best test to perform since I am changing the OS and Hardware.
If this proves to be good, then I am in business and I have more time to myself.  Otherwise, I have already started coding a python/web-app using your css (really like your clean setup).

I just double-checked and the specific Pi I'm using is a Raspberry Pi 1 Model B running Jessie. But that shouldn't make a difference for what we're doing here.
So the way this project works is there's a web server in Flask to serve up the web page and handle ajax requests from your browser (you're not blocking scripts are you?). For triggering the open and getting door status and temps your browser makes an ajax request to the web server which in turn passes everything through to a separately running service that actually does the GPIO. This is done for permissions reasons and to allow certain things like checking if your garage door is still open at a certain time.
Without more info it's hard to say which part of that is not working. After a clean boot, run the following command and paste the output here.
service garagepi status

Then try to use the web interface to open the door to get some entries in the log. Attach any .log files that you find in your garagepi/instance folder.
One last note because from what you said I couldn't tell if you did this or not. The default pin for the reed switch is 18. If you're using pin 17, make sure to change the REED_PIN setting in garagepi/instance/app.cfg.

..This output is from my Pi2 B+ w/jessie   (Still building my Pi1 B..... thought it was an A)
`pi@webcam03:~/garage/python $ sudo service garagepi status
● garagepi.service - LSB: Init script for GaragePi
Loaded: loaded (/etc/init.d/garagepi)
Active: active (exited) since Sat 2016-06-18 22:22:01 MDT; 1h 53min ago
Process: 393 ExecStart=/etc/init.d/garagepi start (code=exited, status=0/SUCCESS)
Jun 18 22:21:59 webcam03 systemd[1]: Starting LSB: Init script for GaragePi...
Jun 18 22:22:00 webcam03 garagepi[393]: Starting system garagepi daemon:.
Jun 18 22:22:01 webcam03 systemd[1]: Started LSB: Init script for GaragePi.`
Also, Yes, I have app.cfg configured for reed=17, garage=7.

another thought/question.  Are you running jessie-lite ?   This is what I have installed since I am headless.

worth noting:
I scratched my wheezy build after I saw you mentioned you are on jessie.   So fresh install (within an hour using jessie-lite).  After I setup my PI (locale/timezone/overclock/hostname/passwd/ssh enable) and updated OS, I immediately cut/pasted your curl cmd for the online install.
Round 1 --> "git" isn't installed, so the installer failed....  installed git
Round 2 --> get an error "Python 3 is required but isn't installed, Easiest way to get it is upgrade to Raspbian Jessie" ....  installed Python3 (including python3-dev)
Round 3 --> almost completed this time, lighttpd installation aborted, manually installed it
Round 4 --> garage_pi successfully installs  (pyzmq takes forever on a Pi1 Model B)

Fired up browser (safari) and opened port 80 --> able to see GaragePi webpage
Transferred my GPIO connections from my Pi2 to the Pi1 Model B and for sanity reasons, I wired the GPIOs to 7=Garage//18=Reed

Outcome:   I get the same thing as on the RPi2 B+.

The Door Status says Closed (regardless if I move the reed magnet away from the base and refresh the browser)
The Pi Status shows ?° C for CPU/GPU
And when clicking the "Open Door" button and "Proceed" button, I do not see or hear the relay triggering

Thanks for the excellent work in troubleshooting this. Your logs indicated that the service wasn't running. Looks like it was a rookie Python mistake on my part when checking to see if you have an IFTTT key. Fixed that and added some extra logging around errors.

oh snap!... Its WORKING NOW!   You da man!
So now I move onto phase 2:
Webcam Module-
I already have this working on my prototype.   Adding motionpie to the mix so I can have a visual on the garage (using USB at the moment, but swapping out for a raspi-cam for small form factor).  I simply duplicate your css/div tags to insert another blue container/box to wrap the webcam stream.  This give me ability to open garage for fedex/ups/freight when not home and record them.
Garage Temperature Module-
Also implementing a dual DS18B20 (digital temp sensors) circuit onto my side board to retrieve the garage temperature, will just add a python module to collect temps and a new line of code into the html to display the garage temp under your CPU/GPU section.   I like working on projects in the summer/winter, so will be nice to see the temps.
If you are interested in these, I can post them or email them to you.
Absolutely love your GaragePi app now  and appreciate you looking into it.

That's great news! I'd love to hear what you do with the project.
Actually, if you feel comfortable doing so I'd encourage you to create a pull request for bringing that functionality into the project. Using the RPi camera was something I always wanted to do, just didn't have the time. Even bringing over the temp sensors would be great. Just try to keep things modular in the code and give people a way to turn things on and off in the app config.

Here is quick peek at that I have done.   Not sure if you will like everything, if you do... I can do the pull request.
Inserted camera.css, this holds the css for the camera and the toggle for the div hold the stream, tried to use a flat looking css/jquery toggle to match your layout.
changed .open_closed_btn so the open/close button has slightly different corner radius (looks more obvious to be a button)
Cleaned up the html pages (tags) so they indent, found a couple tags that were not being used, removed those, added some additional comments.
Moved the Open/Close button into the main div section since it was splitting off on large screens
Inserted a placeholder for Garage Temperature (still waiting on parts to fabricate the circuit), plan on converting to Fahrenheit and still have Celsius.
As far as making things modular, the camera.css accomplishes that, but would have to do something like a catch tag in the garage_control.html for the installer to uncomment/comment out the camera section (maybe a y/n question to trigger the installer to do this?).
I will be slowly working on more with this as parts arrive.

ended up pulling this piece onto my RPi    https://www.richlynch.com/2013/08/04/pi_garage_alert_2/#comment-2745505819    To get email to SMS notifications when the garage is left open for X number of seconds since I will not want to watch this app all day long.   Works pretty good.    Might be something good to splice into the backend service for your project.

I like what you've done. Go ahead and submit a pull request for what you've got. If you like, we can work together on making it modular to turn parts on and off.

Hey Nathan,
I am slowly adding in additional code for the temperature readings...
having some hangups with modules not importing, once I get that working I
can do a pull request for you.
On Sat, Jun 25, 2016 at 4:47 PM, Nathan Jones<EMAIL_ADDRESS>wrote:

I like what you've done. Go ahead and submit a pull request for what
you've got. If you like, we can work together on making it modular to turn
parts on and off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathanpjones/GaragePi/issues/1#issuecomment-228574351,
or mute the thread
https://github.com/notifications/unsubscribe/AS7YG0eUV08mpx5dnxnqhw7tdUtKbp98ks5qPbAbgaJpZM4Iye5j
.

Nathan!
I got it working last night... Code may need some refinement.   When the
door is open, it spews open/close signals.
This could be related to my circuit...where I am using a single 3.3v GPIO
pin to drive the reed switch and the temp (x3 - DS18B20) sensors.
Was looking for a place to make the get_garage_temp routine sleep for 5-7
seconds (without effecting the other subroutines), think the 1 poll/sec is
right on the cusp of being too fast, which is backlogging temperature
sensor polling....
Ended up using json output from the w1thermsensor pkg (written by Timo
Furrer -- https://github.com/timofurrer/w1thermsensor)
Trying to figure out how to use GitHub, first time doing this...  I was
trying to create a branch off yours to upload, no luck (might have missed
something??)
So I created a fork and gave you collaborator rights.   IF there is a
better way to do this, let me know.
(Messy Garage -- still moving IN)
[image: Inline image 1]
On Tue, Jul 5, 2016 at 3:53 PM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Hey Nathan,
I am slowly adding in additional code for the temperature readings...
having some hangups with modules not importing, once I get that working I
can do a pull request for you.
On Sat, Jun 25, 2016 at 4:47 PM, Nathan Jones<EMAIL_ADDRESS>wrote:

I like what you've done. Go ahead and submit a pull request for what
you've got. If you like, we can work together on making it modular to turn
parts on and off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathanpjones/GaragePi/issues/1#issuecomment-228574351,
or mute the thread
https://github.com/notifications/unsubscribe/AS7YG0eUV08mpx5dnxnqhw7tdUtKbp98ks5qPbAbgaJpZM4Iye5j
.

here is the fork...   https://github.com/fireheadman/GaragePi
Honestly, I am not liking this setup since I seem to have lost all the
change history when I uploaded via command line.
I saw there is the ability to have an upstream branch off the master, which
would be a good place to push updates/test so that you can merge them from
upstream to master when you are ready.
Just not sure how to set that up.
On Wed, Jul 6, 2016 at 10:11 AM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Nathan!
I got it working last night... Code may need some refinement.   When the
door is open, it spews open/close signals.
This could be related to my circuit...where I am using a single 3.3v GPIO
pin to drive the reed switch and the temp (x3 - DS18B20) sensors.
Was looking for a place to make the get_garage_temp routine sleep for 5-7
seconds (without effecting the other subroutines), think the 1 poll/sec is
right on the cusp of being too fast, which is backlogging temperature
sensor polling....
Ended up using json output from the w1thermsensor pkg (written by Timo
Furrer -- https://github.com/timofurrer/w1thermsensor)
Trying to figure out how to use GitHub, first time doing this...  I was
trying to create a branch off yours to upload, no luck (might have missed
something??)
So I created a fork and gave you collaborator rights.   IF there is a
better way to do this, let me know.
(Messy Garage -- still moving IN)
[image: Inline image 1]
On Tue, Jul 5, 2016 at 3:53 PM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Hey Nathan,
I am slowly adding in additional code for the temperature readings...
having some hangups with modules not importing, once I get that working I
can do a pull request for you.
On Sat, Jun 25, 2016 at 4:47 PM, Nathan Jones<EMAIL_ADDRESS>wrote:

I like what you've done. Go ahead and submit a pull request for what
you've got. If you like, we can work together on making it modular to turn
parts on and off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathanpjones/GaragePi/issues/1#issuecomment-228574351,
or mute the thread
https://github.com/notifications/unsubscribe/AS7YG0eUV08mpx5dnxnqhw7tdUtKbp98ks5qPbAbgaJpZM4Iye5j
.

played around with this a lot today...learned some more about GITHUB, but
no way an expert.
I ended up deleting my fork/branch.
If phone works better for you, send me a text/call  at<PHONE_NUMBER> and
maybe you can walk me through how to setup an upstream/dev branch to
contribute to.
-Ben
On Wed, Jul 6, 2016 at 11:13 AM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

here is the fork...   https://github.com/fireheadman/GaragePi
Honestly, I am not liking this setup since I seem to have lost all the
change history when I uploaded via command line.
I saw there is the ability to have an upstream branch off the master,
which would be a good place to push updates/test so that you can merge them
from upstream to master when you are ready.
Just not sure how to set that up.
On Wed, Jul 6, 2016 at 10:11 AM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Nathan!
I got it working last night... Code may need some refinement.   When the
door is open, it spews open/close signals.
This could be related to my circuit...where I am using a single 3.3v GPIO
pin to drive the reed switch and the temp (x3 - DS18B20) sensors.
Was looking for a place to make the get_garage_temp routine sleep for 5-7
seconds (without effecting the other subroutines), think the 1 poll/sec is
right on the cusp of being too fast, which is backlogging temperature
sensor polling....
Ended up using json output from the w1thermsensor pkg (written by Timo
Furrer -- https://github.com/timofurrer/w1thermsensor)
Trying to figure out how to use GitHub, first time doing this...  I was
trying to create a branch off yours to upload, no luck (might have missed
something??)
So I created a fork and gave you collaborator rights.   IF there is a
better way to do this, let me know.
(Messy Garage -- still moving IN)
[image: Inline image 1]
On Tue, Jul 5, 2016 at 3:53 PM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Hey Nathan,
I am slowly adding in additional code for the temperature readings...
having some hangups with modules not importing, once I get that working I
can do a pull request for you.
On Sat, Jun 25, 2016 at 4:47 PM, Nathan Jones<EMAIL_ADDRESS>wrote:

I like what you've done. Go ahead and submit a pull request for what
you've got. If you like, we can work together on making it modular to turn
parts on and off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathanpjones/GaragePi/issues/1#issuecomment-228574351,
or mute the thread
https://github.com/notifications/unsubscribe/AS7YG0eUV08mpx5dnxnqhw7tdUtKbp98ks5qPbAbgaJpZM4Iye5j
.

thought of a possible solution to retain performance and keep garTemp piece
working.
Will re-write the block in controller.py to read a file to get the
temperature, which should be fairly quick and will have a separate def
routine() to perform the temp collecting since this takes some time to
collect/parse.
-ben
On Wed, Jul 6, 2016 at 4:13 PM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

played around with this a lot today...learned some more about GITHUB, but
no way an expert.
I ended up deleting my fork/branch.
If phone works better for you, send me a text/call  at<PHONE_NUMBER> and
maybe you can walk me through how to setup an upstream/dev branch to
contribute to.
-Ben
On Wed, Jul 6, 2016 at 11:13 AM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

here is the fork...   https://github.com/fireheadman/GaragePi
Honestly, I am not liking this setup since I seem to have lost all the
change history when I uploaded via command line.
I saw there is the ability to have an upstream branch off the master,
which would be a good place to push updates/test so that you can merge them
from upstream to master when you are ready.
Just not sure how to set that up.
On Wed, Jul 6, 2016 at 10:11 AM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Nathan!
I got it working last night... Code may need some refinement.   When the
door is open, it spews open/close signals.
This could be related to my circuit...where I am using a single 3.3v
GPIO pin to drive the reed switch and the temp (x3 - DS18B20) sensors.
Was looking for a place to make the get_garage_temp routine sleep for
5-7 seconds (without effecting the other subroutines), think the 1 poll/sec
is right on the cusp of being too fast, which is backlogging temperature
sensor polling....
Ended up using json output from the w1thermsensor pkg (written by Timo
Furrer -- https://github.com/timofurrer/w1thermsensor)
Trying to figure out how to use GitHub, first time doing this...  I was
trying to create a branch off yours to upload, no luck (might have missed
something??)
So I created a fork and gave you collaborator rights.   IF there is a
better way to do this, let me know.
(Messy Garage -- still moving IN)
[image: Inline image 1]
On Tue, Jul 5, 2016 at 3:53 PM, Benjamin Piraro<EMAIL_ADDRESS>wrote:

Hey Nathan,
I am slowly adding in additional code for the temperature readings...
having some hangups with modules not importing, once I get that working I
can do a pull request for you.
On Sat, Jun 25, 2016 at 4:47 PM, Nathan Jones<EMAIL_ADDRESS>
wrote:

I like what you've done. Go ahead and submit a pull request for what
you've got. If you like, we can work together on making it modular to turn
parts on and off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathanpjones/GaragePi/issues/1#issuecomment-228574351,
or mute the thread
https://github.com/notifications/unsubscribe/AS7YG0eUV08mpx5dnxnqhw7tdUtKbp98ks5qPbAbgaJpZM4Iye5j
.

I have the re-write completed... its modular now (might need a tad bit of refinement).
/home/pi/garage_pi/backend/collect_garage_temps.py collects temps from DS18B20 sensor(s) and stores readings in /tmp/garage_temp every 5sec.
This script is a daemonized py script that uses systemd (/etc/systemd/system/garage_temp.service) so it is independent of controller.py and it also sends output logger INFO/WARN messages to garage_backend.log on its readings.
If this script isn't running, the last known/found temp in /tmp/garage_temp will show on the html page.... thinking maybe something else can be coded to reset the value to "--"C / "--"F if a reading is older than 30min or something??
After all this re-writing, I thought this would calm my Reed Switch down, right now when I open my garage, it still spews open/close/open/close...etc..etc, which is making the garage_backend.log grow fast then rotate.   I might back out all my changes to see if I introduced this.


fix: requestAccount to show all accounts

📝 Description
Also refactor the screens with useCallback on the flatlist to improve perf
❓ Context

Impacted projects: live-mobile
Linked resource(s): ``

✅ Checklist

[ ] Test coverage To test you can use the platform debugger or any live app that request an account like the L-Market
[x] Atomic delivery
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Looks ok on the build on iOS for this branch 👍


selected images

This image getting URL:
Assets [<PHAsset: 0x11dc12570> 2E25AD2C-51D8-4431-882F-AC8CA2E8F65B/L0/001 mediaType=1/0, sourceType=1, (3024x4032), creationDate=2019-04-08 10:04:57 +0000, location=0, hidden=0, favorite=0 ]
This image not getting URL: (app will crash for data nil)
Assets [<PHAsset: 0x11dc065f0> 420A3B33-A758-4EC3-9DC1-D72AC88B98C9/L0/001 mediaType=1/4, sourceType=1, (1242x2208), creationDate=2019-04-11 07:14:37 +0000, location=0, hidden=0, favorite=0 ]
what are the difference b/w the above two Assets, How to resolve this issue ?

I'm not sure how you are getting the images from a PHAsset, but officially the only way to get the underlying data of PHAsset is through the PHImageManager (recommended) or PHAssetResourceManager.
Using PHAsset or PHAssetResource directly might cause no data to be returned or simply outright crash the app. This is mostly related to iCloud photos and optimized storage, where it could mean that the data isn't actually (accessible) on the phone yet. PHImageManager and PHAssetResourceManager make sure the data is accessible locally before returning.


fix(helm_resource): no parallel in helm_repo

Multiple invocations of helm_repo may not be concurrency safe because
of the execution of helm repo add. This commit unsets the
allow_parallel argument in helm_repo to prevent this bug.
Resolves #500

are you sure this isn't just a mix-up with resource_deps? i.e., the ci run that you were looking at didn't have resource_deps setup? how often are you seeing this happen?

Just the once, but I'm pretty sure the Tiltfile definition was correct (or at least tilt ci had worked on a clean setup before and after). Maybe I'll drop this for now and if I see it again then re-raise it?


fixes 500 error on dashboard when using MSSQL

MSSQL rejects the query:
SELECT "repository"."id" FROM "repository"
INNER JOIN "team_repo" ON "team_repo".repo_id="repository".id AND
"repository".is_mirror=1
WHERE (
("repository".owner_id=2 AND "repository".is_private=0)
OR team_repo.team_id IN (1)
)
GROUP BY "repository".id ORDER BY updated_unix DESC
when the order by term (updated_unix) is not included in the group by
term.

Codecov Report

Merging #2504 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2504   +/-   ##
=======================================
  Coverage   27.85%   27.85%
=======================================
  Files          83       83
  Lines       16825    16825
=======================================
  Hits         4686     4686
  Misses      11464    11464
  Partials      675      675

Impacted Files
Coverage Δ

models/org.go
69.65% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633de01...fb971d0. Read the comment docs.

LGTM

any feedback on the quality of my commit message would be appreciated. Thanks

It describes changes so it is understandable what change fixes, I think it is good ;)

LGTM

Make LG-TM work :)

@bradder555 can you backport it to 1.2 branch?


Aligns language server with protocol proposition

Aligns the server with microsoft/language-server-protocol#953

@giltho should we for consistency change this one as well?
https://github.com/microsoft/vscode-languageserver-node/blob/master/jsonrpc/src/main.ts#L262

Yes I think it would be better indeed. Also, I could probably add it to the protocol proposition.

That would be great!

I updated the draft here microsoft/language-server-protocol#953 :)

@giltho could you resolve the conflict please.

@dbaeumer done :)


Write a NotNullOptimizer

Similar to constant propagation optimizer. If a variable is known to be not null, propagate its non nullness. This applies to string operations (substring, indexes), "new" operations and input.

Similarly, once a variable is tested for null, it doesn't have to be tested for null again (provided it hasn't changed between the checks.)


Mark blocks that branch off from a finalised block as discarded.

Purpose
This tackles Issue #28 and changes the visualization so that branches that start from an already finalized block a shown greyed out.
Changes

Adds a function to recurse through the visualization tree and mark the appropriate blocks as discarded.
Merged the lates master to this branch.
Contains the changes from the jp/treepacking and jp/treesorting branches which contain work i did in January that seems not to have been merged yet. Sorry if this is a bit messy, i originally assumed they had already been merged when starting work on this.

Thanks for this, but there is something gravely wrong with this PR.
There are changes in the diff that make no sense to be there, such as adding the changelog file, which is already on main, so it looks to me like there is some history disagreement.
Can you please clean that up? Otherwise this is not going to be possible to review.
Let me know if I can assist you with this in any way.

Hey thanks for getting back so quickly,
i agree that this is difficult to review, the reason is that it is not asking to merge to main, but to jp/handle-discarded which is a branch from when the repo was still on gitlab. The changes you are seeing are there because i merged the latest main to this branch to get it up to date, so a pull request against main should look a lot cleaner. Should i create that instead?

Yes, please do.
Are there any branches that should be deleted in this repo that are made obsolete by this PR?

I created a pull request against main here: #48


Local shards accessed using devices_indices_map are scaled by # of pods

Description
Given an array sharded across n pods, the following code results in each local_shard having its elements scaled by exactly n:
        m = sharded_arr.sharding.devices_indices_map(sharded_arr.shape)
        for device in jax.local_devices():
            index = m[device]
            local_shard = jax.device_get(sharded_arr[index])

That is, each local_shard is exactly n * sharded_arr[index]. For comparison, this gives the correct list of shards:
        for shard in sharded_arr.addressable_shards:
            index = shard.index
            local_shard = shard.data

Full reproducer with some mesh/distributed setup code omitted:
import jax.numpy as jnp
import jax.sharding
from jax.experimental import multihost_utils

def test_sharding():
    # ... init distributed JAX and mesh ...

    with mesh:
        arr = jnp.full(len(jax.devices()), 1e4, dtype=jnp.float32)

        sharding = jax.sharding.NamedSharding(
            mesh, jax.sharding.PartitionSpec("name_of_first_axis_in_mesh")
        )

        sharded_arr = jax.jit(lambda x: x, out_shardings=sharding)(arr)
        assert sharded_arr.sharding == sharding
        assert jnp.all(multihost_utils.process_allgather(sharded_arr) == arr)

        # Okay...
        for shard in sharded_arr.addressable_shards:
            index = shard.index
            local_shard = shard.data
            assert jnp.all(arr[index] == local_shard), (arr[index], local_shard)

        # Bugged...
        m = sharded_arr.sharding.devices_indices_map(sharded_arr.shape)
        for device in jax.local_devices():
            index = m[device]
            local_shard = sharded_arr[index]
            assert jnp.all(arr[index] == local_shard), (arr[index], local_shard)

The last assert is the one that fails, with output:
AssertionError: (Array([10000.], dtype=float32), Array([640000.], dtype=float32))

when using 64 pods. If using 4 pods then it is off by a factor of 4. And if using just 1 pod then it is fine.
System info (python version, jaxlib version, accelerator, etc.)
jax:    0.4.31.dev20240628
jaxlib: 0.4.31.dev20240628
numpy:  1.24.4
python: 3.11.6 (main, Jul  7 2024, 03:20:08) [GCC 11.4.0]
jax.devices (4 total, 4 local): [TpuDevice(id=0, process_index=0, coords=(0,0,0), core_on_chip=0) TpuDevice(id=1, process_index=0, coords=(1,0,0), core_on_chip=0) TpuDevice(id=2, process_index=0, coords=(0,1,0), core_on_chip=0) TpuDevice(id=3, process_index=0, coords=(1,1,0), core_on_chip=0)]
process_count: 1
platform: uname_result(system='Linux', node='...', release='6.1.58+', version='...', machine='x86_64')

Using .addressable_shards is the way to go. That's the API to fetch local shards.

Thanks for confirming the fix. To clarify / help others who might run into this, the issue is the first approach works if you're on a single pod, and it sort of seems to work at first for more than 1 pod too until you run into correctness issues that are difficult to pinpoint especially since they it doesn't reproduce on a single pod setup. It's easy to be mislead into thinking sharded_arr[index] is an okay thing to do when the index corresponds to a locally addressable shard, and it even seems to work (until it doesn't).


v1.1 // Abstractify Socket, Client, Server

Make Socket, Client, and Server abstract classes.
See #7 as well

Moving this to v1.1 since trying to instantiate any of these would throw an exception, so this is not a breaking change.


Rename account dialog does not disable the rename button

The rename account dialog does not disable the rename button and provide details on why it's disabled for invalid entries.
There are at least two cases of invalid input:

Specifying the existing name of the account being renamed
Specifying an existing name of any account

Under these scenarios the rename dialog lets you press the rename button repeatedly and nothing happens.
I would suggest a label be added to the dialog which is displayed on conditions which prevent entry and for the rename button to be disabled in said cases.  So, for example, entering the same name as the existing account would disable the rename button and show a label "An account already exists with the specified name."

An error is currently caught and handled by printed to console, but you wouldn't know unless you were running it in the visual studio debugger.
There is currently no RPC to query for whether a name is valid or not, and it would be a race condition if we added one to do that check (consider duplicate names).

It should be pretty easy to check against the list of known accounts in the accounts list, right?
I realize this wouldn't catch the case of an account being created by another process, but that is unlikely to happen very often in practice and simply checking against the known accounts client side (within Paymetheus) will improve the UX for almost all realistic cases.

Sure, that's a good idea.


Double quote character is stripped from messages

Double quote character " is stripped if contained in the message.
This happened when message is stored in database.
Note: If this character is added manually in the database, it is displayed correctly.

This is on purpose to reduce risk of SQLi attack, see line 499 in api.js. We could probably change this to replace with a similar char like ” or something.

Fixed in #274


EntityManager: Remove DBAL Connection factory

Removes the hardcoded magic behind creating Connection instance from an array.

Manually merged via doctrine/doctrine2@50da42f2f472a705586a2803f9acbb991b8db0a2, thanks!


Can't compile the resulting expression

Hello!
I'm very new to mathjs, but this looks like an amazing library
I need to compute and use an integral for one of my projects, but it looks to me like there is a small bug with this lib:
Doing this:
math.integral('x^2', 'x').compile();

raises a arg._compile is not a function exception
But this:
math.parse(math.format(math.integral('x^2', 'x'))).compile();

works fine
I've tried tracking the problem down, and by comparing the json
representations of these two:
math.integral('x^2', 'x')
math.parse(math.format(math.integral('x^2', 'x')))

I can only find one difference:
// math.integral output
{"name":"x"}

// serialized then parsed output
{"mathjs":"SymbolNode","name":"x"}

I hope that was clear, and that I'm not missing something obvious (as I said, this is the first time I use both your lib and mathjs)
Cheers!

I think this is happening because you are using a recent version of Mathjs (version >=5.0.0), whereas this extension internally links against version 3.18.1 (released in December 2017). If you ensure that you are using a compatible version, this plugin should work. Just to double check, I created a npm project that uses the old version of Mathjs, and the following ran flawlessly in Node:
const math = require('mathjs');
math.import(require('mathjs-simple-integral'));

console.log(math.integral('x^2', 'x').compile().eval({x:1}));

That said, I should warn against using this extension, as it is unmaintained (hence why it doesn't work with recent versions), and has some pretty severe limitations on the types of functions it can integrate. If you are fine with these limitations, I can look into putting in an hour or two to upgrade this to the latest Mathjs version, which should fix your issue.

Thanks for your answer, and sorry for replying so late (I though I'd had enabled email notifications). I'll check using v3.18.1
Thanks for the heads up about the extension being unmaintained. I don't think I'll have the time to make a fix: I needed the lib for a small side project that I had to cancel because of lack of time
Thanks again, and sorry for not helping (at least for now)


Preventing modification of the name and mail for CAS and Shib

replace #1193

@dooremont have you considered the possibility of a malicious user changing the HTML code on a page to simulate an input field instead of a label so he can try to submit data?
The fix on 4120 "hides" the form, but we still need to make sure the backend doesn't change the data if CAS or Shibboleth are being used, in case an unexpected POST (form submission) comes in.

Hi,
So, what I tried to explain above is that we need to make sure that the server behaves correctly if the POST comes in. The logic you implemented on the client:
if disabled:
  then...
if not:
  then...

isn't present on the server.
The fact that the HTML has been changed in order to make the right things appear to the user doesn't mean that it can't be simulated via javascript, for instance (hence the picture above, which proves that one can still submit the form and cheat the server). We need to be protecting both the client and the server.

Note that the client can never be trusted as the code is easily modifiable
by the user.
Whatever security considerations are in the client are irrelevant from the
perspective of the server, the server has to assume a malicious client.
Sorry if I'm butting in unnecessarily :)
D
On 28 March 2017 at 12:39, Miguel Laginha<EMAIL_ADDRESS>wrote:

Hi,
So, what I tried to explain above is that we need to make sure that the
server behaves correctly if the POST comes in. The logic you implemented
on the client:
if disabled:
then...
if not:
then...
isn't present on the server.
The fact that the HTML has been changed in order to make the right things
appear to the user doesn't mean that it can't be simulated via javascript,
for instance (hence the picture above, which proves that one can still
submit the form and cheat the server). We need to be protecting both the
client and the server.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/oaeproject/Hilary/pull/1313#issuecomment-289743201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKc2L3Vd9lathNui91jZeBUYUryAATOeks5rqPGNgaJpZM4L1JlZ
.

how to get element config in api.user.js
I search the method to get config element disableProfile (Hilary/node_modules/oae-authentication/config/strategies.js )
shibboleth': {

'disableProfile': new Fields.Bool('Preventing modification of the name and mail', 'Preventing modification of the name and mail', true),

in api.user.js for the if
thanks a lot for your help

Hi @dooremont!
I'm not sure I understood your question. What is it you're looking for?

ok i search the method to get a config element for exemple "disableProfile" in file Hilary/node_modules/oae-authentication/config/strategies.js
i want implement the test process
if disabled:
  then...
if not:
  then...

in api.user.js file

hi!
I think you're looking for this kind of statement which applied to your specific case would become something like this:
var foo = oae.api.config.getValue('oae-authentication', 'strategies', 'disableProfile');

Was that it?

exactly thanks a lot
best


Build agent is crashing randomly

Using the latest agent. Can't repro but when it gets crashed occasionally, the stack goes like this.
Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indi
cation that other memory is corrupt.
   at System.Diagnostics.StackTrace.GetStackFramesInternal(StackFrameHelper sfh, Int32 iSkip, Boolean fNeedFileInfo, Exc
eption e)
   at System.Diagnostics.StackFrameHelper.InitializeSourceInfo(Int32 iSkip, Boolean fNeedFileInfo, Exception exception)
   at System.Diagnostics.StackTrace.CaptureStackTrace(Int32 iSkip, Boolean fNeedFileInfo, Thread targetThread, Exception
 e)
   at System.Diagnostics.StackTrace..ctor(Exception e, Boolean fNeedFileInfo)
   at System.Environment.GetStackTrace(Exception e, Boolean needFileInfo)
   at System.Exception.GetStackTrace(Boolean needFileInfo)
   at System.Exception.ToString(Boolean needFileLineInfo, Boolean needMessage)
   at System.Exception.ToString(Boolean needFileLineInfo, Boolean needMessage)
   at Microsoft.VisualStudio.Services.Agent.Listener.MessageListener.<GetNextMessageAsync>d__13.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.Agent.Extensions.<WithCancellation>d__0`1.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task`1.TrySetResult(TResult result)
   at System.Threading.Tasks.TaskFactory.CompleteOnInvokePromise.Invoke(Task completingTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.<SendAsync>d__26`1.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.<SendAsync>d__27`1.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.<SendAsync>d__42`1.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.<SendAsync>d__45.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at System.Net.Http.HttpClient.<FinishSendAsync>d__58.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.Common.VssHttpRetryMessageHandler.<SendAsync>d__3.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.SetException(Exception exception)
   at Microsoft.VisualStudio.Services.Common.VssHttpMessageHandler.<SendAsync>d__17.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining, Task& curre
ntTask)
   at System.Threading.Tasks.Task.FinishContinuations()
   at System.Threading.Tasks.Task.Finish(Boolean bUserDelegateExecuted)
   at System.Threading.Tasks.Task`1.TrySetException(Object exceptionObject)
   at System.Threading.Tasks.TaskCompletionSource`1.TrySetException(Exception exception)
   at System.Net.Http.WinHttpHandler.HandleAsyncException(WinHttpRequestState state, Exception ex)
   at System.Net.Http.WinHttpHandler.<StartRequest>d__101.MoveNext()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.MoveNextRunner.RunWithDefaultContext()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

@nigurr do you have any chance take a process dump? what OS is this agent running on? what kind of cpu x64 or x86?

I don't have process dump. I will collect it later (missed it).
Windows 10 x64

@TingluoHuang this looks similar to what I have reported in past. root stack might be different but the top of the frame is same. Is there a known issue in net core for this
System.Diagnostics.StackTrace.GetStackFramesInternal(StackFrameHelper sfh, Int32 iSkip, Boolean fNeedFileInfo, Exc
eption e)
at System.Diagnostics.StackFrameHelper.InitializeSourceInfo(Int32 iSkip, Boolean fNeedFileInfo, Exception exception)
at System.Diagnostics.StackTrace.CaptureStackTrace(Int32 iSkip, Boolean fNeedFileInfo, Thread targetThread, Exception
e)

@nigurr @acesiddhu
have you guys try the latest version agent?
we used to have this to workaround a bug in the agent code.
at Microsoft.VisualStudio.Services.Agent.Extensions.<WithCancellation>d__0`1.MoveNext()

In the latest version agent, we fix the real bug and delete that workaround.
I would like to see whether you can still repro with latest agent before i open an issue in coreclr.

@TingluoHuang I was using 2.112.0 version. I will give latest version a try now

@nigurr @acesiddhu assuming this is fixed. please reopen if it repros again with latest


Database setup

Software developers working on the BDC will need a database to store all collected data.
Implementation Note

The Project Description mentions, that a PostgreSQL database should be used for that purpose. However, some SDs think that NoSQL might be better (especially in the beginning) - ask Andi!
The database structure should be defined in a file so that it can easily be deployed to different contexts.

Done?

Local version of Database can be run in Docker.
Online Database is up and running.

Data can be stored and retrieved programmatically.
Database is accessible from developer machines.
Data is persisted until deleted manually.
Database is secured against external access.

Online Database is up and running.

Data can be stored and retrieved programmatically.
Database is accessible from developer machines.
Data is persisted until deleted manually.
Database is secured against external access.

This part of the Definition of Done has been dropped, since we currently do not have access to AWS.


[Remove scaffolding VM] #2: Get Methods information from GDB

Currently, NativeJDB uses the suspended VM (running the Java application being debugged) to get static information about the program and the GDB to get dynamic information.
Before any command can be issued, the IDE sends a bunch of setup commands, which are handled by the VM (HotSpotAgent) scaffolding today. The overall work consists of replacing the VM calls with associated GDB commands to get all the needed static information and satisfy the JDWP reply packet data structures.
This issue is to implement the GDB implementation for getting Methods information.
JDWP command to be implemented CmdSet 2 - Cmd 15 - ReferenceType MethodsWithGeneric in sourcefile
https://docs.oracle.com/en/java/javase/11/docs/specs/jdwp/jdwp-protocol.html#JDWP_ReferenceType_MethodsWithGeneric
Useful GDB commands:
-symbol-info-functions --name HelloNested

Related to #64 and #4


Revert "Show search app bar theme"

Reverts flutter/flutter#37962
This PR was reverted because it introduced unintended font and icon color changes. Originally the appBar's default text style was Theme.primaryTextTheme and its icon theme was Theme.primaryIconTheme. PR #37962 mistakenly changed these values to Theme.textTheme and Theme.iconTheme respectively.

The tree is now green except for 3 tests that only fail because the macs involved have artifacts on them that they can't delete. I'm going to squash and merge so that this can make a new roll candidate once the macs are fixed and brought back online.

When reverting things please remember to say why, to make future archaeology easier. Thanks.

@Hixie - updated the description to explain the rationale for reverting.


Default host to <IP_ADDRESS>

I find myself adding --host=<IP_ADDRESS> to almost every project, to be able to test my stuff on other computers in the network. I think this would make for a reasonable default, especially that it doesn’t break the current defaults (works with http://localhost and the local IP).
Is there anything I should keep in mind / watch out for?

I personally think the safer the better. Unless I'm mistaken the default for elm-reactor is also not allowing <IP_ADDRESS> by default.

Good point, let’s leave this open and see if we get other opinions.

Here's a similar discussion happened on elm-reactor, looks like people tend to prefer localhost because it's safer.

Thanks a lot, super interesting link!
Now, that’s a very strong sign the community prefers the safer default. Thanks for the feedback again!


Dynamic feature support

Added dynamic-feature library support
Added logs (for directory)

@audiserg Hey! I must have missed an email or something on this. Was this something you were still looking to get incorporated? Wanted to make sure it was still relevant.
Sorry for the oversight!

@audiserg Hey! I must have missed an email or something on this. Was this something you were still looking to get incorporated? Wanted to make sure it was still relevant.
Sorry for the oversight!

Hi Eric, yes it is relevant. Temporarily I had to make a local repository where I add my changes to the library. I would like to see these changes in the code, especially since they are not essential.I added support for dynamic modules and a bit of logging at build time. As I understand you only need to confirm the merge request


Test-DbaLinkedServerConnection doesn't return results when Get-DbaLinkedServer is piped to it.

Environmental information

#### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.14393.3053
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3053
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

#### dbatools Module version:

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.42\dbatools.psd1
Version : 1.0.42

LCID             Name             DisplayName
----             ----             -----------
1033             en-US            English (United States)

SQL Server:

Microsoft SQL Server 2016 (SP2-CU7-GDR) (KB4505222) - 13.0.5366.0 (X64)   Jun 15 2019 08:22:25   Copyright (c) Microsoft Corporation  Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2016 Datacenter 10.0 <X64> (Build 14393: ) (Hypervisor)

us_english

Report

Host used

[x] powershell.exe
[x] ISE
[x] VS Code
[ ] Other (please specify)

If anything other than powershell.exe was used, please confirm that you can duplicate the issue with powershell.exe

[x] Still buggy in powershell.exe

Errors Received
PSMessageDetails      :
Exception             : System.InvalidOperationException: Cannot force the member with name "PSStandardMembers" and type "MemberSet" to be added. A member with that name and type already exists, and the existing member is not an instance extension.
TargetObject          : [<REDACTED>]
CategoryInfo          : InvalidOperation: (<REDACTED>:PSObject) [Add-Member], InvalidOperationException
FullyQualifiedErrorId : CannotRemoveTypeDataMember,Microsoft.PowerShell.Commands.AddMemberCommand
ErrorDetails          :
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at Select-DefaultView<Process>, C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.42\allcommands.ps1: line 78835
                        at Get-DbaLinkedServer<Process>, C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.42\allcommands.ps1: line 28794
                        at <ScriptBlock>, <No file>: line 2
PipelineIterationInfo : {1, 1}

Steps to Reproduce

$SQLInstance = "MYSQLINSTANCE"
$SqlInstance | Get-DbaLinkedServer | Test-DbaLinkedServerConnection -Verbose

Expected Behavior

Expected that the call to Test-DbaLinkedServerConnection would return results
Actual Behavior

No results returned.

Essentially, I was attempting to perform a task as described in Example 5 in the documentation for that function but not getting any output.


[1.1.x] remove carbon-client.py, is broken for 4 years (1ebd4c16) | Add skipcq: PTC-W0034 (7ece7f57) | Spelling (#893) | Update storage-aggregation.conf.example (41af02c3) | add config option to turn off logging of lost connections (f90516d

Backports the following commits to 1.1.x:

remove carbon-client.py, is broken for 4 years (1ebd4c16)
Add skipcq: PTC-W0034 (7ece7f57)
Spelling (#893)
Update storage-aggregation.conf.example (41af02c3)
add config option to turn off logging of lost connections (f90516db)
change default value to False (6e69af5e)
update conf example values to False (26719e97)
Provide more complete list of aggregation options (8e701f5f)
gitignore (1d3e026b)
Replacing pyCrypto with pyca/cryptography for tests (632ffc44)
skippinmg test_enable_tcp_keep_alive on macos (0f3236a5)
Adding SKIP_TAGS_FOR_NONTAGGED, disabled by default (86dba756)
Enabling SKIP_TAGS_FOR_NONTAGGED by default (374d465a)
Fixing lint, adding pypy3 (a901c24d)
Fixes #906 (BAN-B101) Assert statement used outside of tests (d56e6e69)
Update storage.py (dd99b6b3)
Update storage.py (f0732e9f)
Fixes #908 (PTC-W0016) Unnecessary comprehension (#909)
Update hashing.py (cfd0605d)
Removed assertion check. Tests pass (c55758d7)
Adding CodeQL analysys (57e4d3d9)
Switching x86 arch tests to Github Actions (0a62da40)
Let's try simple (6d44198e)
Rearranging code a bit (e6ab4dc0)

Codecov Report

Merging #918 (d6efe1e) into 1.1.x (56250f5) will increase coverage by 1.35%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##            1.1.x     #918      +/-   ##
==========================================
+ Coverage   50.01%   51.37%   +1.35%
==========================================
  Files          37       36       -1
  Lines        3517     3430      -87
  Branches      503      495       -8
==========================================
+ Hits         1759     1762       +3
+ Misses       1642     1551      -91
- Partials      116      117       +1

Impacted Files
Coverage Δ

lib/carbon/aggregator/buffers.py
93.67% <0.00%> (ø)

lib/carbon/client.py
56.44% <ø> (+0.93%)
:arrow_up:

lib/carbon/conf.py
38.43% <ø> (ø)

lib/carbon/hashing.py
90.42% <ø> (-0.11%)
:arrow_down:

lib/carbon/instrumentation.py
28.36% <ø> (ø)

lib/carbon/protocols.py
73.47% <0.00%> (-0.33%)
:arrow_down:

lib/carbon/storage.py
69.52% <0.00%> (-3.30%)
:arrow_down:

lib/carbon/writer.py
0.00% <0.00%> (ø)

lib/carbon/util.py
50.17% <33.33%> (+0.68%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56250f5...d6efe1e. Read the comment docs.


[RM] Neutron Router Interface cannot show attached gateway interfaces.

Description:
In OpenStack Horizon, we can create Router and attach gateway ports from subnets, but in the Interface tab under a Router, it shows no any interface information for those attached ports.

Thanks @cj-chung for creating the issue. Link this issue to Issue #407 as relevant.


Update Fixtures with SDC conversion and defaults addition

Also updates cqm-models hash. CMS107v6 is not updated because it uses a QDM datatype removed in QDM 5.4.
Pull requests into cqm-execution require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[x] Tests are included and test edge cases N/A
[x] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #35   +/-   ##
======================================
  Coverage    84.8%   84.8%
======================================
  Files           6       6
  Lines         678     678
  Branches      202     202
======================================
  Hits          575     575
  Misses        103     103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3f8ea...9430a63. Read the comment docs.


rootless container permission error

Creating a container with "user:1000:1000" in the compose file generates these errors:
chmod: /var/lib/postgresql/data: Operation not permitted
chmod: /var/run/postgresql: Operation not permitted
The files belonging to this database system will be owned by user "myrootlessuser".
This user must also own the server process.

...

fixing permissions on existing directory /var/lib/postgresql/data ... initdb: error: could not change permission of directory "/var/lib/postgresql/data": Operation not permitted

This seems to happen because i'm using a subuid (which the volume correctly chowns to the bind path)
A solution to this could be to let us set the postgres user UID and GID manually, as suggested in https://github.com/docker-library/postgres/issues/1068
This works without using subuids, but doesn't if so:
services:
  pgdbex:
    image: postgres:16-alpine
    cap_drop:
      - ALL
    user: 1000:1000
    environment:
      POSTGRES_USER:
      POSTGRES_PASSWORD:
      POSTGRES_DB:
    volumes:
      - ./db:/var/lib/postgresql/data

This doesn't work in either case:
services:
  pgdbex:
    image: postgres:16-alpine
    cap_drop:
      - ALL
    user: 1000:1000
    environment:
      POSTGRES_USER:
      POSTGRES_PASSWORD:
      POSTGRES_DB:
    volumes:
      - pgdbdata:/var/lib/postgresql/data

volumes:
  pgdbdata:
    driver: local
    driver_opts:
      o: bind
      type: none
      device: ./db

By subuid, you mean literally user namespaces / dockerd running rootless, right?  In that case, you'll probably need to adjust the permissions of your "local" db volume to be what user 1000 inside the container maps to on the host -- if there's any translation happening there, it's likely your host user to "root" inside the container, not your host user to user "1000" inside the container (but I don't think there's any filesystem translation happening there, unless that's changed since I last looked at it).

A solution to this could be to let us set the postgres user UID and GID manually

That's what user: is, though (as is already supported, and you're already using)

I think you're misunderstanding something -- setting USER in the Dockerfile is exactly the same as setting --user/user: at runtime.  We support using --user/user: for changing to an explicit user specifically for users who need to ratchet security tighter -- there's a tradeoff though in that now filesystem permissions are entirely the user's responsibility (the image cannot automatically correct them), which is why we default to running the image as root but have it switch to a user as soon as it's corrected the filesystem permissions as a balance between the security and usability concerns.
You might be able to get the correct permissions on your directory by doing something like docker run --mount "type=bind,src=$PWD/db,dst=/foo" --rm --user 0:0 some-image chown -R 1000:1000 /foo (with userns/rootless applied) to set the permissions of your ./db to the "in-container" remapped user 1000, but I'm not aware of any functionality in any of the popular runtimes to do that for you.

I think you're still missing something -- we don't create any database in the Dockerfile.  We only create a directory in the Dockerfile, and it's pre-created empty, and with appropriate permissions for the postgres user within the image.  At runtime, that's when we run initdb (and any user-supplied initialization scripts).
I don't have rootless podman handy (nor anywhere I can really set it up ATM), but I do have rootless Docker which is the same for the most part (all the same underlying kernel functions), on which I can demonstrate:
$ id
uid=1000(rootless) gid=1000(rootless) groups=1000(rootless)
$ grep rootless /etc/subuid
rootless:100000:65536

$ pidof dockerd
106
$ ps | grep 106
  106 rootless  0:05 dockerd --host=unix:///run/user/1000/docker.sock --host=tcp://<IP_ADDRESS>:2376 --tlsverify --tlscacert /certs/server/ca.pem --tlscert /certs/server/cert.pem --tlskey /certs/server/key.pem

$ docker run -dit --name psql --user postgres:postgres --pull=always --env POSTGRES_PASSWORD=postgres postgres
latest: Pulling from library/postgres
Digest: sha256:8d3be35b184e70d81e54cbcbd3df3c0b47f37d06482c0dd1c140db5dbcc6a808
Status: Downloaded newer image for postgres:latest
b601a5a030b0815931d64c5326676ba4dd12362b1c78c40d4b9df4db67701a53

$ docker logs psql | tail -n1
2024-11-05 00:10:49.056 UTC [1] LOG:  database system is ready to accept connections
$ docker container inspect psql --format '{{ .State.Pid }}'
574
$ ps | grep 574
  574 100998    0:00 postgres

$ docker container inspect psql --format '{{ index .Mounts 0 "Source" }}'
/home/rootless/.local/share/docker/volumes/9ae7fd4bc14bd1a15cf173d35fb86982c756caa6ab57db35b48efb7dd9f6543f/_data
$ ls -lnd /home/rootless/.local/share/docker/volumes/9ae7fd4bc14bd1a15cf173d35fb86982c756caa6ab57db35b48efb7dd9f6543f/_data
drwx------   19 100998   100998        4096 Nov  5 00:10 /home/rootless/.local/share/docker/volumes/9ae7fd4bc14bd1a15cf173d35fb86982c756caa6ab57db35b48efb7dd9f6543f/_data

(Because of VOLUME /var/lib/postgresql/data in the image, Docker auto-created and mounted an anonymous volume there for me, and part of that behavior is copying filesystem permissions from the image, but that's the only case I'm aware of where any of these runtimes will do so.)


Update layers/meta-balena digest to 1d7b7e3

This PR contains the following updates:

Package
Update
Change

layers/meta-balena
digest
b1bc70d -> 1d7b7e3

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Can one of the admins verify this patch?


JsonWebSignature2020 RSA support

Hi! I wanted to know if there are any plans to support RSA Signatures on https://github.com/transmute-industries/verifiable-data/tree/main/packages/json-web-signature
Thanks!

There are not, but we do plan to support vc-jwt 2.0, which will support everything registered with IANA, of course its still best to move off RSA if you have the ability to.

Unfortunately, we can't change the keys. This is the only JsonWebSignature javascript suite that I found, and it seems I cannot use RsaSignature2018 neither because of a spec bug.
If needed, would you accept PRs?

Yes, we accept PRs.
On Wed, Jun 7, 2023, 10:45 PM Fabricio Gregorio @.***>
wrote:

Unfortunately, we can't change the keys. This is the only JsonWebSignature
javascript suite that I found, and it seems I cannot use RsaSignature2018
neither because of a spec bug.
If needed, would you accept PRs?
—
Reply to this email directly, view it on GitHub
https://github.com/transmute-industries/verifiable-data/issues/239#issuecomment-1581844920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7JLMDECOLVDZC7YAJ32SLXKFDG5ANCNFSM6AAAAAAY6WM4LU
.
You are receiving this because you commented.Message ID:
@.***>

just an FYI, the working group has decided to withdraw that work item: https://github.com/w3c/vc-jws-2020
Like many community signature schemes, it will keep working as long as the contexts resolve,  but I would avoid switching to it if you can.

Thanks! I am closing this issue


if total > 0 and available == 0, let jobToWorkerRatio = 1000

Now, we support letting workers scale down to 0.
Previously, if total > 0 and available == 0, we didn't send a metric.
Now, we send a large (known) number. This way the alarm will trigger and the worker will scale up.

A failure mode here is if someone sets a target metric > 1000. To be fully careful, I could make Catapult reject entries >= 1000.

Currently, all target metrics are <= 2, so very limited risk atm


[WIP] Feat(qualification testing): initial tf files and Makefile targets

High-level description
Adding qualification testing (upgrade and operating system) to the repository
Corresponding DC/OS tickets (required)

D2IQ-ID JIRA title / short description.

Related tickets (optional)

D2IQ-ID JIRA title / short description.

@mesosphere-mergebot request-review  @DominikDary @orsenthil

@mesosphere-mergebot changelog-not-required internal change


fix: always show the label for the "resolved attributes" tables

This fix makes the label over the "resolved attributes" tables (shown after a successful login when "service" is not specified in the request) always displayed - because the tables themselves are also always shown.
Insight: With the current implementation (possibly due to nesting <div> inside <p>?), the attributes table is displayed anyway, even when there are only authentication.attributes present. So using the th:unless condition doesn't make much sense here.
Note: I have tested this against 6.2.x (see #5103), but I believe the very same problem exists in the newer CAS versions, although I didn't have time to fully test them yet.

Thank you for your contributions to Apereo CAS.
When you publish the pull request, please check off relevant items below in the description of your pull request.
Please make sure you include the following:

[x] Brief description of changes applied
[ ] Test cases for all modified changes, where applicable -- N/A
[ ] The same pull request targeted at the master branch, if applicable -- TODO
[ ] Any documentation on how to configure, test -- N/A
[ ] Any possible limitations, side effects, etc -- N/A
[ ] Reference any other pull requests that might be related -- N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Note: I have tested this against 6.2.x (see #5103), but I believe the very same problem exists in the newer CAS versions, although I didn't have time to fully test them yet.

Thanks much for the patch. I'd ask you to spend a bit of time to test the patch, and also do attach before/after screenshots.

Forgot to mention that for changes that affect the UI, please follow this process to add tests:
https://apereo.github.io/cas/development/developer/Test-Process.html#browser--functional-testing

@mmoayyed, thanks for your feedback and tips. That will be a little bit more work, but I will try to do as you propose. Looks like I could at least learn another interesting tool regarding testing the UI... :)

If you need help at any time, please post back. Happy to help :)

OK, so here come the screenshots from 6.3.x:
BEFORE:

AFTER:

I also tested the master (6.4.x) version, getting the same results there.
Regarding the functional tests, I think that extending the login-success test with another text-present assertion would do. But I'm not quite sure if such detail of testing is really necessary for this quite trivial fix. What do you think?

BTW regarding the introduction of "PRINCIPAL" and "AUTHENTICATION" tabs in commit 40d76358e6722d53acc4662ce17e138968abfebb of 6.3.x (with somewhat misleading commit message "add exp policy for tgt based on service"?): while it is maybe more visually appealing, I think the previous table was a bit better from the practical perspective. I would personally vote for reverting back to the simple table and for focusing rather on making the texts of this section translatable and/or making it more clear it contains rather technical data, like by making it collapsible, with at least an introductory label being translated? A topic for another issue though, I guess this is not high in the priority list anyway...

Thanks for the screenshots. I agree that a test in this case is probably overkill. However, you should modify the changeset to not show the label always, but only if there are attributes available to show. You want to check for both principal and authentication attributes in the condition.

Yes, that's what also firstly came to my mind, but then I realized that authentication attributes will be always present, or won't they? Moreover, if we wanted to be really precise, we should also test on emptiness of resolved services and adjust the label (The following attributes and services are resolved ...) accordingly.
But my original intention was really just to have the label displayed consistently, for a start. Because the elements below it are displayed every time anyway, as I noticed at the description. Or aren't they?

Yes, that's what also firstly came to my mind, but then I realized that authentication attributes will be always present, or won't they?

By default yes, but that may not always be the case. This becomes important as this page is mainly used for troubleshooting and diagnostics during deployments and it is possible that customizations may not allow for any authn attributes, now or in the future.

Moreover, if we wanted to be really precise, we should also test on emptiness of resolved services and adjust the label (The following attributes and services are resolved ...) accordingly.

Yes, but I dont think we need to be that exact. At least, not yet.

Well, thanks for your answers, @mmoayyed. But while a minor thing, I still think it really would be more logical and practical to just always show the label for now, as the whole block never gets hidden with the current implementation, no matter what the condition evaluates to...


Allow setup account add to function without an existing config file

Addresses Issue #48

Hope it's ok I have rebased from master to fixup the tests and also fixed the merge conflicts with regards to version and coverage reference

Absolutely its okay! Thanks!

overall a great improvement, thanks

all good now, thanks much


[Viki] "Failed to download MPD manifest". One show can work one but show not work.

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
US
Description
Error:
ERROR: [viki] 1176697v: Failed to download MPD manifest: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template properly. Confirm you are on the latest version using  yt-dlp -U

I can able to download this link: https://www.viki.com/tv/36966c-the-oath-of-love
I can NOT able to download this link: https://www.viki.com/tv/37603c-to-my-star
I provide logs for 2 links.
Verbose log
# NOT WORK
$ yt-dlp https://www.viki.com/tv/37603c-to-my-star --cookies viki.com_cookies.txt -vU
[debug] Command-line config: ['https://www.viki.com/tv/37603c-to-my-star', '--cookies', 'viki.com_cookies.txt', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2<IP_ADDRESS> [e491d06d3]
[debug] Python version 3.9.12 (CPython 64bit) [omitted]
[debug] exe versions: ffmpeg 5.0 (setts), ffprobe 5.0
[debug] Optional libraries: sqlite
[debug] Proxy map: {}
Latest version: 2<IP_ADDRESS>, Current version: 2<IP_ADDRESS>
yt-dlp is up to date (2<IP_ADDRESS>)
[debug] [viki:channel] Extracting URL: https://www.viki.com/tv/37603c-to-my-star
[viki:channel] 37603c: Downloading channel JSON
[download] Downloading playlist: To My Star
[viki:channel] 37603c: Downloading Episodes JSON page 1
[viki:channel] 37603c: Downloading Movies JSON page 1
[viki:channel] 37603c: Downloading Clips JSON page 1
[viki:channel] 37603c: Downloading Trailers JSON page 1
[viki:channel] playlist To My Star: Downloading 20 videos
[download] Downloading video 1 of 20
[debug] [viki] Extracting URL: https://www.viki.com/videos/1176697v
[viki] 1176697v: Downloading video JSON
[viki] 1176697v: Downloading video streams JSON
[viki] 1176697v: Downloading initial MPD manifest
[viki] 1176697v: Downloading MPD manifest
ERROR: [viki] 1176697v: Failed to download MPD manifest: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template properly. Confirm you are on the latest version using  yt-dlp -U

# CAN WORK
$ yt-dlp https://www.viki.com/tv/36966c-the-oath-of-love --cookies viki.com_cookies.txt -vU
[debug] Command-line config: ['https://www.viki.com/tv/36966c-the-oath-of-love', '--cookies', 'viki.com_cookies.txt', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2<IP_ADDRESS> [e491d06d3]
[debug] Python version 3.9.12 (CPython 64bit) [omitted]
[debug] exe versions: ffmpeg 5.0 (setts), ffprobe 5.0
[debug] Optional libraries: sqlite
[debug] Proxy map: {}
Latest version: 2<IP_ADDRESS>, Current version: 2<IP_ADDRESS>
yt-dlp is up to date (2<IP_ADDRESS>)
[debug] [viki:channel] Extracting URL: https://www.viki.com/tv/36966c-the-oath-of-love
[viki:channel] 36966c: Downloading channel JSON
[download] Downloading playlist: The Oath of Love
[viki:channel] 36966c: Downloading Episodes JSON page 1
[viki:channel] 36966c: Downloading Movies JSON page 1
[viki:channel] 36966c: Downloading Clips JSON page 1
[viki:channel] 36966c: Downloading Trailers JSON page 1
[viki:channel] playlist The Oath of Love: Downloading 32 videos
[download] Downloading video 1 of 32
[debug] [viki] Extracting URL: https://www.viki.com/videos/1193304v
[viki] 1193304v: Downloading video JSON
[viki] 1193304v: Downloading video streams JSON
[viki] 1193304v: Downloading initial MPD manifest
[viki] 1193304v: Downloading MPD manifest
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 1193304v: Downloading 1 format(s): 1+2
[debug] Invoking downloader on "https://m-content6-viki.s.llnwi.net/1193304v/dash/1193304v_dash_high_480p_bbb880_2203151538_track1_dashinit.mp4"
[download] Resuming download at byte 132118528
[download] Destination: The Oath of Love - Episode 1 [1193304v].f1.mp4
[download]  82.8% of 152.34MiB at 758.38KiB/s ETA 00:35

The not work maybe because not Viki Pass kind of thing but Work is Viki Pass show I think.

Tag of @nyuszika7h because #1379 #2540


feat: Cta button

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #277
Test URLs:

Original: https://www.esri.com/en-us/about/about-esri/overview
Before: https://main--esri-eds--esri.aem.live/
After: https://ctaButton--esri-eds--esri.aem.live/

The right button should still show up as "negative" and the margins are still off, is this something we can tackle in follow-up PRs or do you intend to fix it in this one?
Live:

EDS:

Oh right. That is actually a content issue we should talk about. The built in primary | secondary functions in EDS will work with it. We should talk about the importer and capturing the current states.
I have an update in my draft version
https://ctabutton--esri-eds--esri.aem.page/drafts/timw/overview


Fungus 2022

Move Project to modern version of Unity (2022)

Do Not Merge this! It has been broken down into smaller pieces, see #13 #14 and #15

Not to be merged!
Broken down into smaller pieces. See: #14 #15 #17


label and legend do not match here

https://lifelines.readthedocs.io/en/latest/Examples.html#invert-axis

And the image is too small


Mistake in page Fifty-six

Hi,i am reading your works recently.And i find one mistake in page Fifty-six,in the sample code of Radio an Check Box on line seven,it should be 'this.handleChange = this.handleChange.bind(this);'instead of 'this.handeChange...' Though it is tiny mistake and i hope in next version it will be corrected.And by the way,the book is useful~

thanks all the way!


Isolation

A rebase of #105
fixes #260
Tests are broken and cleanup pending.

This change is

Prombench results under heavy query load:
samples-s
cpu-s
mem-s
Queries are marginally slower and almost unaffected.

@fabxc @brian-brazil DONE!
This is ready for review. Having a single Head and not multiple made it possible to have 0 public interface changes! I'll run this in prombench overnight for any surprises :)

fixes #260

@gouthamve if you want to rebase and fix the conflicts I would try to review it quickly.


Brave Search: Enhance search result details with extra snippets

Description:
This update significantly improves the Brave Search Tool's utility within the LangChain library by enriching the search results it returns. The tool previously returned title, link, and snippet, with the snippet being a truncated 140-character description from the search engine. To make the search results more informative, this update enables extra_snippets by default and introduces additional result fields: title, link, description (enhancing and renaming the former snippet field), age, and snippets. The snippets field provides a list of strings summarizing the webpage, utilizing Brave's capability for more detailed search insights. This enhancement aims to make the search tool far more informative and beneficial for users.
Issue: N/A
Dependencies: No additional dependencies introduced.
Twitter handle: @davidalexr987
Code Changes Summary:

Changed the default setting to include extra_snippets in search results.
Renamed the snippet field to description to accurately reflect its content and included an age field for search results.
Introduced a snippets field that lists webpage summaries, providing users with comprehensive search result insights.

Backward Compatibility Note:
The renaming of snippet to description improves the accuracy of the returned data field but may impact existing users who have developed integration's or analyses based on the snippet field. I believe this change is essential for clarity and utility, and it aligns better with the data provided by Brave Search.
Additional Notes:
This proposal focuses exclusively on the Brave Search package, without affecting other LangChain packages or introducing new dependencies.

do all results have these arguments? what type is extra_snippets? to me this seems like a rather large change, so id almost rather have this be a feature flag (verbose=Trueor the like)

Hi, yes all results have those arguments.  Extra snippets is what brave calls their summary of the web page, it's usually anywhere from 2-5 paragraphs worth of text.  They specifically added it for use in AI tools.
In the current implementation the most you can ever get back is the title, link and 'snippet', which is just the description that you would see on the search results page.
This was how I fixed it for myself, but your right a feature flag would be better.

Closing as author is unresponsive, will re-open if needed.

@ccurme Sorry about that I thought it was rejected.
Currently the search results only returns the description from the SERP, its like 2 sentences and the rest of the data gets stripped out.  I can look at it again and make a modification that isn't a breaking change and still allows users to access the extra data if they wish.

@ccurme  I’ve improved the brave search tool with very minimal changes.

The run and download_documents methods now concatenate description and extra_snippets when they're available.
This does not introduce any breaking changes but still improves the results when using the brave search api.

Please let me know if there are any further adjustments needed. Thanks!


[FEATURE] Load trained weights and run agents

Please describe the purpose of the feature. Is it related to a problem?
In order to easily evaluate agents in multiple settings, it would be optimal to have a clear way to load trained weights and agents and run them in selected environments, similarly to stable_baseline load and evaluate setting. Currently, and to the best of my knowledge, the quickstart notebook and most examples available present approaches to construct system and launch them but not how to load trained agents.
Describe the solution you'd like
A clear way / function to load network to run trained agents
Describe alternatives you've considered
Updating the system launch to restart from a given checkpoint and not go through weights updates as in this issue, but it's not clear how to do that
How do we know when implementation of this feature is complete?
Checklist:

[ One liner to load agents?  ]

Additional context
As mentionned, I've seen  this issue but it's not exactly clear how to get to the end result. Maybe just an update in documentation would suffice ? ((:
Thanks a lot !

@OmaymaMahjoub @DriesSmit Can you provide more info on how to do this?

Hello @MoMe36, thank you for the feature request!
In the latest version, Mava supports checkpointing and the ability to restore trained networks. To restore the networks, experiment_path must point to a 'checkpoints' folder, generated from a previous run. For more details, see this example. A relevant parameter for you might be the checkpoint_minute_interval parameter, which controls the interval (minutes) between checkpointing.
Moreover, I would suggest that you look at this feature  #744. We are currently implementing it (#814) and it will be available soon. This feature allows you to store and restore the network that performed the best over the course of training.
Once we merge the PR (#814), we will create some documentation explaining how it works :slightly_smiling_face: .

Awesome ! Thanks a lot ((: I'll test this approach this week-end and reopen the issue if necessary.


refactor: DefinitionStore Refactor

Abstracted the definition actions into a factory that wraps the input action. This is the framework for having dependencies update each other in an immutable pattern.

Commented code is intentional


Move pagination of notifications to pagy

Add pagy gem and configure according to previous Kaminari settings
and GOV.UK Design System recommendations
Stop paginating hiring staff notifications with Kaminari and start
paginating them with pagy
Add pagy_stats helper to show pagination statistics with our "house
style"

i just added deply review app from this, would be good to see how/if pagy handles a11y/aria on the controls it creates (im assuming a gov component would be on it with this tho)