Ignore classes annotated with @Generated #28

Provide an implementation for #28.
This is a rather dirty implementation. Based on the already existing suppression filter. There is a lot of duplicated code right now and no test.
Should this PR be improved or can it be accepted as is?
Improving this PR would probably take some time. I have some ideas, but I would like to check them with you first @gaul. Maybe lets split this. Accept the PR as is and open an issue to track the cleanup and missing test.

This also needs documentation in the README.

This needs some kind of configuration to enable it by default and disable via a parameter.  We also need to document it in the README.

@gaul I added a property to control the new behaviour. It is also documented in the README.
I also added integration tests to test the new feature. The maven-invoker-plugins builds two sample maven projects to verify that everything works as expected.

@gaul Is there anything left to do to get this merged? If I can help in any way please tell me :)

I added the integration test to check if my switch works. It was convenient to also test the general functionality of my change that way.
I think integration tests are a good addition to the plugin. If you don't want them I can remove them again.

Thank you for your contribution @Serranya!

When running this locally I see:
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec <<< FAILURE! - in org.gaul.modernizer_maven_plugin.GeneratedTest
itDetectsSuppressModernizerAnnotation(org.gaul.modernizer_maven_plugin.GeneratedTest)  Time elapsed: 0.047 sec  <<< FAILURE!
java.lang.AssertionError:

Actual and expected should have same size but actual size is:
 <0>
while expected is:
 <3>
Actual was:
<[]>
        at org.gaul.modernizer_maven_plugin.GeneratedTest.itDetectsSuppressModernizerAnnotation(GeneratedTest.java:37)

Any idea what is going on here?  This previously passed CI.

Hmm my local build succeeds. Im using openjdk-8

@Serranya When running mvn clean verify I see this with 564a1012752914c5a3654f6bc057353a12112ef5 using both java-1.8.0-openjdk.x86_64 and java-11-openjdk.x86_64.

Sorry it appears I had some litter from an earlier iteration of this patch.  I will make a 2.0.0 release including this commit soon!


Double logging of ForgetInstance failure (instance not found)

I noticed a specific bit of logging while looking at other things:
2020-06-25T04:05:55.952160+02:00 orchestrator orchestrator[26708]: [martini] Started GET /api/forget/host.example.com/3306 for <IP_ADDRESS>:49733
2020-06-25T04:05:55.994451+02:00 orchestrator orchestrator[26708]: 2020-06-25 04:05:55 ERROR ForgetInstance(): instance host.example.com:3306 not found
2020-06-25T04:05:55.994797+02:00 orchestrator orchestrator[26708]: ForgetInstance(): instance host.example.com:3306 not found
2020-06-25T04:05:55.995119+02:00 orchestrator orchestrator[26708]: [martini] Completed 500 Internal Server Error in 43.100349ms

This has a couple of problems:

the error is reported twice. Solution log once.  Consensus seems to be that normally if you handle the error you should not return an error to the caller unless you are sure the caller won't log it too.  This happens in a few places. I've only looked at this specific case and will provide a patch for it.
the internal server error feels wrong. The request failed as the instance did not exist but reporting this as an internal server error seems incorrect. That implies something unexpected happened and here the issue was recognised and reported, so while the request was not handled everything was under control.
it might be convenient to give the request some sort of tag/context so that it's easier to relate the call, any intermediate processing and the final result. On a busy system there can be a lot of log entries and if some processing takes time correlating all relevant entries can be hard.  I'm not sure of the best way to handle this but think it's good to mention it.  It's not directly related to this issue but I had to filter logs to extract those for this specific call.

This specific case was triggered by automation and "forgetting a server that does not exist" is not orchestrator's problem but the application's.
I will provide a patch to address this specific problem as it should be small, but that will be to not log inside the ForgetInstance function but leave the caller to do that. (Which seems to work on the http interface and with command line usage.

I've offered a simple patch to avoid double logging.
The reason for caring about this more than others might is that I see several thousand 500 responses in logging on a daily basis. I think most of these are harmless but it's hard to easily identify or distinguish those that are harmless from those that might a bug in orchestrator or an issue triggered by a client sending http requests.  To be clear, none of this is critical, but it would be good to distinguish an error from a failed (but handled) response to a client request.  I wonder the best way to do this.
Also related and again not a big issue at the moment as orchestrator is not usually expected to be "out in the wild in the Internet" is that it's not clear if all errors should be exposed to a caller (logging is fine) or not. For now the current behaviour seems to be trust the caller and tell him what's happened and that may be absolutely fine, but if you're paranoid in these days of security etc you might not want to expose all details to the caller.   I think for now the current attitude seems fine. but it's good to validate that decision.


Goerli added but no new package published to npm

I can see Goerli finally been added 2 months ago.
would it be possible to publish this change to NPM

Sorry.
Just published 10.2.1


Prevent from errors when deleting PulsarRPCServer objects

Dialog and DialogProgess are not part of xbmc module but xbmcgui

This is associated to this issue : https://github.com/steeve/plugin.video.pulsar/issues/97

Actually, this not needed, because of: c389d72b1d7a340b43c9858091221ab615c96985
Thank you very much anyway


feature/idf_component | Make this repo a IDF component + other inclusions

Context
This repo was very helpful to calibrate my resisitive touch display that I'm using, however it could be improved by converting this repo into a ESP-IDF component such that projects can import this as an IDF component (via component manager or as a git submodule). This PR includes the neccessary files required to do this.
Additional changes
Kconfig
I have also included a Kconfig file to allow for configuration via the ESP Project Configuration (i.e. menuconfig).

UI Text Overrides

Timeouts

Custom Calibration Points

NVS Configuration

Calibration Coefficients

Log output of the calibrated coefficients

Reference to my testing I've been doing in the past few days: https://github.com/lvgl/lvgl_esp32_drivers/issues/222
Usage of this repo/my fork: https://github.com/hiruna/lv_port_esp32/tree/develop/lvgl_8.3.7_idf_5.2

Thanks for your contribution! This is a valid improvement, so I am merging. Just going to make sure to keep compatibility with other build systems by adding some macros in lv_tc.c.

Done: c5734d304014fd6440f7aaf014a23b2ac34d8e7b

thanks for the review! i'll close this off


Call screen not working

Device name: poco f5
Rom name: evolution x (evolution_marble-userdebug 14 UP1A.231105.003<PHONE_NUMBER> release-keys)
Android version: a14
Pixelify version: 3.0

Bug Description: the call screen shows that it is working and it is speaking to the caller but the caller never hear anything.

Same,
Mi note 10 lite
Project elixir 3.13
Evolution x 7.9.9 A13
Pixelify 3.0

Same bug here, caller cannot hear assistant.
Samsung S20 FE stock A13.

I should update my comment, now working on my new phone.
POCO F5 (marble)
Stock HyperOs <IP_ADDRESS> EEA
Pixelify 3.0
Nice

I should update my comment, now working on my new phone.
POCO F5 (marble) Stock HyperOs <IP_ADDRESS> EEA Pixelify 3.0
Nice

Dude what did you do to make it work?

I should update my comment, now working on my new phone.
POCO F5 (marble) Stock HyperOs <IP_ADDRESS> EEA Pixelify 3.0
Nice

Dude what did you do to make it work?

I just flashed it with magisk. But, as i said Im on hyperos 1.0.4 EEA.
I selected: google photo unlimited backup spoof, Google app, Google dialer.
No launcher, boot animation ecc..


outlier detection: max_ejection_percent interfered by stats matcher unexpectedly

Description:
From https://github.com/istio/istio/issues/17004,

Envoy use the stats key
(https://github.com/envoyproxy/envoy/blob/38b926c63f347a70c933e0854ee9f31b1d2e85ce/source/common/upstream/outlier_detection_impl.cc#L420)
cluster.outbound|80||asm-test-http.default.svc.cluster.local.outlier_detection.ejections_active  to record the count of the pods that be ejected in the cluster now

the statsMatcher in the envoy bootstrap config is

  "statsMatcher": {
                "inclusionList": {
                    "patterns": [
                        {
                            "prefix": "cluster_manager"
                        },
                        {
                            "prefix": "listener_manager"
                        },
                        {
                            "prefix": "http_mixer_filter"
                        },
                        {
                            "prefix": "tcp_mixer_filter"
                        },
                        {
                            "prefix": "server"
                        },
                        {
                            "prefix": "cluster.xds-grpc"
                        }
                    ]
                }
            }
        },

cluster.outbound is not in the statsMatcher.inclusionList
so the counter ejections_active will be NullCounterImpl and always return zero

it cause the field maxEjectionPercent failure to limit the number of ejected nodes

Repro steps:
See https://github.com/istio/istio/issues/17004

I can confirm the same behavior in different envoy version. When these stats are filtered out envoy will eject all hosts in a cluster (and doesn't honor MaxEjectionPercent).

I think that this issue has been fixed by https://github.com/envoyproxy/envoy/pull/11629. @lambdai please confirm, so it can be closed.

@cpakulski Yes #11629 is the fix. Thank you for linking it

Hi, I'm seeing this behavior in istio 1.14, even after attempting to add the necessary stats to work around it
      proxyStatsMatcher:
        inclusionPrefixes:
          - "cluster_outlier"
          - "cluster_outbound"
          - "cluster.outbound"
        inclusionRegexps:
          - ".*cluster_outbound.*"
          - ".*cluster.outbound.*"
          - ".*outlier_detection.*"
          - ".*ejections_active.*"

I've confirmed that this isn't an issue in newer versions (1.20.2).  I'd like to get this working in an older version which we'll be running for some time in certain environments before we upgrade.  Can you confirm whether this stat configuration should fix my problem, and if not, what else I should try?


Support LDAP authorization

Request details
I don't know much about implementation of LDAP authorization, but this feature has been already mentioned a few times, so it might be a good idea to investigate this topic during alpha phase.

https://spring.io/guides/gs/authenticating-ldap/


Python intellisence fails to detect modules within code

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
VS2022: Python intellisence fails to detect modules that are already the part of code, and wrongly hints at the return types.

Original Comments
Feedback Bot on 11/15/2021, 00:23 AM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Original Solutions
(no solutions)

Can you please provide code where this repros? Thanks!

Closing old issue. If this is still a problem, please reopen with the information requested. thanks


Renamed Time based query

Renamed the class, files, and metadata.

Please give this another review, I've resolved merge conflicts.


Has anyone gotten caught with this bot?

Just curious. A bit nervous

On Fri, 20 Apr 2018 at 18:48, scaryslender18<EMAIL_ADDRESS>wrote:

Just curious. A bit nervous
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Exaphis/HackQ-Trivia/issues/76, or mute the thread
https://github.com/notifications/unsubscribe-auth/AkoKAPHb8aJwK51A9Sp-JNQzV4hs0dKvks5tqhFGgaJpZM4Tdxcj
.

No

@AlexLovesAlpacaa some people are saying just to use an example userID and bearer token. Is that fine

On Fri, 20 Apr 2018 at 19:30, scaryslender18<EMAIL_ADDRESS>wrote:

@AlexLovesAlpacaa https://github.com/AlexLovesAlpacaa some people are
saying just to use an example userID and bearer token. Is that fine
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Exaphis/HackQ-Trivia/issues/76#issuecomment-383167251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkoKAC-OXwgqSdXYGGGYW45gSEa_-_ZVks5tqhsugaJpZM4Tdxcj
.

Yes, if you want I can give you a Bearer and ID Number, I can walk you
through if you want on Discord: Ardystie#0001

Sure that'd be helpful, thanks.

@AlexLovesAlpacaa sorry, what's the invite link to that?

On Fri, 20 Apr 2018 at 19:57, scaryslender18<EMAIL_ADDRESS>wrote:

@AlexLovesAlpacaa https://github.com/AlexLovesAlpacaa sorry, what's the
invite link to that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Exaphis/HackQ-Trivia/issues/76#issuecomment-383174886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkoKAG0PolviOxTEjQlfDrrLmMOa9Qgpks5tqiGPgaJpZM4Tdxcj
.

Just send me your Discord Name with Tag

@AlexLovesAlpacaa weab00#0293

Hey @AlexLovesAlpacaa.
Is it possible if you can send me your Bearer and ID Number, thanks.
Discord-hdshow#3687

On Fri, 20 Apr 2018 at 21:42, Killerdon2<EMAIL_ADDRESS>wrote:

Hey @AlexLovesAlpacaa https://github.com/AlexLovesAlpacaa.
Is it possible if you can send me your Bearer and ID Number, thanks.
Discord-hdshow#3687
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Exaphis/HackQ-Trivia/issues/76#issuecomment-383201455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkoKAJ-fGy-G-0JYbhPOwKDxLAicDzBoks5tqjoqgaJpZM4Tdxcj
.

BEARER:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VySWQiOjE1OTQ0MTI2LCJ1c2VybmFtZSI6IkFsZXhhbmRlclNpZmZpIiwiYXZhdGFyVXJsIjoiczM6Ly9oeXBlc3BhY2UtcXVpei9hL2JiLzE1OTQ0MTI2LUhpV0M3ci5qcGciLCJ0b2tlbiI6IlVYcW4wYyIsInJvbGVzIjpbXSwiY2xpZW50IjoiIiwiZ3Vlc3RJZCI6bnVsbCwidiI6MSwiaWF0IjoxNTIzOTY5NjA1LCJleHAiOjE1MzE3NDU2MDUsImlzcyI6Imh5cGVxdWl6LzEifQ.Nm0p2g7_DhsJoWmB3tSbLGpELe4zkchxRrrmS7my_Qc
ID(US):15944126

Getting bearer id and token is real simple anyways. If you are new to Charels Proxy or any such, just download the app named Packet Sniffer and run it. Quite easy to run and does work. Have you tried @AlexLovesAlpacaa ?

If on iOS then you need to install the mitproxy profile and then go to settings general about trust_certificates and enable it.

I could not get mitproxy to work, I tried it on Windows 10 and Kali Linux with no luck. Then, I installed Packet Capture on my Android phone and I could see the HQ SSL packages show up but they all had 'no data'. I will keep trying lol

@U-r-Unknown thanks for the charles proxy suggestion! but reading their documentations it says that "As of Android N, you need to add configuration to your app in order to have it trust the SSL certificates generated by Charles SSL Proxying. This means that you can only use SSL Proxying with apps that you control."

Did u save Charles root certificate  on ur Android. To do this save Charles certificate in ur storage of phone.then go to security - install certificate from storage- save

@U-r-Unknown thanks for the suggestions but I have installed the Charles root certificate. The way that I did it was by going to chls.pro/ssl on my phone and it downloaded and installed the certificate.  I have been setting the proxy but when I did mitproxy I saw some people using a static IP and setting a gateway instead.

@neilmunday thanks for the info! I had a feeling that that's what was going on...so, how can I get the Bearer key now? Does an Iphone have the same problems? How do you guys do it?


Remove brackets from echo call and use PHP_EOL over \n

echo is a language construct rather than a function, so shouldn't really have brackets when called. Also switched to using a platform agnostic new line.

"\n" is the ASCII character "linefeed" (LF) on all platforms. PHP_EOL depends on the OS and may be either a single LF or CRLF.
I wouldn't call PHP_EOL platform-agnostic. It was built in for a different purpose than emitting HTML to browsers, I guess: Creating server-local files that get consumed by OS-dependent software like Windows Notepad (which cannot deal with only LF until recently).

@SvenRtbg thanks for the feedback. Would you like me remove that and leave \n in place?

That is my intention. It is mostly useless for a web software to address line ending issues, because they do not exist. Go with the least amount of effort and use "\n".

Cool, done

@SvenRtbg I realise this is pretty minor, but do you want to merge it?

I would do it, but I am lacking rights. I have an open PR myself that is being ignored for some time now...


Add [PureAttribute] on suitable methods

var predicate = PredicateBuilder.New(expr1);
predicate.And(expr2);
Context.Documents.Find(predicate);

The code above is wrong, because expr2 is actually never used as a predicate. Adding [PureAttribute] on suitable methods like And would throw a warning at compile time when the return value of the method is not used, allowing users to find this kind of mistakes more easily.

Hello @Logerfo,
Thanks for this information.
Can you please provide a full code example from the change you would like to see? Or create a PR?


Peer Review

Great title and abstract both informative, your ReadMe is super clear on how to reproduce of paper and navigate if repo which is very comprehensive. The ReadME title and the paper title are different, would be good to stick to one version and apply throughout.

Expanding on the significance of this dataset and how it may be used or why it’s needed/ a nice addition to the world would add more depth to your analysis. You touch on the gap that exists but not so why it needs to be filled.

You have good visualizations, just need to clean up the legends and formatting a bit more

Some sections are not finished, but I'm sure it will be completed soon.

Best of luck with this paper, looks good so far!

Check point
Expanding on the significance of this dataset and how it may be used or why it’s needed/ a nice addition to the world would add more depth to your analysis. You touch on the gap that exists but not so why it needs to be filled.


Handle JavaScript true/false

If I'm filtering from AJAX, I'm likely to use JavaScript's true/false values. These will be converted to the strings "true" or "false" and be ignored by the filter. I would then have to either handle this in JavaScript by using the "True" or "False" strings, exposing server implementation details, or handle this on the server. I think django-filter should handle this conversion implicitly.
I'm using version 0.10.0

If you need to support custom values in the query string you need to create a custom widget and implement value_from_datadict to handle the values you're after.

I fully appreciate your reasoning, however Javascript is a really common way to interact with a service. Not supporting it in django-filter simply forces everyone to reimplement the exact same functionality.
I'm happy to implement it in your way, however I do think it should be part of the core library.

I'm happy to implement it in your way, however I do think it should be part of the core library.

A PR with a widget implementing this, together with tests, and docs including a usage example — users need to pass the widget kwarg to the Filter — would be great.

Awesome, cheers.


esp-idf dhcp client gives different ip each time we boot, arduino-esp32 does not

Hi,
We have the following problem:
ESP32 compiled with latest esp-idf on certain networks gets from the dhcp server each time we boot another ip address.
When we compile with latest arduino-esp32 with all the same hardware it runs fine and we get always the same ip -> like it should be.
Other facts:

DHCP client with esp-idf takes >5 sec. to get the ip. Compiled with arduino < 1 sec.
DHCP client on my home network works fine in both cases. (fast and always same IP). It only occurs on certain networks. (in our case our company network). I understand that it is not on all networks (like yours?) but why does the same hardware works fine on our network when it is compiled with the arduino-esp32. It means that there is a kind of incompability between these 2; esp-idf and our cisco infrastructure. Something that is fixed on the arduino-esp32.
See also github espressif/arduino-esp32 : issue # 1000 - Get new IP address each time the ESP32 gets started/reboot. They HAD that problem too! It seems to be fixed somewhere?
When compiled with esp-idf our DHCP server shows BAD_ADDRESS
First boot

After second boot:

After third boot:

This is not happening with arduino-esp32.

I also added the 2 test projects, 1 for esp-idf and 1 for arduino-esp32:
simple_wifi.zip
WiFiClient.zip
This is the generated output from arduino (all tested with the same hardware):
FIRST BOOT:

ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:808
load:0x40078000,len:6084
load:0x40080000,len:6696
entry 0x400802e4

Connecting to ATS E-Paper
..
WiFi connected
IP address:
<IP_ADDRESS>

SECOND BOOT:

ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:808
load:0x40078000,len:6084
load:0x40080000,len:6696
entry 0x400802e4

Connecting to ATS E-Paper
..
WiFi connected
IP address:
<IP_ADDRESS>

THIRD BOOT:

ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:808
load:0x40078000,len:6084
load:0x40080000,len:6696
entry 0x400802e4

Connecting to ATS E-Paper
..
WiFi connected
IP address:
<IP_ADDRESS>

Each time same IP.
This is the output from esp-idf:
FIRST BOOT:

ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:5716
load:0x40078000,len:7684
ho 0 tail 12 room 4
load:0x40080000,len:7392
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

entry 0x4008039c
0x4008039c: _UserExceptionVector at ??:?

I (30) boot: ESP-IDF v3.2-dev-144-g6ee3cf67 2nd stage bootloader
I (30) boot: compile time 15:14:08
I (32) boot: Enabling RNG early entropy source...
I (36) boot: SPI Speed      : 40MHz
I (40) boot: SPI Mode       : DIO
I (44) boot: SPI Flash Size : 8MB
I (48) boot: Partition Table:
I (52) boot: ## Label            Usage          Type ST Offset   Length
I (59) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (66) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (74) boot:  2 factory          factory app      00 00 00010000 00100000
I (81) boot: End of partition table
I (86) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x11734 ( 71476) map
I (120) esp_image: segment 1: paddr=0x0002175c vaddr=0x3ffb0000 size=0x034d8 ( 13528) load
I (125) esp_image: segment 2: paddr=0x00024c3c vaddr=0x3ffb34d8 size=0x00000 (     0) load
I (126) esp_image: segment 3: paddr=0x00024c44 vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

I (136) esp_image: segment 4: paddr=0x0002504c vaddr=0x40080400 size=0x0afc4 ( 44996) load
I (163) esp_image: segment 5: paddr=0x00030018 vaddr=0x400d0018 size=0x61214 (397844) map
0x400d0018: _stext at ??:?

I (302) esp_image: segment 6: paddr=0x00091234 vaddr=0x4008b3c4 size=0x04fb4 ( 20404) load
0x4008b3c4: xQueueGenericReceive at /Users/skor/esp/esp-idf/components/freertos/queue.c:2037

I (311) esp_image: segment 7: paddr=0x000961f0 vaddr=0x400c0000 size=0x00000 (     0) load
I (312) esp_image: segment 8: paddr=0x000961f8 vaddr=0x50000000 size=0x00000 (     0) load
I (328) boot: Loaded app from partition at offset 0x10000
I (328) boot: Disabling RNG early entropy source...
I (330) cpu_start: Pro cpu up.
I (333) cpu_start: Starting app cpu, entry point is 0x40080fcc
0x40080fcc: call_start_cpu1 at /Users/skor/esp/esp-idf/components/esp32/cpu_start.c:225

I (0) cpu_start: App cpu up.
I (344) heap_init: Initializing. RAM available for dynamic allocation:
I (351) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (357) heap_init: At 3FFB94B8 len 00026B48 (154 KiB): DRAM
I (363) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (369) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (376) heap_init: At 40090378 len 0000FC88 (63 KiB): IRAM
I (382) cpu_start: Pro cpu start user code
I (65) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (112) simple wifi: ESP_WIFI_MODE_STA
I (112) wifi: wifi driver task: 3ffc0788, prio:23, stack:3584, core=0
I (112) wifi: wifi firmware version: 771f1dc
I (122) wifi: config NVS flash: enabled
I (122) wifi: config nano formating: disabled
I (122) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (132) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (162) wifi: Init dynamic tx buffer num: 32
I (162) wifi: Init data frame dynamic rx buffer num: 32
I (162) wifi: Init management frame dynamic rx buffer num: 32
I (172) wifi: Init static rx buffer size: 1600
I (172) wifi: Init static rx buffer num: 10
I (172) wifi: Init dynamic rx buffer num: 32
I (252) phy: phy_version: 3910, c0c45a3, May 21 2018, 18:07:06, 0, 0
I (262) wifi: mode : sta (30:ae:a4:50:16:34)
I (262) simple wifi: wifi_init_sta finished.
I (262) simple wifi: connect to ap
I (382) wifi: n:1 0, o:1 0, ap:255 255, sta:1 0, prof:1
I (1362) wifi: state: init -> auth (b0)
I (1372) wifi: state: auth -> assoc (0)
I (1382) wifi: state: assoc -> run (10)
I (1402) wifi: connected with ATS E-Paper, channel 1
I (1412) wifi: pm start, type: 1

I (12072) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (12072) simple wifi: got ip:<IP_ADDRESS>

SECOND BOOT:

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:5716
load:0x40078000,len:7684
ho 0 tail 12 room 4
load:0x40080000,len:7392
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

entry 0x4008039c
0x4008039c: _UserExceptionVector at ??:?

I (30) boot: ESP-IDF v3.2-dev-144-g6ee3cf67 2nd stage bootloader
I (30) boot: compile time 15:14:08
I (32) boot: Enabling RNG early entropy source...
I (36) boot: SPI Speed      : 40MHz
I (40) boot: SPI Mode       : DIO
I (44) boot: SPI Flash Size : 8MB
I (48) boot: Partition Table:
I (52) boot: ## Label            Usage          Type ST Offset   Length
I (59) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (66) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (74) boot:  2 factory          factory app      00 00 00010000 00100000
I (81) boot: End of partition table
I (86) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x11734 ( 71476) map
I (120) esp_image: segment 1: paddr=0x0002175c vaddr=0x3ffb0000 size=0x034d8 ( 13528) load
I (125) esp_image: segment 2: paddr=0x00024c3c vaddr=0x3ffb34d8 size=0x00000 (     0) load
I (126) esp_image: segment 3: paddr=0x00024c44 vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

I (136) esp_image: segment 4: paddr=0x0002504c vaddr=0x40080400 size=0x0afc4 ( 44996) load
I (163) esp_image: segment 5: paddr=0x00030018 vaddr=0x400d0018 size=0x61214 (397844) map
0x400d0018: _stext at ??:?

I (302) esp_image: segment 6: paddr=0x00091234 vaddr=0x4008b3c4 size=0x04fb4 ( 20404) load
0x4008b3c4: xQueueGenericReceive at /Users/skor/esp/esp-idf/components/freertos/queue.c:2037

I (311) esp_image: segment 7: paddr=0x000961f0 vaddr=0x400c0000 size=0x00000 (     0) load
I (311) esp_image: segment 8: paddr=0x000961f8 vaddr=0x50000000 size=0x00000 (     0) load
I (328) boot: Loaded app from partition at offset 0x10000
I (328) boot: Disabling RNG early entropy source...
I (330) cpu_start: Pro cpu up.
I (333) cpu_start: Starting app cpu, entry point is 0x40080fcc
0x40080fcc: call_start_cpu1 at /Users/skor/esp/esp-idf/components/esp32/cpu_start.c:225

I (0) cpu_start: App cpu up.
I (344) heap_init: Initializing. RAM available for dynamic allocation:
I (351) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (357) heap_init: At 3FFB94B8 len 00026B48 (154 KiB): DRAM
I (363) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (369) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (376) heap_init: At 40090378 len 0000FC88 (63 KiB): IRAM
I (382) cpu_start: Pro cpu start user code
I (64) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (113) simple wifi: ESP_WIFI_MODE_STA
I (123) wifi: wifi driver task: 3ffc0704, prio:23, stack:3584, core=0
I (123) wifi: wifi firmware version: 771f1dc
I (123) wifi: config NVS flash: enabled
I (123) wifi: config nano formating: disabled
I (123) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (133) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (163) wifi: Init dynamic tx buffer num: 32
I (163) wifi: Init data frame dynamic rx buffer num: 32
I (163) wifi: Init management frame dynamic rx buffer num: 32
I (173) wifi: Init static rx buffer size: 1600
I (173) wifi: Init static rx buffer num: 10
I (183) wifi: Init dynamic rx buffer num: 32
I (263) phy: phy_version: 3910, c0c45a3, May 21 2018, 18:07:06, 0, 0
I (263) wifi: mode : sta (30:ae:a4:50:16:34)
I (263) simple wifi: wifi_init_sta finished.
I (263) simple wifi: connect to ap
I (383) wifi: n:1 0, o:1 0, ap:255 255, sta:1 0, prof:1
I (1363) wifi: state: init -> auth (b0)
I (1373) wifi: state: auth -> assoc (0)
I (1373) wifi: state: assoc -> run (10)
I (1393) wifi: connected with ATS E-Paper, channel 1
I (1403) wifi: pm start, type: 1

I (12073) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (12073) simple wifi: got ip:<IP_ADDRESS>

THIRD BOOT:

ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:5716
load:0x40078000,len:7684
ho 0 tail 12 room 4
load:0x40080000,len:7392
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

entry 0x4008039c
0x4008039c: _UserExceptionVector at ??:?

I (30) boot: ESP-IDF v3.2-dev-144-g6ee3cf67 2nd stage bootloader
I (30) boot: compile time 15:14:08
I (32) boot: Enabling RNG early entropy source...
I (36) boot: SPI Speed      : 40MHz
I (40) boot: SPI Mode       : DIO
I (44) boot: SPI Flash Size : 8MB
I (48) boot: Partition Table:
I (52) boot: ## Label            Usage          Type ST Offset   Length
I (59) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (66) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (74) boot:  2 factory          factory app      00 00 00010000 00100000
I (81) boot: End of partition table
I (86) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x11734 ( 71476) map
I (120) esp_image: segment 1: paddr=0x0002175c vaddr=0x3ffb0000 size=0x034d8 ( 13528) load
I (125) esp_image: segment 2: paddr=0x00024c3c vaddr=0x3ffb34d8 size=0x00000 (     0) load
I (126) esp_image: segment 3: paddr=0x00024c44 vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

I (136) esp_image: segment 4: paddr=0x0002504c vaddr=0x40080400 size=0x0afc4 ( 44996) load
I (163) esp_image: segment 5: paddr=0x00030018 vaddr=0x400d0018 size=0x61214 (397844) map
0x400d0018: _stext at ??:?

I (302) esp_image: segment 6: paddr=0x00091234 vaddr=0x4008b3c4 size=0x04fb4 ( 20404) load
0x4008b3c4: xQueueGenericReceive at /Users/skor/esp/esp-idf/components/freertos/queue.c:2037

I (311) esp_image: segment 7: paddr=0x000961f0 vaddr=0x400c0000 size=0x00000 (     0) load
I (311) esp_image: segment 8: paddr=0x000961f8 vaddr=0x50000000 size=0x00000 (     0) load
I (328) boot: Loaded app from partition at offset 0x10000
I (328) boot: Disabling RNG early entropy source...
I (330) cpu_start: Pro cpu up.
I (333) cpu_start: Starting app cpu, entry point is 0x40080fcc
0x40080fcc: call_start_cpu1 at /Users/skor/esp/esp-idf/components/esp32/cpu_start.c:225

I (0) cpu_start: App cpu up.
I (344) heap_init: Initializing. RAM available for dynamic allocation:
I (351) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (357) heap_init: At 3FFB94B8 len 00026B48 (154 KiB): DRAM
I (363) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (369) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (376) heap_init: At 40090378 len 0000FC88 (63 KiB): IRAM
I (382) cpu_start: Pro cpu start user code
I (64) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (113) simple wifi: ESP_WIFI_MODE_STA
I (123) wifi: wifi driver task: 3ffc0704, prio:23, stack:3584, core=0
I (123) wifi: wifi firmware version: 771f1dc
I (123) wifi: config NVS flash: enabled
I (123) wifi: config nano formating: disabled
I (123) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (133) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (163) wifi: Init dynamic tx buffer num: 32
I (163) wifi: Init data frame dynamic rx buffer num: 32
I (163) wifi: Init management frame dynamic rx buffer num: 32
I (173) wifi: Init static rx buffer size: 1600
I (173) wifi: Init static rx buffer num: 10
I (183) wifi: Init dynamic rx buffer num: 32
I (263) phy: phy_version: 3910, c0c45a3, May 21 2018, 18:07:06, 0, 0
I (263) wifi: mode : sta (30:ae:a4:50:16:34)
I (263) simple wifi: wifi_init_sta finished.
I (263) simple wifi: connect to ap
I (383) wifi: n:1 0, o:1 0, ap:255 255, sta:1 0, prof:1
I (1363) wifi: state: init -> auth (b0)
I (1373) wifi: state: auth -> assoc (0)
I (1373) wifi: state: assoc -> run (10)
I (1393) wifi: connected with ATS E-Paper, channel 1
I (1403) wifi: pm start, type: 1

I (12073) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (12073) simple wifi: got ip:<IP_ADDRESS>
ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:5716
load:0x40078000,len:7684
ho 0 tail 12 room 4
load:0x40080000,len:7392
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

entry 0x4008039c
0x4008039c: _UserExceptionVector at ??:?

I (30) boot: ESP-IDF v3.2-dev-144-g6ee3cf67 2nd stage bootloader
I (30) boot: compile time 15:14:08
I (32) boot: Enabling RNG early entropy source...
I (36) boot: SPI Speed      : 40MHz
I (40) boot: SPI Mode       : DIO
I (44) boot: SPI Flash Size : 8MB
I (48) boot: Partition Table:
I (52) boot: ## Label            Usage          Type ST Offset   Length
I (59) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (66) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (74) boot:  2 factory          factory app      00 00 00010000 00100000
I (81) boot: End of partition table
I (86) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x11734 ( 71476) map
I (120) esp_image: segment 1: paddr=0x0002175c vaddr=0x3ffb0000 size=0x034d8 ( 13528) load
I (125) esp_image: segment 2: paddr=0x00024c3c vaddr=0x3ffb34d8 size=0x00000 (     0) load
I (126) esp_image: segment 3: paddr=0x00024c44 vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _iram_start at /Users/skor/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

I (136) esp_image: segment 4: paddr=0x0002504c vaddr=0x40080400 size=0x0afc4 ( 44996) load
I (163) esp_image: segment 5: paddr=0x00030018 vaddr=0x400d0018 size=0x61214 (397844) map
0x400d0018: _stext at ??:?

I (302) esp_image: segment 6: paddr=0x00091234 vaddr=0x4008b3c4 size=0x04fb4 ( 20404) load
0x4008b3c4: xQueueGenericReceive at /Users/skor/esp/esp-idf/components/freertos/queue.c:2037

I (311) esp_image: segment 7: paddr=0x000961f0 vaddr=0x400c0000 size=0x00000 (     0) load
I (312) esp_image: segment 8: paddr=0x000961f8 vaddr=0x50000000 size=0x00000 (     0) load
I (328) boot: Loaded app from partition at offset 0x10000
I (328) boot: Disabling RNG early entropy source...
I (330) cpu_start: Pro cpu up.
I (333) cpu_start: Starting app cpu, entry point is 0x40080fcc
0x40080fcc: call_start_cpu1 at /Users/skor/esp/esp-idf/components/esp32/cpu_start.c:225

I (0) cpu_start: App cpu up.
I (344) heap_init: Initializing. RAM available for dynamic allocation:
I (351) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (357) heap_init: At 3FFB94B8 len 00026B48 (154 KiB): DRAM
I (363) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (369) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (376) heap_init: At 40090378 len 0000FC88 (63 KiB): IRAM
I (382) cpu_start: Pro cpu start user code
I (65) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (89) simple wifi: ESP_WIFI_MODE_STA
I (89) wifi: wifi driver task: 3ffc0788, prio:23, stack:3584, core=0
I (89) wifi: wifi firmware version: 771f1dc
I (89) wifi: config NVS flash: enabled
I (99) wifi: config nano formating: disabled
I (99) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (109) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (139) wifi: Init dynamic tx buffer num: 32
I (139) wifi: Init data frame dynamic rx buffer num: 32
I (139) wifi: Init management frame dynamic rx buffer num: 32
I (139) wifi: Init static rx buffer size: 1600
I (149) wifi: Init static rx buffer num: 10
I (149) wifi: Init dynamic rx buffer num: 32
I (229) phy: phy_version: 3910, c0c45a3, May 21 2018, 18:07:06, 0, 0
I (229) wifi: mode : sta (30:ae:a4:50:16:34)
I (229) simple wifi: wifi_init_sta finished.
I (239) simple wifi: connect to ap
I (359) wifi: n:1 0, o:1 0, ap:255 255, sta:1 0, prof:1
I (1339) wifi: state: init -> auth (b0)
I (1339) wifi: state: auth -> assoc (0)
I (1349) wifi: state: assoc -> run (10)
I (1369) wifi: connected with ATS E-Paper, channel 1
I (1379) wifi: pm start, type: 1

I (12049) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (12049) simple wifi: got ip:<IP_ADDRESS>

Please help to get this fixed!
Korstiaan

The logs on for the good version (arduino compile) shows on the dhcp server: (only renew)

The bad version (esp-idf) shows: (assign - renew)

@korstiaanS please try the following two functions (replace them in your code) and since you have a reliable way to reproduce it (I could not) I would ask you to please try and figure out which line/order of items is triggering it. The two functions are a simplified version of WiFi.connect(ssid, pass)
static esp_err_t event_handler(void *ctx, system_event_t *event)
{
    switch(event->event_id) {
    case SYSTEM_EVENT_STA_GOT_IP:
        ESP_LOGI(TAG, "got ip:%s",
                 ip4addr_ntoa(&event->event_info.got_ip.ip_info.ip));
        xEventGroupSetBits(wifi_event_group, WIFI_CONNECTED_BIT);
        break;
    case SYSTEM_EVENT_STA_DISCONNECTED:
        ESP_LOGW(TAG, "disconnected: %u",
                 event->event_info.disconnected.reason);
        esp_wifi_connect();
        xEventGroupClearBits(wifi_event_group, WIFI_CONNECTED_BIT);
        break;
    default:
        break;
    }
    return ESP_OK;
}

void wifi_init_sta(){
    tcpip_adapter_ip_info_t ip;
    wifi_config_t conf;
    wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();

    wifi_event_group = xEventGroupCreate();

    memset(&conf, 0, sizeof(wifi_config_t));
    strcpy((char*)(conf.sta.ssid), EXAMPLE_ESP_WIFI_SSID);
    strcpy((char*)(conf.sta.password), EXAMPLE_ESP_WIFI_PASS);

    ESP_ERROR_CHECK(esp_event_loop_init(event_handler, NULL));
    tcpip_adapter_init();
    ESP_ERROR_CHECK(esp_wifi_init(&cfg));
    ESP_ERROR_CHECK(esp_wifi_start());
    ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA));
    ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_STA, &conf));

    esp_err_t err = tcpip_adapter_dhcpc_start(TCPIP_ADAPTER_IF_STA);
    if(err == ESP_ERR_TCPIP_ADAPTER_DHCPC_START_FAILED){
        ESP_ERROR_CHECK(err);
    }

    ESP_ERROR_CHECK(esp_wifi_connect());
    ESP_LOGI(TAG, "wifi_init_sta finished.");
    ESP_LOGI(TAG, "connect to ap");
}

Hi,
Same result.
Output:
First boot:
I (0) cpu_start: App cpu up.
I (344) heap_init: Initializing. RAM available for dynamic allocation:
I (351) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (357) heap_init: At 3FFB94B8 len 00026B48 (154 KiB): DRAM
I (363) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (370) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (376) heap_init: At 40090378 len 0000FC88 (63 KiB): IRAM
I (382) cpu_start: Pro cpu start user code
I (65) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (113) simple wifi: ESP_WIFI_MODE_STA
I (123) wifi: wifi driver task: 3ffc0704, prio:23, stack:3584, core=0
I (123) wifi: wifi firmware version: 771f1dc
I (123) wifi: config NVS flash: enabled
I (123) wifi: config nano formating: disabled
I (123) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (133) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (163) wifi: Init dynamic tx buffer num: 32
I (163) wifi: Init data frame dynamic rx buffer num: 32
I (163) wifi: Init management frame dynamic rx buffer num: 32
I (173) wifi: Init static rx buffer size: 1600
I (173) wifi: Init static rx buffer num: 10
I (183) wifi: Init dynamic rx buffer num: 32
I (243) phy: phy_version: 3910, c0c45a3, May 21 2018, 18:07:06, 0, 0
I (243) wifi: mode : sta (30:ae:a4:50:16:34)
I (263) simple wifi: wifi_init_sta finished.
I (263) simple wifi: connect to ap
I (383) wifi: n:1 0, o:1 0, ap:255 255, sta:1 0, prof:1
I (1373) wifi: state: init -> auth (b0)
I (1373) wifi: state: auth -> assoc (0)
I (1373) wifi: state: assoc -> run (10)
I (1413) wifi: connected with ATS E-Paper, channel 1
I (1413) wifi: pm start, type: 1

I (12083) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (12083) simple wifi: got ip:<IP_ADDRESS>

Second boot:
I (0) cpu_start: App cpu up.
I (344) heap_init: Initializing. RAM available for dynamic allocation:
I (351) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (357) heap_init: At 3FFB94B8 len 00026B48 (154 KiB): DRAM
I (363) heap_init: At 3FFE0440 len 00003BC0 (14 KiB): D/IRAM
I (370) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (376) heap_init: At 40090378 len 0000FC88 (63 KiB): IRAM
I (382) cpu_start: Pro cpu start user code
I (65) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (89) simple wifi: ESP_WIFI_MODE_STA
I (89) wifi: wifi driver task: 3ffc0704, prio:23, stack:3584, core=0
I (89) wifi: wifi firmware version: 771f1dc
I (89) wifi: config NVS flash: enabled
I (99) wifi: config nano formating: disabled
I (99) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (109) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (139) wifi: Init dynamic tx buffer num: 32
I (139) wifi: Init data frame dynamic rx buffer num: 32
I (139) wifi: Init management frame dynamic rx buffer num: 32
I (139) wifi: Init static rx buffer size: 1600
I (149) wifi: Init static rx buffer num: 10
I (149) wifi: Init dynamic rx buffer num: 32
I (219) phy: phy_version: 3910, c0c45a3, May 21 2018, 18:07:06, 0, 0
I (219) wifi: mode : sta (30:ae:a4:50:16:34)
I (239) simple wifi: wifi_init_sta finished.
I (239) simple wifi: connect to ap
I (359) wifi: n:1 0, o:1 0, ap:255 255, sta:1 0, prof:1
I (1339) wifi: state: init -> auth (b0)
I (1359) wifi: state: auth -> assoc (0)
I (1359) wifi: state: assoc -> run (10)
I (1379) wifi: connected with ATS E-Paper, channel 1
I (1509) wifi: pm start, type: 1

I (12069) event: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (12069) simple wifi: got ip:<IP_ADDRESS>

OK, new idea :) since it looks like the only difference left. Arduino spins a task from app_main and does everything in that task. Can you test that? The code otherwise is 1:1 what Arduino executes when starting STA

Has nothing to do with esp but they had simular problems.
Look at the last 2 posts. Can maybe of help?
http://forums.netduino.com/index.php?/topic/614-dhcp-getting-different-ip-address-each-time-i-restart/

OK Then... maybe there is something in menuconfig causing this issue? Can you try Arduino's sdkconfig and see if there are any differences (there are some DHCP/ARP options in menuconfig).
Arduino's sdkconfig is here: https://github.com/espressif/arduino-esp32/blob/master/tools/sdk/sdkconfig

Yes :) it just took a couple of back and fourth to figure out what could be it. I will ask the default value to be changed to no. And now we will know what could be the reason for the future.
Thanks @korstiaanS for sticking with it and helping debug the issue!

Thank you for helping solving this problem!
We can continue now with our Homekit (and other) ESP projects.
PS: Espressif/ESP is for me one of best inventions of the last decade. Congrats to all of you for bringing such beautifull products.

Closing this now as resolved :) ping us back if we can help with anything else

So is there something on the network that is actually replying to the arp request saying the IP is in use?

Note that the lwIP DHCP code does not notice that the ARP response contains its own MAC address in all fields; it simply acts on it.
This sounds fixable

I use arduino-esp32 and it worked flawlessly until recently, where I did notice that on networks with ARP-caching that DHCP it is not working.
Took me quite some time to figure out why LWIP DECLINES a ACKd IP.
@me-no-dev Wouldn't it be possible to do an MAC-address check (e.g. check if it's own address), so that IF routers/APs reply on behalf of the client, the DHCP still works? Or is there a technical reasoning why this isn't happening/done?
To me: It absolutely makes no sense, especially in cases like mine, where I quite regularly reboot the ESP32 because of battery-saving.

@tynx can you please take tcpdump of the exchange? We recently updated LwIP to 2.0.3 and I guess that the issue is a result of that. A dump can help trace the packet through the code :)

So I went into the code and saw that only this line can be the reason for it:
https://github.com/espressif/esp-lwip/blob/3b88e84f9b05e76a1ad96e6650a795df74af23aa/src/core/ipv4/dhcp.c#L980
At least if you trust the search-engine of github.
So it has to be in dhcp_arp_reply
https://github.com/espressif/esp-lwip/blob/3b88e84f9b05e76a1ad96e6650a795df74af23aa/src/core/ipv4/dhcp.c#L963
and if I understand the code correctly we do a check if the IP is already used in the network. If another device uses that IP it will respond to the ARP-request leading to LWIP to decline the ACKd IP.
The fun part is, that this is not an issue, as LWIP will not respond to an ARP request from itself, so no worries there. But if an AP/station/network-component answers on behalf of the client (which seems to be a feature called ARP-caching?) then the LWIP declines the IP because an ARP-Reply with the MAC of itself.
As far as I can tell it would be possible to do an MAC-address comparison (does not equal) on line https://github.com/espressif/esp-lwip/blob/3b88e84f9b05e76a1ad96e6650a795df74af23aa/src/core/ipv4/dhcp.c#L976 and the problem should be gone. But I might be wrong? If you want I can try to implement it and do a PR?

You should probably do the filtering in etharp_input


Licensing issues?

I wonder if there might be a licensing problem with extracting your reviews from sites whose terms of use make you surrender your copyrights. Is this the case with any of the sites supported?

None of the sites supported require a full transfer of copyright. Generally, the terms are similar to this (from Yelp):

you grant us an irrevocable, non-exclusive, royalty-free, perpetual, worldwide license to use, modify, prepare derivative works, publish, distribute and sublicense the Feedback, and you irrevocably waive, and cause to be waived, against Yelp and its users any claims and assertions of any moral rights contained in such Feedback.

You're basically opting into distributing your work under a Yelp-Only License, but if you yourself want to attach more permissive terms, you can certainly do so.
Beyond that, some might argue that use of the extension violates terms of use against scraping. I don't think it does, since it does not facilitate wholesale extraction of content, only downloading the user's own contributions. In any event, such violations are immaterial to the question of copyright.

Excellent news!


READ and WRITE subscriptions on the same fd

In mio, we can do this:
poll.registry().register(
    &mut connection,
    token,
    Interest::READABLE.add(Interest::WRITABLE),
)?;

It creates READ and WRITE subscriptions on the same fd.
And this does't work in wasmedge_wasi_socket.

I find it's a problem with WASI, so I am closing this.


Create computeds inside other computeds

Can I create computeds inside other computeds?

You can but you need to make sure it's scoped so that when the root computed re-runs it disposes of old computeds:
root((dispose) => {
  const foo = computed(() => {
    const bar = computed(() => /* ... */);
    // ...
  }, { scoped: true });

  // ...

  dispose();
);

So let's supose that in your example the foo computed runs once and returns a bar1, then it runs a seccond time and returns a bar2, the bar1 reactivity is still going to work?

This example isn't the best, if you can share what you're trying to do then I can help better.

I want to build some dynamic computation trees like this one:
import { signal, computed, root } from '@maverick-js/signals';

describe('tree sum', () => {
  test('simple sum', () => {
    root((dispose) => {
      const arr = [...Array(16)].map((_, v) => signal(v));
      const tree = fromArr(arr);
      expect(tree()).toBe(120);
      arr[0].set(10);
      expect(tree()).toBe(130);
      dispose();
    });
  });
});

type Fn = () => number;
function sumTreeFn(left?: Fn, right?: Fn) {
  return computed(() => {
    return (left?.() ?? 0) + (right?.() ?? 0);
  });
}

function fromArr(arr: Fn[]): Fn {
  if (arr.length <= 2) {
    return sumTreeFn(arr[0], arr[1]);
  }
  return sumTreeFn(
    fromArr(arr.slice(0, Math.floor(arr.length / 2))),
    fromArr(arr.slice(Math.floor(arr.length / 2)))
  );
}

Sorry for the late response @GDX64! The example you showcased will work as expected. There's a change in the latest release to scope all computed's by default to avoid mem leaks. After upgrading feel free to remove the { scoped: true } option.


feat: Package directory volumes when using OCI

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes

@nderjung is this still needed? I feel like there was no real push to have volumes in packages.
Should I close this?


Temporarily remove errorneous providers

There are currently some providers, which do not work with the client due to shortcomings of the provider's implementations not fulfilling the OPTIMADE specification according to the version they supply.
These should be temporarily removed from the list of available providers and include:

Crystallography Open Database
Theoretical COD
NOMAD

Closed by #220


Add PureRef 1.9.2

https://www.pureref.com/
PureRef is a freeware (no license restrictions) tool for artists to visualize and organize their reference images on a board.
You can add images through drag-and-drop and pasting.
I could not find any page that references the hashes for the executables so I'm leaving it to scoop to calculate them.
I tested this locally and it works fine.
If anything else is needed, please tell.

Q: I would like to use the portable version of PureRef on Windows but it gives an error on start up, why is that?
A: To run PureRef you need to have Visual C++ Redistributable for Visual Studio 2015, this is installed if you use the installer but not for the portable version. You can get it here.

Please add
    "suggest": {
        "vcredist": "extras/vcredist2015"
    }

Whoops, I just realised I messed up a few commits. Everything should be fixed in the last one.

    "bin": "PureRef.exe",
    "shortcuts": [
        [
            "PureRef.exe",
            "PureRef"
        ]
    ],
    "architecture": {
        "64bit": {
            "url": "https://www.pureref.com/files/portable.php?build=WIN64#/PureRef.exe",
            "hash": "deadb1491977dd02e4be49b0b049e1dfa5c90d09c485bdb96df63824d5c9b3bd"
        },
        "32bit": {
            "url": "https://www.pureref.com/files/portable.php?build=WIN32#/PureRef.exe",
            "hash": "09b26fe2f0dc7c0d336395838dc10b427656b3981319b86a13fa28855c0f43b0"
        }
    },
    "bin": "PureRef.exe",
    "shortcuts": [
        [
            "PureRef.exe",
            "PureRef"
        ]
    ],

?


charts,manifests: Update the metering package bundle to 4.4.

This is a partial update from 4.3 to 4.4 for the upstream package (which has the 4.4 tags) and the openshift package.yaml that ART uses to publish brew builds.

/lgtm

/lgtm


"Auto-more" menu issues

[ ] 1. in "Add new..." block it's very difficult to click on 3 dots, it's need to be bigger clickable area

[ ] 2. sometimes there is space in header, but still some menu items are still in more menu:

https://una.io/page/view-discussion?id=4896 - "Timeline Post" paragraph

Point №1 was fixed in ticket #2618 - point №3.


host location - for Symbiont-associated (SA) package

New term details
Term name - host location
Structured comment name -host_location
Definition - Location of the symbiotic organism within its host: e.g. intracellular if present within host cells or extracellular if present outside of host cells.
Expected value - enumeration
Value syntax - [intracellular|extracellular|not determined]
Example - extracellular
Packages(s) - symbiont-assiociated
Term ID - MIXS:0001313

Additional context
Term created as part of Symbiont associated package.

The name and definition are incongruent, I.e. the required value is not the location of the host, but the location within the host.
I suggest the name is changed to “location within host” (loc_in_host).
Term name = location within host
Structured comment name = loc_in_host

Additionally, do we need a second term (#178) for "host tissue location" when this term could easily cover both aspects?

We must keep a separate term for host-tissue-location. This one will be commonly used regardless of the type of symbiont.
I do not think that location_within_host would be a good name for the item aimaing at determining whether the organism is intracellular or extracellular... Yes, I guess we could be combine "host location" and "intracellular location" if you want to reduce the number of lines. Is this what you mean?
Term name - host location
Structured comment name -host_location
Definition - Location of the symbiotic organism within its host: e.g. intracellular if present within host cells or extracellular if present outside of host cells.
Expected value - enumeration
Value syntax - [extracellular|intracellular|intracellular_nucleus|intracellular_cytoplasm|intracellular_organella|not determined]
Example - extracellular
Packages(s) - symbiont-assiociated

I'm just thinking we dont want to proliferate very similar terms when we dont need to, so if location within host can be used for both tissue and intra/extracellular then we should.
With regards to the name "host location" to most people is going to mean physical location of the host, which I don't think is what is intended here(is it?), so the name probably needs to change. Is location the correct word? would site be better?

No I do not think they can be combined. This is one of the main point of need for this package!
What we really need is to identify the host species, tissue , cell type and then for intracellular organisms only, the cell compartment…
For both intracellular and extracellular organisms we need to indicate separately whether the organism is collected from the heart, gut or the liver etc.. similar symbiont can be collected from different tissues… they will likely differ because they live in different environments.
But whether the symbiont is intracellular or extracellular is not likely to change from one sample to another.
To give you some perspective, what you are proposing is the same as saying that we can say that an organism was collected from water, and host, or soil, in the same term as indicating that it is collected in a mountain, desert or from a deep sea hydrothermal vent!
I agree that location is not perfect. We started with tissue but it caused some issues for those working on organisms that infect the blood. If we consider a blood a tissue, we can change to tissue_site instead of location. What do you reckon?

These are sounding very similar to the triple-level environment terms we collect already as part of the core:
broad-scale environmental context
local environmental context
environmental medium

@ndheilly I agree with your need for this term as well as the tissue term.  How do you feel about “host cellular location” as a more specific label?

Host cellular location sounds good to me. agreed.

Did this term get subsumed into the newly suggested term "host of the symbiotic host environemental medium" [MIXS:0001326] #198 ?

symbiotic host cellular location
the cellular location of the symbiotic host in the host of the symbiotic host

Term name - location of the smaller symbiont in the larger symbiont
Structured comment name - symbiont_loc
Definition - Given a symbiotic relationship between a smaller and larger organism, this field captures the location of the smaller symbiont within the larger one: e.g. intracellular if present within larger symbiont's cells or extracellular if present outside of larger symbiont's cells.
Expected value - enumeration
Value syntax - [extracellular|intracellular|intracellular_nucleus|intracellular_cytoplasm|intracellular_organella|not determined]
Example - extracellular
Packages(s) - symbiont-assiociated

I don't, however, actually think this is needed. As @only1chunts suggested, this can be covered in the symbiont-specifice env_local

Again, to ensure that the host of the sampled is referenced to using exactly the same vocabulary throughout the package, the definition needs to be changed to:
Term name - cellular location
Structured comment name - symbiont_loc
Definition - This field captures the location of the symbiotic host organism within the host from which it was sampled: e.g. intracellular if the symbiotic host organism is localized within the cells or extracellular if the symbiotic host organism is localized outside of cells.
Expected value - enumeration
Value syntax - [extracellular|intracellular|intracellular_nucleus|intracellular_cytoplasm|intracellular_organella|not determined]
Example - extracellular
Packages(s) - symbiont-assiociated

Minor changes to the term name, structured comment name and definition.
Term name - symbiont cellular location
Structured comment name - symb_cell_loc
Definition - The location of the symbiotic host organism within the host from which it was sampled: e.g. intracellular if the symbiotic host organism is localized within the cells or extracellular if the symbiotic host organism is localized outside of cells.
Expected value - enumeration
Value syntax - [extracellular|intracellular|intracellular_nucleus|intracellular_cytoplasm|intracellular_organelle|not determined]
Example - extracellular
Packages(s) - symbiont-assiociated
TODO: Update spreadsheet

for consistency with the other terms we need to use the word host instead of symbiont in the name:
term name - host cellular location
structured comment name - host_cellular_loc

updated in  v6 spreadsheet, and added to log


Workload cluster deployment

Depends on 11

Deployed workload cluster volante using refactored 3-node bases

Details: patch aci network config, configurable encrypted pullsecret for installing OCP image, customize sealedsecret annotations

Manifest validation depends on 9

Updated blazer with new bases @natifridman take a look


Feature/sign-up button text not showing on hover

Please assign it to me under hacktoberfest label.

Great Idea,
All the Best.
After Contributing Make shure to Add your details in Contributing/README.md


Fixes #2432. Implements Dim.Auto for Content including subviews.

DimAutoStyle.Text is now complete and merged in #3416.
Fixes

Fixes #2432

Proposed Changes/Todos

[ ] Fully implement/test DimAutoStyle.Content
[ ] Implemement Dim.AutoSize (max: dim)
[ ] Use Dialog and MessageBox as test cases - This will require moving the dialog buttons to Padding as adornments.
[ ] Dive deep into all other PosDim objects and get clarity on behavior relative to Dim.Auto - Improve unit tests to validate

[x] Dim.Absolute
[ ] Dim.Auto
[ ] Dim.Fill
[ ] Dim.Function
[ ] Dim.Width/Height
[x] Pos.Absolute/At
[ ] Pos.AnchorEnd
[ ] Pos.Function
[ ] Pos.Anchor
[ ] Pos.Percent
[ ] Pos.Center
[ ] Pos.X/Y etc...

Abandoning this PR. I'll create a new Issue and PR to finalize DimAutoStyle.Content after #3480 is merged.


Work great on PC (fullHD) but it look pixelated in the mobile browser (fullHD+)

Your template work great on browser in pc. But when I open from mobile browser with fulldHD+ resolution it look very pixelated. This not happened on unity editor or build to android apk but only in webgl on mobile browser only.
Please help me to solve this. Thanks!

hey @greggman!
Just curious - do you intend to persist that change?
Because I just faced the same issue and your solution helped.

@Enigo, At the moment I don't intend to persist that change. You should just edit your local copy to do what's right for your app. There's no "one size fits all" solution here.


Escape quotes, single quotes and backslashes

Fixes #13
@vishysank Should I make this a settings option?

I am going to write some tests for these to make sure they work, and if so will merge.

Ok, great!
So should I add an option to disable it in the settings, what do you think?

I think if this works, it will be an improvement to functionality in general so I don't think it needs to be a setting. Will be writing some tests today and tomorrow.

@pdonias added some tests, looks like they pass 👍. However, I made a small adjustment, removed the need to escape double quotes since the identifier is always cased in single quotes, so double quotes should not cause a problem. checkout line 71 in lib/console-log.coffee. What are your thoughts on this ? If you are okay with this I shall go ahead and merge.

Looks good to me :)


Release new version and docs fixes

Coverage remained the same at 90.05% when pulling c37ebc8f41550950b42aa9447d667ea39d3491db on docs-fixes into 529a7de59a60a52758272ad4dd8e112f83d1c4d9 on master.


ENH: Add volspace and volcohort entities to IO config file

Closes none, but relates to #883, https://github.com/bids-standard/bids-specification/pull/1900, and https://github.com/nipreps/fmriprep/issues/3341.
Changes proposed:

Add volspace and volcohort entities to the IO config file.
Allow volspace, volcohort, and resolution in CIFTI filenames.

@effigies @mgxd would you mind taking a look at this at some point?

An alternative proposed by @effigies in https://github.com/bids-standard/bids-specification/pull/1900 involves using + in the space entity instead of a new entity, so that's a viable alternative.

I'm committing to just using +s, so I'm going to close this.


core: add support setting for MTU on macvlan interface from netavark config

Netavark config accepts MTU as network option so allow users to
configure the same for macvlan interface.
See https://github.com/containernetworking/plugins/blob/master/plugins/main/macvlan/macvlan.go#L181
Follow up PR to: https://github.com/containers/netavark/pull/111
Closes: https://github.com/containers/netavark/issues/152

@Luap99 @mheon @baude This should close MTU setup for macvlan.

LGTM but can you add a test?

Sure adding a test.

@Luap99 Merge me please newly added test verifies the change.

/lgtm


[stable backport] [CENNSO-120] Fix skipping classification in upf-gtpu[46]-input (no PFCP_CLASSIFY)

This is a backport of #313

wrong target branch, re-creating


Add Hari-sankar's file

created a branch, created a file and made a commit, and opened a pull request


[Integration] Jina + Haystack -> DeepSparse

[x] Add a sample Haystack Script
[x] Add a minimal integration of DeepSparse in Haystack Script
[x] Add a sample JinaAI Script
[x] Add a minimal integration of DeepSparse in JinaAI Script

Edit: Haystack implementation is not minimal, we could make DeepSparseReader inherit not from BaseReader but BaseComponent, which is even more of a fundamental object (the so-called "Node").
JinaAI integration:
⠴ 1/2 waiting deepsparse_executor to be ready...DeepSparse Engine, Copyright 2021-present / Neuralmagic, Inc. version: 0.12.0 (5f03c9f3) (release) (optimized) (system=avx2, binary=avx2)
⠴ 2/2 waiting  to be ready...
 🔗         Protocol                   GRPC
 🏠     Local access          <IP_ADDRESS>:52823
 🔒  Private network  <IP_ADDRESS>:52823
 🌐   Public address    <IP_ADDRESS>:52823
Input question: What's my name?, input context: My name is Mario!
Response: Mario (took 3.079167366027832s)

Haystack integration:
INFO - haystack.document_stores.base -  Numba not found, replacing njit() with no-op implementation. Enable it with 'pip install numba'.
INFO - haystack.modeling.model.optimization -  apex not found, won't use it. See https://nvidia.github.io/apex/
INFO - haystack.modeling.utils -  Using devices: CUDA:0, CUDA:1, CUDA:2, CUDA:3
INFO - haystack.modeling.utils -  Number of GPUs: 4
INFO - haystack.nodes.retriever.sparse -  Found 3 candidate paragraphs from 3 docs in DB
DeepSparse Engine, Copyright 2021-present / Neuralmagic, Inc. version: 0.12.0 (5f03c9f3) (release) (optimized) (system=avx2, binary=avx2)

Query: Who's brother is holding a sword?
Answers:
[{'answer': "Mario's"}]

@mgoin plan is to move to deepsparse once this is reprioritized


Add the data set name to the output name of the test

fixes #12

@ecrmnn @semproTestMaskin Is this repo still active?

@ventrec Awesome!


Update Instant Client doc to link to the new prebuilt containers

The Instant Client README and Dockerfile comments now contain links to the new prebuilt containers.

In future, remember to bring your fork up-to-date and rebase from main before branching so that we don't get already merged commits added to the PR.

Oh?  I had pulled from oracle/docker-images.git and pushed to my fork before I began.


Add release Dockerfiles

This approach scales better and provides a little more flexibility than the previous iteration (see #114).
We may wish to discuss default behaviors and how these options are specified.
I am also a little unsure about the use of environment variables in this way for the build-args, but it makes things a lot more flexible this way.
With all this in mind, leaving in draft again :)

I don't see a problem with using environment variables. My questions are:

Is the dockerfile environment variable safe from the user's environment (i.e. collisions)?
What is the alternative to using environment variables?
What default behavior are you referring to?

* Is the `dockerfile` environment variable safe from the user's environment (i.e. collisions)?

If the user has defined dockerfile or irods_package_version in their environment and uses the --use-static-image option, they will be ignored because the options set the environment variables before invoking up. This means that --use-static-image is basically a convenience for the user.
Having the environment variables set manually and using other options could lead to unexpected results. For instance, it may be possible to bypass using some options by setting the environment variables and this could allow for using incompatible parameters and triggering unexplored code paths.
I'm open to ideas about what this means and how much to protect the user from this, if at all.

* What is the alternative to using environment variables?

We could use the Compose python API to define a dockerfile and the build-args. This makes me uneasy as the Compose python API usage in this project is unsupported and never has been. According to the Compose maintainers, the python API has never been supported as such and enforced this by dropping it entirely in V2 (see https://github.com/irods/irods_testing_environment/issues/8#issuecomment-1021320731).
We could also define separate Compose projects for the release images on each platform, but that seemed even less palatable.
The environment variables were inspired by other Compose projects I've worked with (namely, ZMT).
I'm open to implementing these or any other ideas.

* What default behavior are you referring to?

I was mainly thinking about what our expectations are around what happens when some options are used and others are not.
For instance, as we discussed "offline" this morning, does it make sense to require --irods-package-version with --use-static-image or should we provide a strong default for --irods-package-version so that it's not required?
Or, should --use-static-image be the default in some cases (e.g. run_plugin_tests.py) and we provide a different option to download and install packages at runtime (e.g. --use-dynamic-image)?

I don't think we have to worry about the environment variables. Adding a few statements about those would be good. If we tell the reader that dockerfile and irods_package_version should not be defined in their testing environment, then I think we're covered.
As for the alternative (i.e. compose api), I agree that attempting to use that api is not in our best interest given it has been dropped in V2.
As for defaults, requiring users to pass --use-static-image feels correct. Developers are less likely to run the wrong version of iRODS that way. If a user provides the static image option, the package version should default to the latest release for that platform IMO. The idea that a user should opt into a static image also fits the purpose of this repo too.

Okay, so, I think the next steps include the following...

[ ] Add words to README regarding environment variables
[ ] Make --irods-package-version optional with --use-static-image by providing a strong default of "latest release"

I created #121 to address the bit about the default behavior of --irods-package-version. This is going to be more of a lift because even if you don't specify irods_package_version environment variable, a blank string will be used instead which is obviously not good.

This seems like it's in a good spot.
Anything left to do for this?

Everything else left to do has been captured in an issue, I believe. I think it's good to go, too


Display full text in Problems pane.

Allow text in problems to word wrap or display full text on hover.
See https://github.com/webhintio/hint/issues/3175

Version: 1.39.2 (user setup)
OS: Windows 10.0.18362

In the meantime workaround would be setting "workbench.list.horizontalScrolling": true, however it affects all list/tree components.

#83336


[New Port Request] OCILIB

Library name: OCILIB
Library description: OCILIB is an open source and cross platform Oracle Driver that delivers efficient access to Oracle databases.
Source repository URL: https://github.com/vrogier/ocilib
Project homepage: https://vrogier.github.io/ocilib/

Hi,
I did experiment with this privately a while ago. If anyone is interested, feel free to use this as a starting point:
CONTROL
Source: ocilib
Version: 4.2.0
Description: OCILIB (C and C++ Drivers for Oracle) - Open source C and C++ library for accessing Oracle databases

portfile.cmake
include(vcpkg_common_functions)

vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO vrogier/ocilib
    REF v4.2.0
    SHA512 64cf66a90854c2d8f39d92fb7b6e4c109a44d18dc1a450aa0e3cd592b933064be34c34180f325b5d955bb2e15b622129db7ca229cb80300e64722b78c0453033
    HEAD_REF master
)

if (VCPKG_TARGET_ARCHITECTURE MATCHES "x86")
    set(MSBUILD_PLATFORM "Win32")
    set(SOURCE_BINARY_PATH ${SOURCE_PATH}/lib32)
elseif (VCPKG_TARGET_ARCHITECTURE MATCHES "x64")
    set(MSBUILD_PLATFORM "Win64")
    set(SOURCE_BINARY_PATH ${SOURCE_PATH}/lib64)
else()
    message(FATAL_ERROR "Unsupported architecture: ${VCPKG_TARGET_ARCHITECTURE}")
endif()

if (VCPKG_PLATFORM_TOOLSET MATCHES "v140")
    set(TARGET_SOLUTION_FILE ocilib_dll_vs2013.sln)
elseif (VCPKG_PLATFORM_TOOLSET MATCHES "v141")
    set(TARGET_SOLUTION_FILE ocilib_dll_vs2013.sln)
else()
    message(FATAL_ERROR "Unsupported platform toolset: ${VCPKG_PLATFORM_TOOLSET}")
endif()

vcpkg_build_msbuild(
    PROJECT_PATH ${SOURCE_PATH}/proj/dll/${TARGET_SOLUTION_FILE}
    RELEASE_CONFIGURATION "Release - ANSI"
    DEBUG_CONFIGURATION "Release - ANSI"
    PLATFORM ${MSBUILD_PLATFORM}
    PLATFORM_TOOLSET ${VCPKG_PLATFORM_TOOLSET}
)

file(COPY ${SOURCE_PATH}/include/ DESTINATION ${CURRENT_PACKAGES_DIR}/include/ocilib/)

file(COPY ${SOURCE_BINARY_PATH}/ociliba.dll DESTINATION ${CURRENT_PACKAGES_DIR}/debug/bin)
file(COPY ${SOURCE_BINARY_PATH}/ociliba.lib DESTINATION ${CURRENT_PACKAGES_DIR}/debug/lib)
file(COPY ${SOURCE_BINARY_PATH}/ociliba.dll DESTINATION ${CURRENT_PACKAGES_DIR}/bin)
file(COPY ${SOURCE_BINARY_PATH}/ociliba.lib DESTINATION ${CURRENT_PACKAGES_DIR}/lib)

# Handle copyright
file(COPY ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/ocilib)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/ocilib/COPYING ${CURRENT_PACKAGES_DIR}/share/ocilib/copyright)

vcpkg_copy_pdbs()

You might want to change VCPKG_PLATFORM_TOOLSET and TARGET_SOLUTION_FILE as newer Visual Studio solutions have been added after ocilib_dll_vs2013.sln

Hey, I'm installing this package using vcpkg. But not able to link to the CMake target. when I call find_package(ocilib CONFIG REQUIRED) it says,
Could not find a package configuration file provided by "ocilib" with any
  of the following names:

    ocilibConfig.cmake
    ocilib-config.cmake

  Add the installation prefix of "ocilib" to CMAKE_PREFIX_PATH or set
  "ocilib_DIR" to a directory containing one of the above files.  If "ocilib"
  provides a separate development package or SDK, be sure it has been
  installed.

anyone can give me the code that I can put into my cmake file to start consuming this library?
thanks.


Negative snark-work-fees appear in a fews places

Setting negative snark fees in via GraphQL is possible and you can see that in coda client status. It looks like internally this is a uint64 so I think this is just a representation issue, but we should dig into it.

Fixed in #8532.


Added feature list

I suggest taking off “provisioning of” on the bullets that have it. I think the last three bullets are not really features, at least in the way that I think should go on this list.


Bring new "dynamic settings" capability into KnowledgeVis repository

Bring in the improvements to add dynamic settings via Pull Request into this repository

Thanks, Dave. I look forward to looking at these changes and testing out
the annotation system.
On Wed, Apr 26, 2023 at 12:00 PM Dave Mackey @.***>
wrote:

We've now merged two PRs into miqa-annotate:
#9 https://github.com/knowledgevis/miqa-annotate/pull/9
#10 https://github.com/knowledgevis/miqa-annotate/pull/10
There is a third awaiting review:
#12 https://github.com/knowledgevis/miqa-annotate/pull/12
I feel pretty good about this one as most of the changes are comparatively
minor.
Once that has been merged I have one more set of code changes to import
and then I believe dynamic settings will be fully integrated into
miqa-annotate. The code changes have already been made and can be seen in
the dynamic-settings branch:
https://github.com/davidshq/miqa/tree/dynamic-settings
—
Reply to this email directly, view it on GitHub
https://github.com/knowledgevis/miqa-annotate/issues/4#issuecomment-1523669102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQNT5Q5KYZ4KBK6L626URDXDFBC3ANCNFSM6AAAAAAWNYLJRE
.
You are receiving this because you authored the thread.Message ID:
@.***>

The last of the annotation system edits are in https://github.com/knowledgevis/miqa-annotate/pull/15
This PR is good to go except there is a problem with the CI, for some reason it can't find ITK. Once this has been resolved it can be merged.


Drag markdown preview to New Window

VSCode Version: 1.15.1, 64 bit
OS Version: Windows 10 64 bit

Steps to Reproduce:

Open markdown file, click the preview button
File/New Window
Try and drag just the preview part to the new window

It would be really nice if I could drag the markdown preview to a new window so I can edit the markdown on one monitor and see the preview result on another monitor.

Also anything that uses the vscode.previewHtml command.
Right now the only options are to open on a side-panel or as a new tab that, as pointed out by @lovettchris, cannot be manually dragged to a new window.

This issue is related with #10121 which has many upvotes.

Hi @lovettchris also use two monitors to edit Markdown files with VSCode, as workaround I expand the window across all monitors like this:

This way I can edit my markdown files in one monitor and see rendered changes in the other :sweat_smile:

A workaround for me now it's use Markdown Viewer. Autoreload is include.

Another workaround:
use VSCode in the Cloud with code-server and let the browser take care of dragging the tabs around!


[RN] Remove bold text

Tested areas:

iOS 11.4.1 (iPhone 6s)
Android 10 (Honor 20)

Description
Remove bold text from the mobile application.

fixed

@tr3v3r After using bold in the Radzima admin (there is no bold button in the editor but admin can use hotkeys "Cntrl+B"), the selected text is no longer displayed in the mobile app. The bug is reproducible on both Android and iOS.

Fixed. BTW there is no way to add bold text using Radzima Admin

verified - closed.


[Bug]: Typescript - info() is not a function

🔎 Search Terms
typescript,info,logger
The problem
README.md is clear that the following syntax is legal:
logger.info('Hello world')
However I cannot get this to work with Typescript.
Versions:
Winston version:  3.10.0
Node version: v20.5.1
Example:
Using "esModuleInterop": true in tsconfig.json to allow the use of Winston using import syntax:
import { Logger, transports, format } from 'winston'
const logger = new Logger({
  level: 'debug',
  transports: [new transports.Console()],
  format: format.combine(format.splat(), format.colorize({ all: true }), format.simple())
})

logger.info('Hello world')

export default logger

Expected:
Console output of: Hello world
Actual:
logger_1.default.info is not a function
What version of Winston presents the issue?
3.10.0
What version of Node are you using?
20.5.1
If this worked in a previous version of Winston, which was it?
No response
Minimum Working Example
Using "esModuleInterop": true in tsconfig.json to allow the use of Winston using import syntax:
import { Logger, transports, format } from 'winston'
const logger = new Logger({
  level: 'debug',
  transports: [new transports.Console()],
  format: format.combine(format.splat(), format.colorize({ all: true }), format.simple())
})

logger.info('Hello world')

export default logger

Additional information
No response

Possible duplicate of https://github.com/winstonjs/winston/issues/2280


Suggestion for customizing Foundation breakpoints...

Found this page:
https://zurb.com/university/lessons/change-foundation-s-default-breakpoints
But didn't like the fact that I would have to edit Foundation files directly to affect these changes.  Did some searching and found the "global-variable-exists" function in Sass >= v3.3.
Changing the file _settings.scss (lines 154 to 157 in Foundation v5.5.3 from bower install) from:
// $small-breakpoint:  em-calc(640);
// $medium-breakpoint: em-calc(1024);
// $large-breakpoint:  em-calc(1440);
// $xlarge-breakpoint: em-calc(1920);
to this:
// @if(not global-variable-exists($small-breakpoint)) $small-breakpoint:  em-calc(640);
// @if(not global-variable-exists($medium-breakpoint)) $medium-breakpoint: em-calc(1024);
// @if(not global-variable-exists($large-breakpoint)) $large-breakpoint:  em-calc(1440);
// @if(not global-variable-exists($xlarge-breakpoint)) $xlarge-breakpoint: em-calc(1920);
allows me to make the following custom foundation scss file with a custom breakpoint:
@charset "utf-8";
@import '/bower_components/foundation/scss/foundation/functions';
$medium-breakpoint: em-calc(1200);
@import '/bower_components/foundation/scss/foundation/components/grid';
@import '/bower_components/foundation/scss/foundation/components/block-grid';
Everything seems to work fine with or without the custom breakpoint defined, but I'm not very deeply versed in Foundation's functionality, so I could very well be missing something big.  Kinda new to the whole Foundation scene, but it's pretty freaking cool.
Anyhow, I thought I'd make this suggestion for a change to the core Foundation files as it seems to allow for a "better" (non-invasive to core files) way to customize breakpoints.
Thanks, all.  Keep up the good work.  Looking forward to getting into Foundation 6.

In Foundation 6 we made changing breakpoints a lot easier. It's just a Sass map, which means you can add, edit, or rename any breakpoint:
$breakpoints: (
  small: 0,
  medium: 640px,
  large: 1024px,
  xlarge: 1200px,
  xxlarge: 1440px,
);

Sweet.  Thanks for the info.


docker: some versions of docker reject requests for buildkit with error if it's not supported :sob:

Hello @maiamcc,
Please review the following commits I made in branch nicks/ch1104/minikube:
e19ed6c02a570b45d3af177bb7cbc9f8c6a189ed (2018-12-12 11:09:58 -0500)
docker: some versions of docker reject requests for buildkit with error if it's not supported :sob:

going to merge this and cut a release, so we don't have a version that doesn't work with the latest minikube


Roborock Vacuum S50 responds randomly

Hi,
I have a Roborock S50 and miio commands work in a randomly way. Sometimes they work and other times they don't. Seems that the vacuum stops responding for some reason (firmware 3.3.9_001633). Any help with this, please?
Working command:
user@linux ~ $ DEBUG=thing* miio inspect <IP_ADDRESS>
INFO  Attempting to inspect <IP_ADDRESS>
thing:miio:pending <- Handshake reply:  +0ms
thing:miio:96657237 Identifier of device updated +0ms
thing:miio:96657237 Loading token from storage, device hides token and no token set via options +6ms
thing:miio:96657237 Using manual token:  +16ms
thing:miio:96657237 -> (5) {"method":"miIO.info","params":[],"id":1} +6ms
thing:miio:96657237 <- Message: {"partner_id":"","id":1,"code":0,"message":"ok","result":{"hw_ver":"Linux","fw_ver":"3.3.9_001633","ap":{"ssid":"Pitufos","bssid":"F8:1A:67:5A:6C:0C","rssi":-48},"netif":{"localIp":"<IP_ADDRESS>","mask":"<IP_ADDRESS>","gw":"<IP_ADDRESS>"},"model":"roborock.vacuum.s5","mac":"","token":"","life":22053}} +10ms
thing:miio:96657237 -> (5) {"method":"get_status","params":[],"id":2} +33ms
thing:miio:96657237 -> (5) {"method":"get_consumable","params":[],"id":3} +2ms
thing:miio:96657237 <- Message: {"result":[{"msg_ver":2,"msg_seq":69,"state":5,"battery":92,"clean_time":1090,"clean_area":18475000,"error_code":0,"map_present":1,"in_cleaning":1,"in_returning":0,"in_fresh_state":0,"lab_status":1,"fan_power":60,"dnd_enabled":0}],"id":2} +5ms
thing:miio:96657237 <- Message: {"result":[{"main_brush_work_time":145508,"side_brush_work_time":145508,"filter_work_time":145508,"sensor_dirty_time":36653}],"id":3} +2ms
thing:miio:96657237 Property state changed from undefined to cleaning +0ms
thing:miio:96657237 Property batteryLevel changed from undefined to 92 +4ms
thing:miio:96657237 Property cleanTime changed from undefined to 1090 +2ms
thing:miio:96657237 Property cleanArea changed from undefined to 18.475 +1ms
thing:miio:96657237 Property fanSpeed changed from undefined to 60 +1ms
thing:miio:96657237 Property in_cleaning changed from undefined to 1 +0ms
thing:miio:96657237 Property mainBrushWorkTime changed from undefined to 145508 +1ms
thing:miio:96657237 Property sideBrushWorkTime changed from undefined to 145508 +0ms
thing:miio:96657237 -> (5) {"method":"miIO.info","params":[],"id":4} +18ms
thing:miio:96657237 <- Message: {"partner_id":"","id":4,"code":0,"message":"ok","result":{"hw_ver":"Linux","fw_ver":"3.3.9_001633","ap":{"ssid":"Pitufos","bssid":"F8:1A:67:5A:6C:0C","rssi":-48},"netif":{"localIp":"<IP_ADDRESS>","mask":"<IP_ADDRESS>","gw":"<IP_ADDRESS>"},"model":"roborock.vacuum.s5","mac":"","token":"","life":22053}} +4ms
Device ID: 96657237
Model info: roborock.vacuum.s5
Address: <IP_ADDRESS>
Token:  via stored token
Support: At least basic
Type info: miio:vacuum, miio, vaccuum
Capabilities: adjustable-fan-speed, fan-speed, spot-cleaning, autonomous-cleaning, cleaning-state, error-state, charging-state, battery-level, state
Firmware version: 3.3.9_001633
Hardware version: Linux
WiFi: Pitufos (F8:1A:67:5A:6C:0C) RSSI: -48
Remote access (Mi Home App): Maybe
Properties:

state: cleaning
batteryLevel: 92
cleanTime: 1090
cleanArea: 18.475
fanSpeed: 60
in_cleaning: 1
mainBrushWorkTime: 145508
sideBrushWorkTime: 145508

Same command, minutes later, not working:
user@linux ~ $ DEBUG=thing* miio inspect <IP_ADDRESS>
INFO  Attempting to inspect <IP_ADDRESS>
thing:miio:pending <- Handshake reply:  +0ms
thing:miio:96657237 Identifier of device updated +0ms
thing:miio:96657237 Loading token from storage, device hides token and no token set via options +6ms
thing:miio:96657237 Using manual token:  +15ms
thing:miio:96657237 -> (5) {"method":"miIO.info","params":[],"id":1} +7ms
thing:miio:96657237 -> (4) {"method":"miIO.info","params":[],"id":101} +2s
thing:miio:96657237 -> (3) {"method":"miIO.info","params":[],"id":201} +2s
WARNING  Could not find device
Thanks!
UPDATE: It's strange that if I run the 'miio discover' command before the inspect or control command, everything seems to work fine...

Same problem here, Roborock S50 randomly respond to commands, and running miio discover don't fix it on my side, I wait and it work again for few seconds/minutes


Validate nullable flag on StructArray fields

Describe the bug
Extracted from a discussion on the equals kernels
It is currently very easy to get inconsistant state between the nullable flag on StructArray fields and the presence of their validity bitmap.  This can lead to very difficult to debug issues, as for example the equality comparison of StructArray includes this flag, but it is not printed by the Debug impl, for example in assertions.
To Reproduce
Example of a confusing test:
    #[test]
    fn compare_nullable_struct_array_fields() {
        let array1 = StructArray::try_from(vec![(
            "a",
            Arc::new(Int32Array::from(vec![1, 2, 3])) as ArrayRef,
        )])
        .unwrap();
        let array2 = StructArray::try_from(vec![(
            "a",
            Arc::new(Int32Array::from(vec![Some(1), Some(2), Some(3)])) as ArrayRef,
        )])
        .unwrap();
        // assert_eq!(array1.data_type(), array2.data_type());
        assert_eq!(&array1, &array2);
    }

panicked at 'assertion failed: `(left == right)`
  left: `StructArray
[
-- child 0: "a" (Int32)
PrimitiveArray<Int32>
[
  1,
  2,
  3,
]
]`,
 right: `StructArray
[
-- child 0: "a" (Int32)
PrimitiveArray<Int32>
[
  1,
  2,
  3,
]
]`'

Expected behavior

if a field is not nullable it should not have a validity bitmap
a StructArray itself should only have a validity bitmap if all its fields are nullable
maybe StructArray::from(Vec<(&str, ArrayRef>) should always set the nullable flag?

A clear and concise description of what you expected to happen.
Additional context
Alternatives could be to ignore the nullable flag when comparing arrays

Closed by https://github.com/apache/arrow-rs/pull/3244


Allow programmed fetchImageAndRun instead of requiring specific URL seach parameter

Was I too quick in merging your other PR? 😅
While you're still working on it you can make a "draft": https://github.blog/2019-02-14-introducing-draft-pull-requests/

Vanessa, no sorry. Is separate PR, but I handled it a bit awkwardly. This one is finished. Does allow to programmatically start with an image (instead of having to supply one from the URL).


typedef std::map<uint256, CCoins> to CCoinsMap

This makes it possible to switch to a more efficient map type
without changing all occurences manually.
Merges half of #4413.

ACK

tested & works for me.


When someone joins, DM anyone who requested them via DM

#966 added the ability for people to DM a Bridgy Fed account and request that someone join the bridge. When that person joins, we should DM the original requester to notify them.
Thanks for the nudge @mackuba!

I may scope this down to just the original requester, or limit to the first N requesters, etc.

First N would be fine I think, but please let people know in the initial response to their request if the requestee isn't being messaged again and also if they won't receive a notification.


removed casperjs dev dependency

Version on Rubygems is 1.0, not compatible with Phantom 2.1.1. Rubygems version should ideally be latest: 1.1.3. Rely on Wraith maintainer to have correct CasperJS installed instead.
Travis appears to run Phantom1.9.8 so tests pass with Casper 1.0. Should look at upgrading Travis to latest Phantom/Casper combo.

To help folks find this via Google:
If you've run bundle install and are getting errors like the following, it may be due to the issue in this PR.
To fix, try gem uninstall casperjs.
  phantomjs://code/bootstrap.js:227 in loadCasper

Couldn't find nor compute phantom.casperPath, exiting.


New option: ensure parent reference in selectors for preprocessors

As we now have basic preprocessors support, we could start adding preprocessor-oriented options like this :)
All preprocessors allow us to omit the parent reference (&) at selectors. Some people like that, while some — don't.
It would nice to have an option to control this, so when there would be something like that:
.foo {
  width: 10px;

  .bar {
    height: 10px;
  }
}

You could change it to this:
.foo {
  width: 10px;

  & .bar {
    height: 10px;
  }
}

and vice versa.
The possible names for this option could be mandatory-parent-reference, ensure-parent-referece or something like that.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1519060-new-option-ensure-parent-reference-in-selectors-for-preprocessors?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github).

Closing the issue as a wontfix.


v3.1.0

Status
READY
Breaking Changes
NO
Description

Update Hydrated Bloc to persist initialState upon initialization.
Update to latest effective_dart.
Add synchronous to prevent file corruption
Refactor HydratedBlocStorage.getInstance to avoid using a singleton
Upgrade to path_provider: ^1.6.5 for MacOS support
Invoke onError and continue emitting states when exceptions occur

Todos

[X] Tests
[X] Documentation
[X] Examples

Impact to Remaining Code Base

Non-Breaking changes which will be included in v3.1.0

@orsenkucher, @jorgecoca can you please take a look?

It is also known as synchronized in the mass market @felangel

What do you mean?

Won't it call delegate.onError second time? Considering bloc: 4.0.0-dev.3 changes @felangel

Yes but I’m planning on removing them when we upgrade to 4.0.0-dev.3. This is just an intermediate step.

And I highly suggest putting some kind of error exposition
like this
@override
void onError(Bloc bloc, Object error, StackTrace stacktrace) {
  super.onError(bloc, error, stacktrace);
  assert(
    false,
    'Your $bloc has some problems with `toJson`ification, '
    'hence you have a problem too🥳',
  );
}

I think this is a larger issue and I would like to address it at the bloc level rather than handle it specifically in hydrated bloc.

It is also known as synchronized in the mass market @felangel

What do you mean?

Package is just called differently))

I think this is a larger issue and I would like to address it at the bloc level rather than handle it specifically in hydrated bloc.

This is pleasant to hear! It is quite hard to detect problems now

It is also known as synchronized in the mass market @felangel

What do you mean?

Package is just called differently))

If you're referring to the meta commit that was independent of synchronized and we had to explicitly add meta as a dependency.


build: fix conditional install_requires

Fix conditional install_requires in setup.py to use environment markers instead of inline conditions.  The latter do not work correctly with universal wheels -- e.g. a wheel made on Python 3.12 would not have a dependency on typing-extensions at all, even if it were installed on Python 3.11 or older, and the other way around.

Thanks!


Implements more temporal kernels using time_fraction_dyn

Which issue does this PR close?

Closes #3108.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Thanks @tustvold


Unreal Engine 5.3.1

Hello, will RefreshAllNodes version 5.3 work on Unreal Engine 5.3.1 (just released)?  I did not want to chance it.  If not just letting you know there was an update.  Thank you and amazing plugin.

I haven't tested RefreshAllNodes with UE 5.3.1 yet, but it shouldn't make a difference. The last time I actually changed the plugin's code was for UE 5.1, almost a year ago when some big Unreal Editor API changes made it so it wouldn't compile.
I have been releasing builds for each new UE version- I do that just for users who don't have C++ compilation set up with UE. If you can compile it yourself then go for it.
There's no harm in trying RefreshAllNodes on UE 5.3.1; 90% chance the plugin code will still compile. But there's no chance it'll malfunction and break your project.
I can release a compiled build soon in case it's needed.
And thank you, I'm glad it's been helpful!


Beast and attack types affect damage taken

Would require the addition of a system too complex and time-consuming to consider at this point.


Attempt to add Abstractions

@jmprieur any luck with the changes to the path to the samples?

@localden: I was just waiting for you to approve the PR

@jmprieur just checking - were the sample paths updated in the source repo, so they don't conflict with other existing samples?

@localden this is what I've been trying to do:
https://github.com/AzureAD/microsoft-identity-abstractions-for-dotnet/compare/jmprieur/referenceDoc?expand=1
so far there was no sample in abstractions, but I would like to add them

Closing as it was done in https://github.com/MicrosoftDocs/microsoft-authentication-library-dotnet/pull/110/files


Generate tabs from markdown files

Proposed Changes
Added some logic that generates tab navigation from markdown files name in the "Components" section of the demo.
Usage
To enable tab navigation for a component you need to add a markdown file somewhere named according to the following pattern: <ComponentName>Examples.<order>.<tabName>.md.
Say I want to add tabs Salmon and Tuna to section Fish, I would need to following files:

FishExamples.tsx
FishExamples.1.salmon.md
FishExamples.2.tuna.md

To obtain

PS: the default first tab name is 'Develop'.
Potential Breaking Changes
None, it only affects the demo.
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1249 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   99.49%   99.51%   +0.01%
==========================================
  Files         356      356
  Lines        8970     8983      +13
  Branches     2128     2133       +5
==========================================
+ Hits         8925     8939      +14
+ Misses         45       44       -1

Impacted Files
Coverage Δ

...ackages/react-vapor/src/components/input/Input.tsx
96.34% <0%> (+2.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173d9c2...ff8439f. Read the comment docs.


fix(datepicker): fixed formControl binding to the datepicker-input di…

…rective to consume momentjs objects and render the value if it is set. (#13264)

I signed it!

You can get it to consume Moment objects by using the MomentDateAdapter. We can't merge this as it adds moment.js as a dependency of Angular Material