daemon.json documentation sample is not valid on Windows

The list of allowed configuration options in this document is not applicable to Windows. Several of the options do not work on Windows. I think this requires minor clarification, perhaps a sample that is applicable to Windows:
When used as is, the following is returned:
PS C:\> dockerd
time="2016-05-12T15:40:59-07:00" level=fatal msg="unable to configure the Docker daemon with file C:\\ProgramData\\docker\\config\\daemon.json: the following directives don't match any configuration option: iptables, bip, icc, api-cors-headers, exec-root, default-gateway-v6, ipv6, cgroup-parent, ip-mask, ip, userland-proxy, default-gateway, ip-forward, selinux-enabled, userns-remap, fixed-cidr-v6\n"

Here is a working sample:
{
    "authorization-plugins": [],
    "dns": [],
    "dns-opts": [],
    "dns-search": [],
    "exec-opts": [],
    "storage-driver": "",
    "storage-opts": [],
    "labels": [],
    "log-driver": "",
    "mtu": 0,
    "pidfile": "",
    "graph": "",
    "cluster-store": "",
    "cluster-advertise": "",
    "debug": true,
    "hosts": ["tcp://<IP_ADDRESS>:2376", "npipe://"],
    "log-level": "",
    "tlsverify": true,
    "tlscacert": "C:\\ProgramData\\docker\\certs.d\\ca.pem",
    "tlscert": "C:\\ProgramData\\docker\\certs.d\\server-cert.pem",
    "tlskey": "C:\\ProgramData\\docker\\certs.d\\server-key.pem",
    "group": "",
    "default-ulimits": {},
    "bridge": "",
    "fixed-cidr": "",
    "raw-logs": false,
    "registry-mirrors": [],
    "insecure-registries": [],
    "disable-legacy-registry": false
}

If this makes sense, and is in line with the docs scope / purpose, I am happy write up and propose the changes.
neilp

I think it would make sense to have an example for Windows as well (is there a way to SIGHUP the daemon?).
There's still much work to do in that area, because the same applies to the flags (we don't mention which ones are supported on Windows, and which not)

Thanks Sebastiaan - I can help with the Windows specific documentation. For future clarification, should I open an issue each time I find a place for doc contribution? Looking at the workflow here, this appears to be the case.
neilp

You can just open a  pull request directly if you like, so long as you explain the problem you are trying to resolve, without opening an issue as well.

@neilpeterson great!
Perhaps we should schedule a meeting someday (when I'm visiting SF) to discuss how we're going to document the Windows/Linux differences. Currently, the Windows daemon is still "beta", and follows a release schedule separate from the Linux releases, which complicates things w.r.t documentation. However, once Windows Server 2016 is release (I assume) the same release schedule will be used, and we should account for that in the documentation.
The tooling and "theme" we use for the documentation is a bit restricted in this area. Ideally we'd have something similar to the .Net docs, where (code) samples can be viewed in different languages;

I'm not sure if that's possible somehow (so just a thought)
ping @patrickqnguyen @SvenDowideit

@thaJeztah - yep happy to talk. Also, totally get it, there is a bunch of info in the Docker docs, we will need to figure out logistics so as not to add cruft / sloppy patches.
I've spoken a bit with @moxiegirl and @friism around the need to weave in some Windows specific items. Adding both here for awareness and contribution.
As for the specific issue (daemon.json), it is likely that this file will be the recommended daemon configuration option on Windows. Ill propose a subtle change to the current doc to note that not all directives are applicable to Windows, and provide some Windows specific guidance.

#dibs

Sounds good, thanks for contributing!


Use identical RNG state across RANSAC runs when matlab_strict enabled

PR Description
Closes #74 (at least as far as MATLAB equivalence is concerned). This PR modifies NoisyChannels to always use a copy of the random state object during RANSAC when matlab_strict is True. This results in the random state being identical for each run of NoisyChannels.find_bad_by_ransac, matching MATLAB PREP.
Also I realize I forgot to update the whats_new.rst for the last PR, so I did that here as well!
Merge Checklist

[ ] the PR has been reviewed and all comments are resolved
[ ] all CI checks pass
[ ] (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
[ ] (if applicable): bug fixes, new features, or API changes are documented in whats_new.rst

Codecov Report

Merging #89 (590214e) into master (b0c62ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 590214e differs from pull request most recent head b589742. Consider uploading reports for the commit b589742 to get more accurate results

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   98.51%   98.51%
=======================================
  Files           7        7
  Lines         673      675    +2
=======================================
+ Hits          663      665    +2
  Misses         10       10

Impacted Files
Coverage Δ

pyprep/utils.py
100.00% <ø> (ø)

pyprep/find_noisy_channels.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c62ad...b589742. Read the comment docs.

Nope: since the channel interpolation method still differs, the re-referencing process still ends up diverging numerically from MatPREP. This just makes it possible to add MatPREP comparisons for that.

okay :) then in it goes :rocket: thanks @a-hurst


Cleanup UPNP and NAT PMP requests on exit

When exiting, we should cleanup our UPNP and NAT PMP port bindings since the amount we can open is limited on some routers

Done via feature/bridger branch that has been merged


Define percent strong

(Stubs for now, so we can add this documentation to code later)
Percent strong is reported in two ways. We should distinguish between these ways of reporting (they are similar but not the same)

The fraction of replicate pairs that are more similar to each other than 95% of non-replicate pairs.
The fraction of replicate sets that are more coherent than 95% of non-replicate sets of the same size. The coherence of a set is defined as the median correlation among elements of the set.

The second version can be a bit confusing so here is an example:

Consider an experiment that has 100 perturbations, performed in 5 replicates
For each perturbation, we compute the pairwise correlation among its 5 replicates (the replicate set), and report the median value. This median replicate correlation value is the coherence of the perturbation's replicates.
We now compute the coherence of non-replicate sets of the same size. So we sample 5 random wells in the experiment such that no two are replicates of the same perturbation. We compute the pairwise correlation among the 5 wells (the non-replicate set), and report the median value. We do this several times to build a null distribution
We now report the fraction of perturbations that have a coherence greater than 95th percentile of the null. This is the percent strong.

@niranjchandrasekaran - at checkin today I think I may have answered your question about "percent strong" incorrectly. We are not calculating medians in percent_strong.py - all we do currently is determine the percentage of "group_replicates" that are higher than a quantile (95% default) of "not group_replicates".

@gwaygenomics, does that mean the current implementation of percent_strong computes the first type of percent_strong in https://github.com/cytomining/cytominer-eval/issues/21#issue-739130751 and not the second type?

@gwaygenomics, does that mean the current implementation of percent_strong computes the first type of percent_strong in #21 (comment) and not the second type?

I think that is correct.
The good news is that it should require relatively little extra code to implement the second time, given that this matrix is being computed
https://github.com/cytomining/cytominer-eval/blob/6f9d350badd0a18b6c1a76171813aaf9a52f8d9f/cytominer_eval/operations/percent_strong.py#L35-L37

note: we've also renamed percent_strong to percent_matching

note: we've also renamed percent_strong to percent_matching

Potentially useful resource: https://github.com/shntnu/grit-benchmark/blob/rtests/1.calculate-metrics/cell-health/taxonomy.md

I'll copy here text by @gwaygenomics from the paper https://github.com/broadinstitute/lincs-profiling-complementarity because it's the clearest description of the method I've come across!

Constructing an appropriate null distribution to calculate reproducibility metrics
In order to calculate percent replicating and percent matching metrics, we constructed matched null distributions. We designed the null distributions to control for different replicate counts between different compounds and MOAs, taking into account different replicate counts per assay. We also constructed different null distributions within each treatment dose independently to account to control for dose differences.
Specifically, for percent replicating, for a given perturbation x with n replicates of dose p, we randomly sampled n non-replicate profiles from all 1,327 common perturbations treated with dose p. We performed this sampling procedure 1,000 times per replicate cardinalityclass (e.g. compounds with 3 replicates, 4 replicates, 5 replicates, etc.) with two additional restrictions: (1) the random sample did not include replicates for perturbation x, and (2) no two compounds of the same non-x perturbation were included in the same null group. For example, in cases where a compound treatment at a specific dose had five replicates, we sampled 1,000 groups of five randomly sampled non-replicate profiles of the same dose. For percent replicating, we used level 4 profiles considering compound and dose information as replicates. We considered a replicating profile one in which the ground truth median pairwise replicate correlation was higher than 95% of the null distribution. We therefore calculate the percent replicating metric as the total number of replicating profiles over all common compounds.
For percent matching, we performed a similar procedure. The only differences were that we (1) used level 5 consensus signatures and (2) considered MOA and dose information as replicates. We subsequently constructed dose and MOA replicate count-specific null distributions to compare against. We considered a matched MOA one in which the ground truth MOA median pairwise correlation was higher than 95% of the null distribution. We therefore calculate the percent matching metric as the total number of matched MOAs over all common MOAs.
We used these null distributions to calculate a non-parametric p value. First, for each compound, we calculated its median pairwise replicate correlation. We next calculated the median pairwise correlations of each randomly sampled group matched to the specific dose and replicate count. Lastly, we calculated a compound specific p value by dividing how many times the real median pairwise correlation of replicates was higher than all 1,000 randomly sampled groups of median pairwise correlations.


Only fetch lfs files for specific git_ref

We should follow this PR in conda-build: https://github.com/conda/conda-build/pull/5202

I also don't think we should call git lfs install.


Refresh kubeadm docs for Windows

Updates Windows kubeadm documentation:

aligns with the documentation policy as specified in https://kubernetes.io/blog/2020/05/third-party-dual-sourced-content/ removing flannel specific details.
Make note for users in the standard join documentation. Running kubeadm join from windows doesn't require additional work beyond specifying the correct cri-socket parameter.
updates the upgrade documentation

This is a follow up from the feedback recieved in https://github.com/kubernetes/website/pull/32862#issuecomment-1113539366

/sig windows
/cc @marosset

/lgtm

/assign @onlydole
/hold cancel

/assign @sftim

/lgtm cancel
mostly for the query about “default path”, which doesn't seem like something we should merge as-is

I've updated the docs based on the feedback. Thanks!

/lgtm

@jsturtevant could you add the redirect that I mentioned in https://github.com/kubernetes/website/pull/33324#pullrequestreview-996544740 ?
The file to change is static/_redirects.
/lgtm cancel
(until that redirect is in place)

@sftim sorry about missing that, updated.  There were a few other redirects on that file, I left them in place but let me know if they should be consolidated in someway.

/lgtm


Do not truncate whitespace for multi-line string

Resolves: https://github.com/microsoft/vscode-python/issues/23743
It seems that when people have a multi line string such surrounded by """ quotes, the white spacing inside the quote is very much intentional, and so if we detect that they are in such code-block, we would rather not normalize/truncate the white spaces for that specific code block.

@anthonykim1 good case for a unit test regardless of whether it breaks that case or not 👆

I think this might actually be a breaking scenario - @edeane ref: https://github.com/microsoft/vscode-python/issues/24069


solid-start-aws: aws-cdk-lib stack: Cannot read properties of undefined (reading 'method')

In a raw aws-cdk-lib stack, event.requestContext.http.method & event.requestContext.http is not present.
The shape of requestContext I'm getting is:
    requestContext: {
      resourceId: 'aabbcc,
      resourcePath: '/{proxy+}',
      httpMethod: 'GET',
      extendedRequestId: 'aabbbccdddee',
      requestTime: '30/Jan/2023:22:16:14 +0000',
      path: '/prod/favicon.ico',
      accountId: '123456',
      protocol: 'HTTP/1.1',
      stage: 'prod',
      domainPrefix: 'bbccdd,
      requestTimeEpoch:<PHONE_NUMBER>063,
      requestId: '91573d85-4935-4254-9006-d3030e6b5fee',
      identity: [Object],
      domainName: 'v2vzpo1sng.execute-api.us-east-1.amazonaws.com',
      apiId: 'v2vzpo1sng'
    },

Making the method getter configurable may be a general solution:
https://github.com/solidjs/solid-start/issues/696

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


Password type input box shape edge on top

below is the snippet is from a form, please see the top left and right on the password input box and the square edges, whilst the bottom edges are rounded.

    <input type="text" name="username" class="form-control" placeholder="Username..." required autofocus>

    <input type="password" name="password" class="form-control" placeholder="Password..." required>

  <button class="btn btn-md btn-primary btn-block" type="submit" name="submit">Sign in</button>

I did add style="border-radius:4px;" to the input and solved my problem but thought i would log this.

I tried, it is OK！I did not add style="border-radius:4px;" to the input

I also tried, everything is fine 👍
https://codepen.io/RichardOey/pen/wvyQMzm


Allow HubConnection to take a SynchronizationContext on which to invoke On handlers

This is super useful in UI scenarios. Usually you want to be able to affect your UI in the On handler, but you need a Sync Context to get back on the UI thread.

Is this done in any other .NET library? From my experience with UWP calling to the dispatcher is fairly common and not a big deal.

@DamianEdwards mentioned we either did this in ASP.NET SignalR or had guidance for doing something like this. This is also something we've talked about for a while. It certainly could be the case that most users will want to do additional processing in the On handler before transitioning to the UI thread though. We can probably leave this until we get feedback

We didn't do this in ASP.NET SignalR but discussed it at length https://github.com/SignalR/SignalR/issues/972

We should wait for feedback, backlogging this

Closing this, waiting for feedback.


Staff Pets: Add badges so staff can tell if a pet has been adopter, is in foster, or open

We have a badge component that already tells people if an adoption is pending on a pet.

Use this badge component to create three new badges for

adopted (bg-light-success)
in foster (text-white bg-dark-primary)
open (bg-light-warning)

Add this badge to pets index table/mobile card for staff - replace the sex column with a 'status' column and place the badge.

Add this badge to the pets show page next to the pet name

Given that this view logic will be used in more than one place, it probably makes sense to use a Helper, something like PetBadgeHelper or the likes

Hi @kasugaijin ! can I do this one?

For sure! @italomatos


Insane values for string "every 24 hours"

I scheduled a process using later with the schedule "every 24 hours" to create a daily running task, and it never fired. I looked into the issue and found that later had parsed that to a rather insane schedule: The next occurrences is next year on Sun Jun 25 2017 19:59:00 GMT-0400 (EDT).
Changing the schedule to "every day" instead of "every 24 hours" solves the issue, but it was very tough bug to pin down.
Attached is some example code which should allow you to reproduce the issue:
"use strict";
var later = require('later');

var samples = [
  "every 24 hours at 12:00 am",
  "every 1 day at 12:00 am",
]

function printNextOccurrances(timeString){
  var sched = later.parse.text(timeString);
  var nextOccurs = later.schedule(sched).next(5);
  nextOccurs.forEach(function(occ){
    console.log(occ.toString());
  })
}

samples.forEach(function(sample){
  console.log("test schedule string\" " + sample + "\"");
  printNextOccurrances(sample);
  console.log("===================\n\n");
})

And the output:

test schedule string" every 24 hours at 12:00 am"
Sun Jun 25 2017 08:00:00 GMT-0400 (EDT)
Wed Nov 07 2018 07:00:00 GMT-0500 (EST)
Sat Mar 21 2020 08:00:00 GMT-0400 (EDT)
Tue Aug 03 2021 08:00:00 GMT-0400 (EDT)
Fri Dec 16 2022 07:00:00 GMT-0500 (EST)
test schedule string" every 1 day at 12:00 am"
Fri Feb 12 2016 07:00:00 GMT-0500 (EST)
Sat Feb 13 2016 07:00:00 GMT-0500 (EST)
Sun Feb 14 2016 07:00:00 GMT-0500 (EST)
Mon Feb 15 2016 07:00:00 GMT-0500 (EST)
Tue Feb 16 2016 07:00:00 GMT-0500 (EST)

Yes, you'll end up with funny schedules anytime you use invalid values with one of the time constraints.  The valid ranges for all built-in time constraints are documented, see http://bunkat.github.io/later/time-periods.html#hour for hours.  I can't really automatically filter out invalid values since before and after modifiers can take invalid values and make them valid.

Agree that it's out of bounds for hours, however I would think that an exception would be thrown warning a developer that the value exceeds the possible hours.  Otherwise you can unknowingly end up in a situation, like we were, where later is scheduling your events for months in the future when you're expecting something to happen daily.
What about throwing an exception if the argument passed to the day/hour/minute parse functions exceeds the bounds? That way I have some warning instead of silently creating a schedule that doesn't make sense.

It's not that simple.  All of the time periods are basically plugins that the core engine just has an interface for.  There is a call to check the extent of a time period (like for hours, it returns 0 to 23), however, this can be date dependent (think Feb, sometimes 29 is valid) and the engine doesn't know if a value is always invalid or just sometimes invalid.  There are also modifiers that can take invalid values and turn them into valid values.  So while you could try and cover things like day/hour/minute that really wouldn't solve the problem of catching schedules that don't do what you want them to do.
The best way is to just test the schedule that you create to make sure it is returning the dates you expect.

Even the "correct" sequence appears wrong here:
test schedule string" every 1 day at 12:00 am"
Fri Feb 12 2016 07:00:00 GMT-0500 (EST)
Sat Feb 13 2016 07:00:00 GMT-0500 (EST)
Sun Feb 14 2016 07:00:00 GMT-0500 (EST)
Mon Feb 15 2016 07:00:00 GMT-0500 (EST)
Tue Feb 16 2016 07:00:00 GMT-0500 (EST)

The test is running in UTC, where "12:00 AM" would be midnight. The results are output in Eastern Time, which is 5 hours earlier. So the resulting schedule should be recurring at 19:00 daily (24-5), but the parser is instead treating 12:00 AM as "Noon", and returning a sequence at 12-5 (7 AM Eastern) instead.

I've confirmed the noon-vs-midnight issue has recently been identified as a separate issue and there is  pull request pending for it on #188


Build dependencies when necessary

Hey!
Maybe im just bonkers, but how can i add a depedency in XcodeGen to have it build when the project itself is built?
I have a dependency to an external framework inside an xcodeproj file that needs to be built before it can be linked.

Hi @flowinho. If the framework is in another Xcode project it isn't currently possible. This issue tracks that https://github.com/yonaskolb/XcodeGen/issues/570
At the moment the only way to link a framework in another project is through implicit linking which doesn't create a build dependency.


MM-25674: Add session type to push proxy

This PR adds support for the session notification type.
The behavior is the same as a normal message type, and is used
by the mobile device to differentiate.

Summary

Ticket Link

https://mattermost.atlassian.net/browse/MM-25674

Needs to be tested with https://github.com/mattermost/mattermost-server/pull/14732.

@wiggin77, @enahum - I don't know what are the QA steps to test this. Would any of you please update the ticket with the steps required for @srkgupta to test this ? Thanks.

To fully test this we still need to add a handler in the mobile apps

Ok, let me pause this PR until those are done.

I have added test instructions for this to https://mattermost.atlassian.net/browse/MM-25394.  Currently this PR blocks that ticket and associated PR https://github.com/mattermost/mattermost-server/pull/14732.
I suggest this be merged, so the blocking PR be merged and QA can at least test that a notification is sent.

Roger. @enahum - This needs an approval from you.
@srkgupta - quick note that this needs to be tested along with mattermost/mattermost-server#14732 or once that gets merged. Whatever you prefer.

I know, we still need to make the mobile app changes to support this, that’s why is still on hold

Ok, I will leave it to you guys then.

Related ticket here https://mattermost.atlassian.net/browse/MM-25931

I will test this once the changes are done in the server & mobile app.

@srkgupta mobile PR here https://github.com/mattermost/mattermost-mobile/pull/4417


SELECT count() could be faster

At the moment SELECT count() reads smallest column (DateType width), it could pick one which is smallest in terms of bytes on disk instead. (ie a column of primary key).
Ticket for rainy days.

https://github.com/yandex/ClickHouse/issues/2099
This was my attempt but it's abandoned:
https://github.com/yandex/ClickHouse/commit/a763a4a6c94bc0448cd35d174746f82e985338fa
CC @amosbird

OK. Why is it abandoned?

I was thought that I can implement it in one hour. After a few hours there were one or two failing tests. Then I switched to more important tasks and never finished. You are the only hope :)

I'll see what I can do :)

Should work in 19.13 and above.

Side effect - that can lead to using the columns which is smaller but which is much more expensive for decompressing.
CREATE TABLE cnt_test
(
    `n` UInt64 CODEC(DoubleDelta, ZSTD(20)),
    `n2` UInt64
)
ENGINE = MergeTree()
ORDER BY tuple();

insert into cnt_test SELECT number - 1000 + rand() % 2000 as x, x from numbers(10000000);

select count(n) from cnt_test; --  Elapsed: 0.837 sec. (smaller, but unpack is expensive)
select count(n2) from cnt_test; -- Elapsed: 0.172 sec. (larger, but unpack is cheap)
select count() from cnt_test;  --Elapsed: 0.821 sec (picks n)

@amosbird has already addressed this issue in one of PRs. We select based on compressed size and uncompressed size.

BTW, a763a4a is still not implemented.


hystrix javanica  aspectj compile time weaving

Hi,
We try to use  javanica  with compile time weaving.
Our  maven configuration is :

    <aspectj.version>1.6.11</aspectj.version>
        <maven.compiler.source>1.6</maven.compiler.source>
        <maven.compiler.target>1.6</maven.compiler.target>

<plugin>
                    <groupId>org.codehaus.mojo</groupId>
                    <artifactId>aspectj-maven-plugin</artifactId>
                    <version>1.4</version>
                    <executions>
                        <execution>
                            <phase>process-sources</phase>
                            <goals>
                                <goal>compile</goal>
                                <goal>test-compile</goal>
                            </goals>
                        </execution>
                    </executions>
                    <configuration>
                        <aspectLibraries>
                            <aspectLibrary>
                                <groupId>com.netflix.hystrix</groupId>
                                <artifactId>hystrix-javanica</artifactId>
                            </aspectLibrary>
                        </aspectLibraries>
                        <!--<outxml>true</outxml>
                        <ajdtBuildDefFile>build.ajproperties</ajdtBuildDefFile>
                        <verbose>true</verbose>
                        <aspectDirectory>src/main/java</aspectDirectory>-->
                        <source>${maven.compiler.source}</source>
                        <target>${maven.compiler.source}</target>
                    </configuration>
                </plugin>```

```java
@HystrixCommand
    public String doWork() throws Exception {

At run time we get the following error:
Exception in thread "main" java.lang.NoSuchMethodError: com.netflix.hystrix.contrib.javanica.aop.aspectj.HystrixCommandAspect.aspectOf()Lcom/netflix/hystrix/contrib/javanica/aop/aspectj/HystrixCommandAspect;
Is there a way to  have javanica aspects applied at compile time?
Thank You

Have you tried upgrading to maven-aspectj-plugin 1.8 and aspectj 1.8.7?

yes, we got the same error

I'll take a look as soon as can

we tried to extract  HystrixCommandAspect  and use it at compile time .
we got into a infinite loop  in the around advice. It seems that when it reaches   com.netflix.hystrix.contrib.javanica.command.MethodExecutionAction  mthod  execute  (  result = m.invoke(o, args); ) the aspect is invoked again until the thread pool is exhausted.
The final error is:
Caused by: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@5e232be7 rejected from java.util.concurrent.ThreadPoolExecutor@57177af9[Running, pool size = 100, active threads = 100, queued tasks = 0, completed tasks = 0]
I hope this helps.

Thanks for help. Will see
On 23 Sep 2015 12:05 pm, "tol"<EMAIL_ADDRESS>wrote:

we tried to extract HystrixCommandAspect and use it at compile time .
we got into a infinite loop in the around advice. It seems that when it
reaches com.netflix.hystrix.contrib.javanica.command.MethodExecutionAction
mthod execute ( result = m.invoke(o, args); ) the aspect is invoked again
until the thread pool is exhausted.
The final error is:
Caused by: java.util.concurrent.RejectedExecutionException: Task
java.util.concurrent.FutureTask@5e232be
https://github.com/java.util.concurrent.FutureTask/Hystrix/commit/5e232be7
rejected from java.util.concurrent.ThreadPoolExecutor@57177af
https://github.com/java.util.concurrent.ThreadPoolExecutor/Hystrix/commit/57177af9[Running,
pool size = 100, active threads = 100, queued tasks = 0, completed tasks =
0]
I hope this helps.
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/Hystrix/issues/907#issuecomment-142649068.

Could you please provide the client code ? Or it's pretty simple, just one method annotated with the annotation ?

Hi, a simple test method, annotated with @HystrixCommand, which is called repeatedly:
public class TestService {
private static final Logger LOG = LoggerFactory.getLogger(TestService.class);
private final boolean shouldFail;
private final int waitTime;

public TestService(boolean shouldFail, int waitTime) {
    this.shouldFail = shouldFail;
    this.waitTime = waitTime;
}

@HystrixCommand
public String doWork() throws Exception {
   System.out.println("TestService, will wait {} millis..."+waitTime);
    Thread.sleep(waitTime);
    if (this.shouldFail) {
        throw new RuntimeException("Test failure");
    }
    return "done";
}

}

I found the root cause of problem and started working on it. The problem is evident, ajc transforms byte code of instrument method, thus we can't get method in original state anymore. But there is one trick in ajc that I've used to fix the problem. There is one disadvantage with it 'cause javanica becomes very dependent on certain aspectj version, it means that in a case of any compatibility issues we can't easily increase aspectj version we need to change javanica code also. But this approach looks simple and doesn't require any changes in client api or adding new features to support it. But you need to run java process with the property: DweavingMode=compile . I didn't have I chance to add tests for all cases, I just checked simple one you provided above. I'll add more tests and see if the solution really works. But for now you can build from my branch and test your cases: https://github.com/dmgcodevil/Hystrix/tree/javanica-iss-907. Thanks

@tol I've finished working on support for compile time weaving, but haven't created PL yet, because suddenly I recognized that you cannot you use CTW if an aspect is located in jar and this aspect wasn't compiled using ajc, otherwise you'll get MethodNotFoundException: aspectOf(). If you want to use CTW then you need to copy HystrixCacheAspect and HystrixCommandAspect from javanica source code into your project and compile javanica aspects+your source code files using ajc. If you are ok with it then I'll create PL. BTW, why you don't use LTW, it has same performance I guess. LTW helps to solve this problem but requires javaagent.

@tol Or I can add task to release sep jar with aspects compiled using ajc. @mattrjacobs  is it possible to upload/release two jars: hystrix-javanica-x.y.z.jar and hystrix-javanica-ctw.x.y.z.jar ?
Then you don't need to copy aspects and you will not see MethodNotFoundException: aspectOf() error

@dmgcodevil Nice work finding the issue.
All of the build/deploy pieces are governed by the Gradle script.  If you write a PR for a Gradle script change, then I could test that out.  I really don't want to add a manual process if it can be avoided.

@mattrjacobs thanks, I didn't mean do it manually, of cource I'm going to change gradle script. Let me try and I'll encourage you if have some problems with it

@dmgcodevil Would it not be possible to resolve this issue without requiring another system property, -DweavingMode=compile ?
As far as I see, javanica inspects this property to recognize the CTW mode and use it in if/else blocks.
Now, CTW mode is the only intended usage mode hystrix-javanica-ctw-X.Y.Z artifact, right? Then, the implementation may safely assume CTW usage in the *-ctw artifact, without requiring extra system properties. So javanica user chooses weaving mode at build time by introducing dependency on CTW or non-CTW artifact.

... also asked spring-cloud-netflix (the downstream project) if they can provide an input on the issue and solution implications.

@pagrus7 Actually it was not easy to implement that. One inconvenience is extra property but I don't think that is a big problem for now. In the future we can remove but now I'm busy with other hystrix issues. Looks like I'm only one contributor.

@mattrjacobs, hi, close it please

I just released 1.4.20 and the publishing process did not push out the new jar you were working on.  I'll investigate.
https://bintray.com/netflixoss/maven/Hystrix/1.4.20/#files/com/netflix/hystrix/hystrix-javanica/1.4.20

Ok, let me know if you will need any help
On 10 Nov 2015 7:10 p.m., "Matt Jacobs"<EMAIL_ADDRESS>wrote:

Reopened #907 https://github.com/Netflix/Hystrix/issues/907.
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/Hystrix/issues/907#event-460766234.

I'm not a Gradle expert, but I think the best way to solve this would be to give hystrix-javanica-ctw its own subproject.
I can start doing this, but wanted to check with you @dmgcodevil, to make sure it sounds reasonable to you.

The vibe now is that in this case hystrix-javanica-ctw will have exactly the same code, to avoid that I need to create three modules: hystrix-javanica-core, hystrix-javanica and hystrix-javanica-ctw. It will be ideal. Now I'm working in onservable feature, once I finish it I'll jump on that

OK, will defer to you.  Thanks!

I'm having the same issue with 1.4.22.
For basic usage is there a previous version that would work?
Also any ETA on the correction of this issue?

Hi @raffaelespazzoli, as @mattrjacobs mentioned, there is an issue with gradle release plugin or something that blocks us to release javanica-ctw jar without having separate module, it's my undestanding. I didn't investigate the issue from gradle perspective so I can't tell you ETA. It would be great if can fix the issue by just tweaking release procedure, if not then I'd estimate it up to 5d. @mattrjacobs did you have a chance to investigate the issue with artifact deployment ?

@dmgcodevil I haven't had any time to make progress on this, so AFAIK it's still in the same state as before.

Hi,
How can I get the hystrix-javanica-ctw?
I am tring this, but it didn't work...
    <dependency>
        <groupId>com.netflix.hystrix</groupId>
        <artifactId>hystrix-javanica-ctw</artifactId>
        <version>1.5.10</version>
    </dependency>

Can you help me please?
@mattrjacobs
@dmgcodevil

I never figured out a way to get Gradle to generate and publish this artifact.  Any help would be appreciated.

So, is there any solution to this?  The docs for hystrix-javanica still reference using hystrix-javanica-ctw-x.y.z.jar for compile time weaving.  Or is there another way to achieve it using the standard jar?

I am having the similar issue. I am getting below error:
Task java.util.concurrent.FutureTask@6c15a847 rejected from java.util.concurrent.ThreadPoolExecutor@29172ba1[Running, pool size = 10, active threads = 10, queued tasks = 0, completed tasks = 0]
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047) ~[?:1.8.0_131]

Even though, there should not be any concurrency issue, as i am submitting only one request. So, ideally only one task should be submitted to the threadpool. But somehow, hystrix seems to be spanning out threads for the same task, until the pool gets exhausted, and the last thread just goes to fallback method, due to the above error.
Could someone help here ?
I am using hystrix-javanica:1.5.12 and spring 4.3.3-RELEASE.

Mine is simple Java application(No Spring) and I am using the configuration as mentioned @https://stackoverflow.com/questions/50994164/hystrixcommandaspect-resulting-into-nosuchmethoderror-in-plain-java-application
I am also facing the same issue, appreciate  any help.

I tried with Load Time Weaving, but end up into the same issue.

could you please create a github repo with a small project that illustrates the issue?

Where can I find hystrix-javanica-ctw-x.y.z.jar? I cannot see it in https://mvnrepository.com.

download javanica src and build it, the ctw artifact should be in the target folder, it's generated as a part of regular build process but it's not published

Has the latest (1.6.0) hystrix-javanica-ctw only been tested with aspectj version 1.8.7?


terraform-providers: disable CGO

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build terraform-full

@ofborg build terraform-full

I'm getting a weird error with nixpkgs-review:
$ nix-shell /home/zimbatm/.cache/nixpkgs-review/pr-153345-3/shell.nix
this derivation will be built:
  /nix/store/9v9vz5xmqxvzyslvckb6w0nphcvjmahg-env.drv
building '/nix/store/9v9vz5xmqxvzyslvckb6w0nphcvjmahg-env.drv'...
error: The store path /nix/store/zn1pyfz2ia166qbz558x3ak8jarhjs8l-terraform-plugin-test is a file and can't be merged into an environment using pkgs.buildEnv! at /nix/store/lf2djfrfli98wn204v5dj6r04hj901f3-builder.pl line 122.
error: builder for '/nix/store/9v9vz5xmqxvzyslvckb6w0nphcvjmahg-env.drv' failed with exit code 2;
       last 1 log lines:
       > error: The store path /nix/store/zn1pyfz2ia166qbz558x3ak8jarhjs8l-terraform-plugin-test is a file and can't be merged into an environment using pkgs.buildEnv! at /nix/store/lf2djfrfli98wn204v5dj6r04hj901f3-builder.pl line 122.
       For full logs, run 'nix log /nix/store/9v9vz5xmqxvzyslvckb6w0nphcvjmahg-env.drv'.

I can't reproduce an error with terraform_plugins_test.
@ofborg build terraform_plugins_test


{load} HTML tags are rendering as empty parameter values in reference

Describe the bug
Problem to solve:
HTML tags in source code are causing build warnings in MicrosoftDocs/azure-docs-cli. More importantly, customer-facing reference docs are not instantiating properly -- parameter values formatted with `<>` are missing. Here's an example:

Requested solution:
These values should be escaped with a backtick. Here's an example from az webpubsub.

Published reference guidelines
Guidelines for Parameters used in examples
Related GitHub issues:
This is the same issue as these GitHub issues.
List of HTML tag instances that need update:

File name
Build error

latest/docs-ref-autogen/load.yml
HTML tag 'name' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/load.yml
HTML tag 'location' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/load.yml
HTML tag 'name' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/load.yml
HTML tag 'name' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/load.yml
HTML tag 'name' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/load.yml
HTML tag 'name' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

latest/docs-ref-autogen/load.yml
HTML tag 'name' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Related command
az load
Errors
n/a
Issue script & Debug output
n/a
Expected behavior
n/a
Environment Summary
Azure CLI 2.62.0
Additional context
No response

Thank you for opening this issue, we will look into it.


Add option of creating issue template

Determined that issue templates shouldn't be required for docs repositories, so closing this issue


BibSched: follow with less exits on interrupt

Originally on 2013-04-16
After using the follow (shift-F) function in less (when looking at logs), one needs to do an interrupt to tell less to not follow anymore. However, this interrupt seems to be propagated to python which naturally exits.
Traceback (most recent call last):
  File "/opt/cds-invenio/bin/bibsched", line 33, in ?
    main()
  File "/usr/lib/python2.4/site-packages/invenio/bibsched.py", line 1812, in main
    {'start': start,
  File "/usr/lib/python2.4/site-packages/invenio/bibsched.py", line 1634, in monitor
    Manager(old_stdout)
  File "/usr/lib/python2.4/site-packages/invenio/bibsched.py", line 333, in __init__
    wrapper(self.start)
  File "/usr/lib64/python2.4/curses/wrapper.py", line 44, in wrapper
    return func(stdscr, *args, **kwds)
  File "/usr/lib/python2.4/site-packages/invenio/bibsched.py", line 1020, in start
    self.handle_keys(char)
  File "/usr/lib/python2.4/site-packages/invenio/bibsched.py", line 391, in handle_keys
    self.openlog()
  File "/usr/lib/python2.4/site-packages/invenio/bibsched.py", line 466, in openlog
    raw_input()
KeyboardInterrupt

@jalavik Is this still applicable?  See also https://github.com/inveniosoftware/invenio/issues/1701


billing: Document model fields that are not self explanatory

@hackerkid let me know when you've updated this -- and then I can do a final language pass and then merge.

Merged, after a bit more fiddling with line-wrapping and some small wording things.  Thanks everyone!


Change from a mock server to live OData service for TechEd

Step 8
Notsure why I am getting an error in the controller<PHONE_NUMBER>090_S1.controller.js

I do not remember making any changes which would cause this. What am I missing?
I would appreciate any help. Thank you.

SAP Web IDE also shows Best Practices "errors" as a red X.There is nothing to resolve; just something to keep in mind when developing productive apps.


Binding polymer dependency to latest major

Ref this issue, Polymer itself is now using caret notation for its own dependencies. This component should as well.
Also included a gitignore file for good measure :+1:

Updated README to reflect deprecation status. Closing this PR: https://github.com/PolymerLabs/polymer-jsonp/commit/1cb4b05797eddeb3ce572211c75c6f4e01bba79a
Thanks for working on it through :)


Restrict Section input to whole numbers

Only allow the increase/decrease arrows to increase or reduce by whole numbers. Ideally, both the arrows and the keyed in values can only be from 1 to 36.

validated


Add no_tracing tag

Tracing plugin pulls in a few heavy vendor dependencies, which is not always a requirement.
For cases, when tracing is not needed, this PR adds no_tracing build tag to exclude it at build time.
Signed-off-by: Maksym Pavlenko<EMAIL_ADDRESS>

Looks good to me. Would it impact the binary size?

The binary size wasn't the goal for my case. But
❯ make bin/containerd
 bin/containerd
❯ du -sh bin/containerd
 23M	bin/containerd

❯ make bin/containerd BUILDTAGS=no_tracing
 bin/containerd
❯ du -sh bin/containerd
 22M	bin/containerd

Slightly less.

More about trimming down unneeded code just in case?

In my specific case I'm getting lots go mod conflicts when there are imports which depend on different versions of opentelemetry (like containerd and k8s.io/component-base/traces)


Bug correction and continuation of the project

Hello,
My reason of merging are :
i found and correct (i hope) a little bug  added french on obkey.
Too, i  intend to continue the project with ergonomic enhancement.
Best regards.

Thanks!
One question and one request before I merge -
Did you intend to change the permissions on obkey from 755 to 644?
Please could you revert the change to the original author's name and email address (part of d1aebbd)? It doesn't seem fair as he wrote most of this.

Ok,
i changed back the setup.py author part but i let « version='1.2pre' »
for version management.  (An AUTHORS file will be usefull in the future...)
Permissions changed.
On 08/06/2016 19:03, Steven Honeyman wrote:

Thanks!
One question and one request before I merge -
Did you intend to change the permissions on obkey from 755 to 644?
Please could you revert the change to the original author's name and
email address (part of d1aebbd
https://github.com/stevenhoneyman/obkey/commit/d1aebbd86ced158edbb35af5a04fca6089dec3de)?
It doesn't seem fair as he wrote most of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stevenhoneyman/obkey/pull/6#issuecomment-224658702,
or mute the thread
https://github.com/notifications/unsubscribe/AJBfDqNN0lzGA4T5BbGesFRE9vkd0i6Bks5qJvXNgaJpZM4Iw5cf.


Is it possible to not print the deepspeed configuration? It is too long.

Sure, we can add an option to suppress. Will that work?


Performance improvements

I profiled UtinyRipper a little with DotTrace, and found some hot functions that could be optimized.
For a game of 500 asset collections, mostly Texture2D, total run time fell from 00:33 to 00:28, i.e. a 20% improvement. (An experiment to further offload YAML serialization to Task threads seem to drop runtime to 00:22, i.e. +50% from baseline, but that still requires more safety work.)

Re the tests,

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(1657,5): error : Project '..\uTinyRipperCore\uTinyRipperCore.csproj' targets 'netstandard2.0'. It cannot be referenced by a project that targets '.NETFramework,Version=v4.6'. [C:\projects\utinyripper\uTinyRipperGUI\uTinyRipperGUI.csproj]

I'm not sure what target to set for the GUI for it to be interoperable with that library version. 😞

Re the tests,

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(1657,5): error : Project '..\uTinyRipperCore\uTinyRipperCore.csproj' targets 'netstandard2.0'. It cannot be referenced by a project that targets '.NETFramework,Version=v4.6'. [C:\projects\utinyripper\uTinyRipperGUI\uTinyRipperGUI.csproj]

I'm not sure what target to set for the GUI for it to be interoperable with that library version. 😞

4.6.1 [ref]

Thanks @chrixian :)

Is there a way to check .net core at runtime? NET_CORE require project recompilation and there is no such define in project settings.

Is there a way to check .net core at runtime? NET_CORE require project recompilation and there is no such define in project settings.

I don't believe so... here is the documentation on multitargetting (you'll notice NET_CORE isn't a valid preprocessor symbol so you'll want to choose an appropriate one from the chart)

Such #define approach is harmful since it compiles dll that is compatible with .net framework but contains code that work incorrectly in this environment. The only option is runtime check. As I found RuntimeInformation.FrameworkDescription return string followed by '.NET Core' or '.NET Framework' so it is possible to detect .netcore at runetime, at least for some versions

Hi, i guess improvments to overall performance are necessary. Reading files from games consumes huge amount of memory and is slow. Maybe more Tasks/Threading and queues are necessary. For me it uses 10Gb of memory but only 8% CPU. Seems like all data is loaded into memory, but not really exported fast?

@Ch4rg3r hi. who said that such kind of tool has to be fast and light.
there are two significant issues that really degrade performance - texture import and shader export. other issues aren't worth their time. Tasks/Threading adds complexity and disturb stable development. such optimization is required after main features are done, not during their development.

@mafaca ok true that. maybe i'll take a look into that. would like to see it work a bit faster. for me actually it imported/exported quite fast even with a lot of textures and shaders. The slowest part definetly was the export preparation.

@Ch4rg3r by texture importing i mean export preparation for textures. That code block you mentioned is actually pretty fast except for one case. For every texture it creates TextureExportCollection. This collection has to find all sprites that correspond to given texture so it fetch all assets in the project. For a project with huge amount of assets and textures this process take incredible amount of time. Since I try to avoid hacks in this project and graceful solution requires pretty much time for implementation so I decided to leave it as it is.

Ok. Thanks for explanation. Sounds like the easiest aproach. I'll take a look at the implementation later.  It's so much code you have written, very complex. Btw once it finished exporting, everything looks good.  Great work

So i took a look into the implementation. The only way i see, which would solve fetching all sprites over and over again would be a mapping of all sprites and textures, which is made once in export preparation. Unfortunatly i have no idea how to implement it due to the interfaces and ExportCollections handling.

due to the interfaces and ExportCollections handling.

that's why i decided to leave it as todo. interface should be supplemented with an object that can hold cache data. i'm going to do it later when i finish more priority tasks


Running on IOS Emulator

Hi, I'm having a problem and I would like to know something. I installed the package and it works fine on android, but on my IOS emulator it doesn't accept to run the app, since you said it doesn't work on the IOS emulator, but at least it runs the app on the emulator it just doesn't work the notifications and others!?

In README.md clearly signed: iOS: ONLY WORKING ON REAL DEVICE, not on simulator(Callkit framework not working on simulator).

In README.md clearly signed: iOS: ONLY WORKING ON REAL DEVICE, not on simulator(Callkit framework not working on simulator).

Maybe it should be clarified that the builds will no longer work on a Simulator. The current disclaimer can be misinterpreted as the functionality of the plugin not working on a Simulator.

Maybe it should be clarified that the builds will no longer work on a Simulator. The current disclaimer can be misinterpreted as the functionality of the plugin not working on a Simulator.

The package won't crash your app on the simulator. Probably you missed something from the installation of the readme.

Maybe it should be clarified that the builds will no longer work on a Simulator. The current disclaimer can be misinterpreted as the functionality of the plugin not working on a Simulator.

The package won't crash your app on the simulator. Probably you missed something from the installation of the readme.

the app doesn't even want to run when I use the package, I don't know what to do anymore

Have you tried flutter clean and pod install?

I solved my problem with this example https://github.com/flutter/flutter/issues/94914#issuecomment-992898782


Change Ansible installation to use yum

Signed-off-by: Yussuf Shaikh<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

/hold
Doing last round of testing with rhel_subscription_password  = "<subscription-password>"
In meantime would like some review comments if any...
/cc @Prajyot-Parab @bpradipt

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Prajyot-Parab, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Prajyot-Parab,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Prajyot-Parab,bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


State of Zutre?

I‘m looking for Spectre on Vue and just found this library.
What‘s the state? Is this still in development? Thanks.

Hi @Anachron ,
Am really sorry for late reply - had some private issues to solve for over last month. Yes this is still in development, there was few updates in Spectre and Vue itself - I will be back to development of this project by the end of this month and will try to update and code improvements during the next month and make it ready to be used with projects.
I have already start to work on some private project based on Zutre and it works pretty fine, there is some small issues which am going to fix.
If you could spend some time to play around and provide some feedback I would appreciate it much!

Good to read. Since I use spectre.css and have switched to vue I hope I find time to be of help.

will close this task. If there would be any more questions please create new ticket


AtmosphericEffects "flickering"

Version of Advanced Rocketry
[AdvancedRocketry-1.7.10-1.4.0-20]
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
[LibVulpes-1.7.10-0.2.8-34-universal]
Version of Minecraft
[1.7.10]
Description of the problem
the Slowness and mining fatigue effects occasionally run below their timers causing the player to gain regular mining/speed until it kicks in a second or 2 later, suggest having an atmospheric effects timer in the config as i feel setting them to about 5 minutes will resolve this issue, also thinking 5 minutes of "decompression" sounds fair :)

1.7.10 is not supported at this point in time. Closing this issue.


add github actions configuration file

Enabling GitHub Actions will provide fast feedback in case some of the tests start failing. If you are interested, I have written a number of blog posts and recorded videos explaining this: https://perlmaven.com/os

I bet the test should be done with make disttest not make test.  make test is most likely running author tests that are not packaged.

On the CI I'd run the author tests as well - at least on one OS/perl version pair. That will protect you from errors there even if you, or someone sending a PR forgets to run the author tests.
Regarding other Linux distributions, GitHub does not provide those, but I think you can use and Docker image to run your workflow inside.


BUG: Mark translatable strings in Libs/Widgets

see Slicer/SlicerLanguagePacks#17
see Slicer/SlicerLanguagePacks#12

@jcfr or @pieper can you approve this? It seems that the CommitCheck got stuck, so I cannot merge.

commitcheck

Due it unreliable nature, I removed it from the required check.
We will instead transition to GitHub action to the commit message.

Thank you!


Unreadable

As a Chinese, These is too much English for me, can't you just support Chinese while English??
/doge

老子喜欢，爷乐意，老子乐意，就是爱装逼，有能耐你给我PR，不能PR少bb/doge

Anger Bother ,RBQ,RBQ


Update release-image.yaml

Updated ko command to build multi-arch images

@pierDipi Hi! The multiarch image is required for testing on IBM Power/Z. Canyou merge this please? The github action should then automatically build it as multiarch.

Image published: https://github.com/pierDipi/sacura/pkgs/container/sacura%2Fsacura-7befbbbc92911c6727467cfbf23af88f/108485927?tag=latest

Nice!


Camera preview stretches sometimes

At first thanks for awesome library.
I had a problem, when app is running sometimes preview is stretched automatically, but if I capture a photo it takes correct scaled picture and than preview is correct.
Tested it on Lenovo and HTC; OS v 6.0.1

I am also facing this issue. Tried on Android 7.1.2 on Oneplus one. It happens randomly though.

If you have autorotate on it will initialize with the phone's sensor values at creation. If you take a photo or rotate the phone it will recreate with the good values and not stretched. At least this is the conclusion I've reached.

I have the same problem. When I start to record the video is stretched and after recording it becomes correct.
Device: LG K8.  Android 6.0.
And I noticed something. I tried another CameraView library. There if the video quality is set to Lowest or 480p, then it is stretched like here, and if you put other qualities, it works correctly!
Maybe this information will help to understand the problem

You can expect fixes here in the next few days and they will be instantly available via SNAPSHOT builds of 0.13.0!

Any update on this? Can't find any snapshot versions.

Have you fixed this bug?

Seems like this bug occurs always if the screen orientation is portrait, but the preview looks fine when the orientation is landscape.

Resolved in our 1.0.0 https://github.com/CameraKit/camerakit-android/pull/318 -- please test it out using the notes in the PR and comment in the PR if you see any further issues on any devices!


chip-tool crashes when called with no arguments

Problem
Compiling the binary in examples/chip-tool and running it with no arguments crashes.  This problem was introduced in https://github.com/project-chip/connectedhomeip/pull/1660 by removing the argc check at the beginning of DetermineCommand.
Proposed Solution
Put the argc check back.
@vivien-apple

Should have been fixed by #1680.

Yep, looks like it. Thank you!


Improve Error message on BadRequest

Is your feature request related to a problem? Please describe.
I was testing some code to upload a dummy file
import os
import io
from huggingface_hub import HfApi

token = os.getenv("USER_API_TOKEN")
api = HfApi()
repo_id = "Narsil/test"
api.create_repo(token=token, repo_id=repo_id, repo_type="dataset", exist_ok=True)

f = io.BytesIO()
readme_string = """
---
benchmark: ttt
task: xxx
type: prediction
---

# Batch job

model_id: {model_id}
dataset_name: {job.dataset_name}
dataset_config: {job.dataset_config}
dataset_split: {job.dataset_split}
dataset_column: {job.dataset_column}
"""
readme_string = readme_string.replace("\n    ", "\n").strip()
f.write(readme_string.encode("utf-8"))
f.seek(0)
try:
    api.upload_file(
        path_or_fileobj=f,
        path_in_repo="README.md",
        repo_id=repo_id,
        repo_type="dataset",
        token=token,
    )
except KeyError as e:
    # Not modified.
    pass

This was crashing with BadRequest error, however I couldn't understand what was the issue.
I had to dive into the code to see that the hub was sending this message:
b'{"httpStatusCode":400,"errors":[{"message":"You can\'t have a key with a \\".\\" or \\"$\\" character in your YAML metadata","type":"error"}],"warnings":[]}'

Afaik this wasn't in the original stack.
Shouldn't we try and wrap it into a better exception so that user can digest that error ?
Describe the solution you'd like
A clear and concise description of what you want to happen.
Probably possible to modify either the BadRequest message or wrap it into another Error.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Not sure I have other suggestions.
Additional context
Add any other context or screenshots about the feature request here.

0.10.1 But it also happens on main.

import os
import io
from huggingface_hub import HfApi

token = os.getenv("USER_API_TOKEN")

api = HfApi()
repo_id = "Narsil/test"
api.create_repo(token=token, repo_id=repo_id, repo_type="dataset", exist_ok=True)

f = io.BytesIO()
readme_string = """
---
benchmark: {job.id}
task: xxx
type: prediction
---

# Batch job

model_id: {model_id}
dataset_name: {job.dataset_name}
dataset_config: {job.dataset_config}
dataset_split: {job.dataset_split}
dataset_column: {job.dataset_column}
"""
readme_string = readme_string.replace("\n    ", "\n").strip()
f.write(readme_string.encode("utf-8"))
f.seek(0)
try:
    api.upload_file(
        path_or_fileobj=f,
        path_in_repo="README.md",
        repo_id=repo_id,
        repo_type="dataset",
        token=token,
    )
except KeyError as e:
    # Not modified.
    pass

But I agree with you that if the BadRequest is not explicit and we received a message from the server, it should be printed. It should already be the case but there can be a bug.

on the server side you can probably reduce this error by sending a README.md file containing
---
foo.bar: true
---

@Wauplin you changed my script.
The error is that dots are disallowed in the metadata.

Good I've reproduced the error using @julien-c snippet !
That is definitely something to improve, thanks @Narsil for reporting it. Error message from the server is already supposed to be propagated to the raised exception. Here it's not the case because the Hub returns a "errors" list instead of "error" message. => I'll adapt hf_raise_for_status to handle both.


[schema]providing the version compatible schema for kubernetes

from @bnookala
@andxu @itowlson Do you think we should be using k8s semantic versioning for the swagger.json file?I'd imagine a situation in which a user might be on 1.7.* cluster, and the swagger.json file we've bundled is using definitions for a 1.9.* cluster.Additionally, this might open up opportunities to use the configured cluster's kubernetes version to load the appropriate swagger.json file.
We need to do more work on choosing the right schema based on kubernetes version

https://github.com/Azure/vscode-kubernetes-tools/pull/101

https://github.com/Azure/vscode-kubernetes-tools/pull/121

I think current solution is acceptable since the latest version is compatible with older versions, the feature to be more precise schema to detect old kubernetes versions will have low priority and should be opened as a new issue.


eager loading on nested resource

I have the nested resource
       resources :clubs do
            resources :members
        end
```

in members_controller
```
class AdminClubs::MembersController < AdminClubs::SecureController
    load_and_authorize_resource :club
    load_and_authorize_resource :users, :through => :club, :class => User

my ability
def initialize(user)
   can :manage, Club do |club|
       user.club_admin?(club.id)
   end
   can :manage, User, id: user.club_id

when I ask for: admin_clubs/clubs/196
user.club_admin?(club.id) generate only one SQL query
When I ask for the members:  admin_clubs/clubs/196
user.club_admin?(club.id) generate one SQL query for each user displayed on the page but it did not make sense to check each displayed user if they are club_admin or not.

You can easily eager load an association in your controller without involving Cancancan.
Cancancan will return an AR scope, which you can keep chaining to, so in your index action, you could do:
load_and_authorize_resource :club
load_and_authorize_resource :users, :through => :club, :class => User

def index
  @clubs = @clubs.includes(:users)
end

Same sort of thing if you were paging a collection action.

great. thanks.


Revert "Don't treat language model datasets special"

Reverts dmlc/gluon-nlp#128
There is no consensus that usage of WikiText for non-LM purpose should be supported at the cost of making the LM API more complicated (by eg. making the bptt_batchify and batchify functions standalone).

Thanks. I do think the general design of this refactor is a step in the right direction. This way, all the classes and interfaces are doing what they are supposed to, and WikiText classes will no longer be more specialized than what's necessary, which should open up possibility for more creative use and customization. Good design takes time, so thanks for proposing the change.
Let's review the design again after next release, and build consensus.

Job PR-134/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-134/2/index.html

Job PR-134/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-134/3/index.html

The merit of the design is not from the results it can get, but rather the flexibility and right principles for API design

Yes, but I do think our package should balance between academic convention and flexible API usage

They are not in conflict.


Docs section: IAM - AADDS replica sets availability

Page section: Design Considerations
Arch and doc refer to Azure AD DS having a limitation of projecting to a single VNET and unable to fail over to another region, This is incorrect as Azure AD DS Replica Sets enable multi-region deployment of Azure AD DS.
Replica sets concepts for Azure AD Domain Services | Microsoft Docs

Migrated to ADO, multi replica sets in different regions will be part of multi-region deployment guidance


UI should run tests against develop

Is your feature request related to a problem? Please describe.
UI builds nightly against develop, but doesn't run the tests. This can lead to some unfortunate surprises
Describe the solution you'd like
UI builds should also run tests against develop.
Failures should probably go to a Slack channel.
Additional context
To run the existing tests, UI fetches a released web service JAR from OICR artifactory.
This will not be an option for develop, which doesn't have a JAR on artifactory. We should be able to run the web service as a Docker container.
Unclear if we'd want to change all tests to use a Docker container, or just this one.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Backlog
┆Issue Number: DOCK-1398

UI fetches a JAR, swagger.yml, and openapi.yml from either OICR + GitHub.  It can also get it from a specific CircleCI build but it's meant to be done manually.


[stable/minio] corrected syntax error in statefulset

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Syntax error in Statefulset prevented installation from working.
Which issue this PR fixes
Syntax error
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Thomas Wilkinson<EMAIL_ADDRESS>

/assign @krisis

/lgtm

This PR reverts the fix I had submitted previously,
FYI:
https://stackoverflow.com/questions/17891226/difference-between-and-operators-in-go
The := operator is an assignment and declaration in one. Therefore:
{{ $scheme := "http" }}
 {{- if .Values.tls.enabled }}
 {{ $scheme := "https" }}
 {{ end }}

If tls is enabled, this will simply declare and assign a new variable "scheme" that only exists until the {{ end }}. ie, it will have zero effect on actually enabling https for minio.
Effectively, scheme is now always "http". If the previous fix broke anything, it is probably because you have enabled tls and there are issues with your certificates. Rather than revert the fix you could simply set tls to disabled or figure out the issues with the certs.

@krisis the PR @briend is referencing is #21373, which fixed the scoping issue that this PR reintroduced

Why it was merged? It seems wrong, and I can't enable TLS successfully.


Configure online editor

This issue is part of the migration to v3. You can read full details about the various changes here.
In Exercism v3, students can now choose to work on exercises directly from their browser, instead of having to download exercises to their local machine. The track-specific settings for the in-browser editor are defined in the top-level "online_editor" field in the track's config.json file. This field is defined as an object with two fields:

"indent_style": the indent style, either "space" or "tab".
"indent_size": the indent size, which is an integer (e.g. 4).

You can find a full description of these fields in the spec.
Goal
The "online_editor" field should be updated to correspond to the track's best practices regarding indentation.
Example
"online_editor": {
  "indent_style": "space",
  "indent_size": 4
}

Tracking
https://github.com/exercism/v3-launch/issues/2

See https://github.com/exercism/vbnet/pull/136

Closed by #136


the loss suddenly increases

Why does the loss suddenly increase by several times after three to four hundred iterations during model training? Another question is, during each iteration of training, does the function net.update() need to run once (with net = DMC())?

I ran into a similar problem when training on volumetric images. After a certain number of iterations the loss suddenly increases rapidly followed by overflow.

Why does the loss suddenly increase by several times after three to four hundred iterations during model training? Another question is, during each iteration of training, does the function net.update() need to run once (with net = DMC())?
Do you have the training code for DCVC？


Sandbox: revisit need to assign configuration environment from preload script

We should see if process.env is actually needed once the renderer is fully sandboxed. Currently we overwrite the process.env with properties from the user environment, but not when sandbox is enabled:
https://github.com/microsoft/vscode/blob/5264ab94a337ea8acae51c550aefe1f0b578f656/src/bootstrap-window.js#L68-L70

Checked again, there is no race condition, but we still should support user environment from configuration in sandbox.

Fixed via https://github.com/microsoft/vscode/commit/6f3fcd2ce0002ffd876b7b43bff42a912edddaae
@segevfiner fyi this fixes the race condition you found, via:
https://github.com/microsoft/vscode/commit/6f3fcd2ce0002ffd876b7b43bff42a912edddaae#diff-df790e46b6eeafab40b4c8d24b56276f16f314eb4b470ef97192dfafac3105c0R217


The launcher currently doesn't support version 4.0.1 currently, please wait for further updates

is it gonna update or do I need to download the whole launcher again?

I think we should wait for new yaagl release

I think we should wait for new yaagl release

do you have any idea till when will it come out?

i try bu that i cant log on

The Release 0.1.3 is out to fix that

I think we should wait for new yaagl release

do you have any idea till when will it come out?


My mind map cuts text in half

The image tells pretty much the full story. I have tried to adjust all the padding and other settings to no avail.

I have this exact same issue, haven't found a fix yet...

i also have the same issue.  I tweaked the plugin settings also. But now way

just now rectified

change node min height values in mindmap plugin settings


[Request] Add nheko

Another promising Matrix client, based on Qt.

The motivation behind the project is to provide a native desktop app for Matrix that feels more like a mainstream chat app (Element, Telegram etc) and less like an IRC client.

Repository here: https://github.com/Nheko-Reborn/nheko

@1hiking could you create a PR for the same?


connecting smartbft metrics

The library changes look fine, I think there was two commits, right?  One that removed the deletion of requests and the other one with the mutually exclusive deliver?
As for the metrics - can we have metrics such that Fabric metric script will generate the corresponding documentation?

This branch has conflicts that must be resolved
Use the [web editor](https://github.com/hyperledger/fabric/pull/4396/conflicts) or the to resolve conflicts.
Conflicting files
orderer/consensus/smartbft/chain.go

Please do one change at a time:

One PR to update the library dependency
One PR to connect metrics.

They should not be coupled together.
Apart from that, please consider the following two fixes:
fabric-research/consensus@bd70a99
fabric-research/consensus@ddcb609

split the changes

The library changes look fine, I think there were two commits, right? One that removed the deletion of requests and the other one with the mutually exclusive deliver?
As for the metrics - can we have metrics such that Fabric metric script will generate the corresponding documentation?

should be done, but if you don't mind I'd do it as a separate pr

The library changes look fine, I think there were two commits, right? One that removed the deletion of requests and the other one with the mutually exclusive deliver?
As for the metrics - can we have metrics such that Fabric metric script will generate the corresponding documentation?

here's the promised change
https://github.com/hyperledger/fabric/pull/4434

The library changes look fine, I think there were two commits, right? One that removed the deletion of requests and the other one with the mutually exclusive deliver?
As for the metrics - can we have metrics such that Fabric metric script will generate the corresponding documentation?

here's the promised change #4434

I saw it, but unfortunately I'm busy right now so I don't have time to review it properly


fail nitro build if there are errors prerendering pages

Environment

Operating System: Linux
Node Version:     v18.3.0
Nuxt Version:     3.0.0-rc.8
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-6hv1ba?file=package.json,app.vue

take a look at package.json & app.vue
execute npm run generate
run echo $? to get the exit code (not working inside stackblitz)

this should return non zero but it returns 0

Describe the bug
The --fail-on-error is ignored by the nuxi generate command so the generate command is not backwards compatible to nuxt2.
The lack of considering this feature can lead to broken website deployments because it is not possible to differentiate between a succeed and failed generation.
Additional context

https://github.com/nuxt/nuxt.js/issues/4991
https://nuxtjs.org/docs/get-started/commands/#fail-on-error

Logs
No response

This is now implemented upstream in Nitro. You can set nitro.prerender.failOnError to true to enable the behaviour.


Excessive CPU load

On my computer:
https://lukeworks.tech/tetanes-web ~60%
https://takahirox.github.io/nes-rust/wasm/web/index.html ~30%
OpenEmu ~15%

Thanks for reporting! I can definitely see some areas for improvement.

@mantou132 Would you mind giving more details on your results like which browser and OS? I'm getting 50-60% CPU usage on nes-rust as well on Chrome 102.0.5005.115 on macOS Catalina 10.15.7. The CPU profile for each shows that 80% of the CPU time is spent in clocking a NES frame in WASM which each frame lasts around 0.14ms to 0.16ms (e.g. 60 FPS). The JS and GPU are actually doing very little amount of work comparatively.
I think both implementations would benefit from switching to AudioWorklets so that the audio handling is not done from the main thread, but I haven't gotten around to figuring out how to do that yet.

Thanks! I'll take a deeper look. I'm working on several performance elements right now even for the native version so hopefully that will be out soon.
TetaNES is meant to be fairly accurate to the original NES, including several odd behaviors that don't directly affect most games. The native version is cycle accurate while WASM is using a catch up method on every CPU instruction to be more accurate. Audio is also downsampled and both low and high pass filtered, so there is certainly a bit more processing than I find in nes-rust.
I know there are gains to be had though, Mesen is what I'm benchmarking against as being more accurate than TetaNES and also more performant.

This affects most emulators. Added to that the web audio API is not well suited to real time generated audio streams.
The NES generates exactly enough audio for 60fps at 48000 hz sample rate. Any less fps and there will be gaps, which creates pops in audio. I've tried to compensate for it using dynamic rate control which resamples the audio to get more samples (and changes pitch a little, but not enough to notice). Unfortunately it's not sufficient. Other option is to clock extra frames, which can cause screen tearing.
It's something I'm continually trying to fix, but feel free to create a separate issue for it for tracking
Some links for reference:
https://docs.libretro.com/development/cores/dynamic-rate-control/
https://emulation.gametechwiki.com/index.php/Vsync

My thought was it would be faster for wasm to copy than JavaScript, and I noticed nes-rust was doing a similar thing except using a for loop, but now that you mention it, a buffer view into wasm memory was probably the more performant method.
I'll need to do some more benchmarks. Working with the web audio API is tedious. My next steps are to explore removing the current audio processing from wasm (so less for the main thread to process) and instead leveraging the builtin filtering features of web audio and a shared array buffer with an AudioWorklet so it can all be done on a separate thread

This should be resolved for the upcoming release based on the engine-rework branch. Additional threads with sleeping for os builds and clocking/redrawing only when needed in wasm.
In general TetaNES is going to have a higher CPU use than similar emulators due to cycle accuracy and additional features like rewind.

This should be much improved in the latest release. It's still higher than some other emulators, especially when cycle accurate and run ahead features are enabled.
This will likely be an ongoing issue. I'm closing this for now in favor of #235 which will greatly reduce overall usage as well.


exclude helm repo from super lint

An example build in my fork shows that the helm directory is no longer getting linted:
https://github.com/cfkoehler/emissary/actions/runs/4877625397/jobs/8702439477


Disallow applying the #[test] attribute to impl methods

We recently had an issue in the bignum library not registering that we had multiple tests with the same name due to the tests being defined inside of an impl (for "hacky forcing the compiler to do things it doesn't want to do" reasons).
I don't see a good reason to have tests be anything other than free functions so we should error in cases where they're attached to impls.

Note that this is currently being used in the bignum library here so we need a solution for codegenning test functions before we can enforce this.


Application crashes when running on iPhone

App crashes when running on iPhone with the message:
dyld: Library not loaded: @rpath/InflectorKit.framework/InflectorKit
  Referenced from: /private/var/mobile/Containers/Bundle/Application/*****
  Reason: no suitable image found.  Did find:
	/private/var/mobile/Containers/Bundle/Application/*****/Frameworks/InflectorKit.framework/InflectorKit: mach-o, but wrong architecture
	/private/var/mobile/Containers/Bundle/Application/*****/Frameworks/InflectorKit.framework/InflectorKit: mach-o, but wrong architecture
	/private/var/mobile/Containers/Bundle/Application/*****/Frameworks/InflectorKit.framework/InflectorKit: mach-o, but wrong architecture

Works fine on iPad. Both devices are running iOS 8.4. I installed meteor through cocoapods. Running the latest version of cocoapods, 0.38.2, and did both pod installand pod update.

i am having the same issue! @martijnwalraven any solution?
I get a series of errors telling me it has failed to code sign such things as InflectorKit, which came with the Meteor installation. I can code sign each of the projects that the Pods workspace includes, and once I get past that I can install the app on a device, but it crashes immediately, saying, "Library not loaded: @rpath/InflectorKit.framework/InflectorKit" in the device's crash log.

It has been a while since I worked on this, so this may be due to changes in newer versions of CocoaPods or Xcode. I won't have time to look into this for at least a few days, so please let me know if you find out anything!

@callmeahab did you find any resolution?
I thought I had it by changing the framework linking to optional, but then the library doesn't get loaded at all, and while the app doesn't crash, it can't interact with meteor, either.

I've created static frameworks using carthage, and it works fine in the simulator, but the minute you put it on a device it gives the same error "Library not loaded: @rpath/InflectorKit.framework/InflectorKit"
I had changed the frameworks to optional, and thought I had it, but then nothing worked in the app...

@sferoze
I cloned the project repo to a new location, did pod install and ran it on iPhone first, and it works. May be an issue with the framework architecture. Now the app works on both iPhone and iPad.

@callmeahab
Thanks
I was able to build by doing the same. Cloning my project into a new location and then running 'pod install'


Disable/Enable SSL certificate verification

Is your feature request related to a problem? Please describe.
We are required to hit our endpoint which is HTTPS with SSL, and we are getting error:  Error: unable to verify the first certificate
Describe the solution you'd like
Able to Disable and Enable SSL certificate verification
Describe alternatives you've considered
N/A
Additional context
N/A

I was able to disable with hardcode: process.env["NODE_TLS_REJECT_UNAUTHORIZED"] = 0;

@ruslK This has been answered here
Are these self signed certificates or  private network API call or behind a proxy ?
A working example that might be of help https://github.com/pactumjs/pactum/pull/293
Note: You will have to ignore parts that doesn't relate to your case in the above example

@leelaprasadv

Are these self signed certificates or private network API call or behind a proxy ?

we don't use proxy.

Additionally, if you have the cert/key pair you can provide it the agent in withCore() and you should be able to make https requests.

we don't mock data, we do E2E, we are hitting actual endpoint in environment.

We would be happy disable SSL with pactum, not with process.env["NODE_TLS_REJECT_UNAUTHORIZED"] = 0;

@leelaprasadv
Can I ask another question about Redirection?
we have endpoint, which finish with 302 and should be redirected to another endpoint.
When I execute that endpoint in postman, I see in logs that postman makes 5 another call with redirection.
is possible to do with pactum?

@ruslK

we don't mock data, we do E2E, we are hitting actual endpoint in environment.

Yes, the example provides you with details on how to use an agent, the suggestion was to pick the block of code related to the agent from the example.
const https = require('https');

// If you have the cert/key pair
const key = fs.readFileSync("server.key")
const cert = fs.readFileSync("server.crt")

const agent = new https.Agent({
  cert: cert, // Optional - add if cert available
  key: key, // Optional - add if key is available
  rejectUnauthorized: false // Ignore  certificate errors
});

pactum.spec()
    .get('<https url>')
    .withCore({agent: agent })
    .expectStatus(200)

For follow Redirects, refer to the documention https://pactumjs.github.io/api/requests/withFollowRedirects.html#withfollowredirects

@leelaprasadv
about Redirect

For follow Redirects, refer to the documention https://pactumjs.github.io/api/requests/withFollowRedirects.html#withfollowredirects

what is deep of Redirect? one redirect or not?
and how to config redirections?
and how to see logs for redirections?

PactumJS relies on phin.js for http/https requests and it has a default follow redirect count of 20. Changes to support configuring redirect count can be expected in the next couple of releases.
As for debug logs for redirects, phin under the hood uses follow-redirects, one option I see is to set an environment variable suggested in their readme doc
https://github.com/follow-redirects/follow-redirects/tree/main?tab=readme-ov-file#debug-logging

@leelaprasadv
thank for this tip:

PactumJS relies on phin.js for http/https requests and it has a default follow redirect count of 20. Changes to support configuring redirect count in PactumJS can be expected in the next couple of releases.
As for debug logs for redirects, phin under the hood uses follow-redirects, one option I see is to set an environment variable suggested in their readme doc https://github.com/follow-redirects/follow-redirects/tree/main?tab=readme-ov-file#debug-logging

It is working, but I have issue with cookies, cookies are not passing for next redirected call.
In postman there is config calls Disable cookie jar - if I disable in postman, i'm getting same problem with pactum.

So it possible to Enable Cookies Jar with PactumJS?

PactumJS relies on phin.js for http/https requests and it has a default follow redirect count of 20. Changes to support configuring redirect count in PactumJS can be expected in the next couple of releases.
The above will be handled in #372

Closing the issue as the original question is answered. Please follow up rest of the queries in existing discussions or start a new one if required.


Missing hello world / template?

The "hello world" explained on the README doesn't compile as it seems to be missing an import to body. The examples at Try Thermite depend on Thermite.Try, so, I think they're not supposed to be used as a template for a new project too. What is a proper Thermite Hello World that I can use as a template for new Thermite projects?

What about the project inside the ´test/` directory? Does that work?

Yes, you should look at the test project. I omitted body from the README, since it's boilerplate code which isn't specific to Thermite.

Gotcha, thanks.

I think that isn't the best hello world, actually. It doesn't work as a simple template I can just start hacking in. For one, there are many files and components which obviously aren't part of my app, so I have to remove them. But of course I don't know what I can safely remove because, by definition, I'm a newcomer doing that exactly to learn about the lib. A template should basically be just have the skeleton with no specific component.
import DOM (DOM) as DOM
import DOM.HTML (window) as DOM
import DOM.HTML.Types (htmlDocumentToParentNode) as DOM
import DOM.HTML.Window (document) as DOM
import DOM.Node.ParentNode (querySelector) as DOM
import React as R
import ReactDOM as RDOM
import Thermite as T

The sheer amount of DOM, React imports - do I need all that anytime I create a new app? The library should hide that from me.
main :: Eff (dom :: DOM.DOM) Unit
main = void do
  let component = T.createClass taskList initialTaskListState
  document <- DOM.window >>= DOM.document
  container <- unsafePartial (fromJust <<< toMaybe <$> DOM.querySelector "#container" (DOM.htmlDocumentToParentNode document))
  RDOM.render (R.createFactory component {}) container

Then, WTF again. What is that even doing? A newcomer having Thermite as his first PureScript experience won't have an idea what that is doing, and it shouldn't, because the purpose of the lib is to abstract always all the DOM manipulation!
I think something like that would be ideal:
import Thermite.Template -- or something like that

myApp :: ...
myApp = ... here I write stuff ...

main :: CommonThermiteApp
main = defaultWebApp myApp

With defaultWebApp doing whatever that thing is doing on the example. That'd reduce a lot the entry barrier for newcomers, I think. As of now, I can't do anything other than give up of learning Thermite to learn the DOM and React libs, so I can come back here and I understand what that code is doing. Which shouldn't be the case! I'd write that Template myself, if only I knew.

You're probably right. PRs are welcome for both examples, and adding the boilerplate code. Note that Try Thermite already includes the boilerplate in the Thermite.Try module.

I am going through the longer path, reading and learning as much as I can about the core libraries. When/if I get comfortable enough with DOM, Aff, and so on, I might come back and write a friendlier template.