Feat: Cache text only option

Description
This pull request addresses issue #25912, which suggests that caching only the text content of messages would be more efficient than caching the entire serialized message.
Summary of Changes:

Introduces a new attribute, cache_text_only, to control caching behavior.
When cache_text_only is set to True, the cache will store only the text content of the message, rather than the entire serialized message.

Rationale:
Storing only the text content of messages can lead to significant improvements in cache efficiency and performance. By focusing on just the text, we reduce the cache size and potentially decrease retrieval times.
Implementation Details:

Added the cache_text_only attribute to the relevant configuration.
Updated cache handling logic to check the value of cache_text_only and store only the message text if the attribute is True.
Ensured backward compatibility by defaulting cache_text_only to False, thus preserving the existing behavior.

Some benchmarking may be required to quantify the actual performance gains.

Okay
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Zeeland @.>
Sent: Tuesday, September 3, 2024 3:05:22 PM
To: langchain-ai/langchain @.>
Cc: Mohammad Mohtashim Khan @.>; Author @.>
Subject: Re: [langchain-ai/langchain] Feat: Cache text only option (PR #25926)
CAUTION: This email has originated from outside of LUMS. Do not click links or open attachments unless you recognize sender’s email address and know the content is safe.
@Undertone0809 commented on this pull request.

Performance impact: Some benchmarking may be required to quantify the actual performance gains.
You may want to consider some boundary cases, such as how the message content will behave if it is empty or very long.
Cache consistency: You need to ensure that cache consistency is not affected when switching cache_text_only Settings.
Documentation update: Need to add docs.

I personally do not recommend this usage, adding complexity to the API usage. Given that LangChain is a general-purpose framework, it may be more important to provide flexibility. But at the same time, we have to weigh the costs of increased complexity.
Suggest:

Consider implementing a more general cache preprocessing hook that allows users to customize how cached content is generated. This satisfies both users who want to cache only text and users who need more control.
At the same time, several preset caching strategies can be provided, such as "text only", "full object", etc., to meet common requirements.

—
Reply to this email directly, view it on GitHubhttps://github.com/langchain-ai/langchain/pull/25926#pullrequestreview-2276984450, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKZFN67HSVKURAEK7RGASKLZUWCWFAVCNFSM6AAAAABNPETADKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZWHE4DINBVGA.
You are receiving this because you authored the thread.Message ID: @.***>

leaving as needs support and can return if folks have some good motivating examples.
In general, I think if you want custom caching behavior like this, it doesn't make sense to use the main LC caching abstraction. Keeping the cache contents in sync with "which caching strategy you're using" will create a lot more confusing errors than usefulness it provides imo

@efriis keeping it open then.


Files page displays 404 while ipfs files exist in console

Hello,
After some days and for no particular reason the "Files" page in ipfs-desktop (as well as the ipfs conpanion) displays a "/ 404" as breadcrumb and the file list remains empty.
It doesn't seem to be a problem with my ipfs repo since I'm able to properly perform files commands from the console:

ipfs files ls
ipfs files cat /some_file

I'm using the Revision 1eef40c version.
To Reproduce
No idea
Expected behavior
It should display files
Screenshots

Desktop (please complete the following information):

Ubuntu 16.04
Chrome
Version 80.0.3987.149 (Build oficial) (64 bits)

Apparently I was wrong when I said that the repo ipfs was correct.
While ipfs files ls works fine ipfs files ls -l hangs.
For one particular file I'm unable to retrieve its cid.
This is rather an IPFS problem and it has nothing to do with the webui.
For information, I was able to recover all my files except the bad one and recreate a clean repo.
Still, in the webui, I was left with no clue about what was going on.
I think this issue could be closed if it's not possible to display a better information on the error than the 404 message.
Anyway, thank you for the webui (ipfs-desktop), I use it everyday.

@nlko Thanks for the kind words!
@hacdias @olizilla If it's possible to provide more granular guidance than just a generic 404 message, let's circle; I'd be happy to iterate on some possible message text.

:+1: for improving the 404 "Not found" state
It should be more prominent, and also more explicit:

should show what resource was not found (with full content path)

As a data point, user report copied from https://github.com/ipfs/go-ipfs/issues/7604:

Hello, at first my ipfs can import, but after some uploads it turns to /404 and no import button anymore, anyone experiencing the problem?

Right now user is unable to tell what went wrong and why "404" is displayed.
If a full content path (either MFS, /ipfs/ or /ipns that was not found was displayed, then it would be much easier to  self-service.


Fix bootstrap link to work on HTTPS

The demo page at https://codeseven.github.io/toastr/demo.html does not load the Bootstrap CSS since it is loaded over HTTP while the page itself is served over HTTPS.
This is how the demo page appears in Chrome:

I have updated the bootstrap link to be able to load over both HTTP and HTTPS.

Thanks for the PR!

You're welcome. I'm glad to contribute @TimFerrell


Not picking up a commit?

Dropping the full function I'm using to test branch creation and pulling diffs. Seemed to work in the terminal but moving to code (python)
Outputs:
Performing Doltgres operations:
Starting on branch: main
Created new branch 'new-feature' in database 'test_db'
Switched to branch: new-feature
Added row in random_table for A12X 9999 in database 'test_db' on branch 'new-feature'
Error performing Doltgres operations on database 'test_db': nothing to commit (errno 1105) (sqlstate HY000)
def perform_doltgres_operations(db_name):
config = {**DOLTGRES_CONFIG, "dbname": db_name}
try:
conn = connect_db(config)
conn.autocommit = False
cur = conn.cursor()
    # Check current branch
    cur.execute("SELECT active_branch()")
    original_branch = cur.fetchone()[0]
    print(f"Starting on branch: {original_branch}")

    # Create new branch
    new_branch = 'new-feature'
    cur.execute(f"CALL dolt_branch('{new_branch}')")
    print(f"Created new branch '{new_branch}' in database '{db_name}'")

    # Switch to the new branch
    cur.execute(f"CALL dolt_checkout('{new_branch}')")
    cur.execute("SELECT active_branch()")
    current_branch = cur.fetchone()[0]
    print(f"Switched to branch: {current_branch}")

    # Ensure the random_table exists
    cur.execute("""
        CREATE TABLE IF NOT EXISTS random_table (
            "A12X" INTEGER PRIMARY KEY,
            "B_Y7" VARCHAR(255),
            "Q9ZP" INTEGER,
            "MTR34" NUMERIC(10, 2),
            "NXM12" VARCHAR(255),
            "ZXC89" VARCHAR(255),
            "LPO21" VARCHAR(255),
            "JDW99" DATE
        )
    """)

    # Add new row to random_table without using UPSERT
    cur.execute("""
        INSERT INTO random_table ("A12X", "B_Y7", "Q9ZP", "MTR34", "NXM12", "ZXC89", "LPO21", "JDW99")
        VALUES (%s, %s, %s, %s, %s, %s, %s, %s)
    """, (9999, 'NewProduct', 30, 199.99, 'NewCat', '20%', 'NewBrand', '2024-12-31'))
    print(f"Added row in random_table for A12X 9999 in database '{db_name}' on branch '{new_branch}'")

    # Check for changes before committing
    cur.execute("SELECT * FROM dolt_status")
    status = cur.fetchall()
    if status:
        cur.execute("CALL dolt_commit('-am', 'Added row for A12X 9999 on new-feature branch')")
        print(f"Committed changes on '{new_branch}' branch")
    else:
        print(f"No changes to commit on '{new_branch}' branch")

    # Switch back to the original branch
    cur.execute(f"CALL dolt_checkout('{original_branch}')")
    cur.execute("SELECT active_branch()")
    current_branch = cur.fetchone()[0]
    print(f"Switched back to branch: {current_branch}")

    # Get diff
    cur.execute(f"SELECT * FROM dolt_diff('{original_branch}', '{new_branch}', 'random_table')")
    diff = cur.fetchall()
    print(f"\nDiff between {original_branch} and {new_branch}:")
    for row in diff:
        print(row)

    # Get detailed diff summary
    cur.execute(f"SELECT * FROM dolt_diff_summary('{original_branch}', '{new_branch}')")
    diff_summary = cur.fetchall()
    print("\nDetailed diff summary:")
    for row in diff_summary:
        print(row)

    conn.commit()
except psycopg2.Error as e:
    print(f"Error performing Doltgres operations on database '{db_name}': {str(e)}")
finally:
    if 'cur' in locals():
        cur.close()
    if 'conn' in locals():
        conn.close()

dolt_commit('-a') will add not add untracked (never committed) tables. This replicates the git behavior.
To add commit new tables, either use dolt_commit('-A') (capital A is a dolt extension that adds untracked tables), or use dolt_add('.') first to add untracked tables to staging.

Fixed. It was my code


add maxReachedStep to EasyStepper and isAlreadyReached to BaseStep

Description:  To navigate directly only between the already reached steps. The steps that have not yet been reached cannot be reached by clicking on the step. Only by indirectly changing the "activeStep" e.g. via external forward and back buttons

Thanks @thfr69 for your contribution

Dear @ma7moud3osman ,
sorry but I forgot to implement the appropriate methods to handle the title and icon color analogously to changing the background and border color. I would create a new pull request.


[Facebook] Broadcast API

Adds facebook Broadcast API

@ouadie-lahdioui beat me to it! hehe

Oops i didn't see it :(


Existing codebase is crashing on Xcode 16 developer beta.

I just wanted to let you know.
I will see when I fix my issue. I can figure out why its is crashing. As of now I have this

Hi, Alok. How is the current status of this issue?


Update speaker profile images

Please use the profile images that are collected in Google Drive @nisarhassan12

[x] Update Stephen o'grady
[x] update Borja Burgos

Fixed in https://github.com/gitpod-io/devxconf.org/commit/6a24a7eaacfa8238dc4d08d0e0d55d5f84f2726e


install on linux?

can this module install on ubuntu?

No, for now, but I will working on that.
On Ubuntu, the version of tesseract binary of apt-get source is 3.04, which is out-dated.
And version 3.04 will cause a problem that pkg-config could not find the location of headers files of tesseract, see tesseract-ocr/tesseract#241 .

provide a Docker image may be a good choice

Which tesseract version does penteract expect? I've tied 4.00.00alpha, but got:
make: Entering directory '/databank/mega/development/js/img_recognition/node_modules/penteract/build'
  CXX(target) Release/obj.target/penteract/cc/penteract.o
  CXX(target) Release/obj.target/penteract/cc/ocr.o
In file included from /usr/local/include/tesseract/ltrresultiterator.h:26:0,
                 from /usr/local/include/tesseract/resultiterator.h:26,
                 from /usr/local/include/tesseract/baseapi.h:31,
                 from ../cc/ocr.h:4,
                 from ../cc/ocr.cc:1:
/usr/local/include/tesseract/unichar.h:164:10: error: ‘string’ does not name a type
   static string UTF32ToUTF8(const std::vector<char32>& str32);
          ^
penteract.target.mk:100: recipe for target 'Release/obj.target/penteract/cc/ocr.o' failed
make: *** [Release/obj.target/penteract/cc/ocr.o] Error 1
make: Leaving directory '/databank/mega/development/js/img_recognition/node_modules/penteract/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/i/.nvm/versions/node/v8.6.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:125:13)
gyp ERR! stack     at ChildProcess.emit (events.js:213:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.4.0-101-generic
gyp ERR! command "/home/i/.nvm/versions/node/v8.6.0/bin/node" "/home/i/.nvm/versions/node/v8.6.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /databank/mega/development/js/img_recognition/node_modules/penteract
gyp ERR! node -v v8.6.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!


INC quantization tutorial

Description
This change extends MKLDNN quantization tutorial with quantization and auto-tuning using Intel® Neural Compressor.

@mxnet-bot run ci [unix-cpu, unix-gpu, website]

@mxnet-bot run ci [unix-cpu, website]


Awesome

How close are you to a 1.0 release?  What features are currently missing?

It's almost there. I just have a few little bugs and I want to add a search feature.
Also, ideally I should include some examples w/ REST calls instead of local storage.
To really make it complete, I want to make a backend that works w/ the same model but that could be a different project all together.
It is mature enough for you can start using it. Please feel free to file any bug you find.
Thanks,
Olivier

... and I have to improve the documentation.

@evoluteur a little question:
The AGPL means that if I improve the library in some way, I'm forced to make that publicly available, but that doesn't cover my project right? not all the source code of my app, but evolutility's only. I'm ok or nope? thanks a lot for this BTW!


Drop all mastered DRM fds on exit

The helper process, that handles privileged DRM operations for the
parent process, now remembers all file descriptors it acquired DRM
mastership over. This allows it to release them properly on
termination, even if the parent process crashes.
This fixes an issue where the virtual console locks up if sway crashes or if I kill it with meta+shift+e (at least on my system).

LGTM

While working on the changes proposed by @ascent12 I noticed that the issue might be related to the Xwayland backend. Since I didn't open any X windows when testing the patch it looked to me like the issue was fixed.
I'll close the push request for now and investigate further. Sorry for not testing the patch more thoroughly

For reference: The virtual console lockup happens due to a segmentation fault in sway (https://github.com/swaywm/sway/issues/2149). I'm not sure why this segmentation fault causes a console lock up, but googling around suggests it could be a bug in the graphics driver.

I'm not sure why this segmentation fault causes a console lock up, but googling around suggests it could be a bug in the graphics driver.

From what I've seen, a compositor segmentation fault leaves the session child behind and doesn't cleanup properly.

I'm not sure why this segmentation fault causes a console lock up, but googling around suggests it > > could be a bug in the graphics driver.

From what I've seen, a compositor segmentation fault leaves the direct session child behind and doesn't cleanup properly.

If you're referring to #1073, this doesn't fix it. I even tried terminating sway from another virtual console using swaymsg, made sure that no sway process was alive any more and used fuser to make sure that /dev/dri/card0 was not opened by anyone. The system still locked up when I changed back to the virtual console where I started sway.


Automate quick guide generation

Move the python source/quickguides/generate_quick_guides.py # Run if quick-guide files were updated step on docs/source/contributing.rst into the automated documentation building (probably at https://github.com/E3SM-Project/e3sm_diags/blob/master/.github/workflows/build_workflow.yml#L128?)
The correct workflow currently is the following:

Modify docs/source/quickguides/generate_quick_guides.py and/or docs/source/quickguides/generate_quick_guides.py
Run python docs/source/quickguides/generate_quick_guides.py to generate:

docs/source/quickguides/quick-guide-acme1.rst
docs/source/quickguides/quick-guide-compy.rst
docs/source/quickguides/quick-guide-cori.rst
docs/source/quickguides/quick-guide-lcrc.rst

However, those four generated files currently exist in the repo. They can be (and have been) edited independently, which disrupts the above workflow. It would be better for those generated files to not exist in the repo and have the automated documentation handle the file generation.

@tomvothecoder Is addressing this as simple as adding python source/quickguides/generate_quick_guides.py after https://github.com/E3SM-Project/e3sm_diags/blob/master/.github/workflows/build_workflow.yml#L128?

The lcrc quick guide is missing on master doc: https://e3sm-project.github.io/e3sm_diags/_build/html/master/index.html Just want to make sure they will be brought back by this PR. Also the links to Crysalis and Anvil need to update in README due to the split of LCRC quickguide.

@chengzhuzhang Thanks, yes I'm discovering that in testing this PR. I'll be sure to fix that before merging!

Closed #511 in favor of #513, which still fixes the errors mentioned above.


refactor code in server.js

All the router are implemented in server.js which makes the app clunky. Create a seperate routes directory to make the code more organized.

hey :)
could you assign this to me?

Hey @moonpatel I'd like to contribute!

Hey @moonpatel I've created a PR


API docs and cheat sheet

We got strong feedback from friends preview that we need to have the API reference docs as well as a API cheatsheet so folks can quickly create Plot charts.

The API docs are covered by the README (and notebooks); the cheat sheet is covered by #329.


Add more Raspberry Pi Pico LCD Shields

Fixes #233 and also brings many improvements in shield documentation:

Pico LCD 0.96 shield by Waveshare
Pico LCD 1.3 shield by Waveshare
Pico LCD 1.44 shield by Waveshare
Pico LCD 1.8 shield by Waveshare
Pico ResTouch LCD 2.8 shield by Waveshare

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.
Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Found the new shields here: https://bridle.tiac-systems.net/ghpr/doc/PR-238/bridle/boards/shields/rpi_pico_lcd/doc/index.html

CONVERTED TO DRAFT see review commits in PR #243

CONVERTED TO DRAFT see review comments in PR #243

done –> READY FOR REVIEW


UHV: backward compatibility to allow malformed URL encoding

Commit Message:
Implement envoy.reloadable_features.uhv_allow_malformed_url_encoding that allows malformed %-encoded triplets. Then the flag is set to false UHV rejects requests with malformed %-encoded triplets in URL path.
Part of #26642
Risk Level: Low, build flag protected
Testing: Unit Test
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.uhv_allow_malformed_url_encoding

/wait

@yanavlasov is it correct that setting the runtime value to false is a more secure configuration?
- area: uhv
  change: |
    Allow malformed URL encoded triplets in the default header validator. This behavior can be reverted by setting runtime flag
    ``envoy.reloadable_features.uhv_allow_malformed_url_encoding`` to false, in which case requests with malformed URL encoded triplets
    in path are rejected. This setting is only applicable when the Unversal Header Validator is enabled and has no effect otherwise.


Bleed label issue

(Thanks @lostanlen for noting this)
The following stems have bleed, but are not labeled as having bleed:
BrandonWebster_DontHearAThing_STEM_02.wav
ClaraBerryAndWooldog_Boys_STEM_05.wav
LizNelson_ImComingHome_STEM_02.wav

Hi,
Thank you for your reactivity.
Also, listening to
Lushlife_ToynbeeSuite_STEM_12.wav
you'll hear some faint, albeit noticeable, hi-hat sound over the guitar.
Yet the song is labeled has having no bleed.

@lostanlen hmm I agree that Lushlife_ToynbeeSuite_STEM_12.wav has bleed. The rest of the stems for that multitrack don't (I don't think), and since I made has_bleed a multitrack level annotation, I'm hesitant to mark the whole thing as having bleed.
Maybe, for the next version of the annotations, it would be reasonable to move has_bleed to the stem level instead of the track level. What do you think?

That is exactly my latest thought on the subject.
I use audio at the stem level for single-label instrument recognitiion, and must ensure that my stems have no bleed. That said, if there is bleed in another stem of the same track, but "my" stem is unaffected, it is too conservative to discard all stems altogether.
So having 'has_bleed' annotations at the stem level would definitely fit my use case.

ok, I'm opening a separate issue to include this for v1.2.

I stumbled upon this bleed stem:
TheScarletBrand_LesFleursDuMal_STEM_08.wav
Again, other stems are not affected, which makes #27 all the more crucial.

I found two more bleeding stems:
ClaraBerryAndWooldog_Boys_STEM_01.wav
ClaraBerryAndWooldog_Boys_STEM_05.wav
The other 7 stems are not affected.

CelestialShore_DireForUs vocals have bleed too.

I created a log of each of these in ERRATA.md
Closing this issue.


I need help as vscode, don't want to show the syntax errors.

VS Code Version:1.53.1

OS Version:Windows 10 Pro

Steps to Reproduce:
1.Open the VSCode
2.And strart coding.

Does this issue occur when all extensions are disabled?: Yes/No
YES

I am using a clean version of VSCode, and writing wrong syntax does not show me where the error is.
Here is a video:
https://user-images.githubusercontent.com/72398757/107584325-83acc280-6bfc-11eb-8389-1b580081a1ba.mp4

@MohaMBS you need to install a C# extension from the marketplace to make this work. If you have install it then please report issues with the extension here: https://github.com/OmniSharp/omnisharp-vscode

I know and I had it. But it still didn't work...
I leave you my solution which works, reinstall / factory reset windows 10.
The problem is Windows.... Agian :(


Express Server and (React) Routes not injecting JS

I am confguring a fresh webpack setup with react router and express right now and intend to use your awesome html-webpack-plugin.
I've setup all my routes (/ and * redirects to /404) and server and I wonder how to setup the server correctly to receive the correct routes.
When I try to go to http://localhost:3000/something f.e., I am getting just the raw HTML template  without the injected JS and stuff that I've configured in the webpack.config.js.
Following setup
webpack.config.js
...
      new HtmlWebpackPlugin({
        template: PATHS.src + '/index.html'
      })
...

server.js
const Express = require('express');
const path = require('path');
const webpack = require('webpack');
const webpackDevMiddleware = require('webpack-dev-middleware');
const webpackHotMiddleware = require('webpack-hot-middleware');
const config = require('./webpack.config');

const app = new Express();
const port = process.env.PORT || 3000;

const compiler = webpack(config);

app.use(webpackDevMiddleware(compiler, {
  noInfo: true
}));

app.use(webpackHotMiddleware(compiler));

app.use('/', function(req, res, next) {
  res.sendFile(path.join(__dirname, 'src') + '/index.html');
});

app.listen(port, function(error) {
  if (error) {
    console.error(error);
  } else {
    console.info('The express server is running at http://localhost:%s\n', port);
  }
});

src/index.html
<!DOCTYPE html>

    <meta charset="utf-8">
    <title>React Boilerplate</title>

routes/index.js
...
export default (
  <Route path="/" component={App}>
    <IndexRoute component={HomeView} />
    <Route path="/404" component={NotFoundView} />
    <Redirect from="*" to="/404" />
  </Route>
)

What do I need to setup to get routings working with html-webpack-plugin? I appreciate every help.

Please ask webpack middleware questions on stackoverflow. Webpack middleware can't be used together with res.sendFile(path.join(__dirname, 'src') + '/index.html');


Release 1.0

Let's do this thing!

@jamessimone feel free to merge #64 so it gets included in this release

@jamessimone I'm ready to merge this thing to master - let me know if you have any last minute objections!


Cross-Compatible JSON Body Exclusion Ruleset for Different ModSecurity Versions

Hello everyone,
Description:
I've come across an issue while working with different versions of ModSecurity (v2 and v3) and their respective variable names when parsing JSON bodies using the JSON body processor.
Problem:
The crux of the problem lies in the fact that v2 and v3 of ModSecurity employ distinct variable names during JSON body parsing. This discrepancy becomes particularly challenging when attempting to create an exclusion ruleset that works seamlessly across all ModSecurity versions. Currently, the only two viable options are duplicating ctl:remove* actions or duplicating rules. However, both of these alternatives demand more CPU consumption than necessary (other than possible -still unknown- security implications/bypass).
Example:
To illustrate this issue further, consider the following JSON body:
{"foo": [{"bar":"payload"}]}

In v2, the corresponding variable name would be: ARGS:foo.foo.bar
While in v3, it becomes: ARGS:json.foo.array_0.bar
If I'm not wrong, this means that I need a rule exclusion like:
SecRule REQUEST_URI "@beginsWith /mypath" "id:1234,\
  ctl:ruleRemoveTargetByTag=OWASP_CRS;ARGS:foo.foo.bar,\
  ctl:ruleRemoveTargetByTag=OWASP_CRS;ARGS:json.foo.array_0.bar,\
  ..."

If the array within the "foo" object in my example comprises 100 entries, it's quite clear that this would necessitate either 200 ctl actions or two distinct rules.
Are there other ways to do this?
If not: Proposed Solution

add an ARGS:json variable like v3 on v2
abstract the ARGS names on rule definition in order to have only 1 syntax
use JSON path syntax like: $.foo[0].bar or ARGS:json.foo[0].bar and would be awesome an ARGS:json.foo[].bar to select all entries of the "foo" array

Hi @theMiddleBlue ,
Another option could conceivably be to structure the exclude as a regex. E.g. something like:
/^(json\.)?foo\.((foo|array_0)\.)bar$/

Just doing a quick check with v3, It looks like one cannot currently do this with ctl:ruleREmoveTargetByTag. In principle, regex exclusions are supported via SecRuleUpdateTargetByTag (although current parser restrictions mean a couple of important regex special characters are not allowed, which may limit its usefulness even here).

I initially considered using regex, but I came to realize that v3 doesn't currently support it with ctl:ruleRemoveBy*. Frankly, this restriction is posing quite a challenge for us when it comes to excluding rules for APIs that heavily rely on JSON bodies. I'm curious, is it completely unfeasible to align v2's JSON variable names with those in v3?


Ability to change path separator in ResponseUrlScroller

While trying to use generic extractor i have problem with using on Microsoft Graph API. Problem is in pagination section. Due documentation https://docs.microsoft.com/en-us/graph/paging Microsoft is using next page url in response. Problem is that dot (.) is character that is ResponseUrlScroller using to parse nested object parameters. So there is no way to use:
"pagination": {
    "method": "response.url",
    "urlKey"<EMAIL_ADDRESS>},

This solution is trying to add delimiter parameter to JSON configuration of pagination

I'm merging this PR and I'm going to modify ex-generic so this change will be reflected there. We will inform you.

@Usetreno-dev

New version 3.10.0 of generic-extractor was release: https://github.com/keboola/generic-extractor/releases/tag/3.10.0
New configuration parameter delimiter was added to docs (old version can be cached in browser): https://developers.keboola.com/extend/generic-extractor/configuration/api/pagination/response-url/

I try it, and it works! Thank you a lot.


Include Vulkan backend

It would be nice to have also a wrapper for the "native" Vulkan backend.
Maybe this Vulkan python wrapper could be of some help.

Yes it would be interesting if the Vulkan backend could be accessible as well.
However I have no use for the Vulkan backend, so I can't work on this and it'll have to come from someone else.

I'd be interested in this as well, I don't have time at the moment but perhaps in some future..


DropdownMenu opens Dialog leads to non-clickable page

Describe the bug
When I set inside my DropdownMenu event handler a signal to open a Dialog, the page stays non interactive after I close the Dialog. When I set the same signal when DropdownMenu is not opened, everything works as expected.
Reason (probably)
It seems that DropdownMenu and Dialog both sets style="pointer-events: none" to the <body> element. And as soon as the user closes these, the body gets it's previous style value.
And this seems to be the problem: as DropdownMenu doesn't resets the style on time before Dialog sets it as well. And Dialog seem to reset it after closing to still pointer-events: none as it read it like this from before.
When I set my signal to open the Dialog with a timeout of 1ms, everything works.
To Reproduce
const App = () => {
  const [dialogDeleteOpen, setDialogDeleteOpen] = createSignal(false);
  const onDelete = () => {
    setDialogDeleteOpen(true);
    // this is a hack which works:
    // setTimeout(() => setDialogDeleteOpen(true), 1);
  }
  return (
    <TaskListMenu onDelete={onDelete} />
  );

  <Show when={dialogDeleteOpen()}>
    <DialogSureToDelete
      onCancel={() => setDialogDeleteOpen(false)}
      onDelete={props.onDelete}
    />
  </Show>
}

const Menu = (props: { onDelete: () => void }) => {
    return (
        <DropdownMenu.Root placement="bottom-end">
            <DropdownMenu.Trigger>...</DropdownMenu.Trigger>
            <DropdownMenu.Content>
                <SheetListItemMenuItem text="Delete" onSelect={props.onDelete} />
            </DropdownMenu.Content>
        </DropdownMenu.Root>
    );
};

Desktop: Arc (Chromium)
"@kobalte/core": "^0.12.1"

Thanks for the report!


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.9 to before v5.10.54",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=5fcfb6d0bfcda17f0d0656e4e5b3710af2bbaae5",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=115e4f5b64ae8d9dd933167cafe2070aaac45849"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "5fcfb6d0bfcda17f0d0656e4e5b3710af2bbaae5",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "115e4f5b64ae8d9dd933167cafe2070aaac45849",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "usb: hso: fix error handling code of hso_create_net_device\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.10.54 by commit 115e4f5b64ae8d9dd933167cafe2070aaac45849, it was introduced in version v5.9 by commit 5fcfb6d0bfcda17f0d0656e4e5b3710af2bbaae5. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001243


Can't load custom linters

Hey!
I'm trying to develop a custom linter and use as plugin_gems dependency, but I get this error when I run:
Unable to load linter plugin gem 'scss_lint_plugin_example'. Try running `gem install scss_lint_plugin_example`, or adding it to your Gemfile and running `bundle install`. See the `plugin_gems` section of your .scss-lint.yml file to add/remove gem plugins.

I created a repo that uses the default example to show the error reproduced. One other thing, if I try importing the directory instead of using the gem, it works properly.

Hey @renancouto,
Have you actually installed the gem plugin with gem build scss_lint_plugin_example.gemspec && gem install scss_lint_plugin_example-0.0.1.gem (substituting the correct version) so that require 'scss_lint_plugin_example' works?
If you're actively developing the gem and using Bundler you can also run bundle config local.scss_lint_plugin_example /path/to/local/git/repository in the repository for which you're using SCSS-Lint + the plugin. See http://bundler.io/v1.12/man/bundle-config.1.html#LOCAL-GIT-REPOS for documentation.

Hey @renancouto,
Have you actually installed the gem plugin with gem build scss_lint_plugin_example.gemspec && gem install scss_lint_plugin_example-0.0.1.gem (substituting the correct version) so that require 'scss_lint_plugin_example' works?
If you're actively developing the gem and using Bundler you can also run bundle config local.scss_lint_plugin_example /path/to/local/git/repository in the repository for which you're using SCSS-Lint + the plugin. See http://bundler.io/v1.12/man/bundle-config.1.html#LOCAL-GIT-REPOS for documentation.


Does detours need huge extra memory?

     I use **DetourCreateProcessWithDll** to create my app process and find the process use **1.6g** memory in win task-manager view. Normally, my app use **0.8g** memory in win task-manager view.
     It's confuse that i can only catch the **0.8g** memory using (by hooking **NtAllocateVirtualMemory** and **VirtualAlloc** ) when use **DetourCreateProcessWithDll**.
     I want to know what's the problem?

@jizhideyu if you use sucha formatting to force everybody to give up reading your message looks like you achieved your goal..

@dstd I'm sorry. I have edited my comment.

Not an expert by any means, but would this have something to do with it?

After the detour DLL has been loaded, it should reverse changes to the in-memory import table by calling DetourRestoreAfterWith. To facilitate reversing these changes, DetourCreateProcessWithDll copies relevant reversal data into a payload in the target process using the DetourCopyPayloadToProcess API. The loaded DLL should call the DetourRestoreAfterWith API to restores the contents of the import table.


chore: bump deps, drop python 3.7 and support python 3.12

If installing with ESP-IDF, it is crucial to align ESP-IDF python dependencies at https://github.com/espressif/esp-idf/blob/master/tools/requirements/requirements.core.txt, to avoid downgrading.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add functional regression metrics

What does this PR do?
Add functional regression metrics. Discussed on slack.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @rohitgr7! Thanks for opening this PR.

In the file pytorch_lightning/metrics/functional/regression.py:

Line 45:2: E121 continuation line under-indented for hanging indent
Line 78:2: E121 continuation line under-indented for hanging indent
Line 112:2: E121 continuation line under-indented for hanging indent

Do see the Hitchhiker's guide to code style

Please let me know if something needs to be changed. Will write tests once current changes get approved.

so far it looks good to me :rabbit:
cc: @justusschock @SkafteNicki

Changes until now also looks good to me, remember to update the functional docs with these new functions :)

Yeah, will add tests and make changes to docs tonight✌

Please let me know any other tests needed to be added or any doc updates.

@rohitgr7 PR looks great, if you could solve the merge conflicts (most related to the merge of #2483) I think this is ready to go :)

@SkafteNicki Done :v:


[MM-31580] Fix call to getChannel to use new parameter format

Summary
makeGetChannel was changed to take an object including an id, but this call to it wasn't updated, causing a bug in notifications. This PR fixes that call.
Ticket Link
https://mattermost.atlassian.net/browse/MM-31580

@hmhealey Kind reminder to review this PR for today's v5.31 code freeze deadline.

@hmhealey Kind reminder to review this PR for today's v5.31 code freeze deadline.

Cherry pick is scheduled.

Cherry pick is scheduled.

/cherry-pick cloud

/cherry-pick cloud

Cherry pick is scheduled.

Cherry pick is scheduled.


Add existing kms example

Description
Add example to use existing kms instance.
Types of changes in this PR
Changes that affect the core Terraform module or submodules

[ ] Bug fix
[ ] New feature
[ ] Dependency update

Changes that don't affect the core Terraform module or submodules

[x] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other

Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Add example to use existing kms instance.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

/run pipeline

/run pipeline

do we need pr tests for it? how long does it take to create resources?

@akocbek The default example already cover the scenario of creating a key protect instance and testing the key creation. The new example is to showcase on how it can be either used with a HPCS or even a key protect.

/run pipeline

/run pipeline


Ensure Docker Compose uses Runnable JAR (Angular)

References

Requires https://github.com/DSpace/DSpace/pull/9505

Description
Per the changes in https://github.com/DSpace/DSpace/pull/9505, this PR updates the Docker Compose scripts in dspace-angular in the following ways:

Updates all docker compose scripts to use Runnable JAR (similar to https://github.com/DSpace/DSpace/pull/9505)
Minor bug fixes to loadsql Docker Compose scripts as a followup to #2966.  These were noticed when I compared the Docker Compose scripts in DSpace/DSpace to those in DSpace/dspace-angular

NOTE: Because this PR modifies docker-compose-ci.yml to use a Runnable JAR, all e2e tests will fail until https://github.com/DSpace/DSpace/pull/9505 is merged.   This is because the e2e tests will now utilize Docker Compose scripts that use the Runnable JAR instead of a Tomcat image.

Tests now pass because https://github.com/DSpace/DSpace/pull/9505 was merged.
Merging this immediately, as these Docker Compose scripts will no longer work until this is merged.


Add comma in package.json

@mrmrs I accidentally merged this instead of the PR in tachyons-background-size. Just found a typo (missing comma) so I'm correcting it here.

Tachyons v5 will become a monorepo so this pull request is being closed, if the pull request is still relevant please open an pull request with the main repo https://github.com/tachyons-css/tachyons/ & link to this one.


[Android][iOS][Dev-tool] Unexpected behavior when xx where weex version is 0.aa.bb.cc

weex官网的实例页面经常挂掉，打不开啊~特别是下午四五点~‘等待dotwe.org的响应~’

感谢你的反馈，Weex目前是隶属于Apache Software Foundation的项目，因此在Gtihub渠道我们鼓励使用英文反馈问题。下面我将使用Google Trasnlate将你的问题翻译成英语，并以英语回答。

Question Description: The example page of the weex official website often hangs, can't open, especially at 4 or 5 in the afternoon ‘waiting for the response from dotwe.org~’

You may try http://editor.weex.io/, but I don't think this problem is about Apache Weex.
I will just close the issue.


what is virtualtext highlightgroup？

Expected behavior

i got virtualtext bg，its red in my own colorscheme， i want to set its ctermbg。can tell me whats it highlight

Here you can see the definitions:
https://github.com/neomake/neomake/blob/master/autoload/neomake/virtualtext.vim#L109-L112
The keys are new highlight groups defined by this plugin and the values are the highlight groups they're linked to by default.

@mhinz   thanks  a lot , i got it


Start drag and enddrag not working

Hi,
When  drag a body startdrag and enddrag are not fired. Is there any working examples for startdrag and end drag and how to use that? I am using the version 0.8.0

Those events are not available in 0.8.0, I suggest upgrading as that version is very outdated.

Which version i can you for drag??

Is there any examples of start drag and end drag?
I am having a code for start and end drag event as follows.
var engine = Engine.create({
render: {
element: document.getElementById("module"),
options: {
background: "rgba(0, 0, 0, 0)",
showAngleIndicator: false,
wireframes: false,
visible: false,
lineWidth: 0,
width: canvasWidth,
height: canvasHeight,
hasBounds: true,
showShadows: false,
}
}
});
engine.enableSleeping = false;
engine.positionIterations = 1;
engine.velocityIterations = 1;
// gravity direction
engine.world.gravity.x = 0;
engine.world.gravity.y = 0.5;

// add a mouse controlled constraint
var mouseConstraint = MouseConstraint.create(engine, {
    constraint: {
        stiffness: 0.01,
        render: {
            visible: false,
            lineWidth: 0
        }
    }
});

//Adding engine and mouseconstraint to world
World.add(engine.world, mouseConstraint);

//startdrag event
Events.on(engine, 'startdrag', function (event) {
console.log('start drag');
});
//end drag event
Events.on(engine, 'enddrag', function (event) {
console.log('end drag');
});

The events are fired on the mouseConstraint not the engine, see the docs.

Yeah it is working. Thank you.. But if i use this version some of the functionalities are not working... such as when i am trying to change the texture of a body the page becomes unresponsive


Request for vanilla example notebook

Wonderful paper. To see if I'm getting something very wrong this is my understanding of the two papers differences.
Transformer-Explainability
You generate the building blocks with relprop as an alongside function to propagate backward the relevancies.
This is LRP, working from the CAMs (Class Activation Mapping) backwards. So you propagate outputs to inputs. To back propogate you have to hard code in all the flow - i.e. all the concats and splits of data, eg when you have to diverge to cam1, cam2 then use /=2 for matrix multiplication then rejoin them in the clone during self attention. This is awkward, and is what you're referring to when you say 'LRP requires a custom implementation of all network layers.' in the MM paper.
Transformer-MM-Explainability
You work forwards and simply add the methods
get_attn
save_attn
save_attn_gradients
get_attn_gradients

and the hooks in the forward pass to save them. This makes tracking things far easier as you don't need to reverse engineer the flow.
Request
You have great alterations of the DETR, CLIP, LXMERT and VisualBERT repos allowing all the interaction coupling scores for the baselines and your method to be calculated and smoothly plug-in to the whole repo.
Could you provide an example using the forward pass formulation of Transformer-MM-Explainability on a Vanilla Transformer model (just your interaction scores, not all the other baseline methods) to act as a very simple demonstrative example which is single-modality, ideally a Jupyter notebook with comments.

Update
I'm wrong, you need the relprop still to get del y_t / del A in eq 5, MM paper.
Update 2
I found what I was describing in DETR/modules/layers.py::MultiheadAttention. Thank you.

I have the same question, is there a colab for Transformer-MM-Explainability on a Vanilla Transformer model (maybe VIT)? I believe this is important for comparing two methods. @hila-chefer
Thank you for your help.

Hi @oliverdutton and @betterze! First, thanks for your interest in our work.
I created a (colab notebook)[https://colab.research.google.com/github/hila-chefer/Transformer-MM-Explainability/blob/main/Transformer_MM_explainability_ViT.ipynb] with a ViT example per your requests. A few things worth noticing:

I used the code from our original repo so everything other than the method is exactly identical.
For the model, I used the (ViT_new.py)[https://github.com/hila-chefer/Transformer-Explainability/blob/main/baselines/ViT/ViT_new.py] model, which does not in any way implement LRP so you can rest assured that there's no use of LRP there.
Notice that under the Implementation of rules section in the notebook, I implemented the rules exactly as appear in the code of this current paper, I added comments with rule numbers so it's easy to follow (you only need rules 5,6 since we have a pure self-attention architecture).
I think this covers everything you need to know about the notebook, but please feel free to ask for clarifications if needed.

Hila.

@hila-chefer Thanks a lot. It is very helpful.

Thank you so much @hila-chefer.
I see I was right, then I was wrong, I hadn't quite understood the one_hot.backward(retain_graph=True) was how you were getting del y_t / del A in eq 5 in MM paper I was worrying about. That is very neat.
I was a little lost, and the 'hand holding' of the notebook and stripped ViT_new.py is very useful, so thank you as I can understand it's not the most exciting thing to write for you.

@oliverdutton it was no bother at all, I'm really glad it helped you to better understand the paper :)
please feel free to ask questions :) I'd be very happy to help.

@hila-chefer Thank you for releasing the notebook. I am trying to implement the explanation method for Vanilla BERT, Roberta, and other text-transformer architectures. If possible, can you please share if there's any easier way to add the relevant modifications to the Hugging Face models? Thank You.


Improve user-facing error message when editing project titles in prohibited ways

Steps

Log in to osf.io.
Navigate to one of your projects.
Edit the project title so that your title is contained in angle brackets.
Notice the error message.

Expected behavior
An error message informing me that the project title cannot be updated as suggested due to presence of characters that are not allowed as entered. Or, we can simplify the message further, saying that the project title cannot be updated as suggested and to try entering another title.
Actual behavior
The user is met with "Unexpected Error: Bad Request," which is not a helpful message for our users.
Screenshot

Done.


Revert "Revert "Unify access to assets needed during rank-setup."" [run-systemtest]

Reverts vespa-engine/vespa#23964

@geirst PR Only the last commit is new


feat(fix alert_actions_base): fixed missing package name on import logging_helper

:tada: This PR is included in version 4.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix TPC-DS columns name

Why are the changes needed?

As there are some issues with the TPC-DS column name reported in https://github.com/trinodb/tpcds/pull/2, we need a workaround before the upstream patch release is available.
This PR also introduces the option useLegacyColumnName(default is true) to make the column name compatible with old TPC-DS queries.
Close #2679
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

why a column name is spark specific？

why a column name is spark specific？

TPC-DS 2.7 is adopted by Spark, but Spark does not update the table schema[1], I will raise a PR in Spark ASAP.
As a Spark data source connector, I think we should make the default schema be compatible with the latest Spark release version, otherwise, users may surprised that they can not run queries provided in the Spark repo[2].
[1] https://github.com/apache/spark/blob/v3.2.1/sql/core/src/test/scala/org/apache/spark/sql/TPCDSSchema.scala#L393
[2] https://github.com/apache/spark/tree/v3.2.1/sql/core/src/test/resources

Codecov Report

Merging #2702 (5ebf869) into master (5585dd0) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #2702      +/-   ##
============================================
+ Coverage     64.07%   64.09%   +0.02%
- Complexity      275      282       +7
============================================
  Files           407      407
  Lines         19080    19086       +6
  Branches       2568     2571       +3
============================================
+ Hits          12226    12234       +8
+ Misses         5704     5699       -5
- Partials       1150     1153       +3

Impacted Files
Coverage Δ

...ache/kyuubi/spark/connector/tpcds/TPCDSTable.scala
72.09% <85.71%> (+4.52%)
:arrow_up:

...ache/kyuubi/operation/KyuubiOperationManager.scala
83.60% <0.00%> (-1.64%)
:arrow_down:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
69.33% <0.00%> (+1.33%)
:arrow_up:

...he/kyuubi/spark/connector/tpcds/TPCDSCatalog.scala
41.17% <0.00%> (+5.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5585dd0...5ebf869. Read the comment docs.

I see they are spark test source codes. and I remember that I and some other contributors change that part a lot. so we do not need to follow that I guess

Changed useLegacyColumnName default value to false and regenerated TPC-DS queries by dsqgen 3.2.0

do we need sql files in src/main?

do we need sql files in src/main?

I think we need, then we can share the queries with other modules.

which one will depend on this？

which one will depend on this？

All DS v2 connectors, kyuubi-spark-sql-engine, kyuubi-server(maybe)

which one will depend on this？

All DS v2 connectors, kyuubi-spark-sql-engine, kyuubi-server(maybe)

seems not available to me

The TPC-DS connector should be compatible with Spark 3.0+, because it implements a small set of DSv2 interfaces which supported by all Spark 3 versions.

you'd better re-implement it with java with your big ambitions

cc @zinking

Thanks, merging to master


Fix #95: fix evelope pulse tests

Fixed tests and did a little cleanup
Changed the cavity test to use ndiff instead of float comparison
Envelope tests are fixed, but still dont pass, this is because the LaserPulseEnvelope class needs to be updated to reflect the removal of the 'z_waist' class.

I switched to the branch and ran pytest from the top director. I got the following errors:
../../.pyenv/versions/3.7.2/lib/python3.7/subprocess.py:1522: FileNotFoundError ======================================================== short test summary info ======================================================== FAILED tests/envelope_test.py::test_instantiation - AttributeError: 'PKDict' object has no attribute 'z_waist' FAILED tests/envelope_test.py::test_eval_ex - AttributeError: 'PKDict' object has no attribute 'z_waist' FAILED tests/pulse_test.py::test_cavity_propagation - FileNotFoundError: [Errno 2] No such file or directory: 'ndiff': 'ndiff' FAILED tests/wavefront_sensor_test.py::test_propagation01 - FileNotFoundError: [Errno 2] No such file or directory: 'ndiff': 'ndiff' ===================================================== 4 failed, 15 passed in 59.38s =====================================================
Is this what we expect?

I switched to the branch and ran pytest from the top director. I got the following errors: ../../.pyenv/versions/3.7.2/lib/python3.7/subprocess.py:1522: FileNotFoundError ======================================================== short test summary info ======================================================== FAILED tests/envelope_test.py::test_instantiation - AttributeError: 'PKDict' object has no attribute 'z_waist' FAILED tests/envelope_test.py::test_eval_ex - AttributeError: 'PKDict' object has no attribute 'z_waist' FAILED tests/pulse_test.py::test_cavity_propagation - FileNotFoundError: [Errno 2] No such file or directory: 'ndiff': 'ndiff' FAILED tests/wavefront_sensor_test.py::test_propagation01 - FileNotFoundError: [Errno 2] No such file or directory: 'ndiff': 'ndiff' ===================================================== 4 failed, 15 passed in 59.38s =====================================================
Is this what we expect?

Yes, the ndiff installer is still in progress, so those are expected errors.


Update sbt-mima-plugin to 0.4.0

Updates com.typesafe:sbt-mima-plugin from 0.3.0 to 0.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "com.typesafe", artifactId = "sbt-mima-plugin" }]

labels: semver-minor

This need manual intervention to deal with https://github.com/lightbend/mima/issues/328.


Bug: Getting 403 Forbidden when trying to get_url 'https://get.sdkman.io'

Bug report
Hi, I'm running an ansible role to install sdkman in a docker container on an us-east-1 ec2 instance, and i'm getting 403 forbidden when doing a get_url with 'https://get.sdkman.io' as the url. I tried doing a curl as well and got the same error 403. This was working fine a week ago, so not sure what changed.
2020-10-23 20:04:20 TASK [okta.sdkman : Download SDKMAN] *******************************************
2020-10-23 20:04:20 fatal: [localhost]: FAILED! => {"changed": false, "dest": "/tmp/sdkman_script", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 403: Forbidden", "status_code": 403, "url": "https://get.sdkman.io"}
The ansible role we're running is based off of this one, and this is the line where it fails: https://github.com/Comcast/ansible-sdkman/blob/3773085be50f5bb3fe8a1030cf3275ee93d9e62a/tasks/install.yml#L63
To reproduce
curl https://get.sdkman.io from us-east-1 ec2 instance.
System info
(unable to even download it)

Hi @seanwang-okta!
Could you do a curl -v https://get.sdkman.io to get a little bit more context?

`
[ec2-user@ip-10-15-50-230 ~]$ curl -v https://get.sdkman.io

Rebuilt URL to: https://get.sdkman.io/
Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to get.sdkman.io (<IP_ADDRESS>) port 443 (#0)
ALPN, offering h2
ALPN, offering http/1.1
Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
successfully set certificate verify locations:
CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
TLSv1.2 (OUT), TLS header, Certificate Status (22):
TLSv1.2 (OUT), TLS handshake, Client hello (1):
TLSv1.2 (IN), TLS handshake, Server hello (2):
TLSv1.2 (IN), TLS handshake, Certificate (11):
TLSv1.2 (IN), TLS handshake, Server key exchange (12):
TLSv1.2 (IN), TLS handshake, Server finished (14):
TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
TLSv1.2 (OUT), TLS handshake, Finished (20):
TLSv1.2 (IN), TLS change cipher, Change cipher spec (1):
TLSv1.2 (IN), TLS handshake, Finished (20):
SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
ALPN, server accepted to use http/1.1
Server certificate:
subject: CN=*.sdkman.io
start date: May 30 00:00:00 2020 GMT
expire date: Apr 28 23:59:59 2022 GMT
subjectAltName: host "get.sdkman.io" matched cert's "*.sdkman.io"
issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA
SSL certificate verify ok.

GET / HTTP/1.1
Host: get.sdkman.io
User-Agent: curl/7.61.1
Accept: /

< HTTP/1.1 403 Forbidden
< Server: nginx/1.19.1
< Date: Fri, 23 Oct 2020 22:52:33 GMT
< Content-Type: text/html
< Content-Length: 153
< Connection: keep-alive
<

403 Forbidden

403 Forbidden
nginx/1.19.1

* Connection #0 to host get.sdkman.io left intact`

Hi @seanwang-okta, could you please DM me your external IP address on Slack? I've had to blacklist a number of IP addresses recently due to overuse of our API. I just want to rule out that yours isn't one of those.

hi @marc0der, i've messaged you in the sdkman slack.

Closing this issue for now.


feat: List Item Themes: Child elements color contrast

Type: feat
Platform: all
When using different themes for .item container, their child elements doesn't get proper color contrast with the item background.
Have you tried to use .item-assertive with an .item-note inside it?
Out of the box it looks very bad, the color contrast turn the note very hard to read.
I am attaching an codepen link to exploit more the problem.
http://codepen.io/thiagofelix/pen/PqNdLr?editors=110

Wow, yeah, that does look bad
Preventing developers from doing something that looks ugly is a rabbit hole I'm not sure we want to go down though. If we made sure that every possible combination of every feature looked well with every combination of every other feature, Ionic would be a lot more bloated and have far fewer features.
I think this is past the point we want to save developers from themselves, at least for now.


Can't schedule jobs with period greater than Java Int max value<PHONE_NUMBER>)

Causes: https://github.com/vikeri/react-native-background-job/issues/77
Since we use int in Java-land instead of long very big periods get rejected.
Solution: Check if RN-Java interop works with long and if so, refactor period to be a long instead.

@vikeri ,would like to know if these issue has been fixed
Thanks

@vikeri , i would like to clarify about the period of scheduling,
does it imply that if i set the period to 15 seconds, the job will run after 15 seconds, or it will run every 15 seconds.
Thanks


Creating a message type to access in the library

I see you have your message types, and can also see you have the card showing in the example. But when using Dialogflow to create responses, what does the library Message components expect to see to set its Message type? For instance, using the Default response, you are given two options, Text and Payload. Action on Google has many more options, but the library doesn't seem to work well with it, not being able to read its response type.
What Dialogflow response's should we use to allow for the library to extract the message type. Do you have an example?

@ElZombieIsra Was wondering if you could assist here? Just what to create in the response on Dialogflow that will allow the library to render those cards, carousels etc?

Hey guys.
So, this line it's what's determines the Message type for the intent.
We're checking several props that the API from DialogFlow sends to the library.
As for the Card, check the example code in this line and this widget
What I'm doing in the DialogFlow console inside the intent is adding a custom response pressing this icon

Then pressing "Facebook"

Then inside the "Facebook" tab, pressing "Add Responses"

After that, you select "Card"

And fill the inputs as you wish

Hope that helps. Let me know if we can close this issue and if you need anything else

That's very helpful! We originally tried Google Assistant as there were more responses to return. Was there a reason why ye didn't look at Google Assistant for response types?

Nevermind, thanks for your help, it's working as expected :)

Can you also give us a demo for suggestion chip from google assistance?

@bashiryousufy  Have you figure out for google assistance ??


chore: Create separate controller for Machine Termination Handling

Fixes #
Description
Create separate controller for termination handling so that we don't bottleneck machine launch and initialization/registration based on the termination of existing instances
How was this change tested?

make presubmit
Manual scale testing and perf testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

46 of 81 (56.79%)  changed or added relevant lines in 4 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 81.054%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/machine/garbagecollection/controller.go
4
5
80.0%

pkg/controllers/termination/controller.go
0
1
0.0%

pkg/controllers/machine/controller.go
2
4
50.0%

pkg/controllers/machine/termination/controller.go
40
71
56.34%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/machine/controller.go
2
60.32%

pkg/cloudprovider/types.go
3
83.12%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
6584

Relevant Lines:
8123

💛  - Coveralls


Are Glue Jobs/DevEndpoints Supported with Sparkmagic kernel?

Hello team,
Do you currently support AWS Glue Jobs/DevEndpoints? This will surely bring this product close to Databricks?

Are you asking if you can use this tool to schedule a notebook that will access a Glue dev endpoint? I think the answer is yes, but I haven't tried it.
This is exactly my question rather than using EMR.


[Bug]: Discussions missing

What happened?
Although u merged my PR to fix the links, the links for feature request, questions still don't work because this github repo don't have discussions enabled
How to reproduce the bug
try to click the buttons on feature request or question
for me i want to request the feature to make announcement to different panels. As some of my sites have multiple panels like a users panel, staff panels, vendor panels etc
and i from staff panel sometimes want to make announcement to users panel
Package Version
3.2.5
PHP Version
8.3
Laravel Version
11
Which operating systems does with happen with?
macOS, Windows, Linux
Notes
No response

thanks for your advice, i've enabled discussion forum.
i see what you needed, i will adding it to the backlog


Make null handler processable

to fix https://github.com/symfony/monolog-bundle/issues/335

Sorry but that seems more like a bug in the MonologBundle than in Monolog. It is misusing a handler.. There is a ProcessableHandlerInterface which can be checked before calling stuff like pushProcessor


Side bar Fix for gentelella

Gentelella shows sidebar which is not fixed with scroll , gives bad view , You can see the whitespace in the image .

@juslee , solved by PR #222.
After solving

Moving away from web app V1. Closing this issue therefore.


Add a brief help file

Documentation of the command and mappings.  Better documentation forthcoming.

Oh my gosh, while I was working on updating the documentation I didn't notice your similar contribution. You decide if you want to enrich the newly created documentation, or discard this contribution, for which I am equally grateful.


[Bug] Running mint node with docker fails

🐛 Bug
I am facing an issue when running the faucet locally with docker. I followed the steps in the documentation at https://github.com/libra/libra/tree/master/docker. Could you please help with this? Maybe I am doing something wrong?
To reproduce

run docker/mint/build.sh
run docker/mint/run.sh libra_mint:latest <IP_ADDRESS> 30307 info

**Stack trace/error message**

+ /opt/libra/bin/faucet-config-builder -o /opt/libra/etc -n -s
error: The argument '--seed <seed>' requires a value but none was supplied

USAGE:
    faucet-config-builder --nodes <nodes> --output-dir <output-dir> --seed <seed>

For more information try --help

## Expected Behavior

The mint node will be started correctly

## System information

**Please complete the following information:**
- Libra Version: latest
- Rust Version: 1.40.0
- Computer OS: Ubuntu 18.04

This was recently resolved.


Feature request: Connect the ariston product locally bypassing the cloud

As we seen recently, sometimes the Ariston cloud goes down causing a lot of trouble for who is using the integration through home assistant. It will be TOP if someone found the way to use the same integration in local mode only, so we are not bound to the cloud service.

@redstyle82  this is a separate topic with additional hardware to get/set data from bridgenet bus from your local equipment and fully avoid Ariston cloud.
You could start with this helpful links
https://github.com/wrongisthenewright/ebusd-configuration-ariston-bridgenet
https://github.com/komw/ariston-bus-bridgenet-ebusd and https://github.com/komw/ariston-bus-bridgenet-ebusd/issues/7
This should help at least for the first steps.


proxy_context_path does not work as expected

Describe the issue:
The configuration "proxy_context_path" which is toml equivalent for "ProxyContextPath" in XML based configs; is not working as expected. The carbon management console does not work due to a hardcoded CSRF guard javascript path. All the react web apps are not working because they have not taken this config into account.
Steps to reproduce
IS configs
[server]
hostname = "idp.wso2.com"
node_ip = "<IP_ADDRESS>"
base_path = "https://$ref{server.hostname}"
proxy_context_path = "auth"

[transport.https.properties]
proxyPort = 443

Nginx configs
server {
	listen 443;
	server_name idp.wso2.com;
	client_max_body_size 100M;

	root /usr/share/nginx/www;
	index index.html index.htm;

	ssl on;
	ssl_certificate /etc/nginx/ssl/server.crt;
	ssl_certificate_key /etc/nginx/ssl/server.key;

	location /auth/ {
		proxy_set_header X-Forwarded-Host $host;
		proxy_set_header X-Forwarded-Server $host;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header Host $http_host;
		proxy_read_timeout 5m;
		proxy_send_timeout 5m;

		proxy_pass https://<IP_ADDRESS>:9443/;
		proxy_cookie_path / /auth;
		proxy_redirect https://idp.wso2.com/ https://idp.wso2.com/auth/;

		proxy_http_version 1.1;
		proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection "upgrade";
	}
}

Generate certificates by following "Create SSL certificates" topic of https://docs.wso2.com/display/CLUSTER44x/Configuring+NGINX
Try logging into any of followings using the base URL as https://idp.wso2.com/auth/

carbon
user-portal (5.10.0)
myaccount (5.11.0)
console (5.11.0)

Environment information

Product Version:  IS 5.10.0, IS 5.11.0 beta4

Related
According to the mail "Deprecating WebContextRoot configuration from WSO2 Identity Server" in dev mailing list, we are going to depreciate WebContextRoot and continue with ProxyContextPath.

Additionally, we need to document this once all fixed.

Hi! Is there any chance for it to be implemented in products-is <IP_ADDRESS>?

Hi! Is there any chance for it to be implemented in products-is <IP_ADDRESS>?

These fixes are not shipped with 5.11.0 release, but if you are a subscription holder, you can raise a support case and request. Otherwise you will have to use 6.0 release.

Re-opening due to pending items

myaccount and console fixes
documentation

Pending action items will be tracked in https://github.com/wso2/product-is/issues/15864

After nginx 1.10, the ssl on is deprected. Hence you can use the following configuration.
server {
	listen 443 ssl;
	server_name idp.wso2.com;
	client_max_body_size 100M;

	root /usr/share/nginx/www;
	index index.html index.htm;

	ssl_certificate /etc/nginx/ssl/server1.crt;
	ssl_certificate_key /etc/nginx/ssl/server1.key;

	location /auth/ {
		proxy_set_header X-Forwarded-Host $host;
		proxy_set_header X-Forwarded-Server $host;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header Host $http_host;
		proxy_read_timeout 5m;
		proxy_send_timeout 5m;

		proxy_pass https://<IP_ADDRESS>:9443/;
		proxy_cookie_path / /auth;
		proxy_redirect https://idp.wso2.com/ https://idp.wso2.com/auth/;

		proxy_http_version 1.1;
		proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection "upgrade";
	}
}


Add Basic Networking Tools to Docker Image for Health Checks

Hi! Would it be possible to include one or two network command packages like ping, netcat, or curl in the Docker image? This would allow folks who want to query the health check endpoint using docker compose or similar tools to do so without needing to create a custom Dockerfile.
I get that y'all are hesitant about adding a HEALTHCHECK command directly to the Dockerfile since it's not standard in any of Docker's official images. But at least with these packages, anyone wanting to set up a health check for their containers can do so more easily.
I'd be happy to open a PR for this if you think it's a good idea.
Thanks!

It's possible to add a health check to a docker-compose file.


Need stronger ui.hold()-like context manager for non-UI objects

We need another context manager, maybe ui.discard(), to prevent Shiny Express from trying to interpret non-UI objects as UI. Or, perhaps Shiny Express should not be so strict about what kinds of objects are allowed to be displayhooked (no-op instead of error).
from shiny.express import ui

class A:
    def __init__(self):
        self.options = {}

    def set_option(self, name, value):
        self.options[name] = value

        # for method chaining purposes
        return self

a = A()

# This next line causes the error.
# Enclosing the line in `with ui.hold()` does not help.
a.set_option("host", "localhost")

with ui.card():
    "Hello"

For now the best workaround I can think of is to turn such lines into dummy assignment statements, like _ = a.set_option("host", "localhost"), but that is not very satisfying.

We could also have a more imperative "echo on/off" type of function.
ui.echo(False)

# Do lots of non-UI stuff

ui.echo(True)

You wouldn't even have to wrap it in try/finally, instead you could say that if there is an enclosing UI context manager (like ui.card()), the effect of ui.echo(False) does not survive beyond the end of that context manager.
The nice thing about this approach is not having to indent the non-UI stuff.
There's a good chance this is a terrible idea and I'm not thinking clearly about it, it's pretty late.

The specific problem with ui.hold() is that it's a RecallContextManager that wraps a TagList, and the TagList cares about what goes into it. This is so all the things in the with ui.hold() as x: block can be referred to as a single object x. But now that I think about it, I think it could be changed to a regular list without breaking anything.
Or another alternative: the objects get put in a subclass of list, like HoldList. If a function consumes that object and doesn't know about HoldLists, then it gets treated like a list. But if function consumes it and and does know about HoldLists (like a RecallContextManager) then it can use the spread operator on it.

Another thought that I had was that perhaps RecallContextManager could add a filter argument, so we could have something like:
def page_auto_cm(
    *,
    filter: Callable[[object], bool] | None = None,
) -> RecallContextManager[Tag]:
    return RecallContextManager(
        ui.page_auto,
        filter=filter,
    )

Where the filter returns True if the displayhooked objects should be stored by the RecallContextManager, False otherwise.
And then the default filter function could be one that returns True only for TagChild objects.
(Even with this, there would still be the issue of ui.hold() not accepting non-TagChild objects, because it doesn't use a RecallContextManager. But that could be solved by the proposal in my previous comment.)

Create subclass of RecallContextManager, RecallContextManagerUi, with a default filter function.
Use a filter function that throws as soon as the displayhook is called, print error message with line number and text

Need to add contextvar state to track current line number.

ui.hold() should store contents with a list instead of TagList


Wrong schema used for 'sync with the database' in documentation editor

Expected behavior
When using 'sync with database' in the documentation editor, I expect it to use the same schema as it would be used during a dbt run executed by the extension.
Actual behavior
Another schema is used, and since the table is not present there, no retrieval of metadata happens.
Steps To Reproduce
In our profiles.yml, the schema is defined as an env variable:
schema: "{{ env_var('DBT_DATASET_PREFIX') }}"
We change this variable dynamically depending on which git branch is currently checked out in our project.
For the extension to work we added a custom dbt wrapper which does the following:

Check active git branch in the project folder
Set environment variable accordingly
Call dbt command

With this setup dbt-power-user works well with the dynamic schema names, i.e. I can call the run button for a model and it will be deployed in the correct schema depending on the current git branch.
For the sync with DB in the documentation editor this does not work.
We observed that it always tries to sync using the 'default' schema, i.e. the one as if the environment variable was not changed from its default value.
One way how I could imagine this to happen is, if the profile.yml is read once when the extension is initialized, and no updates of env_vars are considered. However since it works for other functions of the extension (like e.g. dbt run) I doubt that thats the case here.
Log output/Screenshots
No response
Operating System
Debian 11
dbt version
1.7.3
dbt Adapter
bigquery
dbt Power User version
0.31.3
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I have an update concerning the behaviour, because apparently it does work sometimes.
My steps to reproduce the case where it does not work are:

Create new model
Run model so that it gets persisted on BigQuery
Go to Documentation Editor
Sync with the Database --> Nothing gets synced (because it tries to sync using the wrong schema name)

Now I noticed if I do the following steps after it works:
5. Reload VSCode (ctrl+shift+p -> Developer: Reload Window)
6. Go to Documentation Editor
7. Sync with the Database --> Works with the correct schema

Thanks @alangner for the steps to reproduce the problem. We will have a look soon.

@alangner We were able to reproduce the issue on our end. It is indeed a bug. Hoping to get it fixed soon.

@anandgupta42 do you have an update whether this can be fixed in one of the coming updates? We would love to integrate the extension in our development workflow

As a workaround, we switched to defining the environment variable in the vscode settings.json file, like
"terminal.integrated.env.linux": {     "ENV_VARIABLE_NAME": "VALUE" }
And update this file every time we need to update the variable. This seems to work now also for the operations in the documentation editor.

As a workaround, we switched to defining the environment variable in the vscode settings.json file, like
"terminal.integrated.env.linux": { "ENV_VARIABLE_NAME": "VALUE" }
And update this file every time we need to update the variable. This seems to work now also for the operations in the documentation editor.


Remove title bar on Sierra

Support Sierra
(Before 0.7.0: Blue Sky)

The behavior is not changed on High Sierra.


Module doesn't appear/show

Hi this is what I did:

git clone https://github.com/mrVragec/MMM-mvgmunich.git in ~/MagicMirror/modules
Run: npm install cheerio && npm install array-filter in ~/MagicMirror/modules/MMM-mvgmunich
Add configuration block to my config.js:

{
  module: "mvgmunich",
  position: "bottom_left",
  header: "MVG",
    config: {
      haltestelle: "Hauptbahnhof",
      maxEntries: 25,   // 10 items on screen
      updateInterval: 60000,  // 60 s
      showUbahn: true,    //show ubahn route
      showBus: true,    // show bus route
      showTram: true,   // show tram route
      showSbahn: true   // show sbahn route
    }
},

The module does not appear on my screen.
I tried to change the position to "top_right" but no changes.
Any ideas?

Yes, first install cheerio and array-filters in MagicMirror main folder not in MMM-mvgmunich (I don't know if it will make any difference, but let give a shot). Then rename module MMM-mvgmunich in mvgmunich (without 'MMM-').
After this, please try again and report progress.

Please change "Implerstrasse" to "Implerstraße" and should work.
"Terofalstraße" should work without a problem.

Don't know why but "Terofalstraße" doesn't work for me.
All I see is the header!

Please, update MMM-mvgmunich plugin. Error handling was added and now you should see some error for "Terofalstraße". Please report the error or if it's working.

I get the following error on the display.
Station Terofalstra?e (yes with the "?" in it) is not correct, please update your config!
Hints for your station are:

Can you check what is the encoding of your config.js file? Which OS do you use?
Can you update me if "Implerstraße" is working for you? For me, it seems that there is a problem with encoding of config.js.

No "Implerstraße" doesn't work either. I think it's having a problem reading the "ß"-symbol because all other stations without "ß" are working fine.
What u mean by checking the encoding of my config.js file?
I'm using Magic Mirror Software v2.1.1!

Any ideas?

Is there any error on screen?
Which operating system do you use?
Do you get anything on the console?
Is there anything that you can see in developer tools ( Ctrl+Shift+I) of MagicMirror?

The only error I get when using "Implerstraße" is:  Station Implerstra?e (yes with the "?" in it) is not correct, please update your config!
I'm using Raspberry Pi 3 with Rasbian and Magic Mirror Software v2.1.1
No errors on the console itself.
Nothing

Like I said the problem is that my system can't read a "ß", thats why I'm getting errors. How can I change that?

1 Can you try if you can use "ß" in any other application?
2. Which locale did you choose while installing raspberry pi?

@Da-ne-ezy any updates on this issue? Solved or still persist?


touch device panning

Describe the bug
when disablePan: true or panOnlyWhenZoomed: true the screen on a phone or device cannot be scrolled up or down when the touch area is inside the map.
to put that in context, i need to be able to set an option so the user can either

zoom the map then scroll
2 ignore the map and continue to scroll down the page. if the map takes up all the rest of the available view then the user cannot scroll down below the map.

Your environment
android
Expected behavior
when pan is disabled, the user should be able to scroll the page as normal
Actual behavior
nothing, when pan is disabled you cannot scroll the page if you place finger in map area..

Thanks for opening an issue. I've added an option to deal with this issue.
https://github.com/timmywil/panzoom#touchaction
Note that panning and pinch zooming cannot work when scrolling is enabled on mobile. The native scroll will just take over.
However, you should be able to alternate between touchAction settings to get the desired behavior.

thank you.

:tada: This issue has been resolved in version 4.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Dear Sir,
I have used touchAction : "" in the following demo. Can you please tell me why is it not enabling scrolling on mobile devices?
https://demos.abhinavsoftware.com/panzoom/index.html


[wip] implement "detaching" from shell to start a background process [skip ci]

This uses the daemonize crate to detach the process and effectively daemonize it.
That is kinda cool for long-running processes (e.g. if I run jupyterlab).
There is one big issue: for some reason, creating the activation subprocess does not seem to work and I haven't figured out why yet.
Other TODOs:

[ ] store PID file in .pixi folder
[ ] list running tasks
[ ] kill running tasks
[ ] look at stdout of running tasks

What is the status of this PR?

I gave a try to it at https://github.com/prefix-dev/pixi/pull/682


Editorial updates

Various editorial updates:

PK and KeyValidate updates:

Changed KeyValidate to accept the de-serialized key (half the times KeyValidate was used the PK was (re) de-serialized  immediately after, which is inefficient).
Removed KeyValidate from ProofGen and Sign (we just hash the PK there).
Removed PK de-serialization from Sign (the result is not used).
Added PK de-serialization to ProofVerify.

Changed notation from m~_j1, …, m~_jU -> m~_1, …, m~_U (I think it's clearer this way).

Some updates noted by @dev0x1:

Changed pairing equality check in Verify to match the one in ProofVerify.

Fixed typo in ProofVerify (H_s -> H_d in step 8).

I will update/re-base this as required if needed (it will probably have conflicts with some of the other open PRs).

@BasileiosKal May be we can also update to use consistent ordering of Abar and A' in proof and input to hash_to_scalar,
in ProofGen,
19. c = hash_to_scalar((PK || Abar || A' || D || C1 || C2 || ph), 1)
25. proof = (A', Abar, D, c, e^, r2^, r3^, s^, (m^_j1, ..., m^_jU))
in ProofVerify,
4. (A', Abar, D, c, e^, r2^, r3^, s^, (m^_j1,...,m^_jU)) = proof
10. cv = hash_to_scalar((PK || Abar || A' || D || C1 || C2 || ph), 1)

@BasileiosKal May be we can also update to use consistent ordering of Abar and A' in proof and input to hash_to_scalar, in ProofGen, 19. c = hash_to_scalar((PK || Abar || A' || D || C1 || C2 || ph), 1)
25. proof = (A', Abar, D, c, e^, r2^, r3^, s^, (m^_j1, ..., m^_jU))
in ProofVerify,
4. (A', Abar, D, c, e^, r2^, r3^, s^, (m^_j1,...,m^_jU)) = proof
10. cv = hash_to_scalar((PK || Abar || A' || D || C1 || C2 || ph), 1)

I would probably raise this as a seperate issue rather than addressing in this PR

@BasileiosKal can you address conflicts?

Updated to remove conflicts + made ph in ProofVerify optional (thanks @dev0x1!!)

After thinking more about it, IMO the best way to de-serialize the PK and check if it is valid is to introduce a PubkeyToPoint operation. The reasons are,

If we de-serialize the PK in the procedure and pass the result in KeyValidate directly, we would potentially pass INVALID as input, which I really don’t think it’s wise (not technically wrong, but I’m really afraid of implementation mistakes here).
If we de-serialize the PK in KeyValidate, we would need to de-serialize the key twice.
We want the two operations distinct so we can say that people can skip (or cache) the KeyValidate check.

The proposal goes around these issues. Thoughts??

Can you resolve conflicts with this PR?

Discussed on the WG call resolved to make a few changes

rename pubkey_to_point to octets_to_pubkey
add identity check to octets_to_pubkey and then remove KeyValidate
add security consideration for sub group checks for the octet_to_point_g* functions

Discussed on the WG call resolved to make a few changes

Updated and ready for re-review!


Ffmpeg Protocol not found (download & archive)

Cammand : same use for archive
crunchy-cli download -o "{series_name} S{season_number}E{episode_number} {title}.mkv" -r 1080p -t 100 -s en-US -a ja-JP https://www.crunchyroll.com/watch/GWDU8J729/mash-burnedead-and-the-divine-visionaries
Output :
:: MASHLE: MAGIC AND MUSCLES Season 2 (MASHLE: MAGIC AND MUSCLES The Divine Visionary Candidate Exam Arc)
::  1.  I added a fix which will be available in the next release. Until then, you just can add a ./ to the output flag and it should work fine (e.g. crunchy-cli ... -o "./{series_name} S{season_number}E{episode_number} {title}.mkv" ...)

The : sign in the file name confuses ffmpeg. I added a fix which will be available in the next release. Until then, you just can add a ./ to the output flag and it should work fine (e.g. crunchy-cli ... -o "./{series_name} S{season_number}E{episode_number} {title}.mkv" ...)

The : sign in the file name confuses ffmpeg. I added a fix which will be available in the next release. Until then, you just can add a ./ to the output flag and it should work fine (e.g. crunchy-cli ... -o "./{series_name} S{season_number}E{episode_number} {title}.mkv" ...)

Hmm thank you shall i close

Fixed in v3.2.2


Change 'cosigned' name to 'policy-controller'

As discussed in https://github.com/sigstore/TSC/issues/9,
cosigned will be renamed policy-controller

This is to separate the renaming work from the API version bump up and the work to split the controller to its own repo

So it sounds like there's around three big refactor-ey changes in the immediate pipeline:

bump v1alpha1 -> v1beta1 (sounds like this is in progress)
rename cosigned -> policy-controller
move code out from https://github.com/sigstore/cosign, to https://github.com/sigstore/policy-controller

Do we want (2) to happen before or after (3), or at the same time? Sorry if this has already been discussed and settled.
cc @vaikas

For our purposes, we actually prefer (2) to happen before (3) simply because when we do (3), we have to do a whole internal approval and build process, which we would prefer to work on after we finish our current product release which needs (2).
but that's just for our own purposes/convenience at vmw


No LICENSE file

Currently there's no license for z, which might restrict its use in some business settings.  https://choosealicense.com has lots of information on different ones, I recommend MIT since it's very open.

there is no LICENSE file, but there is a license

WTFPL, got it.  Mind adding a LICENSE file for clarity?  I realize the irony in adding an explicit license for WTFPL, but it would still be useful.


virt-api, admitter: Remove unused method from the VM validation

What this PR does
Remove isMigrationInProgress which is not used.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note
NONE

/sig code-quality

nice thanks
maybe there is some linter that can tell us about those ?

nice thanks maybe there is some linter that can tell us about those ?

There is [1], but this code is not covered by our linter [2].
[1] https://github.com/kubevirt/kubevirt/blob/67974babbb4e805cc6cd222e39287fb2fb8f35f3/.golangci.yml#L98
[2] https://github.com/kubevirt/kubevirt/blob/895075a613f36039a2cb6a30d397b6b0741aece5/Makefile#L208


[Task] Create the database model

initial draft designed by @NicolasChelico and @patrickmac3 and @JRB958


Non admins get 403 Forbidden instead of 409 Conflict when Wrongly POSTing to existing preprint

Purpose
When a read-write user tries to POST to create a preprint that already exists, the API returned a 409 error before the 403 forbidden. While 409 is techncally correct, 403 is way more appropraite for the user because they'll never be able to make a node a preprint.
Changes

check permissions of auth user before 409 conflict

Side effects
no?
Ticket
https://trello.com/c/vc41eU5E/124-api-read-write-and-read-only-users-get-a-409-error-instead-of-a-403

close for #6241


Javascript-capstone Add comment-pop-up

Add a comment section
Style the comment section to a modal
Add details to the book on the comment popup
Fetch comments and display them for each book from an API
Add styling to the comment display section.
Add form for comment input
Post data over fetch on API
Add close event listener

Excellent work @sylvester-wamaya I think there is just a little detail, when adding a comment, the comment isn´t displaying until you refresh the page, it would be better to add in the comment button event listener the function that is refreshing the information.

Okay, thanks for that observation. Let me add the feature now.


Add 'API Documentation' Section to README

Also add some spaces and punctuations.

@adlerhsieh Thanks~


Demo host unreachable

Hello.
The demonstration host http://demo.bacchus.co is unreachable

Hi,
I do not have resources for this for now. I shut it down.
It's very easy to install Bacchus in your environment. Please let me know if you have any difficulties.


Added functionality

Would it be appropriate to add tools for calculating properties of sections? I already have written for my personal use calculators for calculating section modulus, centroid, and second moment of inertia for certain shapes. If you feel these don't belong in MathTools I won't spend the time to clean them up for use.

That sounds awesome. Maybe under geometry tools? Use your best judgment for the file name.


Update Kafka binary url

Use the permanent URL to download Kafka binary.

@lindong28 Can you review this PR?

Thanks for the PR. LGTM.


WIP: Fix language selector for categories page

This approach doesn't appear to be viable, since e.g. English is built before Croatian the logic would make Croatian list English and Croatian, correctly, but in English only English would be listed.

@awennersteen can this be closed?


Assume standard calendar if not specified

This fixes #74. The issue was the created Zarr array did not have a "calendar" attribute, so I changed cftime.num2pydate to use calendar='standard' if zz.attr.get("calendar") == None
Turns out this is the default in cftime.num2date but not cftime.num2pydate.

@martindurant I could use some guidance here, I think I'm going about this the wrong way. Setting the datetimes via this method is working for me, but the tests are failing because of https://github.com/intake/fsspec-reference-maker/blob/cdb652826bbe9831efa8b875614ed73f6ed527cf/fsspec_reference_maker/combine.py#L207
Since that attribute doesn't actually exist. Trying to add a zz.attrs.put({'calendar' : 'standard'}) results in:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/lsterzinger/miniconda3/lib/python3.9/site-packages/zarr/attrs.py", line 109, in put
    self._write_op(self._put_nosync, d)
  File "/home/lsterzinger/miniconda3/lib/python3.9/site-packages/zarr/attrs.py", line 73, in _write_op
    return f(*args, **kwargs)
  File "/home/lsterzinger/miniconda3/lib/python3.9/site-packages/zarr/attrs.py", line 112, in _put_nosync
    self.store[self.key] = json_dumps(d)
  File "/home/lsterzinger/miniconda3/lib/python3.9/site-packages/fsspec/mapping.py", line 152, in __setitem__
    self.fs.pipe_file(key, maybe_convert(value))
  File "/home/lsterzinger/miniconda3/lib/python3.9/site-packages/fsspec/spec.py", line 674, in pipe_file
    with self.open(path, "wb") as f:
  File "/home/lsterzinger/miniconda3/lib/python3.9/site-packages/fsspec/implementations/reference.py", line 381, in open
    raise NotImplementedError
NotImplementedError

Oh it turns out attrs.put() overwrites the whole dict anyways, so that syntax doesn't work

zz.attrs['calendar'] = 'standard' should do it; I'm surprised it's necessary, though.

It turns out it was the z[accum_dim].attrs that needed updating, not zz. I changed that and now the tests are failing on (expected) differences between the reference json and generated dict.
The z[accum_dim].attrs['calendar'] = 'standard' notation didn't work, so I had to convert it to dict, add the key/value and use attr.put() to update it.
https://github.com/intake/fsspec-reference-maker/blob/5072d614cbb6cfa0f497dece422a953c7c4812ab/fsspec_reference_maker/combine.py#L192-L195

If you think these changes are okay, I'll go ahead and regenerate the example json

I changed only the time/.zattrs, time/.zarray, and time/0 values in the example jsons and tests are passing now. Here's hoping that the changes I made don't catastrophically break everything down the line 🤞

Would you like to port this to #73? (which was refactored to do this same thing to more than one coordinate array)

Can do. It'll probably have to wait until the weekend if I feel like doing some of this on my free time.
Another thing I realized, the code I added to the try: block will add a "calendar" attribute to the accum dim no matter what that is (like you said it's almost always time, but not 100%). This probably isn't a great practice in the long run

Good point!

I'll take a look at cleaning this up during my port to #73


helm charts for actions runner

Fixes: #942
helm charts for actions runner, currently its having only RunnerDeployment and Autoscaler resources.
Looks like deployment order is important here, facing the below issue if Autoscaler deployed first and then autoscaling not working as expected.
2022-04-21T12:13:08Z    DEBUG    controllers.webhookbasedautoscaler    RunnerDeployment not found with scale target ref name test-actions-runner for hra test-actions-runner-autoscaler

Helm doesn't support ordering for custom resources. So using List to overcome this issue, didn't use helm chart hooks for ordering since its not tracked after creation.

I was about to start working on this and then saw that you helpfully already have! 😄 One suggestion would be to add the ability to specify the Runner Group. I added this and created saravanan30erd/actions-runner-controller#1 to get that into your branch.

@saravanan30erd @yardbirdsax Hey! First of all, thank you so much for your contribution and patience.
Sorry for the radio silence here. We've been discussing how to maintain this. The main problem is that maintaining the manifests, the kustomize config, and the chart for ARC itself is already too much to maintain for a team of only two, and we weren't sure if we could commit to maintain another right now.
I do believe this chart is super valuable to the community if maintained well, though.
That said, could you let me merge this under a directory like contrib/examples first, and start collecting feedbacks from early adopters/advanced users, and then graduate to the official chart under charts once we gain more confidence?

That said, could you let me merge this under a directory like contrib/examples first, and start collecting feedbacks from early adopters/advanced users, and then graduate to the official chart under charts once we gain more confidence?

@mumoshu  Sure.


Support lifetime parameters on the Q_OBJECT macro

Problem:
struct PG
{
    engine: &mut Engine, -- lifetime error here
    names: Vec<String>
}

Q_OBJECT! { PG:
    slot fn parse(String);
}

To fix the code, I use a lifetime parameter for PG:
struct PG<'a>
{
    engine: &'a mut Engine, // works :)
    names: Vec<String>
}

Q_OBJECT! { PG<'a>: // but now this is broken :(
    slot fn parse(String);
}

This is what the compiler says:
src/main.rs:52:16: 52:18 error: use of undeclared lifetime name `'a` [E0261]
src/main.rs:52 Q_OBJECT! { PG<'a>:
                              ^~

And if I don't use the lifetime parameter in the macro:
src/main.rs:52:13: 52:15 error: wrong number of lifetime parameters: expected 1, found 0 [E0107]
src/main.rs:52 Q_OBJECT! { PG:
                           ^~

Apparently, the macro understands the type just fine, but can't find the definition of 'a. It should be as in impl, where the parameter is defined before used:
impl<'a> PG<'a>

I'm trying to find how to fix this, or how to improve Q_OBJECT, but no success so far.

It's currently not possible to capture a lifetime parameter with a macro, but there's a rust issue for that.
I think the best current solution to this would be to have smaller macros which would help to implement something like this by hand:
impl<'a> qmlrs::Object for PG<'a> {
    fn qt_metaobject(…) => qmlrs::MetaObject {…}
    fn qt_metacall(…) {…}
}


add coveralls to repo

https://coveralls.io/

@rgr2m How does this work? hoodie-plugin-api doesn’t have a .coveralls.yml file which we need according to the coverall docs. I don’t get how this works.

I have used coveralls.io only with this tool: https://github.com/cainus/node-coveralls
hope it helps :smiley:

@christophwitzko thanks! This looks nice, but I still don’t understand where hoodie-plugin-api configures any repo tokens and whatever else is necessary to hook this up :)

when you create an account on https://coveralls.io/, you can create the repo for hoodiehq/pouchdb-hoodie-sync, and then get ENV variables, that can directly be set on Travis configs for the repo


fix: use default wherearewe import

Fixes https://github.com/libp2p/js-libp2p/issues/1344
We can revert this after https://github.com/achingbrain/wherearewe/issues/23

We can just update to<EMAIL_ADDRESS>instead now since it's ESM-only.

Fixed by #1350