Refactor nb blocks (fix #24)

see refactor_notes.md

Great work, I'm seeing a lot of things here that I'm liking :D This will make theming much easier! There's one thing I'm wondering what the rationale for it is, and that's the removal of NbDoc.render. I'm using it myself in nimiSlides (link) because of the way I decided to structure the slides. I don't see any real disadvantages to keeping it and setting it to renders.render by default, or am I missing something? 😄

sorry, I did it again: edited your comment instead of adding a reply. should be back to normal now.

Great work, I'm seeing a lot of things here that I'm liking :D This will make theming much easier!

pretty happy so far, it has really been a long time coming and finally all pieces are falling into place!
and yes, some additional good stuff is coming along (tests!). More than theming I think it will help with making cool custom blocks (html stuff, javascript widgets, ...); release name will be "BlockMaker" (previous release was "ThemeMaker"). But for a "theme" like nimislides I guess it will be useful :)
two main things I am not liking so far:

now rendering mutates document (since block context are updated). It is not great but for the moment I do not think I cannot avoid that
there is blk.context["output"] = blk.output.dup(removeSuffix) (or similar) that is really bad: 1) I now have two different output 2) I now export sugar in nimib (not sure it is really a bad thing, but seems a bit unnecessary). This is mostly due to the need for speed in finalizing this first part (and I do need in some ways to avoid having output with newlines at the end. hopefully I will find a better way.

There's one thing I'm wondering what the rationale for it is, and that's the removal of NbDoc.render. I'm using it myself in nimiSlides (link) because of the way I decided to structure the slides. I don't see any real disadvantages to keeping it and setting it to renders.render by default, or am I missing something? 😄

I think I cannot keep it since nb.render(nb) clashes with nb.render (overload in this case does not work, I had to remove the render field IIRC). It will be a breaking change but honestly the fix is really simple (use nb.render where you previously used nb.render(nb)). And it always seemed weird to me nb.render(nb).

Haha 😄

pretty happy so far, it has really been a long time coming and finally all pieces are falling into place!
and yes, some additional good stuff is coming along (tests!). More than theming I think it will help with making cool custom blocks (html stuff, javascript widgets, ...); release name will be "BlockMaker" (previous release was "ThemeMaker"). But for a "theme" like nimislides I guess it will be useful :)

Right, had already forgotten about my nbHTML/nbRaw needs 🤭

now rendering mutates document (since block context are updated). It is not great but for the moment I do not think I cannot avoid that

It isn't performant, but couldn't you make a copy of nb.context and mutate it instead and pass it to render?
# old
nb.context["blocks"] = blocks
return "{{> document}}".render(nb.context)

# new
var ctx = nb.context
ctx["blocks"] = blocks
return "{{> document}}".render(ctx)

there is blk.context["output"] = blk.output.dup(removeSuffix) (or similar) that is really bad: 1) I now have two different output.
Yeah that's not optimal, but it feels like blk.context["output"] is the one that should survive, no?

I now export sugar in nimib (not sure it is really a bad thing, but seems a bit unnecessary). This is mostly due to the need for speed in finalizing this first part (and I do need in some ways to avoid having output with newlines at the end. hopefully I will find a better way.
What's wrong with strip? It can strip at either end using leading or trailing parameters: https://nim-lang.org/docs/strutils.html#strip%2Cstring%2Cset[char]

I think I cannot keep it since nb.render(nb) clashes with nb.render (overload in this case does not work, I had to remove the render field IIRC). It will be a breaking change but honestly the fix is really simple (use nb.render where you previously used nb.render(nb)). And it always seemed weird to me nb.render(nb).

I'm not really sure how that fix helps me 😅 As it is now in this PR, when we call nbSave, it will call write which in turn calls render(doc). In other words, the render function is hardcoded. My problem is that I want to use my custom renderReveal proc for rendering instead of the built-in nimib/renders/render proc. Do you understand my problem?

It isn't performant, but couldn't you make a copy of nb.context and mutate it instead and pass it to render?

I am thinking something a bit radical but along those lines. Replacing nb.context: Context field with a nb.data: Json field. During rendering first step is to load nb.data into a new context. Context is a weird object to expose directly and I do not really need its specificities. Plus it is really opaque (no public field) and it would require PRs to nim-mustache. I think this will be the way to go. Although it will break stuff (api is similar so providing a context alias should smooth some things out).

Yeah, that's not optimal, but it feels like blk.context["output"] is the one that should survive, no?

given the above it is possible that even code and output field get removed and only survive in the json (with default accessors). Maybe the json is a distinct json and some fields are reserved to be always some type... ok, still not sure how it goes.

What's wrong with strip?

yeah, probably I should just use that (to be honest I only need to strip the last newline, if there is more than one maybe they should stay, mmh not sure). As mentioned I was in a hurry to finish :)

Do you understand my problem?

ah yes, now I do (you actually implemented a new backend) you are right the fix is not easy. But this PR changed fundamentally how render takes place so I think it is supposed to break. What you would need is to create a new backend (basically replace the renderPlan and renderProc). I think I will still change the API there (maybe a backend object by itself). I do have to work at Markdown backend so I will see how that will go. In principle I could keep a renamed field (maybe under a legacy compile time switch) but honestly I do not know how much that is worth. As far as I know only nimislides is using that and it should anyway pass to the new system. Do not worry too much I will help and it will likely not be that much of trouble.

and that's very useful feedback, thanks!

yeah I briefly check nimislides code and I think it will be much improved by stuff in this PR. honestly for me in scope of this PR is also a PR to nimislides that makes it work (you see in the todo there are a few checks of multiple stuff)

I am thinking something a bit radical but along those lines. Replacing nb.context: Context field with a nb.data: Json field. During rendering first step is to load nb.data into a new context. Context is a weird object to expose directly and I do not really need its specificities. Plus it is really opaque (no public field) and it would require PRs to nim-mustache. I think this will be the way to go. Although it will break stuff (api is similar so providing a context alias should smooth some things out).

That could certainly work, and it is more general as well in what kinds of types it can handle than Value 👍

given the above it is possible that even code and output field get removed and only survive in the json (with default accessors). Maybe the json is a distinct json and some fields are reserved to be always some type... ok, still not sure how it goes.

That sounds sensible.  If code or output isn't strings, just error and shout at the user 🤷

yeah, probably I should just use that (to be honest I only need to strip the last newline, if there is more than one maybe they should stay, mmh not sure). As mentioned I was in a hurry to finish :)

The is a stripLineEnd which does exactly that, but it is in-place... If dup is your only use of sugar I would just copy the input to result and do the inplace operation on it. Yeah priority nr 1 is that it works :)

ah yes, now I do (you actually implemented a new backend) you are right the fix is not easy. But this PR changed fundamentally how render takes place so I think it is supposed to break. What you would need is to create a new backend (basically replace the renderPlan and renderProc). I think I will still change the API there (maybe a backend object by itself). I do have to work at Markdown backend so I will see how that will go. In principle I could keep a renamed field (maybe under a legacy compile time switch) but honestly I do not know how much that is worth. As far as I know only nimislides is using that and it should anyway pass to the new system. Do not worry too much I will help and it will likely not be that much of trouble.

Ahh, "backend" is what it's called. It is sensible that a lot of things will break, but functionality shouldn't disappear. As I understand it, renderPlan and renderProc works on a per-block basis? My use-case is to wrap multiple blocks in a common structure (I don't want a linear seq of the blocks, which is what render gives currently), ie I want to wrap the blocks of different slides in

 which isn't possible right now. Have I understood it correctly? This won't be a problem for the Markdown backend though as it works similarly to the HTML backend with a linear seq of blocks.
One solution would be to have some kind of assemble proc the backend could provide which takes the seq of rendered blocks as input and assembles it and modifies the context appropriately before it is being rendered. For the HTML backend it would simply be:
proc htmlAssemble(nbDoc: var NbDoc, renderedBlocks: seq[string]) =
	nb.context["blocks"] = blocks

And in nimiSlides case it would basically do what renderReveal does currently but without the rendering part. How does this sound if you don't want the render proc to be customizable?

yeah I briefly check nimislides code and I think it will be much improved by stuff in this PR. honestly for me in scope of this PR is also a PR to nimislides that makes it work (you see in the todo there are a few checks of multiple stuff)

That will be very much appreciated, or at least some guidance on how I can do it myself :D

My use-case is to wrap multiple blocks in a common structure (I don't want a linear seq of the blocks, which is what render gives currently), ie I want to wrap the blocks of different slides in  which isn't possible right now.

ok starting to understand better. I think it should be doable with current setup, it would be sort of hack but current implementation is likely a worse hack. for example with a simplified api:
nbSlide:
  nbText: "some text"
  nbCode: echo "and some code"

I would implement it as:
template nbSlide(body: untyped) =
  nbSlideStart
  body
  nbSlideEnd

where nbSlideStart and nbSlideEnd create blocks that render to "" and "".
I think this kind of thinking can be adapted to your other apis.
In the future a better solution will probably be to consider container blocks: blocks that can contain multiple blocks and have their separate rendering. It is something I have being thing since I think it would be useful (e.g. a nbFold section that hides stuff under a ..., a nbTabs with multiple tabs...). One step at the time though :)

ok starting to understand better. I think it should be doable with current setup, it would be sort of hack but current implementation is likely a worse hack. for example with a simplified API:

Yeah you are probably right :/ I really liked the idea of not having to wrap the content in a block, as it allows for a more dynamic creation of slides. And it stopped users from making things slides too nested (they aren't visible if nested more than twice). But I guess it will do. :) The fragments (the only other API I have) already uses this kind of logic, it just has to keep track an index which is a bit annoying. As you say, container blocks is really what would be needed in the future.
I'll incorporate these changes in the BlockMaker update of nimiSlides, I don't dare touch it now until FOSDEM 🤣


Automatically download latest release

One great addition would be to download the latest Sonoff-Tasmota release automatically.
You can find the latest release be prarsing this json document: https://api.github.com/repos/arendst/Sonoff-Tasmota/releases
You are looking for the "browser_download_url" below the first asset. You can additionally retrieve the "size" for comparison and a simple download verification. You could additionally print tag name and body for clarity.

I have a working programm, but I was wondering where to save it. For know I save it in the same directory the python script is in. It's probably not the proper way is it?

Good question. Either you go with a temporary file or you store the file in memory and spare yourself the filesystem fiddling, I've no ready to go solution for the second but a temporary file is easy:
https://docs.python.org/2.7/library/tempfile.html

Thank you I think I will use a temp folder. I just read my question again. Good that you understood me. "It" meant the .bin file not the python file. :smile:

Out of interest, why didn't you use tempfile instead of tempdir+"firmware.bin"?
Also instead of "/" or "" you can use os.sep ;)

It was a kind of workaround because I could not find a way to create a temp file from the urllib object 😄 I'm really not fluent in python or programming at all, but I will try it if you say it should work 🙈

I'm not saying it should work! I would expect that but in the end it's something one needs to test out. I'm just pitching ideas ;)

I will look at it again :D feels good to have a goal when programming something, better than doing some exercise from a workbook.
esptools required a path to the file, so in the end I would have to get the filepath from tempfile which is kind of the same only that it will be cleaned up automatically in the end.

That's exactly what I tell students in my engineering class 😄
Maybe this will be helpful?https://gist.github.com/sligodave/6539531

With all the help you give me you could have almost done it yourself :smile:

Where would be the fun in that? Haha
It's great to work on projects together, unrelated to how small they are. If we have a working flash tool in the end and you learned something new by doing so, everything is great.

There is a lot to learn especially how to handle the code on github and on my PC. Do you use Eclipse or something like that? Any hints how to cope with that?
I have a testfile working with tempfile seemed like I was to lazy to find a good way and just worked around ... 🙈

Eclipse is a solid choice. You can use the integrated git client but for better control (especially for a newcomer) I'd recommend GitKraken. After you've gained some experience and if you are looking for a more powerful solution, SmartGit is my daily driver.
Glad the tempfile idea is working. Sometimes it takes multiple steps. Happens to me too all the time.


Predict uses test set, evaluate uses validation set

I might be misunderstanding something about the Trial API design -- but do you think it should be possible to predict on the validation set or evaluate on the test set (assuming you have labels)?
What are your thoughts on having an optional keyword to predict/evaluate on an arbitrary DataLoader (aside from the loaded train/dev/test sets)?
Thanks!

Would be nice to take the state_key which points to the generator as an optional argument for predict and evaluate. Would need to alias the generator keys so that the API is cleaner. E.g. (in state.py)
TRAIN_DATA = TRAIN_GENERATOR = state_key(...)


Add old value to operation when rationalization is enabled

We also need to show the old value when rationalization is enabled.
It's helpful in some sense in detail to compare.

@woostundy LGTM Could you please commit with your GitHub identity (name and email), and sign the commit, in order to have an identifiable commit please ?

Sure, let me close this PR and create a new PR with signed commits.

Move to https://github.com/wI2L/jsondiff/pull/14


Properly scale radii for 2D parts shown in 3D space view's pinhole image plane

What

Fixes #2494

https://github.com/rerun-io/rerun/assets/49431240/f22bb891-257e-4c15-90fb-f82bd1f5b999
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested demo.rerun.io (if applicable)
[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

My upcoming version will also fix

#1223
#1219

replaced by

https://github.com/rerun-io/rerun/pull/4199


bugfix(FDS-522): [Pickers] import antd.css in semantic.css file

import antd.css in semantic.css file
PR Author Checklist

[x] PR title adheres to Conventional Commits
[x] I have finished reviewing the contents of this PR for accuracy
[x] If needed, I have included a Changeset and it follows Semantic Versioning principles
[x] I have completed all of the above and have enabled auto-merge for this PR

Fails

:no_entry_sign:
Please add a '### Dependencies' section to explain the reason we are changing dependencies.

Messages

:book:

packages/cascara/src/atoms/TimePicker/TimePicker.fixture.js: This fixture has been changed.

  Generated by :no_entry_sign: dangerJS against 8a80db71cd5c6312e83c5bcfd6bb1b3c2be25585


Stinky and Doc slug added

I have added two slugs, Stinky and Doc.

@vortex2099 There is some error in code. Check again and first deploy the website and see your code is working or not. Then again do Pull Request


pylightning: init at <IP_ADDRESS>

Needed for clightning plugins
Signed-off-by: William Casarin<EMAIL_ADDRESS>Motivation for this change
Needed for clightning python plugins
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @jonasnick

I think you'll need to disable this for py2.

Otherwise builds on both macos 10.13 and non-nixos linux x86_64. Pity there don't appear to be any tests.

@GrahamcOfBorg build python3.pkgs.pylightning


Sort Colours

Related Issue
Closes: #840
Describe the changes you've made
Added folder and C file
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
C
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

Make changes according to Contribution guideline


Publish decorated event stream

Small change to have EventSourcingRepository publish the decorated event stream instead of the undecorated one.
The current implementation (non-decorated) doesn't allow for access to any metadata from the projectors on the initial publish. The metadata is available in the projectors on subsequent publishes (e.g., if the read model is rebuilt).
The decorated stream is already available in the repository at the time of publishing, however it was only being used in the append() operation and not the publish() that followed (the pre-decoration array of events was instead published).  So this adds no additional overhead; it merely makes more information available (information that is being saved to the database, and is available on subsequent publishes)
Original discussion of this missing functionality began here, and further research here indicates that metadata should be available for use with projections

@mbadolato this makes total sense to me. Can you add a test verifying that it's the decorated event stream that is being published?

@asm89 Sure, can look at it tonight

Also, just a stylistic preference, but since $domainEventStream would only be used once after the change, do you mind if I remove it as an intermediate variable, or would you prefer to keep it?
From:
$domainEventStream = $aggregate->getUncommittedEvents();
$eventStream       = $this->decorateForWrite($aggregate, $domainEventStream);
$this->eventStore->append($aggregate->getAggregateRootId(), $eventStream);
$this->eventBus->publish($eventStream);

To:
$eventStream = $this->decorateForWrite($aggregate,  $aggregate->getUncommittedEvents());
$this->eventStore->append($aggregate->getAggregateRootId(), $eventStream);
$this->eventBus->publish($eventStream);

@mbadolato removing the intermediate is fine.

@mbadolato alternatively you rename the variables a bit and make the code more clear imo. :)
$eventStream = ...;
$decoratedEventStream = ...;

@asm89 Either way works for me!

@%@&%!&^$ php 5.3  and it's lack of short array syntax

what is @%@&%!&^$ ?

| what is @%@&%!&^$ ?
A polite way of screaming a string of profanities in written form in a public medium

@asm89 Ok, test written, commits squashed. Should be good to go.

@mbadolato See comments. Thank you for the added tests. :+1:

@asm89 Done!

:+1:

Thanks @mbadolato

:smile:


Add confirmBacsDebitSetup TS types

Summary & motivation

This adds TypeScript types for stripe.confirmBacsDebitSetup.
Bacs is GA now 🎉
Testing & documentation

This is a Types change only. Type tests added.

Nice catch, thank you Christopher! I've committed those updated URLs.


Support for stdin (and stdout)

Would probably have to be for single reads only (nanopore)

Would be messy to implement in existing codebase, probably better to rewrite in C++/Rust if needing this?


napari-hub page: documentation link don't work

On the napari-hub page of the plugin, the link to the documentation doesn't work:

I presume, one needs to add an entry to this file:
https://github.com/HenriquesLab/napari-NanoPyx/blob/master/setup.cfg
like this one:
https://github.com/haesleinhuepf/napari-assistant/blob/f38944bef2abc10f9c318fef1dd361caac6ce614/setup.cfg#L13

Hi Robert, thanks for pointing this out. We've created a new release that fixes this issue (napari-hub is still updating the remaining README file but links are already working.


[v1.2][W13-B1] ContactSails

@SuxianAlicia @AJZ1995 @A0143487X
v1.2

@amad-person @SuxianAlicia @AJZ1995 @A0143487X
Some comments added. Please take a look and update the document as necessary.
Don't close this pull request; we will use it for further reviews later in the semester.

@amad-person @AJZ1995 @SuxianAlicia @A0143487X
I don't see user guide updates to most of the things on this list:
+* Manage customer contacts: Add, edit and delete contacts.
+* Categorize customers: Group customers according to their preferences, social media platforms, or any other category you want to define.
+* Manage orders: Add, edit, and delete customer orders.
+* Send promotions: Apply differentiated marketing strategies by sending promotions to relevant customers.
+* Keep track of deadlines: Add tasks and reminders and view your schedules in the integrated calendar.
+* Know your customer demographic: See what the top selling items and who your most frequent customers are.
For those you want to implement as a part of later milestones, you were supposed to think through and write the command format and usage examples now!
The idea is to get you to think through the product from an end user perspective, and develop it accordingly.
In addition,
I would want you to mention the following in your Developer guide

For each team member what are the features (major and minor) you are proposing?
Within the scope of the project, how does it fit in (just a one or 2 line summary)
Please do this by end of day Monday 19 March.

@okkhoy In the 2103 website, the TODO just mentioned to mark the coming in v2.0 features. We added a section in the UserGuide that does this. Also, in the Developer Guide, we put the release versions in the User Stories table. Can this please be considered as passing the milestone? Thanks!

@amad-person @SuxianAlicia @AJZ1995 @A0143487X
Some comments added to the DG. Please take a look and update as necessary.


MSDKUI-2311: Access to storage issue

MapSettings.setDiskCacheRootPath() throws exception when it tries to set
external path without storage permission. Adding try catch fixes this
issue because user can't go beyond splash screen without accepting
storage permission.
Signed-off-by: Tadeusz Staszak<EMAIL_ADDRESS>

Codecov Report

Merging #184 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
- Coverage     73.70%   73.65%   -0.05%
+ Complexity     1627      986     -641
============================================
  Files           129       69      -60
  Lines          5731     3952    -1779
  Branches        824      442     -382
============================================
- Hits           4224     2911    -1313
+ Misses          914      797     -117
+ Partials        593      244     -349

Impacted Files
Coverage Δ
Complexity Δ

.../common/mapselection/WaypointSelectionPresenter.kt

.../java/com/here/msdkuiapp/map/MapFragmentWrapper.kt

...ain/java/com/here/msdkuiapp/base/RetainFragment.kt

...e/msdkuiapp/routing/RoutingInstructionsFragment.kt

...e/msdkuiapp/position/LocationPermissionFragment.kt

.../msdkuiapp/position/LocationPermissionPresenter.kt

.../msdkuiapp/guidance/GuidanceStreetLabelFragment.kt

.../msdkuiapp/routing/RouteDescriptionListFragment.kt

...om/here/msdkuiapp/routing/RoutePlannerPresenter.kt

...mmon/routepreview/RoutePreviewFragmentPresenter.kt

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922411d...51011a2. Read the comment docs.


Question about the Role of GNN-Based Dynamics Model during Inference

Thank you for open-sourcing this great work! I would like to ask you about the role of the GNN-based dynamics model outlined in your paper.
In the paper's introduction, you mentioned "we combine a PointNet-based tool classification module with learned dynamics models to determine the most appropriate tool to use at the current task stage", while in Section 6.1, it appears that both the Tool Predictor and Policy Network operate based on the defined target or sub-target point clouds, rather than on predictions from the dynamics model. Thus, I'm a little bit confused about the usage of this GNN-based dynamics model during deployment and wonder if I might have misunderstood the implementation details.
I appreciate your precious time and assistance in clarifying this!

Hi Pengzhi,
Thank you for your inquiry. To clarify, the GNN-based dynamics model is used to create a synthetic dataset for training the policy network. You can consider it as a learned simulator that generates a huge offline synthetic dataset to train the policy. The function of the tool predictor, which selects the next tool, does not factor into the understanding of the dynamics. For more details, please refer to paragraphs 3-5 on page 5 and the left section of Figure 3(b) in our paper.

Thank you Haochen for your quick reply and clear explanation!


Document kubeadm upgrade to v1.17

This is a Feature Request

What would you like to be added
Describe how to update a cluster from v1.16 to v1.17, using kubeadm
Why is this needed
The v1.17 release is imminent.
Comments
https://k8s.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/

@daminisatya is this the right way to track this work?

i was wondering what we are missing. looks like we forgot about this this cycle
cc @fabriziopandini
i will send a PR later today.

/sig cluster-lifecycle

/assign

/lgtm
/approve

/priority important-soon

Done
/close


There are many warnings for using springboot3.2

我们鼓励使用英文，如果不能直接使用，可以使用翻译软件，您仍旧可以保留中文原文。另外请按照如下要求提交相关信息节省社区维护同学的理解成本，否则该讨论极有可能直接被忽视或关闭。
We recommend using English. If you are non-native English speaker, you can use the translation software. We recommend using English. If you are non-native English speaker, you can use the translation software. In addition, please submit relevant information according to the following requirements to save the understanding cost of community maintenances, otherwise the discussion is very likely to be ignored or closed directly.
https://github.com/alibaba/nacos/issues/11616
https://github.com/apache/incubator-seata/issues/6249
There are warnings after the nacos sentinel seata update to springboot 3.2
Which Component
eg. Nacos Discovery, Sentinel
Describe the bug
A clear and concise description of what the bug is.
Simplest demo
The URL of the simplest demo to reproduce the problem.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
e.g.  MacOS  、Java8 、 Version 0.2.1.RELEASE

社区还没适配 spring boot 3.2 最近正在做
具体可以看 https://github.com/alibaba/spring-cloud-alibaba/issues/3574

这实际上是 Spring Cloud 官方项目导致的，不过不影响使用，Spring Cloud 计划在下一个版本中修复该问题，SCA 会在Spring Cloud 下个版本发布后集成最新版本。
https://github.com/spring-cloud/spring-cloud-commons/issues/1315


Bulk sharing of presigned transactions signatures at startup

It's bulky but certainly useful for now.
Based on #157
Fixes #96
Adds a TODO for #35 which can't be fixed yet

Applied linter and rebased on master

utACK 59c70f859ee38937ac838194d9c41f84e2104046 reviewed briefly the code, looks good


[Bug]: Removing Background adding new animated background ( webpage lagging too much )

🐞 Bug Report
📋 Description
there is so much lag in the website because of this background so I have to apply new animated background with simple effects not like this one
⚙ Steps to Reproduce
Steps to reproduce the behavior:

remove old bg
add new bg

CAN YOU ADD GSOC EXT LEVEL 3 to this
https://github.com/user-attachments/assets/fa8e31d4-b2b8-4fb2-b9b6-8db86b04c758
🖥 Environment (if applicable):

OS: (e.g., Windows, macOS, Linux)
Browser: (e.g., Chrome, Safari, Firefox)
Version: (if relevant)

🔧 Additional Information

For getting level 3 you need to make some significant change.And about bg I think it is quite good.


Discuss validators API endpoint caching

shouldn't we allowed to query for old epochs?
shouldn't we handle the cache miss in the retainer itself?
does it make sense to cache with this granularity? wouldn't per epoch make more sense?
for the current epoch, we could cache per new slot
is pagination and size correctly handled?

Maybe it would make much more sense to create a api-cache package than caching that info in the retainer.

Follow up in #752


Prepare for release

The list of changes can be seen here - https://github.com/Azure/azure-sdk-for-net/pull/41144/files#diff-30e1d17e7b7f1af528151f06fb3dd5f932b68367b54adc1c98bc6f33a0084c4dL9-L15

API change check
API changes are not detected in this pull request.


Incorrect /.well-known URL

Zion hosts the Thing Description of the directory at /well-known/wot. My understanding of the specification is that it should be  /.well-known/wot, which currently returns a 404.
I also noticed that link to the Thing Description in the Zion HTML UI server at / links to /well-known/wot-thing-description which returns a 404.
P.S. Congrats on the release! Great to see the WoT Discovery specification in action.

P.S. Congrats on the release! Great to see the WoT Discovery specification in action.

Thank you again!! we are doing our best 💪🏻 .

Zion hosts the Thing Description of the directory at /well-known/wot. My understanding of the specification is that it should be /.well-known/wot, which currently returns a 404.

This is of course a silly typo, fixing it 👍🏻 .

I also noticed that link to the Thing Description in the Zion HTML UI server at / links to /well-known/wot-thing-description which returns a 404.

Ah, that was tricky, it is some left over when we didn't have the landing page. It is probably also related to #7.

I also noticed that link to the Thing Description in the Zion HTML UI server at / links to /well-known/wot-thing-description which returns a 404.

Already fixed in e7b2988f34a9245a2b88655649ec86484f380d0f.


project icon and image updated

Description
Updated the project image and icon to fit the design
Concise description of proposed changes, We recommend using screenshots and videos for better description
After

Additional Information

[ ] I have read the contributing docs (if this is your first contribution)
[ ] This is not a duplicate of any existing pull request

Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:

The image looks great, but something is weird about the icon  It looks like some of the bottom is cut off, and it is stretched horizontally.  It might be good to keep the edges as seen here:

And then the icon can be a little wider to keep it looking like the original, but with some extra side background to make it a square.

A rounded square, hah.  Like the other Icons.

The latest updates look good to me but I am not quite sure what @ZakGriffith was seeing.


High value for Window antialiasingLevel causes frequent segfaults on macOS

Subject of the issue
When a suitably high value is given for the antialiasingLevel member of ContextSettings, Window objects created with these settings almost always (but not every time) crash the program with a segmentation fault.
Your environment

OS and version: macOS High Sierra (v10.13.6)
Version of SFML tested against: v2.5.1
Built-in Clang: Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Special compiler flags used: Only -Wl,-rpath and -framework for linking to the SFML libraries.

Steps to reproduce
Compile this code with clang++ sfml_bug_demo.cpp -o sfml-bug-demo -Wl,-rpath,/Library/Frameworks -framework sfml-graphics -framework sfml-window -framework sfml-system:
#include <climits>

#include <SFML/System/Sleep.hpp>
#include <SFML/System/Time.hpp>
#include <SFML/Window.hpp>

int main() {
    sf::ContextSettings settings;
    // on macOS 10.13.6, any value in range 0..(UINT_MAX/2) is fine
    settings.antialiasingLevel = (UINT_MAX / 2) + 1;
    // with value of antialiasing set to (UINT_MAX / 2) + 1, segfault occurs:
    sf::Window(
        sf::VideoMode::getDesktopMode(),
        "SFML Bug demo",
        sf::Style::Default,
        settings
    );
    sf::sleep(sf::seconds(1));
}

Expected behavior
The Window should be created and then immediately disappear (probably with a message on the console indicating that the exact requested settings could not be fulfilled, owing to the ridiculously large value for the antialiasing level).
Actual behavior
Almost every time the program is run, this is the only output on the console:
Error. Unable to find a suitable pixel format.
Segmentation fault: 11

Very rarely, this output appears instead:
Error. Unable to find a suitable pixel format.
Warning: The created OpenGL context does not fully meet the settings that were requested
Requested: version = 1.1 ; depth bits = 0 ; stencil bits = 0 ; AA level =<PHONE_NUMBER> ; core = false ; debug = false ; sRGB = false
Created: version = 0.0 ; depth bits = 0 ; stencil bits = 0 ; AA level =<PHONE_NUMBER> ; core = false ; debug = false ; sRGB = false

Notes

This same code has been tested on Ubuntu Linux and runs without error.
The issue is not present with antialiasingLevel being in the range 0..(UINT_MAX / 2), which is 0..2147483647 on my system.
I realise that it's rather foolish to set antialiasing to such a high value, but there is no documentation specifying any maximum range for the value and it appears that there is something else wrong with SFML that is causing a segmentation fault to happen when given this large value.

This might be stating the obvious, but as a random drive-by thought: could something be treating a value as signed int while something else is treating it as unsigned int (or vice versa)? (Thought prompted by relationship between UINT_MAX/2 & INT_MAX.)
The inconsistent nature is a bit of a twist though.
Also does any other OpenGL library have the same issue on the same machine?

@follower That is an interesting thought!
For what it's worth, I will add that I did happen to stumble upon the issue originally due to storing a signed integer in an unsigned variable, causing the value to jump to the large one as documented.
I have considered modifying the demo program posted above to use exact literals rather than expressions using the <climits> placeholders, perhaps for explicitness' sake. The thing is, one can't be sure of the width of the built-in integer types in C!

The inconsistent nature is a bit of a twist though.

Yes indeed it is! My guess is it might be a platform-specific implementation detail, perhaps some overlooked constraint in the SFML code which interacts with the macOS-specific OpenGL API...

Also does any other OpenGL library have the same issue on the same machine?

Good question —I'm afraid I'm unable to answer that one though, I do not have any OpenGL programming experience. The only graphics programming I have done is with SDL and SFML. However, from doing a bit of searching within the SFML code, if I'm not mistaken then the ContextSettings class in SFML maps to some kind of equivalent type for OpenGL rendering, so it wouldn't surprise me if it's OpenGL-related.

@follower If you or someone else would be able to guide me in creating or supply a minimal test program for verifying if the issue is to do with OpenGL itself, I would be happy to test such a program on my Mac and Linux machines, if it would be useful.

The joys of unitiliased variables...
#1610  will fix the segfault, but to be honest I don't think there's anything else we can do about this issue. It may well be a signed/unsigned conversion somewhere in the apple code, but it's an extreme edge case and the best we could do is just log an extra error saying to use reasonable AA values

Hooray! I appreciate that someone took the time to look into it, understand totally that it's an extreme edge-case, that there is now a proposal to add additional code in SFML to handle this gracefully feels like the right way to handle it, thanks!

I'd say this can probably be closed now

This was fixed with #1610
Not sure if it's really worth adding checks for "sane" values.


"failed to create tokens" when creating a token

If I use Select All to specify the read and write scopes then it fails.
If I select them individually, then it works fine.

@anwar6953 we believe that this issue should be fixed. Can you confirm that you are no longer seeing this behavior?

I tested it again just now; it still failed for me.

Note that it is not a blocker, since I could easily select the buckets individually, but I just wanted surface the broken functionality.

@anwar6953 is this a local installation or in our cloud product?

It's the cloud product.
If you click "All Buckets", it works. But if you click "Select All", then it fails.
https://imgur.com/a/LZbtqr3

@anwar6953 awesome! Just reproduced this myself. Thank you for reporting!

Unable to reproduce, per @ShmuelLotman
Closing this.


Webpack no longer supports define correctly

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Webpack no longer appears to support define correctly.
If the current behavior is a bug, please provide the steps to reproduce.
We upgraded from webpack 2.2.1 to 2.6.1. In 2.2.1 everything works, but in 2.6.1 it doesn't.

Include the compressjs module, which uses define like so (see https://github.com/cscott/compressjs/blob/master/main.js)

if (typeof define !== 'function') { var define = require('amdefine')(module); }
define([...], function(...) {
    'use strict';
    return freeze({
        version: "0.0.1",
       ...
    });
});)

At runtime, you will get an error saying

Uncaught Error: define cannot be used indirect
    at e.exports (vendor.ac2023d….js:sourcemap:1)
    at Object.<anonymous> (vendor.ac2023d….js:sourcemap:1)
    at Object.<anonymous> (vendor.ac2023d….js:sourcemap:1)
    at n (commons.1a4acdd….js:sourcemap:1)
    at Object.<anonymous> (logos.42ff4f3….js:sourcemap:1)
    at Object.<anonymous> (logos.42ff4f3….js:sourcemap:1)
    at n (commons.1a4acdd….js:sourcemap:1)
    at Object.<anonymous> (logos.42ff4f3….js:sourcemap:1)
    at n (commons.1a4acdd….js:sourcemap:1)
    at Object.<anonymous> (logos.42ff4f3….js:sourcemap:1)

Attempted workarounds
I have tried excluding the module from webpack via noParse (though the docs say not to exclude anything that uses define or require):
module: {
  noParse: /(compressjs)/

At runtime, this results in a different error:
main.js:1 Uncaught ReferenceError: require is not defined
    at Object.module.exports (main.js:1)
    at __webpack_require__ (bootstrap 596e1b2…:54)
    at Object.<anonymous> (expander.tsx:61)
    at Object.<anonymous> (util.js:57)
    at __webpack_require__ (bootstrap 596e1b2…:54)
    at Object.<anonymous> (errors.ts:21)
    at __webpack_require__ (bootstrap 596e1b2…:54)
    at Object.<anonymous> (shortcut-icon.jsx:16)
    at __webpack_require__ (bootstrap 596e1b2…:54)
    at Object.__webpack_exports__.LogoTabIcon (auth-policy.tenant.client.js:9)

I have tried additionally adding an alias:
resolve: {
  alias: {
    compressjs: path.join(projectRoot, 'node_modules/compressjs/main.js')

Offending webpack code
It appears the webpack code in Parser.js no longer returns a value for the define expression. In 2.2.1, parser returned a BasicEvaluatedExpression, but as of 2.6.1 it returns nothing, because the "define" definition has been pushed onto the scope for some reason. this.scope.definitions contains 'define' now, whereas it was previously empty.
this.plugin("evaluate Identifier", function(expr) {
	const name = this.scope.renames["$" + expr.name] || expr.name;
	if(this.scope.definitions.indexOf(expr.name) === -1) { // <-- HERE
		const result = this.applyPluginsBailResult1("evaluate Identifier " + name, expr);
		if(result) return result;
		return new BasicEvaluatedExpression().setIdentifier(name).setRange(expr.range);
	} else {
		return this.applyPluginsBailResult1("evaluate defined Identifier " + name, expr);
	}
});

I'm guessing this is due to the prewalking that was introduced starting in 2.4.0 here.

What is the expected behavior?
Modules such as this runs without errors.
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Testing using the latest Chrome version.

yep this is a problem...

Hi @evilebottnawi I've retried today using webpack 4.8.3 and can confirm the issue with requirejs/ amdefine still exists.

@evilebottnawi Looking through the issue it looks like a minimal reproduction example is lacking. Would it be helpful if I provided one?

*rips out webpack and switches to browserify

/cc @ooflorent

@sverweij Absolutely. Any simple repro would be appreciated.

I've found the issue. Problem is that define is redefined and shadows global.define. If you replace remove var in the source, then it works as expected. I'm not sure webpack can do anything about this.

@ooflorent some old libraries can contain this code, it is not always possible to remove it

@evilebottnawi I understand but this is not a webpack bug. webpack fixed a bug that broke existing libraries because they were doing broken things.

A fix would be to ignore redefinition of define but that would break code that requires define to be shadowed.

If this cannot be solved without breaking (t.b.c.) it might be useful to document any known workarounds for anyone bumping into this (I can help).
@ooflorent seeing you found the root cause: still interested in a simple repro?

@sverweij no, thank you. I was able to create a repo to analyze what was going on 👍


myVlcControl.GetCurrentMedia().Tracks can not get RTSP with and height

myVlcControl.GetCurrentMedia().Tracks can not get RTSP with and height。

Please fill the issue template and tell me the kind of media you are trying to play.
Do you wait correctly for the Parsed event?

the same one RTSP source，in the VLC Media Player is all all right。
source like this ：
step1：
run EasyDarwin.exe（https://github.com/EasyDarwin/EasyDarwin ， EXE file：https://github.com/EasyDarwin/EasyDarwin/releases）
step2：
ffmpeg -re -i test.mp4 -vcodec copy -codec copy -f rtsp rtsp://localhost/film
then, you can open a web  http://...:10008 in Chrome，click the "推流列表"menu，in the list of page right，at “源地址” Column， a rtsp source like this"rtsp://localhost:554/film"
step3:
open "rtsp://localhost:554/film" in VLC Media Player, this player can get the with and height of this rtsp.
but , in Samples.WinForms.Advanced project( last version) ,can not get them.
if the source is a **.mp4 ,Samples.WinForms.Advanced project can get. just rtsp source can not.

EasyDarwin.exe + ffmpeg  can build a rtsp source


What Swagger Version is used here?

I haven't seen sth in the readme. Is it swagger 1 or 2?

See https://github.com/domaindrivendev/rswag#compatibility


Don't work on SAFARI

the script work on all browsers but NO on SAFARI
Can you help me pls?

Hi @marksumoto,
Can you elaborate please? What doesn't work in Safari?
Could you please provide a JSFiddle or JSBin containing a set of reproducible steps?
Thanks!


Update actions/checkout in the README.md

actions/checkout@v3 is now recommended version. Update that in the readme.
PS! Just finished watching So You Want To Earn Money With Open Source video, @mre. Awesome work!

Awesome. Thanks for your contribution @Rauno56.

PS! Just finished watching So You Want To Earn Money With Open Source video, @mre. Awesome work!

Thanks for the feedback. Makes me extra happy. 😊


custom cards missing

Version of HACS
.11

Describe the bug
A clear and concise description of what the bug is.
custom cards plugins missing from the store after update to .11  , for example  monster card  among others.
Debug log

Add your logs here.

sorry , this was a draft , and i see it is working again now


x/tools/gopls: support and documentation for bazel-based projects

What version of Go are you using (go version)?

$ go version
go version go1.13.1 linux/amd64

Does this issue reproduce with the latest release?
n/a
What operating system and processor architecture are you using (go env)?
n/a
What did you do?
Wrote a project with bazel with .go files and .proto files. The protobufs generate go code, which I'm not sure how to make understandable to gopls. Code completion for this code does not work in VSCode.
What did you expect to see?

Documentation of how to set up a Bazel-based project in the User guide.
An example project that works and loads in an IDE like VS Code

What did you see instead?
Scattered information on the level of support and no example projects.
Related links:

https://github.com/bazelbuild/rules_go/issues/512 - main source of updates on gopackagesdriver progress
https://github.com/bazelbuild/rules_go/wiki/Editor-and-tool-integration: Design doc for gopackagesdriver - I'm not sure how accurate this is
https://github.com/microsoft/vscode-go/issues/2755 - gopls support for GOPACKAGESDRIVER in VS Code
https://github.com/bazelbuild/rules_go/issues/393 - editor integration issue for rules_go
https://github.com/golang/go/issues/34341 - documentation request for GOPACKAGESDRIVER
Code: jmhodges/rules_go/go/tools/gopackagesdriver, gopackagesdriver in rules_go feature branch, tools/go/packages/external.go seems to implement the external packages driver

Did you use @jmhodges's Bazel implementation for GOPACKAGESDRIVER when you tried out gopls with Bazel? Is it ready for use?

I did not try out jmhodge's implementation yet - I just browsed the code there.

I see. We don't support any build system that doesn't have an official gopackagesdriver, so I will defer to @jmhodges and @jayconrod on the status of that work.

Tracking issue for that is bazelbuild/rules_go#512.


Ability to Zoom in on Timeline to See Audio Gaps in Long Videos

In long videos (such as Zeta Shift discussion videos, a one second gap in the audio can only be one pixel. It would be useful if you could zoom in the timeline to more easily place the cut.

duplicate of https://github.com/dbvideostriketeam/wubloader/issues/381


Ability to use free memtest86+ with systemd-boot

Describe the bug
There are the bootable programs memtest86 and its fork memtest86+. Both perform the same task, but former has went proprietary a while ago, which makes the fork the only free option. The proprietary one also has EFI support while the fork only supports legacy booting.
When you enable memtest86 with grub, it checks whether EFI is enabled, and if yes, uses memtest86, and otherwise the free fork 7b5550a3fc72cc3c41c4143732502a0787cb17a0. The systemd-boot analog doesn't have this feature, it always uses the proprietary memtest86.
I haven't allowed nonfree software on my system, and don't have EFI enabled. It would be great if I were able to use systemd-boot together with memtest86+.
Notify maintainers
@cdepillabout , author of #61036
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

memtest86+ doesn't support UEFI. systemd-boot is UEFI bootloader even on BIOS systems and as such cannot boot 16-bit programs.

Oh that's too bad. Alright, closing then. Thanks for the reply.


Adding Oauth to Odysee APIs

Seems like it could work. However, it's hard to reason about it when there is no tests for this key piece of functionality. They can be against a real or a mock oauth server instance. Some existing tests call actual internal-apis.


(CSharp) Function name highlight incorrectly

Describe the issue
Function name highlight incorrectly

Which language seems to have the issue?
CSharp / C#
Are you using highlight or highlightAuto?
use "highlight.js": "^11.5.1" with Node.js on the Server
Sample Code to Reproduce
    CoreUtils.SetRenderTarget(cmd, m_MirrorTexture, ClearFlag.All, Color.clear);

    var mirrorPos = MirrorPlanar.mirrorPos(MirrorPlanar.Plane,camTransform.position);
    var viewM = MirrorPlanar.GetViewMat(camTransform.position, rotation);
    var projectionMatrix = camera.projectionMatrix;
    projectionMatrix = GL.GetGPUProjectionMatrix(projectionMatrix, cameraData.IsCameraProjectionMatrixFlipped());

    cmd.SetGlobalVector(worldSpaceCameraPos,new Vector4(mirrorPos.x,mirrorPos.y,mirrorPos.z,0));
    RenderingUtils.SetViewAndProjectionMatrices(cmd, viewM, projectionMatrix, false);

Expected behavior
same code with C++ to highlight

Additional context
I used the following code to test, C# and C++ gave completely different results
html = hljs.highlight('int a = CoreUtils.SetRenderTarget(Color.clear,10)', {language: 'c#'}).value
console.log(html)

html = hljs.highlight('int a = CoreUtils.SetRenderTarget(Color.clear,10)', {language: 'c++'}).value
console.log(html)

int a = CoreUtils.SetRenderTarget(Color.clear,10)

int a = CoreUtils.SetRenderTarget(Color.clear,10)

This is not a bug, it's a lack of a feature.  C# (and many other grammars) currently does not highlight property access or function dispatches.   A PR would always be welcome.  Closing as a duplicate of #2500 (catch all issue for desire for higher fidelity highlighting).


[WIP] Add sql query to cache_key

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
When changing the SQL query in a datasource, the cache key doesn't reflect this change, as only the datasource id is added to the cache key. This PR adds the sql property of the datasource to the dict on which cache_key is based.
While this fixes the problem for SQL "views", this doesn't address other potential changes in the datasource, e.g. changes in expressions. An alternative approach would be to add the changed_on value from the datasource, which would change the cache key every time the datasource is updated. By doing so we would not need to add all properties that need change checking from the datasource to the cache key; however, it might result in unnecessary cache misses if minor changes to the datasource are done regularly.
TEST PLAN
Tested locally by replicating the problem in the issue, and ensuring that the bug goes away with this diff. Unit tests to be added once we decide how to handle change tracking of datasource properties.
ADDITIONAL INFORMATION

[ ] Has associated issue: closes #8898
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@durchgedreht

Codecov Report

Merging #8901 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8901   +/-   ##
=======================================
  Coverage   58.97%   58.97%
=======================================
  Files         359      359
  Lines       11333    11333
  Branches     2787     2787
=======================================
  Hits         6684     6684
  Misses       4471     4471
  Partials      178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191aca1...7713e08. Read the comment docs.

Thanks for this @villebro! My recommendation would be to go with the changed_on timestamp instead of the sql column. As you mention, Datasources define a number of different things that could affect cache behavior or results. Causing cache misses on every Datasource update feels more future-proof, as this logic won't need to change every time Datasource behavior changes. We may cause some unnecessary cache misses, but I think we should lean in the direction of ensuring correctness first and thinking about performance second.

Thanks for chiming in @willbarrett ; personally I also started leaning towards using changed_on instead of all potentially interesting attributes. I'll update the PR to reflect this. It would be valuable to hear if large deployments of Superset are using large scale automated metadata refreshes of existing datasources, and if this might cause unnecessary cache misses. @john-bodley @etr2460 @betodealmeida any feedback would be valuable to understand if this would be a blocker in your deployments?

As there doesn't seem to be any objections to adding changed_on to cache_key, I'll try to finalize this in the coming days.

FYI working on this fix+unit tests surfaced some other issues I will be addressing with this PR, i.e. will take slightly longer to complete than anticipated.

This is ready for review.

@villebro do you think there is merit in adding a line item to UPDATING.md to mention that this PR will invalidate the entire cache given that the hashing logic has changed?

@john-bodley oh absolutely, good idea. Will add a note in UPDATING.


Fixed Output images in Predicting Multivitamine Purchase

Related Issues or bug
Fixes: #412 Output images in Predicting Multivitamine Purchase.
In the Predicting Multivitamin Purchase under the Prediction models, the readme.md file needed to be updated. Under the output section, the links were given which referenced to nowhere.
Proposed Changes
I have attached the proper images in the output section .
Screenshots
Original

Updated

@UppuluriKalyani Please review the changes and add the level tag.
Thanks !


fix issue #851 [spark-clickhouse-sink] Support /DateTime64/DateTime/Date Column

Purpose of this pull request
fix issue #851
spark-clickhouse-sink Support /DateTime64/DateTime/Date Column
step to test
-- create source table
CREATE TABLE pdi.st_source_dates
(
    `date01` Date,
    `date03` DateTime,
    `date04` DateTime,
    `cust_id` String,
    `cust_name` String,
    `cust_idcard` String,
    `age` Int32,
    `sex` String
)
ENGINE = StripeLog

--create target table
CREATE TABLE pdi.st_sink_dates
(
    `date01` Date,
    `date03` DateTime,
    `date04` DateTime64,
    `cust_id` String,
    `cust_name` String,
    `cust_idcard` String,
    `age` Int32,
    `sex` String
)
ENGINE = StripeLog

make Some test data
insert into pdi.st_source_dates values
('2022-03-05','2019-01-01 12:12:22','2019-01-01 12:22:22','1111111','test_nameaaaa','card11111111',55,'男'),
('2022-03-05','2019-01-01 12:12:22','2019-01-01 12:22:22','1111111','test_naaaa','card11111111',90,'男');

config SeaTunnel
vi ./config/jdbc2ck_dates.conf
env {
  spark.app.name = "SeaTunnel"
  spark.executor.instances = 2
  spark.executor.cores = 1
  spark.executor.memory = "1g"
}

source {
  jdbc {
    driver = "ru.yandex.clickhouse.ClickHouseDriver"
    url = "jdbc:clickhouse://<IP_ADDRESS>:8123/pdi"
    table = "st_source_date"
    result_table_name = "SOURCE_VIEW"
    user = "default"
    password = "jRtXD8F8"
  }
}

transform {
}

sink {
  clickhouse {
    host = "<IP_ADDRESS>:8123"
    clickhouse.socket_timeout = 50000
    database = "pdi"
    table = "st_sink_date"
    fields = ["date01","date03","date04","cust_id","cust_name","cust_idcard","age","sex"]
    username = "default"
    password = "jRtXD8F8"
    bulk_size = 20000
 }
}

start SeaTunnel
./bin/start-seatunnel-spark.sh \
--master local \
--deploy-mode client \
--config ./config/jdbc2ck_dates.conf

check the data in target table
select * from pdi.st_sink_dates

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in you PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@CalvinKirs Please have a review

@ZhangchengHu0923 Please resolve the conflict, thanks

@ZhangchengHu0923 Please resolve the conflict, thanks

done

@CalvinKirs LGTM


Add ShowTypingMiddleware

This adds a ShowTypingMiddleware to botbuilder-core, as well as some unit tests.
This is basically a port of the dotnet version, with some slight changes for Javascript.
Should address #470.

Pull Request Test Coverage Report for Build 1697

24 of 29 (82.76%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 70.414%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-core/src/showTypingMiddleware.ts
23
28
82.14%

Totals

Change from base Build 1690:
0.02%

Covered Lines:
2228

Relevant Lines:
3032

💛  - Coveralls

Any more feedback on this, @stevenic?


fix sort spill memory limit

Proposed changes
Issue Number: NA
Problem Summary:
Sort spill does not work since spill is triggered when memory limit exceed but some more memory need to be allocated during spilling.
This pr fix sort spill memory limit by:
1.change block_mgr_limit from exec_mem_limit to half of block_mgr_limit
2.trigger spill when 1/2 of block_mgr_limit is used, implemented in should_spill() function
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No)
Has document been added or modified: (No Need)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Hi @xinyiZzz , Thanks for you comment.
The purpose of the first 1/2 is to reserve half of exec_mem_limit for other components rather than block_mgr. The purpose of the second 1/2 is to trigger spill before block_mgr_limit is full. Maybe twice 1/2 seems to be conservative.

The purpose of the first 1/2 is to reserve half of exec_mem_limit for other components rather than block_mgr. The purpose of the second 1/2 is to trigger spill before block_mgr_limit is full. Maybe twice 1/2 seems to be conservative.

The first 1/2 I understand, great~, but I'm not sure if 1/2 is a good value.
The role of the second 1/2. Currently, BufferedBlockMgr2 has a similar implementation. In write_unpinned_blocks, unpinned blocks will be spilled in advance to avoid waiting when full.

The first 1/2 may be OK, you can add a TODO, and then we may need a complete Query memory estimation model.


Reduce the unnecessary mutex

The job_available_mutex will unlock after calling the
condition_variable::wait, and lock after it return. It means queue_mutex is unnecessary.
change:

reduce the unnecessary mutex
avoid dead-lock in job_available_var.wait's predicate, remove the call of JobsRemaining

next_job deadlocks in your code if the queue is empty, and you're waiting on a new job. ThreadPool::AddJob locks queue_mutex, but it can't because it's been lock already in ThreadPool::next_job.

I don't see the potential deadlock that you see in my code. Could you clarify? The additional job_available_mutex is needed because the queue_mutex is unlocked in the middle of next_job.

in my  pull request , when job_available_var.wait calling, the condition_variable::wait function will unlock the queue_mutex. and when current thread was notified, the condition_variable::wait  funciton will lock the queue_mutex. So no deadlocks for ThreadPool::AddJob. Is it right?http://www.cplusplus.com/reference/condition_variable/condition_variable/wait/

the "avoid dead-lock" in commit message means: After removing the job_available_mutex, It make a deadlocks in  job_available_var.wait(); Because when wait() was notified, it will lock the queue_mutex again( in my pull request), then check the predicate (JobsRemaining()) || bailout). But JobsRemaining require the queue_mutex, so it will make a deadlock.

Sorry, my English is poor.

Ah, I understand. From here next_job can be simplified further by removing the if( queue.empty() ), and replacing it with just the wait:
std::function<void(void)> next_job() {
    std::function<void(void)> res;
    std::unique_lock<std::mutex> job_lock( queue_mutex );

    job_available_var.wait( job_lock, [this]{ queue.size() || bailout; } );

    // Get job from the queue
    if( !bailout ) {
        res = queue.front();
        queue.pop_front();
    }
    else { // If we're bailing out, 'inject' a job into the queue to keep jobs_left accurate.
        res = []{};
        ++jobs_left;
    }
    return res;
}

which is effectively
std::function<void(void)> next_job() {
    // ...
    while( !(queue.size() || bailout) )
        wait( job_lock );
    // ...
}

If the queue is empty, then it will wait, otherwise it will just pass over the wait.
I didn't know that condition_variable::wait released the lock on the mutex; the API that I was looking at didn't mention that. Thanks!

I didn't know that condition_variable::wait released the lock on the mutex; the API that I was looking at didn't mention that. Thanks!

Then shouldn't the same be done in WaitAll as well?

Yes, it seems well.
btw, U can see my new PR, maybe better.


Fix nil pointer panic in telemetry config

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #4332   👈

This comment was auto-generated by Graphite.

Should we add a regression test?


Disable delete commands

Honestly, as I was about to approve the review, I realized how painful learning of elisctl would be for me if I didn't have these commands to clean up my experiments.
Now I feel we underestimated this aspect in the last discussion and perhaps shouldn't remove this for the time being - seems to me the right tradeoff is to live with the downsides for now and make it easy for new users to just experiment.


Add progress bar to simulation

It's very annoying to not know how long a simulation is going to take. Users should hopefully also be aware of a few running statistics:

Time per simulation
std-dev of a result over all time-steps (which we expect to decrease at $1/\sqrt(n)$
mean of a result over all time-steps (a non-zero value is very helpful very early).

Tracked in #47


Divide by zero check

Initial changes and idea on how to handle div by zero.
The idea here is we detect and match div/zero instructions so we preserve the rest of the graph, and then during our final checks (similar to dangling reference checks) we detect any divzero instructions. This would mean we also create a divzero instruction operator, but I'm not sure the correctness of this approach.
Reused and reverted the simplify algebra changeset's divide by zero changes to start this since we could reuse the unit test to validate that we are inserting a divzero in the correct spots.

Found a fun case and something to think about, not sure if just late and be chasing better coverage on compute_shape()/compute() is leading me to somewhere valid.
auto div0  = mm->add_instruction(div, x, 0)
run_pass(*mm)   // <- this makes div0 replaced with @divzero

div0->do_something_else()

Not sure if this is contrived right now in a test case I created or a real issue. Got around it by just specifying the instruction directly using add_divzero and going to see if things don't break here. How do we know we're not creating stale references after every pass or is this something that only seems to come up when we write test cases?

Found a fun case and something to think about, not sure if just late and be chasing better coverage on compute_shape()/compute() is leading me to somewhere valid.
auto div0  = mm->add_instruction(div, x, 0)
run_pass(*mm)   // <- this makes div0 replaced with @divzero

div0->do_something_else()

Not sure if this is contrived right now in a test case I created or a real issue. Got around it by just specifying the instruction directly using add_divzero and going to see if things don't break here in the latest fixup. How do we know we're not creating stale references after every pass or is this something that only seems to come up when we write test cases?

div0 is instruction_ref. After run_pass, all its  references will get replaced by divzero  and  stale references to div0 would be cleaned up by deadcode. For  the div0->do_something_else(),  Instruction_ref are more of abstract to  represent graph. It creates  sort of  edges. I've  not seen  cases where we directly operate on instruction_ref like div0->do_something rather we operate on memory buffers like argument, literal etc. through visit() or visit_all().   I don't think we should worry about case like div0->do_something.

Okay that eases my mind on that then.

Closing and will revisit later


DLL external procedures not working in Linux

Well, that's quiet obvious, but the game won't compile under Linux:

Compile Project, Target: Trollhunter: Exit code 256, Errors: 1
...
Linking Trollhunter
/usr/bin/ld: cannot find -lBearLibTerminal
/usr/bin/ld: cannot find -lBeaRLibItems.dll
/usr/bin/ld: cannot find -lBeaRLibPF.dll
Trollhunter.dpr(74,1) Error: Error while linking
Trollhunter.dpr(74,1) Verbose: There were 1 errors compiling module, stopping

as it can't find/use DLL libraries in BeaRLibItems.pas, BearLibTerminal.pas and uMob.pas. Thou, as I see BeaRLib should be cross-platform? You're using this version https://github.com/bearlib, right? It does also seem to do direct *.dll calls in external definition. I've tried also compiling an example there and it doesn't work either. Well... looks unfixable (easily I mean :))?

There are cross-platform versions of libraries. Problem with pathfind only.

Running a DLL on Linux? Hmm... that shouldn't work. Linux uses *.so libraries and I couldn't find those for BearLib. Anyway, I've found one more problem for me :) DLLs are 32 bit and my Linux is 64 bit :) So it won't even run in Wine.
So, I'm not sure if its worth it. Sorry for disturbing. I'll check a Windows version when I'll have the time :)

A bit more on the issue: Seems the libraries just need to be recompiled to Linux (*.so format). The sources are available, but I'm not sure how to :)

Can these links help?
Src:
BearLibTerminal - https://bitbucket.org/cfyzium/bearlibterminal
BearLibItems - https://github.com/bearlib/items
Bin:
BearLibTerminal - http://foo.wyrd.name/en:bearlibterminal#download

Yes, it seems that all of the above are available here https://github.com/bearlib
I'll see what I can do about these. Good stimulus to learn library compilation :)
Українською теж можна :)

Вітаю брате козаче! Ще хвильку і я комітну версію без BearLibPF.dll ;) Менше .dll - легше порт на Linux :)

BearLibPF.dll випилив :)


Interdomain tests are unstable

Description
Interdomain tests are not working see at https://github.com/networkservicemesh/integration-interdomain-k8s/pull/54
Potential cause: https://github.com/networkservicemesh/sdk/pull/1072
We need to investigate and solve all issues that make CI red.

I think this is fixed: https://github.com/networkservicemesh/integration-k8s-kind/pull/367 :)

It seems like the problem is not related to begin.

Closing due Is not reproducing.


DATABASE_METADATA.json enhancement

What do you think about migrating our DATABASE_METADATA.json content to something more talkative?
I mean now we have:
{"version":2}
wouldn't it clearer to have something like:
{"format": "BONSAI", "version": 1}?
Where format field is BONSAI or FOREST and version is the actual iteration of the format.
I am suggesting that, since I need to introduce a new version of the db, to identify the variables storage upgrade, and since it applies to both formats, with the current metadata, I should introduce 3 and 4 respectively from Forest and Bonsai, but I will prefer to have:

{"format": "FOREST", "version": 2}
{"format": "BONSAI", "version": 2}

Changing the DATABASE_METADATA.json format is a breaking change so we also need to define a migration strategy, and how to version the DATABASE_METADATA itself.
We can consider the current DATABASE_METADATA format, the v1, and it has 2 fields:

version
privacyVersion

we could introduce v2, changing the filename to DATABASE_METADATA_v2.json, example of its content:
{
    "format": "BONSAI",
    "version": 2
}

relates to #6307


Error message Something went wrong, try again!

Description
I have an en.json with only 4 values:
{
	"colors": "Colors",
	"compact_answer_mode": "Compact answer mode",
	"true": "true",
	"false": "false"
}

My langsync.yaml looks like this:
langsync:
source: "./en.json"
output: "./"
target: [de]
languageLocalizationMaxDelay: 200
I run langsync start and get the following output
 langsync start
Localizing process starting..
✓ Your langsync.yaml file and configuration are valid. (25ms)
.    Saving your source file at ./en.json..... (1.1s)

✗ Something went wrong, try again! (1.2s)

I am using windows 11
langsync --version
0.9.51

Hello there,
A new fix and version have been deployed, could you give it a try now?
if you have any other requests or issues, please let us know.

Another thing is that you need to authenticate LangSync CLI with your account API key, you can get your own from LangSync Dashboard, then use that key to authenticate by running the command:
langsync auth --api-key=<YOUR_API_KEY>

Now you can process with starting a localization process.
To Note: The tool is still free to use at this point, I would appreciate it if you could give it some time to try it as needed and provide me with some feedback to improve it.
Thank you again!


Opayo provider callback fails

We have wired up our Opayo provider with Vendr v2 (on Umbraco 9) and currently can't process any payments.
Upon taking the card details Opayo tries to redirect back to the Vendr site.
We receive the following error:

This is because the callback URL that Vendr returns throws a 500 error.
I have investigated and found the error is a null reference, in CallbackRequestModel.FromRequestAsync the request parameter is null... Further digging brought me to looking at PaymentProviderContext in the Vendr Core, which has 2 internal constructors: one that takes a request, and one that passes null through for the request instead. The base payment provider uses the constructor without request and therefore the payment provider goes💥 when it calls ProcessCallbackAsync.
Previously in Vendr V1 the request was passed in to ProcessCallback as a parameter.

I believe this should be resolved in the current unstable feed. The problem was the new PaymentProviderContext wasn't being updated with the request object when it was converted into a stronly typed model. This has now been resolved.
There should be a 2.0.1 build on the unstable feed if you want to test it, otherwise the update will be pushed out some time this week.


GEOPY-1212: address reports from static code analyzers [WIP]

waiting for https://github.com/MiraGeoscience/geoapps-utils/pull/11 to be merged first

Looks like changes were included in #21. Can we close this?


help!!!

hello my friend...what amazing project...congratulations!please tell me something if  I wan transcribe correct I have to choose at least medium...there is some way to transcribe faster?and if yes,can you explain me what I have to do?
                                                        THANKS A LOT!!!

The bigger the model, the more quality it will have. Quality will also depend on language, some have good quality, some not so good. As this is quite resource intensive work for the computer a way to make it faster is to get a GPU video card. Transcribing on GPU video cards will be faster. Fastest model to run on a CPU without a GPU video card is Whisper.cpp

To speed up Buzz you can use external API servers and transcribe on GPUs provided by them.
Get the latest version - https://github.com/chidiwilliams/buzz/releases
See APIs that you could use - https://github.com/chidiwilliams/buzz/discussions/827


Support auto-detection of CubeResource types

Alternative for #6405.
@GoodBoyDigital please confirm that it works for your project.

Could you add a unit test for this? Just make sure we get a CubeResource back?

Codecov Report

Merging #6409 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev   #6409   +/-   ##
=====================================
  Coverage   76.9%   76.9%
=====================================
  Files         69      69
  Lines       3914    3914
=====================================
  Hits        3010    3010
  Misses       904     904

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c9cc0...ea0931d. Read the comment docs.

we could use ArrayFixed in utils for an array of a defined length for CubeResourse content

Yep, I approve the fixed size in type.


flush existing connections on steal

Bug Description
on calico k3s we found out that steal doesn't work until established connections are reset, probably due to different behavior in that setup.
possible solution is to have conntrack binary in our image and call conntrack -F on each stolen port after adding the rule.
**this should be controlled via env var, at least for the first version, then decide if to make it enabled by default **
Steps to Reproduce
calico + k3s
Backtrace
No response
Relevant Logs
No response
Your operating system and version
n/a
Local process
n/a
Local process version
No response
Additional Info
No response

This fixed their issue. Need to decide if we want is by default.

@meowjesty Discussed this with @aviramha , can you please change it to default to true?


add .travis.yml

For testing PRs

Do you vow to maintain this thing with travis? (because I really really don't like travis)

sure, I'm already using it elsewhere


Fix missing sudo on installation_raspbian.md

@alexmehta Thanks!
Can you please base & redirect this PR to development branch as mentioned here: https://github.com/IntelRealSense/librealsense/blob/master/CONTRIBUTING.md

I'll base/redirect this to the dev branch!


Replace :ban with the new BanAsync API

What part of Adonis is this related to?
Command
What are you suggesting?
As the title suggests.
https://create.roblox.com/docs/reference/engine/classes/Players#BanAsync

This is already planned and in progress
Use this until it's released
https://github.com/Epix-Incorporated/Adonis-Plugins/blob/master/Server/Server-Banning API.luau

Related to #1561


Upgrade Cypress Version

Cypress latest version upgrade
Test coverage results :test_tube:
:white_circle: Total coverage has not changed
No changes to code coverage between the base branch and the head branch

/ok-to-test sha=f2dd213

/ok-to-test sha=676fa49

/ok-to-test sha=676fa49

/ok-to-test sha= e007ba9

/ok-to-test sha=e007ba9

/ok-to-test sha=e007ba9

/ok-to-test sha= e007ba9

/ok-to-test sha=e007ba9

/ok-to-test sha=91ae065


RC Spot-Check Test: Graphing Slope-Intercept 1.2.0-rc.2

RC Spot-Check Test
Mentions: @amanda-phet
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html

Test Matrices
General Test:

[x] Tester = NS , Platform = mac + safari/chrome, Time = .25
[x] Tester = KW, Platform = Win 11 Chrome, Time = .25

Additional Features Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Features included

Region and Culture (R&C)
Dynamic Locale
UI Sound
PhET-iO
Alternative Input
Sonification
Description
Voicing

Focus and Special Instructions
Plan to do this test at the same time as https://github.com/phetsims/qa/issues/1074, since Graphing Slope-Intercept is derived from Graphing Lines.
Issues to Verify
These issues have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.

[x] https://github.com/phetsims/graphing-lines/issues/152
[x] https://github.com/phetsims/graphing-lines/issues/153
[x] https://github.com/phetsims/graphing-lines/issues/155
[x] https://github.com/phetsims/graphing-lines/issues/156
[x] https://github.com/phetsims/graphing-lines/issues/158
[x] https://github.com/phetsims/graphing-lines/issues/159

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test some query parameters. (See QA Book for a
list of query parameters.)
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
is a problem.
As the RC ends, notify the developer of any new QA credits that need to be added.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

QA is done

Thanks for the quick turnaround!  We're ready to publish 1.2.0. 🎉


[AppCenterTest] "Error: Too many requests" when waiting for test results

Environment

Server - VSTS, DevDiv
Agent - Hosted

Issue Description
It appears the AppCenter Test task which by default "waits" (by polling from what I can tell) for the test to finish can occasionally fail with Error: Too many requests. This tends to happen when my AppCenter account is "backed up" due to concurrent device limitations.
I'm assuming this is a API rate limit kicking in against the token I'm using due to the long wait times. This seems unfortunate that a users build can fail due to this. Perhaps there needs to be a way to set how often the task "polls" AppCenter? Or calls from this task don't count against the rate limit?
Error logs
2018-02-21T04:03:37.1111300Z Error: Too many requests
2018-02-21T04:03:37.1118080Z
2018-02-21T04:03:37.1131880Z Further error details: For help, please send both the reported error above and the following environment information to us by going to https://appcenter.ms/apps and starting a new conversation (using the icon in the bottom right corner of the screen)

Thanks for reporting this bug. I'll record it for triage and hopefully it will get prioritized accordingly.

Discussing with PM

@kdubau sincere apologies for the delay in reply.
May I please confirm that this is still occurring.  May I additionally confirm that you had multiple test runs submitted by the same user, with the same IP Address?

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

Given it's well over two years later, I don't work on this project any longer and don't have the means to let you know if it's still an issue or not. If no one else has complained, I suspect we can close it. Thanks!


Bump honggfuzz version

Bump hongfuzz version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.094%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19508

Relevant Lines:
23477

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.094%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19508

Relevant Lines:
23477

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.094%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19508

Relevant Lines:
23477

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.094%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19508

Relevant Lines:
23477

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.094%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19508

Relevant Lines:
23477

💛  - Coveralls

Is this still open because updating Cargo.toml is controversial?  If it gets more acks I am happy to remove the toml part.

It was just waiting for a second ACK or two weeks to go by. I will merge it now.


Update About Page with new copy and illustrations

Context
This is a dev hand-off ticket
Problem or idea
The updated mockup for the About page and a link to the new copy can be found in this figjam file
I want to note that there are also separate illustrations for smaller screens (mobile).
We want to do this at the same time as https://github.com/AlexsLemonade/scpca-portal/issues/485
Solution or next step
Tagging @davidsmejia for next steps

Closing in favor of #529  and #530


fix: added kp endpoints in output

Description
Added kp endpoints in output.
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

I'm skipping upgrade test, see why in https://github.com/terraform-ibm-modules/terraform-ibm-key-protect/releases/tag/v2.5.1
@Ak-sky Check out https://github.com/terraform-ibm-modules/terraform-ibm-kms-all-inclusive/pull/404#discussion_r1472654123 - I think I agree with the comment

/run pipeline

/run pipeline


Support for older models

I own an old BRAVIA model (KDL-40EX521, 2012 I think) and the IRCC interface is exposed on http://<ip>/IRCC, instead of http://<ip>/sony/IRCC. Furthermore my BRAVIA doesn't need the PSK (but a fake X-Auth-PSK: 0000 header doesn't hurt).
Is it possible to have a flag in the integration configuration to force the old URL without the "/sony/" part? I think that this addition will add support to my and many other old models. Thank you.

I have had an older Bravia model and the API support was very limited, so it seems to be that the other url will not be the only part that needs to be changed.
Have you had a look at https://www.home-assistant.io/integrations/braviatv/#for-tvs-older-than-2013?

I think that using CEC client provides a very limited set of functionalities to control the TV (on and off). On the other side I have this app https://play.google.com/store/apps/details?id=tv.remote.control.sonytv on my mobile phone and I have a perfect replica of my TV remote that provides full control. I can can select input source, change TV channel, turn TV off, enter TV menu, whatever I can do with the remote. I sniffed the data stream between the app and the TV and it uses the IRCC protocol to send the simulated button pressures.

Allright let's give it a try 😄
I have change the url in the lib from /sony/IRCC to /IRCC and made a beta release.
Can you test it by changing requirements in manifest.json from
pySonyBraviaPSK==0.2.3 to pySonyBraviaPSK==0.2.4b0?

Hi,
I have a similar model (40EX720) and works with  on my mobile phone.
In manifest.json, I have changed pySonyBraviaPSK==0.2.3 to pySonyBraviaPSK==0.2.4b0.
I try to integrate my TV, I enter the IP of my TV but no code PSK appears on my TV.
What's wrong?
@lcavalli , is it working for you?

Hi,
tried the beta version of the Bravia PSK library and although I'm confident it could work with the legacy IRCC endpoint on the TV, unfortunately the integration is blocked by the preliminary configuration steps done via the bravia_req_json calls (get TV power status, volume status, etc etc...).
Maybe the best solution here is not to touch the current library and try to develop a legacy integration, alongside with a minimal IRCC library.

That's a pity it doesn't work. Feel free to fork this repo and try if you get it to work.
Closing this issue.


Add relay security schemes example integration

AN-511
Note the name relay-security-schemes was chosen as this is the nomenclature used in the docs.
Ignore the failing docs link check in CI- this will pass once merged.
Here is how the output looks:
> yarn make-request
yarn run v1.22.11
$ ts-node scripts/make-request.ts
Making request...
Waiting for fulfillment...
Request fulfilled
The following was successfully relayed:
    requesterAddress: 0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512
    sponsorAddress: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
    sponsorWalletAddress: 0x68F7F1197a9FD5f2EC79B4eBff2879A1dc1fe78f
    chainId: 31337
    chainType: evm
Done in 20.31s.

@Siegrift  - the unit tests were actually failing because the validator hadn't been updated to expect security schemes relaySponsorAddress and relaySponsorWalletAddress. See the latest commit in this PR for the fix.


feature: Rename application and project to Epinio

Fixes: #268
Co-authored-by: Dimitris Karakasilis<EMAIL_ADDRESS>

CI is being throttled again by dockerhub. Tests are green locally:

Merging


Use bootstrap ScrollSpy with anchor using dots?

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Context
In the development of the pydata-sphinx-theme we use extensively twitter bootstrap to build the UI of a Sphinx generated documentation. When documenting Python API, the Autodoc plugin (that reads the Python docstring and transform it into a documentation page) creates anchors for functions that correspond to the exact path f the method: "pandas.DataFrame.from_csv". These points seems to be incompatible with the twitter bootstrap ScrollSpy tool as they are not interpreted as correct anchors.
For interested reader, see this thread for more context: https://github.com/pydata/pydata-sphinx-theme/issues/1435
reproducible example
I created this small fiddle by adapting one of bootstrap example: https://codepen.io/12rambau/pen/rNovoyw

    Item 1
    Item2
    Item 3
    Item 4

Item 1

 ...

Item 2

 ...

Item 3

 ...

Item 4

 ...

As you see it's simply not working as I replaced the target names by "item.1" instead of "item 1".
Going down this issue, it seems related to how uri are parsed in bootstrap. Is there any will to support my use case ? if yes how can I help, if not do you see a workaround that would not imply using  custom scrollspy ?

Thanks for opening this issue @12rambau.
I haven't checked in detail this precise use case yet but it could be linked to my comment here https://github.com/twbs/bootstrap/pull/39201#pullrequestreview-1631418743 where it seems that the specification really allows almost all characters as IDs and that maybe our selector engine is too restrictive in a way.
We need to dig that :)

just wanted to add that we've stumbled across this problem, too. It basically affects all JS modules, e.g. modal, collapse, etc. As soon as the ID has anything in it that has a special meaning in a selector (e.g. ., ,, +, ~), the functionality breaks. According to HTML standards, the only character that's not allowed in an ID is a whitespace, so it would be great if bootstrap could support that


Data viewer window launched from the variables view is empty

Testing #10184

Add a cell:

# %%
a = dict()
b = [("a", "one"), ("b", "two"), ("c", "three")]
c = {k: v for (k, v) in b}
print(c)

Debug the cell
Open the variables view and notice that an icon appeared next to the variable name ("Show variable in data viewer")
Click on the icon for one of the variables, note that the Data Viewer window that opened is empty:

For web in May we're removing the button as this support is not ready for web yet.

@sadasant, looks like the complaint here is in the desktop versions, not web. But I've marked it as vscode-web anyway. Need to make sure this works in web and desktop for  June.

I experienced this same issue in desktop VS Code when opening a list's data viewer from the variable explorer. Video recording here: https://msit.microsoftstream.com/video/ae7b0840-98dc-bd6c-7484-f1ecfee3c9d9?st=590
Version: 1.69.0 (user setup)
Commit: 92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9
Date: 2022-07-07T05:28:36.503Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22000

Thank you, @olguzzar ! I'll follow up this month.

Unable to repor this issue.
@olguzzar @joyceerhl @linette-zyy are you still running into this issue?

Closing this issue as its been over 4 weeks, since the information was requested.
We'll be happy to reopen the issue when the requested information has been provided.


:xrefstyle:  is not supported.

Is it possible to support:
:xrefstyle: full

to show the section number in cross refererences to sections in the same document?
See https://docs.asciidoctor.org/asciidoc/latest/macros/xref-text-and-style/

You need to pass xrefstyle attribute value: https://github.com/confluence-publisher/confluence-publisher/blob/master/asciidoc-confluence-publisher-converter/src/main/resources/org/sahli/asciidoc/confluence/publisher/converter/templates/helpers.rb#L175 and also fix problem that link text is always a plaintext.
Full fix can be found in associated text2confl issue commits


Plantcv clowder extractor

This adds several enhancements/changes to the PlantCV processing script and extractor. The script has been generalized in places to allow functions to be called directly from command line or extractor and utilize same shared code wherever possible.

@max-zilla can you assign the person that should give the OK and/or merge this pull request.

@yanliu-chn I'm assigning this to you, because Noah seems content with his script and I think the extractor is working. I know you've done some work on this before so I wanted to to get the chance to see before merging.

@max-zilla should the folder extractor_with_avg_traits with two .pyc files be part of the merge? Otherwise looks good to me.

@nfahlgren no, i thought I took care of those - looks like they must've snuck it at some point (there are other PYC files I didn't commit, havent set up gitignore for them). Just removed them.

@yanliu-chn just checking that you will merge right? Want to make sure no one is waiting on me. Thanks!

@nfahlgren i asked Yan to review, he's been out of the office. I'll go ahead and merge.