Add way to update offices / all user information for admins?

There's no easy way to update someone's offices or adjust some user information (e.g. grad_year). This should be available for certain users (librarian, secretary, imss).
Currently, have to do this via the database directly. Two main parts to this:

New tool to update user offices
Allow editing of more fields if appropriate permissions on the current edit-user page.

Replacing this issue with #92 and #93


Theme and links

Updates theme
Adds doc switcher menu

Blowing this out. Not sure what's causing all the conflicts.


Removing github workflow - common-files publishing

What does this implement/fix? Explain your changes.
Removes the Github workflow that tries to publish the common-files package to NPM
Does this close any currently open issues?
No
What commands can I run to test the change?
Not needed
Any other comments?
No

I would go further with this one and remove all npm links and common-files imports from module and replace it with relative path. Literally revers all what I did when we tried to modularise it for the reusability that never came to be.

I would go further with this one and remove all npm links and common-files imports from module and replace it with relative path. Literally revers all what I did when we tried to modularise it for the reusability that never came to be.

I agree with you, but this is a huge work to do. I believe that Duncan said that he is gonna do that.


Cleanup default expressions

I'm doing a build locally to check that docfx is happy with this too.

This is just for the manually-written code at the moment, right?
@chrisdunelm presumably it won't be hard to change the codegen for DatastoreClient etc?

Correctly, I went through all changed files and manually reverted the auto-generated ones. If you think I missed any, let me know. Most of them were ...Grpc.cs files from the protobuf compiler.

SGTM. I suggest we then change the generator, regenerate, then chase stragglers. Still building...

Docs build failing at the moment:

Error:Error extracting metadata for C:/Users/jon/Test/Projects/google-cloud-dotnet/apis/Google.Cloud.BigQuery.V2/Google.Cloud.BigQuery.V2/Google.Cloud.BigQuery.V2.csproj: Value cannot be null.

I haven't actually tried without this change yet - will do that now. Upgrading docfx could sort it anyway.

Nope - works in master, fails in this - even with docfx 2.22.3.
Will file a bug with docfx on Monday (with a short but complete example).

Thanks Jon. I'll leave this open until that gets resolved.

Hmm - I can't reproduce the docfx problem in a standalone sample, so this will take a bit more investigation.

For anyone interested, I've blogged about the process of diagnosing the bug, and filed an issue with docfx.

I'd hoped this was fixed in docfx 2.23.1, but it generates invalid (and partial) API metadata.

Based on your analysis, it seems we could work around this by changing some expression bodied methods to normal methods. But maybe we should wait a bit longer to see what happens with the docfx issue.

Would definitely rather wait. I suspect it may well be sorted soon.

This can be merged now after a rebase.


Can not add ingestion pipeline for Testsuite

Slack conversation here: https://openmetadata.slack.com/archives/C02B6955S4S/p1689933249988789
Affected module

Ingestion Framework

Describe the bug
For a table which does not have any test case, go to pipeline then Add Ingestion then click, OM will move to 404 page.
For a table which has at least one test case, go to pipeline >>Add Ingestion button not appear. I can not create any Pipeline for any Testsuite.
For Testsuite default for each table, It's not shown on the Data Quality page (test suite tag) so we can not adjust (add or remote) testcase belonging to Testsuite default. If you have some testcase not ready for run, the only way is to delete it then it will not run with other testcase in Testsuite default.
To Reproduce
Screenshots or steps to reproduce

Expected behavior

User can select testsuite and add pipeline in Data Quality
User can add/remote Testcase in Testsuite default and TestSuite Default should be appear in Dataa Quality Page
Testcase maybe need a flag (Activate/DeActivate) so when Run Test Suite only Active Testcase is run in stead of delete Testcase or remove from Test Suite.

Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: OM 1.1
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

Hi @ShaileshParmar11, how about this expect behavior: "User can select testsuite and add pipeline in Data Quality
User can add/remote Testcase in Testsuite default and TestSuite Default should be appear in Dataa Quality Page
Testcase maybe need a flag (Activate/DeActivate) so when Run Test Suite only Active Testcase is run in stead of delete Testcase or remove from Test Suite"
#12575 as I understand only fix issues related to redirect 404.

ok, the issue got closed by mistake, we need to think about other points, and yes the current solution in #12575 is related to redirection. @hoangdh5

@hoangdh5 CustomTestsuites are more like dashboarding. If a test is created, it will execute in the context of Table's test suite itself.
You can create a custom test suite to pick and choose testcase across multiple tables and create a dashboard. If the testcase is already running as part of another table's test suite why do you want to re-run them and add another pipeline to CustomTestsuite

@harshach In operation, some case need to execute testcase not in scheduled, like have to check urgent issues or adhoc request from bussiness unit, or sometime I just want to run a newly testcase added, I have to run all other . Or other usecase like you have some different kind of testcase, and these have to run in different schedule ?. That would be bad if i have to deleted some testcase just because I don't need run it adhoc. I see we have only one testsuite for each table and so only one schedule for all of testcase. I think we can use testsuite for more features not only for group of result/ dashboarding.

Thank you @hoangdh5 for you suggestion. We value your feedback and the contribution you make to enhance the product. We'll be closing this issue as won't fix.
OpenMetadata used to allow execution of logical testSuite where test could be group logically from different tables and executed. Based on the feedback we gather we found it was not the most optimal approach as it created opportunities to duplicate tests and also required users to think about the table refresh schedule to set up the test case. We believe executing all the test cases linked to a table is the best practice to ensure consistent data quality.
Thank you for all your contributions and feedback


fix: upgrade http-proxy module for bug fixes

The http-proxy module was significantly outdated, and was missing many
bugfixes to support node newer than 0.10, as we as a refactor and
simplification of their codebase.
This commit upgrades the http-proxy dependency, and refactors the proxy
middleware to utilize the new API.
parseProxyConfig (an internal function) now takes the proxy
configuration object and converts it into an array of "ProxyRecord"
objects, sorted by path. A ProxyRecord object contains:

host The remote proxy host
port The remote proxy port
baseUrl The remote proxy path
path The local URL path (that triggers the rewrite)
https Boolean to determine if the remote connection will be made
with SSL.
proxy The instance of http-proxy.

This change was necessitated by the removal of http-proxy's
RoutingProxy API, and the desire to only create one proxy instance per
configuration item.
The middleware simply determines if the current request matches a known
proxy path, and calls the proxy's .web and .ws methods with the
current request and response objects.
The relevant unit tests were rewritten in light of these changes.

big :+1:

This is great, a big thanks first of all!
There is only one question I have, what about the option proxyValidateSSL, why did you remove it?

ping @terinjokes

@Dignifiedquire sorry, i've been busy and didn't check in on this.
I no longer remember why I modified proxyValidateSSL, but I'll rebase this today and try to answer it for you. :+1:

Thanks

Merged as bcce56325eccc4758087a857d67be8a9366e91d6


Translated content not duplicated

Winter CMS Build: 1.2.5
Pages Plugin Version: 2.1.3
PHP Version: 8.2.0
Translate 2.1.6 (first language EN, second language IT)
Description:
When a Page with its translations is duplicated and saved, its translated content are not duplicated
Steps To Reproduce:

create a page, translate its contents and save it
duplicate this page
edit its title, url and body in the original language
select the second language but there is nothing

Thanks.

@der-On any ideas?

@LukeTowers will have a look.

@der-On when creating a static page with content for other locales, it creates the page in the content/static-pages-[locale] with that locale's content ... so that's most likely what doesn't get duplicated.


Unable to post status using rest API

above the screenshot here is my APIkey and stuff like in the exmample Folder

You should pass a body for request and use await keyword.
var a = await twitter.request("POST","statuses/update.json",body: body);

You should pass a body parameter.
var a = twitter.request("POST", "statuses/update.json",body: {"status":"test"});
a.then((value){
    new File("test.json").writeAsString(value.body);
});

Excellent thank you!


Intuitive!

It's Intuitive!
Have you try it in video? As more video frames are added, the stronger the pruning, the more interesting the text guidance will be.

@Yxxxb Thanks for your comments 😊.
Our paper currently conducts basic experiments under the Video-LLaVA framework. Perhaps we can see whether the more frames there are, the better the pruning effect.
By the way, your Voco-LLaMA is great, and we have cited it in our paper.

Congrats and thanks!


Supported patterns appear to be the same

On the page listed below it says "The supported patterns depend on whether you deploy Application Gateway v1 or v2:", followed by two tables of data which are identical, rather than showing any differences between v1 and v2.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f2769aea-56d1-03aa-1949-9818d5ee3ba4
Version Independent ID: 25394ed7-b79d-1d85-03c2-0031b666635e
Content: Azure Application Gateway URL-based content routing overview
Content Source: articles/application-gateway/url-route-overview.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@jamesots-tq, Thanks for reaching out. We will investigate and update this thread.

@jamesots-tq, Appreciate your patience. We have assigned this issue to the respective content author to update the document accordingly.

Article updated
#please-close


including reviews with app details

As they are part of the page and don't need a separate request, I've left them with the app details. Might be incomplete, though: I've noticed when browsing them at Play, it seems to have loaded more via XHR all the while. For the example you've specified in #27 it has 40 reviews included. If that's not enough and there are more, we could take a look at that for a separate method later. This one at least gets you started :smile:
So can you please test it out and give your opinion, @BaseMax?

OK, got the responses in, too, if there are any – so it's ready for your testing, @BaseMax (candidate with responses, to get an idea what to look for: com.irobot.home). Feel free to mark it ready-for-review, as that's basically what your testing task will be :rofl: Once merged, we shall not forget to update the documentation.
Oh, btw, as the commit message says I also included the token for fetching more reviews. Might come in handy if you already have the app data and want to append. Or maybe it's even needed to fetch any reviews at all if that process cannot work completely separate (so one would need to fetch appData first, then continue from there).

Thanks.
Good, we can merge it. but we need to fetch and get all reviews.

Good, we can merge it. but we need to fetch and get all reviews.

Yes, full ack. This here just implements the easy-to-get-at part in a place we're parsing already anyway. The original issue is still open (and assigned to me) – I hope to find some time to implement the additional method some day (feel free to send me a reminder every now and then; my current task-queue is quite full and I need to prioritize; also I guess the new issue about not getting versions for some apps is more important, right? For that, too, I'll see when I can get to it).
Thanks for merging!


Add swagger documentation

For personal projects I like to use swag to automatically generate swagger files for my projects and I would like to add this to golang-base-project. This should cover all routes and if possible added to the PR checks to either generate the updated swagger files automatically or to check if it has been done.

This project does not have an API routes and I think by adding api routes I would be complicating things. Swagger is used to document APIs and even if it's possible to document the routes here I do not think it's needed. Therefore I am closing this issue and may instead create other base project repositories where ReactJS or something similar is used where having an API backend may make more sense.


External dll reference gives error

Hello,
Thanks for sharing, this is very useful!
Is it possible to load external dll’s in the worker service methods? We have few math heavy simulation methods in an external dll, which takes several seconds to complete depending on the input measurements. I tried loading the dll but it gives below error. Have you done anything similar? Is it possible to use external dll’s? Please advise. Thank you!
Test-Worker-Error; ex.Message:Could not load type of field 'TestProject.Services.TestCPUIntensiveService:bb' (0) due to: Could not load file or assembly 'CPUIntensiveService.Model, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' or one of its dependencies.; ex.StackTrace:  at BlazorWorker.BackgroundServiceFactory.WorkerBackgroundServiceProxy1[T].InitAsync (BlazorWorker.Core.WorkerInitOptions workerInitOptions) <0x38f3160 + 0x00740> in :0
at BlazorWorker.BackgroundServiceFactory.WorkerBackgroundServiceExtensions.CreateBackgroundServiceAsync[T] (BlazorWorker.Core.IWorker webWorkerProxy, BlazorWorker.Core.WorkerInitOptions workerInitOptions) <0x38c8820 + 0x00156> in :0
at TestProject.Pages.TestPage.RunWorker () [0x001b9] in \TestProject\Pages\TestPage.razor:193`

An example adding references:
var Worker = await Engine.Worker.CreateAsync();
var Service = await Worker.CreateBackgroundServiceAsync<YourClassHere>(new WorkerInitOptions(){
    DependentAssemblyFilenames = new[] { "MeReference1.dll",  "MeReference2.dll" }
});

That worked! Thanks for the quick response Marcus!


Inconsistent release filenames

Packaged filenames do not match release name:
Release name jdk-9+181:

binary name has a dot: OpenJDK9_x64_Win_jdk-9.181.zip
checksum file has a dot: OpenJDK9_x64_Win_jdk-9.181.sha256.txt
content of sha256 file has a plus: 68fa...d028 OpenJDK9_x64_Win_jdk-9+181.zip

PS: The build bot re-released the same version/build# on GitHub. Is it supposed to do that?

Related to: https://github.com/AdoptOpenJDK/openjdk9-releases/issues/1

This looks like an issue with GitHub releases. I'll investigate

This is also really an API issue - we could provide the metadata via the API (source TBA) and greatly simplify the file names

Resolved with new build scripts

Hello
@karianna if I understand correctly, all new builds now have the same naming scheme?
Because earlier it was not quite clear. For example jdk8u192-b12: https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u192-b12/OpenJDK8U-jdk_x64_linux_openj9_8u192b12.tar.gz and next release https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u192-b12_openj9-0.11.0/OpenJDK8U-jdk_x64_linux_openj9_8u192b12_openj9-0.11.0.tar.gz

I think it's consistent on semVer now.

Thanks!
So there will be no more artifacts without semVer at the end of the filename, like OpenJDK8U-jdk_x64_linux_openj9_8u192b12.tar.gz ?
Also, I just noticed that there is a problem with naming for OpenJDK8 Linux x64 Large Heap builds.
All other builds use this template at the end8u202b08_openj9-0.12.1.tar.gz
But Large Heap builds have underscore after openj9. For example 8u202b08-openj9-0.12.1.tar.gz

Nice.
New builds have another naming template 🤦♂ 😞 😭 😢

JDK8u202: OpenJDK8U-jdk_x64_linux_openj9_8u202b08_openj9-0.12.1.tar.gz
JDK8u212: OpenJDK8U-jdk_x64_linux_openj9_jdk8u212-b03_openj9-0.14.0.tar.gz

So there is a new jdk in the middle

I had to add three regexps to Java cookbook to parse all combinations I found
https://github.com/sous-chefs/java/pull/540/files#diff-b4c010242f7f7f5c83ace89c9834a374R161

we are fixing this now. Hopefully, it should be back to normal by the end of the day. Thanks for noticing!

Thank you @gdams !


feat(cactus-plugin-ledger-connector-iroha): remove deprecated iroha connector

Is your feature request related to a problem? Please describe.
Iroha connector is broken for some time and it's SDK does't seem to be actively supported anymore (in regards of bug or security fixes).
Describe the solution you'd like
We should remove this package
Part of: https://github.com/hyperledger/cacti/issues/3155

Agreed!


Tooltips May be Broken in Chrome Canary

Tooltips may be broken in chrome canary because chrome no longer sends mousemove events. They have been replaced by pointermove per https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ODWmcKNQl0I
Should be easy to fix by adding 'pointermove' to the default events configuration.
I created a fiddle, which surprisingly worked in Chrome Canary that we can use for debugging https://jsfiddle.net/wfj4re3s/1/. We should do some testing to confirm

@etimberg does your tooltip issue throw the below error on console?
Unable to parse color from object ["rgba(255, 99, 132, 0.2)"]'
This error that i am getting also yields an absence of a tooltip.
If this this error is unrelated to your tooltip issue, i shall raise a separate issue for my problem.
Cheers.

@edendekker your issue is likely the fact that the color is set as an array rather than a plain string. Chrome has had weird behaviour here that is different from other browsers

Tested in Chrome 56 and there are no issues.


[Recipe] Related recipe

@asthabh23 Please confirm logic to identify related recipes, or will it be manually selected on each recipe?

@mkbansal1 Will discuss this in our call today

Related Recipe will be implements by carousel block #20


Google meet listConferenceRecordsAsync filter

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":

Search the issues already opened: https://github.com/GoogleCloudPlatform/google-cloud-node/issues
Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
Check our Troubleshooting guide: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/troubleshooting
Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/faq

If you are still having issues, please be sure to include as much information as possible:
Environment details

which product (packages/*): google-apps-meet
OS: mac
Node.js version: v20.10.0
npm version: 10.2.3
google-cloud-node version:

Steps to reproduce
  const request = {
      filter: `startTime > "2012-04-21T11:30:00-04:00"`
  };

  const iterable = meetClient.listConferenceRecordsAsync(request);
  for await (const response of iterable) {
      console.log(response);
  }

error:
          {
            "field": "filter",
            "description": "Invalid filter was provided"
          }

what is the problems

+1


How to run UI tests in windowsfamily/windows containers?

Hello
According to this post it should now be possible to run UI apps like WPF apps in the new windowsfamily/windows containers, and indeed this kind of apps do launch.
UI testing is explicitly mentioned in the post, however I (and according to the reactions on that post some other people as well) are unable to actually interact with the app through WinAppDriver or other UI automation tools.
So: is some infrastructure still missing for this to actually work? Can this be looked into? The main two issues we have right now are that it seems to be impossible to get hold of a window handle and also that there is no mouse support (most automation frameworks rely on actually moving and clicking the mouse). And I'm sure if these issues are solved there will be more...
One idea I have is to not rely on the apps running in session 0 (or whatever session they run in now), but install some virtual display driver instead so windows would run the apps on an "actual/virtual" display with actual resolution, dpi settings and all the bells and whistles of a real user session. I didn't have time to dive into this though.
So any ideas?

I also played a bit with automation without any luck.
Container : docker pull mcr.microsoft.com/windows:1809
Steps to reproduce:

Run notepad inside container
Run console utility which uses AutomationElement.RootElement.FindAll (System.Windows.Automation) to find notepad window by name.

Actual results:
Element was not found in 2 minutes period with retries each 100 milliseconds.
Expected results:
Element was found.
Additional info:

I tried both mode (interactive and non-interactive).
For automation we also use interop functions from user32.dll (SetCursorPos and mouse_events) to implement MouseClick action - cannot check if this is work or not as find element functionality does not work now.

Thanks for opening this issue and thanks @remote-specialist for the repro instructions. @Stannieman Regarding below:

impossible to get hold of a window handle and also that there is no mouse support (most automation frameworks rely on actually moving and clicking the mouse)

What framework or API are you trying to use to get the window handle? Same for the mouse controls. I think the best path forward at this point would be to get an idea of which frameworks are attempting to be used, what applications are attempting to be interacted with, etc.

For me it's a WPF app with WinAppDriver and Appium.
For the window handle: Starting notepad.exe or winver.exe and then running (Get-Process notepad).MainWindowHandle or (Get-Process winver).MainWindowHandle returns a valid handle on my real machine, however in the container both cases return 0. I figured this is probably related because WinAppDriver also times out telling me it cannot the find our app's main window element.
For mouse support: I don't know really, other people said they couldn't get mouse working. I didn't even get to that point.
I'm also a bit concerned about the resolution. Someone mentions that he managed to take a screenshot and it was 1024x768, I think that's a bit too small for our app.

@cwilhit, thanks a lot for looking at this issue.
@Stannieman, good way to reproduce issue and nice point about resolution. It would be great to have larger resolution by default.

I'm running into a similar issue, using PowerShell with the UIAutomation module (uiautomation.codeplex.com).  Our application is built using WPF with DevExpress framework for MVVM controls.
On my laptop, I can completely automate the startup wizard for this application (for instance), but inside of a container, I can see that the process has started but no controls return a Name element.  None of my cmdlets that attempt to obtain a control by name are successful.  Some cmdlets will work if I specify an AutomationId in order to obtain the control, but if I do this to grab the install wizard window, the item that gets returned is just a window object with only a single child element: a title bar.  None of the buttons, text, radio buttons, etc. that are actually children of the install wizard window are visible to the UIAutomation framework.
When I test using Notepad, I actually am able to get the window control with a name, and in a brief test I was able to at least obtain the control for the Help menu item inside of Notepad.
Even ignoring the UIAutomation module, if I run Get-Process Notepad | ? MainWindowTitle -ne "" | Select MainWindowTitle on my laptop (with an open Notepad process) I get a MainWindowTitle of "Untitled - Notepad", which I expect.  In a container, running that same command for Notepad will return the same result.  However, when I launch my WPF app, on my laptop I get the window title, but in a container it returns an empty string.
I'm concerned that the Windows 1809 container may be missing some required dependency files for WPF apps to populate correctly, perhaps?  Are there specific things I should try installing into the image, like .NET versions, Visual C++ Redistributable files, Windows 10 SDK files, etc?
I was super excited to play with this, as having deterministic testing for our automated tests was an amazing prospect, but I'm starting to swim out into waters that are way over my head trying to resolve this on my own.  Any help you could provide, even hints to move me in the proper direction, would be amazingly appreciated.

Any updates or suggestions on this?
I'm using FlaUI as the test framework for testing a WPF application.
Similar to others, I'm having no luck with any code or powershell commands that attempt to get the window of my process.

Minor update to this: I managed to get the STUPS UIAutomation to mostly work with a WPF app in PowerShell, but I had to use the -Win32 flag on the Get-UiaWindow cmdlet in order to get a working object.  I have tried messing around with FlaUI but was unable to get that working.
Some additional weirdness: I can't get menu item interactions working within a container in this.  Menu items always remain in the collapsed ExpandCollapseState, and mouse input seems to not be available, so attempting to right-click an item does not seem to do anything.  Calling any of the Invoke-UIAContextMenu cmdlets does not present the context menu, either.  Most other control functionality that I exercised seems to be working with this setup, though.

Hey all, thanks for the additional information. We suspect these UI quirks are related to the session 0 nature  of the container but we'll need to dig in to understand this a bit better.
I don't have a timeline to share right now. The more information we can get around the behaviors you're noticing, the easier it'll be for us to root cause when we do the investigation. Thanks for continuing to share these datapoints!

I'm curious if some of the interaction issues might be due to the lack of hardware classes being passed in to the container.  Namely, I cannot get a valid result from the STUPS UIAutomation framework's mouse and keyboard input classes.  Any input I try to send via these methods run, but do not successfully update any controls or return any results as they normally do outside of containers.  My assumption is that this is because the container doesn't seem to think it has even a virtual mouse or keyboard, but that could be entirely off-base.
We plan on expanding our proof-of-concept containerized UI testing this week, so I should hopefully have some more meaningful feedback soon.
I'm sure you have your own test harnesses set up for these things, but I created a repo to coincide with a blog I was writing where I test some of this functionality, if your team can use a direct example: https://github.com/JasonNoonan/PDQBlogTestApp
Not trying to plug, but here's the accompanying blog, in case the repo is unclear in usage: https://www.pdq.com/blog/ui-testing-a-wpf-app-in-windows-containers/

Do you have any luck with changing container screen resolution? The default 1024x768 is useless for UI testing purposes and Set-DisplayResolution cmdlet is missing in the container.

I wonder if we cannot solve all these problems differently.
The new Windows Sandbox feature is also based on containers, albeit somewhat customized for that particular use case.
There we have full desktop with RDP, mouse and keyboard working, high resolution, GPU acceleration and all the fancy things.
Would this mean we can set up an RDP connection to a regular container also? If yes then maybe WinAppDriver and other UI automation tools could do all the magic through remote desktop and that way bypass this session 0 madness.

@JasonNoonan I somehow mist your comment and only now read your blog post. Nice work! Now I wonder, does WinAppDriver even use System.Windows.Automation or does it have it's own plumbing to achieve similar results? If it does not use System.Windows.Automation then maybe we would already see some improvement if it did. Though I'm also convinced that there will always be quirks as long as an app running inside a container is any different than running it on a real display.

@JasonNoonan @cwilhit Do you guys have any update on your research? Has anything change on last year?
In addition to your findings I can add that there is no way to perform a screenshot using
this script on Powershell because of error:
Exception calling "CopyFromScreen" with "3" argument(s): "The handle is invalid"

I know that there is no support for RDP on containers, but what I believe we're trying to do here is kind of part of this journey. I'm not interested in providing remote access to the container's desktop, but having a local access to kind of virtual screen.

Any update on this?

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Lines/API: active element inconsistency

The interface for the other individual components use their respective lists to control the active element of that type.
The Lines interface is inconsistent with that, using the active circuit element instead:
https://github.com/dss-extensions/dss_capi/blob/ac460b047128b010716305429a17736dfb703c67/src/v7/CAPI_Lines.pas#L106-L117
For consistency, it would be ideal to change this behavior to match the other components. For example, reactors:
https://github.com/dss-extensions/dss_capi/blob/ac460b047128b010716305429a17736dfb703c67/src/v7/CAPI_Reactors.pas#L89-L97
With the refactoring done in ac460b047128b010716305429a17736dfb703c67, this only affects the _activeObj function. It would be reasonable to use the dedicated active line element by default, and use the proposed compatibility flag (#61) to toggle the original behavior.

I'll change the behavior and add the compatibility flag to restore the inconsistent version for the next version.


Feature Vision Discussion: Completions/Hints

This issue is part of the larger vision discussion managed in #63 to brainstorm and prioritize ideas around features that would make reedline as a line editor for you both viable as well as pleasant to use. Feel free to up-vote features you depend on in other tools/shells as well as suggest new ideas!
Completions Features

[ ] Ability to works as expected or better

[ ] File and folder completion

[ ] zsh-style partial path expansion

[ ] Environment variable completion $nu.env.A<tab>
[ ] Table column completion (ls).n<tab>
[ ] Sub-Command completion str <tab>
[ ] Other

[ ] Ability to add external completions for things like git
[ ] Ability to make completions extensible

Hinting Features

[ ] Ability to change the color of the hints
[ ] Ability to create hints from history
[ ] Ability to have plugable hints specific to a vertical

[ ] Nushell
[ ] Azure
[ ] Dataframe/Polars/DataScience
[ ] Maths
[ ] Other

[ ] Ability to complete hints with keybinding
[ ] Ability to change location of hints

[ ]  On prompt line
[ ]  Under prompt line
[ ]  On status bar at the top
[ ]  On staus bar at the bottom

Current voting
Vote for the topic(s) you care about by selecting the corresponding emoji. (No judgement based on the emojis sentiment!)

:+1: File path completion
:-1: (environment) variable completion
:smile: subcommand/flag completion
:tada: completion extensibility (e.g. git with ref completion)
:confused: history-based hints
:heart: hint plugins
:rocket: selectable style/behavior of hints
:eyes: language grammar specific completion configuration (e.g. semantic suggestions, signature snippets, brace matching)

For something like fuzzy completion, would it make more sense to call another tool like fzf or to write something custom?


How about adding Service Fabric as Azure container option?

How about adding Service Fabric as additional Azure container option?
Documentation can also mention that "Both Linux and Windows containers are supported in Service Fabric since 2017." and link to this article - https://docs.microsoft.com/en-us/dotnet/architecture/containerized-lifecycle/design-develop-containerized-apps/orchestrate-high-scalability-availability
Consider including & relating the info to the excellent Compute decision tree illustration on this page - https://docs.microsoft.com/en-us/azure/architecture/guide/technology-choices/compute-decision-tree

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04491fb9-6ca7-c21a-5372-a966c8ee72be
Version Independent ID: 97fa3784-c1b4-0097-1ec9-223edaa768bc
Content: Comparing Container Apps with other Azure container options
Content Source: articles/container-apps/compare-options.md
Service: container-apps
GitHub Login: @jeffhollan
Microsoft Alias: jehollan

Thanks for reporting this. I have assigned the issue to the content author to investigate further and update the document as appropriate.

@mvark  Thank you for your helpful suggestions!  We have updated some of the documents in the Architecture Center.  At this time, we do not plan to add Service Fabric as a comparable service.
#please-close


LHN - No GBR in LHN when there is a submitted expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Navigate to https://staging.new.expensify.com/
Go to the chat with User B
Submit an expense
Log out and log in as User B

Expected Result:
A GBR should appear in the LHN for the submitted expense
Actual Result:
There is no GBR displayed in the LHN for the submitted expense. it only appear after opening it and navigating back
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/9443836b-49c0-4e34-a89b-b2d94f13d24d
View all open jobs on GitHub

@slafortune  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

BE is returning proper value of hasOutstandingChildRequest only on OpenReport. BE bug.

Able to recreate this

not overdue - HotPick

Picking this up

Confirmed @FitseTLT assessment. hasOutstandingChildRequest should be set to true but is false until we open the report. Need to make the onyx data be included when opening the application and getting the reports. Hopefully a simple fix. Looking into it.

Looks like we're getting the onyx updates from Auth, not from Web, so the fix should be in there.
Seems like the stack trace for this error is OpenApp command -> Report::getChats(). getChats() is a massive function though that is quite difficult to understand, though I think I'm narrowing it down. This is where it looks like we should be adding the hasOutstandingChildRequest onyx key, but we never get there when we call OpenApp because the report is type chat and doesn't have a parentID, which we filter out on before getting to the block of code we need. This comment inside getChats helps explain a lot.
I tried looking at the code history to understand why we filter out early, but this seems to have been in place for awhile.
My next question is, how does OpenReport correctly identify that this report has hasOutstandingChildRequest set to true? If I can find that logic then maybe I can reuse it in getChats() to make sure all the reports we look at have that onyx key set to the correct value.

GetReport command -> postProcess -> addReportSummaryToResponse -> getStructuredOnyxReportAndLastMessageData -> structureReportForOnyx -> ...eventually we hit this line where we assign it for OpenReport.
Looks like it just checks the reportSummary, which we get by calling getChats (link).
So we should be able to get the data from within getChats since that is actually where OpenReport is getting the data from. But for some reason when we call getChats from openApp we don't get the hasOutstandingChildRequestData, but when we call it from openReport we do. Looks like it comes back to this conditional; that conditional is true in OpenApp but not in openReport, so we get down to this block which sets it.
The biggest problem I see with this is that getChat is a 800+ line function in one of the most core classes of the whole app, and there isn't a ton of documentation on this, so messing with it is very delicate. Will keep working on this tomorrow.

At the very very last minute of my day I figured out a small change to fix this, but I'm 80% it'll cause other issues. I need more context on the code. Regardless, putting up a draft PR: https://github.com/Expensify/Auth/pull/12952

Posted asking for help today here: https://expensify.slack.com/archives/C03TQ48KC/p1730226386005509
Lots of things learned today. We can solve this by sending all the IOUs to the frontend, but that breaks tests and is probably unnecessary. So currently trying to fix it without doing that, but its proving to be much more complicated. Hoping tomorrow I'll have the time to get a new fix out.

Figured out a different way of fixing the bug without sending a bunch of IOU reports to the frontend. Polishing up the PR and then will put it out for review.

This was deployed to production a few days ago


strcmp throws JS exception when comparing identical strings

The following code gives an error on the second strcmp:
#include <iostream>
#include <cstring>

using namespace std;

int main() {
  char *s1 = "Hello";
  char *s2 = "Bye!!";
  cout << strcmp(s1, s2) << endl;  // ok
  cout << strcmp(s1, s1) << endl;  // ERROR!!!

  return 0;
}

The error (on JavaScript console) is TypeError: Cannot read property 'v' of undefined.
Curiously, the first strcmp, which compares different strings, works as intended.
Tested on https://felixhao28.github.io/JSCPP/.

Fixed. Thanks for reporting!


sequences: Fixing concurrent "NEXT VALUE FOR"

This fixes a bug where concurrent transactions using "NEXT VALUE FOR" would make the sequence invisible to the other concurrent transaction.
The properties of a sequence (such as the INCREMENT BY, etc) are held in the same record as the next value. Since the next value of a sequence needs to be atomic (and separate from the transaction isolation) a ROLLBACK on a transaction that contains an ALTER SEQUENCE will not undo any changes.
Ideally, the properties of a SEQUENCE can be stored in a separate location on disk. However, for now it's a documented limitation.

I wonder if the documented limitation of non-functional rollback is planned to be lifted at some point in the future or if it is rather meant to be accepted as part of the "minimalism" of this SQL library.
Thanks!

Reading it back now, i think I made it sound more complicated to fix than it actually should be. There is an object type that represents the sequence which also contains the next value. The fix would be to separate the next value stored on the sequence definition into a new object type. Then the sequence definition could be tried to transaction.

I see, thanks for explanation.
So, is this limitation planned to be removed in the "near" future or rarther not?

No need to hurry - I just wanted to have the vision clarified :wink:.

@dumblob fixed: https://github.com/elliotchance/vsql/releases/tag/v0.27.7

Thanks a lot @elliotchance !
I am really pleased to see what vsql already achieved and how it evolves.


Lenovo P14s, T14 updates

Description of changes
Add hardware configs for the following Lenovo models:

ThinkPad P14s Gen 1 (AMD)
ThinkPad P14s Gen 3 (AMD)
ThinkPad P14s Gen 4 (AMD)
ThinkPad T14 Gen 4 (AMD)

The only model I don't own and haven't tested is the T14 Gen 4 (AMD), which should actually be identical to the P14s Gen 4 except it can't be configured with more than 32GB of RAM.
The P14s base config differs slightly from the T14 base config, so align them.
In addition, enable the amd_pstate driver on P14s/T14 Gen 2 and above, which run Zen 3+ and thus are supported by the driver. This is needed for proper power profiles support.
Things done

[x] Tested the changes in your own NixOS Configuration
[x] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

@mergify queue


Typo in iCloud_v3_beta5

'/config/custom_components/icloud3/event_log_cad/ipad.png'
must be
'/config/custom_components/icloud3/event_log_card/ipad.png'
2022-12-29 09:16:46.224 ERROR (SyncWorker_7) [icloud3] [Errno 2] No such file or directory: '/config/custom_components/icloud3/event_log_cad/ipad.png'
Traceback (most recent call last):
  File "/config/custom_components/icloud3/support/start_ic3.py", line 724, in _copy_image_files_to_www_directory
    shutil.copy(image_filename, www_evlog_directory)
  File "/usr/local/lib/python3.10/shutil.py", line 417, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/local/lib/python3.10/shutil.py", line 254, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/config/custom_components/icloud3/event_log_cad/ipad.png'

When change it manual and restart HA I have no errors at all anymore :)

it was suppose to be event-log-card, not event-log-cad...
Thanks, fixed in beta 6


fail to compile because of 'ar crs'

My environment are Windows10, Gnu and busybox.
--- stdout
cargo:rerun-if-env-changed=LIBZ_SYS_STATIC
cargo:rerun-if-changed=build.rs
TARGET = Some("x86_64-pc-windows-gnu")
OPT_LEVEL = Some("3")
HOST = Some("x86_64-pc-windows-gnu")
CC_x86_64-pc-windows-gnu = None
CC_x86_64_pc_windows_gnu = None
HOST_CC = None
CC = None
CFLAGS_x86_64-pc-windows-gnu = None
CFLAGS_x86_64_pc_windows_gnu = None
HOST_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
cargo:warning=BusyBox v1.32.0-FRP-3329-gcf0fa4d13 (2020-01-09 09:35:27 GMT) multi-call binary
cargo:warning=
cargo:warning=Usage: ar [-o] [-v] [-p] [-t] [-x] ARCHIVE FILES
cargo:warning=
cargo:warning=Extract or list FILES from an ar archive
cargo:warning=
cargo:warning=  -o      Preserve original dates
cargo:warning=  -p      Extract to stdout
cargo:warning=  -t      List
cargo:warning=  -x      Extract
cargo:warning=  -v      Verbose
cargo:warning=F:\scoop\apps\busybox\current\busybox.exe: unknown option -- s
exit code: 1
--- stderr
The fellow is output of ar:

ar crs
F:\scoop\apps\busybox\current\busybox.exe: unknown option -- s
BusyBox v1.32.0-FRP-3329-gcf0fa4d13 (2020-01-09 09:35:27 GMT) multi-call binary

Usage: ar [-o] [-v] [-p] [-t] [-x] ARCHIVE FILES
Extract or list FILES from an ar archive
    -o      Preserve original dates
    -p      Extract to stdout
    -t      List
    -x      Extract
    -v      Verbose

The 's' option is invalid in windows10.

Thanks for the report! It looks like this is a nonstandard implementation of ar? Is this perhaps a bug in your ar executable?

Hi! I faced the same issue while trying to build another rust application. Busybox's "ar" is not a full implementation (a comment in the source says "Mini ar implementation for busybox"). I have mingw-w64 installed, there's a full ar implementation there. I made the mingw-w64 bin directory available in the Windows path ahead of the busybox path and that solved the problem for me.

Yeah, busybox ar isn't designed to create archives, only extract them. It isn't a usable implementation for compilation.


CLOUD-52776 Shell enum value autocompletion

@doktoric plz review

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2109/


PluralSight downloads seem to have stopped working - "Unable to download webpage: HTTP Error 403: Forbidden"

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.07.02
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--username', u'PRIVATE', u'--password', u'PRIVATE', u'-o', u'~/PluralSight/%(playlist)s/%(chapter_number)s - %(chapter)s/%(playlist_index)s - %(title)s.%(ext)s', u'--sleep-interval', u'60', u'https://app.pluralsight.com/library/courses/test-driven-development-big-picture', u'--playlist-start', u'1', u'--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.07.02
[debug] Python version 2.7.16 (CPython) - Darwin-18.6.0-x86_64-i386-64bit
[debug] exe versions: rtmpdump 2.4
[debug] Proxy map: {}
[pluralsight:course] test-driven-development-big-picture: Downloading JSON metadata
[download] Downloading playlist: Test-driven Development: The Big Picture
[pluralsight:course] playlist Test-driven Development: The Big Picture: Collected 31 video ids (downloading 31 of them)
[download] Downloading video 1 of 31
[pluralsight] Downloading login page
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 627, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2227, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File<EMAIL_ADDRESS>line 435, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File<EMAIL_ADDRESS>line 473, in error
    return self._call_chain(*args)
  File<EMAIL_ADDRESS>line 407, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Description
PluralSight doesn't seem to be working for me and a few other people I checked with. It was working as of last week when I first tried this tool to successfully download one course. While trying to download another yesterday, I started running into the above 403 error. Updating to the latest version of this tool didn't change anything, and I don't think that one course a week is enough to trigger any blocks on my side.
Mostly I want someone else to try to confirm if it's account specific to us or not, though all the people I checked with are under different accounts and download at very different frequencies, but all of us are getting 403s now.

There seem to be a couple posts tangentially related, and some get closed when referring back to this issue: https://github.com/ytdl-org/youtube-dl/issues/20266. However, it's still odd that the same command worked and has been working for several people but only now suddenly is not for all of them.

You must provide account credentials.

@dstftw I did. Is there something in the output that makes it look like they aren't being provided? For additional context, the exact same command works to request Udemy videos. So something on PluralSight is breaking it.

Also note in the original description above, "It was working as of last week when I first tried this tool to successfully download one course." So the same command also worked on PluralSight the week before. Nothing's changed on my side, account-wise.

@marcthayer

I did. Is there something in the output that makes it look like they aren't being provided?

I think @dstftw means that in order to reproduce/fix the bug, the youtube-dl devs need a pluralsight account.

@dstftw : What is the recommended, confidential way of providing credentials to the devs?

@dstftw Do you still need a pluralsight account to test with? I can provide you with one

@dstftw I can spare ann account to fix this

Simple fix
1- Download this extension for chrome: https://chrome.google.com/webstore/detail/cookiestxt/njabckikapfpffapmjgojcnbfjonfjfg
this allows you to read the site cookies;
2- go to https://pluralsight.com and login to your account
3 - press on the extension icon and download the cookies file
4 - run the download command  no need to add username or password
youtube-dl --sleep-interval 10 "https://app.pluralsight.com/library/courses/javascript-best-practices" --cookies ~/Downloads/cookies.txt
happy downloading :D

This doesn't seem to work anymore:
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 627, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2237, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/Applications/MAMP/Library/lib/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/Applications/MAMP/Library/lib/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/Applications/MAMP/Library/lib/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/Applications/MAMP/Library/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/Applications/MAMP/Library/lib/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Even I'm getting the same error. The solution provided by @bellalMohamed did not work for me. Although, I am extracting Udemy courses instead of PluralSight. I have checked other bugs & all of them were referenced to this issue.
Can someone please assist with what might be causing this?

@dstftw


TypeScript MSBuild Offical NuGet not working

TypeScript Version:
I Try to use the TypeScript MSBuild NuGet for my My VS 2013/2015
https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild/
My csProj looks fine and when I try to start my project, the typeScript files get compiled to js, but the resulting js files are invalide, there I can find "class" or "static" identifier in my javaScript files and so the project is not running.
When I copy my local 1.8 TypeScript installtion from
C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.8
to the
\packages\Microsoft.TypeScript.MSBuild.1.8.11\tools\tsc\
then the resulting js files work.
A second Problem is, compile on save is not working with MSBuild Package, bevor I've installed the package this was working fine on VS 2013/2015 I am using a ASP.NET 4 Project with csproj settings for TypeScript --> this works for the compile on save: https://github.com/Microsoft/TypeScript/issues/7210
Expected behavior:

valid js files with current offical NuGet Package

Actual behavior:

current js files created from the NuGet Package are not valid.

You can get a class keyword in the output if you are compiling with --target es6.
Do you have a tsconfig.json in your project? can you share the project?

Sry I need to close the Issue - I've tried it several times this afternoon and it never works.
Now I tried to reproduce the problem and it allways works fine :-/ sorry.


When installing, it now fails

The patches need to also be in the theme repos at the moment. The install now fails -- @stevejpurves any idea how to get around that?

Ok, I think that to change this we:
(1) need to move the source of the themes over into this repo
(2) when building, bundle everything by changing the remix config:
remix.config:
  appDirectory: 'app',
  assetsBuildDirectory: 'public/build',
  serverBuildPath: 'build/index.js',
  serverMinify: true,
  publicPath: '/build/',

// Get rid of this line:
// server: process.env.NODE_ENV === 'development' ? undefined : './server.js',

// Bundle everything
serverDependenciesToBundle: [/.*/],

When build this should create a full api bundle and copy of the public repo.
Copy those assets and the standard remix electron shell in build and public folders
have the packagejson/lock look like:

{
  "name": "@myst-theme/book",
  "private": true,
  "sideEffects": false,
  "scripts": {
    "start": "cross-env NODE_ENV=production node ./server.js"
  },
  "dependencies": {
    "@remix-run/express": "^1.15.0",
    "@remix-run/node": "^1.15.0",
    "compression": "^1.7.4",
    "cross-env": "^7.0.3",
    "express": "^4.18.2",
    "isbot": "^3.6.8",
    "morgan": "^1.10.0"
  },
  "engines": {
    "node": ">=16"
  }
}

These should be copied into a build folder that are the git repos, I think it is fine to have these be in git for now rather than some other deployment
npm install in that build folder to make the lock files (should only take a second as there are barely any deps)
push that to the template repository, which has a template.yml, server.js, .gitignore, public and build folder.

The theme needs to be fixed up to allow for changes in development mode (here).


Have Note Preview window play nicely with Vim/VSpaceCode keybindings

Please select if your request is either something new or an enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup - Dendron's Lookup Command
[x] Views - Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema - Dendron Schemas
[ ] Pod - Data import from / export to Dendron
[ ] Publish - External Site Publish
[ ] Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe
I currently use the VSpaceCode plugin which uses the Vim plugin to provide vim-like keybindings. These work perfectly with Dendron, except for in the Note Preview window. I am able to switch focus to the Note Preview window as expected, but when I try to use the normal j/k movement controls to scroll up/down, they do not work (however, the arrow keys do work). Additionally, VSpaceCode uses the spacebar to initiate most of its commands, so typically, I would use <space> w h/j/k/l to change focus to a different window, but it seems that space is only used to scroll the Note Preview.
Describe the solution you'd like
Ideally, I'd like to have the access to all of the keybindings from VSpaceCode that I would expect everywhere else, or at least access to basic movement and spacebar. I think this would be considered an issue on the Dendron side of things (which is why I am submitting the issue here), since the VSpaceCode plugin controls seem to work everywhere else.

Thanks for the suggestion, we'll look into adding keyboard shortcuts for the preview!
This also might be solved by having the preview sync with your location in the editor, in which case you wouldn't need to scroll around in the preview anyway.


Update required ibm provider version to >=1.61.0, <2.0.0 to pull in fix for known issue

https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4978 was fixed in 1.61.0, so we should bump the required ibm provider version to >=1.61.0, <2.0.0 (and updates examples as needed too)

PR merged, closing


CUDA HAL needs to manage the active context.

Though we create a CUcontext we don't set it properly and have inconsistent usage.
We need to be sure we are not invalidating global state by changing the context out from under hosting applications and also need to be sure we are setting our context whenever we are making CUDA calls that require it.
We allocate the context here:
https://github.com/google/iree/blob/16486e2d7c32bdaadf73bb940500d4356a51ebbb/runtime/src/iree/hal/cuda/cuda_device.c#L145
but do not use cuCtxPopCurrent before returning to the caller. If the calling application is using their own context this will break things, as well as leaving the stack unbalanced.
On the primary entry points into the CUDA HAL we need to put a cuCtxPushCurrent/cuCtxPopCurrent, such as around iree_hal_cuda_device_queue_submit and the allocator functions. The CUDA documentation will need to be checked to see which calls actually use the context but to be safe we could do it around any call tree that can reach a CUDA driver API call.
Wrapping around submit above should handle most of our uses at a coarse level (graph/deferred command buffer issuing), but in the case of inline execution we'll need to use persistent thread state. We can add a check to perform the push in iree_hal_cuda_stream_command_buffer_begin and pop in iree_hal_cuda_stream_command_buffer_end if the command buffer mode has the IREE_HAL_COMMAND_BUFFER_MODE_ALLOW_INLINE_EXECUTION bit set. There may be exceptional cases here where that can break (early-exiting midway through inline execution) but behavior isn't well-defined in those cases anyway.

[ ] Pop context on creation to ensure a balanced stack
[ ] Push/pop around HAL entry points (submit, etc)
[ ] Push/pop around stream command buffer in inline execution mode
(+ probably others)

we are using this patch locally in SHARK https://github.com/iree-org/iree/commit/49c983cf21ea633b161e423a0c2c27c0a0816847

@ThomasRaoux Hey Thomas, any updates here?

Any update here? I hit similar issue when running iree-jax flow.
import jax
import iree.compiler
import iree.runtime
import numpy as np

config = iree.runtime.system_api.Config("cuda")

x = np.array(7, dtype=np.int32)
y = np.array(8, dtype=np.int32)
def my_func(a, b):
    return a+b

xla_comp = jax.xla_computation(my_func)(x, y)
hlo_proto = xla_comp.as_serialized_hlo_module_proto()
bin = iree.compiler.tools.xla.compile_str(hlo_proto, target_backends=("cuda",), input_type="xla")
vm_module = iree.runtime.VmModule.from_flatbuffer(bin)
module = iree.runtime.load_vm_module(vm_module, config)
print(np.asarray(module["main"](x, y)))

Sent a PR to fix the problem:
https://github.com/iree-org/iree/pull/9909
@powderluv can someone on Nod's side confirm that it solves your problem since I don't have a repo?
@FudanEMWLab could you also verify the fix on your side?

@ThomasRaoux , ran my above python program with your PR but hit the same error.

@ThomasRaoux , rebuilt iree with your PR and ran my above python program, but hit the same error.

Could you give a bit more detail on what the error is?
I’ll also try to reproduce on my side.

@ThomasRaoux , rebuilt iree with your PR and ran my above python program, but hit the same error.

Could you give a bit more detail on what the error is? I’ll also try to reproduce on my side.

(venv_local_iree_build) [jax_iree_experiment] > python notebook/test_cuda_as_iree_backend.py
[debug]: iree_hal_cuda_device_create()
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/cuda_device.c]: cuCtxSetCurrent(context pointer: 0x0x32d0250)
[debug]: iree_hal_cuda_device_destroy()
[debug]: iree_hal_cuda_device_create()
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/cuda_device.c]: cuCtxSetCurrent(context pointer: 0x0x32d0250)
[debug]:[/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/xla.py][204]: ['/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-compile', '-', '--iree-input-type=xla', '--iree-vm-bytecode-module-output-format=flatbuffer-binary', '--iree-hal-target-backends=cuda', '--iree-llvm-embedded-linker-path=/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-lld', '--mlir-print-debuginfo', '--mlir-print-op-on-diagnostic=false']
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/stream_command_buffer.c]: (context pointer: 0x0x32d0250) before calling cuLaunchKernel
Traceback (most recent call last):
  File "/jax_iree_experiment/notebook/test_cuda_as_ireejax_backend.py", line 19, in <module>
    print(np.asarray(module["main"](x, y)))
  File "/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/runtime/function.py", line 129, in __call__
    self._invoke(arg_list, ret_list)
  File "/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/runtime/function.py", line 153, in _invoke
    self._vm_context.invoke(self._vm_function, arg_list, ret_list)
RuntimeError: Error invoking function: iree/runtime/src/iree/hal/drivers/cuda/stream_command_buffer.c:378: INTERNAL; CUDA driver error 'CUDA_ERROR_INVALID_HANDLE' (400): invalid resource handle; cuLaunchKernel; while invoking native function hal.ex.submit_and_wait; while calling import;
[ 1]   native hal.ex.submit_and_wait:0 -
[ 0] bytecode xla_computation_my_func_0.main:458 [unknown]
[debug]: iree_hal_cuda_device_destroy()

Thanks for sharing, I wonder if the problem is really related to the context as it seems like we have the right context bound when doing the dispatch. Also I don’t see why another context would be created but I’m not an expert of jax.
I’ll have to try to reproduce to understand what is going on here.

@ThomasRaoux , rebuilt iree with your PR and ran my above python program, but hit the same error.

Could you give a bit more detail on what the error is? I’ll also try to reproduce on my side.

(venv_local_iree_build) [jax_iree_experiment] > python notebook/test_cuda_as_iree_backend.py
[debug]: iree_hal_cuda_device_create()
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/cuda_device.c]: cuCtxSetCurrent(context pointer: 0x0x32d0250)
[debug]: iree_hal_cuda_device_destroy()
[debug]: iree_hal_cuda_device_create()
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/cuda_device.c]: cuCtxSetCurrent(context pointer: 0x0x32d0250)
[debug]:[/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/xla.py][204]: ['/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-compile', '-', '--iree-input-type=xla', '--iree-vm-bytecode-module-output-format=flatbuffer-binary', '--iree-hal-target-backends=cuda', '--iree-llvm-embedded-linker-path=/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-lld', '--mlir-print-debuginfo', '--mlir-print-op-on-diagnostic=false']
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/stream_command_buffer.c]: (context pointer: 0x0x32d0250) before calling cuLaunchKernel
Traceback (most recent call last):
  File "/jax_iree_experiment/notebook/test_cuda_as_ireejax_backend.py", line 19, in <module>
    print(np.asarray(module["main"](x, y)))
  File "/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/runtime/function.py", line 129, in __call__
    self._invoke(arg_list, ret_list)
  File "/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/runtime/function.py", line 153, in _invoke
    self._vm_context.invoke(self._vm_function, arg_list, ret_list)
RuntimeError: Error invoking function: iree/runtime/src/iree/hal/drivers/cuda/stream_command_buffer.c:378: INTERNAL; CUDA driver error 'CUDA_ERROR_INVALID_HANDLE' (400): invalid resource handle; cuLaunchKernel; while invoking native function hal.ex.submit_and_wait; while calling import;
[ 1]   native hal.ex.submit_and_wait:0 -
[ 0] bytecode xla_computation_my_func_0.main:458 [unknown]
[debug]: iree_hal_cuda_device_destroy()

Thanks for sharing, I wonder if the problem is really related to the context as it seems like we have the right context bound when doing the dispatch. Also I don’t see why another context would be created but I’m not an expert of jax. I’ll have to try to reproduce to understand what is going on here.

It's weird. I just cleaned and rebuilt IREE and then the test just passed. I repeated the build flow by undo/redo your patch and surely your patch works for my above test. (not sure why my first try failed). Thanks a lot.

@ThomasRaoux , rebuilt iree with your PR and ran my above python program, but hit the same error.

Could you give a bit more detail on what the error is? I’ll also try to reproduce on my side.

(venv_local_iree_build) [jax_iree_experiment] > python notebook/test_cuda_as_iree_backend.py
[debug]: iree_hal_cuda_device_create()
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/cuda_device.c]: cuCtxSetCurrent(context pointer: 0x0x32d0250)
[debug]: iree_hal_cuda_device_destroy()
[debug]: iree_hal_cuda_device_create()
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/cuda_device.c]: cuCtxSetCurrent(context pointer: 0x0x32d0250)
[debug]:[/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/xla.py][204]: ['/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-compile', '-', '--iree-input-type=xla', '--iree-vm-bytecode-module-output-format=flatbuffer-binary', '--iree-hal-target-backends=cuda', '--iree-llvm-embedded-linker-path=/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-lld', '--mlir-print-debuginfo', '--mlir-print-op-on-diagnostic=false']
[debug]:[iree/runtime/src/iree/hal/drivers/cuda/stream_command_buffer.c]: (context pointer: 0x0x32d0250) before calling cuLaunchKernel
Traceback (most recent call last):
  File "/jax_iree_experiment/notebook/test_cuda_as_ireejax_backend.py", line 19, in <module>
    print(np.asarray(module["main"](x, y)))
  File "/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/runtime/function.py", line 129, in __call__
    self._invoke(arg_list, ret_list)
  File "/jax_iree_experiment/venv_local_iree_build/lib/python3.9/site-packages/iree/runtime/function.py", line 153, in _invoke
    self._vm_context.invoke(self._vm_function, arg_list, ret_list)
RuntimeError: Error invoking function: iree/runtime/src/iree/hal/drivers/cuda/stream_command_buffer.c:378: INTERNAL; CUDA driver error 'CUDA_ERROR_INVALID_HANDLE' (400): invalid resource handle; cuLaunchKernel; while invoking native function hal.ex.submit_and_wait; while calling import;
[ 1]   native hal.ex.submit_and_wait:0 -
[ 0] bytecode xla_computation_my_func_0.main:458 [unknown]
[debug]: iree_hal_cuda_device_destroy()

Thanks for sharing, I wonder if the problem is really related to the context as it seems like we have the right context bound when doing the dispatch. Also I don’t see why another context would be created but I’m not an expert of jax. I’ll have to try to reproduce to understand what is going on here.

It's weird. I just cleaned and rebuilt IREE and then the test just passed. I repeated the build flow by undo/redo your patch and surely your patch works for my above test. (not sure why my first try failed). Thanks a lot.

Great, thanks for double checking. I'm closing this then.

Can confirm from the nod perspective this resolved our issue too


Does @RemoteConfigProperty not parse JSON value?

Description
I expect @RemoteConfigProperty to parses JSON value into [String:[String]] but it doesn't
Reproducing the issue
No response
Firebase SDK Version
10
Xcode Version
14.2
Installation Method
Swift Package Manager
Firebase Product(s)
Remote Config
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Would you share the specific example of what is not working?
See usage examples in our tests at https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseRemoteConfigSwift/Tests/SwiftAPI/PropertyWrapperTests.swift

Would you share the specific example of what is not working?
See usage examples in our tests at https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseRemoteConfigSwift/Tests/SwiftAPI/PropertyWrapperTests.swift

Is there actual documentation on @RemoteConfigProperty? Because I can't see any. So I guess the question back to you is, how exactly does @RemoteConfigProperty work for a JSON server value? What type is passed back?

Hi @dpyy, unfortunately @RemoteConfigProperty is missing documentation (I'll add docs before closing this issue). In the meantime, to answer your question, the @RemoteConfigProperty property wrapper works on Decodable types, rather than an NSDictionary or NSArray that you're likely used to from the return type of jsonValue on RemoteConfigValue. I've added a couple examples below to get you started while I add documentation.
Top-Level Object
In this example the top-level entity in JSON is an object. This would have been returned as an NSDictionary when using the RemoteConfigValue.jsonValue approach.

Example JSON
{
  "recipe_name": "scrambled_eggs",
  "ingredients": [
    "eggs",
    "salt",
    "pepper",
    "butter"
  ],
  "cook_minutes": 5
}

Decodable
struct Recipe: Decodable {
  var recipeName: String
  var ingredients: [String]
  var cookMinutes: Int

  enum CodingKeys: String, CodingKey {
    case recipeName = "recipe_name"
    case ingredients
    case cookMinutes = "cook_minutes"
  }
}

Property-Wrapper
@RemoteConfigProperty(
  key: "recipe",
  fallback: Recipe(recipeName: "placeholder-recipe", ingredients: [], cookMinutes: 0)
) var recipe: Recipe

The fallback value is only used if Remote Config doesn't have a default value for the "recipe" key and it has not yet obtained the remotely configured value.
Top-Level Array
In this example the top-level entity in JSON is an array. This would have been returned as an NSArray when using the RemoteConfigValue.jsonValue approach.

Example JSON
[
  {
    "recipe_name": "scrambled_eggs",
    "ingredients": [
      "eggs",
      "salt",
      "pepper",
      "butter"
    ],
    "cook_minutes": 5
  },
  {
    "recipe_name": "french_toast",
    "ingredients": [
      "eggs",
      "milk",
      "cinnamon",
      "bread",
      "butter",
      "maple syrup"
    ],
    "cook_minutes": 15
  }
]

Property-Wrapper
@RemoteConfigProperty(key: "recipe_list", fallback: []) var recipeList: [Recipe]

In this case the fallback value is just an empty array. Note that the wrapped value recipeList must be annotated with the type [Recipe] because Swift arrays only conform to Decodable if the contained type is known to be Decodable. An alternative approach would be to provide a fallback array containing a Recipe, e.g.:
@RemoteConfigProperty(
  key: "recipe_list",
  fallback: [Recipe(recipeName: "placeholder-recipe", ingredients: [], cookMinutes: 0)]
) var recipeList

Additional clarification

I expect @RemoteConfigProperty to parses JSON value into [String:[String]] but it doesn't

I just wanted to clarify whether this was a typo. Do you have example JSON payload that you'd expect to be parsed into [String:[String]]? As far as I'm aware, ["foo":["bar", "baz"]] wouldn't be valid JSON syntax but I could definitely be mis-guessing the expected input.

Yeah it conforms to decodable
@RemoteConfigProperty(key: "Json", fallback: structure(name: "Niket")) var value
I do have my default value where name is Yash, but still the property returns me the struct with name Niket which is basically a fallback when it fails to retrieve.
Why, please anyone?


Split off Distros

Split off:

[ ] Humble

[x] Create branch
[x] Update rosdistro (https://github.com/ijnek/rosdistro/tree/ijnek-zbar-ros-branch-rename)

[ ] Rolling

[ ] Rename ros2 branch to rolling, to match core ROS packages
[ ] Update rosdistro

Hi @paulbovbel, would you be able to either change the ros2 branch name to rolling, or grant me maintain access to this repo so I can do this? Thanks.

Humble Dev job failure will be fixed by https://github.com/ros/rosdistro/pull/35695

Hi @paulbovbel, would you be able to either change the ros2 branch name to rolling, or grant me maintain access to this repo so I can do this? Thanks.

Hey @paulbovbel , friendly ping

Could someone help me with obtaining admin privilege @paulbovbel or @clalancette please? I've been maintainer for over 3 years and I can't make simple changes like renaming the default branch to rolling.

Since I'm not a maintainer on this repository, I'm not comfortable changing your permissions (though you are currently listed as a "Maintainer").
That said, if you push a rolling branch that matches the current ros2 here, I'm willing to make that the default.

Closing, as all PRs to split off distros have been created.


Support non-UUID telemetry client ID

@pnadolny13 recently commented https://github.com/meltano/internal-data/issues/64#issuecomment-1402751110:

I think the challenge at least in the short term is that we dont receive the unique Meltano Cloud project ID from any events. Until we're sending that via meltano core telemetry then we dont know how to map these project IDs to alpha users. So far we can tell by looking at the activity but we dont have an explicit way to link them.

This issue explains how we can set the telemetry client ID to track this:

https://github.com/meltano/infra/issues/148

This PR makes it possible for us to set the client ID to any UUID:

https://github.com/meltano/meltano/pull/7007

The problem is that we aren't using UUIDs for Meltano Cloud project IDs. We need it to at least support ULIDs, but it seems reasonable to let it be any string (with some max length specified in the project context schema).
We'll need to update the project context schema. Currently it has:
        "client_uuid": {
            "description": "A UUID that uniquely identifies the client",
            "type": "string",
            "pattern": "^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$",
            "minLength": 36,
            "maxLength": 36
        },

To avoid making the name misleading, we'll have to rename it to client_id. This means we'll have to bump the schema version from 1-1-0 to 2-0-0.

@aaronsteers @pnadolny13 An alternative to supporting non-UUID client IDs would be to convert the Meltano Cloud project IDs into UUIDs. They're both 128 bits, so the conversion in either direction should be easy.


How to mark selected options

Hi,
please is it possible to mark the selected options in some way similar to the blocked options?
I use the setOptions () method to add options.
I can then mark the disabled options with the setDisabledOptions () method, but I would also need to mark the selected options, for example with the method or with the properties in the options field.
well thank you
Tony

@abujalka you could use setValue() method.
https://sa-si-dev.github.io/virtual-select/#/methods?id=setvalue


Wrong error message for ModelPruning callback

Hello everyone,
As I understood from the API References for the ModelPruning callback, this class takes a parameter named parameters_to_prune as an argument. However, the error message I provided below uses a term called parameters_to_tune, which is not a valid argument to the ModelPruning callback. I assume parameters_to_prune was meant, because the other error message available in this file also refers to the term parameters_to_prune.
The wrong error message is defined in the file pruning.py:
https://github.com/Lightning-AI/lightning/blob/8d14554383632f4cdff337b3d8d1b226cabdd1d0/src/pytorch_lightning/callbacks/pruning.py#L470
If my understanding is correct, I will be glad to make a pull request to fix the wrong error message.

That looks like a typo. A PR for this would be very welcomed! Thanks


HTTP Status (500 Internal Error)

I connect MindConnect Lib doing onboarding process and it is onboarded.
But i´m getting error in Agent Configuration:
ERROR: HTTP Status 500 - Internal Server Error.
Console in Node-Red
<------
Error: Network error occured Network error occured Internal Server Error <!doctype html>HTTP Status 500 – Internal Server ErrorHTTP Status 500 – Internal Server Error
--->
In Agent Configuration:

Some help would be appreciated.
Kind regards!

@selko this is happening because mindsphere has a major outage in agent management at the moment. We have to wait and see when this will be fixed.
https://status.mindsphere.io/

Ok, it is working now. Thanks for your response. I didn´t know that i can check the status of different sevrvices.
Thank you and kind regards.


Doesn't handle large files well

When I tried to serve an 800 MB file, it lagged my 2 CPU 1 GB ram server so much that it froze and I had to force reboot it.

Fixed in latest update


add XCTest and coverage

The file .travis.yml is in case that you want to add travis-CI and coveralls

Thanks, I took a 2-second look at travis-CI integration hooks, realized I need a travis account and decided not to, for now. If this project becomes more active I might change my mind though.

No problem


ZPL View Korean

hello. I need to convert ZPL to image and this solution helped me a lot. However, it seems that the problem I am facing is not converting Korean to ZPL. I live in Korea and most of the labels are in Korean. Is Korean not supported in the library? Usually ^SEE:UHANGUL.DAT^FS
^CW1,E:KFONT3.FNT^CI26^FS
^CI28
^CFJ,50 add in front, you can see Korean, but it doesn't seem to work with this library.

This code refers to two files located on your physical printer:
UHANGUL.DAT - An ecoding table
KFONT3.FNT - A font file which replaces the default font 1
The first of these cannot be emulated with this library, unfortunately. The second, however can. You can define your own drawer options to replace the default font 1.
IPrinterStorage printerStorage = new PrinterStorage();
DrawerOptions drawerOptions = new DrawerOptions() {
    FontLoader = fontName => {
        if(fontName == "1") {
            return typeface = SKTypeface.FromFile(@"KFONT3.FNT");
        }
        return SKTypeface.Default;
    }
};
var drawer = new ZplElementDrawer(printerStorage, drawerOptions);

@primo-ppcg
Great finally we are able to inject some font loading logic.


Intel realsense GRPC server

First pass at a GRPC server for the intel realsense.

Creates two cameras, color and depth, one for each stream type
The pointcloud generator is the same for each camera
GetProperties also returns the intrinsics
Adds a dependency to PCL to make generating the point cloud a little easier

Did not do speed tests. Will probably need to optimize for frame rate.
I was able to get the server to stream the color and depth channel from the grpc server.
Here is a creepy stream of the office at night (I was at home, don't worry):

And an upside down point cloud:

Rewrote the GRPC server so it doesn't use the forever-looping thread anymore.

This approach definitely resolves the concurrency issue, but I would be a little concerned about performance. I assume the existing camera servers are written the way they are because getting the image from the underlying camera can be an expensive operation, so we want to always have an image ready when someone requests one. Did you do any performance testing for this approach yet?

My plan today is to test out speed- if it doesnt work well in terms of speed i'll move back to the background loop

@jeremyhyde-viam  FYI

I was getting annoyed by the constant line breaks in the C++ code, so changed the column width to be a bit longer. It changed all the other cpp files in the directory, but the only ones I've actually changed are
cameraserver.cpp
intelrealsenseGRPC.cpp
Also made the ticket for the raw RGBA mime type (+lazy is also affected by the bug)
https://viam.atlassian.net/browse/RSDK-683

Removed the GetPointCloud implementation as it was taking too long


Feedback from Lab

Great job! Our favourite part was the tooltips - it was also a small introduction to genders and survival rates, which would be an expansion.
Here are our comments of areas for improvement:

We initially started clicking on the deck levels before we saw the dropdown. James and I both quite liked seeing the deck slices, but it was unclear that it wasn't clickable. Some options may be to either make the deck levels clickable or move the dropdown higher up.
We were unsure what the empty cabins meant - adding a comment about that would be helpful!
For the bottom 2 graphs, if you wanted to divide the data differently, you could maybe facet survival rate of decks by class, or maybe connect the bottom right graph to the deck selection callback to highlight the deck we are currently looking at? I would call this a low priority "nice to have" update.
Lots of excess space - I immediately adjusted my browser, but James missed that note.

Thank you Sam,
Great feedback! We have made notes and will be implementing some of your suggestions, stay tuned


Assign Enums to Enums?

Im a bit confuse why the following doesn't work:
export enum Languages {
    English = 'en',
    Chinese = 'zh-cn'
}

export enum Defaults {
    Language = Languages.English,
}

const language: Languages = Defaults.Language

///(48,9): Type 'Defaults' is not assignable to type 'Languages'.

is there another way of archiving the same in typescript?

It's a little hard for me to imagine a lot of scenarios for this apart from the 'defaults' one you provided.
Typically we only track the original literal values within an enum. I guess we could imagine enum members keeping track of other enum member values, though it seems strange and of limited value in my opinion.
You could instead just declare a const for each default, since I'd imagine your default data might be heterogeneous down the line anyway, and enums currently only handle strings and numbers.

@DanielRosenwasser what is the proposal?

These get different brands; this is the intended behavior.


WIP: pylint upgrade

See original merge request on GitLab
In GitLab by [Gitlab user @frazerclews] on Jul 5, 2020, 03:15
Description
//: # Upgrade .pylintrc to pylint 2.5, while also enforcing new rules to make the codebase better
Changes proposed in this merge request:

Update .pylintrc
Enforce other issues like LF line endings
Enforce new style of logging

This merge request,  when approved, will close:

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 09:01
Commented on .pylintrc line 131
please add the , back there, it helps reduce the amount of diff when a line needs to be added.

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 09:01
Commented on .pylintrc line 324
I am not too confident about this one. Do all our dependencies use the newstyle already? Those can't be mixed at a project level.

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 09:01
Commented on .pylintrc line 402
This should stay disabled, black takes care of it already

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 09:02
The first commit has a huge number of changes, including weird line-returns. (Cutting words after a '-').
Is that how the vanilla generated pylintrc file look like now?

In GitLab by [Gitlab user @frazerclews] on Jul 5, 2020, 15:35
Yeah, I just did the usual pylint --generate-rcfile then change the variables so they match the current repo in the first commit. Personally think it's a good idea to do that since it fixes a few grammatical mistakes, and makes porting to newer pylintrc files easier down the line hopefully

In GitLab by [Gitlab user @frazerclews] on Jul 5, 2020, 15:35
Commented on .pylintrc line 402
That's what I thought, but wasn't too sure if you would want to enforce it in pylint too just in case for consistency, will remove it

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 15:36
Commented on .pylintrc line 402
Pylint is already quite slow, I think that if we have another tool checking it, it's fine to disable here :) thanks!

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 15:37
Agreed, I was just surprised at the number of changes. Let's keep it as close to the genuine as possible.

In GitLab by [Gitlab user @frazerclews] on Jul 5, 2020, 15:40
Commented on .pylintrc line 324
I don't think it causes an issue with dependencies, it's just a style of logging. There are plenty of things in the dependencies I am certain don't follow other rules we enforce and work just fine

In GitLab by [Gitlab user @BenjaminSchubert] on Jul 5, 2020, 15:45
Commented on .pylintrc line 324
In order for logging to work with new style logging, it needs to be configured at the logger level. So if we configure the root logger to use "new style", we'd end up having all the other logger not using new style fail when logging they lines.
We should at least verify that all the logging is correct and doesn't show stack traces, as it would not be an error, logging catches all errors that happen inside it to not crash your app.

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 11:15
Commented on .pylintrc line 131
changed this line in version 2 of the diff

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 11:15
Commented on .pylintrc line 402
changed this line in version 2 of the diff

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 11:15
added 2 commits
162fdebe - update current .pylintrc2dba762b - enfore pylint rules, implicit-str-concat, logging-too-many-args
Compare with previous version

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 11:16
Commented on .pylintrc line 131
Not sure how I feel about that since it goes against the style of the rest .pylintrc, but added the comma back

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 13:35
added 13 commits
2dba762b...e79f4a01 - 10 commits from branch master7a5eca25 - update current .pylintrceaa90524 - enfore pylint rules, implicit-str-concat, logging-too-many-argsbe1da43f - WIP test
Compare with previous version

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 13:59
added 1 commit
a983d159 - WIP test
Compare with previous version

In GitLab by [Gitlab user @frazerclews] on Jul 6, 2020, 15:12
added 1 commit
c0c11446 - WIP test
Compare with previous version

In GitLab by [Gitlab user @cs-shadow] on Jul 14, 2020, 23:19
Thanks for starting this. As a coding style thing, I think it may make sense to separate the pylint upgrade from other changes.
In general, I see value in keeping all the "upgrade" MRs as targeted as possible. That makes reviewing them much simpler, and other changes in the coding style can be debated separately. Merging the upgrade with other changes muddies the water a little bit regarding the scope of the review.

In GitLab by [Gitlab user @BenjaminSchubert] on Aug 4, 2020, 07:41
mentioned in merge request !2011

pylint has been upgraded as part of #1934.


New feature possibility

Thanks for writing this tool.
As I was using the library, I found it would be useful to add a new format specifier %vindent.
This lets me indent my messages based on the verbosity level.
This might be a nice addition.
Thanks,
Bill

Thanks for the suggestion Bill,
what does it resolve to? an example please?
Please note you can also add custom format specifiers if they're specific to project
please see https://github.com/muflihun/easyloggingpp#custom-format-specifiers

Majid,
I'm not sure if custom-format-specifiers works for this case (though I haven't looked into it deeply), because I need the format specifier to know the logMessage->verboseLevel() for what I am interested in.
For the VLOG() invocations:
VLOG(1) << "This is an example at verbosity level 1 (log is prepended with 2 == 21 spaces)";
VLOG(2) << "This is an example at verbosity level 2 (log is prepended with 4 == 22 spaces)";
VLOG(2) << "This is an example at verbosity level 2 (log is prepended with 4 == 22 spaces)";
VLOG(8) << "This is an example at verbosity level 8 (log is prepended with 16 == 28 spaces)";
VLOG(8) << "This is an example at verbosity level 8 (log is prepended with 16 == 2*8 spaces)";
This would be the output:
test -V-:   This is an example at verbosity level 1 (log is prepended with 2 == 21 spaces)
test -V-:     This is an example at verbosity level 2 (log is prepended with 4 == 22 spaces)
test -V-:     This is an example at verbosity level 2 (log is prepended with 4 == 22 spaces)
test -V-:                 This is an example at verbosity level 8 (log is prepended with 16 == 28 spaces)
test -V-:                 This is an example at verbosity level 8 (log is prepended with 16 == 2*8 spaces)
I find this output less of a "wall of text" and gives context to my output.
I basically just created a %vindent in the .h file and added support in two places in the .cc file.
Anyway, I thought it was useful.  But if there's a way to implement it using the custom format specifiers, that would probably be the better way to go.  I just don't know if those would have access to the internal verbosity level.
Thanks!
Bill


Iterable Points

Is it possible for Points to be made iterable so that they can be interchangeably used with tuple or list point coordinates. This would be helpful so that I can use Shapely points in the same manner as sympy.geometry points.

I think the coords property will do what you need. Don't have a computer to hand to demonstrate properly, but:
for point in linestring.coords:
   x, y = point


URL Hash parameter to set default view

I'd like to link to speedscope.app (with some profile data loaded via #profileURL=...) and set the view to "Left Heavy", rather than the default "Time Order". Is there any way to do this? Would you accept a PR?

I'm also interested in this! Though in my case I'd want to set the default to Sandwich.
(My use case is an aggregated, synthetic profile consisting of samples taken from many requests, so time order is not meaningful.)

Hi @danvk! There's no way to do this at the moment. I'd accept a PR to do this, though as a fair warning I'm probably not going to be actively working on/deploying/publishing speedscope for a couple months

@jlfwong gentle nudge - no worries if you're not back to working on Speedscope yet, just making sure this didn't get lost.

Yep! Haven't put time back into this yet. Whenever I do a next push, this and other open pull requests will get some attention.


Fix editing messages with urls

Before:

After:

The best way is to use common code with LinkParser, but it is little bit hard in current design. So merge for now.

I guess the right thing to do (rather than sharing code with existing parsers) is to save the user's input from the textarea when ASS sends it and to use the saved text, because in this way we don't need to care how the Slack server converts sent texts.


terra install failure(s) because of @types/eslint v8.4.4

Right now terra-core will fail to install because @types/eslint v8.4.4 was not correctly published. I'll update this issue once that problem goes away or if we figure out a workaround faster than that.

A couple workarounds have been posted to that linked issue.

Closing this issue as it was fixed after @types/eslint @8.4.4 was re-released.


fix(learn): Added test for edge case

Checklist:

[*] I have read freeCodeCamp's contribution guidelines.
[*] My pull request has a descriptive title (not a vague title like Update index.md)
[*] My pull request targets the master branch of freeCodeCamp.
[*] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #39320

Test fixes the edge case scenario that this code is run:
function confirmEnding(str, target) {

  for (let i = target.length, j = 0; i > 0; i--, j++) {
    if (str[str.length-i] == target[j]) {
      return true;
    } else {
      return false;
    }
  }
}

confirmEnding("Open sesame", "sage");

In this case, the test would pass but would not follow the criteria of the challenge which is to confirm that the ending is correct, letter for letter.

Ideally, one of the other existing tests would be replaced with this one, instead of adding another test. There are far too many tests in this challenge, in my opinion.
I suggest the test below looking for the case of "pen" be replaced, unless someone can think of a reason why not.

You are right. I've done so. I believe the test below it looking for the case of "mountain" explains the idea just the same, if not better.

Congrats @dyneskye on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


keepalive webview can not auto trigger onLoadStart event

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.x

Android version
34

iOS version
12

Xcode version
5.x

Device information:
Description
Expected behavior:
into keepalive webview can auto trigger some event
Current behavior:
not
Steps to reproduce

for example, l have two keepalive webview page , A and B. first into A , auto trigger onWebViewCreated, onLoadStart , onLoadStop, xxx .
and now l Navigator.push  link to B, something happen like top, and now l link to A, only auto trigger onWebViewCreated, the other event trigger after l touch screen.
because my web page will auto trigger some  register JavascriptHandler, now that is wrong😢

now l want know when l use keepalive, the webview lifecycle is what？？ l want to register some js hanlder

@YYL1999 : keepAlive is meant to serve the webview from a non-disposed state, meaning it will not fetch the URL/data on every consecutive page visit (if the webview is still alive) and hence the callbacks for onLoadStart & onLoadStop won't be triggered.
If you want to register some JavascriptHandler, you can register it on onWebViewCreated callback. It gives the controller in the parameter.


[Bug] Redirect back to action

User is sent to homepage immediately after signing in, rather than the Connect Account page.
As shown in video, when the wallet is signed in already, it opens on the correct page.
In resolving this bug, a test must be written that ensures, when signing in, the user is redirected to the correct page
https://github.com/leather-wallet/extension/assets/1618764/f25e6caf-b9b7-4216-aabd-3da149f7928d

Dupe: https://github.com/leather-wallet/extension/issues/5066