Clearing the release select doesn't seem to clear the selection and is confusing

In the "Create Image modal" in the first step where the "Release" can be selected there is one option already pre-selected. There is a "clear button" next to it which when clicked doesn't seem to actually clear the selection as it's still shown but prevents clicking on "Next" and also the "Registration" step is hidden.

And after clicking the clear button it looks like this:

So the Release still seems to be selected but I am unable to continue which seems confusing. Maybe it would make sense to hide the "clear button"? Or at least somehow show that nothing is selected there once cleared.

Nice bug find on the validation. I think you're right about just removing it, and looking at the Patternfly examples there is good precedent for doing so.


Editor crash moving files

Godot 3.1 stable
Linux Manjaro
If you move scene file and associated script at the same time in another directory by FileSystem Godot crash
Create a project with a scene and attach a script to it. Create a folder in the project and drag in the scene and the script together.

Duplicate of #29266.


Updated iOS Quickstart to use getCurrentAccount API for silent token acquisition

@oldalton : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@oldalton : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mmacy, you can only sign off in the main PR conversation, not in review comments.

#sign-off


Add node 8 to CI

Fixes #729

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   94.81%   94.81%
=======================================
  Files          33       33
  Lines        1254     1254
=======================================
  Hits         1189     1189
  Misses         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15558cf...6b59e53. Read the comment docs.


Add feature for waiting longer than current maximum wait time.

Adds a macro to perform a QUA wait command for longer than the current maximum wait time, 2^31-1.
Also tentatively adds a namespace called macros. Open to a better convention than this.

Also, add it to the main readme page

@deanpoulos do you still want to merge this one?

All good, we just need to update the main readme and make one for the macros explaining the function and showing basic usage

I added documentation to the READMEs, but not the changelog yet. If you're happy with the READMEs, lets do the changelog together and merge.


I want to use this checkpoint in ios as mlmodel,

Hello, i converted the checkpoint model to .pb file and then want to convert it to .mlmodel file, at present  i have .pb file, and while conversion to .mlmodel it has an error
ValueError: graph_def is invalid at node u'Genc/Conv/BatchNorm/AssignMovingAvg': Input tensor 'Genc/Conv/BatchNorm/moving_mean:0' Cannot convert a tensor of type float32 to an input of type float32_ref.
And the code for it is:
import tfcoreml
Supply a dictionary of input tensors' name and shape (with batch axis)
input_tensor_shapes = {"input:0": [1, 224, 224, 3]} # batch size is 1
TF graph definition
tf_model_path = './frozen_graph.pb'
Output CoreML model path
coreml_model_file = './frozen_graph_ios.mlmodel'
The TF model's ouput tensor name
output_tensor_names = ['final_result:0']
Call the converter. This may take a while
coreml_model = tfcoreml.convert (
tf_model_path=tf_model_path,
mlmodel_path=coreml_model_file,
input_name_shape_dict=input_tensor_shapes,
output_feature_names=output_tensor_names,
image_input_names = ['input:0'],
red_bias = -1,
green_bias = -1,
blue_bias = -1,
image_scale = 2.0/255.0)
please tell me how i can convert it to .mlmodel

@xyzdcgan I am sorry I have no experience on mlmodel.


Ignore special chars

Fixes the issue with chat symbols from the old renderer: ␐ and ␆

prevent sending messages from the current renderer
ignores incoming messages with these symbols

Should be investigate further why it comes by the versioning system of protobuff packets
More info: https://github.com/decentraland/unity-explorer/issues/897

@NickKhalow I think I can still see the symbols both in unity and in the build:


chore: add tests on paginated relationships

Following on ash-project/ash#1234, this PR adds tests to verify that relationships can be queried on the results of GraphQL queries and mutations.
Querying paginated relationships on the result of deletions doesn't correctly work yet.
Indeed, Ash currently queries relationships using a lateral join but after the resource deletion has happened, so it looks like nothing is related.
Contributor checklist

[ ] Bug fixes include regression tests
[ ] Features include unit/acceptance tests

The "looks like nothing is related" bit is pretty complex. We can try to "simulate" this in ash which is that when relationships are loaded on a query for deletion we could just run the query first, save the relationship data, and then delete without the load. That way we could give a best effort of what the relationships look like. If you think about what its asking its actually kind of ambiguous anyway though, like are you asking for "what it looks like afterwards"? If so, the destroy actions should probably not return anything at all TBH. Anyway, that can be its own conversation :)

@davidebriani are the tests meant to be failing? Is this PR demonstrating a bug?

Or does it just need latest fixes from ash?

@zachdaniel the tests should work with the latest version of Ash.
I assume you'd want to tag an Ash release first, update deps here, and finally I'll rebase the PR

I guess either way, merging it should be fine. The subprojects test in ash will tell us.

🚀 Thank you for your contribution! 🚀


Support for sFTP

Not sure if this is on wishlist yet but having sFTP support would be awesome. I currently run a lftp script to pull down files then rclone to push files to Dropbox. Would be ideal to use rclone for both syncs. Maybe this library would be a good starting point: https://github.com/pkg/sftp.

Thanks for the suggestion.
That library looks very good and has all the primitives rclone would need I think.

+1

+1

Here is a beta of the SFTP support: http://pub.rclone.org/v1.35-60-g74801de-sftpβ/
Any testing much appreciated!

Here is a slightly better beta which won't flake out after 1024 files!
http://pub.rclone.org/v1.35-60-gfdb7dfe-sftpβ/

I have merged this to master now - see here for a beta:
http://beta.rclone.org/v1.35-74-g48cdedc/
Any feedback much appreciated

Any feedback much appreciated

Used directions at https://github.com/ncw/rclone/blob/48cdedc97b238a18bdc33b6930e3a6af0ffd8e9d/docs/content/sftp.md. Using a password worked great!
However, when working with the same server, I couldn't get ssh-agent to work:
rclone-v1.35-158-g4652db3β-osx-amd64/rclone lsd seit:
2017/03/06 14:33:52 Failed to create file system for "seit:": couldn't connect ssh: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

And yet when I do an ssh remote_server_foo.bar.com I can log in perfectly with the key, i.e. no password request.
Here's the config:
[seit]
type = sftp
host = remote_server_foo.bar.com
user = kenz
port =
pass =
--------------------
Edit remote
Value "host" = "remote_server_foo.bar.com"
Edit? (y/n)>
y) Yes
n) No

After it didn't work, I edited the config to add a password and it worked again. So I'm fairly sure I configured everything else properly.

@kubark42 Hmm, I wonder if that is an OS X problem.  Can you make a new issue with the above in please?
Thanks


[test] set up sanity test

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

could refer to https://github.com/kubernetes-sigs/azuredisk-csi-driver/tree/master/test/sanity
Describe alternatives you've considered

Additional context

Working on it.

/assign @tall49er

BTW, what's your slack id, and you could join slack@kubernetes, and then we could talk in that workspace.
@tall49er

My slack id is Rui Tang.

Where can I find azure.json?

@tall49er
Hi, thank for your participation. You can get azure.json by following the steps below:

Create an azure account and apply for a trial.
Create a kubernetes cluster and azure.json path is /etc/kubernetes/azure.json.

actually sanity test is already set up, need to fix the 6 failures: https://github.com/csi-driver/blobfuse-csi-driver/issues/28


use helmet to update page title dynamically

@danielcolinjames one thing i'm noticing with this is that it seems like the history.push on nav tabs clears out the page title. I was only setting title at the infobox level, hoping that that would just prevail for all the subtabs of that infobox but it looks like we may need to specify a title for each tab as well


Store old revisions

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11241 (85cc547) into 3.1 (ad79c9e) will decrease coverage by 4.99%.
The diff coverage is 51.35%.

:exclamation: Current head 85cc547 differs from pull request most recent head 729ce83. Consider uploading reports for the commit 729ce83 to get more accurate results

@@             Coverage Diff              @@
##                3.1   #11241      +/-   ##
============================================
- Coverage     69.39%   64.39%   -5.00%
+ Complexity      119       14     -105
============================================
  Files          1503     1422      -81
  Lines         79579    59331   -20248
  Branches      14039     8720    -5319
============================================
- Hits          55220    38207   -17013
+ Misses        19580    17061    -2519
+ Partials       4779     4063     -716

Impacted Files
Coverage Δ

...apache/dubbo/registry/client/ServiceDiscovery.java
33.33% <0.00%> (-6.67%)
:arrow_down:

...bo/registry/multiple/MultipleServiceDiscovery.java
0.00% <0.00%> (ø)

...try/client/metadata/MetadataServiceDelegation.java
35.41% <50.00%> (-4.17%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
64.32% <54.54%> (-21.83%)
:arrow_down:

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

... and 514 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


DOCS-2313: Fix docstrings in arm and encoder where link not parsing

Some final fixups from this ticket

Fix encoder PositionType.ValueType by changing to PositionType (like in other parts of docstring) + fix code sample (value type seems to be off)
Fix arm KinematicsFileFormat.ValueType by giving the two value types in docstring (link to KinematicsFileFormat does not explain much)

@sguequierre lgtm if you've confirmed this fixes the issue and renders correctly

@sguequierre lgtm if you've confirmed this fixes the issue and renders correctly

yup, renders correctly changed to PositionType as Naveed suggested!


update TestFlight and improve/validate TestFlight & Google Analytics checkpoints

We should upgrade TestFlight SDK to the latest version so the TestFlight dashboard stops complaining. Additionally ideally the various Checkpoint's should be reviewed as some are passed multiple times when they shouldn't be and others are passed before the TestFlight session is started and thus not logged in the metrics (may also be partially addressed in the TestFlight SDK update).

@bbodenmiller - is this issue still relevant?

I believe some of the ga logging events may still be reporting inaccurately so it is worth a detailed look.


build: Require boto3/botocore 1.34.63; stop pinning urllib3

Since https://github.com/boto/botocore/commit/f9470df1af9f2a59d3c30f691e593d0e4abbe9e2, botocore supports all urllib3 versions except 2.2.0 on Python 3.10 and later. It should be safe to stop pinning urllib3 separately here.

This is an alternative to https://github.com/snakemake/snakemake-storage-plugin-s3/pull/23, which keeps the boto minimum versions unchanged and continues to take responsibility for avoiding urllib3 2.2.0.

thanks!


Upgrading remark-wiki-link lib in the project to adjust links with ac…

Closes: #565
Changes

Updated package.json to use the latest version of the remark-wiki-link package.

CC: @olayway @demenech @anuveyatsu

Let's first make sure the remark-wiki-link package has been fixed and released.


replace testsuite to testify part 1(fix #20)

Pull Request for issue
#20
Description

replace testsuite to testify
install testify by dep

I went to take a shower and fixed these problems.

Tnx @Chyroc


[NT-2159] Mock Apollo Client

📲 What
An attempt to improve our coverage of the Apollo Query/Mutation --> Query.Data/Mutation.Data --> SignalProducer flow.
🤔 Why
Helps us test the adapters that convert our Apollo Data objects to their respective pre-existing types (ex. CommentsEnvelope) via the SignalProducers.
Supports more testing of the ApolloClient fetch and mutation calls both for existing features and in the future.
🛠 How
MockGraphQLClient
As per my discussion with @singhhari, we decided to look at the existing PerimeterXClientType and add a protocol (ApolloClientType) to adapt the existing ApolloClient+RAC type so we can test the fetch and perform functions.
The exact signature of the fetch and perform functions are not conducive to passing in a pre-created result that can be returned through a call to these functions. Mostly because GraphQLMutation.Data and GraphQLQuery.Data are associated types, which are not applicable to stored properties. (ie. I can't write let storedResult: <GraphQLQuery.Data>? = nil because it returns an error: "Associated type 'Data' can only be used with a concrete type or generic parameter base"). That basically means we can't generalize or use a generic 'Data' type to store a Decodable object (ie. CommentsEnvelope is Decodable).
I think Apollo uses these Protocols and their Associated types to create the base models (ie. UnwatchProjectMutation which is a class that contains its own Data type). That's just how Apollo creates its models, you can't really re-use their approach to create a base class that represents all mutations for example.
Long story short, the way this is done is to use Data: Decodable generic because the Envelope's all conform to Decodable (except ErroredBackingsEnvelope). So we can return that type as a SignalProducer out of the perform/fetch function.
Also dataFromProducer and errorFromProducer are used with the MutationTemplate.valid.data and MutationTemplate.valid.error in conjunction with the Mutation.Data's producer(from: function, so those can be tested too.
✅ Acceptance criteria

[x] MockGraphQLClient used in testing of Service functions that used the GraphQL.shared.client in MockService.
[x] All Mutation.Data signal producers tested with a combination of the MutationTemplate file and the MockGraphQLClient

[x] CreateBackingEnvelope+CreateBackingMutation.Data
[x] DeletePaymentSourceEnvelope+DeletePaymentSourceMutation.Data
[x] WatchProjectResponseEnvelope+UnwatchProjectMutation.Data
[x] WatchProjectResponseEnvelope+WatchProjectMutation.Data
[x] SignInWithAppleEnvelope+SignInWithAppleMutation.Data
[x] UpdateBackingEnvelope+UpdateBackingMutation.Data

⏰ TODO
Add test coverage for these functions

[ ] CommentsEnvelope.envelopeProducer(from: )
[ ] UserEnvelope<GraphUser>.envelopeProducer(from:)
[ ] ErroredBackingsEnvelope.producer(from:)
[ ] ProjectAndBackingEnvelope.envelopeProducer(from:)
[ ] Project.projectProducer(from:)

❤ Out Of Scope
Test coverage for Fragment files (too many, out of time, additional complexity)

[ ] Backing+BackingFragment
[ ] Checkout+CheckoutFragment
[ ] Comment+CommentFragment
[ ] UserCreditCards+UserFragment
[ ] Location+LocationFragment
[ ] Project+ProjectFragment
[ ] Project.Category+CategoryFragment
[ ] Project.Country+CountryFragment
[ ] Reward+RewardFragment
[ ] ShippingRule+ShippingRuleFragment
[ ] User+UserFragment

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


[Android] Back port commits for dropped IndexedDB  to Crosswalk 11

Because of multiple profile support, from crosswalk 9 IndexedDB
will be put under profile's subfolder.
Issue is reported from https://github.com/MobileChromeApps/mobile-chrome-apps/issues/554.
BUG=XWALK-4047
(cherry picked from commit 36231eaa85f54622210f9999819cb68994d64432)

Crosswalk 11 is unmaintained.


Assinment Links Input Validation

Changes Made:

Validation for the link entered in the URL field: Must be a valid non-empty URL
Added character limits for Link Display Text and Description
The Add Link/Save Changes button stays disabled as long as any of the above conditions are violated.

Overall, looks good to me. Have added some not so important comments. One important thing, however, is its backend counterpart. I should be good to go as soon as you could point me to it (or a follow-up work item to take care of it).

I was under the impression that the client-side validation would be sufficient, but based on your previous comment as well, I see why it might be more important. I have pushed a change now, wherein we make these checks on the incoming dto as well.


fixed test case: check HTTP version 1.0/1.1 both

CONNECT ESTABLISHED response version has been changed to HTTP/1.1 in https://github.com/chobits/ngx_http_proxy_connect_module/pull/53.

trivial fix, merged by myself

Date: Tue Jul 31 15:38:04 CST 2018
pwd: /home/xiaochen/work/github/nginx-1.15.2
cases: /home/xiaochen/work/github/ngx_http_proxy_connect_module/t
case result:

$ MOD_DYCONF_PATH=/home/xiaochen/work/github/nginx-1.15.2 TEST_NGINX_BINARY=/home/xiaochen/work/github/nginx-1.15.2/objs/nginx prove -v -I /home/xiaochen/work/github/nginx-tests/lib /home/xiaochen/work/github/ngx_http_proxy_connect_module/t
/home/xiaochen/work/github/ngx_http_proxy_connect_module/t/http_proxy_connect.t ..
DNS server: try to bind server port: 18085
DNS server: daemon pid: 15090
DNS server: working
ok 1 - 200 Connection Established
ok 2 - 200 Connection Established server name
ok 3 - 200 Connection Established server name
ok 4 - 200 Connection Established server name
ok 5 - 200 Connection Established not allowed port
ok 6 - Get method: proxy_pass
ok 7 - Get method: return 200
ok 8 - set remote address
ok 9 - set local address and remote address
ok 10 - $connect_host, $connect_port, $connect_addr
ok 11 - dns resolver fail
ok 12 - skip proxy connect module without rewrite phase enabled
ok 13 - skip proxy connect module without rewrite phase enabled: if/return
DNS server: stop
1..13
ok 14 - no alerts
ok 15 - no sanitizer errors
All 13 subtests passed

Test Summary Report
-------------------
/home/xiaochen/work/github/ngx_http_proxy_connect_module/t/http_proxy_connect.t (Wstat: 0 Tests: 15 Failed: 2)
  Failed tests:  14-15
  Parse errors: Plan (1..13) must be at the beginning or end of the TAP output
                Bad plan.  You planned 13 tests but ran 15.
Files=1, Tests=15,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.15 cusr  0.06 csys =  0.24 CPU)
Result: FAIL

Report-generated-by: http://wxc.oss.aliyuncs.com/dtest.sh


Handle ties on Provincial Records page

When there is a tie for a provincial record, currently only one of them is shown. We should show all of them.

Need to:

Update seed data (server/seed-data/cuberecords.json) to have a tie.
Update etl/record_updater.py to support ties. May need to modify WCA MySQL to introduce a tie in national records because there isn't one at the moment.
Update server/api/records/record.model to use arrays for the names, dates and person IDs for records.
Update server/api/rankings/ranking.controller to resolve multiple rows for a single record.
Fix whatever unit tests break in the server code.
Update Record interface in client to use arrays for the names, dates and person IDs for records.
Support multiple names in HTML for NationalRecordsList and ProvincialRecords components.
How to handle recent records label?
Fix any client unit tests that break.


Lightwave Integration stopped working after 0.96 upgrade

v0.96.x

Worked in 0.95.x
Operating environment (Hass.io/Docker/Windows/etc.):

Using Hass.io within VM on Hyper-V
Component/platform:

home-assistant/lightwave
Description of problem:
Lightwave (Connect) was working fine in 0.95.x but since upgrading to 0.96.x are now seeing "LW broker timeout!" every time trying to turn a light on/off. No changes to the configuration.yaml which looks like this:
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
lightwave:
  host: <IP_ADDRESS>
  lights:
    R1D1:
      name: Hallway
  switches:
    R2D1:
      name: Dummy

Lightwave hub has a static IP address of <IP_ADDRESS>
Traceback (if applicable):

Additional information:

Hi, you can close this issue - as I had to reinstall the hass.io VM when 0.96 came out I forgot that I needed to re-register with the hub using echo -ne "100,!F*p." | nc -u -w1 <IP_ADDRESS> 9760 from the terminal within Home Assistant. My apologies, once I re-registered everything works again.


Math support (a.k.a. tex_math_dollars)

We'd need:

Support for Pandoc's tex_math_dollars extension in Lunamark (= https://github.com/jgm/lunamark/issues/50) to extract the formula and invoke the writer.
The path then for SILE has to be clarified

Either we assume its TeX-like math is kind of OK, though with restrictions (at this time of writing) on the supported syntax subset...
Or we go to the mathml route (which at the time of writing again, seems a bit better in SILE), but that would mean converting the (La)TeX formula to MathML. We are not going, certainly, to reinvent the wheel here[^1], so likely use something existing, e.g. TEMML, although it implies a dependency on NodeJS and forking an external process... And MathML in SILE also has some restrictions (at the time of writing again, such as https://github.com/sile-typesetter/sile/issues/1604, so I am unsure it's worth the effort going that route.
However, SILE math is not even an inputter, though I've a few doubts regarding the actual implementation, esp. with AST dumping and round-tripping... (#15)

[^1]: The Lua ecosystem is so non-existent that the very choice of Lua for SILE could be questioned. And IMHO, Rust is not even better -- said with a grain of salt, to those in the SILE community who might argue otherwise, heh! :smile_cat:

Blocker: As of 0.14.4, packages markdown and pandocast can no longer be used together in a single document such as the demo/showcase document if they both load the math package... It will hit https://github.com/sile-typesetter/sile/issues/1607, so this will have to wait for resolution...
Other than that, going the "TeX-like math" route seems satisfying enough:

TeX-like math between `$` ("inline mode") or `$$` ("display mode") decently works
Note that $20,000 and $30,000 don't parse as math, while $e^{i\pi}=-1$ does.
There is an important constraint, though: you have to restrict yourself to the syntax subset supported
by SILE. This being said, some nice fomulas may be achieved:

::: {custom-style=center}
$$\pi=\sum_{k=0}^\infty\frac{1}{16^k}(\frac{4}{8k+1}-\frac{2}{8k+4}-\frac{1}{8k+5}-\frac{1}{8k+6})$$
:::

At the time of writing, obtained via the Pandoc AST route -- My quick'n dirty attempt on the Lunamark-native route currently breaks severely on the "note that..." test case. But I spent more time today debugging the blocker issue, and another weird one (worked-around) than seriously trying to implement the pattern right :(

#23 has the experimental code for both inline and display math, supported both with the markdown and pandocast packages.
Looks nice:


Content available flag

Purpose
We need to notify able that we have content to be read and do not want to use their standard templates
Changes
Adding content available
Docs: https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#Message
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

You should have "content_available": true and "mutable_content": true in the body of the request
https://firebase.google.com/docs/cloud-messaging/http-server-ref
https://stackoverflow.com/a/42533430


FIX: coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@e9ab44b). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage        ?   99.33%
=======================================
  Files           ?       20
  Lines           ?      299
  Branches        ?        0
=======================================
  Hits            ?      297
  Misses          ?        2
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HHH-7355 - Added support to join with of many-to-many relation

:+1:

I accidentally closed the pull request. I'm going to send another, but from other branch at my fork


Sync key coding behavior from Darwin

Using keyEncodingStrategy or keyDecodingStrategy, there is a difference of key name case between platforms.

Darwin
Linux

Encode
"camelCase" -> "camelCase"
"camelCase" -> "camel_case"

Decode
"snake_case" -> "snake_case"
"snake_case" -> "snakeCase"

To sync this behavior to be same as Darwin, I just imported this PR changes https://github.com/apple/swift/pull/16238

@swift-ci test

@bendjones can you take a look?

This looks ok to me.

Thanks for doing this!


How to implement this 2 requirements?

Like the SliverAppBar in the NestedScrollView, the expandable header can pinned at the top position when the list scrolling down.

Like the jQuery Accordion

Check out SliverList. The Expandable widget might help you to implement #1 but the implementation will not be simple. For #2 you don't need Expandable, you need a SliverList with a custom SliverListDelegate.
I am closing this, and please note that such questions are outside of the scope of this project. YOu may want to post this on StackOverflow.


MicroServing Implementation

This PR introduces MicroServing API. MicroServing introduces simple yet effective REST APIs to support fine-grained sub-request level actions. A programmable router transforms user requests into sub-request calls, lifting fine-grained scheduling to the API level, thus enabling the dynamic reconfiguration of different orchestration patterns.
Co-authored-by: Ruihang Lai<EMAIL_ADDRESS>Co-authored-by: Charlie Ruan<EMAIL_ADDRESS>Co-authored-by: Yingcheng Wang<EMAIL_ADDRESS>

cc: @MasterJH5574


Aria attribute visible on menu bar buttons

VSCode Version: 1.28.0-insiders
OS Version: Windows 10 Home (Updated)

Hello - after updating to newest version of Code Insiders I've noticed that all menu buttons have aria attribute visible if menuBarVisibility is set to toggle in the settings. The issue did not occur on stable version.
Steps to Reproduce:

Add menuBarVisibility as toggle to settings.json

    "window.menuBarVisibility": "toggle",

Click alt to see menu bar
All Buttons have one aria label visible on them

<u aria-hidden="true">T</u>ips and Tricks

It does not occur on stable VS Code 1.27.0

Screenshot: https://pasteboard.co/HD7hdcy.png
Does this issue occur when all extensions are disabled?: Yes (also with all settings cleared except that one)

Ok. I found it's a duplicate and should be already fixed.
https://github.com/Microsoft/vscode/issues/58156


NPE thrown when empty/null is passes to TimeDimExtractionFn

When a filter query has a dim selector with a TimeDimExtraction function, we get a NPE. This is because TimeDimExtraction didn't handle nulls
@pjain1  @himanshug

@pjain1 @himanshug

👍

@niketh can you check other impls as well and ensure that null is take care of in there.
also, can you annotate ExtractionFn.apply(..) args with @Nullable ?

@leventov @himanshug Add nullable to other interfaces and impls


Add a test for a user who is barred

Closes https://github.com/wellcomecollection/platform/issues/4295
I wrote out a long list of test cases in February 2020, and we forgot to implement one of them.

@pollecuttn was asking me what the behaviour of this was.

So unfortunately we can't really tell from Sierra directly – we have to guess. In particular this error:
{
  "code": 132,
  "specificCode": 2,
  "httpStatus": 500,
  "name": "XCirc error",
  "description": "XCirc error : There is a problem with your library record.  Please see a librarian."
}

is the same whether your record has been manually blocked, or because you're at your hold limit. We return it as a 500 error because we can't actually be sure what's up here.


Automated Package Upgrade

:tada: This PR is included in version 28.5.55 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SAR command (sysstat) doesn't work into VM created using Ubuntu stemcell

I deployed a set of bosh managed vms using stemcells   [3263.10] and [3312.12] with Ubuntu 14.04.
bosh-softlayer-xen-ubuntu-trusty-go_agent | ubuntu-trusty | 3312.12* | 1443361 |
Issuing the sar command  I got:
root@a7bf2596-de9c-4e25-8f9f-eb1fe8bed821:~# sar
Cannot open /var/log/sysstat/sa01: No such file or directory
Please check if data collecting is enabled in /etc/default/sysstat
Despite sysstat is enabled by default Link  it doesn't  work.
Issue is due to the fact that  directory /var/log/systat is missing.
This directory is normally created by dpkg during the sysstat*.deb installation script.
To me it seems a bug of pkg_mgr.
I fixed the deployed VMs  by issuing:
mkdir /var/log/sysstat
service sysstat restart
@maximilien  as per my email

It seems that stemcell contains the /var/log/sysstat folder, but this is "lost" when the bosh agent change the  mount point of  /var/log to  /var/vcap/data/root_log file system.
Notice that the /var/log/sysstat folder is created by dpkg/apt-get during package installation and the sysstat service start script doesn't create that if missing.

The default permission of "/var/log" is set to 775 at line 40, but it's changed to 770 at line 907-910 in  commit 257a51094b68933f3e26a65e561c6c49cdb9b6a2. Need to understand why it's changed to 770.
/cc @aalbanes @maximilien @cppforlife

@mattcui Matt I see, this is another issue.
The sysstat folder creation is not impacted by this permission change, that folder is created by root who owns the /var folder tree... as I said in comment#2 the issue is that deb installation via chroot creates the folder in the root filesystem (/), when the agent start it replace the mount point of /var/log to /var/vcap/data/root_log and this lead to sysstat folder to disappear.

@aalbanes yes, I think there needs to copy all content in /var/log to /var/vcap/data/root_log before bind mount.

@maximilien @jianqiu could you please help discuss with @cppforlife or other guys there when you get a chance. Thanks.

@mattcui DK had some customer thingie today. We'll try him tomorrow

Trying to use the sysstat plugin from Telegraf in a BOSH vm and having a similar issue, would you have any update?

Hey @cppforlife can we chat about this today? Thx
/cc @jianqiu

@fdhex @mattcui @maximilien and i looked into this just now. seems like we could augment stemcell to make it possible to start that service. it seems like unlike auditd service it doesnt create log directory on the fly: https://www.pivotaltracker.com/story/show/140456537

Resoled in stemcell 3421: https://github.com/cloudfoundry/bosh-linux-stemcell-builder/releases/tag/v3421


.card-block p:last-of-type should be margin-bottom: 0

Inside .card-block, the last p tag should be margin-bottom: 0. This is not currently the case.

@brwr Can you post a JSBin demonstrating this issue? I wasn't able to duplicate a situation where this would be a major issue though I may be thinking through this differently than what you mean.

I had a suggestion as to remove the bottom margin of the last immediate child of a panel-body (which could also be applied to a card-block):
.panel-body {
  & > :last-child {
    margin-bottom: 0;
  }
}

But the bs guys don't agree with that (#10825), and apparently cannot even entertain the idea. (#16765)

@kkirsche Here is the requested JS bin: https://jsbin.com/mikinohopa/edit?html,output
This is not a major issue. Removing the margin-bottom from the last p tag is just a reasonable default.
I am actually in favor of @monoblaine's suggestion. It is unfortunate that it was shot down so quickly in both cases.

CC: @mdo

I'd rather see folks use .m-b-0 to nuke things as they need, or as they customize and extend the styles, override things as needed manually.


[SP-4401] Backport of PDI-17203 - XML Output step: Null pointer excep…

…tion when processing fields with null values (7.1 Suite)
@pentaho-lmartins @cravobranco @ricardosilva88

Build Completed
:white_check_mark: This pull request has passed all validations.


Tie resources, social classes, and the map together

Right now we just pass various values around in the update loop.


Kraken regex openshift kill pod fails for statefulset pods

Hello, We are trying to execute kraken to simulate random pod kills on a specific namespace and  we are using the regex pod kill scenario defined here
https://github.com/redhat-chaos/krkn/blob/v1.4.4/scenarios/openshift/regex_openshift_pod_kill.yml
What we can see is, it works as expected when the application pods are deployed as deployments but fails with a timeout when hey are deployed as statefulsets.
python3.9 run_kraken.py --config config/config_openshift.yaml
 _              _
| | ___ __ __ _| | _____ _ __
| |/ / '__/ _` | |/ / _ \ '_ \
|   <| | | (_| |   <  __/ | | |
|_|\_\_|  \__,_|_|\_\___|_| |_|

2023-08-25 08:20:17,348 [INFO] Starting kraken
2023-08-25 08:20:17,353 [INFO] Initializing client to talk to the Kubernetes cluster
2023-08-25 08:20:39,119 [INFO] Publishing kraken status at http://<IP_ADDRESS>:8082
2023-08-25 08:20:39,123 [INFO] Starting http server at http://<IP_ADDRESS>:8082

2023-08-25 08:20:39,124 [INFO] Fetching cluster info
2023-08-25 08:20:39,151 [INFO] Cluster version is 4.12.26
2023-08-25 08:20:39,151 [INFO] Server URL: https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx:6443
2023-08-25 08:20:39,151 [INFO] Generated a uuid for the run: xxxxxxxxxxxxxxxxxx01df30e23350
2023-08-25 08:20:39,152 [INFO] Daemon mode not enabled, will run through 1 iterations

2023-08-25 08:20:39,152 [INFO] Executing scenarios for iteration 0
2023-08-25 08:20:39,152 [INFO] connection set up
<IP_ADDRESS> - - [25/Aug/2023 08:20:39] "GET / HTTP/1.1" 200 -
2023-08-25 08:20:39,156 [INFO] response RUN
2023-08-25 08:20:59,943 [INFO] {
        "output_id": "success",
        "output_data": {
                "pods": {
                        "1692951658935322803": {
                                "namespace": "test-project1",
                                "name": "httpd-sample-57988489d7-fmgnl"
                        }
                }
        }
}

2023-08-25 08:21:21,070 [INFO] {
        "output_id": "success",
        "output_data": {
                "pods": [
                        {
                                "namespace": "test-project1",
                                "name": "httpd-sample-57988489d7-lxxtd"
                        }                                                                                [102/1972]
                ]
        }
}

2023-08-25 08:23:41,587 [INFO] {
        "output_id": "error",
        "output_data": {
                "error": "Timeout while waiting for pods to be removed."
        }
}

2023-08-25 08:23:41,587 [ERROR] Error while running scenarios/openshift/regex_openshift_pod_kill.yml: Step 2 in scenarios/openshift/regex_openshift_pod_kill.
yml (kill-pods) failed
2023-08-25 08:23:41,588 [INFO]
2023-08-25 08:23:41,588 [ERROR] Post scenarios are still failing at the end of all iterations

CAn you let us kow ho we can deploy kraken pod kill scenarios for statefulsets ?

Hi, I apologise for taking so long to reply.
I had quite a hard time reproducing the error and I came to the conclusion, that it was fixed in the arcaflow-plugin-kill-pod in this commit, so if you are still having this issue make sure you have the latest version of it.
The problem was that the pod would come back up so quickly that it did not think that the pod had been killed.
I understand if you have already fixed it.

Closing the issue as it should be fixed in the latest version like @juliemathew mentioned. Please feel free to re-open/reach out in case of any issues/questions/feedback. Thanks.


rtw89: init at 2021-07-03

Motivation for this change
Add support for new WiFi chip. (closes #129098)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Tested on my notebook with Realtek 8852AE, the WiFi now works and seems quite stable. Kernel version: 5.12.9-zen1.
I'm not entirely sure about the metadata as this is mainly copied from the existing rtw88 code.

I'm not sure if the license information is correct. The rtw88 license information is bsd3 and gpl2 only although I cannot find this information on the GitHub repository. For rtw89, the license is gpl2 and I'm not sure if it is gpl2 only, and whether bsd3 would apply.
I'm not sure if I should be the maintainer of this package, I only copied the code from an existing package.
The version is written as unstable-2021-07-03, similar to the one in rtw88. I'm not sure what is the versioning convention for this.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 129325 run on x86_64-linux 1

6 packages marked as broken and skipped:

linuxPackages-libre.rtw89
linuxPackages_4_14.rtw89
linuxPackages_4_19.rtw89
linuxPackages_4_4.rtw89
linuxPackages_4_9.rtw89
linuxPackages_latest-libre.rtw89

11 packages built:

linuxPackages.rtw89
linuxPackages_5_12.rtw89
linuxPackages_5_13.rtw89
linuxPackages_5_4.rtw89
linuxPackages_hardened.rtw89
linuxPackages_latest_hardened.rtw89
linuxPackages_lqx.rtw89
linuxPackages_testing_bcachefs.rtw89
linuxPackages_xanmod.rtw89
linuxPackages_zen.rtw89
rtw89-firmware


Death nettle needs to be resprited

Description

The sprite is messy with a lot of stray pixels.
Screenshots

Someone is working on an entire death nettle rework I believe

#25253 doesn’t change the sprites.


Add Elastic 7 tests

Added elasticsearch tests against a 7.0.0 docker image.
this will allow to test fields added in this version like  date_nanos or flattened..

Merged, thanks for working on this!


Make it easy to query a font's features

Provide a convenience wrapper around CTFontCopyFeatures() so users can easily see if a font supports a requested feature. Could possibly have it take a parameter, and do the heavy lifting behind the scenes:
typedef NS_ENUM(NSUInteger, BONFontFeature) {
    BONFontFeatureUnknown = 0,
    BONFontFeatureSmallCaps,
    BONFontFeatureMonospaceFigures,
    ...
}

+ (BOOL)font:(UIFont *)font supportsFeature:(BONFontFeature)feature;

Or possibly make it an instance method on BONText/BONChain: - (BOOL)supportsFeature:(BONFontFeature)feature. It would throw a runtime exception (or return NO) if the font is not set.

Dup #173


NPE : Attempt to invoke virtual method 'void android.support.v4.app.FragmentManager.popBackStack()' on a null object reference

Application crashed if using support library. Try to use getSupportedFragmentManager instead.
public void dismiss() {
    if (mDismissed) {
        return;
    }
    mDismissed = true;
    new Handler().post(new Runnable() {
        public void run() {
            getFragmentManager().popBackStack();
            FragmentTransaction ft = getFragmentManager().beginTransaction();
            ft.remove(ActionSheet.this);
            ft.commitAllowingStateLoss();
        }
    });
}

Please provide exception stack trace.

java.lang.NullPointerException
	at com.baoyz.actionsheet.ActionSheet$2.run(ActionSheet.java:107)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5143)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
	at dalvik.system.NativeStart.main(Native Method)

Any updates on this issue? I observe the same issue.

I also find this problem,can you fix it?Thanks

I use it in "public void onBackPressed()", maybe something is released after calling this method, so get a NullPointerException, maybe there is some bug in your projrct?

I solved it, make "onBackPressed" running on another thread is ok!

I also had the problem. setCancelableOnTouchOutside (true), this problem must occur when I always click on the event. This problem sometimes occurs when setCancelableOnTouchOutside (false).
@veiz What is your solution ? help me .

My solution is to prevent duplicate clicks


Changed all fonts to be loaded through the PostScript name

Changed all fonts to be loaded through the PostScript name, contrary to the documentation.
Tested to be working on iPhone SE 1 Gen 14.2, iPhone 8 13.7/14.2 and iPhone 11 Pro 13.7

Good to distribute this to the tester that is expiriencing issues directly in App Center and verify that it helps


feat(NODE-3469,NODE-3615,NODE-3507): update min and max wire versions

Description
Updates the minimum wire version for the driver to 6 (MongoDB 3.6) and max wire version to 14 (MongoDB 5.1). Also includes NODE-3615 for bumping max wire version and NODE-3507 for updating SDAM spec tests to raise the max wire version.

NODE-3469
NODE-3615
NODE-3507
DRIVERS-1315

What is changing?
The minimum wire version in the wire protocol has been updated to 6, so MongoDB 3.6, as well as the maximum version number to 5.1 and wire version to 14 for the upcoming 5.1 release. (instead of 5.0). Tests have been added to check the relevant constants.
Is there new documentation needed for these changes?
Perhaps the minimum server version that the driver supports is now 3.6 and not 2.6
What is the motivation for this change?
DRIVERS-1315 to deprecate support for EOL MongoDB versions is the motivation.
Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
[x] Changes are covered by tests

Shouldn't this a semver-major breaking change, since the minimum wire version is increased to 6, which drops support for MongoDB3.2

Hi @matthewmayer, thanks for reaching out: this change was intentional in accordance with our MongoDB Software Lifecycle Schedules. Given the server versions 3.4 and earlier are outside of our support policy range, and have been since January 2020, we no longer test our driver against them and therefore can no longer guarantee compatibility. In the interest of avoiding undefined behavior or silent failures we opted for a thrown error to make sure users are made fully aware of the updated support.
We understand that this could be an unexpected change for some users; however, given the EOL status of the platforms, we expect the real impact to be minimal. We are working on a strategy to better communicate server version support changes in the future that aligns with our configurable Versioned API feature and, of course, we are always listening to the feedback from our community.

I understand it is intentional, but it seems this should have been released as library version 5.0.0 not 4.2.0 following correct semver principles to minimize possible breakage.


Can't use Page model as proxy model

It gives following error while running management command:
Performing system checks...

Unhandled exception in thread started by <function wrapper at 0x110867a28>
Traceback (most recent call last):
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/django/utils/autoreload.py", line 223, in wrapper
    fn(*args, **kwargs)
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/django/core/management/commands/runserver.py", line 110, in inner_run
    self.validate(display_num_errors=True)
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/django/core/management/base.py", line 465, in validate
    return self.check(app_configs=app_configs, display_num_errors=display_num_errors)
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/django/core/management/base.py", line 478, in check
    include_deployment_checks=include_deployment_checks,
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/django/core/checks/registry.py", line 72, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/django/core/checks/model_checks.py", line 28, in check_all_models
    errors.extend(model.check(**kwargs))
  File "/Users/user/projects/projectname/env/lib/python2.7/site-packages/wagtail/wagtailcore/models.py", line 387, in check
    field_exceptions = [field.name for model in [cls] + list(cls._meta.get_parent_list()) for field in model._meta.parents.values()]
AttributeError: 'NoneType' object has no attribute 'name'

My  proxy model:
class PageMeta(Page):
    inherited_objects = InheritanceManager()

    class Meta:
        proxy = True

Which is inherited by BlogPage etc.
I am using master branch, with Django 1.8

Fixed by #1266


Ipython console crashes when closing project that has application still running.

Description
What steps will reproduce the problem?

Open project containing flask application
Run flask application
While application is still running close the project

What is the expected output? What do you see instead?
I was expecting that spyder would close down the ipython console, and exit the project. Admittedly, this may be a PICNIC error, since I did not close my application, before trying to close the project, but I thought that everything would close down without an error. Got the error message below.
Please provide any additional information below
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\plugins\projects.py", line 286, in close_project
self.restart_consoles()
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\plugins\projects.py", line 386, in restart_consoles
self.main.ipyconsole.restart()
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole.py", line 1318, in restart
self.close_client(client=client, force=True)
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\plugins\ipythonconsole.py", line 1236, in close_client
client.stop_button_click_handler()
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 235, in stop_button_click_handler
self.interrupt_kernel()
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\widgets\ipythonconsole\client.py", line 391, in interrupt_kernel
self.shellwidget.request_interrupt_kernel()
File "C:\Users\rbarnes\AppData\Local\Continuum\Anaconda3\lib\site-packages\qtconsole\frontend_widget.py", line 345, in request_interrupt_kernel
self.interrupt_kernel()
File "C:\Users\rbarnes\App

Thanks for reporting. We'll take a look at this in a future release.

The console should be stopped  before closing the project?

It's stopped already.

I think this is a duplicate of issue #5568 and it's already fixed.


refactor-still-valid-module-hook

Summary

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5981  👈
#5980
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ahabhgk and the rest of your teammates on  Graphite

!bench


File associations do not accept extensionless files

When defining the associated language to a file it is impossible to define a default language or a language to be used for files not which the extension is not given. For example if a file is called "CONFIG_H" I cannot tell VS code to treat it as C code because the file has no extension.
Why didn't I add an extension? Because it's a professional project hance I can't choose. Also, just get a full glob support in the first place

@CedT83 your issue can be solved by literally saying
"files.associations": {
  "CONFIG_H": "c"
}

I do the same for other types of files. The keys in "files.associations" are just basic glob patterns.


Expanding use of flow for propType, include flow types in package, add flow-typed

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Prerequisite: generated api docs as a baseline, that's why DialogTitle.md and Typography.md changed.
These initial changes for flow type prop support include:

.babelrc - two plugins to generate propTypes from flow and strip flow types from code
generate-docs-markdown.js - alter to obtain type information from prop.flowType || prop.type
Layout.js - convert to flow and re-gen docs
copy-files.js - add the flow-copy-source to shadow copy source files as .js.flow.  This will distribute flow type definitions with the package.
flow-typed for external libdefs - e.g. mocha.

Given this setup, I don't believe the user of the library will see any changes.  For those that use flow, their use of material-ui will automatically be type-checked for any file using flow types with no setup needed - flow auto-recognizes the shadow files.
Review items requested

Switching stateless function to PureComponent<DefaultProps, Props, void> in order to get defaultProps type checking. I think this is the right way to go as it is the most bullet-proof.  We can stick to stateless functions, but any reference to defaultProps would then not be type-checked.

Implementation notes
The definition of type DefaultProps and type Props is quite specific.  This is the only way I have seen it work properly, more info here.  Specifically, DefaultProps are all made required and Props relists those same props as optional.  The ordering of this statement is important: type Props = DefaultProps & {...}.  Any other ordering causes flow errors.  This doesn't seem to be a problem, it's just a quirk I uncovered.
Docs are generated from comments in whatever type name is bound to props, e.g. type Props

Some early feedback as I'm looking at the source code:

Why do we need the flow-typed folder? That seems to contain a lot of unrelated files. Can't they be provided through npm?
Using a PureComponent for a component that accepts element as properties will most likely perform useless and wasteful check comparisons.

but any reference to defaultProps would then not be type-checked

What do we win with that feature? Function component are lighter, too bad we can't keep them 🤔 !
Also, I'm not sure to understand the primary objective of that PR. Is it to expose a flow version of the lib to end users or to migrate the codebase to flow? I would rather focus on finishing porting the components than flow typing the whole code base. Still, if you want to lead the effort on expose a flow definition of our components, that's awesome 😄 .

Why do we need the flow-typed folder? That seems to contain a lot of unrelated files. Can't they be provided through npm?

flow-typed is a repository of third-party library interface definitions for use with Flow.  Yes, flow types can be provided by NPM as shadow files (like I have setup here), but for those without definitions, flow-typed will update definitions as needed.  For example, a mocha file was created or copied into our repo, and we would need to maintain that libdef.  I was able to remove it because it is provided by flow-typed.  As definitions in flow-typed improve, we will get the benefit without maintaining them directly. These need to be checked in otherwise we will need to instruct every developer to run the install before running flow.  By using flow-typed, we got the following libdefs (not just stubs):
• Installing 10 libDefs...
  • enzyme_v2.3.x.js
    └> ./flow-typed/npm/enzyme_v2.3.x.js
  • prop-types_v15.x.x.js
    └> ./flow-typed/npm/prop-types_v15.x.x.js
  • classnames_v2.x.x.js
    └> ./flow-typed/npm/classnames_v2.x.x.js
  • lodash_v4.x.x.js
    └> ./flow-typed/npm/lodash_v4.x.x.js
  • flow-bin_v0.x.x.js
    └> ./flow-typed/npm/flow-bin_v0.x.x.js
  • object-assign_v4.x.x.js
    └> ./flow-typed/npm/object-assign_v4.x.x.js
  • chai_v3.5.x.js
    └> ./flow-typed/npm/chai_v3.5.x.js
  • mocha_v3.1.x.js
    └> ./flow-typed/npm/mocha_v3.1.x.js
  • webfontloader_v1.x.x.js
    └> ./flow-typed/npm/webfontloader_v1.x.x.js
  • react-addons-test-utils_v15.x.x.js
    └> ./flow-typed/npm/react-addons-test-utils_v15.x.x.js

Using a PureComponent for a component that accepts element as properties will most likely perform useless and wasteful check comparisons.

It uncovered some potential discrepancies in Layout.  I'm not sure it is wasteful if it uncovers errors, and the type checking has zero effect at runtime.  Currently DefaultProp checking for optional props (like component) doesn't work with stateless functions, but does with Component or PureComponent.
If the file is left as @flow weak and only PropTypes are changed, this is a non-issue.  Still, I'd prefer to make a decision now that if needed, it can be converted to PureComponent.  It seems that PureComponent gives us the best coverage with what appears to be no downside.

What do we win with that feature? Function component are lighter, too bad we can't keep them 🤔 !

I'm not sure how quantifiably lighter a function is vs PureComponent, and I know the react folks have said that more PureComponent optimizations are coming.  If we only do propType conversion, not whole file conversion, then we don't have to worry about it.  I think we want to convert propTypes for all, and turn off weak mode as it seems beneficial for different components.

...primary objective of that PR. Is it to expose a flow version of the lib to end users or to migrate the codebase to flow?

Expose flow version of the lib to users.  With the exception of turning of weak mode for Layout this entire PR is geared at best practices of flow typing and exposing that for use.

I would rather focus on finishing porting the components than flow typing the whole code base.

No problem.  I have set things up.  Turn off weak mode on any file where you see benefit, or don't.  As you can see from this PR, prop-types and flow types can coexist without a problem.  So can one file that is strict flow, and others with weak mode, some with prop-types, some with flow types.  This is the incrementalism that the flow team targeted.

Still, if you want to lead the effort on exposing a flow definition of our components, that's awesome 😄 .

Yes, I do, that's why this is here.  I need this baseline approved to move forward.  My primary targets are conversion of:

propTypes with @flow weak (best bang for the buck - all flow users benefit)
remove weak on stateful components -> parameterized flow typed components - we get type checking throughout our most complex components
stateless functions - remove weak.  These are simple to start so least likely to give a great benefit.  With that said, proper interpretation of defaultPropTypes is needed so these may necessitate use of PureComponent.  I'm sure stateless components' defaultProps discrepancy will get ironed out soon though.

Summary
I think I've presented a good rationale behind each of these changes.  I don't want to unnecessarily move stateless functions to PureComponent so I'm watching the linked issue closely.  I'll leave them as-is for as long as possible, and worst case, convert them to PureComponent, for which I have not found a reason to avoid.
Is this approach agreeable?

These need to be checked in otherwise we will need to instruct every developer to run the install before running flow.

I get the point now, we need that folder in order to be able to enable @flow over @flow weak.
My point was any pure logic is going to blast off by React.createElement. As far as I know, we as soon as a component requires an element, we shouldn't use a pure component. It will only end up doing diff comparison for figuring out that this.props.children !== nextProps.children. Hence, using Component over PureComponent makes much more sense to me.
It depends on what it cost to move to do the following change:
-@flow weak
+@flow

I'm far from beeing convinced that typing system actually pay-off, nor that flowtype will prove himself better than Typescript. Just saying that I don't think that we should rush into it. I think that we should be focusing on exposing a flow definition for our users.

Turn off weak mode on any file where you see benefit, or don't.

That's really nice 😄 .

With that said, proper interpretation of defaultPropTypes is needed so these may necessitate use of PureComponent. I'm sure stateless components' defaultProps discrepancy will get ironed out soon though.

That's my biggest issue with that PR. class over function comes with a cost.

The Babel output is much larger.
When chained with Higher-order Component, we can't take advantage of referential transparency.
React says that will improve the perfs of the function component, for instance, no hooks check are needed.

One last point I have been trying the following diff with no warning (static tools as well as the runtime check). Any idea?
-<Layout item xs={12}>
+<Layout item xs={13}>

TL;DR
Thanks for working on it 👍

Thanks for the info on PureComponent vs stateless function.
I can switch Layout back to a function and add back weak  I'll look at the 13 value issue, I can only wonder if it has to do with the extra prop code.  I'll check it out.

Even with weak mode, the default props is an issue.  I reverted to a function and put in a small workaround that I commented.  I'll keep track of the github issue and fix it when I can.
Checking out 13 now...

I just checked:
const wrapper = shallow(<Layout item xs={13} />);

and got runtime:
<Layout /> prop: xs should apply the flex size class

and flow both:
src/Layout/Layout.spec.js:57
 57:       const wrapper = shallow(<Layout item xs={13} />);
                                   ^^^^^^^^^^^^^^^^^^^^^^^ React element `Layout`
 57:       const wrapper = shallow(<Layout item xs={13} />);
                                                    ^^ number. This type is incompatible with
176:     xs?: GridSizes,

I confirm for the 13 thing 😄 . It's working at runtime. For some reason, it's not working with yarn flow on the GuttersLayout.js file but it's working with the Layout.spec.js file.
Two more issues I have noticed:

flow typecheck the /build folder we gonna need to ignore that:

build/test-utils/index.js.flow:3
3: export createShallow from './createShallow';
^^^^^^^^^^^^^ Unexpected identifier

The transpiled code is concerning 😮 , for some reason, react-remove-prop-types do not work.

Layout.propTypes = {
  children: require('prop-types').any,
  className: require('prop-types').string,
  component: require('prop-types').oneOfType([require('prop-types').string, require('prop-types').func]),
  container: require('prop-types').bool,
  item: require('prop-types').bool,
  xs: require('prop-types').oneOfType([require('prop-types').bool, require('prop-types').oneOf([1]), require('prop-types').oneOf([2]), require('prop-types').oneOf([3]), require('prop-types').oneOf([4]), require('prop-types').oneOf([5]), require('prop-types').oneOf([6]), require('prop-types').oneOf([7]), require('prop-types').oneOf([8]), require('prop-types').oneOf([9]), require('prop-types').oneOf([10]), require('prop-types').oneOf([11]), require('prop-types').oneOf([12])]),
  sm: require('prop-types').oneOfType([require('prop-types').bool, require('prop-types').oneOf([1]), require('prop-types').oneOf([2]), require('prop-types').oneOf([3]), require('prop-types').oneOf([4]), require('prop-types').oneOf([5]), require('prop-types').oneOf([6]), require('prop-types').oneOf([7]), require('prop-types').oneOf([8]), require('prop-types').oneOf([9]), require('prop-types').oneOf([10]), require('prop-types').oneOf([11]), require('prop-types').oneOf([12])]),
  md: require('prop-types').oneOfType([require('prop-types').bool, require('prop-types').oneOf([1]), require('prop-types').oneOf([2]), require('prop-types').oneOf([3]), require('prop-types').oneOf([4]), require('prop-types').oneOf([5]), require('prop-types').oneOf([6]), require('prop-types').oneOf([7]), require('prop-types').oneOf([8]), require('prop-types').oneOf([9]), require('prop-types').oneOf([10]), require('prop-types').oneOf([11]), require('prop-types').oneOf([12])]),
  lg: require('prop-types').oneOfType([require('prop-types').bool, require('prop-types').oneOf([1]), require('prop-types').oneOf([2]), require('prop-types').oneOf([3]), require('prop-types').oneOf([4]), require('prop-types').oneOf([5]), require('prop-types').oneOf([6]), require('prop-types').oneOf([7]), require('prop-types').oneOf([8]), require('prop-types').oneOf([9]), require('prop-types').oneOf([10]), require('prop-types').oneOf([11]), require('prop-types').oneOf([12])]),
  xl: require('prop-types').oneOfType([require('prop-types').bool, require('prop-types').oneOf([1]), require('prop-types').oneOf([2]), require('prop-types').oneOf([3]), require('prop-types').oneOf([4]), require('prop-types').oneOf([5]), require('prop-types').oneOf([6]), require('prop-types').oneOf([7]), require('prop-types').oneOf([8]), require('prop-types').oneOf([9]), require('prop-types').oneOf([10]), require('prop-types').oneOf([11]), require('prop-types').oneOf([12])]),
  align: require('prop-types').oneOf(['flex-start', 'center', 'flex-end', 'stretch']),
  direction: require('prop-types').oneOf(['row', 'row-reverse', 'column', 'column-reverse']),
  gutter: require('prop-types').oneOf([0, 8, 16, 24, 40]),
  justify: require('prop-types').oneOf(['flex-start', 'center', 'flex-end', 'space-between', 'space-around']),
  wrap: require('prop-types').oneOf(['nowrap', 'wrap', 'wrap-reverse'])
};

I kept having a recurrent rebase problem - it would succeed, I would push, then would tell me I need to rebase again.  After three attempts, I merged instead.  We should squash/merge this to avoid this commit log.

We would still have to fix the propType issue for users not using flow.

@oliviertassinari - I don't understand the problem - maybe I'm missing it.
The way I understand the production plugin pipeline, you are asking that we generate prop-types only to remove them.
What am I missing?

The thing is that we don't just remove them, we wrap the definitions around a is production conditional clause. That means users can have warnings in dev and a lighter build in production.

Ah, got it.  I'll give it another shot.  If I generate before (plugin listed earlier), then the wrap should occur (later).  I'll look into it.

It could work, it could also be an issue with my plugin.

I'm guessing an issue with the removal plugin.  I explicitly ordered for production (everything) and it didn't wrap.  I'll look at the plugin code.


Kubernetes documentation error?  tls: {} in HTTPS & TLS: Let's Encrypt

Do you want to request a feature or report a bug?
Bug
What did you do?
I'm troubleshooting my own issues getting LetsEncrypt working and spotted an inconsistency in the 2.0 documentation.
What did you expect to see?
In the Kubernetes Configuration Examples of the v2.0 HTTPS & TLS: Let's Encrypt ( https://docs.traefik.io/v2.0/https/acme/#configuration-examples ) examples of Single Domain, Multi Domain and Multi Domain tls.domain, I would expect to see consistent use of the "tls:" or a note if different versions were required.
What did you see instead?
--certificatesResolvers.sample.acme. in the Enableing ACME

Single Domain Kubernetes: "tls: {}"
Multi Domain Kubernetes: "tls: {}"
Multi Domain Kubernetes: "TLS: certResolve: le"

What did you expect?
Consistent use of the certificateResolver name...  If it's "sample", then use that.
In this (https://github.com/containous/traefik/pull/6324) branch, "le" is being changed to "myresolver".
So le, myresolve, sample... Having one through all of the documentation would be excellent.
Also, with the three Single/Multi/Multi examples above, what is the field supposed to be?  tls: {}?  The 2.0 User Guide: Kubernetes and Let's Enrcypt use 'default': "tls:   certResolver: default" Example: https://docs.traefik.io/user-guides/crd-acme/#traefik-routers
Questions?
Let me know... I'm trying to get 2.0 with Lets Encrypt up and running in my own Kubernetes cluster and wanted to pass along my findings as I struggle through my own cluster issues.

Closed by #6324.

FYI, the current stable version is v2.1.
We maintain only the last minor of the v2 (ie: v2.1), so the current doc is https://docs.traefik.io/v2.1/https/acme/#configuration-examples


Improvement: modify the "operator" version to more closely resemble the effect in the original film

A few options to consider for the future from reviewing the original film (see https://www.youtube.com/watch?v=MvEXkd3O2ow starting at 00:25-)

Not all rain columns have cursors
Not all rain columns always fall vertically- some columns stick and fade in/out
Some rain columns have cursors that dont fall the entire lenght of the column, they blink in and out on the way down the screen
Some rain columns have cursors that jump to adjacent columns laterally rapidly creating a random wiggle effect

Some of these options are seen at https://www.youtube.com/watch?v=0xbi3U6G7iA
Great job on this!

Thank you for your kind words and feedback! Hey, that second video is a nice rendition.
I may loop back around to improving the operator version version in the future, at which point I'll factor in your observations. 😊

All I want is for the square 'ripple' codeburst effect to not be on by default. Or for it to be disabled using 'effect=plain'
Please :D
Otherwise this is the best recreation of the look of the intro code from the first film I've seen and I've been investigating Matrix screensavers for 20 years! Well done! I'm comparing it to stills from the film and it's SUPER close 👏👏👏
Other codes are solid as well. I've always wanted the actual screensaver used in the film, but this is the next best thing!


Add scrollbar to table widget

Problem
I noticed the table widget is already scrollable via keyboard navigation: https://github.com/tui-rs-revival/ratatui/blob/main/examples/table.rs
But it is lacking of a scrollbar.
Relates to https://github.com/tui-rs-revival/ratatui/discussions/146
Solution
Add a config scrollbar: bool option or something similar that integrates a scrollbar to visualize the current position.

Perhaps @gibbz00 has some input on this? They mentioned that they were experimenting with Viewport scrolling a little while ago in https://github.com/tui-rs-revival/ratatui/discussions/96#discussioncomment-5426219. It might be related a little.
I wonder whether the entire concept of scrolling shouldn't be pulled out of widgets themselves and into something a little higher level (in a similar fashion to how block acts?). I'm not sure how that would look though.

Close this now that #228 has landed?

I think I'd still like to consider adding scrollbars to the widget as part of the config - e.g. what if table looks something like:
Table::new(rows).scrollbar(Scrollbar::new()...))

Instead of having to manually lay this out?


Change source of css file

Short description
Adjust the source of the custom css accordingly.
Resolved issues
Fixes: #665

Done :)


esp32: Add board config to support MCP2515

Summary
Add board config to support MCP2515
Impact
Only ESP32-Devkit
Testing
ESP32-Devkit

Hi @Ouss4 I fixed the suggestion. He build succeed, only a MacOS failed and sometimes it does. Could you please merge it?


bug: CDKMetadata "Modules" property is an empty string

In @fulghum's box, for some reason the "Modules" property in CDK::Metadata is an empty string.

This was due to an old version of node.js on @fulghum's machine


Play Spotify songs a user is listening to

Skip logic updated
Added a command to play Spotify songs a user is listening to

Made a separate play function.

Added ctx.typing()


std::iterator is deprecated; replace it

std::iterator is deprecated; see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0174r2.html#2.1. It is used ten times in datasketches-cpp:
$ git grep -c std::iterator
fi/include/reverse_purge_hash_map.hpp:1
hll/include/HllArray.hpp:1
hll/include/coupon_iterator.hpp:1
kll/include/kll_sketch.hpp:1
quantiles/include/quantiles_sketch.hpp:1
req/include/req_sketch.hpp:1
sampling/include/var_opt_sketch.hpp:2
theta/include/theta_update_sketch_base.hpp:2

Replace these inheritances with explicit using/typedef declarations in each class.

Not sure exactly when we'll get to this, but this is a good point. We only target C++11, which is prior to deprecation, but these changes won't break compatibility with that version. Definitely worth doing as there's an upside for future compatibility with no obvious drawbacks.

I think some of our existing tasks are wrapping up, so with luck we'll be able to take this up shortly.

I don't seem to get g++ or clang++ to complain about this even if I use c++17.  Not trying to suggest that it's not an issue, just that I'd expected to be complained at. Weird.

You might try with Clang 16 using C++20 and libc++.

@AlexanderSaydakov There's something going with theta sketches that makes things fail if I just remove std::iterator and define the 5 necessary types.

#342 will address this. It might need some tweaks first.

And it has been merged. Might not be perfect -- we welcome any feedback -- but it's certainly better than before.

As a final follow-up, this has now been Officially Released.


Permission denied to create /lib symbolic link

When build the image, there is an error
ln: /lib64: Permission denied
I solved modifying Dockerfile using sudo, so the line 6 will be
RUN sudo ln -s /lib /lib64 \

We have added a user statement to solve this.


memory leak using the defer api of $q

HI there,
I'm working on a large SPA, and we use promises all over the application.
Lately in the invigoration on a major memory leak in the application, I discovered that if the defer object is never resolved/rejected and the closure on the promise keep reference to layout object which may include callbacks to trigger some logic, you can end up having serious memory leak. I guess it because the promises use setTimeout/setInterval in their implementation and the queue of the event loop of the browser  is keeping the reference from GC.
My solution to this issue was to subscribe to the $destroy event of the scope and reject the defer on destruction.
This make me wonder if we can have better angular api  out of the box, which will create defer object and promises and will make sure that the promises are rejected on scope destroy.
what do you think?

Would it be possible to have a plunker that shows this issue? there is no global directory of all the promises, and a promise is just kept in memory as long as there is a reference to it. This is, a promise will be kept in memory as long as your application keeps a reference to it. There might be some circumstances that I am not aware that would prevent a promise not being GCed, but without some working example, there is not a lot to work with to fix this issue

No plunker in 3 weeks that shows the issue, so I am closing this. If you are able to create a plunker that shows the issue, then feel free to reopen this issue


Fix bug where checking with infinite traces does not produce smallest counter example

The raisedEvent and changedInstances relations did not contain all needed 'back loop' tuples


Telescope Extensions

Contact telescope maintainers to add Whaler to the list of Telescope extensions.

Added to the Extenstion Telescope Wiki. Revision b579484
Created issue in the Aweome Nvim Plugins.


esbuild.config.js is too generic naming

I believe esbuild.config.js is too generic naming. It misleads the reader as if that were esbuild config, which it is not. It also 'squats' the place for the actual esbuild config, for example if developer wanted to keep and reuse esbuild settings between different components of the project (such as: esbuild-runner, estrella, vite, esbuild-loader, etc.)
I believe esbuild-runner.config.js would be better naming, directly explaining the purpose of the file.

You are totally right about this. Didn't think that one through. I'll change it!

Just released a new version with the updates https://github.com/folke/esbuild-runner/releases/tag/2.0.0


match character ſ \u017f for s character with case-insensitive flag

Hi, I'm doing a web tool to execute rust regular expressions and when I evaluate (?i)[a-z] in the range appear the character ſ (\u017f)
https://2fd.github.io/rust-regex-playground/#method=syntax&regex=(%3Fi)[a-z]&text=sſ
The character match with the expression
https://2fd.github.io/rust-regex-playground/#method=find&regex=(%3Fi)[a-z]%2B&text=123abcſ
And only appear when the s is in the group

(?i)s:  https://2fd.github.io/rust-regex-playground/#method=syntax&regex=(%3Fi)s
(?i)[a-rt-z]: https://2fd.github.io/rust-regex-playground/#method=syntax&regex=(%3Fi)[a-rt-z]

I'm not  completely sure if this is a bug because something similar happens with the k that match with three characters (\u004b, \ u006b,  \u212a)
https://2fd.github.io/rust-regex-playground/#method=syntax&regex=(%3Fi)k
Is this the expected behavior?
Thanks

Yes, it's correct, according to the Unicode simple case folding rules: http://unicode.org/reports/tr18/#Simple_Loose_Matches
Here's the table: ftp://ftp.unicode.org/Public/UNIDATA/CaseFolding.txt
And the relevant entry for s in particular:
017F; C; 0073; # LATIN SMALL LETTER LONG S

If you want to use only ASCII case rules, then disable Unicode mode: https://2fd.github.io/rust-regex-playground/#method=syntax&regex=(%3Fi-u)[a-z]&text=sſ
Relevants docs are https://docs.rs/regex/1.1.7/regex/#unicode


How to navigate from parent StackNavigator to child StackNavigator inside a DrawerNavigator

This is my current nav stack:
const AppNavigator = StackNavigator({
  Welcome: {
    screen: WelcomeScreen,
  },
  Login: {
    screen: LoginScreen,
  },
  Main: {
    screen: ({ navigation }) => <DrawerNavigator screenProps={{ rootNavigation: navigation }} />,
    path: 'main',
  },
}, { headerMode: 'none' });

const DrawerNav = DrawerNavigator({
  Home: {
    screen: HomeScreen,
  },
  Notifications: {
    screen: NotificationsNavigator,
  },
}, {
  initialRouteName: 'Home',
  contentComponent: DrawerContent,
});

NotificationsNavigator is a Stack navigator with routes: Notifications and Notification
I handle Push Notifications logic on WelcomeScreen (I also check here if the user is logged in)
What I need is to navigate from Welcome to Notification (Stack -> Drawer -> Stack)
I'm trying this, in WelcomeScreen:
const navigateAction = NavigationActions.navigate({
  routeName: 'Main',
  action: NavigationActions.navigate({
    routeName: 'Notification',
    params: { notificationId: '355' },
  }),
});

navigation.dispatch(navigateAction);

Current Behavior
It navigates to Home.
First the action Navigation/INIT appears in AppNavigator
Then it appears the action I dispatch
Then in DrawerNav the action Navigation/INIT is shown.
(Promocion == Notification)

software
version

react-navigation
1.0.0-beta.11

react-native
0.45.1

node
7.10.0

npm or yarn
4.2.0 / 0.17.10

I ended up changing AppNavigator's Main route DrawerNavigator
Now it looks like this:
const AppNavigator = StackNavigator({
  Welcome: {
    screen: WelcomeScreen,
  },
  Login: {
    screen: LoginScreen,
  },
  Main: {
    screen: DrawerNavigator,
    path: 'main',
  },
}, { headerMode: 'none' });

I also needed to change some logic in DrawerContent but the navigation to Notification works correctly.

Glad you figured it out!

Assume I wish to visit Notifications in my Child Nav from my Parent Nav.
const ParentNavigator = StackNavigator(
{
	Home: {
		screen: ChildNavigator,
	},
	.
	.
	.
},
{
	.
	.
	.
});

Your render function probably looks like this:
render() {
	return
	<ParentNavigator
		ref={nav => { this.navigator = nav; }}
	/>;
}

and then in ParentNav using a function you send the following to visit Notifications. Params will be caught anyway in each ComponentDidMount of the child.
this.navigator && this.navigator.dispatch(
				NavigationActions.reset({
					index: 0,
					actions: [
						NavigationActions.navigate({
							routeName: 'Home',
							params: 'Notifications',
						})
					]
				})
			);

Your child nav will look sort of like this:
const ChildNavigator = TabNavigator(
{
	Home: {
		screen: TopBarNavigation,
	},
	Notifications: {
		screen: NotificationScreen,
	},
	.
	.
	.
},
{
	.
	.
	.
});

In the ComponentDidMount of the child nav, do this:
componentDidMount() {
	if (this.props.navigation.state.params === 'Notifications')
		this.navigator && this.navigator.dispatch(
			NavigationActions.navigate({
				routeName: 'Notifications',
			})
		);
}

Where your render function sort of looks like this.
render() {
	return
	<ChildNavigator
		screenProps={{ rootNavigation: this.props.navigation }}
		ref={nav => { this.navigator = nav; }}
	/>;
}

@maggialejandro How did you navigate from drawer? to child StackNavigator. I am still having problem with that


Adds logging info to sln parsing failure

We were missing some logging for solution file parsing

Looks like my issue with CI was related to 6.0.400. @baronfel already has this issue open here.

Nice find - happy to merge this, and we can investigate the 6.0.400 and up breakages here after.


[My images - Lightgallery] Icons are missing on preview

Info

no matter if it's loaded via ajax for standard

Occured only on my private local production - had fonts removed.


bump Octopus.Shared version

Background
Bumps the Octopus.Shared version to pull in the fix in https://github.com/OctopusDeploy/OctopusShared/pull/173

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Using omnibarConfigMap for envid/svcid

Fixes https://github.com/blackbaud/skyux2/issues/811

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4294b9...24af8ef. Read the comment docs.

I'm going to close this and manually open it against the rc- branch.


Backup and Encryption

User Story 21:
As a manager, I want to backup and encrypt my data so that information is not lost.

Not implemented in v2.0


ids in fixtures can't be '0'

Is there a specific reason for this? Ember cli mirage currently replaces my id's with a different number which interferes with my ui and tests.

Does the integer 0 work?

Currently using integers but it doesn't work, should I use strings?

It's because of this: https://github.com/samselikoff/ember-cli-mirage/blob/master/addon/db.js#L55
I'll change it to explicitly check for undefined

Should be all set!


I am missing LUX option

I am missing a LUX or W/m option.
So I can measure how bright it is at sunset and at dusk. Because it is not the same brightness when it is cloudy at sunset.

That's not exactly the same, but now we have UV index: %u in the one-line format

Thank you fro info, but that is no use for me. I need brightness option.

Is there anythinf new regarding LUX or W/m option.


List all nurseries on index page by default

The index page for nurseries has a group of checkboxes at the top of the page to filter the nurseries displayed by district. All checkboxes were unchecked by default and an empty list was displayed to the user.
Change the default so that all checkboxes are initially checked an thus all nurseries are listed. The user can than narrow down the list by unchecking certain districts.
Note: We can change @nurseries in the index action to Nursery.all because the JavaScript form for filtering is send to the results action, not the index action.

[x] Invert default for checkboxes from unchecked to checked, list all nurseries
[ ] Fix bug where checkbox labeled "Alle" (all) will stay checked even after all other checkboxes were manually unchecked (or stay uncheck if all others were manually checked).
[ ] Add tests (a little bit tricky to set up, because JavaScript is involved)

OK, let’s take this one step at a time. The JavaScript bug is not related to this change and can be fixed in a separate issue/PR.
Setting up integration testing should also be done in a separate PR.
So let’s just merge this small fix as-is and move on.


Vite + TypeScript + @pigment-css/vite-plugin requires transformed @mui/material as dependency to function

Steps to reproduce

Obtain and run demo:curl https://codeload.github.com/mui/pigment-css/tar.gz/master | tar -xz --strip=2 pigment-css-master/examples/pigment-css-vite-ts
cd pigment-css-vite-ts
npm install
npm run dev

Load local, as directed by vite (e.g. http://localhost:5173)
Observe page not loading, SyntaxError: Importing binding name 'default' cannot be resolved by star export entries. in console
Add @mui/material dependencynpm i --save @mui/material@latest

Update vite.config.ts to include transformLibraries option for @mui/material:export default defineConfig({
  plugins: [
    pigment({
      theme,
+     transformLibraries: ["@mui/material"],
    }),
    react(),
  ],
});

Observe local now working, no SyntaxError present

Current behavior
Using Vite + React + TypeScript with only @pigment-css/vite-plugin fails to load with error SyntaxError: Importing binding name 'default' cannot be resolved by star export entries. until @mui/material is added to deps and transformLibraries vite.config.ts option.
Expected behavior
Local should load without error.
Context
Ran into the issue when I manually added pigment to a fresh Vite project. After some debugging and testing example projects, found that the example in this repo is broken, but the one in mui/material is not. After some investigation, discovered the dependency and transform differences and applying the changes fixed both my project and the example.
Is this is a new dependency and examples docs are out of date or is this an unintended side-effect of some updates. Perhaps related to @mui/* internal references as noted here?
Your environment

npx @mui/envinfo
  System:
    OS: macOS 15.0.1
  Binaries:
    Node: 22.10.0 - /opt/homebrew/bin/node
    npm: 10.9.0 - /opt/homebrew/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 130.0.6723.70
    Edge: Not Found
    Safari - Used to test: 18.0.1
  npmPackages:
    @emotion/react:  11.13.3
    @emotion/styled:  11.13.0
    @mui/core-downloads-tracker:  6.1.5
    @mui/material: ^6.1.5 => 6.1.5
    @mui/private-theming:  6.1.5
    @mui/styled-engine:  6.1.5
    @mui/system:  6.1.5
    @mui/types:  7.2.18
    @mui/utils:  6.1.5
    @pigment-css/react: latest => 0.0.25
    @pigment-css/vite-plugin: latest => 0.0.25
    @types/react: latest => 18.3.12
    react: latest => 18.3.1
    react-dom: latest => 18.3.1
    typescript: latest => 5.6.3

Search keywords: vite typescript react vite-plugin

I encountered the same issue, and following these steps resolved it for me as well. Thank you, @inimicus, for discovering and sharing this solution! Adding @mui/material and updating vite.config.ts with the transformLibraries option got my project up and running without errors. It would be great if the documentation could reflect this workaround, or if there’s an update on handling this dependency.
Thanks to the pigment-css team for their work on this tool—looking forward to seeing how this evolves!

Updated the example. The fix was to also add prop-types and react-is to the deps and add it to optimizeDeps.include array for the time being.


Optimize for case where CIE contains no register rules

In most cases CIE contains no register rules at all, so the initial rules are default and don't have to be saved. (libgcc's unwinder even just assumes this is always the case and always restore undefined).

I haven't reviewed closely, but I think you need to demonstrate that this is beneficial. The cfi::iterate_entries_evaluate_every_fde benchmark is slower.


Invalid cast

I am trying to use Pkcs11 to talk to an HSM.
I have established a connection to the HSM and can read some information but when I try to read from the session and do a
                    using (var session = slot.OpenSession(SessionType.ReadOnly))                     {                         session.Login(CKU.CKU_USER, "************");                         // Prepare attribute template that defines search criteria for public key                         var publicKeyAttributes = new List<IObjectAttribute>();                         publicKeyAttributes.Add(new ObjectAttribute(CKA.CKA_CLASS, CKO.CKO_PUBLIC_KEY));                         // Find all objects that match provided attributes                         var foundPublicKeys = session.FindAllObjects(publicKeyAttributes);
I get the following error:
Unhandled exception. System.InvalidCastException: Unable to cast object of type 'Net.Pkcs11Interop.LowLevelAPI40.CK_ATTRIBUTE' to type 'Net.Pkcs11Interop.LowLevelAPI80.CK_ATTRIBUTE'.    at Net.Pkcs11Interop.HighLevelAPI80.Session.FindAllObjects(List'1 attributes)
I guess its a configuration issue, but I cannot find the settings that I need to change. Hope someone can giude me

We had not set the path correctly. After we did that, the problem was gone.


Intercept and discard the message

@chkr1011  hello
After the interception of the message, the message is abandoned, that is, do not send to other people.

Hi,
you can set the message to null in the interceptor callback. Then the message will be truncated and not processed.
Best regards
Christian

@chkr1011
      options.ApplicationMessageInterceptor = context =>
        {
            try
            {
                context = null;
                return;

I don't understand where you're talking about.
I tried to set up null in the interceptor, but it didn't work.

I forgot to say that this is only possible with the next 2.6.0 release (which is available as a preview version (nuget)). Please try with that version instead.


Scripts for sample execution do not work with directory structure of the Streams product

The scripts for the execution of the samples only fit to the directory structure of the public github, but not to the structure of the Streams product installation. This should be adapted to support both environments.

Since there is neither a Makefile nor a Studio build config provided with the samples, it would be fair to prepare the scripts of the samples for Studio workspaces, e.g. imported by copy into a workspace.
The directory structure of the git repository, the Streams installation and the Studio workspace should be concerned.
For example:
[[ -f $STREAMS_INSTALL/toolkits/com.ibm.streamsx.network/info.xml ]] && toolkitDirectory=$STREAMS_INSTALL/toolkits
[[ -f $here/../../../../toolkits/com.ibm.streamsx.network/info.xml ]] && toolkitDirectory=$( cd $here/../../../../toolkits ; pwd )
[[ -f $here/../../../com.ibm.streamsx.network/info.xml ]] && toolkitDirectory=$( cd $here/../../.. ; pwd )
[[ $toolkitDirectory ]] || die "sorry, could not find 'toolkits' directory"
[[ -f $STREAMS_INSTALL/samples/com.ibm.streamsx.network/SampleNetworkToolkitData/info.xml ]] && sampleDirectory=$STREAMS_INSTALL/samples
[[ -f $here/../../SampleNetworkToolkitData/info.xml ]] && sampleDirectory=$( cd $here/../.. ; pwd )
[[ $sampleDirectory ]] || die "sorry, could not find 'samples' directory"

I'm not sure I understand your comment. If samples are copied into an Eclipse workspace, they have the same directory structure as the GitHub repository, regardless of where they are copied from, don't they? If so, the speculative directory probes in testPacketFileSourceXxxxxxx.sh should work for samples copied into Studio.


Add Paris final details

Codecov Report
Base: 80.79% // Head: 80.79% // No change to project coverage :thumbsup:

Coverage data is based on head (85ddef1) compared to base (c004ccd).
 Consider uploading reports for the commit 288c2a3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   80.79%   80.79%
=======================================
  Files         370      370
  Lines       20095    20095
=======================================
  Hits        16236    16236
  Misses       3859     3859

Flag
Coverage Δ

unittests
80.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@timbeiko @djrtwo how about this updated version?

LGTM, let's merge this for now (given how long it's already been since The Merge) and if we want to bikeshed over having the TTD there, we can do it in another PR :-)

LGTM, let's merge this for now (given how long it's already been since The Merge) and if we want to bikeshed over having the TTD there, we can do it in another PR :-)

I think a bigger revision to how all this data is presented is needed once the new rollout strategy is agreed on, as there may be 3 different ways by then. Adding that many columns will look weird :)