[Templating] Update documentation for $host and $_acTemplateVersion

Issue
Update adaptivecards-templating documentation to include the following:

$host parameters update
Ability to access templating version via $_acTemplateVersion

Draft PR can be found on docs repo: https://github.com/MicrosoftDocs/AdaptiveCards/pull/448


missed "async" fixed

Without it leads to error when trying to submit wrong login and password

it seems that the same must be fixed inside the library in "MyAuthProvider" class

This method is called inside the template, and can not be async. If you have a use-case who required async get_admin_user, Please fill a feature request issue template


Custom Annotation Dataset, Placement

Hey rrag and contributors, question here on more custom annotation placements.  Just starting to use your package in our platform.  Excited to get more familiar with it.
So we are trying to place our annotation markers based on a different dataset than just our overall candlestick data.  This data is separate but will still have the date and price value fields.
From how I read in your examples, the Annotate component is primarily built to intake the overall data series that is passed to ChartCanvas and is then broken down into ‘d’ within its Chart child.
How might we combine the logic to accommodate the other dataset?  I’m not really clear on how the Annotate component expects data to be passed into it.  From how I see it, it appears that whatever is passed into the ‘when’ conditional function is used internally.  Some documentation on this would very handy.
We would like to pass our dataset instances into the Annotate and AnnotationProps directly.  How can we do this?
Thanks!

Still not clear on this process.
Would it be possible to throw together a quick example of plotted marker points on a candlestick charts?  Overlaying on top of the candlesticks.  Popup info on marker clicks too.
A good example would be instances where a trade was made.  Seems like a pretty essential part of a charting engine.
I'd be down to chat on gitter about this if you'd like.  Please get back to me as soon as you can.  We may be willing to work with you on getting this done.


[Xenoblade Chronicles X] Graphics Packs not working

Hi,
The following Graphics packs don't seem to do anything:
XenobladeX_mod_BladeGainTicketsFromMissions (tested both the DLC setting and TA setting with 0 results)
XenobladeX_NoOfflineTag (tag remains)
The latter is more of an annoyance, but the first one is really bad since the only way to get reward tickets quickly is by beating the big bosses and those are not available offline. :(
Using Cemu 1.15.3b

I am Japanese version 1.15.4 but NoOfflineTag is working properly.
How does your language work with 1.15.4?

I don't have 1.15.4, where can I find that. and how do I get that to work with my current progress?
Also, I managed to remove the offline tag by placing a modded cpk file in the games content folder.

Post your log.txt after running the game.
The latest version of cemu can always be found on the cemu homepage.

I tried 1.15.4, but with that one I have new issues. The XenobladeX_mod_MusicSkellFlightDisabled now wont work. The resolution mod works better with this one, but the music one is more preferable.
I have removed the graphics packs that don't work such as the offline tag one and the mission one. Weird thing is. Ever since I used the forceweather mod I now have incredible lag in the game. Like 5 fps in some cases, but after being in an area for a bit the lag goes away mostly.
I have removed the weather mod, but the issue remains. Also the log.txt has not been updated ever since I used the forceweather mod.
log.txt

When starting the game the shader loading screen is not there, it just loads the game. Wtf...

You need cemuhook for graphics packs that rely on rpx patching.

Yes, I have cemuhook


Allow fetching repos from url

If a URL is passed to --input, we fetch the resource. This removes the need for curl or wget in many cases.

Beside the inline comments please also add tests covering the new feature.

You have previously objected when I've added tests and features in the same PR. Would you still like me to add tests?

You have previously objected when I've added tests and features in the same PR.

I doubt that I have ever made such a statement - to not add tests for the feature being added in the PR.

Would you still like me to add tests?

Yes.

@rotu Since it has been a month I just wanted to check if you are planning to follow up on this ticket or if not close the ticket for now.

It's still a draft since the test coverage is not comprehensive and not a high priority right now. Due to personal stuff, I'm not sure if I'll be able to wrap this up any time soon. I'm sorry - I really want to give this the attention it deserves. If you want to pick up where I left off, I wouldn't mind.

Superseded by #155.


What other functionality should be included?

Brainstorm ideas for built-in functionality here (or open new, separate issue)

Unlikely to have time to implement myself, but my archived package in R had functionality to take dated policy transactions and assign them to the correct interval. This was used for calculating things like premium per policy year. The approach to solve was basically sort+two-pointers, here is the implementation.


Make singleton html and handlebar tags (like partials) use 4 space indentation

Make singleton html and handlebar tags (like partials) use 4 space indentation.

To see what kind of changes this brings to linter, checkout the test case additions for pretty_print_html. Those cases should make it pretty clear what kind of changes one should expect in linting from these changes.

I think for the partials, we definitely want 2-space indentation.  It might be a good idea to use 2-space indentation for the other HTML singleton tags as well, since it'll distinguish them from just something inside a block (I found that a bit confusing when reading the first commit).

Hi @timabbott
So I addressed your comments with the updates to the commits. I didn't squash the new commits completely but arranged them meaningfully so that it might help you in reviewing.
Also I added another commit with achieves two things:

Reduces the complexity of a if else statements (not really a requirement but just to state why I even went down the road which resulted in this commit)
Enforces 4 space indents on tags in situations like:

<button type="button"
class="btn btn-primary btn-small">{{t "Yes" }}</button>

Currently we just honour whatever indentation the developer provided to the second line (the continuation line of the button tag) with respect to its origin line. The last commit starts to enforce a 4 space indent there as well. I separated it out so that it can be merged if that will improve the state of our linter.

Merged, after squashing and cleaning up the commit messages to consistently refer to 2 spaces.  Thanks @adnrs96!

@shubhamdhama FYI :)


Attempt to address https://github.com/driftyco/ionic/issues/2682.

Adds an optional hide-when-closed attribute to the ion-side-menu
directive. If this attribute is set to "true" the side menu will be
hidden from the document layout whenever it is closed.
This was branched from the v1.0.0.-beta.13 tagged branch
It's my first pull request, so apologies for perhaps not quite adhering to the guidelines yet....

closing since the issue was resolved via alternate means


Zone.js is  not working on apache server. Get Call "%5Bobject%20Object%5D" on startup

Zone.js is making a Get call to http://webroot/[object Object] on startup.
In Node (express) env this call is returning the index.html page again.But on any other env (apache) this call is returning 404 error and the page stops here.
Request URL:http://localhost/[object Object]
Why  this get call ?
I am using webpack to compile the application.
CallStack:
Zone.js:101	        setNative.apply(data.target, data.args);

Seem to be getting a similar issue in my application...
https://github.com/jrgleason/ng2-webpack-demo/tree/GULP_EXPRESS
Works fine if I run it under the webpack server, however, if I copy to apache (or even the public folder in express) I get the same error.

In my case I needed to change styleUrls: [String(require('./navbar.component.styl'))]
to styles: [String(require('./navbar.component.styl'))]
It is interesting the other one worked with webpack

this doesn't look like a zone issue. if you are inlining stylesheets in Angular then you should use styles property in the component metadata as @jrgleason suggested.


BLD: fix an outdated requirement for macOS arm64 in pyproject.toml

NumPy 1.20 did build on macOS arm64, but there are no wheels. This change matches an earlier one made in oldest-supported-numpy.
[ci skip]

but if you wanted to both provide maximal NumPy runtime support for the wheels and simultaneously convenience of user pip install,

we do want that

that seems trickier if the minimal NumPy version doesn't have binaries available?

if the metadata is correct, there will always be numpy wheels available. and if it's not correct, we'll catch it faster if we use pyproject.toml numpy versions inside our own wheel build machinery

I think I'm just saying that we could support 1.20.0 as the minimum in this case--are you saying that lack of NumPy wheels == no support from our standpoint--we don't allow from-source builds of NumPy in pyproject.toml build bounds determinations, even if it could theoretically increase the range of NumPy versions we support?

Ah, now I understand what you meant. Indeed, at least no support through the default pip install .. If someone really wants to (but why would you - lots o f unfixed bugs on arm64 in numpy), they are free to select an older numpy by installing it in their build environment and building with pip install . --no-build-isolation.


[AIRFLOW-3165] Document interpolation of '%' and warn

Make sure you have checked all steps below.
Jira

[ ] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3165
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Only doc update.
cc: @ashb

Codecov Report

Merging #4007 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
+ Coverage   75.49%   75.49%   +<.01%
==========================================
  Files         199      199
  Lines       15946    15946
==========================================
+ Hits        12038    12039       +1
+ Misses       3908     3907       -1

Impacted Files
Coverage Δ

airflow/models.py
91.71% <0%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85210d...926da70. Read the comment docs.


Add attestations permission

Changelog

Please copy and paste new entries from CHANGELOG.md here.

Specific changes

Please list each individual specific change in this pull request.

Updated continuous-deployment.yml to grant attestations permission to nested workflow

Recreating.


added missing space

Added the missing space on step 5 :: https://docs.microsoft.com/en-us/azure/site-recovery/hyper-v-azure-powershell-resource-manager#step-5-install-the-provider-and-agent

@Daya-Patil : Thanks for your contribution! The author, @sujayt, has been notified to review your proposed change.

Verified editorial correction.


Integration tests

Added integration tests for the java client.

Testing the sendEmail, sendSms, getNotificationById and getAllnotifications

Added docker container for the jenkins job

Run locally, 👍


feat: add support to use a different KMS key for backup encryption

Description
Add support to use a different KMS key for backup encryption
Expose the ability to provision from a backup CRN in the Elasticsearch DA
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Add support to use a different KMS key for backup encryption
Expose the ability to provision from a backup CRN in the Elasticsearch DA
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

see comments

fixed, my bad

/run pipeline

 2024/11/14 17:13:31 Terraform apply |     "Result": {
 2024/11/14 17:13:31 Terraform apply |         "details": "{\"error\":\"Unauthorized\",\"description\":\"We were unable to complete your request: Unauthorized. Try again with valid permissions or contact support if the issue persists.\"}",
 2024/11/14 17:13:31 Terraform apply |         "error_code": "RC-ServiceBrokerErrorResponse",
 2024/11/14 17:13:31 Terraform apply |         "message": "Please contact the Service Provider for this error. [401, Unauthorized] We were unable to complete your request: Unauthorized. Try again with valid permissions or contact support if the issue persists.",
 2024/11/14 17:13:31 Terraform apply |         "status_code": 502,
 2024/11/14 17:13:31 Terraform apply |         "transaction_id": "626c-0e77f5656f1a876a"
 2024/11/14 17:13:31 Terraform apply |     },
 2024/11/14 17:13:31 Terraform apply |     "RawResult": null
 2024/11/14 17:13:31 Terraform apply | }
 2024/11/14 17:13:31 Terraform apply |
 2024/11/14 17:13:31 Terraform apply |
 2024/11/14 17:13:31 Terraform apply |   with module.elasticsearch[0].module.elasticsearch.ibm_database.elasticsearch,
 2024/11/14 17:13:31 Terraform apply |   on ../../main.tf line 85, in resource "ibm_database" "elasticsearch":
 2024/11/14 17:13:31 Terraform apply |   85: resource "ibm_database" "elasticsearch" {

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.24.0 :tada:
The release is available on:

GitHub release
v1.24.0

Your semantic-release bot :package::rocket:


 These are truly not replies but threaded tweets even thought technically they are classified as replies. There should be an option to spare these replies from being deleted.

Good suggestion, thanks!

I successfully coded and used this feature. But my hack uses user-id of parent tweet to guess which tweet is a thread and I'm not sure how to get this info from user without making them work hard. :) If you have any ideas let me know. I will send a PR shortly with my solution.

@akilan27 was your PR accepted?

I'm yet to make a PR. Will do in a couple of days max.

@akilan27  - any updates?

Hello all,
Sorry for a long delay. Got married, moved countries amid COVID19 etc. Anyway back now and I discovered that Twitter changed their format a bit. Gah. Anyway I will file two PRs shortly: one to fix a "bug" that deleted all tweets even if 'replies' filter is enabled (caused by Twitter changing their file format) and another to preserve threads when deleting replies.

First PR: #91

Creating another PR adds my first commit too. Guess I have to wait for first PR to be approved (The change depends on previous one too).
Here is the commit finishing this issue: https://github.com/akilan27/delete-tweets/commit/f7bd660afe36a2066a786230834d0973648a9259

@koenrh Can you look at the PR?


Broken: Auto-Scroll (Mouse Middle-clicking)

When auto-scroll is used, the site will lock up the mouse and cause the site to not beable to move.
Recreate Issue: Simply go to the site demo @http://ironsummitmedia.github.io/startbootstrap-agency/ and click the middle button of on your mouse's scroll wheel.
This mouse icon will turn into this (icon demands on OS/Browser)

Which operating system version and browser?

Windows 8.1 with all browsers from Chrome 43.0.2357.124 to Firefox 37.0.2 to IE. Sorry for the delay

Closed this Issue for it seems this an issue with browsers in general and on different sites as well.


Handle NodeLinksManager when reading the input value

Fix #266

Codecov Report
Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (5937b88) to head (80d6873).
Report is 45 commits behind head on main.

Files
Patch %
Lines

aiida_workgraph/utils/__init__.py
14.28%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   75.75%   79.84%   +4.09%
==========================================
  Files          70       65       -5
  Lines        4615     4878     +263
==========================================
+ Hits         3496     3895     +399
+ Misses       1119      983     -136

Flag
Coverage Δ

python-3.11
79.84% <14.28%> (+4.18%)
:arrow_up:

python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CI and authentication issue using service accounts

I am trying to use service account to deploy on travis.
gcloud has no issues with activating service account, pushing my docker image to container registry and etc.
The issue is with getting credentials: gcloud beta container get-credentials which returns 404 (cannot see the active project) - as I am authenticated on CI as a service account.
Locally I can run this using oAuth 2.0 authentication but same issue occurs with a service account.
Without credentials I cannot do a rolling-update with kubectl.

@roberthbailey @mbforbes @jlowdermilk you seem like y'all might know how to debug gcloud beta container get-credentials

Does either gcloud beta container clusters list or gcloud beta container clusters describe <name> work? It may be an issue with the way we are authenticating service accounts in general vs. the implementation of that specific command (which doesn't do anything other than getting the cluster and writing a kubeconfig file to the local disk).

Not sure if the issue resolved, but gcloud beta container get-credentials is getting credentials with service account now. No changes has been made, just this morning - it worked.

Strange -- AFAIK we haven't changed anything on our end. If you want to send me the project number for your project I can try to dig a bit deeper on our end. robertbailey [at] google.com.

+cc @jlowdermilk in case he'd like a final look, but closing since this seems to be resolved (please re-open if not!)


Missing memory section for .rodata in neorv32.ld

Hello,
I've been trying to run some software examples on a Fomu.im board. After some experimenting i realized that the neorv32_uart_print() outputs were missing. After some debugging i realized that the static strings where looked for in the DMEM section although they are read only. As only the IMEM gets filled through the bootloader these data were missing.
After some research i found that unmapped sections get mapped to the first defined memory region which has the correct attributes. Link here:
https://users.informatik.haw-hamburg.de/~krabat/FH-Labor/gnupro/5_GNUPro_Utilities/c_Using_LD/ldLinker_scripts.html#MEMORY_command

If an unmapped section matches any of the listed attributes other than '!', it will be placed in the memory region.

Because the linker file defines the ram section first which also has the r attribute the .rodata section (which includes the static strings) is suitable. Here is a snippet from the linker script:
{
/* section base addresses and sizes have to be a multiple of 4-bytes */
/* ram section: first value of LENGTH => data memory used by bootloader (fixed!); second value of LENGTH => *physical* size of data memory */
/* adapt the right-most value to match the *total physical data memory size* of your setup */
  ram  (rwx) : ORIGIN = 0x80000000, LENGTH = DEFINED(make_bootloader) ? 512 : 4*1024
/* rom and iodev sections should NOT be modified by the user at all! */
/* rom section: first value of ORIGIN/LENGTH => bootloader ROM; second value of ORIGIN/LENGTH => maximum *logical* size of instruction memory */
  rom   (rx) : ORIGIN = DEFINED(make_bootloader) ? 0xFFFF0000 : 0x00000000, LENGTH = DEFINED(make_bootloader) ? 32K : 2048M
  iodev (rw) : ORIGIN = 0xFFFFFE00, LENGTH = 512
}

By changing the order and defining "rom" first, the linker would place the .rodata section in the rom, which is correct in my opinion for static read-only data. But this approach would not remove the root of the problem (the unspecified memory section), but only work for this case.
So my solution would be to remove these unmapped sections:
.rodata         : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
.rodata1        : { *(.rodata1) }

An add the wildcards to the mapped section below:
  /* read-only data, appended to text */
  .rodata :
  {
    *(.rodata .rodata.* .gnu.linkonce.r.*)
    *(.rodata1)

    PROVIDE_HIDDEN (__init_array_start = .);
    KEEP (*(SORT_BY_INIT_PRIORITY(.init_array.*) SORT_BY_INIT_PRIORITY(.ctors.*)))
    KEEP (*(.init_array EXCLUDE_FILE (*crtbegin.o *crtbegin?.o *crtend.o *crtend?.o ) .ctors))
    PROVIDE_HIDDEN (__init_array_end = .);

    PROVIDE_HIDDEN (__fini_array_start = .);
    KEEP (*(SORT_BY_INIT_PRIORITY(.fini_array.*) SORT_BY_INIT_PRIORITY(.dtors.*)))
    KEEP (*(.fini_array EXCLUDE_FILE (*crtbegin.o *crtbegin?.o *crtend.o *crtend?.o ) .dtors))
    PROVIDE_HIDDEN (__fini_array_end = .);

    /* finish section on WORD boundary */
    . = ALIGN(4);
  } > rom

In my tests this approach led to correct placements and the neorv32_uart_print() functions were working. Am I missing something here or is this a real bug?

This is really interesting! Seems like a problem during relocation....

I've been trying to run some software examples on a Fomu.im board. After some experimenting i realized that the neorv32_uart_print() outputs were missing. After some debugging i realized that the static strings where looked for in the DMEM section although they are read only.

Could you share a minimal example of your software source code?
What toolchain version are you using (gcc and binutils)?
Do you know to which section your static string was mapped to in the source's object file (so before linking)?

As only the IMEM gets filled through the bootloader these data were missing.

That's right. But right after reset, the CPU executes sw/common/crt0.S, which provides a memory loop that copies .bss's initial data (from IMEM to DMEM).

After some research i found that unmapped sections get mapped to the first defined memory region which has the correct attributes. Link here:
https://users.informatik.haw-hamburg.de/~krabat/FH-Labor/gnupro/5_GNUPro_Utilities/c_Using_LD/ldLinker_scripts.html#MEMORY_command

I was not aware of that :+1:
But I think this would be a workaround.

So my solution would be to remove these unmapped sections:
An add the wildcards to the mapped section below:

Looks very good!
I never saw any data in sections like rodata1 so I have ignored that 🙈 but your proposal is much cleaner. If there is no data in that sections then putting it to rodata does not harm at all.

Thank you for your reply!

Could you share a minimal example of your software source code?

I just used the blinky_led example when I realized that the programm is running but the initial UART output ("Blinking LED demo program\n") is not printed although the bootloader menu showed correctly.

What toolchain version are you using (gcc and binutils)?

riscv32-unknown-elf-gcc (GCC) 10.2.0
GNU ld (GNU Binutils) 2.36.1

Do you know to which section your static string was mapped to in the source's object file (so before linking)?

When i look at the main.c object file it seems to be in the section ".rodata.main.str1.4", which should match the wildcard ( .rodata.)
riscv32-unknown-elf-objdump main.c.o -s

main.c.o:     file format elf32-littleriscv

Contents of section .text.blink_led_c:
 0000 130101ff 13050000 93050000 23261100  ............#&..
 0010 23248100 97000000 e7800000 13050000  #$..............
 0020 13041500 93050000 1375f50f 97000000  .........u......
 0030 e7800000 1305800c 97000000 e7800000  ................
 0040 13050400 6ff0dffd                    ....o...
Contents of section .rodata.main.str1.4:
 0000 4572726f 7221204e 6f204750 494f2075  Error! No GPIO u
 0010 6e697420 73796e74 68657369 7a656421  nit synthesized!
 0020 0a000000 426c696e 6b696e67 204c4544  ....Blinking LED
 0030 2064656d 6f207072 6f677261 6d0a00     demo program..
Contents of section .text.startup.main:
 0000 37550000 130101ff 13060000 93050000  7U..............
 0010 130505b0 23261100 97000000 e7800000  ....#&..........
 0020 97000000 e7800000 63020502 97000000  ........c.......
 0030 e7800000 37050000 13050500 97000000  ....7...........
 0040 e7800000 97000000 e7800000 37050000  ............7...
 0050 13050500 97000000 e7800000 8320c100  ............. ..
 0060 13051000 13010101 67800000           ........g...
Contents of section .comment:
 0000 00474343 3a202847 4e552920 31302e32  .GCC: (GNU) 10.2
 0010 2e3000                               .0.
Contents of section .riscv.attributes:
 0000 411b0000 00726973 63760001 11000000  A....riscv......
 0010 04100572 76333269 32703000           ...rv32i2p0.

It seems to be correct in the object file, and the wildcard which is not mapped to a memory section causes it to be placed in the ram section. Therefore also the copy routine in the crt0.S can't copy the data from the rom to the ram as it isn't in the rom section in the first place (but they also don't need to be in the ram at all, they should stay in the rom as they are read only).

I just used the blinky_led example when I realized that the programm is running but the initial UART output ("Blinking LED demo program\n") is not printed although the bootloader menu showed correctly.

So you did not change any of the default software files? What hardware setup do you use? Especially the memory configuration is interesting here.
And by the way: what kind of UART hardware interface do you use on the FOMU? :wink:

GNU ld (GNU Binutils) 2.36.1

I have not testes that version, but I don't think that any section-mapping related thing have changed. Anyway, I will check that.

It seems to be correct in the object file, and the wildcard which is not mapped to a memory section causes it to be placed in the ram section. Therefore also the copy routine in the crt0.S can't copy the data from the rom to the ram as it isn't in the rom section in the first place (but they also don't need to be in the ram at all, they should stay in the rom as they are read only).

Right, the mapping looks fine.
Please try running this: sw/example/blink_led$ riscv32-unknown-elf-readelf -p .rodata main.elf (so the finally linked file).
On my setup it shows the static string "Blinking LED demo program\n" in placed at offset 0x24 section rodata:
String dump of section '.rodata':
  [     0]  Error! No GPIO unit synthesized!\n
  [    24]  Blinking LED demo program\n

I have checked the programs' main.asm. The reference seems right. The argument of neorv32_uart_print is the base address of the string, which is __extext (end of text segment) + 0x24:
 1ac:	9d850513          	addi	a0,a0,-1576 # 9d8 <__etext+0x24>
 1b0:	170000ef          	jal	ra,320 <neorv32_uart_print>

So you did not change any of the default software files?

No, I did not change anything in the default software source files.

What hardware setup do you use? Especially the memory configuration is interesting here.

I configured the core to use the internal bootloader (in EBR), internal memories for data and instructions (2* 64kBytes) in SPRAM. No cache or external memories are active.
    -- Internal Instruction memory --
    MEM_INT_IMEM_EN              : boolean := true;    -- implement processor-internal instruction memory
    MEM_INT_IMEM_SIZE            : natural := 64*1024;  -- size of processor-internal instruction memory in bytes

    -- Internal Data memory --
    MEM_INT_DMEM_EN              : boolean := true;    -- implement processor-internal data memory
    MEM_INT_DMEM_SIZE            : natural := 64*1024;  -- size of processor-internal data memory in bytes

And by the way: what kind of UART hardware interface do you use on the FOMU?

I used the 4 Touch I/Os which are the only exposed I/Os on the back of the board and soldered wires onto them. And a FTDI TTL to USB converter to get an serial interface. :wink:

Please try running this: sw/example/blink_led$ riscv32-unknown-elf-readelf -p .rodata main.elf (using the finally linked file).

riscv32-unknown-elf-readelf -p .rodata main.elf

String dump of section '.rodata':
  [     0]  Error! No GPIO unit synthesized!\n
  [    24]  Blinking LED demo program\n

It shows the same output on my setup, but the base address is still at 0x80000000.

I have checked the programs' main.asm. The reference seems right. The argument of neorv32_uart_print is the base address of the string, which is __extext (end of text segment) + 0x24:

Here I get different results, where the address points to the ram:
1a8:	80000537          	lui	a0,0x80000
 1ac:	02450513          	addi	a0,a0,36 # 80000024 <__ctr0_io_space_begin+0x80000224>
 1b0:	170000ef          	jal	ra,320 <neorv32_uart_print>

I used the 4 Touch I/Os which are the only exposed I/Os on the back of the board and soldered wires onto them. And a FTDI TTL to USB converter to get an serial interface. 😉

Nice one! :+1:

I just tried your commit which addresses the issue and now everything works fine. 👍

Good to hear! But I am still not sure why the linker thinks the string is located in the .data section... Anyway, thanks for discovering this bug! I will upgrade my toolchains to use the latest binutils. Maybe there was a major change - or maybe this was a design error in he NEORV32 linker script.

Ok, this really is (was) a bug in the linker script. The .rodata.* sub-sections were missing in the final executable .rodata section. Thanks again for discovering and fixing! :+1:


Labels for process collectors

Hi
I would like to have labels for process collectors. It looks like it would be possible assuming that all the metrics in a single process collector have the same label.
I do not however know how to change the label on each collection and also don't know if this would actually be useful.
Has anybody come across this use case and have any input?

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Add a few more fields to Account Model

add attributes and methods for: fbid, has_clips, has_guides, category_name

@calvinps thanks for contribution


using image/js cache but no session data

Hi there.
Using "userDataDir" will make Puppeteer use cache from that folder, but it will also store cookie/session data. Is it possible to make multiple browser instances use same cache for images/js (in order to reduce network load) but use different (or none) cache for cookie/session data?
Also, from https://github.com/GoogleChrome/puppeteer/issues/1316, looks like page doesn't use cache to load from in headless mode (with userDataDir set)? Is it still true? Makes no sense to act like that...

Is it possible to make multiple browser instances use same cache for images/js (in order to reduce network load) but use different (or none) cache for cookie/session data?

@yegor211 I don't think it is possible.

Also, from #1316, looks like page doesn't use cache to load from in headless mode (with userDataDir set)? Is it still true? Makes no sense to act like that...

I didn't get to read the long'ish discussion in #1316. There are some problems with cache reuse between headless and headful profiles, but that's a little exotic usecase.
If you don't switch browser modes (and usually that's not needed in production), profile cache is used just fine. E.g. this script loads most resources from cache on the second and subsequent runs:
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch({
    userDataDir: './profile'
  });

  const [page] = await browser.pages();
  page.on('response', r => {
    console.log(r.request().method(), r.url(), r.fromCache() ? '<CACHE>' : '<NETWORK>');
  });
  await page.goto('https://news.ycombinator.com');
  await browser.close();
})()

Hope this helps.

Is it possible to make multiple browser instances use same cache for images/js (in order to reduce network load) but use different (or none) cache for cookie/session data?

@yegor211 I don't think it is possible.

Also, from #1316, looks like page doesn't use cache to load from in headless mode (with userDataDir set)? Is it still true? Makes no sense to act like that...

I didn't get to read the long'ish discussion in #1316. There are some problems with cache reuse between headless and headful profiles, but that's a little exotic usecase.
If you don't switch browser modes (and usually that's not needed in production), profile cache is used just fine. E.g. this script loads most resources from cache on the second and subsequent runs:
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch({
    userDataDir: './profile'
  });

  const [page] = await browser.pages();
  page.on('response', r => {
    console.log(r.request().method(), r.url(), r.fromCache() ? '<CACHE>' : '<NETWORK>');
  });
  await page.goto('https://news.ycombinator.com');
  await browser.close();
})()

Hope this helps.

Thanks for the answer mate.
So, I see (from your words) that cache reuse is working just fine in headless mode now. That is great.
Your initial answer for my first question was "no", but can I clarify some points with following questions?
Am I able to delete all cookies that were set for the page before I close page/browser instance?
Can I do that on browser level (like delete ALL cookies for EVERY domain)?
Can I remove cookies for the page that was opened not directly by me via "page" and its methods, but for the page that was opened after triggering some actions on my "page"? If I can get to it through some iteration, then I should be able to remove cookies, right? (if we are able to remove them on page-browser levels)
Thanks in advance, sorry if I'm not the best explanator but hope you will understand everything.

Answering the state-management questions: the only bullet-proof method to cleanup cookies/localStorage/etc is to use browser contexts - these will purge everything once they're closed. Browser contexts, however, won't reuse cache.

Answering the state-management questions: the only bullet-proof method to cleanup cookies/localStorage/etc is to use browser contexts - these will purge everything once they're closed. Browser contexts, however, won't reuse cache.

Got it. But am I actually able to clear/remove cookies? At least in some cases? Or it aint possible by any means?

@yegor211 yeah you can get all cookies with protocol's Network.getAllCookies and then delete them using protocol's Network.deleteCookies.

Network.getAllCookies

Can you please show me an example of "Network.something" usage?

We have a pretty decent example in CDPSession description; let me know if this is not enough.

We have a pretty decent example in CDPSession description; let me know if this is not enough.

Thank you again! Sorry if I'm bothering you with questions, just having a big interest.
Can you tell me if there is a difference with this:
await page._client.send('Animation.enable')
And this?
const client = await page.target().createCDPSession(); await client.send('Animation.enable');
Both will work? But what is the prior one and why should we use it?

Sorry if I'm bothering you with questions, just having a big interest.

@yegor211 No worries, that's what we're here for

Can you tell me if there is a difference with this: <...>

Chrome sessions are stateful - there are agents that can be enabled and disabled and that hold some state. The page._client is an instance of CDPSession that's used internally by Puppeteer to drive page interaction. page._client has certain domains enabled (e.g. Page, Runtime and so on), and Puppeteer holds an assumption that its the only one who talks over the session.
I'd highly recommend to create a designated CDPSession for your needs.

I use this to remove all cookies:
	async clearBrowser () {
		// clear cookies
		const client = await this.page.target().createCDPSession()
		await await client.send('Network.clearBrowserCookies')
	}


[BUG]: Add graceful handling of instantiation of ProactiveOpenConnectionProcessor

Determine the best way to handle instantiation ProactiveOpenConnectionProcessor. The handling should not fail CosmosClient / CosmosAsyncClient initialization.

I think this is done - @jeet1995 can you confirm?


Fix models-reducer to be non-destructive.

My actions before raising this issue

[X] Read/searched the docs
[X] Searched past issues

The models-reducer is destructive to the state. Thus when a component subscribes to the store the prevprops and this.props are the same.
Expected Behaviour

The reducer to be non-destructive.
Current Behaviour

The reducer is destructive. For example see line 61 of models.reducer.ts
    case ModelsActionTypes.GET_INFERENCE_STATUS_SUCCESS: {
            const { inferences } = state;
            if (action.payload.activeInference.status === 'finished') {
                delete inferences[action.payload.taskID];
            } else {
                inferences[action.payload.taskID] = action.payload.activeInference;
            }

            return {
                ...state,
                inferences: { ...inferences },
            }

Possible Solution

        case ModelsActionTypes.GET_INFERENCE_STATUS_SUCCESS: {
            const { inferences } = state;
            if (action.payload.activeInference.status === 'finished') {
                return {
                    ...state,
                    inferences: omit(inferences, action.payload.taskID),
                };
            }
            return {
                ...state,
                inferences: {
                    ...inferences,
                    [action.payload.taskID]: action.payload.activeInference,
                },
            };
        }

Steps to Reproduce (for bugs)

Create a component that has modelsstate.inferences as prop
Run annotation
Log this.props.inferences and prev.props.inferences to see the are always the same.

Operating System and version (e.g. Linux, Windows, MacOS):
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

@bigred94
Hi, thx for your concern.
As I understand omit creates shallow copy of an object without a specific key. Right?
But in ES6 syntax { ...inferences } does the same.

Right but you are still modifying the original state because you are deleting the key from the original state THEN making a copy. You need to copy then delete. Following the reproduction steps will show this.


PDM microphone input corrupted when DFS is enabled while using APLL (IDFGH-13860)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3.1
Espressif SoC revision.
ESP32
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
PowerShell
Development Kit.
Custom Board
Power Supply used.
USB
What is the expected behavior?
Clear audio to be recorded from a pair of PDM microphones.
What is the actual behavior?
Audio contains random crackles and pops.
Steps to reproduce.

Download the attached minimal test code test_fw_audio_wav_sdcard_pdm.c onto a board with PDM microphones and an SD card. This code will save 1MB chunks of stereo audio from the microphones to the SD card while it runs.
Run the code with DFS disabled. Listen to the recorded audio, which is clear.
Run the code with DFS enabled (any CPU frequency range). Listen to the recorded audio, which contains periodic crackles and pops.

Debug Logs.
No response
More Information.
As far as I can tell from the ESP-IDF documentation, datasheet, and reference manual, this configuration should be fully supported. The documentation claims that the I2S peripheral should be able to run from the APLL while only holding the NO_LIGHT_SLEEP power management lock, and the datasheet and reference manual do not suggest that changing the CPU or APB bus speed in this configuration will cause any issues.

@L-KAYA Reading through this commit, as far as I can tell this completely removes the ability to use DFS frequencies below APB_MAX with a number of different peripherals and modes (DAC DMA, I2S PDM, I2S STD, I2S TDM, and I2S LCD).
I can't speak to all of these modes. That said, we currently use DFS to switch between 10MHz run and 80MHz run with I2S STD mode. This is already deployed on a production device, and it works well. The reported issue is only with I2S PDM mode. I suspect there are other teams which would have similar issues, since this is a breaking change that removes functionality.
Additionally, as noted in the original report, this issue occurs whenever the CPU frequency changes. Holding the ESP_PM_APB_FREQ_MAX is not sufficient to prevent this issue when I2S PDM mode is used, because e.g. switching from 80MHz run to 240MHz run also causes the issue.

Hi @therealergo, thanks for your feedback!
I'm sorry that the fix doesn't solve the issue, and seems I misunderstood your problem. Let me confirm again, and please correct me if I have something wrong:

DFS + I2S STD + APLL can work correctly, but DFS + I2S PDM + APLL data corrupted;
Have you also tried to capture the clock on the pin, and check if its frequency is correct during the CPU frequency scaling?
Will the audio speed up or lower down after the frequency scaling?

If the audio speed and the clock are both correct but only the audio corrupted when CPU frequency changed, it might probably an issue in the PDM2PCM converter.
Anyway, I'll have a further investigation and will post here if there is any new questions or findings. Sorry again for the inconvenience!

@L-KAYA Thanks for looking into it! To answer each of these:

That is correct. DFS + I2S STD + APLL works correctly, but DFS + I2S PDM + APLL does not work correctly. I have seen this at every DFS frequency range, so DFS + I2S PDM + APLL does not work correctly even when DFS is scaling from 160MHz to 240MHz (and the APB speed is constant).
I have captured the PDM clock pin, and did not see anything odd. The frequency does not change up or down when the frequency changes, and I do not see any obvious glitches or issues.
The speed of the audio may not change, but some audio samples are corrupted. I've attached sample audio recorded using the test code attached to the original report. The "TEST_DFS_OFF.WAV" audio is recorded with DFS disabled, the "TEST_DFS_ON_160_240.WAV" audio is recorded with DFS between 160MHz and 240MHz enabled. With larger DFS frequency ranges, the driver will also record fewer samples than expected, and sometimes even timeout while waiting for samples.
Yes, for DFS + I2S STD + APLL, APB frequency should remain scalable. That case works just fine. I recommend reverting it so that it doesn't break that case.
I've attached the sdkconfig used with the previously-attached test code.

Based on the situations that I've seen fail, my assumption is roughly the same. It's either an issue with interrupt handling, or an issue with the PDM2PCM converter itself.
Please do let me know what you find on further investigation!
attachment.zip


New error with ping and using hostnames

Admittedly I'm running a fork of this release but this issue appears to be related to the recent change of ping module. I had one device that was configured using a hostname instead of an IP address. When using the hostname, ping based status changes never happened. Changing the config to an IP address appears to fix the issue.
Could anyone else confirm if they can replicate the issue?

Interesting, I'll check it out thanks


map view: svg marker not rendering as expected

steps to reproduce:

upload custom marker in svg

expected behaviour:

the marker should be the uploaded issue

actual behaviour:

orange marker appear

no errors in the developer tools console

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Mapping sentences to features of video frames

Hi Mattia,
Thank you for your nice work!
I am trying to map sentence features with corresponding frame-level features.
Because the features are extracted at 5-FPS, the timestamps provided in the annotation-files would translate to 5 times their values for obtaining the indices of corresponding video features, no?
E.g., if timestamps of a particular sentence is [4239.133, 4240.508], then I would imagine that the video features would be from visual[movie_id][4239 x 5] until visual[movie_id][4241 x 5].
Could you please let me know if this is the right way to interpret the data?
Kind regards.

Dear @akskuchi, your intuition is correct.


fix Build and Run GOPATH dir

was probably missed in https://github.com/kubernetes-sigs/descheduler/pull/182

/lgtm

/approve
thanks @tambetliiv for this pr.


Feature request: Add song info to tray or dock title

I noticed there's no currently playing song info either tray or dock title. If I want to know what's playing, I have to open minimized app. Dock title is currently "Google Play Music Desktop Player" whcih makes sense, but you could add some info on the tray at least. What do you think? Radiant Player has quite cool tray "miniplayer", but I guess that's only possible for Mac?

Radiant Player has quite cool tray "miniplayer", but I guess that's only possible for Mac?

Technically possible anywhere but we already use the tracy icon to fulfill another purpose.
We can't add the info to the tray as it just overflows the bounds and becomes quite useless.  We also can't put it on the Dock title as I'm 99% sure it violates the mac design guidelines.

Maybe during a rework one day we can repurpose the tray icon, but that won't be any time soon.

Ok, thanks for the response. Appreciate it. 👍


Avoid creating and validating MC credentials when MC is disabled

What type of PR is this?
/kind bug
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1902
Does this PR introduce a user-facing change?:

Avoid creating and validating MC credentials when MC is disabled

/test pull-kubeone-lint


feat(core): styled-components v2 update

updates project to use to styled-components v2 🎉
i'm thinking we should probably update deps and cut a release soon...
edit: congrats on the release @mxstbr!! https://www.styled-components.com/

Coverage remained the same at 99.242% when pulling b4074b52a0c89538e9082eaa9976990d62121c4b on feat/styled-components-v2 into cfe0c7ce16e376bb32df1ac6b27ac715a6cf6c1f on dev.

Coverage remained the same at 99.242% when pulling 680f333a63f20321b4d394e113aca02d67d40513 on feat/styled-components-v2 into f813fb6aba2a761875ad75f28ebaa30da07a658d on dev.

Coverage remained the same at 99.242% when pulling 680f333a63f20321b4d394e113aca02d67d40513 on feat/styled-components-v2 into f813fb6aba2a761875ad75f28ebaa30da07a658d on dev.

Coverage remained the same at 99.231% when pulling 31e0295c791141d3ad517598f8f0acca73ede15c on feat/styled-components-v2 into 88616cedf47793440794ef8bcd429cd9881782be on dev.

Coverage remained the same at 99.231% when pulling a51028aa2401d313b12eefe86abba433cfb76e7f on feat/styled-components-v2 into a2173a26335cb63e9cb13707afafd12ced7cdfa5 on dev.

@justingreenberg Just a small query. Is babel-plugin-styled-components necessary? Because it says-

This plugin is only necessary if you're server-side rendering, you can use styled-components perfectly fine without it!

And we're not supporting ssr atm.

@KarandikarMihir, it doesn't look useful at the moment but it could be in the future once minification is no longer an experimental feature, so I'm going to give this a thumbs up, but if this plugin is removed I'm fine with that too.

@KarandikarMihir, I've read the description of babel-plugin-styled-components again and it says that it's fine to enable minification in production as long as it's enabled in development as well, so I think this plugin is useful after all.

@justingreenberg, I have one nitpick, otherwise, nicely done :+1:
I've tested your branch and everything seems to be fine (to be more precise, spotted some bugs but they're unrelated to this PR)

Coverage remained the same at 99.231% when pulling 894869f868796f0b7d61b4a3c825ab89235a4097 on feat/styled-components-v2 into 5ec8dd423a56be9a9ac1ef943e8779b4b8e9646d on dev.

@KarandikarMihir & @Dattaya thank you guys!
Re: the plugin - I added it primarily to generate displayName (for use with devtools):

This babel plugin adds the components' name to the class name attached to the DOM node. In your browser's DevTools you'll see <button class="sc-Button-asdf123 asdf123" /> instead of just <button class="asdf123" />.
This also adds support for showing your components' real name in the React DevTools. They will normally show <styled.button> for all of your components, but with this plugin they show <MyButton />.
This makes it easier to find your components and to figure out where they live in your app.

ref: https://github.com/styled-components/babel-plugin-styled-components#better-debugging
preprocessing will be a very cool feature, but I would wait until it stabilizes before turning on

Coverage remained the same at 99.237% when pulling 7572e0fdecdd05564d46986bf468f7cf5f31418f on feat/styled-components-v2 into 24de895d587870ab0e204e9d64f6da0f0b837349 on dev.

Coverage remained the same at 99.237% when pulling 7572e0fdecdd05564d46986bf468f7cf5f31418f on feat/styled-components-v2 into 24de895d587870ab0e204e9d64f6da0f0b837349 on dev.

@justingreenberg @Dattaya Alright! Thanks for clearing that up for me. Let's :ship: :smile:

Hello guys, I am trying to use styled-components v2 in the react boilerplate 3.4 (why? because of the better debugging in inspect tools - https://github.com/styled-components/babel-plugin-styled-components#better-debugging) ... I have done all the changes as indicated here in this PR - however it seems that I am getting an error
index.js:7 Uncaught TypeError:
WEBPACK_IMPORTED_MODULE_0_styled_components.default.a.withConfig is not a function
at Object../app/components/A/index.js (index.js:7)

which is the following line -
const A = styled.a
seems like the styled function is not working any more. This issue goes away when I remove the babel plugin, but then I end up with cryptic class names that dont help debugging

@somghosh, what is the result of:
> npm ls styled-components

also, that line looks wrong, it should be
const A = styled.a`

Hi @Dattaya
> npm ls styled-components
gives
<EMAIL_ADDRESS>/Users/somghosh/Programming/xeniajs
├──<EMAIL_ADDRESS>└── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>
npm ERR! peer dep missing<EMAIL_ADDRESS>|| ^2.1.0-beta || ^2.1.0, required by<EMAIL_ADDRESS>npm ERR! peer dep missing: webpack@1 || ^2.1.0-beta, required by<EMAIL_ADDRESS>
And yes,
`const A = styled.a``
This is exactly what I am doing, sorry for the typo

@somghosh, I can see that you have outdated webpack 2 RC. In this case I recommend you to use the dev branch, it's the same as master but with updated dependencies.

Thanks, yes I figured out thats the case as well. I updated to webpack<EMAIL_ADDRESS>-- and what is now happening is the styled-component is adding a 'sc-' prefixed classname, but the remaining part of that classname is still another random text
Using the dev branch might introduce more uncertainties maybe - I simply want nice debuggable classNames in the Developer Console

Can I kindly ask @Dattaya if, when you made this pull request (and was merged), you were seeing "nice" classnames being produced by styled component?
As I said, I upgraded to webpack 2.6.1 and what I am seeing is as below

Can you run cat node_modules/styled-components/package.json | grep version ? If you use the Babel plugin with any 2.x version (apart from some pre-releases) it should work.

"version": "2.1.0",
also "babel-plugin-styled-components": "^1.1.5",

thanks @mxstbr , I think it is working in terms of adding the new className, just not a "nice" classname

Apologies @mxstbr @Dattaya  - this works now, I seem to have forgotten to put in the
"plugins": [
 +      "styled-components"
 +    ],

bit after making several changes.
I also quickly checked that this is not in the dev branch code in package.json - maybe we should put that in to get the most out of styled-components

@somghosh I'm glad to hear you figured it all out 👍

I also quickly checked that this is not in the dev

I think it is: https://github.com/react-boilerplate/react-boilerplate/blob/dev/package.json#L52


refactor: reuse expectThrowAsync utils

I found the expectThrowsAsync method is used in:

EthEstimateGas
EthCall
GwExecuteRawL2Tx
IntrinsicGas
MinGasPrice

Do we need to check on IntrinsicGas and MinGasPrice?

yes, I will add the missing one

I found the expectThrowsAsync method is used in:

EthEstimateGas
EthCall
GwExecuteRawL2Tx
IntrinsicGas
MinGasPrice

Do we need to check on IntrinsicGas and MinGasPrice?

updated


ONT-37 - View individual trait & ONT-43 - View uploaded trait before finalizing import

Changes

Have two data table types now, expandable row and side panel
Updated existing admin & program tables to use expandable row table
Updated trait import and trait list tables to use side panel table
See https://trello.com/c/hEz1c0Ri for detailed breakdown of subtasks
Fixed some other small existing issues

got rid of unwanted title tool tip on pages
fixed alignment of user login text with logout button
removed some space between page header and content title to be more inline with design reference

Running

A new dependency was added for vue breakpoint so you'll need to run npm install

Design

See https://trello.com/c/hEz1c0Ri for high level design
Table column model based on buefy data table (not latest version)

Looked into vue provide/inject as an alternative way to get table reference but held off for now due to issues

Table breakpoint column collapse is done dynamically with vue breakpoint

Limitations

Uses position: sticky css which limits browser support (particularly IE)

May eventually switch to a site wide contextual side panel and address this (https://trello.com/c/r0Z2P5k0)

Sidepanel set to 100vh to allow for panel content scrolling when sticky and table bigger than sidepanel

Should probably make the close button not scroll at some point
May eventually switch to a site wide panel as stated above

In mobile, page header covers part of sticky side panel

should fix it if we get some time

Only supporting existing scale types (Code, Date, Duration, Nominal, Numerical, Ordinal, Text) for trait details panel

design reference has extra types such as boolean, integer, units

Parser only allows integers for min/max values, not dates which it seems should be allowed?

Should we create a card for this?

Testing

Created test file for testing display of traits detail side panel for different method/scale types and scrolling
test_trait_details.xlsx

Acceptance Criteria

See https://trello.com/c/hEz1c0Ri & https://trello.com/c/sj0tsBx2

 ONT-43 - View uploaded trait before finalizing import

 ONT-42 - Trait Import Failed

 ONT-37 - View individual trait

Parser only allows integers for min/max values, not dates which it seems should be allowed?
Should we create a card for this?

BrAPI has the min/max scale values as integers, so allowing dates in there too might cause some issues. Maybe adding our own custom fields for mix/max date would play better with BrAPI?

Parser only allows integers for min/max values, not dates which it seems should be allowed?
Should we create a card for this?

BrAPI has the min/max scale values as integers, so allowing dates in there too might cause some issues. Maybe adding our own custom fields for mix/max date would play better with BrAPI?

Ya, the min/max date is coming from crop ontology which BrAPI based stuff off. You can see in the BrAPI spec under the min value it says for numerical and date scales. It may be an oversight in BrAPI if the intention is to actually support that?

Ya, the min/max date is coming from crop ontology which BrAPI based stuff off. You can see in the BrAPI spec under the min value it says for numerical and date scales. It may be an oversight in BrAPI if the intention is to actually support that?

Ah ok, I just looked at the schema, not the description. Maybe something we want to check with Pete on before we commit to support date ranges? I'm thinking if BrAPI intentionally does not support date ranges in that field, it will add a lot more complexity/logic and potential breakages for that field if we allow dates in there.

Ya, the min/max date is coming from crop ontology which BrAPI based stuff off. You can see in the BrAPI spec under the min value it says for numerical and date scales. It may be an oversight in BrAPI if the intention is to actually support that?

Ah ok, I just looked at the schema, not the description. Maybe something we want to check with Pete on before we commit to support date ranges? I'm thinking if BrAPI intentionally does not support date ranges in that field, it will add a lot more complexity/logic and potential breakages for that field if we allow dates in there.

Ya, I'll ask Pete about it.

Ya, the min/max date is coming from crop ontology which BrAPI based stuff off. You can see in the BrAPI spec under the min value it says for numerical and date scales. It may be an oversight in BrAPI if the intention is to actually support that?

Ah ok, I just looked at the schema, not the description. Maybe something we want to check with Pete on before we commit to support date ranges? I'm thinking if BrAPI intentionally does not support date ranges in that field, it will add a lot more complexity/logic and potential breakages for that field if we allow dates in there.

Ya, I'll ask Pete about it.

Created card https://trello.com/c/3QrdgElK and issue on BrAPI github. Pete's going to change the field type to support dates so we'll wait for that and have this card for when it's ready.

Looks fantastic!!!! The thoughtful application of scrolling in the side panel for long scales is especially nice.
One tiny detail, if it isn't too much to request: in the side panel is it possible to map the scale methods to a phrase? Examples:
"Ordinal" => "Ordinal Scale"
"Nominal" => "Nominal Scale"
"Numerical" => "Numerical Units"
(for the line "Plant Observation in Ordinal" to become "Plant Observation in Ordinal Scale")
...some of them wouldn't get a word, like "Date" or "Text" probably. I had slightly different language in the design reference due to having slightly different list of scales (still couldn't find where the heck I got that from).
If it's too much trouble, then this is a small point and not worth holding up the card for more than a short time. It would read more cleanly with the extra word to make a coherent noun, but is not a make-or-break item.

Pushed changes.


Frogger Game in JS

Can you assign it to me?

@Shreya-art Sure. Go ahead

@Shreya-art any update?

Please assign me this issue and please tell me that the game is of frog jump only or anything else @geekymeeky ?

@aditya687 Sure. Go ahead


How to deploy openwhisk with source code?

I am trying to modify the logic of openwhisk controller and invoker for acadmic research.
How can I build Openwhisk with modifed code and deploy it into a cluster?

You can deploy OpenWhisk with Ansible or a Helm chart

Thank u for help. Now I guess I can build the source code by ansible.
But I still confused about the deploy method of using helm chart. I see lots of configure files and I guess this method will pull the Openwhisk from remote. So, does it means such method can not deploy our modified Openwhisk in our local storage?

You can deploy OpenWhisk with Ansible or a Helm chart

Thank u for help. Now I guess I can build the source code by ansible.
But I still confused about the deploy method of using helm chart. I see lots of configure files and I guess this method will pull the Openwhisk from remote. So, does it means such method can not deploy our modified Openwhisk in our local storage?

https://github.com/apache/openwhisk-deploy-kube#deploying-a-locally-built-docker-image

https://github.com/apache/openwhisk-deploy-kube#deploying-a-locally-built-docker-image

Thanks


Add the remaining Event blocks

Now, ALL Event blocks from Scratch 2.0 is at Event Category
Also, i made a github page to test this
https://joaoh1.github.io/sb-onlinetests/

One comment but otherwise looks good to me!


Cannot execute ffmpeg command

So, I've created a windows batch file to encode multiple files....for testing purpose I have renamed the files to video1.mp4 and video2.mp4.

In ffmpeg the progress works as intended, it processes video1.mp4 2 times (it is ment to do so), and then continues with video2.mp4
in ffmpeg-bar it processes video1.mp4 1 time, and then gives me this error

video1.mp4: No such file or directory

and then gives me this error for video2.mp4
video2.mp4: No such file or directory

It seems like a strange bug, given that using pure ffmpeg works just fine...

Show us the script.
I've seen this before when concatenating a command in various parts by feeding parts of it into variables and then stringing them all together at the end.
eg:
cmd1="ffmpeg-bar -i $input"
cmd2=" -foo bar"
cmd3=" -f mp4 $exportName"

${cmd1}${cmd2}${cmd3}
...fails with your error (iirc)
bash -c "${cmd1}${cmd2}${cmd3}"
works...but
eval "${cmd1}${cmd2}${cmd3}"
is slightly more elegant
Not sure if your error relates to ffmpeg-bar in your case, but sometimes the way you structure the command requires that you execute it as above....so it might be your issue.
...Show us the actual script.

in my case I'm actually running a .bat script from my computer. The script is very long, but I think the issue arrises from the fact that I use CALL :playlist to start a function reusable function...using ffmpeg-bar without this statement or ffmpeg with the statement works...but using ffmpeg-bar with this statement does not work...giving me the error Invalid attempt to call batch label outside a batch script
Testing
I've made a simplified scripts that has the same issue.
To test, you have to create a .bat eg. test.bat file with this contents, have 2x .mp4 in the same folder, i've called them video1.mp4 and video2.mp4. You can use any video files, but smaller files takes shorter time to test with. I used the 1.5MB file from https://file-examples.com/index.php/sample-video-files/sample-mp4-files/
The Script
@ECHO OFF
FOR /f "tokens=*" %%f IN ('DIR /B /A-D /O:N *.mp4') DO (
   ffmpeg-bar -i "%%f" "%%~nf_output.mp4"

   PAUSE
   CALL :playlist
   PAUSE
)

PAUSE

:playlist
ECHO playlistMethod
EXIT /B 0

Folder Preview

I was wrong, this is not the issue....the issue arrises from the fact that I need to write CALL in front of ffmpeg-bar in order for this to work. And then, if you use %% to use an ffmpeg-variable template it stopps working...and writing %%%% to escape the variable does not work...even though it should work


[FALSE-POSITIVE]  cdn2.hubspot.net

Domains or links
cdn2.hubspot.net
More Information
How did you discover your web site or domain was listed here?
This is a Content Delivery Network (CDN) that serves static images and resources for the Hubspot network
This broke the layout of this page for me: https://www.varonis.com/blog/netcat-commands
Have you requested removal from other sources?
https://github.com/TonyRL/blocklist/issues/2
https://github.com/hemiipatu/PiHoleBlocklists/issues/14
https://github.com/blocklistproject/Lists/issues/711

I also added this removal-request on https://github.com/RPiList/specials/pull/744

Closing as it is already in the whitelist.


Adding subject to Slack notification

Whoops - should have added this in the last PR.  Having the subject in the slack notification helps distinguish what environment the alert is coming from.

LGTM


Replace legacy kubectl commands with rest-client in kube client.

In the kubernetes client apis, there still exist the legacy kubectl commands.
https://github.com/apache/incubator-openwhisk/blob/5b13c4c90e4f8d59156c862c2ffe57ef027e5aee/core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala#L168-L174
It's better to replace this with rest-client based on fabric8.

Currently, the kubernetes client tests are made by mock client with limited number of test cases. After removing kubectl commands, we can refactor our tests with more comprehensive test cases by using mock kubernetes server.

Done 4 months ago in https://github.com/apache/incubator-openwhisk/pull/3963 but I forgot to close this issue.


Made a gui interface for realtime voice conversion

Also I made a video BV1Cc411V7GS to advocate your project.

Oops I forgot to add pysimplegui to the requirements.txt

OK thx a lot. I've been hoping to contact you and continue to complete my code. I'll spend time on it.

Do you mean that I should add some blank length before the recorded sound manually and then pass it to the infer function and set ’f_safe_prefix_pad_length‘ the same length value? I've worked on it but not figuring out how it works. And after inference, I should add the cross-fade function(I've add this function but not displayed it on the GUI). Is this what I'm going to do?


Not all key combinations get registered correctly

On win10, there seems to be an issue with 1) numpad inputs 2) combo inputs https://github.com/golota60/trayasen/issues/16#issuecomment-1718909183
thanks @falkenhawk for reporting this 🙇

As suggested in https://github.com/golota60/trayasen/issues/16#issuecomment-1724970876 to take values for keys and their combinations from https://www.electronjs.org/docs/latest/api/accelerator I've tried the following combinations by entering them in idasen-tray-config.json and restarting the app:

P - works ✔
Alt+P - works ✔
Shift+P - works ✔
AltGr+P - doesn't work ❌
Meta+J - doesn't work ❌
Super+J - doesn't work ❌
Control+J - works ✔
CommandOrControl+J - works ✔
Shift+Control+J - works ✔
numdiv - doesn't work ❌
nummult - doesn't work ❌
* - doesn't work ❌
0 - works ✔
num0 - doesn't work ❌
Up - works ✔
Shift+Control+Alt+Up - works ✔👀

Alright, so I've worked on this on and off for a couple of days, and I think there's not much to be done for now(except fixing frontend keyboard inputs on macOS/win10(? - cannot really speak for win10 as i really cannot find a machine running win10 anywhere) - which will be a part of 0.1.0).
Fixing the behaviors described here(ty for that btw 🙇 ) is more troublesome though. The shortcuts are managed by the upstream framework tauri, but it's pretty inconsistent with what it supports - the feature parity with electron seems to just not be there yet. For example Meta/Super/Numpad/AltGr behaviors simply just do not work, and since the keyboard handler API is pretty low-level and fully handled by the framework, the current fix is either waiting for the folks to fix that in the upstream framework, or having keystrokes be handled via external library on a different process - which is a pretty major change.
I'll try to file an issue upstream in the following days, but unfortunately, there's not much fixing to be done to this as of now. I will keep this open, as I assume tauri v2 will have most of this fixed, and I'll get back to this issue then. In the meantime, I'll try the more complicated workaround fixes, but it's unclear if they will be viable🤞. Anyways, they will not be a part of 0.1.0
Another thing I'll do is have an entry in the README.md pointing to this comment, so people can try to fix-up any cross-system weirdness themselves, as this feature really seems to be unstable in the framework, and I cannot provide any guardrails to ensure everything will work


stable-2.2: site.yml uninstalls ceph packages on Ubuntu Xenial after upgrade

Original situation: Ubuntu Xenial, Jewel installed from distro (xenial-updates, running 10.2.9).
Ran takeover-existing-cluster.yml and then site.yml. All fine. At that time, used the following group_vars/all.yml in a test cluster:
---
generate_fsid: false
fsid: 6e1b075a-7436-4e3e-bc6f-4b1c3bf13cf4
ceph_origin: distro
ceph_stable_release: jewel
monitor_interface: ens3
public_network: <IP_ADDRESS>/24
radosgw_civetweb_port: 7480
ceph_conf_overrides:
  global:
    osd_pool_default_size: 2
    osd_pool_default_min_size: 1
    mon_pg_warn_max_per_osd: 4096

Then, changed to:
generate_fsid: false
fsid: 6e1b075a-7436-4e3e-bc6f-4b1c3bf13cf4
ceph_origin: upstream
ceph_stable_release: luminous
monitor_interface: ens3
public_network: <IP_ADDRESS>/24
radosgw_civetweb_port: 7480
ceph_conf_overrides:
  global:
    osd_pool_default_size: 2
    osd_pool_default_min_size: 1
    mon_pg_warn_max_per_osd: 4096

Ran rolling-update.yml, and then site.yml again. I end up with:
TASK [ceph-mon : start the monitor service] ***************************************************************************
fatal: [daisy]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service ceph-mon@dai
sy: host"}

fatal: [frank]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service ceph-mon@fra
nk: host"}

fatal: [eric]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service ceph-mon@eric
: host"}

        to retry, use: --limit @/home/training/ceph-ansible/site.retry

PLAY RECAP ************************************************************************************************************
daisy                      : ok=49   changed=5    unreachable=0    failed=1

deploy                     : ok=2    changed=0    unreachable=0    failed=0
eric                       : ok=47   changed=5    unreachable=0    failed=1

frank                      : ok=47   changed=5    unreachable=0    failed=1

And sure enough, if I shell into those boxes, I see that the ceph package has been uninstalled. What gives?

By the way:
#!/bin/bash
ansible -m apt -a 'name=ceph state=installed' -s all
ansible-playbook site.yml

Breaks exactly in the same way. So basically, running site.yml can be expected to break a Xenial cluster in that configuration (which doesn't look like it's much out of the ordinary).

@leseb since in #1751 you say that people should always use stable branches, can you please address this issue?

@fghaas the error seems to in site.yml so I assume rolling_update.yml ran well, right? It's strange because rolling_update.yml runs the same role as site.yml so if one succeeds then the other one should.

I had run rolling_update.yml several days earlier, from either master or an earlier checkout, I don't remember for certain. It's been over three weeks.

Closed due to inactivity, feel free to re-open if needed. Thanks!


Enable using compact conn format with all analysis functions

currently just available for plotConn

make all analysis funcs more generic: if no arguments passed, then use internal data structs (sim.net, sim.simData), but allow to pass these as arguments (list of cells, pops, and simData)


This will cause some problems for the containers which are not killed in 10s. One
problem is that it will cause an error when remove  these containers on daemon next
start.The reason is that the container rootfs is still mounted. The containers' rootfs supposed
to be unmounted when the container is killed.
Steps to reproduce(storage driver: overlay):
Step 1. Run a container docker run -ti --name test busybox
[l00284783@localhost docker]$ docker run -ti --name test busybox
/ #

Step 2. Shutdown the docker daemon
^CINFO[0127] Received signal 'interrupt', starting shutdown of docker...
DEBU[0127] starting clean shutdown of all containers...
DEBU[0127] stopping aeb7a17120cd72e045d30e727b36a56b71663f700a69212c08b9060c8964b992
DEBU[0127] Sending 15 to aeb7a17120cd72e045d30e727b36a56b71663f700a69212c08b9060c8964b992
INFO[0127] -job serveapi(unix:///var/run/docker.sock) OK
Step 3. restart the docker daemon
Step 4. Remove  the container test  which is the container run on step 1
[l00284783@localhost docker]$ docker rm test
Error response from daemon: Cannot destroy container test: Driver overlay failed to remove root filesystem aeb7a17120cd72e045d30e727b36a56b71663f700a69212c08b9060c8964b992: readdirent: no such file or directory
FATA[0000] Error: failed to remove one or more containers
I have test with storage overlay and  devicemapper, have the same problem. devicemapper
will show device busy
What cause this is that container test isn't killed in 10s, but the docker daemon timeout and
killed, so the cleanup of the container is not done and leave the container with its rootfs still mounted.
My fixed is use container.stop(10) instead of c.KillSig(15),
container.stop(10) will send SIGTERM to container and wait 10s,
if the container failed to exit within 10s of SIGTERM, then send SIGKILL.
And change the daemon shutdown timeout from 10s to 15s
WDYT? ping @cpuguy83  @estesp  @LK4D4  @jfrazelle

can we have a daemon restart integration-cli test for this

also thanks for hunting this down, I'm sure it was not the easiest thing to debug

ping @jfrazelle  @cpuguy83   add a test, can we run the test with --storage-driver=overlay or devicemapper on Jenkins? The default graphdriver  vfs will not trigger the problem

Ah I see well we do this on all master builds for all the graph drivers so
it's ok if it succeeds on vfs without the patch I'll test personally to
make sure it works w overlay before merging :)
But if we have a test then the overlay master build will fail on Jenkins if
we ever have a regression
On Wednesday, April 15, 2015, Lei Jitang<EMAIL_ADDRESS>wrote:

ping @jfrazelle https://github.com/jfrazelle @cpuguy83
https://github.com/cpuguy83 add a test, can we run the test with --storage-driver=overlay
or devicemapper on Jenkins? The default graphdriver vfs will not trigger
the problem
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12400#issuecomment-93620048.

Ping @crosbymichael @lk4d4 this is what I was thinking was related to your
state on shutdown pr
On Wednesday, April 15, 2015, Jessica Frazelle<EMAIL_ADDRESS>wrote:

Ah I see well we do this on all master builds for all the graph drivers so
it's ok if it succeeds on vfs without the patch I'll test personally to
make sure it works w overlay before merging :)
But if we have a test then the overlay master build will fail on Jenkins
if we ever have a regression
On Wednesday, April 15, 2015, Lei Jitang<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

ping @jfrazelle https://github.com/jfrazelle @cpuguy83
https://github.com/cpuguy83 add a test, can we run the test with --storage-driver=overlay
or devicemapper on Jenkins? The default graphdriver vfs will not trigger
the problem
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12400#issuecomment-93620048.

Can you PTAL at #12423 and see if it solves this for you
On Wednesday, April 15, 2015, Jessica Frazelle<EMAIL_ADDRESS>wrote:

Ping @crosbymichael @lk4d4 this is what I was thinking was related to
your state on shutdown pr
On Wednesday, April 15, 2015, Jessica Frazelle<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','jess@docker.com');>> wrote:

Ah I see well we do this on all master builds for all the graph drivers
so it's ok if it succeeds on vfs without the patch I'll test personally to
make sure it works w overlay before merging :)
But if we have a test then the overlay master build will fail on Jenkins
if we ever have a regression
On Wednesday, April 15, 2015, Lei Jitang<EMAIL_ADDRESS>wrote:

ping @jfrazelle https://github.com/jfrazelle @cpuguy83
https://github.com/cpuguy83 add a test, can we run the test with --storage-driver=overlay
or devicemapper on Jenkins? The default graphdriver vfs will not
trigger the problem
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12400#issuecomment-93620048.

@jfrazelle I have tested,  #12423  can't solve this, it solve a different problem

This one is to ensure the container is cleanuped (unmount the rootfs of the container) on docker daemon shutdown.

ping @jfrazelle  @cpuguy83

In some other refactoring here @estesp and I felt like we should bump this engine wait to something significantly higher.
Reason being is that it may take longer than 10s (or even 15s) to clean up the containers.
If it is taking too long than the user can send 2 more TERMs (or INTs) to the daemon to forcibly stop it, or they can just wait for the timeout.
So if we set the timeout really high it shouldn't really hurt anything.
I believe the reason we are only ever sending TERM to the containers on shutdown is to make sure we aren't just killing them... but I suppose these need to be handled at some point anyway.

@cpuguy83

Reason being is that it may take longer than 10s (or even 15s) to clean up the containers.
If it is taking too long than the user can send 2 more TERMs (or INTs) to the daemon to forcibly stop it,

My fix is to  use c.Stop(10); to stop the container , it will send the SIGTERM to container and wait 10 seconds, if the container failed to exit in 10 seconds then send SIGINT to container.

So if we set the timeout really high it shouldn't really hurt anything.
I believe the reason we are only ever sending TERM to the containers on shutdown is to make sure we aren't just killing them... but I suppose these need to be handled at some point anyway.

But just set the timeout really high may not work for some container in interactive(with -it)  mode . I have test local, I set the timeout to 60 seconds and start a container with -ti,  docker run -ti busybox , then I shutdown the daemon, but the container can't stop in 60 seconds. So I think send SIGTERM to container and wait for seconds and if not exited, then send SIGKILL to container is a much more reasonable way.

ping @jfrazelle  @cpuguy83 @lk4d4 WDYT?

I think this is a dup of #11988, which was closed yesterday because we don't want to SIGKILL containers on daemon exit.

Hmm, but it will wait for 10 seconds.

Design seems legit for me, it is basically the same, but more understandable and secure.
ping @docker/core-maintainers

@LK4D4 what about comments of @unclejack and others from the other PR (for example: https://github.com/docker/docker/pull/11988#issuecomment-90721909) that in some cases it is potentially very bad to SIGKILL, even after waiting and finding the container unresponsive?  However, it seems like the problem of "un-cleaned up" container rootFS's needs to be fixed--this PR seems to fix it cleanly, but still leaves open the window of opportunity for a container with a long-shutdown cycle (closing a ton of connections, performing a significantly large store-to-disk operation, etc.) to be unceremoniously killed in the middle of what would be a reasonable shutdown if the timeout didn't exist.  As @cpuguy83 we thought about making the timeout much larger to accommodate, but even that is hacky in the case that it is unpredictable how much time is required.

by the way..with engine gone, this PR needs a rebase to not use engine.

@estesp I'm not sure what will be with that processes without parent. I think they probably will just die. I'll try tomorrow.

I tried and process live until next daemon start - then they anyway will be killed.

@coolljt0725 Is this something you'll be rebasing? If not, I'll tackle it. Motivated to see this merged since we're having issues with container processes hanging around after Docker daemon restarts on hundreds of machines.
Another thing that needs to be addressed here is adding kill timeout 20 or something similar to the Upstart conf. Otherwise Upstart will kill Docker after 5 seconds regardless of what else is going on. Not sure if something similar is necessary for systemd, etc.

@LK4D4 One instance in which the processes will survive even the next daemon start is if you upgrade the daemon. So upgrading from one version of Docker to another will leave these processes around. It can lead to really gnarly situations like #12239.

I think it makes no sense to have such processes around.
ping @docker/core-maintainers

Seems reasonable to me LGTM

If we move to code review I can carry

@coolljt0725 Would you mind to rebase? Also timeout was increased to 15 already in master.

If we move to code review I can carry

If we move to code review I can carry

If we move to code review I'll carry

@LK4D4  Just wake up, I'll rebase right now

You can have coffee first :D
On Monday, May 18, 2015, Lei Jitang<EMAIL_ADDRESS>wrote:

@LK4D4 https://github.com/LK4D4 Just wake up, I'll rebase right now
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12400#issuecomment-103282897.

@jfrazelle  rebased, please trigger a storage-driver=overlay test  :)

Just wanted to point out again that this is not going to be effective on machines that are running Docker via Upstart. Running containers can/will still be left behind after Upstart reaches its default 5-second kill timeout.
@LK4D4 et al., would it makes sense for the Upstart kill timeout fix to be part of this PR, or should I open a separate one?

@rohansingh I think separate will be easier.

LGTM

update as @LK4D4 's suggestion

Also I believe this closes #7086

Also needs another rebase. :(

@rohansingh @LK4D4 I opened a PR here for increasing upstart kill timeout: https://github.com/docker/docker/pull/13359

@cpuguy83 rebased

TestLogsFollowGoroutinesWithStdout failed on windows jenkins, I think it's unrelated

@coolljt0725 I added this to the 1.7 milestone, could you rebase the PR (again .. )?

ping @LK4D4 @jfrazelle @thaJeztah    rebased

ping @cpuguy83  @LK4D4  @jfrazelle  @thaJeztah  any new about this?

Still LGTM

LGTM. Merging :metal:

cherry-picked


online resources for remote teaching

https://rstudio.com/resources/webinars/teaching-r-online-with-rstudio-cloud/

https://rstudio.com/resources/webinars/teaching-online-at-short-notice/


ItemCombinator removes the wrong Blank Skillbook

Both tiers of blank skillbooks have the same ItemTemplate. This means that Osi.GetItemForItemTemplateInInventory() often fetches the wrong tier.

Does not exist anymore

Does not exist anymore


Bump etcdadm-controller to version 1.0.23

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.20

/cherry-pick release-0.19


experiment: merge and revive do async block proposal

Revives #2245 from 2 years ago, addressing #1482.
Note this is just an experiment, to see if we can integrate with the interim changes to yield on completed as well as incompleted futures. The answer seems yes, but we still make awaits have fuzzy commit points.
Do-async block
The do-async block, do async <block>, returns a future containing the result of <block>.
Unlike an async expression, do async <block> evaluates <block> synchronously at first,  switching to asynchronous computation only at the first await of a pending future within <block>.
The expression do async <block> has type async T provided

<block> has type T;
the expression occurs in an asynchronous context (i.e. in the body of a (non-query) shared function, asynchronous function, async expression or another do async block).

Do-async blocks can be nested, with the exit of a return or throw determined by lexical scoping.
It is a compile-time error for <block> to contain a break to a label declared outside the do-async block.
The expression do async <block> evaluates by entering the evaluation of <block>, executing synchronously  --  just like a do <block> --
until the first await of a pending future, if any.
Unless evaluation traps, it returns a future holding the actual or eventual result of <block>.
During the synchronous execution of <block>:

a return expression exits the block with a completed future, storing the returned value;
a throw expression resumes execution from the nearest enclosing try ... catch ... handler within <block> or, if there is none, exits the do-async block
with a failed future storing the error;
a trap causes do async <block> to trap;
an await expression of
** a successfully completed future continues execution with the contents of that future, or
** a failed, completed future propagates the error contents of the future as if thrown (see above), or
** a pending future exits the do-async block with a new, pending future whose completion with the result of <block> is suspended, waiting on the result of the awaited future.

:::note
Evaluation of a do-async block is synchronous while possible, switching to asynchronous when necessary.
By contrast, evaluation of the similar async <block-or-exp> (without do) immediately returns a pending future and always computes the result of <block-or-exp> asynchronously,
never blocking evaluation of the enclosing expression.
:::
:::note
Do-async blocks are useful for abstracting asynchronous code into re-useable functions, without introducing redundant and expensive async expressions just to satisfy the type checker.
:::
A better way (perhaps)
A better solution,avoing fuzzy commits and allowing better abstraction, might be to introduce a separate type:
type ++= await t (no restrictions on t)

and operations
<exp> ++=
| do await <exp>    (intro)
| await in <exp>    (elim)

Typing:
e : t
-------------------------
do await e : await t

e : await t
-------------
await in e : t

Hence do await e just introduces a thunk and await in e forces the thunk, making explicit that it may await.

Just doing some repo cleanup for better focussing on active work:
Closing PR as it seems inactive for a longer time. Please re-open if it is still relevant and after it has been updated with latest master changes.


[BUG] System.AggregateException: One or more errors occurred. (The given key 'content-platform-dictionaries.zip' was not present in the dictionary.)  [Inner Exception] System.Collections.Generic.KeyNotFoundException: The given key 'content-platform-dictionaries.zip' was not present in the dictionary.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.657654
What problem did you encounter?
kujyhtgrtyujki,lo.;lk,jheretgyhujiop0-[pu67yt54r3e4r5t6y7u89p-0[p98u67y5t4r3e2w1
Bloxstrap Log
N/Ahjukil,

TGYHJDOTG ,JTFIEITFYHI5RJOTG5ROTIYH5RJOGIYHJOI5RJOIRTUJOYHI5RGJTJUYHOTIRJUIOY9THUO5REFIOHRTURH9IO5RETUIO5RE6YHRUJYHIO6RTUY9HTJIOYRHUIOY9RTUIOYHRUT9YB5U9ORTRUYBRTUIOYU5V4RU0EBRJUIYORTGODRJUOYDRJUOIYNUBJORTORETOIRUJTYKOIRTYUREOITIY


Improve variable naming.

Nice Action!
In my opinion, variables like prbody, prurl and PRNUM would be more readable if they had underscores (_) or hyphens (-) to separate them.
prurl ➡ pr-url (underscore didn't look good to me here)
prbody ➡ pr-body (underscore didn't look good to me here)
PRNUM ➡ PR_NUM (hyphen didn't look good to me here)
Cc: @tusharnankani

Hi @HarshKapadia2 @tusharnankani 👋
Thanks for the suggestions! Would you like to submit a PR for any of this? I would be obliged for the purpose 😄

Sure @HarshCasper, I wouldn't mind submitting a PR. I'll do it on the 17th if that's okay with you, as I have end semester exams going on. Sorry!

Sure @HarshCasper, I wouldn't mind submitting a PR. I'll do it on the 17th if that's okay with you, as I have end semester exams going on. Sorry!

Please take your time! Best of luck with your exams :)

Hey @HarshCasper I was working on this issue, but I had a doubt. Where are the following environment variables being set?
https://github.com/HarshCasper/validate-issues-over-pull-requests/blob/1b3d410fa925a35f2919eeab26b125ab36b51994/main.py#L15-L16
I'm asking because I want to rename them to INPUT_PR_BODY and INPUT_PR_URL, but wasn't sure where they're being set. It might cause errors if I rename them without knowing how they're set. I couldn't find anything in the docs. Maybe I missed it.

Hi @HarshKapadia2 — Apologies for the late response.
Here are the references:
https://github.com/HarshCasper/validate-issues-over-pull-requests/blob/1b3d410fa925a35f2919eeab26b125ab36b51994/action.yml#L8
https://github.com/HarshCasper/validate-issues-over-pull-requests/blob/1b3d410fa925a35f2919eeab26b125ab36b51994/main.py#L15
I hope it makes sense now. Please let me know if you have any further questions and I will respond over quickly (subscribed to this conversation).

Any news on this? @HarshKapadia2


Incorrect requirments.txt File

Hi, the corrected readme should read: pip3 install -r requirements.txt instead of pip3 install -r requirement.txt to be consistent with the code. I have below questions:
The version: balls==0.0.115 does not exist and I think should be corrected as balls==0.0.1 ?
Why authors are installing two versions? ipython==8.12.3, ipython==8.13.2?
I cannot find nori2==1.12.1 on the official pip search. Is it nori1?

Why authors are installing two versions of opencv_python==<IP_ADDRESS>4, opencv_python==<IP_ADDRESS>? I think the second one is correct?
Also refile==8.0.0.post1 version does not exist?

AttributeError: module 'refile' has no attribute 'smart_open', How did you fix the error?

Hello, have you solved it yet? I have the same problem, can you help me to solve it? Thank you very much

@aviralchharia  nori, refile and balls are private packages, they are used to build a quicker dataloader.  I replace them with common torch dataloader before release the code but some code was not completely removed.
to fix this, you can replace "xxx.smart_open" with "open", or pull the latest commit.


impl(otel): copy resource attributes

Part of the work for #11775
Add resource attributes as span attributes. We do this because the google::devtools::trace::v2::Span proto does not have a concept of resources.
The work is annoying because the types are different:

Span's AttributeValue
Resource's OwnedAttributeValue

This change is

I am just gonna close this. It was probably dumb for me to try to reuse the span attribute logic by mapping the resource attributes to them.
What I can do instead is map both the span attribute variant and the resource attribute variant to a proto variant: https://github.com/dbolduc/google-cloud-cpp/blob/ef28275b17acc9d94003be38f58fa470ba3b0cc7/google/cloud/opentelemetry/internal/recordable.cc#L77-L132
I'll just convert vector<T>, span<T> to strings so we can stop dropping these attributes.


Added a new property to allow the menu to close on navigation clicks …

This allows the behaviour that the menu had before pull request #56 was merged in.

Thank you!


chore(htmlhint) feature/add commitizen package, husky and prettier

Fixes: #255 & #258

[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:
Add precommit hooks to ensure the uniformity of commit messages and prettier to format the code automatically.
Proposed changes:

Add commitizen and commitlint the same format for commits messages
Add husky to facilitate the creation of hooks
Add prettier to format the code automatically

Codecov Report

Merging #287 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop   #287   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files            1      1
  Lines            1      1
======================================
  Hits             1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51803f...b65b168. Read the comment docs.


No context about the project

Currently, the project is very limited and saves me one copy-paste, not very useful. I expected when this would come out it would be able to see API of the whole project and help me with more complex questions.
Imagine having 2 files A and B. A inherits B.
Question to Chat:
How to do X that uses a method from B
Answer
I'm sorry, but as an AI language model, I don't have access to your project files or any other information outside of the context you provide. Can you please check your project directory to see if there are any other files present?
Describe the feature you'd like.
I expected to have a full vector database underneath to support more advanced queries that we currently cannot do with a normal copilot. Or manual prompting
Example:

Please find a wrapper for X
Please write a method that uses class B
Implement interface that does X

and so on...

It would definitely be useful to at least have a way to provide context from multiple files instead of only one at a time.

Yeah, that one would be game changer, provide Embeddings/Memory capability so it has awareness of whole project or use internally the GPT-4-32K model passing all the files related to the current one (required/usings/imports)...

Duplicate of #32


Support multi-line component anchors

Use margin-bottom instead of height.

Closing as this is obsolete now.


feat: bump terraform provider version and add resources

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Codecov Report
Attention: Patch coverage is 0% with 3509 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3e32178). Learn more about missing BASE report.

Files
Patch %
Lines

apis/ipam/v1alpha1/zz_generated.deepcopy.go
0.00%
489 Missing :warning:

apis/cockpit/v1alpha1/zz_generated.deepcopy.go
0.00%
416 Missing :warning:

apis/block/v1alpha1/zz_generated.deepcopy.go
0.00%
368 Missing :warning:

apis/jobs/v1alpha1/zz_generated.deepcopy.go
0.00%
294 Missing :warning:

apis/iam/v1alpha1/zz_generated.deepcopy.go
0.00%
140 Missing :warning:

apis/sdb/v1alpha1/zz_generated.deepcopy.go
0.00%
136 Missing :warning:

apis/rdb/v1alpha1/zz_generated.deepcopy.go
0.00%
105 Missing :warning:

apis/ipam/v1alpha1/zz_generated.resolvers.go
0.00%
68 Missing :warning:

apis/block/v1alpha1/zz_generated.resolvers.go
0.00%
66 Missing :warning:

apis/cockpit/v1alpha1/zz_generated.resolvers.go
0.00%
66 Missing :warning:

... and 56 more

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #82   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?     354
  Lines           ?   34009
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?   34009
  Partials        ?       0

Flag
Coverage Δ

unittests
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create E2E tests for api page

Fixes #14782
This PR adds E2E tests for the api page.

we should be using the new .testHeader() and .testFooter() methods available in BasePage instead of repeating the logic for header / footer in these e2e tests.
We also have logic for .testSidenav(): https://github.com/CDCgov/prime-reportstream/blob/master/frontend-react/e2e/pages/BasePage.ts#L150-L159

fixed


Pasting anything into that has more than one line breaks it

im using anaconda prompt and whenever i try to paste in code or relevant text it takes each line and runs it one after the other and totally breaks it. im a beginner so im sorry if this is a simple fix but it is an issue im dealing with at the moment

Type // to enter multiline mode.


Feature Request: WAF functionality leveraging OWASP CRS, implemented and enabled by default

Creating this feature request was recommended by @drcaramelsyrup at
https://github.com/cloudflare/pingora/issues/31#issuecomment-2000798482
OWASP CRS currently runs on the following WAF engines:

OWASP ModSecurity v2
OWASP ModSecurity v3
OWASP Coraza

Commercial integrations are done via custom implementations of the rule language. This includes the Cloudflare setup.
If a new open source Reverse Proxy is created, then giving it WAF functionality based on the de facto standard rule set from the beginning would be useful.

I think WAF type functionality will be a great use of the wasm extensibility planned for River: Rule sets could be compiled into wasm to reject requests.

This should basically alter the proposed design. Adding a new Filters between Listeners and Connectors should do the trick. Then a WAF is just another filter in the chain.

Thank you @jamesmunns. I do not really have spare time to contribute here in my volunteer time capacity, but if you have any questions about CRS or especially input on how to provide a successful integration, then please get in touch.

Will do, thanks!

Got it now, I see that it is totally under that stage. Awesome. Ping me if you need anything.