TypeError: init() got an unexpected keyword argument 'n_estimators'

When trying to set arguments like n_estimators for MERF, MERF.fit returns the above initialisation error. It works fine with default setting.
This seems to suggest that MERF to sklearn random forest API is broken. Is this a version issue?
I'm using:
Python 3.9.5
scikit-learn==0.24.2

I tried using
Python 3.6.13
scikit-learn==0.22.2.post1
The error is still there using your notebook examples:
`---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
 in
----> 1 mrf = MERF(n_estimators=300, max_iterations=100)
2 mrf.fit(X_train, Z_train, clusters_train, y_train)
TypeError: init() got an unexpected keyword argument 'n_estimators'`

You have to supply the regressor, not just its parameters.
MERF(fixed_effects_model=RandomForestRegressor(n_estimators=300, max_iterations=100, n_jobs=-1))

Just figured that out. The notebook examples are a little misleading. Thanks.


WWW / UI does not work

WWW/UI does not open on port 8001.
Any there any options need to be enabled on API Server?

@rimusz I'm able to get it working with the following command: hack/local-up-cluster.sh then visiting http://<IP_ADDRESS>:8080/static/app/#/dashboard/ in my web browser. I just tried it again as of commit a442918d314f4ab3de98a45512d2ef60e7939f94
What seems to be the issue that you're facing?

I use CoreOS+Kubernetes, let me check via that link

@preillyme cool, that works.
I think the www doc should be more clear how to use it.

@rimusz yeah I completely agree. I'm working to make the documentation cleaner. Thanks for reporting your issue.

@preillyme no worries. I will update my App https://github.com/rimusz/coreos-osx-gui-kubernetes-cluster with the new UI link, will stop using docker container for UI.

so we can close this one I think

@rimusz Okay sounds good.

@preillyme : Do you have a separate issue for updating the documentation or do you want to use this one?

will stop using docker container for UI

To be honest, when working on CoreOS (but any environment for that matter), it makes a lot of sense to have the UI running inside the container.
I've got all components of Kubernetes running inside containers right now, but the UI part is still missing. I see there are some pre-built non-google images in the Docker Hub, but it'd be great if there was some official documentation on how to run the UI inside a container.

@JeanMertz as @preillyme mentioned above Kubernetes UI is part of API service and can very easily accesses via http://api_server_ip:8080/static/app/#/dashboard/.
Running Kubernetes for production you should not put it's components/binaries to Docker containers as binaries are standalone compiled go programs. Plus such setup brings more constrains to your setup as if your Docker daemon dies then even Kubernetes is dead.

Updates to the documentation are being tracked in https://github.com/GoogleCloudPlatform/kubernetes/issues/7122 and the changes are in PR https://github.com/GoogleCloudPlatform/kubernetes/pull/9330. This issue can be closed.


Using "source" method on mobile/tablet isn't working

[x] Issue does not already exist
[ ] Issue observed on https://plyr.io

Expected behaviour
The video should load without errors
Actual behaviour
The following error is shown in the console:
Uncaught TypeError: Cannot read property 'play' of undefined
at _setTitle (plyr.js:1389)
Environment

Browser: Safari/Chrome/...
Version:
Operating System: Iphone/Ipad/...
Version:

Players affected:

[x] HTML5 Video
[] HTML5 Audio
[x] YouTube
[x] Vimeo

Steps to reproduce

Try to load a video using the "source" method in a mobile environment

Relevant links

Also seeing this.
For continuous playback on mobile, you generally need to somehow click/tap the player before it is allowed to play. When you change the source, if plyr replaces the player instance and not just update it, I think the error will come.

I got this issue too. On desktop all working fine. However on mobile after change source, Youtube doesn't work!

Does this still happen in v3?
The source method doesn't exist any more. It's a setter now. Also think the second comment regarding autoplay is a red herring, since it wouldn't trigger a TypeError.


TLS SNI support

I don't think that currently SNI is supported.

See how mitmproxy supports this complication here

I've read the wiki about SNI, but can not fully understand it.
In AnyProxy, certificates are signed with hostname, not ip address. So there shouldn't be any problem with virtual hosts.

Please see the list of complications mitmproxy talks about here: https://github.com/mitmproxy/mitmproxy/blob/master/doc-src/howmitmproxy.html#L125
They are hopefully documented a little better than the wiki page and can help clarify the different scenarios rather than me restating it :-)

按理说支持了 SNI 你现在的模式就不用监听那么多端口了。 其实还有更好的解决方案 XD （我已经在 0.11.x 的 Node 上实现了更好方案，还没有去支持 0.10.x，不过代码在内网 ）。

@dweinstein
Perhaps I've found out why SNI is not necessary our proxy server.
For regular https servers,  users send requests DIRECTLY to it. So a server should identify the hostname  during TLS handshaking(OSI layer 5) and deliver a corresponding certificate. This is why SNI should be invoked on virtual hosts.
When it comes to proxy server, something changed. If a user wants to connect an https server via proxy, the browser will send an http(not https) request with CONNECT method first. During this process, the proxy server could learn the target host name and then establish a socket tunnel to target server. Now you can see, since we have got the hostname on OSI layer 7, SNI is no longer needed.
Please note that we are talking about regular proxy server, not reverse proxy for load balance on server side.

@dweinstein
The previous comment explains why SNI is not needed in the user-side interface of proxy.
After thinking it again, maybe it is still necessary for the back-side. When the target server is deployed on a virtual host, we have to implement SNI on proxy side correspondingly.
The solution may have to do with something about nodejs api. I'll try to find out and publish a new version if needed.
Thanks !

@guangwong 如上文所述，SNI应该是Proxy向server发送信息时需要支持的特性。至于用户这边的方案，多开几个端口也没什么问题，哈哈。

@ottomao 是呀，单机自己用这样也是没有关系的。 我在做淘宝这边的一个集中代理工具，是集中式的需要多考虑这些的（最伤心的还有证书安全。。 ）。

@guangwong 不知道有没有给你回复过，AnyProxy现在已经支持SNI了，不用再开这么多端口。

@ottomao 好的~  我这才知道

嗨，大家好。
是否有任何教程如何运行anyproxy SNI支持（和TLS），如果可能的话？
也将是非常容易的，如果它可以透明地运行。
而且我一定在客户端浏览器包括证书或工作的透明？
很多问候

@Degreane
Did you use online translation service to get these Chinese words ? It's hard to understand. :(

Yes sorry ;)
anyhow was asking if there are any tutorials on how to run anyproxy SNI support (and TLS), if possible?
It will also be very useful if it can run transparently without adding manually the certificate to client browsers. or to find a way to push it to the client browser.
much regards

AnyProxy is now support SNI, close the issue.


externally-managed-environment error on building docker image in the latest gdal docker image

After ghcr.io/osgeo/gdal:ubuntu-small-3.8.5 docker image, there is the below build issue in Dockerfile
12.55 error: externally-managed-environment
12.55
12.55 × This environment is externally managed
12.55 ╰─> To install Python packages system-wide, try apt install
12.55     python3-xyz, where xyz is the package you are trying to
12.55     install.
12.55
12.55     If you wish to install a non-Debian-packaged Python package,
12.55     create a virtual environment using python3 -m venv path/to/venv.
12.55     Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
12.55     sure you have python3-full installed.
12.55
12.55     If you wish to install a non-Debian packaged Python application,
12.55     it may be easiest to use pipx install xyz, which will manage a
12.55     virtual environment for you. Make sure you have pipx installed.
12.55
12.55     See /usr/share/doc/python3.12/README.venv for more information.
12.55
12.55 note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
12.55 hint: See PEP 668 for the detailed specification.
------
failed to solve: process "/bin/sh -c apt-get update   && apt-get install -y --no-install-recommends   libffi-dev python3-pip   && rm -rf /var/lib/apt/lists/*   && pip3 install --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1

An example of using pipenv to follow
https://github.com/UNDP-Data/geo-cogserver/blob/main/Dockerfile


Add dispatcher.once

It could be helpful to have .once in order to attach an event that will fire just once.

Something like this:
Barba.Dispatcher.once = function (e, f) {
  let self = this;

  function newf() {
    self.off(e, newf);
    f();
  };

  this.on(e, newf);
};


Common apps for different member states to have one registration with Google/Apple

If its possible we would like to have common wallet/verifier apps for different member states to have one registration with Google/Apple. Usually it takes a lot of time to register app and it might be easier to have one app with localisation for different countries/languages.

@arturnovek I believe this issue is no longer current and will close it. If this is still an open question, please bring it directly to the next member state pilot call, as this is an issue that cannot be decided/solved by T-Systems. Thank you!


Its not working any solution

TypeError: Cannot read properties of null (reading '0')
at worker.js:10:60
at async hlsUrl (worker.js:8:10)
at async handleRequest

It's working great now


Added ZeRO functionality, documentation, TypeHints

Expanded PyTorch patching, added documentation and TypeHints. Integrates ZeRO.
Known issues: Datasets have to be even on all workers for training to succeed.

Added multiple notebooks, tensorboard functionality and addressed several small things.


Hey @Megabyte918 !

Hey @Megabyte918 !
Hahaha this is somewhat inconvenient for you! eur-lex.europa.eu eur-lex.europa.eu
But I would say a configuration with playerspeed or something, I remember he said it to me recently, but I can not find the notepad in which I save it :(
Please! :)
THANK YOU FOR BEING SO HAPPY TO US <3

@Jhair2015 There already is a config for playerspeed, see here.

@Megabyte918 I mean that to make double fracture perfect or more or less good, I remember that you wrote me playerspeed: 1.2, something like that, sorry for the inconvenience! :(

@Jhair2015 It doesn't have to be a solid "1" or "2" it could be anything in between like 1.1, 1.2, 1.3, etc. You can have any speed that you want it doesn't have to be a whole number. And what do you mean by "double fracture?" Also, don't be sorry. I like answering people's questions =D


The bounding box of a grid lags behind by one update

Try adding and removing tiles from it, its bounding box will be what it should have been before the latest change.
If you have a 1x2 tile grid and you remove one of them, the bounding box will still be 1x2. Same happens if you add a tile, or add multiple at the same time.

So that's what causes that particular mapping annoyance.
this can cause some really big disparities if a lot of tiles are bulk-filled in at once.

Still an issue.

@metalgearsloth with grids recently getting some love, is this still a thing?

Don't think so


Routes with params not working with bankai start

When looking at #273, I also noticed that params do not work with bankai start:
Example:
app.route('/asd/:foo', require('./views/main'))

GET /asd/123
# No route found for /asd/123
``

Hmmm, there's 2 constraints here:

We can't server render wildcard routes in bankai build because they don't resolve to a specific path, which means that they'd be super weird files on disk — and would require all sorts of workarounds to get to render right on the server (e.g. choo apps can no longer assume state.params to exist, etc. etc.)
We should resolve routes in bankai start, so they can be loaded with the right data and server rendered.

I feel that using JIT server rendering might be a solution for this. If we expect bankai/http to run in production behind a CDN, it might be good to make use of a (persistent) LRU cache for the files, but compile the files as they come in. Also make sure to invalidate the cache when any of the file watchers trigger.
Does this make sense?


Column width cannot change from props if previously changed manually.

Thanks for the awesome library! I experienced this while trying to andjust column widths manually and programmatically.
Describe the bug (required)
Column width cannot change from props if previously changed manually.
Provide an example via Codesandbox! (required)
https://codesandbox.io/s/react-table-simple-table-ple00?file=/index.js
Steps To Reproduce (required)
Steps to reproduce the behavior

Click on"Toggle columns"
Adjust column sizes manually
Click on "Toggle columns again"

Expected behavior (Recommended)
Column width should always change when you click on toggle columns.
Additional context
Column widths don't change after you adjust manually and click "Toggle columns" again.

v6 has been deprecated for a while now. Feel free to fork and fix if you want, but I suggest you upgrade to the latest version of the library.


ETH & ERC-20 token addresses should have upper/lower-case symbols for validity checks

ETH & ERC-20 token addresses support additional validity checks using upper/lower-case letters but the app only has lowercase addresses.
When the address is shared with other software there is no ability to re-check the address for validity and sometimes it produces a warning - MyEtherWallet.com is a one example of such software.
Bitcoin & Litecoin do have mixed-case addresses in the app to support those additional checks.
ETH/token addresses should have them too.

Yeah, in last time I have noticed that checksumed ETH addresses by case becomes more popular. This feature is not critical (many other software just use canonical lowercase format) but nice-to-have due to avoidance of mistakes while rewriting addresses by a hand. We will include it in future releases

I think they are popular because this functionality is useful, so I'd say it's less of a nice-to-have and more of a should-have feature.
In fact some priority tags like: must-have, should-have, nice-to-have or some other naming-system may be a good way to indicate future direction of development and help triage the inflowing issue requests.


[Bug]:

Minimal, reproducible example
Main file ( "Index.js" type ="module")
import puppeteer from "puppeteer";
import { getTheAudio } from "./getTheAudio.mjs";
const browser = await puppeteer.launch({
  headless: false,
});
const page = await browser.newPage();
await page.goto("https://app.ofppt-langues.ma/platform/#/learning-path/mission/DONNER_SES_INFORMATIONS_PERSONNELLES_A1/lesson/FR_FR_A1_GRAMMAR_DEMANDER_ET_DONNER_LA_DATE/activity/FR_FR_A1_GRAMMAR_DEMANDER_ET_DONNER_LA_DATE_EXERCISE_DEMANDER_ET_DONNER_LA_DATE_2/exercise/item/0");

await getTheAudio(page);

The Function: "getTheAudio.mjs"
import fs from "fs";

export async function getTheAudio(page) {
  page.on("response", async (response) => {
    const url = response.url();
    const extension = url.split(".").pop();
    const contentType = response.headers()["content-type"];
    if (extension === "blu" && contentType === "audio/mpeg") {
      try {
        let audioBlu = await response.buffer();
        fs.writeFileSync("./AudioJunk/generatedAudio.mp3", audioBlu);
      } catch (error) {
        console.error("the error is: ", error);
        return false;
      }
    }
  });
}

Error string
no error
Bug behavior

[X] Flaky
[ ] PDF

Background
Bug Report: Inconsistent Detection of Responses in Puppeteer
Description:
The getTheAudio function is designed to catch responses with a specific content type (audio/mpeg) and save them to a file. However, there are instances where the desired response (.blu file) is not detected by Puppeteer's page.on("response") event handler, leading to inconsistent behavior.
Observations:

The issue was investigated using Chrome DevTools' Network tab to monitor network activity.
In some cases, the desired response was not displayed in the Network tab despite being expected.
Exporting a .har file from the Network tab revealed that the response was indeed present, even though it was not detected by Puppeteer or shown in the Chrome DevTools Network tab.

Expectation
I expected that response to get detected everytime.
Reality
I receive a bunch of .blu files as a response but it's always the first file that doesn't get detected , sometimes it does, sometimes it doesn't
Puppeteer configuration file (if used)
No response
Puppeteer version
22.7.0
Node version
20.12.2
Package manager
npm
Package manager version
10.2.4
Operating system
Windows

Please include a test page into the example.

I just added more code for a better understanding of the issue and changed the Reality paragraph, and I didn't include the URL cause it requires a login authentication

Please create a test page that shows the problem. Without it there is no way to debug the issue.

await page.goto("SomeUrl");

await getTheAudio(page);

the way this is written it looks like a race condition since all requests can already fire by the time getTheAudio is called. So without an executable example it is not possible to debug.

Idk what else I should provide cause I'm not that smart :), and the reason I didn't provide more code is gonna dissect you from the issue, so I tried to keep it minimal as much as possible, and for the URL It requires a login, cause it's a school site, I hope that cleared why I couldn't share any more details,  and sorry for the inconvenience

since I'm Stupid I asked chatgpt to generate a test:
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Puppeteer Audio Response Test Page</title>

Puppeteer Audio Response Test Page

    <button id="trigger-response">Trigger Audio Response</button>


Prepare 0.13

Fixes #205
Proposed changes

[x] Add release notes for 0.13 in the form of a blog post.
[x] Fix some typos.
[ ] Bump to 0.13.0.

Codecov Report

Merging #219 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   96.27%   96.27%
=======================================
  Files          24       24
  Lines        1020     1020
  Branches       96       96
=======================================
  Hits          982      982
  Misses         32       32
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6298940...27b8751. Read the comment docs.


Always add parenthesis to bit-wise operations

Is your feature request related to a problem? Please describe.
The bitwise-operation's prioritization is not intuitional in C language. One of the suggested solution is always and parenthesis when mixing normal arithmetic operations and bit-wise operations. But this is not yet the case in Ghidra's decompiler.
Describe the solution you'd like
Always add parenthesis to bit-wise operations
Describe alternatives you've considered
Nope.
Additional context
Add any other context or screenshots about the feature request here.

This should be resolved in #44


⚠ Bofrost.fr has degraded performance

In ee280af, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1353 ms

Resolved: Bofrost.fr performance has improved in 9b9e9c3 after 6 minutes.


feat: add EIP-7702 support

Sharing our work for adding EIP-7702 transaction support to reth / revm / alloy
Current state:

7702 transaction support has been added to reth and alloy
EOA code loading has been added to revm but full 7702 execution has not been tested yet
The teardown of 7702 transactions in revm has not been added yet
Gas calculations have not been updated and are not correct
Compact encoding of added types in reth is currently byte-for-byte
Overall correctness needs to be checked
Not all tests have been added or updated

Incomplete items and points of discussion are marked with TODO(eip7702)
If you have any questions about any of this work let us know
The three related PRs:
https://github.com/paradigmxyz/reth/pull/8895
https://github.com/bluealloy/revm/pull/1541
https://github.com/alloy-rs/alloy/pull/928

Closing this as it is not even half done, and team stated in tg that they do not have resources to continue working on it.
EIP-7702 support will be added in different PR


sys.tables - schema docs missing data_retention_period* columns

I'm not entirely sure what these columns are for, otherwise I would submit a PR. I just came across the discrepancy by happenstance so figured I would submit the issue.
sys.tables columns missing from the docs page:

data_retention_period
data_retention_period_unit
data_retention_period_unit_desc

Appears they were introduced with SQL Server 2022 (along with the ledger columns) as I don't see them on any of my 2019 instances.
https://learn.microsoft.com/en-us/sql/relational-databases/system-catalog-views/sys-tables-transact-sql?view=sql-server-ver16
https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/system-catalog-views/sys-tables-transact-sql.md

Thanks, @chadbaldwin. I'll add these to the documentation, but they're going to say "internal use only" for the time being.

@chadbaldwin The updated article will be published in the next day or so. I tracked down a PM to explain what the columns are for. This issue will close automatically when our internal PR is merged.


With iPython 5.0 this copy-pastes code to iPython but doesn't execute.

I wonder if there's a way to reconfigure ipython_config.py to get this to work?

I haven't had the chance to test with ipython 5 yet, but I'll try to do that next week.
I wonder what has changed. The plugin just simulates an "Enter" keypress in tmux.
Are you running ipython in tmux or screen ?

I'm running it on tmux.

Ok so the problem is that ipython 5 %load puts the cursor at the beginning of the source and you have to scroll all the way to the end to execute. We can't really reliably do that. So instead, I switched to using %run which seems to work fine with both ipython 5 and < 5.
The only downside is that you don't see the code you just executed in ipython's history, but just a line with %run /tmp/foobar. Not sure what we can do about that.
Anyway, can you checkout master and confirm that the bug is solved ?

Confirmed working. Thanks for the quick response!

Great, thanks for the report !
On Jul 19, 2016 5:48 PM, "CameronTStark"<EMAIL_ADDRESS>wrote:

Confirmed working. Thanks for the quick response!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/julienr/vim-cellmode/issues/13#issuecomment-233676373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe66hAfPBFAK5bpj9mlL_p57HghVMyJks5qXPG-gaJpZM4JNpfZ
.

actually, using %run does not work for me. it seems that the environment inside run is different from what you would get with literal inclusion of code. for example, i load matplotlib  and to from pylab import * somewhere in the script and then do e.g. figure(3) to open a new figure. this does not work anymore since i upgraded vim-cellmode today.

maybe this answer could help?
http://stackoverflow.com/questions/34780275/how-do-i-combine-the-pylab-and-run-magic-commands-in-ipython

hmm, i just saw it's already using -i. no idea then.

There is one special usage for which the text above doesn’t apply: if the filename ends with .ipy[nb], the file is run as ipython script, just as if the commands were written on IPython prompt.\

this is from the ipython docs. maybe renaming the temp files to '.ipy' would help?

ok, so i checked by renaming. indeed renaming to the extension '.ipy' solved my problem. '.py' did not. so i would suggest adding '.ipy' to all temporary files.

@nilsbecker It's pretty strange because on my machine, it was working with ipython 4.0.1. Anyway, added the .ipy extension since it seems to work as well. Can you test master ? Thank you for digging into this !

ok, i did PluginUpdate in vundle, restarted vim and indeed it works now -- i can spawn new matplotlib windows. i think it may have had to do with the event loop in some way. the only place where things did not work previously was making new mpl figures. anyway, it's fine now.

@nilsbecker Great, thanks for testing


Tried to alphabetically sort JSON file

I don't know if this is necessary as it is only an idea, but I tried to alphabetically sort the readme, at the end of the file, it is a bit mixed.
I used https://codeshack.io/json-sorter/ .
Thanks.

@Panquesito7 I updated it and put the names at the bottom in the alphabetical spaces. Thanks.

@Panquesito7 I think I should use this tool from now on, as it takes each key to sort: https://aruljohn.com/jsonsort/

@Panquesito7 it's because every time someone has their name merged, this gets out of date.

I should do this at a time, when pr's are not being merged, and if @schmelto  and others approve, this should be merged. And then we should say somewhere in readme to add alphabetically.

@CodingSpecies i found out a way to get this done with GitHub actions but I need some help can you dm me in discord we both can fix this thing together

@Panquesito7 , I am not sure, but it will keep causing conflicts and breaking code, every time a new pr is merged. If this is ok by you all, and is able to be merged, we need to pause merging pr's. The issue with this is, I will have to manually each time go and alphabetically sort everytime, unless, as @qwe123coder said, we could find a github action. thanks.

unless, as @qwe123coder said, we could find a github action

What tool did you use for ordering the JSON file in alphabetical order?

This: https://codeshack.io/json-sorter/
manually paste and get output by choice

unless, as @qwe123coder said, we could find a github action

What tool did you use for ordering the JSON file in alphabetical order?

there is something called jsonabc  its a website and it also provides a js module so we can you it to make a action

What tool did you use for ordering the JSON file in alphabetical order?

there is something called jsonabc its a website and it also provides a js module so we can you it to make a action

Sure. You can share it here, and I'll try to do it soon. Thank you. 🙂

@CodingSpecies i found out a way to get this done with GitHub actions but I need some help can you dm me in discord we both can fix this thing together

so that is why I asked for help to make the GitHub action

What tool did you use for ordering the JSON file in alphabetical order?

there is something called jsonabc its a website and it also provides a js module so we can you it to make a action

Sure. You can share it here, and I'll try to do it soon. Thank you.

i started making one but got stuck so can you and @CodingSpecies  help me ?

What tool did you use for ordering the JSON file in alphabetical order?

there is something called jsonabc its a website and it also provides a js module so we can you it to make a action

Sure. You can share it here, and I'll try to do it soon. Thank you.

i started making one but got stuck so can you and @CodingSpecies help me ?

Sure. You can contact me via Discord if you like. 🙂

@CodingSpecies pls message me or @Panquesito7

Isn't the PR #782 not fixing this?

Is the PR #782 not fixing this?

No idea which one is the best option 😅 @schmelto, thoughts?

Is the PR #782 not fixing this?

No idea which one is the best option 😅 @schmelto, thoughts?

This one is manual while #782 is automated 🤔

Thank you @CodingSpecies - great contribution 👍 but I think we need to automate this so that it is sustainable and scalable.


add support for basic request to ReverseProxy

This pull request adds support to the ReverseProxy for basic requests. The requests are routed using the hashring implementation and the ServerRegistry concept to route requests to different backend servers.
The test is using the generic redistest.TestClient suite, which as we add more and more tests will improve the robustness of the ReverseProxy implementation (it's a bit light for now, but covers the basics).
Please take a look and let me know if something should be changed.

lgtm. we will need to add a retry also if the requests failed :)

Yep, plenty more features to come! Thanks for the review!


Cutting atlases out of mni_atlas_reader

There was some talk here at the hackathon about trying to splice the atlases out of the current repository and make them into their own repository, which could serve as a very useful resource for anyone looking for brain atlases! This question was previously raised on the BIDS Discussion List and some relevant discussion occurred there.
@peerherholz mentioned that Lead DBS has already collected a good number of atlases which might be a good place to start!
What are peoples' thoughts? Should a new repo be created to host atlases (this package could then grab that repo as additional "package data" when downloaded!). If so, what should the name be? @miykael

Awesome idea @rmarkello.
For ALPACA I started something like a summary, containing information on atlas name, type, ROIs/regions & license. You can check it here. Maybe that would be useful? Furthermore, something like that would easily be transferred to a website, eh?

@rmarkello - Yes, I think it should be split from this project.
@PeerHerholz - Oh my god!! That's already perfect.
I think it makes sense to have a new repo where all of this can be combined. Anybody has any idea for such a repo?

Not my idea! All credit to @chrisfilo and @miykael. I love the markdown table, though! That'll be a great launching pad.
I'm deeply terrible at naming, but will happily vote on other suggestions!

At lunch we came up with Corgi - cortical generalized inventory or something lile this.

OMG I love it!
Best,
Chris
On Tue, Aug 7, 2018 at 12:47 PM Michael Notter<EMAIL_ADDRESS>wrote:

At lunch we came up with Corgi - cortical generalized inventory or
something lile this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/miykael/mni_atlas_reader/issues/4#issuecomment-411179007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkpw9QpSwFsjE0v9fHxPi03qtlkc6pks5uOe7NgaJpZM4VytU-
.


Issues proxying locally

Hi,
I'm fairly new to docker and to setting up servers so bear with me.  Basically what I'm trying to solve is I have a decent amount of apps (~10) and I'd like to give them nice urls for my own sanity.  I only access this server from within the local network so I don't really care about opening it up outside of that.  I made a smaller scope set up just to try to get it working the way I want and I can't seem to figure it out.  I'm unsure how I should map the server.  I have tried writing a file to the vhosts.d for both containers.  I'm not sure what I should set the server_name and listens to though, as the server name is the same but only the ports differ.  I think I might be running into conflicts as well because it automatically writes out listen 80 in both entries.
# /opt/docker-compose.yml

---

version: '3.4'
services:
  nginx-proxy:
    image: jwilder/nginx-proxy
    container_name: nginx-proxy
    ports:
      - 80:80
    volumes:
      - /opt/appdata/nginx-proxy/vhost.d:/etc/nginx/vhost.d:ro
      - /var/run/docker.sock:/tmp/docker.sock:ro
  portainer:
    image: portainer/portainer
    container_name: portainer
    restart: unless-stopped
    ports:
      - 9000:9000
    volumes:
      - /opt/appdata/portainer:/data
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      - VIRTUAL_HOST=portainer
  organizr:
    image: lsiocommunity/organizr
    container_name: organizr
    restart: unless-stopped
    ports:
      - 8999:80
    volumes:
      - /opt/appdata/organizr:/config
    environment:
      - VIRTUAL_HOST=organizr

Here is some output from default.conf
server {
        server_name _; # This is just an invalid value which will never trigger on a real hostname.
        listen 80;
        access_log /var/log/nginx/access.log vhost;
        return 503;
}
# portainer
upstream portainer {
                                ## Can be connect with "opt_default" network
                        # portainer
                        server <IP_ADDRESS>:9000;
}
server {
        server_name portainer;
        listen 80 ;
        access_log /var/log/nginx/access.log vhost;
        include /etc/nginx/vhost.d/portainer;
        location / {
                proxy_pass http://portainer;
        }
}
# organizr
upstream organizr {
                                ## Can be connect with "opt_default" network
                        # organizr
                        server <IP_ADDRESS>:80;
}
server {
        server_name organizr;
        listen 80 ;
        access_log /var/log/nginx/access.log vhost;
        include /etc/nginx/vhost.d/organizr;
        location / {
                proxy_pass http://organizr;
        }
}

An example of the include files:
# vhost.d/portainer
server_name <IP_ADDRESS>;
listen 9000;
location /portainer {
  proxy_pass http://portainer;
}

# vhost.d/organizr
server_name <IP_ADDRESS>;
listen 8999;
location /organizr {
  proxy_pass http://organizr;
}

So basically what I have right now for a url is:
<IP_ADDRESS>:8999 and <IP_ADDRESS>:9000

And I want
<IP_ADDRESS>/organizr and <IP_ADDRESS>/portainer

I know that I don't have to map the port if there is only one being exported, but I still have it set up just because I still use this server and still want to access it by port while trying to figure this set up out.  I'm slightly confused about what should I be setting for my server_name in the override files if all the apps live on the same ip address (just a different port).  Any guidance on configuration would be great.
Is what I want not really what this container was meant for?  Is there another container I could use if that is not the case?

@astraldragon Do you have any update on this? Im running into the same issue right now with a very similar config. I have a feeling this might not be working correct with swarm.


IMDB Dataset Experiments

Are the IMDB experiments provided in the codebase? I do not see what  pre-trained sentiment classifier you used to collect additional data.

The IMDB experiments use this sentiment model: "siebert/sentiment-roberta-large-english". You can construct the reward pipeline as:
reward_pipe = pipeline("text-classification", model="siebert/sentiment-roberta-large-english", device=0)
reward_kwargs = {"return_all_scores": True, "batch_size": 16, "truncation": True, "max_length": 512}

@xkianteb I don't expect we'll be able to get the complete code for the IMDb experiments released in the near future, but it's on our TODOs. We'll circle back on this issue when we have an update. Closing now, but feel free to re-open/follow up.

Hi,
any updates for the IMDB experiments? It would be cool to replicate results from the paper.

Upvoting this, super interested in reproducing this particular task/dataset.


Modernize solution

Changes

Bump Phobos.Actor.Common target platform to .NET Standard 2.0
Bump Phobos.Actor.Common.Tests target platform to .NET Framework 4.8.1 and .NET Core 8.0
Use global.json targetting 8.0.1
Update CI/CD to pull .NET SDK based on global.json version

PS D:\git\Petabridge\Phobos.Actor.Common> dotnet list package --vulnerable --include-transitive

The following sources were used:
   https://api.nuget.org/v3/index.json

The given project `Phobos.Actor.Common` has no vulnerable packages given the current sources.
The given project `Phobos.Actor.Common.Tests` has no vulnerable packages given the current sources.


Running validations after authorization

It seems a bit pointless to run validation checks if the authorization denies access to the endpoint.
in this file:
validator/src/Middleware/Validator.js :: handler()

Can u point to the actual line?

From line 203 - 231. Below you can see its executing _runValidations first and then, if successful, it executes _authorize. So even if my form data is valid but I'm not authorized its going to send a bad response.
async handle (ctx, next, validator) {
  validator = validator instanceof Array === true ? validator[0] : validator

  if (!validator) {
    throw new Error('Cannot validate request without a validator. Make sure to call Route.validator(\'validatorPath\')')
  }

  const validatorInstance = resolver.forDir('validators').resolve(validator)

  /**
   * Set request ctx on the validator
   */
  validatorInstance.ctx = ctx

  /**
   * Sanitize request data if there are sanitization rules
   */
  this._sanitizeData(ctx.request, validatorInstance)

  /**
   * Validate the request. This method should handle the request
   * response, since the middleware chain has been stopped.
   *
   * If this method doesn't handles the response, then a generic
   * response is made
   *
   * @type {void}
   */
  const validate = await this._runValidations(ctx.request, validatorInstance)
  if (!validate) {
    this._endResponseIfCan(ctx.response, 'Validation failed. Make sure to handle it inside validator.fails method', 400)
    return
  }

  /**
   * Authorize the request. This method should return true to
   * authorize the request.
   *
   * Make response or throw an exception to reject the request.
   *
   * Returning false from the method will result in a generic
   * error message
   */
  const authorized = await this._authorize(validatorInstance)
  if (!authorized) {
    this._endResponseIfCan(ctx.response, 'Unauthorized request. Make sure to handle it inside validator.authorize method', 401)
    return
  }

  /**
   * All good, so continue
   */
  await next()
}

There's also a if block there, which says right away of unable to validate

If current user posts data that passes validation but is unauthorized to access the endpoint the code will still run all the validation checks first then reject him.

This is how it is structured that validations runs and authorisation is next
If the data submitted by the user is invalid then there is no point finding who they are
Maybe you want different behaviour in that case simply don’t use the authorization method and create your own middleware, that runs before the validator

Closing since not actionable

Hi Virk, this would be a great change, I think that's a better way to check if the user is authorized to perform the action before running validation rules.
I'm very confused because I come from Laravel, and Laravel verify runs the authorize method then run the rules... If you want to follow what they do (as you mostly did), this is the way to do it well 😉


implement challenge leaderboard

utility to add achievement-mailbox-approved to user:
for each user without achievement-mailbox-approved, in reverse order of creation:
play greeting
prompt to approve, replay, delete


signature trait

Description

First task of #52
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (main)
[ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the GitHub PR explorer

Seem like we have converged to the first candidate? @chancharles92 @alxiong

Agree

Okay. now this branch implements our own signature trait, and is ready for review.
FYI: code with arkworks signature trait is stashed here: https://github.com/EspressoSystems/jellyfish/tree/arkwork's-signature-api

LGTM, do we want to add this into tag-release 0.0.1 or should we add it after the tag-release PR?

Perhaps after. There are likely breaking changes after this.


⚠ Secret Website 3 has degraded performance

In c7c8d69, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3087 ms

Resolved: Secret Website 3 performance has improved in a5002eb.


Fix adapter check error message

PR fixes misleading error message. As seen here, config expects adapter to be a string

Thanks!


Post release automated changes for communication releases

Post release automated changes for azure-communication-common

API change check
API changes are not detected in this pull request.


How can I get the video data of CamVid?

Thank you for your great work!
Could you please help with the data pre-processing?
How can I get the video data of Camvid?
I only find some MXF video on the official database page, but the link to the code of pre-processing is broken.
Thanks,
yifan

Thank you for your quick reply.
The SegNet only has the scaled data with 480*360, and only the labeled ones.
What is the source data you use to implement the aug?
I thought there are some unlabeled video data like the sequence in Cityscapes.

Would you mind to share the unlabeled video data, so that we can reproduce your experiments?
Thanks!

I'm sorry but I don't have that data available. I left those when the internship ends. As I mentioned, decoding the videos here will give you the unlabeled video frames, you should have the same data as mine. Sorry about the inconvenience.

What a pity.
By the way, have you used the pre-trained weight on cityscapes to train your CamVid model?

Yes, I used it. As shown in my experiments and previous VideoGCRF work, using pre-trained weight on Cityscapes to train CamVid is very helpful.

Thanks for your help.

Seems like the project moved here: http://web4.cs.ucl.ac.uk/staff/g.brostow/MotionSegRecData/


Add build tutorial

I'm wondering about some tutorial in .md format, where will be described:

How to build PS2SDK for Tyra.
How to build Tyra.
How to build samples.
How unpack samples assets.
What to do in PCSX2 to make Tyra samples running.

Tutorial was created and is available in Discord channel.


Create ci cd deployment

Creating new CI/CD deployment process to auto-publish to PyPI

Deployment only attempts if all QA tests pass

Tests passed, merging to test deployment


Excess scroll in initial chart on android/phone

I've noticed that when going through the scrolly part on a phone screen, the page scrolls too far and hides the top axis with the countries (see image below).

Same thing happening here


Fix for Model2FormTransfomerServiceImplTest

+1

IDK if it's of any interest to LiveSpark but kie-wb-commons now has an "Import Example" module that uses a properties file and Wizard to expose import of arbitrary repositories into a Workbench. We've (well, me) replaced the "auto-clone" of example(s) repositories with this in the KIE Workbench distributions.

@manstis Thanks for the tip. That will probably be of use to us in the future.


select from ws2_32

https://docs.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select

This was added and will be in the next release.

Thank you !


Problems reading Ensight Gold files where case file uses wildards.

May or may not be related to http://visitbugs.ornl.gov/issues/1303 The geometry files are specified using **** wildcards.VisIt opens the case file fine but issues error when attempting to plot.The engine log files indicate an inability to locate/open the geometry file. I have data from customer (Jacob McFarland).
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2543
Status: Rejected
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: Problems reading Ensight Gold files where case file uses wildards.
Assigned to: -
Category: -
Target version: -
Author: Kathleen Biagas
Start: 03/02/2016
Due date:
% Done: 0%
Estimated time:
Created: 03/02/2016 07:27 pm
Updated: 08/10/2017 07:31 pm
Likelihood: 3 - Occasional
Severity: 4 - Crash / Wrong Results
Found in version: 2.10.0
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
May or may not be related to http://visitbugs.ornl.gov/issues/1303 The geometry files are specified using **** wildcards.VisIt opens the case file fine but issues error when attempting to plot.The engine log files indicate an inability to locate/open the geometry file. I have data from customer (Jacob McFarland).
Comments:
#1303 has to do with using * wildcards in a case filename, which the reader is sort-of set up to handle.The reader is NOT set up to parse wildcards in the geometry file name.I've attached Jacob's data, with his permission. The problem with Jacob's data is a line in the TIME section: maximum time steps.The VTK reader we use under the covers has problems parsing the case file when this line exists, while attempting to read the 'filename start number' and 'filename increment' (used for parsing wildcards in geometry file name).If I remove the line, VisIt will work correctly. However, his data also consists of 2 parts, with variables existing only on 1 of the parts, so we run into the problem descirbed by #2273.I looked at the EnSight User Manual for version 10 (seems to be latest), and 'maximum time steps' is not specified. I looked again at the EnSight user manual, and no 'maximum time steps' is specified.Without that line in the case file, and with the changes to fix #2273, then VisIt can read and plot the data.

ensight.zip


ENH: Update to latest Emperor version

Updates recipe to refer to the latest emperor version.

Thanks @lizgehret!


python errors since upgraded tool to current version

First of all many thanks for introducing this very useful tool. Since about a week or two I get python errors when using the tool. Before I upgraded the tool to the currenr version it worked like a charm. I get errors not always but most times. Im now on QGIS 2.18.14, as it happened at 2.18.13,. I also tried long term QGIS release 2.14.20, same thing. As I recently upgraded OSM Tools from 0.3 to 0.3.4 I also tried to downgrade to various versions, no change, it still happens.
Here the trace:
2017-10-30T14:07:11 1 Traceback (most recent call last):
File "C:/Users/User/.qgis2/python/plugins\OSMtools\osm_tools.py", line 265, in run
self.route_anal.route()
File "C:/Users/User/.qgis2/python/plugins\OSMtools\osm_tools_routing.py", line 223, in route
loc_dict = point_geo.reverseGeocode(point_geom)
File "C:/Users/User/.qgis2/python/plugins\OSMtools\osm_tools_geocode.py", line 38, in reverseGeocode
root = json.loads(response.text)
File "C:\PROGRA~1\QGIS2~1.18\apps\Python27\lib\json_init.py", line 338, in loads
return _default_decoder.decode(s)
File "C:\PROGRA~1\QGIS2~1.18\apps\Python27\lib\json\decoder.py", line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\PROGRA~1\QGIS2~1.18\apps\Python27\lib\json\decoder.py", line 383, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
I appreciate your help. What else can I do to fix the issue?
Thanks again and best regards from Germany.

@wmeinolf sorry, I was away on vacation for 4 weeks. I´ll look into it asap and keep you posted. It looks like it has problems in the reverse geocode section. Maybe ORS changed smth in the response.

Hi @wmeinolf,
as I´m working on a temp laptop right now, I did an entirely fresh install of QGIS and OSM tools, and I cannot reproduce your issue. And despite seriously lots of debugging in the past, I never came across that one, though my memory might elude me too..
It´s a weird error, that shouldn´t be raised really.. No matter what you´re doing, you should always get a JSON object back, with an error in the worst case, but there HAS to be one. So, I´d ask you for a few things to narrow down the options:

Can you describe step-by-step what you´re doing to get to the error (e.g. does it happen when you´re clicking the 'Map Coordinates' button in the Routing dialog, or after you click 'Ok')
Can you please load this one in your browser (remember to put in your own key after api_key=:
https://api.openrouteservice.org/geocoding?lang=en&api_key=yourkey&location=9.32368,49.34978

And let me know what the result was. It should return this feature collection:

Thanks
Nils


Add dummy interface to 17.2R1.13

This fixes misalignment of vmx v17.2R1.13 interfaces for xconn

@milanjelicic could you elaborate on what kind of misalignment one will observe if this is left out? Trying to find out if this is matches what I'm seeing on 18.1, namely having to address ge-0/0/0 using interface number 2 in vr-xcon.

@fstolba yes, you're correct it fixes ge-0/0/0 not being mapped to interface number 1 on vr-xconn but interface number 2.

LGTM


Reenable test_copy_editable_packages

Description
This reenables the .egg-link copy test (in a meaningful way this time) disabled by this commit: https://github.com/dacut/Zappa/commit/3c9d8da77c8d15e09deb816a58755061600b21c7
No functionality in this one, just re-adding a test, making it more portable across platforms, and works now for Python 2.7 and 3.6 (previous version was effectively 2.7 only).
GitHub Issues
https://github.com/dacut/Zappa/commit/3c9d8da77c8d15e09deb816a58755061600b21c7

Coverage remained the same at 73.871% when pulling 06603a3299b05d8c6ed65826f366ec41de39e119 on dacut:reenable-copy-editable-packages-test into 12ac82e71deeffcb03dbb6549be4f6f60d537382 on Miserlou:master.


Fix multiple issues in transform.py

Create test cases for already existing pull request #333 and add fix + test for issue #332
ToDos:

[x] Ping @oeway: I used your pull request for fixing the skel test cases.
[ ] Make sure old test cases finish successful

Codecov Report

Merging #340 (bb575d0) into master (ec85934) will increase coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   38.22%   38.97%   +0.75%
==========================================
  Files          17       17
  Lines        5306     5308       +2
==========================================
+ Hits         2028     2069      +41
+ Misses       3278     3239      -39

Impacted Files
Coverage Δ

cellpose/core.py
55.97% <100.00%> (ø)

cellpose/transforms.py
64.40% <100.00%> (+8.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec85934...bb575d0. Read the comment docs.


Update for master branch iced and clipboard support

This merges the changes from #25 into the iced_git branch as discussed in that PR and on the Discord. Since this branch supersedes most of the changes in the iced_git branch, the only remaining change form that branch is the addition of the ignore_non_modifier_keys. In the future that should probably also be replaced by adding proper keyboard focus handling to baseview.

I pushed another change that renames the renderer module to backend because renderer shadows the iced_native::renderer re-export.

And I also added an alias for iced_native::Element because otherwise it's impossible to make custom widgets. Any suggestions for a better name?

Never mind, this change is not needed because you can of course also just implement the conversion for just the renderer used by iced_baseview:
impl<'a, Message> From<Foo<'a, Message, backend::Renderer>> for Element<'a, Message> {
    fn from(widget: Foo<'a, Message, backend::Renderer>) -> Self {
        Element::new(widget)
    }
}

I'll get rid of this alias again.

A few things come to mind:

The option of querying and using the maximum supported number of GL AA samples has been removed, correct? Do you think this would be better implemented in baseview?
I would like to rely on the official baseview repo. Do you think you could get your changes merged? There could be some unforeseen side effects of sending modifiers with mouse events and it would be great if the baseview community could weigh in.

The option of querying and using the maximum supported number of GL AA samples has been removed, correct? Do you think this would be better implemented in baseview?

I wasn't sure about this, what do you think? With hardware currently in use (and that supports OpenGL 3.2/3.3-ish), is there actually any hardware that does not support multisampling?

I would like to rely on the official baseview repo. Do you think you could get your changes merged? There could be some unforeseen side effects of sending modifiers with mouse events and it would be great if the baseview community could weigh in.

Good catch, I had that in there for my personal use (since I want to use keyboard modifiers) but I should move that change to another branch.

I wasn't sure about this, what do you think? With hardware currently in use (and that supports OpenGL 3.2/3.3-ish), is there actually any hardware that does not support multisampling?

I did in fact encounter this problem, though it might have been while doing multi-OS testing inside of a VM. Another factor is that I prefer not to use the lowest common denominator (4 samples?) everywhere because 8 might not be supported in some cases.

Good catch, I had that in there for my personal use (since I want to use keyboard modifiers) but I should move that change to another branch.

Mouse events with modifiers have in fact been working for me, but I have had some strange issues that those changes would possible solve. I'll have to try out your changes with OctaSine.

I don't think there's a way to add a similar check for the wgpu backend, but I'll add it back for the OpenGL backend then! And it seems I'll need to revert some more changes to undo the keyboard modifier changes.

Ok, that's great!
Regarding the keyboard modifiers, if your baseview changes indeed make sense in the general case, it wouldn't be bad to have them upstream!

I also added an option to always force a redraw because baseview currently doesn't always trigger a redraw correctly. The correct approach would of course be to make baseview account for window visibility events but this seemed like a good stopgap measure especially because it would also allow animations to work correctly for custom iced wigets. Otherwise that would require sending iced messages on an async timer stream. Thoughts?


Color issue in 1.4.0

After updating my atom editor all the colors in all my themes start looking very weird.
Before 1.4.0

After 1.4.0

The theme in the images above is Seti both ui and syntax
Is this intended in the update or is there a bug?

Hi @RoleplayDotNetwork, the Javascript language changed a lot between 1.3.0 -> 1.4.0, which added support for chained methods and properties.
Do you have any suggestions as to what the syntax highlighting should be like?

Ah that would explain it.
Thanks @50Wliu
Guess it's just something to get use to.
Though there was an issue on another project where the bracket color matching was quite off.

@RoleplayDotNetwork Thanks for the update! In that case, would you mind opening another issue for that bracket syntax highlighting issue on https://github.com/atom/language-javascript? (Also take a look at the open issues in that repo – it might exist already.)

The highlighting changed for me so much that it is close to unusable. Is there any way to revert to 1.3 highlighting scheme?

@arodic if you're using one-dark-syntax this comment should help you.  Otherwise, a more general solution is available at https://github.com/atom/language-javascript/issues/308#issuecomment-173328656.
In addition, I would greatly appreciate it if you could give some suggestions as to what the highlighting should be like.

@50Wliu thanks I'll look that up. Personally, I prefer the way it was before. For example, in the before/after screenshots below you can see that both this and properties of this are the same color. That makes is harder to visually discern very important this keyword. However, properties are sometimes orange for reason I cannot understand.

Ok, when this becomes orange, that's definitely a bug :P.  I think we've fixed that but I'll double-check later today just to be sure.
Also, you're in luck - this (and super) can be styled separately using .variable.language.js so that you can give it a unique color.


Doesn't work for my 10 1809 - 10.0.17763.1

Not working with the new update of windows 10

Duplicate of #578.


chore: update contrib repo

Update codeowners file.
Add README.md for propagators.
Update top README.md.
Remove duplicate example.

should we list here only the plugins that are in this repo - currently we show all ?

If you don't mind, I would like to do it in the separate PR.


[Bug]: PostVisit hook unable to access story source code

Describe the bug
Hello, I'm using the postVisit hook of test-runner to generate a JSON file containing the source code (in TSX) of each story available in my codebase.
In test-runner.ts I have the following snippet of code:
  async postVisit(page, context) {
    ...
    const { parameters } = await getStoryContext(page, context);
    console.log(parameters.docs.source.originalSource);
    ...
  }

I have a general setting that tells storybook how to render docs.source.type that was initially set to dynamic.
With this initial setting the source docs generated in the StoryBook web app are fine:

While the values retrieved by test-runner in postVisit method are the following:
      {
        args: {
          value: true
        }
      }

If the type is set to auto it behaves like dynamic.
If I set the type to code the web app source code shows args:

While the output of test-runner remains the same of above.
Seems like there is no option to have on both the web and the postVisit the string source code.
How can I achieve this?
Is there another way to programmatically catch and save to a JSON file the source code of a story?
Thanks
To Reproduce
Clone the repo and checkout branch 417-chore-add-tool-to-generate-components-database.
The source code of the branch is available here
Run:

nvm use
npm i
open one terminal and run: npm start
open one side terminal and run npm run test:db

The test:db command will output to the console an example of the source code.
System
Storybook Environment Info:

  System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.14.0 - ~/.nvm/versions/node/v20.14.0/bin/node
    npm: 10.8.1 - ~/Works/melfore/libraries/mosaic/node_modules/.bin/npm <----- active
  Browsers:
    Chrome: 126.0.6478.127
    Safari: 17.2.1
  npmPackages:
    @storybook/addon-actions: ^8.1.10 => 8.1.10
    @storybook/addon-coverage: ^1.0.4 => 1.0.4
    @storybook/addon-essentials: ^8.1.10 => 8.1.10
    @storybook/addon-interactions: ^8.1.10 => 8.1.10
    @storybook/addon-links: ^8.1.10 => 8.1.10
    @storybook/addon-themes: ^8.1.10 => 8.1.10
    @storybook/addon-webpack5-compiler-babel: ^3.0.3 => 3.0.3
    @storybook/react: ^8.1.10 => 8.1.10
    @storybook/react-webpack5: ^8.1.10 => 8.1.10
    @storybook/test: ^8.1.10 => 8.1.10
    @storybook/test-runner: ^0.18.2 => 0.18.2
    eslint-plugin-storybook: ^0.8.0 => 0.8.0
    storybook: ^8.1.10 => 8.1.10

Additional context
No response

Hey @luciob what you are trying to achieve is not possible.
Storybook does not hold the JSX source in the parameters. The Storybook docs addon uses react-element-to-jsx-string internally to rebuild the JSX and that happens dynamically as you access the docs view in Storybook.
If you want, the test-runner can generate DOM snapshots instead. I am not sure what you are trying to achieve though, would be nice to understand your use case better.

Hi @yannbf, thanks for your reply.
I'm already doing snapshots in the postVisit hook, following the tutorial available on SB documentation.
What I'm trying to achieve is to build a database of all components in my library, using StoryBook stories as source of truth.
For each component I want to have a record with:

name
description
props (array of structured data)
examples (array of source code examples, 1 for each component story)

The first three were quite easy using the postVisit hook to access story parameters.
The last one is the missing one I'm trying to achieve.
Maybe I could use the react-element-to-jsx-string somehow, but that's not clear to me how to dynamically import the components.

I see! So the examples you are looking for are of the JSX, right? e.g.
<Checkbox onChange={...} />

I'm honestly not sure how you could achieve that with the test-runner and how difficult it might be, or even if it's possible. You could take some inspiration from how it's done in Storybook docs:
https://github.com/storybookjs/storybook/blob/3a1e61cefec8dfd350d42db5598b2d0d9159a878/code/renderers/react/src/docs/jsxDecorator.tsx#L78
Just keep in mind that the test-runner hook runs in node, so if you need to run things in the browser, you need to use page.evaluate.
The only way to get this easily would be to manually add the source as a parameter, and then access it, but then it will be quite some effort for you to keep things up to date.

Alright I found a solution to your use case. Please be advised that this is not a recommendation at all, this is more like a hacky workaround that happens to work well! However this code is brittle as it depends on internal things that might change.
Storybook already does the job for you, and addon-docs emits the story source after it's computed. So here's an example of how to:

listen to that event before the story is rendered (preVisit hook)
store the data
use it to do whatever you want (postVisit hook)

import { getStoryContext, TestRunnerConfig } from '@storybook/test-runner'

declare global {
  // this is defined internally in the test-runner
  // and can be used for logging from the browser to node, helpful for debugging
  var logToPage: (message: string) => Promise<void>;
}

type SourceData = { source: string; args: Record<string, any>; id: string}
let extractedData: SourceData

const waitFor = async <T>(condition: () => T): Promise<T> => {
  let result = condition();
  let timeout = 2000;
  const interval = 100;

  while (!result && timeout > 0) {
    await new Promise(resolve => setTimeout(resolve, interval));
    result = condition();
    timeout -= interval;
  }

  if (!result) {
    throw new Error('Timeout exceeded');
  }

  return result;
};

const config: TestRunnerConfig = {
  async preVisit(page) {
    const extractData = page.evaluate<SourceData>(() => {
      return new Promise((resolve, reject) => {
        const channel = globalThis.__STORYBOOK_ADDONS_CHANNEL__;
        // use this helper if you want to debug
        // window.logToPage('listening to the storybook channel')

        // event emitted by the addon-docs when a snippet is rendered
        channel.on('@storybook/core/docs/snippet-rendered', (data) => {
          resolve(data)
        })
      })
    })
    // we can't await this because it will block the test from continuing
    // so we store its value and get it in the next hook
    extractData.then(data => {
      extractedData = data
    })
  },
  async postVisit(_page, context) {
    // waitFor is probably not needed so feel free to remove it. It's here to ensure that the data will be there
    // there could be cases where timing isn't right and the event takes a bit longer to be emitted (e.g. complex components that take longer to compute)
    const data = await waitFor<typeof extractedData>(() => extractedData)
    console.log('Story data', {
      id: context.id,
      title: context.title,
      name: context.name,
      source: data.source,
      props: data.args
    })
  }
}

export default config

This results in what you're looking for:
{
        id: 'components-iconbutton--default',
        title: 'Components/IconButton',
        name: 'Default',
        source: '<IconButton\n  aria-label="forward"\n  name="arrow-right"\n/>',
        props: { name: 'arrow-right', small: false, 'aria-label': 'forward' }
}

There are things you can change in this snippet. Some things are there for debugging purposes, some things might not be needed, I just wanted to give you a baseline to start with!

Thanks @yannbf that worked. I was able to solve the issue and generate the components DB.
Just one side note: addon-docs must be explicitly installed as dev dependency.

Great to hear @luciob! I'd really love to see what you are able to achieve with this. Seems like you're experimenting with AI?

Great to hear @luciob! I'd really love to see what you are able to achieve with this. Seems like you're experimenting with AI?

That is the idea. Build a JSON components DB to have all possible documentation for our MUI wrapper library @melfore/mosaic. Once that is done, create something very similar to projects like openV0 to let GPT generate UIs sourcing from our own library. Let's see where this will bring us..
Thanks again for your precious support!


Added onTransitionRun to the unsafe events

This change is

Thanks for the update. :+1:

Not related. But after reviewing this change I found, that onTransitionEnd is twice in the list.

I will check it, thanks for the hint. 👍


Dashboard

Hi!
Thanks for sharing this exporter 👍
Do you have a grafana or similar dashboard you are using to display all the metrics that you could also share? If you are using grafana you can dump the json for a dashboard to share 😉
Kind regards,
Asbjorn

Just uploaded one of the dashboards I am using.. the other summary board has a lot of other things on it but I'll see if I can break that one up to something useful here.

Fantastic!! Thanks a bunch 😬  🙌🎉
I'll close this issue now, but please ping me here if you get around to break out the summary board 👌


feat: add copy schema button

closes #10
I checked, and it seems there is no need to request permissions for using the clipboard. In fact, I don't know why, but I've tested this disabling the permission in chrome and it still copies the schema 🤷♂

Well done


[FEATURE] adding a chatbot ✨

I want to add a chat board, which will be fine tune for the website and solve user queries. Can I work on this issue?

@akbatra567 can i work on this issue.


investigate FacDB source data for capacity/beds information

to request missing data from agencies soon, we should:

list source data for specified facility types
compile a list that links to the latest source data file
note if that source data has capacity and/or beds information

See here
Previous sheet has linking of factype to data source


Set check options in specification code

I'm just going through the project with a fresh pair of eyes, thinking about how a new user would interact with Quickstrom. Here's what I'm wondering:
When looking at the examples the tests are ran using the cli, but I wonder if some of the attributes passed to the cli can in fact be in the tests/specs? eg:
https://github.com/quickstrom/quickstrom/blob/9e74c0da944799ae9d3520dc67c576c1fbd8c7e8/specs/run-all.sh#L49
can http://todomvc.com/examples/vue/ be set as part of a top level spec file, or some sort of a runner from within the specs?
When looking at projects like Puppeteer, you can have full control of the test runner from within the specs. (ignoring it's JS!)
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch()
  const page = await browser.newPage()
  await page.goto('https://www.google.com/') // this line telling test runner where to go
  page.on('dialog', async dialog => {
    console.log(dialog.message())
    await dialog.dismiss()
  })
  await page.evaluate(() => alert('This message is inside an alert box'))
  await browser.close()
})()

Even if it's not inline as part of a spec file, but could be a top level runner:
module Runner where

import Quickstrom (Options(..), Flags(..), Results(..), runQuickStromIO)
import Spec1 (spec1)
import Spec2 (spec2)

main = do
  runQuickStromIO [ { spec: spec1
                    , loc: "../MultiPage.html"
                    , opts: [Options]
                    , flags: [Flags]
                    , res: Result
                  ]
  runQuickStromIO [ { spec: spec2
                    , loc: "http://www.webA.com"
                    , opts:[Options]
                    , flags: [Flags]
                    , res: Result
                    }
                  , { spec: spec2
                    , loc:  "http://www.webB.com"
                    , opts: [Options]
                    , flags: [Flags]
                    , res: Result
                    }
                  ]

Ignoring my terrible naming conventions and if you'd even use records, but the idea being you have control of what the test runner is doing from within the code you are writing the specs/test.
Under the hood it would probably just be using the cli directly and from there could control styling of outputs etc.
This would help with context switching, because how likes to write shell scripts hehe

ps: totally non related but I have to vent my pain somewhere, nix is great but not on osx 😢
I'm still building from original nix-shell that's 5 hours!!! 😂

@Cmdv it took me that much or more to build. Good news it does end up compiling after all that. Have you tried using cachix? Supposedly it will make it faster, but I haven't gotten around to testing it yet.

@amitu yeah it built in the end (6 hours lol) and I do have cachix but didn't realise you could use it to build the full project!! was it just chachix use quickstrom?
Maybe I should add how to install things as contributors 🤔

@amitu yes it's my bad I should have read the provided instructions!! I don't need a manual!!! will the 6 hours wait make me learn? I doubt it very much!! lol

@amitu yeah it built in the end (6 hours lol) and I do have cachix but didn't realise you could use it to build the full project!! was it just chachix use quickstrom?
Maybe I should add how to install things as contributors thinking

I've added a link from the README to CONTRIBUTING.md. Maybe there should be one in the user guide, too? But I'm hesitant, I think the user guide should only be directed at "end users". If there are weird things that require people to clone the repo, then we should fix those problems instead.

Regarding your question @Cmdv , this is something that I've actually changed away from. The origin URL, e.g. http://todomvc.com/examples/vue/, was previously specified as a top-level definition origin in the spec module.
I needed a single specification to be usable with many different origin URLs (all the TodoMVC implementations!). And I imagined people reusing their specs to run them locally, in dev environments, and maybe in prod, for instance.
But if we changed it so that the check options (those that are currently given as CLI parameters) could be optionally set directly in the spec, it would be fine. We could have a resolution mechanism where the first available value for a check option is chosen, in the order:

specified as a top-level definition in the spec module
set as a CLI parameter
(environment variable?)
default value, if available

And if no value is available, Quickstrom would fail with an error.

Ah yes that makes sense, I might have a little dig around see if I can implement an origin URL through all 4 steps. Then if that works it shouldn't be too complex to add any other attributes.
One thing is how do you envision "a top-level definition in the spec module" looking like?
Without having looked too deeply into the inner workings, am I right in saying things are currently set up to work on a per spec basis?

Cool! I'm thinking the CheckOptions could be parameterized with a function, making it an HFunctor:
data CheckOptions f = CheckOptions { checkTests :: f Int, checkOrigin :: f Text, ... } -- and so on

And the different sources of config could be parsed and represented with CheckOptions Maybe. In the end we resolve the various check options structures into a single Either SomeError (CheckOptions Identity).
Regarding top-level definitions, I'm thinking bare top-level names corresponding to the CheckOptions structure:
module MySpec where

...

origin = "http://example.com"

tests = 10

maxActions = 50

...


Vue.extend and constructor chain

First, thanks for sharing this really nice and powerful tool !
I have tried to make use of ES6 or Typescript classes for new components, especially to gain some static testing for TS. I have played with the vue-class-decorator, and it all seems quite OK, except for one thing, the constructor chain.

class TestComp extends Vue {
   n = 42;
   constructor() {
      console.log( "we never end here, and this ", n, " is undefined" );
   }
   data() {return{ "test":42};}
}

var i = TestComp.extend({template:'<div>{{test}}</div>'});

This is, in the eyes of Vue, what the decorator does (in addition, it moves some functions and data around, but that is beside the point), when defining new components.
But in order to make this work as a normal class, we need to be able to call the constructor of the classes, and when this is done the Vue.extend() applied constructor should not call Vue._init() anymore (as the constructor of the Vue class does this), but let the normal constructor chain handle that.
I have looked into 'Vue.extend()' and it seems like some Super class awareness are there, but as far as I can see it end up in only forcing a single call to the 'Vue._init()' function, and nothing more happens.
So are there a trick to make a control constructor behavior in a extended class, or is this on the todo list ?

By vue-class-decorator, are you referring to this? https://github.com/vuejs/vue-class-component
If yes, it seems your usage is wrong. It doesn't use property initializers (and does not work with it).

First, I am sorry for any possible misunderstandings on my part, I am really trying to understand the core of this fantastic library, but I am walking on the edge regarding my knowledge of js here :-) But yes, I am referring to your vue-class-component, as this was my main inspiration, for more tight typescript (ES6 classes, really) coupling.
I understand that while using Vue.extend(), it will provide both the reactive data and the resolved el (when constructing a class from the result of the extend :-)), on the this instance. But if I understand what you are saying, this means that any extended Vue class can't hold other data then what is given by the Vue.extend() initializing original given from the options parameter.
If that is the case, my point is that this may be subject to change if we could somehow call the original constructor chain, that then would be able to further initialize the instance property on this down the chain. This would of cause provide a possible overwrite of the values given by the Vue._init() call, but the class instance would behave almost normally.
If this is not possible, then the 'Vue.extend()' instance, is really "just" a prototype extension, and not a real class extension in a classic sense ?
I hope this make sense, it is not easy to explain :-)

With vue-class-component the constructor is never called, because we are not actually using the raw class itself, we only treat it as something that holds meta data that can be passed to Vue.extend (which creates the actual sub class).
So I guess you are right in that Vue.extend() is not a classic class extension, and I personally recommend against trying to bend it to fit the classic class extension semantics, because Vue components are not classes after all.

Ok, thanks ... I will try to bend my brain after that fact, thanks for clearing that up :-)


Favor mvn exec rather than java jar

stream-registry PR
Manual invocation of java jar could potentially have classpath issues and stale artifacts can exist under assembly/target. Using Maven to run the main class, we are guaranteed for everything to be accurate.
Added

exec-maven-plugin

Changed

Makefile run and debug targets

PR Checklist Forms

[ ] CHANGELOG.md updated
[x] Reviewer assigned
[x] PR assigned (presumably to submitter)
[x] Labels added (enhancement, bug, documentation)

Do we really need to update changelogs for non-deployed code changes? E.g Makefile and documentation changes that aren't "modifying core behavior" ?

We've been talking about high level changes in CHANGELOG for documentation.
Simple typos are probably overkill.
That being said, this functionality might merit a CHANGELOG:
Changed

Preferring exec-maven-plugin over jar to ensure proper dependencies.

Looks like this PR has caused some instability in make run ... can we revert please ?

Reverting until we figure out why we are getting certain classpath issues on make run


Fix the bug of dropout and prenet.

I have tested that with both of the bugs fixed, good alignments can be learned with reduction factor 2 easily.

Hi I want to ask you that if we cut off half of samples in metadata.scv of LJSpeech, can we still get alignment with your fix?

LJSpeech is about 23 hours, and I think maybe 10+ hours of data is enough to learn the alignments.

Thanks for the fixes!

@npuichigo have you tested this on reduction factor of 5 (outputs_per_step=5)? With this change, my model is not wanting to align. Usually it'll align at about 10k steps. Currently at 30 and it's not wanting to align correctly.

Changed found here.
https://github.com/MycroftAI/mimic2/blob/master/models/tacotron.py#L51

@LearnedVector I tested on reduction factor 2 with LJSpeech and alignments can be learned after about 20k steps.

Here's the alignment of 32k with r=2.


Update HIP 16 to remove notion of a "CG score"

Since we're using a random function to elect/deselect, we shouldn't bother calling it a score.
cc: @jamiew @PaulVMo

Merging per @PaulVMo comments in Discord


Hardcoded path in new ssh connection

Version: 1.0.65
Platform: win32 10.0.17134
Plugins: none
I've set up an ssh connection, but when I click on it, I get a popup that says "Could not connect: Error: spawn C:\util\pagent.exe ENOENT".
I don't have a c:\util folder, hence the ENOENT. Is the path hardcoded somewhere?

Duplicate of #328


Getting Started

Hello Community,
I'm very impressed about the intention, possibilities and capabilities of Serenity. It seems to be that we need for development of database driven applications.
But I cannot install the version. E.G. NuGet libraries are missing in Visual Studio a.s.o.
What have I to do to get support? Do I have to buy a premium support (before evaluation) ?
Best regards, Torsten

What do you mean by NuGet packages are missing? Which version are you using? Maybe you cloned or downloaded project directly here?
Follow steps in guide
https://www.gitbook.com/book/volkanceylan/serenity-guide/details
and installation instructions in
https://github.com/volkanceylan/Serenity/blob/master/INSTALL.md

Thank you for your last response.
I followed all steps you described in that documents. At this moment I'm not in front of my computer.
The sergen based installation also does not work, because some error messages occurs while installation. I can try it again and can post this error messages into this thread. Hope that is the right place and  you can help me. I'm very interested in using Serenity.
Also I miss description of needed database settings. That is not described in the installation guide. How now Serinity the credential for log in?

Please read the guide, all you need is there.

Hello,
I had to reinstall Nuget and Visual Studio. After that it worked.
Now I made some exercises with Serenity and it works fine. It covers all what I need (I'm very impressed).  You made a good job. I would like to buy the premium service "personal". For that I don't want to use a credit card. Is it possible to get an invoice from Serenity so that I can transfer money? Can you help me in this?
Best regards, Torsten

Hi @grobberD, please contact me from my mail


Clean up AMP logic/naming

Changes hasAmp, isAmp, amphtml, etc to more descriptive names to help distinguish what they are signifying. Also removes old query logic from dirty AMP optimizing which is no longer needed.

We can address these things in a future follow up.


Account for hourly variations in trip durations when building the stop times

In real-world conditions, a given bus line's total trip time can vary according to the time of the day and the driving conditions.
When building a bus line from scratch, it is impossible to introduce this kind of variation since a single speed can be calibrated for each path.
This limits the use of Transition's route calculator to reliably assess travel time improvements throughout a day. The user is forced to simulate a single period in the day (i.e. peak or off-peak) if they want to use realistic travel times, which negates the usefulness of a full-day schedule.

Also duplicate of #591


Web interface overhaul

We'll be overhauling the web interface.
[ ] Should use better storage method of game state
[ ] Should use AngularJS instead of jQuery

[ ] Should use websockets

Do I dare ask, which version of Angular?

1.x?

I think the web interface could be its own repo, and I think angular would be overkill. I think a basic web interface is all we need (Jquery and angular aren't really comparable: one is a set of utilities the other is an entire MVW framework)

Yeah, no need for anything fancy. Some REST APIs, flask-socketio, and a simple enough design will probably suffice

In terms of my side of things, I cannot stand working with angular 1.x.  I've had much happier times with react, although that doesn't play well with jquery either (but I'm ok with that)

I'm happy with rest apis, will need to look into flask-socketio though.

I can do Flask-SocketIO, if you do the frontend part of SocketIO

sounds good

Closing this as there is now a dedicated repo for web.


medical lockers now have filled belts in them instead of empty ones

About the PR
Replaced the empty medical belts in med lockers with filled medical belts.
Why / Balance
fixes #31469
Technical details
Media
Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Changelog
:cl:

fix: Fixed medbelts in medical lockers starting empty.

So, from a balance perspective, I don't think it really changes that much. The same way that there's no reasonable way sec is using an extra dozen batons and cuffs, med having these extra topicals is about the equivalent of cargo just giving med one crate of materials.
On the other hand, it gives antags more incentives to try and break into med to steal a belt when they're wanted and can't freely walk into the med

How many lockers normally spawn in station? Just off the top of my head I wanna say Marathon has 4 in its backroom… so uh… 8 or so brute packs and ointment, about one or two extra vends of those I think?

Since this would add quite a lot of topicals to the round start equipment medical has available, could you remove the belt from the locker and put a few empty ones into the medidrobe instead? The chemdrobe for example already has a few in it as well.

this PR now does something entirely different than what it originally set out to do :/ still fixes #31469 though
I'll edit the PR title/description to fit

while this does TECHNICALLY solve the issue, I can see the issue "medical belts in medidrobe start empty" being made for exactly the same reason. So at the end of the day, is this PR even worth it at all?

The idea behind the decision was that clothing closets and drobes should only contain clothing, but not tools or medical supplies. It is a little inconsistent right now how it's handled everywhere else. Thank you for adjusting this.


ItemProvider -> ItemConvertible, StringRepresentable -> EnumPropertyValue

ItemConvertible reason:

This ItemProvider is implemented by Item and Block instead of some lambda that actually provides/supplies an item.

Another name HasItemForm, which is very accurate, is also considered, but because of the ideal of interface naming in adjectives, I chose ItemConvertible, as convert as a word means "change to a different form".

EnumPropertyValue reason:

This is only implemented by enum classes that can be used as state property values.

This is really just used to get the enum value names in a lowercase form (or getting the proper string version of the value)

hence "get value name".
A few other usages are present, but they are only really used to be a shortcut for getting lowercase enum names for translation keys, etc.

I'm a little unsure about both of these:

IMO, ItemProvider is perfectly fine. It's never really used in a situation where you care about the "conversion" operation - you just want to get hold of an Item instance. If we were to rename it to anything, it'd just be ItemSupplier.

StringRepresentable is a kinda poor name, but EnumPropertyValue feels really ugly. Maybe something like NamedEnum. Eh, it doesn't feel much better.

this item getting interface is only implemented by block and item classes, which aren't providers or suppliers but just have an item form/state.
I've considered PropertyEnum as well, which means it's an enum used for property (values). How's that? (Might look like EnumProperty too much?)

I feel the String supplying interface should be more generalized. Mojang uses it exclusively for determining the names of property values, so the most generalized form of that would be something like Named with getName as the member name.

Hmm, is there any other string supplying interfaces in vanilla? This one I see are all implemented by enums and used by enum property to retrieve a sanitized name.

hmm, does this match the naming convention

ItemConvertible and StringConvertible would be better.

SerializableEnum might work for the String interface. It is explicitly used for determining a unique name for an enum constant during (de)serialization of state properties.

SerializableEnum

Every enum is serializable (name and byName).

Updated. Renamed StringRepresentable to SnakeCaseIdentifiable instead, which is better than StringIdentifiable (the only method in the interface only return snake case strings)

Updating, any further discussion needs to go in a new PR or issue.


dynamic_reconfigure: 1.5.39-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository dynamic_reconfigure to 1.5.39-0:

upstream repository: https://github.com/ros/dynamic_reconfigure.git
release repository: https://github.com/ros-gbp/dynamic_reconfigure-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.19
previous version for package: 1.5.38-1

dynamic_reconfigure
* Better error message, to fix #32 <https://github.com/ros/dynamic_reconfigure/issues/32>
* Make Python callback code consistent with the C++ API
* Commented unused parameters to avoid compile warnings
* Contributors: Esteve Fernandez, Morgan Quigley

The PR reverts other changes. Please either fix the branch of this PR or create a new PR with bloom-release -p.


Mod-exclusive settings do not save

Whenever I play, the mod exclusive settings(HUD Size, Interface Opacity and Distance, etc) aways revert back to default value, meaning I have to switch every time. This could probably be fixed with a config implementation,.

Whenever I play, the mod exclusive settings(HUD Size, Interface Opacity and Distance, etc) aways revert back to default value, meaning I have to switch every time. This could probably be fixed with a config implementation,.

This is a bug, some options aren't saving, not just the "exclusive settings", it's not a lack of a config, it'll be fixed in the next version.
About the Skin Packs, probably at the beginning there will only be standard skins, to speed up the development process, as just adding skins with customized models would be simple, but I plan more elaborate support with resource packs.


Link to documentation of notification center is broken

https://github.com/terminal42/contao-news_newsletter/blob/3a7cccce61bcb65f9af20a47ed8c1415956a3a35/README.md?plain=1#L59
This link does not lead to the documentation

Fixed in 501ca3edeab5b50d9eeb393b631855bdb7b85257


Documentation: Editors

So, I happened to announce the elisp track on the #editors channel on the Clojurians Slack... someone mentioned how neat it would be to manage exercises from within an IDE (he's using Cursive w/ IntelliJ) and I mentioned the exercism.el package I started and stalled on...
Anyhow, it got me thinking it might be extremely helpful to have a help page on editors & configuration, not sure if this should go in the getting-started-with-clojure help section or somewhere else... should we have this? Thoughts?

Oh, my. Yes, this would be very, very good. Probably in https://github.com/exercism/docs/tree/master/app/pages/topics

Hi @kytrinyx!  I noticed that link is no longer working, is there any updated place that would be good for this documentation?  Would love to take a crack at this :)

I think we should probably have a whole new topic for this. We currently have a "/help" page (http://exercism.io/help), but that's specifically about troubleshooting.
What do you think of renaming "/help" to "/help/troubleshooting" and then adding "/help/editors" as a separate page? Take a look at https://github.com/exercism/exercism.io/blob/master/app/routes/static.rb#L16 and go from there to see how we've put together the view (there's some markdown in x/docs/md/... that we pull in. It's not awesome, but once you find your way around it, it's also not awful.


Functions runtime support consume messages asynchronously

Functions runtime does not allow to consume messages asynchronously. Async communication is needed when a message processing requires communication with external system.

Need a new interface
CompletableFuture apply (T input);


Review DocTR documentation

Hi again @fharper :wave:
Another request for DocTR would be if you could check out the documentation and provide some feedback: https://mindee.github.io/doctr/
I'll soon make some structural changes to integrate the PyTorch-specific documentation (next to TensorFlow version), and it will be a good occasion to make other edits if necessary !
Cheers

FYI we will do a release in a few weeks and by then, we will most likely change the README and documentation!
Would you have any idea whether/when you'd be able to provide some feedback on the README (#25) and the doc? :grin:

I'll do it by the end of the week :)

As with any feedback I'm giving, keep in mind that I don't have the holy truth so feel free to disagree. I'm usually seeing every little things and since I believe the devil is in the details, I usually share them. I also focus on what could be improved IMNSHO, so don't take anything personal here. Lastly, it's based on the actual knowledge I have of this project, which is basically nothing for now (didn't take the time yet to try it, but fear not my friend, it's coming). If anything is unclear or you want to discuss any points I wrote, please let me know, I'll be more than happy to do so!

General

I know doctr is an OSS project, but I think it would make sense to move the doc inside our main documentation. It wouldn't make sense if doctr was not mostly done by us and it wasn't under our own organisation on GitHub. Doing that will ensure the same structure for our users using both, and give some more visibility on our product for doctr users who don't know us.
Does our target audience knows already how all this stuff works? If not the doc would need some more "taking the user by the hand" content. Example, in the index  you talk about NLU, predictors and other things I have no idea what they are even if I know what OCR is and used some in the past. I may not be the target audience (yet).

https://mindee.github.io/doctr/

No need for "Welcome to the documentation of DocTR!"
I would change the wording of "Daily maintained" for something like "actively maintained by Mindee" which doesn't promise we push daily (which we nearly do, but we don't), and it's a small promo for us :D
Add a Table of Content for the page at the top.
No need for changelog & package reference since it's already in the left sidebar.
Maybe it's because of my lack of deep knowledge on OCR, but seems like right after the Installation section, we do back into the features of the app. I would move getting started at the end. Even removed it since there is the installation menu to the left.
Unless again the target audience knows everything in that Model zoo and supported dataset listing, I may add some more details on the benefits of that.

https://mindee.github.io/doctr/installing.html

"This library requires Python 3.6 or higher." should point to Python doc like we do for TensorFlow or PyTorch.
"Whichever OS you are running, you will need to install at least TensorFlow or PyTorch. " How can I know which one should I use? Is there specific cases where I should use one or another?
"For MacOS users, you can install them as follows" we assume people have Homebrew installed (need to point them in the right direction). We can also proposed a more Python centric way as a alternative with pip.
"For Windows users, those dependencies are included in GTK. You can find the latest installer over here." should we point to official GTW Windows installer instead?
Add a table of content
last code snippet of this page has a formatting problem

Tomorrow I'll check the references.

Thanks a lot :pray:
To answer more specifically:

https://mindee.github.io/doctr/

Add a Table of Content for the page at the top.

Considering the small number of sections in this landing page, is it really useful?

Unless again the target audience knows everything in that Model zoo and supported dataset listing, I may add some more details on the benefits of that.

Mmmh, there are more details in the package reference, I'll try to both link the paper & the package reference for each model

https://mindee.github.io/doctr/installing.html

"Whichever OS you are running, you will need to install at least TensorFlow or PyTorch. " How can I know which one should I use? Is there specific cases where I should use one or another?

That one is tricky: say you want to build a house, you can get the same result with material A or B. To make it profitable, you had to make a choice early on about which material to invest in (learning curve-wise). It's exactly the same thing here: half the community is more comfortable with PyTorch, half with TensorFlow. The library fully supports both

"For Windows users, those dependencies are included in GTK. You can find the latest installer over here." should we point to official GTW Windows installer instead?

I added the reference to the most recent installer, the official versions are lagging behind unfortunately (but that one was released by a senior developer working on Microsoft projects)

Add a table of content

Same thing here, isn't it a bit short for a table of content
The rest of your comments has been taken care of :)


Catch file not found

Laravel Mix Version: 6.0.10
Node Version: 14.15.4
NPM Version: 6.14.11
OS: Windows

Description:
when file is not found, need to show an error, but debug of this is missing
Steps To Reproduce:
in webpack.mix.js write:
mix.styles(['resources/css/undefined-file.css'], 'public/css/test.css');

I have the same error...


Handling fn empty where and comments after return type

Proposed fix for issue #5407.  Although the original issue is about fn empty where clause indentation, the issue is actually about handling of comments after fn return type.  This is because with current code the empty where was handled as a post return type comment.
In addition, there are related issues with handling comments for fn empty where clause without return type.  Therefore the fix handles the cases of fn return type without where clause, empty where clause without return type, and return type with empty where clause.
The proposed fix seem to also resolve issue #4649.
Note that the fix is not related to issues with traits empty where clause, such as #4672.

Thanks for your work on this! I Also appreciate you linking some relevant issues. I'm planning to get an initial review done in the next few days

The proposed fix seem to also resolve issue https://github.com/rust-lang/rustfmt/issues/4649.

Could we add test cases for the linked issue if these changes help to resolve what's going on there

The proposed fix seem to also resolve issue https://github.com/rust-lang/rustfmt/issues/4649.

Could we add test cases for the linked issue if these changes help to resolve what's going on there

Added test cases for the original case of #4649 with empty where.
The other reported case in #4649 with non-empty where is a different issue and is probably the same issue as reported in #4672.

Added test cases for the https://github.com/rust-lang/rustfmt/issues/4649#issue-787737841 of https://github.com/rust-lang/rustfmt/issues/4649 with empty where.
The https://github.com/rust-lang/rustfmt/issues/4649#issuecomment-952310029 in https://github.com/rust-lang/rustfmt/issues/4649 with non-empty where is a different issue and is probably the same issue as reported in https://github.com/rust-lang/rustfmt/issues/4672.

Thank you for looking into this!


Unable to build current main on MacOS - no libavcodec

Currently, the build process fails with the following error:
-- Checking for module 'libavcodec'
--   No package 'libavcodec' found
CMake Error at /opt/homebrew/Cellar/cmake/3.29.5/share/cmake/Modules/FindPkgConfig.cmake:634 (message):
  The following required packages were not found:

   - libavcodec

Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.29.5/share/cmake/Modules/FindPkgConfig.cmake:862 (_pkg_check_modules_internal)
  Userland/Libraries/LibMedia/CMakeLists.txt:23 (pkg_check_modules)

-- Configuring incomplete, errors occurred!

Any thoughts on fixing this? I've tried searching brew but failed. Only found this post about libav deprecation: https://stackoverflow.com/questions/75514075/brew-cant-install-libav

Did you install the list of packages here?
https://github.com/LadybirdBrowser/ladybird/blob/master/Documentation/BuildInstructionsLadybird.md#macos
libavcodec should be installed with ffmpeg in that list.

Och, right. I must have missed that. I thought it was installed previously. Sorry for that.
Thank you for pointing out to me.