AOT seems to be enabled by default in beta.22 ?

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

El Capitan
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.22
node: 6.6.0
os: darwin x64
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

run ng serve
The log given by the failure.

Normally this include a stack trace and some more information.

10% building modules 2/2 modules 0 active(node:14509) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in /Users/ritz078/projects/housing-assist/src/app/app.module.ts, resolving symbol AppModule in /Users/ritz078/projects/housing-assist/src/app/a 20% building modules 86/86 modules

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

Yes perhaps, very minor problem here guys. No one cares if it's the weekend and you haven't gone to bed yet.
I can't even build far enough to get a useful error message.
c'mon this sort of thing should not be possible 1 month before 2017.

It looks like aot is enabled by default but I'cant even disable it.

This has already been reported in #3354.

These are the approximately gzipped production payload for my application:
CLI beta 21/Angular 2.2.1 without AoT. main.bundle: 260kb, 0.chunk: 150kb, 2.chunk: 50kb...
CLI beta 21/Angular 2.2.1 with AoT. main.bundle: 200kb, 0.chunk: 350kb, 2.chunk: 20kb...
CLI beta 22/Angular 2.2.3 AoT only. main.bundle. 70kb, vendor 130kb. 0.chunk: 350kb...
Basically with AoT, the main/vendor bundle reduced by about 20%, but all the other lazy/pre-loaded chunks increased, some by more than 100%. I compared the chunk's source and found that with AoT, the size increase seem to came from very many pre-compiled html js code, such as
            this._text_50 = this.renderer.createText(this._el_49, "Some html text", null),             this._text_51 = this.renderer.createText(this._el_47, "\n    ", null),             this._text_52 = this.renderer.createText(this._el_45, "\n    ", null),             this._text_53 = this.renderer.createText(this._el_43, "\n  ", null),             this._text_54 = this.renderer.createText(this._el_0, "\n", null),
where this._el_123 reference a renderer of an html tag. These "\n" code lines basically matches the closing HTML tag. Without AoT, these code would be replaced with plain HTML developers code up.
Is this expected? The app total (eager + lazy) size went from 900kb to 1.2mb according to chrome. Are there any work in progress to reduce the pre-compiled code size? Due to this increase, it may not be worth it in certain situation to turn on AoT. Not sure if this should be a CLI issue or an Angular2 framework issue. If so, please advise...

Looking more into my 0..chunk.js and my other lazy chunks, I've found that these this.renderer... HTML codes are actually duplicated!!! Not wonder it got so humongous... I will open a bug on this tomorrow unless someone beats me to it.

I deleted a comment that was obviously against the code of conduct.

@ritz078 we don't enable AoT by default, BUT we do generate lazy bundles.  We had "faulty" code before that was working which we might revert too; it was dumber but in this case it would fix it.

We changed the way we analyze lazy routes in the CLI; you now have to use statically analyzable code. This is more solid and also takes into account libraries that include routes and lazy routes. It also means the code needs to be AoT-compatible, even though you're not using AoT to compile it.
The problem here seems to be that you either:

are using function calls that are not "simple" enough for the static analyzer to understand, or
are using a library that doesn't include metadata.json files. This can be figured out by remove libraries and seeing if the code compiles.

For point 1, you should not use function calls or non-const values in metadata. Metadata is supposed to be static and easily parseable. Basically it needs
For point 2, we (the Angular Team) offer best practice guides for library developers to follow, in order to be AoT compatible. Libraries should follow those best practices. If you are (or know) the library author, this page explains how to be AoT compatible for a library: https://angular.io/docs/ts/latest/cookbook/aot-compiler.html

It seems that the user experience(in my case ng serve stalling) is not ideal. Also, it seems that ng serve/build is ignore my tsconfig and using declaration: true as I am seeing a lot of these type errors after upgrading to the latest beta: exported variable 'reducers' has or is using name 'Action' from external module

@hansl I'm not sure to understand, but if we use a non compatible AOT library, we won't be able to use angular-cli (except < beta 22) ?

@maxime1992  seems so. + there are several new problems like using non-reexported types as return type of methods in exported class...

Although it is momentarily inconvenient, I think it is a very positive development to see CLI requiring that code and libraries have the bits necessary to work with AOT. This should result in a better sense of urgency among application and library authors to become compatible with AOT.
In the long run, I think this would be even better: for Angular itself to be modified a bit such that JIT imposes as close as possible to the same requirements as AOT.

this will lead to the end of angular, because authors of 3rd party libraries wont invest their time to modify code and build it with ngc.

@kylecordes I loved that I could use some older javascript libraries - for example jQuery jsTree, some color picker and so on.. and write simple wrapper for Angular 2. There are lost of non-angular libraries which are really great and up to this moment could be used (with some wrappers) with angular.
I don't think it is a good idea.
Right now no one is forcing me to use AOT, so I will avoid it as long as possible. But I'm also losing benefits of it - just because you decided to make this huge breaking change in beta.22.

@klinki What I described would only affect Angular specific reusable libraries. It would not affect jQuery or any of zillions of other reusable chunks of code which don't have any Angular specific annotations / components / etc. in them.  I'm not on the Angular team so I am not among the "you" who put in this change :-) but I think a couple of the messages here overstate the impact. The current situation is basically an accident of history, that the requirements for Angular code compatible with AOT are different than the requirements for angular code compatible with JIT. I suspect in a few more versions we will all have long forgotten that, the requirements will have been brought close enough that JIT is no big deal, routinely use, as the Angular team has had in mind for a long time. It's a big complicated thing, takes a while to accomplish the full vision.

I agree with @kylecords. This won't affect non angular libs and now anything built with the cli will be AOT compliant. I do see that it is causing some pain but I believe it to be a net good.

I am not even able to build several Anuglar 2 starter packs, because of errors like:
exported variable 'xyz' has or is using name 'Subject' from external module rxjs
which is built-in in angular 2.  Thats the thing.

I think it's much more than just momentarily inconvenient. As Angular-CLI devs we will now have to audit every open source component we bring in and ensure that they are AoT-friendly before we can use them, even if we have no interest in making an AoT app. In my experience there will be many components that will never be updated so we'll just have to skip them and try to find something else. I don't think it's the "end of angular" but it's definitely a huge hassle.

My immediate concern is that #2799 is still open, i.e. the interaction between AOT compilation and custom decorators critical to state management/side-effects solutions in two material libraries is not yet resolved.
For the first time in the beta cycle, I have held off on upgrading, i.e. from beta.21 to beta.22, as it is not self-evident to me whether said issue is exacerbated with the latest release.
So, if someone could shed some light on this particular aspect, I should be most indebted.

@deebloo

I do see that it is causing some pain but I believe it to be a net good.

For sure, idealy if everything was AOT compliant it would be nice awesome. But it sounds impossible to have every project AOT compliant. As a developer willing to give the best for my users, I'm ready to make my code AOT compliant. But some devs out here won't do that. Especially 3rd party libs. This brings me to that question :

This won't affect non angular libs

How so ? This is really something I don't understand. What are the boundaries of AOT ? Is only our code required to be AOT compliant or also the libs we use ?
Last thing is, as @tomwanzek said, there's a huge concern of introducing the obligation to have our code AOT compliant when #2799 is still opened. I tried to launch my app yesterday after making it fully AOT compliant, and as I use @ngrx/effects my app was displaying well ... But nothing was happening as most of the work is launched from effect.
I've been sticking with angular-cli since the beginning, even tho there are great starters out there that support AOT, lazy loading, hmr, etc for months. But I really like the idea behind angular-cli : Having a similar code base for every repo and making a tool common to every devs so it's easier to work on another project. I loved the decision and (huge) work done when switching from systemjs to webpack. But this time, it feels like this is a big decision with a deep impact on the community (+ existing projects) and we didn't see that coming.  Could it be possible to have an issue opened to discuss that kind of update, even before the work gets started ? I don't know if asking community opinion for big changes is something common in open source world, but it'd probably be great and constructive ! :)

@maxime1992 totally agree that it is odd to have this change in before having a fix for #2799. when I said it won't affect non angular libs I mean to say that if you are using jquery, moment, or something like that AOT doesn't affect it.

I think having it enabled by default but able to be disabled should be the mantra going forward with some of these big "flag" type changes. Also, enforcing AOT compliance only makes sense to me if Angular itself did not support JIT. Perhaps they will with Angular 3 that will be the case. If it is, then this seems be best left for a 2.0 version of the cli.

I'm currently fixing #2799, will come back later this week and definitely be in the next release.

@hansl No, those stats are production gzipped. Main/vendor decrease in size, but chunks definitely increase. For my current app at no network throttling, AoT do improve loading and rendering time. But at scale, with an app with a large set of eager and/or lazy loaded HTML, the gains of AoT could very well be offset by the increased loading time of pre-compiled HTML, especially over slow networks.

@montella1507 to fix, in general, you need to have declarations: false set in the tsconfig. @hansl unless you already know why it seems to be ignoring the tsconfig settings, I'll open a separate issue and try and track it down tonight.

I did try --aot false and still it hangs at 20% when running ng serve
hope we can get a new build soon
regards

Try 'ng build' to see some details why it's hanging. But disabling --aot didn't work for me

had same results with ng build

@born2net what were the results of your build? It still hung or...

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$ ng build
 10% building modules 3/3 modules 0 activeError encountered resolving symbol values statically. Reference to a local (non-exported) symbol 'providing'. Consider exporting the symbol (position 135:5 in the original .ts file), resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts
Error: Error encountered resolving symbol values statically. Reference to a local (non-exported) symbol 'providing'. Consider exporting the symbol (position 135:5 in the original .ts file), resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts
    at positionalError (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:595:18)
    at simplifyInContext (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:473:27)
    at StaticReflector.simplify (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:478:22)
    at StaticReflector.annotations (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:60:36)
    at AotPlugin.getNgModuleMetadata (C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:330:41)
    at AotPlugin._processNgModule (C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:271:42)
    at C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:242:39
    at process._tickCallback (internal/process/next_tick.js:103:7)

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$

let me remind that all is perfect in .21 and I wish to continue and run in JIT, as I have no interest in AOT at this point,
regards

@xmlking When I update to 2.3.0 and "awesome-typescript-loader": "3.0.0-beta.10"

for reference, error is coming from:
https://github.com/born2net/studioDashboard/blob/master/src/app/app.module.ts

@born2net does the error go away with ng build --aot=true ? Also, have you tried exporting those vars and seeing if it can build?

@born2net not relevant to this issue, but you need to export var providing. You simply declare it right now.

I can only assume a lot more people are going to face issues as they will start moving to .22.
So I went ahead and changed it to '''export var providing = ...'''
I also changed my providing to lambda from arrow function
export var providing = [CommBroker, AUTH_PROVIDERS,
    {
        provide: AppStore, useFactory: function() {
        const reducers = combineReducers({
            notify,
            appdb,
            business,
            stations,
            reseller,
            adnet,
            orders
        });
        const middlewareEnhancer = applyMiddleware(<any>thunkMiddleware);
        const isDebug = window['devToolsExtension']
        // const applyDevTools = () => isDebug ? window['devToolsExtension']() : f => f;
        // const enhancers: any = compose(middlewareEnhancer, applyDevTools());
        const enhancers: any = compose(middlewareEnhancer);
        const store = createStore(reducers, enhancers);
        return new AppStore(store);
    }, deps: []
    },
    ...

and here are the issues now.
tried both aot true / false
root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$ ng build --aot false
 10% building modules 3/3 modules 0 activeError encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts
Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts
    at simplifyInContext (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:475:23)
    at StaticReflector.simplify (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:478:22)
    at StaticReflector.annotations (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:60:36)
    at AotPlugin.getNgModuleMetadata (C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:330:41)
    at AotPlugin._processNgModule (C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:271:42)
    at C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:242:39
    at process._tickCallback (internal/process/next_tick.js:103:7)

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$ ng build --aot true
 10% building modules 3/3 modules 0 activecan't resolve module C:/msweb/studioDashboard/src/appdb/NotifyReducer.ts from C:/msweb/studioDashboard/src/appdb/NotifyReducer.ts
can't find symbol notify exported from module C:/msweb/studioDashboard/src/appdb/NotifyReducer.ts
Error: can't find symbol notify exported from module C:/msweb/studioDashboard/src/appdb/NotifyReducer.ts
    at ReflectorHost.findDeclaration (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\reflector_host.js:173:23)
    at C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\codegen.js:137:46
    at Array.forEach (native)
    at extractProgramSymbols (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\codegen.js:120:10)
    at CodeGenerator.codegen (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\codegen.js:57:29)
    at C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:210:73
    at process._tickCallback (internal/process/next_tick.js:103:7)

root@DESKTOP-VEUHFOL /cygdrive/c/msweb/studioDashboard
$

I am not even thinking AOT at this point as I am sure many things I do are not going to be compatible with AOT, for example I used private in components for members which are accessed from the template, I know these need to be public, as one example.
So really I just want to get JIT working with .22 so I can finally use --hmr which I have been waiting for, for sooo long...
but no go.
@hansl if you have a chance it would be awesome if you could use my project as a test bed for .22
(should only take few minutes to install)
git clone https://github.com/born2net/studioDashboard.git
studioDashboard
npm i

and if you can get it working with .22, I'd buy u a beer :)
tx as always,
Sean.

@born2net extract your factory into an exported function. e.g. something like
export function appStoreFactory() {
        const reducers = etc;
}

 provide: AppStore, useFactory: appStoreFactory

tx for the reply so went ahead and converted to:

export function appStoreFactory() {
    const reducers = combineReducers({
        notify,
        appdb,
        business,
        stations,
        reseller,
        adnet,
        orders
    });
    const middlewareEnhancer = applyMiddleware(<any>thunkMiddleware);
    // const isDebug = window['devToolsExtension']
    // const applyDevTools = () => isDebug ? window['devToolsExtension']() : f => f;
    // const enhancers: any = compose(middlewareEnhancer, applyDevTools());
    const enhancers: any = compose(middlewareEnhancer);
    const store = createStore(reducers, enhancers);

issue persists:
$ ng build
 10% building modules 3/3 modules 0 activeError encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts
Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts, resolving symbol AppModule in C:/msweb/studioDashboard/src/app/app.module.ts
    at simplifyInContext (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:475:23)
    at StaticReflector.simplify (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:478:22)
    at StaticReflector.annotations (C:\msweb\studioDashboard\node_modules\@angular\compiler-cli\src\static_reflector.js:60:36)
    at AotPlugin.getNgModuleMetadata (C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:330:41)
    at AotPlugin._processNgModule (C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:271:42)
    at C:\msweb\studioDashboard\node_modules\@ngtools\webpack\src\plugin.js:242:39
    at process._tickCallback (internal/process/next_tick.js:103:7)

Getting the same kind of stuff here. There should really be a way to disable the AoT plugin and just use awesome-typescript-loader or ts-loader.

I have found what causes this problem in my case:
If I understand correctly, they filter out the character ! from path, but ! is legal character in Windows path.
https://github.com/angular/angular-cli/issues/3529#issuecomment-266737336

I am also facing similar issues, How can I downgrade to the angular-cli.

npm install<EMAIL_ADDRESS>and
npm install<EMAIL_ADDRESS>-g

still open on beta.23?

It looks like beta.23 is not yet published to npm.
I'll check if this works when new version will be avabile

@kucharzyk  yeah.. i tried to installl latest version via NPM install Git../tarball/master but i have got tons of errors, so this is propably not the correct way.. so we have to wait :-( i am waiting for that because ngrx/effects are greta, but they use decorators, and they are stripped down in current CLI versions.

looks like this is affecting hmr usage too, now it does full reload on lazy-loaded components...

@hansl  do you evide some problems with HMR on 22-1 and lazy routes already? or shall i create an issues with minimal repo?

Adding the AoT related issue(s) to the "breaking changes" section in the changelog would probably save some people trouble.

To be clear -- is this a bug as far as the team is concerned, or is this how the cli will be compiling from beta 22 onward?
That is to say:

An angular-cli project (and all of it's dependencies) must be AoT ready, even if the developer has no desire to use AoT compilation
The --aot flag now controls whether the project will be precompiled, but will not disable the checks for AoT-compliance

I'd like to upgrade because of the speed improvements that have been made, but my project relies on some 3rd party libs that aren't AoT-ready.

@rosslavery Pretty much. We're always looking for feedback, and we are really aware of the vacuum right now for developing AOT-compatible libraries.
Give us the libraries that are not AOT compliant and we can contact them. We have a great developer relations team that can help those libraries move onto supporting AOT (every library developer I've met wants to, they just often don't know how or it isn't clear).

AFAIK the issues are beyond just AOT, as just running static methods forRoot is causing issues.
and for what its worth, I believe we should continue and support --aot false as some projects I am working on have already been released and rely on CLI.

@born2net the issue that a lot of libs that have a forRoot method are having is that somewhere in that forRoot method they are doing something that isn't statically analyzable.

@deebloo that's what I thought, but I double checked and mine is failing even if my forRoot does nothing at all... I opened a bug and provided access to project to @hansl but no status yet
regards

material2 has a forRoot (and is currently buggy and cumbersome for AoT).

I can confirm forRoot does not work...

I can confirm that forRoot does work. Been using it in my lib and it works with no issues.

Closing this as obsolete. We've been enforcing static analysis since Beta 22 now.


Force us to use web-animations-js#1.0.8

The web-animations library was broken due to
https://bugs.chromium.org/p/chromium/issues/detail?id=601672
With this change, we will use a version of the library that has been
backported with the fix.
Fixes #2465

This change is

:+1:


Non existing links to pages in organizations/projects/toc.yml

Hi,
Sorry if the format of the issue isn't as it should be. I couldn't find the rules of it.
I found an issue while navigating through the docs. I received an 404 on "Set project visibility" and on "Change service visibility". By further diving in to it, I found the file and the issue:
organizations/projects/toc.yml
line: 22 and 24.
The paths are non-existing in the repo (maybe deleted).

@WilliamAntonRohm -- You can see the issue when navigating to https://docs.microsoft.com/en-us/azure/devops/organizations/projects/restore-project?view=azure-devops (for example).
Then using the menu to go to "Set project visibility" or "Change service visibility":

I hope you can do something with this information.

@MitchelVreman -- Mitchel, thank you for your feedback.
@chcomley -- please let me know the new target paths, or whether these links should be deleted, and I will update toc.yml appropriately.

Hi @MitchelVreman, I've published an update fixing the TOC issue, which should be live momentarily. Thanks very much for letting us know about this!


fix fix presto dialect regression-test case

Proposed changes
disable the unavailable sql of presto dialect

run buildall


Running scenes process won't close

When hitting run in the editor, a new process appears and the preview window shows up. but when than window is closed, or the stop button is hit in the editor, the process remains
 I'm using xubuntu 14.04 and everything else in the OS seems fine

Is this issue still valid in the current master branch?

I can't seem to reproduce it here on Linux by monitoring the processes in ktop. I do get a zombie when quickly switch from an opened project to the project list and then into a different project, but it quickly gets cleaned up and in the end I still have only one process.

It's already fixed


Use lowercase resource and owner names when storing assets on disk

This will store models and worlds using lowercase name and owner.
I've done the following tests:

Run SubT worlds with an existing cache that has capitalization. Result: nothing new is downloaded, and the worlds run.
Run SubT world with some models missing from the cache. Result: new models are downloaded to all lowercase directories.
Run worlds with random capitalization in model URIs. Result: utilizes existing cache, or downloads new resources.
Download a collection, such as ign fuel download -v 4 -j 8 -u "https://fuel.ignitionrobotics.org/OpenRobotics/collections/SubT Tech Repo". Result: This will download all the models using lowercase.
If there is a model is two places, such as OpenRobotics/models/X1 Config 1 and openrobotics/x1 config 1, then the lower case version will be used.

I think this won't break anyone, and Ignition Gazebo should still use an existing cache even if the cache has capitalization.
Signed-off-by: Nate Koenig<EMAIL_ADDRESS>

I think this is causing the INTEGRATION_sdf_include and INTEGRATION_log_systems tests to fail in ign-gazebo3


Notification screen is very hard to read

Couldn't see this issue open yet.
Platform: Windows 10
Version: 1.4.6
The way it is at the moment on the notification screen, to see unread notification you must look for the little circular icons coloured in, that can be hard to read sometimes. Would be better to have the notification row text as bold or make it stand out in someway (a little like the devRant official android app) so that it is more readable.

We're planning on adding filters just like in the devRant app :)

@RekkyRek Great, that's nice to hear! I think that instead of having a transparent background for the notification screen it would be useful to have a card sort of layout where each notification row is opaque, and then make a way for unread notifications to stand out.
Also would help to make the notification bell in the top right larger with a larger unread counter.
Other than that the app is great and I'm really enjoying using it.

@redrails thanks for the feedback. We will take them in consideration :)

It seems like you're having a problem with everything being too small. Have you tried going into the settings and adjusting the zoom level? That might help a bit while we work on the new update 🙂

@RekkyRek I am using the zoom level slider but I think in proportion to the text the notification button is kind of small with smaller text. I don't want it to be the case that the text is really big just for a small thing like that, could just be my personal opinion though, not sure what others think of this!


How to use a white space as separator in command line arguments?

Hi. I want to pass config values as command line arguments in this form:
--myarg 3
and I expect the config to look like this:
{
  "myarg": "3"
}

I tried using settingSplitters = {" "}; but that didn't work. How can I achieve the desired behavior? Thank you.

Hello, unfortunately this is not possible in this version of the library, I will try to add this possibility in next versions, for sure it would be useful in many cases

Hi, since version 1.2.0 it is possible to use whitespace separatore in the options passed to command line and it is enabled by default (setting prefix is required in this case)
--myarg 3 or /myarg 3 would create config
{   "myarg": "3" }


ttyd should ask again for user:password when the browser window is closed.

Hi,
I've noticed that if I close my browser window or if I refresh it, ttyd does not ask again for my credentials. It does if I close my browser (Firefox) or if I change my htpasswd.
Is it possible to add this feature ?
I'm using Apache with the following :

RewriteEngine On
RewriteRule .* - [E=PROXY_USER:%{LA-U:REMOTE_USER},NS]
RequestHeader set X-WEBAUTH-USER "%{PROXY_USER}e"
ProxyRequests Off
RequestHeader unset Authorization
<Location /ttyd/>
AuthType Basic
AuthName ttyd
    AuthBasicProvider file
    AuthUserFile /etc/ttyd/ttyd_htpasswd
    Require valid-user
Order allow,deny
Allow from all
ProxyPass unix:/tmp/ttyd.sock|http://<IP_ADDRESS>:7681/
ProxyPassReverse unix:/tmp/ttyd.sock|http://<IP_ADDRESS>:7681/
</Location>

<Location /ttyd/ws>
Order allow,deny
Allow from all
ProxyPass unix:/tmp/ttyd.sock|ws://<IP_ADDRESS>:7681/ws
ProxyPassReverse unix:/tmp/ttyd.sock|ws://<IP_ADDRESS>:7681/ws
</Location>

I'm running systemd with the following :
/mnt/Softs/bin/ttyd.x86_64 -i /tmp/ttyd.sock -H X-WEBAUTH-USER -w /home/ttyd tcsh
Regards.
Xuo.

basic auth cred is cached by browser session, it 's not what ttyd can control.


make header configurable

Hi! Thanks for the great sphinx extension. I needed a way to configure the header and the number of columns, so here's the PR! :smiley:
example.rst
.. documentedlist::
    :listobject: foo.lst
    :header: Surname "Given Name" Email

foo.py
lst = [
    ["John", "Doe"<EMAIL_ADDRESS>]

Result

Surname
Given Name
Email

John
Doe
<EMAIL_ADDRESS>

Merged. I'll propagate the changes to pypi and sphinxcontrib over the next few hours. Thanks!

Awesome. Thanks a lot!

Version bumped to 0.2 on pypi and sphinxcontrib (bitbucket) with configurable header support.

Aaaand it's in production. Thanks for the awesomely quick response time! :smiley:


Add format of audit log streaming for GHEC

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/enterprise-cloud@latest/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/streaming-the-audit-log-for-your-enterprise#about-audit-log-streaming
What part(s) of the article would you like to see updated?
Add a note about JSON format of logs. Brought on by customer ticket: https://github.zendesk.com/agent/tickets/1972917
Additional information
No response

PR for changes: https://github.com/github/docs/pull/23333

👋 @adamrr724 - Thanks for opening an issue and connecting it with your PR ✨


[Report] Print Issues & TextFile

Robocop reports issues by printing them to stdout using format string. Its also possible to use --output to redirect those prints to opened file.
We should reuse existing architecture and reimplement printing issues in a report: Print Issues. Additionaly, printing issues should be handled by another optional report, TextFile.
Print Issues should be default report. It should be possible to disable it (by configuring report or using --silent flag). The output should be improved:
By default Print Issues should use 'enhanced' format, similar to ruff check. It will print the code with the issue with small marging and pin point where the problem is (<todo: insert example>).
Other format will be 'simple' - the same as before.
TextFile should be able to save output of all other reports that prints something to the file. Or at least save the reported issues.

Additional output mode:
grouped
tests\linter\utils\test_version_matching.py:
  37:28 ANN001 Missing type annotation for function argument `robot_version`
  37:43 ANN001 Missing type annotation for function argument `rule_version`
  37:57 ANN001 Missing type annotation for function argument `should_pass`

Robocop prints issues at is goes. Hovewer for better support for grouped mode, and additionaly project checker rules (which shows up after we finish other scans) we may first collect all issues and then print them.
In case of big projects it can delay output, but it may not matter because in such cases you often get many issues that move screen fast, so it's not readable anyway. Additional user tests will be required to verify this claim.


Preheat timer display broken after model learning

The time at which the timer was stopped appears to flicker in after an early timer stop. Hard to reproduce. May be related to not updating temp during timer after snoozing. May be related to #31 .

Can no longer reproduce, so maybe it's fixed?

Reproducing:

choose a model with no measurements but learning turned on
snooze timer from notification
while snoozing, click 'done'
click 'learn'


Corrected README in Angular-Debugging Recipe

Corrected the README.md file to reflect that the browser is launched when debugging is started and that the browser then needs to be refreshed.

Forgot to create a new branch, so I'm closing this PR and opening a new one.


Download App Settings as a .env and Upload local .env files as App Settings

Fixes https://github.com/Microsoft/vscode-azureappservice/issues/639
I'll add dotenv to the thirdparty website after it is approved.
I need some help (probably from @fiveisprime) for the wording here.  These aren't exactly local settings and app settings.  While .env files are local, they are environment variables.  When the user uploads their local env vars to app settings, what should I refer to them as??  The titles on the commands are just placeholder for now.

What about import/export instead of upload/download? I'm not sold on that.. I kind of like upload/download because it makes it clear what the target is based on the language whereas import/export is generic enough to be confusing. :(
It should either be "App Settings" or "Application Settings." though for sure

In Functions, we use the language "Download Remote Settings" and "Upload Local Settings".  Should we just keep it consistent?

Yeah, just follow the Functions pattern for now.

Relies on PR https://github.com/Microsoft/vscode-azuretools/pull/357


Support for installation of fonts

Description of the new feature/enhancement
As part of a new system build, I typically install a handful of fonts including Cascadia Code and other powerline enabled fonts. These fonts don't have an installer associated with them but instead need to be manually downloaded, extracted, and installed.
https://github.com/microsoft/cascadia-code/releases

Alternately, maybe just installing a font manager like FontBase or SkyFonts would work just as well without adding specific font-related features to winget. You'd have to sign into those though.

Be sure to enable installing a font as a non-admin user!

Installing a CLI font manager might be acceptable.

Related: https://github.com/JetBrains/JetBrainsMono/issues/260

Neither are needed. All that's needed is for the font to be uninstalled first, then the updated version is installed after. Some apps or stuff in Windows will need a font-fallback during this process if they're configured to use that font. So winget just needs to support the unattended uninstallation and installation of the font.

font support is not needed. install / uninstall script execution would not only allow the package to install/uninstall fonts, but install standalone apps (utilities) from zip, rar, 7zip, etc etc... even configure windows further than just fonts. we already trust that apps installed from the microsoft winget package repo are trusted so i don't see an issue with arbitrary scripts executing. they will be vetted when submitted to the MS pkg repo.

Adding the link to Cascadia Code.

Because the Microsoft Store is able to manage this already, implementation of this feature is important for compatibility with it. This was the purpose of the addition of the "msstore" repository also.

Hey everyone oh-my-posh by @JanDeDobbeleer now has support for installing nerd fonts.

Hey everyone oh-my-posh by @JanDeDobbeleer now has support for installing nerd fonts.

How does that relate to winget?

I assume there are Windows Package Manager users who are generally interested in being able to install fonts with a CLI. As we haven't sequenced when this feature might land, I was trying to be helpful for the community by offering one possible solution that could be used "today".

This would be a great feature to have. I use OhMyPosh so I'll use that workaround for now.

I've started a discussion on fonts. Please don't add any additional comments to this Issue to avoid the large number of people who receive e-mail notifications.


How to navigate

In the drawer (Picked from react-native-material-ui-demo-app) i see:
renderToolbar = () => {
return (
<Toolbar
key="toolbar"
leftElement="menu"
onLeftElementPress={() => this.props.navigation.goBack()}
centerElement="Home"
/>
);
}
But I want to open the drawer. Do you have an example code how to open the drawer and how to navigate

It is more react-navigation question, rather than react-native-material-ui.
I'd like to suggest you to read article of RN skeleton by Kevin Le in
https://medium.com/@kevinle/comprehensive-routing-and-navigation-in-react-native-made-easy-6383e6cdc293
I learn lot from it.


alamofire complains about argument type

I asked a question in stackflow tagged with "alamofire", could you help me with that?
http://stackoverflow.com/questions/31932792/alamofire-complains-about-argument-type

Answered on Stack Overflow.


fix(abigen): add resolver error factories in generated wrappers via companion object init

Description
If contract abi has only one custom error, the generated code would produce compilation error.

Solution
Moved registration of generated errors to companion object "init" block.
closes #40

Current dependencies on/for this PR:

master

PR #41   👈

This stack of pull requests is managed by Graphite.


ROOT latest version compilation fail

There is a problem with the latest version of ROOT.
The example compiles and works perfectly with ROOT v6-20-06, but with the latest v6-24-02 it returns an error during compilation
[ 50%] Building CXX object CMakeFiles/GenericToolboxExample.dir/example/main.cpp.o
In file included from ***/cpp-generic-toolbox/example/main.cpp:12:
In file included from ***/cpp-generic-toolbox/./include/GenericToolbox.Root.h:82:
***/cpp-generic-toolbox/./include/implementation/GenericToolbox.Root.impl.h:288:11: error: variable 'cwd' with type 'auto *' has incompatible initializer of type 'ROOT::Internal::TDirectoryAtomicAdapter'
    auto* cwd = gDirectory;
          ^     ~~~~~~~~~~
1 error generated.

That happens for me on Mac with clang-1<IP_ADDRESS>
Observed both on master and v2.1.0

Hey ;)
Thanks for the repport!
I'm gonna see what happen with the new version of ROOT. In fact I would have expected gDirectory to be a pointer, but it seems it's not the case...
Keep you informed :)

Fixed: https://github.com/nadrino/cpp-generic-toolbox/commit/19d5d5fb9135d18309a0ef42a2714b89022fd3bc
Cheers ;)


Not able to install any boilerplate

What's going on?
I run ignite new my-app.
Select Bowser(alpha) or an old boilerplate (typescript) from the list of boilerplates
It adds the Infinite red
Goes to add React Native 0.55, in the typescript boilerplate it is 0.51 and just fails
Steps to reproduce
same as above
ignite doctor results:
System
platform           darwin
arch               x64
cpu                4 cores       Intel(R) Core(TM) i5-4308U CPU @ 2.80GHz
directory          /Users/hari
JavaScript
node               8.10.0       /usr/local/bin/node
npm                5.8.0        /usr/local/bin/npm
yarn               1.6.0        /usr/local/bin/yarn
React Native
react-native-cli   2.0.1
Ignite
ignite             2.1.0        /usr/local/bin/ignite
Android
java               1.8.0_161    /usr/bin/java
android home       -            /Users/hari/Library/Android/sdk
iOS
xcode              9.2
Something related to navigation issue? 1225?

@shriharip What's the error you're seeing?

On add react native (30 secondsish). It just fails and gives message saying 'could not add react native'.

Are you able to react-native init MyProject?

hi,
I wanted to take a video of what was happening to better explain but it was working this time :).
I ran the react-native run ios and android commands, and on android it loaded perfectly but on iOS I had the below problem.


fpdf: introduce buffer pool for (de)flating buffers

name              old time/op    new time/op    delta
ParsePNG_rgb-8      22.8ms ± 1%    16.0ms ± 3%  -29.81%  (p=0.000 n=25+30)
ParsePNG_gray-8      660µs ± 3%     624µs ± 4%   -5.54%  (p=0.000 n=28+30)
ParsePNG_small-8    2.49µs ± 2%    2.12µs ± 3%  -14.83%  (p=0.000 n=30+30)
ParseJPG-8          36.3µs ± 4%    36.8µs ± 5%     ~     (p=0.070 n=30+30)
ParseGIF-8           410µs ± 3%     409µs ± 4%     ~     (p=0.562 n=30+29)

name              old alloc/op   new alloc/op   delta
ParsePNG_rgb-8      26.4MB ± 0%     4.2MB ±10%  -84.04%  (p=0.000 n=29+30)
ParsePNG_gray-8     2.56MB ± 0%    2.49MB ± 0%   -2.73%  (p=0.000 n=30+30)
ParsePNG_small-8    8.96kB ± 0%    9.84kB ± 0%   +9.73%  (p=0.000 n=30+30)
ParseJPG-8           274kB ± 0%     274kB ± 0%   -0.00%  (p=0.002 n=30+30)
ParseGIF-8           897kB ± 0%     898kB ± 0%   +0.10%  (p=0.000 n=30+30)

name              old allocs/op  new allocs/op  delta
ParsePNG_rgb-8         400 ± 0%       292 ± 0%  -27.00%  (p=0.000 n=30+28)
ParsePNG_gray-8        164 ± 0%       114 ± 0%  -30.49%  (p=0.000 n=30+30)
ParsePNG_small-8      35.0 ± 0%      10.0 ± 0%  -71.43%  (p=0.000 n=30+30)
ParseJPG-8            12.0 ± 0%      12.0 ± 0%     ~     (all equal)
ParseGIF-8             214 ± 0%       191 ± 0%  -10.75%  (p=0.000 n=30+30)

Codecov Report

Merging #8 (fc0b6fc) into main (0532bfd) will decrease coverage by 0.00%.
The diff coverage is 77.48%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   79.26%   79.25%   -0.01%
==========================================
  Files          29       32       +3
  Lines        5459     5524      +65
==========================================
+ Hits         4327     4378      +51
- Misses        817      827      +10
- Partials      315      319       +4

Impacted Files
Coverage Δ

util.go
72.82% <ø> (+0.18%)
:arrow_up:

template.go
79.31% <20.00%> (-1.94%)
:arrow_down:

fpdf.go
82.08% <60.00%> (ø)

xcompr.go
67.64% <67.64%> (ø)

rbuf.go
73.33% <73.33%> (ø)

png.go
78.66% <91.80%> (+3.28%)
:arrow_up:

attachments.go
92.72% <100.00%> (+0.27%)
:arrow_up:

wbuf.go
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0532bfd...fc0b6fc. Read the comment docs.


[Navigation Animation] No API to handle unhandled deeplinks, navigates to a random destination

Description
There is no way to deal with unhandled / not found deeplinks in the library. Upon encountering an unhandled deeplink, the app navigates to a random screen, probably the one that got added to the graph last.
Regular compose navigation allows to provide a onDeepLinkRequest block in the NavHost composable. What's the replacement for the animated accompanist navigator?
Steps to reproduce

Define multiple destinations
Try to open a deeplink for which a route is not found
Random destination is opened

Expected behavior
An app allows to specify a route to take for unhandled deeplinks and / or a custom logic
Additional context
Accompanist 0.31.0-alpha

onDeepLinkRequest block in the NavHost composable.

This isn't a thing.

the app navigates to a random screen, probably the one that got added to the graph last.

If there is no valid deep link to handle, nothing gets navigated to. If you're following the documentation and always using the default launchMode of standard, then you'll be on the start destination of your app, just as if your app was opened from the launcher icon.

An app allows to specify a route to take for unhandled deeplinks and / or a custom logic

This is exactly what the existing feature request is for. Feel free to star that feature request to follow along.

Thanks for the answer. onDeepLinkRequest is not a thing, the AI tricked me! Sorry for the confusion.


GH-36954: [Python] Add more FlightInfo / FlightEndpoint attributes

Rationale for this change
The C++ classes FlightInfo and FlightEndpoint have attributes that are not available via the Python API.
What changes are included in this PR?
Make the following attributes available in Python:

FlightInfo.ordered
FlightInfo.app_metadata
FlightEndpoint.expiration_time
FlightEndpoint.app_metadata

Also makes existing attributes optional in constructor:

FlightInfo.total_records
FlightInfo.total_bytes

Are these changes tested?
Existing tests that test existing attributes are extended.
Are there any user-facing changes?
Yes, changes are backward compatible.

GitHub Issue: #36954

Any suggestion how to fix the macOS compile error?
I think I have to cast the time_point produced via TimePoint_from_ns to the system clock precision std::chrono::system_clock::duration, preferably via std::chrono::time_point_cast<system_clock, system_clock::duration>, but I cannot get this done in Cython words.
Any help appreciated.

Sorry @EnricoMi, I wanted to push to my fork but default pointed here. Reverted.

It looks like all the review comments have been addressed on this, are there any more changes required? @jorisvandenbossche?

@EnricoMi I don't think this has to be held up so much. Would you mind rebasing again to make sure CI hasn't bitrotted and then I think we can merge?

@lidavidm thanks!

Fixing the Timestamp type in C++ and reverting the workaround of this PR is done in #44681.


Mac Silicon OSX 13, seems to not work

cant get HAP to install on latest MAC

Please don't cross-post issues. This project is for the Hap format and not for any user-installable products.

Tom, where should we post Hap CODEC installation issues? thanks, Benton

There are many Hap encoders and decoders, mostly commercial, some open-source. Which one are you having issues with?

Tom, I'm trying to install the version that comes with VDMX - thus I thought Vidvox/hap/issues was the right thread?
macOS 12.5.1
MacBook Pro (14-inch, 2021)
Apple M1 Max
VDMX version b<IP_ADDRESS>.0

Thanks Tom, thanks Dave - I just installed VDMX Version b<IP_ADDRESS>.5 and the AVF Batch Converter and Hap is working fine now!


docs: fix broken links

reported here https://discord.com/channels/927474939156643850/927866047757959189/1003626639395139584


THRIFT-4373: Derefer PHP zval _TSPEC

If we want process REFERENCE everywhere.
I think we should review every line of zval used, is it?

@RobberPhex how does this look now? I don't have lots of context for other zval values so I'd leave that for another review.

@RobberPhex  Any word on getting this merged?  Using the extension in PHP 7.0 is kinda broken otherwise... this is fixing a common issue that affected many PHP extensions moving to PHP 7.0.


Remove thiserror from risc0-zkp

Fix for #694

Have you considered instead of out right removing thiserror to create a std and no_std option?
For example in code that I want to support no_std environments I would add:
[features]
default = ["std"]
std = ["thiserror"]

[dependencies]
thiserror = { version = "1.0.40", optional = true}

And then I would use the std features like so:
#![cfg_attr(not(feature = "std"), no_std)]

#[cfg(not(feature = "std"))]
extern crate alloc;

#[cfg(feature = "std")]
use thiserror::Error;

#[derive(Debug, PartialEq)]
#[cfg_attr(feature = "std", derive(Error))]
pub enum CustomError {
    /// The Prover was unable to construct a proof with your given inputs
    #[cfg_attr(
        feature = "std",
        error("The prover was unable to construct a proof with your given inputs")
    )]
    UnableToProve,
}

@Brando753 I'd like to have support for error messages in no_std as well. It's not much boilerplate and if it becomes onerous we could switch to snafu.

Understood; looking over the changes, it's not that bad. If you don't have too many error structs, then it's probably not worth worrying about. I don't see the no_std crate attribute. Are you planning to add that?

Understood; looking over the changes, it's not that bad. If you don't have too many error structs, then it's probably not worth worrying about. I don't see the no_std crate attribute. Are you planning to add that?

See: https://github.com/risc0/risc0/blob/main/risc0/zkp/src/lib.rs#L16


Investigate a full docker-in-docker script

Currently the docker-from-docker definitions and docker library script use the host's container engine from inside the container by forwarding the docker socket. The downside with this approach is limitations around bind mounts - which can be scenario blocking in some cases.
While generally docker-in-docker isn't really recommended in most cases, it is worth understanding how easy it would be to create an alternate script that sets up full docker in a container (or just moby) - downsides aside.

This was merged with #702 and will be used by the default codespaces image once deplyed in addition to the new docker-in-docker definition.

This was merged with #702 and will be used by the default codespaces image once deplyed in addition to the new docker-in-docker definition.


Global illumination on Intel Arc GPU's broken

Tested versions
4.3 stable
System information
Windows 11
Issue description
Turning on global illumination blows out every material with some roughness.
I've already created an issue ticket on it on the original repo: https://github.com/godotengine/godot/issues/90277. There's long thread with images, videos .etc describing the issue.
Steps to reproduce
Please see original issue
Minimal reproduction project (MRP)
MRP project can be downloaded in the original issue:

SDFGI is being replaced in Godot by HDDAGI, and isn't getting any attention.
Due to the complexity of SDFGI it requires Experienced Rendering Developers to maintain, so it's unlikely to be fixed in Redot, and will most likely follow Godot in adopting HDDAGI once it comes out.

Yeah.. this seems to work better in HDDAGI (as I've tested). But that effort seems to move forward very slowly and seems to be worked on when Juan feels like it. So there's no knowing if HDDAGI will be implemented anytime soon even though it's been promoted.
One can hope for a Rendering expert with experience to join the team.

Basically HDDAGI got left behind in the last feature freeze, and more pressing matters got prioritized for the next release aimed at improving VFX, Lightmaps, and Performance optimizations, as well as further exposing Rendering to the User

#1
#2
#3
#4
#5
#6
#7
#8
#9
#10
#11
#12
#13
#14
#15
#16
#17
#18
#19
#20
#21
#22
#23
#24
#25
#26
#27
#28
#29
#30
#31
#32
#33
#34
#35
#36
#37
#38
#39
#40
#41
#42
#43
#44
#45
#46
#47
#48
#49
#50
#51
#52
#53
#54
#55
#56
#57
#58
#59
#60
#61
#62
#63
#64
#65
#66
#67
#68
#69
#70
#71
#72
#73
#74
#75
#76
#77
#78
#79
#80
#81
#82
#83
#84
#85
#86
#87
#88
#89
#90
#91
#92
#93
#94
#95
#96
#97
#98
#99
#100
#101
#102
#103
#104
#105
#106
#107
#108
#109
#110
#111
#112
#113
#114
#115
#116
#117
#118
#119
#120
#121
#122
#123
#124
#125
#126
#127
#128
#129
#130
#131
#132
#133
#134
#135
#136
#137
#138
#139
#140
#141
#142
#143
#144
#145
#146
#147
#148
#149
#150
#151
#152
#153
#154
#155
#156
#157
#158
#159
#160
#161
#162
#163
#164
#165
#166
#167
#168
#169
#170
#171
#172
#173
#174
#175
#176
#177
#178
#179
#180
#181
#182
#183
#184
#185
#186
#187
#188
#189
#190
#191
#192
#193
#194
#195
#196
#197
#198
#199
#200
#201
#202
#203
#204
#205
#206

Yeah.. this seems to work better in HDDAGI (as I've tested). But that effort seems to move forward very slowly and seems to be worked on when Juan feels like it. So there's no knowing if HDDAGI will be implemented anytime soon even though it's been promoted.
One can hope for a Rendering expert with experience to join the team.

HDDAGI is taking time due to the goal of it reaching at lumen level render. It not yet there, it still need alot of time to clear or correct all error present in sdfgi. So don't say it when Juan feels like doing it. You could follow the progress on the pull request on their github. They have reached 3 main target out of 5. It mostly latency and ray directions issues that present. If the redot team want to implement their own they could look at what flax engine has implemented.

HDDAGI is taking time due to the goal of it reaching at lumen level render. It not yet there, it still need alot of time to clear or correct all error present in sdfgi. So don't say it when Juan feels like doing it. You could follow the progress on the pull request on their github. They have reached 3 main target out of 5. It mostly latency and ray directions issues that present. If the redot team want to implement their own they could look at what flax engine has implemented.

I am actually following the progress quite closely on what's happening on GitHub (since I'm very interested in having this fixed for the GPU I'm currently using and would prefer to be supported for the commercial project I'm working on). My comment wasn't meant to be offensive, but more an observation that he has a lot on his table, and I'm not sure this is a priority to him, and I haven't seen any progress on this for a long time (doesn't necessarily mean it's not being worked on. But there is no way for an outsider to know if progress is not shown)
Either way. This ticket is not about HDDAGI, it's about fixing the issue with a specific GPU. And if HDDAGI fixes that, that's great. And again, I have no idea when that's going to happen. And I suspect HDDAGI (especially with the ambition you mention) is a much bigger project than fixing the GPU support.

why are you reporting real bugs here? the guy who made this fork can't code or fix them. report them to the real project

it is still being worked on, this is from a report that's like 2 and a half weeks old
https://godotengine.org/article/rendering-priorities-september-2024/
You can see typically what contributors are discussing in meetings every week on https://files.godot.foundation/s/kdJ9ekAZZnQsFeM
There if you scroll down to 23.7. you'll see they discussed long term plans (6 months -2 years) and HDDAGI is there

@mrjustaguy oh, you're getting confused. those are posts about the real project, which is actually developing a game engine. you're posting on a fake grievance fork made by (and for) various forms of idiot. maybe repost on the real project 🫶🏽


Update API links

@NextTurn : Thanks for your contribution! The author, @erhopf, has been notified to review your proposed change.

#sign-off


[Fix #5615] Fix false positive Rails/FilePath when using File::SEPARATOR string

Fixes #5615.
This PR fixes a false positive in Rails/FilePath cop when using File::SEPARATOR string (e.g. '/') without Rails.root.join.
This regression was due to #5461.
Since this is a regression for changes that have not yet been released, it is not described in CHANGELOG.md.
Cc @bquorning

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

The reported problem is fixed by your change.
But checking for special characters in node.children.last.source seems flaky. I don’t know that the last child is special, or that the . and / are the only special characters to check for.


multiplatform error declaring expect function

Describe the bug
@Composable
expect fun PlatformButton(
    onClick: () -> Unit,
    interactionSource: MutableInteractionSource = MutableInteractionSource(),
    content: @Composable RowScope.() -> Unit
)

this compiles without error but when I Use the remember package MutableInteractionSource(), build error occurs.
@Composable
expect fun PlatformButton(
    onClick: () -> Unit,
    interactionSource: MutableInteractionSource = remember { MutableInteractionSource() },
    content: @Composable RowScope.() -> Unit
)

error :
java.lang.Exception: IR lowering failed at: PlatformButton.kt
at androidx.compose.compiler.plugins.kotlin.lower.ComposableFunctionBodyTransformer.visitFile
Affected platforms
Select one of the platforms below:

Desktop

If the bug is Android-only, report it in the Jetpack Compose tracker
Versions

Kotlin version 1.8.0:
Compose Multiplatform version*: 1.3.0
OS version(s)* (required for Desktop and iOS issues):  window11
OS architecture (x86 or arm64): x86
JDK (for desktop issues): openjdk 17

To Reproduce
Steps and/or the code snippet to reproduce the behavior:
Compile this code

@wwalkingg Thanks for a bug report!
We know this issue.
One possible workaround is to make overload function:
@Composable
expect fun PlatformButton(
    onClick: () -> Unit,
    interactionSource: MutableInteractionSource,
    content: @Composable RowScope.() -> Unit
)

@Composable
fun PlatformButton(
    onClick: () -> Unit,
    content: @Composable RowScope.() -> Unit,
) = PlatformButton(
    onClick = onClick,
    interactionSource = remember { MutableInteractionSource() },
    content = content,
)

Initial issue here: https://github.com/JetBrains/compose-jb/issues/2806

Reproduce here: https://github.com/dima-avdeev-jb/reproduce-issues-2816

Reproduce here: https://github.com/dima-avdeev-jb/reproduce-issues-2816

This can help me skip compile error. I think this issue should be the highest priority.

Fixed in 1.4.0 if used with kotlin 1.8.20

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Formatted Markdown renders to different HTML than the input (unknown why)

Describe the bug
context
When I run mdformat on my markdown file, I get the following:
Error: Could not format "-".

The formatted Markdown renders to different HTML than the input Markdown. This
is likely a bug in mdformat. Please create an issue report here, including the
input Markdown: https://github.com/executablebooks/mdformat/issues

I'm editing a document from an open source project, and they use mdformat, so I suspect it's related to my changes, but I can't tell why.  Is there a way to force mdformat to emit the formatted markdown so I can 'diff' it?  An example of the kind of changes I've made are included below:

<div class="tabbed-blocks">

```python
(
    df.lazy()
    .filter(pl.col("sepal_length") > 5)
    .groupby("species")
    .agg(pl.all().sum())
    .collect()
)
```

```rust,noplayground
let df = df
    .lazy()
    .filter(col("sepal_length").gt(5))
    .groupby([col("species")])
    .agg([col("*" ).sum()])
    .collect()?;
```
</div>

I've added the <div> tags and the second code block.  This renders in the book as a tabbed code block that lets you select which language you want to see.  Formerly, it was just Python.
expectation
I expected mdformat to format the markdown in a non-changing way.  And, failing that, tell me what changes were made.  Maybe when this bug happens you could run both copies into diff so that we can have a clue what happened?  This way we might be able to come up with workarounds on our own?
bug
The formatted markdown apparently renders to different html than input.
Error: Could not format "-".

The formatted Markdown renders to different HTML than the input Markdown. This
is likely a bug in mdformat. Please create an issue report here, including the
input Markdown: https://github.com/executablebooks/mdformat/issues

problem
This is a problem because the upstream project runs mdformat in CI, and the jobs are failing.
Reproduce the bug
mdformat into.md
intro.md
List your environment
mdformat --version
mdformat 0.7.5

macos 12.4

python 3.10.4

Hi, thanks for the issue!
You're running a relatively old mdformat version. I recommend trying with the latest release.
The snippet you provided seems to format fine with mdformat versions 0.7.5 and 0.7.14. Would you be able to provide me with full unedited/uncut input so that I can reproduce the error?

Is there a way to force mdformat to emit the formatted markdown so I can 'diff' it?

Currently no, unfortunatley. There's an open issue for this though.

Sure enough!  I updated the requirements.txt for the project and it seems to be addressed.  Thanks for checking!


feat: add diabetes Federated Analytics example

@SdgJlbl I can't find the example on the doc built by RTD: https://owkin-substra-documentation--282.com.readthedocs.build/en/282/auto_examples/index.html

I think we need to change the way we are structuring example folders slightly if we want to display more than one example per page 🤔

I'm still not totally happy with it, but I think it's in a good enough state to get a first review.


MODBULKOPS-314 - update permissions

Purpose
Describe the purpose of the pull request.
MODBULKOPS-314 - Central tenant edit permissions handling
Approach
How does this change fulfill the purpose?
TODOS and Open Questions

[ ] Use GitHub checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.


Add trace_tcp image based gadget

Hello,
This PR adds trace_tcp as image based gadget.
Feedback for fixing tests is welcome.
Resolves #2372
Thank you!

LGTM. Thanks for working on this!

Thank you as well for the valuable feedback!


feat: modularize python notebooks

factor out common configuration logic into separate files
reduce code complexity in notebook files
minor updates to logging, make it configurable for dataset uploads
add several endpoint notebooks

The changes here represent the format that I propose for all endpoints. Shared code for determining the API url base and setting access token is consolidated into easy-to-use functions, as are the basic endpoint functionalities.
By maintaining separate notebooks for each functionality, the curator is able to easily focus on and experiment with a single endpoint. By confining business-logic scaffolding to .py files that do not need to be edited or even understood by curators, we drastically reduce the cognitive complexity of their interactions with the notebooks; subsequent notebooks can be only a dozen lines of code but achieve private Collection creation, revision, editing, Dataset upload, and deletion, thereby allowing curators to build workflows in very little time with consistent, reliable results.
A hybrid of notebook + client library approach.

I'm going to refactor these to classes, seems most appropriate.

There's a few actions/endpoints not represented here (e.g. checking for dataset status after uploading), is that in scope as a follow-up if this structure is approved?

Yes, precisely!! 🦾


SEA Vendor Update

About the PR
SEATech now has 6 training grenades.
The SEA uniform vendor now has the option for the service jacket.
The SEA Weapon Vendor now has the M63, Shotgun, the attached ammo, the bipod, and reddot sight.
Why / Balance
Some of it (Jacket and reddot) is parity however:
SEAs are currently unable to train people how how to use grenades without asking admins or risking using live grenades. They will now be able to teach cadets how to use GLs and even just standard throwing.
The M63 and Shotgun were added due to the severe lack of options, now instead of being forced to steal they may just use it. The bipod is to encourage SEAs to not charge the front in the event of a highjack, and to give them an attachment that does require some knowledge to use correctly. Instead of having to ask req for one to teach with, they can have one.
Technical details
YAML Updating.
Media
SEATech Changes

SEA Weapon Vend Changes (Mildly outdated, the order of the SMG and Shotgun have been swapped in latest commit.)

SEA Clothing Vend Changes

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes
N/A
Changelog
:cl:!

tweak: The SEA vendors have been updated to include new items and equipment: Training Grenades, Service Jackets, the M63, and Shotguns.

Almayer is supposed to have training nades in the firing range. That's why there isn't any in the vendor.

Almayer is supposed to have training nades in the firing range. That's why there isn't any in the vendor.

Aye. I believed that was the case, but even then I do believe it best that SEAs have a consistent way of getting training grenades.

The Ubuntu fail seems unrelated.


Wiki request - rewrite and simplify explanation of String.toString()

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toString

Closing this issue as the article is created: https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/js-Array-prototype-toString


Should check for unlinked dependencies of all dependents, not just named formulae

While investigating CI failures in https://github.com/Homebrew/homebrew-core/pull/67615 (applying an upstream patch to boost), I noticed that brew test pcl failed for all architectures, even though it had passed very recently in https://github.com/Homebrew/homebrew-core/pull/66792. The tests in https://github.com/Homebrew/homebrew-core/pull/67615 failed to find eigen when running cmake to configure some sample code that links against pcl. Searching earlier in the console log, I noticed brew unlink eigen just before freeling was tested. Looking at the console logs from https://github.com/Homebrew/homebrew-core/pull/66792, I noticed the same call to brew unlink eigen just before freeling, but there was also a call to brew link eigen just before pcl was handled. The difference between those two pull requests is that pcl received a revision bump in the earlier one, and there is logic in setup_formulae_deps_instances() in lib/tests/formulae.rb that calls brew link on unlinked dependencies for any formulae to be built. I believe this logic should be added to link dependencies for any dependents that are installed, not just the explicitly named formulae to be tested.

The difference between those two pull requests is that pcl received a revision bump in the earlier one, and there is logic in setup_formulae_deps_instances() in lib/tests/formulae.rb that calls brew link on unlinked dependencies for any formulae to be built. I believe this logic should be added to link dependencies for any dependents that are installed, not just the explicitly named formulae to be tested.

Makes sense to me @scpeters! Could you open a PR?

The difference between those two pull requests is that pcl received a revision bump in the earlier one, and there is logic in setup_formulae_deps_instances() in lib/tests/formulae.rb that calls brew link on unlinked dependencies for any formulae to be built. I believe this logic should be added to link dependencies for any dependents that are installed, not just the explicitly named formulae to be tested.

Makes sense to me @scpeters! Could you open a PR?

I'll work up the courage and give it a shot :sweat_smile:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

potential fix in #659


[BUG] "Deploy preview" redirects to production site

When a PR's pipeline is completed, a deploy preview link is provided (e.g. https://deploy-preview-203--minimumcd.netlify.app/, for PR #203).
However the referred link redirects to the production site (https://minimumcd.org/minimumcd/), not giving the possibility to explore the changes in the produced artifact.

This looks like an artifact of the way the site is bypassing the splash page. I'll try a few more things.

Fixed


KeyError: 'CT'

HI,
An error occurred during the 3-step SCORE process.
Calculating LDpred-inf risk scores
0.43%Traceback (most recent call last):
File "/Anaconda/bin/ldpred", line 10, in
sys.exit(main())
File "/Anaconda/lib/python3.7/site-packages/ldpred/run.py", line 337, in main
main_with_args(sys.argv[1:])
File "/Anaconda/lib/python3.7/site-packages/ldpred/run.py", line 329, in main_with_args
validate.main(p_dict)
File "/Anaconda/lib/python3.7/site-packages/ldpred/validate.py", line 674, in main
verbose=verbose, summary_dict=summary_dict)
File "/Anaconda/lib/python3.7/site-packages/ldpred/validate.py", line 409, in calc_risk_scores
prs_dict = get_prs(bed_file, rs_id_map, phen_map, only_score=only_score, verbose=verbose)
File "/data/sskimvd/Anaconda/lib/python3.7/site-packages/ldpred/validate.py", line 100, in get_prs
[util.opp_strand_dict[g_nt[0]], util.opp_strand_dict[g_nt[1]]])
KeyError: 'CT'
What is the problem?
Thank you.

Hi, I have the same problem. It seems to be related with flipping variants. When I use the LD reference as validation dataset the error does not appear. I still don't know how to fix it though, maybe I will try manually flipping the alleles and see if the error dissapears.


csv2odf: init at 2.09

Motivation for this change
Useful command line tool to insert csv files in ODF spreadsheets.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@jonringer: accepted all of them, thanks for reviewing and these changes.


[Multitenancy] unit tests (and image url option)

This adds unit tests for almost all code added for multitenancy.
It also add an image url option to the agent startup. The multitenancy branch had this option, but there was no way to set it for a non-multitenant wallet. This is just for feature parity.

@andrewwhitehead I didn't add the responder tests back, and also didn't test the added middleware yet. The responder is now created inside the middleware, so we can't just do server.responder. I'm not really sure how to properly test the middleware that is defined in make_application (mainly check_multitenant_authorization and setup_context). Is there a standard approach to how to approach this?

@andrewwhitehead I didn't add the responder tests back, and also didn't test the added middleware yet. The responder is now created inside the middleware, so we can't just do server.responder. I'm not really sure how to properly test the middleware that is defined in make_application (mainly check_multitenant_authorization and setup_context). Is there a standard approach to how to approach this?

Codecov Report

Merging #889 (59d0dd2) into master (2bcb075) will increase coverage by 1.25%.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   97.42%   98.67%   +1.25%
==========================================
  Files         298      298
  Lines       16725    16737      +12
==========================================
+ Hits        16295    16516     +221
+ Misses        430      221     -209

Codecov Report

Merging #889 (59d0dd2) into master (2bcb075) will increase coverage by 1.25%.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   97.42%   98.67%   +1.25%
==========================================
  Files         298      298
  Lines       16725    16737      +12
==========================================
+ Hits        16295    16516     +221
+ Misses        430      221     -209

We might have to move those middleware constructors to separate functions for testability.
I can't apply updates to this branch so could you rebase it when you get a chance.

We might have to move those middleware constructors to separate functions for testability.
I can't apply updates to this branch so could you rebase it when you get a chance.

This is up to date with master now

This is up to date with master now


security(deps): upgrade to latest stable

reduces audit failures. still bunch coming from @wix/sdk and remix
replace deprecated @import in sass with @use
regenerate lock file

Codux does not support @use. @ynesteruk am I right?

Codux does not support @use. @ynesteruk am I right?

Yes. We don't treat it correctly, especially when it comes to collecting variables/class names from scss files


Element could not be drawn on canvas

I got this console.log error, tried to get image of points and polygon?

Are you using the canvas renderer:

(Leaflet < 1.0.0) You must set L_PREFER_CANVAS = true; so that vector layers are drawn in Canvas
(Leaflet >= 1.0.0) You must set renderer: L.canvas() for any layer that you want included in the generated image.

Can you tell me what that exactly means, how to set that renderer for geojson, this is my code:

var features = L.geoJson(test, { })
.addTo(map);

What version of Leaflet do you use?

(Leaflet < 1.0.0) You must set L_PREFER_CANVAS = true; so that vector layers are drawn in Canvas

you must add <script>L_PREFER_CANVAS = true;</script> before including leaflet.

(Leaflet >= 1.0.0) You must set renderer: L.canvas() for any layer that you want included in the generated image.

You can use the preferCanvas: true map option

I managed to succeed, now it's saying only :

Image from origin 'file://' has been blocked from loading by Cross-Origin Resource Sharing policy: Invalid response. Origin 'null' is therefore not allowed access.


Ender book can't remove EXP cost

Hi
I'm playing on my server and i wanted to use the ender book without exp cost.
I looked in the file config and change the value to 0, but it didn't work, when i try to teleport it says Not enough EXP
what should i do?
Cyclic version: 1.8.14
Forge:  <IP_ADDRESS>5
Minecraft: 1.10.2

Should be resolved in latest release https://minecraft.curseforge.com/projects/cyclic/files/2354294
The config file used to have "minimum value 1" enforced, that was removed so it allows zero now


[chore] Update Remote Provider URL for dev env

Notes for Reviewers
http://<IP_ADDRESS>:9876 was causing redirection issue in dev env.
In response to recent changes in remote provider, reverting it back to http://localhost:9876.
This PR fixes #
Signed commits

[x] Yes, I signed my commits.

// @leecalcote @MUzairS15
Merging this one....


Warn when documenting non-existing @param

Search Terms
warning, parameter, optional
Problem
When a typo or mistake is made in naming a parameter, the documentation string after it will be silently dropped.
The original case I found this for was when erroneously adding a question mark to the name of an optional parameter:
/**
 * This is a function.
 *
 * @param mandatory Some parameter documentation
 * @param optional? Parameter documentation missing
 */
function withOptional(mandatory: string, optional?: string) {
}

Next to this case it's probably also useful with typos, or after renaming a parameter and forgetting to change the documention.
--validation.notDocumented also doesn't produce warning for this case, but that is probably expected.
Suggested Solution
Log a validation warning for parameters that couldn't be matched with the function signature.
If an option for this already exists in typedoc, I couldn't find it.
Linting tools can probably do this already. IntelliJ finds this and marks this as warning.

This should happen even without any validation enabled, since it's obviously broken in this case.


For the Bilibili website, yt-dlp is unable to obtain the uploader and upload date for videos that contain multiple parts (P).

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a site-specific feature
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
China
Example URLs
https://www.bilibili.com/video/BV1GJ41117iw
Provide a description that is worded well enough to be understood
When downloading a video list, for the P0 JSON file, the fields %(uploader)s and %(upload_date>%Y-%m-%d)s cannot be correctly obtained and are displayed as NA. For P1, P2, etc., the %(uploader)s and %(upload_date>%Y-%m-%d)s fields are correctly obtained.

Note, This Bilibili video looks like a playlist, but it is actually a single video containing multiple parts (P), and all parts share the same BVID number. Bilibili also has another type of video collection, which is the one that contains multiple independent videos, where each individual video has a different BVID. For this type of video collection, yt-dlp is able to correctly obtain the %(uploader)s and %(upload_date>%Y-%m-%d)s fields for the P0 JSON file.

How can I correctly get the %(uploader)s and %(upload_date>%Y-%m-%d)s fields for P0?
Here is a list of output filenames:
[NA]-[《狄仁杰断案传奇》86版（高清）]-P[000]-[NA]-[《狄仁杰断案传奇》86版（高清）].info.json
[一品豆腐坊少掌柜弟]-[《狄仁杰断案传奇》86版（高清）]-P[001]-[2019-12-12]-[《狄仁杰断案传奇》86版（高清） p01 第1集].info.json
[一品豆腐坊少掌柜弟]-[《狄仁杰断案传奇》86版（高清）]-P[002]-[2019-12-12]-[《狄仁杰断案传奇》86版（高清） p02 第2集].info.json
[一品豆腐坊少掌柜弟]-[《狄仁杰断案传奇》86版（高清）]-P[003]-[2019-12-12]-[《狄仁杰断案传奇》86版（高清） p03 第3集].info.json
[一品豆腐坊少掌柜弟]-[《狄仁杰断案传奇》86版（高清）]-P[004]-[2019-12-12]-[《狄仁杰断案传奇》86版（高清） p04 第4集].info.json

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '--output', '[%(uploader)s]-[%(playlist)s]-P[%(playlist_index)03d]-[%(upload_date>%Y-%m-%d)s]-[%(title)s].%(ext)s', '--cookies', 'C:\\Users\\username\\Downloads\\cookies.txt', '--write-info-json', '--skip-download', '--paths', 'G:\\test', 'https://www.bilibili.com/video/BV1GJ41117iw']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [7ea278792] (win_exe)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.19041-SP0 (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg 7.1-full_build-www.gyan.dev (setts), ffprobe 7.1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-13.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1837 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[BiliBili] Extracting URL: https://www.bilibili.com/video/BV1GJ41117iw
[BiliBili] 1GJ41117iw: Downloading webpage
[BiliBili] BV1GJ41117iw: Extracting videos in anthology
[BiliBili] Downloading playlist BV1GJ41117iw - add --no-playlist to download just the video BV1GJ41117iw
[download] Downloading playlist: 《狄仁杰断案传奇》86版（高清）
[info] Writing playlist metadata as JSON to: G:\test\[NA]-[《狄仁杰断案传奇》86版（高清）]-P[000]-[NA]-[《狄仁杰断案传奇》86版（高清）].info.json
[BiliBili] Playlist 《狄仁杰断案传奇》86版（高清）: Downloading 14 items of 14
[download] Downloading item 1 of 14
[BiliBili] Extracting URL: https://www.bilibili.com/video/BV1GJ41117iw?p=1
[BiliBili] 1GJ41117iw: Downloading webpage
[BiliBili] BV1GJ41117iw: Extracting videos in anthology
[BiliBili] 78895467: Extracting chapters
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec, channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] BV1GJ41117iw_p1: Downloading 1 format(s): 100024+30280
[info] Writing video metadata as JSON to: G:\test\[一品豆腐坊少掌柜弟]-[《狄仁杰断案传奇》86版（高清）]-P[001]-[2019-12-12]-[《狄仁杰断案传奇》86版（高清） p01 第1集].info.json

It's not currently possible; the extractor doesn't return any metadata at the playlist level besides the title and id. And I'm not sure if that information is available at the time of playlist extraction, so it may not be possible ever. Someone more familiar with the site will need to triage this

However, you can use a separate output template for the playlist info JSON that doesn't include uploader or upload_date, e.g.: -o pl_infojson:"%(title)s.%(ext)s"


add py.typed

Because according to the official typing spec:

For namespace packages (see PEP 420), the py.typed file should be in the submodules of the namespace, to avoid conflicts and for clarity.

Which makes sense in this case, as this project looks all nice and type-hinted 👌🏻

@jorenham I just saw that codecov is making the workflow fail. I opened issue #7 to try to fix it.
But apart from this, pre-commit is failing due to end-of-file character. Would you mind sorting it out?

Hmm I thought the py.typed was required to be literally empty 🤔  But I'll add the newline anyway, as static type-checkers probably won't care about it anyway 👌🏻

GitHub's editor messed it up again. It should be fixed now...

Thanks @jorenham Yes. The github editor is quick, but frequently not the best option :sweat_smile:
I now fixed the codecov problem. Would you mind merging the main branch into yours, to fix it here?


Mailspring Notifications not working

Describe the bug
Currently incoming mail notifications on mailspring do not work. Mailspring notifications require having zenity installed, however having it installed seems to have no effect.
Notify maintainers
@LudovicoPiero
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.41, NixOS, 23.11 (Tapir), 23.11.20230801.3ba1245`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.15.1`
 - channels(root): `"nixos"`
 - channels(patrickaldis): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Even after adding gnome.zenity to the runtimeDependencies, I am still unable to receive any desktop notifications. Perhaps @toschmidt can help?

Same here, not desktop notifications.


to add open source - flutter apps

Orientation application
(https://github.com/matthewtory/trinity-orientation-2018)
An app created for Trinity College at University of Toronto. The app is acts as a companion for all first year students during orientation week.

can u pls assign this issue to me


Yaml file for Smart Sprinkler Controller

You can add this to next release. It is working for this product: https://www.aliexpress.com/item/1005003162848907.html?
name: Smart Sprinkler Controller
product:
  - id: e8fwsklivj87msao
    name: Smart Sprinkler Controller
primary_entity:
  entity: switch
  name: Switch 1
  dps:
    - id: 101
      name: switch
      type: boolean
secondary_entities:
  - entity: switch
    name: Switch 2
    dps:
      - id: 102
        name: switch
        type: boolean
  - entity: switch
    name: Switch 3
    dps:
      - id: 103
        name: switch
        type: boolean
  - entity: switch
    name: Switch 4
    dps:
      - id: 104
        name: switch
        type: boolean
  - entity: switch
    name: Switch 5
    dps:
      - id: 105
        name: switch
        type: boolean
  - entity: switch
    name: Switch 6
    dps:
      - id: 106
        name: switch
        type: boolean
  - entity: switch
    name: Switch 7
    dps:
      - id: 110
        name: switch
        type: boolean
  - entity: switch
    name: Switch 8
    dps:
      - id: 111
        name: switch
        type: boolean

Correction: switches goes off after a while and not stable


Querying second nested collection value

Bug Report
I have these collections,
Location Group
Location
Post
Location Group has a value "title" string.
Location has a value "group" which relates to Location Group and "title" string.
Post has a value "location" which relates to Location.
When I'm trying to use dot notation on REST query on Post using location.locationGroup.title, it's not working, but when I use location.title, its working.
Steps to Reproduce
I also found the same issue with @jacobsfletch's "website-cms" (https://github.com/payloadcms/website-cms)
This is the file that I'm having problem:
https://github.com/payloadcms/website-cms/blob/main/src/collections/Posts.ts

Create a Post record with the author filled
Create a query for "author.photo.alt", it will shows nothing
Create a query for "author.firstName", it will shows the record

If you notice it, photo is the second nested collection and I'm suspecting that is the cause of the issue.
Other Details
Payload Version: 1.2 and 1.6

Thanks for the report @jpmadrigal07! The query we expect to work here is ?where[author.photo.alt][equals]=Write%20for%20the%20Community%20Blog%20Image. Related discussion: https://discord.com/channels/967097582721572934/1076804860969754695

This may or may not be directly related to this issue, but I also notice this behaviour when trying to query a Block that has a relationship field. Related discussion to this: https://discord.com/channels/967097582721572934/1077903102159618068

Not working with [or][and]


Use conda-verify?

We have this warning in package builds:
Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.

Should we fix that?

Sure, let's try it out!

Tried it and it emits a single warning:
/tmp/tmpnf0srwsm/proj-23.11.0-py_0.tar.bz2: C1115 Found invalid license "BSD-3-Clause" in info/index.json

According to https://github.com/conda/conda-verify/blob/3b34286470dd1ceb495374e3ff7b52082084da8e/conda_verify/constants.py#L8 it only wants "BSD" as the license. But in practice we haven't encountered any problems with this. So I don't know if we should change it.
In any case, I tried changing it and the warning went away. I also added license_file in my test like this: (in meta.yaml)
about:
  home: https://github.com/scipp/proj
  license: BSD
  license_file: LICENSE
  summary: testing
  description: testing
  dev_url: https://github.com/scipp/proj
  doc_url: https://scipp.github.io/proj


Extend code action suggesting replacement for array item updates

A code action for simple array update expressions was added on #78
This feature request is to extend the code action to handle more complicated cases (as identified by @vadym-kl)

arr[i] = 1 -> set arr w/= i <- 1;
{set }arr[i][j] = 1 -> set arr w/= i <- ( set arr[j] w/= j <- 1 );

@sw23 Thank you for picking this up!
Sorry, I meant to assign that to you - will fix as soon as I get back to my desk.
I am looking forward to this contribution!

As a quick suggestion, I think the second code action might should be set arr[i][j] = 1 → set arr w/= i <- (arr[i] w/ j <- 1)?

Chris is correct - the rhs needs to be an expression. Thanks, didn't read the description careful enough!

@sw23 I am not sure if you ever got the chance to pursue this. We are also looking into more general options for multi-dimensional arrays. Unless there is something you are actively working on, I suggest that I close this one, and instead open a suitable issue to reflect updated capabilities once we are ready with those.


Support zos4 deployments

Describe the solution you'd like
zos4 now have different workload typs than zos3
it has networklight instead of network amd zmachine_light instead of zmachine

network light
zmachine light

also zos4 nodes doesn't support wireguard, ygg and public config stuff

Verification steps:

deployed vm using this script

dashboard listing specfies that vm was deployed on zos4 node


MacOs support

Hi! Thanks for your work!
Could you please port it to mac somehow? If that's possible..

Hi! +1 That would be nice for macos users.

It took some time, but with the latest commit I updated the Pybluez. It works now nicely on Mac OS X.


Bump library version to use magic byte in (de)serialisation everywhere

This PR was successfully deployed to production by CircleCI build 311 at 2017-08-17 14:52 BST.


Add MockProviderLike

This PR will enable the Buidler team to integrate their provider into our legacy API.

@alcuadrado


change servicediscovery pkg to nameresolution pkg and remove mdns code

Description

Change servicediscovery pkg to nameresolution pkg
Remove mDNS dependency from dapr/dapr

Issue reference
#916
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test


Fix overridable repo and document it

Also add a bit more logging for ease debugging when something goes wrong on trusted.ci and all we have is logs :-)

Going to go ahead with Olivier's review because I would like to make sure the same code is used on my machine and on the (currently failing) trusted.ci job side.
Thanks a lot for the review!


Text fields' text cut off for the Contact form

What do you mean @michael-mckenna ? Do you have any screenshots?


Fields for creating service used by Tableau and Redash - UI

Fields required for Tableau and Redash
Tableau:
username: str
password: str
server: str
api_version: str
env: Optional[str] = 'tableau_prod'  /(default)/
site_name: str
site_url: str
service_name: str
Redash:
uri: str = "http://localhost:5000"
api_key: str

Tableau integration has been done, Redash is moved to 0.5.0.

Created https://github.com/open-metadata/OpenMetadata/issues/523 to track Redash, closing this issue.


Add a Gitter chat badge to README.md

IAG-NZ/KudosPlatform now has a Chat Room on Gitter
@PlagueHO has just created a chat room. You can visit it here: https://gitter.im/KudosPlatform/Lobby.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Bearer token refreshing is broken if running as library with Python3

Context
I am using parts of the containerregistry coding as a Python library (i.e. I am not using the stand-alone version built with Bazel via CLI). Using code runs with Python3.6.
Problem
_Refresh class (client/v2_2/docker_http_.py) parses the result of responses returned by httplib2.Http.request invocations. Those appear to behave differently on Python2 and Python3, such that on Python2, an instance of str is returned, whereas on Python3, it is an instance of byte.
json.load however will not accept byte, as an input, so the code breaks when running in my usage scenario.
Workaround
I already created a Pull request that solves the problem in my usage context and is very probable to not break other scenerios: https://github.com/google/containerregistry/pull/116

resolved by 768137526d201789c2391eb331231d945ad73e6c