Redirects: 'target page route' with non-RoutablePageMixin pages causes server error

Issue Summary
https://github.com/wagtail/wagtail/pull/7827 introduced the 'target page route' option to the create redirect form. This option is meant to be used in conjunction with 'Redirect to a page', it allows editors to choose a page that inherits from RoutablePageMixin and specify a route on the RoutablePage to redirect to.
Now for the issue: it is possible to choose a page that does not inherit from RoutablePageMixin and specify a 'target route page'. When the created redirect is visited, a server error like this is raised:
AttributeError at /test/
'MyPage' object has no attribute 'resolve_subpage'

I foresee this will be very confusing for editors. 'Why is my redirect not working?'.
Possible solutions

My preferred solution would be to completely hide the 'target route page' field and only show it if a page that is a RoutablePage is chosen. I feel like it is better to hide it as it serves a very specific purpose and might be a bit confusing for editors as to what the field is used for.

The easy solution: just ignore 'target route page' if the page is not a RoutablePage, would probably involve checking https://github.com/wagtail/wagtail/blob/main/wagtail/contrib/redirects/models.py#L62  if the page has a resolve_subpage attribute before trying to use it...

Steps to Reproduce

Set up the bakerydemo project (https://github.com/wagtail/bakerydemo/)
Upgrade Wagtail to 2.16rc1 using pip install wagtail==2.16rc1 and run migrations (./manage.py migrate).
Launch the django dev server and navigate to http://<IP_ADDRESS>:8000/admin/redirects/
Create a new redirect and choose the following options:

Redirect from: '/test'
Redirect to a page: 'About' (this is not a routable page!)
Target page route: '/causes-server-errors' (or anything you'd like really, it doesn't matter)

Save redirect and navigate to http://localhost:8000/test/
You should now be seeing the following error:

Traceback (most recent call last):
  File "/Users/storm/projects/wagtail/bakerydemo/venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/Users/storm/projects/wagtail/bakerydemo/venv/lib/python3.9/site-packages/django/utils/deprecation.py", line 119, in __call__
    response = self.process_response(request, response)
  File "/Users/storm/projects/wagtail/bakerydemo/venv/lib/python3.9/site-packages/wagtail/contrib/redirects/middleware.py", line 57, in process_response
    if redirect.link is None:
  File "/Users/storm/projects/wagtail/bakerydemo/venv/lib/python3.9/site-packages/wagtail/contrib/redirects/models.py", line 62, in link
    page.resolve_subpage(self.redirect_page_route_path)
AttributeError: 'StandardPage' object has no attribute 'resolve_subpage'

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: Python 3.9.10
Django version: 3.2.11
Wagtail version: 2.16rc1
Browser version: Chrome 97

Discussed in tema meeting.
option 2 is the most likely fix. There is a question aroudn help text for this option on the form. @ababic give this is for automated redirects, should this show up in the UI at all?

@zerolab Aye, this is mostly for creating more useful redirects automatically. If we can't find a way for it to make sense in the UI, then I'm happy for it to be dropped from the form. I think we need to think about the UI for this page as a whole, so maybe we should postpone quick UI fixes until we have time to look at things more holistically.

@zerolab In fact, something I didn't think of before... If a user views a redirect that has this value set, I think they might be equally confused by NOT seeing it and testing it out. I think the best approach is to just fix the error for now, and leave the field where it is.

The problem with leaving the field in place on the form is that it's basically impossible to explain to a non-developer what it's for - we don't want to normalise the practice of editor-facing UI having "mystery settings that no-one understands, just leave it blank and move on."
I can't think of any situation where a user would want to manually edit this field, and can't think of a situation where noticing the 'secret' behaviour would cause confusion either - it would be more like "this redirect says that blog/archive/2017 should redirect to articles/archive, but actually it redirects to articles/archive/2017. I guess that's good though."

Thanks for the input @gasman ... have updated #7896 to hide the field for now.


LLM Models other than Gemma , falcon, phi, stablelm

Can we use other llm other than Gemma, falcon, phi, stablelm cause when i add other model in llm_conversion notebook its showing error to choosw only 4 of them what ro do can anyone explain ??

The four are set up for that conversion script, but if you want to do anything else/custom, then you'll need to use the AI Edge Torch Generative API


some suggestions

Most of the changes were about removing trailing whitespace.  Does this actually have an impact on the output?
The major change was removing the line which described JWS in somewhat negative (but completely true) terms.  Maybe that doesn't belong in an RFC.


[DNM] Add documentation for hypothetical pre-timeout scripts

In the spirit of documentation driven development, this commit adds docs for the pre-timeout scripts proposed in #1906.
I'll start prototyping an implementation soon. In the meantime, I figured we could start shaking out the major design questions by reviewing what's proposed in the documentation here.
cc @criccomini

Thanks for this great feedback, @sunshowers! Will take an another spin through the docs and start working in answers to the questions you mentioned. I've got some long haul flights coming up this week and next, and this should make for a perfect plane project.


workDir has been removed from the payload in 1.0.0-rc.53

Is it expected or a mistake?
The files extension from the store doesn't work anymore for example. (And I use it in my own extensions)

Sorry about this. Maybe you can help me on that front. What do you think is the best between:

Having cwd set to the extension dir, and use workDir to find out the current directory.
Having cwd set to the current working directory, and using your language to find out the script dir

const DIRNAME=$(dirname "$0")

I added it back as workdir

Having the ability to know the current directory is mandatory for some commands that depend on the filesystem and read from local files.
What would be the use case to know what the directory of the extension is? Aren't all the extensions installed in the same folder with sunbeam extension install?
Then, personally, I don't have a preference between using cwd or workdir as long as we can get the current directory somehow.

I mean that there are two options:

either set the current dir of the process to the user current working dir
or set it as the extension dir (.local/share/...) and pass it via stdin (through workdir, workDir, cwd...)

Sunbeam used to work with the first option, but it's quite error prone when you use imports in your scripts
source ./file.sh # here we expect the relative path to be relative to the script

I switched to passing cwd via stdin sorry for noise

Yes, I think that the approach of having the "real" working directory as the script one makes sense to allow those relative imports.

cwd has been removed again, no? Is there another way to get the current directory?

OK. I will do more tests but I feel like when looking at it today, calling the . directory was actually returning the directory of the entry script and not the current working directory.
This can be tested with the files command (I think the one in your repo was not working with the latest version of sunbeam but I have my own very similar version)

Oh this is a bug then, I'll fix it. Quick note, you will have to update your scripts with the latest release:
manifest:
command mode: page => list || detail
command output:
type is no longer necessary

fixed in latest release

With the new behaviour, is the solution to do the following?
Replacing
#!/bin/sh

# check if python3 is installed
if ! command -v python3 >/dev/null 2>&1; then
    echo "python3 is not installed"
    exit 1
fi

exec python3 "./extension.py" "$@"

by
#!/bin/sh

# check if python3 is installed
if ! command -v python3 >/dev/null 2>&1; then
    echo "python3 is not installed"
    exit 1
fi

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

exec python3 "$DIR/extension.py" "$@"

I like splitting the most complex extensions between different files, like here, so the previous behaviour was actually quite nice for that.

Also, about this

manifest:
command mode: page => list || detail

I used to have a page conditionally being a a list (if there is data), or a detail (if there is no data), which is not possible anymore.
Is this where emptyText would help then?

I like splitting the most complex extensions between different files, like here, so the previous behaviour was actually quite nice for that.

Nice extensions btw!
It's a valid usecase. I'm a bit torn between the two options. Most of my script are composed of a single file

Is this where emptyText would help then?

Yes it is how raycast handles it.
Beeing able to know if the script returns a list or a detail before getting the script output allows the user to type a query even  if nothing is rendered yet.

I reverted the change on cwd. I agree that the DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" is quite arcane, and sunbeam is trying to keep it simple.
Btw, why do you use a bash script at all in this extension ?
I would just rename the extension.py script to dagster.py, and add a shebang on it:
#!/usr/bin/env python3

One other thing, you can set env vars in ~/.config/sunbeam/config.json (see https://pomdtr.github.io/sunbeam/book/reference/schemas/config.html)

I use it because it is a boilerplate I can reuse everywhere 😆 . I could definitely change it for some extensions.
In some cases, it is not very useful, but in other ones, I use it to source env vars, adding source ~/.sunbeamrc to the bash script.
With the new config file that you mentioned, I could move away from this approach.

Yeah I would just remove the sunbeam-extension entrypoint in most of your extensions, and just rely on the shebang. Awesome work btw, it is super cool to see my small project beeing used :)


Make official Docker images smaller

This PR is added as a follow-up of Issue #59293 - it updates the Dockerfiles so that they consistently use apt-get -y clean all && rm -rf /var/lib/apt/lists/*, apt-get install -y --no-install-recommends. Thus making official Docker images smaller.
With this update the change in size of the Docker image is the following:

cpu.Dockerfile: 2.07GB -> 1.76GB
gpu.Dockerfile: 6.63GB -> 6.52GB

(I skipped the comparison for other Dockerfiles).

Hi @mikolajpabiszczak Can you please resolve conflicts? Thank you!


Error while using Cache

Laravel Version: 5.6.24
PHP Version: 7.1.18
Database Driver & Version: MySQL
Cache Driver: Redis (also tried on default, i.e. file)

Description:
**While using the Cache class, I'm getting the following error. **
{
"message": "Class 'League\Flysystem\Cached\Storage\AbstractCache' not found",
"exception": "Symfony\Component\Debug\Exception\FatalErrorException",
"file": "D:\Documents\Websites\ritechase-web\vendor\laravel\framework\src\Illuminate\Filesystem\Cache.php",
"line": 8,
"trace": []
}
Steps To Reproduce:

It sounds like you're using wrong Cache class. If you actually want to use Flysystem's cache, install the league/flysystem-cached-adapter package as suggested in composer.json.
https://github.com/laravel/framework/blob/b15997fa50c2e569ad081d4b3c2a75f8adbfd35e/composer.json#L120

i think you just need to use fecade library cache not filesystem it work for me

Try this:
use Illuminate\Support\Facades\Cache;

check if you have  this use ( use Illuminate\Filesystem\Cache) change it  (use Illuminate\Support\Facades\Cache)
cause use wrong cache
)


cmake

running this recipe for linux unbuntu and trying to build the project hello_world, the cmake is not up to date and fails!

running this recipe for linux unbuntu and trying to build the project hello_world, the cmake is not up to date and fails!

@cydrollinger Hi, which example are you trying to build? Thanks for your feedback.

No worries, I think I may have confused this with the Zephyr project


Add Search for Posts

Considering adding a search function to the main feed or making it accessible across all feeds, including both read and unread items.

Nice suggestion! Noted.

#155


Conductor email improvements

What Changed

Send conductor emails from a configurable CONDUCTOR_SENDER and beacon emails from a configurable BEACON_SENDER (set now to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>respectively)
Use a reply-to header in conductor to allow emails to be delivered properly.
Auto-append the current user's email to the send_to_cc field in conductor

Issues

Fixes #418
Fixes #419

Other than the comment I made in dec57510600713efce6ee42a65966d000d6f66f5 this looks good to me

Yeah they are configurable in the settings. I don't want to make them configurable in the admin because that would require storing them in the database.

Ok then FULL STEAM AHEAD :steam_locomotive:


Consider microbundle

It looks like the best tool for the (boring and error-prone) job.
https://github.com/developit/microbundle

I've tried it for a few of my projects and had mixed results. It works well for javascript projects/
microbundle uses rollup under the hood, which still has bad support for Typescript. The typescript plugin doesn't even work properly and has many bugs, to the point I cannot use it in the projects I maintain.

@waynevanson Thank you for an explanation.

@steida I take back what I said about microbundle to some extent. The support for newer typescript features like export * as namespace from 'module-name' is dodgy, but all bundlers seem to be dodgy with this.
As long as a compatible tsconfig file is used to bundle each target (esm,cjs,umd) then it works fine.
Examples are HERE


'Edit this block' overlaps with 'Toggle sidebar' in embedded PDF viewer

Is the bug present when using the default Obsidian theme?
No
Is the bug present when snippets and plugins are disabled?
Yes
Minimal theme version
6.3.3
Describe the bug
In the embedded PDF viewer, the 'Edit this block' button covers the 'Toggle sidebar' button.

In the Default Theme, the buttons do not overlap.

Debug info
SYSTEM INFO:
Obsidian version: v1.3.1
Installer version: v1.1.9
Operating system: Windows 10 Home 10.0.22624
Login status: logged in
Catalyst license: supporter
Insider build toggle: on
Live preview: on
Legacy editor: off
Base theme: dark
Community theme: Minimal v6.3.3
Snippets enabled: 0
Restricted mode: off
Plugins installed: 3
Plugins enabled: 0
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.

Fixed in 7.0


Add ability to specify custom attributes for ng-model element

I would like to keep the "magic" of angular formly that reduces the watchers to the best of its abilities (using required="true" rather than ng-required="to.required" when angular-formly knows that it will never change for example).
However, I would also like to allow users to specify attributes that they want to go directly onto the ng-model element with the 'attribute-name': 'attribute-value' type notation. Something like this:
{
  type: 'input',
  ngModelElAttrs: {
    'my-custom-directive': 'to.myCustomDirectiveValue'
  },
  expressionProperties: {
    'templateOptions.myCustomDirectiveValue': function() {
      return 'something that changes or whatever';
    }
  }
}

This would result in something like:
<input ng-model="model[options.key]" my-custom-directive="to.myCustomDirectiveValue" />

There would be no magic involved at all. It would simply add the attributes by name and value to the template before it's compiled and that's it.
Any thoughts on the API or the concept? I think this would make things much easier to integrate with existing directive libraries.
Note, this would NOT be a breaking change as it is additive :-)

As it is just additive, I think it is 100% OK.
I'm sure I may find application later in my form generator.

Awesome. I think that I'm going to implement this one. I think it's a good idea and much simpler than the existing ngModelAttrs.

How is this different than just setting ngModelAttrs with the different options?
ngModelAttrs: {
  dateDisplayFormat: {
    attribute: 'date-format',
    bound: 'something-date-format'
  }
}

The existing ngModelAttrs is a highly complicated API because it's highly optimized. This would just make things more straightforward.

I like this, but I thnk a better name would be helpful.  The reference to ngModel (while I get it), is initially confusing as it implies that you are defining something for the model object, when you are really defining attributes for the HTML (generally the input element) that formly is generating for you.  This was/is confusing for ngModelAttrs to.  Just thinking out loud; can't think of a better name at the moment.

@sparty02, while your concern is valid, I think that the most straightforward name would be something like: ngModelElementAttributes, but that's way too wordy. If we abbreviate the stuff that makes sense, we can do: ngModelElAttrs and that's much better. I can't think of any other name that would be more strightforward.

:+1:


Enhancement about Upvote

While upvoting posts upvote icon takes 5-6 secs to turn to blue sometimes I have to click again to make sure app registers my action. If you can make something like swiping from left to right would upvote the post that would be better.

thanks for report... It takes 3 seconds to record action to blockchain and extra secs might be network lagging.
Are you seeing loading/spinner when voting is in process?
Swiping from left to right to upvote post, that seem good idea although wouldn't that cause issue when you are scrolling through post?!

No it doesn't, but while upvoting thread it does.
I think it won't be bothersome if app only register action when user would Swipe  post (left to right) nearly half way.

Yes, for comments it doesn't show spinner. I have found that comment votes are not turning button to blue after action is registered. I have applied fix for that in coming release...


Software quality

Setup software quality tool.
Mere info:
https://github.com/who-knows-inc/KEA_DAT_DevOps_2024_Autumn/blob/main/00._Course_Material/01._Assignments/04._Sofware_Quality_Linting_CI/02._After/software_quality.md
Requirement for Mandatory II
After you have setup a these code quality tools and gone through the issues, your group should create a brief document that answers the following questions:

Do you agree with the findings?

Which ones did you fix?

Which ones did you ignore?

Why?

While only one can setup the integration with SonarQube, everyone should be able to answer the questions above for the exam.

Sonar Cloud
Code Climate
Må lige tjekke om du har/kan få adgang til begge ting.

Sonar Cloud
Code Climate
Må lige tjekke om du har/kan få adgang til begge ting.


SI-4303 WIP fix eta expansion.

Validating: https://scala-ci.typesafe.com/job/scala-2.11.x-validate-main/1654/console

Fails during boostrapping:
quick.lib:
    [mkdir] Created dir: /home/jenkins/workspace/scala-2.11.x-validate-publish-core@2/build/quick/classes/library
    [javac] Compiling 32 source files to /home/jenkins/workspace/scala-2.11.x-validate-publish-core@2/build/quick/classes/library
[quick.library] Compiling 579 files to /home/jenkins/workspace/scala-2.11.x-validate-publish-core@2/build/quick/classes/library
[quick.library] /home/jenkins/workspace/scala-2.11.x-validate-publish-core@2/src/library/scala/collection/parallel/mutable/ParArray.scala:616: error: constructor cannot be instantiated to expected type;
[quick.library]  found   : ParArray.this.ScanNode[U(in class ScanNode)]
[quick.library]  required: ParArray.this.ScanTree[U(in class ScanToArray)]
[quick.library]       case ScanNode(left, right) =>
[quick.library]            ^
[quick.library] /home/jenkins/workspace/scala-2.11.x-validate-publish-core@2/src/library/scala/collection/parallel/mutable/ParArray.scala:619: error: constructor cannot be instantiated to expected type;
[quick.library]  found   : ParArray.this.ScanLeaf[U(in class ScanLeaf)]
[quick.library]  required: ParArray.this.ScanTree[U(in class ScanToArray)]
[quick.library]       case ScanLeaf(_, _, from, len, Some(prev), _) =>
[quick.library]            ^
[quick.library] /home/jenkins/workspace/scala-2.11.x-validate-publish-core@2/src/library/scala/collection/parallel/mutable/ParArray.scala:620: error: value acc is not a member of Any
[quick.library]         scanLeaf(array, targetarr, from, len, prev.acc)
[quick.library]                                                    ^
[quick.library] /home/jenkins/workspace/scala-2.11.x-validate-publish-

The problem minimizes to:
trait Base[T] {
  case class ScanNode1[U >: T]()
}
class Sub[T] extends Base[T] {
  class X[V >: T] {
    (null: ScanNode1[V]) match {
      case ScanNode1() =>
    }
  }
}


Why is it important to add @liberation-data/agensgraph is I am using neo4j

Duplicate of #30
Please follow this issue @Quadriphobs1. Contributions welcome.

Duplicate of #30
Please follow this issue @Quadriphobs1. Contributions welcome.

I have actually switched over to using bride since it's an important part of my day... But maybe I'll take a look into it at a leisure time the API for this is actually better than neode for me

You are very welcome to do that. Thank you @Quadriphobs1


Scaled back the requirements of Complex/Jet from IsReal to Signed.

Jet is still ambiguous, see #598

This PR prepares the work on truncated division (with truncated division, we can have lawful floor, ceil, round).
IsReal is probably going to disappear (or be an alias for the intersection of lawful types).

Codecov Report

Merging #630 into master will increase coverage by 0.34%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   49.45%   49.79%   +0.34%
==========================================
  Files         172      172
  Lines       11121    11107      -14
  Branches     1565     1546      -19
==========================================
+ Hits         5500     5531      +31
+ Misses       5621     5576      -45

Impacted Files
Coverage Δ

core/shared/src/main/scala/spire/math/Jet.scala
70.58% <100%> (+6.58%)
:white_check_mark:

...ore/shared/src/main/scala/spire/math/Complex.scala
43.25% <20%> (ø)
:white_check_mark:

core/jvm/src/main/scala/spire/Platform.scala
0% <0%> (-100%)
:x:

...red/src/main/scala/spire/math/interval/Bound.scala
55.9% <0%> (-1.58%)
:x:

...e/shared/src/main/scala/spire/math/Algebraic.scala
68.78% <0%> (-1.24%)
:x:

extras/src/main/scala/spire/math/FixedPoint.scala
35.51% <0%> (-1.1%)
:x:

...ore/shared/src/main/scala/spire/math/Natural.scala
58.76% <0%> (-0.62%)
:x:

core/shared/src/main/scala/spire/math/Real.scala
67.51% <0%> (+0.31%)
:white_check_mark:

...ed/src/main/scala/spire/math/poly/PolySparse.scala
95.08% <0%> (+0.44%)
:white_check_mark:

...re/shared/src/main/scala/spire/math/Interval.scala
71.57% <0%> (+1.26%)
:white_check_mark:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c1760...a6d8aa4. Read the comment docs.

The patch coverage is misleading, check https://codecov.io/gh/non/spire/compare/46c1760c56eb5b242d30d14f3162553cc8dd2337...069b7ee3954171cc61d4b5641f2d6b279f641663


append working-directory

i forgot working-directory setting on test-with-repository.yml
refer: https://github.com/mackerelio/mackerel-create-release-pull-request-action/actions/runs/985312900

Thanks. for your review.


refactor: add mapping for rxjs/operators to help with treeshaking

We need this additional mapping so Webpack never passes through the CJS version of rxjs/operators (which will result in a much larger bundle size).

Coverage remained the same at 98.148% when pulling 43d3a18c92ac6331d7cf128cbca9cc32c7828e87 on jasonaden:adjust_mapping into 09c60039b9b26ac05acfc932540063b40df51b1a on ReactiveX:master.


IPAM controllers for Networks and IPs resources

Description
This PR adds the new IPAM API with the new Networks and IPs resources and their controllers.
Ref #1990
How Has This Been Tested?

[x] locally

/hold

 Controllori della famiglia IPAM

/build

/build


add tests for location methods for longitude, latitude, and cloud score

Coverage increased (+4.2%) to 80.556% when pulling c6bd1272a10e747455a91c4534102287a8a16e60 on add-tests into 5692e3fc911ffdf787ac640c0fd2627fb0e09978 on master.


Add Organization type

The Organization type is provided by a custom API server. This requires the Organization resource to be in a different group than the CRDs. We introduce the group organization.appuio.io
Summary
This PR got quite large, however a lot of the code is auto-generated or tests.
I used the apiserver-runtime to reduce the amount of boilerplate, but the core business logic is independent from the library

We introduce a new Organization type in  apis/organization.

We use kubebuilder to auto-generate deepcopy but disable crd generation.
The type needs to be in its own group as we can only delegate whole groups to aggregate API server
This package also include functions to convert from and to namespaces
Most of the methods are there for apiserver-runtime to do its magic

apiserver/organization contains the actual API server implementation

organization.go and organization_list.go contain the organizationStorage object that implements the rest.Storage interface of Kubernetes and is the core of the api server.
namespaces.go is only a thin layer of abstraction to access namespaces. I introduce it to more easily mock the interaction with Kubernetes in tests (See the auto-generate mock/ package)
table.go handles the server side printing for kubectl

I will handle deployment and adding the api server to the local-environment as a separate PR.
The CodeClimate issues are interfaces of Kubernetes
Checklist

[ ] PR contains a single logical change (to build a better changelog).
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.

Re codeclimate: You can manually make exceptions for individual cases if you're logged in (I did it for 2 of 3). They are persistent.
not sure if you want to address the max 4 allowed return statements (I assume it's classic Go error handling :roll_eyes: ) in this PR or just ignore for now.

Re codeclimate: You can manually make exceptions for individual cases if you're logged in (I did it for 2 of 3). They are persistent. not sure if you want to address the max 4 allowed return statements (I assume it's classic Go error handling roll_eyes ) in this PR or just ignore for now.

It has nothing to do with Go's error handling. It's just a complex interface defined by Kubernetes that we need to implement and there is nothing we can do about it.

It has nothing to do with Go's error handling. It's just a complex interface defined by Kubernetes that we need to implement and there is nothing we can do about it.

I'm pretty sure we could apply refactoring methods like "extract method" or introduce other helpers for it, but let's not make a fuss now ;)

It has nothing to do with Go's error handling. It's just a complex interface defined by Kubernetes that we need to implement and there is nothing we can do about it.

I'm pretty sure we could apply refactoring methods like "extract method" or introduce other helpers for it, but let's not make a fuss now ;)

Oh wait I completely misread the issue from codeclimate :facepalm: I thought it complained about the number of return values..
So yes I guess we could "fix" that. But I'm not sure that would improve readability.


Consider deprecation in favor of mz

normalize/mz#16 now incorporates any-promise.   Consider deprecating fs-promise in favor of mz/fs

I love this repo, and I use for anything filesystem related, so I want to track this repo.

@jonathantneal Thanks for the feedback.  Don't worry, I'm not in a hurry to deprecate fs-promise, and there probably is little reason to since it is such a limited scope with little maintenance.
But I am curious to hear why you prefer fs-promise over moving to mz.  It seems like most things would work if you swap var fsp = require('fs-promise') to var fsp = require('mz/fs').
Is it only because you use it with fs-extra?  (I saw your note on #5) Or are there other reasons?

I was on vacation, sorry for the delay. Yes, I do use this almost exclusively with fs-extra, but I started having issues where some users would not get fs-extra, so I had to include my own version that explicitly called fs-extra.

I'm again thinking of deprecating this module:
For normal fs one could use mz.
For fs-extra you could use fs-extra-promise
Or your favorite promisify/thenify wrapper in either case.

bummer. I don’t want to get near bluebird.

Most of my needs are covered with mz.   And after realizing the issue with #7 should likely be solved using something like thenify, this module would basically be equivalent in API (and implementation) to mz/fs.
The only exception would be for fs-extra support  in #5 (and potentially TypeScript declarations as mentioned by @olivr70 in #7 ).
I could see this evolve into an alternative to fs-extra-promise backed by any-promise.  If that is appealing, would you be willing to submit a PR?  (Or even be added as a maintainer?)  Seems like you are already most of the way there with your custom implementation.

If you end up accepting that other pull request, we can probably close this issue.

@jonathantneal OK. You've convinced me :)  I'll close this issue.  Thanks for your help and interest.


When I reload http://<IP_ADDRESS>:9880/ all the projects disappeared

Here is what I get

If I add a new project, all the projects reappear

Not able to reproduce


Food Ordering Website using HTML | CSS | JS

Is your proposal related to a problem? Please describe.
No, this is a Project Proposal
Add any other context or screenshots about the proposal request here.
Nah!

can you assign this issue to me @Kushal997-das

@samvid2020 We have already this kinda project in our repo .


Error download file

Empire Version
2.5
OS Information (Linux flavor, Python version)
Ubuntu 16.04.4 LTS
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
Screenshot of error, embedded text output, or Pastebin link to the error

Any additional information
Where does the problem come from,?
Even when I try to
download C:\Users\Public\passlist.txt
It's the same

This is addressed in #1034.

#1034 Merged in dev and master.


Don't sleep on PowerDistributor startup

The PowerDistributor used to sleep for 2 seconds on startup, before
processing requests, to wait for data.  This feature is no longer
being used, because it won't receive requests from the PowerManager
unless there's data.  This PR removes it.

Only internal changes, so no release notes necessary.

The CI is failing, not sure why suddenly a lot of cross referencing can't be found, but I guess it might be another ripple effect of https://github.com/mkdocstrings/griffe/issues/294. Will do a quick check to see if downgrading the dependency fixes it.

The CI is failing, not sure why suddenly a lot of cross referencing can't be found, but I guess it might be another ripple effect of mkdocstrings/griffe#294. Will do a quick check to see if downgrading the dependency fixes it.

Fixed.


Minione fresh install opennebula public market place vm image apps issue, no apps shown

/!\ To report a security issue please follow this procedure:
[https://github.com/OpenNebula/one/wiki/Vulnerability-Management-Process]
Description
Minione fresh install opennebula market place issue, no vm image Apps of opennebula pubic cloud shown, only docker and turnkey apps showing.
To Reproduce
./minione --force, after install opennebula market place shows no vm images
Expected behavior
Opennebula public market place should show vm image Apps
Details

Affected Component: [Opennebula public Market place]
Hypervisor: [KVM]
Version: [OpenNebula <IP_ADDRESS> and 6.4]

Additional context
Add any other context about the problem here.

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

Hello @danilansible,
Do you any marketplace monitoring error on /var/log/one/oned.log?

Hello @danilansible,
Do you any marketplace monitoring error on /var/log/one/oned.log?

Hi @al3xhh
Yes, it looks like marketplace with id 0, i.e opennebula marketplace has error in there Other market places like docker and

Hello @danilansible,
Could you please try to install ca-certificates (or update) and check if the error disappears?

Much appreciated @al3xhh
That did the trick.

After Updating the ca-certificates package on centos 7, the ssl error was gone and opennebula and linux containers market places are accessible and can use the apps.
Thanks @al3xhh


Fix XSS issues.

There is 0 input sanitisation, a log could easily write html and XSS into the viewer.

Never do "input serialization", always" output!
Very good article here: https://lukeplant.me.uk/blog/posts/why-escape-on-input-is-a-bad-idea/


do the thing

@ex1765 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


[BUG] Bad address error for python in miniconda-3 enviroment on Theta

Describe the bug
I tried running a hyperparameter search job on ALCF's Theta using
DeepHyper. I followed the Theta installation instructions
(https://deephyper.readthedocs.io/en/latest/install/theta.html) and the
tutorial
(https://deephyper.readthedocs.io/en/latest/tutorials/hps.html), and I
adapted the instructions for my optimization problem.
The run failed. The contents of the log file serial-launcher_2020-08-26_022719.log are as follows:
cat serial-launcher_2020-08-26_022719.log
26-Aug-2020 02:27:20|80434|    INFO|balsam.core.models:292] Job source
filtering for un-scheduled BalsamJobs
26-Aug-2020 02:27:20|80434| INFO|balsam.launcher.mpi_ensemble:56] Not
scheduled by Balsam service
26-Aug-2020 02:27:20|80434| INFO|balsam.launcher.mpi_ensemble:57]
Assigning jobs to 255 worker ranks
26-Aug-2020 02:27:20|80434| INFO|balsam.launcher.mpi_ensemble:274] MPI
Ensemble pulling jobs with WF currentopt
26-Aug-2020 02:27:20|80434| INFO|balsam.launcher.mpi_ensemble:125]
Acquired lock on 1 out of 1 jobs marked for running
26-Aug-2020 02:27:20|80434| INFO|balsam.launcher.mpi_ensemble:139] Sent
1 jobs to rank 1: occupancy is now 1.0
26-Aug-2020 02:27:20|80451| INFO|balsam.launcher.mpi_ensemble:425] rank
1 [currentopt | 5d081b10]  Popen (shell=False):
['/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python',
'-m', 'deephyper.search.hps.ambs', '--evaluator', 'balsam', '--problem',
'g4blopt.currentopt.problem.Problem', '--run',
'g4blopt.currentopt.model_run.run']
26-Aug-2020 02:27:20|80451| ERROR|balsam.launcher.mpi_ensemble:435] rank
1 [currentopt | 5d081b10] Popen error:
[Errno 14] Bad address:
'/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python'

26-Aug-2020 02:27:24|80451| ERROR|balsam.launcher.mpi_ensemble:380] rank
1 [currentopt | 5d081b10] nonzero return 12345:

26-Aug-2020 02:27:24|80451| ERROR|balsam.launcher.mpi_ensemble:391] rank
1 [currentopt | 5d081b10] can retry task (err occured after 3.41 sec;
attempt 1/3)
26-Aug-2020 02:27:24|80451| INFO|balsam.launcher.mpi_ensemble:425] rank
1 [currentopt | 5d081b10]  Popen (shell=False):
['/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python',
'-m', 'deephyper.search.hps.ambs', '--evaluator', 'balsam', '--problem',
'g4blopt.currentopt.problem.Problem', '--run',
'g4blopt.currentopt.model_run.run']
26-Aug-2020 02:27:25|80451| ERROR|balsam.launcher.mpi_ensemble:380] rank
1 [currentopt | 5d081b10] nonzero return -11:

26-Aug-2020 02:27:25|80451| ERROR|balsam.launcher.mpi_ensemble:391] rank
1 [currentopt | 5d081b10] can retry task (err occured after 1.12 sec;
attempt 2/3)
26-Aug-2020 02:27:25|80451| INFO|balsam.launcher.mpi_ensemble:425] rank
1 [currentopt | 5d081b10]  Popen (shell=False):
['/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python',
'-m', 'deephyper.search.hps.ambs', '--evaluator', 'balsam', '--problem',
'g4blopt.currentopt.problem.Problem', '--run',
'g4blopt.currentopt.model_run.run']
26-Aug-2020 02:27:25|80451| ERROR|balsam.launcher.mpi_ensemble:435] rank
1 [currentopt | 5d081b10] Popen error:
[Errno 14] Bad address:
'/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python'

26-Aug-2020 02:27:28|80451| ERROR|balsam.launcher.mpi_ensemble:380] rank
1 [currentopt | 5d081b10] nonzero return 12345:

26-Aug-2020 02:27:28|80451| ERROR|balsam.launcher.mpi_ensemble:391] rank
1 [currentopt | 5d081b10] can retry task (err occured after 3.35 sec;
attempt 3/3)
26-Aug-2020 02:27:28|80451| INFO|balsam.launcher.mpi_ensemble:425] rank
1 [currentopt | 5d081b10]  Popen (shell=False):
['/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python',
'-m', 'deephyper.search.hps.ambs', '--evaluator', 'balsam', '--problem',
'g4blopt.currentopt.problem.Problem', '--run',
'g4blopt.currentopt.model_run.run']
26-Aug-2020 02:27:28|80451| ERROR|balsam.launcher.mpi_ensemble:435] rank
1 [currentopt | 5d081b10] Popen error:
[Errno 14] Bad address:
'/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python'

26-Aug-2020 02:27:30|80451| ERROR|balsam.launcher.mpi_ensemble:380] rank
1 [currentopt | 5d081b10] nonzero return 12345:

26-Aug-2020 02:27:54|80434| INFO|balsam.launcher.mpi_ensemble:306]
Nothing to do for 20.0 seconds: quitting
26-Aug-2020 02:27:55|80434| INFO|balsam.launcher.mpi_ensemble:288]
Shutting down with 0 jobs still running..timing out
26-Aug-2020 02:27:55|80434| INFO|balsam.launcher.mpi_ensemble:293]
master calling MPI Finalize
26-Aug-2020 02:27:55|80434| INFO|balsam.launcher.mpi_ensemble:295]
ensemble master exit gracefully

I checked that
/lus/theta-fs0/projects/ATPESC2020/valetov/deephyper/dh-env/bin/python
does exist, and I was able to run this Python executable from a login node.
To Reproduce
Steps to reproduce the behavior:
Submit a hyperparameter search on ALCF's Theta using a command like the following:
deephyper balsam-submit hps currentopt -p g4blopt.currentopt.problem.Problem -r g4blopt.currentopt.model_run.run -t 360 -q default -n 256 -A ATPESC2020 -j serial
I think that the essential parts are deephyper balsam-submit hps, -j serial, and the number of nodes -n larger than one.
Expected behavior
The hyperparameter search runs and completes successfully.
System:

OS: [e.g. Ubuntu]: SUSE Linux Enterprise Server 15 SP1
System: Theta
Python version [e.g. 3.8]: 3.7.6
DeepHyper Version [e.g. 0.1.11]: 0.1.0-beta0

Hello @evvaletov,
Theta was recently updated and some installation instructions were not updated in our documentation...
can you try adding the postgresql module: add module load postgresql in your .bashrc if you are using other systems than Theta you can use the $HOSTNAME variable to load the module only on Theta.
Keep trying this in the debug-queue and keep me posted about the behaviour.

Thanks @Deathn0t ! Adding module load postgresql to the .bashrc file resolves the issue.


client.instruments.get : Missing required argument: accountId

Hi there, the following code returns "Missing required argument: accountId" and despite including account_id and accountId was options in the get method I don't seem to be able to get this to work.
It looks as if the account_id is required when querying a list of instruments, not sure if its a limitation of the gem or I've just mis understood the documentation.
--[SAMPLE]
require 'oanda_api'
client = OandaAPI::Client::TokenClient.new(:practice, "<API_TOKEN>")
instruments = client.instruments.get
puts instruments.inspect
--[ERROR]
~/.gem/ruby/gems/oanda_api-0.9.3/lib/oanda_api/client/client.rb:92:in rescue in execute_request': An error as occured while processing response. Status 400 (OandaAPI::RequestError) { 	"code" : 2, 	"message" : "Missing required argument: accountId", 	"moreInfo" : "http:\/\/developer.oanda.com\/docs\/v1\/troubleshooting\/#errors" } 	from ~/.gem/ruby/gems/oanda_api-0.9.3/lib/oanda_api/client/client.rb:78:in execute_request'
from ~/.gem/ruby/gems/oanda_api-0.9.3/lib/oanda_api/client/namespace_proxy.rb:107:in method_missing' 	from oanda_instruments.rb:6:in '
Thanks

You're right the documentation is misleading. I'll update it to make it clearer that your need to include an accountId parameter when using a practice account. Whether or not you need to include an accountId parameter depends on the type of client that you connect to the API. The Oanda Rates endpoint documentation, specifies that an accountId parameter is required, however, when connecting with a sandbox client it's not required.
When using a practice account, you should be getting an instruments list like this:
client = OandaAPI::Client::TokenClient.new(:practice, ENV.fetch("OANDA_PRACTICE_TOKEN"))
instruments = client.instruments(account_id: 1234).get

Thanks for the quick reply, works perfectly.

:+1:


/admin/Settings/general HTTP ERROR 500

When I enter SendGrid API key and click save button, the page Status Code:500 Internal Server Error

Are you able to save anything at all? Or this is just this single field issue? If save doesn't work in general, I would guess that MySql provider still causing issues.


What does connecting to "None" server do?

Testing https://github.com/microsoft/vscode-jupyter/issues/10170
This item confuses me, I don't think it does anything so it shouldn't be there?

It means you're not connected to any server. Not particularly useful for web as then you can't do anything, but for local it prevents remote kernels from showing up when you don't want them anymore.

Should that item be removed on web only since clicking it does nothing?

We're going to redesign this UI to make it so the user can have more than one remote server specified.

This should be fixed withthe new Kernel picker, marking as fixed as this UI no longer appears with the new kernel picker


Removal of Istio component (#2836)

Tested epicli apply on Azure cluster with Ubuntu machines

/azp run

/azp run


Add example to demonstrate reading argument from console

Add code example let say read_from_console.go which demonstrates following:

Reading argument from console
Perform certain operation on the basis of passed argument
Keep asking argument until user passes exit value

Refer Hello World for reference

@akshayithape096 let me work on this

PR

Welcome @mishrraG, Thank you for taking up this issue.


reconsider how package updates alerts are generated

Now that package updates can come from repositories not (only) updated along with manager updates, and in step with manager updates, we need to reconsider how storage server package update availability alerts are produced.
Currently (or rather, previous to modularization) agent package updates only came bundled with manager package updates so it was reasonable to only scan for new agent package update availability when the manager was upgraded.  This was accomplished by nature of the manager being restarted after the upgrade and re-establishing sessions with the agent.
This is due to the fact that the agent only ever scans for package update availability on new session establishment from the manager and then never again scans for new package availability until the manager once again establishes a new session (i.e. manager restarts).
This will not work very well in the new world order of modularity where the manager and agent packages can and will be updated out of sync with each other.  The agent needs to be able to determine and signal the manager when new packages are available independently of session establishment.
But we also need to be careful and do this periodic scanning at a frequency, and/or in a way that does not impact the node measurably.  This is worth some time and effort in investigating the DNF ecosystem to determine the most efficient means.

How should we consider what updates are in the purview of IML? Is it just packages coming from /etc/yum.repos.d/Intel-Lustre-Agent.repo?
In addition, I think we need to try and resolve whether the updates are even installable (this is missing from the current implementation).


Component Specification: How to produce output by value with a reusable component?

The documentation page about Component Specification shows in particular how to:

consume inputs by value
consume inputs by file
produce outputs by file

This page does not explain how to produce outputs by value (i.e. outputValue placeholder) when creating a reusable component from a Yaml specification. The data passing tutorial shows how to do so, but only for lightweight Python components.
I think that the documentation could be improved by adding an example of usage of ouputValue for reusable components, and I would be interested too!

@Ark-kun Do you have any examples handy? :)
/cc @joeliedtke

Thank you for your interest in reusable components and the lighweight components feature.
outputValue does not exist in the ComponentSpec schema or in any other place in the SDK.
The standard interface of a command-line program does not really provide a way to do that in a universal way. The only data that the program kind of outputs is the contents of STDOUTand STDERR, but usually this is not used for outputting data values.
So, the only common way to get some output data from a command-line program is to give it an outputPath so that the program can write the data there.
The lightweight python components feature just builds on top of the ComponentSpec (reusable components) and injects code to serialize small data values and write them to files. See the generated code:
https://github.com/kubeflow/pipelines/blob/56d519e9f76c57bdffc593742e23b790a0505310/components/gcp/automl/create_model_for_tables/component.yaml#L99
So, if you are creating a component from a command-line program, just use outputPath and write that data pieces to the provided paths. This tutorial may come handy: https://github.com/Ark-kun/kfp_samples/blob/master/2019-10 Kubeflow summit/106 - Creating components from command-line programs/106 - Creating components from command-line programs.ipynb
P.S. When you create a lightweight component, you can write it to a file for sharing and inspecting. It's a proper reusable component.yaml. func_to_container_op(my_func, output_component_file='my.component.yaml') . This will demystify the lightweight components for you.

Thank you for the detailed answer, it makes more sense now.
I'll just use outputPath. I was a bit confused by the UI, which makes a clear distinction between Output parameters and Output artifacts.
Thanks again.

/kind feature
/area docs
/priority p2

Thanks @Ark-kun and @tholop! I'm going to close this issue as answered. If there's still doc work to do, please do re-open the issue and/or send a PR. :)
/close


Fixes and code improvement on the code to save and restore trained models

Hi Patrick,
Sorry for the delay in responding and fixing the bugs that came up as mentioned here.
Directories are being created :
There is one directory that is created by the name saved_models under the trpo directory which is used to save and load the trained models and the value of the scale and offset. The subdirectories of this saved_models directory are specific to environments.
Errors when running locally :
I tested it on my computer. It doesn’t throw any error. Can you tell more about what kind of errors did you get?
Besides, I have tried to remove all PEP8 violations. Let me know if you have any questions or trouble integrating it.

For policy.py, it looks like I need to add 2 lines:

import os
and in Policy class init:
self.env_name = env_name

And 1 line to train.py:

import pickle

That's minor, I'll fix, but can you confirm?
Also, in line 286, it seems the call to Policy is missing the correct 1st argument?

Ok, merge was a bit complicated because some of these changes were committed and reverted earlier. Anyway, got them all in.
Why: import _pickle as pickle?

For now, it is in branch:
https://github.com/pat-coady/trpo/tree/sanjaythakur-master
My mujoco license is expired, will dust off another simulator and try again tomorrow.

Hi @pat-coady ,
Thank you for integrating my conflict-laden code. I have verified the branch sanjaythakur-master. It runs fine. But I do have responses/suggestions/requests:

"Why: import _pickle as pickle?"
Python3.x supports _pickle but I felt the word pickle looks cleaner. Feel free to change it the way you want.
Can you add the instructions for reusing the saved models in the README.md file. Here is a sample:

Reuse the saved trained models
Example usage after running the updated 'train.py' that trains and saves the learned model:
./reload.py HalfCheetah-v1

For the sake of accreditation can you add me as a co-author in the sanjaythakur-master branch in your next commit? It is easy and the instructions are given here - https://help.github.com/articles/creating-a-commit-with-multiple-authors/ . I can be addressed as "sanjaythakur<EMAIL_ADDRESS>
Let me know if you have any questions.

Sorry for the delay, I followed the instructions for adding co-author. Let me know if it didn't work.

On Aug 11, 2018, at 4:52 PM, Sanjay Thakur<EMAIL_ADDRESS>wrote:
Hi @pat-coady https://github.com/pat-coady ,
Thank you for integrating my conflict-laden code. I have verified the branch sanjaythakur-master. It runs fine. But I do have responses/suggestions/requests:
"Why: import _pickle as pickle?"
Python3.x supports _pickle but I felt the word pickle looks cleaner. Feel free to change it the way you want.
Can you add the instructions for reusing the saved models in the README.md file. Here is a sample:
Reuse the saved trained models
Example usage after running the updated 'train.py' that trains and saves the learned model:
./reload.py HalfCheetah-v1
For the sake of accreditation can you add me as a co-author in the sanjaythakur-master branch in your next commit? It is easy and the instructions are given here - https://help.github.com/articles/creating-a-commit-with-multiple-authors/ https://help.github.com/articles/creating-a-commit-with-multiple-authors/ . I can be addressed as "sanjaythakur<EMAIL_ADDRESS><EMAIL_ADDRESS>Let me know if you have any questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/pat-coady/trpo/pull/22#issuecomment-412300840, or mute the thread https://github.com/notifications/unsubscribe-auth/AWdFxF1m-go0Ca_oa_7lhky2HwGk_hOnks5uP0P8gaJpZM4U3EOU.

For now, it is in branch:
https://github.com/pat-coady/trpo/tree/sanjaythakur-master
My mujoco license is expired, will dust off another simulator and try again tomorrow.

Pat, your code works perfectly with free pybullet gym environments instead of mujoco :)
Just add: import pybullet_envs.gym_locomotion_envs

It only took me a year, but I moved the code to pybullet and TensorFlow 2.

On Dec 29, 2018, at 4:36 AM, Kirill Makukhin<EMAIL_ADDRESS>wrote:
For now, it is in branch:
https://github.com/pat-coady/trpo/tree/sanjaythakur-master https://github.com/pat-coady/trpo/tree/sanjaythakur-master
My mujoco license is expired, will dust off another simulator and try again tomorrow.
Pat, your code works perfectly with free pybullet gym environments instead of mujoco :)
Just add: import pybullet_envs.gym_locomotion_envs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/pat-coady/trpo/pull/22#issuecomment-450479521, or mute the thread https://github.com/notifications/unsubscribe-auth/AWdFxHMahq8upjmIbwmTxTaOlAJNhVp0ks5u9zeZgaJpZM4U3EOU.

Unfortunately I just completed a major refactor to TensorFlow2, so merging this will be a small nightmare.


pr-dev: 39

Codecov Report

Merging #42 into dev will decrease coverage by 0.23%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##              dev      #42      +/-   ##
==========================================
- Coverage   76.88%   76.64%   -0.24%
==========================================
  Files          22       22
  Lines         558      561       +3
==========================================
+ Hits          429      430       +1
- Misses        129      131       +2

Impacted Files
Coverage Δ

...ject/file/function_def/expression/returned_expr.py
94.44% <92.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fc795...b3dbade. Read the comment docs.


unregister no-locations widgets

@shaniwein sorry had a pylint error, had to remove the import as well


[FEATURE REQUEST]  Want to add dark/light toggle button

By adding this light/dark mode option the website look more good

Adding a toggle button to switch between light and dark theme is indeed a great UI, and it greatly helps the user experience therefore kindly assign this issue to me @akshitagupta15june

not needed in this website


Performance: Choose the quickest available way to get the caller

Currently the implementation uses the StackTrace of a Throwable to get the Caller class, and then uses Strings to compare the Class names. https://stackoverflow.com/a/2924426 has examples on how to use the Reflection class/Security manager to get the caller class way faster. Best-case gatekeeper should check for the fastest available method(since the Reflection way is sadly deprecated without replacement) that the runtime JVM has to offer.
Doing a quick test with optimized class lookups(only getting the target class when the caller was not allowed), comparing classes instead of class-names and the Reflection way of getting the caller class speed up checks from ~400k checks/second to ~9million checks/second.

Thank you very much for this valuable insight regarding the performance. I tried the improve the performance already by getting the stacktrace from an Exception but your suggestion from the stackoverflow topic is even better. Especially the option with the security manager. I don't think the option with reflection is a good alternative as it is marked deprecated and should be avoided.
Would you like to create a pull request?

Yea I'll do that later at home.


MWPW-159269 add size field

Test URLs:

Before: https://main--mas--adobecom.hlx.live/
After: https://MWPW-159269--mas--adobecom.hlx.live/

also, another thought, we could put the 'Optional' into the name field to make it more explicit to GWP what fields are not necessary, wdyt?

i think that we have not dealt with the variant -> fields mapping in authoring yet (even if we did it for hydration), and at that moment yes, we could foresee such things (even check box for slice card "is wide ?"). It makes even more sense not having size field at all for lot of variants

also, another thought, we could put the 'Optional' into the name field to make it more explicit to GWP what fields are not necessary, wdyt?

i think that we have not dealt with the variant -> fields mapping in authoring yet (even if we did it for hydration), and at that moment yes, we could foresee such things (even check box for slice card "is wide ?"). It makes even more sense not having size field at all for lot of variants

We could add it later, true.
So what are the possible values for the size field?

So what are the possible values for the size field


Remove DbContext Pooling from Miscellaneous TOC

DbContext Pooling used to be a page under Miscellaneous, but was moved to the Advanced Performance Topics page under Performance. A redirection is already in place, but the old TOC entry was left in place.

Maybe we should leave it in both places? For discoverability.

I guess... I like to leave Miscellaneous as small as possible, and DbContext pooling really is a perf feature. If anything, it should probably be mentioned somewhere under "DbContext Lifetime, Configuration, and Initialization"...

I like putting it under  "DbContext Lifetime, Configuration, and Initialization"

I can do that. What do you think, an additional short section in the existing overview page? Because there's only that one page in the section, it would be weird to have a second DbContext Pooling TOC item...

There's going to be many more pages. As soon as I write them. :-) I think just move the second TOC item there.

@ajcvickers done


Stable Diffusion deep dive notebook can't be run on 8GB GPUs

OOM errors pop up when running the notebook on a 8GB GPU. I managed to run it successfully by using half-precision tensors (fp16) instead.

Hi @kevinbird15. There is no pipe in Stable Diffusion Deep Dive notebook as it is (components are loaded independently). I think you may be talking about a different notebook (perhaps this one?).

@jarandaf what if you add this before the "# To the GPU we go!" comment:
slice_size = unet.config.attention_head_dim // 2
unet.set_attention_slice(slice_size)

This is what is inside the enable_attention_slicing function:
Signature:
pipe.enable_attention_slicing(
    slice_size: Union[str, int, NoneType] = 'auto',
)
Source:
    def enable_attention_slicing(self, slice_size: Optional[Union[str, int]] = "auto"):
        r"""
        Enable sliced attention computation.

        When this option is enabled, the attention module will split the input tensor in slices, to compute attention
        in several steps. This is useful to save some memory in exchange for a small speed decrease.

        Args:
            slice_size (`str` or `int`, *optional*, defaults to `"auto"`):
                When `"auto"`, halves the input to the attention heads, so attention will be computed in two steps. If
                a number is provided, uses as many slices as `attention_head_dim // slice_size`. In this case,
                `attention_head_dim` must be a multiple of `slice_size`.
        """
        if slice_size == "auto":
            # half the attention head size is usually a good trade-off between
            # speed and memory
            slice_size = self.unet.config.attention_head_dim // 2
        self.unet.set_attention_slice(slice_size)
File:      ~/.local/lib/python3.9/site-packages/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion.py

Running on Paperspace with 8GB GPU, I get the error on this line  vae = vae.to(torch_device):
RuntimeError: CUDA out of memory. Tried to allocate 2.00 MiB (GPU 0; 7.80 GiB total capacity; 6.00 GiB already allocated; 2.44 MiB free; 6.61 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

Is there a way of making this model less memory intensive?


EXPORT_ANALYZER data response

Page 22 of Logic Socket API Users Guide details an optional third parameter to have the analyzer data returned in the socket response.

Add a third, optional parameter to have the results piped back through the TCP socket to you.

This change exposes that with a kwarg data_response=<boolean> to enable that feature.
I'm currently using this to receive two Async Serial decodes (RX and TX) and merge them into a single CSV where each RX and TX are a column, and everything is sorted by timestamp.

Looks cool, thanks.
One question as I've never used this feature of Saleae, is that response a giant string? Would it possibly make more sense for the library to return a more useful parsed data object (array of arrays perhaps)?

Yeah, it is just a big 'ol string.
I have set my Analyzers to export CSV and that's what I get via the API, but I'm not sure if you can get the text format too? The API examples only show CSV, and it doesn't appear to expose any way to configure the export before asking for it.
If we can confirm that the API only returns CSV, it would be very useful to parse the response into an array of named tuples.

@Marcus10110 can you confirm whether the API will reliably return CSV data?

Any suggested changes for me to make before taking this PR?

Naw, I'd hoped Mark would be able to reply, but it could be something that just isn't stable yet / they don't have a good answer for yet, which is understandable. It's a bit of a niche corner.
We could add a response_format parameter or s/t like that in the future to coerce one way or another w/out breaking backward compatibility.
I'll let this sit for another 24h or so on the off chance that this thread bumped back to top of Mark's inbox, o/w I'll just go forward with unformatted string as a response.


proselint: 0.10.0 -> 0.10.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/proselint/versions.
meta.description for proselint is: '"A linter for prose"'.

Checks done (click to expand)

built on NixOS
/nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2/bin/.proselint-wrapped passed the binary check.
/nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2/bin/proselint passed the binary check.
2 of 2 passed binary check by having a zero exit code.
2 of 2 passed binary check by having the new version present in output.
found 0.10.2 with grep in /nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2
directory tree listing: https://gist.github.com/a7bdcd705ffd074e2f401b071a068e9d
du listing: https://gist.github.com/143c0c43f6a56d5de01c5ea8f34c577b

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 33383b426bfb873d15817526f42b4221aeafb71d && nix-shell --pure -I nixpkgs=. -p proselint

cc @alibabzo for testing.

Success on x86_64-linux (full log)
Attempted: proselint
Partial log (click to expand)
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed proselint-0.10.2
/build/proselint-0.10.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2/lib  /nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2/bin
patching script interpreter paths in /nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2
checking for references to /build in /nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2...
wrapping `/nix/store/mc0rwc184jgcj10rn884h6mp422qfm9z-proselint-0.10.2/bin/proselint'...

Success on aarch64-linux (full log)
Attempted: proselint
Partial log (click to expand)
Successfully installed proselint-0.10.2
/build/proselint-0.10.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2/lib  /nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2/bin
patching script interpreter paths in /nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2
checking for references to /build in /nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2...
wrapping `/nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2/bin/proselint'...
/nix/store/lhijznry7qh04gbrqim9byiangpvmpj5-proselint-0.10.2

Success on x86_64-darwin (full log)
Attempted: proselint
Partial log (click to expand)
Installing collected packages: proselint
  The script proselint is installed in '/nix/store/zaps5ghiq44kj0cmx9kmixzyb6yyhfk5-proselint-0.10.2/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed proselint-0.10.2
/private/tmp/nix-build-proselint-0.10.2.drv-0/proselint-0.10.2
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/zaps5ghiq44kj0cmx9kmixzyb6yyhfk5-proselint-0.10.2/lib  /nix/store/zaps5ghiq44kj0cmx9kmixzyb6yyhfk5-proselint-0.10.2/bin
patching script interpreter paths in /nix/store/zaps5ghiq44kj0cmx9kmixzyb6yyhfk5-proselint-0.10.2
wrapping `/nix/store/zaps5ghiq44kj0cmx9kmixzyb6yyhfk5-proselint-0.10.2/bin/proselint'...


Add support for reporting variance in benchmarks

This adds a new CLI arg to both the benchmark CLI commands that will report the standard deviation (SD) and interquartile range (IQR) for a set of results by passing either -v or --show-variance as an argument when running a benchmark command.
Example:
npm run research benchmark-server-timing -- -u http://localhost:8889/ -p -n 100 -v

╔═════════════════════╤════════════════════════╗
║ URL                 │ http://localhost:8889/ ║
╟─────────────────────┼────────────────────────╢
║ Success Rate        │ 100%                   ║
╟─────────────────────┼────────────────────────╢
║ Response Time (p10) │ 131.22                 ║
╟─────────────────────┼────────────────────────╢
║ Response Time (p25) │ 136.7                  ║
╟─────────────────────┼────────────────────────╢
║ Response Time (p50) │ 142.71                 ║
╟─────────────────────┼────────────────────────╢
║ Response Time (p75) │ 147.52                 ║
╟─────────────────────┼────────────────────────╢
║ Response Time (p90) │ 159.02                 ║
╟─────────────────────┼────────────────────────╢
║ Response Time (SD)  │ 26.7                   ║
╟─────────────────────┼────────────────────────╢
║ Response Time (IQR) │ 10.82                  ║
╚═════════════════════╧════════════════════════╝

Playing with this idea in our compare-wp-performance repo, you can see how it could be useful when interpreting a set of data (example). For server timing, it seems like there is very low variance in the results population, so it can be inferred that the improvement percentage (which is larger than the IQR) is likely significant and not just the result of variability. Similarly, this run shows an improvement at LCP-TTFB (p50) of -1.75ms, but with both results having SDs of over 6ms and IQRs of nearly 10ms, this could be the result of variance.

@swissspidy I've added MAD calculations in 5ae442c


Action "stop" does not work for a connection

When I try to stop a connection, the connection is put into "reconnecting" state. This happens after I click the "Stop" action under a Connection in the sidebar.
Not sure if I'm actually disconnected or not. Maybe I should finish #212 instead.
Could be as simple as the reconnect timer is not cancelled. Not sure atm.

Closing this, since the code is completely different in one-point-oh.


IndexDB RMW

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c9cb11) 68.43% compared to head (b420157) 68.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   68.43%   68.43%
=======================================
  Files          17       17
  Lines         583      583
  Branches      128      128
=======================================
  Hits          399      399
  Misses        174      174
  Partials       10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


operators node-healthcheck-operator (0.1.0)

Signed-off-by: Roy Golan<EMAIL_ADDRESS>

/hold cancel

@J0zi @mvalarh please help me set the labels to allow this.

/hold
namespace is required

@rgolangh any update regarding https://github.com/k8s-operatorhub/community-operators/pull/48#issuecomment-887308516?

@rgolangh I'm closing this as we already release 0.1.1
/close


[SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC client

What changes were proposed in this pull request?
While processing the Rowdata in the server side ColumnValue BigDecimal type value processed by server has to converted to the HiveDecmal data type for successful processing of query using ODBC client.As per current logic  corresponding to the Decimal column datatype, the Spark server uses BigDecimal, and the ODBC client uses HiveDecimal. If the data type does not match, the client fail to parse
Since this handing was missing the query executed in ODBC client wont return or provides result to the user even though the decimal type column value data present.
How was this patch tested?
Manual test report and impact assessment is done using existing test-cases
Before fix

After Fix

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @davies @HyukjinKwon

@sujith71955 Thanks for this fix. Could you describe how to reproduce this issue.  Which
ODBC client? which ODBC driver? I need verify it first.

@sujith71955 Thanks for this fix. Could you describe how to reproduce this issue. Which
ODBC client? which ODBC driver? I need verify it first.

Its Hive ODBC client and UnixODBC driver. Further details you can refer the JIRA steps. In JIRA the steps has already added by thhe tester. Moreover you can also check in data-bricks site to know more about HiveODBC conenction details. Please revert me for any clarifications further. Thanks for your input ;)

@dongjoon-hyun @davies @HyukjinKwon @cloud-fan  Can i get any inputs regarding my changes for this JIRA. Thanks.

@wangyum are you able to verify? let me know if any clarifications you have.

cc @srowen

@sujith71955 I'll verify it next few days.

@sujith71955 I'll verify it next few days.

Thanks wangyum

@wangyum @HyukjinKwon  Can i get some inputs for this PR. Thanks in advance

retest this please

add to whitelist

ok to test

Test build #103322 has started for PR 23899 at commit 90109a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8761/
Test PASSed.

Test build #103322 has finished for PR 23899 at commit 90109a3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103322/
Test PASSed.

@cloud-fan @dongjoon-hyun - please review and let me know for any suggestions. Thanks

@cloud-fan @dongjoon-hyun - please let me know for  any suggestion on the above PR as directly the querues with decimal type column are not giving any results in hive client. thanks

gentle ping @cloud-fan @dongjoon-hyun

gentle ping @cloud-fan @dongjoon-hyun

gentle ping @cloud-fan @dongjoon-hyun

@sujith71955 Could you please try these ODBC drivers:
https://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.6.5/bk_data-access/content/hive-jdbc-odbc-drivers.html
https://www.cloudera.com/documentation/other/connectors/hive-odbc/latest.html

@cloud-fan @dongjoon-hyun Kindly review and let me know for your opinion.
@wangyum I will let you know the results. Did you verified? This happens only in case of ODBC driver, because HIVE_CLI_SERVICE_PROTOCOL_V1 so it goes with RowBasedSet.

gentle ping @cloud-fan @dongjoon-hyun  - please review this PR and let me know for any clarification. the usecase is directly failing if user try to execute a decimal type column using ODBC client. thanks

gentle ping @cloud-fan @dongjoon-hyun

gentle ping @cloud-fan @dongjoon-hyun

gentle ping @cloud-fan @dongjoon-hyun

@dongjoon-hyun @cloud-fan @HyukjinKwon  Gentle reminder for the review. thanks

@dongjoon-hyun @cloud-fan Gentle reminder for the review. thanks

Gentle ping, @sujith71955 .

@sujith71955 Cloud you update the PR and enable this test case:
https://github.com/apache/spark/blob/a59fdc4b5783be591a236bfc60d1107caa818412/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala#L186-L193

Test build #108808 has started for PR 23899 at commit 97c4ca5.

@sujith71955 Cloud you update the PR and enable this test case:
https://github.com/apache/spark/blob/a59fdc4b5783be591a236bfc60d1107caa818412/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala#L186-L193

Done. Thanks

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13889/
Test PASSed.

Test build #108809 has started for PR 23899 at commit 64e3031.

Test build #108808 has finished for PR 23899 at commit 97c4ca5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108808/
Test PASSed.

Test build #108809 has finished for PR 23899 at commit 64e3031.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108809/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13900/
Test PASSed.

Test build #108822 has started for PR 23899 at commit 85931c8.

Test build #108822 has finished for PR 23899 at commit 85931c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108822/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13901/
Test PASSed.

Test build #108824 has started for PR 23899 at commit 5b4331e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13902/
Test PASSed.

Test build #108824 has finished for PR 23899 at commit 5b4331e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108824/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13903/
Test PASSed.

Test build #108825 has started for PR 23899 at commit c701a71.

Test build #108825 has finished for PR 23899 at commit c701a71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108825/
Test PASSed.

Thank you @sujith71955 Please update PR title according to the PR content.
Also add test-hadoop3.2 to PR title to test with our v2.3.5.

Thank you @sujith71955 Please update PR title according to the PR content.
Also add test-hadoop3.2 to PR title to test with our v2.3.5.

Done.

Thanks for the inputs.

retest this please

Test build #108863 has started for PR 23899 at commit c701a71.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13936/
Test PASSed.

Test build #108863 has finished for PR 23899 at commit c701a71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108863/
Test PASSed.

LGTM
cc @HyukjinKwon @dongjoon-hyun

Thanks @dongjoon-hyun and thanks for cc'ing me @wangyum. LGTM too.

Thanks all for the guidance.


osbuild: support multiple dirs in --libdir via PATH like ":" separator

This allows to write:
$ osbuild --libdir /home/foo/osbuild:/usr/lib/osbuild

[draft as it needs more tests and also https://github.com/osbuild/osbuild/pull/1848]

Or just make it so passing --libdir more than once appends to a list? I think that's a more common pattern for cmdline arguments and ':' separated is more common with environmental variables. Not really feeling strongly one way or the other, but it should be less new code since argparse supports this.


logging.ts should not call loggingcontroller for logs below the logging filter

Currently, logging.ts calls the logging controller regardless of the logging level.  We may be incurring a large worker communication overhead here for statements which fall below the current log level.
This will require adding a getConsoleFilter counterpart to the logging controller's setConsoleFilter (and, presumably, getBufferedLogFilter).

So, I ran a quick test to guess-timate the impact of doing this.

First, I:
hack datachannel.ts to output a debug line on every send and receive
similarly for tcp.ts
Then, I start downloading a huge file, e.g. curl -O -C - -x socks5h://localhost:9999 http://mirrors.xmission.com/ubuntu-cd/14.04.1/ubuntu-14.04.1-desktop-amd64.iso
While that's happening, I monitor:

CPU use and RSS size in top
download speed (as reported by curl)

I repeat steps 2-3, having hacked logging.ts to just do nothing: no cross-module message, nothing.
The results are mostly pretty similar: download speed is ~600-700k/sec and, after a few moments, RSS grew to a similar size (~800MB, though I didn't time how long I ran it for). What differed was CPU use: it was ~140% without logging, but ~200% in the second. I'm not really sure how download speed was roughly the same in each case but it's clear there's a gain in CPU use to be had. Yes, I know logging on every send and receive is perhaps overkill but this helps highlight an issue.

We currently have a rather odd division of responsibilities:

logging.ts handles %1- substitutions and the business of asynchronously fetching loggers
loggingprovider.ts does the rest (filtering, prepending timestamps, etc.)

So, I wondered what would happen if I just disabled substitution in logging.ts. Maybe the string operations are super-slow? No, still ~200% CPU use.
Still pretty informal but it seems there's significant overhead in the logging.ts -> loggingprovider.ts.
I see two paths forward:

move a bunch of the loggingprovider.ts logic into logging.ts in an effort to avoid message passing overhead
just don't log so much

Fantastic to know all this!
Logging in freedom involves copying the messages a few times: when a message is 'logged', it is first copied to the core environment, then it is copied again to the logging provider; and when we then console log it, I think it is copies again back to the core environment again, and then the browser (very slowly) log does its console log thing.
I expect that might be eating some of that CPU, as well as IPCs.
If we put the filtering logic into logging.ts, for logs that are filtered out, we could save on the string replacement, the IPCs and the copying (and perhaps on the subsequent garbage collection too: unused strings will just be on the stack ... depending how awesome V8 / the JS engine is).
From that analysis, I think I'm in favour of the smarter logging.ts.

@jpevarnek Assigning you as you were working on this last we chatted.


update version for 389ds v143 (#1775)

update version for 389ds v143 (#1775)
Signed-off-by: cclhsu<EMAIL_ADDRESS>

Thanks to Clark explanation, I was able to test RBAC feature using the new 389ds container.


[Feat] .Net SDK 100% grpc api coverage

Description
.Net SDK must support all GRPC api.
Action items

[x] All methods can be invoked with a client
[ ] All methods that support streaming can be used
[x] Add support for synchronous operations
[x] SQL

After discussion with @byo - @raducrisan1 Is there something left or can we close this one and track other features in separate tasks?

let's close it.


host: Start flynn-host at boot by default

Disabled in EC2 and Vagrant images so that bootstrap scripts can do their thing.

LGTM.

This means a Flynn node can be rebooted now?

Yes, I'm doing testing now but we believe we have fixed the reboot issues. A release will follow shortly if everything is working.

Finally! :heart:


Toggle switch a11y take3

This PR addresses the accessibility feedback for the ToggleSwitch component, outlined in this issue: https://github.com/github/primer/issues/1867. It is a re-submission of https://github.com/primer/react/pull/3251 and https://github.com/primer/react/pull/3433 which had to be reverted. See https://github.com/primer/react/issues/3429 for details.
Namely it:

Removes role=switch from the button.
Uses aria-pressed in favor of aria-checked.
Makes the status label (on/off) clickable.

Screenshots
No visual changes
Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup yes, that's correct 👍


Feature - 106

Github Issue URL/Tags (required)
#106
What's this PR do? Please give a technical summary (required)

Add properties in Payment and Options

Which acceptance criteria does this PR do? (optional)
Have you written a test code? if not, please provide an evidence instead (Screenshot, log ...) (optional)
Screenshots (if appropriate) (optional)
Any references (stackoverflow …) (optional)

@at-suho
Please review this PR , thank you!


Cannot remove a user from an organization, cannot leave an organization

Gitea version (or commit ref): 1.12.4, 1.12.5
Git version: any
Operating system: any
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[X ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X ] No (try.gitea.io does not provide admin access)
[ ] Not relevant

Log gist:

Description
When I try to remove a user from an org it spins forever and locks up the app, never completing. When I sign in as the user and try to leave the org the same thing happens. Sometimes it will timeout and yield a 502 error.
...
Screenshots

Would it be possible to see some logs and a suitably sanitized copy of your app.ini please.


Change plugin configurations at runtime

Is it possible to change the configuration of a plugin after the jstree has been created?
More specifically, I'd like to toggle the three_state property of the checkbox plugin configuration of an existing jstree to support cascading as well as non-cascading selection, based on the user's preference.

Most setting will work when changed at runtime, but that is not officially supported. But the three_state setting will not work I am afraid, and I do not plan on adding support for that - sorry.


External Service UI issues

Date - 12/3/19
Results:

[x] The target radio options should be horizontal not vertical with the field below

[x] Space needs to be added between the Name/Namespace and Target title as well as between Target title and radio options.

[ ] The Service list drop-down needs to be bigger and the "Select a Service" text needs to show up instead of it being empty.

[x] Spacing needs to be added when I select list of IP Addresses from Target

[x] Probably a little space needs to be added as well when I select DNS name

[x] Cancel needs to be first and Create on right of it.

I'll need @mantis-toboggan-md to fix the drop down


Fixing the linking errors for tests when default modules are not built

This should prevent failures of automatic build tests on dashboards

:100:


Custom Range, calendar widget allowing start date as future date and current date as end date

Sm date picker is working fine. In custom range when select the start date, it disabled the previous arrow icon and also disabled the previous dates. But middle month& year button is not disabled. We can select the button and go to the previous years and months. In the previous year and months dates are disabled. But when we click on the "ok" button, start date and end date values are not coming correctly. If disabled the previous year and  months also it is fine or give the validation message for start date end date , it is fine.
Please provide  the solution.

I have fixed min year problem but working on max year will take some time. i am pushing fix to this issue please check

@mominsamir let me know if you need help with this issue or any other reported bug and I can take a look.

Hi oscar09,
Thanks for your reply.
I give the demo link. I tried with "Close on Select Date-Time Range Picker".
http://mominsamir.github.io/smDateTimeRangePicker/#!/range-picker-demo
The issue is in CUSTOM RANGE selection. Once select the start date, it does not allow to select previous date as end date, but it allow to go to previous years through middle month&year button , it is after start date end date headings. We can go to previous years , but can not select dates. It is fine and all the previous dates are disabled. But at the scenario if we select OK button of the end date calendar, the selection date which are start and end dates are not related to selection. Some times different dates placed in the text box i.e.
in picker.js line number 1687 I changed the code. I added the code below
if(!startDate && !endDate)
{
_ng_model_value = '';
}
else if(Date.parse(startDate) > Date.parse(endDate))
{
_ng_model_value = '';
}
else
{
startDate = startDate || 'Any';
endDate = endDate || 'Any';
_ng_model_value = startDate + ' ' + divider + ' ' + endDate;
}
Need validation If user select future date as start date and previous date as start date. Just look at the above solution. need to change the above code and give the validation for the scenarion.

Got it. I will try to fix it.

I believe it is fixed now. Please give it a try when you have a chance. Basically, instead of displaying an error, I am  disabling the past dates.
Also, I commented out lines 65 to 72 from calender-date.js. An extra day was being subtracted from the min date, which allowed you to input past dates on the date range. The code was added by Pablo, but I didn't delete it because I still need to find out which bug was intended to be fixed with that code.


extend gradle config without chaning build.gradle

hello Maksim,
first of all thank you for sharing your project templates. 👍
the proposed change would allow you to extend your gradle configuration without changing build.gradle by just placing more *.gradle files in /gradle. it helps me start with a small initial configuration and add features as needed (f.e. with sub-generates)
best regards,
Yevgeniy

Hi, thanks for your contribution, but at the moment it's not true.
Think is that not all ./gradle/*.gradle files actually could be applied in same time. for instance main.gradle is not compatible with spring-boot.gradle as well as for example kotlin.gradle will not work if proper plugin wasn't applied in a plugins / buildscript block


Any way to use it from Python?

Hey :)

Yes. This is the only way to use it.

@blizzrdof77 how??? I only see a way to use it from CLI in the Readme


build and install wsktool raises problem.

With current codebase, when I try make build, the go will complain "fatal: repository 'https://github.com/openwhisk/go-whisk/' not found", because currently the repo doesn't exists.
So the import will fail.
If I change the package import source code to github.com/openwhisk/openwhisk/tools/cli/go-whisk/whisk, the go will complain that
" Installing dependencies
$GOPATH/src/github.com/openwhisk/openwhisk/tools/cli/go-whisk/whisk/client.go:31:5: local import "../wski18n" in non-local package"

It seems the reason is here:https://golang.org/cmd/go/#hdr-Relative_import_paths

Will close for now given temporary location of go-whisk repo.  There is open issue in the core OpenWhisk to look at setting this up.
See: https://github.com/openwhisk/openwhisk/issues/1480


Regarding attention weights

Hello,
It seems to me that flash attention always returns None as attention weights: https://github.com/HazyResearch/flash-attention/blob/d478eeec8f16c7939c54e4617dbd36f59b8eeed7/flash_attn/flash_attention.py#L71
Is there a reason why the weights cannot be returned?
Thanks!

Yes, because the attention weights have size N x N, where N is the sequence length. FlashAttention aims to reduce memory reads/writes, so it does not materialize the attention weights.


Wiki Incorrect Arguments for Registry Setup

The wiki page for factory and member injector setup incorrectly passes a FactoryRegistry to MemberInjectorRegistryLocator.setRootRegistry

Fixed! thx @eygraber


Hosts UI

Summary of the Pull Request

Title bar
few strings
sizes here & there
Dim the title bar when the window is inactive

To-do:

[ ] sort out the Grid > ListView > DataTemplate > Grid structure, so that the (inner) Grid is actually one grid so that the first column width can be set to Auto. Currently, each row is an independent grid.
[x] ~merge mainpage into mainwindow ?~

PR Checklist

[x] Closes: #27261
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
Visual Studio

What's this framework again?

@jay-o-way Is this ready for review as there are to-do items?
Note: please do NOT merge MainPage with MainWindow.. there are some known quirks that could cause things not to work. It's also best practice to use pages within Windows, makes it easier to update / support multiple pages as well.

Self-reminding note: for easy debugging, replace L81 in MainViewModel.cs with : paths = new string[1] { "C:\\Program Files" };

The Grid structure is not a blocking issue and may be done in a new PR. Would love to wrap this/these up.

Done InfoBar and Icon and Title

Done InfoBar and Icon and Title

The InfoBar now blocks the last item on the list where it was inline before, right? I can imagine we might get a a11y flag on this..

Might be a nice scenario for the StackedNotifcationsBehavior in the future

True. It's in the same grid "cell" now as the ListView is, aligned at the bottom. I had difficulty finding a nice solution. The bars must be in a StackPanel, because if they overlap, one is transparent. If I set a bottom-margin or top-margin on any of them, the margin is maintained even when they are not Open/Visible. (could that be a XAML bug, maybe?)

True. It's in the same grid "cell" now as the ListView is, aligned at the bottom. I had difficulty finding a nice solution. The bars must be in a StackPanel, because if they overlap, one is transparent. If I set a bottom-margin or top-margin on any of them, the margin is maintained even when they are not Open/Visible. (could that be a XAML bug, maybe?)

The object is closed, yet still taking its place in the UI. Setting Visibility="Collapsed" probably works!

The object is closed, yet still taking its place in the UI. Setting Visibility="Collapsed" probably works!

I guess this was previously working since there was no spacing in the grid.
@Jay-o-Way you should be able to bind for both info bars IsOpen and Visibility to the bool property. Should fix the problem.

Yep, finally got it!


Angular demo code does not work

The liveQuery example on stackblitz does not work.
https://stackblitz.com/edit/angular-ivy-4666q1?file=src%2Fapp%2Fitemlist.component.ts

Open the link in 2 windows
Add an item
The update only happens in one window, not both.

It does work for all the other frameworks.

Thanks! Dexie detects the changes but angular fails to re-render when the observable emits a new value if the change originates from another tab. The reason is most probably that angular does hook into the BroadcastChannel API (which is the one we use to communicate changes across tabs). There is probably a doable workaround for this. I've found this article about it:  https://www.acagroup.be/en/blog/how-to-use-the-broadcastchannel-api-angular/.
If someone finds a nice way to patch the sample to update when changes happens on other tabs, please fork the stackblitz sample and post a link!

I know this problem.
You can fix it by using an official rxjs patch from zone.js:
import 'zone.js/dist/zone-patch-rxjs';

Be sure to NOT use this patch in the polyfill.ts but use it in your main angular bundle code.
Related: https://www.bennadel.com/blog/3448-binding-rxjs-observable-sources-outside-of-the-ngzone-in-angular-6-0-2.htm
Working example here: https://github.com/pubkey/rxdb/blob/master/examples/angular/src/app/app.component.ts#L12

Great thanks guys!


Move xorm logger bridge from log to models so that log module could be a standalone package

As title.

Codecov Report

Merging #6944 into master will increase coverage by 0.01%.
The diff coverage is 45%.

@@            Coverage Diff            @@
##           master   #6944      +/-   ##
=========================================
+ Coverage   41.39%   41.4%   +0.01%
=========================================
  Files         441     441
  Lines       59733   59729       -4
=========================================
+ Hits        24727   24732       +5
+ Misses      31767   31758       -9
  Partials     3239    3239

Impacted Files
Coverage Δ

modules/setting/log.go
74.76% <ø> (+1.03%)
:arrow_up:

models/log.go
41.86% <44.44%> (ø)

models/models.go
56.59% <50%> (ø)
:arrow_up:

models/repo_list.go
66.84% <0%> (-1.06%)
:arrow_down:

routers/repo/view.go
43.03% <0%> (+1.01%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e057eb...4b1191b. Read the comment docs.


[New I/O Site] Create github repository with default gatsby site

Description
This should include branch protection for main (this repo will not use a develop branch), adding the team as contributors, an initial readme, and the default site created by the gatsby cli.
AC

[ ] A new repository exists under the newrelic org, called instant-observability-website
[ ] The main branch requires at least 1 approval to merge
[ ] The repository contains the default site created by gatsby create
[ ] The repository contains a README with instructions on how to develop and deploy the site

@aswanson-nr will add some details with steps to how we create a repo in the newrelic org.

New repo is alive! 🥳 Instant-Observabilty-Website

🥳

PR's mentioned above merged into I/O Repo. 🎉