Versioning in Rapid Pro

Discussion how to avoid versioning problem in Rapid.
More info
https://blog.echobind.com/8-business-reasons-to-adopt-graphql-and-apollo-server-c2e0e9655310#d8cb

I would be fine with saying that the default is to return key fields (or odata.id) if no select is specified.
Note that OData also defines a revisions vocabulary that can be used to mark added/changed/deprecated elements. We are planning on using the deprecated revision in MS Graph to announce deprecated elements that will be removed in a future version of the endpoint or after telemetry shows it is no longer in use.  We will drive doc experience off of this, as well as validate URLs and raise a warning if they return deprecated elements.

Define way to represent deprecation in RSDL
-generates revisions annotation in CSDL
Based on Revisions annotation (RevisionKind=deprecated):
-reflect in generated documentation
-urlvalidation/builder input
-reflect in generated classes
-track usage
-return sunset, deprecation headers
remove after period of unuse
-benefits over rev'ing entire endpoint -- only those affected have to change


Unable to use pipe in component

Hello,
I am trying to use the pipe in the component as follows:
        constructor(private fonticon: TNSFontIconService) {
		var logo = this.fonticon.transform('fa-plus');
	}

But I see the following error:
[ts] Property 'transform' does not exist on type 'TNSFontIconService'.
also tried this:
constructor(private fonticon: TNSFontIconService, private pipe: TNSFontIconPurePipe) {
       var logo = new TNSFontIconPurePipe(fonticon).transform('fa-plus');
}

this fixes the syntax error
constructor(private fonticon: TNSFontIconService, private test: TNSFontIconPipe) {
		var x = this.test.transform('fa-plus', []);
	}

but it does throw a runtime error No provider for TNSFontIconPipe! I have included TNSFontIconService and TNSFontIconPipe in the appModules providers
what am I missing here?

@NgSculptor try this if you want to use it manually:
import { TNSFontIconService, TNSFontIconPurePipe } from 'nativescript-ng2-fonticon';

constructor(private fonticon: TNSFontIconService) {
       var logo = new TNSFontIconPurePipe(fonticon, []).transform('fa-plus');
}

You don't want to inject the pipes since they are not providers. Just import and instantiate manually. Also keep in mind the TNSFontIconPurePipe is intended to be used in cases where you know your collections have already loaded since they rely on the collections being fully loaded.
TNSFontIconPipe can only be used in a view binding since it relies on the Pipe decorators pure: false setting to update the view through the injection of the ChangeDetectorRef:
https://github.com/NathanWalker/nativescript-ng2-fonticon/blob/master/src/app/pipes/fonticon.pipe.ts#L14
which is manually marked here:
https://github.com/NathanWalker/nativescript-ng2-fonticon/blob/master/src/app/pipes/fonticon.pipe.ts#L30
therefore you can't really use that one manually.
Also ensure you are importing TNSFontIconModule and have it configured properly per the README:
@NgModule({
    imports: [
        NativeScriptModule,
        TNSFontIconModule.forRoot({
            'fa': 'font-awesome.css'
        })
    ],
    declarations: [
        AppComponent
    ],
    bootstrap: [
        AppComponent
    ]
})


is React\Http\Message\Response::plaintext binary safe? how am i supposed to respond with binary data?

lets say i want to respond "\x06\x00\xFF\xFFinfo" , how am i supposed to do that?
seems the documentation is not clear on whether  or not "Response::plaintext()" is binary-safe or not, and how one is supposed to respond with binary data..?

nvm, yes it is binary safe.

@divinity76 Interesting question!
The plaintext() method expects a valid Unicode string encoded as UTF-8, as per the documentation: https://github.com/reactphp/http#plaintext
The string \x06\x00\xFF\xFFinfo is not valid UTF-8, so you probably shouldn't be using this method. The method itself is binary safe, but only guarantees to accept valid UTF-8. Future versions may reject and/or replace invalid UTF-8.
As per the documentation, you can always create a custom HTTP response like this:
$response = new React\Http\Message\Response(
    React\Http\Message\Response::STATUS_OK,
    [
//      'Content-Type' => '???'
    ],
    "\x06\x00\xFF\xFFinfo"
);

I hope this helps! :+1:


Implementing Lanczos algorithm as a new solver method

Summary
Lanczos algorithm is an approximate diagonalisation method. It is implemented as an LMDE method and is a considerable speedup compared to scipy.expm
Details and comments
This PR adds a new fixed-step solver method lanczos_diag. This method only works with hermitian generators and works best in sparse evaluation mode. A follow up with a Jax implementation of the same is in progress.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Regarding y0 being a matrix:
When Lanczos is initialised using y0 as the seed, we can skip computing the matrix exponential since the equation simplifies to something in terms of the Lanczos basis and tridiagonal matrix.
However, when this is not possible, I could seed using a random vector -> compute the matrix exponential, -> find action on expm on the y0 matrix.
This change would affect the speed only a little bit, but this also takes a toll on the accuracy. This is because the rows of Q (the basis vectors) are not perfectly orthogonal.
To mitigate this, one has to perform a QR decomposition which adds to the runtime. However, since we QR decompose, one could make do with a smaller k_dim value.
@miamico what do you think?

Regarding y0 being a matrix: When Lanczos is initialised using y0 as the seed, we can skip computing the matrix exponential since the equation simplifies to something in terms of the Lanczos basis and tridiagonal matrix. However, when this is not possible, I could seed using a random vector -> compute the matrix exponential, -> find action on expm on the y0 matrix.
This change would affect the speed only a little bit, but this also takes a toll on the accuracy. This is because the rows of Q (the basis vectors) are not perfectly orthogonal.
To mitigate this, one has to perform a QR decomposition which adds to the runtime. However, since we QR decompose, one could make do with a smaller k_dim value. @miamico what do you think?

I'm still thinking how to deal with an initial matrix instead of a vector. If it's just about batching many initial vectors which are put together into a matrix, couldn't we just do Lanczos on each of the columns (or rows) of the matrix which represent a vector?

@DanPuzzuoli, I've made the requested changes. As for rectangular arrays, I've modified the code so that we run a Lanczos iteration for each row, as @miamico suggested. Let me know what you think.

@DanPuzzuoli, I've made the requested changes. As for rectangular arrays, I've modified the code so that we run a Lanczos iteration for each row, as @miamico suggested. Let me know what you think.

Okay awesome, TY. I'm ending early today, but will take a look next week.

@DanPuzzuoli
Thanks for those examples. The if: break condition in the loop was supposed to handle these div by zero errors. However, it comes only after one run of the loop. In those examples you mentioned, It hit zero before the loop starts. I've fixed it now by moving the if condition to the top.
The JAX version (not part of this PR) does not have that if: break condition. I might text you on slack when I get to that.
I believe the CI is not automatically running the tests yet. Can you check that?
I've made all the fixes as suggested. Although I'm not sure about the names I've given to the test functions, let me know if they're okay.

I've made the changes and changed lanczos_expm to store the norm and multiply it later. Thanks, @DanPuzzuoli.
Now I'll add the Jax code to this branch

Hi @DanPuzzuoli, I've got the changes done. However, I implemented the scan based looping in a slightly different way than you had suggested with some inspiration from  fixed_step_solver_template_jax. This method uses only one scan, I guess that's a good thing. The cost is a bunch of loops that return zeros.

Hi @DanPuzzuoli
I fixed all the inline comments.
Regarding using sparse mode for regular tests,
I ran into a bunch of errors for the NumPy backend (aka scipy.sparse.csr_matrix).
sparse mode doesn't seem compatible with rotating_frame.
Here's an example (on the main branch)
import numpy as np
from qiskit_dynamics import Solver, Signal
from qiskit_dynamics.array import Array

sparse_solver = Solver(static_hamiltonian=np.array([[0,1],[1,0]]),
                       hamiltonian_operators=[np.array([[0,1],[1,0]])],
                       rotating_frame=np.array([[0,1],[1,0]]),
                       evaluation_mode='sparse'
                      )

res = sparse_solver.solve(
    t_span=[0., 50],
    y0=np.array([0,1]),
    signals = [Signal(Array(1.), carrier_freq=5)],
    method="odeint"
)

# TypeError: operand type(s) all returned NotImplemented
# from __array_ufunc__(<ufunc 'matmul'>, '__call__',
#                      [<2x2 sparse matrix of type '<class 'numpy.complex128'>'with 4 stored elements in Compressed Sparse Row format>],
#                      Array([[-0.70710678-0.j,  0.70710678-0.j],
#                             [ 0.70710678-0.j,  0.70710678-0.j]], backend='numpy')
#                     ): 'list', 'Array'

Things work fine with JAX sparse + rotating_frame for the same example.

Nice bug find. This is a bit of a weird example that I'll need to think about a little to figure out the proper fix.
The reason it hasn't been found before is due to the expected usage that if a user sets evaluation_mode='sparse', then their frame operator is already diagonal (and specified as a 1d array).
For a bit of background: A user can specify the frame operator as a 1d array as a way of explicitly telling Dynamics that it's already diagonal. The main reason this is "expected usage" for sparse evaluation mode is that internally Dynamics always represents all operators in a basis in which the frame operator is diagonal - if it isn't diagonal, it has to change the basis of all other operators. If the operators are sparse, you don't want to do a change of basis (which could ruin sparsity), so specifying the frame operator as a 1d array is something we put in to allow the user a pathway to prevent Dynamics from trying to do any basis changes.
That all being said, everything should still work if the frame operator is not given as a 1d array, but it seems that we've really baked the "expected usage" into our tests, so we've missed the bug so far. I think this will be a quick fix, and will get back to you.

Okay #118 should solve this issue. The example you provided is working (though you need to change the method to something like 'RK4' rather than 'odeint'.

Didn't look at the tests again but just scanned through everything else and looks good. Let me know if you get the tests working, and I'll do a final holistic review.

Thanks for the quick resolution. The tests are working.


Selfmute

Please add in a selfmute command that mutes the user on the server for a specific amount of time that they choose.
The command would work as, well Joe already knows how it works, he just wants me to make an issue, but it's like !selfmute <time>.
Most of the code for this is already written in the tempmute command. The command would need to be cloned from tempmute. It would remove the restrictions on who can use it, and instead of taking in input of who to mute, it would mute the person sending it. It would also need to not add in an infraction every time the user uses it.
Here is an example of how it might work: courtesy of Joe:

Realworld uses: Many times people want to avoid distractions, and keep themselves from talking on the server, however, shutting down discord entirely is not an option. This command would let the user work distraction-free, while still having access to the rest of discord.

Joe doesn't just want you to make an issue. You should describe why you
think this should be a command, and how it should work from a technical
perspective as well.  But I have indeed updated the issue to include that information!

This isn't justified to me. My proposed alternatives:

Temporarily leave the server
Have more self control to not visit the server or write in there

+1 to Mark’s comments here.
There are many tools which can prevent this. For example, Apple has a screentime tool which allows users to lock app access. This feels out of scope for our bot.

Acutally, you're right. I'll just create something.

This dude is a bigbrain

I would just like to add that if you don't want to leave the server for any reason, logging out of discord is also a good option


fix Fix unable to export empty data (#30703)

Proposed changes
Issue Number: close #xxx
cherry-pick #30703
be/src/io/fs/s3_file_writer.cpp has some diff, but the logic is the same.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


viewer

The output file is not human-readable, so it is desirable to provide some human-readable viewer.

As for the RO-Crate, it has a function to generate the preview in a html format.
I think it helpful to provide it even only for the RO-Crate format.


Adding bulk remove API where users can remove multiple resources and service does the orchestration.

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

ARM API Review team is trying new model where only new RP addition is requires API review. Please make sure you review the API surface area with senior members in your team, and continune following the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/202/Overall-Process-of-AME-Onboarding

/azp run automation - sdk

ARM API Review team is trying new model where only new RP addition is requires API review, hence removed the WaitForARMFeedback.

The PR looks good to me


element is unfixed before its real position

thank you for this plugin, i think I finally have it working on a wordpress site, I am trying to emulate the floating / fixed footer element that fades in and then sticks in place as you continue to scroll on this page: [http://www.sungevity.com/] (http://www.sungevity.com/).
I have mine fading in and sticking to the bottom, but disappears way before its actual position in the html.
I played with the test-min.html that comes with the download and moved is all over the place, even added more content before and after and it still works wonderfully, but not sure why it disappears / becomes non-fixed to bottom before it is suppose to with mine.
any help would be wonderful.
is it an offset issue?
-gerald

I took a look at your website. Very nice! I did not see that the footer is using the scroll to fixed plugin. You might have removed it?

no no. it is on a working site that is not live yet.
actually local so far, as we are testing things before we go live.
stage.thatsbyers.com  is the staging site, but i have it local, so it
is not on that yet as I cannot get it to work correctly.

Preview: I took a look at your website. Very nice! I did not see that This email is forwarded from a MASKED EMAIL you created using DoNotTrackMe. IF THIS IS SPAM, CLICK HERE TO BLOCK. Want to shop safely and privately online? Get DoNotTrackMe Premium. I took a look at your website. Very nice! I did not see that the footer is using the scroll to fixed plugin. You might have removed it? — Reply to this email directly or view it on GitHub.

Usually it is an offset issue. If it is possible for me to take a look, I might be able to see what the correct solution is.


fix: product type bug and return validity default set

Description
This PR does a few things. There was a bug in the Netex-converter where we were setting a value based on the ticket period being in days, when it should have also been checking that the number of days was '1'. Also, we are setting the return period validity to 1 day, if the user selects no on the returnValidity page in the site.
Lastly, this PR alters our test data so that all of the tickets we use have 1 product in, which is inline with what the site generates.
Testing instructions
Generate some Netex and view that  correctly is set for tickets that are 1 day (they should be dayPasses etc).

multiOpGeoZone.xml has a name of 1 day but it product type period pass is that intended?


fiber link : big differences between browsers

Hi
I have a 100MB fiber optic link.
Firefox :
=> Upload : 79.079 MBps
=> Download : 98.210 MBps
Google Chrome :
=> Upload : 79.953 MBps.
=> Download : 50.461 MBps.
On Google Chrome, the download result it's always around 50MB.
It's a interne limit of Chrome ? (Same problem with Chromium).

Unable to reproduce, closing. I don't have any fiber optic link to try this. Feel free to make a pull request if you want to see this fixed.


Add ReplicaSet support

Add ReplicaSet support. Adopted from https://github.com/mcornick/central_logger/commit/1f52d75bd5108194eeb6647a41a1fad274d7f515

Done. Thanks.


How should I project the lidar data to the camera image with the depth in v2?

I use following code to generate the 3D point cloud with [N, 3] in (x, y, z)
lidar_calib = read('lidar_calibration')
camera_calib = read('camera_calibration')
lidar_pose = read('lidar_pose')
vehicle_pose = read('vehicle_pose')
df = v2.merge(lidar_calib, lidar)
df = v2.merge(df, lidar_pose)
df = v2.merge(df, vehicle_pose)
df = v2.merge(df, camera_calib)

for i, (_, r) in enumerate(df.iterrows()):
    lidar = v2.LiDARComponent.from_dict(r)
    lidar_calib = v2.LiDARCalibrationComponent.from_dict(r)
    camera_calib = v2.CameraCalibrationComponent.from_dict(r)
    lidar_pose = v2.LiDARPoseComponent.from_dict(r)
    vehicle_pose = v2.VehiclePoseComponent.from_dict(r)
    if np.all(lidar.key.laser_name == 1) == True:
        print(lidar_calib)
        print(camera_calib)
        pc1 = lidar_utils.convert_range_image_to_point_cloud(lidar.range_image_return1, lidar_calib, lidar_pose.range_image_return1, vehicle_pose)
        with open(f'lidar{lidar.key.segment_context_name}_{lidar.key.frame_timestamp_micros}.npy', 'wb') as f:
            np.save(f, pc1)

The 3D point cloud data like this

And the camera image like this

And How to projection lidar distance on camera image in v2?
I don't find any v2 function with projection the 3D data to 2D data on image like this?

You may first convert a range image from polar coordinates to Cartesian coordinates by convert_range_image_to_cartesian, then load camera projection (v2.LiDARCameraProjectionComponent), extrinsic and camera image size (v2.CameraCalibrationComponent) and call build_camera_depth_image.


Added a flag that stops longpolling for exited browsers

What's the reason for making this flag uppercase?

On Aug 14, 2015, at 9:16 PM, Matthew Marcus<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/baudehlo/node-phantom-simple/pull/68
Commit Summary
Added a flag that stops longpolling for exited browsers
File Changes
M node-phantom-simple.js (6)
Patch Links:
https://github.com/baudehlo/node-phantom-simple/pull/68.patch
https://github.com/baudehlo/node-phantom-simple/pull/68.diff
—
Reply to this email directly or view it on GitHub.

@baudehlo i guess, similar to .POSTING https://github.com/CaptoraInc/node-phantom-simple/blob/203ceebf1123adef4db835b217e8d9247d11af8a/node-phantom-simple.js#L407
@Kirill89 will take a look what can we do with it.

Solved by https://github.com/baudehlo/node-phantom-simple/commit/126cd63c848c96d020c49b83e0b527cd85226b22

Awesome.  Glad this was fixed in the other PR.  Just for clarificaiton, I orginially considered using phantom.killed as the value to base the conditional off of, the only reason I went w/ creating a separate flag was because of another conditional in the code that I saw: https://github.com/baudehlo/node-phantom-simple/blob/126cd63c848c96d020c49b83e0b527cd85226b22/node-phantom-simple.js#L619
I was conscerned that, since the dead || phantom.killed was used elsewhere, that we would not be catching some use cases and would still see some CPU leakage.
It looks like dead is being set to true if and when phantom throws the 'exit' event.  Should we be checking against that value in the conditional used for killing the long-poll as well?

@puzrin, any feedback on the above?  Just want to make sure we're not missing an edge case w/ the PR that was merged for this..

@RavenHursT sorry, busy with embedza design & bugs. I did a mark for Kir to take a look in 1-2 days.

Awesome.  Thanks @puzrin

@RavenHursT looks like you are right. I will fix it. Thanks for your help.

Np @Kirill89 Can you ping back here whenever this has been updated and released so I can pull?

https://github.com/baudehlo/node-phantom-simple/commits/master

Awesome.  thanks guys.


Ctrl-hover on images URI opens a new tab

VSCode 1.21.1, plugin 2.1.7.
Open any glTF 2.0 asset that uses textures (e.g. glTF-Sample-Models/2.0/BoxTextured/glTF/BoxTextured.gltf).
Ctrl-hover (without clicking) on image (e.g. /images/0/uri) URI.
A new tab with image appears.

A new tab shouldn't appear without clicking.

I think this going to be a "won't fix". If you want a hover image just release the Ctrl and you'll get the normal image preview. onDefinition doesn't give any context about how its being used so changing behavior isn't possible. Its actually pretty hacky to get what we have working well as the system is built around navigating and presenting text documents.

Sorry, I don't quite understand.
It's possible to Ctrl-hover over, e.g., Draco pointers and see some values in tool-tips. Ctrl-click opens a full list of values in a new document. Why can't image URIs behave the same way?

VSCode's onDefinition system provides a document URI and a cursor location and it expects a URI and a cursor location back. For JSON definition this works pretty simply; we use the same URI and find the location of the pointed to object. For data buffers we craft a new data URI which includes information on what accessor is under the cursor. The protocol handler for that data URI transforms the accessor into a new text document and VSCode shows this content where appropriate. For images the same type of data URI is constructed but we can't present text; we need to command VSCode to open a tab and show the image in an HTML page. We had in previous revisions of the extension just returned a URI directly to the image (which is what you see when hovering with out Ctrl). VSCode limits the size of images it will open in this way to 1MB and as you can see with the hover doesn't scale the image so you can see the whole thing in the editor window.
I can open an feature request with VSCode to allow definitions to return an HTML document. With this capability we'd be much more able to handle all the cases as expected.

Can't reproduce this anymore.  I think it was fixed upstream.

Can't reproduce this anymore.  I think it was fixed upstream.


Upgrade nlopes/slack to Fix Message Parsing

What is this about
Upgrade nlopes/slack to the latest in order to get the fix for https://github.com/nlopes/slack/issues/630.
Checklist

[x] I've reviewed my own code
[x] I've executed go build ./... and confirmed the build passes
[x] I've run go test ./... and confirmed the tests pass

@cflee : I don't know if you're running a bot powered by slackscot but, if so, you might have started having issues with all messages coming resulting in a failure to parse (and therefore all reactions to messages being broken). This upgrades the nlopes/slack dependency to bring in the fix but you could also just go get github.com/nlopes/slack@d06c2a2b3249b44a9c5dee8485f5a87497beb9ea in your repo to achieve the same.


Improve the 'E24 - actionElementNotFoundError' error message.

The current message is the following:
The specified selector does not match any element in the DOM tree.

> Selector('some-selector')

Need to add steps to fix the problem to customers can fix the problem by yourself.
For example:
Make sure the matched element exists on the tested web page, has non-zero width and height and it is not hidden by CSS rules 'display: none' and 'visibility: hidden'. Also, check that the expected element is not in another browser context (in an iframe). If it's true, call the 'switchToIframe' method to switch test execution context to the target iframe.

It the text is very long for the error message, we can just add a link to the troubleshooting guide.

https://github.com/DevExpress/testcafe/issues/5030
https://github.com/DevExpress/testcafe/issues/1533
https://stackoverflow.com/questions/55028357/trouble-finding-element-node-using-testcafe-selector-or-testcafe-react-selector
https://stackoverflow.com/questions/54317489/clicking-a-button-based-on-the-text


PEAR-1083 - Custom filters should retain the parent category

Description

Checklist

[x] Added proper unit tests
[x] Left proper TODO messages for any remaining tasks
[x] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good! 👍


Fix snapshot restore wait

Before starting the restore, send a list of namespaces to the operator to be cleared. The namespaces come from the spec of the Backup that is being used for the restore. The operator will use discovery and dynamic clients to list all resources in those namespaces and delete anything that has a kots.io/app-slug annotation matching the app that is being restored. This is necessary for deleting PVCs created by StatefulSets. The operator will not report the undeploy is complete untill all resources for the app are gone from the namespaces.
Fix the restore sequence. The current deployed sequence being snapshotted should come from the app_downstream table, not the app table.
Fix the prefix in the kotsadm-velero-backend BackupStorageLocation template to prevent velero pod getting into a crash loop.

looks good, though I'd rather include the annotation in the generated yaml instead of adding it via operator

I'm going to merge like this. This will need to change from app slug to app ID anyway so we can update the implementation then.


IS there  a  function test  ,  integration (system) test  for hygieia ??

@samyzemmouri - for general questions and operational support please go to gitter.im and start a conversation there. As this is a general question and not an issue, per se, I am going to close this issue. I look forward to talking to you on gitter.im


TOS forward

Title: Envoy TOS field forward support
Description:

Hi,
I would like to propose TOS field forwarding in IP datagram for UDP protocol. I've managed to simply implement this mechanism (fow now without any tests), because I would like to know if proposed solution is reasonable. If so, I would like to get a code review. Is there any chance this functionality could be merged to master?

linked pull request #19334

Is there anyone who would like to help me solve this issue?


[TextAnalytics] AnalyzeHealthcareEntities_Cancellation failing in nightly runs

TextAnalytics runs are failing with:

Error message
Azure.RequestFailedException : Failed to cancel job with job id 07fc2546-2650-4720-932f-aec164c25cb5 as its already completed.
Status: 400 (Bad Request)
ErrorCode: InvalidRequest
Content:
{"error":{"code":"InvalidRequest","message":"Failed to cancel job with job id 07fc2546-2650-4720-932f-aec164c25cb5 as its already completed."}}
Headers:
Transfer-Encoding: chunked
x-envoy-upstream-service-time: 10
apim-request-id: e5778255-cd4d-4610-bc6b-1002f659d112
Strict-Transport-Security: max-age=31536000; includeSubDomains; preload
X-Content-Type-Options: nosniff
Date: Thu, 20 Jan 2022 02:53:39 GMT
Content-Type: application/json; charset=utf-8
Stack trace
at Azure.AI.TextAnalytics.TextAnalyticsRestClient.CancelHealthJob(Guid jobId, CancellationToken cancellationToken) in D:\a_work\1\s\sdk\textanalytics\Azure.AI.TextAnalytics\src\Generated\TextAnalyticsRestClient.cs:line 307
at Azure.AI.TextAnalytics.AnalyzeHealthcareEntitiesOperation.Cancel(CancellationToken cancellationToken) in D:\a_work\1\s\sdk\textanalytics\Azure.AI.TextAnalytics\src\AnalyzeHealthcareEntitiesOperation.cs:line 246
at Azure.AI.TextAnalytics.Samples.TextAnalyticsSamples.AnalyzeHealthcareEntities_Cancellation() in D:\a_work\1\s\sdk\textanalytics\Azure.AI.TextAnalytics\tests\samples\Sample7_AnalyzeHealthcareEntities_Cancellation.cs:line 41

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1314633&view=results

@jsquire for notification.

closing in favor of https://github.com/Azure/azure-sdk-for-net/issues/26528


[util] Allow optional tools in check_tool_requirements

tool_requirements.py lists minimum versions for tools, but the
distinction between "tools that absolutely need to be installed" and
"the minimum version of a tool if you want to run it" was baked in to
check_tool_requirements.py
This patch moves that distinction to the (more user-editable)
tool_requirements.py. Tools that are marked as_needed aren't
checked unless they are passed on the command line to
check_tool_requirements.py.
If this gets merged, I intend to do a follow-up PR to check e.g. VCS version as part of a dvsim run.

Force-push adds the VCS_ARCH_OVERRIDE environment variable and sorts out the platform number snafu.

Force-push adds the VCS_ARCH_OVERRIDE environment variable and sorts out the platform number snafu.

Some more candidates for optional tools would be AscentLint, Vivado and DC. However, we can add these later on once this has landed.

Yep, definitely. I just didn't want the "framework" changes to get embroiled in discussions about exactly what version of what tool etc.

Some more candidates for optional tools would be AscentLint, Vivado and DC. However, we can add these later on once this has landed.

Yep, definitely. I just didn't want the "framework" changes to get embroiled in discussions about exactly what version of what tool etc.


update Gem dependencies + add additional_criteria option for conditions

Based on another PR of a similar nature, this one also updates the Gem dependencies as well as fix the offending line causing tests to fail

Other PR this is based on: https://github.com/andreapavoni/panoramic/pull/22

Hey @RubyBrewsday thank you very much for your PR. Travis is still failing because of the rails-controller-testing gem, but it should be a false flag.
Thanks ❤


Two install instructions for ToC

Git's readme says "download toc.js and toc.css and add this code to custom.js". However, toc.js gives a different piece of code to add to custom.js.
The first one worked fine for a small notebook that I have, but not for a large one for which I had to increase the RequireJS timeout. Removing the stuff I added to custom.js (the install way from README.md) and adding what the toc.js file suggested (after the line that is increasing the timeout) fixed my problem, so maybe README.md should be updated with this.
It probably doesn't matter much, but I'm running IPython Notebook Server 3.2.0-8b0eef4 with Python 3.3.2.

Fixed, thanks.


Ignore words

Would it be possible to define a list of ignored words, maybe per filetype?
E.g. In python I have some # noqa: SOMECOME to disable a specific linter in the line, which are not proper words

It is possible; try zg
You can read more here or use vim's help feature

@e2oneedh2o  should be the accepted answer.


Add custom attribute to force static PInvoke resolution

Add PInvokeStaticResolutionAttribute which overrides the logic that
decides whether the PInvoke will be resolved by the compiler or lazily
at runtime. For multi-module compilation it is preferable to have
PInvokes all resolved lazily since we compile everything and there may
be unresolvable (but un-used) PInvokes.  However some PInvokes occur
early enough on the startup path that we can't do lazy resolution yet.
For example, calling LoadLibraryEx causes an infinite loop.

We have support for '*' as .dll name that basically means the same thing. Mono AOT has the same thing, except that they use __Internal instead * as the special name.
I am wondering whether we really need yet another way via the custom attribute. Why not just use '*' or __Internal ?

cc @yizhang82

I'm not a fan of __Internal

Even though __Internal may not be pretty, we should think about how to make it work in our system to be compatible with Mono.

it could very well be a real thing

It is pretty unlikely that you will have a library called __Internal. We have similar crutch with treating [MRT] as a special name. It can be a real thing as well, in theory.

it make more sense to resort to compiler switch to specify certain DLLs

I tend to agree that compiler switch should be one of the options to control it. It seems to be recurring pattern, e.g. the reflection policy is similar. The choices always end being:

Reasonable built-in default policy so that things work well most of the time.
Custom attribute that you use if you know what you are doing. I think the per method custom attribute in this case needs to allow both directions - force lazy loading even for cases where the default policy says to eager load.
Compiler input to handle 3rd party libraries that you do not have a control over; or if it does not make sense to bake the policy into the managed library.

However we may dislike having all three, we always end up with having all tree eventually because of each of them is needed to handle different scenario.

These are great points. Thanks, @jkotas

I thought using * was supposed to be a temporary hack that we're planning to move away from. A custom attribute self-documents the intent.  If we're fine with keeping on the * plan I'll can this change for now.


Remove application and version from appengine-web.xml template

fixes #827
Should not be merged until gcloud is updated .
This removes application and version from all appengine-web.xml template files (including test data).
It also updates the appengine-web xsd (see the link from here: https://cloud.google.com/appengine/docs/java/config/appref).

LGTM!

todo: prior to merging confirm that the updated xsd is still the latest one.

looks like this is now supported by gcloud 131

@etanshaul I think it's time.

This is ready for review. However, even though gcloud supports it now, I think we should wait for https://github.com/GoogleCloudPlatform/google-cloud-intellij/issues/1051 to go in first

@patflynn @joaoandremartins @aslo
This is ready for review. Now that we have a minimum sdk version check this can be merged in.

Can we merge this and update the release notes?


Documentation Sorting in APIM 4.1.0 DevPortal

Description
The ordering of documentations are deviated from the following list when listed in the Devportal
HOW TO
SAMPLES
PUBLIC FORUM
SUPPORT FORUM
OTHER
Steps to Reproduce
Create the following kinds of documentations from the Publisher portal per API
HOW TO
SAMPLES
PUBLIC FORUM
SUPPORT FORUM
OTHER
Observe when viewed from the Dev-portal the sorting is changed.
For example
OTHER
SAMPLES
HOW TO
PUBLIC FORUM
SUPPORT FORUM
Affected Component
APIM
Version
4.1.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Closing issue as PR is merged and issue is fixed


yum utils: force utf-8 encoding before writing content

OSBS-7739
Make sure that all strings are encoded as utf-8 before writing them
out.
Signed-off-by: Mark Langsdorf<EMAIL_ADDRESS>Maintainers will complete the following section:

[ ] Commit messages are descriptive enough
[ ] "Signed-off-by:" line is present in each commit
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request includes link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

Redid this significantly.  Now _content is always stored as unicode and content is returned as a byte string.

Fixed, thanks for the suggestion.

Added to RN under Bugfixes
"- yum repos are consistently stored as unicode and written out as byte strings, eliminating an error where byte string input would fail to encode to byte strings"


Barrier package failing to build

Describe the bug
The barrier package is failing to build
Steps To Reproduce
Steps to reproduce the behavior:

Run nix build github:nixos/nixpkgs/master#barrier

...
[ 12%] Building CXX object src/lib/base/CMakeFiles/base.dir/Event.cpp.o
In file included from /build/source/src/./lib/base/EventTypes.h:20,
                 from /build/source/src/./lib/io/StreamBuffer.h:21,
                 from /build/source/src/lib/io/StreamBuffer.cpp:19:
/build/source/src/./lib/base/Event.h:63:37: error: 'NULL' was not declared in this scope
   63 |     Event(Type type, void* target = NULL, void* data = NULL,
      |                                     ^~~~
/build/source/src/./lib/base/Event.h:23:1: note: 'NULL' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
   22 | #include "common/stdmap.h"
  +++ |+#include <cstddef>
   23 |
/build/source/src/./lib/base/Event.h:63:56: error: 'NULL' was not declared in this scope
   63 |     Event(Type type, void* target = NULL, void* data = NULL,
      |                                                        ^~~~
/build/source/src/./lib/base/Event.h:63:56: note: 'NULL' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
[ 12%] Building CXX object src/lib/mt/CMakeFiles/mt.dir/Lock.cpp.o
/build/source/src/lib/io/StreamBuffer.cpp: In member function 'const void* StreamBuffer::peek(UInt32)':
/build/source/src/lib/io/StreamBuffer.cpp:49:16: error: 'NULL' was not declared in this scope
   49 |         return NULL;
      |                ^~~~
/build/source/src/lib/io/StreamBuffer.cpp:26:1: note: 'NULL' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
   25 | #include <cassert>
  +++ |+#include <cstddef>
   26 |
make[2]: *** [src/lib/io/CMakeFiles/io.dir/build.make:76: src/lib/io/CMakeFiles/io.dir/StreamBuffer.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:577: src/lib/io/CMakeFiles/io.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 12%] Building CXX object src/lib/mt/CMakeFiles/mt.dir/Mutex.cpp.o
In file included from /build/source/src/lib/base/Event.cpp:19:
/build/source/src/./lib/base/Event.h:63:37: error: 'NULL' was not declared in this scope
   63 |     Event(Type type, void* target = NULL, void* data = NULL,
      |                                     ^~~~
/build/source/src/./lib/base/Event.h:23:1: note: 'NULL' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
   22 | #include "common/stdmap.h"
  +++ |+#include <cstddef>
   23 |
/build/source/src/./lib/base/Event.h:63:56: error: 'NULL' was not declared in this scope
   63 |     Event(Type type, void* target = NULL, void* data = NULL,
      |                                                        ^~~~
/build/source/src/./lib/base/Event.h:63:56: note: 'NULL' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
[ 13%] Building CXX object src/lib/mt/CMakeFiles/mt.dir/Thread.cpp.o
[ 13%] Building CXX object src/lib/mt/CMakeFiles/mt.dir/XMT.cpp.o
make[2]: *** [src/lib/base/CMakeFiles/base.dir/build.make:76: src/lib/base/CMakeFiles/base.dir/Event.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:499: src/lib/base/CMakeFiles/base.dir/all] Error 2
[ 14%] Linking CXX static library libmt.a
[ 14%] Built target mt
make: *** [Makefile:166: all] Error 2

Expected behavior
The package to build successfully without errors
Notify maintainers
@phryneas
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.17.1, NixOS, 22.05 (Quokka), 22.05.20220417.1ffba9f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.9.0pre20220422_7f814d6`

I'm sorry, I haven't used barrier in years - but also nothing with that package has changed in some while. I'd assume an upstream problem?

I don't use barrier but took a look out of curiosity. It was an upstream problem that is fixed by this commit a few commits after the latest 2.4.0 release. There hasn't been a new release since then. Is the best thing to do here pull down that commit as an isolated patch or to bump the revision that's pulled down to that (untagged) revision?

Can we use gcc10 in the meantime?


Add ~20 fine-tuning examples and switch to new ft model

This includes more examples, including ones where it's prompting a specific component

Awesome. Looking forward to testing out this new version, especially in regard to the layout examples you added.

Yes, please do! I find it's working not too bad on smaller apps, but it's kinda falling apart for bigger aparts (e.g. the diff doesn't applying). If you can contribute some fine-tuning examples as well, that'll be very helpful.

Yes, please do! I find it's working not too bad on smaller apps, but it's kinda falling apart for bigger aparts (e.g. the diff doesn't applying). If you can contribute some fine-tuning examples as well, that'll be very helpful.

Yeah, I'm hoping to add some examples at some point. For app maker, I've been starting to focus on layout and chat UI components specifically, so hopefully I can add some of the examples I'm creating there.
One thing I'm trying to experiment with is regular HTML/CSS translation to me.box/me.Style (kind of similar to what you were saying about Tailwind to Mesop translation before). Seems like if we can get the model to recognize that pattern, then maybe it can do a better job of layouts without having to provide too many examples beyond a basic set.


Could not install on Windows 7 x64 - setup.py fails because of UTF-8 encoding of README.rst

Hello, I've had a curious issue with the readchar module. My post also includes a workaround.
I've been trying to use readchar lately because I jump between Linux and Windows a lot. Last month I discovered how great python is. Since then, I'm writing various helper scripts for both platforms, and I wrote a simple question/answer function that takes y/n in one keystroke to help me with some otherwise tedious tasks.
On linux (python 3) readchar installed and runs without any problems. However, on Windows 7 64bit (tested both Python 3.4 and 3.3 because I read somewhere that readchar has issues on windows with py3.4) I cannot even install it using pip. Also, when I cloned and tried to build using simple: python-readchar (master) $ python setup.py build I get:
Traceback (most recent call last):
  File "setup.py", line 39, in <module>
    long_description=read_description(),
  File "setup.py", line 11, in read_description
    return fd.read()
  File "c:\Programs\Python34\lib\encodings\cp1250.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2590: character maps to <undefined>

so... I investigated, and noticed that README.rst is encoded in UTF-8. I converted it to ANSI with Notepad++. The "guilty" characters were just the two characters in your name (Á and í). After that, both setup.py build and setup.py install worked. However, still, when I run readchar.readchar(), I get this strange error
  File "d:\Projects\python\mbdev.py", line 29, in ask
    answer = readchar.readchar().decode("utf-8").lower()
  File "C:\Programs\Python34\lib\site-packages\readchar-1.1.1-py3.4.egg\readchar\readchar_windows.py", line 14, in readchar
    while ch in '\x00\xe0':
TypeError: 'in <string>' requires string as left operand, not bytes

So... I changed the line 14 in readchar_windows.py from
while ch in '\x00\xe0':
to
while ch.decode() in '\x00\xe0':
and changed my code from
answer = readchar.readchar().decode("utf-8").lower()
to
answer = readchar.readchar().lower()
And now it works on Windows. I feel that this solution might not be the optimal one, maybe on some other Windows systems the decode() is not needed as the char is already of type str. Maybe something along the lines of the type check present in readchar_linux.py is needed?
Also, I noticed that the readchar.readchar() in 1.1.0 (from pypi) returns bytes on linux, while 1.1.1 (current master from github) returns str. So, after I changed my code it stopped working on linux. After that I cloned and built rearchar from github also on my linux machine.
And now it really works on both platforms! :)
I'm willing to do some more testing on windows in the future. @magmax Please let me know if I can help with improving and/or testing readchar_windows.py as it looks like the windows code lags behind the readchar_linux.py.

Wow.
All of that is great!
I really have no way to test it in Windows. I have no Windows machine, and that file was just copied from a stackoverflow thread (as it is said in the header, I hope).
So please, fix anything you find, because I cannot test it.
I will do all what you say as soon as I can.
Thank you very much.

Please also take a look at the merge request #6, because it seems that fixing the issue of README.rst for Windows, breaks it for linux. I've forked your repo and created branch 'devel'. I would be grateful for some feedback if setup.py build is also broken on branch 'devel' in your linux environment. I'm currently unsure how to properly fix it - so that the same code builds on both linux and windows.

A simpler, though less elegant (which shouldn't take priority over working code) solution would be to stick to ASCII characters in the README: the only change necessary would be "Miguel Ángel García" -> "Miguel A'ngel Garci'a" or something similar.

This issue (as well as #26) can be marked as fixed as soon as #27 is resolved.


Authentication in Nats server

Is there a way that I can add multiple users credentials to the config file (or any other way) without having to restart the server???

Not at the moment. I believe that there are plans to have the NATS Server reload the configuration file on a signal without dropping client connections. This would be limited to a certain number of configuration parameters, but authentication may be one of them. We will keep you posted.

Thank you. Urgently needing this feature as currently one user credentials can only allow a single logon.
So means we have to run the server without authentication and hence not secure.

Not sure about the reference to "one user credentials can only allow a single logon", but to reiterate, NATS supports multi-user authentication and authorization, however, it does not support reload of the configuration without restart at the moment.

Meaning only one connection can use 1 user and password combination. No other connection can use this credentials again while the first connection is still connected.
So if I have 100 multi users credentials when server startup, 101 user cannot be authenticated and cannot be connected.
Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: Ivan Kozlovic<EMAIL_ADDRESS>Date: 26/08/2016  11:29  (GMT+07:00) To: nats-io/gnatsd<EMAIL_ADDRESS>Cc: steventanwc<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [nats-io/gnatsd] Authentication in Nats server (#335)
Not sure about the reference to "one user credentials can only allow a single logon", but to reiterate, NATS supports multi-user authentication and authorization, however, it does not support reload of the configuration without restart at the moment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/nats-io/gnatsd","title":"nats-io/gnatsd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/nats-io/gnatsd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kozlovic in #335: Not sure about the reference to "one user credentials can only allow a single logon", but to reiterate, NATS supports multi-user authentication and authorization, however, it does not support reload of the configuration without restart at the moment."}],"action":{"name":"View Issue","url":"https://github.com/nats-io/gnatsd/issues/335#issuecomment-242627715"}}}

Closing this issue for now. Please follow #338. When this is implemented, that should solve your issue.


Problem w/install of latest v0.8.0 -rc10

RancherOS Version: (ros os version)
v0.8.0-rc10
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
baremetal: INtel NUC i3 w/32 GB ram, 500GB ssd.
Just tried install of latest rc from ISO flash drive.
Boot from ISO appears to work fine.
[rancher@rancher ~]$
[rancher@rancher ~]$ sudo ros install -c cloud-config.yml -d /dev/sda

INFO[0000] No install type specified...defaulting to generic
Installing from rancher/os:v0.8.0-rc10
Continue [y/N]: y
INFO[0004] user specified to install pre v0.8.0: rancher/os:v0.8.0-rc10
INFO[0004] starting installer container for rancher/os:v0.8.0-rc10
set-disk-partitions deprecated
Installing from :v0.8.0-rc10
time="2017-02-09T19:53:51Z" level=info msg="start !isoinstallerloaded"
time="2017-02-09T19:53:51Z" level=info msg="ps error: exit status 1"
time="2017-02-09T19:53:51Z" level=error msg="error setDiskpartitions exit status 1"
time="2017-02-09T19:53:51Z" level=fatal msg="Failed to run install" err="exit status 1"
FATA[0004] Failed to run install                         err="exit status 1"
[rancher@rancher ~]$

Note, previous install of 0.7.1 worked fine but had console problems (ref issue #1566

Confirmed that this is happening.

oh joy - it seems that semver & hashicorp sort the -rcXX meta alphabetically, so -rc10 is not greater than -rc3
I'm switching to the version code that @joshwget made for the catalog, as it handles what people do rather than what the spec says.

#1593 fixes this for me :)

I'm building an v0.8.0-rc11 just to make sure that the library update to replace the semver library with a logical versioning GreaterThan works out.
clearly, nothing can go wrong :)

Well, I can boot up rc11 from flash ISO and do a ros install to the ssd.  I confirmed, prior to
reboot that cloud-config.yml gets copied to ssd as usr-config(sp?).  But, after reboot
that config file no longer works (it did on the 7.1 install).  System comes up as DHCP with
the wrong domain name.  Cloud-config.yml is:

hostname: electra.rtisys.org
rancher:
network:
interfaces:
eth*:
dhcp: false
eth0:
address: <IP_ADDRESS>/24
gateway: <IP_ADDRESS>
dns:
nameservers:
- <IP_ADDRESS>
- <IP_ADDRESS>
ssh-authorized-keys:

ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDESEL1x/nFAJY0b4ejsuv5**** deleted on purpose ********
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
Also, back to where this all started w/7.1,  I cannot login from either console or remote ssh.  The remote ssh
makes sense because ranchos does not like the cloud-config.yml that I gave it.  But console requires a login
(where the ISO does not) and will not accept either my previously set passwd from the ISO boot or the default "rancher".  Any ideas?
Can probe around  a bit, but will need some pointers to do that.

Regrds,
rtisys

@mcparland mmm, that's surprising - I just copied your cloud-config.yml, and used it to install, and I get the hostname, and the IP address
(though this is on a machine with only one network)
I was wondering if the newlines or something else was going on.

Thanks for checking,.....will re-enter the config more carefully.  It would be easier
if I could get into the machine after the reboot.  Never succeeded in getting
Grub's attention during boot. (left shift A or something like that?)  Is there a way
to get into grub after boot to set up kernel params for following boot?
Will keep googling this, but results seem contradictory (this always works, that
seems to work every fifth time, don't bother trying that. etc. )
If you know of something that works, would appreciate
a heads up.
Cheers,
rtisys

oh - v0.8.0 has replaced grub with syslinux - I basically just keep tapping the a key to get to it.

Same issue with v.0.9.1. Installing v0.7.1 worked with no hick-ups.

Having the same issue as @kapolos.  First time Rancher user.  Just trying to get this thing installed in a local VM.
Booted off the the iso fine and figured out how to set both root & rancher passwords to blank and to let sshd permit blank passwords (for the temporary in-memory ISO-booted rancher OS, mind you; I would never do this to an installed OS), so I can install using my machine's native terminal app and get the ssh pub key into the cloud-config.yml an all that.
After setting up the cloud-config.yml (passes validation) and formatting my main drive disk-image, ran ros install -c cloud-config.yml -d /dev/sda1.
Received status messages and errors nearly matching @kapolos's:
[root@rancher ~]# ros install -c cloud-config.yml -d /dev/sda1
> INFO[0000] No install type specified...defaulting to generic
Installing from rancher/os:v1.0.3
Continue [y/N]: y
> INFO[0001] start !isoinstallerloaded
> INFO[0001] trying to load /bootiso/rancheros/installer.tar.gz
> INFO[0002] Loaded images from /bootiso/rancheros/installer.tar.gz
> INFO[0002] starting installer container for rancher/os-installer:latest (new)
Installing from rancher/os-installer:latest
> time="2017-07-20T00:19:30Z" level=error msg="partprobe error exit status 1"
> time="2017-07-20T00:19:30Z" level=error msg="error setDiskpartitions exit status 1"
> time="2017-07-20T00:19:30Z" level=fatal msg="Failed to run install" err="exit status 1"
> FATA[0002] Failed to run install                         err="exit status 1"

Scratch that; I just realized that RancherOS docs's Installing RancherOS to Disk instructions, you're installing to /dev/sda, not /dev/sda1.  Worked when changed it to specify the former rather than the latter.

I'm going to close this issue - it was for a specific issue where the version number parsing failed to consider rc10 to be after rc9 because it used non-numerical ordering


Fix documentation links after change directory structure

After https://github.com/Financial-Times/polyfill-service/pull/1693 went in, it's broken a few links on the documentation.
This PR resolves that.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @scripter-co!

No problem @JakeChampion.

I'm not sure why but I don't think these changes are reflecting on the website.
https://polyfill.io/v2/docs/api
Is there a different repo which needs these changes.
(Sorry for commenting on an old issue, got 404s so thought better to get them fixed.)


SIP006a and SIP008 Proposal

Task List:

[x] SIP006a Proposal on Testnet (Proposal ID: 2)
[ ] SIP008 Proposal on Testnet
[x] SIP006a Proposal on Mainnet
[ ] SIP008 Proposal on Mainnet

With one address (my current one with delegated voting power), only one proposal can be proposed at a time. So, either SIP006a or SIP008 will go through at the moment. I am thinking SIP006a is a priority. (There might be another solution, but only after point 2 is solved, that would be useful).

SIP006a was successfully proposed in Testnet, but for Mainnet the same thing is giving trouble, I am still looking at it, but not sure how soon can it be solved.

SIP006a is executed on the Mainnet, thanks to @ororopickpocket
Transaction Hash: 0x6043707d6a945633cd64b3291b0877a58d51ee6f26772a7996ca8a33168c8fb4

SIP008 proposed as well @TravinImmunefi


CMake packaging fix.

Add find_dependency for the new dependency libdeflate, and remove the REQUIRED flag. find_dependency will pickup the correct flag from the calling find_package call.

https://github.com/microsoft/vcpkg/issues/37394

Seems that libdeflate can either be provided externally, then my change are needed. Or added internally using OPENEXR_FORCE_INTERNAL_DEFLATE, then my change will break the CI since in that case you just embed the sources. :/
Need to make the find_dependency dependent on how libdeflate is consumed.

The OPENEXR_FORCE_INTERNAL_DEFLATE flag is probably not sufficient to check for though. Not sure if there is any variable that indicates how libdeflate is consumed at the moment that could be used in cmake/OpenEXRConfig.cmake.in?

Oops, looks like pushed a commit to your repo by mistake. Maybe you should set permissions so that's not possible?
This may fix the problem, but apologies for stomping on your repo by accident.

I intended to push to my fork to trigger the CI builds but pushed to your repo accidentally. The change is:
if (libdeflate_FOUND)
  find_dependency(libdeflate)
endif()

libdeflate_FOUND should be set if and only of find_package(libdeflate) ran successfully in OpenEXRSetup.cmake, which only happens if OPENEXR_FORCE_INTERNAL_DEFLATE is off. This should cover the cases where libdeflate is not autofetched, either intentionally or unintentionally.
I can't reproduce your original failure case, so please confirm that this satisfies it.

No problem, thanks for the help!
I just needed to expand the libdeflate_FOUND variable at configure_file time. Then it works on my side!


Tagging imported Bible notes

Is there any way to tag the imported notes?
For example, you could implement a title line for each note enclosed in {{}}, which could in addition include a comma-separated list of tags? Something like: {{Title|Tag1,Tag2}}

Tags you have to create when you make your notes in the App on the specific device.
Comfortably edit them you can in the section "Personal Study" (create, rename & delete).
If you keep a strict pattern (spelling) creating them, they will apear as you type while searching and separate them with blanks.
Maybe you just have to mark your "title tag_" with a special character and type it always first while searching in personal study.
In my opinion, too much similar and redundant tags makes it more difficult to work with it.

@temporarium You can now specify a single, existing tag when importing a notes file. I know this doesn't really satisfy your request, but just for your information.

HI Antony,
Thank you for the recent modifications. I was waiting to finish with Revelation before uploading my close-to-10-thousands notes...
Anyway, the tagging seems to work. The note in the reference pane shows the tag, but when the tag is selected in the study notes window, they're not listed. Maybe it's just very slow with so many notes.
No matter. My main purpose was to be able to eliminate ALL my Bible reference notes by tag, but that won't work anyway. I sometimes modify the title and so have a duplicate note, so I thought I'd remove them all first and reimport. So, to remove, I've resorted to an SQLite browser. It works, but it's a real tangle, and I hope I don't mess something up.
For the moment I've decided to prefix the titles with a "%". That way, in the SQLite browser, I can distinguish those notes from other notes I create directly in the app.
I have another strange issue: the notes show correctly in the reference pane - each one within its scripture section. But, in the Bible, I only have one note icon at the beginning of the chapter. This only happens in the nws-S. The Rbi8-S and the nwt-E display a note icon at each verse that has a note. The notes were imported with
[BibleKeySymbol=nwt]
[MepsLanguageId=1]
Any ideas? Could be just the app.
Anyway, thank you again for your continued work on this tool!

Follow-up: I tried importing my notes as
[BibleKeySymbol=nwtsty]
[MepsLanguageId=0]
And it worked!

I have another strange issue: the notes show correctly in the reference pane - each one within its scripture section. But, in the Bible, I only have one note icon at the beginning of the chapter. This only happens in the nwt-S. The Rbi8-S and the nwt-E display a note icon at each verse that has a note.

Fixed

So, was that a bug in your implementation, then?
Strangely, specifying the language, etc. has no impact, as the notes show up in all Bibles.

So, was that a bug in your implementation, then?

Yes


Remove byteorder-dependency?

https://github.com/danburkert/prost/blob/565d3bcf232f6fb1a09986238c4a6d803d030b37/Cargo.toml#L40
byteorder is a still dependency but referenced nowhere. Can it be removed?

SGTM!  Interested in sending a PR?


test: add unit test for network

Signed-off-by: letty<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #737 into master will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   12.46%   12.94%   +0.47%
==========================================
  Files          97       97
  Lines        5857     5857
==========================================
+ Hits          730      758      +28
+ Misses       5076     5045      -31
- Partials       51       54       +3

Impacted Files
Coverage Δ

daemon/mgr/network.go
5.22% <0%> (+5.22%)
:arrow_up:

cli/volume.go
9.61% <0%> (+9.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06b62e...7412044. Read the comment docs.

LGTM


Creates materialized view for enrollment events (FC-0024)

Creates a top-level materialized view for enrollment events based on the parsed xAPI events materialized view.

Thanks for the pull request, @SoryRawyer!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@SoryRawyer 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


[WIP] muxcover decoder generation to be undef aware

Fixes an issue uncovered in https://github.com/YosysHQ/yosys/issues/1132#issuecomment-506008086
This fixes issues with MUXes not being able to be covered by MUX8 or MUX16 due to generation of a redundant decoder, by making decoder generation undef (1'bx) aware.
~EDIT: Not sure this is working; even though it passes my micro benchmarks, it (specifically, flows that employ muxcover) fails when used to synth the picorv32 and then checking the result with the testbench...~
Now passes picorv32 tb, hopefully not just by luck.

See #1142 for my proposed fix.

Superseded by #1142


Year Precedence

OMDB doesn't have strict search mode, seems it'll return first wild card match for the specific year. Some movies get exact match from previous year, some from current and some next year.
Figure out the precedence and apply strict matching using movie title?

resolved via @c693294


New version: HELICS v0.4.0

Registering package: HELICS
Repository: https://github.com/GMLC-TDC/HELICS.jl
Created by: @kdheepak
Version: v0.4.0
Commit: 0a87e61ca9430fef90a8db7d00936ad817e110e1
Reviewed by: @kdheepak
Reference: https://github.com/GMLC-TDC/HELICS.jl/commit/0a87e61ca9430fef90a8db7d00936ad817e110e1#commitcomment-35675682

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


Confirm email address by link

It would be nice if addict would support activating an user account by a confirmation link.

I would love to see this happen.


Mobile - Revising Settings Pages

Settings pages of mobile project needs to be improved to match the design.

Settings pages are completed.


React 17 migration path

A few months ago, the React team announced their plans to remove the UNSAFE-prefixed component lifecycle methods in version 17. Several of the carbon components use these soon-to-be deprecated methods, but there is a path for gradual migration to React 17. Are there any plans in the works for this move? The React team has also already outlined several new component lifecycle methods that can be used.
Related thread in Slack

Hi @emyarod! 👋 There are definitely plans to move away from the unsafe lifecycle methods called out in 16.3. No work has been started towards refactoring away from them as of yet, but there has been work into making sure that all the unsafe component lifecycle methods have been prefixed as such.
In addition, for code reviews we're starting to be more restrictive on lifecycles that can be used to deliver features or fix bugs 👍
We went ahead and added React.StrictMode to our dev environment, as well, so that we can be fully aware of any components that will cause troubles in the next major release of react 😄

Thanks for the info @joshblack, it's good to know that there are plans and actions being taken to stay aligned with the latest React versions! If the migration effort would require additional help from the community I would love to help contribute

Great thanks @emyarod - Definitely help is welcome, e.g. cWRP -> gDSFP migration!

And this might be worth taking a look at: the React team just published a blog post yesterday about gDSFP


write clang-tidy to build dir

Rust build for swiftnav-rs complains because the repository will modify itself when generating a .clang-tidy config.  Instead of putting a .clang-tidy into the source, put it into the build dir.  This still seems to work fine:
❯ find |grep '\.clang-tidy'
./build/.clang-tidy

When running clang tidy, the config gets picked up, I placed an invalid config item in the generated file and clang-tidy spit out an appropriate error/warning:
❯ cmake --build build --target clang-tidy-all
YAML:7:1: error: unknown key 'Pork'

^
Error parsing /home/ubuntu/dev/swiftnav-rs/swiftnav-sys/src/libswiftnav/build/.clang-tidy: Invalid argument
Enabled checks:
    clang-analyzer-apiModeling.google.GTest

This is one of the things I tried when writing this module but had to change it because of the idiotic way clang-tidy picks up config. By having it in the build dir clang-tidy will only ever work properly when run from the build dir, whereas when config is in the repo root clang-tidy will work properly when run in any subdirectory. This can cause problems with some IDEs and versions of clangd. (The same is true for .clang-format)
To get around the git thing we just add .clang-tidy to .gitignore in other repos since it fixes the issue without breaking other workflows. A proper solution would be to use a linter where a config file can be passed on the command line

Also if you really want a custom .clang-tidy you can use the LegayClangTidy module which doesn't so any autogeneration of config

To get around the git thing we just add .clang-tidy to .gitignore in other repos since it fixes the issue without breaking other workflows. A proper solution would be to use a linter where a config file can be passed on the command line

There seemed to be a command line option to pass in a config in the parallel clang-tidy script.

Also if you really want a custom .clang-tidy you can use the LegayClangTidy module which doesn't so any autogeneration of config

Why do we need to generate the .clang-tidy? Just to have it the same across all repos?
I think we could turn off the auto generate and still use this module (but check in a copy of the generated .clang-tidy). If there's a benefit to doing it that way?

That's what used to happen  but there were constant problems where someone would make a change to .clang-tidy in one repo but not bother updating any of the other ones. It caused issues where something like (say) LSNP would pass just fine but there would be some syntax in a header file that would only cause a lint error by the time it made it up to starling. Synchronisation which doesn't require manual steps was the major goal of revamping this module a few months ago.

To get around the git thing we just add .clang-tidy to .gitignore in other repos since it fixes the issue without breaking other workflows. A proper solution would be to use a linter where a config file can be passed on the command line

There seemed to be a command line option to pass in a config in the parallel clang-tidy script.

There isn't such an option for plain old clang-tidy. Not sure how clangd behaves but I have a feeling it just does the same recursive search upwards as clang-tidy

@woodfell Thanks for clarifying the state of play here, ideally we'd like to get libswiftnav where it doesn't modify itself during compilation, do you have a recommendation here?

Maybe this is over-complicating things but it's possible we could add an optional parameter to the clang tidy module that allows the user to specify the directory it gets written to (defaults to CMAKE_SOURCE_DIR).
We add an option to libswiftnav (i.e. -DCLANG_TIDY_DIR) that defaults to CMAKE_SOURCE_DIR, so that we don't break local dev workflows.
Then in libswiftnav-rs we could add a CMakeLists.txt that overrides this to CMAKE_BINARY_DIR, (or as a cmake arg in the rust build scripts).

I was thinking we could take the approach we've taken in other places with generated content that has to live "in tree", which is to require that changes/updates must be intentionally staged and committed.
That is:

cmake module generates a clang-tidy config, then runs git diff to ensure nothing has changed
build fails if generated config is different than what's checked in (e.g. git diff returns a non-zero exit code)

So, if clang-tidy was updated, this would require all bumps to the cmake module to include an update to the generated clang-tidy in each of those repos, but if these updates are infrequent it, this doesn't seem like a super horrible idea.
We could also optionally enable this behavior (only for repos that care about this behavior)-- so the "generate and git diff" dance would only happen if the .clang-tidy is not git ignored (see stackoverflow for a possible implementation).  This way we could turn on this behavior for the libswiftnav-private repo, and not for everything else.
@isaactorz @woodfell thoughts?

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

It triggers this check when attempting to release/package swiftnav-rs: https://github.com/rust-lang/cargo/blob/50d52ebf0ef91f392f47b4d9b9e954bb25c60aca/src/cargo/ops/cargo_package.rs#L815
Example:
Compiling swiftnav-sys v0.7.2-alpha.0 (/Users/joseph.angelo/repos/swiftnav-rs/target/package/swiftnav-sys-0.7.2-alpha.0)
    Finished dev [unoptimized + debuginfo] target(s) in 40.27s
error: failed to verify package tarball

Caused by:
  Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
  Added: /Users/joseph.angelo/repos/swiftnav-rs/target/package/swiftnav-sys-0.7.2-alpha.0/src/libswiftnav/.clang-tidy

  To proceed despite this, pass the `--no-verify` flag.

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

It triggers this check when attempting to release/package swiftnav-rs: https://github.com/rust-lang/cargo/blob/50d52ebf0ef91f392f47b4d9b9e954bb25c60aca/src/cargo/ops/cargo_package.rs#L815
Example:
Compiling swiftnav-sys v0.7.2-alpha.0 (/Users/joseph.angelo/repos/swiftnav-rs/target/package/swiftnav-sys-0.7.2-alpha.0)
    Finished dev [unoptimized + debuginfo] target(s) in 40.27s
error: failed to verify package tarball

Caused by:
  Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
  Added: /Users/joseph.angelo/repos/swiftnav-rs/target/package/swiftnav-sys-0.7.2-alpha.0/src/libswiftnav/.clang-tidy

  To proceed despite this, pass the `--no-verify` flag.

But we can get around this by making the directory the clang-tidy file gets written to variable (my suggestion above).
That would be a lot more lightweight change to implement to this module than your suggestion above. We also wouldn't need to patch every repo using this module every time we make a change to it.
Are there any other big advantages for having the .clang-tidy file checked in that would make the downsides worth it?

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

It triggers this check when attempting to release/package swiftnav-rs: https://github.com/rust-lang/cargo/blob/50d52ebf0ef91f392f47b4d9b9e954bb25c60aca/src/cargo/ops/cargo_package.rs#L815
Example:
Compiling swiftnav-sys v0.7.2-alpha.0 (/Users/joseph.angelo/repos/swiftnav-rs/target/package/swiftnav-sys-0.7.2-alpha.0)
    Finished dev [unoptimized + debuginfo] target(s) in 40.27s
error: failed to verify package tarball

Caused by:
  Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
  Added: /Users/joseph.angelo/repos/swiftnav-rs/target/package/swiftnav-sys-0.7.2-alpha.0/src/libswiftnav/.clang-tidy

  To proceed despite this, pass the `--no-verify` flag.

I see.
Another way could be to add a command line flag to complete disable the ClangTidy module. We then use than flag from swiftnav-rs so that nothing gets generated in any location at all. Presumably we're not going to miss the clang tidy targets in this build?

But we can get around this by making the directory the clang-tidy file gets written to variable (my suggestion above).
That would be a lot more lightweight change to implement to this module than your suggestion above. We also wouldn't need to patch every repo using this module every time we make a change to it.

Yeah, the simplicity of your suggestion is a big upside.  However, I don't think we should build this change without the "explicit enable" part, that is, you'd be required to check-in a copy of .clang-tidy before it would do the git diff check.

Are there any other big advantages for having the .clang-tidy file checked in that would make the downsides worth it?

The benefit is just the "out of the box" factor, if anyone else is consuming the repo, they don't need to know about our cmake stuff to prevent it from modifying the source tree.

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

It triggers this check when attempting to release/package swiftnav-rs: https://github.com/rust-lang/cargo/blob/50d52ebf0ef91f392f47b4d9b9e954bb25c60aca/src/cargo/ops/cargo_package.rs#L815
[..]

I see.
Another way could be to add a command line flag to complete disable the ClangTidy module. We then use than flag from swiftnav-rs so that nothing gets generated in any location at all. Presumably we're not going to miss the clang tidy targets in this build?

Yeah, that would work too.

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

It triggers this check when attempting to release/package swiftnav-rs: https://github.com/rust-lang/cargo/blob/50d52ebf0ef91f392f47b4d9b9e954bb25c60aca/src/cargo/ops/cargo_package.rs#L815
[..]

I see.
Another way could be to add a command line flag to complete disable the ClangTidy module. We then use than flag from swiftnav-rs so that nothing gets generated in any location at all. Presumably we're not going to miss the clang tidy targets in this build?

Yeah, that would work too (don't need clang-tidy targets for a wrapped build).

I ported over the ability to disable the clang-tidy targets from the legacy module (see https://github.com/swift-nav/cmake/blob/master/OldClangTidy.cmake#L206).

Yeah that sounds like it would work. But what's the problem with using .gitignore here? As far as I know it's been working alright so far?

It triggers this check when attempting to release/package swiftnav-rs: https://github.com/rust-lang/cargo/blob/50d52ebf0ef91f392f47b4d9b9e954bb25c60aca/src/cargo/ops/cargo_package.rs#L815
[..]

I see.
Another way could be to add a command line flag to complete disable the ClangTidy module. We then use than flag from swiftnav-rs so that nothing gets generated in any location at all. Presumably we're not going to miss the clang tidy targets in this build?

Yeah, that would work too (don't need clang-tidy targets for a wrapped build).

I ported over the ability to disable the clang-tidy targets from the legacy module (see https://github.com/swift-nav/cmake/blob/master/OldClangTidy.cmake#L206).

So, this is probably the best option, seems this is already something we were using in this module: https://github.com/swift-nav/swiftnav-rs/blob/master/swiftnav-sys/build.rs#L20 -- this was probably broken when the new clang-tidy module was introduced.


the repo lacks a Readme

I may help to state the scope of this repository.

It is definitely a must but just until yesterday I was not really satisfied with the API. Now it looks much better and I will add a Readme ASAP. Some changes might still occur since I plan to do some renaming in thx.promise. Thank you for pointing it out!


Connect Zip Code API to trefle lookups

We have code to get the zip code of an IP address, however it's not being used (we feed a dummy zip code to Trefle still).
We need to include this function where we call Trefle with a zip code, and use it to get the current visitor's zip code (and thus, climate zone and minimum temperature required for the Trefle species search).

This is now done in master - we look up the zip code using Maxmind GeoIP data, then pass it to Frostline API to get a minimum temperature range, then pass the lower end of that range to Trefle.


next commerce

go to https://demo.vercel.store/product/lightweight-jacket
click add to cart

This ticket has been moved to RUN-155


Czech translation of new landing page

I've translated the new landing page, corrected the old one and moved it to /old/cs/.
I also recommend changing the word "content" to "data" throughout the English version.

Thanks a lot! I put it live right away. :)


Missing 3.2.1 GitHub release

[X] None of the other issue templates apply to this issue.

Version 3.2.1 is available in the App Store, but there is no GitHub release for this version yet. Please create a GitHub release listing all changes compared to https://github.com/corona-warn-app/cwa-app-ios/releases/tag/v3.2.0

There's already https://github.com/corona-warn-app/cwa-app-ios/releases/tag/v3.2.1-rc.2, but that's a pre release.

@30mar
Could you please, for the sake of a continuous transparent release policy, also release version 3.2.1 and 3.2.2 to GitHub?
Thank you.
cc @dsarkar

Team, I won't stop pushing this issue, please just release the two versions. Thanks.


Support for Consul 0.5.0 and multiple check configuration

I just reviewed the Consul 0.5.0-rc1 change log and it looks like there will be a few changes that will require changes in puppet-consul.  Some quick notes:

'consul::service' will need to be updated as the checks property for services is now an array instead of a hash.
'consul::check' will also need updates for the new HTTP check type as well as optional service_id property.

Cool. I've released 0.4.6 to the forge and added a compatibility section.
The next version/tag of this module will be 0.5.0 to be compatible with Consul 0.5.0!

Believe it or not, this module does have an acceptance test suite, I would love to see us TDD our way towards 0.5.0 compatibility.

These sound like they could cause us to be backwards-incompatible. Should we bother maintaining a branch that's compatible with 0.4, or just expect people to upgrade?

Na. If people are on .4 they can use a release from the .4 series, otherwise they can be on .5 or master.

Has there been any progress towards 0.5.0?

Na :(

Any ETA on when a 0.5.0 compatible version will be released?

There is #94, but needs a little TLC.
Patches welcome?

Do you have a list of additional known items that need to make this compatible? I'd be happy to provide some pull requests.

As far as I know, the list at the top of this issue is it. For the most part things are backwards compatible, but I'm not running 5.0 in production yet.

I added a pull request #98 with the additional options for checks along with unit tests for it.  I will work on the additional service options as well.

I went ahead and finished up the service portions and move all the validation logic into a function since it needed to really be used in multiple locations by consul::check and consul::service with the checks array.  The pull request is located #99.
I added several tests to ensure that things are getting handled properly but please double check to see if anything was missed or more tests are wanted.

This in place.
I'm not using .5 in production yet, so we'll have to wait for bug reports if anything crucial is missing.


Build manual page does not explain the --network argument

File: engine/reference/commandline/build.md
It would be useful to have a link over to the networking documentation which lists and explains all the networking choices.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


"inner tag" pending operator broken

it doesn't behave properly:

vim --noplugin for instance

:setf html

i

 esc

Now, if you do _cit it will appropriately place the cursor inside of the tag, as it should.
However, if you do 0f<cit then it will effectively do cat (change around tag), as it deletes the entire tag. The problem is that if the cursor is position on the start of the closing tag, and the tag is emtpy, then cit will not work properly, but instead it deletes the entire tag not just the inner tag.
I have also noticed some bugs when the tag is empty for tpope's vim-surround and also with (presumably) the default xmap (whatever it is ... vit).
For example (with vim-surround), if you use the above example (

) and do:
csttimg

(that's cst for change surrounding tag then another t for tag again--we're trying to change the divs to imgs--and finally img for the ... well, "img"--the tag we're changing it to) ... this does not work when the tag is empty, but it works when there is at least one character inside the tag.

it case:
From :help tag-blocks:

The normal method is to select a <tag> until the matching </tag>.  For "at"
the tags are included, for "it" they are excluded.  But when "it" is repeated
the tags will be included (otherwise nothing would change).  Also, "it" used
on a tag block with no contents will select the leading tag.

When you are on the < of the closing tag of an empty block, IIUC you're in the case of ...otherwise nothing would change so it includes the tags.
The help paragraph is a little mealy-mouthed, and not perfectly clear, but I think that what you experience is expected behaviour. @brammool (or someone), please correct me if I'm wrong.

st case:
I cannot find in the help any documentation about an st object. The only way I know about to change the interior of a <..> is to place the cursor inside the angle brackets, or on one of them, and then use an "inner angle bracket" object, e.g. ci<. I don't know where you got that cst idea from, maybe a third-party ftplugin, named (e.g.) .vim/ftplugin/after/html/something.vim? (--noplugin inhibits global plugins but not filetype plugins if filetype detection is enabled, which is usually the case when Vim is invoked without -u NONE: then looking for your vimrc is not inhibited, if found it will normally include a :filetype plugin [indent] on statement, and if not found Vim will source the $VIMRUNTIME/defaults.vim which does include such a statement.)

Best regards,
Tony.

As Tony says, this is in some sense expected by analogy to vit on the closing tag's <.  That is, if you are in visual mode, the smallest region is 1 character and it tries to expand this region.

"it" used on a tag block with no contents will select the leading tag.

Doesn't actually seem correct, since cit anywhere but the < will enter insert mode inside the tag.
The following patch would fix the inconsistency described in this issue for operators while keeping the behavior in visual mode the same:
--- a/src/search.c
+++ b/src/search.c
@@ -4108,7 +4108,8 @@ again:

        /* If we now have the same text as before reset "do_include" and try
         * again. */
-       if (EQUAL_POS(start_pos, old_start) && EQUAL_POS(end_pos, old_end))
+       if (EQUAL_POS(start_pos, old_start) && EQUAL_POS(end_pos, old_end)
+               && VIsual_active)
        {
            do_include = TRUE;
            curwin->w_cursor = old_start;

@tonymec st is a complex text object provided by vim-surround (tpope plugin). I find myself trying to cst an empty tag nearly every day only to find that it doesn't work. If this is a vim-surround problem, then maybe I should raise the issue there (I bet it already has been), but I feel like it's a vim issue and not a vim-surround issue.
@andymass I am not quite following, but do you think that this would fix the issue with vim-surround (eg csttNEWTAG)? Thanks for the prompt reply and looking into it.

@dylnmc, no, that patch would only change the first issue which you describe.  I don't think the vim-surround issue is related because it happens for empty tags no matter where the cursor is, unlike the other issue which happens only when the cursor is on the closing tag's <.
Specific plugins for the most part are off-topic.  So, while it might be related to a vim limitation of empty text objects, I think that should be a separate issue.  I don't know exactly why vim-surround won't work with empty objects.