package.json exports field not respected in scoped packages

Bug Report
It seems that scoped packages (i.e. packages with names prefixed by @org/...) within a monorepo have the exports field of their package.json ignored.
🔎 Search Terms
package.json, exports field, scoped packages, Cannot find module
🕗 Version & Regression Information
Tested on 4.8.4
Reproduction
Reproduction repository
💻 Code
import add from 'shared'; // works fine
import scopedAdd from '@scoped/shared'; // identical package except for scope
// Cannot find module '@scoped/shared' or its corresponding type declarations

🙁 Actual behavior
Couldn't resolve the exports for the @scoped/shared package
🙂 Expected behavior
Both packages (@scoped/shared and shared) should resolve according to their exports field in their respective package.json files.

I have the same error, exports is ignored in a monorepo but with or without scoped module.
I can work around this problem by adding moduleResolution to nodenext, but that gives me other problem: export * from another package which was not a problem so far gives me the error: TS2305: Module '"@org/uikit"' has no exported member 'Box'
I don't understand anything, I always have one or the other error.

The package's package.json says the package name is shared and not @scoped/shared, which is the root of our confusion. A namespaced package usually has to list the namespace in the name in its package.json.

@weswigham thanks for looking into this!
Actually, the line you linked to is from the non-scoped shared package - there are two dependencies, one scoped and the other not. I probably should have named them differently to avoid confusion.
The package.json you linked to is for the shared package, which was intentionally not scoped to show that it was working correctly.
This package.json is for the @scoped/shared package, which is not working (and correctly lists its own name as @scoped/shared.
Sorry for the confusing naming!

Um, well, for starters, there's no packages/app/node_modules/@scopes/shared folder. Pretty simple way to not find any types is them just not being there. Rerunning pnpm i inside app gets it linked it and running.

Sorry @weswigham, not sure how I managed to mess that install up. Thanks for taking the time to investigate, much appreciated.


Raw value output from fmt

I have a CSV where one of the fields is actually JSON:
foo,"[""bar"",""baz""]",bazinga

(Before anyone tells me this is dumb: Yes, I agree. But it's what I have to work with, for various reasons.)
I would like to extract just the JSON column for further processing as JSON, but there doesn't seem to be a way to convince xsv fmt to output the "raw" text value; it is always quoted for CSV purposes.
I imagine it would look something like this, e.g. via an -r or --raw flag:
$ echo 'foo,"[""bar"",""baz""]",bazinga' | xsv select 2 | xsv fmt -r
["bar","baz"]

Or, as a hack, fmt --quote could accept an empty string I guess?
(I know that such output would not be suitable for further processing by xsv, but that's kind of the point.)
For prior art on this, see for instance the --raw-output / -r flag in jq.

I suspect this would be a better fit for the xsv select command itself?
Whether it goes in xsv select or xsv fmt, I think more specification is required. For example, what happens if more than one column or row is selected? What delimiter is used for the raw output?

I suspect this would be a better fit for the xsv select command itself?

Sure, that would be fine.

Whether it goes in xsv select or xsv fmt, I think more specification is required. For example, what happens if more than one column or row is selected?

Given the file my.csv below:
foo,"[""bar"",""baz""]",bazinga
buzz,"[""bang"",""boom""]",blammo

For selecting a single column with multiple rows, I would expect one value per line, like:
$ cat my.csv | xsv select 2 --raw
["bar","baz"]
["bang","boom"]

A problem with this would be when the quoted values themselves contain newlines; then the output will probably be very hard to use in a meaningful way. For my purposes it would be nice to somehow escape in-value newlines e.g. as \n but I'm not sure that works without making assumptions about the content or the downstream use case.
(Even if in-value newlines break things, I think raw output could still be useful for when you are sure you don't have in-value newlines, which for me is pretty often.)
Multiple columns: To be honest I hadn't thought about this. I'm not sure what to expect; perhaps one value per line but they are interleaved like:
$ cat my.csv | xsv select 1,2 --raw
foo
["bar","baz"]
buzz
["bang","boom"]

What delimiter is used for the raw output?

Ultimately my aim is to pipe things to other line-wise programs, so the natural answer is \n.

I also think this would be a great use case to add for xsv.
I had similar data and did the following to work around:
xsv select col_name file.csv | sed -E 's/""/"/g; s/^"//g; s/"$//g' | tail -n +2 | jq .

Basically replace the quotes with sed and skip the header row with tail

In case other people find this via Google and need a workaround, this is mine using qsv and jq:
< csv qsv tojsonl | jq '.RAW_JSON' -r
I would still love to see this feature in xsv.


Go tests disappear when clicking in reload

I have a go project with different services in sub-directories:
Each service get his own test file (names _test.go
Here is part of my file structure:
/pgk/tools. -> 4 *_test.go files
/src/dbapi
dbapiclient. ->  1 dbapiclient_test.go
server. ->  1 dbapiserver_test.go
./decod.    -> 2 *_test.go
./postgres -> 3 *_test.go
There will be other sub-directories in /pkg and in /src
When I start vscode (latest version), test explorer only detects 2 tests files
If I click on the reload button, one test file disappear..
If I edit a 'missing' go test file, it is added in the list, but will not be there when I restart vs code...
Is there a way to force which subdiretories to look for test files ?
Nicolas

vscode-test-explorer is a generic test visualising UI. it doesn't know anything about specific test frameworks. to learn about test suites and cases for different languages it relies on test adapters. they are the ones discovering and running tests, they capture test results and report them to test explorer.
that being said, your problem quite likely is with go-test-adapter (see https://gitlab.com/firelizzard/vscode-go-test-adapter) you might try report an issue over there.


add ethernet-switching filter type

Hi team,
This PR is related to issue https://github.com/aerleon/aerleon/issues/56
As discussed porting our Capirca PR here with associated unit tests.
It's basically adding ethernet-switching filter type for Juniper EX platform.
Thx

This is looking good but just to ask, do we know if all features for regular filters are supported with ethernet-switching? addresses and ports look to be supported but what about advanced features such as qos, logging, etc?

Most features are supported but indeed there are some hardware limitations.
It's also the case for QFX filters: we had to remove logging or even filters in some scenario.
We can extend the unit tests to have more coverage and identify the gaps if you want to?


proposal: utf8: add ErrInvalid

Proposal Details
I propose the addition of the following sentinel error to the utf8 package:
// ErrInvalid indicates that invalid UTF-8 was encountered within a text string.
// Packages that return this error should usually wrap this error value within
// some local error type to provide further semantic context regarding where
// this error occurred.
var ErrInvalid = errors.New("invalid UTF-8")

Many higher-level formats are built on top of UTF-8 (e.g., XML, JSON, protobuf, etc.) where encountering an UTF-8 encoding problem is a possibility. In many cases such an error is not fatal and processing can still continue such that a function that returns a typical (T, error) result may provide a sensible while also returning an error that matches utf8.ErrInvalid. Even if it is fatal, it is often useful for metrics reporting purposes to specially identify invalid UTF-8 as a particular class of errors.
This could replace internal error values used by the "encoding/json/v2" prototype and also within the protobuf module (e.g., golang/protobuf#1228).

Related Documentation

Package json > type InvalidUTF8Error 				¶

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

I have reservations about this. When we were doing the work that led to UTF-8, Ken and I made an explicit choice to use the invalid character instead of having an out-of-band error signal. The easiest way to explain why is to run grep on a file that has UTF-8-encoded text but also other things. On many systems you'll see an endless stream of complaints about bad bytes, hiding the information you're looking for. Now I know the situations don't exactly match up, but it's important almost always to continue processing even when an encoding error arises, and adding this error to the package would encourage people not to do that.
In other words, your "processing can continue" is true and desired, but making the error happen will discourage that. I can't even think of another standard error in the library that is meant to persist until all processing is done. Instead, errors stop processing, always.

The goal then is to have a conventionally-agreed-upon value to use for higher-level parsers for languages whose syntax requires valid UTF-8, so that their callers could use errors.Is (and similar) to handle that situation in a special way without needing each higher-level parser to offer its own error value for that case.

Correct. It may very well have been the intent of UTF-8 to avoid needing an out-of-band error signal, but the reality is that many formats strictly require that the format be composed of valid UTF-8 and I've encountered needing to make this distinction multiple times.

The part about returning utf8.ErrInvalid along with a parsed result to indicate "this result is usable aside from having incorrect UTF-8 encoding" seems a little dubious to me, but ultimately that's a decision that can be made by the designer of each higher-level parser and described in their own documentation, rather than being a direct part of this proposal.

Correct. My proposal doesn't specify that returning utf8.ErrInvalid guarantees that the result may be usable. I'm just saying that a given implementation that does make use of utf8.ErrInvalid may document if that is so.
For example, jsontext.AppendUnquote will decode a JSON string completely, but report an error if invalid UTF-8 is encountered. Some callers of that function do not care if invalid UTF-8 exists so long as it is reasonably handled (e.g., coerced into the Unicode replacement character), but other use-cases require that the input be valid UTF-8.


protocol-kit: enableModule and disableModule functions are missing on Safe contracts

Description
The type definitions seem to lack some functions. I tried encoding a call to enableModule but couldn't find that function on the contract instances provided by protocol-kit

Environment

protocol-kit: 5.0.1

@jfschwarz thank you for your report. I see that for now you did a workaround with the .encode('enableModule, [])
Will check as we also use it like that in the moduleManager


AST - Fix Earthly Star counts

We weren't ever incrementing uses, which was the main issue.
Also copy the logic from Draw for calculating lost time if it stopped being used at some point during the fight.
Fixes issue reported on discord.

I don't know who Ay is short for, can you tag them to see when they can give this a look? Someone joined the discord to ask about this bug.

@ayyaruq

Merged so we can get this done without further superfluous edits.


Browse records:  what do do with the "documents not have field" message

JIRA issue created by: rcook
Originally opened: 2011-10-28 06:56 PM
Issue body:
(nt)
This issue has an attachment associated with it (external link): directors.png

JIRA Comment by user: rcook
JIRA Timestamp: 2011-10-28 06:58 PM
Comment body:
This happens in both directors and Language tabs.
Jennifer has proposed removing this, or at least making the word "document" into the plural "documents".
Should we show?

JIRA Comment by user: dlindahl
JIRA Timestamp: 2011-10-29 07:07 PM
Comment body:
For the directors tab, it should say: "Director information is not available for <#> items in the collection."
For the languages tab: "Language information..."
For the genres tab: "Genre information..."
At first, I thought this should be a distinct field in the form you fill out for the browse page builder.  Why?  Note that the tab name is "Genres" and the drop-down-box label is "Genres" but the string in the note field is "Genre" (without the "s")
BUT, now, I think that most of the tab names and drop down box field labels should be changed to remove the "s" at the end.  This means that we SHOULD NOT MODIFY the admin forms.
Just make change the tabs to read: Title, Language, Director and Genre.  Leave Keywords tab as is.
And change the drop-down-selection-labels to read: Director, Language, and Genre
And the string can be constructed dynamically as follows:
 information is not available for <#> items in the collection.
Also, I have a question, are you counting how many items within the set of DVDs and Videos do not have the field, or are you counting the number of items in the entire Rochester catalog that do not have the field?  You should only be counting within the video/dvd subset.

JIRA Comment by user: pkiraly
JIRA Timestamp: 2011-11-04 08:31 PM
Comment body:

	Done.

	The count is relevant only for the video subset, not for the whole catalog.

Issue resolved: 2011-11-04 08:31 PM


Keeps returning to AP-STA mode.

How do you keep the happy-bubble-ble from reverting back to AP-STA mode? I am using the latest firmware.
Thanks!

Brian,
This should have been addressed from Version 10 and on. I can't replicate this in the newest one. Which mode are you in when you see it acting as AP?


Add changes in charging profiles and cars collections to socket.io.

Signed-off-by: Jérôme Benoit<EMAIL_ADDRESS>

Conflicts to resolve

Conflicts to resolve

Done.


feat: add code for car serialization format

Add a code for CARs so that in .storage services we could identify them by multihash

oh, and do we need a v1 and v2 here? we can differentiate once we get the bytes, but do we need to know up front where multicodecs get used?

oh, and do we need a v1 and v2 here? we can differentiate once we get the bytes, but do we need to know up front where multicodecs get used?

For our use cases that seems irrelevant, as long as we can identify the version from the bytes.
I suggest we go with generic car code and if we find that capturing version is important we could add version specific entries as well.

If this code is intended to be used in a CID as multicodec-content-type (this is what the spec currently calls it), then it should be ipld and not serialization. I think there is agreement that only IPLD formats should be there and we should update the CID spec to make that clear.

If this code is intended to be used in a CID as multicodec-content-type (this is what the spec currently calls it), then it should be ipld and not serialization. I think there is agreement that only IPLD formats should be there and we should update the CID spec to make that clear.

What the point of that table column if only value allowed is “ipld” ?
I suggest we start with “serialization” because it is a fact today. If we end up turning it into codec, using it in CIDs we can update that column to reflect that fact.

What the point of that table column if only value allowed is “ipld” ?

The Multicodec Table is a table that is not related to CIDs. It's just a list of things that map to certain numbers. The column is there to make sense, what such a number is used for. E.g. for a Multihash, or for IPLD Codecs that can then be used in CIDs.

The Multicodec Table is a table that is not related to CIDs.

I have misunderstood what you were referring to with “there” in your previous comment.
Does my suggestion of starting with the “serialization” to reflect fact today and updating that as necessary in the future makes sense ?

Re serialization and ipld:

If we end up turning it into codec, using it in CIDs we can update that column to reflect that fact.

I'm OK with this as a position if it's not going to be used for CIDs (a good way to think about this column might be something like: "does the decoder yield IPLD links?", and a CAR decoder does in fact yield links). But this raises the question of what this is being used for if not CIDs? Continuing from #239, I think most of us are assuming that's what this would be for. But apparently not?
So back to the original ask:

Add a code for CARs so that in .storage services we could identify them by multihash

How does this help you identify by multihash? Presumably you're going to hash the bytes and the digest from that gives you the multihash. What do you need the additional identifier for if not to make CIDs?
This is not a blocker btw, I think this can be merged, but the nuances might dictate needing to change that type column. I'm currently imagining this being a little like the CAR index format codes, 0x0400 and 0x0401 which are just unique identifiers for a single thing among a group of related things and I'm assuming that .storage services have a need for uniquely identifying a CAR as a thing among a group of related things, but I'm not sure what that would be, if not the same use-case as CIDs.

To clarify why I asked, the use case I have in mind  is convention where raw and  car codecs are used on HTTP Gateway as a way of requesting a single Block and a CAR with that  DAG.

In this convention the multihash represents the root CID of a DAG, and if you plan to use car with a multihash that has different meaning, we should agree on that now.

How is that multihash generated?

I messed up when I said "we could identify them by multihash", because as you've all pointed out it's not really a multihash and I'm not sure we have term for it. We want to generate multihash for CAR and tag it with this code.
It is true that it sounds like CID, maybe it should be CID. Yet I really want to avoid the debate of whether it is good idea to identify things larger than libp2p block size limit with a CIDs. There are tradeoffs there and I'm not sure we're prepared to evaluate them yet.
I do think however that we can all agree on the fact that CAR is an established serialization format which can have it's own code.
I think we'll be in a better position to debate whether CAR as an IPLD codec is good idea after we've had a chance to evaluate that in our work. And only we're convinced that it's a right choice we can discuss tradeoffs and update table field if we choose so.

In this convention the multihash in a CID represents the root block of a DAG, and if you plan to use car with a multihash that has different meaning, we should agree on that now.

I love the idea of making gateway capable of export DAGs, but I am concerned about overloading CID codec here because:

CAR may not cover whole DAG (it may contain only subset of nodes)
It may contain nodes from multiple unrelated DAGs.
Same DAG can be represented by different CARs.

More broadly I think it is a mistake to think of CAR as DAG serialization format. Thinking of it as block set serialization seems a lot more accurate to me.
In regards to how we want to use it.
We want to generate CAR multihash by hashing bytes of the file (e.g. with sha256 and tagging accordingly) and than tag that multihash with CAR code. If we tag it with CID version we'd get a CID in a more traditional sense, but again I'm not prepared to have a debate on whether we should identify large things (greater than block size limit) with CIDs or not.

I'm going to merge this given approvals and comments suggesting no blockers here. Happy to carry on related discussions at https://github.com/multiformats/multicodec/issues/239 instead


Add google login

This pull request adds Google Login support.

Added dep. for<EMAIL_ADDRESS>Added class for Google Login Client
Added Google Login Example to Readme

This login code is based on the data provided by https://github.com/tejado/pgoapi

Wow that was quick, I was thinking about doing this myself later :)
Looks great, thank you!


Missing support for binary bitwise ops in metal

Metal issue: https://github.com/tenstorrent/tt-metal/issues/13582
This is blocking us from solving
https://github.com/tenstorrent/tt-mlir/issues/1051
https://github.com/tenstorrent/tt-mlir/issues/1053
https://github.com/tenstorrent/tt-mlir/issues/1054

FYI @tt-mpantic

Closing this issue as it is excessive. Issues that referenced this one will reference metal issue directly.


QUICK-FIX Change test of audit contains snapshotable control after deleting original control

This PR unskip and change according to actual expected behavior of existing test: "test_audit_contains_snapshotable_control_after_deleting_original_control".

@SergeyRabtsau I have changed approach of finding 'disabled' element,  please take a look.


ordered-imports rule

Fixes #771
See test & rule metadata for how this works. No options for now, but I could imagine many different ways to order & group imports.

👍

I added a line to the test that would break if lastImportSource weren't reset.

@adidahiya mind taking a look at this? Thanks!

This PR looks very good, thanks @danvk! I left a few comments above for tweaks/improvements.
My first thoughts were that import {SomeClass, someFunc} from "a" should be enforced instead of import {someFunc, SomeClass} from "a". Perhaps this is one of the cases though where it doesn't really matter which is the default, as long as users can choose which they want (eventually). There do seem to be many possible options for this rule, but perhaps we're better off starting simple as you've implemented it here.

@JKillian Thanks for the educational review! I've taken all your suggestions and added an option to control the order of named declarations. Valid options are:

"case-insensitive": Correct order is {A, b, C}. (This is the default.)
"lowercase-first": Correct order is {b, A, C}.
"lowercase-last": Correct order is {A, C, b}.

For named imports like:
import {longName as name} from 'foo';
import {name: longName} from 'foo';

I'm sorting by the full text, i.e. longName as name and name: longName.
Let me know if you have any more suggestions.

My apologies for my one comment, I don't believe import { symbol: localName } from "./wherever"; is valid ES6 or valid TS! Using as as you mention above is correct, and I think the way you handle it currently is good.
(As as aside, I wonder why the syntax differs between importing and destructuring?)
Those options you provide seem good to me. It also keeps the door open for adding ordering of groups in the future.

Looking good! Just left a few comments on some minor docs changes

Addressed all comments.
I'm not sure why the syntaxes for imports and destructuring are different. I certainly find the {name as localName} syntax to be much clearer. I never use const {a: b} = o; because I can never remember whether that means const a = o.b; or const b = o.a;.

Sweet, merged!

I order my imports based on the full text, and not the "source". Two benefits are:

I can use something like "sort lines" in my editor (VS Code).
It's easier to look up a named import (for example) in this alphabetical order. The "source" is possibly less important.

I'm not 100% sure about this though. I may change my mind. :stuck_out_tongue:


Remote theme cross-origin not working

Checklist

[x] I have read the newlest tutorials and know the correct effect of the functional design.
[x] There is no similar question on existing issues (including closed ones).
[x] I have tried to find the answer on Jekyll Forum and StackOverflow.
[x] My question is based on the latest code of the master branch.

Description

I have setup my site using the theme, however needed to make some modifications that likely you wouldn't want to add to the main theme, so created a fork and modified this I then used jekyll-remote-theme to load the theme, when I do this the cross-origin data doesn't appear to work.
There are no errors and when I inspect the webpage can see that the href is empty for all of them. It's almost like the assign origin = 'cross_origin' is not actually being set.
Do you have any idea what would cause this?

figured this out, i had to create the _data\assets file on my website repository im guessing it overrides so cant find it unless i do that.


Module pages not loading in IE

Going to a module never loads on Internet Explorer for example:

http://package.elm-lang.org/packages/elm-lang/core/2.1.0/Signal

What version of Internet Explorer is this? What version of Windows are you running?

Internet Explorer 11 running on Windows 8.1. There is nothing in the console.

Checked and observed the same behavior. Though I do get something in the console. Namely a complaint that str.trimLeft() is not defined. Maybe IE does not implement that JavaScript function for strings, so the reliance on it in the corresponding Elm function leads to problems? (And then that would not be something that hits in this package page, but also in other compiled Elm code.)

The relevant uses of trimLeft in this case would be this and this. But of course that doesn't really matter if it is a general problem affecting all Elm code in IE.

See https://github.com/elm-lang/core/issues/319.

Thanks for the report @alexiamcdonald, and nice bug hunting @jvoigtlaender, thanks! This should be fixed with the next release of elm-lang/core so I'm gonna close this knowing the fix will come. If things are still broken after that, let's open another issue and debug from there.


improve the document for proto compiling

What this PR does:
improve the document for proto compiling
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #110 (c1646d8) into main (6d89057) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   40.32%   40.47%   +0.14%
==========================================
  Files          39       39
  Lines        1344     1344
==========================================
+ Hits          542      544       +2
+ Misses        761      760       -1
+ Partials       41       40       -1

Impacted Files
Coverage Δ

...kg/filter/network/tcpcopy/persistence/work_pool.go
90.00% <0.00%> (+5.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d89057...c1646d8. Read the comment docs.


Basis function for nodes?

I'm looking for an efficient way to get the value of a basis function at each individual node on a mesh. I'm computing a quantity like so
a = \sum_{i=1}^{n} a_{i}(t) N_{i}(x)

where N represents the nodal basis functions evaluated at 3D point x.
For any given FiniteElement in MFEM, I can call element.CalcShape(...) to get the value of the functions across the element, but is there a simple way to get the nodal basis functions? What I would like to do is something like
feSpace.getNode(i).CalcShape(x)

or
feSpace.getShapeAtNode(i,x)

Any suggestions? Thanks in advance!

How is the point x given? Do you know the element it belongs to and the reference coordinates?
If you do and you compute a_{i}(t) for a given t and initialize the entries of a GridFunction with those values, then you can call the method GridFunction::GetValue(j, ip) where j is the index of the element that contains x and ip is the IntegrationPoint that specifies the reference coordinates of x.
If you just have the physical coordinates of x you will need to call something like Mesh::FindPoints(...) first.

Thanks @v-dobrev! What's the difference between GridFunction.GetValue() and GridFunction.GetNodalValues()?

There are two versions of GetNodalValues - one that works for one element and a second one that works with the whole mesh. Both return the values of a GridFunction at the vertices of the mesh. The global one will also perform averaging in the vertices when the GridFunction is not continuous.
On the other hand, GetValue works for any point inside a single element.

Very good to know. Thanks @v-dobrev.
If I understand this correctly, GridFunction.CalcShape() will give me the total shape function for the element for a point x. What if I want it for the shape function due to only one node? Let's say I have a 1D element with nodes i and j on the left and right, and nodal basis functions N_{i}(x) and N_{j}(x). Is it possible to compute only N_{i}(x), for example?
Forgive me if I'm unclear or not keeping up. Still learning MFEM (and loving it!).

Thanks @tzanio. I'll take a look at the mini-app and review this some more.
Yeah, it is a little weird. I'm using MFEM to build a Material Point Method code and I need the values of the nodal basis functions to create the matrix that maps particle positions to nodal basis function values at those positions.
I really appreciate the help from you and @v-dobrev! More soon.

I just had a chance to look at this. I think I misread the documentation for fe.CalcShape(...). That function computes the all the shapes at ip, which is what I need. GridFunction uses this to retrieve the shapes and then computes the inner product of the two vectors for the element. Does that sound correct?

Yes, that is correct.

@jayjaybillings were you able to make progress on this? Do you have any additional questions?

@tzanio Thanks for closing and following up. Apologies for now responding sooner.
I do not have any additional questions. I think this works for me.

Feel free to reopen anytime :)


remove search panel

Hi,
I am trying to remove search panel from the grid. I have found the function withoutSearchForm() in RendersGrid.php. This function seems to be used in one of the tests so I suppose it should actually work. Here is how I create and render the grid:

public function index(KeysGridInterface $keysGrid, Request $request)
    {

        return $keysGrid
                ->create(['query' => Key::latest(), 'request' => $request])
                ->withoutSearchForm()
                ->renderOn('home.manage-keys.index');

    }

But the search form is still there. The function withoutSearchForm() doesn't seem to change anything.
Could you please help me understand how I need to call it?
Thanks in advance

Will look into it. I've not been on github for a while.


BREAKING: return zapray.Logger and implement remaining zap.Logger method wrappers

This allow us to just use the the zapray wrapper without having to think
about zap.Logger and the conversion to it on some method calls.
We can continue to use zapray.Logger.Logger to get the underlying logger
if needed.

Thanks for the PR, this is a nice addition, also been meaning to add a NewProduction constructor for a while!
I'll cut a release on Monday with these changes.


Old wallet not working!

I have exactly the same problem, and I download a more recent one and that warning keeps coming out, I do not know what I can do ..

We apologize for any inconvenience that the swing wallet not working has caused!  We are actively working on resolving the issue permanently. For now, please see below.
Remember - wallet issues DO NOT result in loss of your coins.  Your coins live on the blockchain - as long as you have your wallet.dat and/or your private keys, you are safe.
DOWNLOAD LATEST <IP_ADDRESS>: https://github.com/bitcoinz-pod/bitcoinz-wallet/releases
Solution
Make sure to backup your BitcoinZ wallet directory that contains the wallet.dat file before proceeding!
Close your wallet
Goto %AppData%\BitcoinZ
Delete all EXCEPT your wallet.dat
Re-run your wallet - give it some time to try and find connections to continue the sync from where it left off.
IF connections remain at 0 after a reasonable amount of time, then:
Close your wallet
Edit your bitcoinz.conf file located at %AppData%\BitcoinZ
Edit your bitcoinz.conf with Notepad, Textpad, or Notepad++ to include:
addnode=<IP_ADDRESS>
addnode=<IP_ADDRESS>
addnode=<IP_ADDRESS>
addnode=<IP_ADDRESS>
addnode=btcz.kovach.biz
addnode=seed.btcz.life
addnode=bzseed.secnode.tk
addnode=btzseed.blockhub.info
addnode=btcz-us.crypt29.net
addnode=btcz.vnminers.com
addnode=dnsseed.ppcall.ru
Restart your wallet

@renuzit this is exactly what I've done...Read my previus reply...
The problem is that this is happening regularly and I can't do this each time this happens!

@renuzit @digibum
Tradesatoshi btcz wallet also has problems :)

If you can keep it running, it won't have issues.
Another thing you can try is to only delete the peers.dat file. We have reason to believe that BitcoinZ is connecting to invalid peers which do an instant reject. It will, however, take a while to find a connection.

@lukazvar We have no evidence to believe that Tradesatoshi is having wallet issues. We think it's a combination of them being slow with transactions and user wallet issues.

@renuzit  pending for hours

@lukazvar No Txid means no transfer request has issued on the BTCZ network.

@lukazvar It's typical to see 0 confirmations in Tradesatoshi as it processes through their internal systems. Once the transfer has been approved, the transactionId will be created and this is when it hits the BTCz Blockchain. Without a Txid, we can't say an attempt was even made by Tradesatoshi to start a transfer.

Now pending for days :)

Thank you for trying to give a solution to the problem of the wallet. I would like to know the exact path where wallet.dat is located because I can not find it. I have already downloaded the latest version <IP_ADDRESS> but I do not want to delete anything in case I do something wrong. Or if you can do a mini tutorial on how to fix the problem. Thank you...

I agree with @Gofioamasado .
I have solved my issues with a help of a friend.
We are not all hardcore techies.
And when something like that happens, youtube step by step tutorial would help a lot!

@renuzit I was happy way soon :) WTF!

Hi there,
We had the same issue on HUSH network and traced it down to this:
https://github.com/MyHush/hush/commit/aeda8a9faa766fdde3de84305377c1df727536af
Upstream fixed it, for other reasons it appears, some weeks ago:
https://github.com/zcash/zcash/pull/2931
Regards!

thanks @FireMartZ  ! and thanks zcash upstream https://github.com/zcash/zcash/pull/2931

If this is a fix, who can do this?

@cannonballdex I have fixed the binary on my branch, but we're waiting on the dev to make an update here. If you want, you can download my binary replacement here:
https://github.com/renuzit/bitcoinz-win/releases/tag/1.1.5_2
To install, you can download the zip file, unzip the package, and replace the 'zcashd' binary found in the wallet with the updated one.

and this is how you deal with problems WTF!

I created a patched <IP_ADDRESS> release that resolves the EOF issue. You can find it here:
https://github.com/bitcoinz-wallets/bitcoinz-swing-wallet/releases/tag/<IP_ADDRESS>-patched

Today I will try it and comment on the result. Thanks for your effort

I have installed the patched version. At first it did not work, after restarting everything ok. The problem is that my balance is 0 BTCZ. I do not understand what could have happened. I leave some photos ... I have few coins about 440 approximately that I have mined at times at home. I would not like to think that I have lost them. Any solution?? Thank you

In the last photo do not leave the total transactions I made. Some are missing

@renuzit help me please!!!

@Gofioamasado did you keep your wallet.dat or have your private key?  If so did you place your old wallet.dat in the AppData\BitcoinZ directory or import your private key?

I have not deleted anything, I have only installed the patched version. And now looking for wallet.dat. Date of modification 02/22/2018. Today I tried to send 9 crypts to the wallet and I did not get it. Same error on the screen, after restarting everything ok but without coins and date modified as in the photo. I repeat that I do not have many cryptos mined in total 446BTCZ. But it's raging not to count on them after my effort and energy spent. I would have preferred to send them to my Android wallet address where I have 10 crypts. The private key where I can see it, because when doing Windows wallet I did not get an option or code. Greetings and thanks for your help.

I don't know what your old address was that had 446 coins in it.. Is it listed under the 'Own Addresses' ?

I have looked at my old wallet and searched the file wallet.dat and it says modification date 02/22/2018. How can I find the coins in the blockchain? Or my private key? @cryptorex @renuzit

@Gofioamasado  I see the address in your screenshot - if you are not synced 100% you will not see your balance. If you are synced and your wallet address t1gHXgKRoRFHxnmGL4FNNeBeaRrbPCf4iGg appears in your 'Own Addresses' then I have no idea what you did.  You get your private key by right clicking the address and exporting the private key.

checkout
https://github.com/bitcoinz-pod/bitcoinz-wallet/releases/download/<IP_ADDRESS>/bitcoinz-windows-wallet_<IP_ADDRESS>-2_win64.zip
backup your wallet.dat
delete all files from %appdata%/BitcoinZ and leave only wallet.dat
you can also run tools/reindex.bat

I tried the last version of the wallet and it was not going well, I tried again the patched version and little by little all the transactions that I had until the total was appearing. Today I tried to mine and send back some crypts to the wallet. Everything ok Do you advise me to stay in this patched version? I have already made the copy of wallet.dat. Or follow the steps and try the last one? Many thanks

its more systemic. and provide linux too! not all of us- most of us miners use it. The daemon syncs ok but doesnt provide the interface to send- the wallet claims it cant connect and tries to override the blockchain data, which corrupts it requiring a re-sync again. This started just over a week ago intermittently- so I reindexed it before but now he wallet is overridding the zcashd (should be called btczd due to package conflict w zcash) files so I cant send out my z's. I hope that makes sence.I have copy of wallet file.

I have the same problem as Gofioamasado. So it looks like in my last send to a transparent address, the the remaining unspent balance was sent to a randomly generated address. I did not export the private key but had my wallet.db unencrypted so figured no issue.
Well come to find I ran into the EOF error to my horror. After investigating, I downloaded the patched wallet (which strangely did not have an incremented version) after performing a backup and reindex. After it was complete, I was finally able to open my wallet but found I had a zero balance. How do I recover from this situation?
Would the wallet overwrite my wallet.db? If so, this seems to be a poor design choice resulting in the loss of over 300k BTCZ. Moreover, there should be a dialog box on send to transparent address informing the user of this risk and that private key should be exported immediately after such transactions. Never did I think the client would overwrite my wallet.db...
I hope that this project will be able to redeem itself but as of now I have over 300k BTC in an address that I can't seem to access any longer. What a disappointing turn of events. :(
https://explorer.btcz.rocks/address/t1RWFSERkGjwLYJd7EVEEBKsNdJebK5AoFk


[rom] Improve hardened checks

Change the hardened check to evaluate both the requested condition and its opposite.  Land on an illegal instruction if either of the tests evaluates incorrectly.

Should we add some unittests just as a sanity check given all the inverse operations?

Would it surprise you to know we didn't have any tests of the hardened sequences (apart from the fact that the ROM itself executes successfully).
I've added an on-target test that checks each of the hardened sequences in both the good and bad cases.

The functest makes me feel much better :) Thanks @cfrantz!
LGTM

The CI test failure is not related to the change in this PR.


Implement lazy Array.__iter__

[x] Closes #7889
[x] Tests added / failed
[x] Passes black dask / flake8 dask / isort dask

This doesn't fix the original issue https://github.com/pandas-dev/pandas/issues/38645, but hopefully it'll make it easier for pandas to know that it should sanitize dask.arrays.

I'm also ok with the compute call.  I think that we should be curious about how this will get used.
If people are going to do the following
for row in x:
    row = row.compute()
    # do something with row

Then we definitely want to pre-compute in order to save them from recomputing each block thousands of times.
I recommend that we check in with DataFrame.iterrows and be consistent with that.

 I find it slightly surprising every time that dask returns a value when I haven't explicitly called compute.
That said, DataFrame.iterrows returns computed rows.
In [1]: import dask
   ...: import dask.dataframe as dd
   ...:
   ...: ddf = dask.datasets.timeseries()
   ...: for row in ddf.iterrows():
   ...:     print(row)
   ...:     break
   ...:
(Timestamp('2000-01-01 00:00:00', freq='S'), id          1038
name       Zelda
x       0.228069
y       0.582803
Name: 2000-01-01 00:00:00, dtype: object)

The difference is that it is really really easy to accidentally trigger an __iter__ call. See https://github.com/dask/dask/pull/7913 where I am cleaning up some accidental usages.
Here is a case that people might not think of as using __iter__:
import dask
import dask.dataframe as dd

ddf = dask.datasets.timeseries()
["Alice" in ddf.name.values]

Of course that just uses __iter__ because we haven't implemented __contains__ . Which we should probably implement if we go with a greedy __iter__. I just did a quick little check with this:
    def __iter__(self):
        for block in self.blocks:
            array = block.compute()
            for row in array:
                yield row

    def __contains__(self, value):
        for block in self.blocks:
            array = block.compute()
            yield value in array

# with iter only
%timeit ["Alice" in ddf.name.values]
19.7 ms ± 1.41 ms per loop (mean ± std. dev. of 7 runs, 100 loops each)

# also with contains
%timeit ["Alice" in ddf.name.values]
551 µs ± 19 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

@jrbourbeau pointed out that this contains is implemented wrong. So feel free to ignore that bit

My sense is that we should stay consistent with dask.dataframe and return computed values.  I have trouble finding an application for returning an iterable of dask arrays.

My sense is that we should stay consistent with dask.dataframe and return computed values. I have trouble finding an application for returning an iterable of dask arrays.

Works for me! I'll change the implementation.

As noted on https://github.com/dask/dask/issues/7889 by @GenevieveBuckley and @davidhassell, having iteration over an array implicitly compute values is a breaking change. I know I've also written plenty of code that depends on the current behavior of returning delayed values, and would behave disastrously if this changed.

My sense is that we should stay consistent with dask.dataframe

With dataframes, we don't know the number of rows, so (some) compute is necessary to do row-by-row iteration, which is maybe why dask.dataframe behaves this way in the first place?
Though it might be more consistent with dataframe, IMO it's less consistent with the rest of the dask.array API. In general I think of dask.array as "equivalent to NumPy, but everything is delayed (unless impossible)". I can't think of something inherent to the __iter__ interface that suggests the results should be computed, any more than they should be eagerly computed by slicing or some other operation. Yes, you can achieve the same thing by slicing in a for-loop or using da.take, but people are familiar with the __iter__ semantics on a NumPy array, and should reasonably expect dask arrays to behave in an equivalent way within the dask world.

Thank you for chiming in @gjoseph92 - I was having trouble articulating why the computed version felt weird to me.
So I think this PR is good to merge. It doesn't change any behavior, just makes the response from __iter__ explicit.


Possible solution for #302 - new function Matrix.hadmardPower()

As Matrix.power(n) produces a true matrix power, for element wise powers the function Matrix.hadmardPower(n)was added.
This possibly helps to close #302 .

I am closing that as it accidentially includes parts of #288 and #289.


tests: re-enable all tests

Codecov Report

Merging #155 (e815ba3) into develop (a8fd906) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e815ba3 differs from pull request most recent head a622ff1. Consider uploading reports for the commit a622ff1 to get more accurate results

@@           Coverage Diff            @@
##           develop     #155   +/-   ##
========================================
  Coverage    86.05%   86.05%
========================================
  Files           49       49
  Lines         1936     1936
  Branches       307      307
========================================
  Hits          1666     1666
  Misses         270      270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fd906...a622ff1. Read the comment docs.


Add showcase pokemon type

An attempt from my side to add support for pokemon type on showcases, that we have seen with the Dazzling Dream event.
Will still need support from Reactmap to actually show the info, but now we parse and store the data in Golbat.
Have only tested this briefly so far, but seems to be working.
Can't say if this is a good solution, but trying to learn. So all feedback is appreciated.

https://github.com/WatWowMap/ReactMap/pull/916 untested but maybe you can try it @Cronick

Together with the ReactMap PR

Looks good to me. Conflicts with #194 for sql migration so will need to be merged seperately

Looks good to me. Conflicts with #194 for sql migration so will need to be merged seperately

Yeah. Just called both 25, so both could be merged before the other.
Will of course change that.

Thanks for your contribution :)


v0.0.16 Controller fails to create/update a Lattice Service when no endpoints in any of the corresponding K8S Services

Steps to reproduce:

Create a K8S HTTPRoute pointed at a Lattice Gateway as the parent and, as the backend, a K8S Service whose selectors don't match any endpoints.
Observe that the Controller is unable to create (or update) the Lattice Service, and keeps spewing the following:

{"level":"info","ts":1693939293.0518966,"logger":"controller.route","caller":"controllers/route_controller.go:312","msg":"RouteReconciler: Failed deploy traffic-exemplar due to err TargetSynthesize: Failed to create targets :&{{0xc012a2d000 AWS:VPCServiceNetwork::Targets k8s-traffic-exemplar-traffic-exemplar} {traffic-exemplar traffic-exemplar traffic-exemplar  []}} , err:InvalidParameter: 1 validation error(s) found.\n- missing required field, RegisterTargetsInput.Targets.\n\n"}

It appears that the Controller is calling some API which does not let it provide an empty list of Targets for a Target Group. Strangely, the AWS Console does let me create/update Target Groups without any targets. So, it seems the Controller has a bug.

Thanks for reporting this issue.
Relevant: https://github.com/aws/aws-application-networking-k8s/blob/main/pkg/deploy/stack_deployer.go#L120-L133
I had a quick look, I feel like this is not a v0.0.16 regression and the controller has been working like this since the beginning. The controller cannot proceed to service reconciliation if it cannot finish target registration, and I don't recall any validation logic that prevents empty RegisterTargets request.

Hints for fix:

https://github.com/aws/aws-application-networking-k8s/blob/main/pkg/deploy/lattice/targets_synthesizer.go#L43-L44
check if list is empty

Thank you very much!


Transform DEF dataset from Julia Mahamid (Dataset 10000)

@anchi2c noticed we need to deal with #175 also, as segmentation masks are now supported.


skip setup assistant if Service Account JSON setting is already configured

Settings can be set by constants or via the Network Settings.
When activating the plugin...

[ ] If the Service Account JSON setting is already configured, skip the setup assistant and redirect the user to the settings panel.

What about Stateless Sync menu?
As everything configured shouldn't we moved directly to Stateless Sync?

@alimuzzaman they can access the 'Sync' tab from the 'Settings' tab. That should be good enough.


Completely broken on Firefox, likely due to recent YT UI update

Currently does not work at all for me. I'm running the dev version via greasemonkey on the current build of Firefox, and every time I go to watch a video with YTC running, all I get is a blank page. Moreover, the settings menu is totally unavailable.
I don't have any other browsers with it installed, although spoofing Firefox's browser profile to any number of other web browsers does nothing to mitigate the problem.
Youtube recently updated its interface. I'm assuming that's the culprit.

+1 for me. FF 53, GM 3.10, YTC 548

No, it's not. You made me install TM, gahh.. Video auto-played when I have disabled that option, and annotation is on when it shouldn't be.

Same here, video autoplays when i have the option disabled.
Sometimes it stops 2 seconds in (automatically) and i have to refresh the page because the play button doesn't work anymore.

On Apr 21, 2017 2:06 AM, "BobBobBobBobBobBobBobBobBob" <
<EMAIL_ADDRESS>wrote:

Currently does not work at all for me. I'm running the dev version via
greasemonkey on the current build of Firefox, and every time I go to watch
a video with YTC running, all I get is a blank page. Moreover, the settings
menu is totally unavailable.
I don't have any other browsers with it installed, although spoofing
Firefox's browser profile to any number of other web browsers does nothing
to mitigate the problem.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

greasemonkey on the current build of Firefox, and every time I go to watch a video with YTC running,
all I get is a blank page. Moreover, the settings menu is totally unavailable.

Hi,
I had the same with FF 51 + Greasemonkey... Btw, at this time I could revert back to the previous YT UI through a link that was somewere I don't remerber where it was on the new UI :-/ ... Since, I still NOT use the new YT UI and YTC still work fine, except that YT/Google seem to have locked some protected content (see #2396).
Regards

@sdsucks

dev 548 working fine in FF 53 with tampermonkey 4.3.5393

Didn't solve anything for me. I was able to access the YTC options menu through Tampermonkey, but it was basically broken. Oddly, however, as autoplay was enabled by default on running it via Tampermonkey, videos seem to play in the background even though the page I'm given is still completely blank.
I've also disabled any extensions/scripts that could possibly interfere to no avail.

How to quote in github? Please teach! 😃
@joaocpfb I also had the same problem, video appear in only a black line but it's playing, I reloaded the page everytime I encountered this and then the normal video window will appear.

It appears to be functional now.
@p1nkyy
Just start the line with [>] (minus brackets)

Not in me, sometimes it works, sometimes not.

It's still completely broken for me.

Seriously considering to e-mail the dev right now 😖

Yeah, for me annotations and video autoplay are the most annoying problems right now on the normal youtube interface. Sounds like the new material design youtube that they are testing completely breaks it though.

Someone in the chrome/chromium thread found a solution,

to change all the con.log words in the userscripts into console.log
Change something into bootstrap.
The 2nd step, I don't know the equivalent in Firefox, maybe someone can help?
Check: https://github.com/YePpHa/YouTubeCenter/issues/2407

@p1nkyy @Parsnip @BobBobBobBobBobBobBobBobBob @JohanPirlouit @joaocpfb @sdsucks
Just tried that solution and it worked! 😀 (Windows 10 64-bit Firefox 53.0 64-bit)
Go to C:\Users\YOUR USERNAME\AppData\Roaming\Mozilla\Firefox\Profiles\YOUR USERNAME\gm_scripts\YouTube_Center_Developer_Build
There edit YouTubeCenter.user.js (i used notepad++) press CTRL+F, go to the Replace tab, in find input "con.log" and in replace input "console.log", hit "Replace All" (it should replace about 144 entries) then you save and restart Firefox!
I hope this helps.

Doesn't really work for me. Maybe someone else can confirm? I still think it needs the 2nd step...

I'm not quite sure that chrome issue is the same issue at all since it apparently works in older chromium.
And in this thread we have at least 2 different issues (completely broken with just blank youtube page versus mostly working with broken autoplay and annotations).

Maybe it's time to summon the developers: @YePpHa @aggroskater , please help us that's desperately want this awesome script to work again!

@Parsnip I get the blank page too, just not too often.

weird because dev548 + FF54b2 + GM3.11 is working just fine for me

Used same as above except beta 3 instead of 2 for FF. I don't think it's completely broken for me but something I've noticed is if I have Tab Auto Pause on and I allow it to do that, it'll permanently pause the video. I have to refresh the window to be able to play the video.

@omperus it is probably only broken again because, if you all perform this local on-disk edit, you should either also manually increment the version of the script internally (BAD IDEA because then you won't get the real update when it comes), or better idea - DISABLE ALL AUTO-UPDATING OF SCRIPTS in GM/TM, or your local edits will simply be silently overwritten on the next update check.

I have to confirm the issue. YTC548, FF nightly 55.0a1 (2017-05-01) (64-bit), linux.

The blank page issue is due to a UI redesign, which I've been seeing in increased frequency for the past few months. And now YouTube have made it official: https://youtube.googleblog.com/2017/05/a-sneak-peek-at-youtubes-new-look-and.html.

Replacing on the script "con.log" for "console.log" on firefox fixes a lot of stuff.

For those having problems with stopping auto-play, I managed to fix this by commenting the 2037th line of the script
//originalPlayFunc.apply(this, arguments);
I'm not entirely sure how this works, but until an official patch from @YePpHa, it does the job done for me.

No such luck here. I seem to be getting the same behavior whether that's commented out or not. Shame.


Custom menus have ghost border

pls see the screenshot below

fixed by https://github.com/Microsoft/vscode/commit/01fb34dc00c36566afc7ac55e09be4c17f2f1bb4


Theory page

Before sending your pull-request 💌 make sure :

[x] The tests are up-to-date and your code is tested

I'm going to fix the tests and I think we're good to go.
We just need to improve the content and translate it, but it can come later


Vox Ghost Role Spawns Have No Nitrogen Tank

Description
If a Vox spawns as a ghost role, (I'm assuming all) they spawn without nitrogen, and die.
Reproduction
Have a Vox spawn in a ghost role, like traveling chefs.
Screenshots

Additional context
They dead, Jim.

Thank you for reporting the issue! The good news is that a fix has already been submitted for this


Faster Groovy compilation

Groovy compilation via Gradle (GroovyCompile) currently doesn't support compile avoidance or incremental compilation. When we want to have IDEA to delegate to Gradle for compilation and test execution in the Gradle build, we need at least incremental compilation for a good developer experience.

we need at least incremental compilation for a good developer experience.

I would expect compile avoidance to have a better return for the effort, given that there are a lot of groovy compile tasks and a lot of projects.

Doing compile avoidance for Groovy would also mean that we'd need to abstract out the Java compile avoidance logic. With some more work we could make it into a public API, so Kotlin could implement its own compile avoidance. I think this could be another good reason to do Groovy compile avoidance.

See https://github.com/gradle/gradle/issues/5226 for supporting compile avoidance for other languages than Java.

we need at least incremental compilation for a good developer experience.

I would expect compile avoidance to have a better return for the effort, given that there are a lot of groovy compile tasks and a lot of projects

I think we should start with compile avoidance and see where we get.
A datapoint why incremental compilation would be good is that e.g. core:compileTestGroovy takes 40s on CI: https://e.grdev.net/s/klpldicnkwd4o/timeline?sort=duration&task=trevx2rfm4gr4&taskFilter=Groovy

Is there a chance this work could be incorporated somehow in the Apache groovy project?  I've been using GroovyScriptEngine and noticed it too has trouble with incremental compilation when static members are used.  See this issue for details: GroovyScriptEngine doesn't always reload classes
Or maybe there is a way to use gradle to provide similar functionality to what GroovyScriptEngine does now?

There are other ways around slow Groovy compilation:

stop working in :core and other large projects, and break them into smaller chunks
reduce the size of test source sets, so each compilation would work on a smaller number of source files
stop working with :core's existing tests, and instead copy anything we need to a new test source set directory

The last one is more of a stop-gap measure, and is probably not feasible. Modularizing tests more however could be beneficial regardless of why we do it.
I'm not saying we should go this path, though. But if we want to enable delegation without having incremental Groovy compilation (regardless if we have compile avoidance for Groovy), then we'll need some way to reduce the number of sources that need to be recompiled.

Have we measured where the slowness is to see if there are any quick wins?
Could we also introduce parallel compilation within a compile task?

The improvements to compilation don't have to be very good initially. For example, we can reuse the incremental java compilation as-is and unmodified for groovy compilation, and this will be perfectly fine for our purposes. It's not a general solution, as we're making an accuracy trade-off, so would need to be behind an opt-in until we find the time to finish it up. It's the same story for compile avoidance.

I agree with @adammurdoch that compile avoidance is likely to have a bigger impact, at least on the Groovy build itself. If shouldn't be too hard to implement. Basically, we can reuse @CompileClasspath, but it's not done for a reason: the Groovy compiler has slightly different semantics than the Java one.
In particular, the Groovy compiler has AST transformations (global or local). If a transformation code is updated, we need to recompile everything. However, the fix should be pretty simple: Gradle already internally separates the "compiler" classpath (compiler plugins aka AST xforms) from the "compile classpath" (libraries). So we could apply @CompileClasspath on the library part, while keep using @Classpath on the compiler part. We just need to expose this to the user, which is not done today.
There's also a slight complication, in that AST transformations can very well access arbitrary resources. In this case I think we should just provide a way to declare those resources as inputs (they should already, really).
Eventually, Groovy has this "compiler configuration" which is itself a Groovy script. Whenever it changes, we need to rebuild. But honestly I think compile avoidance shouldn't be much effort.
Then comes incremental compilation into play. Again, the semantics are the same as Java, so I think we could reuse most of what we do for Java. From what I remember in the code this is not trivial though, because the Groovy compile tasks and the Java compile tasks are not really implemented the same way. We also have to think about stub generation, but the biggest issue is again AST transforms: because we don't know what they do, if an AST xform is found on the compiler classpath, we have to disable incremental compilation. It's extremely similar to what we have for annotation processors in Java, only Groovy allows more things.

I think the key here is that we aren’t needing perfection. If it can work most of the time it’s good enough since this is really just a development centric feature.

We understand this, and on the other hand we don't want to trade correctness for performance. So we have to find the right way to do it.

Let's keep this epic open.


Create pull request template

Context
At the moment the project doesn't have a PR template.
Some examples of PR templates can be seen:
https://github.com/devspace/awesome-github-templates#rocket-templates-for-pull-requests
Acceptance criteria

Create .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

What are the things we want our contributors to keep in mind when raising PR?
Few mandatory items I can think of to be added in  every PR
Fixes #issue-ref

Description/Approach

??

@bhavaniravi at the moment we have a checklist for new features issues. I believe we should have a similar list for pull requests. Not all pull requests will need all the items of the checklist, but they could serve as reminders

In my opinion, some of the things that we should have:

Any assumptions made when implementing the code in the PR
Limitations
A description of the changes proposed in the pull request. A PR reviewer should know on a high-level (the approach) on what the changes in the PR achieves
A reference to a related issue in your repository.
If there are any new tickets or action items we need to do even after merging the PR. (Code, docs etc)
If there are interface or breaking changes: would be good to see a before/after example or screenshot if not already discussed or included in the issue.
Any open questions you have which you want the reviewer to give their opinion on.

Only the ones that are applicable for a particular PR should be added.
Some Examples of PRs with good descriptions:

https://github.com/apache/airflow/pull/22613
https://github.com/apache/airflow/pull/18675
https://github.com/apache/airflow/pull/10956
https://github.com/apache/airflow/pull/16289


spod: Make /etc/selinux.d an emptyDir instead of hostPath

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Since the directory only contains policy definitions, not the actual
policy result it is not needed to be a hostPath. The actual policy is
persisted in /etc/selinux (without the .d).
The original idea behind having a hostPath was to run selinuxd on the
nodes directly to lock down even e.g. the kubelet. But that will not
happen, at least not in the short term, so let's reduce the number of
our hostPath mounts a little.
Which issue(s) this PR fixes:
None

Does this PR have test?
N/A tested by existing tests

Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?

The directory /etc/selinux.d used to be mounted on the hosts in previous SPO versions.
This is no longer the case, the directory was converted to an emptyDir instead,
reducing the number of required host mounts.

Codecov Report

Merging #698 (1003795) into master (248f47e) will not change coverage.
The diff coverage is n/a.


[rom_e2e] Fix the e2e_weak_straps test

This test should run an unsigned binary when executing under the test_rom and should run with empty flash when executing under the mask_rom.

Addresses #21630.


rustc: fix >=1.68 host!=build

Fix for this issue.
Description of changes
Our rustc.nix adds a --target flag for the host when doing a host!=target build, but neglects to add a --target flag for the buildPlatform when doing a build!=(host==target) build.  This commit corrects that.
Before rustc 1.68 omitting the --target flag for the buildPlatform did not cause any problems.  As of rustc 1.68, build!=host without a --target for the build will fail like below (with hundreds more "cannot find std::" errors.
$ nix build -f . -L pkgsCross.aarch64-multiplatform.rustc
...
Copying stage1 library from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / aarch64-unknown-linux-gnu)
Uplifting stage1 library (x86_64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
Copying stage2 library from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / aarch64-unknown-linux-gnu)
Building stage2 tool rust-analyzer-proc-macro-srv (aarch64-unknown-linux-gnu)
   Compiling autocfg v1.1.0
   Compiling libc v0.2.135
   Compiling cfg-if v1.0.0
   Compiling proc-macro2 v1.0.47
   Compiling quote v1.0.21
   Compiling unicode-ident v1.0.5
   Compiling syn v1.0.102
   Compiling once_cell v1.15.0
   Compiling parking_lot_core v0.9.4
   Compiling serde_derive v1.0.145
   Compiling hashbrown v0.12.3
   Compiling scopeguard v1.1.0
   Compiling smallvec v1.10.0
   Compiling log v0.4.17
   Compiling serde v1.0.145
   Compiling rustc-hash v1.1.0
error[E0463]: can't find crate for `std`
error: cannot find macro `println` in this scope
 --> /nix/tmp/nix-build-rustc-aarch64-unknown-linux-gnu-1.68.2.drv-0/rustc-1.68.2-src/vendor/libc-0.2.135/build.rs:7:5
  |
7 |     println!("cargo:rerun-if-changed=build.rs");
  |     ^^^^^^^
error: cannot find macro `println` in this scope
  --> /nix/tmp/nix-build-rustc-aarch64-unknown-linux-gnu-1.68.2.drv-0/rustc-1.68.2-src/vendor/libc-0.2.135/build.rs:16:9
   |
16 |         println!(
   |         ^^^^^^^
error: cannot find macro `println` in this scope
  --> /nix/tmp/nix-build-rustc-aarch64-unknown-linux-gnu-1.68.2.drv-0/rustc-1.68.2-src/vendor/libc-0.2.135/build.rs:29:13
   |
29 |             println!("cargo:rustc-cfg=freebsd10")
   |             ^^^^^^^

Things done

Built on platform(s)

[x] aarch64-linux (cross from x86_64-linux)

[x] Fits CONTRIBUTING.md.

@ofborg build pkgsCross.aarch64-multiplatform.rustc

rustc, rustc.passthru.tests on x86_64-linux — Success


chore(litmus-portal): Added Myhub screens and redux setup for MyHub section

Proposed changes
This PR adds:

MyHub screens
Graphql queries from backend
Changed redux for MyHub Section

Screenshot of Connect MyHub Page

Screenshot of Connected Hubs Page

Screenshot of Charts Page

Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Thanks for the review @A4k9 . Have made the necessary changes!


feat(run-e2e): add e2e update project hook

Description
Right now, when running e2e tests we downloading test project and then running release and then we copying mpk to downloaded test project. This case don't work with data-widgets as widgets may depend on changes that were made in datagrid itself. Also, there are might be changes related to styles. So, to bypass this limitation I added new option - e2e-update-project hook (script). Now, e2e will check presence of this hook (script) in package.json and will execute this hook (script) if hook is present.
Pull request type

[ ] No code changes (changes to documentation, CI, metadata, etc)
[ ] Dependency changes (any modification to dependencies in package.json)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Test related change (New E2E test, test automation, etc.)

What should be covered while testing?

@r0b1n, can you please have a look when you have time?


Work without waist and chest trackers

Right now it works if you don't have waist or chest trackers, but it doesn't rotate at all. Yaw of waist and chest should match yaw of the headset if chest and waist trackers are missing probably. This is bad either way, but it will let test some stuff more easily without the need for full set of slimevr.
Legs with missing trackers should also match their yaw to the previous tracker in the chain.

solved in https://github.com/SlimeVR/SlimeVR-Server/pull/138


Format generated test file

See https://github.com/kadena-community/kadena.js/pull/291#discussion_r1211732301
This is a quick fix so the generated file is reformatted according to our Prettier config. Ideally we would do it directly in code but that would require more changes and adding the dependency, but this is a test project so I didn't bother.
It's kinda weird that we have to take into account that Rush does not execute npm run pre[task] or npm run post[task] but in this case we can take advantage of it.

I thought we removed it from being formatted and added it to .prettierignore. Maybe an idea to not format generated code in general?

I thought we removed it from being formatted and added it to .prettierignore. Maybe an idea to not format generated code in general?

Yes, totally agree. I assumed that the problem had to do with prettier not picking up the root ignore list when executed from a package dir, or something else more complicated (since nobody fixed it). But everything seems OK afaic, so I just pushed a change so this PR results in just an unformatted generated file.


Fernflower

Fernflower is a Java decompiler by Jetbrains
Metadata

homepage URL: ??
source URL: https://github.com/fesh0r/fernflower
license: apache
platforms: linux, ??

I would love to know how to do this myself.  I just don't know where the tutorial is.

IMO the best resource for getting started with packaging for nixpkgs is this.
It also mentions that is often a good idea to start with a similar package and adapt the build as necessary. This is how I usually do it as well.
Additional information can be found in this wiki entry:
https://nixos.wiki/wiki/Packaging/Tutorial
Is Fernflower just a plugin of IntelliJ or a standalone package?
Are you running NixOS or just using Nix as a package manager?
Feel free to ping me if you get stuck and need help

Fernflower can be used from the command line without having a IntelliJ installation.  I have done this.
I am using nixpkgs on Ubuntu.
If anybody (including @totoroot) have leads on simple java command line applications, I am interested because I have one personal that I am interested in packaging and this one makes two.
--
thx

I haven't yet packaged any Java applications, so I cannot get the package to build.
For anyone wanting to help getting this packaged, please take a look at this branch. I've entered the metadata already, so my branch should be a good starting point.

https://github.com/totoroot/nixpkgs/blob/init/fernflower-unstable-2022-12-30/pkgs/tools/security/fernflower/default.nix

Why is this not in development/java/ ??
$ JAVA_HOME=~/.jdks/semeru-17.0.5/ ./gradlew jar
JAVA_HOME=~/.jdks/semeru-17.0.5/ ./gradlew jar

Simply because I found another Java decompiler in security, namely jd-cli and thought I follow suit.
Whoever ends up working on this should decide where to put the package.
There are no incredibly strict guidelines where to put packages, so sometimes it is up to the maintainer (or in this case the person first creating the package) to decide.
I can't help you with your other questions, as I have no experience packaging Java applications.

Thx @totoroot
Hi @lorenzleutgeb,
Can I ask for your help in packaging this?

Any progress?

Just jumping in to say that it might be preferable to package vineflower as well/instead. It's a community maintained fork of fernflower with many improvements in both output and performance.

I've been fuddling around with other things.
It seems pretty simple, I'll try to (find and) update my previous work.
PS: vineflower (and others) noted.


Connection error

Describe the bug
I can´t connect to IBM I, i don´t have any problem with ACS connections
To Reproduce
Steps to reproduce the behavior:

Go to 'Connect to an IBM i'
Fill the fields.
Click on 'Connect'
Scroll down to '....'
See error
Not connected to <IP_ADDRESS>  Max identification string size exceed
Expected behavior
Connect to an IBM I

Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Extension version [V0.5.3)
IBM i OS version [e.g. 7.x2

Additional context
Add any other context about the problem here.

@eduardomarco Please fill out the issue correctly, especially the steps to reproduce. Thanks.

@eduardomarco Were you able to connect to the system previously? Or has it just never worked.
I have never seen this error before.

@eduardomarco Were you able to connect to the system previously? Or has it just never worked?
I have never seen this error before.

With VS code never connect. I am connecting with ACS without problems

@eduardomarco is the SSH daemon running? Are you able to connect with ssh?

@eduardomarco is the SSH daemon running? Are you able to connect with ssh?

I can´t connect.

I have the same problem.


Add the option to export in CSV

if someone is not a developer or not necessary want to use code to work with the data.
I think it would be helpful if an option to work in excel direclty would be awesome.
I know that there is an option to export to google sheet but to avoid login and keep working locally i think it would be a nice feature to export it to either CSV or XLSX

@david1x this is already supported
The excel exporter exports to CSV


Update camera.py

fix deprication warning for SUPPORT_* on camera entities
fixing #492

Thank you!


Add support for navigating with keyboard

This feature is important for integration with KaiOS, a platform that does not have a Spotify client.

hey @mathkruger
can you elaborate on this, do you mean to make the website combability with keyboard shortcuts?
example:  image reference
if yes is it something u currently working or do you want some hand of help :)

Hey!
Well, I was planning this to allow the users to navigate through the app with the arrow keys (like you would do with a tv remote). It's not a very important feature, but it's a cool addition I would like to make.

You mean something like a currently pressing a tab button would do in pc? Or do you mean like the shortcut keys

Well, after thinking more about it, I don't think this is valuable enough for this project. So, I'm closing it.


Add link to Github repo

Used React Icons for add Github Icon
Resolves #11

@steezeburger

@steezeburger any updates?

@vr-varad sorry! I was away camping. I will test this tonight!

@vr-varad I apologize for the delay. I have been very busy with work!

No problem!! Just wanted to ask xan I keep resolving the issue even if u are not present?

@vr-varad the issue shouldn't be resolved till the fix is merged, which requires my approval for now.


Probable excpetion handled in LightNode

An exception was present in LightNode which did not cause any problems, although it's much better to run without any hiccups.

Task linked: CU-860t7evdx drgrserf


Remove trailing whitespaces from .md files in docs

Cleanup .md files by removing all trailing whitespaces.
Maybe this can be enforced in the future by a jenkins build test. ping @jfrazelle as I see her name in all Jenkins builds
Signed-off-by: Ankush Agarwal<EMAIL_ADDRESS>

+kind/writing
+exp/novice

http://daringfireball.net/projects/markdown/syntax

When you do want to insert a
 break tag using Markdown, you end a line with two or more spaces, then type return.

So, sometimes trailing spaces in Markdown are not only appropriate, but syntactically relevant.

(not saying many/any of these are -- just that they can be valid and meaningful, so aren't universally safe to strip)

Ahh. I'll read the syntax and update the patch accordingly avoiding any syntactical errors.

I thoroughly went through the Markdown syntax reference for any potential syntactical uses of trailing spaces other than the
 use case. There was one other place where it could be used, but not really required
You can put the title attribute on the next line and use extra spaces or tabs for padding, which tends to look better with longer URLs

Either way, I did not find either of cases in my patch.
Let me know how I should proceed with this.
Thanks.

Do we have any guidelines for the md files like max column lengths, etc.?

@ankushagarwal In general, 80-chars width is used; some exceptions may apply, e.g. for tables and literal output / code blocks.

Rebased and resolved conflicts.

I spot checked 10+ files and checked for problems introduced by removing these. Didn't find any. LGTM

ping @fredlf @jamtur01 @SvenDowideit @thaJeztah maybe we can get one more LGTM and merge this before the release or it needs a new rebase

After reading comments @thaJeztah, this does not seem like the best idea. This cleans up the doc files a little, but we cannot risk having docs broken at some of the places. I am going to close this, unless someone things otherwise.

@moxiegirl @ankushagarwal  I added some notes; the runmetrics.md probably needs fixing, the http-routingtables.md may need fixing (but didn't know where to find it).
Note that I determined this by looking just at the code, and visually checking with the current site, so I may have missed some. Overall, most trailing whitespace looks unintentional, so safe to remove.

@ankushagarwal yeah, it's a tricky one; I think most are safe. But some need fixing (previous comment). The docs won't completely fall apart because of this, and can always be fixed easily, but yeah.

If some of these will break formatting, then we need to go through and fix them. I'm not sure the benefit is worth that cost, to be honest.

Agreed

@ankushagarwal @fredlf  I actually built the docs and spot checked them as stated.  I also paged through the entire change set.  If they were going to break, I think they would have broken something in at least one of the files which wasn't the case.  100% checking is of course possible but given the relative importance of these changes there is an obvious tradeoff.  If you think it is necessary to check each file, you should do that.   If you are very worried, we should close this out without merging it.

I don't have time to check each file and don't think the benefit realized by this change merits that kind of investment of time and effort. I also don't think the benefit realized by this change outweighs the risk of messing up the formatting of a page. So yes, I think we should close without merging.

Thanks a lot for attempting this, @ankushagarwal, even though it didn't get merged, it's really appreciated. If you ever feel to try this again, smaller chunks may be easier to review/merge and less risky.


Implementing Git Sync for Settings Sync

Hi,
Settings Sync is looking forward to all one feature in future version on its extensions to implement similar git sync like gist sync.
Issue details are available at https://github.com/shanalikhan/code-settings-sync/issues/413
Issue bounty is about 200$ at the moment , which will be transferred once PR is accepted.
Just wanted to post here so you can tag this issue as extension-candidate or feature-request so any of the contributors who are willing to solve can go ahead to implement in my repo.
Thanks!

@isidorn we can keep this open for some time.
What do you suggest?

up to @joaomoreno he owns the git world. I would close it as we usually don't do advertise extensions like this.


Streaming Runelite on Discord sometimes breaks the stream, requiring a full reset of Discord

Describe the bug
When streaming on Discord, something specific happens. The stream will "break" for everyone (infinite loading screen, no display), and when I end the stream, I will be stuck in a constant state of reconnecting to RTC (unable to voice chat with people) until I end backend Discord process tasks and restart it. It is hard to say what reproduces it. I have a hunch it is a higher level setting with window focus behavior or resizing, but I have not been able to narrow it down. It seems very unpredictable, and can happen without any major changes in the higher level state of Runelite, without changing any window focus at all.
This does not happen while streaming any other application on Discord. The only plugin from the hub that I have is the HD plugin, but this bug has been occurring months before it was released. It was also reproducible before the Discord rich presence plugin, but that might still be a relevant plugin to look at.
To Reproduce
Steps to reproduce the behavior:

Join a Discord VC
Stream the Runelite window
Play the game as normal (or particularly mess with some plugin settings that correspond to the window as a whole, as a hunch)
Check the output of the stream by focusing back on Discord
If the stream preview is black, the stream has crashed. If not, continue from Step 3.
(If there is someone else in the call) verify that you are no longer able to speak to them
Verify that Discord cannot RTC connect to voice calls until restarting backend tasks

Expected behavior
An uninterrupted stream that doesn't crash or force me to restart Discord every time it does
Screenshots
None
Environment (please complete the following information):

OS: Windows 10
RuneLite version: 1.7.27
Launcher version: 2.1.0

Additional context
Logs from today (seems like 14:31 was when I restarted Discord)
2021-10-24 12:34:00 [RuneLite] INFO  net.runelite.client.RuneLite - RuneLite 1.7.27 (launcher version 2.1.0) starting up, args: none
2021-10-24 12:34:01 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached vanilla client
2021-10-24 12:34:01 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached patched client
2021-10-24 12:34:01 [Preloader] INFO  net.runelite.client.rs.ClientLoader - client-patch<PHONE_NUMBER>.293
2021-10-24 12:34:01 [RuneLite] INFO  n.r.client.account.SessionManager - No session file exists
2021-10-24 12:34:02 [RuneLite] INFO  n.r.c.plugins.kourendlibrary.Library - Library is now reset
2021-10-24 12:34:02 [RuneLite] INFO  n.r.c.e.ExternalPluginManager - Loading external plugin "117hd" version "1.0.6" commit "803c7136ee133484ee8ca80e16974897def85bb5"
2021-10-24 12:34:03 [RuneLite] INFO  n.r.client.discord.DiscordService - Initializing Discord RPC service.
2021-10-24 12:34:04 [RuneLite] INFO  net.runelite.client.RuneLite - Client initialization took 3704ms. Uptime: 5577ms
2021-10-24 12:34:04 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,0,0,1920x1040,layout=java.awt.BorderLayout,title=RuneLite,maximized,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,1920x1040,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@7c70ce68,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
2021-10-24 12:34:05 [Client] INFO  rs117.hd.HdPlugin - Using device: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2
2021-10-24 12:34:05 [Client] INFO  rs117.hd.HdPlugin - Using driver: 4.6.0 NVIDIA 466.63
2021-10-24 12:34:21 [pool-3-thread-1] INFO  n.r.client.discord.DiscordService - Discord RPC service is ready with user Solis.
2021-10-24 14:31:33 [pool-3-thread-1] INFO  n.r.client.discord.DiscordService - Discord RPC service is ready with user Solis.

Any eyes on this? I see thumbs up.

I haven't personally experienced a Discord crash from this since I don't use Windows. However, I've seen the frozen stream shortly followed by a crashed Discord many times and it seems reasonably consistent. Hopefully this issue will garner some interest.


Multiselect not working for triads to set common Orientation angles

Wanting to manually orient all triads to be used in a prismatic joint (up front, before creating the joint), would be a nice possibility.
However the multiselect feature is not working for the Rot angles.
This is maybe not a bug, as I can't recall if it ever did work or was supposed to.

If this is considered a bug or just a lack of functionality is a matter of definition. But you're right it is not working. Actually, none of the fields in the Orientation tab of Triads, Parts and Joints will update for multi-selected objects. This is because the Origin widget was implemented in a different way than all other property views, and they do not have the multi-select update functionality. Fixing this requires some extra coding therefore labeling this "enhancement".


Added metrics to add timestamp create/update/delete events

Added metrics to set a timestamp for last successful create/update/delete event
Signed-off-by: Natalie Rogers<EMAIL_ADDRESS>What Are We Doing Here
Here is where you should describe the problem you are solving, adding any fine details on the solution that might
otherwise not be recognizable for someone unfamiliar with the changes. Add some pictures if it helps.
How to Verify

Check out this PR
Run Command X, Click Button Y
Profit

@nicolerenee @drush211 @lvaughn Ready for your review.

@nprogers-WPE we need this squashed to a single commit

@lvaughn @nicolerenee Ok, ready again.

@nicolerenee @lvaughn @drush211 Ready for your review.


Sync with master

There were major changes between the version this fork is based off of and master. Any tests done to make sure everything still works? This fork only really exists to add hacky support to Electron, it wasn't mean to be maintained.

I just checked what you changed and that's it.. and still experimenting with my own branch and my own problems.. so feel free to ignore it :)
But since you are here and it worked for you I have a question... Will it be possible to redirect all our console.log that exist in the app to be logged in a file?! or in order to make the use of winston we'll have to update/change our code everywhere?!

I'm only using this fork for a single project, and there's only those few lines changed it may be best to keep your own fork as the changes are so small.
And no, with this fix it'll write both to console and to file. Example here: https://github.com/dustinblackman/Championify/blob/master/src/logger.js


[incubator/kafka] Kafka chart should use vanilla Kafka not confluent

Which chart:
incubator/kafka
What happened:
incubator/kafka uses confluentinc/cp-kafka for its image which is not a standard vanilla kafka install
What you expected to happen:
incubator/kafka should use a Docker image that utilizes https://kafka.apache.org/downloads for its JARs instead of Confluents binaries.
Just look at the tags for confluentinc/cp-kafka, what is 4.1.1. The latest Kafka version is 1.1.0, I don't want to push Confluent kafka 4.1.1, whatever that is.
Anything else we need to know:
incubator/kafka should be renamed to incubator/confluent-kafka and the eventual stable/kafka should be a vanilla Kafka installation with a vanilla ZooKeeper installation.

Confluent added the bug #7730.


Feature: reduce bundle size

Small improvements in bundle size by refactoring to use function components. Further changes would need a switch to hooks (especially useContext()), which would have to come in a major release, since we risk breaking people's usage otherwise.
the UMD bundle goes from -rw-r--r--  1 emilia  staff  32065  6 Jul 18:33 index.js to -rw-r--r--  1 emilia  staff  27327  6 Jul 18:05 index.js, that's more significant than I expected!

Coverage decreased (-0.4%) to 87.649% when pulling 9c7649a4ac906d35245432f3783f8eca56c8b96c on feat/reduce-bundle-size into 5a0b7da9ad3e6f96ece001d837f55585a70ff230 on master.


Add support for proxies.

It would be nice if we supported connecting via proxies, both HTTP/2 and HTTP/1.1.

I have started to look into this.

Awesome! Shout if you run into trouble or want advice, or hop into #python-requests on Freenode, where I spend a lot of time.

On 13 Jun 2015, at 23:49, Fred Thomsen<EMAIL_ADDRESS>wrote:
I have started to look into this.
—
Reply to this email directly or view it on GitHub.

Would a bypass list for a session be worth including into this?

I don't think so. =)
The way this normally works is that for a library at this level you just say "give me a proxy" or "don't give me a proxy". Higher-level libraries like requests worry about more complex function like exclusions

Finally got back around to this after some distractions.  Making a pull request to make sure I am on the right track.


rbenv install 2.0.0-p247 causing errors on openssl-1.0.1e...

I am trying to install the latest 2.0.0-p247 version globally and an error is occurring during the install.
I am running : rbenv install 2.0.0-p247
Here is the terminal output:
Downloading openssl-1.0.1e.tar.gz...
-> http://dqw8nmjcqpjn7.cloudfront.net/66bf6f10f060d561929de96f9dfe5b8c
Installing openssl-1.0.1e...

BUILD FAILED

Inspect or clean up the working tree at /var/folders/rp/lsy865ts38x8m_x2jd5lpy_c0000gn/T/ruby-build.20150107233927.14353
Results logged to /var/folders/rp/lsy865ts38x8m_x2jd5lpy_c0000gn/T/ruby-build.20150107233927.14353.log

Last 10 log lines:
installing man1/ca.1
installing man1/ciphers.1
installing man1/cms.1
cms.pod around line 457: Expected text after =item, not a number
cms.pod around line 461: Expected text after =item, not a number
cms.pod around line 465: Expected text after =item, not a number
cms.pod around line 470: Expected text after =item, not a number
cms.pod around line 474: Expected text after =item, not a number
POD document had syntax errors at /usr/bin/pod2man5.18 line 72.
make: *** [install_docs] Error 255

The log output is fairly similar:
created directory `/Users/stuartmorris/.rbenv/versions/2.0.0-p247/openssl/ssl/man/man7'
installing man1/CA.pl.1
installing man1/asn1parse.1
installing man1/ca.1
installing man1/ciphers.1
installing man1/cms.1
cms.pod around line 457: Expected text after =item, not a number
cms.pod around line 461: Expected text after =item, not a number
cms.pod around line 465: Expected text after =item, not a number
cms.pod around line 470: Expected text after =item, not a number
cms.pod around line 474: Expected text after =item, not a number
POD document had syntax errors at /usr/bin/pod2man5.18 line 72.
make: *** [install_docs] Error 255

Any ideas on what I should do here would be appreciated.
Thanks

Can you upgrade ruby-build and try again?

Can you confirm the steps for this please. I'm not too familiar with ruby
and want to make sure I do it correctly. Thanks
On Thursday, 8 January 2015, Mislav Marohnić<EMAIL_ADDRESS>wrote:

Can you upgrade ruby-build and try again?
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/rbenv/issues/676#issuecomment-69117768.

I thinks this issue is caused by your os environment. Please tell us your os and it's version.

@StuartMorris0: Certainly. The rbenv install command comes from the ruby-build project, which is in a separate repo on GitHub. Please see its wiki documentation for instructions on how to upgrade. Then, rbenv install --version should output something like "ruby-build 20141225".
Then try the install again and paste the output again.

For the record I am on Yosemite 10.10.1
Thanks @mislav for your help. I ruby-build update:
cd "$(rbenv root)"/plugins/ruby-build && git pull
Then run rbenv install again and all working fine. Appreciate the help! Thanks


File contents should not be fetched when opening through h5web

Waiting on https://github.com/jupyterlab/jupyterlab/pull/7596

@loichuder In case you're still waiting, that got merged

https://github.com/jupyterlab/jupyterlab/issues/10757

I am closing this since I am quite happy with the fix of #65.
Using format: null is still a possibility but we may need to filter JupyterLab versions, which is a bit cumbersome.


add Pirate English translation

A bit of fun, taken seriously.
en-pirate is Google's language code for Pirate English.
Translated and tested for authenticity (using translators). I couldn't find a real 1600s pirate to ask whether it made sense, but it does to a native englander. :)

Thank you for adding this @lukeoliff.
I apologise fer takin' so much time t' review and merge this matey . 🖖 ✨

Haha! Thanks @Roshanjossey!


notify_property_list_changed() causes backwards/reversed text entry with String @export var (@export_multiline = OK)

Godot version
4.0 alpha 9
System information
Windows 10
Issue description
Entering text in an @export var String field with notify_property_list_changed() at the end of the setter function causes text to be entered backwards.
The caret moves to the beginning of the string after each typed character.
Steps to reproduce
https://user-images.githubusercontent.com/60025044/172140913-0bc461d8-53c5-4b21-991e-c83a4abadade.mp4
@tool
extends Node

#@export var: OK
#@export var & notify_property_list_changed(): texts gets entered backwards
#@export_multiline = OK

var _text := ""
#@export_multiline var text := "":
@export var text := "":
	get: return _text
	set(__v):
		_text = __v
		notify_property_list_changed()

Minimal reproduction project
Backwards Text Bug.zip

Why are you calling notify_property_list_changed()?
I had some issues in a larger project where stuff wasn't refreshing in the editor, so I just started putting that in all my tool setter funcs out of habit.

I can just take it out, I suppose.

Yeah you should only use this when a list of properties has changed. Unless you are overriding _get_property_list(), you won't need it.

Ok, thanks. Got it.
Will mark as closed.


Websocket communication

This is a very rough demo of using httpuv server in user R session and websockets on vscode side for communication.
If r.session.useWebSocket is enabled, a httpuv server is started in the background of an interactive R session, and vscode-R session watcher will create a WebSocket to connect to the server on attach.
The hover and completion of $ and @ are roughly implemented.
And it works on both local and remote development.
This makes it possible to address #440, #594, #837, #999.
https://user-images.githubusercontent.com/4662568/228568579-e6eedbed-f27d-413a-b302-c8681569842d.mp4

pretty neat! I tried this with an R6 object and it worked nicely. this could also have implications for liveshare requests

Just would like to check whether there is any update and plan to release this implementation. Thanks.

Completion and hover are improved to support recursive $ and @.

Works as expected for
a <- list(
    b = list(
        c = list(
            d = 5L
        )
    )
)

and
x <- setClass("student", slots = list(name = "character", age = "numeric", GPA = "numeric"))

Would it be worth allowing the socket ip address to be set by the user? Currently it's set to <IP_ADDRESS>.
Also, is it possible to use unix domain sockets or windows pipes via httpuv::startPipeServer? I'm not sure if it returns the same messages as the standard socket server function

Would it be worth allowing the socket ip address to be set by the user? Currently it's set to <IP_ADDRESS>.

Is there a use case for setting an ip other than <IP_ADDRESS>? Since the session watcher itself still relies on a local filesystem to work properly, I'm not sure if it is useful to allow a websocket to attach to an IP other than <IP_ADDRESS>.

Also, is it possible to use unix domain sockets or windows pipes via httpuv::startPipeServer? I'm not sure if it returns the same messages as the standard socket server function

The main point of using a httpuv websocket server in user R session and websocket in vscode-R extension here is that it does not block the user session and provides a simple event loop mechanism. I'm not sure if the bare bone socketServer or socketConnection could do the same?
Also, I'm thinking of using the Infinite Row Model to allow for dynamic loading of data frame in the viewer via WebSocket or http socket directly talking to the R session that creates that data viewer.

In 99% of situations, I'd say no, unless for whatever reason only IPv6 is allowed.

Good catch. Didn't think of/meet such scenario before. I'm curious how other R packages that start a web server (e.g. shiny) handle this?

I've used socketConnection in the past, iland haven't run into major issues. Not sure of the major difference between it and httpuv admittedly. I might fiddle with the different socket implementations to see the differences

If there is a good way to handle non-blocking communication between client and server via sockets, I'd be happy to see how we could adjust our implementation.

Sounds like a good idea! I'll have a closer look at the PR tonight.

Thanks, just take your time!
The dynamic loading of data frames will require another PR for certain, as I'm just playing around with the ag-grid api at https://github.com/REditorSupport/vscode-R/compare/master...renkun-ken:vscode-R:websocket-data-viewer but looks like there is more work such as server-side handling of filtering and ordering.

So, I tried using httpuv::startPipeServer, and it appeared to work as expected.
I couldn't find much on IPv6 in R, so it might just be not super important ATM. I tried "localhost" but it looks like httpuv doesn't resolve names so no luck there.

I switch to using just httpuv::startServer() to start a non-blocking http server and use fetch() on extension side. This could make it easier to implement dynamic data loading as we could directly access the R session's http server via resource uri inside the data viewer webview.

Let's merge this as an experimental feature first and see if it works properly under different scenarios.

Sorry for the delay! I think that's a fair idea, we can get more feedback that way. Similar to how we handled rstudioapi and the session watcher