Revamp the docs using minimalistic markdown

The Landing Page
On GitHub the README file of a project serves as its landing page, it is displayed immediately below the directory listing. Currently, the OpenSSL README is a raw text file, which gives a rather dusty impression, compared to all these fancy landing pages you find nowadays on GitHub.
Current Landing Page
This is how our landing page looks currenty.

New Landing Page
Wouldn't it be much nicer if it would look something like that?

For a long time I've dreamed of such a fancy landing page, but it turned out not to be so easily done.
The Problem
My first attempt to replace the simple text README file by a fancy markdown file ended up in a file which was not very well readable anymore in a text editor. This was a serious disadvantage for developers downloading the source tarball and trying to get started.
One possibility to avoid this problem would have been to add a separate markdown version of the README file as .github/README.md, which would have been favoured by GitHub. But having two different README files is not really a good solution. After trying different options for several weeks, the solution to the problem came to my mind.
Minimalistic Markdown
The idea is to have a single README file which does not only look pretty when viewed in the browser, but is also well formatted and easy to read when you view the raw file in your favourite text editor. Wasn't that exactly the goal of the original markdown implementation of John Gruber und Aaron Swartz? So I tried to go back to the roots using minimalistic markdown.
With 'minimalistic' markdown, I don't mean a certain markdown dialect. It's just the fact that I try to add as little markup as possible, which could interfere with the reading flow int the text file.
For example,

avoid ATX headings and use setext headings instead (works for <h1> and <h2> headings only).
avoid inline links and use reference links instead.
avoid fenced code blocks, use indented code blocks instead.

Show Cases
The Landing Page
I changed the default branch of my repository clone mspncp/openssl to the revamp-the-docs branch, so you can view my changes there live in action. The following files have already been heavily revamped or are currently in progress. Please take a look at them and compare their online version with their raw file content.
The README file

View the online version
View the raw file content

The NEWS file

View the online version
View the raw file content

The CHANGES file

View the online version
View the raw file content

The INSTALL file

View the online version
View the raw file content

The SUPPORT file

View the online version
View the raw file content

Your feedback, please!
This work is currently an early draft. So instead of diving into the documents and looking for typos and whitespace errors, I'd rather appreciate if you could give me more high level feedback, for example:

Do you like the direction in which this is going? Shall I continue?
Do you have some general ideas how this could be improved even more?

Looking forward to your comments!

this is way cool.

What about the CHANGES file? Ideally, it should be revamped the same way as the NEWS file.

What about the CHANGES file? Ideally, it should be revamped the same way as the NEWS file.

Sure, I intend to convert all those files to markdown. Since the conversion of the CHANGES file will be very similar to the one of the NEWS file, I did not bother to do it for the preview yet. Most of the other file conversions will be straightforward, too.
The only file which currently gives me headaches is the INSTALL file, because of its table structure for the options. I don't see how I could mimick this in markdown without raw HTML. So I'll have to think of a different way to format the text which looks equallly well in both views.

Apropos NEWS & CHANGES: did you see that I added the entire history back, taking the missing peaces from the stable branches? So in the future the files on 1.1.1 LTS will just be a shortened copy of the ones on master (if we backport the reformatting, which we probably should).
We could utilize this fact to simplify cherry-picking from master to 1.1.1 in the future: thoshe files will always conflict, but we can just run a script which accepts the incoming version from master and drops all entries newer than 1.1.1.

... because of its table structure for the options.

I actually view that as a definition list, which exists as an extended syntax...  one might argue about the readabilty of colon-prefixed lines, though...

_(quoted from https://github.com/openssl/openssl/issues/10546#issuecomment-560091518)

We disagree on the NOTES files. I think they should have the same visibility as README and INSTALL. You think of it in terms of web pages, I think of it in terms of a top directory listing.

If you see it like that, it's ok for me. Maybe a good compromise would be to have a single NOTES file with a Table of Contents?

Maybe a good compromise would be to have a single NOTES file with a Table of Contents?

So the user will have to scroll past lots of text to get to their specific pet peeve?

... because of its table structure for the options.

I actually view that as a definition list, which exists as an extended syntax... one might argue about the readabilty of colon-prefixed lines, though...

Thanks for the link to markdownguide.org, which was new to me. I'll take a look at it. I am familiar with simple tables, but tables containing paragraphs and other items like fenced code blocks are a completely different matter. They will always look ugly in raw text.

Note: I reverted the NOTES.* changes and started reformatting the CHANGES file.

Started working on the INSTALL file:

View the online version
View the raw file content

Just autosquashed some commits without changing anything.

The INSTALL file
The latest update contains some initial work on the INSTALL file. In particular the Configuration Options section gave me a hard time, because the original two column layout of the text file is not reproducible in markdown. I tried to find a reasonable compromise which looks acceptable in both versions.
As usual, you need to look at both versions:

View the online version
View the raw file content

Note: rebasing this pull request to fix conflicts is practically infeasible because of all the whitespace changes. Since the changes on master are negligible compared to those on my branch,  I will incorporate the changes from master manually in the end.

Note: rebasing this pull request to fix conflicts is practically infeasible because of all the whitespace changes. Since the changes on master are negligible compared to those on my branch, I will incorporate the changes from master manually in the end.

After having sufficient sleep, rebasing was not that infeasible anymore. The trick is to manually compare stage 1 (BASE) of the conflicting file with stage 2 (OURS: master) and then integrate those changes manually into stage 3 (THEIRS: revamp-the-docs). Here is what I did for CHANGES.md:
git diff :1:CHANGES.md :2:CHANGES.md > CHANGES.diff
git reset --theirs CHANGES.md
<integrate CHANGES.diff manually>
git add CHANGES.md
git rebase --continue

I actually view that as a definition list, which exists as an extended syntax... one might argue about the readabilty of colon-prefixed lines, though...

Unfortunately GitHub Flavoured Markdown does not support definition lists.

As usual, you need to look at both versions:

I think this is looking really nice. It seems to work in both formats.

As usual, you need to look at both versions:

I think this is looking really nice. It seems to work in both formats.

Thank you very much, Matt. I think that, except for the SUPPORT file, all files have already matured so far that an initial review would be possible. There are some more files which I didn't start on yet, but maybe it's better to keep them for a followup pr.
That's why I'll change the prefix from [PREVIEW] to [WIP].

Split and reorganized commit fee94bd444b70a994fdca866b0b513db0560ea81 without further changes.

Apart from the need to update the formating of CHANGES, I think this would be already huge improvement worth merging. IMO the .md files are readable even as pure text files without the formatter so it should be no problem to merge the PR.

I intended to do some cleanup and remove the WIP this weekend, but I got a little bit distracted by the krb5 fix. The only file I'm not happy yet with is the SUPPORT file. So maybe I'll just leave that for a later pull request and finish this one up as soon as possible.

Apart from the need to update the formating of CHANGES, I think this would be already huge improvement worth merging. IMO the .md files are readable even as pure text files without the formatter so it should be no problem to merge the PR.

One question which we should discuss in the @openssl/otc is whether we replace the NEWS and CHANGES files with the new markdown versions (without the master additions) in order to ease backporting entries to the 1.1.1 stable branch.
Apart from that, I went through the effort to add all NEWS and CHANGES entries from the stable branches all the way back to version 1.0.0 into the master branch and I would strongly encourage that in the future we always add entries for the stable branches also to the master branch. So effectively, if a feature is added in master and backported to 1.1.1, it will get two entries on master accordingly.

The last force-push was a pure cleanup of commit history (splitting multi-file fixups and squashing fixups with the corresponding fix) without any tree changes.

Next step is to manually integrate and reformat the the current additions to master:
$ git diff revamp-the-docs...master -- CHANGES NEWS

diff --git a/CHANGES b/CHANGES
index e0dc0e2611..b002df633c 100644
--- a/CHANGES
+++ b/CHANGES
@@ -9,6 +9,107 @@

  Changes between 1.1.1 and 3.0.0 [xx XXX xxxx]

+  *) Deprecated EVP_PKEY_decrypt_old(), please use EVP_PKEY_decrypt_init()
+     and EVP_PKEY_decrypt() instead.
+     Deprecated EVP_PKEY_encrypt_old(), please use EVP_PKEY_encrypt_init()
+     and EVP_PKEY_encrypt() instead.
+     [Richard Levitte]
+
+  *) Enhanced the documentation of EVP_PKEY_size(), EVP_PKEY_bits()
+     and EVP_PKEY_security_bits().  Especially EVP_PKEY_size() needed
+     a new formulation to include all the things it can be used for,
+     as well as words of caution.
+     [Richard Levitte]
+
+  *) The SSL_CTX_set_tlsext_ticket_key_cb(3) function has been deprecated.
+     Instead used the new SSL_CTX_set_tlsext_ticket_key_evp_cb(3) function.
+     [Paul Dale]
+
+  *) All of the low level HMAC functions have been deprecated including:
+     HMAC, HMAC_size, HMAC_CTX_new, HMAC_CTX_reset, HMAC_CTX_free,
+     HMAC_Init_ex, HMAC_Update, HMAC_Final, HMAC_CTX_copy, HMAC_CTX_set_flags
+     and HMAC_CTX_get_md.
+     Use of these low level functions has been informally discouraged for a long
+     time.  Instead applications should use L<EVP_MAC_CTX_new(3)>,
+     L<EVP_MAC_CTX_free(3)>, L<EVP_MAC_init(3)>, L<EVP_MAC_update(3)>
+     and L<EVP_MAC_final(3)>.
+     [Paul Dale]
+
+  *) All of the low level CMAC functions have been deprecated including:
+     CMAC_CTX_new, CMAC_CTX_cleanup, CMAC_CTX_free, CMAC_CTX_get0_cipher_ctx,
+     CMAC_CTX_copy, CMAC_Init, CMAC_Update, CMAC_Final and CMAC_resume.
+     Use of these low level functions has been informally discouraged for a long
+     time.  Instead applications should use L<EVP_MAC_CTX_new(3)>,
+     L<EVP_MAC_CTX_free(3)>, L<EVP_MAC_init(3)>, L<EVP_MAC_update(3)>
+     and L<EVP_MAC_final(3)>.
+     [Paul Dale]
+
+  *) All of the low level MD2, MD4, MD5, MDC2, RIPEMD160, SHA1, SHA224, SHA256,
+     SHA384, SHA512 and Whirlpool digest functions have been deprecated.
+     These include:
+         MD2, MD2_options, MD2_Init, MD2_Update, MD2_Final, MD4, MD4_Init,
+         MD4_Update, MD4_Final, MD4_Transform, MD5, MD5_Init, MD5_Update,
+         MD5_Final, MD5_Transform, MDC2, MDC2_Init, MDC2_Update, MDC2_Final,
+         RIPEMD160, RIPEMD160_Init, RIPEMD160_Update, RIPEMD160_Final,
+         RIPEMD160_Transform, SHA1_Init, SHA1_Update, SHA1_Final,
+         SHA1_Transform, SHA224_Init, SHA224_Update, SHA224_Final,
+         SHA224_Transform, SHA256_Init, SHA256_Update, SHA256_Final,
+         SHA256_Transform, SHA384, SHA384_Init, SHA384_Update, SHA384_Final,
+         SHA512, SHA512_Init, SHA512_Update, SHA512_Final, SHA512_Transform,
+         WHIRLPOOL, WHIRLPOOL_Init, WHIRLPOOL_Update, WHIRLPOOL_BitUpdate
+         and WHIRLPOOL_Final.
+
+     Use of these low level functions has been informally discouraged for a long
+     time.  Instead applications should instead use the EVP_DigestInit_ex,
+     EVP_DigestUpdate(3) and EVP_DigestFinal_ex(3) functions.
+     [Paul Dale]
+
+  *) Corrected the documentation of the return values from the EVP_DigestSign*
+     set of functions.  The documentation mentioned negative values for some
+     errors, but this was never the case, so the mention of negative values
+     was removed.
+
+     Code that followed the documentation and thereby check with something
+     like 'EVP_DigestSignInit(...) <= 0' will continue to work undisturbed.
+     [Richard Levitte]
+
+  *) All of the low level cipher functions have been deprecated including:
+     AES_options, AES_set_encrypt_key, AES_set_decrypt_key, AES_encrypt,
+     AES_decrypt, AES_ecb_encrypt, AES_cbc_encrypt, AES_cfb128_encrypt,
+     AES_cfb1_encrypt, AES_cfb8_encrypt, AES_ofb128_encrypt,
+     AES_wrap_key, AES_unwrap_key, BF_set_key, BF_encrypt, BF_decrypt,
+     BF_ecb_encrypt, BF_cbc_encrypt, BF_cfb64_encrypt, BF_ofb64_encrypt,
+     BF_options, Camellia_set_key, Camellia_encrypt, Camellia_decrypt,
+     Camellia_ecb_encrypt, Camellia_cbc_encrypt, Camellia_cfb128_encrypt,
+     Camellia_cfb1_encrypt, Camellia_cfb8_encrypt, Camellia_ofb128_encrypt,
+     Camellia_ctr128_encrypt, CAST_set_key, CAST_encrypt, CAST_decrypt,
+     CAST_ecb_encrypt, CAST_cbc_encrypt, CAST_cfb64_encrypt,
+     CAST_ofb64_encrypt, DES_options, DES_encrypt1, DES_encrypt2,
+     DES_encrypt3, DES_decrypt3, DES_cbc_encrypt, DES_ncbc_encrypt,
+     DES_pcbc_encrypt, DES_xcbc_encrypt, DES_cfb_encrypt, DES_cfb64_encrypt,
+     DES_ecb_encrypt, DES_ofb_encrypt, DES_ofb64_encrypt, DES_random_key,
+     DES_set_odd_parity, DES_check_key_parity, DES_is_weak_key, DES_set_key,
+     DES_key_sched, DES_set_key_checked, DES_set_key_unchecked,
+     DES_string_to_key, DES_string_to_2keys, DES_fixup_key_parity,
+     DES_ecb2_encrypt, DES_ede2_cbc_encrypt, DES_ede2_cfb64_encrypt,
+     DES_ede2_ofb64_encrypt, DES_ecb3_encrypt, DES_ede3_cbc_encrypt,
+     DES_ede3_cfb64_encrypt, DES_ede3_cfb_encrypt, DES_ede3_ofb64_encrypt,
+     DES_cbc_cksum, DES_quad_cksum, IDEA_encrypt, IDEA_options,
+     IDEA_ecb_encrypt, IDEA_set_encrypt_key, IDEA_set_decrypt_key,
+     IDEA_cbc_encrypt, IDEA_cfb64_encrypt, IDEA_ofb64_encrypt, RC2_set_key,
+     RC2_encrypt, RC2_decrypt, RC2_ecb_encrypt, RC2_cbc_encrypt,
+     RC2_cfb64_encrypt, RC2_ofb64_encrypt, RC4, RC4_options, RC4_set_key,
+     RC5_32_set_key, RC5_32_encrypt, RC5_32_decrypt, RC5_32_ecb_encrypt,
+     RC5_32_cbc_encrypt, RC5_32_cfb64_encrypt, RC5_32_ofb64_encrypt,
+     SEED_set_key, SEED_encrypt, SEED_decrypt, SEED_ecb_encrypt,
+     SEED_cbc_encrypt, SEED_cfb128_encrypt and SEED_ofb128_encrypt.
+
+     Use of these low level functions has been informally discouraged for a long
+     time. Instead applications should use the high level EVP APIs, e.g.
+     EVP_EncryptInit_ex, EVP_EncryptUpdate, EVP_EncryptFinal_ex, and the
+     equivalently named decrypt functions.
+     [Matt Caswell and Paul Dale]
+
   *) Removed include/openssl/opensslconf.h.in and replaced it with
      include/openssl/configuration.h.in, which differs in not including
      <openssl/macros.h>.  A short header include/openssl/opensslconf.h
diff --git a/NEWS b/NEWS
index 3929894f58..de439d6bb1 100644
--- a/NEWS
+++ b/NEWS
@@ -25,6 +25,11 @@
       o Removed the heartbeat message in DTLS feature.
       o Added EVP_KDF, an EVP layer KDF API, and a generic EVP_PKEY to EVP_KDF
         bridge.
+      o All of the low level MD2, MD4, MD5, MDC2, RIPEMD160, SHA1, SHA224,
+        SHA256, SHA384, SHA512 and Whirlpool digest functions have been
+        deprecated.
+      o All of the low level AES, Blowfish, Camellia, CAST, DES, IDEA, RC2,
+        RC4, RC5 and SEED cipher functions have been deprecated.

   Major changes between OpenSSL 1.1.1 and OpenSSL 1.1.1a [20 Nov 2018]

The additions on master were discarded during rebase and readded at the end of fixup, which was simpler than resolving all conflicts caused by the reformatting.
354fe8eaf4 fixup! doc: add missing CHANGES entries for all versions >= 1.0.0
06f373a173 fixup! doc: add missing NEWS entries for all versions >= 1.0.0

I just autoquashed all fixups without changing anything else before continuing...

Rebase to the tip of master.
Fresh additions to NEWS.md and CHANGES.md on master were discarded and manually readded in the following two commits, as I did the last time. Solving the whitespace merge conflicts would not have been feasible.
commit 46ca78474b4161575ec378f3fd3deef00c157dd5 (HEAD -> revamp-the-docs)
Author: Dr. Matthias St. Pierre<EMAIL_ADDRESS>Date:   Tue Feb 25 13:20:10 2020 +0100
fixup! doc: add missing NEWS entries for all versions >= 1.0.0

commit cfd706689bd8f4fbb9c29f5cd7d5c655b2f9c52b
Author: Dr. Matthias St. Pierre<EMAIL_ADDRESS>Date:   Tue Feb 25 13:19:46 2020 +0100
fixup! doc: add missing CHANGES entries for all versions >= 1.0.0

Apart from the need to update the formating of CHANGES, I think this would be already huge improvement worth merging. IMO the .md files are readable even as pure text files without the formatter so it should be no problem to merge the PR.

@t8m I had little time recently to do progress on the INSTALL file and I agree that this pull request should go in now, in particular since it's getting more and more tedious to merge all the frequent updates to the CHANGES and NEWS entries. Could you please do a last final review? It's easier to continue with little steps once this big pull request is merged.
Only the following commits contain changes:
commit cbd4804467961f04e2d618f95260752c0628bb87 (HEAD -> revamp-the-docs)
Author: Dr. Matthias St. Pierre<EMAIL_ADDRESS>Date:   Tue Feb 25 13:20:10 2020 +0100
fixup! doc: add missing NEWS entries for all versions >= 1.0.0

commit 65cddf3d3e3aa9403cbc4368dd4fa90c6a599b00
Author: Dr. Matthias St. Pierre<EMAIL_ADDRESS>Date:   Tue Feb 25 13:19:46 2020 +0100
fixup! doc: add missing CHANGES entries for all versions >= 1.0.0

commit f70dea6b8d8e21ed01ca4fb14642333baaeaab15
Author: Dr. Matthias St. Pierre<EMAIL_ADDRESS>Date:   Tue Feb 25 12:47:23 2020 +0100
fixup! doc: add missing CHANGES entries for all versions >= 1.0.0

This one here had only its commit message changed:
commit 82a8257891d0ec65c8f37d9561776e177200f1d7
Author: Dr. Matthias St. Pierre<EMAIL_ADDRESS>Date:   Fri Nov 29 19:45:56 2019 +0100
doc: revamp the SUPPORT file

Too be continued...

Just as a reminder: here are the links to view the documents 'live':
The README file

View the online version
View the raw file content

The NEWS file

View the online version
View the raw file content

The CHANGES file

View the online version
View the raw file content

The INSTALL file

View the online version
View the raw file content

The SUPPORT file

View the online version
View the raw file content

Great work!

Thank you! Your remakr mad me realize that I forgot to add an important detail: 36927d588f621047c2c24dcb6dcc01ca7013a959, please take a last look.  :-)
(Note that I capitalized 'Markdown' in the CHANGES entry. I'll do the same in the commit messages when merging.)

Still approved. @openssl/committers  please speak up if you have any objections.

Done. Thanks for the feedback!
c50604eb4a doc: add a fancy CHANGES entry to celebrate the new Markdown format
be0c6a3692 doc: revamp the SUPPORT file
6ede7d73fa doc: revamp the INSTALL file
44652c1637 doc: add missing CHANGES entries for all versions >= 1.0.0
4477beacc4 doc: add missing NEWS entries for all versions >= 1.0.0
dac5138e13 doc: revamp the README file
569b74a36b doc: add OpenSSL logo
5f8e6c50bd doc: introduce some minimalistic markdown without essential changes
2e07506a12 doc: convert standard project docs to markdown


Missing string header is an error under gcc-10.1.0

This hotfix is a backport of ecmwf/atlas # 51.  This is necessary for gcc-10 support as the missing header is an error.
Notes:

Hopefully this is more inline with how we want to handle these types of upstream PRs?
What is the difference with release-stable and develop-jcsda?
For the upstream PR I cannot add it to any epic or milestone because it is actually a PR to ecmwf/atlas.  One advantage of having a second local hotfix PR is that it will give a mechanism to track external contributions within the jcsda repo zenhub system.

Yes, I think this is the way to do it, at least for now.   Even better would be to not do a jcsda PR at all.  Just do an upstream PR and use the feature branch until it is merged and transmitted to our develop via the upstream sync.  I expect something like this would be merged upstream quickly.  But, if it's urgent and straightforward (minimizing the risk of conflicts with the eventual solution), then we can do a hotfix to release-stable.
develop-jcsda can eventually be deleted but I think @ytremolet had some changes there that need to be merged before we delete it.


Adding tenets to CONTRIBUTING.md

Description
Taking over from #2593 from @shanilpa, adding starting tenets to our CONTRIBUTIN.md file.
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2762 (095f486) into main (9d758f9) will increase coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff              @@
##               main    #2762      +/-   ##
============================================
+ Coverage     61.36%   61.39%   +0.02%
- Complexity     3413     3415       +2
============================================
  Files           272      272
  Lines         18850    18850
  Branches       3296     3296
============================================
+ Hits          11568    11573       +5
+ Misses         5684     5681       -3
+ Partials       1598     1596       -2

see 3 files with indirect coverage changes


chore: Updating link component props

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Add a TL;DR when description is extra long (helps content team)
Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

PR fixes following issue(s)
Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview skip-tests=true

/ok-to-test

/build-deploy-preview skip-tests=true

Issues in this PR:

Clicking on the Theme selector bak link opens up a new tab

https://github.com/appsmithorg/appsmith/assets/39921438/2ed7b6b6-bc29-4ccb-b41e-803b9a43b48c

Configure email service link redirects to the wrong page.

https://github.com/appsmithorg/appsmith/assets/39921438/c2e1df3e-68f3-4451-8daf-51edde4ed21a

/build-deploy-preview skip-tests=true

/ok-to-test

Both the reported issues have been fixed.
This PR is good to go.

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test


Unable to build examples (Python 3.8)

See original issue on GitLab
In GitLab by [Gitlab user @albfan] on Dec 11, 2019, 19:33
Summary
Cannot build examples
Steps to reproduce
Using pip stable release:
$ bst --version
1.4.1
$ cd doc/examples/flatpak-autotools
$ bst build hello.bst
[--:--:--][][] STATUS  Cache usage recomputed: 125.2M / infinity (0%)
[--:--:--][][] START   Build
[--:--:--][][] START   Loading elements
[00:00:00][][] SUCCESS Loading elements
[--:--:--][][] START   Resolving elements
[00:00:00][][] SUCCESS Resolving elements
[--:--:--][][] START   Resolving cached state
[00:00:00][][] SUCCESS Resolving cached state
[--:--:--][][] START   Checking sources
[00:00:00][][] SUCCESS Checking sources

BuildStream Version 1.4.1
  Session Start: Wednesday, 11-12-2019 at 19:15:17
  Project:       flatpak-autotools (/home/alberto/projects/python/buildstream/doc/examples/flatpak-autotools)
  Targets:       hello.bst
  Cache Usage:   125.2M / infinity (0%)

User Configuration
  Configuration File:      /home/alberto/.config/buildstream.conf
  Log Files:               /home/alberto/.cache/buildstream/logs
  Source Mirrors:          /home/alberto/.cache/buildstream/sources
  Build Area:              /home/alberto/.cache/buildstream/build
  Artifact Cache:          /home/alberto/.cache/buildstream/artifacts
  Strict Build Plan:       Yes
  Maximum Fetch Tasks:     10
  Maximum Build Tasks:     2
  Maximum Push Tasks:      4
  Maximum Network Retries: 2

Project Options
  arch: x86_64

Pipeline
fetch needed 1fb677ea63be533ff4391db8c764030a80500c8f1feba0959eb747f720fd3748 base/sdk.bst
     waiting 6fbcd70444b9b3bb74e48bf930fd93a0715e854bfe370c4a43b7e9d2d81caee7 base/usrmerge.bst
     waiting 60ef22ffacf88b1fb99d3bf72752456b55c83ec86672310bcf7917f55ed7d485 base.bst
     waiting 8c609e7d39e81c68c2f8162a19440d8a947f1b95535dfb18d43b7fbef611866f hello.bst
===============================================================================
[--:--:--][][] BUG     no running event loop

    Traceback (most recent call last):
      File "/usr/bin/bst", line 8, in <module>
        sys.exit(cli())
      File "/usr/lib/python3.8/site-packages/click/core.py", line 764, in __call__
        return self.main(*args, **kwargs)
      File "/usr/lib/python3.8/site-packages/buildstream/_frontend/cli.py", line 173, in override_main
        original_main(self, args=args, prog_name=prog_name, complete_var=None,
      File "/usr/lib/python3.8/site-packages/click/core.py", line 717, in main
        rv = self.invoke(ctx)
      File "/usr/lib/python3.8/site-packages/click/core.py", line 1137, in invoke
        return _process_result(sub_ctx.command.invoke(sub_ctx))
      File "/usr/lib/python3.8/site-packages/click/core.py", line 956, in invoke
        return ctx.invoke(self.callback, **ctx.params)
      File "/usr/lib/python3.8/site-packages/click/core.py", line 555, in invoke
        return callback(*args, **kwargs)
      File "/usr/lib/python3.8/site-packages/click/decorators.py", line 27, in new_func
        return f(get_current_context().obj, *args, **kwargs)
      File "/usr/lib/python3.8/site-packages/buildstream/_frontend/cli.py", line 340, in build
        app.stream.build(elements,
      File "/usr/lib/python3.8/site-packages/buildstream/_stream.py", line 211, in build
        self._run()
      File "/usr/lib/python3.8/site-packages/buildstream/_stream.py", line 1022, in _run
        _, status = self._scheduler.run(self.queues)
      File "/usr/lib/python3.8/site-packages/buildstream/_scheduler/scheduler.py", line 153, in run
        self._sched()
      File "/usr/lib/python3.8/site-packages/buildstream/_scheduler/scheduler.py", line 427, in _sched
        self._sched_queue_jobs()
      File "/usr/lib/python3.8/site-packages/buildstream/_scheduler/scheduler.py", line 401, in _sched_queue_jobs
        self._spawn_job(job)
      File "/usr/lib/python3.8/site-packages/buildstream/_scheduler/scheduler.py", line 281, in _spawn_job
        job.spawn()
      File "/usr/lib/python3.8/site-packages/buildstream/_scheduler/jobs/job.py", line 162, in spawn
        self._watcher.add_child_handler(self._process.pid, self._parent_child_completed)
      File "/usr/lib/python3.8/asyncio/unix_events.py", line 1286, in add_child_handler
        loop = events.get_running_loop()
    RuntimeError: no running event loop

Trying with master:
$ cd buildstream
$ sudo pip3 install -e .
$ bst --version
1.91.2+286.ga8fb5cd7

cd doc/examples/autotools
$ bst build hello.bst

Error loading user configuration: /home/alberto/projects/python/buildstream/src/buildstream/data/userconfig.yaml: Severely malformed YAML:

'NoneType' object is not callable

What is the current bug behavior?
build fails on 1.4.1 and master
What is the expected correct behavior?
be able to build examples
Relevant logs and/or screenshots
Anything else is needed?
Possible fixes
Other relevant information

BuildStream version affected: /milestone %BuildStream_v1.4

In GitLab by [Gitlab user @jjardon] on Dec 12, 2019, 02:30
[Gitlab user @albfan] are the examples working with bst-1.4 when using the bst-1 branch?

In GitLab by [Gitlab user @juergbi] on Dec 12, 2019, 05:24
There is an incompatibility with Python 3.8 that we're looking into. Related issue: #1173

In GitLab by [Gitlab user @juergbi] on Dec 12, 2019, 05:24
changed title from Unable to build examples to Unable to build examples{+ (Python 3.8)+}

In GitLab by [Gitlab user @albfan] on Dec 12, 2019, 07:29
[Gitlab user @jjardon] I checkout origin/bst-1 and results are the same as for tag 1.4.1
[Gitlab user @juergbi] I forget to add that info:
$ python --version
Python 3.8.0

So yes, maybe this is related with python 3.8. I went through #1173, related issues and MR but didn't find what I can cherry-pick to make bst to work with python 3.8 (building from source), any tips?
I tried with a virtualenv using a local python 3.7.5 and results for bst build hello.bst are the same. Not sure if there's anything else needed in Buildstream to work from virtualenv.
If there's anything I can provide feedback, just let me know.
I'm just revisiting my main use case for buildstream: Trying to build a vala project based on flatpak Elementary SDK, and a C project dependency, to work at same time in vala project and C project.

In GitLab by [Gitlab user @BenjaminSchubert] on Dec 12, 2019, 16:35
[Gitlab user @albfan]
For python3.8: https://gitlab.com/BuildStream/buildstream/commit/e188b16d7979f75823200c5104b3a5fa952fc50c#65c9089123965199008f5d09bc3e5d13b56777dd_174_174 the changes in this file should be able to fix the immediate problem.
Please note that this still has some problems, but they seem to be related to how we run tests with coverage.

I tried with a virtualenv using a local python 3.7.5 and results for bst build hello.bst are the same. Not sure if there's anything else needed in Buildstream to work from virtualenv.

There is nothing needed to work in virtualenvs for BuildStream, we've been using it extensively.
Could you post the output of which bst and echo $VIRTUAL_ENV ?

In GitLab by [Gitlab user @albfan] on Dec 12, 2019, 17:15
[Gitlab user @BenjaminSchubert] About virtualenv: I tried again and now it's working for autotools example.
For flatpak-autotools:
$ bst build hello.bst
[--:--:--][][] START   Build
[--:--:--][][] START   Loading elements
[00:00:00][][] SUCCESS Loading elements
[--:--:--][][] START   Resolving elements
[00:00:00][][] SUCCESS Resolving elements
[--:--:--][][] START   Resolving cached state
[00:00:00][][] SUCCESS Resolving cached state
[--:--:--][][] START   Checking sources
[00:00:00][][] SUCCESS Checking sources

BuildStream Version 1.4.1
  Session Start: Thursday, 12-12-2019 at 18:14:10
  Project:       flatpak-autotools (/home/alberto/projects/python/buildstream/doc/examples/flatpak-autotools)
  Targets:       hello.bst
  Cache Usage:   125.3M / infinity (0%)

User Configuration
  Configuration File:      /home/alberto/.config/buildstream.conf
  Log Files:               /home/alberto/.cache/buildstream/logs
  Source Mirrors:          /home/alberto/.cache/buildstream/sources
  Build Area:              /home/alberto/.cache/buildstream/build
  Artifact Cache:          /home/alberto/.cache/buildstream/artifacts
  Strict Build Plan:       Yes
  Maximum Fetch Tasks:     10
  Maximum Build Tasks:     2
  Maximum Push Tasks:      4
  Maximum Network Retries: 2

Project Options
  arch: x86_64

Pipeline
fetch needed 6afb679221210681d694cb1e2a160460e4e739df836f5648216329b539909115 base/sdk.bst
     waiting d07b99cd5e1dec6b89ac0218d1cec80a7cdfae507caf0c55194143a39fda7814 base/usrmerge.bst
     waiting 339e2946759cc32b3545273ab9e62d810fe89a48a825247c0c141a7d3d63bc20 base.bst
     waiting 6284d7c804cd409ee9596bf568b4b39dd263681b96c6e4e9a44fd35b3174c1ea hello.bst
===============================================================================
[--:--:--][6afb6792][fetch:base/sdk.bst                  ] START   flatpak-autotools/base-sdk/6afb6792-fetch.197125.log
[00:00:00][6afb6792][fetch:base/sdk.bst                  ] BUG     Fetch

    An unhandled exception occured:

    Traceback (most recent call last):
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/_scheduler/jobs/job.py", line 413, in _child_action
        result = self.child_process()
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/_scheduler/jobs/elementjob.py", line 94, in child_process
        return self._action_cb(self._element)
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/_scheduler/queues/fetchqueue.py", line 46, in process
        source._fetch(previous_sources)
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/source.py", line 695, in _fetch
        self.__do_fetch()
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/source.py", line 1014, in __do_fetch
        self.fetch(**kwargs)
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/plugins/sources/ostree.py", line 126, in fetch
        remote_name = self.ensure_remote(self.url)
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/plugins/sources/ostree.py", line 194, in ensure_remote
        _ostree.configure_remote(self.repo, remote_name, url, key_url=gpg_key)
      File "/home/alberto/projects/python/buildstream/virtualenv/buildstream-ve/lib/python3.7/site-packages/buildstream/_ostree.py", line 274, in configure_remote
        repo.remote_gpg_import(remote, stream, None, 0, None)
    TypeError: OSTree.Repo.remote_gpg_import() takes exactly 5 arguments (6 given)

Not sure what should be the correct ostree version here.
I will try with patch too to see if I can send feedback.

In GitLab by [Gitlab user @BenjaminSchubert] on Dec 12, 2019, 17:35
That problem's https://gitlab.com/BuildStream/buildstream/issues/1164. Lets move this part of the discussion there if needed :)

In GitLab by [Gitlab user @albfan] on Dec 12, 2019, 22:04
Thanks for guiding. I can cherry-pick here and there.
Let's close this and contribute where is needed.
Thanks again.

In GitLab by [Gitlab user @albfan] on Dec 12, 2019, 22:04
closed


Update to v2.61.0 of Zitadel API and a few rebuild script fixes.

Since the last release of this project a lot of new protos have been added to the zitadel project. The previous rebuild script used to generate the Elixir SDK in this project relied on the proto structure being flat and all in one directory.
This change introduces a few changes to bin/rebuild.sh that are needed to compile the protos to Elixir:

Use a temp directory paired with git sparse checkout to download proto files in the download_proto_files function (the previous approach would have been more complicated to implement recursively)
Set ERL_AFLAGS environment variable to set standard io_encoding to latin1 to fix apparent regression introduced in Erlang 26 that prevented several of the protos from being compiled without the fix

A few changes were also made to make the rebuild script easier to maintain:

Move to bash to use pushd/popd
Separate utility functions into a separate file
Rename download_files to download_proto_files

I did not bump the version of this package in mix.exs in favor of letting you determine versioning strategy.
That said, what do you think about using the associated Zitadel version instead of having a separate version for the SDK? In this case it would be 2.61.0. This would probably make it easier for consumers of the Elixir SDK to pick the right version and reason about what protos were used to generate it.

I just realized I'll need to fix the workaround I mentioned that was stopping protoc-gen-elixir from working with the latest version of Elixir and Erlang. The fix stops it from working on versions currently pinned in .tool-versions.  That issue should probably be fixed in elixir-protobuf/protobuf.


chore: disable lake 116 test.

The test is flaky, and thus we disable it to improve CI reliability. Ping @tydeu

Where is the evidence for flakiness? Didn't it fail every single time on your PR on Linux Release after a certain point?

Writing down for future documentation: The test passes upon increasing the timeout at #2358 (https://github.com/leanprover/lean4/pull/2340#issuecomment-1653538059). @Kha , would you rather I increase the timeout (to 30s? 10s?) rather than disable the test altogether?

@Kha Regarding https://github.com/leanprover/lean4/issues/2340#issuecomment-1653998617, since my https://github.com/leanprover/lean4/pull/2337#discussion_r1268011791 I have remembered why a shutdown notification was insufficient. The reason this has a timeout is that it wants to wait until the build completes to test that the it prints the proper error. Without a timeout, the process will be killed immediately and the build will not complete, preventing the proper output from being produced. Thus, to avoid a timeout, the test needs some way to tell the server to die only after the build completes.

I see, we use Ipc.collectDiagnostics for that in the server tests

@bollu I vote for (1): Just do the bump,

After some more consideration, I am not at all comfortable with having an arbitrary timeout in our test suite. The offending part of the test should be disabled pending a rewrite using Ipc.

@Kha In that case, we should probably just disable the test completely like this PR originally did. The test doesn't do anything else.

@Kha Oh, honestly, I forgot about that part. However, I do not think worth keeping the test enabled. Without the test to check that serve actually properly sets the environment variable, testing the environment variable itself is minimally useful. Furthermore, commenting it out would just make it more annoying to test manually as it would require uncommenting during and then re-commenting for commit.

@Kha I've reverted the patch back to its original behavior of disabling 116.


Calico does not exist on Network modes section in Intro to Windows support in Kubernetes

Calico is not listed on network modes.
Is there any reason?

(k8s)network modes
Calico for Windows
Calico for Windows goes open source September 22, 2020

Hi @sakaia
Can you confirm the page you're discussing and which section you're focusing this issue report on?
If what's documented there won't work without 3rd party software (such as Calico), we can track a defect to document what you need to make things work.
/triage needs-information

Thank you for your comments.
I understand the document description area.


🐛 noLabelWithoutControl false positives when labels are expressions

Environment information
CLI:
  Version:                      1.9.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v22.7.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.3.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?
https://biomejs.dev/playground/?code=YwBvAG4AcwB0ACAAbABhAGIAZQBsACAAPQAgACIAVABoAGkAcwAgAGkAcwAgAG4AbwB0ACAAbwBrAGEAeQAiADsACgAKADwAPgAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAbwBuAGUAIgAgAC8APgAKACAAIAB7AC8AKgAgAFUAbgBkAGUAcgBzAHQAYQBuAGQAYQBiAGwAeQAgAG4AbwB0ACAAbwBrAGEAeQAgACoALwB9AAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAbwBuAGUAIgA%2BADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAdAB3AG8AIgAgAC8APgAKACAAIAA8AGwAYQBiAGUAbAAgAGgAdABtAGwARgBvAHIAPQAiAHQAdwBvACIAPgBUAGgAaQBzACAAaQBzACAAbwBrAGEAeQA8AC8AbABhAGIAZQBsAD4ACgAgACAACgAgACAAPABpAG4AcAB1AHQAIABpAGQAPQAiAHQAaAByAGUAZQAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAdABoAHIAZQBlACIAPgB7AGwAYQBiAGUAbAB9ADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAZgBvAHUAcgAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAZgBvAHUAcgAiAD4AewAnAEEAcABwAGEAcgBlAG4AdABsAHkAIAB0AGgAaQBzACAAaQBzACAAYQBsAHMAbwAgAG4AbwB0ACAAbwBrAGEAeQAnAH0APAAvAGwAYQBiAGUAbAA%2BAAoAIAAgAAoAIAAgADwAaQBuAHAAdQB0ACAAaQBkAD0AIgBmAGkAdgBlACIAIAAvAD4ACgAgACAAPABsAGEAYgBlAGwAIABoAHQAbQBsAEYAbwByAD0AIgBmAGkAdgBlACIAPgBUAGgAYQBuAGsAZgB1AGwAbAB5ACAAewAnAGEAdAAgAGwAZQBhAHMAdAAgAHQAaABpAHMAIABpAHMAIABvAGsAYQB5ACcAfQA8AC8AbABhAGIAZQBsAD4ACgA8AC8APgA%3D
Expected result
Labels that are statically analyzable to confirm they will result in a non-empty string should not be reported as errors.
This was not happening in 1.8.3, started showing up in 1.9.0.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

defining a label as a component also has issues:
https://biomejs.dev/playground/?code=YwBvAG4AcwB0ACAAbABhAGIAZQBsACAAPQAgACIAVABoAGkAcwAgAGkAcwAgAG4AbwB0ACAAbwBrAGEAeQAiADsACgAKAGYAdQBuAGMAdABpAG8AbgAgAEwAYQBiAGUAbAAoAHAAcgBvAHAAcwA6ACAAUgBlAGEAYwB0AC4AQwBvAG0AcABvAG4AZQBuAHQAUAByAG8AcABzAFcAaQB0AGgAbwB1AHQAUgBlAGYAPAAnAGwAYQBiAGUAbAAnAD4AKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIAA8AGwAYQBiAGUAbAAgAHsALgAuAC4AcAByAG8AcABzAH0AIAAvAD4AOwAKAH0ACgAKADwAPgAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAbwBuAGUAIgAgAC8APgAKACAAIAB7AC8AKgAgAFUAbgBkAGUAcgBzAHQAYQBuAGQAYQBiAGwAeQAgAG4AbwB0ACAAbwBrAGEAeQAgACoALwB9AAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAbwBuAGUAIgA%2BADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAdAB3AG8AIgAgAC8APgAKACAAIAA8AGwAYQBiAGUAbAAgAGgAdABtAGwARgBvAHIAPQAiAHQAdwBvACIAPgBUAGgAaQBzACAAaQBzACAAbwBrAGEAeQA8AC8AbABhAGIAZQBsAD4ACgAgACAACgAgACAAPABpAG4AcAB1AHQAIABpAGQAPQAiAHQAaAByAGUAZQAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAdABoAHIAZQBlACIAPgB7AGwAYQBiAGUAbAB9ADwALwBsAGEAYgBlAGwAPgAKACAAIAAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAZgBvAHUAcgAiACAALwA%2BAAoAIAAgADwAbABhAGIAZQBsACAAaAB0AG0AbABGAG8AcgA9ACIAZgBvAHUAcgAiAD4AewAnAEEAcABwAGEAcgBlAG4AdABsAHkAIAB0AGgAaQBzACAAaQBzACAAYQBsAHMAbwAgAG4AbwB0ACAAbwBrAGEAeQAnAH0APAAvAGwAYQBiAGUAbAA%2BAAoAIAAgAAoAIAAgADwAaQBuAHAAdQB0ACAAaQBkAD0AIgBmAGkAdgBlACIAIAAvAD4ACgAgACAAPABsAGEAYgBlAGwAIABoAHQAbQBsAEYAbwByAD0AIgBmAGkAdgBlACIAPgBUAGgAYQBuAGsAZgB1AGwAbAB5ACAAewAnAGEAdAAgAGwAZQBhAHMAdAAgAHQAaABpAHMAIABpAHMAIABvAGsAYQB5ACcAfQA8AC8AbABhAGIAZQBsAD4ACgAKACAAIAA8AGkAbgBwAHUAdAAgAGkAZAA9ACIAcwBpAHgAIgAgAC8APgAKACAAIAA8AEwAYQBiAGUAbAAgAGgAdABtAGwARgBvAHIAPQAiAHMAaQB4ACIAPgBUAGgAaQBzACAAaQBzACAAYQBsAHMAbwAgAGEAbgAgAGkAcwBzAHUAZQA8AC8ATABhAGIAZQBsAD4ACgA8AC8APgA%3D

@lifeiscontent Have you tried configuring the rule? Specifically I'm talking about labelComponents.
https://biomejs.dev/linter/rules/no-label-without-control/

@wojtekmaj yes, I would have in the playground, but no option to change the config from what I can tell

@Conaclos  how can i config or disale this rule noLabelWithoutControl  in biome.js file.
Thank You, for your support

@othegagan
{
  "linter": {
    "rules": {
      "a11y": {
        "noLabelWithoutControl": "off"
      }
    }
  }
}

I am getting this warning, (I have biome 1.9.2 installed )

You're probably using an old version of the schema

Yep, i just saw the $schema, in the config it was 1.8.3  but i had installed 1.9.2, after changing it to latest one it is working fine, i am able to disable this rule..
Thank You 😎👍

@othegagan
We always recommend running biome migrate --write after a version bump, the command will update the configuration for you


Is OAuth supported?

Is OAuth supported?
If yes, Where is the documentation and example?
If not, How?

Hi,
There is module for OAuth on the dev branch.


⚠ ClamAV has degraded performance

In 43c985e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in 295a392 after 15 minutes.


Node registration expiration should be configurable

Currently expiration is hardcoded to current_epoch+2 in the registration worker (https://github.com/oasisprotocol/oasis-core/blob/02a945839e9bb7e2bb119d26d6a0b53129316396/go/worker/registration/worker.go#L623).
This should be configurable, and it should probably default to MaxNodeExpiration (https://github.com/oasisprotocol/oasis-core/blob/2ca7a1dc790472ce564c72fab55a8e769c758ade/go/registry/api/api.go#L1301).

Why?  The reason it is relatively short is so that nodes that fail to re-register (repeatedly over the course of an eppch) get pruned reasonably quickly.  There is no upside I can think of for using longer expiration period as nodes will still re-register once an epoch.


Fix sync extension logging

What type of PR is this?
bug
Which issue does this PR fix:
closes https://github.com/project-zot/zot/issues/2527
What does this PR do / Why do we need it:
It does two very small things.
First: it ensures that Zot doesn't panic with a nil pointer dereference on incorrectly configured local storage in the sync extension, and instead returns an error when localImageStore is nil.
Second: (and arguably more important) it enables logging for the sync extension image store.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
I have manually tested this on my cluster, and can confirm that logging accurately shows my configuration error in #2527 (I had configured Zot to use a read-only filesystem, which obviously doesn't work since it needs permissions to write to the download directory used in the sync extension) and the panic instead just returns an error which is logged to stdout.
Automation added to e2e:
Will this break upgrades or downgrades?
No.
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndersBennedsgaard do you want to squash your commits in the PR into a single commit?

I don't know why the CI is failing. It's complaining about code coverage  and something about licenses, but I don't get the issue..

@AndersBennedsgaard do you want to squash your commits in the PR into a single commit?

@rchincha I could do that, but wouldn't it be easier just to do a squash merge when it gets merged to main?


etcdhttp: add config/local/debug endpoint

PUT on the endpoint sets the GlobalDebugLevel to DEBUG.
DELETE on the endpoint set the GlobalDebugLevel to INFO.
The action overwrites the original log level setting from
users. We need to write doc to warn this.
Close https://github.com/coreos/etcd/issues/2942

@xiang90 instead of fooling around with HTTP verbs I feel it would be better to just put with a verbosity parameter insetad.

@philips We can do that. But this is how today's auth/enable works. I wanted to be consistent.

/cc @barakmich Any idea?

I think debug endpoint is good considering we have https://github.com/coreos/etcd/blob/master/Documentation/auth_api.md#enable-and-disable-authentication already. /cc @philips

we closed this PR because we use master branch as the base branch for development instead of dev-2.2 after etcd 2.1 is cut. we will cherry-pick these commits and send new PR compared to master branch. Sorry for the inconvenience.


Set a reasonable min supported Android version

Problem
We currently support Android devices as far back as Android 5.0. This is very old and requires that we support devices used by less than <1% of our users. This requires additional support for old versions, and sometimes requires that we implement specific code to handle old and new/Android versions differently.
Android SDK useage
Solution
Set a reasonably valid supported Android version, based on the current amount of users on lower Android versions. Perhaps Android 7 is a good starting point.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fedc73e1218c2523
Upwork Job ID:<PHONE_NUMBER>230606336
Last Price Increase: 2023-01-05

On hold for now

Not a priority

Still not a priority

Same as above. We talked about this in slack and will likely target 8.0

Same as above

Okay, so Android 7.0 still seems like a reasonable minimum supported version:

I'm just not sure we have a true problem here yet...

No change

Thank you, I commented on the PR.

Update: RN 0.73 may make minimum sdk version to 23.
Since https://github.com/facebook/react-native/pull/39671 just got into 0.73.0-rc.5

Thanks, Android 7.0 (SDK 23) seems reasonable 👍

No recent updates

We have discussing SDK 23 as a reasonable minimum here

I'd say 23 is definitely reasonable.

No current need to bump the min version.

Yup, VisionCamera V4 will work on minSdk 21

No need for this bump yet

Closing, we'll create a new issue for discussion when we actually need to make a bump


Trial ag-grid as a replacement for ui-grid

https://github.com/ceolter/ag-grid
Looks like its ~ 500kb

Open source compatible version has limitations making it unworkable as a simple replacement for ui-grid.


Update content-camera.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3215
Changed authors as per @scanum

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@kenwith PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

The author should not have the @ sign so I will go ahead and adjust that now.

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/3353


Make Global or Universal Accessor to all the attributes of a model in Laravel 5.4 ?

Laravel Version: 5.4

Description:
In Laravel 5.4 , i want to make global or universal accessor to all the attributes of a model to check if the attribute value equal to NULL then return empty string instead of NULL !
for example : consider my response is an object of current login user :
$user  = Auth::user();
$user['auth_token'] = $user->api_token;

return response()->json([
     'data'          => [
                                'user'       => $user,
                            ],
     'message'   => 'success',
     'code'         => getMsgCode()
]);

the JSON response is like this :
{
  "data": {
    "user": {
      "id": 4,
      "name": "user1",
      "email"<EMAIL_ADDRESS>      "gender": null,
      "phone": null,
      "img": null,
      "role": "member",
      "status": 1,
      "created_at": "2017-04-09 14:44:54",
      "updated_at": "2017-04-15 16:43:51",
      "auth_token": "6csDDeFoDxWNvKGhvQcMnLsK7vRiF7FNhOGSUEYt2OmZ1OLhy4vvrpPDONk7"
    }
  },
  "message": "success",
  "code": 200
}

so as you see above in the response, for example the gender, phone or img ,, all of this attributes because there is no value to it in the database , it returned as a NULL value !!
and i don't want this null value , instead i want it to be an empty string ( "" )
like this :
{
  "data": {
    "user": {
      "id": 4,
      "name": "user1",
      "email"<EMAIL_ADDRESS>      "gender": "",
      "phone": "",
      "img": "",
      "role": "member",
      "status": 1,
      "created_at": "2017-04-09 14:44:54",
      "updated_at": "2017-04-15 16:43:51",
      "auth_token": "6csDDeFoDxWNvKGhvQcMnLsK7vRiF7FNhOGSUEYt2OmZ1OLhy4vvrpPDONk7"
    }
  },
  "message": "success",
  "code": 200
}

And i know about  the Accessor in laravel .. for example i can do this for the img attribute, i can wirte this function ( accessor ) in User model :
public function getImgAttribute($value){
    return is_null($value) ? '' : $value;
}

but what i want is to apply an Global or Universal Accessor to all attributes instead of writing an Accessor for each attribute to handle the null value in the response.

Have you tried attribute casting?
https://laravel.com/docs/5.4/eloquent-mutators#attribute-casting

@lindyhopchris :
the attribute casting applied on setting data or on getting ??
and if it on getting data, this is the only way to deal with this situation ? , as i don't want to write all the attributes that is nullable instead i want to write one code like the accessor to be applied on all attributes ..
Thanks .

You could override the getArrayableAttributes Model method and tinker with it a bit.
Anyway please continue on the forums, we try to keep this repo for bug reporting only.

From looking at the code I believe (but haven't tried myself) that the casting only affects getters, as the casting doesn't seem to be called in the setter.
https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L511-L543

@themsaid : thank you Mohamed, its worked for me :+1: :100:
by doing this in my model :
protected function getArrayableAttributes()
    {

        foreach ($this->attributes as $key => $value) {
            if ($key == 'deleted_at') continue;

            if ( is_null($value) ) {
                $this->attributes[$key] = '';
            }
        }

        return $this->getArrayableItems($this->attributes);
    }

@lindyhopchris : thanks for your replaying :+1:


Minor clean up and added node environment for jslint

I would have liked to do however, RelayServer was hampering me from seperating the ip logic.
Additionally, I'm not exactly sure if you want to keep the event emitter private or not as that is the benefit of doing things the way your doing. However, it also adds redundant features
The Relay server itself could probably be more abstract

Thanks for this.  One question, I don't understand the
+/*jslint node: true */
stuff. I'm using eslint. Type
grunt eslint

And it's configured to use node mode for those files already so are those jslint lines needed?

More importantly its messy and you don't need to see it. I'm using atom which is helping me lint on the fly. But I'll run eslint as well. Why not use all the linters amirite?

For what its worth, eslint seems quite draconian. That may be a good thing though there are times such as here it wants you to split up the variable statements which is purely a personal preference issue (which may actually prefer commas for performance, [though its impact is debatable]).
That being said, there is so much linting to do T__T

eslint is not draconian, my configuration of it is :P  I had forgotten to check in the files that skip checking semver etc...
But, that said, I manually merged most of your changes but I couldn't use body-parser as is. It changes the behavior. Specifically if you pass bad json it just barfs, there's no catching the error. I added 2 unit tests to test post handling which caught the change in behavior. The issue is documented on SO and the body-parser repo but I looked around and didn't see a solution.
As an aside this is one of those things though that seems like overkill. body-parser is ~6000 lines of code to replace 20 lines of code. Sure it's supposed to handle some special cases but I'm not sure where any of those special cases would come up in HFT so for now I just refactored the old json parsing code into express middleware.

Understandable :) I fully and respect your decisions. BodyParser certianly has a lot in it, though in other cases people. I'll try my best to do more tests/create more in case I submit to your repo. This is very far down the line, so the last thing I want to do break what isn't broken.
I'm sincerly excited to see this project continue to evolve!


Costumers service

If you rely solely on an online bank, you could be challenged to access your accounts should your bank experience an online or mobile app outage and there’s no branch for you to visit instead.

Best online banking services 24 hours on service

Very good and easy to access,I love online banking services


iOS 15 start app crash

build Xcode 13.2
Version:             1.0.380 (77)
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           com.fourxfun.ios.cyber [12505]

Date/Time:           2021-12-17 13:49:19.1418 +0800
Launch Time:         2021-12-17 13:49:16.2291 +0800
OS Version:          iPhone OS 15.1 (19B74)
Release Type:        User
Baseband Version:    7.02.00
Report Version:      104

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000010
Exception Codes: 0x0000000000000001, 0x0000000000000010
VM Region Info: 0x10 is not in any region.  Bytes before following region:<PHONE_NUMBER>
      REGION TYPE                 START - END      [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->
      __TEXT                   1040d4000-1040dc000 [   32K] r-x/r-x SM=COW  ...berpunkMobile
Exception Note:  EXC_CORPSE_NOTIFY
Termination Reason: SIGNAL; [11]
Terminating Process: exc handler [65269]

Terminating Process: exc handler [65269]
Triggered by Thread:  0

Thread 0 name:   Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   UnityFramework                	       0x10c4a38d4 0x10c21c000 + 2652372
1   UnityFramework                	       0x10c4a38cc 0x10c21c000 + 2652364
2   CoreFoundation                	       0x1851c0c4c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 20
3   CoreFoundation                	       0x185255554 ___CFXRegistrationPost_block_invoke + 48
4   CoreFoundation                	       0x18522ab34 _CFXRegistrationPost + 416
5   CoreFoundation                	       0x1851d5754 _CFXNotificationPost + 696
6   Foundation                    	       0x1868f0138 -[NSNotificationCenter postNotificationName:object:userInfo:] + 92
7   UnityFramework                	       0x10c230cd0 0x10c21c000 + 85200
8   UnityFramework                	       0x10c230dac 0x10c21c000 + 85420
9   UnityFramework                	       0x10dad507c 0x10c21c000 + 25923708
10  GoogleUtilities               	       0x1068ebb68 -[GULAppDelegateSwizzler application:donor_didRegisterForRemoteNotificationsWithDeviceToken:] + 264
11  UIKitCore                     	       0x18839c43c __63-[UIApplication pushRegistry:didUpdatePushCredentials:forType:]_block_invoke + 108
12  libdispatch.dylib             	       0x184ef5194 _dispatch_call_block_and_release + 24
13  libdispatch.dylib             	       0x184ef6198 _dispatch_client_callout + 16
14  libdispatch.dylib             	       0x184ed74a8 _dispatch_main_queue_callback_4CF$VARIANT$armv81 + 908
15  CoreFoundation                	       0x1851e57e8 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
16  CoreFoundation                	       0x1851a30e8 __CFRunLoopRun + 2528
17  CoreFoundation                	       0x1851b5d7c CFRunLoopRunSpecific + 572
18  GraphicsServices              	       0x19f42a9a0 GSEventRunModal + 160
19  UIKitCore                     	       0x1879e805c -[UIApplication _run] + 1080
20  UIKitCore                     	       0x18777dce0 UIApplicationMain + 2028
21  UnityFramework                	       0x10c235c34 0x10c21c000 + 105524
22  CyberpunkMobile               	       0x1040dbe00 0x1040d4000 + 32256
23  dyld                          	       0x1043b4190 start + 444

ref:
https://giters.com/Unity-Technologies/com.unity.mobile.notifications/issues/121

@yingnierxiao this appears to be a Unity issue. There are no GoogleUtilities or Firebase symbols in the crashing thread.


Teams Fixes

Pull Request (PR) description

TeamsCallingPolicy

Removed the AllowCalling parameter since it is no longer supported;
Fixed an issue with Policies without tags in their name (e.g. Global);

This Pull Request (PR) fixes the following issues
N/A

This change is

@ykuijs Can you review please? Thanks

Codecov Report

Merging #421 into Dev will decrease coverage by 73%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##             Dev    #421     +/-   ##
=======================================
- Coverage     90%     17%    -74%
=======================================
  Files        104     104
  Lines      11213   11214      +1
  Branches      10       0     -10
=======================================
- Hits       10200    1977   -8223
- Misses      1003    9237   +8234
+ Partials      10       0     -10


sui-multi-select avoid multiple select of same option

Hi guys,
I am confused over the usage of sui-multi-select, if I am making a mistake in implementing or is it a bug? I see that I am able to select single object/option multiple times. I could avoid it by putting extra checks. But it does not seem nice to first show the user the option and deny its selection.

Here is the stackblitz.

duplicate #148

Possible solution:

https://stackblitz.com/edit/ng2-semantic-ui-select-resolved


DO NOT MERGE UNTIL 1.9.0 - LTS Release Branch

Release PR for Zowe v1.9.0 LTS.
Feel free to edit this description to describe the contents of this PR as it evolves:

1.9.x LTS site configuration
Release Notes set up

TODO -

Use new Zowe logo
Confirmation from ci/cd squad that our naming in version picker is good
CLI installation docs, tutorials, Web Help updated for @zowe-v1-lts version, FTP, IMS, MQ, and SCS plug-ins are added
Link to document about what Zowe LTS means
TPSRs
BoM update (manual)
Archive PDF

@OnnoVdT It looks like there are a few missed DCO signoffs here for your ID - I think you'll need to retroactively sign-off by pushing a .txt file to the dco_signoffs folder in this repository. Thanks!

@BrandonJenkins14 I hope I did it right, https://github.com/zowe/docs-site/pull/1007

This PR could not be built now. Will close and open a new one.


Can't update token list

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
I am trying to update the logo path in the solana.tokenlist.json file but get the error "Error: Pull request should not contain any deletions."

Can someone please update the MMaps token to the right format
{
"chainId": 101,
"address": "EFqYVEitSUpUTj2d9LSqun4eZ4BzouFuTPqQzU4hNtsS",
"symbol": "MMaps",
"name": "MapMetrics",
"decimals": 6,
"logoURI": "https://raw.githubusercontent.com/solfinaprotocol/token-list/main/assets/mainnet/EFqYVEitSUpUTj2d9LSqun4eZ4BzouFuTPqQzU4hNtsS/logo.png",
"tags": [
"utility-token",
"Community",
"NFT"
],
"extensions": {
"website": "https://mapmetrics.org/"
}
},

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Please read the SPL-token README, and ensure your SPL-token info uses the correct Uniswap format.

If this is still an issue, please link a PR and reopen this!


Push Hash

Hello Martin,
We started with version 1.2 of your application and found the push hash to McAfee a useful option.  Seems it was removed at some point.  Can that be restored?  I'm happy to assist in restoring that function in the app if you're looking for a collaborator.
Thanks,
Josh

Hi Josh,
thanks for you message. The push hash function got renamed in 1.2.3 to set reputation.
With the set reputation action you will be able to set TIE enterprise reputations.
Is that the action you were looking for?
All the best,
Martin

Hi Josh,
i will close the open issue. Please reopen if there is anything with the set reputation action.
Many thanks and all the best,
Martin


add messages to AMINO.MAP

Add types to Amino.Map
Finding fix for gov vote message proposal type. Broken in 1.2.1 working in 1.1.0

@joe-bowman This is the pr to merge, the other is now closed and was from a few months ago


[silgen] When compiling with sil-ownership use borrows+CopyOnSuccess instead of TakeOnSuccess.

[silgen] When compiling with sil-ownership use borrows+CopyOnSuccess instead of TakeOnSuccess.
This is NFC since all changes are behind a flag. I took a look at the codegen
when this is enabled. It looks pretty optimizable for a -Onone ARC pass. Until I
have that pass though I need this behind a flag.
Basically you see a lot of this pattern:
%0 = begin_borrow %foo
%1 = copy_value %0
...
bb1:
%2 = begin_borrow %1
%3 = copy_value %2
...
destroy_value %3
end_borrow %2 from %1
destroy_value %1
end_borrow %0 from %foo
...
bb2:
destroy_value %1
end_borrow %0 from %foo
...
This is really easy to optimize since one can easily see that all of %1's users
are borrows or a final destroy and since %1's lifetime is completely surrounded by the borrow of %0.
rdar://31145255

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge


Obey over_18 settings for link / search get

:eyeglasses: @florenceyeun @Deimos

I am horribly unqualified to be giving this :fish:

:fish: lgtm

@florenceyeun / @Deimos - had to revert this, because it was returning empty lists for NSFW subreddits.


[Feature] Support more specific error message (backport #34484)

Add a parameter to Starrocks::Status::to_string to control whether the status information it outputs has context.
When tablet creation fails, return the error message from be to the user client through Starrocks::Status::to_string.

What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[x] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.11 out of 12 committers have signed the CLA.:white_check_mark: kevincai:white_check_mark: letian-jiang:white_check_mark: Smith-Cruise:white_check_mark: abc982627271:white_check_mark: stonechen111:white_check_mark: Youngwb:white_check_mark: EsoragotoSpirit:white_check_mark: zombee0:white_check_mark: gengjun-git:white_check_mark: rickif:white_check_mark: Astralidea:x: mergify[bot]You have signed the CLA already but the status is still pending? Let us recheck it.

@Mergifyio rebase


Specify engine in Dream API Call

Dreamstudio deprecated some engines and so a new one must be specified.

Hmm this doesn't seem to work on the dev preview, we can try prod

Seems like it doesn't return an image

Let me try again, I think I made a spelling error

Thanks @wasabipesto!

I'm not sure this is 100% fixed - I changed to the SDXL v0.9 model since that was the first one that worked from my testing, but it seems like the vercel function might be timing out while it waits for the image response. The function times out after 15s but the image generation can take 20-40s.

Oh I see, we can fix that if it's a real problem. I haven't experienced it yet

Well it's working fine on prod now, maybe dev has different timeout limits.
One last thing, I would keep an eye on usage costs. I don't know how much more the SDXL API costs but there was a note that it would be higher than the old engine.


[ASK] The docstring explanation for LibffmConverter

Description
Hello Dev Team,
In the docstring of LibffmConverter:
https://github.com/microsoft/recommenders/blob/fe215e9babf8f7caba025a83059445362cff0006/recommenders/datasets/pandas_df_utils.py#L112
I'm wondering if this line would be the following one instead:
i.e. `<field_index>:<field_feature_index>:1` or `<field_index>:<field_feature_index>:<field_feature_value>`

Since according to:
https://github.com/microsoft/recommenders/blob/fe215e9babf8f7caba025a83059445362cff0006/recommenders/datasets/pandas_df_utils.py#L225
The returned value is in form of <field_index>:<field_feature_index>:<field_feature_value> instead of  <field_index>:<field_index>:<field_feature_value>.
A PR https://github.com/microsoft/recommenders/pull/1669 has been made to fix this typo if applicable.
Thank you very much.

Hello @miguelgfierro, thanks for reviewing the PR. I'm also wondering if there would be a specific reason for selecting 1 in <field_index>:<field_feature_index>:1 for strings? Thanks again!

That's just an example, you can add the value you want


Moving code from bin/util into tikv, and crate docs

What have you changed? (mandatory)
This moves most of the src/bin/util code and most of src/bin/tikv-server.rs into the tikv library. In addition to making it easier to use the library to create a tikv server, it also reduces the amount of utility coded that is recompiled between the three binaries.
This is a follow up to my previous cleanup pr. It does a number of things.
It started out as a documentation patch, and I add some basic crate docs. Then I started documenting some of the configuration methods, but found I wanted more of the setup code from tikv-server, so that it would be easier to write examples.
So then I pulled in some commits for https://github.com/tikv/tikv/issues/4389, moving all of src/bin/util into the tikv library, and then the setup code from tikv-server. Now it should be easy to show documentation examples for the API.
Moving code from the bins into tikv will reduce the amount of compilation work, but won't reduce serial compilation time.
It is getting pretty big, so I hope to land it before continuing.
What are the type of the changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)
cargo check
Does this PR affect documentation (docs) update? (mandatory)
no
Does this PR affect tidb-ansible update? (mandatory)
no
Refer to a related PR or issue link (optional)
Fixes https://github.com/tikv/tikv/issues/4389
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

but won't reduce serial compilation time

Sadly, can it reduce the partial build time?

Sadly, can it reduce the partial build time?

No it won't. It's just moving compilation from one module to another. But some code that had to be compiled three times now may need to be compiled once. It probably won't be noticeable.

OK, re-merged. Docs say "Titanium" and "key-value" in both places.


how to train the network with mini-batches in eager execution?

Describe the problem
I find a simple code from tensorflow documents to train a simple neural network by eager execution.
I need to know that how should I modify the code to train the network with mini-batches?
Source code / logs
from future import absolute_import, division, print_function
import tensorflow as tf
import numpy as np
tfe = tf.contrib.eager
NUM_EXAMPLES = 1000
training_inputs = tf.random_normal([NUM_EXAMPLES])
noise = tf.random_normal([NUM_EXAMPLES])
training_outputs = training_inputs * 3 + 2
def prediction(input, weight, bias):
return input * weight + bias
def loss(weights, biases):
error = prediction(training_inputs, weights, biases) - training_outputs
return tf.reduce_sum(tf.square(error))
def grad(weights, biases):
with tf.GradientTape() as tape:
loss_value = loss(weights, biases)
return tape.gradient(loss_value, [weights, biases])
train_steps = 20000
learning_rate = 0.01
W = tfe.Variable(5.)
B = tfe.Variable(10.)
optimizer=tf.train.AdamOptimizer(0.1)
for i in range(train_steps):
grads=grad(W,B)
optimizer.apply_gradients(zip(grads,[W,B]),global_step=tf.train.get_or_create_global_step())
if i % 20 == 0:
print("Loss at step {:03d}: {:.3f}".format(i, loss(W, B)))

You'd want to structure your code so that each iteration feeds a minibatch instead of hardcoding the input in the call to loss.
See for example the custom training tutorial and other tutorial notebooks on www.tensorflow.org/tutorials and the MNIST example
Hope that helps!


This project could benefit from a CI / CD setup

I am thinking that Github Actions would be a good fit for this project to use CI and CD for PR validation, any objections?

Agreed, Kyle! We're working on getting PR CI testing in place.

We have PR in testing place now using the Swift CI infrastructure, thanks to @shahmishal! PRs now will need to pass CI on macOS with the latest Xcode and Linux with Swift with the latest versions of 5.1 and 5.2. Available commands are:

@swift-ci Please test (tests all platforms)
@swift-ci Please test macOS platform
@swift-ci Please test Linux platform


using '--' for separate vertical slides

The separator '--'  not works for vertical slides, probaly not implemented,
https://revealjs.com/#/2
Its possible to implement?

Its, I don't have a time to add this feature. I will just leave to up for grabs

do you update the docker repository?

No yet, I will make a new minor release as well :)

Done

No problem, I look later.
I think, the ACE editor may updated , then the old revealjs can be removed.

Good call #31! It's definitely needs to be clean up

great, now it runs directly from docker repo!
well, the ACE editor there is olny in the old version.
I think, one of the minifed versions can be used., like
https://github.com/ajaxorg/ace-builds/tree/master/src-min


Requirements txt need

Is your feature request related to a problem? Please describe.
Yes as of now when clone webiste we have to install all libraries manually, so we can create requirements.txt file and then we can run on one cmd
Describe the solution you'd like
I will create requirements.txt file where I will add all libraries with version
Describe alternatives you've considered
No response
Additional context
Assign it to me under gsoc
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Pranjal360Agarwal assign it to me under gsoc


Add a deployment status to EnvoyDeployment

Since EnvoyDeployment should manage deployment for you, it would be great if it mirrored the status of the underlying deployment so it would be easy to check from the EnvoyDeployment resource if everything is ready and if I can start sending requests through it.

/kind feature

Implemented in #184


will the history of chats connected in Telegram ?

Nazeem Hi, will the history of chats connected in Telegram be integrated into Conversations ?

Yes, it will be available in next week's updates


Special hours doesn't work for weekends

I'm trying to paint weekends in a different color, using the "special-hours" feature. The calendar is painted ok but nothing on weekend get different (coloured) than the rest.
I'm using VueJS 2.6.11, and VueCal 2.24.7
Here is my component configuration at the template section:
<vue-cal style="height: 30em" locale="es" today-button :special-hours="weekendDays" :time-from="9 * 60" :time-to="20 * 60" :time-step="30"/>
Inside the default export section (at data):
weekendDays: { 6: weekendHours, 7: weekendHours }
also:
const weekendHours = { from: 0 * 60, to: 23 * 60, class: 'weekend-hours'}  // full day
and the style:
    .weekend-hours {         background-color: rgba(255, 255, 0, 0.2);         border: solid rgba(255, 210, 0, 0.6);         border-width: 2px 0;     }
Any idea?
Regards,
Herman.

Hi @hgc2002,
Thanks for reporting, this is now fixed in version 2.24.8!

Please note that the documentation is up to date with the alpha release and a little ahead the 2.24.8 version, a few things may differ while using the current latest version - check the V 3.0 alpha release notes. I should release the stable version end of next week.

@antoniandre ok thanks.
uhm, so my code is about to change to adapt to the next stable version, right?
currently the problem is still happening in 2.24.8 (just updated) so I'll wait for the next version to try again.

Ok, fixed. I've found that the scoped style was not being added to the web page. Little bit strange. As soon as I put the style as global, it worked like a charm ...


Add device descriptions to Hat.get()

This should allow people to more easily distinguish which motor is connected to which port by adding a description to the dictionary returned from Hat.get()
Unfortunately, without moving type identification out to another class or another solution, on lines 193 and 228 of serinterface.py, one cannot use Device.name_for_id(typeid) to compare against "Matrix" instead of a fixed integer (which would be preferable for readability) due to a circular import.

Thanks for this, sounds like a good idea, will look over it properly soon

Note to self: If PR #126 gets accepted before this one, this PR will need a single line in devices.py where the type identifier is used for Matrix in __del__ changed to if Device._device_names[self._typeid][0] != "Matrix": to be more consistent.


AIRMap is not compatible yet

Summary
I'm getting this error whenever i want to create MapView component. I already wrote my code if there is error in my code then anyone can comment that
Reproducible sample code
const initialRegion = {
    latitude: 37.78825,
    longitude: -122.4324,
    latitudeDelta: 0.0922,
    longitudeDelta: 0.0421,
  };
<MapView style={styles.map} initialRegion={initialRegion}>
              <Marker
                coordinate={{
                  latitude: 37.78825,
                  longitude: -122.4324,
                }}
                title="Marker Title"
                description="Marker Description"
              />
            </MapView>

Steps to reproduce
Whenever using Mapview getting this error
Expected result
It needs to show Map in my app
Actual result
AIRMap is not Fabric compatible yet.
React Native Maps Version
^1.7.1
What platforms are you seeing the problem on?
Android
React Native Version
0.72.3
What version of Expo are you using?
Not using Expo
Device(s)
Google Pixel 4
Additional information
No response

It's the same problem for me. Can someone help me with this problem? I have it on Android

in your android gradle.properties
disable new architecture by setting following property to false
newArchEnabled=false.
#4383 is related

in your android gradle.properties disable new architecture by setting following property to false newArchEnabled=false.
#4383 is related

not working

I have a similar issue

any update ?

Create a file named react-native.config.js in the root directory of your project & paste this
module.exports = {
  project: {
    android: {
      unstable_reactLegacyComponentNames: ['AIRMap'],
    },
    ios: {
      unstable_reactLegacyComponentNames: ['AIRMap'],
    },
  },
};

this fixed the issue for me

is work for me thanks ❤

in your android gradle.properties
disable new architecture by setting following property to false
newArchEnabled=false.
after doing this uninstall application and reinstall again

This worked for me by using the legacy components in the new architecture
module.exports = {     project: {         android: {             unstable_reactLegacyComponentNames: [                 'AIRGoogleMap',                 'AIRMap',                 'AIRMapMarker',                 'PanoramaView'             ],         },         ios: {             unstable_reactLegacyComponentNames: [                 'AIRGoogleMap',                 'AIRMap',                 'AIRMapMarker',                 'PanoramaView'             ],         },     }, };

same issue
AIRMap is not compatible yet
import React from 'react';
import {StyleSheet, Text, View} from 'react-native';
import MapView, {PROVIDER_GOOGLE} from 'react-native-maps';
const CustomerLocation = () => {
return (

<MapView
provider={PROVIDER_GOOGLE} // remove if not using Google Maps
style={styles.map}
region={{
latitude: 37.78825,
longitude: -122.4324,
latitudeDelta: 0.015,
longitudeDelta: 0.0121,
}}>

);
};
const styles = StyleSheet.create({
container: {
...StyleSheet.absoluteFillObject,
height: "100%",
width: 400,
justifyContent: 'flex-end',
alignItems: 'center',
},
map: {
...StyleSheet.absoluteFillObject,
},
});
export default CustomerLocation;
"react-native": "0.73.6",
"react-native-maps": "^1.14.0",


esbuild error when running example 01

Steps to reproduce:
cd examples/01-hello-world/
gleam run -m lustre build app

crashes with
Downloading packages
 Downloaded 20 packages in 0.03s
  Compiling argv
  Compiling gleam_stdlib
  Compiling filepath
  Compiling gleam_community_colour
  Compiling gleam_community_ansi
  Compiling gleam_erlang
  Compiling thoas
===> Analyzing applications...
===> Compiling thoas
  Compiling gleam_json
  Compiling gleam_otp
  Compiling gleam_package_interface
  Compiling glearray
  Compiling gleeunit
  Compiling snag
  Compiling glint

warning: Deprecated value used
    ┌─ /home/grfork/reps/gleam/lustre/examples/01-hello-world/build/packages/glint/src/glint.gleam:493:56
    │
493 │   run_and_handle(from: glint, for: args, with: function.constant(Nil))
    │                                                        ^^^^^^^^^ This value has been deprecated

It was deprecated with this message: Use a fn literal instead, it is easier
to understand
  Compiling justin
  Compiling simplifile
  Compiling repeatedly
  Compiling spinner
  Compiling tom
  Compiling lustre
  Compiling lustre_ui
  Compiling app
   Compiled in 9.67s
    Running lustre.main
⠋ Building your project
warning: Deprecated value used
    ┌─ /home/grfork/reps/gleam/lustre/examples/01-hello-world/build/packages/glint/src/glint.gleam:493:56
    │
493 │   run_and_handle(from: glint, for: args, with: function.constant(Nil))
    │                                                        ^^^^^^^^^ This value has been deprecated

It was deprecated with this message: Use a fn literal instead, it is easier
to understand
✅ Project compiled successfully
⠋ Checking if I can bundle your application
warning: Deprecated value used
    ┌─ /home/grfork/reps/gleam/lustre/examples/01-hello-world/build/packages/glint/src/glint.gleam:493:56
    │
493 │   run_and_handle(from: glint, for: args, with: function.constant(Nil))
    │                                                        ^^^^^^^^^ This value has been deprecated

It was deprecated with this message: Use a fn literal instead, it is easier
to understand
✅ Esbuild installed!
▲ [WARNING] Import "create_from_string" will always be undefined because there is no matching export in "build/dev/javascript/gleam_erlang/gleam/erlang/atom.mjs" [import-is-undefined]

    build/dev/javascript/gleam_erlang/gleam/erlang/process.mjs:78:18:
      78 │   let tag = $atom.create_from_string("EXIT");
         ╵                   ~~~~~~~~~~~~~~~~~~

▲ [WARNING] Import "create_from_string" will always be undefined because there is no matching export in "build/dev/javascript/gleam_erlang/gleam/erlang/atom.mjs" [import-is-undefined]

    build/dev/javascript/gleam_otp/gleam/otp/actor.mjs:135:10:
      135 │     $atom.create_from_string("gleam@otp@actor"),
          ╵           ~~~~~~~~~~~~~~~~~~

▲ [WARNING] Import "from_string" will always be undefined because there is no matching export in "build/dev/javascript/gleam_erlang/gleam/erlang/charlist.mjs" [import-is-undefined]

    build/dev/javascript/gleam_otp/gleam/otp/actor.mjs:169:18:
      169 │         $charlist.from_string("Actor discarding unexpected message: ~s"),
          ╵                   ~~~~~~~~~~~

✘ [ERROR] No matching export in "build/dev/javascript/lustre/lustre/cli/utils.mjs" for import "exec"

    build/dev/javascript/lustre/lustre/cli/project.mjs:18:9:
      18 │ import { exec, map, try$ } from "../../lustre/cli/utils.mjs";
         ╵          ~~~~

✘ [ERROR] No matching export in "build/dev/javascript/lustre/lustre/cli/utils.mjs" for import "exec"

    build/dev/javascript/lustre/lustre/cli/esbuild.mjs:22:9:
      22 │ import { exec, keep, replace } from "../../lustre/cli/utils.mjs";
         ╵          ~~~~

▲ [WARNING] Import "new_subject" will always be undefined because there is no matching export in "build/dev/javascript/gleam_erlang/gleam/erlang/process.mjs" [import-is-undefined]

    build/dev/javascript/gleam_otp/gleam/otp/actor.mjs:197:25:
      197 │   let subject = $process.new_subject();
          ╵                          ~~~~~~~~~~~

4 of 19 warnings and all 2 errors shown (disable the message limit with --log-limit=0)
❌ Bundling with esbuild

I ran into an error while trying to create a bundle with esbuild:

This should be fixed in the new lustre_dev_tools package! Please give it a try and open an issue on the repo there if you run into anything.


adding java language

Description

added java language

Signed commits

[x] Yes, I am a Member of DEVSTRONS'

@KhafiaAyyub: Thanks for your valuable contributions! :slightly_smiling_face:

Thanks for your review @vsnthdev, @Panquesito7  & @alphaX86
@KhafiaAyyub : LGTM! 🥳

Oh, my suggestions weren't accepted yet. Should I make a PR to fix that? They are suggestions by the Markdown Linter. @ghulamyazdani.

@Panquesito7: We do not have any strict guidelines reg. markdown formatting & linting. In the future. We will like to implement a markdown linter within the project


Django 2.0

So, Django 2.0's just a few months away, and with it the dropping of Python 2 support.
@ghickman and @meshy: I know you've both done work on the static pages rebuild, so I was wondering roughly what the current state of play was with that. Essentially: do you think that, with the right support from others, it could be made ready in time for us needing to support Django 2.0? I know you're both really busy so may not be able to do much or any of he dev yourselves, but I don't know the state of that rebuild well enough to determine if I could help get it over the line in time or if it's just too far out.
If it doesn't look like a dead cert to be ready in time, I'm happy to try to get the current build Python 3 ready. Of course, that'll still need hosting changes from someone with access to that but hopefully that won't be too much work.

Django 2.0's just a few months away

omg they move so fast now, that's both amazing and argh!
So, a bit of a state of the union…
The static builder is 90% done and in typical fashion the last 10% is proving the hardest.  Building the home page and nav turned out to be the hardest parts.
The concept I ran with was one of: the tool should be able to generically look at some Django and create static HTML.  To this end I've built up a system that uses virtualenvs to generate the output from each version of Django so we can "just" rely on importing Django from the current env and get some HTML at the end.
You might be seeing where the issues came in at this point… if we're generating a load of HTML per Django version then how do we build a cross-version nav/get the latest version 🤦♂
You can see [and hopefully run!] the latest work from the static-pages-requiem branch.  Docs on how to get set up/run it are here

I know you're both really busy

I can't speak for @meshy but yes very much so for me :(

do you think that, with the right support from others, it could be made ready in time for us needing to support Django 2.0?

If someone picks up the dev then I think pre-Django 2.0 is definitely doable.  I'd be more than happy to answer questions on the existing code if someone else picks up getting it past the finish line.

Great, I'll start digging into it one of these evenings.
Does it get views and mixins from all across Django or does it only do views.generic like the first version did at the point I think you started working on the rebuild?

It takes a list of sources as part of the generate command, so you can pass in multiple locations where it can find CBVs like this.
The idea with that was letting us support an arbitrary number of locations (your initial auth.mixins PR popped up when I was first building it IIRC!) with only template code needing to be changed to accommodate them.

Brilliant! Should have read the docs :(

Cool. Well I'll definitely have a go at it soon.
In the mean time, I had a quick go at making the current version python3 ready. There wasn't much to do, but it wasn't until I had finished that I realised I should probably have been going for compatibility with python2 and python3, so I might need to go back and get some six in there.

I'm not sure it's worth the extra time of making the existing codebase cross-compatible. We should already have generated the docs for the old versions, and if we need to retroactively add something, we can always check out an old version.
Thank you for looking into this, by the way @exonian :)

OK great, yeah that does make sense. That was my initial thinking and then I kinda second-guessed myself.

For Django 2.0 we can use super().some_method() instead of super(SomeClass, self).some_method() because Django 2.0 is Python 3 only.
I think that's definitely nicer and simpler to read.

@ovalseven8 Yeah that syntax is way nicer! Did you mean using it in our docs or in our own classes?
If the former, I think that's already covered as Django 2.0 does use the newer syntax so when we generate fixtures from it they'll reflect that.
If the latter, @meshy has now moved master over to Python 3 but hasn't made this change, so it's all set ready to be done. Looks like just a couple of classes in views.py and one in models.py. If you'd like to submit a PR with the changes, that'd be really welcome!

Resolved by #130


CuPy JIT: Readable compile error messages

Indicates on which line of the target Python function the compile error occurred.
If an error is raised while the compilation, the type of error is immediately converted to _JitCompileError class temporarily.
The attributes of _JitCompileError object include 1. the type and message of the original error and 2. On which line of the original python function the error is raised.
Just before exiting the top level of the compilation function, the error type is restored to the original error type, and "Where in the Python function the compilation error occurred" is shown as the error message.

Jenkins, test this please

Jenkins CI test (for commit bc3b8f64739571292b1bc8117cd4060d27b30ef7, target branch master) failed with status FAILURE.

Jenkins, test this please.
Jenkins, test this please.

Jenkins CI test (for commit bc3b8f64739571292b1bc8117cd4060d27b30ef7, target branch master) failed with status FAILURE.

Jenkins failure is unrelated to this PR.


Duplicate symbols error

I'm not a rust expert, so forgive my terminology. This crate should hide all libzstd symbols in the rlib. Otherwise, when using the zstd-sys module, and linking with other C/C++ code that also uses zstd, you will get duplicate symbol warnings.
You can get zstd to hide all of its symbols with these compiler flags:
-DZSTDLIB_VISIBILITY=
-DZDICTLIB_VISIBILITY=
-DZSTDERRORLIB_VISIBILITY=
-fvisibility=hidden

See the example in python-zstandard.

Hi @gyscos, I'm preparing to release zstd-1.4.0 in the next week or two. The new advanced API is now part of the stable API in the development branch, and won't change between now and the release.
I believe that all the functionality you need in zstd-rs is now available in the stable API, except for maybe very minor use cases, which could be hidden behind an experimental feature. It would be great to see zstd-rs migrate to only using the stable API!
In the meantime, if you find that you are missing some critical functionality in the stable API, please let me know!

zstd-1.4.0 has been released.
Hopefully everything you need is in the stable API, which will make updating zstd versions much easier, since the stable API will never change. If you find you are missing something important, please let us know.


Add warning about IMPORT INTO statement

Add a warning that import into will invalidate foreign keys without a validate constraint statement. Resolves issue #8651.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e948f81256081899821183596a9b241cee4f0ba3/
Edited pages:

v20.1/foreign-key.md
v20.2/foreign-key.md
v21.1/foreign-key.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4d6afae5284f08e08d3f63234da431a5c624e71f/
Edited pages:

v20.1/foreign-key.md
v20.2/foreign-key.md
v21.1/foreign-key.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d3d3192032ffad2fb6725c25b43c6d347d7692e5/
Edited pages:

v20.1/foreign-key.md
v20.2/foreign-key.md
v21.1/foreign-key.md


Phrase Query with slop

I have checked the documentations and code and could not figure out how to write a query like the one below using SolrNet.
q=text:"digital group"~100
Help please.

Hi, any of these should work:
new SolrQuery("text:\"digital group\"~100")
or
new SolrQueryByField("text", "\"digital group\"~100") {Quoted = false}

Hi, any of these should work:
new SolrQuery("text:\"digital group\"~100")
or
new SolrQueryByField("text", "\"digital group\"~100") {Quoted = false}

That's pretty much what I found as well. Was hoping may be there would be a separate property or query class which I could use instead as it could have been more elegant.
Had to do a small modification on top of your suggestion, in order to ensure the keywords are properly quoted.
new SolrQueryByField("text", QueryByFieldSerializer.Quote(keyword) + "~100") {Quoted = false}
Thanks for the help @mausch.


Add support for Coveralls reporting

Adding Coveralls reporting coverage to the gem

@timcraft - Any idea why the jruby builds continue to fail until I go in manually and restart the builds? It looks like it's failing on the downloads.

@timcraft - Any idea why the jruby builds continue to fail until I go in manually and restart the builds? It looks like it's failing on the downloads.

This seems to be a new issue with jruby, and not with us, as @fabianrbz discovered, FYI.

Any idea why the jruby builds continue to fail until I go in manually and restart the builds? It looks like it's failing on the downloads.

I noticed it before but no idea. The call that is failing is rvm get stable so even though it's only on the jruby builds I don't think it's a jruby issue. Whether it's an rvm issue, a travis issue, or an issue with the travis config file we're using I'm not sure 🤷♂


use cast to disable warnings instead of unsafe Key()[HoleEnumConv]

the whole point is that Key(c) cast causes Holey Enum compiler warnings, this hopefully removes it by just simply using cast
did you think about this? or did you miss it? Please close it if its bs
Commit: ay, looked at the generated source before commit, its generates the same as above code. we don't get warnings anymore.

I think this will blow up with unknown keycodes, so I'd rather keep what we have @bloomingchad.

Hey yes, an unknown number do cause illegal storage access SIGSEGV. Have a good day