test: added LeakTest

GitHub Issue (If applicable): #

PR Type
What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
[ ] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

todo:

[ ] bump package after rte#59
[ ] drop EngineMetaAttributes.cs and drop UNO_RUNTIMETESTS_DISABLE_* constants


Lighting support

Hi, is there any way to add support for the Kraken LCD? I really hate NZXT CAM and finally handled to fully migrate to a single app for all the fans, only annoyance left is the LCD that does not disaply the stats nor a simple GIF unless the CAM software is opened

Hi @seanwlk , yes I wrote something that works very well with signalrgb.
https://github.com/brokenmass/AIOLCDUnchained
Give it a look.
I’m actually working on the next improved version so stay tuned


Recorded Run

An outcome of the Reproducibility and Provenance Task Group (2019-09-20) is general agreement on the need for a Recorded Run feature to enable the auditable execution of computational workflows in Tales.
The use case is as follows:

A researcher uses the Whole Tale system for the creation and development of a Tale leveraging data registration and interactive environments (e.g., Jupter/RStudio).
When they are ready to publish a version of their tale, they are encouraged to create a "Recorded Run", which includes:

Designating key workflow objects (e.g., entrypoint scripts) that must be executed to generate results/artifacts.
Executing a "Recorded Run" that 1) creates a version of the tale, 2) builds or tags and image of the environment, 3) launches a non-interactive container, 4) executes the workflow using PTRACE-style provenance capture, 5) tale version, image, results/outputs, and structured trace information are stored.

The structured trace information is used to capture runtime environment information, trace input and outputs sources, and support future queries and visualizations (e.g., which scripts produced which outputs)

This issue is intended to capture discussion and any work related to the technical design of the "recorded run" features.

Replaced by https://github.com/whole-tale/whole-tale/issues/88

Replaced by https://github.com/whole-tale/whole-tale/issues/88


Add support for Node Authorizer + Node Restriction admission controller

After https://github.com/kubernetes/kubernetes/pull/48707, we can now add support for the node authorizer + node restriction admission controller to kube-aws without breaking our node drainer implementation.
In order to use this, Kubelets must use certificates that conform with the username/group restrictions documented here, which makes TLS bootstrapping a prerequisite.
Also, as noted in cluster.yaml, this feature can only be used in Kubernetes 1.7.4+. (See #853)

Codecov Report

Merging #851 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #851     +/-   ##
=========================================
+ Coverage   34.49%   34.59%   +0.1%
=========================================
  Files          57       57
  Lines        3902     3908      +6
=========================================
+ Hits         1346     1352      +6
  Misses       2398     2398
  Partials      158      158

Impacted Files
Coverage Δ

core/controlplane/config/config.go
57.66% <100%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc583e...709bebc. Read the comment docs.

/lgtm
Thanks for the contribution @danielfm!


Bump capybara-screenshot from 1.0.21 to 1.0.22

Bumps capybara-screenshot from 1.0.21 to 1.0.22.

Release notes
Changelog
Commits

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>This is a copy of #243 with a shorter branch name, as longer branch names appear to cause Jenkins to panic.

#243 started working again, so this isn't needed.


[14.0] ISPN-14112 Prevent creation of schemas from empty content

https://issues.redhat.com/browse/ISPN-14112

LGMT, merged thanks!


Cannot boot windows 10 via OC

Describe the bug
I cannot figure out why but after I received a exchanged NUC8i7HVK from Intel, the OC just doesn't boot windows anymore, even the windows installer.
When I boot USB Windows 10 Installer using OC, it ends up posting an error, or simply restart.

If I use F10 to pick bootable device and install, after I set bootloader to OC by executing
bcdedit /set '{bootmgr}' path \EFI\OC\OpenCore.efi,
the OC still failed to boot windows, it's less than 3 sec did the windows 10 stuck and restart.
However, the Windows 10 installed in last NUC worked fine in this machine until I upgraded BIOS to 0059, after which it refused to boot and ran into blue screen immediately after being picked, reporting ACPI_BIOS_ERROR, and no luck after downgrading.
Expected behavior
I think it should be able to boot windows 10 without much pain, as my last NUC did. On my last NUC, I simply let OC to boot Windows installer and install and it worked fine.
Configuration

HaC Mini version : https://github.com/osy86/HaC-Mini/actions/runs/42725807
OSX version : 10.15.3
NUC model : NUC8i7HVK
Boot SSD model and protocol : NVME 1TB, MacOS
Second SSD model and protocol : SATA 512GB, Windows
First DIMM model : Kingston 2666 16GB
Display port(s) used : MiniDP, USB-C
Display resolution(s) : 2K, 4K
Any TB3 devices: HP TB3 DOCK
Any USB devices: DIY Keyboard, Logitech G903

Modifications
No
Panic log
Above

I don’t think this is related to OC. Does the USB work on another machine? According to microsoft the error code means corrupted files.

F10->USB UEFI, it works. But in OC, NO.

This feels like an OC issue to me. Can you manually update OC for the USB and see if that helps? You might have to manually update the config.plist as well.

This feels like an OC issue to me. Can you manually update OC for the USB and see if that helps? You might have to manually update the config.plist as well.

This feels like an OC issue to me. Can you manually update OC for the USB and see if that helps? You might have to manually update the config.plist as well.

I think I kinda fixed the problem by erase all my disks and reinstalled the system, which is tough but worked. But to install windows 10 still I have to boot the installer via F10 otherwise it ended up showing the same error message.
BTW, when booting windows via OC, NUC is recognized as a MAC MINI so that some drivers for NUC is not available at this point, like the IGPU.


resume/play functionality

Subject of the issue
new feature request
since web scraping is deals with lot of data , there should be an resume and play functionality.

Can reopen if anyone has interest in taking this on.


Creating of env.example for  development purpose

The current repo does not have any .env.example files, if added it will help contributors to setup their project more easily. Please assign this issue under gssoc-ext level 2

The current repo does not have any .env.example files, if added it will help contributors to setup their project more easily. Please assign this issue under gssoc-ext level 2

Sure, you can go ahead.
about levels: As per the given instructions we can only give this issue as level1 as there is no programming logic here,just adding .env.example the demo credentials


VSCode Stuck

Issue Type: Bug
VSCode stuck after Update on October 2018 (v1.29).
please Fix this issue.
Thanks
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz (4 x 3000)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.87GB (4.54GB free)

Process Argv

Screen Reader
no

VM
80%

Extensions (2)

Extension
Author (truncated)
Version

php-intellisense
fel
2.3.9

jquery-snippets
Hri
1.0.0

so, what version are using? 1.29 or 1.28?

I believe we are having the same issue, with me after the update today VSCode froze about 4 times, something about 6h of use, with it asking to close the window or reopen, with me tho it's version 1.29, I don't know how to debug VSCode exceptions such as this and would be happy to help

Also experiencing this with 1.29.0 on Mac OS High Sierra with only theme extension enabled. VSCode stops responding to interactions from mouse or keyboard and sometimes eventually becomes responsive again but usually I am having to kill it via the OS force quit. This has happened several times since the update to 1.29.0.

I got the same issue every ten minutes, it's definitely a bug in 1.29.0.
Or all releases? occurs before, but not so frequently.

I am also experiencing the “The window is no longer responding” dialogue since upgrading to 1.29.0. Initially I thought it was due adding the "terminal.integrated.experimentalBufferImpl": "TypedArray" setting but vscode still freezes after I removed this setting. I am using Windows 10 Version 1803

Also experiencing this after updating. Version 1.29.0 on Windows 10 x64 1809.

/duplicate of https://github.com/Microsoft/vscode/issues/62970


typo: Double word "removes"

Docs Build status updates of commit 61357db:
:clock10: Full build: the average full build time is 22 min(s) 26 sec(s), this is based on the last 166 build(s) for this repository.

Docs Build status updates of commit 61357db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azps-1.8.0/Az.Network/Remove-AzNetworkInterfaceTapConfig.md
:white_check_mark:Succeeded
View (azps-1.8.0)

azps-2.4.0/Az.Network/Remove-AzNetworkInterfaceTapConfig.md
:white_check_mark:Succeeded
View (azps-2.4.0)

azurermps-6.13.0/AzureRM.Network/Remove-AzureRmNetworkInterfaceTapConfig.md
:white_check_mark:Succeeded
View (azurermps-6.13.0)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Hosted Solutions

Is it possible to host your solution on premise?

@kitsushadow Not at the moment, no.
However, we do plan to open-source the server-side component. This would enable you to host it yourself in the future.

Awesome, thanks for the feedback!


External app global config integration testing with UI

Summary
External app global config integration testing with UI
Motivation
EA global config APIS are ready, test it with UI and identify the gaps

Observations:
user access: following apis are breaking
orchestrator/env/autocomplete
orchestrator/chart-group/list
orchestrator/app/min?teamIds=1
project: working fine
sso login service:  working fine
cluster env:
/orchestrator/env -> endpoint breaking
UI fails to load

UI ticket: https://github.com/devtron-labs/devtron/issues/983


setState() called in constructor when it isn't

On clicking a stateful widget containing an IconButton, which is supposed to change the colour of the Icon, I get the following error:
setState() called in constructor: WheelItem#121e2(lifecycle state: created, no widget, not mounted)

The code for the widget is as follows:

class WheelItem extends WheelItemState {
  State<StatefulWidget> createState() => new WheelItemState();
}

class WheelItemState extends State<StatefulWidget> {
  var _iconColor;
  @override
  void initState() {
    _iconColor = Colors.black54;
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return new IconButton(
      icon: Icon(Icons.star, color: _iconColor),
      onPressed: () {
        setState(() {
          _iconColor =
              (_iconColor == Colors.black54 ? Colors.blue : Colors.black54);
        });
      },
    );
  }
}

I think the class hierarchy is different to what you're supposed to use. The below should work as intended. I changed the WheelItem to extend StatefulWidget and WheelItemState to extend State<WheelItem>.
class WheelItem extends StatefulWidget {
  @override
  State<WheelItem> createState() => new WheelItemState();
}

class WheelItemState extends State<WheelItem> {
  var _iconColor;
  @override
  void initState() {
    _iconColor = Colors.black54;
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return new IconButton(
      icon: Icon(Icons.star, color: _iconColor),
      onPressed: () {
        setState(() {
          _iconColor =
              (_iconColor == Colors.black54 ? Colors.blue : Colors.black54);
        });
      },
    );
  }
}

Instead of extending the statefulwidget in state,use your previous class name which is *WheelItem as
state

confirmed this works, thank you @apalugniok and @farheen21


Add support for Gleam syntax in logger

Fixes #4
Values are now displayed as the equivalent Gleam types in the logger. This affects arrays (tuples), booleans and undefined (Nil):

JS
Gleam syntax

[1, 2, 3]
#(1, 2, 3)

true
True

undefined
Nil

Other types are displayed like in JS. However, objects that appear to be Gleam types also use the equivalent Gleam syntax. To detect Gleam types, the prototypes are inspected:

JS
Prototypes
Gleam syntax

{ "0": 5, foo: "bar" }
MyType -> CustomType
MyType(5, foo: "bar")

{ head: 5,  tail: { head: 3,          tail: {} } }
NonEmpty -> ListNonEmpty -> ListEmpty -> List
[5, 3]

Gleam syntax can be enabled and disabled at runtime, but there's isn't a button yet to control it.
Note that even when Gleam syntax is enabled, the JS properties of objects can still be inspected by clicking on the arrow next to an object.

This PR increases the TypeScript target from ES3 to ES2017. This may result in smaller and more efficient JS being emitted, and enables features such as accessors, which are unavailable when targeting ES3. Increasing the target to ES2017 is ok because no browser older than 2017 can possibly support WebAssembly.
This PR also includes some layout/design changes:

Editors correctly adjust their size when zooming in or making the browser window smaller
The buttons above the Gleam editor are in a single row again
Colors in the logger were adjusted to look better on red background

This looks good to me, locally.
Checked in Latest Firefox, Chrome and Safari on Mac OS 11.6.2.
Mac Safari has an issue unrelated to this PR as far as I can see.

Thank you for the Gleam type presentation. That's awesome!
Unfortunately it appears that this changes the mobile version to be horizontally scrollable which isn't desirable as it hides the GitHub link normally or shifts to hide the buttons / title.
This PR

Alternatively

Checked again on an iPhone, seems to work fine now thanks @Aloso

Looks great! Thank you ❤


Duplicate events when resizing & resize element bug

Do you want to request a feature or report a bug?
Report a bug
What's the current behavior?
This is reproduced when there are no events on the default day.
Click "Back" and click on any event, then try to resize it.
Bug 1: The resize element (=) reacts to click one by one (works -> does not work -> works -> ...)
Bug 2: The event is duplicated.

https://codesandbox.io/s/react-big-calendar-events-duplication-5p39x
What's the expected behavior?
The resize element always reacts.
Events are not duplicated.

Hey @ksk6794,
I had a few minutes and tried to duplicate what you're experiencing. I was able to fix both of those "bugs" when I changed Line 31 to: const CalendarComponent = Dnd;
Adding the react-dnd and withDragAndDrop together will try to override each other since they effectively do the same thing. So when I disabled react-dnd and react-dnd-html5-backend, everything seemed to work fine. I hope this helps!

Hey @christianpatrick,
I removed react-dnd and react-dnd-html5-backend, but the problem is still reproducing.

Not sure how I wasn't duplicating it earlier consistently, but now I can totally see what you were referring to.
When I changed the defaultView prop to the string "day", it began allowing drag and drop to work every time.
For the duplication issue, there's an example here showing the props to add for it to respect the resource column it's in.
I applied those changes to a fork of yours, and it seemed to do the trick: https://codesandbox.io/s/react-big-calendar-events-duplication-vx6ui
Let me know if that doesn't work but hope it points you in the right direction! :smiley:

I replaced Line 2 in events.js: dt.setDate(dt.getDate() - 1);
and it repeated again.
Yes, if there are events on the date that the component is rendered for the first time, the problem does not reproduce.

That's interesting! I had simply updated that to current day for simplicity. Can you take another peek at this fork and see if it's now working correctly? https://codesandbox.io/s/react-big-calendar-events-duplication-vx6ui
I ended up adding in state to allow move and resize functionality and all seems working now.

No, the problem is still present. (

Do you mind providing some extra detail to what I am missing? In the sandbox I forked, all of your steps have been applied.

I checked your fork https://codesandbox.io/s/react-big-calendar-events-duplication-vx6ui,
but the result is the same as in all the previous ones.

@ksk6794, thanks for the details. Unfortunately for me, I'm seeing full functionality in both Firefox and Chrome using the same steps. I'm not sure how else to help, but hope you find the solution that works for you! :crossed_fingers:

@christianpatrick, It's amazing that this works for you.
Checked in Firefox and Safari - the problem is present everywhere.
Yes, for myself, I solved this problem by putting a condition on the calendar render. When switching the date, the condition changes to true/false and the component is rendered again and the problem does not reproduce.
Obviously, there is a problem with the calendar and judging by the issue - developers encounter a problem from time to time.


Upload multiple images for a product

Is there is support for upload product pictures ? because it's doesn't work to me

upload multiple images - no
maybe on next deploy this feature will be


Confusing Usage

I'm trying it out, but it's not working. Am I missing any steps?

[x] Installation done
[x] Executed nace configure ...
[x] adonisrc.ts already contains @acidiney/bull-queue/queue_provider in providers
[x] Created new jobs with nace make:job ...
[x] Registered in start/jobs.ts

I want to run the job when opening one of the methods in the controller that has been registered to the route. I call it with the following code:
await bull.dispatch(ExampleHandlerJob.name, { app, payload } as ExampleHandlerPayload)

but it's not working at all. The process inside the handle() method doesn't work, even in the failed() method.

Hey, could you share with me the code inside the controller? And please confirm witch version are you using

And have you started the queue process? node ace queue:listen?

Actually, I haven't executed it yet, but I want when the server is running to simultaneously run BullMQ as well. I create start/bull.ts and add it to the preloads in adonisrc.ts, and the code is as follows,
import net from 'net'
import app from '@adonisjs/core/services/app'
import queue from '@acidiney/bull-queue/services/main'

const PORT = 9999
const server = net.createServer()

server.once('error', async (error: any) => {
  if (error.code === 'EADDRINUSE') {
    queue.list().forEach(async (queue) => {
      await queue.close()
    })
  }
})

server.once('listening', async () => {
  server.close()
  // await queue.processBulk(Object.keys(queue.list()))

  if (app.inDev) {
    await queue.ui(PORT || 9999, Object.keys(queue.list()))
  }
})

server.listen(PORT)

Any idea? Perhaps my above code is not quite right.


[Aio] Add add_done_callback to the ServicerContext class

This API is available in the existing API. This PR adds this functionality.
class ServicerContext:

    def add_done_callback(self, callback: Callable[[ServicerContext], None]) -> None:
        """Registers a callback to be called on RPC termination.
        Args:
          callback: A callable object will be called with the call object as
          its only argument.
        """

However, this API design is not perfect. User application cannot get the final status of the RPC on the server side, nor the status code, neither the raised exception if there is any. The problem also exists  in the existing API. Let's say you want to clean-up resources based on the result of an RPC, well, you can't do it through the done callback API.
On the other hand, I can see this API as a warning for users to not register powerful callbacks. WDTY?

@lidizheng Can you explain the rationale behind adding this? "Adding a done callback" is equivalent to calling await and then doing something else, no?
We have no obligation to maintain backwards compatibility here. asyncio is an entirely new set of APIs, one with opinions on how asynchronous operations should be carried out. It seems kind of clunky to use old and -- by your own admission -- imperfect approaches to asynchronicity.
Is there a better way to solve the use cases served by this method with asyncio? The main use case I can think of is cancellation. This is basically the only case where the server isn't in control of the end of life of the RPC. Is there a more natural way to solve this use case with asyncio? Perhaps you could use a Future to represent cancellation of the RPC?

@gnossen Yes. The done callback is simply a logic invoked after the handler is finished. But with existing Python syntax, there is no clean way to invoke multiple callbacks except using try-except-finally. This functionality can be considered a helper for that.
As for the scenario that done callbacks might be useful, 1) as you pointed out, the cancellation handling; 2) metrics collection; 3) logging.
The reason I want to port this feature is to support cancellation handling and error handling. I will reconsider the surface API. Do you have any suggestion regarding this two features?

@lidizheng That makes sense. Can we call out those use cases in the docstring then?
The main improvement I would like to see to this API is more visibility into the final status of the RPC. What I have in mind is something that would allow me to easily implement Apache-style logging. Something like
<IP_ADDRESS> - frank [10/Oct/2000:13:55:36 -0700] "GET /apache_pb.gif HTTP/1.0" 200 2326

What seems difficult to implement here is the status code and the byte length of the response. You'd have to gather that information in the servicer and then have the done callback reference that. It would be great if we could simply pull that information out of one of the arguments.


spring tries to insert null enums as varchar

Hi, I have an issue with enums using spring-data-jdbc.
I have a Java enum type:
public enum Sentiment {
  POSITIVE,
  NEGATIVE,
  NEUTRAL
}

And a corresponding enum type on one of my tables:
insights=> \dT+ sentiment
                                          List of data types
 Schema |   Name    | Internal name | Size | Elements |    Owner    | Access privileges | Description
--------+-----------+---------------+------+----------+-------------+-------------------+-------------
 public | sentiment | sentiment     | 4    | POSITIVE+| owner |                   |
        |           |               |      | NEGATIVE+|             |                   |
        |           |               |      | NEUTRAL  |             |                   |
(1 row)

I have this Entity (see the Sentiment field):
@Table("responses")
public record Response(
    @Id UUID id,
    UUID roundId,
    UUID cardTemplateId,
    UUID cardId,
    UUID answerOptionTemplateId,
    UUID answerOptionId,
    String text,
    Sentiment sentiment) {}

If I call save on the repository:
responseRepository.save(new RoundResponse(Id, roundId, UUID.randomUUID(), UUID.randomUUID(), UUID.randomUUID(), UUID.randomUUID(), "text", null)); // sentiment is null

I get the error:
Caused by: org.postgresql.util.PSQLException: ERROR: column "sentiment" is of type sentiment but expression is of type character varying

I have some Converters for handling the enums but because the value is null it doesn't reach these converters. It seems to me that the spring-data-jdbc library must be at some point trying to convert the null value to a varchar? (maybe by default?)
This is not what I would expect, I would expect if the value I am inserting is null and my enum type postgres field is nullable then null should be used rather than varchar :)
Let me know if you need any more information, thank you!

I think it isn't Spring Data JDBC that tries to convert something here. Instead it seems to tell Postgres, this null value is a VARCHAR` and Postgres is overwhelmed by the task to convert it to an enum ...

@schauder Do you think this is a bug? It seems like the MappingJdbcConverter doesn't recognise the type so converts it to a String.
Should there be some higher level function that handles nulls whereby if the value is null then don't try and type it and insert as a null in the DB?

Yes, I do think this is a bug. Could you provide a full reproducer, preferable as github repo?

^ is the above useful for you? @schauder

Yes, I think this will do. Just need to find time to look into it.

no problem, thanks for your help


CI Server is Borken

CI Circle is complaining about docker layer caching not being enabled for out plan 😭.
Need to fix

The is also preventing dependabot from doing it's thang


no matches for kind "Deployment" in version  "app/v1" ensure CRDs are installed first

The apiVersion for deployment is apps/v1

@cleverhu U saved my day bro =)))

Thank you guys, this helps :)

Can anyone tell, How this problem can be solved I have faced the same problem....


Leverage Functions to proxy API keys

We are aware that we are serverless NFT gallery, thus due security issues we need hide some secrets.
Would be nice to use https://docs.netlify.com/functions/build-with-typescript/ probably?
Seems pricing is fair https://www.netlify.com/pricing/#add-ons-functions
Don't forget to regenerate keys for

[x] pinata
[ ] textile

Once done

Closed by #535

I made textile keys invalid

I made textile keys invalid

♿


filtering using external commands causes neovim plugin to become unresponsive

Using VSCode 1.54.0, neovim  plugin version 0.0.78, NVIM v0.5.0-nightly, macOS Big Sur 11.2.2.
To reproduce, enter the following in a blank vscode buffer:
10
9
8
7
6
5
4
3
2
1
Then select all 10 lines, and type ":" to enter ex mode, then enter:
'<,'>!sort
Now the neovim plugin is completely unresponsive, no key commands work at all. The user must run Reload Window to restore the plugin functionality.
I didn't see any errors in the developer console. What's the best way to debug errors with the neovim plugin? Is there a log file somewhere?
Thanks!

I figured out the problem. I had some network folders on my PATH. For some reason those were causing vscode-neovim to hang for a long time when running ! filter commands. This behavior didn't occur when running nvim or vim from the terminal. By removing the network paths from my PATH I can work around the problem.


user docs: Update outdated UI screenshots and docs.

In preparation for release 1.6, the docs and their screenshots have been updated in this PR.
Some minor and trivial changes might have been made to other areas.
Fixes #4763 and #4522

Awesome, thanks @synicalsyntax for the extensive fixes! Merged as is; a few follow-ups that might be good:

view-the-exact-time-a-message-was-sent.md has a regression, in that we used to say how to see the full time, and currently it doesn't. You can get the full time by hovering over the timestamp.
I don't see where the information in "View information about a message" went?
"Send a stream message" should probably become "Send a message to a new topic", and potentially we should add a new article "Reply to a message"
For "custom link filter": we no longer automatically do open graph for github pull requests. Maybe that's fine for the screenshot, though?
Not worth changing now, but worth noting for the future that some of our message screenshots have the blue box around them


Support for custom config file path

Added the option to let users place msix_config.yaml as a separate file and pass it as an option when creating a msix installer.
Improved readme regarding new option

Closes https://github.com/YehudaKremer/msix/issues/220

One more minor thing, I was going to add a print statement for when the user is really using a custom file location but I removed it before committing to git as I wasn't sure you would like it.
I was adding it to provide some feedback to the user that the msix is using a custom location. So you can choose to add it yourself or leave it as it is.

Please check if you need any changes.

@YehudaKremer  May I ask to check this pull request, please?

Hello
The idea is nice and the PR code is good 👍
But adding complexity and responsibility of load different configuration files other then the common one (pubspec.yaml) are out of this package scope.
As an alternative, you can override specific configuration for different environment by using "Command-line argument", for example, my config in my pubspec.yaml is:
msix_config:
  display_name: Flutter App
  msix_version: <IP_ADDRESS>
  certificate_path: C:\path\to\myTESTCertificate.pfx
  certificate_password: 1234
  windows_build_args: --dart-define="DATABASE=development"

So in development environment i will run just dart run msix:create,
but in production environment i will run:
dart run msix:create --certificate-path "C:\path\to\myPRODertificate.pfx" --windows-build-args --dart-define="DATABASE=production".
This alternative may be less convenient, but I think it covers all use cases.

This alternative may be less convenient, but I think it covers all use cases.

It's too much hassle for such a little problem when the solution already fixes that. Plus we are not loading any multiple configuration files. It's just 2 files with the aim of reducing the time spent in producing the end msix files.
But it's okay since it's your package and you can choose to not include this pr.


HTML Error response breaks server

When there is an HTML error response from an API endpoint the server throws an error when it tries to run JSON.parse(body) , can we add a check to see what content type the response is? I'm running into this problem when my api gateway sends a timeout error

Ah okay! This would be a good addition! Will take a look into it. Thanks for the tip! 😊

So, the idea would be to return the unparsed response (whatever it would be) in an error from GraphQL?
@Alan-Cha Could we use error extensions for this?


Recipes issue

player knows 70 recipe(s) and has cooked 71 of them; there are 71 total recipes.

I'm missing Artichoke Dip - I missed the recipe the first time around. 605 is not in recipesCooked.
However... recipesCooked believes I've cooked 5 Large Eggs (174)!
Would it be possible to check that each cooked recipe's ID is actually a recipe, to get a correct count?
Thanks!

Sanity-checking the recipe ID has been added in version 2.0.1. Thanks for the suggestion.


Allow ECDSA address as output

Confirmed working:

https://explorer.kaspa.org/txs/bbb70a3d6a4d7b0b9774b97a27e65d38701fb9d73660c012cf7df5ee7726eaa5

ECDSA has a different OP_CODE (0xab) so this adds support for that.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (0f85b11) 88.01% compared to head (9c1a210) 88.03%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   88.01%   88.03%   +0.02%
==========================================
  Files          25       25
  Lines        1176     1178       +2
==========================================
+ Hits         1035     1037       +2
  Misses        141      141

Flag
Coverage Δ

unittests
88.03% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

unit-tests/test_tx_parser.c
100.00% <ø> (ø)

src/transaction/deserialize.c
65.95% <100.00%> (+1.51%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Scroll up page

We need an option to scroll to the top for easy user experience, if the document is long I need to scroll up manually.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f6e09089-1ae2-8943-5ce2-9d48f458c81f
Version Independent ID: ba780cba-f604-b0a4-a81a-23c7d2384762
Content: Set up staging environments - Azure App Service
Content Source: articles/app-service/deploy-staging-slots.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@harshahz
Thank you for bringing this to our attention.
I've delegated this to content author, who will review it and offer their insightful opinions.

Internal item created: https://dev.azure.com/msft-skilling/Content/_workitems/edit/288713
#please-close


Policy debugging doesn't work when using hostname for self-hosted gateway

APIM Setup:

APIM with internal VNET
Using self-hosted gateway
Only accessible from private network

Problem statement:
When trying to debug policy from VS Code for APIs on self-hosted gateway, the bugging operation fails with 404 error which test of same API from VS code works fine.
Steps to reproduce problem:

Right-click on API Management instance and choose "Select Gateway Host Name"

A text field is activated at the top of VS Code with 2 choices in dropdown. Choose "Input a hostname (for self-hosted gateway)"

Enter the hostname "gc-api-dev-apimgwt.apps.xxxxxxxx.xxxxxxx.com" and press enter

Test operation on selected API --> Correct hostname is used.

Hit "Send Request" and response is 200 OK.

Right click on an operation of selected API and choose "Start Policy Debugging". Debugging tries to initialize and then stops. Nothing happens

Debug Console shows 404 error:

Version: 1.56.2 (user setup)
Commit: 054a9295330880ed74ceaedda236253b4f39a335
Date: 2021-05-12T17:13:13.157Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

@thepolyglotter: We are facing a similar issue. Have you checked the logs on the self-hosted gateway?
If we try to connect a debugger , we see the following error on the gateway side:
[Info] XXXXXXXXXXXXXX, isRequestSuccess: False, totalTime: 0, category: GatewayLogs, callerIpAddress: XXXXXXXX, timeGenerated: XXXXXXXX, region: XXXXXXX, correlationId: XXXXXXXXXXXXXXXXX, method: GET, url: https://XXXXXXXXXXXX/debug-0123456789abcdef?key=XXXXXXXXXXXXXXXXXXXX, responseCode: 404, responseSize: 130, cache: none, clientProtocol: HTTP/1.0, clientTlsVersion: 1.2, lastError: {   "source": "configuration",   "reason": "OperationNotFound",   "message": "Unable to match incoming request to an operation.",   "section": "backend" }, correlationId: XXXXXXXXXXXXXXXX
Does anyone know what network connectivity is needed between the client (VS Code) and the server (self-hosted gateway)? Maybe a web-socket connection is required and this is blocked by a firewall sitting between VS Code and the gateway. I haven't checked this in detail in our infrastructure.


How to make a tunnel in CARLA?

Hi! I'm trying to make a tunnel in CARLA as Town03 shows.
https://user-images.githubusercontent.com/75726020/115820632-cb896a80-a433-11eb-806c-bdd0599f67cd.MP4
I know in RoadRunner, the height of road can be adjusted to even negative value, but it's hard to adjust terrain in RoadRunner.
If you know how to make a tunnel in CARLA, please give me some advices, thanks!

good questions


Jsonselect.org down

Hello lloyd,
It seems thats jsonselect.org playground is down ;)

Any action on this?  Looks like the domain expired.  It's a shame to see the visible face of the library go away, it's still the best JSON querying tool that I know of, and I'd hate to see it fade into obscurity.


Encoder: Maybe speed up stream row buffer

I thought that ArrayBuffer in Scala is smart enough to NOT allocate things if it still has existing capacity, but somehow in the profiler I'm reading a lot of allocations there. Let's try a custom implementation of the row buffer – as simple as possible.
If this works, I will finish the docstrings. If not, I will revert it.

We should also add tests for the FastBuffer class, to be 100% sure it works correctly with expanding capacity...


Building kedge & winch without CGO.

Signed-off-by: Bartek Plotka<EMAIL_ADDRESS>

This is for debug purposes, and it does not improve anything - but get some overview of what is happening (:


https://github.com/DmitryBaranovskiy/eve.git, could not load a package from it

I can't find the previous version of the package with bower, I mean this one https://github.com/DmitryBaranovskiy/eve , could you please leave there or make an redirect to this lib from  previous repo?

I got the same issue today when was updating composer dependencies. Can not install a project due this error.
Error:

[Composer\Repository\InvalidRepositoryException]
No valid bower.json was found in any branch or tag of https://github.com/Dm
itryBaranovskiy/eve.git, could not load a package from it.

Any news on this? It has been a while now. I can't install package from kartik-v/yii2-widget-datepicker

@platx @zmiftah as a workaround install in with specific commit see stackoverflow

I have following in my composer.json and now this issue fixed. You may take out installer-paths if not required in case.
"config": {
"fxp-asset": {
"installer-paths": {
"npm-asset-library": "vendor/npm",
"bower-asset-library": "vendor/bower"
},
"repositories": {
"bower-asset/eve": {
"type": "bower-vcs",
"url": "https://github.com/adobe-webplatform/eve.git"
}
}
},
"process-timeout": 1800
}

I have following in my composer.json and now this issue fixed. You may take out installer-paths if not required in case.
"config": {
"fxp-asset": {
"installer-paths": {
"npm-asset-library": "vendor/npm",
"bower-asset-library": "vendor/bower"
},
"repositories": {
"bower-asset/eve": {
"type": "bower-vcs",
"url": "https://github.com/adobe-webplatform/eve.git"
}
}
},
"process-timeout": 1800
}

thank u man


Zypper (SLES 15 Service Pack 1) repository missing "repodata"

ROCm SLES 15 Service Pack 1 repository (zypper) at http://repo.radeon.com/rocm/zyp/zypper/ seems to be missing repository metadata "repodata" used by zypper. This results in following error when update is attempted:

An error occurred during repository initialization. [zypper|http://repo.radeon.com/rocm/zyp/zypper/] Repository type can't be determined.

The "repodata" are present in version 3.1.1 but not in 3.3.

Hi @FilipVaverka
Thanks for reaching out.
This issue is fixed and no more observed with the latest ROCm 4.0 and so request you to try the same.
Thank you.


Login Successful

issue no #167
Description of Changes
the success message will display below the form heading if the login is successful. This also clears the input fields after a successful login.
Type of Pull Request

[ ] Bug Fix
[ X] New Feature
[X ] Performance Improvement
[ ] Documentation Update
[ ] Code Refactoring
[ ] Security Enhancement
[ ] Other (Specify): _______________

Screenshots / Demo (if applicable)

Checklist for Contributor
use'X' in [ ] to check it .

[ X] I have reviewed my code before submission.
[ X] I have read and followed the project's Contribution Guidelines.
[ X] I have tested the code thoroughly.
[ X] I have attached related issue numbers, screenshots, or videos (if applicable).
[ X] I have added comments to my code where necessary for clarity.
[ X] I have checked the existing code base and my changes do not introduce any breaking changes.
[ X] My PR addresses only one issue; I have created separate PRs for other issues.
[ X] I have ensured that the PR does not include unrelated files.
[ X] I am mindful of the project's coding standards and best practices.

thanks @Ishika-Gupta06


Unable to make it work on pythonanywhere

Hi, first, your tool is a great one, keep up the good work!
Everything is working well on my computer, but I'm unable to understand why I'm experiencing problems using it on pythonanywhere.
e.g.
pip3.7 install --user pyflightdata

f = FlightData()
f.get_airport_arrivals('GVA', page=1, limit=100)
returning en empty result, but not on my computer.

Do you know is the setup at pythonanywhere could be involved? Could you have the opportunity to quickly test it? you just create a free account and install pyflightdata with the pythonanywhere bash console and test those previously mentioned python lines.... I can't understand...
Thanks in advance,
J.

Was a pythonanywhere issue: free account is whitelisting reachable urls... paid accounts allow to reach urls used by pyflightdata.
Nothing related to pyflightdata, sorry. Let's close this one. You could even remove this issue from your list.


hotfix: fix saved gtid in replication

only save GTID when meeting XID and QUERY event.
it duplicates with #414, but we really very need this fix, so after waiting three days, I decide to file a hotfix pr for it. Thanks  @ianzapolsky very much

@amyangfei PTAL

the most correct way seems to be to not try again here, because we can't distinguish when we should save gtid, it's better to let caller handle it

@gleonid has a good solution to this in #420. Let's go with that.


codeStyle app folder

Add code style, fix spaces, tab, 3 spaces, brackets and indentation.
relate to:

https://github.com/GarageGames/Torque3D/issues/1619
https://github.com/GarageGames/Torque3D/pull/579
https://github.com/GarageGames/Torque3D/issues/22

This PR just have the app folder, later I will continue with the whole project.
@dottools ? :D

oh wait! should be 3 or 4 spaces? lol

Oh my... Well the syntax corrections look correct, but it's going to be a nightmare for people to diff against their repositories. ;)

Oh my... Well the syntax corrections look correct, but it's going to be a nightmare for people to diff against their repositories. ;)

aaaah T_T we can't never beat you with the code style nathan :( you are a heartless person lol :D

Fars it goes, I don't thiiiiiiiiink there's anything being touched this release that would conflict with alterations to the app directory, so cleanup on that one shouldn't cause any headaches with wipwork...


Would a boilerplatize command be a good idea?

Hi there,
This is a feature proposition that I would be ready to implement.
Problem right now is that maintaining the dependencies set in our boilerplate is too hard (I need to create a new project with my boilerplate, upgrade packages, change files if needed and report all changes manually in my boilerplate/ folder).
I was wondering if it would not be easier to create a command that allows you to transform a working react-native project into the boilerplate/ folder of an ignite "boilerplate plugin".
That way, I could create a new app with my boilerplate, upgrade dependencies, run my tests to verify that everything works as expected and "re-boilerplatize" it to update my boilerplate.
What do you guys think?
Or am I missing something and there's already a simple way to do that?

@GantMan @kevinvangelder Any opinion on this? 🙂

HOLY HELL!  I love it!

That would be an awesome feature.

Closing this: it's pretty stale, and as of Ignite 6, we don't support custom boilerplates any more; also, the boilerplate folder within the ignite project is a working standalone (non-expo) project, so you can work on it in place.


Allow custom user agent

It would be good to be able to set a custom user agent, so that clients using this library can abide by the User-Agent policy.
I suggest adding a new method: Wikimate::setUserAgent( string $userAgent ): void

This is to help with https://phabricator.wikimedia.org/T286099

We're just in the process of wrapping up v0.13.0, so I'll schedule this for the next release (it's a small easy addition).
Nice to see this little library in use at big Mediawiki. :)

This is now resolved in master, and will be in the v0.14.0 release.


EpiNow2 - running at scale

A large amount of the epinow2 code base comes from running at scale, we might want to flag this and could point at this (https://epiforecasts.io/posts/2022-03-25-rt-reflections/) piece for context.
Half a million people hated these graphs for a reason after all!

People also hate the logging that this brought with it. Especially SF.

Pointed at the write-up. I don't think anything more is needed for this tutorial.


"Peer's Certificate has expired."

Hi I have reinstalled my elassandra, It did fail after the last update. I am encountering an expired certificate. How can I get pass this? Thanks
**

failure: repodata/repomd.xml from Elassandra: [Errno 256] No more mirrors to try.
https://packages.elassandra.io/rpm/elassandra/repodata/repomd.xml: [Errno 14] curl#60 - "Peer's Certificate has expired."

**

Hi,
Kindly change the #6 of http://doc.elassandra.io/en/latest/install_rpm.html (this will save more time on installing) following the documentation. Thanks

rpm -qa gpg-pubkey --qf "%{version}-%{release} %{summary} f1d18d84-5724b296 gpg(Elassandra<EMAIL_ADDRESS>34ec9cba-54e38751 gpg(Fedora (23<EMAIL_ADDRESS>"

New rpm+debian packaging will be delivered in the next version.

rpm and deb packages are currently automatically built by travis and not signed.


richtext field validation error for two adjacent list items

for the following markdown content (two list items separated by empty line):
- one

- two

the richtext field displays this validation error message:

reproduction: https://github.com/stefanprobst/issue-keystatic-document-field

This was a limitation of the document field, the document field has now been deprecated and superseded by the markdoc and mdx fields which both support content like this


user12986714: Watch game79zone.com

user12986714 requests the watch of the watch_keyword game79zone\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

game79zone\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


Make a create-forgo-app tool

Most people use Create-React-App to build the scaffolding - and it's indeed quite useful to have one for Forgo. It can also set up some best practices.

This could be super simple - just clone template repos on github.com/forgojs and do an npm i after that.
Rules to identify the repos:

The cloned repo url will be https://github.com/forgojs/forgo-template-{template}-{language}
If template is not provided, then use https://github.com/forgojs/forgo-template-{language}
If language is not provided, use "javascript".

# clone https://github.com/forgojs/forgo-template-javascript into the directory myapp
create-forgo-app myapp

# clone https://github.com/forgojs/forgo-template-typescript into the directory myapp
create-forgo-app myapp -l typescript

# same as
create-forgo-app myapp --lang typescript

# clone https://github.com/forgojs/forgo-template-todos-javascript into the directory myapp
create-forgo-app myapp -t todos

# same as
create-forgo-app myapp --template todos

# clone https://github.com/forgojs/forgo-template-todos-typescript into the directory myapp
create-forgo-app myapp -t todos -l typescript

# same as
create-forgo-app myapp --template todos --lang typescript

This could be super simple - just clone template repos on github.com/forgojs and do an npm i after that.
Rules to identify the repos:

The cloned repo url will be https://github.com/forgojs/forgo-template-{template}-{language}
If template is not provided, then use https://github.com/forgojs/forgo-template-{language}
If language is not provided, use "javascript".

# clone https://github.com/forgojs/forgo-template-javascript into the directory myapp
create-forgo-app myapp

# clone https://github.com/forgojs/forgo-template-typescript into the directory myapp
create-forgo-app myapp -l typescript

# same as
create-forgo-app myapp --lang typescript

# clone https://github.com/forgojs/forgo-template-todos-javascript into the directory myapp
create-forgo-app myapp -t todos

# same as
create-forgo-app myapp --template todos

# clone https://github.com/forgojs/forgo-template-todos-typescript into the directory myapp
create-forgo-app myapp -t todos -l typescript

# same as
create-forgo-app myapp --template todos --lang typescript

This could be super simple - just clone template repos on github.com/forgojs and do an npm i after that.

Svelte uses the degit tool with template repositories in place of a dedicated command line tool. Would that plus a list of recommended templates on the website be enough for Forgo?

This could be super simple - just clone template repos on github.com/forgojs and do an npm i after that.

Svelte uses the degit tool with template repositories in place of a dedicated command line tool. Would that plus a list of recommended templates on the website be enough for Forgo?

That's a good suggestion. I've updated the README accordingly.
Will close this now. Thanks.

That's a good suggestion. I've updated the README accordingly.
Will close this now. Thanks.


[Other] Is it Support MacOS 15.1 and Xcode 16.0 Release Version

Additional Information
I updated to macOS 15.1 and Xcode 16.0 in the release version. Does our support cover this?

Yes.

Cool Thanks for your help!


A new default for displaying the menu  and options?

I wonder if you have considered another option for the default display of annotation tool menu options? It seems cumbersome to have to hover over multiple menus to be able to see all the options available. If triggering the annotation tool triggered the display of a static menu with most options visible by default, it might make the tool easier to use. Right now, it can get annoying to have to do so much hovering to select an option.

It is possible to overwrite the defaults to create you own menu. You can redefine the main menu:
"export": {
	"menu": [
		{
			"label": "Annotate Profile 1",
			"action": "draw" // uses default from drawing.menu
		},

		{
			"label": "Annotate Profile 2",
			"action": "draw",
			"menu": ["PNG","JPG","CANCEL"]
		}
	]

Or keep our main menu and adapt only the annotation menu instead:
"export": {
	"drawing": {
		"menu": [
			{
				"label": "Change color ...",
				"action": "draw.colors",
				"widths": [ "#FF000", "#000000", "#0000FF" ] // replaces the default choice
			},
			"PNG",
			"JPG",
			"CANCEL"
		]
	}
}

https://github.com/amcharts/export#annotation-settings
https://github.com/amcharts/export#-or-set-your-own-custom-options


feat: allow manage-merge-queue to paginate all PRs

The manage-merge-queue helper will now list all PRs in a repo when determining the merge queue.

:pencil: Description
:link: Related Issues

:tada: This PR is included in version 1.20.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature Request]: Flagging the two sunset/night beach levels for outside of time attack?

Describe the feature you'd like to see added
Going off the coattails of the stage transition option, would it be possible to flag the sunset/night beach levels that appear in time attack as having a chance to appear elsewhere? They're exclusive stages, but they're just lighting changes if I recall.

I just tested Howard's Course Editor and it mostly works, it's a bit buggy specially in "Heart Attack Mode".
You don't need to use FXT, works the same with fine with emoose's Tweaks (or even with no mod)
You may need to change the Scripts directory properties, uncheck the "Read only" attribute:

Oh, yeah, I'm aware that you can force it with the course editor, I was just hoping that it wouldn't be needed since that locks the race into that specific ordering.

It looks possible in principle, I was reading the thread and it seems that there was a more feature rich version in development but was not released. It even randomiced the ehe couse on the fly and could have endless loops.
It seems that it's quite hard to debbug because there are a lot of addresses pointers and it test it you need to run the courses again and again.
It took a look at the posted data, but it's above my expertise... so I'm not sure how hard could it actually be.

A working endless mode would be sweet. I think the course editor allows you to set the first track as one of the exit points in a 15-course, but I don't remember if it actually works.


TypeGraphQL Generator with Union type fails with error

Describe the bug

When generating TypeGraphQL, using a union type, the type passed to @TypeGraphQL.Field fails with the error: 'Step' only refers to a type, but is being used as a value here. (TS 2693)
To Reproduce
Steps to reproduce the behavior:
Run the generation below.

My GraphQL schema:

type PullStep @entity {
  nextSteps: [Step!] @column
  # ...other fields...
}

type PushStep @entity {
  nextSteps: [Step!] @column
  # ...other fields...
}

union Step = PullStep | PushStep

My codegen.yml config file:

generates:
  types.ts:
    plugins:
      - typescript-type-graphql

The output:

import * as TypeGraphQL from 'type-graphql';
export { TypeGraphQL };
export type Maybe<T> = T | null;
export type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
export type MakeOptional<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]?: Maybe<T[SubKey]> };
export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]: Maybe<T[SubKey]> };
export type FixDecorator<T> = T;
/** All built-in and custom scalars, mapped to their actual values */
export type Scalars = {
  ID: string;
  String: string;
  Boolean: boolean;
  Int: number;
  Float: number;
};

@TypeGraphQL.ObjectType()
export class PullStep {
  __typename?: 'PullStep';

  @TypeGraphQL.Field(type => [Step], { nullable: true })
  // ^^^^ !!! "'Step' only refers to a type, but is being used as a value here. (TS 2693)" !!!
  // ^^^^
  nextSteps!: Maybe<Array<Step>>;
};

@TypeGraphQL.ObjectType()
export class PushStep {
  __typename?: 'PushStep';

  @TypeGraphQL.Field(type => [Step], { nullable: true })
  // ^^^^ !!! "'Step' only refers to a type, but is being used as a value here. (TS 2693)" !!!
  // ^^^^
  nextSteps!: Maybe<Array<Step>>;
};

export type Step = PullStep | PushStep;

Expected behavior

No error. To fix this, it probably needs a union type generated:
https://typegraphql.com/docs/unions.html
Environment:

OS: Linux
@graphql-codegen/...: 1.21.3
NodeJS: 14

Additional context

Hey @dotansimha @Ranguna @ryall, you have any updates on this one? Work around? Fix? Thanks in advance!


State cache for A Plague Tale: Requiem

its a directx 12 game so VKD3D is required.

Cache also exists for VKD3D just like for DXVK?
I didn't know about that, hmm..

yep it does exist for vkd3d too

Thanks for this pull request, I didn't know that vkd3d-proton has a cache just like DXVK.
I created another repository just for VKD3D-Proton caches: https://github.com/begin-theadventure/vkd3d-proton-caches so open a pull request there.
Though unfortunately there is no tool like dxvk-cache-tool for vkd3d, so I won't be able to merge, see the entries, etc.

Thanks for this pull request, I didn't know that vkd3d-proton has a cache just like DXVK.
I created another repository just for VKD3D-Proton caches: https://github.com/begin-theadventure/vkd3d-proton-caches so open a pull request there.
Though unfortunately there is no tool like dxvk-cache-tool for vkd3d, so I won't be able to merge, see the entries, etc.

I asked and sharing it isn't worth it: https://github.com/HansKristian-Work/vkd3d-proton/issues/1351#issuecomment-1360152451

I asked and sharing it isn't worth it: https://github.com/HansKristian-Work/vkd3d-proton/issues/1351#issuecomment-1360152451


Replace radial menu with a context menu

Todo

[x] Fix the tooltip
[x] Remove the redundant variables for adjusting the position of svgs in edit_menu.js
[x] Fix the failing test cases

(closes #3671 )

Hey @samanpwbb can you check the screenshot here https://github.com/openstreetmap/iD/issues/3671#issuecomment-272365384
and let us know if you have any thoughts?

I think the whole form can be vertically condensed, and simplified. I would lose the semitransparent background – it's distracting and less legible than a solid background. If you make the background solid, you will be able to remove the round background fills from the action icons, which will allow you to cut a good amount of vertical space from the design. End result will be cleaner looking and easier to use.

@bhousel I feel this is done.
Could you look over it ?

I tried a white style

As per talk with @rasagy, he suggested on removing the operations which are always disabled.

As per talk with @rasagy, he suggested on removing the operations which are always disabled.
This would help reduce the height of context menu.

I know that the disabled icons were always there for discoverability.  I still think messages like "This feature can't be made circular because it's not a loop" are for users to see.
Maybe we can just make the icons smaller?  This menu doesn't need to be so much bigger than the browser's default contextmenu.
I really like the light style! 👍

@bhousel
Discoverability is important, but we don't need to overdo it. Always showing every operation seems to be too much, but this doesn't mean that we should always hide disabled operations.
We should always think about what is really required to make the specific operation sufficiently discoverable.
For example "Circularize":
Someone who is not working with nearly circular features doesn't need "Circularize".
Someone who is working with such will eventually select such a feature and discover the "Circularize" operation, even if it is shown in case of nearly circular closed features only.

I still think messages like "This feature can't be made circular because it's not a loop" are important for users to see.

Showing this message can be limited to the case of a nearly closed, nearly circular way.

Maybe we can just make the icons smaller? This menu doesn't need to be so much bigger than the browser's default contextmenu.

Doesn't this make the icons too unspecific? Otherwise I would agree.
Maybe we can reduce the height of the menu rows, but place the icons aligned in two colums alternatingly (zigzag pattern).

I know that the disabled icons were always there for discoverability. I still think messages like "This feature can't be made circular because it's not a loop" are important for users to see.

@bhousel I think the idea was not to hide all the disabled icons, but only ones that didn’t seem relevant for a particular feature. On exploring a bit with @kepta, we realized that this already happens. Here’s what we felt: actions that might be disabled due to the feature not being in the screen should be shown, since they explain why something can’t be done, but actions that won’t be possible for a feature (straight road would never be able to Circularize), it only adds more confusion.
Do you think there are more cases — like Circularize for straight roads — that would be disabled regardless of the context? If this isn’t common, then maybe we can take a quick call on hiding Circularize when it’s not relevant.

The iD architecture document mentions disabled operations a bit here:  https://github.com/openstreetmap/iD/blob/master/ARCHITECTURE.md#operations-module
I don't know who the original author of this section was, but I think it's still important to show disabled operations for discoverability.
The menu is there for teaching in addition to using.  So please keep Circularize on the menu, but disabled for straight roads.

I edited a lot with this today to test it out. Overall it's great.
I really don't miss the menu except in one situation, and that's when operations are disabled.
One example of this is:  I'd draw a building and hit 'S' to square the corners of it, and nothing would happen because too much of the building is off screen.  Normally you would be able to see the menu with the disabled icons and realize that something is preventing you from running the command.  But without a menu, I'd find myself wondering whether the command ran or not, and just keep hitting 'S', then eventually right-click to see the menu and realize what was going on.
This is a hard problem to solve elegantly.  #1734 touches on this - "Better indication when an action is selected".  That issue is, sometimes a user will do something by accident and not realize that the action happened.  But now without a menu, it's also possible for a user to try to do something on purpose and not realize when the action didn't happen.
I'm thinking for keyed operations initiated by the user, we should maybe take the message that we already use for undo/redo (e.g. "Made an area circular") and flash it in the corner of the screen.  If the operation is disabled, instead flash the disabled message "This can't be made circular because it isn't a loop".
Flash messages are really hard to get right, in a way that is tasteful, enjoyable, and delights the user instead of being annoying.  But it would close #1734 and help us replace the visual clues that we lose by not popping up the context menu on every select.  I'm going to prototype this idea and see how it turns out.

@bhousel I like the idea of notifying the user that something is not allowed. In the Mac they play that famous sound when an operation is disabled.
I just want to make sure, by flash messages, we are not planning to blink or do something fancy to grab the users attention right?
I really like the way visual studio code shows its alerts. They just overlay them on the top.

Maybe we could do something similar for iD? Showing the alert at the top (even if it hides something). Some of these alerts would go off and some wouldn't , depending on the severity.
This is also similar to how iOS shows notifications.

Maybe we could do something similar for iD? Showing the alert at the top (even if it hides something). Some of these alerts would go off and some wouldn't , depending on the severity.
This is also similar to how iOS shows notifications.

Yeah I agree, I'm going to start off displaying something small at the top and see how that looks.  I agree we don't want to be overly distracting or blinky, or have these things stack up and need to be dismissed.  And this would be only be an immediate feedback response to an action performed by the user, not just random "helpful" popups.

@kepta Just trying out different ideas.. It needs work, but it's not terrible..

@bhousel looks pretty awesome. I was looking at how other people have implemented it.
I like the way they do it in this screenshot.

Link: dialogs

Will we be showing this dialog for every operation, or just for keyboard shortcuts?

I'm just planning to try it out with keyboard shortcuts for now..
Latest version:

added the icons
support succeeded and failed operations
configurable showDuration and fadeDuration
failed operations show for slightly longer (3sec), because there more text for the user to think about

Still unsure about placement.  It's just centered at the top, which would be ok except that the buttons just above the message are left aligned.
I'll probably edit with it like this for an hour and see how it feels.

@bhousel looks really good.
I would like to see it in the bottom or top right though.....

Will we be showing this dialog for every operation, or just for keyboard shortcuts?

I'm just planning to try it out with keyboard shortcuts for now..

Hmm maybe we should just have this happen on every operation?  It might be weird for it to only happen if the user is using the keyboard shorctuts.   It seems like the sort of thing someone might open an issue about later, like "Why does the flash show up only sometimes?"

re: placement..    For now I'm going to move it to top right beside the buttons like @kepta suggested..

I do wish we had a better UI for these addons, because they are all over the place and not at all consistent.  Other tools like Illustrator or Photoshop have nice panels for stuff like this.

the iD UI has gotten spawly. I recommend placing the notice messages here:

If a black background doesn't make the flash stand out enough, try a background color:

@samanpwbb That works, and I like how unobtrusive it is..  I'll try it today..

@bhousel

I edited a lot with this today to test it out. Overall it's great.
I really don't miss the menu except in one situation, and that's when operations are disabled.
Relying on shortcuts seems to be ok for power users, but I don't think this is good for the casual users.

The radial menu is annoying when selecting a feature without intent to use the menu, but it is fine when selecting a feature with intent to use the menu. Requiring left click to select, and right click to open the new menu afterwards would be annoying too.
What we can do instead is offering two different ways to select a feature:
A left click selection which is not opening a menu, and a right click selection which is opening the menu.
In addition we can offer a right button drag based menu operation working on the current selection without selecting a new feature. There is a little issue, as we can't open the menu on right button down, because the selection to work on is unknown at this time. Instead we have to open the menu on right button up or start of dragging, but I think users would get used to it easily.

What we can do instead is offering two different ways to select a feature:
A left click selection which is not opening a menu, and a right click selection which is opening the menu.

Yes, this is how it works currently..  I also have to test this on Windows because contextmenu fires a little differently there, but I think it should be ok.  contextmenu is just the event that would fire when the default browser context menu pops up on right click.. We're stealing that event to pop up an iD menu instead.

In addition we can offer a right button drag based menu operation working on the current selection without selecting a new feature.

If we ever do support anything on right button drag, it would probably be to rotate the map.  Lots of maps (Google, Mapbox, etc) support this now, so it's pretty common.

Latest version.. I like it!  Thoughts @samanpwbb @kepta ?

@bhousel, I would love to see a different colour on it. (😅 pink looks good to me)

Final stuff:

[ ] Show operation title above tooltip
[ ] Check contextmenu/right-click especially on Windows
[ ] Check right click preventdefault (right click seems to bring up menu but not activate frame?)
[ ] Preserve backward compatibility of radial menu
[ ] Update walkthrough

This was merged!  🎉
Thanks @kepta @rasagy @samanpwbb & @slhh!

Awesome🤘
On Sun, 26 Feb 2017 at 2:03 AM, Bryan Housel<EMAIL_ADDRESS>wrote:

This was merged! 🎉
Thanks @kepta https://github.com/kepta @rasagy
https://github.com/rasagy @samanpwbb https://github.com/samanpwbb &
@slhh https://github.com/slhh!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openstreetmap/iD/pull/3753#issuecomment-282510432,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGpL7sn8-DmxxoHxDxEhXma8yYr2vTbMks5rgJAcgaJpZM4LijMP
.

Great work! Testing this in Chrome 56.0.2924.87 when I select an element and hit SPACE to bring up the edit menu, it appears in the top right of the screen, away from the selected element.

Great work! Testing this in Chrome 56.0.2924.87 when I select an element and hit SPACE to bring up the edit menu, it appears in the top right of the screen, away from the selected element.

Good catch, I notice that too.. I'll open a new issue for it..


[host_callback] Fix bug when id_tap takes no arguments but has a result.

Fixes: #5414

Wow, that was so fast!  Thank you!

Wow, that was so fast!  Thank you!


Generation of spurious CDP connections between ports that are not actually connected

This was found while testing AXCIOMA support, but has since been found in the original ATCD support, too. To reproduce (in ATCD support):

Define a CORBAInterface. Set the interface to be declared Asynchronous.
Define two monolithic components: CompA and CompB. On each, define a port, setting the port type to the above interface. Set the port in CompA to be a 'conjugate'. Mark both ports as 'asynchronous'.
Define an assembly. Add ‘a1:CompA’ and ‘b1:CompB’, and make a connection between the components.
Add another instance ‘a2:CompA’ in the assembly, without making any connections to its port.
Create a deployment plan, domain, process and node. Deploy all of these, plus the assembly in the plan.
Generate descriptors for the plan.

In this case, we expect the tool to generate three connections for 1 physical connection between ‘a1:CompA’ and ‘b1:CompB’ in the assembly of the ATCD model:

uses-port to client-side-AMI-connector (sendc -> ami_provides)
uses-port to client-side-AMI-connector (use port -> sync_provides)
client-side-AMI-connector to provides port

However, in the current support, the tool generates 3 more connections by incorrectly assuming the presence of a physical connection between ‘a2:CompA’ and ‘b1:CompB’.
Root cause is that while retrieving connectors for an asynchronous port, the code generator considers all the connectors available in the container assembly that have the given port in one end without taking the CCMPart into account which is the owner of the given port.
See the attached example where we expect 9 connections to be generated, but the tool generates 12 connections.
SimplifiedDiningPhilosophers.zip

Fix is provided for this issue. However, a related issue is created: issue #6.


Failed to switch servers

Installed by winget , always can't switch servers .
And i want to know how to show the number of sedding/downloading torrent.

Could you provide log files
(top bar menu -> Info -> Open Logs)

will be fixed soon for develop branch
Try switch to beta updates to receive it early
(Kebler -> Kebler Preferences) and set AllowPreRelease=True

And i want to know how to show the number of sedding/downloading torrent.

Will add it on next Release (1-2 weeks depends on my free time)

@zfro Beta build contains category counting feature now. If works correctly, in few days will be release


Support left hand

Finally figured out the non-write defaults trick! I believe the Lila avatar has done it for a while now, but I could never figure out what was different. Basically, the right hand default animation should set no blend shapes. If the right hand is on the default animation, this allows the left hand to do stuff. If the left hand then goes to default, then its default animation is successfully able to reset the blend shapes back, and there's no need for the right hand to do it.
EZFXLayer isn't really designed to be able to do that, since animations are supposed to contain the full set of blend shapes and game objects (animatables) across the layer as defined in the reference animation.
This needs more thought than I feel like putting in right now, but there are a couple obvious options:

An option to make the an animation empty.
A redesign to separate the set of animatables and the reference animation. Reference animation -> Reference. New components come with an initial animation, and it can even be removed to make marker layers way more obvious.
Allow overriding the set of animatables in an animation (in combination with the above to fit this scenario).
A new component that doesn't have a base set of animatables. In addition to supporting this scenario, the main story behind it is supporting simple configuration authoring while having more control over what gets animated. Also a note to add a button to copy a specific animation.

Still undecided, but will probably go the following route:

Add the quick and easy option
Add a new issue for the redesign and for overriding sets of animatables
Do the redesign
Support overriding and remove support for and auto-convert the empty animation option

Before releasing 1.1.0, since not a lot of people are using this tool yet, want to get this design finalized, particularly with respect to how serialization changes. Therefore, keeping this in the milestone, but probably won't actually implement anything before its release.

Decided to do the redesign now, which is underway. Done is the design to separate the reference animation into an animation and a reference. Next will be supporting adding and removing animatables to/from animations, detached from the reference.
One design issue is what happens when the reference is given an animatable already contained in an animation. I don't think there's any reason to keep them detached, so we'll probably link them together.
Also a note that having unit tests for this part of EZFXLayer is now in-scope, since the ui code is pretty complicated.


Add new endpoint giving simple rustdoc status for a version

As discussed in #2144, this adds a new endpoint for simply requesting whether docs are available for a specific version, without exposing other details about our builds.
I've also fixed the metrics recording /builds.json requests as being "static resource" stopping us from being able to see how many requests we get, that will let us verify whether there's any other clients hitting that endpoint once shields.io/crates.io/lib.rs have migrated over.

@Nemo157 after manually testing, I saw one thing:
we do seem to follow semver logic, so a request to /crate/itertools/0.10.0/status.json, where 0.10.0 doesn't exist, would lead to the endpoint returning the status for 0.10.5 (the latest semver for this).
Seeing the two use-cases I can imagine:

shields.io will request /latest/ (?)
crates.io will request a specific version

Perhaps I'm missing another case?
for the crates.io case I could imagine some edge-cases where the status for a version would be returned that crates.io didn't request. Though this could currently only happen when we're missing a version that is not the latest of that semver bracket.
Would crates.io check the returned version? Or should we perhaps return a redirect similar to the builds.json endpoint? ( crates.io would need to ignore that one too then).

Huh, interesting, likely the only reason that crates.io doesn't make that mistake right now is that the redirect is lacking a CORS header. Testing on https://crates.io/crates/stylish-core/0.1.0 (which isn't on docs.rs because of weird reasons around cyclic dependencies, but 0.1.1 is):
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://docs.rs/crate/stylish-core/0.1.0/builds.json. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 302.

I could make it only support exact or latest, and return an error on semver matches still, or when changing crates.io to use this endpoint make it do a request to /={version}/.

I could make it only support exact or latest, and return an error on semver matches still, or when changing crates.io to use this endpoint make it do a request to /={version}/.

Sleeping over it, expecting the latter sounds like a valid approach.
That means the only remaining question (for me, right now) seems to be:
so we want consistency with the other pages, and the builds.json endpoint? Because in these, we have redirects for semver matches.

@kornelski given lib.rs' source has gone private, would you be able to migrate to this new API? https://docs.rs/crate/{crate}/{version}/status.json returning a simple { doc_status: boolean, version: string } response. (The version parameter can be a semver matcher, if you want to do exact versioning like I'm recommending for crates.io you should use ={version}, but since you don't have per-version pages I'm not sure if that'd be the best approach).


More Options for URL construction ( Retain query parameters and allow Key-Value pairs)

In one of the requirements I needed all the Query Params for URL construction but this was impossible with current tag.
To illustrate it more lets have this forum question https://groups.google.com/forum/#!msg/chicagoboss/IQ0d1DBKgAM/j8Asd8WPjTYJ where Evan Miller suggested/intended doing {% url foo="bar" _req.query_params %} . However this doesn't work as Variables get values like
[
 {foo, <<"bar">>},
 [
  {first_param, "x"},
  {second_param, "y"}
 ]
].

which goes unhandled by lists:map.
This can be resolved if we do a lists:flatten.

We can send nested arrays in query parameters. If you flatten them, you can lost their structure and in most cases, make a huge mess with your data.
Actually, I will appreciate if you will explain bit more about your requirements

As I understand from the code, specifically from this expression:-
    ListVars = lists:map(fun
            ({K, V}) when is_binary(V) -> {K, binary_to_list(V)};
            ({K, V}) -> {K, V}
        end, Variables),

only key-value pairs or elements of proplists are allowed in Variables List (I will say it fun constraint). So any nested arrays/List should be with their key. Since lists:flatten only works on deeplist it will not destroy any other list as if there is any list, it will obviously be inside a tuple (fun constraint). Example:-
%% This is what will happen (lists inside tuple are preserved) -->
lists:flatten([{k1,v1}, {k2, v2}, {k3, [v31, v32, v33, v34]} ]).
%% Output:- [{k1,v1},{k2,v2},{k3,[v31,v32,v33,v34]}]

%% Though this kind of list (nested array) will loose its flavor, but this is not gonna processed by our fun param constraint. It will be an error anyway.
lists:flatten([{k1,v1}, {k2, v2}, {k3, [v31, v32, v33, v34]} , [discard1, discard2, discard3], {k4, v4} ]).
%% Output:- [{k1,v1}, {k2,v2}, {k3,[v31,v32,v33,v34]}, discard1,discard2,discard3, {k4,v4}]

My Requirement
Many times you might like to add another proplist in the url tag as in case, you need all the url parameters (which is already available as a list in _req.query_params). For that you might choose to operate on query params before, right in controller and make them suitable for url tag or in my case, just pass the proplist as it is, and url tag will automatically process it.
Please let me know if I am unclear somewhere or if I am missing something.


Replace blacklist with denylist and use Larastan Org

Updates blacklist to denylist from one of the alternatives recommended (sample: https://github.com/ietf/terminology#alternative-terminology). The purpose is to use more inclusive and non-biased language. The changes align with industry-wide movement for inclusive terminology.
Starting with Larastan 2.7.0, the Larastan repository will now be managed under the Larastan organization.

Thanks


JSON.mapping cannot have properties key

Given the following code:
require "json"

class Foo
  JSON.mapping(
    properties: Hash(String, String),
  )
end

p Foo.from_json({
  properties: { "foo" => "bar" },
}.to_json)

This doesn't work, but if you change properties to something else, it does. properties doesn't appear to be a language keyword, so I don't think it's the same problem as #284, but I figure it might be caused by properties being used in the JSON.mapping macro.
I'm currently making it work with props: { type: JSON::Any, key: "properties" }, but if properties isn't already a method on a JSON-mapped class, it makes sense to be able to use it.

Yes, in this case, the call to JSON.mapping is interpreted as assigning the named argument properties.
You can solve this easily by wrapping the hash in curly braces:
  JSON.mapping({
    properties: Hash(String, String),
  })

You can use it like this:
require "json"

class Foo
  JSON.mapping({
    properties: Hash(String, String),
  })
end

p Foo.from_json({ properties: { "foo" => "bar" }, }.to_json)

https://carc.in/#/r/27ny
Note that I'm passing a NamedTuple to JSON.mapping, not directly the fields as args

Considering that the notation without braces is encouraged by the example in the API docs and properties is a very likely name used in a JSON mapping, it would be great to rename the argument to something less like to conflict. It should usually not be required to actually address this named parameter.

Isn't this be solved by #236?
Could you see does it still happen on the master branch?

No, this is not related.
The signature of JSON.mapping is
macro def mapping(properties, strict = false)

When you call it like in the above example, the compiler assumes, properties: refers to the named argument of the macro call while instead is it intended to be a field in the named tuple that is the value of that argument.

So this issue could be avoided for the specific value of properties by changing the macro declaration to be:
macro def mapping(mapping_properties, strict = false)

I realize that doesn't really solve anything, it just changes where the collision occurs.

... and thus makes a collision less likely.

Whatever name we choose, there will always be the possibility of a collision. There's also the strict parameter. If named arguments give you a conflict, pass a hash literal as mentioned. I don't think this is easily solvable.
We can maybe remove the named arguments overload.

strict is not really an issue. A TupleLiteral with strict: will be matched as value for the required argument properties: https://carc.in/#/r/27v8

We can maybe remove the named arguments overload.

Is it currently possible to remove an argument from name-matching?
If this can be done, it would be great. Otherwise, changing the (external) name to something with lower risk of name collision would be a reasonable improvement.

@straight-shoota I think @asterite mean that as a change in the compiler.
Syntax-wise I think we could allow _ as an external name that will disallow to make the call with named argument for that, hence making a positional arg only.
But is definitely simpler for now to change that name for now. Adding that kind of syntax seems nice and neat, but there are thing to check and disallow when mixing many _ and named arguments and mandatory named arguments.

Oh, yes, I think we can just rename properties to _properties or even _properties_ to make the collision less probable.

As #5180 has been merged, can we close this issue?


"Label image data using GPT-4o" doesn't pick up the dataset when in "object detection" mode.

Hi,
Thanks @furtiman for helping me debug this issue.
you can see the logs in the this project.
Here are the steps I tried:

Start a new Enterprise project and clicked "yes" when I was asked: "Are you building an object detection project?" then uploaded some data to my dataset in the project.
Followed the youtube guide for using GPT for labelling, so I created a transformation block and selected "Label image data using GPT-4o"
used the following prompt:
What road speed limit signs do you see in this image? Respond only with the speed limit like  "30", "40", etc or "unsure" if you're not sure.
Submitted the task and here is the logs:

Loading logs for 18648488...
Scheduling job in cluster...
Pulling container image...
Pulling container image...
Container image pulled!
Job started
Labeling unlabeled data for "Edge Impulse Inc. / GPT Labelling issue"
Prompt: "What road speed limit signs do you see in this image? Respond only with the speed limit like  "30", "40", etc or "unsure" if you\'re not sure."
Disable samples with labels: unsure
Limit no. of samples to label to: 1,000
Concurrency: 10
Auto-convert videos: No

Finding unlabeled data...
Finding unlabeled data OK (found 0 samples)

Labeling 0 samples...
[0/0] Labeling samples... (error=0)
Done labeling samples, goodbye!

Job completed (success)

as you can see its not picking up any images to label despite having a lot of unlabelled images in my dataset.
I later realised when I change the object detection mode to one label per item mode the problem gets resolved.
@furtiman : "This is not necessarily a bug but an issue would be to improve how the block communicated - perhaps it can log a message that the dataset is in another mode and notify the user"

We're changing this flow with AI Actions, and it will no longer find unlabeled data, but rather be explicit about what data to label (Studio is in control).


Horizontal List View

Hi
First of all Thank you for making this package.
is there a way to make a horizontal super sliver list?

SuperSliverList should be axis agnostic. Have you tried specifying horizontal axis direction when creating the CustomScrollView?

no i did not, but if i have over slivers that i want to be vertical?
thanks for the fast response by the way.


Productivity idea, related to selecting proposed options by keyboard number 1-9

Please consider implementing a feature where, in the proposed code options, clicking a number on the keyboard selects the corresponding option displayed under that number.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

salom

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


add stu.xidian.edu.cn

add domain stu.xidian.edu.cn,Students of Xidian University will use it.

@fengdefangxiang Pull request merged. Thank you!


Landing Zones perspective in Enterprise Scale

Describe the solution you'd like
My experience in design principles I try to push now in Enterprise Scale type deployment would be to consider Landing Zones a potential parallel to the "Product". I.e. not just one Application, which could be misunderstood for an app services, but more as the whole solution.
I would argue that in a DevOps culture and the autonomy requirements, the landing zone as a dedicated subscription and set of resources all required with just a Enterprise level push of policy driven governance, is the right way to have enablement of the flow for value creation.
As described in the ES design you then share the core resources from the hub/platform subscription, e.g. APIM as a pivotal resources to share APIs internally (between products) or externally.
Not sure if this request is for this repo or the docs page.
Cheers
Manu

Thank you @ManuInNZ for your feedback apologize for the delay. In ESLZ we are focusing on platform architecture and what needs to be true before an application/workload/product can be deployed to Azure. Working with customers we have seen a lot of different names used for the ressource used to build a "workload". This comes down to the company nomenclature.
However we have started to look into workload specific LZ design and guidance. Can you share more information and requirements on your customer sceanrio?

Perfect, will reach out to via teams.


[FLINK-35877] Shade protobuf in flink

What is the purpose of the change
Shade the classes in protobuf to avoid class conflict.
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Which part of the Flink runtime/system relies on Protobuf, that would justify shading Protobuf?

This is mainly to avoid the dependency conflict between the protobuf used in the developer's code and flink itself.  protobuf is very commonly used in development.

Thanks for the contribution. I left 2 minor comments.

Done~

Hi @MartijnVisser , This is mainly for shading protobuf dependency in SQL format jars (ORC, protobuf) and flink-python. They are all not in the default distribution. So no changes in Flink runtime/system. If you don't have other concerns, I will merge this PR.

Martijn is away on vacation. I will merge this PR first. We can revisit it if there is any concerns.


Always refresh on result NULL

A cashable option to always request DB if cached result is NULL

Extended option now allows this scenario.


MbedTLS/TF-M usability improvements for PSA APIs

Linked PRs

https://github.com/zephyrproject-rtos/mbedtls/pull/43
https://github.com/zephyrproject-rtos/trusted-firmware-m/pull/92

Description
Previously, Zephyr's mbedtls module's cmake build created a single static library, rather than the collection of libraries (mbedtls, mbedcrypto, and mbedx509) that upstream mbedTLS cmake provides.
To give better control at link time to choose the required libraries to link in, this commit updates the Zephyr MbedTLS module to also define three distinct libraries rather than a single static MbedTLS library.
One benefit of the three library approach is that if mbedTLS is used in Zephyr in the the non-secure application in addition to TFM's PSA Crypto API on the secure side with TF-M, PSA API calls on the non-secure side will be redirected to the TFM PSA implementation, and the mbedcrypto library will only be linked to the secure (TF-M) binary, with the mbedtls and mbedx509 libraries linked against the non-secure (Zephyr) binary, enabling TLS calls to PSA crypto to be redirected to mbedcrypto in the secure partition and avoiding function duplication in the non-secure binary.
Additional Changes
Re-commits the psa_crypto sample, which had to be removed during the TF-M 1.7.0 update due to unresolvable linker issues with MbedTLS as a single static library.
Fixes #56995

1c1dd384b877bf6b3fa66bfb9ba85c2528994c5d -> can we make this include path automatic when CONFIG_MBEDTLS is selected ? That is breaking the current usage and and it is not the common pattern on Zephyr AFAIR.
Other than that looks good to me.

1c1dd384b877bf6b3fa66bfb9ba85c2528994c5d -> can we make this include path automatic when CONFIG_MBEDTLS is selected ? That is breaking the current usage and and it is not the common pattern on Zephyr AFAIR.
Other than that looks good to me.

Thanks for the feedback, Flavio. There is a precedent for this here, for example: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/net/lib/sockets/CMakeLists.txt#L35 ... but can you point to an example of what you'd like to see here instead?

@joerchan @nordicjm Mind having another look to try to get this in before the freeze Friday? Thanks.

I want to be stricter in what are exposed in interface include paths.
sha512.h could be define by other modules for example. mbedtls/sh512.h is very clear.

I would say this is already taken care of in the mbedTLS sha512.h file if the user defines this flag: https://github.com/zephyrproject-rtos/mbedtls/blob/zephyr/include/mbedtls/sha512.h#L40.
Please let me know if there is any other mbedTLS header file that may have a problem like that.

I want to be stricter in what are exposed in interface include paths.
sha512.h could be define by other modules for example. mbedtls/sh512.h is very clear.

@ joerchan I would say this is already taken care of in the mbedTLS sha512.h file if the user defines this flag: https://github.com/zephyrproject-rtos/mbedtls/blob/zephyr/include/mbedtls/sha512.h#L40.
Please let me know if there is any other mbedTLS header file that may have a problem like that.

You misunderstood me, I'm not talking about mbedtls ALT headers for sh512. I'm talking about other modules having their own sh512 header.
In zephyr you can include:
<tinycrypt/sha512>
<mbedtls/sha512>
If you include:
<sha512.h>
Then which one would you get?
The hostap module (Wi-FI) for example has a sha512.h header file that will be included like "sha512.h". Now I have to make sure that correct sha header file is included by looking at header file path order.
So I don't want "include/mbedtls" on the include path for this reason.

I want to be stricter in what are exposed in interface include paths.
sha512.h could be define by other modules for example. mbedtls/sh512.h is very clear.

@ joerchan I would say this is already taken care of in the mbedTLS sha512.h file if the user defines this flag: https://github.com/zephyrproject-rtos/mbedtls/blob/zephyr/include/mbedtls/sha512.h#L40.
Please let me know if there is any other mbedTLS header file that may have a problem like that.

You misunderstood me, I'm not talking about mbedtls ALT headers for sh512. I'm talking about other modules having their own sh512 header.
In zephyr you can include: <tinycrypt/sha512.h> <mbedtls/sha512.h> If you include: <sha512.h> Then which one would you get?
The hostap module (Wi-FI) for example has a sha512.h header file that will be included like "sha512.h". Now I have to make sure that correct sha header file is included by looking at header file path order.
So I don't want "include/mbedtls" and "include/psa" on the include path for this reason.

Sorry, as you said, I misunderstood. I made the library include path changes pushed here already; please review and approve if you are okay with the final changes.

Thanks @rajkan01  Looks good to me now.


Add configuration for thumbnail size

Thumbnail size should be a application.yml property

Once this is implemented, SAGE will need to be updated to use it:
https://github.com/TAMULib/SAGE/pull/254


#676 ref for FileUpload

Add ref in FileUpload for controlling file window.

Somehow this PR broke the test suite. Please run npm run test on your branch to confirm tests are passing before committing changes.

retest this please

Build pass after rebuild, weird


bump components-core ~3.1.0-1 => ~3.1.0-2

This PR was unnecessary.
See https://github.com/ministryofjustice/fb-runner-node/blob/master/components.md
Pinning default version used by the runner on


Problems with backup

Hello,
When I try to start a backup via the Backup Manager, I always get the error:

I have changed the owner of the users, backup and cache folder to root:apache end changed the permissions to 775, but I still got the error.

Sorry for the late reply. It should not be necessary to change permissions in a standard environment. I will see if I can reproduce the error.


Apply for Approver Role

I apply for Approver role of repo kubevela.
Have 22 PRs totally for  all of the repos so far.

great, thanks for all your contributions!
+1 from myside!

great, thanks for all your contributions!

Thanks your contributions for addon and other areas! +1

Steven has been very active in the community, I think he can be a qualified approver.
LGTM and thanks for the contributions!

Since there're a majority votes for approval! Congratulations! @StevenLeiZhang

Great! I see you are active in multiple areas of KubeVela. Looking forward to more proposals and contributions from you.
+1 from myside!

Since there're two Maintainers vote for approval, according to our community rules, congratulations! @StevenLeiZhang