Gaia margin cache catalog on Epyc has a wrong index dtype and misses its name

Bug report
Gaia margin catalog on epyc has a weird metadata for the index - it has name of __index_level_0__ (vs _hipscat_index for "normal" catalogs) and dtype of int64 (vs uint64)
with fsspec.open('https://epyc.astro.washington.edu/~lincc-frameworks/hipscat_surveys/gaia_dr3/gaia_10arcs/_common_metadata') as f:
    meta = pa.parquet.read_metadata(f)
meta.schema

...
  optional int64 field_id=-1 __index_level_0__;

Before submitting
Please check the following:

[ ] I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
[ ] I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
[ ] If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.

Related to https://github.com/astronomy-commons/lsdb/issues/335#issuecomment-2130344301


"Petrisat" is listed in the drop-down menu

Description:
"Petrisat" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Petrisat" in the search bar.

Expected results
The location is listed in the drop-down menu as "Petrisat, Alba (Blaj)".


Handler function signature is function(event, direction)

Maybe I am missing something but I had to adjust to get this to work with latest jquery waypoint. The handler function signature is function(event, direction) where event is a standard jQuery Event Object and direction is a string, either 'down' or 'up' indicating which direction the user is scrolling.

@fcsobel What version of jQuery waypoints does this not work with? The project's bower file specifies ~2.0.5, so unless they broke BC in a patch version not sure how that is possible.

Using 3.1.1 waypoints so makes sense

@fcsobel Thanks for the PR.  I wasn't aware of waypoints v3.  It looks like it doesn't use jQuery as a dependency.  We could try to support it, but I think we would need to release angular-waypoints v2.0 since this is a BC break (notice your PR breaks our travis tests).  Also, we'd need to review what other BC changes they have made from jQuery waypoints 2.0.5

@fcsobel FYI, I was researching the new Waypoints 3 API in order to upgrade our library to use the latest verion; it seems that the function signature for the handler has not changed.  As you can see here, they still only pass the direction to the callback, not an event.
(Incidentally, none of the documentation in their API docs mention an event either)


Normalize clusters

Do not add duplicate clusters. This could happen if there are conflicting service definitions. This may help
https://github.com/istio/istio/issues/7869, but it looks like the root cause is elsewhere.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf
If they are not already assigned, you can assign the PR to them by writing /assign @ijsnellf in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5595161a457f7149eb3071d15e23a073fd2a25f6
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5595161a457f7149eb3071d15e23a073fd2a25f6
link
/test istio-unit-tests

prow/e2e-dashboard.sh
5595161a457f7149eb3071d15e23a073fd2a25f6
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
/test e2e-dashboard

/hold - please add at least the metric and improve the log.
Keep in mind the log will be repeated once per connected endpoint, on each push. So maybe you want to log at the end of the push (like we do to other verbose logs), using push context

@costinm this code is already in master as well. I am going to merge this and fix up in the PR I am about to submit..


IE 10 - Problem with the "MutationObserver" workaround

Hi.
I've been having a problem with IE 10 when i create a custom element and, in the postRender, i try to move another custom element inside the first one. Because the "DOMNodeInserted" is triggered and the cycle of the "onDOMNode" begins. The child element starts the createdCallback but when is appended isn't rendered.
For example:
/* This is called inside the cycle of the createdCallback */
postRender: function() {
var contentEl = this.querySelector('.parent-content'),
    child = this.querySelector('.child'),
    item,
    i = 0;

while (child.children.length > 0) {
      item = child.children[0];
      contentEl.appendChild(item);
}

}
The "item" appended is a custom element but it's shown without rendering.
In the browsers that support  the "MutationObserver" this works fine.
I've been searching but can't find a solution. Someone else can reproduce it?

can you please provide a basic page to test? I don;'t know what is postRender, I don't know where are those elements, and I actually don't understand what you are trying to do because to me it looks like you are re-appending to the same container same elements that where already there.
Thanks for helping figuring out this one (also, IE10 which one? where?)

@matias91 can you please provide a basic test or even test with latest and tell me if there's still a problem?

closing until I have a proper bug to work on.

Sorry, @WebReflection, i was busy.
The problem we have is when we try to move (append, remove) elements that are not rendered.
We found that the problem is in the polyfill of the mutationObserver in IE 10.
If the browser doesn't support  mutationObserver, you attach two events:
document.addEventListener('DOMNodeInserted', onDOMNode(ATTACHED));
document.addEventListener('DOMNodeRemoved', onDOMNode(DETACHED));
This doesn't emulate the full behavior of the mutationObserver.
So, when a element is attached or detached the "createdCallback" is triggered.
We fixed this adding a polyfill for the IE 10 mutationObserver.
Sorry for the delay.
Regards.

So, when a element is attached or detached the "createdCallback" is triggered.

this makes little sense to me ... the createdCallback is invoked only once per node lifecycle. This can trigger at any time and might be asyncronous, but it should be triggered as node setup before anything else (and always before the attachedCallback)
I really would like to have a basic page example to test the problem, but I'd also wouldn't mind a link to such MutationObserver polyfill you used so that others might use it as similar solution if needed.
Thanks.

Yes, you are right, the createdCallback is always invoked once. But in our case the problem is "when" is invoked, because we are appending a custom element (childNode) inside the createdCallback lifecycle of another custom element (parentNode), this starts the createdCallback of the childNode when the cycle of the parent didn't finish. This flow doesn't happen in the browsers that support mutationobserver.
I will try to make an example later, because i'm at work now.
This is the link of the polyfill:
https://github.com/megawac/MutationObserver.js/blob/master/MutationObserver.js
Thanks!

this starts the createdCallback of the childNode when the cycle of the parent didn't finish. This flow doesn't happen in the browsers that support mutationobserver.

OK, this makes more sense ... yes, MutationObserver are indeed asynchronous so this case shouldn't happen. I see if I can debounce the creation somehow in code, reopening for now.

@matias91 do you mind testing one of the latest build files removing that polyfill and tell me if everything is fine now?
I should have made the invocation asynchronous which is similar to what MutationObserver does ... I don't mind using that poly upfront, when and if needed, but it looks/feel a very greedy solution that won't probably scale with huge documents.
Thank you

@WebReflection, all works great now!
IE 10 follows the correct flow. Thanks for the patience and for the support!
Now we don't need to use another polyfill.
Thanks a lot!

thank you for the report. This has been flagged as 0.4.0 and will be hopefully soon available in the CDN.


Sprig does not check the Schema Version when loading data

there is a risk to load fixtures which are for the incorrect DB schema version -- resulting in incorrectly loaded tables/data.
See also: Sprig is not using a transaction when loading the data

Thanks @tilo! We'll get started looking into both these issues this week and keep you posted.

Lawson

@tilo could you provide a sample of how you could envision a fix working. How would you tie a particular schema version to the set of seed data? Via top-level configuration? Seed file config?
All the solutions I'm coming up with seem like they would create a lot of busywork updating config every time you created a new migration.


Fix Helm upgrade compatibility

Review commit-by-commit.
Here's the diff between a v1.7 configmap generated from the tip of v1.7 against the new v1.9 configmap generated with --set upgradeCompatibility=1.7 using this PR:
$ diff -u cilium-1.7-cm.yaml cilium-1.9-with-17-compat-cm.yaml
--- cilium-1.7-cm.yaml  2020-10-21 22:12:29.611909244 -0700
+++ cilium-1.9-with-17-compat-cm.yaml   2020-10-21 22:34:07.738427408 -0700
@@ -1,4 +1,4 @@
-# Source: cilium/charts/config/templates/configmap.yaml
+# Source: cilium/templates/cilium-configmap.yaml
 apiVersion: v1
 kind: ConfigMap
 metadata:
@@ -17,6 +17,7 @@
   #   the kvstore by commenting out the identity-allocation-mode below, or
   #   setting it to "kvstore".
   identity-allocation-mode: crd
+  cilium-endpoint-gc-interval: "5m0s"

   # If you want to run cilium in debug mode change this value to true
   debug: "false"
@@ -28,7 +29,9 @@
   # Enable IPv6 addressing. If enabled, all endpoints are allocated an IPv6
   # address.
   enable-ipv6: "false"
-
+  # Users who wish to specify their own custom CNI configuration file must set
+  # custom-cni-conf to "true", otherwise Cilium may overwrite the configuration.
+  custom-cni-conf: "false"
   # If you want cilium monitor to aggregate tracing for packets, set this level
   # to "low", "medium", or "maximum". The higher the level, the less packets
   # that will be seen in monitor output.
@@ -45,8 +48,7 @@
   #
   # Only effective when monitor aggregation is set to "medium" or higher.
   monitor-aggregation-flags: all
-
-  # ct-global-max-entries-* specifies the maximum number of connections
+  # bpf-ct-global-*-max specifies the maximum number of connections
   # supported across all endpoints, split by protocol: tcp or other. One pair
   # of maps uses these values for IPv4 connections, and another pair of maps
   # use these values for IPv6 connections.
@@ -56,14 +58,15 @@
   # policy drops or a change in loadbalancing decisions for a connection.
   #
   # For users upgrading from Cilium 1.2 or earlier, to minimize disruption
-  # during the upgrade process, comment out these options.
+  # during the upgrade process, set bpf-ct-global-tcp-max to 1000000.
   bpf-ct-global-tcp-max: "524288"
   bpf-ct-global-any-max: "262144"
-
-  # bpf-policy-map-max specified the maximum number of entries in endpoint
+  # bpf-policy-map-max specifies the maximum number of entries in endpoint
   # policy map (per endpoint)
   bpf-policy-map-max: "16384"
-
+  # bpf-lb-map-max specifies the maximum number of entries in bpf lb service,
+  # backend and affinity maps.
+  bpf-lb-map-max: "65536"
   # Pre-allocation of map entries allows per-packet latency to be reduced, at
   # the expense of up-front memory allocation for the entries in the maps. The
   # default value below will minimize memory usage in the default installation;
@@ -95,42 +98,33 @@

   # Name of the cluster. Only relevant when building a mesh of clusters.
   cluster-name: default
-
-  # DNS Polling periodically issues a DNS lookup for each `matchName` from
-  # cilium-agent. The result is used to regenerate endpoint policy.
-  # DNS lookups are repeated with an interval of 5 seconds, and are made for
-  # A(IPv4) and AAAA(IPv6) addresses. Should a lookup fail, the most recent IP
-  # data is used instead. An IP change will trigger a regeneration of the Cilium
-  # policy for each endpoint and increment the per cilium-agent policy
-  # repository revision.
-  #
-  # This option is disabled by default starting from version 1.4.x in favor
-  # of a more powerful DNS proxy-based implementation, see [0] for details.
-  # Enable this option if you want to use FQDN policies but do not want to use
-  # the DNS proxy.
-  #
-  # To ease upgrade, users may opt to set this option to "true".
-  # Otherwise please refer to the Upgrade Guide [1] which explains how to
-  # prepare policy rules for upgrade.
-  #
-  # [0] http://docs.cilium.io/en/stable/policy/language/#dns-based
-  # [1] http://docs.cilium.io/en/stable/install/upgrade/#changes-that-may-require-action
-  tofqdns-enable-poller: "false"
+  # Enables L7 proxy for L7 policy enforcement and visibility
+  enable-l7-proxy: "true"

   # wait-bpf-mount makes init container wait until bpf filesystem is mounted
   wait-bpf-mount: "false"

   masquerade: "true"
+
   enable-xt-socket-fallback: "true"
   install-iptables-rules: "true"
+
   auto-direct-node-routes: "false"
+  enable-bandwidth-manager: "false"
   kube-proxy-replacement:  "probe"
-  enable-host-reachable-services: "false"
-  enable-external-ips: "false"
-  enable-node-port: "false"
+  kube-proxy-replacement-healthz-bind-address: ""
   enable-health-check-nodeport: "true"
   node-port-bind-protection: "true"
   enable-auto-protect-node-port-range: "true"
   enable-endpoint-health-checking: "true"
+  enable-health-checking: "true"
   enable-well-known-identities: "false"
   enable-remote-node-identity: "true"
+  # Enable Hubble gRPC service.
+  enable-hubble: "true"
+  # UNIX domain socket for Hubble server to listen to.
+  hubble-socket-path:  "/var/run/cilium/hubble.sock"
+  ipam: "cluster-pool"
+  cluster-pool-ipv4-cidr: "<IP_ADDRESS>/8"
+  cluster-pool-ipv4-mask-size: "24"
+

Basically this represents the eventual set of options that someone would end up with if they upgrade first from 1.7 to 1.8 (with --set config.upgradeCompatibility=1.7) to 1.9 (with --set upgradeCompatibility=1.7).
Related: #12288
Related: #13650

Summary of brief discussion of the cluster-pool option on Slack:
cluster-pool was introduced in 1.8, and is set as the default during upgrade, unless the user overrides the configuration by manually specifying (as helm args or via values file). So it's fine that it is added during this upgrade path (since I haven't explicitly configured IPAM).

Also from Slack:
   kube-proxy-replacement:  "probe"
-  enable-host-reachable-services: "false"
-  enable-external-ips: "false"
-  enable-node-port: "false"

Since kube-proxy-replacement is set to probe, the probe will take precedence so the previous setting of these other options to false was a no-op. So fine to remove during upgrade.

test-me-please

Scaling gke cluster failed:
https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/2916/
11:28:22  ERROR: (gcloud.container.clusters.resize) FAILED_PRECONDITION: Operation operation-1603391301625-8eb1c018 is currently operating on cluster cilium-ci-18. Please wait and try again once it is done.

Will retry.

test-gke

4.19 test hit what looks like a variation on known flake #13552.

Only checks are the false negative coveralls and known flake. Merging.


Added use-case for DVC on remote storage

I have used spotty for creating spot instances on AWS. I got confused how to do dvc remote and further. Please check this out and help me.
#Fix 194

Hi @Naba7 ! Please, read the documentation contributing guide and make sure you are submitting a proper Markdown file. Second, from what I briefly saw, it is still requires a lot of work. I would recommend you to start with something smaller. Pick one of the commands in the commands references and improve, improve an example in it, etc.


Ubuntu latest: Ansible failed to run task with json_query filter

Description
Ubuntu latest runner has missing ansible required modules.
Fixed by purging ansible installed by pipX and installing it globally by apt-get
- name: "purge pipx ansible"
  run: |
    sudo pipx uninstall-all --verbose
- name: "install ansible"
  run: |
    sudo apt-get update
    sudo apt-get install --yes ansible python3-boto3
    ansible-galaxy collection install amazon.aws:4.3.0

Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
 Error was a <class 'ansible.errors.AnsibleError'>, original message: You need to install "jmespath" prior to running json_query filter

Run any provisioning which requires jmespath
Is it regression?
ubutnu-latest
Expected behavior
Provided ansible on the image should works with all expected required dependencies.
Actual behavior
Error was a <class 'ansible.errors.AnsibleError'>, original message: You need to install \"jmespath\" prior to running json_query filter"
Repro steps
{{ ansible_mounts|json_query('[].size_total')|max }}

Hi @Hellseher and thank you, we will check it.

Hi @Hellseher , can you provide minimal repro steps?

We install "ansible core" which provides significantly fewer Ansible plugins and modules than "Ansible Engine". There are also a number of filters that are no longer included in Ansible Core, such as json_query, ipaddr, and others. At that moment we have no plans to install additional modules or filters. If you need the full version of Ansible, you can install it runtime.
If you have any questions feel free to reach us.


[Feature Request]: Add option to enable line numbers on the left margin

I do agree that this feature is useful even for plain text editor. However, it is not easy to do with my current approach (implementation related). I will revisit this later.

Adding line number to the RichEditBox is a problem, it seems can not set a fixed line height, but you can use TextRange.GetPoint() to get the position of a line.
This is my old editor, and it also uses RichEditBox,
it supports line number && code highlight
https://github.com/Duronsoft/Just_Editor_UWP_Old
You can also check this new one, it uses my custom input controls
https://github.com/Duronsoft/Just_Editor_UWP

@Duronsoft  thx for the tip, I was trying the similar way but ends up with misaligned line number and line content. It starts to getting off a little bit after few thousand lines so I completely gave up.

@JasonStein

I found a new solution to get line height, it needs Direct2D API, I guess win2d also provides something similar, maybe you could try that.

Any news? line numbers would be awesome

@beerisgood I guess the best solution is to create a custom control, it means a lot of changes to this app, but it could get better performance.

同志，有关于行号显示的进展如何？

同志，有关于行号显示的进展如何？

WIP:

This feature has been implemented in Notepads v<IP_ADDRESS>.
Closing this thread for now.


Why not upgrade jquery？

The zTree latest version v3 still use jquery 1.4.4.

The jquery in zip is only for demo.
You can change jquery what you want to use.
Do I have to put all the jquery versions in Zip?


EKF gives bad results in speed bump and after a sudden brake or turning scenario

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
We encountered the problem of localization shaking when going through speed bump. I checked the inputs for EKF. There doesn't appear to be any delays or errors regarding velocity data. NDT orientation y and orientation y values from GNSS overlap with each other and the values come as they should, but the EKF output responds late because of the sudden change. This causes the localization to shake.
Expected behavior
The map and point cloud must always be on top of each other. I expect not to see any shaking
Actual behavior
I see that the localization shifts on the z axis when going through speed bump. I observe the distortion in localization by checking whether the concatenated point cloud match with the map.
Here is the test videos:
Test Video1
Test Video2
At these moments, when I look at the orientation data coming from GNSS, the orientation output of NDT, and the orientation data output of EKF, I see that NDT and GNSS give close and accurate data. However, when I look at the orientation values in the EKF output, I see that they react late. (The value I take into consideration here is the pitch value because the distortion occurs on the pitch.)

-- /localization/pose_estimator/pose/orientation/pitch_deg  --> NDT Output (Green )
-- /localization/pose_twist_fusion_filter/pose/orientation/pitch_deg --> EKF Output (Yellow)
-- /sensing/gnss/pose/orientation/pitch_deg  --> GNSS Output (Purple)
Steps to reproduce
1.) Bag files and videos are here:
https://drive.google.com/drive/folders/1Nvj1HkRecVttlfBPTliMTGJc7OGRjyYj?usp=sharing
2.) Sensor kit:
https://github.com/leo-drive/golf_sensor_kit_launch
3.) Individual Params:
https://github.com/leo-drive/autoware_individual_params
4.)PC Map:
https://drive.google.com/file/d/1ltgV-rD0a6O7Nv3uxrzs47OFcrcX4DrA/view?usp=drive_link
5.) EKF parameters are here
https://github.com/leo-drive/autoware_launch/blob/golf/autoware_launch/config/localization/ekf_localizer.param.yaml
Versions
No response
Possible causes
I know that EKF filters sudden changes because it processes data from the past, but working this way will cause many problems and needs to be solved.
Additional context
No response

One thing you could do is to tune the parameters for Simple1DFilter in ekf_localizer. Currently it's not prepared as a default parameters, so you need to edit the code to add a parameters here: https://github.com/autowarefoundation/autoware.universe/blob/bae5ea79c0879d02aab728e355205a0fb17e6fdc/localization/ekf_localizer/src/ekf_localizer.cpp#L98-L100

Thank you for your response. I appreciate your help. The shift problem in EKF was solved when I played with these parameters (roll_filter_proc_dev parameter affected the result).
That's why I created two PRs so that I could change them in the parameter file.
https://github.com/autowarefoundation/autoware_launch/pull/710
https://github.com/autowarefoundation/autoware.universe/pull/5707
While localizing with NDT, the shift between EKF decreased from 400 ms to 200 ms. Since the frequency of NDT is low, I think it may be normal that this is not 0. Because when I fed GNSS data to EKF at 100 Hz with new parameters, this shift disappeared. There is no delay or shift anymore. However, this problem was not solved when I localized both with GNSS and NDT. That's why I'm taking a look at other problems in my system right now.

Since all relevant PRs have been merged, I close this issue.  Thanks for all of your support.


[ISSUE #6396]Fix DefaultMQPushConsumer javadoc typo

Make sure set the target branch to develop
What is the purpose of the change

fix #6396
Brief changelog
-Fix DefaultMQPushConsumer javadoc typo
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6397 (3a2cae5) into develop (7d67484) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6397      +/-   ##
=============================================
- Coverage      43.08%   43.07%   -0.01%
- Complexity      8914     8917       +3
=============================================
  Files           1105     1105
  Lines          77954    77954
  Branches       10144    10144
=============================================
- Hits           33586    33580       -6
- Misses         40151    40167      +16
+ Partials        4217     4207      -10

Impacted Files
Coverage Δ

...ocketmq/client/consumer/DefaultMQPushConsumer.java
58.10% <ø> (ø)

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add Sequence.reset

Closes https://github.com/thoughtbot/ex_machina/issues/120
Sequence.reset can be run in a setup block to make sure sequences
are reset between tests. This often times is not needed, but when it is,
it's handy to have. See the linked issue above for more details.

:+1: This LGTM

Nice, LGTM

Thanks for the reviews!


docs(configuration): Improve docs for curations in .ort.yml

I ended up rewriting / reordering larger parts than planned as I found the docs to be more and more lacking the more often I read it.


Fix Spanish translation

Fix spanish translation: Error in "fog" spanish translation (It is not "nublado" but "niebla", nublado is cloudy)

Thank you!


WIP: First pass at ignoring signals

I'm not a huge fan of this solution... ignoring signals solves the problem for Replicant directly, but is kind of an odd solution, relying on pushing signal handling to the end user for a fairly common scenario of having to clean up or wait for call completion.
On startup we have setup (pre-connect) and ready (post-connect)
On shutdown we only have teardown (post-disconnect)... what we're missing is a pre-disconnect callback method.
I would suggest instead we expose another callback method (name TBD) that allows the user to manage their business logic while shutting down but before its disconnected from Relay.
The result I think is the same, Replicant would write the same code, but it would be in a SDK supported callback rather than hacking signal handling.

That would be a great solution, though we are going to eventually redo all
SDKs. Also, adding a consumer interface method makes it so all SDKs have to
support it. I think this is a good stopgap measure.
On Fri, 20 Nov 2020 at 20:12, Bryan Rite<EMAIL_ADDRESS>wrote:

I'm not a huge fan of this solution... ignoring signals solves the problem
for Replicant directly, but is kind of an odd solution, relying on pushing
signal handling to the end user for a fairly common scenario of having to
clean up or wait for call completion.
On startup we have setup (pre-connect) and ready (post-connect)
On shutdown we only have teardown (post-disconnect)... what we're missing
is a pre-disconnect callback method.
I would suggest instead we expose another callback method (name TBD) that
allows the user to manage their business logic while shutting down but
before its disconnected from Relay.
The result I think is the same, Replicant would write the same code, but
it would be in a SDK supported callback rather than hacking signal handling.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/signalwire/signalwire-node/pull/271#issuecomment-731357774,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB2TSV5PHLRGZFXQZSBRWTSQ25SXANCNFSM4T356XAA
.

Not really, we should eventually have it for all of them, but we can add it just for Node right now, it's just as much if not less code than this... rather than having a client rely on something we won't support in the future.

Ok, I understand better now. You are right. This is Replicant, so it is high priority, and if we could get an ETA it would be great.

Can you take an attempt at it? Would just have to follow whatever is done for teardown, setup, or ready, and probably hook it into gracefulShutdown.


Add more examples to CppMicroServices.

I have implemented a simple math example. This example makes it easy to understand how to add, multiply using CppMicroService. I need this to be added to CppMicroServices.

@ameya7295 please feel free to create a pull request which adds this simple math example. I suggest adding it under doc/src/examples within the source tree.

Thankyou @jeffdiclemente I would be creating the PR for the same. Please tag this under the appropriate label.


Add experiment id and/or analysis id to exception error messages

What is the expected behavior?
In the case of an exception raised during analysis of experiment results, it would be very useful to have the experiment or analysis ID in the error message, so that one can retrieve the result later to debug/check the reason for the exception - especially when the experiment is run in some shell script or automation code, or as part of a very large (batch/parallel) experiment.
Thank you.

You typically can't save show the analysis result ID for failed analysis because these results are never generated. The experiment ID could definitely be added to the log messages though.

Thanks. Is there an estimate on when this will be included? I am getting sometimes various analysis exceptions (thrown e.g. by numpy.linalg routines, and other library calls), that cannot be debugged right now.

Can this be closed with #781 merged?

Yes I think so. Closing.


New xSPBlobCache resource

New xSPBlobCache resource as specified in issue #45
Thanks for submitting a Pull Request to this project.
Please make sure you have read the Contribution Guidelines.
To aid community reviewers in reviewing and merging your PR, please take the time to run through this checklist:

[X] Change details added to Unreleased section of readme.md?
[X] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[X] Examples updated for both the single server and small farm templates in the examples folder?
[X] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
[X] Unit and Integration tests created/updated where possible?

This change is

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 15 unresolved discussions, some commit checks failed.

a discussion (no related file):
You'll need to do a pull from dev to get this one up to date - watch it carefully though, the merge will pick up all of the renames so when you're accepting merge changes just keep a close eye on it

README.md, line 102 [r1] (raw file):

 * Fixed incorrect output of server name in xSPOutgoingEmailSettings
 * Added ensure properties to multiple resources to standardise schemas
 * Added xSPSearchContentSource, xSPContentDatabase, xSPServiceAppSecurity, xSPAccessServiceApp, xSPExcelServiceApp, xSPPerformancePointServiceApp, xSPIrmSettings, xSPSearchCrawlRule and xSPBlobCacheSettings resources

Since this will hit in 1.1 can you do an update from dev and move this in to the CHANGELOG.md file for me?

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 9 [r1] (raw file):

        [parameter(Mandatory = $true)]  [System.String] $WebAppUrl,
        [parameter(Mandatory = $true)]  [ValidateSet("Default", "Intranet", "Internet", "Custom", "Extranet")] [System.String] $Zone,
        [parameter(Mandatory = $false)] [System.Boolean] $EnableCache,

Rather than calling this "EnableCache" can we follow the DSC convention of use the "Ensure" property - like we want to ensure the settings are present, or ensure it is absent kind of thing? Just for consistency.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 10 [r1] (raw file):

        [parameter(Mandatory = $true)]  [ValidateSet("Default", "Intranet", "Internet", "Custom", "Extranet")] [System.String] $Zone,
        [parameter(Mandatory = $false)] [System.Boolean] $EnableCache,
        [parameter(Mandatory = $false)] [System.String] $Location,

Can we change this parameter name to "CachePath" or something that includes the word path. Location sounds a little generic.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 11 [r1] (raw file):

        [parameter(Mandatory = $false)] [System.Boolean] $EnableCache,
        [parameter(Mandatory = $false)] [System.String] $Location,
        [parameter(Mandatory = $false)] [System.UInt16] $MaxSize,

Can we make this one "MaxSizeInMB" or something that indicates the order of scale? I know we will have the doco updated but if it's right there it will be easier for people to work with

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 49 [r1] (raw file):

        $webconfig = New-Object XML
        $webconfig.Load($webconfiglocation)

Rather than loading the XML in like this, we can use the shorthand for this in PowerShell
[xml]$webConfig = Get-Content -Path $webConfigLocation

You can still refer to everything the same in the code below, this is just a neater way to do it without needing to fall back to the New-Object cmdlet

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 60 [r1] (raw file):

        }
        catch [FormatException] {
            throw "Conversion of MaxSize failed"

Whats the scenario we are accounting for here? If someone puts a value in to the web.config that isn't a number? Happy to handle it, but if we can't convert it maybe we should return "-1" or something like that to indicate a value was invalid rather than throwing the exception in this case? Happy for the next non-specific exception catch block to throw, but I think this one should behave differently.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 105 [r1] (raw file):

    if ($CurrentValues.Location -ne $Location) { $changes.Location = $Location }
    if ($CurrentValues.MaxSize -ne $MaxSize) { $changes.MaxSize = $MaxSize }
    if ($CurrentValues.FileTypes -ne $FileTypes) { $changes.FileTypes = $FileTypes }

What happens with these comparisons when you don't provide values - since there are no defaults does this provide the expected results? I'm happy with the logic of detecting the changes but you might need to check if $PSBoundParameters contains they key before we test for the value change.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 141 [r1] (raw file):

        $webconfiglocation = Join-Path $sitePath "web.config"
        $webconfigbackuplocation = Join-Path $sitePath "web_config-$timestamp.backup"
        Copy-Item $webconfiglocation $webconfigbackuplocation

FYI - I love that you caught the backup in this! Nicely done!

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 143 [r1] (raw file):

        Copy-Item $webconfiglocation $webconfigbackuplocation

        $webconfig = New-Object XML

Same remark as the get method for how to load the XML doc

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.schema.mof, line 5 [r1] (raw file):

This resource is used to configure the Blob Cache settings for a web application.
You have to make sure the specified folder is created and has the correct permissions.

I think we can handle creating the folder if it doesn't exist (we do this for search index locations in SPSearchTopology and SPSearchIndexPartition already) - and in theory we should be able to do the permissions as well. Do you think we can add this in? Happy to take this on as technical debt and put it in the backlog if you think it's too challenging for right now though and we can leave this in the documentation.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.schema.mof, line 10 [r1] (raw file):

This resource only configures the local server.
It changes the web.config file directly and is NOT using the SPWebConfigModifications class.
In order to configure all WFE servers in the farm, you have to apply this resource to all servers.

Do we need to advise making these changes on all servers? I vaguely recall there being a health analyser rule that will fire if the web.config files don't match on each server

Modules/xSharePoint/DSCResources/MSFT_xSPWebAppPolicy/MSFT_xSPWebAppPolicy.psm1, line 506 [r1] (raw file):

}

#Verplaatsen methode naar eigen utils module

Whats this change? Looks like its being removed so im ok with it though.

Tests/xSharePoint/xSharePoint.xSPBlobCacheSettings.Tests.ps1, line 18 [r1] (raw file):

    InModuleScope $ModuleName {
            $testParams = @{
                WebAppUrl   = "http:/sharepoint.contoso.com"

There's only 1 "/" in the URL - i know for testing purposes it won't matter, but can we fix it anyway

Tests/xSharePoint/xSharePoint.xSPBlobCacheSettings.Tests.ps1, line 60 [r1] (raw file):

        }

#Incorrect MaxSize in WebConfig

Do we need comments like this here if the context line explains the context of the test?

Comments from Reviewable

Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

a discussion (no related file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> You'll need to do a pull from dev to get this one up to date - watch it carefully though, the merge will pick up all of the renames so when you're accepting merge changes just keep a close eye on it

Done

README.md, line 102 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Since this will hit in 1.1 can you do an update from dev and move this in to the CHANGELOG.md file for me?

Done.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 10 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Can we change this parameter name to "CachePath" or something that includes the word path. Location sounds a little generic.

The parameter in the web.config is called Location, that is why I kept the same naming. Will change it to CachePath.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 11 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Can we make this one "MaxSizeInMB" or something that indicates the order of scale? I know we will have the doco updated but if it's right there it will be easier for people to work with

The parameter in the web.config is called MaxSize, that is why I kept the same naming. Will change it to MaxSizeInGB.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 49 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Rather than loading the XML in like this, we can use the shorthand for this in PowerShell
>
>     [xml]$webConfig = Get-Content -Path $webConfigLocation
>
> You can still refer to everything the same in the code below, this is just a neater way to do it without needing to fall back to the New-Object cmdlet

Will update this

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 60 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Whats the scenario we are accounting for here? If someone puts a value in to the web.config that isn't a number? Happy to handle it, but if we can't convert it maybe we should return "-1" or something like that to indicate a value was invalid rather than throwing the exception in this case? Happy for the next non-specific exception catch block to throw, but I think this one should behave differently.

Correct, since someone can edit the web.config manually a non number can be configured in the MaxSize property (it is a string value). Will change it to return -1 instead of an exception

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 105 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> What happens with these comparisons when you don't provide values - since there are no defaults does this provide the expected results? I'm happy with the logic of detecting the changes but you might need to check if $PSBoundParameters contains they key before we test for the value change.

Correct, will change this

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 143 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Same remark as the get method for how to load the XML doc

Will update

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.schema.mof, line 5 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> I think we can handle creating the folder if it doesn't exist (we do this for search index locations in SPSearchTopology and SPSearchIndexPartition already) - and in theory we should be able to do the permissions as well. Do you think we can add this in? Happy to take this on as technical debt and put it in the backlog if you think it's too challenging for right now though and we can leave this in the documentation.

Creating the folder isn't that difficult, but granting it the correct permissions is the tricky part. Separate modules exist that are specifically build to manage file/folder permissions and I did not want to include that functionality in this resource. That should be in a separate resource.
Should we set the correct permissions (and validate) as well or leave this up to the other resources

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.schema.mof, line 10 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Do we need to advise making these changes on all servers? I vaguely recall there being a health analyser rule that will fire if the web.config files don't match on each server

Will add an additional remark to include the advise.

Modules/xSharePoint/DSCResources/MSFT_xSPWebAppPolicy/MSFT_xSPWebAppPolicy.psm1, line 506 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Whats this change? Looks like its being removed so im ok with it though.

Found this comment still being in this resource while creating the BlobCache module. I removed it since it was something I used during the development of the other resource and should be in here. Since it was only a comment, I did not create a separate PR for this.

Tests/xSharePoint/xSharePoint.xSPBlobCacheSettings.Tests.ps1, line 18 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> There's only 1 "/" in the URL - i know for testing purposes it won't matter, but can we fix it anyway

Oeps, will correct it.

Tests/xSharePoint/xSharePoint.xSPBlobCacheSettings.Tests.ps1, line 60 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Do we need comments like this here if the context line explains the context of the test?

Done

Comments from Reviewable

Review status: all files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 10 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> The parameter in the web.config is called Location, that is why I kept the same naming. Will change it to CachePath.

OK didn't think of it like that, happy to leave this as location

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 11 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> The parameter in the web.config is called MaxSize, that is why I kept the same naming. Will change it to MaxSizeInGB.

Again happy for this to line up that way - I saw we have it documented as well, so we can leave this one too.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.schema.mof, line 5 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Creating the folder isn't that difficult, but granting it the correct permissions is the tricky part. Separate modules exist that are specifically build to manage file/folder permissions and I did not want to include that functionality in this resource. That should be in a separate resource.
>
> Should we set the correct permissions (and validate) as well or leave this up to the other resources

I think we should definitely be validating them, and realistically I think this is one we can set as well. If it was a directory that could potentially be used for other things there is an argument for keeping it separate, but realistically it should be a folder for jsut the cache items so I'm happy that our resource would own it.

Comments from Reviewable

Review status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 9 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Rather than calling this "EnableCache" can we follow the DSC convention of use the "Ensure" property - like we want to ensure the settings are present, or ensure it is absent kind of thing? Just for consistency.

Since the web.config also used an Enabled/Disabled parameter, I think the Ensure property is a little confusing. With Ensure=Absent, the line will still be there but then set to false. That is why I used the EnabledCache parameter, to match the parameters in the web.config

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 10 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> OK didn't think of it like that, happy to leave this as location

I will leave it as it is.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 11 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Again happy for this to line up that way - I saw we have it documented as well, so we can leave this one too.

Rename was already done. Will leave it including InGB, since that makes it clear the size is in GB.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 49 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Will update this

Done.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 60 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Correct, since someone can edit the web.config manually a non number can be configured in the MaxSize property (it is a string value). Will change it to return -1 instead of an exception

Done.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 105 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Correct, will change this

Done.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.psm1, line 143 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Will update

Done.

Modules/xSharePoint/DSCResources/MSFT_xSPBlobCacheSettings/MSFT_xSPBlobCacheSettings.schema.mof, line 10 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Will add an additional remark to include the advise.

Done.

Tests/xSharePoint/xSharePoint.xSPBlobCacheSettings.Tests.ps1, line 18 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Oeps, will correct it.

Done.

Comments from Reviewable

@ykuijs Are you meaning to push code here as well? I see the reviewable updates but no new commits to the PR

Correct, I am working on the changed and will push them all at once to this PR. Probably somewhere in the next couple of days.

@ykuijs All good - was just confused where I saw "done" in the code review and no code changes :) Ping me here when you push the code in and I'll come back for review. Thanks bud

Review status: 0 of 10 files reviewed at latest revision, 9 unresolved discussions.

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1, line 9 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Since the web.config also used an Enabled/Disabled parameter, I think the Ensure property is a little confusing. With Ensure=Absent, the line will still be there but then set to false. That is why I used the EnabledCache parameter, to match the parameters in the web.config

Left the parameter name as EnableCache, because of my previous comment

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1, line 49 [r1] (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
> Done.

Done.

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.schema.mof, line 5 [r1] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> I think we should definitely be validating them, and realistically I think this is one we can set as well. If it was a directory that could potentially be used for other things there is an argument for keeping it separate, but realistically it should be a folder for jsut the cache items so I'm happy that our resource would own it.

Done.

Comments from Reviewable

@BrianFarnhill Just synced my changes. Go ahead with the review!

Reviewed 4 of 10 files at r1, 6 of 6 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

a discussion (no related file):
This is looking great @ykuijis - just a couple of very minor things on this pass and then we are good to merge, but seriously this is nice code dude, very happy with where this one is at.

README.md, line 16 [r2] (raw file):

## Installation

Why did you take this empty line out? I don't think it makes a different to how the markdown renders, just curious is all

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1, line 28 [r2] (raw file):

        }

        switch ($params.Zone) {

Rather than use this switch statement you should be able to use a line like this to get the zone:
$zone = [Microsoft.SharePoint.Administration.SPUrlZone]::$($params.Zone)

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1, line 150 [r2] (raw file):

            Write-Verbose -Verbose "Processing changes"

            switch ($params.Zone) {

Same remark as above about selecting the zone

Comments from Reviewable

@ykuijs Also looks like this one needs a pull from PowerShell dev as well

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

a discussion (no related file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> This is looking great @ykuijis - just a couple of very minor things on this pass and then we are good to merge, but seriously this is nice code dude, very happy with where this one is at.

You are welcome! :+1:  ;-)

README.md, line 16 [r2] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Why did you take this empty line out? I don't think it makes a different to how the markdown renders, just curious is all

All sections had the next line right after the title line, so I brought this in line. I now see that in the current version of the file this isn't consistent anymore :-)

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1, line 28 [r2] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Rather than use this switch statement you should be able to use a line like this to get the zone:
>
>     $zone = [Microsoft.SharePoint.Administration.SPUrlZone]::$($params.Zone)

Done.

Modules/SharePointDSC/DSCResources/MSFT_SPBlobCacheSettings/MSFT_SPBlobCacheSettings.psm1, line 150 [r2] (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
> Same remark as above about selecting the zone

Done.

Comments from Reviewable

Reviewed 8 of 13 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Switching to EE not working

We are trying to set up local M2 EE dev environments on Windows 10 workstations to support our new manged M2 ECE instance.  All commands below were run using Git Bash as Admin.
Install Steps

Installed Git Bash (2.15.0 64-bit), Composer (1.5.2), VirtualBox (5.1.30) and Vagrant (1.8.5)
Installed vagrant hostmanager, vbguest and host-shell plugins
Configured Git core.autocrlf false, core.eol LF and diff.renamelimit 5000 globals
Generated SSH keys and added to GitHub and M2 ECE dev environment on AWS
Cloned git@github.com:paliarush/magento2-vagrant-for-developers.git into C:\Users\JordanG\Documents\Source\Magento
Copied ..\vagrant-magento\etc\config.yaml.dist to config.yaml and configured EE repository url to point to M2 ECE dev master git, CE repository url to point to our forked M2 CE repo, composer_prefer_source: 1 and upped memory and cpus
Copied ..\vagrant-magento\etc\composer\auth.json.dist to auth.json and configured GitHub personal access token and Magento public and private access keys
Uncommented vb.gui=true in Vagrantfile to avoid issues with VirtualBox on Windows 10
Ran bash init_project.sh from ..\vagrant-magento with PHPStorm closed

Install Results
Only one error logged, in cache flushing step: Can't remove /var/www/magento2ce/app/etc/env.php: Text file busy, skipping file.

M2 CE storefront and admin sites working:

EE directory populated with correct source from M2 ECE AWS dev master Git repo: C:\Users\JordanG\Documents\Source\Magento\vagrant-magento\magento2ce\magento2ee
So all is well up to this point.
Switching to EE

Run PhpStorm as admin and open directory C:\Users\JordanG\Documents\Source\Magento\vagrant-magento
Click yes:

Choose ignore for Unregistered VCS root detected. The directory C:\Users\JordanG\Documents\Source\Magento\vagrant-magento is under Git, but is not registered in the Settings.
Some background tasks fire up:

VCS connections made:

After initial wave of background tasks completed in PhpStorm, run bash m-switch-to-ee with PhpStorm open
Eventually, automated progress stops and this is logged: WARNING: >  [Action Required] Wait while Magento2 code is uploaded in PhpStorm and press any key to continue... Not sure how long to wait... nothing seems to be happening in PhpStorm... wait 10-15 minutes...
Hit a key in bash to continue script execution

Front end now shows setup page:

Switching to EE results in error

A quick search reveals RabbitMQ may not be properly installed/configured on the VM?
Per official docs, --amqp-host is:

For magento Commerce only. Do not use the --amqp options unless you have already set up an installation of RabbitMQ. See RabbitMQ installation for more information about installing and configuring RabbitMQ.

Switching to EE "without" RabbitMQ results in error

Commented these lines out in: C:\Users\JordanG\Documents\Source\Magento\vagrant-magento\scripts\guest\m-reinstall

Run bash m-switch-to-ee -f with PhpStorm open
Wait for arbitrary amount of time while Magento2 code is uploaded in PhpStorm, before pressing a key to continue... how do you know when this is done?

One error logged:

Front end now displays:

Last-ditch efforts

Tried flushing cache with bash m-bin-magento cache:flush but got error:

Tried flushing cache with bash m-clear-cache - got one error:

Seems like it worked because custom module in app/code that was committed to M2 ECE AWS dev master Git repo is installed in the admin site:

But vagrant is still not switched to the EE source cloned from ECE repo. The admin sites show different versions and have all different menu options available:

Tried recompiling: bash m-bin-magento setup:di:compile - that fails:

Tried re-deploying static content: bash m-bin-magento setup:static-content:deploy - works but vagrant is still not in EE 'mode'

On VM, apache2 sites-enabled does't point to EE dir... bad sign?
<VirtualHost *:80>   DocumentRoot "/var/www/magento2ce"   ServerName magento2.vagrant129   <Directory "/var/www/magento2ce">       Options Indexes FollowSymLinks       AllowOverride All       Require all granted   </Directory>   ErrorLog "${APACHE_LOG_DIR}/error.log"   CustomLog "${APACHE_LOG_DIR}/access.log" common </VirtualHost>

Next steps?
Clearly there are some RabbitMQ issues when switching to EE, but there also seems to be some other things going wrong under the hood here. Are there any steps here where we're doing something wrong or out of order? Any feedback would be greatly appreciated!!!
Thank you!

Hi Jordan,
I looked this over, per your request. Only two things stand out to me, and they may be insignificant:
I get the same error about env.php during init.project.sh. I spent some time trying to figure out what the source of the problem is, but I decided that I could disregard it because the script completed and after that error line the status printed was "magento installed successfully" or whatever.
The other thing I noticed is that you said "Ran bash init_project.sh from ..\vagrant-magento with PHPStorm closed" which makes me wonder if it was closed at the time but had been used to open the project prior to running init_project.sh. The reason I wondered about that is because of this line from readme.md: ":warning: Do not open it in PhpStorm until init_project.sh has completed".
Good luck.

I deliberately did not open PhpStorm or the vagrant-magento directory with PhpStorm ever before the script was completed, due to the warning you pointed out.

@jordangottlieb-ych thank you for such a detailed description of your issue.
RabbitMQ error that you are experiencing is caused by the fact that Magento codebase is still CE, which does not support RabbitMQ (RabbitMQ related CLI options are supported by EE only).
When you try to switch to EE on Windows the algorithm is following:

build-ee.php tool (provided by Magento) is used to link your EE codebase to CE codebase. Try to run the same command manually to make sure that the tool works correctly on your instance
After linking is complete (should take couple seconds), PhpStorm is supposed to automatically upload all modifications to the VM (may take a minute or so). You should see this as "Automatic upload" background task in PhpStorm. See this doc and make sure that automatic upload is configured and works correctly.

As a workaround you can just copy EE codebase on top of CE codebase and do bin ./m-switch-to-ee -f if this option is acceptable for you.
But it really seems that build-ee.php tool does not work as expected on your instance.

Tried configuring my CE and EE repos in the yaml file to point to the same EE repor, installed an ran bin ./m-switch-to-ee -f - Errors:


Create config.yml

Initial creation

leaving support site commented out till it's ready for release.

You may as well uncomment the support site, the other ticket creation link you had goes straight to the same site anyways.


Promise based alternative to done() callback.

As suggested by @Page-.

I'm closing this since it has been fixed in the next branch, which will be soon published to npm.


Defender feature only required for WS16+

We can clarify the EP role feature requirement: if you’re using WS16, then you need to add the WD feature. In other words, that feature only applies to WS16+. ConfigMgr installs SCEP on older server versions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9070eb9b-0e5f-a877-e02e-2d1cea2a2b38
Version Independent ID: df251762-f2d6-9f06-4fa9-ec5cea2cca0a
Content: Site prerequisites - Configuration Manager
Content Source: sccm/core/plan-design/configs/site-and-site-system-prerequisites.md
Product: configuration-manager
Technology: configmgr-other
GitHub Login: @mestew
Microsoft Alias: mstewart

Original issue: #845
Fixed by private PR MicrosoftDocs/SCCMDocs-pr#3236

looks like this is already fixed


I am getting location manger warning when i am requesting for geo location

A location manager (0x1610ab70) was created on a dispatch queue executing on a thread other than the main thread.  It is the developer's responsibility to ensure that there is a run loop running on the thread on which the location manager object is allocated.  In particular, creating location managers in arbitrary dispatch queues (not attached to the main queue) is not supported and will result in callbacks not being received.

Thank you, I've fixed it.


[FEATURE] Add capacity to send multiple commands at once with remoteOverrideCommandsList

Is your feature request related to a problem? Please describe.
Its really annoying to have to press the volume key on my homekit remote 50 times depending upon the app/audio stream currently streaming.
Describe the solution you'd like
Enable remoteOverrideCommandsList to contain commands which reference sequences... such as "Volume Up 5" which I created to change the volume must faster.
                        {
                            "CommandName": "INFORMATION",
                            "NewCommand": "Xbox One S;Xbox"
                        },

Describe alternatives you've considered
There aren't alternatives for this particular problem because telling siri to activate a switch to change the volume triggering a sequence is problematic with other sounds in the room.
Additional context
An example command list might be something like this.
                "remoteOverrideCommandsList": [
                {
                    "ActivityName": "Xbox",
                    "CommandsList": [
                        {
                            "CommandName": "VOLUME_DOWN",
                            "NewSequence: "Volume Down 5"
                        }
                        {
                            "CommandName": "VOLUME_UP",
                            "NewSequence: "Volume Up 5"
                        }
                    ]
                }

If someone can point me to the code that needs to change, I wouldn't mind contributing

Hi, did you try the option «numberOfCommandsSentForVolumeControl » ?
Sent with GitHawk

Work in progress.
Something like this will be possible, so that you can optionally specify the number of commands to send :
 "remoteOverrideCommandsList": [
      {
        "ActivityName": "La TV",
        "CommandsList": [
          {
            "CommandName": "REWIND",
            "NewCommand": "Ampli;Number0;5"
          },
          {
            "CommandName": "BACK",
            "NewCommand": "TV;Back"
          }
        ]
      }
]


policy file command 500 errors from server

Whenever I run any command that involves policy files API endpoints, the server returns a 500 server error.
For example: running chef show-policy returns this:
[2015-08-03T00:30:25+01:00] ERROR: Server returned error 500 for https://chef-server.XX.com/organizations/XX/policy_groups, retrying 1/5 in 3s

But also chef push returns the same error.
In the opscode-erchef/crash.log, I see this:
{<<"method=GET; path=/organizations/XX/policy_groups; status=500; ">>,{error,{badrecord,chef_container},[{oc_chef_authz,get_container_aid_for_object,3,[{file,"src/oc_chef_authz.erl"},{line,139}]},{oc_chef_wm_base,forbidden,2,[{file,"src/oc_chef_wm_base.erl"},{line,156}]},{webmachine_resource,resource_call,3,[{file,"src/webmachine_resource.erl"},{line,186}]},{webmachine_resource,do,3,[{file,"src/webmachine_resource.erl"},{line,142}]},{webmachine_decision_core,resource_call,1,[{file,"src/webmachine_decision_core.erl"},{line,48}]},{webmachine_decision_core,decision,1,[{file,"src/webmachine_decision_core.erl"},{line,225}]},{webmachine_decision_core,handle_request,2,[{file,"src/webmachine_decision_core.erl"},{line,33}]},{webmachine_mochiweb,loop,2,[{file,"src/webmachine_mochiweb.erl"},{line,72}]}]}}

I am running chef server 12.1.1 and chef-client 12.4.1.
Can anyone help me please, as the above error is not particularly helpful? thx

Was this a fresh install or did you upgrade from a previous version?

It was an upgrade

Backfilling some IRC conversation:

Something seems to have gone wrong during the upgrade.  The organization in question does not have the policy_group container but does have a policies container.

Running the upgrade again hasn't helped.

New organizations work as expected.

Joel is going to look into just doing a fresh install and reimporting the data rather than mucking about with trying to repair the failed upgrade.  I've let him know he can drop a note back here if he runs into problems with that.

I recently saw this in a customer's Chef Server. They had previously imported into a new 12.0.5 server and then upgraded that in-place to 12.1.2. Somehow all the upgrade migrations looked fine except an org was missing the policy_groups container. I'm not sure what the root cause of the problem is.
To fix the problem I used the chef_fixie tool to create the missing container and assign appropriate permissions. Here are the instructions for installing chef_fixie in any Chef Server 12+ and for the fix. You will need to replace ORG_NAME with the name of the affected org.
# install chef_fixie
/opt/opscode/embedded/bin/gem install chef_fixie --ignore-dependencies --no-ri --no-rdoc

# start a chef_fixie session
/opt/opscode/embedded/bin/chef_fixie

# run this code to fix the org
o = ORGS['ORG_NAME']
c = o.authz_api.post('containers', {})
pivotal = USERS['pivotal']
now = Sequel.function(:NOW)
o.containers.inner.insert(id: SecureRandom.hex, org_id: o.id, authz_id: c['id'], name: 'policy_groups', last_updated_by: pivotal.authz_id, created_at: now, updated_at: now)
policies_container = o.containers['policies']
o.containers['policy_groups'].acl_add_from_object(policies_container)

Thanks @jeremiahsnapp


docs: Add Managed Kafka terraform samples for Clusters and Topics

Description
Fixes https://b.corp.google.com/issues/343411931
Checklist
Readiness

[x] Yes, merge this PR after it is approved
[ ] No, don't merge this PR after it is approved

Style

[x] My sample follows the rules described for Terraform in the Effective Samples style guide
[x] My sample follows the other requirements and best practices in the Contributing
guide

Testing

[x] I have performed tests described in the Contributing guide:

[x] Tests pass: terraform apply
[x] Lint pass: terraform fmt check

Intended location

[x] Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/managed-kafka/docs

[ ] No, this sample won't be included on cloud.google.com
Reason:

API enablement

[x] If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

[x] If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

This PR is starting from scratch from https://github.com/terraform-google-modules/terraform-docs-samples/pull/687 because the original PR got too messy.

@msampathkumar should be the reviewer (they were reviewing the previous PR)

Both executions of this PR failed the integration tests with the same error after just shy of 1 hour:
Error waiting for Creating Cluster: Error code 13, message: an internal error has occurred

The latest CI run from the previous PR had a successful creation of the instance in under 30 minutes.
Re-running tests to see if this is a temporary issue.
/gcbrun

Yeah, there was a production issue but that should be resolved now. Thanks for re-running.

Hi @jessdejong shared you a PR suggestion.
@glasnt is one of our awesome leads for this repo. Along with @glasnt, we leads share a cross products interest to support PR like this. In this PR, you are adding codeowner - managedkafka-dev-team. So going forward, this managedkafka-dev-team members can be your first reviewers for this product samples.
I see you are doing good work already but let me say it again. Be familiarise yourself with https://googlecloudplatform.github.io/samples-style-guide/ and if you need support, do reach out chat group or to glasnt or myself.
You are doing great! 👍

/gcbrun

/gcbrun

Lint diskspace errors reported in https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/issues/2427

Thanks for your help! Please LMK if there is anything else. It looks like the lint errors seem unrelated -- are we able to submit now?
(also pls see my comment about making the subnet "default", unfortunately we are not able to do that)

/gcbrun


Hoist proptypes

The "Connected" Component generated by connect inherits propTypes unrelated to the store dependencies from the BaseComponent.
So if a Component passed to connect declares a count propType and there is not count field in the dependency...
class CountComponent extends Component {
  static propTypes = {
    count: PropTypes.number,
    user: PropTypes.object,
  };

  // ...
}

export default connect({user: UserStore})(CountComponent);

That Component returned by connect will have a propType signature like...
const propTypes = {
  count: PropType.number,
};

Previously the connected component would only receive the types defined in it's dependencies without any additionally types from the BaseComponent. This can be problematic if propTypes are used as a programatic interface in parent components. Perhaps not common, but relevant for some.
TODOs

[x] linter, checker, and test are passing
[x] any new public modules are exported from src/GeneralStore.js
[x] version numbers are up to date in package.json and bower.json
[x] CHANGELOG.md is up to date

Also adds a yarn.lock file


python311Packages.deezer-python: 6.1.0 -> 6.1.1

Diff: https://github.com/browniebroke/deezer-python/compare/refs/tags/v6.1.0...v6.1.1
Changelog: https://github.com/browniebroke/deezer-python/releases/tag/v6.1.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 262033 run on x86_64-linux 1

4 packages built:

python310Packages.deezer-python
python310Packages.deezer-python.dist
python311Packages.deezer-python
python311Packages.deezer-python.dist


Identifiers validation failed for dataset Modelaje de la distribución potencial de 10 especies de anfibios y reptiles en riesgo de extinción con escasos registros de presencia (LEPMIC)

Identifier validation failed for the dataset Modelaje de la distribución potencial de 10 especies de anfibios y reptiles en riesgo de extinción con escasos registros de presencia (LEPMIC):

Crawler attempt: 157
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 8
Cause: GBIF IDs hit maximum allowed - 50%, duplicates - 88%, total records count 8, absent records count 7
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3073432/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Modelaje de la distribución potencial de 10 especies de anfibios y reptiles en riesgo de extinción con escasos registros de presencia (LEPMIC) : https://doi.org/10.15468/ahgend.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Modelaje de la distribución potencial de 10 especies de anfibios y reptiles en riesgo de extinción con escasos registros de presencia (LEPMIC):

Crawler attempt: 160
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 8
Cause: GBIF IDs hit maximum allowed - 50%, duplicates - 88%, total records count 8, absent records count 7
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3094215/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Modelaje de la distribución potencial de 10 especies de anfibios y reptiles en riesgo de extinción con escasos registros de presencia (LEPMIC) : https://doi.org/10.15468/ahgend.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Add a Bugsnag.maxDepth option (number) [Fixes #113]

Originally requested by @Yappli in issue #113 (https://github.com/bugsnag/bugsnag-js/issues/113).
I also require this feature, so I thought I'd hurry this along by submitting my own PR (not that it's much of a rush, but yeah... #swag).

Perfect! Thanks @jacobmarshall!

Thanks @jacobmarshall!! :heart:

:+1: any idea when will it be live on CDN?

I thought it was already... Whoa, I never noticed! :smile:


defaultProject deprecated and automatically removed after update to 14.. now ng serve doesn't work

Which @angular/* package(s) are relevant/related to the feature request?
No response
Description
I've updated some workspace projects to angular 14. They contain mostly a library and an app, sometimes multiple of either.
in angular.json defaultProject is now removed and CLI gives a warning about it.
However spinning up the dev environment is a daily task and ng serve is a nice shorthand to run it. Now I can't use it anymore (unless I change it back to deprecated state)
This is imo a step backwards. Commands should be simple by default and we can do that by configuration. I don't understand why you would remove power from the developer like this.
Proposed solution
Put it back like it was / undeprecate it.
or defaultServeProject or defaultBuildProject (which for most of our projects is different (lib vs app))
Alternatives considered
alternatives would be custom solutions like makefiles or just using npm run start (which is more typing, not that big of a deal but do it 100x per day and it becomes a big deal)

Hi @alan-agius4 ,
changing directory is not really an option for me. I can understand there are groups of devs that use subdirectories but also groups of devs that just use the project from the root. Especially when you use Webstorm and open a terminal in the project. So for that group its not really useful.
As for the longer typed version, that is more effort. Mainly I just don't see a reason to remove it, doesn't seem to be in the way? Or am I missing something? In the end, I feel a cli is a layer that translates the users command into action, and it should help the user, and make it as easy as possible, right?

changing directory is not really an option for me. I can understand there are groups of devs that use subdirectories but also groups of devs that just use the project from the root. Especially when you use Webstorm and open a terminal in the project. So for that group its not really useful.

Not really understanding what is the problem with cd into a directory and run ng serve from the project directory.
The defaultProject was mostly a legacy option left over from CLI version 1. In fact we there have been discussion to remove this since 2018 as per https://github.com/angular/angular-cli/issues/11111#issuecomment-425176217
In a monorepo it's also ambiguously that when running a command like ng build/generate/test  you don't really know which project the command is executed against.

Had some discussion on this and there are a number of options for users to consider to fit their workflow:

$ (cd projects/my-project/ && ng serve) - This cd's into the directory and then runs ng serve. It uses a Bash subshell (the parens) to isolated the cd to that subshell, so when the command exits you are still in the original directory. I use this a lot to run commands in specific directory without actually moving my shell, so it's a nice trick if a bit wordly and ugly.
$ ng serve my-project - The "cleaner" alternative is to have direct support in the command for running in a different directory / project, and the Angular CLI supports this.
$ ng serve <TAB> - If you don't know what projects are available, the CLI can autocomplete it for you as of v14. This can help discover projects in a new Angular workspace you're unfamiliar with.
$ npm start - You can set up npm start or any npm run command to do ng serve my-project. This gives a little more control over exactly how you want to structure your workspace.
$ alias s="ng serve my-project" - If you really want to micro-optimize typing, you can make an alias which does exactly what you want with whatever name you want to give. I'm sure there's a Windows equivalent but I don't know it offhand.

We briefly considered having ng serve default to serving the only servable project in the workspace (if there is only one such project). This would work for the case of having one or two libraries and a demo application, since only the application can be served. We ultimately decided this was not a good idea because it would diverge ng serve from other commands. ng build can't use the same logic since both libraries and applications are buildable. ng e2e can also get weird in a similar capacity.
We also don't feel that micro-optimizing typing is a real goal of the CLI. Particularly for ng serve, most users run this once and let the project build itself, it's not a command that's run every minute, but rather every few hours (obviously exceptions exist). Also in practice, many users will press Up Arrow x ? -> Enter. Terminals also already have a lot of capabilities for aliases and shortcuts which can do a better job of adapting to user customizations than Angular can.
I do admit that discoverability is a bit of a challenge. Exactly what project names are available is not obvious. ng serve <TAB> is great, but I doubt many devs would think of that as a tool they could leverage. We can likely improve the error message of ng serve in a monorepo to list out available projects and suggest ng serve <project> which can reduce some of the getting started friction for new devs. On a similar point, we can also add some capability to list all available projects in a workspace, which would be a bit more generically useful. Filed #23481 and #23482 to improve those.
Beyond those improvements, our take is that users have enough flexibility in how to control their projects and CLI tools that they shouldn't need defaultProject to get a solid experience.

Not really understanding what is the problem with cd into a directory and run ng serve from the project directory.

It's more effort. And I never cd around my projects because I want to always be in root to do any commands. Helps me to have a consistent workflow and no surprises/side-effects.

In a monorepo it's also ambiguously that when running a command like ng build/generate/test you don't really know which project the command is executed against.

Exactly because of that ambiguity you want this option. Let the project decide what it wants. The opinionated nature of angular is great but we are forcing workflow here instead of shepherding best practices.
Forcing to be verbose in patterns is just adding extra boilerplate of developer time that could be fixed with configuration.
Shouldn't commands work by default and with flags/options they become more powerful?
I switch a lot between projects and we have some git hooks that we want to run so I always stop the server when I finish a task and get back to the develop branch or onto another issue. I can't be the only one.
At the very least, ng serve should autodetect the first application in your projects folder or something. Because now, ng serve in root is broken. Like showing a 404 page on a root domain.
Your considerations about which default project to show is exactly where configuration would be an asset. Because you don't know, you let the workspace decide. I think the commands should definitely behave similarly / as expected, but that doesn't mean they don't have their own uniqueness. How about an optional root 'serve' or 'build' configuration in which you can supply the default project?
So with moving away from ng serve because of the lack of support for configuration, the npm start solution is perhaps the best, but I cannot help feel a little bit disappointed. I think this is a small thing but it speaks to a larger topic, which is not supporting just the majority (which are partly assumptions) but also empowering pro-users to optimize their workflows.

I'm also facing some issues with defaultProject being removed but in the context of schematics.
I have built a library (@hug/ngx-schematics-utilities) that ease the use of angular schematics and since ng14 many of the tests are failing due to defaultProject no more being returned through WorkspaceDefinition.extensions['defaultProject'].
When developing a schematic, running ng add does not provide to the schematic any context of which project the command is currently running against, nor provide to the user any way to specify it (ie. there is no ng add schematicName projectName nor ng add schematicName --project projectName available).
The developer is left alone to implement such a --project option inside his schematic to understand where the schematic should be applied. Having the defaultProject property was a safeguard for any developers forgetting to implement such a mechanism and a nice fallback for any users forgetting to specify a project.

I agree that for the ng add we should provide a standard --project option.  Related to: https://github.com/angular/angular-cli/issues/11016
Currently however, providing this option is trivial for schematics author. As all they need to do is to add a project option and add a projectName as a smart default provider. This provider will populate the project option based on inferred project from the cwd if the option is not provided by the user.
    "project": {
      "type": "string",
      "description": "The name of the project.",
      "$default": {
        "$source": "projectName"
      }
    },

Thanks @alan-agius4 !
I was not aware of that provider and it surely is a good start to ease the process.
But I would definitely love to see it defaulted in ng add 😉.


[WIP] 4211-discoverable group

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

NEW BUGS
5

NEW SECURITY HOTSPOTS
0

NEW CODE SMELLS
0

NEW VULNERABILITIES
0

NEW DUPLICATED LINES DENSITY
62.1052631578947

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4419

@pkdash Is this ready for review?

@Maurier I am waiting for @dtarb to test this work. Once he finishes testing and there are no issues, then it will be ready for review.

@Maurier It's now ready for review.


any plans to support directory layer?

Any plans to support the directory layer?

There are no plans for supporting directory layer. We plan on having proper support for FDB Tenants. FDB Tenants together with Redwood storage engine should address most of the use-cases where directory layer was previously used.

Ok, thanks!


please release prebuilt binaries for windows and linux

Hi there,
For the linux side of things making the .a/.so should be straighforward enough.
For the windows side of things however, it would have been nice to release some pre-build binaries for windows 10 to things out with.
Also, it would have been nice to simply msbuild.exe ide/vs2017/mimalloc.sln
giving examples to build it at the command line with different mstools versions.
How do we query for the available install mstools versions we have to pass it at the msbuild command line and force it to use that?
Thank you for listening.

This is now partially addressed through the Azure pipelines. I hope to do a first release early next week

mkdir build
cd build
cmake -G "Visual Studio 15 2017 Win64" ..
MSBuild libmimalloc.sln /p:Configuration=Release /p:Platform=x64

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:12.06


About ETH3D evaluation

Hi Wei,
thanks for sharing the code.
Would it be possible to provide the ETH3D evaluation code?
I was wondering how the data flow of the model's forward propagation.
Look forward to your reply.
Regards

Hey, were you able to get the quantitative results for HPatches? If so, can you share the code?
Thanks!

Hi, I'm not able to get the results for HPatches...

Hey, were you able to get the quantitative results for HPatches? If so, can you share the code?
Thanks!

Can you share your evaluation code? Thanks a lot.


Document the core infrastructure of the project

See the Tooling section of the OpenJS Foundation application.
This should notably:

include estimated cost of the infrastructure and plans for funding those (e.g. continuous funding by Google),
list services and their costs,
list deployed open source projects and link to their repositories,
list custom infrastructure and link to their repositories,
specify that the infra is under the purview of the Infra WG.

/cc @ampproject/wg-infra

@bnb and @kborchers from the OpenJS Foundation Cross Project Council have expressed interest in helping with this effort

Today, during the Foundation Onboarding WG, we agreed to share this document as a google doc with the CPC (rather than a markdown file). The reasoning was that this information was more useful to the foundation than to the project as it was essentially focused on costs. Thus the foundation could decide where to put it rather than have the WG add it to its own repository.
@jorydotcom will share it with the CPC providing additional context and cc'ing @estherkim, @rsimha, and myself (I will be sharing email addresses privately with Jory).

The CPC had a follow-up question which was promptly addressed by @estherkim.
Having not heard back from the CPC, I suggest we close this issue. We can always revisit if new question/issues come up.
Thanks very much for your help with this, folks!


docs: Add hubot::docker option for answers.yaml

If you're trying to use answers.yaml to automate installation of stackstorm including chatops setup, hubot::docker: True is required, if you don't want to use the webgui installer. This adds documentation for that to the docs.

Nice. Thanks!

Sean first thanks for the contribution; we are in the process of moving docs away to a separate repo https://github.com/StackStorm/st2docs so the more contributions will be against it, can you please coordinate with @manasdk on when it opens for contrib and get your [future] PRs against it? Thanks again.

can you please coordinate with @manasdk on when it opens for contrib and get your [future] PRs against it?

I can move it over. Unfortunately end up loosing commit history :(
Should be out of limbo by early next week.

Should I make commits against both for now, or should I be PRing against https://github.com/StackStorm/st2docs from now on? I only came here because of the "Edit this on GitHub" link on all of the docs pages.

@manasdk I'm happy to make the commit against st2docs if the history matters to you!

should I be PRing against https://github.com/StackStorm/st2docs from now on

Yes. Should PR against st2docs from now on. That where docs will live going forward.
Once st2docs stabilizes I plan to merge https://github.com/StackStorm/st2/pull/2365

if the history matters to you!

Indeed. I like giving folks due credit for contributions :)

once we move, and build off the new repo, the link will be showing to the correct repo, too.

Closing in favor of https://github.com/StackStorm/st2docs/pull/8


README instructions wrong?

Got errors running these commands:
cordova plugin add org.apache.cordova.camera
cordova plugin add org.apache.cordova.file-transfer
But it worked with these commands:
cordova plugin add cordova-plugin-camera
cordova plugin add cordova-plugin-file-transfer

Yes, I have updated the README with the correct commands


Better check for action changes on table row

Action bar was refreshing to much often.

Stringifying the actions before the check seems to have fixed it.
Added a check to only refresh the action bar actions when the row was selected.

Codecov Report

Merging #1084 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
- Coverage   99.77%   99.77%   -0.01%
==========================================
  Files         324      324
  Lines        8003     8001       -2
  Branches     1918     1917       -1
==========================================
- Hits         7985     7983       -2
  Misses         18       18

Impacted Files
Coverage Δ

src/components/table-hoc/TableRowConnected.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9103113...ac3b284. Read the comment docs.


"Openpilot failed to build" screen

Describe the bug
Downloaded the recent update to the master-ci on 1/20/23. When I got back in the car after the update the screen said "Openpilot failed to build". I hit the reset button but it keepos coming back to the same screen. On a 2022 Kia Sorento with Red Panda.

Provide a route where the issue occurs
No route
openpilot version
master-ci 1/20/23
Additional info
No response

There was a bad commit briefly on master.


Remove required flag from Replace action

Updated doc based on this PR
Hold merge until 2.7.0 is released

this can be merged in now

thanks!


fix: private registry only support https

registry support http/https and not default port

Sorry, but unpkg will never support non-https registries.


PiP While The Device Is Locked:

Can you add this option to keep it play while the device is locked or on the lock screen?
Thank you.

This doesn’t seem like its possible. Default iOS behaviour stops PiP playback when screen is locked. (See safari)

Potentially out of scope of YouPiP. Think of this as another tweak that forces PiP on the lock screen or something.


Changes to radarr.py to support API v3

https://github.com/HTPC-Manager/HTPC-Manager/issues/50
made some modifications to radarr.py to fix for the API v3, seems to work okay now for adding movies to Radarr

missed a change, will resubmit pull request

Many thanks! I can test the next days.

This works with the current stable version of Radarr, <IP_ADDRESS>09. The API itself is v3. The only thing that does not appear to work correctly is when it lists your movie library, all movies are shown as "missing" and I'm not sure how to address that.

Hmm, there are a lot of unresolved conflicts in Kodi and Plex modules now. It is all but the last two commits which need to be removed. However, if you have problems with it, I can clear this and squash the commits together before merging.


Updated name.ts

I have added a few new pet names of snake, duck, and crab.
Kindly review this pull request and consider it as a hacktoberfest contribution. Please let me know in case any changes are required. Thank You :)

Thanks for the PR! Please make the required changes.
Also you need to run npm run lint:fix in the repository as some of the lines have trailing spaces after the commas (or fix them by hand).

Codecov Report

Merging #293 (5be399f) into master (1065478) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   10.53%   10.53%
=======================================
  Files           5        5
  Lines         655      655
  Branches       92       92
=======================================
  Hits           69       69
  Misses        586      586

Impacted Files
Coverage Δ

src/common/names.ts
78.57% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update proxy.md

#6450

Deploy preview for docsdocker ready!
Built with commit 51d428f608531f9de76cac5fc695db56579d90f6
https://deploy-preview-8352--docsdocker.netlify.com

@thaJeztah Hi Sebastiaan - I know you are swamped - if you have a chance, PTAL. I'm just trying to get some older items closed out. Thanks, as always, for all your help and input.


test: add test setup and first test

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Move PNG report generation to the end of .run()

Since KLayout is now generating a design screenshot in its export task, the final report summaries no longer have any EDA tool dependencies and can be run locally.
Moving the image generation to the end of .run() will ensure that A) the image exists even if .summary() is not called, and B) the image is only re-generated when something is likely to have changed (after a new run/resume/etc).
HTML report generation is untouched for now, per offline discussion.

@nmoroze the call to summary is not always there and this ensures the file is always generated regardless and only pops up on calling summary(). It's more to make sure the file is there, the work to make the PNG is pretty light

@WRansohoff lets wait to merge until we can check with @aolofsson

It will probably be easier to discuss the reasoning offline; there are a few intertwined issues.
In a nutshell, the fix in #1379 introduced a new failure, and revealed that the summary-based report generation logic is probably brittle enough to merit some reconsideration.

@WRansohoff closing this per the offline discussion and will update tutorials instead