frontend i18n: Add 'fr' locale for French

Note to reviewers:

either leave review comments in the files tab with the suggested change, or leave a comment about a screenshot
for screenshot comments, please mention the number of the screenshot you're referring to (1-9)

How to use
Switch to French language in top right 'fr' locale choosing select box.
To run locally with this branch (you'll need golang and nodejs):
git clone git@github.com:kinvolk/headlamp.git
cd headlamp
git fetch --all
git checkout fr-fr

make backend frontend
make run-backend

In a separate terminal:
make run-frontend

Now it should open in the web browser with the clusters configured in your ~/.kube/config
1)

2)

3)

4)

5)

6)

7)

8)

9)

10)

How to use
Switch to French language in top right 'fr' locale choosing select box.
Testing done

[x] Went through different screens.
[x] Have translations reviewed

There's a lot of concepts here that shouldn't be translated to French.
E.g. resource conceptual names shouldn't be translated. I know that we have them marked to be translated but this is just in case some of them are and others aren't which may depend on the language.
A good place to check those is the Kubernetes docs. See how ReplicaSet is not translated.

I'll go through and update the Kubernetes terms like they do in the kubernetes docs/translations (and in the es/pt headlamp ones).

In f88f07e I used the Kubernetes english terms (like Role Binding, Config Maps, and Binding Info).
@eiffel-fl What do you think of them?

I fixed a few things from your comments here, and also replied:
https://github.com/kinvolk/headlamp/commit/f88f07e17e22bb9584536fe0f746d2b3a7018f62
(I missed these comments somehow because they didn't show up on this PR page... Some github bug I guess.)

I noticed "Use minimal editor" needs a translation (like in screenshot 5).
In resource.json
  "Use minimal editor": "Utiliser un éditeur minimal"

Thanks heaps @eiffel-fl :)

applied your patch
made a small fix for the 'Clear' one. By moving one of them into the notifications.json file. I'll have to fix the other langs (en/es/pt/etc) to use that one later.
However, I didn't debug the ones which aren't translated yet. Will do that next.

@eiffel-fl I pushed a couple of fixes for the ones shown in your screen shots. See the bottom of the fr/resource.json
However, I can't find the "Buffer is not defined" message anywhere. I guess it's an error message coming from... somewhere, perhaps in JS. Do you know how to reproduce getting that error?

Thanks for the patch @eiffel-fl , applied that one too.
Those two messages are translating properly now.


QuickFixes broken with linter 2.0

Using current version of Atom and atom-ide-purescript along with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>on a windows 7 machine.  When trying to use the QuickFixes feature nothing happens.  This is when evoking it through the keymap or directly through the Atom menu.  It used to work fine in previous version so I'm not sure what may have changed.

Sorry not had time to try reproduce this. Would be useful to note the particular Atom version (for posterity if nothing else) and a sample issue which you are attempting to use the fix on (e.g. is it a specific kind of import quickfix?)

Sure - Atom version = 1.15.0.  The issue is happening on import quickfixes with unused references.  Instead of removing the unused references, no action is taken at all.  I tried to check the logs, but it doesn't look like anything is logged when a quickfix action is taken.

Looks to be related to linter update. As a workaround right now, you can probably downgrade the atom-linter version - or maybe use pscid to apply fixes (or purescript-suggest).
The good news is that the linter updates bring some cool new stuff, that should let me delete code and have a better UX after updating - in particular https://github.com/steelbrain/intentions

Correct - downgrading Linter resolved the issue.

I'm working on this now, can hopefully release something this weekend that (only) works with the new Linter.

Done. Linter 2.0 will now be required, but giving a better UI https://github.com/nwolverson/atom-ide-purescript/releases/tag/v0.16.1


Refactor

Cleaning up the model schema
Creating CLI for loading generations

The Django documentation answers my question:
https://docs.djangoproject.com/en/3.1/ref/models/querysets/#django.db.models.query.QuerySet.create
However, if your model contains a manual primary key value that you set and if that value already exists in the database, a call to create() will fail with an IntegrityError since primary keys must be unique. Be prepared to handle the exception if you are using manual primary keys.

I agree that avoiding duplicates would be preferred, so I relied on falling back onto the good ole  IntegrityError from Django. Adding better support for management into the CLI is definitely on the roadmap, and until then, managing the Playlist and Model names using the Django Admin portal (i.e. /admin) is the way to go.


Optimized base.scss styles

Can you pls squash some commits. Atleast squash this two:
Switched div to button 8a87f746dc5c1e09064f78c78fa2c8e2a5d42903
Changed filter button to be a button cc44e6af1fa48795c9bba15b2b1957ff019f200b


feat: session id support for payloads

What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions:

Does the docs need an update?
Are there any security concerns?
Do we need to update engineering / success?

I think we're also missing a resetSessionId method ?

Adding Ben just for sess-rec awareness

Happy to add a review but not sure it has much impact on sesh-rec world...?

D'oh, right, you wouldn't need this at all, since no session recordings on mobile 🤦

Closed in favor of https://github.com/PostHog/posthog-ios/pull/100


toLowerCase == static string with upper case values?

i've done this a few times
if(someVariable.toLowerCase() == 'thisThing'){
}
and this is obvious nonsense, can this create a compiler warning?

TypeScript does't treat any individual methods specially. All toLowerCase tells the compiler is that the method returns a string, which doesn't carry any information about what kinds of characters are in the resulting string.
This seems more in the domain of a lint rule which you could write up.


[Documentation] Layout is broken on Cr, FF and Safari (probably others too)

In the documentation, we currently have a big white bar appearing.
https://www.dropbox.com/s/0sxyu85eicokgei/Screenshot 2016-05-17 10.26.51.png?dl=0

fixed with https://github.com/algolia/instantsearch.js/commit/4759a0e13df1a6db5680abeb6f7d24f9f4740211


Add Migrate *_filter to *_action feature

Description:
Closes https://github.com/fastruby/rails_upgrader/issues/22
I will abide by the code of conduct.

@bronzdoc Closing this PR since it has been in stale state for a long time. Feel free to re-open it if you want to continue with it. Thank you!


Plugin Settings Page is blank.

The settings page for the plugin is blank except for the sponsor button.

When I open the console, this error message appears and seems relevant.
VM343 plugin:obsidia…ble-reference:12979 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'isFeatureEnabled')
    at BibleReferenceSettingTab.setUpVersionSettingsAndVersionOptions (VM343 plugin:obsidia…-reference:12979:50)
    at BibleReferenceSettingTab.display (VM343 plugin:obsidia…-reference:12848:10)

That seems related to this function here:
  setUpVersionSettingsAndVersionOptions() {
    let allAvailableVersionOptions = allBibleVersionsWithLanguageNameAlphabetically;
    const disableBibleAPI = FlagService.instance.isFeatureEnabled("disable-bible-api");  //  <-- This line specifically as the .isFeatureEnabled is flagged as having an error.
    if (disableBibleAPI) {
      allAvailableVersionOptions = allAvailableVersionOptions.filter((v) => {
        return v.apiSource.name !== BibleAPISourceCollection.bibleApi.name;
      });
    }

Device: Lenovo Thinkpad T480
OS: Windows 10
Obsidian Version : v1 .7.1 (Installer version: V1 .5.12)
Plugin Version: v3.1.1

I probably wouldn't have worried about reporting this, but it switched Bible versions on me and I can't switch translations.

I'm on the default Obsidian Theme and have no other plugins installed.
Tried uninstalling and reinstalling the plugin.
Not sure when this started.

Happy to poke around and try to help in any way I can or provide more info.
Thanks so much for this awesome plugin. I love it.  It's been super helpful as I've been working on a research project on the conscience.

Thanks, I can see it in one of my computers as well, let me fix it.

It is fixed in 3.1.2, can you have a try?
https://github.com/tim-hub/obsidian-bible-reference/releases/tag/3.1.2

@all-contributors add @Redster1  for bug

It's fixed! 🎉
Thank you so much!


Config: Cleanup typing of dotdict

Remove ignore by allowing any object to be passed to contains (and return False if not a str)
Make explicit in type annotation that keys must be str
Take a generic mapping as input to constructor

bors merge


v-model not working inside jquery steps plugin

I have jquery steps and form input. I have used v-model to bind input to vue data. It works perfect if i don't initialize jquery steps plugin. But When i Initialize jquery steps plugin v-model cannot bind the input.
I think jquery steps is rerendering the html tags so that v-model could not access that input . But is there any way to bind v-model to input inside such plugin ??

I have jquery steps and form input. I have used v-model to bind input to vue data. It works perfect if i don't initialize jquery steps plugin. But When i Initialize jquery steps plugin v-model cannot bind the input.
I think jquery steps is rerendering the html tags so that v-model could not access that input . But is there any way to bind v-model to input inside such plugin ??

You can check if vue app is initialise or not when steps get changes
`onStepChanged: function(event, currentIndex, priorIndex) {
if(currentIndex == 3) {
const mountPoint = document.querySelector("#selector");
if (mountPoint && mountPoint.vue_app === undefined) {
// Vue app is not initialized, initialize it
initVueApp();
} else {
// Vue app is already initialized
console.log('Vue app is already initialized!');
}
			}
		},`


syz-fuzzer: invalid memory address or nil pointer dereference at BuildChoiceTable

OS: FreeBSD
Dashboard: https://syzkaller.appspot.com/bug?extid=b69eae15f92f0f50575b
Report:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x5d3d24]

goroutine 1 [running]:
github.com/google/syzkaller/prog.(*Target).BuildChoiceTable(0xc0000a9040, 0xc010ce0000, 0xe146, 0xf000, 0xc00b9cfe48, 0x3)
	/syzkaller/gopath/src/github.com/google/syzkaller/prog/prio.go:213 +0x354
main.main()
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:276 +0x13af

FreeBSD/amd64 (ci-freebsd-main-6.c.syzkaller.internal) (ttyu0)

login:

Log
Starting background file system checks in 60 seconds.

Mon Sep 27 08:47:10 UTC 2021

FreeBSD/amd64 (ci-freebsd-main-6.c.syzkaller.internal) (ttyu0)

Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
2021/09/27 08:47:25 fuzzer started
2021/09/27 08:47:25 dialing manager at <IP_ADDRESS>:24542
2021/09/27 08:47:25 syscalls: 828
2021/09/27 08:47:25 code coverage: enabled
2021/09/27 08:47:25 comparison tracing: enabled
2021/09/27 08:47:25 extra coverage: support is not implemented in syzkaller
2021/09/27 08:47:25 setuid sandbox: support is not implemented in syzkaller
2021/09/27 08:47:25 namespace sandbox: support is not implemented in syzkaller
2021/09/27 08:47:25 Android sandbox: support is not implemented in syzkaller
2021/09/27 08:47:25 fault injection: support is not implemented in syzkaller
2021/09/27 08:47:25 leak checking: support is not implemented in syzkaller
2021/09/27 08:47:25 net packet injection: enabled
2021/09/27 08:47:25 net device setup: support is not implemented in syzkaller
2021/09/27 08:47:25 concurrency sanitizer: support is not implemented in syzkaller
2021/09/27 08:47:25 devlink PCI setup: support is not implemented in syzkaller
2021/09/27 08:47:25 USB emulation: support is not implemented in syzkaller
2021/09/27 08:47:25 hci packet injection: support is not implemented in syzkaller
2021/09/27 08:47:25 wifi device emulation: support is not implemented in syzkaller
2021/09/27 08:47:25 802.15.4 emulation: support is not implemented in syzkaller
2021/09/27 08:47:25 fetching corpus: 0, signal 0/2000 (executing program)
2021/09/27 08:47:25 fetching corpus: 50, signal 12041/16012 (executing program)
<...>
2021/09/27 08:47:26 fetching corpus: 850, signal 95452/129320 (executing program)
login: Expensive timeout(9) function: 0xffffffff81f78bb0(0xffffffff841bd680) 0.018718503 s
2021/09/27 08:47:26 fetching corpus: 900, signal 101386/136993 (executing program)
2021/09/27 08:47:26 fetching corpus: 950, signal 106046/143420 (executing program)
2021/09/27 08:47:26 fetching corpus: 1000, signal 110255/149402 (executing program)
<...>
2021/09/27 08:48:23 fetching corpus: 57670, signal 1687375/1716696 (executing program)
2021/09/27 08:48:23 fetching corpus: 57670, signal 1687375/1716696 (executing program)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x5d3d24]

goroutine 1 [running]:
github.com/google/syzkaller/prog.(*Target).BuildChoiceTable(0xc0000a9040, 0xc010ce0000, 0xe146, 0xf000, 0xc00b9cfe48, 0x3)
	/syzkaller/gopath/src/github.com/google/syzkaller/prog/prio.go:213 +0x354
main.main()
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:276 +0x13af

FreeBSD/amd64 (ci-freebsd-main-6.c.syzkaller.internal) (ttyu0)

login:

A probably related crash - assignment to entry in nil map:
Dashboard: https://syzkaller.appspot.com/bug?extid=b69eae15f92f0f50575b
Report:
panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/google/syzkaller/pkg/signal.Serial.Deserialize(0xc000369500, 0x0, 0x0, 0xc000324a00, 0x690, 0x0, 0x0)
	/syzkaller/gopath/src/github.com/google/syzkaller/pkg/signal/signal.go:91 +0xa0
main.(*Fuzzer).addInputFromAnotherFuzzer(0xc0000b0d00, 0xc000092ba0, 0x28, 0xc000448140, 0x126, 0x126, 0xc000369500, 0x690, 0x690, 0xc000324a00, ...)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:439 +0x103
main.(*Fuzzer).poll(0xc0000b0d00, 0x99e200, 0x0, 0xc00033be78)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:412 +0x427
main.main()
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:267 +0x11d6

Log:
2021/09/27 11:03:22 fuzzer started
2021/09/27 11:03:22 dialing manager at <IP_ADDRESS>:54477
2021/09/27 11:03:23 syscalls: 828
2021/09/27 11:03:23 code coverage: enabled
2021/09/27 11:03:23 comparison tracing: enabled
2021/09/27 11:03:23 extra coverage: support is not implemented in syzkaller
2021/09/27 11:03:23 setuid sandbox: support is not implemented in syzkaller
2021/09/27 11:03:23 namespace sandbox: support is not implemented in syzkaller
2021/09/27 11:03:23 Android sandbox: support is not implemented in syzkaller
2021/09/27 11:03:23 fault injection: support is not implemented in syzkaller
2021/09/27 11:03:23 leak checking: support is not implemented in syzkaller
2021/09/27 11:03:23 net packet injection: enabled
2021/09/27 11:03:23 net device setup: support is not implemented in syzkaller
2021/09/27 11:03:23 concurrency sanitizer: support is not implemented in syzkaller
2021/09/27 11:03:23 devlink PCI setup: support is not implemented in syzkaller
2021/09/27 11:03:23 USB emulation: support is not implemented in syzkaller
2021/09/27 11:03:23 hci packet injection: support is not implemented in syzkaller
2021/09/27 11:03:23 wifi device emulation: support is not implemented in syzkaller
2021/09/27 11:03:23 802.15.4 emulation: support is not implemented in syzkaller
2021/09/27 11:03:23 fetching corpus: 0, signal 0/2000 (executing program)
panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/google/syzkaller/pkg/signal.Serial.Deserialize(0xc000369500, 0x0, 0x0, 0xc000324a00, 0x690, 0x0, 0x0)
	/syzkaller/gopath/src/github.com/google/syzkaller/pkg/signal/signal.go:91 +0xa0
main.(*Fuzzer).addInputFromAnotherFuzzer(0xc0000b0d00, 0xc000092ba0, 0x28, 0xc000448140, 0x126, 0x126, 0xc000369500, 0x690, 0x690, 0xc000324a00, ...)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:439 +0x103
main.(*Fuzzer).poll(0xc0000b0d00, 0x99e200, 0x0, 0xc00033be78)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:412 +0x427
main.main()
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:267 +0x11d6

And also this one (looks more promising for debugging purposes)
Dashboard: https://syzkaller.appspot.com/bug?extid=2f86134b30793b5438cf
Report:
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
target: freebsd/amd64, rev: 8cac236e8c3741446e540b2fe0702086a4ae4c17, mode=1, prog:
"r0 = socket$inet_sctp(0x2, 0x5, 0x84)\nconnect$inet(r0, &(0x7f0000000080)={0x10, 0x2, 0x2, @rand_addr=0x79}, 0x10)\ngetsockopt$inet_sctp_SCTP_PEER_ADDR_PARAMS(r0, 0x84, 0xa, &(0x7f0000000840)={@in6={{0x1c, 0x1c, 0x2, 0x0, @rand_addr=\"09ae5aa61fd79b128970dd7e52030fe4\"}}}, &(0x7f0000000100)=0x98)\n"
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5e7351]

goroutine 1 [running]:
github.com/google/syzkaller/prog.(*Target).Deserialize.func1(0xc000101040, 0x1, 0xc000372640, 0x126, 0x126)
	/syzkaller/gopath/src/github.com/google/syzkaller/prog/encoding.go:237 +0x228
panic(0x8f70c0, 0x10354f0)
	/syzkaller/go/src/runtime/panic.go:969 +0x166
github.com/google/syzkaller/prog.(*Prog).validate(0x0, 0x0, 0x0)
	/syzkaller/gopath/src/github.com/google/syzkaller/prog/validation.go:32 +0x71
github.com/google/syzkaller/prog.(*Target).Deserialize(0xc000101040, 0xc000372640, 0x126, 0x126, 0x1, 0x0, 0x0, 0x0)
	/syzkaller/gopath/src/github.com/google/syzkaller/prog/encoding.go:252 +0x1b6
main.(*Fuzzer).deserializeInput(0xc000101a00, 0xc000372640, 0x126, 0x126, 0x25fc13b030d1496e)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:462 +0x69
main.(*Fuzzer).addInputFromAnotherFuzzer(0xc000101a00, 0xc000028330, 0x2a, 0xc000372640, 0x126, 0x126, 0xc000332d80, 0x344, 0x344, 0xc0000bd880, ...)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:434 +0x59
main.(*Fuzzer).poll(0xc000101a00, 0x99e200, 0x0, 0xc00033fe78)
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:412 +0x427
main.main()
	/syzkaller/gopath/src/github.com/google/syzkaller/syz-fuzzer/fuzzer.go:267 +0x11d6

I've started hitting a similar-looking problem locally. Currently bisecting, it's probably a FreeBSD regression.

Almost certainly fixed by https://cgit.freebsd.org/src/commit/?id=b1e2f063ae912dc5b7a7f6638ccb3aff14f299cf


Add native animation support to PopochiuCharacter

This issue is somehow related to #8
The current implementation of each game object only supports a sprite to represent the object in both the editor scene and the game.
Also, besides flipping the player character's sprite when it moves, no accurate directions are taken into account to turn the sprite accordingly to the movement direction.
What should be done

[x] Add an AnimationPlayer element to PopochiuCharacter base scene to control the sprite by means of one or more animations
[x] Make sure the character actually plays the walk animation while walking
[x] Take the 8 directions that are listed in the LOOKING enum into consideration when an animation is played (i.e. if the character is facing down-right and we have an animation to make them talk down-right, that has to be played.
[x] Make sure to fall back on the 4 directions or the most simple case of "no direction" (like there is no "talk right" but just "talk" so use it, flipping the animation if necessary)
[x] Introduce a naming convention for directional animations (eg <animation_name>_dl for down-left, <animation_name>_d for down, <animation_name>_l for left, and so on.

Maybe I'm overlooking something meaningful, in case I'll take more notes in here.

This has been long closed.


HTML5 memory leak

I don't really know where to start to look into this. There's no terminal or console warnings. I was using Phaser and am now porting my game over to HaxeFlixel. I ran into a bad memory leak today in my project (a simple object catching game with pngs, spritesheets, fonts, and sounds). It ran all the way up to 150GB in a matter of seconds.
What I've tried: update haxelib, using git versions of lime/openfl/hcxpp, and using different browsers. I'm stumped so I thought I would make this public. Will happily provide private access to my repo if anyone has time to take a look.
Only is happening in the html5 target (tried debug & final options). Memory usage is fine in neko target although my sound wasn't playing which is why I tried html5 in the first place.

Do you have a code that can reproduce the problem?

Gave you access to my private repo. The memory runs up as soon as you load it in the html5 target.

Gave you access to my private repo. The memory runs up as soon as you load it in the html5 target.

I built the game and it works fine.

I contacted you on discord.

Weird, you're right, I just built it on my old Linux laptop and no memory leak there. It must be my OS/hardware (macOS 15.1, M2 Mac mini).
I just tried creating a fresh user account on the Mac, made a new directory for haxelib and installed haxe/lime/openfl/flixel. Ran lime test html5 and the leak is back. I'm keeping this open in case anyone has any ideas or can look into it further.

Weird, you're right, I just built it on my old Linux laptop and no memory leak there. It must be my OS/hardware (macOS 15.1, M2 Mac mini). I just tried creating a fresh user account on the Mac, made a new directory for haxelib and installed haxe/lime/openfl/flixel. Ran lime test html5 and the leak is back. I'm keeping this open in case anyone has any ideas or can look into it further.

try to update flixel with haxelib install flixel

Ok, It's my project. Not happening in any examples. I'm gonna comment out every line of code tomorrow until I find the line that was causing the issue, and post it here & close the issue.

Ok, It's my project. Not happening in any examples. I'm gonna comment out every line of code tomorrow until I find the line that was causing the issue, and post it here & close the issue.

Ok I found the problem, the problem is debug draw can you please start the program without debug and retry?

That's it!
FlxG.debugger.drawDebug = true;
Thank you. Should we close the issue now?

That's it! FlxG.debugger.drawDebug = true; Thank you. Should we close the issue now?

I think don't close issue because it is a problem that debug draw causes this.

Please create the issue here: https://github.com/HaxeFlixel/flixel/issues

Will do.

Here is the link to the new issue.


navigateTo() returns error

Are you requesting a feature or reporting a bug?
bug
What is the current behavior?
.navigateTo() always returns an Uncaught SyntaxError: Unexpected identifier
What is the expected behavior?
.navigateTo() should navigate to the specified web page.
How would you reproduce the current behavior (if this is a bug)?
Pretty straightforward, any test (a relative or absolute URL path) and then wait().
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
await t
        .navigateTo('https://google.ca/')
        .wait(1000)

Specify your

operating system: Windows 10
testcafe version: 0.11.1
node.js version: 6.9.1

Hi Steven,
I've tried to run the following test in chrome, firefox and ie:
fixture `Example`
    .page `http://github.com`;

test('Check navigateTo', async t => {
    await t
        .navigateTo('https://google.ca/')
        .wait(1000)
});

It works properly on my side:

Could you please provide the whole test to reproduce the problem.
If you run the test in chrome try to check it in the incognito mode to disable all extensions:
testcafe "chrome --incognito" test.js

Hi,
Yes you are correct, this test also "passes" (doesn't fail) for me:
fixture `Example page test navigateTo`
    .page `http://www.yahoo.com/`;

const pauseMs = 1000;

test('Emulate simple navigateTo', async t => {
    await t
        .setNativeDialogHandler(() => true)
        .navigateTo('/foo')
        .wait(pauseMs)
});

However, this test does not "pass", gives an error "Uncaught SyntaxError: Unexpected identifier":
import {
    Selector
} from 'testcafe';

fixture `Example page`
    .page `http://www.example.com/`;

const pauseMs = 10000;

test('Emulate user actions and perform a verification', async t => {
    await t
        .setNativeDialogHandler(() => true)
        .hover('#username')
        .typeText('#username', 'user1')
        .wait(500)
        .hover('#password')
        .typeText('#password', 'pwd')
        .wait(500)
        .hover('#signBtn')
        .click('#signBtn')
        .wait(pauseMs * 2)

     // <snip> a little logic here, of no consequence

    await t
        .navigateTo('/foo')
        .wait(pauseMs) // ERROR: Uncaught SyntaxError: Unexpected identifier
});

Apparently my syntax is just incorrect somewhere?

Actual documentation for the open-source TestCafe version is here: https://devexpress.github.io/testcafe/documentation/getting-started/
You can find how to ignore js-errors on the page in the Command Line Interface article

Actual documentation for the open-source TestCafe version is here: https://devexpress.github.io/testcafe/documentation/getting-started/
You can find how to ignore js-errors on the page in the Command Line Interface article

It seems that testcafe -e ... arg does the trick. I think this ticket can be closed!


FEAT: handle 304 response in jsonapi request processor

A response with status code 304 indicates that we already have the
latest, valid representation available.
Currently a response with this status results in an error. With this
change such a response is handled in a successful manner, which results
in a transform with no operations.

I am not fully familiar with all the concepts yet and pretty sure I am missing something. This is just my initial stab at addressing parts of #577 and putting this out there to get more input.
I am especially unsure about having a transform with no operations, which I guess should be no transform at all...
Appreciate pointers in any direction and happy to make changes.

Maybe we should return just undefined (as in case of 204) which will result in a response with no transforms?


strings color

gruvbox dark mode has green strings on screenshot but I see white.
Is it OK?

Color groups are still a WIP, so some groups may still be wrong

Thanks for your quick response!

Actually this looks like an issue with using unpack here. I assume it's interacting weirdly with lush.
Here's what the String highlight group says

yep, will take a look on that

hey @harrygallagher4 @Stanislav-Lapata i did a partial which fixed that initial problem. Can you guys pull latest and try again please?

Looks good! By the way, when fixed this locally I used:
    String (special_string),

which is a bit more concise than splitting up the table into a bunch of improved_strings_* variables. It's sort of a hacky way to use the lush dsl though, I haven't seen that syntax used anywhere in the lush examples.

yep, ive opened #18 to investigate special string cases.


Improve Script Transforms

Description
Having used ESBuild transforms for the script asset pipeline for some time now, I've noticed that the current approach of limiting options is problematic and all available options should be exposed.
Refactors
Will like refactor the processors configuration option and instead infer all usage within transforms.scripts
Notes

Consider Terser and a final pass-through
Consider replicating some transform approach as TSUP: ESBuild > Rollup / SVC > Terser / ESbuild Minify
Make snippet generation more user friendly

For now, this is viable. Using pre-existing logic of ESBuild


Vagrant VM no longer available.

in base Vagrant file
The following box seems to be no longer available and 404s when I run it
config.vm.box = "ubuntu/trusty64"
Suggest
config.vm.box = "http://files.vagrantup.com/precise64.box"

Hi Robert
The Vagrant box seems to be there: ubuntu/trusty64. It was even updated 18 minutes ago!
I just removed by local copy and re-ran the provision and it downloaded the box fine.
I'm going to close this for now but do feel free to re-open and let me know if you still have problems.


Add support for lint in client/

Current lint command only affects server/ directory.
But we have already much codes in client/ directory as well.
So, we should make the lint command apply to client/ directory as well and fix all lint error.

I'll take this issue :)

@sapzape Go ahead! Thanks :)


Health check with hostname

Do you want to request a feature or report a bug?
bug
What did you do?
setup traefik with file config
    [backends.insideapi_backend.servers]
      [backends.insideapi_backend.servers.server0]
      url = "http://ip:80"
      [backends.insideapi_backend.servers.server1]
      url = "http://ip:80"
    [backends.insideapi_backend.healthCheck]
      path = "/api/integrate/status"
      port = 80
      interval = "1s"
      hostname = "insideapi.local"

What did you expect to see?
Traefik health check with url like this http://ip/api/integrate/status (with header Host:insideapi.local)
What did you see instead?
Traefik health check with url like this http://ip/api/integrate/status (without hostname header)
Output of traefik version: (What version of Traefik are you using?)

{
 "LifeCycle": {
  "RequestAcceptGraceTimeout": 0,
  "GraceTimeOut": 0
 },
 "GraceTimeOut": 0,
 "Debug": false,
 "CheckNewVersion": true,
 "SendAnonymousUsage": false,
 "AccessLogsFile": "",
 "AccessLog": null,
 "TraefikLogsFile": "",
 "TraefikLog": null,
 "Tracing": null,
 "LogLevel": "",
 "EntryPoints": {},
 "Cluster": null,
 "Constraints": [],
 "ACME": null,
 "DefaultEntryPoints": [
  "http"
 ],
 "ProvidersThrottleDuration":<PHONE_NUMBER>,
 "MaxIdleConnsPerHost": 200,
 "IdleTimeout": 0,
 "InsecureSkipVerify": false,
 "RootCAs": null,
 "Retry": null,
 "HealthCheck": {
  "Interval":<PHONE_NUMBER>0
 },
 "RespondingTimeouts": null,
 "ForwardingTimeouts": null,
 "AllowMinWeightZero": false,
 "Web": null,
 "Docker": null,
 "File": null,
 "Marathon": null,
 "Consul": null,
 "ConsulCatalog": null,
 "Etcd": null,
 "Zookeeper": null,
 "Boltdb": null,
 "Kubernetes": null,
 "Mesos": null,
 "Eureka": null,
 "ECS": null,
 "Rancher": null,
 "DynamoDB": null,
 "ServiceFabric": null,
 "Rest": null,
 "API": null,
 "Metrics": null,
 "Ping": null,
 "ConfigFile": ""
}

Thanks for your interest in Traefik 😃
The hostname option has been added in v1.7 (current master), see the milestone of #3047.
It's not available in 1.6.


update to new zig build API

Really appreciate all the patches!

Thanks! All dependencies of gyro build on the master branch now ;)


make examples executable, remove run task

Shall we make each example executable?
The additional leading text isn't very pretty...
#!/usr/bin/env deno run -A

... but it would allow for less-obfuscation of the example-running command:
- deno task run examples/<example-name>.ts
+ deno task capi -- examples/<example-name>.ts

This better-showcases how the Capi CLI ingests commands

Decided not to pursue this, as it bloats examples and is misaligned with how devs are likely to actually use the Capi CLI.


Prevent copy from copying text from the adjacent column in a diff

When I try to copy text from a split diff, it should restrict the copying to one column only and not both. Would you please consider adding this?

👎 That would add a lot of complexity for very limited gain. Just switch to Unified diff if you want to copy from a diff.

Fair enough. Thank you!


Manually entering an invalid date causes some completely different date to be used

Describe the bug
In my company, we use the Norwegian date format dd.MM.yyyy. The problem may or may not exist in other date formats.
Let's say someone fatty-fingers when manually inputting a date (as opposed to picking one from the calendar) and writes 29.02.2023. This is an invalid date; 2023 is not a leap year. This turns into the date 2020-02-29, which is a valid date (2020 was a leap year).
Why does this happen? By testing, I have concluded that DatePicker uses the last date it saw and understood. That means that while the user was typing, the input at some point read 29.02.20. DatePicker saw 20 as the short version of  2020, giving the date 2020-02-29.
Note: This is not limited to the leap day. Typing 31.04.2023 becomes 2023-02-03 for some reason. Exactly what it becomes appears to be dependent on the current month.
To Reproduce
Steps to reproduce the behavior:

Create a datepicker with format dd.MM.yyyy
Manually enter the date 29.02.2023
Blur the input. The date changes to 29.02.2020. It requires a watchful eye to catch this.

Expected behavior
The date should be recognized as invalid. I'm not sure how this should be displayed to the user, but the value should be an invalid date object. At least not one representing a completely different date than what is shown.

Hey , do you got any solution to this problem ?

I don't have a solution (this would be a PR fixing the bug), let's say a temporary workaround


Error Handling: As described in email

Feature Description
The functions that modify the QF arrays typically reference a shape file that it assumes to exist. Instead of having, for example, qf_arrs.mod_wetlands() crash the script if the wetlands shapefile isn't read in; I would rather there be a try statement with the except warning the user that the function didn't run because the script didn't read in the correct shapefile.
Getting Started
Look at implementation of qf_arrs.build_fuelbreak() and qf.arrs.mod_wetlands(). Warn user if there script is not tracking the appropriated shapefiles to implement the function. Feel free to implement additional error handling where you see fit.
Screenshots

https://github.com/QUIC-Fire-TT/ttrs_quicfire/blob/1e8fc9edd59130511f8551c7fc0f25f1314d09a1/ttrs_quicfire/build_shapefiles.py#L51-L53
I added this raise FileNotFound if the file_path is None in load_shapefile(). This allows us to do a try except anytime we call this function and if the filepath is saved as None it will allow us to handle it in any way we deem fit. I was initially running into an issue trying to do it in clip_to_bbox since mod_wetlands() called this function and then the file was opened in there.
https://github.com/QUIC-Fire-TT/ttrs_quicfire/blob/699a1ceac9f141cbe9bcd0f4821b1478d66a239c/ttrs_quicfire/quic_fire.py#L132-L134
This is because I assumed that everytime we used clip_to_bbox this is the way it was handled. I finally realized that as in the code below, sometimes the file was opened beforehand.
https://github.com/QUIC-Fire-TT/ttrs_quicfire/blob/699a1ceac9f141cbe9bcd0f4821b1478d66a239c/ttrs_quicfire/quic_fire.py#L172-L180
In the end, adding this raise to load_shapefile and changing the behavior of mod_wetlands was easier and may allow for the removal of the loads within clip_to_bbox. The only issue may be with the bbox filepaths in that function but if so a try catch should be able to handle that there for all instances of the bbox.
I believe for now this issue can be resolved but some fine tuning or cleanup may be needed in the future.

I think that should be good. I'll run a few test and merge it to main.

Since when burn_plot.shp doesn't exist nothing can be built, it is better to handle the continuation on a case by case basis. This means that I added a condition to the try except in mod_wetlands like so:
https://github.com/QUIC-Fire-TT/ttrs_quicfire/blob/1916494b8c1d6fdfba903b7d489629bbbc3e9784/ttrs_quicfire/quic_fire.py#L137-L145
This is how any additional try except for shapefile loads should be handled unless it is required, in which case only sys.exit() should be called.


End-to-end tests

End-to-end test for the provider
The logging part will only pass once https://github.com/ofiliz/virtual-kubelet/pull/1 and https://github.com/ofiliz/virtual-kubelet/pull/3 are merged.
Currently the tests are failing with:
2018/04/21 15:04:08 RegisterTaskDefinition input:{
  ContainerDefinitions: [{
      Command: ["-c","echo \"Started\"; while true; do sleep 1; done"],
      Cpu: 204,
      EntryPoint: ["/bin/sh"],
      Image: "busybox",
      LogConfiguration: {
        LogDriver: "awslogs",
        Options: {
          awslogs-region: "us-east-1",
          awslogs-stream-prefix: "vk-podspec_arn:aws:ecs:us-east-1:439744694103:cluster/vk-aws-e2e-test_default_test_1524315848382468_echo-container",
          awslogs-group: "/ecs/vk-aws-e2e-test"
        }
      },
      Memory: 450,
      MemoryReservation: 256,
      Name: "echo-container"
    }],
  Cpu: "256",
  Family: "vk-podspec_arn:aws:ecs:us-east-1:439744694103:cluster/vk-aws-e2e-test_default_test_1524315848382468",
  Memory: "512",
  NetworkMode: "awsvpc",
  RequiresCompatibilities: ["FARGATE"]
}
2018/04/21 15:04:08 RegisterTaskDefinition err:ClientException: Family contains invalid characters.
	status code: 400, request id: 7a38f81a-4564-11e8-957f-f35d2c658fc8 output:{

}

Are those the not-yet released changes you mentioned @ofiliz?

No. The RegisterTaskDefinition call is failing because cluster ARN contains characters ':' and '/'. Family field can only consist of alphanumeric, hypen and underscore.
We'll either have to remove cluster name from the family, or use the cluster name (not the ARN).
I wanted the cluster name in the family, because task definitions are shared between clusters and we should be able to tell which task def is created for which cluster.

We'll either have to remove cluster name from the family, or use the cluster name (not the ARN).

Sounds good, do you want to implement this change or should I?


docs: clarity on LIST operations

The docs talk of use_update_marker to reduce S3 bills, but the obvious question here is what is the frequency of the LIST calls in the first place. The docs are silent on that ?
The different commercial S3 providers provide different levels of "free" LIST calls and so it would be nice to have an accurate guess at at which point people would exceed "free" and have a good idea of likely S3 bills.

This is the LS config item that controls how often we do a LIST if use_update_marker is not in use:
# Check the storage for new snapshots at this interval
#storage_poll_interval: 1s

The relationship between this config item and S3 LIST requests, and how this affects costs should indeed be documented.
If I remember correctly, with AWS and use_update_marker enabled, the estimated costs for a small deployment would be around 1 USD per month per node. Please correct me if you find this is incorrect.
For AWS a LIST command is 10x more expensive than a GET command, so use_update_marker reduces the poll costs tenfold, minus the occasional LIST forced by update_marker_force_list_interval, which defaults to 5m.

It's fine for production use if you are not doing cross region or datacenter S3 bucket syncing.
And even if you use such syncing, the update_marker_force_list_interval will fixup any issues with updates missed due to the update marker and files not being synced in the right order.


[Feature Request] Saving and replacing or starting with different simulation solutions

Description
A method to simulate differently aged cells in one and the same circuit with liionpack. After a given amount of cycles one can specify cells in the circuit that are to be removed and replaced with unaged or other cells from another circuit which has been cycled differently.
Motivation

Simulate the behaviour of systems which combine aged/non-aged cells
Simulate the behaviour of systems which contains differently aged cells
Expand the number of cells in a circuit. How does behaviour change when the dimentions Np x Ns are changed? (Either by decreasing or increasing circuit size [I: Which cells should be removed? II: System behaviour with the inclusion of non-aged cells or differently aged cells combined with the initial system])
In BESS some cells has to be replaced before the system is decommissioned, this can be modelled to simulate behaviour when some cells are replaced with fresh (non-aged) cells (or differently aged cells from another system) whilst the majority of the original cells are left as they are in the BESS
Capacity is lost over time and a BESS may need to replace its capacity to sustain its purpuse or expand its capacity for a different use case where more capacity is needed. Simulating this may bring insight into how this can be done efficiently?

Possible Implementation
Initial condition expansion:

different_initial_soc.py from the liionpack repo. shows how different SoC can be set with update_init_conc(param, SoC=None, update=True)
update_init_conc() could be expanded to include a variable that describes aging such as SoH or RuL

A general implementation which allows saving and replacing or starting with different simulation solutions:

Run a cell degradation model over a number of cycles and then copy the solution (which can be different for each specified cell) to initialize the pack
Chose which cell(s) to replace by defining which position(s) in the Np x Ns circuit are to be replaced and which cells should remain
Chose a new Np x Ns dimention and which cells it contains (either new cells or cells which have been aged)

Additional context
No response

Thanks @Mykle99 I think a first step would be to change liionpack to accept an initial PyBaMM solution to start from. Currently the solutions are initialised behind the scenes to save transferring data to parallel processors. PyBaMM does not allow you to specify an SoH or RuL as an initial condition because it would be way too complicated and subjective. However what you could do is run a single cell simulation for a number of cycles and copy solutions at the end of different cycles into the pack format. Or like you say, run a pack simulation for a bit then replace some cells with fresh cells. Both methods would require passing in starting solutions rather than starting concentrations.

Is there a way to bounty issues/feature requests?

Do you mean upvote or are you asking if you can pay for it?

Is paying within the guidelines of GitHub, or is it not allowed? From the nature of your answer I assume, there are no personal reputation bounties similar to those found on StackOverflow.

No I don't think so


msi: remove unnecessary path delimiter

The last character of %~dp0 is \, so we don't need add it.
(Though it appears it does not cause any problems.)

Note: https://github.com/fluent/fluent-package-builder/pull/606#issuecomment-1851432074


Default font has non-zero spacing between characters

When using default Monospaced font in Windows 10 and JDK 17, there's a spacing between characters that breaks continuity of elements such as lines.

This, however, doesn't happen in macOS, probably because it's using a different font.

Changing COSPLAY_EMUTERM_CH_HEIGHT_OFFSET and COSPLAY_EMUTERM_CH_WIDTH_OFFSET doesn't solve this issue, since the existing spacing goes all around the character and the offset would only go for one direction.
Using a different font would solve this, but I've struggled to find a font with wide support of Unicode characters and, at the same time, pleasant appearance.
Changing the TextAttribute.TRACKING value of the font would probably work.

Not sure this addresses it but you can use following system properties (see http://cosplayengine.com/devguide/game_structure.html#system-props):

COSPLAY_EMUTERM_CH_WIDTH_OFFSET
COSPLAY_EMUTERM_CH_HEIGHT_OFFSET

Also, if you can provide OS/JVM/Font name you are using along with a screenshot - that would help.

Not sure this addresses it but you can use following system properties (see http://cosplayengine.com/devguide/game_structure.html#system-props):

COSPLAY_EMUTERM_CH_WIDTH_OFFSET
COSPLAY_EMUTERM_CH_HEIGHT_OFFSET

to change how fonts are rendered in the terminal emulator. Or... use different font all together.
Also, if you can provide OS/JVM/Font name you are using along with a screenshot - that would help.

I've edited the issue's original description to add more information and answer your questions

Here's couple of thoughts on this issue.

This only applies to built-in CosPlay terminal emulation. If you play the game natively, i.e. in ANSI terminal - there's no way to control the font. You can theoretically ask the user to install & use a certain font - but the chances of that actually done are pretty slim. Again - there's no technical way to change (or even know) the font that used by the native terminal.

I've played with TextAttribute.TRACKING and it has zero effect on the default font used (Monospace). Moreover (see p.1) even if it would work It may be perceived as a slight cheating as the game will certainly look different in the native terminal.

2.1 I'm typing this on MacOS and I don't get the same smoothness on the font as you do ( at least using the default CosPlay terminal emulator font).


[Language Text] Implement cancellation outside pollers

Canceling a long-running operation is currently done by calling cancelOperation: https://github.com/Azure/azure-sdk-for-js/blob/eb0aa1da675c97b07739cf02ba0482c9b1ae8901/sdk/core/core-lro/src/poller.ts#L79-L82 However the cancellation behavior could vary between APIs in a way that makes cancelOperation a confusing abstraction. In particular, when sending a cancellation request, the service may respond with either a 200 or a 202 response, depending on the API and/or the operation, where the former indicates the operation has been canceled immediately and the latter indicates it could be some time before the operation is deemed as canceled. Handling 202 responses needs care to set the customer's expectation about wait times and this is typically done by providing a poller object that customer could use to optionally block until the operation finishes. This discrepancy in behavior makes cancelOperation not a suitable abstraction for the case when cancellation returns a 202 response.
LRO Cancellation
This LRO cancellation returns a 202 response so cancellation itself is an LRO. I am proposing to implement cancellation by returning a function named sendCancellationRequest alongside the operation poller, so the return type is:
interface AnalyzeBatchOperation {
    poller: AnalyzeBatchPoller;
    sendCancellationRequest(): Promise<void>;
}

And client code can simply destruct the output object as follows to get access to the poller and the cancellation function:
const { poller, sendCancellationRequest } = await client.beginAnalyzeBatch(actions, documents, "en");
...
// Let's cancel the operation
await sendCancellationRequest(); // poller.cancelOperation() no longer exists

Design considerations:

cancellation as a concept is not related to polling so a poller is not the right place to send cancellation requests
canceling an operation requires knowing the operation ID/location, but we shouldn't ask customers for that information because it is an implementation detail
cancellation is an LRO but it doesn't have its own operation location, i.e. the operation location is the same for the operation being cancelled and the cancellation operation itself. This means there is no need to create a dedicated poller for the cancellation operation and customers could still use the existing poller to await their operation or its cancellation
cancellation is a POST request with no interesting response, so it should be modeled programmatically as (): Promise<void> function

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-language-text

Couldn't get approval for this PR because the new UX is not confirmed whether it actually solves the problem and is a bit awkward.


Sign in with apple on the web not redirecting

Hi folks, I'm not sure if this is a bug, probably more like a settings issue, however I can't proceed with using this plugin on the web. (on a device it works fine). So this is how I start the flow:
SignInWithApple.authorize({
    clientId: environment.appId+'.webapp',
    redirectURI: 'https://api.xxxx.hu/signInWithAppleCallback',
    scopes: 'email name',
    state: '12345',
    //nonce: 'nonce',
  }).then(appleUser => {
    this.sendOauthConnectRequest(OauthProvider.apple, appleUser.response.identityToken).subscribe();
  }).catch(() => {
    this.oauthLoading[oauthProvider] = false;
    return;
  });

clientId is what I registered with apple and the redirect url is OK as well. When I start this call a new window pops up where I am able to log in with my apple ID, but after finishing it, it won't redirect me to the specified URL. As a matter of fact, nothing happens. No errors in the console either. I can see that there is a successful request to "https://appleid.apple.com/appleauth/auth/oauth/authorize", and in the response I can see all the correct authentication data, simply the redirection is not happening. If I close the login window after that, the callback for the error handler is correctly called, thus notifying me, that the login was not successful (which is what is. expected, since the user closed the window). So any idea on why the redirection is not happening? Thanks a lot!

Hi @Lzolcsi

Hi @ghonche ,
at the moment I am going with the following solution:
async appleTokenReceived(event) {
    if(
      typeof event.data !== 'object' ||
      !event.data.hasOwnProperty('appleToken') ||
      !event.data.appleToken
    ) {
      return;
    }
    this.appleSignInAbortController.abort();
    const loadingMessage = await firstValueFrom(this.translate.get('LOADING'));
    this.errorDialog.showLoading(loadingMessage);
    const deviceId = await Device.getId();
    let postData: any = {
      token: event.data.id_token,
      device_name: deviceId.uuid
    };
    if(event.data.hasOwnProperty('name')) {
      postData.name = event.data.name;
    }
    this.http
      .post(environment.apiUrl+'/auth/loginWithApple', postData)
      .subscribe((response: any) => {
        localStorage.setItem('apiToken', response.token);
        this.authService.refreshCurrentUser().then((user: UserModel) => {
          this.errorDialog.hideLoading();
          //REDIRECT user to the main page
        });
      });
  }

  async doAppleLogin() {

    if(Capacitor.getPlatform() === 'web') {
      this.appleSignInAbortController = new AbortController();
      window.open(
        'https://appleid.apple.com/auth/authorize?' +
        'client_id='+environment.appId+'.webapp&' +
        'redirect_uri='+environment.apiUrl+'/auth/signInWithAppleCallback&' +
        'response_type=code id_token&' +
        'scope=name email&' +
        'response_mode=form_post',
        '_blank'
      );
      window.addEventListener('message', e => {this.appleTokenReceived(e)}, {signal: this.appleSignInAbortController.signal});
      return;
    }
    //TODO Make sure this still works on native platform (and possibly android, maybe...)
    const options: SignInWithAppleOptions = {
      clientId: environment.appId+'.webapp',
      redirectURI: '',
      scopes: 'email name',
      state: '12345',
      //nonce: 'nonce',
    };

    const loadingMessage = await firstValueFrom(this.translate.get('LOADING'));
    const deviceId = await Device.getId();
    SignInWithApple.authorize(options)
        .then((result: SignInWithAppleResponse) => {
          this.errorDialog.showLoading(loadingMessage);
          this.http
              .post(environment.apiUrl+'/auth/loginWithApple', {
                token: result.response.identityToken,
                device_name: deviceId.uuid
              })
              .subscribe((response: any) => {
                this.errorDialog.hideLoading();
                localStorage.setItem('apiToken', response.token);
                this.authService.refreshCurrentUser().then((user: UserModel) => {
                  this.errorDialog.hideLoading();
                  this.appComponent.navigateAfterActivated(user, ['purchases']);
                });
              });
        })
        .catch(error => {
          //console.log(error);
        });
  }

This mostly works, at the moment I'm having some trouble figuring out why it doesn't work in dev environment when the domain isn't localhost. But hopefully this is a good starting point for you.

OK, it turns out this solution might not work WITH https, which is still a big issue.

Unfortunately it seems like this only works on localhost at the moment, the message is not posted back when the domain is something else. I'm having two ideas at the moment:
1: I'll try to use apples own JS framework for the sign in process: https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_js/configuring_your_webpage_for_sign_in_with_apple
This might have the same issue, but we'll see. Also, I don't want to include Apples JS file for the native apps, so the build process needs to be adjusted for this.
2: The Apple pop up window should post back the credentials in the background to the backend with the state variable, so theoretically if the backend stores the received credentials and the JS client asks the backend with the state variable periodically, it might solve the issue. But this seems to much of a hassle at the moment.

Here is a gist for a service provider that works both on ios and web as well:
https://gist.github.com/Lzolcsi/9c275953c63c94f8240d59d04e54507d
I'm closing this because with this everything is working fine for me now.

I have the same situation; works fine on a device, will not work on the web.
I'm going to try your workaround, but shouldn't this issue remain open? The plugin does not seem to be working correctly on the web?
Has anyone had the recommended code work for them on a website? The documentation suggests it should work 'as is'. ( I have confirmed I haven't made the usual mistakes, my domain is listed without the 'https://' on it, and my redirect_url is https (in fact, it's firebase, so like this: 'https:///__/auth/handler')

For what it's worth, since I'm using Firebase, I just re-coded the web Apple Signin following the Firebase instructions. (e.g. https://firebase.google.com/docs/auth/web/apple#web-version-9), using Javascript and avoiding this plugin. It works fine, although I'd rather not have an extra set of more-or-less duplicate code to maintain.
The main drawback is that I have two different apps with the same backend signin, which doesn't work quite as well with Firebase. Apple Signin uses the Services ID to determine logo and messaging to the user (e.g. "Use your Apple ID to Sign in to App ABC". With this plugin, one can have multiple Apple Service IDs, one for each app, and thus get the correct messaging (what happens for my apps on devices). With Firebase, only one Service ID seems to be allowed, so my second app will show a potentially confusing message mentioning the wrong app....so it would be cool if this plugin could work on the web. (Of course it's possible I'm doing something wrong, but cannot figure what it might be).


ADTs with Parceler.

I'm using ADT to model my state in Android application written in Kotlin.
It looks like following:
@Parcel(
  converter = StageParcelConverter::class,
  implementations = arrayOf(
    Stage.Landing::class,
    Stage.Identification::class,
    Stage.PinVerification::class)
  )
interface Stage {
  object Landing
  object Identification
  data class PinVerification(identificationResult: IdentificationResult)
}

It works well if I just wrap/unwrap instances of this type.
But when I use fields with Stage type in another Parcel'ed class like:
@Parcel
final class PinVerificationOps {
  final Stage.PinVerification pinVerificationStage;

  @ParcelConsturctor
  public PinVerificationOps(Stage.PinVerification pinVerificationStage) {
    this.pinVerificationStage = pinVerificationStage;
  }

  // Code that makes sense only in PinVerification stage.
}

But Parceler complains:
error: Parceler: Unable to find read/write generator for type Stage.PinVerification for Stage$PinVerification pinVerificationStage
    public PinVerificationOps(Stage.PinVerification pinVerificationStage)

It looks strange to me because I don't understand what preventing Parceler to see Stage.PinVerification as Stage and use StageParcelConverter for it.

Hmm, yeah, it looks like Parceler should behave as you described.  I'm no an expert on Kotlin, could you share an example application that I can tinker with?

No problem, I made a Java example for you.
https://github.com/pepyakin/adt-parceler

Oh, sweet, let me take a look then...

Maybe this is a shortcoming of Parceler at the moment, but the implmentations parameter is not used during code generation to map types to a given converter.  I think we could add that.
Looking at your example, it looks like you are working against Parceler, instead could you use something like the following without the need for a converter:
public interface Stage {

    @Parcel class Identification implements Stage {
        static final Identification INSTANCE = new Identification();
    }

    @Parcel class PinVerification implements Stage {
        final String derp;

        @ParcelConstructor public PinVerification(String derp) {
            this.derp = derp;
        }
    }
}

This would solve a few problems with your approach.

Yep, it might look like in Java, however in Kotlin there is few problems with Parceler:

Data classes are still problem, even with Bean serialization ("No corresponding property found for constructor parameter arg0", probably kapt problem).
[Kotlin] Objects cannot be created, because have no public constructors.

I think there are workarounds for these problems, e.g use @ParcelFactory for objects, but they oblige to clutter model definition. I prefer to keep definition clean and have seperate StageParcelConverter.

Relevant discussion on the first point: https://github.com/johncarl81/parceler/issues/143 TLDR: You may use @ParcelProperty to specify the constructor parameter names.
Not sure what yo mean by the second point, but Parceler can handle non-public constructors
I was thinking about alternatives to this further.  If you want to specify your converter on those classes the proper way to do so is the following:
@ParcelClasses(
        @ParcelClass(value = Stage.Identification.class, @Parcel(converter = StageParcelConverter.class)),
        @ParcelClass(value = Stage.PinVerification.class, @Parcel(converter = StageParcelConverter.class))
)
public interface Stage {
    class Identification implements Stage {
        static final Identification INSTANCE = new Identification();
    }

    class PinVerification implements Stage {
        final String derp;

        public PinVerification(String derp) {
            this.derp = derp;
        }
    }
}

Sorry, in second point I mean not the lack of the public constructor, but the fact why there is no public constructor — kotlin object is a singleton.

I was thinking about alternatives to this further. If you want to specify your converter on those classes the proper way to do so is the following:

It works. However, I experimented even further and tried to keep single converter.
class StageParcelConverter: ParcelConverter<Stage> {
    private fun Stage.ordinal(): Int = when (this) {
        is Stage.Identification -> 0
        is Stage.PinVerification -> 1
        else -> TODO()
    }

    override fun toParcel(input: Stage, parcel: Parcel) {
        val ordinal = input.ordinal()
        parcel.writeInt(ordinal)
        when (input) {
            is Stage.Identification -> { }
            is Stage.PinVerification -> {
                // ...
            }
        }
    }

    override fun fromParcel(parcel: Parcel): Stage? {
        val ordinal = parcel.readInt()
        return when (ordinal) {
            0 -> Stage.Identification
            1 -> {
                val derp = parcel.readString()
                Stage.PinVerification(identificationResult)
            }
            else -> TODO()
        }
    }
}

Parceler succeeds but produces code that is not compiling.
@Generated(value = "org.parceler.ParcelAnnotationProcessor", date = "2016-01-22T20:02+0400")
@SuppressWarnings({
    "unchecked",
    "deprecation"
})
public class Stage$PinVerification$$Parcelable
    implements Parcelable, ParcelWrapper<PinVerification>
{

    private PinVerification pinVerification$$0;
    @SuppressWarnings("UnusedDeclaration")
    public final static Stage$PinVerification$$Parcelable.Creator$$0 CREATOR = new Stage$PinVerification$$Parcelable.Creator$$0();

    public Stage$PinVerification$$Parcelable(android.os.Parcel parcel$$0) {
        pinVerification$$0 = new com.wheely.app.ui.onboarding.presenter.StageParcelConverter().fromParcel(parcel$$0);
        // ^^^ compile error: Incompatible types: Found: Stage Required: PinVerification
    }
}

This is due to a type coercion detail around generics that I haven't implemented.  A cast should be added in this spot (Here's the code that should perform that)


Portal RTX is not working with last NVIDIA drivers

Describe the bug
Running portal RTX is not working
Steam release version until 9 Dec 2023.

Click on play.
The game will not launch anymore.
Expected behavior
The game initialize and I can see the main game menu.
The game worked on January 2023
Attached files
Release version config files.
dxvk.txt
hl2_d3d9.log
hl2_d3d9.txt
metrics.txt
rtx.txt
steam_appid.txt
thirdpartylegalnotices.txt

Hello @jgmatu, you've come across a downstream fork of DXVK which is exclusively used for integration of the project into Proton.
Please report this issue on the compatibility report for the game (https://github.com/ValveSoftware/Proton/issues/6367) or to the upstream issue tracker (https://github.com/doitsujin/dxvk).


Avoid parsing commit response's offset field unnecessarily

When controller asks an instance to discard the segment during /segmentConsumed call, the offset returned is default (-1)
(https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java#L692)
But, this offset is parsed regardless of the status in the LLRealtimeSegmentDataManager
https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pi[…]ot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
which in case of DISCARD always fails with
2023/06/09 11:53:54.895 ERROR [LLRealtimeSegmentDataManager_TABLE_NAME__70__1684__20230609T0553Z] [TABLE_NAME__70__1684__20230609T0553Z] Exception while in work
java.lang.IllegalStateException: Caught exception when creating KinesisPartitionGroupOffset from offsetStr: -1
        at org.apache.pinot.plugin.stream.kinesis.KinesisMsgOffsetFactory.create(KinesisMsgOffsetFactory.java:41)
        at org.apache.pinot.core.data.manager.realtime.LLRealtimeSegmentDataManager.extractOffset(LLRealtimeSegmentDataManager.java:783)
        at org.apache.pinot.core.data.manager.realtime.LLRealtimeSegmentDataManager$PartitionConsumer.run(LLRealtimeSegmentDataManager.java:670)
        at java.lang.Thread.run(Thread.java:829) [?:?]

This leads to the consuming segment going in an error state and getting committed prematurely with reason = Exception. This PR fixes this

cc: @Jackie-Jiang

Codecov Report

Merging #10893 (cde7ced) into master (86b3b3e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #10893     +/-   ##
=========================================
  Coverage    0.11%    0.11%
=========================================
  Files        2186     2132     -54
  Lines      117493   114990   -2503
  Branches    17762    17460    -302
=========================================
  Hits          137      137
+ Misses     117336   114833   -2503
  Partials       20       20

Flag
Coverage Δ

integration1temurin11
?

integration1temurin17
?

integration1temurin20
?

integration2temurin11
?

integration2temurin17
?

integration2temurin20
?

unittests1temurin11
?

unittests1temurin17
?

unittests1temurin20
?

unittests2temurin11
0.11% <0.00%> (ø)

unittests2temurin17
0.11% <0.00%> (ø)

unittests2temurin20
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...manager/realtime/LLRealtimeSegmentDataManager.java
0.00% <0.00%> (ø)

... and 54 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


how do i get rid of the 2 empty lines below the last code line when embedding?

i embed python code into a html website using https://emgithub.com/pytorch/pytorch/blob/master/torch/nn/cpp.py
I noticed that below the last code line but above the lower border

of the code container seem to be 2 empty lines, how can i disable them?

I think this's because the environment where the code is shown is adding other CSS styles for the pre tag. To solve this, I decide to use a simulated pre tag to avoid style being added or overwritten. (See 18ba04cb8ffe7500893e0d25d63f59e8e4b052f1)
In this way, what you see on the page where code is embedded should look basically the same as it is on emgithub.com.


change ui langauge

how can i change the ui message langage

Download lockscreen folder and add it to your project as a module. Change the String.xml file at this path: lockscreen/src/main/res/values/strings.xml


[improvement] Display bubbles over page initials when the left sidebar is collapsed

When collapsed, the left sidebar shows the initials of each page.
Often, the initials are the same and it would be helpful to display a bubble with the full-length name of the page on hover.
Expanded state:

Collapsed state = no way to know which is which:

It is a good idea. Using emoji as the first letter can help too:

cc @louisdelbosc :)

I think this issue is obsolete. Here a video to show you. I'll let you close the issue 🙂
https://user-images.githubusercontent.com/11460746/183599843-a5f9f812-13d3-4fa8-9f51-a56d38917486.mov

Good catch @LouisDelbosc, this behavior was added by @cpind recently (in https://github.com/gristlabs/grist-core/commit/80f31bffc299aa9f2601228e93a85fa5c7a02bdf)

Great, your development team rocks!


Add icons to formbuilder labels

Adds icons to field labels in Screendoor's form builder.

Edit: Not sure why the build is failing...

@jrubenoff, any idea why thousands of lines of code got deleted as a part of the build here? https://github.com/dobtco/formrenderer-base/pull/146/commits/628a1029e2ef7c9464f5dc0a54dfaf28cd75642b#diff-49bf7afef736b8fa7016b275a05bf3b8
Can you try building again and see if those lines are restored?

I think this is due to trouble I was having while bootstrapping the repo. We could troubleshoot later together if you’d like

https://dobt.slack.com/archives/C024ZNYSG/p1501109094009671?thread_ts=1501108732.899265&cid=C024ZNYSG

@drusepth, it looks like something is wrong with josh's dev environment, causing his build to fail.
You have the closest thing to a functional JS environment right now, could you please build the repo and commit the changes when you have a moment?

Besides the failed code build, the code change itself looks fine.

Code looks good to me, and it looks like a rebuild fixed the tests as well.

Will merge once the Screendoor PR is approved!

this looks good to merge to me.
@drusepth, have you been generating releases by just adding a git tag and running script/release X.X.X or is it more complicated then that?

@vlymar Actually, the script/release X.X.X creates and pushes the git tag as well.
Relevant code from script/release:
grunt all
grunt test
git commit -am "release $version"
git tag $version
git push origin master --tags
grunt s3:version

It'll also push properly to rails-assets, so script/release X.X. X on master should be all you need to do for a full release.
(For major version changes there is one other change to make in the URL [changing /1/ to /2/ in path config], but it's not necessary for minor/patch updates.)

@vlymar, please merge this if you're 👍 with it.


Advancement package stuff 2

Stuff from the advancement package from #1956
This is the twenty-first of the follow ups from that, dividing into top level packages
This includes stuff I missed in #1971

actually gonna redo this on a new branch


Traffic split does not work with routes-v2, no virtual_host for apex service in the inbound route at destination

Bug description:
Traffic split does not work with routesV2 when run with the default demo ./demo/run-osm-demo.sh --enable-routes-v2-experimental=true.
There needs to be a virtual_host corresponding to the apex service in the inbound route configuration at the destination service, but this is not being programmed as expected.
Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [X]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]

Expected behavior:
Traffic split should work with routesV2.
Steps to reproduce the bug (as precisely as possible):

Apply the following diff for spit policy to be processed correctly

--- a/demo/deploy-traffic-split.sh
+++ b/demo/deploy-traffic-split.sh
@@ -12,7 +12,7 @@ metadata:
   name: bookstore-split
   namespace: "$BOOKSTORE_NAMESPACE"
 spec:
-  service: "bookstore.$BOOKSTORE_NAMESPACE"
+  service: bookstore
   backends:

   - service: bookstore-v1

Run the demo:
./demo/run-osm-demo.sh --enable-routes-v2-experimental=true`

Environment:

OSM version (use osm version):
Version: dev; Commit: 1323707da19e7b8590dd06aaf91832c01a4ebb4d; Date: 2021-02-17-10:59

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.1", GitCommit:"206bcadf021e76c27513500ca24182692aabd17e", GitTreeState:"clean", BuildDate:"2020-09-14T07:30:52Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}

Size of cluster (number of worker nodes in the cluster): 1 node

Reopening this issue as the previous implementation is not fully correct given this bug #2578


[shellscript] validate end of line character

VSCode Version:
Version 1.5.2
Commit 66f37fd2a99eb9d628dd374d81d78835b410c39b
Date 2016-09-12T13:30:03.456Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0
OS Version:
Windows 10

Steps to Reproduce:

create a dosomething.sh file in c:\repro\
place the following in the file

#!/bin/bash
echo hello from the cozy container

run:
docker run -it -v c:/repro:/src debian src/dosomething.sh
Response:
standard_init_linux.go:175: exec user process caused "no such file or directory"
Which starts you down the crazy train as you know it’s there but question if you got all the Linux things right:
Did you lean forward / lean backward
Did you get the ./ correct?
Was volume mounting correct?
Ahhhhhhhhh
use Dos2Linux to fix the file
learn VS Code has a nice option in the corner to switch to lf
docker run -it -v c:/repro:/src debian src/dosomething.sh
Response:
hello from the cozy container
Look for a way to customize a specific language (bash)
log a bug hoping the VS Code team will just fix *.sh files to always use just lf
blog that VS Code rocks, and hope it will fix the default

You could use an .editorconfig and the EditorConfig extension to get that:
[*.sh]
end_of_line = lf

Thank you. That's a better workaround than having to change all or manually change everytime. Can we get this added to bash?

I'm not sure what you mean by adding to bash.

VS Code has language support for bash. It's auto associated to .sh files. can
[*.sh]
end_of_line = lf

be added to that language service?

The problem with this is, that it requires the EditorConfig extension, which is not bundled with VSCode.

Doing this automatically might not always be expected, but we could ask the user when we detect this case on save.

Not sure what is the right approach here.

Automatically changing a new line character is not a good idea. There could be a warning and a quick fix. That's what could already be implemented by an extension
Provide language specific EOL character settings

It would be really nice if this was the default...
"[shellscript]": {
"files.eol": "\n"
}
Or if it was even possible.  I'll keep using dos2unix on Bash on Ubuntu on Windows to fix my bash scripts.

We have #49418 as request to make \n the line delimiter of all new shellscript files. I created a PR to fix that.
To also add validation is not planed but would better come from a shell language server that also does other linting.


Multiple file outputs

Hey, gulp noob user here!
In the advanced usage documentation it mentions that the configuration outputs to multiple formats but I don't quite see which part does that.
If I wanted to use the same single yml file to output multiple different formats how would I do that? Ie. tokens.yml -> variables.css & variables.js

I've solved this the dumb way by defining more and more tasks. Feels a bit odd (and just like grunt) so maybe there's a nicer way. Works for nor anyway!

I think the docs mention that because there are multiple inputs, unfortunately the current plugin only supports a single output. If I have time, I can update the plugin to accept an array of options and then create multiple outputs.


Why AsyncCommand in Future folder?

Hi,
Just wondering why AsyncCommand is in Future folder? Is it not usable or whats the reason?
Thanks
Sherry

I never completed the design. AsyncCommand eventually became part of Mvvm.Async.


Component generator

Notes for Reviewers
This PR fixes #8592
Signed commits

[x] Yes, I signed my commits.

Test run happening now... https://github.com/meshery/meshery/actions/workflows/meshmodel-generators.yml


Remove unused code for the EU exit business finder

Remove more unused code for the EU exit business finder
Mostly removes the grouped results finder and related code which was only used for this finder
trello: https://trello.com/c/qBM5QLID/482-remove-business-finder-tech-debt
Search page examples to sanity check:

https://finder-front-remove-bf-fa05sd5.herokuapp.com/search/all
https://finder-front-remove-bf-fa05sd5.herokuapp.com/search/research-and-statistics
https://finder-front-remove-bf-fa05sd5.herokuapp.com/search/news-and-communications?parent=%2Feducation&topic=c58fdadd-7743-46d6-9629-90bb3ccc4ef0
https://finder-front-remove-bf-fa05sd5.herokuapp.com/get-ready-brexit-check/questions
https://finder-front-remove-bf-fa05sd5.herokuapp.com/drug-device-alerts
https://finder-front-remove-bf-fa05sd5.herokuapp.com/find-eu-exit-guidance-business
https://finder-front-remove-bf-fa05sd5.herokuapp.com/find-eu-exit-guidance-business?keywords=eori&order=relevance
https://finder-front-remove-bf-fa05sd5.herokuapp.com/find-eu-exit-guidance-business?sector_business_area[]=aerospace&order=topic
https://finder-front-remove-bf-fa05sd5.herokuapp.com/uk-nationals-living-eu

Other finders

I think you need to rebase against master, bill did some base_path changes and there's something about a rake task I think we've already removed.

Humm still getting:

14:46:36  Don't know how to build task 'publishing_api:publish_eu_exit_business_finder' (See the list of available tasks with rake --tasks)


⚠ Fortnite has degraded performance

In 657a64e, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1656 ms

Resolved: Fortnite performance has improved in b901a2e.


Matrix aggregation first iteration

Related PR :
https://github.com/phovea/phovea_core/pull/110

Works in general. I documented the error I found in issue #352.


type load exceptions from the bound msbuild libraries can escape being caught and handled by the failure loop

Describe the bug
If there's a mismatch in the msbuild dlls, then a typeloadexception will escape the error handling present in the library.
The first time the libraries are loaded are on calls to this function.  This call happens here. Therefore, we should catch exceptions here and bubble that up as a Result.Error so that the error can be reported by the notification event handler as we expect, instead of being uncaught and never notifying callers.

@baronfel think this is still an issue?


Deprecated property key value should be passed to new property key with alias

Alluxio Version:
2.7.0, 2.8.0
Describe the bug
In Alluxio property key fail, we see
  /**
   * @deprecated use {@link #USER_STREAMING_DATA_READ_TIMEOUT} instead
   */
  @Deprecated
  public static final PropertyKey USER_NETWORK_DATA_TIMEOUT_MS =
      durationBuilder(Name.USER_NETWORK_DATA_TIMEOUT)
          .setAlias("alluxio.user.network.data.timeout.ms")
          .setDescription("The maximum time for an Alluxio client to wait for a data response "
              + "(e.g. block reads and block writes) from Alluxio worker.")
          .setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)
          .setScope(Scope.CLIENT)
          .build();

  public static final PropertyKey USER_STREAMING_DATA_READ_TIMEOUT =
      durationBuilder(Name.USER_STREAMING_DATA_READ_TIMEOUT)
          .setAlias("alluxio.user.network.data.timeout.ms", Name.USER_NETWORK_DATA_TIMEOUT,
              Name.USER_STREAMING_DATA_TIMEOUT)
          .setDefaultValue("3m")
          .setDescription("The maximum time for an Alluxio client to wait for a data response "
              + "for read requests from Alluxio worker. Keep in mind that some streaming "
              + "operations may take an unexpectedly long time, such as UFS io. In order to handle "
              + "occasional slow operations, it is recommended for this parameter to be set to a "
              + "large value, to avoid spurious timeouts.")
          .setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)
          .setScope(Scope.CLIENT)
          .build();

We have one deprecated property key and one new property key with alias name the same as the old deprecated property key value.
The code has been changed to use USER_STREAMING_DATA_READ_TIMEOUT.
Expected that setting the value of one of the property key names should set the value of USER_STREAMING_DATA_READ_TIMEOUT:
alluxio.user.streaming.data.read.timeout
alluxio.user.network.data.timeout.ms
alluxio.user.network.data.timeout
alluxio.user.streaming.data.timeout
However, setting the value of alluxio.user.network.data.timeout.ms or alluxio.user.network.data.timeout will not set the value of USER_STREAMING_DATA_READ_TIMEOUT.
Our way of combining @Deprecated PropertyKey and `PropertyKey.Alias" doesn't work as expected.
This issue is not just asking for fixing this issue but considering a comprehensive way of how to deprecate property keys especially when they are replaced by new property keys.
To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
Expected behavior
Urgency
Describe the impact and urgency of the bug.
Are you planning to fix it
Please indicate if you are already working on a PR.
Additional context
Add any other context about the problem here.

@yuzhu @Xenorith
This issue is not a regression for 2.8.0, do we consider it as a release blocker that needs to fix immediately?

This issue is discovered with the changes of modifying alluxio.worker.fuse.* to alluxio.fuse.* https://github.com/Alluxio/alluxio/pull/15286

Proposal:
Have a separate DeprecatedKey class to

record the deprecated key information (name, alias, default value, description) similar to property key
record when this key is deprecated and when it will be removed.
remind users to move the DeprecatedKey to removedKey when it should be removed (passed the removal time)
Warn user deprecated information through logging
Improve Alluxio configuration documentation to include deprecated key information

Change to the property key class

The alias names of all property keys should be recorded in the DeprecatedKey class.
Deprecated key will not be registered to avoid this github issue problem.

@rongrong PTAL and see if the fix makes sense, thanks!

Basically, it will be a refactoring that is better to be merged after 2.8 release

Exception
  /**
   * @deprecated use block annotators instead
   */
  @Deprecated(message = "Use WORKER_BLOCK_ANNOTATOR_CLASS instead.")
  public static final PropertyKey WORKER_EVICTOR_CLASS =
      classBuilder(Name.WORKER_EVICTOR_CLASS)
          .setDescription("The strategy that a worker uses to evict block files when a "
              + "storage layer runs out of space. Valid options include "
              + "`alluxio.worker.block.evictor.LRFUEvictor`, "
              + "`alluxio.worker.block.evictor.GreedyEvictor`, "
              + "`alluxio.worker.block.evictor.LRUEvictor`, "
              + "`alluxio.worker.block.evictor.PartialLRUEvictor`.")
          .setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)
          .setScope(Scope.WORKER)
          .build();
  public static final PropertyKey WORKER_BLOCK_ANNOTATOR_CLASS =
      classBuilder(Name.WORKER_BLOCK_ANNOTATOR_CLASS)
          .setDefaultValue("alluxio.worker.block.annotator.LRUAnnotator")
          .setDescription("The strategy that a worker uses to annotate blocks "
              + "in order to have an ordered view of them during internal"
              + "management tasks such as eviction and promotion/demotion. "
              + " Valid options include: "
              + "`alluxio.worker.block.annotator.LRFUAnnotator`, "
              + "`alluxio.worker.block.annotator.LRUAnnotator`, ")
          .setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)
          .setScope(Scope.WORKER)
          .build();

These two property key have special deprecation logic to transfer the values of WORKER_EVICTOR_CLASS to WORKER_BLOCK_ANNOTATOR_CLASS in code

A quick/isolated fix for 2.8 is to remove all the deprecated property keys except WORKER_EVICTOR_CLASS.


nixos-rebuild: move $SSHOPTS declaration after fun definitions

When I tried to update a node with a specific ssh key using the ssh -i flag. It threw an error:
Permission denied (publickey)

But the path and key were correct, I could connect via ssh directly. The problem is that in #283634 we have started running the remote command to get the hostname, but $SSHOPTS is declared below that line, causing them to be ignored.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.
cc: @lf- @roberth

If everything is okay, can we also backport this?

When will this be merged? Also is there any workaround until this gets merged?

Do you have any questions about my review?
Do you need help with extending a test for this? Unfortunately nixos-rebuild would be exceedingly difficult to maintain without good test coverage.

Do you have any questions about my review?

No. I just haven't had time, but I will add tests this weekend. I'll ping you for a review soon

oh no, you accidentally rebased in a bad way that causes mass email spam. it's because the base branch is wrong. please reopen as a new PR.


📝 Add annotations to HTTP middleware example

Update documentation example for HTTP middleware to complete type annotations in the signature.
import time
from typing import Awaitable, Callable

from fastapi import FastAPI, Request, Response

app = FastAPI()

@app.middleware("http")
async def add_process_time_header(
    request: Request, call_next: Callable[[Request], Awaitable[Response]]
) -> Response:
    start_time = time.time()
    response = await call_next(request)
    process_time = time.time() - start_time
    response.headers["X-Process-Time"] = str(process_time)
    return response

looks good :+1:


Functionality: could you make table cells editable?

For example per column property "setEditable".
After editing finished (td blur?) fire event.

thank you for your suggestion, however for additional functionality with table cells etc, you can just create the td template yourself, like so:
<vue-good-table
  title="Dynamic Table"
  :columns="columns"
  :rows="rows"
  :lineNumbers="true"
  :defaultSortBy="{field: 'age', type: 'asec'}"
  :globalSearch="true"
  :paginate="true"
  styleClass="table condensed table-bordered table-striped">
  <template slot="table-row" scope="props">
    {{ props.row.name }}
    {{ props.row.age }}
    {{ props.row.btn }}
  </template>
</vue-good-table>

closing. Please re-open if this doesn't satisfy your needs.

I have created an editable component which I use in the td template like:
<vue-good-table :columns="columns" :rows="rows" :paginate="true">
 <template slot="table-row" scope="props">
   <editable :item="props.row.strname" @updated="onUpdate(i,'stringnaam',$event)"></editable>

</template>
</vue-good-table>

For the updated event I need the row index; how do I do that?

hey @focussing! You can get row index from props.index. make sure you're on v1.7.1 or later.

Hi @xaksis!
Thank you.
Didn't know that there was a new release... I was still at 1.6.2.
How can I see there is a new release?
Another issue; after the page is loaded the rows order is not exactly as read from my database...
It should be ordered by index. But the first row has id 104, and the rest goes from id 12 upto 201

@focussing hmm... good question about where to see new release... perhaps i'll add a changelog.
I'll use the open issue to discuss the indexing problem. thanks for pointing it out.

Maybe you could make use of "Releases" like I see with other repositories?

@xaksis I see that you have version tags. You could use https://github.com/zeit/release
with which you can generate a changelog very fast

@cristijora awesome! Thanks, I'll use it for the changelog!

Issue Title: "Editable Component Value Propagation Issue" "vue-good-table": "2.21.0"
Description:
When using editable components, such as input fields, and adding an event listener to track changes, an issue arises. When the value of one input is updated, it propagates to all other inputs because it modifies rows.field.value. This behavior is unexpected and can lead to unintended changes in other inputs.


fichier: non-ASCII characters don't behave as expected

non-ASCII characters fail with 1fichier, and the default (escape with \unicode) doesn't work here as backslash is also blacklisted on 1fichier. Will try to fix this after #3295 is merged

it appears to be that these characters are blacklisted:
["'<>$/´]` as well as a space at the beginning of the folder name

this is resolved on branch fichier

Found some files which create duplicates on remote and fail. Will look at that now


"Change dicthtml strings to micthtml" doesn't work completely on 4.20

I posted about my experience here, but basically, the patch applies without errors, but the full list of dictionaries doesn't appear in the drop down box; just a small subset. And the Settings menu thinks there are no dictionaries installed, despite the Installed and IsSynced columns in the database all being set to true and the micthtml files all being there. And you can still do searches on the dictionaries that are selectable, meaning that changing the file name does work since the Kobo can still access them.
Remove the patch and rename everything to dicthtml format, and everything works as expected again. Patch worked fine in 4.19 and earlier.

I'm most likely going to remove the patch, as it's quite old, and it's not necessary (I think).
Can someone else confirm that setting IsSynced to false on an overwritten installed built-in dictionary prevents it being overwritten during a sync?

This patch isn't necessary anymore: https://github.com/geek1011/kobopatch-patches/issues/49#issuecomment-596228361.


Fix bug which prevented tradebacks from being edited

Resolves #323

Can you base this off my branch that is curently the beta (311-update-dependencies) so I don't have to rebase this evening.


[CHORE] Builder Script

As soon as we decide on a format for snippets and get a few going, we need to make a builder script with all the necessary components.

Like use webpack or npm scripts to build all files?

Ok, got it.


Supporting Scalar Lists in Postgres

In reference to https://github.com/prisma/prisma2/issues/169
Noticed that Postgres does not currently have scalar lists support. Thought I would create an issue here for the same.

Postgres does support them. It is just a bug in the extension that you are reporting. Lift successfully migrates the database.
See: https://github.com/prisma/vscode/issues/38


move propTypes declaration

Related to https://github.com/ReactTraining/react-router/issues/4493.
This test should ensure us it's working correctly.
cc @timdorr

Sorry for letting this sit. I was waiting on Travis and got distracted...


container config updates

improved settings for elasticsearch and minio, related to https://github.com/wmo-im/wis2box/issues/814

Thanks @maaikelimper.  Not sure if the CI failures are related?

@tomkralidis CI failures are unrelated, the fixes for CI failures are addressed in https://github.com/wmo-im/wis2box/pull/811


Is there any way of mapping Flags to array of enums or byte?

I've been trying to set up an API endpoint that has a FlagsAttribute enum as input, but Swashbuckle is mapping it to an Enum, instead of an Array or Bit sequence. Is there any alternative, solution or desire to implement such feature? Thanks.

For this type of customization, I would recommend the MapType setting to provide a custom schema for the enum in question.

For this type of customization, I would recommend the MapType setting to provide a custom schema for the enum in question.


Add helm chart for Apache Solr

What this PR does / why we need it:
This PR adds a helm chart for the Apache Solr project: http://lucene.apache.org/solr/, a search engine built upon Apache Lucene.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Variables are documented in the README.md

hello all, there is nothing wrong with this PR

this blog covers how it works

Hi. I'm a prospective user of this chart, curious about what a typical timeline for merge of something like this would look like. We're trying to decide whether to pursue other ways of depending on this chart, or whether to hold work to save duplicated effort.
Thanks!

@no-reply Hey Tom, the helm-chart is here: By the time you wake up, I think we can ensure there is parity between that one and this one so you can depend on it with confidence.
https://github.com/lucidworks/solr-helm-chart/tree/master/solr

@ian-thebridge-lucidworks We now have the Helm Hub and you can submit a charts repo of your own to it. This is documented here. I see you already have the chart in a separate location. Did you want to host it yourself? You can easily do that using GitHub Pages if you like.

/ok-to-test

@mattfarina That's cool. Thanks for running this and providing the info on Helm Hub. We would still like this chart in the Helm Charts repo if it passes your rigor.

/lgtm

💯


Add support for JIT access requests from the CLI

Can you actually address #9855 rather than closing the issue without an update, please?
It's currently possible to manage JIT access policies, but it's not possible to request JIT access to a resource.

route to CXP team

@LukeCarrier Thank you for reaching out to us, we are looking into this request,

@LukeCarrier We will try to prioritize this issue in future planning, thank you for bringing this our notice.

Can someone tame @msftbot? You must lose so much feedback and community goodwill from this incessant closing of tickets without resolution.

@LukeCarrier I understand your concern, since this is a feature request which as I mentioned earlier will be considered in future releases which could take sometime (No ETA as of now). We internally do have a work item to track this request. Therefore we decided to close this issue.

I understand that it takes time to address feature requests. I don't understand this bot's incessant spamming:

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

Does Microsoft expect its customers to reply to their threads every week to keep their issues open? If so, I can write a GitHub Action to do that, but at this point I am more likely to up and move to a provider that doesn't waste so much of my time ;-)

@LukeCarrier Once again sorry for this, but the bot is designed to help us close inactive issues/threads. Let me close this thread for now and we can revisit this once the new feature is implemented, which I believe will happen in the next sprint.

Two months? That's a long sprint :-)

Any update on this?

Any updates on this?

Any updates on this?

☝ this, Microsoft, is why you ought to communicate progress information with your customers rather than fobbing them off with nonsense like:

we can revisit this once the new feature is implemented, which I believe will happen in the next sprint.

...which was nearly two years ago, and we thought two months was a long time at the time! 😂

Any update on this?


fix(docs): fix two links broken by crate move

This commit fixes two links I forgot to update in
ef89bba0ca3f35c5b1cc1aa48cf814fe6ed5d4a4.

Thanks for fixing all these


(llm-chatbot notebook) Weight compression using Optimum Intel/NNCF

In the llm-chatbot notebook - https://github.com/openvinotoolkit/openvino_notebooks/blob/main/notebooks/254-llm-chatbot/254-llm-chatbot.ipynb, within the section "Weight Compression using Optimum Intel/NNCF", I noticed that the procedure involves converting the model to FP16 before proceeding with INT4/INT8 weight compression.
Any reason behind not converting the model to FP32 for use in the weight compression process?

FP16 half-precision, which halves the model size of FP32 precision, can get an almost identical inference outcome while using half the GPU resources. You may refer to Common data types used in Machine Learning for more information.

Closing issue, feel free to re-open or start a new issue if additional assistance is needed.


AlephClientBase and AuthenticatedAlephClientBase

Adding abstract base classes for the client classes and add several improvements:

Many pages of messages can now be iterated over with get_messages_iterator or get_posts_iterator.
get_posts now returns a PostsResponse type instead of untyped dictionary
Harmonize get_messages and watch_messages as both should have the same query parameters
Moved all docstrings from the client classes to their ABCs

Thanks for this proposal for improving the SDK.
The capability of using generators such as your suggestion for get_messages_iterator seems very relevant.
I believe that there is a better way of doing this than adding such method, and I experimented a bit with a new Pull Request here: https://github.com/aleph-im/aleph-sdk-python/pull/58

Thanks for this proposal for improving the SDK.
The capability of using generators such as your suggestion for get_messages_iterator seems very relevant.
I believe that there is a better way of doing this than adding such method, and I experimented a bit with a new Pull Request here: #58

Merging the PRs that are lined up would conflict with the proposed changes in #58. I would offer to take these suggested changes and make another PR that integrates better with the new ABCs and MessageCache/DomainNode classes.

@hoh and me agreed to continue with merging the branch after another review. I will take care of implementing certain features of #58 in future PRs on the basis of this PR and #59, but will now prioritize UX, especially around deployment and managing of VMs, as new features will hit https://github.com/aleph-im/aleph-vm soon.
@odesenfans please review the requested changes and approve, if no further required.


fix default session, which was wrong as well as not the right syntax

for your perusal

Thank you 👍


Updates Caddy Readme to avoid deprecation warning

"login / " leads to deprecation warning and fails to start.

Coverage remained the same at 92.143% when pulling bdeafe9a959ea9b149c185b43b215476c08ba302 on schnatterer:patch-1 into fdf90ae4d0dc8431d336765d669d4b834356648c on tarent:master.

cool, thx.