HBASE-28153 Upgrade zookeeper to a newer version

ZooKeeper has changed their netty dependencies so we need to modify our netty dependencies and exclusions too.
And ZooKeeper also specify some necessary dependencies for running ZooKeeperServer as provided, so we need to specify them directly in our pom as we have a MiniZooKeeperCluster, where we will run a ZooKeeperServer.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s
master passed

+1 :green_heart:
compile
6m 23s
master passed

+1 :green_heart:
spotless
0m 47s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s
the patch passed

+1 :green_heart:
compile
5m 55s
the patch passed

+1 :green_heart:
javac
5m 55s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  7s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m  6s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 45s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

40m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 6e5e5c00d8c1 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 41057bbf35

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
2m 26s
master passed

+1 :green_heart:
shadedjars
6m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
2m 48s
the patch passed

+1 :green_heart:
javac
2m 48s
the patch passed

+1 :green_heart:
shadedjars
6m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
329m 36s
root in the patch passed.

371m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a9143130cdf0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 41057bbf35

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/testReport/

Max. process+thread count
8154 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
master passed

+1 :green_heart:
compile
1m 59s
master passed

+1 :green_heart:
shadedjars
5m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

+1 :green_heart:
shadedjars
6m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 18s
the patch passed

_ Other Tests _

-1 :x:
unit
363m 23s
root in the patch failed.

398m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 68261d38ec58 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 41057bbf35

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/testReport/

Max. process+thread count
4793 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 50s
master passed

+1 :green_heart:
compile
4m 45s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
4m 47s
the patch passed

+1 :green_heart:
javac
4m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 49s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

34m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 3f70b12628b7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 32s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 20s
master passed

+1 :green_heart:
compile
2m  7s
master passed

+1 :green_heart:
shadedjars
5m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
1m 47s
the patch passed

+1 :green_heart:
javac
1m 47s
the patch passed

+1 :green_heart:
shadedjars
5m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
270m 20s
root in the patch passed.

305m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a4912286362a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/testReport/

Max. process+thread count
8401 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
2m 13s
master passed

+1 :green_heart:
shadedjars
6m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
2m 29s
the patch passed

+1 :green_heart:
javac
2m 29s
the patch passed

+1 :green_heart:
shadedjars
6m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 30s
the patch passed

_ Other Tests _

-1 :x:
unit
332m 21s
root in the patch failed.

371m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c64e9903b17f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/testReport/

Max. process+thread count
5076 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
4m 48s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
4m 52s
the patch passed

+1 :green_heart:
javac
4m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  6s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 17s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

33m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux b798bfaefc02 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 17s
master passed

+1 :green_heart:
compile
2m 16s
master passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m 47s
the patch passed

+1 :green_heart:
javac
1m 47s
the patch passed

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
271m  1s
root in the patch passed.

305m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 804c21d16d06 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/testReport/

Max. process+thread count
8076 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 19s
master passed

+1 :green_heart:
compile
1m 38s
master passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
4m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
315m 44s
root in the patch failed.

344m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 60c4f7698da2 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/testReport/

Max. process+thread count
5352 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Strange, the same UT failed two times in jdk8 pre commit build. Should not be related but let me download the test logs to check. And the PR for branch-2.x will be different as we have two hadoop profiles. Will open another PR for branch-2.x.

Filed HBASE-28180 for the failed UT, it is not related.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
4m 43s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
4m 51s
the patch passed

+1 :green_heart:
javac
4m 51s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 19s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

33m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 4f369ba3d174 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 36s
master passed

+1 :green_heart:
compile
4m 45s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
4m 46s
the patch passed

+1 :green_heart:
javac
4m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 11s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

33m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 220804714a16 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
76 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 50s
master passed

+1 :green_heart:
compile
1m 45s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
shadedjars
5m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
275m 11s
root in the patch passed.

307m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5c364140f467 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/testReport/

Max. process+thread count
8729 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 18s
master passed

+1 :green_heart:
compile
1m 35s
master passed

+1 :green_heart:
shadedjars
4m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 16s
the patch passed

+1 :green_heart:
compile
1m 37s
the patch passed

+1 :green_heart:
javac
1m 37s
the patch passed

+1 :green_heart:
shadedjars
4m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
317m 50s
root in the patch failed.

346m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6789a3d5149f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0749fad448

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/testReport/

Max. process+thread count
5193 (vs. ulimit of 30000)

modules
C: hbase-common hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 36s
master passed

+1 :green_heart:
compile
4m 48s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
4m 50s
the patch passed

+1 :green_heart:
javac
4m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 22s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

33m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux b703b5c9e917 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 208e9b1a82

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 32s
master passed

+1 :green_heart:
compile
1m 44s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
1m 53s
the patch passed

+1 :green_heart:
javac
1m 53s
the patch passed

+1 :green_heart:
shadedjars
5m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
239m 48s
root in the patch failed.

271m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9461fa3e7c5d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 208e9b1a82

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/7/testReport/

Max. process+thread count
8650 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server hbase-it . U: .

 U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
6m 52s
master passed

+1 :green_heart:
spotless
0m 57s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
7m 59s
the patch passed

+1 :green_heart:
javac
7m 59s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  7s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
13m 20s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
1m  5s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 43s
The patch does not generate ASF License warnings.

48m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux b94be21b407d 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 208e9b1a82

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 31s
master passed

+1 :green_heart:
compile
1m 48s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 30s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
5m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
275m 49s
root in the patch passed.

307m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5c3220590f0a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 208e9b1a82

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/testReport/

Max. process+thread count
8767 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 18s
master passed

+1 :green_heart:
compile
1m 37s
master passed

+1 :green_heart:
shadedjars
4m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
4m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
377m 16s
root in the patch passed.

407m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5475

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4f641fcf8740 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 208e9b1a82

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/testReport/

Max. process+thread count
7330 (vs. ulimit of 30000)

modules
C: hbase-zookeeper hbase-server hbase-it . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5475/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

lots of exclusion removals. how was the list compiled? AFAIK we don't have great checks to ensure we aren't accidentally leaking new dependencies. (Referring to the non-netty ones now)

Zookeeper removed a lot of dependencies by their own, so we do not need to exclude them now.
The exclusion section of zookeeper is done when we uses 3.4.x, this is the compile dependencies
https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper/3.4.14
And now
https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper/3.8.3
I think all other exclusions are netty related. So do you have any other concerns?


Can i get all content of article with anotation and highlight?

Like title. Can i do that? Thank you.

Unfortunately no.


Spring - ensure all package names are changed to com.azure.xxx for Spring Cloud modules

We still use com.microsoft.azure as our package prefix in spring cloud modules, we should change them to com.azure to be compliant with track2 guidance.

PR merged, closing this issue now.


Add network links and info bubble

#658

Can we hyperlink Testnet/Previewnet here.

Lets also add previewnet under contract browser and add a Support networks section there to make it consistent with the others.

Can we hyperlink Testnet/Previewnet here.

That's what this PR does :)


Make example build cache client into a test

This regression test ensures external integrations with the build cache client keep working.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

The merge queue build has failed. Click here to see all failures.


Enhances debug console

Changes default keybinding
See also #982.
I prefer F12 to ~ because vanilla uses F12 to open console window.
Enables debug console in muggle mode
It is because you currently do not have ability to switch to wizard mode except for activating voldemort mode. Voldemort mode is designed as strengthened wizard mode(it's the reason why I name this mode "Voldemort") so we should provide the way to switch to the pure wizard more.
Adds another keybindings

Left/right to move cursor.

Emulates vanilla console
Currently, you have to run command as Lua code snippet. I want to vanilla-like console commands like this:
> wizard
Done.
> voldemort               # I'll remove F12 shortcut in release build and replace it with this "voldemort" command.
Done.
> help
help: Shows this help.
wizard: Activates wizard mode.
voldemort: Activates Voldemort mode.
...

These behavior can be implemented by this code:
// Pseudo-code
for (cmd : builtin_commands)
{
    lua[cmd.name] = cmd; // Register commands as variables.
}

auto result = eval(user_input); // The evaluated result is the variable bound above.
if (result is ConsoleCommand) // Check if the variable is ConsoleCommand(by some meta information?)
{
    result.execute(); // Execute the command.
}
else
{
    print(result); // It is a usual result. Just print it out.
}

I had a plan to implement Voldemort mode like this:
// wizard.hpp
class Wizard
{
    bool is_wizard;

    bool no_sp_cost;
    bool no_mp_cost;
    bool never_dies;
    bool can_open_any_locks;
    // and other special flags for playtesting...

    void enable_wizard_mode()
    {
        is_wizard = true;
    }

    void enable_voldemort_mode()
    {
        enable_wizard_mode();

        no_sp_cost = true;
        no_mp_cost = true;
        // and enables all of special flags...
    }
};

it isn't perfectly resolved. reopening.


Statusline broken after update

Hello,
I just updated my system (Archlinux) and now my status line doesn't show correctly:

Terminal: termite 16.6-2
Tmux: 3.4-4
LC_CTYPE: en_GB.UTF-8
glibc: 2.39-1
kernel: linux-lts 6.6.23-1

ranger-tmux broke my config


newline-before-return false positive

Bug Report

TSLint version: 4.5.1
TypeScript version: 2.2.1
Running TSLint via: Node.js API

TypeScript code being linted
class HelloWorld {

    test() {
        console.log("Any statement");
        // Any comment

        return;
    }
}

with tslint.json configuration:
"rules":
{
    "newline-before-return": true
}

Actual behavior
If there is a comment between the last statement and the return statement, tslint throws a false positive "Missing blank line before return"
Expected behavior

Here's another case not covered by the rule:
function foo() {
    fn();
    // comment

    // comment
    return;
}

The if (comments) { ... } block in newlineBeforeReturnRule.ts should probably check if:

There's a blank line in between one comment and another
Or there's a blank line after the last comment

Either of those conditions could trigger an early return and no warning.


jsoncons: 0.176.0 -> 0.178.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/danielaparker/jsoncons/releases.
meta.description for jsoncons is: C++, header-only library for constructing JSON and JSON-like data formats
meta.homepage for jsoncons is: https://danielaparker.github.io/jsoncons/
meta.changelog for jsoncons is: https://github.com/danielaparker/jsoncons/blob/v0.177.0/CHANGELOG.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.177.0 with grep in /nix/store/qy8qn876kb3x7lwz2hdv1x0a1b97r9d4-jsoncons-0.177.0
found 0.177.0 in filename of file in /nix/store/qy8qn876kb3x7lwz2hdv1x0a1b97r9d4-jsoncons-0.177.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

bt-migrate
jsoncons

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qy8qn876kb3x7lwz2hdv1x0a1b97r9d4-jsoncons-0.177.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jsoncons https://github.com/r-ryantm/nixpkgs/archive/19e01d3c1beb4b360be08276358b32ac68d277ff.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/19e01d3c1beb4b360be08276358b32ac68d277ff#jsoncons

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qy8qn876kb3x7lwz2hdv1x0a1b97r9d4-jsoncons-0.177.0
ls -la /nix/store/qy8qn876kb3x7lwz2hdv1x0a1b97r9d4-jsoncons-0.177.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

bt-migrate

1 package built:

jsoncons

Maintainer pings
cc @sikmir for testing.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 335293 run on x86_64-darwin 1

1 package failed to build:

bt-migrate

1 package built:

jsoncons

bt-migrate https://github.com/mikedld/bt-migrate/issues/26

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/danielaparker/jsoncons/releases.
meta.description for jsoncons is: C++, header-only library for constructing JSON and JSON-like data formats
meta.homepage for jsoncons is: https://danielaparker.github.io/jsoncons/
meta.changelog for jsoncons is: https://github.com/danielaparker/jsoncons/blob/v0.178.0/CHANGELOG.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.178.0 with grep in /nix/store/rqr7wk04s6g50i045zy4x0f6gd7xqdwq-jsoncons-0.178.0
found 0.178.0 in filename of file in /nix/store/rqr7wk04s6g50i045zy4x0f6gd7xqdwq-jsoncons-0.178.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

bt-migrate
jsoncons

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rqr7wk04s6g50i045zy4x0f6gd7xqdwq-jsoncons-0.178.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jsoncons https://github.com/r-ryantm/nixpkgs/archive/0a6b946c48b6d2f5a1c532825cd79c029e8a57ac.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0a6b946c48b6d2f5a1c532825cd79c029e8a57ac#jsoncons

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rqr7wk04s6g50i045zy4x0f6gd7xqdwq-jsoncons-0.178.0
ls -la /nix/store/rqr7wk04s6g50i045zy4x0f6gd7xqdwq-jsoncons-0.178.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:x: 1 package failed to build:

bt-migrate

:white_check_mark: 1 package built:

jsoncons

Maintainer pings
cc @sikmir for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


Remove message when streamer goes offline

Remove the message from going live channel when the streamer goes offline, maybe add in a timer to ensure it doesnt start spamming online message when stream drops due to connection issues

This request has been completed.


Add a ROOT path constant for sigh

Continuation of work on concerns raised in #5770
Replace use of Helper.gem_path with Sigh::ROOT

👍


negroni

Requirement - what kind of business use case are you trying to solve?

Problem - what in Jaeger blocks you from solving the requirement?

Proposal - what do you suggest to solve the problem or improve the existing situation?

Any open questions to address

操作失误


Update vuejs to current version

wisott

Updated with a manual run: https://github.com/endoflife-date/endoflife.date/commit/5772763278b48c0d86f7ecfe9b11d4e1836d63e7
The automation was breaking occasionally because of invalid YAML getting committed. Jekyll is not very strict about YAML issues (such as duplicate keys), but our automation is (RuaYAML/Python) and this meant it broke sometimes.
I've now added a Validation step to every commit, so PRs will now need to fix these issues before getting merged.
cc @endoflife-date/everyone


fix dead lock in SetLoopBodyEntryPoint

should not aquire FunctionProxy global lock while out of collecting code gen data phase. adding assertion to enforce that

:shipit:


Switching between Scene Editor and Game View changes mouse's wheel speed value

Summary
Basically what is said in the title.
In the following gif, I logged the value of DualityApp.Mouse.WheelSpeed if it wasn't null.

The Scene View does not forward any input to the game, only the Game View does. What you're seeing is likely the effect of the mouse becoming unavailable to your game, rather than a switch between views - something like the mouse wheel value jumping to zero from its previous value, producing a false wheel speed.
Can you extend you log output to the following and share your results?

DualityApp.Mouse.Wheel
DualityApp.Mouse.WheelSpeed
DualityApp.Mouse.Y
DualityApp.Mouse.YSpeed
DualityApp.Mouse.IsAvailable

I think that WheelSpeed changes because wheel is reset to 0 then to the former value when I switch between Scene Editor and GameView.
Maybe a fix could be by non resetting the wheel value when exiting Game View

Thanks! This is definitely a bug - even though the wheel value should be zero when unavailable, the speed should not go crazy.

Fixed. Release in progress. Check for package updates in about 30 minutes.


DEM format requirements / Reproducible example

Hi all,
I'm running into issues processing an SLC scene. Both GTC and RTC results are not really usable. I suspect my DEM is the problem and I'm wondering why, because I'm using the same DEM to successfully create an RTC product with SNAP. Here is the gdalinfo output if you're interested.
Can you provide some guidelines on format requirements for the DEM? Or at least a reproducible example in the notebook section. download_data.sh could, for example, be extended by a section that downloads DEM tiles from an open source (e.g., here) and prepares it with GDAL in the way sarsen expects.
Cheers, Marco

@maawoo any DEM supported by GDAL / Proj is supposed to work, as long both horizontal and vertical reference systems are specified.
As you don't provide details on what unexpected behaviour you see, I'll guess you are hitting the most common problem, that is: the DEM height has a different reference than the ellipsoid in the horizontal CRS.
As an example, you can see in line 8 of download_data.sh how I override the CRS specification of the SRTM DEM -s_srs EPSG:4326+5773 where the +5773 instructs Proj that the reference height is the EGM96 geoid.

Thanks for your help @alexamici!
I'm using the Copernicus 30m DEM (EGM2008 reference height), which has been converted to WGS84 ellipsoid heights in a very similar way that you pointed out (-s_srs EPSG:4326+3855 -t_srs EPSG:32632), so I think my DEM should be fine.

[...] I override the CRS specification of the SRTM DEM [...] where the +5773 instructs Proj that the reference height is the EGM96 geoid

From your description it sounds like the vertical heights of the DEM are supposed to stay the same and that only information about the reference height is added. Just to be clear (also for anyone stumbling over this issue), gdalwarp -s_srs EPSG:4326+5773 -t_srs EPSG:32616 is transforming/correcting the DEM to WGS84 ellipsoidal heights. See also https://github.com/OSGeo/gdal/issues/4566 for a good visualization of the difference between EGM96 and WGS84. But I guess that's what you meant?

Regarding my problem, which I'm happy to move to another issue if you want:
An output raster is created (gdalinfo) but it completely breaks my QGIS if I want to take a quick look at it. The Computed Min/Max=0.000,inf might be related?
There are some warnings during processing (see here). Maybe you can take a look and see if anything is unusual? I can also provide the DEM and SLC I'm using.


Updating "How can I manage captions?" FAQ

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@cichur Thank you for submitting feedback and contributing to the docs. We are currently investigating this.


How to train deepspeed-chat using nccl with multi-nodes?

My GPU machines do not have openmpi and some launcher. I want to use the original torch.distributed to train with multi-nodes.
But the error is always like this:
[2023-04-27 10:29:22,235] [INFO] [launch.py:222:main] 0 NCCL_DEBUG=INFO
[2023-04-27 10:29:22,235] [INFO] [launch.py:222:main] 0 NCCL_SOCKET_IFNAME=eth1
[2023-04-27 10:29:22,235] [INFO] [launch.py:222:main] 0 NCCL_IB_GID_INDEX=3
[2023-04-27 10:29:22,235] [INFO] [launch.py:222:main] 0 NCCL_IB_SL=3
[2023-04-27 10:29:22,236] [INFO] [launch.py:222:main] 0 NCCL_P2P_DISABLE=0
[2023-04-27 10:29:22,236] [INFO] [launch.py:222:main] 0 NCCL_IB_HCA=mlx5_2:1,mlx5_2:1
[2023-04-27 10:29:22,236] [INFO] [launch.py:222:main] 0 NCCL_LL_THRESHOLD=16384
[2023-04-27 10:29:22,236] [INFO] [launch.py:222:main] 0 NCCL_CHECK_DISABLE=1
[2023-04-27 10:29:22,236] [INFO] [launch.py:222:main] 0 NCCL_IB_CUDA_SUPPORT=1
[2023-04-27 10:29:22,236] [INFO] [launch.py:229:main] WORLD INFO DICT: {'<IP_ADDRESS>': [0, 1, 2, 3], '<IP_ADDRESS>': [0, 1, 2, 3]}
[2023-04-27 10:29:22,236] [INFO] [launch.py:235:main] nnodes=2, num_local_procs=4, node_rank=0
[2023-04-27 10:29:22,236] [INFO] [launch.py:246:main] global_rank_mapping=defaultdict(<class 'list'>, {'<IP_ADDRESS>': [0, 1, 2, 3], '<IP_ADDRESS>': [4, 5, 6, 7]})
[2023-04-27 10:29:22,236] [INFO] [launch.py:247:main] dist_world_size=8
[2023-04-27 10:29:22,236] [INFO] [launch.py:249:main] Setting CUDA_VISIBLE_DEVICES=0,1,2,3
[2023-04-27 10:29:25,898] [INFO] [comm.py:586:init_distributed] Initializing TorchBackend in DeepSpeed with backend nccl
mmnewyardnodesz52663:93:93 [0] NCCL INFO Bootstrap : Using eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:93:93 [0] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
mmnewyardnodesz52663:93:93 [0] NCCL INFO NET/IB : Using [0]mlx5_2:1/RoCE [RO]; OOB eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:93:93 [0] NCCL INFO Using network IB
NCCL version 2.12.12+cuda11.3
mmnewyardnodesz52663:96:96 [3] NCCL INFO Bootstrap : Using eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:96:96 [3] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
mmnewyardnodesz52663:95:95 [2] NCCL INFO Bootstrap : Using eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:95:95 [2] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
mmnewyardnodesz52663:94:94 [1] NCCL INFO Bootstrap : Using eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:94:94 [1] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
mmnewyardnodesz52663:95:95 [2] NCCL INFO NET/IB : Using [0]mlx5_2:1/RoCE [RO]; OOB eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:95:95 [2] NCCL INFO Using network IB
mmnewyardnodesz52663:96:96 [3] NCCL INFO NET/IB : Using [0]mlx5_2:1/RoCE [RO]; OOB eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:96:96 [3] NCCL INFO Using network IB
mmnewyardnodesz52663:94:94 [1] NCCL INFO NET/IB : Using [0]mlx5_2:1/RoCE [RO]; OOB eth1:<IP_ADDRESS><0>
mmnewyardnodesz52663:94:94 [1] NCCL INFO Using network IB
mmnewyardnodesz52663:96:249 [3] NCCL INFO Setting affinity for GPU 3 to ff,ffff0000,00ffffff
mmnewyardnodesz52663:93:244 [0] NCCL INFO Setting affinity for GPU 0 to ff,ffff0000,00ffffff
mmnewyardnodesz52663:94:250 [1] NCCL INFO Setting affinity for GPU 1 to ff,ffff0000,00ffffff
mmnewyardnodesz52663:95:248 [2] NCCL INFO Setting affinity for GPU 2 to ff,ffff0000,00ffffff
mmnewyardnodesz52663:95:248 [2] NCCL INFO Trees [0] 3/-1/-1->2->1 [1] 3/-1/-1->2->1
mmnewyardnodesz52663:96:249 [3] NCCL INFO Trees [0] -1/-1/-1->3->2 [1] -1/-1/-1->3->2
mmnewyardnodesz52663:94:250 [1] NCCL INFO Trees [0] 2/-1/-1->1->0 [1] 2/-1/-1->1->0
mmnewyardnodesz52663:93:244 [0] NCCL INFO Channel 00/02 :    0   1   2   3   4   5   6   7
mmnewyardnodesz52663:93:244 [0] NCCL INFO Channel 01/02 :    0   1   2   3   4   5   6   7
mmnewyardnodesz52663:93:244 [0] NCCL INFO Trees [0] 1/4/-1->0->-1 [1] 1/-1/-1->0->4
mmnewyardnodesz52663:95:248 [2] NCCL INFO Channel 00 : 2[3d000] -> 3[3e000] via P2P/IPC
mmnewyardnodesz52663:94:250 [1] NCCL INFO Channel 00 : 1[1b000] -> 2[3d000] via P2P/IPC
mmnewyardnodesz52663:95:248 [2] NCCL INFO Channel 01 : 2[3d000] -> 3[3e000] via P2P/IPC
mmnewyardnodesz52663:94:250 [1] NCCL INFO Channel 01 : 1[1b000] -> 2[3d000] via P2P/IPC
mmnewyardnodesz52663:93:244 [0] NCCL INFO Channel 00/0 : 7[3e000] -> 0[1a000] [receive] via NET/IB/0
mmnewyardnodesz52663:93:244 [0] NCCL INFO Channel 01/0 : 7[3e000] -> 0[1a000] [receive] via NET/IB/0
mmnewyardnodesz52663:93:244 [0] NCCL INFO Channel 00 : 0[1a000] -> 1[1b000] via P2P/IPC
mmnewyardnodesz52663:96:249 [3] NCCL INFO Channel 00/0 : 3[3e000] -> 4[1a000] [send] via NET/IB/0
mmnewyardnodesz52663:93:244 [0] NCCL INFO Channel 01 : 0[1a000] -> 1[1b000] via P2P/IPC
mmnewyardnodesz52663:94:250 [1] NCCL INFO Connected all rings
mmnewyardnodesz52663:94:250 [1] NCCL INFO Channel 00 : 1[1b000] -> 0[1a000] via P2P/IPC
mmnewyardnodesz52663:94:250 [1] NCCL INFO Channel 01 : 1[1b000] -> 0[1a000] via P2P/IPC
mmnewyardnodesz52663:96:249 [3] NCCL INFO Channel 01/0 : 3[3e000] -> 4[1a000] [send] via NET/IB/0
mmnewyardnodesz52663:96:251 [3] NCCL INFO NCCL_IB_GID_INDEX set by environment to 3.
mmnewyardnodesz52663:95:248 [2] NCCL INFO Connected all rings
mmnewyardnodesz52663:93:252 [0] NCCL INFO NCCL_IB_GID_INDEX set by environment to 3.
mmnewyardnodesz52663:95:248 [2] NCCL INFO Channel 00 : 2[3d000] -> 1[1b000] via P2P/IPC
mmnewyardnodesz52663:93:252 [0] NCCL INFO NCCL_IB_SL set by environment to 3.

mmnewyardnodesz52663:93:252 [0] misc/ibvwrap.cc:302 NCCL WARN Call to ibv_modify_qp failed with error Invalid argument
mmnewyardnodesz52663:93:252 [0] NCCL INFO transport/net_ib.cc:525 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO transport/net_ib.cc:703 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO include/net.h:26 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO transport/net.cc:631 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO proxy.cc:914 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO proxy.cc:942 -> 2

mmnewyardnodesz52663:93:252 [0] proxy.cc:1040 NCCL WARN [Proxy Service 0] Failed to execute operation Connect from rank 0, retcode 2
mmnewyardnodesz52663:95:248 [2] NCCL INFO Channel 01 : 2[3d000] -> 1[1b000] via P2P/IPC

mmnewyardnodesz52663:93:244 [0] misc/socket.cc:523 NCCL WARN Net : Connection closed by remote peer mmnewyardnodesz52663_in<55451>
mmnewyardnodesz52663:93:244 [0] NCCL INFO misc/socket.cc:531 -> 2
mmnewyardnodesz52663:93:244 [0] NCCL INFO misc/socket.cc:543 -> 2
mmnewyardnodesz52663:93:244 [0] NCCL INFO proxy.cc:805 -> 2

mmnewyardnodesz52663:93:244 [0] proxy.cc:808 NCCL WARN Proxy Call to rank 0 failed (Connect)
mmnewyardnodesz52663:93:244 [0] NCCL INFO transport/net.cc:319 -> 2
mmnewyardnodesz52663:93:244 [0] NCCL INFO transport.cc:137 -> 2
mmnewyardnodesz52663:93:244 [0] NCCL INFO init.cc:730 -> 2
mmnewyardnodesz52663:93:244 [0] NCCL INFO init.cc:914 -> 2
mmnewyardnodesz52663:93:244 [0] NCCL INFO group.cc:58 -> 2 [Async thread]

mmnewyardnodesz52663:93:252 [0] misc/ibvwrap.cc:302 NCCL WARN Call to ibv_modify_qp failed with error Invalid argument
mmnewyardnodesz52663:93:252 [0] NCCL INFO transport/net_ib.cc:525 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO transport/net_ib.cc:703 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO include/net.h:26 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO transport/net.cc:631 -> 2
mmnewyardnodesz52663:93:252 [0] NCCL INFO proxy.cc:914 -> 2

mmnewyardnodesz52663:93:252 [0] proxy.cc:1040 NCCL WARN [Proxy Service 0] Failed to execute operation Connect from rank 0, retcode 2
Traceback (most recent call last):
  File "/hf/DeepSpeedExamples/applications/DeepSpeedChat/training/step1_supervised_finetuning/training_scripts/multi_node/../../main.py", line 344, in <module>
    main()
  File "/hf/DeepSpeedExamples/applications/DeepSpeedChat/training/step1_supervised_finetuning/training_scripts/multi_node/../../main.py", line 203, in main
    torch.distributed.barrier()
  File "/usr/local/python/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 2776, in barrier
    work = default_pg.barrier(opts=opts)
RuntimeError: NCCL error in: /root/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1169, unhandled system error, NCCL version 21.2.12
ncclSystemError: System call (socket, malloc, munmap, etc) failed.
mmnewyardnodesz52663:96:249 [3] NCCL INFO Connected all rings
mmnewyardnodesz52663:96:249 [3] NCCL INFO Channel 00 : 3[3e000] -> 2[3d000] via P2P/IPC
mmnewyardnodesz52663:96:249 [3] NCCL INFO Channel 01 : 3[3e000] -> 2[3d000] via P2P/IPC
mmnewyardnodesz52663:96:249 [3] NCCL INFO Connected all trees
mmnewyardnodesz52663:96:249 [3] NCCL INFO threadThresholds 8/8/64 | 64/8/64 | 8/8/512
mmnewyardnodesz52663:96:249 [3] NCCL INFO 2 coll channels, 2 p2p channels, 2 p2p channels per peer
mmnewyardnodesz52663:95:248 [2] NCCL INFO Connected all trees
mmnewyardnodesz52663:95:248 [2] NCCL INFO threadThresholds 8/8/64 | 64/8/64 | 8/8/512
mmnewyardnodesz52663:95:248 [2] NCCL INFO 2 coll channels, 2 p2p channels, 2 p2p channels per peer

mmnewyardnodesz52663:96:249 [3] misc/socket.cc:503 NCCL WARN Net : Call to recv from <IP_ADDRESS><45613> failed : Connection refused
mmnewyardnodesz52663:96:249 [3] NCCL INFO misc/socket.cc:520 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO misc/socket.cc:531 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO misc/socket.cc:537 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO bootstrap.cc:60 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO bootstrap.cc:321 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO bootstrap.cc:341 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO init.cc:885 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO init.cc:914 -> 2
mmnewyardnodesz52663:96:249 [3] NCCL INFO group.cc:58 -> 2 [Async thread]
Traceback (most recent call last):
  File "/hf/DeepSpeedExamples/applications/DeepSpeedChat/training/step1_supervised_finetuning/training_scripts/multi_node/../../main.py", line 344, in <module>
    main()
  File "/hf/DeepSpeedExamples/applications/DeepSpeedChat/training/step1_supervised_finetuning/training_scripts/multi_node/../../main.py", line 203, in main
    torch.distributed.barrier()
  File "/usr/local/python/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 2776, in barrier
    work = default_pg.barrier(opts=opts)
RuntimeError: NCCL error in: /root/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1169, unhandled system error, NCCL version 21.2.12
ncclSystemError: System call (socket, malloc, munmap, etc) failed.
[2023-04-27 10:33:12,457] [INFO] [launch.py:428:sigkill_handler] Killing subprocess 93
[2023-04-27 10:33:12,458] [INFO] [launch.py:428:sigkill_handler] Killing subprocess 94
[2023-04-27 10:33:12,674] [INFO] [launch.py:428:sigkill_handler] Killing subprocess 95
[2023-04-27 10:33:12,967] [INFO] [launch.py:428:sigkill_handler] Killing subprocess 96
RuntimeError: NCCL error in: /root/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1169, unhandled system error, NCCL version 21.2.12

I have forced Deepspeed to use deepspeed.laucher.launch not other launchers like openmpi, but I still get this error.

直接用deepseed cli启动

直接用deepseed cli启动

请问deepspeed是怎么知道用哪些node的？需要准备一个ip list文件？

@LarryZhangy deepspeed默认读/job/hostfile，这样的格式 $worker slots=${slots}"

I have the same problem, does anyone know how to solve this?


Re-style header into sections and ready for solutions dropdown

Description
Splits the navigation header (in preparation for #412 adding /solutions/xxx). Driven by content/ideas in #319. Working across all screen sizes.
https://user-images.githubusercontent.com/99246719/222178928-9406eafe-f3e8-439e-9222-0b593b0e1647.mov
Related Issue(s)
Closes #319
Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes
[-] Suitable unit/system level tests have been added and they pass
[-] Documentation has been updated

Not exactly sure I understand the change you made? However, the top menu now seems to be very crowded. It seems you have move in the margins so it spans a smaller amount of screen real estate. Was this your intention?

The screen recording is taken on a thinner screen in order to demonstrate the responsiveness of it.
In full-width it looks like this:

In the design I had here: https://github.com/flowforge/website/issues/412#issuecomment-1441419099
I didn't have the "Docs" option actually, so we could remove that.

Not exactly sure I understand the change you made?

I've added the "Company" option per request, and added the respective options underneath that option too.

The top menu now seems to be very crowded.

I've added the options you've asked for, it's about to get more crowded with "Solutions" too.

It seems you have move in the margins so it spans a smaller amount of screen real estate.

I have in fact made the space taken up by the header much wider than was previously used. The screen recording is taken on a thinner screen in order to demonstrate the responsiveness of it.
In full-width it looks like this (including hte "solutions" option which I'm working on atm)

This looks great.

This looks great.

In that case, can you approve/merge the PR please :)

@iskerrett can I get a review on this please?


Add config option preparation_profile to allow cross-querying in hybrid mode

Fixes #1980. @karussell can you check if this way this is also useful for #1776?
This is how it works
profiles:
  - name: my_car
    vehicle: car
    weighting: some_weighting
  - name: my_adjusted_car
    vehicle: car
    weighting: other_weighting
lm_profiles:
   # this means we will calculate landmarks for the 'my_car' profile
  - name: my_car
  # this means we do *not* calculate landmarks for the 'my_adjusted_car', but we can use still use
  # the 'my_adjusted_car' profile in hybrid mode and it will use the landmarks from the 'my_car' profile
  - name: my_adjusted_car
    preparation_profile: my_car

Hmm the build failed with
Failures:

[ERROR]   GraphHopperIT.testCompareAlgos:1546 expected: <1273.0535550319373> but was: <1315.3815116669612>

Probably unrelated to this PR and unfortunately we did not log the seed used in this test...

Merging here, I am sure if we want to change anything about the docs etc. we can do this afterwards in master.


Compare Robj to Robj by value?

Currently our implementation of some_robj == some_other_robj relies on this implementation:
https://github.com/extendr/extendr/blob/a06962c7e42e97bdc078a2ed4e4a47b54749f5d1/extendr-api/src/robj/mod.rs#L956-L967
And this function quite neatly compares all aspects of any Robj by value:
https://github.com/SurajGupta/r-source/blob/a28e609e72ed7c47f6ddfbb86c85279a0750f0b7/src/main/identical.c#L86
I think my code was not working with this function only because the attribute lists were different (which I still don't understand).

Oops, didn't mean to post this.


[Kubernetes plugin] – List Services & Ingresses

Feature Suggestion
Since https://github.com/backstage/backstage/pull/3918 got merged (nice work in there by the way), I was thinking about replacing my homemade k8s plugin with the built-in one. The only show-stopper at the moment is the fact that Services and Ingresses aren't displayed yet.
Would you be interested in a PR that adds support for these two types of objects?
Possible Implementation
N/A
Context
I have a PoC that looks like this:

Solved in #4080

Solved in #4080


wrong code offset

Every time I enter a code it doesn't work, unless I wait 10-30 seconds(this fluctuates) AFTER the code expires on my phone.
Is there a way to offset these codes so they work when they are  shown and don't when they're no longer shown? If there is, I haven't been able to find it.
I use the app on my pixel 7 with grapheneOs, app version 2.9
Hope someone can help!

The problem seems to be getting worse over time, I have to wait longer and longer until the otp works. First it worked fine, after a couple weeks I had to wait for the next otp to appear, another couple weeks and I had to wait for the next otp to expire halfway and now I can only enter my otp after the one after it has expired

Well, the TOTP will just calculate the time difference for the counter. If either your phone's time drifts or the server's time drifts, the TOTP will be in accurate. Seems like the clock on either your phone or on the server you authenticates further and further away so you need to skip one token. Would you try to make sure your phone's time sync is enabled and check that with your computer's time?

that aws indeed the issue, for some reason my phone's auto time sync was turned off after an update and it drifted causing TOTP's inaccuracy. Thank you for the solution!


Feature - Prevent the same bot name being used twice in a raid

Originally written by chomp

Implemented with: https://github.com/sp-tarkov/server/commit/eaa16259ae1f8df3bdc586a96011f46c04aedab6

Originally written by chomp


clear left side and clear right side don't work in the charter

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
clear left side and clear right side don't work in the charter
Command Prompt/Terminal/Crash logs (if existing)
dont have any

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
click clear left side or clear right side

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

you have to move a bit for the line for it to work

i'm aware of this, and have no fix for it yet. for now to work around it when you switch sections you need to press W/S, this makes the game know what section you're on then it'll work


LM tokenizer can't handle whitespace token

Rasa version: 2.1.1
Python version: 3.7.6
Operating system (windows, osx, ...):  Ubuntu 18.04.5 LTS
Issue:
when the training sample has " " (whitespace char) inside, e.g. '你好，我是 Silly，一个专注天气预报的对话机器人。'.
rasa train will raise  ValueError: not enough values to unpack (expected 2, got 0)
Error (including full traceback):
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/train.py", line 114, in train
    interpreter = trainer.train(training_data, **kwargs)
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/model.py", line 204, in train
    updates = component.train(working_data, self.config, **context)
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/featurizers/dense_featurizer/lm_featurizer.py", line 808, in train
    batch_docs = self._get_docs_for_batch(batch_messages, attribute)
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/featurizers/dense_featurizer/lm_featurizer.py", line 754, in _get_docs_for_batch
    batch_examples, attribute
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/featurizers/dense_featurizer/lm_featurizer.py", line 382, in _get_token_ids_for_batch
    example, attribute
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/featurizers/dense_featurizer/lm_featurizer.py", line 351, in _tokenize_example
    split_token_ids, split_token_strings
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/featurizers/dense_featurizer/lm_featurizer.py", line 288, in _lm_specific_token_cleanup
    return model_tokens_cleaners[self.model_name](split_token_ids, token_strings)
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/utils/hugging_face/transformers_pre_post_processors.py", line 234, in bert_tokens_cleaner
    return cleanup_tokens(list(zip(token_ids, token_strings)), "##")
  File "/home/howl/data/Envs/rasa_weather_bot-rasa-v2/lib/python3.7/site-packages/rasa/nlu/utils/hugging_face/transformers_pre_post_processors.py", line 26, in cleanup_tokens
    token_ids, token_strings = zip(*token_ids_string)
ValueError: not enough values to unpack (expected 2, got 0)

Command or request that led to error:
rasa train

domain.yml:
version: "2.0"
language: zh
pipeline:
    - name: JiebaTokenizer
    - name: LanguageModelFeaturizer
      model_name: bert
      model_weights: bert-base-chinese
...

I already know how to fix it, I will submit a PR for this later.

Thanks for the issue, @tmbo will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

closed. by https://github.com/RasaHQ/rasa/pull/7407

closed. by https://github.com/RasaHQ/rasa/pull/7407


Change the build to have a new Identity

Fixes #1716
What is being addressed
At the moment, the build and E2E tests are using the API_CLIENT_ID to authenticate to AAD. This change uses a new Identity that has Application.ReadWrite.All so that workspace AAD Applications can be registered automatically.
How is this addressed

Most of the work has been completed in previous PRs, this just switches the identity at the github secret level.
Also update the .env.sample to make it clearer how you setup a new TRE

Not included

I am now going to start documenting how all this hangs together

/test-extended

/test-force-approve


chore: bump zio-prelude from 1.0.0-RC20 to 1.0.0-RC21

About this PR
📦 Updates dev.zio:zio-prelude from 1.0.0-RC20 to 1.0.0-RC21
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-prelude" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-prelude" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Codecov Report

Merging #221 (4563f3e) into master (8bcc5d6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   67.90%   67.90%
=======================================
  Files          79       79
  Lines        1087     1087
  Branches      126      126
=======================================
  Hits          738      738
  Misses        349      349


presentation.sty.ltxml totally fails because CROSSREFOP handling LaTeXML postprocessing did not get moved from the KWARC branch.

Dennis and I just found a problem with (almost all constructors in) presentation.sty.ltxml.
TLDR: We need help in extending the sTeX plugin with postprocessing!
The symptom is that in the (presentation MathML) renderin in the notation definitions, the \prefix presentation operator generates (if I disable omdocpost.xsl):
<omdoc:rendering ic="variant:ddo" argprec="          ">
        <ltx:Math mode="inline" xml:id="partial-derivative.notation5.m4" about="#partial-derivative.notation5.m4" stex:srcref="smglom/calculus/source/partial-derivative.tex#textrange(from=7;0,to=7;76)" tex="\crossrefOp[fun]{\frac{\partial}{\partial{arg:2}}}" text="CROSSREFOP@(partial-differential / partial-differential@(arg:2))" font="italic" fragid="partial-derivative.notation5.m4">
          <ltx:XMath>
            <ltx:XMApp role="CROSSREFOP">
              <ltx:XMTok cr="fun" role="CROSSREFOP"/>
              <ltx:XMApp>
                <ltx:XMTok mathstyle="text" meaning="divide" role="FRACOP"/>
                <ltx:XMTok meaning="partial-differential" mode="math" name="partial" role="OPERATOR" font="upright" fontsize="70%">∂</ltx:XMTok>
                <ltx:XMApp font="upright" fontsize="70%">
                  <ltx:XMTok meaning="partial-differential" mode="math" name="partial" role="OPERATOR">∂</ltx:XMTok>
                  <ltx:XMTok mode="math" role="ID">arg:2</ltx:XMTok>
                </ltx:XMApp>
              </ltx:XMApp>
            </ltx:XMApp>
          </ltx:XMath>
          <om:OMOBJ>
            <om:OMA>
              <om:OMV name="CROSSREFOP"/>
              <om:OMA>
                <om:OMS cd="latexml" name="divide"/>
                <om:OMS cd="latexml" name="partial-differential"/>
                <om:OMA>
                  <om:OMS cd="latexml" name="partial-differential"/>
                  <om:OMV name="arg:2"/>
                </om:OMA>
              </om:OMA>
            </om:OMA>
          </om:OMOBJ>
          <m:math about="#partial-derivative.notation5.m4" alttext="\crossrefOp[fun]{\frac{\partial}{\partial{arg:2}}}" display="inline">
            <m:mrow>
              <m:mi mathcolor="red">𝐶𝑅𝑂𝑆𝑆𝑅𝐸𝐹𝑂𝑃</m:mi>
              <m:mo mathvariant="italic"></m:mo>
              <m:mfrac>
                <m:mo mathvariant="normal">∂</m:mo>
                <m:mrow>
                  <m:mo mathvariant="italic">∂</m:mo>
                  <m:mo mathvariant="italic"></m:mo>
                  <m:mi mathvariant="italic">arg:2</m:mi>
                </m:mrow>
              </m:mfrac>
            </m:mrow>
          </m:math>
        </ltx:Math>
        <m:mrow>
          <m:mo fence="true">(</m:mo>
          <ltx:Math mode="inline" xml:id="partial-derivative.notation5.m5" about="#partial-derivative.notation5.m5" stex:srcref="smglom/calculus/source/partial-derivative.tex#textrange(from=7;0,to=7;76)" tex="arg:1" text="arg:1" font="italic" fragid="partial-derivative.notation5.m5">
            <ltx:XMath>
              <ltx:XMTok mode="math" role="ID" font="upright">arg:1</ltx:XMTok>
            </ltx:XMath>
            <om:OMOBJ>
              <om:OMV name="normal-arg:1"/>
            </om:OMOBJ>
            <m:math about="#partial-derivative.notation5.m5" alttext="arg:1" display="inline">
              <m:mi mathvariant="normal">arg:1</m:mi>
            </m:math>
          </ltx:Math>
          <m:mo fence="true">)</m:mo>
        </m:mrow>
      </omdoc:rendering>

in a nutshell, the problem is that
          <ltx:XMath>
            <ltx:XMApp role="CROSSREFOP">
              <ltx:XMTok cr="fun" role="CROSSREFOP"/>

is post-processed to
           <m:mrow>
              <m:mi mathcolor="red">𝐶𝑅𝑂𝑆𝑆𝑅𝐸𝐹𝑂𝑃</m:mi>
              <m:mo mathvariant="italic"></m:mo>

The later comes from the \prefix macro
DefMacro('\prefix[]{}{}','\@prefix[#1]{\ensuremath{\crossrefOp[fun]{#2}}}{\ensuremath{#3 }}');

where \crossrefOp is defined in presentation.sty.ltxml as
DefConstructor('\crossrefOp[]{}',
       "?#2(<ltx:XMApp role='CROSSREFOP'>"
              .  "<ltx:XMTok role='CROSSREFOP' cr='?#1(#1)(fun)'/>"
              .  "<ltx:XMWrap>#2</ltx:XMWrap>"
              ."</ltx:XMApp>)()",
   requireMath=>1);

obviously with the idea that this would be converted to a proper cross-reference in LaTeXML post-processing. But in the LaTeXML master there is nothing of the sort, but in the old KWARC fork of LaTeXML we find:
# Experimental; for an XMApp with role=ID, we treat it as a ci
# or ultimately as csymbol, if it had defining attributes,
# but we format its contents as pmml
sub cmml_decoratedSymbol {
  my ($item) = @_;
  return ['m:ci', {}, pmml($item)]; }

# Experimental; for an XMApp with role=CROSSREFOP, we treat it as a mo
# and we format its contents as pmml
# Note that we need to transfer the cr attribute of the XMApp to the m:mo
sub pmml_decoratedOperator {
  my ($head, @args) = @_;
  return undef if (!($head->getAttribute('role') eq "CROSSREFOP"));
  my $doc = $LaTeXML::Post::DOCUMENT;
  my $cr = (ref $head ? $head->getAttribute("cr") : "fun");
  $head->setAttribute("role", "SKIP");
  my $operator = pmml(@args);
  return undef unless $operator;    #bootstrap
  if ($$operator[0] =~ /^m:m[io]$/) {    #Unwrap if only a mi or mo
    $operator = $$operator[2];
    ['m:mo', { 'cr' => $cr },
      $operator]; }
  else {
    #If structure is present, add cr attribute to top level element
    $$operator[1]{'cr'} = $cr;
    $operator;
  } }
#Experiment: CROSSREFOP
DefMathML("Apply:CROSSREFOP:?", \&pmml_decoratedOperator, undef);
DefMathML("Token:SKIP:?", sub { undef; }, sub { undef; });

which looks exactly like the postprocessing we need.
It seems that we only need to integrate that into the sTeX plugin, but that does not have any post-processing yet, and I am not sure how to do that.
Any pointers would be very welcome.

Fixed locally by copying the experimental code from the KWARC fork of LaTeXML into my clone of brucemiller/LaTeXML. Seems to solve the problem for me, but not a long-term solution, obviously

you should probably commit that to master anyway.

Done: e113ac5adf2dc4907e94416f4d97cdec71386002


Parse chinese character to jyutping

I've gone through the documentation but did not find how to convert Chinese sentence to jyutping. For example something like this.
import pycantonese as pc

pc.parse_to_jyutping("我係香港人")
'ngo5 hai6 hoeng1 gong2 jan4'

Hello, the characters-to-jyutping functionality isn't available yet, but is definitely a very reasonable feature for pycantonese. Hopefully we can get to implementing it sooner rather than later.

Hi!
@jacksonllee Do you accept contributions? I may be willing to give this a shot.

@mirfan899 We have a Jyutping conversion tool here, please try it out: https://github.com/CanCLID/ToJyutping

Great!!! thanks.

Hello everyone, I finally got around to finish some related work and just made a new release of pycantonese v2.4.0 to PyPI (pip install -U pycantonese should install the latest release). The new characters2jyutping() function does what this ticket asks for:
>>> import pycantonese as pc
>>> pc.characters2jyutping('我係香港人')
['ngo5', 'hai6', 'hoeng1', 'gong2', 'jan4']

Docs: http://pycantonese.org/jyutping.html#characters-to-jyutping-conversion
(Relatedly, this new pycantonese release also includes word segmentation, which the characters-to-jyutping conversion functionality depends on: http://pycantonese.org/word_segmentation.html)
I'm closing this ticket as resolved. Please feel free to let me know if there are other questions. Thanks!


Upgrade to Knative  > v0.3.0

As knative v0.4.0 its out, it is better to have the camel-k apis upgraded to use minimum v0.3.0 of Knative API.
It will be nicer if v0.4.0 is done as there some new features introduced such as volume mounts

@nicolaferraro can you have a look at upgrading to knative 0.3.0 ?

Yes, I'll work on it.

thanks guys. also it will be great if we can  make CE v0.2 as default


catalog-model: add stringifyEntityRef and deprecate serializeEntityRef

Hey, I just made a Pull Request!
Broke this out from ongoing catalog work
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

I really like this one, was on our list for some time 👍


Use the body color for dropdown menu text in navbars

Fix #17276

We should be able to apply this to the .dropdown-menu itself, without scoping it to the navbar, no?

That's a good point. I hadn't fully considered that as my thought was in most cases it would inherit that. But you're right it makes more sense to be explicit about that. That update has been pushed
I think I got the right declaration order but I couldn't figure out if your guide was to have imports last or because it's visual use alphabetical within this section... Sorry if I got it wrong!

color comes after font and line-height properties :). See https://github.com/twbs/bootstrap/blob/v4-dev/scss/.scsslint.yml#L93 for the specifics. Some of the reasoning is highlighted at http://codeguide.co/#css-declaration-order.

OK. That's fixed. Is that just one of those things that is constantly looked at or just memorized over time?

Oh yeah, I've basically memorized it at this point since it's based on how I write CSS :p. You can lint it yourself with grunt scsslint though, too.

@kkirsche Update the commit message since this no longer touches navbar code?

Oops. Sorry about that @cvrebert

Rebased


macOS Sequoia and tvOS 18 support?

the app stopped working for me since i updated both operating systems.
it's stuck here:

i tried deleting the ATV Remote folder and restart the app. still doesn't work.

Same issue and sadly I have a feeling it probably won't be fixed because it seems the program is abandoned

It's not abandoned, it's just a shared personal project. I made this for me.
Things you can try:

Install command line tools: xcode-select --install

Install homebrew: https://brew.sh

Install pyatv directly https://pyatv.dev/documentation/#latest-stable-version

Pyatv is how this program communicates with the Apple TV. That plus websockets are the only Python packages it uses, that's what it's doing when that screen shows up.

You can also look at the setup code and try running it line by line to find out where it stops for you: https://github.com/bsharper/atv-desktop-remote/blob/main/build/start_server.sh

There are other closed issues you might have to look through, but I'm sure you can get it working. Generalizing every issue into a robust setup file is hard, but I'm open to pull requests.

I had the same issue when I updated to macOS Sequoia.  To fix the issue, go into the ~/Library/Application Support/ATV Remote/env/bin and run ./atvremote wizard
This seemed to reset the pairing and I could repair it again using atv remote.

I tried most of these fixes unfortunately they didn't work. I hope you are able to update this program soon. It was such a nice tool to use around the house. I was searching for something like this for years and just found your program a couple months ago. Too short a time to use it.

@roar5138 Can you share the file atv_pip_install.log from the path ~/Library/Application Support/ATV Remote? You can find this by going to Finder then pressing Cmd+Shift+G then pasting ~/Library/Application Support/ATV Remote and pressing enter. There should be a file called atv_pip_install.log. If you post that file I might be able to see what is causing the initialization to fail.

Unfortunately, I don't see that specific log file. I have uninstalled and re-installed it a couple times before remembering there was a TVos Update.  This is what the folder looks like if you have any ideas.
Thanks for getting back to me so soon.
Screen Recording 2024-10-10 at 11.24.58 AM.mov.zip

If you are running Sequoia, can you make sure this setting is correct under Privacy and Security / Local Network?

If it's not, I'd try enabling it and then deleting ~/Library/Application Support/ATV Remote (just drag ATV Remote to the trash can) and starting it again. The program will recreate this directory and everything in it, including the atv_pip_install.log file.

just to chime in, ever since i created this issue the app went back to working normally again. i didn't change anything in regard to the two operating systems. if my logs can help in any way i would be happy to post them.

@bsharper Yeah I had that setting on my local network. Thanks for all the help everyone. Maybe one day my will return to normal like @nimrodbens Hah, glad you got it back! I'll keep trying and if you have an idea, let me know!

hey all, just trying again to maybe get this back. am I missing anything as im looking for something called "./atvremotewizard". Just imagine you're talking to someone who definitely isn't a programmer....

@roar5138 I'm guessing you don't have command line tools installed? Seems to be starting and stopping quickly. If you had them installed before you might have to install them again: https://mac.install.guide/commandlinetools/4
Or the short version, type xcode-select –-install in the terminal.

If you are running Sequoia, can you make sure this setting is correct under Privacy and Security / Local Network?
If it's not, I'd try enabling it and then deleting ~/Library/Application Support/ATV Remote (just drag ATV Remote to the trash can) and starting it again. The program will recreate this directory and everything in it, including the atv_pip_install.log file.

Deleting the folder fixed the app for me, thanks for the app : )


fix: trestle transformation tasks naming convention.

Types of changes

[ ] Hot fix (emergency fix and release)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[x] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary
Conform to trestle transformation tasks naming convention, plus miscellaneous minor fixes.
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

Not done yet! Just results are done. Need to do the others. I suppose I can open a new PR for them.
cis-to-catalog
cis-to-component-definition
osco-result-to-oscal
profile-to-osco
tanium-result-to-oscal
xlsx-to-oscal-component-definition

Obsolete.


Fix concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor

Motivation
Fix concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.
Modifications

Adds test to expose concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.
Fixes concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Adds test to expose concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: ( no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

run cpp tests

run cpp tests

run cpp tests


[TEST] Add better query test

fix too much output of subprocess，add better error monitor case
##add more error case in openai sdk ,such as wrong input,wrong max token,etc

merged! thanks!


Further improvements of bubble map

Thanks @jdk137  :clap: :heart_eyes:
The bubble map starts to take the form and i certainly like what i see! Here are the further improvements

indicator is not translated. It should be =)

Indicator should use tree menu on click. See how it's done in bubble chart

Control opacity of bubbles with JS, not CSS. Copy and adapt the logic of updateBubbleOpacity() function (there are tricky combinations that's why we discarded CSS earlier).
One visible improvement: while one bubble is selected, other bubbles have to dim (become more transparent)

Standardise your CSS to vizabi variables oops, just did it

Adapt label system from bubble-chart: labels positioned relative to bubbles, not to cursor. The labels of selected bubbles stay on screen. Bubbles can be unselected by clicking a little cross in the corner of the label. User can drag labels to position them how preferred

If i select bubbles and set size to GDP, the selection text about population is not working anymore :-D
Replace "people" with the unit of the size hook

Connected views:

Hover country in select list, bubble gets highlighted.
Hover region in color legend: all bubble of the region get highlighted
listen to entities.highlight array in bubble map. see bubble chart or mountain chart for example

estimated time: a week from now

It would also be nice to keep the same ordering system from Mountain Chart for the list of countries.
This is Bubble Map (alphabetical):

This is Mountain Chart (by region and desc ordered by population):

@arthurcamara1 @jdk137 agree but let's wait sorting the list before @olarosling approves we should have one ;)

Two more improvement points:

opacity of non-selected bubbles: when one bubble is selected, all the others become more transparent. Check out bubble chart for an example

remove meridian and latitude lines. It would look something like this:

all done and finished in e874126fe16e7408bffa77ca106b36dbf1443fae


AutoEndSegmentGroups Help

Does anyone have any insight into how to implement AutoEndSegmentGroups?
I need to implement this for N1 loops that use N3, N4, and/or PER segments.
As soon as I set that flag to true, everything I had set up ends up breaking.
The serializer throws an error :: Unable to deserialize segment BIG. No matching property found on stack.
BIG is the first segment after ST and is implemented below
        [EdiValue("9(8)", Path = "BIG/0", Format = "yyyyMMdd", Description = "BIG01 - Invoice Issue Date")]
        public DateTime? InvoiceIssueDate { get; set; }

        [EdiValue("X(22)", Path = "BIG/1", Description = "BIG02 - Invoice Number")]
        public string InvoiceNumber { get; set; }

        [EdiValue("X(30)", Path = "BIG/4", Description = "BIG05 - Release Number")]
        public string ReleaseNumber { get; set; }

        [EdiValue("X(2)", Path = "BIG/6", Description = "BIG07 - Transaction Type Code")]
        public string TransactionTypeCode { get; set; }

        [EdiValue("X(2)", Path = "BIG/7", Description = "BIG08 - Transaction Set Purpose Code")]
        public string TransactionSetPurposeCode { get; set; }

Any insight would be appreciated.

The AutoEndSegmentGroups was introduced in #75 by @dfyx and maybe he could give some pointers.
I suggest should provide with your full models as well as a sample 810 file. The best way to do this is if you make a pull request and add your sample edi & sample models plus one test that fails with the problem you mention.


We have added more events in the month of december and january

Hello I want to add an open source event which is happening on JAN 3,2024 - JAN 17,2024
Can you please assign me in the issue? @anubhavpulkit


Failed to import getstream sdk on a server side: "ReferenceError: window is not defined"

I'm trying to use getstream-js on the server side (typescript + webpack + serverless) and getting "ReferenceError: window is not defined" error at .../lib/node_modules/getstream/dist/js/getstream.js:10:2:
(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory();
	else if(typeof define === 'function' && define.amd)
		define([], factory);
	else if(typeof exports === 'object')
		exports["stream"] = factory();
	else
		root["stream"] = factory();
})(window, function() {          <--- HERE

I'm not sure, but it might be related to the UMD modules issue in Webpack 4 (https://stackoverflow.com/questions/49111086/webpack-4-universal-library-target).

3.17.0 works fine though.

Closing this, let us know if you can reproduce this on 3.17 or newer

Oh, sorry, I wasn't clear enought: it works fine on 3.17 but doesn't on 3.19.