Low conversion performance for toJS

What happened
let dataSource = Immutable.fromJS( {peple: {age: 18, preferences:['basketball', 'football']}}} ); let jsObj = dataSource.toJS()
I'm using redux, which is very time-consuming for TOJS conversions, especially on some hardware devices.
For example, sometimes it can take 1 seconds or more.
I want to know if Imuutable has an API that can use immutable data directly in JavaScript.

How to reproduce

It sure does, that API is the iterable API.  You can read more about it here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols
Also you've included a code example, are you saying that on some devices running that line of code takes 1 second? If not I'm happy to take a look at the actual code which is taking a long time to run to see if there's any obvious problems with it.

@liangzhuang327 I think this may be a duplicate of #1453, which was resolved here and released in 4.0.0-rc.10. The performance now is almost 60% better than it was before the issue was introduced by 4.0.0-rc.8.
If you think there is an actual issue, please include steps to reproduce and the version you are using (or, ideally, a repository that demonstrates the issue like in #1453).
That said, it sounds like the issue has more to do with how you are using Immutable.js in combination with your state. From the redux docs on interoperability challenges w/ Immutable.js:

Note that Immutable.JS objects do have a toJS() method, which returns the data as a plain JavaScript data structure, but this method is extremely slow, and using it extensively will negate the performance benefits that Immutable.JS provides

There are a few approaches to working with immutable structures. The first is what @conartist6 mentioned.
Since all immutable structures are iterables, it allows you to do things like this:
const myMap = Map({ /* ... */ });
for(const [key, value] of myMap) {
  /* ... */
}

Something that probably better suits your needs is the Immutable.js Record. As long as you know the shape of your records ahead of time (and you don't need to support IE8), it allows you to read properties as though it was a regular object instead of having to use get() methods.

@lukaswelinder  Thank you very much for your answer，I find I really don't need to convert immutable data into JavaScript objects or arrays
In addition, I would like to ask you another question：

/* in redux */
const myMap = Map({ test: 'hello' });
let count = 0
export function(state = myMap, action){
switch(action.type){
 case 'TEST':
     count++
     return state.merge({ age: count})
}
}
//dispatch
dispatch({type: 'Test'})

As shown above，Whenever I dispatch this Action,redux state will change once. According to the Immutalbe documentation, a new immutable data is generated each time the immutable data is changed, and I wonder where the immutable data generated each time is stored? Will it be put into memory? If so, will it cause the browser to become more and more stuttering?

You can see a bit how Immutable data is stored just by taking a look at an Immutable object. The reference equality property derives from the fact that Immutable data structures are like fancier versions of linked lists.
I might represent a simple singly linked list as three nodes, each storing a value and reference to another node. In shorthand, this would look like:
node(3) -> node(2) -> node(1)

In this case having a reference to node(3) is enough to allow you to get the values 3 -> 2 -> 1. If the implementation of node forbids changing its contents, that list is immutable. I could add an item to it by making a node(4) which points to node(3), and this would not require changing node(3). Thus node(4) is a separate list which is !== to node(3), even though the rest of the memory for storing items is reused. This is the fundamental pattern which immutable exploits to preserve reference equality.
If you want to get more technical, Immutable isn't actually using singly linked lists, it is using the Tries. I believe the nodes in the tree are stored under vNode when you look at an immutable object. The cost of doing things this way is random access. If you look at Immutable's documentation, you will find that List and Map's .get() methods are not defined to take O(1) time as they would with a normal array or object. They take O(log32 n) time, because Immutable must walk the tree. In general, though, you shouldn't be worried by this. Immutable is quite performant.

@liangzhuang327 A simpler way of describing what @conartist6 said above is that Immutable.js uses object property sharing when creating a new object from a change. I'll try to explain briefly.
Normal property value assignment would be like this:
const a = { age: 1 };
const b = {};
b.age = a.age;

In this example, the value is copied in memory. Do this too many times and you start to use more memory.
Property sharing works something like this:
cosnt a = [['age', 1]];
cosnt b = [];
b[0] = a[0];

In this example, we just pass a reference to the key/value, so there is less memory used.
For smaller data sets (like your example), Immutable.js might be overkill, but when you have larger sets of data that are frequently changing, it can help reduce memory usage and improve performance.


Force NVML-based CUDA check in PyTorch 1.14+

What does this PR do?
Follow up to https://github.com/pytorch/pytorch/pull/85951 which landed in pytorch master and will appear in 1.14.
cc @borda @justusschock @awaelchli @kaushikb11 @akihironitta @rohitgr7 @speediedan @carmocca
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
I made sure I had fun coding 🙃

Why is this still a draft? We want this for 1.8, correct?

Won't people that use PyTorch 1.13 and install PL 1.8 have issues with fork until we update the version check?

Yes, I guess for the version check that's good to have.

Will there be a way to disable this? When running a pytest test, this check sometimes takes ~9s, adding a lot of overhead to the test suite. I think there are situations when you know you don't want to run with GPU, and you would like this disabled. What do you think?

@jzazo Which version of Lightning and which version of PyTorch is your pytest running with?

pytorch_lightning 3.8.6
pytest 7.2.0
torch 1.13.1

I am analyzing the time with pyinstrument. I was observing two days ago ~9s delay when the trainer was initialized, but I can no longer reproduce that number. I deleted and reinstalled the environment, maybe things changed. If I can reproduce it again I will let you know.
If you have comments, explain. Should it be really fast ~ms?

I don't know why it should be slower by this much. Looking back, in 1.8.6 we are using this code to determine the device count:
https://github.com/Lightning-AI/lightning/blob/caa3329b79965f7712e49bd9f8933f7a4686c49b/src/lightning_lite/accelerators/cuda.py#L106-L112
Since you are using torch 1.13.1, we are falling back to the default torch implementation:
    if _TORCH_GREATER_EQUAL_1_13:
        return torch.cuda.device_count()

If you are seeing this again, it could be worth trying to set os.environ["PYTORCH_NVML_BASED_CUDA_CHECK"] = "0" in a fixture in your test suite.


Hue Motion - Motion Status & Active

Describe the bug
I cant get any status from the Motion Event. In the Function Block I have the following
msg.payload.motion
return msg;
Also with the the Active Event, When its Active it outputs "null" and when inactive it outputs "false". Is this correct or should it have "True" when its Active?
Expected behavior
Expected to get a "True" or "False" Status from the Motion Event and Clarification on the Active Event as above
Please complete the following information:

NodeRED version: [v1.0.6]
NodeJS version: [..12.16.2.]
Device running NodeRED: [.Raspberry Pi 4..]

This is fixed with the latest release (at least the invalid active state). Your function block seems incorrect. If you want to return the motion state, just return the motion state ;)
return msg.payload.motion;
This should output a boolean with the current motion state if something is moving in front of the sensor.


[1.1.0] calendar: open weekly note not obey the weekly syntax format

but the previous version is supported

it seems that daily note also not work

Hi @bytemain, thanks for the report. This is a known issue. I'm tracking the Calendar plugin support issue here: #100
It will be fixed in the next version of the Calendar plugin.


chore: 🔧 Reduce chromatic load via bundled screenshot story

Pull Request
📖 Description
The amount of screenshots taken by chromatic needs to be limited to avoid running out of screenshots.
🎫 Issues
Closes #55
👩💻 Reviewer Notes
📑 Test Plan
✅ DoD

[x] I have tested my changes manually.
[ ] I have added automatic tests for my changes (unit- and visual regression tests).
[x] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[x] I have made sure to follow the projects coding and contribution guides.
[x] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[ ] I have used design tokens instead of fix css values

Please re-assign me, when you're done with the changes. :)


Pagemode bookmarks won't work with embed pdfjs in Firefox

Configuration:

Firefox 57 64bits
Linux Mint 18.2
PDF.js v 2.0.144
Not in browser extension

Steps to reproduce the problem:

embed pdf.js, and open a pdf with viewer and use of option #pagemode=bookmarks

What is the expected behavior?
The pdf will be rendered with bookmarks panel open
What went wrong?
The bookmarks pane wasn't open
Also note the rendering of the pdf is blank until an external event came as scroll pdf or resize browser window
Everything is fine in same site with chromium panel and rendering
I noticed in js console :
Error: Unknown action from worker: GetPageMode
pdf.worker.js:1298:5
messageHandlerComObjOnMessage@http://localhost/OpenTPE/OpenTPE/views/js/pdfjs/build/pdf.worker.js:2651:7
pdf.worker.js:1299:5
Error: Unknown action from worker: GetPageMode

embed pdf.js, and open a pdf with viewer and use of option #pagemode=bookmarks

Please provide access to the complete example online, as requested in both https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md and https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md.

Also note the rendering of the pdf is blank until an external event came as scroll pdf or resize browser window

This sounds like an issue with how your custom implementation of PDF.js, but from a distance it's impossible to tell what might be wrong.

I can't provide access to an online example, so i extracted the pdfviewer part of this project and put it online and with the inverse of murphy's law everything goes right :(
It's the same pdfjs files, same pdf, just some part differs like include of css or js script
Don't understand what's going on.
In my project pdf is loaded at page 0 and i need to scroll to force refresh of the view, the bookmarks pane can be opened manually but won't open automatically as #pagemode will.
I found a way to fix it in my project, use of 127.0.01 instead of localhost for accessing it o_O
Don't know if it's in link with pdf.js, firefox or apache so let's close it
Thanks a lot

Is there added Bookmark?


CfnDBCluster impossible to get ARN

Hi
I try to use the CDK to create infrastructure with AppSync and Aurora serverless.
Unfortunately I cannot get the ARN from the CfnDBCluster which is needed for the Data source and I AM role.
getAtt for Arn is also not working for CfnDBCluster
Is there another way to get the ARN?

Is there a general strategy for getting the ARN of a construct? If so, we should document it in the guide.

This is a limitation of CF, not of CDK. Unfortunately CDK does not expose it, so you will have to assemble it manually:
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_Tagging.ARN.html
let clusterArn = arn:aws:rds:${this.region}:${this.accountId}:clusterIdentifier:${cluster.clusterIdentifier}

@fimbulvetr Thanks for the info but CfnDBCluster also doesn't expose the clusterIdentifier
How do you get around this?
Basically I need the ARN of the newly created cluster to create the access role for the appsync datasource.
        const cluster = new CfnDBCluster(this, 'DBCluster', {
            databaseName: 'myDb',
            engine: 'aurora',
            engineMode: 'serverless',
            masterUsername: 'master',
            masterUserPassword: 'password',
            port: 3306,
            scalingConfiguration: {
                autoPause: true,
                maxCapacity: 2,
                minCapacity: 2,
                secondsUntilAutoPause: 300,
            },
        });

        // cluster.clusterIdentifier is undefined
        let clusterArn = `arn:aws:rds:${this.region}:${this.accountId}:clusterIdentifier:${cluster.clusterIdentifier}`;

        const role = new Role(this, 'GrantAppsyncAcessToClusterAndSecret', {
            assumedBy: new ServicePrincipal('appsync.amazonaws.com'),
        });
        role.addToPolicy(new PolicyStatement()
            .addAction('secretsmanager:GetSecretValue')
            .addResources(secret.secretArn)
        );
        role.addToPolicy(new PolicyStatement()
            .addActions('rds-data:DeleteItems',
                'rds-data:ExecuteSql',
                'rds-data:GetItems',
                'rds-data:InsertItems',
                'rds-data:UpdateItems')
            .addResources(
                "arn:aws:rds:us-east-1:123456789012:cluster:cdktrialstack-dbcluster-?????????????",
                "arn:aws:rds:us-east-1:123456789012:cluster:cdktrialstack-dbcluster-?????????????:*",
            )
        );

@BerndWessels  Apologies, I made two mistakes:

It should be "cluster" in part 6 of the ARN, not clusterIdentifier.
You should use the cluster.dbClusterName property.

Like so:
let arn = `arn:aws:rds:${this.region}:${this.accountId}:cluster:${cluster.dbClusterName}`

@fimbulvetr Thanks, I am trying this out now.
I am slightly confused about the execution order within the CDK. Will the CfnDBCluster be created first, then the let arn ='arn:aws:rds:${this.region}:${this.accountId}:cluster:${cluster.dbClusterName}'; statement executed to receive the correct value to be used in the Role that has the secret.node.addDependency(cluster); ?
So basically what is the magic that puts the correct cluster.dbClusterName into the let clusterArn = 'arn:aws:rds:${this.region}:${this.accountId}:cluster:${cluster.dbClusterName}'; - since the cluster needs to be created before the value will be available ?

Wow, that works.
I think I understand how - so actually the CDK is clever enough to turn string templates like
let arn =`arn:aws:rds:${this.region}:${this.accountId}:cluster:${cluster.dbClusterName}`;

into
              Fn::Join:
                - ""
                - - "arn:aws:rds:"
                  - Ref: AWS::Region
                  - ":"
                  - Ref: AWS::AccountId
                  - ":cluster:"
                  - Ref: DBCluster

which is resolved at the "right" time within the flow of the CloudFormation Stack.
Pretty cool ;)
I would still prefer if all resources would give easy strongly typed access to all necessary properties without workarounds, but anyways cool that there is a workaround for now - thanks to @fimbulvetr

@BerndWessels If you're familiar with standard CF, you'll know that you can set up a resource, say a cluster with a name of FooBar,  you can refer to it later when setting something else (Like an IAM role or something) up by using the !Ref FooBar and CF will know that it has to evaluate that "later" (i.e. not right now).
Basically, CDK behind the scenes is adding !Ref FooBar to your template.
See this page (or google "cloudformation ref" for more examples:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ref.html
The tricky part is knowing that there are in general two ways to refer to an object - either GetAtt or Ref. Depending on the resource Type (AWS::Lambda::Function, AWS::SNS::Queue, etc.) , Ref might return an ARN, a Name, a UUID, etc. Also depending on the resource type, you may or may not have the ability to use GetAtt. In general, you can get an ARN from a resource using either GetAtt or Ref. Some resources (Such as RDS Cluster) inexplicably don't have the ability to get an ARN. Some resource types give you the ability to get a lot of useful things from GetAtt, some give you none.
I suggest always browsing the docs, it's what I do and it's how was able to get the RDS ARN to work for my usecase.
Just go to the Resource Type, and on the right click "Return Types". It will tell you what the "Ref" returns and if applicable, what GetAtts are available and what they return. For example:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-account.html#aws-resource-apigateway-account-returnvalues
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appsync-graphqlapi.html#aws-resource-appsync-graphqlapi-returnvalues
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-certificatemanager-certificate.html#aws-resource-certificatemanager-certificate-return-values
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudfront-distribution.html#aws-resource-cloudfront-distribution-ref
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html#w2ab1c21c10d110c14c15
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#aws-properties-ec2-instance-returnvalues
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html#w2ab1c21c10d183c21b9
Just browse to those and see the variations of what Ref returns and if/what GetAtts are available.

@fimbulvetr Thank you, great advice - will do.

@fimbulvetr Oh, one last thing - this document says
Fn::GetAtt

Fn::GetAtt returns a value for a specified attribute of this type. The following are the available attributes and sample return values.

ClusterResourceId

    The resource id for the DB cluster; for example: cluster-ABCD1234EFGH5678IJKL90MNOP. The cluster ID uniquely identifies the cluster and is used in things like IAM authentication policies.

But if I use cluster.getAtt('ClusterResourceId') I get this error
 CdkTrialStack failed: ValidationError: Template error: resource DBCluster does not support attribute type ClusterResourceId in Fn::GetAtt
Template error: resource DBCluster does not support attribute type ClusterResourceId in Fn::GetAtt

Any ideas if I am doing something wrong or if there is another way to get the ClusterResourceId ?

Oh it's because you were on the DocDB::DBCluster:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-docdb-dbcluster.html
You want to be on RDS::DBCluster:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbcluster.html

testing with 1.4.0 version and arn that works now is:
let arn =arn:aws:rds:${this.region}:${this.account}:cluster:${cluster.ref};
so, instead of cluster.dbClusterName use cluster.ref

Thanks @goranopacic ! Closing this issue but please reopen it if you want to discuss things further.


[BUG] "Keywords added successful" with no keywords beeing shown

Hey, first of all, thanks for this awesome project!
Unluckily I have a problem where I can't add keywords. I spun up the project with the example compose and left the values as standart (on the first try i changed the key and password and so on). Then I went into the settings and added the API key for the scrapper (this works, as everytime I "add" a keyword, the count of requests on the scraper site ticks up!)
But I can neither view them in the WEBUI nor in the "api" (/api/...) in the browser (different browsers). It does show my domains, but not my keywords.
From the logs:

[1] Error: Settings file dont exist.
[1]     at getAppSettings (/app/cron.js:34:16)
[0] Listening on port 3000
...

[0] time taken: 6722.727298736572ms
[0] [Error: ENOENT: no such file or directory, open '/app/data/failed_queue.json'] {
[0]   errno: -2,
[0]   code: 'ENOENT',
[0]   syscall: 'open',
[0]   path: '/app/data/failed_queue.json'
[0] }
[0] [SUCCESS] Updating the Keyword:  KEYWORD
[0] GET /api/domains
[0] GET /api/keywords?domain=DOMAINNAME
[0] getKeywords:  0

I can see the request in the browser as well as an successful answer from the backend. I am also able to see that there is in fact data in the DB (per "cat" on the server).
I hope this helps. If you need any other information, I will gladly take another look into the logs.

@justuspfaue Sounds like the issue is actually on the frontend. Can you please check the browser console log and see if there are any errors once you submit the Add Keyword Modal?

Hi @towfiqi,
I just installed it via docker and am encountering the same problem as op.
When looking at the browser console there are no errors.

Adding Keywords: POST Request to /api/keywords comes back as 200 ok, payload looks okay too (has all the keywords and no error)
In the container's log I can see that the added keywords have been successfully updated
After reloading the page for the domain, the request to fetch the domains comes back as 200 with {"keywords":[]} as payload and the backend log says [0] GET /api/keywords?domain=[redacted] and [0] getKeywords:  0

Having the same issue. I've noticed that I'm only seeing these errors on domains that have "www."

@establishedweb Thanks for that. Just spotted the bug. Will push the fix shortly.

@justuspfaue You are not unlucky. Its the same bug, but it occurs for domains with hyphens. Will be fixed shortly.

It's fixed now. Thanks!


track pad three finger drag

Description of the new feature / enhancement
on a macbook, if i have three fingers on the trackpad and drag, i will move a window, select text, etc. double tap + 2 fingers feels extremely foreign and there is no way to change this in the trackpad settings. It would be great to have an option for "mac style" trackpad 3-finger-drag
Scenario when this would be used?
enabled at all times (similar to the keyboard shotcuts).
I will use this every 15 seconds of my life :)
Supporting information
No response

I'd look at https://github.com/microsoft/PowerToys/issues/4484.  Depending on the trackpad, this is enabled via windows settings.  I'm going to dup this against that.
As for generic implementation, honestly, i don't think there is an API we as PowerToys can hook into as it seems very hardware dependent to enable.

I don't believe the mac-style behavior exists in the windows settings.
this is a decent video of it: https://www.youtube.com/watch?v=ABZDg3Rxik0&t=29s

any laptop that can support 3 fingers, would be plenty good I imagine. magic trackpad (if you buy an external one) or the surface book trackpad etc.
To your point about the hooks available, if there isn't one then yeah, can't be helped :/

Actually, it is not that hard to develop, I made it in two days, in a C# WPF application, that uses the raw input API and the library emoacht/RawInput.Touchpad.
And it works well!
If you wanna take a look, it is available on my GitHub https://github.com/ClementGre/ThreeFingersDragOnWindows
Enjoy!
PS: It would still be fantastic to have this on PowerToys.

I second that... almost made another feature request for this... Besides it is very helpful and almost dispenses the use of a mouse on laptops when this feature is available.  Because dragging is much faster and more precise because we dont have to worry about double clicking all the time.
Also when we double click the point shifts position most of the time.
So FOR A POWER USER, 3 finger dragging should at least be an option if not a must.

I couldn't get it to work on my Thinkpad P52 laptop running windows 11 which by the way supports up to 4 fingers gesture.
I disabled all three finger gestures as well as double tap and drag.
Please let me know if i'm doing something wrong.

the problem is it does recognize up to two fingers and when third finger is placed on trackpad it shows only one finger regardless of how close or far apart fingers are.

I recently had my macbook replaced by my work with an HP for "security" :( - Luckily PowerToys was approved. I would definitely love to have this feature implemented.
In case it's helpful there is a solution on linux called fusuma. I don't know if any principles could be transferrable from the implementation there but it could help get around some of the concerns around hardware input. Happy to help but have basically no experience coding with windows.


Fix loss calculation

The fix can be found in this timestamp of the course but hasn't been applied to the notebook.

Thanks!


Add support for op_block_list

Background
Added a new argument to the quantize script called "op_block_list." If op_block_list is provided, do not quantize those ops. Sometimes you have ops that are incompatible with quantization.
Test Plan
Regession Test

This test is just making sure there are no regressions in behaviour when you don't provide an op_block_list
git clone https://huggingface.co/onnx-models/sentence-t5-base-onnx
This model has a /model/model.0/auto_model/encoder/block.0/layer.0/SelfAttention/Range node so we are checking that it is still excluded because it is part of the default exclude types (https://github.com/microsoft/onnxconverter-common/blob/master/onnxconverter_common/float16.py#L108)
Test with main branch of transformers.js
git checkout . && rm -rf ./*_*.onnx || true && PYTHONPATH=../transformers.js ../transformers.js/.venv/bin/python3 -m scripts.quantize --input_folder . --output_folder . --mode fp16
Run stat: stat -f "%z" model_fp16.onnx

220762121

Now test with this PR branch
git checkout . && rm -rf ./*_*.onnx || true && PYTHONPATH=../transformers.js ../transformers.js/.venv/bin/python3 -m scripts.quantize --input_folder . --output_folder . --mode fp16
Run stat: stat -f "%z" model_fp16.onnx

220762121

File size is the same so test passed

Qwen2-VL Test

Here we actually check that the op_block_list works
Checkout this PR for transformers.js
Clone this repo https://huggingface.co/pdufour/Qwen2-VL-2B-Instruct-ONNX-Q4-F16
Delete already quantized models so it doesn't double quant them
rm -rf onnx/*_*_*.onnx
Quantize the A model without the op_block_list
PYTHONPATH=../transformers.js ../transformers.js/.venv/bin/python3 -m scripts.quantize --input_folder ./onnx --output_folder ./onnx-dest --mode q4f16
Run the infer script: python3 infer.py Qwen/Qwen2-VL-2B-Instruct ./onnx

Expected result: No error.
Actual Result: onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Load model from ./onnx/QwenVL_A_q4f16.onnx failed:Type Error: Type parameter (T) of Optype (Sub) bound to different types (tensor(float) and tensor(float16) in node (/Sub).

Now we quantize with the op block list
rm -rf onnx/*_*_*.onnx
PYTHONPATH=../transformers.js ../transformers.js/.venv/bin/python3 -m scripts.quantize --input_folder ./onnx --output_folder ./onnx --mode q4f16 --op_block_list Conv DynamicQuantizeLinear DequantizeLinear Resize
Try infer script again

python3 infer.py Qwen/Qwen2-VL-2B-Instruct ./onnx
The image shows a vintage teal-colored...
You see the correct result

Very useful! Thanks! Just for my testing, is the model you're testing available on the Hugging Face hub?

One curious behaviour is that if you do provide a op_block_list it doesn't include the defaults anymore https://github.com/microsoft/onnxconverter-common/blob/master/onnxconverter_common/float16.py#L141. I am not sure if you want that or not, could also include the defaults if that's preferred. But then it's impossible to clear them.

One curious behaviour is that if you do provide a op_block_list it doesn't include the defaults anymore https://github.com/microsoft/onnxconverter-common/blob/master/onnxconverter_common/float16.py#L141. I am not sure if you want that or not, could also include the defaults if that's preferred. But then it's impossible to clear them.

Good point! We should then default to None instead of an empty array.

@xenova Updated PR to use None and added some more comprehensive tests in the description.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


MultiplayerSynchronizer doesn't synchronize Resources

Godot version
4.0.1stable
System information
Windows 11
Issue description
The new MultiplayerSynchronizer node does not sync resources. It never updates them, neither on spawn, nor on sync.
Using the same Synchronizer to sync other properties (such as Vectors or ints) works fine.
This is pretty major as it makes using the MultiplayerSpawner to spawn a node which needs to have a resource set on spawn (in my case I want to sync a custom PlayerStats resource which contains max_health, which is used in _Player.ready()), as you can't use the Spawner for it then, because you cannot add custom spawn synchronization without a MultiplayerSynchronizer.
Steps to reproduce
Assume a tester node:

with a script:
#tester.gd
extends Node2D

@export var some_resource: Texture2D

func _input(event: InputEvent) -> void:
	if multiplayer.is_server():
		if event.is_action("ui_accept"):
			some_resource = GradientTexture2D.new()

As you can see a resource (Texture2D) is exported so that it can be synced by a MultiplayerSynchronizer.
Now we add it to the Synchronizer of the Tester:

We add the net code from the official blogpost to a simple UI.

# multiplayer.gd
extends Control

const PORT = 4433

func _ready():
	# Start paused.
	get_tree().paused = true

func _on_host_pressed():
	# Start as server.
	var peer = ENetMultiplayerPeer.new()
	peer.create_server(PORT)
	if peer.get_connection_status() == MultiplayerPeer.CONNECTION_DISCONNECTED:
		OS.alert("Failed to start multiplayer server.")
		return
	multiplayer.multiplayer_peer = peer
	start_game()
	# calls the world.start() method (see below) to add the first tester to the world.
	get_parent().start()

func _on_connect_pressed():
	# Start as client.
	var txt : String = %IPEdit.text
	if txt == "":
		OS.alert("Need a remote to connect to.")
		return
	var peer = ENetMultiplayerPeer.new()
	peer.create_client(txt, PORT)
	if peer.get_connection_status() == MultiplayerPeer.CONNECTION_DISCONNECTED:
		OS.alert("Failed to start multiplayer client.")
		return
	multiplayer.multiplayer_peer = peer
	start_game()

func start_game():
	# Hide the UI and unpause to start the game.
	hide()
	get_tree().paused = false

Together with a Container to spawn the Tester in (to test if they are synced on spawn), also with the code from that same blogpost:
#world.gd
extends Node

# was _ready() in the blogpost, changed here to spawn the first player only after host button is pressed.
func start():
	# We only need to spawn players on the server.
	if not multiplayer.is_server():
		return

	multiplayer.peer_connected.connect(add_player)
	multiplayer.peer_disconnected.connect(del_player)

	# Spawn already connected players.
	for id in multiplayer.get_peers():
		add_player(id)

	# Spawn the local player unless this is a dedicated server export.
	if not OS.has_feature("dedicated_server"):
		add_player(1)

func _exit_tree():
	if not multiplayer.is_server():
		return
	multiplayer.peer_connected.disconnect(add_player)
	multiplayer.peer_disconnected.disconnect(del_player)

func add_player(id: int):
	var tester = preload("res://tester.tscn").instantiate()
	# Randomize character position.
	tester.name = str(id)
	$Container.add_child(tester, true)

func del_player(id: int):
	if not $Container.has_node(str(id)):
		return
	$Container.get_node(str(id)).queue_free()

Now running the project and connecting to clients, we can use the remote debug tool (in the scene tree) to look at the resource at runtime.
Host:

Client:

Pressing Enter changes the resource on the server but not on the client.
Minimal reproduction project
MultiplayerSynchronizerBug.zip

Duplicate of #74325, this is by design

Oh, sorry I didn't find that while looking for existing issues.
So there is no way of syncing any "object type properties", does that mean you cannot sync any type of object that isn't a primitive value? Would I need to sync every single primitive value of the resource individually then?

Ok, thank you for the quick help :)
Closing this, as it adds nothing new to the duplicate mentioned above.


Set context for copied message on retry

Sets the context for the message copy when it is retried.
The problem is that currently if a handler fails to process a message - it is copied, but without a context. That might result in the errors in the handler if it waits for the partition, offset or message timestamp fields in the context, which are set here https://github.com/ThreeDotsLabs/watermill-kafka/blob/b03a4f48517c6afd50b3b1de4d89faa57faf971f/pkg/kafka/subscriber.go#L546-L548
Context is created here and set for the original message https://github.com/ThreeDotsLabs/watermill-kafka/blob/b03a4f48517c6afd50b3b1de4d89faa57faf971f/pkg/kafka/subscriber.go#L556-L558

Thank you @sevaorlov!


Breaking up integration docs

OPS Build status updates of commit 465f392:
:clock10: Pending: waiting for processors (95 builds ahead of you)
:warning: OPS Build is busy, click here to report any potential performance downgrade issues, or you could view OPS Portal for trend of build queue length.

OPS Build status updates of commit 465f392:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit 465f392:
:clock10: Incremental building: average incremental building time is 19 sec(s)

OPS Build status updates of commit 465f392:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/bind-a-model.md
:white_check_mark:Succeeded
View

docs/create-a-session.md
:white_check_mark:Succeeded
View

docs/evaluate-model-inputs.md
:white_check_mark:Succeeded
View

docs/get-started-desktop.md
:white_check_mark:Succeeded
View

docs/integrate-model.md
:white_check_mark:Succeeded
View

docs/load-a-model.md
:white_check_mark:Succeeded
View

docs/what-is-a-machine-learning-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit f7a28f3:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit f7a28f3:
:clock10: Incremental building: average incremental building time is 19 sec(s)

OPS Build status updates of commit f7a28f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/bind-a-model.md
:white_check_mark:Succeeded
View

docs/create-a-session.md
:white_check_mark:Succeeded
View

docs/evaluate-model-inputs.md
:white_check_mark:Succeeded
View

docs/get-started-desktop.md
:white_check_mark:Succeeded
View

docs/integrate-model.md
:white_check_mark:Succeeded
View

docs/load-a-model.md
:white_check_mark:Succeeded
View

docs/what-is-a-machine-learning-model.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


blocking::spi::write_iter has a needless Default blocker?

Why does blocking::spi have this custom Default trait?
It's making using things like IntoIterator<Item = u8> impossible with write_iter with errors like:
embedded_hal::blocking::spi::write_iter::Default<u8>` is not implemented for `nrf52832_hal::Spim<nrf52832_hal::nrf52832_pac::SPIM0>

I don't see why this default is even needed.

Even without conversion tho, say we want to use [Into]Iterators for greater flexibility, this Default trait is a blocker.
If there's no reason for it to exist I'd make a PR to remove + unify I2C and SPI naming (write vs write_iter currently).

Nvm, figured it out with Disasm's help.


More control/settings for how undo behaves when working in the context of the explorer

Issue Type: Feature Request
Hey,
I love Visual Studio Code. It's by far my favorite editor. However, there's a new (?) feature that's been giving me headaches recently. Maybe it's not new, but I've only noticed it disrupting my workflow recently.
The problem
If I use undo while the context is the explorer, it will silently start removing and renaming files based on the last changes that occurred in the explorer. The problem is, I may have added files an hour ago, and could now be working on a new file and simply want to undo a typo in the new file (that just happened). But, if I'm accidentally in the explorer and hitting undo, it will silently start perma-deleting all my files. Once I realize what's going on, it may be too late to truly recover them.
How it affects one's workflow
It's hard to realize sometimes that the undo is happening in the file explorer, where there can be hundreds or thousands of files, silenting renaming or deleting themselves. When the undo action doesn't delete the latest typo in a file, it's easy to see why one would start spamming undo, only to realize later that they're making changes in the explorer.
Solution
I'd like to have a setting that warns me (either every time, or only on the first delete/rename/restore) that I'm about to take an "undo" action in the Explorerer and not the currently or last opened file. If the context ever switches to a file, then I should be warned again when undo will affect the explorer--again, either for the first "new" explorer undo action, or only the first--until the context changes again.
I envision a simple dialogue box asking me to confirm.
Thanks
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:32:10.090Z)
OS version: Linux x64 5.4.0-65-generic snap

We have actually done this in the current January release and should be out in VS Code stable in a couple of days. We will ask for confirmation every time there is a destructive undo. Try it out and let me know how it goes.

Hah. You guys were already on top of it! Just got the update and tried it
out. It works just as expected--awesome.
Thanks
On Thu, Feb 4, 2021 at 7:58 AM Isidor Nikolic<EMAIL_ADDRESS>wrote:

We have actually done this in the current January release and should be
out in VS Code stable in a couple of days. We will ask for confirmation
every time there is a destructive undo. Try it out and let me know how it
goes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/115750#issuecomment-773285522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEMUDYXKNOCPC4ML63INA73S5KKWHANCNFSM4XCX3V5A
.

Lovely, thanks for letting us know.


Show LOC under a particular folder using badge

I find that the LOC on the badge seems to be much larger than what I would expect. The tool seems to be counting much more than just code (even with category=code). There are 16460 newline characters under src in my repo. I think this tool excludes comments so I expect a number smaller than 16.5K but I get 71.9K. I have a lot of files that aren't code in my repo!
To solve this problem, perhaps there should be a way to specify which directory to search under when generating the badge. Something like this:
https://tokei.rs/b1/github/xampprocky/tokei?category=code&dir=src

This would produce a much more reasonable number.

Thank you for your issue! I agree this would be a nice option. I'm going to close this issue as a duplicate of #2


Open Example in (GitPod, VSCode) style thing.

Closing - codespaces seems to cover this as far as @afolson and I can recall!


Update Aliyun ECS node driver UI

Can you make API calls to them through the proxy to validate API credentials and lookup instance types and other stuff (like AWS or DO, except for some parts AWS doesn't have the info in the API) instead of maintaining lib/shared/addon/utils/aliyunecs-choices.js ?  It's a long feedback loop for creating a node template and a pool and it fails and go back and edit and try again so I'd like all the drivers to actually validate things and talk to the API beforehand...

Done. Now it makes API calls to Aliyun ECS through the proxy like AWS.


elements invisible or rendered with wrong z-index

Bug reports:
I noticed that some elements are invisible when rendered on canvas. I narrowed it down to elements that are child of "flex" element and have position "static"
https://codepen.io/creativeinteractivemedia/pen/dyqKzjK
Specifications:

html2canvas version tested with: 1.4.1
Browser & version: Chrome, Safari
Operating system: macOS 12.6

in codepen exaple, change css like this
.green-wrapper {
  display: flex;
  position: relative;
}

will works fine;
i don't know why
~~ i am researching...


Move Darwin-specific types to darwinMain source set

This makes it easier to add new native platforms in the future.
Test: gw :compose:ui:ui-text:assemble

Friendly ping!


quick-sip:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: This is a template to produce Quick Reference Handbook style checklists.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thanks :)


Missing required param for url

This add "required" param to fix missing slide when adding.

Questions
Answers

Description?
Please be specific when describing this change. What did you change? Why?

Type?
bug fix / improvement / new feature / refactor

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes #{issue URL here}, Fixes #{another issue URL here}

Sponsor company
Webo.agency.

How to test?
Check if adding slide is now required to input image src as is core feature of module to begin with and for template to render slide.

Hello @Triloworld!
This is your first pull request on ps_imageslider repository of the PrestaShop project.
Thank you, and welcome to this Open Source community!

Nope. It isn't URL alone but "image_url". Fixing that.

Added to check for every language. Tested on <IP_ADDRESS>

I will rewrite pull request to only required changes

Duplicate of: https://github.com/PrestaShop/ps_imageslider/pull/106


WELD-2389 introduce new SPI method at Environment

So I came with this but TBH I am not 100% sure about it. This would mean to override this new method also in org.jboss.as.weld.deployment.processors.WildFlyWeldEnvironment right?

Well, it might return true by default...

true by default would make more sense as the only case where it's false is actually SE, right?

Yes, if talking about the default set of envs.


SyntaxError: Unexpected token import when running Jest and importing a React component from nested directory

I am using create-react-app and having trouble running Jest.
When I attempt to import a React component into my test file, I get an error when I yarn test:
Test suite failed to run

.../src/node_modules/common/ErrorMessage.js:1
({"Object.<anonymous>":function(
module,exports,require,__dirname,__filename,global,jest)
{import React from 'react'
^^^^^^

SyntaxError: Unexpected token import

This is what my test file looks like:
// test.test.js

// attempting to import
import ErrorMessage from '../node_modules/common/ErrorMessage.js'

// dummy test
test('adds 1 + 2 to equal 3', () => {
     expect(1 + 2).toBe(3)
})

However, the error does not get thrown if I'm at the root of the src file, importing my index.js. At that point, the error gets thrown in the first file that index.js imports. For example:
test.test.js
import index from './index'

index.js
import React from 'react'
import { render } from 'react-dom'
import './style/index.css'
import LoginContainer from './node_modules/user/LoginContainer'
import NewUser from './node_modules/user/NewUser'
// etc.

terminal output
 FAIL  src/test.test.js
  ● Test suite failed to run

    /Users/hannahmccain/Desktop/DEV/expense-report/fullstack-expense-report/client/src/node_modules/user/LoginContainer.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import React, { Component } from 'react'
                                                                                ^^^^^^

    SyntaxError: Unexpected token import

      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/ScriptTransformer.js:289:17)
      at Object.<anonymous> (src/index.js:11:164)
      at Object.<anonymous> (src/test.test.js:3:14)

It seems like, in the context of Jest, Babel isn't able to compile the files in src/node_modules properly. I'm just at a loss as to how to correct that! Any insights would be appreciated.
Please let me know if you need more code, context, or info! I'm new at this :)

I don't think using src/node_modules for source code is currently supported. In 2.x alpha releases we support using Lerna or Yarn Workspaces for monorepos so maybe that would help you?

Great — that was the issue. Removed node_modules and all was well. And I will look into using Lerna or Yarn Workspaces. Thanks for your help!

I created a brand new create-react-app. I didn't change anything. I open terminal and run jest and get error "SyntaxError: Unexpected token import" - nay ideas?

So I cd'ed into src dir then ran jest again and now its giving a problem with JSX:

I'm having de same problem

@Noitidart @JulianeAlbuquerque
Please run yarn test or npm run test instead of jest

Thanks @bugzpodder I will test this out!

Oh wow thank you so much @bugzpodder!! It works!!

@bugzpodder Im getting another error after installing some packages. It seems its running tests in the 3rd party libs. Shouldnt node_modules be ignored? Am I doing something wrong?
Writing objects: 100% (7/7), 638 bytes | 0 byt FAIL  src\App\index.test.js
  ● Test suite failed to run
    C:\Users\Mercurius\Documents\GitHub\boiler\node_modules\redux-persist\es\storage\index.js:1    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import createWebStorage from './createWebStorage';                                                                                ^^^^^^
    SyntaxError: Unexpected token import
      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/ScriptTransformer.js:289:17)      at Object.<anonymous> (src/App/store/index.js:5:16)      at Object.<anonymous> (src/App/index.js:9:14)

Test Suites: 1 failed, 1 total
Tests:       0 total

Hi @Noitidart please file a new issue with appropriate repo steps.
If you do yarn test or npm run test it should just work.  If not then there must be something that doesn't work and I would have no idea without seeing more information.

Thanks @bugzpodder I'll definitely do that and share link. Really appreicate your attention!

Hey guys...
Are there another issue for that? What am I doing wrong?
It was working well yesterday, but I tried it again now and I got this >>
FAIL  specs/Login.spec.js
● Test suite failed to run
C:\App\projects\contabilidade\fe-contabilidade-client\specs\jest.setup.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import React from 'react';

             ^^^^^

SyntaxError: Unexpected identifier

  at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:403:17)


Resource Controllers and Routes

Is it possible to use:
Route::resource
in a Module routes file? I've tried but get: NotFoundHttpException in RouteCollection.php line 161:

My bad! Need to remove the prefix from the Route group.


New release on pypi

With the latest fix for timezone handling in python3 ( #9 ), I'd appreciate a new version pushed to pypi so pip install pause pulls in this fix.
Thanks! I love this little library.

Done.


Add programmatic setting of AWS credentials

AWS credentials are required to access S3. Typically these credentials end up in two locations - first, they're put in a core-site.xml file, where they're read out and used by the Hadoop InputFormat readers, which in Thunder primarily come in when reading binary Series data. For other access to S3, we use the boto module, which looks for credentials in a couple different places, including environment variables and a .boto config file. In the thunder-ec2 script we write out these credentials to a .boto file and push this file out to all workers.
So far so good. The problem comes in when running in managed environments that don't give direct access to the cluster node file systems, such as the new Databricks Cloud. Here we can push out credentials to be used by the Hadoop readers by something like the following:
sc._jsc.hadoopConfiguration().set("fs.s3n.awsAccessKeyId", ACCESS_KEY)
sc._jsc.hadoopConfiguration().set("fs.s3n.awsSecretAccessKey", SECRET_KEY)

But we don't have a good solution (or any solution, really) for getting the AWS credentials out where they can be used by boto on the workers. So, at the moment, on Databricks Cloud most attempts to access S3 fail once a worker node attempts to connect and discovers that it doesn't have the AWS credentials.
The "solution" implemented in this PR is to add a new setAWSCredentials method on the ThunderContext object (accessed as tsc in the shell). Calling this method should make it so that all data loaded in the future will use the passed access keys to reach S3. These keys should be propagated out to child Data objects, and in general everything should Just Work. If this method is not called, then the current behavior should be maintained - the only reason one should have to use this new method is if you are in an environment where you don't have direct access to set configuration files or environment variables on worker nodes.

This PR has a whole lot of plumbing, but not much in the way of actual meaningful changes. I'm planning to do some more extensive testing on ec2 tonight and tomorrow, but wanted to get this PR out now in its current state for visibility.

After some testing on ec2 with all credentials saved in files blown away, I'm reasonably confident that this PR is complete and functional.

After a chat with @industrial-sloth offline, to handle the saving of data objects back to S3, we're going to try using the credentials as stored on the Hadoop configuration attached to the data object's rdd, as opposed to storing them explicitly as attributes on the data object.

I'm going to close out this PR and open a new one after squashing commits.


[ECS] [Parallel] Add Option PARALLEL_TIMEOUT_IN_SECONDS and PARALLEL_SYSTEM_ERROR_COUNT_LIMIT constant to allow reconfigure it in ecs config

make it minimal 120 seconds
make configurable

@enumag  this is to handle https://github.com/symplify/symplify/issues/3914
Ref for inspiration came from rector :

https://github.com/rectorphp/rector-src/pull/1657
https://github.com/rectorphp/rector-src/pull/1673

All checks have passed 🎉 @TomasVotruba it is ready for review.

Thank you :+1:


It is not possible installing last version 1.0.5 using yarn or npm

I-m trying to install the last version of the module that has the loop prop implemented, but the last package is stopped at the version 1.0.4

New version published @ingmiki 🎉


Decouple app definitions from the server code

Clearly separate the app definitions from the rest of the MST user-facing server

That means putting the app definitions in a separate git repo that we either load directly from the servers, or put into a db (I favour the former until we need actual app modifications outside the deployment process, and git automatically gives us versioning).

Currently we load the workflows/apps into redis on each server startup, then load the apps back. This doesn't make much sense to me. For simplicity, I think we should commit the repo of apps as a submodule to the mst server code, so we can control the versioning directly, and have functional tests running on the correctly versioned apps.


fix(pages): change special months selector in settings page

:tada: This PR is included in version 2.130.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Automatically report crash reports

Use Electron crash reporter, as described here.
Do we want/need this?

I guess we want that, mid-term.

We'll continue from here -> https://github.com/camunda/camunda-modeler/issues/1788


How to prevent default onClick over AccordionItem

Hello,
Thank very much for your work.
is it possible to prevent onClick over AccordionItem title so users can click on buttons inside it?
This means I will control the expanded state.
Thank you

One way currently is to pass a custom component as title prop, then add an onClick handler for buttons
function toggleButton(evt) {
  evt.stopPropagation() // prevent the onClick from reaching AccordionItem title
}

...

<AccordionItem
  title={
Some Text  <button onClick={toggleButton}>A button</button>
}
/>

I don't think you can currently prevent the outer onClick without capturing the event - that would be useful for managing the state outside of the component

Ok thank you. Got it.


Add ',' to invoke pekofy

Added ',' to invoke pekofy

thank you for your contribution, however by adding it as an invoker, i didn't mean a prefix, just a comma added as a punctuation mark in en_punctuation_list inside modules/pekofication.py

alright, it seems like we are good to go! thank you for your PR!

Than you for the good first issue!


Is there a way to access the other way of the relationship ?

I see there a function friends in the User model but is the other way around possible ?
I'm trying to make access to $friend->user ?

You can call $user->friends->first()->sender or $user->friends->first()->recipient to get the entities that are involved in the relationship.

No i'm try to access that throgh the view, and no i only have access to the friend model, i want the other way around

I don't get what you are trying, the Friend Model is just a connection between two Entities which you can each access through the morphed sender or receiver.

Yes I have access to the sender_id and receipient_id but the problem is that u have to make another access to the database to get the user associated to sender_id or the recepient_id

Just call Friend::find($whateverid)->sender and Friend::find($whateverid)-> recipient and you will get the models for sender_* and receipient_* fields.


Fix link for Luxury Dark

The header linked to a GitHub file viewer instead of raw.githubusercontent.com.

Thanks!


Lack of moderation

Not really a Github issue, but I'm reporting it here because I'd like to be sure that someone will read it.
The server is now full of players again (5-8 players), which has never happened the last 2 years. On one side it's a great thing, it brings life to a server that I thought was dead. But on the other hand some players are clearly going beyond the rules. The problem is that there doesn't seem to be anyone capable of moderating the server and it's gradually becoming anarchy.
Even more serious: @Cyberpangolin  and crabman77 got their accounts stolen, so the only moderator accounts are currently under the control of a malicious player.
@Darcidride Have you read my forum PM?

See what I just added to my first post about Cyber and Crabman's accounts
Otherwise it's mainly on the chat: in the last hours I saw many insults, swears, and even a racist sentiment
Once there was someone dating, too
There are some nice players on the server, but they are annoyed by this bad atmosphere.

It happens again, very annoying. 1 hour 40 minutes of constant insults (12:00-13:40 French time), and I can't do anything. For me who have been following this server for almost 4 years, this is really disappointing.
Olaari and Azagal report to be personally bullied by a group of player who followed them when they left Eurythmia 2 weeks ago, for no other obvious reason.
@Darcidride Sorry for highlighting you from everywhere, but something really need to be done quickly.
Also, Obani and I would be ready to take matters in hand and moderate this server to make it a decent place to play.

imo things aren't that bad. Players are playing, and yes that creates a lot of noise. If people can't afford having as much chat flood as on any "played" server, then you can locally mute them. Each sides are wrong in some ways.
All what I've seen is players playing and not liking each other. Insults are part of common attitude. That's my point.


Combining bitnum and fixed point operators.

To reduce duplication in the standard libraries, an idea is to combine all the operators for bitnum and fixed point. While this requires a bit more thought, we should be able to treat bitnum numbers as a special case, where the fractional width is zero.
This would also change to our interface to the more common WIDTH, FRAC_WIDTH.
Example
If we want a 32-bit unsigned adder for bitnums, it would be std_add(32, 0).
If we want a Q32.16 (16 integer bits, 16 fractional bits) unsigned adder for fixed points, it would be std_add(32, 16).
Changes Needed

A lot of refactoring - bitnum operators would need to include the fractional width. We could default this (?) to zero, but I'm not a fan of default values.
Change the Dahlia backend for Calyx, as well as the Python AST.
Update documentation (for standard library).
Update fud. In the verilator stage, when interpreting the values, we'll just assume its an integer if FRAC_WIDTH == 0.

Potential Pitfalls
Are there primitives that may cause unnecessary cycles for bitnum when trying to combine the two representations? Right now, I can't think of any. For some of the more complex operators, such as division, we just include more iterations in the long division process, which is entirely dependent on the number of FRAC_WIDTH. So, if FRAC_WIDTH == 0, then no extra iterations are included.

Discussed today: Just instantiate an instance of std_fp_* in the bitnum module std_* with FRAC_WIDTH set to zero. This ensures we can easily revert back to other modules without lots of refactoring.


python38Packages.plugwise: 0.13.1 -> 0.14.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.plugwise is: "Python module for Plugwise Smiles, Stretch and USB stick"
meta.homepage for python38Packages.plugwise is: "https://github.com/plugwise/python-plugwise"
meta.changelog for python38Packages.plugwise is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.14.1 with grep in /nix/store/93aa45xjh3ywnr8y3jzv9b3y2xrni94w-python3.8-plugwise-0.14.1

found 0.14.1 in filename of file in /nix/store/93aa45xjh3ywnr8y3jzv9b3y2xrni94w-python3.8-plugwise-0.14.1

directory tree listing: https://gist.github.com/522151adcdb2e179054b04cf65826788

du listing: https://gist.github.com/28cf3f02c170785447b0735a6e557c89

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
home-assistant
python38Packages.plugwise
python39Packages.plugwise

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/93aa45xjh3ywnr8y3jzv9b3y2xrni94w-python3.8-plugwise-0.14.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.plugwise https://github.com/r-ryantm/nixpkgs/archive/4762d8dc06f75b22fb92fd5e38fc2f66e752df49.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/93aa45xjh3ywnr8y3jzv9b3y2xrni94w-python3.8-plugwise-0.14.1
ls -la /nix/store/93aa45xjh3ywnr8y3jzv9b3y2xrni94w-python3.8-plugwise-0.14.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant

2 packages built:

python38Packages.plugwise
python39Packages.plugwise

Maintainer pings
cc @fabaff for testing.

0.14.5 already in master, see https://github.com/NixOS/nixpkgs/commit/6278ea9fefc17da8c0ab3a69b2c0506475984527


[DOCS] - Update the topic-level policies

Fixes #8899
Update the description of the newly added topic-level policies in https://github.com/apache/pulsar/issues/2688.

@Jennifer88huang Please help review. Thank you.

@Jennifer88huang Please help review. Thank you.

@sijia-w Thank you for your efforts.
Have you checked and added the new subcommands to the topics subcommand lists (from From L1769)?

@sijia-w I've added the subcommand list for topics in https://github.com/apache/pulsar/pull/9108

@sijia-w Thank you for your efforts.
Have you checked and added the new subcommands to the topics subcommand lists (from From L1769)?

@sijia-w I've added the subcommand list for topics in https://github.com/apache/pulsar/pull/9108

@freeznet @Jennifer88huang  Updated. Please take a look. Thank you.

@freeznet @Jennifer88huang  Updated. Please take a look. Thank you.

@sijia-w It's time to update the docs now since https://github.com/apache/pulsar/pull/9215 is merged. Thank you.

@sijia-w It's time to update the docs now since https://github.com/apache/pulsar/pull/9215 is merged. Thank you.


Need help with "Warning: getRouteProps could not find..."

I've got a problem only on development mode with the client-side navigation.
I can access localhost:3000/tom directly but i can't navigate from localhost:3000/john to localhost:3000/tom for example.
Any ideas ?
// static.config.js

export default {
  getSiteProps: () => ({}),
  getRoutes: async () => {
    return [
      {
        path: '/john',
        component: 'src/containers/Hi',
        getProps: async () => ({
          name: 'john'
        })
      },
      {
        path: '/tom',
        component: 'src/containers/Hi',
        getProps: async () => ({
          name: 'tom'
        })
      },
    ]
  },
}

// src/containers/Hi.js

import React from 'react'
import { getRouteProps } from 'react-static'

export default getRouteProps(({ name }) => (

Hi {name} !

))

Hi @DevSide! Could you show us your entry point file (src/index.js in the basic example) and the topmost component file (src/App.js in the the basic example) as well? It's hard to tell what is wrong without seeing those files.

// App.js

import React from 'react'
import { Router, Link } from 'react-static'
//
import Routes from 'react-static-routes'

import './app.css'

export default () => (
  <Router>

        <Link key="john" to="/john">john</Link>
        <Link key="tom" to="/tom">tom</Link>

        <Routes />

  </Router>
)

// index.js (untouched)

import React from 'react'
import ReactDOM from 'react-dom'
import { AppContainer } from 'react-hot-loader'

// Your top level component
import App from './App'

// Export your top level component as JSX (for static rendering)
export default App

// Render your app
if (typeof document !== 'undefined') {
  const renderMethod = module.hot ? ReactDOM.render : ReactDOM.hydrate
  const render = Comp => {
    renderMethod(
      <AppContainer>
        <Comp />
      </AppContainer>,
      document.getElementById('root'),
    )
  }

  // Render!
  render(App)

  // Hot Module Replacement
  if (module.hot) {
    module.hot.accept('./App', () => {
      render(require('./App').default)
    })
  }
}

Looks like because the prefetch is on componentWillMount and not on componentWillReceiveProps. I use the same container ?

Very interesting. I tried your example, and there is a bug. I created a identical component Hi2.js and used that for one of the routes and it worked. Great find!

Fixed with #255. Release is queued ;)


Add Protobuf support to the default DataConverter

Some of our customers use Protobuf generated structures as workflow and activity inputs and outputs.

+1 Wondering if anybody is actively looking into this. Given the prevalence of Protobuf types in Go APIs this seems like a fairly severe bug.

This can also reduce the size of the payload, which can reduce the load Cadence storage layer, and accommodate more workload with same size limit


Fix is not working for app started by tomcat

If Application is started by docker root user, then app is patched successfully but when application is started by tomcat user inside docker, then the patch is not working.
Will you be able to provide a fix for that?
The closest solution is https://stackoverflow.com/a/13974371.

@falgofrancis Thanks for bringing this to our attention. I am investigating whether we have a fix for this.

@jicowan We were able to set up a "work around" solution for this. We added service to multi-user.target.wants and make it work. Hence closing the issue.

The RPM is supposed to address this. When it enables the hotpatch.service it will create the symlink multi-user.target.wants.
Unit file configuration:
[Install]
WantedBy=multi-user.target


Replace ansicolors with lua-term

Since lua-term is already used and has a submodule equivalent to ansicolors,
use lua-term for color handling. Removed ansicolors dependency from rockspec.

Less dependencies \o/
:+1:

I'm sorry, apparently lua-term doesn't disable coloring on windows like ansicolors. I'll send a PR with a fix.


change ESMetadata field names

This is for #603
THIS PR WILL REQUIRE REINDEXING METADATA = CREATE A NEW DATASET AND METADATA FOR FASTEST TESTING, old resources that have existing content in Elasticsearch will be unaffected b/c this changes how metadata is indexed.
Before, Metadata would include name, description fields that are mirrored from Files, Datasets. These were used to build the tile components to display search results. This modifies the Metadata ES object to change those fields to things like "ds_description", "resource_name" so searching for a name of a file or dataset wont return the metadata in addition to the actual resource.
This also means that the current search interface is searching the metadata index for basically no reason (it isn't looking through md content at the moment - i tried that but ran into some issues) so the search interface still isn't perfect, but at least we dont have the duplicates problem as-is.
Further adjustments will bump into the question of whether we want to continue using Reactivesearch, or implement our own. Something like lucene search would be nice for metadata but currently our permissions checks don't work on lucene search box they have implemented.

With advanced search, I see datasets by name and from metadata entries, started with new db so didn't need to re-index.
And I don't see results if I don't have permission for a particular user.
Is there anything else that needs to be tested? That seems like everything.

what's the proper way to drop indexes? I delete the whole volume but still see below behavior

when turn on lucene i see double results
I can't search any metadata (file and dataset names works fine). I'm also missing the creator dropdowns


Pr 14893

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
ng-view directives inside async loaded templates do not display the correct view if the location change occurred before $route was instantiated.
What is the new behavior (if this is a feature change)?
Now we track all location changes before $route is instantiated, which are then used to initialize the current route.
Does this PR introduce a breaking change?
No (I don't think)
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Other information:

This actually creates more potential problems than it creates and #14893 is simpler.


⚠ Beamable Stats (Object) has degraded performance

In 978da31, Beamable Stats (Object) (https://api.beamable.com/object/stats/platform/docs) experienced degraded performance:

HTTP code: 504
Response time: 10018 ms

Resolved: Beamable Stats (Object) performance has improved in 632fb8f after 12 minutes.


net/procfs: Support to show MTU in netdev statistics

Summary
Support to show MTU in netdev statistics
Impact
N/A
Testing
Usage:
ifconfig (interfacename)
example:
ifconfig eth0
eth0	Link encap:Ethernet HWaddr 42:d3:59:ad:5a:2f at RUNNING mtu 1500
inet addr:<IP_ADDRESS> DRaddr:<IP_ADDRESS> Mask:<IP_ADDRESS>
inet6 addr: fe80::40d3:59ff:fead:5a2f/64
inet6 DRaddr: ::/64

@wangchen61698
I noticed that the gs2200m driver with usrsock can not obtain MTU info from the Wi-Fi chip.
So I think that showing MTU info should be selectable.

what' value will show in ifconfig.

what' value will show in ifconfig?

nsh> ifconfig
wlan0	Link encap:Ethernet HWaddr 3c:95:09:00:89:96 at UP mtu 576
	inet addr:<IP_ADDRESS> DRaddr:<IP_ADDRESS> Mask:<IP_ADDRESS>

Perhaps, the value was calculated from
#
# Driver buffer configuration
#
CONFIG_NET_ETH_PKTSIZE=590
CONFIG_NET_GUARDSIZE=2
CONFIG_NET_LL_GUARDSIZE=14
CONFIG_NET_RECV_BUFSIZE=0

@wangchen61698 I noticed that the gs2200m driver with usrsock can not obtain MTU info from the Wi-Fi chip. So I think that showing MTU info should be selectable.

WiFi has the standard MTU definition, why not return the value in gs2200m driver directly if the chip can't return mtd info directly?

@wangchen61698 I noticed that the gs2200m driver with usrsock can not obtain MTU info from the Wi-Fi chip. So I think that showing MTU info should be selectable.

@masayuki2009 Hi, it seems that the gs2200m driver doesn't do the step obtain MTU info from the Wi-Fi chip and change dev->d_pktsize, so dev->d_pktsize would be default value (CONFIG_NET_ETH_PKTSIZE). But I don't have the device so if there is a mistake please point out to me, thanks :-)
I mean, the net stack will default think its MTU is CONFIG_NET_ETH_PKTSIZE - ETH_HDRLEN and cannot send packet longer than this value, so it will be the 'actual' MTU that takes effect for packet send.
Overall, I suggest to set the value of CONFIG_NET_ETH_PKTSIZE to correct value (MTU + L2 header len), which is the main effect of this config (Refer to its description below, To get an MTU of 1500, for example, you would need packet buffer of size 1514). And the MTU info in ifconfig would faithfully show the value that takes effect.
https://github.com/apache/nuttx/blob/c87da0d11521653f1f38c3340dd542bd53e36016/net/Kconfig#L58-L80


Decide how to publish non-trajectory information

Decide how to publish additional info to ROS side, tool state, digital I/O, robot mode, safety mode, and tcp pose. Do we create controllers or to spin another thread to publish this stuff

Here I am more fan of multiple controller creation which would be based on controller_interface.
This approach only tends to make a huge list of state and command controllers like:

TcpPoseStateController
IOStateController
IOController
RobotModeStateController
SafetyModeStateController
SpeedSliderController
ToolStateController
ExternalUrScriptController
ResetMotionController
...
These controllers would interface with driver via one of these state or command or sensor.

Other option is to hold onto ROS1 approach and spin multiple threads and callbacks within hardware interface to register topics.

Here I am more fan of multiple controller creation which would be based on controller_interface.
This approach only tends to make a huge list of state and command controllers like:

TcpPoseStateController
IOStateController
IOController
RobotModeStateController
SafetyModeStateController
SpeedSliderController
ToolStateController
ExternalUrScriptController
ResetMotionController
...
These controllers would interface with driver via one of these state or command or sensor.

Other option is to hold onto ROS1 approach and spin multiple threads and callbacks within hardware interface to register topics.

^that's my understanding from ros2_control meetings, as well

^that's my understanding from ros2_control meetings, as well

I would say "officially", drivers should always have used the *Controller approach to publish additional information. Even in ros_control (ie: the ROS 1 version).
It's just that it was so easy to do it with realtime publishers from the hardware_interface itself, no one really bothered.
ps: I really don't like to use the Controller suffix for something which doesn't actually control anything. I believe we don't have to any more in ros2_control, so it would be great if we could avoid it. It leads to many questions ("ah, so the joint_state_controller let's me execute motions?", well, no ..).

I would say "officially", drivers should always have used the *Controller approach to publish additional information. Even in ros_control (ie: the ROS 1 version).
It's just that it was so easy to do it with realtime publishers from the hardware_interface itself, no one really bothered.
ps: I really don't like to use the Controller suffix for something which doesn't actually control anything. I believe we don't have to any more in ros2_control, so it would be great if we could avoid it. It leads to many questions ("ah, so the joint_state_controller let's me execute motions?", well, no ..).

https://github.com/ros-controls/ros2_control/issues/318

ps: I really don't like to use the Controller suffix for something which doesn't actually control anything. I believe we don't have to any more in ros2_control, so it would be great if we could avoid it. It leads to many questions ("ah, so the joint_state_controller let's me execute motions?", well, no ..).

Unfortunately, we still have it... I agree fully with you....
@livanov93

This approach only tends to make a huge list of state and command controllers like:

I think we can solve this issue by creating a few general controllers/publishers. Basically, we need only GPIOController and an extension of the joint_state_controller which enables the definition of states one wants to have published.
I think this is the most general approach and could make many people happy :)

Mid-term improvements on the ros2_control side as discussed today in the meeting:

ros-controls/roadmap#38
ros-controls/roadmap#39
ros-controls/ros2_controllers#150


Add commit comment functionality

The GitLab WebUI allows users to comment directly on commits.  These comments
appear both in the comment view and the MR view.  This functionality can be
implemented via the lab.Commits.PostCommitComment() function, however, the
function only supports comments on "new" lines of code.  After discussions
with GitLab they have suggested using lab.Discussions.CreateCommitDiscussion()
as a workaround [1].  This solution has a minor issue in that it will not work
with commits that have multiple parents

Implement the ability for users to comment directly on commits.

[1] https://gitlab.com/gitlab-org/gitlab/-/issues/335337#note_643291819

@bmeneguele @zampierilucas  Ready for review.  Had some test failures to fix, and an interesting code panic that testing caught.

I have chosen to keep the "|" instead of ">" suggested by @bmeneguele . As I discovered, the ">" can be used when you are quoting text in Markdown.

:disappointed: .... that's fine though.
Will review it tomorrow. But thanks for getting it done Prarit :)

@bmeneguele any chance of a review?

Oh yes. Will review it tomorrow. :)

@prarit you mentioned you did solved the question, but they weren't pushed yet, right?
Also, don't forget to drop the 'draft' state of the PR :)

@prarit you mentioned you did solved the question, but they weren't pushed yet, right?
Also, don't forget to drop the 'draft' state of the PR :)

I pushed last night?  At least it shows up in my tree as being pushed:
[prarit@prarit ~]$ cd git-kernel/github/lab/
[prarit@prarit lab]$ git where
commit_work2
[prarit@prarit lab]$ git push -f prarit commit_work2
Everything up-to-date
[prarit@prarit lab]$

and AFAICT the new code is present in the MR:

--- a/internal/gitlab/gitlab.go
+++ b/internal/gitlab/gitlab.go
@@ -1799,7 +1799,9 @@ func GetCommitDiff(project string, sha string) ([]*gitlab.Diff, error) {
        for {
                ds, resp, err := lab.Commits.GetCommitDiff(p.ID, sha, opt)
                if err != nil {
-                       fmt.Println(err)
+                       if resp.StatusCode == 404 {
+                               log.Fatalf("Cannot find diff for commit %s.  Verify the commit ID or add more characters to the commit ID.", sha)
+                       }
                        return nil, err
                }

@prarit you mentioned you did solved the question, but they weren't pushed yet, right?
Also, don't forget to drop the 'draft' state of the PR :)

I pushed last night? At least it shows up in my tree as being pushed:
[prarit@prarit ~]$ cd git-kernel/github/lab/
[prarit@prarit lab]$ git where
commit_work2
[prarit@prarit lab]$ git push -f prarit commit_work2
Everything up-to-date
[prarit@prarit lab]$

and AFAICT the new code is present in the MR:

--- a/internal/gitlab/gitlab.go
+++ b/internal/gitlab/gitlab.go
@@ -1799,7 +1799,9 @@ func GetCommitDiff(project string, sha string) ([]*gitlab.Diff, error) {
        for {
                ds, resp, err := lab.Commits.GetCommitDiff(p.ID, sha, opt)
                if err != nil {
-                       fmt.Println(err)
+                       if resp.StatusCode == 404 {
+                               log.Fatalf("Cannot find diff for commit %s.  Verify the commit ID or add more characters to the commit ID.", sha)
+                       }
                        return nil, err
                }

Yeah, sorry. Had to refresh the browser tab :facepalm:


webdriver-manager ignores NO_PROXY

Bug report

Node Version: 4.2.4
Protractor Version: 3.2.0
Operating System and Version Windows 10 x64
Configured environment variables:

HTTP_PROXY
HTTPS_PROXY
NO_PROXY

We have put ChromeDriver and Selenium jar files on a local server in our enterprise and we've used the --alternate_cdn argument to specify where webdriver-manager should go grab the files

Steps to reproduce the bug

Execute webdriver-manager update --alternate_cdn=...
Expected behavior: successful download of selenium-server-standalone--xxx.jar, chrome driver zip, etc.
Result:
401 errors because webdriver-manager issues requests against our corporate proxy instead of going directly to the alternate_cdn.
The issue lies in the resolveProxy function which should check if the NO_PROXY environment variable is defined and if the provided fileUrl does not match against the one of the NO_PROXY values.
For example, assuming that I have the following value for NO_PROXY, then the resolveProxy function should probably return null (assuming that the request library supports that): `NO_PROXY='localhost,<IP_ADDRESS>,.local'

When setting the alternative_cdn option, the fileUrl passed into the resolveProxy method is the alternative cdn host with the path to download the file. So digging into this method with the proxy option:

it would return proxy value set on the command line
if the proxy option was not used, it would defer to an environment variable set
if no environment variable is set, it should return undefined

It could be that your proxy server does not know how to route to your endpoint. I would make a curl call to your sever to make sure it is reachable.
This request and #3035 are requests to change webdriver-manager that appear very specific around your corporate proxy. What you could do instead, is just run selenium standalone server. The webdriver-manager is only a simple download and start node application and could easily be replaced with a script:
download from your file server:
wget http://somefile

run the selenium server:
java -jar <selenium-server.jar> -port 4444 -Dwebdriver.chrome.driver=<chromedriver.exe> -Dwebdriver.ie.driver=<iedriver.exe>

Hi @cnishina,
Indeed this is specific to our proxy configuration. Basically it can only be used when going towards the Web. In this case, the server is on our internal network so the NO_PROXY environment variable is important to respect.
As you mention, we could probably work around this issue with a script, but it's probably as easy to add support for NO_PROXY in webdriver-manager :)
I'll try to submit a PR


"e^sqrt(x) = sum_(k=0)^∞ (2 k x^(-1/2 + k) + x^k)/((2 k)!)" not working

look into this and figure it out

alternatively https://www.wolframalpha.com/input/?i=taylor+series+exp(sqrt(x))
ensure to delete the ending "(Puiseux series)"


support changing problem severity

atm the problem is rendered as info, but maybe we can make it more flexible to use any of the other types error, warning, etc...

Good point, should be quite easy to implement as well.


Connecting a DontCare to a DataView Produces Illegal FIRRTL

Consider the following:
import chisel3._
import chisel3.experimental.dataview._

class Foo extends Bundle {
  val foo = UInt(8.W)
}
class Bar extends Foo {
  val bar = UInt(8.W)
}
class MyModule extends Module {
  val foo = IO(Input(new Foo))
  val bar = IO(Output(new Bar))
  bar.viewAsSupertype(new Foo) := DontCare // bar.foo := foo.foo
  bar.bar := 123.U           // all fields need to be connected
}

This produces the following FIRRTL IR which is illegal:
circuit MyModule :
  module MyModule :
    input clock : Clock
    input reset : UInt<1>
    input foo : { foo : UInt<8>}
    output bar : { foo : UInt<8>, bar : UInt<8>}

    view.foo is invalid @[main.scala 15:32]
    bar.bar <= UInt<7>("h7b") @[main.scala 16:11]

Specifically view is never declared. 😬
A scastie snippet of the above is here: https://scastie.scala-lang.org/seldridge/WcJpoy9RTEOTLGQGGjUbiA/10
This can be worked around with a WireInit(new Foo, DontCare).  However, it is surprising that the user needs to do this.
h/t @terpstra for reporting this.

Glad this is being fixed. Posting so I get notified of progress. :)

@seldridge can you clarify the workaround (perhaps with another scastie)?

You can more easily work around this by just using <> (https://scastie.scala-lang.org/ypfeMJGnQ4iVOz3YcAO58w).
Fix coming.


Dataloader.get/4 returns nil for empty list

Dataloader struct
%Dataloader{
  options: [],
  sources: %{
    RedOcean.Entities => %Dataloader.Ecto{
      batches: %{},
      default_params: %{},
      options: [],
      query: #Function<0.78108663/2 in RedOcean.Entities.data/1>,
      repo: RedOcean.Repo,
      repo_opts: [],
      results: %{
        {:assoc, RedOcean.Entities.Instance, #PID<0.622.0>, :entity_facts,
         RedOcean.Entities.Fact,
         %{dataset: "public"}} => %{
          ["03954047-7a76-46a1-a31a-53a6f3039f4f"] => []
        }
      }
    },
  }
}

Current Behaviour
Dataloader.get(
  loader,
  RedOcean.Entities,
  :entity_facts,
  %RedOcean.Entities.Instance{id: "03954047-7a76-46a1-a31a-53a6f3039f4f"}
) # => nil

Expected
I'd expect an empty array to be passed.
note
I did scrub out some irrelevant assocs on the dataloader struct.

I misunderstood the api. Need to call get/4 with the same params as load/4. This includes if you use {key, args} as the batch key (a nice effect).


LumaCode PCB Design

Hi,
I was think it would be neat if a new PCB existed to support LumaCode.
Saw the KiCad files are not uploaded, so thought i will create the next best thing.
Was thinking something like this, sorry about my poor paint skills.

PPUdigitizer for LumaCode does not yet support NTSC, but will in the future.
Any ideas about that?
I happy to help if you need it.
Thanks,
-Linus Nibell

Linus,
That you for your comment and I wanted to let you know that we have been working on something just like this.  :)
The Duo Mono Audio output has always been sort of a gimmick as you can simply just get a RCA splitter to use on the Red Audio Port and get the exact same results as what we are doing on the current board.
I have been wanting to move the Yellow port back to the original position for a long time now, especially for how awkward it looks to have the RCA cable jacks so far separeated when plugging it in.
We just did not have a use for that old RF output port but when I watched the video on Luma Code, which is pretty awesome!!, I had the exact same thought that you did.  :)
It is super easy just to add a large pad that folks can solder any type of external video on, like lumacode, and have it output what they desire.
My plan was to have this implemented on the Classic RCA editions for release 3.2 and hopefully it will be ready in a week or so.
Thanks,
-Merlin Shaw

No problem Merlin,
Saw it this week also, i will gladly test any prototype board. Don't have the PPUdigitizer yet, waiting on it to ship.
Live in Sweden so have access to pal consoles, they are pretty cheap here so just pm me and i can send you one 😄

If you can reach out to my email.  merlin dot shaw at google then we I can list you as a tester and get you some prototypes.  :)


Upgrade PeerDependencies Version for Hardhat

Hardhat now has released the version 2.22. But peerDependencies are still >=2.16 <2.21.0, please support new version.

Hardhat 2.21 and introduces EDR and this plugin currently does not work with it out of the box yet hence the peer dependency constraint was recently added.
Regarding upgrading this plugin to support EDR, is an issue regarding it https://github.com/NomicFoundation/edr/issues/299. For reference, here is a WIP branch however it still missing features and is not ready to be published at this stage https://github.com/zemse/hardhat-tracer/tree/v3
I am trying to support EDR asap.

Thank you sir. The trace plugin you developed has tremendous significance for contract developers.

I reopen this issue to wait for v3 publish.
When support hardhat EDR, you could close this.

Just published<EMAIL_ADDRESS>based on the hardhat EDR. Note that this needs hardhat >= 2.22.5.

I have tried and it works smoothly, so I close this issue. Thank you for your work!


Fix reconciliation of openshift controller manager service ca manifest

Fixes a bug introduced with the refactoring of the openshift controller manager where the service CA for the openshift controller manager is not getting reconciled

/test e2e-aws

/lgtm


OpenSearchCon NA 2024 Recap Blog

Describe the blog post your would like to write
Blog will recap OpenSearchCon North America and discuss some of the sessions, happenings, and provide links to relevant resources that can be leveraged by the community should they have missed the event - or if they want to revisit conent.
What is the title of the blog post?
OpenSearchCon NA Recap Blog
Who are the authors?
Laysa Uchoa & Yulia Barabash
What is the proposed posting date?
10/18/24

Looking forward to see what you put together Yuliia & @laysauchoa 😃

Hi, can you give me please permissions to create a branch and push commits. because it shows that I do not have an access)

Here is the post: https://github.com/opensearch-project/project-website/pull/3425


Closes #2458 Updated cheatsheet in line with 1.1 and 1.2 changes

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63 @bundfussr to aid your review, you can see the updates I made in the #2458 checklist.

Sorry, my bad, I also just now noticed there were some partial updates already here...!

Thanks @bundfussr for the review. I've addressed all of the above except:

Should we add derive_vars_cat() to "Special Variable-Adding Functions"?
because there is simply not enough space, so would rather keep under generic.

Should we close this and re-submit? https://github.com/rstudio/cheatsheets/pull/555

I think better would be: merge this one, close #2479, and update the this so with the new cheatsheets. I think we should not wait for RStudio.

I have updated https://github.com/rstudio/cheatsheets/pull/555 to the latest version of the cheatsheet.

@manciniedoardo , I did a small update for derive_vars_crit_flag() see https://github.com/pharmaverse/admiral/pull/2616

Thanks @bundfussr


Update dcos-test-utils

Refs:

https://github.com/mesosphere/dcos-enterprise/pull/6695
https://github.com/dcos/dcos/pull/6343
https://github.com/dcos/dcos-test-utils/pull/101


Remove duplicate scenario1.json

Send
email
@.***
=May%20I%20list%20you%20as%20a%20professional%20reference?&body=Hi%20there!%0A%0AI%20was%20wondering%20if%20you%27d%20be%20willing%20to%20write%20a%20professional%20reference%20for%20my%20ZipRecruiter%20profile.%20It%20should%20take%20no%20more%20than%20a%20few%20minutes%20and%20it%27ll%20definitely%20help%20me%20in%20my%20ongoing%20job%20search.%20Here%27s%20a%20link%20to%20complete%20the%20reference%3A%20https%3A%2F%
2Fwww.ziprecruiter.com
%2Fsubmit-reference%2Fd07c8d1a%2Fv1%3AU2FsdGVkX1_7OWXqgp_6FNqFX4EaKE1TctQ3_H39XX0UBys1s_LPqCV0p-Z5z3C7yg9h1GudQgQ%0A%0AThanks%20so%20much!%0A%0ANoble%20Chukwukere
On Tue, Apr 11, 2023 at 12:01 AM Noble Chukwukere @.***>
wrote:

mailto:
?subject=May%20I%20list%20you%20as%20a%20professional%20reference?&body=Hi%20there!%0A%0AI%20was%20wondering%20if%20you%27d%20be%20willing%20to%20write%20a%20professional%20reference%20for%20my%20ZipRecruiter%20profile.%20It%20should%20take%20no%20more%20than%20a%20few%20minutes%20and%20it%27ll%20definitely%20help%20me%20in%20my%20ongoing%20job%20search.%20Here%27s%20a%20link%20to%20complete%20the%20reference%3A%20https%3A%2F%
2Fwww.ziprecruiter.com
%2Fsubmit-reference%2Fd07c8d1a%2Fv1%3AU2FsdGVkX1_7OWXqgp_6FNqFX4EaKE1TctQ3_H39XX0UBys1s_LPqCV0p-Z5z3C7yg9h1GudQgQ%0A%0AThanks%20so%20much!%0A%0ANoble%20Chukwukere
On Mon, Apr 10, 2023 at 9:38 PM Noble Osinachi @.***>
wrote:

Merged #2 https://github.com/NobleOsinachi/learning-solidity/pull/2
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/NobleOsinachi/learning-solidity/pull/2#event-8966962092,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANRS6AG7WJ4E7UXTO4WRGMDXARVTXANCNFSM6AAAAAAWZMS2JA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
.com>

@.***
?subject=May%20I%20list%20you%20as%20a%20professional%20reference?&body=Hi%20there!%0A%0AI%20was%20wondering%20if%20you%27d%20be%20willing%20to%20write%20a%20professional%20reference%20for%20my%20ZipRecruiter%20profile.%20It%20should%20take%20no%20more%20than%20a%20few%20minutes%20and%20it%27ll%20definitely%20help%20me%20in%20my%20ongoing%20job%20search.%20Here%27s%20a%20link%20to%20complete%20the%20reference%3A%20https%3A%2F%
2Fwww.ziprecruiter.com
%2Fsubmit-reference%2Fd07c8d1a%2Fv1%3AU2FsdGVkX1_7OWXqgp_6FNqFX4EaKE1TctQ3_H39XX0UBys1s_LPqCV0p-Z5z3C7yg9h1GudQgQ%0A%0AThanks%20so%20much!%0A%0ANoble%20Chukwukere

Message ID: <NobleOsinachi/learning-solidity/pull/2/issue_event/8966962092

@github.com>


GitHub Pages Demo Site

Now that the library needs a build step, I may have to make a separate example page that's different from the test pages. At least now I can reference the latest builds from npm! That's a great bonus that will really help out!
Not sure if anyone's reading this, but does anyone know if you can associate TypeScript types for a CDN URL? I think I almost got it working by using declare module on the URL, and referencing the exports from an npm install of the library itself. Seems like a nice solution, but maybe there's a simpler one I don't know about yet.

I don't think this specifically is quite as much of a goal now, since there are usable demos out there now, like Dovetail and img2mcstructure for example. If anything, I'd want to point to those, and to write more documentation examples, rather than a demo specific to this repo.
In regards to the part about getting type-checking for the CDN import of NBTify, yes this is what it looks like to get it working:
// nbtify.d.ts

declare module<EMAIL_ADDRESS>{
  export * from "nbtify";
}

So it does involve you in needing to install it with npm, specifically with type-checking in mind. I was looking into automatic type detection, but I wasn't able to get it working, or at least I couldn't figure out how to get it working.


Make localization test hermetic

'cause there's no reason to load the whole composite for these.

Is this meant to be (deletion of the beta ones and new stable ones):

Update: I see the update action failed, rerunning....
Is this meant to be (deletion of the beta ones and new stable ones):

The deleted files are .../live/... and the added ones are .../hermetic/...
I've been trying to manually delete the old snapshots as I move tests around, but I suspect that some will be left behind to be cleaned up later because there are so many conflicting PRs in flight.
The fact that there are only hermetic snapshots for one build flavor is just because our snapshot update automation is terrible at the moment -- we kick off three of them and one of them wins... forcing the other two to restart. And each of these takes hours...


fix typo error

Just a small typo error.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your guidance!


Run unit tests

What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Unfortunately we skipped all unit tests within the CI which also makes it impossible to collect the code coverage. This is now fixers.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #674 (d9bd46a) into main (59c4845) will increase coverage by 20.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            main     #674       +/-   ##
==========================================
+ Coverage   6.89%   27.72%   +20.82%
==========================================
  Files          2       12       +10
  Lines         29      873      +844
  Branches      17      324      +307
==========================================
+ Hits           2      242      +240
- Misses        27      441      +414
- Partials       0      190      +190