Build Error

│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Timed out waiting for deployment/gitea-operator-controller-manager in
│ openshift-operators to start
│ Error from server (NotFound): deployments.apps
│ "gitea-operator-controller-manager" not found

Stuck on Destroy


Include a warning in regards using WSL with Windows 10 1803 build

Add a warning at WSL usage in regards to Windows 10 1803 build having issues with CMake.

Codecov Report

Merging #10501 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10501      +/-   ##
==========================================
+ Coverage   53.18%   53.33%   +0.15%
==========================================
  Files         210      210
  Lines       25816    25816
  Branches     5682     5682
==========================================
+ Hits        13729    13770      +41
+ Misses       9780     9733      -47
- Partials     2307     2313       +6

Impacted Files
Coverage Δ

lib/posix/pthread_sched.c
41.66% <0%> (-20.84%)
:arrow_down:

lib/posix/pthread_mutex.c
77.77% <0%> (+1.38%)
:arrow_up:

lib/posix/pthread.c
80.36% <0%> (+12.32%)
:arrow_up:

lib/posix/pthread_cond.c
83.33% <0%> (+20.83%)
:arrow_up:

include/posix/posix_sched.h
100% <0%> (+100%)
:arrow_up:

lib/posix/pthread_barrier.c
100% <0%> (+100%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518ec09...520c03b. Read the comment docs.

Looks like the new GitHub "suggest" comment feature creates a separate commit for each suggestion accepted, and these need to be squashed to work properly within our project workflow (these kind of commits don't have a signed-off).  Sigh.

@Ralms can you please rebase and fix the commit message?

@Ralms sorry for the delay, I missed this message.


🐛 [Auth] authStateChanges() stream fires once too often upon attaching

Bug report
Upon attaching a listener to authStateChanges() it should fire immediately with the current state, and then after that whenever the state changes. When I attach a listener, it fires twice with the same state.
Steps to reproduce
Attach a listener to the authStateChanges() stream:
FirebaseAuth.instance.authStateChanges().listen((user) {
  print('Auth state changed to '+(user!=null?user.uid:'<null>'));
}

When you run this (and a user is signed in), you'll notice it fires/prints twice.

Now open the underlying iOS app in Xcode and add this code in AppDelegat.didFinishLaunchingWithOptions:
Auth.auth().addStateDidChangeListener { (auth, user) in
    print("Swift addStateDidChangeListener")
    print(user != nil ? user!.uid : "<null>")
}

When you now run the app again, you'll notice that the Swift code only logs once, but the Flutter code logs twice.
Additional context
I think the problem is most likely caused by this streamController.add(currentUser); in: https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_auth/firebase_auth/lib/src/firebase_auth.dart#L224-L242, as the underlying Platform SDK already does precisely that when a listener is attached. So since FlutterFire passes the listener on to the platform SDK, it doesn't have to repeat firing the initial state.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.22.0, on Mac OS X 10.15.5 19F101, locale en)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.50.1)
[✓] Connected device (3 available)

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.10.0
Flutter SDK 1.22.0
hands 1.0.0+1

dependencies:
- cupertino_icons 1.0.0
- firebase_auth 0.18.1+2 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_database 4.1.1 [flutter firebase_core]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- google_sign_in 4.5.5 [google_sign_in_platform_interface flutter meta google_sign_in_web]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0-nullsafety.1 [collection]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- clock 1.1.0-nullsafety.1
- collection 1.15.0-nullsafety.3
- fake_async 1.2.0-nullsafety.1 [clock collection]
- firebase 7.3.2 [http http_parser js]
- firebase_auth_platform_interface 2.1.1 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.1+1 [flutter flutter_web_plugins firebase meta http_parser intl firebase_core firebase_auth_platform_interface js]
- firebase_core 0.5.0+1 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_core_platform_interface 2.0.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.0 [firebase firebase_core_platform_interface flutter flutter_web_plugins meta js]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.2 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- http 0.12.2 [http_parser path pedantic]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- intl 0.16.1 [path]
- js 0.6.2
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- path 1.8.0-nullsafety.1
- pedantic 1.9.2 [meta]
- plugin_platform_interface 1.0.3 [meta]
- quiver 2.1.3 [matcher meta]
- sky_engine 0.0.99
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0-nullsafety.3 [collection]
- vector_math 2.1.0-nullsafety.3

Hey @puf
From memory, the reason why we added the streamController.add(currentUser); line was because the native listener is always listening, whether or not the user has. When the user subscribes, we essentially forwarded on the native events to any attached listener. The first time around it seems the client fires, and then native. After that, I believe it would only be the client (to mimic expected functionality).
I'll see what we can do to improve this.

Thanks for clarifying @Ehesp . I assumed you must have had a good reason to add this code, as the comment above indicated a clear intent. Why is the native listener always listening? Wouldn't it be easier to attach a native listener for each listener that is attached to the stream/each time the stream is requested?

Wouldn't it be easier to attach a native listener for each listener that is attached to the stream/each time the stream is requested?

Gets a little harder I think as we'd would need to track these 'pairings' of Stream to native listeners in Dart & native with some kind of identifier so native events are forwarded to correct stream instances (as these would channel through a single native <-> dart vm event channel anyway). The cleaning up/tracking of this also gets a little messy with multiple Firebase apps and things like hot reload/restart in Dart (which native then needs to be made aware of when it happens to remove listeners).
Still doable but a lot more involved I think versus a singleton auth listener per Firebase app. Unless I'm over complicating it 😅
I wonder if we could just internally on Dart discard (still handle it for the internals management of user state in Dart, but just not forward it on to the users stream) the first native event that comes through the method channel? Not sure if that would work and also thinking we may have issues with hot reload/restart as well doing it that way so maybe that needs to happen on native instead.

Thanks for explaining Mike. While dropping the initial event will solve the case I flagged here, I'm still afraid that we're replicating business logic in the library.
How about having a  FlutterFire wrapper for each listener, and then leaving it to the application code to manage that listener/wrapper (same as the native SDKs do)? So that way there's a 1:1 relationship between a flutter listener and its underlying native listener. Would the library then still need to track all pairings?

Would the library then still need to track all pairings?

I think we still may have to for hot reloading/hot restarting or maybe do a blanket remove all - not 100% sure, would need to spend some time looking into it
I'm gonna ship the initial fix to stop the events sending twice and then I'm going to look into this further in the next few weeks and see if I can get it working ok with a 1:1 relationship as suggested

Thanks Mike!
On Tue, Nov 24, 2020 at 12:18 PM Mike Diarmid<EMAIL_ADDRESS>wrote:

Reopened #4049
https://github.com/FirebaseExtended/flutterfire/issues/4049.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FirebaseExtended/flutterfire/issues/4049#event-4034649769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG7BXYJ3UTAGK6YMRAH5ODSRQIILANCNFSM4TMAUBPQ
.

https://github.com/FirebaseExtended/flutterfire/pull/4099 fixed this on Android, macOS and iOS. Web still fires once too often.

you dumb?
i already opened this issue before #3591

I want to point out that I already opened this issue before (#3591).
It might be helpful - I am a bit surprised that my issue was not linked with any of the fixes since it had a few upvotes.

Will the #4099 fix also solve the issue for the .userChanges() stream?

Will the #4099 fix also solve the issue for the .userChanges() stream?

Also I believe the FlutterFire documentation needs updating?
"Once called, the stream provides an immediate event of the user's current authentication state, and then provides subsequent events whenever the authentication state changes."

Also I believe the FlutterFire documentation needs updating?
"Once called, the stream provides an immediate event of the user's current authentication state, and then provides subsequent events whenever the authentication state changes."

That behavior should remain unchanged. Can you show the code and output that shows a mismatch with that documentation?

That behavior should remain unchanged. Can you show the code and output that shows a mismatch with that documentation?

Doesn't #4099 prevent the initial ' immediate event of the user's current authentication state' from being sent?

Doesn't #4099 prevent the initial ' immediate event of the user's current authentication state' from being sent?

This has now been fixed via https://github.com/FirebaseExtended/flutterfire/pull/5766 - The PR aligns both native and web to have the same behaviour.


Fixed LUSERS count not subtracting invisible users

LUSERS was not subtracting invisible users from the total user count. Fixed to stay in line with how other ircds do.

if onlineusers.flags[modes.Invisible] {

if onlineusers.flags[modes.Operator] {

um, those look dodgy and like LUSERS could create some bad races.
Thanks for the PR, I'm gonna note the above in a separate issue.


custom hit-/killsounds dont work

I put them into \csgo\sound directory, but when I type in their names ingame they do not play (I made sure theyre in .wav format aswell)
Am I missing something / is it broken rn ?

Nothing is broken. I have this problem too when i'm using my own .wav files. But when i tried xpossed-you sound pack #1463 it worked perfectly.

Nothing is broken. I have this problem too when i'm using my own .wav files. But when i tried xpossed-you sound pack #1463 it worked perfectly.

hey my boii


Support for different persistent homology backends

As stated in the roadmap, currently, guddhi and giotto-ph are used for various purposes. We want to be able to allow the user to specify which backend to use, and also provide sane defaults if the user does not care/has no preference.

I think this is a great idea and would leave this as a potential enhancement. However, I currently do not see what the advantages of choosing between the two backends would be. Issue #7 discusses a specific backend for GPUs, which, if implemented, would indeed prove advantageous to users.


Add guide to maintaining a quality crate.

Per https://github.com/rust-lang/crates.io/issues/249, I have started work on a guide to maintaining a quality crate. Right now it's in the brainstorming phase, and I will soon start contacting crate maintainers to solicit input.
The current work-in-progress document may be found here: https://github.com/AndrewBrinker/crate-guide
The goal is to have a document of best practices that people can be pointed to, and that can codify certain community practices for crate creation and maintenance based on input and ideas from the Rust community.
cc @steveklabnik

You might be interested in https://pascalhertleif.de/artikel/good-practices-for-writing-rust-libraries/ :smile:

Thanks! Those are some fantastic ideas.


Tracing on 3D view

Being able to trace on the 3D view side to make smoothing out nuclei shape easier when finished with initial tracing sweep on 2D side

Implemented basic 3D editing features. Will open new issue for additional work (highlighting, etc.)


⚠ Bofrost.at has degraded performance

In 9a9bcf7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1542 ms

Resolved: Bofrost.at performance has improved in 9940c80 after 6 minutes.


Thaumcraft biomes using RWG

Minecraft version:
1.7.10
Unabridged or Abridged version:
Release 15
Issue Description:
No thaumcraft biomes spawning while using Real World Generator to generate the world.
Steps to Reproduce:
Set world seed as RWG. Set thaumcraft biome generation settings to whatever. Create a new world.
Crash report or log (uploaded to gist.github.com or pastebin.com):
https://gist.github.com/MeVsTheVoices/a9d9fb6aa08fb9c1a917c068bc9a543a

RWG is getting removed in the next version. The version in unabridged is completely unfinished and got abandoned.


.github/workflows: do not fail ginkgo if unable to fetch features

Fetching the features tested on the GH workflow should not be a reason to fail the workflow. Thus, we can continue on error if this step fails.
Fixes: a23106d28619 (".github/workflows: report which features are being used in CI")

/test


[Docs] Add manpages to Readthedocs

@vvbandeira @dralabeing

Changes made:

Add install instructions for Manpage in utl/README and Build.md

Looks good!


Importing error

Hi,
I did my coding for the scribble-tune. How to import it in the Ableton live 9 if i import it the music is not playing there is no sound.

Hello there. Make sure you drag an instrument on to the MIDI channel you want to import the clip to. Then drag the music.mid file exported from Scribbletune on to the MIDI channel and play it. Let me know how that goes ;)


fix(Deps): address npm audit

:tada: This PR is included in version 2.7.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Optionally prefix all class names

Spectre is wonderful. I really want to use it for most of my future projects, where it will do a fabulous job maintaining a bit of sanity in my frontend when there is need for basic style and elements.
However using it for existing projects can be very hard, especially since classes can clash with existing code or worse with existing framework behavior which is harder to change. In my case Ember.js adds a loading class to all links that are mid transition which can be great, but also can break the layout in unexpected ways because the loading state is not tied to a specific css selector.
This can be fixed rather easily by prefixing all selectors generated by Spectre, which is rather straight forward and completely optional when done with Sass.
I just forked the repository to our company account and will provide a pull request for this until later today. It will default to an empty prefix, meaning no breaking changes for existing users. I'll also add documentation for this where necessary.
Edit
As mentioned below, I'm aware of prefixing as a postprocessing step, but this does not work for the Sass source.

This is already there.
https://picturepan2.github.io/spectre/getting-started.html#variables-custom-prefix

I forgot to add this reference. This approach does not work for me as I prefer to consume the source files, where this post processing likely fails.

Thank you. There is already a solution to Custom prefix here. https://picturepan2.github.io/spectre/getting-started/custom.html#variables-custom-prefix It is safer and quicker. I fixed the gulp v4 issue in v0.5.9. This will fix your issue.


Adding multi-agent unprotected intersection environment

What changes do you make in this PR?
Adding multi-agent unprotected intersection environment
TBD: Randomized spawning spots for agent (currently max. spots = 8)
Checklist

[x] I have merged the latest main branch into current branch.
[x] I have run bash scripts/format.sh before merging.
Please use "squash and merge" mode.

Thank @Edwardhk ! Very nice kickoff for MAIntersection!
Please don't use YOUR_NAME/main again! This causes many troubles when we want to follow up this PR.


Typescript type annotations

(Also added cross-env devDep for windows build compatibility)
Are the definitions correct?  I think so, but I don't have a good way to test, so I didn't.
I also didn't review for updates since my original attempt.  If they're close, we can fix the definitions as issues are found.
What do you think?

Thanks! 👍


Allow root module's override tags to take precedence over the overridees from transitive deps.

Occasionally, a bazel_dep can introduce a maven.overrides tag that aliases an artifact to another label. This may not be what the root module desires, and so we should allow the root module's overrides to take precedence over any transitive overrides, but at the caution of the root module owner.
Concretely, this is a problem encountered by the Bazel project itself, where a grpc-java transitive dep overrides @maven//:com_google_protobuf_protobuf_java as an alias to @@protobuf+//:protobuf_java, which was not desirable.
This PR is validated by a test that contains a root override from okhttp to javapoet, which takes precedence over a dependency's override from okhttp to a poison pill label.

Thanks! Is it possible for the root module to just remove the override instead of adding a new one? Not sure how to do it properly.
/cc @shs96c

It's possible, but removing it instead of aliasing it to something else might cause the transitive bazel_dep to break?

It's possible, but removing it instead of aliasing it to something else might cause the transitive bazel_dep to break?

So I guess, if the root module wants to revert it back to the jar from maven, they can still do that with an override, right?

It's possible, but removing it instead of aliasing it to something else might cause the transitive bazel_dep to break?

So I guess, if the root module wants to revert it back to the jar from maven, they can still do that with an override, right?

Yep! That's the idea. The root owner can override it back to the original (or any other target) if they are sure that the transitive dep is ok with it. But outright removing it will probably break the transitive dep.


ImproveTagParsing: Stop tag parsing at any invalid tag character

Obsidian tags start with a # and then can have a mix of alphanumeric characters, _, -, or /. A tag also cannot be strictly a number. Adjusted the tag parser so that it handles tags in the same way as Obsidian does.
Closes #56

Indirectly merged  into the fun that was release 3.3... where I ended up doing a big refactor of Tag handling.  Many thanks!


Support non-URC events for Quectel GSM Modules

This pull request updates the cellular library to support non-URC events sent by the modem, such as:   <socket_index>,CONNECT OK. This is required for Quectel GSM Modules added in https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface-Community-Supported-Ports/pull/3
The unit tests are updated to include the changes

Hi @Mtalat,
We suggest you move this port to the community support repo.
https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface-Community-Supported-Ports
This repo will be existed in the module/ThridPart directory.

@Mtalat
I don't have the cellular modem. I use a similar example from the document.
AT+QIOPEN=1,“TCP”,“<IP_ADDRESS>”,“8063” <= AT command
OK <= AT command SRC success token
1, CONNECT OK <= This line will be regarded as AT_UNDEFINED since it is not in CellularUrcTokenWoPrefixTable and it doesn't has prefix.

Can you help to try this patch?
Also update the module porting.
https://github.com/1NCE-GmbH/FreeRTOS-Cellular-Interface-Community-Supported-Ports/blob/e882083635a88b6a6a33b4190b6e40515790d0fa/qgsm/cellular_qgsm.c#L109
static bool prvUndefinedRespHandler( CellularContext_t * pContext, const char * pLine )
{
    bool result = true;

    LogInfo( ( "prvUndefinedRespHandler : input line %s", pLine ) );

    /* Handle the AT_UNKNOWN message here. If it can be handled, return true. Otherwise,
     * return false to pktio to indicate error.  "0, CONNECT OK" can be handled in the callback. */
    return result;
}

CellularError_t Cellular_ModuleInit( const CellularContext_t * pContext,
                                     void ** ppModuleContext )
{
    ...
    if( cellularStatus == CELLULAR_SUCCESS )
    {
        cellularStatus = _Cellular_RegisterUndefinedRespCallback( pContext, prvUndefinedRespHandler );
    }
    return cellularStatus;
}

If this patch can help your porting, I will try to merge the patch to this repository.

This PR is included in PR #71.
Please help to update your porting accordingly.
Many thanks to your contribution. I will close this PR first.
If there is any question, please re-open this PR and reply.


dont force list view when using column mode.

What feature or improvement do you think would benefit Files?
when using column mode, i can no longer see the thumbnail tiles properly. this renders the column mode completely impractical.
Requirements
allow river view / tile view / filmstrip view / details view on the right pane, when using column mode.
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.2861
Comments
No response

Thanks for the feedback, column mode isn't built for viewing videos and photos and wouldn't make sense for navigation. The features you want are likely in the preview pane (Alt+Ctrl+i)

Thanks for the feedback, we’ll keep this in mind as we continue exploring additional density options for the different layouts.

Thanks for the feedback. We don't have any plans to implement this feature, but we’ll keep it in mind as we continue exploring additional density options.


 But that is not the case.  Anyway, I assume the code from the branch 'mh-ctrlr_load_balancing' is now in the master?

Looks right to me and there are no differences between branches now. I will delete mh_ctrl_load_balancing


Use a custom comparer to prevent boxing

For full benchmark and results see this gist, but in summary:

oh, neat!

That was quick, thanks!


add @niftyco/standard

I'd like to be able to use my own standard fork in the plugin without having to completely fork and make my own plugin utilizing it.
We should really look into making it so such stuff isn't required.

Hey @joshmanders, I would prefer something you described on #137. I don't think adding another linter will help the installation of this package, right now it takes far to much time to install it. That's why I want to remove the linters from the dependencies of this package. So I can't accept this, but I loved your idea.


forms needs an action

https://github.com/MisahSaid/reparatie-end-ass/blob/6105a1ccf921cf46bd0110e8b866f62d2ab1e052/views/goal.ejs#L30
With the action you can send the data of the form to the right route

Now it like this

It needs to be more like this :

Thank you Chris!! I noticed while trying to edit my code in that page that the structure isn't right for the goal of the page. It should be structered bit differect due the fact that page should be a filled in form already etc. But it makes sence thank you!
i will try to resolve this / use this in my next project when having more time!!


Cross namespace/global Operator

Currently, we have a simple approach where the operator simply watches the namespace it was created in. But in larger env, multi-namespaces are common. To create mysql cluster in any namespace, we broadly have two approaches (1) Make mysql-operator watch and create mysql clusters in any namespace (2) Continue with current model.
However, current approach is problematic when multiple namespaces are present. The CRDs are global and deploying operator in every namespace is tedious.
More details in this conversation:
j0gger @smanpathak 10:52
@calind @AMecea any thoughts on the design wrt namespaces? Currently, we have a simple approach where the operator simply watches the namespace it was created in. But in larger env, multi-namespaces are common. To create mysql cluster in any namespace, we broadly have two approaches (1) Make mysql-operator watch and create mysql clusters in any namespace (2) Continue with current model.
However, current approach is problematic when multiple namespaces are present. The CRDs are global and deploying operator in every namespace is tedious
j0gger @smanpathak 11:16
e.g. I have a cluster used for dev and test. The test workloads can fail and keep taking capacity. So, I would like to clean them up periodically without touching dev. I can do that easily with separate namespaces.
Calin Don @calind 11:23
The operator takes a -namespce parameter so you can launch an operator for dev and one for test.
j0gger @smanpathak 11:25
Yeah, but that will require more process. I update the operator atleast once a week.
as i said, it will be simpler if a global service provides mysql instances in any namespace.
Calin Don @calind 11:26
We can implement an annotation like mysql.presslabs.org/class an have the operator act only on those annotated with it’s class
If you can open a PR with a behavior like that we can merge that
j0gger @smanpathak 11:28
Are you suggesting capability to create instances in any namespace, but only for those requests which have the class annotation?
Calin Don @calind 11:28
Yup
Just like nginx-controller does for example
https://kubernetes.github.io/ingress-nginx/user-guide/cli-arguments/ (-ingress-class) in nginx’s case
Would that solve the issue for you?
j0gger @smanpathak 11:34
So that I understand what they mean: (1) if mysql-operator CRD is created without a class spec annotation it creates mysql objects across namespaces (2) if it has a class spec, then only creates objects with that annotation?
across namespaces in case (2) as well
seems like a design similar to storage provider, and objects without class spec using the default provider
if that’s what it means, yes that works for me.
Calin Don @calind 12:21
Yup, just like the storage provisioner
j0gger @smanpathak 12:33
sounds good

@smanpathak, I've summarized the design. Also filed #87 because the way --namespace currently is a bit unexpected:

[ ] add a --class parameter to the operator which by default is empty
[ ] the operator should enqueue only MysqlCluster resources with a matching mysql.presslabs.org/controller-class. If an operator is started without an empty class it must enqueue only resources without the annotation set

I believe cross-namespace operator is a controversial idea.
I large organizations you can have several teams which have own setup in own namespaces.
So if some team wants to update own MySQL cluster or apply custom-patch on the operator.
Such actions shouldn't affect other namespaces.

This issue is partially fixed by #232, the PR introduces --namespace command line flag and watchNamespace value in the chart values.yaml.
A way to fix this is to introduce a new command line flag --namesapce-selector which will watch only for resources that are in namespaces labeled with labels provided by the flag. I would like to know your opinion about this.


bootstrap.min.css doesn't work

Replacing it with  "href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"
fixed the issue, but the Menu is still not 100% functioning.
Scrolling page Up and Down is not moving the Left Menu.
Font is also not precisely the same

Having the same issue with 3.3.7


How to use authenticated routes that are permission based?

I'm trying out Navi on a ReactJS application that has a bit complex routing system. What I'm doing right now is having a wildcard route, and then do necessary permissions checks and then mount routes based on the checks.
'*': map((request, context) => {
    const { authService, } = context;
    if(_.isEmpty(authService.currentUser)){
      const originalUrl = encodeURIComponent(request.originalUrl);
      return redirect(
        `${routeRegistry.login.path}?redirectTo=${originalUrl}`,
        {exact: false,}
      )
    }
    if(!authService.currentUser.name) {
      return getLoginRoutes();
    }
    return getAuthenticatedRoutes();
  })

const getAuthenticatedRoutes = () => {
  return mount({
    [routeRegistry.dashboard.path]: ...
  })
};
const getLoginRoutes = () => {
  return mount({
    '/': ...
  })
};

But with this approach I'm unable to unmount routes if the user loses permissions (when logging out).
Do you have an example similar to what I'm trying to do right now?

You’re on the right track! I do something similar in my current app. The main difference in my approach is I pass the currentUser to context, and call navigation.setContext to update it when it changes (which recomputes the routes).
Let me know if this helps.

@jamesknelson that is interesting. Will the routes that earlier was mounted, be unmounted? Or what happens at setContext? Is it that of 'restting' the routes as you explain in the documentation of not trying to change the context to often?

Changing the context will just recompute the route object from scratch. You can think of this as calling a setState within the <Router> function - it can be very fast, or quite slow depending on the size and design of your application.
In any case, authentication state changing should be a relatively rare event, so it shouldn't be a problem to call setState when auth state changes.

@jamesknelson cool cool thanks! Is there a difference from setContext, and changing the object that is sent in to the context of the router?
As you mention here: https://frontarm.com/navi/en/guides/routing-context/#the-context-prop that if the object changes a new computation changes.

They're actually the same thing. Changing the context prop just calls setContext under the hood.

Kkk, then I understand more :)
Thanks.
I will let @malithrw close this when he is done with examples and understood it himself

Thanks guys!


[wallet] Add dapp signMessage functionality

Problem
Sui Wallet doesn't yet support the signing of messages sent from a dapp.
Summary of Changes

Added signMessage method to DAppInterface
Created Sign Message Approval page for popup
Added message passing flow and redux integration
Adds additional permission suggestSignMessages

Fixes https://github.com/MystenLabs/sui/issues/3832

Heads up, these dapp pages are being re-designed here: #4006

Thanks for the heads up @Jordan-Mysten! Those look really nice. I'll follow that PR and reopen this when I've reconciled the update.


I can create discussions on rooms that I am not a part of

If a room is public, but I am not a part of it, I can still create discussions on it.

Closed by https://github.com/debdutdeb/rocket.chat.apps.discuss/commit/7585d2cb55ff867d62ef826681a3da77868fb398


fix: added dataFormat into file data

Description
Added data format in filepicker widget
Fixes #11279
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/issue-11279

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.34 (0)
37.75 (0.01)
35.95 (0)
56.56 (0)

:green_circle:
app/client/src/selectors/commentsSelectors.ts
85.25 (1.64)
64.71 (2.95)
73.33 (0)
90.59 (2.35)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

/ok-to-test sha=45e0e95

/ok-to-test sha=db301eb

@techbhavin Tested this PR and please find the status below,

Trying to bind the file data format the auto-suggestions don't show options "dataFormat" and it just shows data
Steps:
A) Add a file picker and upload a file
B)Add a text widget and bind the text widget with filepicker - {{Filepicker1.files[0].}} and check for the auto suggestions

https://www.loom.com/share/78e513341d44400ca94c664f2f3548c0

Dynamic update on the fileData type is not reflecting on the binded widget and every-time user needs to refresh the page and add a file again
Steps:
A) Add a file picker and upload a file and set the data type as Binary
B)Add a text widget and bind the text widget as {{Filepciker1.files[0].dataFormat}}
C)change the data type in the file picker widget to Text and observe the text widget is not updated dynamically

https://loom.com/share/86b4cc9135d54f1f99030a030b3b07f4

The evaluated value on the image widget is not appropriate when the file picker is binded with the image widget and keeping the file data type as binary or Text. Is this expected behaviour?

https://www.loom.com/share/7d4274d3a37a4533908986ef81483b25

@YogeshJayaseelan  plz refer this comment and let me know your new observation
comment 1: I'll update autosuggestion
comment 2: dataType is bind with the uploaded file. once you upload the file in base64 and then you update dataType from the property pane and expect that reflection to the uploaded file that's wrong (not relevant issue)
comment 3: image widget only accept URL / Base64 formats, not text format (not relevant issue)

/ok-to-test sha=ae74b52

@techbhavin Tested this PR and it is working as expected


QOS1 publish NullPointerException [MemoryStorageService]

hi, @andsel .I find that if we use the MemoryStorageService,when  we publish a message with qos1 to the server,a NullPointerException occured.I think we should add this sentence to the removeMessageInSession method of the org.eclipse.moquette.spi.impl.MemoryStorageService class.

it is a Business logic in the MQTT, when we publish a  qos1 message to the subscriber who is active,no PublishEvent will be writen to the  Map<String, List> m_persistentMessageStore [MemoryStorageService].And once a pubAck message arrived,the removeMessageInSession method will be called,and the  List events = m_persistentMessageStore.get(clientID) will be null;

Fixed with 33bc23b4e100ff26b5fd2a8fdb35b228f584423e as MapDBPersistentStore already done.


2 add additional methods

Adds build instructions and attempts to ignore build-related files

Thanks! Could you pls remove package.json and bun.lockb from the .gitignore? They are essential to make sure you install the proper version of each package.

I can -- normally each user does an install locally to update their package.json, but if you feel it's safe to push my version to main, tis fine my me.


The Tool is failing to generate the test case when flag -ac -rbt provided

As Documentation mentioned , When we execute the command with flag -ac -rbt the tool is throwing the error as mentioned in screenshot
However without flag the tkltest is running as expected
Command
tkltest -cf ./test/data/pdl/common-externalid-service/tkltest_config.toml -vb generate ctd-amplified -ac -rbt
Environment information

CLI version
OS: Windows

@Nachiketh18 great thanks for the update


[ARM Plugin] Fixed handling of negative axes values in MVN

Negative value means counting the in_shape dimensions from the back.
Partially fixes #428
Signed-off-by: Dmitry Ermilov<EMAIL_ADDRESS>

@dmitryermilov thank you for the contribution! Welcome to the OpenVINO contrib! :)


Beta/1.6.2

What
Update default search limit from 20 to 50
How to review
Check that a search for a dimension of more than 50 through the api and with no limit set returns 50 results.
Who can review
Anyone but me

NB. I can see there was more in develop rather than just my change and that it hasn't been released before. I'd appreciate some advice on how to proceed .


Cl sea kraken displays wrong image

🐛 Bug report
=Cl sea kraken shows the cl for zil

duplicate of #1170 can be closed


Ensure files are marked as deleted

JIRA Ticket: https://jira.lyrasis.org/browse/FCREPO-3338
What does this Pull Request do?
Not entirely sure what was happening, but it appears that when deleting binaries we were executing 2 delete requests. The DeleteResourceService called resource().getDescribedResource() to delete, but that is the binary. Changed that to getDescription() and removed the check to delete the binary-description from the persister.
This seemed to resolve the issue, so maybe it was a race condition?
How should this be tested?
Follow the steps in the ticket and with this PR, the deleted children of an AG stay deleted.
Interested parties
@fcrepo4/committers

Not related, rolling into #1711


Crossorigin Status Reports

Idea for v2
Cross Origin is up and down the last few days. Maybe for v2 you can have crossorigin.me/status just like github status

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/39833823-crossorigin-status-reports?utm_campaign=plugin&utm_content=tracker%2F12536595&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F12536595&utm_medium=issues&utm_source=github).

crossorigin.me/status

Well that's going to work really well if Crossorigin is down... :-)

Not really there are services that do that and stay up even when it is down.


If yamlizing objects they get casted as arrays

This allows yamlizing simple objects with public members only like associative arrays wich is often quite useful.

Might be very useful for deeply nested structures containing arrays as well as objects.

Any opinion about that anyone?


[WIP] Game Monk & Tictactoe widgets

This PR is in extension to #8176

One issue I have identified with this widget:

This can be reproduced by narrowing to a widget stream and then clicking all messages.

This is looking great so far!   @timabbott This particular PR still needs some work, but it's further validation that I think we're ready to merge #8350 after you give you that a review, so that we can start building widgets like this trivia widget.


docker@2 docker history --format flag only introduced in 17.0.9

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Docker
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment
Azure Pipelines:
sdo-online, Te Ara Manaaki, ei-mule-runtime, ei-mule-runtime-70

Agent: Private
OS: RHEL 7.6
Agent Version: 2.150.3

Issue Description
The RHEL Docker version 1.13.1 is not compatible with dockerV2.

Is there a minimal version of Docker for this task?
Task logs
logs_10365.zip
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
414unknown flag: --format
415See 'docker history --help'.
416##[debug]rc:125
417##[debug]success:false
418##[error]unknown flag: --format
419##[debug]Processed: ##vso[task.issue type=error;]unknown flag: --format
420##[error]See 'docker history --help'.
421##[debug]Processed: ##vso[task.issue type=error;]See 'docker history --help'.
422Finishing: push to ACR
`

We have fixed this issue so that the docker task will not fail for old docker versions due to --format flag

Hi @dabasnidhi a question around the release of the fix
According to the Merge M153. This was released to 2.253.3. We're running 2.254.2 and still seeing this error
`Starting: push to ACR
Task         : Docker
Description  : Build or push Docker images, login or logout, or run a Docker command
Version      : 2.154.4
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/build/docker
sr/bin/docker push /ei/mule-ee-runtime:12912
The push refers to a repository [/ei/mule-ee-runtime]
82d2f05de59e: Preparing
8bd751e53129: Preparing
73bba00e98eb: Preparing
...
9a5bec00fb84: Layer already exists
21c8b525c58c: Layer already exists
8bd751e53129: Pushed
4b14d4850bd6: Pushed
12912: digest: sha256:4cd987a865561fcd7ae6643fef48b65cde99251f73087d85de78428ba81dd272 size: 2831
sr/bin/docker history --format createdAt:{{.CreatedAt}}; layerSize:{{.Size}}; createdBy:{{.CreatedBy}} --no-trunc ***/ei/mule-ee-runtime:12912
sr/bin/docker push /ei/mule-ee-runtime:v1.1-Mule4.1.1
unknown flag: --format
See 'docker history --help'.
##[error]unknown flag: --format
##[error]See 'docker history --help'.
The push refers to a repository [/ei/mule-ee-runtime]
82d2f05de59e: Preparing
8bd751e53129: Preparing
73bba00e98eb: Preparing
59f2dd0c3c92: Preparing
2fd73551dd7d: Preparing
ceb314908860: Preparing
See 'docker history --help'.
##[error]unknown flag: --format
##[error]See 'docker history --help'.
`

Hi @byroncollins , the fix for the issue has been released already in the version 2.154.4.
In order to test I have tried with random unknown flags, and the task did not fail for me, it only logged the exception for unknown flag. So I am unable to infer why it could be failing for you.
Can you please share the generated files for the Docker task in the Agent folder which gets created on your machine when you run the task?
Also request you to re-configure your agent, and run the task on a fresh pipeline.


Oil Well North Light Pole Placement

On Oil Well North at the end of tracks B5O/B6L where you can drive into a dead-end, with the default light pack you get stuck on the last yard light if you drive the steamer into the dead-end to reverse onto another track.
Have to disable mod temporarily to get past the yard light as the delete function of the remote somehow does not work on that yard light.

Hi thanks for the heads-up, I will look at that and fix the issue.
There are a couple of work-arounds you can use temporarily rather than disabling the mod wholesale:

Any lights read from a pack are read-only because LightSniper can't write the changes back into the pack zip file. However you can extract the pack Regions into the user Regions folder and then you can edit any lights you wish.

All the lights in the default pack are organised into groups, you can selectively enable and disable groups using the console commands. For example all the yard lights are in a group called yard_lights so you can disable them using the command LightSniper.DisableGroup yard_lights


ripgrep: 0.8.1 -> 0.9.0

https://github.com/BurntSushi/ripgrep/releases/tag/0.9.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: ripgrep
Partial log (click to expand)
post-installation fixup
moving /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0/man to /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0
shrinking /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0/bin/rg
gzipping man pages under /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0/bin
patching script interpreter paths in /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0
checking for references to /build in /nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0...
/nix/store/2g17dzsmh05gsdwsanm15s5h6xvidh14-ripgrep-0.9.0

Success on aarch64-linux (full log)
Attempted: ripgrep
Partial log (click to expand)
post-installation fixup
moving /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0/man to /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0
shrinking /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0/bin/rg
gzipping man pages under /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0/bin
patching script interpreter paths in /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0
checking for references to /build in /nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0...
/nix/store/wkg7dlanlrfzj9j0ni13fy11wpkz2glz-ripgrep-0.9.0


chore(main): release 1.2.14

:robot: I have created a release beep boop
1.2.14 (2024-10-28)
Bug Fixes

deps: bump cookie and express (fa45d86)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/JoshAlexis/utils-abstractions/releases/tag/v1.2.14 :sunflower:


Wrong syntax highlights in MSDN Magazine Archive

Describe the bug
C++ code samples in MSDN Magazine Archive are syntax-highlighted as XML.
To Reproduce
Steps to reproduce the behavior:

Go to C++ - From Algorithms to Coroutines in C++ | Microsoft Docs.
Scroll down to the first code block.
See the code block is syntax-highlighted as XML.

Expected behavior
The code block is syntax-highlighted as C++.
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser: Edge
Version: 103.0.1253.0

Smartphone (please complete the following information):

Device: Pixel 5a
OS: Android 12
Browser: Firefox
Version: 100.1.1

Additional context
N/A

Thank you - this has been fixed and the fix should be live in ~2 hours.


Random corruption of solcast.json

          I went down the rabbit hole and wanted to see if i could find a pattern.

One thing i did find was a single case, around the time history data dissapeared, where solcast.json was literally just this:
{"siteinfo": {"xxxx-xxxx-xxxx-xxxx": {"forecasts": [] "tally": 0}}, "last_updated": "xxxx", "version": 4}

Probably some issue thats already been addressed, but i did notice that history dissapeared occasionally. One thing I didnt know, until this evening, was that it wasnt meant to!
Originally posted by @sh00t2kill in https://github.com/BJReplay/ha-solcast-solar/issues/153#issuecomment-2324678104

At present, my thoughts are that this bug is squashed. Changes to serialisation. Changes to startup. Changes to exception handling. This issue would need to sit for a long time stale until this is proven in the current code.

Will close.


Interfaces Supplied in Data files are missing.

Rbac\Role\RoleInterface and Rbac\Role\HierarchicalRoleInterface provide in the data files are mission.
No such interfaces are defined.

Those interfaces are defined in the Rbac package (that ZfcRbac uses): https://github.com/zf-fr/rbac


EXTENDED CHANGES: feedID/InputID updates

Breaking Changes:

Remove FeedID/InputID wrapper objects

Rebased on main to include Bernard's changes

Rebased on master


ESP32 partition schema and apps support

The following partitioning schema is used and supported:
# Name,   Type, SubType, Offset,  Size, Flags
# Note: if you change the phy_init or app partition offset, make sure to change the offset in Kconfig.projbuild
nvs,      data, nvs,       0x9000,     0x6000,
phy_init, data, phy,       0xf000,     0x1000,
factory,  app,  factory,  0x10000,   0x1C0000,
lib.avm,  data, phy,     0x1D0000,    0x40000,
main.avm, data, phy,     0x210000,   0x100000

The schema should be evolved in order to support more advanced scenarios, such as application updates, and etc...
The following boot sequence should be supported:

boot into kernel application
decided whether boot app1 or app2
open the partition and run the StartupModule:start()

The kernel application might be packed together with the rest of the libraries in order to reduce the partition count, however at the moment booting into lib.avm is not supported.
Also the simplest possible scenario should be supported anyway (that is libraries and just one app packed together).
So the following changes are proposed:
When there is a kernel.avm partition, the kernel.avm partition is always booted.
# Name,   Type, SubType, Offset,  Size, Flags
# Note: if you change the phy_init or app partition offset, make sure to change the offset in Kconfig.projbuild
nvs,      data, nvs,       0x9000,     0x6000,
phy_init, data, phy,       0xf000,     0x1000,
factory,  app,  factory,  0x10000,   0x1C0000,
kernel.avm,  data, phy,     0x1D0000,    0x40000,
app1.avm, data, phy,     0x210000,   0x100000
app2.avm, [...]

The following is still supported:
# Name,   Type, SubType, Offset,  Size, Flags
# Note: if you change the phy_init or app partition offset, make sure to change the offset in Kconfig.projbuild
nvs,      data, nvs,       0x9000,     0x6000,
phy_init, data, phy,       0xf000,     0x1000,
factory,  app,  factory,  0x10000,   0x1C0000,
main.avm,  data, phy,     0x1D0000,    0x40000,
[...]

Question: do we want to keep support also for a lib.avm + main.avm scenario, or in general do we want to still support a lib.avm partition?
Right now it costs about 15 lines of code, so it doesn't add too much complexity.
I suppose that we might also support lib, kernel, app1 and app2 partitions with ho additional code for free, we just open lib.avm partition regardless of anything else.

Other additional schema that we might support: kernel.avm + main.avm (just a single app with kernel app that boots into it).


Sprint 6

fixes #65

Pull Request Test Coverage Report for Build 260

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 49.225%

Totals

Change from base Build 258:
0.0%

Covered Lines:
127

Relevant Lines:
258

💛  - Coveralls

This pull request will be merged with the #77 pull request


ENH: Add C++ script to add in-class {} member initializers to ITK

The script that was used for the following pull requests:
pull request https://github.com/InsightSoftwareConsortium/ITK/pull/3851 "STYLE: Add in-class {} member initializers to objects created by New()"
pull request https://github.com/InsightSoftwareConsortium/ITK/pull/3913 "STYLE: Add in-class {} initializers to classes with virtual functions"
pull request https://github.com/InsightSoftwareConsortium/ITK/pull/3917 "STYLE: Add in-class {} initializers to classes with override = default"

Thanks for doing this @N-Dekker :100:, and also all the related PRs lately, and the PR to skip the CI for files that do no need to be tested.

You're welcome @jhlegarreta I'm happy to see that it did not trigger a CI run  😃
You know I hesitated to place this script in the ITK git repository, because I did not want to add an extra maintenance burden. The script was meant to reduce maintenance in the first place! Once it is in here, people may do code clean-up's, fix typo's, upgrade the code to newer style guidelines or other compilers, etc. While I think ITK has more than enough code to maintain already!
As a compromise, could we agree that this script does not need to be at the main branch "forever"? Could it possibly be removed from the main after the next major release or so?
By the way, I may still make some small adjustments to the code, that's why it's still draft now.

You know I hesitated to place this script in the ITK git repository, because I did not want to add an extra maintenance burden. The script was meant to reduce maintenance in the first place! Once it is in here, people may do code clean-up's, fix typo's, upgrade the code to newer style guidelines or other compilers, etc. While I think ITK has more than enough code to maintain already!

As a compromise, could we agree that this script does not need to be at the master branch "forever"? Could it possibly be removed from the master after the next major release or so?

Niels, we ourselves are trying to maintain code that we did not write, so anybody in the open source community that is interested in ITK is more than welcome to improve the script if they need it. But in the first place, it can be very useful for e.g. remote modules.
So even if you cannot devote time to maintain it further, I would keep it; it does not make sense to me to remove it for the next releases (for example, not all remotes may have time to apply the script by then).

By the way, I may still make some small adjustments to the code, that's why it's still draft now.

Fine, I just wanted to thank you for the effort of doing these things.

Is there much overlap with this an the "use-default-member-init" functionality of clang tidy?
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html
@N-Dekker Can you compare and contrast functionality?

Is there much overlap with this an the "use-default-member-init" functionality of clang tidy?

Thanks for asking @blowekamp I think this script (AddEmptyDefaultMemberInitializers.cxx) is complementary to the clang tidy "use-default-member-init" option. The clang-tidy option moves existing (C++98/03 style) member initializers from constructors to the corresponding C++11/C++14 in-class data member declaration. While the script adds in-class {} initializers to data member declarations that did not yet have them.
 Specifically:
int m_Data; // Some comment

Because of the trailing comment, this data member is still ignored now, even if it should have a {} initializer. To be continued... 😃


Decrease complexity in versions.py

          The nested conditional statements are quite complex. Breaking down this logic into smaller, more descriptive helper functions would increase readability and maintainability.

Originally posted by @daniel-sintef in https://github.com/SINTEF/ci-cd/pull/220#discussion_r1403073988

Especially update_specifier_set().


Add documentation for cadl sync and generate

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

FYI @raych1 @dw511214992 we should start to use these scripts in all the languages.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


openapi: Add example validation and fix response validation bug.x

Add test to validate example responses in zulip.yaml. Also change
zulip.yaml for some wrong examples or for cases which were not
covered by test-api. Also enhance validate_against_openapi_schema.
Also, Currently there are no checks in validate_against_openapi_schema
to check whether the content it received actually matched with
the response code. For example during testing if a certain endpoint
was returning 400 but it was expected to return 200, then it would
pass schema validation as it would only have msg and result keys.
Add this validation and fix the wrong response returning points

This is great, merged as e989c87a18b123d6c84e5bfb0abd38a552aac3ef after fixing the comment above.
I think the HTTP response for editing subscription properties is probably something we should plan to remove; I'll open an issue for that.


Create GitHub documentation page to visualize existing markdown docs

Is your feature request related to a problem? Please describe.
Improve documentation accessibility.
Describe the solution you'd like
A dedicated Github documentation page that will serve as a centralized hub to visualize and navigate through the existing markdown documentation files.
Tasks

[ ] Investigate and select a documentation framework/tool, ideally one that works with GitHub Pages.
[ ] Set up the chosen tool in the repository.
[ ] Configure the documentation tool to generate pages from the existing markdown files.
[ ] Test the documentation page to ensure that it is user-friendly and correctly displays the markdown content.
[ ] Set up CI to automatically deploy updates to the documentation site.
[ ] Write basic guidelines for future contributions to the documentation.

Hello! I found this: https://docsify.js.org

Yes, I would like to work on this.
The tool I found deploys the markdown files to GitHub pages. It only needs an index.html to render content form those files.

These were some historic considerations for a standalone doc site (not in any order of preference):
https://www.mkdocs.org/
https://docs.readme.com/main/docs/rdme
https://www.markdownguide.org/
https://markdoc.dev/
https://mintlify.com/
https://scalar.com/
@Tomas2D what's your thought? It would be good to understand if docsify is a short term solution or long term one.

I also found docusaurus, docz, gitbook

docsify is a long-hanging fruit; it is easy to set up and modify and an active project with many plugins.
@eduardconstantin, feel free to start

the best choice in the history of choices


Catch exceptions when using OSTree version tracking in old OSTree versions

See original issue on GitLab
In GitLab by [Gitlab user @tlater] on Aug 2, 2017, 11:46
https://gitlab.com/BuildStream/buildstream/blob/master/setup.py#L72 can cause a stacktrace in setup with a very unhelpful error message - should note that the OSTree version is way outdated.

In GitLab by [Gitlab user @tlater] on Aug 2, 2017, 11:50
changed the description

In GitLab by [Gitlab user @juergbi] on Aug 10, 2017, 07:24
closed via commit 67af5967041242a0392192aad285fbad6d0b44bb

In GitLab by [Gitlab user @juergbi] on Aug 10, 2017, 18:05
mentioned in commit 67af5967041242a0392192aad285fbad6d0b44bb


Research possibility to automate entire build and deployment process

Ideally, we would like to get to a state where we can build and deploy new versions of FTM whenever changes are made to the Google Sheet that contains all the content and level information with only manual intervention when necessary.
Would this be possible? How would we achieve it? What tools or services might we need? What would we need to build ourselves? Would we need to build anything ourselves? What supplementary services might we need to build to monitor the automated process?

Duplicate issue.


Get bluez interface using NodeInfo introspection xml

Use GDBusNodeInfo to create static introspection xml
and extract the interface using g_dbus_node_info_new_for_xml.
This makes the code simpler and easily understandble from
introspection xml. introspection function order as in
bluez/doc/profile-api.txt and bluez/doc/media-api.txt
Signed-off-by: Parthiban Nallathambi<EMAIL_ADDRESS>

What are the benefits of this (besides mentioned readability, which I'm kind of sceptical if such a verboseness is required)? Bluealsa implements interface defined by bluez, so if one wants to see how the interface should look like, one shall go to the bluez documentation (bluez/doc/...). Also, personally, I do not like incorporating XMLs in small C projects. For big clambered Java project it might be fine, though :D
Whole g_dbus object registration is an internal wiring anyway, so (IMHO) if it is less visible the better. If one wants to "understand" the bluez interface one should look at bluez_endpoint_method_call() and bluez_profile_method_call() which are dispatching functions for all API calls.
Or maybe this PR is a part of some bigger picture. If so, please write some more, because it looks like some kind of XY problem :).

@Arkq There isn't any big benefits out of it except the readability and in place visibility of the actual bluez interface.


New terms for Carbon Capture and Sequestration, as well as related terms

Description of the issue
This originates from OEO Dev Meeting 24.
The concepts of Carbon Capture and Sequestration are not yet represented in the Ontology.  This probably needs a lot of discussion to capture all aspects needed by different models (calling on @OpenEnergyPlatform/oeo-domain-expert-energy-modelling).
Ideas of solution
During the meeting, we identified four terms that will be needed:

Carbon Capture
Carbon Sequestration
Carbon Capture and Sequestration
Direct Air Capture

Further suggestions and ideas for definitions are welcome.
Workflow checklist

[x] I discussed the issue with someone else than me before working on a solution
[x] I already read the latest version of the workflow for this repository
[x] The goal of this ontology is clear to me

I am aware that

[x] every entry in the ontology should have a definition
[x] classes should arise from concepts rather than from words

Some first proposals:

Carbon capture a process that captures carbon dioxide from a gas.
Direct carbon capture is carbon capture from air.
Carbon sequestration is a process that stores CO2 in a geological formation.
Carbon capture and storage is a process that combines carbon capture and carbon sequestration.

I think, we should discuss whether to use storage or sequestration.
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q is using sequestration and @l-emele is using both. I have little experience with domains so my logical solution would be that we prefer one term and use the other as an alternative term.
I disagree with the definition of carbon sequestration because it does not include pyrogenic carbon which could be a useful fertiliser in future and is not stored in a geological formation.
Another proposal for carbon sequestration:
Carbon sequestration is a process that stores carbon dioxide.
Even with the proposed definitions, we have the problem from #866 that carbon is not precise. Probably, it is common sense that carbon capture means carbon dioxide capture.

I think, we should discuss whether to use storage or sequestration.
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q is using sequestration and @l-emele is using both. I have little experience with domains so my logical solution would be that we prefer one term and use the other as an alternative term.

That is a question of the proper label which we can solve at the very end.

I disagree with the definition of carbon sequestration because it does not include pyrogenic carbon which could be a useful fertiliser in future and is not stored in a geological formation.

This seems to be a different concept than what I described. Maybe we need a parent concept of carbon sequestration and then two more specific derived concepts.

Another proposal for carbon sequestration:
Carbon sequestration is a process that stores carbon dioxide.

This could be a parent concept. So it could be:

Carbon sequestration is a process that stores carbon or carbon dioxide.

X is carbon sequestration that stores CO2 in a geological formation.
Y is carbon sequestration that stores pyrogenic carbon. (I am not very familiar with this concept, but I assume you mean this.)

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q : Any thoughts?

Another proposal for carbon sequestration:
Carbon sequestration is a process that stores carbon dioxide.

This could be a parent concept. So it could be:

Carbon sequestration is a process that stores carbon or carbon dioxide.

X is carbon sequestration that stores CO2 in a geological formation.
Y is carbon sequestration that stores pyrogenic carbon. (I am not very familiar with this concept, but I assume you mean this.)

Yes, I mean this concept.
But this concept also includes the carbon capture which is not included in carbon sequestration. For this reason, we should perhaps also add pyrogenic carbon capture as a subclass of carbon capture.
So we could call Y pyrogenic carbon storage.
Or we just add a subclass of carbon capture and storage: pyrogenic carbon capture and storage
Which fits better? Who has expert knowledge in this field?

I disagree with the definition of carbon sequestration because it does not include pyrogenic carbon which could be a useful fertiliser in future and is not stored in a geological formation.

This seems to be a different concept than what I described. Maybe we need a parent concept of carbon sequestration and then two more specific derived concepts.

I'm not sure pyrogenic carbon would be considerer CCS by everyone.  I guess it carbon retention times are extremely dependent on land management practices and so forth.  At least in the IAMC template, it would not count as CCS, but probably be lumped into afforestation.
Is there a use user of the ontology (@OpenEnergyPlatform/oeo-domain-expert-energy-modelling ) currently needing to represent this?  If not, I would move to table this issue until a later time and get on with what we do need now.

I am fine with leaving out pyrogenic carbon and focus on the current needs.

So should we implement this:

Carbon capture is a process that captures carbon dioxide from a gas.
Direct ~carbon~ air capture is carbon capture from air.
Carbon sequestration is a process that stores CO2 in a geological formation.
Carbon capture and storage is a process that combines carbon capture and carbon sequestration.

I am still confused whether we use storage or sequestration.
In my research I have often come across the short cut DAC for direct air capture. Should we add it as alternative term? If anybody is using direct carbon capture we could also add it as an alternativ term.
We should add CCS as an alternative term for carbon capture and storage
Do we need the terms in oeo-shared or is oeo-physical enough?

We also need to describe at least the relations between the processes and CO2.

Any preferences for the labels?

Nope.

Okay, then I suggest that we use storage as main label, simply because it is a bit closes to the definition which contains the word stores.
Regarding:

Do we need the terms in oeo-shared or is oeo-physical enough?

It should be implemented in oeo-physical. If we see later that we need these classes in other modules, we still can shift them.

We also need to describe at least the relations between the processes and CO2.

'has physical input' some 'carbon dioxide' should be the right relation.

I think so, I can do that.


feat: add manual linking APIs

What kind of change does this PR introduce?

Adds a new endpoint GET /user/identities/authorize which is an endpoint to initiate the manual linking process and can only be invoked if the user is authenticated
GET /user/identities/authorize functions similarly to GET /authorize where the user needs to login to the new oauth identity in order to link the identity
Example

// sign in with one of the supported auth methods to get the user's access token JWT first

// start the identity linking process
$ curl -X GET "http://localhost:9999/user/identities/authorize?provider=google" -H "Authorization: Bearer ACCESS_TOKEN_JWT"

{"url":"https://oauth_provider_url.com/path/to/sign-in"}

// visit the url returned and login to the oauth provider
// request will be redirected to the /callback endpoint

// if the identity is successfully linked, the request will be redirected to `http://localhost:3000/#access_token=xxx&....`

// if the identity already exists, the request will be redirect to:
// http://localhost:3000/?error=invalid_request&error_code=400&error_description=Identity+is+already+linked+to+another+user#error=invalid_request&error_code=400&error_description=Identity+is+already+linked+to+another+user

Details

The callback endpoint used will be the same callback as the oauth sign-in flow so that the developer doesn't have to add any additional callback URLs to the oauth provider in order to enable manual linking
A special field LinkingTargetId is introduced in the oauth state to store the linking target user ID. This ID will be used in the callback to determine the target user to link the candidate identity used
If the identity is already linked to the current user or another user, an error will be returned
If the identity doesn't exist, then it will be successfully linked to the existing user and a new access & refresh token will be issued.

Am I understanding correctly that setting the environment variable SECURITY_MANUAL_LINKING_ENABLED should enable this feature? My GoLang foo isn't the strongest. Setting that on a docker-compose deployment locally always yields 404: Manual linking is disabled so it's included in my version.
Happy to open an issue if my understanding is correct, figure I would ask firs though.

i upgrade api to allow link by oicd token  - https://github.com/supabase/auth/pull/1885
would be good to be able to test locally - was there any feedback on  @mosnicholas 's concerns.


Create proposal for PyPI organization

Now that we are publishing several PyPI packages we should officially propose creating a PyPI org to own them all: https://pypi.org/manage/organizations/
cc @tiran @russellb curious y'alls thoughts

Once the new org is approved, we should moving all of our libs to the new org: https://pypi.org/search/?q=instructlab
Current owners are:

@russellb
@nathan-weinberg
@tiran
@bjhargrave
@fabianlim

It has been pointed out that it may be better to create a user owned by the @instructlab/oversight-committee to be the package owner

I've had some conversations with pypi about this as a "whole," and organizations are still in "progress" and will only be available to the sponsoring organizations any time soon.
Unless our project can start sponsoring the PSP and pypi, this should be either completely back burner'd or closed as can't be done.

So shouldn't we go the user route I've suggested then @jjasghar? Otherwise all these packages will just be owned by a smattering of Red Hat and IBM engineers
We can create a user just called instructlab and have the credentials shared somewhere amongst the OC

Yep, that seems like the best path forward.

have the credentials shared somewhere amongst the OC

Ooooh, a 1password vault :-)

We can create a user just called instructlab and have the credentials shared somewhere amongst the OC

No, shared accounts are a bad idea. Don't do this. You want to be able to audit account activity and remove access of a person in case they leave the project or their work machine gets compromised.

We can create a user just called instructlab and have the credentials shared somewhere amongst the OC

No, shared accounts are a bad idea. Don't do this. You want to be able to audit account activity and remove access of a person in case they leave the project or their work machine gets compromised.

What we have now is bad. So what do you propose?

Use individual, personal accounts in combination with strong 2FA (FIDO). Select a few people (3-4) to be project owners.
InstructLab is using trusted publishing for releases anyway. Project admin access is only needed to yank a bad release or to add/remove another maintainer. You could make an argument that people should create a new work account with their work email address and not use their personal PyPI account. I don't think that's necessary.


Add easy share option in Sunstone for resources

Description
Currently, resources can be shared either by setting the permissions (group or all) or by setting ACL for allowing specific users to access specific resources.
It will be useful to have a share button in Sunstone which takes care of asking the user the ACL required information and create it under the hood.
Use case
Allow a final user to share resources with other users without the need of being aware of what ACLs are or how they work.
Interface Changes
Some kind of share button plus a dialog should be added to Sunstone. The dialog should be very similar to the ACL creation one.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

closed in favor of #5724


Extract characteristics for Logicals

Fixes #238 and completes task CIMPL-1167.
Logical models use special extensions to set their type characteristics. Check for these extensions when extracting keywords. Do not create caret rules for these extensions.

but I also recognize that we have other tests that handle normal extensions (and they still pass)

I'm guessing we have test cases somewhere that handle extensions on Structure Definitions generically (although I haven't pinpointed exactly which test case covers this), but I don't think we have any tests that test if a Logical has non-characteristics extensions. We only have test cases that have extensions that are all characteristics. Maybe this is testing more than we need to still, but wanted to ask specifically about that. Or maybe I'm just missing something and we have already covered that through something else.


feat: add subnet_mapping and limit id lenght lb and tg

what

Added ability to configure fixed IP via EIP
Added id length limit for lb and target groups
Add additional_certs variable for tls listener

why

The ability to set a static IP is one of the main features of the network load balancer
There have been problems with IDs being too long

references

#11
Doc: specyfic elastic ips
Doc: lb name lenght
Doc: tg name length

@joe-niland

can you run :
make init
make readme

and fmt the code please.

/terratest

@ByJacob thanks for the contribution


Copyright license pass across the board

Pull Request Test Coverage Report for Build 74288

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 80.434%

Totals

Change from base Build 73438:
1.9%

Covered Lines:
3519

Relevant Lines:
4375

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1


[Request] Set permissions of downloaded files

I would really love to be able to set the permissions of the files once they are downloaded. I use docker on my home server, and I have a different user set up for each container, but they're all a part of the same group. As it stands, seedsync writes the files with 755 as the permissions, and I have to go change the files to 775 by hand. I'd love to have an option on the seedsync configuration page that lets me set that automatically.

+1


Reversed content- "Manitoba Start & Settlement agencies"

In the Arabic version, it's written as "And settlement agencies Manitoba start &)
Because the sentence has Arabic and English wording, the order of the sentences is reversed. To resolve this, it's better to write the whole sentence in Arabic like this "مانيتوبا ستارت ووكالات الاستقرار"

Proposed solution: Insert newline between "Manitoba Start" and the remainder of the text, so the appearance in the app will be
Manitoba Start
<and settlement services>

fixed!


Changing Size in IChart node is not taking affect

Hi, I'm testing out the demo FlowChartWithState, and tried to set the size property in nodes inside IChart, but couldn't see any changes on the webpage after webpack rebuilding, is it something I'm doing wrong?
export const chartSimple: IChart = {   offset: {     x: 0,     y: 0,   },   nodes: {     node1: {       size: {         width: 70,         height: 30,       },       id: "node1",       type: "output-only",       position: {         .........

The size property is for internal use to determine which nodes are visible. You should use css / custom components to define the node size.


thumbnail preview for AtlasTextures

Fixes #3372
AtlasTextures that reference a LargeTexture will still show the default icon, but I think regular Textures are the most common case.

Code looks good :)


Support for VHDL code generation.

I will merge this to a branch and do the edits there. Is anyone else editing?

Will continue tomorrow. Please don't do any edits meanwhile.

Here is a branch that only contains the relevant changes related to hardware. I will do some more work before making a new pull request.

We now have three monads:

Program for platform-independent instructions
Software for C-specific instructions
Hardware for VHDL-specific instructions

We also have a class
type Any m = (References m, Arrays m, Controls m)

For instructions that work in all three of them.
I propose renaming Program to Comp, to signal that it's for "computation" rather than effects. If so, Any could be renamed to MonadComp.
I'm not sure about the other two monads. In some sense the names are logical, but I think both of them suggest a setting in which one does co-design and wants to distinguish specifically between SW and HW. For programmers who are only generating C it's a bit odd to work in a monad called Software (after all, all Feldspar programs are software, regardless of back end).
As Anders said about the modules, it might make sense to call them by their respective target platform names. Then the Software monad should simply be called C. This is reasonable given that it's instructions are very tied to C.
I'm not sure about Hardware, and would be fine with leaving it as it is for now.
@markus-git, @emwap What do you think?

+1 for Comp and MonadComp.
I can live with Software if the connection to C code is loosened a bit. We could for example generate assembler, interface descriptions and other support files from that monad.

Good point. But I do feel that Software is too generic. How about Sys or System to signal that it's for interaction with the operating system?
Maybe "system" is also a generic term. But then we could even use something like SysCode or whatever. At least that gives a good description of what the monad is for.
Other suggestions?

Another logical option would be FIO as a shorthand for FeldsparIO.

+1 for FIO or some other abbreviation of FeldsparIO

Moved to hardware branch.


Update and rename test to test1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fsgzfs


add NSG to restrict 22 and open 80

@yaweiw,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Fix issue where icon list and following properties are deserialized incorrectly from single-line XML

Should "isonList" in the line;
 while (!reader.EOF && reader.NodeType != XmlNodeType.Element && !(reader.NodeType == XmlNodeType.EndElement && reader.Name == "isonList"))
not be "iconList"?

Thanks for the PR. Should be published to Nuget in 15 mins or less.

Thanks for responding so fast (and catching the typo)! I will upgrade to the newest Nuget package.


UKS isn't supported on CKAN anymore, so remove it as a dependency.

Title says it all.

Fair enough. Merging.

@Quartz101 , UKS is back on CKAN, are you ok with this being reverted?

Feel free to revert. P.S - changing github username to N70

Thanks, N70!


Verify & Validate The Use Of The Configuration Class

Use Configuration class in all required classes (mostly inside the network package)

Issue fulfilled in commit 2afe7274a20196765f309d216b96a0d73f97cdf5


chore: maintainer role for jpower432

Completing a self-nomination process below
Nominee
@jpower432

[X] I have read the membership documentation

Eligibility

[X] I have been a member of oscal-compass for at least a month

Note: I currently hold a maintainer position in compliance-trestle

Sponsporship

[X] I have contacted the two project maintainers for C2P Go prior to this pull request

Justification for the Role Change
I plan on contributing significantly to the design and implementation of the v2 module of C2P Go. I have been working on a prototype implementation to help get that work started.
I have contributions to C2P and C2P Go. I have listed a couple below.

Completed work on issue 22 to decouple Python from Go
PR review in compliance-to-policy - https://github.com/oscal-compass/compliance-to-policy/pull/35

Thanks @yana1205 and @yuji-watanabe-jp!


Sends too much too discord

this worked fine at first but it sends this long line nowadays for some reason, was doing the same thing on a18.4
discord bot issue video 2020-07-14 10-11-26.zip

Closing as stale for now.


Using Auth0 to enable multiple Authentication Methods in your React App

Proposal Submission
Proposed title of article
Using Auth0 to enable multiple Authentication Methods in your React App
Proposed article introduction
[API] Handling authentication on your own always seems to be a thorn in the flesh more so when you're a frontend developer. You'd have to tell a friend to help you spin up a backend server for authentication. But even with this, they most likely won't be able to allow alternative sign-in methods like Facebook, Github, etc. Auth0 solves these problems as it allows you to enable different authentication methods on your web app without a server.
Key takeaways

Readers will learn how to navigate and use the Auth0 Dashboard.
Readers will learn how to successfully set up Facebook, Twitter and Github Authentication Methods.
Readers will learn how to integrate Auth0 with React.

Article quality
This article will cover the full steps of enabling Auth0 in a React App from start to finish. We'll go through the motions of creating a new Auth0 Account, setting up your Auth0 app, setting up the different developer accounts needed and finally integrating it into React.
References
N/A

Hello, I saw an article similar to this online and I decided to close it. I'll submit another topic soonest.


Hadd to add python-dateutil in misp-web dockerfile

Hello,
just to keep you up to date, I had to add another apt package to be installed.
The iroginal error:
error: The 'python-dateutil' distribution was not found and is required by cybox
ERROR: Service 'misp-web' failed to build: The command '/bin/sh -c python setup.py install' returned a non-zero code: 1
I've added python-dateutil into the Dockerfile at ** ./mthc/apps/misp-docker/web**
RUN apt-get install -y python-dateutil python-dev python-pip libxml2-dev libxslt1-dev zlib1g-dev python-setuptools libfuzzy-dev
RUN apt-get install -y cron logrotate supervisor syslog-ng-core
RUN apt-get clean
After making this change, the "build" installation went through smoothly.  :-)
Thanks a lot for all the great work you did.
Cheers
Marcus

Hi @icepaule,
I've just merged the misp/misp-docker to pe3zx/misp-docker which mthc is relying on.
Could you help me verify that this issue still present?
Thank you very much!

Closing due to no further response.


Are WAV files sent or just a LInk

The documentation indicates that the WAV file can be sent as email.  How is this enabled?

The .wav file is sent instead of the encrypted S3 URL when you disable the encryption setting in the admin portal.

Ok then!  That makes sense!


Moved from UiBinder to Errai UI

Moved from UiBinder components to Errai UI
Removed unused constants
Fixed ClassCastException
Removed _ on translation keys

Hi @pefernan
As I mentioned in-line, I think we should get rid of the underscores in the field names of the translation key constants since they will cause build warnings.
Otherwise looks good.

@mbarkley tbh I thought it was only with variables called "_" but you're right... so removed them.

Jenkins, retest this.

+1


Record extension

You should be able to extend a record using a syntax like { someRecord | x = "foo" }. The type signature syntax should have the same order so we should probably reverse it (have the row variable first).

Will the overloaded record be anonimous types like in Elm or SML? In haskell they aren't, so you can declare
data Pair a b = Pair {fst :: a, snd :: b}

and have
Pair :: a -> b -> Pair a b
fst :: Pair a b -> a
snd :: Pair a b -> b

But in the languages above fst and snd will have nothing to do with Pair - they would be the "methods" of anonymous record itself, and you have to manually unpack the record from the ADT like that:
let first f (Pair rec) = Pair { rec with fst = f (fst rec) }

which effectively disallows us to write code in pointless pointfree style.
How about generating a typeclass (protocol?) like HasFieldX rec :: Constraint?
P.S.: Do you plan to authomatially generate Van Laarhoven lenses/prisms on datatype declarations?

I'm not too good with ML syntax, so not sure about your unpack example. However, I want to make it much like Elm, i.e. there are no global functions fst and snd that takes pairs, fst and snd are just fields in the record and you access them using something like p.fst and p.snd. It would be nice to have the ability to pass a field accessor just like a function, say map(.fst, pairs).

If you will do like in Elm, you'll have to write
fst' (Pair p) = p.fst

due to fst being method of anonymous record, not the Pair itself.

OK, that's what I want to avoid, so not like Elm then. The PureScript approach is the one I'm after: https://github.com/purescript/purescript/wiki/Differences-from-Haskell#records


Quest Event: Typhon-Infested colony

Description
Would be neat to periodically have typhon infestation quest in which a friendly colony requests help due to a typhon invasion.

https://github.com/Vanilla-Expanded/VanillaExpandedFramework/wiki/Exporting-buildings


Double check size to avoid ArrayIndexOutOfBoundsException

Double check size to avoid ArrayIndexOutOfBoundsException
Motivation:
Recycler$Stack.pop will occurs ArrayIndexOutOfBoundsException in some race cases, we should double check size even after scavenge called.
Modifications:
Double check size after scavenge
Result:
avoid ArrayIndexOutOfBoundsException in pop
Fixes https://github.com/netty/netty/issues/9608.

@carryxyh can you please sign out ICLA and let me know once done :
https://netty.io/s/icla
Also I wonder if we can somehow write a test for it

@netty-bot test this please

@carryxyh never mind you signed it before.


Highlight recently update results

Flash them in a colour perhaps?

Could we do this by Time of Day? We habitually set the Timy system to be real time.


initialization of an instance of the custom polymer element declared in an entry page.

 Issue by RWander
Originally opened as dart-lang/sdk#19840

I cannot initialize an instance of the custom element declared in an entry page.
For example:

<polymer-element name='my-elm' attributes="count" noscript>
<template>
{{count}}
</template>
</polymer-element>
<my-elm id="my-elm"></my-elm>
// index.dart
(querySelector("#my-elm") as dynamic).count = 1;
When I attempt to initialize count propery of my-elm polymer element instance I get the following execption: Breaking on exception: Class 'HtmlElement' has no instance setter'count='. bug?

 Comment by zoechi

Only a field of a class can be accessed this way. When you don't have a class assigned to you element you can access the attribute using
querySelector("#my-elm").attributes['count'] = '1';

 Comment by RWander

attributes is Map<string, string>.. The following code doesn't work in Polymer.dart 0.11.0+5
<polymer-element name='my-elm' attributes="foo" noscript>
  <template>
    {{foo.a}}
    {{foo.b}}
  </template>
</polymer-element>
<my-elm id="my-elm"></my-elm>
Foo foo = new Foo(a:1, b:2);
(querySelector("#my-elm") as dynamic).foo = foo;
So I need to write the standard class for my-elem element.. This class contains only constructor and the declaration of Foo field, without any logic.
@CustomTag('my-elm')
class MyElm extends PolymerElement {
  @published Foo foo;
  MyElm.created() : super.created();
}
I believe that Polymer.dart will be more intellectual in a next versions..

 Comment by RWander

see also http://stackoverflow.com/questions/24578121/how-to-initialize-an-instance-of-the-custom-element-declared-in-an-entry-page

 Comment by dgrove

Added Pkg-Polymer, Triaged labels.

 Comment by sigmundch

You need to wait until the upgrade had happened before you can access the element. To do that, make sure your code that queries for the element happens after initPolymer and after Polymer.onReady. Basically like gzoechi suggested in the SO question.

Added AsDesigned label.


⚠ ClamAV has degraded performance

In 64bd7e3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: ClamAV performance has improved in 93b1dbe.


how i can build multiple SPA inside one peoject

Hi there,
first of all thanks Evan for your amazing work.
so, i'm building a large scale application, and i want to break it down to multiple SPA so for example if the user want to login then he'll use the 'auth' SPA under '/auth' route than he'll be redirected to the main SPA under '/', and if he want to access the dashboard it'll be in the '/dashboard' as an another SPA, anyway the project is much bigger and by doing his i'm trying to solve the problem if serving a heavy SPA to the user which in 80% of cases he'll only use 20% of it.
so is there anyone try to implement this before with webpack?

Hi there, please make sure to read the Issue Reporting Guidelines before opening new issues. The issue list only accepts bug reports and feature requests. Questions should be posted to the Gitter chat room,  forum or StackOverflow. Thanks.

@yyx990803  sorry,
but do you have a solution?

What you describe is just the old way of doing things, a web page that will countain a vue.js instance, without the router. You already know how to do it.
at best, you could try to use pjax style.


Minimal Theme CSS breaks Dataview in specific cases

Is the bug present when using the default Obsidian theme?
No
Is the bug present when snippets and plugins are disabled?
Yes
Minimal theme version
7.2.3
Describe the bug
The following piece of CSS from the minimal theme results in, obviously, tables having a display of 'none' if their result is an error. Which is fine in some instances, but if you have a dataview query outputting multiple tables and some of them have .dataview-error-box then none of the tables  that actually have results display. The Dataview Example Vault has some good examples for this in 30 Dataview Resources > 31 Query Overviews > Queries by DVJS function.
.block-language-dataviewjs:has(.dataview-error-box) table.dataview {
    display: none
}

Default CSS:

The exact above CSS, but with display: initial (edit: occurred to me it should have a display of 'table', not 'initial', but you get the idea):

Debug info
SYSTEM INFO:
Obsidian version: v1.4.14
Installer version: v1.4.13
Operating system: Windows 10 Pro 10.0.19045
Login status: not logged in
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: dark
Community theme: Minimal v7.2.3
Snippets enabled: 2
Restricted mode: off
Plugins installed: 5
Plugins enabled: 3
1: Dataview v0.5.59
2: Minimal Theme Settings v7.2.4
3: Style Settings v1.0.7
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Same question, made a PR to fix it.


Removing cookie from share page

I am still testing this and will update in case I find issues

Looks like a good start.


ClientResponse.status wrongly returns -1

Test used:
import Kitura
import KituraNet
import Dispatch

// configure the router
let router = Router()
router.get("/test") { request, response, _ in
    try response.status(.OK).end()
}

// start Kitura
DispatchQueue(label: "server").async {
    Kitura.addHTTPServer(onPort: 8080, with: router)
    Kitura.run()
}

//let the server come up
sleep(5)

//make a request
_ = HTTP.get("http://user:pass@localhost:8080/test") { response in
    print(response?.status ?? "no response")
}

Output with Kitura-net (which is expected):
200

Output with Kitura-NIO:
-1

Fixed by #214