ObjectType inheritance issues

I'm attempting to do codegen for frontend code using graphql introspection, but having some issues. The root of my problems seem to be that GraphQL::Field annotations aren't inherited by extending types.
This means that if I have a PaginatedOutcome class containing total_count, total_pages, and has_more fields and then I attempt to extend that object with UsersPaginatedOutcome which adds the users field, all that is seen by introspection is the users field which breaks codegen. It also makes it so that utilities like Postman don't work in these cases because they rely on introspection to make sure the fields are correct.

annotations aren't inherited by extending types

Are you sure? Do you have a code sample?

Basically I have this:
module Graph::Objects
  @[GraphQL::Object]
  class PaginatedOutcome
    include GraphQL::ObjectType

    getter scope, page, limit

    def initialize(@scope : T, @page : Int32, @limit : Int32) forall T
    end

    @__total_count : Int64? = nil

    @[GraphQL::Field]
    def total_count : GraphQL::Int64Scalar
      value = if @__total_count.nil?
                @__total_count = scope.reset_limit.reset_offset.select_count
              else
                @__total_count.as(Int64)
              end

      GraphQL::Int64Scalar.new(value)
    end

    @[GraphQL::Field]
    def total_pages : GraphQL::Int64Scalar
      value = (total_count.value / limit).ceil.to_i64
      GraphQL::Int64Scalar.new(value)
    end

    @[GraphQL::Field]
    def has_more : Bool
      total_count.value > (offset + limit)
    end

    private def offset
      (page - 1) * limit
    end
  end
end

and this
module Graph::Objects
  @[GraphQL::Object]
  class OfficeUsersPaginatedOutcome < Graph::Objects::PaginatedOutcome
    include GraphQL::ObjectType

    property scope : UserQuery

    @[GraphQL::Field]
    def users : Array(OfficeUserSerializer)
      OfficeUserSerializer.for_collection(
        scope.limit(limit).offset(offset)
      )
    end
  end
end

but the generated schema contains the following OfficeUsersPaginatedOutcome:
{
  "kind": "OBJECT",
  "name": "OfficeUsersPaginatedOutcome",
  "description": null,
  "fields": [
    {
      "name": "users",
      "description": null,
      "args": [],
      "type": {
        "kind": "NON_NULL",
        "name": null,
        "ofType": {
          "kind": "LIST",
          "name": null,
          "ofType": {
            "kind": "NON_NULL",
            "name": null,
            "ofType": {
              "kind": "OBJECT",
              "name": "OfficeUserSerializer",
              "ofType": null
            }
          }
        }
      },
      "isDeprecated": false,
      "deprecationReason": null
    }
  ],
  "inputFields": null,
  "interfaces": [],
  "enumValues": null,
  "possibleTypes": null
}

Do the fields on PaginatedOutcome resolve? We probably need to iterate .descendants in the document macro like we do in the resolver
https://github.com/graphql-crystal/graphql/blob/30643003f84062d9c5f8ca23a0702078cee824e7/src/graphql/object_type.cr#L31
https://github.com/graphql-crystal/graphql/blob/30643003f84062d9c5f8ca23a0702078cee824e7/src/graphql/document.cr#L91

They seem to resolve in situations where introspection isn't being used. The current frontend isn't using introspection, and this query returns all of the necessary information.


Dev

Created transpose and support for transpose of 1d arrays

Coverage increased (+1.4%) to 78.759% when pulling e289935bf0d7a257bc5c2c66f4bbe096450c9c7a on dev into a62567e32ec4e73001c0abd2d26c98c8ad3a27c2 on master.


Adding Travis-CI Support For Arm

Travis-CI has added support for ARM64. Added ARM64 job in Travis-CI

Thanks, but there's no reason this should be affected by CPU architecture, so I don't want to add a load of redundant tests in CI.


Add [Debian] package version support

https://wiki.debian.org/Services/api.ftp-master.debian.org

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @scop!

  Generated by :no_entry_sign: dangerJS against df2412de2f7f74a266097ab319d81fd6762a5579

A couple of improvements I thought of but didn't get around to implementing as I didn't immediately spot what would be the best way to do them:

Maybe mark versions containing ~ as prereleases -- "maybe" because that's what they usually are, but not strictly always; can be backports and such.
Implementing epoch aware ordering, possibly also stripping epochs from displayed versions; ref https://www.debian.org/doc/debian-policy/ch-controlfields.html#version, example https://packages.debian.org/stretch/bash-completion

This is a really nice addition! Thank you!


English?

Could you release a version for linux in "English"? i guess most of us would  love to know what to do after installing your app.

Sure :)

Done. @EchoUnderscoreNine


Cannot use WebUI versions > 2.4.1 for V wrapper

There might be a regression between 2.4.1 and 2.4.2.
With the "Wait for connection"-changes below it is not possible to use webui.<fn_name>('args') anymore in the V wrapper. webui.call(<fn_name>, 'args') on the other hand still does work!
https://github.com/webui-dev/webui/blob/ba7d0323774f1a1db2a488b00a0df21e86bf5a1c/src/webui.c#L6480-L6531
The changes were first added in 663e066f5eb84b6a897d099c13583eccb776b754, there it stopped working.
At first, I thought it's a thing with V GC again, but having done test with GC disabled and manual memory management the issue persists.
Changing it back to a return true in the below code makes it work again.
https://github.com/webui-dev/webui/blob/ba7d0323774f1a1db2a488b00a0df21e86bf5a1c/src/webui.c#L6513-L6515
// Stop if timer is finished
-if (_webui_timer_is_end(&timer, (timeout * 1000)))
-    break;
// Stop if timer is finished
+if (_webui_timer_is_end(&timer, (1)))
+    return true;

Next to bringing it down to this, I'm clueless :/.
Do you have an idea where the interference could come from @hassandraga?

Well, the problem is pretty simple after all. The bindings just need to happen before calling show on the window is shown, which is logical since the connection is now awaited.
If putting the bindings after the show() it is the same behavior for fall wrappers with webui.<fn_name>()

Thinking again, maybe this should work after. A call to a bind function could trigger a refresh of the webui object to be able to also webui.<fn_name> when using bind after show. What do you think @hassandraga ?

Not a critical or very concrete one.
So far only allowing the main Window of an application more loading time, or spawning a sub-window which should timeout more quickly than other windows when trying to show it.


NO!!!
他媽數學考試我完了

hii :3

:3

guh turns out im from the US
ALL HAIL THE MIGHTY EAGLE, DEMOCRACY, AND NUCLEAR ANIHILATION


Update .travis.yml dsfds

Travis tests has failed
Hey Eliran Pe'er,
Please read the following log in order to understand why the tests failed.
It'll be awesome if you fix what's wrong and commit the changes.
Powered by: Travis Buddy


Open lineage bug workaround

Describe the bug
Message from @conorbev
So while waiting for the release I tried it out from main and I do see the TransformOperator producing Inputs and Outputs now, I also did not need to set the custom extractor env var. It seemed to work fine with the default extractor. Very cool!
(https://astronomer.slack.com/archives/D044NMSCBTR/p1669860239092409)
I think I've found the reason why the SQL that the TransformOperator was supplying in the facet did not show up.
It's because the SQL facet is only being supplied in the COMPLETE OpenLineage event and you are running into this bug: https://github.com/MarquezProject/marquez/issues/2230
( I confirmed this by manually copying your SQL facet into the START event that you send and then the SQL does show up as expected: https://cloud.astronomer.io/lineage/graph/job/conor-astrosdk4/calculate_popular_movies.top_five_animations )
#2230 Only first job context is taken into consideration.
So I think we certainly need to fix that bug in Marquez either way, but in the meantime, I wanted to check with you:
Is it possible for you to set the facets during the START event or you only know it at the end ?

Currently task_instance is not available on get_openlineage_facets_on_start() on DefaultExtractor. sql is accessible using task_instance object as its template field is rendered in execute method.
    def get_openlineage_facets_on_start(self):
        from astro.lineage import (
            BaseFacet,
            OperatorLineage,
            SqlJobFacet,
        )
        base_sql_query = task_instance.xcom_pull(task_ids=task_instance.task_id, key="base_sql_query")
        job_facets: dict[str, BaseFacet] = {"sql": SqlJobFacet(query=base_sql_query)}

        return OperatorLineage(
            inputs=[], outputs=[], run_facets={}, job_facets=job_facets
        )

So I think fix on Default extractor would be required for this.
cc: @conorbev

This is still blocked on OL side.

This issue is closed now on OL side so we should test this out now.


failed to process request  8bad0031 with Win7Msix

Installing an .appx package with Win7MSIXInstaller.exe results in error :
failed to process request  8bad0031
Command line used: Win7MSIXInstaller.exe -AddPackage abc.appx
OS - Windows 7 SP1 (6.1 Build 7601)

Issue is reproduced by using both the pre-compiled and self-compiled binary

Win7MSIXInstaller.exe had some issues with certificates, fixed by the commit https://github.com/Microsoft/msix-packaging/commit/c8258683606a88244d39d192de85c7d32e00a2c3.
Can you retry with the most recent version?
Rudy

please reopen if you still experience the issue.


Authoring dashboard

I'd love to see something like the Ghost Admin interface for this, with a simpler focus and authoring markdown to github.
Ghost is using the new koenig editor, which they have as an addon https://github.com/TryGhost/Ghost-Admin/tree/master/lib/koenig-editor so maybe that can be a starting point.

How would we do this?  Let's assume the editor was available to everyone if the app was built in dev mode, since we don't have users/roles.  The app still couldn't write to disk because of the permissions that a web app has.
Would it therefore only make sense as an accompanying electron app?
Or could we work in the Fastboot realm to get server permissions and actually write the file via our 'server'?  I'm not at all familiar with fastboot, but this feels like it could be possible.
Finally, since ember s is actually launching an express instance, I wonder if we could do something in the ember-cli to add a 'save' end-point?
I'm operating a little beyond the edge of my ember knowledge here, so forgive me if any of these suggestions are patently absurd.

I could see the dashboard being the dummy app and running ember-cli-deploy to github pages on publish.

Github pages feels a little hosting specific, and I'm holding my repo in GitLab, so GitHub APIs are not that helpful either.
There might be a way of dealing with the variety of git targets in config however?

Yeah for sure. The other thing I want to do is do a p2p version where you can self-publish via dat/beakerbrowser, but that is drastically different from a regular implementation.


Prevent Time Machine from prompting to use new hard drives as backup volume

[x] I made sure this command is not in the commands list
[x] I searched and didn't find this command in the listed issues
[x] I know this defaults command exists
[x] I know this command works on macOS current version
[ ] I know this command is deprecated on macOS current version

Folder: TimeMachine
Command: defaults write com.apple.TimeMachine DoNotOfferNewDisksForBackup -bool true
Argument type (if applicable): bool
Examples:

true: When a new disk is connected, system does not prompt to ask if you want to use it as a backup volume.
false (default): When a new disk is connected, system prompts to ask if you want to use it as a backup volume.

See also: https://www.defaults-write.com/disable-new-disks-requests-for-time-machine/

@yannbertrand I can tackle this tomorrow if you want to assign me 😄

If it's alright, I will create a new folder for Time Machine defaults commands since there seem to be a few: https://www.defaults-write.com/cat/time-machine/


Bump react-native-pdf to 6.7.3

Details

Bump to 6.7.3, because 6.7.2 introduced build issue for Android with React Native version <73
Fixed Issues

$ https://github.com/Expensify/App/issues/30492
PROPOSAL: https://github.com/Expensify/App/issues/30492#issuecomment-1783856351
Tests

Same as QA

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat.
Send a large PDF file.
Tap on the PDF preview.
Double tap on it to zoom in.
Double tap again.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/138074114/b41286b1-6980-4d08-8103-04495ee006c0

iOS: Native

https://github.com/Expensify/App/assets/138074114/2035166c-336f-437e-a491-f8224ea5aaad

snyk is failing but I think it's known. What other else is not passing?

@alex2bc can you fix the commit history?

Yea, you can revert your last commit and merge main

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.5-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Principle 3.6

The Information Package MUST follow a common conceptual structure regardless of its technical implementation.
Based on principles 3.1 – 3.4 we now present a common structure for any CS IP Information Package.
Following Principle 3.4 the structure separates explicitly the representations of data and metadata into a separate structural component.
Following Principle 3.1 the package MUST include a high-level structural component for metadata which includes at least relevant metadata for the whole package. In addition the representations MUST internally separate between data and metadata (though note that the CS IP does not mandate that both data and metadata must be available in all representations).
In addition we highly recommend dividing the metadata portion of the Information Package to separate different types of metadata (SHOULD Principle 3.3).
Following Principle 3.5 repositories and their users have the possibility to add any additional components (as an example for schemas and binary support documentation) either as extensions to the whole Information Package or into a specific representation.
This common structure MUST be followed throughout all specific physical implementations of the CS IP.

In the end of the explanation we say physical implementation, does this mean its supposed to be a folder structure. We have soften that up in the description of the elements. Should we do something similar here?

Connect with catalogue / folder structure issues #366 #367 #369

We use "implementation" very freely and it's quite overloaded. Suggestion to tighten up language here as follows:

"manifested" when referring to the package structure as physical folders so not "the package structure is implemented as a physical folder structure"
"instance | instantiated" when referring to individual package instances
"implementation" when referring to implementations of the CSIP (there may be a better term here).


Update awsebs region and zones

Change Overview
Update awsebs region and zones
Add new ap-northeast-3 region/zone
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[X] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

#XXX

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Found by test:
af-south-1

eu-north-1

ap-south-1

eu-west-3

eu-west-2

eu-south-1

eu-west-1

ap-northeast-3

ap-northeast-2

me-south-1

ap-northeast-1

sa-east-1

ca-central-1

ap-east-1

ap-southeast-1

ap-southeast-2

eu-central-1

us-east-1

us-east-2

us-west-1

us-west-2

eu-west-2[eu-west-2a eu-west-2b eu-west-2c]

eu-central-1[eu-central-1a eu-central-1b eu-central-1c]

us-east-1[us-east-1a us-east-1b us-east-1c us-east-1d us-east-1e us-east-1f us-east-1-bos-1a us-east-1-iah-1a us-east-1-mia-1a us-east-1-wl1-atl-wlz-1 us-east-1-wl1-bos-wlz-1 us-east-1-wl1-dfw-wlz-1 us-east-1-wl1-mia-wlz-1 us-east-1-wl1-nyc-wlz-1 us-east-1-wl1-was-wlz-1]

af-south-1[af-south-1a af-south-1b af-south-1c]

eu-west-3[eu-west-3a eu-west-3b eu-west-3c]

ap-northeast-1[ap-northeast-1a ap-northeast-1c ap-northeast-1d ap-northeast-1-wl1-kix-wlz-1 ap-northeast-1-wl1-nrt-wlz-1]

ap-southeast-1[ap-southeast-1a ap-southeast-1b ap-southeast-1c]

ap-south-1[ap-south-1a ap-south-1b ap-south-1c]

ap-northeast-2[ap-northeast-2a ap-northeast-2b ap-northeast-2c ap-northeast-2d ap-northeast-2-wl1-cjj-wlz-1]

ap-east-1[ap-east-1a ap-east-1b ap-east-1c]

us-west-1[us-west-1a us-west-1b]

us-west-2[us-west-2a us-west-2b us-west-2c us-west-2d us-west-2-lax-1a us-west-2-lax-1b us-west-2-wl1-den-wlz-1 us-west-2-wl1-las-wlz-1 us-west-2-wl1-sea-wlz-1 us-west-2-wl1-sfo-wlz-1]

eu-west-1[eu-west-1a eu-west-1b eu-west-1c]

ca-central-1[ca-central-1a ca-central-1b ca-central-1d]

ap-northeast-3[ap-northeast-3a ap-northeast-3b ap-northeast-3c]


⚠ Guya.moe has degraded performance

In 71002c0, Guya.moe (https://baka.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 19070 ms

Resolved: Guya.moe performance has improved in dd26253.


Imp various fixes improvements

Hi @robertdebock
Small proposal here :

force the cron installation
don't use creates in the command executipon so that new domains could be added at each execution. Otherwise it won't be run https://docs.ansible.com/ansible/latest/collections/ansible/builtin/command_module.html#parameter-creates

Hi @robertdebock , any chance to hae a review on this one ?
Regards

Okay, tests will run in a bit. I've just pushed many small changes to all roles, so CI will like start in several hours. I'll try to keep an eye on it.

Hi @robertdebock , changes done!

FIX #6

LGTM, merged. Thanks I'll review the CI tests and fix if required. Good job, thanks a lot!

you're welcome
Your work is awesome !


Fix links in table of contents

A trivial fix to a couple links in the Table of Contents

Coverage remained the same at 98.782% when pulling 100c5a7f3b4eea4ef1510fc37d73036d25a563a8 on Ajedi32:patch-1 into 5733e6138a9fdb3e822ad90e920abd5520115a68 on theupdateframework:develop.

Thanks for fixing the broken links!
I took the liberty of editing your pull request to fix another broken link in the Table of Contents

Coverage remained the same at 98.782% when pulling cabc2d088636e52e44359fabeb96c44ff8d46377 on Ajedi32:patch-1 into 5733e6138a9fdb3e822ad90e920abd5520115a68 on theupdateframework:develop.


Again some of my nitpicks

Brief summary on what I made in this PR:

Add a hyperlink to the DBH logo in the footer.
Add a tip for Proxying page to only use one of the IP addresses.
Add hyperlinks to services which have a official website. (for example: All of the Databases guides).
Merge both ShareX pages into one.
Move UptimeKuma page to Panel Guides.
Add credit for the NVM guide (can be found here).

Also I lied about my last PR being my final one kekw


Stop Explore from defaulting to worldwide in Android

Closes #2032

@kueda I have updated as per your suggestion

@israr002 you've still got one more thing in the checklist to do.

No i have added a comment https://github.com/michalchudziak/react-native-geolocation/issues/272#issuecomment-2349543220

@israr002, I'm asking for a comment in this repo linking out so that in the future when we're wondering why there is this weird OS-specific conditional, we know where to look to check if the underlying bug has been fixed.

@kueda Sry my bad i misunderstood
i have added in the repo

@kueda
The issue you're facing was related to a different problem, which is already being fixed in #1885 . I've synced the code with the latest from main.
Regarding the map tiles issue, it's happening because we're currently passing a hardcoded parameter worldwide: true in the navigation flow. The relevant code is in the TaxonDetails screen:
navigation.navigate("TabNavigator", {
screen: "TabStackNavigator",
params: {
screen: "Explore",
params: {
taxon,
worldwide: true, // Hardcoded value
},
},
});
Before making any changes, I wanted to confirm if there's a specific reason why we're forcing worldwide: true. If not, we can  dynamically set the worldwide parameter based on state.placeMode. Let me know your thoughts!

After your merge, @israr002, it seems to be working, or at least I can't reproduce with the steps in #2032, so I'm going to merge.
Regarding the worldwide: true param on TaxonDetails, I don't think that's related, but the reason that's there is that when you navigate to Explore from TaxonDetails, we want you to see all the observations of that taxon, not just the ones near you.


Add python syntax formattng

I signed it!

Closing this PR as this not against master, please open a new PR against master
CC @mihaimaruseac

@rthadur I created a new PR against master - https://github.com/tensorflow/tensorflow/pull/29520
CC @mihaimaruseac


Executable CLI

[x] CLI into executable
[x] Bundle with jre
[ ] Test on linux
[ ] Test on macos

Closes #31

Try out https://github.com/libgdx/packr

Try out https://github.com/libgdx/packr


Added std:: where it was missing

This is in relation to issue #543 and covers the main places where std:: is missing but there may still be further calls.

:+1:

Okay, so currently Travis doesn't like it if I changed ::tolower to std::tolower. Some other fix is evidently necessary to fix that issue. In my gcc 4.4.2 compiler I am getting:
/../external/clara.h:235: error: '::tolower' has not been declared

Is there a #include <ctype.h>?

Good call @kirbyfan64 will add the missing include into clara.h and catch_common.hpp and put the std:: back in :
#include
Is there an easy way to roll back changes on here (I'm fairly new to using GitHub!)

@Crog You can use the standard set of git commands

Thanks, I will take a look at Git commands soon. For now I can't solve the issue of ::tolower as Travis build system doesn't have a test that replicates a strict conforming environment like I have here :(

Cracked it. GCC reports nicely in some versions about std::tolower having ambiguous overloads. Fixing the ambiguity with the following tells the compiler which function to use and this now builds under QNX and all the Travis Test  :)

:+1:

Apologies for the premature closure - I deleted the branch and it auto-closed all associated PRs - it wasn't intentional.
I also can't re-open it at this point - but I'll come back and review shortly.

I have opened this request again under #559


Improve workflows and actions

In this PR, I have:

Added tests for any new features or bug fixes (if relevant)
[x] Added my changes to the CHANGELOG.md at the top, under the "Unreleased" section
[x] Ensured issues that this PR closes will be automatically closed

Reason for this PR

Improve documentation in our workflow files for users
Update action/workflow dependencies

Links to any solved or related issues
Closes #869
Closes #844
Closes #871
Any manual testing I have done to ensure my PR is working
N/A

@plocket I'm just taking @BryceStevenWilley off as an assigned reviewer. He's welcome to take a look, but I know he just has a few hours and they're mostly for the e-filing proxy server

Makes sense to me!


README does not correct reflect how to run CIS levels

Describe the Issue
The explanation to run tags against cis levels is not correct.
README and files to be updates accordingly.
Expected Behavior
README documents correct way to achieve this

sorted in new PR


libraryfolders.vdf layout changed

It looks like some Steam update changed the layout used in libraryfolders.vdf. Here is an anonymized version from my windows install:
"libraryfolders"
{
	"contentstatsid"		"-9876543210987654321"
	"0"
	{
		"path"		"C:\\Program Files (x86)\\Steam"
		"label"		""
		"contentid"		"-9876543210987654321"
		"totalsize"		"0"
		"update_clean_bytes_tally"		"98765432109"
		"time_last_update_corruption"		"0"
		"apps"
		{
			"111"		"12345678901"
			"210987"		"9998887776"
		}
	}
	"1"
	{
		"path"		"D:\\SteamLibrary"
		"label"		""
		"contentid"		"7654321098765432109"
		"totalsize"		"123456789012"
		"update_clean_bytes_tally"		"11223344556"
		"time_last_update_corruption"		"0"
		"apps"
		{
			"10"		"101112131"
		}
	}
}

This matches the same layout present on my linux install
Notably there is a parse error before any information can be extracted because steamy-vdf has an issue parsing empty strings and the new layout contains the pair "label"        "". Changing the labels' values manually to contain some text gets past the parse error and instead fails on the different layout

If you're open to it I can swap out the parser for the vdf parsing library I made, since steamy-vdf doesn't seem to be maintained.
It would be a breaking change since types from steamy-vdf are exposed directly, but it could be a good opportunity to clean up the public API a bit

Honestly go right ahead. I welcome any of your contributions :D


Add a first-party schedule visualizer

What problem does this solve or what need does it fill?
In traditional OOP-based game development, per-frame logic flow is generally easier to deduce because (usually) the call-stack is the schedule. We don't have that luxury with today's data driven scheduling mechanism.
What solution would you like?
A way to visualize the schedule graph with all ordering constraints displayed. This could (and should) be part of the Bevy Editor when we get there, but a first-party solution now would also be nice.
Recommended Features:

Viewing individual Schedules.
Searching by System Sets and Systems to see their scheduling constraints.
See which Plugins registered which Schedules, System Sets, and Systems.

Also extend this to registered hooks and observers, if possible.

Live visualization of the schedule graph, with the ability to freeze the visualizer at any point for review.
Breakpoint-style visualization freezes whenever a Schedule is modified.

Those last two will be very important for debugging if/when we get runtime schedule modification.
What alternative(s) have you considered?
Continue using bevy_mod_debugdump as-is.
Additional Context
Prior Art: bevy_mod_debugdump

Might be a good idea to add it to CI and serve it up on https://dev-docs.bevyengine.org/ like https://jakobhellermann.github.io/bevy_mod_debugdump/ that is always kept up to date with main.


Missing process.env.PWD on Windows OS - [ERR_INVALID_ARG_TYPE]

This is a Bug Report
Description

What went wrong?
Creating test CLI application and the build crashed.
What did you expect should have happened?
Compile a working build.
What was the config (if any) you used?
It was a standard CLI template config.
What stacktrace or error message did you see?
[ERR_INVALID_ARG_TYPE] The issue is related to the missing env.PWD. I think you should check if the PWD is undefined. I am not sure if the setting of PWD to be process.cwd() will work for all, but it should work for most. It is not related to the powershell as it bugs the same with CMD

Similar or dependent issues:

#1881

Additional Data

Which version of node and npm are you using?: 17.5.0 and 8.5.4
Operating System: Windows 10 64
Stack Trace:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
   at new NodeError (node:internal/errors:371:5)
   at validateString (node:internal/validators:120:11)
   at Object.join (node:path:429:7)
   at KopytkorcReader._getAbsolutePath (C:\Framework\test-framework\node_modules\@dazn\kopytko-packager\src\env\kopytkorc-reader.js:149:17)
   at KopytkorcReader._getKopytkorcConfig (C:\Framework\test-framework\node_modules\@dazn\kopytko-packager\src\env\kopytkorc-reader.js:110:32)
   at new KopytkorcReader (C:\Framework\test-framework\node_modules\@dazn\kopytko-packager\src\env\kopytkorc-reader.js:16:28)
   at Object.<anonymous> (C:\Framework\test-framework\node_modules\@dazn\kopytko-packager\src\env\kopytko-config.js:6:19)
   at Module._compile (node:internal/modules/cjs/loader:1097:14)
   at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10)
   at Module.load (node:internal/modules/cjs/loader:975:32)
   at Function.Module._load (node:internal/modules/cjs/loader:822:12)
   at Module.require (node:internal/modules/cjs/loader:999:19)
   at require (node:internal/modules/cjs/helpers:102:18)
   at Object.<anonymous> (C:\Framework\test-framework\node_modules\@dazn\kopytko-packager\src\core\plugins.js:3:44)
   at Module._compile (node:internal/modules/cjs/loader:1097:14)
   at Object.Module._extensions..js (node:internal/modules/cjs/loader:1151:10) {
 code: 'ERR_INVALID_ARG_TYPE'
}

Provider Error messages:

Hi dejanjankovic,
Thank you for your feedback. We are currently investigating this issue.

Hi, anyone found the solution to the above, having the same issue as below while using React JS
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:120:11)
    at Object.join (node:path:429:7)
    at noopServiceWorkerMiddleware (D:\frontend\node_modules\react-dev-utils\noopServiceWorkerMiddleware.js:14:26)
    at Layer.handle [as handle_request] (D:\frontend\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (D:\frontend\node_modules\express\lib\router\index.js:317:13)
    at D:\frontend\node_modules\express\lib\router\index.js:284:7
    at Function.process_params (D:\frontend\node_modules\express\lib\router\index.js:335:12)
    at next (D:\frontend\node_modules\express\lib\router\index.js:275:10)
    at launchEditorMiddleware (D:\frontend\node_modules\react-dev-utils\errorOverlayMiddleware.js:20:7)
    at Layer.handle [as handle_request] (D:\frontend\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix (D:\frontend\node_modules\express\lib\router\index.js:317:13)
    at D:\frontend\node_modules\express\lib\router\index.js:284:7
    at Function.process_params (D:\frontend\node_modules\express\lib\router\index.js:335:12)
    at next (D:\frontend\node_modules\express\lib\router\index.js:275:10)
    at handleWebpackInternalMiddleware (D:\frontend\node_modules\react-dev-utils\evalSourceMapMiddleware.js:42:7)

In the console, it says Compiled successfully.
Compiled successfully!

You can now view frontend in the browser.

  Local:            http://localhost:3000/
  On Your Network:  http://19x.xxx.xxx.xx:3000/

Note that the development build is not optimized.
To create a production build, use npm run build.


Update Blog “2021-03-01-how-to-edit-the-content”

Automatically generated by Netlify CMS

👷 Deploy Preview for cute-syrniki-fa66d6 processing.

Name
Link

🔨 Latest commit
ee1e05929c71edbf16c23f03cae5c3ad43f6634e

🔍 Latest deploy log
https://app.netlify.com/sites/cute-syrniki-fa66d6/deploys/650b3f9bda89d90008db3877


Pycurl SSL error 77 - CA certificate

Not sure if this is a problem with my current installation or with the program. Getting the following error after I select a book to download:
Download progress: An error occurred for an unknown cause. Exception type:  <class 'pycurl.error'> Message: (77, "SSL: can't load CA certificate file /etc/ssl/certs/ca-certificates.crt") Traceback (most recent call last):   File "/Users/user/libbyfetch/libbyfetch.py", line 387, in <module>     fetch_audio_files(book_title, deweyURL, cookie)   File "/Users/user/libbyfetch/libbyfetch.py", line 338, in fetch_audio_files     do_pycurl_cmd(audio_filename, currentURL, cookie)   File "/Users/user/libbyfetch/libbyfetch.py", line 317, in do_pycurl_cmd     c.perform() pycurl.error: (77, "SSL: can't load CA certificate file /etc/ssl/certs/ca-certificates.crt")
I've tried updating Homebrew, MacOS, X-Code, curl, pycurl and all of the other dependencies. Any ideas would be appreciated.

Let me suggest a few things.
Does a simple curl command work?
Try curl https://www.google.com
If this also fails, it's a system-wide issue with CA certificates.
Check if the file exists at the path indicated in the error message:
ls -l /etc/ssl/certs/ca-certificates.crt
If it does not exist, you may need to install or update the CA certificates. On most Linux systems, use:
sudo apt update && sudo apt install ca-certificates -y
Let me know the results of these efforts.

I experienced a similar result - on linux and then windows. My hacky workaround (definitely not long term ideal) on windows was to go find a ca-bundle.crt already on my machine and use that. Linux I haven't finished debugging since I got the windows side working quickly.

Like @BenjaminMichaelis metioned, Windows 11 was easy to set up for a non-regional library system, but a little hacky: (1) install python (2) install Chrome (3) copy ca-certificates.crt from a linux machine (or could try a hard link in Linux on a shared folder in a virtual machine).  (4) change libbyfetch.py code to point to the cert.
# c.setopt(c.CAINFO, '/etc/ssl/certs/ca-certificates.crt')
c.setopt(c.CAINFO, 'Z://libbyfetch/ca-certificates.crt')

I wasn't sure about trying to get this to work on Ubuntu since Chromium is a snap package now, and spent too much time getting the python virtual environment right.
It works @jdalbey, nice work!

I'm working on an enhancement to resolve this issue in branch dev_issue6.

After some trial and error, I got this to work in Windows 11 by installing certifi (pip install certifi), running python -m certifi to locate the certificate store that certifi had installed, and then replacing the CA certificate bundle path in libbyfetch.py to point to that path instead.:
# c.setopt(c.CAINFO, '/etc/ssl/certs/ca-certificates.crt')
c.setopt(c.CAINFO, '/Python312/Lib/site-packages/certifi/cacert.pem')

(My Windows Python installation is at c:/Python312. Yours may be elsewhere, depending upon the version.)
After that, it worked fine and I was able to download the audiobook MP3s that I wanted.

I'm so glad you could obtain your MP3!
The fix I'm working on that should be platform independent:
c.setopt(c.CAINFO, certifi.where())
It's in branch dev_issue6 waiting for me to test it on different platforms.

Fixed in 3009de5c0b7a312ac2792b099cd39c78c9c8798e.  Used certifi module to get cross-platform CA bundle.


Added pangyp for cross-compatibility build between node.js and io.js.

pangyp decides between node.js and io.js node-gyp versions.
This allows io.js installs to build node-odbc too.

Needed only for  <4.x Node.js versions.
nan package changes break the current master and pull implementation due to V8 major changes.

Node.js 4.0 is here. Next node-odbc changes will fix nan usage.


How to set ks_thresh and pd_thresh?

I notice that there is a hyperparameter ks_thresh in the code, but it does not mention in the paper. How to set it?

@bk820653874 if you have figured it out, please also share it here.


Release Note

Release Note :

Localization
Settings changes

Looks good. I will merge it and check the APK once before releasing it.

Looks good. I will test this once before releasing it. Thanks again.


Classic Tomate Sauce Recipe

https://www.thespruceeats.com/classic-tomate-sauce-996089

Part of 5 Mother Sauces.


ignore integration test crate for code coverage

Currently when you add integration tests it reduces coverage because the integration tests don't have any verifiable test on them and codecov doesn't really know that they are indeed tests. So I think for now to reduce the false negatives in codecov we can just ignore the entire integration test crate for now per this document.

Codecov Report

Merging #517 (2ac120e) into main (eb083a1) will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   60.86%   61.12%   +0.25%
==========================================
  Files          87       85       -2
  Lines       12672    12609      -63
==========================================
- Hits         7713     7707       -6
+ Misses       4959     4902      -57


[Frontend] Scroll to Top Button

Deliverable:

[ ] Make a component scroll_to_top under utility folder that can be imported to all the pages
[ ] The button should take to the top of the page

I'd like to give it a try!

I'd like to give it a try!

I'd like to give it a try!

sure @nehaparmar99 !

I'd like to give it a try!

sure @nehaparmar99 !

@Kajol-Kumari can i also work on this issue

@Kajol-Kumari can i also work on this issue

@Kajol-Kumari can i also work on this issue

sure @kenkirito Go ahead with this issue :)

@Kajol-Kumari can i also work on this issue

sure @kenkirito Go ahead with this issue :)


Method to always start from step 0

When I move to other pages in the middle of tour, I want to always start tour at a beginning without reopening halfway. When I clicked tour start button, why does the start() function after init() not move?
My script:
$(function() {
  var $introduction, tour;
  $introduction = $("#introduction");
  tour = new Tour({
    name: "introduction",
    debug: true,
    backdrop: false,
    orphan: false,
    steps: [
      {
        path: "",
        element: "#introduction",
        placement: "bottom",
        title: "Welcome to My Tour!",
        content: "Introduce theme features by walking through it step by step."
      }, {
        path: "",
        element: "#project",
        placement: "bottom",
        title: "My Project",
        content: "You can confirm latest information here. Let's click a link."
      }
    ],
    onStart: function() {  // *** Why does this event not occur?
      return $introduction.addClass("disabled", true);
    },
    onEnd: function() {   // *** This is OK.
      return $introduction.removeClass("disabled", true);
    }
  });
  $(document).on("click", "[data-introduction]", function(e) {
    e.preventDefault();
    if ($(this).hasClass("disabled")) {
      return;
    }
    tour.init();
    //tour.setCurrentStep(0);  // *** Why is this ineffective?
    // your.start();  // Why does tour not begin?
    tour.restart();
    return $(".alert").alert("close");
  });
  $("html").smoothScroll();
});

Thanks Fotso,
It's working perfectly for me..

vaibhavshaha , You're welcome


How to open service with secured connection

Hi Sir,
When I use HID service , it has secured connection.
But BluetoothLEExplorer will return Access Denied in HID service.
How to fix this problem?
Thanks.

文件詳細資料
⚠ 請勿編輯此區段。 這是 docs.microsoft.com ➟ GitHub 問題連結的必要項。

ID: 65c2a20d-cc06-5e41-2f42-e6da327756d2
Version Independent ID: 633f27d1-83ba-10b9-6200-eb9f6329041a
Content: GattDeviceService.OpenAsync(GattSharingMode) Method (Windows.Devices.Bluetooth.GenericAttributeProfile) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.devices.bluetooth.genericattributeprofile.gattdeviceservice.yml&version=GBlive&_a=contents
Product: uwp
Git Login: eliotcowley
Microsoft Alias: elcowle

Hi, @billtsai999. Thanks for filing this issue, and my apologies for the very long delay in responding.
This feels like a support question about the product, rather than feedback about the documentation (since there's nothing that I can action, as things stand). You got here by clicking Send feedback about > This page. If instead you click Send feedback about > This product, then you'll be taken to the Windows developer feedback site (more info about that below).
Here are all of the developer support resources, for completeness.

The Windows developer feedback site is the right place to lobby for a change, a feature, or to make a suggestion.
For community assistance with development questions, there are our forums, and StackOverflow.
The Windows developer support site explains other support options.
The Visual Studio developer community is available, and responsive. The former User Voice feature is now there on the Suggest a feature tab, if you want to lobby for a change, a feature, or to make a suggestion.
For developer issues, or suspected product bugs, there's Microsoft Support; a support engineer will look at the repro and see whether the issue is a Microsoft product bug, or something else. If it's a bug with a Microsoft product then the ticket will be free of charge.

If you receive assistance via any support resource, and you believe that information would help us improve the docs, then please come back and let us know.
Thanks!
Steve

I'll go ahead and close this issue now since there's no further action we can take here. Please reopen if I made a mistake in closing. ~Steve


Add "new folder" option -- to make starting a new project easier.

I may be doing something wrong, but the experience of starting a new project from within VSCode is clunky / unintuitive.
On the welcome screen and menu, there's "new file" -- but when starting a new project, I'd actually want a new folder.
After all, for existing projects one typically opens the folder, not an individual file, so why should project creation be any different?
As it is, I create the new file, and then when I go to save the the file for the first time, I create a folder using the "new folder" button in the OS's "save as" dialog --
but even then, VSCode's file explorer doesn't switch into that folder.
So, I'd suggest "new folder" as a both a menu item and on the Welcome screen.
For the best UX, you'd then probably want to highlight or make obvious a "new file" button, either in the file explorer sidebar, or in the empty/open folder.

There's "open" -- but presumably that's for existing projects?
Of course, you can create a new folder from withing the system dialog,
but if I'm thinking of the new-user experience, it wouldn't occur to me to use "open" to start a new project.
I'm using Mac OS 11, and latest stable for VSCode.

@vscode-triage-bot @JacksonKearl
Hi, just suggesting we un-close, unless there's been behind-the-scenes discussion (which is fine!).

@ultraGentle
If you are starting a new project then wouldn't "new workspace" be more accurate than "new folder"?
Create "new workspace" can create a folder, create the .vscode folder, and whatever else is needed to get you started.


Remove Java source files and add initial Python setup

whoami is going to undergo major changes. We are switching to using the spaCy dependency parser and rewriting whoami in Python.
We don't want to lose the history of commits, so this PR is replacing the Java source files with an empty Python project structure.

Looks good :)


Use Drum in BaseController to allow generic route references

I am using a custom DirectRouteProvider that overrides the GetActionRouteFactories method of the DefaultDirectRouteProvider in order to allow inheritance in attribute routing.
This allows me to use attribute routing in a BaseController to define route for every action that should be available to all the inheriting controllers (TestController : Basecontroller).
This works fine until I try to generate links to generic routes.
I can't name the routes dynamically based on the generic type as this is not allowed in attributes in C#.
I can't define a name for these routes as there would be many routes with the same name (for all inheriting controllers).
I thought I could use your package as Drum works well with unnamed routes, but I can't seem to find a way to use the uriMaker from inside the BaseController to reference the route from the inheriting controller in a generic way.
Is there a way out?

This pull request might be of interest. Does that look like it would solve your problem?

Thanks for your reply.
But i don't see how this helps me resolve my problem.
What I want is to get a link for a route defined for an action of a web api controller in a inherited BaseController type.
For instance, here is a derived controller:
[RoutePrefix("api/test")]
    public class TestController : BaseController<TestCustomType> { }

Here is the base controller:
public class BaseController<T> : ApiController where T : CustomType
    {
        [Route("")]
        public T Get()
        {
            return new TestCustomType();
        }

what I want is to be able to get a link to the Get action of TestController from within the code of the Basecontroller.


more metrics

Scope & Purpose

Added replication metrics arangodb_replication_initial_sync_bytes_received for the number of bytes received during replication initial sync operations and arangodb_replication_tailing_bytes_received for the number of bytes received for replication tailing requests. Also added arangodb_replication_failed_connects to track the number of connection failures or non-OK response during replication.
Added metrics rocksdb_free_inodes and rocksdb_total_inodes to track the number of free inodes and the total/maximum number of inodes for the file system the RocksDB database directory is located in. These metrics will always be 0 on Windows.

[ ] :hankey: Bugfix
[x] :pizza: New feature
[ ] :hammer: Refactoring
[x] :book: CHANGELOG entry made
[x] :muscle: The behavior in this PR was manually tested
[ ] :computer: The behavior change can be verified via automatic tests

Backports:

[x] No backports required
[ ] Backports required for: (Please specify versions)

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11861/

https://github.com/arangodb/docs/pull/551

@Simran-B : I understand that request, but this would also change the names of the existing rocksdb metrics in ArangoDB.
The metrics names are auto-generated by a single function, and if I change it, all existing consumers of the rocksdb metrics would get a "No data":
https://github.com/arangodb/arangodb/blob/devel/arangod/RocksDBEngine/RocksDBEngine.cpp#L2163-L2174

Tests blue


Power sensor unavailable in template daily using decimals

made a set of sensors for 5 of my outside motion sensors, each consuming 0.5 w like:

and that too creates an unavailable power sensor, and an energy sensor showing fine, albeit 0.0000kWh ofc
This error originated from a custom integration.

Logger: homeassistant
Source: custom_components/powercalc/helpers.py:13
Integration: Powercalc (documentation, issues)
First occurred: 09:55:49 (3 occurrences)
Last logged: 11:07:43

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/config/custom_components/powercalc/sensors/power.py", line 334, in initial_update
    await self._update_power_sensor(entity_id, new_state)
  File "/config/custom_components/powercalc/sensors/power.py", line 387, in _update_power_sensor
    self._power = await self.calculate_power(state)
  File "/config/custom_components/powercalc/sensors/power.py", line 435, in calculate_power
    power = await self._power_calculator.calculate(state)
  File "/config/custom_components/powercalc/strategy/fixed.py", line 63, in calculate
    return await evaluate_power(self._power)
  File "/config/custom_components/powercalc/helpers.py", line 13, in evaluate_power
    return Decimal(power)
decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]

in the log
HA says its a fine template:

Originally posted by @Mariusthvdb in https://github.com/bramstroker/homeassistant-powercalc/discussions/977#discussioncomment-3382126
can confirm when changing that to fixed value 2.5, the power sensor is created correctly:

Yes definitely a bug. Bug is here: https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/sensors/daily_energy.py#L130
This needs to fallback to CONF_VALUE_TEMPLATE when CONF_VALUE is not defined by the user.
Will resolve this weekend and fix will be included in next beta for v0.25

Will be fixed with #981


Manifest diff should be readable by the color-blind

A diff like this

means to some colleagues the same as

So let's be nice to them and add some nice diff markers like other diff tools use, e.g. plus or minus signs or such.

you can run it with --no-color and bosh will add +/-

Ah awesome, thanks!


Pagination is broken

Hello there, and first of all, thank you for this nice model chooser, very useful 👍 .
I probably have found a bug, but I don't see where the problem could be coming from.
Description
When having a lot of model instances to choose from, the admin modal add a "Next" pagination link. This links works fine for me until this specific commit: https://github.com/neon-jungle/wagtailmodelchooser/commit/185cfa12db1ef60aec5dc2981a86ac6a17bb5232
When it works (any commit before this one), the request loads http://<IP_ADDRESS>:3000/admin/chooser/[model_name]/[instance_name]/?ajax=1&p=2
From this commit on, the request points to http://<IP_ADDRESS>:3000/admin/pages/[page_id]/edit/?ajax=1&p=2 which has for effect to load the whole admin inside the modal, and breaks all JS event listeners in the parent page.
I don't see what could be the reason for that problem in this commit, but there must be something.
I can provide more information on demand.
Thanks a lot in advance.

oh dang, I'll try to get to this shortly. In the meantime you can use version 2.2.x

@pierremanceaux  I just tried this out locally and couldn't reproduce it. Is it possible you have an older version of the static files cached?

Thanks for the quick answer @seb-b, much appreciated!
I will play around with the static files soon to see if that can be the cause of the issue and get back to you asap. 👍

@seb-b I have deleted the ./static/ folder, run ./manage.py collectstatic --noinput, clear browser cache, but problem persists. Is there anything else I could do to help?
Are you by any chance on the wagtail slack?

I also have tried the pagination in another modal (native page chooser) and I confirm that the problem affects only the modal from wagtailmodelchooser.

@pierremanceaux Yep I'm on the slack feel free to ping me on there. If you can send through what you have installed I can try with the same versions of wagtail + django + python

Thanks for the help, 2.3.2 has been release for a fix


[BEAM-13102] [Playground] update playground according with the latest design changes

I updated the Playground application with the latest design changes:

New lib:
https://pub.dev/packages/google_fonts (Apache-2.0)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @damondouglas
cc: @pabloem


new dynamic ohe branch due to weird git stuff

Implements changes suggested in Tdcc ohe (PR #2087). Refactors realize_schedule and integrates with new changes to main. Adds correctness and snapshot tests.

@parthsarkar17 what kind of weirdness are you running into with Github CI?

I don't think it was an issue with CI. It was more of a merge conflict that was causing me a little grief. I tried merging into the original branch, but I kept running into issues, and I figured it would be easier to just copy the code onto a new branch off of main. These were the merge issues that @ayakayorihiro was speaking about in #2087. Not the best solution, but it was a bit faster.

Awesome, this all looks good to me-- I say merge when you're ready.
As an aside: eventually we need a more sustainable way to test these new FSM optimizations once we add more and more different splits/encodings of FSMs. We can discuss this better.


[Service Bus Client] Documentation Updates

Summary
The focus of these changes is to update the changelog with a recent community contribution and to reformat doc comments to try to fix a doc generation issue.
Last Upstream Rebase
Friday, January 15, 2:56pm (EST)
Related

Markup mistake in Remarks section (#18025)

Fixes #18025  (maybe?)

Fixes #18025  (maybe?)


Array Operations on Lists

We've been starting to test deepstream in production, at least for a few customers. We are using a custom, PHP client, to do updates for a server side. This does work for the most part. But the subscription nature of updating the records does cause issues sometimes.
In this issue I want to discuss lists. In our use case, we have several static lists that we add and remove records from. We never get rid of these lists, we just maintain them.
In situations of concurrency, its possible that the update fails due to another client updating the list record at the same time. Right now our solution is to retry the update, but its inefficient.
So to solve this I am proposing some additions to the message specification that would allow array operations to be directly to update lists without needing to subscribe. In particular for us, being able to do push and removeElement would cover our cases, but i could see adding additional operations like pop and slice.
I would be interested in building this, but I am looking for thoughts as to whether or not others may find this useful.

We are looking to add a concept of version number -1. What this will do is bypass the version conflict in record transition, load the last object, apply the patch and then save it with the record version + 1.
This will be useful for adding a HTTP endpoint which will allow post requests to update records without having to subscribe first.
Would that solution work for you? The problem is it doesn't exactly support array operations, and lists are essentially just records under the hood. Theres a whole seperate discussion of us making a LIST api, but that requires alot more work and depends greatly on the underlying tech used ( since we would want to retrieve only the last X records from a list using that API as opposed to records which returns the entire json object, and certain things like REDIS supports that, but others don't ).

That would help in another case, but not for lists. I do have a case where the server needs to update the entire object, and it would be easier to not have to subscribe first to do that. For my use case, that is not likely to conflict with a version_exists issue though. Maybe the version of -1 could also bypass any subscription check on the update.
Lists are different for me, in most cases i need to just update the list without reading it as all i need to do is remove or add an element. A list api operations could fix this without significantly changing how lists work.
I can do some research on what Redis, mongo and others support for list operations and propose and API to support it. More than likely we can support everything, it just that some work may have to be done in a connector vs in the storage/message layer itself.
In the meantime, i could add support for the -1 version. That would help simplify my client quite a bit on all other operations.
Using a websocket client in languages like PHP does work. Subscriptions do somewhat complicate things. I think adding more support for more direct operations would allow languages like PHP to work better and could provide the interface needed for a REST interface.

If you could add the -1 version that would be awesome.

I can do some research on what Redis, mongo and others support for list operations and propose and API to support it. More than likely we can support everything, it just that some work may have to be done in a connector vs in the storage/message layer itself.

True, but the question is more of what should deepstream support over what can we get.
When designing an application it isn't unlikely that some lists can become hundreds/thousands elements long. An ideal list API would have a minimum of:

pagination so that you can specify what window you want to view in the list
the ability to send operations such as added, deleted and moved without having to send alot of information over the wire
the ability to do merge conflicts ( pretty complicated with lists )

Are lists indexed only intended to be index records to other individual records? Or can they be used to store other types of data?
The usefulness of pagination is a bit limited without being able to filter, or sort by other record data. Getting a slice of the records, you would have to know what indexes you are already looking for. If record names are the only thing that should be part of a list, then there may be a way to tie this together.
Having the option to get subscriptions automatically for the result set could save some round trips instead of subscribing to all records individually.
Being able to broadcast list updates would be awesome, would limit the scope of data being sent to an event.
If records are intended to be the only content of lists, then automatically removing or adding an item to a list on record creation/deletion would be helpful.
Merging is why firebase avoids 0 indexed arrays, they use a different sort of unique key for all elements.

Keeping this issue open as lists is the killer feature deepstream needs.
It’s also not the easiest to implement and hence will most likely not come to be. Here’s to wishful thinking.


move CI routine to a make target

make test, build, test-style are all called when running make ci

Thanks for the PR @Jan200101 . Please feel free to make more enhancements and submit more PRs.


⚠ Bofrost.at has degraded performance

In f9cdcce, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 917 ms

Resolved: Bofrost.at performance has improved in 03a7085 after 26 minutes.


chore: don't install burrito in test

Current dependencies on/for this PR:

main

PR #166

PR #167   👈

PR #168

This comment was auto-generated by Graphite.


papers

Hello，
Is there any paper about your work？ If yes, can you give me a URL or paper name?
Thkan you.

I don't have any papers for this work, but I am working on a tightly coupled fusion method. If you are interested, I found useful information from Paul Groves' textbook : Principles of GNSS, Inertial, and Multisensor Integrated Navigation Systems, 2nd Edition.


fix: Increase compatibility

fix: #138

Can we move mf temp directory under node_modules?

Can we move mf temp directory under node_modules?

https://github.com/module-federation/vite/issues/74


New version: LanguageServer v1.0.0

Registering package: LanguageServer
Repository: https://github.com/julia-vscode/LanguageServer.jl
Created by: @davidanthoff
Version: v1.0.0
Commit: 65899d3f6388494c553546ff3a46e79f4c98e807
Reviewed by: @davidanthoff
Reference: https://github.com/julia-vscode/LanguageServer.jl/commit/65899d3f6388494c553546ff3a46e79f4c98e807#commitcomment-35735531

If you can't wait 30 mins for automerge, then at least squash merge please.

Sure. Maybe configure the repo to only allow squash merges in that case?


add bodyFile to response part of pair

Hey!
I'm working on https://github.com/SpectoLabs/hoverfly/issues/815 and decided to make a PR so you can tell me if I'm on the right track. Tests pass locally, not sure why they are not run on CI here.
I'll add new tests and update docs after successful review.
Thanks.

@tommysitu thanks for review. only 1 question for now. Does making v6 require copy pasting v5, renaming every struct to v6 and replacing v5 with v6 in all tests and other files?

@tommysitu thanks for review. only 1 question for now. Does making v6 require copy pasting v5, renaming every struct to v6 and replacing v5 with v6 in all tests and other files?

pretty much. also you need to add a function to upgrade v5  to v6 in simulation_views_upgrade.go

@tommysitu ok, got it, but I'm curios :-) wouldn't it be much easier to maintain the project with only 1 schema and avoiding BC? And in case of BC, release new major version with changelog?

@tommysitu ok, got it, but I'm curios :-) wouldn't it be much easier to maintain the project with only 1 schema and avoiding BC? And in case of BC, release new major version with a migration guide (or a tool to upgrade existing files)?

It's a little bit extra work to do but we can ensure all the existing users can benefit from hoverfly upgrades without breaking their tests and CI pipelines. It could spark lots of support issues which is what we try to avoid.

Ok :-) Here we go again.
Now, if bodyFile is not empty, it's read and recorded into body. bodyFile remains in the response for information.
In NewResponseDetailsFromResponse there's no error checking for now, I'll add it tomorrow.
Current tests pass.

Nice, will check it out tmr

I've added error handling when bodyFile is missing.

@tommysitu any chance you can review it soon? :shipit:

@tommysitu any chance you can review it soon? :shipit: so i'll get on docs and tests

this weekends for sure

@ns3777k Thank you for your patience. I've finally got a chance to test it thoroughly. Here is what I found:

If the body file failed to read, it will wipe the existing simulation, because of this line:
https://github.com/SpectoLabs/hoverfly/blob/master/core/handlers/v2/simulation_handler.go#L127
I think this is something I need to fix afterwards

I couldn't get it to read a file relative to the hoverfly binary or the imported simulation. I think what would be really useful is that the body file path should be relative to the simulation file

When both body and bodyFile exists, Hoverfly should pick one or the other, and prints a warning to the user. I would suggest body field takes precedence in this case.

I have fixed the comments above.

Should I fix this? Can you describe the case in more details?

Hmm. Can you show me the failed use case? Relative paths are resolved to the cwd, not the binary. If hoverfly was started from another directory, then the cwd would be that another directory. Starting hoverfly with hoverctl does not set the cwd for hoverfly (https://github.com/SpectoLabs/hoverfly/blob/master/hoverctl/wrapper/hoverfly.go#L173). Will setting the cwd there solve the case?

For now it picks bodyFile and prints no warning. I'll change that this week.

Regarding to the comments:

feel free to fix it if you got some ideas. we shouldn't allow a failed import deleting the simulation that was storing in Hoverfly

Basically I couldn't get relative path working at all. I've tried putting the file in the same directory as hoverfly binary or the simulation file, or the cwd. None of that works.

In the issue https://github.com/SpectoLabs/hoverfly/issues/815,  @BrainStone proposed that the relative path could be relative to the Simulation file. I think that's a good idea, as you can keep these body files side-by-side to the simulation where they can be found easily.
For example, you can store your simulation and body file with this structure:
.
+-- simulations
|   +-- flight_api.json
|   +-- flight_api_responses
    |   +-- 200.json
    |   +-- 400.json

and the bodyFile in your flight_api.json can set to flight_api_response/200.json and flight_api_response/400.json regardless of where you start your hoverfly or use hoverctl.

Thanks for the PR. The fix looks good to me. No need to change the export cmd. As we have given user a warning, we'd expect them to fix the simulation and decide what they want to keep.

Ok, I'll think about it this week
Hmmm. Say I wanna use hoverctl import or API directly to send a pair with bodyFile in response. The simulation file is located locally (on client) but hoverfly service can be run on a different machine and hoverfly binary won't be able to find files relative to simulation file thay was uploaded from a client machine. Am I missing something here? :confused:
Ok, cool

mmm. Say I wanna use hoverctl import or API directly to send a pair with bodyFile in response. The simulation file is located locally (on client) but hoverfly server can be run on a different machine and hoverfly binary won't be able to find files relative to simulation file that was uploaded from a client machine. Am I missing something here?

you're right, it won't work if hoverfly is remote. What about reading the bodyFile is done locally in core/import.go and hoverctl/cmd/import.go? I think that solves the first issue as well.

I've got confused a little :smiley:
So, first off is to patch hoverctl to loop through all pairs, replacing bodyFile with body filled with files' contents. Would be a little tricky 'cause we should unmarshal simulation data, but no problems so far.
Touches only client side, so no BC for server and no need for v6 and supporting bodyFile in schema, right?
Then patch hoverfly import cmd to do the same thing.
Question is: should I keep v6 with bodyFile?

Not entirely sure if reading the bodyFile in the hoverctl import is the right way to go:

It won't work if someone imports the simulation using the Admin API
Any tools that build around the hoverfly Admin API (such as Hoverfly-Java) have to replicate the logic to handle bodyFile.

sorry for contradicting to what I said 😳 . I underestimated the challenges of adding this feature.
So if we keep what you have done, then we must find a way to handle relative path. Any thoughts?
Nevertheless, we should keep the v6 schema.

So if we keep what you have done, then we must find a way to handle relative path. Any thoughts?

Well. As I said before, what about hoverfly cwd process? That did work for me. When we call ioutil.ReadAll, it resolves the relative path against the cwd. Could you show me the failed case?

Here's what I've tried:

make build
start hoverfly binary in the target folder

$ target/hoverfly

copy the body file to the same folder as the hoverfly binary:

$ cp 200.json ~/go/src/github.com/SpectoLabs/hoverfly/target/200.json

import the simulation that has "bodyFile": "200.json",, then it blows up:

$ hoverctl import time.json
Could not import simulation

{"error":"An error occurred: open 200.json: no such file or directory"}{"data":{"pairs":[],"globalActions":{"delays":[],"delaysLogNormal":[]}},"meta":{"schemaVersion":"v6","hoverflyVersion":"v1.1.3","timeExported":"2020-02-19T22:24:11Z"}}

that's correct because your cwd is not target, but the directory where target is at. in other words valid cwd = $PWD.

it's very odd, if I moved hoverfly to any other folder such as
~/Download/hoverfly, then it can find the file in
~/Download/200.json.
but if hoverfly is in
~/go/src/github.com/SpectoLabs/hoverfly/target/hoverfly, then the file needs to be in ~/go/src/github.com/SpectoLabs/hoverfly/200.json

ok, it's relative to where the hoverfly binary is executed.

It can find the file in Download because you probably run the hoverfly from the same directory? If you're on linux (not sure about mac) you run the following command to know the wd of the process: pwdx pgrep hoverfly.
That's usually $PWD unless changed.

race condition :smile: so, there are a couple things left here:

prevent deleting the simulation on failed import
write some tests
write some docs

right?

pretty much. If you can fix #1 that will be great. 🌟 feel free to do 2 and 3 in a separate PR

According to removal the simulation on a file error. I think I've found one easy way to prevent this.

Methods inside Hoverfly::DeleteSimulation should return the removed elements and get saved in the new backup simulation which is returned from Hoverfly::DeleteSimulation.

New method Hoverfly::RestoreSimulation or Hoverfly::ReplaceSimulation should be added to replace the current simulation with the previous backed up in case of error.

Pseudo code:
hoverfly_service.go:
before:
func (this *Hoverfly) DeleteSimulation() {
	this.Simulation.DeleteMatchingPairs()
	this.DeleteResponseDelays()
	this.DeleteResponseDelaysLogNormal()
	this.FlushCache()
}

after:
func (this *Hoverfly) RestoreSimulation(s *models.Simulation) {
	this.Simulation.DeleteMatchingPairs()
	this.Simulation.ResponseDelays = s.ResponseDelays
	this.Simulation.ResponseDelaysLogNormal = s.ResponseDelaysLogNormal
	pairs := s.GetMatchingPairs()
	this.Simulation.AddPairs(pairs)
}

func (this *Hoverfly) DeleteSimulation() *models.Simulation {
	pairs := this.Simulation.DeleteMatchingPairs()
	delays := this.DeleteResponseDelays()
	delaysLogNormal := this.DeleteResponseDelaysLogNormal()
	this.FlushCache()

	s := models.NewSimulation()
	s.ResponseDelays = d1
	s.ResponseDelaysLogNormal = d2
	s.AddPairs(pairs)

	return s
}

In simulation_handler.go we save the simulation returned from DeleteSimulation and pass it to RestoreSimulation in case of errors.
There is a thing I didn't figure out for now. From what I see, ResponseDelays and ResponseDelaysLogNormal can be written in and read from but they are not protected with a mutex.

Sorry for the late reply, I was under the weather. Just looked at your proposed solution, I'm a bit wary about the potential performance impact. We were aware that some hoverfly users have huge simulation files loaded in. It would be great if none of the existing hoverfly users gets much penalty for upgrading.
What about looping through the pair, and testing any presence of bodyFile to see if they are readable instead?
We already have simulationView, err := NewSimulationViewFromRequestBody(body) in the addSimulation, so using function such as  os.OpenFile to test bodyFile  should be relatively simple to do as well.

After thinking about the relative path, we could make it a config option for user to specify where the root path it's relative to. That should solve the problem when user wants to store the file somewhere else rather than the cwd of hoverfly binary.

ignore os.openfile, that was my brain fart. What about os.stat()? It only reads the file metadata. I can’t tell what the actual performance is without a benchmark. I’m suggesting that we should do something to avoid impacting existing users when they upgrade. Alternatively It can do the backup only when body file.

os.stat does not check whether a file is able to be read by the process (e.g. permissions) it can only tell that a file exists. i'll dig deeper soon :-)

Thanks for looking into this!

So, that's what I've come up with (latest commit):

We can avoid additional performance impact if we read the bodyFiles into body right after creating a simulation view (we'll read them anyway later). So we can early return on error before deleting simulations.

I moved the body reading part into PutSimulation method as well as deleting simulation call because I didn't want to read body files inside context of http handler. So basically I encapsulated this piece of logic there so everything is in 1 place.

I've added the configuration option -response-body-files-path, but I suck at naming things :smile: maybe you've gotta better one.

what's the plan? :male_detective: should i start on the docs and tests? or you need some time to review this (last commit should solve previous issues)?

 How urgently do you need this feature?  I'm planning to a bug fix release for v1.1.5 this week. Then this one can go into the next one v1.2.0 with another two issues that need schema changes:
https://github.com/SpectoLabs/hoverfly/issues/807
https://github.com/SpectoLabs/hoverfly/issues/761
What do you think?

No urgency. Just wanted to know the plan :smile:

Also I realized one more thing: you've loaded the file and put it in the body field. so it will show up in the exported simulation. Can we do something about this? Perhaps adding some way to keep track if the body was from the bodyFile and should be excluded on export.

Yes, that's exactly what I asked some days ago https://github.com/SpectoLabs/hoverfly/pull/893#issuecomment-586734806 :smile: I'll think what can be done to avoid this.

This PR is on the right track, I quite like to merge it to the next release branch (https://github.com/SpectoLabs/hoverfly/tree/v1.2.0). Do you mind reopen this issue for merging into the v1.2.0 branch? Then we can tackle the export issue.  Thanks!

also it's quite a long thread, that's probably why I was losing track 😆

I switched the base branch to `v1.2.0


Show team breakdown in attendance report summary graph

The bar graph on the attendance report should be a stacked bar graph showing the distribution of attendance per team per day.

Analytics moved to Metabase


new components id for envoy proxy

Signed-off-by: wbpcode<EMAIL_ADDRESS>Please answer these questions before submitting a pull request

Why submit this pull request?
Add new components id for SkyWalking tracer of Envoy Proxy.

This is related PR: https://github.com/envoyproxy/envoy/pull/13060

Please check if this component id is OK for SkyWalking tracer of Envoy Proxy. @dio @wu-sheng


fix: don't allow cast of Value to Interval,

remote async [Value::try_cast_from_literal, Interval::parse]
remove DataType::Interval cast to Value
remove Value::try_into_interval
Rename From<&Interval> for String to to_sql_str

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

44 of 45 (97.78%)  changed or added relevant lines in 10 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 98.754%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/data/interval/string.rs
11
12
91.67%

Files with Coverage Reduction
New Missed Lines
%

core/src/data/value/mod.rs
1
99.57%

core/src/executor/aggregate/mod.rs
7
82.47%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
44161

Relevant Lines:
44718

💛  - Coveralls


Selection fragment not cleared in some cases

In Scientist:

maybe a fragmenter or update bug?

As this is not critical I am shifiting it to beta 5.

We don't have this anymore.


Update to AutoMapper 6.0

AutoMapper 6.0 was just released with a lot of improvements and bugfixes: https://github.com/AutoMapper/AutoMapper/releases/tag/v6.0.0
I tried to update AutoMapper in my project but get the following exception:
crit: IdentityServer4.Hosting.IdentityServerMiddleware[0]
      Unhandled exception: System.IO.FileNotFoundException: Could not load file or assembly 'AutoMapper, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=be96cd2c38ef1005'. The system cannot find the file specified.
      File name: 'AutoMapper, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=be96cd2c38ef1005'
         at IdentityServer4.EntityFramework.Mappers.IdentityResourceMappers.ToModel(IdentityResource resource)

done


cargo test cannot pass due to csv-rs doesn't support openssl version:806354976

the issue can be found from here:
https://github.com/confidential-containers/guest-components/actions/runs/6105168876/job/16568311628?pr=321
and can be verified locally,
cargo test --features openssl,rust-crypto,offline_fs_kbc -p attestation-agent -p attester -p coco_keyprovider -p kbc -p kbs_protocol -p attestation_agent -p crypto -p resource_uri -p<EMAIL_ADDRESS>
Tried to revert the change here: https://github.com/confidential-containers/guest-components/pull/342, but still doesn't work.
  = note: /usr/bin/ld: /go/src/github.com/confidential-containers/guest-components/target/debug/deps/libcsv_rs-cf8059eec6404d4e.rlib(csv_rs-cf8059eec6404d4e.csv_rs.fbdd6b72ef39f42a-cgu.11.rcgu.o): undefined reference to symbol 'EVP_PKEY_set_alias_type@@OPENSSL_1_1_1'
          /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1: error adding symbols: DSO missing from command line
          collect2: error: ld returned 1 exit status

cc @Xynnn007 @BaoshunFang

cc @jialez0

@chendave csv-rs only support openssl 3.0.x, which is also the version of rust:latest. But the current revision of azure-cvm-tooling set vendored feature to openssl, which will build openssl from source, and the version is 3.1.2. So I think the way to fix the issue is update azure-cvm-tooling to 09a8a0d or newer, this version disabled vendored feature.
CC @jialez0 . same issue as attestation-service.

which will build openssl from source, and the version is 3.1.2.

I think the source is here:
https://github.com/sfackler/rust-openssl
the latest version is 0.10.57
the change from azure-cvm-tooling upstream,
memoffset = "0.8.0"
-openssl = { version = "0.10.45", features = ["vendored"], optional = true }
+openssl = { version = "0.10", optional = true }

so, the bump to 09a8a0d should not work, I have verified, it doesn't work as well.


Build dldt 2020 with OMP on CentOS 7.7 Error

I'm trying to build dldt 2020 on CentOS 7.7. It works with TBB, but failed with OMP.
build command:  cmake -DCMAKE_BUILD_TYPE=Release -DTHREADING=OMP ..
cmake: 3.14.6
gcc: 4.8.5
Kernel:

Here is the error message. It seems that OpenCV is looking for TBB. :(
/usr/bin/ld: warning: libtbb.so.2, needed by ../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0, not found (try using
 -rpath or -rpath-link)
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_scheduler_init::initialize(int)
'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task::note_affinity(unsigned short)'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_group_context::is_group_executi
on_cancelled() const'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::internal::allocate_continuation_prox
y::allocate(unsigned long) const'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_scheduler_init::terminate()'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `typeinfo for tbb::task'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `vtable for tbb::task'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::internal::allocate_root_with_context
_proxy::free(tbb::task&) const'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_group_context::init()'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_scheduler_init::default_num_thr
eads()'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::internal::get_initial_auto_partition
er_divisor()'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_scheduler_init::initialize(int,
 unsigned long)'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::task_group_context::~task_group_cont
ext()'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib[ 88%] Building CXX object ngraph/test/CMakeFiles/unit-test.dir/backend/range_CPU.cpp.o
/libopencv_core.so.4.2.0: undefined reference to `tbb::internal::allocate_child_proxy::allocate(unsigned long) const'
../../../../inference-engine/temp/opencv_4.2.0_centos7/opencv/lib/libopencv_core.so.4.2.0: undefined reference to `tbb::internal::allocate_root_with_context
_proxy::allocate(unsigned long) const'
collect2: error: ld returned 1 exit status
make[2]: *** [../bin/intel64/Release/hello_reshape_ssd] Error 1
make[1]: *** [inference-engine/samples/hello_reshape_ssd/CMakeFiles/hello_reshape_ssd.dir/all] Error 2

``

Disable OpenCV through CMake parameters or use own build of OpenCV (through OpenCV_DIR), see build-instruction.md for details.

Hi @alalek
Disable OpenCV with -DENABLE_OPENCV=OFF works. But there won't be benchmark_app in bin dir. I will try to build OpenCV from source and OpenCV_DIR .

Build passed. Issue closed :)


Enhance: Arrange cart page

Enhancement: Arranged the cart page as shown in the image
Solves issue #65
The cart page currently looks like this after changes:

Kindly review and merge @Bhavya1403 @SubstantialCattle5 @3xpl0itk1t
Thanks :)

Can someone review this PR @Bhavya1403 @SubstantialCattle5 ? Thanks.


Dev

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jawy888 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Review taxonomic profiling

fixed wrong image
small changes in wording
small addition to content
added info on difference to amplicon analysis
added citation

Additional note:
Should the MetaPhlAn part be in the Details ? I think it would be better in the main text.

I put metaphlan in the details because the results are not really good with this dataset. Do you think it should still be in the main text?

I will merge this PR so I can record the video for Smorgsboard. We can update the tutorial later with maybe new dataset where we get better results with MetaPhlAn

all good by me !! I was just wondering about the metaphlan part in a block, but the reason is good !! Great work !


All classification metrics are identical when finetuning network with flash

🐛 Bug
Hi,
I am trying to play around with the ImageClassifier finetune example from flash. However, when I finetune the network, all of my classification metrics are the exact same for any given epoch. Not sure whether this is a bug in my code or something about how flash, torchmetrics, and the bolts callback work.
The code below should reproduce based on a slightly adapted version of the example shown here: https://lightning-flash.readthedocs.io/en/latest/reference/image_classification.html#example.
To Reproduce
from flash.image import ImageClassifier, ImageClassificationData
from flash.core.data.utils import download_data
from pl_bolts.callbacks import PrintTableMetricsCallback
import flash
import torchmetrics as tm

download_data("https://pl-flash-data.s3.amazonaws.com/hymenoptera_data.zip", "./data")

datamodule = ImageClassificationData.from_folders(
    train_folder="data/hymenoptera_data/train/",
    val_folder="data/hymenoptera_data/val/",
    batch_size=16
)

# Threshold at zero since logits are returned
mets = [
  tm.Accuracy(num_classes=datamodule.num_classes, threshold=0),
  tm.Recall(num_classes=datamodule.num_classes, threshold=0),
  tm.Precision(num_classes=datamodule.num_classes, threshold=0),
  tm.F1(num_classes=datamodule.num_classes, threshold=0)
]

model = ImageClassifier(
  backbone='resnet18',
  num_classes=datamodule.num_classes,
  pretrained=False,
  metrics=mets
)

ptb = PrintTableMetricsCallback()

trainer = flash.Trainer(max_epochs=2, callbacks=ptb)

trainer.finetune(model, datamodule=datamodule, strategy="freeze")

This is printed after the second epoch. It can be seen that the value for all 4 metrics are the same within an epoch, and also the callback prints the metrics in duplicate rows for some reason.
val_accuracy│val_recall│val_precision│val_f1│val_cross_entropy
──────────────────────────────────────────────────────────────
0.0│0.0│0.0│0.0│1.4804610013961792
0.4575163424015045│0.4575163424015045│0.4575163424015045│0.4575163424015045│0.735869824886322
0.4575163424015045│0.4575163424015045│0.4575163424015045│0.4575163424015045│0.735869824886322
0.6470588445663452│0.6470588445663452│0.6470588445663452│0.6470588445663452│0.6557145714759827
0.6470588445663452│0.6470588445663452│0.6470588445663452│0.6470588445663452│0.6557145714759827

Expected behavior
I expect the metrics to be different.
Environment

PyTorch Version: 1.8.1
PyTorch Lightning Version: 1.4.7
Lightning Flash Version: 0.5.0
Lightning Bolts Version: 0.4.0
Torchmetrics Version: 0.5.0
OS: MacOS
Python version: Python 3.7.0

Try changing the average method from micro to macro. Under the default micro average the formula for the metrics may be the same.

I came across this same problem. Your solution didn't work and I haven't really understood why micro would be an issue. Would you mind explaining further please? specificity, recall and accuracy are showing identical metrics. F1 is now different after the recommended change.

have the same value for accuracy


Any chance of React 16 support?

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.3.0-0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^15.3.0-0 but none was installed.

Get this warning when transitioning to react 16. It still works fine from what I can see.

I will have a look

Many thanks :) I think it just needs an addition to the peerDependencies

I just published version 1.5.0 on npm with updated peer dependencies.
regards

Thanks @RRutsche 👍 👍


Missing function to ->get user from API

If a user id is valid but the bot doesn't already have the user stored in the UserRepository, an attempt to get the user will always fail.
$user = $discord->users->get('id', $result);
$username = $user->username;
$discriminator = $user->discriminator;
$id = $user->id;
$check = "$username#$discriminator";
$exist_string = "This ckey is registered to $check (<@$result>)";
$message->channel->sendMessage("$ckey joined byond on $joined. $exist_string");

DiscordPHP needs a function similar to Yasmin's fetchUser which queries the API to retrieve the user information by using a react promise:
/**
 * Fetches an User from the API. Resolves with an User.
 * @param string  $userid  The User ID to fetch.
 * @return \React\Promise\ExtendedPromiseInterface
 * @see \CharlotteDunois\Yasmin\Models\User
 */
function fetchUser(string $userid) {
    return (new \React\Promise\Promise(function(callable $resolve, callable $reject) use ($userid) {
        if ($this->users->has($userid)) {
            return $resolve($this->users->get($userid));
        }

        $this->api->endpoints->user->getUser($userid)->then(function($user) use ($resolve) {
            $user = $this->users->factory($user, true);
            $resolve($user);
        }, $reject);
    }));
}

This is resolved.
$discord->users->fetch("$result")->then(
	function ($user) use ($author_channel, $ckey, $joined, $result) {
		//$user = $discord->users->get('id', $result);
		//$user = $discord->users->fetch($result); echo "user class: " . get_class($user) " . PHP_EOL;
		$username = $user->username;
		$discriminator = $user->discriminator;
		$id = $user->id;
		$check = "$username#$discriminator";
		$exist_string = "This ckey is registered to $check (<@$result>)";
		$author_channel->sendMessage("$ckey joined byond on $joined. $exist_string $whitelist_string");
	},
	function ($error) {
		var_dump($error);
	}
);


Reimplement Jaxley's ionotropic synapse with solver options

The form of the synapse doesn't actually seem to involve solving a differential equation per se, so maybe this can actually be avoided


Move away from Cloudflare for DNS change instructions

The current site (https://<IP_ADDRESS>/dns/) is a pretty good guide, but the first thing it shoves in a user's face is essentially an advert to download an app, which could confuse the non-tech savvy users the guide is for.
I'm not sure of any alternatives though, just wanted to start a discussion after some confusion in the support channel.

Changing the url to https://<IP_ADDRESS>/dns/#setup-instructions might be worth doing.

For what it's worth, some companies (at&t/centurylink) assign <IP_ADDRESS> to their modems. So this because the login page for their own network.