Example Nginx configuration

do you have an example nginx config you can share to use this?
will this work for submodule dependencies? like when a root module is defined like :
module "consul" {
  source = "hashicorp/consul/aws"
}

will it server the traffic as inpersonating registry.terraform.io or you need to change the source?

no problem, thanks
On Thu, Jun 16, 2022 at 6:01 PM Jason Barnett @.***>
wrote:

@jamengual https://github.com/jamengual When I originally wrote this I
was narrowly thinking about providers, not modules. Let me take a look at
this and get back to you in a few weeks.
—
Reply to this email directly, view it on GitHub
https://github.com/jasonwbarnett/terraform-registry-proxy/issues/1#issuecomment-1158358831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQ3ERHY5GLSKE3KHKGJ6MLVPPE7JANCNFSM5WQSXO2A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update talk admin class

Create TalkAdmin class than can do following:

filter by: type, duration, status, event (try and add if you like this filter)
list view, show fields: title, type, status, event, speaker (try and add if you like this filter)
group form fields:

description: title, abstract, evet
details: type, status, duration, speakers

any other improvements, welcome...

working on it

PR merged. Thanks.


Redo Rebalancing Set Exchange Issuance Module

Pull Request Test Coverage Report for Build 6003

14 of 49 (28.57%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.5%) to 96.473%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/core/tokens/rebalancing-libraries/StartRebalanceLibraryV2.sol
0
35
0.0%

Totals

Change from base Build 5995:
-3.5%

Covered Lines:
850

Relevant Lines:
885

💛  - Coveralls


Custom event for 'drawEnd'

Looking through the source and the examples, I'm trying to establish how to create a custom event handler via addEventHandler when the draw of the chart has finished. I can see how to create the event handler and emit it, but how exactly would your trigger the emit within the source creation of the svg?

Hey guys, kudos for this solution! The created event works perfectly!


(maint) Skip autoload tests on masters

The tests for autoloading resource types from generated types made the
assumption that Puppet masters are not Puppet agents. This assumption
depends on the beaker configuration used, and in many cases a master is
also classified as an agent. In this particular test the log files for
the agents must be empty while the log files for the master must be
populated, or vice versa.
Since the existing tests already have special cases for the master, this
commit resolves the issue by excluding the master from agent tests.

CLA signed by all contributors.


Format decimals with ENGLISH locale

Why is this needed? In other words, what was the problem and how does this fix it?

On my PC with Polish locale decimals were formatted as 1,23, which is not supported by Presto


No 'back' option during onboarding

When going through the on boarding there is no option to go back to previous pages.
May be something some users want.

I think on the front-end this should be easy enough, but is there any issues with this on the backend for instance if a user has already entered their password or node info?

we got this now \o/


On OSX adding a Bridged adapter to VirtualboxIP causes problem

IP: <IP_ADDRESS> is not in the cert's list: <IP_ADDRESS>
It seems that the new address gotten by the Bridged adapter is causing trouble.
I can't start a container via Kinematic anymore
Edit:
also docker-machine ls
gives
NAME      ACTIVE   URL          STATE     URL                        SWARM   DOCKER    ERRORS default   -        virtualbox   Running   tcp://<IP_ADDRESS>:2376           Unknown   Unable to query docker version: Get https://<IP_ADDRESS>:2376/v1.15/version: x509: certificate is valid for <IP_ADDRESS>, not <IP_ADDRESS>
which seems to indicate that the problem doesn't come from Kinematic proper.

If docker-machine can't communicate with the VM, then Kitematic wont be able to either - The issue you're seeing is simply due to the new IP and the fact that the certs were made for the previous IP.
You should be able to regen the certs and fix all this:
docker-machine regenerate-certs default

Not to hijack this issue, but I am having the same problem as @nodje. When I use docker-machine regenerate-certs default as suggested, the certs regenerate fine, but there's now a second error which is preventing me from using Docker:
_This machine has been allocated an IP address, but Docker Machine could not
reach it successfully.
SSH for the machine should still work, but connecting to exposed ports, such as
the Docker daemon port (usually :2376), may not work properly.
You may need to add the route manually, or use another related workaround.
This could be due to a VPN, proxy, or host file configuration issue.
You also might want to clear any VirtualBox host only interfaces you are not using._
Any advice? Thanks.

@bcooney it sounds like some Vbox network issues - If the VM is brand new (aka it can be blown away) then I would do just that via docker-machine rm default and re-create one by opening Kitematic

Closing this issue due to lack of update/activity - Feel free to re-open if appropriate.


Starter Renders Black Screen

I am trying to use the scripts from getting started.
Running the following gets me a black screen:

react-native init MyApp --template reason
yarn watch after adding

"scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest",
    "build": "bsb -make-world -clean-world",
    "ios": "react-native run-ios",
    "watch": "bsb -make-world -clean-world -w"
  },

HelloWorld yarn watch
yarn run v1.13.0
warning ../../../package.json: No license field
$ bsb -make-world -clean-world -w
Cleaning... 24 files.
Cleaning... 424 files.
[14/14] Building src/ReasonReactOptimizedCreateClass.mlast.d
[7/7] Building src/ReactDOMRe.cmj
[279/279] Building src/components/touchableWithoutFeedback.mlast.d
[139/139] Building src/animated-BsReactNative.cmj
>>>> Start compiling
[2/2] Building src/App.mlast.d
[1/1] Building src/App.cmj
>>>> Finish compiling 133 mseconds
>>>> Start compiling
[2/2] Building src/App.mlast.d
[1/1] Building src/App.cmj
>>>> Finish compiling 145 mseconds

Start react-native, yarn start

HelloWorld watchman watch-del-all
{
    "version": "4.9.4",
    "roots": [
        "/Users/prisc_000/working/HelloWorld/HelloWorld"
    ]
}
➜  HelloWorld yarn start --reset-cache
yarn run v1.13.0
warning ../../../package.json: No license field
$ node node_modules/react-native/local-cli/cli.js start --reset-cache
┌──────────────────────────────────────────────────────────────────────────────┐
│                                                                              │
│  Running Metro Bundler on port 8081.                                         │
│                                                                              │
│  Keep Metro running while developing on any JS projects. Feel free to        │
│  close this tab and run your own Metro instance if you prefer.               │
│                                                                              │
│  https://github.com/facebook/react-native                                    │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

Looking for JS files in
   /Users/prisc_000/working/HelloWorld/HelloWorld

warning: the transform cache was reset.
Loading dependency graph, done.
 BUNDLE  [ios, dev] ./index.js ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100.0% (594/594), done.

::1 - - [09/Mar/2019:11:10:54 +0000] "GET /index.bundle?platform=ios&dev=true&minify=false HTTP/1.1" 200 - "-" "HelloWorld/1 CFNetwork/975.0.3 Darwin/17.7.0"
 BUNDLE  [ios, dev] ./index.js ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100.0% (1/1), done.

::1 - - [09/Mar/2019:11:11:37 +0000] "GET /index.bundle?platform=ios&dev=true&minify=false HTTP/1.1" 200 - "-" "HelloWorld/1 CFNetwork/975.0.3 Darwin/17.7.0"

Start ios, yarn ios.

...
** BUILD SUCCEEDED **

Installing build/Build/Products/Debug-iphonesimulator/HelloWorld.app
Launching org.reactjs.native.example.HelloWorld
org.reactjs.native.example.HelloWorld: 21687
✨  Done in 38.60s.

Result in Simulator:

Im not getting any errors to chase here. Any guidance would be appreciated. Thank you.

Solution can be found here: https://stackoverflow.com/questions/54654224/black-screen-after-modifying-index-js.

Can you tell what it's in your index.js?

I faced this problem last time I used the template, I would like to fix this.

Just added styles to a the project after creating with react-native init MyApp --template reason
index.js
import { AppRegistry } from "react-native";
import App from "./App.bs";

AppRegistry.registerComponent("App", () => App);

AppRegistry.runApplication("App", {
  rootTag: document.getElementById("root")
});

https://gist.github.com/idkjs/6d080f501f5f9e0369da327cece19d0d

Running the updated starter script now renders something to the screen but only after you update bs-platform to "bs-platform": "^4.0.18", in my case.
After the error I changed bs-platform then re-ran yarn install
rnwebdataapp yarn watch
yarn run v1.13.0
warning ../../../package.json: No license field
$ bsb -make-world -w
Error: spawnSync /Users/prisc_000/working/AMP/rnwebdataapp/node_modules/bs-platform/lib/bsb.exe ENOENT
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
➜  rnwebdataapp yarn
yarn install v1.13.0
warning ../../../package.json: No license field
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "jest > jest-cli > @jest/core ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "jest > jest-cli > jest-config ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[4/4] 🔨  Building fresh packages...
success Saved lockfile.
✨  Done in 11.02s.
➜  rnwebdataapp yarn watch
yarn run v1.13.0
warning ../../../package.json: No license field
$ bsb -make-world -w
[14/14] Building src/ReactDOMRe.mlast.d
[7/7] Building src/ReactDOMRe.cmj
[279/279] Building src/components/scrollView.mlast.d
[139/139] Building src/animated-BsReactNative.cmj
>>>> Start compiling
[2/2] Building src/App.mlast.d
[1/1] Building src/App.cmj
>>>> Finish compiling 100 mseconds

I will push an updated template that looks just like the default rn hello world. That should improve the situation. I will close as soon as @grabbou gave me npm rights to publish a new version of react-native-template-reason.

poke @grabbou

My npm name is "moox" :)

@cknitt what do you think about using react-native-template-bs name instead of current react-native-template-reason (since we are sticking to bs- namespace)?

@MoOx I don't know, I think I'd rather keep "reason". Weren't you considering naming the npm package for the new bindings "reason-react-native"?

@cknitt We discussed about that with @chenglou (reason- prefix), and we are not sure that a good thing, as this bindings, especially since we moved to zero-cost without abstraction, are purely bucklescript stuff. I am wondering if we should deprecate the previous template & use -bs suffix for the new one.

@MoOx Ok, somehow I missed the discussion with Cheng.
In any case, I guess people new to Reason would be looking for a "-reason" template rather than for a "-bs" template.
Also, "-reason" is correct in the sense that there is an App.re in the template and not an App.ml. So I do not really see a reason to change the prefix.

Fair enough. Will keep it that way.

<EMAIL_ADDRESS>is out & should make the situation better


DlImageSkia does not use a Skia unref queue wrapper

DlImageSkia is one of the few objects left that holds an object that might need to be unref'd on a GPU thread, but it does not protect its GPU resource from those unrefs by using something like a SkiaGPUObject wrapper.
As a result, its queueing issues are promoted to affect any object that holds a DlImageSkia object and thus to any object that holds a DlImage object and thus ... to dozens of other objects that themselves don't hold any actual resources.
See https://github.com/flutter/flutter/issues/122634
See https://github.com/flutter/flutter/issues/33086

It looks like DlImageSkia is used primarily from test code where we only have one thread anyway. For these uses we should create a test class that holds a Skia image using only an sk_sp and find a different way to manage images from the few other places where we are managing a Skia image that may be owned by the UI thread. There is already a DlImageGPU class that holds a SkiaImage in a GPUObject wrapper - those cases should use that existing class instead.


Line 359 applyToTen typo fixed

Line 359 was "applyToThen". Fixed to correct "applyToTen".

Thanks for the fix.


Fix invalid navigation listener.

Fixed the navigation listener

Codecov Report

Merging #33 (a8a9647) into main (c62aa7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   89.77%   89.77%
=======================================
  Files          41       41
  Lines         626      626
  Branches      109      109
=======================================
  Hits          562      562
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62aa7b...a8a9647. Read the comment docs.

cc @joeldmyers This fixes a navigation issue that we have discovered recently. There is no this in a functional component. Please make sure it makes its way all the way to prod-beta. Probably to prod-stable as well.

@Hyperkid123 OK I just started deploy to prod-beta. Our app is not currently deployed on prod-stable at the moment (we are still awaiting some RBAC-related API work), so I don't expect we'll push to prod-stable now. Thanks!


Add support for RFC 0023: DID Exchange

Spec: https://github.com/hyperledger/aries-rfcs/tree/b3a3942ef052039e73cd23d847f42947f8287da2/features/0023-did-exchange
Requires:

[x] https://github.com/hyperledger/aries-framework-javascript/issues/344
[x] https://github.com/hyperledger/aries-framework-javascript/issues/343
[x] Add support for RFC 0023: DID Exchange

Fixed in #717, outstanding issues tracked in #764


Enabled perlcritic on misc-scripts

I don't know if misc-scripts was intentionally skipped, but it contains 76 non-compliant perl files

misc-scripts is full of legacy scripts which are not much used/maintained any more, so it is not worth going back through them to make them perlcritic compliant
I think we will leave the test out for the moment, thanks for the suggestion though


Can't Connect

Every time I try to connect, it shows dialogue with title "Error in Configuration" and the message "You must select a user certificate"

Your FileDetails.json is invalid. Remove the whitespaces and replace newlines with \n. It should work. Also, check through your ovpn file for quotation marks like ("), ('), and (`). These will not allow the activities to parse your JSON property, so remove them from your ovpn file before pasting it into your FileDetails.json.


Analyze prebuilts for common repo

The following prebuilt packages are included as dependencies in source-build by common.  These need to be analyzed to determine how to avoid requiring packages that source-build doesn’t build.

Change to use the source-built version
Package is not critical to product and can be removed.  (i.e.test-specific, windows-specific, etc)
The package is used as reference only
The package should be built in source-build
Other – please elaborate on what you think should be done.

For more detailed usage information for these, please see the Usage Exploration tab of the SourceBuildPrebuiltReport.

PackageName
PackageVersion
SourceBuiltVersion
Category

System.Console
4.0.0

Removal dependent on #849

System.IO
4.1.0

Removal dependent on #849

System.Linq
4.1.0

Removal dependent on #849

If it were me, I would close this in favor of https://github.com/dotnet/source-build/issues/849 or https://github.com/dotnet/source-build/issues/890. We're not planning on making any changes to aspnet/common's 1.x branch. It exists in source-build only to serve NuGet.Client.

@rrelyea Can you comment on whether #849 "Move Microsoft.Extensions.CommandLineUtils into NuGet repository" is doable to clean this up?

All direct-dependency prebuilts removed.


Google assistant audio autput

Hi, there is a way to get the assistant response as a google assistant audio output? Now i get only text output. I enalbed the google assistant in the response section of the intent.

Hi, you can now use Adding Speech Response to Detect Intent Requests
Let me know if that helps. :)


Add Link to Github Repository

Added a link to the github repository of your project.

Awesome thanks 👍


[TOPI] Add handwritten matvec for dynamic cases

Add a handwritten matrix-vector multiplication implementation for dynamic cases on cpu. This avoids crashing when a dynamic shape is present. Only supports vector LHS and float32 for now.

@jwfromm a change: the dynamic kernel usage is predicated on it being a matrix-vector multiply instead of asserting within the kernel. Apparently there are some other code paths that do dynamic matmul that I broke.

Yeah that makes perfect sense to me, good change.

@tvm-bot rerun

@tvm-bot rerun

@tvm-bot rerun


Add GitHub Action JavaScript_tests

I didn't know that Jest work like this, do you have any example?

Hi @cclauss,
I'm starting moving all .js file to its folder, and I will use Jest + EsLinter + Prettier


'this' is undefined on the server side

Upon upgrading to 2.0 the server side rendering broke:
To render numbers and dates in an i18n compatible way I'm using numeral.js and moment.js. Both of them are written in a way that uses this as the global object, like
(function () {
    // here, `this` means `window` in the browser, or `global` on the server
    // add `numeral` as a global object via a string identifier,
    // for Closure Compiler 'advanced' mode
    this['numeral'] = numeral;
}).call(this);

Or
(function (global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
    typeof define === 'function' && define.amd ? define(factory) :
    global.moment = factory()
}(this, function () {
    var _moment;
    ......
    return _moment;
});

They are both valid in a browser or a node.js environment, but the following fails:
ReactConfig.cs:
ReactSiteConfiguration.Configuration
    .AddScript("~/Scripts/numeral.js")
    .AddScript("~/Scripts/my-component.js");

Index.cshtml:
@Html.React("MyComponent", new { prop1 = "prop" })

Since it cannot set the property 'numeral' of undefined.
This pretty much blocks me from upgrading to React.Core 2.0 and therefore React 0.14.

Thanks for the report, I'll take a look this weekend. This may be due to how Babel handles this compared to JSXTransformer.

Looks like I need to blacklist the "strict" transformer. From the Babel docs:

Why is this being remapped to undefined?

Babel assumes that all input code is an ES2015 module. ES2015 modules are implicitly strict mode so this means that top-level this is not window in the browser nor is it exports in node.

If you don't want this behaviour then you have the option of disabling the strict transformer:

$ babel --blacklist strict script.js
> ```js
require("babel").transform("code", { blacklist: ["strict"] });

You could try hacking this into the ReactJS.NET Babel config:
{"blacklist", new List<string> { "strict" } }

If you do try that out, let me know if it works :)

Fixed in 2.0.1, thanks for reporting!

Works perfectly, thanks.


Multiple CSS cases around this documentation bug

Suggesting a change as per https://identitydivision.visualstudio.com/Hybrid Identity/_workitems/edit/627281.

Thanks

#sign-off

@billmath , could you please help incorporate this change to the public doc? Thank you! 👍

#sign-off

Manual merge performed due to merge conflict.  Will now close this pr.


chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-key-protect-all-inclusive
module
minor
v4.7.0 -> v4.8.2

github.com/terraform-ibm-modules/terraform-ibm-resource-group
module
patch
v1.1.4 -> v1.1.5

terraform-ibm-modules/cbr/ibm (source)
module
patch
1.19.0 -> 1.19.1

Release Notes

terraform-ibm-modules/terraform-ibm-key-protect-all-inclusive (github.com/terraform-ibm-modules/terraform-ibm-key-protect-all-inclusive)
v4.8.2
Compare Source
Bug Fixes

resource_group_id is only required if creating KP instance (#421) (6cfc5fa)

v4.8.1
Compare Source
Bug Fixes

Update DA to claim from "CIS IBM Cloud Foundations Benchmark" profile (#420) (ca3a356)

v4.8.0
Compare Source
Features

Created DA solution (#418) (e60edb5)

v4.7.1
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#416) (c366731)

terraform-ibm-modules/terraform-ibm-resource-group (github.com/terraform-ibm-modules/terraform-ibm-resource-group)
v1.1.5
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#581) (5552c65)

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.19.1
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#407) (c62077d)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.6.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


update data in demo

(1) token4 is the results of 10%, update it to the correct one.
(2) test the acceleration on devices, the actual acceleration on devices are 22% on RK3288 and 16% on iOS.

The latency of MobileNetV2 (output: fc) is 218.177ms; the latency of token2 is 170.905ms. The acceleration is 22%.

(1) token4 is the results of 10%, update it to the correct one.
(2) test the acceleration on devices, the actual acceleration on devices are 22% on RK3288 and 16% on iOS.

这个里面MobileNetV2的latency是30.6538ms, token4对应模型的latency是25.7241ms。加速是16%。

The latency of MobileNetV2 (output: fc) is 84.2464ms; the latency of token3 is 66.8286ms. The acceleration is 20.67%.


MSID: 89311 Version: 1 DOI: 2<IP_ADDRESS>5687v3

"msas": "Neuroscience"
"msid": "89311"
"preprintDoi": "10.1101/2<IP_ADDRESS>5687"
"Reviewed Preprint posted": "2023-05-25"
"Sent for peer review": "2023-05-26"
"Posted to bioRxiv": "2023-05-11" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>5687v3.full/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=89311)

or (only one should be ticked. remove other from description.)

[ ] Confirmed with Ted at bioRxiv that MECA archive is available

Send the following email to Ted and wait for his reply.
Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/89311/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5687)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/89311/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/89311)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/89311

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/89311

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/89311/v1/89311-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/89311)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from reference list

The dates at the top of this ticket for peer review and the preprint publication were wrong. I have corrected them.


Automatically generate a road training set based on OpenStreetMap

We need a training set with road masks for the areas we have high-resolution satellite imagery for.
Repeat process in https://github.com/mapbox/robosat/issues/15 with roads. The tag we care about is highway=*. In OpenStreetMap:

https://wiki.openstreetmap.org/wiki/Highways
https://wiki.openstreetmap.org/wiki/Key:highway

For road width in addition to width and lane tags:

parking:lane=*
cycleway=lane
busway=lane
expressway=*

Problems and open questions:

Roads in OpenStreetMap are modelled with ways and not polygons. Which means we can only guestimate their width (look into road width and lane tags) to create a mask for them. We can also use the highway classification (think: primary vs service roads).
The road classification does not have to be consistent. A primary road in SF could be tagged secondary in DC. Does it make sense to create our own road classes, e.g. paved / unpaved?
Do we want a binary road / not road binary classifier or do we e.g. want to be able to detect link roads? Can we distinguish link roads from the imagery?

Tasks:

[ ] Check which highway tags we want
[ ] Check if highway classification is the same across geographies
[ ] Check which tags to use for road width estimation
[ ] Implement osmium handler for rs extract
[ ] Spec out ticket for road post-processing

Need help here, @daniel-j-h?  Would love to discuss ...

Yes sure, if you want to help here that would be amazing! Here are some notes for how to approach this:

You need to add a new handler for rs extract (e.g. robosat/osm/roads.py) which turns OpenStreetMap way geometries into polygon shapes. Take a look at the existing handlers.
You need to import and add the road handler then in robosat/tools/extract.py
In the road handler you need to filter out every way that does not have the highway=* tag
In the road handler you need to estimate the road width based on tags like: width, lane tags, parking=lane, cycleway=lane, busway=lane, expressway=*. And if no such tags are available come up with a reasonable default. Note: from experience, it doesn't have to be super precise the model will learn from lots of images and work with his kind of noise.
You can then buffer the way with your width estimate to turn the way linestring into a polygon shape.
You need to think of edge-cases like steps. Do we want to include them? Maybe not. Both paved and unpaved roads? Maybe. Should it depend on the zoom level? Maybe.

You can put the way object into a shapely shape. Then use the buffer function to turn it into a polygon. And then use the mapping function to go back from shapely shape to geojson.

http://toblerity.org/shapely/shapely.geometry.html#shapely.geometry.base.BaseGeometry.buffer
http://toblerity.org/shapely/shapely.geometry.html#shapely.geometry.geo.mapping

Hope that helps; let me know if things are unclear.

About the road width estimation, how's it going? Could we just simply give fixed value according to some standard.

@DragonEmperorG implemented this in https://github.com/mapbox/robosat/pull/111.
We should open up a new ticket about roads post-processing and how to best implement it.


⚠ GitLab Server has degraded performance

In 6052602, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11547 ms

Resolved: GitLab Server performance has improved in fd8b82b.


Add support for downloading the test report for other test frameworks than Appium and uitest

Currently the tool allows one to download the test reports when the test framework is either Appium or uitest. This makes it impossible to publish the report when the test run is triggered from an external system like CI.
The test reports for Appium and uitest can be downloaded to the triggering system using either the --test-output-dir option for the test run command or using the test download command. It would be beneficial if both of these options would work also for all the other test frameworks.

Hi @JussiPekonen,
Thanks for getting in touch! Could you provide more details about your request? It would be helpful if you could share a real-life example. Please specify the test framework you'd like to use, the process for uploading to App Center, and your preferred method for downloading it. Your clarification will assist us in better understanding your needs.

Hi,
In principle the setup I would like to have is that there is a CI job (GitHub Actions, Azure Pipelines, GitLab CI, CircleCI, Jenkins, pick your poison) that would trigger a test run on AppCenter. These CI systems have the capability to report the test run results in the job results, making it "easy" to see what is possibly wrong with the tests when the CI system notifies one for the failed job. Now one must visit AppCenter to actually see the test results.
Now, if the test are using anything else than Appium or uitest such as Espresso (native Android) or XCUITest (native iOS), there is no option to get the test results in a format that the CI system supports (such as jUnit test result XML output). What I would like to have in the CLI tool to have an option to get the test results downloaded to the triggering system if one wants to get the test results from the test run. This could be achieved by having the --test-output-dir option to define a job to where the test outputs are written.
Furthermore, when one has a mix of tests that are run both on the CI host (such as unit tests) and on AppCenter, there is no possibility to see the aggregated test results from all tests. With this option one could get the AppCenter test results to the CI host and the aggregated test results would be available on the CI host.

@JussiPekonen , We support downloading test results for all the supported test frameworks.
Do I understand correctly that you were able to successfully run your uitests on App Center, and couldn't download the test report? To assist you better, could you provide additional information? Specifically, what test framework was used, the command you used to start the test run and the command you used trying to download the report.
Regarding the task of aggregating test results gathered from both your CI system and App Center, this process would require creating a consolidated report manually. You'll need to convert the test report formats from both sources into a unified format to achieve this.

Okay, so is this then a documentation issue? Because according to the test download command help this would be available only for UITest and Appium:
$ appcenter help test download

Download the report artifacts, unpack and merge them. This command is only available for UITest and Appium test runs.

I can of course test this myself with the Espresso/XCUITest runs I have done, but if it is indeed documentation issue, then the documentation should be updated accordingly.

Did a quick test with the download command using an old Espresso test run and it failed with the following error (fetched using --output json for more verbose output):
{"succeeded":false,"errorCode":3,"errorMessage":"XML reports have not been created"}

The command did return the overall status of the run just fine, the message rows match what the test run report on AppCenter says.

Any updates on this? According to the test run documentation there is way to define that the test report XMLs would be generated for Espresso or XCUITest frameworks.

@JussiPekonen , I'm sorry for the confusion. We only support xml reports for uitest and appium. There is only status report for others, as you already figured out.

@JussiPekonen we do not have plans to add support for more report types in the next year, so I'm closing this issue.

Thanks. Knowing that it is in the plans is enough for us. Do you have a preliminary schedule for that update? Just asking, so that we know when to expect it to be available.

We have no plans.


Download source file wrong when resolve eclipseClassPath when has classifier

apply plugin: 'java'
apply plugin: 'eclipse'
repositories {
mavenCentral()
}
dependencies {
compile (
'net.sf.json-lib:json-lib:2.4:jdk15'
)
}
When try to run gradle eclipseClasspath
Gradle download json-lib-2.4-jdk15.jar OK
But will not download json-lib-2.4-jdk15-source.jar.
It seem gradle try to download json-lib-2.4-source.jar which is wrong name

This is likely a bug where we don't use the classifier for resolving the corresponding sources JAR file. Would you be interested in providing a fix for it?


QMSI 1.3.1 Release

This is a code drop for QMSI 1.3.1
Signed-off-by: Malcolm Prinn<EMAIL_ADDRESS>

LGTM


Integrate with CAPI e2e test framework

As discussed in issue 25, I have init-ed work for e2e. Summary for my work:

Add the e2e test under test/e2e ( I mainly followed cluster-api-provider-rke2)

Add two simple test specs in test/e2e/e2e_test.go

create_test:  Create a cluster with 1 controlplane and 3 workers.
node_scale_test: Create a cluster with 1 worker node, scale up and down.

One thing to notice is that I copied lots of codes from sigs.k8s.io/cluster-api/test/framework/* to test/e2e/helpers.go, because in the original framework, it assumed the use of KubeadmControlPlane, so I just copied code and changed to KThreesControlplane.

Change the default tag in config/manager/kustomization.yaml to dev. Add a docker-build-e2e Makefile target for building docker image with tag dev. This image will be used during e2e test.
Add test/e2e/README.md for usage

Future work

Scaling down control plane is buggy, need to enable scaling down control plane in the e2e test when the bug is fixed.

LGTM

@richardcase it seems that my approval doesn't unblock the pr review gate?

@richardcase it seems that my approval doesn't unblock the pr review gate?

I can get that sorted.


Module dependencies result in duplicated data in store

I have a module that depends upon several other modules that are scoped to the primary module, but when I load the page, I'm seeing the dependant modules as both peers of my primary module and as children of it.
Primary module
/* File: CustomerDetailsPage/store/module.js */

// Peers
import { getModule as getBillingAccountModule } from 'store/billingAccount'
import { getModule as getAssignableUsersModule } from 'store/assignableUsers'

// Children
import { getModule as getCustomerModule } from './customer'
import { getModule as getOrdersModule } from './orders'
import { getModule as getEnrollmentRecordsModule } from './enrollmentRecords'
import { getModule as getPaymentObligationsModule } from './paymentObligations'

export function getModule() {
  return [
    getAssignableUsersModule(),
    getBillingAccountModule(),
    // The following four should be nested within
    getCustomerModule(),
    getEnrollmentRecordsModule(),
    getOrdersModule(),
    getPaymentObligationsModule(),
    {
      id: ID,
      reducerMap: {
        [ID]: reducer,
      },
      sagas: [
        customerDetailsPageSagas,
      ],
    },
  ]
}

As an example of a child module:
/* File: enrollmentRecords/module.js */

import reducer from './reducer'
import enrollmentRecordsSagas from './sagas'

const ID = 'enrollmentRecords'

export function getModule() {
  return {
    id: ID,
    reducerMap: {
      [ID]: reducer,
    },
    sagas: [
      enrollmentRecordsSagas,
    ],
  }
}

Now, when I load the page, my store looks like this:

I think I know why the store parts in red are where they are (because I didn't follow https://redux-dynamic-modules.js.org/#/reference/Dependencies), but what's not clear to me is why my dependent store partitions are in both places.

Okay, I think I understand this now.
The store partitions that I've highlighted in red in the screenshot, above, are due to this:
    // The following four should be nested within
    getCustomerModule(),
    getEnrollmentRecordsModule(),
    getOrdersModule(),
    getPaymentObligationsModule(),

While the (properly) nested parts are due to this in my reducer:
/* File: ./reducer.js */

export default combineReducers({
  detailsPage: detailsPageReducer,
  customer: customerReducer,
  enrollmentRecords: enrollmentRecordsReducer,
  orders: customerOrdersReducer,
  paymentObligations: paymentObligationsReducer,
})

So it looks like what I need to do for my purposes is just remove the getFooModule() parts from the config, and roll-up all my subordinate sagas in my ./sagas.js and reduce my configuration down to this:
export function getModule() {
  return [
    getAssignableUsersModule(),
    getBillingAccountModule(),
    {
      id: ID,
      reducerMap: {
        [ID]: reducer,
      },
      sagas: [
        customerDetailsPageSagas,
      ],
    },
  ]
}

Does that sound about right?


[BEAM-7389] Add code snippets for CombineGlobally

Adding the code snippets for CombineGlobally.
R: @aaltay

Note: Side inputs do not work on CombineGlobally so those tests are commented out.
Filed BEAM-8400 to track this, here's a notebook to reproduce the issue.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Python PreCommit

Run Python PreCommit


Integrate IPFS for data storage

Be able to store records via IPFS.

implementing generic IPFS support without Authentication and authorization is a bad idea even if encrypted.  We should discuss https://github.com/LinuxForHealth/connect/issues/55 and https://github.com/LinuxForHealth/connect/issues/19 first.


GitHub insights section

The insight section contains several levels that would be ideal to check and address to have the best visibility for the package and help the community trust the contribution.

Community: set up discussions
Community standards

Description (done)
README (done)
Code of conduct (done)
Contributing (pending)
License (done)
Security policy (pending)
Issue templates (pending)
Pull request template (pending)

The following Community Standards were not completed, but it would be beneficial to work on them in figure iterations, especially as new folks in the team start working in the repository.


Add to scoop's bucket

I think it might be worth working towards including Nvy in scoop's (GitHub) bucket  - a popular command-line installer for Windows. It should fit in Scoop/Extras bucket.
If it was included there you can install Nvy via:
scoop bucket add extras
scoop install neovim nvy
nvy

...on a fresh installation to start quickly. I believe most people that use scoop already have Scoop/Extras bucket added.
And just scoop update nvy to get to latest version.
Surely users would be more likely to try Nvy if there was an easy way to do so, especially in repository of a commonly used installer. It might also expose Nvy to a broader audience.
Adding it should be pretty straightforward. I might try to do it in future, when I have some more time but anyone can try. See: ScoopInstaller/.github/CONTRIBUTING.md#for-scoop-buckets.

It seems we do not yet fit the criteria for inclusion in the extras bucket sadly.
a reasonably well-known and widely used developer tool (e.g. if it's a GitHub project, it should have at least 500 stars and 150 forks)
Otherwise good idea, I've used scoop in the past myself

* a reasonably well-known and widely used developer tool (e.g. if it's a GitHub project, it should have at least 500 stars and 150 forks)

I think that's the requirement for the Scoop/Main bucket. I was confused about that at first too.
Scoop/Extras:

Scoop Extras
Extra manifests for Scoop, the Windows command-line installer. For manifests that don't fit the Main criteria.

Huh okay, in that case I'll see if I can find some time soon to open a PR. Good suggestion 👍

I've opened an issue in the Scoop/Extras repo: https://github.com/ScoopInstaller/Extras/issues/9277

Great if merged.


Fix timezones and add support for pydantic 1.9.0

0.10.24
🐛 Fixes

Fix support for pydantic==1.9.0 #502
Fix timezone issues with datetime #504
Remove literal binds in query generation to unblock postgres arrays #/tophat/ormar-postgres-extensions/9

Currently blocked by bug in encode/databases, already fixed but not yet released: #encode/databases/435

@collerek - I suggest you consider also adding python 3.10 support and dropping python 3.6.

@Goldziher I wanted to do this some time ago but I think databases still don't support python 3.10 so I'm blocked.

Are you sure this is a blocker? 3.10 probably doesn't break anything, but it will give a new syntax for those who use it. I suggest updating the test matrix and seeing.

Are you sure this is a blocker? 3.10 probably doesn't break anything, but it will give a new syntax for those who use it. I suggest updating the test matrix and seeing.

Ok it was aiomysql at that time not databases: https://github.com/collerek/ormar/runs/4141248426?check_suite_focus=true.
Can check if it works now.

Codecov Report

Merging #508 (e7174e3) into master (e651400) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head e7174e3 differs from pull request most recent head bf3b361.


Fix frac-line

Render frac-line, underline, overline, and vertical-separator using an SVG path that fills the middle third of an SVG image and its containing span.
Because the span is three times as thick as the line, we hope that Chrome will consistently render it.

@kevinbarabash, When I test this PR locally, I get math rendered, but I also get a number of console warnings about missing fonts.

I'm not 100% sure that I got all the kern distances correct. A careful test with Screenshotter is called for.

@ronkok in #891 I moved fonts into a submodule. Running git submodule update --init --recursive should fix the issue.  There are additional details of working with submodules in https://github.com/Khan/KaTeX/blob/master/CONTRIBUTING.md#working-with-submodules.

The fraction lines are a bit blurry on non-retina displays.  This is to be expected.  We might experiment with setting shape-rendering: crispEdges on the fraction bar SVGs.

Even though the fraction line is 0.12em high, at small fonts it looks that's still somewhere between 1 and 2 pixels.  I wonder if we should render an empty span for the fraction bar and then a second span with that contains the SVG which is at least 0.04em + 2px.

We might experiment with setting shape-rendering: crispEdges

It may be worth an experiment, but I expect the same sort of failure that we get from borders. We tried crispEdges during PR #670 and some horizontal lines disappeared on a low resolution monitor.

at least 0.04em + 2px tall

I'll give that some thought. It might be easier just to make the line span 7 lines tall or 9 lines tall instead of 3 lines tall.

a bit blurry on non-retina displays

I'll experiment a bit with changing the two brush strokes to three brush strokes.

Since we're experimenting, I'm also going to try CSS border-image. Unlike a border, a border-image-width can be a percentage. That would make a min-height value on the span effectively a min-height on the frac-line.

Results are in re: crispEdges. Both images below are from Firefox. The top image includes crispEdges. The bottom image does not:

Notice that the fifth and sixth crispEdges examples, in 12 pt font and 11 pt font, omit the fracline.  Chrome and Opera were okay in the larger font sizes, but they omitted frac-lines in the smaller sizes.
I am going to avoid crispEdges. I'll try to find some other way to avoid blurriness of the line edges.

The most recent commit sets the container span to 5 times the line thickness. My tests show frac-lines that are:

visible until font sizes get so small that I can't read the numerator,
blurry on non-retina displays.

I can't think of much more to help that blurriness. I don't want to use crispEdges for reasons described above and a triple brush stroke did not help. I think this is the best I can do short of changing the defaultRuleThickness to something larger than 0.04em.

@kevinbarabash, It seems to me that the blurriness is worse in scriptstyle than in textstyle. And I think there is something I can do about that, but it may be a few days before I get to it.

The most recent commit changes from SVG paths to SVG lines. The change makes no difference that I can see on high-resolution screens, but the lines will get darker/sharper when two lines are written in Chrome on a Windows 8 box with a low-res screen.
If fact, when I tested 4 brush strokes, Chrome would actually make the lines much thicker on the low-res screen. Strange.
For the commit, I stayed with two brush strokes.

@ronkok should I regenerate the screenshots?

Yes, thank you. I've done everything with this PR that I can think to do.

@ronkok I've sent you a PR with the updated screenshots.  There also seems to be a flow issue:
Error: src/functions/genfrac.js:165
                        v----------------------
165:             frac = buildCommon.makeVList({
166:                 positionType: "individualShift",
167:                 children: [
...:
176:             }, options);
                 ----------^ call of method `makeVList`
173:                     {type: "elem", elem: rule,   shift: midShift + 2 * ruleWidth},
                                              ^^^^ null. This type is incompatible with
346:     elem: DomChildNode,
               ^^^^^^^^^^^^ union: span | anchor | svgNode | symbolNode. See: src/buildCommon.js:346

Well, I've corrupted another branch with commits from another PR. I'm closing this PR so that I can submit the same material in a fresh one.


Properly exit on error

@alexsomesan @brancz
This uses the errgroup package and contexts. On the first error returned by either operator's Run(), the context gets canceled and ensures the other one exits as well and with it the program as a whole.
I disabled closing of the server for now and just let it run. It's not graceful and just returns confusing errors.
We can do it properly once https://tip.golang.org/pkg/net/http/#Server.Shutdown lands in go1.8

lgtm :+1:

That's pretty cool. 👍


outdated lodash - improving performance

There is a newer version of lodash (3.3.1) which  improved performance 20-40% overall  by better utilizing the JIT in JavaScript engines, using internal helper functions that avoid optimization disqualifications & increase the likelihood of function inlining.
lodash 3.0.0 is 40%  (1.40x) faster than lodash 2.4.1.
In v3 also introduced were lazily evaluated chaining for massive performance wins in certain scenarios.
Any change to update to the latest release?

I upped it to 4.0 here: https://www.npmjs.com/package/es6-plato


dyld error after upgrading to v0.4

dyld: Symbol not found: OBJC_METACLASS$__TtC6APIKit3API
Got this error after upgrading to v0.4 when trying to run the app on device (works fine in simulator).
And it would work if rolled back to old version.

Does this error occur on APIKit DemoApp too?

If it doesn't, you may forgot to embed APIKit into your app target.

No news is good news.


Implement Move native ECDSA k1 verification

we will need an interface to take in hashed_message, since this is for use case the user signs the message elsewhere, with a hash function they prefer.


Decisions need an update

Decisions should include an 'update' array to match the suggestion action types. Currently only create and delete are provided.

I agree, the decision and suggestion structures should be consistent.

This seems to be an obvious inconsistency. Will it be fixed in v1.0?

Thanks for the feedback @robs16.
As you're aware (since you were present for the discussion), the community reached consensus at the Sept 2017 San Diego Connectathon to remove decisions for the 1.0 release (#99) until we obtain more implementer feedback. We will swing back on the decisions feature on a subsequent release. As such, I'm closing this issue with a deferred label.


It doesn't work anymore

After internet stopped and returned It doesn't work anymore.
used: last version, no antivirus, no firewall, hosts file empty and not read only.
Figure below shows everything

Unbelievable, change server to "mt.google.com" and everything works again.
Forget my post.


Fix broken image paths

Description
README.md has three broken images. This is because the image path is not correct. This PR replaces ./chrome-store/ with ./assets/ in those paths.
Type of change

[x] This change requires a documentation update

How Has This Been Tested?
You can confirm the change to fix images on this forked branch: https://github.com/shuuji3/headless-recorder/tree/fix-image-path
I couldn't pass the npm run test on my environment but it should pass because this PR only changes README.md.
Checklist:

[x] My code follows the style guidelines of this project. npm run lint passes with no errors.
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes. npm run test passes with no errors.

@shuuji3 thank you!


Allow ability to run all tests on local Windows installs

Fixes #1455
Description

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

@UmbWill and I tested this manually at the SciPy Japan sprints, and it works! 🎉

Just checked and the tests are also running in CI as expected, see e.g. https://cirrus-ci.com/task/6130607342223360?command=test_pyside2_with_coverage#L262 🎉

Hmmm looks like there is a problem on Windows CI now... Maybe chaining skipifs is not as straightforward as I thought... Will investigate.

Ok so I don't actually understand why it's failing. The use of pytest.mark.skipif is correct. I changed the platform to 'linux' and pretended to be in CI, and things were totally fine:
 $ CI=1 pytest -rs napari/_vispy/_tests/test_vispy_multiscale.py
==================================== test session starts ====================================
platform linux -- Python 3.8.6, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
PyQt5 5.12.3 -- Qt runtime 5.12.9 -- Qt compiled 5.12.9
rootdir: /home/jni/projects/napari, configfile: pyproject.toml
plugins: napari-plugin-engine-0.1.8, timeout-1.4.2, ordering-0.6, qt-3.3.0
collected 6 items

napari/_vispy/_tests/test_vispy_multiscale.py ..ssss                                  [100%]

================================== short test summary info ==================================
SKIPPED [1] napari/_vispy/_tests/test_vispy_multiscale.py:63: Screenshot tests are not supported on napari windows CI.
SKIPPED [1] napari/_vispy/_tests/test_vispy_multiscale.py:97: Screenshot tests are not supported on napari windows CI.
SKIPPED [1] napari/_vispy/_tests/test_vispy_multiscale.py:138: Screenshot tests are not supported on napari windows CI.
SKIPPED [1] napari/_vispy/_tests/test_vispy_multiscale.py:175: Screenshot tests are not supported on napari windows CI.
=============================== 2 passed, 4 skipped in 0.99s ================================

If anyone from @napari/core-devs has any ideas, they would be much appreciated!!!

i know it's weird... but try using a string as the skipif condition (it will be evaled).  Also, in order to reduce all the duplication, you can create a custom decorator like this:
skip_on_win_ci = pytest.mark.skipif(
    "sys.platform.startswith('win') and os.getenv('CI')",
    reason='Screenshot tests are not supported on windows CI.',
)

skip_local_popups = pytest.mark.skipif(
    "not os.getenv('CI') and not os.getenv('NAPARI_POPUP_TESTS')",
    reason='Tests requiring GUI windows are skipped locally by default.',
)

@skip_on_win_ci
@skip_local_popups
def test_z_order_adding_removing_images(make_test_viewer):
    ...

Thanks @tlambert03! I saw the string eval option in the docs but it was marked as deprecated. Still, worth a try, might help us narrow down the issue... 🤷

According with the os.getenv documentation:
Return Type: This method returns a string that denotes the value of the environment variable key. In case key does not exists it returns the value of default parameter.
Every time, the statement has been skipped.
I changed the code as Lambert-san said, and added os.getenv('NAPARI_POPUP_TESTS')=='1'

@UmbWill awesome, so good that this is passing now! 🎉


[Improve][e2e]change the jdbc driver scope to provider

Purpose of this pull request

change the jdbc driver scope to provider
Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

subtask of #2642 .change the jdbc driver scope to provider and improve the jdbc connector doc.
PTAL @ashulin @Hisoka-X @TyrantLucifer thanks

PTAL @hailin0

@ashulin  i fixed those problems, and PTAL again ,thanks.

@ashulin @TyrantLucifer @CalvinKirs @Hisoka-X @EricJoy2048 PTAL thanks.

@TyrantLucifer  @EricJoy2048  PTAL thanks

Need to add driver package download for all JDBC inheritance tests
E.g XaGroupOpsImplIT.testRecoverAndRollback

Done. @ic4y  .please rerun CI

@EricJoy2048 thanks.

LGTM

@TyrantLucifer  PTAL


CVOpenGLESTextureCacheCreateTextureFromImage Error -6661

Hi, I met a problem when finish record from camera. It shows,
Camera CVOpenGLESTextureCacheCreateTextureFromImage failed (error: -6661)
I found some buffer that the camera buffer handler got is null.
Can you help fixing that?

Hello I get the same issue with xCode 6.4, iPad Air, iOS 8.3.
Reboot done, everything done, always get this error :

I am now receiving the same error as brizzly has shown above.  Any idea why this is happening? Everything was running fine last time I ran the application, but now it is broken.

@CM137 - I believe that's a bug in iOS 8.3, as described in issue #2041 . Something broke in 8.3, then was fixed in 8.4. Only affects that specific iOS version.


"need activation" notification is missing

The frontend is now showing the "need activation" notification after the new user logs into the system.

It should be fixed after #2535


Add wicket-orientdb as a git submodule

This wouldn't interfere with the development of wicket-orientdb as a separate project, but due to the fact that the projects are quite close a specific revision could be enforced if it is necessary for a patch in Orienteer which is not provided by the maven versioning schema x.y.z or x.y.z-SNAPSHOT.

I'm not so familiar with git feature for submodules. Thanks! I'll take a look.

If you're ok with it I can do it.

Can it be delivered as PR? If yes - yes please - I will check it out.
Will it be possible, for example: make changes in this submodule and than commit them to your own wicket-orientdb clone?

That is precisely the idea behind submodules. They serve to enforce a certain state of the submodule which is used for the build in the project. This state is managed in the parent git. You can commit in the submodule and no one will ever know it has be done in a submodule rather than in an independent clone, because there's no reason to distinguish.

see #134

I see the reason... lets return to this after releasing of 1.0. While wicket-orientdb and Orienteer are being developed in parallel: imho it might slow down turn around.

git feature was checked. It's not for now. Issue might be reopened if some real-life cases occur.


Spring Cloud Gateway - Getting error "Connection Closed Prematurely before /during response" during high volume of requests

Hi,
we are using Spring cloud gateway for an application having high volume of requests (approx. 500 to 700 requests per sec).
we have been facing intermittent issues like
a) Connection prematurely closed DURING response
b) Connection prematurely closed BEFORE response
c) Error finishing response. Closing connection
application.yml is configured with following numbers and we are also using EventLoopNettyCustomizer
server:
netty:
connection-timeout: 120000
httpclient:
wiretap: true
pool:
type: fixed
max-idle-time: 60000
max-life-time: 60000
acquire-timeout: 120000
connect-timeout: 60000
@Override
public HttpServer apply(HttpServer httpServer) {
EventLoopGroup eventLoopGroup = new NioEventLoopGroup();
eventLoopGroup.register(new NioServerSocketChannel());
return httpServer.runOn(eventLoopGroup);
}
@Bean
public NettyReactiveWebServerFactory nettyReactiveWebServerFactory() {
NettyReactiveWebServerFactory webServerFactory = new NettyReactiveWebServerFactory();
webServerFactory.addServerCustomizers(new EventLoopNettyCustomizer());
return webServerFactory;
}
Please suggest right pool configuration and any customization required to resolve above mentioned issues.

Thank you all
Root cause of this issue is "content-length" header is missing in the response headers. Issue is fixed after modifying the calling service response.


Reductions in CkIO::WriteSession not completing

This is with Charm version 7.0.0 and ChaNGa.
I am running on frontera with the mpi build of charm on 40 nodes.
I am occasionally getting hangs during the use of Ck::IO.  Sticking in CkPrintf()s narrows down the hanging to two different different places:

sessionReady(), which is set as an InitCallback, will sometimes not get called after the CProxy_WriteSession::ckNew().
(More commonly) the reduction triggered by contribute at the end of WriteSession::forwardData() never completes, and WriteSession::syncData() is never called.

At the moment I'm reproducing this from a checkpoint.  I'm checking now if I can reproduce it from a non-checkpoint restart.
If someone has an account on frontera, I can point them at the simulation.

My current guess is that this hang is due to bookkeeping problems around the creation and destruction of the WriteSession arrays.  In particular, the number of array elements is much less than the number of PEs, so there are a lot of inactive PEs to keep track of during reductions.  Furthermore, these creations/reductions/destructions are all happening immediately before ChaNGa writes a checkpoint, so I'm worried about bookkeeping across the checkpoint.
So one thing I tried: do a CkWaitQD() just before calling CkStartCheckpoint().  The hang goes away (so far) with this change.

Unfortunately, I'm still getting the hang after #3765 was merged.

Update: when I get to a point where CkIO hangs, I can get through the problematic CkIO session by restarting from the last checkpoint with ++ppn  1.  Furthermore, once the problematic output is done and a new checkpoint is written, I can continue from the new checkpoint with the usual ++ppn number.
My guess is that this problem is caused by a race condition.

I can further confirm that @trquinn's workaround does get past the hang for me as well.


fix: the 'connect to Xero' experience in two ways (modal style & translation copy update).

Explanation of Change

Fixed Issues
$ https://github.com/Expensify/App/issues/53414
PROPOSAL: https://github.com/Expensify/App/issues/53414#issuecomment-2513328885
Tests

Log in and Create a WS
Go to workspace settings page
Enable Accounting in more features
Click Connect for Xero
Verify there is no padding on the top and sides of the illustration.
Verify the description is updated to For security purposes, Xero requires two-factor authentication to connect the integration. in english and Por razones de seguridad, Xero requiere la autenticación de dos factores para conectar la integración. in spanish

[x] Verify that no errors appear in the JS console

Offline tests

Log in and Create a WS
Go to workspace settings page
Enable Accounting in more features
Click Connect for Xero
Verify there is no padding on the top and sides of the illustration.
Verify the description is updated to For security purposes, Xero requires two-factor authentication to connect the integration. in english and Por razones de seguridad, Xero requiere la autenticación de dos factores para conectar la integración. in spanish

QA Steps

Log in and Create a WS
Go to workspace settings page
Enable Accounting in more features
Click Connect for Xero
Verify there is no padding on the top and sides of the illustration.
Verify the description is updated to For security purposes, Xero requires two-factor authentication to connect the integration. in english and Por razones de seguridad, Xero requiere la autenticación de dos factores para conectar la integración. in spanish

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/0665ddef-d1cd-4462-9566-1bff7d8f94df

Android: mWeb Chrome
https://github.com/user-attachments/assets/b535fc0d-adf8-4099-98d0-39f389628003

iOS: Native
https://github.com/user-attachments/assets/bac8a215-80e2-4397-b469-2c2be9783d2b

iOS: mWeb Safari
https://github.com/user-attachments/assets/266611b2-1728-44d3-bdbc-897c960eb65b

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/c6a4ce2a-f7dc-486d-abc9-985184d072ae

MacOS: Desktop
https://github.com/user-attachments/assets/86b06c5c-4bf9-49ba-a644-86e11eba1a3f

Tagging @Expensify/design for review—thank you!

I think that looks pretty good. I've had feedback elsewhere that in the desktop views we should use 32px of padding for the headline + text + button area, but with a modal as skinny as this, I don't think it would look very good. Anyways, consider this a 👍 from me.

but with a modal as skinny as this, I don't think it would look very good.

Do we have a standard width for these on desktop? Why is the one you suggested we use 32px on wider?

Good question. I think this one is modeled off of a centered alert modal, and thus isn't super wide. The other one I commented on is more like an empty state where we use more width?

Ok yeah that makes sense! Just wanted to make sure we didn't have a bunch of randomly different sizes 👍

Great! Just waiting for translation confirmation.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Function prints on path on embedded preview

Originally from https://github.com/microsoft/vscode-livepreview/issues/143#issuecomment-1098875424
@falco467

Hi! The current version seems even more broken. When I start live preview in a Workspace I get the following error message on the HTML preview:
File not found
The file "\c:\Workspace\myproject\function (old_index, new_index) { \ Shortcut helper to move item to end of array if (-1 === new_index) { new_index = this.length - 1; } if (new_index >= this.length) { var k = new_index - this.length; while (k-- + 1) { this.push(undefined); } } this.splice(new_index, 0, this.splice(old_index, 1)[0]); return this; \ for testing purposes }\index.html" cannot be found. It may have been moved, edited, or deleted.
It seems there is some Javascript code, which is not evaluated, but gets put directly into the URL.

This is an older bug, but I am seeing a similar message in https://github.com/benc-uk/armview-vscode/issues/54 its unclear but I believe that this visualization is built on top of livepreview. Can you indicate where that code snippet is coming from? What's strange is I see it on some Visual Studio Code installs; but not all?

Where does it say in that extension's source code that it uses Live Preview? It looks like it just uses a vscode webview.

Apologies; I made a terrible assumption that Live Preview and the WebView were one in the same!


Update README.md

Contribution guidelines

Contribution guidelines

Looks good to me @shivshankar9. Just rename the file to contributors.md and submit the PR.

Ok give me sec

@shivshankar9 Ok great. Everything looks fine to me now.
@noviicee Would you like to add something or review once? or should I merge the PR.


Drawer + Navigation Bar - paddingTop for component visibility

Version

react-native-router-flux v3.37.0
react-native v0.41.1

Expected behaviour
After applying paddingTop to Parent/Root component, its child component should be visible just below the Navigation Bar.
Actual behaviour
Child component is hidden behind Navigation Bar. This thing happened after applying Drawer - I needed to have both Drawer and Navigation Bar on top.
Steps to reproduce
Router file link (repo)
If I add the padding on Router it will give some unusual effect - pushes the Navigation Bar down with the child component.

I can achieve the desired result by adding paddingTop to children components but that will get hectic later on.
I will not update this repo till I found a solution, so you can check if there is any problem.

I have the exact same problem. Did you find a solution?

I have the exact same problem.

Delete line 29
sceneStyle={{paddingTop: Navigator.NavigationBar.Styles.General.TotalNavHeight}}
Works for me

@fernandovega  If I delete sceneStyle={{paddingTop: Navigator.NavigationBar.Styles.General.TotalNavHeight}}, the rendered component will be again shift up top behind the NavBar.


no video playback on FB livestreams

when I get a notification that someone has started a livestream on Facebook and when went to check stream it wont play it, it's just a black/blank screen. Normal FB videos do work normally, also the "archived"/saved livestreams.
I'm using the git version of freshplayerplugin, with FF43.0.4 on chakraOS

I don't use Facebook usually. Is there a way to find a live stream?

find? no, you have to have a friend or follow someone who starts a livestream...there are few that I follow who does it few times a week...I will check if it was nvidia beta driver problem

should be fixed since FB uses ovbiously RTMP/RTMFP/RTMPE/RTMPTE protocols
please try the last git thanks

@ahjolinna, does it work now? Or bug's still there?

If I recall correctly, PepperFlash started to use other parts of API for making UDP connections. Since real-time communication protocols are implemented over raw UDP, that most probably was the reason. Since new API parts were implemented long ago, there is no sense in keeping this issue open.


Update to v3

Changes to be compatible with mimosa v3.
Related with issue dbashford/mimosa#439
@dbashford can you review it?
Thanks

Just one comment on it in the PR.
Also, with 3.0, placeholder will no longer be used.  So you can nuke this entire code block: https://github.com/ifraixedes/mimosa-asset-cache-bust/blob/master/src/config.js#L20-L39  and then this line: https://github.com/ifraixedes/mimosa-asset-cache-bust/blob/master/src/index.js#L37
Then you should be squared away for 3.0.


Flaky Test in presentation-full-stack-tests - Ruleset Variables Multiple frontends for one backend handles multiple simultaneous requests from different frontends with ruleset variables

Build Info

Repo: itwinjs-core
Build Name: iTwin.js
OS: Linux x64
Test Suite Name: presentation-full-stack-tests
Test Name: Ruleset Variables Multiple frontends for one backend handles multiple simultaneous requests from different frontends with ruleset variables

Error Detail
1) Ruleset Variables
       Multiple frontends for one backend
         "before each" hook for "handles multiple simultaneous requests from different frontends with ruleset variables":
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/agent/_work/1/s/full-stack-tests/presentation/lib/frontend/RulesetVariables.test.js)

Links to failing builds
https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1933957&view=logs&j=0aa84d8c-14fd-5636-fb46-99be2362d8e1&t=234e5986-45f5-5876-92cf-d939451fbda1&l=3969
This also seems similar / related: https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1934676&view=logs&j=9f3a3068-7880-5994-433d-b92c1f9d379b&t=c78dc741-fe12-5d6a-c099-5134f70fdb0c&l=8228
Notes
Flaky, noticed on Windows & Linux so far.

Feb 2, MacOS: https://bentleycs.visualstudio.com/iModelTechnologies/_build/results?buildId=1936227&view=logs&j=47fa0b0a-f6a7-5b52-b86a-09932c451137&t=22921386-9f0d-5e70-566c-c007901e7097&l=8572

Haven't seen this lately, closing and will re-open if it shows up again.


Local result is inconsistent with torch_geometric tutorial on colab !

❓ Questions & Help

In the pytorch_geometric colab's tutorial  1. Introduction.ipynb
I ran the cell and got
from torch_geometric.datasets import KarateClub

dataset = KarateClub()
print(f'Dataset: {dataset}:')
print('======================')
print(f'Number of graphs: {len(dataset)}')
print(f'Number of features: {dataset.num_features}')
print(f'Number of classes: {dataset.num_classes}')

Dataset: KarateClub():
======================
Number of graphs: 1
Number of features: 34
Number of classes: 4

However, after I cloned the notebook to my local machine, I ran the same cell and got
from torch_geometric.datasets import KarateClub

dataset = KarateClub()
print(f'Dataset: {dataset}:')
print('======================')
print(f'Number of graphs: {len(dataset)}')
print(f'Number of features: {dataset.num_features}')
print(f'Number of classes: {dataset.num_classes}')

Dataset: KarateClub():
======================
Number of graphs: 1
Number of features: 34
Number of classes: 2

As you can see the number of classes is inconsistent. On colab it is 4 while on my local machine it is 2.
Also, I ran and got
data = dataset[0]  # Get the first graph object.

print(data)
print('==============================================================')

# Gather some statistics about the graph.
print(f'Number of nodes: {data.num_nodes}')
print(f'Number of edges: {data.num_edges}')
print(f'Average node degree: {data.num_edges / data.num_nodes:.2f}')
print(f'Number of training nodes: {data.train_mask.sum()}')
print(f'Training node label rate: {int(data.train_mask.sum()) / data.num_nodes:.2f}')
print(f'Contains isolated nodes: {data.contains_isolated_nodes()}')
print(f'Contains self-loops: {data.contains_self_loops()}')
print(f'Is undirected: {data.is_undirected()}')
print(data)

Data(edge_index=[2, 156], x=[34, 34], y=[34])
==============================================================
Number of nodes: 34
Number of edges: 156
Average node degree: 4.59

AttributeError                            Traceback (most recent call last)
 in
8 print(f'Number of edges: {data.num_edges}')
9 print(f'Average node degree: {data.num_edges / data.num_nodes:.2f}')
---> 10 print(f'Number of training nodes: {data.train_mask.sum()}')
11 print(f'Training node label rate: {int(data.train_mask.sum()) / data.num_nodes:.2f}')
12 print(f'Contains isolated nodes: {data.contains_isolated_nodes()}')

AttributeError: 'Data' object has no attribute 'train_mask'
library version
cuda 10.2
pytorch 1.6.0
pytorch_geometric 1.6.1

Please install PyG from source for the updated KarateClub dataset:
pip install git+https://github.com/rusty1s/pytorch_geometric.git

So is the old version PyG wrong?

No, the dataset just got enhanced by the training objective introduced in the GCN paper.

Ok, I have not read so many papers yet. Thanks for your reply!

Sure, feel free to ask any questions that might occur :)


Added code to handle Static banners in Recs

@rallu Need suggestions on how to handle analytics events calls from UI component.

Changes of  this PR are in #484


move object properties from shared to original modules #1703

Summary of the discussion
comes from #1703
Type of change (CHANGELOG.md)
Updated

place to live for several domain and ranges of object properties in oeo-shared

Removed

doubles axioms in oeo-shared

Workflow checklist
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

has client: Domain (model or information content entity) lives in oeo-model, range ('has role' some client) lives in oeo-social. I see two options:

I move whole the object property to oeo-shared-axiom
I move the object property to oeo-social and the domain declaration to oeo-shared-axioms

Any opinions?

has bearer and has characteristic live in oeo-shared and must not be moved. They have energy as domain and range resp. Again two options:

move energy to oeo-shared (In this case my preferred option)
split domain and range from class declaration and transfer it to oeo-physical

I leave covers sector untouched in oeo-shared. We can take care of it in #1703

Thinking about this, I am asking myself, why is model not a subclass of information content entity (ICE)? The definition of ICE is: A generically dependent continuant that is about some thing. To me, that definition holds also to model, as a model is about an idealised reproduction of some system and its behaviours.
If we make model a subclass of ICE, we can simplify the domain of has contributor to ICE and we don't have any problem in OEO shared.

There is a discussion in #1444 about the classification of model with the colclusion to make it equivalent to continuant and 'has role' some 'model role'

. [ ] We have a lost object property OEO_00010128 that needs to be restored.

That's it so far for shared.
The other modules should be done in separate PRs.

[x]  has bearer and has characteristic live in oeo-shared and must not be moved. They have energy as domain and range resp. Again two options:

move energy to oeo-shared (In this case my preferred option)

split domain and range from class declaration and transfer it to oeo-physical

I just implemented this now to complete the PR. If there are good reasons, we can still revert.

Note for reviewers:
I merged #1709 and #1710 into this branch. The've been already reviewed.
All commits until c21f357 are not yet reviewed.

@l-emele @areleu now the PR should be fine. Please take a hopefully final look.

At first glance there seems not to be any duplicated axioms, the object property tree looks clean.


Feature: Unified files routes

Title:

Unified files routes for OpenAI and Cohere

Related Issues: (optional)

https://github.com/Portkey-AI/gateway/issues/754

closing because I'm pushing changes to feature/unified-batches-api


keycloak installation isn't reliable

When installing on new on a new system, Keycloak is very often failing. api-gateway-deployment is missing:
...
      hostAliases:
      - ip: "<IP_ADDRESS>"
        hostnames:
        - "czertainly.local"

and user is getting error Kong Error. Even when values.yaml contains:
...
# this is needed only for KeyCloak
apiGateway:
  hostAliases:
    resolveInternalKeycloak: true
  trustedIps: "<IP_ADDRESS>/0,::/0"
...

Steps to reproduce

Take Virtual Appliance
Fully configure it to install all features of version 2.7.1
Remove last task, CZERTAINLY instalation, from file /etc/czertainly-ansible/roles/czertainly/tasks/main.yml
Exec complete instalation and wait for it to fail (because that last task is removed)
This is moment when you have clean, ready to use k8s sys
Enter system shell, exec /usr/sbin/helm --version=2.7.1 upgrade -i --reset-values --wait --timeout 10m --values=/root/install/czertainly-values.yaml --values=/root/install/czertainly-values.local.yaml czertainly-tlm oci://harbor.3key.company/czertainly-helm/czertainly -n czertainly --debug 2>&1 | tee /tmp/2.7.1-helm-install-ENABLED-keycloak.log
check if keycloak is working (loggin to https://czertainly.local/administrator/ without cert will fail if it is not working)
Enter system shell again and exec /usr/sbin/helm --version=2.8.0 upgrade -i --reset-values --wait --timeout 10m --values=/root/install/czertainly-values.yaml --values=/root/install/czertainly-values.local.yaml czertainly-tlm oci://harbor.3key.company/czertainly-helm/czertainly -n czertainly --debug 2>&1 | tee /tmp/2.8.0-helm-upgrade-ENABLED-keycloak.log
at this moment will be keycloak typically working

File /tmp/2.7.1-helm-install-ENABLED-keycloak.log is lacking section with hostAliases, so keyCloak is not working. File /tmp/2.8.0-helm-upgrade-ENABLED-keycloak.log typicaly has section hostAliases. And keycloak is working.
Notes

Steps above are not 100%
Installing 2.8.0 with disabled Keycloak and enabling it is typically not enough, but once it was good
mentioned files are attached:
2.8.0-helm-upgrade-ENABLED-keycloak.log
2.7.1-helm-install-ENABLED-keycloak.log

I think this may be caused by the lookup function that is implemented in api-gateway-deployment:
      {{- if and (.Values.global.keycloak.enabled) (.Values.hostAliases.resolveInternalKeycloak) }}
        {{- $namespace := .Release.Namespace }}
        {{- $keycloakService := (lookup "v1" "Service" $namespace "keycloak-internal-service") }}
        {{- if $keycloakService }}
          {{- $hostName := pluck "hostName" .Values.global .Values | compact | first }}
          {{- $internalIp := (lookup "v1" "Service" $namespace "keycloak-internal-service").spec.clusterIP }}
      hostAliases:
      - ip: {{ $internalIp | quote }}
        hostnames:
        - {{ $hostName | quote }}
        {{- end }}
      {{- end }}

When the chart is installed for the first time, or when the internal Keycloak does not exist yet in general, the $keycloakService will be always empty. lookup function will not be able to find it before the resources are prepared.
Maybe it would be better to patch the api-gateway-deployment using post-hooks. In such case, the internal Keycloak should be available, including the service with associated IP address.
Impact:
When the hostname is registered in the DNS, this does not have any impact on the deployment. It is used only for local testing or development purposes.
Existing workaround:
Install internal Keycloak with resolveInternalKeycloak: false, and after it is installed, you can enable it with resolveInternalKeycloak: true. This will find existing resources and create hostAliases.


Improve test coverage

95% coverage of whole package (763 tests). 99% for the scene kit (376 tests) and 91% for the MC module (387 tests).
Changes

Fixed many deprecated tests
71 new tests for the scene kit
341 new tests for the MC module
It includes visual tests for some Mayavi and Matplotlib figures (that I need to test on other OS since the output might vary).
Also includes good coverage of each OpenCL C module. It is not included in the Python coverage report, but my guesstimate is around 90%.
Some tests are skipped if OpenCL is not installed.
I regrouped all examples under the main directory ~/examples.
The whole test suite takes around 10 seconds to run on my laptop.

Notes

Missing coverage for the autoNWorkUnits algo and 3DVolumeSlicer. I plan to refactor both in another branch first.
Also missing coverage for the examples and the pre-defined samples. Might test that later.

As expected, the visual tests do not work on Windows. I might have to resort to skipping them by default, and when run, simply display reference view along with current view so the user can assert that they look the same.
There are also a few tests regarding the Ellipsoid that raise ZeroDivisionError probably because of a different numpy/math version.


Use dotenv to load environment variables on development and test

I noticed that currently the project needs the OCTOKIT_TOKEN variable to work properly (I mean, with a higher rate limit on GitHub API requests). I think it'd be nice if we had a .env.example file on the root directory that contributors can use to generate their own .env files.
What are your thoughts about it?

Yeah that's awesome, I'm using dotenv on https://github.com/librariesio/libraries.io already, works really well 👍


Progress reports requirements

Please add progress report requirements and schedule for existing Icon Foundation grant

You can also include something like the following in the requirements:
"Grant progress reports may be submitted on a regular schedule or, additionally, ad-hoc, after an agreed upon set of milestones

I would recommend to use the following directory structure:

requirements

progress-reports-requirements.md

To reduce the clutter, I think this is something that can exist in the template itself because this template is required to be followed, not a guideline.


Fix async compatibility

It is still possible to get an error in async test if aiohttp is used:
Timeout context manager should be used inside a task
Will try to add a failing test case & details soon

It turns out, that issues I faced were caused by aiohttp pytest plugin & pytest-asyncio compatibility, pytest-asyncio creates a new event loop but aiohttp plugin uses its own one. The issue itself could be more about docs on how to avoid it.
However, there is still an issue with a message about missing loop_factory - it is caused that pytest_generate_tests is called on the original function itself, not on the ones parametrized by schemathesis and these test function doesn't receive loop_factory fixture

After fixing #280 this one should work since it was caused by incompatibilities with aiohttp.pytest_plugin


blessed-integration: remove interruptable=True, always retry select.select()

This builds on https://github.com/erikrose/blessings/pull/100
Removes interruptable=True, and behaves as though it is always True.  This follows https://www.python.org/dev/peps/pep-0475/ and is no longer necessary in python3.5, but is required for all previous versions of python.


Spaces removed. Also sentence too long at start.

Sorry - I don't think this substantially improves the readability of this paragraph in its output form.


setup function relies on reading cross-origin style sheets (CSSOM spec violation)

https://github.com/sampotts/rangetouch/blob/46e6b12f196bc6511d44acbaf6947633bd4ddb41/src/js/rangetouch.js#L52-L54
This violates the CSSOM spec:
The insertRule(rule, index) method must run the following steps:

    If the origin-clean flag is unset, throw a SecurityError exception.
    Return the result of invoking insert a CSS rule rule in the CSS rules at index.

https://drafts.csswg.org/cssom/#dom-cssstylesheet-insertrule
And breaks in Firefox (which follows the spec).

To workaround this, you could create a new stylesheet with this rule and append that to the document. Or just use inline styles?

This is fixed in v1.0.6 but I've also just released a complete rewrite which is in beta - v2.0.0-beta.1. It is now using a proper ES6 class so must be setup per input. There's also a static RangeTouch.setup() method that allows you to setup multiple inputs and returns an array of the references to the instances so you can destroy them etc. I think this will improve support for frameworks like React where you can import the lib and setup RangeTouch in your component. Give it a go and give feedback if you can. I'm still testing myself (hence beta) so there may be bugs.


Add three-panel visualization task

Add this new example task for the library.  I'll create a communities article to describe it soon, and publish a link in the README.md

Merged after review and suggested changes from Olivia


Fix encoded path for 'helm dependency build'

What this PR does / why we need it:
Fixes: #9821.
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

@cndoit18 Please review this one (split out of #9763).

@cndoit18 What is the status of this PR? Please review 👀 .

@bacongobbler Please unblock tests for this PR, and please review :pray:.

@hickeyma @mattfarina @jdolitsky @marckhouzam I'm desperately looking for someone to start the CI and review this PR :pray:
Now that Gitlab supports Helm charts, more people will be affected by this (even if it can be worked around by using the project id instead of the project path).

@sathieu I would like to test this fix manually first.  Do you have suggestion how to setup a repo path with encoded path? I tried using GitHub but it is unfortunately interpreting the path.

Thanks @hickeyma You can test on gitlab.com. I've already uploaded charts here: https://gitlab.com/kubitus-project/kubitus-ingress-operator/-/packages

https://gitlab.com/api/v4/projects/28163461/packages/helm/main -> works
https://gitlab.com/api/v4/projects/kubitus-project%2Fkubitus-ingress-operator/packages/helm/main -> doesn't work, unless you apply this MR

NB: Gitlab doc is here: https://docs.gitlab.com/ee/user/packages/helm_repository/.


Full scope policy does not work for undefined APIs

@lesmin-sk commented on Mon Feb 24 2020
If you define a policy as a full scope policy,
403 Forbidden error is returned when accessing the API in the illegal IP address band.
However, for an undefined API, when accessing from an illegal IP address band,
404 Not Found error is returned instead of 403 Forbidden.
The expected behavior is that ip-filter is a global policy, so I want to return 403 Forbidden.
This article lacks a description of these cases.
Or if you can add the policy back into the policy,
It seems that the above expected behavior handling is possible, but it is not currently supported.
I would also like to add a description.

문서 세부 정보
⚠ 이 섹션을 편집하지 마세요. docs.microsoft.com ➟ GitHub 문제 연결에 필요합니다.

ID: 250924d9-418b-9a24-90fe-5b3835c3b2a7
Version Independent ID: cfd91d85-ffff-d2b0-fc7f-61bcae6ed615
Content: Azure API Management의 정책
Content Source: articles/api-management/api-management-howto-policies.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@srvbpigh commented on Mon Feb 24 2020
Hello, @lesmin-sk
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hi Team,
Could you please check comment above from user?
Kind regards,
Microsoft DOCS International Team

All policies are applied after all matching scopes are identified. If matching scopes can't be identified (as in the case of undefined API) 404 is returned.

@vladvino Thanks for the explanation.
Then could add support for  in the ?
That can make 403 return when matching failed.

@lesmin-sk You can submit a feature request on Azure Uservoice for API Management.
Since this channel is for driving doc changes and we haven't determined any, we will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Bp 435

Codecov Report

Merging #440 into v6.x will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             v6.x     #440      +/-   ##
==========================================
+ Coverage   86.36%   86.37%   +<.01%
==========================================
  Files          38       38
  Lines        6390     6393       +3
==========================================
+ Hits         5519     5522       +3
  Misses        871      871