Security - Close Account - No growl is received when closing an account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Access staging.new.expensify.com OR open the desktop mac app
Sign into a public domain account
Click on the Profile icon > Security > Close account
Input the correct information in the fields and proceed with the "close account" button in red.

Expected Result:
The user expects to be navigated to the Sign in page and receive a growl so that they may now their actions were successful.
Actual Result:
The user is redirected correctly but no growl was received.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/182512465-4264e6be-1062-493b-a158-db2479da0a52.mp4
https://user-images.githubusercontent.com/93399543/182512469-b3120476-bc91-40a7-8e2f-8edb54332a88.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Beamanator looks like it is coming from https://github.com/Expensify/App/pull/9635
I think it would be better to display growl in this case that action is successful. What do you think?

cc @Julesssss as it appears like Alex is OOO today and this is hourly issue

There was a confirmation modal.

I was ooo most of yesterday, back today! I'm not sure this growl was necessary, i'll take a look at the design doc where this refactor happened to see if this detail was missed or if it's expected we don't show the growl

Ok the confirmation Growl wasn't specifically discussed in the doc, but I don't think the Growl is necessary. We automatically redirect the user to the sign in screen when they close their account, that should be good enough. I would say we just need to update the regression test steps to not look for the growl anymore

There was a confirmation modal.

Yeah, there was. IIRC the 'type your account details' was a replacement for this step though.
I also kinda think the growl should exist though. Regardless, it shouldn't be a deployblocker.

Yeah, there was. IIRC the 'type your account details' was a replacement for this step though.

I think you're right about this one. In the PR you can see that the only modal I changed was the error modal, not any confirm modal

I also kinda think the growl should exist though. Regardless, it shouldn't be a deployblocker.

Agree it should be a deploy blocker, the growl could make sense too - I think we are mainly trying to avoid growls now'days because they're only showing for a limited time and .. some other reasons I forget? But if you close your account, you get logged out and it doesn't really matter if you don't see the growl right?

I view this as an exception to the no growl rule as closing an account is an incredibly rare and important event. Also, when testing I did notice that there wasn't any feedback and it felt a bit odd -- almost like there had been an error.

I'm ok with either way - growl or no growl. I don't find it confusing that "close account" takes you back to the sign in page w/out a growl but I wouldn't be opposed to adding one there

Agree 👍 this seems like a "no growl" exception and we should add one to indicate that action succeeded.

Engaged in N07, will update soon

Will get back next week!

Working on it now!

I had a look at the User_Delete flow and the design doc. I thought of displaying a growl after we make a Write request here but realized we can't be optimistic that account will be deleted every time as we many checks here before deleting the account. So, I think the only way to add a growl is to make it use makeRequestWithSideEffects instead of Write. I'm not sure if we really want to change request type just to display growl.
@Beamanator @Julesssss thoughts? Should I bring this in slack, or :donothing:?

I think this could be a good convo to bring to slack, since:

As you mentioned, we try not to use makeRequestWithSideEffects when possible
Some people are adamant about not using Growls in our product, so maybe there's some other kind of message / notification we can display to the user

Discussing here https://expensify.slack.com/archives/C03TQ48KC/p1663931636325039

So when we push onyx update to clients, we can pass a message in ACCOUNT Onyx key and display it to user.
Here I tried displaying it on Login page.

@Expensify/design Please review and share your thoughts.
Context: When user closes their account and it is successful, they're redirected to login page. We want to display a message to tell them that their account is closed.
As in the screenshot above, I think we can display a message on the login page, Or make a new page with a message and a button to redirect to signin page.

FYI we have an onyx key closeAccount so maybe we can use that instead of ACCOUNT?

Yeah, that will be better 👍

Does closeAccount mean the account was deleted or the user logged out?

I think the above screenshot looks good 👍


Create a list of data sources that are used for the LLM

AS A product manager
I WANT TO have an overview of all the data sources
SO THAT there is one place where developers can refer to when they start data scraping
AC:

[ ] Created a file or a page where all the data sources are listed for data scraping
[ ] Additional info or contact information, so that the data can be accessed in case it is necessary
[ ] Ability to see when the list was modified and what was changed

File with the list of data sources can be found here: https://docs.google.com/spreadsheets/d/1dhF_WUy0OI8-G-qZfcp30tVguLrYl02UMF-XYodR4jU/edit?usp=sharing


want to customize data received from Part.prototype.getTable in PartialLoader before sending for translation

Want to customize data received from Part.prototype.getTable in PartialLoader before sending for translation
Your environment

version of angular-translate 2.18.0
version of angular 1.7.5

Steps to reproduce
I have implemented partial loader in my application.
But json files which contain data which needs to be translated has a application specific json format.
So In partialLoader, I want to customize my partial loader such a way that data received by Part.prototype.getTable needs to transform to standard json format before sending for translation.
https://github.com/angular-translate/angular-translate/blob/master/src/service/loader-partial.js#L55
data returned by this function needs to be customsied as per the requirement.
handleNewData function is having data from files so customization can be done at this step.
So please provide a way to do it.
https://github.com/angular-translate/angular-translate/blob/master/src/service/loader-partial.js#L75
It will be great if you provide a way to do such use case as it is very urgent issue.

I won't see major updates to the partial loader any more. So if you need bigger changes, I would suggest of creating your own one. Just create your own custom loader based on our partial loader code. Basically, a loader is only a function which returns a table of translations (wrapped in a promise).


Link to "closed tasks" in project summary

Hi!
In the project summary page there is a link to closed tasks.
When I click on the link, I get a "Page not found".
http://localhost/kanboard/?controller=project&action=show&project_id=1
Should'nt this link be like this instead? (project -> projectinfo)
http://localhost/kanboard/?controller=projectinfo&action=tasks&project_id=1
Best regards
Danny

You should upgrade because this issue have been fixed a while ago.


docs(dart): tweak Dart homepage banner

@wardbell: Are you OK with this change? Do you want me to duplicate any part of it to the TS/JS equivalents?

Merging...


Would be nice to have a function to repopulate the query with bindings.

query.fullSQL = query.sql;
query.bindings.forEach(function(binding, idx) {
query.fullSQL = query.fullSQL.replace('$' + (idx+1), "'" + binding + "'");
});

@pursual feel free to send a PR.
I've been working on another ORM recently, Azul.js. It's coming together really nicely, so I may not be spending as much time with Knex/Bookshelf in the future.


Spec reporting shows different line numbers in results

require "spec"

def my_it(file = __FILE__, line = __LINE__)
  it "my_it", file, line do
    true.should be_false
  end
end

my_it

The result from this spec looks like this:
F

Failures:

  1) my_it

       Expected: false
            got: true

     # eval:5

Finished in 83 microseconds
1 examples, 1 failures, 0 errors, 0 pending

Failed examples:

crystal spec eval:9 # my_it

The line number is 5 in the detailed result and 9 in the summary. This is because the detailed view shows the location where the AssertionFailed was raised while the summary shows the location given to it using file and line variables.
I'd suggest that both should show the same line number and it should be the location provided to it (my_it => 9). If you're using such spec helpers (and explicitly set the location of the caller), you're usually interested in the helper call that caused it, not the location in the helper method definition.
We should however make sure that it doesn't affect other cases: When an it block directly contains several individual expectations, the line number should certainly point the location where the expectation was raised.
Take this example spec:
require "spec"

it do
  true.should be_true
  true.should be_false
end

It currently prints this result:
F

Failures:

  1) assert

       Expected: false
            got: true

     # eval:5

Finished in 519 microseconds
1 examples, 1 failures, 0 errors, 0 pending

Failed examples:

crystal spec eval:3 # assert

Line 5 is actually the important line. I'd suggest that the summary should also point to this line. I guess pointing to the beginning of the example is actually just a leftover from when spec could only target the beginning of the block for selected execution.
In essence, if it is invoked with explicit file and line arguments, those should be used as location of the failing spec in both detailed result and summary. Otherwise it should implicitly use the location of the failing expectation (or exception).

FYI, I'm working on a pull request for this improved output and currently have the following:
`
.F
Failures:

Spec      (spec/play_spec.cr:4): foo does something with 3 and 4
Assertion (spec/play_spec.cr:6): (x + y).should eq(8)
Expected: 8
got: 7

Finished in 462 microseconds
2 examples, 1 failures, 0 errors, 0 pending
Failed examples:
spec/play_spec.cr:4 (@spec/play_spec.cr:6) # foo does something with 3 and 4
`
I'm not sure whether I should put the actual assertion in the small format at the bottom for example:
spec/play_spec.cr:4 ((x + y).should eq(8)@spec/play_spec.cr:6) # foo does something with 3 and 4
Thoughs?

Looks like you're trying to be more expressive... but I don't think that helps to improve readability.
I'd keep changes from the current output format at a minimum and go for something like @RX14 suggested.
By the way, I've been trying to setup some specs for the spec output. They're missing entirely.

What's your feeling on:
.F

Failures:

  1) Spec      (spec/play_spec.cr:4): foo does something with 3 and 4
     Assertion (spec/play_spec.cr:6): (x + y).should eq(8)

       Expected: 8
            got: 7

Finished in 462 microseconds
2 examples, 1 failures, 0 errors, 0 pending

Failed examples:

spec/play_spec.cr:4 (@spec/play_spec.cr:6) # foo does something with 3 and 4

Changes are fairly minimal but more explicit, and it means you get both line numbers in both outputs?
Also, I think I deleted my other comment as you posted, so I'm not sure which bit of it you're referring to.

Taking this code as a reference. In the above examples, @asterite and @RX14 referred to the same code, I've just added the file and line arguments because you'd usually want to know where the helper method was invoked, not where it defines the example (because that would be identical to all created by it_does_something).
require "spec"

private def it_does_something(x, y, file = __FILE__, line = __LINE__)
  it "does something with #{x} and #{y}", file, line do
    (x * y).should eq(12)
    (x + y).should eq(8)
  end
end

describe "foo" do
  it_does_something 2, 6
  it_does_something 3, 4
end

I would just add the following minimal changes:
 .F

 Failures:

   1) foo does something with 3 and 4
+     at spec/foo_spec.cr:12
+     Failure/Error: (x + y).should eq(8)

       Expected: 8
            got: 7

     # spec/foo_spec.cr:6

Finished in 83 microseconds
1 examples, 1 failures, 0 errors, 0 pending

Failed examples:

crystal spec spec/foo_spec.cr:12 # foo does something with 3 and 4

And an example which directly defines an expectation:
require "spec"

describe "foo" do
  it "does something with 3 and 4" do
    (3 + 4).should eq(8)
  end
end

F

Failures:

  1) foo does something with 3 and 4

       Expected: 8
            got: 7

     # spec/foo_spec.cr:5

Finished in 88 microseconds
1 examples, 1 failures, 0 errors, 0 pending

Failed examples:

-crystal spec spec/foo_spec.cr:4 # foo does something with 3 and 4
+crystal spec spec/foo_spec.cr:5 # foo does something with 3 and 4

Maybe we could add at spec/foo_spec.cr:4 in the detailed view like in the other example, but I'm not really conviced this would be necessary.

Personally, I would like spec/foo_spec.cr:4 in the detailed view, just for the sake of clarity and consistency.
I'll see if I can put something together today.


wine-unstable: 1.9.7 -> 1.9.11; add optional dependencies; opencl-icd: init; refactor flags

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I'm somewhat reluctant on adding all those dependencies to Wine. How much people would really use its, say, ODBC or GSM bindings? IMHO most of them won't matter to the vast majority of users if any, while blowing up the closure size.
Having said that, some people might actually find this useful. I propose to go with one addition at a time, backed by a use case. When the mass reaches critical levels we can refactor things to add with* flags so that people would get what they want with recompilation. What do you think?

On Tue, May 10, 2016 at 02:52:53PM -0700, Nikolay Amiantov wrote:

Having said that, some people might actually find this useful.
I propose to go with one addition at a time, backed by a use
case. When the mass reaches critical levels we can refactor
things to add with* flags so that people would get what they
want with recompilation. What do you think?

I am agreed with it. May be with couple presets, like "wineFull".
Also wineStaging can get some customization.
(anyway most games usually stick with "wine version, that work
stable with that game", so rebuilds is unavoidable ;))

I pushed another patch, to encode the (already depended on) libtxc_dxtn library into RPATH.
Regarding closure size:
> du -sh --total $(nix-store -qR /nix/store/8mynl7igi0s3zvg73b5d4hkfj4wkjzqw-wine-wow-1.9.8-staging)
...
1.5G    total

vs
> du -sh --total $(nix-store -qR /nix/store/0f88afn3fn4zxwwpsg7vzb0j3dyvqql9-wine-wow-1.9.9-staging)
...
1.8G    total

If you feel that's too much, I can hide it behind flags

That's indeed much but it also depends on whether what's gotten into closure is usually installed with Wine anyway or not. My guess is that  glib and gtk3 may be the main space eaters (and certainly not all Wine users would have them). Try to disable them and see what happens -- if it indeed helps let's move them behind flags.

I refactored wine's build expression to have a flag for everything, that's optional. Default flags are slightly less than in the original expression. I hope that this won't break any dependent, but it seems pretty reasonable, in that it includes widely used features like tls, curses, alsa, opengl and image formats.

@abbradar is there anything missing on this?

Completely forgot about this one, sorry! I'll review this once more, build and merge if there are no problems.

I haven't built all combinations but at least wineUnstable builds and wineFull configures. Thank you!


Update configuring-additional-lsa-protection.md

If RunAsPPL set to 2 does not work on anything except Win 11 22h2 and higher, then it shouldn't be here, since that OS already has its own section.  Can confirm on Win 10 22h2, that setting this to 2 still locks LSAProt in UEFI

#assign: @robinharwood, @Xelu86
@robinharwood @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Ar fix icon

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.4.47-alpha.4af670.0@codecademy/gamut-labs@19.11.3-alpha.4af670.0@codecademy/gamut@34.10.10-alpha.4af670.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60d4c70e456cbe46e96169b9--gamut-preview.netlify.appDeploy Logs


Keystone (V2): Get User Credentials

Pull request: Get user credentials #31

Model: openstackinabox.models.keystone.model.db.users


firebase-js-sdk build using Trampoline

Worked as expected:
https://github.com/firebase/firebase-js-sdk/pull/1654/files
https://fusion.corp.google.com/invocation/a2e51fb6-570f-4011-baac-fb267adb0fcc?target=cloud-devrel%2Fdpebot%2Ffirebase%2Ffirebase-js-sdk&drilldownTab=tests

cc @feiyang1


Distribute to hockeyapp suddenly failing

In version 1.6.0 I could successfully upload to hockeyapp by using the following settings.
ipa(
      workspace: "APPNAME.xcworkspace",
      configuration: "Beta",
      scheme: "Beta",
      destination: "build",
      identity: "Company BV",
      clean: true,
    )

hockey(
      api_token: "OUR_TOKEN",
      ipa: './build/APPNAME.ipa',
      notes_type: "1",
      notes: changelog,
    )

After upgrade (1.7.0) I get to following error:
Error when trying to upload ipa to HockeyApp: {"status"=>"error", "message"=>"App could not be created."}

Didn't touch anything and the app still lives in HockeyApp. Only thing that I changed is the ruby version (2.2.2).
EDIT
Tried to upload with the curl command from hockeyapp docs:
curl \
> -F "status=2" \
> -F "notes=Manual curl upload" \
> -F "notes_type=0" \
> -F<EMAIL_ADDRESS>\
> -F<EMAIL_ADDRESS>\
> -H "X-HockeyAppToken: API_TOKEN" \
> https://rink.hockeyapp.net/api/2/apps/APP_TOKEN/app_versions/upload

upload seems to work but can't install. Error: Unable to Download App.

So the upload work but you can't install it on your device? That sounds a lot like a code signing issue.

Well... It only works if I use the curl command from terminal. Upload doesn't work with the hockeyapp command from the fastfile.

it happened to me just delete the app and recreate it on hockey and you are done

I had this problem as well, but it went away when I gave the hockey action the application's public_identifier parameter.

I had the same error message and public_identifier worked for me too. Thanks!

Great to hear :+1:

Same here. public_identifier is required.

Just so this doesn't happen: https://xkcd.com/979/ for when someone comes along and sees this: My Hockey uploads were working fine and then suddenly stopped working. The reason is that I changed my app's bundle ID, which means the referenced HockeyApp app no longer is associated, so it was trying to upload it to an App ID that doesn't exist. I fixed it by editing my HockeyApp app to match my new bundle ID of my actual app.


TestBadRemoteSecret causes future tests to fail once secrets are removed

https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/33701/integ-pilot-multicluster-tests_istio/1409935357113274368
test fails at 18:10:00. Its missing endpoints for some service
istiod logs show the cluster update at same time: https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/33701/integ-pilot-multicluster-tests_istio/1409935357113274368/artifacts/pilot-de882957a19240769ee1a3c93/TestTraffic/services/case_2_service_port_match_in_cluster_cross-network-primary/_test_context/istio-state096177769/primary/istiod-8ccfbd58c-k2gk2_discovery.log
It looks like a single push (from debounce) is handling removal of the clusters and the addition of the new service
I am fairly sure I have seen this before, but couldn't find an issue...
cc @stevenctl

https://prow.istio.io/view/gs/istio-prow/pr-logs/directory/integ-pilot-multicluster-tests_istio/1404861847785443328
https://prow.istio.io/view/gs/istio-prow/pr-logs/directory/integ-pilot-multicluster-tests_istio/1404503012868624384

Did we ever root cause this? I feel like we have still seen it, although its rare

Possible recent occurances: https://prow.istio.io/view/gs/istio-prow/pr-logs/directory/integ-pilot-multicluster-tests_istio/1430996327751225344

Ah, sorry about that. I'll keep looking into it.

I have a better idea of what's happening, but not quite root cause.

2021-06-29T18:09:45.094570Z	info	Adding cluster no-permissions from secret istio-system/istio-remote-secret-no-permissions
...
2021-06-29T18:10:00.114489Z	error	Adding cluster_id from secret=no-permissions: istio-system/istio-remote-secret-no-permissions failed creating config configStore for cluster no-permissions: context deadline exceeded
2021-06-29T18:09:48.385662Z	info	Processing delete: istio-system/istio-remote-secret-no-permissions
2021-06-29T18:09:48.385713Z	info	Deleting cluster_id=no-permissions configured by secret=istio-system/istio-remote-secret-no-permissions

The queue in secretcontroller gets blocked by the addCallback and doesn't begin processing the delete till much later.
This explains why the issues aren't contained to the window for TestBadRemoteSecret, but this still shouldn't affect the main service registries.
The primary cluster is probably not configuring the inbound for b-alt-2 for whatever reason. From a in cross-network-primary
outbound|80||b-alt-2.echo-1-8933.svc.cluster.local::<IP_ADDRESS>:15443::cx_connect_fail::10

Trying to replicate this by:

From an injected sleep pod while true; do curl helloworld:5000/hello; sleep 3; done
Running only 1 istiod with a large debounce (30s, 60s max)
Pushing the bad remote secret and waiting 60s+
Deleting the secret and applying $iSTIO/samples/helloworld/helloworld.yaml

Looking at pilot logs, we start to get pushes immediately after the new proxies connect, then some time later we get the debounced push from the service/secrets.
Pretty much as soon as we push the new helloworld pods the sleep pod gets traffic, so nothing is misconfigured.
Any better ideas on how to replicate?

I tried a lot a while back, I could never reproduce it either...
On Thu, Sep 23, 2021 at 9:30 AM Steven Landow @.***>
wrote:

Trying to replicate this by:

From an injected sleep pod while true; do curl
helloworld:5000/hello; sleep 3; done
Running only 1 istiod with a large debounce (30s, 60s max)
Pushing the bad remote secret and waiting 60s+
Deleting the secret and applying
$iSTIO/samples/helloworld/helloworld.yaml

Looking at pilot logs, we start to get pushes immediately after the new
proxies connect, then some time later we get the debounced push from the
service/secrets.
Pretty much as soon as we push the new helloworld pods the sleep pod gets
traffic, so nothing is misconfigured.
Any better ideas on how to replicate?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/33708#issuecomment-925971441, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXK5FGTHG65FGJVSNGTUDNIZFANCNFSM47Q4T6FQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Updated to 14.5

Seems the 14.4 did not work for me, redid this to build instead of use an old image. And also updating to 14.5 Alpha that was just released

Will update my master @lucaperret

Master should now be updated  @lucaperret


MF-783 - Allow access checking by a thing ID

What does this do?
Adds new endpoint for checking access rights of a thing to the channel.
Which issue(s) does this PR fix/relate to?
Resolves #783.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
Yes, I've added new tests for this endpoint
Did you document any new/modified functionality?
I've updated swagger docs.

Codecov Report

Merging #784 into master will increase coverage by 0.22%.
The diff coverage is 92.23%.

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   85.23%   85.46%   +0.22%
==========================================
  Files          73       73
  Lines        4558     4657      +99
==========================================
+ Hits         3885     3980      +95
- Misses        445      450       +5
+ Partials      228      227       -1

Impacted Files
Coverage Δ

things/redis/streams.go
90.47% <0%> (-1.46%)
:arrow_down:

things/postgres/channels.go
80.55% <100%> (+1.5%)
:arrow_up:

things/api/auth/grpc/client.go
100% <100%> (ø)
:arrow_up:

things/api/auth/grpc/endpoint.go
100% <100%> (ø)
:arrow_up:

things/api/auth/http/endpoint.go
100% <100%> (ø)
:arrow_up:

things/api/auth/http/requests.go
100% <100%> (ø)
:arrow_up:

things/api/auth/grpc/server.go
96.49% <100%> (+1.36%)
:arrow_up:

things/api/auth/http/responses.go
100% <100%> (ø)
:arrow_up:

things/api/auth/http/transport.go
89.18% <100%> (+5.85%)
:arrow_up:

things/api/auth/grpc/requests.go
66.66% <50%> (-33.34%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7af7c...8309431. Read the comment docs.


feat: add xresource themes

Edit: Whoops, merged into the wrong branch. Sorry about that.

No worries! Btw you've read discussions right? We are making a remastered theme. Check it out, it's really cool and easy on the eyes. If you like it then I'd really appreciate it if you wrote an Xresources file for it too :).

Oh, thanks for notifying me of the update! I'll make sure to make an Xresources file for it when it's done.

Great! In that case I think you should subscribe to the issue tracking the big update 👍


Missing event

Hello,
In BC18.5 this event: https://github.com/microsoft/ALAppExtensions/issues/13941 is not available.
The other ones are (same kind of request):
https://github.com/microsoft/ALAppExtensions/issues/13938
https://github.com/microsoft/ALAppExtensions/issues/13939
https://github.com/microsoft/ALAppExtensions/issues/13940

Codeunit 5814 "Undo Return Shipment Line" has been updated accordingly request #13941. Seems the problem is about codeunit 5816 "Undo Return Receipt Line" which actually was not mentioned.

Oleg, Seems you are right, I mixed up the Github ID's in my own spreadsheet.
codeunit 5816 "Undo Return Receipt Line"
        ItemJnlLine."Bin Code" := "Bin Code";
        ItemJnlLine.Quantity := Quantity;
        ItemJnlLine."Quantity (Base)" := "Quantity (Base)";
        ItemJnlLine."Unit of Measure Code" := "Unit of Measure Code";
        ItemJnlLine."Qty. per Unit of Measure" := "Qty. per Unit of Measure";
        ItemJnlLine."Document Date" := ReturnRcptHeader."Document Date";

        OnAfterCopyItemJnlLineFromReturnRcpt(ItemJnlLine, ReturnRcptHeader, ReturnRcptLine);

        // DINNL <<
        DINOnBeforeWhseUndoQtyInsertTempWhseJnlLine(ReturnRcptLine, WhseUndoQty);
        // DINNL >>
        WhseUndoQty.InsertTempWhseJnlLine(
            ItemJnlLine,
            DATABASE::"Sales Line", SalesLine."Document Type"::"Return Order".AsInteger(), "Return Order No.", "Return Order Line No.",
            TempWhseJnlLine."Reference Document"::"Posted Rtrn. Rcpt.", TempWhseJnlLine, NextLineNo);

        if "Item Rcpt. Entry No." <> 0 then begin
            ItemJnlPostLine.Run(ItemJnlLine);
            exit(ItemJnlLine."Item Shpt. Entry No.");
        end;
        UndoPostingMgt.CollectItemLedgEntries(

[IntegrationEvent(false, false)]
local procedure DINOnBeforeWhseUndoQtyInsertTempWhseJnlLine(var ReturnRcptLine: Record "Return Receipt Line"; var WhseUndoQty: Codeunit "Whse. Undo Quantity")
begin
end;

So we do need those extra parameters on OnAfterCopyItemJnlLineFromReturnRcpt
Sorry for the confusion :) Thanks for your reply

NP.
It will be realized like similar events before:
OnAfterCopyItemJnlLineFromReturnRcpt(ItemJnlLine, ReturnRcptHeader, ReturnRcptLine, WhseUndoQty);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[Question] Recommended way to handle adding new tables in migration

I know migration of db isn't supported as of now. Implementing migration of existing table changes is more complicated, but adding new tables should achieveable.
Can melon-fire handle this now?
I can see that if there already exists 20 tables, but has data for only 5, only those 5 tables' data is uploaded. Later when the other tables have data, new variables are created and uploaded in Firestore.
So was wondering if melon-fire at this moment can handle new table creation as well?
If not, whats the best course of action to support only this.

Great question - I haven't taken a look at this, but I suspect you'll need migrations to work in order for this to really work. For instance, what should happen if a more recent version of your app uploads a backup that includes a new table, but an older version than syncs that data down? Migrations might be the only way to make that work.
I'd like the package to support migrations, but haven't had the need for them myself yet and haven't had the time to write them. Happy to take PRs, though, if anyone's up for it!


Same update should be applied to the Terror Dog task in the Morytania Medium Diary:

    Same update should be applied to the **Terror Dog** task in the Morytania Medium Diary:

Originally posted by @zahti in https://github.com/Zoinkwiz/quest-helper/issues/1018#issuecomment-1380805323

This should be resolved with https://github.com/Zoinkwiz/quest-helper/commit/b689ec35e4190fbaea10abe78adff59e3659c0ae


Apple raster support in libcupsimage: Page header is 32 bytes long, not 64 bytes

Following your hint in issue #4916, that the OfficeJet (which is an AirPrint printer and not an IPP Everywhere printer) should work your most recent fixes in the GIT repo, I had a deeper look into the repo and saw that you have added Apple raster support. Now I have tried it and the Apple raster generated by CUPS only printed the first page of each document, both on the mentioned OfficeJet, the Officejet Pro 8500 A910 via IPP, and on the DeskJet Ink Advantage 2540 via USB (regular CUPS "usb" backend, not IPP-over-USB).
So I had a look into your code and that Apple raster has 64-byte headers, where only the bytes 0, 1, and 12-23 were actually used for metadata. Then I compared with an old filter which is able to read Apple raster but based on reverse engineering and there the page header size is 32 bytes. So I tried changing your code to make the header size 32 bytes (and this drops only zeros, nothing of the metadata) and both printers started printing the Apple raster files correctly, all pages. A number of pages in the file header seems not to be required (was always zero in my sample files which I generated with the cupsfilter command).
Patch attached.
Please check through the rest of CUPS whether it needs further changes concerning the 32 byte long Apple raster headers.
urf-has-32-byte-headers.patch.txt

Note that this code is still BETA and subject to change. And the IANA registered name is "Apple raster"... :)

[master 98f204f] Fix size of header (Issue #4920)


Often PowerToys Run crashes when I start typing

Microsoft PowerToys version
0.66.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce

Press WinKey+Space
Start typing

✔ Expected Behavior
Not crashing - It happened 17 times in 12 days
❌ Actual Behavior
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22621.0
IntPtr Length: 8
x64: True
Date: 28/01/2023 08:56:43
Exception:
System.InvalidOperationException: Dispatcher processing has been suspended, but messages are still being processed.
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
2023-01-28.txt
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/18166

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!


[$1000] Can’t collapse “Open in New Expensify app” banner at top of page on mWeb (Safari)

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Access staging.new.expensify.com on a safari from a mobile device while having the app installed on your device
See persistent banner at top of page
Expected Result:
Allow the user to collapse the banner to make the most of screen real estate.
Actual Result:
User cannot collapse the banner.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.99-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @michaelhaxhiu
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681327348825739
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bca86576667d2dd3
Upwork Job ID:<PHONE_NUMBER>510245888
Last Price Increase: 2023-04-17

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reproduced. I don't think we want to remove this entirely (a link to the app is good + convenient) but I tested with another app (Reddit) and it goes away as you scroll down rather than remaining persistent, so I think that behaviour is one we should aim for.

Job added to Upwork: https://www.upwork.com/jobs/~01bca86576667d2dd3

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Triggered auto assignment to @Julesssss (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

We can export this one to callstack too

What's the behavior today on Android?
I think whatever we do here, we should just stay consistent b/w Android & iPhone.

Ya we can pass it to callstack if you think that's ideal @mountiny!

I think whatever we do here, we should just stay consistent b/w Android & iPhone.

I think this is system specific thing which is not that easy to make consistent.

Cool, thanks for reviewing Vit. I'll share with callstack.

Hi I'm Nicolay from Callstack - expert contributor group - will start investigation in this area

Awesome, thanks!

📣 @narefyev91 You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Still investigating possible solution, will update asap

Proposal
Please re-state the problem that we are trying to solve in this issue.
Suggested banner on the top of the page is not disappear during scrolling
What is the root cause of that problem?
I will say that we are not having any issue here. The major issue - is that banner adding by Safari itself, and stays outside of application DOM.
Also i can't say that application container built wrong in the app - because to make the same effect which we can see in youtube or reddit mobileWeb - main container should be scrollable.
If we trying to do the same (making global page container scrollable in RN) - all pages will started to be scrollable and also we will need to fully refactor our headers to be fixed - and they should be our of scrollable page to be fixed on top.
Like here:
https://user-images.githubusercontent.com/28352309/234804469-7d0f907c-ab0e-4666-906b-ff541f186213.MP4
BTW headers is not a general issue during refactoring - the main one - is that we will start having UX issues/regressions.
The most bad thing that we will get - is that any page - which should not have scrolling ability - will start getting this. For example this page

It should not be scrollable - because all content fully fit the page. But what will be happened you can see on youtube mobileWeb here:
https://user-images.githubusercontent.com/28352309/234805053-795dedc2-7d13-43df-9c9c-aecb7de72a6c.MP4
That page should not have any scroll - because content already occupied less space. And there no way to say - hey - let's not applying scrolling for this page - because you need to dismiss top banner on scroll on all pages.
And also - if user will not installed app - and banner will not be shown, what we will see in that case? Same bad UX - because we could not get information from browser - that app installed on the phone. And we will see this:
https://user-images.githubusercontent.com/28352309/234805991-f2735ebb-3b6b-43cc-870a-9c33518ee665.MP4
I can't really say on which framework both youtube/reddit were built - but one more issue which we will face - adding ScrollVIew we will have nested Flatlists on some pages - which may add performance issues for the app.
And i think one possible issue which will come up - will be content moving out of the screen when keyboard will be opened for android - because in the bottom we will have more space - and we will need to calculate space below TextInput every time when keyboard will be opened - without it - it will be move far away.
What changes do you think we should make in order to solve the problem?
Based on info above - i can suggest 3 ways here:

Do nothing as it would be a very complex refactor to do and could introduce UX/UI/RN problems/regressions above
We can stop using default banner for safari and integrate custom solution - which will work in safari/chrome on bot ios/android - like this https://medium.com/umamitech-blog/smart-app-banners-for-ios-and-android-a-handmade-solution-7785d6bca205, or this https://www.branch.io/resources/blog/how-to-setup-an-ios-and-android-smart-app-banner-with-deep-linking-and-download-tracking/ - but also there some styling limitations and issues around them - for example they will not be move out during scrolling - but will have close button

What alternative solutions did you explore?
If you think that we should really stay on decision to re-write the main part of the app, and everything above not so critical items - we can build parent scrollable container

@Julesssss @narefyev91 @bfitzexpensify @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Thanks for such thorough investigation @narefyev91 🙇
To be honest, I would say its better to do nothing here, essentially we are making sure you can use the app in mobile web but it will never be that good as native and I think its actually desirable and good to force people to download the app from app store. The banner is slim it does not take that much space so I would keep it there and focus on more important things now. Curious for your thoughts @Julesssss


No legacy renewals found Importing scheduled renewals from LEWS <IP_ADDRESS> to WACS <IP_ADDRESS>2

Hi,
I'm upgrading LEWS <IP_ADDRESS> to WACS <IP_ADDRESS>2
After copied new files in other location I run wacs, after I select O option and then I option to import all my scheduled renewals from old LEWS.
The problem is that No legacy renewals found.
am I doing something wrong?

How can I complete the update process to the new version importing all scheduled tasks from old version?
Thanks

If you could run both of those with --verbose I might be able to tell more, but it looks like the importer is not finding the proper file system or registry location to import from. This can be because it gets distracted by another location that gets higher preference but doesn't actually contain anything. You might be able to work around this by moving the renewals from registry to the file system yourself, following the upgrade instructions here: https://www.win-acme.com/manual/upgrading/to-v1.9.9

Thanks, I looked at the instructions indicated but I can't find any keys in SOFTWARE Windows Registry for letsencrypt-win-simple.
But can I solve it with a manual upgrade? I've approximately only 30 domain to update.
If I'm not wrong I should be able to update manually following this steps:

revoke one by one all ACME v.01 certificates with LEWS console
disable or delete LEWS scheduled task
create new ACME v.02 certificates for all just deleted certificates with new WACS console
I'm right? Can I go on in this way?

If they're not in the registry then they should be on the file system and the new version is looking for them in the wrong folder. Again the --verbose mode might give more info on where the file actually is (in the old version) and where it's expected to be found (in the new version). Moving a copy of the file to the place where it's looking for it would be the workaround.
As for your manual steps, the first one is not required. There is no need to cancel, delete or revoke anything on v1. Disabling the scheduled task is enough.

I've checked with --verbose and I can see that WACS try to import from C:\ProgramData\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org
It's right, the folder is the right folder with inside all certificates to import but WACS warn me with No legacy renewals found message!

It looks like there is no file called "Renewals" in that folder though, so the renewals must be coming from the registry. You may have been looking in the wrong place or - if you originally used an older version of the program - the data might be in the user-specific part of the registry (HKCU). The old letsencrypt.exe might reveal exectly where it's reading from with --verbose, though I'm not sure.
The fact that the new version prints "Legacy config folder..." doesn't mean that's it's actually trying to read the renewals from that location. I've added some extra debug messages to a new build so that it will report where it's reading from, if you wouldn't mind to help solve this mystery.
https://ci.appveyor.com/project/WouterTinus/win-acme-s8t9q/build/artifacts

Below you can see screenshot of latest build of WACS

if you can give me private email I can send you also LEWS --verbose screenshot, it contain privacy data.

You can share that with me at<EMAIL_ADDRESS>thanks in advance.
Looks like the new version of the program also cannot find the registry entries, but the old version sure can.

So I checked your screenshots and it's pretty surprising that you cannot see the registry entries yourself, nor the new version of the program can see them, while the old program does see them.
Did you download the 64 bit or 32 bit build?

Hi @WouterTinus
I'm using 64bit version, however I've solved adding all certificates one by one as new in WACS
I've also found little bug on Notification SMTP mail setting, it don't work in SSL mode only in clean mode on port 25 it work fine.

That email issue that you mentioned might be this one: #1437
I'm sorry that you had to manually recreate your renewals, it's a mystery to me how the old program version finds them but the new one (and your own registry editor) doesn't. I suspect something is either mixed up in the SysWOW abstraction layer or something related to different user profiles.

Closing this due to age and inactivity, appearantly this was a very isolate case.


Add a message to Findings

Findings should be able to store a localized message to be displayed in the code review where findings are marked.

I think we could write and attach messages to the metrics. For example:
IndentationCheck could be mapped to This line/block of code is not properly indented or some other more descriptive message better suited for displaying to the user.

@maximAtanasov I agree with you.

Closed in #356


Tried to show an alert while not attached to an Activity

Description
Migrating my existing libraries / apps from<EMAIL_ADDRESS>to the latest<EMAIL_ADDRESS>Using new architecture, targeting Android. Got Tried to show an alert while not attached to an Activity error when calling Alert.alert('abc', 'def');. Seems to be a regression of an old bug #13439?
P.S.: No, I had no chance yet to check whether it is reproducible in a clean RN app.
Steps to reproduce
Above.
React Native Version
0.75.2
Affected Platforms
Runtime - Android
Areas
Other (please specify)
Output of npx react-native info
N/A

Stacktrace or Logs
N/A

Reproducer
N/A
Screenshots and Videos
No response

@birdofpreyru could you provide a reproducer using this template? You can add whichever library you need to make the reproducer work.
It's quite hard for us to help out if we don't know how to repro it.

It seems to work fine on my side... Am I missing something?
https://github.com/user-attachments/assets/56e7c5a4-a05f-4b9e-b84c-55b0c9fb0e42

Hmm... it works now for me as well 0.o Tried everything that comes to my mind — the older commit at which I was when reporting it, a clean build, a few different Android versions in the emulator... still no problem anymore.


[Question] what is the appropriate naming convention?

What is the appropriate naming convention? These are some that I have found in the wild or from memory.

[ ] dnscrypt-proxy - This is the repository name
[ ] dnscrypt-proxy 2
[ ] DNSCrypt-proxy - personally I like this one or the next one
[ ] DNSCrypt-Proxy
[ ] DNSCrypt-Proxy 2 - This is the (awesome) logo
[ ] DNSCrypt proxy
[ ] other?

Basically I'm asking in order to establish more consistency in the documentation here and elsewhere.

I tend to use DNSCrypt for the protocol, and dnscrypt-proxy to refer the client, but this is indeed not very consistent with the logo. So... whatever you want :)

Hm I find that even more inconsistent. DNSCrypt where DNS is the acronym and where dnscrypt-proxy doesn't highlight this. I do agree that DNSCrypt is the best capitalisation for the protocol. BTW I always pronounce it "DNS Crypt Proxy" hence why I think the capitalisation could also reflect that. But I also understand that both the binary and the repository are all lower case and the v1 was always all lowercase. It's like curl and cURL. but I don't know anyone that actually says C U R L (as individual letters) vs curl.
So I think these are two good options: DNSCrypt-proxy ('protocol' + '-proxy') or dnscrypt-proxy (adding the 2 is just weird as that is the version number IMHO, I know it's a complete rewrite)
Let me know if you agree or disagree. I don't have a strong opinion just that it's consistent. e.g. 1, 2, 3

Maybe we should stick to dnscrypt-proxy for the tool, as it makes it more obvious that the protocol and the tool are different things.
I can update the logo to reflect this.


React: Navigation tagline has incorrect alignment

See screenshot. It looks like the tagline is left aligned instead of right aligned.
https://react.ui.ilo.org/?path=/docs/components-navigation-navigation--overview&globals=rtlDirection:!undefined
This happens in both LTR and RTL:

Hey @Shashika6, this still looks broken to me but your fix is merged. Could you have a look?
https://react.ui.ilo.org/?path=/docs/components-navigation-navigation--overview


Add daily task indicators

Sends a message in chatbox notifying the player if they can collect:

Herb boxes at NMZ
Staves from Zaff
Pure essence from Wizard Cromperty

Instead of using onGameTick, I decided to use onGameStateChanged to help increase performance as it won't be running thru the logic every single game tick; instead, now the logic will be ran thru whenever the gamestate changes to GameState.LOGGED_IN.
Also, the System.out.println's weren't meant to be pushed, as well as I forgot to complete the onConfigChanged method, sorry about that.


P.291 first paragraph

In original text of the first paragraph in  p. 291

We can see that the MSE on the training dataset is larger  than on the test set, which is an indicator that our model is slightly overfitting the training data in this case.

should be corrected as follows:

We can see that the MSE on the training dataset is less  than on the test set, which is an indicator that our model is slightly overfitting the training data in this case.

Good catch, thanks!


Add pod priorities to image builder and cleaner

The DIND and image cleaner pods have a priority of zero which I think means they can get evicted when there isn't enough room for pods with higher priority. This is my guess for the build up of pending build pods over night.
Is there a way to add a pod priority to all pods except certain ones? My guess is that we'd want a pod priority of 10 for everything except the placeholder pods. Right now we have to go and annotate matomo, dind, etc by hand to make sure they have a priority above zero.

@consideRatio do you remember why in the default-priority class globalDefault: false is set? From a quick look at https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#priorityclass I don't think there is a downside to doing this and it would save a lot of manual work of adding pod priority annotations to pods.

Instead of adding the priority class explicitly I will change the global flag to true.

Working this out on gitter: I believe this is a bug in the jupyterhub chart, not setting the default priority as the global default priority. Applying that fix and deploying it here should have the desired effect. We may need to restart pods to get it, though.

Pods does indeed need to be restarted for their priority to be updated.
The new proposed default priority:
podPriority:
  enabled: false
  globalDefault: true
  defaultPriority: 10
  userPlaceholderPriority: 0

And my recommended config for mybinder.org:
podPriority:
  enabled: true
  globalDefault: false
  userPlaceholderPriority: -10

@consideRatio sounds right to me!

Taken care of elsewhere.


cosmosdb DatabaseAccountListKeysResult (PrimaryMasterKey) is null if multiple pods are started at the same time

I have an AKS cluster with manged identies and AAD pod identiy. I have startup with keyvault and cosmosdb. It turns out that the pods upon startup crash because the master keys to access the cosmosdb cannot be retrieved. They are empty. After multiple restarts of the pods all pods are able to get the keys. Why is this behaviour?
Do I need to implement a token cache between pods?
Sometimes the pods start without any issue and other times they fail.
`            // AzureServiceTokenProvider will help us to get the Service Managed token.
var azureServiceTokenProvider = new AzureServiceTokenProvider();
        // Authenticate to the Azure Resource Manager to get the Service Managed token.
        string accessToken = await azureServiceTokenProvider.GetAccessTokenAsync("https://management.azure.com/");

        if (accessToken == null)
            throw new Exception("Failed: accesstoken CosmosDbService is null");

        // Setup the List Keys API to get the Azure Cosmos DB keys.

        string endPoint = $"https://management.azure.com/{cosmosDbConfiguration.Scope}/listKeys?api-version=2019-12-12";

        // Setup an HTTP Client and add the access token.
        HttpClient httpClient = new HttpClient();
        httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", accessToken);

        // Post to the endpoint to get the keys result.
        var result = await httpClient.PostAsync(endPoint, new StringContent(""));

        // Get the result back as a DatabaseAccountListKeysResult.
        DatabaseAccountListKeysResult keys = await result.Content.ReadAsAsync<DatabaseAccountListKeysResult>();

        if (keys == null || keys.PrimaryMasterKey == null)
            throw new Exception("Failed: PrimaryMasterKey CosmosDbService is null");`

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9dc95f42-25e6-42ba-a3d9-94ed896d7383
Version Independent ID: 00936b2f-959b-b55f-60d3-deaa7bea6e17
Content: How to use a system-assigned managed identity to access Azure Cosmos DB data
Content Source: articles/cosmos-db/managed-identity-based-authentication.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @j-patrick
Microsoft Alias: justipat

Hello @V4A001
Thank you for your feedback! We will review and update as appropriate.

@j-patrick Is there a precedence for this issue? Can you please check this further.

I still have this issue. It even happens with 1 pod during startup. I cannot go live as this is too risky.
`            // Get the result back as a DatabaseAccountListKeysResult.
DatabaseAccountListKeysResult keys = await result.Content.ReadAsAsync();
        if (keys == null || keys.PrimaryMasterKey == null)
            throw new Exception("Failed: PrimaryMasterKey CosmosDbService is null");`

I apologize for not responding sooner.  An https call should just be an https call.
What is your url. I am not familiar with the scope var, it should be something like:
string endpoint = $"https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/listKeys?api-version=2019-12-12";
For DatabaseAccountListKeysResult can you share your implementation? What is your deserializer?
I would also like to check the logs, can you share an activity id that fails?

From: V4A001 @.>
Sent: Friday, March 12, 2021 11:22 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Justin Patrick @.>; Assign @.>
Subject: Re: [MicrosoftDocs/azure-docs] cosmosdb DatabaseAccountListKeysResult (PrimaryMasterKey) is null if multiple pods are started at the same time (#70547)
I still have this issue. It even happens with 1 pod during startup. I cannot go live as this is too risky.
` // Get the result back as a DatabaseAccountListKeysResult.
DatabaseAccountListKeysResult keys = await result.Content.ReadAsAsync();
    if (keys == null || keys.PrimaryMasterKey == null)
        throw new Exception("Failed: PrimaryMasterKey CosmosDbService is null");`

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F70547%23issuecomment-797700935&data=04|01|Justin.Patrick%40microsoft.com|40e5ffd6df2a4184bac708d8e58c3404|72f988bf86f141af91ab2d7cd011db47|1|0|637511737624486361|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bg6rIxheiPt2xyyq8c5vjLqhWTtjzxZ1y8RUM1HK0sA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKBALP7PHOMZBA7GXDY4FA3TDJSYBANCNFSM4XSSXCFQ&data=04|01|Justin.Patrick%40microsoft.com|40e5ffd6df2a4184bac708d8e58c3404|72f988bf86f141af91ab2d7cd011db47|1|0|637511737624496356|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bEw%2FV13ZhT6%2FqI5oL69LDiT%2FbBirNYf7tP48CloYItA%3D&reserved=0.

the end point is same as yours. Otherwise it would not work occasionally. My code is:
`///
/// Creates a Cosmos DB database and a container with the specified partition key.
/// https://docs.microsoft.com/en-us/azure/cosmos-db/managed-identity-based-authentication
///
///
private static async Task InitializeCosmosClientInstanceAsync(ICosmosDbConfiguration cosmosDbConfiguration)
{
// AzureServiceTokenProvider will help us to get the Service Managed token.
var azureServiceTokenProvider = new AzureServiceTokenProvider();
        // Authenticate to the Azure Resource Manager to get the Service Managed token.
        string accessToken = await azureServiceTokenProvider.GetAccessTokenAsync("https://management.azure.com/");

        if (accessToken == null)
            throw new Exception("Failed: accesstoken CosmosDbService is null");

        // Setup the List Keys API to get the Azure Cosmos DB keys.

        string endPoint = $"https://management.azure.com/{cosmosDbConfiguration.Scope}/listKeys?api-version=2019-12-12";

        // Setup an HTTP Client and add the access token.
        HttpClient httpClient = new HttpClient();
        httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", accessToken);

        // Post to the endpoint to get the keys result.
        var result = await httpClient.PostAsync(endPoint, new StringContent(""));

        // Get the result back as a DatabaseAccountListKeysResult.
        DatabaseAccountListKeysResult keys = await result.Content.ReadAsAsync<DatabaseAccountListKeysResult>();

        if (keys == null || keys.PrimaryMasterKey == null)
            throw new Exception("Failed: PrimaryMasterKey CosmosDbService is null");

        //CosmosClient client = new CosmosClient(account, key);
        CosmosClient client = new CosmosClient(
            $"https://{cosmosDbConfiguration.Account}.documents.azure.com:443/",
            keys.PrimaryMasterKey,
            new CosmosClientOptions()
            {
                SerializerOptions = new CosmosSerializationOptions()
                {
                    PropertyNamingPolicy = CosmosPropertyNamingPolicy.CamelCase
                }
            });
        CosmosDbService cosmosDbService = new CosmosDbService(client, cosmosDbConfiguration.DatabaseName, cosmosDbConfiguration.ContainerName);
        DatabaseResponse database = await client.CreateDatabaseIfNotExistsAsync(cosmosDbConfiguration.DatabaseName);
        await database.Database.CreateContainerIfNotExistsAsync(cosmosDbConfiguration.ContainerName, $"/{Company.PartitionKeyPath}");

        return cosmosDbService;
    }`

Hi @V4A001, we're happy to help with this issue further. Because this is not an issue with the documentation. For technical troubleshooting could you please either:

Post the question here: Microsoft Q&A
File a support ticket from the portal.

Thanks!

#please-close


Run tests on a bigger dataset

This adds another GitHub Actions job that tests StrobeAlign on a somewhat bigger dataset. The idea is to compare the SAM/BAM output against a "baseline" commit for which we assume StrobeAlign produces correct results.
The file tests/baseline_commit.txt sets this baseline commit. It is currently ef86bce15896b5cca437c54ff95dfad40da2145a, which is the same as the current main. We have established that this version gives us results that are sufficienty close in accuracy to v0.7.1, so this should be a good starting point. Whenever mapping results change on purpose, we need to update the commit hash in that file. I am not super happy with this procedure and would prefer to not have this manual update, but have to think a bit how to improve upon that.
The steps of the GitHub Action are as follows:

A D. melanogaster reference and 100'000 real reads from the Sequence Read Archive are downloaded. This step takes a bit long, so I tried to enable caching for it. This means that the dataset is only re-downloaded from SRA if the download.sh script changes, and otherwise the cached files directly from GitHub servers are used.
A StrobeAlign binary is built for the baseline commit.
A StrobeAlign binary is built for HEAD.
The test data is mapped using the baseline binary.
The test data is mapped using the HEAD binary.
The BAM outputs are compared using a new samdiff script. This is based on the script that I wrote for the detective work in #140.

I will temporarily add a commit with a deliberate bug so you can see what the samdiff script produces if there are differences. Note that the script only compares reference name and position for each SAM record. It ignores changes in MAPQ, CIGAR, TLEN etc. This is on purpose because this test is about noticing when alignment accuracy decreases. Those other changes should already be caught by the existing tests.
@ksahlin Regarding the choice of dataset, I feel a bit bad that I’m not using one of the simulated datasets that you generated for this. One reason is that these files need to be put somewhere for download and I didn’t quite know where. The main reason, however, was that the real dataset was much better able to flag the bad commits. I evaluated all three datastes (your simulated dataset 1 and 2 and the real Drosophila dataset I use now), and looked at twelve different commits between v0.7.1 and main that introduced some relevant change in alignment results. Dataset 1 flagged 2/12, dataset 2 flagged 6/12 and the real Drosophila dataset flagged 11/12 commits.
The downside with using a real dataset is that we don’t have expected mapping locations. We can start using a simulated dataset when that becomes important.

This is super! And great that the drosophila real data flags even more commits.
Does this mean the there are more commits producing differences besides the ones detected in #140? I count 10 commits besides baseline in that issue.

Does this mean the there are more commits producing differences besides the ones detected in #140? I count 10 commits besides baseline in that issue.

The two additional commits are ba8e901 and d8a1341. Not sure why left them out of the table, but the first commit added a bug that was fixed in the second commit one day later.
I noticed that there’s a 13th commit 5b462d6f594a28f1e9a23bd133e485b233c1f3e2 mentioned in one of the comments. That one is also flagged by the real Drosophila dataset.

I see!

Merging this because I finally want to be able to get back to refactoring :smile:

sounds good :)


Cannot import mdns from a Worker

I am trying to use mdns from inside of a Node.js Worker, but when I do I get the following error:
Module did not self-register: '/<...snipped...>/node_modules/mdns/build/Release/dns_sd_bindings.node'.
The import statement (written in TypeScript) is:
import mdns, {Browser, Service} from "mdns";
When I do this from the main thread, it works like a charm.  I have done all the usual npm/node_modules tricks online trying to resolve and/or rebuild the library, but no dice.
OS:  MacOS 12.5.1
Node: 18.9.0
mdns:  2.7.2
Please let me know what other information would be helpful here.

For what it's worth, I have isolated the error as arising from the import statement itself (a simple console log statement afterward never gets executed).

Here's the associated stack trace (sorry I forgot it earlier):
    at Object.Module._extensions..node (node:internal/modules/cjs/loader:1203:18)
    at Module.load (node:internal/modules/cjs/loader:997:32)
    at Function.Module._load (node:internal/modules/cjs/loader:838:12)
    at Module.require (node:internal/modules/cjs/loader:1021:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/<...snipped...>/node_modules/mdns/lib/dns_sd.js:24:20)
    at Module._compile (node:internal/modules/cjs/loader:1119:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1173:10)
    at Object.require.extensions.<computed> [as .js] (/<...snipped...>/node_modules/ts-node/src/index.ts:1608:43)
    at Module.load (node:internal/modules/cjs/loader:997:32)

In case it helps, here's what the TS compiles to:
var __importDefault = (this && this.__importDefault) || function (mod) {
    return (mod && mod.__esModule) ? mod : { "default": mod };
};
Object.defineProperty(exports, "__esModule", { value: true });
const node_worker_threads_1 = require("node:worker_threads");
console.log('WONK: About to import...');  // <-- this is output
const mdns_1 = __importDefault(require("mdns"));
console.log(`WONK: ${mdns_1.default.tcp('foo')}`);  // <-- never gets here

Another interesting data point:  Our project had been importing the module in the main thread (creating an Advertisement) as well as in the worker thread.  When I comment out the import from the main thread and stub out the calls, the import works in the worker thread (tested a few times now without any error...I see both the log message before and after the import).

Hi @bguezzie,
thanks for reporting this. Could you do me a favour and provide a pure javascript minimal reproducer? Just a single file (or block of code) that launches a worker and fails on require(...) demonstrating the issue.
Thanks!


Are there instructions for completely removing?

Operating System Version: Win10
Provider (VirtualBox/VMWare):  VMWare
Vagrant Version:  2.2.6
Packer Version:  1.5.1
Are you using stock boxes (downloaded) or were they built from scratch using Packer?  downloaded
Is the issue reproducible or intermittent?  unsure

BLUF:  I've lost lots of the logs and errors that would help with debugging and troubleshooting.  Is there a way to completely remove and uninstall so I can start from a clean environment?
I downloaded the master package about 6/7 months ago, tried to install, ran into some problems where I apparently tried to install the vmware version without the plugin.  I then got distracted for several months and started working on this again a couple of days ago.
I had since purchased the plugin and I followed the instructions on the main page.  But when I ran the build.ps1 script, I constantly got the following error:
preflight_checks : You appear to have already created at least one Vagrant instance. This script
does not support already created instances. Please either destroy the existing instances or follow
the build steps in the README to continue.
So I downloaded the newest master from the github page and tried again.  Same error.
As there was no documentation regarding this error, I ended up getting support from vagrant and it was fixed by downloading the plugin and installing rather than using the command line install shown in your instructions.  Now when I ran the build.ps1 script, things seemed to work great.
I ran this command: powershell .\build.ps1 vmware_desktop -VagrantOnly
But then, I confess, I was doing multiple things and running other vms during the build (yeah, I know) and while logger started just fine, nothing else downloaded or worked.  So I stopped everything and ran the command again.  This time logger didn't work either.  Downloaded again, tried again, and nothing worked again.
The problem is with all these attempts, I've lost A LOT of the errors and output and things that would help you know what is wrong and what to fix.
So I'm wondering if there is a way to uninstall and remove everything, and start clean so if I start running into errors again, I can record them properly?
Below is the link to the log file and the screen output
Link to Gist Containing Build Logs:

Another question, if vagrant is fully installed, does the build.ps1 script have to be run from an elevated prompt or can a normal user run it?

Hi @reswob10 , there aren't instructions but there should be! From the DetectionLab/Vagrantfolder, run vagrant status. You should see something like this:
Current machine states:

logger                    suspended (vmware_desktop)
dc                        not created (vmware_desktop)
wef                       not created (vmware_desktop)
win10                     not created (vmware_desktop)

To start fresh, run vagrant destroy -f and it will remove any created virtual machines and bring you back to a clean state. Let me know if that works for you and let me know if you run into any additional issues!

OK, the vagrant destroy -f worked fine.
Then I tried 2x.
First time from user account on Win10.
attempt_as_user.zip
That did not work.
Second time attempt under admin account on Win10
attempt_as_admin.zip
That partially worked.  logger installed and is running, but nothing else.
logs and screen output in zip files.  let me know if you can't get the files and I'll post differently

@reswob10 , welcome! Does using the following command switch change anything with your setup?

.\build.ps1 -ProviderName vmware_desktop -VagrantOnly

I am not too sure if the ProviderName is automatically getting triggered and assuming something else... There are other errors that I need time to look into such as not being able to reach Splunk's site, the existing shared folder conflict(?) and other things.

sorry for the delay, I'll try this tomorrow....
Craig L Bowser

This email is measured by size.  Bits and bytes may have settled during
transport.
On Wed, Jan 8, 2020 at 10:45 AM Michael Seborowski<EMAIL_ADDRESS>wrote:

@reswob10 https://github.com/reswob10 , welcome! Does using the
following command switch change anything with your setup?
.\build.ps1 -ProviderName vmware_desktop -VagrantOnly
I am not too sure if the ProviderName is automatically getting triggered
and assuming something else... There are other errors that I need time to
look into such as not being able to reach Splunk's site, the existing
shared folder conflict(?) and other things.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clong/DetectionLab/issues/371?email_source=notifications&email_token=AAI2XZANL36PLOCQMLCBRVDQ4XYJNA5CNFSM4KEARHVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIM72XY#issuecomment-572128607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI2XZCT5Z6EMJTIDUBDISLQ4XYJNANCNFSM4KEARHVA
.

OK progress.
logs attached and Screen output below
E:\DetectionLab-master>powershell .\build.ps1 -ProviderName vmware_desktop
-VagrantOnly
[preflight_checks] Running..
[preflight_checks] Checking if Vagrant is installed
[preflight_checks] Checking for pre-existing boxes..
[preflight_checks] Checking for vagrant instances..
[preflight_checks] Checking disk space..
The following drives have less than 80GB of free space. They should not be
used for deploying DetectionLab
[] C
[] D
You can safely ignore this warning if you are deploying DetectionLab to a
different drive.
[preflight_checks] Checking if vagrant-reload is installed..
[preflight_checks] Finished.
[main] Running vagrant_up_host for: logger
[vagrant_up_host] Running for logger
Attempting to bring up the logger host using Vagrant
[vagrant_up_host] Finished for logger. Got exit code: 0
[main] vagrant_up_host finished. Exitcode: 0
Good news! logger was built successfully!
[main] Finished for: logger
[main] Running vagrant_up_host for: dc
[vagrant_up_host] Running for dc
Attempting to bring up the dc host using Vagrant
[vagrant_up_host] Finished for dc. Got exit code: 0
[main] vagrant_up_host finished. Exitcode: 0
Good news! dc was built successfully!
[main] Finished for: dc
[main] Running vagrant_up_host for: wef
[vagrant_up_host] Running for wef
Attempting to bring up the wef host using Vagrant
[vagrant_up_host] Finished for wef. Got exit code: 0
[main] vagrant_up_host finished. Exitcode: 0
Good news! wef was built successfully!
[main] Finished for: wef
[main] Running vagrant_up_host for: win10
[vagrant_up_host] Running for win10
Attempting to bring up the win10 host using Vagrant
[vagrant_up_host] Finished for win10. Got exit code: 1
[main] vagrant_up_host finished. Exitcode: 1
WARNING: Something went wrong while attempting to build the win10 box.
Attempting to reload and reprovision the host...
[main] Running vagrant_reload_host for: win10
[vagrant_reload_host] Running for win10
[vagrant_reload_host] Finished for win10. Got exit code: 0
[main] Finished for: win10
[main] Running post_build_checks
[post_build_checks] Running Splunk Check.
[download] Running for
https://<IP_ADDRESS>:8000/en-US/account/login?return_to=%2Fen-US%2F,
looking for This browser is not supported by Splunk
Error occured on webrequest: Exception calling "DownloadString" with "1"
argument(s): "Unable to connect to the remote server"
[post_build_checks] Splunk Result: False
[post_build_checks] Running Fleet Check.
[download] Running for https://<IP_ADDRESS>:8412, looking for Kolide Fleet
Error occured on webrequest: Exception calling "DownloadString" with "1"
argument(s): "Unable to connect to the remote server"
[post_build_checks] Fleet Result: False
[post_build_checks] Running MS ATA Check.
[download] Running for https://<IP_ADDRESS>, looking for
Error occured on webrequest: Exception calling "DownloadString" with "1"
argument(s): "Unable to connect to the remote server"
[post_build_checks] ATA Result: False
WARNING: Splunk failed post-build tests and may not be functioning
correctly.
WARNING: Fleet failed post-build tests and may not be functioning correctly.
WARNING: MS ATA failed post-build tests and may not be functioning
correctly.
[main] Finished post_build_checks
Craig L Bowser

This email is measured by size.  Bits and bytes may have settled during
transport.
On Wed, Jan 8, 2020 at 10:53 PM craig bowser<EMAIL_ADDRESS>wrote:

sorry for the delay, I'll try this tomorrow....
Craig L Bowser

This email is measured by size.  Bits and bytes may have settled during
transport.
On Wed, Jan 8, 2020 at 10:45 AM Michael Seborowski <
<EMAIL_ADDRESS>wrote:

@reswob10 https://github.com/reswob10 , welcome! Does using the
following command switch change anything with your setup?
.\build.ps1 -ProviderName vmware_desktop -VagrantOnly
I am not too sure if the ProviderName is automatically getting triggered
and assuming something else... There are other errors that I need time to
look into such as not being able to reach Splunk's site, the existing
shared folder conflict(?) and other things.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clong/DetectionLab/issues/371?email_source=notifications&email_token=AAI2XZANL36PLOCQMLCBRVDQ4XYJNA5CNFSM4KEARHVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIM72XY#issuecomment-572128607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI2XZCT5Z6EMJTIDUBDISLQ4XYJNANCNFSM4KEARHVA
.

vagrant_up_wef.log
vagrant_up_win10.log
vagrant_up_dc.log
vagrant_up_logger.log
I think this time the files attached...

Cleared out 45gb space on the c drive without deleting those files and
tried again. Same failure.
Suggestions?
On Thu, Jan 9, 2020, 9:02 PM craig bowser<EMAIL_ADDRESS>wrote:

OK progress.
logs attached and Screen output below
E:\DetectionLab-master>powershell .\build.ps1 -ProviderName vmware_desktop
-VagrantOnly
[preflight_checks] Running..
[preflight_checks] Checking if Vagrant is installed
[preflight_checks] Checking for pre-existing boxes..
[preflight_checks] Checking for vagrant instances..
[preflight_checks] Checking disk space..
The following drives have less than 80GB of free space. They should not be
used for deploying DetectionLab
[] C
[] D
You can safely ignore this warning if you are deploying DetectionLab to a
different drive.
[preflight_checks] Checking if vagrant-reload is installed..
[preflight_checks] Finished.
[main] Running vagrant_up_host for: logger
[vagrant_up_host] Running for logger
Attempting to bring up the logger host using Vagrant
[vagrant_up_host] Finished for logger. Got exit code: 0
[main] vagrant_up_host finished. Exitcode: 0
Good news! logger was built successfully!
[main] Finished for: logger
[main] Running vagrant_up_host for: dc
[vagrant_up_host] Running for dc
Attempting to bring up the dc host using Vagrant
[vagrant_up_host] Finished for dc. Got exit code: 0
[main] vagrant_up_host finished. Exitcode: 0
Good news! dc was built successfully!
[main] Finished for: dc
[main] Running vagrant_up_host for: wef
[vagrant_up_host] Running for wef
Attempting to bring up the wef host using Vagrant
[vagrant_up_host] Finished for wef. Got exit code: 0
[main] vagrant_up_host finished. Exitcode: 0
Good news! wef was built successfully!
[main] Finished for: wef
[main] Running vagrant_up_host for: win10
[vagrant_up_host] Running for win10
Attempting to bring up the win10 host using Vagrant
[vagrant_up_host] Finished for win10. Got exit code: 1
[main] vagrant_up_host finished. Exitcode: 1
WARNING: Something went wrong while attempting to build the win10 box.
Attempting to reload and reprovision the host...
[main] Running vagrant_reload_host for: win10
[vagrant_reload_host] Running for win10
[vagrant_reload_host] Finished for win10. Got exit code: 0
[main] Finished for: win10
[main] Running post_build_checks
[post_build_checks] Running Splunk Check.
[download] Running for
https://<IP_ADDRESS>:8000/en-US/account/login?return_to=%2Fen-US%2F,
looking for This browser is not supported by Splunk
Error occured on webrequest: Exception calling "DownloadString" with "1"
argument(s): "Unable to connect to the remote server"
[post_build_checks] Splunk Result: False
[post_build_checks] Running Fleet Check.
[download] Running for https://<IP_ADDRESS>:8412, looking for Kolide
Fleet
Error occured on webrequest: Exception calling "DownloadString" with "1"
argument(s): "Unable to connect to the remote server"
[post_build_checks] Fleet Result: False
[post_build_checks] Running MS ATA Check.
[download] Running for https://<IP_ADDRESS>, looking for
Error occured on webrequest: Exception calling "DownloadString" with "1"
argument(s): "Unable to connect to the remote server"
[post_build_checks] ATA Result: False
WARNING: Splunk failed post-build tests and may not be functioning
correctly.
WARNING: Fleet failed post-build tests and may not be functioning
correctly.
WARNING: MS ATA failed post-build tests and may not be functioning
correctly.
[main] Finished post_build_checks
Craig L Bowser

This email is measured by size.  Bits and bytes may have settled during
transport.
On Wed, Jan 8, 2020 at 10:53 PM craig bowser<EMAIL_ADDRESS>wrote:

sorry for the delay, I'll try this tomorrow....
Craig L Bowser

This email is measured by size.  Bits and bytes may have settled during
transport.
On Wed, Jan 8, 2020 at 10:45 AM Michael Seborowski <
<EMAIL_ADDRESS>wrote:

@reswob10 https://github.com/reswob10 , welcome! Does using the
following command switch change anything with your setup?
.\build.ps1 -ProviderName vmware_desktop -VagrantOnly
I am not too sure if the ProviderName is automatically getting triggered
and assuming something else... There are other errors that I need time to
look into such as not being able to reach Splunk's site, the existing
shared folder conflict(?) and other things.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clong/DetectionLab/issues/371?email_source=notifications&email_token=AAI2XZANL36PLOCQMLCBRVDQ4XYJNA5CNFSM4KEARHVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIM72XY#issuecomment-572128607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI2XZCT5Z6EMJTIDUBDISLQ4XYJNANCNFSM4KEARHVA
.

It looks like Win10 is out of disk space from your vagrant_up_win10.log. I would ignore the post-build tests for now and see if you can access any of the services (Splunk, Fleet, Guacamole):
==> win10: Adding box 'detectionlab/win10' (v1.4) for provider: vmware_desktop
    win10: Downloading: https://vagrantcloud.com/detectionlab/boxes/win10/versions/1.4/providers/vmware_desktop.box

    win10: Download redirected to host: vagrantcloud-files-production.s3.amazonaws.com

    win10: Progress: 9% (Rate: 5735k/s, Estimated time remaining: 0:13:01)
    win10: Progress: 10% (Rate: 6174k/s, Estimated time remaining: 0:12:55)
    win10: Progress: 26% (Rate: 6028k/s, Estimated time remaining: 0:10:29)
    win10: Progress: 30% (Rate: 6073k/s, Estimated time remaining: 0:09:50)
    win10: Progress: 47% (Rate: 7011k/s, Estimated time remaining: 0:07:11)
    win10: Progress: 73% (Rate: 6039k/s, Estimated time remaining: 0:03:33)
    win10: Progress: 75% (Rate: 5721k/s, Estimated time remaining: 0:03:13)
    win10: Progress: 77% (Rate: 6041k/s, Estimated time remaining: 0:02:58)
    win10: Progress: 82% (Rate: 5942k/s, Estimated time remaining: 0:02:26)
    win10: Progress: 84% (Rate: 6831k/s, Estimated time remaining: 0:02:07)
    win10: Progress: 100% (Rate: 6847k/s, Estimated time remaining: --:--:--)
    win10:
    win10: Calculating and comparing box checksum...
vagrant.exe : The box failed to unpackage properly. Please verify that the box
At E:\DetectionLab-master\build.ps1:295 char:3
+   &vagrant.exe @('up', $VagrantHost, '--provider', "$ProviderName") 2 ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (The box failed ...fy that the box:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

file you're trying to add is not corrupted and that enough disk space
is available and then try again.
The output from attempting to unpackage (if any):

OK, you guys are great.  So first after reading your reply, I found issue #48 which dealt with the same issue and suggested a solution:  https://github.co/clong/detectionlab/issues/48
Then a simple google reminded me how to change the VAGRANT_HOME environmental variable.
I did find that after clearing space, Win10 did download and start (so now I had four machines) and I was able to get into Fleet, but not the other two.  I also found the page where you provide vagrant usage (https://github.com/clong/DetectionLab/wiki/Vagrant-Usage) and troubleshooting (https://github.com/clong/DetectionLab/wiki/Known-Issues-and-Workarounds) and I'll work through those to try and get Splunk and guacamole up and running.
thanks again.

Awesome! I'm glad to hear progress is being made. If you conintue run into additional issues, feel free to hit me up on bloodhoundhq.slack.com in the #detectionlife channel for more real time help :)

I created this wiki page for folks to use moving forward: https://github.com/clong/DetectionLab/wiki/Starting-Fresh-(Hard-Reset-for-Troubleshooting).
I'm going to go ahead and close this issue out.

Can I suggest you also add some direction to delete the machines in vmware
workstation and/or virtualbox?  I notice I have orphaned machines in my
vmware workstation.  I don't know if they affect anything on re-install,
but it makes a clean start to delete them.
Craig L Bowser

This email is measured by size.  Bits and bytes may have settled during
transport.
On Mon, Jan 13, 2020 at 9:08 PM Chris Long<EMAIL_ADDRESS>wrote:

Closed #371 https://github.com/clong/DetectionLab/issues/371.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clong/DetectionLab/issues/371?email_source=notifications&email_token=AAI2XZG4SKF3HOWT2UCWFJDQ5UNAXA5CNFSM4KEARHVKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV6HZ6CY#event-2945425163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI2XZCY54I3PMP2XM4J343Q5UNAXANCNFSM4KEARHVA
.


Customized metrics

Is your feature request related to a problem? Please describe.
New metrics need to be implemented and hard coded in the Polaris client whenever new modality and benchmarks introduce them.  This has been the bottleneck for the benchmark creation process.
Describe the solution you'd like
An approach is needed that allows flexible, customized metrics while maintaining the robustness of the Polaris client codebase. Balancing flexibility with stability is key to ensuring that users can easily introduce new metrics without compromising the integrity of the system.

hello, I'm working on the EvoScale BioML hackathon so I'm under time constraints.
I have a custom metric that doesn't fit into the two-column specification of your design. it would be great to connect with you to help out with a solution for our submission. Thanks.

hey, thanks for getting back to me @cwognum
we are uploading a new dataset called OpenPlasmid. our evaluation looks at how well different plasmid sequence embedding methods reflect the similarity of plasmid feature annotations. so, we basically take the plasmid embeddings of a new method, cluster them, and then compute NMI and ARI relative to labels to quantify expected similarity.
any idea how this could fit into your framework?

Oeh, that's interesting, but I'm afraid it's not a great fit for the current state of the platform... We've been focused on predictive modeling.
However, it sounds like you could ask people to submit the cluster annotations and then compare that against the ground truth clustering.
So, for example, your dataset may look like:

Plasmid ID
Cluster

0
0

1
0

2
1

3
1

The predictions would then e.g. look like: [1, 1, 0, 2].
So:
from sklearn.metrics.cluster import normalized_mutual_info_score as nmi
from sklearn.metrics import adjusted_rand_score as ari

nmi([0, 0, 1, 1], [1, 1, 0, 2])
# Gives: ~0.800

ari([0, 0, 1, 1], [1, 1, 0, 2])
# Gives: ~0.571

That does mean you don't have any control over the clustering algorithm. I understand that that may not be ideal, but you could make clear in your README how people are supposed to do the clustering and ask people to attach a link to the code when they submit  results (Polaris has a dedicated field for this, see here).

ok, yeah thats prob a sufficient work around for now. thanks for the suggestion!

hey, figured I'd be back.. realizing that there is not a way to add new metrics for usage with SingleTaskBenchmarkSpecification? Doesnt seem like I can extend the Metric class

Hey! You can, but it's a bit of a manual process. You'll have to create a PR in this repo. See e.g. https://github.com/polaris-hub/polaris/pull/199 and https://github.com/polaris-hub/polaris/pull/48 .
This is a bit of a frustrating process, which is why we created this issue to begin with.


New package: PostgreSQL.PostgreSQL.17 version 17.0-1

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

Verify:


To add SSG, to avoid redeployment of the website after every post added

PROBLEM
Whenever a new notion doc is uploaded, the site has to redeploy manually
SOLUTION
To generate static site after every time interval (eg. 5 min / 10 min / 1 hr)

Hi, @hkirat Sir, I have completed this assignment. Should I go for PR

Hey @mvp5464 , I didn't know that we had to create an issue first. As a result I have already created a pull request #136 .
Did you use a similar approach, also, did you face the issue with ESLint as well regarding named exports?

Ok then I will not create the PR for this issue.
Yes same problem.

How did you solve it? can you check the file changes in the pr and let me know if you had a different approach? thanks.

Added Revalidation whenever the backend endpoint is hit

We can add this to a button which is used to upload the notion docs (so if successfully uploaded then hit this link) [as TracksEditor.tsx is empty so not able to do that]
So It won't render in intervals but only when the notion doc is uploaded.
@hkirat sir, Is this good or need to add something else

Screencast.webm

How did you solve it? can you check the file changes in the pr and let me know if you had a different approach? thanks.

In time duration I had done alsmost the same

Your backend revalidation request is something even I am trying. Can you share your implementation here?

Your backend revalidation request is something even I am trying. Can you share your implementation here?

Sure, I am pushing PR but it is giving  me type error

it looks good on the video.
can you share the code snippet here?
of the backend request function and implementation on the front end?

So It won't render in intervals but only when the notion doc is uploaded.

Made PR So check it there and if any doubt or any suggestions mention me.

Added Revalidation whenever the backend endpoint is hit

We can add this to a button which is used to upload the notion docs (so if successfully uploaded then hit this link) [as TracksEditor.tsx is empty so not able to do that]
So It won't render in intervals but only when the notion doc is uploaded.
@hkirat sir, Is this good or need to add something else

Screencast.webm

Hey, currently there is no backend endpoint being hit for uploading the notionDoc. The file seed.ts is used to fill the data locally.

Check out #141 .. your implementation is top notch, however shouldn't we add an api route to the next app since we are using the app router and not the pages router?
you can check out the code and let me know if I am assuming incorrectly.

Hi @bhutoria, PR #138  has been created for this issue, so kindly close the duplicate PR #141.
I read that it may create conflict, So suggested to created this pages directory. page directory should be in the same level as the app directory. If this is wrong I will change my PR to add it back to an api route.
BTW, Thank you for your suggestions, and if have any doubt happy to help on this issue

yeah, we are using Next v14, so we should use app router.

OK, Thanks will update the PR

closed #138


Add missing license information

Issue Number:

Objective of pull request: Add proper license information.
Pull request checklist

Your PR fulfills the following requirements:

[ ] Issue created that explains the change and why it's needed
[ ] Tests are part of the PR (for bug fixes / features)
[ ] Docs reviewed and added / updated if needed (for bug fixes / features)
[ ] PR conforms to Coding Conventions
[ ] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
[ ] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
[ ] Build tests (pytest) passes locally

Pull request type

Please check your PR type:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation changes
[x] Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[x] No

Supplemental information

We should probably have a CI job that scans for license stuff.


Add BlackBlocks GmbH validator

Validator company: BlackBlocks GmbH
Discord: BlackBlocks#2470
Twitter: BlackBlocks_io
E-mail<EMAIL_ADDRESS>

We are a company from Germany specialized in the operation of blockchain block producers and data transmission.
Our company operates many blockchain archive nodes and we also bring our skills to the development and improvement of corresponding software.
We wanted to get into the Namada genesis since the closed quarter testnet 2 and would be happy if it works this time.
https://github.com/anoma/namada-testnets/pull/62
https://github.com/anoma/namada-testnets/pull/81
https://namada.blackblocks.io/


bigO.png: Corrected big O notation image.

Fixes https://github.com/kdn251/interviews/issues/3

Good catch, thank you!


Build.BuildNumber doesn't work for deploying TeamCity builds

If I create a release definition using a TeamCity build as artifact source, and $(Build.BuildNumber) as Release name format, releases are still named using the default naming schema (Release-1, ...)

@pascalberger This issue is fixed in latest vsts release, can you confirm that it is working for you now?

@omeshp We're using TFS on-prem (currently 2018 RTM). If you let me know in which TFS version this is supposed to be included I can test as soon as it is released.

@pascalberger Hi pascal, this fix will get released with TFS 2018 update 2.


bigquery: document new methods

@garrettjonesgoogle Can you teach me to run snippet integration tests? Running mvn verify on the example dir ran no tests.


Some application icons missing in GNOME3 (NixOS 16.09/unstable)

Issue description
When moving a NixOS 16.03 system to 16.09/unstable, some application icons are missing in the GNOME3 UI (dash/dock/activities/overview or what's it called). One particular example is chromium. chromium is in in environment.systemPackages, so it's consistent with the rest of the system. Moving back to 16.03 makes the icons appear again.
Not all icons disappear. For instance, the GNOME "Web" application has working icons also on master.
Steps to reproduce

GNOME3 desktop (haven't tested other DEs)
With chromium installed, see if it has the "chromium" icon in the gnome shell activities view. If broken, the icon is the stock "program" icon (or what's it called), which is used when no icon is available.

Technical details

System: NixOS 16.09/unstable @ 0d5be595a7c707be1cedebf1f14a47cafdf0a3f4 (master as of today, but the issue has been there for weeks)

I'm guessing it has something to do with multiple outputs.

Oh, it looks mostly fixed now (tested at nixpkgs master 6af0f57f91f5b87e10186f7d26a345cab565478c). Yay!
For completeness, I see missing icons for these apps in GNOME Shell overview:

Audacious
Cheese
Firefox
FMIT
Meld
Okular
Pitivi
qScreenshot
Qt Creator

(But I don't know if they were missing before or not.)

Is this fixed? I still have missing icons in GNOME, for instance: Firefox, Evolution, Shotwell. Should I open a new issue, should this be re-opened or is the issue fixed but I'm just doing something wrong. I'm using unstable channel.


cd hooks

Add two hooks, $before-cd and $after-cd, that are triggered before and after changing directory.

Yes please! 👍

FWIW, I can only find one reference to execution hooks in the elves/elvish.io project src/ref/edit.md file. This mechanism definitely needs more documentation. In particular the before-location, after-location, before-history, after-history, before-lastcmd, and after-lastcmd hooks are not documented. Too, the concept of hooks needs to be documented outside of the mention in the edit module.

@xiaq Any documentation on how to use this?
I'm building a close of https://github.com/rupa/z for Elvish (and any other shell) in Rust: https://github.com/dmix/portal and I need a way to detect directory changes with cd.
In ZSH I was able to get it to work with
autoload -U add-zsh-hook
add-zsh-hook -Uz chpwd (){
    portal db track $pwd
}

I tried:
edit:after-cd = [{ echo 'just changed dir' }]

But I got this error:
new variables can only be created in local scope
Am I missing something?

its after-chdir = [[_]{ put 'just changed dir' }]
tracking directory is not a job of editor.

@dmix The before/after-chdir hooks are documented here: https://elv.sh/ref/builtin.html#$after-chdir
The error you got was caused by you trying to create a new variable inside the edit: module (which is not allowed), but additionally your hook function was missing one argument, which is automatically passed as the path of the new directory.

@zzamboni @SolitudeSF thanks guys, I need to relearn Elvish it seems!


Android Device Crashes while calling .tmx file image for game

I am trying to make a game and using .tmx file format. testing on window works fine but testing on android device it crashes and give message "unfortunately, your game has stopped working". How can I solve this problem? Thank you and would like to hear from you as soon as possible.

You'll need to provide a stack trace if we are to determine if there is indeed any problem in libgdx or if the problem is in your code.
Please use the forum or irc to ask questions. We'd like the issue tracker to remain dedicated to actual issues within libgdx.


Bug: Creating a code block after a list, no matter how many blank lines I type, it always show two blank lines.

Hi @xsxsxszs, welcome to Ghost's GitHub.
Your issue doesn't state what you expect the behaviour to be in this case? For future reference we have a bug report template in our contributing guidelines that shows the information that is useful to include when raising a bug.
The behaviour displayed in your screenshot is common to showdown, the original Markdown.pl library, and many others - as shown by Babelmark.
There are various other interpretations by other libraries, but I don't think that this interpretation is necessarily wrong? Going to close this for now as it's not something we control (it's part of showdown), but if someone has information that can show one of the other interpretations as being more correct or more useful, then we can look at revisiting or trying to get it fixed in showdown.