TTL and min. TTL set to 0

The "ttl" and "min_ttl" can not set to 0 because of omitempty option!
Please allow 0 as TTL value, because of https://www.ietf.org/rfc/rfc1035.txt:

TTL          a 32 bit signed integer that specifies the time interval
that the resource record may be cached before the source
of the information should again be consulted.  Zero
values are interpreted to mean that the RR can only be
used for the transaction in progress, and should not be
cached. For example, SOA records are always distributed
with a zero TTL to prohibit caching.  Zero values can
also be used for extremely volatile data.

Use case:
Bind9 (with caching) before SkyDNS, BUT we do not want to cache Service Discovery (SkyDNS) requests even for 1 second!
Reference:
https://github.com/tmaczukin/docker-bind9/tree/master/assets/bind-configuration
And adding cache into the bind options.
Thank you!

[ Quoting<EMAIL_ADDRESS>in "[skynetservices/skydns] TTL and min..." ]

The "ttl" and "min_ttl" can not set to 0 because of omitempty option!
Please allow 0 as TTL value, because of https://www.ietf.org/rfc/rfc1035.txt:

TTL          a 32 bit signed integer that specifies the time interval
that the resource record may be cached before the source
of the information should again be consulted.  Zero
values are interpreted to mean that the RR can only be
used for the transaction in progress, and should not be
cached. For example, SOA records are always distributed
with a zero TTL to prohibit caching.  Zero values can
also be used for extremely volatile data.

Use case:
Bind9 (with caching) before SkyDNS, BUT we do not want to cache Service Discovery (SkyDNS) requests even for 1 second!
Reference:
https://github.com/tmaczukin/docker-bind9/tree/master/assets/bind-configuration
And adding cache into the bind options.
Thank you!

http://www.zytrax.com/books/dns/ch7/hkpng.html#max-cache-ttl

Hi miekg,
I know about this option.
But: "This statement may be used in view or a global options clause."
This work-around is not acceptable in my case, because I want 2 zones:

options {
max-ncache-ttl   5;
max-cache-ttl   15;
max-cache-size 10M;
minimal-responses yes;
recursion yes;
...
};
zone "." in{
type forward;
forward only;
forwarders {
<IP_ADDRESS>;
<IP_ADDRESS>;
};
};
zone "local." in{
type forward;
forward only;
forwarders {
skydns_ip_here;
};
};

One zone for any internet domain and one for Service Discovery (SkyDNS).
Inside zone, you cant change cache.
View is also not an option, because view is based on client IP, not on FQDN. :(

[ Quoting<EMAIL_ADDRESS>in "Re: [skynetservices/skydns] TTL and..." ]

Hi miekg,
I know about this option.
But: "This statement may be used in view or a global options clause."
This work-around is not acceptable in my case, because I want 2 zones:

Damn bind... :(
Wonder if there are side effects in removing the omit-empty for this value.
Also: why are you bothered with the 1 sec TTL? Can't think if any operatial
reasons...? Also in a traffic burst it might well protect etcd.
/Miek
--
Miek Gieben

Actually yes, I also believed in bind :D
There might be side effects :S
I am also aware of it, but I will try.

Also: why are you bothered with the 1 sec TTL?
Well yes, great question. I want real-time service discovery.
Because fail can happen any time: sigsegv, nullptr. exception, connection lost :(

[ Quoting<EMAIL_ADDRESS>in "Re: [skynetservices/skydns] TTL and..." ]

Actually yes, I also believed in bind :D
There might be side effects :S
I am also aware of it, but I will try.

Also: why are you bothered with the 1 sec TTL?
Well yes, great question. I want real-time service discovery.

real-time and DNS don't really go well together.

Because fail can happen any time: sigsegv, nullptr. exception, connection lost :(

Which does not prevent from any client holding on to this IP.
I consider this a micro optimization that is probably not worth the trouble.
/Miek
--
Miek Gieben

I got your point :(
Before bind, my applications did not used DNS cache.
getpeername() always did the resolving, regardless of TTL value (default 3600 :).
Anyway, SkyDNS should obey RFC :)
Feel free to discard my issue.
I will find the way to make it work...
Thanks!


Current activities do not load when deployed to Github

We receive an Uncaught ReferenceError in Client.js. It appears that the deployed version on Github is sending server.js instead of client.js.

Closing ticket due to core platform issues. Github cannot support Node.js.


Cannot build the demo for vcl-button

Error: Cannot find module './node_modules/font-awesome/css/font-awesome.css' from '/tmp/button/node_modules/vcl-font-awesome'

Probably related to https://github.com/FortAwesome/Font-Awesome/pull/6046 .
As I expect them not to accept the PR, there will be a workaround in the preprocessor.
It will still not be ideal, and we will probably run into issues in the future, but this should fix the demo for now.

quick fix: https://github.com/vcl/button/commit/e26a89704ea2b864e8094af2dfec70f25699616a
Delete your node_modules after pulling.


Shai: Return parsing pass error data in RPCs

Closes #2199
(See #2234 for additional notes on context and the motivation for this approach).

Catches SanyExceptions from the highest level of the SANY parser
pass and makes these available in the PassResult.
Promotes the general RPC error data into protbuf specs, allowing more
consistentcy and reducing the amount of dynamic JSON.
Includes some light refactoring as incidental cleanup.
Updates tests.

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)

Very good question about the relation to the exception adapters. I'll need to do a grep of the codebase to ensure that:

All places where SanyException are raised are now caught by this Either
That there are not additional exceptions we use to signal parse errors, which should also be caught.

Once those are addressed, I should remove those cases from the exception adapters.


Framework.apk?

Hi everyone,
I finally managed to get the Framework to build successfully but now Eclipse is showing me a weird error message when I try to run one of the samples. Here's the console log:
[2016-04-13 17:18:26 - Minimal360PhotoActivity] ------------------------------
[2016-04-13 17:18:26 - Minimal360PhotoActivity] Android Launch!
[2016-04-13 17:18:26 - Minimal360PhotoActivity] adb is running normally.
[2016-04-13 17:18:26 - Minimal360PhotoActivity] Performing org.gearvrf.samples.Minimal360Photo.Minimal360PhotoActivity activity launch
[2016-04-13 17:18:26 - Minimal360PhotoActivity] Automatic Target Mode: using device 'xxxxx'
[2016-04-13 17:18:26 - Minimal360PhotoActivity] Uploading Minimal360PhotoActivity.apk onto device xxxxx
[2016-04-13 17:18:27 - Minimal360PhotoActivity] Installing Minimal360PhotoActivity.apk...
[2016-04-13 17:18:29 - Minimal360PhotoActivity] Success!
[2016-04-13 17:18:29 - Framework] Could not find Framework.apk!
[2016-04-13 17:18:29 - Minimal360PhotoActivity] Starting activity org.gearvrf.samples.Minimal360Photo.Minimal360PhotoActivity on device xxxxx
[2016-04-13 17:18:29 - Minimal360PhotoActivity] ActivityManager: Starting: Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] cmp=org.gearvrf.samples.Minimal360Photo/.Minimal360PhotoActivity VirtualScreenParam=Params{mDisplayId=-1, null, mFlags=0x00000000)} }

(I edited the device ID to "xxxxx", it actually shows the right one in the console.)
The same thing happens with the "gamepad" sample.
I already tried to export the Framework as apk but Eclipse didn't let me.
When I open one of the already installed samples on my S7, it only shows a black screen with a white "x" in one of the corners, then the app crashes. Yes, I added the Oculus signature file to the "assets" folder, so at least that shouldn't be the cause.
Does anyone know what's up with this Framework.apk and where I can get it/how I can get the samples to run?

Hi,
The "Could not find Framework.apk" is a benign message. It is an artifact of the Framework being a library project and what it seems a bug in the Android plugin for Eclipse. See http://stackoverflow.com/questions/5580575/could-not-find-the-xxx-apk-message-in-console-while-starting-application-with - it may help you.
For the crash we will need logcat output - would you mind attaching it here? There might be something missing from the apk you are building - did you copy all the Oculus libraries GVRF depends on to the libs folder?

do you just need to enable Oculus developer mode?  Settings->Application Manager->All->GearVR Service->Manage Storage  tap on the version number seven or eight times, then toggle the switch for developer mode.  I have no idea what it is that convoluted.

@liaxim
Thanks, I'll look into it and post the log tomorrow.
If we're talking about the "libs" folder in "GVRf\Framework", then yes. I also copied the extra files from the libs-gvrf archiv into it.
@thomasflynn
That's the problem, there's no "Manage Storage" button there for me. I did see it in the youtube video by gamefromscratch and in this guide but the whole settings menu looks different on my phone.
What's even weirder is: The guide says that there has to be at least one app installed that has my device signature in it. The console in Eclipse said that both the "gamepad" and the "Minimal360PhotoActivity" app were installed successfully (they simply crashed 5-10 seconds after starting them), so I don't know, why it still won't show that button. Maybe it's different if you're using Marshmallow (6.0.1) instead of Lollipop?
The only thing that it would let me do was enabling the normal Android developer mode but that one apparently doesn't help with VR apps.

ok, yeah, the menu is different on Marshmallow.  After I click on 'Gear VR Service', you need to click on 'Storage', then 'Manage Storage'.  Once there, you can start tapping on VR Service Version (7 or 8 times).  You do need to have an apk with your device signature installed.  If you don't, then when it searches your phone for apks, it'll give a toast that says, "you are not a developer".  If you do, then you'll get the developer mode switch.

@thomasflynn
Okay, I got it and it worked. Thanks! Sorry, I think it's worth a facepalm. It always starts scrolled down and since there are two different entries with the same name (the phone isn't set to English), I didn't recognize the first one to be what I was looking for.

Glad you're up and running.  Close this issue?

@liaxim
Thanks, that solved one problem, it's not showing that error message anymore.
Afterwards I got the same error like in this post but I fixed it by only having "Android x.x.x" (x.x.x = version number), "gamepad/src" and "gamepad/gen" in "Project Properties/Java Build Path/Order and Export" ticked (the last two have that full square "check mark"). Is that the right one or should I better use "Android Private Libraries" or "Android Dependencies"?
No matter what I use, the app still crashes on startup, though (at least the developer mode is working now, yay). :/
Here's the crashlog from the LogCat tab in Eclipse:
04-15 16:31:25.239: W/ResourcesManager(11715): getTopLevelResources: /data/app/org.gearvrf.gamepad-1/base.apk / 1.0 running in org.gearvrf.gamepad rsrc of package org.gearvrf.gamepad
04-15 16:31:25.239: I/InjectionManager(11715): Inside getClassLibPath + mLibMap{0=, 1=}
04-15 16:31:25.249: D/ResourcesManager(11715): For user 0 new overlays fetched Null
04-15 16:31:25.249: I/InjectionManager(11715): Inside getClassLibPath caller
04-15 16:31:25.259: D/InjectionManager(11715): InjectionManager
04-15 16:31:25.259: D/InjectionManager(11715): fillFeatureStoreMap org.gearvrf.gamepad
04-15 16:31:25.259: I/InjectionManager(11715): Constructor org.gearvrf.gamepad, Feature store :{}
04-15 16:31:25.259: I/InjectionManager(11715): featureStore :{}
04-15 16:31:25.259: W/ResourcesManager(11715): getTopLevelResources: /data/app/org.gearvrf.gamepad-1/base.apk / 1.0 running in org.gearvrf.gamepad rsrc of package org.gearvrf.gamepad
04-15 16:31:25.259: D/ContextRelationManager(11715): ContextRelationManager() : FEATURE_ENABLED=true
04-15 16:31:25.259: D/RelationGraph(11715): garbageCollect()
04-15 16:31:25.269: W/ResourcesManager(11715): getTopLevelResources: /data/app/org.gearvrf.gamepad-1/base.apk / 1.0 running in org.gearvrf.gamepad rsrc of package org.gearvrf.gamepad
04-15 16:31:25.269: I/GVRActivity(11715): onCreate 4c1b180
04-15 16:31:25.289: E/JniUtils(11715): FindClass( com/oculus/vrapi/loader/AppLoader ) failed
04-15 16:31:25.289: A/libc(11715): Fatal signal 6 (SIGABRT), code -6 in tid 11715 (gearvrf.gamepad)

Another weird thing I've noticed - and maybe that's how it's supposed to be - is that I get an error message when I start Eclipse:
[2016-04-15 15:49:59 - Unable to launch cygpath. Is Cygwin on the path?] java.io.IOException: Cannot run program "cygpath": CreateProcess error=2, Das System kann die angegebene Datei nicht finden
After loading the Android SDKs, everything's fine again and the red "x" on top of the "Framework" project icon vanishes.

Hi,
In my projects I have "Android Private Libraries" and "Android Dependencies" checked in the Order and Export section and have no complaints.
Looks like you are missing the Oculus libraries GVRF depends on. You need to copy few files from the Oculus Mobile SDK (<IP_ADDRESS> and <IP_ADDRESS> both work) to your libs folder. VrApi.jar and SystemUtils.jar should go to ./libs/ and libvrapi.so to ./libs/armeabi-v7a/.
And about the "Cannot run program "cygpath"" - maybe you can try what http://stackoverflow.com/questions/15459934/unable-to-launch-cygpath-in-android proposes and/or different ndk versions as I have seen reports that may matter. But if you build works otherwise you may just ignore the message.

I had both checked before too but that gave me the "Unable to execute dex..." error.
I already copied the 3 files into the libs folder (for me it's: G:\Dev\GearVR\GVRf\Framework\libs), so SystemUtils.jar, VrApi.jar and VrAppFramework.jar. It didn't say anything about "libvrapi.so" in the instructions but a file with that exact name is already in the "armeabi-v7a" folder.
I had a different NDK version (r11c, now I'm using r10e) installed before but that gave me a bunch of other errors and it didn't even build the Framework properly. I did set the NDK_HOME environment variable for Windows and just now added the "NDKROOT" variable for the project in eclipse (G:\Dev\AndroidNDK\ndk-build.cmd NDK_DEBUG=1) but it still gives me the same message. I thought you don't need Cygwin for newer versions?

Based on this error:
04-15 16:31:25.289: E/JniUtils(11715): FindClass( com/oculus/vrapi/loader/AppLoader ) failed

I am pretty sure VrApi.jar is not found at runtime.
Regarding the NDK: yes, I am seeing references that Cygwin is not needed anymore. I am using Linux so I don't have first-hand experience building on Windows though.

Damn, the "Order and Export" settings reset itself after restarting Eclipse. Seriously?!
I can assure you, the file is in there:
click
Hm, okay, I guess I'll just ignore it then.

You can enable verbose build logging (Windows->Preferences->Android->Build->Build output) and examine the console output. Do you see anything like the following?
[2016-04-15 09:04:09 - gvrsample] Dx processing com/oculus/...
[2016-04-15 09:04:09 - gvrsample] Dx processing com/oculus/vrapi/...
[2016-04-15 09:04:09 - gvrsample] Dx processing com/oculus/vrapi/loader/...
[2016-04-15 09:04:09 - gvrsample] Dx processing com/oculus/vrapi/loader/AppLoader.class...
[2016-04-15 09:04:09 - gvrsample] Dx processing com/oculus/vrapi/loader/BuildConfig.class...

You shouldn't have to mess with the Order and Export settings really. Dropping the dependencies under libs is enough. The Android plugin for Eclipse takes care of the rest. If you explicitly modify your Java Build Path and/or Order and Export settings, it is almost certain you'll get in trouble.

I just deleted the samples and the framework, downloaded the latest version (from 42 minutes ago) and did the following:

Import the framework in Eclipse and build it
Copy the 3 files, plus the "armeabi-v7a" folder with the extra file from the Oculus SDK into the framework's "libs" folder
Clean and build it
Import the "gvr-cubemap" sample
Copy my Oculus key into the sample's "asset" folder
Clean and built it --> error because it's not linked to the framework
Add the framework (Properties - Android - Library) & apply
Clean and build again
Enable Developer Mode (both Gear VR and general Android) on my phone and plug it in
Run the "gvr-cubemap" sample as an Android Application
Tada, the app is running! So do "gamepad" and "gvrf_minimal360photo".
I didn't change anything exept get the new Framework (didn't even restart my PC inbetween), maybe there was a bug in the old one but I have absolutely no idea what actually changed and I did pretty much the same things when I set everything up the first time..

Thank you very much for your help! I'm just glad that it's working now, even though I have no idea why.
Btw, my Oculus Mobile SDK is version <IP_ADDRESS>.

Glad to hear that things are working. Can we close the issue now?

Yes, thanks.


Use a simpler clearfix

You could simplify the clearfix code with the code below, works in all modern browsers.
.clearfix {
    *zoom: 1;
}

.clearfix:after {
    clear: both;
    content: "";
    display: table;
}

Source: http://nicolasgallagher.com/micro-clearfix-hack/

lol this is the first issue


Feature request: libsqlite-sys built-in sqlite math functions

The latest versions of SQLite come with basic math functions included by default. For instance, if you compile a sqlite3 binary manually, on Linux you have access to functions like exp and ln, which provide the only built-in mechanism for calculating a cumulative product.
Here are steps for how to currently include math functions when building a rusqlite project:
wget https://www.sqlite.org/2022/sqlite-autoconf-3390200.tar.gz
tar -xvf sqlite-autoconf-3390200.tar.gz
cd sqlite-autoconf-3390200
mkdir build && cd build
../configure # If you want static SQLite only, add --enable-shared=no
make -j6 && su -c "make install"

# necessary for rusqlite to detect your compiled libraries
export LD_LIBRARY_PATH="/path/to/sqlite/shared/libs:$LD_LIBRARY_PATH"

Then set the documented env var in cargo.toml:

[env]
SQLITE3_LIB_DIR = "/path/to/sqlite/shared/libs"

It would be great if the above steps were automatically performed with a bundled build of rusqlite, since by default these math functions should be included in 3.39.2 version of SQLite. Unless they are intentionally removed (for smaller disk footprint?)?
Thanks for considering this enhancement!

https://sqlite.org/lang_mathfunc.html

The math functions shown below are part of the SQLite amalgamation source file but are only active if the amalgamation is compiled using the -DSQLITE_ENABLE_MATH_FUNCTIONS compile-time option.

So you should try [LIBSQLITE3_FLAGS]https://github.com/rusqlite/rusqlite/blob/d6780ece27fdd127394aaff17743054984f731ad/libsqlite3-sys/build.rs#L273).
Something like
LIBSQLITE3_FLAGS="-DSQLITE_ENABLE_MATH_FUNCTIONS" cargo build --feature bundled

@gwenn I exported that env var and it worked. I tried adding that env var to my cargo.toml and this didn't work (would be great to codify that env var somehow - any ideas?)
[env]
LIBSQLITE3_FLAGS = "-DSQLITE_ENABLE_MATH_FUNCTIONS"

But notice above when I compile myself ln/exp are included by default. So why isn't libsqlite-sys including them by default? Do you guys prefer math functions are intentionally excluded?
Thanks for the quick help!

I think it would be reasonable to include these. It seems unlikely that it contributes much to binary size at all.

Currently, we don't include them because SQLite doesn't include them by default.
I mean the SQLite3 library, not the SQLite3 CLI.
https://sqlite.org/lang_mathfunc.html

are only active if the amalgamation is compiled using the -DSQLITE_ENABLE_MATH_FUNCTIONS compile-time option.

@thomcc that would be awesome - especially since [env] config in my cargo.toml doesn't seem to trigger them being included.
@gwenn that's odd, because the library (*.so) that I compile does include them by default. Or am I referring to a different library than you are referring to? I am compiling autoconf and not amalgamation. Maybe that's the difference? I'm not sure why they are named that way! :)

I tried adding that env var to my cargo.toml

It should be in .cargo/config
$ cat .cargo/config

[env]
XYZ = { value = "value" }

Currently, we don't include them because SQLite doesn't include them by default.

Could this flag be included by default, as mentioned earlier in this issue? I feel this is a stumbling block -- it was for me! I did not realize my database client I was testing with was compiled with this feature, so when I copied the query over to my program and it did not work I was stumped.

Could we please get a resolution on this suggestion? It would be a nice quality of life improvement and I'd love to see it implemented. If defaults are a concern, then perhaps it could be put behind a feature flag?

Something like:
https://github.com/StractOrg/stract/blob/0d51eff321e4025716780f61e8a1a71073c79c80/.cargo/config.toml#L8
Or:
https://github.com/kellpossible/avalanche-report/blob/28d6b0033e3652c8f7bf28c3f394cd8e2ed1e1fd/.cargo/config.toml#L3
doesn't work ?
Because there are many SQLite options: https://sqlite.org/compile.html
I am afraid if we need to support all of them behind feature flags...

Sure, but having math functions seems like a fairly common thing to want, and when they don't work there's no clear documentation on how to enable them outside of this very issue. At the very least I think this method of configuration should be mentioned in the docs.
Are there any practical considerations for not including them by default, outside of following upstream? If it's only a concern for libsqlite3-sys, could only rusqlite be built with that flag enabled by default?
If not, I can sympathize with wanting to keep flag proliferation in check, but there are already many feature flags for much more specialized features, so I don't think adding a flag for widely used math functions would significantly affect the scope.

but there are already many feature flags for much more specialized features, so I don't think adding a flag for widely used math functions would significantly affect the scope.

Please find me a single feature flag that don't change SQLite3 API (SQLITE_ENABLE_MATH_FUNCTIONS don't).

Sorry, I don't think I understand. Is there some criteria for what can and can't become a feature flag that I'm not aware of?
In any case, I only suggested it as one option for improving the developer experience here. I would appreciate if you considered the rest of what I wrote, too. :)

I am biased but...
If I considered all the points, I deduce that you will document how users can build rusqlite / libsqilte3-sys with any specific SQLite3 options without having to introduce another feature flag to avoid their proliferation.


Segmentation fault and "*** stack smashing detected ***" for very long lines

Run the following command in the shell:
seq -s ' ' 300 | fzy

and type any number.
Result:
> 1*** stack smashing detected ***: terminated
Aborted

For even longer input text fzy terminates with a segmentation fault:
seq -s ' ' 3000 | fzy

Type any number. Result: Segmentation fault.

It seems like this was fixed in a recent commit. Sadly the version number is always the same. So I don't know which one is installed on my system. Anyway closing.


New feature and two bug fixes

This PR fixes two bugs and adds one feature:

fixed issue where caller could call register_parent_prefork() without an array but the code relies on it being an array
add ability for child to send a message to the parent via child_send_result_to_parent
fixed an issue where a signal interrupting socket_receive or socket_send would cause the protocol to get out of sync.  without the signal block, sometimes the payload header was being partially consumed resulting in a mixup of the payload header and payload
small documentation cleanup

Tried to fix some codeclimate issues and made it angrier.  I'll leave this in the capable hands of @ablyler :)


Updated file to work.

There were 2 errant spaces in the YAML file causing this to fail if you just copy/paste.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?

Hi @themsquared,
Thanks for fixing the typo. I will merge you PR for the 5.14 milestone.


finding Z accuracy and plane fit RMS error python

How can i find plane fit RMS error and Z accuracy using pyrealsense2 library in python. I have see the python wrappers but i need a help.

@scizors , Plane fit RMS and Z accuracy are core elements of the Depth-Quality tool provided with the SDK. link
The algorithmic part is embedded into the tool and not in the SDK (i.e. not included pyrealsense2).
The theoretic basis for that tool is established in the relevant white paper
In order to get that functionality in python you can reuse the core functionality from C++ by wrapping with python. You can also port and rewrite the algorithms into python.

Thanks for the reply how about in C++ and please mention any other programming language to test the camera and its efficiency with respect to errors and various lighning condition I need to check it.

You can use rs-depth-quality tool in a stand-alone manner in different environments (inside and outside) as long as the minimal requirements are met :

A flat non-reflective surface is set in front of the camera
You can hold camera stable enough to achieve the required perpendicularity threshold

Just to reiterate  - the methodology for testing the actual image quality is elaborated in the white paper link above. And you can follow that document (and/or actual C++ implementation) to introduce a similar functionality in python.
One thing to mention though  - using the rs-depth-quality  has the advantage that the tool has been internally validated, so you can use its results and generated reports to be acknowledged by the Realsense team.

thanks for the reply


Project maintenance request

Can I maintain this project?
I already have a few patches:
https://github.com/tim241/omnisharp-sublime/tree/tim241/submodule-patch
https://github.com/tim241/omnisharp-sublime/tree/tim241/python-fix
https://github.com/tim241/omnisharp-sublime/tree/tim241/md-patch
branch with all patches applied:
https://github.com/tim241/omnisharp-sublime/tree/tim241/patched
I'm currently waiting for a fix from GitVersion (then I can compile the newest omnisharp-roslyn and fix stuff if it doesnt work)

Hello @tim241,
Is there any news about your ask (private message or anything like that)?

@theredfish no, nothing sadly.

Maybe @jchannon can help or contact someone? :)

Bat signal has been put out. Hold tight

@tim241 I added you as admin to this repo - welcome! 🚀🎉 thanks @jchannon

thank you @filipw  @jchannon and @theredfish !


Switch type support

Change log

add switch type supported.
add a requierment that: in graph yaml, user must name the first node with root.
add a validation to check the root node.
add README.md file.

/assign @yuzisun


Imputation: meta issue

The goal is to roughly reproduce the imputation schemes described in the PeMS User Guide. The regression-based scheme is described in more detail in this research paper.

[ ] #169
[ ] #170
[ ] #171
[ ] #172

Yes, agree 100% that we should limit regressions to detectors of the same type so that we don't look for correlations between e.g. ramps and mainline.

Just to clarify I think the additional parameters would only be needed if detector data in close proximity is not available. The additional parameters would only be needed if there is no nearby data to correlate with 😊

Agreed!

@ian-r-rose FYI list of station types in PeMS:
CD	Coll/Dist
FF	Fwy-Fwy
HV	HOV
FR	Off Ramp
OR	On Ramp
ML	Mainline
CH	Conventional Highway

I've had a chance to review the imputation paper and associated imputation tables in the PeMS data warehouse. I would like to have a meeting with the group to go over the assumptions in the paper and review the imputation tables in PeMS. Based on the paper and data tables we should be creating a model that stores flow, occupancy and speed coefficients associated with a station and it's neighbor independent of time, see screenshot below:

I believe these coefficients are applied to a formula that incorporates actual values reported by neighbors for a five-minute period which allows for the exclusion of time for the coefficients. When reviewing the paper, the version I have is missing many of the symbols so hopefully there is a cleaner copy out there we can use. I believe the imputation coefficients were updated on a yearly basis from 2012-2017 but has not been updated since. I will follow this up with an email but wanted to document it here future reference.


Fix .cargo/config for missing targets

Hello,
I can't seem to build with Xargo by following the instruction because the .cargo/config was missing instructions for my board.
Here is the fixed .cargo/config that should work for all boards :
[target.thumbv7em-none-eabihf]
rustflags = [
  "-C",
  "link-arg=-Tstm32f3discovery.ld",
  "-C",
  "link-arg=-nostartfiles",
]

[target.thumbv7em-none-eabi]
rustflags = [
  "-C",
  "link-arg=-Tstm32f3discovery.ld",
  "-C",
  "link-arg=-nostartfiles",
]

[target.thumbv7m-none-eabi]
rustflags = [
  "-C",
  "link-arg=-Tstm32f3discovery.ld",
  "-C",
  "link-arg=-nostartfiles",
]

[target.thumbv6m-none-eabi]
rustflags = [
  "-C",
  "link-arg=-Tstm32f3discovery.ld",
  "-C",
  "link-arg=-nostartfiles",
]

If I have the time, I will make a pull request.

My bad I read all the introduction stuff and thought, let's try with an other board (not even a DISCOVERY board). Modifying .cargo/config fixed the linking issue, but even with a simple program the tutorial does not work very well with an other board.
Anyway, that was worth trying at least.


Consider adopting AsyncAPI spec

AsyncAPI spec is an specification used to describe your asynchronous APIs. You can then generate documentation, code, and validate your message payloads among other things.
I suggest this project to have its own asyncapi.yaml file and, additionally, to analyze how AsyncAPI tools ecosystem can help.
Feel free to reach me. Happy to help on this task!

Planned.


[Feature]: Support moz-extension pages

Feature description
With help of web-ext it is relatively simple to load a webextension into browser controller by Puppeteer. Sadly, Puppeteer is unable to perform any operations on extension pages, methods like page.goto, page.click timeout.
Here is a minimal repo to reproduce the problem: https://github.com/chrmod/puppeteer-webextension-test

This issue is a duplicate of https://github.com/puppeteer/puppeteer/issues/6616 but example runs with latest puppeteer and web-ext.

Is it Firefox specific?

cc @whimboo do you have CDP support for extension targets?

No we don't and most likely won't have. I think it's something that we might have to focus on for BiDi at some point. But we don't have time to get it implemented for CDP, sorry.

I will keep the feature request open then to see how many users are interested.

Closing issue given that it's not something that we will have for CDP but is on the roadmap for WebDriver BiDi.


[Feature, Request], table selection and expand can't set render-header

Existing Component
是
Component Name
table
Description
when to use table component and set the table-column type as 'selection' or 'expand', the render-header event will non't be execute.
sometime i wan't to change the selection header, such as "all select" other than the select box.

Using render-header means you'll have to take care of all the interactions yourself.


Add inital content access identityX route, components & submission handler

LoggedIn/NonAuthIdentified User:
initial visit:

On submit it will generate a website.ContentAccessSubmission doc containing
{
    "_id" : ObjectId("65b3e6a21c7736001b111fc7"),
    "payload" : {
        "fields" : {
            "givenName" : {
                "label" : "First Name",
                "value" : "Brian"
            },
            "familyName" : {
                "label" : "Last Name",
                "value" : "Miller"
            },
            ...more
        },
        "selects" : {},
        "booleans" : {}
    },
    "created" : ISODate("2024-01-26T17:06:42.191Z"),
    "contentId" : 22288700,
    "ipAddress" : "<IP_ADDRESS>"
}

A page reloads occures and the page renders without the gate... Update for discussion is how to handle additional page visits???
Error/success timeout message:

engagement report pr: https://github.com/parameter1/engagement-report/pull/17

 Gated article access & reporting


[modify] add fragile option in mobile_size_check spec

Coverage increased (+0.03%) to 84.776% when pulling 3d2d7e21b0b78594d5989928c45f65506de0655c on itowtips:spec into db49a1ccefdca2a658d2481c65bca5a6f4cd5554 on shirasagi:master.


Support a grid layout for editors

VSCode Version: Windows 10
OS Version: 1.7.0 - insider

-- Sorry for the English, I used Google Translator --
Leave even better drag and drop, detecting where we point out the window.(#224, #1749).
How does the Atom. I think it's more intuitive.

@Tekbr what is wrong with our approach?

@bpasero I think it was not very clear. I'll try to explain better. Sorry for English
I enjoyed new in version 1.7, but it would be interesting to allow vertical and horizontal split at the same time.
As shown in the gif, three tabs. A vertical split, horizontal split and another at the same time.
Clicking a button (or use the shortcut) to change the orientation, it becomes a little boring.
Just as we drag the tab to the side it adjusts the window, dragging down, near the lower edge of this window to adjust, without the need to use "Toggle Editor Group Layout".

I used the 👍  but wanted to provide verbal support for this usecase as well. I have a rather large monitor on which I use Sublime in a 2x3 grid which currently is not possible in VS Code as you have to choose between horizontal vs vertical.

After finally implementing #1749, this is another needed step towards making the workbench as flexible as in other editors (Sublime Text, Atom, vim, Emacs, full Visual Studio - they all support grid layouts). Especially on larger screens, it is very useful to use 2×2 or 1+2 grid layouts. Some people with very large screens tend to use even more crazy layouts, which can be useful when working on projects that have multiple related files (e.g. header files in C++).

Would be very lovely to have something like this in VS Code!

I like to be able to split both vertically and horizontally and this is really missing here :(
Hopefully it will be implemented. This is the only major problem I have with vscode right now.

For me, Atom has it perfectly ... split horizontally ... split vertically ... and you can end up with 4 quadrants, or 2 on the left and 1 on the right, or 1 on the left and 2 on the right ... each with its own set of tabs. A newly opened file goes into the section with focus at the time of opening. I currently use all three cases on my 4K monitor.

I wonder why it was not implement yet, or maybe VS team has some justifications against horizontal split?

@whitecolor VSCode has horizontal split. You can enable it by pressing 'alt+shift+1'.
However, I would definitely agree that a grid layout allowing a mismash of horizontal and vertical windows is needed in VSCode. In my office, I'm the only person consistently using VSCode and one of the outstanding reasons is the lack of grid layout capability.

Right you can switch vertical horizontal, but can't use both, it is kind of strange.

Is this going to be considered or should we just forget about it?
To be honest it is the only real bad thing I see about vscode right now, but I want to use it everyday and it's quite painful not to be able to.
I understand that time is not infinite, but I don't see much happening here so excuse me if I'm being annoying by upping this but I'd like this discussion to continue further :)

Please see discussion in #9443.

@kieferrm You closed issue #9443 referring people to here. So ca we assume this issue is the one that will track the grid layout feature>

@andradei yes.

Also would love this. Arbitrary grid splitting is pretty central to my workflow. I'd love to switch to Code as it's amazing in other places but, this keeps holding me back. 😄

This is the number one reason some of my colleagues aren't on the vscode train

Definitely. It's an integral part of most emacs' users workflow to continuously redefine the buffer grid, using the C-x-<n> key combinations. I would say the number one use is to split once to obtain two views of the same buffer and quickly navigate to a different part for reference  – and then often unsplit shortly after.

I'm just trying to switch from Emacs, and not having that makes migration painful

Wow.  Any time you start some new software, play around a little and find something annoying, you go to open an issue – but it was either just resolved to be released in the next version, or discussion have been just finished that it needs to be done.
Anyways. Playing with React-Native, after Android Studio I really miss this splitting of screens

Agreed that we need to be able to split both Horizonally AND Vertically. Choosing 1 format over the other just isn't usable.
Might want to take a page from:
https://github.com/SublimeText/Origami

This is one of the only features that I would miss if I left Sublime or Atom and is keeping me from using VSCode
For serious Coders or Authors who multi-task this is a required feature which should at least be supported in a plugin.

I've always felt that 3 windows is far too skinny/short to see anything clearly, and grid layouts are a great way to mitigate the problem. When I need two reference files open it's a pain to get it usable in vscode right now :(

Hopefully this will be on the roadmap for the future!

I need this so badly that I'd do it myself if I had time. Without this, VSCode is unusable for many developers. If this isn't available soon I'm going to have to move on because it's a basic feature developers have come to expect from every text editor.

👍

I was just starting to like VSCode when I settled in for a session with my new 4K monitors and I learned that I can't split down/up like I could using Atom at the same time as having columns!
April update was bug squashes - fine; but if MS wants to continue adopting resistors they need to have comparable "standard" features to the main stream editors that have dominated web development the past 5-years: sublime and atom

Coming from old-school VIM back in the 90s and early 00s, and VS since 00s for 14 years, Sublime and Atom w/VIM plugins for years...  Trying to switch to VSCode and just ran into this limitation.
Flabbergasted, I couldn't believe the justification MS mentioned in #1749 as the reason why (the layout and grouping, and key bindings).
It's a serious limitation to not be able to:
:vs
:vs
:split

Translation to non-VIM gurus: it's an echo to the rants in this thread and in #1749 about not being able to split Vertically AND Horizontally - to form a grid-like editor.
Enough with the "design reviews" - just enable the features that all other editors have, and be done with it.  If you have to change the infrastructure and groupings of tabs or whatever, make it a major version bump and tell everyone why.  Done.
It's so frustrating that I tend to just use VS code for lighting editing, and drop to a terminal for hardcore grid editing.
On my 4k 30", or on my Macbook Pro 15" Retina - I use the grid layout exclusively.
Undocking windows would be a big plus too.  But right now, I still have to use [n]vim - so I have console open with tmux across my 3 three monitors for now and maybe a single VScode session for some prettiness on a single monitor - since VSCode doesn't support the 'grid layout' of horizontal and vertical splits at the same time.

I sort of agree with the above comment. Though I wouldnt just go in with a hammer and do it. If keybindings are the worry, fine. Have the features "available" with no bindings to start. Work that in later once you find a compromise and are able to rework the keymap. it doesnt matter to me anyways as I have a largely custom keymap as I do for most of my editors so they are all consistent with each other (to a point).
But if the feature were just working and available, and documented, I think people would still love that forward momentum. Make a separate PR to find out how to integrate that into existing workflows and keymaps.

Is there any update on whether this will be implemented in the near future?

I'd also like to echo the earlier recommendation to check out (read: steal ideas from) Origami for sublime. It's super powerful and has well-designed/intuitive key bindings (after you learn the basic "chord" structure), which include shortcuts for arbitrarily splitting window horizontally/vertically, moving files between panes, moving focus between panes, resizing panes, quickly expanding one pane to some percentage of of editor size.
It was by far the most valuable ST plugin for me, and the one thing i still miss on a daily basis in vscode

The lack of grid-layout support is main thing preventing me from giving VSCode a serious try.

Waiting for updates regarding this feature. Switching from Atom to VS Code is painful without this.

I need this feature.

Any update on this at all? happy to look at putting in a PR if its not something that's being actively worked on??

This is such an important feature, and its absence is pretty much the only thing keeping me on the fence about switching.

VS code needs this!

While we're on this topic, I'd like to request an API to programmatically control the splits. It'd be kinda lame if everytime we wanted to resize panels we had to use our mouse.
In addition, I think it'd allow for some pretty cool plugins.

Definitely need this feature!!

@atmd83  Unless there's something being worked on behind the scenes, this doesn't appear to be something that anyone is actively developing. I have yet to see any pull requests related to this issue, and it hasn't been added to any upcoming milestones. If you still wanted to put in a PR, I don't think it would be a waste, and it's probably our best shot at seeing this any time soon.

@atmd83 based on the comments and reactions in this thread it's safe to say that you'll be hailed as a hero by thousands of developers if you implement this feature

@pelotom @atmd83 @JeremyKruman I'd be wary of trying to work on this. This is something that impacts a lot of wide ranging things, and it'd be unlikely that your PR will get merged.
If you do want to contribute, I'd suggest talking to one of the VSCode core team along the way.

@Chillee you might be right. I'm honestly not familiar enough with how everything works behind the scenes to make that call. Until we get an update on this, I've found an extension here that allows for custom CSS and JS to be inserted into VSCode, which could maybe offer a temporary workaround for people who are particularly desperate for this feature. I haven't had too much time to play with it yet, but I plan to spend some time this evening trying to get one vertical editor on the left side of the screen, and two horizontal ones on the right. As others have suggested, it might be much more easier said than done, but I wanted to bring this potential option to people's attention in case anyone else would like to investigate 😃

For those that want to use VSCode. I do have a small work around, nothing special though.
Open two separate VSCode windows. In one of the windows open the main folder of the project you are working on. In the other window, open a subfolder of the main project folder, i.e /src. You can then place those two windows side by side and then set the layout of each of them independently.  Small cost to using such a great IDE. Hopefully proper grid splitting features will be added in the future.
Hopes this helps some!
Cheers,
Greg

If anyone is interested, you can find my custom CSS that achieves a layout similar to Greg's in this gist. It's a little finnicky (missing scrollbars, etc.), but it gets the job done for the time being.

@JeremyKruman Can you at least scroll using the mouse wheel?

Yes, scrolling works via the mouse and keyboard, the scrollbars are just not visible. They're somewhere, they just need to be styled properly to get them into the right place, which I have yet to get around to.

Any updates whether this features will be implemented or not?

This is still on our backlog.

I was thinking of making an extension which when works with an angular-cli project. When you open a *.component.ts file it automatically detects the template and the css file associated with the component and puts them up in a horizontally split screen.
It's annoying to be moving around files and in an angular-cli project we tend to do that a lot from component to template and vice versa.
Unfortunately horizontal splitting isn't supported and doing too many vertical splits is just not usable.
------------------------------
TEMPLATE     | COMPONENT.TS
             |
-------------
STYLES       |
             |
------------------------------

FYI @praveenpuglia in the Ember-CLI world there exists an extension to quickly switch between related component files via a shortcut which is pretty much essential for sanity in that space. Could be an alternative solution to the one you've posted, and might already exist, if you are looking for some sanity before this feature lands in vscode

When grid layout comes I switch from sublime. I couldnt believe my eyes.... otherwise very good!

@peabnuts123 thats a great idea. I'll try to find something and follow this thread too.

@praveenpuglia Find Related will support the shortcut key support. It won't work out of the box (as I don't have any built-in rulesets for Angular (but I would love to add them). If you need help setting up the rulesets -- let me know.

Open multiple editor ?

Yep, that's an option, @bonarja, and although I understand why you think that might be a helpful solution, I'm afraid it misses the mark.  The reason people are requesting this feature isn't that they don't realize they can open up multiple instances; it's that by using multiple instances, you can't use editor features that are shared among multiple buffers (e.g. named clipboards) or allow you to move between buffers that you in your screenshot have displayed in separate editors (e.g. using vim-mode split commands).

On top of what @coddingtonbear said, vscode does not support opening the same folder in multiple instances. So for me, your suggestion is not a realistic solution

@bonarja @coddingtonbear @alexriedl This won't really work for me either, cause I tend to split, switch, close buffers and change their placement all the time as I'm working. And using multiple windows would just be way too slow and cumbersome for fast and continuous switching.

Another person who need grid view in VSCode 😭

here is also another person who need grid view in VSCode... :)

I need grid layout in VSCode too.

...and I also really want this

+1

People in this thread +1ing and "I want this too"-ing, please make sure you 👍  the original post so that this Issue gets visibility (issues can be sorted by number of 👍 s).

This feature is the only thing holding me back from fully switching away from Atom. I love VSCode, it's fast and I can write plugins using Typescript. Amazing. But this feature is sorely missed. I am amazed that macOS Touch Bar support made it in before this feature.
Thank you again for all the hard work, it's an amazing app. Please consider moving this feature up.

Still noone assigned :/ Please prioritize this! It's the only feature slowing down mass adoption of vscode ;)

+1'd and commenting -- really would love to have grid layout for editor windows. Particularly a pyramid layout of one full-width editor top half of screen and two half-width editors on bottom half 👍

VS Code hackers, any update on this? Please.

+1

I really don't understand what's the problem with this feature? The editor supports the needed functionality already, just not both options at the same time. For people like me with a big monitor (43" 4k display) this would be a godsend!

@underscoreHao one presumes the problem is that it's difficult to implement, however easy it may appear from the outside. Sad that it's not being prioritized though; this has to be the vscode's most-requested feature by a long shot.

Come on guys. Have none of you worked on a product before? Things don't just appear because a user really wants it to. Clearly they are doing stuff that are apparently higher prioritized - like multiple folders (or for other reasons that aren't exposed to the customers/users). You can sort by 👍 priority on github and you'll see that this is in fact not the most-requested feature - it's in place 11. Chill :)

VIM and Emacs are both editors that are nearly 20 years old and they support this as do most professional IDE's and even the other electron based editor Atom. Yet VSCode still doesn't support this and is supposedly the best editor. This keeps me from using VSCode as anything but a simple notepad. Does Visual Studio the IDE support this? If it doesn't is this a deliberate choice to hold back the user experience with VSCode to keep both at the same level of extremely basic and simplistic UX? There are very fine points to VSCode but sometimes I feel as if the developers are out of touch with the options available in other editors.

The lack of grid layout is frustrating to me also. I've used Visual Studio, Atom, Spacemacs, and Vim recently. VS Code is currently my favorite, but the lack of horizontal splits is a serious shortcoming.

Added a 👍 - I'm in the process of moving my workflow to VS Code, and so far this is the only real pain point I've encountered. (Which is to say, this editor is kind of amazing - so, thank you!)
To echo a few comments above, out of the various editors (and plugins) I've used, my favorite approach to this is by far Origami for Sublime Text.

+1

Deal breaker for me. Giving up on VS Code for now.

I'd really love to have this feature. Right now I'm using multiple windows and it's not as good. We should ideally be using only one instance to manage code.

+1
Related to this discussion, but I haven't seen it explicitly mentioned yet:  The limit of 3 editor windows is insufficient for large (4k) monitors.  If we're making the editor view layout more flexible, then this should also include removing limits on how many editor windows / rows / columns can be created.

+1. Switched back to Atom until this is done. IntelliJ pack, Sublime, Atom, Visual Studio, etc., support this.
Its kinda the first thing i looked for, specially on my 2560 x 1080 screen. Custom grids it's a most for me.

I can't believe this issue is still not resolved. It's really a must for a code editor! :/

+1 for me. I come back to vscode because of the next gen concepts and the pure awesomeness of this editor, but after a few hours I come back to sublime+origami, since I work on a 4k monitor and I usually have 4-6 panels open in  various layout settings. Unfortunately the 3-tab limit is a deal breaker for me at this moment.

This issue was brought up in the Iteration Plan for January 2018
"We understand that this feature has many up votes, but there are others with more votes. All I can say for now is that the feature is on our radar."

Can anyone explain me how many votes a must an issue have to force developers to take it into account?
This is a really useful feature and all of us miss it a lot, I mean A LOT!

@pallapo see https://github.com/Microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc

I honestly doubt that this is just a matter of how many votes exactly a feature has. They also have to take into account the expected necessesary effort as well as any synergy effects / dependencies. And the votes are anyway just a very rough indicator of how important a feature is for the community (e.g. I can't prioritize one feature I'd like to see over another)
That being said, I am surprised that this is apparently such a problematic feature to implement.

@MikeGitb Exactly. I think they will have to focus on this one when it comes the time and leave other important features on the side because everything indicates this one feature will mean a big change in the current architecture of VSCode. Even if this one feature is worked on right now, I doubt it would be shipped in the next release cycle or the next unless this is a all hands on deck approach.
I think multi-windows might help people with wider screens or 4K a little until this is implemented.

PLEASE WORK ON THIS!!! This is the only thing stopping us (10 people here at work) from using VSCODE as we are all using huge monitors! Por favor!!

I had made a post about this before knowing this was currently active. Is there any update from the VSCode team on whether or not they think this is value use of their time to make the editor better for their users? This is a feature that would be beneficial to a lot of people who don't code on big screens or are coding on laptops and want to see their files full width but need to have two or 3 files open at a time.
I know for me when coding on my 13 inch MacBook pro or 15 inch Lenovo Laptop I want to move around but tend to stay at my desk so I can be plugged into another monitor. This is a feature that the almost all other competitors have and seems to be a feature a lot of people in here miss when switching from Sublime, Atom, Vim, etc.

Atom Editor introduced the concepts of Docks which is what most people (including myself) would like in VScode & are referring to in this thread:

I use this feature everyday in Atom. Here's a contrived demo gif of me with 2 code files open, my linter & errors panel open and 2 terminals open. All of the aforementioned are draggable and placeable pretty much anywhere in the editor 🔥 ✌

Even the git diff viewer is draggable anywhere in the UI too

Yeah I hope what @cliffordfajardo posted is what's getting implemented, it's very powerful and intuitive. Of course, if its possible to drag tabs out into their own windows, that would be amazing. Multimonitor editing and debugging is where it's at.
What I'm wondering is, why haven't the VS Code devs simply ticked the ✅ Support Grid Layout checkbox yet and given it to us?? No seriously, this isn't a trivial change so no wonder it's not here yet. :)

This would be essential for the Vim keybindings of <C-w>w and <C-w>s to work correctly

Sorry to necrobump, but I would very much like to at least have 4 side by side as I have a 3840 pixel wide display and 3 as a limit only really corresponds to 1920 wide pixel displays.

This would be awesome--the ability to view four windows at once: two windows across the top, and two windows across the bottom. Easily done in Atom and Sublime Text. The lack of this feature is why I don't use VS Code.

Thanks for Looking at this @aberonni

I touched on this a bit in the 'terminal tabs bug', but is anyone interested in having the editors use tabs full of panes (the way the terminals do) instead of panes full of tabs (the way this thread/atom/sublime) is about?
tabs full of panes would allow you have a group of files open, arranged in some layout.  Then when you change tabs, another group of files, in a similar or different layout.

I would like it to be exactly like the multi-panel terminal with multiple layouts like the linux terminal client 'Tilix'. The drag-to-side feature, but add top, bottom, left and right to each panel. And the same with the terminal. On the top left of the window work-pane editor, a button that lets you add a new view, as well as switch between them. https://youtu.be/XzHE_BcSRbA?t=312

The terminal, I can't really see why you would really want more than 3 side by side

full screen mode on an ultra-wide monitor.

but it would be nice if it had tabs instead of a button that lets you select the menu of multiple views.

Yup, thats the other thread.

The terminal would be best if it was independent and acted as a separate UI component to the editor views.

I go back and forth on this (yay for things that are configurable).  I Think it would be cool if any split window in the main editor area could be come a terminal (sometimes you just want a big terminal), and also the persistent is always there because it's doing things useful to the project as a whole, and i always want to see it.

yeah, maybe have the option of the quake console style, top, sides and bottom, or have them as a type of panel in the view. Also I know it's configurable but maybe a the shortcut should be a single key. I might have to think about that, I would like to use f12 if it was available.

I think you can't get much better than the way Origami works for Sublime Text: https://github.com/SublimeText/Origami . With a right click you can add/remove panes in any direction, save your layout, etc. Extremely useful.
One other note: In Sublime you can also open an entirely separate window of the same file. I use this, for example, to have certain panes open in one monitor, and other panes open in a separate monitor. (that might be a totally separate feature however)

Would prefer if everything in Code was just a tab (terminal, problems, output debug console etc), and that tabs were free to be positioned / split anywhere (above, below, side by side etc) like atom.

Would prefer if everything in Code was just a tab (terminal, problems, output debug console etc)

Exactly! This is one of the main features of editors as VIM or Emacs that makes them so powerful - a generic approach to windows.
I once requested something very related, but with focus on a specific use case: #30987. It appears VSCode  team totally didn't understand usability value of that (cc @bpasero )

Exactly! This is one of the main features of editors as VIM or Emacs that makes them so powerful - a generic approach to windows.

The emacs terminal emulator is fantastic. You can navigate quickly with keystrokes and add or delete text anywhere in the buffer. (in evil mode of course)
I spent a month in spacemacs a few months ago and loved the buffer multiplexing and terminal emulation. Emacs is just missing some tools I use everyday in vscode.
When I switched back to vscode it was back to 3 open files and tmux for terminal multiplexing.
 I always make fun of my co-worker who lives in emacs, yet I envy him sometimes). I would think Microsoft could implement this, but after months of following this thread I'm beginning to lose hope.

Great news. grid layout made it to the Feb 2018 iteration plan
https://github.com/Microsoft/vscode/issues/43361

Workbench
🏃 Improve notification UI #22388 @bpasero
💪 Investigate support a grid layout for editors #14909 @stevencl @bpasero @Tyriar @joaomoreno

Emacs is just missing some tools I use everyday in vscode.

Exactly, the great integration of latest language features are the main reason I'm on VSCode. Nobody works on providing that to Emacs unfortunately.
Still my productivity on VSCode suffers purely cause of such limited windows handling

WOOO I can plan to move from sublime text to VSCode now.
Thanks ~Chuck Norris~ Microsoft!

"Investigate" means that they will still analyse the issue and only then set a goal to really implement it? Right?

Looks like this item is deferred on the Feb iteration plan as of 02/26. Hopefully next cycle.

Suddenly hit this no-grid-layout-yet-folks problem while working on a very tall .tex file just now. I was hoping I could split the tall .tex file pane into 2 verticals on the LEFT group and the single PDF file on the RIGHT group. That would be sweet for us using VS Code for writing papers, VS Code team. So pleeeease approve the feature request for grid layout c(~_~)"

This should be implemented without limiting the maximum number of columns/rows, the current limit of 3 columns doesn't make sense to me.

Sorry guys but this is just an INVESTIGATION!!
"Investigate support a grid layout for editors #14909 @stevencl @bpasero @Tyriar @joaomoreno"

@pallapo "investigation" is still an indication of movement forward. It's great to see any official movement on this ticket at all. Thanks, team!

@joshjensen you're right!

I agree with @fabiospampinato. The option to split any viewport into two, in either orientation, as long as the ui allows it, seems like a strong way to implement this. If the windows are generic enough, they could be used to build any number of tools (similar to the Docks feature from Atom) referenced above.

Time to do something about this Microsoft VS team 👍 😄

Trying to leave atom completely behind, but this is a big one is holding me back. I love everything else about VS Code. Hope Microsoft allows vertical and horizontal splitting soon!

Adding +1 to the "this is the only thing keeping me from using VSCode full time" sentiment.

@elleryfamilia if you don't care able being able to do both at the same time these are the steps to activate just vertical or just horizontal

View > Toggle Editor Group Layout menu.
View: Toggle Editor Group Vertical/ Layout command in the Command Palette (⇧⌘P (Windows, Linux Ctrl+Shift+P))
-Toggle button in the OPEN EDITORS tool bar.
⌥⌘0 (Windows, Linux Shift+Alt+0) keyboard shortcut.

But yeah having the ability to drag a file anywhere top bottom left and right would make vscode practically unbeatable for me.

Ran into this myself trying to switch to VS Code from Vim. Major setback. I particularly noticed when I wasn't able to find how to jump left or right between splits with a keybinding since each is explicitly numbered. In my Vim+iTerm setup I'm able to jump up and down seamlessly between a vim split and a terminal split and replicating that in VS Code is near impossible.
The mention of EVERYTHING being a tab, not just editors, would make a massive difference to a grid layout system as well. Having a terminal tab, editor tabs, debug tabs, etc. would be huge... even a sidebar tab might be nice but would be a huge overhaul of course. I hope this gets some solid traction. I may not stick with VS Code long unless I figure out a couple of hacks for navigating relatively between editors.

Yeah this is a major thing.  Screens aren't always as you think they are.  I use multiple portrait monitors and with the ultra-wide monitors there are reasons people would want to do more than 3 columns anyways.
No reason for VSCode to implement restrictions based on their own personal thoughts of how screens are used.
I was in love with Atom until this one thing came up.  I usually have atom projects on both portrait monitors with horizontal splits on them and then i use multiple 3-4 vertical splits for my ultra-wide

Seems the Investigate support a grid layout for editors task has been moved to Deferred Items
I come to this issue page almost every day, to check the status.
Actually every-time I open the editor and split the window, I go and check this, if there is any hope.
I hate switching editors, VS Code is perfect in all the aspects, thanks a lot for all the awesomeness!!
But starting to seriously considering to switch, working on multiple files with current layout is a pain, every single day.
Much more pain than having to reload after installing an extension and other issues, that had more votes than this.
Not being critical at all, this is by far the best open source product I've used.
I would only appreciate more information to the community, is this even feasible, how much longer should we wait till we know more? Is this not critical to the vast majority of users and has low priority?
Please let us know, so we can decide and move on.

I don't see it deferred- #47369

Deferred in March, fingers crossed for next iterations.

Yeah, I am waiting for this as well. Even Visual Studio can do it with some hassle (drag file to start separate window, which you can split again = you can have multiple windows with multiple splits).
I absolutely need it when I need to see multiple files. Many people have requested it and many more will. Please, please, pretty please, implement it. It is incredibly useful on big screens.

@RayBenefield navigating between splits as you describe is doable by binding keys to workbench.action.navigateUp|Down|Left|Right.

@bpasero look 1.23 insiders release and no window layout(#14909). Does it mean that it will not be updated in April?

:+1: In the great words of 50 cents, Patiently Waiting.

#49599 Slay Ben, slay. The final, missing piece that will make VSCode the only editor of choice in 2018. Except for ssh. VSViCode 2k19?

Wow. Just looked over all of the comments of this issue. I have almost gotten used to the no grid layout and not realising that this is such a hot topic. For anyone skipping through till the end, the latest update doesn't include it but according to issue #47369 they are in progress of creating something similar to this.
Let's cross our fingers for the May update to include this :crossed_fingers:

@elebumm There's actually a pull request where you can see how far they are with this feature and the continuous progress they are making.
It also states that they plan to roll it out in June for insiders.

Current Plan is to make this feature testable for this months (May) endgame week and then ship it to insiders early June. This would mean it lands in stable for the release end of June.

@skreborn Hope this is true. Having only 3 vertical splits is super unpractical with 2 monitors...

@psychosis448 It's true, here's the gif from the WIP PR:

🤞 seeing the gif really brings joy.
Just finished reading all the comments and realized that these guys have definitely been hard at work.
I know this wasn't an easy task and wanted to just say thanks for pushing this along and yet again taking the beating and hearing us out.
Greatly Appreciated !

I know that I'm late to the party and I guess this would be out of scope for the grid layout thing, but in case the VS Code team is watching: it would be really, really awesome if the terminal windows, especially, could somehow fit into this grid layout. As you probably know a lot of users on *NIX use screen or tmux together with vim or some other console editor. Others use tiling window managers, for basically the same effect, just with graphical editors.
It would be a shame if you make such a huge change and don't at least design the new feature with such an logical extension of this idea, in mind.

Implementation of this takes a very long time.....
I hope it will have functionality to toggle focus window into full screen (and back to previous layout when toogle it once again), something like this:

https://atom.io/packages/maximize-panes (atom)
https://packagecontrol.io/packages/MaxPane (sublimetext)

Ohh boy, 60hz? God-like coders use 120hz. I can't use this product.
Those extra refreshes are necessary for superior cursor movement speed.

@phoenixsampras I hope there's nothing sensitive in that screenshot..

@phoenixsampras @michaelduminy IP's and at least a DB password... I'll recommed taking it down 🤦♂

@andion Admin password aswell

While this feature will land into our insider builds only sometime next week (for a stable release end of June), we have custom insider builds for testing this feature now available for more people to try out:

macOS: Download
Windows: Download
Linux: Download

Note: In order to run these builds you will first have to close any running VSCode Insiders build.
Feedback is very welcome, ideally as individual issues and not as comments here to reduce the number of notifications for people subscribed. Please ensure to first have looked for any existing issue with the workbench-grid label already: query
There is no real documentation for the new features yet, except for maybe the test plan item we went through this endgame week: https://github.com/Microsoft/vscode/issues/50458
A quick overview:

editors can be split vertically and horizontally (e.g. via drag&drop, or from the split action in the editor toolbar - hold Alt key to split in the other direction)
a setting workbench.editor.closeEmptyGroups allows to configure if closing the last editor of a group should also close it
the "open editors" view is no longer showing groups based on their location (left/center/right) but with a number in their order of creation

We are still planning on tweaking this experience, specifically around these outstanding issues:

Connect the sash in the 2x2 grid #50770
Allow to drag sashes at places where 2 overlap to size both ways #50769
Grid: Implement "Centered Editor Layout" #50936

Something related, especially for those who come from Vim, is the fact that open files are bound to editors.
Is there a way of closing a editor without closing its files? So we can have vim-buffer like functionality?

Will this implementation also allow for the sidebar, activity bar, etc ... to be organized in a grid layout? For example, could I have the activitybar at the bottom?

Will this implementation also apply to the activity bar? Could I have the bar attached to the bottom?

Well those are internal IP ranges, not public IPs. You can learn more about
it on https://en.wikipedia.org/wiki/Private_network
On 28 May 2018 at 13:47, Lucas Andión Montáns<EMAIL_ADDRESS>wrote:

@phoenixsampras https://github.com/phoenixsampras @michaelduminy
https://github.com/michaelduminy IP's and at least a DB password...
I'll recommed taking it down 🤦♂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/14909#issuecomment-392577362,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB37QPG3mjlaU8bbCEuA7e1h190rdZj2ks5t3DgYgaJpZM4KoZDu
.

--
Best regards,
CP

@bpasero How do we actually install these, though?

@dnutels you should be able to just run the provided downloads without installation. I did not want to put installers up because since this has not yet landed in insiders, you would get an update notification shortly after that would bring you back to the previous version.

@bpasero Just tried the builds you posted and it worked flawlessly, thank you!

Awesome feature without any limitations!  Great work @bpasero

Thank you! This is awesome! I've been watching this issue for years. Congratulations on this!! Thanks for everyone's really hard work and perseverance to work through the terrible comments of 'I won't ever use VSCode with out this!'.

@bpasero Works great but I think the areas to initiate a split are a bit small. Are you planning to support panels like "output" and terminals in the new layout?

Working great, love it! Thanks @bpasero!!! Where should I send the 🍾  ? :)

Only thing I noticed.
If I initially have full page with a symmetric 2 x 2 grid.
I resize the editor to only half a screen and make it full screen again, it does not maintain the ratio of open sections.
The first column is very narrow.
I notice this with manual resize and using Magnet as well.
Not important but a nice to have. 😄

VSCode team you are amazing! Thank you, thank you, thank you. 🍾🍾🍾

Does this feature make 3-way diff in vscode possible?

Could this be extended to any window by any chance? Like getting rid of the sidebar at all and allow me to construct my own tiled UI from all the windows I need including terminals, code overview, explorer, problems list, etc.

graet job @bpasero I really love it!
Thanks, thanks a lot!!!!

@bpasero during a discussion about grid layouts, maybe also this topic:
https://github.com/Microsoft/vscode/issues/16927
As I wrote there, similar functionality to this:
Atom -> https://github.com/santip/maximize-panes
SublimeText -> https://github.com/jisaacks/MaxPane

This is brilliant! Hope it makes it's way into the Stable build very soon! 👍

Please consider keyboard shortcuts for grid window actions for those of us who dislike leaving home.

It would be nice if Terminals could be part of the Grid system, so we can arrange our terminals in any grid too! https://twitter.com/_rctl/status/1004704690586705921

@eighteyes I am counting ~35 new commands being added as part of grid that all can have keybindings assigned so please let me know which one is missing and we can look into adding it...

This is awesome! It's simply fantastic that the VSC team has been able to work on this and make it a reality. Can't wait for the stable release. As time goes on, I'm sure the team will bake in the ability to split in terminals, git windows, etc. For now, I cannot complain that this is coming and am simply ecstatic. Thanks for this! 🥇

Dear VS Code team: you put in the VS Code release notes that we should subscribe to this issue on Github if we want to be notified when the feature is ready: "This feature will be available in our Insiders release in the beginning of June. Subscribe to issue 14909 to receive a notification when this happens." Cool idea in theory! Minimal work on your end, leverages existing tools, users already know how to use Github, etc. But in practice, I'm getting a lot of noise from this issue, and I imagine other people are too. I subscribed within the last 24 hours and already received a dozen or so notifications through Github unrelated to the release that made me want to subscribe in the first place. I hope this constructive criticism is helpful! But I am definitely going to unsubscribe from this issue, and I do hope that another way of subscribing to new features can be worked out. Sincerely yours: some random guy.

@sdegutis https://tellmewhenitcloses.com

Awesome @pelotom thanks for the link!!

Closing this as the feature has landed in insiders. You can see this query for work that is still planned for this milestone (as for example to support "Centered Editor Layout" properly).
Feel free to continue to report issues or feedback (after checking for duplicates).
I will mark this issue as readonly to reduce the number of notifications people get.


Cleaning up files

Cleaning up files ready for v1.0.0 release.

appears it doesn't expect to find no tests.


Make test setup functions terminate on error

I changed test setup and teardown functions to take no arguments and return void, because that's what pw_unit_test expects. If an error occurs in the initialization / deinitialization code, I call VerifyOrDie instead of returning an error value.
Followup: VerifyOrDie(...) should be replaced by ASSERT_SOMETHING(...) once transition to pw_unit_test is completed.
EDIT: Following suggestions by @andy31415, the scope was reduced - I will make the necessary methods static and rename some context classes in followup PRs.

@Alami-Amine - FYI


Gradle build fails, can't resolve all artifacts

Describe the bug
Gradle build fails after adding the plugin, using NativeScript-Vue.
To Reproduce
Add the plugin to a NS-Vue project.
Expected behavior
Finalize build successfully.
NativeScript Info(please run tns info):
√ Getting NativeScript components versions information...
√ Component nativescript has 6.4.1 version and is up to date.
√ Component tns-core-modules has 6.4.2 version and is up to date.
‼ Update available for component tns-android. Your current version is 6.0.0 and the latest available version is 6.4.1.
‼ Update available for component tns-ios. Your current version is 6.0.1 and the latest available version is 6.4.2.

Sample Code(please provide minimum code to reproduce problem):
https://github.com/nativescript-vue/nativescript-vue
Additional context
I'm getting this error:
FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\Hp\Documents\GitHub\ayneh-mobile-app\platforms\android\app\build.gradle' line: 534

* What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all artifacts for configuration ':app:debugRuntimeClasspath'.
   > Could not find vectordrawable-animated.jar (androidx.vectordrawable:vectordrawable-animated:1.1.0-beta01).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/androidx/vectordrawable/vectordrawable-animated/1.1.0-beta01/vectordrawable-animated-1.1.0-beta01.jar
   > Could not find fragment.jar (androidx.fragment:fragment:1.1.0-alpha08).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/androidx/fragment/fragment/1.1.0-alpha08/fragment-1.1.0-alpha08.jar

build.gradle:
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {

    repositories {
        google()
        jcenter()
        mavenCentral()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.4.1'
    }
}

allprojects {
    repositories {
        google()
        jcenter()
        mavenCentral()
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

This isn't related with this plugin.

Hi @jibon57 and thank you for your response.
Yes, I didn't find vectordrawable-animated in your plugin's dependencies, but when I remove nativescript-mediafilepicker, build happens smoothly. I'm relatively new to Gradle and would appreciate your help :)


how to get folder_id by folder name?

how to get folder_id by folder name??

The list of all folders is received through the update `updateChatFolders, so you can do this yourself, but be aware that multiple chat folders can have the same name.

i see that there is parameter chat_folders_ in method, is array of chat folders. Why?

or how to call it right

that is how i call it

See https://core.telegram.org/tdlib/getting-started.

ok, thx, but now i have another problem:

its crashes randomly

This is unlikely to be an issue with TDLib.

its issue with python wrapper or with my pc then?

Yes please, my phone no more batterry.
On Fri, 25 Oct 2024, 21:03 shared object, @.***> wrote:

its issue with python wrapper or with my pc then?
—
Reply to this email directly, view it on GitHub
https://github.com/tdlib/td/issues/3100#issuecomment-2437865501, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BJ4PV44H4AAGZCLP5YN7YEDZ5JFRLAVCNFSM6AAAAABQSCI3QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXHA3DKNJQGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This is an issue with code.


(Feature) Hotkeys for context menu option

Any thoughts on giving those context menu options a shortcut keys?

I'm not sure what you're asking for.  Are you trying to configure which hotkeys interact with the context menu?  Or is there some action that currently doesn't have a hotkey that you want to add?

Yes. I would like to config a Keyboard shortcuts to use the context menu.
Like Ctrl + O to trigger contextMenuItem number 1
Ctrl + K to trigger contextMenuItem number 2
.
.
.

You can do that without any changes to the library.  But that does seem like a pretty common requirement, so I should put a section in the docs about it.
Here's what I would do:
import { HostListener } from '@angular/core';

...

// meta is control on windows and command on mac
@HostListener('window:keydown.meta.o')
executeActionOne() {
  // stuff
}
@HostListener('window:keydown.meta.k')
executeActionTwo() {
  // stuff
}


Graphics features like DLSS/Frame generation/Fluid motion frames not available

Basically, I don't get any options in Adrenaline to enable any special features.
I made sure I have only 1 graphics driver running and no dice.
Is this expected behavior?

I second that question as it may be an issue for us down the line of our development with VDP. Any idea what could cause this @itsmikethetech ?  And thank you, this work is great. We really appreciate it.

Do those features require hardware support?  For example, I think DLSS is implemented with the Nvidia tensor cores, I think?


vizlab version update

Okay, I see where you got that guy from.

Cool. I also just created a vizlab release, v0.3.4, which we could use as the ref instead, but i think the commit hash works just as well, so let's keep that.


Bug when changing the portal html

When I change to others portals by selecting "Select HTML" on the flipper the wifi html goes bugging.
In the first screen I have the Apple portal and it's all good, when I change it to Amazon they like fuse together, I'm using Xtreme firmware and I've installed the evil portal with flipper katalog.

"FIXED" I need every time I want to change the portal to click "reset" on the dev board.

Optionally you can reboot the flipper by pressing and holding "back" and "left" before selecting the new html file


ColinEberhardt/VCTransitionsLibrary

VCTransitionsLibrary - A collection of iOS7 animation controllers and interaction controllers, providing flip, fold and all kinds of other transitions.
Language - Objective-C.

https://github.com/vsouza/awesome-ios/pull/2286


[VS Code] Could not load file or assembly 'System.Runtime.Serialization, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.

Error:
Could not load file or assembly 'System.Runtime.Serialization, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The system cannot find the file specified.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.2.260

protocolVersion
2.1

applicationName
VSCode

applicationVersion
1.21.1

platformName
MacOS

platformVersion
17.3.0

Hey @aalibasic, thanks for reporting this!! Could you please take a look at ~/.vscode/extensions/ms-vsliveshare.vsliveshare-0.2.260/dotnet_modules and confirm System.Runtime.Serialization.dll is actually there?
I think you're hitting #112. Assuming the file is there, can you try completely shutting down VS Code and then reinstalling the extension to verify that fixes the problem?

Closing as a duplicate of #112 due to inactivity.


npm commands stop working/break with npm config set ignore-scripts true

when a users has npm config set ignore-scripts true all npm commands break and flightdeck will not start.
current work around is to use yarn command in place of all npm commands.

using npx resolves this


Unresolved reference: OpenAI in 3.0.0-beta01

This is version: 2.1.3

This is version:3.0.0-beta01
Most of time, I can't make the interface OpenAI in 3.0.0-beta01 be referenced. But once, it can be reference (and I don't know how it works), another error occurred: Only the interface (not the public fun OpenAI(token: String): OpenAI ) can be call, it makes create an instance for interface impossible.

@CloudChaan I would suggest to clean your IDE cache, if it doesn't work, clean your gradle cache

@Aallam
Thank you!
It works! And… I almost shed tears!


Change how the reserved keywords are checked

We're using the $yourls_reserved_URL array to avoid people using swearwords as keywords. We've noticed recently that the behaviour seems to be to check whether a suggested keyword is in the list. Otherwise it's acceptable. So if you concatenate %$#! (the swear word) with TEST to form %$#!TEST it will be accepted.
I would like to suggest to change that approach to check whether the keywords contains any of the reserved keywords.   Maybe an additional flag should be introduced, $yourls_reserved_URL_strict that could by default be set to true (to be retro-compatible) or false to activate the new behaviour.

[x] Check you are using the LATEST release or the development branch.
[x] Make sure you have SEARCHED existing issues first.
[x] Read the GUIDELINES linked in the yellow notice box above.
[x] COMPLETE this issue template.

Technical details regarding my environment

YOURLS version: 1.7.2
PHP version: 5.6

That's definitely plugin territory. Most people don't need such a feature (typically single user install with no public interface don't need that, which accounts for roughly 70% of YOURLS installs).
This said, this would make a very interesting plugin (so far there's nothing similar that I know of)

So, I've written my plugin but am unsure which hook to use. Two places seem most appropriate, both in the functions.php file:

yourls_do_action( 'add_new_link_custom_keyword', $url, $keyword, $title ); line 246
$keyword = yourls_apply_filter( 'custom_keyword', $keyword, $url, $title ); line 249

In case the plugin detects that a swear word of the list is used as a substring inside the submitted keyword, I'd like to return a message equivalent to the case where !yourls_keyword_is_free( $keyword ) (line 250).
However, with either hook I cannot see how to achieve it. With the filter, the only thing I see I could do is to have my plugin return a known bad word so that it will be caught in line 250, but that doesn't seem clean. And for the action hook, I can't see how I can influence the subsequent flow of execution.
Any pointers gratefully received.

How about shunt_add_new_link (line 199)? It gets the keyword (if any) and returning a truthy value short circuits the link creation. The function would have to print a message itself, though.

I think @dgw's suggestion is sound here. Apply your custom filtering rules as early as possible. Depending on your use case, you will also want to check keyword after editing (to make sure "kd9Po" isn't edited into "niggercuntfaggot" for instance)

Thanks @dgw and @ozh I'll try this. I should probably say "again", because I initially actually did use that particular hook, but somehow it got hung, i.e. it never returned. Only later did I think to check the PHP log for any traces, because of the number of arguments that might be passed and expected. I found later that these errors get dumped into the error log.
By the way, one thing that might benefit debuting plugin developers is the addition of a small section on how to pass arguments to a hook'ed function. I looked at many plugins, and sometimes they passed one argument, say $keyword, sometimes none, but still it was possible to retrieve them from within the function via $args[0] etc. I couldn't find an explanation that would explain the logic behind it. Maybe I just didn't look at the right place... :-(

Everything is explained on the wiki... here in particular: https://github.com/YOURLS/YOURLS/wiki/Plugins

It probably is, just not very explicitly.  As I understand it now, having re-read the page looking for information on argument passing, 'action' functions seem to pass in an array of arguments, like mentioned here:

Now if you hook a custom function into the event 'pre_redirect', it will be passed array($location, $code) as an argument.

Whereas 'filter' function pass in arguments one by one (i.e. not bundled into an array), like mentioned in this example:

$keyword = yourls_apply_filter( 'random_keyword', $keyword );
If a custom function hooks into the 'random_keyword' filter, it will be sent $keyword as an argument.

The fact that these are given as examples only makes it not 100% clear for the reader whether this is the case of this particular example, or a generalisation that can be assumed for all cases of 'action' or 'filter' functions, respectively.
I think it would be worth highlighting the fact that arguments are passed differently, depending on the hook type.


build: Bump build-tools to 0.26.1 across repo

Bumped build-tools deps across repo to 0.26.1.
Ran policy-check:fix to do automated fixup in the repo.
Cleaned up policy handler exclusion settings in fluid-build config.

webpack becomes production dependency?

Refers to: pnpm-lock.yaml:43105 in 3bba245. [](commit_id = 3bba2455c8f25edcc7a31f195006c5ec0491727e, deletion_comment = True)

Looks like /webpack-cli/4.10.0_ai6cu5vnuisb2akyozxbiaqwvu already was - so not really a notable change

In reply to:<PHONE_NUMBER>

Refers to: pnpm-lock.yaml:43105 in 3bba245. [](commit_id = 3bba2455c8f25edcc7a31f195006c5ec0491727e, deletion_comment = True)

Thanks for the review, @jason-ha!


 However, all of the affected usages were actually synonyms themselves. I.e. species combined into new genus.
Maybe, consider adjusting to only affect accepted taxa with a synonym parent  ?

I am not sure if I understand, can you give an exampe? "Chained" synonyms, i.e. synonyms that have another synonym as the parent, are not desired.

@thomasstjerne ? I would close this otherwise as I dont understand the problem

Say the genus Aus is being combined into the genus Bus.
Hence the species Bus cus is also combined into Aus as Aus cus.
So the usage Bus cus is a synonym and its parent Bus is also a synonym, but this seems legit?

In what format does this example happen, DwC?
Synonyms no matter in which format should always point to an accepted.
And the classification given for synonyms is irrelevant and instead taken from the accepted.
Bus cus is a synonym and Aus cus is the accepted. It does not point to Bus anymore, or how does it do that?


cURL SSL_ERROR_SYSCALL (OpenSSL\LibreSSL)

seems like there is some inconsistency with curl (binary itself) or\and brew use of curl.
i installed the latest curl and made sure it is in my path environment variable
$ brew install curl
Warning: curl 7.59.0 is already installed and up-to-date

$ which curl
/usr/local/opt/curl/bin/curl

$ curl --version
curl 7.59.0 (x86_64-apple-darwin17.5.0) libcurl/7.59.0 OpenSSL/1.0.2o zlib/1.2.11 libidn2/2.0.4 nghttp2/1.31.1
Release-Date: 2018-03-14
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IDN IPv6 Largefile NTLM NTLM_WB SSL libz TLS-SRP HTTP2 UnixSockets HTTPS-proxy

yet, when i look at my brew configurations, i see that curl is using a different path (/usr/bin/curl) then the above (/usr/local/opt/curl/bin/curl)
$ brew config
HOMEBREW_VERSION: 1.6.1
ORIGIN: https://github.com/Homebrew/brew
HEAD: 5a2817cb023ca5e929fe030d423002992bdabf1b
Last commit: 4 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 94d798a38c48bc5edb49c6c90cfa2a73f684f3ee
Core tap last commit: 5 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: --appdir=~/Applications
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_NO_ANALYTICS: 1
CPU: quad-core 64-bit kabylake
Homebrew Ruby: 2.3.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 9.1 build 902
Git: 2.17.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 10
macOS: 10.13.4-x86_64
CLT: <IP_ADDRESS>.1.1521514116
Xcode: 9.3
XQuartz: N/A

regardless, when i try to use either of which i get the SSL_ERROR_SYSCALL error
$ /usr/bin/curl https://statics.teams.microsoft.com/production-osx/<IP_ADDRESS>52/Teams_osx.dmg > /tmp/test.file
curl: (56) LibreSSL SSL_read: SSL_ERROR_SYSCALL, errno 54

$ /usr/local/opt/curl/bin/curl https://statics.teams.microsoft.com/production-osx/<IP_ADDRESS>52/Teams_osx.dmg > /tmp/test.file
curl: (56) OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 54

yet, i have no problem downloading the file using wget.
note sure whether it is a problem with curl itself, as it seems the issue happens regardless on which curl binary is used.

is it a curl bug generally, or is it specific to macos?
when i pass the --no-alpn to curl it bypasses the issue. how can i pass curl parameters when using brew? (placing the parameter within ~/.curlrc is honored when using curl binary but not when curl is invoked via brew)

UPDATE
setting HOMEBREW_FORCE_BREWED_CURL=1, is reflected in brew config yet, the issue still occurs.
i came across the issue when running a cask formula
$ brew cask install microsoft-teams

yet, when i look at my brew configurations, i see that curl is using a different path (/usr/bin/curl) then the above (/usr/local/opt/curl/bin/curl)
setting HOMEBREW_FORCE_BREWED_CURL=1, is reflected in brew config yet, the issue still occurs.

This is intentional.

$ /usr/bin/curl https://statics.teams.microsoft.com/production-osx/<IP_ADDRESS>52/Teams_osx.dmg > /tmp/test.file
curl: (56) LibreSSL SSL_read: SSL_ERROR_SYSCALL, errno 54
$ /usr/local/opt/curl/bin/curl https://statics.teams.microsoft.com/production-osx/<IP_ADDRESS>52/Teams_osx.dmg > /tmp/test.file
curl: (56) OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 54

This is an issue specific to your machine (not Homebrew) you'll need to figure out yourself, I'm afraid.

@MikeMcQuaid: just to be sure, were you able to reproduce it or not?
and another unrelated question, how can specify which ruby binary brew is using. meaning, when executing brew config the Homebrew Ruby: will be point to the ruby which i installed via brew?

just to be sure, were you able to reproduce it or not?

I cannot.

can i pass the --no-alpn to curl when it used by brew?

No, sorry.

how can specify which ruby binary brew is using

You cannot change this. This is intentional. We do not support using custom Rubies.

@MikeMcQuaid:

I cannot.
meaning that you didn't get any error when running the curl command above without --no-alpn.
correct?

thank you.

thank you.

You are welcome.

@MikeMcQuaid: but why curl does not honor ~/.curlrc? (if it would have honor the file, i could bypass the issue)

@y0y0z You must set HOMEBREW_CURLRC.

@MikeMcQuaid thank you!

i still didn't find a permanent fix for the issue, but here is why i did in order to bypass my issue.
echo '--no-alpn' > ~/.curlrc
export HOMEBREW_CURLRC=1
brew cask install ...


Add functional tests for richmedia module

Would be greate to have a test when hooks.pb-richmedia-filter.enabled : false. I don't see test when in account and in host config feature enabled and from where should we get precedence?

but we already had that
host true, account false:
PBS should process request without analytics when adm matches with pattern name and filter enabled in host config but disabled in account config
host false, account true:
PBS should reject request with error and provide analytic when adm matches with pattern name and filter disabled in host config but enabled in account config
Extended with host true, account true

Would be greate to have a test when hooks.pb-richmedia-filter.enabled : false. I don't see test when in account and in host config feature enabled and from where should we get precedence?

but we already had that host true, account false: PBS should process request without analytics when adm matches with pattern name and filter enabled in host config but disabled in account config host false, account true: PBS should reject request with error and provide analytic when adm matches with pattern name and filter disabled in host config but enabled in account config Extended with host true, account true

I'm not mean "hooks.modules.pb-richmedia-filter.filter-mraid": true/false,
I offer this one property hooks.pb-richmedia-filter.enabled : true/false` entire hook.

Would be greate to have a test when hooks.pb-richmedia-filter.enabled : false. I don't see test when in account and in host config feature enabled and from where should we get precedence?

but we already had that host true, account false: PBS should process request without analytics when adm matches with pattern name and filter enabled in host config but disabled in account config host false, account true: PBS should reject request with error and provide analytic when adm matches with pattern name and filter disabled in host config but enabled in account config Extended with host true, account true

I'm not mean hooks.module.pb-richmedia-filter.filter-mraid: true/false, I offer this one property hooks.pb-richmedia-filter.enabled : true/false entire hook.

added


Remove deprecated commands for code upate

extended/code_update/test_image_upload.robot:    Execute Command On BMC  rm -rf /tmp/images/*
extended/test_bmc_upload_stability.robot:    BMC Execute Command  rm -rf /tmp/images/*  quiet=${1}
syslib/utils_os.robot:    Execute Command On BMC  rm -f /tmp/images/*

Remove image clean up from BMC Current code update cleans out the images from /tmp dir.

Under review https://gerrit.openbmc-project.xyz/#/c/9048/


Move CI infrastructure from Bamboo to Jenkins

As a developer, I'd like to migrate the CI infrastructure from Bamboo to Jenkins, so it simplifies the overall release process.

CI build is moved to jenkins.


setDataAsync assigns a negative value to an UInt causing runtime crash

For some reasons only in my tests, the framework fails in the DiskCacheLevel.swift method setDataAsync.
The crash seems to be caused by the assignment of a negative value to the iVar size which is an UInt.
We are specifically talking about this part of the code
if newSize > previousSize {
    size += newSize - previousSize
    controlCapacity()
  } else {
    size -= previousSize - newSize
  }

In case it helps:
At the first call of the method setDataAsync the size = 0, previousSize = 0, newSize = 223
At the second call of the method the size = 223, previousSize = 27986, newSize = 223, as a result it gets to:
size -= previousSize - newSize
And because size is a UInt iVar, it crashes.
So, the previous size was much larger than the new size and in the same time the size iVar is not big enough for the subtracting operation. Not sure why is the previous size that big if the first call of the method determines an initial change in size of 223.
More details:
The cache I am using is as follows:
MemoryCacheLevel<URL, NSDate>().compose(DiskCacheLevel<URL, NSDate>().pooled())
And the ExpensiveObject extension is specified like this:
extension NSDate: ExpensiveObject {   public var cost: Int {     return 1   } }
Maybe I'm doing something wrong with the cost [I was not sure what is the correct way to determine it's cost, so I just assumed we can reduce it to TimInterval cost which is a Double], but even in this case, I guess the library should be crash free and in this kind of situations just return an error or fail silently with an error log.
Also please note that my tests set the value for exactly the same key 3 times consequently.

Hi @Carpemeid, thanks for the very detailed description of the issue you're encountering!
To be honest, I have little time to investigate this in the short term, but I'll try to have a look as soon as I can and I'll come back to you with my findings!