GWT: Promise & Future support

@dharezlak says in Gitter chat:

I played a little with the Future/Promise pair on the other side of the fence (I mean the browser side). This required a few modifications which were super-sourcing the ExecutorService interface and providing a simple implementation for it. Simple use cases worked just fine.

I believe this makes sense.

@ruslansennov I also had to remove code using Object#wait()|notify() as these methods are not available in GWT. Also, some calls do not make sense on the client side such as Future#get()|isEmpty() as they use Java's notification mechanisms. One way to deal with this is to use GWT's replace mechanism which could use class implementations throwing exceptions for such cases (http://www.gwtproject.org/doc/latest/DevGuideCodingBasicsDeferred.html#replacement).

We can leave <exclude name="concurrent/**"/> entry in Javaslang.gwt.xml, but implement lightweight version of Promise and Future Javaslang's classes in GWT super-source folder. If you have played with it, could you try do this?

I'll try...

Where can I push the preliminary implementation?


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
HTTPS Corrected URLs

Was
Now

http://clojars.org/mvxcvi/multihash
https://clojars.org/mvxcvi/multihash

http://clojars.org/mvxcvi/multihash/latest-version.svg
https://clojars.org/mvxcvi/multihash/latest-version.svg

Other Corrected URLs

Was
Now

https://www.versioneye.com/clojure/mvxcvi:multihash
https://www.versioneye.com/clojure/mvxcvi:multihash/2.0.1

Updated.


How to use calculated version(s) to pre-process files in the build?

In my scenario I have a repo that contains some projects that represent NuGet packages with DLLs, plus some .NET CLI template packages that have projects that need to reference the build NuGet packages. Because the NuGet package versions are generated dynamically (thanks, NerdBank! 😄), I figured I need to use $(NuGetPackageVersion) to process my template files and get that version injected into them.
I figure one strategy is to have a file such as templates\.template.config\template.json.in (note the .in extension) that has text REPLACE_VERSION in it, then with an MSBuild target that runs at a suitable time, replace REPLACE_VERSION with $(NuGetPackageVersion) and save the file as templates\.template.config\template.json, and let the build continue with the substituted values.
Does anyone know any guidance or sample of how to do this?

Yes, I've done this in a few places, including an OSS repo very recently:
https://github.com/microsoft/vs-threading/pull/554/files#diff-81f1e2b7e2669d47bc2274efe06588f9

Awesome, I was able to use something very close to that and get my stuff working.
Because I'm running w/ .NET Core, I wasn't able to use CodeTaskFactory, but had to use RoslynCodeTaskFactory instead, with slightly tweaked imports:
  <UsingTask TaskName="ReplaceFileText" TaskFactory="RoslynCodeTaskFactory" AssemblyFile="$(MSBuildToolsPath)\Microsoft.Build.Tasks.Core.dll">
    <ParameterGroup>
      <InputFilename ParameterType="System.String" Required="true" />
      <OutputFilename ParameterType="System.String" Required="true" />
      <MatchExpression ParameterType="System.String" Required="true" />
      <ReplacementText ParameterType="System.String" Required="true" />
    </ParameterGroup>
    <Task>
      <Using Namespace="System" />
      <Using Namespace="System.IO" />
      <Using Namespace="System.Text.RegularExpressions" />
      <Code Type="Fragment" Language="cs">
        <![CDATA[
            File.WriteAllText(
                OutputFilename,
                Regex.Replace(File.ReadAllText(InputFilename), MatchExpression, ReplacementText)
                );
          ]]>
      </Code>
    </Task>
  </UsingTask>

Because I'm running w/ .NET Core, I wasn't able to use CodeTaskFactory, but had to use RoslynCodeTaskFactory instead

How very peculiar. I use my version in a few different repos that all work with dotnet build. I wonder what went wrong for your case.

When I want to see what happened in MSBuild: http://www.msbuildlog.com/

I got an error saying that CodeTaskFactory wasn't supported, then Bing led me to RoslynCodeTaskFactory. I'd have to try again to see what the error was.

This post is old but it seemed to match what I saw (I think): https://github.com/Microsoft/msbuild/issues/2890
I'm running .NET Core 3.0 and 3.1, but I'm not sure which I was using when I got the error.


Updated Smartsheet link to current, old link deprecated

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

thanks for the awesome repo 👍 @pawelborkar

[x]  My submission is formatted according to the guidelines in the contributing guide
[x]  My addition is ordered alphabetically
[x]  My submission has a useful description
[x]  The description does not end with punctuation
[x]  Each table column is padded with one space on either side
[x]  I have searched the repository for any relevant issues or pull requests
[x]  Any category I am creating has the minimum requirement of 3 items
[x]  All changes have been squashed into a single commit

thanks for the awesome repo 👍 @pawelborkar

My pleasure 😊

Hi I’m wondering is this my repo
Sent from Yahoo Mail for iPhone
On Saturday, August 21, 2021, 3:44 AM, Pawel Borkar @.***> wrote:
thanks for the awesome repo 👍 @pawelborkar
My pleasure 😊
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I am xan187 and my Account is stolen. They will use my email and switch back soon
Sent from Yahoo Mail for iPhone
On Saturday, August 21, 2021, 3:44 AM, Pawel Borkar @.***> wrote:
thanks for the awesome repo 👍 @pawelborkar
My pleasure 😊
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@cameron187187
Stop spamming the PR section, Otherwise you'll be reported.


KomaMRI v0.7.4: Bug fixes and minor features

In this pull request I have changed some parts of the simulation method to be able to sample the magnetization in an RF Bloch. Also, I fixed bugs #162 #85 by modifying the TimeStepCalculation.jl get_variable_times. Finally, I added some extra features, as now you can plot the eddy currents and the MC2 of a sequence, and a new BlochDict method that showcases how you can generate custom outputs and create new simulation methods without the need of modifying the source code of KomaMRICore.
KomaCore -> 0.7.5
KomaPlots->0.7.5

Codecov Report

Merging #163 (86c4e47) into master (18491fb) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   48.91%   48.91%
=======================================
  Files          35       35
  Lines        2067     2067
=======================================
  Hits         1011     1011
  Misses       1056     1056

Flag
Coverage Δ

core
53.86% <0.00%> (ø)

komamri
0.88% <0.00%> (ø)

plots
59.93% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Cannot read property 'indexOf' of undefined - Universal&angular5

Error with Angular Universal and angular 5.2.11.
When I run "run serve: ssr" and I go to the browser this error appears
Current behavior
ERROR { Error: Uncaught (in promise): TypeError: Cannot read property 'indexOf' of undefined
TypeError: Cannot read property 'indexOf' of undefined
at TranslateService.getBrowserLang (project/dist/server.js:37892:25)
at ManualParserLoader.LocalizeParser._getBrowserLang (/project/dist/server.js:53678:55)
at ManualParserLoader.LocalizeParser.init (/project/dist/server.js:53502:32)
at /project/dist/server.js:53825:19
Environment

//package.json scripts
"scripts": {
    "ng": "ng",
    "build": "ng build --prod",
    "start": "ng serve",
    "test": "ng test",
    "lint": "tslint ./src/**/*.ts -t verbose",
    "e2e": "ng e2e",
    "extract": "ng xi18n --outputPath=src/locale",
    "build:ssr": "npm run build:client-and-server-bundles && npm run webpack:server",
    "serve:ssr": "node dist/server.js",
    "build:client-and-server-bundles": "ng build --prod && ng build --prod --app 1 --output-hashing=false",
    "webpack:server": "webpack --config webpack.config.js --progress --colors"
}

ngx-translate version: 8.0.0
Angular version: 5.2.11

For Tooling issues:
- Node version: 8.11.3
- Platform:  Mac

1+

+1

Hi guys,
Try this in your server.js.
The getBrowserLang is getting from window.navigator.language which is not available at server side. Just define some value for it ;)
const domino = require('domino');
const fs = require('fs');

const template = fs.readFileSync(path.join(__dirname, '../dist/browser/index.html')).toString();
const win = domino.createWindow(template);
win.navigator.language='en';
global['window'] = win;
global['document'] = win.document;

I have the same proyect, and after this modification on my server.ts file:

const domino = require('domino');
const fs = require('fs');
const path = require('path');
const template = fs.readFileSync(path.join(__dirname, '.', 'dist', 'index.html')).toString();
const win = domino.createWindow(template);
const files = fs.readdirSync(${process.cwd()}/dist-server);
global['window'] = win;
Object.defineProperty(win.document.body.style, 'transform', {
value: () => {
return {
enumerable: true,
configurable: true
};
},
});
global['document'] = win.document;
global['CSS'] = null;
global['XMLHttpRequest'] = require('xmlhttprequest').XMLHttpRequest;
global['Prism'] = null;
win.navigator.language='en';
I received this error after execute npm run generate:prerender:

node prerender.js

ERROR TypeError: Cannot read property 'indexOf' of undefined
at TranslateService.getBrowserLang (webpack:///./node_modules/@ngx-translate/core/fesm5/ngx-translate-core.js?:886:25)
at new eval (webpack:///./dist-server/main.2354f112b15d37acff04.js?:1:298972)
at createClass (webpack:///./node_modules/@angular/core/fesm5/core.js?:9598:20)
at createDirectiveInstance (webpack:///./node_modules/@angular/core/fesm5/core.js?:9483:20)
at createViewNodes (webpack:///./node_modules/@angular/core/fesm5/core.js?:10703:36)
at createRootView (webpack:///./node_modules/@angular/core/fesm5/core.js?:10617:5)
at Object.createProdRootView [as createRootView] (webpack:///./node_modules/@angular/core/fesm5/core.js?:11129:12)
at ComponentFactory_.create (webpack:///./node_modules/@angular/core/fesm5/core.js?:8963:29)
at ComponentFactoryBoundToModule.create (webpack:///./node_modules/@angular/core/fesm5/core.js?:3612:29)
at ApplicationRef.bootstrap (webpack:///./node_modules/@angular/core/fesm5/core.js?:4847:40)
Unhandled Promise rejection: Cannot read property 'indexOf' of undefined ; Zone:  ; Task: Promise.then ; Value: TypeError: Cannot read property 'indexOf' of undefined
at TranslateService.getBrowserLang (webpack:///./node_modules/@ngx-translate/core/fesm5/ngx-translate-core.js?:886:25)
at new eval (webpack:///./dist-server/main.2354f112b15d37acff04.js?:1:298972)
at createClass (webpack:///./node_modules/@angular/core/fesm5/core.js?:9598:20)
at createDirectiveInstance (webpack:///./node_modules/@angular/core/fesm5/core.js?:9483:20)
at createViewNodes (webpack:///./node_modules/@angular/core/fesm5/core.js?:10703:36)
at createRootView (webpack:///./node_modules/@angular/core/fesm5/core.js?:10617:5)
at Object.createProdRootView [as createRootView] (webpack:///./node_modules/@angular/core/fesm5/core.js?:11129:12)
at ComponentFactory_.create (webpack:///./node_modules/@angular/core/fesm5/core.js?:8963:29)
at ComponentFactoryBoundToModule.create (webpack:///./node_modules/@angular/core/fesm5/core.js?:3612:29)
at ApplicationRef.bootstrap (webpack:///./node_modules/@angular/core/fesm5/core.js?:4847:40) TypeError: Cannot read property 'indexOf' of undefined
at TranslateService.getBrowserLang (webpack:///./node_modules/@ngx-translate/core/fesm5/ngx-translate-core.js?:886:25)
at new eval (webpack:///./dist-server/main.2354f112b15d37acff04.js?:1:298972)
at createClass (webpack:///./node_modules/@angular/core/fesm5/core.js?:9598:20)
at createDirectiveInstance (webpack:///./node_modules/@angular/core/fesm5/core.js?:9483:20)
at createViewNodes (webpack:///./node_modules/@angular/core/fesm5/core.js?:10703:36)
at createRootView (webpack:///./node_modules/@angular/core/fesm5/core.js?:10617:5)
at Object.createProdRootView [as createRootView] (webpack:///./node_modules/@angular/core/fesm5/core.js?:11129:12)
at ComponentFactory_.create (webpack:///./node_modules/@angular/core/fesm5/core.js?:8963:29)
at ComponentFactoryBoundToModule.create (webpack:///./node_modules/@angular/core/fesm5/core.js?:3612:29)
at ApplicationRef.bootstrap (webpack:///./node_modules/@angular/core/fesm5/core.js?:4847:40)
could anyone hepls me???
Thanks in advance.

Hi @mgutbor you are supposed to put the win.navigator.language before you declare the global window variable.
win.navigator.language='en';
global['window'] = win;

Hi guys,
global['window'] = win;
solve that issue but.. I'm receiving:
ERROR [Error]
Any ideas what can be happening here?

@BruneXX  post full error or screenshot

Hi @Ilyoskhuja that's the only I've got from node console ERROR [Error]

Hi, @BruneXX . Recently I fixed error with "Cannot read property 'indexOf' of undefined " and I have also get another error like this

"Error: renderModuleFactory requires the use of BrowserModule.withServerTransition() to ensure
the server-rendered app can be properly bootstrapped into a client app." ,  and found solution from here
https://github.com/angular/angular-cli/issues/8384
I added to my app module this solution
import { BrowserModule } from '@angular/platform-browser';
...
imports: [
BrowserModule.withServerTransition({
appId: 'ng-universal-demystified'
})...
]
and now everything working

Thanks @Ilyoskhuja
But unfortunately that is not related to my error, that you've added:
BrowserModule.withServerTransition is to transition from the server to browser app, AFAIK that must be added for any universal app.
Regards


Update Puppet Providers : wechat

This PR updates Puppet Providers : wechat in References.
References #890

Here some issues that were striked out I have removed them as they were not fixed.

This is great, but could you replace the code snippet in the usage section with #1098 after it is merged?

Sure, I can do that.

This is great, but could you replace the code snippet in the usage section with #1098 after it is merged?

@proudofsimin #1098 has not been merged yet. We could merge this PR now and I can update it when #1098 gets merged.

ping for review @proudofsimin


Tigran about me page review 12/10

Team
README quality, release day policies, Scrum Board to week after break
1.0
.75
.5
0
Justification:
Deployed Web Site
1.0
.75
.5
0
Justification:
Individual
About Page must Extend from Layout and have special customization (color pallet, background, etc)
1.0
.75
.5
0
Justification:
Picture with Mask that toggles to Picture of Choice (ie pic without mask)
1.0
.75
.5
0
Justification:
Pull or show data (Web API) with information of interest
1.0
.75
.5
0
Justification:
Establish link(s) to journal and other key indicators of your work and progress (remember pop quiz). TPT Link to Create Task planning
1.0
.75
.5
0
Justification:
Create Task plan
1.0
.75
.5
0
Justification:
2.3 Extracting Information from Data, 2.4 Using Programs with Data
1.0
.75
.5
0
Justification:


Bug: markdown that has code comments with a tree file isn't rendering well

I think it just might be missing the new line (\r\n) sorta thing to render it well:

Per @estruyf's suggestion I added the bash code style and now it renders well:

I think we can probably close unless anyone has a good idea how to handle differently :)

There is already a fix on its way for this 😄 - if you don't define the code type, it will use the default code element without syntax highlighting.

Should be fixed in the 0.0.11 version, which is currently building/publishing.

Nice, thank you!


fix(icons): Rename send-horizonal to send-horizontal

There seems to be an unintended typo in horizontal misspelled as horizonal.
As this PR is similar to https://github.com/lucide-icons/lucide/issues/533, I renamed the files as before. Hope that's enough.
Thanks for a great set of icons!

You need to put "aliases": ["send-horizonal"], to the .json for backwards compatibility.

Great work guys, thanks for the PR & review.


Please remove package-lock.json and .gitignore both it and yarn.lock

Please remove package-lock.json and .gitignore both it and yarn.lock

Done.

You're missing some things here.  There is no destroy() {} function.  You need to close and delete the ws in said function.  Also, you'll want something like this in your initWebSocket() {}:
if (this.ws !== undefined) {
    this.ws.close; // or equivalent in ws (I didn't research)
    delete this.ws
}

I wonder whether I should add some kind of reconnect timer. Do you have any recommendations? Should it be hard-coded or user configurable?


Shuffled Frog Leaping Algorithm Python and C++ code

🛠 Issue (Number)
#1484

Issue no #1484
👨💻 Changes proposed

Added Python and C++ codes
✔ Check List (Check all the applicable boxes)

[✔] My code follows the code style of this project.
[✔] This PR does not contain plagiarized content.
[✔] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

#SSOC23


Undefined

Worked perfectly for a few hours, tried it again to test some things and it only shows "undefined" in console every time i try to translate something, is it my problem or the API's problem?

ok now it works again, probably because of google limit quota?

Yes, you are right, Google has limitation for this way of usage for its translate service.
For commercial usage, suggest to pay for a translation service.


sequencer: reduce maximum block size to 4MiB

Summary
Set genesis params to match new upstream values.
Background
21MiB was the old default set by upstream, 4MiB is the new, safer default after discovering the p2p storms issue. See:
https://github.com/cometbft/cometbft/pull/1518
https://github.com/cometbft/cometbft/security/advisories/GHSA-hq58-p9mv-338c
https://github.com/notional-labs/placid
Changes

Reduce maximum block size from 21MiB to 4MiB.
Reduce gas limit from limitless to 10 million.

Testing
Launch a new testnet with the new genesis.json?

We already had updates in flight for what works for Astria: https://github.com/astriaorg/astria/pull/1193


feat: add global search

Overview:
This PR introduces a new feature aimed at enhancing the search capabilities. The primary focus is on enabling users to perform searches using regular expressions (RegExp) across multiple fields
Changes Made:

Added a function to parse search queries using regular expressions across specified fields.
Modified the existing parsing logic to accommodate the new search functionality seamlessly.
Introduced MongoQueryOptions interface to provide users with the flexibility to specify search parameters, including the search key and paths for searching.

Key Additions:

MongoQueryOptions Interface: Introduced MongoQueryOptions interface to define search parameters, allowing users to specify the search key and paths for searching.
getSearch Function: Implemented a new function getSearch to parse search queries using regular expressions across specified fields. This function enhances the search capability of the library by enabling global searches across multiple fields.

Result
Users can now pass options to MongoQuery decorator (useful for further options like default limit or sort)
findAll( MongoQuery({ search: { key: 'q', paths: ['name', 'description'] } }) query: MongoQueryModel)

Request
http://localhost:3000/resources?q=John
Query
{
  "limit": 30,
  "skip": 0,
  "select": {},
  "sort": {},
  "populate": [],
  "filter": {
    "$or": [
      {
        "name": {
          "$regex": "John",
          "$options": "i"
        }
      },
      {
        "description": {
          "$regex": "John",
          "$options": "i"
        }
      }
    ]
  }
}

Impact and Benefits:

Enhanced Search Capability: Users can now perform more sophisticated searches using regular expressions across multiple fields, improving the overall search experience.
Improved Flexibility: The addition of the MongoQueryOptions interface provides users with greater control over search parameters, enhancing the flexibility of the library.
Better Usability: With enhanced search capabilities, developers can build applications with more robust search functionality, leading to better usability and user experience.

@cicciodifranco nice feature, man. I will release it now!

@cicciodifranco I had an issue when generating the library package due to an error generated by TypeScript when creating a ParameterDecorator, as MongoQueryOptions cannot be nullable:
TS2322: Type '(...dataOrPipes: (MongoQueryOptions | PipeTransform<any, any> | Type<PipeTransform<any, any>>)[]) => ParameterDecorator' is not assignable to type '(opts?: MongoQueryOptions | undefined) => ParameterDecorator'.   Types of parameters 'dataOrPipes' and 'opts' are incompatible.     Type 'MongoQueryOptions | undefined' is not assignable to type 'MongoQueryOptions | PipeTransform<any, any> | Type<PipeTransform<any, any>>'.       Type 'undefined' is not assignable to type 'MongoQueryOptions | PipeTransform<any, any> | Type<PipeTransform<any, any>>'.

Because of this, I will create and expose a method called MongoQueryOpts, which performs the same operations as MongoQuery, but with the possibility of having search options, as defined in your feature.
If there are questions or new suggestions for implementing this feature, please open a new Pull Request or an Issue, so that I can adjust it.
Thanks for the contribution!

a possible solution could be
export const MongoQuery: (data?: MongoQueryOptions | undefined) => ParameterDecorator =
    createParamDecorator(
        (
          data: MongoQueryOptions | undefined,
          ctx: ExecutionContext,
        ): MongoQueryModel => {
          const query = ctx.getArgByIndex(0).query;
          return parse(query, data);
        },
    );

btw I will open a new pr for that

@cicciodifranco bruh, I didn't considerate this solution 🤦🏻 . No new pr needed, I will fix this now. Thanks!


Fire turbo:click event when submitting <form method="get">

Prior to this change, navigating a page via an <a> element and
navigating a page via a <form method="get"> element both resulted in
turbo:visit events.
However, clicking an <a> fired a turbo:click event, whereas
submitting a <form method="get"> by clicking its <input type="submit"> or <button> element did not fire the click for the
submitter.
This commit adds support for firing turbo:click events for a
<form method="get"> element's submitter.

I wouldn't expect a form submission, even if its a GET method, to trigger turbo:click, when other form submissions do not. What gave rise to wanting this?

It is an odd duck, but making get-forms fire turbo:click doesn't quite make sense to me. I get that they under the good are actually more like links than forms, but that's not how a user would think of it. If anything, it should fire more of the same like post-forms. But I also think that maybe it's just fine as it is? It is a bit of a hybrid, so imo OK that it has a different event stack.

The more I think about it, the more I think what's proposed in #424 is more viable.
I'm closing this in favor of https://github.com/hotwired/turbo/pull/424.


Missing comma

In the section below, a comma is missing.
Current
Can I use custom VM extensions?
No AKS is a managed service, and manipulation of the IaaS resources is not supported. To install custom components, etc. please leverage the Kubernetes APIs and mechanisms. For example, leverage DaemonSets to install required components.
Proposed
Can I use custom VM extensions?
No, AKS is a managed service, and manipulation of the IaaS resources is not supported. To install custom components, etc. please leverage the Kubernetes APIs and mechanisms. For example, leverage DaemonSets to install required components.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d501ff67-9208-8bcb-e8df-f09e9b16a802
Version Independent ID: e3fc3851-ddc4-d26c-251d-6ae53d714081
Content: Frequently asked questions for Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/faq.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@smith1511 Thanks for the feedback! We are taking a look into this and will get back to you soon.
@mlearned FYI!

Thanks for bringing this to our attention. I have created a PR with the update, changes will be live shortly.
Thanks for improving our documentation! Just so you know, it's also possible to make these changes yourself, if you are interested. Doing so will improve our documentation, and it will add you as a contributor to the document.
In case you're interested, these are the steps to do so:

Navigate to the page of interest
Select the "Edit" button at the top right of the page
Select the "Pencil" icon on the right
Modify the text within the text box in markdown format - more info: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
Name your file change and provide a description, if necessary
Select "Propose file change"
Select "Create pull request" on the 'Comparing changes' page
Select "Create pull request" on the 'Open a pull request' page
You can find a GIF that demonstrates the end-to-end process for submitting changes here: https://aka.ms/editsqldocs.


fix: add support for jx-values.yaml create in destroy

to fix gc failures
needed a minor tweak to get the unit tests passing.
not sure why lighthouse merged when the tests were failing

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Use typedef to define the type of GlobalWorkerOptions (PR 12102 follow-up)

Use typedef to define the type of GlobalWorkerOptions.
It would be much better to write explicitly in JSDoc that the type of GlobalWorkerOptions.workerPort  is Worker.

I have edited as requested.

/botio-linux preview

Looks good!


Move forwarder extension methods

Fixes https://github.com/microsoft/reverse-proxy/issues/1172

Thanks!


Add test cases for model

100% test coverage for models.
CheckstyleMain and checkstyleTest passed.
Two todos added to solve the issue of the same DateTime checks for logs.

100% test coverage for models.
CheckstyleMain and checkstyleTest passed.
Two todos added to solve the issue of the same DateTime checks for logs in Sampleutil.java.

There are some merge conflicts to be resolved here.


Communication-chat Readme issue

Section Link:

Suggestion:
For 1: Change to [Chat Thread Operations](#chat-thread-operations)
For 2: Change to [Chat Message Operations](#chat-message-operations)
For 3: Change to [Chat Thread Member Operations](#chat-thread-member-operations)
@jongio , for notification

Updated and fixed, thanks for spotting this @Melanie-Ma


Docs: update portfolio and about us

Coverage remained the same at 85.72% when pulling 6c0f4b0fcf893b3308b2c87228fa9ed6c1a55240 on zhangshuoyang:theme_selection into beab6cebaadca7010fa7ddd4ea240dd70ef08673 on CS2103AUG2017-W11-B1:master.


[AutoPR monitor/resource-manager] Support azureFunctionReceivers in actionGroup APIs

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2659

(message created by the CI based on PR content)


UIPOLICIES-14: Add tenantId and affiliationSelectionComponent props to support Authorization Policies in Consortium settings

Purpose

https://folio-org.atlassian.net/browse/UIPOLICIES-14
Approach

Consortium managers need to manage system policies at a high level, they need the ability to efficiently manage the creating and updating of policies for and on behalf of members of the system. Inorder to filter policies by tenants it requires to add tenenat selection component affiliationSelectionComponent and currently selected tenantId
Screenshots

https://github.com/user-attachments/assets/cb86bccf-6c7e-4cbe-946e-101982ab3e9b

Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.

[x] I've added appropriate record to the CHANGELOG.md
Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Could you please explain why the changes are being made in the ui-authorization-policies module, not in ui-consortia-settings, if the consortium manager requires the support of cross-tenant auth policies?

Could you please explain why the changes are being made in the ui-authorization-policies module, not in ui-consortia-settings, if the consortium manager requires the support of cross-tenant auth policies?

Sorry to forget to mention. Here is the supporting PR, I have just created https://github.com/folio-org/ui-consortia-settings/pull/137

@usavkov-epam updated

As we discussed with our team the reusable components should be moved stripes-authorization-components and imported from the repo stripes-authorization-components

LGTM


Trackback Error misc.py

Hi,
i use ST3 and a fresh installed version of your package. This is the error message i receive in the console:
Traceback (most recent call last):
  File "/home/user/.config/sublime-text-3/Installed Packages/NimLime.sublime-package/utils/misc.py", line 103, in loop_status_generator
  File "NimCheck in /home/user/.config/sublime-text-3/Installed Packages/NimLime.sublime-package", line 115, in run
  File "/home/user/.config/sublime-text-3/Installed Packages/NimLime.sublime-package/utils/misc.py", line 316, in write_to_output
  File "/home/user/.config/sublime-text-3/Installed Packages/NimLime.sublime-package/utils/misc.py", line 132, in get_output_view
  File "/home/user/.config/sublime-text-3/Installed Packages/NimLime.sublime-package/utils/misc.py", line 182, in show_view
TypeError: Can't convert 'NoneType' object to str implicitly

How can I fix this?
Thanks in advance,
pyloor

Are you running any specific command or action when you get this error?

Ok, I think I've fixed this. Please give any feedback about the console output mode - I'm debating on whether to keep, as it's a bit complicated to maintain.


Added a persistable version of LocalVectorStoreDriver. Added tests fo…

Implemented a persistable child class of LocalVectorStoreDriver that uses pickle to save the internal entries dict.
Added test for the serialization and deserialisation of the new class.

I guess it was just a bad habit. I’ll modify it to use json, and will add an optional argument to save it as zipped json.

I addressed the comments. Not sure why the Quality / lint job complains e.g.
with open(...) as f:
    ....

is pretty idiomatic python . " Variable name "f" doesn't conform to snake_case naming style" might be overkill.
I can change these things i.e. "f->file", but I am not sure it increases readability.

Thanks for adding the changes! Will review tomorrow. Don't worry about squashing—I squash all commits on merge.

Hi @tarbaig we are going to close this PR for now in favor of an implementation that will come through this issue. If you have any interest in working on the other issue, we'd be happy to assist. Thank you!


Separate paths per box

Problem
Hive uses the path of Hive.init(path) globally. This makes it difficult for SDKs to use hive because it doesn't allow to write in a special "sdk" folder when the implementer also uses hive.
On Android exists a special cache folder. I'd like to write some boxes there, and other in a different folder. This isn't possible right now.
Solution
Allow opening boxes with a path.
Hive.openBox(path: absolutePath);

Thanks for this idea. I completely agree and will implement this with the next version.

This is now possible with v1.2.0 using Hive.openBox(path: "some/path").


Fix broken link in the i18n_contribution

Changes:
Fix link in the i18n_contribution.md file index.

Thanks!

I was going through the guidelines because I was thinking of proposing to
add the Italian translation as part of my GsoC project proposal.
Do you think this could be a useful/interesting project?
(I already posted this question on the Processing Foundation forum but I
didn't get an answer yet and I don't know who to ask to for this)
https://discourse.processing.org/t/introduction-and-adding-italian-as-new-language/18370
Il giorno mer 4 mar 2020 alle ore 11:57 Kenneth Lim <
<EMAIL_ADDRESS>ha scritto:

Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/processing/p5.js-website/pull/573?email_source=notifications&email_token=ALXC2VFO6MTTXSC3M7QDNRLRFYXZTA5CNFSM4LAWH5N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENXKUJY#issuecomment-594455079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXC2VE6QLSFWO3WRYI4JWLRFYXZTANCNFSM4LAWH5NQ
.

I can't say for sure about any decisions relating to GSoC as I'm not involved in that process. However one point about translating p5.js is the long term sustainability of the project, adding a new translation means future efforts that needs to go into regularly updating the translation when the original website changed. It should be something to plan for as part of your proposal.

I see, thanks for the advice!


How to cancel a stream from an external function?

Can you elaborate?
https://github.com/lucgagan/completions#cancelling-responses
Cancelling is generally very simple:
import { createChat, CancelledCompletionError } from "completions";

const chat = createChat({
  apiKey: OPENAI_API_KEY,
  model: "gpt-3.5-turbo",
});

try {
  await chat.sendMessage("continue sequence: a b c", ({ cancel }) => {
    cancel();
  });
} catch (error) {
  if (error instanceof CancelledCompletion) {
    console.log("cancelled");
  }

  throw error;
}

Yes, I have seen that.
For example, I just want to stop streaming with a click on a button or any other external condition.
For now, it is possible only within the callback.
I think the best solution will look like chat.stopStream()


Private attributes

Currently there is no way to pass attributes to (server rendered) components that won't be serialized and passed to the client.
I think there should be a way to pass attributes to server rendered components that will be stripped from the element before being passed to the client.
<server-component #user-id="${this.currentUser}"></server-component>
We could use the `#' as the symbol for private attributes, just like it is the symbol for private class properties in javascript.
A advantage of this approach would be, if we are passing a lot of (rich) text, or maybe an object which is used to render static children, to a component, it won't be rendered inside the attributes and inside the component.

@quarkus @eddyloewen What is your opinion about this feature?

I'm not sure if I understand correctly.
Is this an "attributes" vs. "properties" thing? Then I would rather suggest something like https://lit.dev/docs/templates/expressions/#property-expressions with the "." notation. With that it is clear that attributes are serialized and sent to the client but properties are only set internally and not serialized.
If not - I don't think that "private" is the right mental model for this. Isn't this again a question of the target? Like "server" vs. "client"? Although the "#" doesn't have to mean "private" - if documented correctly it can also mean "server only".
But I would still prefer the "." notation.

@lukas-schardt I think I know now what you mean by "private". What you're reffering to is the reflection of properties to attributes correct? There is logic for this in element-js for example. We do reflect everything that was initially set as attributes or anything that was set to reflect from the property options.
Luna could respect that and look into the element configuration in order to determin whether it should add attributes or not. This should probably also be a mehtod in the Element Renderer factory.


Use system Qt

Is there a way to specify the system Qt to the pre_build.py script? I'd expect --qt-root=/usr or --qt-root=/usr/lib64/qt5 to work

Hi FireBurn,
Thanks for your feedback. This is something we haven't given much thought to, but it can probably be done by mimicking the directory structure required by the current build system and using some creative symbolic links.
As of this writing, the current version of Qt installed with Ubuntu 22.04 LTS is 5.15.3. Build the directory structure and make symbolic links to the system Qt lib and include files:
mkdir -p ~/Qt/Qt5.15.3/5.15.3/gcc_64
sudo ln -s /usr/lib/x86_64-linux-gnu ~/Qt/Qt5.15.3/5.15.3/gcc_64/lib
sudo ln -s /usr/lib/x86_64-linux-gnu/qt5 ~/Qt/Qt5.15.3/5.15.3/gcc_64/include

Comment out the lines that do the chrpath in the file 'source/frontend/CMakelists.txt'. This isn't needed since the system Qt files are being used.
   # Call chrpath on system to override executable file RPATH.
    #find_program(CHRPATH_EXECUTABLE NAMES chrpath)
    #    add_custom_command(TARGET ${PROJECT_NAME} POST_BUILD
    #    COMMAND ${CMAKE_COMMAND} -E echo "trying chrpath"
    #    COMMAND ${CHRPATH_EXECUTABLE} -r "\\$$ORIGIN/lib" $<TARGET_FILE:${PROJECT_NAME}>
    #)

Change the file 'source/renderer/public/renderer_types.h' so the line that reads:
include <QtGui/5.15.2/QtGui/qpa/qplatformnativeinterface.h>
uses the new qt folder:
include <QtGui/5.15.3/QtGui/qpa/qplatformnativeinterface.h>
Some additional Qt components may be required, so install those:
sudo apt-get install qtbase5-dev
sudo apt-get install qtbase5-dev-tools
sudo apt-get install libqt5svg5-dev
sudo apt-get install libqt5x11extras5
sudo apt-get install qtbase5-private-dev

to build, use:
python3 pre_build.py --qt 5.15.3 --build --disable-extra-qt-lib-deploy
I hope this is useful,
Thanks!
Tony.

This functionality has now been added to RRA 1.3, so closing this issue


We should move the discussion of the semantics protocol from rendering/README.md to dartdocs

I did this a year ago. Closing.


[WIP] HTTP listing details

What is the purpose of this change?

Serve static files with the ?rclone=static URL param
Implemented a slightly richer GUI:

The ability to navigate "up" a directory
Show file sizes and modification times

Was the change discussed in an issue or in the forum before?
Yes, this is an ongoing thing: https://forum.rclone.org/t/prototype-for-a-nicer-built-in-web-gui/7443/17
Checklist

[ ] I have read the contribution guidelines.
[ ] I have added tests for all changes in this PR if appropriate.
[ ] I have added documentation for the changes if appropriate.
[ ] All commit messages are in house style.
[ ] I'm done, this Pull Request is ready for review :-)

Where are you at this with pull request @poundifdef  ? Do you want to continue with it?

@ncw Hello! I will close this PR. I have had many life changes (for the good! recently married!) in the past 7 months and that has completely drained my time.
I would like to continue pursuing this (and have a little GUI that I use locally with rclone rcd) but I will close this for now as to reduce clutter.
If you are already working on something, I'm happy to take a look and test as well!

I will close this PR. I have had many life changes (for the good! recently married!) in the past 7 months and that has completely drained my time.

Congratulations!

I would like to continue pursuing this (and have a little GUI that I use locally with rclone rcd) but I will close this for now as to reduce clutter.

If you'd like to resubmit at some point when you have time that would be great!

If you are already working on something, I'm happy to take a look and test as well!

I've got a google summer of code student working on a react gui for rclone - we are almost ready for beta testing - I'll post in the forum when it is ready!


Fix Docs Repo refrence in Readme

Sigstore docs have been moved to their own repo. This branch docs has be sunset so refrence to it should be updated on Readme ✅

/assign hrittikhere


Fix bug in jerry_string_to_char_buffer.

Str_len can smaller than buffer_size.
  if (ecma_string_get_size (str_p) > buffer_size)
  {
    return 0;
  }

It should be ">" in the comparison.
And also change the related code in unit-test-api.c.
Before, in the foreach, it only sunk into
  if (sz == 0)
  {
    JERRY_ASSERT (!strncmp ((const char *) user_data, "user_data", 9));
    return true;
  }

JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang<EMAIL_ADDRESS>

LGTM

LGTM

@jiangzidong, please rebase to the current master, so we can land it properly.


pytorch_lightning.utilities.exceptions.MisconfigurationException: The provided lr scheduler OneCycleLR doesn't follow PyTorch's LRScheduler API. You should override the LightningModule.lr_scheduler_step hook with your own logic if you are using a custom LR scheduler.

First, thanks for the code you have pubulished.
When I run the command to train the model, I first got the error with "ValueError: not available number labels, select from:
200, 200" and "
hydra.errors.HydraException: Error calling 'datasets.semseg.SemanticSegmentationDataset' : not available number labels, select from:
200, 200".
So, I have changed the "num_labels=20" to "num_labels=200" in the config file  "Mask3D\conf\data\indoor.yaml".
However, I got another error with "pytorch_lightning.utilities.exceptions.MisconfigurationException: The provided lr scheduler OneCycleLR doesn't follow PyTorch's LRScheduler API. You should override the LightningModule.lr_scheduler_step hook with your own logic if you are using a custom LR scheduler."
This error that I can't solve, may get help from you, thank you very much, hope to get your reply.

@JonasSchult

Hi! :)
Thanks for your interest in our work!
we have just released a fix which most likely will solve your issue. Just pull the latest version of the project and recreate your virtual python environment following the instructions here.
Previously, the issue occurred because we did not lock the packages in the Python environment to specific versions. We now made sure that the packages in the environment remain the same.
I will close the issue now. Please feel free to reopen it again if you continue to experience issues.
Best,
Jonas

Thanks for your reply, best wish for you!
Jonas Schult @.***> 于2023年5月31日周三 19:17写道：

Closed #93 https://github.com/JonasSchult/Mask3D/issues/93 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/JonasSchult/Mask3D/issues/93#event-9388965616, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AN332LADDDROQTKUIZYZDPTXI4SEVANCNFSM6AAAAAAYVHSINU
.
You are receiving this because you authored the thread.Message ID:
@.***>


ClusterIP and NodePort service IPSet entries added

This PR contains following code changes
a) ClusterIP , NodePort related IPSet are added.
KUBE-LOOP-BACK
KUBE-6-LOOP-BACK
KUBE-CLUSTER-IP
KUBE-6-CLUSTER-IP
KUBE-NODE-PORT-TCP
KUBE-6-NODE-PORT-TCP
KUBE-NODE-PORT-UDP
KUBE-6-NODE-PORT-UDP
Other IPSets will be added in subsequent review
b) Dual stack handling for service and endpoints

/lgtm
/approve


1.10.0 External Storage does not allow access to inventories without redstone ticks

The block will not count the attached inventory as part of the storage network without a redstone update. This can be accomplished either by providing a redstone signal or by changing the redstone behavior in the GUI. Otherwise the RS inventory will not show new or removed items from the external inventory accesssed by the External Storage

To what is the external storage connected?

Sorry I've been doing some troubleshooting with this issue and I've updated my original post. I did test with vanilla chests and a variety of mod storage including iron chests.

May I ask which version you are running? Are you on the latest version?

Actually I'm so sorry this is on version 0.8.5, which is clearly not the latest. This pack is supposed to be bleeding edge so I didn't look for an update. If this bug has since been resolved accept my apologies.

This bug has since been resolved indeed


Feature: Rest log streaming

Closes #601
Changes

Response message in proto definition changed for GetLog, to return raw bytes with content type "text/plain"
Buffered writer implementation updated to work with different interface for updating and accessing logs.

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
action required: The gRPC and REST response for GetLog API changed. Refer to the REST API Specs doc.

/test pull-tekton-results-integration-tests

/approve Tested, it works as expected. Tested on very large log files too (~100k lines)
Click here to see tests
Few questions:

should the tkn-results update be included in this PR?
Docs for handling large logs be updated/deleted?

I don't think tkn-results will need any change. I'll check and update in this PR if required.
The document for handling large logs will not be relevant anymore, I can delete it as a part of this PR.

/approve Tested, it works as expected. Tested on very large log files too (~100k lines)
Click here to see tests
Few questions:

should the tkn-results update be included in this PR?
Docs for handling large logs be updated/deleted?

Removed doc "handling large logs"


Added Sapienza University of Rome

Added Sapienza University of Rome

@G1AC0B I am sorry, the domain studenti.uniroma1.it is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Create torque widget only if layer has hasAnimationStyle attribute.

This PR is related to https://github.com/CartoDB/cartodb/issues/12571, solving the pertinent code in DI side.

Looks good! 👍


Detect headers from globals, extra header from not response object

Detect headers from globals, extra header from not response object

[? ] Are you fixing a bug?

[ ] Detail how the bug is invoked currently.

ob_get_level();
header('some-header: from global, not api response object');
ob_get_clean();
All headers from global will be send to client without response object.

[ ] Detail the new, expected behavior.
If some headers sent without response object emitter throw exception.

Need extra test for it. Phpunit already sent headers.

I don't quite understand what you're trying to accomplish here from your description. A unit test could likely help make that more clear - I see you've indicated you need an extra test for it already. As such, I'm marking this as a "work in progress"; drop a note when you feel it's ready.

I added gist with example - https://gist.github.com/alexpts/fbacb2364b4190a244a22528d2c17c17
I don`t know how i can test it via phpunit.

This is expected behavior.
The emitter only emits what it knows about in the response provided to it. We specifically ignore anything emitted using header() or http_response_code(), as these interact directly with the SAPI (either via the output buffer, or the SAPI-specific methods for emitting the headers and response code). As such, there's no way for the $response to know about header-2 unless you were to specifically inject it yourself.
The whole point of this library is to provide a way to handle incoming requests and provide a response outside of the SAPI. Doing so allows using alternate SAPIs than php-fpm or Apache's mod_php — e.g., Swoole, ReactPHP, AMP, unit testing, etc.
The output buffer and the various header*() methods in PHP have a lot of edge cases we'd prefer not to work around or with, and we will not be adding code to interact with them.
If you are mixing usage of header() and other output-buffering, either (a) don't use this package, (b) rewrite the code to inject such content into the response, or (c) rewrite the code to omit usage of header() and output buffering (recommended solution).


Allow to configure information displayed on menu bar

Hello. Thank you for sharing app really enjoying using it.
Could you provide a way to configure menu bar displayed information since we already have it e.g. CAQI:  %caqi PM2.5: %pm25 %temp st. C we would get  CAQI: 60 PM2.5: 42ug/m3 4.5 st. C

PRs are welcome, but I will close this as stalled since there has been no activity since 2018.


Treeview - child nodes

I have problem with child nodes in treeview.
This is how I set dataSource - result is array, because example does not work good with Doctrine. IMO array is OK.
$grid->setDataSource($this->getResourcesTree($this->facade->getResources([], "priority")));
$grid->setTreeView([$this, 'getChildren'], 'has_children');

And functions for creating tree:
    private function getResourcesTree(array $resources, $parentId = null, $fromParent = null): array
    {
        $return = [];
        foreach ($resources as $resource) {
            if ($resource['parentId'] == $parentId) {
                $children = $this->getResourcesTree($resources, $resource['id']);
                if($children) {
                    $resource['children'] = $children;
                }
                $resource['has_children'] = isset($resource['children']) ? count($resource['children']) : 0;

                $return[$resource['id']] = $resource;
            }
        }
        if($fromParent) {
            $return = $this->getChildrenTree($return, (int)$fromParent);
        }

        return $return;
    }

    private function getChildrenTree(array $resources, int $fromParent, $firstLoop = true): array
    {
        foreach($resources as $value){
            if($value['id'] == $fromParent) {
                return $value['children'];
            }
            if(!$firstLoop && $value['parentId'] == $fromParent) {
                if(isset($value['children'])) {
                    return $value['children'];
                }
                else{
                    return $value;
                }
            }
            if(($value['has_children'] > 0) && !empty($value['children'])) {
                $children = $this->getChildrenTree($value['children'], $fromParent, false);
                if($children) {
                    return $children;
                }
            }
        }

        return [];
    }

And callback for nodes with children:
    public function getChildren($parentId): array
    {
        return $this->getResourcesTree($this->facade->getResources([], "priority"), null, $parentId);
    }

Now the problem, what's wrong.
When I open first level node (meaning from root to first level), every child nodes appear correctly. But, if this node has another children and I try to show them, page reload and all nodes are packed up.
And also - when I successfully opened first level from root, same issue is when i want to click edit on this child node.
Do you have any idea, what's wrong with my code, or is it some issue of this library?
Thanks a lot for any suggestions!

Hi, not sure, if it´s connected-but I have just found kind of strange behavior of Tree View.
I have Status switch on every line - in root level, everything works, if I open children level and use the status switch, it looses connection to Presenter (I have grid in ocmponent), it runs the "statusChange" callback, but in it, I can´t check working Ajax.
Calling $this->presenter->isAjax() returns false, while using status switch on root level, it returns true.
I have switchStatus method in baseGrid class (I have tons of grids and statusSwitch is always the same), but in few special cases, I´m overloading that general function, calling parent and adding some stuff after the base function and it won´t run that code as page redraws without ajax.
It kind of seems like your problem is the same - instead of Ajax opening, your page reloads and everything is packed again.
No idea tho...if problem is on our side, or on datagrid side. Could be easilly wrong implementation. Tree view demo on:
https://examples.contributte.org/datagrid-skeleton/tree-view/ doesn´t work at all

@MikKuba so, I´ve searched a bit more and found out updating Naja1 to Naja2 and adding this fix https://github.com/contributte/datagrid/pull/1035/files to datagrid.js fixes my issue with Ajax.

Hey @darkWolf-PR, I am not sure what you mean, can you open PR please?

@f3l1x  What you mean exactly? @MikKuba did not said which JS library is he using. I´ve found that the problem I´ve had with datagrid reloading whole page within TreeView instead of using ajax (which seems to be the same issue as he had) was connected to support of Naja 1 library (I had Naja 1.8.3) in Datagrid.
After checking other issues and pulls, I´ve found the one I´ve tried to link(and it doesn´t work for some reason?!?) that suggests similar problem with Naja2 and fix for that, so I had nothing to loose, switched to latest Naja and added suggested change to datagrid.js.
That fixed me the reloading problem. So I guess it´s something related to released datagrid version and used Naja 1 version. I have no idea what, because I do not understand this JS at all...
It still doesn´t work completely, it fails to redraw respected grid line after status switch.
Switching status in child node misses these two lines in ajax request(these are from root node status switch), no idea why:
_datagrid_redrawItem_class	""
_datagrid_redrawItem_id	7
Btw - that not working demo(tree view part) is already using the new version 7? As there is BS5 in assets. It´s impossible to open child rows there.

Oh, I see now. I will try to fix demo. :-)

@f3l1x it looks like treeView demo misses this
Which, btw, is really awesome code, probably from Dibi?, which I keep failing to recreate in NetteDatabase.