Thread 7: EXC_BAD_ACCESS (code=1, address=0x18) during file upload

Happens with flutter_uploader 1.2.0 (iOS)
The crash is not always reproducible. Looks like a concurrency issue to me. It's easier to catch on Simulator.
Dart code:
FlutterUploader().enqueue(
  url: url,
  files: fileItems,
  headers: headers,
);

Passed values:
headers = {_InternalLinkedHashMap} size = 1
 0 = {map entry} "File-Session" -> "1-2-3"

url = "https://www.somehost.com/upload?param=123"

fileItems = {_GrowableList} size = 1
 0 = {FileItem}
  savedDir = "/Users/reist/Library/Developer/CoreSimulator/Devices/CC8A4947-A263-453E-A154-8BE088D9C37C/data/Containers/Data/Application/F7FB2"
  filename = "412535EB-FD37-434B-A168-9662B058A46C.jpeg"
  fieldname = "files[]"

Stack trace:
#0	0x00007fff50b9378b in objc_msgSend ()
#1	0x000000010eca2d13 in Dictionary._Variant.setValue(_:forKey:) ()
#2	0x000000010ee98f8d in specialized Dictionary.subscript.setter ()
#3	0x000000010ec72792 in Dictionary.subscript.setter ()
#4	0x000000010960cf39 in SwiftFlutterUploaderPlugin.urlSession(_:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:) at /Users/reist/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_uploader-1.2.0/ios/Classes/SwiftFlutterUploaderPlugin.swift:617
#5	0x000000010960d315 in @objc SwiftFlutterUploaderPlugin.urlSession(_:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:) ()
#6	0x00007fff22f2dd89 in ___lldb_unnamed_symbol8580$$CFNetwork ()
#7	0x00007fff25732d61 in __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ ()
#8	0x00007fff25732c59 in -[NSBlockOperation main] ()
#9	0x00007fff25735be6 in __NSOPERATION_IS_INVOKING_MAIN__ ()
#10	0x00007fff25731e59 in -[NSOperation start] ()
#11	0x00007fff25736540 in __NSOPERATIONQUEUE_IS_STARTING_AN_OPERATION__ ()
#12	0x00007fff2573604a in __NSOQSchedule_f ()
#13	0x000000010f6cd3c9 in _dispatch_block_async_invoke2 ()
#14	0x000000010f6bed48 in _dispatch_client_callout ()
#15	0x000000010f6c16ba in _dispatch_continuation_pop ()
#16	0x000000010f6c0ac5 in _dispatch_async_redirect_invoke ()
#17	0x000000010f6d028c in _dispatch_root_queue_drain ()
#18	0x000000010f6d0b96 in _dispatch_worker_thread2 ()
#19	0x00007fff51c016d5 in _pthread_wqthread ()
#20	0x00007fff51c0157b in start_wqthread ()
Enqueued from com.apple.NSURLSession-work (Thread 35) Queue : com.apple.NSURLSession-work (serial)
#0	0x000000010f6c2c5d in dispatch_async ()
#1	0x00007fff25730010 in __NSOQSchedule ()
#2	0x00007fff25733e6c in __addOperations ()
#3	0x00007fff22f2a706 in ___lldb_unnamed_symbol8413$$CFNetwork ()
#4	0x000000010f6bddd4 in _dispatch_call_block_and_release ()
#5	0x000000010f6bed48 in _dispatch_client_callout ()
#6	0x000000010f6c55ef in _dispatch_lane_serial_drain ()
#7	0x000000010f6c61b5 in _dispatch_lane_invoke ()
#8	0x000000010f6d1a4e in _dispatch_workloop_worker_thread ()
#9	0x00007fff51c0171b in _pthread_wqthread ()
#10	0x00007fff51c0157b in start_wqthread ()
Enqueued from com.apple.NSXPCConnection.m-user.com.apple.nsurlsessiond (Thread 7) Queue : com.apple.NSXPCConnection.m-user.com.apple.nsurlsessiond (serial)
#0	0x000000010f6c2c5d in dispatch_async ()
#1	0x00007fff22e3bdbb in ___lldb_unnamed_symbol3257$$CFNetwork ()
#2	0x00007fff23c561cc in __invoking___ ()
#3	0x00007fff23c532df in -[NSInvocation invoke] ()
#4	0x00007fff258d756c in __NSXPCCONNECTION_IS_CALLING_OUT_TO_EXPORTED_OBJECT__ ()
#5	0x00007fff258d6068 in -[NSXPCConnection _decodeAndInvokeMessageWithEvent:flags:] ()
#6	0x00007fff258d78b8 in message_handler ()
#7	0x00007fff51c3debc in _xpc_connection_call_event_handler ()
#8	0x00007fff51c3e246 in _xpc_connection_mach_event ()
#9	0x000000010f6bede8 in _dispatch_client_callout4 ()
#10	0x000000010f6d8736 in _dispatch_mach_msg_invoke ()
#11	0x000000010f6c540e in _dispatch_lane_serial_drain ()
#12	0x000000010f6d95f1 in _dispatch_mach_invoke ()
#13	0x000000010f6c540e in _dispatch_lane_serial_drain ()
#14	0x000000010f6c61b5 in _dispatch_lane_invoke ()
#15	0x000000010f6d1a4e in _dispatch_workloop_worker_thread ()
#16	0x00007fff51c0171b in _pthread_wqthread ()
#17	0x00007fff51c0157b in start_wqthread ()

@ragnor-rs did you hear any updates on this issue? I'm seeing similar crashes at my end.

@ahujamanish not really

Please try the latest version 2.0.0-beta.5 - which includes a fix for this problem.


Fabric / Quilt??

Fabric / Quilt??
1.19.2 - 1.19.3

i would answer but i dont even know hot to download it

also its nforge

also do you know how 2 download

https://github.com/tizu69/ntl-redone/releases/tag/0.1

if the create mod supports both, this also should.

Fabric support is coming in NTL 0.2 along with support for 1.19.2

so for now it is quilt only?

so for now it is quilt only?

Forge only, not sure if Create even supports quilt, but if it does, I'll also add it to NTL 0.2 unless that is already integrated into Fabric (sry, I never actually used Quilt myself)

oh, so that is for forge. really i nver also used quilt neither fabric

so for now it is quilt only?

Forge only, not sure if Create even supports quilt, but if it does, I'll also add it to NTL 0.2 unless that is already integrated into Fabric (sry, I never actually used Quilt myself)

I've played fabric version on quilt so it should work

Fabric support is coming in NTL 0.2 along with support for 1.19.2

Would it be possible to support 1.19.3 as well? The normal create mod for fabric only supports 1.19.2 unfortunately.


BigTable Admin Samples

I signed it!

@juan-rael and @billyjacobson is this ready to go?

Sorry, I've been busy this week. I need to review the tests still, but the
samples were looking good. I'll wanna do another quick pass on them though
just to see if there's anything else I catch.
On Fri, Nov 9, 2018 at 11:47 AM Solomon Duskis<EMAIL_ADDRESS>wrote:

@juan-rael https://github.com/juan-rael and @billyjacobson
https://github.com/billyjacobson is this ready to go?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-437420292,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFekT55Rs0aHTKzz1rXLxQfHPQW4sDEvks5utbGYgaJpZM4X8mH8
.

--
*•  *Billy Jacobson
•  Developer Programs Engineer,
*•  *Google Cloud Developer Relations
•  111 8th Ave, New York, NY 10011
https://maps.google.com/?q=111+8th+Ave,+New+York,+NY+10011&entry=gmail&source=g

@billyjacobson https://github.com/billyjacobson  @tmatsuo
https://github.com/tmatsuo I using an  environment variable "PROJECT_ID"
to set the project_id...Need to know if theres a Var Env for that or I need
to set it statically?
On Fri, Nov 30, 2018 at 11:29 AM Billy Jacobson<EMAIL_ADDRESS>wrote:

@tmatsuo https://github.com/tmatsuo the kokoro tests are failing with
error:
Google\ApiCore\ValidationException: Cannot bind segment '{project=*}' to
value ''
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-443259078,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqBRbaVBP5IdpcoiibPbGBLB0IJnUhF3ks5u0VzkgaJpZM4X8mH8
.

@billyjacobson  @tmatsuo Right now, I used and environment variable "GOOGLE_CLOUD_PHP_TESTS_KEY_PATH"... That variable is fine?

"ERROR: (gcloud.auth) Invalid choice: 'configure-docker'."

Looks good! But we're still getting quota errors. Can you add bigtable/api to this list please? That will run each of them in a separate project so they should have enough quota. Or we can fill out a request for more quota.

I understand the problem now, @juan-rael. For some reason even though we're making requests to resources on other projects (e.g. php-docs-samples-php70) we are making them using a single set of service account credentials (e.g. php-docs-samples-kokoro). This is causing the quota to be exceeded when run across 4 projects simultaneously. Unfortunately, the API is counting all calls against the single project instead of the individual projects. I assume this is intended behavior but I don't like it.
To get around it, I'll either have to refactor the way kokoro tests are run to use separate credentials (not that big of a deal but kind of annoying) or we can use the ExponentialBackoffTrait to retry after we receive RESOURCE_EXHAUSTED errors from the API:
use Google\Cloud\TestUtils\ExponentialBackoffTrait;

final class BigTableTest extends TestCase
{
    use ExponentialBackoffTrait

    public function setUp()
    {
        $this->useResourceExhaustedBackoff();
    }

    //...

    private function runSnippet($sampleName, $params = [])
    {
        $testFunc = function() use ($sampleName, $params) {
            $argv = array_merge([basename(__FILE__)], $params);
            ob_start();
            require __DIR__ . "/../src/$sampleName.php";
            return ob_get_clean();
        };

        return self::$backoff->execute($testFunc);
    }
}

Sorry for all the headache here... I've also submitted a request to bump up our quota.

Running locally on a single project I am still getting quota errors. Is there a way you could conceivably reduce the number of calls?

Every test do I think four or five calls, I can reduce the calls, but need
to change the test, right now, the test create a instance, create a table,
run the snippet, check in the table/instance and then delete the instance...
On Tue, Dec 4, 2018 at 7:04 PM Brent Shaffer<EMAIL_ADDRESS>wrote:

Running locally on a single project I am still getting quota errors. Is
there a way you could conceivably reduce the number of calls?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-444306922,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqBRbUJz3EaMbJBHd6VB-1QbrUKWWnAWks5u1w2TgaJpZM4X8mH8
.

It would be great to reuse a single instance and table across the tests
On Tue, Dec 4, 2018, 16:39 juan-rael<EMAIL_ADDRESS>wrote:

Every test do I think four or five calls, I can reduce the calls, but need
to change the test, right now, the test create a instance, create a table,
run the snippet, check in the table/instance and then delete the
instance...
On Tue, Dec 4, 2018 at 7:04 PM Brent Shaffer<EMAIL_ADDRESS>wrote:

Running locally on a single project I am still getting quota errors. Is
there a way you could conceivably reduce the number of calls?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-444306922
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AqBRbUJz3EaMbJBHd6VB-1QbrUKWWnAWks5u1w2TgaJpZM4X8mH8
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-444313586,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGWBS3gE0KzwC1PrzJqHaxuCTDbyddFks5u1xWugaJpZM4X8mH8
.

I changed the test to use only three instances, but, right now it create
one table for every table test(column, table, list).
On Tue, Dec 4, 2018 at 7:51 PM Brent Shaffer<EMAIL_ADDRESS>wrote:

It would be great to reuse a single instance and table across the tests
On Tue, Dec 4, 2018, 16:39 juan-rael<EMAIL_ADDRESS>wrote:

Every test do I think four or five calls, I can reduce the calls, but
need
to change the test, right now, the test create a instance, create a
table,
run the snippet, check in the table/instance and then delete the
instance...
On Tue, Dec 4, 2018 at 7:04 PM Brent Shaffer<EMAIL_ADDRESS>wrote:

Running locally on a single project I am still getting quota errors. Is
there a way you could conceivably reduce the number of calls?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-444306922

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AqBRbUJz3EaMbJBHd6VB-1QbrUKWWnAWks5u1w2TgaJpZM4X8mH8

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-444313586
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAGWBS3gE0KzwC1PrzJqHaxuCTDbyddFks5u1xWugaJpZM4X8mH8
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/743#issuecomment-444315970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqBRbRqdm-lZ0pstd1I7oZw_5Q4rcSbmks5u1xh0gaJpZM4X8mH8
.

@bshaffer: there are table admin constraints on the Cloud Bigtable side on multi-cluster instances.  We ran into problems using a single instance.  We need to use a different instance for instance admin and table admin to avoid those constraints.

Added #774 to hopefully address this issue (by providing unique credentials for each CI build).

Also getting this error now
1) Google\Cloud\Samples\BigTable\Tests\BigTableTest::testCreateCluster
Google\ApiCore\ApiException: {
    "message": "Cannot create multiple clusters in the same zone.",
    "code": 9,
    "status": "FAILED_PRECONDITION",
    "details": []
}

I set another region cluster for that test.

I've created a PR that has fixes for these tests (#775), so I'm closing this one


Minimal Mode channel panel width ?

Hello
Since last big Discord update that broke a lot of stuff, minimal mode also has some issues

The width of channel pannel is too small, user names gets cut and you can't see much, even less when they mute themself you can only see a few letter and the muted icons...
The folder names disappear and you can't close them anymore
Same issue without any theme

Is there any plugins that would allow to resize that pannel ? Or CSS code ?
Wish I knew stuff about this but I don't :/

Bump ?

Bump ?


zsh: permission denied: ..

zsh: permission denied: ..
You can specify what you need
setopt auto_cd

late, but it's setopt autocd, with no underscore


Downloads stay in queued state for a very long time before starting

Seen on apps with targetSdk 34 and Android 14
Everything is working fine with targetSdk 33.
Since targetSdk 34 is mandatory for new apps and updates in PlayStore starting August 31st, this is somewhat urgent.

I am having this problem too. Do you have a solution for this problem?

Noticed a similar issue. The root cause for me was identified to be ACTION_QUEUE_BACKOFF_RESET broadcast was failing on Android 14, because the intent used was not package protected.

New version 3.4.0 has been released that contains fixes for this issue.


 I'm wondering if it's related to @roryaronson's issue #483.
When you get a chance, can you check whether it happens on other page upload places?

I'm going to mark this as closed, if anyone else has this problem, feel free to reopen.


Jenkins coverage badge generation fails if Jenkins server's default language is not English

Are you experiencing an issue with...

[x] shields.io
[ ] My own instance
[ ] badge-maker NPM package

:beetle: Description
Our Jenkins server does not have the locale plugin installed, and therefore is using the machine's default language as default language, which is Spanish.
This means that this query's
language response depends on the Accept-Language field of the HTTP header.
If the query is performed directly in the browser, the header is added, and so if the browser is configured in English, then the result is in English and the coverage badge can be generated.
However, if Accept-Language is not specified, Jenkins responds in its default language, so my coverage response looks like
{
    "_class":"hudson.plugins.cobertura.targets.CoverageResult",
    "results":{
        "children":[...],
        "elements":[
            {
                "denominator":112.0,
                "name":"Paquetes",
                "numerator":111.0,
                "ratio":99.10714
            },
            {
                "denominator":434.0,
                "name":"Ficheros",
                "numerator":422.0,
                "ratio":97.23502
            },
            {
                "denominator":434.0,
                "name":"Clases",
                "numerator":422.0,
                "ratio":97.23502
            },
            {
                "denominator":41695.0,
                "name":"LÃ\xadneas",
                "numerator":32987.0,
                "ratio":79.115005
            },
            {
                "denominator":65298.0,
                "name":"Condicionales",
                "numerator":22829.0,
                "ratio":34.961254
            }
        ],
        "name":"Cobertura Coverage Report"
    }
}

:link: Link to the badge

:bulb: Possible Solution
For the badge generation to work with Jenkins servers defaulting to languages other than English, the query to the job's coverage report should specify "Accept-Language": "en-US,en;q=0.9" in the HTTP header.
Of course setting the server to always respond in English will solve the issue, but that's something that is not always possible to do depending on the privileges.
I'm sorry about not issuing a PR myself, but I don't know the project and I don't have enough time at the moment.

Thanks for the report @EduPonz!

the query to the job's coverage report should specify "Accept-Language": "en-US,en;q=0.9" in the HTTP header

Do you have any additional info on this you could share (links to Jenkins docs, whether all Jenkins versions support this, etc.)


Geocoder doesn't work as expected

Geocoding should zoom to results when a user presses enter after entering data. Currently it does nothing.
Solution might be to get esri-leaflet-geocoder plugin to work with our custom geocoding service. But I'm having trouble with that, too. It may be a bug in esri-leaflet-geocoder since I'm not able to figure out how this conditional can pass to findAddressCandidates. It seems to always default to find.

Not a bug. Fixed in c78e233.


Add some docs

Really nicely explained, good work. Perhaps @robkuz can give some thoughts too, in case there's anything else that isn't obvious in here. Looks great to me though!

Thanks :)
I think it's probably worth adding a small section that says something like "but I just want to serialize and deserialize my types!" and points to argonaut-codecs at some point too, but I was intending to address that later, perhaps together with docs for argonaut-codecs. It might be the case that people don't need to know very much about this library to be able to use argonaut-codecs.

I pushed a new commit with the following improvements:

Define the whole hypothetical ADT in the first section; we nearly had all the cases covered anyway.
Fix mixups of JSON.stringify and JSON.parse.
Go into a little more detail about the JNumber, JString, JArray types.
Mention the (previously forgotten) other way of introducing Json into your program: parsing it from a string!
Add another key to the JSON object in the construction functions example, so that we have more than one key and therefore have a reason to not use jsonSingletonObject.
Talk more about the type of foldJson, and how it is like a case ... of expression.

I did consider putting foldJson last, but it's the fundamental function for matching on Json values, so I think it's best that the section reflects this, by mentioning it first and having it occupy the majority of that section.

I think this will do for now. I might come back to this later and write a fuller example as @robkuz suggested, but I am starting to suspect that the effort would be better spent on examples and docs for argonaut-codecs instead.

Amazing work! Reading the docs really helped me understand what's going on, especially around the foldXXX. Thank you

You're welcome :)


Global and organization secrets

Adds way to add server wide and organization wide secrets
Organization page

Organization settings page

Global settings page

[x] Database and store changes
[x] #1037
[x] Server API changes
[x] Organization settings UI
[x] Server settings UI
[x] Translation fixes

Codecov Report

Merging #1027 (ddc3738) into master (061596d) will decrease coverage by 0.03%.
The diff coverage is 42.62%.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   51.19%   51.15%   -0.04%
==========================================
  Files          81       82       +1
  Lines        6157     6216      +59
==========================================
+ Hits         3152     3180      +28
- Misses       2822     2850      +28
- Partials      183      186       +3

Impacted Files
Coverage Δ

server/model/secret.go
54.34% <0.00%> (-6.63%)
:arrow_down:

server/store/datastore/migration/migration.go
37.50% <ø> (ø)

.../store/datastore/migration/006_secrets_add_user.go
30.76% <30.76%> (ø)

server/store/datastore/migration/common.go
37.50% <46.66%> (+1.61%)
:arrow_up:

server/store/datastore/secret.go
80.00% <61.53%> (-20.00%)
:arrow_down:

server/logging/log.go
54.65% <0.00%> (+5.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cbd63...ddc3738. Read the comment docs.

@anbraten added suggested changes

@lafriks https://ci.woodpecker-ci.org/woodpecker-ci/woodpecker/build/3121/41

@anbraten fixed


[IOTDB-1727] Fix Slow creation of timeseries with tag

Description
same as #4019

Coverage increased (+0.01%) to 67.504% when pulling 7c721e0f22d35d49b646b3580a544a46d8d1dd5a on zyk990424:tagFile_Improvement_to_master into 15a5e68cac7cdd5e3d8ae0b4890c79ec1c945266 on apache:master.


Reduce copying and allocations

This eliminate Reader::prev and adds special handling of unfiltering for the first row.
It has minimal impact overall on the QOI corpus. However, if limited to QOI corpus images under 64KB, the average decoding speed goes from 244 MP/s to 436 MP/s on my machine. Edit: I think I messed up the benchmarks but I still see a modest perf improvement
cc: @anforowicz

it may be worth comparing all 3 approaches

Not sure if the data below helps or just stirs the pot unnecessarily :-) :

prev-row-copy-avoidance--double-long-buffer (see here)

noncompressed-8x8.png: change in time:
[-3.4699% -3.2960% -3.1177%] (p = 0.00 < 0.05)
noncompressed-128x128.png: change in time:
[-1.7766% -1.3460% -0.9357%] (p = 0.00 < 0.05)

prev-row-copy-avoidance--fintelia (see here)

noncompressed-8x8.png: change in time:
[-5.5093% -5.3152% -5.0900%] (p = 0.00 < 0.05)
noncompressed-128x128.png: change in time:
[-5.2180% -4.8080% -4.3969%] (p = 0.00 < 0.05)

prev-row-copy-avoidance--swap-prev-and-curr (see here)

noncompressed-8x8.png: change in time:
[+16.659% +16.859% +17.074%] (p = 0.00 < 0.05)
noncompressed-128x128.png: change in time:
[-17.995% -17.647% -17.318%] (p = 0.00 < 0.05)

I am very surprised by the wild changes from prev-row-copy-avoidance--swap-prev-and-curr.
I still worry about the cost of compaction (i.e. the calls to drain in Reader::next_raw_interlaced_row and ZlibStream::transfer_finished_data), but maybe we should just merge this PR and move on.

@fintelia, I just wanted to double-check that you've seen all of my comments above.  (The performance comparison is probably safe to ignore, but I was wondering about my comments/suggestions about unit test coverage and about tweaking code comments that refer to the deleted/renamed scan_start field.)

Somehow didn't see those comments or your changes on #420. Not exactly sure what happened, but I'll address them when I have a chance


Unifying the interface options

We have some applications where it would be very useful to have both absolute and relative tolerances, e.g. because we will run a lot of linear solves with good initial guesses such as in Newton methods. Currently, the linear solvers seem to support only  relative tolerance (via the keyword argument tol). Would it be okay

to introduce keyword arguments abstol, reltol (mimicking the names of arguments in the SciML ecosystem) with the same meaning as in PETSc, i.e. to stop the iteration when current_residual <= max(reltol * initial_residual, abstol)?
to deprecate tol in favor of reltol, e.g. using something along the lines of the following code snippet?function bicgstabl!(x, A, b, l = 2;
                    abstol = zero(real(eltype(b))),
                    reltol = sqrt(eps(real(eltype(b)))),
                    tol = nothing, # TODO: deprecated
                    max_mv_products::Int = size(A, 2),
                    log::Bool = false,
                    verbose::Bool = false,
                    Pl = Identity(),
                    kwargs...)

    # TODO: deprecated
    if tol !== nothing
        Base.depwarn("The keyword argument `tol` is deprecated, use `reltol` instead.", :bicgstabl!)
        reltol = tol
    end

    # the rest of the implementation
end

If it's okay, I can invest some work into this, but would like to know first whether it would be acceptable (to not waste some effort).
A related issue could be to specify a divergence tolerance divtol, similar to PETSc.
Another issue concerns the maximal number of iterations or matrix-vector products. Some methods allow specifying a maxiter (e.g. GMRES) while other allow specifying a max_mv_products (e.g. BiCGStab(l)). It would be nice if all methods could use the same keyword argument for this to make it easier to switch solvers.

Hi @ranocha, I would say this is great to have. abstol and reltol are good choices, I believe there's been some people complaining atol and rtol are hard to decipher.
The depwarn is OK, especially if iterativesolvers.jl is used somewhere deep inside another algorithm. But I'm also happy to quickly create a breaking change that doesn't have the depwarn.
max_mv_products is a mistake I'd say. Let's just use maxiter throughout.
divtol is quite alright too, but do note that there's various methods that have a bumpy convergence behavior, so it'll only really make sense for methods that are known to be not-bumpy, including CG and maybe GMRES. But even then, irregular convergence can happen due to rounding errors etc, so I probably wouldn't use this divtol myself.

Thanks for the feedback! I will add abstol and reltol in #280. We can have a look at maxiter(s) later, since that will likely be more difficult to change without breaking anything, since we should be consistent with the use of iterations in IterativeSolvers (in the convergence history etc.).
If we go for maxiter(s), I would like to use maxiters since that's in accordance with the keyword argument in the SciML ecosystem, see https://diffeq.sciml.ai/latest/basics/common_solver_opts/#Miscellaneous.
Would you propose to use maxiters as a replacement for "maximum number of matrix-vector products" and make this nomenclature consistent everywhere, i.e. should we also use iters to count the number of matrix-vector products in the convergence history or should iters still be the number of iterations?

Let's just make maxiter(s) the number of "outer" iterations of the algorithm. bicgstab(k) is special cause it has k gmres-like inner iteration per out iteration, but it's implemented as the matrix acting on a block of vectors, which is typically faster than applying it per vector, so it doesn't really make sense to count matrix-vector products in that algorithm. So instead, just count the number of outer iterations, and make the user responsible for potentially scaling that with their k param.

And yeah, maxiters is fine if that brings more consistency across packages.

Okay, that sounds reasonable to me.


Peer Dependency

Its a bit similar to #37.
I want to update to angular 2 beta 7. They ve updated RXjs to beta 2. They depend on version two and you peer dependency depend on beta 0. So i cant resolve this on my own. I would recommend to set peer dependency to ~beta.0. Then you can support different versions of angular 2 and the developer needs to resolve the peer dependency by his own.
Greetings,
Daniel

Yes I'm gonna do that as soon as I'm back from Amsterdam (for ng nl) later
today :-)
Le dim. 21 févr. 2016 14:01, DanielSchuech<EMAIL_ADDRESS>a
écrit :

Its a bit similar to #37
https://github.com/ocombe/ng2-translate/issues/37.
I want to update to angular 2 beta 7. They ve updated RXjs to beta 2. They
depend on version two and you peer dependency depend on beta 0. So i cant
resolve this on my own. I would recommend to set peer dependency to
~beta.0. Then you can support different versions of angular 2 and the
developer needs to resolve the peer dependency by his own.
Greetings,
Daniel
—
Reply to this email directly or view it on GitHub
https://github.com/ocombe/ng2-translate/issues/38.


sync up xcode related gitignore files

Xcode, Obj-C, & Swift updates. Also comment to help prevent fragmentation.
Some details based on #1221

Is it worth having a discussion about unifying these ignore files? We did this a while ago for VisualStudio - which was a combination of CSharp and VisualBasic languages - and I can't help but feel this is heading down that path...

@shiftkey See comments on 5bd4330 for why we have the current state of these particular templates. I think it needs fixing, but people have strong feelings here.

Can we get these changes merged? Given the comments on the other thread I don't see a merge of the templates being feasible in the near future.

@bbodenmiller I'll give @arcresu a chance to chime in if has any issues with it, but I'm :thumbsup: with this change.

Thanks, yeah this looks like a good change.


Please mark it as the non-official implementation of PV-RCNN

Hi,
Thanks for your interests in our work.
Please mark it as the non-official implementation of PV-RCNN in your README in case of the unnecessary confusion for other users.
Thank you!

@sshaoshuai Thanks, I have updated first line of readme to avoid any confusion.


Very bad sound (like a robot) on Android (+Chrome)

Hello,
I use this lib like it is indicated in the documentation (with React and Class Component).
It works well on a desktop (Safari / Chrome / Firefox)
It works well on my iPhone 6s (Safari)
But I have the same bad recording with Android device like : Samsung Galaxy Tab, Samsung A21, and I also try on a huawei phone (always with Chrome).
Is this a known problem ?
is there a setting to be made to operate on an Android / Chrome ?
( more than : const Mp3Recorder = new MicRecorder({ bitRate: 128 }); )
Many thanks for your help
Rachel

Can I ask why they are not mergable?

For anyone coming across this thread for a similar issue, give pull request #44 a try - using the AudioWorkletNode API frees up the main thread and alleviates a lot of burden for mobile devices. I had the robotic/choppy sound quality on a few lower- and mid-range phones fixed with this update.

@wLancaster thanks


Twilight Forest materials Compat

So I realized Twilight Forest was realeased for Fabric 1.18.  and I see that there is a lot of compatablity with other mods such as better end, better nether and Oh the biomes you'll go. So I was wondering if maybe you could add twilight forest materials to the mod now? I would love to swing around 2 firesteel ninjatos!

Reopen this issue with textures for a twilight forest compatibility.


Pixellisation

The way it is implemented here is interesting because they avoid the border problem by distributing the difference in size in all the squares.

https://onlineimagetools.com/pixelate-image

Already implemented


Add theme configuration to build

Adding a configuration option to the build in order to build the FrontEnd with a theme provided by semantic-ui

some information available at http://semantic-ui.com/usage/theming.html#using-packaged-themes advance information can be found here http://learnsemantic.com/ - most likely this will require custom build of Semantic-UI


easyrpg-player: 0.6.2 -> <IP_ADDRESS>

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/EasyRPG/Player/releases.
meta.description for easyrpg-player is: "RPG Maker 2000/2003 and EasyRPG games interpreter"
meta.homepage for easyrpg-player is: "https://easyrpg.org/"
meta.changelog for easyrpg-player is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found <IP_ADDRESS> with grep in /nix/store/ar246zrgxv3syi3yhh8x7br7dwn5vsbq-easyrpg-player-<IP_ADDRESS>

directory tree listing: https://gist.github.com/1c2eea879f0c3cacd060f4c18a5c28fe

du listing: https://gist.github.com/475791e2a265d3b398eea0e211b880a3

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
easyrpg-player

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ar246zrgxv3syi3yhh8x7br7dwn5vsbq-easyrpg-player-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A easyrpg-player https://github.com/r-ryantm/nixpkgs/archive/0a56f10920502120adb9ff59d0fc59f26cb7ce84.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ar246zrgxv3syi3yhh8x7br7dwn5vsbq-easyrpg-player-<IP_ADDRESS>
ls -la /nix/store/ar246zrgxv3syi3yhh8x7br7dwn5vsbq-easyrpg-player-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- easyrpg-player

Maintainer pings
cc @yegortimoshenko for testing.

Reviewed points

[x] package name fits guidelines
[x] package version fits guidelines
[x] package build on x86-64
[x] executables tested on x86-64 (nixos)
[x] all depending packages build (none)

Possible improvements
Comments
tested with a game from here (https://archive.org/download/EasyRPG_Games), specifically ZeldaLinksAwakening.zip. the game load and is playable.


Improved Performance by profiling using Nsight-Compute

Reduced memory transfers between cpu and gpu in outer loop iterations

This PR is a significant improvement in the algorithm's performance. It fixes an oversight I had about the memory transactions between the CPU and GPU. There are still some more improvements possible according to Nsight Compute, but they are mostly granular.


Fixed bug where the pinch strength defaults were inverted

Overview
The pinch strength values were inverted, making the pinch bool flicker on oculus. This fixes the values so that it's harder to exit pinch once the gesture is raised
Changes

Fixes: ##9544

/azp run


Update README.md

I just published a book about using data science in your personal day-to-day life. I think this group might appreciate it. There are fun pictures, stories, code, math, and jokes. I hope self promotion is ok, this seemed really relevant to the community.

Thanks for the input.
Regards,
Shubhendu
On Fri, Jan 29, 2021, 11:19 PM Andrew Carr<EMAIL_ADDRESS>wrote:

I just published a book about using data science in your personal
day-to-day life. I think this group might appreciate it. There are fun
pictures, stories, code, math, and jokes. I hope self promotion is ok, this
seemed really relevant to the community.
You can view, comment on, or merge this pull request online at:
https://github.com/academic/awesome-datascience/pull/234
Commit Summary

Update README.md

File Changes

M README.md
https://github.com/academic/awesome-datascience/pull/234/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(1)

Patch Links:

https://github.com/academic/awesome-datascience/pull/234.patch
https://github.com/academic/awesome-datascience/pull/234.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/academic/awesome-datascience/pull/234, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGH5RZBNALM4JZHXESIJJFTS4LYI5ANCNFSM4WZHQSYA
.

Thanks for the input.
Regards,
Shubhendu
On Fri, Jan 29, 2021, 11:19 PM Andrew Carr<EMAIL_ADDRESS>wrote:

I just published a book about using data science in your personal
day-to-day life. I think this group might appreciate it. There are fun
pictures, stories, code, math, and jokes. I hope self promotion is ok, this
seemed really relevant to the community.
You can view, comment on, or merge this pull request online at:
https://github.com/academic/awesome-datascience/pull/234
Commit Summary

Update README.md

File Changes

M README.md
https://github.com/academic/awesome-datascience/pull/234/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(1)

Patch Links:

https://github.com/academic/awesome-datascience/pull/234.patch
https://github.com/academic/awesome-datascience/pull/234.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/academic/awesome-datascience/pull/234, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGH5RZBNALM4JZHXESIJJFTS4LYI5ANCNFSM4WZHQSYA
.


SSO with Azure fails. client_id=None is sent to Azure

Nautobot 1.6.1 running on python 3.8 on Ubuntu 20.04.5 LTS .
SSO required dependencies have been installed; and configuration from documentation applied: https://docs.nautobot.com/projects/core/en/stable/configuration/authentication/sso/
We are using Azure SSO authentication; application created and access granted in Azure with correct return URI's.
SSO authentication page on Nautobot loads but sends request to Azure with "client_id=None" hence authentication fails. Error on Azure points to authentication issue due to no client_id being passed on.
AUTHENTICATION_BACKENDS = [
"social_core.backends.azuread.AzureADOAuth2",
"nautobot.core.authentication.ObjectPermissionBackend",
]
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_KEY = "ABC"
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_SECRET = "DFG"
SOCIAL_AUTH_AZUREAD_TENANT_OAUTH2_TENANT_ID = "HJK"
Please help in reviewing logs and resolving issue.
Thank you in advance.
Logs "social" set to debug level:
Traceback (most recent call last):
File "/path/nautobot/lib/python3.8/site-packages/django/template/base.py", line 829, in _resolve_lookup
current = current[bit]
File "/path/nautobot/lib/python3.8/site-packages/django/forms/forms.py", line 155, in getitem
raise KeyError(
KeyError: "Key 'custom_fields' not found in 'LoginForm'. Choices are: password, username."
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/path/nautobot/lib/python3.8/site-packages/django/template/base.py", line 837, in _resolve_lookup
current = getattr(current, bit)
AttributeError: 'LoginForm' object has no attribute 'custom_fields'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/path/nautobot/lib/python3.8/site-packages/django/template/base.py", line 843, in _resolve_lookup
current = current[int(bit)]
ValueError: invalid literal for int() with base 10: 'custom_fields'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/path/nautobot/lib/python3.8/site-packages/django/template/base.py", line 848, in _resolve_lookup
raise VariableDoesNotExist("Failed lookup for key "
django.template.base.VariableDoesNotExist: Failed lookup for key [custom_fields] in
Exception while resolving variable 'relationships' in template 'login.html'.
Traceback (most recent call last):
File "/path/nautobot/lib/python3.8/site-packages/django/forms/forms.py", line 153, in getitem
field = self.fields[name]
KeyError: 'relationships'

It sounds like your application isn't linked to the common tenant since you're providing a tenant ID. You'd need to use the social_core.backends.azuread_tenant.AzureADTenantOAuth2 backend in that case.

Thank you. It works now. Great support and fast responses.


libtorch-bin: 1.6.0 -> 1.7.0

Motivation for this change
Changelog:
https://github.com/pytorch/pytorch/releases/tag/v1.7.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 101925 1 run on x86_64-darwin

1 package built:

libtorch-bin

Result of nixpkgs-review pr 101925 1

1 package built:

libtorch-bin


Windows Tablets detected as PC and not Tablets

Under Tablets holding Windows OS , the methods :

isTablet() = false
isDesktop() = true

Fixed by https://github.com/KoderLabs/ngx-device-detector/releases/tag/1.3.7
Please see the breaking changes to use 1.3.7


added view engine list function

some widely used engines added

Hi, i see this was removed. Something wrong?  @ArjunSharda

One collaboration team member pointed out its not useful anymore as we are
now using Enums in our code.
On Fri, Oct 7, 2022 at 1:36 AM Alan Biju @.***> wrote:

Hi, i see this was removed. Something wrong? @ArjunSharda
https://github.com/ArjunSharda
—
Reply to this email directly, view it on GitHub
https://github.com/ArjunSharda/Searchor/pull/38#issuecomment-1271171256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASQ3JQWITR2SZTAEKO3FAI3WB7AG5ANCNFSM6AAAAAAQO35XJI
.
You are receiving this because you were mentioned.Message ID:
@.***>

oh, may i work on that again?
I'll code to display from enum class.
@ArjunSharda


Spatial navigation with dropdown select

Dear all,
I have trouble trying to make Norigin-Spatial-Navigation work with the dropdown select element.
I want the following typical behavior:
-The dropdown button could get focused with directional navigation.
-When focused, pressing Enter will expand the dropdown menu.
-When the menu is expanded, pressing the up and down keys will highlight the different dropdown options.
-When Enter is pressed, the highlighted option is selected, the dropdown is retracted, and the onSelect callback function is called.
I have tried making the dropdown component focusable as follows:
import {useFocusable} from "@noriginmedia/norigin-spatial-navigation";

function DropdownSelection() {

    const { ref, focused } = useFocusable()

    return (
        <select ref={ref} name="cars" id="cars">
            <option value="volvo">Volvo</option>
            <option value="saab">Saab</option>
            <option value="mercedes">Mercedes</option>
            <option value="audi">Audi</option>
        </select>
    );
}

export default DropdownSelection;

But this did not work. The menu does not expand on  Enter press when the element is focused.
I even tried with dropdown components from libraries like Semantic-ui and react-bootsrap, but also failed.
Any suggestions?

Hello.
First of all, you need to handle onEnterPress callback from the useFocusable hook. Otherwise, nothing is happening when Enter is pressed. Then each Option element needs to be a focusable component as well with its own onEnterPress handling. Hope it helps.

I separated the option out to its own component but I am now facing an issue with the focus being lost once i get to the select.
import {useFocusable} from "@noriginmedia/norigin-spatial-navigation";

function DropdownOption() {
	const { ref, focused } = useFocusable({onEnterPress: () => //}}
    return (
        <option ref={ref} value={value}>{label}</option>
    );
}
function DropdownSelection() {
	const { ref, focused } = useFocusable({onEnterPress: () =>  })
    return (
        <select ref={ref} name="cars" id="cars">
            <DropdownOption value=“volvo” label=“Volvo”/>
            <DropdownOption value=“mercedes” label=“Mercedes”/>
            <DropdownOption value=“audi” label=“Audio”/>
        </select>
    );
}

export default DropdownSelection;


Split backdrop into 4 divs around highlighted div

See comment here : https://github.com/GlobalHive/vuejs-tour/issues/65#issuecomment-2331124090
Some libraries are redefining stacking context, so it's impossible to use the backdrop as it is now.
This could be switched on/off on demand with a prop. Not necessarily a "quasar" props, since it's probably not the only framework to be impacted.

Thank you for creating this issue! I'll start working on it ASAP. 🙏

Hello @chboing ,
I have updated the highlight procedure to use the clip-path for the backdrop, as mentioned in #68. This ensures compatibility across all frameworks.
There is no need for any changes on your end. Simply update the package to version 2.2.0.
Best regards,
Global Hive
Sascha

You may want to update your doc too ;) https://globalhive.github.io/vuejs-tour/guide/the-onbefore-event.html
I was waiting the 2.2.0 with this feature (onBefore & onAfter) but it seems i'll have to wait a bit more !

Hey @chboing,
You're right, looks like the latest release went out without the Dev branch included—oops! I’ve just pushed a new one, and it’s got all the, bigger, promised features now.
Best regards,
Global Hive
Sascha


Clearing the ng lint errors

Will try taking this.

@validity-check, Sure!

Nearly done. Should have a PR done by the end of today.

Awesome!
That sounds good. Thanks

#161


Refine Locations View in New UI

Private Zenhub Image
Mostly looking at the order with the legacy view.

Hey team! Please add your planning poker estimate with Zenhub @bryanculver @glennmatthews @gsnider2195 @HanlinMiao @jathanism @timizuoebideri1

Closed by #4365


LICENSE file in docs repo is different from page footer.

The LICENSE file in the repo that contains the specification is Apache 2.0; but the footer of the specification site says that the content is licensed under Creative Commons 4.0 Attribution International.
I believe that the intent is that the specification's content is licensed under CC4, and the apache LICENSE file is a holdover / bug.
Is this correct? If so, we should really update the LICENSE file to match the footer.

This is correct and intentional. From our README.md:

All Markdown content in this repository is licensed under the Creative Commons Attribution 4.0 International License.
Unless otherwise noted, the contents of this repository are licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

When you apply the Apache 2.0 License, you copy this LICENSE file into your project (per Apache's guidance here). I realize that GitHub picks up this file and assumes the whole project falls under that license; however, that's just because GitHub doesn't handle projects with content under multiple licenses.
The Apache 2.0 License is for code -- not documentation/spec. That's where Creative Commons license comes in and why it is in the footer of our documentation/spec pages.
Does that help clarify things? Do we need to make that more clear in the README.md for this project?


Feature Request: ListR for Google Drive and Dropbox

Hi,
Noticed that mounting an encrypted remote on Dropbox in Windows is really slow when listing directories. The documentation states that ListR isn't being used for Dropbox.
Dropbox's v2 API has a list_folder method. Similarly, Google Drive also supports listing folder contents.
Can support for these be added?

ListR is all about listing the directory recursively, so you get the whole file system listing back at once.  rclone mount doesn't use the ListR interface - it lists each directory at a time.

This question seems to be answered. If you have anything else, please feel free to ask on the forums.


Fix email-alert-api LB healthchecks and remove disused ELB.

Load balancer healthchecks for email-alert-api were checking the default
vhost config on the nginx instead of being routed through to the app
itself. (See https://github.com/alphagov/govuk-aws/blob/master/doc/architecture/decisions/0037-alb-health-checks.md)
Also remove the external-facing Classic ELB since this has never been used.
Now is a good time to clean this up, before we migrate Staging and Production
email-alert-api to AWS.

TF plan in Staging and Integration (they're the same) :
Resource actions are indicated with the following symbols:
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  - aws_elb.email-alert-api_elb_external

  ~ aws_elb.email-alert-api_elb_internal
      health_check.0.target: "TCP:80" => "HTTP:80:/_healthcheck_email-alert-api"

  - aws_route53_record.service_record_external

  - module.alarms-elb-email-alert-api-external.aws_cloudwatch_metric_alarm.elb_httpcode_backend_5xx

  - module.alarms-elb-email-alert-api-external.aws_cloudwatch_metric_alarm.elb_httpcode_elb_4xx

  - module.alarms-elb-email-alert-api-external.aws_cloudwatch_metric_alarm.elb_httpcode_elb_5xx

  - module.email-alert-api.aws_autoscaling_attachment.node_autoscaling_group_attachment_classic[1]

Plan: 0 to add, 1 to change, 6 to destroy.


Flicker when resizing the window

Since updating to macOS Sierra, I think, my MacVim flickers whenever I resize the window. I have tried the version from GitHub and the one from homebrew. The flicker is almost painful to look at.
Warning: fast black and white strobe effect in this video.
https://cloud.githubusercontent.com/assets/828125/22670826/0a80f656-ec99-11e6-8e0d-0c1aee37433e.gif

Same as #32


Microsoft Edge support

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Unable to send data to Thingspeak

When I run the ThingSpeak.py file from sample folder, I get the following error.

AttributeError:  'CellularIoTApp'  object has no attribute  'sendDataComm'

I have checked the cellulariot.py file and 'sendDataComm' method is not defined
Please help

If you installed the library with pip, your library may be old release. Please follow instructions below and install the library from Github repo again and share with us the results.
git clone https://github.com/sixfab/Sixfab_RPi_CellularIoT_Library.git
cd Sixfab_RPi_CellularIoT_Library
sudo python3 setup.py install

Also thank you for your feedback. We will update the library at pip soon.

I am still getting the same error.

Can you try again? I added a bug fix.

It is working now. Thank you for the bug fix


CACHE MISS Glitch has resurfaced.

The cache missing glitch has resurfaced. it's the exact same glitch found from this previous issue: #1081
I'm currently running PEX version 1.22.1
The workaround currently works by removing the affected player from the group and manually re-adding them.
Just thought I'd let you know about the issue.
Here's a screenshot of some of the code when the user is in debug mode:

I am also having this issue. I had someone that is ranked "builder" not have gamemode privileges which is odd. i pex user name to verify he had the group and he did. When he spoke he did not have the builder title.
[22:57:02] [Server thread/INFO]: [PermissionsEx] User rosseelcrafter checked for permission 'essentials.mail', regex-matched a value of true from essentials.mail (CACHE MISS)
[22:57:02] [Server thread/INFO]: [PermissionsEx] User rosseelcrafter checked for permission 'essentials.gamemode', no match found (CACHE MISS)
[22:57:02] [Server thread/INFO]: [PermissionsEx] User rosseelcrafter checked for permission 'essentials.', no match found (CACHE MISS)
[22:57:02] [Server thread/INFO]: [PermissionsEx] User rosseelcrafter checked for permission '', no match found (CACHE MISS)
He switched maps with no success. It was fixed with a /pex reload which from what it sounds with the previous time this bug existed that was the fix.
The SQL database is around 170ms away (temporary) Im not sure if that would cause any issues as  pex does locally cache.
Would love some advice or suggestions.
Questions always welcome.


disable for device builds?

Hey dude - thanks for this.  Definitely makes this error go away.
Does this get applied when building for a device vs. building for the emulator?  I'd think it'd be better if there was a way to only apply this to the emulator so that real builds continue to have the security benefit.  Do you know how to do that?
Thanks!

:+1:

:+1: Emulator only patches would be awesome! Otherwise being able to configure whitelisted hosts in config.xml would be really nice!


[questions] Some question about writing flutter plugins

Why FlutterActivity extends android.app.Activity and not AppCompatActivity
Is there some plan to use it one day ?
And if not why ?
My goal is to access getSupportFragmentManager (cf. https://developer.android.com/reference/android/support/v4/app/FragmentActivity#getSupportFragmentManager()) in order to add v4 Fragment.

I read somewhere that they did it to save on binary size. You can change your MainActivity to inherit from io.flutter.app.FlutterFragmentActivity to use fragments.

@Kleak
Is this still a valid question or has it been resolved ?
Can this issue be closed ?

i think you can close it


Fix #50

This isn't a full fix but I can't seem to reproduce the issue in #50 at
the moment. So for now this just ensures that exceptions in the
constructors get cleaned up properly (so they don't block future
construction attempts against the same pin)

Is this ready to merge?

Yup, should be - but it might break the merging of #61 - if it does, no worries - I'll just rebase the latter

Sorry - did you want me to merge it? No worries if so, I was just wondering if you wanted to sign off on stuff first?


How to add circles using Point and Polygon with JSX syntax

Ask:
Specifically I want to do this:
https://docs.microsoft.com/en-us/azure/azure-maps/map-add-shape#add-a-circle-to-the-map
I want a geospatially correct circle as the user zooms in and out.
Alternatives I've tried:
Bubble layer gets me a circle but the radius is pixel fixed which is why I discarded this approach and want to get the above point/shape + Polygon layer combo working.
Question:
It is not clear to me where to apply properties subType and radius when using the JSX components offered by this library.
I tried something like this where I specify type as a point and variant as shape. Then I add subType and radius to properties. This did not work and nothing from this layer shows up on the map.
Is this on the right track and if so, what is missing in order to render a point as a geospatially correct circle?
myPoints
<AzureMapFeature
  key={id}
   id={id}
   variant="shape"
   type="point"
   coordinates={[new Position(0, 0)]}
   properties={{
       subType: 'Circle',
       radius: 10000 //meters
     }}
 />

Later I create a PolygonLayer like this
myPolygonLayer
<AzureMapLayerProvider
  id={`${layerId}-polygonLayer-circles`}
  options={{
    fillOpacity: 0.75,
    fillColor: 'red',
  }}
  type="PolygonLayer"
  events={eventsHandlers}
/>

Finally I create a DataSource provider like this with the above two JSX components
DataSource
<AzureMapDataSourceProvider id={layerId}>
  {myPolygonLayer}
  {myPoints}
</AzureMapDataSourceProvider>

Thanks!

I've come across this issue too. The azure maps documentation says that this should be possible (https://learn.microsoft.com/en-us/azure/azure-maps/map-add-shape). Is the circle subtype not implemented in this library?


[Feature request]

Hello,
Thanks for sharing this great piece of code !
Would it be possible to include the opposite direction ? From clipboard to Dataframe ?
That would be awesome !
Patrick

Excellent feature request. We'll take a look.


cannot import name 'UNIT_PERCENTAGE'

Version of the custom_component
VERSION = "2.0.1"
Configuration
foldingathomecontrol:

address: "<IP_ADDRESS>"
port: 36330
#password: "password"

Add your logs here.
Sep 19 09:25:26 ultra hass[734]: 2020-09-19 09:25:26 ERROR (MainThread) [homeassistant.components.homeassistant] Component error: foldingathomecontrol - cannot import name 'UNIT_PERCENTAGE' from 'homeassistant.const' (/srv/homeassistant/lib/python3.8/site-packages/homeassistant/const.py)
Describe the bug
The HACS integration throws this error on start up.  Just doing some digging I can up with: UNIT_PERCENTAGE was changed to PERCENTAGE in 0.115. The integration needs to update their code. Please open a github issue on the integration’s repo

I see it also....
Log Details (ERROR)
Logger: homeassistant.setup
Source: setup.py:138
First occurred: 1:51:49 AM (1 occurrences)
Last logged: 1:51:49 AM

Setup failed for foldingathomecontrol: Unable to import component: cannot import name 'UNIT_PERCENTAGE' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)
Home Assistant has started!


Remove solver options from default installation

The solvers for running MESSAGEix are currently specified in the file message_ix/model/MESSAGE/auxiliary_settings.gms - this causes issues for users who do not have a CPLEX license. It would be prefereable that GAMS defaults to the solver selection made during GAMS installation, and only make the MESSAGE-specific selection of solver optional.

#273 was a duplicate and contains additional information. Copied labels and milestone here.

No one was assigned to do this by the feature freeze for v3.2.0, so we postpone to v3.3 (or later).

No one was assigned to do this by the feature freeze for v3.2.0, so we postpone to v3.3 (or later).

No one was assigned to do this by the feature freeze for v3.3.0. I'll remove the milestone.


This PR modifies the VPP existing probe to be able to run inside the namespace, using the socket interface. I integrated the memifs retrieval that you implemented and the links between them. I also cherry-picked the tests from your PR.
It would be very nice if you could give it a try.

I was able to get it running and overall it looks good, only added few comments.
Also one general comment: If it is not already done/planned, I would also welcome if it was documented how to build and use vpp probe. For example mention that WITH_VPP=true has to be defined, that vpp probe is not loaded by default and needs to be listed in agent.topology.probes config and also document which version of VPP is supported out-of-the-box (for which version the binary API files have been generated and included in the repo).

@milanlenco Thanks a lot for taking the time to test and for the review. This is really useful, I will try to address the issues


⚠ Bofrost.fr has degraded performance

In dce9908, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 923 ms

Resolved: Bofrost.fr performance has improved in 47fb8f2 after 6 minutes.


”Trifești” is listed in the drop-down menu

Description:
"Trifești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Trifești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Trifești, IAȘI".


PlayCanvas profiler crashes on v1.25.0-dev

Description
PlayCanvas profiler crashes on version 1.25.0-dev.
One of the stats seems to be undefined, causing it to crash.
See the images for more information.

Steps to Reproduce

Open any project.
Launch the app with the profiler option ticked
Launch the app with the latest dev engine (v1.25.0-dev)
Check the logs.

If you launch with the dev engine and the profiler enabled, you need to be serving the profile build of the dev engine.
npm run build:profiler

The output engine should be called playcanvas.prf.js

Thanks for the fast reply. I'll do that. Closing the issue.


[WIP] Create a separate module for API

What this PR does / why we need it:
Creates a go submodule for the api/v1alpha1 package to simplify importing Hypershift's API by external consumers.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes HOSTEDCP-336
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/close
We'll try to reduce the dependencies on the Kubevirt API side


Validation of page url in FeedbackRestRepository

References
This PR fixes #9288
Description
This PR adds a simple validation of the page url.

We should add a test case in FeedbackRestRepositoryIT to check that the generated email does not contain manipulated page urls. Unfortunately, the DS backend unit tests do not run on my local dev environment ;(


Unable to send epoc time using LOCAL.DATE

Unable to send epoc time using LOCAL.DATE

hey @vinod-191gs . Can you provide more information? The scenario you are trying to run, logs and so on. Thanks

I am trying send epoch time in the payload instead of formatted date but there is no option to send epoch time in the payload.
This is a new feature i am requesting to implement.

@vinod-191gs  there might be simpler way to do it , but this is one way to do it: The idea is to have a first step that calls our  method, that returns epoch time (or anything you want) and then use that response in second step, like this:
"steps":[
        {
            "name": "get_epoch_time",
            "url": "Main",
            "method": "getEpoch",
             "assertions": {
                  }

        },{
         "name": "execute_java_method",
                    "url": "Main",
                    "method": "testEpoch",
                    "request":"${$.get_epoch_time.response}",
                     "assertions": {
                          }
        }
        ]

so In step 1 I call getEpoch method of Main class that returns epoch time. In step two I use that with  ${$.get_epoch_time.response}  (keep in mind that  get_epoch_time this is the name of first step, you most certainly will have a different name so use that ).  For more questions, you can join our  Slack


Update link Awesome-C

Change links from archived projects to more active projects

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.
This applies even when changing an existing link to a new list.

I respect your rules for high quality commitments.
Sorry for making you spend your time.
I will close for now.


can't use react-redux frontend to connect to

https://github.com/gothinkster/react-redux-realworld-example-app
seems they use a wrong api to connect?
INFO: ('<IP_ADDRESS>', 64608) - "OPTIONS /api/users HTTP/1.1" 400
INFO: ('<IP_ADDRESS>', 64712) - "OPTIONS /api/users/login HTTP/1.1" 400

the problem has been resolved. It's because by my cors settings. I deleted the allowed_host setting in the .env file. It works.


lazygit: 0.11.3 -> 0.12.3

Motivation for this change
https://github.com/jesseduffield/lazygit/releases/tag/v0.12.3
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

/nix/store/s6z3192c4v9ry9xm1s2vhhzvdx9ks234-lazygit-0.11.3-bin    45.5M
/nix/store/kn02mx68llpdssa01lj2vdimazwg1x84-lazygit-0.12.3-bin    45.9M

[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @fpletz @equirosa

This change is

@GrahamcOfBorg build lazygit


Getting error on AZ CLI while deploying Container Apps via BICEP

Please provide us with the following information:

This issue is a: (mark with an x)

[X] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When I try to deploy my container app setup via a BICEP file, the AZ CLI gives me error stating "[WinError 193] %1 is not a valid Win32 application", The version of AZ CLI is up to date on my system.

Steps to reproduce

.. Create a Bicep file for deploying CA.
.. Run it via az cli using this command
az deployment group create --resource-group "yourresourcegroupname" --template-file containerapps.bicep --parameters location="yourregionofchoice"
Running the command with --debug gives me this.

C:\Users\rachittandon\Desktop>az deployment group create --resource-group "rg-Abc-test" --template-file containerapps.bicep --parameters location="West Europe" --debug
cli.knack.cli: Command arguments: ['deployment', 'group', 'create', '--resource-group', 'rg-Abc-test', '--template-file', 'containerapps.bicep', '--parameters', 'location=West Europe', '--debug']
cli.knack.cli: __init__ debug log:
Enable color in terminal.
Enable VT mode.
cli.knack.cli: Event: Cli.PreExecute []
cli.knack.cli: Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x0178A460>, <function OutputProducer.on_global_arguments at 0x01858BF8>, <function CLIQuery.on_global_arguments at 0x01877850>]
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableCreate []
cli.azure.cli.core: Modules found from index for 'deployment': ['azure.cli.command_modules.resource']
cli.azure.cli.core: Loading command modules:
cli.azure.cli.core: Name                  Load Time    Groups  Commands
cli.azure.cli.core: reso
[containerappbicep.txt](https://github.com/microsoft/azure-container-apps/files/11752463/containerappbicep.txt)
urce                  0.016        47       209
cli.azure.cli.core: Total (1)                 0.016        47       209
cli.azure.cli.core: These extensions are not installed and will be skipped: ['azext_ai_examples', 'azext_next']
cli.azure.cli.core: Loading extensions:
cli.azure.cli.core: Name                  Load Time    Groups  Commands  Directory
cli.azure.cli.core: Total (0)                 0.000         0         0
cli.azure.cli.core: Loaded 47 groups, 209 commands.
cli.azure.cli.core: Found a match in the command table.
cli.azure.cli.core: Raw command  : deployment group create
cli.azure.cli.core: Command table: deployment group create
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableTruncate [<function AzCliLogging.init_command_file_logging at 0x03B4B460>]
cli.azure.cli.core.azlogging: metadata file logging enabled - writing logs to 'C:\Users\rachittandon\.azure\commands\2023-06-15.09-03-35.deployment_group_create.7352.log'.
az_command_data_logger: command args: deployment group create --resource-group {} --template-file {} --parameters {} --debug
cli.knack.cli: Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument.<locals>.add_subscription_parameter at 0x03B73928>]
cli.knack.cli: Event: CommandInvoker.OnPostArgumentLoad []
cli.knack.cli: Event: CommandInvoker.OnPostCommandTableCreate [<function register_ids_argument.<locals>.add_ids_arguments at 0x03B8D898>, <function register_cache_arguments.<locals>.add_cache_arguments at 0x03B8DA90>]
cli.knack.cli: Event: CommandInvoker.OnCommandTableLoaded []
cli.knack.cli: Event: CommandInvoker.OnPreParseArgs []
cli.knack.cli: Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x01858C40>, <function CLIQuery.handle_query_parameter at 0x01877898>, <function register_ids_argument.<locals>.parse_ids_arguments at 0x03B8DA48>]
cli.azure.cli.command_modules.resource._bicep: Current value of "use_binary_from_path": if_found_in_ci.
cli.azure.cli.command_modules.resource._bicep: Bicep CLI installation path: C:\Users\rachittandon\.azure\bin\bicep.exe
cli.azure.cli.command_modules.resource._bicep: Bicep CLI installed: True.
cli.azure.cli.core.azclierror: Traceback (most recent call last):
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 697, in _run_job
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 333, in __call__
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/resource/custom.py", line 546, in deploy_arm_template_at_resource_group
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/resource/custom.py", line 575, in _deploy_arm_template_at_resource_group
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/resource/custom.py", line 989, in _prepare_deployment_properties_unmodified
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/resource/_bicep.py", line 94, in run_bicep_command
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/resource/_bicep.py", line 273, in _get_bicep_installed_version
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/resource/_bicep.py", line 311, in _run_command
  File "subprocess.py", line 503, in run
  File "subprocess.py", line 971, in __init__
  File "subprocess.py", line 1440, in _execute_child
OSError: [WinError 193] %1 is not a valid Win32 application

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/arm.py", line 109, in handle_template_based_exception
AttributeError: 'OSError' object has no attribute 'inner_exception'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 663, in execute
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 718, in _run_job
  File "D:\a\_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/arm.py", line 114, in handle_template_based_exception
knack.util.CLIError: [WinError 193] %1 is not a valid Win32 application

cli.azure.cli.core.azclierror: [WinError 193] %1 is not a valid Win32 application
az_command_data_logger: [WinError 193] %1 is not a valid Win32 application
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x03B4B580>]
az_command_data_logger: exit code: 1
cli.__main__: Command ran in 0.943 seconds (init: 0.454, invoke: 0.490)
telemetry.main: Begin splitting cli events and extra events, total events: 1
telemetry.client: Accumulated 0 events. Flush the clients.
telemetry.main: Finish splitting cli events and extra events, cli events: 1
telemetry.save: Save telemetry record of length 3489 in cache
telemetry.check: Negative: The C:\Users\rachittandon\.azure\telemetry.txt was modified at 2023-06-15 08:57:48.325351, which in less than 600.000000 s

Expected behavior [What you expected to happen.]
CA should deploy successfully
Actual behavior [What actually happened.]
An error occurs as specified above
Screenshots
Bicep file and Screenshot attached

Please share the Bicep file if possible.

Possibly related to: https://github.com/Azure/bicep/issues/2364
@ractando please try reinstalling your Bicep and Azure CLI.


Upgrade to rustc 1.0.0-dev (7f53b943f 2015-03-19)

Renamed FileNotFound to NotFound.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTING.md for more information.

Thanks! We'll be sure to merge once the new nightlies are available


Cross platform plugin docs update

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Credential-Providers-for-Visual-Studio.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Credential-Providers-for-Visual-Studio.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Cross-Platform-Authentication-Plugin.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix line-endings

Coverage remained the same at 95.8% when pulling 4ac17d4760d43660376afdee06ecd2631f3e01ce on poorgeek:fix-line-endings into 02383d934a1f861bd30dfb8f1e48b6cab392b38f on cfpb:milestone8.


Rx Animated Data Source still animates when animation style is set to none

Hi All,
First of all great library! It changed completely the way I handle data sources in table views and collections views :)
The issue I'm having is with the following code (in this case for a Table View)
dataSource.animationConfiguration = AnimationConfiguration(insertAnimation: .none,                                                                    reloadAnimation: .none,                                                                    deleteAnimation: .none)
I need the animated data source because I want to append/remove/update data changes but I don't want the row animation at the insert. However when setting it to .none it still animates.
Am I missing something here? Thanks for your help.

Hi @alexbredy ,
I think it should work.
view.insertItemsAtIndexPaths(
        changes.insertedItems.map { IndexPath(item: $0.itemIndex, section: $0.sectionIndex) },
        animationStyle: animationConfiguration.insertAnimation
    )

You can put a breakpoint there and see what command is being sent.
¯\_(ツ)_/¯

Hi kzaher,
Thanks for your prompt reply!
Your code does execute correctly and the parameters I've defined are passed in this function.
However, when setting animation to .none, iOS still animates the tableView's cell in one way or another.
In order to prevent this to happen, I temporarily updated the performBatchUpdates function (for the table view) and wrapped its three lines with a UIView.performWithoutAnimation and it worked like a charm! I used this technique in the past in order to have no animation and take advantage of the table view not being fully reloaded. Here's the code of the updated function:
public func performBatchUpdates<S: SectionModelType>(_ changes: Changeset<S>, animationConfiguration: AnimationConfiguration) {         UIView.performWithoutAnimation {             self.beginUpdates()             _performBatchUpdates(self, changes: changes, animationConfiguration: animationConfiguration)             self.endUpdates()         }     }
Of course I wouldn't suggest this as a change since all animations wouldn't perform anymore but perhaps whenever you have some time it would be nice to refactor it so that an animation set to .none is really not animating. :)
Thanks again.

@alexbredy @kzaher Just encountered this.
I'm setting the .animationConfiguration (with a AnimationConfiguration initialized with .none for all params) just before a next event is fired on the observable the dataSource is binded to.

Still seeing this issue as well. Setting .none as the animation seems to have no effect.  Any reason it was closed?

We are passing that information to UIKit correctly. If there is some change that you are proposing feel free to make a PR, but I don't see any bug on RxDataSources side.

Same issue here.. Oddly enough, the .left, .right, .top and so on... All have the expected animation style. It's only the .none animation that seems to perform as a .fade animation.

So how to disable animation while I need append/remove/update cells？

You can edit UI+SectionedViewType file. Add performWithoutAnimation as in:
public func performBatchUpdates<S>(_ changes: Changeset<S>, animationConfiguration: AnimationConfiguration) {
        UIView.performWithoutAnimation { [unowned self] in
            self.beginUpdates()
            _performBatchUpdates(self, changes: changes, animationConfiguration: animationConfiguration)
            self.endUpdates()
        }
    }

dataSource.decideViewTransition = { (_, _, _)  in return RxDataSources.ViewTransition.reload }

@kzaher
As the doc mentioned:
case none
The inserted or deleted rows use the default animations.
```swift

`none` doesn't means no animation, it means `default`. As a result, there is no way to easily disable the animation.
Change all the `decideViewTransition` to `.reload` won't take benefit from the diff algorithm, so I don't think it's a right approach.

@kzaher so even though there is no bug on RxDataSources, it seems that users of RxDataSources aren't able to fully disable animations without modifying RxDataSources as suggested by @alexbredy and @Gamec. In order to remove animations without modifying the framework, perhaps that extension would have to be turned into an open class so people could override performBatchUpdates.
Another approach I was thinking of, even though it goes against Apple's documentation quoted by @kukushi above, would be including the performWithoutAnimation block in case the AnimationConfiguration was configured as none for all scenarios. I'm not sure what the community thinks about it but IMHO it's at the very minimum an awful name choice by Apple to say that UITableViewRowAnimation.none does not mean "no animation". Personally I'd be happy to override that definition by doing:
    public func performBatchUpdates<S>(_ changes: Changeset<S>, animationConfiguration: AnimationConfiguration) {
        let performUpdates = {
            self.beginUpdates()
            _performBatchUpdates(self, changes: changes, animationConfiguration: animationConfiguration)
            self.endUpdates()
        }

        let config = animationConfiguration
        switch (config.insertAnimation, config.reloadAnimation, config.deleteAnimation) {
        case (.none, .none, .none):
            UIView.performWithoutAnimation(performUpdates)
        default:
            performUpdates()
        }
    }

what do you think?

There's a simple way to disable animation with Rx animatable data source. It's odd but it works.
DispatchQueue.main.async {
   UIView.performWithoutAnimation {
      // update your section model data here
   }
}

For anyone out there, I wrote this if you wanna fix it. It's just a modified version of RxTableViewSectionedAnimatedDataSource with a few tweaks
//
//  RxTableViewSectionedAnimationlessDataSource.swift
//  RxExample
//
//  Created by Krunoslav Zaher on 6/27/15.
//  Copyright © 2015 Krunoslav Zaher. All rights reserved.
//
import RxDataSources

#if os(iOS) || os(tvOS)
import Foundation
import UIKit
#if !RX_NO_MODULE
import RxSwift
import RxCocoa
#endif
import Differentiator

open class RxTableViewSectionedAnimationlessDataSource<Section: AnimatableSectionModelType>
    : TableViewSectionedDataSource<Section>
    , RxTableViewDataSourceType {
    public typealias Element = [Section]
    public typealias DecideViewTransition = (TableViewSectionedDataSource<Section>, UITableView, [Changeset<Section>]) -> ViewTransition

    /// Animation configuration for data source
    public var animationConfiguration: AnimationConfiguration

    /// Calculates view transition depending on type of changes
    public var decideViewTransition: DecideViewTransition

    #if os(iOS)
        public init(
                animationConfiguration: AnimationConfiguration = AnimationConfiguration(),
                decideViewTransition: @escaping DecideViewTransition = { _, _, _ in .animated },
                configureCell: @escaping ConfigureCell,
                titleForHeaderInSection: @escaping  TitleForHeaderInSection = { _, _ in nil },
                titleForFooterInSection: @escaping TitleForFooterInSection = { _, _ in nil },
                canEditRowAtIndexPath: @escaping CanEditRowAtIndexPath = { _, _ in false },
                canMoveRowAtIndexPath: @escaping CanMoveRowAtIndexPath = { _, _ in false },
                sectionIndexTitles: @escaping SectionIndexTitles = { _ in nil },
                sectionForSectionIndexTitle: @escaping SectionForSectionIndexTitle = { _, _, index in index }
            ) {
            self.animationConfiguration = animationConfiguration
            self.decideViewTransition = decideViewTransition
            super.init(
                configureCell: configureCell,
               titleForHeaderInSection: titleForHeaderInSection,
               titleForFooterInSection: titleForFooterInSection,
               canEditRowAtIndexPath: canEditRowAtIndexPath,
               canMoveRowAtIndexPath: canMoveRowAtIndexPath,
               sectionIndexTitles: sectionIndexTitles,
               sectionForSectionIndexTitle: sectionForSectionIndexTitle
            )
        }
    #else
        public init(
                animationConfiguration: AnimationConfiguration = AnimationConfiguration(),
                decideViewTransition: @escaping DecideViewTransition = { _, _, _ in .animated },
                configureCell: @escaping ConfigureCell,
                titleForHeaderInSection: @escaping  TitleForHeaderInSection = { _, _ in nil },
                titleForFooterInSection: @escaping TitleForFooterInSection = { _, _ in nil },
                canEditRowAtIndexPath: @escaping CanEditRowAtIndexPath = { _, _ in false },
                canMoveRowAtIndexPath: @escaping CanMoveRowAtIndexPath = { _, _ in false }
            ) {
            self.animationConfiguration = animationConfiguration
            self.decideViewTransition = decideViewTransition
            super.init(
                configureCell: configureCell,
               titleForHeaderInSection: titleForHeaderInSection,
               titleForFooterInSection: titleForFooterInSection,
               canEditRowAtIndexPath: canEditRowAtIndexPath,
               canMoveRowAtIndexPath: canMoveRowAtIndexPath
            )
        }
    #endif

    var dataSet = false

    open func tableView(_ tableView: UITableView, observedEvent: Event<Element>) {
        Binder(self) { dataSource, newSections in
            if !dataSource.dataSet {
                dataSource.dataSet = true
                dataSource.setSections(newSections)
                tableView.reloadData()
            }
            else {
                // if view is not in view hierarchy, performing batch updates will crash the app
                if tableView.window == nil {
                    dataSource.setSections(newSections)
                    tableView.reloadData()
                    return
                }
                let oldSections = dataSource.sectionModels
                do {
                    let differences = try Diff.differencesForSectionedView(initialSections: oldSections, finalSections: newSections)

                    switch dataSource.decideViewTransition(dataSource, tableView, differences) {
                    case .animated:
                        // each difference must be run in a separate 'performBatchUpdates', otherwise it crashes.
                        // this is a limitation of Diff tool
                        for difference in differences {
                            let updateBlock = {
                                // sections must be set within updateBlock in 'performBatchUpdates'
                                dataSource.setSections(difference.finalSections)
                                tableView.batchUpdates(difference, animationConfiguration: dataSource.animationConfiguration)
                            }
                            UIView.performWithoutAnimation {
                                if #available(iOS 11, tvOS 11, *) {
                                    tableView.performBatchUpdates(updateBlock, completion: nil)
                                } else {
                                    tableView.beginUpdates()
                                    updateBlock()
                                    tableView.endUpdates()

                                }
                            }
                        }

                    case .reload:
                        dataSource.setSections(newSections)
                        tableView.reloadData()
                        return
                    }
                }
                catch let e {
                    dataSource.setSections(newSections)
                    tableView.reloadData()
                }
            }
        }.on(observedEvent)
    }
}
#endif


Use set for ordered env

Since there is a number of contains calls agaist ordered env it would make sense to use set here to make it a bit faster.
At the same time since order is important linkedhashset will help here

Thanks for taking a look


[loc][Query][TypeScript] Localizability of 0; "OrganizeImportsFailureMessage"

Hi,
please help localization team to answer question from translator.
In case translator is not sure about context/meaning/localizability of string we raise a question to Core team.
Please re-assign back to use in case you are not the right contact person or you can´t assign to a proper person.
Can you help please?
Thanks!
Source:
Failed to organize imports
File Name:
LanguageService\TypeScriptLanguageService\bin\Release\localize\ENU\Microsoft.CodeAnalysis.TypeScript.EditorFeatures.dll
Resource ID:
0; "OrganizeImportsFailureMessage"
Query:
Does it refer to "Import statements"?

Does it refer to "Import statements"?

yes.

Thanks for confirming.


EVP_PKEY_keyGen for RSA hangs if pub exponent invalid

Setting rsa public exponent to invalid value such as 1 or 2 or 4 causes EVP_PKEY_keygen to hang.
    BIGNUM *bn = NULL;
    EVP_PKEY *pkey = NULL;
    EVP_PKEY_CTX *ctx = EVP_PKEY_CTX_new_id(NID_rsaEncryption, NULL);
    EVP_PKEY_keygen_init(ctx);
    BN_hex2bn(&bn, "02");
    EVP_PKEY_CTX_set_rsa_keygen_pubexp(ctx, bn);
    EVP_PKEY_keygen(ctx, &pkey);

With which OpenSSL version / branch is this happening?

Issue observed on master branch

Looks like this would also occur in 1_1_1..


Post question allow sub-subject not matching subject

@avivz450 About this bug, (which I'm also working on) I came to the conclusion we should override the is_valid method of the QuestionForm, and check there if the sub_subject matches the subject. One thing though is that I need to add a way to distinguish between different is_valid errors. because as for now, when is_valid fails it prints an error message about the page number limit.

Maybe you should implement the method clean_sub_subject in home/forms.py and check there if there is a good match.
if there isn't, you can raise ValidationError.
You can see clean_email method for an example in the SignUpForm - https://github.com/avivz450/A-GBusinessesPromotions/blob/main/App/forms.py

Good idea thanks!


Methods anntotated with @PreDestroy throw exceptions.

I am deploying a project using spring-cloud-openfeign on a Glassfish (Payara 5) application server. During deployment I get the following exception:
Exception while deploying the app [xyz] : The lifecycle method [destroy] must not throw a checked exception.
Related annotation information: annotation [@javax.annotation.PreDestroy()] on annotated element
[public void org.springframework.cloud.openfeign.FeignAutoConfiguration$HttpClientFeignConfiguration.destroy()
throws java.lang.Exception] of type [METHOD]

The lifecycle method [destroy] must not throw a checked exception. Related annotation information:
annotation [@javax.annotation.PreDestroy()] on annotated element
[public void org.springframework.cloud.openfeign.FeignAutoConfiguration$HttpClientFeignConfiguration.destroy()
throws java.lang.Exception] of type [METHOD]

[...]

Glassfish seems to check all included classes for validity, including classes from libraries within the WAR file. In this case, it refuses to proceed, because there are instances, where methods annotated with javax.annotation.PreDestroy throw exceptions. I looked into this, and found two instances:
https://github.com/spring-cloud/spring-cloud-openfeign/blob/4120ca2bc634d2ec76523da5442a1defdf93a97d/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/clientconfig/HttpClientFeignConfiguration.java#L105-L111
https://github.com/spring-cloud/spring-cloud-openfeign/blob/4120ca2bc634d2ec76523da5442a1defdf93a97d/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignAutoConfiguration.java#L144-L150
Looking at the documentation for @PreDestroy I found the following:

Note: A PreDestroy interceptor method must not throw application exceptions, but it may be declared to throw checked exceptions including the java.lang.Exception if the same interceptor method interposes on business or timeout methods in addition to lifecycle events. If a PreDestroy interceptor method returns a value, it is ignored by the container.

If the method throws an unchecked exception it is ignored except in the case of EJBs where the EJB can handle exceptions.

My understanding is, that in general, any method annotated with @PreDestroy should not throw exceptions, and if it does, it is ignored in most cases. I tried replacing the two mentioned classes with version where I caught the exception in a try-catch block, and removed it from the signature. I was successfully able to do the deployment with this modifcation.
Would it be possible to include this modification in the upstream? I am aware that using this framework on Glassfish is more of a border case, since GF has JAX-RX. Thank you for your consideration.

Thanks for the quick reaction and the fix! Looking forward to the release!


mini.ai add another object matching rule?

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.ai
Description
given the text:
"aaa"bbb"ccc"

when the cursor is on the middle b, i want to use di" to delete the three b characters
mini.ai delete three c characters instead
i know that mini.ai groups the first and second quotation marks as one pair, and the third and fourth quotation marks as another pair
but i prefer the original, slightly dumber behavior, as it's more intuitive
it is also more user-friendly for cases like case "$(printf "%s" "$arg")" in...
users can still delete the three c characters via next/last prefix

This is already possible with custom_textobjects. To change textobject with id " to use regular 'from " to "' matching without balancing, use the following:
require('mini.ai').setup({
  custom_textobjects = {
    -- Match without balancing
    ['"'] = { '"().-()"' },
  },
})


notify user that hotkey is not registered

This PR notifies the user if the hotkey is not registered during btcli stake and btcli unstake calls

Closing to properly rebase on finney


[Getting Started][Installation]

Please confirm

[x]  I am running the latest version of this plugin

Hi, I am just trying to install and use telekasten.nvim for the very first time.
Here are some notes:

It seems that Installation is missing an Apostrophe.

I am not a 100% sure about this but the it feels that the ( parenthesis )  in the Base-setup section should be  { Curly Brackets} .

FROM this:

require('telekasten').setup(
  home = '~/zettelkasten', -- Put the name of your notes directory here
)

To this??
require('telekasten').setup{
  home = '~/zettelkasten', -- Put the name of your notes directory here
}

Thanks for creating this. I am excited to use this plugin.

Indeed. Thank you for reporting this. I made a few major edits to the doc last week to simplify the onboarding process for new users. There might be some other typos hiding here and there. Do not hesitate to report them or propose a PR to fix these.


Address image builder COPY idiosyncrasy

What this PR does / why we need it:
Modifies the Dockerfile to adapt to the imagebuilder idiosyncrasy wrt COPY command in a Dockerfile.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # ose-kubefed builds
Special notes for your reviewer:
Comments in the Dockerfile should explain the issue at hand.

/assign @pmorie

/lgtm


[SPARK-8879][SQL] Remove EmptyRow class.

As a baby step towards no megamorphic InternalRow.

Merged build triggered.

Merged build started.

Test build #36743 has started for   PR 7277 at commit 594100e.

Test build #36743 has finished for   PR 7277 at commit 594100e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.