Modified Apache 2.0 License is detected as default Apache

See https://github.com/wg/wrk/blob/master/LICENSE
Github displays this as the default "Apache License 2.0" even though the title of the license clearly says "Modified", and there are additional terms within the license text.  This can result in users being surprised later on if the author attempts to exert their rights from the additional clause, because with how Github makes their "project is licensed under the X license", many users may not see the change in the license text.
Thanks for considering!

There's one term added:

{+(e) If the Derivative Work includes substantial changes to features+}
{+          or functionality of the Work, then you must remove the name of+}
{+          the Work, and any derivation thereof, from all copies that you+}
{+          distribute, whether in Source or Object form, except as required+}
{+          in copyright, patent, trademark, and attribution notices.+}

Current version of licensee does obtain a false positive:

$ script/git-repo https://github.com/wg/wrk
License file: LICENSE
License hash: bd7a4313aa73d2af6278b3fc4a0ae083b490a003
License: Apache License 2.0
Confidence: 98.44%
Method: Licensee::Matchers::Dice

A few possible fixes that would be relatively easy:

Check for required string present in Apache-2.0 (eg "Version 2.0, January 2004"), similar proposed at https://github.com/benbalter/licensee/issues/191#issuecomment-302187397 but not yet implemented
Make similarity (% of words in common) increase with wordcount (currently 95%, making it easier for longer licenses to get false positive matches like this one); getting right factor would require fiddling
Different attack on false positives for long licenses without changing % words in common: reject match if absolute number of words is different; again getting this right would require fiddling

(Longer term it might be interesting to implement a different matcher leveraging the SPDX markup of license texts, which indicates parts that are optional or templated.)

I'd prefer 100% match of the license, not 95% or 98%. Just eliminate false positives completely.
Either it is the Apache License, Version 2.0 or it is not.
The suggestion for people to apply the Apache License 2.0 to their own work is to refer to the license in the header of each source file, not to change the license.
http://www.apache.org/licenses/LICENSE-2.0.html#apply

I'd also prefer to eliminate false positives completely by requiring a 100% match (at least for non-templated licenses). I've not tried this yet as it would require substantial test changes, at the least.

The project https://github.com/wg/wrk still is advertised as being licensed under Apache 2.0 license, which it is not.
How does #198 fix this issue for this project?

This is fixed on master for https://github.com/wg/wrk, and should be eventually updated on GitHub:
➜  licensee git:(master) script/git-repo https://github.com/wg/wrk
License file: LICENSE
License hash: bd7a4313aa73d2af6278b3fc4a0ae083b490a003
License: Not detected

Thanks for the update. I'd prefer to keep this one open until it's visible. I'll keep an eye on it.

It has now been 28 days and the project still shows as being licensed under Apache 2.0.
https://github.com/wg/wrk/blob/master/LICENSE and https://github.com/wg/wrk both show this.
It is not.
What are the plans to update this incorrect information?

Reopening in light of https://github.com/benbalter/licensee/pull/205#issue-238585162.

This issue is still fixed. FCPL false positive for MPL-2.0 is another issue, opened #207 for that.

It has now been 40 days and the project still shows as being licensed under Apache 2.0.
https://github.com/wg/wrk/blob/master/LICENSE and https://github.com/wg/wrk both show this.

@clr-apache this is the bug tracker for an open source project. If you have a question about a feature on GItHub.com, please contact GitHub support.

@benbalter sorry about that. my issue is with github not your tool.


Cannot launch multiple-module/service apps

#474 configured the launch of dev_appserver to only start a single module instances as the stock JDT socket listener IVMConnector only accepts only the first connection.  This behaviour will be a limitation for debugging apps with multiple services.  We should extend or write a new IVMConnector that continues to accept new incoming connections from debug JVMs, allowing a launch to connect to multiple JVMs.

#473

Work in progress: https://github.com/GoogleCloudPlatform/gcloud-eclipse-tools/tree/wip-498
Turns out the underlying Eclipse JDT/Debug doesn't support multiple connections on a listening socket.  Although it's straight-forward to fix, we're stuck with the status quo and need a workaround.
It seems the max_module_instances may still be useful to keep as hitting a breakpoint and then receiving another connection causes dev_appserver to launch a new instance.  So you end up with a number of instances.
It would also be nice to leverage any information from the launched JVMs to create meaningful labels.  Ideally that would include the service name.

In creating the Eclipse bug report, I realized that rather than connection argument multiple:

It might be more flexible to use "count" with an integer, defaulting to 1, with 0 being unlimited

That would allow a launch to accept up to 5 connections, but no more.  And count = 1 is the current behaviour.

@briandealwis I am trying to understand this issue: with the fix #609, it looks like we support launching multiple modules (or JVM?) for local debug run. You also said just above that

It seems the max_module_instances may still be useful to keep as hitting a breakpoint and then receiving another connection causes dev_appserver to launch a new instance. So you end up with a number of instances.

and currently, we do limit the number of modules to 1:
https://github.com/GoogleCloudPlatform/google-cloud-eclipse/blob/master/plugins/com.google.cloud.tools.eclipse.appengine.localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/server/LocalAppEngineServerBehaviour.java#L177
So, is it that we have an infrastructure set up for accepting multiple connections (JVMs?) in local debug run, but we aren't really allowing multiple connections yet?

So, is it that we have an infrastructure set up for accepting multiple connections (JVMs?) in local debug run, but we aren't really allowing multiple connections yet?

That's right: I restored it in #657 as you get some confusing behaviour when hitting a breakpoint.  If you're using a browser to invoke the endpoints, browsers will oftentimes test-fetch the URL; since the existing request hasn't completed, the dev_appserver launches a new JVM to handle the test-fetch.   We need to provide some UI to allow the user to change the max-instances.

Got it, thanks.


merge tests from sql.py into nipaptest.py

I have no personal travis, with these changes the tests seem to pass against master.
This is so I can add more tests later to fix #401.

It seems most tests are inside nipaptest.py. Perhaps the file sql.py should be dropped as a whole? or are there specific tests in there that might need to be moved?

@giganteous please take care of the indentation errors pointed out by @houndci-bot - i.e. non-multiple of four.

Thanks for the nudge. I suppose the noisy reports about long lines are.... somewhat noisy? If you have suggestions for those, I might be able to fix it.

LGTM


TedJDH Dataset in Binary?

Dear Ryan,
I very much appreciate your work on this project.
We've been trying to work with Ted Underwood's dataset, but it appears that all the .txt files are actually binary?
This is the case both on the Google Colab Notebook, as well as when we downloaded it to disk and unzipped it.
Is there a special trick to this dataset?
Is the zip somehow encrypted?
Your help is very much appreciated.
Thanks,
Thomas
This is a snippet from the output, when calling text.txt in the notebook:
VVzhAfNWțlC8T�U=L$^3Q<ƗdoPyыp4Wҹ* jfPP֕nMݵ
c@?_bePs=
~͵9L<vd)b;Ool
L5)z]b~A(>i>vFě>ZgjbPn{}LV3=Pi]kJ0}M;̓Yq{+#Q-ӭï^U^6Tt4f6�N4o}~OV~[茩Y:{c>!fju@RI[t
"fM
͡³⥪,9`Ҩ/p|?QI@dGFdثNfুaJm&؍|A;m:A+toR}CͼBoBMEJ\5#cl!E}60
c;O<KFOg2-GtmLGΘ[\6ZPR̮gCCќ0ݒ
1TC3P^dbX/,%F3{]g{;?ݖ |ttfO
'0֟_[t8[fR{j	p2s>
."Lni7M럔ǷLA܌0s5ث6T\Ukh4_$4�T%&
Tɺ&vt$	(.9y:cb60pv}Ў
Jn)EhJPC_U3/=! I didn't realize the text files for this corpus were corrupted: wasn't sure why at first but it turns out they were actually gzipped, even though their extension didn't end with ".gz". I just de-gzipped them, and converted the line breaks to unix from mac (unrelated problem but was annoying), and reuploaded the files. I also regenerated and reuploaded the frequency count files, and I've always generated and uploaded the MFW and DTM default datafiles. The same dropbox link used before to download the texts is used, so all you'd have to do is delete your ~/lltk_data/corpora/tedjdh folder and let everything redownload. But better to update lltk if possible. I've just made a google colab here which shows it working I think: https://colab.research.google.com/drive/1hUaEzUu_OnOqGgONQVzfFOw-VNFki8GC?usp=sharing

Great news!
This means we can actually use this corpus in my seminar on stylometry.
We also noticed that the metadata wrt. the number of tokens in a document is typed as a string, which means it can't be queried.
What are your plans with this query language?
Is there documentation on it?


do not evaluate all templates with --template switch

try to fix #2765

Thanks for taking care of this!


Add back "DOC-2793: Add SSO note for Cloud Console login"

This reverts commit fb03219b41600155d0f66e42b4d182177bb96be8.

This change is

These changes were reviewed as https://github.com/cockroachdb/docs/pull/13163


Re-instate .gitattributes

In https://github.com/thephpleague/uri/commit/2daaa898a9952e7d33421909889c3f4c6130a8c6 "the library is now a metapackge" (though, I'm not 100% sure what that actually means due to https://github.com/thephpleague/uri/issues/146), numerous entries were removed from .gitattributes
However, https://github.com/web-auth/webauthn-framework/blob/v3.0/composer.json#L43 is requiring this package in a non dev environment, for usage in one of the files in a sub package https://github.com/web-auth/webauthn-framework/blob/v3.0/src/metadata-service/src/MetadataService.php#L109-L117
This means, including the package then adds a load of files to vendor that aren't really needed...
	new file:   league/uri/.php_cs
	new file:   league/uri/.scrutinizer.yml
	new file:   league/uri/LICENSE
	new file:   league/uri/benchmark/build.php
	new file:   league/uri/benchmark/http-create-from-components.php
	new file:   league/uri/benchmark/parse.php
	new file:   league/uri/composer.json
	new file:   league/uri/phpstan.src.neon
	new file:   league/uri/phpstan.tests.neon
	new file:   league/uri/phpunit.xml
	new file:   league/uri/src/Http.php
	new file:   league/uri/src/Uri.php
	new file:   league/uri/src/UriInfo.php
	new file:   league/uri/src/UriResolver.php
	new file:   league/uri/src/UriString.php
	new file:   league/uri/tests/DataTest.php
	new file:   league/uri/tests/FactoryTest.php
	new file:   league/uri/tests/FileTest.php
	new file:   league/uri/tests/FtpTest.php
	new file:   league/uri/tests/HttpTest.php
	new file:   league/uri/tests/RelativizerTest.php
	new file:   league/uri/tests/ResolverTest.php
	new file:   league/uri/tests/UriInfoTest.php
	new file:   league/uri/tests/UriStringTest.php
	new file:   league/uri/tests/UriTest.php
	new file:   league/uri/tests/WsTest.php
	new file:   league/uri/tests/data/hello-world.txt
	new file:   league/uri/tests/data/john-doe.vcf
	new file:   league/uri/tests/data/red-nose.gif

Can we re-instate the .gitattributes excludes for tests, dot files etc? IIRC, if you still require-dev include the package, you don't get the filtered output, so this shouldn't make any day to day actual difference for those that want all the other files

@reedy Indeed we could re-instate on based on the one present in the uri-component package.


[BUGFIX] Fix unique validation in Postgres

Unique validation fails on subscriber creation when using Postgres because $this->subscriber is an empty string.
https://laracatch.com/share/d145e815-16ba-4f60-9d90-98f19c35c65a

Thanks for your input @MaizerGomes, let me chat with @willselby tomorrow AM and we'll decide which approach to go with. Both seem perfectly valid, though yours is a little more verbose. Either way, I think the logic should be extracted to its own protected method within the SubscriberRequest class. I think this reduces visual debt and aids readability.

You're welcome.
Well, I think using the Rule class adds more readability and since it has been referenced in the official laravel documentation since version 5.3 I think is easier to understand what's going on if something goes wrong.
By the way, I was trying to figure out where the property "subscriber" in the request comes from.
When using the update method in the SubscriberController it gets filled with the id of the subscriber event though no "subscriber" value is being sent by the submit form.
Is this some laravel magic behind the scenes that I don't know about?
Am I missing something?

Well, I think using the Rule class adds more readability and since it has been referenced in the official laravel documentation since version 5.3 I think is easier to understand what's going on if something goes wrong.

Yes, I agree. The Rule class definitely makes things a little clearer and I think we should stick to the established Laravel conventions where we can. We'll go with that approach. Thanks for your input!

By the way, I was trying to figure out where the property "subscriber" in the request comes from.
When using the update method in the SubscriberController it gets filled with the id of the subscriber event though no "subscriber" value is being sent by the submit form.
Is this some laravel magic behind the scenes that I don't know about?
Am I missing something?

There's a little bit of Laravel magic going on behind the scenes here.
If you take a look in routes/web.php, you'll see that we declare a resourceful subscriber route:
$appRouter->resource('subscribers', 'Subscribers\SubscribersController');

This single declaration will generate multiple routes. Because we specify subscribers as our resource name, Laravel will generate the URIs around that. /subscribers/{subscriber} is the URI that gets generated for the PUT/PATCH update endpoint.
When we're in a FormRequest class, $this refers to our request object. You'll see that the base Request class contains the following magic method:
public function __get($key)
{
    return Arr::get($this->all(), $key, function () use ($key) {
        return $this->route($key);
    });
}

When we do $this->subscriber, the magic method is invoked. First, Laravel will check the request data array to see if a value exists under the 'subscriber' key. If no such value is found,  we resort to the closure to obtain a default. Inside the closure, we call:
$this->route('subscriber')

public function route($param = null, $default = null)
{
    $route = call_user_func($this->getRouteResolver());

    if (is_null($route) || is_null($param)) {
        return $route;
    }

    return $route->parameter($param, $default);
}

As you can see, this method will attempt to resolve the route that is attached to our request. If a route is resolved, it'll check for any route parameters that match the given key. In our case, we're looking for a route parameter called subscriber. As we established earlier, our URI does have a subscriber parameter (/subscribers/{subscriber}), so whatever value is passed in that segment of the URI is what will be returned.
tl;dr
subscriber is a route parameter and the value is pulled from there.


WFLY-19734 Remove accurateSize(true)

The default is false and true seems to be causing performance issues when metrics are frequently gathered

<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->

Wildfly issue links:

WFLY-19734

<--- END OF WILDFLY GITHUB BOT REPORT --->
More information about the wildfly-bot[bot]

Hello, FireBurn. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

/ok-to-test

Hmm - before we can merge this we're going to need to update some tests that rely on accurate metrics.


Automating webpage

I would like to create a script that could be run in CLI and open the website.
Please add DWOC label to it and assigne me this issue.

Can you explain its need
We already have our website hosted

Can you explain its need
We already have our website hosted

Can you explain its need
We already have our website hosted

yes sure, i will create a bash script , running which website will automatically open in web browser.
It will be helpful to those using  linux. It will enable users to open your website without even opening web browser. Run the script and wham!!!
website opens.
If you find it goot to go, assigne me this issue and add "DWOC and level-3 tags

Can you explain its need
We already have our website hosted

yes sure, i will create a bash script , running which website will automatically open in web browser.
It will be helpful to those using  linux. It will enable users to open your website without even opening web browser. Run the script and wham!!!
website opens.


Command warnings not showing up in ZAP

The UI warnings are not showing up in ZAP commands. See attached

https://github.com/project-chip/zap/pull/1206

fixed

https://github.com/project-chip/zap/pull/1206


Hii.. can i use angular mobile ui in intel xd and how???

Please post your support questions in the Intel XDK forum.


Inline attachments

Hi there
I needed inline-attachment support for a project, so I added it for myself, and thought it might make a good PR.
Inline-Attachment support has been added to Sendgrid, Mandrill, Mailgun, Postmark and SparkPost adapters.
Update: SMTP adapter also supported
At its core you just need to specify type: :inline when creating an Attachment, and all the rest will happen automatically.
Attachment.new("/data/file.png", type: :inline)

And the ContentID of the attachment will default to filename so in the above case, you can refer to the inline-attached image by using:

I've tested using all of the adapters listed above. Please let me know if you have any comments, or need me to change anything.
Kind regards
Theo

Hi Theo,
I'm on my phone.
I just want to quickly say thank you for the great effort!
I've scanned through the PR, it's mostly good. I'll go through it again on my desktop soon. Probably just nits so I might simply merge this and tweak the styles / implementation details myself.
Po

Thanks @princemaple - I'll wait for you and @stevedomin to discuss the handling of type: :inline|:attachment vs inline: true|false. I myself wasn't sure which approach to take.
I'll also commit some small fixes/changes on the back of your comments above.
I haven't looked at the SMTP implementation, but I can do that also today.

Thanks for the Approval.
I'm still working on adding inline-attachment support to SMTP adapter. Will push that as soon as I get it working 😄

@theodowling thanks for looking into it!

@theodowling nice work on the SMTP attachment!

Hi @princemaple, thanks for the comments. I've made the changes as requested.
Please let me know if there is anything else we need to update/change. I'm happy to help out 👍

I'm 👍, feel free to merge if you feel it's good to go @princemaple

@theodowling thank you very much for the great work. Merging now!

You would do well to update your documentation to mention the bit about the cid name being the filename. Even better to provide a simple example. (searching github bugs in a poor replacement for docs)

@blackham It's not very helpful to comment on a PR closed over 3 years ago.
It'd be better you filed an issue to tell us what troubled you, and how we can improve. Basically what you did with the comment. Even better you could send a PR to address the issue.

Sorry it was late. Let me try and explain and give you example code you might be able to use in the doc. Also sorry for commenting on an old bug.
It would have saved me some time last night if the text "Inline attachments by default use their filename (or basename of the path if filename is not specified) as cid, in relevant adapters." found in https://hexdocs.pm/swoosh/Swoosh.Attachment.html also gave a very basic example.
Just this would have been enough for the light bulb to go off.

Or better, I could have skipped most everything else in the docs and just looked at this example:
   new()
    |> to({user.name, user.email})
    |> from({"Red Skull"<EMAIL_ADDRESS>    |> subject("OTP QR Code")
    |> html_body("
Hello #{user.name}
 Here is your QR Code ")
    |> text_body("Hello #{user.name}. Please find your QR Code attached.\n")
    |> attachment(
      Swoosh.Attachment.new(
        {:data, Avengers.Accounts.OTP.qrcode_png(user)},
        filename: "qrcode.png",
        content_type: "image/png",
        type: :inline)
    )
    |> Avengers.Mailer.deliver

Maybe OTP (One Time Password) isn't the best in that example. Using "OTP" for anything but Open Telecom Platform in Elixir might be against some peoples religion.  But TwoFA.qrcode_png(user) is ugly. TwoFactorAuth.qrcode_png(user) or TFA.qrcode_png(user)?

Thanks for that. I'll update the docs to include your example.
Documentation PRs are always welcome.

Pushed more docs updates.


Fix session:table command generated output

Since there is separated command for old session table, this command should generate the new structure, isn't it?

Please send to 5.2.

Okay


Share Button Bug

The "share bounty" button on bounty posts leaves off the ".com" in the link produced.

For example:  "https://nostrbounties/b/naddr1qq9rzd3cxsmnsdpjxc6qygxs3jf3986ucff2jqtm75heppgxpvg8vcs2trxkjg5mx83h8m7vnupsgqqqw4rsxfs3dy"
I posted a bug bounty for this one.

hey! thank you for reporting it. I'll fix it asap ;)

Thanks!


Add CODE_OF_CONDUCT.md

can you please assign to me under hacktoberfest-accepted label

hey
i would like to work on this readme assign it to me under the hacktoberfest tags

Hey, please refer my other repos, I need something similar ,for this @Hriishikeshh


Fix azure provider breaking change

This PR fixes the failure due to https://pypi.org/project/apache-airflow-providers-microsoft-azure/8.0.0rc1/

Looks like there is a mypy failure, also could we add a screenshot of a successful DAG run (either local or on Astro Cloud)?

Looks like there is a mypy failure, also could we add a screenshot of a successful DAG run (either local or on Astro Cloud)?

I think it's because it was not released by then. Yep, let me deploy one more time. The DAG disappeared (as expected) . cannot screenshot the last successful DAG run


Reimplement #4541

Since PR #4541 is waiting for CNCF CLA check, I'm reimplementing it.

This change is

closes #4541


Conserving on computing square roots and divisions

The s_2 function has several calculations that are already done in the main code;  several of these involve divisions and square roots.  I would like to conserve on computing these, and am wondering, @rodluger , if this is something you have done in starry.  Some examples are:
k^2 = (1-(r-b)^2)/(4*b*r)
sqrt(1-r^2)
k_c = sqrt(1-k^2)
sqrt(1-(r-b)^2)

etc.
I could include all of these as variables in my Transit_Struct object, and just pass the object (which passes by reference/pointer) to the s_2 routine.  Or I could pass the individual variables.  But, I'm wondering if there is a more clever/elegant way to do this in which the two routines could share the variables and the computation.

@ericagol In C++ my flux-computing routines are actually class methods, so they always have access to the class variables (which include the variables you listed up top). So I never have to explicitly "pass" any of these to the functions. I don't know if it works the same way in julia, but passing the struct by reference to each function should be totally fine speed-wise.

I tried to implement this today, but there are some bugs occurring at boundary cases which I haven't tracked down yet.  And, the speed improvement is not significant (although that could be due to bugs).  This also makes the code a bit more difficult to read.

I'm closing this for now;  I can't seem to find the bug that's occurring, but the problem seems to be that df/dr and df/db become zero for small values of b.  This does not occur when I use the original version of s_2, but what is strange is that s_2 seems to be computed correctly, as well as its gradients.


build.sh dosen't work

since GTKSlide was merged

Working on makefiles

Makefiles almost perfect now, no longer an issue


⚠ ClamAV has degraded performance

In f070aad, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 87 ms

Resolved: ClamAV performance has improved in ceb7849.


kernel: Non-deterministic and very high ISR latencies

Describe the bug
Non-deterministic and very high ISR latencies.  Spinning...

If a connection establishes with a peripheral in vicinity, the Max. ISR latencies measured is very high, over 100 us.
Legend for the log message:
<inf> bt_ctlr_hci: l: 9, 8, 111; t: 46, 46, 95.

l: Radio peripheral ISR latency Current value of 9us, Minimum of 8us, Maximum of 111us.
t: Radio peripheral ISR CPU usage Current value of 46, Minimum of 46us, Maximum of 95us.
[2019-02-21 10:47:17.917] ***** Booting Zephyr OS v1.14.0-rc1-268-g8bd360fa14 *****
[2019-02-21 10:47:17.933] Bluetooth �***** Booting Zephyr OS v1.14.0-rc1-268-g8bd360fa14 *****
[2019-02-21 10:47:17.983] Bluetooth initialized
[2019-02-21 10:47:17.986] [00:00:0Scanning successfully started
[2019-02-21 10:47:17.991] 0.010,650] <inf> bt_hci_core: HW Platform: Nordic Semiconductor (0x0002)
[2019-02-21 10:47:18.001] [00:00:00.010,681] <inf> bt_hci_[DEVICE]: 61:bb:ca:fe:4b:d5 (random), AD evt type 0, AD data len 21, RSSI -49
[2019-02-21 10:47:18.014] [AD]: 1 data_len 1
[2019-02-21 10:47:18.016] [AD]: 3 data_len 4
[2019-02-21 10:47:18.023] core: HW Variant: nRF51x (0x0001)
[2019-02-21 10:47:18.222] [00:00:00.010,711] <inf> bt_hci_core: Firmware: Standard Bluetooth controller (0Connected: 61:bb:ca:fe:4b:d5 (random)
[2019-02-21 10:47:18.488] [ATTRIBUTE] handle 39
[2019-02-21 10:47:18.838] [ATTRIBUTE] handle 45
[2019-02-21 10:47:18.938] [ATTRIBUTE] handle 47
[2019-02-21 10:47:18.938] [SUBSCRIBED]
[2019-02-21 10:47:21.047] x00) Version 1.14 Build 0
[2019-02-21 10:47:21.051] --- 18 messages dropped ---
[2019-02-21 10:47:21.052] [00:00:00.996,032] <inf> bt_ctlr_hci: l: 9, 8, 111; t: 46, 46, 95.
[2019-02-21 10:47:21.061] [00:00:01.041,198] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 62, 46, 95.
[2019-02-21 10:47:21.068] [00:00:01.091,339] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 52, 46, 95.
[2019-02-21 10:47:21.076] [00:00:01.141,357] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 46, 46, 95.
[2019-02-21 10:47:21.085] [00:00:01.191,009] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 49, 46, 95.
[2019-02-21 10:47:21.093] [00:00:01.241,333] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 46, 46, 95.
[2019-02-21 10:47:21.101] [00:00:01.290,954] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 50, 46, 95.
[2019-02-21 10:47:21.109] [00:00:01.341,308] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 46, 46, 95.
[2019-02-21 10:47:21.116] [00:00:01.441,375] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 62, 46, 95.
[2019-02-21 10:47:21.124] [00:00:01.442,291] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 46, 46, 95.
[2019-02-21 10:47:21.133] [00:00:01.490,875] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 50, 46, 95.
[2019-02-21 10:47:21.141] [00:00:01.540,496] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 44, 44, 95.
[2019-02-21 10:47:21.149] [00:00:01.941,345] <inf> bt_ctlr_hci: l: 8, 8, 111; t: 46, 44, 95.
[2019-02-21 10:47:21.157] [00:00:01.990,966] <inf> bt_ctlr_hci: l: 9, 8, 111; t: 50, 44, 95.
[2019-02-21 10:47:21.165] [00:00:02.090,454] <inf> bt_ctlr_hci: l: 9, 8, 111; t: 44, 44, 95.

To Reproduce
Checkout 8bd360fa14a6fff0f09cdf574937a9493b39e095
Steps to reproduce the behavior:

Update samples/bluetooth/central_hr/prj.conf to append the following:

CONFIG_BT_CTLR_PROFILE_ISR=y

mkdir build; cd build
cmake -GNinja -DBOARD=nrf51_pca10028 ../../samples/bluetooth/central_hr
ninja
ninja flash
Open terminal, minicom -D /dev/ttyACM0, 115k200

central_hr asserts when scanning without any peripheral in vicinity.
Use iPhone 6S, LightBlue application and enable a virtual peripheral with heart rate service, then
Expected behavior
Console output as in v1.13.0, with acceptable ISR latencies of < 30 us.
***** Booting Zephyr OS zephyr-v1.13.0 *****
[2019-02-21 10:29:53.649] [bt] [INF] hci_vs_init: HW Platform: Nordic Semiconductor (0x0002)
[2019-02-21 10:29:53.655] [bt] [INF] hci_vs_init: HW Variant: nRF51x (0x0001)
[2019-02-21 10:29:53.659] [bt] [INF] hci_vs_init: Firmware: Standard Bluetooth controller (0x00) Version 1.13 Build 0
[2019-02-21 10:29:53.670] [bt] [INF] bt_dev_show_info: Identity: d2:06:aa:d5:f3:9a (random)
[2019-02-21 10:29:53.675] [bt] [INF] bt_dev_show_info: HCI: version 5.0 (0x09) revision 0x0000, manufacturer 0x05f1
[2019-02-21 10:29:53.683] [bt] [INF] bt_dev_show_info: LMP: version 5.0 (0x09) subver 0xffff
[2019-02-21 10:29:53.690] Bluetooth initialized
[2019-02-21 10:29:53.696] Scanning successfully started
[2019-02-21 10:29:54.304] [DEVICE]: 66:76:38:cf:3b:a6 (random), AD evt type 3, AD data len 24, RSSI -47
[2019-02-21 10:30:54.235] [DEVICE]: 67:9f:3b:76:38:3e (random), AD evt type 3, AD data len 24, RSSI -46
[2019-02-21 10:31:56.522] [DEVICE]: 61:bb:ca:fe:4b:d5 (random), AD evt type 0, AD data len 21, RSSI -64
[2019-02-21 10:31:56.529] [AD]: 1 data_len 1
[2019-02-21 10:31:56.530] [AD]: 3 data_len 4
[2019-02-21 10:31:56.555] Connected: 61:bb:ca:fe:4b:d5 (random)
[2019-02-21 10:31:56.605] [bt] [INF] encode_control: l: 6, 6, 6; t: 61, 61, 61.
[2019-02-21 10:31:56.655] [bt] [INF] encode_control: l: 6, 6, 6; t: 109, 61, 109.
[2019-02-21 10:31:56.705] [bt] [INF] encode_control: l: 6, 6, 6; t: 60, 60, 109.
[2019-02-21 10:31:56.756] [bt] [INF] encode_control: l: 6, 6, 6; t: 97, 60, 109.
[2019-02-21 10:31:56.761] [bt] [INF] encode_control: l: 6, 6, 6; t: 55, 55, 109.
[2019-02-21 10:31:56.805] [bt] [INF] encode_control: l: 6, 6, 6; t: 59, 55, 109.
[2019-02-21 10:31:56.810] [bt] [INF] encode_control: l: 7, 6, 7; t: 110, 55, 110.
[2019-02-21 10:31:56.855] [bt] [INF] encode_control: l: 6, 6, 7; t: 59, 55, 110.
[2019-02-21 10:31:57.056] [ATTRIBUTE] handle 39
[2019-02-21 10:31:57.058] [bt] [INF] encode_control: l: 6, 6, 7; t: 61, 55, 110.
[2019-02-21 10:31:57.306] [bt] [INF] encode_control: l: 6, 6, 7; t: 51, 51, 110.
[2019-02-21 10:31:57.356] [ATTRIBUTE] handle 45
[2019-02-21 10:31:57.358] [bt] [INF] encode_control: l: 6, 6, 7; t: 53, 51, 110.
[2019-02-21 10:31:57.506] [ATTRIBUTE] handle 47
[2019-02-21 10:31:57.508] [SUBSCRIBED]
[2019-02-21 10:31:57.607] [bt] [INF] encode_control: l: 6, 6, 7; t: 66, 51, 110.
[2019-02-21 10:31:57.612] [bt] [INF] encode_control: l: 16, 6, 16; t: 40, 40, 110.
[2019-02-21 10:31:57.706] [bt] [INF] encode_control: l: 6, 6, 16; t: 66, 40, 110.
[2019-02-21 10:31:57.712] [bt] [INF] encode_control: l: 11, 6, 16; t: 41, 40, 110.
[2019-02-21 10:31:57.755] [bt] [INF] encode_control: l: 6, 6, 16; t: 47, 40, 110.
[2019-02-21 10:31:57.805] [bt] [INF] encode_control: l: 6, 6, 16; t: 51, 40, 110.
[2019-02-21 10:31:57.856] [bt] [INF] encode_control: l: 6, 6, 16; t: 48, 40, 110.
[2019-02-21 10:31:57.905] [bt] [INF] encode_control: l: 6, 6, 16; t: 51, 40, 110.
[2019-02-21 10:31:58.006] [bt] [INF] encode_control: l: 6, 6, 16; t: 48, 40, 110.
[2019-02-21 10:31:58.056] [bt] [INF] encode_control: l: 6, 6, 16; t: 51, 40, 110.
[2019-02-21 10:31:58.155] [bt] [INF] encode_control: l: 6, 6, 16; t: 46, 40, 110.
[2019-02-21 10:31:58.205] [bt] [INF] encode_control: l: 6, 6, 16; t: 45, 40, 110

Impact
Showstopper, Blocker for supporting Bluetooth on nRF51 Series and critical for nRF52 series due to bad ISR latencies.
Screenshots or console output
Refer to the ones added in the description of the bug.
Environment (please complete the following information):

OS: Linux (Archlinux distribution) and  MacOS with HomeBrew
Toolchain: Native Archlinux distributed arm-none-eabi- toolchain, gcc version 8.2.0 (Arch repository)
Commit SHA or Version used: 8bd360fa14a6fff0f09cdf574937a9493b39e095

Additional context
None.

Attention: @andyross  and @pabigot towards kernel scheduling/timeout and nrf_rtc_timer.c changes respectively, since v1.13.0.

@pabigot reverting nrf_rtc_timer.c changes to 37fbff6179e8bca7e780a83771b974c5a71a647e reduces the latencies by ~50 us

@andyross and @pabigot, the nrf_rtc_timer.c  was lockless in v1.13.0. Do you think it can be made lockless for v1.14.0 too?

@pabigot reverting nrf_rtc_timer.c changes to 37fbff6 reduces the latencies by ~50 us

@cvinayak To clarify: you're saying that reverting my changes made in #12605 reduces latencies?
Odd.  My own experiments on the ISR timing itself showed significant decreases in locking with that rework, especially on nRF51.  It's not immediately obvious how the timer ISR could be at fault.
There are a lot more irq_lock() calls (hidden as spinlock uses; see #12537) throughout Zephyr now so it may be that the direct cause is something else that's affected by the duration of the clock maintenance code.
I'm not working Zephyr at the moment so will have to leave this to @anangl.

@cvinayak any chance you can add a testcase for this to be able to catch such regressions in the future?

@cvinayak are you sure about your commit? The one you reference is from @anangl (37fbff6) and doesn't seem to be related.

@cvinayak A timer ISR was never really lockless -- it has to call into the timeout system and out into arbitrary callbacks, all of which need synchronization.  Someone should definitely check the bisection though -- I agree that the referenced commit doesn't seem particularly relevant.

Oh, and to be clear:

There are a lot more irq_lock() calls (hidden as spinlock uses; see #12537) throughout Zephyr now

There really are not, and I'm not sure why you'd think so.  Synchronization in the spinlockification patch was almost entirely 1:1, and where it differed it was uniformly in the direction of reducing latency by breaking existing recursive irq_lock usage.  If we've regressed it's a bug and we should fix it.

There are a lot more irq_lock() calls (hidden as spinlock uses; see #12537) throughout Zephyr now

There really are not, and I'm not sure why you'd think so.

I was mixing two things, one being an unsupported assumption that since a lot of material was added/changed since 1.13.0, there would be more locks of any sort.  This command:
for d in kernel drivers ; do
  for h in v1.13.0 HEAD ; do
    echo -n "$d $h " ; git grep -P 'k_spin_lock|irq_lock' ${h} ${d} | wc ;
   done ;
done

shows the rough number of lock operations has decreased from 106 to 87 in in kernel, and increased from 68 to 98 in drivers.  That's consistent with your expectation that the total number has not increased since 1.13.0 (I think kernel is more representative than driver here), so thanks for calling that out.
But I also meant to indicate that if you're looking for an irq_lock you'll undercount them if you don't also look for spin_lock which didn't exist in 1.13.0.  Whatever's causing this regression might be due to changes under a lock that's now spelled k_spin_lock().

I'm sorry, I misread @cvinayak bisection report.  If reverting only the changes to nrf_rtc_timer.c between 37fbf fixes your latency problems, then that points to a pretty tight list of patches mostly from @pabigot (FWIW: these all look fine to me):
75f77db432 include: misc: util.h: Rename min/max to MIN/MAX
ac36886e62 drivers: nrf: timer: add inline qualifier where inlining is intended
084363a0dc drivers: timer: nrf: refactor for speed and correctness
71882ff8c4 drivers: timer: nrf: drop unnecessary counter mask
4b24e88fa4 drivers: timer: nrf: use irq_lock instead of spinlock

If you're reverting your whole tree to that, then I'd guess the more likely culprit is the spinlockification series.  Note that most of it should be bisectable independently (though IIRC there's a header dependency that @carlescufi discovered that has to be manually fixed) so you can zero in on the specific subsystem at fault.  That series "shouldn't" have changed latencies at all, it's just refactoring.

@cvinayak @andyross Some of the wakeups are explained in
https://github.com/zephyrproject-rtos/zephyr/issues/12542#issuecomment-455872935; in short even with default tickless the timeslicing infrastructure is default enabled.  Which is a mess because drivers like I2C are neither re-entrant nor threadsafe, so a timeslice that suspends a thread with a transfer in progress could introduce some very difficult to find.  A tickless system by default should have run-to-completion threads.  IMO.
Without knowing exactly what channel 0 measures I can't explain how you see 21 us lock durations, but I never saw anything greater than 2.88 us on an nRF51, nor did I see anything greater than 11 us before my changes.  Information about timing related to my changes to nrf_rtc_timer is in #12605.

even with default tickless the timeslicing infrastructure is default enabled

Timeslicing has always been "default y" in kconfig.  But it only affects threads that are at preemptible priorities, which aren't the default.  It did indeed get reworked along with the rest of the timing system during the churn last fall, but it's almost entirely orthogonal to tickless.
I'll admit I remain confused, though.  There really doesn't seem to be anything in that patch series that should impact latencies.  The locking strategy is basically the same.

Which is a mess because drivers like I2C are neither re-entrant nor threadsafe, so a timeslice that suspends a thread with a transfer in progress could introduce some very difficult to find misbehavior.

If a driver isn't reentrant or thread-safe, that is a serious bug in the driver and not a problem in the kernel...what I2C drivers are like this?

A tickless system by default should have run-to-completion threads. IMO.

I'm confused here.
Tickless, and timeslicing really don't have much to do with each other, except of course if you enable timeslicing you're going to get more timer IRQs than if you didn't.

@pabigot attached is the patch I used to profile the irq_locking in nrf_rtc_timer.c
From 44a8ede5526f011a9443aaef3aead53853ea5790 Mon Sep 17 00:00:00 2001
From: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>Date: Mon, 25 Feb 2019 16:24:39 +0530
Subject: [PATCH] drivers: timer: profile the irq_locking

Profile IRQ locking in nrf_rtc_timer.

Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>---
 drivers/timer/nrf_rtc_timer.c         | 2 ++
 samples/bluetooth/central_hr/prj.conf | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/timer/nrf_rtc_timer.c b/drivers/timer/nrf_rtc_timer.c
index ef202da355..b27075191e 100644
--- a/drivers/timer/nrf_rtc_timer.c
+++ b/drivers/timer/nrf_rtc_timer.c
@@ -139,6 +139,7 @@ void z_clock_set_timeout(s32_t ticks, bool idle)
 	u32_t cyc = MIN((1 + ticks) * CYC_PER_TICK, MAX_DELAY);

 	u32_t key = irq_lock();
+	NRF_GPIO->OUTSET = BIT(12);
 	u32_t d = counter_sub(counter(), last_count);

 	/*
@@ -176,6 +177,7 @@ void z_clock_set_timeout(s32_t ticks, bool idle)
 	}
 	set_comparator(last_count + cyc);

+	NRF_GPIO->OUTCLR = BIT(12);
 	irq_unlock(key);
 #endif
 }
diff --git a/samples/bluetooth/central_hr/prj.conf b/samples/bluetooth/central_hr/prj.conf
index e937bf405d..54f6215497 100644
--- a/samples/bluetooth/central_hr/prj.conf
+++ b/samples/bluetooth/central_hr/prj.conf
@@ -3,3 +3,5 @@ CONFIG_BT_DEBUG_LOG=y
 CONFIG_BT_CENTRAL=y
 CONFIG_BT_SMP=y
 CONFIG_BT_GATT_CLIENT=y
+
+CONFIG_BT_CTLR_DEBUG_PINS=y
--
2.20.1

Also attached are the logic16 data files with the measurements.
nrf_rtc_timer_profile.zip

I'm not sure who's working this (it isn't me; I'm not working Zephyr at this time), but I haven't seen progress and was curious so I spent a few hours looking at it.  Note that I can't replicate the environment: I don't have an iPhone, and I'm not seeing the [bt][INF] output.  So this is based on instrumentation alone.
IMO this instability is due to the requirement to align timeout deadlines to the 100 Hz system (tick) clock rather than use the native 32 KiHz RTC clock.  This alignment is not a cheap operation on the Cortex-M0.
The solution from #12605 was designed with the expectation that most timeouts were set through z_clock_announce(), so that the common case would be that z_clock_set_timeout would be invoked within one cycle of the last timer interrupt.  That is not the case with this application: the branch that is required to adjust the pre-calculated deadline is almost always entered, and the time it requires is apparently not always less than the previous solution as I had thought.  (There may be toolchain version impacts as well; I'm using gcc-arm-none-eabi-8-2018-q4-major.)
This is a problem because the Cortex-M0 needs to call __udivsi3 to perform the adjustment because CYC_PER_TICK is 327.  This call/return takes at least 3 us.  If SYS_CLOCK_TICKS_PER_SEC is set to 128 it drops to 0.18 us because the division is a simple shift.  It would be interesting to see if that change makes the real application behave better.
The application also frequently sets six or more timeouts in less than 1 ms, all of which require recalculating the deadline.  I've seen cases where four calls to z_clock_set_timeout() occur within 148 us.  Of those, two were invocations with ticks set to zero, so there might be an opportunity for optimization there (though it's not trivial).  There's also some potential for pre-calculating a fallback adjustment based on the assumption z_clock_set_timeout() is not interrupted before it reaches the locked region.  In the general case, though, the only way I see to reliably fix the delay is to eliminate the costly alignment operation.
If changing ticks-per-second to ensure CYC_PER_TICK is a power of two is not an acceptable solution, it may be appropriate to revert 084363a0dc2a4d339a16c63c5d817400ae469605 in whole or in part to make this work, with the understanding that other instabilities will reappear and that #12541 must be re-opened.

Is that consistent with this being a regression, though?  That division was in the old code too, and the clock settings were the same.
But the advice sounds sane to me: choosing the tick rate (which in tickless mode is an entirely arbitrary thing that just defines the units of timekeeping) to match the underlying clock for performance reasons seems like a good idea.

@andyross @nashif as requested @cvinayak has added a "To Reproduce" section in the main description

@cvinayak funnily I cannot reproduce the high numbers once connected, though I do see the assert if scanning without connection.
Scanning (after a while if not remote device found):
[00:00:20.015,563] <err> bt_ctlr_llsw_ctrl: assert: '!radio_is_ready()' failed
Connecting to another board running peripheral_hr:
[00:00:42.721,038] <inf> bt_ctlr_hci: l: 6, 6, 39; t: 44, 43, 109.
Connecting to iPhone:
[00:00:01.056,060] <inf> bt_ctlr_hci: l: 6, 6, 25; t: 49, 39, 104.
So worst case scenario I'm seeing is 39uS.

@SavinayDharmappa Please take a look at this.

Let's at least start with a reversion per the comments above, as that seems lowest risk.  Can you guys try the linked patch to see if that resolve the issue as @cvinayak reported?  If so, then that seems simple.  If not we'll have to try something else.
Unfortunately I have neither a nrf51 board or iPhone (though I can probably scrounge up the former) so local reproduction is going to take some work.

FWIW I have a very hard time believing that the irq_lock around that section of nrf_rtc_timer could be held for 105 us.  That's an extremely long time; the longest operation in that sequence is an integer division that's less than 5 us, and the longest I saw the lock held was less than 20 us.  So I don't think reverting just the changes to that file will resolve the issue completely.
I would believe there are other irq_lock occurrences that could be that long.

I don't disagree, but at this point we need to take what we can get.  @cvinayak can confirm, if it works we can merge and then fix it at our leisure.

Recent discussion in PR #14176 seems to indicate that it addresses this issue.  For anyone here who might have missed that, please reveiw.

Think we can close this one.  I opened #14577 to track the need for performance work in this ISR.  Please add notes there as needed.

I am running into this issue on Zephyr master (d045bd7673348db395e53b3d14c61d6742a25a06) in my own application on the nrf51_ble400 board. This application is set up as a BLE peripheral and has quite a few features enabled, including BLE security and and custom sensor driver than uses a GPIO interrupt. I have not yet gotten a chance to try to create a minimal example that reproduces the problem. The crash only occurs when a device is connected.
This is the log just before the crash, with CONFIG_BT_CTLR_PROFILE_ISR=y.  Spinning...

@lopsided98 do you have a master commit which was fine? could you check if v1.14-branch works fine for your application? I would try to bisect to find the commit beyond which the controller is seeing increased latencies. Is this reproducible in the vanilla samples/bluetooth/peripheral sample?
Thinking aloud, assuming the assert happened in an encrypted connection, the Radio ISR CPU time too seems to have increased, maybe changes in controller code too may be contributing to the increased overall CPU use. I should do some GPIO debug pin profiling to confirm the new numbers seem above.


proposal: Use PopupWindow to show context menu

Hi @farmerbb , now, Taskbar uses the activity to show the context menu, so it will overlap the below windows. Maybe we can use PopupWindow to show context menu, and fix this problem. When soft input view is disabled, the google pinyin input method will use PopupWindow to show the candidates content below input cursor.

If you don't mind, could you better explain the problem that this proposal would solve?  The context menu needs to remain an activity with its own window, etc. so that the Android window manager can place it in the freeform workspace independently of other activities.  I've never used PopupWindow myself, but the documentation suggests that they are meant to only appear on top of other activities, which wouldn't work for how Taskbar needs its context menus to function.
There's definitely room for refactoring how context menus work, though.  Currently ContextMenuActivity subclasses PreferenceActivity and inflates XML preferences to show it's items in a list.  It would be better to move this to a RecyclerView using a LinearLayoutManager and an adapter that generates the list items.

Actually, PopupWindow uses WindowManager.addView to show window, the same as UIHost. And the real MenuPopupWindow uses PopupWindow to show context menu. So in real simulating meaning, PopupWindow is a good candidate. The initial purpose to use PopupWindow to replace ContextMenuActivity is to fix the problem that when context menu showing, it covers up the following popup window, such as start menu window. Maybe I mislead the reason of the problem.


Issue in circuit breaker with SpringBoot3

circuitbreaker is not working as expected in spring boot3
application.yml
spring:
application:
name: gateway-service
cloud:
gateway:
routes:
- id: customer-service
uri: http://localhost:8092
predicates:
- Path=/customer/**
filters:
- RewritePath=/customer/(?.), /${path}
- name: CircuitBreaker
args:
routeId: service-fallback
name: service-fallback
fallbackUri: forward:/order/hello
statusCodes:
- 500
- 503
- 502
- id: order-service
uri: http://localhost:8090
predicates:
- Path=/order/hello
filters:
- RewritePath=/order/(?.), /${path}
logging.level.io.github.resilience4j: DEBUG
logging.level.org.springframework.cloud.gateway.filter.factory: TRACE
Dependencies used:
 org.springframework.cloud spring-cloud-starter-gateway

 org.springframework.cloud spring-cloud-starter-circuitbreaker-reactor-resilience4j

with spring boot 2.7.10 and cloud 2021.0.6, the request was going to order-service (http://localhost:8090) if http://localhost:8092 is down.
but after upgrading to spring boot 3.0.5 and cloud 2022.0.2, the request is going into a infinite loop and not going to order-service if http://localhost:8092 is down.

I have the same issue

https://github.com/spring-cloud/spring-cloud-gateway/pull/2918 should fix this problem  :arrow_right: either use version 4.0.5 directly or wait for the next spring-cloud-release.

HI, @Felixel42
I´m working with Spring Boot 3.1.6 and don´t working Circuit Breaker, ¿Do you know the versión Spring Boot is the correct?
Thanks.

@JO503688 see https://start.spring.io Spring Boot 3.2.3 and Spring Cloud 2023.0.0 or boot 3.1.9 and cloud 2022.0.5 both have the fix


[Feat] GitHub Actions for the script to run every morning

A github action needs to be programmed so that the script runs every morning, at 10:00am

Alright, I'll see when I can do this.


The Jetty launcher classpath may not be complete

I have troubles launching a sample project in Payara #315 so I thought I would try Jetty. However, it didn't worked out quite well: the persistence provider generally complains that it cannot find the persistence unit. The curious thing is the following console output:
Jan 17, 2017 1:11:25 PM org.hibernate.jpa.boot.internal.PersistenceXmlParser doResolve
INFO: HHH000318: Could not find any META-INF/persistence.xml file in the classpath

The file is present in src/main/resources/META-INF, so maybe it is not on Jetty's classpath for some reason?
I'm attaching the testing project - just run ./gradlew vaadinRun on it.
myvaadinapp.zip

Thanks, indeed the resources was not included properly on Jetty's classpath. That should be fixed now and the provided app should work with the next version of the plugin (provided you rememebr to add the Person bean to persistance.xml :wink: ).


Implement /api/v1/text/task/detection/content endpoint

This addresses #124.
No unit tests were added as most of the code is reused from the /api/v1/task/classification-with-text-generation endpoint was reused. We will add integration tests for this endpoint once we start working on these.

Agreed. I might have made something silly on the rebase. I'll look into it.


[BUG] Not able to use GUI through script

Describe the problem
When I try to look at a dataset through the GUI (doesnt matter if desktop or web) it doesnt show my dataset and tells me to load one to view it, which I did (view screenshot). However when I use the CLI and do a quickstart it works flawlessly.
Code to reproduce issue
import fiftyone as fo
import fiftyone.zoo as foz

# Load the CIFAR-10 test split
# Downloads the dataset from the web if necessary
dataset = foz.load_zoo_dataset("cifar10", split="test")

session = fo.launch_app(dataset)

System information

OS Platform and Distribution (e.g., Linux Ubuntu 22.04): Windows 11
Python version (python --version): Python 3.10
FiftyOne version (fiftyone --version): FiftyOne v0.23.2
FiftyOne installed from (pip or source): pip

Willingness to contribute
The FiftyOne Community encourages bug fix contributions. Would you or another
member of your organization be willing to contribute a fix for this bug to the
FiftyOne codebase?

[ ] Yes. I can contribute a fix for this bug independently
[ ] Yes. I would be willing to contribute a fix for this bug with guidance
from the FiftyOne community
[x] No. I cannot contribute a bug fix at this time

Note that if you're running the above code in a script (as opposed to from the REPL or in a notebook), then you must add session.wait(), otherwise the script will complete and then the App session will be immediately killed just after launching!
import fiftyone as fo
import fiftyone.zoo as foz

# Load the CIFAR-10 test split
# Downloads the dataset from the web if necessary
dataset = foz.load_zoo_dataset("cifar10", split="test")

session = fo.launch_app(dataset)
session.wait()  # block execution until App is closed if running in script


How to run my Angular application in IE-11 support ?

Which @angular/* package(s) are the source of the bug?
common
Is this a regression?
Yes
Description
Hi
I have developed angular application 12 version it is working good in Chrome and Mozila.
but  not working  Angular application in IE-11 support ?
by following this url for Angular run IE 11
https://dev.to/getamano/angular-8-x-9-x-internet-explorer-not-working-quick-solution-3ha7
error shows like this
Unknown error from PostCSS plugin. Your current PostCSS version is 8.3.6, but postcss-preset-env uses 7.0.36. Perhaps this is the source of the error below.
Please provide a link to a minimal reproduction of the bug
Unknown error from PostCSS plugin. Your current PostCSS version is 8.3.6, but postcss-preset-env uses 7.0.36. Perhaps this is the source of the error below.
Please provide the exception or error you saw
Hi
I have developed angular application 12 version it is working good in Chrome and Mozila.
but  not working  Angular application in IE-11 support ?

by following this url for Angular run IE 11

https://dev.to/getamano/angular-8-x-9-x-internet-explorer-not-working-quick-solution-3ha7

error shows like this

Unknown error from PostCSS plugin. Your current PostCSS version is 8.3.6, but postcss-preset-env uses 7.0.36. Perhaps this is the source of the error below.

Please provide the environment you discovered this bug in
No response
Anything else?
No response

Hi @petebacondarwin
I am using Angular version 12.0.5 version

Can you try like to delete the lock file and node_modules?
rm -rf node_modules package-lock.json
npm i

If the problem persists please provide the output of ng version and npm ls postcss.


Add token to component settings

Hello,
This issue about the possibility to give tokens/variables to the magic form component.
For example to have an email message corresponding to the "subject" field of the form, or adding the current date to the email subject, or defining the visitor email as the "reply-to" option see my  reply-to issue.
What do you think about it ? Actually, the component settings is a little too static.

Any update about this ?
I think about a way to dynamically define email recipients. That would allow to send the notification email to different addresses depending on the result of the form.
It would be useful for notification subject too, to make it dynamic.
Same for the group, that could depend on the result of the form instead of being static.

Have you seen the new events feature?
You can "intercept" the form submission and do your own logic.

Ah, I didn't see that, I will take a look.

You need to create a new plugin.
On the boot method, add:
Event::listen('martin.forms.beforeSaveRecord', function ($formdata) {
    // add your custom logic here
});

You can take a look at this plugin

Hello,
I looked at that new events, but I'm not sure it can do what I want.
I need to add the current date to the notification email subject, so I need to access to components settings as the subject of the notification message is done in the component.
the $formdata you have as argument only contains the form user data, I can't alter the email subject before sending it from here.
Another event like "beforeSendMail" is required with all mail object as argument to be able to alter before sending it.

Any update on this ? Concretely, I need to have the current date to all email subjects I send. Even with the new event system, I don't see how can I do that. It seems to be impossible without hardcoding the plugin actually.


Fix error in GCC 10.2.1

DecCu.cpp: In member function 'void DecCu::TaskDeriveDMVRMotionInfo(CodingStructure&, const UnitArea&)':
DecCu.cpp:172:92: error: call to non-'constexpr' function 'const _Tp& std::max(const _Tp&, const _Tp&) [with _Tp = int]'
  172 |       static constexpr unsigned scale = 4 * std::max<int>(1, 4 * AMVP_DECIMATION_FACTOR / 4);
      |                                                                                ^
In file included from c:\msys1021\include\c++\10.2.1\algorithm:61,
                 from c:\msys1021\x86_64-w64-mingw32\include\commonlib\CommonDef.h:54,
                 from c:\msys1021\x86_64-w64-mingw32\include\commonlib\contexts.h:54,
                 from BinDecoder.h:54,
                 from CABACReader.h:54,
                 from DecCu.h:58,
                 from DecCu.cpp:51:
c:\msys1021\include\c++\10.2.1\bits\stl_algobase.h:254:5: note: 'const _Tp& std::max(const _Tp&, const _Tp&) [with _Tp = int]' declared here
  254 |     max(const _Tp& __a, const _Tp& __b)
      |     ^~~

See comment. Will fix properly rather than with a workaround.


Select only single field

How to let select only a single field?
For example I can use onSelectionChanged to know the last value checked and I want to uncheck all other fields except the last one. How to achieve that?

Hi, I was just looking for a solution to this issue. Until now I've managed to find one, though it has some visual bugs that I've not gotten into fixing. What I did is the same solution you proposed. Here is a sample code:
 child: MultiSelectBottomSheetField(
              items: widget.items,
              isDismissible: false,
              searchable: true,
              title: Text(widget.question.question),
              buttonText: Text(
                widget.question.question,
                style: const TextStyle(
                  fontSize: 15,
                  fontFamily: "Poppins",
                ),
              ),
              onSelectionChanged: (p0) {
                final list = p0; // THIS IS THE MOST IMPORTANT PART FOR SINGLE OPTION
                setState(() {
                  for (var i = 0; i < list.length - 1; i++) {
                    p0.remove(list[i]);
                  }
                });
              },
              listType: MultiSelectListType.CHIP,
              onConfirm: (values) {
                _selectedQuestion = values.last.toString();

                widget.controller.text = _selectedQuestion.toString();
              },
              chipDisplay: MultiSelectChipDisplay(
                textStyle: smallerDefaultStyle,
                chipColor: paletePink,
              ),
            ),


Obtain values for secrets needed to run pipeline

USER_NAME
AZURE_CREDENTIALS
UNENTITLED_IBM_USER_ID
UNENTITLED_IBM_USER_PWD
ENTITLED_IBM_USER_ID
ENTITLED_IBM_USER_PWD
MSTEAMS_WEBHOOK

userName: ${{ secrets.USER_NAME }}

This should be the WASdev. This string is prepended like so for downloading https://raw.githubusercontent.com/${git.repo}

Service Principal

azureCredentials: ${{ secrets.AZURE_CREDENTIALS }}
export SUBSCRIPTION_ID=<subscription id for Azure WebSphere Collaboration Sponsorship
  It starts with 1970. You can get it from the portal>
export SP_NAME=20210512_IBM_SP
az ad sp create-for-rbac --name ${SP_NAME} --sdk-auth --role contributor --scopes /subscriptions/${SUBSCRIPTION_ID}

From GitHub actions docs:

When complete, the az ad sp create-for-rbac command displays JSON output in the following form (which is specified by the --sdk-auth argument):
{
  "clientId": "<GUID>",
  "clientSecret": "<GUID>",
  "subscriptionId": "<GUID>",
  "tenantId": "<GUID>",
  (...)
}

In your repository, use Add secret to create a new secret named AZURE_CREDENTIALS.

Paste the entire JSON object produced by the az ad sp create-for-rbac command as the secret value and save the secret.

I think I have now done this.  Let me know if it's not right.  Thanks.

@edburns @zhengchang907 Following secrets have been added: https://github.com/WASdev/azure.websphere-traditional.image/settings/secrets/actions

This can be closed, @git4rk .


Added split-cycleworkspaces dispatcher

Added a dispatcher to allow cycling through workspaces per monitor.
Usage:
bind = $mod, mouse_down, split-cycleworkspaces, prev
bind = $mod, mouse_up, split-cycleworkspaces, next

I've been using this for a while on my two monitor setup and it works great. I did some testing with 6, 8 and 10 workspaces, but I think is should work as is for any config.

Can you also update the readme with this new feature?

Can you modify the changeMonitor function to also use your getDelta function?

Thanks! Merging.


Add Module Command

Currently, only the GradeCommand supports adding a module to a student.
Considering teachers only grade students towards the end of the module, it is important to allow users to add modules to students without the grade.
Changes made in the PR include:

adding a ModuleCommand class to facilitate adding a module without a grade to the specified Person's list of modules.
adding a ModuleCommandParser class to parse the newly-added module command.
refactoring GradeCommand class such that it now

requires the specified Module to be present in the specified Person's list of modules.
has accurate JavaDocs

refactoring GradeCommandParser class to support the changes made to the GradeCommand class.
refactoring Person class such that it supports the changes and additions made in this commit.
adding new test cases for the following classes:

GradeCommand
GradeCommandParser
ModuleCommand
ModuleCommandParser
AddressBookParser

adding constants to CommandTestUtil class to facilitate testing.
refactoring toString method of Person class to include the module.
refactoring PersonBuilder class to include a module field.
refactoring public final fields of StudentId, Module and Grade classes to "value" to standardize across all attribute classes.
capitalising the I in studentId in PersonCard class and PersonListCard.fxml file to standardize across the rest of the code base.

Things of Note:

ModuleCommand and GradeCommand updates a student by creating a new Person object and replacing the student with the new Person object, similar to how EditCommand performs edits.
ModuleCommand and GradeCommand requires the prefix id/ for studentId input. This is not the case for the EditCommand, and we may need to consider whether or not to standardize the exclusion of the id/ prefix.
Similar to EditCommandTest, ModuleCommandTest and GradeCommandTest assumes that the studentId 99999999 does not exist in the typical address book.
A student's modules is still represented by an ArrayList, which may need to change to accommodate for Storage implementation.
Most if not all of the line changes not covered by tests are variable name refactoring which is trivial.

LGTM


support stark aggregation

first run
./stark_aggregation.sh yes

second run
./stark_aggregation.sh

C12 Stage Time Cost (38s)
Aggregation Stage Time Cost (51s)
Final Stage Time Cost (30s)
Recursive Snark Stage Time Cost (47s)
Full Process Time Cost (166s)

on chain verify gas  cost: 40w gas

AMD Ryzen 9 5950X 16-Core Processor
16G memory

this is for g16? @cyl19970726


Merge Failed for HH accounts

I use an app called duplicate check for Salesforce when I try to merge the HH accounts, an Error message appears.
Error Message: Merge Failed: Merge failed. First exception on row 0 with id -Acc ID - ;
first error: DELETE_FAILED, npsp.TDTM_Account: execution of AfterDelete caused by: System.DmlException: Update failed. First exception on row 0 with id -Acc ID -;
first error: SELF_REFERENCE_FROM_TRIGGER, Object -Acc ID - is currently in a merge operation, therefore a trigger can not update it.: [] (npsp) : []
I use NPSP Version 3.124

Hi @ShathaJ We don't provide support or issue troubleshooting here in Github. Please post in the NPSP Group in the Hub or more likely, open a support ticket with Salesforce as it appears you have other custom code or customization which is causing this issue. Thanks!


UserInfoEndpoint does not issue profile scope claims.

I am using authorization code flow in my asp.net core mvc client and try to obtain user's profile scope claims(given_name, family_name) by making a request to /connect/userinfo endpoint but it issues only sub claim, though logs show all profile scope claims were requested. I do not inject any custom IProfileService implementations, could you please point where is the error?
IDP logs:

Client configuration:
services.AddAuthentication(authOptions =>
            {
                authOptions.DefaultScheme = "Cookies";
                authOptions.DefaultChallengeScheme = "OpenIdConnect";
            }).AddCookie("Cookies")
            .AddOpenIdConnect("OpenIdConnect", oidcOptions =>
            {
                oidcOptions.SignInScheme = "Cookies";
                oidcOptions.Authority = "https://localhost:5001";
                oidcOptions.ClientId = "imgvwr";
                oidcOptions.ClientSecret = "secret";
                oidcOptions.SaveTokens = true;
                oidcOptions.ResponseType = "code";
                oidcOptions.GetClaimsFromUserInfoEndpoint = true;
            });

IDP configuration:
            public static class Config
    {
        public static IEnumerable<IdentityResource> IdentityResources =>
            new IdentityResource[]
            {
                new IdentityResources.OpenId(),
                new IdentityResources.Profile()
            };

        public static IEnumerable<ApiScope> ApiScopes =>
            new ApiScope[]
            { };

        public static IEnumerable<Client> Clients =>
            new Client[]
            {
                new Client
                {
                    ClientName = "imageviewer",
                    ClientId = "imgvwr",
                    ClientSecrets = { new Secret("secret".Sha256()) },
                    AllowedGrantTypes = { "authorization_code" },
                    RedirectUris = { "https://localhost:5000/signin-oidc" },
                    AllowedScopes = { "openid", "profile" },
                }
            };
    }

Claims are also defined on test users:
new TestUser
                    {
                        SubjectId = "818727",
                        Username = "alice",
                        Password = "alice",
                        Claims =
                        {
                            new Claim(JwtClaimTypes.Name, "Alice Smith"),
                            new Claim(JwtClaimTypes.GivenName, "Alice"),
                            new Claim(JwtClaimTypes.FamilyName, "Smith"),
                            new Claim(JwtClaimTypes.Email, "AliceSmith@email.com"),
                            new Claim(JwtClaimTypes.EmailVerified, "true", ClaimValueTypes.Boolean),
                            new Claim(JwtClaimTypes.WebSite, "http://alice.com"),
                            new Claim(JwtClaimTypes.Address, JsonSerializer.Serialize(address), IdentityServerConstants.ClaimValueTypes.Json)
                        }
                    },

Solved: I didn't call AddTestUsers method as following:
public void ConfigureServices(IServiceCollection services)
        {
            // uncomment, if you want to add an MVC-based UI
            services.AddControllersWithViews();

            var builder = services.AddIdentityServer(options =>
            {
                // see https://identityserver4.readthedocs.io/en/latest/topics/resources.html
                options.EmitStaticAudienceClaim = true;
            })
                .AddInMemoryIdentityResources(Config.IdentityResources)
                .AddInMemoryApiScopes(Config.ApiScopes)
                .AddInMemoryClients(Config.Clients)
                .AddTestUsers(TestUsers.Users);

            // not recommended for production - you need to store your key material somewhere secure
            builder.AddDeveloperSigningCredential();
        }

but it raises another question how authentication could succeed and I managed to login with alice user without AddTestUsers method call?


Conveying Extra Tool Functionality

There should be a way to convey that Iron Axes and above don't consume hunger and Diamond Axes and above don't consume durability when breaking vegetation.
Could also potentially do something similar with Pickaxes and strata, though that's a bit more obvious.
Hoes and getting seeds from grass?
Shears snipping Creepers?
There are probably others I can't think of right now.

I'm not 100% sure tooltips are the solution. but I definitely agree a way to convey this kind of info into the game would really help out making this game less dependent on wiki info. Maybe incorporate it into the achievements system? as that's already set to become a guide of sorts

I personally don't like tooltips, I would much rather the player fiddle around with an item/block to find out its uses and other small details like axes chopping grass without durability loss.

While a lack of hunger consumption might be noticeable due to the hunger bar not shaking, I don't think a new player would notice that the durability didn't go down a slither. You would have to break a lot of vegetation before noticing, and I don't think many people would waste durability doing that.
I've edited the issue to be more general about the problem, instead of limiting it to tooltips.


refactor of CommonJsRequireDependency to es6

What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
current tests should pass
If relevant, link to documentation update:
N/A
Summary
upgrade CommonJsRequireDependency to es6
Does this PR introduce a breaking change?
No

trigger rebuild for appveyor


[Application] Consistent actions on Sales / Purchase

Please provide fix on next BC14 cumulative update if possible.
Please update the purchase document pages having Send/Print/Mail action to the same structure as the sales pages. Code should be consistent between Sales and Purchase.
E.g. PAG 143 contains 'SalesInvHeader := Rec;' whereas the code on PAG 146 does not.

[ ] Available in BC14

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for submitting this issue. We will publish a fix for it in the next minor update for release 15.

Thanks for submitting this issue. We will publish a fix for it in the next minor update for release 15.


bottledwater service depends on both postgres and postgres-94 causing port conflicts

The bottledwater-json and bottledwater-avro services in the Docker Compose file has links to both the postgres and postgres-94 services. The postgres services both have a port mapping for 45432 on the host, which causes an error when starting bottledwater-json or bottledwater-avro.
bottledwater-json and bottledwater-avro should probably just link to postgres only, dropping postgres-94.

Thanks for this report!
I've been making a lot of changes to the Docker Compose setup as it's used in the test suite to automate setting up a test cluster, and some of them broke more normal uses of Docker Compose.  The problem you note was actually deliberate, but it does break the instructions in the readme :)  This is done for the Docker Compose "links" feature, so that the Bottled Water container can address whichever Postgres is running simply by the hostname "postgres". This works fine in the tests, which run docker-compose up --no-deps [service] and explicitly start just one of the Postgressen, but on the command line a simple docker-compose up bottledwater-json will attempt to start both, and fail because they attempt to bind the same host port.
As a workaround, I've submitted PR #106 which assigns different host ports to each Postgres service, so they no longer clash. This still means you'll end up redundantly running one more Postgres than you actually wanted, but that should be fairly harmless.

Ah, thanks for the detailed explanation here and PR #106! I was indeed trying to follow the README instructions.

I've just merged that PR so the instructions in the README ought to work now.  Do let me know if you're still having problems!


adcskiller: init at 0-unstable-2024-05-19

Description of changes

Python-based tool designed to automate the process of discovering and exploiting Active Directory Certificate Services (ADCS) vulnerabilities
https://github.com/grimlockx/ADCSKiller
Related to #81418
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Extend spec of Migrator.migrations/3

Hi 👋
Just stumbled across a dialyzer error because I used this function with a singular directory as an argument. Functions works thanks to List.wrap, but dialyzer is unhappy.
Best,
malte

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Add associate alerts workflow

Asana task: Associate alert workflow
Description
Add the workflow for associating a new PA Message with an alert and potentially importing some of it's attributes

@PaulJKim I see the recent changes to remove Edit but wanted to bump my most recent comments before those changes. There should be some state cleanup that can be done now that we can always assume the user is navigating to the page without an alert already selected.

@cmaddox5 Which comments are those? I'm not sure if I see/remember the ones you're referring to


Fix integration cli

Quick & dirty, but we need green tests!

LGTM

LGTM

I surrender and skipped both tests: I fail to understand why TestRunUnshareProc fails randomly.

https://www.youtube.com/watch?v=ywDZKfZ-iZA  :-)

LGTM


github: add missing v1-debian-component and arm64 tag

In the previous versions, v1-debian-component and
v1-debian-component-arm64 tag were always created.
With GitHub Actions, it follows as before.
NOTE: v1-debian-component and v1-debian-component-arm64 should point latest version of fluentd. e.g. v1.17.

Verified with forked one:
https://github.com/kenhys/fluentd-kubernetes-daemonset/actions/runs/9987812740/job/27603013691

https://hub.docker.com/repository/docker/kenhys/fluentd-kubernetes-daemonset/tags


v0.5.1 docs are broken

No docs available for v0.5.x, can see version switcher at https://docs.rs/axum-jrpc/0.4.0/axum_jrpc/

Fixed by a14496bc876b1c75345ba04c5bc31323cb71895f for 0.6.x and by 9b688e6923deac8be38bd1f4605e0b496eb97033 for 0.5.x


table dataViewMapping does not respect the name attribute of dataRole

Hi,
I have a dataViewMapping as below
{
    "dataRoles": [
        {
            "name": "category",
            "kind": 0,
            "displayName": "Style Field"
        },
        {
            "name": "latitude",
            "kind": 0,
            "displayName": "Latitude"
        },
        {
            "name": "longitude",
            "kind": 0,
            "displayName": "Longitude"
        }
    ],
    "dataViewMappings": [{
        "table": {
            "rows": {
                "select": [
                    {
                        "bind": {"to": "category"}
                    },
                    {
                        "bind": {"to": "latitude"}
                    },
                    {
                        "bind": {"to": "longitude"}
                    }
                ]
            }
        }
    }]
}

my understanding is that a dataRole name attribute is supposed to be bound to any field we assign to the data role.
so should be able to drag a field, say, long into dataRole with a displayName Longitude, which internally has name longitude
but, as shown in comparison of the 2 images below, my field has to have the name longitude in order for the dataview rows to be populated
here, where the field names do not match the dataRole names, the dataView rows is an empty array.

here, the array is populated.

what do i need to do in order for the dataRole name to be respected in the select => bind => to: name definition in the capabilities above?

Hm, re-uploading the data resolved this issue... is it possible the data was deleted in powerbi?

maybe, though in general the 'name' property of datarole in the capabilities is only so you can refer to it in the mappings. It doesn't have the be the same as your column name.


Bing image creator feature does not work (in chatbot)

Hi
Some users have access to the image creator over the chatbot. At least in jailbroken mode it does not work for me - only normally over the website.
Any idea how to implement that? Maybe its a special request in the backend.
Best regards

The feature is over a totally different endpoint and would need to be added to this library. You can see an implementation here: https://github.com/acheong08/EdgeGPT

Pull requests are welcome.

The feature is over a totally different endpoint and would need to be added to this library. You can see an implementation here: https://github.com/acheong08/EdgeGPT

Hmm im not sure, because i reverse engineered the image creator directly myself and added it to this code myself. But the chatbot image creator  feature should be able to do this over chat himself right?

Can be closed because it was implemented in #381


Tag tracing interface obsolete

The limited extensibility of interfaces within major releases makes tracing an ideal candidate to remove in the next major.
See PHOENIXCONTACT/MORYX-Core#59

With this Obsolete you introduced a lot of warnings. You should ignore them in every usage but is the application developer able to use the alternative right now? If not, the developer will get a lot of warnings in their application which cannot be fixed.

Trying to provide an intermediate alternative would have created more work than benefit. I removed the interface and switched to future.


added jacoco to pom.xml

This pull request includes a change to the pom.xml file. The change adds the JaCoCo Maven plugin to the project, which is a tool used for measuring code coverage. The plugin is configured to prepare an agent and generate a report during the test phase of the Maven build lifecycle.
Why
To address issue #17 in public repo
How
How is it doing what it does?
It is generating a HTML report
fixes #17

LGTM


In Address List Editor, change Copy to clipboard so it doesn't require manual intervention

Fix Export function as well.

Verified in prod


Create a stub for the persistent data store (annotations)

This stub will not write data to the disk, but should allow for the dummy API endpoints to be connected to real handlers. At this point the store will continue to return dummy data.

Closed by #21690


Trajectories with missing entries

Is it possible to cluster trajectories with missing entries?

Excuse the delay, no, not presently.


terminal position - configuration

This is really cool. It would be neat if you could define top or bottom of the terminal as a config option.

Hi @southpawlife ,
Thanks for your feedback.
I'll consider adding this feature in the coming version.

Hi again @southpawlife ,
The feature you requested is now available as part of release 1.1.0


ScaleDecodedVideoFrame Throws Exception: attempted to read or write protected memory

Hello Bogdanov,
Thanks for this amazing c# library. It works well for me overall. However, sometimes this ScaleDecodedVideoFrame method will throw the attempted to read or write protected memory exception. What went wrong here and how should I handle it? It is a very rare exception, but it did crash my program and the try catch block doesn't seem to catch it after all.
The original call is from the TransformTo(IntPtr buffer, int bufferStride, TransformParameters parameters) method in FFmpegVideoDecoder.cs
int resultCode = FFmpegVideoPInvoke.ScaleDecodedVideoFrame(_decoderHandle, videoScaler.Handle, buffer, bufferStride);
[DllImport(LibraryName, EntryPoint = "scale_decoded_video_frame", CallingConvention = CallingConvention.Cdecl)]
public static extern int ScaleDecodedVideoFrame(IntPtr handle, IntPtr scalerHandle, IntPtr scaledBuffer,             int scaledBufferStride);
Thank you so much for the answer!

Problem solved, with this solution, able to catch the exception. However it is still beneficial to know the root reason causing this!
The reason being that the exception happens outside the memory reserved by CLR. It happens within the unmanaged C++ code.
Here is the link for the solution to catch the exception:
https://airbrake.io/blog/dotnet-exception-handling/system-accessviolationexception
Hope this saves someone's day.

Did you find any further solution to this?
I have the same problem with the decode function. Sometimes it throws an AccessViolationException. I dont know why.
As I am developing under .net core I cannot use your solution, it might be better to fix it in the c++ library helper, but that goes beyond my knowledge...


feat: Handling of transaction fees 💲

Description
Currently we don't have implemented the handling of transaction fees. We need to implement.

Fixed by #313


Unable to bind selected value in px-typehead with angular 2 app

I'm trying to get the selected value in my px-typehead component that I have used in the angular app.
The docs of px-typehead says to use value: string to get the current value of the input (docs).But the searched element dosen't seem to bind with the [(ngModel)].
Codepen link  here
I also tried by changing the value to inputValue/input-value/[attr.input-value]

To be compatible with ngModel, custom elements need to provide ControlValueAccessor, which gives ngModel a way to set the value and listen to value changes. vaadin/angular2-polymer has formElementDirective that implements this for elements with iron-form-element behaviour (listening to valueChange/setting value). Others - including px-typeahead - need custom CVA implementation. See https://blog.thoughtram.io/angular/2016/07/27/custom-form-controls-in-angular-2.html for more.

@randyaskin  Thanks.Is there any working fiddle with px-typeahead and angular2

Not that I have, no.


Support line limit settings in error renderer

Fixes #9881

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #9885 (d83799e) into main (131f6c3) will increase coverage by 0%.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           main   #9885   +/-   ##
====================================
  Coverage    63%     63%
====================================
  Files       203     203
  Lines      9826    9826
  Branches   1564    1564
====================================
+ Hits       6243    6245    +2
+ Misses     3079    3078    -1
+ Partials    504     503    -1

Impacted Files
Coverage Δ

src/platform/errors/errorHandler.ts
67% <0%> (+1%)
:arrow_up:

@rchiodo thanks for reviewing it. This PR shows the limitation of our renderer API, including:

To support localization, we need to have an extension side, making the renderer "impure".
The activation sequence of the extension side and the renderer is not guaranteed, so the extension code and the renderer needs to do some sort of handshake to do the initial setup (this is probably not what we can avoid but it's painful).

With that said, the PR handles the line limit and localization supported properly. I will create an issue in VS Code side to track our requests for localization support for renderers.


Remove delete doc CI

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Removed rogue space from Example 1

OPS Build status updates of commit 922c4f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsOnlineLisCivicAddress.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


typo: verions -> versions

Source file server/src/config.rs contains a typo: verions -> versions

Thanks, fixed!


SubstitionAsset subsitite method name typo

https://github.com/aws/caws-blueprints/blob/8a58aa6e1e6152d42d9ceb65f1f2042ae5de33[…]ckages/components/caws-source-repositories/src/static-assets.ts
subsitite(subsitution: any): string {
guess that should be
substitute(substitution: any): string{

This is partially addressed. There are many different spellings.
subsitution substition substitite substitute substitution
Notably, the class itself SubstitionAsset.


"newi is not defined"

Hi,
I'm using the latested minified and bundled version but am getting a console error that "newi" is not defined.  Am I missing a dependency?
Thanks!

I must have deleted a space between new and i...

Seems that you have typo in your code. Anyway, console shows you filename
and line number of error location.
Bit of advice: do not use minified libraries in development, they are hard
to debug. You should only pack and minify scripts on production sites.
On 6 February 2015 at 11:46, Raymond Suelzer<EMAIL_ADDRESS>wrote:

Hi,
I'm using the latested minified and bundled version but am getting a
console error that "newi" is not defined. Am I missing a dependency?
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/mikeric/rivets/issues/444.


Convert gantry coordinate system from right handed (x positive to left) to conventional (x positive to right)

Description
The coordinate system is currently placed with a 0, 0 point near the SE corner of the gantry. The x axis is positive going west. Units are meters offset from 0,0
When we create data products available for download, we can convert to any coordinate system.
Further Suggestions / Request for Feedback
There are a few options

Change the coordinates used by the lemnatec scanner

this has been rejected in discussions w/ Ben, Bob Strand, and others

Change coordinate system on ingest. We could do this as the first step in meta-data processing.

something like x = -x + offset and y = y + offset.
requires @rjstrand (or someone at MAC) to establish a new 0,0 point and measure offsets.

Use the given coordinate system

the primary reason not to do this is that it means everyone has to understand this non-intuitive extra step.

Related issues

converting lemnatec meta-data to absolute geographic positions https://github.com/terraref/reference-data/issues/32
store camera location and field of view https://github.com/terraref/computing-pipeline/issues/101

@rjstrand assigned to you. This is different than what we agreed last week, but after working with the existing reversed coordinate system I realized that it is sufficiently difficult to implement that it would make it more error prone to have each person writing code in gantry coordinate system to understand and handle appropriately.

@dlebauer - can this issue be closed?

No, Ting Lee is working on this

@tingli3 - please give an update.

see #174


how to send message between origin_web and flutter_web

i wannt to refer flutter web like this

but i can not send message to flutter_url
how to make it?

Hi @yilingfeixian
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources.
You may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


fix wasm breaking when using plugin defaults

noticed wasm breaking when not supplying a font as bytes.
may be a better way to fix than bundling a font, bit unsure.

Yeah, ideally user wants to make a request on wasm, download font form some web location and supply it to the plugin. Bundling font into wasm binary increases binary significantly. But this is reasonable default, improvement 👍

@bytemunch oh, this will increase size of plugin :/

maybe it's better to take the font bevy includes as default font :) it's smaller than 197KB

yeah i think i'll pop it in a new issue and try get to it tomorrow, size is so important on the web


fix: update README example to avoid using experimental fs.promises

Description of changes
If you use the README's usage sample as-is in Node LTS, you'll get a warning about use of an experimental node API. This change updates the example to avoid the warning.
Pull request checklist

[x] PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
[x] PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
[x] (if applicable) Addresses issue: #0000
[x] Added relevant unit tests for your changes
[x] Ran yarn precheckin
[x] Verified code coverage for the changes made

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Define tests policy and method

https://medium.com/analytics-vidhya/how-to-test-flask-applications-aef12ae5181c
https://pythonhosted.org/Flask-Testing/

https://medium.com/analytics-vidhya/how-to-test-flask-applications-aef12ae5181c

Seems like a very good source, thanks!

https://pythonhosted.org/Flask-Testing/

will probably be useful as well.

Action items
In general, I think we should make the effort to:

Minimum 1 test per PR
Tests should cover the logic of its PR

This is of course dependent on the nature of the PR.

Once we'll integrate the client app, we should select the way we want to test it.

https://medium.com/analytics-vidhya/how-to-test-flask-applications-aef12ae5181c

Seems like a very good source, thanks!

https://pythonhosted.org/Flask-Testing/

will probably be useful as well.

Action items
In general, I think we should make the effort to:

Minimum 1 test per PR
Tests should cover the logic of its PR

This is of course dependent on the nature of the PR.

Once we'll integrate the client app, we should select the way we want to test it.

For each PR include at least 1 test, for simple (atomic) functions, and higher number of tests for complex functions (i.e. traffic control) for each test include:

a test code
each test should include a function documentation:

elaborated scenario, explaining the test flow
inline comments to explain implementation

@ordavidil can I add to the readme.md


Query subfield _id

I have a document like this in the db
I have tried some ways but I cannot query "category._id" like this:
Post::find()->where(["category._id" => "566625a4a84fb072f74b7072"])->all();
though the below query is possible
Post::find()->where(["_id" => "566e883fc38b63a4038b4660"])->one();
{ "_id" : ObjectId("566e883fc38b63a4038b4660"),
"category" : {
"_id" : ObjectId("566625a4a84fb072f74b7072"),
"name" : "ABC"
}
}
The question is does Yii2 mongodb support the former query?

You should typecast value of "category._id" to MongoID manually.

@klimov-paul
I have searched on google and it seems you are right. But the problem is in the new php MongoDB driver ( http://php.net/manual/en/set.mongodb.php ), there are no MongoID class, as I know. What should I do.

I figured out that the new php MongoDB has \MongoDB\BSON\ObjectID class instead.
Problem solved. Thanh you very much.


Resolves 457

Constants In IL Should Not Also Be Pointers

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@KyleMiles, can you confirm that aarch64 PC-relative add and adrp-based xrefs still work with this? Relevant code:
https://github.com/trailofbits/mcsema/blob/eb0ac39fb511e6bb4057261fbc79e1913f2d4ae9/tools/mcsema_disass/binja/xrefs.py#L77-L106
https://github.com/trailofbits/mcsema/blob/eb0ac39fb511e6bb4057261fbc79e1913f2d4ae9/tools/mcsema_disass/binja/xrefs.py#L128-L147

Locally with #472, #462 (this), and remill's #306 all merged, the maze for aarch64 re-compiles and runs.


Add rate limit config settings to the self-hosting configuration settings documentation

For self-hosters, there are server config settings defaultRateLimit and also defaultAuthRateLimit which need documentation.
Config settings are documented here:
https://www.medplum.com/docs/self-hosting/config-settings
It should be noted that if developers are hitting rate limits, it could be an indication of a suboptimal integration where each request is authenticating rather than reusing a token.

Add to config-settings.md
https://www.medplum.com/docs/self-hosting/config-settings


Outlook Calendar

Description:
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#3438
Example entry for configuration.yaml
calendar:
  platform: outlook
  client_id: [CLIENT_ID]
  client_secret: [CLIENT_SECRET]

Checklist:
If user exposed functionality or configuration variables are added/changed:

[X] Documentation added in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @TomMini,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Any reason why you are not using Office365-REST-Python-Client?

No other reason than not knowing it exists. I had a "problem', found some pieces to fix it, and the python-client wasn't in scope. I'll have a look into it though, thanx for pointing it out.

Ping any work on that in progress?

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.

Can you guys point me out whats wrong with this pull request? I don't understand why its being closed. Use it myself and works like a charm.

Good point, it looks like no one has ever actually reviewed this. My bad!

@fabaff have described what it need

Thanx, I'll look into making or adjusting a 3rd party lib. Can't use the one @fabaff mentions though because of the lack of OAuth2 support. Storing tokens sounds better than raw credentials to me. I'll give it a shot but you can close this PR for now.


Issues About Feature Outputs

Hi, there.
Can I ask you about why the outputs of the model are with four features, which return [f1, f2, f3, f4], and how the features work in the end, like plans use the flatten and SoftMax like Vits. I was also looking for the network arch, but I can't find it, would you offer it?
Lots of thanks.

ViT-CoMer, as a multi-scale backbone, shares a similar usage pattern with other similar backbones like Swin. You can refer to the network structure in vit_comer.py.


MAX17055 fuel gauge

I think I have fixed all the problems so this is ready for another look

ping?

Seems a little weird that this is in the sensors folder, but I don't really have a better suggestion.

Yes it seems to be where the chargers are.

Thanks Peter! Yes that resolved it and I've updated the pull request accordingly.

Thanks @sjg20