Please add more Result methods

So that eg, we can use these:
eg: Return result if not an error, otherwise raise a fairly generic exception:
x = result.unwrap()
eg: Return result if not an error, otherwise raise an exception with a specific description:
x = result.expect("Unable to initialise subsystem!")
Basically please, a lot more of the methods supported by Rust Results, in terms of methods:
https://doc.rust-lang.org/std/result/enum.Result.html
It isn't especially Pythonic, but it would allow much easier use of rust-like error-handling code and idioms. Also, people don't need to use those methods if they don't need them.

Adding .unwrap and .expect is a good idea. Other methods are less useful in Python, e.g. unwrap_or(default) can just be written as res.ok() or 'default'.

.unwrap_or lets you express a function like this:
def parse_int(s, default):
    try:
        i = int(s)
    except ValueError as ex:
        return default
    else:
        return i

Like this instead:
def parse_int2(s):
    try:
        i = int(s)
    except ValueError as ex:
        return Err(str(ex))
    else:
        return Ok(i)

Which then lets you use parse_int2() in a few Rust-like ways, with less boilerplate than you would need with parse_int().
eg:
i = parse_int2(s).unwrap()

or eg:
i = parse_int2(s).expect("Invalid parameter")

As well as:
i = parse_int2(s).unwrap_or(123)

In addition to the other methods present on in the Result class.

As well as:
i = parse_int2(s).unwrap_or(123)

That is the same as i = parse_int2(s).ok() or 123 though, and I'd say that the version with the or is easier to read and more pythonic. Don't you think?

"None" is also a valid return result for a function, so there's eg, a need to be able to do something similar to this:
Assuming that get_item is a wrapper for dict.item, except that it returns a Result value, with Ok(val) if the key was present in the dict, or Err("Key not found") if the item is not found (where Python would normally raise an IndexError exception).
If eg, our dict has a value like this: d = dict(test=None)
Then we'd expect git_item('test') to return Ok(None).
And we'd also expect for get_item(d, 'wat') to expect Err("Key not found").
So eg, there is a big difference between these two bits of syntax:

i = fetch_item(d, 'test').unwrap_or('DEFAULT')

i = fetch_item(d.'test').ok() or 'DEFAULT'

The first one (1) would return None (correct), but the second one would return 'DEFAULT' (incorrect).
A bit more technically/pedantically, it's a bit better to actually have an explicit Option type, rather using None (python) values to always mean the same as Rust's  "None" Enum value.
One big difference between Rust and Python is that Rust doesn't have the concept of None as a valid variable value (it uses Option instead), whereas None is a valid value for any variable. It depends on context whether "None" in Python can mean both "no valid value to return", or eg "string variable has not yet been assigned a string value".
I hope that makes sense.

Also if ok() returns any other "falsey" value like 0 or False, that would also cause problems.

This is a problem. In this example
>>> parsed = parse_int2("0")
>>> parsed
Ok(0)
>>> parsed.ok() or 123
123

This should be marked as a bug, not an enhancement.

You're all right.
I'm a bit busy now, but if someone would want to do a pull request, I'm happy to review and merge.


Fix game.forces to be LuaForce instead of LuaSurface

Thanks! This will be in the next minor version, releasing soon.


Adding support for args throughout covalent

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation, VERSION, and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

This PR will add supports for positional arguments along with keyword arguments throughout the repo in a more robust manner which will allow electrons to be defined with variable args and kwargs, add support for args in executors, reducing the size of transport graph, and a lot more changes rooting from the modifications.

These changes break the UI since a new argument has been added. Fixing the UI in this branch now.


How does versioning work?

Hello @toniblyx !
Last Thursday I was using Prowler, when I came with the option -V, which shows Prowler version.
I'm using Prowler with the master branch (v2.4.1) but the command outputs:
$ ./prowler -V
Prowler 2.4.0-07042021

I can see that the line in the code was edited on the date it says, then, what about git tags?
Thanks!

This is a embarrassing (for me) question, I need to see how to improve that tagging process and automate it. Any help is appreciated.

Hello @toniblyx !
I've been investigating how Prowler could use versioning a little bit better, do you happen to be familiar with these concepts:
https://www.toptal.com/software/trunk-based-development-git-flow
Trunk based & Git Flow ?
I think that we should first adapt how do we work with git and its branches, before modifying the -V option of Prowler.
Because the development flow we are using it's a little bit different than, for instance, gitflow. If we first (after v2.5) adapt to gitflow, then, I think that adapting or modifying the -V option would be easier. It could be just a git command such as:

git describe --tags --abbrev=0
or
git describe --tags

Any thoughts on it?
Cheers!

Since this is not a feature but more a versioning management issue, I'm closing it. We are going to improve this process for sure.


Add ListCheckContainerDetails

This adds the fly resources command requested in concourse/concourse#1149.
This PR is intended to go along with 2 other PRs:
concourse/fly#250
concourse/atc#295

@edtan Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@edtan Thank you for signing the Contributor License Agreement!

closing per https://github.com/concourse/fly/pull/250#issuecomment-416328924 - thanks again!


On Windows target forward slashes turn into native backward slashes.

Description of the issue. Please be specific.
On windows, bazel targets have the forward slashes turned into backward ones, hence they are not recognized, for example
Command: bazel query --tool_tag=ijwb:CLion --output=label_kind --keep_going same_pkg_direct_rdeps("//sdk\test\metrics:aggregation_test.cc")
What's the simplest set of steps to reproduce this issue? Please provide an example project, if possible.
Well, I know Windows is not officially supported, but all it takes is a repository with at least one sub-directory and target into it, and the IDE would show it with wrong slashes. Current workaround (in the IDE) only is to manually change them everytime, but certain operations cannot finish like the one above ^^^
Version information
CLion: 2021.3.4
Platform: Windows 10 10.0
Bazel plugin: 2<IP_ADDRESS>.1-api-version-213
Bazel: 5.0.0

Hello @malkia, Can you provide a minimal steps to reproduce the above issue . Thanks!

Sure. I've used https://github.com/open-telemetry/opentelemetry-cpp as example, did the defaults, and then went into
src/test/metrics/BUILD file
and selected the aggregation_test

right click, debug on it, and it shows this:

then I get

the workaround is to manually click on all backslashes, and make them into forward ones

then it can run bazel

I've also checked the plugin version, it's 2<IP_ADDRESS>.1-api-version-222 Oct 20, 2022
and my CLion is right now at 2022.2.4
Hope this helps.

@sgowroji Unfortunately I don't own any Windows devices so I can't reproduce/fix/verify, can we please reassign to those with Windows devices?


Full image or the cropped regions used in VG dataset?

Hi, thanks for your great work.
In your paper, you meaned that "we filter 5 out of 50 captions for each image according to largest areas of bounding box regions". In VG, the caption is for each bounding box region, so if you cropped the region to train or use the full image?

thanks for your question.
We save cropped regions as individual image-text pairs for training. We do not use the full image, but you can try it.
According to our experience, VG is not the most important dataset and its usage does not significantly influence the model performance.

BTW, do not use extremely small cropped regions, and it could hurt model performance.

Got it, thanks.


Code style fixes

I don’t usually see a lot of comparisons with assignments. Is there a PHP_CodeSniffer rule to toggle for this?

I kind of like writing like this. But I usually don’t in open source.
Also, taking every trick to reduce line count :)

This was just stylistic, merged straight up.


WIP: Fix Netlify Function compat layer

WORK-IN-PROGRESS — DO NOT MERGE
This PR will fix a few issues with the compatibility layer between Netlify Functions and Next.js.

~First, we copy over files from next-aws-lambda and remove that dependency.~ ✔
Then, we fix .writeHead to return the res object and enable chaining. That will resolve #74 (thanks for the test case, @afzalsayed96! It's the first commit in this PR 🙂)
Then, we catch any errors that occur after the res.end() has been called. That will resolve #82. I'm not sure if this is a Next.js bug, because the call of Buffer.byteLength(null) happens inside the serverless Next.js code. In any case, by catching and logging errors that occur after the response has ended, we can get around this until it is fixed upstream.
Then, we add netlifyContext to the req object, so that clientContext (for netlify identity) can be accessed in API routes and pages with SSR. That will resolve #20.

I'm splitting up this PR into multiple PRs. First one is here: https://github.com/netlify/next-on-netlify/pull/92


[BUG]  Safer Illinois Home screen is not updated

Describe the bug
Safer Illinois Home screen is not updated, when the user didn't verify his identity while onboarding and verified via "Connect your NetID" on the Safer Illinois Home screen.
To Reproduce
Steps to reproduce the behavior:

Install Safer app
University Student role is selected in "Who are you?" screen
Tap on "Not Right now" on Connect your NetID screen
Complete the Covid onboarding screen
Safer home screen is displayed.
Tap on Connect your NetID button
Enter the login credentials in the Shib screen and verify the student identity

Actual Result
As the user connected the app using the NetID, the Safer Illinois Home screen has to be updated. But it was showing the same information "Connect to Illinois"
Note - The setting screen has updated user information once the user verified his identity.
Expected behavior
As the user connected the app using the NetID, the Safer Illinois Home screen has to be updated
Screenshots
Home screen after the user connected the app via Net ID

The setting screen has updated after the user connected the app via Net ID

Additional NOTE
The same issue apply to Verify your Phone number
Smartphone (please complete the following information):

Device: [e.g. iPhone and Android]
Version - 2.10.18-prod.apk

Additional context
Add any other context about the problem here.

@Priyaravi8 @pmarkhennessy
I'm unable t reproduce it. Everything & everywhere related is reloaded accordingly. I have noticed only a slight delay due to several post login requests - but nothing more.
If that delay is the main concern - I would propose to show a modal loading bar during this process? What do you think?

@mdryankov - Today I am not able to reproduce this issue. But I see the following issue

Once a user connects the app using his Netid.
The home screen is updated Current status duplicated the info "Not Available". Please see the screenshot

.

@Priyaravi8, I was unable to recreate the both problems that you talk about in this GIT issue.
Regarding the second one (Status NA): This could happen if the RSA private key (the COVID-19 QR code) is not properly setup. Was this the case? I am also wondering what the Status panel shows in this case?

@mihail-varbanov  -  For the 2nd issue -

While covid onboarding RSA private key (the COVID-19 QR code) screen is not displayed.
Added the screen shot of Status panel.

Added the Screen shot of setting screen

@Priyaravi8 , it is clear way: "Missing COVID-19 private key", as I initially supposed. You have to import an existing private key for this user from other device, or reset it. Then the second issue should disappear.

@mihail-varbanov - From the users stand point, it would be better if we add a message like "import an existing private key from another device, or reset it" on the Safer Home screen instead of the current status displays the information "Not available" and too duplicated.

@Priyaravi8, the proper handling of missing/mispaired RSA keys requires much more than changing the message in Status widget from the Home panel. The situation is very similar to a user not being logged in because he/she cannot access his/her health history or status. So what I am trying to say is that the proper handling requires removing the health status widget or the access to Health history, as well as adding some new widget that is similar to COVID-19 keys section from Settings panel that allows loading/scanning/resetting COVID-19 key. In general we need to perform some behavior that is very similar to the one when the user is not logged in. This is a major change that requires app design update and time for development as this is not quick and simple.
My suggestion is to close this issue because it was opened for something totally different, and let the management decide whether they want the above update now.
CC @pmarkhennessy, @johnmpaul, @joegrohens

Closing this issue and open a new issue for -"missing/mispaired RSA keys" under the usability tag.


some confused

in bdf_cards_ctria3.cpp

in entry_type.h

bdf_cards_ctria3.cpp is easy to fix. Just move the closing bracket for else just before return and thus get rid of the goto.
I am not sure yet how to get rid of the possible problem in entry_type.h. Due to the way the entries are stored and processed the library relies on overloading the format(const void*)method.
I will generate a pull request for bdf_cards_ctria3.cpp.


Invalid object name when using the function diff_branch_file

I run the command :Telescope advanced_git_search diff_branch_file and get the following picker which says invalid object name.

If I select any branch, I always get the right side empty.

Also, I tried using another function like search_log_content and it worked properly

@lunfel Thanks for reporting the issue, can you try the linked PR?
https://github.com/aaronhallaert/advanced-git-search.nvim/pull/47

Wow thanks! That was really quick and responsive. Thanks for your efforts.
It seems like this fixed the issue. Here are some screenshots of it working.

Though, eere is the output when there are no change. I would suggest to add a small message to let the user know that there are no differences. At first glance, I thought it was broken, then I remembered that exit 0 means no error. I don't think this might be obvious to everyone so maybe adding a small message would be a nice touch.

Thanks again

Thanks! Good idea to replace the "Process exited 0". I'll have a look at it later.


SyntaxError: invalid syntax : "self.svc = SVC(**kwargs, probability=True)"

First of all, let me start by thanking you very much for all your hard work and dedication. Your work is truly magnificent.
I am trying to run the example from your instructions. I am getting the error:
File "C:\Python27\lib\site-packages\clairvoyant\model.py", line 22
self.svc = SVC(**kwargs, probability=True)
SyntaxError: invalid syntax
What could be the cause of this error ?
I am running Python 2.7.15

Do you have these dependencies installed?
bokeh>=0.12.4
matplotlib>=2.0.0
numpy>=1.11.3
pandas>=0.19.2
scikit-learn>=0.18.1

Specifically scikit-learn?

Hi Federico,
Thank you very much for coming back so quick. Yes, all the above dependencies have been met. I have the latest versions.

Hmmm a lot of these packages are dropping Python 2 support by December of this year. Can you try in Python 3?

Thanks for looking into it . This is working now .


batch size finder not running training steps after first batch size

When trying to automatically find largest batch size, only validation steps are taken. Eg:
model.batch_size = tuner.scale_batch_size(model, mode='power', init_val=1, steps_per_trial=3)

will run:
validation_step(batch_idx=0) #part of the sanity check code
validation_step(batch_idx=1) #part of the sanity check code
train_step(batch_idx=0)
train_step(batch_idx=1)
train_step(batch_idx=2)
Batch size 1 succeeded, trying batch size 2

validation_step(batch_idx=0)
validation_step(batch_idx=1)
Batch size 2 succeeded, trying batch size 4

validation_step(batch_idx=0)
validation_step(batch_idx=1)
Batch size 4 succeeded, trying batch size 8

etc. thus this will return a batch size much larger than the one that fits in memory during the train step.
The issue is in  pytorch_lightning/loops/fit_loop.py:
    def done(self) -> bool:
        """Evaluates when to leave the loop."""
        # TODO(@awaelchli): Move track steps inside training loop and move part of these condition inside training loop
        stop_steps = _is_max_limit_reached(self.epoch_loop.global_step, self.max_steps)
        [...]

The variable self.epoch_loop.global_step was not reset to 0 when attempting a new batch size. In this case, it will be 3 on batch size 2, returning True as the value of the done flag, and ultimately setting self.skip=True in pytorch_lightning/loops/base.py.
cc @akihironitta @borda @rohitgr7

this is not an issue anymore :)


Add support for stormpath.web.socialProviders.callbackRoot option

Add support for stormpath.web.socialProviders.callbackRoot option.

The library must implement provider callbacks for all social provider directories that are mapped to the specified Stormpath application. The callback URLs for each provider should take the form of:

/<stormpath.web.socialProviders.callbackRoot>/<providerId>

Where providerId  is the property that is found in the provider object of the Stormpath directory, e.g. google or facebook.

Part of https://github.com/stormpath/express-stormpath/issues/298.

FYI I've opened this, as I think we have more that needs to be addressed: https://github.com/stormpath/stormpath-framework-spec/pull/35

The framework spec was updated, please see here for the new structure:
https://github.com/stormpath/stormpath-framework-spec/blob/master/web-config.yaml#L196-L207


Barchart overflowing in each other

Example stackblitz
AppUrl
IDE url

Expected Behavior
What I would expect is that if you set the barThickness: 2 to a higher value that the bars wouldn't overflow in each other but keep space between each other.
Current Behavior
If you set the barThickness: 8 you get something like this, the bars are overflowing in each other. The chart is hard to read also.

Context
I'm showing around 1600 values splitted in to 7 categories. I want to show the values in a barchart so each to read for the user and to see what numbers are falling often.
Environment
I'm using angular
"dependencies": {
    "@angular/animations": "~9.0.6",
    "@angular/cdk": "^9.0.6",
    "@angular/common": "~9.0.6",
    "@angular/compiler": "~9.0.6",
    "@angular/core": "~9.0.6",
    "@angular/forms": "~9.0.6",
    "@angular/localize": "^9.0.6",
    "@angular/platform-browser": "~9.0.6",
    "@angular/platform-browser-dynamic": "~9.0.6",
    "@angular/router": "~9.0.6",
    "@ng-bootstrap/ng-bootstrap": "^6.0.0",
    "@ngx-translate/core": "^11.0.1",
    "@ngx-translate/http-loader": "^4.0.0",
    "bootstrap": "^4.4.1",
    "chart.js": "^2.9.3",
    "moment": "^2.22.2",
    "ngx-reactivetoolkit": "^7.0.0",
    "rxjs": "~6.5.4",
    "tslib": "^1.10.0",
    "zone.js": "~0.10.2"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.900.6",
    "@angular-devkit/build-ng-packagr": "~0.900.6",
    "@angular/cli": "~9.0.6",
    "@angular/compiler-cli": "~9.0.6",
    "@angular/language-service": "~9.0.6",
    "@commitlint/cli": "^8.3.4",
    "@commitlint/config-conventional": "^8.3.4",
    "@commitlint/config-lerna-scopes": "^8.3.4",
    "@types/node": "^12.11.1",
    "@nrwl/jest": "^8.11.0",
    "@types/jest": "^24.9.0",
    "codelyzer": "^5.0.0",
    "commitizen": "^4.0.3",
    "commitlint": "^8.3.4",
    "cz-lerna-changelog": "^2.0.2",
    "fs-extra": "^8.1.0",
    "husky": "^4.0.0",
    "jest": "^24.9.0",
    "jest-cli": "^24.9.0",
    "jest-preset-angular": "^7.0.0",
    "lerna": "^3.20.2",
    "ng-packagr": "^5.4.0",
    "prettier": "^1.19.1",
    "pretty-quick": "^2.0.1",
    "protractor": "~5.4.0",
    "rxjs-marbles": "^5.0.4",
    "shelljs": "^0.8.3",
    "ts-jest": "^24.3.0",
    "ts-node": "~7.0.0",
    "tsickle": "^0.37.0",
    "tslint": "~5.20.1",
    "typescript": "~3.7.5",
    "sass-rem": "^2.0.0"
  },
  "config": {
    "commitizen": {
      "path": "./node_modules/cz-lerna-changelog"
    }
  },
  "husky": {
    "hooks": {
      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
      "pre-commit": "pretty-quick --staged **/*.ts"
    }
  }

I can barely see the bars because they are so small. Would it be possible to reproduce this using a smaller dataset and larger bars?

Thanks for the fast response.
If you go to the following file chart\chart.component.ts on line 53 you will find the different datasets that are used in the graph:
this.barChartData = {
      labels: barChartDatasets.labels,
      datasets: [
        barChartDatasets.datasets[0],
        barChartDatasets.datasets[1],
        barChartDatasets.datasets[2],
        barChartDatasets.datasets[3],
        barChartDatasets.datasets[4],
        barChartDatasets.datasets[5],
        barChartDatasets.datasets[6]
      ]
    };

I created a different example with only the following datasets:
barChartDatasets.datasets[1],
barChartDatasets.datasets[2],
barChartDatasets.datasets[3],

IDE url
App url

Like you can see in the picture below the bar charts are overflowing in each other. If you have a smaller dataset, like 1 or 2 datasets this issue don't exist. (barThickness: in this example is 2).

In this example, there is not barThickness set. Then I definitely looks unreadable.

So why is there no space created between the bars so they don't overflow in each other when you modify the barThickness property.

https://stackblitz.com/edit/chartjs-bar-chart-smaller-keccwe?file=src/app/chart/chart.component.ts
Set stacked: true to xAxis.

@kurkle Thank you for the response.
But it doesn't solve my issue.
I saw that you also changed the following properties:
borderWidth: 0,
barPercentage: 1,
categoryPercentage: 1

The issue still exist, I can't change the bar thickness without that the bars are overflowing in each other.

Chart.js does not change the canvas size based on its contents. Instead the canvas is resized to fit the container, if responsive is set to true.
If you have 1600 bars and set batThickness to 8, your chart needs to be at least 12800 (+ scales & padding) pixels wide for no overlapping to occur.
Looks like the original online example was deleted. Closing as this is not something Chart.js is expected to do.


Fix deprecation warning from Moment.js

Prior to this PR, a user may encounter the message below in their console. This is the result of a deprecation warning thrown in Moment.js, where the preferred order of arguments has been swapped.

Deprecation warning: moment().add(period, number) is deprecated. Please use moment().add(number, period).

Registers tests, fixes testing harness to reslove an issue with Sinon/Chai
Fixes deprecation notice that has crept in with updates
Bumps moment-timezone version to latest release

Looks good :+1:


fixed issue with dataset nav arrows

For ticket: https://github.com/CDL-Dryad/dryad-product-roadmap/issues/266

Looks good. Thanks for fixing this critical issue!


Embedding usage without starting a server

So we can use it in nodejs worker_thread without starting a server, and I/O with FFI instead!

I am not sure about using it from nodejs, but I am curious if there is an example how to use it from a Go program directly.

Ollama embeddings API is build on top of llama.cpp, which now has node.js bindings. You can use these bindings to use create embeddings without Ollama (or any server).

Hi there, sorry this isn't possible today with Ollama. It's something we're thinking about making possible with the Javascript and Python libraries, but haven't started building that yet. Would it be possible to create an issue on that repo? Thanks so much

I would like to do it with Go. So I think this issue here should then be for tracking enabling Go embedding?
I was looking into this a bit and I think it could work with a bit of reorganizing, so that generate is called by Go to generate the .a file which then is should be found by a sub-package's go:embed.


Action hovers don't include the docstring

It would be useful

This has been fixed in the latest release


No error when an arrow function uses a variable from an unreachable branch

🔎 Search Terms
variable used before declaration function
🕗 Version & Regression Information

This is the behavior in every version I tried since v3.3.3333

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.3.2#code/BTCUAIF4D5wbwFDnASwGbmAWQIYBcALAOhwCMBnYARgkjvBviWXACcBTARwFd3y8AggDsUAW3woA9kIBirHKPYhasAMbTykgDbsiWyQHNgaSZNCgA3M2Qc83VkKvIAvs3VD+4E5KjgATE7g7po6eobGppYIzqBgVkA
💻 Code
(() => {
  if (Math.abs(1) === 1) {
    requestAnimationFrame(() => console.log(foo));
    return;
  }
  const foo = 2;
  console.log(foo);
})();

🙁 Actual behavior
Fails at runtime with
Uncaught ReferenceError: Cannot access 'foo' before initialization

🙂 Expected behavior
The same error, but at compile time
Additional information about the issue
If you replace requestAnimationFrame() with an IIFE (``), it correct

(Probably) another duplicate of #9998.

I don't think so.
This is not entirely about control flow analysis; the foo variable is entirely out of scope in the always-terminating if(){} block above it.
In particular, I'm not complaining about locals used before they're declared (eg, if you move const foo to directly below requestAnimationFrame()), which is actually valid.

It’s not actually out of scope, just in the temporal deadzone (the identifier itself is hoisted), which is the purview of CFA.

@fatcerebus -
I'm don't know whether you are talking about JS or TS hoisting of const variable scope.
JS hoists var variables to the stop of their scope, but not their initialization.  It doesn't hoist const variables - thet's why the runtime error happened.
TS runs flow analysis from the bottom up, and treats const variables as if they were declared and initialized at the top of their resident scope.
I would say this a probably a design limitation of the current TypeScipt flow algorithm.  bug would mean it is fixable without a redesign, which I think isn't the case.
Because there is a runtime error without a compiler error, it has to be a design limitation or a bug.

@fatcerebus -
I don't know whether you are talking about JS or TS hoisting of const variable scope.
JS hoists var variables to the stop of their scope, but not their initialization. It doesn't hoist const variables - otherwise the runtime error would not have happened.
TS CFA treats const variables as if they were declared and initialized at the top of their resident scope. If it knew const foo was in a temporal dead zone it would make an error, but it doesn't recognize that in this particular case even if Math.abs(1) is changed to 1==1.
Because there is a runtime error without a compiler error, it has to be a design limitation or a bug.
I would say this a design limitation of the current TypeScipt flow algorithm. bug would mean it is fixable without a redesign, which I think is not the case.
#9998 is about the advantages and disadvantages of assuming a mutable variables value won't change in a subcall (please forgive me if am wrong). That couldn't even apply to const variables because they are immutable.

@craigphicks #9998 still applies; the same design limitations that cause the problems described there are at play here.

It doesn't hoist const variables - otherwise the runtime error would not have happened.

This is a common misconception.  const/let are still hoisted, they’re just in TDZ instead of being undefined like var would be (the TDZ check happens at runtime, which is why using const/let can sometimes be a performance issue vs. var).  If they weren’t hoisted then this would work:
const foo = "bar";
{
    // console.log(foo);  // nope, runtime error
    const foo = "qux";
    console.log(foo);  // ok, "qux"
}

and the below code does work precisely because the variable is hoisted:
setTimeout(() => console.log(foo), 0);  // ok, "bar"
const foo = "bar";

@fatcerberus
Your case 1.1 does show something.
const foo = "bar";
{
    /console.log(foo);  // nope, runtime error
    const foo = "qux";
}

The const is not hoisted like var would be, because for var it would show undefined.  But the JS runtime compiler has checked all scoping and removed the outer foo from the inner scope before executing the inner scope because a redefinition exists in the inner scope.
The second case works only because setTimeout yields control to continue to the next line - the call back won't execute at least until control yields again.

But the JS runtime compiler has checked all scoping and removed the outer foo from the inner scope before executing the inner scope because a redefinition exists in the inner scope.

This is just a roundabout way to say the inner const is hoisted to the top of its scope.  Semantically, the hoisting is the same as for var, it just throws on access instead of returning undefined (the error is different than the one for accessing an out-of-scope variable).  TDZ is a runtime phenomenon; it doesn’t correspond to lexical scope.

This is a duplicate of #11498. It's sometimes valid and idiomatic to write this code, but we don't know if it's safe or not unless we know the semantics of the receiver of the callback. It's not practical to always error on this, so the only thing we can do is never error.

Thanks @RyanCavanaugh, I knew duping to #9998 was sketchy and I always forget about #11498 😝

It's sometimes valid and idiomatic to write this code, but we don't know if it's safe or not unless we know the semantics of the receiver of the callback.

Not in this case; because the if() block always terminates, this can never be valid (no matter when the callback runs, the variable can never have been declared.

IOW, if a variable's declaration is never reachable from a nested function's definition, you should emit an error when using the variable from inside the nested function.

I don't think the control-flow analyzer is that sophisticated; the const is reachable within its own scope, so the compiler is satisfied.  I'm pretty sure there's no internal infrastructure for analyzing the control flow of individual references to foo.

But the JS runtime compiler has checked all scoping and removed the outer foo from the inner scope before executing the inner scope because a redefinition exists in the inner scope.

This is just a roundabout way to say the inner const is hoisted to the top of its scope. Semantically, the hoisting is almost the same as for var, it just throws on access instead of returning undefined (the error is different than the one for accessing an out-of-scope variable). TDZ is a runtime phenomenon; it doesn’t correspond to lexical scope.

It's complicated, but there's help:

Hoisting is not a term normatively defined in the ECMAScript specification. The spec does define a group of declarations as HoistableDeclaration, but this only includes function, function*, async function, and async function* declarations. Hoisting is often considered a feature of var declarations as well, although in a different way. In colloquial terms, any of the following behaviors may be regarded as hoisting:

Being able to use a variable's value in its scope before the line it is declared. ("Value hoisting")
Being able to reference a variable in its scope before the line it is declared, without throwing a ReferenceError, but the value is always undefined. ("Declaration hoisting")
The declaration of the variable causes behavior changes in its scope before the line in which it is declared.
The side effects of a declaration are produced before evaluating the rest of the code that contains it.

... let, const, and class declarations (also collectively called lexical declarations) are hoisted with type 3 behavior

No, because it doesn’t:
switch ("foo" as string) {
    case "bar":
        const foo = 0;
    case "foo":
        foo;  // runtime error (TDZ)
}

foo is fully in scope here, but errors anyway because the line that declares it is skipped at runtime.

This particular case has everything to do with evaluation of the branch condition:
function requestAnimationFrame(f:()=>void): void;
(() => {
  if (true) {
    requestAnimationFrame(() => console.log(foo));
    return;
  }
  const foo = 2; // error: Unreachable code detected.(7027)
})();

"correlates with" does not mean "equates to".  So the counter example is not proof that "correlates with" is not an accurate description.

No, because it doesn’t:
switch ("foo" as string) {
    case "bar":
        const foo = 0;
    case "foo":
        console.log(foo);  // runtime error (TDZ)
}

foo is lexically in scope here, but errors anyway because the line that declares it is skipped at runtime.

This OP's case has everything to do with evaluation of the branch condition:
function requestAnimationFrame(f:()=>void): void;
(() => {
  if (true) {
    requestAnimationFrame(() => console.log(foo));
    return;
  }
  const foo = 2; // error: Unreachable code detected.(7027)
})();

true make the CFA treat the declaration of foo as unreachable.   Math.abs(1) === 1, and for that matter 1===1 don't.
In the end, neither #9998, nor #11498, come into play.

Not in this case; because the if() block always terminates, this can never be valid (no matter when the callback runs, the variable can never have been declared.

This isn't a useful hypothetical. If it "can never be valid" then no one would write the if in the first place. If Math.abs(1) were -1 and requestAnimationFrame waited until the next event loop tick, then the code would be valid. The point is that TypeScript doesn't know either of those facts and thus can't conclude that it's invalid.

@RyanCavanaugh It is true in this case that, if requestAnimationFrame is called, then the const will never be initialized—regardless of how many frames it takes to call the callback or the exact condition in the if.

(because the function returns early)
if the CFA chooses to recognize as alway true.

No, that’s irrelevant - even if the branch condition is only sometimes true, calling requestAnimationFrame always corresponds to an early return.

No, that’s irrelevant - even if the branch condition is only sometimes true, calling requestAnimationFrame always corresponds to an early return.

If the branch is not called, foo is initialized.

If the branch is called, foo is never initialized, and the CFA could reliably conclude that accessing foo is an error.

That's true.

Yes, I’m fully aware - I was specifically arguing against Ryan’s assertion that this code could ever be valid as written (it can’t).

function requestAnimationFrame(f:()=>void){ f(); }
(() => {
  let maybe = true;
  if (maybe) {
    requestAnimationFrame(f)
    return;
  }
  const foo = 2;
  function f(){ console.log(foo)};
})();

Just to issue clarity, the above particular case produces a runtime error, as expected.
[ERR]: "Executed JavaScript Failed:"
[ERR]: can't access lexical declaration 'foo' before initialization

While this done doesn't:
(() => {
  function f(){ console.log(foo)};
  setTimeout(() => f()), 0);
  const foo = 2;
})();

Any program calling requestAnimationFrame is probably not purely synchronous, so the worst case would have to be assumed.


yarn-berry: 4.2.2 -> 4.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for yarn-berry is: Fast, reliable, and secure dependency management
meta.homepage for yarn-berry is: https://yarnpkg.com/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.3.0 with grep in /nix/store/h6w92i08wjip986xl7pxcjzi1f67h0yv-yarn-berry-4.3.0
found 4.3.0 in filename of file in /nix/store/h6w92i08wjip986xl7pxcjzi1f67h0yv-yarn-berry-4.3.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

yarn-berry

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h6w92i08wjip986xl7pxcjzi1f67h0yv-yarn-berry-4.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A yarn-berry https://github.com/r-ryantm/nixpkgs/archive/c84e78ae5d45f776cf2f5a86c25d483c4a674bd5.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c84e78ae5d45f776cf2f5a86c25d483c4a674bd5#yarn-berry

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h6w92i08wjip986xl7pxcjzi1f67h0yv-yarn-berry-4.3.0
ls -la /nix/store/h6w92i08wjip986xl7pxcjzi1f67h0yv-yarn-berry-4.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

yarn-berry

Maintainer pings
cc @ryota-ka @pyrox0 @DimitarNestorov for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for yarn-berry is: Fast, reliable, and secure dependency management
meta.homepage for yarn-berry is: https://yarnpkg.com/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.3.1 with grep in /nix/store/ykqbvn4lwincis3q14xh3021cybab0yz-yarn-berry-4.3.1
found 4.3.1 in filename of file in /nix/store/ykqbvn4lwincis3q14xh3021cybab0yz-yarn-berry-4.3.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

yarn-berry

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ykqbvn4lwincis3q14xh3021cybab0yz-yarn-berry-4.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A yarn-berry https://github.com/r-ryantm/nixpkgs/archive/31823a35b144c3390016e95304e85649c0fd072f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/31823a35b144c3390016e95304e85649c0fd072f#yarn-berry

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ykqbvn4lwincis3q14xh3021cybab0yz-yarn-berry-4.3.1
ls -la /nix/store/ykqbvn4lwincis3q14xh3021cybab0yz-yarn-berry-4.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

yarn-berry

Maintainer pings
cc @ryota-ka @pyrox0 @DimitarNestorov for testing.

Result of nixpkgs-review pr 319133 run on x86_64-linux 1

1 package built:

yarn-berry


Port already in use due to local quoters

I tried to run this example with quoters running locally as well - as suggested in "Fetching a REST Resource". The (consumer) application failed to start due to Web server failed to start. Port 8080 was already in use.
IMHO there is no reason why this consumer application should fire up a web server.
Thus the solution for me was to change the main method to
new SpringApplicationBuilder(GsConsumingRestApplication.class)
	.web(WebApplicationType.NONE) // .REACTIVE, .SERVLET
	.run(args);

Would it be okay to include this in the repo?

I tried to run this example with quoters running locally as well - as suggested in "Fetching a REST Resource". The (consumer) application failed to start due to Web server failed to start. Port 8080 was already in use.
IMHO there is no reason why this consumer application should fire up a web server.
Thus the solution for me was to change the main method to
new SpringApplicationBuilder(GsConsumingRestApplication.class)
	.web(WebApplicationType.NONE) // .REACTIVE, .SERVLET
	.run(args);

Would it be okay to include this in the repo?

I would welcome that change as a PR. You are correct that there's no reason to fire up a web server for this application, and the reactive approach is a good way to avoid that unnecessary overhead.
I'm adding the good first issue tag, in case someone wants to use it as their first contribution to Spring.

Alternatively, you could change the spring-boot-starter-web dependency to spring-boot-starter-json. This includes all the dependencies needed for the consuming app, but doesn't add a web server to the classpath.

You are right. However, the solution proposed in the initial comment is better, because it removes the unnecessary overhead of starting a web server.


Tooltip as a property?

Feature request type
Enhance component
Component name
Tooltip
Is your feature request related to a problem?
No response
Describe the solution you'd like
It would be a blast if I could use Tooltip not as a wrapper around other component, but as a property of that component. For example <MudNumericField ToolTip="Bla"/>
Have you seen this feature anywhere else?
WPF ;)
Describe alternatives you've considered
title="Bla"
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I think the problem with this is that you would loose all customization options. Tooltip color, placement etc.
And adding new parameters for them as well clutters the api in my opinion

What's the problem with the old approach? Is it just for convenience?

I think the problem with this is that you would loose all customization options. Tooltip color, placement etc.
And adding new parameters for them as well clutters the api in my opinion

Not, if the ToolTip parameter would accept any object, not just string. That object could either be plain string as well as MudTooltip for those requiring customisation. In WPF ToolTip is a property of FrameworkElement, which is a base class for all controls.

What's the problem with the old approach? Is it just for convenience?

Not only that but mainly readability. Using parameter would just feel more natural to me.

I think the problem with this is that you would loose all customization options. Tooltip color, placement etc.
And adding new parameters for them as well clutters the api in my opinion

Not, if the ToolTip parameter would accept any object. That object could either be plain string as well as reference to MudTooltip instance - for those requiring customisation. In WPF ToolTip is a property of FrameworkElement, which is a base class for all controls.

What's the problem with the old approach? Is it just for convenience?

Not only that but mainly readability. Using parameter would just feel more natural to me.

I am not sure if this is possible in blazor. I think you can't render a MudToolTip object which is passed as a parameter. If it is possible we should discuss if we want to apply this approach for other components as well. (MudIcon for instance)
This would simplify a lot of components: MudIcon prop instead of iconcolor, iconssize ...
But this would permit two-way binding of props of these parameters I think

Just noticed we have this exact functionality in MudTabPanel component.
https://try.mudblazor.com/snippet/i4_3TczM0ytKrMovkrfxLU0JSUwqVnDNSS1LLMnMz7NVMlRSCMovzUtJTbFVKikqTVVSCEjMS81xzkksLrZVKkjUNVOy41IAAqhmsKxCSGpFia2SZ0lqroJ_HlBPSH5-Tkhmga0SlAEWheiD6wVqsYPpsNGHiUDM1kcyHL91IeX5WKwDieKyDihHgXUZRanY_AcRx2klSBa_pTBusR0A

Just noticed we have this exact functionality in MudTabPanel component.
https://try.mudblazor.com/snippet/i4_3TczM0ytKrMovkrfxLU0JSUwqVnDNSS1LLMnMz7NVMlRSCMovzUtJTbFVKikqTVVSCEjMS81xzkksLrZVKkjUNVOy41IAAqhmsKxCSGpFia2SZ0lqroJ_HlBPSH5-Tkhmga0SlAEWheiD6wVqsYPpsNGHiUDM1kcyHL91IeX5WKwDieKyDihHgXUZRanY_AcRx2klSBa_pTBusR0A

That is true. The reason for this is that we don't have a header RenderFragment yet. I would rather prefer a solution like that https://github.com/MudBlazor/MudBlazor/pull/3913#issuecomment-1036982747
and obsolete the ToolTip prop in MudTab.

The change mentioned in https://github.com/MudBlazor/MudBlazor/pull/3913#issuecomment-1036982747 was implemented in https://github.com/MudBlazor/MudBlazor/pull/4624 in case anyone is wondering.


Losing [older] chat while sharing older chat in presence of a newer one

This one caught me by surprise. I had one old chat and a newer chat...eg if i open a new chatcraft it opens newer chat.
I then go to share older chat, it asks me to login and then returns to newer chat...i seemingly lose the older chat..luckily i could get back via search.

Help me reproduce.
So if I go to chatcraft.org/ right now, it takes me to the latest chat, which is https://chatcraft.org/c/zJAbsFS1ZTzY6tQI5Daki for me.
Then you are making a new chat by clicking New > Blank Chat...?
Now I have https://chatcraft.org/c/d9mMqEvKTh-6eQwbAxGQY (new) and https://chatcraft.org/c/zJAbsFS1ZTzY6tQI5Daki (old).
When I open chatcraft/ again, it takes me to https://chatcraft.org/c/d9mMqEvKTh-6eQwbAxGQY (new).
That seems right to me, since https://chatcraft.org/c/d9mMqEvKTh-6eQwbAxGQY (new) is the most recent.
Maybe what we need here is to add a Recent list to the sidebar, which shows your last 5-10 chats above the Shared chats?

made a recording..will share it once it finishes uploading

See #93 too.

see vid
https://github.com/tarasglek/chatcraft.org/assets/857083/09924153-6815-41cc-81fb-ddbd7f67ad5e

Got, so this is about the fact that doing a login redirects back to / vs /:currentId.  That's a bug for sure, nice find.


Sticky Labels toggle has issues toggling

In the HTML, the <label> tag for 'Sticky labels' has for="stickyNavigation", so clicking the text 'sticky labels' makes it toggle the checkbox for Sticky Navigation instead. You have to directly click the checkbox for sticky labels to change it. It should be for="stickyLabels".
Also, proc.js has document.getElementById('stickyLabels').checked = rawData.defaults.sticky_labels, but gridgencore's WebDataBuilder's build_json method doesn't write sticky_labels to the JSON file.

oop, that was already fixed in the swarm version, just haven't cross-ported over yet

synced to swarm version https://github.com/mcmonkeyprojects/sd-infinity-grid-generator-script/commit/966662cc035c69c0272bbd860c5562c59583e2a4


Rewrite the microsoft/surface linuxPackage function to make it simpler to use

Description of changes
The original linuxPackage function required passing-in more metadata / params than necessary (apologies for my code!).
I rewrote it some months ago, based on a similar set of functions I use in a private repo to (hopefully) make it simpler to use.
Things done

[x] Tested the changes in your own NixOS Configuration
[x] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

cc @stigtsp @ifd3f @damianoognissanti

I had to manually set microsoft-surface.kernelVersion="6.6.13"; in my configuration.nix for it to build. Previously you could leave it unset for the default value.
I am building it now to see if everything works as expected. Will write again later today.

Btw, are there plans to cache the builds somehow? Either in the regular cache or the nix-community one? To avoid the frequent recompilations?

Everything seems to work on my machine. Batteries are detected (but they are with stock kernel too), the camera works (using v4l2loopback), and touchscreen too.

I had to manually set microsoft-surface.kernelVersion="6.6.13"; in my configuration.nix for it to build. Previously you could leave it unset for the default value. I am building it now to see if everything works as expected. Will write again later today.

Yes, I ran out of time to find this, and just found + fixed it.
Thanks!

I had to manually set microsoft-surface.kernelVersion="6.6.13"; in my configuration.nix for it to build. Previously you could leave it unset for the default value. I am building it now to see if everything works as expected. Will write again later today.

Ah, I see how that code was intended, now;  I misinterpreted the intention.
Let me fix this, now...

I had to manually set microsoft-surface.kernelVersion="6.6.13"; in my configuration.nix for it to build. Previously you could leave it unset for the default value. I am building it now to see if everything works as expected. Will write again later today.

Ah, I see how that code was intended, now; I misinterpreted the intention. Let me fix this, now...

I've fixed it (i.e. restored the functionality) so you can set the major.minor version as the default kernel-version.

Btw, are there plans to cache the builds somehow? Either in the regular cache or the nix-community one? To avoid the frequent recompilations?

IDK if the nixos-hardware repo is cached anywhere by default?
However, it seems to come-up every so often.
Partly perhaps because I've been told that some people would prefer the hardware-specific fixes were rolled-into the main nixpkgs repo — except that moves pretty slow c.f. how quickly some hardware gets support...

I had to manually set microsoft-surface.kernelVersion="6.6.13"; in my configuration.nix for it to build. Previously you could leave it unset for the default value. I am building it now to see if everything works as expected. Will write again later today.

Ah, I see how that code was intended, now; I misinterpreted the intention. Let me fix this, now...

I think I've fixed it — i.e. restored the functionality — so you can set the major.minor version as the default kernel-version.

After a flake update I could unset the kernelVersion and it didn't complain and didn't try to build a different version, so it's probably fixed.

Btw, are there plans to cache the builds somehow? Either in the regular cache or the nix-community one? To avoid the frequent recompilations?

IDK if the nixos-hardware repo is cached anywhere by default? However, it seems to come-up every so often.
Partly perhaps because I've been told that some people would prefer the hardware-specific fixes were rolled-into the main nixpkgs repo — except that moves pretty slow c.f. how quickly some hardware gets support...

But one also cache just the microsoft part of nixos-hardware. This is done by someone with a powerful machine (or some build system somewhere), and uploaded to the binary cache.
Here are the instructions for the nix-community cache (but I am not sure how to get an account though): https://app.cachix.org/cache/nix-community#push
And sorry that this is off topic...

But one also cache just the microsoft part of nixos-hardware. This is done by someone with a powerful machine (or some build system somewhere), and uploaded to the binary cache. Here are the instructions for the nix-community cache (but I am not sure how to get an authorized account though): https://app.cachix.org/cache/nix-community#push
And sorry that this is off topic...

Afraid I'm not sure what the right thing to say, here, would be?
Perhaps looking into creating your own small build-cluster might help?

https://nixos.wiki/wiki/Distributed_build
https://nixos.org/manual/nix/stable/advanced-topics/distributed-builds.html

Desktop-style machines are almost always more performant than laptops, primarily because they can provide much better power and cooling, and even some of the very small 2nd-hand office-style machines can be surprisingly quick for the cost.

Btw, are there plans to cache the builds somehow? Either in the regular cache or the nix-community one? To avoid the frequent recompilations?

If you can help me to add a hydra jobset to this repository, we can enable hydra.nixos.org for this repository.

@mergify queue

@mergify rebase

@mergify merge

@mergify update

@mergify queue

Btw, are there plans to cache the builds somehow? Either in the regular cache or the nix-community one? To avoid the frequent recompilations?

If you can help me to add a hydra jobset to this repository, we can enable hydra.nixos.org for this repository. Than everything would land in the official binary cache.

Sure, I can try. Is there any documentation on how to add a hydra jobbset to a repository? Any template or guide?


fix 25% => 50% withdrawal bug

testing:
100% -> trigger 50% transaction
25% -> trigger 50% transaction
50% -> trigger 25% transaction

testing:
100% -> trigger 50% transaction
25% -> trigger 50% transaction
50% -> trigger 25% transaction

I figured out what was causing it and fixed it. We locked it the default decimal amount of 50% and then showed the prompt to change the amount which then had no effect because the default amount was already locked in. It is fixed now and I tested it on the preview link, looks good to me. @ashachaf can you confirm that it is working as intended now?
@Velua can you polish this off by triggering the WETH balance to update once the withdraw is confirmed. Currently the site seems to needs a refresh to show the updated WETH balance.

@Velua can you polish this off by triggering the WETH balance to update once the withdraw is confirmed. Currently the site seems to needs a refresh to show the updated WETH balance.

Just pushed in https://github.com/bancorprotocol/webapp/pull/1486/commits/cb1176c3404d7939038585f0a2aa0a4e39f8049e
Good work! @pingustar


Feature/add rpc anno

What this PR does:
https://github.com/mosn/layotto/issues/112
add comments to RPC related code
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Thanks for your contribution!
@MoonShining  Could u help review this PR?

Codecov Report

Merging #230 (bc84809) into main (306cac0) will increase coverage by 0.12%.
The diff coverage is n/a.

:exclamation: Current head bc84809 differs from pull request most recent head b9f13fc. Consider uploading reports for the commit b9f13fc to get more accurate results

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   55.79%   55.91%   +0.12%
==========================================
  Files          53       53
  Lines        2409     2409
==========================================
+ Hits         1344     1347       +3
+ Misses        934      931       -3
  Partials      131      131

Impacted Files
Coverage Δ

.../filter/network/tcpcopy/persistence/persistence.go
70.51% <0.00%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306cac0...b9f13fc. Read the comment docs.

Thanks again for your contribution,and welcome to the Layotto community!


Always add cICP chucks to djxl generated pngs if possible.

Did anyone manage to actually read this back? @veluca93 @sboukortt
I'm getting zero chunks from png_get_unknown_chunks()...

The chunk is there according to pngcheck. How do you call set_keep_unknown_chunks? I remember it took me some convincing to get it working in Chrome: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/image-decoders/png/png_image_reader.cc;l=102?q=png_set_keep_unknown_chunks&sq=&ss=chromium

The chunk is there according to pngcheck.

Yes, I verified it using exiftool as well (and used the tool to remove the ICC profile).

How do you call set_keep_unknown_chunks?

Thanks for the pointer - it seems indeed critical to call it before info_ptr is created!


Email change form and emails

Since the user model is no longer in the scope of this project, this is better left to be handled at the project level.


Split off CONTRIBUTING.md from README.md.

Details about contributing should go into CONTRIBUTING.md; README.md should just explain what this repo is about.

There should probably be a link from README to CONTRIBUTING.
You can do cross-links on GitHub Markdown: http://stackoverflow.com/a/7658676/21501

Done

:+1:

Thanks!


Require the "image" key in the CSV schema where necessary

Signed-off-by: Ben Alkov<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[n/a] Changes to metadata also update the documentation for the metadata
[n/a] Pull request has a link to an osbs-docs PR for user documentation updates
[n/a] New feature can be disabled from a configuration file

@ben-alkov
You could link the corresponding jira issue here. Also, do we need to mention this change in some docs or not?


Release preparation for v1.1.1

Codecov Report

:exclamation: No coverage uploaded for pull request base (release@03d3c35). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             release     #107   +/-   ##
==========================================
  Coverage           ?   83.53%
==========================================
  Files              ?        3
  Lines              ?      164
  Branches           ?        0
==========================================
  Hits               ?      137
  Misses             ?       27
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d3c35...d8256e5. Read the comment docs.

@binford2k Thanks for incorporating the comments and for your help.
Travis is failing on one platform with the following error.
bundle exec bolt command run 'apt-get install wget -y' --inventoryfile inventory.yaml --nodes='localhost*' Unknown argument '--nodes=localhost*'
Could you please update the parameter nodes to targets in travis.yml file
https://github.com/puppetlabs/puppetlabs-hocon/blob/master/.travis.yml#L37
This is from the latest changes in litmus for moving to bolt v2 .
Please let me know if you need any help with this PR. Thank you.


Executing Apply when there are no changes should exit success, not throw PlanIsUpToDateException

I created a new release to apply to a new environment after a previous release successfully applied on the dev environment.  But the deploy/apply to dev (which had no changes) failed with:
2020-08-13T22:37:28.9431787Z Executing apply...
2020-08-13T22:37:28.9436938Z
2020-08-13T22:37:30.2278932Z com.devshawn.kafka.gitops.exception.PlanIsUpToDateException: The current desired state file matches the actual state of the cluster.
2020-08-13T22:37:30.2285551Z 	at com.devshawn.kafka.gitops.manager.PlanManager.validatePlanHasChanges(PlanManager.java:179)
2020-08-13T22:37:30.2287816Z 	at com.devshawn.kafka.gitops.StateManager.apply(StateManager.java:93)
2020-08-13T22:37:30.2291777Z 	at com.devshawn.kafka.gitops.cli.ApplyCommand.call(ApplyCommand.java:35)
2020-08-13T22:37:30.2292939Z 	at com.devshawn.kafka.gitops.cli.ApplyCommand.call(ApplyCommand.java:19)
2020-08-13T22:37:30.2294005Z 	at picocli.CommandLine.executeUserObject(CommandLine.java:1783)
2020-08-13T22:37:30.2295589Z 	at picocli.CommandLine.access$900(CommandLine.java:145)
2020-08-13T22:37:30.2296457Z 	at picocli.CommandLine$RunLast.handle(CommandLine.java:2141)
2020-08-13T22:37:30.2297266Z 	at picocli.CommandLine$RunLast.handle(CommandLine.java:2108)
2020-08-13T22:37:30.2298094Z 	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1975)
2020-08-13T22:37:30.2298922Z 	at picocli.CommandLine.execute(CommandLine.java:1904)
2020-08-13T22:37:30.2299804Z 	at com.devshawn.kafka.gitops.MainCommand.main(MainCommand.java:69)
2020-08-13T22:37:30.6357738Z
2020-08-13T22:37:30.6415279Z ##[error]Bash exited with code '1'.

Given that this tool is intended to be used with automation to apply desired state configuration, if no changes are required to make the current state match the desired state that should be represented as a success to the controlling automation framework.
I can imagine why one might want to fail if there were no changes and you expected there to be changes, but imo that should be an optional flag, not the default.

Good catch! I'd probably consider this a bug, as that should be the intended behavior.
I think I'll fix this as well as output a plan file even when the desired state matches the actual state. I found that when testing this locally, that if my old plan file sticks around, you can end up double-applying if you try to apply after doing a plan with no changes. I agree that it should be an optional flag. 🚀

Also noticed, if planning does not emit any changes, it will not write anything to or create the indicated plan file.  For automation I think it would be better to emit an empty plan file (or a plan with an empty list etc).

Yes, I also noticed that yesterday as I was addressing this issue. Both issues have been fixed and released in 0.2.7. 🚀
Thanks for the report 😄


feat(trie): read-only root calculation

This PR extract all write operations from the state root calculation. This is needed in order to be able to compute state root with read-only transaction, for instance, for payload building.
All operations are buffered in TrieUpdates and flushed if needed. Alternatively, root calculation can be called without a buffer and all updates will be omitted.
This PR also introduces checkpoints for state root calculation. Computation is checkpointed in order to avoid keeping database updates in memory and enabling intermediate commits.

Converted back to draft because for this to work, the cursors over hashed tables need to be abstracted away.

Codecov Report

Merging #2233 (46f73a6) into main (db1e6cb) will decrease coverage by 53.06%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2233       +/-   ##
===========================================
- Coverage   72.19%   19.14%   -53.06%
===========================================
  Files         472      473        +1
  Lines       57068    57108       +40
===========================================
- Hits        41200    10932    -30268
- Misses      15868    46176    +30308

Flag
Coverage Δ

integration-tests
19.14% <0.00%> (-0.02%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/stages/src/stages/merkle.rs
0.00% <0.00%> (-86.67%)
:arrow_down:

crates/storage/provider/src/transaction.rs
0.00% <0.00%> (-89.71%)
:arrow_down:

crates/trie/src/cursor/account_cursor.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

crates/trie/src/cursor/storage_cursor.rs
0.00% <0.00%> (-93.75%)
:arrow_down:

crates/trie/src/hash_builder/mod.rs
0.00% <0.00%> (-92.71%)
:arrow_down:

crates/trie/src/lib.rs
0.00% <ø> (-100.00%)
:arrow_down:

crates/trie/src/trie.rs
0.00% <0.00%> (-99.02%)
:arrow_down:

crates/trie/src/updates.rs
0.00% <0.00%> (ø)

crates/trie/src/walker.rs
0.00% <0.00%> (-95.95%)
:arrow_down:

... and 315 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

There's a failure in one of the eth_createAccessList tests it seems like:
this PR + hive: https://github.com/paradigmxyz/reth/actions/runs/4759013384/jobs/8458269107
main + hive: https://github.com/paradigmxyz/reth/actions/runs/4759097858/jobs/8458083596
The failure:
response differs from expected:
 {
   "id": 1,
   "jsonrpc": "2.0",
   "result": {
     "accessList": [
       0: {
         "address": "0xbb00000000000000000000000000000000000000",
         "storageKeys": [
+          0: "0x0000000000000000000000000000000000000000000000000000000000000003",
           1: "0x0000000000000000000000000000000000000000000000000000000000000001",
         ]
       }
     ],
     "gasUsed": "0x6b0e"
   }
 }

For some reason the + line of the diff isn't showing up in hive, and I'm not sure why we're having a createAccessList failure when this PR doesn't seem to touch anything related to that on first glance. I'll do some digging to figure out what's wrong

Hive test passed after merging main
https://github.com/paradigmxyz/reth/actions/runs/4761790254/jobs/8463510010
This PR passed state root calculation on sepolia at height 3m and mainnet height 8m. Merging in good faith and opening follow up perf PRs


Refactor to use ES6 (ES2015)

This is a good time to bring this codebase into 2016. Modern JS doesn't need us to write var self = this; and Foo.prototype.thing = function() { ... } all over the place.
I've done this in a branch called refactor and I'm using babel to build it to ES5 for Node versions before v5.
This feature is a prerequisite to https://github.com/sstur/nodeftpd/issues/80 in which I will do more refactoring in an effort to make FtpConnection shorter and more readable/understandable by factoring out pieces (like PASV) where applicable.

Any feedback on my work at https://github.com/sstur/nodeftpd/tree/refactor will be appreciated. As of now, all tests passing (including some new tests) and lint passes.

:+1:


feat(imports): add support for top-level imports

Previously top-level import strings like 'json' were not possible.
Signed-off-by: Florian Scherf<EMAIL_ADDRESS>

@maratori: Thanks for reviewing!


use self hosted runner and disable windows workflow

Description
Use self hosted runner and disable windows workflow + use forked functional-test repo for development
Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #182 (cd17702) into workspace-pr-integr (f1eb762) will decrease coverage by 11.16%.
Report is 1 commits behind head on workspace-pr-integr.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           workspace-pr-integr     #182       +/-   ##
========================================================
- Coverage                66.50%   55.35%   -11.16%
========================================================
  Files                     3406     1185     -2221
  Lines                    65111    23745    -41366
  Branches                 10426     3942     -6484
========================================================
- Hits                     43302    13143    -30159
+ Misses                   19221     9976     -9245
+ Partials                  2588      626     -1962

Flag
Coverage Δ

Linux_1
?

Linux_2
?

Linux_3
?

Linux_4
?

Windows_1
?

Windows_2
?

Windows_3
?

Windows_4
?

_2
55.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2582 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Move components from Sound to PhonoModel

Due do changes addressing https://github.com/tresoldi/maniphono/issues/11 , methods that previously worked (and returned) graphemes are now working with values. This is better in structural terms, but the results can be less user-friendly.
It should be investigated if the .grapheme() and ._parse_grapheme() logic should be moved from Sound to PhonoModel (keeping them as wrappers in the former), so that we can generate graphemes on the fly (and parse them!) in the newly implemented methods of the latter.
Tasks:

[x] Move methods
[ ] Re-organize code, docs, and tests

Methods moved with a38db6d

Methods moved with a38db6d


Update README.md

Thanks for the PR.
I don't think your formatting fixes are correct, but thank you for reviewing this.


In a fresh Google Closure editor, a bug will "arbitrarily" delete text. This tends to happen when the user first starts using that editor.

1)   Open a fresh Closure Library editor.
2)   Click "Set Field Contents"
       a)   The lower box text physically moves to the upper box. The lower box text disappears
3)   Click the upper box text
       a)   The upper box text disappears
PR #468 fixes this.

@fbsolo wtf is that link

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


tiny change in README for usage

Included a sentence to explain the usage of the tool after gcloud based installation.

Hey @balopat, thanks for this change! We don't accept PR on Github yet. Would you mind making the change within Google code? It will be exported here.

Sounds good, I'll raise it internally then, I'll close this one. Thanks!


Duplicate Address Creating in checkout page.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
Master
Issue Description
If the customer is clicking on save this address on the checkout page then. the duplicate addresses are created.
Preconditions
The customer should be on the checkout page.
Steps to reproduce
1. Go to 'shop'
2. Login as a customer.
3. Add any product to the cart.
4. Process for checkout.
5. Add a new shipping address.
6. Click on save this address after filling in all required fields.
7. click on the back button at the top of the address section.
8. Click on add new address button.
9. Click on the save this address button after filling in all required fields.
10. See the error
Expected Result
Duplicate addresses should not be created.
Actual Result
If the customer is clicking on the save address checkbox duplicate addresses are created on the checkout page.
Screenshots

Additional context
No response

Please assign this issue to me.


How to go throught images tapping next and back buttons?

How can I do this?

did you find a solution? Currently I try with
setCurrentPage(currentPage + 1, animated: true)
and
setCurrentPage(currentPage - 1, animated: true)
but the behavior is weird...

I implemented previousPage and nextPage methods on ImageSlideshow in 31710dbed4e7b13fb8274b985e8b6addf358f257


Issue #8181: Change exercise from creating Pod to Deployment (page 1)

Partially addresses #8181.
This is based directly on the YAML file given in the issue, so should in theory be fine.
Followed up by PR #8343 to fix the second page.

/assign @steveperry-53

Thanks @bethaitman. I'll test the new steps sometime during the next few days.

@bethaitman, This looks good. One comment in line.

@bethaitman Any updates?

@bethaitman Any updates here?

@bethaitman 👋 Feel free to reopen this PR when you're ready.


exif.ts as independent repo / npm package

As the headline says, I want to use your exif.ts library in another project.
It would be very nice, if you can publish that exif.ts in an independent npm package. So the versions don't disperse over time.
Thank you!

Feel free to take it and publish your own node-module!
On Mon, May 8, 2017 at 3:52 PM Dominik<EMAIL_ADDRESS>wrote:

As the headline says, I want to use your exif.ts library in another
project.
It would be very nice, if you can publish that exif.ts in an independent
node module. So the versions don't disperse over time.
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cstefanache/angular2-img-cropper/issues/187, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC7c4e4Fijmk8bF7BDCpo1sHm1lqrm6Dks5r3xAigaJpZM4NT57J
.


Authentication failure specifying empty password for default bucket (Couchbase)

Error at runtime:
2017-07-06 14:04:44,323 INFO [org.apereo.cas.ticket.registry.CouchbaseTicketRegistry] - <Setting up Couchbase Ticket Registry instance>
2017-07-06 14:04:44,857 WARN [com.couchbase.client.core.endpoint.Endpoint] - <[null][KeyValueEndpoint]: Authentication Failure.>
2017-07-06 14:04:44,886 WARN [com.couchbase.client.core.endpoint.Endpoint] - <[null][KeyValueEndpoint]: Authentication Failure.>
2017-07-06 14:04:44,886 WARN [com.couchbase.client.core.endpoint.Endpoint] - <Error during reconnect: >
com.couchbase.client.core.endpoint.kv.AuthenticationException: Authentication Failure
        at com.couchbase.client.core.endpoint.kv.KeyValueAuthHandler.checkIsAuthed(KeyValueAuthHandler.java:288) ~[core-io-1.3.7.jar!/:?]
        at com.couchbase.client.core.endpoint.kv.KeyValueAuthHandler.channelRead0(KeyValueAuthHandler.java:173) ~[core-io-1.3.7.jar!/:?]
        at com.couchbase.client.core.endpoint.kv.KeyValueAuthHandler.channelRead0(KeyValueAuthHandler.java:52) ~[core-io-1.3.7.jar!/:?]

...

2017-07-06 14:04:44,886 WARN [com.couchbase.client.core.endpoint.Endpoint] - <[null][KeyValueEndpoint]: Could not connect to endpoint, retrying with delay 32 MILLISECONDS: >
com.couchbase.client.core.endpoint.kv.AuthenticationException: Authentication Failure

This line (CouchbaseClientFactory.java#L73) may need to be refactored to use either of the default openBucket constructors which explicitly declare connectivity to the default with no password (timeout optional):

Bucket openBucket() - Opens the default bucket with an empty password with the default connect timeout.
Bucket openBucket(long timeout, java.util.concurrent.TimeUnit timeUnit) - Opens the default bucket with an empty password with a custom timeout.

Reference: http://docs.couchbase.com/sdk-api/couchbase-java-client-2.0.0/com/couchbase/client/java/Cluster.html
And yes, I know what you're going to say, "Please investigate and submit a pull request."
I'm going to try creating a different bucket first, one that is not default which does not support passwords to begin with.

And yes, I know what you're going to say, "Please investigate and submit a pull request."

Great. Please do.

If you have already identified an enhancement or a bug fix, it is STRONGLY recommended that you simply submit a pull request to address the case. There is no need for special ceremony to create separate issues. The pull request IS the issue and it will be tracked and tagged as such. Do NOT log issues hoping for the issue to get resolved in the future by someone else. Study the guide and learn the skills to submit contributions, or reach out to a commercial affiliate for assistance.

More guidelines in case it helps https://apereo.github.io/2017/07/05/cas-contribution-guide/


Replace Bytecode with Blobs

Motivation
Now that we have blobs, there are several follow ups we can do.
Proposal
This PR replaces Bytecode with Blobs. This will clean up a lot of code and also make our blocks smaller when publishing Bytecodes. Fixes #2149
Test Plan
CI
Some tests had to be altered since we don't have to subscribe to get bytecodes anymore, and also the ApplicationId format has changed with this.

#2375  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on  Graphite

test_script_in_readme_with_storage_service seems to be failing on CI for some reason, but it passes locally 🤔 will investigate more on Monday

Merge activity

Aug 26, 8:46 PM EDT: @andresilva91 started a stack merge that includes this pull request via Graphite.


Failed to parse custom header

object `X-Custom` extends HeaderKey.Singleton {
  type HeaderT = `X-Custom`
  def name: CaseInsensitiveString = "x-custom".ci
  def matchHeader(header: Header): Option[`X-Custom`] = Some(`X-Custom`(header.value))
}

final case class `X-Custom`(token: String) extends Header.Parsed {
  override def key = `X-Custom`
  override def renderValue(writer: Writer): writer.type =
    writer.append(token)
}

val r: Request = ...
r.headers.get(`X-Custom`) == Some(x-custom: localhost:9999)
r.headers.get(`X-Custom`.name) == Some(x-custom: JULIEN)

localhost:9999 seems to be the first header when I print the request.

Where does the request come from?  Is this from a client, or are you constructing it yourself?

I used blaze client to send request to a blaze server

@julien-truffaut: looking back on this, I think your
def matchHeader(header: Header): Option[`X-Custom`]

method is wrong. You also need to check the key. It should probably look more like this:
def matchHeader(header: Header): Option[`X-Custom`] = {
  if (header.name == name) Some(`X-Custom`(header.value))
  else None
}

Could you give that a try and see if it works?

thanks, I will give it a try

Sorry for the delay @bryce-anderson, your solution works.
What happens when you do: r.headers.get(X-Custom) ? does it iterate through all headers until one match?

Yes: https://github.com/http4s/http4s/blob/master/core/src/main/scala/org/http4s/HeaderKey.scala#L30

will it cause a problem to look up by header name and then call match header?

I'm not sure what you mean. Can you give a quick example?

sure, could from be implemented like this?
trait Singleton extends Extractable {
    def from(headers: Headers): Option[HeaderT] =
      headers.get(name).flatMap(matchHeader)
  }

Technically yes, but I personally think Headers.from should be made to enforce that matchHeader as the standard way to match a header. @rossabaker, do you have an opinion on that?

Let try to close this issue. If we want to change the definition of from we should change a few others things such as the definition of get(CaseInsensitiveString) so that we don't reparse headers. I'm partial to making from final and moving forward.


Avatars not persist docker

Gitea version (or commit ref): 1.13
Git version: Docker built-in
Database:

[x] MySQL

Description
Hello,
I use gitea inside docker but today after multiple deletion and creation of the container with mapped data to a volume, i found a bug. Organization avatars not persists.
Here, my docker-compose.yaml file:
version: '3'
services:
  web:
    image: gitea/gitea:1.13
    volumes:
      - git_data:/data
      - ./app.ini:/data/gitea/conf/app.ini
    ports:
      - "<IP_ADDRESS>:3000:3000"
      - "2222:22"
    depends_on:
      - db
    restart: unless-stopped

  db:
    image: mariadb:latest
    restart: unless-stopped
    environment:
      - MYSQL_ROOT_PASSWORD=xx
      - MYSQL_DATABASE=gitea
      - MYSQL_USER=gitea
      - MYSQL_PASSWORD=xx
    volumes:
      - db_data/:/var/lib/mysql

volumes:
  db_data:
  git_data:

Screenshots

What's the chrome network request and response?

404 not found

Have you changed your app.ini?

Waht the settings you want i give to you ?
Here my app.ini:
APP_NAME = GIT
RUN_MODE = prod
RUN_USER = git

[database]
DB_TYPE  = mysql
HOST     = db:3306
NAME     = gitea
USER     = gitea
PASSWD   = *****
SSL_MODE = disable
CHARSET  = utf8
PATH     = /app/gitea/data/gitea.db

[repository]
ROOT = /data/git/gitea-repositories

[ui]
DEFAULT_SHOW_FULL_NAME = True

[server]
LFS_CONTENT_PATH = /data/git/lfs/
LFS_START_SERVER = true
ROOT_URL         = https://*****/
START_SSH_SERVER = false
DOMAIN           = *****
SSH_PORT         = 2222
ENABLE_GZIP      = True
LANDING_PAGE     = explore
SSH_DOMAIN       = *****
HTTP_PORT        = 3000
OFFLINE_MODE     = false
DISABLE_SSH      = false
LFS_JWT_SECRET   = *****

[log]
# ROOT_PATH = /data/logs/
LEVEL     = error
MODE      = console
ROOT_PATH = /app/gitea/log

[service]
REGISTER_EMAIL_CONFIRM            = true
DISABLE_REGISTRATION              = true
ENABLE_CAPTCHA                    = true
REQUIRE_SIGNIN_VIEW               = true
ENABLE_NOTIFY_MAIL                = true
DEFAULT_ORG_VISIBILITY            = private
ALLOW_ONLY_EXTERNAL_REGISTRATION  = false
DEFAULT_KEEP_EMAIL_PRIVATE        = false
DEFAULT_ALLOW_CREATE_ORGANIZATION = true
DEFAULT_ENABLE_TIMETRACKING       = true
NO_REPLY_ADDRESS                  = ****

[attachment]
ENABLED       = True
ALLOWED_TYPES = image/jpeg|image/png|application/octet-stream|application/x-gzip|text/plain
MAX_SIZE      = 150
MAX_FILES     = 5

[session]
PROVIDER      = file
COOKIE_SECURE = false
COOKIE_NAME   =  ****

[security]
LOGIN_REMEMBER_DAYS  = 30
COOKIE_USERNAME      = user
COOKIE_REMEMBER_NAME = name
INSTALL_LOCK         = true
INTERNAL_TOKEN       = ******

[other]
SHOW_FOOTER_VERSION = false

[openid]
ENABLE_OPENID_SIGNIN = false
ENABLE_OPENID_SIGNUP = false

[picture]
DISABLE_GRAVATAR        = false
ENABLE_FEDERATED_AVATAR = true

[oauth2]
JWT_SECRET = ******

this will be because the default avatar storage location has not ended up on your data partition

Okay, what is the parameter to add ?

Should be fixed by https://github.com/go-gitea/gitea/pull/14217.

Should be fixed by https://github.com/go-gitea/gitea/pull/14217.


Changing LineSize of RadialGaugeChart while changing size of chart?

Hey there!
Thanks for this great library. I was trying to change the LineSize attribute of the RadialGaugeChart type and i experienced that whenever i set it to a small size, something like 10, i can't resize the whole chart.
What i want to achieve is a big chart with a thin line. Any ideas?
Best regards

Can you please provide code samples for your issues?


feat(nodebuilder/p2p): Implement Module

Implements the P2P Module and provides it on our RPC.
Fixes one TODO in https://github.com/celestiaorg/celestia-node/issues/977

Use assert

Codecov Report

Merging #1285 (933ea83) into main (793ec2c) will increase coverage by 0.07%.
The diff coverage is 55.95%.

@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
+ Coverage   55.32%   55.40%   +0.07%
==========================================
  Files         176      180       +4
  Lines       10640    10755     +115
==========================================
+ Hits         5887     5959      +72
- Misses       4170     4213      +43
  Partials      583      583

Impacted Files
Coverage Δ

api/gateway/server.go
69.64% <ø> (ø)

nodebuilder/das/daser.go
100.00% <ø> (ø)

nodebuilder/fraud/mocks/api.go
16.66% <0.00%> (+4.16%)
:arrow_up:

nodebuilder/fraud/service.go
0.00% <0.00%> (ø)

nodebuilder/header/service.go
57.14% <ø> (ø)

nodebuilder/share/service.go
100.00% <ø> (ø)

nodebuilder/fraud/lifecycle.go
31.57% <31.57%> (ø)

nodebuilder/fraud/module.go
73.68% <50.00%> (ø)

nodebuilder/p2p/p2p.go
92.45% <92.45%> (ø)

api/rpc/client/client.go
78.57% <100.00%> (+0.79%)
:arrow_up:

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ERROR at the end of regression with Questa

Hi all,
I am using Cocotb with Questa, and if I don't set the GUI=1, at the shutdown of the simulator, at the end of the regression, I get the following:
312537.50ns INFO     cocotb.regression                         regression.py:184  in tear_down                       Shutting down...
312537.50ns DEBUG    cocotb.gpi                                 GpiCbHdl.cpp:128  in run_callback                    Generic run_callback done
312537.50ns DEBUG    cocotb.gpi                                 FliCbHdl.cpp:85   in cleanup_callback                Removing Postponed DELETE timer 0x1
Simulation halt requested by foreign interface.
312537.50ns ERROR    cocotb.scheduler                            init.py:172  in _sim_event                      Failing test at simulator request before test run completion: Simulator shutdown prematurely
312537.50ns DEBUG    cocotb.scheduler                           scheduler.py:535  in finish_scheduler                Issue sim closedown result to regresssion object
End time: 08:32:36 on Jan 26,2017, Elapsed time: 0:01:12
Errors: 0, Warnings: 3
By rewinding the source of this message, my understanding is that it is triggered by FliShutdownCbHdl::run_callback , that triggers gpi_embed_end(), that generates embed_sim_event(SIM_FAIL, "Simulator shutdown prematurely");
(I am using VHDL, that's why I looked at the FLI).
The way I understand this shutdown is not "premature", and is triggered by the need to close the simulator at the end of hte regression. Is my understanding correct? Am I the only one getting this ERROR message?
Thanks for your help!

Which operating system you are using? I'm not getting such error when GUI=0 both on Linux and Windows 7. Everything is fine, however my language is Verilog.

I have this with Debian. Unfortunately, I won't be able to test with another OS because of questa license. But thanks for your answer!

You could try Modelsim Altera Starter Edition which is free for any OS. Also, try simple test with Verilog (not VHDL):
`timescale 1ns / 1ns

module top_cocotb(
input clock,
input reset,
output reg [3:0] test
);

initial test = 0;
always @(posedge clock) begin
	if(reset) test <= 0;
	else test <= test + 1;
end
endmodule

Thanks for the advice.
I am currently away, I will come back in 3 weeks. As soon as I am back, I'll try this.

Hi guys, I fixed this, that was my fault.
For info, I had a mistake in my makefile , having a VSIM_ARGS appearing twice, leading to a vsim command containing  "vsim -coverage -onfinish exit -foreign "cocotb_init libfli.so" -foreign "cocotb_init libfli.so" work.fs_fpga_top" >> obj_nosvn/runsim.do which was crating the issue reported.
I close it.


Update adjo.json

Travis tests have failed
Hey Eliran Pe'er,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
Node.js: 8

     npm test

><EMAIL_ADDRESS>test /home/travis/build/bluzi/[secure]
> mocha

  name files
    ✓ should contain valid JSON
    1) should contain a lowercase name, same as the filename
    ✓ should not have duplicate names
    ✓ should have ISO-639-3 language codes (164ms)
    2) should have correct structure

  Translations
    ✓ should be lowercase

  Sex
    ✓ should be "m", "f" or "u"
    ✓ should be lowercase

  6 passing (293ms)
  2 failing

  1) name files
       should contain a lowercase name, same as the filename:
     TypeError: Cannot read property 'toLowerCase' of undefined
      at Context.it (test/test.js:25:47)

  2) name files
       should have correct structure:
     Error: Error in name file "adjo.json":
instance.name is required
      at Context.it (test/test.js:106:23)

npm ERR! Test failed.  See above for more details.


docs need clarification re binding.gyp

Node Version: node -v10.12.0 and npm -v6.4.1
Platform:  Windows 10
Compiler:
Module:

Verbose output (from npm or node-gyp):

The instructions in the docs for building a native module, while clear, seem not to mention any case where multiple source files are entered in the "sources" field in binding.gyp.  As there are very few, if any, tutorials covering this scenario, it would be helpful if the node-gyp docs were updated to show how to build  a module where, say, two  C files existed in the sources field.

At the very least we could link to https://nodejs.org/api/addons.html. For example, the two source files scenario is covered in https://nodejs.org/api/addons.html#addons_addon_examples.
Pull requests are welcome.

Thanks Richard,  particularly for that  second link.   Following it up, I
found 3 relevant examples in nodejs/node-addon-examples.   These are
6_object_wrap,  7_factory_wrap,  and 8_passing_wrapped.
Unfortunately, these examples are  extremely difficult to understand for
someone like me.   An ultra minimal example with clear explanations would
be of immense value.  The simple "hello world" examples repeated everywhere
are of course easy to follow.
On Fri, Nov 2, 2018 at 7:56 PM Richard Lau<EMAIL_ADDRESS>wrote:

At the very least we could link to https://nodejs.org/api/addons.html.
For example, the two source files scenario is covered in
https://nodejs.org/api/addons.html#addons_addon_examples.
Pull requests are welcome.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/node-gyp/issues/1595#issuecomment-435312632,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADCMuh0rR9_vAOF3xEtdV3yDozMvXnINks5urAixgaJpZM4YLEMH
.


Updating to newest gRPC, fixing tests.

The newest gRPC library doesn't allow registering services after Serve()
is called (which makes sense!). Fixing all tests to not do that.

I will rebuild the docker base images with this change, so it fixes the build there (still have older gRPC that doesn't support 'status' and so all docker automated builds fail now).


CzmlDataSource onChange Event is not firing on data change

The load event works fine but when I change the CZML data the onChange event doesn't fire.
For example when changing CZML description the onChange event doesn't fire and the description remains the same.
I'm talking about data changes via the data prop.
When I save the Cesium.CzmlDataSource that results from the load event and the I do something like:
            loadedCzmlDataSource.load(newCZML);

Here the onChange event fires but the changes are not visible in the graphics.

Seems like the correct way to update a loaded CzmlDataSource:
loadedCzmlDataSource.process(newCZML);


Replace Ollama with LiteLLM to allow for any LLM with OpenAI compatibility

I came across this comment that highlights LiteLLM as an excellent approach to using any LLM with OpenAI format. If you agree, I am happy to submit a PR for it. An example of how it looks off of this feature branch:
def query_litellm(prompt, context=''):
    messages = [{"content": context+prompt, "role": "user"}]
    response = completion(model="gpt-3.5-turbo", messages=messages)
    answer = response['choices'][0]['message']['content'].strip()

    followup_prompt = "What is a likely follow-up question or request? Return just the text of the question or request."
    followup_messages = [{"content": answer, "role": "assistant"}, {"content": followup_prompt, "role": "user"}]
    followup_response = completion(model="gpt-3.5-turbo", messages=followup_messages)
    followup = followup_response['choices'][0]['message']['content'].strip()

    return answer, followup

In my tests, it works pretty well, and allows for faster training data generation by querying cloud-hosted LLMs like GPT 3.5-Turbo, Claude 2, etc. Especially can be a preferred approach on MacBooks with slower performance.

The problem with litellm is the hardcoded list of supported ollama model with many constraints on context size: check the json file here


Optimised get namingService and namingMaintainService

Describe what this PR does / why we need it
Optimised get namingService and namingMaintainService

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: yuhuangbin:x: yuhuangbin1You have signed the CLA already but the status is still pending? Let us recheck it.


Fix copying issue of traffic_layout init

This PR fixes the copying issue of traffic_layout: https://github.com/apache/trafficserver/issues/3646.
A filter is applied during the creating of the runroot to only copy or hard link the traffic server related files.
@dragon512 @bryancall
Note: mandir is removed from the runroot.

Comments and test are updated

More Comments !

[approve ci autest]

[approve ci]

[approve ci]
[add to whitelist]

[approve ci autest]

[approve ci]

Hmmm, this was a bad PR, it changes two source files to be executable.

I'm fixing the permissions, and will cherry-pick this + my undo of the issues to 8.0.x

Thanks for reminding and it won't happen again :) @zwoop


Fix android lint warnings

Build https://github.com/Glusk2/sprouts/runs/61758818 failed because of lint errors

Add lynx -dump as suggested in this SO answer to see the lint warnings after a travis build.

It's too time consuming to properly update the project to a newer version of gradle. Closing for now.


[helm-chart]: labels for kube-monkey

Purpose

We want to be able to opt-in for chaos. Used chaos-monkey
How does the solution address the problem

Opt-ins for chaos by adding labels to StatefulSets.
Changes made

Added labels to pod templates (and metamata of StatefullSep app as well) in StatefulSet of boot, rpc and consensus nodes.

prnet cleaned-up successfully


Error while running Azure tests on Mint

When I was running Azure gateway tests on Mint, I got the following error:
{
  "args": {
    "bucketName": "minio-go-test-mj6c6n45dw0bpa4e",
    "objectName": "test-object",
    "opts": "",
    "size": -1
  },
  "duration": 289,
  "function": "PutObject(bucketName, objectName, reader, size, opts)",
  "message": "Expected content-language 'en-US' doesn't match with StatObject return value",
  "name": "minio-go: testPutObjectWithContentLanguage",
  "status": "FAIL"
}

@nitisht pending accept from Praveen. Assigning it to you until then.


More syntax directives

Added docker keywords and post conditions. Moved post to the same
level as other sections. Based on https://www.jenkins.io/doc/book/pipeline/syntax/, but the change doesn't cover each option listed there.
Also added xunit step.
Ideally steps sections needs to be synced with https://www.jenkins.io/doc/pipeline/steps/ from time to time.

Thank you!


Fix dead SMT hyperlink and add sub-levels to table of content

Description
Problem*
The link for Sparse Merkle Tree Verify/Add/Update/Delete is dead
Summary*
Fixing the link to the new repo.
Adding the sub-levels to the table of content for better overview
Additional Context
PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

thanks!


Fix imports

(couldn't reopen old one)
Description:
Run script to move single line imports up. Then run isort on changed files to make the sorting correct.
Part of #27284
Hacked together with this script:
from pathlib import Path

component_dir = Path("./homeassistant/components")

import_lines = ("import", "from", ",", ")")

for fil in component_dir.glob("**/*.py"):
    # if "xiaomi_miio/fan.py" not in str(fil):
    #     continue

    lines = fil.read_text().split("\n")
    inject_import_pos = None
    to_push_up = []

    quotes_found = 0

    normal_code_started = False

    for no, line in enumerate(lines):
        if inject_import_pos is None:
            quotes_found += line.count('"""')

            if quotes_found >= 2:
                inject_import_pos = no + 1

            continue

        if not normal_code_started:
            if line == "":
                continue

            if any(s in line for s in import_lines):
                continue

        normal_code_started = True

        if " import " in line:
            to_push_up.append(no)

    if to_push_up:
        print(fil, to_push_up)

    for no in to_push_up:
        lines.insert(inject_import_pos, lines.pop(no).strip())

    # print("\n".join(lines))
    fil.write_text("\n".join(lines))

Going to close this again. @OverloadUT is right that this can better be looked at on a per-integration basis. Also comments should be filtered out, plus pylint comments should bre removed. That's more work than I can handle right now.