Thanks for allowing me use your code freely. Please see the problem below!

I do not know what the following description means. But I know that you will find out. Youtube-dl failed me for the first time and I just wanted to let you know. Knowing about this may help you as you continue to make the code better. Thanks for your help to the community.
youtube-dl https://www.youtube.com/watch?v=yDv5FIAeyoY
[youtube] yDv5FIAeyoY: Downloading webpage
[youtube] yDv5FIAeyoY: Downloading video info webpage
[youtube] yDv5FIAeyoY: Extracting video information
WARNING: unable to extract uploader nickname
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/youtube_dl/extractor/youtube.py", line 1081, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python3/dist-packages/youtube_dl/extractor/youtube.py", line 969, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://www.youtube.com/yts/jsbin/player-vflwcUIMe/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError("Cannot identify player 'https://www.youtube.com/yts/jsbin/player-vflwcUIMe/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
root@ubuntu:...# apt install youtube-dl
Reading package lists... Done
Building dependency tree
Reading state information... Done
youtube-dl is already the newest version (2017.03.26-1).

Jesus, can you please try to fix your text formatting here?

Some points:

NEVER install youtube-dl from apt-get. Check https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl and install version 2017.10.12.
Don't run youtube-dl as root.


vkQueuePresentKHR often crashes

About 1 in 10-15 times, when I run my code (even a simple tutorial engine), MoltenVK crashes (upon the first frame) with this error:
MVKCrashTest(11214,0x7ff855dd27c0) malloc: Heap corruption detected, free list is damaged at 0x600000124ee0
*** Incorrect guard value: 183628
MVKCrashTest(11214,0x7ff855dd27c0) malloc: *** set a breakpoint in malloc_error_break to debug

The error occurs when calling return disp->QueuePresentKHR(queue, pPresentInfo);
Using the LLDB Debugger, I have found that vkQueuePresentKHR causes this for no discernible reason. I am on the latest release. My hardware is an AMD Radeon 757 Pro 4GB and an Intel(R) Core(TM) i5-7600 CPU @ 3.50GHz. I upgraded the memory to be 32 GB 2400 MHz DDR4. This is a 27-inch 5K iMac from 2017 running macOS ventura 13.6.7
The code works 100% of the time on the same machine when booted into ubuntu and win11. I started up the application 200 times on win11, ubuntu, and macos. On macOS, it failed 23 times. It did not fail on either of the other operating systems. I am using the VK_LAYER_KHRONOS_validation layer, and am seeing no errors.

Were you are running with MVK_CONFIG_SYNCHRONOUS_QUEUE_SUBMITS=0 (disabled)?
If so, PR #2297 may fix this. Please test again with that update, and close this issue if it fixes the problem.

this issue no longer occurs

@billhollings this bug also exists in the latest  MoltenVK, it crash as i described in https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8473 ,please check it, thx

@billhollings this bug also exists in the latest MoltenVK, it crash as i described in KhronosGroup/Vulkan-ValidationLayers#8473 ,please check it, thx

@aitor-lunarg has created #2321 to cover this new issue.


/home/dokku/vddistd/ENV: line 1: -----END: command not found

Can not start application
dokku ps:restart vddistd
-----> Releasing vddistd ...
-----> Deploying vddistd ...
-----> Running pre-flight checks
/home/dokku/vddistd/ENV: line 1: -----END: command not found
/var/lib/dokku/plugins/ps/commands: line 5: 23984 Killed                  dokku deploy "$APP"

Can you gist your ENV file?

I remove the application , and start over again, I know what happened, there is one line: '------END RSA PRIVATE KEY-------'


Toolchain shouldn't update 'CMAKE_MODULE_PATH'

The toolchain files update CMAKE_MODULE_PATH so that 'opt-in' functionality can be included - such as IDL support. But by updating the CMAKE_MODULE_PATH the chance of colliding/breaking consuming builds in-advertently seems higher. Alternatives:

Set a variable allowing consumers to, say:

include(${TOOLCHAIN_SUPPORT}/MidlRT)

instead of:
include(MidlRT)

Include all functionality in the toolchain by default. If the '.cmake' files are less intrusive (as recommended by #18), then making the support 'opt-in' may not be necessary.

You can use what I did for project_options:
https://github.com/aminya/project_options/blob/49de1cc71e544bf56aa3a83768e044040a8726c2/src/Index.cmake#L13-L16


Update .lines z-index to fix highlighting

The text highlighting upon selection was not working for me. This is a potential workaround.

Reference #4


package openbazaar2-2.0.21-1.amd64 does not have a compatible architecture

Brief Description:
Operating System (OS and version): Fedora 27
OpenBazaar version: openbazaar2-2.0.21-1
Hardware: Linux itzel 4.14.11-300.fc27.x86_64 #1 SMP Wed Jan 3 13:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always
Steps to reproduce:

Try to install using rpm or dnf on Fedora 27 on x86_64 kernel.

Observed Behavior:
$ sudo dnf install openbazaar2-2.0.21.amd64.rpm
Last metadata expiration check: 0:04:01 ago on Sat 20 Jan 2018 11:10:33 AM PST.
Error:
Problem: conflicting requests

package openbazaar2-2.0.21-1.amd64 does not have a compatible architecture

Expected Behavior:
I expect it to install without error.
Additional info (links, images, etc go here):

Try modify libsolv: src/poolarch.c.
For example:
diff --git a/src/poolarch.c b/src/poolarch.c
index 8da16c1..d5f1d77 100644
--- a/src/poolarch.c
+++ b/src/poolarch.c
@@ -22,9 +22,9 @@
static const char *archpolicies[] = {
#if defined(FEDORA) || defined(MAGEIA)

"x86_64",    "x86_64:athlon:i686:i586:i486:i386",

"x86_64",    "x86_64:athlon:i686:i586:i486:i386:core2_64",
#else

"x86_64",    "x86_64:i686:i586:i486:i386",

"x86_64",    "x86_64:i686:i586:i486:i386:core2_64",
#endif
"i686",      "i686:i586:i486:i386",
"i586",      "i586:i486:i386",

The arch should be set as x86_64, not amd64


Manim Music sheet rendering svg

I want to make some animated Music theroy videos with latex and manim.
I only need to render the notes proper way.
That was quite a workaround, however I NEARLY got it nice.
So here, here is the code:
And the out2.svg looks perfect in inkscape:

However, when I load the svg to manim, I get this:

Of course I can increase the stroke_width, which will result in this:

Where every outline increased.
from big_ol_pile_of_manim_imports import *
class music(Scene):
    def MuseMobject(self):
        FOLDER = "/home/jan-hendrik/python/projects/manim-new/projects_hendrik/music_template/"
        FILE = "tex_template_music.tex"
        os.system("cd " + FOLDER + "&& latex -shell-escape " + FILE)
        temp1 = "out1.svg"
        os.system("cd " + FOLDER +" && eps2svg out-abc.eps " + temp1)
        temp2=  "out2.svg"
        os.system("cd " + FOLDER + "&& cairosvg "+ temp1 +" -f svg -o " + temp2)
        dat = FOLDER + temp2
        t = SVGMobject(dat,stroke_width=0) # or stroke_width = 2
        t.scale(0.9)
        self.add(t)
    def construct(self):
        self.MuseMobject()
        self.wait(2)

I would like to have a solution, where I can see the grid lines, but all my other objects should be untouched by the stroke_width function.
Any ideas?
Thanks a Lot!

You'll need a way to reference the staff separately from the notes. I'm not that familiar with how SVGMobject works, but there's a chance it has a .submobjects attribute that you can index into.

Yes, now it is working properly!  Thanks a lot!
I would also like to know if it is worth to try  a pull request when I put the framework together.
Is the manim project meant to be extended in this way, or is it meant to be more a "only math" repository?

Glad I could help.
Extensions shouldn't be added here, but if you don't mind hosting and maintaining your own repository you could do it there. Manim still changes pretty often, so you'll have to keep the repo up to date if you do decide to do it.

I recommend you use MuseScore, when you have your score go to file>export>svg. I did something like this:

In that scene I use MusixTex but you can use svg too. I has created a class to check the elements of svg. Is this:
class CheckSVG(Scene):
    CONFIG={
    "camera_config":{"background_color": WHITE},
    "svg_type":"svg",
    "file":"",
    "svg_scale":0.9,
    "angle":0,
    "flip_svg":False,
    "fill_opacity": 1,
    "remove": [],
    "stroke_color": BLACK,
    "fill_color": BLACK,
    "stroke_width": 3,
    "numbers_scale":0.5,
    "show_numbers": False,
    "animation": False,
    "direction_numbers": UP,
    "color_numbers": RED,
    "space_between_numbers":0,
    "show_elements":[],
    "color_element":BLUE,
    "set_size":"width",
    "remove_stroke":[],
    "show_stroke":[],
    "stroke_":1
    }
    def construct(self):
        if self.set_size=="width":
            width_size=FRAME_WIDTH
            height_size=None
        else:
            width_size=None
            height_size=FRAME_HEIGHT

        if self.svg_type=="svg":
            self.imagen=SVGMobject(
                "%s"%self.file,
                #fill_opacity = 1,
                stroke_width = self.stroke_width,
                stroke_color = self.stroke_color,
                width=width_size,
                height=height_size
            ).rotate(self.angle).set_fill(self.fill_color,self.fill_opacity).scale(self.svg_scale)
        else:
            self.imagen=self.import_text().set_fill(self.fill_color,self.fill_opacity).rotate(self.angle).set_stroke(self.stroke_color,0)
            if self.set_size=="width":
                self.imagen.set_width(FRAME_WIDTH)
            else:
                self.imagen.set_height(FRAME_HEIGHT)
            self.imagen.scale(self.svg_scale)
        self.personalize_image()
        if self.flip_svg==True:
            self.imagen.flip()
        if self.show_numbers==True:
            self.print_formula(self.imagen,
                self.numbers_scale,
                self.direction_numbers,
                self.remove,
                self.space_between_numbers,
                self.color_numbers)

        self.return_elements(self.imagen,self.show_elements)
        for st in self.remove_stroke:
            self.imagen[st].set_stroke(None,0)
        for st in self.show_stroke:
            self.imagen[st].set_stroke(None,self.stroke_)
        if self.animation==True:
            self.play(DrawBorderThenFill(self.imagen))
        else:
            self.add(self.imagen)
        self.wait()
    def import_text(self):
        return TexMobject("")

    def personalize_image(self):
        pass

    def print_formula(self,text,inverse_scale,direction,exception,buff,color):
        text.set_color(RED)
        self.add(text)
        c = 0
        for j in range(len(text)):
            permission_print=True
            for w in exception:
                if j==w:
                    permission_print=False
            if permission_print:
                self.add(text[j].set_color(self.stroke_color))
        c = c + 1

        c=0
        for j in range(len(text)):
            permission_print=True
            element = TexMobject("%d" %c,color=color)
            element.scale(inverse_scale)
            element.next_to(text[j],direction,buff=buff)
            for w in exception:
                if j==w:
                    permission_print=False
            if permission_print:
                self.add(element)
            c = c + 1

    def return_elements(self,formula,adds):
        for i in adds:
            self.add_foreground_mobjects(formula[i].set_color(self.color_element),
                TexMobject("%d"%i,color=self.color_element,background_stroke_width=0).scale(self.numbers_scale).next_to(formula[i],self.direction_numbers,buff=self.space_between_numbers))

In "file": you put the directory of your svg, and the class show you the numbers of the array of the svg.
You can see the code of my animation here, and the code of the scene here


Remove conda installation instructions and remove environment.yml?

At present, we're maintaining two separate ways to install nowcasting_dataset:  through pip and through conda.  Should we simplify?  Should we delete all mention of conda?
To be specific:  At present, the code has a requirements.txt (for pip) and an environment.yml (for conda, and uses Python 3.8).  The README's installation instructions talk about using conda to install.  But the python-app.yml GitHub action uses pip with Python 3.9.
(Personally, I'm quite fond of conda.  But I recognise that pip is probably easier for most people; and easier for automated testing).

I quite like conda too, and I think it works better for having an entirely reproducible environment for development, etc, while we need pip to make it easily installable for most potential users. So I'm not sure we need to remove one or the other. On the other hand, we could also standardize on conda, and add nowcasting, etc. to conda-forge so they are easily installable alongside all the other conda stuff.

Yeah, cool, I'd quite like to keep both conda and pip installation methods, too :)  (I prefer conda for my own dev environment, too)
Does anyone know if there's a way to automatically keep requirements.txt and environment.yml in sync?  :)

We could have only the non-pip requirements in environment.yml and then all the pip things in requirements.txt it was what I was doing for SatFlow, so then installing it is only conda create env -f environment.yml then pip install -r requirements.txt for installing?

I'll close this issue for now as it feels like we do actually want to allow users to install via either pip or conda :)


[DOCS] Add 7.5.1 release notes

Adds release notes for the 7.5.1 release.

master: 8cc42a4
7.x: 6b1a0c2
7.5: f4f0899


[SPARK-8162] [HOTFIX] Fix NPE in spark-shell

This was caused by this commit: f271347
This patch does not attempt to fix the root cause of why the @VisibleForTesting annotation causes a NPE in the shell. We should find a way to fix that separately.
I am testing locally in parallel.

Merged build triggered.

Merged build started.

Test build #34477 has started for   PR 6711 at commit bf62ecc.

LGTM

Ok, I tested this locally and verified that the NPE went away. I'm merging this into master 1.4 and 1.3

Test build #34477 has finished for   PR 6711 at commit bf62ecc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


Serializing QuerySolution ?

There might be a way to get rid of Row.java and QueryMvcSolutionItem by somehow using a single serialization of jena QuerySolution(s) for each ResultSet.
Let's see what it takes to implement this in order to evaluate what we can gain out of it, mainly in terms of code length, efficiency and memory usage.

This has been improved a while ago... closing


Midhat-fatima-pucit

prime Number checker

@Midhat-fatima-pucit contribute here https://github.com/Ishaan28malik/Get-Dev-Resources


use js rather than coffee

I may be missing something but I can't seem to use app.js and pure js rather than app.coffee.
are there some settings for this, or is this just not possible?

It's not possible at the moment, although roots' cousin spike does have this capability!

Brilliant thank you


remove_set seems to be without effect

I'm trying to "shorten" the horizon of a model. First, I remove the parameters of the model using the Scenario.remove_par() command. This works perfectly fine. In the next step, I want to remove the access years from the cat_tec set. I tried:
last_year = 2030
years = scenario.set('year').astype(int)
s = 'cat_year'
_set = scenario.set(s, {'year': years[years>last_year]})
shorter_model.check_out()
shorter_model.remove_set(s, _set)
shorter_model.commit(' ')
Despite running without error, there seems to be no effect. Thus, the set 'cat_year' remains unchanged. Any ideas on what might be happening here?

Since the set in question here is ‘year’, I wonder if this is the same as #227 reported by @gidden.
@ClaraLuisa do you observe this effect with any other set?


proposed new criteria: pipelines must be deterministic

Is your proposed change related to a problem? Please describe.
I feel a criteria is missing.
If a pipeline is non-deterministic (so the same inputs don't reliably lead to the same output, i.e. the pipeline is flaky), it puts the trustworthiness of the entire pipeline and indeed the process in jeopardy.
It also undermines the power of one of the present demands: "All feature work stops when the pipeline is red". If the pipeline can go red spuriously, people will stop caring and develop alarm blindness (at best).
Describe the solution you'd like
For this reason, I propose the inclusion of this new MinimumCD criteria.
Describe alternatives you've considered
One alternative would be to simply not include it, as keeping the manifesto brief is of great value.

Sorry for the delay. Lots going on.
Would you consider determinism to be implied by:

The pipeline decides the releasability of changes, its verdict is definitive
Artifacts created by the pipeline always meet the organization’s definition of deployable


Incompatible with the latest better combat

latest.log

Has been resolved as of V0.5.2, which should be released on CurseForge and Modrinth at the time of this comment. Closing the issue.


Import is not completely processed

We just imported 169 delegates as a CSV file. Few of them does not have a structure level. The preview says that 169 delegates will be imported. But only 133 are finally imported.

If you want me to send over the import file please write me to<EMAIL_ADDRESS>due to privacy issues.

I send a private message to Lars...
It would be interesting which users are not imported? Only the users without a structure level?

A first idea was that only delegates with no structure level were not imported. Yes, they were not imported but that makes only 13/37 - still 20 missing.

Ok, every delegate with the group '1' (which means guest group, default by system) was not imported

It is intended that nobody can be member of the group with id 1. This group exists only to control the permissions of guests, that are clients without any login. (This requires that the guest system is activated in the config.)
The same for group with id 2 (registered). Nobody can be a regular member of this group but all registered users (even those who do not belong to any group) gain permissions from this group.
May be we just have to document this properly. @donovaly

@normanjaeckel the UI is not clear on this point

The user csv import site says Default groups: Delegates 3, Staff 4. There is no comment that you should not use group id 1 and 2.
@larsboehnke Do you have a suggestion how we can improve the UI?

May be we just have to document this properly. @donovaly

Done: https://github.com/donovaly/openslides-docs/blob/master/de/OpenSlides-Handbuch.pdf

@larsboehnke Any idea how we can improvethe csv user-import page that we can prevent your error for setting default group 1. Is the help text and the documentation enough? If yes we can close this issue because all done.

I closed this issue. There is a help text in users import view which says that the default groups are 2 (delegates), 3 (staff) and 4 (committees). Group 1 (default group) is automatically set to users who have no other groups (see also help text in new group permission matrix for further explanation).


Add Governance contract to UI

Referenced issue
Probably part of already closed #36
Summary of changes
Just adding the Governance contract to the wizard UI (making it visible in the drop down)
Reviewer recommendations
None.

Maybe we should start thinking on retries for this errors :thinking: .Will retry the jobs now ...


Small fixes

Moved tracking ID to .env
Turned on test mode for react-ga
Arrow below "Learn More" button is also a button
Clear indication that bubbles are draggable

Nice! It was not allowing me to implement the trackingID via a .env
Glad you fixed it.


Peer disconnect message - add client info

PR description
Add client name to summary disconnect message - makes cross-referencing disconnects much easier.
Also whether the connection was active.
Fixed Issue(s)
Refs #6945
Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

examples of logs
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:14:42,237","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x22790fd33ef94696... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:40:21,524","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xd174777b3f3efa4f... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:01:28,939","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:06:16,053","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x03 USELESS_PEER  - 0x7f2092381e47dabf... Geth/v1.2.9-34b065ae-20230721/linux-amd64/go1.19.11 - 2 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:12:30,168","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x37a0bc5301ae557a... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:20:06,827","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x5476d6ed52c9b07b... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T05:10:46,235","level":"DEBUG","thread":"nioEventLoopGroup-3-3","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x04 TOO_MANY_PEERS  - 0xf64105f40f5533e4... erigon/v2.58.1/linux-amd64/go1.21.6 - 1 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T05:40:28,027","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xdc01223695d49395... bor/v1.2.7/linux-amd64/go1.20.14 - 1 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T06:08:54,482","level":"DEBUG","thread":"nioEventLoopGroup-3-2","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x464f5277624ce834... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T06:24:49,875","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xcd6dc7d5e44b5590... bor/v1.2.7/linux-amd64/go1.20.14 - 2 peers left","throwable":""}
disconnects-6609-60.log:{"@timestamp":"2024-04-15T06:28:44,161","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x03 USELESS_PEER  - 0x87fc72a3d15c69f8... besu/v24.4-develop-9bed81f/linux-x86_64/openjdk-java-21 - 2 peers left","throwable":""}
disconnects-6609-61.log:{"@timestamp":"2024-04-15T06:27:40,759","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x05 ALREADY_CONNECTED  - 0x87fc72a3d15c69f8... besu/v24.4-develop-9bed81f/linux-x86_64/openjdk-java-21 - 1 peers left","throwable":""}
disconnects-6609-61.log:{"@timestamp":"2024-04-15T06:36:33,373","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x269545a10921e699... bor/v1.2.7/linux-amd64/go1.20.14 - 3 peers left","throwable":""}
disconnects-6609-62.log:{"@timestamp":"2024-04-15T06:28:39,851","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x05 ALREADY_CONNECTED  - 0x87fc72a3d15c69f8... besu/v24.4-develop-9bed81f/linux-x86_64/openjdk-java-21 - 1 peers left","throwable":""}
➜  ~ grep 0xa3435a0155a3e837... disconnects-6609*
disconnects-6609-51.log:{"@timestamp":"2024-04-15T04:58:56,490","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:01:28,904","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T04:58:56,489","level":"DEBUG","thread":"nioEventLoopGroup-3-6","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:01:28,939","level":"DEBUG","thread":"nioEventLoopGroup-3-10","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0xa3435a0155a3e837... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
➜  ~ grep ac906289e4b disconnects-6609*
disconnects-6609-51.log:{"@timestamp":"2024-04-15T05:51:14,935","level":"DEBUG","thread":"nioEventLoopGroup-3-7","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xac906289e4b7f12d... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}
disconnects-6609-52.log:{"@timestamp":"2024-04-15T05:51:14,911","level":"DEBUG","thread":"nioEventLoopGroup-3-5","class":"EthProtocolManager","message":"Disconnect - active Connection? true - Outbound - 0x01 TCP_SUBSYSTEM_ERROR  - 0xac906289e4b7f12d... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 1 peers left","throwable":""}

one with empty client info
disconnects-6609-50.log:{"@timestamp":"2024-04-15T06:25:27,150","level":"DEBUG","thread":"nioEventLoopGroup-3-8","class":"EthProtocolManager","message":"Disconnect - active Connection? false - Inbound - 0x10 SUBPROTOCOL_TRIGGERED  - 0x5680fdd9c1442e60...  - 22 peers left","throwable":""}

Note latest commit changes this
"Disconnect - active Connection? true - Outbound - 0x03 USELESS_PEER_USELESS_RESPONSES Useless responses: exceeded threshold - 0x302cf78ac89db83b... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 4 peers left","throwable":""}

to this (easier for log analysis)
{"Disconnect - active Connection? true - Outbound - 0x03 USELESS_PEER_USELESS_RESPONSES - 0xac906289e4b7f12d... Geth/v1.13.14-stable-2bd6bd01/linux-amd64/go1.21.7 - 0 peers left","throwable":""}


Show track not hide filled zone

The new feature "show tracks" when disable, doesn't hide the filled zone, just the tracks. It was expected that, when disable, the viasualization was like the older version of the plugin.

I realize that there is other setting to...


Theme :)

Bro which theme are you using here?

Hey @NazmusSayad
Good question. The theme in that screenshot is from almost 2 years ago, and many themes have adjusted their colors since then. So it's kind of hard to tell with 100% certainty.
I usually stick with built-in themes, so I'd say that the one above is "Dark (Visual Studio)". Hope that helps you :)

Hey @NazmusSayad
Good question. The theme in that screenshot is from almost 2 years ago, and many themes have adjusted their colors since then. So it's kind of hard to tell with 100% certainty.
I usually stick with built-in themes, so I'd say that the one above is "Dark (Visual Studio)". Hope that helps you :)

I just liked the brackets color there 😅

Right now I'm using the built-in "Dark Modern" theme. Slightly updated "Dark (Visual Studio)". But there are hundreds of themes to choose from, so that's not an easy task 😅


Potential locking problem between methods open_console and lose_console

Hi, I found a potential locking bug in methods open_console and close_console.
The lock ui->lock is acquired in the open_console.
https://github.com/openssl/openssl/blob/1c0eede9827b0962f1d752fa4ab5d436fa039da4/crypto/ui/ui_openssl.c#L373-L379
When OPENSSL_SYS_VMS  enabled and status != SS$_NORMAL, the lock ui->lock is not released in method close_console
https://github.com/openssl/openssl/blob/1c0eede9827b0962f1d752fa4ab5d436fa039da4/crypto/ui/ui_openssl.c#L552-L569

Fix in #17365


Cannot access home directory from Python on MacOS

Description
I'm trying to use pathlib.Path.home() to get the home directory, but printing it seems to indicate its an empty string. Using Path.home() / "Library" gives /Library so I'm not sure what is going wrong. I don't want to use $HOME because apparently it's not set for GUI scripts. os.path.expanduser("~") is meant to work for any platform yet it is also just an empty string.
Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[X] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Environment: macos-11
Version: 20220508.1
Included Software: https://github.com/actions/virtual-environments/blob/macOS-11/20220508.1/images/macos/macos-11-Readme.md
Image Release: https://github.com/actions/virtual-environments/releases/tag/macOS-11%2F20220508.1
Is it regression?
No response
Expected behavior
Return "/Users/runner"
Actual behavior
Returns ""
Repro steps
Run python -c "import os; print(os.path.expanduser("~"))"
Run python -c "import pathlib; print(pathlib.Path.home())"

Hi! Your syntax is incorrect.

Wasn't this problem, but seems that stdout was getting redirected and I had an extra slash that made it lose the first half of the path. Thanks for the reply though!


create lobby, team and player class and their methods

To implement method getNextMinigame(): At lobby creation, all the minigames will be stored in lobby. The next minigame will be randomly chosen from the minigames.


TypeError: Passing coroutines is forbidden, use tasks explicitly

Fatal error encountered:

Traceback (most recent call last):
  File "main.py", line 177, in <module>
  File "asyncio\base_events.py", line 650, in run_until_complete
  File "twitch.py", line 351, in run
  File "twitch.py", line 371, in _run
  File "twitch.py", line 914, in get_auth
  File "twitch.py", line 136, in validate
  File "twitch.py", line 145, in _validate
  File "contextlib.py", line 204, in __aenter__
  File "twitch.py", line 938, in request
  File "gui.py", line 1926, in coro_unless_closed
  File "asyncio\tasks.py", line 415, in wait
TypeError: Passing coroutines is forbidden, use tasks explicitly.

Exiting...

Application Terminated.
Close the window to exit the application.

Hello o/
Is this from the latest master I've just pushed out?

This was from one version back. I just rebuilt with the latest commit and now I get this:
Fatal error encountered:

Traceback (most recent call last):
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\main.py", line 177, in <module>
    loop.run_until_complete(client.run())
  File "C:\Users\$User\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 650, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\twitch.py", line 351, in run
    await self._run()
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\twitch.py", line 371, in _run
    auth_state = await self.get_auth()
                 ^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\twitch.py", line 914, in get_auth
    await self._auth_state.validate()
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\twitch.py", line 136, in validate
    await self._validate()
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\twitch.py", line 145, in _validate
    async with self._twitch.request("GET", BASE_URL) as response:
  File "C:\Users\$User\AppData\Local\Programs\Python\Python311\Lib\contextlib.py", line 204, in __aenter__
    return await anext(self.gen)
           ^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\twitch.py", line 938, in request
    response = await self.gui.coro_unless_closed(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\$User\Documents\GitHub\TwitchDropsMiner\gui.py", line 1926, in coro_unless_closed
    done, pending = await asyncio.wait(
                    ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\$User\AppData\Local\Programs\Python\Python311\Lib\asyncio\tasks.py", line 415, in wait
    raise TypeError("Passing coroutines is forbidden, use tasks explicitly.")
TypeError: Passing coroutines is forbidden, use tasks explicitly.

Exiting...

Application Terminated.
Close the window to exit the application.

Are you using Python 3.11 by chance?

I am

Please try the latest master branch, now that I've added handling for this: https://github.com/DevilXD/TwitchDropsMiner/commit/683d2fd755f966a64f796eeaefc5fbe8f7b63413

Fatal error encountered:

Traceback (most recent call last):
  File "main.py", line 177, in <module>
  File "asyncio\base_events.py", line 650, in run_until_complete
  File "twitch.py", line 351, in run
  File "twitch.py", line 371, in _run
  File "twitch.py", line 914, in get_auth
  File "twitch.py", line 136, in validate
  File "twitch.py", line 145, in _validate
  File "contextlib.py", line 204, in __aenter__
  File "twitch.py", line 938, in request
  File "gui.py", line 1929, in coro_unless_closed
  File "asyncio\tasks.py", line 415, in wait
TypeError: Passing coroutines is forbidden, use tasks explicitly.

Exiting...

Application Terminated.
Close the window to exit the application.

And after https://github.com/DevilXD/TwitchDropsMiner/commit/2306fc1331dd4559dbc7e5fc6575a11e087ef160?

✅ Confirmed. The coroutines issue has been resolved. Working with 024ad97 on Python 3.11.0

Closed


[feat]: add media change listener to events map

come up with a solution to listen to media changes in JS
i.e.
   mediaQueryList.addEventListener('change', event => {
            this.renderMobileTemplate = mediaQueryList.matches;
            this.requestUpdate().then(() => {
                this.evaluateState();
            });
        });

I really like the idea of reactive controllers that lit added in v2.
https://lit.dev/docs/composition/controllers/
As far as I understand it they are also supposed to work cross framework:
https://github.com/lit/lit/issues/1682
I think it is a really neat solution to composing UI classes/elements. Would this maybe make sense for us to try to make this pattern work for element-js as well?
In case of the mediaQueryList change listener from the described issue - Something like this could work?
https://lit.dev/playground/#[encoded data, 4415 characters]

That looks cool, but i think it would be quite a change if we'd introduce these...
I mean we could replace the entire event map with these kind of controllers.
For now i had sth like this in mind:
events() {
    return {
        window : {
            'media:(max-width: 600px)': () => {
                //did change
            }
        }
    }
}

Thats  way simpler but and would play nicely with what we have right now. But it has the downside that you can't compare an initial "matches" or access the mq instance ...

No I was just thinking if this controllers thing could be something that we would like for element-js in general as well 👍
But yeah - for this specific feature we can think of something for now.
How about something like this?
isMobile = window.matchMedia('(max-width: 600px)');

connected() {
    console.log('connected', this.isMobile.matches);
}

events() {
    return {
      'media:isMobile': {
        'change': (e) => {
          console.log('change', e);
        }
      }
    }
}

Where element-js would know if the "selector" starts with "media:" it will look for the property on the instance and add the listener.

We could also provide a matchMediaQuery helper:
import { BaseElement, matchMediaQuery } from '@webtides/element-js';

class ExampleElement extends BaseElement {
    isMobile = matchMediaQuery('(max-width: 600px)', (e)   => {
      console.log('change', e);
    });

    connected() {
      console.log('connected', this.isMobile.matches);
    }
}

Or we could do something like the controller pattern and call the lifecycle implicitly:
import { TemplateElement, matchMediaQuery } from '@webtides/element-js';

class ExampleElement extends TemplateElement {
    isMobile = matchMediaQuery(this, '(max-width: 600px)');

    connected() {
      console.log('connected', this.isMobile.matches);
    }

    template() {
      return html`<div>${this.isMobile.matches ? 'is mobile' : 'is not mobile'}</div>`;
    }
}

In this case the helper function would add the listener behind the scenes and call the "requestUpdate" method on the element.

I like the idea, but i don't like putting it inside the event map, or at least not on the window. That could be confusing as they are not really these classic events.
window already is a special key, maybe we can put media as another special key?
events() {
    return {
        'media': {
             '(min-width: 300px)': (matcher) => { },
        }
    }
}

Or another map:
function media() {
    return {
        '(min-width: 300px)': (matcher) => { },
    };
}

@eddyloewen For now i think i would like to stay in the element-js pattern and not introduce a whole new concept of doing things. But for the future this controller pattern seem to be worth a shot. 👍

How would we handle the initial state?

MediaStore Example is now in docs:
https://github.com/webtides/element-js/commit/5718c085813b6a51d12a13e93edba8e42e87a09c


Added Skill Fruits to Item Spawner

Added Skill Fruits item category to the Menu.cpp and items to the ItemList.hpp

very nice addition thank you


Failed to load a file with a space from saved project

1.5

https://github.com/effekseer/Effekseer/commit/a4445fc62eab9333803249279b2905150f515fba


Non-editable table

Is it possible to make an active-table non-editable using APIs?

Hi @umayrh.
Yes it is, you can use the following example to achieve this.


New Message Type: 'application'

I think we should add a message called 'application':
{
  "type": "application",
  "data": anything
}

This allows user applications to send simple control messages/early data or whatever it desires without having to modify a task. The message can be sent at any time after the client-to-client handshake has been completed. Every task should support it, even after handover. It shall be independent of message states. The message shall not be abused for custom protocols which should be defined as tasks.
(And yes, I think it should land in v1)
@dbrgn Thoughts?

Haha, there we have the Data message again that we dropped :smile:
What about that simple DataTask you mentioned earlier?

The problem with the data task is that it's a task. Currently, we cannot have multiple tasks being active at the same time. This 'application' message is intended for messages such as a quick version compatibility check of a user application.

Currently, we cannot have multiple tasks being active at the same time.

That's true, you convinced me :)

Just to add: For a very strict protocol such as the WebRTC task defines, a custom message will not be that important. However, I'm currently writing on the ORTC task and there definitely will be plenty of use cases where you need to sneak in control messages in between as ORTC is very low level.


DPL-880-1 Add a new postgresql table for storing the prefixes instead of a config file to avoid deployment of baracoda for adding a prefix

User story
As PSD developer I want to create a new postgresql table for storing the prefixes instead of a config file to avoid deployment of baracoda for adding a prefix.
Who are the primary contacts for this story
Sangeetha, Steve
Who is the nominated tester for UAT
Sangeetha
Acceptance criteria
To be considered successful the solution must allow:

[ ] to store the prefixes in a postgresql table
[ ] to be able to read/write to the database to retrieve existing prefixes and create new prefixes.
[ ] the application should continue to work as expected without any loss of service to the users.

References
This story has a non-blocking relationship with:

https://github.com/sanger/baracoda/issues/417

Additional context
Add any other context or screenshots about the feature request here.

Tasks:

[ ] Create a new table named prefixes with the following fields:

Column name
Type
Description

Id
SERIAL

prefix
VARCHAR(32) NOT NULL
The prefix to be created

barcode_format
VARCHAR(255) NOT NULL
Format for the barcode like -. Example: ASDF-A34ADA

sequence_name
VARCHAR(32) NOT NULL
The sequence name to use like heron, pam, csm etc to maintain the sequence number

enable_children_creation
BOOLEAN NOT NULL
True/False to allow child barcode creation

is_active
BOOLEAN NOT NULL
True/False to maintain list of active/inactive prefixes

created_at
TIMESTAMP NOT NULL
Creation timestamp

modified_at
TIMESTAMP
Modified timestamp

- [ ] Add a migration to create the table
- [ ] Write script to seed the existing prefixes from the config/defaults to the new table.


Usage of OpenAITTSService cause the user audio_out_sample_rate =24000 hz which sounds cartoonic

we have to do the
wf.setframerate(16000)
in order to retrieve the real audio of user but we have to sacrifice the recording of the bot.Since my use case was more concerned about the user side so implemented it

Since I have selected the TTS as OpenAITTSService so we have to set the set_audio_sample_rate=24000 for getting the bot voice correctly and in right pace(P.S:-OpenAI voices are created with out_sample_rate=24000).
But while fetching user_recordings since the normal out_sample_rate=16000 the user voice quality is affected
so the following function for extracting only user_voice:
    with BytesIO() as buffer:
        with wave.open(buffer, "wb") as wf:
            wf.setnchannels(1)
            wf.setsampwidth(2)
            wf.setframerate(16000) #set implicitly for user_voice
            user_speech = bytearray()
            for i in range(0, len(audiobuffer._user_audio_buffer), 2):
                user_speech.extend(audiobuffer._user_audio_buffer[i:i+2])
            # wf.writeframes(audiobuffer._user_audio_buffer)
            wf.writeframes(user_speech)
        return buffer.getvalue()

Hope everyone finds it useful @aconchillo @adriancowham

Thank you @geekofycoder! We have changed the default output sample rate of Pipecat to be 24000. This is now in main and should be released this week. So, closing.


Eye Gaze and Button FocusTimeout

Overview
This PR introduce two changes:

GazeProvider has been changed to allow the possibility to use the Eye Gaze. This feature is only supported in HoloLens 2 device.
PressableButton has the property FocusSelectionTime. If a button is focused during the time specified in the property, the button will be pressed. Additionally, this PR modify the IPressableButtonFeedback class adding the void FocusTimeout(float timeout), allowing components to represent visually the timeout process till the button will be pressed.

How to test

Create a MRTK application.
In the XRScene, set the property EnableEyeGaze to true, this will enable the eye gaze.
With your eye gaze (in Hololens) or with a controller, focus one of the three round buttons during 2 seconds. The button must be pressed.

Hi @davilovick,
I have successfully added eye tracking feature to our project (see feature/tecnatom-guiadohololens branch) by enabling it on two of our buttons.
Please consider adding this commit to the PR in case you find it suitable:
https://github.com/EvergineTeam/MixedRealityToolkit/commit/247ce73a60225d7e9490c2e73380d42ce21c8201
Thank you for all the hard work mate,
—Marcos


Added additional information, fixed minor typos

Minor docs improvements:

Directed users looking to GET orders and offers to API docs
Fixed minor typos/syntactical errors
Changed code to reflect correct input for currency
Specified that listings = orders
Fixed price description
Provided context for finding orderId through API for use in SDK methods

Closed in favour of pull request #8.


Vegetarian Logo Update #813

solve Vegetarian Logo Update #813

This is pretty close! Pay attention to CONTRIBUTING.md - in particular, the start of the SVG was changed so it no longer matches the required format, which also affects the size of the image. The background should also be white rather than transparent. It also comes in just over 1,024 bytes, so you might need to make some small optimizations. Thanks!

@Eiim updated that, can you review it, please

It's still not quite there. I'm looking for these lines:
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

Also, I think you accidentally edited the Vagrant logo, please remove those changes.

Fixed in https://github.com/edent/SuperTinyIcons/commit/4a370ee39d442391dcde287a1103c7a7aafecb5f


Main project author (off top)

The original author of this project has gone missing. (I knew him personally)
:(

You mean onroundit? Sorry to hear! I never had any direct contact with him. Not sure what you are looking for from me. I just took over when he deleted his account.

I just announced. Well done for re-uploading this!


change default editor and viewer roles

Overview
We need to adjust our editor and viewer roles to be more explicit about what is allowed under infra because chef servers is getting added.
Design Details

in the editor role, change infra:* to infra:nodes:*, infra:nodeManagers:*
in the viewer role, change infra:*:get, infra:*:list to infra:nodes:get, infra:nodes:list, infra:nodeManagers:get, infra:nodeManagers:list

closing in favor of #2710


Feat/guidance page

Closes #156

Commit "chore: refactor radio options" endres til "refactor: radio options"


turn on optimization, integrate error reports with native code cache

enabling optimization will make profiling more accurate and
performative
we also want to reuse internal code cache logic for performance reasons, but it will hide every "pre-profiled" error reports when enabled naively
(just because they "don't" interpret code again, thus no profiling), so
we need to find a way to integrate pre-profiled error reports with code
caching somehow

function symgp(n)
    n == 1 && return [[n]]
    gp = Vector{Int}[]
    for s in symgp(n-1)
        for i in 1:n
            push!(gp, insert!(copy(s),i,n))
        end
    end
    return gp
end

symgp(10.0)

I turned off inlining for now, and the profiling seems to work correctly as far as I tried


emoji: Do selective local echo of emoticon conversions.

Earlier, we used to convert all occurrences of an emoticon on the
frontend. That behavior has been altered to do conversions only
when the emoticon has some terminal symbols around them, and not
any alphabet or number. Also adds tests for emoji conversions for
the above logic.
markdown: Test the translate_emoticons flag.
The main testing of the translate emoticons code is in the
node_tests/emoji.js file. This code just checks if the setting
to enable/disable the emoticon translation is being honored.
Fixes #8585 .

@timabbott this is ready for another review. The second commit tries to address your comment about that testcase, and since I wasn't sure, I made it in a separate commit that if you want, can be fixed up to the previous one.

This looks great!  Squashed the optional commit in and merged, thanks @aero31aero!


Aggregate Exception on UWP

When using sockets on UWP, I am getting a aggregate exception that is impossible to handle.  Other Android and iOS seems ok.  This is getting caught in the UnhandledException
Count = error CS0103: The name 'InnerExceptionCount' does not exist in the current context	System.AggregateException
One or more errors occurred. (There was an error deserializing the object of type System.Collections.Generic.IDictionary`2[[System.String, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]. The data at the root level is invalid. Line 1, position 1.)
"Exception of type 'System.Exception' was thrown."
Ideas?

Sorry this seems to be related to something else.


IndexRedirect component

The pattern from https://github.com/rackt/react-router/blob/v1.0.0-rc1/examples/redirect-using-index/app.js#L44 should be pulled out into a separate IndexRedirect component. It seems like a sufficiently common use case that it shouldn't just be a cookbook recipe from an example.

if that is a common use case, it might be worth merging it, thoughts @ryanflorence @mjackson ?

I feel like for something relatively simple like this, it's better to have it as a component than as a recipe in an example. I definitely use this pattern.

+1 for this, very simple to use and understand.


Drivers tarball for Offline usage with DBeaver-plugin

Discription.
I have separated Network with Postgres and MariaDB.
Users are using linux terminal server eclipse+DBeaver as eclipse plugin.
Eclipse is installed in /opt/eclipse
DBeaver-plugin is installed in /opt/eclipse/dropins/dbeaver/eclipse/plugins
It allows all users have same version of eclipsa, DBeaver.
But when user tries to connect to DB it fails cause DBeaver wants to download proper driver with dependencies from internet and store it under /home/user/.dbeaver-drivers
It is little bit impossible cause this network is separated from Internet.
Also i think that it is not really right that each user has own directory with duplicating drivers.
So DBeaver needs two features:

Possibility to download  all DB-Drivers as tarbal for installation on hosts that don't have internet
Possibility to use DB-drivers from same install directory where DBeaver-plugin is installed. For example: /opt/eclipse/dropins/dbeaver/eclipse/plugins

If i have not found this existing functionality please give me link to DB-driver tarball and documentation about DB-drivers installation for all users.

Also, DBeaver CE downloads most of the drivers from Maven Central.
You could setup Nexus repository in your local network. It could proxy entire Maven Central or just keep some artifacts with JDBC drivers you really need. And then change Maven configuration in DBeaver.
However it is quite a bit of administrative work.

I tired to use this workaround:
I downloaded all drivers to my laptop with dbeaver, '~/.dbeaver-driver' was uploaded to server  without internet.
But no luck. DBeaver tried to connect to maven.

Can someone upload all the drivers here?

Can someone upload all the drivers here?
I really think this would be nice to have an offline mode.
@serge-rider is an offline mode planned eventually? I think it should be seriously considered as important.

DBeaver supports offline mode - you can just remove references on external artifacts (like Maven artifacts or direct http links).
Also DBeaver EE is bundled with most of driver and do not tries to download them.
Potentially it is possible to make some "advanced" CE version (which will include some pre-downloaded drivers). However I don;t think we'll do this in near future.

I think an "advanced" CE version with pre-downloaded drivers would be a cool idea, I'd like to see that. I also own a copy of EE and think EE would still be worth it over CE even with bundled drivers.

Why was this closed? Is this feature being added?

This option is under the question and we are not sure that it will be implemented. Moreover, when we decide to do something like this it can be not exactly the same as described in the ticket. So, it is not make a lot of sense to keep this question opened.


Enforce limits on tile GPU memory usage

Some users are trying to view massive iModels on laptops with poor integrated graphics chips and experiencing WebGL context loss due to exhaustion of GPU memory. Most of the memory is being consumed by tiles that are not currently being drawn. In particular, we tend to keep a parent tile's graphics in memory as long as its children are in memory - so if you zoom in far enough, lots of parent tiles are hogging memory despite not being drawn.
TileAdmin.maxTotalContentBytes, if defined, specifies the maximum amount of GPU memory that should be allocated to tile contents. When this  threshold is exceeded, we dispose of tile contents in least-recently-selected order until either the limit is satisfied or we have discarded the contents of all non-selected tiles. (Here "selected" means "selected for display in any viewport").
To make this work I needed to be able to know how much memory each Tile is consuming; how much total memory all Tiles are consuming; which tiles are currently selected for display in any viewport; and a least-to-most-recently-selected ordering of all tiles. I wanted to introduce as little overhead (in additional memory and in processing) as possible. The solution is an intrusive linked list - see documentation comments on LRUTileList for details.
Tile trees need to be aware that any Tile's content can become unloaded at any time due to memory pressure, and avoid implementing tile selection in such a way that requires parents to be loaded before their children can be displayed - that would defeat the purpose and end up constantly reloading the same tile content only for it to be disposed again. IModelTile required changes in this regard.
ImageryMapTiles are weird in that they use reference-counting; disposeContents does nothing if the ref count is > 0, instead relying on the garbage collector to free their memory. That's unfortunate but LRUTileList handles it by keeping such tiles in the list.
Incidental changes:

TileAdmin was an abstract base class with one non-exported implementation. That was becoming unwieldy as every new addition to the base class interface had to be duplicated in the implementation. I collapsed them into one class.
Added OrderedSet<T> which implements the interface of Set<T> with the custom ordering of SortedArray<T>.

@RBBentley I had to disable this feature for MapTile and ImageryMapTile - with their dependence on one another and the reference-counting, there isn't really a way to determine if it's safe to discard their contents.

@markschlosseratbentley this supplants your mobileExpirationThreshold which I have removed - please review.

@markschlosseratbentley this supplants your mobileExpirationThreshold which I have removed - please review.

@pmconne  See my approval comments.  (In summary: looks great and appears to still fix iOS issues that mobileExpirationThreshold resolved).

@Mergifyio backport release/2.12.x


fix units of spell_length_distribution

Pull Request Checklist:

[ x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1003

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

[ ] bumpversion patch has been called on this branch
[ ] The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

xc.sdba.properties.spell_length_distribution has units of the input, but it should have units of days. This is fixed now.

Does this PR introduce a breaking change?
Other information:

@juliettelavoie @aulemahal I can merge this once approved, but for the checks to pass, we need to merge #1000 and #1002.

Coverage increased (+0.0006%) to 91.47% when pulling efbcf57291469b18a3625f272a06fadb8cffb224 on fix-1003 into 1f2aab4673af4b04089e82b80dcbd5c468096b07 on master.


Large gaps of GPU idle time

For some apps, we the replayer sometimes shows huge gaps of GPU idle time.  They can be clearly visible using GPU profilers. These gaps were not present during the native app, so we should investigate the root cause.

Was replay done using virtual swapchains? Can you also see these gaps without virtual swapchains being used?


Added test test_count_actual_storage_changes in rust

Added test test_count_actual_storage_changes in Rust to test the actual number of storage changes for a fee when:

Writing a new value to a contract cell
Rewriting the same value to the cell
Transfering 1 ETH to another account

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a98899c) 70.70% compared to head (7811ed3) 70.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1253   +/-   ##
=======================================
  Coverage   70.70%   70.70%
=======================================
  Files          57       57
  Lines        7135     7135
  Branches     7135     7135
=======================================
  Hits         5045     5045
  Misses       1673     1673
  Partials      417      417

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/blockifier/src/transaction/account_transactions_test.rs line 1419 at r2 (raw file):
Previously, dorimedini-starkware wrote…
Add a comment marking the second scenario

Done.


Can we use bpftrace to trace user space function within docker container?

I can trace the userspace function using uprobe but I can't trace when the process
is running in the Docker container.
I don't know how to do it or the current bpftrace doesn't support it.

Can you share what command/script you were trying to run and the error messages?

Sorry, the function is never called, so I can't trace it.


Key Vault: Elliptic curve name incompatible when using Azure CLI for importing keys.

Describe the bug

When importing an elliptic curve key of the type SECP256K1 (it might also be the case for other types, but I have only tested this type) into a Key Vault through the Azure CLI, the Elliptic curve name is set to a value which is incompatible with the Azure.Security.KeyVault.Cryptography and Azure.Security.KeyVault.Keys libraries.
Importing the key through Azure.Security.KeyVault.Keys using a KeyClient or creating a P-256K key directly through the Key Vault, the Elliptic curve name will be set as P-256K, but when using the Azure CLI, the type will be set as SECP256K1.
Both P-256K and SECP256K1 refer to the same curve.
When using the Key Vault to perform operations with the ES256K algorithm through Azure.Security.KeyVault.Keys.Cryptography using the key, an exception will be thrown with the following error message:

Key and signing algorithm are incompatible. Key  uses curve 'SECP256K1', and algorithm 'ES256K' can only be used with curve 'P-256K'.

To Reproduce

Generating a key:
openssl ecparam -name secp256k1 -genkey -noout -out private_key.pem

Importing the key through Azure CLI:
az keyvault key import --curve P-256K --kty EC --pem-file private.pem --vault-name <name> --name private_key

Importing the key through Azure.Security.KeyVault.Keys:
ECDsa ecdsa = ECDsa.Create();
string pemContent = File.ReadAllText("private_key.pem");
ecdsa.ImportFromPem(pemContent);

KeyClient keyClient = new KeyClient(uri, credential);
keyClient.ImportKey("private_key", new JsonWebKey(ecdsa));

The following code will throw an exception on the second line if the key was imported using Azure CLI:
CryptographyClient cryptographyClient = new CryptographyClient(keyId, credential);
cryptographyClient.Sign(SignatureAlgorithm.ES256K, hashedData);

Expected behavior

A valid SignResult without any exceptions thrown as when the key is imported through Azure.Security.KeyVault.Keys.
Environment summary

All .NET runs with:
.NET 5.0 SDK @ 5.0.301
Azure.Identity @ 1.4.0
Azure.Security.KeyVault.Keys @ 4.1.0
Ubuntu 20.04 Desktop:
az --version
azure-cli                         2.24.2

Windows 10 20H2:
az --version
azure-cli                         2.24.2

Ubuntu 20.04 on Windows 10 20H2 using WSL1:
az --version
azure-cli                         2.24.0 *

Additional context

keyvault


Release v0.11.2

(PR #166, 2020-12-15) requirements: Update 'cryptography'
(PR #169, 2020-12-16) build(deps): bump coverage from 4.5.3 to 5.3
(PR #172, 2020-12-22) rtc: Add data model for "Cesiones Periodo" entries
(PR #173, 2021-01-05) requirements: Add 'pydantic'
(PR #175, 2021-01-06) libs.tz_utils: Add checks to validate_dt_tz
(PR #174, 2021-01-07) rtc: Add constants and "cesión" natural keys
(PR #171, 2021-01-07) build(deps): bump codecov from 2.1.9 to 2.1.11

Codecov Report

Merging #178 (1bf1cc8) into master (fe96847) will decrease coverage by 0.52%.
The diff coverage is 70.65%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   78.14%   77.62%   -0.53%
==========================================
  Files          26       28       +2
  Lines        1725     1908     +183
  Branches      279      319      +40
==========================================
+ Hits         1348     1481     +133
- Misses        256      280      +24
- Partials      121      147      +26

Impacted Files
Coverage Δ

cl_sii/rtc/data_models_cesiones_periodo.py
55.04% <55.04%> (ø)

cl_sii/rtc/data_models.py
92.64% <92.64%> (ø)

cl_sii/libs/tz_utils.py
64.70% <100.00%> (+14.70%)
:arrow_up:

cl_sii/rtc/constants.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe96847...1bf1cc8. Read the comment docs.

Codecov Report

Merging #178 (1bf1cc8) into master (fe96847) will decrease coverage by 0.52%.
The diff coverage is 70.65%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   78.14%   77.62%   -0.53%
==========================================
  Files          26       28       +2
  Lines        1725     1908     +183
  Branches      279      319      +40
==========================================
+ Hits         1348     1481     +133
- Misses        256      280      +24
- Partials      121      147      +26

Impacted Files
Coverage Δ

cl_sii/rtc/data_models_cesiones_periodo.py
55.04% <55.04%> (ø)

cl_sii/rtc/data_models.py
92.64% <92.64%> (ø)

cl_sii/libs/tz_utils.py
64.70% <100.00%> (+14.70%)
:arrow_up:

cl_sii/rtc/constants.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe96847...1bf1cc8. Read the comment docs.


Feature request: sign and validate

Hello Phoenix/ACINQ
I would like to sign and verify a message using the static on-chain address of my wallet.
Some brokers require by law to sign a message using an on-chain address as their KYC policy. If done, I then can send fiat money directly to this wallet via this broker and Phoenix will add the liquidity to my lightning wallet. Signing a message from the broker once using the static on-chain address and validating a message is a feature I would like to use in Phoenix. Can this be implemented please?
Is there already a workaround to sign a message, like importing in Sparrow/Electrum?

I would like the ability to sign messages as well, this will help decentralize Bitcoin.
I have an ASIC (more on the way) and I'd like to mine with Ocean and take advantage of their Lightning payouts. I don't want to setup another Lightning node and would like to use my Phoenix wallet. Ocean's signing scheme requires the signature to be from the child address and not the xpriv/parent key.
I believe the signing feature is the only missing piece for Phoenix to be compatible with Ocean LN payouts, as it already supports generating a Bolt12 offer / URI.
Can this be made into a high priority request for the sake of decentralized template construction?

I would also like to see the feature sign/verify message as it is possible with breez for example.
Thank you.

De facto requirement for me


Swift4 compatibility

$ swift --version
Apple Swift version 4.0 (swiftlang-9<IP_ADDRESS> clang-900.0.37)
Target: x86_64-apple-macosx10.9

When compiling with Xcode 9, MatrixInverse.swift the following code gives the following errors (someone else had this issue too):

dgetrf_(&N, &N, &mat, &N, &pivot, &error)

dgetri_(&N, &mat, &N, &pivot, &workspace, &N, &error)

Overlapping accesses to 'N', but modification requires exclusive access; consider copying to a local variable

Also, running your unit tests was giving me errors in Swift 4 due to XCTAssertEqualWithAccuracy changing to XCTAssertEqual(::accuracy:).

I had to temporarily comment out OptimizationTests.swift:47 and OptimizationTests.swift:47 because of the following error. Any idea on this last point?
/Users/user/src/SwiftNum/Tests/OptimizationTests/OptimizationTests.swift:47:9: error: cannot invoke 'XCTAssertEqual' with an argument list of type '(Matrix, Matrix, accuracy: Double)'
        XCTAssertEqual(xMin, expectedXmin2, accuracy: 0.001)
        ^
/Users/user/src/SwiftNum/Tests/OptimizationTests/OptimizationTests.swift:47:9: note: expected an argument list of type '(@autoclosure () throws -> T, @autoclosure () throws -> T, accuracy: T, @autoclosure () -> String, file: StaticString, line: UInt)'
        XCTAssertEqual(xMin, expectedXmin2, accuracy: 0.001)
        ^
/Users/user/src/SwiftNum/Tests/OptimizationTests/OptimizationTests.swift:63:9: error: cannot invoke 'XCTAssertEqual' with an argument list of type '(Matrix, Matrix, accuracy: Double)'
        XCTAssertEqual(xMin, expectedXmin2, accuracy: 0.001)
        ^
/Users/user/src/SwiftNum/Tests/OptimizationTests/OptimizationTests.swift:63:9: note: expected an argument list of type '(@autoclosure () throws -> T, @autoclosure () throws -> T, accuracy: T, @autoclosure () -> String, file: StaticString, line: UInt)'
        XCTAssertEqual(xMin, expectedXmin2, accuracy: 0.001)
        ^

Great changes, thanks for doing this. For testing that the xMin matrices are correct, I'm a fan of keeping things simple in unit tests, and just doing it directly with subscripts.

I see you've corrected those unit tests. Thanks and great project!

Do you have any thoughts for new operations / numerical computing features I should implement / focus on?


DateRange Picker [PRO] - Access Events when dates are cleared either by the cleaner or manual removal.

Discussed in https://github.com/coreui/coreui/discussions/780

Originally posted by JPalmer-ITSM June 21, 2024
I'm trying to integrate the DateRange  picker (https://coreui.io/bootstrap/docs/forms/date-range-picker/) into a project. For each picker I have a pair  of hidden input fields that are populated via the endDateChange.coreui.date-range-picker and startDateChange.coreui.date-range-picker event. These fields have on change event listeners attached which then calls an AJAX api with the values. That part work fine.
However, when clearing the dates the paired hidden fields are not updated. This is the same regardless if the date text is removed from the rendered text field or via the "cleaner" button.
What is the best way to update dependent fields when dates are cleared?

@JPalmer-ITSM I'm working on improvements to the event handling. On Monday, I will release a new version.


potential bug in BillCosponsors - missing cosponsor data

see screen shot for Cosponsors button: http://localhost:3000/bill?id=H4568

Some coSponsors are missing data - I am not sure if that is a bug or whether the data is really not available from the API.  It's worth investigation.

Hey @jkoren, it turns out sponsors aren't necessarily members of the legislature. For example, here is the list of cosponsors for H4568:
    {
      "Id": "BMA1",
      "Name": "Brian M. Ashe",
      "Type": 1,
      "Details": "http://malegislature.gov/api/GeneralCourts/192/LegislativeMembers/BMA1"
    },
    {
      "Id": null,
      "Name": "Donald Davenport",
      "Type": 3,
      "Details": null
    },
    {
      "Id": null,
      "Name": "Mark Gold",
      "Type": 3,
      "Details": null
    },

The Type field determines the type of sponsor: 1 = Legislative Member, 2 = Committee, 3 = Public Request, 4 = Special Request
So the rows without branch are external people. We'll need to update how we handle primary and co sponsors to handle these other cases. Shall we use this issue to track that?

@alexjball that sounds good..  let's talk to Matt and the team Tuesday night.  It might be best to just leave that information missing for non-legislators, but we can ask if they want any special handling.  For example, do we want to list the type of sponsor?

conversation last night - let's get a list of all the non-legislator sponsors.  If it is a small amount - we may be able to add the data manually (governor, secretary of state).  If large, will need to think if we need a fix.  Not immediately critical.


start,add and edit can confirm new project or tag

In issue https://github.com/TailorDev/Watson/issues/191 possibility to configure Watson to warn about adding projects and/or tags that do not exist yet was requested.
This pull requests now implements this feature. By adding --confirm-new-project or --confirm-new-tag to start, add or edit commands this feature is enabled. By default --no-confirm-new-project and --no-confirm-new-tag are in effect. This feature can also be enabled by adding confirm_new_project = true and/or confirm_new_tag = true to Watson configuration file under 'options' section.

This pull request lacks:

unit tests for new features implemented
bash completions for new command line options
zsh completions for new command line options

Nice implementation :+1: ! I see no reason not to accept this Pull-Request once the items you listed will have been added.


can't access builder

Build aar but the error message shows that I can't access the Builder
is there anyone who can help?
    public void startCamera() {
        cameraHelper = new CameraXPreviewHelper();
        cameraHelper.setOnCameraStartedListener(this::onCameraStarted);
        CameraHelper.CameraFacing cameraFacing =
                USE_FRONT_CAMERA ? CameraHelper.CameraFacing.FRONT : CameraHelper.CameraFacing.BACK;
        cameraHelper.startCamera(this, cameraFacing, null, cameraTargetResolution());
    }

testmediapipe\MainActivity.java:210: error: cannot access Builder
        cameraHelper.startCamera(this, cameraFacing, null, cameraTargetResolution());
                    ^
  class file for androidx.camera.core.ImageCapture$Builder not found

Hi @ChenLiangChong ,
Could you please share complete details of the above issue , like what solutions and platform are you aiming for. And also share the detail build error.


[SPARK-15985][SQL] Eliminate redundant cast from an array without null or a map without null

What changes were proposed in this pull request?
This PR eliminates redundant cast from an ArrayType with containsNull = false or a MapType with containsNull = false.
For example, in ArrayType case, current implementation leaves a cast cast(value#63 as array<double>).toDoubleArray. However, we can eliminate cast(value#63 as array<double>) if we know value#63 does not include null. This PR apply this elimination for ArrayType and MapType in SimplifyCasts at a plan optimization phase.
In summary, we got 1.2-1.3x performance improvements over the code before applying this PR.
Here are performance results of benchmark programs:
  test("Read array in Dataset") {
    import sparkSession.implicits._

    val iters = 5
    val n = 1024 * 1024
    val rows = 15

    val benchmark = new Benchmark("Read primnitive array", n)

    val rand = new Random(511)
    val intDS = sparkSession.sparkContext.parallelize(0 until rows, 1)
      .map(i => Array.tabulate(n)(i => i)).toDS()
    intDS.count() // force to create ds
    val lastElement = n - 1
    val randElement = rand.nextInt(lastElement)

    benchmark.addCase(s"Read int array in Dataset", numIters = iters)(iter => {
      val idx0 = randElement
      val idx1 = lastElement
      intDS.map(a => a(0) + a(idx0) + a(idx1)).collect
    })

    val doubleDS = sparkSession.sparkContext.parallelize(0 until rows, 1)
      .map(i => Array.tabulate(n)(i => i.toDouble)).toDS()
    doubleDS.count() // force to create ds

    benchmark.addCase(s"Read double array in Dataset", numIters = iters)(iter => {
      val idx0 = randElement
      val idx1 = lastElement
      doubleDS.map(a => a(0) + a(idx0) + a(idx1)).collect
    })

    benchmark.run()
  }

Java HotSpot(TM) 64-Bit Server VM 1.8.0_92-b14 on Mac OS X 10.10.4
Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz

without this PR
Read primnitive array:                   Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------
Read int array in Dataset                      525 /  690          2.0         500.9       1.0X
Read double array in Dataset                   947 / 1209          1.1         902.7       0.6X

with this PR
Read primnitive array:                   Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------
Read int array in Dataset                      400 /  492          2.6         381.5       1.0X
Read double array in Dataset                   788 /  870          1.3         751.4       0.5X

An example program that originally caused this performance issue.
val ds = Seq(Array(1.0, 2.0, 3.0), Array(4.0, 5.0, 6.0)).toDS()
val ds2 = ds.map(p => {
     var s = 0.0
     for (i <- 0 to 2) { s += p(i) }
     s
   })
ds2.show
ds2.explain(true)

Plans before this PR
== Parsed Logical Plan ==
'SerializeFromObject [input[0, double, true] AS value#68]
+- 'MapElements <function1>, obj#67: double
   +- 'DeserializeToObject unresolveddeserializer(upcast(getcolumnbyordinal(0, ArrayType(DoubleType,false)), ArrayType(DoubleType,false), - root class: "scala.Array").toDoubleArray), obj#66: [D
      +- LocalRelation [value#63]

== Analyzed Logical Plan ==
value: double
SerializeFromObject [input[0, double, true] AS value#68]
+- MapElements <function1>, obj#67: double
   +- DeserializeToObject cast(value#63 as array<double>).toDoubleArray, obj#66: [D
      +- LocalRelation [value#63]

== Optimized Logical Plan ==
SerializeFromObject [input[0, double, true] AS value#68]
+- MapElements <function1>, obj#67: double
   +- DeserializeToObject cast(value#63 as array<double>).toDoubleArray, obj#66: [D
      +- LocalRelation [value#63]

== Physical Plan ==
*SerializeFromObject [input[0, double, true] AS value#68]
+- *MapElements <function1>, obj#67: double
   +- *DeserializeToObject cast(value#63 as array<double>).toDoubleArray, obj#66: [D
      +- LocalTableScan [value#63]

Plans after this PR
== Parsed Logical Plan ==
'SerializeFromObject [input[0, double, true] AS value#6]
+- 'MapElements <function1>, obj#5: double
   +- 'DeserializeToObject unresolveddeserializer(upcast(getcolumnbyordinal(0, ArrayType(DoubleType,false)), ArrayType(DoubleType,false), - root class: "scala.Array").toDoubleArray), obj#4: [D
      +- LocalRelation [value#1]

== Analyzed Logical Plan ==
value: double
SerializeFromObject [input[0, double, true] AS value#6]
+- MapElements <function1>, obj#5: double
   +- DeserializeToObject cast(value#1 as array<double>).toDoubleArray, obj#4: [D
      +- LocalRelation [value#1]

== Optimized Logical Plan ==
SerializeFromObject [input[0, double, true] AS value#6]
+- MapElements <function1>, obj#5: double
   +- DeserializeToObject value#1.toDoubleArray, obj#4: [D
      +- LocalRelation [value#1]

== Physical Plan ==
*SerializeFromObject [input[0, double, true] AS value#6]
+- *MapElements <function1>, obj#5: double
   +- *DeserializeToObject value#1.toDoubleArray, obj#4: [D
      +- LocalTableScan [value#1]

How was this patch tested?
Tested by new test cases in SimplifyCastsSuite

Test build #60636 has started for PR 13704 at commit 17f17d6.

Test build #60636 has finished for PR 13704 at commit 17f17d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60636/
Test PASSed.

can you also put the plan tree of the example program in PR description?

@cloud-fan I updated the PR description by adding plan trees.

I'm wondering why we have this Cast in DeserializeToObject. Isn't the value#63 already a double array?

@cloud-fan I think value#63 is UnsafeArrayData.
When I ran a DataFrame program, I got the following trees. Since operations for DataFrame access data in UnsafeArrayData, I think that LocalRelation and LocalTableScan keep an array as UnsafeArrayData.
val df = Seq(Array(1.0, 2.0, 3.0), Array(4.0, 5.0, 6.0)).toDF()
val df2 = df.selectExpr("value[0] + value[1] + value[2]")
df2.show
df2.explain(true)

== Analyzed Logical Plan ==
((value[0] + value[1]) + value[2]): double
Project [((value#63[0] + value#63[1]) + value#63[2]) AS ((value[0] + value[1]) + value[2])#67]
+- LocalRelation [value#63]

== Optimized Logical Plan ==
LocalRelation [((value[0] + value[1]) + value[2])#67]

== Physical Plan ==
LocalTableScan [((value[0] + value[1]) + value[2])#67]

Sorry I should say it more explicitly: value#63 is already double array type. UnsafeArrayData is an internal data representation of array type, so it seems weird to have the Cast there.

I agree that value#63 is double array type. value#63 is stored as UnsafeArrayData.
<function1> in MapElements <function1>, obj#67: double is represented by Java byte code instead of Expressions.  We have to pass an Java primitive array double[] instead of double array in UnsafeArrayData. I think that Cast performs this conversion of double array from UnsafeArrayData to double[]. This is an issue only for Dataset.
What do you think?

From the plan tree given by you, the Cast is casting value#63 to array type, not ObjectType(classOf[Array[Double]]), there should be some other reason that we need to find out(maybe it's because the nullability of array element is different).

Regarding the plan tree printout (I removed my debug information), the Cast performs conversion from UnsafeArrayData to GenericArrayData since the target type of Cast is ArrayType<DoubleType>. Since Cast shows  dataType. simpleType of the target type, it is shown as array<double>.
Regarding the generated code, we seems to be on the same page. What you said is not done in Cast now, and what I did. IIUC, current Cast code generation for array seems to be conservative. Current goal of cast code generation is to create GenericArrayData object. This code generation always creates Object[] and assign values into each Object[] element. Then, the generated code passes Object[] to the constructor of GenericArrayData. As you pointed out, if code generation takes care of nullability, it can avoid to create Object[]. Unfortunately, it is not done in [the current code](code generation for array (Lines 828-862).
The code generated by this PR can also use specialized GenericArrayData implemented by https://github.com/apache/spark/pull/13758.

the Cast performs conversion from UnsafeArrayData to GenericArrayData.

Cast is used to cast one type to another, not cast one kind of data representation to another, so I don't quite understand why the Cast is there.

This code generation always creates Object[] and assign values into each Object[] element.

This is reasonable, as it needs to take care of null elements. And we do have a chance to optimize it: if the target array type's element type is primitive and the input array type's element nullability is false, we can avoid using Object[].

Let me check which code portion inserts Cast in this tree.

And we do have a chance to optimize it: if the target array type's element type is primitive and the input array type's element nullability is false, we can avoid using Object[].
This PR generated code without using Object[] by check the above condition.

@cloud-fan, I checked the following

Let me check which code portion inserts Cast in this tree.

IIUC,  this code inserts the corresponding Cast in Analyzed Logical Plan to upcast in  Parsed Logical Plan.

Test build #61629 has started for PR 13704 at commit 2d3d34a.

Test build #61630 has started for PR 13704 at commit 256c861.

Test build #61629 has finished for PR 13704 at commit 2d3d34a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61629/
Test FAILed.

Test build #61630 has finished for PR 13704 at commit 256c861.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61630/
Test FAILed.

Test build #61677 has started for PR 13704 at commit 77859cf.

Test build #61677 has finished for PR 13704 at commit 77859cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61677/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan , regarding a cast, I think that you are correct. When we insert a cast, I pass information on ArrayType.containsNull to Cast now. In this case, it is false. As a result, after the logical optimizations, we got a plan tree with Cast. I updated the description of PR.
== Analyzed Logical Plan ==
value: double
SerializeFromObject [input[0, double, true] AS value#6]
+- MapElements <function1>, obj#5: double
   +- DeserializeToObject cast(value#1 as array<double>).toDoubleArray, obj#4: [D
      +- LocalRelation [value#1]

== Optimized Logical Plan ==
SerializeFromObject [input[0, double, true] AS value#6]
+- MapElements <function1>, obj#5: double
   +- DeserializeToObject value#1.toDoubleArray, obj#4: [D
      +- LocalRelation [value#1]

Test build #62050 has started for PR 13704 at commit 43ced15.

Test build #62050 has finished for PR 13704 at commit 43ced15.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PrimitiveArrayBenchmark extends BenchmarkBase

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62050/
Test FAILed.

Merged build finished. Test FAILed.

Test build #62057 has started for PR 13704 at commit 677d81e.

Test build #62057 has finished for PR 13704 at commit 677d81e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62057/
Test PASSed.

@cloud-fan could you please review this? As you pointed, I also changed code related to cast. I added benchmark results, too.

Test build #62071 has started for PR 13704 at commit 66800fa.

Test build #62071 has finished for PR 13704 at commit 66800fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62071/
Test PASSed.

Test build #62087 has started for PR 13704 at commit 1bbe859.

Test build #62084 has started for PR 13704 at commit c31729f.

Test build #62084 has finished for PR 13704 at commit c31729f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62084/
Test PASSed.

Test build #62087 has finished for PR 13704 at commit 1bbe859.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62087/
Test PASSed.

Merged build finished. Test PASSed.

Test build #62097 has started for PR 13704 at commit b7477de.

Test build #62097 has finished for PR 13704 at commit b7477de.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SimplifyCastsSuite extends PlanTest

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62097/
Test FAILed.

Test build #62102 has started for PR 13704 at commit d99bd20.

Test build #62102 has finished for PR 13704 at commit d99bd20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62102/
Test PASSed.

@cloud-fan I added test cases. Could you review it again?

Test build #62152 has started for PR 13704 at commit 8dd829a.

Test build #62152 has finished for PR 13704 at commit 8dd829a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62152/
Test PASSed.

Test build #62155 has started for PR 13704 at commit 466ba88.

LGTM, one last comment: https://github.com/apache/spark/pull/13704/files#r70381491
BTW can you also update the PR description? e.g. we don't need to show the difference of generated code as there is no codegen related changes.

Thanks again for your kindly reviews. I addresses both comments.

Test build #62159 has started for PR 13704 at commit e6a5772.

Test build #62155 has finished for PR 13704 at commit 466ba88.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62155/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62159/
Test PASSed.

Test build #62178 has started for PR 13704 at commit a236e5e.

Test build #62178 has finished for PR 13704 at commit a236e5e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62178/
Test PASSed.

Addressed a comment. Since the following code cannot pass information on valueContainsNull = false, I use the current code.
def map(mapType: MapType): AttributeReference =
  AttributeReference(s, mapType, nullable = false)()

Test build #62239 has finished for PR 13704 at commit 355f5a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62239/
Test PASSed.

@cloud-fan I misunderstood your comment. Now, I think that I understand it correctly and addressed.

Test build #62504 has started for PR 13704 at commit cbcfd56.

Test build #62504 has finished for PR 13704 at commit cbcfd56.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62504/
Test PASSed.

Test build #62530 has started for PR 13704 at commit e4cd571.

Test build #62530 has finished for PR 13704 at commit e4cd571.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62530/
Test FAILed.

Jenkins, retest this please

Test build #62538 has started for PR 13704 at commit e4cd571.

Test build #62538 has finished for PR 13704 at commit e4cd571.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62538/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

Test build #62570 has started for PR 13704 at commit e4cd571.

Test build #62570 has finished for PR 13704 at commit e4cd571.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62570/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan Could you please take a look?

LGTM, cc @liancheng to take another look.

@liancheng Could you please review this?

@liancheng would it be possible to review this?

ping @liancheng

@liancheng Could you please review this?
cc: @cloud-fan , we are waiting for @liancheng 's review for a long time.

Test build #64594 has started for PR 13704 at commit c8f87a1.

Test build #64594 has finished for PR 13704 at commit c8f87a1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64594/
Test PASSed.

@liancheng Could you please review this since I resolved conflict?

left some comment, let's go ahead and merge it after that :)

Test build #64658 has started for PR 13704 at commit 40ac2bc.

Test build #64658 has finished for PR 13704 at commit 40ac2bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64658/
Test PASSed.

thanks, merging to master!


refactor: ci scripts now use log_ functions

This shortens the log statements, gives them all the same timestamp
prefix, and removes the need to remember to reset the terminal.

This change is

This is really nice, can we get (now or in a future PR) a log_normal that prints the timestamp but leaves the color alone?

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Good idea. Done. This replaces almost all of the remaining uses of date -u


fixing typo lon->lng in refence.html file

Fixes: #8461

should i remove line 20 aur fix typo?

Please remove it

Please review it.


fatal: unable to auto-detect email address

Versions

Angular CLI: 6.0.5
Node: 8.11.1
OS: linux x64
Repro steps

git config --global unset user.email
ng new mytestapp

Observed behavior

*** Please tell me who you are.

Run

  git config --global user.email<EMAIL_ADDRESS>  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (

I consider that since there is a fatal error, the command has not ended successfully.
Why a generation of a new project requires that I have a globally set user.email? I setup this per-project, not globally.
Desired behavior

Not to raise a fatal error, if git user.email has not been set globally.
Mention any other details that might be useful (optional)

I am marking this as a feature, if you would like to create a project while controlling the git options, you can use the --skip-git option which will not create the repo.

Closing as this is not currently in the roadmap.


Test with Python 2 style print statements

The following test function has python 2 style print statements
https://github.com/SheffieldML/GPy/blob/bf4dc0aaa319fe00a579cdb1acabda7f366c22b2/GPy/testing/mpi_test__.py#L16-L20

Hi @oysstu
thanks for putting this up. Could be contribute a PR fixing this one?

Is it a good idea, I wonder, to continue with Python 2 support?

Hell no. We should get rid of any python2 stuff here.

I also can't think of a reason to maintain Python 2 any more.

I'm a little at the moment but I hope I'll find some time to finish some issues and PRs over summer.