Implement Clone for AccountCredentials

Currently, AccountCredentials only implements Serialize, and Deserialize, but cloning them may be useful for recreating ACME client instances. We currently do the following under the hood:
fn clone_creds(creds: &AccountCredentials) -> AccountCredentials {
    serde_json::from_str(&serde_json::to_string(&creds).unwrap()).unwrap()
}

However, I feel like this is unnecessary, and it would be better to be able to just clone the creds.

Why do you need to clone the credentials? What's the use case?

Why do you need to clone the credentials? What's the use case?

Whenever I need to recreate Account.
Account::from_credentials consumes the credentials object. Sometimes, ACME server returns an error when acquiring a session, and thus, a retry is needed. Alternatively, I experienced a case where the account session stopped working after some time, which could be fixed by recreating the Account object, which once again, requires me to clone the credentials.


Windows 10 SKU support

Is Enterprise State roaming supported on Windows 10 Pro or only Windows 10 Enterprise?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 448e1185-6acc-5928-9932-a360230319bd
Version Independent ID: 1d907bdc-b1ad-fb3d-8d75-93e1da810148
Content: Settings and data roaming FAQ
Content Source: articles/active-directory/devices/enterprise-state-roaming-faqs.md
Service: active-directory
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@alexverboon
Thanks for your feedback! We will investigate and update as appropriate.

@alexverboon The Enterprise State roaming is supported on all Windows 10 client SKUs including Windows 10 Pro.

@alexverboon We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Delete unnecessary spaces

Delete unnecessary spaces: When copying from the web page, there is an unnecessary space after the code.
Fix indent: Indentation is misaligned.

@changeworld : Thanks for your contribution! The author, @suhuruli, has been notified to review your proposed change.

@changeworld : Thanks for your contribution! The author, @suhuruli, has been notified to review your proposed change.

#sign-off


Add API to enumerate external displays in screen module

Fixes #780.

## Event: display-added

* `event` Event
* `newDisplay` Object

Emitted when `newDisplay` has been added.

## Event: display-removed

* `event` Event
* `oldDisplay` Object

Emitted when `oldDisplay` has been removed.

## Event: display-metrics-changed

* `event` Event
* `display` Object
* `changedMetricts` Array

Emitted when a `display` has one or more metrics changed, `changedMetricts` is
an array of strings that describe the changes. Possible changes are `bounds`,
`workArea`, `scaleFactor` and `rotation`.

## screen.getAllDisplays()

Returns an array of displays that are currently available.

## screen.getDisplayNearestPoint(point)

* `rect` Object
  * `x` Integer
  * `y` Integer

Returns the display nearest the specified point.

## screen.getDisplayMatching(rect)

* `rect` Object
  * `x` Integer
  * `y` Integer
  * `width` Integer
  * `height` Integer

Returns the display that most closely intersects the provided bounds.

Another example of creating a window in the external display:
var app = require('app');
var BrowserWindow = require('browser-window');

var mainWindow;

app.on('ready', function() {
  var screen = require('screen');
  var displays = screen.getAllDisplays();
  var externalDisplay = null;
  for (var i in displays) {
    if (displays[i].bounds.x > 0 || displays[i].bounds.y > 0) {
      externalDisplay = displays[i];
      break;
    }
  }

  if (externalDisplay) {
    mainWindow = new BrowserWindow({
      x: externalDisplay.bounds.x + 50,
      y: externalDisplay.bounds.y + 50,
    });
  }
});

Sounds good!

Is this in a release? I just downloaded 0.20.6 but I get undefined function for getAllDisplays() so I'll presume it's not been properly released yet? Thanks for this though :) really excited to try it soon!

It will be in next release.

Sweet! Thank you so so much for getting this added so quickly. Really appreciated!
Sent from my iPhone

On 19 Jan 2015, at 19:40, Cheng Zhao<EMAIL_ADDRESS>wrote:
It will be in next release.
—
Reply to this email directly or view it on GitHub.


:arrow_up: snippets & settings-view

This upgrades settings-view and snippets to include the ability to disable a packages snippets.
See https://github.com/atom/snippets/pull/277 https://github.com/atom/settings-view/pull/1084 and https://github.com/atom/settings-view/issues/1076 for details.
It also changes the behavior when pressing Tab after a snippet reaches an explicit end stop https://github.com/atom/snippets/pull/280
/cc: @savetheclocktower @daviwil

Looks like you'll need to run script/bootstrap and commit the changes to package-lock.json before this will build successfully.  I can give you a hand with this in a little bit if you're not able to get to it first!

@Ben3eeE @savetheclocktower hey, thank you for this needed feature
Is it possible to enable/disable not all package snippets but only some? For example, package has 20 snippets and I need to disable only 2 of them. In snippets page I can see view/copy buttons, what about enable/disable per snippet?

Hi :wave:
You can only disable all snippets similarly to how disabling keybindings work. If you want to disable individual snippets you would need to disable all of them and copy back the ones you want to your personal snippets file.

@Ben3eeE yes, this is what I thought. However, copy-pasting 18 from 20 snippets is not that great :)
It would be awesome to have a third (enable|disable) button next to copy/view buttons to have a possibility to disable some package snippets. Maybe @savetheclocktower can tell if this is possible to add, this feature would be really nice 🙏

My gut feeling is that having such an intricate UI as to allow for enabling/disabling of individual snippets would be a granularity mismatch with the rest of Atom. There’s a reason why Atom/VScode/ST lean so heavily on configuration files for customization instead of an elaborate control panel. TextMate has a UI for command/snippet customization, but it’s mostly just a thin veneer over an editor window.
(TextMate also does a lot of work in the background to allow you to customize bundles as though you were editing them directly, but actually storing those customizations as diffs so that the “pristine copies” of bundles can still receive updates. Saying “here’s what this package does; feel free to customize it in your keymap file/snippets file/init script“ punts on that by making it clear to the user how those customizations get applied.)
One possible next step would be to flesh out the relevant sections of Flight Manual so that “how do I disable just a couple of package-provided snippets” has an explicit answer. I do also think that both keymaps and snippets could have a “copy the entire contents of the package’s config file to my clipboard” button so that you can paste the whole thing into your own keymap.cson/snippets.cson file and customize it all at once.

@Aerijo’s suggestion is a good one, because then you can leave the “Enable” checkbox checked on the package’s snippets. Explicitly disabling just the ones you dislike means that you’ll still automatically get new snippets if the package author adds some in a future update.
In fact, I think I’ll look into updating the Flight Manual, because this feature should be explained such that the reader understands that disabling a snippet is just one kind of customization. Copying the snippet to your own snippets.cson is step 1; step 2 would be changing the body of the snippet or deleting the body entirely, thus turning it into a no-op.

@savetheclocktower I prefer ui toggles as they are more convenient to use for me. Atom packages have enable/disable button which works same way which is very nice.
The issue with snippets file is that when you copy-paste them and a package is updated with new snippets or updates existing ones - you now have your outdated ones.
@Aerijo suggestion is fine, it just feels like a hack when you can disable snippets but overwrite them in config file instead because you can't disable only some using ui.
I guess I'm too used to nice UX and would be happy with any your decision :)

The issue with snippets file is that when you copy-paste them and a package is updated with new snippets or updates existing ones - you now have your outdated ones.

Yeah, my second comment supersedes my first one. It’s probably an anti-pattern to dump the entire contents of a package’s snippets.cson into your own for customization purposes. That’s how quickly I can talk myself out of an idea.

it just feels like a hack when you can disable snippets but overwrite them in config file instead because you can't disable only some using ui.

Yeah, I agree that it’s an awkward line to draw. The fact that package-provided keymaps and snippets are disabled via the package settings panel instead of the user’s config file strikes me as a compromise between two valid concerns: (a) user customization should be controlled by config files wherever possible, and (b) a package’s settings page should encapsulate all the configurable aspects of that package.
My view is that snippets should behave similarly to keymaps, so if we were to add individual checkboxes for enabling/disabling snippets, we should do the same for keymaps. Now, whether we’re currently doing the correct thing for both snippets and keymaps is a matter of debate.
I’d suggest creating a new issue for discussion if you think snippets and keymaps should be able to be individually disabled from the settings panel. I haven’t been around long enough to know if the way things are now is the result of a purposeful decision or just because nobody has had a better idea.


Is there a way to change language ?

Is there a way to change calendar language ?

Yes via config

And to change number you can include moment language package

Thanks man changing moment language work great!


Typescript: Using const enum

Is it possible to use const enums with this packager? I tried the recipe but couldn't get it to work. It seems that babel is always used for transpiling instead of tsc.

@akrger Can you try this:
import { makeConfig, withPolyfills } from<EMAIL_ADDRESS>
export default makeConfig({
  bundles: {
    index: {
      entry: withPolyfills('./index.ts'),
      transform({ config }) {
        config.module.rules = [
          {
            test: /\.tsx?$/,
            loader: 'ts-loader'
          },
          ...config.module.rules.filter(rule => !rule.use[0].loader.includes('babel-loader')),
          {
            test: /\.jsx?$/,
            loader: require.resolve('babel-loader'),
              options: {
                extends: getBabelConfigPath(root),
                plugins: [
                  require.resolve(
                    '@haul-bundler/core/build/utils/fixRequireIssues'
                  ),
                ],
                /**
                 * to improve the rebuild speeds
                 * This enables caching results in ./node_modules/.cache/babel-loader/
                 * This is a feature of `babel-loader` and not babel
                 */
                cacheDirectory: dev,
              },
          },
        ];
      },
    },
  },
});

Thanks, it's working with a splice on the array, then using the spread between the tsx and jsx loader.
import { makeConfig, withPolyfills } from<EMAIL_ADDRESS>
export default makeConfig({
  bundles: {
    index: {
      entry: withPolyfills('./index.ts'),
      transform({ config }) {
        config.module.rules.splice(1, 1);
        config.module.rules = [
          {
            test: /\.tsx?$/,
            loader: 'ts-loader'
          },
          ...config.module.rules,
          {
            test: /\.jsx?$/,
            loader: require.resolve('babel-loader'),
              options: {
                extends: getBabelConfigPath(root),
                plugins: [
                  require.resolve(
                    '@haul-bundler/core/build/utils/fixRequireIssues'
                  ),
                ],
              },
          },
        ];
      },
    },
  },
});

@akrger Would you mind creating a PR to the docs with the correct config, but instead of using hardcoded values for splice using something like this:
function spliceFilter(value, condition) {
    const findIndex = value.findIndex(condition)

    if (findIndex !== -1) {
        value.splice(findIndex, 1)
        spliceFilter(value, condition)
    }
}

or something else which will find the index of the rule to remove??

I created a pull request


Ranger gatling cannot be stunned

Ranger can still fire while being stunned

This will likely require a channeling state for the player.

Added in 03848fc2c61b690c3b8e05fc14f2a6d435490e41


Rewrite CMake build scripts

See #187 for motivation.
Let's see how much I can screw up git history with the monumental rebase I did.

I'm closing this since the branch is stale and I have a newer branch. Hooray, branches.


ValueError: Dimension 0 in both shapes must be equal, but are 160 and 256 for 'discriminator/concat' (op: 'ConcatV2') with input shapes: [64,160,320,3], [64,256,512,3], [].

I have a dataset of images of size [320x160x3]  (WxHxC) .
I'm trying train a 'dcgan-like' generator on it.
hypergan train ~/path/to/my/data/ -b 64 -f png --config examples/configs/improved-gan.json --sampler static_batch --sample_every 50 -s 320x160x3
However it gives me a dimension mismatch error:
ValueError: Dimension 0 in both shapes must be equal, but are 160 and 256 for 'discriminator/concat' (op: 'ConcatV2') with input shapes: [64,160,320,3], [64,256,512,3], [].
Is it not possible to train the GAN with those image dimensions?
If I leave out the -s 320x160x3 parameter the training is at least starting (not converging apparantly though), but it seems that the images are downsampled to 64x64x3 internally which I'd like to avoid...
Any ideas how to do that?

The good news,  I fixed this issue in the next major version release(0.9).  It should fix resolution issues - I have a 300x150 training now, for example.
Bad news, 0.9 isn't release-ready yet.  In the meantime 0.8 is limited to powers of two.

0.9 has been released.  Make sure you use --resize if your input size is variable.


Icon request: Better Uptime

URL for the brand / site / app
https://betteruptime.com
Logo resources for the icon
https://betterstack.com/packs/static/logo-b9bb2de68dce64823424.svg
Proof of the Aegis-compatible 2FA
https://docs.betteruptime.com/team/account-settings/two-factor-authentication
Anything else?
No response
Confirmation

[X] I have read and followed the issue guidelines & issue form.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/icons/1_Primary/Better Uptime.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.

Thank you! ❤


Transpiling async/await to promises instead of generators for es5

According to #1564 async/await support in ES5 typescript depends on generators in ES5 to be implemented. But ES5 generators implementation has been declined.
I hope it won't mean that async/await support won't be unsupported as well, because async/await depending on generators is a false assumption, as demonstrated by fast-async. Instead of compiling async/await to generators as intermediate step, you can go straight to Promises. It results in ES5 target support and better looking code.
Could you consider implementing async/await support for ES5 target without focusing so much on generators? Most of the community finds async/await support more important.
Ping @RyanCavanaugh

async/await is already implemented via partial generator support.
npm install typescript@next

Apparently a subset of generator semantics is all that is required such that, while downlevel emit of Generators as a language feature was declined. async/await is here. Pick a Promise polyfill and try it.
I don't know the reasons for choosing generators, although I would be very much interested in finding out why they were chosen over promises. I suspect it has to do with exceptions.

Ach, yes @jonaskello mentioned it just after I posted this issue.
I'm leaving this open, though, as it straight-to-promise transcompilation could result in more readable and smaller code. I've prepared comparison of current typescript transcompilation and fast-async one in: https://gist.github.com/sheerun/68e182127f9acb894b43efed5f592d6e
Notice while preceeding "library" code is little smaller in typescript's version (though probably not in complexity, just code size), the transcompiled code is more readable and shorter:
function something() {
    return __awaiter(this, void 0, void 0, function () {
        var result;
        return __generator(this, function (_a) {
            switch (_a.label) {
                case 0: return [4 /*yield*/, fetch('http://www.google.pl')];
                case 1:
                    result = _a.sent();
                    return [2 /*return*/, 'foobar'];
            }
        });
    });
}

vs
function something() {
  return new Promise(function ($return, $error) {
    var result;
    return fetch('http://www.google.pl').then(function ($await_1) {
      result = $await_1;
      return $return('foobar');
    }.$asyncbind(this, $error), $error);
  }.$asyncbind(this));
}

As for the benefit of using generators instead of promises, maybe it leads to less closures created.

I think implementing with generators is probably more straightforward as async/await is basically just synthetic sugar over generators. Both implement the same exact same idea which is co-routines. Promises/Tasks is not a related idea, it just helps with the async/await sugar. Before C# got async/await it was easily emulated using IEnumerabe/yield which is the C# equivalent of JS generator functions.

I'm leaving this open, though, as it straight-to-promise transcompilation could result in more readable and smaller code

this may be true for code with small list of await expressions. but it does not scale for the general case. once you have a loop with an await expression, you can not use promises.

But ES5 generators implementation has been declined.

Supporting generators for ES5/ES3 is tracked by https://github.com/Microsoft/TypeScript/issues/1564


Add support for image popovers

Super simple implementation, I just check if the content type includes "image" in the existing popover script. Had to adjust styles for popoverInner a little since vertical images would have scrollbars otherwise. This still works with floating ui thankfully.
Example of this functionality in Obsidian:

Example in the Quartz Docs:

also can yall make sure that the PR title matches the rest of the commit format before squashing and merging?

Hmm think we need to re-open


Enable consistent-return rule

Add consistent-return ESLint rule. As mentioned in #5456, many functions rely on returning either a value or undefined.
I suppressed nearly all of the errors inline, with notable exceptions being in KmlDataSource.js and gulpfile.js.

Hmm, I dunno, this one seems troublesome to have to workaround.  Perhaps just keep the real fixes here and do not enable this.
Up to @mramato

I agree that all of this error suppression is bad.  What I was expecting here is that if a function sometime returns a value and sometimes doesn't, this rule would just make us specifically state return undefined; in those cases.  This makes it more clear that we really want undefined instead of it being a bug.
For example, we have a bunch of code like this:
if(!foo) {
    return;
}
//Do stuff
return result;

That would get turned into this.
if(!foo) {
    return undefined;
}
//Do stuff
return result;

@omh1280 am I misunderstanding the rule, or did you just take the approach of suppressing instead of adding the explicit undefined?  I think if you remove all of the suppression and do what I suggest above, this rule may be worth it.
Did this reveal any real problems?  If not, then I realize this may be bordering on stylistic choices, so I'm okay with just punting on this rule completely if @pjcozzi thinks it's not worth it. (If it did reveal real bugs, then it may be worth keeping).

You're totally right. I misunderstood the rule.
Updated all the suppression to instead follow the rule.

@mramato can you prioritize this? The glob change means that the eslint tests aren't running on travis

After looking at the updated code, I'm not sure this rule is worth it and since it didn't find any bugs, it's unlikely that we would introduce problems in the future because of adding this rule.  Thanks for evaluating this @omh1280!
As discussed offline, open another PR for the glob changes.

Sounds good!


fix: reset _stop when new stream is called

It resolves the issue: https://github.com/kubernetes-incubator/client-python/issues/326

Codecov Report

Merging #28 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   93.64%   93.93%   +0.28%
==========================================
  Files          11       11
  Lines         803      824      +21
==========================================
+ Hits          752      774      +22
+ Misses         51       50       -1

Impacted Files
Coverage Δ

watch/watch_test.py
97.36% <100%> (+0.93%)
:arrow_up:

watch/watch.py
100% <100%> (+1.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168c5e7...c656764. Read the comment docs.

/lgtm
Thanks.


[WIP] Example Logging Presets

The idea behind this PR is to provide an easy solution to quickly setup some basic logging configurations without having to research and understand the entire structure of the LOGGING dictionary.  The idea would be to allow the user to specify an entire LOGGING config via an env variable (see PR #197) or if they don't want to have some predefined NAUTOBOT_LOGGING_PRESET values which set it up for them which would be read from the environment.  The example here provides 3 console (useful for docker), files (useful for some VM deployments), and journal which uses the systemd journal to collect logs.  The journal is a newer way to collect logs and requires some additional packages which also need to be built from source so it might not be an example we want to go with but I wanted to put this idea out there.

I think this is terrific. Having these preset and available is perfect for an enterprise app.


Make the fields of DynamoDBError public

I want to do some case analysis based on the error that gets returned from DynamoDB (in particular, ConditionalCheckFailedException), but I can't because the __type field is private.
It would even be better if the various exceptions got translated to an enum, but I get that this is safe against API extension by DDB, so some string inspection is good enough for me.

(Is the library stable for contributing yet? -- I see the constant theme in ticket replies that some big changes are upcoming... I'm aching to send pull requests so please let me know when ;)

The major translation of the code generation from Python to Rust has landed, so yes, PRs of all shapes and sizes are welcome now. Service-specific errors are now gone on the master branch. There's just one standard AwsError type.

Closing this since there are no longer service-specific error types.


Add gemm conv sections for the verify tests

Jenkins has a timeout for running tests. As we've added more and more tests to the verify tests, it has started timing out of the limit of 5000s.  Therefore split verify tests into two additional sections e.g. "conv" and "gemm".

Is this linked to any issues?

Is this linked to any issues?

No. this is fixing CI issue.


InvalidAudience when sending message to service bus from Azure Function.

Library name and version
Azure.Messaging.ServiceBus 7.5.1
Query/Question
Can you tell me under what circumstances I would get this error when calling the  ServiceBusSender.SendMessageAsync method?
Error Message:
Put token failed. status-code: 401, status-description: InvalidAudience: The authorization header contains a token with a wrong audience..
Details:
I create the ServiceBusClient like this
        public ServiceBusClient(string fullyQualifiedNamespace, string sharedAccessKeyName, string sharedAccessKey, bool useDefaultAMQP = false)
        {
            var credential = new AzureNamedKeyCredential(sharedAccessKeyName, sharedAccessKey);
            var clientOptions = GetClientOptions(useDefaultAMQP);
            _azureServiceBusClient = new Azure.Messaging.ServiceBus.ServiceBusClient(fullyQualifiedNamespace, credential, clientOptions);
        }

I create the ServiceBusSender like this:
var serviceBusSender = _azureServiceBusClient.CreateSender(entityPath);
Call Stack:
System.UnauthorizedAccessException:
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope+<CreateSendingLinkAsync>d__77.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope+<OpenSenderLinkAsync>d__70.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpSender+<CreateLinkAndEnsureSenderStateAsync>d__28.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.FaultTolerantAmqpObject`1+<OnCreateAsync>d__6.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.Singleton`1+<GetOrCreateAsync>d__13.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Microsoft.Azure.Amqp.Singleton`1+<GetOrCreateAsync>d__13.MoveNext (Microsoft.Azure.Amqp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpSender+<SendBatchInternalAsync>d__19.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpSender+<SendBatchInternalAsync>d__19.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpSender+<>c+<<SendAsync>b__20_0>d.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy+<>c__20`1+<<RunOperation>b__20_0>d.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Threading.Tasks.ValueTask`1.get_Result (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1+ConfiguredValueTaskAwaiter.GetResult (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy+<RunOperation>d__21`2.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy+<RunOperation>d__21`2.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy+<RunOperation>d__20`1.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.Amqp.AmqpSender+<SendAsync>d__20.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.ServiceBusSender+<SendMessagesAsync>d__26.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at Azure.Messaging.ServiceBus.ServiceBusSender+<SendMessageAsync>d__25.MoveNext (Azure.Messaging.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=92742159e12e44c8)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at StandardProcess.Core.ServiceBus.ServiceBusClient+<SendMessageToTopic>d__4.MoveNext (StandardProcess.Core.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at StandardProcess.Core.Services.AutoShip.CoreAutoShipService+<SendMessageToBusAsync>d__12.MoveNext (StandardProcess.Core.Services, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null: D:\a\1\s\MicroServices\src\Utilities\StandardProcess.Core.Services\Services\AutoShip\CoreAutoShipService.cs:152)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at StandardProcess.Core.Services.AutoShip.CoreAutoShipService+<SendAutoShipConfigToBusAsync>d__8.MoveNext (StandardProcess.Core.Services, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null: D:\a\1\s\MicroServices\src\Utilities\StandardProcess.Core.Services\Services\AutoShip\CoreAutoShipService.cs:74)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult (System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
   at StandardProcess.Core.Services.AutoShip.CoreAutoShipService+<UpdateAutoShipsForOrderAsync>d__13.MoveNext (StandardProcess.Core.Services, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null: D:\a\1\s\MicroServices\src\Utilities\StandardProcess.Core.Services\Services\AutoShip\CoreAutoShipService.cs:174)

Environment
Running this code in an Azure Function, version 3.  This does not happen locally, only in my Azure Function.

Hi @sp-jeff.  Thank you for reaching out and we regret that you're experiencing difficulties.   Can you help us understand what the clientOptions are that you're passing when you create the client?

Hi @jsquire , the only one I'm setting is TransportType
return new ServiceBusClientOptions { TransportType = ServiceBusTransportType.AmqpWebSockets };

Does it work without using WebSockets? I wonder if it has something to do with the default proxy being used.

No, same issue over TCP.  I'm using an alias for the service bus namespace, we a service bus in north central US and south central US, could that have anything to do with it?  Again though, cannot reproduce locally.

I'm using an alias for the service bus namespace

Does that indicate that you're setting the fullyQualifiedNamespace to the alias rather than the name that appears in the portal?   If so, then yes - that will cause authorization issues.

so what should I use for the namespace so we would have the failover ability, I thought that was why we used the alias?  If I just use the namespace for my northcentral US service bus, will it fail over to my SC location?  They are paired in the geo-recovery screen in Azure portal

Hi @sp-jeff.   As I started to dig into this, I found that my repro was based on a typo in my test code for the key name.  After correcting the name, I'm unable to reproduce.   I've been able to successfully use the paring connection string and the components to send and receive messages.
Can you help me understand more about the environment where you're seeing failures?

Can you confirm that the connection properties match those shown in the Azure portal exactly?
Are you able to use the exact configuration in the failure environment locally and successfully send a message?
Is there any kind of proxy being used in the environment?
Is the environment doing any kind of URL rewriting for outgoing connections?
Is the application being hosted in Azure or is the connection being made from an on-prem host?

Along with the above, I'd be grateful for any additional context that you may be able to provide that would help me be able to reproduce.

Can you confirm that the connection properties match those shown in the Azure portal exactly? Yes, we have verified they match numerous times.

Are you able to use the exact configuration in the failure environment locally and successfully send a message? Yes, I have run locally with the same settings and have been able to successfully send a message to our production service bus

Is there any kind of proxy being used in the environment? No

Is the environment doing any kind of URL rewriting for outgoing connections?  No

Is the application being hosted in Azure or is the connection being made from an on-prem host? It's hosted in Azure. It's an azure function that listens to one topic for incoming messages (via service bus trigger), then sends a new message to a different topic using the Azure.Messaging.ServiceBus.ServiceBusClient class.

Hi @jsquire - when you got the error before with the typo for the key name, did you get the "InvalidAudience: The authorization header contains a token with a wrong audience.." message, or was it a different message?

Interestingly enough, I just hit this error in Event Hubs when I had an extra trailing space in the name of the Event Hub.

Hi @jsquire - when you got the error before with the typo for the key name, did you get the "InvalidAudience: The authorization header contains a token with a wrong audience.." message, or was it a different message?

No; same error and AMQP result code, but I overlooked the difference in error message.

Is the application being hosted in Azure or is the connection being made from an on-prem host? It's hosted in Azure. It's an azure function that listens to one topic for incoming messages (via service bus trigger), then sends a new message to a different topic using the Azure.Messaging.ServiceBus.ServiceBusClient class.

That would seem to rule out many of the usual environmental factors.   Is the topic that you're publishing to part of the same namespace as the subscription that the trigger is reading from?   If so, would you be so kind as to try binding to the ServiceBusClient in your function?   This will allow us to use the existing client/connection that the trigger read from successfully,
An example of doing so can be found here.

Interestingly enough, I just hit this error in Event Hubs when I had an extra trailing space in the name of the Event Hub, when using an EventHubProducerClient.

Josh's suggestion is a good one; the entity name is part of the string that forms the audience.   Can we confirm that the name of the topic that is being published to doesn't contain any leading/trailing spaces or other non-visible characters?

Josh's suggestion is a good one; the entity name is part of the string that forms the audience. Can we confirm that the name of the topic that is being published to doesn't contain any leading/trailing spaces or other non-visible characters?

Tried this with no success, when I tried to write to a topic name with leading or trailing whitespace, or even carriage return characters, they were ignored and the message still made it to my topic.
Read and write topics are the same namespace, yes. I'll try binding to the ServiceBusClient , thank you for the suggestion and link.

Read and write topics are the same namespace, yes. I'll try binding to the ServiceBusClient

Thank you.   While we're testing that, could I ask that you share (via email) the fully qualified namespace of your Service Bus, the name of the topic that you're trying to publish to, and an approximate date/time for when you saw the exception?    I'd like to reach out to the service team and understand what the service logged to see if that offers any additional insight.
My address is my GitHub handle at microsoft dot com.

@jsquire - I just sent you an email with that information

I just sent you an email with that information

Much appreciated; it was received.   It may take a day or so to get access to the logs, but I'll update here when we do.

Due to the need to exchange sensitive information, the remainder of investigation and discussion for this issue was performed over email.   The root cause was discovered as having authorization rules at the namespace and topic level with the same name.
When publishing to the topic with that rule, it appears that the service expects any further use of that to be bound to the topic rule and rejected its use with other entities.  This has been reported to the service team internally for follow-up to ensure that it is the correct behavior.


Rollback tf distribute change

We are getting some reports form customers that this is breaking TPUStrategy runs.
We don't have a nice minimal repro yet, will work on that next week! But going to roll this back for now while we figure it out.

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.50%. Comparing base (8f5ad1e) to head (a027959).

Files
Patch %
Lines

keras/src/backend/tensorflow/trainer.py
0.00%
2 Missing :warning:

keras/src/backend/tensorflow/optimizer.py
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (8f5ad1e) and HEAD (a027959). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (8f5ad1e)
HEAD (a027959)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20017       +/-   ##
===========================================
- Coverage   79.25%   57.50%   -21.76%
===========================================
  Files         500      500
  Lines       46859    46842       -17
  Branches     8631     8626        -5
===========================================
- Hits        37140    26936    -10204
- Misses       7978    18233    +10255
+ Partials     1741     1673       -68

Flag
Coverage Δ

keras
57.50% <0.00%> (-21.61%)
:arrow_down:

keras-jax
?

keras-numpy
57.50% <0.00%> (+0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make use of GitVersion to detect version

If you plan to use GitVersion, I would recommend installing and using it through a tool-manifest file.
This can be easily set up running the following commands:
dotnet new tool-manifest
dotnet tool install GitVersion.Tool

Then commit the file .config/dotnet-tools.json to the repository.
When the tool is meant to be used,
you could then call
dotnet tool restore # Will restore all tools mentioned in the tool manifest
dotnet gitversion

The same thing could then be used with GitReleaseManager (#29) as well.
NOTE: Do not work with cake, if it is planned to use that


DO NOT MERGE: Vendor in giuseppe/image:use-ostree-golang-bindings

This requires also adding github.com/ostreedev/ostree-go.
This is supposed to demonstrate how https://github.com/containers/image/pull/279 is incorporated into skopeo, right now the test suite fails.

This is now correctly done in #351.


Change text shown on deployment/application labels filter

What this PR does / why we need it:
Minor change since the previous text is a bit odd to the users.
before

after

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/trigger web-test

/trigger web-test

At least this is better than now.
/approve


[RTC-117] Move typed emitter to runtime deps

Shouldn't TypedEmitter be in runtime deps? I can see that it's in dev deps in ts-client-sdk but when it's in dev deps, VSCode cannot see on property on WebRTCEndpoint class :thinking:

Are you sure? Language Server was suggesting events names in Neovim just fine when I was modifying integration tests in membrane_rtc_engine (after building it with npm run build). I'll check it once more tho.

@ostatni5 said it looks ok so I am merging


Move Disputed To CVE State

The CNA tags  includes a 'Disputed" label that would make much more sense as a CVE state.
The three states would then be:

Published
Rejected
Disputed

As of 9/26 the breakdown of CVE State is:
PUBLISHED    249255
REJECTED      14429

Could you expand on what benefit you would expect to see from this change?
Also, why just DISPUTED? What about some of the keywords that have been used (and some new ones I haven't seen until recently)? Are these less helpful?
REJECTED      14436
DEADLOCK         15
DISPUTED          9
UNVERIFIABLE      5
SPLIT             1
UAF               1

The change would be to identify the "State" of a CVE quickly, but it appears that Tags have taken over this instead and have started to be used in the last few weeks.
Disputed seemed to be the most common state after Rejected, with a GitHub search showing over 1,000 CVEs containing the string ** DISPUTED **
Someone may have made a data change, added disputed to tags, and removed the ** from being displayed on the CVE.org website, but that description is still present in the JSON.
https://www.cve.org/CVERecord?id=CVE-2020-8812
https://github.com/CVEProject/cvelistV5/blob/5bc42f06ee73702307c480a5ebd35abaa41e3165/cves/2020/8xxx/CVE-2020-8812.json#L85
https://nvd.nist.gov/vuln/detail/CVE-2020-8812

Is DISPUTED a secondary state?  For example, could a CVE be DISPUTED and then additionally either published or rejected? (I think the answer is yes to that?)  To your point, maybe we treat disputed (and "unverifiable", etc) as a tag?
Also, I think your 1000's of matches are finding it in the X_legacyV4 section of most of the CVEs. The current v5 data only has 9 that match that.

To me, disputed is a primary state because it means the vendor is unlikely ever to patch it making the CVE not useful?
I pulled all the tag counts (from NVD data), and it was these today which are different from your list?
Tag
Blank                                    262848
[disputed]                                 1254
[unsupported-when-assigned]                 404
[exclusively-hosted-service]                 19
[unsupported-when-assigned, disputed]         1

Okay, in the cvelistv5 data, there exists the containers.cna.tags list that has these counts (as of a month ago, I need to updated my local data):
 tags                                n
 disputed                         1244
 unsupported-when-assigned         391
 exclusively-hosted-service         14
 x_open-source                       5
 x_known-exploited-vulnerability     3
 x_nt_ware                           2
... < 10 more silly x_tags >

Would these tags not allow a consumer to identify the CVEs that are disputed? Or are you suggesting that by making it a top level state, that it becomes more apparent because being DISPUTED is very important?
And to my question before, can a CVE be both REJECTED and DISPUTED? Or would DISPUTED always imply it is also published?

A CVE can't be both Rejected and Disputed.  Disputed seems to be a "limbo" state between the Published and Rejected, but does it feel more important than a normal tag?   The Disputed tag would be a time-limited tag in a perfect world until the reporter and software owner agree on the final state of the CVE.
At present, if you want to get a full list of "Accepted" CVEs, you have to do a double filtering of removing the Rejected and then a second filtering on Disputed.


chore(main): release 1.11.0

:robot: I have created a release beep boop
1.11.0 (2024-03-14)
Features

nvim: add mini.bufremove (2005b23)
nvim: finally make 3rd/image.nvim work (b8b1519)
software: adds a reinstall script that installs from INSTALLED-<machine>.md (5d6617f)

Miscellaneous

fish: update plugins (a48e3bc)
mise: add ruby as an installed global (f4f6487)
nnn: use custom preview-tui2 plugin (2432378)
nvim: add base16 plugin (9e56450)
nvim: add vim-markdown-toc plugin (9e56450)
nvim: small adjustment of image.nvim config (a06ca5f)
nvim: small changes (9e56450)
nvim: swap scroll direction in cmp preview windows (2005b23)
software: update installed (b4bc755)

Styles

nvim: format lua code (2005b23)
zsh: format (2432378)

Code Refactoring

nvim: use copilot.lua over .vim, and cmp add-on (a06ca5f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/engeir/stowfiles/releases/tag/v1.11.0 :sunflower:


CIP-30 optional args support

Closes #1132.

partialSign does nothing, cuz I am not sure what it is supposed to do in mock.
getUtxos in our code filters out collateral outputs - I am not sure if that is correct, cuz CIP-30 seems to say nothing about this.

Pre-review checklist

[x] All code has been formatted using our config (make format)
[x] Any new API features or modification of existing behavior is covered as defined in our test plan
[x] The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@jy14898 Please check if I modified template/ctl-scaffold/packages.dhall correctly.

@uhbif19 Looks good, we'll also need to push the templates commit of CTL at some point but we can leave that for later

Closed as stale.


Kpt and kustomize json patches don't work

I have created a demo repo which can be used to reproduce this.
kpt pkg get https://github.com/msonnleitner/kpttest@kpt-kustomize-patch-issue patch-issue
results in

kpt pkg get https://github.com/msonnleitner/kpttest@kpt-kustomize-patch-issue patch-issue
fetching package / from https://github.com/msonnleitner/kpttest to patch-issue
error: [ROOT]/kpt-consumer/patch-issue/kustomize/components/cors/add-cors-policy-to-virtual-service.yaml: wrong Node Kind for  expected: MappingNode was SequenceNode: value: {- op: add

This needs to be reopened. #510 was closed and it doesn't resolve this issue.
Originally posted by @jasonmcboyd in https://github.com/GoogleContainerTools/kpt/issues/506#issuecomment-668672565

@etefera any chance you can take a look at this?

@etefera @mikebz @phanimarupaka this is a duplicate of #1218

@etefera @mikebz @phanimarupaka this is a duplicate of #1218

should we close this issue and possibly add the example from @msonnleitner there?

should we close this issue and possibly add the example from @msonnleitner there?

@etefera had some ideas and is looking into whether or not it's the same underlying issue

@etefera had some ideas and is looking into whether or not it's the same underlying issue

We were able to repro this error and are investigating the best way to go about implementing the missing SequenceNode functionality in the kustomize repo.
@msonnleitner In the meantime, would changing the operation in https://github.com/msonnleitner/kpttest/blob/kpt-kustomize-patch-issue/kustomize/components/cors/add-cors-policy-to-virtual-service.yaml to replace and having the entire http node as the value suffice for your use case?

We were able to repro this error and are investigating the best way to go about implementing the missing SequenceNode functionality in the kustomize repo.
@msonnleitner In the meantime, would changing the operation in https://github.com/msonnleitner/kpttest/blob/kpt-kustomize-patch-issue/kustomize/components/cors/add-cors-policy-to-virtual-service.yaml to replace and having the entire http node as the value suffice for your use case?

@etefera Well I guess it would not suffice but then I again, I am currently evaluating kpt, so I currently don't need work arounds...

@etefera Well I guess it would not suffice but then I again, I am currently evaluating kpt, so I currently don't need work arounds...

Related: #1342.

Related: #1342.

@msonnleitner are you still having this issue? I am unable to reproduce this error with the latest release when running kpt pkg get https://github.com/msonnleitner/kpttest@kpt-kustomize-patch-issue patch-issue

@natasha41575 It seems that it is working now, can't reproduce it with 0.38.


Some altgr combination doesn't work on Ubuntu with azerty keyboard

I have some issues typing the below characters with an azerty (belgian) keyboard on ubuntu 22.04
~ (altgr + =)
` (altgr + µ)
´ (altgr + ù)

Every other keyboard combination with altgr work properly
This might be related to https://github.com/sedwards2009/extraterm/issues/408 maybe?

I'm using Linux Mint here and on the basic Belgian layout altgr + =  acts as an accent key which combines with the next letter if possible. i.e. I can write "français". But Extraterm doesn't handle it correctly but the other apps do. So, finally I can reproduce this keyboard problem. :tada:

Fixed in the 0.71.0 release.


Error calling script from NodeRed: init() should return None

I can't use this library in a script called by Node Red. Every time the script executes:
c = tinytuya.Cloud()
I get this error:
Traceback (most recent call last):
  File .node-red/assets/testTuya.py", line 39, in <module>
    initialize()
  File ".node-red/assets/testTuya.py", line 22, in initialize
    c = tinytuya.Cloud()
TypeError: __init__() should return None, not 'dict'

Hi @fmarzocca - I suspect the init() for the class is returning a JSON formatted error because you have not provided your Cloud API "Key" and "Secret".  If no parameters are sent in the init call, TinyTuya will attempt to read it from a local (current working directory) tinytuya.json file that was generated during the Wizard setup, but I suspect NodeRed doesn't allow or have access to that.
You should be able to fix this by specifying the credentials on the call:
# OPTIONAL: Turn on Debug Mode
tinytuya.set_debug(True)

# Setup Cloud Connection
c = tinytuya.Cloud(
        apiRegion="us",
        apiKey="xxxxxxxxxxxxxxxxxxxx",
        apiSecret="xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
        apiDeviceID="xxxxxxxxxxxxxxxxxxID")

# Display list of devices
devices = c.getdevices()
print("Device List: %r" % devices)


Cache bind mounts fail in case repo url contains a colon (e.g. url:port)

bind mounts for cache dirs currently fail to work in case the repository url contains a colon (see https://github.com/docker/docker/issues/8604)
e.g. '<IP_ADDRESS>:10080/user/app'
docker inspect drone-container gives the following output:
[...]

    "VolumesRW": {
        "/tmp/bundle": true,
        "10080/user/app/tmp/bundle": false
    }

[...]

This should probably be handled by docker itself, it would still be nice if one could override the default host path set by drone

I'm having the same issue that since the code is being checked out into a path with a colon, setting the classpath of java does not work.

@SerialVelocity until we have a fix you can override the default path to omit the color:
git:
  path: alternate/clone/path

as of latest release caching no longer uses mounts, so this has been resolved. New caching docs:
http://readme.drone.io/build/cache.html

N.B.:
git:
  path: alternate/clone/path

Does not seem to work anymore, seems it has to be replaced by:
workspace:
  base: /go
  path: src/github.com/octocat/hello-world

http://readme.drone.io/questions/how-to-customize-the-workspace/
Just for people like me who need to use maven, which (still) breaks down completely when there is a colon in the path (see http://maven.40175.n5.nabble.com/Issue-if-colon-in-project-path-td3281864.html).


raw_to_Xy doesn't handle gaps in data

raw_to_Xy appears to handle regular gaps in data (e.g. weekend days) but cannot handle irregular gaps such as holidays.
When fed trading data similar to the example at https://deepdow.readthedocs.io/en/latest/source/data_loading.html but covering an entire trading year it get out of sync on every holiday. E.g. a Monday that would typically trade but does not on a holiday such as Jan 20, 2020.
The result is that the assertion assert timestamps[0] == raw_df.index[lookback] fails.
This, and likely other data formatting issues, causes an error when executing history = run.launch(30) which is RuntimeError: mat1 and mat2 shapes cannot be multiplied

Hey there!
Could you please share some minimal reproducible raw_df that leads to errors? I am not sure what the main problem is. Note that you can remove all potential private information (column names, valid values, etc..).
In general, I encourage you to check the implementation of raw_to_Xy and rewrite it in a way that suits your use case.
https://github.com/jankrepl/deepdow/blob/ea894c590d41f1c0ce93679811c11c90e0f74549/deepdow/utils.py#L203
Additionally, check any of the end-to-end examples where the raw_to_Xy was not used and the X, y were created from scratch: https://deepdow.readthedocs.io/en/latest/auto_examples/index.html#end-to-end

Thank you for your response; I realize my question may not have been very clear.  I took a look at the implementation and noticed raw_to_Xy is calling pandas date_range with freq=B by default (this wasn't clear to me from the documentation).
I believe I've been able to address this particular issue by using:
from pandas.tseries.holiday import USFederalHolidayCalendar
bday_us = pd.offsets.CustomBusinessDay(calendar=USFederalHolidayCalendar())

...and then call raw_to_Xy with that custom frequency...
X, timestamps, y, asset_names, indicators = raw_to_Xy(raw_df,
                                                      lookback=lookback,
                                                      gap=gap,
                                                      horizon=horizon,
                                                      freq=bday_us,
                                                      use_log=True)

I'm still having issues and will provide sample data and additional information.

You can use the below code and the attached csv file (sample_raw_df.txt, github does not allow .csv attachments).  You'll notice the data has 19 rows (timesteps) and if we use a 5 day lookback, 0 gap, and 1 horizon it should be 14 windowed samples.  When running it through raw_to_Xy we end up with 13.
from pandas.tseries.holiday import USFederalHolidayCalendar
bday_us = pd.offsets.CustomBusinessDay(calendar=USFederalHolidayCalendar())
# MLK holiday is around Jan 19th and results in a gap if not accounted for in a custom freq for pandas

raw_df = pd.read_csv('./sample_raw_df.txt',
                     parse_dates = ['Date'],
                     index_col=['Date'])
raw_df = raw_df.sort_values(by=['Date', 'Ticker'])

raw_df = raw_df.pivot_table(index=['Date'],
                                columns='Ticker',
                                aggfunc='sum',
                                fill_value=0).swaplevel(axis=1).sort_index(1)

assert isinstance(raw_df.columns, pd.MultiIndex)
assert isinstance(raw_df.index, pd.DatetimeIndex)

n_timesteps = len(raw_df)  # 19
n_channels = len(raw_df.columns.levels[1])  # 5
n_assets = len(raw_df.columns.levels[0])  # 2

lookback, gap, horizon = 5, 0, 1

X, timestamps, y, asset_names, indicators = raw_to_Xy(raw_df,
                                                      lookback=lookback,
                                                      gap=gap,
                                                      horizon=horizon,
                                                      freq=bday_us,
                                                      use_log=True)

n_samples =  n_timesteps - lookback - horizon - gap + 1  # 14

print(f'Timesteps: {n_timesteps}, Samples: {n_samples}, X.shape {X.shape}')

assert timestamps[0] == raw_df.index[lookback]
assert X.shape == (n_samples, n_channels, lookback, n_assets) # X.shape: (13, 5, 5, 2), should be (14, 5, 5, 2)
assert asset_names == list(raw_df.columns.levels[0])
assert indicators == list(raw_df.columns.levels[1])

sample_raw_df.txt

Thank you for the example!
I would guess that the thing that confused you (I blame the documentation) is that the true value of n_samples is not always equal to len(raw_df) - lookback - horizon - gap + 1. It worked out that way in the documentation, however, if there was a different number of missing timestamps in the raw_df or a different freq it could be a totally different number.
The raw_to_Xy creates its own DateTimeIndex in the following way (see code for more details):
index = pd.date_range(start=raw_data.index[0], end=raw_data.index[-1], freq=freq)

So it does not really matter what happens in between the start and the end timestamp - the new index is just generated from scratch based on the frequency and the end points. In you example, you changed the frequency to a custom one
index_custom = pd.date_range(start=raw_df.index[0], end=raw_df.index[-1], freq=bday_us)
index_default =  pd.date_range(start=raw_df.index[0], end=raw_df.index[-1], freq='B')

print(len(index_custom), len(index_default), set(index_default) - set(index_custom))

19 20 {Timestamp('2016-01-18 00:00:00', freq='B')}

That means that just by providing your custom index you will lose 1 sample with respect to the default one.

Thanks again for the feedback.  As background  just wanted to quickly test out deepdow with a limited dataset so was following the getting_started.ipynb notebook and simply replacing the generated data with a sampling of my own closer to the format noted in Data Loading.
I'm used to creating windowed training datasets as is typical for LSTM.  E.g. 3D numpy arrays with samples, lookback, features, and the matching target array (y). Using a toy dataset fed to raw_to_Xy caused several assertions to fail which I mistook as critical.
I think it may be easier to take your earlier advice and create X and y from scratch.  Looking at the generated data in the end-to-end examples is a start tough it's only a single feature (channel).
At this point I've still not been able to get a toy dataset successfully trained (currently seeing a RuntimeError: mat1 and mat2 shapes cannot be multiplied error no doubt due to something wrong in the dataset I'm loading).
Thanks for your patience.

I'm able to get the training to run with a simple dataset (252 timesteps, 2 assets, 1 channel) and a lookback of 60, gap of 0 and horizon of 1 when I keep the channels to 1 (e.g. closing price) giving my dateset a shape of X: (191, 1, 60, 2), y: (191, 1, 1, 2)
With no other changes but adding additional channel for a total of 2 (e.g. closing and opening prices) giving my dataset a shape of X: (191, 2, 60, 2), y: (191, 2, 1, 2) I get the error RuntimeError: mat1 and mat2 shapes cannot be multiplied (32x240 and 120x2) from executing history = run.launch(30).
Have you successfully run with multiple channels?  I noticed all the examples have a single channel.

After more experimentation the relationship between the dataset shape and the network is now more clear.  I had assumed the dataset and network were generic but now I see the different networks expect different dataset shapes (e.g. number of channels).  I has assumed the errors I was seeing when attempting to train was due to something in my dataset construction.  In actuality it was a mis-match between what the network was expecting (e.g. 1 channel or multiple channels) and what I was feeding it.

Well, I hope you managed to do what you wanted! Feel free to ask any other questions at any point!
Cheers!


Fixed compilation with giflib version 5

Based on https://github.com/pld-linux/libgdiplus/blob/master/libgdiplus-giflib.patch

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

Submitted at https://build.opensuse.org/request/show/295390

Updated. https://build.opensuse.org/request/show/295392

Thanks. I don't have the authority to decide whether this is OK to be merged or not, can you reach out on the mailing list?

Announced the fix at https://bugzilla.xamarin.com/show_bug.cgi?id=5859

I just tried this out (with the added guards), but the "make check" tests fail with this patch

I added the additional guards here: https://github.com/akoeplinger/libgdiplus/commit/85fb4b4982b8c1f6d93e15982fea64e4e25efa11, feel free to pull that commit in. The libgdiplus tests run fine with it, but it'd be good to run the System.Drawing testsuite against it.

Updated. Also added unit checks to https://build.opensuse.org/request/show/295418 however there is currently no current SUSE version that still runs giflib 4 so this remains untested from my side.

Thanks, looks good :+1: I tested on Ubuntu 14.04, which is still on giflib 4 and seems fine.

build

https://jenkins.mono-project.com/job/test-libgdiplus-pull-request/7/

You should probably close https://bugzilla.xamarin.com/show_bug.cgi?id=5859 then.


Add Encoding hp-roman8

I'm developing scripts for a system which strictly uses hproman-8 but I am unable to use vscode for this since the encoding hproman-8 is not available.
I love vscode and would really love if I can use it for this development.

How to vote for this request?


Translations for Config Ui X

Maybe its possible to select an Language file to Config Ui. Would be very nice

I've been thinking about this for a while, this library looks like it will make it easier:
https://github.com/ngx-translate/core
I'll create the english language files, but I will then need help from others to create translations.

I can translate it to German if you like

I can help with German, too...

Working branch:
https://github.com/oznu/homebridge-config-ui-x/tree/enable-i18n

Thanks @razer4908 for your help so far fixing up Google Translate's attempt at english to german. A pre-release can installed using this command (don't forget to restart homebridge after you do this):
sudo npm install -g --unsafe-perm homebridge-config-ui-x@next

There is nothing to configure, the app will figure out what language to serve based on your browser settings. When this gets made live you can upgrade in-app as usual.
German translation file: https://github.com/oznu/homebridge-config-ui-x/blob/enable-i18n/ui/src/i18n/de.json

Hi @oznu,
First, let me thank you for your work.
I've took the liberty to make a pr (#105) to add French translation files.
Tell me if it's good or need re-work.
Have a nice day :smile:

Landed in 3.8.0.

I would like to bump this thread because I have a suggestion on how to work more easily with the translation of the homebridge ui. I'm involved in some translation jobs for various projects out there and many projects use POEditor - a really awesome tool that makes translation jobs a lot easier! Submit this suggestion to the creator!


Add Tcl to list of grammars supported

I noticed TCL was missing from the list of grammars? Any reason you wouldn't want to include it?
Just needs
TCL (language-tcltk)
adding to the list of grammars ( and language-tcltk present of course ).
Seems to work ok for me..

There is nothing in semanticolor to exclude TCL...?


Better errors

Handling two more error cases
1.Package does not exist
2. No internet connection

Fixes https://github.com/siddharthkp/auto-install/issues/17


Feature Request: Support for Controlling Multiple Nuki Locks with a Single ESP32

Hello,
I've been working with your nuki_hub project and it's been great for single-lock control. However, I have a scenario where I'd like to manage multiple Nuki locks using a single ESP32 to simplify my setup and reduce hardware redundancy.
My idea involves modifying the codebase to create and manage multiple instances of NukiLock, each with its own unique identifier, enabling the ESP32 to send commands to and receive statuses from multiple locks independently. This could potentially be achieved by extending the current implementation to handle an array of locks, each with distinct configuration parameters.
Would this be feasible with the current architecture of nuki_hub, or are there known limitations that would prevent this from being implemented? I’m willing to contribute to the development and testing of this feature if you think it's a viable addition to the project.
Looking forward to your thoughts and any guidance you can provide.
Best regards,
Niko (stoykow)

@technyon can probably answer this in more detail, but you are going to be limited by the lack of memory, the low CPU power, and the single radio.

This was discussed before, unfortunately I can't the issue. The point is that supporting multiple locks would add a lot of complexity to the code. Not only you need to keep track of multiple locks, the UI would need to be changed to support an unknown number of locks. Adding complexity always has a good chance to add new bugs, and considering how cheap ESPs are, it's easier if you just get a second (or third) ESP, which has the advantage that you can move them closer to each lock to improve bluetooth reception.


Move coco conversion co

[ ] add to_coco functions from bdd100k
[ ] add poly2d to RLE/polygon functions
[ ] add testcases
[ ] pass linting and pytest


Update (develop to master)

Added Data Recorder (llm_pysc2/lib/data_recorder.py)
Added Log Analyse (llm_pysc2/lib/log_analyse.py)
Added docs/config.md
Added docs/experiments_analyse.md
Updated READM.md
Updated task6 text-obs, shorten the obs to avoid 16k limitation of some LLMs
Updated config.py, optimized inheritance
Fixed action space exhibitin
Fixed task3 action space
Fixed task2 obs of phoenix weapon status
Fixed text error in task8 task description
Fixed text error in example input prompt
Fixed text error in communicator
Fixed bug in in MainAgent status 7.0 possible endless loop
Fixed bug in team gather function
Fixed bug in LlamaClient
Fixed bug in GlmClient

Added Data Recorder (llm_pysc2/lib/data_recorder.py)
Added Log Analyse (llm_pysc2/lib/log_analyse.py)
Added docs/config.md
Added docs/experiments_analyse.md
Updated READM.md
Updated task6 text-obs, shorten the obs to avoid 16k limitation of some LLMs
Updated config.py, optimized inheritance
Fixed action space exhibitin
Fixed task3 action space
Fixed task2 obs of phoenix weapon status
Fixed text error in task8 task description
Fixed text error in example input prompt
Fixed text error in communicator
Fixed bug in team gather function
Fixed bug in LlamaClient
Fixed bug in GlmClient


refactor(config): template "state after power failure" setting

I've added more variants (2 and 3 way) for the "state after power failure" and $import-ed them where possible.

I'm fine with this, but we will need to note to re-verify those as we do those folders. I've found several instances where we were missing options or an option was added at a specific fw verison.

Mental note added 😅


Add ability to enable and disable cars

This feature will allow individual cars to be enabled and disabled from the settings page.
There is one new column added to the car_settings table for storing the enabled flag. It is not nullallable and has a default value of true.
When a change to the enabled value of any car it will call the existing restart method in the vehicles file.
NOTE: This will not affect any grafana dashboards other than no new data for a car will be collected.
I found two discussions that relate to this.
https://github.com/teslamate-org/teslamate/discussions/3918
https://github.com/teslamate-org/teslamate/discussions/1049

Thanks for your suggestion. This is obviously not as hard as https://docs.teslamate.org/docs/maintenance/manually_fixing_data#remove-a-vehicle-from-the-database

Thank you for your suggestion. This is obviously not as permanent as removing the vehicle from the database: https://docs.teslamate.org/docs/maintenance/manually_fixing_data#remove-a-vehicle-from-the-database

Thanks JakobLichterfeld, I agree this is not as permanent as removing the vehicle from the database. This is more for stopping data collection on active cars associated with your Tesla account. I have a car on my account that belongs to a family member and I need to prevent data collection on that car without removing driver access.

@mark3-dev  Why the feature is not yet merged:
I'm thinking about how we can document this feature for the user. The most user-friendly way would certainly be an explanation directly in the settings.

@mark3-dev Why the feature is not yet merged: I'm thinking about how we can document this feature for the user. The most user-friendly way would certainly be an explanation directly in the settings.

Is there anything else I can do?
My original entry in the settings page was "Enabled" as the section title and "Enable data collection" for the text beside the slider. But after I realized that there were many different languages that the interface was translated to I changed it to Enabled for both since that was already translated in all the languages.

I'd suggest put a 'Learn more' link and add a page under the 'Maintenance' section with more details. Including a link back to the removing a vehicle from the database details as well.
Could also seeing merging that section and this PR under a 'Vehicle Management' page under 'Maintenance'.

My original entry in the settings page was "Enabled" as the section title and "Enable data collection" for the text beside the slider. But after I realized that there were many different languages that the interface was translated to I changed it to Enabled for both since that was already translated in all the languages.

For now I would go with your initial suggestion. Necessary translation should not prevent us from being precise in our wording for the sake of UX.

My original entry in the settings page was "Enabled" as the section title and "Enable data collection" for the text beside the slider. But after I realized that there were many different languages that the interface was translated to I changed it to Enabled for both since that was already translated in all the languages.

For now I would go with your initial suggestion. Necessary translation should not prevent us from being precise in our wording for the sake of UX.

I'll try and get that added later today.

Not saying you need to translate the message, we start with English

I think I like this one better

I think I like this one better

Agreed.


Alternate scope initialization

Something like...
let menuView = BTNavigationDropdownMenu()

let items = ["Foo", "Bar"]

override func viewDidLoad() {
     super.viewDidLoad()
     menuView = BTNavigationDropdownMenu(navigationController: self.navigationController, title: "Main Menu", items: items)
}

This would help with keeping the navigation title static, as the menuView could re-initialize in viewDidAppear()

@sinanku yes, good idea. I've just fixed this issue in release 4. Now you can initialize menuView like this: (where title parameter doesn't need to be one of the items array)
menuView = BTNavigationDropdownMenu(navigationController: self.navigationController, title: "Main Menu", items: items)

Please feel free to reopen if it's still an issue for you. Thanks!

@PhamBaTho awesome, thanks so much!

@sinanku You're welcome 🙂


Getting "Product Disconnected" message

I followed every step as you instructed in the readme file. I collected my key from dji, and connected my phone with the RC and got "Product Disconnected" message. In the dji go app my drone is connected.  what to do?

I found out that dji released new SDK and with that they changed the apps
registration location (server side), and including SDK 4.6 in cordova is
too much work for me, so I wrote one in Android studio.
On Sun, Aug 26, 2018, 6:18 AM Atomicchipmonk<EMAIL_ADDRESS>wrote:

Hi saaiful.
Do other third party applications work for your drone? A lot of times the
default application overrides other applications abilities to talk to the
controller. I would remove the DJI app as your default app and try again?
Also I only tried this on a mavic pro, so while I assume it works with
others, I am not 100% sure.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Atomicchipmonk/dji-bridge/issues/1#issuecomment-416004842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEUL-VuMaQp0Ua4kwHwOed0fF1Tod1sdks5uUelKgaJpZM4WFyky
.


Shift gear

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

26 of 26 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26

Relevant Lines:
26

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

26 of 26 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26

Relevant Lines:
26

💛  - Coveralls


Repo sync for protected CLA branch

The pull request is created from main637762322507840607 to main to fix git push error for protected CLA branch

@opbld16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


settings: fix key-value duplication check

Whenever a new key-value is about to be stored, the settings
perform check whether the value really changes. This check
after #9521 patch should work differently as \0 is not
the value terminator anymore. Because of above any value which
starts from \0 will be treated mistakenly as a NULL.
This patch uses check-length callback instead read-callback which
fix the issue and simplify the code a little.
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

Gives me these build warnings:
/Users/jhedberg/src/zephyr/subsys/settings/src/settings_store.c: In function 'settings_dup_check_cb':
/Users/jhedberg/src/zephyr/subsys/settings/src/settings_store.c:114:6: warning: unused variable 'rc' [-Wunused-variable]
  int rc;
      ^~
/Users/jhedberg/src/zephyr/subsys/settings/src/settings_store.c:113:7: warning: unused variable 'temp' [-Wunused-variable]
  char temp;
       ^~~~
[217/228] Linking C executable zephyr/zephyr_prebuilt.elf

@nvlsianpu 	this solves the issue I had with mesh_shell, thanks for fixing it! I'll wait for the compilation warnings to be fixed before approving, though.

@nvlsianpu any update on fixing the compilation warnings? It'd good to get this merged ASAP.

Codecov Report

Merging #12026 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #12026     +/-   ##
=========================================
- Coverage   48.05%   47.96%   -0.1%
=========================================
  Files         281      281
  Lines       43412    43399     -13
  Branches    10404    10403      -1
=========================================
- Hits        20863    20815     -48
- Misses      18400    18432     +32
- Partials     4149     4152      +3

Impacted Files
Coverage Δ

subsys/logging/log_output.c
59.81% <0%> (-9.59%)
:arrow_down:

subsys/logging/log_core.c
69.86% <0%> (-4.81%)
:arrow_down:

misc/printk.c
81.81% <0%> (-3.13%)
:arrow_down:

include/logging/log_msg.h
89.09% <0%> (-1.82%)
:arrow_down:

include/logging/log_core.h
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f704f91...aa37f35. Read the comment docs.

@jhe green now


fix: Tests are not breaking anymore

I the problem is when you define a root_path on FastAPI it's append the root_path to the openapi_url, but not to the docs page. This might be something from FastAPI structure, I tried to find the reason or when this changed but I couldn't find.
Pull Request Checklist

[x] Make sure to read the contributor guide here.
[x] Make sure you are making a pull request against the main branch.
[x] Make sure your pull request title matches the requested format.
[x] Make sure to lint, type-check, and run unit and API tests.

Description
The problem is when you define a root_path on FastAPI, it appends the root_path to the openapi_url, but not to the docs page.
This might be something from the FastAPI structure. I tried to find out why or when this changed, but I couldn't find it.

This still breaks for python 3.7 because the latest FastAPI version isn't supported for it. I'm kinda thinking we should stop supporting python 3.7 because FastAPI has dropped support for it as of 0.104.0.

@yuripiratello I included this in my PR for dropping python 3.7 support. Thanks!


Problems of traing

I encountered the following problems when training with BRATS dataset！Can you help me？Thanks！
File "D:\jace\pythonProject\MedSegDiff-master\MedSegDiff-master\guided_diffusion\train_util.py", line 83, in init
self._load_and_sync_parameters()
File "D:\jace\pythonProject\MedSegDiff-master\MedSegDiff-master\guided_diffusion\train_util.py", line 139, in _load_and_sync_parameters
dist_util.sync_params(self.model.parameters())
File "D:\jace\pythonProject\MedSegDiff-master\MedSegDiff-master\guided_diffusion\dist_util.py", line 76, in sync_params
dist.broadcast(p, 0)
RuntimeError: a leaf Variable that requires grad is being used in an in-place operation.

have you modified anything in the code?

Directly training on the BraTS20 dataset, the following error was reported, please answer the author thank you.

I directly trained on the BraTS20 dataset and reported the following error. Please help me answer it. Thank you.

It processes each slice individually, you should input a slice with the shape [8,5,256,256].

I directly used the BraTS20 dataset for training, now how do I need to modify it specifically, thank you

you need to extract each slice from a volume for training. you can also download brats20 dataset with slice format from kaggle

Would it be convenient for you to put a link? I also could not find the sliced brats20 dataset on kaggle. Thank you very much

Thank you. I'll try again.

The brats20 of this slice is in h5 format, and it is not consistent with the data sets t1, t1ce, t2, flair that you need. Now do you need to change the bratsloard.py file name yourself? Could you please provide your dataset directly? Thank you very much。

hi, in fact, you can simply extract the slices from volume through two lines code like:
for index in range(volume.size(2)):
slice = volume[:,:,index,:,:]
ps: MedSegDiff is not a good project for you to start in this field, a recomment route is unet->nnunet->transunet->medsegdiff.

Thank you for your advice


Daemonize process for real-time report

Added --daemonize command line option to run goaccess as a daemon (if --real-time-html enabled). It will be shipped in the upcoming version.


Adds helper function and fixes training examples

Fixes the training examples, there have to be 2 labels, like in the model instantiation
Adds helper function so that the copyright message isn't printed as part of the prompt
Adds some texts explaining the cells

The original example contains an additional label, which has been addressed in this commit. With the accompanying explanations, it is now prepared for merging.


Shortening nohello message

It's too long. It takes up a full screen on mobile. This last paragraph is nonessential to the point that we want questions asked, not greetings, so removing it is fine. Besides, there's a link to the source if they want to read more.

We should probably change the "Please continue your education" bit. Sounds very condescending.

I still think a more concise text (plus the link) should be sufficient, but let's see how people react to it.


Should output Git error

Hi,
When I execute a Git Plus action menu, if there is a Git error, the menu is stuck there forever.
For e.g, I run a push to an self-signed SSL site, which would fail.
To know the error, I have to go back to the Terminal to review it.
So I think it is better that Git Plus output the error so user know how to fix it.
Thank you,

Are you saying the error isn't being displayed in Atom and that's why you go to the terminal?

Yes!


getDistinctFields does not fully account for non-field related model reference conversion

BUG DESCRIPTION
Problem
A recent PR uncovered a problem when a related model reference is included among other distinct fields returned by getDistinctFields for the Format class in dataformst.py.  While that problem currently has a work-around, the problem is now more correctly understood and needs to be fixed to avoid future issues.  The initial hunch was that this was a bug in Django's SQL generation, but upon reporting the alleged django bug, the code intended to account for an order-by "gotcha" was revealed to contain a deficiency (based on an incomplete understanding of the gotcha).  The first fields in the distinct call must match the fields in the order_by (which our code does) and must account for the fields defined in meta.ordering (which our code does), and must do this for all related tables (which our code does) BUT they must also be sensitive to ordering "fields" that are not actual fields in the database (which our code does not do, or rather, does incorrectly). Thus, if a related model reference is included among the distinct fields of the meta.ordering fields, as in the case of CompoundSynonym's meta.ordering fields (including compound - which isn't a field), it can trigger a ProgrammingError exception that cryptically claims that the distinct field list must match the order by field list (even if the exact same list is supplied to both order_by() and distinct()).  The problem is that compounds__synonyms__compound is automagically changed to compounds__synonyms__compound__name in the order_by clause and changed into compounds__synonyms__compound__id in the distinct clause (or vice-versa - I didn't confirm, but I did confirm they were different) when it is written as SQL.
Steps to reproduce

open the django shell and enter:from DataRepo.models.peak_group import PeakGroup
qs = PeakGroup.objects.filter(msrun__sample__tissue__name__iexact="brain")
flds=pg.getDistinctFields(assume_distinct=False, included_paths=["msrun__sample__animal","peak_data","compounds","msrun__sample","msrun__sample__tissue","msrun__sample__animal__tracer_compound","msrun__sample__animal__studies","compounds__synonyms"])
qs.order_by(*flds).distinct(*flds).values_list(*flds)

Current behavior
flds =
['name',
 'pk',
 'compounds__synonyms__compound',
 'compounds__synonyms__name',
 'compounds__synonyms__pk',
 'compounds__name',
 'compounds__pk',
 'msrun__sample__animal__studies__name',
 'msrun__sample__animal__studies__pk']

When the query is executed, you get an exception:
ProgrammingError: SELECT DISTINCT ON expressions must match initial ORDER BY expressions
LINE 1: ...nd_id", "DataRepo_compoundsynonym"."compound_id", "DataRepo_...

Expected behavior
No exception
Suggested Change
Note that if you change CompoundSynonym's met ordering from:
        ordering = ["compound", "name"]

to:
        ordering = ["compound__name", "name"]

There is no exception.
Having compound in the Synonym ordering is not the problem.  It's that including it when you want to do a distinct causes the mismatch because in 1 clause it's changed to Compound's id and in the other, it's changed to name.
The getDistinctFields method needs to catch these non-field references and make sure the fields returned are real fields.  There might be a supported way of doing this.  Changes may need to be made to either or both of these methods:
dataformat.getDistinctFields
dataformat.getOrderByFields

Comment
Once this update is made, the included_paths argument to getDistinctFields can be reverted to a boolean named split_all, defaulting to False.

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Requirements

List of conditions to be met for the feature
E.g. Every column/row must display a value, i.e. cannot be empty

Limitations

A list of things this work will not fix
E.g. Getting edge case X to work requires too much effort and will not be
fixed in this effort.

Affected/Changed Components

Files
Environment variables
External executables
Database tables
Cron job settings
Etc.

DESIGN
GUI Change description
Describe changes the user will see.
Code Change Description (Pseudocode optional)
Describe code changes planned for the fix.
Tests
A test should be planned for each requirement (above), where possible.

In hindsight, we might want to drop the compound_synonym model and change the concept to an ArrayField within compound (if there are not too many advantages to keeping it, and it avoids this issue, or does not make it worse)

That may be something we will do, but it's still a work-around to an existing issue. And I intend to fix it either way.


NPOI cannot rightly detect excel file content

original.xlsx
Hi, @tony1223,
   When we use NPOI as library to read excel file (added as attachment), it cannot successfully detect the file content and return null. After we just open and resave the excel file, then read it again, the content can be successfully read and shown.

   Could you help have a look?

Thanks!

Can you show me the code of reading the Excel file? Do you use WorkbookFactory?

@tonyqus , we use excel file suffix to determine using which approach to load and read the content.
if (String.IsNullOrEmpty(stream.Name) ||
String.IsNullOrEmpty(fileExtension) ||
fileExtension.Equals(ExcelConstants.ExcelNewExtension, StringComparison.Ordinal))
{
// Try to open input file as .xlsx directly.
workbook = new XSSFWorkbook(stream);
}
else
{
if (!stream.HasLength)
{
throw HybridDeliveryException.ExcelInvalidContent(stream.FileName);
}
byte[] bytes = new byte[stream.Length];
stream.Read(bytes, 0, bytes.Length);
using (MemoryStream memstream = new MemoryStream(bytes))
{
	memstream.Position = 0;
	workbook = new HSSFWorkbook(memstream);
}

}
After get the workbook and try to read content, it returns null. After open and resave the excel file "original.xlsx", the same code can work well.

WorkbookFactory is what you need.


Typescript language server will occasionally "refresh" constantly when editing a ts file

Occasionally when editing a file, the document will enter a state where it seems like TypeScript is being continually being reset. This get's especially cumbersome as intellisense will flicker in and out and the code lens annotations will disappear and reappear causing the document to jump around.

VSCode Version: 1.12.1
OS Version: Windows 10 Creators Update

I don't have logs or reliable reproduction steps. Next time it happens I'll attempt to get logs. It seems to happen most often when doing edits that but the rest of the document in a "bad" state, like inserting a backtick `.

@RichiCoder1 pls see this documentation for how to enable logging of the TypeScript server https://code.visualstudio.com/updates/v1_11#_simplified-typescript-server-log-collection

WeirdRefresh.txt
Hopefully this is useful. Was seeing that continous refresh again

I don't see anything odd in those logs after glancing through them. @RichiCoder1  Can you also make sure that a VSCode extension is not causing this behavior. Just start code with the -disable-extensions command line flag to disable all extensions

I've seen similar issues with Typescript where typescript simply stops responding. I'll turn of my extensions for a little while and see if I still see issuing.

TSServerLog.txt
Maybe this one will provide some insights?

@RichiCoder1 Thanks. I don't see anything odd in the logs at a glance.
Please try out the VSCode latest insiders builds though. There were a few issues in VSCode 1.12 that may be causing the TS server to stop responding we try to cancel a request

tsserver - report.txt
Not only did it basically stop working (or stop working consistently), but the log file basically went from 1kb to 2mb in about the span of 2-3 minutes. This is using VSCode 1.13.1 (latest as of this post.)

Same thing happened again. Was working briefly and then intellisense stopped working and log started growing:
tsserver.zip