[$1000] Workspace - No correct error message when entering a workspace link without access

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to this link https://staging.new.expensify.com/workspace/77336CD9870F8DB1
(does not have any users)
Log in

Expected Result:
"You do not have access to this page. Are you trying to join the workspace? Please reach out to the owner of this workspace so they can add you as a member! Something else? Reach out to Concierge" error message should be shown.
Actual Result:
"Hmm... it's not here. Oops, this page cannot be found" error message is shown.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.43-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/a9d44bcf-c319-4405-b7c2-58e37125c335
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010da14427ae7a9920
Upwork Job ID:<PHONE_NUMBER>724613632
Last Price Increase: 2023-07-20

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - No correct error message when entering a workspace link without access
What is the root cause of that problem?
Here, the subtitle passed is wrong -
https://github.com/Expensify/App/blob/7fea760c2bb7556815aaca2d61861bd1cf39d6b1/src/pages/workspace/WorkspaceInitialPage.js#L188
According to the condition, notAuthorized message will be shown when policy is not empty. This is wrong since if user doesn't have access then policy will be empty and notAuthorized message will not be shown.
What changes do you think we should make in order to solve the problem?
Right now, there is no way to know if policy/workspace actually exists or if the user doesn't have access. Unless there is some data returned by backend which tells if policy even exists or not we can't properly decide whether to show the unauthorized message or unexisting policy message.
So, what we can do in the meantime is to always show notAuthorized message by changing line 188 to -
subtitleKey='workspace.common.notAuthorized'

We have to do the same change on following pages since this problem exists on all workspace pages -

WorkspaceInitialPage
WorkspaceSettingsPage
WorkspaceCardPage
WorkspaceReimbursePage
WorkspaceBillsPage
WorkspaceInvoicesPage
WorkspaceTravelPage
WorkspaceMembersPage
ReimbursementAccountPage

What alternative solutions did you explore? (Optional)
NA

I don't think this is a bug and this behaviour is expected. Hmm... it's not here. Oops, this page cannot be found error message is being displayed for the user who is trying to access workspace link he/she is not a part of. Since the user is not a part of that workspace at all the backend does not return any data for this policy and hence props.policy is empty giving this error. Error You do not have access to this page. Are you trying to join the workspace?....... error should be displayed in the case where user is trying to access workspace link he is a part of.

In case if it is taken up as bug moving forward, #23188 is similar and was raised before, can we change or add my name in reporting?

          ## Proposal

The issue #23188 is the same but it's closed. So bring the proposal here
Please re-state the problem that we are trying to solve in this issue.
Wrong error message when members try to open workspace link
What is the root cause of that problem?
We set wrong subtitleKey prop here. If props.policy is empty that means the user isn't a member of the workspace, we should show workspace.common.notAuthorized error.
https://github.com/Expensify/App/blob/e19a620d50b34029ff9c0733560f43e391c21432/src/pages/workspace/WorkspaceInitialPage.js#L188
And if not and the user isn't admin of the workspace we should display another error like You don't have permission to access this workspace because you are just a member of the workspace, not the admin of the workspace
This issue also occurs in other workspace pages: WorkspaceInviteMessagePage, WorkspaceInvitePage, WorkspaceMembersPage, ReimbursementAccountPage,
What changes do you think we should make in order to solve the problem?
We should create another translation key for the case user is a member of the workspace. And we should change the condition here like !_.isEmpty(props.policy) ? undefined : 'workspace.common.notAuthorized'
https://github.com/Expensify/App/blob/e19a620d50b34029ff9c0733560f43e391c21432/src/pages/workspace/WorkspaceInitialPage.js#L188
What alternative solutions did you explore? (Optional)

@thesahindia could you review the proposals here?

we already have an old issue https://github.com/Expensify/App/issues/12616.

So should this one be closed @thesahindia?

@lschurr We have TR steps https://expensify.testrail.io/index.php?/cases/view/2638169 for the above issue, can you please send the TR update issue if it's expected now.

This is a very old issue, so I'm not sure about the expected behavior. Please start a conversation in Slack so the team can weigh in @kbecciv


Core module in not getting added to server

Hi,
I am using aem eclipse plugin in Eclipse Mars 2 on Mac OX. I am not getting option to add core module to AEM server. It is working on Windows version of Eclispe
Regards,
Salman

Ditto... Created project from AEM perspective, didn't setup server on project creation due to Issue #67, so setup server after the fact, updated tomcat ports, right click to "Add and Remove..." and only seeing "project.ui.apps" and "project.ui.content"

Thanks to @auniverseaway, you should check the diff between your bundle pom and a vanilla bundle pom from Archetype10... For me, I was missing the following in the  section:
<plugin>
    <groupId>org.apache.sling</groupId>
    <artifactId>maven-sling-plugin</artifactId>
</plugin>

Thanks @midnit, I was also missing the same entry.

Looks like there's nothing more to do here, please reopen if needed.


When will formal version of gitea:1.21.0 to be released in docker hub?

Description
Need to confirm with gitea team when will formal version of gitea/gitea:1.21.0 to be released in docker hub? (https://hub.docker.com/r/gitea/gitea/tags)
I had raised the question in another issue and it was said to be maybe some day this week Of Oct 27, details please refer to - https://github.com/go-gitea/gitea/issues/27194#issuecomment-1767893046, while so far the formal release of gitea/gitea:1.21.0 not available in docker hub yet, and not found formal repo tag of "v1.21.0" in https://github.com/go-gitea/gitea/tags
Would you update me here when could we pull newer version of gitea/gitea:1.21.0 image from docker hub? Thanks in advance!
Gitea Version
v1.21
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
linux/amd64
How are you running Gitea?
run with gitea docker image
Database
None

It will be late because we need to wait for some PRs.

https://blog.gitea.com/release-of-1.21.0/


Please add a web submission variable for $HOME

PBS doesn't understand $HOME in the PBS header directives.
e.g. this doesn't work as expected:
#!/bin/bash
#PBS -o $HOME/logs/

Can a form variable %HOME% (set to the value of the HOME variable) be added to SOCA? That would help a lot in putting PBS logs in a central location, instead of scattered across job working directories.
#!/bin/bash
#PBS -o %HOME%/logs/

The expectation is that PBS will output job logs to $HOME/logs.

Brian -
Just to confirm:
%HOME% will be replaced by the value of https://github.com/awslabs/scale-out-computing-on-aws/blob/master/source/soca/cluster_web_ui/config.py#L25 + "/<User>"
If yes, I think it may also make sense to add another parameter for %User%.

OK, I wasn't aware that %USER_HOME% is replaced. Yes, adding %USER% should suffice.


[Enum Request] Table 5717 "Item Cross Reference"

Please convert field(4; "Cross-Reference Type"; Option) to an extensible enum.

We are not going to support Cross Reference anymore, this feature replaced by Item Reference, please check 2020 Wave 2 release

Oh, that's also new to me.
https://docs.microsoft.com/en-us/dynamics365-release-plan/2020wave2/smb/dynamics365-business-central/write-longer-item-references
https://docs.microsoft.com/en-us/dynamics365/business-central/inventory-how-use-item-cross-refs
Then why then is table Item Cross Reference not already marked as pending obsolete?

That's long story. We were not able to simple extend vendor item numbers (and therefore Item Cross-reference No.) to Code[50] as this field is in primary key for cross reference table.  In such case we made replacement solution, and introduced new set of tables with longer codes. As this is clearly breaking change for many partner extensions (and good time will be needed to adopt this change) we put Item Reference under feature key and let parallel use of both features depending on partner and customer needs. We will start obsoleting old Cross References with tag '18.0' soon so it will be visible in 2021 Wave 1.


"Address already in use" error at connection

I'm playing with the example notebook example_notebooks/imexam_ginga_example.ipynb. Third cell (a=imexam.connect(viewer='ginga')) given the following error.
I may have other sessions open from separate ipython terminals, but even if that is the case, I would have expect  a new session being opened.
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
<ipython-input-4-4ecd2ce0ba6b> in <module>()
----> 1 a=imexam.connect(viewer='ginga') #stars up a new tab with the ginga HTML5 viewer

/usr/local/lib/python3.7/site-packages/imexam/connect.py in __init__(self, target, path, viewer, wait_time, quit_window, port)
    102             self.window = ginga(exam=self.exam,
    103                                 close_on_del=quit_window,
--> 104                                 port=port)
    105             # the viewer will track imexam with callbacks
    106             self._event_driven_exam = True

/usr/local/lib/python3.7/site-packages/imexam/ginga_viewer.py in __init__(self, exam, close_on_del, logger, port, host, use_opencv)
    927
    928         super(ginga, self).__init__(exam=exam, close_on_del=close_on_del,
--> 929                                     logger=logger, port=self._port)
    930
    931     def _open_browser(self):

/usr/local/lib/python3.7/site-packages/imexam/ginga_viewer.py in __init__(self, exam, close_on_del, logger, port)
    145
    146         # create the viewer specific to this backend
--> 147         self._create_viewer(bind_prefs, viewer_prefs)
    148
    149         # TODO: at some point, it might be better to simply add a custom

/usr/local/lib/python3.7/site-packages/imexam/ginga_viewer.py in _create_viewer(self, bind_prefs, viewer_prefs, opencv, threads)
    950         self._threads = threads
    951         self._server = None
--> 952         self._start_server()
    953
    954         self.ginga_view = self._server.get_viewer('Imexam Display')

/usr/local/lib/python3.7/site-packages/imexam/ginga_viewer.py in _start_server(self)
    997             no_ioloop = True  # jupyter console and notebook
    998
--> 999         self._server.start(no_ioloop=no_ioloop)
   1000
   1001     def _shutdown(self):

/usr/local/lib/python3.7/site-packages/ginga/web/pgw/ipg.py in start(self, use_thread, no_ioloop)
    425         ], factory=self.factory, logger=self.logger)
    426
--> 427         self.http_server = self.server.listen(self.port, self.host)
    428
    429         if no_ioloop:

/usr/local/lib/python3.7/site-packages/tornado/web.py in listen(self, port, address, **kwargs)
   2040         from tornado.httpserver import HTTPServer
   2041         server = HTTPServer(self, **kwargs)
-> 2042         server.listen(port, address)
   2043         return server
   2044

/usr/local/lib/python3.7/site-packages/tornado/tcpserver.py in listen(self, port, address)
    141         the `.IOLoop`.
    142         """
--> 143         sockets = bind_sockets(port, address=address)
    144         self.add_sockets(sockets)
    145

/usr/local/lib/python3.7/site-packages/tornado/netutil.py in bind_sockets(port, address, family, backlog, flags, reuse_port)
    166
    167         sock.setblocking(0)
--> 168         sock.bind(sockaddr)
    169         bound_port = sock.getsockname()[1]
    170         sock.listen(backlog)

OSError: [Errno 48] Address already in use

I think this is a rolling bug, I can't reproduce on my end right now. I do have logic in the server startup that tries to pick an open port, it could probably use improving. @bsipocz do you get this issue every time you startup?


[angular1] angularCompileFilters lack of digest cycle

Custom filter is not immediately compiled after filter opening.
The filter gets compiled after first digest cycle which was caused by other factors of the page.

tracked by AG-123
https://www.ag-grid.com/ag-grid-pipeline/

Hi, This should be fixed in the next release


Kotlin Compilation Errors in Android Build with Expo SDK 48

Description:
I have installed the version 3.2.1 of @vonovak/react-native-theme-control library into my project, which is using Expo SDK 48. While I can successfully build the app for iOS, I am encountering Kotlin compile errors during the Android build process. Here's the specific error I'm facing:
* What went wrong:
Execution failed for task ':vonovak_react-native-theme-control:compileDebugKotlin'.
> Compilation error. See log for more details
...

Add the config plugin to app.json
Build the app for Android.

Any insights or guidance on resolving these errors would be greatly appreciated.

Hello and thanks for reporting,
this is fixed in 3.2.3
Thank you 🙂


add: yashsehgal

Description
Added @yashsehgal skills profile to static database.
Changes Proposed
Added JSON data for profile render.
Checklist

[x] I have read and followed the contribution guidelines.
[x] All new and existing tests passed.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Note to reviewers
Looking forward for the review and merge 😄

conflicts


[CV] new CV column / attribute: type of MS experiment

In the current CV term collection (the separator-delimited file now suffixed '.md') it may also be interesting to report, for what MS experiment type (e.g. DDA-high-throughput MS/MS or SRM) a quality metric can only be useful (as Wout pointed out in the QC announcement manuscript, the total number of acquired MS/MS spectra is not so helpful for SRM). By adding such a column / attribute, it is not decided, whether this will be also included in a final CV collection / ontology or whether it is stated via text in a QC format specification document or whether it is modled by a rule in a semantic validator.

so you mean the metric collection ?

We might consider changing the collection overall ... see also: https://github.com/HUPO-PSI/qcML-development/pull/21#issuecomment-215409871

This will be handled by the tools, which actually write the metrics, and the metric descriptions.


Creating new db record misbehavior

Expected behavior
when creating a new table record, onEnter or on clicking Create button, it should save the record and stay on the same page (create.htm) to enable more records creation.
Actual behavior
It redirects to 'update.htm'
Solution
one way I solved this is:
Add 'data-request-data="redirect:0' to the submit button

Your solution is fine, the default behavior to redirect to update.htm is also fine.


Language Reference: notnull constraint

Document the notnull generic constraint on the page with generic constraints. Add a brief discussion of the various attributes, and refer to the tutorial.

This is a stretch goal for July. If not, it should be the first task in August.


Feature/transfer

Coverage increased (+0.9%) to 82.813% when pulling ef0e8325da7b21b6b41c106791bbe16f288bf79a on Feature/Transfer into 7303b244b09097a7b56a0330292e98fa5dcb3747 on V2.


Update section on Ad blockers.md

Proposed changes
Update the section about Ad blockers to also cover browser privacy settings as a potential cause for data loss. Additionally, include information about using Edge as a workaround
Merge timing
<!-- When should this get merged/published?
- ASAP once approved
-
### Related issues (optional)

Slack: https://twilio.slack.com/archives/CATJY9BDW/p1701111560014619

Hey @forstisabella are we good to go ahead and merge this?

@prigiattiperrut - once you address the feedback I've provided we'll be good to go! definitely feel free to reject any of my suggestions/reach out with any questions!

All the changes look good to me! Thanks


[ONEM-23925] - add browserversion property to config of WebKitBrowser

Reupload

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: przemyslaw-gorszkowski-red:x: jacek-skiba-redYou have signed the CLA already but the status is still pending? Let us recheck it.

@emutavchi @MFransen69 what is the current state of this task? Will it be merged?

@jaroslaw-bojko-red sorry for the delayed response. Could you please describe the use case for this? Is this supposed to work together with https://github.com/rdkcentral/rdkservices/blob/sprint/23Q2/WebKitBrowser/WebKitBrowser.cpp#L44 or replace it?  it might be better to use the already-defined version instead of introducing a new one that is configured outside of the component. Having multiple versions of a single component could be confusing.
requesting @anand-ky  and @pwielders to review as well.

Added @modeveci as reviewer as well.

If you want to fetch the wpe webkit version, there are APIs which bring major,minor,macro versions of wpewebkit:
for example for 2.38.6 version you can get
webkit_get_major_version() -> e.g: 2
webkit_get_minor_version(). -> e.g:38
webkit_get_micro_version(). -> e.g: 6

We want to add browserversion (eg. 2.22, 2.28, 2.38) to WebkitBrowser.json config. In our usecase other component (UI) is checking browserversion property, and based on that value middleware logic is build.
Change is not related to API version of webkit browser plugin.

Hi @jaroslaw-bojko-red
Okay, thanks for letting us know.
I think storing version information in a file meant to configure a component will be confusing. One might expect it to influence the behavior of the component, not just to be a stored value. From that perspective it breaks the Thunder plugin architecture as the json configuration file should contain key-values that change the configuration of the plugin. One might even think by changing the value one can choose with browser version to load :)
I also agree with Eugene to not store information  that is already available elsewhere, you must make sure they are aligned and correct, so better to have that in one place.
I don't know if the browser version itself is already exposed via the JSON and/or COM RPC interface but if not, we are happy to add that. Then via these interfaces you could retrieve the correct browser version from an external component. And if you really want you can of course store the information in a different (json) file you define yourself.

Thanks @emutavchi and @MFransen69 for details argumentation. We agree with your opinion.


[Build] Removed gRPC_PROTOBUF_PACKAGE_TYPE, supporting config only

FindProtobuf isn't working as Protobuf began to use Abseil so gRPC is now using CONFIG mode for protobuf module
(Context: https://gitlab.kitware.com/cmake/cmake/-/issues/24321)

CC: @coryan


Support for ->required() on the label within a form group

By intercepting the required($conditional) function here we will add automatically the control-label-required CSS class to the <label> HTML element.
This way you are able to use CSS to style the <label> HTML element however you want, you can even use pseudo-elements to add an asterisk:
label.control-label-required:after {
    content: " *";
}

Obviously we wont interfere with Form Builder and we'll call the required() function defined within adamwathan/form no matter what. The CSS class will just be added conditionally.

Coverage decreased (-1.6%) to 89.286% when pulling d94265c420ea866934bf511ac98e96ec92ae1523 on Claymm:master into f593c3304c0ff1df9d30c0582301f5519eb43d73 on adamwathan:master.

Coverage increased (+0.2%) to 91.071% when pulling ebd0986145c43721af676dbee0912487b8133b9d on Claymm:master into f593c3304c0ff1df9d30c0582301f5519eb43d73 on adamwathan:master.

Anyone pretty please? @adamwathan?

Sure why not 🤷♂

Any change this goes into a release? Would like to avoid having to use dev-master if possible.

Done

Amazing! 🎉


[FEATURE] Allow users to set count/size limit on snapshots

Is your feature request related to a problem? Please describe.
Snapshots use extra storage. Currently, users don't have a way to control snapshots count/size and check how much size snapshot uses. Snapshots may use more storage than users expect.
Describe the solution you'd like
Leverage LH snapshot space management feature to achieve it.

Does this need a require/doc label?

Needs documentation update.
It's unclear what units are expected, e.g.:
.spec.snapshotLimit.namespaceTotalSnapshotSizeQuota: 100 is this 100 snapshots, 100 bytes or 100 GiB?

Verifying on Harvester v1.4.0-rc3 with Rancher v2.9.2
Result
$\color{green}{\textsf{PASS}}$ Check namespaceTotalSnapshotSizeUsage and vmTotalSnapshotSizeUsage values format in "default-resource-quota" CR $~~$

Can't set namespaceTotalSnapshotSizeUsage to negative value

# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
# resourcequotas.harvesterhci.io "default-resource-quota" was not valid:
# * spec.snapshotLimit.namespaceTotalSnapshotSizeQuota: Invalid value: -1: spec.snapshotLimit.namespaceTotalSnapshotSizeQuota in body should be greater than or equal to 0
#
apiVersion: harvesterhci.io/v1beta1
kind: ResourceQuota
...
spec:
  snapshotLimit:
    namespaceTotalSnapshotSizeQuota: -1
    vmTotalSnapshotSizeQuota:
      vm:<PHONE_NUMBER>0

Can't set vmTotalSnapshotSizeUsage to negative value

# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
# resourcequotas.harvesterhci.io "default-resource-quota" was not valid:
# * spec.snapshotLimit.vmTotalSnapshotSizeQuota[vm]: must be greater than or equal to 0
#
apiVersion: harvesterhci.io/v1beta1
kind: ResourceQuota
metadata:
  creationTimestamp: "2024-10-21T06:11:04Z"
  generation: 8
  name: default-resource-quota
  namespace: default
  resourceVersion: "2716201"
  uid: 16601199-dc77-4739-8c53-be0ed4d0e215
spec:
  snapshotLimit:
    namespaceTotalSnapshotSizeQuota:<PHONE_NUMBER>0
    vmTotalSnapshotSizeQuota:
      vm: -1

Can't set namespaceTotalSnapshotSizeUsage to non-integer value

# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
# resourcequotas.harvesterhci.io "default-resource-quota" was not valid:
# * spec.snapshotLimit.namespaceTotalSnapshotSizeQuota: Invalid value: "string": spec.snapshotLimit.namespaceTotalSnapshotSizeQuota in body must be of type integer: "string"
#
apiVersion: harvesterhci.io/v1beta1
kind: ResourceQuota
metadata:
  creationTimestamp: "2024-10-21T06:11:04Z"
  generation: 8
  name: default-resource-quota
  namespace: default
  resourceVersion: "2716201"
  uid: 16601199-dc77-4739-8c53-be0ed4d0e215
spec:
  snapshotLimit:
    namespaceTotalSnapshotSizeQuota: test
    vmTotalSnapshotSizeQuota:
      vm:<PHONE_NUMBER>0

Can't set vmTotalSnapshotSizeUsage to non-integer value

# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
# resourcequotas.harvesterhci.io "default-resource-quota" was not valid:
# * spec.snapshotLimit.vmTotalSnapshotSizeQuota.vm: Invalid value: "string": spec.snapshotLimit.vmTotalSnapshotSizeQuota.vm in body must be of type integer: "string"
#
apiVersion: harvesterhci.io/v1beta1
kind: ResourceQuota
metadata:
  creationTimestamp: "2024-10-21T06:11:04Z"
  generation: 8
  name: default-resource-quota
  namespace: default
  resourceVersion: "2716201"
  uid: 16601199-dc77-4739-8c53-be0ed4d0e215
spec:
  snapshotLimit:
    namespaceTotalSnapshotSizeQuota:<PHONE_NUMBER>0
    vmTotalSnapshotSizeQuota:
      vm: test

$\color{green}{\textsf{PASS}}$ Test the vmTotalSnapshotSizeUsage setting on VM in default-resource-quota $~~$

Write data to make two volumes full. (10Gi and 20Gi)

Filesystem      Size  Used Avail Use% Mounted on
devtmpfs        4.0M  8.0K  4.0M   1% /dev
tmpfs           979M  4.0K  979M   1% /dev/shm
tmpfs           392M  5.9M  386M   2% /run
tmpfs           4.0M     0  4.0M   0% /sys/fs/cgroup
/dev/vda3        10G   10G   36K 100% /
/dev/vda2        20M  3.0M   17M  15% /boot/efi
tmpfs           196M     0  196M   0% /run/user/1000
/dev/vdb         20G   20G     0 100% /mnt/vdb

✅ Create the first VMBackup. It should be allowed. The total snapshot size is 30Gi.

Clear data and write data to make two volumes full again

vm:~ # df -h
Filesystem      Size  Used Avail Use% Mounted on
devtmpfs        4.0M  8.0K  4.0M   1% /dev
tmpfs           979M  4.0K  979M   1% /dev/shm
tmpfs           392M  5.9M  386M   2% /run
tmpfs           4.0M     0  4.0M   0% /sys/fs/cgroup
/dev/vda3        10G   10G   36K 100% /
/dev/vda2        20M  3.0M   17M  15% /boot/efi
tmpfs           196M     0  196M   0% /run/user/1000
/dev/vdb         20G   20G     0 100% /mnt/vdb

Create another VM Snapshot. It should be allowed. The total snapshot size is 60Gi

NAMESPACE         NAME                                            VOLUME                                     CREATIONTIME           READYTOUSE   RESTORESIZE   SIZE          AGE
longhorn-system   snapshot-15bfa0a4-8327-49ef-bca6-9f653a7fb092   pvc-1ef5d807-1aab-46bc-9442-fa2642a571c1   2024-10-21T08:44:49Z   true<PHONE_NUMBER>0<PHONE_NUMBER>    97s
longhorn-system   snapshot-8bd5a4fe-84fe-424b-9afb-477d6e58a5e6   pvc-157c4541-db9c-4e39-a391-54f4d8f6a79a   2024-10-21T08:32:41Z   true<PHONE_NUMBER>0<PHONE_NUMBER>6   13m
longhorn-system   snapshot-c0ca8527-447e-4c36-b343-d043661c76b9   pvc-1ef5d807-1aab-46bc-9442-fa2642a571c1   2024-10-21T08:32:41Z   true<PHONE_NUMBER>0<PHONE_NUMBER>    13m
longhorn-system   snapshot-e350c427-26af-4b10-8418-d43a1749b0e3   pvc-157c4541-db9c-4e39-a391-54f4d8f6a79a   2024-10-21T08:44:50Z   true<PHONE_NUMBER>0<PHONE_NUMBER>2   96

✅ Set 30Gi virtual machine quota on the VM, It should be allowed

Clear data and write data to make two volumes full again

✅ Create the second VMBackup. It should be denied, because the total snapshot size will be 90Gi

failed to create VM backup, error: admission webhook "validator.harvesterhci.io" denied the request: total snapshot size limit 30Gi is less than total snapshot usage 87378588Ki

✅ Remove the first backup and the first snapshot. The total snapshot size is 0Gi

✅ Create a new VMBackup. It should be allowed. The total snapshot size is 30Gi

Test Information

Test Environment: Single node harvester on baremetal machine
Harvester version:  v1.4.0-rc3
Rancher version: `v2.9.2

Verify Steps
Check namespaceTotalSnapshotSizeUsage and vmTotalSnapshotSizeUsage values format in "default-resource-quota" CR

Click the Edit Virtual Machine Quota setting on the VM
Set the value to Edit Quota
Click the Edit Quota setting on the Namespace
Set the value to Edit Quota
Open K9s
Search for the resourcequotas.harvesterhci.io CR
Edit the CR
Set the namespaceTotalSnapshotSizeUsage to negative and non-integer
Set the vmTotalSnapshotSizeUsage to negative and non-integer

est the vmTotalSnapshotSizeUsage setting on VM in default-resource-quota

Clear all the setting of namespaceTotalSnapshotSizeUsage and vmTotalSnapshotSizeUsage
Create a VM has two volumes. The first volume size is 10Gi and the second volume size is 20Gi.
Write data to make two volumes full.

sudo mkfs.ext4 /dev/vdb
sudo mkdir /mnt/vdb
mount /dev/vdb /mnt/vdb

sudo dd if=/dev/zero of=/bigfile bs=1M
sudo dd if=/dev/zero of=/bigfile bs=1M

Create the first VMBackup. It should be allowed. The total snapshot size is 30Gi.
Clear data and write data to make two volumes full again
Create the first VM Snapshot. It should be allowed, The total snapshot size is 60Gi.
Set 30Gi on the VM snapshot quota. It should be allowed.
Clear data and write data to make two volumes full again.
Create the second VMBackup. It should be denied, because the total snapshot size will be 90Gi if the request is allowed.
Remove the first and the second VMBackup. The total snapshot size is 0Gi
Create a new VMBackup. It should be allowed.
Check the total snapshot size is 30Gi

During the issue verification. I notice on thing worth mentioned for the reference.

All virtual machines under the same namespace would share with the snapshot size quota set on it.

If no quota size limit set on the namespace, then each virtual machine would check and follow it's own quota size set on the vm level.


docs: Update transactional-storage-api.md

Unless I'm missing something, the url variable was not needed.
Also,I took the chance to format one option as inline code.

👋Hi there, we’re going to close this PR. All PRs prior to August 12 need to be reworked due to the platform migration to Astro.


GHA: Remove external contributor step

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3617   👈

This comment was auto-generated by Graphite.


Remove --insecure-registries flag

Signed-off-by: Yves Brissaud<EMAIL_ADDRESS>- What I did
The --insecure-registries flag is removed to have a consistent UX with
Docker CLI.
- How I did it
Instead of this flag, the list of insecure registries is retrieved from
the engine. See https://docs.docker.com/registry/insecure/ to configure
your engine to allow communication to an insecure registry.
See the engine API and RegistryConfig.IndexConfigs fields.
- How to verify it

run an insecure registry:
docker run --rm -p 5000:5000 registry:2

create an app
docker app init test-insecure

push the app against the insecure registry
docker app push --tag <IP_ADDRESS>:5000/test-insecure:0.1 test-insecure.dockerapp
It should fail with an error about HTTP (insecure) response to a HTTPS (secure) client:

http: server gave HTTP response to HTTPS client

update your daemon configuration to add the local registry as insecure (apply and restart the daemon, restart the stopped registry)
"insecure-registries": [
  "<IP_ADDRESS>:5000"
]

push again the app

Successfully pushed bundle to <IP_ADDRESS>:5000/test-insecure:0.1.

- Description for the changelog
Remove --insecure-registries flag and rely on the daemon to retrieve the list of insecure registries.

@eunomie can you rebase?

Updated:

InsecureRegistries now also returns an error instead of logging it
a dedicated end to end test has been added, pushing the same image against an insecure registry with and without daemon configuration to show
rebased

Rebased after https://github.com/docker/app/commit/acbaab0ff55a7ab6add3de65b30bc19a44e971e9 that added a new test with --insecure-registries.
InsecureRegistries is now private and named insecureRegistriesFromEngine (to not collision with variables insecureRegistries.


Not displaying in testflight

Content inside HTML (import HTML from 'react-native-render-html')tag is not visible once after archive is made (on testflight or on simulator of xcode).

I would fill out the bug report template to make sure this actually gets answered by the devs, but I have my apps working just fine in Testflight/simulator/etc with this library.
Make sure you've linked the react-native-render-html library as per the docs for iOS. If you're fetching data from a remote source, make sure your server is using SSL (https) otherwise iOS will reject the request.
It's hard to provide help and suggestions without more context/code.

⚠ You did not follow the contributing guidelines!
As stated in these:

You need to fill out the issue template. This step is mandatory! Not doing so will result in your issue getting closed. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.
Although we might still help you without all these informations, it would be unfair to let some people post issues without filling everything.


Egress Bandwidth

Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] I can track my ingress, yet not my egress.
Describe the solution you'd like
A clear and concise description of what you want to happen. Add a function to check ingress as an option.
Additional context
Add any other context or screenshots about the feature request here. I'm not sure if speedtest.net provides this function, yet iperf3, which runs against the speedtest servers, does.

No sure I follow what you're asking.

Disregard, I was tired.  There is egress.  Been working on my darn cluster too much :)


Quick QA for demo

List undone things, known bugs
QA login, signup, new site, edit site, question sections 1-4, look and feel stuff
Extra check after form edit: hit refresh to make sure sumbitted values went to the api and get pulled and loaded correctly again into the front end

https://gmw-users-test.herokuapp.com/

Undone things off the top of my head:

section 5+
editing/creating/deleting landscapes and orgs
extra details on sites list card, and landscapes list card

Gerneral overall aestic is still in progress which includes, but not limited to:

Links will be styled better
Hover states on desktop
More informative Site cards
Logo image
Placeholder text in inputs should be lighter, as to not confuse with an answer from the user

Creating a new site:

New site form should have all required fields in section 1
After creating a new site, should be navigated to section two. Since all of section 1 will be complete when creating the site.

All sections:

Submit button should be more informative. something like "Save change", "Save and continue to next section"
Should prompt before navigating away from an unsaved form
Don't show errors until form is submitted. For example: When editing question 2.1, if you uncheck everything, the error stakeholders field must have at least 1 items is displayed.
Pluralization in error messages

Section 1:

z-index issue: Country dropdown goes under question 1.3 when the page is scrolled to the bottom. Can't select country.
z-index issue: file success upload is hidden by submit button container
After success geojson file upload, nothing changed on the map
Project start date can be after project end date

Section 2:

None of the questions in section 2 are required.
Stakeholder name are prepopulated with previously submitted values.

Check some stakeholder

Fill out the name field

save and reload

Uncheck a previously checked stakeholder

check another one

noticed that the name filed is populated with the value from the first field.

Question 2.1 - can't click checkbox labels to select checkbox.
Question 2.5 - should it be single choice? How can it be Full Protection AND Partial Protection?

Section 3:

Question 3.3 is not required

Section 4:

Question 4.2 is not required.
Answering "no" and clicking submit does not give confirmation toast of being saved.
Only some labels check/uncheck the associated boxes when clicked (after GEOLOGICAL EVENTS)?
Font size mismatch on labels after GEOLOGICAL EVENTS.
Error message not Human readable causesOfDecline field must have at least 1 items
Pluralization in above error message, should be 1 item (no s)
Two asterisks on first Magnitude of impact dropdown, other options have one. Should have none since they're not required
Question 4.3 is not required, but the app only shows confirmation of being saved when all of Q4.3 is complete
After answering 'Yes' on question 4.1, if you change your anser to "no" it should also hide question 4.3.


cass-operator image tag is not updated to v1.7.1 in cass-operator-manifests.yaml in 1.7.1 release

What happened?
Did you expect to see something different?
How to reproduce it (as minimally and precisely as possible):
Environment

Cass Operator version:
Insert image tag or Git SHA here

* Kubernetes version information:    `kubectl version`
  * Kubernetes cluster kind:```

insert how you created your cluster: kops, bootkube, etc.

* Manifests:

insert manifests relevant to the issue

* Cass Operator Logs:

insert Cass Operator logs relevant to the issue here

**Anything else we need to know?**:

┆Issue is synchronized with this [Jira Task](https://k8ssandra.atlassian.net/browse/K8SSAND-487) by [Unito](https://www.unito.io)
┆Fix Versions: k8ssandra-1.2.0,cass-operator-1.7.1

Hi @anoopps79
Where are you getting cass-operator-manifests.yaml?

I checked
the one in zip (https://github.com/k8ssandra/cass-operator/archive/refs/tags/v1.7.1.zip)
as well as in this location (https://raw.githubusercontent.com/k8ssandra/cass-operator/v1.7.1/docs/user/cass-operator-manifests.yaml)
Both still have
image: k8ssandra/cass-operator:v1.7.0

https://hub.docker.com/layers/k8ssandra/cass-operator/v1.7.1/images/sha256-252b5d3874d82808a86b90148b7926efd86b69726642f16e672c3fe67356f343?context=explore
Docker hub has the v1.7.1 tag listed

So may be we need to refresh the bits after the fix

Verified that it is fixed


Add more basic examples

This adds a couple of basic examples showing

basic GPIO
SPI
UART
I2C

Such nice! Many thanks!


cumsum drops coordinate in Dataset but not DataArray

What happened?
Inconsistent behavior between cumulative sum on Dataset and DataArrray - Dataset.cumsum drops coordinate along reduction dim (even though cumsum is not actually a reduction).
DataArray does not do this. The dimension is still there, but as a dimension without a coordinate.
What did you expect to happen?
Expected Dataset to behave like DataArray, without dropping the coordinate.
Minimal Complete Verifiable Example
import xarray as xr

ds = xr.Dataset({"var1": (('dim1', ), [0, 1, 2])}, coords={"dim1": ['a', 'b', 'c']})
print(ds)

print("\n\nDataset cumsum:\n")
print(ds.cumsum(dim="dim1"))

print("\n\nDataArray cumsum:\n")
print(ds["var1"].cumsum(dim="dim1"))

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.
[X] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
<xarray.Dataset> Size: 36B
Dimensions:  (dim1: 3)
Coordinates:
  * dim1     (dim1) <U1 12B 'a' 'b' 'c'
Data variables:
    var1     (dim1) int64 24B 0 1 2

Dataset cumsum:

<xarray.Dataset> Size: 24B
Dimensions:  (dim1: 3)
Dimensions without coordinates: dim1
Data variables:
    var1     (dim1) int64 24B 0 1 3

DataArray cumsum:

<xarray.DataArray 'var1' (dim1: 3)> Size: 24B
array([0, 1, 3])
Coordinates:
  * dim1     (dim1) <U1 12B 'a' 'b' 'c'

Anything else we need to know?


code cleaning

Some cleaning of part of the code

@Magalex2x14 This was one of your own code optimizations you had in 0.7.1 beta. I just did it again on the latest code (all credits to you :-).

OK )

There are many good changes in that branch, but there were also controversial ones. Since I broke that stream with my long absence, now I can't remember all the nuances. I remember one thing - there was a change that spawned the data collection thread only once at system startup. Now we have this thread re-created each time at the beginning of a new measurement period. I think it's better to leave it that way until we learn to catch all possible problems on the hci interface. Otherwise, users who use our component in conjunction with other bt components risk being left without data at all...

If you like, then keep pushing those changes to the current branch. I didn't plan to return to that beta anytime soon. I want to finish reading the missed issues first.

Yes, sure. I started with the easy changes :-). I propose to make small steps (commits). I also have an idea about the configuration parameters, but will make a separate issue for that to discuss.


Add custom rendering infrastructure

Move all classes to src/ and all tests to tests/. That eases the integration with composer and phpunit.
Add custom rendering twig function route_tree_render(name, options)
Add custom simple route voter (that ignores the route parameters).
Also add a custom template that uses the “navigation” translation domain by default.
Set better default classes that more match our style

We aren't using CS here, so i would not add it in this PR (but rather a separate PR).
And yeah, it's still not working in PHP 7.3


Feature Request: Add support for retrieving all uploaded files and querying fine-tuned models

I hope this message finds you well. I have been using your "gozhong" package for integrating with the OpenAI API, and I am impressed with its functionality. I wanted to reach out to suggest a feature enhancement and seek guidance on a related topic.

Feature Request: Retrieving all uploaded files
I would like to propose adding support for retrieving all uploaded files from the OpenAI API. Currently, it seems that the package lacks the functionality to fetch a list of all files uploaded by the user. According to the OpenAI API documentation, the /v1/files endpoint allows users to list their uploaded files by making a GET request to the following URL: https://api.openai.com/v1/files. Integrating this functionality into the "gozhong" package would greatly improve the user experience and enable better management and monitoring of uploaded files. Additionally, it would be beneficial to have the ability to retrieve specific file information such as ID, name, and other metadata.

Querying fine-tuned models
Another aspect I would like to discuss is the usage of fine-tuned models. It would be helpful if the package could provide guidance or examples on how to use fine-tuned models in conjunction with the OpenAI API. Specifically, I am interested in understanding the recommended approach for utilizing my own fine-tuned models in the requests made through the "gozhong" package. Any insights or code snippets demonstrating this integration would be greatly appreciated.

I believe that incorporating these features into the "gozhong" package would significantly enhance its usability and value to the community. I understand that implementing these changes may require additional effort, but I believe they would greatly benefit users like myself who rely on your package for OpenAI integration.
Thank you for your time and consideration. I look forward to your response and any insights you can provide regarding these suggestions.

@emoob

Feature Request: Retrieving all uploaded files

Implemented https://github.com/sashabaranov/go-openai/pull/348

Querying fine-tuned models

Would anyone be able to write some clear sample code for the example/ directory or in the README?

@vvatanabe I can help here to provide example for usage of fine tune

@emoob Added an example of fine tune model in #438.


KeyError: 'name' occurred in Overview() method

Since sanctions occured at 27 Feb, 2003 Tinkoff Broker returns an error if request current portfolio with Overview() method, if EUR or GBP in user portfolio:
python TKSBrokerAPI.py -o -v 10

Traceback (most recent call last):
  File "x:\work\projects\TKSBrokerAPI\tksbrokerapi\TKSBrokerAPI.py", line 5101, in Main
    trader.Overview(show=True, details="full")
  File "x:\work\projects\TKSBrokerAPI\tksbrokerapi\TKSBrokerAPI.py", line 1819, in Overview
    "name": curr["name"],
KeyError: 'name'

Fixed in v1.6.dev154
Debug build: https://app.travis-ci.com/github/Tim55667757/TKSBrokerAPI/builds/260999666
PyPI artefact for testing: https://pypi.org/project/tksbrokerapi/1.6.dev154/


Investigate editing code during upgrades

Is your feature request related to a problem?
As part of upgrading from one release to another, there may be some common (required?) code changes required to move to the next version successfully.
Describe the solution you'd like
Investigate whether .NET SDK built-in code fixers/analysers (or maybe some trivial custom ones) could be run as part of the upgrade process to increase the chance of a successful automated upgrade.
Other things that might be relevant could be:

[ ] Suppress a common new noisy warning (e.g. CA1515).
[x] Edits for breaking changes like .NET 8's change to the default Docker port.

If there are things that can be done, unless they can be done with very high confidence that it's correct, make it opt-in with a flag (--run-code-fixers/--include-code, whatever).
Describe alternatives you've considered
Do nothing - humans better know what needs changing/fixing that this tool will be able to.
Additional context
None.

For future reference, the original prototype of running the fixers in-process can be found here: https://github.com/martincostello/dotnet-bumper/commit/26b7ef89b9af6add200e2d277a67f28f15900136


[Tips] Connecting zustand store with React state

@timkindberg asked how we could use React state with zustand store.
While this is not the primary use case of zustand, there might be a special use case.
Related discussion: #151
So, the idea is to sync React state and zustand store.

const createSyncZustand = (useValue, zustandStore) => {
  return (props) => {
    const [value, setValue] = useValue(props);
    useEffect(() => {
      zustandStore.setState({ value });
    }, [value]);
    useEffect(() => {
      const unsub = zustandStore.subscribe(
        (nextValue) => {
          setValue(nextValue);
        },
        (state) => state.value
      );
      setValue(zustandStore.getState().value);
      return unsub;
    }, [setValue]);
    return null;
  };
};

Here's the full example: https://codesandbox.io/s/laughing-varahamihira-zr1n1?file=/src/App.js

Thank you @dai-shi. This is close to what I'm looking for. I'm not sure I care if the state is synced back to react. I think it's ok if its only synced from the hook to zustand.
My main goal was:

Zustand but with regular react hooks, as opposed to the proprietary state object and api. I'd actually brought this idea up in Dec.
Because it's "just hooks" it remains ridiculously composable. So things like recoil have ways to merge multiple "atoms" together. This becomes unnecessary because hooks naturally "merge" and compose.
I'd want the solution to support any type of hook regardless of what it returns (literal, object, array, etc).

All of those goals were achieved in my POC found here: https://codesandbox.io/s/stately-3-zp0w5?file=/src/App.js
Here is the code. See how we use zustand with any hook, here is an example with a customuseName hook. Beyond that zustand works normally.
App.js
import React, { useState } from "react";
import create from "./zustandWithHooks";
import "./styles.css";

const useName = (initialValue) => {
  const [name, setName] = useState(initialValue);
  return { name, setName };
};

const useNameStore = create(useName, "Tim");

const Name = () => {
  const name = useNameStore((s) => s?.name);
  return {name};
};

const SetNameButton = () => {
  const setName = useNameStore((s) => s?.setName);
  return (
    <button onClick={() => setName((prev) => prev + "!")}>
      Click Me
    </button>
  );
};

export default function App() {
  return (

      <Name />
      <SetNameButton />

  );
}

And here is the implementation. The secret "hack" is to render a react root into an element in memory and allow the hook to be run there.
zustandWithHooks.js
import React, { useEffect } from "react";
import ReactDOM from "react-dom";
import "./styles.css";
import zcreate from "zustand";

export default function create(hook, ...args) {
  const useZStore = zcreate(() => ({ value: undefined }));
  const reactRoot = document.createElement("div");
  ReactDOM.render(
    <Store hook={hook} args={args} useZStore={useZStore} />,
    reactRoot
  );
  const useStore = (selector, isEqual) =>
    useZStore((s) => {
      if (typeof selector === "function") return selector(s.value);
      return selector(s.value);
    }, isEqual);
  useStore.getState = () => useZStore.getState().value;
  // useStore.subscribe = ...
  // useStore.destroy = ...
  return useStore;
}

function Store({ hook: useHook, args, useZStore }) {
  const result = useHook(...args);
  useEffect(() => {
    useZStore.setState({ value: result });
  }, [useZStore, result]);
  return null;
}

Some potential gotchas of my approach:

Relies on react-dom
You can't use useContext in your hook passed to zustand, but I think that makes sense since the state is essentially global.
Any other downsides of my approach?

@dai-shi Thank you for brainstorming with me and spending time figuring out how one might sync zustand with React in the other direction. I still have a preference for my original POC. I do love your idea of giving the user a component to insert in the tree though where they want. This would avoid having to render with react-dom into an element in memory! I think this would be an optional feature. By default it would still render into memory.

You are welcome. If you don't need to sync back, then you just don't need to subscribe and it can accept any value. The remaining difference would be hidden react-dom vs. explicit insert.


WFLY-19473: fix and bump schema

Issue: WFLY-19473
This is the last one, the issue here is that certain elements in the schema were configured as mutually exclusive - specifically elytron-enabled is not mutually exclusive with anything according to the model but was declared as such in both security and recovery. Some elements had to be reordered as a result.
elytron-enabled was also changed from booleanPresence to boolean, but we should just pick one (or they could be attributes) since it looks randomly assigned, e.g. in xa-pool we've got

is-same-rm-override (boolean)
interleaving (boolean-presenceType)
no-tx-separate-pools (boolean-presenceType)
pad-xid (boolean)
wrap-xa-resource (boolean)
though I imagine this pops in other subsytems too.

In the parser refactor the pool-fair attribute was never being written in a non-xa pool, so that is also fixed. I noticed most of the pool attributes are shared with datasources so maybe there should be another refactor of the whole "wildfly/connector" so that both the RA schema and parser import from datasources.

<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->

Wildfly issue links:

WFLY-19573

<--- END OF WILDFLY GITHUB BOT REPORT --->
More information about the wildfly-bot[bot]

I think the second commit here has the wrong JIRA id attached. WFLY-19573  was just created today and is about CDI.

@jamezp yeah, thanks, that was a typo


--nostarted causes the start time to shift

Found and in the report for #361, this was confirmed in 3.4 and in current master (4.0.4alpha).
Ran this at approx Thu Aug  2 20:28:15 PDT 2018
(venv) ~/src/gcalcli$ gcalcli agenda

Thu Aug 02           all day test

(venv) ~/src/gcalcli$ gcalcli agenda --nostarted

Tue Aug 07   2:00pm  Test meeting

In _ParseStartEnd, which called by AgendaQuery (and I'm sure many other functions), we see:
        if not startText:
            start = self.now if self.options['ignore_started'] else None

So, that seems like a bug to me, especially because I find a specific filter _IterateEvents
        for event in eventList:
            if self.options['ignore_started'] and (event['s'] < self.now):
                continue

The only other spots in the code which refer to 'ignore_started' are in the _tsv function.  This may mean that other functionality is relying on the moving of the start date.
Since we're on alpha in master, I'm going to write a test or two for this and then check in a bug fix this weekend.  I'm going to take the strategy of just removing the start time shift unless someone else knows a reason I shouldn't.

Thank you very much for such an awesome tool and for your immediate response to the problem.
FYI: Ubuntu 18.04 official repository contains gcalcli 4.0.0~a3-1 which is the version caused to the problem mentioned in https://github.com/linuxmint/cinnamon-spices-desklets/issues/330.

@slgobinath I hope I didn't confuse anyone.  The issue reported in #361 is still a thing.  While investigating #361 I ran across this bug (#362), which is now fixed.  I think your comment might be helpful in the thread about #361, unless I'm missing something.


feat: add command to reseed with external listings

Pull Request Template
Issue Overview

[X] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
This PR adds two new reseed options, yarn db:reseed:with-external:dev and yarn db:reseed:with-external:prod, and a couple of supporting actions in the package.json file for backend/core.  The regular yarn db:reseed will now emit a notice if called directly, informing the user that they probably want to use one of the two new options instead.
How Can This Be Tested/Reviewed?
Run yarn db:reseed:print-notice to view the notice that gets displayed when run.
Run yarn db:reseed to verify that the notice displays when run.
Run yarn db:reseed:with-external:prod to verify that listings are imported from the prod Bloom endpoint and that no notice is displayed.
Run yarn db:reseed:with-external:dev to verify that listings are imported from the dev Bloom endpoint and that no notice is displayed.
Checklist:

[X] My code follows the style guidelines of this project
[ ] I have added QA notes to the issue with applicable URLs
[X] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[X] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[X] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

hey! the command works, but there's an error when I try to view on the public site. I think this has to do with uploads being broken or an implicit dependency on env variables here (and the urls seem malformed -- too many slashes)

at the least we should add some documentation here, the web of env variable dependencies is very tough to figure out.

hey! the command works, but there's an error when I try to view on the public site. I think this has to do with uploads being broken or an implicit dependency on env variables here (and the urls seem malformed -- too many slashes)

Can you explain why you think that would be due to this PR?  It doesn't touch any code, all it does is combine a couple of yarn commands together.  None of the seed data uses cloudinary and the listings import doesn't touch image URLs.  Or was this meant for another PR?

I recommend creating an issue(s) for any outstanding questions/missing pieces around this feature. This PR is unrelated to the implementation details of showing external listings but allows us to seed from the CD pipeline.

Oh fair, the cloudinary stuff is not working properly even on main (all external listing photos seem broken). I still can't see external listings after reseeding, but it works if I switch off of this branch. Let's submit to unblock and then perhaps we can do a bit of a bug bash on the broken things and fix either by documenting how to set up folks' envs or via bugfixes.


Typo

Just finished the set of videos on MicrosoftDocs/Power BI/Guided Learning/"Introduction to DAX"
If I did understand the subjects correctly, I believe there is a typo on the page "Table relationships and DAX" (DAX5) that seems to be important to the correct understanding of this section.
--- Current text is: ---
For example, the TABLE function follows relationships and returns the value of a column, while RELATEDTABLE follows relationships, and returns an entire table that is filtered to include only related rows.
--- I believe it should read: ---
For example, the RELATED function follows relationships and returns the value of a column, while RELATEDTABLE follows relationships, and returns an entire table that is filtered to include only related rows.
Thank you,

Hi @acldemac
Thank you for your feedback, we really appreciate it.  I've assigned this to the author of that article and she will respond asap.
Take care,
The DOCS team.

Adding an assignee to look into resolution.

Seems to be fixed already. #please-close @mgblythe


Plugin Request - Stubby

Hi Guys,
I was thinking it would be good if we had a DNS over TLS plugin. Unbound is nearly there but doesn't use connection reuse yet, so it has to make a new TLS connection every time (costing extra time per request).
I'm proposing a plugin like Stubby is a dns forwarder which uses DNS over TLS with connection reuse. That way DNS resolution times say low and encrypted.
I personally use this on a Raspberry Pi, but would be neat if it was a Plugin.
DNS over TLS is the open standard so it would make sense to use this over DNS over HTTP etc.

What about dnscrypt-proxy?

Does that use DNS over TLS? or is that plugin DNS over HTTP?

DoH and Dnscrypt

Yeah I didn't think it used DNS over TLS, just thought it would be better to have a plugin which conforms to standards

You can search the forums for user directnupe. He wrote a guide for DNS over TLS with Unbound

I'll rather stick to using my Pi with Stubby as unbound doesn't do connection reuse (yet, I presume they'll add it at some point), so it keeps having to redo the encryption handshake. Where Stubby reuses the last connection, allowing faster lookup times, close to non tls requests

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


Review+Submit Menu Item

Need to have user permissions first before adding in the menu specific items/changes


[BUG] Get-PnPMicrosoft365Group -IncludeSiteUrl provisions M365 group's SharePoint site

Reporting an Issue or Missing Feature
If you create a Microsoft 365 group from the Outlook desktop client, its associated SharePoint site is NOT automatically provisioned.  (I've opened a case with Microsoft as it would seem this is a bug in and of itself since all other methods to create a M365 group DOES provision the group's associated SharePoint site, alas I was told its expected behavior and to submit a DCR to change it :eyeroll:).
The bug here is if you run Get-PnPMicrosoft365Group -Identity <M365groupname> it will return the group's properties (SiteUrl will be blank).  But if you run Get-PnPMicrosoft365Group -Identity <M365groupname> -IncludeSiteUrl (the added -IncludeSiteUrl parameter being the difference) it will create the M365 group's SharePoint site and populate the group's SiteUrl property with its SP site URL.
Submitting this as a bug since the cmdlet's IncludeSiteUrl parameter's documentation https://pnp.github.io/powershell/cmdlets/Get-PnPMicrosoft365Group.html#-includesiteurl only mentions "fetching" the site URL, and not creating the group's SP site if one doesn't already exist.
Expected behavior
I would expect running Get-PnPMicrosoft365Group -Identity <M365groupname> -IncludeSiteUrl gets/fetches the M365 group's SP site URL if one exists, and report blank/null if it doesn't.
Actual behavior
See first section for actual behavior details.
Steps to reproduce behavior
Create Microsoft 365 group from Outlook desktop client.  Confirm group's SharePoint site doesn't exist via admin portal (Microsoft 365 admin center, SharePoint admin center, Azure AD) or by running Get-PnPMicrosoft365Group -Identity <M365groupname> and noting the SiteUrl property is blank.
Run Get-PnPMicrosoft365Group -Identity <M365groupname> -IncludeSiteUrl and you'll see the group's SP site gets created (can confirm via any admin portal or by running Get-PnPMicrosoft365Group -Identity <M365groupname> and noting the SiteUrl property now returns the group's SP site URL.
What is the version of the Cmdlet module you are running?
2.1.1
Which operating system/environment are you running PnP PowerShell on?

Windows

Hi @veronicageek,
I think a better way to phrase it is the SiteUrl switch initiates something in the service that kicks off the site provisioning process (similar to your test when you did not use PnP PowerShell-- the site doesn't exist until you click the link in the email, go to the Files tab of the group, etc-- there are multiple ways to initiate the group's site provisioning outside of PnP PowerShell).
The reason for creating this bug issue is because when the SiteUrl switch is used with the Get-PnPMicrosoft365Group cmdlet on a group that doesn't already have a SharePoint site, the SharePoint site gets created.  This is counter-intuitive to every Get cmdlet in PowerShell-- it should only be retrieving information and never creating/writing/provisioning anything new.  Since I understand it may not be the cmdlet thats doing it directly (again, sounds like its initiating something in the SharePoint service thats doing it), I think adding a note to the https://pnp.github.io/powershell/cmdlets/Get-PnPMicrosoft365Group.html#-includesiteurl documentation should be considered.

To be clear, the site does not get created when the M365 group is created via the Outlook desktop client.  You can wait days, weeks, months.  The site will not exist in any admin center, can't be retrieved via other PowerShell cmdlets, etc.  The site only gets created once some action initiates its creation.  This action could be clicking the site link in the group creation email, going to the group's Files in Outlook, or running the Get-PnPMicrosoft365Group cmdlet with the SiteUrl switch.

The site only gets created once some action initiates its creation. This action could be clicking the site link in the group creation email, going to the group's Files in Outlook, or running the Get-PnPMicrosoft365Group cmdlet with the SiteUrl switch

So then I don't see why this would be a PnP PowerShell issue, but I'll wait to hear @gautamdsheth or @KoenZomers's thoughts.


Support for React Native platform specific files

Right now exports in X.android.ts or X.ios.ts files are considered unused. It'd be great if the parser knows that import X should include these files.

Duplicate of #126. Please continue the discussion over there, I can re-open if necessary.


Develop on Digital Ocean serve

Symlink www-folder to demo-folder to get an instant feel to whether it works or not.

Don't need it for now. Working well enough with debugging in the editor and GitHub pages.


BoringSSL-based binary packages

Is your feature request related to a problem? Please describe.
Current packaging options for Themis provide only packages that rely on system's OpenSSL. This is convenient on general-purpose server platforms. However, more and more deployments forgo TLS support entirely, leaving it to edge machines, with data-processing ones not having a need to include OpenSSL. Embedded systems may not fit the entire OpenSSL library too.
Describe the solution you'd like to see
It would be nice for Themis to ship with prebuilt packages that don't depend on system OpenSSL, using embedded BoringSSL.
Describe alternatives you've considered
Current alternative is to build Themis from source to use it with applications that already use BoringSSL and do not rely on systems's OpenSSL. This is more involved that installing it from the package, but should work.

You want to install themis which is statically compiled with some backend (openssl/boringssl) to not install openssl/boringssl to your system? Or you want some API to configure themis at runtime from your app with already initialized backend engine (like some "engine" object from openssl)?

You want to install themis which is statically compiled with some backend (openssl/boringssl) to not install openssl/boringssl to your system?

This.
It's about providing libthemis-boringssl0 packages that ship Themis with statically linked BoringSSL, along with libthemis0 that are linked against the system's OpenSSL.

You want to install themis which is statically compiled with some backend (openssl/boringssl) to not install openssl/boringssl to your system?

I would even go that far and remove the statically compiled openssl/boringssl at all. My suspicion is that from the whole openssl API, soter uses a very limited set of crypto operations, which could be just embedded (cherry-picked) into the soter code directly. openssl comes also with an extended X.509 API that it's not needed.
IMHO there are a number of advantages of not depending on any underlying SSL library.

avoiding going to openssl-dependency hell
decoupling the Themis API from OpenSSL thus accepting all kinds of combinations; it seems that all openssls are equal, but some are more equal than the others and the idea is to have one platform-independent package
smaller library
simpler DevOps
being able to better interface with packages and framework such as SwiftNIO SSL that come with their own implementation of TLS
potential use for embedded devices and sensors with low resources available; the hypethesis here is that they do not have the resources needed to load the complete openssl library into memory
on the server-side we see that TLS needs are being pushed to the edges to the ingress controllers and east-west traffic being upgrated by TLS though proxies (service mesh pattern)
sometimes you just need to send a Secure Message

@gene-eu @vixentael what's your take on this?
Andrei

openssl comes also with an extended X.509 API that it's not needed

Modern linkers have a dead code elimination pass and are able to remove whatever code is unused during static linkage. Admittedly, it's coarse because OpenSSL encryption API uses EVP abstraction and we're using it through that, so it's not like linker will remove everything besides exactly the code Soter uses. But it should remove the libcrypto bits that Soter definitely does not use, such as ASN.1, PKCS, PEM, X.509 parsers, probably most of the BIO code, etc. It will leave everything transitively used from generic EVP API though. OpenSSL has algorithm-specific API so it should probably be possible to avoid including even more code, such as unneeded algorithm implementations, if that's really necessary. And just for completeness, Soter does not use libssl or link against it, so there will be no TLS-related code if static linkage is used.

To put some numbers to where my mouth is, here are sizes that Themis currently has with typical builds on a typical x86_64 machine with Linux.

Crypto backend linkage
On-disk size
In-memory size

Dynamic OpenSSL
162.6 KB (+ OpenSSL)
2.92 MB

Static OpenSSL
2.5 MB total
2.49 MB

Static BoringSSL
0.97 MB total
0.96 MB

That said, it seems I have been overoptimistic about linker capabilities, but I'm still fairly sure that we can do something about size optimizations (they were never a priority).

How I did the measurements
Shared library dynamically linked against system OpenSSL
Build:
make
strip build/lib*.so

On-disk sizes can be measured with ls -l.

Library
Size, bytes

libcrypto.so.1.1
2925408

libsoter.so.0
111392

libthemis.so.0
55112

The application package will bundle 162.6 KB of libraries. Additionally, 2.79 MB of libcrypto will be installed by dependency manager, plus whatever else is in the package since it typically includes libssl too (for another 571.7 KB). OpenSSL disk usage is going to be shared by applications that need it, same goes for Themis.
In-memory size can be estimated with size, adding up text and data sections which are going to be loaded into memory. This will give approximate virtual memory usage (excluding zero-initialized data from BSS), not actual resident set that depends on run-time behavior. However, it gives a good perspective of how much of the file is loaded, and how much is just ancillary data that stays on disk.

Library
Total, bytes
Text sections
Data sections

libcrypto.so.1.1
2914610
2730666
183944

libsoter.so.0
101995
68555
33440

libthemis.so.0
50352
48944
1408

So the appliction process will load 148.7 KB of Themis into memory, followed by 2.78 MB of OpenSSL, for a total of 2.92 MB of virtual memory usage (plus some 13 KB of zero pages).
Shared library statically linked against system OpenSSL
There is no easy option to do this, but it can be hacked in the following way:
make CRYPTO_ENGINE_LDFLAGS="/lib/x86_64-linux-gnu/libcrypto.a -ldl -pthread -Wl,--exclude-libs,ALL -flto -Wl,--gc-sections"
strip build/lib*.so

We currently don't really support static builds so some additional flags have to be manually added to enable appropriate size optimizations.
On-disk sizes:

Library
Size, bytes

libsoter.so.0
2567920

libthemis.so.0
55112

That's not much, to be honest: 2.5 MB installation size. Probably because of the way OpenSSL is compiled, the linker was not able to remove some code (like, X.509 parsing is still there).
In-memory sizes:

Library
Total, bytes
Text sections
Data sections

libsoter.so.0
2556342
2348382
207960

libthemis.so.0
50352
48944
1408

No significant change here either, 2.49 MB of virual memory, give or take.
Shared library statically linked against vendored BoringSSL
This is supported better in the build system, but some flags are still necessary:
LDFLAGS="-Wl,--exclude-libs,ALL -flto -Wl,--gc-sections" make ENGINE=boringssl
strip build/lib*.so

On-disk size:

Library
Size, bytes

libsoter.so.0
959344

libthemis.so.0
55112

This is a bit better, as you can see: 0.97 MB installation size. There is still some room for optimization as I see some unnecessary symbols in the binaries before stripping.
In-memory size:

Library
Total, bytes
Text sections
Data sections

libsoter.so.0
952071
917239
34832

libthemis.so.0
49670
48270
1400

Memory image is also a bit smaller, for a total of 0.96 MB.

If memory is premium and static linkage is used for Themis as well, it's possible to shave off even more because the linker will throw out parts of Themis/Soter that are not used. For example, if the application does not use Secure Session or Comparator, they won't be included along with ed25519 handling code that they need. It won't throw things like RSA support even if it's not needed though, but there is some room for tailored builds if someone really needs to be minimal.

Install themis which is statically compiled with some backend (openssl/boringssl)
It's about providing libthemis-boringssl0 packages that ship Themis with statically linked BoringSSL, along with the current alternative of libthemis0 that are linked against the system's OpenSSL.

This changes responsibility to maintain/update crypto-engine from users to us. We don't follow Open/Boring/LibraSSL updates so carefully.

Also, I imagine situations, where app has 3 dependencies that use crypto-engine, if all of them are using static libs, it means 3 versions of crypto-engine will be installed (↑ app size, ↑ duplicated symbols?).

I'm not against shipping Themis with statically linked BoringSSL (libthemis-boringssl0), but we are jumping into updating dependencies more often water. Especially with BoringSSL, as even Google doesn't support versioning and doesn't recommend to link to master.

which could be just embedded (cherry-picked) into the soter code directly

Cherrypicking code from crypto-engine to Soter makes us responsible for all the hacks/bugs/backdoors. We are not. Themis doesn't implement own crypto, Themis relies on crypto-engine.

potential use for embedded devices and sensors with low resources available

They have their own SSL, like BearSSL, WolfSSL or SSL-less solutions, like E4. Themis is not a lib for low energy / weak CPU devices, it was never designed and tested like this. Themis is tested and proved to work on ARM x32 and above.

being able to better interface with packages and framework such as SwiftNIO SSL that come with their own implementation of TLS

SwiftNIO links against BoringSSL. I imagine that it's OK to use Themis and SwiftNIO in the same app, when BoringSSL package is dynamically linked. Will it be possible if Themis links BoringSSL as static lib?

TLDR:
a. I'm completely against cherry-picking openssl/boringssl code into Soter and maintaining it on our own. Due to numerous reasons: security, "do not implement your own crypto", maintainability and speed of fixes.
b. I'm not against shipping yet-another-Themis with statically linked BoringSSL package, but it should solve some real world use-cases. What use-case are we trying to solve here?

libthemis-boringssl is probably going to be a thing starting with Themis 0.14. It is already implemented in #683, but it definitely needs more testing.


william/setup-mods-squashed

This provides a slight improvement to setup instructions for end users.

Trying again... I want to preserve Andre's changes, which are only in the original PR.


Fix a few minor typos in docs / comments

While I was reading the docs & the source code I came across a few minor typos. This PR fixes them.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


(maint) Specify bolt_server spec helper default port as integer

Previously the target2request method would set the port for an ssh target as the string '22'. The transport app schema requires this value to be an integer. This commit updates the method to set the default ssh port to the integer value.

Noticed then when reviewing https://github.com/puppetlabs/bolt/pull/1053.
cas@cas-ThinkPad-T460p:~/working_dir/bolt$ bundle exec scripts/server_client.rb sample::echo<EMAIL_ADDRESS>'{"message": "hey"}'
{
  "kind": "boltserver/schema-error",
  "msg": "There was an error validating the request body.",
  "details": [
    "The property '#/target/port' of type string did not match the following type: integer in schema fd716135-94d5-5356-9213-f5c4225bc92a"
  ]
}

cas@cas-ThinkPad-T460p:~/working_dir/bolt$ git diff
diff --git a/spec/lib/bolt_spec/bolt_server.rb b/spec/lib/bolt_spec/bolt_server.rb
index 2a0dc255..a1f79d58 100644
--- a/spec/lib/bolt_spec/bolt_server.rb
+++ b/spec/lib/bolt_spec/bolt_server.rb
@@ -39,7 +39,7 @@ module BoltSpec
         elsif target.options['private-key']
           req['private-key-content'] = File.read(target.options['private-key'])
         end
-        req['port'] ||= '22'
+        req['port'] ||= 22
         req['user'] ||= 'root'
       when 'winrm'
         req['ssl'] = false

cas@cas-ThinkPad-T460p:~/working_dir/bolt$ bundle exec scripts/server_client.rb sample::echo<EMAIL_ADDRESS>'{"message": "hey"}'
{
  "node": "f32gbe3lv9s3erz.delivery.puppetlabs.net",
  "target": "f32gbe3lv9s3erz.delivery.puppetlabs.net",
  "action": "task",
  "object": "sample::echo",
  "status": "success",
  "result": {
    "_output": "f32gbe3lv9s3erz got passed the message: hey\n"
  }
}

CLA signed by all contributors.


Can't delete a question

In trying to delete a question from Squeak! admin, I get an error:
client.ts:76          DELETE https://squeak.cloud/api/question/11 500
VM57:2 Uncaught (in promise) SyntaxError: Unexpected token 'I', "
Invalid `p"... is not valid JSON

Note: I'm getting this on other pages too (like /settings). This is a non-PostHog Squeak! account.


protocol upgrade to validate eligibility without downloading activesets

closes: https://github.com/spacemeshos/go-spacemesh/issues/5598
to realize proposed solution i introduced non_decreasing_weight for an epoch, this weight tracks the weight of all known atxs in the epoch. however for equivocating atxs we can't count weight multiple times, therefore we count only largest atx from an identity in the epoch. this way we guarantee that peers will be eventually in agreement what weight they are using for validating ballots.
using that weight we compute lower_boundary. if any ballot claims that it has lower eligibility than this boundary it is either intentionally concentrating weight or it knows about more atxs then we have locally. in 2nd case we will eventually download those atxs and validate referenced ballot.
additionally we introduce upper_boundary. this boundary computed using hardcoded minimal weight. if any ballot claims larger boundary we know that node is misconfigured or intentionally creates many small ballots for dos. in both cases we will disconnect that node with reject.

What's the status on this? Is this ready to be integrated or still WiP?

Closing, since this is falling further behind develop and probably needs to be re-implemented. Feel free to open a new PR if you feel like it 🙂


consider
adding
apathy
mod

No need for that mod anyway as forgery has a config to do the same thing


"No video formats found" when downloading from manifest.mpd

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.08.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.08.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-F', 'https://edge01p.friday.tw/drm/18995.smil/manifest_w1503210253540.mpd']
[debug] Encodings: locale cp936, fs mbcs, out cp936, pref cp936
[debug] youtube-dl version 2017.08.18
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: ffmpeg N-86330-gbd1179e, ffprobe N-86330-gbd1179e
[debug] Proxy map: {}
[generic] manifest_w1503210253540: Requesting header
WARNING: Falling back on generic information extractor.
[generic] manifest_w1503210253540: Downloading webpage
[generic] manifest_w1503210253540: Extracting information
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmput9or0a0\build\youtube_dl\YoutubeDL.py", line 776, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmput9or0a0\build\youtube_dl\extractor\common.py", line 433, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmput9or0a0\build\youtube_dl\extractor\generic.py", line 2121, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmput9or0a0\build\youtube_dl\extractor\common.py", line 1057, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

DRM protected content.


Read configuration file from XDG location

Git itself has started using ~/.config/git/ as of 1.7.12, so getting rid of extra clutter in ~/ would be a welcome change.
Though I'm not sure if I should have used xdg.BaseDirectory from PyXDG instead?

Ok, cool, this looks good to me!
I prefer to keep it the way it is, without adding PyXDG as a dependency (there's no difference in terms of functionality, right?).
In your PR, could you also update the README to mention this alternative location for the git-remote-dropbox.json file?

Whoops, didn't notice that you'd made the change.
Thanks for the patch! Merged in 9b936e6.


DACT-1482 Add CH01 has been updated booleans

https://companieshouse.atlassian.net/browse/DACT-1482
has_been_updated are to show whether the user has updated that section of information during CH01 web journey

@PhilipGlover These values don't get passed to CHIPS but they are used for the CHIPS data (to work out which sections should be passed to CHIPS). The steer we have been given is to move data unrelated to CHIPS out of the data object (eg certain web choices that are saved in the filing), but to keep these booleans within the data object.


remove version number property, maven cannot inject it during build

maven cannot inject the property into the version number and so the project cannot build, I've hardcoded the number, but it can be updated with the maven versions plugin.

Does this mean we need to update every one of these files whenever we create a new version? Seems like there should be a better way.

@coryvirok there's a command line way to update all at once that @dlsteuer found. The way this is done currently flat out doesn't work on Maven central for some reason. It'd be simple to create a custom build task that ran that first.

@coryvirok @Crisfole I switched it around to using the maven flatten plugin, so we only have to update the version number in the properties under the root pom, but the version number is propagated to all the modules correctly now.  This doesn't require any additional build steps.


Bug: Revert operation on protected branches succeeds

As part of review of fix revert reference which does not exist on the branch
Noticed that in the reproduction section - the example given was performed on main branch.
Testing myself - I validated that we indeed do not block revert operation (which creates a commit) on protected branches:
lakectl branch revert lakefs://quickstart/main fbe482cb0036ae3a119abb0fe298b3354c2c707f7e7f923a266da2ef43cfe461
Branch: lakefs://quickstart/main
Are you sure you want to revert the effect of commits fbe482cb0036ae3a119abb0fe298b3354c2c707f7e7f923a266da2ef43cfe461: y
commit fbe482cb0036ae3a119abb0fe298b3354c2c707f7e7f923a266da2ef43cfe461 successfully reverted

@ozkatz @talSofer Need product input on this:
One the one hand revert operation internally performs a merge operation (from branch to itself)
One the other hand it is presented to the user as a commit and according to the branch protection definitions:
"Changes to protected branches can only be done by merging from other branches."

I suggest to leave the behavior as is.
My reasoning is that there's no obvious choice here - both make sense, HOWEVER
if we allow reverting on protected branches (which are typically important/production branches), we allow bouncing back from mistakes quicker - especially if that mistake happened to a pre-merge hook - which are common for protected branches.
Closing for now, but happy to reopen if anyone has better reasons to disallow reverts instead.


converted to onnx and tensorrt

Good paper，I wrote  two inference demos, onnxtuntime and tensorrt，go to https://github.com/xuanandsix/DIS-onnxruntime-and-tensorrt-demo。

https://github.com/xuanandsix/DIS-onnxruntime-and-tensorrt-demo
c++ tensorrt, python onnxtuntime and tensorrt

Great work

Hello, if you are interested you can learn about https://github.com/Chenyu-Yang-2000/EleGANt and https://github.com/Snowfallingplum/SSAT, the build quality of the project is very high


populate composer.json

In the file is still written:
"description": "FoundationPress is a WordPress starter theme based on Foundation 5 by Zurb",

and should be adjusted perhaps.

Good spot!

yes, a small one ;-)


iOS Login with the Facebook app installed fails

Describe the bug
The AppDelegate function of the FBSDK refuses to handle the returned Intent.
To Reproduce
Steps to reproduce the behavior:

Follow the instructions in the Readmes
Install on an iPhone with the FB app installed
Open the login dialog
When asked to open in the native app, do so
Provide authorization, return to app
See, that the dialog is not closed.

Expected behavior
The Dialog should close and provide the auth info to the app.
Smartphone (please complete the following information):

Device: all iPhones
OS: iOS 14

Additional context
Official Facebook app is required. Authorization through safari works just fine but is disabled when the app is installed.
Returned URL is (omitting IDs) fb***://authorize#denied_scopes=&granted_scopes=email%2Cpublic_profile&graph_domain=facebook&nonce=&signed_request=&state=%7B%22challenge%22%3A%22xn1%252FW870hI2L16%253D0EtIa87a6Wjo%253D%22%2C%220_auth_logger_id%22%3A%2212F0D8C6-***-304804A65CA4%22%2C%22com.facebook.sdk_client_state%22%3Atrue%2C%223_method%22%3A%22sfvc_auth%22%7D

I have the same problem

Did you change AppDelegate.swift ? This work well.
  func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
    if CAPBridge.handleOpenUrl(url, options) {
      return FBSDKCoreKit.ApplicationDelegate.shared.application(app, open: url, options: options)
    }
    else{
     return false
    }
  }

Did you change AppDelegate.swift ? This work well.
  func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
    if CAPBridge.handleOpenUrl(url, options) {
      return FBSDKCoreKit.ApplicationDelegate.shared.application(app, open: url, options: options)
    }
    else{
     return false
    }
  }

Yeah, I tried both your method as well as the one provided by Facebook.
FBSDKCoreKit.ApplicationDelegate.shared.application just returns false. Returning true manually also does not close the dialog.
As I said, having the official facebook app installed is mandatory. Authentication with the browser works fine.

Yeah, I tried both your method as well as the one provided by Facebook.
FBSDKCoreKit.ApplicationDelegate.shared.application just returns false. Returning true manually also does not close the dialog.
As I said, having the official facebook app installed is mandatory. Authentication with the browser works fine.

Ok I think I've got it. The issue was, that I was using the SDK provided by the swift package manager, as is instructed by facebook. I removed the dependency, switched to the cocoa pods and it seemingly worked.
I will test a little bit more, but it would probably be a good Idea to add this to the documentation.

Ok I think I've got it. The issue was, that I was using the SDK provided by the swift package manager, as is instructed by facebook. I removed the dependency, switched to the cocoa pods and it seemingly worked.
I will test a little bit more, but it would probably be a good Idea to add this to the documentation.


[stable/spinnaker] Cannot delete spinnaker

Describe the bug
Unable to delete spinnaker with helm delete myspin --purge
Version of Helm and Kubernetes:
Helm: v2.14.3
Kubectl: v1.14.7
K8S: v1.14.8-eks-b7174d
Which chart:
stable/spinnaker
What happened:
> helm delete myspin --purge
Error: timed out waiting for the condition

The hal container seems to freeze at ContainerCreating for more than 32 minutes.
pod/myspin-spinnaker-cleanup-using-hal-9znmj                 0/1     ContainerCreating   0          9m18s

What you expected to happen:
The chart to be removed and purged.
How to reproduce it (as minimally and precisely as possible):
This can happen for a variety of reasons.  You can reproduce the scenario by deleting everything manually with kubectl delete, e.g. services, deployments, pods, job.batch, configmap, related to spinnaker, and then try to do a helm delete.

not stale


Separate compiled_path in manifest + printer

resolves #1985
Description
Adds a new node property, compiled_path. Previously, dbt would only use one property, build_path, which would represent the target/compiled path for compile-only tasks (compile, docs generate) and the target/run path for execute tasks (run, test, etc). Given that these paths represent truly different things, I think it makes sense to have them be separate!
The immediate motivation is fixing a regression from many versions ago that caused dbt to print the "Run SQL" file path, rather than the "Compiled SQL" file path, as context for model database errors and test failures.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

🤔 I could be convinced either way whether to bump the schema version for adding new fields, in these case we are sort of changing what a field means and also adding a new field. I'm leaning towards keeping same version and publishing the new schema with the new field and same version 🤷

Silly me! I just merged this in without a changelog entry. I'll follow up with that right now.


[SPARK-14418] [PYSPARK] fix unpersist of Broadcast in Python

What changes were proposed in this pull request?
Currently, Broaccast.unpersist() will remove the file of broadcast, which should be the behavior of destroy().
This PR added destroy() for Broadcast in Python, to match the sematics in Scala.
How was this patch tested?
Added regression tests.

cc @yhuai

Test build #55053 has started for PR 12189 at commit cdee210.

Test build #55053 has finished for PR 12189 at commit cdee210.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55053/
Test PASSed.

Merged build finished. Test PASSed.

Minor point: would it make sense to also update the PyDoc for unpersist to match the scaladoc while we are fixing its behavior anyways?

Seems this PR does not change unpersist? Is the behavior of unpersist correct?

@holdenk Updated.
@yhuai Changed unpersist(), the os.unlink() is moved to destroy()

Test build #55123 has started for PR 12189 at commit e0408f3.

Test build #55123 has finished for PR 12189 at commit e0408f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55123/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Merging to master. Thanks!


yahoo_finance stopped working after upgrading to 0.57.0

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
**Home Assistant release (hass --version): 0.57.0
**Python release (python3 --version): 3.5
**Component/platform: yahoo_finance
Description of problem:
Yahoo Finance stopped working after upgrading from 0.53.0 directly to 0.57.0. Even the example on the component page isn't working. I have attached the log file for more information:
home-assistant.log
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:
sensor:
  - platform: yahoo_finance
    symbols:
      - RHT
      - GOOGL

Traceback (if applicable):
2017-11-04 13:40:04 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform yahoo_finance
Traceback (most recent call last):
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 120, in _request
    _, results = response['query']['results'].popitem()
AttributeError: 'NoneType' object has no attribute 'popitem'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 123, in _request
    raise YQLQueryError(response['error']['description'])
KeyError: 'error'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/homeassistant/helpers/entity_component.py", line 170, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 400, in wait_for
    return fut.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/homeassistant/components/sensor/yahoo_finance.py", line 49, in setup_platform
    if Share(symbol).get_price() is None:
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 178, in __init__
    self.refresh()
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 142, in refresh
    self.data_set = self._fetch()
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 181, in _fetch
    data = super(Share, self)._fetch()
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 134, in _fetch
    data = self._request(query)
  File "/srv/homeassistant/homeassistant_venv/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 125, in _request
    raise YQLResponseMalformedError()
yahoo_finance.YQLResponseMalformedError: Response malformed.
2017-11-04 13:40:10 WARNING (MainThread) [homeassistant.setup] Setup of media_player is taking over 10 seconds.
2017-11-04 13:40:10 WARNING (MainThread) [homeassistant.setup] Setup of remote is taking over 10 seconds.
2017-11-04 13:40:45 WARNING (Thread-13) [homeassistant.components.zwave] zwave not ready after 30 seconds, continuing anyway

Additional info:

I'm not sure but I recall reading that Yahoo Finance API is being decommissioned. The home assistant component has not been updated in the last 5 months so I assume chances are low this is an issue related to the upgrade.

The YQL site is still available with no information about terminating it:
https://developer.yahoo.com/yql/
The component was working before the upgrade and 5 minutes later it stopped working so I assume it was because of the upgrade.

https://github.com/lukaszbanasiak/yahoo-finance/issues/140

Further details: https://yahoo.uservoice.com/forums/382977-finance/suggestions/32103877-yahoo-stock-quote-api-please-bring-back

#10873 is a replacement.


add partial

For more flexibility, add a
partial void AfterCopy(  original)
and call in the constructor to let the people to add their implementation

I was planning to make the generated constructor calls the default constructor if one exists in the destination class. Do you think this will cover what you have in mind?
For instance:
public partial class DestinationClass
{
    public DestinationClass()
    {
        // User code.
    }

    // Other properties and methods...
}

public partial class DestinationClass
{
    public DestinationClass(....) : this()
    {
        // Generated code
    }
}

This way, people have the opportunity to define read-only fields/properties as well.

Okish
But my approach will allow people to modify whenever they want e


select2 select2-selecting event is NOT fired on iOS

var $select = $('.account-select');
$select.on('select2-selecting', function (e) {
   debugger; // didn't call on ios :(
});

This should be fixed in 4.0 and earlier versions of Select2.
If it is not fixed, please add a :+1: to the ticket to bring it to our attention. Please also include an example that we can test to verify that it is not actually working.