InputTagHelper showing route value instead of model value

Hello, this is real head scratcher.
I am finding that the input tag helper is ignoring model values and instead using route values. It occurs when the route has a parameter with the same name as a model property (case insensitive) and the action method has a parameter that MVC binds to the route parameter.
The model class:
class ViewModel
{
  public string Name { get; set; }
  public string Identifier { get; set; }
}

The route in Startup is defined as:
{controller=Home}/{action=Index}/{identifier?}

The action method:
ActionResult Details(string identifier, string name = "")
{
  var model = new ViewModel { Name = "MyName", Identifier = "perm-id-123" }
  return View(model);
}

The Razor:
@model ViewModel
...
<input asp-for="Name" />
<input asp-for="Identifier" />
...

With this setup I would expect the input element to render the with values of "MyName" and "perm-id-123", but if an "identifier" value is in the route it is rendered instead of "perm-id-123"! And if there were a query parameter called 'name' that was bound to the action method parameter then that value will also render instead if "MyName".
This might be by design, but the documentation says asp-for="Property" equates to model => model.Property... and this isn't what I'm observing.
Thanks!

Reading always value from ModelState could expose me to a code injection attack ? I Think Yes.

@blowdart do you want to take this? @dougbu or I could explain the workflow.
@dougbu do we have write up on how model expressions are interpreted in Mvc? We could add those to our docs.

@iscifoni How do you think this is code injection attack? Everything put in the form is HtmlAtrributeEncoded. Sure, you can inject a value into a form, but it's just going to be a value because it's encoded.

@pranavkm the interpretation of a model expression i.e. where the value will be found is covered pretty thoroughly for HTML helpers in their doc comments. But, we have nothing similar for tag helpers.

Hint Tag helpers work about the same as the corresponding expression-based HTML helper e.g. <textarea/> interprets asp-for about the same way Html.TextAreaFor(...) interprets the passed expression.

We also haven't duplicated this information on the documentation site.

We updated the docs to include a snippet about possible sources for a model expression. See https://docs.microsoft.com/en-us/aspnet/core/mvc/views/working-with-forms#expression-names.

@pranavkm  Awesome, thanks!


raftstore, cdc: fix leader info maybe lost

Signed-off-by: 5kbpers<EMAIL_ADDRESS>
What problem does this PR solve?
Problem Summary:
The region info in peer storage was updated after the leader changed event triggered.
What is changed and how it works?
What's Changed:
Use peer id instead of peer info to record leader info in StoreMeta.
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test

Release note

N/A

Should it be cherrypicked to release-4.0?

Should it be cherrypicked to release-4.0?

Will pick it to 4.0 after further testing.

/merge

/merge

/merge


500 Internal Server Error on attempted cache purge with aio threads enabled (nginx 1.9.5)

fastcgi_cache_purge causes a 500 error when "aio threads" is specified in the http section of the nginx config.
The problem resolves itself when nginx threads are disabled.

Hi PeterMaxwell ,
Do you have anyway to use nginx thread pool with module ngx_cache_purge ?

Workaround - set aio off; on purge location.

you can ajust the code like
if (NGX_HAVE_FILE_AIO)
to
if (NGX_HAVE_FILE_AIO || NGX_THREADS)
also you need to configure with --with_threads


Peer Review - Edit task

Hi @aamir-asaram!
You have done a wonderful job implementing the test of the edit, update and clear completed function.
However there are some improvements that can be added to improve your test functions.
Optional Changes

To improve your test, you can try mocking the event listeeners.

Keep up the great work. 👍🏾
Happy Coding!

Hello @aamir-asaram,
You have done Great Job.
Overall, you have done an amazing job in implementing all the project requirements. 🤝
Highlights🌞

[ ] Clean code✔
[ ] All test are green✔
Keep up the good work!


Running diff on generated files (without detail sentences)

Description
Updated the automatic CARS.md generation to utilize wget and diff instead of pickle, which should be better (assumes less about the file structure as well). Should resolve https://github.com/commaai/openpilot/issues/32690, although this does not handle "📖 Detail Sentence Changes" as this seems to not be intrinsic to the generated markdown files immediately. Would love to get some feedback on how to incorporate that here.
Verification
Simply edited the CARS.md file locally to check it on my end, not included in the commit for obvious reasons.

Meant to leave as a draft! Still working on the

You may need special handling of the detail sentence however, which is fine.

Sorry about that.

Can you post an example by the bot on your own fork? The result of this project should be a much cleaner and smaller docs diffing file, this grows the code.

@sshane sure! Could you quickly explain to me how to deal with the pyx files, couldn't find a solution. Running it on my codespace (using codespaces since my laptop is broken) I get:
@agniv-the-marker ➜ /workspaces/openpilot (master) $ /home/batman/pyenv/versions/3.11.4/bin/python /workspaces/openpilot/selfdrive/car/tests/test_docs.py
Traceback (most recent call last):
  File "/workspaces/openpilot/selfdrive/car/tests/test_docs.py", line 8, in <module>
    from openpilot.selfdrive.car.docs import CARS_MD_OUT, CARS_MD_TEMPLATE, generate_cars_md, get_all_car_docs
  File "/workspaces/openpilot/openpilot/selfdrive/car/docs.py", line 13, in <module>
    from openpilot.selfdrive.car.car_helpers import interfaces, get_interface_attr
  File "/workspaces/openpilot/openpilot/selfdrive/car/car_helpers.py", line 6, in <module>
    from openpilot.common.params import Params
  File "/workspaces/openpilot/openpilot/common/params.py", line 1, in <module>
    from openpilot.common.params_pyx import Params, ParamKeyType, UnknownKeyName
ModuleNotFoundError: No module named 'openpilot.common.params_pyx'

I feel like I'm maybe missing something with how you're supposed to deal with cython files? Sorry for all the comments.
Right now my bottleneck is just generating the CARS.md file which is importing this.

You need to build params, scons -j8 should work if you installed the openpilot deps

CI is also failing


[Feature request] Host only target

Several libraries I work with are written with the intention of being shared between host tooling and device firmware. Something that has come up multiple times is that you can't have defmt enabled when building/running tests/examples. This has also struck in the CI setup a few times (cargo build --all-targets --all-features fails when not cross compiling).
I see this may have been a thing originally (https://crates.io/crates/defmt-logger) but that doesn't seem to apply now.
Motivation

Not needing a device/emulator to check defmt logging messages from calling a function
Remove duplication: redirecting-to/co-existance with log/tracing would remove the need to duplicate/cfg!(...) logging statements depending on the target in many cases

currently I often end up with both log and defmt as optional dependencies and a couple of #[cfg(...)] statements to make it work (crate level logging modules + extras when formatting compatibility is an issue).

cargo build --all-targets --all-features could work which helps with having standard CI scripts

I believe this is a duplicate of https://github.com/knurling-rs/defmt/issues/714. Can you please post a small note about your thoughts there?


Movement from Ubuntu to MacOS, can't get v9 going again

Hello, I started a V9 composer project a week ago on my local Ubuntu box.  I recently received a new Mac M1 and found it to be faster than my Ubuntu box so I switched.  I setup the same version of PHP, MySQL, etc on the Mac via Homebrew and cloned my git repo and did my composer installation.  I pulled over the application/config directory, application/files directory and the dump of the database. I tweaked the config for the new database connection and then turned all cache settings off.  Cleared the cache and linked the site up to run.  Unfortunately, I'm running in to an issue.  Here is the error that presents:
Warning: require(/Users/david/Repositories/BOMA-2021/vendor/composer/../../src/helpers.php): failed to open stream: No such file or directory in /Users/david/Repositories/BOMA-2021/vendor/composer/autoload_real.php on line 78
Fatal error: require(): Failed opening required '/Users/david/Repositories/BOMA-2021/vendor/composer/../../src/helpers.php' (include_path='/Users/david/Repositories/BOMA-2021/public/concrete/vendor:.:/opt/homebrew/Cellar/php<EMAIL_ADDRESS>in /Users/david/Repositories/BOMA-2021/vendor/composer/autoload_real.php on line 78
I have been able to move Concrete 5.8.7 projects over without this issue, but the v9 one I cannot seem to get working.  I can also install new V9 projects and those work fine.  Any insight would be great!
Thanks!

Please post it on forum if you want to get support from the community.

Please post it on forum if you want to get support from the community.

OK done.  Thanks!

OK done.  Thanks!


Added graphviz dot backend in order to be able to use the show command from programs...

... linking to the yosys library

FYI: I verified it to be working

This contains a verbatim copy of ShowWorker from show.cc. Clearly this is not the way to maintain a clean and maintainable codebase.

Why not simply run show -prefix schematic -format dot to write the current design to schematic.dot?

I'm not ready to include Yodl as command for Yosys. I need the ShowWorker functionality available in libyosys. This is because Yodl is based on sources that are licensed under the GPL.
Regarding your first point: Of course, it's a verbatim copy. I didn't change any of the existing code. This PR was intended as a refactoring suggestion, because IMHO the ShowWorker should clearly be exposed as backend. Could you please reconsider your decision?
I can, of course, also provide for the appropriate simplifications of the show command. Since ShowWorker is not needed there anymore. I thought this would be trivial though, because this step simply requires you to delete the ShowWorker definition from show.cc.

You did not address my second point: Why not simply use the existing functionality of the show command to write a .dot file?

What do you mean by use the [ ... ] show command. Is the functionality already in the shared lib? From your use of PRIVATE_NAMESPACE_BEGIN at the beginning of show.cc I concluded that it's not intended to be used that way. Moreover, there are no comments whatsoever regarding this issue...
The only other option I can think of is to dump the rtlil code with yosys's ilang backend, manually start another yosys process with your suggested command as input in order to convert the ilang file into dot code. I don't know if I'm interpreting your suggestion right, but if I did: Sorry, I'm certainly not going to do this. I dislike temporary files with a passion and moreover, the show command generates a hidden file in my home directory! I don't want my testing to litter my home directory.

Simpy run e.g. Yosys::Pass::call(design, "show -prefix schematic -format dot"); from your C++ code with the design you want to dump.

Ok, that's nicer. Thanks


Content: How we work

This content will include:

Principles across disciplines
Links to GitHub repositories or presences

Content done and launched on live site.


[bug report] fit mode doesn't work on image element if texture is updated at runtime

If you fork this project and attempt to set the fit mode to cover for example, it won't work. The video will not play on the UI according to the fit mode you chose. It works with static images just fine, but it seems that on textures that are updated at runtime, it fails.

Expected:

Result:

Project repro: https://playcanvas.com/project/972307/overview/video-fitmode


[C++, Go] Inclusion Proof fails for leaf_index = 0

Returning a leaf index of 0 is a valid CT response, per the RFC, and is the index of the first entry.
SCT:
{"tree_size":1,"timestamp":1469742447178,"sha256_root_hash":"4OEMvu0pQwiIBmNv8x+7ivc10k6j0yTuSsmRA3ZPmes=","tree_head_signature":"BAMARTBDAiAiVLelb8WoTpu4JnCaiAVFBZyPrVuNrdXJzlHr2qy49QIfbHdVQRYnOjFsBtduv+7NubX5xhLTPEy9nKtRyueqwA=="}
Proof By Hash:
/ct/v1/get-proof-by-hash?hash=4OEMvu0pQwiIBmNv8x%2B7ivc10k6j0yTuSsmRA3ZPmes%3D&tree_size=1
{"leaf_index":0,"audit_path":[]}
The python implementation follows the RFC algorithm and verifies, but the Go and C++ implementations do not.

Not sure what you mean so I'll take a guess. An audit path is the list of
additional nodes that you need to verify the hash. There aren't any
additional nodes in a single leaf tree.
In RFC 6962 section 2.1.1 it says:
"The path for the single leaf in a tree with a one-element input list
D[1] = {d(0)} is empty:
PATH(0, {d(0)}) = {}"
Or do you mean something else? Have you got some code?
Martin
On 29 July 2016 at 00:11, Gary Belvin<EMAIL_ADDRESS>wrote:

Returning a leaf index of 0 is a valid CT response, per the RFC
https://tools.ietf.org/html/draft-ietf-trans-rfc6962-bis-17#section-10.4.1,
and is the index of the first entry.
SCT:
{"tree_size":1,"timestamp":1469742447178,"sha256_root_hash":"4OEMvu0pQwiIBmNv8x+7ivc10k6j0yTuSsmRA3ZPmes=","tree_head_signature":"BAMARTBDAiAiVLelb8WoTpu4JnCaiAVFBZyPrVuNrdXJzlHr2qy49QIfbHdVQRYnOjFsBtduv+7NubX5xhLTPEy9nKtRyueqwA=="}
Proof By Hash:
/ct/v1/get-proof-by-hash?hash=4OEMvu0pQwiIBmNv8x%2B7ivc10k6j0yTuSsmRA3ZPmes%3D&tree_size=1
{"leaf_index":0,"audit_path":[]}
The python implementation follows the RFC algorithm and verifies, but the
Go and C++ implementations do not.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/certificate-transparency/issues/1278, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMv2T5xLacdgynkJOLhPQvJ01PUiI-h6ks5qaTcqgaJpZM4JXu5d
.

I have a PR for the Go code on the way :-)

Your first comment there says "SCT" at the top, but did you really mean that, or did you mean STH? It really looks like an STH. :smiley:
And you're right, a tree of size 1 has a root hash that's equal to the leaf hash of the only entry in it, and if you ask an inclusion proof for that entry, you'll get an empty audit path. Basically, your algorithm can be simply "for each entry in the audit path, combine it with the hash, and make that the new hash", with this case being that you don't do anything, and your initial hash is your root hash.
I wasn't even sure whether there was any code doing inclusion checks in C++ (which function/class were you using in C++ that showed the bug?) or Go, so I'll take it on good faith that there are and that they are buggy. :smiley:

https://github.com/google/certificate-transparency/blob/cdde1f2345c95ca633514b5c105a13b4e97e2937/cpp/merkletree/merkle_verifier.cc#L34
go/merkletree/merkle_verifier.go L50


adding pre-commit config

What this PR does / why we need it:
Add your description
Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @kdada
Release note:

adding pre-commit config

we'll do this only for push right?

@ddysher when you do it depends on your way of installation.


GPU resources don't need to be mutable

Odd that clippy didn't catched those. I created a new release (v0.2.2) with these changes and some additonal cleanups.


New doc generation

Try to migrate for the doxity tool.

Docs generated and published at https://airalab.github.io/core/docs


Fix error message

There is a typo in error message. It should be "seem" instead of "see".
Signed-off-by: Vivek Goyal<EMAIL_ADDRESS>

@rh-atomic-bot r+


Some of the Polkadot Sub0 POAP NFTs are not loading properly in collection

What happened?
Freshly minted collection this morning - official Sub0 POAP NFTs - some of them are not loaded properly. Because its the official Polkadot NFT collection, it would be good if we could solve this asap. I noticed that epic NFTs in collection have issues the most.
Asset Hub Polkadot.
Collection: https://kodadot.xyz/ahp/collection/13
Example NFT that is not working:

https://kodadot.xyz/ahp/gallery/13-957
https://kodadot.xyz/ahp/gallery/13-731
https://kodadot.xyz/ahp/gallery/13-565

Please reproduce in steps
Open the collection and find the ones that are not loading
Expected Behavior
load them all
What browsers are you seeing the problem on?
Chrome
At which address did you encounter bug?
kodadot.xyz
Are you logged in?
None
Which wallet you are using?
No response
Screenshots

Relevant log output
No response
Payment link for reward
https://kodadot.xyz/ksm/transfer/?target=<My_Kusama_Address_check_https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address>
Code of Conduct

[X] I agree to follow this project's Code of Conduct

works fine for me

works fine for me

event those?

https://kodadot.xyz/ahp/gallery/13-957
https://kodadot.xyz/ahp/gallery/13-731
https://kodadot.xyz/ahp/gallery/13-565

even those?
https://kodadot.xyz/ahp/gallery/13-957

yes

https://kodadot.xyz/ahp/gallery/13-731

yes

https://kodadot.xyz/ahp/gallery/13-565

yes

but https://kodadot.xyz/ahp/gallery/13-853 doesn't load for me

works fine for me

even this one? https://kodadot.xyz/ahp/gallery/13-732

weird maybe it just needs much more time to load

Same here
https://kodadot.xyz/ahp/collection/13

cc @vikiival @preschian

@roiLeo  try to disable cache

IMO Kodadot worker issue check image repo

btw seems it works ok on Nuxt?

https://nuxt.kodadot.xyz/ahp/collection/13

btw seems it works ok on Nuxt?

Possible because it does not DDOS the image service

Deployed workarounds:

https://github.com/kodadot/workers/pull/162/files
https://github.com/kodadot/workers/pull/163/files

Please reopen the issue if anyone still gets the error


Allow a "Version" to re-run an old version again

use case:

Run once, but didn't get files
Re-run same inputs and same version number.

Proposal: add a "JobIteration" argument. When it is 0 (default) nothing happens, then 1, etc., adds a ".1" to the version number.

Need to alter the invoke and also the copy for this, and I guess the status?


How to UPDATE a query with different arguments.

At first
I could have one argument 'aaa' or two arguments 'aaa' and 'bbb'.
UPDATE user SET email = 'aaa' WHERE uid = 'xxx';
UPDATE user SET email = 'aaa', password = 'bbb' WHERE uid = 'xxx';

My problem
How could I use one query to overcome above cases? Like below ...
var sql = "UPDATE user SET email = ?, password = ? WHERE uid = ?;"
dbclient.query(sql, [email, password, uid], function (err, results) {
	...
});

If two arguments were defined, variable sql was :
 sql = "UPDATE user SET email =<EMAIL_ADDRESS>password = 'abcd' WHERE uid = 1;";

If someone argument was undefined, variable sql was :
 sql = "UPDATE user SET email =<EMAIL_ADDRESS>password = password WHERE uid = 1;";

I found the #escaping-query-values can solve it.
Sorry :")

If you want to make the SQL more dynamic to handler more column-value pairs, take a look at:
var sql = [
	'UPDATE user SET',
	'email = ?'
]
var params = [email]

if (password) {
	sql.push(', password = ?')
	params.push(password)
}

sql.push('WHERE uid = ?')
params.push(uid)

dbClient.query(sql.join('\n'), params, function(err, results) {
	console.log(err, results)
})


Is there is way to know when user XCDYouTubeVideoPlayerViewController dismisses?

I want to know when XCDYouTubeVideoPlayerViewController is get dimissed so I can do some house keeping activities.

You have to register for MPMoviePlayerPlaybackDidFinishNotification, see https://github.com/0xced/XCDYouTubeKit/blob/2.2.0/XCDYouTubeKit Demo/iOS Demo/DemoFullScreenViewController.m#L36-L55 for an example.


Dissertation Visual #13: CO1868 Spectrogram

Spectrogram of borrowings in CO1868. Should show heavy reliance on Illinois law.

Beautiful.

Whoops. Didn't mean to prematurely close. I ought to have a companion visualization of Colorado under the Field code, so can you run the same formula on CO1877?

Limit this to IL, IN, IA and Other.

Did the whitelisting for CO1868.

Added CO1877, just working out the details.


Why the accuracy is low  in the start of training  about mobilenetV2 part?

During the training, I only changed the batch size from the default 512 to 256, but the Acc@1 is only about 5% and the Acc@5 is only about 15% before the 5th epoch. Do you encounter this situation during the training?  Thank you !

Low training accuracy is absolutely normal in training the PruningNet. We also experienced that. Thinking that the PruningNet need to predict weights for various different Pruned Networks while the weight in a normal network only need to suit themselves to a single network, it is understandable for PruningNet achieving not as high accuracy as we expect for a normal network.

Low training accuracy is absolutely normal in training the PruningNet. We also experienced that. Thinking that the PruningNet need to predict weights for various different Pruned Networks while the weight in a normal network only need to suit themselves to a single network, it is understandable for PruningNet to achieve not as high accuracy as we expect for a normal network

Low training accuracy is absolutely normal in training the PruningNet. We also experienced that. Thinking that the PruningNet need to predict weights for various different Pruned Networks while the weight in a normal network only need to suit themselves to a single network, it is understandable for PruningNet achieving not as high accuracy as we expect for a normal network.


ledgerutil exits with a proper code

This patch makes ledgerutil exit with a proper code when it fails.
Type of change

Improvement (improvement to code, performance, etc)

Description
The ledgerutil command exits with 0 (success) whether or not it succeeds in the comparison; it exits with 1 (failure) only when the parsing of the command line arguments are unsuccessful.
This patch makes it exit with 1 additionally when

it fails in the comparison of snapshots
it finds that the snapshots are different after the comparison

@manish-sethi Thank you for the comment. I have updated the patch to make ledgerutil return a different exit code when the snapshots are different as well as the documentation for ledgerutil.
As the command name compare suggests, I think the case that the snapshots are identical would not be an error case, either. Therefore, the question would be "0 should be assigned for the 'identical' case or the 'different' case".
As a use case, I have in my mind some kind of a maintenance script that is executed automatically and periodically. In this case, snapshots being different is a scenario that needs attention of administrators. Considering some other common examples such as diff(1) and strcmp(3), I'd suggest the utility return 0 when the snapshots are identical.

As a use case, I have in my mind some kind of a maintenance script that is executed automatically and periodically. In this case, snapshots being different is a scenario that needs attention of administrators. Considering some other common examples such as diff(1) and strcmp(3), I'd suggest the utility return 0 when the snapshots are identical.

Though the original intention of this utility was to use when actually the snapshots are different as for the same snapshots, it's easy to detect just by looking at their metadata file. But I fine with this new proposed meaning - thanks for your contribution.


kubeone: 1.5.3 -> 1.5.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kubermatic/kubeone/releases.
meta.description for kubeone is: "Automate cluster operations on all your cloud, on-prem, edge, and IoT environments."
meta.homepage for kubeone is: "https://kubeone.io/"
meta.changelog for kubeone is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.4 with grep in /nix/store/qhrsnr99myb3bvvkdmdidydmy8qhz249-kubeone-1.5.4
found 1.5.4 in filename of file in /nix/store/qhrsnr99myb3bvvkdmdidydmy8qhz249-kubeone-1.5.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
kubeone

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qhrsnr99myb3bvvkdmdidydmy8qhz249-kubeone-1.5.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kubeone https://github.com/r-ryantm/nixpkgs/archive/f6dbd52c8588ff52f74a2b2009f745570f39f3ab.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qhrsnr99myb3bvvkdmdidydmy8qhz249-kubeone-1.5.4
ls -la /nix/store/qhrsnr99myb3bvvkdmdidydmy8qhz249-kubeone-1.5.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kubeone

Maintainer pings
cc @lblasc for testing.

@ofborg eval


Action does not fail if PKGBUILD was not found

The action does not fail if the PKGBUILD was not found.
In my case I ended up not updating the source hashes and still pushing the package to the aur.
You might consider putting set -e at the beginning of the script.

Oh sorry, I forgot. Like this right?
https://github.com/datakrama/archlinux-package-action/blob/54649a2e6b0a480b7dc7043aae56aa094b3d6e31/entrypoint.sh#L2

Yes, exactly. Thank you!


Current menu not selected

Hi,
I've changed the way my custom layout works, the session layout is under the route /session in separated module, while all the other pages are under de the / route, this has cause the menu not being active anymore and only works if I set the routes this way, example:
{label: 'CLIENTS', route: '/clients', iconClasses: 'fa fa-user' },
{label: 'PROJECT_LEADERS', route: '/project-leaders', iconClasses: 'fa fa-trophy' },
If I use the config like route: 'project-leaders', the link will be active in the right route but only work in the / route, in any other route, the links will be like http://localhost:4200/clients/(project-leaders)
Is there any way to make it work again?

Hi,
Can you fork the project, reproduce this and create a PR?
It will be deployed to https://mledour.github.io/angular-admin-lte/pulls/ID
thanks


kind: Pick up the latest kindest/node image

Also update kubeadm.k8s.io API version from v1beta2 to v1beta3.
Ref: #2720

will update renovate config as a follow up PR 🚀🙏


Check the validity of the scenario file

fix #146

Codecov Report

Merging #149 (2b6d528) into main (99cf7fe) will decrease coverage by 0.17%.
The diff coverage is 40.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   59.61%   59.44%   -0.18%
==========================================
  Files          26       26
  Lines        1102     1112      +10
  Branches      219      223       +4
==========================================
+ Hits          657      661       +4
- Misses        371      374       +3
- Partials       74       77       +3

Impacted Files
Coverage Δ

qgis_deployment_toolbelt/cli.py
70.88% <40.00%> (-4.48%)
:arrow_down:


Add to contrib: ImmediateEntityProvider, LoadTestingEntityProvider

Hack day stuff!
The backend change was because of the load testing provider actually breaking it on cleanup :)

@freben i gave this provider a try given we have a use case to that requires us to update an annotation on the fly which can only by performed by a memberOf a unique group.
I get a 201 response when i post a yaml document toapi/catalog/immediate/entities that contains the updated annotation value but when I do a get on api/catalog/entities the entity still shows the old value, am I missing something?


Update elm/browser to 1.0.2

Wanted to play around with the new debugger, so I downloaded and compiled the example, however it still was using 1.0.1 so this PR fixes this!

Thanks!


Turn CNCF Webinar into a tutorial in Pinniped docs

We should take this demo from our CNCF Webinar and turn it into a docs page on our website so people can more easily follow the commands by copying and pasting them, and follow along at their own pace.
This can go in the Tutorials section of our website.

Here's a slightly higher resolution copy of that video, if it's helpful: https://www.youtube.com/watch?v=6brRiL5_ae4&t=519s


array_merge(): Argument #1 is not an array @ using UserHasAnyRole middleware

I'm trying to use UserHasAnyRole on my middleware's controller like this
	public function __construct() 	{ 		$this->middleware('auth'); 		$this->middleware('has.anyroles:admin,medic'); 	}
then I went to the middleware and then, in the beginning of the handle function I dd($roles) and this is what it cointains:
array:2 [▼   0 => "admin"   1 => "medic" ]
on line 37 at $roles      = call_user_func_array('array_merge', $roles); is where the exception jumps on array_merge(): Argument #1 is not an array

I have the same problem, did you solve it?

Yes, I had to make a middleware on app>http>middlewares called UserHasAnyRole then I copied and pasted the same code from vendor>caffeinated>src>Middleware>UserHasAnyRole and deleted this line:
$roles      = call_user_func_array('array_merge', $roles);
then in your Kernel.php you must assign your new created middleware:
on $routeMiddleware:
'has.anyRoles' => \App\Http\Middleware\UserHasAnyRole::class,
after that you should be allowed to use 'has.anyroles:admin,roleX,roleY,etc' in your controller's middleware


bug: backup compatible bug in v1.10

Describe the bug
When upgrading to v1.10, the meta node panics because of missing fields when parsing the manifest of backups.
Error message/log
thread 'rw-main' panicked at src/meta/node/src/server.rs:337:10:
Unable to start leader services: Encoding error: missing field `state_table_info` at line 1 column 77013

To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

Duplicated with https://github.com/risingwavelabs/risingwave/issues/17926.


Error when building gdrcopy deb package

I'm seeing following error when building gdrcopy deb package:
> ./build-deb-packages.sh
...
> dpkg-shlibdeps: error: no dependency information found for /usr/lib/x86_64-linux-gnu/libcuda.so.1 (used by debian/gdrcopy/usr/bin/sanity)

Which, i suppose, due to installing driver from downloaded *.run package.
Error can be suppressed by adding rule:
override_dh_shlibdeps:
        dh_shlibdeps --dpkg-shlibdeps-params=--ignore-missing-info

to packages/debian/rules, but i'm not sure whether this is the right way to maintain this.

Another issue in same command - if CUDA installed through runfile, not debian package, then this error happens:
dpkg-shlibdeps: error: cannot find library libcudart.so.10.1 needed by debian/gdrcopy/usr/bin/sanity (ELF format: 'elf64-x86-64' abi: '0201003e00000000'; RPATH: '')

which is resolved by adding another flag to dh_shlibdeps in override_dh_shlibdeps: -l${CUDA}/lib64

Thank you for reporting. I will investigate and fix this.

@marsaev The fix has been merged into the master branch. Can I ask you to verify?

Hey Pak, works good for me! I'm also fine with 'validate' and 'copybw' not being part of gdrcopy package.

Hi @marsaev. Nice to hear that it works. Actually, "validate" and "basic" have been merged into "sanity". We then distribute "copybw" and "sanity" with the package instead.
I am closing this issue because the problem has been fixed.


Ensure directory exists before copy

@j2sol @dlundquist

good catch, I changed it to 0755 to match other directories


Clone impl for LocalExecutor?

futures 0.2.0
LocalPool's executor method promises a "clonable handle" to the pool. But LocalExecutor does not implement Clone.

This is actually pretty bad. Say I have a superfuture that wants to spawn non-threadsafe subfutures. Since the Executor trait requires things to be Send for spawning, we can't use the default executor to spawn a non-send subfuture. So we have to somehow pass a LocalExecutor to the superfuture.
To spawn the superfuture via spawn_local, it needs to be 'static, so it has to take ownership of the LocalExecutor. But by moving it into the superfuture, I can't use it anymore to run the LocalPool.
So unless I'm miss(understand)ing something, it is currently impossible to use futures 0.2.0 for non-trivial, non-threadsafe execution on a single thread.

@AljoschaMeyer Thanks for the report! I've opened https://github.com/rust-lang-nursery/futures-rs/pull/872 to fix this.


lifelong learning enhancements tracking issue

This issue is to track these known lifelong learning added in #72 enhancements to be done:

[ ] KB server need its standalone code directory instead of placing into lib directory
[ ] KB API need to be reviewed again(such as /file/download, /file/upload)
[ ] Reduce KB image size(v0.3.0 is 1.28G showed by docker-images)
[ ] In multi-task-learning of lib code, need to add docs and code comment
[ ] Remove scikit-learn requirement for federated-learning surface-defect-detection example
[ ] Reduce lifelong example image size(v0.3.0 is 1.36G)
[ ] Review the requirements of lib

(sedna-example-lifelong-learning-atcii-classifier)[https://github.com/kubeedge/sedna/tree/main/examples/lifelong_learning/atcii] run fail

backend_type should change to sklearn not tensorflow

progress:

Reduce KB image size(v0.3.0 is 1.28G showed by docker-images) ==> reduced to 315MB

S3 storage support is not user-friendly.


fix(patchViaPropertyDescriptor): disable if properties are not configurable

closes #42

Fixes just one of the many, many problems running the angular2 example apps in safari


Got 503 TLS_error_end when DR tls.mode: ISTIO_MUTUAL

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
My DestinationRule:
...
spec:
  trafficPolicy:
    tls:
      mode: ISTIO_MUTUAL

My peerauthentication config:
...
# no selector, apply to default namespace.
spec:
  mtls:
    mode: STRICT # or PERMISSIVE

Then I checked out endpoints from client pod(in default ns same as target pod):
➜  istio ./istioctl pc endpoint istio-client-test-649d77c495-4nlnk --port 3000
# all endpoints is OK
ENDPOINT             STATUS      OUTLIER CHECK     CLUSTER
<IP_ADDRESS>:3000     HEALTHY     OK                outbound|3000|v2|go-multiroute.default.svc.cluster.local
<IP_ADDRESS>:3000     HEALTHY     OK                outbound|3000||go-multiroute.default.svc.cluster.local
<IP_ADDRESS>:3000     HEALTHY     OK                outbound|3000|v2|go-multiroute.default.svc.cluster.local
<IP_ADDRESS>:3000     HEALTHY     OK                outbound|3000||go-multiroute.default.svc.cluster.local

But curl got 503 from client pod:
/ # curl go-multiroute:3000 -v
* Rebuilt URL to: go-multiroute:3000/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to go-multiroute (<IP_ADDRESS>) port 3000 (#0)
> GET / HTTP/1.1
> Host: go-multiroute:3000
> User-Agent: curl/7.59.0
> Accept: */*
> test-version:v2
>
< HTTP/1.1 503 Service Unavailable
< content-length: 253
< content-type: text/plain
< date: Tue, 26 Mar 2024 10:40:24 GMT
< server: envoy
<
* Connection #0 to host go-multiroute left intact
upstream connect error or disconnect/reset before headers. retried and the latest reset reason: remote connection failure, transport failure reason: TLS_error:|268435581:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED:TLS_error_end:TLS_error_end

When I set mtls mode to DISABLE, and tls.mode to DISABLE in DR, curl is success. So what's the problem in my istio configs?
Version
istio verison is v1.20.3, k8s is v1.27.0

Additional Information
No response

oh! f**k 😫😫😫, I have just restart client pod, it's ok now!


Update readme

very minor updates

@shannonhaughton
Thanks for these updates. I think what else could be useful is to add after "From Pandas dataframe to Neo4j and back" section a simple example of using load_dict function on a nested dictionary.

I have added an example here now @paltusplintus - is this what you had in mind


Restyling: Renewal of the Homepage

[x] Footer

[x] Header

[ ] Everything in between

Temporarily copying assets' sub-folders from the Foot Wear theme to the assets pkg of the posters-demo-store. Planning to remove redundant assets later.

having problems with overflowing text in the  drop-down mini-cart and the drop-down user-menu. Text tends to overflow out of the menu boundaries.
With the exception of header-menu, have not implemented changes for the mobile view.
Planning to implementing changes for the mobile view after implementing changes for the desktop view at the homepage.

Have some confusion about the products list.
If I'm to follow the layout of the footwear template, then will have to add more products(Up to 16) to populate the posters homepage. Currently only three such products populate the posters homepage as Hot Products.
In order to add more products will need to modify the WebShopController, from what I understand so far. Need permission for this.


Ribbon Group Separator Missing

Ribbon group separator is missing for some reason between two groups. See screenshot below. Place where separator is missing is marked in red.

This appears to be fixed now. Closing #8


Only add data prop when necessary

Describe the bug
At the moment, there is some situation where a data prop gets added in a layout that's not used, causing a lot of noise by vite.
Severity
annoyance
Steps to Reproduce the Bug
Not sure, yet
Reproduction
No response

Im not able to reproduce this - closing it until there's something concrete


Tearsheet design research: Stepping and Stacking

We are currently exploring Tearsheet stacking and stepping as part of the base component. Currently, stepping is only available in CreateTearsheet. Stacking is unique to Tearsheet of the dialog components (including modal and side panel). We should explore whether stacking presents an accessibility issue.
 - Stacking (accessibility, changing focus). Look up Mike Gower issues/chat with him re: stacking.
 - Stepping: adding stepping as optional functionality to base tearsheet. Matt is exploring this.

This exploration will likely need dev opinion/ paired work.
Tasks

[ ] Reach out to dev team re: stacking
[ ] Reach out to Mike Gower
[ ] Research stacking as a pattern

Research on stacking
Neilson Norman Group
Bottom sheets guidance - 2023

Bottom sheets are more of a mobile pattern, but they share similar attributes with tearsheet, namely the overlay and transient nature of the component.
NNG recommends not stacking bottom sheets.

One of the biggest issues with bottom sheets occurs when an app stacks several such sheets on top of each other. We have previously discussed some of the issues with stacked bottom sheets. Inevitably, users will have to keep track of where they currently are in the rapidly multiplying stack of overlays and will need to be able to discriminate between dismissing the last sheet on the stack and dismissing the whole stack, as in the example below.

We strongly recommend not using a bottom sheet to replace typical page-to-page user flows. A bottom sheet is a transient UI element that is not intended to be a stable place for users to return to, or spend significant time on. They are intended for interruptions or a fork in the road, rather than the expected “happy path” the user will usually take. For example, don’t use a sheet to display an ecommerce product-detail page: the user may navigate to related products, reviews, or detailed specifications from that sheet, and a bottom sheet will break longstanding conventions of how users can navigate from page to page.


BAU: move inline Fingerprint code to external asset

For our CSP work we want to minimise the use of inline scripts so that we can have a small whitelist. The fingerprinting code can happily live externally so this PR moves it and rewrites the tests for the new scenario.

LGTM, but on a partially unrelated note is FINGERPRINT_CONFIG really config if it's a constant value?

I'll change it to FINGERPRINT_PATH in the other open fingerprint PR when I rebase


Deleting components with backspace and delete

Hello, I am a Mac user. The mac doesn't have de delete key. Would you mind adding the option to delete components with backspace?
Nice work!

As of Pre-release 0.0.6 right clicking a component will bring up a menu that includes deleteting a component. I'll leave this issue open to be fixed in the next version

In GUI.java:
private void keyHandler(java.awt.event.KeyEvent evt) {         System.out.print("Key pressed ");         if (evt.getKeyCode() == KeyEvent.VK_DELETE) {             //removing items in this manner causes a bug where the list doesn't update properly since it's controlled in circuitmaker.java             schematicWindow.deleteSelectedComponent();             System.out.print("delete");         }         System.out.println("");     }
Changing the if statement:
if (evt.getKeyCode() == KeyEvent.VK_DELETE)
to
if (evt.getKeyCode() == KeyEvent.VK_DELETE || evt.getKeyCode()== KeyEvent.VK_BACK_SPACE)
Makes it possible to delete components with backspace

Backspace now deletes components in the same way as the delete key does.


fix: Upgrade axios to v1.6.0. Fixes #12085

Fixes #12085.

So it looks like this was a breaking change: https://github.com/axios/axios/pull/6028#issuecomment-1783536371
Per previous comment, I don't think a cookie is needed for the API docs, but could you check to confirm that it still works?
Also I might recommend fix(deps): Update transitive axios to v1.6.0 for the title to be a bit more specific as it's not a dep we use directly

but could you check to confirm that it still works?

Checked myself, seems to work fine. So I think this is good to go once the suggested changes are made


LICENSE file

Would you mind adding LICENSE file in your repository if there's any?
Thank you!

Sure, I'll do this soon.

Added in https://github.com/chmllr/NoteHub/commit/59012329b7e36c6b60e3ea91d85cf511dad6fca1.


Invalid image "UbuntuLTS". Use a valid image "Ubuntu2204"

This pull request includes updates to the articles/virtual-machines/disks-deploy-zrs.md file to reflect changes in the deployment process and ensure the documentation is up-to-date. The most important changes include updating the date, changing the image version, and adding the az group create command in multiple sections.
Changes to image version and commands:

articles/virtual-machines/disks-deploy-zrs.md: Changed the image version from UbuntuLTS to Ubuntu2204 in various sections to ensure the use of the latest Ubuntu version. [1] [2] [3]
articles/virtual-machines/disks-deploy-zrs.md: Added the az group create -n $rgName -l $location command to ensure the resource group is created before other operations. [1] [2]

@roygara
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Use launchd for ctl commands

keybase ctl should use launchd start, stop and restart. Start now
defaults to launchd on OS X by default, but can specify --type if you
want to use autofork.

> keybase ctl start
▶ INFO Starting keybase.service

> keybase ctl stop
▶ INFO Stopping keybase.service

> keybase ctl start && keybase version
▶ INFO Starting keybase.service
Client:  1.0.14-20160321211440+202f099
Service: 1.0.14-20160321211440+202f099

> keybase ctl stop
▶ INFO Stopping keybase.service

> keybase ctl start --type=auto
▶ INFO Forking background server with pid=95425

> keybase ctl stop

>

@maxtaco @patrickxb
I believe some users out there were using keybase ctl start and then their launchd setup wouldn't work and we'd get a bug report since the Keybase.app errors if the launchd service is bad.

cc @oconnor663

ok reverted the cmd_ctl_start.go and made a new cmd_ctl_start_osx.go as @maxtaco suggested

Cool many thanks. Will take a long look tonight!

So reading it through, it seems like another goal here is to move all launchd-related manipulation out of the service, and into the client.  This does make sense, but there are a lot of cases to cover. And it would be good to totally purge launchd-related functions from the service then.

Yeah lmk if you want me to move stuff into platform specific files. It seems like the answer is not right now?

Ok, :+1:, this is a good change.  I agree, no reason to involve the service...
Did you test with standalone btw?  Everything should error out, just wondering.. Thanks!

:+1: if C/I works.  SEems like Ci1 is back up after last night?


Problems with primitive instantiation using synth_xilinx (executing XILINX_DFFOPT)

I was comparing Yosys against ISE and Vivado, using examples provided by Xilinx. I found a problem instantiating the LUT2 primitive in 2 of 3 cases.
To check with iverilog and for the generic synth command, I used the following blackbox definition (blackboxes.v) and it works:
(* blackbox *)
module LUT2 (O, I0, I1);
    parameter [3:0] INIT = 4'h0;
    output O;
    input I0;
    input I1;
endmodule

I have three examples from Xilinx:

primitive_1.v

module v_primitive_1 (I0,I1,O);
    input I0,I1;
    output O;

    (* INIT="1" *)
	 LUT2 inst (.I0(I0), .I1(I1), .O(O));

endmodule

primitive_2.v:

module v_primitive_2 (I0,I1,O);
    input I0,I1;
    output O;

    LUT2 #(4'h1) inst (.I0(I0), .I1(I1), .O(O));

endmodule

primitive_3.v:

module v_primitive_3 (I0,I1,O);
    input I0,I1;
    output O;

    LUT2 inst (.I0(I0), .I1(I1), .O(O));
    defparam inst.INIT = 4'h1;

endmodule

The cases primitive_1.v and primitive_2.v fail:
$ yosys -Q -p "read_verilog primitive_1.v; synth_xilinx -top v_primitive_1"
...
3.47.4. Continuing TECHMAP pass.
No more expansions possible.

3.48. Executing XILINX_DFFOPT pass (optimize FF control signal usage).
Optimizing FFs in v_primitive_1.
terminate called after throwing an instance of 'std::out_of_range'
  what():  dict::at()
Aborted

Note: the file primitive_1.v has as description The INIT value is specified with an attribute, which is rejected by XST

To be clear: the first case will not be supported, as mixing up parameters with attributes this way is just horrible.
Second is more interesting — the problem is that the parameter is positional and is called $1 internally and not \INIT.  I suppose the proper fix here would be to make hierarchy fix it up...

And to be clear: this is not a bug in synth_xilinx or xilinx_dffopt, but a general problem with the usage of positional parameters (and probably in/out signals as well).  Even if xilinx_dffopt was skipped, we'd still emit invalid netlist with the parameter called $1.

Ok, is clear to me now that is related with the positional assignment of the parameter.
For further info, in the first case, ISE fails and Vivado ignores the INIT attr.

ISE:

ERROR:Xst:3154 - "primitive_1.v". Line 13. Unable to set attribute "INIT" with value "1" on instance <inst> of block <LUT2>. This property is already defined with value "0" on the block definition by a VHDL generic or a Verilog parameter. Apply the desired value by overriding the default VHDL generic or Verilog parameter. Using an attribute is not allowed.

Vivado:

 WARNING: [Synth 8-2887] Directive 'INIT' on 'inst' is unsupported and ignored

In the second case, take into account that when synth is used, it does not fails (the output result is a verilog file):
3.26. Printing statistics.

=== v_primitive_2 ===

   Number of wires:                  3
   Number of wire bits:              3
   Number of public wires:           3
   Number of public wire bits:       3
   Number of memories:               0
   Number of memory bits:            0
   Number of processes:              0
   Number of cells:                  1
     LUT2                            1

3.27. Executing CHECK pass (checking for obvious problems).
checking module v_primitive_2..
found and reported 0 problems.

4. Executing Verilog backend.
Dumping module `\v_primitive_2'.

End of script. Logfile hash: 59b15ddd90, CPU: user 0.05s system 0.00s, MEM: 13.86 MB peak
Yosys 0.9+1706 (git sha1 f828cb51, gcc 6.3.0-18+deb9u1 -fPIC -Os)
Time spent: 30% 6x read_verilog (0 sec), 15% 13x opt_clean (0 sec), ...

(I provided blackbox.v version to know LUT2, as shown in the first message).

The positional version should work now — can you retest?

Hi @mwkmwkmwk. I compiled and installed the last master version and now... The three examples are synthesized without complaints. I compare the three synthesis logs and the only difference between primitive_1.v and the other two examples, is that LUT2 is not present when statistics are printed. It seems that it could be a problem.. maybe a warning or error (because unsupported) could be better?
Here the main differences between primitive_1.v and the other two examples:
3.51. Printing statistics.

=== v_primitive_1 ===

   Number of wires:                  5
   Number of wire bits:              5
   Number of public wires:           3
   Number of public wire bits:       3
   Number of memories:               0
   Number of memory bits:            0
   Number of processes:              0
   Number of cells:                  3
     IBUF                            2
     OBUF                            1

   Estimated number of LCs:          0

VS
3.51. Printing statistics.

=== v_primitive_2 ===

   Number of wires:                  6
   Number of wire bits:              6
   Number of public wires:           3
   Number of public wire bits:       3
   Number of memories:               0
   Number of memory bits:            0
   Number of processes:              0
   Number of cells:                  4
     IBUF                            2
     LUT2                            1
     OBUF                            1

   Estimated number of LCs:          1

primitive_2.v and primitive_3.v print the same statistics.

There is no reasonable warning we could give here, really: in the first example, you're passing the INIT value as an attribute instead of parameter, which (if ever supported) is legacy Xilinx cruft we don't want.  The attribute is ignored (as usual for unknown attributes), and the parameter value is now taken from the default in cell_sim.v, which is 0.  The xilinx_dffopt pass, in turn, notices that it can optimize that LUT to a constant driver.  None of these events are reasonable cause for a warning.

Ok, I understood and agree. So, it is solved. Thanks.

@rodrigomelo9 - I agree with @mwkmwkmwk that we probably don't want to promote the usage of these legacy Xilinx cruft and hence upstream Yosys support is probably not the right place.
For compatibility reasons it could still be useful to have a pathway forward to supporting them. A very simple pass which "lowers" the attribute into the correct parameter should be pretty easy to right. This could potentially be part of the "SymbiFlow Yosys plugins" repo. We have already added a couple of things like supporting pulling constraints from xdc files into Yosys parameters / attributes.

Hi @mithro, I agree with do not support these attributes in Yosys. In fact, I always tried to avoid attributes in the code, so it is not something in what I am particularly interested. I didn't know about the Yosys-plugins repo, thanks.

@rodrigomelo9 -- Could you log a bug on the SymbiFlow Yosys plugin repo with the information here so that it doesn't get lost?

Of course @mithro, I can, but... I am not sure what to report :p
In this particular issue, the behaviours of the tools are:

ISE: aborts because xst rejects the attribute.
Vivado: ignore the attribute (with a warning) and performs synthesis (the LUT2 is still there at the end @mwkmwkmwk FYI).
Yosys (now): ignore the attribute (without a warning) and performs synthesis, optimizing (removing) the LUT2.

I don't know from where the specification of a parameter as an attribute is valid: maybe Synopsys? XACT? (which is the software previous to ISE). Anyway, I don't think that this particular case would be very useful. And, to have a plugin which catches other attributes could be a great thing, to deal with legacy code but, I'm not sure it's worth the time it would take.
Let me know if you still want to report an issue and about what exactly :P
Regards


fix(cookie): handle previously set-cookie headers

This commit fixes a case where previous set-cookie headers were ignored through
the request lifecycle. This is now fixed and handles both single and multiple
set-cookie header values. Since in Node.js you can do:
res.setHeader("set-cookie", "name=value"); and
res.setHeader("set-cookie", ["name=value", "name2=value2"])
fixes #112

:tada: This PR is included in version 4.1.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


repo sync

This is an automated pull request to sync changes between the public and private repos.
:robot: This pull request should be merged (not squashed) to preserve continuity across repos, so please let a bot do the merging!

data/release-notes/3-0/1.yml

gh_1.9.1-pre0_checksums.txt


macos Ventura 13.2.1 reports only 'pass' and 'file' as available backends, no 'keychain'.

Hello,
macos Ventura 13.2.1 reports only 'pass' and 'file' as available backends, no 'keychain'.
Is this a known issue? I see the keychain access app and can view saved credentials in the GUI, but when running 'fmt.Println(keyring.AvailableBackends())' it shows '[pass file]'. I should note I'm not a mac user but some tools I've written in go I do also compile for mac to support the small group of mac users I have, so I may just be missing something stupid.
Regards,

David C.

@dcopenhaver are you seeing this on a intel or arm arch based machine? i ask because i'm seeing differences based on the arch, not OS version in https://github.com/jacobbednarz/cf-vault/pull/147


Small CLI fixes

This PR combines a bug fix with several tiny improvements to CLI functions, and the introduction of a developer util decorator.
The bug is this (reporting a successful flexmeasures db-ops dump when in fact it failed):
Backing up <IP_ADDRESS>/flexmeasures-db database
/bin/sh: line 1: pg_dump: command not found
db dump successful: saved to pgbackup_flexmeasures-db_2022-11-01-1510.dump

Likewise for flexmeasures db-ops restore.
The timeit decorator can be added to to CLI functions (or any function, really) to print out the run time of that function. Is this something you'd consider adding as a default for all CLI commands?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 17 (23.53%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 64.964%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flexmeasures/cli/db_ops.py
0
2
0.0%

flexmeasures/cli/data_delete.py
1
4
25.0%

flexmeasures/utils/coding_utils.py
2
10
20.0%

Files with Coverage Reduction
New Missed Lines
%

flexmeasures/cli/data_delete.py
1
28.07%

flexmeasures/cli/db_ops.py
2
41.46%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
6519

Relevant Lines:
9421

💛  - Coveralls


Add pop func to sync pool

Codecov Report

Merging #24 into master will increase coverage by 0.51%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   58.83%   59.35%   +0.51%
==========================================
  Files          24       24
  Lines         651      647       -4
==========================================
+ Hits          383      384       +1
+ Misses        222      216       -6
- Partials       46       47       +1

Impacted Files
Coverage Δ

sync/pool.go
100% <100%> (ø)
:arrow_up:

net/tcplistener.go
57.89% <0%> (-2.64%)
:arrow_down:

net/conn.go
75% <0%> (+7.14%)
:arrow_up:

net/isTemporary.go
33.33% <0%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b8bcb...564f0b0. Read the comment docs.


[SPARK-15100][ML][Doc] doc update for stopwords and binarizer

What changes were proposed in this pull request?
2.0 Audit: Update document for StopWordsRemover and Binarizer.
How was this patch tested?
manual review for doc

Test build #59557 has started for PR 13375 at commit 625b34c.

Test build #59557 has finished for PR 13375 at commit 625b34c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59557/
Test PASSed.

Thanks for the review @srowen

Test build #59592 has started for PR 13375 at commit e4e56b3.

Test build #59592 has finished for PR 13375 at commit e4e56b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59592/
Test PASSed.

I think that's fine.

@hhbyyh Could you please create a new JIRA for this PR to make it clear in JIRA what it is addressing?  Please link it to SPARK-15100.  Thanks!

created sub-task: https://issues.apache.org/jira/browse/SPARK-16045 and updated the title.

LGTM. Merged into master and branch-2.0. Thanks!


try again to support macos

Let's wait til llvm/clang 14.0.0 is supported via KyleMayes/install-llvm-action@v1 and see whether compilation succeeds.

superseded by #29


Generate index for new RD: Paula

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/index.yml
:white_check_mark:Succeeded

rd/map.yml
:white_check_mark:Succeeded

rd/media/profiles/paula-januszkiewicz.jpg
:white_check_mark:Succeeded

rd/media/profiles/reza-rad.jpg
:white_check_mark:Succeeded

rd/paula-januszkiewicz.yml
:white_check_mark:Succeeded

rd/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Merge changes from fork

draw the full screen less often
Update README
Fix: make merge_lines not leave trailing spaces
fix: disable folding
chore: lint cleanup
chore: fix indent
feat: show line number of context items
chore: nvim_command -> vim.cmd
chore: remove gutter buf on disable
chore: big refactor
chore: more refactoring
chore: more refactoring
doc: update README
fix: only get matches for root tree
Remove nvim 0.5 compat
chore: refactor
iterate parents from top, move visible line for each match
Add exclude patterns
refactor: prefer 'local function '
refactor: remove utils.lua
break!: Nvim 0.7 updates
doc: update README with Neovim requirements
fix: don't use deprecated functions
fix: support nonu nornu
fix #7
fix: Don't hide cursor with context
fixup #9: dont hide cursor max_lines == 0
feat: show *section context in tex files
feat: show chapter context in tex files
Include first line when looking for valid parent nodes
fix!: always throttle, remove config.throttle
feat: support relative line number
chore: fixup README

Alright, so I went over the code, didn't read everything in detail but what I read looked fine and the PR worked fine after pulling, so I've merged as-is.
I saw you cleaned up the issues, thanks for that, I'll go through them as well.
I'm still waiting for an update from someone on the nvim-treesitter org to transfer, I'm never sure if the pings reach them though. Maybe I'll ask on gitter see if someone can speed that up.

I've spoken with @vigoux on matrix and plans to get it done today.


Add EBI header and footer

Can take the code from ZOOMA
https://github.com/EBISPOT/zooma/blob/main/zooma-ui/src/main/frontend/src/components/EBI.tsx
https://github.com/EBISPOT/zooma/blob/main/zooma-ui/src/main/frontend/public/index.html

Actually seems the one we use in ZOOMA is outdated. The current version is described here:
https://latest.visual-framework.dev/components/ebi-header-footer/
Not immediately obvious how to integrate it so more research needed.


Discard changes to G if a move is invalid

Immer is super handy when making complex changes in a move rather than using immutable update patterns in a deep nested object. However, I have a few occasions when I'd like to discard some changes I've made if it turns out the move is invalid.
For instance, when a card is played in a particular way, a corresponding token is put on the board in a starting space and then is moved to another space on the board. It's easier to put the token on the board and then check if the move is valid so I modify G and run the check, but if it's invalid and I return INVALID_MOVE, Immer rightfully complains.
I tried messing with Immer's original function but it doesn't seem to do what I want. Ideally, before I return INVALID_MOVE I'd like to make as if I hadn't modified G at all and reset it to its previous state. That sounds like something that should be possible but I can't figure out how.

I haven't found a good solution to this either. Does making the changes in a copy of G work? You can use that to check if the move is invalid and then copy it over the the original if you want the move to proceed.

I did try to make a copy of G like so const draftG = { ...G } and making the changes to draftG but I still get an error. Could be I'm doing something wrong somewhere else, but my impression was that the underlying objects are still being proxied by Immer. Might be worth doing a reduced test case?
Could also be something to bring up with the folks over at Immer? It might not fit the use cases they want to cover since you can already return NOTHING if you want to discard the changes (if I got that correctly). Is INVALID_MOVE a wrapper around Immer's NOTHING?

I think Immer’s nothing is used if you want to reset your state to undefined (which returning undefined won’t do, nor assigning state = undefined) (docs).
Could the problem with const draftG = { ...G } be nested object references? It’s more expensive but maybe some kind of deep copying could work or do proxies interfere with that? Something as simple as const draftG = JSON.parse(JSON.stringify(G))?
I’m not very familiar with Immer, but just reading through the docs, I see they mention a function for getting the draft’s original state.
Could we use that to do something like the following internally?
import { original, produce } from 'immer';

const newG = produce(oldG, G => {
  const moveResult = moveFn(G, ctx);
  if (moveResult === INVALID_MOVE) return original(G);
  return moveResult;
});

This would be great, because INVALID_MOVE could be returned at any point in move functions instead of validation all having to happen before any mutations.

@delucis definitely something to do with the nesting for the draftG idea. Might be worth a try but I think I like your suggested approach better. As you say, you can return INVALID_MOVE at any point and that's very handy.
I did try their original function but inside the move but no luck. Doing it as you suggest would solve that issue brilliantly!

I did try their original function but inside the move but no luck.

Well, it’s also very possible I’ve misunderstood what original does 😅
If it is theoretically sound, we would have to update the immer plugin and figure out a way to flag to outside code that the move was invalid. Currently the reducer checks the return to bail out of events etc.:
https://github.com/nicolodavis/boardgame.io/blob/2f74b548b53b69ee028cfd73d50032e36ff16b64/src/core/reducer.ts#L166-L172


Support browser field of package.json

Describe the feature
Support the browser field of package.json (docs) to determine an entry point that overrides main when the target is a browser environment. This field is supported by Webpack and other bundlers and would be helpful for users migrating to spack/swc.
It would enable support for isomorphic packages such as isomorphic-fetch.
Additional context
This should be enabled by default (the assumption is that the browser is the most common target) but an option needs to be provided to disable use of  the browser field for other targets such as server-side code. This could be achieved with a new configuration parameter in .swcrc which could be set on the command line when invoking spack to override the configuration.
Note I have assumed this is not yet supported as the PackageJson struct in NodeResolver does not declare the field.
Reference

Webpack aliasFields
Browser field spec

Is this a bug about the bundler?

I don't think it's a bug so I created a feature request as I figured you just haven't had time to implement this yet. Happy to help out to get this landed of course :+1:
It is worth being aware that handling package entry points correctly from package.json configuration is a bit of a can of worms. So in addition to browser there is also the module field when the type is set to module and then there is the more recent exports (docs) which is specific to nodejs and supports different entry points for ESM (import) and CommonJS (require) - implementing this may involve passing a context to NodeResolver indicating whether to prefer ESM or CommonJS entry points.
Neither of these are part of the official package.json specification (unlike browser) but many bundlers support them and I think the goal for spack/swc should be compatibility so migrating from other bundlers is easy.

I mean is this feature request about the bundler of the resolver.

It is related to the bundler as it is about resolving package entry points but I think the main part of the implementation would go in NodeResolver as that is where package.json is read and the main entry point is determined: https://github.com/swc-project/swc/blob/master/ecmascript/loader/src/resolvers/node.rs#L150.
But because reading the browser entry point is only specific to a particular target environment the implementation is also concerned with configuration (.swcrc) and command line options IMO.

Closing as fixed by #2045 .


carrierwave-google_drive now cannot upload image to google drive.

Halo,
When uploading image to google drive, i have an error:
Authentication failed for<EMAIL_ADDRESS>Response code 404 for post https://www.google.com/accounts/ClientLogin: https://developers.google.com/accounts/docs/AuthForInstalledApps
I'm googling and find that now we have to use OAuth 2.0 to access google drive, ClientLogin has been officially deprecated. I get the information here https://developers.google.com/identity/protocols/AuthForInstalledApps
Parallel588, what can I do to solve this error?

I have the same problem. All my apps that use this gem stopped working


Set function channel to idle to prevent DNS resolution of deleted pod

Motivation
When running the Kubernetes runtime and deleting a function, it is possible to observe the following error log:
15:36:17.025 [worker-scheduler-0] INFO  org.apache.pulsar.functions.utils.Actions - Sucessfully completed action [ Deleting statefulset for function ds/default/gluon-revolut-ord-rsp-assembler ]
15:36:17.405 [grpc-default-executor-307] WARN  io.grpc.internal.ManagedChannelImpl - [Channel<99>: (pf-ds-default-gluon-revolut-ord-rsp-assembler-0.pf-ds-default-gluon-revolut-ord-rsp-assembler.pulsar.svc.cluster.local:9093)] Failed to resolve name. status=Status{code=UNAVAILABLE, description=Unable to resolve host pf-ds-default-gluon-revolut-ord-rsp-assembler-0.pf-ds-default-gluon-revolut-ord-rsp-assembler.pulsar.svc.cluster.local, cause=java.lang.RuntimeException: java.net.UnknownHostException: pf-ds-default-gluon-revolut-ord-rsp-assembler-0.pf-ds-default-gluon-revolut-ord-rsp-assembler.pulsar.svc.cluster.local: Name or service not known
	at io.grpc.internal.DnsNameResolver.resolveAll(DnsNameResolver.java:399)
	at io.grpc.internal.DnsNameResolver$Resolve.resolveInternal(DnsNameResolver.java:269)
	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:225)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.net.UnknownHostException: pf-ds-default-gluon-revolut-ord-rsp-assembler-0.pf-ds-default-gluon-revolut-ord-rsp-assembler.pulsar.svc.cluster.local: Name or service not known
	at java.base/java.net.Inet4AddressImpl.lookupAllHostAddr(Native Method)
	at java.base/java.net.InetAddress$PlatformNameService.lookupAllHostAddr(InetAddress.java:929)
	at java.base/java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1519)
	at java.base/java.net.InetAddress$NameServiceAddresses.get(InetAddress.java:848)
	at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1509)
	at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1368)
	at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1302)
	at io.grpc.internal.DnsNameResolver$JdkAddressResolver.resolveAddress(DnsNameResolver.java:624)
	at io.grpc.internal.DnsNameResolver.resolveAll(DnsNameResolver.java:367)
	... 5 more
}

This error happens because the ManagedChannel is created to target the StatefulSet pods, and the function worker deletes the pods before shutting down the ManagedChannel. Note that there is nothing about pod deletion that triggers the GRPC client to connect to the functions. The error happens due to the way that GRPC handles DNS and its frequent DNS resolution.
There are two solutions. First, we could shutdown the managed channel first, or we could set the channel to idle and prevent any new DNS resolution (as long as there are new connections). Given that the StatefulSet or the Service could fail to get deleted, it seems simpler to just set the channel to idle and then delete it after successfully deleting the function.
Although, it's worth noting enterIdle is labeled as experimental. It looks like it is implemented in the ManagedChannelImpl to do exactly what we want: stop DNS resolution for as long as the channel stays in "idle" state. Here is the associated Javadoc
  /**
   * Invoking this method moves the channel into the IDLE state and triggers tear-down of the
   * channel's name resolver and load balancer, while still allowing on-going RPCs on the channel to
   * continue. New RPCs on the channel will trigger creation of a new connection.
   *
   *
This is primarily intended for Android users when a device is transitioning from a cellular
   * to a wifi connection. The OS will issue a notification that a new network (wifi) has been made
   * the default, but for approximately 30 seconds the device will maintain both the cellular
   * and wifi connections. Apps may invoke this method to ensure that new RPCs are created using the
   * new default wifi network, rather than the soon-to-be-disconnected cellular network.
   *
   *
No-op if not supported by implementation.
   *
   * @since 1.11.0
   */
  @ExperimentalApi("https://github.com/grpc/grpc-java/issues/4056")
  public void enterIdle() {}

Modifications

Set all channels to idle before deleting the function pods in the K8s function runtime
Fix some copy/pasted log lines that were a bit confusing
Fix typos of sucess.

Verifying this change
This is a trivial change that will not affect the logic of function deletion. It just ensures graceful shutdown and avoids benign errors that might otherwise confuse users.
Does this pull request potentially affect one of the following parts:
This is a backwards compatible change.
Documentation

[x] no-need-doc

This is an internal cleanup.

@freeznet @nlu90 Please help review this PR.


After ng build --prod process, I got this.bindPlayEvent is not a function error

Wonderful audio player for ng7+
But I got some errors after finishing build --prod then,

this.bindPlayerEvent is not a function
at e.ngOnInit ........

How can I fix this issue?

Wonderful audio player for ng7+
But I got some errors after finishing build --prod then,
this.bindPlayerEvent is not a function
at e.ngOnInit ........
How can I fix this issue?

I just remove all package and reinstall and build again~!!
All errors has gone.
But, Now I got new error in this time.
I check mobile device and figure out player is something wrong.
Is this module not support for mobile web browser?

It should support mobile web browser as well as its responsive in nature.


Extend header navigation items properties to allow for data- attributes on items in a macro

I have a need to add data- attributes to header navigation items.
We currently use a header macro, which unfortunately does not allow data- attributes on navigation items.
Consider allow that. Fallback is not to use the macro to generate the header, just use HTML.

Could this mean adding 'attributes' property support for the individual items?

yeah ! :)

Original https://github.com/alphagov/govuk-prototype-kit/pull/551 need


Smarter initializations for AFT models

Related to #661, we can choose better initial values for AFT models.
From flexsurvreg:

If not specified, default initial values are chosen from a simple summary of the
survival or censoring times, for example the mean is often used to initialize scale
parameters. See the object flexsurv.dists for the exact methods used. If the
likelihood surface may be uneven, it is advised to run the optimisation starting
from various different initial values to ensure convergence to the true global
maximum.

Strategy: under the null (or even averaging over all scenarios), all the coefficients are nil and the intercepts are equal to the values fitted in a univariate parametric model. Thus good default values for the intercepts are  values fitted in a univariate parametric model. This comes at a perf cost, but we make it up later as we cache the null log likelihood for the log-likelihood ratio test.

We also may gain performance on less iterations 🤞

Nice! Yes, a smarter initialization might be useful for robustness, as long as it doesn't significantly degrade performance (maybe it should be optionally activated?). It may be the case that a user already applies a problem-specific strategy to handle convergence issues, so forcing a robust, but slow approach for each call to .fit wouldn't be very welcome in this case.
Multi-start can be a good idea (since we're dealing with a nonlinear optimization problem), but I wouldn't affirm something like

to ensure convergence to the true global maximum.

because we're not applying a deterministic optimization algorithm to provably converge to the global solution.

From my local performance tests, it won't be noticeable (and you can always "turn it off" by supplying values like np.zeros(..)).
I'm surprised they use multi start. Unless I'm missing something, the log-likelihood is non-linear but is convex, so optimization algos should converge to the global minimum.
Part of the my problem is I can't get the model to actually fail to converge, so it's hard to know what needs to be done.

Equation 20 on page 5: https://www.biorxiv.org/content/biorxiv/early/2018/08/27/362186.full.pdf. I don't think we're dealing with a convex model here. We wouldn't need a starting point if it were convex (just enough iterations).

Yea, you're right: the proof is in the pudding. Different results for survreg vs flexsurvreg vs lifelines suggest local minima.


how to get the 'original_data.npz' file

hello，i use the following code to get the original_data.npz, and then run the process_Epinions_data.py and cvae_ind.py. And I can not get the result in paper(in fact I got the value 0.1807 of NCRR) , how should I run the code? Waiting for help. Thanks a lot.
import numpy as np

trust_data = np.loadtxt('../trust_data.txt',dtype=int)
ratings_data = np.loadtxt('../ratings_data.txt',dtype=int)
print(ratings_data)
np.savez('original_data.npz',trust_data=trust_data,ratings_data=ratings_data)

Hi @xingyuezhiji , thanks for trying our code. I think the way you generated the file "original_data.npz" is fine, but I am curious where did you get the files "trust_data.txt" and "ratings_data.txt"?  Did you get it from here? We know that there may be multiple different Epinions datasets. Probably that is the reason. We understand that different train/test splits and different runs may yield slightly different performances, but that should not be that far away from the original results.

Seems that the dataset size is correct. Are you sure what you get is 0.1807? not 0.01807?
Also, I used python2 to run but I do not think it should have such a big difference. Can you make sure if you are running the correct file cvae_ind.py? Since the line 170 in this file is not following the grammar with python3. If the file is correct, can you run it again and let me know what do you get for the Random test RR (printed using the code in line 170)?

Seems that the dataset size is correct. Are you sure what you get is 0.1807? not 0.01807?
Also, I used python2 to run but I do not think it should have such a big difference. Can you make sure if you are running the correct file cvae_ind.py? Since the line 170 in this file is not following the grammar with python3. If the file is correct, can you run it again and let me know what do you get for the Random test RR (printed using the code in line 170)?

To use python3，I add the parentheses '()' after 'print'. Also, I change f = file(FLAGS.input_data_file_name, 'rb') into f = open(FLAGS.input_data_file_name, 'rb'), and change the code from https://github.com/datang1992/Correlated-VAEs/blob/3a08fe3d9bc5f5334d20602991920c73ba595a1f/src/process_Epinions_data.py#L89 into the follow code:
new_l = np.asarray(list(s3.intersection(s4.intersection(s5))),dtype=np.int64)
id_map = -np.ones(N, dtype=np.int64)
id_map[new_l] = np.arange(new_l.shape[0])
trust_data = trust_data.astype(np.int64)

That is the all i have changed the code.

Can you run the original code in python2 for preprocess_Epinions_data.py and cvae_ind.py again and let me know what did you get for random Test NCRR and best test NCRR, without modifying the original datasets from the website and the code? I did not see any big differences if you only change this part of the code. But we just want to make sure everything is the same in case if you forgot that you changed some other part of the code and the datasets.
Also, can you let me know why do you need to change the line 89-92? And can you let me know if you use any parameters in the files preprocess_Epinions_data.py and cvae_ind.py other than the default values?

here is my running result

Can you show me the random NCRR? Seems this is not what I expect. Probably the issue happens in the dataset preprocessing.

Oh I saw the random test NCRR, which is too high. That means that probably your dataset is smaller than the version we get using the default parameters from process_Epinions_data.py. Can you run the original process_Epinions_data.py again using python2 and the original datasets, and train this model again? Thanks.

okay，I try using python2 to run again

Thanks. Let me know if you have further issues. I guess it is not because of version of python, but perhaps you edited some part of the code or used a different parameter and as a result the dataset size is different.

Thanks. Let me know if you have further issues. I guess it is not because of version of python, but perhaps you edited some part of the code or used a different parameter and as a result the dataset size is different.

Thanks a lot! I run the process_Epinions_data.py in python2, and then the NCRR result is correct!

Great to hear that! No problem. Let me know if you have further questions.


Use stdweb spawn_local to execute futures

Description
Allow to use send_future with cargo web and asmjs-unknown-emscripten target by using stdweb spawn_local future feature.
An example of using future with stdweb https://github.com/koute/stdweb/blob/master/examples/futures/src/main.rs
Context (Environment)

Rust: v1.39.0 stable

yew: v0.10.0

target: asmjs-unknown-emscripten

cargo-web: v0.6.26

I realize this is different, but some may find it useful. I just tried using the spawn_local from wasm-bindgen for a function marked #[wasm_bindgen] and it worked. I'm using yew from master branch.
https://docs.rs/wasm-bindgen-futures/0.4.5/wasm_bindgen_futures/fn.spawn_local.html
https://github.com/rustwasm/wasm-bindgen/search?q=spawn_local&unscoped_q=spawn_local

Oh, interesting.
Although it has since been removed and replaced with this stdweb based spawn_local in the yewtil crate, there are eventual plans to re-add a wasm-bindgen based implementation you could choose to use. This is more simple than the prior implementation, and should make gating either behind a feature flag much easier.

With async move, I was able to  call emit on branch_received: Callback<String>.
    spawn_local(async move {
        let branch = get_branch().await.unwrap_throw(); // vs unwrap?
        branch_received.emit(branch);
    });

Since the corresponding PR in the appropriate repo was merged, I think that this issue can be closed.


Switching tabs when generating code with Copilot messes up file contents

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.85.1
OS Version: Windows 10

Steps to Reproduce:

Press ctrl + i to open prompt window
Start generating code
Switch tabs while generating code

Generated code will end up in the file you opened, it will be mixed with the existing file content

Optimistically closing this because we have revised how changes are cancelled and tracked


stat_type argument in load_player_stats() yields unexpected results

I see a few kickers included in the "offense" stat type, but not all of them. This is weird because kicking seems like an offensive position, and there is also a "kicking" stat_type option.
library(nflreadr)
library(dplyr)

kicking <- load_player_stats(seasons = TRUE, stat_type = "kicking")
offense <- load_player_stats(seasons = TRUE, stat_type = "offense")
glimpse(semi_join(offense, kicking))

Also, I see defensive players in the "offense" stat type, and there is no option for stat_type = "defense":
offense %>%
  distinct(player_display_name, position) %>%
  filter(player_display_name == "J.J. Watt")

What am I missing?
Thanks for all the work on this project!

stat_type refers to the particular statistics returned, not which players are returned - so kickers appearing in offense stat refers to those players accumulating rushing/receiving/passing stats. defensive player stats aren't yet supported via nflreadr but is on our to-do list

Got it. Thanks @tanho63!


Implement has_changed in HStoreField to correctly handle empty one

HStore Form Field falsely report has_changed. Implementing a custom has_changed method for this kind of field, we avoid comparing a default empty string '' with an empty dict {}

buildbot, test this please.

Merged in 43b2d88a5b9cfb151ccf7ac861f2750e70c0e2c4, thanks!


DateTime readjusting when user returns to edit scan job recurrent schedule

Describe the bug
When a user returns to edit their recurrent scan job, the previously saved time is displayed incorrectly.  At this point it appears the time is being saved correctly, however it is being displayed wrong when choosing to edit.
To Reproduce
Steps to reproduce the behavior:

navigate to https://a2-dev.test/compliance/scan-jobs/jobs
Create a recurring scan job
return to https://a2-dev.test/compliance/scan-jobs/jobs
click the Edit button next to that scan job to edit
notice that when viewing the times to select for your recurrent job, they are different than previously saved.

Expected behavior
When choosing to Edit a previously saved job, a User should see the same time they last saved as the first option displayed.
Screenshots

time is being saved correctly, however it is being displayed wrong when choosing to edit

what i'm seeing is this:

time is correct utc time on the form
when i click save, the time sent to the backend is different -- like it thinks the utc time is localtime and adds to it to make it utc time but it's already utc time

resolved with https://github.com/chef/automate/pull/3280
thank you!


Update default CPU compilation flags.

https://github.com/openxla/iree/commit/c5a6cdc8dd89b048b81e212f7ca674aa111d56f1
https://github.com/openxla/iree/commit/52eb7e9b82380500a9776a1dbe2d26ae093b0191
tweak CPU iree-compile flags to match upstream changes.

Did you file a bug to fix data tiling for unet?

done, thanks for the reminder
https://github.com/openxla/iree/issues/15751


Deleted data remain in database

Why deleted data like categories, products, etc remains as records in the database?
I think they should be removed accordingly because the collide with other functions, for example the search function, when you look in there :ghost:  products appear

The behaviour you witnessed is a bug, but instead we should fix the search function to exclude deleted content. A good CMS should make it very hard for you to lose (accidentally delete) data, so please open issues for colliding functions.


Possible to replay term files

Is it possible to archive a set of term files and use these to replay and exactly reproduce issues in a test environment ?

It is possible for the data structures. In fact, it is consequence of the design.
However, currently there is no interface to do it. It would be quite easy to add this, though. It would be a little different version of some of the driver internal objects.


Refactor header handling, make outgoing ICMP work

All outgoing ICMP vlan tests pass with this change.

Besides one nit, LGTM.

LGTM.

This  ties in with https://github.com/Igalia/snabbswitch/issues/99 - all outgoing ICMP should now work with vlans, both v4 and v6.


High energy consumption

Even if the app just sits on the account overview page and nothing visible happens the energy consumption of the application constantly ranges from high to very high. This behavior definitely should be optimized. Battery is a very very precious good on iOS and mobile in general.

NDXRV4-767UOX-C2CY3Y-IRLFMB-TWIXXS-V7GQYO-WELC

@kmiliak Any idea?

Bounty paid. Tx hash: 0f022d0ee96309fa7cf580788f966189c3aad2b827eee47912cfede8be8dca6d


Switch to JMODs providing front-end configs in arrays

I'm not sure why I decided to have explicitly named instances for JMOD front end components. This makes errors in configurations more likely. JMODs should switch to providing an array containing objects that represent individual front-end instance configs/data. If a identifier is needed for a component, the JMOD should be responsible for making sure unique IDs are provided in each config.

Closed in new-frontend-config pull request #99


CI 0.5.2-STAGING

Marked as status/ready for test in 0.6-6-STAGING by CI build #5.

Marked as status/tested in 0.7-7-SNAPSHOT by CI build #2.

Marked as status/tested in 0.7-7-SNAPSHOT by CI build #3.

Marked as status/tested in 0.7-7-SNAPSHOT by CI build #4.


non-aggregation query support

will add more test cases for go part

Codecov Report

Merging #112 into master will increase coverage by 0.07%.
The diff coverage is 81.86%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   75.26%   75.34%   +0.07%
==========================================
  Files          86       88       +2
  Lines       13519    13626     +107
==========================================
+ Hits        10175    10266      +91
- Misses       2558     2573      +15
- Partials      786      787       +1

Impacted Files
Coverage Δ

query/aql.go
100% <ø> (ø)
:arrow_up:

query/stats.go
90.42% <ø> (ø)
:arrow_up:

query/aql_context.go
100% <ø> (ø)
:arrow_up:

query/time_series_aggregate.go
74.03% <0%> (-1.27%)
:arrow_down:

memstore/common/data_type.go
73.19% <100%> (ø)
:arrow_up:

query/aql_postprocessor.go
74.78% <100%> (+0.87%)
:arrow_up:

query/hll.go
76.52% <100%> (ø)
:arrow_up:

query/aql_compiler.go
76.23% <66.66%> (+0.07%)
:arrow_up:

query/aql_batchexecutor.go
83.05% <83.05%> (ø)

query/aql_processor.go
74.9% <85.71%> (-0.15%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55801b...2a651f1. Read the comment docs.

support non-aggregation query


[NFC] Simplify Opaque Type Registration

Drop the table of unvalidated declarations and rename the accessor so
it's a little clearer what kind of lookup this will perform.  On lookup,
the declaration will be validated via the call to getInterfaceType().
In the future, we should investigate making this even lazier by letting
the client control where validation should occur unless we're absolutely
certain this entrypoint should return a fully validated declaration.

@swift-ci please smoke test

Dismaying that the tests pass...
I'll implement the other approach then reopen this.

Hm, I thought I had some tests that tried to intentionally look up opaque types before they would've been validated, but of course validation order is impossible to maintain.


fix(route): update route.protocols document

Summary

Kong accepts HTTPS requests when route.protocols is set to only ["http"].
Reason

Testing

FTI-4566

@vm-001 If this is for Gateway 3.2, could you change the base branch to release/gateway-3.2? Thanks!

@vm-001 If this is for Gateway 3.2, could you change the base branch to release/gateway-3.2? Thanks!

Done.

@vm-001 Sorry for not catching this sooner, but I think since this is new as of 3.2 and the Admin API doc is autogenerated, I think you need to add your content to this file instead: https://github.com/Kong/kong/blob/master/autodoc/admin-api/data/admin-api.lua

@cloudjumpercat Sorry for not following up quicker since I'm in a heavy load.
Kong PR is here: https://github.com/Kong/kong/pull/10097


WinRT build & fsPortableReflection.cs

was curious if the WinRT build is required for UWP builds?
as I was to build DLL for WinRT, shows:
Severity	Code	Description	Project	File	Line
Error	CS1503	Argument 1: cannot convert from 'System.Reflection.TypeInfo' to 'System.Type'	FullSerializer - Unity - WinRT	F:\Development\Full Serializer\Source\Internal\fsPortableReflection.cs	54
resulting also in:
Severity	Code	Description	Project	File	Line
Error	CS1061	'Type' does not contain a definition for 'IsGenericType' and no extension method 'IsGenericType' accepting a first argument of type 'Type' could be found (are you missing a using directive or an assembly reference?)	FullSerializer - Unity - WinRT	F:\Development\Full Serializer\Source\Converters\fsIEnumerableConverter.cs	50
what am I missing here?
I had to add the following for the Unity version build to fsISerializationCallbacks:
#if !NO_UNITY
using UnityEngine;
#endif
...
and wrap:
#if !NO_UNITY
public class fsSerializationCallbackReceiverProcessor : fsObjectProcessor {
    public override bool CanProcess(Type type) {
        return typeof(ISerializationCallbackReceiver).IsAssignableFrom(type);
    }

    public override void OnBeforeSerialize(Type storageType, object instance) {
        ((ISerializationCallbackReceiver)instance).OnBeforeSerialize();
    }

    public override void OnAfterDeserialize(Type storageType, object instance) {
        ((ISerializationCallbackReceiver)instance).OnAfterDeserialize();
    }
}

#endif

Sorry, this accidentally got broken. It looks like #67 fixes this though.


Replace tightdb to realm in build.sh

Change "tightdb_objc" to "realm_objc" in build.sh
"tightdb_objc" is used as working directory name in package build process.
This PR changes just the working directory name, "tightdb_objc" to "realm_objc".
CC: @jpsim @segiddins

This needs a bunch of CI changes since most of the Jenkins jobs use the tightdb_objc name in various places.

OK, I've got it.


Project cleanups

I browsing the code, I noticed a few things about the project structure and setup that could use some attention. I'd like to submit a PR with the fixes but would like to discuss the changed before making a bunch of changes.

[ ] Use explicit module versions in package.json - Currently it is using * as dependency versions. This make for totally unreliable builds as we don't know which versions of dependencies are being used today nor 3 months from now. Case in point, mocha 3.0.0 dropped support for html-cov. So the html coverage reporting will not work unless we explicily set an older version of that dependency.
[ ] Enable npm shrinkwrap - This will ensure the versions of the packages used on the project are always set regardless of what was released later. Makes for very predictable builds. This will require that occasionally we update the dependencies manially via npm install module@version --save.[-dev]
[ ] Use a dedicated build/dist directory - Keep all our temp files during build and test in one place. Will help keep .gitignore clean.
[ ] Code coverage to output standard coverage format - Use something like lcov. This directly flows into the next point.
[ ] Enable codecov.io integration with github - Using a .codecov.yml file in the root, the gated coverage requirements can be visually seen on each pull request. So a contributor will know immediately and quite clearly if their code passes and if it has enough coverage. Enabling access is something the project owner will have to enable. I can add the config files and other necessary stuff.
[ ] Optimized documentation - Some improvements can be made to make things a bit more clear.
[ ] Switch to gulp instead of grunt - Mostly, with the automated setup of a local dynamodb for testing, it would be good to have that process tear down too. Sadly with grunt that is not so simple. Gulp tends to allow for this sort of flexibility and has a lot more community support.
[ ] Using Istanbul instead of blanket - blanket is inactive and they even recommend using Istanbul instead.

Thoughts?

I agree completely.   The code needs some TLC.  My one request is to use separate PR for each main update.  It makes reviewing and merging a lot easier.
I switched some of my other repos to istanbul and coveralls.io.  However, I think codecov.io is a better option.
I've used both gulp and grunt, but am no expert with either.  So, if gulp works better with dynamodb-local, I'm cool with the change.
On the documentation updates, what were you thinking?  I've wanted to redo the doc for a long time.  I would like to move to using Github Pages in a docs folder using jekyll.  I could setup the basic structure and copy the current readme.  I may also get a nice domain like (dynamoosejs.com) just to make the project look a little more polished.

Throwing my 🎩 into the 💍...
I'm happy to help with the documentation upgrades. I'm a (legacy) member of the Jekyll org and I've been doing Jekyll sites for many years now.

Great, will keep it all as separate PRs.
CodeCov
Just setup the account and give them access to this repo. I'll just need the token for the travis build step to upload the coverage files.
I'll also get Istanbul running.
Documentation
I was thinking about just being more explicit about return types and such. For example it's not clean if Model.get returns a model, plain object or dynamo result. It returns a model which of course is the preferred solution.
@troyswanon I will defer to you on your expertise here as I admittedly do not have the experience to setup documentation well. Would it be more feasible to create a separate dynamoose-documentation repository and populate it with all the .rst files? Then it would look pretty.

To start with on the documentation, I think we can move detailed usage docs into the GitHub Wiki. The README can be cleaned up to be more focused on quickly setting up dynamoose. Once a good structure for the documentation is set up in the Wiki, we can migrate that into a Jekyll site which will be automatically hosted by GitHub for free.
We can move the discussion around the documentation project over to #126.

@troyswanson  -- Thanks, I've got a few Jekyll site but only touch the config ever once in a while.  I seem to have to re-learn it every time.
I agree we'll keep the documenation site updates on #126.

Although these are still good ideas. I'm closing this issue for now. It has been inactive for quite a while. If anyone wants to make PRs for this stuff, I'd be more than happy to review and help get it in.


Disable Sentry for now on Android (cherry-pick from v27.213)

In the rush to get v27.213 out the door as a fix for #5757 — and partly because I was hopeful that the Sentry folks would be finding a fix soon — I made these changes directly on a release branch, rather than on main first and cherry-picking to a release branch.
Here they are for main, along with the changelog entry for v27.213.

Thanks, LGTM! Merged.