Fix ads deadlock and race condition

The LastPush and LastPushFailure are fields in the connection struct.
This is problamatic as there can actually be two pushes to the same
connection at once (if two pushes come in back to back). This means
these connections can interfere with each others timeout detection.
As a fix for this, a mutex was added to part of the usage of this. This
ended up causing a deadlock, blocking all pushes from pilot. The other
usage of the LastPush was not protected by the mutex, and therefor was
still subject to the race condition.
I would like to add some more testing for this, but I am not sure how we reasonably can in automated tests. I manually tested this by triggering many pushes to a few services (this triggers the race condition, as only 20 pushes can happen at once), and then also tested many push to many services (10k XDS cons) which previously triggered the deadlock. I tested both of these with -race enabled as well.
Fixes https://github.com/istio/istio/issues/14611

:thinking: :bug: You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test e2e-simpleTests-master

prow/integ-pilot-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [howardjohn,hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-simpleTests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-simpleTests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test e2e-simpleTests-master

prow/integ-mixer-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

test e2e-simpleTests-master

/test e2e-simpleTests-master

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio-pilot-multicluster-e2e-master

prow/integ-mixer-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e_pilotv2_auth_sds.sh
8358306fe98b4e545d2a28d7b57b061ea407400d
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio_auth_sds_e2e-master

/test integ-pilot-k8s-presubmit-tests-master


challenge2 lucy

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: FranzHelm sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


No e-mail password login possible 2

Netflix add-on version
1.18.7+matrix.1 from repo version 2.0.0
Operative systems used
Android
Kodi version used
Kodi 20 (Nexus)
Description of the bug
Hardware: Nvidia Shield TV 2015
Existing: InputStream Adaptive Version 20.2.2
No e-mail - password login possible in the Netflix addon version 1.18.7+matrix.1 as of the Kodi 20 ( 64 Bit ) Nexus Build
kodi-20220611-a7f66f24-master-23202-arm64-v8a.apk = Not OK
kodi-20220613-daa96893-master-23226-arm64-v8a.apk = Not OK
kodi-20220615-5776c974-master-23254-arm64-v8a.apk = Not OK
but with this build it was still possible without problems
kodi-20220609-26061502-master-23182-arm64-v8a.apk = OK
Steps to reproduce the behavior
No response
Debug log - mandatory
https://paste.kodi.tv/jazapufejo.kodi
Possible fix
No response
Additional context
Is this a similar problem?
https://github.com/CastagnaIT/plugin.video.netflix/issues/1349
Screenshots
No response

thanks will be fixed in next kodi nightlies


Fixed Win32 API forwarding

Changed approach for identifying imported functions: from address-based to import-by-name. We should use original thunk information to access the function names.

Passed regress checks on MSVS 2022 v143 C++17 debug for:

GetCurrentThreadId (mocks bypass)
GetWindowLongPtrA (macro expansion in win32)
GetNumberOfPhysicalMonitorsFromHMONITOR (API forwarding)
RoInitialize (win32 apiSet DLL redirections)

Didn't check: release, clang, msvs2019 and x64

I hope there will be no conflicts with "AppCompat/ShimDLLs" which was removed in this PR #4. By the way, I have already seen forwarding. When user32.lib!_DefWindowProcA is mapped/forward to ntdll.dll!_NtdllDefWindowProc_A. I didn't think we'd get to a solution so quickly.

I've retested it using RoInitialize, and everything works fine. I hope there won't be any problems.

Thanks for this change!


Problem with peer-dependencies [v0.5.0-rc.7]

I am having trouble installing the package because package.json requires a non-existing versions 11 of  @trpc/client and @trpc/server
  "peerDependencies": {
    "@tanstack/vue-query": "^5.22.2",
    "@trpc/client": "11",
    "@trpc/server": "11",
    "vue": "^3.4.19"
  },

Could it be changed to?
  "@trpc/client": "^11.0.0-next || ^11.0.0",
  "@trpc/server": "^11.0.0-next || ^11.0.0",

Thanks :-)

Thank you for bringing this to our attention!
The "11" works only when verifying the version when it is already installed. When fresh installing, it tries to install @trpc/server@11 which does not exist. trpc uses only next as the version tag for release candidates.

Should be fixed in v0.5.0-rc.8


How to read input power......................?

Hai
in my project i want to read the input voltage applied to ble nano  from my battery to display the battery percent.
Have any built in function to read applied voltage...?
THANK YOU

This issue tracker is only for items relating to this library.
I suggest you ask your question here: https://github.com/RedBearLab/nRF51822-Arduino


Document.body is null error

Talked with @sccolbert yesterday, wanted to share something that I ran into.
Error:
Uncaught (in promise) TypeError: Cannot read property 'contains' of null
    at Function.attach (widget.js:893)
    at TodoMVC.Application.attachShell (index.js:314)
    at index.js:273
    at <anonymous>

Source of error thrown:
  export
  function attach(widget: Widget, host: HTMLElement, ref: HTMLElement | null = null): void {
    if (widget.parent) {
      throw new Error('Cannot attach a child widget.');
    }
    if (widget.isAttached || document.body.contains(widget.node)) {
      throw new Error('Widget is already attached.');

Minimum reproducible example:
src/app/index.ts
export class TodoMVC extends Application<Widget> {
  config: {[key: string]: any};

  constructor() {
    super({ shell: new Widget() });
  }
}

src/index.ts
import {TodoMVC} from './application';

let app = new TodoMVC();
app.start();

template/index.html
<!DOCTYPE html>
<html>
    <head>
        <title>Todo MVC App</title>
        <link rel="stylesheet" href="{{ static_url('style.compat.css')}}">
         <script type="text/javascript" src="{{ static_url('bundle.js') }}"></script>
    </head>
    <body>
    </body>
</html>

This error doesn't happen if I set a timeout on app.start() or put the script tag in the body.
Let me know if there is any value to this issue.

Use an onload handler to defer execution of your JS until the page as fully loaded. This is what do in all examples:
https://github.com/phosphorjs/phosphor/blob/master/examples/example-dockpanel/src/index.ts#L400


python311Packages.icalevents: relax deps

Description of changes

The package currently fails to build with:
Checking runtime dependencies for icalevents-0.1.27-py3-none-any.whl
  - datetime<5.0,>=4.3 not satisfied by version 5.4
  - httplib2<0.21.0,>=0.20.4 not satisfied by version 0.22.0
  - icalendar==4.0.9 not satisfied by version 5.0.10
  - pytz<2022.0,>=2021.3 not satisfied by version 2023.3.post1

This change relaxes those dependencies. Related: https://github.com/jazzband/icalevents/issues/123
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281463 run on x86_64-linux 1

3 packages built:

home-assistant-custom-components.waste_collection_schedule
python311Packages.icalevents
python311Packages.icalevents.dist


fix drivers/kbs_keymap.h: return invalid value when api no provided

To address issue #38 related to a usage fault occurring when pressing the left side Shift + Ctrl + Alt in combination with any keys, the problem arises from passing a NULL struct km_api *api parameter to a callback function without prior validation. This leads to the invocation of the callback function by offset from 0, triggering an exception handler.
To resolve this issue, it is essential to implement a check for the NULL condition of the api parameter before invoking the callback function. This precautionary measure ensures that the callback function is only called when a valid pointer is provided. The absence of this check currently results in a usage fault, particularly when the specified key combination is pressed on the left side.
The recommended fix involves incorporating a NULL check for the api parameter within the code. This validation step should precede the invocation of the callback function. By doing so, the code will handle the situation more gracefully, preventing the occurrence of unexpected exceptions or faults.
Please consider incorporating the provided guidance into the codebase to address and resolve issue #38 effectively.

wondering why static analysis tools are not catching this ?

Let us check.


Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
i made a mod in it

addLuaSprite('obj', false)
true for over


Cannot export to PDF - Illegal String

Describe the bug
My new Bookstack server cannot export to PDF, but it can export to HTML
The error message I get is: Illegal string offset 'hex'
Steps To Reproduce
Steps to reproduce the behavior:

Go to page selected.
Click on Export to PDF
See error

Expected behavior
A PDF is downloaded of your page.
Screenshots

Your Configuration (please complete the following information):

Exact BookStack Version (Found in settings): BookStack v0.28.0
PHP Version: 7.2
Hosting Method (Nginx/Apache/Docker):  Apache

Hi @jvarnadore,
This was an issue that was addressed in BookStack v0.28.1. Please could you update to the latest BookStack version and see if the issue persists?


Staking negative income produces errors

When staking ETH it is possible to have a negative income. This can happen when your node is offline for a period. This is the error I see when running rp2_us when "Transaction type" is set to "Staking" and "Crypto in" is negative:
ERROR: Fatal exception occurred:
Traceback (most recent call last):
  File "[path to python]/site-packages/rp2/rp2_main.py", line 151, in _rp2_main_internal
    input_data: InputData = parse_ods(configuration=configuration, asset=asset, input_file_handle=input_file_handle)
  File "[path to python]/site-packages/rp2/ods_parser.py", line 127, in parse_ods
    _create_and_process_transaction(
  File "[path to python]/site-packages/rp2/ods_parser.py", line 166, in _create_and_process_transaction
    transaction: AbstractTransaction = _create_transaction(configuration, current_table_type, internal_id, row_values)
  File "[path to python]/site-packages/rp2/ods_parser.py", line 282, in _create_transaction
    transaction = InTransaction(**argument_pack)
  File "[path to python]/site-packages/rp2/in_transaction.py", line 56, in __init__
    self.__crypto_in: RP2Decimal = configuration.type_check_positive_decimal("crypto_in", crypto_in, non_zero=True)
  File "[path to python]/site-packages/rp2/configuration.py", line 471, in type_check_positive_decimal
    raise RP2ValueError(f"Parameter '{name}' has non-positive value {value}")
rp2.rp2_error.RP2ValueError: Parameter 'crypto_in' has non-positive value -0.03

Would it be possible to cater for such negative values?

Oh, that's interesting (I don't know too much about altcoins, so thanks for educating me): so if you keep your node offline the protocol penalizes you by removing from your stash, rather than adding to it. Is that correct? If so the fix should be fairly easy: this check needs to be changed so that: if type is staking then use type_check_decimal, else use type_check_positive_decimal.

This should be fixed now: see 80b58cb. Let me know if it works.

Oh, that's interesting (I don't know too much about altcoins, so thanks for educating me): so if you keep your node offline the protocol penalizes you by removing from your stash, rather than adding to it. Is that correct? If so the fix should be fairly easy: this check needs to be changed so that if type is staking then use type_check_decimal, else use type_check_positive_decimal.

Yes, that's correct. The stake decreases very gradually when offline.

Oh, that's interesting (I don't know too much about altcoins, so thanks for educating me): so if you keep your node offline the protocol penalizes you by removing from your stash, rather than adding to it. Is that correct? If so the fix should be fairly easy: this check needs to be changed so that if type is staking then use type_check_decimal, else use type_check_positive_decimal.

Yes, that's correct. The stake decreases very gradually when offline.

This should be fixed now: see 80b58cb. Let me know if it works.

Thanks for the quick response on this. I've tried out the fix but it doesn't work. The error message has changed a bit:
ERROR: Fatal exception occurred:
Traceback (most recent call last):
  File "[path to rp2]/rp2/src/rp2/rp2_main.py", line 154, in _rp2_main_internal
    computed_data: ComputedData = compute_tax(configuration=configuration, accounting_engine=accounting_engine, input_data=input_data)
  File "[path to rp2]/rp2/src/rp2/tax_engine.py", line 44, in compute_tax
    unfiltered_gain_loss_set: GainLossSet = _create_unfiltered_gain_and_loss_set(configuration, accounting_engine, input_data, unfiltered_taxable_event_set)
  File "[path to rp2]/rp2/src/rp2/tax_engine.py", line 127, in _create_unfiltered_gain_and_loss_set
    Configuration.type_check_positive_decimal("taxable_event_amount", taxable_event_amount)
  File "[path to rp2]/rp2/src/rp2/configuration.py", line 471, in type_check_positive_decimal
    raise RP2ValueError(f"Parameter '{name}' has non-positive value {value}")
rp2.rp2_error.RP2ValueError: Parameter 'taxable_event_amount' has non-positive value -0.03

That's an error further downstream. It looks like this isn't as straightforward to fix as I originally thought. I need to find some time to dig into this.

I'm working on a proper fix for this: I should have something ready later today.

OK, this should be fixed for good. The way to capture staking losses is to use STAKING-typed Out Transactions. There is a new unit test that shows this: see test_data4.ods, sheet B4. Let me know if this works for you now.

I can now get it running over some staking data containing negative income without producing errors. I wasn't convinced of some of the numbers in the "full_report" ods file so created a simplified input ods file. In case you want to check it out, I've attached it along with the ini config file. The input ods file mocks three days of staking. On each of the first two days 1 ETH is earned (ie two IN rows) and there's one day where 1 ETH is lost (1 OUT row). And the remaining 1 ETH is then sold on Coinbase. In the full report the "Crypto Taxable Total" is equal to 3 ETH. Should it not be 1 ETH? Or perhaps the "IN" staking ETH should be counted separate to the "OUT" staking ETH to give a total for gains and losses respectively.
simple_staking_example.ods
simple_staking_example.ini.txt

The "Crypto Taxable Total" for Staking is 3 because there are 3 Staking-related taxable events, each of which amounts to 1 ETH: two Staking/IN and one Staking/OUT (Staking/OUT is treated like a sale, let me know if you have pointers to documentation that says otherwise). That column simply sums all the taxable events denominated in crypto. Note however that the Capital Gains is only $2000, because only the two Staking/IN transactions generated any gains ($1000 each): the Staking/OUT generated $0 gains because the cost basis and the sale price are the same ($1000). For your taxes you'll need to use Capital Gains.

For tax purposes staking rewards are considered as income in the US as far as I can tell.
https://tokentax.co/blog/crypto-staking-taxes
https://www.irs.gov/pub/irs-drop/rr-23-14.pdf
So net income over a period would be Staking/IN minus Staking/OUT, to which whatever income tax is relevant would apply. Upon sale of staking rewards, capital gains tax would then apply.
In any case, I think I can get what I need from the reports produced now so I think we're good.
And thanks for clarifying so quickly.


ls --dired: replace the previous "total: xx" padding method

@tertsdiepraam you will probably prefer this one :)


Optimizes display performance of the Input render method

https://github.com/erikras/redux-form/issues/123
While implementing a Redux form using Stardust I encountered a
performance bottleneck similar to the ones others are experiencing
in redux-form currently.
This pattern, pulled from the above issue, provides better performance
for forms with Inputs both in Redux and in general.
The most performant solution in the end is to use Immutables,
though that's very heavy-handed and not part of the general use case.

What about adding a shouldComponentUpdate with shallow equality checks on both the props and state to prevent unnecessary renders?

@davezuko that makes way more sense. adjusting...

I tried switching lifecycle methods, and pulled in and performed shallowCompare as suggested in the React Advanced performance docs without any luck.

This should be handled outside of Stardust.  This makes the component controlled by default.  Since props are spread on the input, you can make a controlled component from the outside.


Stop lowering ```'s karma with YAML code snippets

When sending YAML code snippets, "```" take a dive:

This should prevent this from happening.

#6 attempted to fix this but seems not to work (or the change was not deployed?).  I do not know how to to test this unfortunately.

Looks good! I'll clean up the testing tasks a bit too


No way to render different top label for pressed bar in Bar Chart

Firstly, Thanks for providing such a simplistic way to render different charts.
I was using the Bar Chart and needed a different way to show the tapped bar. Though we have focusedBarConfig which I'm making use of but I also want to have the top label to be highlighted whenever user press the bar.
I was able to achieve the same by providing the onPress and topLabelComponent as below since we don't have a way to know the pressed state for top label:
 const [selectedBarIndex, setSelectedBarIndex] = useState<number | null>(null);

 const renderTopLabel = (precipValue: number, i: number) => (
   <Text
     style={{ color: selectedBarIndex === i ? colors.primary : colors.secondary }}
     variant={selectedBarIndex === i ? 'labelExtraSmallProminent' : 'labelExtraSmall'}>
     {precipValue}
   </Text>
 );

const newBardata = useMemo(() => {
   if (data && validTimeData) {
     return data.reduce((newData, currentPrecip, i) => {
       const precipValue = accumulatedPrecip.length
         ? parseFloat(
             (currentPrecip + accumulatedPrecip[accumulatedPrecip.length - 1].value).toFixed(2)
           )
         : parseFloat(currentPrecip.toFixed(2));
       const xAxisLabel = getFormattedDate(validTimeData[i]);
       const chartValue = {
         value: precipValue,
         label: xAxisLabel,
         onPress: () => setSelectedBarIndex(i),
         topLabelComponent: () => renderTopLabel(precipValue, i)
       };
       newData.push(chartValue);
       return newData;
     }, [] as barDataItem[]);
   }
   return [];
 }, [historicalData, selectedBarIndex]);

Could you please confirm if there can be a better way to implement this with the current available props ?
Steps to reproduce
I went through all the props but none seems to be provide a way to render the pressed bar top label different on press.
Snack or a link to a repository
No response
version of react-native-gifted-charts
1.4.31
React Native version
0.72.7
Platforms
iOS
Workflow
None

@Abhinandan-Kushwaha  - Could you please take a look and provide your input ?

Yes Harish, you are doing it the right way. Currently we don’t have a way
to render the top label differently just by using a prop like focusedConfig.
I will try adding this feature in the next release.
On Wed, 6 Nov 2024 at 12:49 PM, Harish Gupta @.***>
wrote:

@Abhinandan-Kushwaha https://github.com/Abhinandan-Kushwaha - Could you
please take a look and provide your input ?
—
Reply to this email directly, view it on GitHub
https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/issues/891#issuecomment-2458878303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5ERUCQMKCCW6YVUZYHVLDZ7G7G7AVCNFSM6AAAAABRDSXD4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYHA3TQMZQGM
.
You are receiving this because you were mentioned.Message ID:
<Abhinandan-Kushwaha/react-native-gifted-charts/issues/891/2458878303@
github.com>

Yes Harish, you are doing it the right way. Currently we don’t have a way to render the top label differently just by using a prop like focusedConfig. I will try adding this feature in the next release.
…
On Wed, 6 Nov 2024 at 12:49 PM, Harish Gupta @.***> wrote: @Abhinandan-Kushwaha https://github.com/Abhinandan-Kushwaha - Could you please take a look and provide your input ? — Reply to this email directly, view it on GitHub <#891 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5ERUCQMKCCW6YVUZYHVLDZ7G7G7AVCNFSM6AAAAABRDSXD4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYHA3TQMZQGM . You are receiving this because you were mentioned.Message ID: <Abhinandan-Kushwaha/react-native-gifted-charts/issues/891/2458878303@ github.com>

Thanks, @Abhinandan-Kushwaha  for the quick response. I am looking forward to the release for this feature.

Hi @Abhinandan-Kushwaha  - I’m considering using a line chart for my project and wanted to check if this design would be feasible to implement with your library. If there are any limitations or features that may not be fully supported, could you kindly point those out? Additionally, I’m hoping to display information outside the chart that updates based on slider or point movement along the line – would this functionality be achievable i.r. do we have any callback for pointer/slider movement which gives the data point?

Thank you so much !!

Yes @harishgupta01 It is possible to display information outside the chart that updates based on slider or point movement along the line.
For this you can use the dynamicLegendComponent prop.


update build to latest duckdb

This is required to build the extension against latest DuckDB version (v0.8.2-dev2278)
Don't forget to do a make pull to retrieve the updated git submodule of DuckDB

Looking good. I'm getting this error when building on Linux.
error: cannot coerce a set to a string

       at /nix/store/caa9n4b3za154sl4lajq870lv7cfcrbq-nixpkgs-with-glibc-2.35-224/lib/strings.nix:160:38:


Mouse interactions don't work when the Terminal window is positioned in the top left of the screen

Windows Terminal version (or Windows build number)
1.11.2421.0, 1.10.2383.0
Other Software
Windows 11 22468.1000
Steps to reproduce
If I move the Windows Terminal window to the top left of the screen, most mouse interactions don't work for a certain area of the terminal.
My screen configuration is a single monitor 2560x1440 @ 144Hz with scale set to 100%.
GPU is GeForce GTX 1060 3GB running NVIDIA driver <IP_ADDRESS>71 (default installed by Windows, not using NVIDIA GFE/GRD/SD).
I saw a bunch of other similar reports, but they were all from users who have PowerToys installed. I do not have PowerToys installed, I have a relatively fresh Windows 11 install besides some standard corporate tools, browsers, drivers (7zip, Adobe Acrobat DC, Company Portal, Datto RMM, Ninja RMM, Chrome, Edge, Logitech Options, Teams, Mimecast Security Agent, Office, Splashtop, Spotify, Telegram, Zoom).
The issue still happens after a fresh reboot and reinstalling both Terminal and Terminal Preview.
Expected Behavior
I expect mouse interactions to work as normal.
Actual Behavior
The buttons in the title (close, new tab, menu, maximise, minimise) do not work. They also do not highlight when I hover over them. I am also unable to select text in the terminal window.  However, clicking and dragging an empty section of the title to move the window still works, as do the resize handles.
There is also a gap around the top of the screen and left of the screen where interactions do work, and if the top left of the window isn't working, the bottom right of the window will still work provided it is outside of the dead zone.
What it feels like is there's an invisible window sitting on top of the terminal blocking any mouse events from getting through to the terminal window (except for moving and resizing). This invisible window / dead zone seems to start at 20px from the top, 10px from the left, and be about 770px wide and 560px high. I can't find any more dead zones.

Weird. Those dimensions make it definitely seem like there's an invisible window there, not one that I'd expect. There's a tool in Visual Studio that can be used for finding windows like that which might be helpful. It's called Spy++. The finder tool can be used to ID windows, even if they're invisible. If you can't install all of VS Community, I'm sure there's some open-source alternatives somewhere.
Could you try using that to find what the window is?


Replace snapshots with specific expect statements

@ghostd Thank you for taking the time to do this! We will give it a review over the weekend.


Update documentReference.fsh

close #213

https://build.fhir.org/ig/IHE/ITI.MHD/branches/JohnMoehrke-patch-1/index.html

reviewed in committee


nvd

Describe the bug
A clear and concise description of what the bug is.
Steps To Reproduce
Steps to reproduce the behavior:

...
...
...

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

Seems to be missing basic info?

Sorry, did I do this? Cancel cancel.


Enable CentOS build test on submitted PRs

This adds the compilation of Vapor on CentOS7 to the tests run on submitted PR's.  With this change, the following checks will be run on CircleCI:

Build on Ubuntu18
Check for warnings on Ubuntu18
Build on CentOS7

@sgpearse the circleci build on centos is not passing.

@clyne - This is because this branch was derived from our current master, which is also failing its builds on CentOS.
However my configuration did not make this clear because I was directing make's output to a file instead of CircleCI's web interface.  The creation of this file is used to scan for warnings, as we do on Ubuntu18.
Since we don't currently have plans to check for warnings on CentOS, I've removed this step in the CentOS build process.  The output for our make command will now display on Circle's build page, so build failures should be easier to see.


[Schedules] Missing Options

When using the schedules UI there is a drift between the options available in the documentation and what is actually there.
For example:
Missing Fixed Start Type

Missing Flood Playout Mode

Using latest image version 0.5.8-beta-docker

You are correct that the documentation is lacking here, will address.
What's happening is that you have Shuffle Schedule Items enabled on the schedule, and the missing options are expected to be missing in this case because they are incompatible with that option. If you disable Shuffle Schedule Items you will be able to pick fixed start times, reorder schedule items and flood schedule items again.


sulu Resourcelocator does not works properly

Q
A

Bug?
yes

New Feature?
no

Sulu Version
developer

Browser Version
All

Actual Behavior
In the admin section when I wanted to add a content in persian (it is a RTL language and works under UTF8-without_BOM ) sulu Resourcelocator  could not be generated and counted the persian title as a empty title it also goes for arabic, hebrew and mandarin Chinese but it works fine and also it does not have a problem for mandarin Chinese; even when I entered the Resourcelocator manually it had counted as empty string and did not let me to publish the form at all.
Expected Behavior
It should add '-' for spaces and cover all languages. ;D
Possible Solutions
I thought it might be the php files encoding but as long as I checked I could not find the problem yet.
Thank you all

could you please paste an example here? i will try it locally to find the issue. maybe the replacers for this language are missing.

you can try for persian or arabic with: تیتر متن and for hebrew with: Εβραϊκή γλώσσα and for mandarin Chinese with 官 話.
Thanks

i have talked to @c00n84 we will generate an empty resource-locator and give the user a message that he should type-in a correct one. /cc @chirimoya should we include that in a HOTFIX?

I think there is a problem in husky.js or something in that area cause the form validator does not validate  these kind of languages as well, to me it seems look like the forms use that for validation; am i right?

i have created a PR which should fix this issue (at least in the backend) https://github.com/sulu/sulu/pull/2400
It will give you empty resource-locators and if you type in a correct one you can save the node normally.

I think it does not make the problem go away; I still have the error with form validation in which it counts the Resourcelocator as an empty field. we need to go to husky.js to solve the problem.

hmm the field is empty yes but the user has to fill in the resource-locator. it cannot be empty when you want to save.

even when I add text manually the validator count it as empty.

it is still red even when I added text

this resource-locator is not valid you have to type in latin letters

ok i know but how can I use internationalizing system to make it work with languages other than latin?
like : %E5%BC%95%E3%81%8D%E5%89%B2%E3%82%8A

I think the problem comes from \vendor\sulu\sulu\src\Sulu\Bundle\ContentBundle\Resources\public\js\validation\types\resourceLocator.js

yes the front-end validation. but we have a deeper problem. our url storage (phpcr) cannot use arababic letters for "nodeName" and thats why we ignore them everywhere

See Internationalized URL  on  http://en.m.wikipedia.org/wiki/Uniform_Resource_Locator it could help

@wachterjohannes Where have you got that information from? I mean that PHPCR cannot use arabic letters? I just created a node named like that:

hmm there were an exception when i tried it from a raw php file ... maybe there was another issue. then maybe another slugifier would be enough. our current one removes this letters. see https://github.com/aferrandini/Urlizer/blob/master/Urlizer.php

Ok something I discovered just now! when I tried to make a sulu-standard with webspace settings like :
<?xml version="1.0" encoding="utf-8"?>
<webspace xmlns="http://schemas.sulu.io/webspace/webspace"
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://schemas.sulu.io/webspace/webspace http://schemas.sulu.io/webspace/webspace-1.0.xsd">

    <name>tcbase.io</name>
    <key>tcbase_io</key>

    <localizations>
        <localization language="fa" default="true"/>
        <localization language="en"/>
    </localizations>

    <theme>
        <key>default</key>
        <default-templates>
            <default-template type="page">default</default-template>
            <default-template type="homepage">overview</default-template>
        </default-templates>

        <error-templates>
            <error-template default="true">ClientWebsiteBundle:views:error.html.twig</error-template>
            <error-template code="404">ClientWebsiteBundle:views:error404.html.twig</error-template>
        </error-templates>
    </theme>

    <navigation>
        <contexts>
            <context key="main">
                <meta>
                    <title lang="fa">Mainnavigation</title>
                    <title lang="en">Mainnavigation</title>
                </meta>
            </context>
        </contexts>
    </navigation>

    <portals>
        <portal>
            <name>tcbase.io</name>
            <key>tcbase_io</key>
            <resource-locator>
                <strategy>tree</strategy>
            </resource-locator>

            <environments>
                <environment type="prod">
                    <urls>
                        <url>{host}/{localization}</url>
                    </urls>
                </environment>
                <environment type="stage">
                    <urls>
                        <url>{host}/{localization}</url>
                    </urls>
                </environment>
                <environment type="dev">
                    <urls>
                        <url>{host}/{localization}</url>
                    </urls>
                </environment>
            </environments>
        </portal>
    </portals>
</webspace>

the content part and the home page part in admin panel do not work due to errors from husky.js
It seems when I did app/console sulu:build prod and app/console sulu:build dev stuff got made in persian from symfony translations (like the homepage name) and husky.js exactly has problem with the  resource-locator part of the page here too. I checked it.

@Kharestani Can you check the path /cmf/tcbase_io/contents with the doctrine:phpcr:shell command, and see if there are any arabic letters? Maybe also post the output in here. AFAIK the generated title of the homepage at the beginning is not translated, so this should not be the issue.
In case you want to dive deeper into husky because of this issue, you should check the husky repository, which also contains the code not being built yet 😉

@Kharestani @danrot is the localization part in the portal not required? And in which languages the meta need to be I only did use backend language their ('en', 'de') not the webspace languages.

@danrot It seems you are right. I run this:
php app/console doctrine:phpcr:shell "node:list /cmf/tcbase_io/contents"
and I got this:
/cmf/tcbase_io/contents [nt:unstructured] > nt:base
+----------------------------+-------------+--------------------------------------+
| jcr:primaryType            | NAME (15)   | nt:unstructured                      |
| jcr:mixinTypes             | NAME (9)    | [0] sulu:home                        |
| jcr:uuid                   | STRING (36) | 5dd4ca1b-7c72-473f-b930-acb44a59af68 |
| i18n:fa-title              | STRING (8)  | Homepage                             |
| i18n:fa-url                | STRING (1)  | /                                    |
| i18n:fa-smartcontent       | STRING (4)  | null                                 |
| i18n:fa-template           | STRING (8)  | overview                             |
| i18n:fa-navContexts        | STRING (0)  |                                      |
| i18n:fa-nodeType           | LONG (1)    | 1                                    |
| i18n:fa-state              | LONG (1)    | 2                                    |
| i18n:fa-published          | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| sulu:order                 | LONG (2)    | 30                                   |
| i18n:fa-created            | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| i18n:fa-changed            | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| i18n:en-seo-title          | STRING (0)  |                                      |
| i18n:en-seo-description    | STRING (0)  |                                      |
| i18n:en-seo-keywords       | STRING (0)  |                                      |
| i18n:en-seo-canonicalUrl   | STRING (0)  |                                      |
| i18n:en-seo-noIndex        | BOOLEAN (0) | false                                |
| i18n:en-seo-noFollow       | BOOLEAN (0) | false                                |
| i18n:en-seo-hideInSitemap  | BOOLEAN (0) | false                                |
| i18n:en-excerpt-categories | STRING (0)  |                                      |
| i18n:en-excerpt-tags       | STRING (0)  |                                      |
| i18n:en-excerpt-icon       | STRING (2)  | []                                   |
| i18n:en-excerpt-images     | STRING (2)  | []                                   |
| i18n:en-title              | STRING (8)  | Homepage                             |
| i18n:en-url                | STRING (1)  | /                                    |
| i18n:en-smartcontent       | STRING (4)  | null                                 |
| i18n:en-template           | STRING (8)  | overview                             |
| i18n:en-navContexts        | STRING (0)  |                                      |
| i18n:en-nodeType           | LONG (1)    | 1                                    |
| i18n:en-state              | LONG (1)    | 2                                    |
| i18n:en-published          | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| i18n:en-created            | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| i18n:en-changed            | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| i18n:de-seo-title          | STRING (0)  |                                      |
| i18n:de-seo-description    | STRING (0)  |                                      |
| i18n:de-seo-keywords       | STRING (0)  |                                      |
| i18n:de-seo-canonicalUrl   | STRING (0)  |                                      |
| i18n:de-seo-noIndex        | BOOLEAN (0) | false                                |
| i18n:de-seo-noFollow       | BOOLEAN (0) | false                                |
| i18n:de-seo-hideInSitemap  | BOOLEAN (0) | false                                |
| i18n:de-excerpt-categories | STRING (0)  |                                      |
| i18n:de-excerpt-tags       | STRING (0)  |                                      |
| i18n:de-excerpt-icon       | STRING (2)  | []                                   |
| i18n:de-excerpt-images     | STRING (2)  | []                                   |
| i18n:de-url                | STRING (1)  | /                                    |
| i18n:de-smartcontent       | STRING (2)  | []                                   |
| i18n:de-template           | STRING (8)  | overview                             |
| i18n:de-navContexts        | STRING (0)  |                                      |
| i18n:de-nodeType           | LONG (1)    | 1                                    |
| i18n:de-state              | LONG (1)    | 2                                    |
| i18n:de-published          | DATE (29)   | 2016-05-20T17:32:50+02:00            |
| i18n:de-created            | DATE (29)   | 2016-05-20T17:03:24+02:00            |
| i18n:de-changed            | DATE (29)   | 2016-05-20T17:32:50+02:00            |
+----------------------------+-------------+--------------------------------------+
1 nodes in set (0.000000 sec)

and there is no i18n:de-title could that be the problem?

@alexander-schranz No, the localizations in the portal are optional. When you omit them, all the localizations of this workspace are taken. But you are right about the meta tags, they should contain translations from the system locales, not from the webspaces ones. This is because these tags are only used in the UI, which is only translated in the system locales.
@Kharestani Yeah, that's interesting... Actually there shouldn't be any properties prefixed with i18n:de-, because de is not a localization in your webspace. Maybe these properties are orphans? Can you try to delete everything (app/console sulu:build dev --destroy, but do that only if you haven't any important data in Sulu, since everything will be lost)?

sorry for the delay.
after I ran app/console sulu:build dev --destroy I tried php app/console doctrine:phpcr:shell "node:list /cmf/tcbase_io/contents" again and for en as default language the result was:
/cmf/tcbase_io/contents [nt:unstructured] > nt:base
+----------------------------+-------------+--------------------------------------+
| jcr:primaryType            | NAME (15)   | nt:unstructured                      |
| jcr:mixinTypes             | NAME (9)    | [0] sulu:home                        |
| jcr:uuid                   | STRING (36) | f0e68b74-dd3b-4475-bd9b-8df8158f3d57 |
| i18n:en-title              | STRING (8)  | Homepage                             |
| i18n:en-url                | STRING (1)  | /                                    |
| i18n:en-smartcontent       | STRING (4)  | null                                 |
| i18n:en-template           | STRING (8)  | overview                             |
| i18n:en-navContexts        | STRING (0)  |                                      |
| i18n:en-nodeType           | LONG (1)    | 1                                    |
| i18n:en-state              | LONG (1)    | 2                                    |
| i18n:en-published          | DATE (29)   | 2016-06-04T19:56:47+02:00            |
| sulu:order                 | LONG (2)    | 30                                   |
| i18n:en-created            | DATE (29)   | 2016-06-04T19:56:47+02:00            |
| i18n:en-changed            | DATE (29)   | 2016-06-04T19:56:47+02:00            |
| i18n:fa-seo-title          | STRING (0)  |                                      |
| i18n:fa-seo-description    | STRING (0)  |                                      |
| i18n:fa-seo-keywords       | STRING (0)  |                                      |
| i18n:fa-seo-canonicalUrl   | STRING (0)  |                                      |
| i18n:fa-seo-noIndex        | BOOLEAN (0) | false                                |
| i18n:fa-seo-noFollow       | BOOLEAN (0) | false                                |
| i18n:fa-seo-hideInSitemap  | BOOLEAN (0) | false                                |
| i18n:fa-excerpt-categories | STRING (0)  |                                      |
| i18n:fa-excerpt-tags       | STRING (0)  |                                      |
| i18n:fa-excerpt-icon       | STRING (2)  | []                                   |
| i18n:fa-excerpt-images     | STRING (2)  | []                                   |
| i18n:fa-title              | STRING (8)  | Homepage                             |
| i18n:fa-url                | STRING (1)  | /                                    |
| i18n:fa-smartcontent       | STRING (4)  | null                                 |
| i18n:fa-template           | STRING (8)  | overview                             |
| i18n:fa-navContexts        | STRING (0)  |                                      |
| i18n:fa-nodeType           | LONG (1)    | 1                                    |
| i18n:fa-state              | LONG (1)    | 2                                    |
| i18n:fa-published          | DATE (29)   | 2016-06-04T19:56:50+02:00            |
| i18n:fa-created            | DATE (29)   | 2016-06-04T19:56:47+02:00            |
| i18n:fa-changed            | DATE (29)   | 2016-06-04T19:56:50+02:00            |
+----------------------------+-------------+--------------------------------------+
1 nodes in set (0.000000 sec)

and for fa as the default language the result was:
+----------------------------+-------------+--------------------------------------+
| jcr:primaryType            | NAME (15)   | nt:unstructured                      |
| jcr:mixinTypes             | NAME (9)    | [0] sulu:home                        |
| jcr:uuid                   | STRING (36) | b3f80bf6-a5c2-4e8e-9b02-62b0f375fd8e |
| i18n:fa-title              | STRING (8)  | Homepage                             |
| i18n:fa-url                | STRING (1)  | /                                    |
| i18n:fa-smartcontent       | STRING (4)  | null                                 |
| i18n:fa-template           | STRING (8)  | overview                             |
| i18n:fa-navContexts        | STRING (0)  |                                      |
| i18n:fa-nodeType           | LONG (1)    | 1                                    |
| i18n:fa-state              | LONG (1)    | 2                                    |
| i18n:fa-published          | DATE (29)   | 2016-06-04T20:04:05+02:00            |
| sulu:order                 | LONG (2)    | 30                                   |
| i18n:fa-created            | DATE (29)   | 2016-06-04T20:04:05+02:00            |
| i18n:fa-changed            | DATE (29)   | 2016-06-04T20:04:05+02:00            |
| i18n:en-seo-title          | STRING (0)  |                                      |
| i18n:en-seo-description    | STRING (0)  |                                      |
| i18n:en-seo-keywords       | STRING (0)  |                                      |
| i18n:en-seo-canonicalUrl   | STRING (0)  |                                      |
| i18n:en-seo-noIndex        | BOOLEAN (0) | false                                |
| i18n:en-seo-noFollow       | BOOLEAN (0) | false                                |
| i18n:en-seo-hideInSitemap  | BOOLEAN (0) | false                                |
| i18n:en-excerpt-categories | STRING (0)  |                                      |
| i18n:en-excerpt-tags       | STRING (0)  |                                      |
| i18n:en-excerpt-icon       | STRING (2)  | []                                   |
| i18n:en-excerpt-images     | STRING (2)  | []                                   |
| i18n:en-title              | STRING (8)  | Homepage                             |
| i18n:en-url                | STRING (1)  | /                                    |
| i18n:en-smartcontent       | STRING (4)  | null                                 |
| i18n:en-template           | STRING (8)  | overview                             |
| i18n:en-navContexts        | STRING (0)  |                                      |
| i18n:en-nodeType           | LONG (1)    | 1                                    |
| i18n:en-state              | LONG (1)    | 2                                    |
| i18n:en-published          | DATE (29)   | 2016-06-04T20:04:05+02:00            |
| i18n:en-created            | DATE (29)   | 2016-06-04T20:04:05+02:00            |
| i18n:en-changed            | DATE (29)   | 2016-06-04T20:04:05+02:00            |
+----------------------------+-------------+--------------------------------------+
1 nodes in set (0.000000 sec)

and when I tried to save a content with Persian Title there was another error from husky but I was able to save a content with english title and persian body.

thats what i have fixed in the linked PR. there you could use persian title, persion content but the resource-locator would have to be english. would that help you? (for the moment)

i have also found a quite good slugify library. https://github.com/cocur/slugify

@wachterjohannes Yes sure, that can solve the problem for now but we should make it right for future.

@danrot what do you think?

Using an external slugifier sounds like a good solution to me. The problem with the linked PR for me is that it names the node after the UUID, and I am not sure if this has some unwanted side effects...

Same problem in article bundle too , sulu don't accept arabic  with some character in url - routePah - and some time not saved in title

@ibnab tbh there was no progress about this topic but last weeks we have discussed it and it will maybe be fixed in 2.0 - its not that easy :)

I have used https://github.com/cocur/slugify by provided the service sulu_document_manager.node_name_slugifier , and is work perfect for arabic , So good idea for small patch before lunching the V2

@ibnab
Please, could you describe your method of replacing the service?

Closing in favour of sulu/sulu#3367, because it is in the correct repository.


TypeError: conn.rollbackAsync is not a function with oracledb

Hi, I am having this issue when attempting to mock a transaction with multiple inserts. I have tried doing what is suggested here https://github.com/jbrumwell/mock-knex/issues/95 however it does not seem to help, I still get the same error.
this is what I am trying to mock
import * as knex from 'knex';

export const pool: any = knex({
    acquireConnectionTimeout: 60000,
    client: 'oracledb',
    connection: {
        connectString: 'zoo',
        password: 'foo',
        user: 'bar',
    },
    debug: true,
    pool: {
        acquireTimeoutMillis: 60000, 10),
        idleTimeoutMillis: 60000,
        max: 10,
        min: 10,
    },
});

    await pool.transaction((trx: any) => {
        return Promise.all([
            row = this.insertOne(trx, id, data),
           this.insertTwo(trx, id, data),
           userData.flag ? this.insertThree(trx, id, data) : {},
           this.insertFour(trx, id, data),
           moreToDo(data),
        ]);
    })
    .catch((err: any) => {
        logger.error(err);
    });

each insert looks something like this:
    return pool('FOOBAR')
            .transacting(trx)
            .withSchema('FOO')
            .insert([
                {
                    FOO: 'BAR',
                    ID: id,
                    CREATE_DT: pool.raw('sysdate'),
                    LAST_MOD_DT: pool.raw('sysdate'),
                },
            ]);
}

this is my mock:
mockKnex.mock(pool);
const tracker = mockKnex.getTracker();
tracker.install();
    tracker.on('query', (query, step) => {
        [
            function firstQuery() {
                    {
                        ID: 1234,
                    },
                ]);
            },
            function secondQuery() {
                query.response([
                    {
                        ID: 1234,
                    },
                ]);
            },
            function thirdQuery() {
                query.response([]);
            },
            function fourthQuery() {
                query.response([]);
            },
            function fifthQuery() {
                query.response([]);
            },
        ][step - 1]();
    });
    const results = await sut.inserts(subject);
    expect(results).toEqual(foo);

This is the error:
TypeError: conn.rollbackAsync is not a function
    at Oracle_Transaction.commit (/home/foo/node_modules/knex/lib/dialects/oracledb/transaction.js:14:18)
    at Function.transactor.commit (/home/foo/node_modules/knex/lib/transaction.js:277:40)
    at /home/foo/node_modules/knex/lib/transaction.js:191:35

Im using
knex 0.21.12
mock-knex 0.4.9

@aggaton this may be an issue with the implementation on our side for Oracle.  We currently only have tests for msyql and postgres.  I'll look into adding tests for the other engines but I don't have a timeline for you at the moment.


Support environment variables in unix file/folder pickers

You may know this dialog window that pops up when you click File > Open Folder ... in any unix context:

It would be great if I could enter things like $MY_PATH_VARIABLE or $MY_PATH_VARIABLE/path/to/file there to open the file or folder which the input resolved with my environment variable MY_PATH_VARIABLE points to.
Here is an example that should work instead of raising an error message:

For comparison, Windows does support this:

The same applies to the folder picker (and probably further widgets I did not discover yet).

Additionally, it would be a nice gimmick to support common bash notation as well:

But this would be probably much more complicated and error-prone :-)

Here are some implementation notes:
Looks as this would be the place to install the mentioned extension: https://github.com/microsoft/vscode/blob/7d4cd4a30b3b48406f742cead944db6470e11a14/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts#L209-L215
I did not find any interesting cross-platform library for resolving paths including environment variables, but this appears not to be very sophisticated:
Windows
path = str.replace(/%([^%]+)%/g, (_,n) => process.env[n]);

Others
path = st.replace(/\$([a-zA-Z_]+[a-zA-Z0-9_]*)/g, (_,n) => process.env[n]);

Problem: How can the user enter a path that actually includes a dollar/percent sign? This would require escaping and increase complexity ...
Another approach could be to pass path to `bash -c "echo ${path}"` (or on Windows, `cmd /c "echo ${path}"`. This would completely outsource the substitution logic to proven tools ...


unbound: fix cross

Since c011c36c003c801a21d60d884128c87710a00c02 unbound is built directly from git checkout. This does not contain flex/bison generated files, so we need both of those in order when cross-compiling. Moving bison from nativeCheckInputs to nativeBuildInputs fixes this problem for cross. For native builds that would have surfaced with doCheck = false.
Context: https://github.com/NixOS/nixpkgs/pull/350185
Sending this to master since the eval is identical.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/NixOS/nixpkgs/pull/364656

Whoops, didn't see that.


help for a given task

I have to be honest, after finding out about dependencyInsight it was kind a pain to understand, but even worse, I don't actually remember how to use it without googling it.
suggested fix, make help work like git help
gradle help dependencyInsight

would print the help for that task, presumably it would find the task via the tasks api, thus you could also run
gradle help :foo:mytask

of course in order for this to work at all you need to add an API for documenting task usage, maybe some kind of cli task ... I'm thinking of an API like ok, during the course of writing this I found picocli... I've never tried it though and now I'm thinking gradle should just switch to using this O.o so should spring boot. so something like this and it would just generate help
tasks.register("myTask") {
    @Option(names = "-c", description = "create a new archive")
    val foo: boolean;
}

You're looking for:
./gradlew help --task dependencyInsight

see https://docs.gradle.org/current/userguide/command_line_interface.html#sec:show_task_details

I would recommend using -q as well in that context so the output focuses on the task help.


Add the hover effect in the Submit button

Hey !!
I have solved the issue no . #326 .
I added the hover effect in the submit button in the contact section , which now looking more beautiful .
As now someone goes to submit the contact form it shows the beautiful hover effect in it .

Thank You !!

@namandude kindly resolve conflicts

Hey Please re review this


2023 Launch

It's almost December again, time to prepare the project for 2023.
Any help would be appreciated, the majority of work involved is user support and marketing.
Launch tasks:

[x] Run rake task to check status of all existing projects (@andrew)
[x] Scale up heroku dynos (@andrew)
[x] Update sendgrid config
[x] Update and send November reminder email
[x] Review current admins and contributors on GitHub (@andrew)
[x] Update sponsors
[x] Update featured projects
[x] Triage existing issues
[x] Setup 24pullrequests account on mastodon (@andrew)
[x] Tweet to direct people to follow on mastodon instead of twitter (@andrew)
[x] Toot to thank each sponsor (@andrew) - https://mastodon.social/@24pullrequests/111489204748184420

Seems like this can be closed?


perf(parser): make not at EOF the hot path in Source methods

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4576  👈
#4575
#4574
#4573
#4572
#4571
#4569
#4568
#4566
#4565
#4564
#4563
#4562
#4561
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Load cufft dll in Windows (CUDA 6.5, 7.0, 7.5 only)

As same as CUDArt.ji(https://github.com/JuliaGPU/CUDArt.jl/blob/master/src/CUDArt.jl#L31), I made a patch to be able to load CUFFT library from windows. It passes tests on Windows 10 64bit and CUDA 7.5.

Thanks!


[BUG] Bad Request while trying to reset password

Issue: Bad Request while trying to reset password.
Browser Details: Firefox 68.12.0esr (64-bit)
Device Details: macOS 10.15.6 (MacBook Pro)
Note: Tried on cloud.
Attachments: https://drive.google.com/drive/folders/14F5yWQpK6A4rA_1hiPifQwUVos-YiRc4?usp=sharing
Steps to replicate :

Hit https://app.appsmith.com/user/login
Click on 'forgot password'
Enter<EMAIL_ADDRESS>in the email field.
Actual Result: Bad Request: Missing request header 'Origin' for method parameter of type String

Expected Result: Message 'It looks like you may have entered incorrect/invalid credentials. Please try again or reset password using the button below.'

Unable to add the label 'above-them'

@mohanarpit seeing different messages for these 2 issues
#637

This error is being thrown by the Spring framework because the client hasn't sent us the mandatory header Origin. Typically, the browser adds this header on it's own for all requests. That's why I'm unable to reproduce this issue on my system.
@Saket2 Is this error consistently showing up for you? Or was it a one-time thing?

@mohanarpit It was consistent. In fact, I reproduced it just now. Here is the thing:
#590 occurs on Firefox (Consistently).
#637 Occurs on Chrome (Consistently).

@prapullac can you repro this on firefox?

@Nikhil-Nandagopal  I am unable to reproduce the issue on firefox. I am displayed with an error " Unable to find user with emailID<EMAIL_ADDRESS>


feat: the doVarietyDemo

Codecov Report
Patch coverage has no change and project coverage change: +0.02 :tada:

Comparison is base (36a31b1) 8.60% compared to head (023f76f) 8.63%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #30      +/-   ##
========================================
+ Coverage   8.60%   8.63%   +0.02%
========================================
  Files          5       5
  Lines        918     915       -3
========================================
  Hits          79      79
+ Misses       837     834       -3
  Partials       2       2

Impacted Files
Coverage Δ

qr_code.go
1.75% <0.00%> (-0.01%)
:arrow_down:

qr_segment.go
14.37% <ø> (ø)

qr_segment_advanced.go
5.10% <0.00%> (+0.10%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: should encode additional target format just once per bundle reconcile

While working on something else, I discovered that if a bundle specifies any additional format in targets, the JKS/PKCS12 is encoded for each and every target configmap/secret. This seems wrong to me, as encoding in these binary trust store formats is a quite heavy operation.
This PR moves the encoding of any additional target formats into buildSourceBundle method - which is executed once per bundle reconciliation. I tried to make this fix/refactoring as minimal as possible to not affect the WIP on https://github.com/cert-manager/trust-manager/pull/235 too much. We could eventually improve this even more in a follow-up PR - especially the tests, which have a lot of duplication at present.

/retest

@aidy - this might be interesting to review.

/test pull-trust-manager-verify

/test pull-trust-manager-verify


Sometimes on scrolling, the header and strip becomes transparent and sometimes on tab change strip becomes transparent !

See the random padding gap in this image.

See the random padding gap in this image.

Sometimes the header becomes transparent and the below scrolled list is visible.

Same issue !
Thanks!

I just bumped on the same issue today. How did you solve it?

Nope 🙀
On Dec 17, 2015 6:59 PM, "dimitrisCBR"<EMAIL_ADDRESS>wrote:

I just bumped on the same issue today. How did you solve it?
—
Reply to this email directly or view it on GitHub
https://github.com/florent37/MaterialViewPager/issues/162#issuecomment-165453218
.

Same issue. Does anyone have a solution?

same issue :/ @florent37  kindly help  :)

Same issue...

+1

+1

@florent37 do you hear us? Please release a new update to fix that bug


missing mmpose/version.py

Hi,
When I installed mmpose in this repo, I found there is no mmpose/version.py file.
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/home/chenshoufa/workspace/HRFormer/pose/setup.py", line 105, in <module>
        version=get_version(),
      File "/home/chenshoufa/workspace/HRFormer/pose/setup.py", line 14, in get_version
        with open(version_file, 'r') as f:
    FileNotFoundError: [Errno 2] No such file or directory: 'mmpose/version.py'

Hey @ShoufaChen were you able to figure this out? I'm stuck at the same issue.

I solved this issue by adding a version.py at  pose/mmpose/version.py  which contains:
__version__ = '0.13.0'
short_version = __version__


Any plan about the 1,920 open issues?

It seems like it's getting out of control.
Do you have a plan of action to review, close and triage all these issues?
VSCode dedicated a full iteration 1 year ago to achieve it:

Welcome to the April 2017 release of Visual Studio Code. For this iteration, we shifted from our usual focus on new features to improving our processes and code base. We reviewed and triaged all our open issues, fixed bugs, and reduced engineering debt.

Do you consider doing something similar for Flow?
Can we help in any way?

It's now reached 2000 :/

You probably could help with identifying obsolete problems and answering questions. This could help a lot.

Considering nobody of the team replied in 1 month I doubt that would make any difference.

I work on TypeScript but check in on this issue tracker from time to time to see what's going on. Caleb responded to someone on Twitter a while back
https://twitter.com/calebmer/status/970281251033686016

They're definitely busy as shown by the commit history - lots of fixes and features going in!

It's true, Flow folks are mostly focused on internal work. If you think, that some issue should be closed or labeled, you can always ping me, and I will do it ASAP. Unfortunately, that's the extent of what I can do.

Thanks a lot @vkurchatkin and @TrySound for taking the time to go through all those issues and closing a bunch.

Another option is to tag support issues here and outright close them with a recommendation to move them somewhere else.


docs: 修改自定义节点链接

G6文档好像迁移到语雀上了，以前的链接被重定向到AntV首页。

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


As a user, I would like to contact the POCs from a Listing's launch notice.

AMLNG-677
Requirement:
Add a way to contact the POCs (app owner/tech poc), possibly through the notification system, since some of these names are obfuscated to the users at times, from a Listing's launch notice.

For this implementation, create a configurable list of users to be notified, rather than using the listing owner/tech POC. Those names can easily have spelling mistakes and are not accessible through the notification system. We'll use the OZP representative's contact information as the users to be notified. For development, we can use our test users: wsmith, bettafish, bigbrother, etc.

Acceptance Criteria:

Give the ability to message the app owners, through notifications, from a Listing's launch notice.

PR submitted.

Merged.


stub the rest of the menu options; update install

Codecov Report

Merging #419 into experimental will decrease coverage by 0.75%.
The diff coverage is 4%.

@@               Coverage Diff                @@
##           experimental     #419      +/-   ##
================================================
- Coverage         71.96%   71.21%   -0.76%
================================================
  Files                30       30
  Lines              1762     1782      +20
================================================
+ Hits               1268     1269       +1
- Misses              494      513      +19

Impacted Files
Coverage Δ

vent/menus/main.py
10.52% <4%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa1b4c...8ff0f30. Read the comment docs.


Provide kubectl

kube-spawn makes it really easy to get and launch local k8s for newbies but users most likely also want to have a kubectl binary to interact with the cluster. Currently AFAIK you are expected to get that yourself and most people would just get it from their distro and that will likely not have all the feature/parameters that the k8s fetched by kube-spawn will have.
So it would be nice if kube-spawn could also get the kubectl for users or at least make it easy to install the latest one.

Isn't kubectl installed in /var/lib/kube-spawn/k8s/kubectl? You could just adjust your PATH to point there.

For me it is in:
/var/lib/kube-spawn/default/rootfs/usr/bin/kubectl

But the path depends on the cluster name...
I think it is fine if users has to get kubectl themselves, but the README has to be updated to explain how to do that.
Example:
curl -Lo /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl
chmod +x /usr/local/bin/kubectl


part_of relation missing from GO basic

part_of relation missing between SNAP receptor and membrane fusion.
https://user-images.githubusercontent.com/7359272/92286477-15eac500-eeff-11ea-9c85-c509f13a23a2.png
https://github.com/pombase/pombase-chado/issues/791

@kltm @dougli1sqrd @balhoff
Can you have a look ? This is weird, I see the relation in protégé, but not in today's snapshot go-basic.obo
Thanks, Pascale

@kimrutherford for info

I think relations that cross GO aspects/namespaces are specifically filtered out of go-basic. There is a Perl script for this: https://github.com/geneontology/go-ontology/blob/af1c8e3e48dec31842814b975209759f10485898/src/util/filter-obo-for-standard-release.pl#L69-L73
This one is a part_of between a MF and a BP.

@ValWood
go-basic does not contain relations that go across aspects, see http://geneontology.org/docs/download-ontology/
I dont think we want to change this.
Thanks, Pascale

Just  so I can explain to Kim - why is that?
We use GO basic, but this means that we will miss inferences.
Should GO basic not be used?
I imagined   GO would want to keep inferences consistent whichever flavour of the ontology is used?
What should GO basic be used for? Does it have a special purpose (if it does not contain inter-ontology relationships it should come with a big disclaimer).
@cmungall

Thinking about it some more we don't need these inter ontology relationships in GO basic.
BUT, the annotations should be generated by GO, and we (POmBase) pick them up and incorporate them into our annotation corpus.
So, we seem to be missing the  annotations to "membrane fusion" that should be inferred via the  inter-ontology link?
So I need to figure out if we are not including these annotations, or if some annotations are not being generated, or if there is a lag.
v

the relation is not new
GO:0005484    SNAP receptor activity
2015-01-12 | Added | RELATION | part of GO:0061025 (membrane fusion)

Are the  MF-BP annotations only generated if there is not an existing annotation?
If so, we may not be seeing these because  there are PAINT annotations and we are not yet importing PAINT.
(we are waiting until  these fixes are through
https://github.com/geneontology/go-annotation/issues?q=is%3Aissue+is%3Aopen+label%3A"PAINT+annotation")

I suspect that might be  the case, if so we can close this ticket now because we will get the inferences soon.

Are the MF-BP annotations only generated if there is not an existing annotation?

I think so. @cmungall @kltm
can you confirm ?

Hi   @cmungall @kltm
can you confirm that  an inferred annotation between MF and BP will only be made if there is no existing annotation? If so I can close this..

Just so I can explain to Kim - why is that?

Historic. There was historically there were lots of tools that baked in assumptions about no inter-ontology links.
I think we should revisit this. We can give people the script.

Hi @cmungall
It's OK for us that the inter ontology links are absent from GO basic, because the annotations are provided so we will get them anyway. I think the only reason we don't have the annotation I was looking at is because we are not importing PAINT right now (we are waiting on some annotation fixes). So, if something has a PAINT (or any annotation from another source)    you don't create an annotation by a MF-BO link, is that correct?

We are now importing PAINT ans still missing these annotation.
I can't figure out why.
13 | membrane fusion (GO:0061025) AND SNAP receptor activity (GO:0005484) [details] | ...
  | 34 | membrane fusion (GO:0061025) | ...
  | 19 | SNAP receptor activity (GO:0005484)
The intersect should be 19 based on the ontology

Based on the ontology, anything annotated to
"SNAP receptor activity"
should get an infered annotation to "membrane fusion"
https://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0005484
Is the inferred annotation from F-P links up and running?

As thought the interontology links were used to make annotations that go in the 'prediction' files, for example for pombase: http://release.geneontology.org/2020-12-08/products/annotations/pombase-prediction.gaf
But I dont see SPCC594.06c (one of the pombase genes annotated with SNAP receptor activity, see http://amigo.geneontology.org/amigo/gene_product/PomBase:SPCC594.06c)
Not sure what's going on
@kltm Do you know how the pipeline handle those ?
Thanks, Pascale

The SNAP receptor activity for SPCC594.06c is ISO. Perhaps the F-P inferences ignores this evidence code? but it should be evidence code agnostic, if the annotation is true, the inference is true whatever the evidence code...

This  old ticket documents some other instances of the same problems.
Quite often  when I expect that we did not need to make a process annotation be3casue it could be inferred, the expected annotation is not in the inferred gaf. This makes it difficult to know whether we need to make the gap filling annotations or not...

This old ticket documents some other instances of the same problems.
Quite often, when I expect that we did not need to make a process annotation because it should be inferred via an F-P link, the expected annotation is missing from the inferred GAF. This makes it difficult to know whether we need to make the gap filling annotations or not...
see also
geneontology/go-annotation#1336
geneontology/go-annotation#1427

Maybe we can set up a call also with @kimrutherford and @balhoff to look at that ? I dont understand where the issue is coming from.

Maybe we can set up a call also with @kimrutherford and @balhoff to look at that ? I dont understand where the issue is coming from.

I don't think it is an ontology issue.   It does not matter that the links are not in GO basic.  I really only want to find out why the F-P inferences I expected are missing.
The question is really  why do the
MF annotations to "SNAP receptor activity" not result in a GOC annotation  to "membrane fusion"
@cmungall  is probably the best person to answer this.  Once I know the reason they are missing  I can figure out  if it a problem with the inference pipeline that will be fixed, or If I need to  fill int he annotation gaps manually. I'm happy to explain the issue on a call sometime  if this does not make sense.
(@cmungall  you only need to consider the comments since 25th Sept - this is where I realise the problem was not what I thought it was originally)

I don't think it is an ontology issue.   It does not matter that the links are not in GO basic.  I really only want to find out why the F-P inferences I expected are missing.
The question is really  why do the
MF annotations to "SNAP receptor activity" not result in a GOC annotation  to "membrane fusion"
@cmungall  is probably the best person to answer this.  Once I know the reason they are missing  I can figure out  if it a problem with the inference pipeline that will be fixed, or If I need to  fill int he annotation gaps manually. I'm happy to explain the issue on a call sometime  if this does not make sense.
(@cmungall  you only need to consider the comments since 25th Sept - this is where I realise the problem was not what I thought it was originally)

I think @dougli1sqrd was working on the script that generated those?

I think @dougli1sqrd was working on the script that generated those?

@pgaudet  want to revisit this tickdet. It is still an issue for us.
I will summarize
There is a MF-BP  part of link between  SNAP receptor activity and membrane fusion:

So, I expected the GO  Predictions would include inferred mapping to "membrane fusion" for all SNAP receptor activity annotations.
However

, you can see that this is not the case:

@cmungall @dougli1sqrd
https://www.pombase.org/results/from/id/cd19d97f-3b4b-43b1-8145-aa10a5803f4b
Note that we import these inferences from GOA.

@cmungall
@pgaudet  understand the issue. We just need to know if the file is correctly generated and if we need to import it separately.
@kimrutherford  do we  expect the  inferred annotations are in GOA, or do we pick up any of these from GO? It might be that we are not getting them because they are not in GOA.
(although we suspect that not all of the annotation expected are generated)

I spoke with @kimrutherford  and we do not get the  inferred annotations from GOA we pick them up from
http://snapshot.geneontology.org/products/annotations/pombase-prediction.gaf
which I believe is the correct file.
This means that there are  missing inferences. I suspect that, because the only inferences for "membrane fusion" are IDA, that maybe the pipeline only generates the inferences for experimental annotation.   If the rule is correct it should presumably be applied to all annotation regardless of evidence code?
One of the reasons that these annotations cause problems for curators is that it is really difficult to identify the source.  Especially as they use the same evidence code as the originating annotation. Curators have complained about this a lot over many years. I would love to see a different evidence code used for MP->BP inferences  (IMF - inferred from molecular function?) so that we know immediately how these were derived.

@pgaudet  Did this ever get looked into?

Hi @ValWood
Chatting with @cmungall @kltm - this code is older, unsupported code that actually needs to be replaced, so we need to prioritize this work with the new code (ontobio) that will be taking care of this. This is underway but needs to be completed.
Relevant tickets:
https://github.com/geneontology/pipeline/issues/221
https://github.com/geneontology/pipeline/issues/130
Sorry about that !
Pascale

What is the situation on this (just checking, but if it will be a  really long time I might make the annotations manually). I opened the ticket in Sept 2020 ;)

Can we discuss on an editors call in the New Year?


Image cuts off early on short/power-less origins

I was trying the website on the vanilla 10 Origins, and I saw that the Human origin just cuts off early. The border doesn't finish properly.
It's a small error though, I don't think it's too urgent to fix, but it's still there so :shrug:

Should be fixed now, thanks for reporting.


form displays briefly before overlay initiates

I was adding a display:none to the form which worked but now when trying the conditional branch,  this fails due to inability to "focus". Removing the display:none form style resolves the issue but the form is displayed for a second before the CF UI overlays.
Thoughts?

seems to be ok when using build files as opposed to dist files.

I added opacity: 0; to the form instead. This seems to be a better solution.


Load files remotely

Explore the posibility to load remote files. This would apply to:

layouts: This allows to define a remote layout: layout: https://example.com/theme/layout.njk
static files: site.copy("https://necolas.github.io/normalize.css/latest/normalize.css", "css/normalize.css")

Implemented in v1.10.0


Docker can't seem to bootstrap an lxd container :(

Required information

Distribution: Ubuntu
Distribution version: 16.04.2 LTS
The output of "lxc info" or if that fails:

config:
  core.https_address: '[::]'
apiextensions:
- id_map
apistatus: stable
apiversion: "1.0"
auth: trusted
public: false
environment:
  addresses:
  - <IP_ADDRESS>:8443
  - <IP_ADDRESS>:8443
  architectures:
  - x86_64
  - i686
  certificate: |
    -----BEGIN CERTIFICATE-----
    MIIFTDCCAzSgAwIBAgIQX/Z+Fo2jEr+0qozyt1mg8TANBgkqhkiG9w0BAQsFADA4
    MRwwGgYDVQQKExNsaW51eGNvbnRhaW5lcnMub3JnMRgwFgYDVQQDDA9yb290QGt1
    YmVybmV0ZXMwHhcNMTcwMjI3MDAwNTI1WhcNMjcwMjI1MDAwNTI1WjA4MRwwGgYD
    VQQKExNsaW51eGNvbnRhaW5lcnMub3JnMRgwFgYDVQQDDA9yb290QGt1YmVybmV0
    ZXMwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQC7wVlLDeeqEPLphNWe
    vdkydp8P9nC2+TmSxYhnuQ4ZF4+SdtzoH4drvf2wR9pevMtgAZGYpY0iwQf/CGvR
    h+1rY4WNxAhiFRME0b9NaulzsF6c6beljt7VlGNEdNtMJGR/2j3xxgGc5CGjkpBa
    wjHy4oZ4C+yvYgEy8QJb5g3KFLfosJWaqsjm/nA0vLDQO6pVdQPvp0URf01+mkX7
    C64bV2XHHPLE2ROhQFPR3ljZUUSULivyW1Ykq+40jCu5UmmPHZY+gcV2bxJ+oWHj
    FO/0CUhFUnRcNQD4wxhCp9G/5Tin9kiznigLIyfiTvXYebGUI4UH2G+MVzGQ+pND
    smwZOJV9TlWLXjqipZ2GzYJ209BnlOj6C7zwFqvmFyXUKukGYJTQB9nIAdEhCGgt
    hIjsuC87Uqf2IphXfrjse1ePQAq35fE00rhCjAS6RfbdouYT1TOvpHyw+iK8ndF1
    Fa5zifCGqLGMXfl7u7s8av/EQEoKLyMhJMGnYqClBo6zTLZEGNL+HO9ILnUW+gJ8
    OsGjQhLpyrh7Jbflktj9v8ZMSjK9NcKJcv2rI4WluF5M57hOYa5IfvFp+Sogd/xO
    hSRe7B7o3QekrUvkiDl5KGIWBXBX1XnnYFfT51e1ZQ0LxuIDx8LvN8dpI0Ag0ATF
    N4G3dwxCqRWLdrA37Gh4cqXTbQIDAQABo1IwUDAOBgNVHQ8BAf8EBAMCBaAwEwYD
    VR0lBAwwCgYIKwYBBQUHAwEwDAYDVR0TAQH/BAIwADAbBgNVHREEFDASggprdWJl
    cm5ldGVzhwQKAAEKMA0GCSqGSIb3DQEBCwUAA4ICAQCw8E5ZamnxpduCiYgkstm6
    xmBUk5oJUHHeFNc47iG4yda4GhSRLoZxoqk1jON10+TTNOz6XK0s7c7tnGCQPQE6
    zWho3rprgIZ3XXU0vPa4FD0Tyc1+rGpDI+4wrG6MZag7yHB/SySFOHQCC734J3iK
    9/dPlhzzF1/nFujKyQ2cxhi7wM30gaJJk9EoywcrAkYKn4wg+hs9PEc/LnjnTEyd
    fUeFj0EsKXo6FN9i8augxLBZAP+jNpby3Lq+47IxFgKCGj1kVYJEhFa+0A48jmRK
    iwnPmfkcAsn0/ZrXaoOQ/QiTUqhSJ6EkL7oXCQylrg5l2SUfQlXqdHtonOCNx/wi
    9KLw+oK2h/l8VIJNW5H1gha+BGy4EkXwH6NtQ1/mgN+HbUvPAFBN7zokTGqGjHpu
    onXf9Vve0a1igZWJIQS/OGjVbQ8krJKt9UfSzCsRKiXZgYW861g2xcbDuMYr8dtm
    p1allkIVR1XKzxQ43OlHjvrp7FLsO7dlql3n9o3eDF7LuLQxKGZR1avvyGqTZdP2
    +F3ijAYvcjvFC7/Z1G7xPkLphwBK0qRbXCrEnTHu3pj/6bJMzgoQKuyIc9PNsE6I
    KWB3kH7ukHPLvj3L9YwOnhlloXbnIkNmMeWwZh2G+KFJX7wxe50eW099AZnms4l+
    PGzXU8+HCGDDbDjJjP36og==
    -----END CERTIFICATE-----
  certificatefingerprint: 21d52c7926e56685fa3c0e31ac0a73ca39092731092e4a41f9116a9fca889fc3
  driver: lxc
  driverversion: 2.0.7
  kernel: Linux
  kernelarchitecture: x86_64
  kernelversion: 4.4.0-64-generic
  server: lxd
  serverpid: 2004
  serverversion: 2.0.9
  storage: dir
  storageversion: ""

Issue description
Docker will not run inside a container when bootstrapped with docker-machine.
Steps to reproduce

$ sudo lxd init
$ lxc launch ubuntu: first-machine
$ docker-machine create --driver generic --generic-ip-address=<ip address of first-machine> --generic-ssh-key ~/.ssh/id_rsa --generic-ssh-user=root first-machine

Information to attach
--output from docker-machine
Error creating machine: Error checking the host: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": read tcp <IP_ADDRESS>:43634
-><IP_ADDRESS>:2376: read: connection reset by peer
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which might stop running containers.

--output from dockerd inside container when run manually
INFO[0000] libcontainerd: new containerd process, pid: 4838
WARN[0000] containerd: low RLIMIT_NOFILE changing to max  current=1024 max=65536
Error starting daemon: error initializing graphdriver: driver not supported

So I don't know docker-machine, but it sounds like it's a tool which will use SSH to enter the container and install Docker inside it. If so, there are a few problems with your setup:

You're not using the "docker" profile for your container. You'd instead want: "lxc launch ubuntu: first-machine -p default -p docker"
It's unclear what version of Docker this would install. If it's installing an upstream build of Docker, then it's very unlikely to work. You instead should use the version of Docker coming from Ubuntu (docker.io package) which includes the needed bits to run inside a LXD container.

So I don't know docker-machine, but it sounds like it's a tool which will use SSH to enter the container and install Docker inside it.

That is correct.  It is a utility that is a part of the Docker suite that allows you to manage various different "docker machines" or VM's that have docker installed.  I believe it works the way you've described.
https://docs.docker.com/machine/

You'd instead want: "lxc launch ubuntu: first-machine -p default -p docker"

Hmm, I'm not sure what that does but I'll certainly look into it.  That might be a work-around for now.  I think I'll lose the functionality of docker-machine but it might be tolerable, at least for now.  The cool thing about docker-machine that I really like is I can just do eval $(docker-machine env <docker machine name>) and it sets the environment such that all docker commands now run in the context of that machine.  Its very, very handy because you're still on your machine and not ssh'd into the docker VM but the docker commands are being run against that VM.

It's unclear what version of Docker this would install. If it's installing an upstream build of Docker, then it's very unlikely to work.

I'm almost positive it would be some upstream version, thus the reason I made the ticket.

You instead should use the version of Docker coming from Ubuntu (docker.io package) which includes the needed bits to run inside a LXD container.

That would most certainly work, but again the problem with that is that you lose the convenience that docker-machine provides :(

Ok, so sounds like this was caused by a mix of a Docker version which doesn't work inside LXD and the LXD container itself missing some configuration.
I'm closing this issue since there's nothing for us to fix at the LXD level.
At the Docker level, we do regularly contribute patches and our goal is absolutely to allow for unpatched upstream docker to work inside LXD. In fact, that was true with the early 1.13 builds but regressed since...


Error while fetching data from database

When a user creates an account the first time then the app crashes while retrieving the name from the database. Include a condition that checks if a name already exists for the user or not in the database

Issue solved by adding an if condition which checks whether the name already exists in the database or not.


not loading after installing from hacs

I get error:
Component error: aqara - Integration 'aqara' not found.

looks like that was the issue, I don't see this error in the logs.
how can I tell its actually working?

You can just look at any  of the configured sensors' state in Developer Tools.  When you move in front of the sensor it will turn on. 5 seconds later it will turn off.
Without the hardware hack, I think, it takes 60 seconds before it will turn on again.
I can highly recommend the hardware hack.

Is this now listed in HACS? I couldn't find it or are we to add a custom repository?

its in hacs under automation section

@ishalem Were you able to test that it's working?  If so, please close the issue.

its in hacs under automation section

Strange, I can't see it and when I try to add a  custom repo I getthe following...
"Repository structure for v1.0.1 is not compliant"
HACS version 1.5.2

after configuring in apps.yaml its working.


Relation extraction for a given sentence

Is there any way to extract relation for a sentence given as an input?
I wanted to write an interface so that I can extract relations as a tuple for a given sentence, any hint?

Hi,
In selector.test function,
https://github.com/ShulinCao/OpenNRE-PyTorch/blob/11bf7ce0aa5ac6ef168e43065722fb3cad2a14b4/networks/selector.py#L63
you can get the score for each relation, than you can get the most possible relation for one sentence and map the index to the relation label.

@ShulinCao thanks so much!


Schema: Cloud Resource

Description
Requesting schema change to add a cloud resource to the existing controller.

Example Plan
terraform {
  required_providers {
    juju = {
      source  = "juju/juju"
      version = "= 0.14.0"
    }
  }
}

provider "juju" {}

resource "juju_cloud" "test_k8s_cloud" {
  name = "my-k8s-cloud"
  kubeconfigfile = "<path/to/kubeconfigfile>"
  cloud = "<parent-cloud-name>"
  region = "<parent-cloud-region>"
}

resource "juju_cloud" "test_cloud" {
  name = "my-cloud"
  clouddefinitionfile = "<path/to/clouddefinitionfile>"
}

Schema
func (o *cloudResource) Schema(_ context.Context, req resource.SchemaRequest, resp *resource.SchemaResponse) {
	resp.Schema = schema.Schema{
		Description: "A resource that represent a Juju Cloud for existing controller.",
		Attributes: map[string]schema.Attribute{
			"name": schema.StringAttribute{
				Description: "The name of the cloud.",
				Required:    true,
				PlanModifiers: []planmodifier.String{
					stringplanmodifier.RequiresReplace(),
				},
			},
			"clouddefinitionfile": schema.StringAttribute{
				Description: "The cloud definition file path for the cloud.",
				Optional: true,
				PlanModifiers: []planmodifier.String{
					stringplanmodifier.RequiresReplace(),
					stringplanmodifier.RequiresReplaceIfConfigured(),
					stringplanmodifier.UseStateForUnknown(),
				},
			},
			"kubeconfigfile": schema.StringAttribute{
				Description: "The kubeconfig file path for the cloud.",
				Optional: true,
				PlanModifiers: []planmodifier.String{
					stringplanmodifier.RequiresReplace(),
					stringplanmodifier.RequiresReplaceIfConfigured(),
					stringplanmodifier.UseStateForUnknown(),
				},
			},
			"cloud": schema.StringAttribute{
				Description: "The cloud name in case adding k8s cluster from existed cloud.",
				Optional: true,
				PlanModifiers: []planmodifier.String{
					stringplanmodifier.RequiresReplace(),
					stringplanmodifier.RequiresReplaceIfConfigured(),
					stringplanmodifier.UseStateForUnknown(),
				},
			},
			"region": schema.StringAttribute{
				Description: "The region name in case adding k8s cluster from existed cloud.",
				Optional: true,
				PlanModifiers: []planmodifier.String{
					stringplanmodifier.RequiresReplace(),
					stringplanmodifier.RequiresReplaceIfConfigured(),
					stringplanmodifier.UseStateForUnknown(),
				},
			},
		},
	}
}

Urgency
Casually wishlisting
Notes & References
No response

Thoughts and questions:

What is the content of the clouddefinitionfile?
I'm not clear on the difference between the name and cloud attributes.
More than the name attribute should be required to create a cloud. There are are some validators like AtLeastOneOf to help here.
No all of these attributes require replacement if changed. Name does. If the cloud hasn't changed, but there is a new endpoint ip address, that is okay and needed to fix an existing config.
We need the controller, client booleans like in cloud credentials. At least 1 needs to be true.
Should we add a cloud data source too?

What is the content of the clouddefinitionfile?

A cloud definition file has the following YAML format:
    clouds:                           # mandatory
      mycloud:                        # <cloud name> argument
        type: openstack               # <cloud type>, see below
        auth-types: [ userpass ]
        regions:
          london:
            endpoint: https://london.mycloud.com:35574/v3.0/

I'm not clear on the difference between the name and cloud attributes.

This is equal terms, in juju facades we use name for VM based clouds, and cloud for k8s-based.  The question is, maybe we should drop cloud and use the name everywhere in the TF plugin.

More than the name attribute should be required to create a cloud. There are are some validators like AtLeastOneOf to help here.

Agreed, I'll add them.

No all of these attributes require replacement if changed. Name does. If the cloud hasn't changed, but there is a new endpoint ip address, that is okay and needed to fix an existing config.

I'll analyze and fix it.

We need the controller, client booleans like in cloud credentials. At least 1 needs to be true.

Q: Do we need client at all? I thought that we are focusing only on --controller case

Should we add a cloud data source too?

What is it?


Cytoscapemossy: Stats table not showing up

When network loads, stats table is missing

Still an issue.


Add CBMC proof for TaskPrioritySet

Description
This PR adds the CBMC memory-safety proof for TaskPrioritySet.
Depends on #774
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closed in favor of https://github.com/aws/amazon-freertos/pull/1325.


[release-1.4] Adding ServiceRoleServicesAnalyzer

This is an automated cherry-pick of #18160

@xeviknal Can you please add consent here?

LGTM @sushicw


fix(pouchdb-size): do not swallow .info errors

Fixes #353

PR merged but with fresh express-pouchdb installation does not includes this fix.
@garethbowen


Bad UX for splitter of description's and code's panels

Describe the bug
It is hard to catch the splitter between panels to drag it. Scrolling controls on the splitter makes a bad user experience if one tries to drag it.

Expected behavior
The separator should be clicked very easy.
Screenshots
Here are screenshots which demonstrate cursor style on top of the scroll controls and on top of the separator.
Note: width of the separator is set to 25px for convenience.

Desktop:

OS: Win7
Browser: Firefox 63

Additional context
The separator can be dragged even if scroll-controls on top of it (FF only). But this is not obviously since user will be looking for resize-cursor style and that style won't appear if the mouse is over scroll-controls. In Opera(v56) this even worse - the separator cannot be dragged with scroll controls.

I think the trade-off of making it easier to hold has been made to make it uniform with the rest of the website and other websites and in favor of not making it so 'ugly'.


update docs

Move MariaDB and Postgres to in development.
Thanks @TimMajerus!

@TimMajerus Yes and add D2 as well. Please send a PR and I will approve it.


[Feature] - End of the Game

The game ends when a player's king piece is in checkmate

duplicate from #22