fix(scheduler): Remove redundant DCHECK in Scheduler

Small fix

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.91%. Comparing base (d30de86) to head (841315c).
Report is 125 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   77.60%   78.91%   +1.30%
==========================================
  Files         103      108       +5
  Lines        7824     8755     +931
==========================================
+ Hits         6072     6909     +837
- Misses       1752     1846      +94

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@BagritsevichStepan you should sign the commit.


Map Marker animation

Hi , I have googled for map marker animations But i didn't found any clear doc for animating the map marker. If i want to show a map marker like water bobble for same place to come on map. Can you help me how to do that.  In the Ios we found pop and push animations. but in android not there any animations to show list of markers.

@shankarpilli Take a look at https://github.com/googlemaps/android-maps-utils/issues/171, and please comment on that thread if it doesn't meet the use case you're looking for.


Missing model.pt File

Recently I wanted to see the representation of R3M model. But it seems that the checkpoints file is missing.
FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/.r3m/r3m_50/model.pt'
How am I supposed to get to this file?

I solved this by manually downloading the ckpt from google drive with gdown. Hope this will work for you.

got it, thank you.


chore: test e2e managed

test e2e managed again..

/ok-to-test-managed sha=61f2ebd provider=aws

/ok-to-test-managed sha=61f2ebd provider=gcp

first successful test runs: gcp (~23min) & aws (~40min)

Awesome!
Eventually we need to add docs for e2e tests. How to run them locally and how to deal with them here.
Right now we don't have individual status of the run on the PR's green/red checks, right?
So we have to wait one run to call the other if it is a change that affects both?

Right now we don't have individual status of the run on the PR's green/red checks, right?

I'm working on that to create the check dynamically from the pipeline - one for current provider that is being tested in the pipeline.

So we have to wait one run to finish to then call the other if it is a change that affects both?

no, they can run in parallel, they don't block each other.

Eventually we need to add docs for e2e tests. How to run them locally and how to deal with them here.

certainly, i'll add them once the above issues are resolved

/approve

/merge


Can't pin tabs by double clicking explorer files

Issue Type: Bug
I used to be able to double click on a file to pin it open, while a single click only temporaly opens the tab
on this build it stop working
VS Code version: Code - Insiders 1.32.0-insider (11416de365a1e96302e171c9eebc2547872ac230, 2019-02-23T08:16:36.706Z)
OS version: Darwin x64 18.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 4, 4

Memory (System)
16.00GB (0.04GB free)

Process Argv
.

 I can reproduce.

@bpasero I can also reproduce. The issue is that the open event I am getting from the list service has pinned: false, even though it is a double click.
I will do some bisecting to find the fault.
fyi @joaomoreno @sandy081

By bisection this was broken by https://github.com/Microsoft/vscode/commit/3946e3233baba153802680044654d605a03ce926
If I revert that commit everything works fine.
Forwarding to @joaomoreno

By bisection this was broken by https://github.com/Microsoft/vscode/commit/3946e3233baba153802680044654d605a03ce926
If I revert that commit everything works fine.
Forwarding to @joaomoreno

thanks for looking into this so quickly

@FernandoMiguel thanks for using insiders and for reproting issues.


[BugFix] Unexpected crash by tricky parameters in TVM's Python API

Background
This is a fixing proposal to Discussion#10988 and https://github.com/apache/tvm/issues/8979 .
Approach
This PR fixed unexpected C++ crash by:

check nullptr before using operator-> (in this case, it must crash);
allow None containers (Array) being capable of range-based for; (otherwise crash);
add specific nullptr checking to other complicated cases (e.g., ICHECK(false) << ... << statement_causing_TVMError will result in crash);

This PR passed test cases contributed in https://github.com/apache/tvm/issues/8979 (the crashes that can be trigger by giving None parameters in TVM's core python APIs)
Comparison with other options
According to the discussion, I also tried other proposals but don't think they are good approaches:
(1) NOTNULLABLE and tvm::runtime::Optional suggested by @junrushao1994 and @Hzfengsy ; -> still requires lots of code changes on legacy codes;
(2) Add checkers for all those .set_body* statements; -> not fundamental that checkers will scale when new interface coming in;
This PR fixed a fundamental issue causing invalid memory access crashes: avoid nullptr objects using -> operator because it must result in program crash; It only requires ~40 lines of edit and very few future engineering (since the fundamental issue is resolved).
Known issue
Statements like ICHECK(false) << ... << statement_causing_TVMError will still crash so that we have to manually add new checkers before it. e.g., line 112 in BlockReadWriteDetector::operator().

I have to agree that failing, even on adversarially constructed cases by a fuzzer, is actual failing. Thanks for pointing this out 😃🙏
On the other hand, I feel this particular change to the object system might be a bit aggressive, given in TVM nullability by default is allowed by design, and enforcing nullptr checks every time might be contradictory with the assumptions in some pre-historic pieces of the codebase (I'm sure there isn't many though).
Just wanted to share some recent efforts on improving nullability related stuff:

This RFC introduces the not-nullable macro TVM_DEFINE_NOTNULLABLE_OBJECT_REF_METHODS. If an ObjectRef type T is marked using this not-nullable macro, then our system will check its nullability to ensure security, unless it is explicitly guarded using Optional<T>; Converting Optional<T> to T incurs nullability checks as well so it's safe;
We have several follow-up PRs that migrates many TVM types to not-nullable, so checks are on by default for those types: #5654, #5717, #5748, #5788;

However, the effort was paused because the support is not perfect for composite TVM objects, i.e. TVM objects that contain other TVM objects, and it's less prioritized task given it only helps with adversarially constructed cases, we haven't seen too much progress on this side.
I am happy to chat more if you are interested! More fundamental contribution is warmly welcome ❤

@junrushao1994 Thanks for the comments.
Yes, they are just some tricky edge cases that users would not intentionally meet in most cases (though it is possible by API misuse). I think they are only useful in some extreme and rare security cases, e.g., some hostile server attack to model servers using tvm.
As you said, a more fundamental and elegant workaround would be applying Optional, though I found it needs to change countless legacy codebase (changing many APIs into Optional<T> and convert them into .value() style). This PR is like a quick fix avoiding most crash issues by such tricky inputs (since the root cause of most issues is that applying data access (->) through nullptr). And it only considers avoiding bad inputs from Python API.
Since the conclusion seems to be clear (I know you guys are busy and such issues are minor and should not be prioritized), I think we can close this PR and simply record this proposal on the channel. Always tyty for the instant reply and patience ❤


chore: merge develop into main

release 5.4

:tada: This PR is included in version 5.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fatal error on build (Deno Adapter)

Hi Guys,
I've an issue using this plugin on build. It's might be compatibility issue with Deno Adapter.
Here is the evidences:
Details:
❯ pnpm run build

><EMAIL_ADDRESS>build /Users/rio/Projects/JS/web/apps/astro-blog
> astro build

11:02:51 PM [build] output target: server
11:02:51 PM [build] deploy adapter: @astrojs/deno
11:02:51 PM [build] Collecting build info...
11:02:51 PM [build] Completed in 280ms.
11:02:51 PM [build] Building server entrypoints...

🌼 daisyUI components 2.33.0  https://github.com/saadeghi/daisyui
  ✔ Including:  base, components, themes[1], utilities

11:02:54 PM [build] Completed in 2.23s.

 building client
Completed in 295ms.

 finalizing server assets

11:02:54 PM [build] Rearranging server assets...
@astrojs/sitemap: Skipped!
No pages found! We can only detect sitemap routes for "static" builds. Since you are using an SSR adapter, we recommend manually listing your sitemap routes using the "customPages" integration option.

Example: `sitemap({ customPages: ['https://example.com/route'] })`

Compressed about.39dc5942.css for 1 Bytes (1.61% reduction).
Compressed about.d36aaeb4.css for 2.36 KB (5.69% reduction).
Compressed blog.0b6c13c9.css for 1 Bytes (0.28% reduction).
Successfully compressed a total of 3 CSS files for 2.37 KB.
Compressed client.8e9befd7.js for 1.1 KB (0.79% reduction).
Compressed entry.mjs for 495.85 KB (50.75% reduction).
Successfully compressed a total of 2 JS files for 496.95 KB.
Compressed favicon.svg for 84 Bytes (9.62% reduction).
Successfully compressed a total of 1 SVG file for 84 Bytes.
✘ [ERROR] Could not resolve "stream"

    dist/server/entry.mjs:73:87825:
      73 │ ...ct.createElement("div")}),t,n,{}),r)throw r;return a}async function getNodeWritable(){let{Writable:e}=await import("stream");return e}async function renderToStaticMarkup$1(e,t,{default:n,...r},a){delete t.class;const o={};for(const[e,t]o...
         ╵                                                                                ~~~~~~~~

  The package "stream" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

 error   Build failed with 1 error:
  dist/server/entry.mjs:73:87825: ERROR: Could not resolve "stream"
  File:
    dist/server/entry.mjs
  Code:
      1623 |   }).join("");
    > 1624 |   let error = new Error(`${text}${summary}`);
           |               ^
      1625 |   error.errors = errors;
      1626 |   error.warnings = warnings;
      1627 |   return error;

  Stacktrace:
Error: Build failed with 1 error:
dist/server/entry.mjs:73:87825: ERROR: Could not resolve "stream"
    at failureErrorWithLog (/Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:1624:15)
    at /Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:1266:28
    at runOnEndCallbacks (/Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:1179:65)
    at buildResponseToResult (/Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:1264:7)
    at /Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:1377:14
    at /Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:678:9
    at handleIncomingPacket (/Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:775:9)
    at Socket.readFromStdout (/Users/rio/Projects/JS/web/node_modules/.pnpm/esbuild@0.14.54/node_modules/esbuild/lib/main.js:644:7)
    at Socket.emit (node:events:527:28)
    at Socket.emit (node:domain:475:12)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

 ELIFECYCLE  Command failed with exit code 1.

Thank you,
:)

Can I take a look at your astro.config.mjs?

Hi @nikolaxhristov @aFuzzyBear , Sorry for late reply. Here is my setup

package.json

{
  "name": "@apps/astro-blog",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "dev": "astro dev --port 3000",
    "start": "astro dev",
    "build": "astro build",
    "preview": "deno run --allow-net --allow-read --allow-env ./dist/server/entry.mjs",
    "astro": "astro"
  },
  "dependencies": {
    "@astrojs/deno": "^1.2.0",
    "@astrojs/mdx": "^0.11.4",
    "@astrojs/prefetch": "^0.0.8",
    "@astrojs/react": "^1.2.0",
    "@astrojs/rss": "^1.0.2",
    "@astrojs/sitemap": "^1.0.0",
    "@astrojs/tailwind": "^2.1.0",
    "@mdx-js/rollup": "^2.1.5",
    "@types/react": "18.0.21",
    "@types/react-dom": "18.0.6",
    "astro": "^1.5.0",
    "astro-compress": "^1.0.12",
    "autoprefixer": "^10.4.12",
    "daisyui": "^2.31.0",
    "postcss": "^8.4.18",
    "react": "^18.0.0",
    "react-dom": "^18.0.0",
    "react-ui": "workspace:*",
    "rollup": "^3.2.1",
    "tailwindcss": "^3.2"
  },
  "devDependencies": {
    "@tailwindcss/aspect-ratio": "^0.4.2",
    "@tailwindcss/container-queries": "^0.1.0",
    "@tailwindcss/forms": "^0.5.3",
    "@tailwindcss/line-clamp": "^0.4.2",
    "@tailwindcss/typography": "^0.5.7"
  }
}

astro.config.mjs

import { defineConfig } from "astro/config";
import mdx from "@astrojs/mdx";
import sitemap from "@astrojs/sitemap";

// https://astro.build/config
import deno from "@astrojs/deno";

// https://astro.build/config
import react from "@astrojs/react";

// https://astro.build/config
import tailwind from "@astrojs/tailwind";

// https://astro.build/config
import prefetch from "@astrojs/prefetch";

// https://astro.build/config
import compress from "astro-compress";

// https://astro.build/config
export default defineConfig({
  site: "https://rio.deno.dev",
  integrations: [mdx(), sitemap(), react(), tailwind(), prefetch(), compress()],
  output: "server",
  adapter: deno()
});

Thank you

Can you try a reproduction of the repo on stackblitz or codesandbox?


Driver Automation Tool Downloads incorrect and creates incorrect version for Lenovo T490

For lenovo T490 and Model Type 20N3 it should create Bios Version 1.61, however it creates it with version 1.08 instead (Model Types : 20RY and 20RX)
1.61 and 1.08 is in the same package so i simply change the Folder name under Package\Lenovo\ThinkPad T490\Bios\1.08 to 1.61
I also need to change the version and content source for corresponding package.
After those changes the correct version get's applied for The T490.
(The same bios package contains both version)
However if I had the earlier bios version 1.08/1.60 downloaded it would not download the 1.08/1.61 bios though I had to delete the old 1.08 package first, then download and then rename as described above.
Also note that the Driver autmation tool logs / says it is model 20N3 so the detection part seems ok, it is the creation part that fails.

I'll check this out for you. There is a significant update being coded in for the next release that should improve the Lenovo matching processes also.


Added support for next version of systemjs-hmr

@capaj Ok to merge?

Maybe better remove yarn.lock? It's pretty big.

@capaj Is it ok if I move forward and merge further pull requests myself?

@alexisvincent yarn.lock is good for apps, this is a library/utility we want to get patches from upstream dependencies. Good thing you removed it. Seems ok to merge.

Technically, the yarn lock only applies to server side code. In this case, the build system. So I would argue that a yarn lock is good. But its out :)


[BUG]

Context
Tried to use new  input/output headers, but it failed

ElasticDump version - 6.69.0
Elasticsearch version - 7.5.2
Node.js version - 16.0.0
Full command:
elasticdump \   --input="https://$INPUT_USER:$INPUT_PASS@localhost:8000/$ES_INDEX" \   --input-headers  "{\"Host\": \"$INPUT_HOST\"}" \   --output="https://$OUTPUT_USER:$OUTPUT_PASS@localhost:8001/$ES_INDEX" \   --output-headers "{\"Host\": \"$OUTPUT_HOST\"}" \   --limit="10000" \

Description
Dump ended with error (get phase) => Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames, same as when not correct he
To Reproduce
2 setups of elastic search
run the command above with substituted values
Current behavior
getting error that provided hostname not as expected, while when using elastic-file/file to elastic with parameter Headers works well
Expected behavior
Expected that process will go with reading 10k records and writing them to another elastic
Error record
Thu, 22 Apr 2021 12:50:01 GMT | starting dump Thu, 22 Apr 2021 12:50:01 GMT | Error Emitted => Hostname/IP does not match certificate's altnames: Host: localhost. is not in the cert's altnames: DNS:*.xxxxx.com, DNS:xxxxx.com Thu, 22 Apr 2021 12:50:01 GMT | Error Emitted => Hostname/IP does not match certificate's altnames: Host: localhost. is not in the cert's altnames: DNS:*.xxxxx.com, DNS:xxxxx.com Thu, 22 Apr 2021 12:50:01 GMT | Total Writes: 0 Thu, 22 Apr 2021 12:50:01 GMT | dump ended with error (get phase) => Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: localhost. is not in the cert's altnames: DNS:*.xxxxx.com, DNS:xxxx.com

Check to ensure that your env_vars are getting resolved. No reason you should have any errors

Added a new release, this will allow input/output headers to be parseable


Several properties don't manage ACCEPT_SINGLE_VALUE_AS_ARRAY

Still marked as "TODO JAVA: @JsonFormat(with = {JsonFormat.Feature.ACCEPT_SINGLE_VALUE_AS_ARRAY, JsonFormat.Feature.WRITE_SINGLE_ELEM_ARRAYS_UNWRAPPED})"

The one in TransferTicket is still to be done.


如何进入手动驾驶模式？

请问如何进入手动驾驶模式，我想通过命令行直接输入控制信息控制车辆，可以实现吗

I assume you want to control the vehicle via commands?
canbus
There is already a tool modules/canbus/tools/teleop.cc, which send control commands directly to the vehicle chassis through the keyboard.
It can meet your requirements, but it is usually used for chassis testing, if you want to use it for testing, pay attention to safety

请问这个工具该怎么使用呢

teleop.cc中的
control_command_.set_reset_model(false);
control_command_.set_driving_mode(Chassis::COMPLETE_MANUAL); 这两个函数在编译时会提示已经不再使用

driving_mode: COMPLETE_AUTO_DRIVE   我现在可以通过teleop发送控制信息 但是canbus的输出里面还是自动驾驶模式 我也无法控制汽车

Normally you can only control the car in autonomous mode. The vehicle does not know whether your command is from the autonomous driving system or from teleop.
Therefore, you need to enter the automatic driving mode first, and then send commands. Some vehicles have requirements for entering automatic driving. You can check


Basic DCAT metadata inside the CSV-W Metadata

The DCAT metadata will hold the publisher/title/etc. of the dataset but won't directly link into the PMD catalogue and won't use any PMD-specific metadata.

The DCAT data is mostly what is stored in the .trig-file; however the contents of this .trig contains PMDCAT components, which we are not planning to use -> use the DCAT components instead. And make sure it is linked to the cube dataset.
There is no component which links dcat and qb together, we will need to define this.


Always pull latest docker image

Any reason why you want to do this? We should really stay with stable version.

I had deployed the default 2.0.0, and the autoscaler was breaking with some error relating to the size of my Azure VM. I spent a couple of hours tracking it down, to new code that was merged (that should have solved my problem), but since this was pointing to old docker image, I was still pointing at old code!
Looking at https://hub.docker.com/r/wbuchwalter/kubernetes-acs-engine-autoscaler/tags/ "latest" is really the only tag containing the code that knows about all Azure VM sizes. I am not sure if "latest" by definition is unstable, I am thinking it means latest stable tagged image. In which case, it makes sense to me. If that is not the case, then maybe @wbuchwalter should tag a new docker image and that should be made the default!

Hello,
latest is unstable indeed. When something is verified and working I tag using SemVer.
The reason this has not been done yet is mainly because I was in vacation for a few weeks with very limited internet access (and still am for a few days).
I will push a new tag when I get back.
Note that PR on this repository also usually take a while to be merged (discussed here https://github.com/kubernetes/charts/issues/1471), so the new chart will be first available here: wbuchwalter/Kubernetes-acs-engine-autoscaler/tree/master/helm-chart

We do not want to default to using latest images. If a user needs to do so, he/she can set it in a values file or on the command line.


CC56643: Update memory.md #62

Hello, @rick-anderson,
This proposed file change comes from https://github.com/aspnet/Docs.ko-kr/pull/62/files?w=1.
Could you review this contribution and help to merge if agreed?
Many thanks in advance.
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

That's incorrect. The https://docs.microsoft.com/aspnet/core needs to be removed from https://docs.microsoft.com/aspnet/core/api/<type>


Minor edits

A couple small things that looked off to me reading the spec.

@notEthan thanks for raising the PR.
Can you target this PR at https://github.com/OAI/Arazzo-Specification/tree/v1.0.0-dev rather than main? We'll be cutting a 1.0.1 release from there.


Order methods when exporting csv

TE: Order methods when exporting csv.
Jira: [CS] AP > Booking > Export CSV file sequence

Specs in local

failed
green

Hi @playerace please help deploy.
Tested this on staging and got a go signal from CS

cc: @jperdiguerra


Add support NUMERIC type for PostgreSQL

Hi
Is there any possibility to add support NUMERIC type for PostgreSQL?
Thank you

Hi @ivan-kuritsyn
I am currently working on a related issue to add Float / Real / Double precision support.
I add this to the next release scope.

Hi @pull-vert !
Thank's so much!

hi @ivan-kuritsyn , NUMERIC and DECIMAL support was released yesterday in Kotysa 2.3.3 for PostgreSQL, H2, MySQL, MariaDB and Microsft SQL Server.


chore(angular-15): update to angular 15

Please read and mark the following check list before creating a pull request (check one with "x"):

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Why haven't you upgraded to Angular 16?


Add toolchain detection for Nix package manager

Related to #16645.
Context
This change adds detection for JDKs installed via the Nix package manager (the Nix package repository contains numerous, see stable and unstable channels).
I've been thinking about implementing this at least since 2021-03-25, and recently there was another request for more liberal detection of JDKs in the Nix forums by @kravemir. Some downsides of this addition were mentioned by @raboof in https://github.com/gradle/gradle/issues/16645#issuecomment-808098771.
Status of this PR
I haven't implemented any tests and also have not changed any documentation yet. This is because I would like to get some feedback by Gradle maintainers because I spend more. In case I get positive feedback on the core changes (which are there already) I will add tests and documentation. I might need help to set up integration tests for this change.
Contributor Checklist

[x] Reviewed Contribution Guidelines.
[x] All commits are signed off to indicate that I agree to the terms of Developer Certificate of Origin.
[x] Code can be distributed under the terms of the Apache License 2.0, and was written by myself.
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
[ ] Provide unit tests (under <subproject>/src/test) to verify logic.
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes.
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck.
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Marking this as draft until I have feedback on https://github.com/NixOS/nixpkgs/pull/312887

Sorry, we don't want to add more built-in options.
I opened a new issue that describes roughly our approach: https://github.com/gradle/gradle/issues/29508
We want a mechanism so 3rd parties can add support for different package manager options and not require changes to Gradle to support them. Eventually, we would remove the existing options.


[Dribblish] Song Queue Button not Displaying Icon

Describe the bug
When using Dribblish the song queue button does not display. The song queue is there and works as expected, but the SVG icon is not displayed. I haven't tried reproducing this with any other themes, but the issue goes away when the Dribblish extension is disabled, even if the Dribblish theme is enabled.
I was able to isolate the issue to this line of code here:
waitForElement([
    ".Root__nav-bar .LayoutResizer__input, .Root__nav-bar .LayoutResizer__resize-bar input"
], ([resizer]) => {
    const observer = new MutationObserver(updateVariable);
    observer.observe(resizer, { attributes: true, attributeFilter: ["value"]});
    function updateVariable() {
        let value = resizer.value;
        if (value < 121) {
            value = 72;
            document.documentElement.classList.add("sidebar-hide-text"); // this line of code
        } else {
            document.documentElement.classList.remove("sidebar-hide-text");
        }
        document.documentElement.style.setProperty(
            "--sidebar-width", value + "px");
    }
    updateVariable();
});

it seems it hides this icon because the filter just hides all "small" svgs?
Edit
Adding this
html.sidebar-hide-text .GlueDropTarget span {
    display: flex;
}

after this rule seems to solve the issue but i'm not sure what other side effects this might have.
On a side note there seems to be an unrelated error that file /images/tracklist-row-song-fallback.svg does not exist (at least on my installation).
To Reproduce
Steps to reproduce the behavior:

install Dribblish as per the instructions in the README

Expected behavior
The song queue icon is displayed.
Screenshots
With dribblish.js loaded

Without

Logs

Specifics (please complete the following information):

OS: Windows 10
Spotify version: Spotify for Windows <IP_ADDRESS>0.g4585142b
Spicetify version: 2.7.0
Theme: Dribblish

i just noticed there are some issues when the side bar is small as possible with the code i originally posted but the more specific rule does not have those issues.

Fixed.


Support SAML logins for Portal for ArcGIS

Right now, Enterprise logins are supported for AGO because AGO-assistant leverages the oauth dialog. For Portal, you can only use built-in accounts or IWA. Ideally, you could switch to a model where oauth is used for both, or where ago-assistant would allow you to log in to a SAML-authenticated Portal.

Do you have a good feel for how this could be implemented? What is the login experience in a Portal with SAML based authentication?

I don't know how from a Javascript/HTML perspective, but here's a Portal with SAML configured so you can see the UI:
https://maps.test.rcview.redcross.org/portal/home/
Right now for that portal, I can only login with a built-in account, not a SAML account.

@ecaldwell I think it would require registering ago-assistant as an oauth application with your Portal, then having a UI in AGO-assistant to use oauth OR the simple generatetoken method it's using now. the AGO login uses oauth, would it be possible to reuse that easily?
I really should start learning javascript I guess.

OK, in that case you should just be able to put the new registered app info in this section. Since it requires modifying the source code, this also means you would have to rehost the app on your own web server.

Would this be fixed by programmatically using a different url in the oauth info object based on user input? Can the appid be negotiated or retrieved based on the portal url?

@nheminger Interesting thought. There's not a good way to search in Portal for a specific registered URL...it would have to search all type: Web Application then inspect each until it found one with the url to the hosted app (i.e. https://ago-assistant.esri.com). Then it could grab and replace the appId and portalUrl in the OAuth object.
Maybe a simple approach would be to allow for a URL parameter in the app. If somebody loads the app with ?portalUrl=<myPortal.domain> then it could trigger the above logic. If it doesn't see that URL parameter, it could just use the default for ArcGIS Online. Think that would work?

Love that idea, @ecaldwell. could also specify portalurl and appid in the url and use that to populate the rest.

@slibby I like that better. Less logic needed in the app.

i just tried testing a SAML enabled Portal and am seeing some funny behavior. with the configuration below the OAuth popup appends two /sharing/ directories in its request to the SAML enabled Portal.

// *** ArcGIS OAuth ***
var appInfo = new arcgisOAuthInfo({
  appId: "Cyn33oUlgf0qLhEf",
  popup: true,
  portalUrl: "https://samlpadfs.ags.esri.com/arcgis/sharing"
});

https://samlpadfs.ags.esri.com/arcgis/sharing/sharing/oauth2/authorize?client_id=Cyn33oUlgf0qLhEf&response_type=token&state={"portalUrl"%3A"https%3A%2F%2Fsamlpadfs.ags.esri.com%2Farcgis%2Fsharing"}&expiration=20160&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fbuild%2Foauth-callback.html
if i remove sharing, i encounter an error in the code before a request is even triggered.
  portalUrl: "https://samlpadfs.ags.esri.com/arcgis"
// ...
// line: 1875
esriId.getCredential(appInfo.portalUrl, {
  oAuthPopupConfirmation: false
})

dojo.js:94 Error: Unknown resource - could not find token service endpoint.(…) "Error: Unknown resource - could not find token service endpoint.

I think this is related to how esriId interprets the appInfo object. My understanding is that it automatically adds /sharing when the url is arcgis.com, but you need to do it manually for Portal.
Try changing this line to esriId.checkSignInStatus(appInfo.portalUrl + '/sharing') and see if it gets any further.

@ecaldwell.  your suggestion, plus manually tacking /arcgis/ back onto the 'portalUrl' referenced in the Portal instantiation in the callback allowed me to sign in and see content.
// my config object from line 28 of main.js
var appInfo = new arcgisOAuthInfo({
   appId: "Cyn33oUlgf0qLhEf",
   popup: true,
   portalUrl: "https://samlpadfs.ags.esri.com/arcgis"
});

/*
the above necessitates that you have created a portal item to register your new application and configured redirect_uris for it to ensure that its considered safe to forward folks back to your app
mine:
http://localhost:8080/index.html,
http://localhost:8080/oauth-callback.html
*/

// further down in main.js...

// hardcoded reference to '/sharing/' added to line 1698
esriId.checkSignInStatus(appInfo.portalUrl + '/sharing/')
  .then(
    function(user) {
    // ..
    app.portals.sourcePortal = new portalSelf.Portal({
        // hardcoded reference to '/arcgis/' added to line 1704
        portalUrl: user.server + "/arcgis/",
        username: user.userId,
        token: user.token
    });

for anyone following along at home, this extra configuration is currently necessary to get ago-assistant using OAuth when users log into their own portal (whether SAML enabled or not) because the production app falls back to making a direct request to fetch a token instead.
:smile:

Working on this end - thanks @jgravois @ecaldwell and @slibby !

thanks for confirming @phoefflernps!  i'm getting ready to try and give @ecaldwell a hand with refactoring the build process.  i'll also be thinking about how to organize a PR so that the production app can support OAuth Portal access without all these hardcoded tweaks.

i finally got ahold of a SAML portal for testing and after pulling down the latest updates and after updating only the config.json, signing in w/ OAuth, i'm not able to login and work with content until after i refresh the page.
// redirect uri is http://localhost:8080
"appId": "0Gbekqt3u9ZLcaXb",
"portalUrl": "https://samlpadfs.ags.esri.com/arcgis"

in the initial login sequence, a request that omits /arcgis/ is made to https://samlpadfs.ags.esri.com/sharing/rest/portals/self?
i noticed an inverse problem when working with NPS (hence my suggestion to update checkSignInStatus), but now, even when calling grunt dev, the code in main.js is too obfuscated to debug happily.

We have two hard-coded local instances of this that date back to September. We'll need to update to a more recent version assuming that we can implement the changes made with help from @jgravois. Right now we're facing a significant challenge of moving content from our old Portal (built-in user accounts) to a new Portal (SAML-based accounts) - to use the Assistant for that purpose the sign on dialog under the copy function needs to support the SAML-based sign on. Thoughts on if that's possible using similar techniques as before? We have a great demand for this and not many alternatives. If this is a separate issue I can open it as such. Thanks!

@phoefflernps are you hoping to upgrade to v2.7.2?
i'd have to blow out some cobwebs, but i should be able to set aside some time in the next couple days to re-digest the notes above and see whether the same changes are necessary to get SAML working in the most recent release.

@jgravois, the newer version would be ideal if we can continue to support SAML-based sign on.
Our more pressing need is to allow users to copy content from a Portal that has only built-in accounts (would not require SAML-based auth for first Portal sign on) to the Portal that is using SAML-based authentication, which means supporting this (hard-coded or otherwise) at the I want to... Copy Content, Another Account dialog box.
We hope to be able to upgrade to the newest version and support the SAML-based authentication in both areas, using as many copies of Assistant as necessary. Thanks for thoughts on the above!

since the latest release has two different sign in dialogs (one for ArcGIS Online and one for Portal) i think that if we configure the ArcGIS Online sign in to point at your own SAML enabled Portal and leave the Portal sign in alone you'll be able to use the context dialog you mentioned to copy items between the two.
does that sound right to you?

Good point - that may cover both of our cases, as long as it works as expected and we can change some labels on the front end. May be a straightforward fix after all, I'll attempt this and report back. I expect the next request will be to copy between Portal and ArcGIS Online (both SAML-enabled), but we can deal with that down the road. Thanks!

May be a straightforward fix after all.

it should be, but give a shout if you get stuck.

we can deal with that down the road.

@slibby was right back in early 2016 and it would still be great to get this app using OAuth exclusively.

i sanity checked this today and the workflow i outlined above (in https://github.com/Esri/ago-assistant/issues/115#issuecomment-249270264) works just as well in version 2.7.2 as it did back then.
the important thing to remember is that the maintainers of this project make downloads of both the raw source for the entire project and the prebuilt website code thats actually ready for deployment each time they tag a release.
this means you have two different options to point ago-assistant v2.7.2 at your own SAML enabled portal instead of ArcGIS Online.
update the built project

download ago-assistant-2.7.2.zip from the v2.7.2 release page.
unzip the folder and open main.min.js
update the appId and portalUrl at the very top of the file.

update the raw source

download Source code (zip) from the v2.7.2 release page.
unzip the folder and cd into it using cmd or terminal
npm install the project dependencies
open config.json and update the appId and portalUrl
run npm run build to concatenate and minify whats currently in /src in a new /build directory.
use a web server to host the contents of the /build/ folder (not the /src/ folder)

Addressed by PR #194.

🎉 :tada::tada:


IOS-9880 - ensure browsing works in offline mode

Verified that @adempsey has signed the CLA. Thanks for the pull request!

@boxtcarpel

We discussed offline about some issues with the completion blocks. As it stands we have some scenarios where completion won't get called at all even if work was completed (perhaps unsuccessfully, but still), and other scenarios where you get multiple calls to the completion block (this may be unexpected and can cause issues as this is new behavior from this change).

@thuyBox @boxtcarpel see revisions

+2!

We spoke offline about the last final renaming change for the completion blocks, so I'll merge this in.


[DNM] Add support GigaDevice GD32V SoC

This PR adds support for GigaDevice GD32V SoC and SiPeed Longan Nano board that is use the SoC.
Currently, the west module dependency points to https://github.com/soburi/hal_nuclei.

Support

GPIO (with EXTI)
UART (UART0 only, pins are fixed)

WIP

Support pinctrl.
Add SPI and other drivers.

Hi @soburi , very happy about you are PR to Zephyr with Nuclei SDK project, our team in Nuclei are also planning to provide zephyr integeration in future, using the Nuclei SDK project is a good choice.
I also see you have made some changes to Nuclei SDK, any extra requrements to be maded to support Zephyr, maybe I can provide some help to see whether the changes can be placed in Nuclei SDK project directly.
Thanks
Huaqi

Reworking the PR to apply the result of the discussion with @carlescufi and @nandojve..

Remove dependency to NMSIS. The required definitions import separately.
ECLIC driver implements without dependency on external modules.

GD32V uses the clock for the machine timer that is obtained by dividing the core clock by 4.
http://www.gd32mcu.com/data/documents/shujushouce/GD32VF103_User_Manual_EN_V1.2.pdf#[{"num"%3A145%2C"gen"%3A0}%2C{"name"%3A"XYZ"}%2C60%2C769%2C0]
This configuration seems to be non-standard.
I wrote a patch to riscv_machine_timer to support this configuration.
And also need to modify tests.
test_nop in tests/kernel/common/src/irq_offload.c is testing 'nop' behavior.
The test measure how much clock cycles nop spends with sys_clock_cycle_get_32.
With this clock configuration, sys_clock_cycle_get_32 will be inaccurate (not cpu clock accuracy).
So I don't think it can test correctly.
I will make skipping this test.
I would like to hear opinions on this point.

Twister tests are all passed excepted that one. (Some are often timeouts, but it became ok in rerun)
./scripts/twister --device-testing --device-serial /dev/ttyUSB1 -p longan_nano --west-flash="--openocd=/usr/local/bin/openocd" --west-runner=openocd -T tests

@soburi could you please rebase this?

Hi, @carlescufi

@soburi could you please rebase this?

I done rebase to include USART interrupt support and pinctrl patches.
Completed the twister test without any errors excepted note in previous comment.

Hi, @carlescufi

@soburi could you please rebase this?

I done rebase to include USART interrupt support and pinctrl patches.
Completed the twister test without any errors excepted note in previous comment.
Currently, skipping the test by 8958f6ab9a8b213cc16f0d1697ae412799debd98 change.
Other notable changes:

Modify Kconfig and CMakeLists.txt

101999286e916f20aed17d08a18ee721f7975063
eebe078a916871896bf8ab43ae292a467cc038a6

Modify RISCV shared implementation

5dcb75b439182ea902accedd313d1f40836396a5
07a7a68bc2633c58587c13398ef8b6532c87e621

Codecov Report

Merging #34970 (5aedcab) into main (1323074) will increase coverage by 0.47%.
The diff coverage is 55.45%.

:exclamation: Current head 5aedcab differs from pull request most recent head 59bbf81. Consider uploading reports for the commit 59bbf81 to get more accurate results

@@            Coverage Diff             @@
##             main   #34970      +/-   ##
==========================================
+ Coverage   50.64%   51.12%   +0.47%
==========================================
  Files         601      604       +3
  Lines       70166    70771     +605
  Branches    16145    16298     +153
==========================================
+ Hits        35536    36182     +646
+ Misses      28880    28640     -240
- Partials     5750     5949     +199

Impacted Files
Coverage Δ

boards/posix/native_posix/timer_model.c
52.17% <0.00%> (+0.72%)
:arrow_up:

drivers/gpio/gpio_emul.c
66.54% <52.17%> (+64.18%)
:arrow_up:

arch/x86/core/x86_mmu.c
81.73% <58.75%> (-4.84%)
:arrow_down:

boards/posix/native_posix/cmdline_common.c
9.80% <100.00%> (ø)

boards/posix/native_posix/hw_models_top.c
86.20% <100.00%> (ø)

subsys/pm/device.c
47.05% <0.00%> (-15.17%)
:arrow_down:

subsys/storage/flash_map/flash_map_integrity.c
48.83% <0.00%> (-11.17%)
:arrow_down:

kernel/mem_domain.c
71.24% <0.00%> (-10.58%)
:arrow_down:

subsys/testsuite/ztest/src/ztest.c
58.70% <0.00%> (-1.81%)
:arrow_down:

subsys/net/ip/ipv6_mld.c
38.62% <0.00%> (-0.27%)
:arrow_down:

... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08b65e...59bbf81. Read the comment docs.

Hi @gmarull, @nandojve

I think that the soc/riscv/riscv-privilege/nuclei/ location should be soc/riscv/riscv-privilege/gigadevice, since you are adding support for a GigaDevice SoC, which turns out to embed a Nuclei RISC-V core (core != SoC). If a lot more SoCs that use this core are added in the future and there is soc/ code that can be re-used, we can likely find the way, maybe soc/riscv/riscv-privilege/common/nuclei can be used for shared code.

I tried some possibilities, and I think the directory move to soc/riscv/riscv-privilege/gd32vf103 is a good way.
gd32vf103 should be under the soc/riscv/riscv-privilege because it is implementing RISCV privilege ISA
SoC configurations placed under soc/riscv/riscv-privilege force to have SOC_FAMILY as riscv-privilege by the conventions under the directory.
So we can't use SOC_FAMILY as the same role in the ARM directory here.
Directory name must be soc/riscv/riscv-privilege/[SOC_SERIES] if under the riscv-privilege directory.
By the way, modules/hal_gigadevice/CMakeLists.txt determines what driver files uses in gigadevice external modules by SOC_SERIES value.
Therefore, I think SOC_SEREIS should be gd32vf103 and as a result, the file should place in soc/riscv/riscv-privilege/gd32vf103.
( I think the "SOC_FAMILY=riscv-privilege" rule makes the situation complexity.
I think it is good to add a hierarchy to determine ISA spec, or handle riscv-privilege as an attribute (such as HAS_PRIVILEGE_ISA), and make able to use SOC_FAMILY for SoC family name.)

Hi @gmarull, @nandojve

I think that the soc/riscv/riscv-privilege/nuclei/ location should be soc/riscv/riscv-privilege/gigadevice, since you are adding support for a GigaDevice SoC, which turns out to embed a Nuclei RISC-V core (core != SoC). If a lot more SoCs that use this core are added in the future and there is soc/ code that can be re-used, we can likely find the way, maybe soc/riscv/riscv-privilege/common/nuclei can be used for shared code.

I tried some possibilities, and I think the directory move to soc/riscv/riscv-privilege/gd32vf103 is a good way. gd32vf103 should be under the soc/riscv/riscv-privilege because it is implementing RISCV privilege ISA
SoC configurations placed under soc/riscv/riscv-privilege force to have SOC_FAMILY as riscv-privilege by the conventions under the directory. So we can't use SOC_FAMILY as the same role in the ARM directory here. Directory name must be soc/riscv/riscv-privilege/[SOC_SERIES] if under the riscv-privilege directory.
By the way, modules/hal_gigadevice/CMakeLists.txt determines what driver files uses in gigadevice external modules by SOC_SERIES value.
Therefore, I think SOC_SEREIS should be gd32vf103 and as a result, the file should place in soc/riscv/riscv-privilege/gd32vf103.
( I think the "SOC_FAMILY=riscv-privilege" rule makes the situation complexity. I think it is good to add a hierarchy to determine ISA spec, or handle riscv-privilege as an attribute (such as HAS_PRIVILEGE_ISA), and make able to use SOC_FAMILY for SoC family name.)

@soburi , @gmarull
What about define at modules/hal_gigadevice below option? This lead us to have more freedom. This help us to have inclusive the soc/riscv/riscv-privilege/gigadevice. We can apply same principle to SOC Kconfig variable. SOC_FAMILY is not important anymore.
config GD32_SOC_SERIES
	string
	default SOC_SERIES if SOC_FAMILY_GD32
	default "gd32vf103" if SOC_SERIES_RISCV_GIGADEVICE_GD32VF103

@nandojve please take another look

@nandojve ,

@soburi , @gmarull
What about define at modules/hal_gigadevice below option? This lead us to have more freedom. This help us to have inclusive the soc/riscv/riscv-privilege/gigadevice. We can apply same principle to SOC Kconfig variable. SOC_FAMILY is not important anymore.
config GD32_SOC_SERIES
	string
	default SOC_SERIES if SOC_FAMILY_GD32
	default "gd32vf103" if SOC_SERIES_RISCV_GIGADEVICE_GD32VF103

Appling this suggestion.
Set SOC_FAMILY='riscv-privilege' and SOC_SERIES='gigadevice' from the folder name convention

dev-review (Dec 2, 2021):

Discussion on SoC dir layout and comparison to how this works for example on Arm.  Suggest from @galak is that we start having a layout similar to arm for risc-v with soc// as expect that the number of risc-v SoCs will only grow.

Suggest from @galak is that we start having a layout similar to arm for risc-v with soc// as expect that the number of risc-v SoCs will only grow.

Hi @galak ,
I can see a direction, which is good. however, it is not clear how this affect this PR.
What are the expectations around this directive that affect this PR?

Hi @nandojve,

HI @soburi,
Not sure why, my board stop print characters. Did you noted something after rebase?

Hmm...
Does flash work?
I don't know it related this problem, recently my openocd environment suddenly broken and reconstruct it.
I verified to run hello_world sample with this PR's source after recover my environments.
(x86_64 PC + Ubuntu20.04 + OpenOCD from sipeed patge https://dl.sipeed.com/shareURL/LONGAN/platformio/dl-packages.
and
RPi4 + Debian-bullseye + locally build OpenOCD https://github.com/GigaDevice-Semiconductor/openocd/)
It seem sources not has significant change in between previously pushed and after rebasing.
The affected file is only the drivers/timer changes, but I don't think this is a problem either.
Thus, zephyr source might be no problem.
So I worry about flash environment problem.

update: rename from dts/bindings/riscv/riscv,nuclei-bumblebee.yaml to dts/bindings/cpu/nuclei,bumblebee.yaml

@gmarull @nandojve could you please take another look?

Hi @soburi ,

Consider adding yourself as a collaborator in MAINTAINERS.yaml.

+1
It will be necessary add some entries to allow add reviewers:
GD32 Platforms:
    status: maintained
    maintainers:
        - nandojve
        - gmarull
+    collaborators:
+       - soburi
    files:
        - boards/arm/gd32*/
+        - /boards/riscv/longan_nano/
        - drivers/*/*gd32*/
        - drivers/*/*gd32*
-        - dts/arm/gigadevice/
+        - dts/*/gigadevice/
        - dts/bindings/*/*gd32*
        - modules/hal_gigadevice/
        - soc/arm/gigadevice/
+        - soc/riscv/riscv-privilege/gd32vf103/
        - scripts/west_commands/*/*gd32*

Thanks for attending the long review.
I found two twister tests failed with this PR.
It is probably the last issue.

tests/subsys/debug/coredump/coredump.logging_backend
This test passed correctly with applying this commit.
I think it is no problem because the test code becomes the same as the hifive1 case.

tests/subsys/cpp/libcxx/cpp.libcxx.newlib
It seems exception handling is not working correctly.
I also verified this did not work correctly with the HIFIVE1 board.
Is there a known problem that exception handling did not work correctly in a non-emulator environment?
Both the M2GL025_MIV board and the HIFIVE1 board use RISCV shared codes only. It may be a common problem with RISCV.
Changes at #40434 excluded M2GL025_MIV from testing.
https://github.com/zephyrproject-rtos/zephyr/pull/40434/files#diff-fd9f9662244d71a39028303cde1a2ed8660cb1bb5b8a052879237f23f1888e54R70
That PR did not describe why excluding the M2GL025_MIV board.
If there is an appliable reason to exclude GD32VF103 (and HIFIVE1), I would like to exclude it from the test.

(If trying to fixing, it may be a bit large problem. I want to discuss in new PR, if so.)

Hi @soburi ,
I dropped 07e4db8 and ran core dump test with success in HW, see below:
*** Booting Zephyr OS build v2.7.99-2334-gd14120d1259d  ***
Coredump: longan_nano
E:
E:  mcause: 3, Breakpoint
E:   mtval: 0
E:      a0: 00000016    t0: 00000080
E:      a1: 00000007    t1: 00000030
E:      a2: 08004704    t2: 00000000
E:      a3: 0800470f    t3: 00000020
E:      a4: 00000000    t4: 00000023
E:      a5: 40013800    t5: 0000002d
E:      a6: 0000000a    t6: 0000002d
E:      a7: 0000002d
E:                      tp: 00000000
E:      ra: 080009d6
E:    mepc: 080009da
E: mstatus: 00001880
E:
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Current thread: 0x200000e0 (main)
E: #CD:BEGIN#
E: #CD:5a4501000400050000000000
E: #CD:4101004800
E: #CD:d609000800000000800000003000000000000000160000000700000004470008
E: #CD:0f47000800000000003801400a0000002d00000020000000230000002d000000
E: #CD:2d000000da090008
E: #CD:4d0100e000002088010020
E: #CD:3002002030020020000000000180000000000000000000000000000000000000
E: #CD:00000000000000000000000000000000f0050020000000000000000000000000
E: #CD:0000000000000000000000000000000000000000000000000000000000000000
E: #CD:000000000000000048010020480100206d61696e000000000000000000000000
E: #CD:0000000000000000000000000000000000000000400200200004000000000000
E: #CD:1253000800000000
E: #CD:4d01004002002040060020
E: #CD:c3aee3fe3141866fd69f35cba53ad1c29d3fe0556028852cfc497e3050ceb58c
E: #CD:4c4b7b9a298ce3f0f59161618e48e4fdba388ac1807bc90d81f992c17837e67b
E: #CD:cb363411b97a3ee647bd021990970ffef325773298f14e86fb67807b9451d62b
E: #CD:a85149cb09bb0fdebf4052925882bb328ed4f815809d859e55e5981c41086653
E: #CD:ddbd6cf7eabaea820c8a57a8402e75f2cdfc815e079239737f24cc7f46a20409
E: #CD:be17ccad8dd1ee738ef87e03e31ccb131ed8716c0180b29da54f82f340d13bfd
E: #CD:903a938754013c647df3a663e8b5cdbbc7dee1a850007849d1340b3c2324e3fc
E: #CD:4c7d70805f8fbeaac9337b2601ecf4ca0b9e2d91604f84becefb809734eb6dd2
E: #CD:4dedbf090c42d898bf1bbb111e88b5217b2f028afc50eebda35e08bd01cddd77
E: #CD:384341be946e967f33c664ce3ed4fd8bee91b02207623d498798b23fbe423fbc
E: #CD:aff308407015de55490797659553b86ce96ba6991d54f33653c388990535bf76
E: #CD:28e073429ef0b1d2d2f902319a9162f7b3720dd00b70ee3da7a517d310828395
E: #CD:c2c63cd739e70e83314513b2f152ba36e2160008a8000020000000000a000000
E: #CD:2d000000d002000830000000bc1b000800000000d001002010020020fe0b0008
E: #CD:14050020fc3100080a000000bc1b0008020a0008470000000a000000780c0008
E: #CD:65f0814fac47000804480008bc1b0008020a00081f00000045000000780c0008
E: #CD:76dfa800ac47000804480008bc1b0008d0010020000000000000000000000000
E: #CD:80000373000000000000000000000000d0010020000000000000000000000000
E: #CD:00000000000000000000000000000000005000083f000000d0010020d0010020
E: #CD:a00100009f040020100200205c0a0008005000083f000000d001002048000000
E: #CD:000000005f050020e8010020a8140008000000000000000000000000f4040020
E: #CD:00000000c0050020e0000020621900080000000045000000d001002010020020
E: #CD:09000000300000000a0000002d000000000000000000000000000000c0050020
E: #CD:00000000000400004002002030180008000000004d0100400200204006002020
E: #CD:00000000c0050020e000002098180008044700085a4501000400050000000000
E: #CD:0000000000000000e0000020e42900088000037345000000ca04002000000000
E: #CD:0000000000000000c0050020a415000800000000c00500200000000008160008
E: #CD:0000000000000000000000000300000000000000000000000000000068020008
E: #CD:d60900080000000080000000300000000000000020000000230000002d000000
E: #CD:2d0000001600000007000000044700080f47000800000000003801400a000000
E: #CD:2d000000da090008801800002d0000002d000000d002000800180000a82a0008
E: #CD:00000000217a36d3edbfb805d80a0008516f7122b8090008801800000f470008
E: #CD:END#
E: Halting system

After that I tried run locally twister for longan_nano and all green:
./scripts/twister -p longan_nano
INFO    - Zephyr version: v2.7.99-2334-gd14120d1259d
INFO    - JOBS: 4
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testcase list...
INFO    - 1557 test scenarios (1474 configurations) selected, 1165 configurations discarded due to filters.
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:  309/ 309  100%  skipped: 1262, failed:    0
INFO    - 212 of 212 test configurations passed (100.00%), 0 failed, 1262 skipped with 0 warnings in 324.98 seconds
INFO    - In total 1438 test cases were executed, 18286 skipped on 1 out of total 410 platforms (0.24%)
INFO    - 0 test configurations executed on platforms, 212 test configurations were only built.
INFO    - Saving reports...
INFO    - Writing xunit report /home/gfbudke/zephyr/mainline/zephyr/twister-out/twister.xml...
INFO    - Writing xunit report /home/gfbudke/zephyr/mainline/zephyr/twister-out/twister_report.xml...
INFO    - Run completed

Hi @nandojve,
Thanks for run the tests.

I dropped 07e4db8 and ran coredump/coredump_backend tests with success in HW, see below coredump:

The failed test is tests/subsys/debug/coredump/coredump.logging_backend.
(NOT tests/subsys/debug/coredump_backend/coredump.backends.logging.
Confusing!)
Could you verify the tests/subsys/debug/coredump test result , please?
coredump test should need to apply my patch to pass the test, I think.
I got the same result of the tests/subsys/debug/coredump_backend test as @nandojve runs.

CXX is working. It was necessary manually enable CONFIG_NEWLIB_LIBC and CONFIG_LIB_CPLUSPLUS
...
START - test_exception
SKIP - test_exception in 0.1 seconds

It seemed the test skipped.
Need to add CONFIG_EXCEPTIONS=y to run this test.
We will get the following result.
The test_exception doesn't respond, so we get a timeout.
*** Booting Zephyr OS build v2.7.99-2333-g55b49a2fb8bc  ***
version 201703
Running test suite libcxx_tests
===================================================================
START - test_array
PASS - test_array in 0.1 seconds
===================================================================
START - test_vector
PASS - test_vector in 0.1 seconds
===================================================================
START - test_make_unique
PASS - test_make_unique in 0.1 seconds
===================================================================
START - test_exception
exit

I've run the device testing with the following command line.
./scripts/twister --device-testing --device-serial /dev/ttyUSB1 -x=OPENOCD=/usr/local/bin/openocd -x=OPENOCD_DEFAULT_PATH=/usr/local/share/openocd -p longan_nano --west-flash=""  --west-runner=openocd -T tests  --test tests/subsys/debug/coredump/coredump.logging_backend --test   tests/subsys/cpp/libcxx/cpp.libcxx.newlib

(openocd path is needed fitting each environment.)

Hi @nandojve,

The acceptance criteria for non integration platforms is build without errors. In this case, gd32vf103 is ok. You are running twister in HW (which is very good) but I think it is not mandatory to move forward.

Thank you for confirmation!
I understood the issues can be fix in future.
I leave it at this time and I will report this problem later.


Please help me to solve this error...

File "h5py_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
File "h5py_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
File "h5py\h5f.pyx", line 85, in h5py.h5f.open
OSError: Unable to open file (unable to open file: name = 'models/pose_model', errno = 13, error message = 'Permission denied', flags = 0, o_flags = 0)
how to get this model within " models/pose_model"

Please have a look at this.


Add Apple M1 Config on spir-v

-Add tuned apple M1 Config for spirv backend

Done! thanks for the comments :)

Nice, thanks @raikonenfnu for adding this!


(dev) cherry-picks from master

Coverage increased (+0.05%) to 78.823% when pulling ce7b4d1b296c1f3ad94c0fd3416ecb2ffa259cfb on rastislavszabo:dev into 4bd68f84bda6590bc0f073c0f0762352e3e1faec on contiv:dev.


Create fuzzing tests for text input

Similar to https://github.com/flutter/flutter/issues/113571
We've definitely had issues in the past around invalid/unexpected values supplied in text input bridge. We should add fuzzing tests.

Sounds useful, that would be text that's inserted via the engine?

My thought here was to have tests that just send arbitrary random data to the channel from the "Framework" side of things - ranging from invalid json to unexpected values/missing values in the JSON - to make sure that it doesn't crash or misbehave.


Add unique modifiers from the config

Currently if modifier is already defined in a third party config, defining the modifier in the main app cause errors. This pull request will make sure that only unique set of modifiers from the config is used.

Thanks!


feat: Mongo Instrumentation (ported from Datadog)

Fixes https://github.com/open-telemetry/opentelemetry-ruby/issues/257
Ready for review

@fbogsany thank you so much for the code review. Would it be possible to consider extending the OpenTelemetry schema to incorporate:
db.mongo.request_id
db.mongo.op_id
db.mongo.n  (or count)

@fbogsany thank you so much for the code review. Would it be possible to consider extending the OpenTelemetry schema to incorporate:
db.mongo.request_id
db.mongo.op_id
db.mongo.n  (or count)

It is possible. Please open a spec issue (or PR) making the case for these.

@ericmustin re: "use of thread local storage", I don't see any other way clean around this besides to use thread storage. The mongo-ruby-driver's instrumentation API gives us separate "start" and "end" callbacks, so we need to store the ID somewhere during the time between. They don't give us the equivalent of an "around (with yield)" callback. The only real alternative would be to hack-in our own monkey patch instrumentation which is ill-advised...

@johnnyshields yup I think thread local is the way to go, I just mean that if we have some existing helpers within the API for managing this we should use those. I don't believe we do though, I think your implementation is good on this front.

@ericmustin @fbogsany I believe I've addressed all comments. Can you please review again?

Let's merge?

@mwear @dazuma please approve

LGTM after the CI failure is fixed.

@fbogsany specs fixed lets merge

Thanks @johnnyshields. This needs a rebase before I can merge. I don't have permissions to rebase - can you please do that?

Merged in master

Ready to merge

Thanks @johnnyshields


UI issue in Moto E

The Camera surface is not occupying full screen even though the width attribute is match parent. It is restricted to half of the screen.But this is only happening on MOTO E device.

![screenshot]
(https://cloud.githubusercontent.com/assets/14054850/14119361/6d07a8c2-f60b-11e5-9b8f-83adec868cae.png)

I have the same issue on my Nexus 6, there is a white area on the right side (not as big as in the screenshot above) in portrait. In landscape it is still there but just like 5pixels.

See the solution that I posted for issue:  https://github.com/googlesamples/android-vision/issues/23

I see - this helped. Thanks a lot.


Connecting to doltgres from R Postgres client fails because of no "SET datestyle"

In attempting to get a "Hello, World" working from R, I run doltgres from bash, then in R I run:
library(DBI)
library(RPostgres)

con <- dbConnect(RPostgres::Postgres(), host = "localhost", port = 5432, user = "doltgres", dbname = "doltgres")

I get the following error in R:
Error: Failed to fetch row : ERROR:  column "datestyle" could not be found in any table in scope (errno 1105) (sqlstate HY000)

In the doltgres log I get the same error as a WARN. I get the same error in psql, but it is not a fatal connection error.
This is because the R Postgres client, by default, runs SET datestyle to 'iso, mdy' on connection to standardize the date-time values returned across different Postgres versions, and within R not getting a response is an error (See https://github.com/r-dbi/RPostgres/issues/287 and https://github.com/r-dbi/RPostgres/blob/6d785a2bad98fd3663668fc39f38bbf1677fa1c1/R/dbConnect_PqDriver.R#L93).

We don't yet support setting any system parameters in DoltgreSQL. We have a few other features to work through first before we tackle this one, but we appreciate the issue! We'll get to it as soon as we can.

Update:
SET datestyle now works, but it does not update the value yet.
The next support needed to connect from R is current_schema() function, used as SELECT current_schema().

This should work now in 0.11.1. Let us know if you come across anything else!


vite.config.ts support?

I use a vite.config.ts file, but currently getting this error in vscode

The error seems to be related to the .ts extension. This plugin doesn’t handle extensions, it only resolves the alias. Please check your ESLint configuration.


analysisID not found

i was in my analysis (as guest), clicked on veupath icon (idea to log in) then i remembered i could login from wihin eda, hit teh back button and got analysis not found .
i was a diff guest user

sorry this belongs in the service...

This was due to the eda service issuing a set-cookie header that conflicted with the wdk service, which results in the browser being assigned a new guest user.


EasyCLA GitLab: after docu-signed MR remains uncovered in the ICLA flow

Summary
EasyCLA GitLab: after docu signed MR remains uncovered in the ICLA flow
Background

Create a new GitLab branch
Create new MR(cla gated)
Click on the Not Covered button
proceed as 'Individual Contributor'
Fill document & finish it
Add /esycla comment on MR

Actual behavior
EasyCLA GitLab: after docu signed MR remains uncovered in the ICLA flow
Screenshots

@thakurveerendras kindly verify this

@nickmango , Issue is still reproducible as reported on dev site
Refer the MR: https://gitlab.com/gitlabcommenttest/repo/-/merge_requests/14

@nickmango please review this fix.

Issue is not reproducible as reported, Now status is properly updated after docusigned

Tested on prod & it is working fine. So closing this ticket
Refer PR: https://gitlab.com/feb15prod/repo01/-/merge_requests/1#notes


Type coercion for profiles.yml fields

via @cabouffard (originally opened here)
Hey,
I’m hitting some kind of unexpected errors. I want the thread value of my profiles.yml file to be configurable via ENV variables, such as I can do the following:
default:
  outputs:
    dev:
      type: redshift
      threads: "{{ env_var('DEV_DBT_THREADS') }}" # [1-8]
      host: "{{ env_var('DEV_WAREHOUSE_DB_HOST') }}"
      port: "{{ env_var('DEV_WAREHOUSE_DB_PORT') }}"
      user: "{{ env_var('DEV_WAREHOUSE_DB_USER') }}"
      pass: "{{ env_var('DEV_WAREHOUSE_DB_PASSWORD') }}"
      dbname: "{{ env_var('DEV_WAREHOUSE_DB_NAME') }}"
      schema: "{{ env_var('DEV_DBT_SCHEMA_OUTPUT') }}"
    staging:
      type: redshift
      threads: "{{ env_var('STAGING_DBT_THREADS') }}" # [1-8]
      host: "{{ env_var('STAGING_WAREHOUSE_DB_HOST') }}"
      port: "{{ env_var('STAGING_WAREHOUSE_DB_PORT') }}"
      user: "{{ env_var('STAGING_WAREHOUSE_DB_USER') }}"
      pass: "{{ env_var('STAGING_WAREHOUSE_DB_PASSWORD') }}"
      dbname: "{{ env_var('STAGING_WAREHOUSE_DB_NAME') }}"
      schema: "{{ env_var('STAGING_DBT_SCHEMA_OUTPUT') }}"
    production:
      type: redshift
      threads: "{{ env_var('PRODUCTION_DBT_THREADS') }}" # [1-8]
      host: "{{ env_var('PRODUCTION_WAREHOUSE_DB_HOST') }}"
      port: "{{ env_var('PRODUCTION_WAREHOUSE_DB_PORT') }}"
      user: "{{ env_var('PRODUCTION_WAREHOUSE_DB_USER') }}"
      pass: "{{ env_var('PRODUCTION_WAREHOUSE_DB_PASSWORD') }}"
      dbname: "{{ env_var('PRODUCTION_WAREHOUSE_DB_NAME') }}"
      schema: "{{ env_var('PRODUCTION_DBT_SCHEMA_OUTPUT') }}"
  target: "{{ env_var('DBT_TARGET') }}"

Unfortunately, when building the docs I’m raised with the following error:
pipeline-dbt-docs | Encountered an error while reading profiles:
pipeline-dbt-docs |   ERROR Runtime Error
pipeline-dbt-docs |   Runtime Error
pipeline-dbt-docs |     Invalid arguments passed to "ProfileConfig" instance: threads.'4' is not of type 'number'
pipeline-dbt-docs | Defined profiles:
pipeline-dbt-docs |  - default

I dug a little bit, and saw that env_var was a macro defined by this that uses os.environ. In this context, os.environ will always return a string.
I then dug into how the validation was being done and found this which expects the value to be a number.
I'm unsure how to properly resolve that other than currently hard-coding a value to something.
I wanted to flag and document this error as this seems to be something that should be fixed.
Thanks!

I'm running into this as well, because I want to be able to run by DBT models in a CI process, but the database server which is started is on a random port (since multiple builds could be running at once).
Any thoughts on how to handle this?  (a command line switch I'm not seeing, etc)

Ah, I see that port has actually been sorted:
https://github.com/fishtown-analytics/dbt/blob/aa0e58ef3bbc863c880b7f5b0a316433e65e87ac/core/dbt/config/renderer.py#L65-L73
My specific failure ended up being related to threads because it also has to be an integer.

closing this via the native env jinja rendering in 0.17.0

@drewbanin this problem has hit me after upgrading to 0.17.2 (from 0.17.0).
I had to cast the port to int like this:
      port: "{{ env_var('PGPORT') | int }}"

Is it expected that the port from env_var still has to be casted to int? If yes, I think it would be great if it was mentioned in the documentation.

That's correct, based on changes we made in 0.17.1 to native-env rendering. If you're setting port to an environment variable, you need to filter it | int or | as_number.
I agree that it would be good to add a note about this to the env_var docs. Would you be up to propose that change?

@jtcohen6 This has bitten us several times and just now found this issue. Added to the doc for better visibility.
https://github.com/dbt-labs/docs.getdbt.com/pull/2156


Design Scrollbars customization

In the current implementation in 1.4.0 version, Scrollbar thumbs are customized only by using data class ScrollbarStyle that allows simple customization of the thumb. But for e.g. IntelliJ theming more customization is needed (for example, border on Windows/Linux).
So we need to design API that allows customizing a scrollbar thumb and probably scrollbar track

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Reduce timeout for nodesDown and noNodeDown in cd

When there are issues preventing progress in cd, 30 minutes is too long
to wait for the errors to show up, trying with 20 minutes. Hard to know the right number, but we should rather increase it again if there is any issue.

@jonmv FYI


Follow-up of 29826 Use default driver for IPAM if none

Follow up for #29826 in master this time

We use the 'default' driver if none is specified.
Fix #29809
Fix #28528
/cc @dnephin @icecrime @thaJeztah @mavenugo @vieux
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

moved to the 1.13.1 milestone to make clear this was included in 1.13.1 (through https://github.com/docker/docker/pull/29826)


[VL] enable 11-22 upstreaming velox rebase

What changes were proposed in this pull request?

Make some modifications in Gluten by incorporating the BridgeOptions parameter for updating the Arrow conversion API in https://github.com/facebookincubator/velox/pull/7625
https://github.com/facebookincubator/velox/pull/6725 upgrades DuckDB to version 0.8.1, requiring changes in Gluten to update its dependency on DuckDB as well.

How was this patch tested?
Existing UTs.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3773_time.csv
log/native_master_11_26_2023_f456a7e86_time.csv
difference
percentage

q1
34.44
34.38
-0.063
99.82%

q2
24.96
24.62
-0.332
98.67%

q3
37.93
37.74
-0.189
99.50%

q4
35.92
36.67
0.752
102.09%

q5
72.02
68.82
-3.200
95.56%

q6
7.33
7.12
-0.209
97.15%

q7
83.60
82.01
-1.584
98.11%

q8
86.97
87.72
0.755
100.87%

q9
126.75
120.79
-5.960
95.30%

q10
47.28
44.22
-3.061
93.53%

q11
21.24
19.96
-1.288
93.94%

q12
25.82
28.56
2.737
110.60%

q13
46.24
46.61
0.368
100.80%

q14
18.58
14.35
-4.234
77.21%

q15
27.20
29.15
1.953
107.18%

q16
16.59
15.41
-1.182
92.87%

q17
103.07
100.98
-2.090
97.97%

q18
152.18
145.61
-6.577
95.68%

q19
12.96
12.88
-0.079
99.39%

q20
28.57
27.79
-0.779
97.27%

q21
224.28
223.56
-0.720
99.68%

q22
13.18
13.03
-0.143
98.91%

total
1247.11
1221.98
-25.126
97.99%


New test suite

Probably mocha.

[x] Test runner
[x] Parser tests
[x] Import statement tests
[x] Reporter tests
[ ] Test cases / fixtures for reported bugs

I think what the remaining checkbox equates to is to add test cases for the remaining open issues that relate to the v3 parser.
These should be added as CSS files in /spec/fixtures/input and /spec/fixtures/output/parser.

My intention with the remaining checkbox was essentially to make sure the following issues were addressed:

[ ] #10
[ ] #15
[ ] #23
[ ] #24
[ ] #38
[ ] #52


makefile: update scripts

What have you changed?
It's wrong to check all binaries in target directory: some of them are not generated by current build; some of actual running tests are put into the child directory of target directory. So this PR rewrite the check scripts to make test precise:

Check built binaries instead of arbitrary by filtering tests output
Use python for readability
Use readelf to speed up the check
Check jemalloc for dist_release

What is the type of the changes?

Engineering

How is the PR tested?

Manual test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.
Benchmark result if necessary
Master:
% time env FAIL_POINT=1 EXTRA_CARGO_ARGS="--no-run" make test
env FAIL_POINT=1 EXTRA_CARGO_ARGS="--no-run"    446.82s user 20.97s system 102% cpu 7:35.51 total

This patch:
% time env FAIL_POINT=1 EXTRA_CARGO_ARGS="--no-run" make test
env FAIL_POINT=1 EXTRA_CARGO_ARGS="--no-run"    12.26s user 3.31s system 120% cpu 12.930 total

The comparison is a little tricky as cost time grows for master when there are too many files in target directory. But it's a practice situation as during edit-test-checkout cycle, number of binaries will grow.

/release

/coverage

It would be nice if you can include https://github.com/tikv/tikv/blob/96a0814cb04c73fd9c8e3a68bbbedfdf1938b0f3/scripts/check-udeps.sh too.

I have moved the file into makefile.


fix: add microbundle global for preact/hooks package

Description
This fixes "useMemo undefined" error when using useSignal hook with UMD scripts.
The UMD builds of preact/hooks package will attach itself to the global window.preactHooks when using CDN, while @preact/signals is searching for window.hooks and cause this problem.
There is also some messages about this in microbundle's output log:
$ pnpm run build:preact

> pnpm _build --cwd packages/preact && pnpm postbuild:preact
> microbundle --raw --globals @preact/signals-core=preactSignalsCore "--cwd" "packages/preact"

No name was provided for external module 'preact/hooks' in output.globals – guessing 'hooks'

Bug Reproduction
Here is a minimal reproduction page demonstrating the issue.
https://stackblitz.com/edit/preact-signals-cdn
Uncaught TypeError: Cannot read properties of undefined (reading 'useMemo')
    at useSignal (signals.min.js:1:2667)
    at g.App [as constructor] (use-signal-broken.html:36:29)
    at g.N [as render] (preact.min.js:1:8510)
    at j (preact.min.js:1:6180)
    at x (preact.min.js:1:2071)
    at j (preact.min.js:1:6394)
    at O (preact.min.js:1:8631)
    at use-signal-broken.html:50:7

Expected Changes
The changes to the UMD build of @preact/signals package after applying this patch is as below:
--- signals-broken.min.js       2023-09-20 18:46:16
+++ signals-fixed.min.js        2023-09-20 18:46:14
@@ -11,7 +11,7 @@
                : i(
                                ((n || self).preactSignals = {}),
                                n.preact,
-                               n.hooks,
+                               n.preactHooks,
                                n.preactSignalsCore
                  );
 })(this, function (n, i, r, t) {

Thanks!


Cursor remains valid when seek to nothing again

Bug Report
Currently we judge whether or not seeking reaches data end by checking either:

cursor.seek() family returns true or false
cursor.valid() returns true or false

This "either" choice is based on the assertion that the following scenario always holds:
let a: bool = cursor.seek().unwrap();
let b: bool = cursor.valid();
assert_eq!(a, b);

However, this scenario actually does not always holds.
In the following test case, last line's assertion will fail:
        must_put(&engine, b"1", b"foo1");
        must_put(&engine, b"5", b"foo5");

        let snapshot = engine.snapshot(&Context::new()).unwrap();
        let mut iter = snapshot
            .iter(IterOption::default(), ScanMode::Mixed)
            .unwrap();

        let mut statistics = CFStatistics::default();

        assert_eq!(iter.valid(), false);

        assert_eq!(iter.seek(&make_key(b"0"), &mut statistics).unwrap(), true);
        assert_eq!(iter.valid(), true);
        assert_eq!(iter.key(&mut statistics), &*bytes::encode_bytes(b"1"));
        assert_eq!(iter.value(&mut statistics), b"foo1");

        assert_eq!(iter.seek(&make_key(b"9"), &mut statistics).unwrap(), false);
        assert_eq!(iter.valid(), false);
        println!("{:?}", iter.key(&mut statistics));

        assert_eq!(iter.seek(&make_key(b"4"), &mut statistics).unwrap(), true);
        assert_eq!(iter.valid(), true);
        assert_eq!(iter.key(&mut statistics), &*bytes::encode_bytes(b"5"));
        assert_eq!(iter.value(&mut statistics), b"foo5");

        assert_eq!(iter.seek(&make_key(b"9"), &mut statistics).unwrap(), false);
        assert_eq!(iter.valid(), false);

Does such use case exist? Is it a bug in real life or just an unexpected behavior for possible usage?

@BusyJay In many of our existing code, we use iter.valid() instead of the return value of seek family function, so it could be possible to construct. Also the newer mvcc refinement heavily relies on this assertion to eliminate an extra check (currently we both check return value and valid() in many functions in mvcc) and it will be easier to construct a failure case.

Would like to see a practical fail case. As the cursor is about to be split into more domain specific, the fix may otherwise not be necessary anymore.

@BusyJay Even after cursor split, this case exists, because after cursor splitting, a re-seek in contrary direction is still allowed (with explicit casting).

because after cursor splitting, a re-seek in contrary direction is still allowed (with explicit casting).

It depends on how the splitting works. The big principle would be only allow one direction seek when possible.
What I really concern about is whether it impacts the version 2.0.xs which doesn't have all the refactoring yet.

Em, @breeswish
I prefer only using valid to check iterator valid or not, seek return nothing,

@breeswish Is this issue already fixed?

@cfzjywxk I'm not sure. @MyonKeminta @sticnarf Could you help verify it against latest branch?

It still exists. And https://github.com/tikv/tikv/pull/3404 is the simplest way to fix it. Why is it closed? @breeswish

It still exists. And https://github.com/tikv/tikv/pull/3404 is the simplest way to fix it. Why is it closed? @breeswish


Clarification between sc_model.py and sb_model.py

Hello, thank you a lot for the work you’ve done on this project. I’ve been using your model and it has been working very well. I have a question that I hope you could help clarify.
I understand that the vgg directory contains code to utilize the pretrained VGG model. However, I noticed that the training process is conducted with sc_model.py. Could you please explain how  sc_model.py  differs from sb_model.py?
I believe sb_model.py is the model described in the paper. If this is the case, could you provide some insight into why sc_model.py is specifically used for the summer2winter dataset?

Hi, thank you for your comment.
both of sc_model.py and sb_model.py contains our proposed UNSB model,
but sc_model.py file is used when using pre-trained VGG model.
We implemented the two models in different way, as extracting features from generator & VGG model show slight difference.
However, overall training processes are same.

Thank you for the clarification. Given that both sc_model.py and sb_model.py contain the proposed UNSB model, I’m interested in understanding how to adjust certain hyperparameters when using sc_model.py.
In particular, if one uses sc_model.py, how can we tweak the hyperparameters such as lambda_NCE and lambda_SB in the UNSB loss calculation? I noticed that in sc_model.py, the given hyperparameters are lambda_spatial, lambda_perceptual, lambda_style, lambda_identity, and lambda_gradient.
I would greatly appreciate if you could provide some guidance in this matter.

Hi, lambda_spatial in sc_model corresponds to lambda_NCE.
For hyperparameter setting, we followed the previous work of "The Spatially-Correlative Loss for Various Image Translation Tasks" (CVPR 21).
Although there are many losses, we did not use lambda_perceptual,lambda_style,lambda_identity, and lambda_gradient, as their default setting is 0.

Hello, thank you for your response, from the code, I believe the overall loss calculation is done in sb_model.py in here like this:
self.loss_G = self.loss_G_GAN + self.opt.lambda_SB*self.loss_SB + self.opt.lambda_NCE*loss_NCE_both

And in the sc_model.pyis done in here like this:
self.loss_G = self.loss_style + self.loss_per + self.loss_G_s + self.loss_G_s_idt_B + self.loss_idt_B + self.loss_G_GAN + self.loss_ENT

which is simplified considering these lambdas are zero:
self.loss_G = self.loss_G_s + self.loss_G_GAN + self.loss_ENT

It looks like self.loss_G_s correspond to self.loss_NCE and self.loss_ENT correspond to self.loss_SB. As you mentioned the lambda_NCE  appears as lambda_spatial, so I wonder if self.opt.lambda_SB and  self.opt.lambda_GAN could be multiplied to the corresponding values (self.loss_ENT and self.loss_G_GAN) in sc_model.py
I might be wrong or missed something  but could you indicate if that would be appropriate?


Update r-tidyselect to 0.2.4.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Change speechSynthesizer voicename in Node js

I have created a bot in node js and it can now talk. How can I change its voce it JessaRUS for example? Is there a bot.set('speechOptions', speechOptions)? and set voiceName: 'Microsoft Server Speech Text to Speech Voice (en-US, JessaRUS)'? Thank you!

@shahidkhuram can you help?

duplicate of: https://github.com/Microsoft/BotBuilder/issues/3231

@shahidkhuram ping :)

As Nils responded earlier, i think this is a dupe and should be closed. Let me know if there's a remaining issue.


Accessibility: Everytime a response button is selected, there is a focus loss. Pressing tab forces the user to start from the first actionable link on the top of the Health Bot (in our case call 911).

Actual
Select “I Accept” or “Yes” or “No” button. There is a focus loss. Actually the focus is on the Health Bot container (as shown in Red rectangle below) but is not visible. Pressing tab brings the focus to call 911 link at the top of the chat window.
Expected
The focus should be programmatically set to the first line of new text which is displayed as part of selecting “I Accept” button. In this case  “I Accept” text highlighted in “green” below.
User Impact:  A keyboard and screen reader user is thrown way off context and they have to press “tab” several times to come back to their original place.
WCAG Violation
Focus Order 2.4.3
https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-order.html
Possibly Related #2608

These are accessibility issues of v3 of Web Chat, which has been deprecated and we no longer support unless there are security risks. For accessible Web Chat, please migrate to v4.
Additionally, these have already been discussed internally. Is there a reason why they are being filed now?

The "I Accept text highlighted in green below" you mentioned is not a clickable nor interactive element. Thus, it is not focusable. We do not expect the user to click on the "I Accept text highlighted in green below".
Thus, there are only 3 things left focusable in your screenshot:

"call 911" link
"Terms & Conditions" link
"Privacy Statement" link

And the first one is "call 911", which is on a correct focus order.

I think the bug referred to the fact that when a user clicked on the "I accept" button at the example. And a new message arrived with or without new 'focusable' items, the focus was lost and set to the start point again instead of following the conversation.
However it looks like this was fixed on v4 as @corinagum mentions.
I'm attaching the next screenshots as examples:
Image 1. The focus is at the text bar for a user to write:

Image 2. The user clicks or presses the Tab button on the "Yes" option

Image 3. The focus is now on the "No" option of the first set of buttons and not resetting to the WebChat root. Therefore it is following the correct focus flow.


Loosen HUnit dependency.

I think this is fixed in master?

It was not fixed at the time when PR was made, but is fixed now. Closing the ticket.


chore: update portlet utils to version 1.1.3

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

https://github.com/Jasig/portlet-utils/releases/tag/portlet-utils-parent-1.1.3

This item is a no-brainer;  commons-collections-3.2.2.jar is already the version selected by Gradle in the dependency resolution process.


Attaching picker to dynamically created element returns "relative positioned container" error

I have the following input, which I'm attaching datetimepicker to on pageload:

This works as expected.
When the user clicks a button, I duplicate this input to allow for multiple dates.
Clone code:

The cloning works as expected, but clicking the date input triggers this error:
Uncaught Error: datetimepicker component should be placed within a relative positioned container
.input-group already has "position: relative;" set in a separate CSS file. I tried adding this as an inline style, but id didn't make a difference.
Any ideas? Thanks in advance!

StackOverflow question: http://stackoverflow.com/questions/35204626/attaching-eonasdan-datetimepicker-to-dynamically-created-element-returns-relati

Solved! Swapped the order of my .datetimepicker and insertAfter functions. Was trying to add a datetimepicker to an input that didn't yet exist.


Workaround failures of filesystem::canonical

... on some old Windows Server containers by falling back to absolute() and checking that the resulting entity is of the correct type.
Works around https://github.com/microsoft/vcpkg/issues/16614

https://github.com/microsoft/vcpkg/issues/18326 <-- This is more like what we want to do


Missing time zone for time stamps

For timestamps the timezone is missing. This can cause errors when parsing or interpreting the data.
A Z for UTC time or +/-xx:xx depending on the time zone would be expected at the end of the timestamp.

#c6b449a49ec2ab517f2691166cefe429be7ebf20

#c6b449a49ec2ab517f2691166cefe429be7ebf20

Commit c6b449a49ec2ab517f2691166cefe429be7ebf20 should do the trick

Commit c6b449a49ec2ab517f2691166cefe429be7ebf20 should do the trick

It works, thanks!

It works, thanks!


In the assessment list tags do not wrap

Only impacts small width devices.
Will add screenshot shortly.

tags now wrap. seems a bit imprecise at the moment but good enough.


colored text should be uncolored

Description
remove \textcolor{blue}{the} with "the"
(Optional:) Please add any files, screenshots, or other information here.

(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
ea1846d3-cfc5-40b3-9387-c0b5ab4f7cdd
Paper URL
https://arxiv.org/html/2404.03323v1
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

@Andron00e this HTML behavior is the same as with the PDF file.
Given you're an author, maybe push a version 2 update that removes the color?


Repair broken this reference in authorizedScope()

A recent commit changed User.prototype.authorizedScope to look up unrestricted scopes from the data store. This change wrapped a this._id in a new function, causing the references to that property to be undefined. This caused user role lookups to always result in an empty array, and therefore authorization requests including restricted scopes would issue tokens omitting those scopes. This PR fixes the problem.

@EternalDeiwos – want to do the honors of merging this one since you discovered the problem?

Would be happy to.


Add support for pipeline properties

What changes were proposed in this pull request?
Adds the ability to edit pipeline properties (as opposed to node properties). Adds a tab to the right panel in the pipeline editor for the pipeline properties editor. Fixes #1699.
This relies on https://github.com/elyra-ai/pipeline-editor/pull/122 being merged / released, so I'll keep the blocked label / draft state until that's released. For now, it uses the code sandbox link so that testing is easier.
Appearance:

Todo:

[x] Add default runtime image field
[x] Switch to using a text area (larger) rather than a text input for pipeline description
[x] Add readonly fields like pipeline name / pipeline type

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@marthacryan Pipeline Editor 0.4.0 has been published now.

Big bug where the api in infinitely called once the properties is opened, otherwise the code looks good.

Fixed!

The actual properties aren't functional though

What's the point of adding properties that have no effect? If there's no backend support they should not be exposed in the UI.

Removing the env var and default runtime fields - planning for those to be added in a follow-up PR.

summary of the follow up plan for runtime images:
The backend will handle filling in the default runtime for nodes that are missing it. Also validation will only flag empty runtimes if a default is also not set.
As for the front end, we want to show a kinda of greyed out version of the default in node properties when it's not set so a user can see what runtime will be used


Fix error logic on workflow view [risk: low]

Don't know when this broke, but this restores the original behavior, plus a wording improvement.

I quickly tested it locally and it works 👍


Remove finishSpanOnClose flag

This is a follow up on https://github.com/opentracing/opentracing-java/issues/267. The underlying issue of that one is that you can't remember the finishSpanOnClose flag when implementing a bridge for ScopeManager#active().
The point of this issue is to remove the finishSpanOnClose flag altogether, as it is only useful in try-with-resources constructs which are a bad practice because you can't can't log exceptions as the span is closed before the catch block. To cite the main README.md:

Note that startActive(true) finishes the span on Scope.close(). Use it carefully because the try-with-resources construct finishes the span before the catch or finally blocks are executed, which makes logging exceptions and setting tags impossible. It is recommended to start the span and activate it later in try-with-resources. This makes the span available in catch and finally blocks.

So we are basically officially admitting that finishSpanOnClose is a bad practice.
You could argue that try-with-resources is valid if you don't want to log exceptions. But what if a user then later decides that they do want to log exceptions? Do they still remember that they can't use try-with-resources + a catch block then? I would most likely forget about that.
The finishSpanOnClose just enables some syntactic sugar after all which turns out to be problematic. As flag essentially advocates a bad practice, I suggest removing it.
Transition:
Of course, we can't just remove the flag which would introduce a breaking change.
Instead, I propose adding the method io.opentracing.Tracer.SpanBuilder#startActive() without arguments, which has the same semantics like calling spanBuilder.startActive(false). Also, deprecate io.opentracing.Tracer.SpanBuilder#startActive(boolean finishSpanOnClose). This method can then be removed on a later release (for example 1.0.0-RC1)
The Scope interface can still extend from Closeable, because logging an exception is still valid to do after the scope is closed.
I think, even after doing this, https://github.com/opentracing/opentracing-java/issues/267 (Deprecate or remove ScopeManager.active()) is still relevant, but maybe less severe.

See also this brave issue for more information about why try-with-resources is considered an anti-pattern: https://github.com/openzipkin/brave/issues/676

note this antipattern is also well documented in wingtips too. There's significant documentation burden to explain how to overcome it
https://github.com/Nike-Inc/wingtips#warning-about-error-handling-when-using-try-with-resources-to-autoclose-spans

@adriancole is an explicit inner-try not a relatively easy fix? I agree there's a documentation burden though.
(example: https://github.com/talsma-ict/context-propagation/blob/develop/context-propagation-java8/src/main/java/nl/talsmasoftware/context/functions/FunctionWithContext.java#L51)

@sjoerdtalsma I think what you are doing is clever, but yeah I agree with @felixbarny.

So trying to get this one moving again - I played a little bit with updating some instrumentation with this change, and it feels it can definitely make things clearer when you need to add logs on unhandled Exceptions (opposed to the case where you didn't care at all about such errors).
This way we could have something like:
Span span = tracer.buildSpan("foo").start();
try (Scope scope = tracer.scopeManager().activate(span)) {
} catch (Exception exc) {
  Tags.ERROR.set(span, true);
  span.log(ImmutableMap.Builder<String, Object>()
                   .put("event", "error")
                   .put("error.object", exc)
                   .build());
} finally {
  span.finish(); // Optional
}

Or
Scope scope = null;
try {
  scope = tracer.buildSpan("foo").startActive();
} catch (Exception exc) {
  Tags.ERROR.set(scope.span(), true);
  scope.span().log(ImmutableMap.Builder<String, Object>()
                   .put("event", "error")
                   .put("error.object", exc)
                   .build());
} finally {
  if (scope != null) {
    scope.close();
    scope.span.finish(); // Optional
  }
}

And the simplest case of simply activating/deactivating without closing it and without reporting errors (when you don't own the Span) would be kept too.
On the other side, I think that, as Felix mentioned, #267 would be less severe - and I'd like to keep that one after removing the finishSpanOnClose flag, to cover up the case when the user has no context to keep the Scope around (with proper/better documentation, of course).
Thoughts? @felixbarny @yurishkuro @sjoerdtalsma @adriancole
PS - if that sounds feasible, I can definitely champion to update the testbed examples once a PR is created for this, and probably adding one more to showcase this case too.

Sounds good to me


ts: Migrate message_overlay_ui to TypeScript.

Migrates message_overlay_ui module to TypeScript.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "buddy review" "mentor review"

@zulipbot add "area: typescript migration"

@zulipbot remove "mentor review" "buddy review"
@zulipbot add "integration review"

LGTM, thanks!

Merged, thanks @Lalit3716 and @PIG208!


[Bug Fix] Error Notif on Success

This PR fixes a bug where the NonInteractiveCodeExecutor shows an "Error!" notif when the program succeeds.
The root cause of this is a typo where, instead of checking if the exit code isn't 0 (which would indicate failure), it checks if the exit code is zero.

Thank you!


Different folder for 'completed' and 'under development' metrics

Hi Everyone,
I was working on classifying the metrics into their respective focus areas (#395). While classifying I noticed that in the metrics folder a lot of metrics seem to be in the stage of development. . So I was thinking of doing the following changes.

Move the developed metrics to a new 'focus-areas' folder.
The ones in the stage of development can be kept in the metrics folder itself

There is another similarly named folder 'focus_areas', which contains the tables of metrics classified as per their focus areas. I was thinking of utilizing those files as the README.md for each focus area in the new 'focus-area' folder.
Please let me know your thoughts and suggestions on this.

The CHAOSS Community decided that we will remove metrics under development from the repository, and and link them to this spreadsheet, which contains links to google docs where the metrics are under development: https://docs.google.com/spreadsheets/d/1tAGzUiZ9jdORKCnoDQJkOU8tQsZDCZVjcWqXYOSAFmE/edit#gid=1004270137


feat: bump all deps to latest and fix all breaking changes

Hey! I've done a bit of modernization here:

updated to next.js 13 (no app, still pages) and some v13 fixes
updated all libs related to supabase and fixed all deprecated functions
migrated to pnpm

Cheers,
Yuri

Also, I'd like to send you some swag as a thank you! Will send you a DM on Twitter 👍

@thorwebdev yeah, you are right, I missed that stripe api version. Thanks for super quick reaction!
Now everything should build without issue. It appears that only one new stripe subscription status has been added (paused). I ran the pnpm supabase gen types typescript --local command, so the supabase types should now be up-to-date as well.


Minor: Quarantine test that is intermittently failing in CI

Feature or Bugfix

Quarantining test: tests/test_athena.py::test_athena_query_cancelled

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 10fda95eead4e12b57c7dd3f049522d1abf1c5d8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Header search button still shows divider line when activated

I'm getting a grey divider crashing into the opened search button on mobile, which looks a bit buggy:

This is on Safari on an iPhone with iOS 16.
I think it should probably just not show the divider when the menu's open – that's how the other 'menu' button behaves.

I think this might have been resolved by various changes in PR https://github.com/alphagov/govuk_publishing_components/pull/3058. Can anyone please confirm?

@jon-kirwan did you find out if this has been resolved? Thank you!

https://github.com/alphagov/govuk_publishing_components/pull/3201 Hello, this should be resolved by this PR

Just a note to say that I'm not seeing this happening on the current live site in Safari iOS 16 so I think it might have already been fixed by https://github.com/alphagov/govuk_publishing_components/pull/3058. Tempted to close the issue but maybe someone else could double check if they can't replicate it before I do that?

This has been resolved by https://github.com/alphagov/govuk_publishing_components/pull/3201, but I didn't close this issue! Sorry!