Fix hot proxy server for shared instances

1. Why is this change necessary?
Currently, the hot-proxy fails to work in shared instances e.g. when using on an internal development server where multiple web application get built at the same time with different domains.
This allows the hot-proxy to get used in a way more widespread environment since many people are not used to local-machine development environments or restricted by company rules to internal development servers.
2. What does this change do, exactly?
This change fixes multiple things

errors inside the lifecycle of a request are now handled properly instead of crashing the whole hot-proxy
port-binds are now bound to the host which eliminates unforeseen binding behavior (e.g. binding to the default :: host may result in only a IPv6 bind)
the request is now piped to a specific host instead of the internal loopback address, which allows any domain-based routers to work properly (e.g. apache/nginx)
reject requests from the wrong host to prevent domain specific content to be served on another domain

3. Describe each step to reproduce the issue or behaviour.

Accessing the Hot-Proxy won't work when using IPv4 because of the IPv6-only bind

$ lsof -i :9998
COMMAND TYPE NODE NAME
node    IPv6 TCP :9998 (LISTEN)

When able to access the Hot-Proxy the pipe won't work due an error: connect ECONNREFUSED <IP_ADDRESS>:80

4. Please link to the relevant issues (if any).
n/a
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I have also an internal PR which fixes a similar issue. Maybe this fixes this too? It works also on a single port instead of two
From 343c8056a2db4ee9226c27df73f4356f65196a83 Mon Sep 17 00:00:00 2001
From: Soner Sayakci<EMAIL_ADDRESS>Date: Mon, 14 Sep 2020 20:49:45 +0200
Subject: [PATCH 1/2] NEXT-10838 - Fix administration login on non localhost
 host

---
 .../app/administration/src/core/service/login.service.js        | 2 +-
 .../Resources/app/administration/webpack.config.js              | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Administration/Resources/app/administration/src/core/service/login.service.js b/src/Administration/Resources/app/administration/src/core/service/login.service.js
index 66c009de25..a2c87e7866 100644
--- a/src/Administration/Resources/app/administration/src/core/service/login.service.js
+++ b/src/Administration/Resources/app/administration/src/core/service/login.service.js
@@ -321,7 +321,7 @@ export default function createLoginService(httpClient, context, bearerAuth = nul
      * @returns {CookieStorage}
      */
     function cookieStorageFactory() {
-        const domain = context.host;
+        const domain = window !== undefined ? window.location.hostname : context.host;
         const path = context.basePath + context.pathInfo;

         // Set default cookie values
diff --git a/src/Administration/Resources/app/administration/webpack.config.js b/src/Administration/Resources/app/administration/webpack.config.js
index 64376d8666..18adddd5c7 100644
--- a/src/Administration/Resources/app/administration/webpack.config.js
+++ b/src/Administration/Resources/app/administration/webpack.config.js
@@ -109,6 +109,7 @@ const webpackConfig = {
                     host: process.env.HOST,
                     port: process.env.PORT,
                     open: true,
+                    disableHostCheck: true,
                     proxy: {
                         '/api': {
                             target: process.env.APP_URL,
--
GitLab

From e983bc223eaed3e60b1421c8933a4fb6e61f1aca Mon Sep 17 00:00:00 2001
From: Soner Sayakci<EMAIL_ADDRESS>Date: Mon, 14 Sep 2020 21:01:25 +0200
Subject: [PATCH 2/2] NEXT-10838 - Fix hot reload in dockerized environment

---
 ...020-09-14-improve-dev-tooling-for-docker.md | 13 +++++++++++++
 .../storefront/build/proxy-server-hot/index.js | 18 +++++++++++++++---
 .../app/storefront/build/start-hot-reload.js   |  5 +++--
 .../Resources/app/storefront/webpack.config.js | 16 +++++++++++-----
 .../Resources/views/storefront/base.html.twig  | 14 ++++++--------
 5 files changed, 48 insertions(+), 18 deletions(-)
 create mode 100644 changelog/_unreleased/2020-09-14-improve-dev-tooling-for-docker.md

diff --git a/changelog/_unreleased/2020-09-14-improve-dev-tooling-for-docker.md b/changelog/_unreleased/2020-09-14-improve-dev-tooling-for-docker.md
new file mode 100644
index<PHONE_NUMBER>..e842dd4de8
--- /dev/null
+++ b/changelog/_unreleased/2020-09-14-improve-dev-tooling-for-docker.md
@@ -0,0 +1,13 @@
+---
+title:              Improve developer tooling with Docker
+issue:              NEXT-10838
+---
+# Administration
+* Changed watcher to allow domains other than `localhost`
+* Disabled host check in webpack dev server
+
+---
+# Storefront
+* Removed port suffix in hot module server when the port is `80` or `443`
+* Changed hot module server to support setups with external ip
+
diff --git a/src/Storefront/Resources/app/storefront/build/proxy-server-hot/index.js b/src/Storefront/Resources/app/storefront/build/proxy-server-hot/index.js
index b8cc097bc8..fa18340456 100644
--- a/src/Storefront/Resources/app/storefront/build/proxy-server-hot/index.js
+++ b/src/Storefront/Resources/app/storefront/build/proxy-server-hot/index.js
@@ -8,13 +8,13 @@ const { createServer, request } = require('http');
 const { spawn } = require('child_process');

 module.exports = function createProxyServer({ appPort, originalHost, proxyHost, proxyPort }) {
-    const proxyUrl = `${proxyHost}:${proxyPort}`;
-
+    const proxyUrl = proxyPort !== 80 && proxyPort !== 443 ? `${proxyHost}:${proxyPort}`: proxyHost;
     const originalUrl = appPort !== 80 && appPort !== 443 ? `${originalHost}:${appPort}` : originalHost;

     // Create the HTTP proxy
     const server = createServer((client_req, client_res) => {
         const requestOptions = {
+            host: originalHost,
             port: appPort,
             path: client_req.url,
             method: client_req.method,
@@ -22,11 +22,23 @@ module.exports = function createProxyServer({ appPort, originalHost, proxyHost,
                 ...client_req.headers,
                 host: originalUrl,
                 'hot-reload-mode': true,
-                'hot-reload-port': process.env.STOREFRONT_ASSETS_PORT || 9999,
                 'accept-encoding': 'identity',
             },
         };

+        // Assets
+        if (client_req.url.indexOf('/_webpack_hot_proxy_/') === 0) {
+            requestOptions.host = '<IP_ADDRESS>';
+            requestOptions.port = process.env.STOREFRONT_ASSETS_PORT || 9999;
+            requestOptions.path = requestOptions.path.substr(20);
+        }
+
+        //
+        if (client_req.url.indexOf('/sockjs-node/') === 0 || client_req.url.indexOf('hot-update.json') !== -1 || client_req.url.indexOf('hot-update.js') !== -1) {
+            requestOptions.host = '<IP_ADDRESS>';
+            requestOptions.port = process.env.STOREFRONT_ASSETS_PORT || 9999;
+        }
+
         // pipe a new request to the client request
         client_req.pipe(
             // request the data
diff --git a/src/Storefront/Resources/app/storefront/build/start-hot-reload.js b/src/Storefront/Resources/app/storefront/build/start-hot-reload.js
index a7973b6ab2..89e1b8e76d 100644
--- a/src/Storefront/Resources/app/storefront/build/start-hot-reload.js
+++ b/src/Storefront/Resources/app/storefront/build/start-hot-reload.js
@@ -6,6 +6,7 @@ const server = createLiveReloadServer();

 server.then(() => {
     const fullUrl = process.env.APP_URL;
+    const proxyUrl = new URL(process.env.PROXY_URL || process.env.APP_URL);
     const proxyPort = process.env.STOREFRONT_PROXY_PORT;

     // first value of array is the http protocol
@@ -15,8 +16,8 @@ server.then(() => {
     const proxyServerOptions = {
         originalHost: domain,
         appPort: port || 80,
-        proxyHost: domain,
-        proxyPort: proxyPort || 9998,
+        proxyHost: proxyUrl.hostname,
+        proxyPort: parseInt(proxyPort || 9998),
     };

     // starting the proxy server
diff --git a/src/Storefront/Resources/app/storefront/webpack.config.js b/src/Storefront/Resources/app/storefront/webpack.config.js
index 807e0ee410..fc748f1d79 100644
--- a/src/Storefront/Resources/app/storefront/webpack.config.js
+++ b/src/Storefront/Resources/app/storefront/webpack.config.js
@@ -26,10 +26,14 @@ if (isHotMode) {
 }

 let hostName;
+const proxyPort = parseInt(process.env.STOREFRONT_PROXY_PORT || 9998);

 try {
-    const { protocol, hostname } = new URL(process.env.APP_URL);
+    const { protocol, hostname } = new URL(process.env.PROXY_URL || process.env.APP_URL);
     hostName = `${protocol}//${hostname}`;
+    if (proxyPort !== 80 && proxyPort !== 443) {
+        hostName += `:${proxyPort}`;
+    }
 } catch (e) {
     hostName = undefined;
 }
@@ -40,7 +44,8 @@ let webpackConfig = {
         if (isHotMode) {
             return {
                 contentBase: path.resolve(__dirname, 'dist'),
-                publicPath: `${hostName}${isHotMode ? ':9999' : ''}/`,
+                public: hostName,
+                publicPath: `${hostName}/`,
                 open: false,
                 overlay: {
                     warnings: false,
@@ -54,7 +59,7 @@ let webpackConfig = {
                 compress: false,
                 disableHostCheck: true,
                 port: 9999,
-                host: '<IP_ADDRESS>',
+                host: '<IP_ADDRESS>',
                 clientLogLevel: 'warning',
                 headers: {
                     'Access-Control-Allow-Origin': '*'
@@ -281,7 +286,7 @@ let webpackConfig = {
     output: {
         path: path.resolve(__dirname, 'dist'),
         filename: './js/[name].js',
-        publicPath: `${hostName}${isHotMode ? ':9999' : ''}/`,
+        publicPath: `${hostName}/`,
         chunkFilename: './js/[name].js'
     },
     performance: {
@@ -352,8 +357,9 @@ if (isHotMode) {
     const scssEntryFileContent = (() => {
         const fileComment = '// ATTENTION! This file is auto generated by webpack.hot.config.js and should not be edited.\n\n';
         const dumpedVariablesImport = `@import "${scssDumpedVariables}";\n`;
+        const assetOverrides = '$sw-asset-public-url: \'\';\n$sw-asset-theme-url: \'\';\n$sw-asset-asset-url: \'\';\n$sw-asset-sitemap-url: \'\';\n'

-        const collectedImports = [dumpedVariablesImport, ...themeFiles.style.map((value) => {
+        const collectedImports = [dumpedVariablesImport, assetOverrides, ...themeFiles.style.map((value) => {
             return `@import "${value.filepath}";\n`;
         })];

diff --git a/src/Storefront/Resources/views/storefront/base.html.twig b/src/Storefront/Resources/views/storefront/base.html.twig
index efca5fe006..b16c343485 100644
--- a/src/Storefront/Resources/views/storefront/base.html.twig
+++ b/src/Storefront/Resources/views/storefront/base.html.twig
@@ -1,5 +1,5 @@
 {# Set variable to "true" to enable HMR (hot page reloading) mode #}
-{% set isHMRMode = app.request.headers.get('hot-reload-mode') %}
+{% set isHMRMode = app.request.headers.get('hot-reload-mode') and app.environment == 'dev' %}

 {% block base_doctype %}
 <!DOCTYPE html>
@@ -154,14 +154,12 @@

         {% block base_script_hmr_mode %}
             {% if isHMRMode %}
-                {% set baseUrl = app.request.getScheme() ~ '://' ~ app.request.getHost() %}
-                {% set port = app.request.headers.get('hot-reload-port') %}
-                <script type="text/javascript" src="{{ baseUrl }}:{{ port }}/js/vendor-node.js"></script>
-                <script type="text/javascript" src="{{ baseUrl }}:{{ port }}/js/vendor-shared.js"></script>
-                <script type="text/javascript" src="{{ baseUrl }}:{{ port }}/js/runtime.js"></script>
-                <script type="text/javascript" src="{{ baseUrl }}:{{ port }}/js/app.js"></script>
+                <script type="text/javascript" src="/_webpack_hot_proxy_/js/vendor-node.js"></script>
+                <script type="text/javascript" src="/_webpack_hot_proxy_/js/vendor-shared.js"></script>
+                <script type="text/javascript" src="/_webpack_hot_proxy_/js/runtime.js"></script>
+                <script type="text/javascript" src="/_webpack_hot_proxy_/js/app.js"></script>
                 {# The storefront entry is a combined entry point which contains all plugins & themes #}
-                <script type="text/javascript" src="{{ baseUrl }}:{{ port }}/js/storefront.js"></script>
+                <script type="text/javascript" src="/_webpack_hot_proxy_/js/storefront.js"></script>
             {% else %}
                 {% for file in shopware.theme.assets.js %}
                     <script type="text/javascript" src="{{ asset(file, 'theme') }}" async></script>
--
GitLab

@shyim ill try this on Monday, weekend is calling :)

Hey @element-code, could you give me a quick update on monday?

@J-Rahe, as far as I can see the changes that @shyim made are looking fine & work as required by this PR.

HMR watcher triggers on plugin SCCS & JS changes
storefront reloads properly,
The second port 9999 doesn't need to be open to the public anymore 👏

Something with the web sockets is not working as expected, it did not affect the workflow anyways.*

I still would suggest some changes (references to 2. What does this change do, exactly?):

Let the proxy server listen to proxyPort, proxyHost instead of only listening to proxyPort as done in https://github.com/shopware/platform/pull/1642/commits/cfe62765ce0b7532df9f4511c7d7a73cdc7c2f03 (see reason in 2.2.)
Reject hot-proxy request from wrong hosts as done in https://github.com/shopware/platform/pull/1642/commits/c67a63db7b6900084810715dea0da8ea5d2ce4d7 (2.4.)
Handle errors in the server request callback "properly" as done in https://github.com/shopware/platform/pull/1642/commits/9979d02a112788bc1d673e34208bcc51ffe856fa (2.1.)

Hey @element-code ,
My changes are now merged. The first change could be problematic. The current setup uses as proxyHost localhost. This would make the server listing only to <IP_ADDRESS> and not more accessible from outside the docker container.
I have no idea how to handle that smooth with only one Env. As we have already a env for the port, we could create there a second one for the listen ip.
The both other changes are fine for me.
Thanks for your Contribution! 💙

I've excluded the first change from this PR :)

Can you rebase into one commit?

@shyim I tried, but the merge commit seems to create the conflict again and again.
Please tell me how to handle that.
Right now the history is messed up since that merge commit  contains only the conflict resolution and the main commit contains the real merge changes.. not proud of this :D

Maybe try git reset --soft? that would set you back to the choosen commit with the changes you did in an "to-be-commited"-state.

But there is more.. HTTPS.
I'm not sure about the source, but it seems that Firefox throws an upgrade-insecure-requests header in the request when the domain is known to support HTTPS. This is fine but when connecting to :9998 we get our upgrade as well ... and then we get a SSL_ERROR_RX_RECORD_TOO_LONG error.
The question is, do you see any way to support HTTPS on the hot proxy? -- have each developer change his complete browser behavior to be able to develop shopware project seems not like an option.

introduce two new environment variables for the key file paths
bring self-signed keys with shopware, only for this -> this would allow using HTTPS for the hot proxy in general for all shopware development; after accepting the self-signed cert
any ideas, maybe a much easier way?

Hey @element-code, that does sound more like an problem with the setup to me. If you cant tell your server not to serve https on that port, maybe an TLS termination proxy can help? Having the hot proxy run on an Server is not really that common and adding https to the hot-proxy servers will probably be quite a bit of work.

Yeah, I'm not quite sure how the stack is built and who has control over the upgrade process itself.
The main question is if node is involved in that process.
On the other hand should the hot-proxy support/use HTTPS for security reasons.
Let us move this topic out of this merge request, I'll write an issue for this.

This PR should be ready to merge?

@element-code, if you complete the changelog i can put it in our internal review.
You are missing the mail (you do have an mail from github for the case that you don't want your private mail in the changelog)
and we do have some keywords( Added, Removed, Changed, Deprecated) that have to be used, you can take a look at the /changelog/_example.md if you are unsure.

@element-code?

@J-Rahe done 👍

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14102
Please use this issue to track the state of your pull request.


[GSSOC'23] -- Adding a scroll to top button

Issue Description:
I would like to suggest on having a "scroll to top" option available to easily navigate back to the top of the page. Currently, when I scroll down the webpage, I have to manually scroll back up, which can be inconvenient and time-consuming, especially on long pages. @codervivek5 Please assign me this issue.
Expected Outcome:
When implemented, the "scroll to top" option will provide a convenient way for users to quickly return to the top of the webpage with a single click or tap. This feature will enhance the user experience by improving the accessibility and usability of the website.
Proposed Solution:
To address this issue, we can add a scroll-to-top button or a similar UI element that remains fixed on the page. When the user clicks or taps on the button, the page will smoothly scroll back to the top, allowing for easy navigation. The button should be easily visible and accessible to users as they scroll down the page.

I'm interested, could you please assign me this issue?

Please assign it to me under gssoc'23. I want to work on it


release 0.4.0

This PR contains the latest changes for release 0.4.0 of sf-processor:

Simplified processor modes to enrich and alert

enrich adds policy info, priority, and tags records that match rules. Non-matching records are pushed as is (non-blocking). This is the default mode.
alert adds policy info, priority, and tags to matching records and raises them to alerts. Non-matching records are blocked.

drop rules can be used to pre-filter the record stream before applying rules. The old filter keyword is silently supported (not documented).
Policy engine processes records concurrently in a thread pool of workers. The pool size is configurable (default is 5). Record processing is asynchronous, there is no guarantee on the record order in the output when processing records concurrently.
Support for pluggable user-defined actions. Actions are specified using the action key in a rule. Value is a comma-separated list of action names. Each action can add context such as tags to the record. Actions attached to a particular rule are executed in the order they were specified.
The hash feature is not part of this PR. This version does not provide any built-in actions.
There is no alert action anymore. Policy files in the repo are updated.
Updated documentation. This also includes documentation in writing user-defined action plugins.

Thanks for this PR. It fixes the ambiguity we had in the policy engine modes and add pluggable, user-defined actions to the processor. Nice job! I went through the code changes, and made some additional changes, fixes, and refactoring:

fix linting issues: comment style, error message style, naming style, etc.
refactor thread pool and fix start/stop lifecycle when used with policy monitor; if using the monitor, the interpreter pool wouldn't be closer/stopped prior to assigning a new interpreter.
refactor policy monitor and simplified usage in policy engine (unrelated to this PR, but since I was there :))

I tested the pipeline modes, in both enrich and alert mode, and it looks good.

LGTM


I am getting error on 'flutter pub get'

Running "flutter pub get" in counter_app...
Because every version of flutter_test from sdk depends on test_api 0.2.19-nullsafety.2 which depends on async >=2.5.0-nullsafety <2.5.0, every version of flutter_test from sdk requires async >=2.5.0-nullsafety <2.5.0.
And because every version of swipeable_page_route depends on list_diff ^1.3.0 which depends on async >=2.2.0 <2.5.0, flutter_test from sdk is incompatible with swipeable_page_route.
So, because counter_app depends on both swipeable_page_route ^0.1.4 and flutter_test any from sdk, version solving failed.
pub get failed (1; So, because counter_app depends on both swipeable_page_route ^0.1.4 and flutter_test any from sdk, version solving failed.)
exit code 1

As the error message describes, the list_diff dependency restricts compatible versions of async to >=2.2.0 <2.5.0. There's already an issue (including a workaround) for that: marcelgarus/list_diff#4

Fixed this with version 1.3.2 of list_diff.

Fixed this with version 1.3.2 of list_diff.


First draft for Support of multiple Prefixes

This is a first draft to support multiple prefixes.
Right now I added the feature only for table extensions fields.
But this can easily added for the other extension objects.
I was tryin to create a solution for issue: https://github.com/waldo1001/crs-al-language-extension/issues/151
It's not perfect, but I could work as temporary solution.
@waldo1001 do you have any plans and time to work on improvements of prefix handling or would accept the solution that is proposed with this Pull Request.
@christianbraeunlich you do seem to have some experience with npm.
Do you know how I can disable that the yarn.lock is updated and that yarn.lock is used instead of package-lock.json for this repository?

Have you tried this: https://github.com/waldo1001/crs-al-language-extension/blob/master/HowToContribute.md#installation---with-yarn

@waldo1001 I would really appreciate if you give me some feedback on this pullrequest.
Is this a feature you would accept?
I know i would have to add this feature to any function where currently the ObjectNamePrefix is used.

First of all: thank you!  and sorry to not being able to really look into this myself (too busy).
Having multiple places for similar settings doesn't make sense .. we should go for the "appsourcecop.json" approach.
That should be quite similar to my function to read the app.json (in the Settings.ts file):

If I'm not mistaken, the idea is to check the current name with the approved affixes, and if one of the affixes are either in the beginning, or at the end - then the filename is accepted .. correct?

Makes totally sense.
Do know that multiple affixes is not possible anymore for partners - just old partners (like us?) might have multiple.. .
We simply switch off auto-suffixing because of this and let the codecop handle it :(.  But sure - let's see what you can come up with ;-)

@waldo1001 it took some time, but now I updated my code to make use of the AppSourceCop.json
Looking forward to feedback.


Rewrite CONTRIBUTING.md

CONTRIBUTING.md should be rewritten to reflect the recent changes to this project.

In order to ease us (the Wikidata dev team) to track the issues of the primary sources tool, we have created a Phabricator ticket for this issue: https://phabricator.wikimedia.org/T148151
Moving forward, please drop your comments onto that Phabricator ticket.


vscode does not honor http_proxy and https_proxy environment variables on Linux

VSCode Version: 1.21.1
OS Version: Ubuntu 16.04

Steps to Reproduce:

Run code
Click on "Source Control" (Ctrl-Shift-G)
More -> Install Additional SCM Providers...

An error will pop up "An unknown error occurred. Please consult the log for more details.".

Does this issue occur when all extensions are disabled?: Yes/No
Yes.
Workaround
Start code as follows:
code --proxy-server="http=$http_proxy;https=$https_proxy"

Then everything works.
I think this is a bug, as code should honor the http_proxy, https_proxy (and also no_proxy) variables automatically just like every other program that is launched from the command line like wget, apt-get, etc.

Until this is fixed, a solution for me is to put this into the ~/.bashrc:
alias code="code --proxy-server=\"http=$http_proxy;https=$https_proxy\" --proxy-bypass-list=\"localhost;<IP_ADDRESS>;*CORPORATE_DOMAIN\""

(Change CORPORATE_DOMAIN for your company domain.)
Now everything seems to be working. Simply use code or code <path> from the command line.
The option --proxy-bypass-list unfortunately expects the addresses in a different format than the linux no_proxy environment variable uses, so that's why one has to specify those by hand.

Docs: https://code.visualstudio.com/docs/setup/network

@joaomoreno I used those docs to figure out a workaround above, but those docs are insufficient to determine the answer to this bug report. I am happy to submit a PR improving the docs, but in order for me to do that, can you please confirm, that the below is correct:

vscode will only support proxy settings via Chromium setup
vscode will not support http_proxy, https_proxy and no_proxy, unless Chromium itself supports it

@certik That is correct.


Simplify the BaseCommand classes

:+1: as long as you update command/stacker/__init__.py...see tests.

ah, left over pyc files on my end were causing tests to pass locally


Added get_grade_book function

Added get_grade_book function so users can retrieve the grades of their current classes without having to parse and iterate through all of them.

Thanks! A few things:

Don't use format strings because they're not compatible with versions earlier than Python 3.7
Make the return documentation more descriptive
Change the values in the return dictionary from lists to a dictionaries that label the mark and score

When you say "make the return documentation more descriptive", what exactly does that mean? More description of the structure of the return value, or more descriptive about what information it holds?


Add method to deleteCommitComment

The icon exist on the user interface to remove a comment but the API does not provide this feature.
It is required when a tool automatically creates comments on a commit and we don't want comments being duplicated after each execution. The tool needs to remove (or update) previous comments.

Sure, happy to merge a PR if you're willing to contribute it! :)


Unable to refer to a resource group in own model from main.bicep

I have a main.bicep which runs two modules, where the resource group is in its own model and has to be refered to the scope of the other model (vnet).

main.bicep

targetScope = 'subscription'

module rgDeploy './CreateResourceGroup.bicep' = {
  name: 'Rg_Something_Deploy'
}

module vnetDeploy './CreateVNet.bicep' = {
  name: 'vnet_Deploy'
  dependsOn: [
    rgDeploy
  ]
  scope: resourceId(rgDeploy.outputs.rgID) **?????????????**
}

rgDeploy

targetScope = 'subscription'

resource newRG 'Microsoft.Resources/resourceGroups@2021-04-01' = {
  name: 'Rg_Something'
  location: 'westus'
}

output rgID string = newRG.id **?????????????**

vnetDeploy

resource newVNet 'Microsoft.Network/virtualNetworks@2021-02-01' = {
  name: vnetName
  location: 'westus
}

Do I need output in rgDeploy, if yes what kind?
also how to include it in vnetDeploy ?
I tried to use the resourceGroup() function but didn't manage to make it work

The easiet way to do this would be to do this in your main.bicep:
targetScope = 'subscription'

resource rg 'Microsoft.Resources/resourceGroups@2021-04-01' = {
  name: 'myRg'
  location: 'westeurope'
}

module vnetDeploy './vnet.bicep' = {
  name: 'vnet_Deploy'
  scope: rg
  params: {
    vnetName: 'myVNet'
  }
}

But is there no way to create a resource group in own module at all ?
What if the deployment has so many Resource groups ?

Yes, you can deploy resource groups using modules but you add complexity to the template by doing so. Since the scope property on the module deployment requires a vaule that can be calculated at the start of the deployment you can not use an output from the resourceGroup deployment if you are using a module for it. And a module deployment (your VNet) also expects the type resourceGroup for the scope property, which requires that you use the resourceGroup() function.
You can do something like this to deploy the RG using a module and then use it as scope for your VNet deployment.
targetScope = 'subscription'

param rgName string
param vnetName string
param location string

module rg 'rg.bicep' = {
  name: 'rg_deploy'
  params: {
    location: location
    name: rgName
  }
}

module vnet './vnet.bicep' = {
  name: 'vnet_Deploy'
  scope: resourceGroup(rgName)
  dependsOn: [
    rg
  ]
  params: {
    vnetName: vnetName
  }
}

You get additional code, an extra module to maintain and get no benefits from it.
If you have many resource groups to deploy you can just loop your RG deployment or declare multiple RGs in the template. Since resource groups don´t have any properties to define except name and location  it adds very little code to your template. Below is an example with loops for RG and VNet deploy.
targetScope = 'subscription'

param rgNames array = [
  'rg1'
  'rg2'
]
param vnetNames array = [
  'vnet1'
  'vnet2'
]
param location string

resource rg 'Microsoft.Resources/resourceGroups@2021-04-01' = [for rgName in rgNames: {
  name: rgName
  location: location
}]

module vnet './vnet.bicep' = [for (vnetName, i) in vnetNames: {
  name: 'vnet_Deploy'
  scope: rg[i]
  params: {
    vnetName: vnetName
  }
}]


CORE: Syntax Highlighting

Integrate the syntax highlighter in to the markdown parser.

Sort-of working.

I'm going to close this for now. I can't remember what was wrong or missing. We'll open new bugs when we figure out what.


Insert into the middle of a list?

If I have a Node, is it possible to insert an item directly before or directly after it using this library?
The only existing functions I see for insertion are unshift (at the beginning of the list) and push (at the end of the list).

I'd accept a pull request to add a splice function that works like the Array function by the same name.

Pull request is ready.
I`ve also removed old versions of node from travic-ci config to make tests green.

This change also makes this library Node < 6 incompatible: (see #21) - this made this a breaking change, no? (semver-major)


[distributed training] conditional statement error for GPU allocation

should remove not
'''
if not getattr(self.model, "is_sequential_parallel", False):
self.current_device = self.accelerator.device
else:
self.current_device = torch.device("cuda:0")
'''

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @halfrot @younesbelkada,
I'm facing the same issue as above. What is the intended fix for this case?
My issue:
I'm using accelerate with PPO training. Following example scripts, I've set device_map = {'': Accelerator().local_process_index} in my base model definition. As I can check here, this somehow sets is_sequential_parallel = True (I'm not sure how this exact process follows, didn't debug yet). But given that is_sequential_parallel is True, this code executes to False, and self.current_device is updated to cuda:0. This eventually leads to the issue that response_tensors are not in the right device as expected.


Error No Database connection yet in VoyagerServiceProvider loadAuth()

Version information

Laravel: 8.42.1
Voyager: 1.4.2
PHP: 7.4.3
Database: MySQL 8.0

Description
I end up with a recurring errors that doesn't seem to be a problem for my app (but populated my log file).
This error occurs even outside Voyager admin panel.
[datetime] local.ERROR: No Database connection yet in VoyagerServiceProvider loadAuth()

Please search before opening issues.
Duplicate of https://github.com/the-control-group/voyager/issues/5285, https://github.com/the-control-group/voyager/issues/5069 and https://github.com/the-control-group/voyager/issues/4045

I had watched carefully before opening my issue, and messages like: "This is just a warning, not an error" does not suit me, thank you!
Voyager seems to be at a standstill and is proving to be more and more buggy, I will take my time to create my own administration panel.
Thank's for your work, but Pity :(

But it's true, when we'd delete that line no one would notice.
It's just saying that there is no database connection yet and will try again later.
Saying that Voyager is dead is not correct at all. We are still merging PRs.
Beside that we are working hard on V2 which is why merging/releasing/triaging is just a bit slower at the moment.

Quoted from https://github.com/the-control-group/voyager/issues/5285

The error messages was "softened" and is now an information.
This message (No database connection yet in VoyagerServiceProvider loadAuth()) can be ignored safely and is definitely not the cause of any problems mentioned here.


docs(useExpanded): Add sub-comp-lazy to sidebar

Oops, I missed this in #2531!

Nice :)

:tada: This PR is included in version 7.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(jsfm): must use promise polyfill SDK version >= 0.26 fixed #3127

Brief Description of the PR
Sdk >= 0.26  Android must always use polyfill.
read two commits:

[jsfm] Also enable the promise polyfill on Android
 [Android] Remove shared library from binary of Weex

first commit let promise use polyfill in android, but second commit make WXEnvironment.__enable_native_promise__  true, so promise use native, and has some unexpected behavior.
Checklist

Demo:
Documentation:

Look at this issue #3127  ,  I think to change this logic is the minimum cost

The code in master branch has changed, WXEnvironment.sUseRunTimeApi will be ture if we use libjsc.so
Could you please check that?

@YorkShen  ok, read this code, the logic is work.
but if use SDK0.28  (tag: 0.28.0), I only build a jsfm to make the promise doesn't use native.
Do you have a better suggestion？

@chs97 Not quite sure what you mean.


Prometheus: Expose individual probe results

Currently the Prometheus surfacer just provides aggregate data.
It would be great if we could also get an option to provide a metric for each individual executed probe, which is purged once it was exported once.

@theduke You can export gauge metrics instead of aggregates by adding the following to the config:
export_as_gauge: true

https://cloudprober.org/docs/config/surfacer/#cloudprober_surfacer_SurfacerDef
Note: if you run more than one probe every 10s, you'll still see results aggregated every 10s.

@theduke Can you please confirm if the above comment answers your question?


If DynamoDB changes version, still match

This means that Current keeps working even if the version changes (or if someone for some reason is using a different version), otherwise we get a case_clause error

Thanks for your PR! I am just wondering if we should lock current to specific version to be sure we are compatible with DDB API or just simply trust Amazon that there won't be any breaking changes in their API. Of course throwing more meaningful error would be way nicer than case_clause error.

So this way does have the advantage that the message will still get thrown up to the user of Current, but with the version bit at least indicating something is a bit odd. It's not quite a meaningful error though.

Agree.


Update project tt_um_a1k0n_vgadonut (a1k0n/tt08-vga-donut)

Update project tt_um_a1k0n_vgadonut to commit a1k0n/tt08-vga-donut@01d39c8d4980902c7b3042004db6747fa79f8f43
Project title: VGA donut
Tiles: 2x2
Workflow: https://github.com/a1k0n/tt08-vga-donut/actions/runs/10640278664

you can close this PR, I have a new revision upcoming which fixes some glaring issues and looks much better and even uses less area.


don't use ENTER instruction

it's slower than the 3 instruction sequence

See<EMAIL_ADDRESS>

This is not true for 16 bit code generation, which is still supported by the code generator. In addition, ENTER is shorter, and so is appropriate when being optimized for space, also supported by the code generator. It can't be removed wholesale.
I'm not sure which CPU made ENTER slower, but the code generator supports quite a number of CPU specific optimizations from the 8088 (!) to the present.

If ENTER appears in speed optimized code, then fix that and reopen this.

D doesn't support 16 bit code anyway... can you at least like #ifdef it if this code is shared with dmc? (BTW I still kinda like dmc's 16 bit support, but dmd doesn't need it)

If ENTER appears in speed optimized code, then fix that and reopen this.

It does, just checked again. Something like enter &= globals.release; at the right places would do the trick to generate the full prologue when -release is defined.

16 bit in 2015? Are you joking?

IIRC valgrind doesn't support ENTER/LEAVE, and its use was supposed to be removed (atleast on IA-32 & amd64)
https://issues.dlang.org/show_bug.cgi?id=11788

D doesn't support 16 bit code anyway...

But dmc does, and the code generator is shared, and the dmc test suite does a lot of code gen checking that the dmd suite does not.

can you at least like #ifdef it if this code is shared with dmc?

I've been trying to remove all the #ifdef's because I'd eventually like to convert the source code to D. Besides, I cannot identify any detriment to having a test for I16 here and there.

valgrind doesn't support ENTER/LEAVE

One wonders why valgrind doesn't support the complete instruction set.

16 bit in 2015?

dmc is the only compiler supporting DOS that is still maintained. There are users of it I support.

Updated to only use ENTER for 16-bit codegen.

There's no reason to not use ENTER/LEAVE for 32/64 bit code when optimizing for space on Windows. Valgrind doesn't run on Windows, so Valgrind's bugs are irrelevant.


Type Definitions for SELECT commands - is there an improvement possible?

I have an entity definitions like follows:
entity Travels : managed, cuid {
  displayId          : Integer                       @readonly  default 0  @assert.unique;
  beginDate          : Date;
  endDate            : Date;
  bookingFee         : Decimal(16, 3);
  totalPrice         : Decimal(16, 3)                @readonly;
  currencyCode       : Currency;
  description        : String(40);
  travelStatus       : Association to TravelStatuses @readonly;
  agency             : Association to TravelAgencies @assert.integrity;
  customer           : Association to Passengers     @assert.integrity;
  bookings           : Composition of many Bookings
                         on bookings.travel = $self;
  bookingSupplements : Association to many BookingSupplements
                         on bookingSupplements.travel = $self;
};

Now I am writing a SELECT command:
await SELECT
  .from(Travels)
  .columns(
      'displayId',
      'invalidColumn'
  )
  .where({
    invalidColumn: 'ABC'
  });

I do not get a type error if I use an invalid column name when supplying columns or using where.
I would expect to get a type error if I use an invalid column name to make the development easier and faster.
Is this possible?
Through the .from(Travels) the valid column names could be inferred or not? I am no TypeScript expert and just enjoy using it. As I think this would be very beneficial I just want to ask if this is possible or understand why this is not possible.

Maybe try out cds-ts-repository if you need good type auto-completion:

You also can use the projection syntax which is provided out of the box and provides at least the typings for the columns method,
await SELECT
  .from(Travels)
  .columns((t) => [t.displayId, t.invalidColumn]) // compiler will complain that invalidColumn is not a property of t
  )
  .where({
    invalidColumn: 'ABC'
  });

Hi everyone,
I will attempt to add this in the next release of cds-types. As CQL is quite powerful and allows for several different syntaxes to axpress where and having, we'll have to circle in on the a full solution over time.
Best,
Daniel


Implement verify-only PSS PaddingScheme

A fix for #172 , implementation of verify-only PSS padding schema

Instead of introducing a DummyRng, it seems to me like it would make more sense to remove salt_rng from PaddingScheme::PSS.
Its only use is to pass it to pss::sign, and in that regard it can be passed as an explicit parameter rather than embedding it into the padding scheme. An RNG is already an explicit parameter to sign_blinded (in which case it receives two RNGs. I'm not sure why one would want to use two RNGs?)
Really it'd be nice to implement the traits from the signature crate, where the "sign" vs "sign with RNG" cases are concretely handled as Signer versus RandomizedSigner, but that's a lot more work.

@tarcieri done

gracious ping

Refreshed to remove conflict.

@tarcieri could this be included in the upcoming 0.7.0 release? It would save me a dependency and make it clearer what is going on in my code.

Yep, that's the plan

Yep, that's the plan

Great! I look forward to testing 0.7.0-pre2😁


fix: readme format

Codecov Report

Merging #414 (82b4d54) into master (d02a4b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   59.44%   59.44%
=======================================
  Files          41       41
  Lines        2796     2796
=======================================
  Hits         1662     1662
  Misses       1008     1008
  Partials      126      126

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[2012-07-02] Missing feature: Sort pages alphabetically; Duplicate Page

created by: @smagnusson (smagnusson)
created at: 2012-07-02
original ticket: http://open.silverstripe.org/ticket/7602

The ability to order pages by Name and Duplicate Pages in v2.4 has been lost in v3.0.
Put these right-click options back on to the page tree. In the case of Sort, make this a sub menu now, whereby you can choose either to Sort by "Title" and Sort by "Last edited date."
The right menu therefore becomes

Edit
Add new Page there -> (page types)
Sort -> By Title \n By Last Edited Date
Duplicate -> This page only \n This page and subpages

Attached - screenshot of 2.4 showing the feature.

Duplicate functionality has been added, feature request anyway


tsdb: fsync only called on segment closing

I was reading the ingestion path of tsdb and was talking to @gouthamve as I think fsync is only called on closing a segment (which happens on shutdown) or when rotating to a new segment (which happens when a segment is "full"). A segment is 128MB by default, so on unclean shutdown, I believe we may loose up to the most recent 128MB of data.
It looks like https://github.com/prometheus/tsdb/pull/332 added the new WAL, which is not being flushed at an interval, being part of the strategy to make:

It is safe for concurrent reads across different processes.

@gouthamve and I were thinking that instead of fsync'ing at an interval, we fsync in flushPage or directly at the end of log.
First of all, let's validate this and make sure we didn't miss something :slightly_smiling_face: . Otherwise let's make sure we fix this. (I'm actually on vacation, just happened to be reading the code for work unrelated reasons, so it's unlikely I will work on it this week, I'll be back next week)
@gouthamve @brian-brazil @codesome @cstyan @fabxc

As part of the bugscrub, it is proposed that we close this as at best it'd be a tunable that'd make no practical difference in terms of dataloss on power failure - you could have lost the same data if the power had been lost a few seconds before.

Agreed.


discourse: migrate to prefetch-yarn-deps

Description of changes
#240174
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269287 run on x86_64-linux 1

2 packages built:

discourse
discourseAllPlugins

@ofborg build discourse discourse.passthru.tests

Doesn't build on top of master, though.

Result of nixpkgs-review pr 269287 run on x86_64-linux 1

2 packages built:

discourse
discourseAllPlugins

@ofborg build discourse discourse.passthru.tests


Change app-admin/eselect-* to app-eselect/eselect-*

Fix broken build

Thanks!

Thanks for sharing this great tool !


rocm-smi does not show full clock and voltage information

Despite booting with the amdgpu.ppfeaturemask=0xffffffff kernel parameter, I cannot see some clock and voltage related information via rocm-smi. I'm using a 6900XT on a X570 motherboard with Ryzen 5900X. Here's the output from rocm-smi -a and rocminfo - notice the lines saying ERROR: 15 GPU[0]: od volt: Data (usually from reading a file) was not of the type that was expected:
======================= ROCm System Management Interface =======================
========================= Version of System Component ==========================
Driver version: 5.17.0
================================================================================
====================================== ID ======================================
GPU[0]		: GPU ID: 0x73bf
================================================================================
================================== Unique ID ===================================
GPU[0]		: Unique ID: N/A
================================================================================
==================================== VBIOS =====================================
GPU[0]		: VBIOS version: 113-D4120100-100
================================================================================
================================= Temperature ==================================
GPU[0]		: Temperature (Sensor edge) (C): 52.0
GPU[0]		: Temperature (Sensor junction) (C): 57.0
GPU[0]		: Temperature (Sensor memory) (C): 58.0
GPU[0]		: Temperature (Sensor HBM 0) (C): N/A
GPU[0]		: Temperature (Sensor HBM 1) (C): N/A
GPU[0]		: Temperature (Sensor HBM 2) (C): N/A
GPU[0]		: Temperature (Sensor HBM 3) (C): N/A
================================================================================
========================== Current clock frequencies ===========================
GPU[0]		: dcefclk clock level: 1: (960Mhz)
GPU[0]		: fclk clock level: 1: (1296Mhz)
GPU[0]		: mclk clock level: 3: (1000Mhz)
GPU[0]		: sclk clock level: 0: (500Mhz)
GPU[0]		: socclk clock level: 1: (800Mhz)
GPU[0]		: pcie clock level: 1 (16.0GT/s x16)
================================================================================
============================== Current Fan Metric ==============================
GPU[0]		: Fan Level: 63 (25%)
GPU[0]		: Fan RPM: 570
================================================================================
============================ Show Performance Level ============================
GPU[0]		: Performance Level: auto
================================================================================
=============================== OverDrive Level ================================
GPU[0]		: GPU OverDrive value (%): 0
================================================================================
=============================== OverDrive Level ================================
GPU[0]		: GPU Memory OverDrive value (%): 0
================================================================================
================================== Power Cap ===================================
GPU[0]		: Max Graphics Package Power (W): 293.0
================================================================================
============================= Show Power Profiles ==============================
GPU[0]		: 1. Available power profile (#1 of 7): CUSTOM
GPU[0]		: 2. Available power profile (#2 of 7): VIDEO
GPU[0]		: 3. Available power profile (#3 of 7): POWER SAVING
GPU[0]		: 4. Available power profile (#4 of 7): COMPUTE
GPU[0]		: 5. Available power profile (#5 of 7): VR
GPU[0]		: 6. Available power profile (#6 of 7): 3D FULL SCREEN
GPU[0]		: 7. Available power profile (#7 of 7): BOOTUP DEFAULT*
================================================================================
============================== Power Consumption ===============================
GPU[0]		: Average Graphics Package Power (W): 38.0
================================================================================
========================= Supported clock frequencies ==========================
GPU[0]		: Supported dcefclk frequencies on GPU0
GPU[0]		: 0: 417Mhz
GPU[0]		: 1: 960Mhz *
GPU[0]		: 2: 1200Mhz
GPU[0]		:
GPU[0]		: Supported fclk frequencies on GPU0
GPU[0]		: 0: 500Mhz
GPU[0]		: 1: 1296Mhz *
GPU[0]		: 2: 1941Mhz
GPU[0]		:
GPU[0]		: Supported mclk frequencies on GPU0
GPU[0]		: 0: 96Mhz
GPU[0]		: 1: 456Mhz
GPU[0]		: 2: 673Mhz
GPU[0]		: 3: 1000Mhz *
GPU[0]		:
GPU[0]		: Supported sclk frequencies on GPU0
GPU[0]		: 0: 500Mhz *
GPU[0]		: 1: 2660Mhz
GPU[0]		:
GPU[0]		: Supported socclk frequencies on GPU0
GPU[0]		: 0: 480Mhz
GPU[0]		: 1: 800Mhz *
GPU[0]		: 2: 1200Mhz
GPU[0]		:
GPU[0]		: Supported PCIe frequencies on GPU0
GPU[0]		: 0: 2.5GT/s x1
GPU[0]		: 1: 16.0GT/s x16 *
GPU[0]		:
--------------------------------------------------------------------------------
================================================================================
============================== % time GPU is busy ==============================
GPU[0]		: GPU use (%): 0
GPU[0]		: GFX Activity: N/A
================================================================================
============================== Current Memory Use ==============================
GPU[0]		: GPU memory use (%): 11
GPU[0]		: Memory Activity: N/A
================================================================================
================================ Memory Vendor =================================
GPU[0]		: GPU memory vendor: samsung
================================================================================
============================= PCIe Replay Counter ==============================
GPU[0]		: PCIe Replay Count: 0
================================================================================
================================ Serial Number =================================
GPU[0]		: Serial Number: N/A
================================================================================
================================ KFD Processes =================================
No KFD PIDs currently running
================================================================================
============================= GPUs Indexed by PID ==============================
No KFD PIDs currently running
================================================================================
================== GPU Memory clock frequencies and voltages ===================
ERROR: 15 GPU[0]: od volt: Data (usually from reading a file) was not of the type that was expected
================================================================================
=============================== Current voltage ================================
GPU[0]		: Voltage (mV): 775
================================================================================
================================== PCI Bus ID ==================================
GPU[0]		: PCI Bus: 0000:2F:00.0
================================================================================
============================= Firmware Information =============================
GPU[0]		: ASD firmware version: 	553648218
GPU[0]		: CE firmware version: 		36
GPU[0]		: DMCU firmware version: 	0
GPU[0]		: MC firmware version: 		0
GPU[0]		: ME firmware version: 		62
GPU[0]		: MEC firmware version: 	88
GPU[0]		: MEC2 firmware version: 	88
GPU[0]		: PFP firmware version: 	86
GPU[0]		: RLC firmware version: 	91
GPU[0]		: RLC SRLC firmware version: 	0
GPU[0]		: RLC SRLG firmware version: 	0
GPU[0]		: RLC SRLS firmware version: 	0
GPU[0]		: SDMA firmware version: 	76
GPU[0]		: SDMA2 firmware version: 	76
GPU[0]		: SMC firmware version: 	<IP_ADDRESS>
GPU[0]		: SOS firmware version: 	0x00210862
GPU[0]		: TA RAS firmware version: 	<IP_ADDRESS>
GPU[0]		: TA XGMI firmware version: 	<IP_ADDRESS>
GPU[0]		: UVD firmware version: 	0x00000000
GPU[0]		: VCE firmware version: 	0x00000000
GPU[0]		: VCN firmware version: 	0x0210d02a
================================================================================
================================= Product Info =================================
GPU[0]		: Card series: 		Navi 21 [Radeon RX 6800/6800 XT / 6900 XT]
GPU[0]		: Card model: 		Radeon RX 6900 XT
GPU[0]		: Card vendor: 		Advanced Micro Devices, Inc. [AMD/ATI]
GPU[0]		: Card SKU: 		D41201
================================================================================
================================== Pages Info ==================================
ERROR: 2 GPU[0]: ras: RSMI_STATUS_NOT_SUPPORTED: This function is not supported in the current environment.
============================ Show Valid sclk Range =============================
ERROR: 15 GPU[0]: od volt: Data (usually from reading a file) was not of the type that was expected
GPU[0]		: Unable to display sclk range
================================================================================
============================ Show Valid mclk Range =============================
ERROR: 15 GPU[0]: od volt: Data (usually from reading a file) was not of the type that was expected
GPU[0]		: Unable to display mclk range
================================================================================
=========================== Show Valid voltage Range ===========================
ERROR: 15 GPU[0]: od volt: Data (usually from reading a file) was not of the type that was expected
GPU[0]		: Unable to display voltage range
================================================================================
============================= Voltage Curve Points =============================
ERROR: 15 GPU[0]: od volt: Data (usually from reading a file) was not of the type that was expected
GPU[0]		: Voltage Curve is not supported
================================================================================
=============================== Consumed Energy ================================
GPU[0]		: Energy counter: 188012754
GPU[0]		: Accumulated Energy (uJ):<PHONE_NUMBER>.06
================================================================================
WARNING:  		 One or more commands failed
============================= End of ROCm SMI Log ==============================

ROCk module is loaded
=====================
HSA System Attributes
=====================
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE
System Endianness:       LITTLE

==========
HSA Agents
==========
*******
Agent 1
*******
  Name:                    AMD Ryzen 9 5900X 12-Core Processor
  Uuid:                    CPU-XX
  Marketing Name:          AMD Ryzen 9 5900X 12-Core Processor
  Vendor Name:             CPU
  Feature:                 None specified
  Profile:                 FULL_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        0(0x0)
  Queue Min Size:          0(0x0)
  Queue Max Size:          0(0x0)
  Queue Type:              MULTI
  Node:                    0
  Device Type:             CPU
  Cache Info:
    L1:                      32768(0x8000) KB
  Chip ID:                 0(0x0)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   5034
  BDFID:                   0
  Internal Node ID:        0
  Compute Unit:            24
  SIMDs per CU:            0
  Shader Engines:          0
  Shader Arrs. per Eng.:   0
  WatchPts on Addr. Ranges:1
  Features:                None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: FINE GRAINED
      Size:                    32861432(0x1f56cf8) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 2
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    32861432(0x1f56cf8) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 3
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    32861432(0x1f56cf8) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
  ISA Info:
*******
Agent 2
*******
  Name:                    gfx1030
  Uuid:                    GPU-XX
  Marketing Name:          AMD Radeon RX 6900 XT
  Vendor Name:             AMD
  Feature:                 KERNEL_DISPATCH
  Profile:                 BASE_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        128(0x80)
  Queue Min Size:          4096(0x1000)
  Queue Max Size:          131072(0x20000)
  Queue Type:              MULTI
  Node:                    1
  Device Type:             GPU
  Cache Info:
    L1:                      16(0x10) KB
    L2:                      4096(0x1000) KB
    L3:                      131072(0x20000) KB
  Chip ID:                 29631(0x73bf)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   2660
  BDFID:                   12032
  Internal Node ID:        1
  Compute Unit:            80
  SIMDs per CU:            2
  Shader Engines:          8
  Shader Arrs. per Eng.:   2
  WatchPts on Addr. Ranges:4
  Features:                KERNEL_DISPATCH
  Fast F16 Operation:      TRUE
  Wavefront Size:          32(0x20)
  Workgroup Max Size:      1024(0x400)
  Workgroup Max Size per Dimension:
    x                        1024(0x400)
    y                        1024(0x400)
    z                        1024(0x400)
  Max Waves Per CU:        32(0x20)
  Max Work-item Per CU:    1024(0x400)
  Grid Max Size:<PHONE_NUMBER>(0xffffffff)
  Grid Max Size per Dimension:
    x<PHONE_NUMBER>(0xffffffff)
    y<PHONE_NUMBER>(0xffffffff)
    z<PHONE_NUMBER>(0xffffffff)
  Max fbarriers/Workgrp:   32
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    16760832(0xffc000) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Accessible by all:       FALSE
    Pool 2
      Segment:                 GROUP
      Size:                    64(0x40) KB
      Allocatable:             FALSE
      Alloc Granule:           0KB
      Alloc Alignment:         0KB
      Accessible by all:       FALSE
  ISA Info:
    ISA 1
      Name:                    amdgcn-amd-amdhsa--gfx1030
      Machine Models:          HSA_MACHINE_MODEL_LARGE
      Profiles:                HSA_PROFILE_BASE
      Default Rounding Mode:   NEAR
      Default Rounding Mode:   NEAR
      Fast f16:                TRUE
      Workgroup Max Size:      1024(0x400)
      Workgroup Max Size per Dimension:
        x                        1024(0x400)
        y                        1024(0x400)
        z                        1024(0x400)
      Grid Max Size:<PHONE_NUMBER>(0xffffffff)
      Grid Max Size per Dimension:
        x<PHONE_NUMBER>(0xffffffff)
        y<PHONE_NUMBER>(0xffffffff)
        z<PHONE_NUMBER>(0xffffffff)
      FBarrier Max Size:       32
*** Done ***

I have the same issue but with the RX 6700s (cpu is r7 6800HS)
OpenSuse Tumbleweed, kernel 5.19
ROCm 5.2.3
I have set the same boot parameter in grub and still get same error, the maximum memory clock I can set is 875Mhz

@aligirayhanozbay Hi, is your issue resolved in the latest ROCm? If so can we close this ticket?

Closing the ticket as no response from @aligirayhanozbay.  Please re-open if this issue still exists with latest ROCm 6.0.2.  Thanks.


CAN Address Claiming

Related to #112, we will need to claim an address on the CAN bus in order to query for information. This will have to disable the listen-only mode that we currently use
Mentioned by @aultac on 1/22/21 meeting but has been a known issue for a while now
Questions/roadblocks

Is there a time restriction to claim an address? If we startup slow, can we still claim?
Autobaudrate detection - how can we ensure that we are on the right baud rate?
We need to be absolutely sure we don't crash the bus or cause other issues

Thanks @aaron97neu for recalling the blockers. We should start by seeing if we have address claims in the logs.
we should be able to claim our address at any time.
However, autobaud detection will make it even more likely we miss address claims.

Thanks @aaron97neu for recalling the blockers. We should start by seeing if we have address claims in the logs.
we should be able to claim our address at any time.
However, autobaud detection will make it even more likely we miss address claims.

I remember hearing that newer CAN chips has build in auto-baud-rate detection. Is that correct and something we can feasibly integrate with the avenashield? Unsure how quick it is, but a hardware chip should theoretically be able to detect the rate by the first few bits, right?

I remember hearing that newer CAN chips has build in auto-baud-rate detection. Is that correct and something we can feasibly integrate with the avenashield? Unsure how quick it is, but a hardware chip should theoretically be able to detect the rate by the first few bits, right?

You might be able to exploit the fact that you’ll be starting up most of the time in the same tractor, so the most likely baud speed is the one you had last time you turned on?  i.e. ISOBlue deployment just involves starting the tractor twice?  Just a thought.
Aaron

On Jan 22, 2021, at 10:34 AM, Andrew Balmos<EMAIL_ADDRESS>wrote:
Thanks @aaron97neu https://github.com/aaron97neu for recalling the blockers. We should start by seeing if we have address claims in the logs.
we should be able to claim our address at any time.
However, autobaud detection will make it even more likely we miss address claims.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/oats-center/isoblue-avena/issues/113#issuecomment-765489063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2KEUH3EIF7K2HTYZL437TS3GLJ5ANCNFSM4WOUV3VQ.

You might be able to exploit the fact that you’ll be starting up most of the time in the same tractor, so the most likely baud speed is the one you had last time you turned on?  i.e. ISOBlue deployment just involves starting the tractor twice?  Just a thought.
Aaron

On Jan 22, 2021, at 10:34 AM, Andrew Balmos<EMAIL_ADDRESS>wrote:
Thanks @aaron97neu https://github.com/aaron97neu for recalling the blockers. We should start by seeing if we have address claims in the logs.
we should be able to claim our address at any time.
However, autobaud detection will make it even more likely we miss address claims.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/oats-center/isoblue-avena/issues/113#issuecomment-765489063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2KEUH3EIF7K2HTYZL437TS3GLJ5ANCNFSM4WOUV3VQ.

@aaron97neu Maybe. I don't see any support for that in SocketCAN, but maybe it is coming if hardware is starting to support it.

@aaron97neu Maybe. I don't see any support for that in SocketCAN, but maybe it is coming if hardware is starting to support it.

@aultac I was thinking that as well, same if we missed the address claiming once in a while. Deploying an isoblue currently involves a few power cycles to ensure things are working fine
The issue is the logs for the first/last power cycle of any deployment could be considered unreliable as it might not have realized it is on a new machiene. How terrible that is depends on how we use them and how we deploy them

@aultac I was thinking that as well, same if we missed the address claiming once in a while. Deploying an isoblue currently involves a few power cycles to ensure things are working fine
The issue is the logs for the first/last power cycle of any deployment could be considered unreliable as it might not have realized it is on a new machiene. How terrible that is depends on how we use them and how we deploy them

@aultac The problem is having it wrong at all breaks the machine badly. If we assume it was the same as last time, then it might  break the next machine when IB is moved. At Cyrus "break" means persistent errors even after IB was disconnected and the machine was restarted. We had to flip the battery switch to get monitor back in working order and we had a calm and collected, but concerned farmer/father.

@aultac The problem is having it wrong at all breaks the machine badly. If we assume it was the same as last time, then it might  break the next machine when IB is moved. At Cyrus "break" means persistent errors even after IB was disconnected and the machine was restarted. We had to flip the battery switch to get monitor back in working order and we had a calm and collected, but concerned farmer/father.

@abalmos iirc the software based auto-baud rate detection is done by being in listen-only mode and cycling through known/guessed baud rated until we start receiving data
I assume that if we were to use @aultac 's idea we would use the last good baud rate as the first guess but still be in listen-only mode. If we are wrong, we cause no issues and just move on to the next guess (losing data in the meantime). If we are correct, we get data quickly but still may lose some switching out of read-only mode

@abalmos iirc the software based auto-baud rate detection is done by being in listen-only mode and cycling through known/guessed baud rated until we start receiving data
I assume that if we were to use @aultac 's idea we would use the last good baud rate as the first guess but still be in listen-only mode. If we are wrong, we cause no issues and just move on to the next guess (losing data in the meantime). If we are correct, we get data quickly but still may lose some switching out of read-only mode

@aaron97neu That's true, that may work. You might have to bring the interface up and down to change the listen-only flag--but I could be recalling that wrong?
We can start by checking for address claims in our current logs. If we don't see them in Cyrus' data, then IB takes too long to start-up. That is a much harder problem to overcome.

@aaron97neu That's true, that may work. You might have to bring the interface up and down to change the listen-only flag--but I could be recalling that wrong?
We can start by checking for address claims in our current logs. If we don't see them in Cyrus' data, then IB takes too long to start-up. That is a much harder problem to overcome.

Agreed. Will be interesting to see. We need to make sure to differentiate between machines that remove power to the isoblue on key off and those that don't @facastiblancor
If we can query for the machine identification data, it would make things easier. Any way to find this out?

Agreed. Will be interesting to see. We need to make sure to differentiate between machines that remove power to the isoblue on key off and those that don't @facastiblancor
If we can query for the machine identification data, it would make things easier. Any way to find this out?


Only guesses maps when all columns have been analysed

Closes #4307
This allows for full implementation of the decision trees, by gaining access to the analyses obtained from all columns.
CR @javierarce please? ;)
cc @javisantana @saleiva

Frontend tests were OK :+1: (details)

I think we could use the this.columns collection to bind the change:analyzed event and launch the analysis instead of using an array.
Have a look to the _onChangeColumns method here: https://github.com/CartoDB/cartodb/blob/4307-postguess/lib/assets/javascripts/cartodb/common/dialogs/pecan/pecan_view.js#L128

That makes a lot of sense, hadn't noticed that binding!

Frontend tests were OK :+1: (details)

Merged manually to 4299-pecan-fixes, thanks!


Improve styles for user avatar alt texts

Resolves #171

Nice one, @Loilo!
I just think you missed the prefix on the CSS side of things, so I suggested the changes!
As soon as you finish this, I'll test the extension!
Cheers!

Okay, b992200 should do it. 😁

Seems fine to me! Great job, @Loilo!

My pleasure. 🙂


Not Using port 22

I don't use port 22 for SSH on the remote machine where the script is located and will run. Is there a way to configure for different ports?

Component support port param. Just not in docs

Component support port param. Just not in docs

Thank you 🙏


为所有小部件API文档增加[]包裹

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Docs have been added / updated (for bug fixes / features)

[x] The commit message follows our guidelines: https://github.com/cipchk/delon/blob/master/CONTRIBUTING.md#commit

[x] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:提高小部件的文档阅读性

What is the current behavior?

为小部件API文档增加  [] 包裹
方便开发者更清晰的阅读文档
被修改小部件列表:

名称

upload

transfer

time

textarea

text

tag

string

slider

select

rate

radio

object

number

mention

date

custom

checkbox

cascader

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

非常感谢，但 https://github.com/cipchk/delon/pull/101 已经有了。


Can't start Lavalink because of UnsupportedClassVersion Error

Description

So I tried to start lavalink but I have this error:
Caused by: java.lang.UnsupportedClassVersionError: lavalink/server/info/AppInfo has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
I installed the newest version of java but It still isn't working. I reinstalled Java but still nothing.
Version info
Client used:
Output of java -version:
java version "1.8.0_251"
Java(TM) SE Runtime Environment (build 1.8.0_251-b08)
Java HotSpot(TM) Client VM (build 25.251-b08, mixed mode)

I can't provide log and version because of error.

Java 8 is not supported. Update to Java 13.
Duplicate of #249 and #266

I know that, but where is Java 13 JRE? I can't find it.

That depends on your system. This issue tracker is not the place to seek general help with Java. Try asking in our Discord channel.
https://discord.gg/jtAWrzU


Update project to latest Godot master, convert materials to tres, replace OBJ with GLB

The first commit converts the project to the latest Godot master and updates the gitignore file. The second commits converts the materials to tres, which saves us about 100 KB and is better for version control. The third commit places the OBJ file with a GLB file, so that we only need one file (no MTL), moves it into a subfolder, and I also tweaked the mesh to reduce its file size and fill in some holes outside the play area. The fourth commit tweaks the camera script and simplifies it.
Bugsquad edit: This closes #3.

Pinging @Calinou :)


Add support to cluster stats API for enabling/disabling mapping_stats…

… and analysis_stats at request level.

Description
Continuing on https://github.com/opensearch-project/OpenSearch/pull/14447 to make analysis_stats and mapping_stats information optional in _cluster/stats API but limiting the scope to request level only. Two request params namely include_mapping_stats and include_analysis_stats has been introduced to enable/disable these stats info from the cluster stats API. By default these stats info will be part of the API response.
REST request formats to exclude the information for

analysis_stats  -  localhost:9200/_cluster/stats?include_mapping_stats=false
mapping_stats - localhost:9200/_cluster/stats?include_analysis_stats=false
analysis_stats and mapping_stats -   localhost:9200/_cluster/stats?include_analysis_stats=false&include_mapping_stats=false

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
https://github.com/opensearch-project/OpenSearch/pull/14447
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for edc3eae: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test https://github.com/opensearch-project/OpenSearch/pull/15204


Adapt to upstream ycmd changes

The BufferUnload event uses now filepath from request data instead
of unloaded_buffer parameter.
See https://github.com/Valloric/ycmd/pull/542

Upstream PR has been merged.


Fixes for documentation generator

Before/after:

How can I reproduce this problem? I tried the link in File, using Chrome and it seems to be working well.
I wouldn't remove the tags, I would instruct the method not to generate them in the first place (just in case that regex removes more than it should)

@asterite Hmm that was in Firefox but somehow I can't full reproduce this today???
Anyway, at least the final bracket is cut off, in both Firefox and Chrome
About removing the tags - you know how there is that links = true / links: links flag passed around everywhere? Well, another flag would have to join it, which is a real mess and I think it's not worth bothering. At first I thought I could just turn this links = true into a html = false but there are instances where some HTML is needed but not links.
The regex can't remove more than it should because non-tag brackets must already be <``> at that point anyway.

I think links can be replaced with html. Where would be the place where links = false but html = true?
(we could just merge this, but lately I'm trying to justify all code changes and come up with the best "correct" solution for everything)

In Class Method Summary, HTML is there for colors but links are not present.

@BlaXpirit Oh, right... Well, for now it's much easier to just remove the tags in that place, so let's do that.


[move-cli] Added "docgen" command

Move Prover's --docgen switch is not currently exposed to the user, so added a top level command docgen to do the trick.
Move Prover is also mentioned in the description, so the user knows they must have a working Move Prover setup in order to use this feature.
Also added a smoketest for the docgen command so it would not break because of a regression. A non-existent subcommand smoketest is intentionally used so the output has as little variable output as possible.
Motivation
Move Prover's --docgen switch is not currently exposed to the user, so added a top level command docgen to do the trick.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
In addition to the smoke test (cargo test -p move-cli) you can test the actual documentation generation by running:
cargo build -p move-cli
./target/debug/move --path ./language/documentation/tutorial/step_8/BasicCoin docgen

You should get something like:
[INFO] generating documentation
[INFO] Module `0xcafe::BasicCoin` in file `doc/BasicCoin.md` will be generated
[INFO] 0.148s checking, 0.075s generating

And then you should have the final generated markdown documentation at ./language/documentation/tutorial/step_8/BasicCoin/doc/BasicCoin.md.
(In order to use the docgen you must have a working Move Prover, verify this by running ./target/debug/move --path ./language/documentation/tutorial/step_8/BasicCoin prove)

Because I can't add reviewers, asking review from my mentors @awelc and @tnowacki this way :memo:

I believe the same functionality can be achieved with build --generate-docs?

It is not unreasonable to make this it's own command though.

@tnowacki Unfortunately build --generate-docs doesn't exist anymore, and --docs is a no-op. --docs is burried so deeply in move-cli that it would need another PR to remove, and that would be logically separate from this change (there seems to be a lot of logic behind the switch, despite being effectively a no-op). I can work on such a PR if this gets merged (rendering --docs obsolete)

@tnowacki Unfortunately build --generate-docs

@tnowacki I get:
move build --generate-docs
error: Found argument '--generate-docs' which wasn't expected, or isn't valid in this context

	If you tried to supply `--generate-docs` as a value rather than a flag, use `-- --generate-docs`

USAGE:
    move build [OPTIONS]

For more information try --help

Looks like it is move build --doc no s, go figure.
I agree though it's rather buried, and a top level command would be nice. Especially since it took me a while to get the thing working at all lol
I'll take a deeper look at the PR later today

@tnowacki Good points! My takes:

Do you mean adding more tests?
(commented on the review comment)
I would vote for removing, but in another PR: to me --docs seems to be burried so deeply in move-cli that it would need another PR to remove, and that would be logically separate from this change (there seems to be a lot of logic behind the switch, despite being effectively a no-op). But I can gladly work on such a PR if this gets merged, and renders --docs obsolete.

Yes, it seems there are no tests that actually run it?

works for me :)

@tnowacki Added an actual test and --template (exposing --docgen-template to the user, which is currently the only switch exposed by the Prover)  :slightly_smiling_face: While I think move docgen should eventually use Docgen:: instead of Prove:: (and hence expose all the other options to the user), currently I see this current approach being the fastest way to fix Docgen for the regular user. I can start working next on a proper Docgen:: implementation of docgen.

@tnowacki Added an actual test and --template (exposing --docgen-template to the user, which is currently the only switch exposed by the Prover) 🙂 While I think move docgen should eventually use Docgen:: instead of Prove:: (and hence expose all the other options to the user), currently I see this current approach being the fastest way to fix Docgen for the regular user. I can start working next on a proper Docgen:: implementation of docgen.

This seems like a fair approach, thanks for the explanation!
Just a comment on the test, then I think this should be good to go!

@tnowacki Great! :partying_face: The test is now fixed, and is using cat instead of grep which makes sense :+1:

Thanks again for this!


Water tracking

Describe the feature you'd like
A clear and concise description of what you want to happen and why.
Additional context
Add any other context or screenshots about the feature request here.

Closed by commit 7b3a0d1b4279c59fae7e6043b033656e9b58aeb2


added numpy compatibility for BMS predict method

Description
Added numpy functionality in predict method of BMS. This is necessary for BMS to work in the cycle with the popper experimentalist.
Type of change:

Bug fix (non-breaking change which fixes an issue)

Features:

checks for numpy input and converts to pandas dataframe

also, while tests are passing, workflow checks are not (again)...

also, while tests are passing, workflow checks are not (again)...

Yeah, it seems so. Not sure how to address that... Perhaps ignore them for now since those are not related to the change? @hollandjg

all tests passing and overall this looks good to me! i have just one question: does this change merit writing another test in which predict is initially passed a numpy array? or would that be redundant given the structure and purpose of our existing mcmc test? looks like that test exclusively uses a dataframe, so just curious for completeness purposes...

I don't think it's necessary since the change is quite straightforward. It would have made sense if there were more mcmc tests already but since it is just one, it might not be worth duplicating that with a numpy input instead of a df....

sounds

all tests passing and overall this looks good to me! i have just one question: does this change merit writing another test in which predict is initially passed a numpy array? or would that be redundant given the structure and purpose of our existing mcmc test? looks like that test exclusively uses a dataframe, so just curious for completeness purposes...

I don't think it's necessary since the change is quite straightforward. It would have made sense if there were more mcmc tests already but since it is just one, it might not be worth duplicating that with a numpy input instead of a df....

good deal, approved then!


More descriptive error voting for >10 val groups

Feature Description
The limit is 10: https://github.com/celo-org/celo-monorepo/blob/master/packages/protocol/contracts/governance/Election.sol#L260
The current error is unclear (generic tx error)

So by more descriptive you mean concatenate the number after the msg? Something like: "Voted for too many groups, please limit number of groups to 10(let's say)"?

So by more descriptive you mean concatenate the number after the msg, the limit being maxNumGroupsVotedFor? Something like: "Voted for too many groups, please limit number of groups to 10(let's say)"?

Yeah something like that. We should add a condition in the validate method to catch this even before the user attempts the tx: https://github.com/celo-tools/celo-web-wallet/blob/master/src/features/validators/stakeToken.ts#L39


Fix issue with abstract classes

The getEntityClasses() method of SettingsCommand also return the class Gedmo\Tree\Entity\MappedSuperclass\AbstractClosure.
This is because I use the Gedmo\Tree extension. This class is abstract and so, cannot be instanciated.
The ``discoverEntity() does not take care of abstract classes anymore, which can be usefull for other weird cases.

@gregquat thanks


[Feature Request] Configurable search prefixes

If this issue is related to compatibility with other mods, such as missing recipes, make sure to follow these steps before reporting

[N/A] Make sure the recipe exists in game and can be crafted
[YES] If the mod requires JEI, make sure both EMI and JEI are installed together
[NO] Report this issue to the mod if applicable

I agree that # for tag and $ for text makes more sense, but the standard has been $ = tag, # = text for so long.
Please give us a config option to change it for compatibility with synchronized search terminal mods like AE2, Integrated Dynamics (Integrated Terminals), etc
I searched quite a bit on google, curseforge comments, github and config files of both EMI and AE2, so forgive me if I missed something.

I just found out that if you select "use EMI" on the AE2 terminal settings, it will relay the search filter directly from EMI, circumventing the issue but I still think there should still be an override option in EMI for compatibility and consistency.


Finish unit tests for the validating webhook

https://github.com/metal3-io/ironic-standalone-operator/pull/66 adds some tests, more are needed (cover DHCP, database logic, etc).
/triage accepted
/help

/assign


Create NewApp

Pre-Submission Checklist

[ ] Your pull request targets the staging branch of FreeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ ] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@tbenterprises, if this is a legitimate pull request, please reopen with the correct changes.


HasMany Fieldtype

Description

This pull request introduces a new HasMany fieldtype to Runway, built on the foundation of the BelongsTo fieldtype.

To Do

[X] Build out the get/save flow
[X] Ensure augmentation works as expected
[ ] Investigate the possibly of editing related models in stacks
[ ] Fix fieldtype's 'index' display (currently displays nothing)
[ ] Write tests
[x] Write documentation

Related Issues

Closes #70 and closes #73

For my reference later: looks like the reason the index is not working is because it's never being called. See https://github.com/doublethreedigital/runway/blob/feature/has-many-fieldtype/src/Http/Resources/ResourceCollection.php#L61

Merged - I've missed out the stack functionality as it's a tad harder to do and I'm not quite sure how that bit works yet...


Prioritize loading blocks in the view frustum

Right now, we load blocks in cubic layers around the player. We should prioritize the ones (roughly) inside the view frustum.

Closing for now; things load quickly enough, and this adds overhead.


Thank you for bringing this up!

These appear to be fixed, so closing the issue. Thanks!


Unable to execute JMX on Non GUI in Ubuntu

Expected behavior
JMX to run on ubuntu on
Jmeter 5.5
Openjdk version "11.0.20" 2023-07-18
OpenJDK Runtime Environment (build 11.0.20+8-post-Ubuntu-1ubuntu120.04)
OpenJDK 64-Bit Server VM (build 11.0.20+8-post-Ubuntu-1ubuntu120.04, mixed mode, sharing)
javac 11.0.20
Machine(VM) Configuration:
NAME="Ubuntu"
VERSION="20.04.5 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.5 LTS"
VERSION_ID="20.04"
HOME_URL=https://www.ubuntu.com/
SUPPORT_URL=https://help.ubuntu.com/
BUG_REPORT_URL=https://bugs.launchpad.net/ubuntu/
PRIVACY_POLICY_URL=https://www.ubuntu.com/legal/terms-and-policies/privacy-policy
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
Actual behavior
Error Seen:
($User)@perf-test-instance-0:~/apache-jmeter-5.5/bin$ jmeter -n -t /home/($User)/ )/{$Test.jmx}
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.thoughtworks.xstream.core.util.Fields (file:/usr/share/java/xstream.jar) to field java.util.TreeMap.comparator
WARNING: Please consider reporting this to the maintainers of com.thoughtworks.xstream.core.util.Fields
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Error in NonGUIDriver java.lang.IllegalArgumentException: Problem loading XML from:'/home/($User)/{$Test.jmx}’, conversion error com.thoughtworks.xstream.converters.ConversionException:
---- Debugging information ----
cause-exception     : com.thoughtworks.xstream.converters.ConversionException
cause-message       :
first-jmeter-class  : org.apache.jmeter.save.converters.TestElementConverter.unmarshal(TestElementConverter.java:109)
class               : org.apache.jmeter.save.ScriptWrapper
required-type       : org.apache.jmeter.save.ScriptWrapper
converter-type      : org.apache.jmeter.save.ScriptWrapperConverter
path                : /jmeterTestPlan/hashTree/hashTree/hashTree[9]/ResultCollector/objProp/value/sentBytes
line number         : 5425
version             : 2.13.20180731
Steps to reproduce the problem

Write a JMX file
Upload in Ubuntu
Make sure system matches to config mentioned above(In Expected)
Run "jmeter -n -t <testfile.jmx> "

JMeter Version
5.5
Java Version
11.0.20
OS Version
Ubuntu "20.04.5 LTS (Focal Fossa)"

Yes those are data which i renamed intentionally  to save PII. I do have the valid data running when hitting those commands.

OK, so I assume, that you can open the same file in GUI mode?
If so, can you look at that file at line number 5425? Is there (or a line above) something related to "sentBytes"?
Are there any more error messages in jmeter.log?


v4.20.0 consumes noticeably more RAM than v4.19.12

Describe the bug
Using steam-user v4.19.12 my application consumes around 97MB RAM but after updating steam-user to v4.20.0 this RAM usage shoots up to around 190MB. Both values stay around the same during the lifetime of the application, so the Garbage Collector doesn't seem to clean anything up that would bring both values closer together again.
I can reproduce this behavior back to back, just by installing the other version using npm. The code didn't change during testing.
This issue isn't really that noticeable on a desktop machine but annoying on a smaller machine (like a Raspberry Pi) with more limited resources.
Versions
Tested with node.js v16.10.0 (latest) and v14.17.6 (LTS)
OS: Arch Linux (Kernel: 5.14.8-zen1-1-zen)

Alright, I quickly went through the commit history between v4.19.12 and v4.20.0.
I can still observe the old RAM usage with commit c6f975e but starting with the next commit, 21a77bd, the RAM usage increased.


Experimental debugger wont stop on breakpoints when debugging testcases in async-await code

Environment data

VS Code version: 1.25.0
Extension version (available under the Extensions sidebar): 2018.6.0 (20 June 2018)
OS and version: Kubuntu 17.10, Linux 4.13.0-46
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv
Relevant/affected Python packages and their versions: unittest, pytest, trio, asyncio

Actual behavior
Running a test on an async function running, the debugger won't stop on breakpoints inside async functions. Tried with both unittest and pytest. Originally tested with trio event loop but the problem also occurs with asyncio, so it is not event loop specific.
It looks as if the execution stops, but you don't get an indication at all, no yellow line on the breakpoint, no stack trace, no variable inspection and shortly after the test seems to crash.

Expected  behavior
Debugger stops on breakpoint inside async function.
Steps to reproduce:
Test code using pytest:
def test_content(response):
    """Sample pytest test function with the pytest fixture as an argument."""
    # from bs4 import BeautifulSoup
    # assert 'GitHub' in BeautifulSoup(response.content).title.string
    async def test_something_async():
        assert 1 == 2

    trio.run(test_something_async)

I set the breakpoint on the assert line, like in the screenshot above.
Logs
Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
============================= test session starts ==============================
platform linux -- Python 3.6.3, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /home/andersa/python/realtime_data, inifile: setup.cfg

collecting 1 item
collected 1 item
tests/test_realtime_data.py

May be similar to #2093

Originally reported this for the Trio event loop, but on further testing it doesn't work with asyncio either.

Hi @andersea, thanks for the report. I cannot seem to reproduce this failure. Could you please send along your launch.json file so I can see how you've set the test-debugging run?

I've tested this with the latest PTVSD (master), and it works as expected.
Will leave it open until a new version of PTVSD is released.

Hi, I have seen your replies. Thanks for looking into it. I will be really busy the next day or two, so it will be hard for me to get the time to add more info. I have tried several times with several different methods to get debugging in test cases to work, and no matter what I try it just doesn't work.
As soon as I get a few moments I will try to make a detailed step by step guide to what I am doing. Since you all can get it to work, I must be doing something different than you.

@andersea

I must be doing something different than you.

You do not have the latest development version of the debugger. That's why it  works at my end and not yours. So, there's nothing you'll have to do at this stage, but wait for the next release with a new debugger. Will get back to you when it does happen.

Ok! Standing by!

@andersea
Please could you test this with the latest version of the extension.
Please ensure you are using the experimental debugger.
All you need to do is go into the .vscode/launch.json file and change the setting from "type":"python" to "type":"pythonExperimental"


can not fall back to TCP in case of truncation

i do not find example in case of TCP query，because in cast of truncation,can not fall back to TCP。how to use  Exchange performs a synchronous TCP query.

https://github.com/miekg/exdns/blob/master/q/q.go might contain ponters


[5.5] Add the mix function to not localhost host support

Wrong branch. Would go to 5.4.

Also needs full description.


NetCore LtiRequest.CheckForRequiredLtiParameters lis_outcome_service_url being validated in error

I am new to LTI stuff, so I apologize in advance if I misunderstand something.
When I use your ConsumerCertification project in your LtiSamples solution, and I use the default CustomParameters when I use the Instructor Link 2 it throws an exception from the below method stating that lis_result_sourcedid is required. Your code is setup as such that if lis_outcome_service_url is not null or empty, then lis_result_sourcedid is required.
In the 1.1 implementation guide, (section 6)[https://www.imsglobal.org/specs/ltiv1p1/implementation-guide#toc-6], it talks about these two fields. I don't see anything about lis_result_sourcedid being required if the lis_outcome_service_url is provided. As a matter of fact, it seems to say that if lis_outcome_service_url is required if the TC accepts outcomes, and that regardless of whether or not the lis_result_sourcedid is provided. I do see a case for the reverse where if a lis_result_sourcedid is provided then the lis_outcome_service_url` is required
Therefore, if I understand, correctly it seems the below check should not be occurring where it requires lis_result_sourcedid if there is a `lis_outcome_service_url', and it probably should be reversed.
The method in question:
LtiLibrary.NetCore.Lti.v1.LtiRequest.CheckForRequiredLtiParameters

The code in question
// If the request is configured to support Outcomes 1.0, make sure lis_result_sourcedid is specified
if (!string.IsNullOrWhiteSpace(LisOutcomeServiceUrl))
{
    RequireAllOf(RequiredOutcomes1Parameters);
}

Update:
Throws the same exception as above with Link1, Link 3, Link 7, and Link 8.
Only seems to work with Link 4, 5, 6.

Removed check for lis_result_sourcedid. Thank you for pointing this out.


Update mapmodel3d.md

This is a dead-end page with no samples.  MapModel3D is primarily assigned to MapElement3D.Model, and MapElement3D has a sample.

@DavidBuerer : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Build: don't vendor jflex

It might be better not to store jflex in lib directory, but let gradle download the appropriate version.

:+1:
Just check prior to transition that target jflex version correctly treats all properties employed.


Fix minor gui issues

Fix two size issues for labels where size was explicitly stated instead of automatic size setup

Before (example):

After (example):

Add space between units (MHz, dBFS, V etc.) for consistency in a lot of panels

Before (example):

After (example):

Note: While working on commit 1109427 I noticed some weird behaviour in the TxTSP and RxTSP panels: If you visit these panels after the first time, some labels get set to a different value than before (note the Angle column changing to PHO). Also if you switch between the FCW and PHO mode, some labels in the RxTSP panel get swapped whereas in the TxTSP panel they stay the same. I have no idea what the default behaviour should be...

Merged. Thanks for fixing issues in GUI.
Labels should swap in both RxTSP and TxTSP tabs. I will fix this.


⚠ Bofrost.de has degraded performance

In af02d7c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1657 ms

Resolved: Bofrost.de performance has improved in fcf8d19 after 8 minutes.


Ember-Core H2Server: get streamCreationLock from H2Connection

Since streamCreationLock.permit is itself a functional value, it should not be a problem to share it from the connection.

@diesalbla this has conflicts btw :)


sync_ldap_user_data: Show a proper error if no relevant users exist.

Discussion around https://chat.zulip.org/#narrow/stream/31-production-help/topic/ldap/near/1364155
It doesn't make sense to run sync_ldap_user_data if user_profiles list
is empty. Otherwise this misleading exception gets raised:
raise Exception(
    "LDAP sync would have deactivated all users. This is most likely due "
    "to a misconfiguration of LDAP settings. Rolling back...\n"
    "Use the --force option if the mass deactivation is intended."
)

I pushed a refinement for this that I think is pretty solid; feel free to merge if you're happy with it.
@alexmv FYI as well, since this may be something we want to backport.