Add DebugOptions::show_unaligned

This tool highlights coordinates that are non-integer.

Closes https://github.com/emilk/egui/issues/4927
Will be used for https://github.com/emilk/egui/issues/5163

This is disabled by default (even in debug builds), because so many widgets cause un-alignment currently.
This is how it looks when enabled:

Awesome!


clean container_disk_test a bit

Using libvmi.NewAlpine, libvmi.NewCirros and tests.RunVMIAndExpectScheduling
makes container disk tests slightly shorter and clearer.
Simple replacement did not work right away in some of the tests, e.g test_id:1463.
I don't understand those test and their
peculiar usage of objs on top of vmis so I leave their cleanup to a
future PR.
NONE

/approve

/retest

@dankenigsberg , it seems a test is constantly failing with this change.

/hold
it seems that CI found a real bug in my code
 02:08:44: [rfe_id:588][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]ContainerDisk
02:08:44: tests/container_disk_test.go:47
02:08:44:   [rfe_id:273][crit:medium][vendor:cnv-qe@redhat.com][level:component]Starting from custom image location
02:08:44:   tests/container_disk_test.go:194
02:08:44:     with disk at /custom-disk/downloaded
02:08:44:     tests/container_disk_test.go:195
02:08:44:       [test_id:1466]should boot normally [It]
02:08:44:       tests/container_disk_test.go:196
02:08:44:
02:08:44:       Unexpected Warning event received: testvmi-wrsvk,cf4fdbae-97a5-4790-93de-d1ff1852c549: failed to find a sourceFile in containerDisk disk0: No image on path /proc/1/root/var/lib/containers/storage/overlay/799d52eeb1907f13c089c4b6d17492ff1b70f91616dc2dbc76a5864717096b5f/merged/custom-disk/downloaded
02:08:44:       Expected
02:08:44:           <string>: Warning
02:08:44:       not to equal
02:08:44:           <string>: Warning
02:08:44:
02:08:44:       tests/utils.go:415

/hold cancel

/retest


Allow 'unspecified' git failures to be logged to errorLogs.txt.

This makes it more easy to determine why git fails if it doesn't fall into one of the already-caught categories of Git errors we capture.  Unspecified git problems in the code will not result in a crash, but will now spit out error data with a timestamp to the errorLogs.txt file with these changes.

Coverage remained the same at 65.846% when pulling d9010b3f7df91dc539e26e60f9837a0c972f63aa on unspecified_git_errors_to_errlog into 643b14fca7d17c02d3db9211258183eb18bf58b9 on master.


Change yaml marshalling of node-labels

The yaml marshalling does not play well with '+' in the key.
This commit makes the node-labels hopefully play nice with k3s/rke config again.
Signed-off-by: Fredrik Lönnegren<EMAIL_ADDRESS>

Shouldn't all of this be a git revert instead ?

Well, with the + in the yaml tag it will not serialize properly so we still need the ugly work-around.

The PR looks good to me, should the fix go directly to the new branch or wait until we merge the new operator in the main?

Probably easiest to go to main directly? Unless you plan to merge the new operator today?

Dont agree with this solutiuon. We should not force the yaml into a string wheh we have libs for that.
The real issue here is that the k8s yaml library FOR SOME WEIRD REASON, uses the json comment in the struct to know how to marshall the end yaml. dont ask me why it doesnt use the EXPLICIT YAML FIELD for that but it doesnt.
Just do a revert of the old commit and change the struct to use json comment instead of yaml and you will see it working back. Baffling.
See https://go.dev/play/p/GnYFrZVwfIn for an example and check the different in output.
So we need to add:
type LabelsFromInventory struct {
		NodeLabels []string `yaml:"node-label+",json:"node-label+"`
	}

Speechless.. But yes that looks much better! I will make the change!

Hmm, looking at the code again I don't know why we are using sigs.k8s.io/yaml as we use gopkg.in/yaml.v2 in other parts of the code. Will change to use that one instead!
https://go.dev/play/p/vGEq1fqUelY

weird as hell


[website] horizon.io taken by blockchain gaming company

Remove references to horizon.io as the domain is taken by blockchain gaming company.
The issue template references the URL as well as the project's URL.
The Horizon Twitter account seems dead but links to horizon.io as well.
If this project is dead maybe remove the URL referneces and archive this repository.
<!--
If you have a question,  please open a new topic in Horizon's Help forum:
    https://discuss.horizon.io/c/get-help

If you're reporting a bug please include the following:
-->

Must have been the 5th time or so I stumbled over it, every time getting extremely confused and closing the tabs again after getting excited initially. "Ethereum blockchain, a Game? That's your end goal? Man, you sounded so professional in all those youtube talks but now you're doing that?" 😆

Must have been the 5th time or so I stumbled over it, every time getting extremely confused and closing the tabs again after getting excited initially. "Ethereum blockchain, a Game? That's your end goal? Man, you sounded so professional in all those youtube talks but now you're doing that?" 😆

LOL.  Thanks for making this comment @JosXa , and @fibric for the report, I must have clicked through this Github notification last time.  I'll scrub out the URLs when I get the chance (which should be today).

LOL.  Thanks for making this comment @JosXa , and @fibric for the report, I must have clicked through this Github notification last time.  I'll scrub out the URLs when I get the chance (which should be today).

I made two PR's.  One of them changes the documentation links to point at http://samuelhughes.com/rethinkdb/horizon-docs/docs/index.html , and if anybody has a better place they'd like to host the docs, we could point it there instead.

I made two PR's.  One of them changes the documentation links to point at http://samuelhughes.com/rethinkdb/horizon-docs/docs/index.html , and if anybody has a better place they'd like to host the docs, we could point it there instead.

More about it, the website link should be changed, too

More about it, the website link should be changed, too

I have removed that link and merged the PR's.

I have removed that link and merged the PR's.


How to have a dynamic translation lookup table?

I am having a Map where the value for each key (ID) must be localized.
Having my translations file contain stuff like
String get entry_408fb1c2044643eeb74652908b41b19c => Intl.message('Item X', name: 'entry_408fb1c2044643eeb74652908b41b19c');
String get entry_192320807c944c599d9a155d230effdc => Intl.message('Item Y', name: 'entry_192320807c944c599d9a155d230effdc');
...

is pretty hard to maintain for many many items because additionally - due to the fact that flutter does not support reflection, there cannot be any dynamic calls to that translation (Translations.of(context).entry('192320807c944c599d9a155d230effdc')) so every call needs to be hardly programmed by hand.
I already though about something like
String entry(String entryID) {
    switch (entryID) {
        case '408fb1c2044643eeb74652908b41b19c':
            return Intl.message('Item X, name: '...');
...
    }
}

but this does unfortunately not work because A: the method name needs to be the same as the Intl.message() name and B: the name must be unique (so just entry won't work).
Is there any way to be able to call a translation dynamically? If such translation does not exist, it should just return null.

This sounds like https://github.com/dart-lang/intl/issues/298

@alan-knight wonderful, thank you very much. The solution mentioned here works for me.


Java client: high CPU regression for producer between 2.6.x and 2.7.x

Describe the bug
When upgrading our pulsar client to 2.7.x, we noticed significantly higher CPU used for applications running multiple produces with the newer version. We have been unable to isolate the exact cause of the regression.
To Reproduce
Steps to reproduce the behavior:

Run the example dropwizard application at https://github.com/klevy-toast/dropwizard-pulsar-test/
Run ./while.sh to trigger continuous message production
Observe average CPU over time
Change pulsar version in pom.xml, repeat 1-3

Expected behavior
CPU usage should be fairly similar between versions. But something in 2.7.x is clearly using more resources.
Screenshots
I tested this by running the application on an AWS t3a.large EC2 instance -- there was a ~15% increase in CPU.

Desktop (please complete the following information):

OS: linux

@klevy-toast  It seems to be a very strange question. I want to know what version you upgraded to before 2.7.

Hey @complone. I was using client version 2.5.2 before upgrading to 2.7.1. But I also did some tests with 2.6.x, and observed that the CPU usage was not elevated in that version. It only regressed in 2.7.x

Hey @complone. I was using client version 2.5.2 before upgrading to 2.7.1. But I also did some tests with 2.6.x, and observed that the CPU usage was not elevated in that version. It only regressed in 2.7.x

@klevy-toast I want to try to reproduce this problem, but it is currently tested on a local machine and cannot be restored to the cpu and thread configuration in the aws instance you provided. If the configuration of my current local machine is lower than the configuration you provided and it does not work properly, there is a problem. Do you think it is appropriate for me to verify this

@complone If you can measure your CPU usage on your local machine effectively, I believe you will still see the issue. I used AWS because of the convenient monitoring tools.
Regarding #2, I was not monitoring those pulsar metrics. I was simply monitoring the CPU usage of the whole server while it was running my program.

We were able to reproduce this issue with one of our applications.
With ~40 producers spun up but idle (not producing any messages) we tested with pulsar client 2.6.3 and 2.7.2 and analyzed the CPU usage using datadog's profiler.
2.63:

2.7.2:

2.7.2 used significantly more CPU, mostly in the ProducerImpl's batching task.
We did notice this change between 2.6.x and 2.7.x: https://github.com/apache/pulsar/pull/7733/files#diff-d6fcf8aa2d0035cc386dca0942a452343d6854763c7fd397efa4e660c0069767R1233
Looking at the code there seems to be a slight behavior regression in how this task is scheduled. Previously, the behavior mimicked scheduleWithFixedDelay however scheduleAtFixedRate was chosen. So we believe that the batching task for producers runs much more frequently now, causing higher CPU usage.
We think replacing the usage of scheduleAtFixedRate with scheduleWithFixedDelay will likely fix this issue.

Can you test your suggestion on current master branch?
If you get good results please send a PR

@klevy-toast Did you start producer with batch-enabled? and the batch time config kind of small, like 1ms, 10ms. My team have found this param is an important factor affecting the CPU. We also have a excel of cpu,producer number, batch time. If you are interested in, I can share it tomorrow.

@klevy-toast That's the result tested with @fu-turer on huawei cloud.
case1: 1000 producer, batch 1ms, cpu 68%
case2: 1000 producer, batch 20ms, cpu 23%
case3: 1000 producer, batch 50ms, cpu 11%
case4: 1000 producer, non-batch, cpu near to zero
case5: 500 producer, batch 1ms, cpu 50%
That's the test result without any produce.
cc @eolivelli

@Shoothzj yes, so this task isn't run when batching is disabled. Tests were run with batching enabled and the default batchingMaxPublishDelayMicros of 1000 (equivalent to 1ms).
We can certainly increase the batch time, which will result in the task running less often. However, the fix we are proposing would make the the task run less often even at 1ms and should match the behavior prior to the 2.7 release. The theory is that before the task will take the 1ms break before running again, but now it's effectively an infinite loop without breaks.
@eolivelli we will try that out and get back to you.

@eolivelli finally got around to verifying the behavior of the suggested fix here and submitted a PR #14125

I think that https://github.com/apache/pulsar/pull/14185 might prove to be an even more optimal solution, especially when running with many producers that are not in user. I haven't completed any bench marks yet, though.


How to get a payload_url for a given payload_type?

Please remind me how to do this or point to a relevant documentation.
Am I supposed to use the following URLs? If so, how to match a payload_type to its "name"?
$curl 'http://nopayloaddb-nopayloaddb.apps.sdcc.bnl.gov:80/api/cdb_rest//payloadiovs/?gtName=TestGT1&majorIOV=0&minorIOV=0'
[{"id":1,"name":"Beam_1","global_tag":1,"payload_type":1,"payload_iov":[{"id":2,"payload_url":"D0DXMagnets.dat","major_iov":0,"minor_iov":0,"payload_list":1,"created":"2021-12-01T18:44:47.898625"}],"created":"2021-12-01T18:44:47.771677"},{"id":2,"name":"FieldMap_2","global_tag":1,"payload_type":2,"payload_iov":[{"id":5,"payload_url":"sphenix3dbigmapxyz.root","major_iov":0,"minor_iov":0,"payload_list":2,"created":"2021-12-01T18:44:47.960308"}],"created":"2021-12-01T18:44:47.795465"},{"id":3,"name":"CEMC_Thresh_3","global_tag":1,"payload_type":3,"payload_iov":[{"id":4,"payload_url":"CEMCprof_Thresh30MeV.root","major_iov":0,"minor_iov":0,"payload_list":3,"created":"2021-12-01T18:44:47.940778"}],"created":"2021-12-01T18:44:47.818779"},{"id":4,"name":"ZDC_4","global_tag":1,"payload_type":4,"payload_iov":[{"id":1,"payload_url":"towerMap_ZDC.txt","major_iov":0,"minor_iov":0,"payload_list":4,"created":"2021-12-01T18:44:47.879554"}],"created":"2021-12-01T18:44:47.839263"},{"id":5,"name":"CEMC_Geo_5","global_tag":1,"payload_type":5,"payload_iov":[{"id":3,"payload_url":"cemc_geoparams-0-0-4294967295-1536789215.xml","major_iov":0,"minor_iov":0,"payload_list":5,"created":"2021-12-01T18:44:47.917463"}],"created":"2021-12-01T18:44:47.859916"}][smirnovdi@rcas2601.rcf.bnl.gov:~/bnlnpps/xpload]

$curl 'http://nopayloaddb-nopayloaddb.apps.sdcc.bnl.gov:80/api/cdb_rest/pt'
[{"name":"Beam","created":"2021-12-01T18:44:47.692772"},{"name":"FieldMap","created":"2021-12-01T18:44:47.707427"},{"name":"CEMC_Thresh","created":"2021-12-01T18:44:47.721391"},{"name":"ZDC","created":"2021-12-01T18:44:47.736156"},{"name":"CEMC_Geo","created":"2021-12-01T18:44:47.750772"}]

Was my question clear? Please tell me how to use your API to select a payload_url for a payload_type specified by name.

Actual release tag is 0.0.6

What is the correct URL for the production web server now? The one I used in the initial post does not seem to return any sensible result. I thought we agreed to use this URL for production http://nopayloaddb-nopayloaddb.apps.sdcc.bnl.gov:80
Also, how does one get a list of all available tags?

URL is correct. But OKD broke after they update the version. Now they have to re-install everything. With bring Production and Test instances alive when OKD back

Hm... That is strange because http://npdb-test-test.apps.sdcc.bnl.gov:80 is responsive

My instances are also up and running. No issues can be seen at this time
curl 'http://npdb-prod.apps.sdcc.bnl.gov:80/api/cdb_rest/tags'
curl 'http://npdb-test.apps.sdcc.bnl.gov:80/api/cdb_rest/tags'

While we are waiting on the OKD cluster upgrade, can someone please address my question I asked above: "how does one get a list of all available tags?" The reason I am asking is that when I use the '/api/cdb_rest/gt' API endpoint it takes 5 minutes to get the response on my local machine for a DB with only 100 tags. That makes me think there is a better way I am not aware of.
I believe Chris @pinkenburg expressed a similar concern in his recent email when he used a curl command on your test DB instance.

A Web interface would be great, wouldn't it?
On 3/3/22 1:42 PM, Dmitri Smirnov wrote:

While we are waiting on the OKD cluster upgrade, can someone please
address my question I asked above: "how does one get a list of all
available tags?" The reason I am asking is that when I use the
'/api/cdb_rest/gt' API endpoint it takes 5 minutes to get the response
on my local machine for a DB with only 100 tags. That makes me think
there is a better way I am not aware of.
I believe Chris @pinkenburg https://github.com/pinkenburg expressed
a similar concern in his recent email when he used a curl command on
your test DB instance.
—
Reply to this email directly, view it on GitHub
https://github.com/BNLNPPS/nopayloaddb/issues/12#issuecomment-1058367986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEJXDPLF5YXXAYFBUYXORTU6EBYPANCNFSM5OPLV2KQ.
Triage notifications on the go with GitHub Mobile for iOS
https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!QK_PPxtK4sQDwnEsTxBaiyyQx--rgvDayAHwJcoijt09Y5bGxf1fkSpHXUG58ibj$
or Android
https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!QK_PPxtK4sQDwnEsTxBaiyyQx--rgvDayAHwJcoijt09Y5bGxf1fkSpHXfl0SBqD$.
You are receiving this because you are subscribed to this
thread.Message ID: @.***>

Hi @plexoos , reading didn't change so as @ruslan33 commented above the form:
curl 'http://npdb-test-test.apps.sdcc.bnl.gov/api/cdb_rest/payloadiovs/?gtName=sPHENIX_ExampleGT_2&majorIOV=0&minorIOV=2'
is what you should use.  If you populated your test DB with a lot of test data then you should probably flush it, indexing et al is coming in a branch next week and this will speed things up.  We're prioritising the interface first, then performance.
@buddhasystem, for the software framework use case a "Web interface" is irrelevant.

Paul, my understanding is that this endpoint api/cdb_rest/payloadiovs is used for getting a list of payloads for a given tag. I think there should be a way for the user to get a list of available tags, otherwise, how the user would know which tag is valid. I believe that's what Chris was trying to see when he used the CLI tool as xpl show tags. Internally it sends a request to api/cdb_rest/gt and that's where I also noticed that it gets slow.

Oh I thought we were discussing api/cdb_rest/payloadiovs !  You're right that api/cdb_rest/gt should return the list of all 'global tags', 'tags' is used in a different context on other experiments (equivalent to a 'payload_list'), sorry for the confusion.  You're right, and that is naively very odd, but I can reproduce locally having injected a reasonable amount of data and I see that the implementation dumps the entire content of all global tags instead of just the tiny Global Tag objects which is what you want.  Could you please open a new issue?  I believe this is pretty easy to fix but I'd prefer if we follow up in dedicated issues.  Thanks!

Yay! I was able to restore my instances with test entries just like they were before the cluster upgrade.
Once you guys have your django apps up and running I'll check the timing. Feel free to close this one.


Adding "Lazy" modify and modifyAll capability to lenses

Hi,
I propose to enable an alternate syntax for lenses definition:
modify[Person](_.address)

and
modifyAll[Person](_.firstName, _.middleName.each, _.lastName)

Thanks! Released in 1.4.12

Thank you :-)


Does adding an enum variant break backwards compat?

I just want to confirm: anything written as type A will be incompatible for reading as if it were type A'? Specifically for enum variants.

Hello,
If you use the serde version (Serialize, Deserialize), then it's ok to add new variants at the end of your enum. Since bitcode can't know the total number of variants, they might as well have been there all along.
If you use the derive version (Encode, Decode), which does know exactly which variants exist, then there is a high chance (and you must assume) that compatibility is broken.

That's great to know, thanks! Can this (and anything else compatibility related) be documented? Happy to close this issue, but it'd be nice to have this stuff in the readme and crate docs.

Actually, can I turn this into a feature request? I'd like to be able to specify the number of bits to reserve for an enum so I can choose how many I want to have for future compat. Really the setting should be "number of available variants" and in the backend it rounds up to a power of two or does something smarter.

Can this (and anything else compatibility related) be documented?

This is not a "feature" we want to advertise. bitcode is not intended for compatibility when changing types or versions. If and when serde allows knowing the total number of enum variants, we'll optimize bitcode and remove this "feature."

Actually, can I turn this into a feature request?

Unfortunately the ability to reserve enum variants is contingent on a few assumptions about how bitcode would organize data. A future version of bitcode might need to know the size/alignment/etc. of all variants or the enum it self, which wouldn't be known when reserving variants. We have an internal project that completely changes those assumptions and, while we might release it under a different name, we don't want to overconstrain bitcode's implementation either.

bitcode is not intended for compatibility when changing types or versions

This is what should be documented then. Also when you say versions, you mean major versions right?

Also when you say versions, you mean major versions right?
Yes, e.g. 0.4.0 to 0.5.0 or 1.0.0 to 2.0.0. Not minor/patch changes.

Also, I talked with @caibear and another workaround (for Encode and Decode) is to add some placeholder variants for future use:
#[derive(Encode, Decode)]
enum Extensible {
    A,
    B,
    #[doc(hidden)]
    Placeholder1,
    #[doc(hidden)]
    Placeholder2,
}

Then, as long as you never use the placeholders, you can change their definition to be a tuple or struct variant.

Clever!

can change their definition to be a tuple or struct variant

Is this guaranteed to always work? If so, that's good enough for me.

Is this guaranteed to always work? If so, that's good enough for me.
Probably, unless we need to deprecate it in a major version (in which case you would have to break compatibility anyway by upgrading if you needed to upgrade).

That's fine, thanks!


Dev mode hangs when debugging Gradle plugin execution due to debug port collision across parent/child Gradle processes.

A simple:  gradle libertyDev -Dorg.gradle.debug=true will typically hang.
The reason is that the JVM debug args  will be constructed as:   ...,suspend=y,address=5005 for the process running DevTask.
However, the child Gradle launched via BuildLauncher in DevTask:runGradleTask() will likewise be configured with the same exact JVM args.   Because the daemon running the parent task is in-use, a new JVM/daemon will be needed. So the parent Gradle execution DevTask will hang waiting for the child, while it waits for a debugger connection.
Maybe we'd need to loop in the findAvailablePort processing to make this work.
Tried w/ LGP v3.5.2 but I think any recent version with dev mode would have this issue.

From above I had in mind the org.gradle.debug.port property, however it seems relatively recent.  I see it added in https://docs.gradle.org/7.4/userguide/troubleshooting.html, but not the 7.3 doc.


Tutorials > Polkadot SDK > Parachains > Build Custom Pallet > Build the Pallet

This PR adds a tutorial on how to build a custom pallet

One or two things left and there's a merge conflict. But I'll approve once these are taken care of! ✨


Winternitz checksum code optimization

This PR introduces a minor optimization on winternitz. It refactors the checksum calculation code to an equivalent form that utilizes fewer opcodes.

Great work! Credited you in the comments: https://github.com/BitVM/BitVM/blob/main/src/winternitz.rs#L120
I can send you a small bounty if you send me a LN invoice...


TextBox.FontSize has no effect

Setting the FontSize of a TextBox does not change anything.

It's actually change the text size, but no more. I think what is a bug

I just created a similar issue. It does not change the text size

Hello, @jsimjolner
Sorry for long awaiting. I've fixed it in last nightly release. Can you take a look?


Project uses pathlib2

Probably for legacy reasons before pathlib moved into the python standard library. Change it to just use the standard library instead.

This would be fixed as part of #3946.


Fix: Unable to scroll 2nd editor window

Description
When create a second editor window, users are unable to scroll by dragging on mobile until focus was set to the new editor panel.
The problem was traced to QuillSingleChildScrollView which was introduced in version 9.0 as a replacement to SingleChildScrollView.
Improvements to SingleChildScrollView by the Flutter team appear to have eliminated the need for the Quill variant.
Related Issues

Fix #1907
Fix #2104
Fix #1841

Type of Change

[ ] ✨ New feature: Adds new functionality without breaking existing features.
[ X ] 🛠 Bug fix: Resolves an issue without altering current behavior.
[ ] 🧹 Code refactor: Code restructuring that does not affect behavior.
[ ] ❌ Breaking change: Alters existing functionality and requires updates.
[ ] 🧪 Tests: Adds new tests or modifies existing tests.
[ ] 📝 Documentation: Updates or additions to documentation.
[ ] 🗑 Chore: Routine tasks, or maintenance.
[ ] ✅ Build configuration change: Changes to build or deploy processes.

QuillSingleChildScrollView which was introduced in version 9.0 as a replacement to

A side note, QuillSingleChildScrollView was already in older versions, however since we have moved files frequently, it may appear that it was introduced in version 9.0.
Take a look at this comment.
Screenshot


build: bump deps from dependabot

What is the goal of this change?
Consolidate dependabot PRs and bump dependencies.
Is there any issue related?
N/A
How does the changes address the issue?
N/A

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0a8e4f4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master       #27   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         1
  Lines             ?         7
  Branches          ?         0
==========================================
  Hits              ?         7
  Misses            ?         0
  Partials          ?         0

Flag
Coverage Δ

unittests
100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Clean cache on disable

Hi @MauriceButler,
I implemented this functionality because I have had some issues with the cache that Node.js implements.
Those issues happen when you have a module a.js that requires another module e.g. fs and you need to mock that module (fs). The mock functionality works well but when fraudster is disabled and you require the a.js module for second time it is returned from require.cache which have his dependency fs still mocked. So with this when fraudster was instantiated with cleanCacheOnDisable = true option, the cache of the modules that were required while fraudster was enabled will be removed on disable/deregisterAll.
Cheers!

Thanks @milsosa this functionality has been added and published in version 1.1.0


Issues with output files

Current status
Each time a calculation concludes, a new output folder is created with a new output file inside.
Issue

The user is not asked about saving the output file. Any user that is not aware of the app saving in the background will amass hundreds of folders that are essentially rubbish.
The app should never write anything to disk without the users consent.
The fact that all output files are in separate folders makes processing them an immense pain.
The naming of the output files makes finding specific calculations tedious.
model_outputfile.cpp is very difficult to read IMO. The Model class should not have authority on where to save files. This should be governed by the Controller.

Proposed change

Saving files should be done after the user has specified their intent to save them. The user should specify the output folder.
All saved files should be placed in the same folder. Their names should contain identifying information about the calculation, and rather than differentiating them by time, they should be differentiated by something else, such as a consecutive number.
generateReport() should be more self contained. It should take arguments when called by the Controller rather than call global variables. The use of global variables (members of Model) should be avoided at all cost.

Improvement

Avoid clutter on the user's disk.
Align with the design of comparable apps.
Make code more readable.

I agree with most points. I simply prepared a base for output that would be improved later when we are done with calculating functions.
The only point that I would keep it the use of the creation time in some form because it simplifies the classification by alphabetical order without having to keep track or checking all existing files in the output folder.
For example:
In the GUI, tick a box to save output => specify the output folder.
In the output folder, make a folder with the name of the structure file followed by the time (can be as a number like<PHONE_NUMBER>1705 instead of 2021-01-03_13h17m05s). This is a form that looks unnecessary long but is quite common in output files from analytical equipment in chemistry (e.g. mass spectrometers).
In this folder, save all output files that are requested by the user (report, analyzed structure, surface maps). The analyzed structure output file is useful in case the user excludes some elements or requests the unit cell analysis => it won't be the same as the input file.
We can deactivate the report writing altogether for the moment and deal with that later in my opinion.

I agree with most points. I simply prepared a base for output that would be improved later when we are done with calculating functions.
The only point that I would keep it the use of the creation time in some form because it simplifies the classification by alphabetical order without having to keep track or checking all existing files in the output folder.
For example:
In the GUI, tick a box to save output => specify the output folder.
In the output folder, make a folder with the name of the structure file followed by the time (can be as a number like<PHONE_NUMBER>1705 instead of 2021-01-03_13h17m05s). This is a form that looks unnecessary long but is quite common in output files from analytical equipment in chemistry (e.g. mass spectrometers).
In this folder, save all output files that are requested by the user (report, analyzed structure, surface maps). The analyzed structure output file is useful in case the user excludes some elements or requests the unit cell analysis => it won't be the same as the input file.
We can deactivate the report writing altogether for the moment and deal with that later in my opinion.


Adaptation of the Joint Base Class to integrate parent_point and child_point (eventually ?)

After the #85 the following was discussed :
"Super" calls the parent class  JointBase that has common entries for every joint. As all joints doesn't have a parent and child point yet.
It's not relevant to initialize them now. But this would be a great idea in the future !
Then, to initialize parent and child point with proximal and distal point would be automated for every joint, in the parent class JointBase  to avoid redundancy.

It requires to generalized hinge and universal joints to any application point, once its done this issue would be relevant and a good first issue !


Add setting for following symbolic links for code files that are going to be formatted.

I would like to request a feature for a setting that when enabled makes the extension follow symbolic links of the code file that is being sent to the black formatter.
Something like this [Pseudo code]:
def _get_filename_for_black(document: workspace.Document) -> str:
    """Gets or generates a file name to use with black when formatting."""
    if document.uri.startswith("vscode-notebook-cell") and document.path.endswith(
        ".ipynb"
    ):
        # Treat the cell like a python file
        return document.path[:-6] + ".py"
    document_path = Path(document.path)
    if settings.followLinksForCode:
        real_document_path =  document_path.resolve()
        if real_document_path.is_file():
            return str(real_document_path)
        else:
            raise ValueError("Received a broken path.")
    return document.path

The reason for this is that if the code resides inside a directory that is a symbolic link the black formatter can sometimes give the following error(here you have to imagine that you have opened a project folder in vscode which resides inside a workspace folder which in turn is a symbolic link to the real workspace folder somewhere else.):
[info] <symbolic workspace link path>/project/.venv/bin/python -m black --stdin-filename <symbolic workspace link path>/project/src/main.py
[info] [Error ....]
.
.
   raise ValueError("{!r} does not start with {!r}")
ValueError: `<symbolic workspace link path>/project/src/main.py does not start with <real workspace path>/project`

It seems as if the black formatter wants to receive the filenames as real paths. Or maybe I am just missing something.

@Superhepper This should be filed on black itself. We want to minimize the work arounds that we do in the extension. The above was a workaround for working with cells, and it is a part that we own. But, here the path that we pass to black should be resolved by black. Think this way, suppose you have configuration files in your project, and there is configuration in the symbolic link target. Black now has the option to decide which one to use. If we provide the resolved path, then we are forcing black to pick one.
The feature request on black would be to add symbolic link resolutions for paths passed with --stdin-filename


Method names should support symbol properties

The current function-name rule fails when implementing an iterable:
const it: Iterable<any> = {
  // [tslint] Method name does not match /^[a-z][\w\d]+$/: [Symbol.iterator] (function-name)
  [Symbol.iterator](): any {}
}

It should not fail; symbol properties and the iterable protocol are standard parts of JS since many years ago and should be supported.

Hi sklits 👋 thanks for the issue! You're absolutely right, this is a bug and should be fixed.

here's my override:
"function-name": [true, {
  "method-regex": "^\\*?\\[?[a-zA-Z][\\w\\d\\.]+\\]?$",
  "private-method-regex": "^\\*?\\[?[a-zA-Z][\\w\\d\\.]+\\]?$",
  "protected-method-regex": "^\\*?\\[?[a-zA-Z][\\w\\d\\.]+\\]?$",
  "static-method-regex": "^\\*?\\[?[a-zA-Z][\\w\\d\\.]+\\]?$",
  "function-regex": "^\\*?\\[?[a-zA-Z][\\w\\d\\.]+\\]?$"
}],

@JoshuaKGoldberg Is there a scheduled date for the 5.2.2 version of the package to include this fix? We're using this set of rules via tslint-config-airbnb and we're finding the same issue. We're applying a local override in the meantime, but it would be nice to see this go live :)

Thanks for bringing his up @joelalejandro - I'm planning on releasing a version after Hacktoberfest ends / early first week of November. It wasn't mentioned at all so I'll file a separate issue.


The "+" icon obstructs the view

Issue Summary
Today, I couldn't scan a train ticket because of the "+" icon:

Specifications

App Version: 2.7
Android Version: 8.1.0 (Lineage OS + microg)

The plus icon contains all the extra options, I might just redesign the main interface of the app. Any recommendations? I'm planning on putting everything on a bottom app bar...

Ofc with the new configuration nothing will block the main pdf view

I'd be fine with just being able to toggle the "+" icon by tapping anywhere in the document view, or moving all the options to the "three dots" menu

@JavaCafe01 We don't have the FAB anymore, I think this can be closed.


GodotSteam can't run a project on Linux by using the default engine launcher

Describe the bug
GodotSteam can't find the required file libsteam_api.so on Linux when opened directly by click.
To Reproduce
Steps to reproduce the behavior:

Download any version of GodotSteam for Linux
chmod +x ./linux-351-editor.64'
Execute linux-351-editor.64
Open any project
Run the project and notice an empty Output

Expected behavior
Find the libsteam_api.so file automatically, without the need of making a custom .sh for that.
Screenshots

Desktop:

Ubuntu 22.10 (Also present in previous versions; Struggling with it since 20.04)

Version of Godot:
Godot 3.x
Version of GodotSteam:
GodotSteam 3.5.1
Additional context
My workaround is to always download the GodotSteam 3.14 and modify the .sh file so it executes the latest version instead of the one it was written for.

Hey there!  This is actually a Steam issue that affects non-Godot games too and has been an issue since Steam came to Linux, oddly enough. I believe even games like The Binding of Isaac includes a .sh launcher to get around these things.  Interestingly, it is not a consistent issue; it happens somewhat randomly to different users on different distros.  I ran into this problem with Pygame and Python before getting into Godot.
That being said, there isn't any way to change this behavior in the editor or games.  But, both the editor and exported games will sometimes hit this snag.  The only solution is to create that .sh file to link the API file correctly.  It is common enough, that we cover this in the Linux Caveats tutorial.

I will close the issue as this isn't GodotSteam specific but more a problem with Steam and Linux; and, weirdly, an occasional issue.


Day2 Operations -- Disk Replacement

Description

Disk Replacement Support is required in case of the following
-- For failed disks in a RAID group (Faulted)
-- Proactive replacement for disks which can get failed (Based on error count / latency factors etc .. manual)
Context

Disks replacement for a pool is must as part of Day2 Operations.
Disks would go bad in a pool, the disk replacement is required for the pool  type as mentioned below
-- RAIDZx(1,2,3)
-- Mirror
For pool type Striped, Disk replacement support not required.

This has been addressed via cstor-operators and further information can be found here.


Include hash of package sources in build id when compiling packages to global build store

Oops, wrong repo.


fixed requirement.txt for pip installation, resolves #4

Description
Fixed the requirements.txt file for pip installation
Fixes #4
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Close, requirements.txt adjusted appropriately.


Fix#74  style header footer

Title and Issue number

Title :style header footer
Issue No. : #74
Code Stack :
Close #74
Video/Screenshots (mandatory)

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

JWOC

@AftabMankapure This branch still have merge conflicts . please make a new branch & then properly sync to the updated version & then make the changes & then submit your PR


Add Dark Mode

Self explanatory. Everyone who opposes a dark mode is not welcomed here!
Just kidding 🥲
Tasks

Add dark mode with Tailwind
Make sure to take the users OS settings first and use them as a default value, when rendering our app. When the user overwrites the setting manually it should take precedence over the OS setting.
Provide a dark mode version of the tiled background image

Make sure to take the users OS settings first and use them as a default value, when rendering our app. When the user overwrites the setting manually it should take precedence over the OS setting.

As setting the theme happens on the client side, we need to make sure that we add the dark class to the html tag when the page is requested. The html tag is inside the RootLayout and can only be done, when saving the theme preferences in a cookie.


FAB is square on Android 4.4.2

Hello,
I don't know why but on Android 4.4.2 the floating action button is square. It also doesn't behave as it should. (i.e. it doesn't show/hide based on the scrolling of the listview) I've attached a photo for you to see. Does anyone know if this is a bug or am I doing something wrong?
Thanks!

me too.. mine is on 4.4.4

ok I got this.
This component is a ImageButton form the soruce. So you need to add this in order to make the size right

  android:scaleType="centerInside"

that didn't fix it for me. :( still a big square.

@tudorsirbu you have to use 24dp drawables, at least that's what fixed the issue in my case

@tudorsirbu Using setBackgroundColor() made my fab to turn to a square button. it might be fixed if you use the other methods to set the background.


Adapt new StringLiteralExpr in SwiftSyntax

Overview
New StringLiteralExpr's introduced to consolidate StringInterpolatedExpr and StringLiteralExpr to have same interface. This PR adapts the literal expr

Codecov Report

Merging #7 into master will decrease coverage by 1.95%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   78.87%   76.92%   -1.96%
==========================================
  Files          10       10
  Lines         142      130      -12
==========================================
- Hits          112      100      -12
  Misses         30       30


WIP: Add dynamic helper instance methods

I was trying to make a translation page (two languages side by side in a form) and I realized it was not possible to give title_i18n["fr"] to the form helper. So I set out on this great quest to make some dynamic helpers so I could use title_fr when I18n.locale == :en, alas it's not that simple.
So here it is, in all its WIP glory, so you can give your comments and maybe make this a real feature.

I've picked a few of the more generic fixes and updates into the develop branch. A rebase skipping those should get this into a state that could be merged. I like the idea of the dynamic accessor but personally I don't have a use case at the moment. If you think it's stable feel free to merge.
Use in a form: Why not treat the nested column like any other object/relation and make use of nested form/attributes?

Use in a form: Why not treat the hstore column like any other object/relation and make use of nested form/attributes?

I just poked around, and this is another endeavor entirely. The main reason is that the locale is lower in the hierarchy than the attribute. So, with the stock form helpers, it would mean
fields_for(:title){ |ft| ft.field :en; ft.field :fr } # and so on rather than fields_for(:fr){ |fr| fr.field :title; fr.field :body } as the field key (name) needs to be post[title][en].
If we want to do that that means rolling out our own fields_for_locale helper, nothing impossible, but the hill is steep. I've started writing tests, but I don't know where to begin, as we need to test against ActionView and I'm not really sure how to do that. I agree it would be more elegant though.


Remove GIT_DIR hack

Homebrew has dropped the git export approach. Instead,
it copies the entire source dir to build dir. So the GIT_DIR
hack becomes obsolete.
Ref: https://github.com/Homebrew/homebrew/commit/359e972d4a75182ace2557e94d1a586ae66e7ad7

Nice! I wonder if they are aware that git clone /foo/bar on a local path will do a cheap clone using hardlinks.


BrainVision event parser doesn't handle my data correctly

The event parser for BrainVision files generates seemingly arbitrary event codes for my data. This is a problem that was first mentioned in #6267 and supposedly fixed. However, the fix introduced special handling depending on the detected event type:
https://github.com/mne-tools/mne-python/blob/70789c466133eaba410e1fc254c4b88723e30b77/mne/io/brainvision/brainvision.py#L825-L829
In the vmrk files generated in our lab using PyCorder, all stimulus and response events are simply labeled as Event (i.e., not Stimulus or Response, respectively). Therefore, they get assigned IDs 10001+, and the IDs we assigned to them during recording are basically ignored, yielding the issue(s) brought up in #6267.
When I change the line
_BV_EVENT_IO_OFFSETS = {'Stimulus/S': 0, 'Response/R': 1000, 'Optic/O': 2000}

to include Event markers:
_BV_EVENT_IO_OFFSETS = {'Stimulus/S': 0, 'Event/': 0, 'Response/R': 1000, 'Optic/O': 2000}

all works as expected and I can do
data = mne.io.read_raw_brainvision('data.vhdr')
events, _ = mne.events_from_annotations(data)
event_id = {'fixation': 100,
            'stim_a':   110,
            'stim_b':   120,
            'stim_c':   160,
            'response': 230}
epochs = mne.Epochs(data, events=events, event_id=event_id)

as would be expected.
This was tested with master.
x-ref https://github.com/cbrnr/mnelab/pull/50
cc @ArndalAndersen

Seems reasonable to me. Do you happen to know if Event is basically the same thing as Stimulus, or are they different? Maybe just from different versions of PyCorder?

Seems reasonable to me. Do you happen to know if Event is basically the same thing as Stimulus, or are they different? Maybe just from different versions of PyCorder?

I'm not sure, maybe it's just a configuration setting. The data were recorded two years ago and I currently don't have a working EEG setup to run further tests. But I could try to get a copy of PyCorder working again.
I would, intuitively, assume that Event is just a generic term for pretty much all kinds of stimulus and response events.

@larsoner Maybe your question was actually whether the offset for Events should be zero or something else? The answer is, I believe it should always be zero in that case. :)

I am fine with the suggested 1 line change.
you'll need to update a test though
thx

you'll need to update a test though

I'd add a new sample file to mne/io/brainvision/tests/data and add a very small test that just tests whether Event markers are being read correctly, nothing else, would that suffice?

Maybe just modify an existing vhdr file to have Event/ rather than Stimulus/, that way you don't even need to add a new file (or even a new test, since it should show up the same way)

Maybe just modify an existing vhdr file to have Event/ rather than Stimulus/

You mean, replacing some existing Stimulus/S markers with Event/?

You mean, replacing some existing Stimulus/S markers with Event/?

yes


ConfigParser.MissingSectionHeaderError: File contains no section headers.

python nshield-main.py
Traceback (most recent call last):
File "nshield-main.py", line 12, in
config.read("/etc/nshield/nshield.conf")
File "/usr/lib/python2.7/ConfigParser.py", line 305, in read
self._read(fp, filename)
File "/usr/lib/python2.7/ConfigParser.py", line 512, in _read
raise MissingSectionHeaderError(fpname, lineno, line)
ConfigParser.MissingSectionHeaderError: File contains no section headers.
file: /etc/nshield/nshield.conf, line: 5
'dryrun = 0\n'

Fixed by editing the .conf file /etc/nshield/nshield.conf
Added [conf] before dryrun
[conf]
#Enable or Disable Dry-Run to avoid updating current iptables rules
dryrun = 0
Enable or Disable basic Anti-DDOS
basic_ddos = 1
#Enable aggressive rate-limiting to incoming connections
under_attack = 0
nShield proxy if enabled checks domain list and creates the nginx conf (Works only for HTTP requests.. SSL still not implemented)
nshield_proxy = 0

Thank you for this issue, the example config file /etc/nshield/nshield.conf on github was using an old format.. i committed the fix to master

Thank you


[Codelabs intermediate] Google news API alternative

Is there a reasonable reason why the codelabs is using the Google news API?
Wouldnt it be better to use open resources instead? The Hackernews API is publically available, hence no registration step required. It reduces complexity (yet another registration form with captcha), completely omits the construction of the url with the API key and doesnt interrupt the flow of the codelabs.
I did implement the codelabs with the Hackernews API instead. With some minor modifications (see code below), it has the same outcome, no real value though (just a bunch of comments to an "unknown" topic).
async fetchArticles() {
          this.loading = true
          let idx = 0
          const array = []
          const path = "https://hacker-news.firebaseio.com/v0/item"
          const maxItem = 22115410

          while (idx < 5) {
            await fetch(`${path}/${maxItem - idx}.json`)
            .then(res => res.json())
            .then(data => array.push(data))

            idx++
          }

          this.articles = array
          this.loading = false
        }

The registration for the google news API is a bit annoying indeed. I think the hackernews API is a good alternative, I don't mind switching over to that. Open for PRs :)

This was implemented.


add missing tiny-warning dependency

Thanks for the PR. I made this a peer dependency instead

cool


use NAV_MC_ALT_RAD for MC takeoff check

When checking a mission, the takeoff altitude is being checked
against the waypoint acceptance radius to ensure the MAV being
clear from ground before heading to the next waypoint.
However, until now the horizontal acceptance radius was being
used, instead of the altitude reference value.
Targets #7379

This is only a quick-fix for multirotors, I'd be happy to hear opinions and work on the fixed wings as well!

I've updated the indentation issue, and suddenly tests on CircleCI fail. They are still running on my machine, though.
Any ideas? What am I doing wrong? :stuck_out_tongue:

Jenkins test this please.

Travis seems to be stuck somewhere...

@dagar please comment

CI was distracting. Need to stabilise it.


Install: instruction to install latest release via opam

We should have both a "from source" and a "stable" installation instreuctions

That's still something we want


build: don't overwrite tcmu.conf

If there is a tcmu.conf do not overwrite it.
Signed-off-by: Mike Christie<EMAIL_ADDRESS>

Yes, this is needed.


arc-0015 AlgoSMS - Algorand Standard for Encrypted Short Messages initial draft

Initial draft, to be revised heavily.
Example SDK will follow shortly.

Thank you very much for your proposal!
Using the same key for decryption and signature is usually quite dangerous.
If you know an academic paper proving this is ok in that specific case, please let us know.
If not, we will need to write a proof that your specific instantiation is secure.
At first glance, it looks ok, but cryptography can quickly go wrong. (For example, using plain RSA for decryption and signature is completely insecure.)
Other points to analyze/discuss:

How do you handle rekeying?
How do you handle non-ed25519 public keys? You can easily see that some addresses are not ed25519 public keys as about 1/8 of possible addresses are valid ed25519 public keys. But with probability 1/8 a multisig or logicsig address may look like a valid ed25519 public key. Using the indexer can tell you what the address actually is, but only if the address transacted.
Are there any addresses that are incorrectly generated and that would allow anyone to decrypt the ciphertext? At first glance if you filter for valid ed25519 public keys and the point at infinity, I think that should be good, but this need to be checked to.

Thank You for finding the time to parse through this. :)
Am not a crypto guy but is the recent https://eprint.iacr.org/2021/509.pdf referenced @ https://libsodium.gitbook.io/doc/advanced/ed25519-curve25519 enough for this use-case ?
Good point on the non-ed25519 public keys. The standard should definitely forbid encryption if the destination is not a valid public key. Also, the main use-case is to replace notification emails in sites that do wallet-based (ARC-0014) logins instead of email-based logins. Users would use dedicated login-only accounts so we can focus on accounts that are valid ed25519.
Question: can a wallet (like AlgoSigner) generate an account that is not valid ed25519 public key (on purpose)?
As for the rekeyed accounts, we could just ignore them, and treat them the same as invalid ed25519, as they are mostly outside of the use-case. But let me sit on the rekeying issue as this is a common one with ARC-0014.

Once an account is rekeyed, its private "spending" key should be considered forgotten.
This limits the use-case a lot :(
An encrypted message cannot be sent to an address if the address is:

a multi-sig address
a logicsig address
rekeyed-to a multi-sig account :)
rekeyed-to a logicsig
rekeyed-to a normal address, as the address can be the authorized one for many other addresses and we should not assume that the person authorized for spending is also authorized for reading private notes.
rekeyed-to a hardware wallet - probably next to impossible to get the hardware to support this.

Q: Is there a way to check for 1:1 relation in rekey-to ?

Q: Is there a way to check for 1:1 relation in rekey-to ?

@urtho this Issue tracks how to expose AuthAddr to the AVM. In this way the SMS should be sent by an AlgoSMS dApp that could check if the receiver has been rekeyed or not. I think the AlgoSMS protocol should include a bit of TEAL logic in order to validate proper SMS receivers, approving or rejecting SMS sending.

if there would be information in /v2/account/{id} in algod or indexer about the current address that it is rekeyed to, this would solve the isusse also for arc0014 .. perhaps there should be also some information with which account it has been encoded if it is not the same as the original public address.. this however waits for algorand action.. @fabrice102 am i right?

@urtho would you mind to change it also for unencrypted messages? if i send a public message to other person using algorand network, it costs me 0.001 algo, and if it is my decision to make it public it may serve several use cases.. mainly something like governance chat, trading chat and so on..

have you give a thought to make it also external? if the encoded message is longer than note field or when algorand will decide to require higher fee if there is longer message, it might be good to have external capabilities.. for example you could store just ipfs link to the encoded message and if receiver wants to read it he downloads it

ad. 1. The "spending" account info is there in the postgres DB on the indexer so no it "just" needs to be exposed.
ad. 2  Nice one. I'll upgrade the specs to include non encrypted texts. The minimum free was here to avoid spam. Any ideas how to allow for you use-case while making mass spamming cost prohibitive ?
ad. 3 There are some solutions already that do encrypted chain mail just by sending hashes and storing content on IPFS.  I wanted to start with simple SMS and possibly MMS (with image in URL and/or meta fields) but did not want to make a full-blown email solution out of it. Anyways it does not hurt the spec to have an additional field for IPFS-like content so I will do a revision this week with your suggestions. @scholtz

@urtho If this PR is still relevant, please, reach out to me

i believe it is.. we are using similar encryption system in the vote coin standard


Only use 1 core-lightning RPC crate

Right now we use both of these:

https://crates.io/crates/clightningrpc
https://crates.io/crates/cln-rpc

We need to collect what features cln-rpc is missing. Long term cln-rpc is the way to go imo because it has a higher chance of being maintained (as part of core-lightning).
Changes we need:

[ ] connect command (I think @jkitman ran into this problem)

Nice to have:

[ ] various API improvements, see https://github.com/ElementsProject/lightning/pull/5258

Feel free to edit that list.

At least one API command was missing and another failed because it was passing in a deprecated parameter.  Hard to say exactly what was missing until we try to remove the clightningrpc entirely.

We don't use clightningrpc anymore


BYON option with userDefinedRouting

Is your feature request related to a problem? Please describe.
Enable scenario to install AKS into existing VNET with Existing Firewall and tunneling and aksOutboundTrafficType set to userDefinedRouting
Currently it's not an option

Good suggestion. Should be very easy to implement.

I am happy to pick this up. Although I will need a discussion on UI changes with you @Gordonby.


Enable window channel on evas gl renderer

Signed-off-by: Boram Bae<EMAIL_ADDRESS>

@HakkyuKim
I reviewed what you asked me last time.  to solve this problem, I open this PR. I think we need to change the size of graphics adapter for resizing.


istio v0.7.1 requires privileged=true for istio-init container

Deployment fails unless you run this command
$ oc patch dc/customer --patch '{"spec": {"template": {"spec": {"initContainers": [ {"name": "istio-init", "securityContext": {"privileged": true}}]}}}}'
deploymentconfig "customer" patched

Deprecated as we will move to 0.8


Don't fire the observer if the result of a query hasn't changed

If we have a watchQuery observer and we receive a result from the server that is identical to the last result we handed to the observer, we should not call the observer at all. This will prevent solutions like using shouldComponentUpdate and will reduce useless re-renders on the page.

I'm unsure if I'm running into the same thing, or a slight variation of it:
I have a watchQuery (with noFetch: true); the observer's next fires 2 or 3 times  each time the store is changed, even if some other portion of the store (not owned by apollo) was modified

Hm. That should not happen if the part of the store associated with the store was left untouched. Could you file an issue that would allow us to reproduce the problem? (a unit test would also be great!)

Since #402 was merged, this issue can now be closed.

And deployed!

@nevir can you check if 0.4.2 fixes your issue with multiple firing?

@stubailo can confirm - all better as of 0.4.2

Sweet! It really helped in our app as well.


Release Slurm-GCP 6.5.6

6.5.6

Fix bug where dynamic nodes with hostname set to FQDN could not be found by slurmsync script; in current architecture, this impacts login nodes. The resulting Exception was uncaught; Solution truncates all nodenames to short hostname before performing comparisons requiring short hostname

Extends work performed in e33c07ef.
Observed results
✅ Test 1: confirm nodeset startup-script is working by activating a service at boot
srun -N64 systemctl is-active nvidia-dcgm.service
active
active
...

✅ Test 2: confirm exception no longer appears in slurmsync logs and the login node appears as idle to sudo sinfo (x-login partition is "root only")
$ sudo cat /var/log/slurm/slurmsync.log
2024-05-29 15:32:45,153 INFO: Restarting slurmctld to make changes take effect.
$ sudo sinfo
PARTITION AVAIL  TIMELIMIT  NODES  STATE NODELIST
x-login      up   infinite      1   idle a3mega-login-001.c.hpc-toolkit-gsc.internal
a3mega*      up   infinite     64   idle a3mega-a3meganodeset-[0-63]
debug        up   infinite      4  idle~ a3mega-debugnodeset-[0-3]

Manually deploying examples/hpc-slurm.yaml from the HPC Toolkit shows no errors/exceptions in the sync log:
# cat slurmsync.log
2024-05-29 16:49:03,412 INFO: Restarting slurmctld to make changes take effect.


FancyZone does not allow for different configurations per monitor.

Microsoft PowerToys version
v0.60.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Appears that the customization portion of the fancyzones for monitors and setting different monitors with different layouts is no longer working. Seems to default to whatever the last chosen fancyzone in the editor when I used to be able to set different monitors with different layouts.
✔ Expected Behavior
Able to use my two different layouts for monitor orientation differences.
❌ Actual Behavior
All monitors are set to the last zone selected.
Other Software
No response

Was just about to open the same issue. Experiencing the same behavior but in addition changes to layouts existing are not saved.

Same, the new version does not work properly with multiple monitors

/dup #19240


Detailed network configuration

Hi author,
Good job, happy to see your updates.  I've read your paper many times and run your inference code, can you share the supplementary material about the detailed network mentioned in the paper.
thanks!
BR.
star

The supplementary material is in the readme.


Multiple Drag and drop with drag and drop cdk

Feature Description
With the new Angular 7 feature cdk drag and drop right now it is unable to select multiple elements and the drag those and drop it.
Use Case
While drag and drop it would be good to have multiple elements dragged
and dropped in the list

Duplicate of https://github.com/angular/components/issues/14702.


Code Review

@phildini I think this is most of the way to addressing #7 albeit a bit rough around the edges.
Of note:

project no longer contains the mock db thanks.json
locally we read data from either PKG-INFO for eggs or METADATA for dists

theoretically we could also parse these for patreon of paypal links

added a message to get users to submit PRs asking authors/maintainers to funding metadata

this probably needs reworking

I've yet to find a project on PyPI which contains a funding url so, although I believe it all works, I haven't been able to confirm against the live wharehouse.

thanks itself has funding data: https://pypi.org/project/thanks/
Hoping to look at this PR in more depth later today.

True, but even thanks doesn't have it's funding url on pypi yet :)
Do you know of any other projects which already have it?

Eh? I see the funding URL listed on the pypi page.

:man_facepalming: I guess I was a fool to assume it would appear in the json-api results.
Any idea where the code base which serves the json-api lives?
However, it does extract the url from local installs.

Just found https://github.com/pypa/warehouse/issues/3831 which will probably work for us once it's completed


Version 7.0.0 not compatible with Azure Functions/AWS Lambda/Google Cloud Functions

References:

https://github.com/uuidjs/uuid/issues/375#issuecomment-590428623
https://github.com/uuidjs/uuid/issues/375#issuecomment-590576023

It's not just Azure. AWS lambda as well as google cloud functions have the same issue
Same goes for Azure functions. Getting the message:

Error: uuid: This browser does not seem to support crypto.getRandomValues(). If you need to support this browser, please provide a custom random number generator through options.rng.

@evdama @jvpelt @VandalPaulius @ZebraFlesh could you please share more details about your Azure Functions/AWS Lambda/Google Cloud Functions setup with steps to reproduce the error?
My suspicion is that you are bundling code in a way that is designed to run in a browser environment, not in Node.js
So are any bundlers like webpack or rollup involved in your process?
I created a minimalistic PoC that shows that under normal circumstances using uuid in Cloud Functions works just well: https://github.com/ctavan/uuid-cloud-functions-poc

yes, I use rollup to bundle uuid

@ctavan Here's a minimal repo with what I'm doing. master branch is set to<EMAIL_ADDRESS>upgrade to<EMAIL_ADDRESS>to see failure. https://github.com/ZebraFlesh/uuid-serverless-poc

Thank you @ZebraFlesh. I think a fix is near: #380

So are any bundlers like webpack or rollup involved in your process?
I created a minimalistic PoC that shows that under normal circumstances using uuid in Cloud Functions works just well: https://github.com/ctavan/uuid-cloud-functions-poc

Yes, in my case I was using Webpack to bundle everything, but the target was set to node. Hopefully #380 will fix it

I have just released<EMAIL_ADDRESS>which should fix this issue. If the problem remains for anyone please feel free to open a new issue.
And thanks @TrySound for the great work! 🎉

Thanks much, working again for firebase cloud functions with node express middleware (code see above).

Thanks so much for the quick turn around! Confirmed on my end that my PoC is fixed with 7.0.1 🙌

Bumped in to something similar today after upgrading from version 3 to version 7.0.2. Everything works locally, but on node in Azure I get a TypeError: _ff5.a(...).v4 is not a function when I import v4 as such:
import { v4 as uuid } from 'uuid';

I'm running my server code with node -r esm.
Is this somehow related to the above issue, or am I missing something?


What's the output?

why reverse the order of the output? seriously, why?

What do you mean?

This issue is (maybe) related #22

shape.diameter(); returns 20
shape.perimeter(); returns NaN
Answer B = 20 and NaN.
What's wrong about the order?

Didn't get it too.

withdrawn, I misunderstood the problem.


Dropdown menus

There are no dropdown menus in the Photon UI Kit. So, we should create one.

First sketch in https://github.com/fmoliveira/tantalus/commit/a7e00e1efe06b772c4d31802f6fa10ef44931ec9.

Dropdown container for user details in https://github.com/fmoliveira/tantalus/commit/12acd7e5db275cbfcc401ec44827a6be1d435943.


DTR patch releases

/cc @vikstrous, @pdevine if you want to review this.

We need to update the release dates and add one more fix to 2.4.1. See the private tracker for details.


Update text to be correct for start of 2024

added info about management being transferred to mobilitydata
added more info about feasibility study
added attributions and history with cal-itp
changed future tense ('proposed spec') to present tense

TODO:

[ ] @safrazier17 can you add to the list of implementers or those who are in process of implementing? You can respond in a comment and i can add to txt if you want.

implementers:

Equans
Giro (on request/non-native)
The Master Scheduler
Remix by Via
Swiftly


Large composite project crashes tsserver.js with "Debug Failure. False expression."

TypeScript Version:  3.1.0-dev.20180818
Search Terms: Debug Failure False Expression
Code
My project contains a single package which is built from:
/src
  /directoryA
  /... 29 other directories
/tests
  /tsconfig.json
  /directoryA
  /... 29 other directories
/tsconfig.json

Each directory under src has it's own composite tsconfig.json, and they form a DAG. There is also a tsconfig under tests that references each and every directory under src. The root directory contains a tsconfig that references every tsconfig under src and tests.
Expected behavior:
tsc --build should succeed and I should be able to browse the code in vscode without issue.
Actual behavior:
tsc --build succeeds, and I can browse code under src in vscode without issue. However, when I open up a file inside tests, the following error is emitted in the tsserver.log:
Debug Failure. False expression.

    Error: Debug Failure. False expression.
    at mergeSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29937:26)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30033:49
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30032:20)
    at mergeSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29957:21)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30033:49
    at Map.forEach (<anonymous>)
    at mergeSymbolTable (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30032:20)
    at mergeSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29962:21)
    at mergeModuleAugmentation (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30061:34)
    at initializeTypeChecker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:54898:25)
    at Object.createTypeChecker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29781:9)
    at Object.getTypeChecker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:83198:79)
    at synchronizeHostData (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:111305:21)
    at Object.getProgram (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:111378:13)
    at ConfiguredProject.Project.updateGraphWorker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:115433:53)
    at ConfiguredProject.Project.updateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:115381:42)
    at ConfiguredProject.updateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:115751:61)
    at ProjectService.addFilesToNonInferredProjectAndUpdateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:116821:25)
    at ProjectService.createConfiguredProject (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:116837:22)
    at ProjectService.openClientFileWithNormalizedPath (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:117243:44)
    at IOSession.Session.openClientFile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:118832:37)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:118037:31)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119496:88
    at IOSession.Session.executeWithRequestId (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119487:28)
    at IOSession.Session.executeCommand (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119496:33)
    at IOSession.Session.onMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119516:35)
    at Interface.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:120770:27)
    at emitOne (events.js:116:13)
    at Interface.emit (events.js:211:7)
    at Interface._onLine (readline.js:282:10)
    at Interface._normalWrite (readline.js:424:12)
    at Socket.ondata (readline.js:141:10)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)
Info 1390 [12:54:10.751] response:
    {"seq":0,"type":"response","command":"open","request_seq":2,"success":false,"message":"Error processing request. Debug Failure. False expression.\nError: Debug Failure. False expression.\n    at mergeSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29937:26)\n    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30033:49\n    at Map.forEach (<anonymous>)\n    at mergeSymbolTable (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30032:20)\n    at mergeSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29957:21)\n    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30033:49\n    at Map.forEach (<anonymous>)\n    at mergeSymbolTable (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30032:20)\n    at mergeSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29962:21)\n    at mergeModuleAugmentation (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:30061:34)\n    at initializeTypeChecker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:54898:25)\n    at Object.createTypeChecker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:29781:9)\n    at Object.getTypeChecker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:83198:79)\n    at synchronizeHostData (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:111305:21)\n    at Object.getProgram (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:111378:13)\n    at ConfiguredProject.Project.updateGraphWorker (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:115433:53)\n    at ConfiguredProject.Project.updateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:115381:42)\n    at ConfiguredProject.updateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:115751:61)\n    at ProjectService.addFilesToNonInferredProjectAndUpdateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:116821:25)\n    at ProjectService.createConfiguredProject (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:116837:22)\n    at ProjectService.openClientFileWithNormalizedPath (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:117243:44)\n    at IOSession.Session.openClientFile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:118832:37)\n    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:118037:31)\n    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119496:88\n    at IOSession.Session.executeWithRequestId (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119487:28)\n    at IOSession.Session.executeCommand (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119496:33)\n    at IOSession.Session.onMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:119516:35)\n    at Interface.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:120770:27)\n    at emitOne (events.js:116:13)\n    at Interface.emit (events.js:211:7)\n    at Interface._onLine (readline.js:282:10)\n    at Interface._normalWrite (readline.js:424:12)\n    at Socket.ondata (readline.js:141:10)\n    at emitOne (events.js:116:13)\n    at Socket.emit (events.js:211:7)\n    at addChunk (_stream_readable.js:263:12)\n    at readableAddChunk (_stream_readable.js:250:11)\n    at Socket.Readable.push (_stream_readable.js:208:10)\n    at Pipe.onread (net.js:594:20)"}

The typescript process is then dead on that file, not even a Loading... hover. The following process in process explorer seems to be stuck:
electron_node electronForkStart.js tsserver.js
  electron_node typingsInstaller.js tsserver.js typesMap.js

Also apart from that you should submit tsserver log to be able to understand the issue.
You can also upload logs using

With "typescript.tsserver.log": "verbose" enabled
Restart vscode or vscode insiders
Reproduce the problem
Run code --upload-logs on the command line (or code-insiders --upload-logs if using vscode insiders) and follow instructions
Share the log file ID

A smidge more data:
$ tsc --diagnostics
Files:           934
Lines:        114371
Nodes:        597497
Identifiers:  222348
Symbols:      357365
Types:        126168
Memory used: 457463K
I/O read:      0.12s
I/O write:     1.01s
Parse time:    3.00s
Bind time:     0.97s
Check time:    6.17s
Emit time:    13.48s
Total time:   23.63s

@sheetalkamat Upload successful! Log file ID:<PHONE_NUMBER>
@RyanCavanaugh This project is private so I can't share it, and as you can see from the diagnostics it's pretty big! If the data in the uploaded log files isn't enough to figure out the issue I'll try to recreate it on a smaller scale.

@leemhenson From the shared log, nothing stood out. From the log it seems project has 1343 files being added to it (compared to tsc 934 as per your shared data) That's the only thing standing out as such. We would need repro to investigate this and tsserver log is not enough.

@leemhenson One option would be for us to sign an NDA, if that would allow us to look at your original code.

I'm a bit snowed under at the moment but I'll try to work up a repro. If not I'll see about the NDA route.

I am also having this problem on a similar project. It's private as well but I'd be more than willing to provide access to the project.

@drew-y Thanks! I'll contact you over e-mail to talk about how to get access.

I have also run into this on a large composite project.  The build will work fine one minute then it will get into this state, and reverting my most recent change doesn't restore the build.  I will put together a repro case as soon as possible.
In the meantime, I have been able to work around it by doing a clean (removing existing build artifacts) and building again.  If that is the case for the OP, it may be a clue.  In any case, it may help others hitting this.

Here's a 100% repro w/two .ts and three tsconfig files running tsc version 3.4.5. Cmdline: "tsc --build src"
ts_throw_e.zip

@wolcotts your error is fixed in typescript@next. It's a duplicate of https://github.com/microsoft/TypeScript/issues/30591. However, that code didn't exist when this issue was filed, so I don't think it's the same cause.

Looking back at my e-mail, @drew-y's problem was fixed in 3.1.4. It's just @leemhenson's bug that is outstanding. I could be wrong, though, and maybe the code did exist already, so it could in fact be the same issue that @wolcotts saw.
@leemhenson can you test with typescript@next or typescript@rc?

Hey @sandersn, I no longer work at that company so don't have access to that project to test. I'm 99% certain it's the same problem I reported here:
https://github.com/microsoft/TypeScript/issues/30429
I just updated the repro project listed there to typescript@next, but that has not helped:
https://github.com/leemhenson/project-refs-oom-repro/commit/97c54910acb08d622f40198035a2570c0e89901b

Thanks. You've done a lot of work on this one. I'll close this as a duplicate of #30429 since it looks like the oomemory is the blocker now, not the mergeSymbol assertion.

we just got bitten by this very issue when we tried to switch to composite builds

@zpdDG4gta8XKpMCd Which issue? An assert with a stack ending in mergeSymbol? Or does the build run out of memory?

build runs out of memory, no matter how much we give it via --node --max_old_space_size=XXXXX


Is our documentation "good" and up to date?

Description:
As part of our ongoing effort to ensure that our documentation is both user-friendly and current, we're seeking contributors, especially those new to SBI and our package, to review and potentially update our documentation. This task is an excellent opportunity for newcomers to familiarize themselves with SBI and contribute to the community.
The review should focus on several key areas of our documentation to ensure that it is accessible, straightforward, and useful for both new and existing users. Specifically, we are looking for feedback and improvements on the following:

Readability of the README: Is the README document easy to understand? Does it effectively communicate what the package is about and how to get started?

Clarity of Installation Instructions: Are the installation instructions clear and precise? Can a new user follow them without running into issues? Is the installation process smooth across different operating systems?

Usability of the Getting Started Tutorial: Is the Getting Started tutorial easy to understand and follow? Does it serve as a helpful introduction to the package and its core functionalities?

General Feedback on Other Tutorials: Beyond the Getting Started tutorial, we are interested in general feedback on our other tutorials. Are they informative? Do they cover the necessary topics effectively? Are there any areas of confusion or improvement? Do you miss some tutorials?

To contribute, please follow these steps:

Review the documentation sections mentioned above.
Open an issue with your feedback, categorizing it according to the checklist provided below.
If possible, propose changes or updates to address the issues identified.

Checklist:

Readability of the README:

[ ] Is the README document easy to understand?
[ ] Does it effectively communicate what the package is about and how to get started?
[ ] Is the README up to date? Would you like to add something?
Clarity of Installation Instructions:

[ ] Are the installation instructions clear and precise?
[ ] Are the contribution guidelines and the setup for contributing clear?

Usability of the Getting Started Tutorial:

[ ] Is the Getting Started tutorial easy to understand and follow?
[ ] Does it serve as a helpful introduction to the package and its core functionalities?

General Feedback on Other Tutorials:

[ ] Are the other tutorials informative?
[ ] Do they cover the necessary topics effectively?
[ ] Are there any areas of confusion or improvement?
[ ] Is it complette? Do important features have an associated tutorial?

We appreciate your contributions to making SBI's documentation better for everyone. Thank you for your support!

Hello, can I work on this issue?

Great that you labelled it good first issue - I'd be happy to do that!!

@augustes we created a lot of tutorial-like material (some of it hands on!) during the 2021 sbi workshop -- some of it might be helpful?
About the workshop (including links to participant feedback): https://mlcolab.org/thoughts-on-our-simulation-based-inference-workshop
The tutorials: https://github.com/mlcolab/sbi-workshop

great, that is good to know. I will check it out - it would be great to
incorporate some if they are nonoverlapping. I'll keep this in mind next
week.
Thanks for the heads-up!
On Fri, 15 Mar 2024 at 16:49, Álvaro Tejero-Cantero <
@.***> wrote:

@augustes https://github.com/augustes we created a lot of tutorial-like
material (some of it hands on!) during the 2021 sbi workshop -- some of it
might be helpful?
About the workshop (including links to participant feedback):
https://mlcolab.org/thoughts-on-our-simulation-based-inference-workshop
The tutorials: https://github.com/mlcolab/sbi-workshop
—
Reply to this email directly, view it on GitHub
https://github.com/sbi-dev/sbi/issues/935#issuecomment-1999950135, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF4JKDLDYYQWMQM4CTHNWGTYYMJ7ZAVCNFSM6AAAAABDGNSJ7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHE2TAMJTGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Readability of the README: Is the README document easy to understand? Does it effectively communicate what the package is about and how to get started?
Clarity of Installation Instructions: Are the installation instructions clear and precise? Can a new user follow them without running into issues? Is the installation process smooth across different operating systems?
https://docs.conda.io/en/latest/miniconda.html]
Readability of the README:

[ ]  Is the README document easy to understand?

yes until the point inference algorithms

I changed word tutorial to instructions as that can be very frustrating when one expects a tutorial and it is just loading different inference methods. It should be clear before that that there are other tutorials as an entry point

I hence gave it a go and added a tutorial section before that directs one to tutorials because you both have an example and tutorial folder.

[ ] Does it effectively communicate what the package is about and how to get started?

yes but see tutorial getting started comment

[ ]  Is the README up to date? Would you like to add something?

broken link to miniconda

installation python version too old

add GPU CPU info

check depending on what we add in the hackerthon in case more inference algorithms will be supported

Hi there, I would like to propose extending a bit more the guide for contributions for sbi. I thought about getting inspiration from the guides from sklearn and mne. However, I don't understand if this issue is closed or not and whether the contribution that I propose should be done here or elsewhere.

Yes, that's a good idea @plcrodrigues! This issue here is more a collection of many different issues. Please create a separate one for improving the contribution guidelines, or create PR with the motivation that just mentions this issue. Thanks 🙏

Regarding the tuorials we currently have a few open issues to make them more consistent.
Once that is completeted, the website needs to be adjusted accordingly.
The newest papers also need to get added to the website (current cut off 2022)

Many points in this issue have been solved. Here is a checklist for closing it before the release:
These fixes should probably go into #1147

[ ] update papers, e.g., add flow matching and score matching once implemented. Is TSNPE and MNLE in there?
[ ] Execute all tutorials with the release-code and fix potential API changes, e.g., pairplot upper vs offdiag,
[ ] Add new methods to implemented methods tutorial

closed with #1232


feature request: global scripts

Could you add global scripts to this project ?
im thinking universal themes, overlays everywhere etc :octocat:
love the concept !

Hmm, that should be easy to do. I just don't know what name to give to that script. global.js? Ideally, it shouldn't conflict with any valid domain. I see that global is a valid TLD, so let's not use it. I'm inclined to prefix it with some character that can't be used in domain names, like _. Maybe _global.js? That's not a bad name. It will appear on top of other scripts when alphabetically listing the directory and also makes it clear its purpose. Looks good to me? What do you think?

And, of course, also _global.css.

Exactly what i was thinking !
_global sounds good to me :)

Alright, done :-)
I have just released version 2.3.0 to the Chrome store. It may take up to 60 minutes for the publishing to complete.
Thanks for your suggestion, @mjuksel.


Ansible role

Adds an ansible role for large_image.

Sorry,  what is the status of this PR with relationships to the girder.large_image role?

@kotfic I ported this PR to it's own repository. Since galaxy or ansible requirements.yml cannot pull from a subdirectory in a git repository I decided to move it to a separate repository.
@manthey had a file that currently the role does not support, and we can go forward if we support that file I believe.
I don't know what would be the best location for the role though. Maybe Vagrantfiles should remain here and the role should be in a separate repository. I am open to bright ideas.

@manthey I need a running example of large image with most (if not all) of the bells and whistles locally. I'm hoping inside a vagrant box.  I can put together a PR based on the vagrantfile here and the ansible_role.  Would this be useful or does the role need to handle all edge cases before you want to merge something that relies on it?

@kotfic This PR worked for almost, but not quite everything.
Specifically, if you have certain JPEG 2000 images that need to be processed via vips to convert to a pyramidal format, it can fail.  vips uses ImageMagick to read certain files.  ImageMagick's Ubuntu 18.04 distribution doesn't handle these files.  The only way I currently know how to do this is to build ImageMagick from source and then build vips (there may be simpler/better ways to do this).
We've had some microscopy files that need this conversion, so without resolving this issue, the role isn't of use to HistomicsTK (where we build all the microscopy related libraries from source).
If this is useful to you as is, then it could be merged and an issue filed against the outstanding problem.

Closing this as outdated.


Use Indexer for replica operation

Allows us to avoid setting the source on a request item - reducing
memory footprint.
The cost to re-generate the source is probably similar to what parsing
the source would be.

I think this currently could lead to primary/replica divergence if there are generated columns or default clauses which are not deterministic.
We'll probably have to extend the targetColumns + add the generated values on the primary to the insertValues so that the replica can re-use them?

Tested this on the dev cluster with 2 replicas enabled.
Initial results look promising:
venv ↪  ./compare_results.py --old old.jsonl --new new.jsonl
Q: insert into id_int_value_str ("id", "value") values ($1, $2)
C: 1
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |       11.872 ±    7.401 |      6.393 |     10.365 |     11.677 |    162.141 |
|   V2    |       10.355 ±    5.413 |      6.081 |      9.028 |     10.252 |    102.449 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -  13.65%                           -  13.80%
There is a 100.00% probability that the observed difference is not random, and the best estimate of that difference is 13.65%
The test has statistical significance

Q: insert into id_int_value_str ("id", "value") values ($1, $2)
C: 10
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |        9.328 ±    8.567 |      3.478 |      7.058 |      9.328 |     74.335 |
|   V2    |        7.366 ±    3.359 |      3.385 |      6.573 |      8.374 |     35.418 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -  23.50%                           -   7.12%
There is a 100.00% probability that the observed difference is not random, and the best estimate of that difference is 23.50%
The test has statistical significance

Q: insert into tbl ("id", "value") values ($1, $2)
C: 1
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |       16.709 ±    7.653 |      9.573 |     14.605 |     16.439 |    101.469 |
|   V2    |       15.243 ±    6.863 |      9.390 |     13.917 |     14.996 |    101.532 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -   9.17%                           -   4.82%
There is a 100.00% probability that the observed difference is not random, and the best estimate of that difference is 9.17%
The test has statistical significance

Q: insert into tbl ("id", "value") values ($1, $2)
C: 10
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |       46.991 ±   78.407 |      9.622 |     39.129 |     51.831 |   1217.121 |
|   V2    |       43.529 ±   74.426 |     10.148 |     34.561 |     45.380 |   1104.225 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -   7.65%                           -  12.40%
There is a 68.87% probability that the observed difference is not random, and the best estimate of that difference is 7.65%
The test has no statistical significance

Q: insert into uservisits ("adRevenue", "destinationURL", "searchWord", "UserAgent", "duration", "visitDate", "sourceIP", "lCode", "cCode") values ($1, $2, $3, $4, $5, $6, $7, $8, $9)
C: 10
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |       76.110 ±   97.144 |     22.022 |     53.049 |     79.138 |   1118.735 |
|   V2    |       54.952 ±   72.149 |     21.882 |     42.721 |     57.781 |   1026.043 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -  32.29%                           -  21.57%
There is a 100.00% probability that the observed difference is not random, and the best estimate of that difference is 32.29%
The test has statistical significance


[Bug] VSCode 1.86.0-insider is incompatible

This version is currently causing Vibrancy to not work on macOS (Windows unconfirmed)
Version: 1.86.0-insider
Commit: 02b90714767f05c734ac29a64d0e5b4768f532d8
Date: 2023-12-08T11:53:33.171Z
Electron: 27.1.3
ElectronBuildId: 25612240
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.1.0

On WIndows also. :(

I have created an issue a few months back about a bug regarding vibrancy in electron and created a standalone fiddle for the basic use case. I tested the same fiddle, that was created with version 25.x.x, with the same 27.1.3 version of electron and it seems like it's not an issue of this extension, nor vscodes but electrons/chromiums fault. The code regarding vibrancy was likely touched as version 26.0.0 "works" as it used to.
The fiddle I created some time ago and the issue.

That's unfortunate, thanks for the valuable info @RoyalFoxy

I have created an issue on the electron github repo regarding this. I found out that all version above version 26.6.2 aka version 27.x.y up to alpha versions of 29 are affected by this so there has been introduced a breaking change in the codebase for the 27th major release of electron and it likely hasn't been touched again ever since. I've also noticed that version 26.3.0 also had a change done to the part of the codebase that is responsible for the vibrancy effect as it had a difference in rendering the actual window vibrancy, this however, at least I hope so, is not related to our problem here.

I have found the likely issue as someone from the electron team pointed out that dark and thus also light I assume are not supported anymore in 27 and up. I've already found a list of vibrancy modes that work on electron natively fullscreen-ui, header, hud, menu, popover, selection, sidebar, titlebar, tooltip, under-window and 2 seem good for this extensions purpose: fullscreen-ui & under-window. I hope this helps

Thank you for the tip @RoyalFoxy, I've tested both and I agree, under-window seems to be a close match. They also seem to work in the current release VSCode version, meaning that updating the default to under-window now would likely not cause issues. I've released v1.1.25 that includes those two types, will look into updating the defaults later.

Released v1.1.26 that includes all currently available BrowserWindow Electron types, prepared the code for Electron 27 and updated the default theme types. I've tested all available types and it appears that there is no more Light type anymore, selection is the closest alternative but it's more grayish and doesn't work with existing themes. Will track this in #121, but for now VSCode 1.86 can be considered compatible.

@illixion Unsure what you mean by there is no more Light type anymore. All new vibrancy types are now refactored to be both compatible with light and dark mode and switches automatically with the system theme. There's nothing for you to do as it works out of the box.

@RoyalFoxy You're right, didn't realize that window.systemColorTheme is set to dark in my configuration, can confirm light mode does work properly without it

Look like the issue found at version 1.85.2. This is the latest VSCode Public Release for macOS and it's before 1.86.0.
Module Version is v1.1.27.
installed vibrancy effect after updated vscode, the Window has light vibrancy effect, but my VSCode color config is set to dark/Tokyo Night Storm.

Change System Color Theme to Dark(Currently i'm using auto dark/light mode), the vibrancy is return normal dark.
Switch back to 'dark' mode also solved this issue(This marked deleted after version 1.86.0). look like the auto mode can not dynamic set the dark / under-window mode after/before 1.86.0 or under-window will broken dark vibrancy if system is light mode

And on Windows Version, the Vibrancy is not working on 1.86.0-insider when using auto mode.

System dark/light mode currently has to match the Default Dark/Light theme in VSCode since automatic switching isn't yet implemented (#51). We could probably force dark/light mode in VSCode through window.systemColorTheme config setting based on the chosen theme, which would mitigate this issue. Will implement this in an update soon

System dark/light mode currently has to match the Default Dark/Light theme in VSCode since automatic switching isn't yet implemented (#51). We could probably force dark/light mode in VSCode through window.systemColorTheme config setting based on the chosen theme, which would mitigate this issue. Will implement this in an update soon

Badly, the Stable Tag 1.85.2 doesn't have window.systemColorTheme config commit. so the stable release users should be switch to deprecated dark mode manually.