WIP: Edition mode

This adds a first test for edition lints. I'll open another PR for filtering by machine applicability in a minute.
Note: Requires custom rustc built with https://github.com/rust-lang/rust/pull/50454
cc @Manishearth

rewrote the branches a bit, so this is now based on #96

Nice! I think we're still thinking of adding an --edition flag, right? One to auto-turn-on the "phase 1" lints I think?

@alexcrichton yes! This PR is just about having tests for each of the three modes (migration-to-2018, on-2018, yolo).
We should add an --edition flag that adds -W rust_2018_migration and disables all other lints.

Ok cool makes sense to me. I'm also less certain myself about what those three modes are, could you detail them a bit more?
Also, are you thinking that this should land ahead of other PRs to get it into rust-lang/rust sooner?

Sure. The "three modes" are basically the same as the "groups" we defined here, plus "fix all suggestions":

Migration to 2018

"Group 1: lints within 2015"
lints that change your 2015 code so it also works in 2018.
I'm not sure if the lint group for this exists in rustc yet.

Edition mode

"Group 2: lints within 2018"
lints that change your code so it becomes idiomatic 2018 code.
This is what you get when you add #[warn(rust_2018_migration)]

which means my naming is bad (this lint group was previously known as rust_2018_idioms so it didn't conflict with me calling the above group "migration"… oh well

"Everything" (the good old "yolo" mode) is just an internal group for us

all the other lints that are edition unrelated

This is only an internal grouping for rustfix' tests! I want to ensure that we have integration tests covering what is pretty essential to rustfix -- doing edition related fixes :)

@killercup ah ok, interesting! I figured we were just gonna always leave rustfix in "fix all warnings you can" mode and otherwise the flags would simply indicate what lints the tool explicitly enables.
For example I figured that when you switch to the 2018 edition via edition = '2018' we'd probably have a lot of lints on by default, so you'd run cargo fix and be done with it. Before you do that though you may want to make sure you can do it in the first place, so you'd run cargo fix --edition 2018 which would enable the rust_2018_migration lint explicitly (which currently is thought to be turned off for the near future.
Are you thinking we'd explicitly ignore some lints though and not apply fixes that we automatically look at?

Ok that all sounds great to me!


Decide on how to allow layered builds

Currently it's not possible to use osbs-box's docker-registry, <IP_ADDRESS>:5000, to build layered images because it requires authentication, and pull_base_image plugin does not support authentication.
Once support is added to atomic-reactor's plugin, we can change, or at least document, that to build layered images set source_registry_uri=<IP_ADDRESS>:5000 in osbs.conf.
Enabling this source registry by default would be problematic because it first needs to be populated with some initial images, rhel7 or fedora. But maybe this can be part of osbs-box.py up ?
Maybe pull-through registry can be used? https://docs.docker.com/registry/recipes/mirror/#use-case It seems unlikely.

I think its safe to remove authentication from the registry at all:
    registry:
      image: registry:2
      ports:
        - 5000:5000
      environment:
        REGISTRY_HTTP_TLS_CERTIFICATE: /certs/domain.crt
        REGISTRY_HTTP_TLS_KEY: /certs/domain.key
      volumes_from:
        - shared-data


Instruction for corpus and query on MTEP Evaluation

Do you use same instruction written in the paper for corpus and query on ReRank or Retrieval Benchmark?

Hi @bzantium,
Thank you for your interest in our work. The corpus is encoding without any instruction following previous works (e5-mistal-instruct, echo-embeddings).


sam validate fails if cf template was created with cdk

Description
After trying to validate template or execute a single lambda out of the cf template with sam cli, the follwing error appears:

Error: Failed to parse template: unacceptable character #x0000: special characters are not allowed
in "", position 3

It doesnt matter if i check out a example app or try it with my own.
Observed result
The last entries of the output in the console with the debug option are this ones:
Traceback (most recent call last):
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\yamlhelper.py", line 64, in yaml_parse
return json.loads(yamlstr)
File "json_init_.py", line 354, in loads
File "json\decoder.py", line 339, in decode
File "json\decoder.py", line 357, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "runpy.py", line 193, in _run_module_as_main
File "runpy.py", line 85, in run_code
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli_main.py", line 12, in
cli(prog_name="sam")
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 722, in call
return self.main(*args, **kwargs)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 697, in main
rv = self.invoke(ctx)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 535, in invoke
return callback(*args, **kwargs)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\decorators.py", line 64, in new_func
return ctx.invoke(f, obj, *args[1:], **kwargs)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\click\core.py", line 535, in invoke
return callback(*args, **kwargs)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\lib\telemetry\metrics.py", line 94, in wrapped
raise exception  # pylint: disable=raising-bad-type
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\lib\telemetry\metrics.py", line 65, in wrapped
return_value = func(*args, **kwargs)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\commands\validate\validate.py", line 32, in cli
do_cli(ctx, template)  # pragma: no cover
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\commands\validate\validate.py", line 40, in do_cli
sam_template = read_sam_file(template)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\commands\validate\validate.py", line 69, in read_sam_file
sam_template = yaml_parse(sam_template.read())
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\samcli\yamlhelper.py", line 67, in yaml_parse
return yaml.safe_load(yamlstr)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\yaml_init.py", line 94, in safe_load
return load(stream, SafeLoader)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\yaml_init.py", line 70, in load
loader = Loader(stream)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\yaml\loader.py", line 24, in init
Reader.init(self, stream)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\yaml\reader.py", line 74, in init
self.check_printable(stream)
File "C:\Program Files\Amazon\AWSSAMCLI\runtime\lib\site-packages\yaml\reader.py", line 144, in check_printable
'unicode', "special characters are not allowed")
yaml.reader.ReaderError: unacceptable character #x0000: special characters are not allowed
in "", position 3
Expected result
When i invoke the following command:
sam local invoke MyFunction3BAA72D1 --no-event
i would expect that it will be executed normally.
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)
OS is Windows 10
Python is 3.8.0
nodejs is 12.13.0
SAM CLI, version 0.19.0
I hope this helps you to improve your very great software even more! Thanks!

When i convert the template with
iconv -f utf-16 -t utf-8 template.yaml > template.yaml
This error not come up again.

Template files are typically expected to be UTF-8 encoded. We haven't tested with utf-16. We have made several improvemtns to file handling. Can you upgrade SAM CLI to latest version and try?

Ran into the same issue on powershell and was able to output in utf-8 by setting:
$PSDefaultParameterValues['Out-File:Encoding'] = 'utf8'
More information on SO: https://stackoverflow.com/a/40098904/4249811

I've also encountered this issue with the latest version of the AWS SAM CLI (0.41.0 at time of writing).

What's curious is that @marcortw's suggesting of setting the out file encoding makes the validation pass. I re-synthesized my template and sam validate succeeded.
Unfortunately, this appears to surface another issue. When attempting to run some local SAM CLI commands I receive an error message that seems incorrect to me. The message reads

Error: [InvalidTemplateException("'Resources' section is required")] 'Resources' section is required
I say this seems incorrect because the template for which these commands were issued definitely does have a resources section.  Here is a screen shot just in case I've done something obviously wrong. Thanks to the SAM team for all your hard work.

@JMRolf-Spok Try sam local start-api -template.yml not template.yaml, since that is how you named the file.

Yeah sorry that was a typo. The effect is the same, however.

@JMRolf-Spok Please create a new issue, something else is going on which doesn't seem related to this issue.

@jfuss will do. Thanks.


refactor: compiler using babel

@ShenQingchuan Sorry for bumping an old PR. Was playing around with ast-grep, and the doc linked to this repo with an old compiler implementation. I found this PR replaced it. Do you mind sharing the reasons behind this refactoring? Just want to see if there's some potential pitfalls before I commit more into my side project. Thanks in advance!

Not a very necessary refactor actually, ast-grep is a very useful and powerful tool and I'll have no doubt to choose it in many code searching relative situation.
But for Vue Vine, even though I need a solution for building compiler and ast-grep is able to do that, I still find that there're something complicated in bundling it and using in VSCode extension, and I was planning to make a REPL in browser but I felt it'll be complex to porting my compiler to browser environment when it was based on ast-grep.
For performance reason too, my use case is not even at the advanced target of ast-grep, I didn't write anything better to leverage its power in parallel computing, just use it to accomplish some basic requirements.

Thank you so much for taking the time to write a detailed response! It's very helpful.


Prepare a 0.0.1 release of the rp235x crates

I'm not sure if the crates are well-tested enough for a "real" release, but starting with a 0.0.1 for now wouldn't hurt IMHO.

It might be best to not run the version clock backwards in case people are using git deps. 0.2.0 is still "pretty sketchy" as a version number.


[SPARK-5722] [SQL] [PySpark] infer int as LongType in Python

This PR change to use LongType for int in Python, when inferSchema(), because IntegerType in SQL is not enough for int in Python (which is 64-bit on 64-bit machines).
Closes #4521
cc @dondondrake @marmbrus

Test build #27694 has started for   PR 4681 at commit 05ef1c8.

This patch merges cleanly.

Test build #27694 has finished for   PR 4681 at commit 05ef1c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27694/
Test PASSed.

@davies @marmbrus Just curious what the status of this PR and JIRA are for 1.2.x?
Thanks.

Merged to branch-1.2
@davies can you close this issue?

Thanks!


can't input chinese code

Lapce Version
v0.2.5
System information
LSB Version:	n/a
Distributor ID:	ManjaroLinux
Description:	Manjaro Linux
Release:	22.0.0
Codename:	Sikaris
Describe the bug
I can't input chinese into lapce editor or terminal with  IBus Libpinyin on Gnome 43.  I nerver try fcitx5 or others. but i can input chinese in any Gtk or Qt application.
Additional information
I try to build lapce from source, it has same problem.

I confirm is not working also with fcitx5 in a wayland session on Gnome 43

same problem on archlinux，0.2.7


Build about me page of the website

Build the about me page of the website, which includes the following:

Build about me page
Animate letters
Add information about me

Resolved as about me page was merged from branch "website" -> "main".


Incompatibility with Prysm

From Nishant on Prysm discord:
Occasionally Teku has difficulty peering with Prysm locally. It seems like a discoveryV5 issue
https://gist.github.com/nisdas/24fa1fc59c1b2ea37143a4abcab4e0d5
I am just running a local testnet with it and it came up

P3. Adding the bug label here due to Discovery repo not having bug labels yet.


[Event Request] codeunit 1000 "Job Calculate WIP" - OnBeforeCreateJobWIPTotal

New Event in codeunit 1001:
[IntegrationEvent(false, false)]
local procedure OnBeforeCreateJobWIPTotal(var JobTask: Record "Job Task")
begin
end;

local procedure CreateJobWIPTotal(var JobTask: Record "Job Task"; var JobWIPTotal: Record "Job WIP Total")
begin
    OnBeforeCreateJobWIPTotal(JobTask);
    JobWIPTotalChanged := true;
    WIPAmount := 0;
    RecognizedAllocationPercentage := 0;

    JobWIPTotal.Init();

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 48316.


Unable to use scala-native-crypto

Version(s)
Scala CLI version: 1.5.0
Scala version (default): 3.5.0
Describe the bug
unable to use https://github.com/lolgab/scala-native-crypto, a drop-in scala-native java.security.MessageDigest replacement library.
To Reproduce
//> using platform native
//> using nativeVersion 0.4.17
//> using dep "com.github.lolgab::scala-native-crypto::0.0.4"
//> using nativeLinking -lcrypto

import java.security.MessageDigest

def md5(s: String) =
  println(s.getBytes())
  println(
    MessageDigest
      .getInstance("MD5"),
  )

  println(
    MessageDigest
      .getInstance("MD5")
      .digest(s.getBytes()),
  )

@main def hello =
  println(md5("yex"))

sudo dnf install openssl-devel (or equivalent)
scala-cli run repro.scala
Expected behaviour
it works in scala native.
Actual behaviour
[info] Linking (1142 ms)
[warn]
Found 1 errors on @"M14repro$package$D3md5L16java.lang.StringuEO" :
[warn]     can't call D6digestLAb_LAb_EO on @"T32java.security.DummyMessageDigest"
[warn]
1 errors found
[info] Checking intermediate code (quick) (64 ms)
[info] Discovered 693 classes and 3836 methods
[info] Optimizing (debug mode) (750 ms)
[info] Generating intermediate code (614 ms)
[info] Produced 12 files
[info] Compiling to native code (1834 ms)
[info] Linking with [pthread, dl]
[info] Total (4623 ms)
scala.scalanative.runtime.ByteArray@c4070ad
java.security.DummyMessageDigest@c4043fd
scala.scalanative.runtime.UndefinedBehaviorError
        at java.lang.StackTrace$.currentStackTrace$$anonfun$1(Unknown Source)
        at java.lang.StackTrace$$$Lambda$2.applyVoid(Unknown Source)
        at scala.runtime.function.JProcedure1.apply(Unknown Source)
        at scala.scalanative.unsafe.Zone$.apply(Unknown Source)
        at java.lang.StackTrace$.currentStackTrace(Unknown Source)
        at java.lang.Throwable.fillInStackTrace(Unknown Source)
        at scala.scalanative.runtime.package$.throwUndefined(Unknown Source)
        at <none>.(Unknown Source)
        at repro$package$.hello(Unknown Source)
        at hello.main(Unknown Source)
        at <none>.main(Unknown Source)
        at <none>.(Unknown Source)
        at <none>.__libc_start_main(Unknown Source)
        at <none>._start(Unknown Source)

scala-native-crypto isn't picked up.

@WojciechMazur any clue what could be causing this?

That's the issue with the Scala Native 0.4.x series - it contained a dummy implementation (seen in logs) that was not marked with @stub. Because of that linker assumes that it's a valid definition and includes it.
The scala-native-crypto provides an alternative implementation of MessageDigest, however, there is no mechanism that could check if there are multiple definitions somewhere on the classpath. Because of that linker picks the first implementation found on the classpath.
There is nothing that can fix in in the scala-cli. I'd recommended switching to Scala Native 0.5.x which has this issue fixed. Alternatively we could release the 0.4.18, however the 0.4.x series is in general no longer maintained or developed.

thanks for the detailed reply.

There is nothing that can fix in in the scala-cli. I'd recommended switching to Scala Native 0.5.x which has this issue fixed.

guess I'm stuck in a catch-22 situation; I can't use 0.5.x because cats-effect doesn't support it, and i can't use 0.4.x either because of #3141. maybe i should find another native-compatible crypto library.

Okay... seems there's nothing to fix on our side.
Closing this.


Can this font system support font attribute italic or bold?

Hi,
Can this font system support font attribute italic or bold? like this test test
Best regards.

Hi,
There is no way to use bold, italic and regular fonts in the same text. However, the ttf fonts usually have more variants for bold, italic etc and you can convert new fonts from them to set for a label's style.

As there was no activity here for a while I close this issue.
If you have remarks about this topic feel free to comment here and reopen the issue.


Installer: add more unit tests

only descriptors generation are tested

I think this was addressed?

I think this was addressed?

Not enough, we need a full vertical setup install tested


KAFKA-4472: offsetRetentionMs miscalculated in GroupCoordinator

Fix possible integer overflow

Good catch. :) Can we add a simple unit test for this?

@ijuma I'll try to get create a test tomorrow

@ijuma I'm having some difficulty creating the test. The problem I'm facing is that it's the GroupCoordinator that has the bug, but the information is only used in GroupMetadataManager, meaning I would have to create a test basically testing the GroupMetadataManger instead for the GroupCoordinator.

@kichristensen, I was thinking of something simpler. After calling GroupCoordinator.apply, check the value in GroupCoordinator.offsetConfig.

@ijuma Of course, thanks. I've updated the PR with a test

@ijuma Sorry, most of it was auto generated by IntelliJ. It should be fixed now

LGTM, merged to trunk and 0.10.1. Note that I simplified the test a little by extracting the OffsetConfig construction into its own method. I hope that's OK. :)


Add variable for bypass update on startup

When modding the Server it's important to keep modded files. For this reason a startmode variable would be nice :)

Working fine! Thank you <3


Add node org to monitoring labels

This change adds an "org" label to monitored autojoined nodes

This change is

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 98.222%

Totals

Change from base Build<PHONE_NUMBER>3:
0.01%

Covered Lines:
718

Relevant Lines:
731

💛  - Coveralls

@robertodauria thank you for fixing this PR - PTAL?


HTTP/2 5.1/5 is racy

I am getting the following failure:
    × 5: half closed (remote): Sends a DATA frame
        -> The endpoint MUST respond with a stream error of type STREAM_CLOSED.
           Expected: GOAWAY Frame (Error Code: STREAM_CLOSED)
                     RST_STREAM Frame (Error Code: STREAM_CLOSED)
                     Connection closed
             Actual: WINDOW_UPDATE Frame (length:4, flags:0x00, stream_id:0)

My understanding is that WINDOW_UPDATE is allowed per 5.1 half-closed (local):
In this state, a receiver can ignore WINDOW_UPDATE frames, which might arrive for a short period after a frame bearing the END_STREAM flag is sent.

On further review, there seems to be an expectation of how the server should behave with these requests.
If the default behavior for a GET / is to return no data, many of the tests fail. The moment data is returned this test passes (mostly).
The test is racy as are others. In this specific case, there is a race between the data frame from the HEADER request and the RST_STREAM from the data request.
If I guarantee that I receive the response from the HEADER or delay the data request, it will always pass.

Here is the verbose for 5.1/5 and 5.1/6 which have similar issues.
5.1/5
           [send] SETTINGS Frame (length:6, flags:0x00, stream_id:0)
           [recv] SETTINGS Frame (length:24, flags:0x00, stream_id:0)
           [send] SETTINGS Frame (length:0, flags:0x01, stream_id:0)
           [recv] WINDOW_UPDATE Frame (length:4, flags:0x00, stream_id:0)
           [recv] SETTINGS Frame (length:0, flags:0x01, stream_id:0)
           [send] HEADERS Frame (length:15, flags:0x05, stream_id:1)
           [send] DATA Frame (length:4, flags:0x01, stream_id:1)
           [recv] HEADERS Frame (length:49, flags:0x04, stream_id:1)
           [recv] WINDOW_UPDATE Frame (length:4, flags:0x00, stream_id:0)
           [recv] DATA Frame (length:42, flags:0x01, stream_id:1)
           [recv] Timeout
      × 5: half closed (remote): Sends a DATA frame
        -> The endpoint MUST respond with a stream error of type STREAM_CLOSED.
           Expected: GOAWAY Frame (Error Code: STREAM_CLOSED)
                     RST_STREAM Frame (Error Code: STREAM_CLOSED)
                     Connection closed
             Actual: DATA Frame (length:42, flags:0x01, stream_id:1)

5.1/6
          [send] SETTINGS Frame (length:6, flags:0x00, stream_id:0)
           [recv] SETTINGS Frame (length:24, flags:0x00, stream_id:0)
           [send] SETTINGS Frame (length:0, flags:0x01, stream_id:0)
           [recv] SETTINGS Frame (length:0, flags:0x01, stream_id:0)
           [send] HEADERS Frame (length:15, flags:0x05, stream_id:1)
           [send] HEADERS Frame (length:4, flags:0x05, stream_id:1)
           [recv] WINDOW_UPDATE Frame (length:4, flags:0x00, stream_id:0)
           [recv] HEADERS Frame (length:49, flags:0x04, stream_id:1)
           [recv] DATA Frame (length:42, flags:0x01, stream_id:1)
           [recv] Timeout
      × 6: half closed (remote): Sends a HEADERS frame
        -> The endpoint MUST respond with a stream error of type STREAM_CLOSED.
           Expected: GOAWAY Frame (Error Code: STREAM_CLOSED)
                     RST_STREAM Frame (Error Code: STREAM_CLOSED)
                     Connection closed
             Actual: DATA Frame (length:42, flags:0x01, stream_id:1)

In both cases, the DATA frame is from the first request and there is the StreamError for the second request.
Here is some info on send queue from the server side,
&http2.writeQueue{s:[]http2.FrameWriteRequest{
http2.FrameWriteRequest{write:(*http2.writeData)(0xc0004261b0), stream:(*http2.stream)(0xc000444000), done:(chan error)(0xc000414180)},
http2.FrameWriteRequest{write:http2.StreamError{StreamID:0x1, Code:0x5, Cause:error(nil)}, stream:(*http2.stream)(nil), done:(chan error)(nil)}}}

Thanks for the log. It seems that h2spec is doing the expected behavior.
Why does not your server immediately send a stream error?

Define immediately.he test case sends a HEADER frame with EndStream=true. This can result in a HEADER w/EndStream=true or HEADER + DATA (EndStream=true).
Like I said, I haven't seen what the expected response is from the Server side.
I can control the response to cause either of the above. If I have an empty handler, you get a HEADER only. If I send back some data, you get the later.
If I only send back a HEADER, then I randomly fail with Actual: WINDOW_UPDATE Frame (length:4, flags:0x00, stream_id:0) which again is valid.
If I run all the h2spec tests with a server that sends no response data, I will fail anywhere from 3-7 tests.
If I run with a server that sends some data back always, I get anywhere from 1-5 failing test cases.
All of the failures but one are due to races between requests from the client and the internal state of the server.

Make sense. All the tests of h2spec expects a response data. So you need to have endpoint that respond with HEADER + DATA frame.
If your server processes the first HEADER frame before receiving the second HEADER or DATA frame from h2spec in 5.1/5 or 5.1/6, your server should send a Stream error or Connection error after sending that response.

Well, now that I look at it closer its a bit more tricky.
As I showed above, there is a RST_STREAM queued on stream 1, but because an END_STREAM was send to the client, the send queue for stream 1 is dropped. I will investigate how we should be handling that.

I am now convinced this test is racy.
The race is ultimately between the responses of the first and second requests.
If the first request sends a response, the stream is ended, so sending a RST_FRAME makes no sense since its already sent an END_STREAM on the the first response.
If however, the response of the second request occurs first, then an RST_FRAME makes perfect sense.
This test cannot guarantee which response is actually sent back first.


Adjust minimum validators on CartLine, OrderLine and FulfilmentLine

I want to merge this change because...
close #2912

Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.

I think you need to include migrations for those changes.

Yeah, that's right.

I'll do that right away.

How about dropping the MaxValueValidator on quantity_fulfilled as well?

Thank you for picking this up!

Glad to be of assistance.


Restict option

Using the restrict option 'R' in the .xml doesn't work.
It does nothing, but when I switch to 'U' to update it adds my groups.
Would like to have 'R' work to make sure only those users/groups are part of the local group.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b0c55a7-9aaa-d395-409e-59c2595c8e9e
Version Independent ID: cf8e5a71-a8fc-1d43-6eed-03d3f2490693
Content: Policy CSP - LocalUsersAndGroups - Windows Client Management
Content Source: windows/client-management/mdm/policy-csp-localusersandgroups.md
Product: w10
Technology: windows
GitHub Login: @ManikaDhiman
Microsoft Alias: dansimp

Thank you for providing feedback.
Note that the feedback section that you have used to submit this issue is intended for product documentation issues only.
Please consider opening a product feedback ticket for any of your suggestions or feature requests to help Microsoft improve your experience. Find the link to Feedback Hub below:
Microsoft Windows 10 Feedback Hub
Thanks.


Add basic autocompletion for Zsh

Unsolved problem:
Should I hard code this file into somewhere and generate it in a proper place, say ~/.cargo/_rustup(then ask users to copy it to /usr/share/zsh/site-functions),
or simply let rustup copy this file to ~/.cargo/_rustup?

part of #278

I'm a little concerned about keeping this up to date with the CLI, but we can add it for now on the basis that slightly out-of-date completions are better than no completions, and our CLI aims to be backwards compatible.
However, I'd prefer not to clutter the root directory with this. src/rustup-cli/zsh/_rustup should be fine, and we should link to it from the README under installation instructions.
Regarding actual installation, for now just providing them in the repo is better than nothing. When we figure out the best way to install it automatically, we can always include! the completions file into the rustup binary.

@Diggsey updated as you said :)

Thanks! Test failure looks spurious, so merging this.


Fargate New cluster

Issue #, if available: 57
Description of changes: New pattern for creating fargate cluster with observability using cloudwatch and containerInsights
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Howlla Please fix GitHub Issues.

/do-e2e-test single-new-eks-cluster deploy

/do-e2e-test single-new-eks-cluster deploy

/do-e2e-test single-new-eks-cluster destroy

/do-e2e-test single-new-eks-cluster destroy

Ready for merge from my side. :)

Depdendent on this PR. @Howlla thankyou for your work on this. Please alert me once you have it working, i can take a look,

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

/do-e2e-test single-new-eks-awsnative-fargate-observability destroy

@Howlla Destroy is failing. Please make sure destroy works clean in your environment and fix any issues.

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

/do-e2e-test single-new-eks-awsnative-fargate-observability deploy

/do-e2e-test single-new-eks-awsnative-fargate-observability destroy

Error is due to CoreDNS failure while destroy. Merging the PR.


Note: Array.prototype.at() is available now

[]["at"] ([][(![]+[])[+!![]]+(!![]+[])[+[]]]) may replace []["filter"] or []["fill"] ([][(![]+[])[+[]]+([![]]+[][[]])[+!+[]+[+[]]]+(![]+[])[!+[]+!+[]]+(![]+[])[!+[]+!+[]]]) to get a Function and it should work with latest browser versions except Safari as of now.
(This note is for golfing but not for compatibility though)
Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at#examples

@t-wy looks good - not yet works on safar

Thanks for the reminder! We already had a quick look at at here:
https://twitter.com/aemkei/status/1415033724748582923

As we can see on the below link:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at#browser_compatibility
the "at" method now is compatible with Safari.


Multiple Reimbursements, Same Day

The database doesn't seem to allow the same member to receive multiple reimbursements on the same day.  (On June 16, 1942 Denise Lafoy received a deposit reimbursement and a refund for an unused membership.)  Currently the database checks account and date for uniqueness.  A solution would be to check $ amount as well.
(So far I have sound two relevant cases: Denise Lafoy and Thomas on Nov. 13, 1940.)

Perfect.
Same dates --> OK.  Same dates and same amount --> Not OK.


Moving libraries and entitle.sh into /usr/local/bin

/test gpu-operator-e2e

/test gpu-operator-e2e

/lgtm
/approve
thanks for updating it :)


Generate Serial.begin(buad_rate) line only if needed for arduino

Difference in resulting hex file when compiling with and without the call to Serial.begin() is up to 1k (3% of storage) and 8% of DRAM, so we could save space by generating the said call only if needed by show text block.

As for all collectors it is really hard to check if the used hardware flag is set in all circumstances as needed.


Make me one of the maintainers.

What would you like to be added?
I am a maintainer in the main Kepler repository and I would like to become a maintainer in the kepler model server repository too.
Why is this needed?
As a maintainer I will be able to review and approve PRs.

@sunya-ch and @rootfs ^^

Done


cmd/go: unexpected directory layout while building project

    unexpected directory layout:
    	import path: github.com/gruntwork-io/terratest/modules/helm
    	root: /home/vagrant/go/src
    	dir: /home/vagrant/go/src/k8stests/vendor/github.com/gruntwork-io/terratest/modules/helm
    	expand root: /home/vagrant/go/src
    	expand dir: /home/vagrant/go/src/k8stests/vendor/github.com/gruntwork-io/terratest/modules/helm
    	separator: /

Can you please help me on where i am going wrong here.
$ go env
    GOARCH="amd64"
    GOBIN=""
    GOCACHE="/home/vagrant/.cache/go-build"
    GOEXE=""
    GOHOSTARCH="amd64"
    GOHOSTOS="linux"
    GOOS="linux"
    GOPATH="/home/vagrant/go:/home/vagrant/go/src/k8stests"
    GORACE=""
    GOROOT="/usr/lib/go-1.10"
    GOTMPDIR=""
    GOTOOLDIR="/usr/lib/go-1.10/pkg/tool/linux_amd64"
    GCCGO="gccgo"
    CC="gcc"
    CXX="g++"
    CGO_ENABLED="1"
    CGO_CFLAGS="-g -O2"
    CGO_CPPFLAGS=""
    CGO_CXXFLAGS="-g -O2"
    CGO_FFLAGS="-g -O2"
    CGO_LDFLAGS="-g -O2"
    PKG_CONFIG="pkg-config"
    GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build737322677=/tmp/go-build -gno-record-gcc-switches"

go version go1.10.4 linux/amd64

Can you provide the exact commands you ran to fetch and build this package?

in the project root directory /home/vagrant/go/src/k8stests
go build ...

Since you are using Go 1.10, you need to do everything according to the GOPATH. First of all, you have an incorrect GOPATH setting. There is no need to append /home/vagrant/go/src/k8stests to /home/vagrant/go. Just /home/vagrant/go is fine. And secondly, clone your repo under the correct path. If you are building github.com/gruntwork-io/terratest, create that folder structure under home/vagrant/go/src and then clone the repo there and build it.
Please see this answer - https://stackoverflow.com/questions/45428744/golang-unexpected-directory-layout.
I will go ahead and close this since this is not a bug. If this still does not solve your issue please feel free to ask it in any of these forums below:

Stack Overflow with questions tagged "go"

The Go Forum, a web-based forum

Gophers Slack, use the invite app for access. The #general channel is a good starting point.

Go Community on Hashnode with questions and posts tagged with "go"

The golang-nuts mailing list

IRC channel #go-nuts on Freenode

Thanks

@agnivade Its working fine if i pull the dependency using "go get" but as soon as i move to  godep to resolve dependency it pulls everything in vendor folder but while building my project it shows "  unexpected directory layout" . Not sure where i went wrong.
As per your suggestion i changed the GOPATH to "/home/vagrant/go" still no luck.


Some problems I can't explain

Version of Waterdog

git:Waterdog-Bootstrap:1.15-SNAPSHOT:97da972:25 by md_5
BUG - 1
When you break a block, it comes late in your inventory.
BUG - 2
Sometimes, when you swap two items in your inventory, 'SOMETIMES' it is bugging and clearing inventory items.
BUG - 3
Sometimes, when you put item to a chest, 'SOMETIMES' it is bugging and clearing chest items.
BUG - 4
Sometimes, game is very lagging while joining server.
REQUEST - 1
Emotes not implemented.
Server software used:
Nukkit

Hello, the inventory bugs are caused by server software not by Waterdog. The emotes will be implemented with next update (in few days).

Oh? Emotes does work in my network and it's working with WaterDog

Oh? Emotes does work in my network and it's working with WaterDog

@CupidonSauce173 they only appear to those who make the emote

Closing due to inactivity.


404 the requested path couldnot be found in localhost:8000

i have followed every step but my localhost:8000 gives 404 The requested path could not be found error

Check your docker, console and log. Need more information to troubleshoot your issue.


xExchangeHelper: Fix/workaround for Test-Path error

Pull Request (PR) description
Sometimes the Test-Path cmdlet is a little bit buggy and return false even if the path is available. For example if you mount the Exchange ISO image with Mount-DiskImage, the first Test-Path returns false although setup.exe is accessible. To prevent this, it is helpful to run a Get-PSDrive before running Test-Path the first time.
This Pull Request (PR) fixes the following issues
None
Task list

[x ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Hi @malauter , thanks for this submission as well! Do you have any references where this buggyness has been discussed, and Get-PSDrive has been agreed on as the workaround? It sounds plausible, but I want to make sure we're identifying the appropriate root cause issue and solving it as far upstream as possible (i.e. if this is a problem caused by the DSC resource for mounting ISO's, maybe we should address it there instead; or if this is a known issue solved by a PowerShell hotfix or something, perhaps we should check for that fix instead).

Hi @mhendric, the root cause is in the Test-Path cmdlet. But since we are not able to fix this, we can only implement a workaround here to prevent issues during Exchange setup. Please have a look at the following links where this issue has been discussed (some behavior for UNC paths as well as for mounted disk images).
In the environment of my customer I mounted the Exchange ISO and ran into the problem. After adding Get-PSDrive before running Test-Path, it worked.

https://stackoverflow.com/questions/22394904/powershell-test-path-returns-false-when-testing-a-network-share
https://github.com/PowerShell/PowerShell/issues/6864
https://stackoverflow.com/questions/42290665/check-if-iso-is-already-mounted-in-powershell-if-not-then-mount (here you will find the Get-PSDrive workaround)

Hey @malauter , sorry for the late response on this one as well. I don't love the idea of fixing this in xExchange rather than in PowerShell itself, but if we don't reasonably think we can get a PowerShell fix out to all xExchange users, we may have no other choice. That said, do you believe this is 100% reproducible (i.e. could we create a unit test that mounted a sample .iso and then repro'd this bug)? If so, we should probably add a unit test for that. Also, there's another setup related call to Test-Path in Assert-ExchangeSetupArgumentsComplete, so this should probably be addressed there as well. Perhaps you can make a Test-SafePath helper function, and move the Get-PSDrive / Test-Path combo into there. And add comments linking to the articles you found and maybe that we should revisit this at a later point. Sound good?

I'm closing this issue as there has been no work to adress the comment for a long time. This can re-opened or another PR can be sent in to propose the appropriate changes.


Connection to IPv6 Only Servers Failing

Describe the bug
Unable to connect to IPv6 only servers (servers with an AAAA DNS record but no A record). The app provides an error saying the Connection Failed.
Information

Device : [e.g. iPhone 11]
OS : [e.g. iOS 14.7.1]
WebSSH Pro version : [e.g. 16.0.4]

Screenshots

To Reproduce
Steps to reproduce the behavior:

Go to 'SSH’
Touch on '+’ to add a server.
Enter a host that only has an AAAA record / IPv6 support.
Complete remaining the server details.
Touch ‘✔’ to save.
Swipe down to server in list, and click on server to connect.
See error.

Hello @admdly
Thank you a lot for your issue and it's reproduce steps 🙏
I will look at it asap.
Have a nice day ☀

@admdly In order to have more information about this issue, could you do these steps please?

Go to iOS settings
Got to WebSSH settings
Enable "VERBOSE" level
Close (kill) WebSSH
Launch WebSSH
Try to establish your IPv6 connection
Extract useful logs from iOS > Files > WebSSH > log-XXXXXX

Thank you a lot 🙏

@isontheline thank you for your response. Please find the requested log file attached - I have removed any sensitive information.
Hope this will be helpful. 🙂
log-6DF797.txt

@isontheline many apologies - I see the error in the log and upon checking this was my mistake. 🙏
I can confirm it is working as intended with the correct settings. I'll close this issue.

@admdly No worry, thank you so much for your quick feedback ❤
Feel free to open any issue if needed.
Have a nice day ☀


Make _hid_match() public?

In the MNE-BIDS-Pipeline, I need the functionality of mne.utils.mixin._hid_match(); however, the function is not part of the public API.
Is there any chance we could make it public?
cc @agramfort

use a hack like this for now:
if would use here something like this for now:
import numpy as np
import mne

event_id = {'auditory/left': 1, 'auditory/right': 2, 'visual/left': 3,
            'visual/right': 4}

info = mne.create_info(['A'], 1)
data = np.random.randn(len(event_id), 1, 1)
events = np.zeros((len(event_id), 3), dtype=int)
events[:, 0] = events[:, 2] = np.arange(len(event_id)) + 1
epochs = mne.EpochsArray(data, info, event_id=event_id, events=events)
event_id_hid = epochs['left']
print(event_id_hid.event_id)

what we call HID here is a cryptic name. If we expose such en event_id filtering function we need to find a good naming.

@agramfort Thanks for providing this example code!
Alas, the reason why I didn't implement that myself (you had suggested it earlier) was that I wasn't really convinced it's what we'd want in the BIDS Pipeline. If this were just a part of some other package – alright. But for the BIDS Pipeline, I'd like to keep the code readable and free of hacks as good as we can … and this here is clearly a (granted, clever!) hack 😅
But if it's really just about the name of the function, we should try to come up with something better / more descriptive, for example, resolve_event_names(), find_event_names(), events_in_mapping(), …?

ok I slept over it. How about a public function called
mne.utils.filter_event_id(event_id, query: str)
or something like this? I would like to avoid the use of HID in the public API.

query or keys I don't know...

I like the idea.
We could make it such that the function accepts as its first parameter a dict (our good old event_id) or a collection of strings (basically, event_id.keys()).
I think key is good as a name for the second parameter.

works for me

Message ID: @.***>


v0.2.5

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/112568
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.5 -m "<description of version>" 92ac5dea6a3bfd6f1aa985dda47673f3d094fd30
git push origin v0.2.5


Show all charts simultaneously

It seems this is not possible. If the Gnuplot object is created as a background process Gnuplot g("gnuplot &")  as soon as the destructor of the object is called, the plots dissapear.


Unbound variable equivalence

As discussed in https://github.com/ruby-rdf/rdf-n3/issues/15, there is a need to modify equivalence semantics for non-bound variables. Basically, in N3, existential variables are bound to a formula, not the a serialization.
The 0.4.x branch changed BNode equivalence semantics so that #eql? matches only on the same object, or on objects sharing a common ancestor. (In two different serializations :_a refer to different nodes.)
Looking at RDF::Query::Variable, and RDF::Node, it may be that changing the semantics of RDF::Query::Variable#eql? to be the same as RDF::Node when source and target are both unbound variables could work; we'd need to try it both against RDF::Spec and SPARQL::Algebra specs to see if that broke something. This would allow RDF::N3::Reader to allocates different variables for different scopes (at least for non-distinguished variables).
In RDF::Node#eql?, the comparison is made to be sure source and target are the exact same node, or that they share an ancestor. Node#dup sets #original to be the original node, so that ancestry can be tracked. RDF::Query::Variable could probably do the same thing. They way to test this would be to create a branch of RDF.rb and test it against RDF::Spec and SPARQL::Algebra to ensure that specs pass, or that we can satisfy ourselves that the semantics are appropriate.

While not unreasonable, this breaks a lot of the SPARQL specs and is only useful for obscure N3 semantics which are unlikely to be implemented.


RuntimeError("No write pls")

        addi    a0, zero, 1
        addi    sp, sp, 4
        li      t1, 1
        sw      t1, -4(sp)

this code breaks with:
Traceback (most recent call last):
  File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/grosser/Projects/riscemu/riscemu/__main__.py", line 103, in <module>
    cpu.run_loaded(loaded_exe)
  File "/home/grosser/Projects/riscemu/riscemu/CPU.py", line 100, in run_loaded
    self._run()
  File "/home/grosser/Projects/riscemu/riscemu/CPU.py", line 140, in _run
    self.run_instruction(ins)
  File "/home/grosser/Projects/riscemu/riscemu/CPU.py", line 168, in run_instruction
    self.instructions[ins.name](ins)
  File "/home/grosser/Projects/riscemu/riscemu/instructions/RV32I.py", line 56, in instruction_sw
    self.mmu.write(addr, 4, int_to_bytes(self.regs.get(rd), 4))
  File "/home/grosser/Projects/riscemu/riscemu/MMU.py", line 180, in write
    raise RuntimeError("No write pls")

while it works in https://www.kvakil.me/venus/. Any idea what I am doing wrong?

It seems you are writing outside of allocated memory (yes, the error message could probably be improved). The error seems to be your use of the stack pointer, sp should be decremented (stack grows "down") in this emulator (I think thats how I learned it in uni, but I always get the directions confused).
Have you tried:
        addi    a0, zero, 1
        addi    sp, sp, -4
        li      t1, 1
        sw      t1, -4(sp)

Indeed. Let's close this for now.


Avoid punning enum names in documentation

This makes these descriptions easier to read & translate.
Information is not lost because these enum names are available in the function signature.

Information is not lost because these enum names are available in the function signature.

About that... How well does this work in practice when the name in the signature is not translatable and the description only refers to it using plain language? Do people understand that whatever "transfer mode" is in, say, Chinese is the same as "MultiplayerPeer.TransferMode"?

I can confirm just for Swedish that translation wouldn't necessarily carry any implication clearly enough
Maybe instead it should be a link to the type, but we don't support such links, having a link that allows translation of the plain text but linking would be helpful
I'm not even sure the un-punned names are sufficiently clear in English as to what they point to

Would be useful to have a link or the ability to add set what the text of a link is to allow both for ease of translation and of connecting it

How well does this work in practice when the name in the signature is not translatable and the description only refers to it using plain language?

These descriptions are mainly:

TransferMode get_transfer_mode():
Returns the transfer mode of something.
void set_transfer_mode(id: int, mode: TransferMode):
Sets the transfer mode of something identified by [param id] to [param mode].
void complex_operation(id: int, foo: int, mode: TransferMode):
Some description of the complex operations.
[param mode] is the transfer mode of something.

It's clear that "the transfer mode" is the return type of the function, or the type of the named parameter.
Say we have a function signature func 测试(a: 数据传输模式, b: 纹理压缩模式) -> 线程安全策略 and the description of it is:

This is a test function that does random things.
Returns the thread safety policy of this device.
An error is printed when [param a] is not set to a data transfer mode this device can handle.
Some random textures will be transfered using the texture compression mode specified in [param b].

Even though you probably don't know Chinese, it's still obvious what identifier "thread safety policy", "data transfer mode", and "texture compression mode" correspond to.

Okay, as long as we make it clear if something refers to a return value or a named parameter.

Thanks!


Test alternate hashing mechanisms

According to https://twitter.com/jonaso/status/549967116485808128
Instead of taking a mean over horizontal bands and comparing the reduced pixel (ie the 16x16 image) against this mean, make a local mean over a 3x3 pixel cell and compare the pixel against this mean. Set the bit to 1 or 0 according to whether the pixel value is above or below the mean. This will generate a hash with more vivid bit changes and thus less hash collisions.
It is also possible to calculate the gradient for each cell (pixel), and comparing that to a mean for neighboring cells like the previous described method. This will generate a bit that is independent of local intensity variations, only the gradient will remain.
If you use a gradient it could be wise to use two orthogonal vectors to describe the plane, and it could also be wise to only use the absolute value.
One interesting variation is to hash the gradient into bins and form fingerprints from that. Such a fingerprint can be somewhat  resistant to cropping if done right.

The local mean is implemented by @artfwo in this branch: https://github.com/commonsmachinery/blockhash/tree/alternate-hashing
In our test cases, it produces much better hash values in terms of their uniqueness and vividness (if we call it that), but we take a significant hit on false negatives, ie. we get a lot more images that should be matched as the same which aren't.
That said, I've now tried several other window "sizes" for the mean, upwards of 11x11 and in some different shapes. The best contestant so far is a 9x9 window, which generate just a few more false negatives, but cuts the false positives almost in half. A large window of 11x11 generate less false negatives but generate a few more false positives compared to a 9x9 window.
More testing will follow! :)


Genome Browser: Upload user data

Allow users to upload their own data in standard file formats (BAM, BigWig, GFF, etc) and display them as custom tracks.
Genome browser is an important tool for providing integrated view of the multi-omics data and using comparing experimental data to annotations. We need to preserve the basic functionality that allow users to upload their data directly to genome browser and later provide tighter integration with the data in user workspace.
-Maulik

Fixed.


Dialogue asset gets reset after restarting editor.

Issue

Make a UDialogue asset using the UE editor.
Create some dialogue graph.
Test it.
Close all the windows of UE.
Restart UE.
Reopen the UDialogue asset previously worked on.
Observe the graph is empty.
Test again. Observe the dialogue works as if the graph is intact.

I just got hit by this after re-opening my project, so the plugin is not usable for me as a result.  Unfortunate because it seems to be a good experience otherwise.

Okay I see this should be fixed by the 1.2.1 hotfix.  1.2.0 was published to Fab yesterday, now its gone.


Shorthand property name with an initializer in object assignment pattern does not parse

var x;
({ x = 0 } = { x: 0 });

The following does not parse, but it's allowed by section 12.14.5 of the ES6 spec. Specifically, we are failing to parse the production:
AssignmentProperty[Yield] :
     IdentifierReference[?Yield] Initializer[In,?Yield]opt

This is by design. The left hand side { x = 0 } is required to be a valid object literal before it is re-interpreted as an object assignment pattern.


postgresql: bug fix updates for all versions

These postgresql minor updates fix issues that can cause data corruption, which are described in the release notes. It also patches a number of other bugs reported over the last few months.
See: https://www.postgresql.org/about/news/1712/
It would be great if this can be cherry picked on release-16.09 as well.

Thanks, I've cherrypicked this and the 9.6 addition.

Thanks for the merge and cherry picks!


Makes it possible to add extra spaces between the Action and the text…

…. This can make the feature files more readable. https://github.com/intuit/karate/issues/1732
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

Relevant Issues : https://github.com/intuit/karate/issues/1732
Relevant PRs : (optional)
Type of change :

[X] New feature
[ ] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

Modified the regex for the ScenarioActions so that each Action can be executed with spaces around it. But there should be at least 1 whitespace.
Also added a test to prove that it works. Test can be removed of incorperated in the existing testcases ofcourse.
This can improve the readability of the feature files.
And I thought earlier about raising this as an improvement, but now it was the right time for me :)

@gerben86 there are build failures

I fixed one.
The other failure I don't understand. Could you give me a headsup on 'testcontinueOnStepFailure3'?

@gerben86 sorry I don't have time right now - cc @joelpramos since he contributed that test

Ok, got it. I don't know why it only failed in this scenario...

I have a few questions and I'll ask others for opinion as well before merging this cc @peterquiel

does this affect the IDE auto-complete user-experience for Gherkin in Eclipse and IntelliJ
does this regex negatively affect performance of the step-matcher at run-time
until now we seemed to be fine, and in my personal opinion enforced a standard across all teams.
I am assuming that we still enforce at least one space to surround a = or == or contains etc.

1: Can someone else check it? I don't use the auto-complete for Gherking in Eclipse/Intellij
2: I can't imagine that it has a noticable performance impact, because still the regex-matcher is used, although the regex may be a little bigger.
3: I don't see the benefit of this standard, I think scripts can be easier readable if there are more whitespaces, especially if your using multiple def/match statements. But that's up to the user to make use of it or not.
4: Correct, still at least one space is enforced

Is there any reason for def and status to be different to the others:
e.g. def \\h* vs def\\h+
I think it would be good to be consistent.

Good catch, the origin of this lies in the test "testcontinueOnStepFailure3".
That fails if it's consistent with the others. The strange thing is that ONLY this test is failing, all others are passing...

Not sure when I'll have time to pull your branch but looked at the error log and through the code and I suspect it has to something to do with configuring specific keywords that are to be ignored when there are failures. On the Config class there should be a section configuring the continueOnStepFailure, can you maybe check there if anything weird pops up?

@gerben86 change StepRuntime.java:75 to regex.substring(1).split(" |\\\\h|\\\\s")[0]; and feel free to remove the spaces on the step definitions you added to overcome the issue (I think in the status and def keywords).

@gerben86 change StepRuntime.java:75 to regex.substring(1).split(" |\\\\h|\\\\s")[0]; and feel free to remove the spaces on the step definitions you added to overcome the issue (I think in the status and def keywords).

That was indeed the correct fix! Just updated the code, thanks!

@gerben86 I think I merged too soon, can you submit another PR with the extra changes

Yes, new one created.


how to prepare weak labels of S3DIS dataset?

Hi? Could you please share scripts for preparing weak labels of the S3DIS dataset?
Thanks.

See code in prepare_dataset/stanford/preprocess_stanford.py for details.

I just uploaded the code in prepare_dataset/stanford/data_efficient_v2.py.
For fair comparisons, I recommend using our generated point ids.
A quick note, we have tried generating different point ids w.r.t different label ratios and the results do not change too much.


Any one know how to use this library with mysql's AES_ENCRYPT and AES_DECRYPT

As title, or have any example?

Please check out the Raw object: https://medoo.in/api/raw

Thanks, I get it now^_^


Change navigatorPatch function to be compatible with Helsinki and Jakarta

This patch makes the navigator edit module menu work in both Helsinki and Jakarta, (it broke somewhere along the way as they changed the structure of the HTML. I have tested this in Helsinki and Jakarta and it works in both. Hopefully it is future compatible also.

Thanks a lot for the pull request @hayds. Appreciate the effort.
I have actually fixed things for Jakarta and added some more features. I haven't officially released yet as my Share account is broken.
You can download the latest release from dist/... 2.3 and if you think it still needs fixing by all means send me another pull request.
Cheers!

Damn not sure how I missed that. Thanks.
On 10 October 2017 at 21:23, James Neale<EMAIL_ADDRESS>wrote:

Closed #2 https://github.com/thewhitespace/UI16-Developer-Patch/pull/2.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thewhitespace/UI16-Developer-Patch/pull/2#event-1285758756,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AByc785CgwR9czWyCbAL4_Pm8f2vZLI2ks5sq0W0gaJpZM4PzTMx
.

Not your fault! I had done the work and hadn't pushed! Sorry!


Feedback delete menus linger after use

The feedback channel feature includes several menus that allow the user to delete specific posts/messages/thread they have created with the feature, even if they would usually lack permissions to do so. These buttons function as intended, however, the messages remain in the channel after they are used. This contributes to clutter for the user and is a negative experience. However, the user can dismiss the messages themselves if they wish.
Currently, if these buttons are pressed again, the user is notified that the buttons are now useless (hopefully prompting them to dismiss them).
It would be better if these messages could be automatically deleted. This would be a better and more consistent user experience.

This is unfortunately a discord limitation. The only way around this would be to store information on the user, which defeats the purpose.


Default name assignment to animations without names

🦟 Bug fix
Related to #393
Summary
Current implementation for the assimp loader does not check the names of the animations loaded through assimp. This PR adds default names for the animations without names. This approach is similar to how ColladaLoader names the animations.
Checklist

[X] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

The macOS warning here is due to an ffmpeg update and can be ignored.

@Ahcorde,
What I can do CI/CD, it looks failure reason doesnt comes from my code?

What I can do for CI/CD, it looks failure reason doesnt comes from my code?

I agree, the GDAL errors are not because of this PR.  With approval, we can go ahead and merge here.

Is the intention to still to target this to main, or should it target gz-common5 ?

ABI checker likely to fail until there is some release from main, so this is good to go.


error to build training data

I got an error when running the build training data script:
python convertHTML/build_code.py \
    --model_path_or_name /path/to/llamamodel \
    --dataset_name rico25 \
    --dataset_path data/rico25-max25 \
    --save_path data/rico25-max25/html_format \
    --bbox_quantization code \
    --consistency_num 10 \
    --add_task_instruction;

console outputs:
begin to save train file >>> data/rico25-max25/html_format
  0%|                                                                                | 0/35851 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/mnt/data/code/LayoutNUWA/convertHTML/build_code.py", line 647, in <module>
    for i, batch_inputs in enumerate(train_dataloader):
  File "/mnt/data/code/LayoutNUWA/convertHTML/build_code.py", line 559, in __iter__
    yield self.custom_function(data, i, self_consistency=self_consistency)
  File "/mnt/data/code/LayoutNUWA/convertHTML/build_code.py", line 402, in custom_function
    bbox_cond_seqs = [
  File "/mnt/data/code/LayoutNUWA/convertHTML/build_code.py", line 403, in <listcomp>
    self.cond_bbox_prefix.format(categories=cate, bbox_html=bbox_html)
AttributeError: 'CustomDataLoader' object has no attribute 'cond_bbox_prefix'

I have check the source code and there is not attribute 'cond_bbox_prefix' in CustomDataLoader.

I found that cond_box_prefix and cond_cate_prefix are only used to generate the test_llama_numerical.jsonl file, but all executable scripts (including evaluation.py) do not use this file.
(Instead, evaluation.py uses the pre-generated data/generated_results/rico/golden.jsonl file.)
So, it seems to be solved by erasing all the cond_bbox_prefix and cond_cate_prefix variables and their dependent codes, or simply inserting dummy strings like:
        self.cond_bbox_prefix = ""
        self.cond_cate_prefix = ""

I found that cond_box_prefix and cond_cate_prefix are only used to generate the test_llama_numerical.jsonl file, but all executable scripts (including evaluation.py) do not use this file. (Instead, evaluation.py uses the pre-generated data/generated_results/rico/golden.jsonl file.)
So, it seems to be solved by erasing all the cond_bbox_prefix and cond_cate_prefix variables and their dependent codes, or simply inserting dummy strings like:
        self.cond_bbox_prefix = ""
        self.cond_cate_prefix = ""

Yes, I delete the irrelevant code.

Thanks for your attention to our work and sorry for my late reply. We will clean the code soon, and you can refer to the original paper to delete some irrelevant code (this part of code is mainly for my ablation studies).


Add osmobuilder image to create binaries for amd64 and arm64 for a release

Closes: #XXX
What is the purpose of the change
This PR proposes a new release process that:

creates the osmosisd binaries for arm64 and amd64 statically linked agains libcosmwasm
creates a releases/ folder with the binaries, archives, source code and sha256checksum

To use it, make sure to be in the root of the repository and run:
git checkout <TAG>
make -f contrib/images/osmobuilder/Makefile release

This will create a release/ folder with all the appropriate files.
To statically link the binary for different architecture the trick is to build the image while building the docker image via docker buildx.
This process however it's slow when building arm64 from amd64 (or viceversa)
Brief Changelog

Add osmobuilder image to build the images

Testing and Verifying
To use it, make sure to be in the root of the repository and run:
git checkout <TAG>
make -f contrib/images/osmobuilder/Makefile release

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not applicable

Yeah! That would be the ideal setup, just wanted to put this here early in case was needed for v9. I will start working on the CI

Codecov Report

Merging #1584 (cf573fe) into main (20835e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   19.54%   19.54%
=======================================
  Files         242      242
  Lines       32262    32262
=======================================
  Hits         6307     6307
  Misses      24801    24801
  Partials     1154     1154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20835e6...cf573fe. Read the comment docs.


A new release request

https://github.com/firebase/firebase-admin-java/pull/1003 bumps the version of protobuf, where the old version currently gets flagged with a CVE.
A new release of firebase-admin with this PR merged (which it already is) should fix this

Fixed in #1013


TextEdit border style doesn't work and corner radius doesn't do anything

Tested versions

Reproducible in 4.2.2.stable.mono
If I remember right, this may have worked in 3.x, but I'm not sure. I do remember first noticing this problem when porting my project from 3 to 4 and fixing up the theme. I was able to fix every other theme element except this.

System information
Godot v4.2.2.stable.mono - Fedora Linux 40 (Workstation Edition) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX (RADV NAVI31) () - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)
Issue description
Trying to apply a style with borders to a TextEdit seems to do nothing. The background colour applies, but border doesn't.
Here's how the TextEdit looks with the theme editor having a stylebox with borders set on it:

I tried to look for existing issues but I didn't find any exactly about this, I only found these kind of related problems with TextEdit styling:

https://github.com/godotengine/godot/issues/74445
https://github.com/godotengine/godot/issues/59639
https://github.com/godotengine/godot/issues/29163

Steps to reproduce

Create a theme and add a new StyleBoxFlat for normal in TextEdit
Try to specify a border width, corner radius, and border colour
Observe how the style does not apply for some reason, and how the same stylebox works for example with LineEdit

Minimal reproduction project (MRP)
Here's my exact theme file in case it matters: https://github.com/Revolutionary-Games/Thrive/blob/a83a0d0a3211b07f9968adca63fd86b32f74fc19/src/gui_common/thrive_theme.tres

Your TextEdit theme color theme_override_colors/background_color is set to full opacity black, this is covering the StyleBox. You can remove the override or set the opacity to 0, the border should work.

Thank you so much. That was exactly the case and removing that style part made the stylebox work. I had tried the exact same stylebox on a LineEdit and that worked fine, which is why I opened this issue. Interestingly it looks like that background color property doesn't even exist for a LineEdit so it is a TextEdit specific feature for some reason.


GraphQL tests failing in v4.0.11

NetBox version
v4.0.11
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

cd develop
docker compose up
docker exec -it develop-netbox-1 /opt/netbox/netbox/manage.py test netbox_bgp

Significant failure occur around graphql
Expected behavior
Tests pass}

It doesn't surprise me as I didn't release them for 4.0
That's why I made #200
Or am I missing something?

with #200 - Ran 205 tests in 2.560s
FAILED (failures=13)
Destroying test database for alias 'default'...

Hmmm ... strange, I would not make a PR if the test failed.
I did them without #204 , idk if it modifies the behavior

On which netbox version ?
On Thu, 3 Oct 2024, 13:59 Pl0xym0r, @.***> wrote:

Hmmm ... strange, I would not make a PR if the test failed.
I did them without #204
https://github.com/netbox-community/netbox-bgp/pull/204 , idk if it
modifies the behavior
—
Reply to this email directly, view it on GitHub
https://github.com/netbox-community/netbox-bgp/issues/214#issuecomment-2391361107,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKJY34VXMGOUH3PGEZXZI3ZZU5UJAVCNFSM6AAAAABPJLHV6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRGM3DCMJQG4
.
You are receiving this because you were assigned.Message ID:
@.***>

At that time, I think I was on 4.0.7


molecule matrix command produces unreadable colored output

Prerequisites

[X] This was not already reported in the past (duplicate check)
[X] It does reproduce it with code from main branch (latest unreleased version)
[X] I include a minimal example for reproducing the bug
[X] The bug is not trivial, as for those a direct pull-request is preferred
[X] Running pip check does not report any conflicts
[X] I was able to reproduce the issue on a different machine
[X] The issue is not specific to any driver other than 'default' one

Environment
RHEL 9 Workstation with GNOME
molecule and molecule-podman just installed into a fresh virtualenv
(test) master$ molecule --version
molecule 6.0.3 using python 3.9
ansible:2.15.8
default:6.0.3 from molecule
podman:2.0.3 from molecule_podman requiring collections: containers.podman>=1.7.0 ansible.posix>=1.3.0
What happened
$ molecule matrix test
silly colored output...

I think in this case it makes sense to attach screenshots. First the settings of my Gnome Terminal. Second the unreadable output of the command.

Reproducing example
$ molecule matrix test
silly colored output...

I PR to address it it would be welcomed. Thanks for reporting it!


API vs. UI

Identify the differences between API and UI on Wordnik.

As covered in our last hack session, the ability to use the wordnik api test interface accomplishes this for us. We have a simple interface to test calls and see data returned to determine what data/objects we actually have available from the API to drive behavior in our game.
That is, we can take a question of the form "would the game be able to do X" and transform it as follows:
In order to do X, the game would have to (for example):

know what lists a user has
know what words are on those lists
remove a word from list A
add a word to list B

And each of these items above are things that we can directly test against the wordnik api before writing any code.


Release new version

I noticed that there are unpublished changes which update the dependencies.

I would love a new release with the updated dependencies.
@bergos @cw00dw0rd could one of you look in to this?

Just released v3.1.1


Logic error？

This judgment always seems to be true

You are right. Good catch, fixed with f1f14f52d1ce292d756cef05b78273665454d612


riff image relocate option for not flattening image names

The --flatten option was deleted by https://github.com/projectriff/riff/issues/901 and became the only option. Flattening should remain the default behaviour, but for registries which do support hierarchical names, we should add a flag such as --deep to turn off flattening.
However, with flattening turned off, we should also try to reduce the likelihood of collisions for images with short paths, e.g.:
reg1.org/user1/x
reg2.org/user2/x

No longer required since #949.


feat: add identity linking methods

What kind of change does this PR introduce?

Adds 3 new methods: unlinkIdentity, linkIdentity, getUserIdentities to support the new identity linking endpoints
All methods require the user to be authenticated
This PR should only be merged once the gotrue release with the new identity linking endpoints are deployed

TODO

[x] fix issue where user is logged out if linking fails

I think I've found a few issues with this, specially using twitter as the provider.

After doing unlinkIdentity for twitter, I can still sign back in with the same Twitter account and it gets added/linked back to the same old account automatically.

I'm not sure if this is related, unlinkIdentity remove the record from the auth.identities table but it doesn't clean/delete the data in raw_user_meta_data in the auth.users table (which is where the twitter data is stored).

linkIdentity using 'twitter as the provider doesn't work as expected, it returns error code 500 not found and request token doesn't match token in callback. It works fine for google and discord as the provider. It also works fine when I use with signInWithOAuth, so this should not be a Twitter APP settings issue on my end. I can see the error in the URL after the redirect back from Twitter. Apart from the error, it also logs me out of the application.

/account?error=server_error&error_code=500&error_description=Request+token+doesn%27t+match+token+in+callback#error=server_error&error_code=500&error_description=Request+token+doesn%2527t+match+token+in+callback
@kangmingtay would you be able to help please?

Hey @chhuang,
Thanks for filing the issue and for your patience with us while we work through the tickets. Might need to trouble you for a bit of information. For:

After doing unlinkIdentity for twitter, I can still sign back in with the same Twitter account and it gets added/linked back to the same old account automatically. The Twitter account is using a different email address, I'd assume if I unlink it, and then do a new sign in/sign up, it would create a new account for me based on the email from the Twitter account, but that is not the case.

As I understand the first steps would be:

User signs in with Google OAuth<EMAIL_ADDRESS>and then signs in with Twitter OAuth (primary_email:  john@gmail.com). Let's call this UserA.
Developer calls unlinkIdentity for twitter . UserA now has one identity.

Mind sharing more about the next step?

I can still sign back in with the same Twitter account and it gets added/linked back to the same old account automatically.

I am guessing here but would it be:

User signs in with OAuth via Twitter OAuth (primary_email<EMAIL_ADDRESS>and Identity is again linked to UserA  (?)

If you have a linked video that would be very helpful

I'm not sure if this is related, unlinkIdentity remove the record from the auth.identities table but it doesn't clean/delete the data in raw_user_meta_data in the auth.users table (which is where the twitter data is stored).

I think unlinkIdentity only updates the providers app_meta_data and does not touch raw_user_metadata). Do you mind sharing what fields remain  in raw_user_metadata and what you'd like cleared?

linkIdentity using twitter as the provider doesn't work as expected. It returns error code 500 not found and request token doesn't match token in callback. It works fine for google and discord as the provider. It also works fine when I use with signInWithOAuth, so this should not be a Twitter APP settings issue on my end. I can see the error in the URL after the redirect back from Twitter. Apart from the error, it also logs me out of the application.

I'm spitballing and will need to check further but there might be a mismatch in the one of the fields of the JWT.  If you see any differences that stand out let us know.
Thanks!

Thanks for looking into this @J0
Scenario 1:

User A signs in with Google<EMAIL_ADDRESS>User A links Twitter (user-a-twitter@gmail.com), the linking fails. Important to note that this is a brand new Twitter account that it has never been used to create or sign in before in our system.
User A is redirected back and logged out automatically: {"code":401,"msg":"invalid claim: missing sub claim"}

In the same scenario, User A can sign in with Twitter<EMAIL_ADDRESS>with no problem. I only did this after I failed to link it to<EMAIL_ADDRESS>in step 1. But now I have created 2 different accounts, one with Google and one with Twitter. Obviously this was not the initial intention.
Scenario 2:

User A signs in with Google<EMAIL_ADDRESS>User A adds/links Twitter to the account (different email<EMAIL_ADDRESS>User A signs out
User B signs in with Google<EMAIL_ADDRESS>User B adds/links Twitter (user-a-twitter@gmail.com), the linking fails because email is already used and linked to User A
User B is redirected back to the site and logged out automatically

I think the UX can be improved for step 7? I can see this is in the TODO of this PR and it's checked, can you confirm it's working as intended please?

Scenario 3:

User A signs in with Twitter<EMAIL_ADDRESS>User A links Discord to the account (different email<EMAIL_ADDRESS>User A tries to unlink Twitter, the unlink fails: {"code":403,"msg":"Unable to unlink identity due to email conflict"}

Unlike the other scenarios, here the user is not logged out automatically. I can also unlink my Discord without problem.
What is the reason I can't unlink my Twitter here? Since I've also added Discord, I should be able to unlink Twitter right?

Hi @chhuang, thanks for providing all these details.
Scenario 1 will be fixed by this PR.
Scenario 2 is expected but you should not be logged out in step 6 - i'll look into why that's happening in the client library
Scenario 3 happens because you already have another user / identity in your db that uses the email<EMAIL_ADDRESS>When you unlink the twitter identity from the user, we need to update the auth.users.email column which has a unique constraint on it. If there is another user that initially signed in with discord using<EMAIL_ADDRESS>this email will already be used in the auth.users table. This is a known issue and we're working on relaxing the email constraint on oauth identities so that this error goes away.

Hi @chhuang, thanks for providing all these details.
Scenario 1 will be fixed by this PR.
Scenario 2 is expected but you should not be logged out in step 6 - i'll look into why that's happening in the client library
Scenario 3 happens because you already have another user / identity in your db that uses the email<EMAIL_ADDRESS>When you unlink the twitter identity from the user, we need to update the auth.users.email column which has a unique constraint on it. If there is another user that initially signed in with discord using<EMAIL_ADDRESS>this email will already be used in the auth.users table. This is a known issue and we're working on relaxing the email constraint on oauth identities so that this error goes away.

Thanks @kangmingtay for the fix!
Can you tell me how to get the fix? Which library should I update?


Update for deprecated features

Coverage increased (+3.2%) to 62.492% when pulling 5f301148afdcddc7ab337cdb23b4b51871445df5 on dev into 75d1e0d46bbc65e22792eab51e14a3f1b6d1ba84 on master.


Make cache size a function of memory size

In preparation of a z-stack (and probably a good idea anyway) is to utilize the ability to make the cache size a function of memory as per https://github.com/uber/deck.gl/pull/4246

Closed by deck.gl finishing the issue


Write blog for API agent

Review the requirement to write a blog post. It's likely we will want to refactor the APIAgent. See @dbrewster

We are going to put this in docs


Update Package.swift

Updating Package.swift to add support for Swift 4.2

This breaks our support for some Swift versions

@mxcl it seems possible... https://github.com/apple/swift-protobuf/blob/master/Package%40swift-4.2.swift
I will try that soon and push new commits to this PR

Would be good if we can add a travis test to verify we are actually getting 4.2 out of the swift compiler. If you can't think of a way, I'll merge and I can try to figure it out at a later time.

@mxcl I'm not sure how this could be done. One way maybe would be replace the swiftLanguageVersions to the old format [3, 4] and check if it fails. Do you have any suggestion how to do it?

I published 6.4.1


ClassfileManagerType to ClassFileManagerType name refactoring

Fix remaining naming inconsistency described in #254 .

Hi @sepulkarz,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

[error] /home/travis/build/sbt/zinc/internal/zinc-scripted/src/test/scala/sbt/internal/inc/IncHandler.scala:336: type ClassfileManagerType is not a member of package xsbti.compile
[error]       val transactional: xsbti.Maybe[xsbti.compile.ClassfileManagerType] =
[error]

Thanks, I must have overlooked it somehow. Fixed now.

CI is green, we got two signoff's, merging! Thanks again @sepulkarz.


Add yarn support and use it for Travis CI

This will resolve #249

Changed the title because it was misleading. I wouldn't approve replacing npm with yarn, but this PR adds yarn support as an opt-in feature. I also verified this improves Travis CI runs performance.
Thanks for the contribution!!! :D

😆 Thanks.


Placeholder not visible with Guide ON

I know it is not true on the demo page (it is working perfectly there), but when I try it like this:
`$(function () {
var keyMask = [/[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, '-',
/[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, '-',
/[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, '-',
/[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/, /[A-Za-z0-9]/];
        var myMaskInput = document.querySelector("#maskedInput");

        var maskedInputController = vanillaTextMask.maskInput({
            inputElement: myMaskInput,
            showMask: true,
            keepCharPositions: true,
            guide: true,
            placeholderChar: '_',
            pipe: function (conformedValue, config) {
                    return conformedValue.toUpperCase();
            },
            mask: keyMask,
        });
    })`

and
<input class="form-control" id="maskedInput" placeholder="AAAA-AAAA-AAAA-AAAA" value=""/>
(plain JS and HTML)
I am not able to see the placeholder - the guide is shown permanently - even when there is not any user input.
What makes the difference to this and the demo page ?
Thanks in advance!

showMask is set to true.. this is a new recently added feature, tat is perhaps not very well documented.
When showMask is true, then when the vallue is empty it will display the mask, ____-____-____-____.... When false, then the placeholder (or nothing) will be displayed when the value is empty.

Thanks a lot - that solved my problem!


K.Dᴀᴠɪs: Watch (?:aids\W*){2,}

K.Dᴀᴠɪs requests the watch of the watch_keyword (?:aids\W*){2,}. See the Metasmoke search here and the Stack Exchange search here.

(?:aids\W*){2,} has been seen in 0 true positives, 0 false positives, and 0 NAAs.

You can close this. Should have been caught by repeated words. Haven't had coffee this morngin :(

Coverage remained the same at 65.199% when pulling eb6f45f3bc99871f6f54d8859a306f2248450b3c on auto-blacklist-1521820511.1929553 into 8d595dae1e1982a7daeea4625c683bf964ab8d6c on master.


fix: replace jamba-instruct usage with jamba-1.5, add documentation

Update docs to use Jamba-1.5 and move jamba-instruct to the legacy models list.
Log http headers in http_client

@pazshalev Please resolve conflicts and rename jamba-1.5 to jamba-1.5-mini :)


STORM-2578: Apply new code style to storm-elasticsearch

@HeartSaVioR could you review the changes? Thanks.

Hi @HeartSaVioR , reduced the value to 0.

thanks @HeartSaVioR, change the fix accordingly.


False positive performance SpreadOperator in case of pass-through vararg

Expected Behavior
When using the spread operator to pass on a vararg array from a vararg function implementation to a vararg function call, the spread operator should not be reported.
Observed Behavior
The spread operator passing a vararg array from a vararg function implementation to a vararg function call is reported by Detekt as a performance issue because of the spread operator.
This is wrong because, in the case of passing vararg to vararg, the spread operator does not (anymore since Kotlin 1.1.60, 1.2-Beta2) create a new array and thus is not a performance issue. Refer to the following ticket on Kotlin: https://youtrack.jetbrains.com/issue/KT-20462
Steps to Reproduce
Call one vararg method from another using the spread operator.
A popular example is to call runApplication(args) from main(vararg args: String) in Spring applications.
The following code should be accepted as correct by detekt:
package com.example

import org.springframework.boot.autoconfigure.SpringBootApplication
import org.springframework.boot.runApplication
import org.springframework.context.ApplicationContext

@SpringBootApplication
class ExampleApplication

lateinit var appContext: ApplicationContext
    private set

fun main(vararg args: String) {
    appContext = runApplication<ExampleApplication>(*args) // ⇐ Point of Interest
}

Context
The impact is low.
The situation of passing through vararg is relatively rare.
It is easy to deal with the situation by using a @SuppressWarnings("SpreadOperator") annotation on the corresponding method.
Your Environment

Version of detekt used: 1.14.1
Version of Gradle used (if applicable): 6.6.1
Operating System and version: Kubuntu 20.04 LTS
Link to your project (if it's a public repository): -

As an enhancement, the check could look at the actual byte code generated. If the spread operator leads to a new array instantiation, the spread operator is a performance issue and should be reported. If the spread operator passes through an existing array, the spread operator is not a performance issue and should not be reported.

Thank you, works like a charm now! ❤


Subscription address exception

Please read the instruction and answer the following questions before submitting your issue. Thank you.
Please answer all the questions with enough information. All issues not following this template will be closed immediately.
If you are not sure if your question is truely a bug in V2Ray, please discuss it here first.

What version of V2Ray are you using (If you deploy different version on server and client, please explicitly point out)?
V3.18

What's your scenario of using V2Ray? E.g., Watching YouTube videos in Chrome via Socks/VMess proxy.
Watching YouTube videos in Chrome via Socks/VMess proxy.

What did you see? (Please describe in detail, such as timeout, fake TLS certificate etc)

订阅地址会自动添加很多异常地址，我更换不同的版本都会这样。
Automatically add many exception subscription address

What's your expectation?
订阅地址应该只有我自己添加的。
The subscription address should be one

Please attach your configuration file (Mask IP addresses before submit this issue).

官网下载最新版，未修改任何配置，只添加一个订阅。
Server configuration:
    // Please attach your server configuration here.

Client configuration:
    // Please attach your client configuration here.

Please attach error logs, especially the bottom lines if the file is large. Error log file is usually at /var/log/v2ray/error.log on Linux.

Server error log:
    // Please attach your server error log here.

Client error log:
    // Please attach your client error log here.

Please attach access log. Access log is usually at '/var/log/v2ray/access.log' on Linux.

    // Please attach your server access log here.

Other configurations (such as Nginx) and logs.

If V2Ray doesn't run, please attach output from --test.

The command is usually /usr/bin/v2ray/v2ray --test --config /etc/v2ray/config.json, but may vary according to your scenario.

If V2Ray service doesn't run, please attach journal log.

Usual command is journalctl -u v2ray.
Please review your issue before submitting.

这个要找v2rayN的文档，那是另一个项目


I'm having issues understanding how to use this.

I can't figure out how to use this library on the clientside. I will happily donate if someone can help me figure it out.  The instructions start off talking about using it on nodejs and webassembly, but all i want is to use it with vanilla javascript.
The first code snippet I see is this:
const monerojs = require("monero-javascript");

// connect to daemon
let daemon = await monerojs.connectToDaemonRpc("http://localhost:38081", "superuser", "abctesting123");
let height = await daemon.getHeight();            // 1523651
let feeEstimate = await daemon.getFeeEstimate();  //<PHONE_NUMBER>
let txsInPool = await daemon.getTxPool();

The problem is, require is only defined in NodeJS, and the next lines of code dont even make sense on their own, you cant use "await" without "async", and theres no async here. I feel theres a critical lack of context on whats going on here, and if this is even what im supposed to be using for the clientside or not.
Then I go over to Part 2 ( https://github.com/monero-ecosystem/monero-javascript/blob/master/docs/developer_guide/getting_started_p2.md) and it's talking about nodejs and python being dependencies. What? What do those two things have to do with clientside javascript? The next thing i see is:
const monerojs = require("monero-javascript");

main();
async function main() {

  // create a random keys-only (offline) stagenet wallet
  let walletKeys = await monerojs.createWalletKeys({networkType: "stagenet", language: "English"});

  // print the wallet's attributes in the browser window
  document.getElementById("wallet_mnemonic_phrase").innerHTML = "Mnemonic phrase: " + await walletKeys.getMnemonic();
  document.getElementById("wallet_address").innerHTML = "Address: " + await walletKeys.getAddress(0, 0); // get address at account 0, subaddress 0
  document.getElementById("wallet_spend_key").innerHTML = "Spend key: " + await walletKeys.getPrivateSpendKey();
  document.getElementById("wallet_view_key").innerHTML = "View key: " + await walletKeys.getPrivateViewKey();
}

Which again, require is not defined in vanilla javascript.
So how do i use this in vanilla javascript only? Whats the simple explanation? Which exact files do i need? What line of code will run when i type them in?
I dont see any alternatives to this library so i cant proceed until I understand how to use this.

I tried using browserify to make it usable by javascript, but it says it cannot walk the dependency graph. I am unsure what else to try at this point.
browserify public/src/monero-javascript-master/index.js > monero-js-bundle.js
Error: Can't walk dependency graph: Cannot find module 'promise-throttle' from '/home/anonymous/Documents/Spederan/speedrunjs/public/src/monero-javascript-master/src/main/js/common/HttpClient.js'
    required by /home/anonymous/Documents/Spederan/speedrunjs/public/src/monero-javascript-master/src/main/js/common/HttpClient.js
    at /usr/local/lib/node_modules/browserify/node_modules/resolve/lib/async.js:146:35
    at processDirs (/usr/local/lib/node_modules/browserify/node_modules/resolve/lib/async.js:299:39)
    at isdir (/usr/local/lib/node_modules/browserify/node_modules/resolve/lib/async.js:306:32)
    at /usr/local/lib/node_modules/browserify/node_modules/resolve/lib/async.js:34:69
    at FSReqCallback.oncomplete (node:fs:207:21)


Synapse basic fixes

Fixes For:

btcli inspect
args for blacklisting and priority queue
sample configs for core validator

Pull Request Test Coverage Report for Build 59594ba9-d372-435a-ab61-18ea68e91650

0 of 0   changed or added relevant lines in 0 files are covered.
1495 unchanged lines in 38 files lost coverage.
Overall coverage decreased (-2.2%) to 58.373%

Files with Coverage Reduction
New Missed Lines
%

bittensor/_config/config_impl.py
1
88.71%

bittensor/_dataset/thread_queue.py
1
97.14%

bittensor/_endpoint/endpoint_impl.py
1
80.0%

bittensor/_endpoint/init.py
1
85.96%

bittensor/_keyfile/init.py
1
90.91%

bittensor/_logging/init.py
1
76.41%

bittensor/_wallet/wallet_mock.py
1
72.97%

bittensor/_metagraph/init.py
2
76.92%

bittensor/_serializer/init.py
2
62.5%

bittensor/utils/stats.py
2
95.24%

Totals

Change from base Build a903a396-78ca-4e82-a246-681b1dca0365:
-2.2%

Covered Lines:
3517

Relevant Lines:
6025

💛  - Coveralls