Added two new correlation metrics, Pearson and Concordance Correlation Coefficients.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.46%. Comparing base (3d32481) to head (0151c2d).

:exclamation:  There is a different number of reports uploaded between BASE (3d32481) and HEAD (0151c2d). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (3d32481)
HEAD (0151c2d)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20364       +/-   ##
===========================================
- Coverage   78.87%   57.46%   -21.42%
===========================================
  Files         512      513        +1
  Lines       49266    49320       +54
  Branches     7953     7953
===========================================
- Hits        38861    28344    -10517
- Misses       8546    19170    +10624
+ Partials     1859     1806       -53

Flag
Coverage Δ

keras
57.46% <100.00%> (-21.28%)
:arrow_down:

keras-jax
?

keras-numpy
57.46% <100.00%> (+0.04%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@fchollet I resolved the naming comment. Do you have an idea about the error in the torch tests? It doesn't seem to be related to my code at all, and actually, this test passed in the early commits in this PR and then suddenly appeared in the last 2 commits.

@fchollet I resolved the naming comment. Do you have an idea about the error in the torch tests? It doesn't seem to be related to my code at all, and actually, this test passed in the early commits in this PR and then suddenly appeared in the last 2 commits.

I am facing the same problem. This indicates an issue with the backend?

Looks challenging to debug since we have no indication where the infringing code might be. Not directly related though. Might be triggered by a new dependency version.


Add RetryingMetastore for gRPC Metastore

You went slightly overboard with the unit testing, but I'd take that any day over no tests at all.

I love tests


Added spec and type annotations

Coverage increased (+0.1%) to 85.315% when pulling 15ec255ee242279092885d1eba3ed680bf9eb650 on feature/spec_type into a3b13cc7d166ca0fd0a6d2b28eb311b4e9109f45 on master.


[Win11] PowerRename appears 2 times

Microsoft PowerToys version
0.60.1
Running as admin

[ ] Yes

Area(s) with issue?
PowerRename
Steps to reproduce
(I added into Windows 11 the registry key to 'Show more options' by default in Explorer, I am a pro user and don't need and extra click each time i right click [{86ca1aa0-34aa-4e8b-a509-50c905bae2a2}])
Right click on a group of files to rename will show the PowerRename item 2 times:

If I set the PowerToys option to show the PowerRename on the "Extended context menu only", it doesn't appear at all.
✔ Expected Behavior
Appear only 1 time
❌ Actual Behavior
Currently it appears 2 times
Other Software
No response

Thanks for your message. This is a Duplicate of an other issue. Additional comments may be added there. /dup #19590
(@jaimecbernardo correct me if I'm wrong)


Feature: Routes for pfp and banner

Describe your Idea
An API to get the pfp and banner without having to know the image hash

Resolved by 7bda90a


Force redirect from heroku to official domain

We got a few links floating around to the herokuapp URL.
Lets do a 301 redirect if the domain is localhost (or PRODUCTION in NODE_ENV?).

This is also true for the MozHacks post, at least the last time I checked. You might want to update that (whether you add the redirect or not).

I've updated the Moz Hacks post to reflect the new URLs.  Thanks for the shout @fbendr!

Fixed this a few days ago


nixos/release-small: remove minimal installer ISOs

Description of changes
These take up 2 GiB every time anything in the minimal installer changes, or up to 4 GiB per day. We already stopped building Amazon images in 9426d90c6784aa19f11a8cfc5171a46f0b21cd94. Meaningful installer changes are rare enough, and the couple of days it takes for them to trickle down to the large channel acceptable enough, that this is mostly a waste of space.
This should buy enough slack to build stdenv on staging without contributing to cache size growth.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Change looks good, but requires a channel-scripts round-trip first.

Opened https://github.com/NixOS/nixos-channel-scripts/pull/74 and pushed a release notes entry.

Except those don’t work on aarch64-linux because they use legacy BIOS 🫠
Added nixos.tests.installer.simpleUefiSystemdBoot as a reasonable proxy for the contents of the installation ISO which does build on aarch64-linux.

Channel-scripts deployed, this should be good to go now.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-image-downloads-as-torrent/55870/5


build: disable generation of package-lock since it is not used

With package-lock.json ignored, it's better to just tell npm not to generate it at all.  This removes the need for developers on the package to keep deleting package-lock.json and re-installing to get the latest patch versions of transitive deps.

This removes the need for developers on the package to keep deleting package-lock.json and re-installing to get the latest patch versions of transitive deps.

I am not quite sure what you meant here.

Sure!  Let me explain :)  If you keep a package-lock.json in source control, every time someone modifies the dependency tree there could be an update to the lock file.  Any change to that file would be included in the commit.
When you ignore that file, it means that this can happen:

I clone the repo, run npm install
It generates a lock file
I wait a few weeks
I git pull to update my branch, no lock file updates cause it's ignored
I run npm install

At this stage, I am going to have tons of old packages sitting in my node_modules folder, because they match the last known state of the lock file.  Unless I explicitly delete the lock file, and re-run npm install, I will have old patch versions that match the semverity of the request version, but are out of date.
If npm install is instructed to generate no lock file at all - this issue goes away :)

Thx for the explanation, I will add this soon.


Change Dockerfile to a dual-staged build/run approach

Pushing this Dockerfile to integrate with quay.io pipeline, and to test again ci-operator integration

Changes made:

Lock apline version to 3.8
Added yaml update/clean
Added user/UID config (based on latest Dockerfile generated by operator-sdk)

Build notes added to the README file.
Also added LABELS to the Dockerfile to tag the img itself


Port "Perception Pipeline Tutorial" tutorial

Port tutorial to ROS2.

haven't it been migrated yet? is there any progress?

Actual loading of sensor data is implemented here: https://github.com/ros-planning/moveit2/pull/1387
I'll probably circle back in about a week and try a first pass of cleaning up this tutorial

More discussion is happening in https://github.com/ros-planning/moveit2_tutorials/issues/583 about the same issue. Suggest to close this?

Not ported: https://moveit.picknik.ai/main/doc/examples/perception_pipeline/perception_pipeline_tutorial.html

Closed by #906


Obfuscar breaks Task

Obfuscar breaks Task even tho I skipped everything. Skipped renames, skipped properties, skipped string obfuscation... yet it still does something with JObject
Original
await LIB.page.Client.SendAsync("Page.setDownloadBehavior", new
{
	behavior = "allow",
	downloadPath = Path.GetDirectoryName(libPath)
}, true);

Obfuscar
await LIB.page.Client.SendAsync("Page.setDownloadBehavior", new A<string, string>("allow", Path.GetDirectoryName(libPath)), true);

This causes the following error:
PuppeteerSharp.MessageException: Protocol error (Page.setDownloadBehavior): Invalid parameters Failed to deserialize params.behavior - BINDINGS: mandatory field missing at position 8

Duplicate to #130. You might try the solution there.


No way to set notification type?

In a previous version of the library, there seems to be a ToastNotificationType enum that you could pass in to the Notify method to choose an error or warning.
Is this functionality no longer present or is there a new method?  Forgive me if I have missed something...
thank you

That ended in version 2.0.4. The plugin switched to use the native toast/notification API's. You can set the icon yourself, changing colors as previously done, is no longer possible.


Add Google Analytics

Fixes #4
Uses Google Tag Manager... NB there are some warnings in Google Analytics about Universal Analytics expiring July 1, 2023. But I think this should be OK for now.

Pinging @wakibi @davidebukali on this :))


dx: add global state management

Closes #169

#169

I was doing some research on this, and I'm wondering if we need Redux for this app.
What do you think about simply using React Context for it, instead?

What do you think about simply using React Context for it, instead?

Redux Toolkit provides a better and easier developer experience. Updating the shared state is also easy and then there is the Redux devtool for debugging purposes. The website is going to be large and dynamic in nature. Redux Toolkit is best suited for our use case.

I think Redux is just way too complex for what we have right now. All we need is basically a way to keep track of the user session and the user.
More context.
We've had a discussion about it on #share-resources on Discord, too.

I agree with YK. Redux is kind of an old giant. For this apps purpose React Context could definitely work

@iShibi are you still working on this? If not, I'll close it and go back to #167.


Added Bottom Navigation in Android (Kotlin)

Description 📜
In this documentation I have added everything related to Bottom Navigation in Android (Kotlin) with this I also have also beautified my code and also allowed users to directly copy the code directly from the docs.
THANK YOU
Fixes #1426

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Android Dev #(Kotlin)

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

You have added a single space after filename .md, it should be filename.md
Again in the several bold words you have added space **like this ** fix this too. it should be like this

Done the changes @rahulsain .
Thankyou

@eshan1925 you have done a great job. Though here java code is not required, as a separate domain is working on java related works. I think no need to any change. But you don't need to do in both languages for your further PRs. BTW nice work.

@eshan1925 you have done a great job. Though here java code is not required, as a separate domain is working on java related works. I think no need to any change. But you don't need to do in both languages for your further PRs. BTW nice work.

Thanks so much @sitamadex11 I will definitely keep your points in mind in the future.😁


vcpkg_check_features seems not to work

Hi,
I'm trying to use vcpkg_check_features to get optional features and it's not working. I created a very simple port with CONTROL:
Source: mytest
Version: 0.1.0

Feature: test
Description: Build with test

and port.cmake:
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
    test BUILD_TESTS
)

message(STATUS "BUILD_TEST is set to " ${BUILD_TESTS})

I'm installing it with vcpkg.exe install mytest and I get nothing when the message is printed:
-- BUILD_TEST is set to
Why? Is vcpkg_check_features not supposed to populate BUILD_TESTS in this case with OFF and when used vcpkg.exe install mytest[test] with ON?
What am I doing wrong?

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
    test BUILD_TESTS
)

does not set BUILD_TESTS in the portfile. It will only add -DBUILD_TESTS=ON(or OFF) too FEATURE_OPTIONS for the cmake configure call

I see, how can I get the features a user selected in the portfile so I can react depending on that?
Thanks

I found how to do it. In the case that someone is interested:
    set(${var} OFF PARENT_SCOPE)
    if (${name} IN_LIST FEATURES)
        set(${var} ON PARENT_SCOPE)
    endif ()
endfunction ()

check_feature("test"         BUILD_TESTS)


Fix socket reconnect issue that event emitter is lost

This PR fixes an issue where socket's event emitter will be lost once socket is reconnected. This happens when app lost network connection, causing socket to reconnect but the server socket is reconnected and lose all the event listener including user-message. This causes an issue where typing user message doesn't trigger anything in UI.
Added the functionality to manually trigger the run event through the socket to re-add all the custom event listeners.

https://github.com/gptscript-ai/gptscript/issues/766


Mid 2019 refreshment

html5please is pretty much unmaintained and needs a major update.
The idea

review and update each and every feature
collect and add new features

I hope we find people willing to contribute to make that happen.
How to proceed
New features
If you find a new feature that isn’t part of html5please yet please feel free to comment on this issue and add a new issue before starting to work on it.

[x] fit-content
[ ] Web Animations API
[ ] closest (Element.closest())
[ ] Variable fonts
[ ] JavaScript Font Loading API
[ ] CSS font-display property
[ ] Font loading API

Update existing features
Feel free to pick a feature out of the posts directory that you would like to work on.
Please create a new issue, use a title containing the feature name and reference this issue to help us tracking the progress.
Please consider the following when updating existing features:

Does the feature need a status update?
In case there are polyfills: Are they still relevant and the best choice?
Are there any additional helpful resources to add to the body of the post or as link via the moreurl property of the post
Does the file name matches the feature on https://caniuse.com to automatically add a link?

Update status of existing features:

[x] Eventsource
[x] audio
[x] background-image
[ ] border-image
[x] border-radius
[ ] box-reflection
[x] box-shadow
[x] box-sizing
[ ] calc
[ ] canvas
[x] classlist
[ ] contenteditable
[ ] cors
[x] css animations
[ ] css-filters
[ ] css-fixed
[ ] css-sticky
[ ] css3-colors
[x] datalist
[ ] dataset
[x] details
[ ] dialog
[ ] dom
[ ] dragndrop
[x] es5
[x] es6
[ ] exclusions
[ ] fetch-api
[ ] fileapi
[ ] filesystem
[x] flexbox
[ ] font-feature-settings
[x] fontface
[ ] form-validation
[ ] formdata
[ ] fullscreen
[x] geolocation
[ ] gradients
[ ] grids
[ ] history
[ ] html5semantic
[ ] hyphens
[ ] iframe-sandbox
[x] iframe-seamless
[ ] iframe-srcdoc
[ ] img-srcset
[ ] indexeddb
[ ] input-color
[ ] input-datetime
[ ] input-number
[ ] input-placeholder
[x] input-range
[ ] input-search
[ ] interaction-media-features
[ ] json
[ ] localstorage
[ ] masks
[ ] matchmedia
[ ] mediaqueries
[ ] menu
[ ] meter
[ ] microdata-domapi
[x] ~minmaxwh~ Removed see #460
[ ] multibackgrounds
[ ] multicolumn
[ ] offline
[ ] ol-reversed
[ ] opacity
[ ] paged-media
[ ] picture
[ ] pointer-events
[ ] postmessage
[ ] progress
[ ] pseudo-elements
[x] regions
[x] rem
[ ] requestanimationframe
[ ] ruby
[ ] scoped-css
[ ] selectors
[ ] supports
[ ] svg
[ ] text-overflow
[ ] text-shadow
[ ] text-stroke
[ ] track
[ ] transforms
[ ] transitions
[x] vibration
[ ] video
[ ] viewport-units
[ ] webcomponents
[ ] webgl
[ ] webp
[ ] websockets
[ ] websql
[ ] webworker

Hej @h5bp/html5please, @paulirish,
would you please consider spreading the word, about this?
Because:

I would like to get reviews to the PRs I’ll create
I hope that this will
I think this refreshment should be accomplished pretty soon.

Otherwise I’m afraid that htmlplease will be pretty worthless soon

I hope that we will engage people to contribute on a frequent basis

@mischah 	i just gave a quick review now, but I'll likely be unable to review again. You should feel free to be the primary reviewer now. :)
Thanks very much for spending time on this and whipping it back into shape!

Thanks Paul 😊

Hej @coliff, just in case you would like to participate on this issue:
Reference this isuue in your PR to track the checkboxes above. Just in case you aren’t able to check them by yourself.
Cheers, Michael

shouldn't CSS variables be added as well?


Add a module entry to package.json

This PR adds a module entry to package.json, pointing to src/index.js, which allows tools that use ES modules to avoid having to interoperate with the package's CommonJS build. This works around a problem that I've been experiencing including react-dropzone in a project that builds using Rollup.
More Details of My Problem
I'm including react-dropzone in a project that build using Rollup and have run into an issue with it importing this package (attr-accept).
react-dropzone ships an ES module build, but this package does not, which causes @rollup/plugin-commonjs to run into some interop issues, and means that this line ends up trying to call an object, which throws an exception. (It's basically calling accepts() when it needs to be calling accepts.default().)
Interop issues with @rollup/plugin-commonjs are discussed in great detail here: https://github.com/rollup/plugins/issues/481
I've worked around the issue in my project through a horrible hack in my Rollup configuration to add a module entry to this package's package.json. I would love to get a version of this package published that includes it already so I can get rid of my horrible hack. There are other benefits to exposing an ES module build anyway.

Thank you!


Change in user configuration leads to cluster restart

We are testing clickhouse operator as a replacement for our cluster setup on EC2 instances.
We are managing users with xml file per user in users.d config folder.
Changes in users xml doesn't require server restart, but when we use users setting in CHI manifest, operator does restart the cluster. It looks like operator calculates config checksum and perform restart on any changes, but on my opinion it is incorrect. It should exclude configs which can be changed in runtime.
Also with lots of users it is not very convenient to manage them in CHI.
I understand that recommended way is sql, but it doesn't fit well into configuration as code (reason for operator existence) as we need db migration tool for that. Ideal scenario would be to allow custom configs (in addition to generated configmaps) to be mounted or added to generated with projection.

setting in CHI manifest, operator does restart the cluster.

Which clickhouse-operator version do you use? latest releases should not restart clickhouse when you change users
Could you share your kind: ClickHouseInstallation manifest? without sensitive credentials?

@playdaddy, change of users, both using users section and users.d files should not cause the restart. So if have an example when it does -- please share it.

We have noticed this in version 0.23.3.

we were using default operator install with bundle.
In this bundle in config section you have settings/*: yes as default value
I've commented out this, but didn't have a chance to test results

could you upgrade operator bundle to latest 0.23.5 release?
and look to
https://github.com/Altinity/clickhouse-operator/blob/master/deploy/operator/clickhouse-operator-install-bundle.yaml#L3516-L3556


How to generate prior_boxes_ssd300.pkl

Hi, your implementation is really great!
But I have a question.  I think this pkl is in the same format with the class PriorBox, but I don't know how to generate the pkl, can you give me some advices?
Thank you in advance.

@xyq676419 you dont need to generate them. look up issue #19

@primebuilder Sorry, I think i need to generate them, because I change the structure of the network. I predict the model once and get prior_boxes_ssd300.pkl from the outputs and save it. But the outputs from the model are a little different form the pkl file, the outputs boxes is a little smaller.

@xyq676419 I write some code  to regenerate prior_boxes_ssd300.pkl. Prior boxes are directly related to the network structure. New prior boxes can be created by setting "box_configs" variable in the script according to the structure of your new network.

Merged, if anybody is interested https://github.com/nszceta/ssd_keras/commit/ddec7192885061645b77ce9921f4d6db984d5bea

How can i calculate the min_size und max_size for the boxes for each layer
for instance for layer2 it is: 'min_size':  60.0, 'max_size': 114.0.

@xyq676419
Hi xyq676419,
Could you please tell me how to get the  get prior_boxes_ssd300.pkl file? Because I have changed the network topology.
Thanks a lot.


novel class incompatible

The novel class has a completely different structure than the standard classes and tries to set up metadata with hyperref in a way the generic driver does not like. Also, it redefines footnotes in an incompatible way.
\DocumentMetadata
  {
    lang=en-US,
    pdfversion=2.0,
    pdfstandard=ua-2,
    testphase={phase-III}
  }
\documentclass{novel}
\SetTitle{Some title}
\SetAuthor{Some author}

\begin{document}

text

\end{document}

errors with
! Undefined control sequence.
<argument> \ERROR
       \cs_set_eq:NN \__fnote_tmp:w \exp_stop_f:

It is also incompatible with table tagging as for some reason it errors if array is loaded.

sounds a bit as if that might end up "not supported", but that remains to be seen.

hm. Various problems even without tagging. E.g. the example produces a PDF 2.3 and adobe complains that it doesn't know this version :-). It writes directly into the PDF catalog, and into the Info dictionary, and creates its own XMP-data. So it is not compatible with the PDF management.

So should this be "no-support"?

I think so (for now at least). perhaps with a comment stating what would need to change in the class


Add project key attribute to resources where the API supports projectKey parameter

Our use case for Xray requires granting access to resources without the global "manage" permissions that would grant access to all Xray resources. To do this, we need to use the limited access granted with Projects to allow Xray resources to be created with the same limited access.
It appears that the Xray API provides the ability to create watches (see sample 5) and policies (see sample 4) in projects. From what I can tell, this is different than creating e.g. a watch that uses a watch resource of type project, since that would not grant users who have permissions in the project to manage the watch in the UI. So, we would like to be able to create Projects, grant users access to resources in that project, and create watches and policies in that project.
We would like to be able to do this all within Terraform. Right now, the xray provider does not support the projectKey query parameter that would allow this.
For example, using some sample code from the documentation:
resource "xray_watch" "repository" {
  name        = "repository-watch"
  description = "Watch a single repo or a list of repositories"
  active      = true

  # new attribute
  project_key = "test"

  watch_resource {
    type       = "repository"
    bin_mgr_id = "default"
    name       = "your-repository-name"
    repo_type  = "local"

    filter {
      type  = "regex"
      value = ".*"
    }
  }

  watch_recipients =<EMAIL_ADDRESS><EMAIL_ADDRESS>}

See jfrog/terraform-provider-project#39 for previous discussion.

Example REST API call for creating a project watch below.
If the query parameter is not provided then a global watch is created.
Current behavior of the xray_watch resource is to create a global watch.
#!/bin/bash
host="https://artifactory.site.com"
user="username"
pass="password"
key="test"

# Note: When creating a watch for of remote repository you have to use the remote repository cache name.
# i.e. test-remote-cache instead of test-remote.
# The REST API will return an error saying the test-remote repository does not exist.
# This is undocumented or a bug in the REST API that needs to be fixed.
# If you get the list of watches using /api/v2/watches?projectKey=test the name of the remote repository will be test-remote instead of test-remote-cache.
post_data() {
cat <<EOF
{
  "general_data": {
    "name": "test-watch",
    "active": true
  },
  "project_resources": {
    "resources": [
      {
        "type": "repository",
        "bin_mgr_id": "default",
        "name": "test-local"
      },
      {
        "type": "repository",
        "bin_mgr_id": "default",
        "name": "test-remote-cache"
      }
    ]
  },
  "assigned_policies": [
    {
      "name": "test-policy",
      "type": "security"
    }
  ],
  "watch_recipients":[]
}
EOF
}

curl -i \
-u "${user}:${pass}" \
-H "Accept: application/json" \
-H "Content-Type:application/json" \
-X POST --data "$(post_data)" \
"${host}/xray/api/v2/watches?projectKey=${key}"

Thanks @oallauddin I now see the additional query param for project key.


Support netty data transmission in dora

What changes are proposed in this pull request?
Support netty data transmission in dora to further improve reading performance.
Why are the changes needed?
Experimental result shows that replacing gRPC with netty to transfer data can improve the reading performant by 30%-50%. Based on this context, dora can also benefit from netty data transmission. Therefore, it is meaningful to support netty data transmission in dora.
Does this PR introduce any user facing changes?
To enable netty, just add the following configurations to alluxio-site.properties. Notice that we can enable epoll if we are using Linux. As Windows and MacOS don't support epoll, we use nio instead.
###### NETTY CONFIG ######
alluxio.user.netty.data.transmission.enabled=true
#alluxio.worker.network.netty.channel=epoll
alluxio.worker.network.netty.channel=nio
#alluxio.worker.network.netty.file.transfer=MAPPED
alluxio.worker.network.netty.file.transfer=TRANSFER
alluxio.worker.network.netty.backlog=40

alluxio-bot, merge this please.


Add allowUnsyntacticBreakContinue option

Moving from #340
I went with this option instead because there's a whole validation process with both types of statement.

We should enable this by default in babel-template when added

Codecov Report

Merging #341 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   97.65%   97.65%   +<.01%
==========================================
  Files          20       20
  Lines        3326     3327       +1
  Branches      882      883       +1
==========================================
+ Hits         3248     3249       +1
  Misses         30       30
  Partials       48       48

Impacted Files
Coverage Δ

src/options.js
100% <ø> (ø)
:white_check_mark:

src/parser/statement.js
97.79% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c4a7...46c1342. Read the comment docs.

For the context of babel-templates it feels like this API might be nicer as providing a default context, like "parse as if you're already inside a function" and "parse as if you're already inside a loop" since that focuses on the standard spec behavior, rather than having the flag focus on breaking standard parsing rules.
Thoughts?

parse as if...

are you saying either or or both?

To be sure to understand well, could you please provide a use case for this?
This will be valid, right?
a:
for(;;) {
  break b;
}

I don't like all this options to make the parser parse invalid stuff, but I totally see the usecase in babel-template. Maybe instead of adding more and more options for this, I would suggest creating one option to disable all this checks aka disableCodeChecks or similar. That way we would at least have only one option instead of multiple ones for babel-template.
Even cooler would be to separate this logic (in this case) that checks for valid break/continue into an own method pp.checkBreakContinue() and then provide a plugin that overrides it and makes it succeed always. That way we wouldn't have to do all the if (option) {} logic inside the actual parsing code.
Not sure if that works in all the cases we currently cover with options, but would be worth a try.
Thoughts?

are you saying either or or both?

Assuming I'm understanding your question, I think either-or?
babel-templates already takes options that pass through to Babylon, so my proposal would be an attempt to generalize cases where parsing as if it had a given parent, which is kind of like what you seem to be looking to solve.
What I had in mind would be like
options = {
  context: {
    // Same as "allowReturnOutsideFunction"
    function: true,

    // Same as "allowSuperOutsideMethod"
    method: true,
  },
};

then your case we could do
// Parse, allowing break and continue
loop: true

We just landed .parseExpression but you could imagine that being
// Parse, assuming the parser is already in an expression
expression: true

as a replacement for that.
Similarly, we probably want
// Parse "yield" without explicit wrapper "function*(){ ... }"
generator: true,

// Parse "await" without explicit wrapper "async function(){ ... }"
async: true,

We moved babylon back into the monorepo at https://github.com/babel/babel/tree/master/packages/babylon.
Unfortunately pull requests cannot be migrated between repositories automatically. If this PR is still valid please reopen it there.
Thanks for your effort.


Goal Position Leakage in Metaworld Benchmark

When the env._partially_observable is to False ( line 181 and line 271 in rollout_runner.py), the goal position is included in the last 3 elements of observation, which is fed directly into the model in both training and testing. So if I didn't miss anything, labels are leaked.
I run a quick experiment on reach-v2 environment and find that by masking the goal position from the observation, the success rate drops. Here is what I did:

Train with original code bash experiments/scripts/metaworld/train_test_metaworld_1task.sh hf://liruiw/hpt-base "" "" train.total_epochs=50
Test: 19.4% average success rate across 5 runs, which is low but expected since only 50 epochs are trained.
Remove data folder, set _partially_observable in RolloutRunner to True, set the last three elements in state to 0 after line 325
Test the previous model, a 0% success rate is returned.
Train again on the corrected dataset.
Test again: 14.6% average success rate across 5 runs

Could you please check if I miss anything and verify if this affects the results reported in the paper? Also, could you please release the complete code for reproducing the results in your paper? Thank you.

Thanks for the questions. This is not a mistake. We usd the goal information for proprioception information for metaworld, and this is consistent with the results in this paper.


Remove MutexID list

Remove MutexID list in SynchronizationObjects to avoid memory leaks.
cc #3967

I feel I have been constantly running into already mutably borrowed: BorrowError when it comes to unblock_thread. It always takes me a while to realise that it has something to do with unblock_thread again.

Generally you have to take great care of your RefCell handles. Never keep them any longer than you have to.
If we didn't use RefCell, you'd get a borrow checking error due to changing a vector while iterating it. That would be nicer but unfortunately the reference patterns are too dynamic to make that work.

For every function you call while holding the handle, ensure it doesn't reentrantly access the same data again.

This is a pretty nice way to see it, thanks.

@rustbot author

@rustbot ready

Just some final nits. :)
You can squash after taking care of those (with --keep-base as usual).
@rustbot author

@rustbot ready

Oh, wtf... as long as there is a "requested changes" review, it won't merge, even if the merge button is pressed by the person that requested the changes...


SPFarmSolution: 'Cannot find error' thrown when 'Absent'

Details of the scenario you tried and the problem that is occurring
Running SPFarmSolution with Ensure = 'Absent' against a solution that does in fact not exist throws an exception that the solution could not be found.  It should not throw this exception when it does not exist, and the resource is set to Absent, as a Solution that does not exist and configured to be Absent is correct state.
Verbose logs showing the problem
VERBOSE: [localhost]:[SP201902]: LCM:  [ Start  Set      ]  [[SPFarmSolution]FarmSolution_LDAPCP.wsp::[SharePointServerFarmConfiguration]DeployFarmConfig]
VERBOSE: [localhost]:[SP201902]:                            [[SPFarmSolution]FarmSolution_LDAPCP.wsp::[SharePointServerFarmConfiguration]DeployFarmConfig] Setti
ng farm solution 'LDAPCP.wsp' settings
VERBOSE: [localhost]:[SP201902]:                            [[SPFarmSolution]FarmSolution_LDAPCP.wsp::[SharePointServerFarmConfiguration]DeployFarmConfig] Getti
ng farm solution 'LDAPCP.wsp' settings
VERBOSE: [localhost]:[SP201902]:                            [[SPFarmSolution]FarmSolution_LDAPCP.wsp::[SharePointServerFarmConfiguration]DeployFarmConfig] Execu
ting as the local run as user RA\svc.dev.spexec
VERBOSE: [localhost]:[SP201902]:                            [[SPFarmSolution]FarmSolution_LDAPCP.wsp::[SharePointServerFarmConfiguration]DeployFarmConfig] Execu
ting as the local run as user RA\svc.dev.spexec
Cannot find an SPSolution object with Id or Name: LDAPCP.wsp.
+ CategoryInfo          : InvalidData: (Microsoft.Share...dletGetSolution:) [], CimException
+ FullyQualifiedErrorId : Microsoft.SharePoint.PowerShell.SPCmdletGetSolution
+ PSComputerName        : [localhost]

Suggested solution to the issue
Code update / do not throw error when missing and Absent.
The DSC configuration that is used to reproduce the issue (as detailed as possible)
SPFarmSolution SampleWsp
            {
                Name                 = "ThisDoesntExist.wsp"
                LiteralPath          = "C:\src\ThisDoesntExist.wsp"
                Ensure               = "Absent"
                Version              = "1.0.0"
                WebAppUrls           = @("http://collaboration", "http://mysites")
                PsDscRunAsCredential = $SetupAccount
            }

The operating system the target node is running
OsName               : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture       : 64-bit
WindowsVersion       : 1909
WindowsBuildLabEx    : 18362.1.amd64fre.19h1_release.190318-1202
OsLanguage           : en-US
OsMuiLanguages       : {en-US}
Version of SharePoint that is used (e.g. SharePoint 2016)
SharePoint 2019
Version and build of PowerShell the target node is running
Name                           Value

PSVersion                      5.1.18362.628
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.18362.628
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
Version of the DSC module that was used
3.8.0

Further testing has identified two bugs in near proximity towards the end of Set-TargetResource:
Bug 1)  The call to Wait-SPDscSolutionJob fails because the solution does not exist.  We should only be waiting for a Solution Job for an Ensure = 'Present' solution.
Bug 2)  The code for Remove-SPSolution is executed for a solution that is already known to be absent, thus throwing an error that the Solution cannot be found.  The code should check if the $CurrentValues.Ensure is already known to be Absent and not attempt to remove a solution that is known to not exist.

Successful run with Farm Solution 'Absent' verified by code changes:

In the future: Please leave the issue open when submitting the PR. Merging the PR will automatically close the issue ;-)


test function

this method could potentially work

sorry for the double commit my internet didnt work at the job


nix-daemon.sh does not work in zsh

Issue description
PATH is not getting updated correctly anymore post running . /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh, so unable to directly run nix-shell (running /nix/var/nix/profiles/default/bin/nix-shell works fine).
Steps to reproduce

Run a fresh install of nix (curl https://nixos.org/nix/install | sh).
Try and get nix-shell to run from zsh

➜  ~ nix-shell
zsh: command not found: nix-shell
➜  ~ . /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
➜  ~ nix-shell
zsh: command not found: nix-shell

Doing the same thing works from bash

➜  ~ bash
bash-3.2$ nix-shell
bash: nix-shell: command not found
bash-3.2$ . /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
bash-3.2$ nix-shell

[nix-shell:~]$

Have not investigated yet if single user vs. multi user matters (http://zzamboni.org/post/using-nixs-single-user-mode-on-macos/).
Technical details

System: macOS High Sierra 10.13.1 Beta (17B25c)
Nix version: 1.11.15
Nixpkgs version: 18.03pre116432.263185aa68
Sandboxing enabled: false

sorry, will re-open in nix vs. nixpkgs

or already done: https://github.com/NixOS/nix/issues/1577


Available for sale ?

Is it available for sale as a module ? looks interesting

Hopefully soon... Im working on building some documentation to help with the build, if you wanted to try to build yourself...
I'd like to start to sell kits for DIY assembly and fully assembled modules soon.

Would you be interested joining a mailing list for those interested when getting notified about when this module is available for purchase as a kit, assembled?

Yes! Please add me to a mailing list. Thanks for this project and your
dedication to creating documentation and also offering it as DIY.
The power of the DIY community is unmeasureable.
All the best,
Nicolas Fellas
On Thu, Mar 12, 2020 at 10:14 AM Nic Newdigate<EMAIL_ADDRESS>wrote:

Would you be interested joining a mailing list for those interested when
getting notified about when this module is available for purchase as a kit,
assembled?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/newdigate/teensy-eurorack/issues/12#issuecomment-598083071,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIBM3SMR2DV3BKXJ3TP6CX3RHCRYPANCNFSM4LGGNHNA
.

Hi, please add me to the mailing list too...
Kind regards
Jonas
fehrjonas at gmail com

I have had good success, having china soldering all SMD parts. Maybe this could be an option for the kit versions?

@simonredfern added to the list...
https://github.com/simonredfern

Yes, please add me to the mailing list!
I am definitely interested.
Thank you for sharing your work!
Best wishes
Johan Zetterqvist
Den torsdag 12 mars 2020 10:14:48 CET, Nic Newdigate<EMAIL_ADDRESS>skrev:
Would you be interested joining a mailing list for those interested when getting notified about when this module is available for purchase as a kit, assembled?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

2 done....
5 to go....
hang in there guys...!!!! I need to test my current revision 1.9 and Im also working on 1.9.1 which will hopefully help us to integrate the ad5754 into the teensy audio library...

nice, please sign me up for diy kit, erwin.coumans at gmail.com

added...

Hi, this looks really cool! +1 for the mailing list please.
Do you have any experience with noise issues? I have an Audio Shield + Teensy 4.1 here, connected the line in/outs to Eurorack and i get really a LOT of noise and hiss. Power supply is coming from Eurorack also. I wonder how it performs with different (better) ADC/DACs and on a real PCB instead of breadboard.

Hi Tom.
Breadboards are very good for audio, they are usually quite intermittent, you can get them to work, but they are very fragile, I experienced this first hand. You should download Kicad and see if you can build a circuit and a pcboard.
Other thing is that I assume your not sending control voltage into the audio card.
I doubt either of these things will cause a hiss thou.
What you really want to do is hook your MCLK, BCLK, LRCLK and TX to a logic analyser like Saleae and check that it can decode and that you are not sending junk to your audio codec.
Also make sure that vcc is not too far above the i2s levels, when vcc is higher that signals, it becomes more suseptable to noise.

 That sounds like a source of hiss..

@tompilot if you like you can continue this conversation here

Thank you Nic for your detailed answer! I have done some experimentation and finally found some sort of "solution".
My current DSP approach is a lot about FIR filtering and convolution of long impulse responses (which is all quite CPU hungry). I figured out that when using long IRs with the Teensy Audio Lib the I2S clock starts to jitter (Teensy is I2S master). Also, some of the noise came from putting the power supply through the breadboard.
To get a clean environment i did:

Use another audio shield (WM8731) with crystal and use I2S Slave mode, so that the crystal creates the clock signal - not the Teensy. I also noticed changes in the noise when other CPU- or timer consuming tasks are running, in my case printing on a display and using encoders. Probably the SGT5000 codec would also be doing fine in slave mode, but the PJRC Audio shield does not support a crystal on it.
Solder the line input on the development board instead of going through the breadboard (blocking cap and two resistors in case of WM8731). Having it on the breadboard was very sensitive to picking up noise.
Solder the power supply directly to the Teensy. I am using the 5V line of my Rack as the power.
In general: Disable the 5V supply from the USB programming cable by cutting a trace on the Teensy (you should never use two power sources at once)

By now, i only have the I2S and i2c lines going over the breadboard, which does not seem to have an effect.
Will switch over to gitter now, but i just wanted to give my reply here for completeness :-)

Just a quick update - if you want to follow the project and get updates, priority pre-orders, discounts, pcbs -  please consider supporting this project in patreon: https://www.patreon.com/teensy_eurorack
Thanks :)


Uploading new friend file shannonmcook.html

Adding my name via html file to the friends list. Thanks for making this challenge for us newbies for Hacktoberfest 2018. If I do this right, this will be my first opportunity for a contribution! Here goes nothing! Let's be friends!

Your pull request needs further work because of the following reason(s):

Your file has a github link but it's (probably) not to your profile.

Once you have resolved the issues, comment on this request to be re-judged
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

1207fb3a1eda69992ec5316594650eaab518640d

I change my image host from GitHub to twitter. We should be good to re-judge. Thanks for evaluating!

Your pull request needs further work because of the following reason(s):

Your file does not clearly show a link to your github profile.

Once you have resolved the issues, comment on this request to be re-judged
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

685b288ccd98ca8ad7b66b76adc90b453115addf

Added clear link to github profile in the html file shannonmcook.html

Your pull request needs further work because of the following reason(s):

Your file has a github link but it's (probably) not to your profile.

Once you have resolved the issues, comment on this request to be re-judged
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

ce079c3a84a403f2c3fa22951dad905e05ca66dd

I've added my clear link to my GitHub profile landing page and the merge is rejected. The link is an actual HTML link, as well as spelled out. I'm not sure what I'm doing wrong - I referenced other accepted merges and my file seems correct. Let me know where I've gone astray. Thanks in advance!

Hello, ive looked through your file and have found no instances of "https://github.com/shannonmcook"

Ah, i see it now.
Typically it's best to keep the same issue in the same PR but I don't mind people re-opening things since the bot kinda ruins that workflow anyways.

Lol, thank you so much for this experience! I have been terrified of touching other people's repos, besides forking them... Heading back to clean up my repo and resubmit the name html to the CORRECT place, lol. Total rookie mistake. Thanks for not booting me off the internet ;)


Make default branch name 'main' instead of 'master'

Currently, when you create a package the default branch that is created is called master. Because the term is quite loading culturally I think it's better to change this to main like GitHub now does by default.
Ref: https://www.theserverside.com/feature/Why-GitHub-renamed-its-master-branch-to-main

Fixed it as part of the refactor I did recently https://github.com/mediamonks/pota/commit/122bdcf3220929f60c19a615fdc688abd25ca896


getMixPath returns an incorrect path in some cases with cabal 1.22 / ghc 7.10

Background analysis
Below is the current implementation of the getMixPath function, which computes a mix file path based on the hpc data directory, the test suite name, and the tix module:
getMixPath :: String -> String -> TixModule -> FilePath
getMixPath hpcDir testSuiteName tix = mixDir hpcDir ++ dirName ++ "/"
    where dirName = case span (/= '/') modName of
              (_, []) -> testSuiteName
              (packageId, _) -> packageId
          TixModule modName _ _ _ = tix

In some cases, this function doesn't return the correct path.
For a concrete example, see this build output: https://travis-ci.org/guillaume-nargeot/hpc-coveralls/jobs/50498362 (throw away test branch hpc-data-dir-troubleshooting)
As a result of this build, the partial directory tree of the dist/hpc/vanilla/ folder is:
├── mix
│   ├── hpc-coveralls
│   │   └── Trace.Hpc.Coveralls.Util.mix
│   └── hpc-coveralls-0.8.4
│       └── hpcco_IlD5BmmDkZU34g6Jd9zefP
│           └── Trace.Hpc.Coveralls.Util.mix
└── tix
    ├── hpc-coveralls-0.8.4
    │   └── hpc-coveralls-0.8.4.tix
    └── test-all
        └── test-all.tix

In both hpc-coveralls-0.8.4.tix and test-all.tix, the modName value for the TraceHpcCoveralls.Util module is hpcco_IlD5BmmDkZU34g6Jd9zefP/Trace.Hpc.Coveralls.Util.
When building the same package with cabal 1.20 and ghc 7.8 (instead of cabal 1.22 and ghc 7.10), the hpcco_IlD5BmmDkZU34g6Jd9zefP bit found in the module name and directory structure is hpc-coveralls-0.8.4, which seems to be more correct.
This strange looking string is the reason why the getMixPath function fails, as it will produce the following path, which doesn't exist:
dist/hpc/vanilla/mix/hpcco_IlD5BmmDkZU34g6Jd9zefP/

The correct path should instead be:
dist/hpc/vanilla/mix/hpc-coveralls-0.8.4/

The fact that the referenced mix file paths have this additional indirection (two times the package name) is yet to be understood.
A simpler package, such as this one, used for hpc-coveralls testing, doesn't seem to generate mix files in such a way (see this build), and therefore doesn't suffer from this issue.
Objective
Either find a way to better control hpc and where it outputs the tix/mix data files, or try to access the package name and pass it to the getMixPath function.
The package name can be parsed from the cabal file using Distribution.PackageDescription (distributed with cabal, so it should always be available).
A new command line option may have to be introduced in order to specify the cabal file, or it could be found by inspecting the current folder.
Feature branch: read-cabal-file

I'm currently being affected by this issue. Has there been any progress?

@zovt I'm working on it when I can find some time, and hope to fix it soon. Will keep you updated.

TODO: https://github.com/guillaume-nargeot/hpc-coveralls/commit/91924d159e77e24c77b39c23ff1e617d6c649ffb#commitcomment-12968500


WaveNet (Hyper) Parameters

I've trying to find the model hyper-parameters used in the original paper.
I refer to the following:

Number of Layers
Number of Blocks
Skip channels
Residual Channels
Out Channels
Kernel Size

I couldn't find any reference in the paper.
How were these repository default parameters deduced?

No one can answer this? I´m also interested on this question. Thanks!


Fix CI badges in README.md

@mergify backport jazzy humble

@ijnek it seems like I don't have the privileges to run mergify

@mergifyio backport jazzy humble


Provide a way to enable GRPC reflection service and make it enabled by default.

We wanna provide a way to enable Armeria GRPC reflection service. And since some organization rely heavily on grpcurl tool to debug and write scripts which is based on reflection api, would it be necessary to enable it by default?

If it is repeatedly used, we may provide an option to automatically enable it such as GrpcService.enableReflectionService(boolean).
I am not 100% sure that it makes sense to enable it by default.
Because it is able to expose unexpected implementations to the public networks.

It's also not too terribly difficult to enable right now:
import com.linecorp.armeria.server.grpc.GrpcServiceBuilder
import io.grpc.protobuf.services.ProtoReflectionService

val builder: GrpcServiceBuilder = GrpcService.builder()
// enable reflection
builder.addService(ProtoReflectionService.newInstance())

Replacing that one line with builder.enableReflectionService(true): I'm not sure if theres a ton of benefit to do that. I guess it shows up in code completion and someone may stumble upon it? I agree it should not be on by default.


Use land fraction to calculate more inclusive land masks

This is a WIP PR that expands our land mask to include coarse grid cells that have small fractions of land areas. It builds off xesmf's tutorial on masking. I think we need to propagate this functionality to the weights generation script (cc @andersy005).

closed by #228


Introduce Phive

You could remove tools from the repository if you use Phive.
See https://github.com/phar-io/phive
Very easy to configure!

After that youo may consider reducing the repo size by https://help.github.com/en/articles/removing-sensitive-data-from-a-repository

hey @szepeviktor
I'm currently working on moving our CI tooling from platform to the development template. so the main repo size will be decreased. I will take your issue and your PR into account :+1:
thanks for your contribution

All right.

moving our CI tooling from platform to the development template

@mitelg Does it mean that platform contribution won't be checked?

just a little hint :blush: as we are shortly before our first release, it will may take some time, as I don't want to struggle up our CI pipeline before the release :wink:

@mitelg Does it mean that platform contribution (PR-s) won't be checked?
Currently there are no checks here on github anyway :grin:
I will take that to my task

What a shame! You develop modern code as use Atlassian products? No words can describe their quality.

I don't want to struggle up our CI pipeline before the release 😉

My base package for developer team are these 3 zero-coverage tests:

parallel syntax check
coding standards check
static analysis

It costs nearly nothing to introduce them, and keeps your code quality very high even is you don't have time to write unit/functional tests.

Don't get me wrong here, we already use these tools :blush:
but if I now move phar files from here to there, or introduce phive, I have to adjust our CI. and this is mostly not done in five minutes :wink:

What a shame! You develop modern code and use Atlassian products? No words can describe their quality.

We have plans to migrate to an internal GitLab instance and we may can use parts of it's CI configuration for travis ci like we are doing with Shopware 5.

Some weeks ago, we've evaluated phive as replacement for the phar files. At the end of the day, the key servers are really unreliable and not all tools are available with a signature, which does not make much sense right now. We'll keep an eye on phive and once it's more mature, we'll evaluate it again.


Sample Code

Sample code to add proxy in Image generation

Init gen with proxy URL
imagen _gen= ImageGenAsync(
                auth_cookie=cookie
                proxy=proxy
            )

Thx


Restructure run_on_url

This PR separates many of the tasks in run_on_url (inside Scanner.py) to be a function of their own. It also implements a few common functions that the code can use instead of having multiple instances of the same snippet. (e.g final_report, count_results).
The function store_results (Not created by me) has also been called inside final_report. It was not being used before. So I sure hope it works correctly.
Note : This PR does not change/fix/improve anything except code readability. There are still bugs/unhandled exceptions that exist. I see a lot of flaws in the diff implementation, especially when  alerts are not being addressed. The PR to fix these will be seperate.

This should close #18

Thanks Chase! This looks really good. One equestion. Have you tested it at all on something like xss-game? You can find the example link in the menu startup.

I've tested this and as I mentioned this does not FIX the already present problems (see #21). It does not however add any other problems.
I've a working version right now but I have not pushed it because I wanna do this one by one. Also I need to know how diff is being used before I can make a working change, I can only make it work without diff for now.
See, diff is quite flawed.....

It returns true if the sources are same, not different. Which is fine I guess, except-

It's being used to check whether they are different, as in this if statement supposedly wants isDifferent to be true only when the sources are different. So that's an oversight. Also Difflib is a better choice for checking deltas I believe, just comparing the direct sources is not going to do us any good.
I'll push the working versions right today but I must make a request, allow me to suspend this diff function for now, a lot of work needs to be done to finish it before we can make it live.

Yes for sure, feel free to suspend the diff module. Its not working correctly it seems anyways.

Alright, I merged a working version to this PR. Here's the things I've changed -
id.send_keys(Keys.ENTER)
    try:
        new = self.driver.find_element_by_css_selector('button').click()
    except ElementNotInteractableException:
        pass

Every payload comes with a newline already with it (as I checked from debug). Hence that ENTER key send is useless and only raises unwanted exceptions so I removed that. I also removed the try - except block and it's contents because that one needs work to be usable.
A disclaimer on it's current state of working, this is for the payloads that work perfectly-

However, there are a bunch of payloads that either have syntax error or some other error in them. I suggest you check these out -

We can merge this build right now though. I'll be working on improving the HTML scan now, creating a webelement_list everytime inside a loop isn't very effective anyway. Also check out the code in Scanner.py a bit. Dropped some questions there :)

Merging, looks good! Thanks for the contribution. The URL variable is the straight URL passed in. I did this so that if they have cookies it will render the normal webpage that they'd request and then add the cookies to that.


Question regarding robotics notations used.

I tried loading a fanuc m710ic/70 urdf robot using this example
https://github.com/stack-of-tasks/pinocchio/blob/master/examples/overview-urdf.cpp
I don't understand q :
is it a pose as Tx,Ty,Tz,Rx,Ry,Rz ?
running the program, the joint positions are displayed as 3 values for each joint . I don't understand,  does it mean 3 possible solutions in each column / or the rotation on each axis rx,ry,rz ?
q:     2.1374 -0.0220371    3.22123     3.7502     1.7961   -3.80063
universe                : 0.00 0.00 0.00
joint_1                 : 0.00 0.00 0.56
joint_2                 : -0.08 0.13  0.56
joint_3                 : -0.07 0.11  1.43
joint_4                 : -0.08 0.12  1.27
joint_5                 : 0.46  -0.73 1.16
joint_6                 : 0.53  -0.65 1.31

sorry, it is to compute cartesian position from joint position using forward reverse formulas


which space is the loaded normal in?

Hi, thanks for the great work!
I use this function to load the normal data. (https://github.com/city-super/MatrixCity/blob/778775c18d2e30e5684fbecb1e759835e8b0b5aa/scripts/load_data.py#L15).
Is this normal in camera space or world space? It is hard to judge by myself because your data seems hardly contains camaeras rotates around the same object.
Thank you very much,
Yanrui

https://github.com/city-super/MatrixCity/issues/34#issue-2427167081


build: synchronise SwiftSupport.cmake from Foundation

@swift-ci please test

Please test with following PRs:
https://github.com/apple/swift/pull/22981
@swift-ci please test

Please test with following PRs:
apple/swift#22981
apple/swift-clang#263
@swift-ci please test

Please test with following PRs:
apple/swift#22981
apple/swift-clang#265
@swift-ci please test

@swift-ci please test


100 Continue issue

Hi,
Looks like the 100 Continue response is causing trouble again. You fixed one issue related to this in https://github.com/VBA-tools/VBA-Web/issues/125
Now the server is returning two Continue 100 rows before the actual response. The response looks like this
HTTP/1.1 100 Continue

HTTP/1.1 100 Continue

HTTP/1.1 200 OK
...

This may be a result of a change in my server configuration. I changed my web server from Puma to Phusion passenger lately. And in general my web server is configured so that it uses internal port forwarding. There is Apache forwarding requests to internal web servers.
I believe it is best to just delete all the Continue lines from the response. Some server configurations may have even more forwards.

I changed the web_FindStatusLine function to be like this and now it works. Should work for any response.
Private Function web_FindStatusLine(web_CurlResponseLines() As String) As Long
    For web_FindStatusLine = LBound(web_CurlResponseLines) To UBound(web_CurlResponseLines)
        If VBA.Trim$(web_CurlResponseLines(web_FindStatusLine)) <> "" Then
            If VBA.Split(web_CurlResponseLines(web_FindStatusLine), " ")(1) <> "100" Then
                Exit Function
            End If
        End If
    Next web_FindStatusLine
End Function

Yep, that looks like a much more robust solution than the existing, I'll update the library soon.


docs(managed): add first draft

Beyond copyedits, this PR also includes the following changes:

removed [Managed Team - Create ServiceNow Case for P0 Qualified Alerts]. This linked to an internal slab doc
renamed Slow and big bang migrations
removed "Spinnaker Training" and "need to add information about Spinnaker Training here" comment

Rendered output: https://deploy-preview-842--armory-docs.netlify.app/managed-spin
The published page would be hidden in local search and from search engines.

@brian-armory I think we are good to go with this doc.


Added timeout for getStdin and trim trailing new lines

Added timeout to getStdin:
In some CLI the if (process.stdin.isTTY || process.env.STDIN === '0') check isn't enough. Some CLI like git bash on windows just hang on the getStdin call. Solved this by using a getStdin function with support for timeout.

Removed trailing new lines:
Trying to paste something into the cli and having it paste a new line which runs an uncompleted command is not great. Keep new lines in the middle to support copying multi line text, but remove trailing new lines to prevent unnecessary commands to run.

Added timeout to getStdin:

You're solving this problem in the wrong place. This is a problem with the terminal you're using, Git Bash, not with this CLI or get-stdin. I would suggest using a better terminal, like https://github.com/microsoft/terminal

Removed trailing new lines:

I disagree. It should copy exactly what's coming from stdin. That's what most users would expect. You can trim newlines yourself with various bash commands if you need it for your use-case.


SEO April: include ASP.NET Core 3.0 in title

SEO April Effort: This topic is for ASP.NET Core 3.0 and a top keyword being used in search included "3".  It is not immediately clear the topic is for ASP.NET Core 3.0 in search or even once you look at the topic.  Changing to see if the bounce rate improves.  Following up on bounce ratings next month for this as part of SEO hackadoc.  No related issue for this PR.

Including a version in the title of a topic that spans versions via the version selector may cause problems:

At 3.1 when the user selects 3.0, the title will still say 3.1 ... could be confusing to the visitor.
We have to maintain this every patch release ... could be missed ... someone probably will one day. 🙈
What about the caching of the title on external systems (search engines being the worst case scenario)? It could cache with a 3.0 title but load 3.1. Again, confusing ... and perhaps even a little embarrassing.
I suspect the topic will position well with Google ... it's look'in good today :+1: ...

+1 to @guardrex comments --

We don't usually put version number in the title -- we'd have to change the title with every release. If we started doing that with this one we should be consistent and do it everywhere, but that would be confusing for customers and a lot of work to maintain.
What's more relevant to Blazor is not its 3.0 status but its preview status -- if the goal is bounce rate reduction you'd probably get more by adding (Preview) than by adding 3.0.

@guardrex and @tdykstra for the feedback.  Greatly appreciated. I did goof this up.  I will remove the version from the title.  The version is included in the text body, but far enough down it is not seen right away.  Tom pointed out it could also be that folks are figuring out late after searching and landing on it that it is preview and bouncing out.  I will move the version communicated later in the doc and move it to the intro paragraph which will show up in search results so it is clear up front.  It will have to be changed later of course, but it is also a high traffic topic, there is some confusion over it, and  worth some extra clarification and a later update.


Some CSS variables are defined as "[object Object]"

There are a few variables that are defined as "[object Object]". I am guessing this is a side effect of a generator being used. Should we remove or fix these values?
https://github.com/adobe/spectrum-css/blame/master/components/vars/css/scales/spectrum-large.css#L100

Hey @achicu good catch. Looks like there was a mistake in DNA where an object was ending up in the output that should have been resolved against the scale being processed. That made its way down into Spectrum CSS and manifested as the [object Object] error.
Here's the fix in DNA: https://git.corp.adobe.com/Spectrum/spectrum-dna/pull/346/files#diff-09f6d1357db57beb20f16020473f0c3eR32
Once we update DNA, this issue will be fixed.

@GarthDB since you're working on tokens and will be updating them in CSS soon, I'll go ahead and assign this issue to you.

Fixed in the latest release.


failed to load resource google-analytics.com/ga.js

Taken from the Developer Tools Console in Chrome on Windows 8:
Document was loaded from Application Cache with manifest http://sutsis.nomei.la/webapp.appcache sutsis.nomei.la/:1
Application Cache Checking event sutsis.nomei.la/:1
Failed to load resource: net::ERR_BLOCKED_BY_CLIENT http://www.google-analytics.com/ga.js
Application Cache NoUpdate event sutsis.nomei.la/:1
Application Cache Checking event (index):1
Application Cache NoUpdate event (index):1

@ahzee
You can try this i guess it should help; for more details read up from: http://stackoverflow.com/questions/24668860/google-analytics-file-not-found


['Заяви' tab in the Parent's Cabinet] Inconsistency of the application with the design

Follow the link: https://github.com/ita-social-projects/OoS-Frontend/issues/1138


Updated navigation to ignore coastal flowlines

Before making a pull request

[x] Make sure all tests run
[x] Update the changelog appropriately

Updated navigation to ignore coastal flowlines
Created an fcode check in navigate.xml to ignore coastal features (fcode == 56600).
Description
https://internal.cida.usgs.gov/jira/browse/NHGF-30
Navigation requests will now stop once they reach a coastal feature. If the request starts on a coastal feature, only that feature will be returned. In order to test using the demo database you will need to create fake coasts. Run the following psql command against the database to create example coasts.
update nhdplus.plusflowlinevaa_np21 set fcode = 56600 where comid in (13294304, 13294298, 13294300, 13294310);

Test requests can be run using upstream or downstream features. These should end when reaching the Lake Mendota area. Making a request from a coastal feature (localhost:8080/nldi/linked-data/wqp/WIDNR_WQX-10031720/navigation/UT/flowlines?distance=100&f=json) should return only that feature.
Resolves #39
After making a pull request

[x] If appropriate, put the link to the PR in the JIRA ticket
[x] Assign someone to review unless the change is trivial

Codecov Report

Merging #203 (6863e97) into master (c7327a7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage     94.82%   94.82%
  Complexity      197      197
=========================================
  Files            30       30
  Lines           715      715
  Branches         50       50
=========================================
  Hits            678      678
  Misses           29       29
  Partials          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7327a7...6863e97. Read the comment docs.

I'd like to get the test case included before merging. Let's avoid that technical debt if possible.

@dblodgett-usgs Moved the fcode to a variable in the latest commit. https://github.com/ACWI-SSWD/nldi-services/pull/203/commits/355f8ca3bcc2701ad41ff71ccc42adf76c30b52f


Add a guide about usage of sessions

Describe the feature
I think that we could add a guide about usage of sessions (same approach that I've done in #1307).
Additional information

[X] Would you be willing to help implement this feature?

I think this absolutely needs to be defined somewhere.
Ideally, this should be in a section of a H3 website, and both the Nuxt and Nitro sites should have H3 as a "subsite"
https://github.com/nuxt/nuxt/issues/21930

I think this absolutely needs to be defined somewhere.
Ideally, this should be in a section of a H3 website, and both the Nuxt and Nitro sites should have H3 as a "subsite"
https://github.com/nuxt/nuxt/issues/21930

Yes, I'm ok for the h3 website but currently there is not documentation for this website!

This is a good idea. Setting up h3 docs soon. I think we can document it in both places because nitro docs can include more details such as configuration and using runtime config (in the future I'm thinking to make it even a built-in feature for easy usage)


macOS Catalina 10.15 search tag appear "E432: Tags file not sorted"

I have install vim by brew in macOS Catalina 10.15.
When I search or jump any tag. "E432: Tags file not sorted" appeared.
Even use vim help, the error appeared  such as:
:h <c-w>
VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep  5 2019 21:03:34)

I'm seeing the exact same problem with a setup that worked flawlessly for over ten years. I'm trying to lookup documentation using :help <keyword> and are instantly greeted with the error message.
:help surround
E432: Tags file not sorted: /Users/kevinsjoberg/.vim/plugged/lightline.vim/doc/tags
E432: Tags file not sorted: /Users/kevinsjoberg/.vim/plugged/vim-dirvish/doc/tags
E432: Tags file not sorted: /Users/kevinsjoberg/.vim/plugged/vim-abolish/doc/tags
E432: Tags file not sorted: /Users/kevinsjoberg/.vim/plugged/vim-commentary/doc/tags
E432: Tags file not sorted: /Users/kevinsjoberg/.vim/plugged/vim-dispatch/doc/tags
E432: Tags file not sorted: /Users/kevinsjoberg/.vim/plugged/vim-rails/doc/tags
E432: Tags file not sorted: /usr/local/share/vim/vim81/doc/tags
E426: tag not found: surround@en

For plugins it seems tags file should be sorted case insensitive, while sorting tags from Vim runtime files doesn't help at all

Did you try set notagbsearch.   If you want to work with unsorted tag files your file should start with
   !_TAG_FILE_SORTED	0	/comment/

@andymass while I appreciate workarounds, I much rather fix the underlying issue.

@KevinSjoberg How did you generate these tag files?

@andymass like I always do. Either using :helptags ALL or automatically using vim-plug. This has been working for close to ten years. The only difference is the recent upgrade to Mac OS Catalina.

Either vim is generating out of order tag files or its calculation of when a tag file is not sorted is wrong.
https://github.com/neovim/neovim/issues/11196

could that be related to case insensitivity of the underlying filesystem?

Back in 2003, I saw the following e-mail thread that discussed a
solution to this problem:

Here is the scoop.. Setting the env. var. LC_ALL to C should help
you build a sorted tag database and allow you tag lookups from the
vi/vim editors.

What would cause a tags database to not be sorted?>

Given that your example shows a sort into lexical order instead of native
ascii order, I suspect the problem is recent addition of support for
locales.  This changes the semantics of sort(1)so that it sorts
lexically by default instead of ascii order.This was an incredibly
boneheaded decision (to change the default behavior of a tool), but it
seems to be fairly universal now.
Try setting unix environment LC_ALL to C, and see if generating tags
makes the problem go away.  BTW, so far I've only seen this class of
problems on linux; have they now shown up on solaris?

Yegappan

could that be related to case insensitivity of the underlying filesystem?

No, this wasn't a case before while filesystem is case insensitive for years.

I posted the patch in https://github.com/neovim/neovim/issues/11196#issuecomment-541212889
feel free to apply

FWIW, under Mojave, doing :%!sort -R on $VIMRUNTIME/doc/tags or any plugin-local tags file doesn't break :help foo at all despite making the files pretty much unsorted.
This makes me think that this is not a matter of "sorted" versus "unsorted".

@dm1try does this patch works in others versions of macOS?

@eirnym sure

Then it looks fine for me.

Addressed in Neovim (see https://github.com/neovim/neovim/pull/11222). Could we apply the same patch in Vim?

Would really appreciate if anyone could look into this.

Has anyone reported this as a bug to Apple?  If it can be reproduced with Catalina's system vim there's a better shot that they'll fix it.

The bug is reported to apple (https://github.com/neovim/neovim/issues/11196#issuecomment-541365466)
I have an open pull request with the same fix as Neovim.

Fixed by #5061.
Closing.

Fixed by PR 955 in v8.2.0314 original issue 5061


Make :version consistent over search and dep add commands

The following outputs numbers
neil dep search libpython-clj
:lib techascent/tech.jna :version 4.06 :description "Bindings to JNA.  Used with libpython-clj among others."
:lib clj-python/libpython-clj :version 2.024 :description nil
:lib cnuernber/libpython-clj :version 1.36 :description "libpython bindings to the techascent ecosystem"
:lib libpython-clj/libpython-clj :version 1.6-SNAPSHOT :description "libpython bindings to the techascent ecosystem"

However using the command expects strings or it will insert an EDN number which won't work ❗
neil dep add :lib clj-python/libpython-clj :version 2.024

So make the latter accept numbers and/or the former output strings.
https://clojurians.slack.com/archives/C03KCV7TM6F/p1677929356870239

An attempt in the commit above, but it's failing one test. I'd have to check later this week what's wrong.


Fixing minor typo: 'form' -> 'from'

Fixing minor typo: 'form' -> 'from'

@leewallen can you please re-open this PR against the main branch?


WIP: Add partial repaint macrobenchmark

This adds a macrobenchmark for https://github.com/flutter/engine/pull/25158. It consists of a relatively busy page with an activity indicator in the middle.

Still needed to get these benchmarks run in post-submits:

modify .ci.yaml
modify TESTOWNERS
EITHER:
add a new run file in macrobenchmarks/test to run it with the E2E mechanism (very lightweight, but doesn't result in timeline trace files being left as byproducts)
OR:
add a new run file in macrobenchmarks/test_driver to run it with the timeline trace mechanism (which is much more heavyweight, but you can examine the traces for debugging after)
(most new benchmarks are going the E2E route...)
add an appropriately named file in dev/devicelab/bin/tasks
add a new entry in dev/devicelab/bin/tasks/perf_tests.dart

You can use https://github.com/flutter/flutter/pull/94447 as a template, though that PR added 5 benchmarks at once (using E2E)...

@knopp Do we still have a chance to get this landed before it gets enabled on some platform so that we have a "before" baseline being tracked to see the improvement?

Apologies, somehow I missed all notifications on this PR. I think it would still be a good thing to have even though partial repaint has landed for both iOS and Android.

Apologies, somehow I missed all notifications on this PR. I think it would still be a good thing to have even though partial repaint has landed for both iOS and Android.

That's great, can we give it the love it needs to be landable?

cc @iskakaushik

@knopp Are you still interested in landing this PR?

@knopp I'm going to close this to get this off our review queue for now, but please don't hesitate to submit a new PR when you're ready. This would be a very valuable benchmark to add.


Extract script updates

Propagate deletions from Web modeller by deleting checked out artefacts before extract
Support creation of a new branch
Updated README with self managed extract example and local Zeebe stack set up instructions

Looks like this is good to go now. @benariss If you are happy with it then merge it and probably add the tag to the 0.2.0 draft release - that will trigger the build and push to docker hub.


undefined method `cycle'

Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Failed to parse inline template: undefined method cycle' for nil:NilClass at /etc/puppetlabs/code/environments/production/modules/letsencrypt/manifests/certonly.pp:47:18`
CentOS7
# /opt/puppetlabs/puppet/bin/ruby --version ruby 2.1.9p490 (2016-03-30 revision 54437) [x86_64-linux]
what am I missing?

I think you're probably missing the webroot_paths parameter to letsencrypt::certonly, which should be an array of paths of your webroot(s) when using the webroot plugin.

true. I was naiively assuming there would be a fallback default, just didn't go looking for it :)
Worth a README example code, maybe?

We can add some validation logic to ensure that webroot_paths isn't undef when the plugin is set to webroot

I thought maybe it could fall back to "/var/www/html" os something sensible like that...

I don't think there's a good cross-server and cross-OS default for the parameter, so requiring it is probably safest to prevent stranger errors when trying to request certificates.


Custom registry key on FVariables get reset on mod manager load

This is a bug I think I missed when creating the custom FVariable definition.

Right fix was pretty easy, will create pull request in a second


chore(TransactionFeedV2): Re-write transactions reducer to slice

Description
11th PR for RET-1207. Rewrite of transactions reducer.ts/actions.ts files to slice.ts/selectors.ts. Slice also requires all actions to get arguments passed as a single payload object so needed to refactor all the usages of the corresponding actions. For better review experience, each action usage refactor was merged as a separate commit.
This rewrite is necessary to move a bunch of redux-related useEffects from TransactionFeedV2 component to extraReducers.
Also, this rewrite doesn't change the implementation of TransactionFeedV2 as it is already a bit of a big PR.
Test plan
Re-use existing reducer.test.ts and rename it to slice.test.ts
Related issues

Relates to RET-1207

Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:

[x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@jeanregisser updated


Create remove_node.py

Thank you for merging my code .
Just want to clarify that if it's merged then why on hacktoberfest account
it's showing waiting ?
Could you please clarify my doubt!?
On Mon, 16 Oct, 2023, 11:32 pm 200, @.***> wrote:

Merged #15 https://github.com/Chitresh-code/DSA_Worksheet/pull/15 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/Chitresh-code/DSA_Worksheet/pull/15#event-10668867124,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4TBUYFZPYMBTTDGLVWE233X7VZDLAVCNFSM6AAAAAA6CBZ4WGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGY3DQOBWG4YTENA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Again @gitaditee its their policy.
Read the terms to merge a pr properly, its not from my side.


[Feature] websockets as a datasource

Summary
For live apps that can subscribe to events
Motivation
Would be useful for dashboards where data is updated in real-time.
Users could also add a chat window
Not sure, if it's in the roadmap currently, tried searching for websocket

There's an issue filed a couple of weeks ago with this request. I had typed web sockets instead of websockets, so you couldn't find it. https://github.com/appsmithorg/appsmith/issues/1866. I updated it with your comments.


feat: add option crossOrigin

This PR contains a:

[ ] bugfix
[x] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case
Solving https://github.com/webpack-contrib/worker-loader/issues/281 according to this comment

Breaking Changes
No breaking changes.

Additional Info

@evilebottnawi how is my solution? If you think it is good then I'll try to improve code coverage.

Hello. Any plans on going forward with this one? 💔

Could use my fork for now?

@pckhoi I don't seem to be able to use a relative path here.
Assuming my page is http://reddit.com, I would like to add /static-proxy as my originPath.
This would result in using http://reddit.com/static-proxy/${fileName} as the path to the worker.
Can this be achieved?

@mwanago Yep, we need thinking more about this and solve this in more general way

@evilebottnawi Maybe allowing a function to be used as the crossOrigin (or another name we come up with) would help.
I could use ${window.location.origin}/static-proxy as the return of the function.

We should use currentScript here, webpack supports publicPath: 'auto'...

@evilebottnawi My public path is set to something else and I need it to stay this way.
I need to override it only for the worker path.

@mwanago Just for information, can you provide real use case?

@mwanago this PR is meant to solve cross origin use cases. I think you might be able to do what you want with existing options already. What have you tried so far? Would changing __webpack_public_path__ before importing worker script not work?

@pckhoi This is precisely due to me wanting to solve my cross-origin issue.
@evilebottnawi
I've created a small proxy on my Node.js backend that is in the same origin and under the hood loads content from the CDN. Now I want to use this proxy to load my worker.
@pckhoi
Changing the __webpack_public_path__ before importing the worker script didn't work well for me because I wasn't able to change it back to the previous value.
Trying to change it back caused it to work like I never changed __webpack_public_path__ before importing.

sounds resonable, I will thinking about this deeply in near future, right now I am focused on webpack-dev-server updating, so ping me at this Friday and we try to solve this

ping me at this Friday and we try to solve this

@alexander-akait I am pinging you 👀

ping me at this Friday and we try to solve this
@alexander-akait Is there any hope for tackling this issue?

Sorry for delay, deadline + a lot of issues, I remember about this, try to return to this in near future, sorry again

Sorry for delay, deadline + a lot of issues, I remember about this, try to return to this in near future, sorry again

Is there any way I can help you with that?

As minimum we need better name for this option

@alexander-akait
I think workerChunkUrl sounds fine, as long as we allow it to be relative path.


[Doc Improvement][Update App functionality description]

Updated the description.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
82
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit e674bf5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
82
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 043590d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
82
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 7f79ffc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
83
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit cb22628:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
83
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 4fd4a1b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
83
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 3ff32d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Added docker build of keybase client to Travis

@jzila Think I need more info -- what's the goal of this PR? And why does it push to $CI_HOST/keybase (the server repo?) from the client repo?

:+1: after changing CI_HOST/keybase to CI_HOST/kbclient


Add fix for CompileTimeErrorCode.SUPER_FORMAL_PARAMETER_WITHOUT_ASSOCIATED_POSITIONAL

This can use the AddMissingParameter fix if it can get the right list of ExecutableParameters.
CC @bwilkerson

Yes thats what I was thinking. That is also used for CompileTimeErrorCode.EXTRA_POSITIONAL_ARGUMENTS.


docs: add installation configuration question, file structure updated, description added, and toast typos fixed

Updates the questions to configures for installation
Fix incorrect CLI commands for toast addition on toast docs
Fix incorrect Manual code for toast on toast docs

@dan5py Seems like the PR was raised at a similar time. Guess, I will update the PR.


pug syntax

Hi, it seems some items in the pug syntax aren't highlighted
Gruvbox:

Nobber:

And is it possible for pug mixins to have a different color?
Gruvbox:

Nobber:

Besides, I love this theme!

Thanks for reporting these!
Pug mixins should now be colored aqua, which should offer better contrast against any possible mixin arguments.
These changes and more have made it into 1.2.3, so make sure to update.

yes, thanks! Looking good :)


Wrong label in the XDR pages, says “Transaction XDR” (lab v2)

The text input field is labeled as “Transaction” in both “XDR to JSON”  and “JSON to XDR”.
This is inaccurate as the type could be anything (not just TransactionEnvelope type).

Should say Base-64 encoded XDR
Thanks @MonsieurNicolas for raising these issues


expand/shrink feature

Description
Mainly for use with circles formed with "O" - but I guess could apply to any closed line :-
a way of expanding or shrinking it.  Would need to find a "centre" as a first step.
Screenshots
No response

It already exists!
When you're in "edit", click on the line of the circle (e.g. a roundabout) then "shift"+"+" (shift + plus) on your keyboard, not in iD itself!, will expand the size of the circle. Likewise, shift+- (shift + minus) will shrink them.
Also works on areas (at least buildings & car parks) if you click inside the area of the building, not on it's actual outline.
Have fun! :-)


queryForObjects() / query() with manual mapping of multiple classes

Currently:

queryForObjects() can only map a single class, although multiple rows/nodes
query() returns only Map, not mapped objects

Please add a variant to allow mapping of multiple classes, i.e. for Cypher queries having form MATCH ... RETURN a, b, ... where a and b are different @NodeEntity classes.
What I'm looking for is similar to Jackson's ObjectMapper.readValue() and ObjectMapper.writeValue()-style API methods.

Neo4j-OGM 2.0 supports this. You can return multiple entities via a Cypher query, and they'll be available in the map of results, as hydrated domain entities.
Here is an example: https://github.com/neo4j/neo4j-ogm/blob/2.0/core/src/test/java/org/neo4j/ogm/persistence/session/capability/QueryCapabilityTest.java#L240

@luanne Thanks! :) When will this be supported by Spring Data Neo4j ?

@ceefour you can use it already with 4.1.0.M1

Is there still an API to use the normal (unmapped) behavior?

No, with OGM 2.x/SDN 4.1, you'd have to return individual properties instead. By default, an attempt will be made to map the domain entities.
OGM 1.x/SDN 4.0 does not support mapping entities.


[SMALLFIX] Use @Nullable annotation for methods which may return null

[SMALLFIX] Use the @Nullable annotation for all methods which may return null in /alluxio/core/server/master/src/main/java/alluxio/master/file/meta/MountTable.java#reverseResolve

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3312/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3428/
Test PASSed.

alluxio-bot, merge this please


v0.2.0

@JuliaRegistrator register

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


page.sources()?

I'm trying to obtain a list of all the assets/URLs a page has loaded (or not). In essence, I'm looking for the equivalent of the "Sources" view in Chrome Inspector, which might be represented (naïvely) with a URI key pointing to a Response() object.
Should I grab the 'requestfinished'/'requestfailed' events and build by own convenience function to assemble that list, or is this something you might consider adding to the API?

Maybe this example can help?

Something like:
'use strict';

const puppeteer = require('puppeteer');

(async() => {

const browser = await puppeteer.launch();
const page = await browser.newPage();
await page.setRequestInterceptionEnabled(true);

const URLs = new Set();

page.on('request', request => {
  URLs.add(request.url);
  request.continue();
});
await page.goto('https://github.com/GoogleChrome/puppeteer');

console.log([...URLs].join('\n'));

browser.close();

})();

But API would also be helpful.

@vsemozhetbyt yeah, that's what I am doing, of sorts. I'm also interested in the responses, for testing purposes.

@vsemozhetbyt you can use the performance timing API:
await page.evaluate(`performance.getEntries()`);

@benjamingr the timing API does not yield URIs or response codes, which makes it unsuitable for my purposes.

@benjamingr I was trying this
  const URLs =
    [...await page.evaluate('performance.getEntries()')]
    .filter(entry => entry.entryType === 'resource')
    .map(entry => entry.name)
    .sort()
    .join('\n');

but I get empty string.
This code:
(await page.evaluate('performance.getEntries()')).map(entry => Reflect.ownKeys(entry))

gives this:
[ [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [] ]

Why does it return empty objects for PerformanceEntrys?

@rcarmo PerformanceEntrys has URI in name key.

@vsemozhetbyt That's because PerformanceResourcesTiming is not JSON serializable. If you do the filtering in the page, it'll work:
 const urls = await page.evaluate(() => {
    return performance.getEntries()
        .filter(e => e.entryType === 'resource')
        .map(e => e.name);
  });

Related: https://github.com/GoogleChrome/puppeteer/issues/310
Fix: https://github.com/GoogleChrome/puppeteer/issues/382

@vsemozhetbyt well, it actually depends on the timing entry (there are navigation and resource entries), but the resource entries do not have result codes (Chrome 60):
JSON.stringify(performance.getEntries()[1], null, '  ')
"{
  "name": "https://fonts.googleapis.com/css?family=Roboto:300,400,400italic,500,500italic,700,700italic|Roboto+Mono:400,500,700|Material+Icons",
  "entryType": "resource",
  "startTime": 1108.065,
  "duration":<PHONE_NUMBER>0000016,
  "initiatorType": "link",
  "workerStart": 0,
  "redirectStart": 0,
  "redirectEnd": 0,
  "fetchStart": 1108.065,
  "domainLookupStart": 1147.17,
  "domainLookupEnd": 1386.68,
  "connectStart": 1386.68,
  "connectEnd": 1447.3700000000001,
  "secureConnectionStart": 1402.155,
  "requestStart": 1447.8500000000001,
  "responseStart": 1504.685,
  "responseEnd": 1519.7600000000002,
  "transferSize": 982,
  "encodedBodySize": 747,
  "decodedBodySize": 3074
}"

It does tell me if it was a redirect (which is also useful for testing certain scenarios), but the approach of passing that on to page.evaluate() also means that something on the page can itself call clearResourceTimings() - I'd rather have something that cannot be broken by third-party scripts.

Should I grab the 'requestfinished'/'requestfailed' events and build by own convenience function to assemble that list, or is this something you might consider adding to the API?

@rcarmo You should listen to these events and build a convenience function, it should be very straightforward. You could also just listen to the response and it might have all the information you need.
@vsemozhetbyt await page.setRequestInterceptionEnabled(true); was not necessary in your snippet. In fact it is slowing down page load significantly - browser goes to puppeteer for every request it intends to issue.