KAFKA-10193: Add preemption for controller events that have callbacks

JIRA: https://issues.apache.org/jira/browse/KAFKA-10193

add preempt(): Unit method for all ControllerEvent so that all events (and future events) must implement it
for events that have callbacks, move the preemption from individual methods to preempt()
add preemption for ApiPartitionReassignment and ListPartitionReassignments
add integration tests:

test whether preempt() is called when controller shuts down
test whether the events with callbacks have the correct error response (NOT_CONTROLLER)

explicit typing for ControllerEvent methods

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

add preempt(): Unit method for all ControllerEvent so that all events (and future events) must implement it
for events that have callbacks, move the preemption from individual methods to preempt()
add preemption for ApiPartitionReassignmentand ListPartitionReassignments

Great idea

ok to test

retest this please

ok to test


Sidebar issue in Atom 1.17.x

Selected item not full width and wrong color on new git changes.

Seems to be issue with atom itself or material-ui. Closing.


[Feature suggestion for eSteem Surfer 2.0.5] Please Add "In Conversion" To Wallet

Hello eSteem Team,
When you start a conversion in steemworld.org for SBD to Steem the amount is taken from your wallet. The amount is transferred into the order section and the only place currently to track it is in your Steem wallet and SteemWorld where it shows the order. The conversion takes 3.5 days to complete and on eSteem Surfer 2.0.5 there is no where to reflect this transaction in progress.
I would like to suggest eSteem to implement this feature in order for its users to track and check their conversions from start to finish. I personally would like to see this happen and not having to rely on other tools and interfaces to go looking for this information.

Thanks for suggestion @erikah1! We will work on this, it should be simple relatively small change, @talhasch lets work on this in upcoming release...

Thank you very much!

I always use the latest version. I commented in the last post about 2.0.5. but probably I have not been seen.
I want to say what doesn't work for me:

I cannot choose favorite people
-I cannot see the followings list
-I cannot see the list of followers

@danbluemoon you can see your Favorites through menu here:

list of followers and followings will be added soon

Thank you for your reply.
I know where Favorites are.
I ask how I chose a new favorite? I must click on a heart icon and I don't find it
in the profile of the chosen person.
My name is @bluemoon, I sign up in github with a wrong username.

Thanks @danbluemoon for clarification.
Here is another screenshot on how you can favorite account:

Well, thank you very much! I'm sorry I didn't notice.


Adapt recent changes in the security plugin to pass integ test

Description
This PR changed the API called in main, but was not backported to 2.x: https://github.com/opensearch-project/security-dashboards-plugin/pull/1502. It also changes some text. This updates internal users tests to accommodate those changes. It should NOT be backported to 2.x line.
Issues Resolved
Fix: https://github.com/opensearch-project/security-dashboards-plugin/issues/1645
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Should fix: https://github.com/opensearch-project/security-dashboards-plugin/issues/1645

Sorry for so many pings recently, @SuZhou-Joe @ruanyl can you folks merge this in at the earliest convenience? Thanks!


Adding screenshots and update Readme.md examples

Now using a simpler example and adding a couple of screenshots.

Nice!  Thanks!


jax.tree_map -> jax.tree.map

The former has been deprecated since jax 0.4.26.
jax.tree.map was added in jax 0.4.25, so bump dep version.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks good to me!


Is there a way to use this with Nodejs 10.x - ES5?

I would love to use this for an AWS Lambda I'm creating.  I'm stuck in ES5 (Node 10.13).  10.13 only supports ES6 with --experimental-mode flag.  I haven't found a way to set that for Lambda.
I've tried various iterations with both the module and the drop in without any success...
All cause SyntaxError: Unexpected token because of ES6 Compatibility
import Simmer from 'simmerjs';
import Simmer from './node_modules/simmerjs/dist/simmer.js';
import { Simmer } from './simmerjs';
import Simmer from 'simmer.js'
import Simmer from "./node_modules/simmerjs/dist/simmer.js";

This causes a "window is undefined" error message
const Simmer = require("./node_modules/simmerjs/dist/simmer.js");

this causes "the SyntaxError: Unexpected token" error message because of the imports in the header
const Simmer = require("./node_modules/simmerjs/modules/simmer.js");

This loads fine but throws a "TypeError: Simmer is not a constructor" error on const simmer = new Simmer(jsdom_window)
const Simmer = require("simmerjs");
//

Hope you have some thoughts about what I haven't tried.  My next step is to try to transpile the module to ES5 with babel.
Thanks in advance,
E

Hi E,
You should definitely be able to consume Simmer using CommonJS, no need for ES modules, but as it's designed to be used by modules, you need to tell Node that you want to use the default export.
Note though that Simmer needs an HTML document to work on to figure out what the selector needs to be, so in Node you'll need to create an HTML document and tell Simmer to use it, and you can use a library like JSDOM to achieve this.
The example bellow works:
const Simmer = require('simmerjs').default; // Use commonJS to get default export

// create an HTML document to use as our reference for what the page looks like
const jsdom = require("jsdom");
const { JSDOM } = jsdom;
const dom = new JSDOM(`<!DOCTYPE html><p>Hello world</p>`);

// instanciate Simmer so it knows not to use a global Window, but rather the JSDom document
const simmer = new Simmer(dom.window.document);

// find the element we wish to generate a selector for
const paragraph = dom.window.document.querySelector("p");

// Ask simmer to generate a selector for it
console.log(simmer(paragraph)); // prints the selector "P"

If you have any other issues, feel free to ask and I'll try and help.

Perfect!  I just needed the .default.  I spent hours trying to resolve this.  Thank you for the quick response.

My pleasure 😁
On Wed, Aug 7, 2019, 14:58 eflyerman<EMAIL_ADDRESS>wrote:

Perfect! I just needed the .default. I spent hours trying to resolve this.
Thank you for the quick response.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/gmmorris/simmerjs/issues/13?email_source=notifications&email_token=AAC6JIEFEL64WXUXD6SBVXDQDLIHLA5CNFSM4IJ4XVB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3YPYSI#issuecomment-519109705,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC6JIEJP3OX3FRFAD3YWV3QDLIHLANCNFSM4IJ4XVBQ
.


Use unlimited max results by default (RDBMS & MongoDB)

Hi,
This change is to allow unlimited results by default for RDBMS and MongoDB.
Please note that the MongoESAggregationTest and the MongoESOrderByTest started failing for me though I'm not exactly sure if it's because of this change.
Can you please test it with a working ES setup?
Thanks!

Hi @rycus86
This can be handled by a small change in QueryImpl. We should not use additional custom property in persistence.xml for setting max results. Because, this property is specific to a particular query and setting it in persistence unit will make it available for all the queries on all the entities in that particular persistence unit which is not correct.
Thanks for the contribution. We can discuss more if you have any queries.
-Karthik

Hi @karthikprasad13
Yes, I was thinking about that but seems like some drivers actually need that number to be bigger than zero so I thought it's less chance of breaking other drivers if I just add an extension.
I could also move a setMaxResults(0) to the constructors of the Mongo and RDBMS specific Query implementation classes if we don't want the option globally.
Would that sound better?
Thanks,
Viktor

@rycus86
maxResults is by default set to 100, what do you mean by bigger than zero?
-Karthik

@karthikprasad13 yes but I'd like it as zero - only for RDBMS and Mongo where the driver can deal with this setting by default.
Feels like limiting the max results by default on systems which don't need it is unnecessary.

In that case, below should work.

I could also move a setMaxResults(0) to the constructors of the Mongo and RDBMS specific Query implementation classes if we don't want the option globally.

But we cant use additional property in persistence unit.
-Karthik

OK, I'll close this one and submit another one.
Thanks!


Is it possible to select only dates starting today?

Thanks!

Need this also

It's something that I need badly. Thanks!

You can implement this yourself using the on-before-render callback and setting .selectable = false on the dates/times that the user is not allowed to select.
There are examples in the demo directory that show you how to do this.

Ok, I've implemented my own solution.
It disable correctly the entries in the past in all views, except in the year view. In the year view, it disable also the current year.
Do you have any idea why?
Here's my before render function:
        function timepickerBeforeRender($view, $dates, $leftDate, $upDate, $rightDate) {

            var currentDate = new Date();
            var currentDateValue = currentDate.getTime();

            var yearViewDate = new Date(currentDate.getFullYear(), 0);
            var yearViewDateValue = yearViewDate.getTime();

            var monthViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth());
            var monthViewDateValue = monthViewDate.getTime();

            var dayViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth(), currentDate.getDate());
            var dayViewDateValue = dayViewDate.getTime();

            var hourViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth(), currentDate.getDate(), currentDate.getHours());
            var hourViewDateValue = hourViewDate.getTime();

            for (var index = 0; index < $dates.length; index++) {

                var date = $dates[index];

                // Disable if it's in the past
                var dateValue = date.localDateValue();
                switch ($view) {

                    case 'year':
                        if (dateValue < yearViewDateValue) {
                            date.selectable = false;
                        }
                        break;

                    case 'month':
                        if (dateValue < monthViewDateValue) {
                            date.selectable = false;
                        }
                        break;

                    case 'day':
                        if (dateValue < dayViewDateValue) {
                            date.selectable = false;
                        }
                        break;

                    case 'hour':
                        if (dateValue < hourViewDateValue) {
                            date.selectable = false;
                        }
                        break;

                    case 'minute':
                        if (dateValue < minuteViewDateValue) {
                            date.selectable = false;
                        }
                        break;
                }
            }
        }

Looks like an off-by-one error in your logic
var yearViewDate = new Date(currentDate.getFullYear(), 0);
var yearViewDateValue = yearViewDate.getTime();

// yearViewDateValue == 1-1-2015

if (dateValue < yearViewDateValue) { ... }

// 2015 < 2015 = false

I didn't run this, so if I am incorrect please post a fiddle or plunker that demonstrates the problem.

Yeah, it make total sense now.
Thanks a lot for the help!

@ccarnino : The above code looks good , except I was getting an error that , minuteViewDateValue is not defined .
Have added the fix for that in the snippet below .
`function timepickerBeforeRender($view, $dates, $leftDate, $upDate, $rightDate) {
        var currentDate = new Date();
        var currentDateValue = currentDate.getTime();

        var yearViewDate = new Date(currentDate.getFullYear(), 0);
        var yearViewDateValue = yearViewDate.getTime();

        var monthViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth());
        var monthViewDateValue = monthViewDate.getTime();

        var dayViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth(), currentDate.getDate());
        var dayViewDateValue = dayViewDate.getTime();

        var hourViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth(), currentDate.getDate(), currentDate.getHours());
        var hourViewDateValue = hourViewDate.getTime();

        var minuteViewDate = new Date(currentDate.getFullYear(), currentDate.getMonth(), currentDate.getDate(), currentDate.getHours() , currentDate.getMinutes());
        var minuteViewDateValue = minuteViewDate.getTime() ;

        for (var index = 0; index < $dates.length; index++) {

            var date = $dates[index];

            // Disable if it's in the past
            var dateValue = date.localDateValue();
            switch ($view) {

                case 'year':
                    if (dateValue < yearViewDateValue) {
                        date.selectable = false;
                    }
                    break;

                case 'month':
                    if (dateValue < monthViewDateValue) {
                        date.selectable = false;
                    }
                    break;

                case 'day':
                    if (dateValue < dayViewDateValue) {
                        date.selectable = false;
                    }
                    break;

                case 'hour':
                    if (dateValue < hourViewDateValue) {
                        date.selectable = false;
                    }
                    break;

                case 'minute':
                    if (dateValue < minuteViewDateValue) {
                        date.selectable = false;
                    }
                    break;
            }
        }
    }`

Thanks for the reply, but I don't have that application in production any more, so I will not be able to test it. But thanks anyway.

When to call this timepickerBeforeRender function ?


commit updates in Requests not visible

In several projects there is a case like this:

...so basically, there is no updates on commits.
How is this data being generated in the dashboard? Maybe understanding that will help resolve the matter.

@mikkokotila  👋
Commits are collected from all opened Pull Requests including in PR title RFC.

ah right, nice, thanks :)


trove classifiers aren't showing up on PyPI

https://pypi.python.org/pypi/inflection doesn't list the trove classifiers, causing https://caniusepython3.com/project/inflection to conclude Py3 support isn't available yet
I think this might be because classifiers is a tuple and not a list, looking into it

yep looks like that's the cause, PR incoming
https://bugs.python.org/issue19610


Localization fixes

I'll add to this pull request some localization-related fixes.
I can't create a pull request for each issue because they all depend on https://github.com/mlocati/concrete5/commit/f2a8b29debdb5158e2e342ca5d821bcd94cbad5f
If/when this pull request gets merged, I can create different pull requests.

I'm going to leave this up for some other reviews, but this looks good to me.

I'm going to leave this up for some other reviews

I agree. In particular the good pair of eyes of @ahukkanen are really appreciated.
I'm also going to inspect the localization caching system, but in the meanwhile this PR can be merged (or refused).

Looks all good to me! Generally this is just improving the codebase by moving the localization context strings to constants (:+1:), removing some use of the facade aliases and moving towards the shorthand notation of defining an array.
Only functional level change that I can see is happening in the setupSiteInterfaceLocalization() method (Concrete\Core\Multilingual\Service\Detector) that I might not understand 100% at this moment but looks OK code wise. Maybe if that part was extracted to its own method, we might be able to avoid nesting a couple of the if-clauses.
Maybe @KorvinSzanto can also have a look, usually this type of stuff falls more into his territory.

@ahukkanen You are right, most changes are quite irrelevant.
What really changed something are https://github.com/concrete5/concrete5/pull/5010/commits/4f390ad91f895fa3abf86f5090f76af3d44c4cca and https://github.com/concrete5/concrete5/pull/5010/commits/ff90afff2405874bffbc71488fdad74bbfda5cf3, where we always set the site context.

Regarding ff90aff, really glad to see shouldChangeContext() to go, it was very hacky in the first place. I remember it was fixing some problem regarding single page translation issues but of course, it's better if the fix is already "built in" in the translation layer.
I haven't tested these personally but this is basically the only functional change worth testing. Looks all good to me (simply judging by the code).

@ahukkanen What about these two new approaches I'm thinking about?
a) When we add new translation files to the Zend Translator, we reset its internal $messages array (for the applicable locale) and we change the cache identifier.
This would solve this problem we currently have:

we add a translation file to the Translator
we ask the Translator to translate a string
the Translator loads the translation file and place the read strings in the cache
we add the Translator another translation file
we ask the Translator to translate another string
Translator won't load the new translation file because its $messages array is already initialized

Resetting the $messages array is needed because we need to make Translator reload the strings.
Changing the cache identifier is needed to keep the cache system working and to be sure that the cached data contains all the translation strings.
b) We currently may have the two contexts ui and site pointing to the same locale (this case happens quite often). What about adding another layer that handles the connection between contexts and locales? That's aimed to have just one Translator instance per locale: if two contexts have the same locale they'd point to the same instance.
That would save a couple of hundreds of KB of memory usage.

a) Can you provide a real life use case when this is needed? I get the problem as described but I don't know when this happens.
b) Yes, saving memory would always be a good idea. One possible problem is that in some occasions the different locales might load different translation files. Not the core implementations but in some occasions we might want to load e.g. overriding translations to the site context and keep the ui context as is (in case we want to e.g. override a string that appears in the core translation files).
Don't know how often this would happen, so I guess this would be a marginal problem considering the benefit of saved memory.
Actually, I don't think this would require anything else than a couple of additional lines in TranslatorAdapterRepository. I don't think adding an extra layer to solve this would be necessary.

a) Sure: see #5004 (basically it tries to reduce the cases when we have t() calls before the translation files are fully loaded)
b) There are so many classes/interfaces/factories/adapters/repositories/loaders that I'm a bit lost (that's one of the consequences of a strict SOLID programming... I'm not saying that's bad, just saying I'm lost). I'll try to digger a bit in them...

Yeah, I remember the early t() calls were problematic before too.
If possible, I'd avoid initializing the translations multiple times and explore if it would be possible to maybe bypass the internal translation logic before we are 100% sure that all needed translations have been loaded.
I'd also think of some solution where we would manually call e.g. a method called loadTranslations() after the phase we would be sure everything is "ready" and we know the correct locale.
I don't know if this makes any sense but just a thought.

I don't think that inhibit translation would be nice... If someone needs t(), we must allow that...
What I described in a) would solve this problem in a more flexible way

Yeah, that might be. I just feel that during the early phases, no one needs the translation system to return the  (but of course calling t() should still be possible).

Yeah, that might be. I just feel that during the early phases, no one needs the translation system to return the real translations (but of course calling t() should still be possible).

It seems that many people call t() in packages on_start methods (and possibly in other places?), when (after #5004) package translations are set up, but the site translations may be not...

@mlocati In my opinion it would be better if the responsibilities of on_start() were clearly defined and people were guided towards hooking into the events after which translations have been loaded.
But in case this problem needs to be fixed for the current user without any changes to their code, I agree that the suggested way would be the way to fix it.

But in case this problem needs to be fixed for the current user without any changes to their code, I agree that the suggested way would be the way to fix it.

@ahukkanen It seems to me it's the safer approach... Let's see if someone takes care of https://github.com/zendframework/zend-i18n/pull/63 (that would simplify a lot what I have in mind)

@ahukkanen Last question... What do you think about https://github.com/mlocati/concrete5/commit/d02308357058dd2e73adc0e4e35dcfecc9e8101c ? I think it's a good alternative to solve problem a) and I don't see any drawbacks...

@mlocati, if you can make it work, all good and makes it much cleaner!
I there was originally some reason doing it that way, I think the database connection was not available in the early stages of the process when some of the config code was already calling the t() functions which initialized the translation loaders. Not 100% sure about that but all I can remember is that there was some reason for that.
See also 9a00a4ead5039aa9968b79cbab93cb28c9b2927d on why the other method was originally added in the DispatcherRouteCallback (don't know it you already saw that).

I did some test with https://github.com/mlocati/concrete5/commit/d02308357058dd2e73adc0e4e35dcfecc9e8101c (well, not exactly it, but the logic is the same), and everything seems to work fine.
BTW, I think that this PR #5010 can be considered as ready to be merged (or refused :wink: ).

I there was originally some reason doing it that way, I think the database connection was not available in the early stages of the process when some of the config code was already calling the t() functions which initialized the translation loaders.

I think it was only related to correctly loading the translation files (see https://github.com/concrete5/concrete5/pull/1920 )

I think it was only related to correctly loading the translation files (see #1920 )

OK! Makes sense.

@ahukkanen I implemented what we talked about here above (https://github.com/concrete5/concrete5/pull/5010/commits/1072e73b0197fe4cec25da4547f2e3a566884d68)
@aembler If it's ok for @ahukkanen, I think this PR is ready to be merged...

I also added to this PR this commit: https://github.com/concrete5/concrete5/pull/5010/commits/7160dfa53e8f8f07cf0fa5f2adbeb876da009805
This is required for single-language websites.

I just merged this, not sure why it's not showing as closed. Thanks!


Could not get data from API

screenshot:

request:
{"zone":"zone.home","style":"standard_style","dark_mode":false,"use_deprecated_forecast_attribute":"do_not_use_deprecated_forecast","language_override":"none"}

error response:
{"type":"form","flow_id":"82786b63ca072e6b438f057ce24314f0","handler":"irm_kmi","data_schema":[{"selector":{"entity":{"domain":["zone"],"multiple":false}},"name":"zone","required":true},{"selector":{"select":{"options":["standard_style","contrast_style","yellow_red_style","satellite_style"],"mode":"dropdown","translation_key":"style","multiple":false,"custom_value":false,"sort":false}},"name":"style","optional":true,"default":"standard_style"},{"type":"boolean","name":"dark_mode","optional":true,"default":false},{"selector":{"select":{"options":["do_not_use_deprecated_forecast","daily_in_deprecated_forecast","twice_daily_in_deprecated_forecast","hourly_in_deprecated_forecast"],"mode":"dropdown","translation_key":"use_deprecated_forecast_attribute","multiple":false,"custom_value":false,"sort":false}},"name":"use_deprecated_forecast_attribute","optional":true,"default":"do_not_use_deprecated_forecast"},{"selector":{"select":{"options":["none","fr","nl","de","en"],"mode":"dropdown","translation_key":"language_override","multiple":false,"custom_value":false,"sort":false}},"name":"language_override","optional":true,"default":"none"}],"errors":{"base":"api_error"},"description_placeholders":{"zone":"zone.home"},"last_step":null,"preview":null,"step_id":"user"}

Anyone else having this?

I presume this is due to:

Their main website is also down, I get either a 503 or a 504 like you.
There is nothing the integration can solve here. Just be patient and wait until the API is back online.
https://www.meteo.be/


Implemented a textual copypaste in hybrid editor

Implementation notes:
ByBoundsCompletionItem allows completing the whole string literals, from opening quote to closing one. I expect strings editing to be backed by two completion items: Simple and ByBounds; first will complete single quote input (when you just type "), and second will work when you paste quoted string. However, tokenizing is not only useful application of ByBoundsCompletionItem: suppose you have typed a string without opening quote (abc") — this won't be completed; then you position a cursor to the string beginning and type opening quote — and ByBounds completes the whole string ("abc").
Tokenizer tokenizes some string against completions provided by HybridEditorSpec. Algorithm tries to find the longest single-match completions in input. This class is not a part of public API because it may change soon: further copypaste implementation will require adding more features and extension points to this class.
ClipboardContent implementation in HybridSynchronizer checks tokens against text() method support by catching UnsupportedOpertationException. This is not the best way; better would be checking something like HybridEditorSpec.supportsToText(), but this interface is public API which discourages adding new methods unless it's Java 8. When we migrate to it, I will rewrite this part.
Test application is added string literals and copypaste support, please try. Strings editing may seem not absolutely smooth; it will improve as we develop this feature.

In CellTrait, if we have onAdd method, we should add a symetric onRemove method (not onAdded).
Instead of getLastSeenText(), please create a test implementation of keyboard and use it. We shouldn't expose too many internals just for test, especially if we can get by without such changes.
Otherwise everything looks fine and I am ready to merge it.


feat: migrate all entry screen, ctas to new add account v2

✅ Checklist

[x] npx changeset was attached.
[x] Covered by integration test of AssetSelection in this scope.
[ ] Impact of the changes:

...

📝 Description
When llmNetworkBasedAddAccount feature flag is enabled, all the ctas that open an add account process will be redirected to the new flow and support currency and related route params.
Entry point list:

Swap
Buy
Earn/Stake
Asset
Wallet
Deeplinks
Market
Receive Flow

The new add account flow start either by a new Crypto selection  or via Network provider (AssetSelection feature). If those informations are provided in the route params then the next step is to Connect the device and Scan & Select found account (will be adjusted in the next ticket).
 Important

The scope of the ticket is the entry point, SelectCrypto or SelectNetwork when currency is provided in the route params.

Changes in ledger-live-common
Here is my analysis on the subject!
It is the SelectCrypto component, during its mounting, that intercepts the currency from the params and uses this info in a useEffect to simulate an explicit redirection:

To SelectNetwork: if the currency has at least one network provider (I will come back to this)
Otherwise,
To SelectAccount: if a scan has already been done previously on this currency
Otherwise,
To the SelectDevice process and scan & co

What happens during the mounting is that it intercepts ethereum as currency, calls a custom hook useGroupedCurrenciesByProvider, and triggers a useEffect to redirect if needed.
The problem is that the custom hook is slow since it depends on an asynchronous operation to return a 'result' containing 2 arrays:

sortedCryptoCurrencies
currenciesByProvider
The first execution returns 2 empty arrays.

From the second execution, the arrays are filled.
Hence, the useEffect is triggered twice on the SelectCrypto side,
The first without providers redirects to SelectAccount,
Then the second arrives a few seconds later, following the new return of the custom hook which changes the ref of the onPress function that triggers the useEffect a second time
Consequently, a redirection to SelectNetwork occurs. This results in this strange and ambiguous behavior from a UX point of view.
The root cause of all this is that the useEffect managing potential navigation depends on an onPress callback, which in turn depends on the result of the custom hook useGroupedCurrenciesByProvider, while we do not have the information that it is loading the data. It executes with the result of its initial state and then with the filled arrays.
On the add-account, I made sure to better control this custom hook with a loading system with 4 states: idle, pending, success, and error, so that we extract this information at the instantiation of the hook.
Consequently, the useEffect only triggers if the asynchronous operation is finished (success OR error state).

Example of issue

https://github.com/user-attachments/assets/280ce5d3-d8be-4f4e-af43-0c4957a9e06f

When fixed

https://github.com/user-attachments/assets/4be46ec0-6320-4f5b-9dcc-7f4addc86666
Test revision is done

here ➡ https://ledgerhq.atlassian.net/browse/LIVE-15374?focusedCommentId=501993

Video preview in progress 📹 ⚠

❓ Context

JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-15374
🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

We need to fix the issue with the Select Asset screen blink, please.
We can't keep it as is for the end user + it breaks navigation by adding this step.
Can you have a look on how to fix it, please?

@KVNLS fixed

Unit test for LLC are working fine even after purging turbo cache, probably it's a flaky test on ubuntu


io.js 2.0 support.

nan dependency should be updated to ~1.8.0.
Or to ^1.7.0 or ^1.8.0 if you don't want to update package.json with every new minor version of nan.

package.json updated


Allow us to override the shader versions for pixel and vertex shaders individually.

My first PR to this repo, nothing seems broken in my testing!

Alright! hopefully thats all good :D

Please squash your commits into a single commit (makes merging this a lot easier).
There are a bunch of guides online for how to do that, this one seems decent:
https://www.git-tower.com/learn/git/faq/git-squash (the interactive rebase part)

Please squash your commits into a single commit (makes merging this a lot easier).
There are a bunch of guides online for how to do that, this one seems decent: https://www.git-tower.com/learn/git/faq/git-squash (the interactive rebase part)

Alright done!

Just merged this to our internal repo. It should show up in Github within the next hour or so.


Mapped restricted and ultra restricted users in slack to zulip guest

This PR is regrading issue  #13255
The users restricted and ultra restricted users imported from slack will be mapped with Zulip's guests.

We'll want unit tests for this.
@hackerkid can review this once it has tests.

@Chinmay-Gurjar This looks like a great first PR. I went through the code quickly and added one minor comment. I will review thi once you are done with tests.

@hackerkid I don't know why this is failing CircleCI tests. Can you please direct me where the problem is ?

@Chinmay-Gurjar Rebase your code on top of zulip upstream master branch, push to the fork and see if it works.
git pull --rebase upstream master

where upstream points to https://github.com/zulip/zulip

To expand on
git pull --rebase upstream master

The upstream remote needs to be added at .git/config file
[remote "upstream"]
	url = git@github.com:zulip/zulip.git
	fetch = +refs/heads/*:refs/remotes/upstream/*

@hackerkid  I tried but things aren't working out for me, I think I messed up somewhere I don't know. Can I just open another Pull Request ?

@Chinmay-Gurjar You can ofocurse open another pull request. But I am not sure whether its necessary. You can use git rebase command to squash all the commits into one commit. Try and see if you can do that. If not feel free to open another PR. Also take a look at this.
https://zulip.readthedocs.io/en/latest/git/overview.html

@hackerkid I guess it's done, can you please a look ?

@Chinmay-Gurjar Please merge all the commits into one commit. Also please look at the comment I left before.

@Chinmay-Gurjar  relevant how-to on squashing multiple commits into one:

https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git
https://www.internalpointers.com/post/squash-commits-into-one-git

Or alternatively, just open a new PR with a new branch containing one commit.
Either way there shouldn't be any blocker to this PR other than just technical issue.


SNOMED nodes in KG2.7.1

I noticed that there are about 9,000 nodes in KG2.7.1 that have an ID starting with SNOMED:
seems unexpected given that we started excluding SNOMED from KG2 with KG2.6.7, and I confirmed that KG2.6.7 doesn't have any nodes with SNOMED:__ IDs.
looks like they're basically all coming from MONDO:
match (n) where n.id starts with "SNOMED:" return n.knowledge_source, count(distinct n) order by count(distinct n) desc

n.knowledge_source
count(distinct n)

"infores:mondo"
9000

"infores:genepio"
1

(@ericawood confirmed this seems unusual in Slack and said they'll look into it)

Erica and I decided that the KG2 team will try to fix this issue in 2.7.2, and that we will not hold up roll-out of 2.7.1 over this issue. Is that OK?

yep, sounds good to me!

Surprisingly, this is still an issue, but a very minor one now. There is only one SNOMED: node left in KG2, as of KG2.8.3.
match (n) where n.id starts with "SNOMED:" return n.provided_by, count(distinct n) order by count(distinct n) desc

n.provided_by
count(distinct n)

"['infores:genepio']"
1

Huh, KG2 never ceases to amaze me. I wonder how that got in there?

It's still in KG2.8.6pre:
(venv) sramsey-laptop:automat-test sramsey$ python3 find_snomed.py | grep SNOMED
SNOMED:22642004

Here is the node JSON for that node:
{
    "category": "biolink:NamedThing",
    "category_label": "named_thing",
    "creation_date": null,
    "deprecated": false,
    "description": "An assay for detecting bacteria by subjecting them to strain-specific bacteriophages.",
    "full_name": null,
    "has_biological_sequence": null,
    "id": "SNOMED:22642004",
    "iri": "http://www.snomedbrowser.com/Codes/Details/22642004",
    "name": "Bacterial bacteriophage typing",
    "provided_by": [
        "infores:genepio"
    ],
    "publications": [],
    "replaced_by": null,
    "synonym": [],
    "update_date": "2023-09-08 22:01:14 GMT"
}

OK, I checked on kg285build.rtx.ai, and found  the following in genepio.owl:
    <!-- http://snomed.info/sct/22642004 -->

    <owl:Class rdf:about="http://snomed.info/sct/22642004">
        <rdfs:subClassOf rdf:resource="&obo;OBI_0000070"/>
        <obo:IAO_0000412 rdf:resource="http://snomed.info/sct/900000000000207008"/>
        <rdfs:label xml:lang="en">Bacterial bacteriophage typing</rdfs:label>
        <rdfs:seeAlso>http://phinvads.cdc.gov/vads/http:/phinvads.cdc.gov/vads/ViewCodeSystemConcept.action?oid=2.16.840.1.113883.6.96&code=22642004</rdfs:seeAlso>
    </owl:Class>

I can live with this. Closing this issue.

If you delete the SNOMED mapping in the mapping YAML files, that might solve this issue. (Also, as a reminder, please rely on the umls.jsonl file in ~/kg2-build/ rather than the TTL files now, with the new UMLS ETL process @saramsey, it will be more up to date).

Thank you @ecwood !


expect([]).toHaveSameItems({}) throws TypeError

expect([]).toHaveSameItems({})

This throws TypeError: Cannot read property 'length' of undefined even though the docs suggest that this should work.
expect(<Array, Object>).toHaveSameItems(<Array, Object>, [<boolean> ignoreSort])

pass: mismatches.length === 0 line 116
mismatches is undefined, because the input state has not been fully checked.
if(Array.isArray(actual) && Array.isArray(expected)) { line 99
else if(isObject(actual) && isObject(expected)) { line 112
Consider normalizing the input before comparison to avoid the explicit type checking or updating the documentation if this is intended behavior. I would prefer allowing developers to compare collections regardless of type.


Not an issue - richer datasets

are you familiar with this https://twitter.com/e08477/status/1418440857578098691?s=21 ?
I want to do cityscape shots. Are you familiar with any relevant datasets?
Can this repo help output higher quality images? Or does it help with the prompting?

Hi, I was not aware of these, these are very beautiful!
the repo is not meant to output higher quality images (quality should be the same as VQGAN-CLIP examples) or help with prompting, it is meant to do the same thing without needing an optimization loop for each prompt, and can also generalize to new unseen prompts in the training set. All you need is to collect/build a dataset of prompts and train the model with it, once it is done you can generate images with new prompts. I will shortly also upload pre-trained model(s) based on conceptual captions 12m prompts (https://github.com/google-research-datasets/conceptual-12m), if you would like to give it a try without re-training from scratch. Also, since you obtain a model at the end, additionally you can also interpolate between the generated images of different prompts.  I hope the goal of the repo is clearer.

"so no optimization loop" -
does that mean there's no 500x iterations to get a good looking image?
fyi - @nerdyRodent

" does that mean there's no 500x iterations to get a good looking image?" Yes

Following the tweet you mentioned above, here is an xample with "devianart, volcano": https://imgur.com/a/vvWPDSz with a model currently being trained on conceptual captions 12m

@johndpope I added a bunch of pre-trained models if you want to give it a try

I had a play with the 1.7gb cc12m_32x1024 - I couldn't get my high quality that I was getting on VQGAN-CLIP - will keep trying - bumping the dimensions. Maybe docs could use some pointers - 256 x256 / 512x512 etc
One thing is clear - this can perform very quickly - perhaps efforts to have this provide a hot serving whereby you could give it a new prompt / running a service / almost in realtime without turning off the engine so to speak. We talk about FPS - frames per second - could we see a VQPS ???
Here's some images I turned out over the weekend -
https://github.com/nerdyrodent/VQGAN-CLIP/issues/13
Observerations
When I threw in a parameter - it was clearly identifable.
Los Angeles | 35mm
Eg. https://twitter.com/johndpope/status/1419352229031518209/photo/1
Los Angeles Album Cover
https://twitter.com/johndpope/status/1419354082192412679/photo/1
This didn't quite cut it.
python -u main.py test pretrained_models/cc12m_32x1024/model.th "los angeles album cover"
Other improvements for newbies - you could consider integrating these downloads into readme
https://github.com/nerdyrodent/VQGAN-CLIP/blob/5edb6a133944ee735025b8a92f6432d6c5fbf5eb/download_models.sh

@johndpope have you considered re-embedding the outputs from the trained vitgan as clip image-embeds; and then using those as prompts to a "normal" VQGAN-CLIP optimization with a much higher learning rate than usual and fewer steps? That will allow you to use non-square dimensions.
Also - one of the other primary benefits of this approach is that if you'd like to finetune from one of the checkpoints or even train your own from scratch - this can be relatively simple as all you need are some captions which can be generated/typed out. You'll want to cover a large-ish corpus but using something like the provided MIT states captions as a base should be a good start.
Thanks for the extra info. I'm a little busy today but I think the README might need one or two more things and possibly a colab notebook specific to training (if we don't have that already) that would make it easy to customize MIT states.


use of the  CP2102 USB to TTL converter

i assume the use of a  CP2102 USB to TTL converter is not required if you have a KKL-USB cable with a FTDI chip. The FTDI chip with the suitable drivers makes the the USB act as a serial port. Hence this code will work ?

i have a 5 pin cp2102 module. it doesnot have DTR pin and i am not able to program atmega328p,


fixing destructuring issue exposed with Xcode 16b1

Remove type information from tuples destructuring results from enumerated(), which is failing to compile with Xcode 16b1
resolves #68

didn’t @xedin fix this in https://github.com/apple/swift/pull/73983 ? it was merged 3 weeks ago, so perhaps it did not make the cutoff for the Xcode beta.
if this is urgent, i’d rather you add the labels to the type annotations so that they match enumerated rather than removing them entirely :)

I guess it didn't make it in. Since this is something you knew about already, I'll close the PR - don't need this critically at all.


Always make BUILD_DISTPATH a posix path

After action-gh-release was updated globs are handled differently. This is because the glob library it uses was updated. The updated glob library always interprets backslashes as escape characters. This means if BUILD_DISTPATH has backslashes in it, action-gh-release won't match it correctly and won't upload our archives. To fix this, we can make sure to always use a posix path.

Here is the relevant text from v8.0.3 of node-glob's README:

Please only use forward-slashes in glob expressions.
Though windows uses either / or \ as its path separator, only / characters are used by this glob implementation. You must use forward-slashes only in glob expressions. Back-slashes will always be interpreted as escape characters, not path separators.


Check PHP 7 with adapter

https://github.com/alcaeus/mongo-php-adapter

Successfully checked in branch https://github.com/sokil/php-mongo/tree/php7-compat-layer


LWS does not match current OpenHowNet implementation

In openbackdoor/data/lws_utils.py line 130 no longer works.  OpenHowNet no longer accepts structured or lang keywords.
Line 134 also breaks.  The subtrees of sememe_tree does not have the keys "word" or "syn"

Downgrading OpenHowNet to version 1.0 resolves this issue


Can't set 24h format

Hello,
The 24 hours format is set using this rule:
...
 is24Hour: !this.format.match(/h|a/)
...

I don't understand this rule, can someone tell me more about it ?
If I set format to "HH[h]mm[m]", it returns false, but in my case I want it to be true.
Maybe is24Hour should be a option passed with props directly, with a default tofalse ?

You should use format like that,
format={'HH:mm'}


Upgrading to v1?

Are there any plans to upgrade this to work with V1? I just tried this with your configuration and it doesn't work.

I'd like to see this also!

+1

+1

Fixed to work with the latest version while maintaining compatibility with v0.74!


Fix docker-db issue with database

Currently, the docker-db running the scalar function integration test brings the docker-db sooner or later into a state where it rejects connections due to a lack of free space.
Sometimes this error also occurs during the test-run. In that case, after a certain point in time, all tests-fail.

I can not investigate here right now, but have to wait after Christmas after some required experts are back from vacation.

did not occur again...

did not occur again...


Listening to Windows RT events

I tried using Powershell to listen to the Dismissed event of a ToastNotification as follows:
$toast = [Windows.UI.Notifications.ToastNotification]::new( ... )
$notifier = [Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier( ... )
$notifier.Show($toast)

Register-ObjectEvent -InputObject $toast -EventName Dismissed -Action { ... }

Running this code, however, fails with the following exception message:
Windows PowerShell cannot subscribe to Windows RT events.
Therefore, I'd like to ask:

Does a workaround exist to subscribe to Windows RT events from Powershell?
Is there another way to query the current state or final result of a ToastNotification (i.e. whether it is Activated, Dismissed, or Failed) from Powershell?

Any help is much appreciated.

We need to check with latest builds or simply close.

Any update on this in 2020? It's weird that I can do a ton of WinRT stuff, but then cannot register event handlers.

@citelao Do you test with latest PowerShell 7.0 build?

I found a workaround from @david-risney https://deletethis.net/dave/2016-06/WinRT+Toast+from+PowerShell

If you can get that working @iSazonov (or anyone out there) I'll send you a beer or something!
A lot of the APIs/References that uses have changed. I managed to compile and get it working on Windows 8 (maybe 8.1), but haven't been able to replicate on Windows 10 even after updating references etc. I even reached out to Dave at one point to see if he knew how to update it for Windows 10.
As for if it works on the current version, I test this in every Windows update and PowerShell release because I'm very invested in seeing this work. The answer today with Windows 10 1909 and PowerShell 7.1 is... no:

@Windos Please share you test script.

@iSazonov sure thing: https://gist.github.com/Windos/78ed980d926c634d0acede61e44a29af

After reviewing this I see that PowerShell need a wrapper to process WinRT events.
I am not sure that it is stable area (API) to allow us to inject this in PowerShell engine. So best way to address the issue is to create a module in PowerShell Gallery.
Perhaps @rkeithhill could share thoughts.
@rjmholt @TylerLeonhardt  Perhaps it is useful for PowerShell related projects.

It seems .Net Core has a code for WinRT events. https://github.com/dotnet/runtime/blob/c9edf7e621350ae8171e1ae4461d4a9e2c74c092/src/libraries/System.Runtime.WindowsRuntime/src/System/Runtime/InteropServices/WindowsRuntime/MarshalingHelpers.cs#L199 I don't know whether we use it.

I wish I could be of more help actually writing a solution to this, my C# is both rusty and rudimentary ☹
I can point to where the check for WinRT events in the PowerShell code base is though, in case that helps anyone: https://github.com/PowerShell/PowerShell/blob/b7cb335f03fe2992d0cbd61699de9d9aafa1d7c1/src/System.Management.Automation/engine/EventManager.cs#L675

It is block condition only for writing user friendly message. Really AddEventHandler() below does not support WinRT events.
If you want to get a progress you could open an issue-question in .Net Runtime repo about how work with WinRT events in .Net Core.

issue is still present, no solution to use event with toast notification with Ps7
$XmlString = @"

Default Notification

"@
$AppId = 'Microsoft.AutoGenerated.{A49227EA-5AF0-D494-A3F1-0918A278ED71}'
$null = [Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime]
$null = [Windows.Data.Xml.Dom.XmlDocument, Windows.Data.Xml.Dom.XmlDocument, ContentType = WindowsRuntime]
$ToastXml = [Windows.Data.Xml.Dom.XmlDocument]::new()
$ToastXml.LoadXml($XmlString)
$Toast = [Windows.UI.Notifications.ToastNotification]::new($ToastXml)
$Toast | Get-Member -MemberType Event
Register-ObjectEvent -InputObject $Toast -EventName Activated -Action {
Out-File -FilePath C:\Temp\Event.txt -InputObject (Get-Date -Format 'o') -Append -Force
}
PS C:\temp\1110> .\testtoast.ps1
TypeName: Windows.UI.Notifications.ToastNotification
Name      MemberType Definition

Activated Event      Windows.Foundation.TypedEventHandler2[Windows.UI.Notifications.ToastNotification,System.Object... Dismissed Event      Windows.Foundation.TypedEventHandler2[Windows.UI.Notifications.ToastNotification,Windows.UI.No...
Failed    Event      Windows.Foundation.TypedEventHandler`2[Windows.UI.Notifications.ToastNotification,Windows.UI.No...
Register-ObjectEvent : Windows PowerShell cannot subscribe to Windows RT events.
At C:\temp\1110\testtoast.ps1:26 char:1

Register-ObjectEvent -InputObject $Toast -EventName Activated -Action ...

  + CategoryInfo          : InvalidOperation: (Windows.UI.Noti...astNotification:ToastNotification) [Register-Object
 Event], InvalidOperationException
  + FullyQualifiedErrorId : INVALID_REGISTRATION,Microsoft.PowerShell.Commands.RegisterObjectEventCommand

getting the same issue but seems like there is no proper solution for this yet.?


Cannot find module 'buoy' in v7 of smooth-scroll

Hey, I'm getting an error saying Cannot find module 'buoy' in the most recent version of smooth-scroll (v7). Not sure why though since in your release notes it says 'buoy' was removed.
I'm using version v0.10.28 of node so maybe that's causing it to not find the 'buoy' module?
Switching to 5.3.7 fixed the issue ("smooth-scroll": "git://github.com/cferdinandi/smooth-scroll.git#b5621ff47293b8ec957c271a72121254349f169e"). Then npm install
No rush on fixing this cause the old version works just fine, this is more just an fyi.
See below for the stack trace:
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: Cannot find module 'buoy' from '/Users/timscanlin/Sites/developers.optimizely.com/node_modules/smooth-scroll/dist/js'
    at /Users/timscanlin/Sites/developers.optimizely.com/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
    at process (/Users/timscanlin/Sites/developers.optimizely.com/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Users/timscanlin/Sites/developers.optimizely.com/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
    at load (/Users/timscanlin/Sites/developers.optimizely.com/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/timscanlin/Sites/developers.optimizely.com/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /Users/timscanlin/Sites/developers.optimizely.com/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at Object.oncomplete (fs.js:107:15)

npm ERR<EMAIL_ADDRESS>gulp: `gulp`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>gulp script.
npm ERR! This is most likely a problem with the developers.optimizely.com package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp
npm ERR! You can get their info via:
npm ERR!     npm owner ls developers.optimizely.com
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 14.3.0
npm ERR! command "/Users/timscanlin/.nvm/v0.10.28/bin/node" "/Users/timscanlin/.nvm/v0.10.28/bin/npm" "run" "gulp"
npm ERR! cwd /Users/timscanlin/Sites/developers.optimizely.com
npm ERR! node -v v0.10.28
npm ERR! npm -v 1.4.9
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!      I made updates to the source but didn't run the build, so the dist directory still contains both Buoy itself and the previous iteration of the script that passed in Buoy as a dependency. This isn't a problem when loading the script the old fashion way, but when using module systems like Browserify, it will throw an error for the missing dependency.
I'll rerun the build and push an update in the next 15 minutes. Thanks for letting me know about this!

Fixed

Thanks for fixing this so fast, you're awesome! :)

Actually, I'm apparently not. I didn't do the things I needed to do. Oy, not enough coffee!

Ok, properly fixed this time. Sorry!
You want v7.0.2. https://github.com/cferdinandi/smooth-scroll/pull/185

Cool, thank you!!


Usermin theme messed up

I think error started appearing after I logged out of a Usermin session. There were some error messages that I unfortunately did not have time to take note of. They were related to Perl modules.
The next time I tried to login to Usermin, Authentic Theme was messed up. Other themes work fine.
As the issue seems related to #567 I tried installing the latest version of AT 18.21 but no improvements.
Usermin restarted. Issue is present in at least Firefox and Chrome, Mac OSX.
Operating system 	Ubuntu Linux 14.04.2
Webmin version 	1.821
Virtualmin version 	5.04
Theme version 	Authentic Theme 18.20 and 18.21
To reproduce the issue:
Login to Usermin via the Webmin UI: Edit User > Login to Usermin

Please reinstall the theme for Usermin:
https://github.com/qooob/authentic-theme/issues/572#issuecomment-258248017

..and restart Usermin and Webmin afterwards.

Missed that issue - thanks I will try that!


Auto init test helpers

What kind of change does this PR introduce?

Improves DX by setting up auto cleanup & test initialisation

What is the current behaviour?
User has to manually call initTestHelpers in their testing setup to avoid errors at runtime.
What is the new behaviour?
Users don't have to do anything. They can directly use next-page-tester imports and everything will work out of the box.
Does this PR introduce a breaking change?
No
Other information:
Please check if the PR fulfills these requirements:

[x] Tests for the changes have been added
[x] Docs have been added / updated

Coverage decreased (-0.1%) to 99.873% when pulling 1122f3f2448b6d1d892d747e09d471ec196bdcbc on auto-init-test-helpers into 732d6b71bc59a159b3168168d1cbc6e759c56e37 on master.

Updated with your suggestions @toomuchdesign I think we should be good to go 🚀


Update articles mentioning A2HS trigger in DevTools (that it's gone)

Page Affected:

https://developers.google.com/web/fundamentals/app-install-banners/#test
https://developers.google.com/web/fundamentals/web-app-manifest/#test
https://developers.google.com/web/tools/chrome-devtools/progressive-web-apps#manifest

What needs to be done?
The trigger is removed in https://crrev.com/72cfd665f9 and is shipped with Chrome 73.
(I was wondering why it's not there the other day and found the commit.)
And I just saw a tweet wondering the behavior is changed.
https://twitter.com/azu_re/status/1106731545857949696
There seems to be an ongoing work to bring it back ( https://crbug.com/915945 ) but until then it's gone and that might confuse more people.
So, I think we should add some notes that it's (temporally) gone.
Perhaps promoting the #enable-desktop-pwas-omnibox-install flag might be helpful for devs looking for alternatives ;)

[ ] Appropriate type-something label has been added.
[ ] Appropriate section-something label has been added.

think #7520 is a dupe


werkzeug.exceptions.NotFound

I have been trying to get started with digits - my first attempt , I hit 'create dataset' after setting  image dirs  and setting params, but the job never runs, only indiciates 'initialized'.  The text files with image names were created fine but job never seems to run. Second attempt I get a python error ending with 'werkzeug.exceptions.NotFound', the source code for this error did'nt clue me in as to what the problem might be, then I noticed in the terminal from which i started my browser 'scheduler not running' - how would i start the scheduler?
killing the digits process (found my ps -aux|grep digits) and restarting using
python /usr/bin/gunicorn --config /usr/share/digits/gunicorn_config.py digits.webapp:app
didn't seem to help matters.

This sounds like you might possibly be missing some dependencies? Or maybe you have a dependency with too new or too old of a version? I'll need some more information to do better than guessing.
Can you post the full error message you're seeing?

i can't copy/paste from the vnc i am running this on but the traceback synopsis is
flask/app.py line 1475 full_dispatch_request
flask/app.py line 1461 dispatch_request
dataset/views.py line 25
raise werkzeug.exceptions.NotFound('Job not Found'
NotFound:404:NotFound
again it seems the prob is probably related to 'schduler not running' , how would i start that

The scheduler is started for you automatically (whether you're using digits-devserver or digits-server):
https://github.com/NVIDIA/DIGITS/blob/v3.2.0/digits-devserver#L51
https://github.com/NVIDIA/DIGITS/blob/v3.2.0/gunicorn_config.py#L13
Can you tell me what version of the code you're running?
$ git describe
v3.2.0-3-g3ccc526

And which versions of python packages you have?
$ pip list
alembic (0.6.2)
argparse (1.2.1)
backports.ssl-match-hostname (<IP_ADDRESS>)
beautifulsoup4 (4.2.1)
blinker (1.3)
bzr (2.7.0dev1)
bzr-builddeb (2.8.6)
...

i installed from apt-get , to find version i did
root@braini1:/var/log/digits# apt-cache policy digits
digits:
  Installed: 3.0.0-1
  Candidate: 3.0.0-1
  Version table:
 *** 3.0.0-1 0
        500 http://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu1404/x86_64/  Packages
        100 /var/lib/dpkg/status
root@braini1:/var/log/digits#

and the pip list

root@braini1:/var/log/digits# pip list
adium-theme-ubuntu (0.3.4)
apt-xapian-index (0.45)
argparse (1.2.1)
Babel (1.3)
beautifulsoup4 (4.2.1)
blinker (1.3)
boto3 (1.2.3)
botocore (1.3.15)
chardet (2.0.1)
click (6.2)
colorama (0.2.5)
command-not-found (0.3)
cvxopt (1.1.4)
Cython (0.20.1post0)
debtagshw (0.1)
decorator (3.4.0)
defer (1.0.6)
dirspec (13.10)
docutils (0.11)
duplicity (0.6.23)
feedparser (5.1.3)
Flask (0.10.1)
Flask-SocketIO (0.6.0)
Flask-WTF (0.11)
futures (3.0.3)
gdata (2.0.18)
gevent (1.1rc3)
gevent-socketio (0.3.6)
gevent-websocket (0.9.3)
green (2.2.0)
greenlet (0.4.9)
gunicorn (17.5)
gyp (0.1)
h5py (2.2.1)
html5lib (0.999)
httplib2 (0.8)
idna (2.0)
ipython (1.2.1)
ipython-genutils (0.1.0)
itsdangerous (0.22)
Jinja2 (2.7.2)
jmespath (0.9.0)
joblib (0.7.1)
Keras (0.3.1)
Lasagne (0.2.dev1, /root/Lasagne)
leveldb (0.1)
lmdb (0.87)
lockfile (0.8)
lxml (3.3.3)
Mako (0.9.1)
MarkupSafe (0.18)
matlabengineforpython (R2015b)
matplotlib (1.3.1)
meld3 (0.6.10)
mercurial (2.8.2)
mock (1.0.1)
MySQL-python (1.2.3)
networkx (1.8.1)
nose (1.3.1)
numexpr (2.2.2)
numpy (1.8.2)
oauthlib (0.6.1)
oneconf (<IP_ADDRESS>.04.1)
openpyxl (1.7.0)
PAM (0.4.2)
pandas (0.13.1)
path.py (8.1.2)
patsy (0.2.1)
pexpect (3.1)
pickleshare (0.6)
Pillow (2.3.0)
pip (1.5.4)
piston-mini-client (0.7.5)
Pmw (1.3.2)
protobuf (2.5.0)
psutil (1.2.1)
psycopg2 (2.4.5)
PyChart (1.39)
pycrypto (2.6.1)
pycups (1.9.66)
pycurl (7.19.3)
pydot (1.0.28)
Pygments (1.6)
pygobject (3.12.0)
pyinotify (0.9.4)
pymongo (3.2)
PyOpenGL (3.0.2)
pyOpenSSL (0.13)
pyparsing (2.0.1)
Pyrex (<IP_ADDRESS>)
pyserial (2.6)
pysmbc (<IP_ADDRESS>)
python-apt (<IP_ADDRESS>ubuntu2)
python-dateutil (1.5)
python-debian (0.1.21-nmu2ubuntu2)
python-gflags (1.5.1)
python-ldap (2.4.10)
python-openid (2.2.5)
pytz (2012c)
PyWebDAV (0.9.8)
pyxdg (0.25)
PyYAML (3.10)
pyzmq (14.0.1)
redis (2.10.5)
reportlab (3.0)
requests (2.2.1)
roman (2.0.0)
rq (0.5.6)
scikit-image (0.9.3)
scikit-learn (0.14.1)
scipy (0.13.3)
selenium (2.49.2)
sessioninstaller (0.0.0)
setuptools (3.3)
simplegeneric (0.8.1)
simplejson (3.3.1)
six (1.5.2)
software-center-aptd-plugins (0.0.0)
ssh-import-id (3.21)
statsmodels (0.5.0)
suds (0.4.1)
supervisor (3.0b2)
sympy (<IP_ADDRESS>)
system-service (0.1.6)
tables (3.1.1)
tensorflow (0.6.0)
termcolor (1.1.0)
Theano (0.7.0, /root/Theano)
tldextract (1.7.4)
tornado (3.1.1)
traitlets (4.1.0)
Twisted-Core (13.2.0)
Twisted-Web (13.2.0)
unittest2 (0.5.1)
unity-lens-photos (1.0)
urllib3 (1.7.1)
uTidylib (0.2)
vatnumber (1.1)
virtualenv (1.11.4)
vobject (0.8.1c)
Werkzeug (0.9.4)
wheel (0.24.0)
wsgiref (0.1.2)
WTForms (2.0.1)
xdiagnose (3.6.3build2)
xlrd (0.9.2)
xlwt (0.7.5)
zope.interface (4.0.5)
ZSI (2.1-a1)

and finally the tail of /var/log/digits/digits.log, which would seem to indicate the scheduler is not running
**2016-02-15 12:19:20 [20160215-121917-d3e0] [WARNING] Parse Folder (train/val/test): Reached maximum limit for this category
2016-02-15 12:25:19 [ERROR] Scheduler not running. Cannot add job.
2016-02-15 12:25:44 [ERROR] Scheduler not running. Cannot add job.
2016-02-15 12:29:07 [ERROR] Scheduler not running. Cannot add job.
2016-02-16 02:49:12 [20160215-121917-d3e0] [INFO ] Job deleted.
2016-02-16 02:49:57 [ERROR] Scheduler not running. Cannot add job.
2016-02-17 07:01:20 [ERROR] Scheduler not running. Cannot add job.
2016-02-17 07:01:42 [ERROR] Scheduler not running. Cannot add job.
2016-02-18 04:37:52 [ERROR] Scheduler not running. Cannot add job.
**

gevent (1.1rc3)

That looks problematic to me. I have 1.0:
$ pip list | grep -i gevent
gevent (1.0)
gevent-socketio (0.3.6)
gevent-websocket (0.9.3)

I assume that at some point you ran sudo pip install --upgrade gevent. Can you try rolling back to gevent==1.0?

Fixed with https://github.com/NVIDIA/DIGITS/pull/930 (and then addressed differently with https://github.com/NVIDIA/DIGITS/pull/965).

What was the fix?


Testing: Component vs Browser Testing (w/ Screenshot)

Info
We want to know how we're going to run our developer based cypress tests. Are we going to use Component level testing, or are we stuck with Browser based testing. And how do we add Screenshot testing to that mix
Acceptance Criteria:

Component Testing or Browser Based Testing?
How to integrate Snapshot testing. It looks like there are plugins for Cypress to take and compare screenshots (here)

On hold until we determine if this is even necessary


Windows.Media.Capture

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0ee7d59-98a5-f835-749d-12f9a0a24e98
Version Independent ID: 27299429-b6cb-18a5-ec69-86aac4d53d57
Content: AdvancedCapturedPhoto Class (Windows.Media.Capture) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.Media.Capture/AdvancedCapturedPhoto.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @drewbatgit
Microsoft Alias: drewbat

No comment was supplied by the user. Closing.


Lab2 - task 3 : │ Error: 500-InternalError, Out of host capacity.

Hi, I ran into a problem here.
I followed your steps, I have the trial credits, I tried the command ./start.sh again and everything but I got stuck on this and don't know what to do. Any advice?
thanks
...
oci_database_autonomous_database.adb: Still creating... [3m0s elapsed]
oci_database_autonomous_database.adb: Creation complete after 3m5s [id=ocid1.autonomousdatabase.oc1.eu-frankfurt-1.antheljteooaf4ial5bmjhf3ic45znvc7w5ikq4n54xca47fencxcw2ti4xa]
oci_database_autonomous_database_wallet.adb_wallet: Creating...
local_file.dotenv: Creating...
local_file.dotenv: Creation complete after 0s [id=24a0ea19396832ed775b454502d2b19edd722f4b]
oci_database_autonomous_database_wallet.adb_wallet: Creation complete after 2s [id=DatabaseAutonomousDatabaseWalletResource-1681269226]
local_file.adb_wallet_file: Creating...
local_file.adb_wallet_file: Creation complete after 0s [id=5657b075a203f264eb06a0663549adf09f223ed0]
╷
│ Error: 500-InternalError, Out of host capacity.
│ Suggestion: The service for this resource encountered an error. Please contact support for help with service: Core Instance
│ Documentation: https://registry.terraform.io/providers/oracle/oci/latest/docs/resources/core_instance
│ API Reference: https://docs.oracle.com/iaas/api/#/en/iaas/20160918/Instance/LaunchInstance
│ Request Target: POST https://iaas.eu-frankfurt-1.oraclecloud.com/20160918/instances
│ Provider version: 4.123.0, released on 2023-05-31. This provider is 26 Update(s) behind to current.
│ Service: Core Instance
│ Operation Name: LaunchInstance
│ OPC request ID: d124c98e0cc09aa9124e27787268a75c/F288580836EF93E408B398F9BE5E8B19/AC4826C1FF5DF8E72BDC7F91FA1EB0A9
│
│
│   with oci_core_instance.compute[0],
│   on compute.tf line 47, in resource "oci_core_instance" "compute":
│   47: resource "oci_core_instance" "compute" {
│
╵
╷
│ Error: 400-LimitExceeded, Your resource creation limit has been reached. To unblock resource creation, please upgrade to a Pay As You Go or Oracle Universal Credits account, or delete resources to restore your resource creation capability.
│ Suggestion: Request a service limit increase for this resource Datascience Notebook Session
│ Documentation: https://registry.terraform.io/providers/oracle/oci/latest/docs/resources/datascience_notebook_session
│ API Reference: https://docs.oracle.com/iaas/api/#/en/data-science/20190101/NotebookSession/CreateNotebookSession
│ Request Target: POST https://datascience.eu-frankfurt-1.oci.oraclecloud.com/20190101/notebookSessions
│ Provider version: 4.123.0, released on 2023-05-31. This provider is 26 Update(s) behind to current.
│ Service: Datascience Notebook Session
│ Operation Name: CreateNotebookSession
│ OPC request ID: 1be93626599bfc78c17ffdaa67701900/A5D6B8C6EF9ED3F9C7C50F854553675C/F343CC1BFE2417ED1A31520F24F8502E
│
│
│   with oci_datascience_notebook_session.lol_notebook_session,
│   on datascience.tf line 17, in resource "oci_datascience_notebook_session" "lol_notebook_session":
│   17: resource "oci_datascience_notebook_session" "lol_notebook_session" {

You’re not the first one that comes with this question! I determined that the issue is that you’re trying to allocate a VM Instance Shape that is currently out of host capacity in your OCI Region. May I ask, is your account Free Tier?
You can try in a different OCI region (subscribe to a new OCI region in your tenancy if your account is not free tier), or you can try to fiddle with the Terraform script to change the compute shape that you want to allocate, one that’s available for you in your region. This has worked very well for most people with this issue.

You’re not the first one that comes with this question! I determined that the issue is that you’re trying to allocate a VM Instance Shape that is currently out of host capacity in your OCI Region. May I ask, is your account Free Tier?
You can try in a different OCI region (subscribe to a new OCI region in your tenancy if your account is not free tier), or you can try to fiddle with the Terraform script to change the compute shape that you want to allocate, one that’s available for you in your region. This has worked very well for most people with this issue.

I chooses Frankfurt as OCI region, but now my free credits are spent. I didn't get further since and I did close my account.
But I hope this issue will help some others.
Thanks.


chore: Avoid re-render on project tree when select an item

Description
When select items on project tree, avoid re-rendering by reducing local state and useEffect.

Task Item
#minor

Screenshots
Before:

After:

Coverage decreased (-0.02%) to 55.079% when pulling e1af645f119d433c8158eb45d73aec1abe77ab29 on zhixzhan/pref-projecttree into ecf2df0e9966417e33abe76f5a0af4d68a4cebf9 on main.

Coverage decreased (-0.02%) to 55.079% when pulling e1af645f119d433c8158eb45d73aec1abe77ab29 on zhixzhan/pref-projecttree into ecf2df0e9966417e33abe76f5a0af4d68a4cebf9 on main.


Add tests for when the server 404's or 50X's when updating

I re-worked the first couple of tests in client_update_tests to cover more cases and moved them to the bottom of the file.
I also changed client so that:

we don't get an unexpected end of JSON error when the server errors while downloading a timestamp
we just use the cached timestamp now when the server 404's on getting a timestamp (previously, we used the cached timestamp when we got any other error than 404 - not sure we should default to cached if we do get a 404, but the behavior should probably be consistent for non-200 status codes)
warn users that we are using a stale timestamp file and hence may have a stale view of the repo, if we use the cached timestamp

Partially addresses #361.

Skimmed through the tests, they all seem to make sense. LGTM

I really like how you structured the test options and look forward to using them :)  LGTM!

LGTM


Implementing progress bar for uploading zip

Solving #840
Please provide me feedback for any improvements

Current coverage is 34.08% (diff: 100%)

Merging #934 into development will not change coverage

@@           development       #934   diff @@
=============================================
  Files                7          7
  Lines             1021       1021
  Methods            131        131
  Messages             0          0
  Branches           157        157
=============================================
  Hits               348        348
  Misses             673        673
  Partials             0          0

Powered by Codecov. Last update 384e6ca...ff24d17

@poush Thanks for the request. Could you deploy it on Heroku so we can test it, please?

Thanks @poush , Working perfect . Nice Work !!


translation

cleanup in

interfaces_bridge_edit.php
services_upnp.php
services_dhcpv6.php
interfaces_lagg_edit.php

This will be the last merge of translation cleanups before the 16.7 release. We don't want to risk introducing more problems and lowering the number of provided translations now. Let me know when this can be merged.
(Templates will be regenerated once more before 16.7 is out.)

@fichtner you can merge it - I can wait for the new template (my tool does not find many which are left)

Merged, thanks for all your work! :)


Textual change for donation account.

There is some Dummy text on Donation page, would need actual text.
Actual text: “Scan the bitcoin address QR or copy it in your wallet to send donation”

Need text on this section as well. @cakesoft-swati

@antuz123 Please suggest the text for above screen as well.

@cakesoft-utkarsh The text should be:
Our Supporters
Join the community by donating to the cause

Done.

Verified this issue on dev app v2.0(351)


Firebase Messaging iOS SDK v7.0 will no longer support the FCM Direct Channel API

Hi,
We recently received an email from the Firebase team stating that: Firebase Messaging iOS SDK version 7.0 will be a breaking change where the SDK will no longer support iOS Direct Channel API.
We are using this plugin for push notification for both android and iOs.  Will this plugin be impacted by this?

It won't for sure if you have updated the plugin for v5 or newer.
If you didn't, although not recommended, it might still work but version of Firebase SDK itself might behave strangely.


TURN connection loss after 10 minutes

When establishing the connection between two android phones via relay server (TURN), I observe that the connection is always lost after 10 minutes with SocketTimeoutException.
In know that the default lifetime of the relay connection is 10 minutes according to RFC5766 (https://tools.ietf.org/html/rfc5766 page 8). According to this specification the client sends refresh requests to the TURN server to keep the connection from getting closed.
Can it be that ice4j does not send these refresh messages to the server? Do I have to configure the Agent for that. Or what am I potentially doing wrong?

Tracing #199

Did you find a solution to this problem?

No, I switched to WebRTC : )

Switching to WebRTC wasn't an option for us as we're sending lots of packets at a size of 20 bytes and the DTLS enforced by WebRTC causes bandwidth to double.
Our solution was to manually call the refreshRequest function using reflection. This is quite hacky, but it works flawlessly for our purpose:
https://github.com/FAForever/java-ice-adapter/blob/master/ice-adapter/src/main/java/com/faforever/iceadapter/ice/PeerTurnRefreshModule.java#L70


[Website] Native setup page does not work

Steps to reproduce
Hi there, I've been trying to check the native setup page since yesterday but all I get is a 404 error. Could you please check if it's ok?
Link: https://patrol.leancode.co/native/setup
I got it from here, in the callout with the native setup info: https://patrol.leancode.co/ci/firebase-test-lab
Actual results
.
Logs

Logs
<!-- Replace this line with your logs. Do not remove the backticks! -->

Patrol version
.
Patrol Doctor output

Patrol Doctor output
<!-- Replace this line with your logs. Do not remove the backticks! -->

Flutter Doctor output

Flutter Doctor output
<!-- Replace this line with your logs. Do not remove the backticks! -->

Hi, looks like that link is broken.
This is the correct one: https://patrol.leancode.co/getting-started/native

Thank you for reporting this issue, probably the link changed and we forgot to update it. The page is now here: https://patrol.leancode.co/getting-started/native

Thanks a lot <3


Cite QIIME 2 instead of mothur?

From the last week's hackathon, I have a feeling that it'd be more relevant and fair to cite QIIME 2 instead of the legacy mothur.
(Or cite both, and then no OpenMS which perhaps isn't as crucial for µGalaxy)
Please disregard this PR if you disagree 😉

Good point. Thanks @matuskalas


Bluetooth: Opt ram for smp_null

Before:
│   └── smp_null.c                           232  0.73%
│       └── bt_smp_pool                      232  0.73%

After:
│   └── smp_null.c                           0    0.00%
│       └── bt_smp_pool                      0    0.00%

Signed-off-by: Lingao Meng<EMAIL_ADDRESS>

I'm not really enthused about adding a new API (even if it's internal) for a single user and only for the reason of saving a bit of memory overhead. Would it make sense to consider to consider redesigning all fixed channels to use something like this? You'd then at least have the CID in the struct in addition to the recv callback.

@jhedberg

Would it make sense to consider redesigning all fixed channels to use something like this?

https://github.com/zephyrproject-rtos/zephyr/pull/42281 Both have common parts, which can be saved in fixed CID


add start-group and end-group around php-config libs

don't be dependent on php not messing up when compiling the embed sapi

Oh good catch, I didn't touch the github actions.
But I have a question now, the dev-alpine.Dockerfile only builds php in zts mode with no extensions - can you use dynamically loaded extensions from package managers then (apt-get, rpm, etc)?

The dev-alpine.Dockerfile file is only intended for contributors/maintainers of FrankenPHP. It is totally internal. It just helps set up a dev environment with GDB and the like. working properly.
For general use of non-static builds, it's better to use Docker or Setup PHP builds (which can also installed using Homebrew etc, and provides a lot of extensions already compiled for ZTS). Documenting how to use Setup PHP with FrankenPHP is on my todolist.

LLD remembers the symbol table of archives that it has previously seen, so if there is a reference from an input file to the right of an archive, LLD will still search that archive for resolving any undefined references. This means that an archive only needs to be included once on the command line and the --start-group and --end-group options are redundant.

https://lld.llvm.org/ELF/warn_backrefs.html
Not needed on MacOS then.

Thank you very much @DubbleClick!


Diivoo WT03 can't turn on valve

This form is for reporting bugs.  If you have encountered a bug, you should
generally have some log messages or device diagnostics to show something is
going wrong.  If your problem is more of a question or a request for help,
then Discussions is
probably a more suitable venue.
Describe the bug
Diivoo WT03 single water timer not able to turn on valve, but can turn off.
This when I try it from HA

And this is what it looks like when I do it from either the app or the button on the actual device

It matches the ble_water_valve which I guess it might use the wrong trigger for turning on.
Expected behavior
Turn on the valve, from the looks, it seems like it should turn it to "manual" for on and "idle" for off
If the bug involves a device, then please include device diagnostics from
Settings / Devices & Services / Tuya Local (your device) / "1 device"
config_entry-tuya_local-9fbf5e54830e1734d6eac55776e5bd98.json
Please check if there are messages from Tuya Local in the Home
Assistant log (Settings / System / Logs), and include those too.
If applicable, add screenshots to help explain your problem.

There is nothing this integration can do about the behaviour of devices.
Perhaps though your connection settings are incorrect and you only have one way communication (incorrect device id can do this, and there are probably more possibilities with a hub involved).

This form is for reporting bugs. If you have encountered a bug, you should generally have some log messages or device diagnostics to show something is going wrong. If your problem is more of a question or a request for help, then Discussions is probably a more suitable venue.
Describe the bug Diivoo WT03 single water timer not able to turn on valve, but can turn off. This when I try it from HA  And this is what it looks like when I do it from either the app or the button on the actual device  It matches the ble_water_valve which I guess it might use the wrong trigger for turning on.
Expected behavior Turn on the valve, from the looks, it seems like it should turn it to "manual" for on and "idle" for off
If the bug involves a device, then please include device diagnostics from Settings / Devices & Services / Tuya Local (your device) / "1 device" config_entry-tuya_local-9fbf5e54830e1734d6eac55776e5bd98.json
Please check if there are messages from Tuya Local in the Home Assistant log (Settings / System / Logs), and include those too.
If applicable, add screenshots to help explain your problem.

Hi!
I'm try to configure the same device "WT-03" but i'm not so lucky...could you please share your settings?? DPs, etc...
Do you have the gateway?
Thanks!

This form is for reporting bugs. If you have encountered a bug, you should generally have some log messages or device diagnostics to show something is going wrong. If your problem is more of a question or a request for help, then Discussions is probably a more suitable venue.
Describe the bug Diivoo WT03 single water timer not able to turn on valve, but can turn off. This when I try it from HA  And this is what it looks like when I do it from either the app or the button on the actual device  It matches the ble_water_valve which I guess it might use the wrong trigger for turning on.
Expected behavior Turn on the valve, from the looks, it seems like it should turn it to "manual" for on and "idle" for off
If the bug involves a device, then please include device diagnostics from Settings / Devices & Services / Tuya Local (your device) / "1 device" config_entry-tuya_local-9fbf5e54830e1734d6eac55776e5bd98.json
Please check if there are messages from Tuya Local in the Home Assistant log (Settings / System / Logs), and include those too.
If applicable, add screenshots to help explain your problem.

Hi! I'm trying to configure the same device "WT-03" but i'm not so lucky...could you please share your settings?? DPs, etc... Do you have the gateway?
Thanks!

It will only work with the gateway, also you won't be able to turn it on, even with official tuya integration you can't.


Fix PE-D bugs in UG

This PR contains fixes for User Guide bugs found by testers during PE-D.
The following edits have been made to the UG

Correct prefix of ITEM_NAME in addi to i/ from the previous erroneous n/
#150

Edit example given under Features section of ug to:
"if the command specifies i/ITEM_NAME q/QUANTITY, q/QUANTITY i/ITEM_NAME is also acceptable"
#158

Add details to clarify marko restrictions

Add warning that an order marked as paid and/or delivered cannot be unmarked
#170
Add rationale for allowing marking as paid on insufficient stock but not marking as delivered
#182

Codecov Report

Merging #201 (6f2d785) into master (55060cf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     63.23%   63.23%
  Complexity      631      631
=========================================
  Files           105      105
  Lines          2388     2388
  Branches        307      307
=========================================
  Hits           1510     1510
  Misses          753      753
  Partials        125      125

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


make time series continuous

Currently when time series data has 0 values line charts do not properly, showing singular disparate dots intstead of lines.
Before

After

Can we get it merged? @RhysSullivan


mb_convert_encoding(): Illegal character encoding specified

When trying to use TwigView rendering, I got

mb_convert_encoding(): Illegal character encoding specified

in vendor/twig/twig/lib/Twig/Extension/Core.php:1137
Any idea what this is? It is a basic ascii template with simple variables.
	$data = [
		'name' => 'Foo',
		'namespace' => 'foo',
		'plugin' => 'cakephp-foo',
	];

	$this->renderer->set($data);

	$content = $this->renderer->generate('foo');

Sorry for the late response my github box got swamped due to automated dependency bumping. So are you using this for CakePHP 3 or the upcoming for 4? (Should fix it in both tbh.)

cake3

Cheers, looking into it tonight

You can easily reproduce it by commenting out 'encoding' => 'utf-8',
https://github.com/dereuromark/cakephp-dto/blob/master/tests/bootstrap.php#L32
and running the tests on that plugin.

@dereuromark sorry for the delay #101 is up to fix this

Tagged 4.3.8 with #101


TABL: Dump while uninstalling GTT

Demo repo
https://gitlab.com/christianguenter/test_gtt
GTT requires strict SQL syntax
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenddic_database_tables_gtt.htm

suggest that if IS_GTT is set, then skip the test/SELECT, as its probably okay to delete a temporary table without asking

Also, function DB_COUNT_DATA might be nice replacement for SQL logic to check if data is present.

yeah, IS_GTT is available since 750. Or we could catch the exception and set lv_no_ask = abap_true as quick fix.

I think catching the exception would be okay, just add a comment regarding GTT, so its possible to remember the scenario
Also suggest adding the scenario to https://github.com/abapGit-tests

DB_COUNT_DATA is a bit weird on my NW 752 SP04 dev system. I cannot open it and it looks inactive in object list. And a strange message appears.


init beta

initialize beta v0.1.0

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Feature bigfish

Finished the big fish event. The arrow indicator has yet to be implemented but the basis for it is present. <feature

The code looks clean and well-written to me, so merging can be done.

I argee with leon, code looks good. One remark though: playery should be renamed to playerY. It currently looks like a typo.


Plan to develop the 3D map engine？

Plan to develop the 3D map engine？ On the map, the right key can be dragged。  like  this  http://lbs.gaode.com/api/javascript-api/example/map/map3d

http://openlayers.org/ol-cesium/

Sorry       That's not the truth
You can change the visual angle, like a game, with a stereo.
http://lbs.gaode.com/api/javascript-api/guide/create-map/3d-map#show-3d-map

That is literally the 3d library receiving support...

#4802


Create multi-part tweaks

Some tweaks might require more than one type, for example:

An init.coffee tweak that adds a command
A keymap.cson tweak that adds a keybinding

As stated in the README, this project is no longer maintained and has been retired. Because of this, I am archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


fix(v2): fix theme validation for prism field and add tests

Motivation
This PR fixes #3209.
I have moved the validation for the prism field from live-code-block package to theme-classic package - this is the correct place to validate the prism field.
I have also added tests for themeConfig validation.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Automated tests have been added to check if:

prism field accepts valid keys like additionalLanguages.
themeConfig accepts valid fields

LGTM thanks


youtube-dl is broken

Basic info
To make sure that we are on the same page:

Kernel: Linux thinkpad 4.4.6 #1-NixOS SMP Wed Mar 16 15:43:17 UTC 2016 x86_64 GNU/Linux
System: 16.09pre79453.32b7b00 (Flounder)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: 16.09pre79453.32b7b00

Describe your issue here
$ nix-env -iA nixos.pypyPackages.youtube-dl
...
$ youtube-dl
Traceback (most recent call last):
  File "/nix/store/jdy43y0jhl0saq0vbimbvw1bgiks18zk-pypy4.0-youtube-dl-2016.01.01/bin/..youtube-dl-wrapped-wrapped", line 8, in <module>
    from youtube_dl import main
ImportError: No module named youtube_dl

cc @FRidh I guess #13124 is causing this

It can't be that. The only difference between buildPythonPackage and buildPythonApplication is that in the latter namePrefix is empty, instead of showing e.g. python3.5-.
Anyway, what is done there with youtube-dl is wrong. All Python libraries (and that includes /development/python-modules) should go via python-packages.nix. Python applications should not go via python-packages.nix.
Now that still doesn't explain your issue. In fact, youtube-dl does work with nix-shell
Try nix-shell -p pythonPackages.youtube-dl -I nixpkgs=. --run "youtube-dl" or any other pythonPackages set, and with -I nixpkgs=. checked out at unstable.
Obviously you want to use it as an application in which case it should work when you install it in your profile like you showed you did. Apparently there is something wrong with the wrapper.
Let's try installing it in the profile. We begin with
nix-env -iA nixos.pkgs.pythonPackages.youtube-dl -I nixpkgs=.
Again, I am using -I nixpkgs=. to use your version of NixOS/Nixpkgs.
I get now the following:
nix-env -iA nixos.pythonPackages.youtube-dl -I nixpkgs=.
installing ‘youtube-dl-2016.02.13’

Before I test, there is one important thing to notice. The name of my package is different.
While you are using NixOS Unstable, the channel that nix-env uses is an older version!
Now, youtube-dl does function in combination with CPython 2.7
$ youtube-dl
Usage: .youtube-dl-wrapped [OPTIONS] URL [URL...]

.youtube-dl-wrapped: error: You must provide at least one URL.
Type youtube-dl --help to see a list of all options.

However,
$ nix-env -iA nixos.pypyPackages.youtube-dl -I nixpkgs=.
replacing old ‘youtube-dl-2016.02.13’
installing ‘youtube-dl-2016.02.13’

gives
$ youtube-dl
Traceback (most recent call last):
  File "/nix/store/fnrx71ax877dn68qjsggrrhn77wh9c32-youtube-dl-2016.02.13/bin/..youtube-dl-wrapped-wrapped", line 8, in <module>
    from youtube_dl import main
ImportError: No module named youtube_dl

Somehow the wrapper only fails with pypy.

It is being wrapped twice. First, buildPythonApplication wraps it, and then it is wrapped again manually.

Alright haha, I just saw that you converted tons of packages and assumed you didn't try running all of them. :)
With nix-shell, it's working for me as well. So now downloading a youtube video is as simple as
nix-shell -p pythonPackages.youtube-dl --run "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt youtube-dl https://www.youtube.com/watch?v=77OlKRkaixo"

:grin:
Wrapping twice is bad, but why does it even use pypy if it works fine with cpython? It just increases the download size for most people.

Well I definitely didn't test all those packages when I made that change :-)
You chose to use the pypy in your bug report. You can use any python version.
We have to decide though...is this an application, or a library. Anyway, closing this.


[QUESTION]

Question
I just installed Dashy and I want to display the description of the items but I can not find any option for this, is it possible?
Category
Setup and Deployment
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this question hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Yeah, under appConfig set iconSize: large


CPPSDK: parameter/result handling for method and events + inner object handling

Handle parameters/result sections for method and callbacks based on templateDir passed
Handle Inner type inside object properties. For that introduced sub-property folder and keeps template for sub properties inside this folder. In CPP case need to handle sub property differently
Note: some templates already introduced in previous PRs anyOfSchemaShape/additionalProperties are already with these too, since this also comes under the parameter/result templates. will merge these only on top previous PR to ensure any change in these templates are in place

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/firebolt-openrpc/140/rdkcentral/firebolt-openrpc

Commit: b6767e3528da82ae8320576dd9360d652fdaff66

Report detail: gist

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-openrpc/140/rdkcentral/firebolt-openrpc

Commit: b6767e3528da82ae8320576dd9360d652fdaff66

Report detail: gist

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-openrpc/140/rdkcentral/firebolt-openrpc

Commit: 9babd2fa89a349e9121215d6192978af6e5619c3

Report detail: gist


Bugfix/875 rar oppforsel i filter i api delegering

Description
Related Issue(s)

#875
#861

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@allinox Sorry, I should have said something about it. The reason of the weird Kasse error was because there where duplicate keys in react. "Arbeids and velferdsetaten" and "Nav (Arbeids og velferdsetaten)" had the same key since they had the same org code. Duplicate keys in react causes unexpected errors and this was one of them (Seemed like everytime you searched for something "Arbeids and Velferdsetaten" was automatically added as a duplicate and also always displayed, maybe because it didn't actually exist but was just a duplicate). So duplicate keys caused more duplicate keys and so on so everytime you searched for something, more duplicate keys was added and more duplicate FilterOptions were added.

@Albertlarsen
Aha! That makes sense!
Thanks for the explanation and kudos for figuring it out! 🙌


update with sed to change -v flag for dsp driver

Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
A clear and concise description of the problem this proposed change will solve.
E.g. For this use case I ran into...
Describe your solution
A clear and concise description of what you have implemented.
Describe possible alternatives
A clear and concise description of alternative solutions or features you've considered.
Test data / coverage
How was it tested? What cases were covered? Logs uploaded to https://review.px4.io/ and screenshots of the important plot parts.
Additional context
Add any other related context or media.

Codecov Report

:exclamation: No coverage uploaded for pull request base (voxl-dev@5636914). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             voxl-dev      #11   +/-   ##
===========================================
  Coverage            ?   35.07%
===========================================
  Files               ?      720
  Lines               ?    56580
  Branches            ?        0
===========================================
  Hits                ?    19847
  Misses              ?    36733
  Partials            ?        0

Flag
Coverage Δ

unittests
35.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5636914...3162783. Read the comment docs.


Add a mod settings screen with convenient access to mod configuration

I often find myself going to the ModMenu list of modules, searching through the list to find a specific mod, just to press the configuration button for that mod. Some mods have hotkeys to go directly to their configuration screen, but it's hard to remember them all, and after a while, hotkeys tend to become a precious resource in modded Minecraft.
This PR is a response to that problem. A separate "Mod Settings" screen is created, with easy access from the in-game menu. This screen is a standard Minecraft scrollable options list, with a button for each mod with a configuration screen. The button takes the user directly to the mod's configuration screen. This creates a very integrated, "vanilla feel" experience for changing mod settings.
The way the "Mod Settings" button is added is a bit more complex than what I'd wished for. The core problem is that the current way of determining button placement and size would need a redesign. A single multi-value is supposed to determine both the placement of the title menu button and the in-game menu button. This makes options such as "Adjacent" behave quite weirdly (in the title menu it sits next to "Realms", in the in-game menu it replaces the "Report bug" button (much to my surprise!)
I tried to stay close to what I believe was the design intent of these placement heuristics, but I think a follow-up PR which clears up the button placement logic would be a good thing.
There is a separate configuration to enable/disable the "Mod Settings" button. (Note that the mod button placement heuristic must allow for the button to be displayed, otherwise it is not showing even if the configuration flag is true.

Screenshot of Mod Settings screen

Screenshot showing Mod Settings button in in-game menu.

This should be a separate mod.
To find mods that provide a Mod Menu compatible settings screen check ModMenu.java. To make sure that your mod runs after Mod Menu you can set the Mixin priority, Minimal Menu does this for their Screen mixin.
If you have any other questions feel free to post them here.

While the mod setting screen itself is easy to implement in a separate mod, unfortunately it will be harder to co-operate with Mod Menu for placement of the buttons in the in-game menu screen. :-(
But if this is your decision, I'll have to accept it.

Minimal Menu had the same problem and solved it for both the title screen and the game menu screen. The way it is set up guarantees that it runs after Mod Menu inserted the Mods button.


Payload-Lexical: link tooltip pops up on selecting a decorator node

Link to reproduction
No response
Describe the Bug
Upon selecting a custom Decorator node, the tooltip for LinkNode displays and positions itself next to the Decorator node.
This does not happen for plain text present in lexical.
The selection seen in the Link Editor plugin, for this scenario, is a NodeSelection. It bypasses the flow mentioned here and relies on window selection to display the tooltip.
https://github.com/payloadcms/payload/assets/114465851/8d2ff46d-4893-42e9-bc08-d1ff88ce8c6d
To Reproduce

Create a decorator node. This node should will not be editable.
Add a command to mark the node as selected if anywhere inside the node is clicked.
This should display the link tooltip below the decorator node.

Payload Version
2.11.2
Adapters and Plugins
@payloadcms/richtext-lexical: 0.7.0

Fixed this in #6241 - will be available in the next 3.0 release! Do note that this likely won't get backported to 2.0


Feature requested in issue #1468

1.Add endWithPreview element.
2.Adapt example to handle new prop.
3.Update documentation.

We updated PR after linter run with format fixings

It passes lint and tests. Feel free to squash commits. We got some hesitations.