debug_opt.h

Hi, I tried to run your project, but I didn't find the debug_opt.h.
#include "debug_opt.h"----blue_noise.cpp

Hi, I'm afraid that the project is not supported and some of the last pull requests I have approved from other user broke the build. :(
I am really sorry for that - and for not maintaining the project anymore. If you were to find the offending CL and propose a PR of rollback (or better - actually fix it...?), I'd be happy to accept it. Sorry for your trouble!


Sound not working?

Describe your bug here.
I opened Psych Engine 0.5 after using 0.4.2 for playing Psych Engine mods and making my own.
After I downloaded the compiled version from GameBanana, I extracted the file, opened it and the sound is not working at all. I made sure my volume wasn't muted or very low, I tested with headphones, and even compated it to 0.4.2. The sound doesn't show up.
I downloaded the 64-bit version, by the way. I tried with the 32-bit version and the same thing happens. I don't know if it happens with a manually compiled version though.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I tried putting other mods in such as Holiday Part I and some upcomming mods I'm making. I've also installed the 32-bit version.

Are you sure the volume is all the way up? Click +

huh, it worked
I dunno why it started mute.


doctrine:migrationgenerate does not detect change in projection without a clear cache

Yes, but that's a Flow bug, not a CQRS/ES bug.

Please raise a bug report in https://github.com/neos/flow-development-collection.


Functors are maps for categories

The central idea behind a functor is that it is a map between categories; for every arrow in the source category, the functor designates an arrow in the target category, such that identity and composition (the algebraic laws for categories) are preserved. This central idea isn't covered.

Oh, if I had concrete suggestions for improving wording, I would open a PR. I wouldn't do that to you, just opening issues without planning to eventually resolve them.
My main concern is that the given definitions of "category" and "functor" do not actually line up; we should expect that a "functor" is a map between "categories", but that is not the case. The underlying issue here (and in other issues I've opened) is that there are two situations where a category shows up in a programming context:

The category's objects are the types of the programming language, and the arrows are (total/partial/etc.) functions between types
The category's objects are the elements of some chosen type, and the arrows are merely skeletal (that is, the category mainly records whether there exists an arrow from one object to another, and not which arrow it might be)

There's no commonly-accepted jargon or nomenclature for this distinction. We might argue that the latter categories are "internal categories", and then by analogy we might call the former category the "external category" for a given language.
Then, the main problem is easy to state: the repo currently documents internal categories and external functors. Worse, the external functors are limited to endofunctors, but the limitation isn't justified.

I still think most of this is beyond the scope of this document.  The category-theoretical view is interesting, but I think it's mostly a distraction here.  However I'm mostly just a viewer here and not a core contributor; someone closer to the work may disagree.

Worse, the external functors are limited to endofunctors, but the limitation isn't justified.

That is absolutely true, and I think there should be examples of other functors.  Even str => str.length would help.

I almost regret putting "Category" in the document as it creates a desire to frame every definition in terms of it's mathematical background which (while interesting) makes it way harder to maintain the "explain like I'm five" form that we're going for.


Missing @id Values in EML Strategy Schema Objects

Description:
According to SOSO conventions, some schema objects in the EML strategy are missing @id values. This can lead to inconsistencies and difficulties in data processing.
For example, the identifier property of type Person in the soso.strategies.eml.convert_user_id function (line #595) is not assigned an @id value, but could be.
Other affected schema objects include:

Person/identifier
Organization/identifier
funding/MonetaryGrant
funder/Organization
Dataset

Proposed Solution:
Implement logic to ensure that all relevant schema objects within the EML strategy have @id values assigned.

Closed as completed.


StreamController.close docs don't describe the significance of the returned Future

the docs here say that close returns a Future (tangent: not sure why it's a Future instead of Future<void>), but don't say when it's supposed to complete.  that makes it hard to determine how to write tests that involve close.  should you await it?  what do you expect to happen after awaiting it?  what doesn't happen before you await it?

Docs where expanded in https://dart-review.googlesource.com/c/sdk/+/302101


Adding of multiple cursor not working properly

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:34:09.706Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

open-html-in-browser
cod
0.1.21

beautify
Hoo
1.1.1

cpptools
ms-
0.12.1

vscode-icons
rob
7.12.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

Multiple lines selection is not working in a proper way. The shortcuts shown in the command plate changes the orientation of the window it self to upside down. Please resolve this issue.

@sr08 What locale are you on? What does the keyboard shortcut editor show you?

This issue has been closed because it needs more information and has not had recent activity. Please refer to our guidelines for filing issues. Thank you for your contributions.


Added RONEC dataset.

Thanks for the PR @iliemihai .
Few comments -
Can you run -
python datasets-cli dummy_data ./datasets/ronec --auto_generate to generate dummy data.
Also, before committing files run :
make style
flake8 datasets
then you can add and commit files.

Awesome, good job @iliemihai !
I think the PR is ready to merge.
@lhoestq would you mind double-checking this ?

Had to regenerate the dummy data since I just found out they were empty files


change refs to avoid error

Description
interminttne update_tests failing due conflict with services
Fixes # (issue)
Type of change
What is it?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[X] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 46.66% // Head: 46.66% // No change to project coverage :thumbsup:

Coverage data is based on head (b7acbf2) compared to base (0d74849).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   46.66%   46.66%
=======================================
  Files          70       70
  Lines        9826     9826
=======================================
  Hits         4585     4585
  Misses       4788     4788
  Partials      453      453

Impacted Files
Coverage Δ

pkg/routes/readiness.go
100.00% <0.00%> (ø)

pkg/common/kafka/consumer.go
31.25% <0.00%> (ø)

pkg/services/devices/event_device_sync.go
100.00% <0.00%> (ø)

pkg/services/devices/event_inventory_sync.go
100.00% <0.00%> (ø)

pkg/services/update/event_update_repo_requested.go
87.50% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/retest

/retest

Merging with 1 approval. Asking for forgiveness later, if needed :)


Event Extensibility through hooks

Suppose we want to extend the ProfileService, but we don't want to recompile the source code and just use the existing docker image made from this repo. How can we extend functionality, like adding extra claims to the access token coming from an external service, without having to recompile?
Typically you would write a new class in C# to extend the ProfileService and recompile, like this example at SO.
Another IDP, like Auth0, however allows you to write javascript code that hooks into certain events. They called it rules. Could we do the same??
Given the documentation on webpack middleware, we can extend certain events just like Auth0 does with rules.
However the NodeServices package is mark obsolete in .NET 3.1 and will be removed in .NET 5.0. I see 2 alternatives for this

EdgeJS
Javascript.NodeJS

Both as .NET core compatible.
So, suppose we let the ProfileService look for existing javascript files on disk (mounted through a docker volume) and execute these, getting the result and apply that result. Another option would be to look for those scripts in the database (but then seeding would be a bit harder, it would require a UI and would pose a security risk involving injection). We could even do both in the long run if wanted.
If we were to create those js entrypoints (and that's just a couple) in various points in the service and provide javascript hook support there, we would have the same effect. We still use the same docker image, mount some extra javascript scripts in predefined folder and run the container. No need to recompile source code.
If we only rely on reading the script from disk only, the security risk is minimal as that's all service-side. Nothing is executed from the browser. We just do Javascript interop (switching languages momentarily on server-side). Letting them come from the database, requires more code and requires a UI to get them in there, but that can be added later.
I can see how you would want to extend this repo with your own functionality, but without having to fork or use the templates. Keeping those up to date is sometimes cumbersome if you only need a small change (like adding extra claims).
Is this something we want to pursue?

@bravecobra - thanks for your idea - I think it is really interesting - I will explore more details.


fix: Unreferenced web/resource-manager/Microsoft.Web examples

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?

Automation for azure-sdk-for-java


Demo App Issue: Blank Content + Runtime Errors

Describe the bug
Hello,
My team and I are very excited about the project you have put together. Certainly the community (both flutter and rust) will greatly benefit from your efforts -- genuinely, thank you.
One thing I did notice was the demo instructions do not seem to work out of the box (for web). I didn't spend much time troubleshooting, but I imagine anyone new to rust / this package would appreciate a working version.
The app bootstraps (but has a blank screen) with errors in the runtime logs.

Steps to reproduce
Followed the quickstart instructions:

flutter_rust_bridge_codegen create freshahead
flutter run

Logs
## From web dev tools
- localhost/:1 <meta name="apple-mobile-web-app-capable" content="yes"> is deprecated. Please include <meta name="mobile-web-app-capable" content="yes">
- _web.dart:27 Warning: Buffers cannot be shared due to missing cross-origin headers. Please refer to https://fzyzcjy.github.io/flutter_rust_bridge/manual/miscellaneous/web-cross-origin for details.
-localhost/:1 Refused to execute script from 'http://localhost:55395/pkg/rust_lib_freshahead_flutter.js' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

## From the console
Launching lib/main.dart on Chrome in debug mode...
Waiting for connection from debug service on Chrome...             10.8s
This app is linked to the debug service: ws://<IP_ADDRESS>:55467/Y6oWpadUmT4=/ws
Debug service listening on ws://<IP_ADDRESS>:55467/Y6oWpadUmT4=/ws

🔥  To hot restart changes while running, press "r" or "R".
For a more detailed help message, press "h". To quit, press "q".

A Dart VM Service on Chrome is available at: http://<IP_ADDRESS>:55467/Y6oWpadUmT4=
Warning: Buffers cannot be shared due to missing cross-origin headers. Please refer to https://fzyzcjy.github.io/flutter_rust_bridge/manual/miscellaneous/web-cross-origin for details.
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
Warning: Buffers cannot be shared due to missing cross-origin headers. Please refer to https://fzyzcjy.github.io/flutter_rust_bridge/manual/miscellaneous/web-cross-origin for details.
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html
A message on the flutter/lifecycle channel was discarded before it could be handled.
This happens when a plugin sends messages to the framework side before the framework has had an opportunity to register a listener. See the ChannelBuffers API documentation for details on how to configure the channel to expect
more messages, or to expect messages to get discarded:
  https://api.flutter.dev/flutter/dart-ui/ChannelBuffers-class.html

Expected behavior
No response
Generated binding code
No response
OS
MacOSflu
Version of flutter_rust_bridge_codegen
flutter_rust_bridge_codegen 2.7.0
Flutter info
[✓] Flutter (Channel stable, 3.24.5, on macOS 15.1.1 24B91 darwin-arm64, locale en-US)
    • Flutter version 3.24.5 on channel stable at /Users/tc.ferguson/.fvm/versions/3.24.5
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dec2ee5c1f (4 weeks ago), 2024-11-13 11:13:06 -0800
    • Engine revision a18df97ca5
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/tc.ferguson/Library/Android/sdk
    • Platform android-34, build-tools 33.0.0
    • Java binary at: /Users/tc.ferguson/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    ! iOS 18.1 Simulator not installed; this may be necessary for iOS and macOS development.
      To download and install the platform, open Xcode, select Xcode > Settings > Platforms,
      and click the GET button for the required platform.

      For more information, please visit:
        https://developer.apple.com/documentation/xcode/installing-additional-simulator-runtimes
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.2)
    • Android Studio at /Users/tc.ferguson/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] IntelliJ IDEA Ultimate Edition (version 2024.3.1)
    • IntelliJ at /Users/tc.ferguson/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 83.0.4
    • Dart plugin version 243.23177

[✓] VS Code (version 1.95.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.102.0

[✓] Connected device (2 available)
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 15.1.1 24B91 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 131.0.6778.140

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Version of clang++
Apple clang version 16.0.0 (clang-16<IP_ADDRESS>) Target: arm64-apple-darwin24.1.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Additional context
No response

Also a list of deps:
(same issue regardless of the initial deps vs after pub upgrade --major-versions)

direct dependencies: all up-to-date.

dev_dependencies: all up-to-date.

transitive dependencies:
async                         *2.11.0     *2.11.0     *2.11.0     2.12.0
characters                    *1.3.0      *1.3.0      *1.3.0      1.4.0
collection                    *1.18.0     *1.18.0     *1.18.0     1.19.1
material_color_utilities      *0.11.1     *0.11.1     *0.11.1     0.12.0
meta                          *1.15.0     *1.15.0     *1.15.0     1.16.0
path                          *1.9.0      *1.9.0      *1.9.0      1.9.1

transitive dev_dependencies:
boolean_selector              *2.1.1      *2.1.1      *2.1.1      2.1.2
clock                         *1.1.1      *1.1.1      *1.1.1      1.1.2
fake_async                    *1.3.1      *1.3.1      *1.3.1      1.3.2
file                          *7.0.0      *7.0.0      *7.0.0      7.0.1
leak_tracker                  *10.0.5     *10.0.5     *10.0.5     10.0.8
leak_tracker_flutter_testing  *3.0.5      *3.0.5      *3.0.5      3.0.9
lints                         *5.0.0      *5.0.0      *5.0.0      5.1.0
matcher                       *0.12.16+1  *0.12.16+1  *0.12.16+1  0.12.17
platform                      *3.1.5      *3.1.5      *3.1.5      3.1.6
process                       *5.0.2      *5.0.2      *5.0.2      5.0.3
source_span                   *1.10.0     *1.10.0     *1.10.0     1.10.1
stack_trace                   *1.11.1     *1.11.1     *1.11.1     1.12.0
string_scanner                *1.2.0      *1.2.0      *1.2.0      1.4.0
test_api                      *0.7.2      *0.7.2      *0.7.2      0.7.4
vm_service                    *14.2.5     *14.2.5     *14.2.5     15.0.0
webdriver                     *3.0.3      *3.0.3      *3.0.3      3.0.4
all dependencies are up-to-date.

Hi, thank you! Maybe try to add the headers as mentioned in quickstart page:

I totally missed the "Web" tab. Thank you for the guidance. Those steps made the difference.

You are welcome and happy to see it solved!


[Feature Request] ability to open output of individual steps

Is your feature request related to a problem? Please describe.
I wish it was easier to navigate directly to the log output of a step that failed.  Navigating large workflows on github.com is too slow so I installed this extension.  But it only lets me open the output of an entire job, and clicking or double clicking on individual steps doesn't navigate within the output.  On github.com I can at least expand and collapse the output of individual steps.
Describe the solution you'd like
I wish the tree nodes for individual steps had a View logs icon just like the nodes for jobs.
Additional context
More broadly, any kind ways to immediately open the output of steps that failed would save me time, whether on github.com, via the GitHub CLI, or via this extension.  I'm dealing with workflows with hundreds of jobs, and it's tedious scrolling through the jobs that passed to expand the ones that failed.

Hi @jedwards1211 :wave: - Thank you for the feature request!
If I recall correctly, the extension used to have something similar but we ended up removing it because it was difficult to get the "jump-to" linking to behave consistently. I think a good interim solution would be to have the logs open when the step is clicked on.

The PR has been completed and the fix will be available in our upcoming release v0.25.7, which planned for release May 5, 2023. Thanks so much for submitting great bugs and feedback to help make the extension even better!

The fix has been released and is available in v0.25.7 🎉 !

If you could view each step in vscode, it would be very convenient, similar to the following effect.


fix(PEAR-1653): capitalize facet aria labels

pear-1653
samples.days_to_collection

follow_ups.viral_hepatitis_serologies

Do we want to capitalize here or lowercase? Which do we normally do for aria-labels? I saw a bunch of lowercase ones at a glance, but maybe there are capitalized ones elsewhere.
any ideas - @amlehman / @paribartandhakal / @cemile-ctds ?
@bpierce01 -- you caught this via a test, right? what did the test expect?

It doesn't really matter if it's sentence case, camel case, or all lowercase – most screen readers will pronounce it the same way. However, it's best to avoid using all caps for the label because that can mess with the screen reader's voice inflection and might cause some words to be read as separate characters.


[CI] Update workflow usage of component_updater script

Notes for Reviewers
This PR updates the usage of component_updater scripts based on recent updates on the support for system flags and custom output paths.
Relates to: https://github.com/meshery/meshery/pull/8145 https://github.com/meshery/meshery/issues/8130
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

// @MUzairS15 @leecalcote


Add support for custom user agent

Twitter does not provide OG tags anymore if specified (Curl) user agent is used.

See https://twittercommunity.com/t/twitter-removed-opengraph-tags-from-server-rendered-tweet-page/138473/8


ParserException while compling files containing cyrillic comments

Hello! I get a error while trying to compile any scss file containing cyrillic comments. Example file:
main.scss.txt
Errors look like:
[Leafo\ScssPhp\Exception\ParserException]
parse error: failed at */  (stdin) on line 3 (0)
scssphp\src\Parser.php:120

It works for me. What php version are you running? If possible, please provide the output from php -i or phpinfo().

BTW you can use the command line script to test this, e.g.,
bin/pscss main.scss.txt

Can you see if 493e05a95431e0cbb3ed6cbca65e07e6e443e19e helps?

Nevermind.... I was able to duplicate it using:
php -dmbstring.func_overload=2 -dmbstring.internal_encoding=utf-8 vendor/bin/phunit

Thank you! You saved much time for many people!


[SPARK-5211][SQL]Restore HiveMetastoreTypes.toDataType

jira: https://issues.apache.org/jira/browse/SPARK-5211

Test build #25484 has started for   PR 4026 at commit 785cf61.

This patch merges cleanly.

LGTM

Test build #25486 has started for   PR 4026 at commit 153b6c0.

This patch merges cleanly.

Test build #25484 has finished for   PR 4026 at commit 785cf61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25484/
Test PASSed.

Test build #25486 has finished for   PR 4026 at commit 153b6c0.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
    val classServer                                   = new HttpServer(conf, outputDir, new SecurityManager(conf), classServerPort, "HTTP class server")
 case class QualifiedTableName(database: String, name: String)
case class CreateMetastoreDataSource(

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25486/
Test PASSed.

FYI this no longer merges ...

Test build #25553 has started for   PR 4026 at commit 15ee32b.

This patch merges cleanly.

Test build #25553 has finished for   PR 4026 at commit 15ee32b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25553/
Test PASSed.

Merging in master & branch-1.2. Thanks.


Deprecated GeometryCollections are not supported any longer. #389

Removes support for GeometryCollections, which already have been deprecated in 1.1.0.
Implements #389

Keeping this open until we have merged datacubes into draft-2.0. Afterwards, I need to update this branch and check again that no new GeometryCollections "sneaked in".


dart errors on css/html tab

@devoncarew @lukechurch
fix #98

Kasper! Welcome back.
I have one question about whether a line is necessary for this fix. If so, lgtm!
I'll address the failing saucelabs/webdriver test separately - it's not related to this PR.

Kasper!


OCI Config not found issue

I am using Windows Subsystem for Linux . I got the "** OCI Config was not found here : ~/.oci/config or env varibles missing, aborting **" error.
My cis_reports.py, config file, oci public key, private key & fingerprint is located in echo$Home.
Plz help

The script by default uses the DEFAULT profile from the ~/.oci/config file. The easiest thing to do is create a .oci directory in your home directory then copy your config file there.  Make sure your config file looks like the below and the path to the API Key is correct.
[DEFAULT]
tenancy=<tenancy_ocid>
region=us-ashburn-1
user=<user_ocid>
fingerprint=<api_key_finger_print>
key_file=/path_to_my_private_key_file.pem

Hi  Josh ,
I have created .oci directory in home directory & copied all the files
there.
Still I got the same error message.
Please refer to the screenshot below.
On Sun, Apr 25, 2021 at 1:43 AM Josh Hammer @.***>
wrote:

The script by default uses the DEFAULT profile from the ~/.oci/config
file. The easiest thing to do is create a .oci directory in your home
directory then copy your config file there. Make sure your config file
looks like the below and the path to the API Key is correct.
[DEFAULT]
tenancy=<tenancy_ocid>
region=us-ashburn-1
user=<user_ocid>
fingerprint=<api_key_finger_print>
key_file=/path_to_my_private_key_file.pem
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oracle-quickstart/oci-cis-landingzone-quickstart/issues/14#issuecomment-826147403,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJUCBYFLLBB4IBF7M66FD7DTKMQ6HANCNFSM43QK3M3A
.

Would you try to install  the oci cli in your WSL to test your ~/.oci configuration.  Here are the directions I used the Linux directions for my WSL environment. I have successfully run the script from my WSL environment please see the output below:
(python-venv) hammer@DESKTOP-BKHQ31S:~$ pwd
/home/hammer
(python-venv) hammer@DESKTOP-BKHQ31S:~$ ls
2021-04-27  cis_reports.py  python-venv
(python-venv) hammer@DESKTOP-BKHQ31S:~$ ls ~/.oci/
config  oci_api_key.pem
(python-venv) hammer@DESKTOP-BKHQ31S:~$ python3 cis_reports.py

##########################################################################################
#                                 Running CIS Reports...                                 #
##########################################################################################
Written by Josh Hammer & Andre Correa, updated April 22, 2021.
Starts at 2021-04-29 17:39:03

##########################################################################################
#                  Processing Tenancy Data for orasenatdpltsecitom01...                  #
##########################################################################################
Processing Compartments...
Processing Cloud Guard Configuration...
Processing Vaults and Keys...
Processing Audit Configuration...
Processing Tenancy Password Policy...
Processing IAM Policies in root...

if you are using a passphrase with your private key then the issue may happen. if this is the case add the pass_phrase parameter.
tenancy=XXXXXXXXXX
region=XX
user=XXXXXXXXXXXXXXX
fingerprint=XXXXXXXXXX
key_file=/home/oracle/.oci/oci_api_key.pem
pass_phrase=Passphrase

@Harish2892 I am also getting the same error, let me know the solution if resolved.


Github Dorks in process stuck

There is a bug in the tool [gitdorks_go] (https://github.com/damit5/gitdorks_go)
Here is the error: Error: https://docs.github.com/v3/search/; We have to wait 20 seconds
this error cause the recon process to stuck for a day at this phase (Github Dorks in process) and I discovered the error after debugging
Anyway, I reported a problem to the tool owner, so after fixing the problem, I think there should be an update for the old users to update the framework to get the gitdorks_go tool update

Ok, I will close this issue, issue continues here https://github.com/damit5/gitdorks_go/issues/1


bot commands do not work in DMChannel

The addition to discord.js requiring Intents to be declared has broken the bot's functionality in DMChannels.

Solution: use the CHANNEL partial. Needs testing on if this messes up anything else.
https://discordjs.guide/popular-topics/partials.html#enabling-partials

Closed - No longer relevant with the introduction of Slash commands, bot has been rewritten to not have message viewing intents.


Change Contact component for version with icons

As part of the visual stories pages, we offered up a new version of the contact card, with icons, under the same toggle.
This could be officialised across the website separately from visual stories. It has been tweaked and reviewed (see #10102), just waiting on final decision to officialise and remove the older version from the codebase.
Slack convo

Now in production


Disable or customize finishNavigation pop/slider

Hello,
Is there a way to either disable or customize pop that comes at destination? Screenshot below:

Thanks
Rahul

Stale issue message

Can use the following but only supported for iOS now:
  /// In iOS this will show/hide the feedback button. Default to True.
  bool? showReportFeedbackButton;

  /// In iOS this will show/hide the end of route page when navigation is done. Default to True.
  bool? showEndOfRouteFeedback;


[sail] Update to 0.9.0-pre21

Describe the pull request
Numerous improvements in the upstream.

What does your PR fix?

-

Which triplets are supported/not supported? Have you updated the CI baseline?
Same

Does your PR follow the maintainer guide?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@JonLiu1993 Regarding the pre-release state.
Too many ideas to implement 😃 A half of them break compatibility, and I want to maintain backwards compatibility in the future. I hope a first release will be roll out till summer.

Thanks @HappySeaFox :)


PMP pull documentation

A basic README file in the repo to explain how to use the functionality of this phase 1 "PMP Pull".

Looks good.


Cupy dose not working on ubuntu 18.04

Conditions (you can just paste the output of python -c 'import cupy; cupy.show_config()')

CuPy version 7.0.0
OS/Platform Ubuntu 18.04
CUDA version 9.0
cuDNN/NCCL version 7.6.5 (for cuda 9.0)
GPU NVIDIA GTX580
Driver version 390.116

Code 1:
import cupy as cp
x = cp.arange(6).reshape(2, 3).astype('f')

Error msg 1:
NVRTC compilation error: nvrtc: error: invalid value for --gpu-architecture (-arch)

-----
Name:
Options: -I/home/liu/.local/lib/python2.7/site-packages/cupy/core/include -I /usr/local/cuda-9.0/include -ftz=true -arch=compute_20
CUDA source:
1
-----
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/liu/.local/lib/python2.7/site-packages/cupy/creation/ranges.py", line 57, in arange
    _arange_ufunc(typ(start), typ(step), ret, dtype=dtype)
  File "cupy/core/_kernel.pyx", line 864, in cupy.core._kernel.ufunc.__call__
  File "cupy/core/_kernel.pyx", line 876, in cupy.core._kernel.ufunc._get_ufunc_kernel
  File "cupy/core/_kernel.pyx", line 638, in cupy.core._kernel._get_ufunc_kernel
  File "cupy/core/_kernel.pyx", line 60, in cupy.core._kernel._get_simple_elementwise_kernel
  File "cupy/core/carray.pxi", line 166, in cupy.core.core.compile_with_cache
  File "/home/liu/.local/lib/python2.7/site-packages/cupy/cuda/compiler.py", line 136, in compile_with_cache
    base = _preprocess('', options, arch)
  File "/home/liu/.local/lib/python2.7/site-packages/cupy/cuda/compiler.py", line 97, in _preprocess
    result = prog.compile(options)
  File "/home/liu/.local/lib/python2.7/site-packages/cupy/cuda/compiler.py", line 250, in compile
    raise CompileException(log, self.src, self.name, options)
cupy.cuda.compiler.CompileException: nvrtc: error: invalid value for --gpu-architecture (-arch)

Code 2:
import cupy as cp
cp.random.random_sample(10)

Error msg 2:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/liu/.local/lib/python3.6/site-packages/cupy/random/sample.py", line 161, in random_sample
    return rs.random_sample(size=size, dtype=dtype)
  File "/home/liu/.local/lib/python3.6/site-packages/cupy/random/generator.py", line 540, in random_sample
    out = self._random_sample_raw(size, dtype)
  File "/home/liu/.local/lib/python3.6/site-packages/cupy/random/generator.py", line 528, in _random_sample_raw
    func(self._generator, out.data.ptr, out.size)
  File "cupy/cuda/curand.pyx", line 158, in cupy.cuda.curand.generateUniformDouble
  File "cupy/cuda/curand.pyx", line 162, in cupy.cuda.curand.generateUniformDouble
  File "cupy/cuda/curand.pyx", line 86, in cupy.cuda.curand.check_status
cupy.cuda.curand.CURANDError: CURAND_STATUS_LAUNCH_FAILURE

It seems answered in https://stackoverflow.com/questions/59451428.


Solr sync and other things

I didn't have push rights to the repo so I had to fork. This syncs the solr configs and does a few other helpful things.
@cam156

@awead did you check with @informaticianme to get the Solr version he is using for CHO?

@cam156 yep, we're good!


Are the right side magic methods supposed to work?

I'm not sure if this is a bug report or a feature request, but as of cython 0.27.3 __radd__, __rtruediv__ and other right side magic methods do not work:
In [1]: %load_ext Cython

In [2]: %%cython
   ...: cdef class Example:
   ...:   def __radd__(self, other):
   ...:     print('radd', self, other)
   ...:   def __rtruediv__(self, other):
   ...:     print('rtruediv', self, other)
   ...:

In [3]: 3 + Example()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-3-b54d8dd2451f> in <module>()
----> 1 3 + Example()

TypeError: unsupported operand type(s) for +: 'int' and '_cython_magic_c1fde2d95cc29b87ed98f696ccfef975.Example'

In [4]: 'foo' / Example()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-1e29a35d9b28> in <module>()
----> 1 'foo' / Example()

TypeError: unsupported operand type(s) for /: 'str' and '_cython_magic_c1fde2d95cc29b87ed98f696ccfef975.Example'

In [5]: import Cython

In [6]: Cython.__version__
Out[6]: '0.27.3'

I'm using the following workaround, but it looks ugly:
In [7]: %%cython
   ...: cdef class Example:
   ...:   def __add__(other, self):
   ...:     print('add', self, other)
   ...:   def __truediv__(other, self):
   ...:     print('truediv', self, other)
   ...:

In [8]: 3 + Example()
add <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109d7a0f0> 3

In [9]: 'foo' / Example()
truediv <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109d7a110> foo

and doesn't really work if we switch operands:
In [10]: Example() + 3
add 3 <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109d7a110>

In [11]: Example() / 'foo'
truediv foo <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109468e60>

I'm not familiar with cython codebase, but a quick search through the source, issues and PRs doesn't show anything related.

Cython's special methods still mostly reflect the C API rather than the
Python API. See
http://cython.readthedocs.io/en/latest/src/userguide/special_methods.html#arithmetic-methods
. Here either the first or second parameter may be self, rather than having
rxxx versions of the operators. (It would be nice to support this
however, similar to how the comparison methods were recently added.)
On Thu, Dec 28, 2017 at 3:14 AM, Dmitry Malinovsky<EMAIL_ADDRESS>
wrote:

I'm not sure if this is a bug report or a feature request, but as of
cython 0.27.3 radd, rtruediv and other right side magic methods
do not work:
In [1]: %load_ext Cython
In [2]: %%cython
...: cdef class Example:
...:   def radd(self, other):
...:     print('radd', self, other)
...:   def rtruediv(self, other):
...:     print('rtruediv', self, other)
...:
In [3]: 3 + Example()---------------------------------------------------------------------------TypeError                                 Traceback (most recent call last) in ()----> 1 3 + Example()
TypeError: unsupported operand type(s) for +: 'int' and '_cython_magic_c1fde2d95cc29b87ed98f696ccfef975.Example'
In [4]: 'foo' / Example()---------------------------------------------------------------------------TypeError                                 Traceback (most recent call last) in ()----> 1 'foo' / Example()
TypeError: unsupported operand type(s) for /: 'str' and '_cython_magic_c1fde2d95cc29b87ed98f696ccfef975.Example'
In [5]: import Cython
In [6]: Cython.version
Out[6]: '0.27.3'
I'm using the following workaround, but it looks ugly:
In [7]: %%cython
...: cdef class Example:
...:   def add(other, self):
...:     print('add', self, other)
...:   def truediv(other, self):
...:     print('truediv', self, other)
...:
In [8]: 3 + Example()
add <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109d7a0f0> 3
In [9]: 'foo' / Example()
truediv <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109d7a110> foo
and doesn't really work if we switch operands:
In [10]: Example() + 3
add 3 <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109d7a110>
In [11]: Example() / 'foo'
truediv foo <_cython_magic_45c6eacd188f8181199b3c76f32cba5d.Example object at 0x109468e60>
I'm not familiar with cython codebase, but a quick search through the
source, issues and PRs doesn't show anything related.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cython/cython/issues/2056, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdqgcvFpRoV1V5VQmmG1gnKEIwYNzK5ks5tE3gWgaJpZM4ROO6o
.

We should consider whether we want to move away from the "first or second argument is self" for the arithmetic methods for 3.0.

I think we should switch to normal Python semantics. As @robertwb said, in the same way as we support the comparison methods now.

See generate_richcmp_function() in ModuleNode.py together with the RichcmpSlot in TypeSlots.py.
The idea is to define the number slots with a new slot type BinopSlot that has two special Python methods as implementation, and then generate the nb_add etc. slots by dispatching to these methods (more precisely, their C functions) according to CPython's own logic in typeobject.c.

Marking as Cython 3.0 release blocker, in case we need backwards incompatible changes for this.

The test failure in #3644 (in unicode_formatting.pyx) shows that changing default semantics will definitely break code. Potentially a lot of it since existing code bases could only implement the left-side operator and are now left without the right-side operator support (even in the case where the right-side operator support was the only thing they actually wanted).
Do we really want to implement such a hard break? Is there a way we could mitigate the impact? Such as some kind of hybrid behaviour that would become the default instead of full Python semantics, maybe only if the right-side method is not implemented?

I would really like to unify the Python and Cython semantics here, rather than have our own thing (even if it's a step closer). One can get the old behavior with a directive; perhaps we could add a third option. Alternatively, we could introduce a warning (maybe this is a reason to backport to 0.29) about this change in behavior. The upside is the fix is really easy. (I would assume that people are expecting to take care when upgrading to 3.0, we should provide advice on how to do that, especially with defaults like this that change.)

I think a warning in 0.29 is a good idea, when users implement __add__ but not __radd__. They can do this in a backwards compatible way, by making __add__ support both directions and __radd__ only the reverse direction (which 0.29 will ignore then).

I would really like to unify the Python and Cython semantics here, rather than have our own thing

What do you find still missing?

I think a warning in 0.29 is a good idea, when users implement __add__ but not __radd__. They can do this in a backwards compatible way, by making __add__ support both directions and __radd__ only the reverse direction (which 0.29 will ignore then).

That's a good idea.

I would really like to unify the Python and Cython semantics here, rather than have our own thing

What do you find still missing?

I'm saying want to avoid re-introducing different behavior for cdef classes than for "normal" classes when a user implements __add__ but not __radd__.

I added a warning in ec99487becc3a4a4f3bbd83be0bc31f027c8e11e and also updated the documentation.

BTW, I think we do not assign the type of the self argument correctly yet, do we? That seems not so easy to change based on a directive, since the slot signatures are built statically.


⚠ Build step unable to load Maven meta-data from Sonatype url

Describe the bug
Our Expo builds are failing with the following error message:
> Configure project :react-native-reanimated
Android gradle plugin: 8.2.1
Gradle: 8.8
FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':app:buildReleasePreBundle'.
> Could not resolve all dependencies for configuration ':app:releaseRuntimeClasspath'.
   > Could not resolve com.stripe:stripe-android:20.52.+.
     Required by:
         project :app > project :stripe_stripe-react-native
      > Failed to list versions for com.stripe:stripe-android.
> Unable to load Maven meta-data from https://oss.sonatype.org/content/repositories/snapshots/com/stripe/stripe-android/maven-metadata.xml.
            > Could not GET 'https://oss.sonatype.org/content/repositories/snapshots/com/stripe/stripe-android/maven-metadata.xml'. Received status code 504 from server: Gateway Time-out
> There is 1 more failure with an identical cause.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
BUILD FAILED in 2m 42s
20 actionable tasks: 20 executed
Error: Gradle build failed with unknown error. See logs for the "Run gradlew" phase for more information.

To Reproduce
 When visited directly, the URL does indeed 404
Expected behavior
The URL should point to a valid resource.
Additional context
I understand this is likely a sonatype issue, I am looking in to how to report this issue to them as well.

Looks like it's back up, as I was able to build a few minutes ago without


fix:  heapify() function does not work  in heap_sort.cpp

fix bug:  heapify() function does not work, during heap sort;
solve c++ build error.
@ericcurtin Eric Curtin
pls review.

I must fix it here too when this gets through:
https://github.com/TheAlgorithms/C/pull/508

thank you very much。

a possible duplicate of #873

OK i will check it on the latest version.
To make sure the bug fixed

a possible duplicate of #873
@ayaankhan98 and @liushubin-gitHub , referencing the bug issue number in the pull-request descriptions could help us avoid such conflicts. Hence, we have the checkmark in the pull-request description. Please use it and not not delete the template. This pull-request did not use the description template.

=======================================
I checkout the latest  code , and test ok.

Since the heap sort works well in the latest code.  (Although the modifications are different from this pull request)
As the bug has fixed , so close it.


Crafting upgrades not working

My exporter exports items from my Refined Storage system into an inventory even though it has a crafting upgrade.
The thing is, it stops exporting if I enable “Craft-only mode” in the exporter, but then, I don’t need a crafting upgrade. I am extremely confused right now.

Minecraft version: 1.12.2
Forge version: <IP_ADDRESS>1
Refined Storage version: 1.5.23

Crafting upgrade is upgrade that will do as followed for example:
You have Mekanism's Metallurgic Infuser in which you need redstone or those redstone plate-ish things.

Now... If you would export only redstone you would just need exporter set with redstone.

If you would need to export those redstone plates and you don't have any in your system, you will create recipe. Then you take redstone plate and crafting upgrade and set it into the exporter.
What will that do, if machine can accept another redstone plate, RF will craft it and export it right away.

Out of my head cannot come with this Crafting only button usage. But as far as you put it, you don't really need it.

Yeah, that makes sense. Thanks.
I haven’t played modded Minecraft in a while. I realize I used the crafting upgrade incorrectly.
That said, I really want to know what the “Craft-only mode” button does. If it does the same thing as the crafting upgrade, what’s the point of the crafting upgrade? I don’t think it does the same thing as the crafting upgrade, though. For some reason, it stopped exporting items from my system once I enabled “Craft-only mode.”
Does it mean that the exporter will only function if the items are used in a crafting recipe?
@raoulvdberge

Craft-only will only exported newly crafted items, not using any previous items from storage.

How does the mod determine which items were newly crafted, and what are the uses of this option?

See #132.
I removed the craft-only option for 1.5.24 because it was implemented in a buggy way.


update #499 - adds comments to user profile

Closing this to submit backend & frontend logic separately under branch 499 (backend) & 499/comments (subbranch)


Proper Examples of Diarization

I managed to make diarization work with the Python client using the below code.
# Set up an offline/batch recognition request
config = riva.client.RecognitionConfig(enable_word_time_offsets=True)
riva.client.add_speaker_diarization_to_config(config, True)

#req.config.encoding = ra.AudioEncoding.LINEAR_PCM    # Audio encoding can be detected from wav
#req.config.sample_rate_hertz = 0                     # Sample rate can be detected from wav and resampled if needed
config.language_code = "en-US"                    # Language code of the audio clip
config.max_alternatives = 1                       # How many top-N hypotheses to return
config.enable_automatic_punctuation = True        # Add punctuation when end of VAD detected
config.audio_channel_count = 1                    # Mono channel

However, some of the items in the words output don't contain a speaker label. Furthermore, there is no punctuation or capitalization in the words output.

Can we get a proper notebook/example of how to use diarization, including how to get a diarized, punctuated, and capitalized transcript back?

Yes, we will be adding a tutorial / example for diarization in the future.
I'm not sure why with your example audio the first couple of words aren't getting assigned a speaker, but the fact that the speaker_tag field is missing is because the value is the default (0) which is not printed by default by protobuf.  The zero indicates diarization do not assign the word a speaker.
Currently Riva does not punctuate or capitalize the individual word output.  We plan to fix that in the future.

This is in progress.


[util] Rejig how we load hjson configurations for dvsim.py

The main new feature from this patch is that a dvsim configuration
should now set a dvsim_cfg_type value. This value is used to decide
which subclass of FlowCfg to construct (in CfgFactory.py).
There are two upsides to this:

You can now run a lint or synthesis run without specifying the
tool on the command line (before, the code made a SimCfg unless
it recognised the tool).

If you run dvsim.py on some other random hjson file, you get a
somewhat helpful error message. Before, you'd get something
cryptic about expanding verbosity flags.

There is also a downside:

Every configuration needs to specify dvsim_cfg_type. In practice,
this isn't so bad, because this can be done in the included
common_*_cfg.hjson.

Note that "every configuration" here includes primary configurations.
This is kind of silly, because a "primary configuration" is really
just a list of other things to run. In later patches, we can split
these out into their own type, which should clean up quite a lot of
the code, and get rid of this requirement. However, you can't do that
splitting without the change in this patch (I tried!), so I've done
this patch first.
To make sense of how this all works:

dvsim.py calls CfgFactory.make_config

This uses CfgJson.load_hjson to load an hjson file and everything
it includes.

After loading the file, make_config looks at dvsim_cfg_type (which
must have a value) to decide which subclass of FlowCfg to
instantiate.

The constructor for FlowCfg gets passed hjson_data. It sets up
a whole list of attributes, then calls self._merge_hjson to merge
the data from hjson_data into itself. It then calls self._expand
to expand all the wildcards. Subclasses can hook in to these two
methods if they need things to happen at specific times.

The only slight complication is from primary configs: configurations
that have a list of children to be loaded and run. These need to load
up some new hjson files. They can do so by calling back to the
factory (passed in as an argument to avoid circular dependencies).

@cindychip, @msfschaffner: While I have tried to run various synthesis / fpv flows (with the -n flag, because I don't have access to dc or jaspergold), I'd be very surprised if I haven't broken at least something. Would you mind either running the flows you use with dvsim or sending me a list of commands to try out locally, to make sure nothing comes unstuck?

Hmm, looks like there's some fixes that I can do locally to get this through CI. Rather than spamming everyone, I'll mark this as draft again for now.

That went better than I expected :-)

I just ran a set of FPV regression and they are running as expected. Thanks for the implementation Rupert. I will take a detailed look at the code soon.

Thanks Cindy and Michael for having a look at this. Good point about the quotes: I'll push up a fix with them in a second.

Force-push rebases onto master. No other change.

@sriyerg could you review this when you have time. its been sitting here for a while!

Force-push rebases onto master (it conflicted with my recent verbosity changes and, trivially, with a path change in one config file).

Force-push rebases onto master. No other change.

Force-push rebases onto master (over a conflicting PR which was merged recently)

Force-push rebases onto master. No other change.

Force-push rebases onto master (past some dvsim changes, so it's not completely trivial). No other change.

Force-push rebases onto master (past some conflicting dvsim changes). No other change.

Force-push is a weekly rebase. No other change.

Thanks for the reviews, Sri!

Force-push is a rebase that should (hopefully) fix CI.


Generate ViewStateProvider for presenters in nested classes

Currently, moxy compiler doesn't generate correct ViewStateProvider classes for nested presenters, which leads to a NPE at runtime when trying to access view state.
By "nested" I mean defined in an interface or another class:
class SomeClass {
    class MainPresenter : MvpPresenter<MainView>() {
        ...
    }
}

or
interface SomeInterface {
    class MainPresenter : MvpPresenter<MainView>() {
        ...
    }
}

We can easily fix this by taking into account enclosing classes.
The proposed solution doesn't break anything and works for both nested and non-nested presenters.

Hi Alexey!

You should add a unit test for the new feature you're proposing

Will do.

Why did you delete MainPresnter.kt?

Sorry, I was experimenting and I deleted it by accident :) I'll bring it back.


Proof of concept: GraphQL spec

I'm not actually sure how useful this is. Output of that command is in dociql
./node_modules/dociql/bin/dociql.js -d dociql.yml -H "Authorization: Bearer $TOKEN" -d -t dociql

It might actually be a nicer way of documenting the cookbook, which ensures working queries, but the spec itself is pretty unreadable. Maybe that was always going to be the case with a non trivial schema?

Ooh, maybe the example on the right in that screenshot is actually broken?

And another generator https://github.com/2fd/graphdoc

Hi @plaindocs I've created a draft PR building our own templating for GraphQL API reference Docs https://github.com/buildkite/docs/pull/1641

This PR has been very much superseded.


OpenAIChatCompletion result is not connecting to GrabText node

I opened the "Example - NodeJS Agent" and tried to change default "OllamaChatCompletion" to use openai one instead, but when I was able to connect "system message" and "message (array)" the result one is not working.
I then changed to "LMStudioChatCompletion" which worked flawlessly.
omnichain-openaichatcompletion.webm
I also tried to use an intermediate node but without luck.
No errors on browser or in the console.

Of course it doesn't. The OpenAI nodes output arrays. That connection requires a single string.

Ah got it. With that I was able to connect

Maybe would be good to change the text in the UI to "result (array)" or similar?
Thanks for the help!

Closign the issue as it was resolved, thanks @zenoverflow !


Passwd and sshkeys always be coverd by qume-guest-agent

What happened:
create vm with passwd and sshkey secret
          accessCredentials:
          - sshPublicKey:
              source:
                secret:
                  secretName: my-pub-key
              propagationMethod:
                qemuGuestAgent:
                  users:
                  - "fedora"
                  - "root"
          - userPassword:
              source:
                secret:
                  secretName: my-user-pass
              propagationMethod:
                qemuGuestAgent: {}

then change passwd in vm；after seconds，passwd and sshkey be coverd by qemu-guest-agent
What you expected to happen:
Don't set passwd or sshkey when secret not changed
Environment:

KubeVirt version (use virtctl version): release-0.51

I have resloved this issue, the passwd or sshkey will force a resync of changes every 5 minutes.
https://github.com/kubevirt/kubevirt/blob/c428c980bdb2f44a5e5001dc834d7c93cd71c9aa/pkg/virt-launcher/virtwrap/access-credentials/access_credentials.go#L428-L437


Added metadata URL and token issuer

Fixes #911

Docs Build status updates of commit 9bf7fd5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/security-requirements.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Prevent column from next row to stack on the right if it has the space to do so

See the following screenshot: this is what we want to prevent.

Fixed by adding class "row" and setting "margin-left: 0" on class "dashboard-row"


Add/sama5d3 xplained

This patch support for sama5d3-xplained  board https://www.microchip.com/DevelopmentTools/ProductDetails/ATSAMA5D3-XPLD

Looks good. Thanks!


Document highlighting does not work

After c4bfcabd6464e797edcd296f17672ef3d6bbc27f, document highlighting stops working.
Before:

Now:

The following code seems not working. Put the cursor on sum(see pictures above) and execute :lua nav_doc_hl(), there is no highlighting at all, but execute :lua vim.lsp.buf.document_highlight() directly, everything goes well.
https://github.com/ray-x/navigator.lua/blob/c4bfcabd6464e797edcd296f17672ef3d6bbc27f/lua/navigator/dochighlight.lua#L203-L210

I can confirm it has been fixed by 36c01adc2d537e7803a585f9417115dd5a634f00, thanks.


[Bug]: Unable to select 2FA method during account setup on Firefox

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[X] I have joined the ZITADEL chat

Environment
Self-hosted
Version
v2.37.2
Describe the problem caused by this bug
During the signup process, the first account setup or after enforcing 2FA, it is impossible to select a 2FA method on Firefox, thus becoming stuck on the 2-Factor Setup screen.
To reproduce

Configure your instance to enforce 2FA
Remove all second factors from your account
Sign out
Sign in again on Firefox

Screenshots

Expected behavior
By clicking on a method it should be selected and the user able to click on next.
Operating System
OS: Pop!Os 22.04 & Windows 10
Browser: Firefox 118.0.1
Relevant Configuration
On Chrome it works as expected.
Additional Context
No response

This has already been fixed with the following pr: https://github.com/zitadel/zitadel/pull/6632
Its included in the Rc 2.38.0 and will soon be released and deployed to zitadel.cloud


On Ubuntu 16.04 "xargs: run_command: No such file or directory"

Hi,
I'm running the video script on Ubuntu LTS 16.04 with bash, using the "master.zip" as of yesterday.
Something is wrong with "xargs" and possibly "ffmpeg":
$ ./gear360video.cmd -s -t ./tmp/ 360.mp4
DEBUG: Output filename: ./html/data/360_pano.mp4
DEBUG: Running command:  notify-send -a ./gear360video.cmd Starting panoramic video stitching..
Extracting frames from video (this might take a while)...
DEBUG: Running command:  ffmpeg -y -i 360.mp4 tmp/tmp.PihX3Qdgm7/image%05d.jpg
ffmpeg version 2.8.11-0ubuntu<IP_ADDRESS> Copyright (c) 2000-2017 the FFmpeg developers
[...cut...]
DEBUG: Input video size: 2560:1280
DEBUG: PTO template: gear360video2k.pto
Stitching frames...
xargs: run_command: No such file or directory
Recoding the video...
DEBUG: Stream: 0 FPS: 30000/1001
DEBUG: Input video FPS: 30000/1001
DEBUG: Running command:  ffmpeg -y -f image2 -i tmp/tmp.0MpP9oRFLX/image%05d_pano.jpg -r 30000/1001 -s 2560:1280 -vcodec libx264 tmp/tmp.0MpP9oRFLX/tmpvideo.mp4
ffmpeg version 2.8.11-0ubuntu<IP_ADDRESS> Copyright (c) 2000-2017 the FFmpeg developers
[...cut...]
[image2 @ 0xca6940] Could find no file with path 'tmp/tmp.0MpP9oRFLX/image%05d_pano.jpg' and index in the range 0-4
tmp/tmp.0MpP9oRFLX/image%05d_pano.jpg: No such file or directory
Error while running ffmpeg
DEBUG: Running command:  notify-send -a ./gear360video.cmd Error while running ffmpeg
Removing temporary directories...
DEBUG: Removing frames directory: tmp/tmp.PihX3Qdgm7
DEBUG: Removing output directory: tmp/tmp.0MpP9oRFLX

The xargs line in the script is this:
if [ -z "${USEPARALLEL+x}" ]; then
  # No parallel
  find $FRAMESTEMPDIR -type f -name '*.jpg' | xargs -Ipanofile run_command "$DIR/gear360pano.cmd" -r -m -o "$OUTTEMPDIR" "panofile" "$PTOTMPL"
else

The ffmpeg error occurs in this line:
run_command ffmpeg -y -f image2 -i "$OUTTEMPDIR/$IMAGETMPLENC" -r "${SRCFPSSTR}" -s "${SRCVIDEOSIZE}" $FFMPEGQUALITYENC "$OUTTEMPDIR/$TMPVIDEO"`

Any ideas how this can be fixed?
RL.

Can you try the fix mentioned here?
https://github.com/ultramango/gear360pano/pull/44#issuecomment-361947139

Should be fixed now - I didn't check properly xargs "fix".
Note: I've noticed, as someone already noted, extra frames being added to video - I don't know yet why it happens. Every second extra 6 frames are added.
Please reopen if problem persists.


fix(rbac): remove empty summary row, align bundle with other plugins

Hey, I just made a Pull Request!

fix: remove empty summary row from the UI by adding a filterTableData util that filters the table rows similar to @material-table/core (the implementation behind Backstage Table)
remove @janus-idp/cli / scalprum configuration from package.json
Rename app-config.yaml to app-config.dynamic.yaml to align it with other plugins and make it clear that is actually no real/full app-config.

Before:
https://github.com/user-attachments/assets/d501a696-6d9f-42e8-bfed-2b5a8e74096b
After:
https://github.com/user-attachments/assets/5bc2e5c7-b07c-4a7a-919e-ac545d762feb
For reviewers:
I installed the RBAC plugin with this command into my local RHDH:
cd workspaces/rbac/plugins/rbac

npx --yes @janus-idp/cli package export-dynamic-plugin --dynamic-plugins-root ~/git/janus-idp/backstage-showcase/dynamic-plugins-root --dev

Removing the scalprum configuration requires that I changed my RHDH config from:
dynamicPlugins:
  frontend:
    janus-idp.backstage-plugin-rbac:
      appIcons:
        - name: rbacIcon
          importName: RbacIcon
          module: RbacPlugin
      dynamicRoutes:
        - path: /rbac
          module: RbacPlugin
          importName: RbacPage
          menuItem:
            icon: rbacIcon
            text: RBAC3
      menuItems:
        rbac:
          parent: admin
          icon: rbacIcon
          priority: 10

to

dynamicPlugins:
  frontend:
    backstage-community.plugin-rbac:
      appIcons:
        - name: rbacIcon
          importName: RbacIcon
      dynamicRoutes:
        - path: /rbac
          importName: RbacPage
          menuItem:
            icon: rbacIcon
            text: RBAC1-X
      menuItems:
        rbac:
          parent: admin
          icon: rbacIcon

So the expected plugin id and no need to define the module anymore.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

/lgtm


debounce timing

Hi, I encountered a problem that when a file under watch is modified many times successively in a short period (e.g. building a file by appending), there may be a situation that the "changed" event is not emitted after the last modification ocurred. So the callback function cannot see the "final content" of the file.
This seems because that when an event ocurred, next events are blocked for debounceDelayms. So I added a code trying to emit the event after the last filesystem event, even if emitting was blocked by previous event's delay.
I wonder if this is a good solution, but I'm glad if you take a look at it. Thanks.

Just wondering if there is a plan to address this issue.  Sounds like a pretty serious issue if an event is not issued immediately after the last change.  It does seem like a shame not to just use lodash/underscore debounce but I understand if you want to avoid extra dependencies.  Thanks.

@expectlabs-andrew I haven't had time to address this. Currently it fails test (and now has a merge conflict).
I don't think this issue is that serious though. It already does debounce just not the exact time the OP wants. FWIW, I'd prefer to not do this internally and let users choose how/if they want to debounce.
So this is not a high priority for me but if someone else wanted to fix this to not fail tests I'd be happy to merge.

Thanks for the update.  Debouncing locally is by fine, but this worried me enough to go back to gulp.watch (where I can also use lodash to debounce).  My concern is just that the out-of-the-box default behavior can actually leave unhandled events on the table.  If that is, in fact, the default behavior, then it might be just be better to disable debouncing by default.  To debounce locally, my reading of the code is that I explicitly need to set debounceDelay to 0 instead of the default value of 500.


php2cpg: double arrow operator needs desugaring

so we can make any sense of it, we need to desugar the double arrow operators:
$x = array(
    key  => value,
    ...
)

into something like
$x = Block {
   _tmp = array()
   _tmp[key] = value
   ...
   _tmp
}

and
foreach($x as $key => $value) {
}

into something like
... // existing $iter_tmp initialization
$key = $iter_tmp1->key()
$value = $iter_tmp1->current()
... // loop body

The array case is already handled as suggested. I'll update the foreach case to match.


Doc: Add a new Extention Feature(extention13.kt)

Description:

add a new extention13.kt

PR Instruction:

Issue will be assigned on a first come first serve basis.
If you are thinking to make a pr then at first be sure to get assigned.
before pushing your PR please make sure to fetch upstream.
your pr should be pushed on the develop branch only.
try to complete your assigned task within 3 to 5 days and if you need more time then please let me know. As the program has limited time only so please try to complete as fast as you can.
With your PR try to send a screenshot or screen recording of your work

I am interested


Fast path get_section on macOS

BREAKING: replace find_section with get_section! macro.
get_section!: Add a static mut at __SUI_INTERNAL,<SECT_NAME>. It stores section's vmaddr and data length.
MachO::build: Update the info during inject phase.

Already fast https://github.com/denoland/sui/issues/25#issuecomment-2362788796


Fix bad thread titles

Bot shouldn't match titles like "... samosas..."
https://www.reddit.com/r/singapore/comments/qt0odc/delivering_pizzas_samosas_and_deepavali_cheer_to/hkgafmy/

Hello! Greatly appreciate the PR, but I think it's missing an edge case.
samosa is no longer triggered, but samos will still cause it to trigger. You might have to do a double \b word boundary.
Could you also help to add 2 additional unit tests? On top of samosa, please also help to test for samos and amosa.

Appreciate it, thanks!


Vue 2 component type decoration

Add the .d.ts declaration file for Vue 2 output.
Waiting for https://github.com/BuilderIO/mitosis/issues/847 to be fixed.

Vue 2 is deprecated #17


Testing infrastructure

We should create some testing infrastructure, primarily for use during development:

A command for publishing events to a queue (perhaps receiving ND-JSON as input?) (#72)
~A command for consuming events from a queue (#85)~
System / integration tests that run against the two queue implementations.

System test framework (#92)

Infrastructure provisioning, wait for infrastructure to be available.
Tear down after tests are complete or with an additional command.

Basic producing (#93)

Synchronous and Asynchronous producing
Topic routing

Group consuming (#94)
~- Run system tests as part of PR checks (approved contributors) (#95).~

I moved https://github.com/elastic/apm-queue/issues/95 out of scope for ms-03. Let's discuss that with the robots team when this can be tackled.
Please ensure to get https://github.com/elastic/apm-queue/issues/94 merged within the ms-03, so that we can close this meta issue.

@simitt Could you please provide more detail on what you would like our team to do in this regard?

@cachedout that comment was refering to #95, where we already discussed that the robots team is taking on the automation (ss https://github.com/elastic/apm-queue/issues/95#issuecomment-1527036259)

Moved this task to ms-04, the PR looks like it is at a good stage to get merged in this iteration.

@simitt is this task also meant to track the CI automation side of things? The initial tests have been all added now that #116 is closed.


Codespaces Jupyter Template not working

I just tried Codespaces for the first time. I clicked on Codespaces, and then I started my first Jupyter template.
Then I opened one of the included notebooks (matplotlib.ipynb). The window opened is empty and it loops forever (small moving blue line moving from left to right on top of window).
It also opens the following notifications:
"
Error loading webview: Error: Could not register service workers: NotSupportedError: Failed to register a ServiceWorker for scope ('https://1pvulns9h30c6i2c38d0d0dmih5124tmd0rrgmk5934qicaco55d.vscode-cdn.net/stable/92da9481c0904c6adfe372c12da3b7748d74bdcb/out/vs/workbench/contrib/webview/browser/pre/') with script ('https://1pvulns9h30c6i2c38d0d0dmih5124tmd0rrgmk5934qicaco55d.vscode-cdn.net/stable/92da9481c0904c6adfe372c12da3b7748d74bdcb/out/vs/workbench/contrib/webview/browser/pre/service-worker.js?v=4&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&remoteAuthority=codespaces+janpfeifer-fantastic-space-eureka-gv49p57g79cpgrw'): The user denied permission to use Service Worker..
"
There seems to be an option for "Insiders Version". I tried that as well, but to no avail, same error.
I also tried the latest version of the Jupyter extension plugin by Microsoft, still the same error.
The demo/jupyter template seems to be broken.
Also any advise on how to try it out ?
cheers
ps.: I created a similar issue in Codespaces: https://github.com/microsoft/vscode/issues/176218
Environment data
Not sure ... but I just created a default Codespaces (first time for me), opened jupyter template, and it didn't work. I'm not usually a VS Code user. Likely whatever is the default for Github Codespaces.

VS Code version: XXX

Jupyter Extension version (available under the Extensions sidebar): v2023.2.1000592019

While poking around to try to fix, here I tried both the release/pre-release. Same issue.

Python Extension version (available under the Extensions sidebar): XXX
OS (Windows | Mac | Linux distro) and version: XXX
Python and/or Anaconda version: XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Jupyter server running: Local | Remote | N/A

Expected behaviour
XXX
Actual behaviour
XXX
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

XXX

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

I'm sorry for not getting back to you on this issue, somehow this has slipped though the cracks.
I'm certain this may have been resolved, as I'm unable to repro this anymore and i've seen a few issues related to service worker having been resolved in the past.
Closing as completed,
If you believe this hasn't been fixed, please ping here and I'll reopen this or feel free to create a new issue and we'll look into this.


Fix e2e networkpolicy tests on Kind for slower machines

I tried running the tests locally today and couldn't get the test setup
(initial probe to check connectivity between all Pods) to succeed. I
added some log messages and it seems that a fraction of the probes
(different set of probes for every attempt) was always failing. I wasn't
able to reproduce the connection failures by exec'ing into the Pods
directly. I believe that this is caused by
https://github.com/antrea-io/antrea/pull/2565, which is causing a vey
large number of probes (648) to execute in parallel, each in its own
goroutine. This happens when running Docker on my macOS laptop, but
surprisingly I haven't observed any such failure in Github Actions. My
fix is to limit parallel probes to a single port number.
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

Codecov Report

Merging #2614 (5bc7aed) into main (fdf3034) will decrease coverage by 18.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2614       +/-   ##
===========================================
- Coverage   60.35%   41.95%   -18.40%
===========================================
  Files         283      154      -129
  Lines       22455    18609     -3846
===========================================
- Hits        13552     7807     -5745
- Misses       7472    10101     +2629
+ Partials     1431      701      -730

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Added missing HTMLFieldSetElement properties

This commit added disabled property for HTMLFieldSetElement but this property is not in DOM2 specification. I've moved it into html5.js extern and added other missing properties according to the HTML5 specification.

 Unless someone is going to take on a huge project to reorganize them, I don't think this is worth it.

Why do you think that adding missing properties isn't worth it? Or you want these properties to go under the w3c_dom2.js extern?

Adding missing properties is fine but moving things from one file another is just churn.

So, if I move these new properties under the w3c_dom2.js extern, will you merge it?

So, if I move these new properties under the w3c_dom2.js extern, will you merge it?

We'll try. Can you move the definition of HTMLFieldSetElement.prototype.disabled back to its original place?

Updated

AFAICT, there are no custom externs defined for these properties internally, so this should be safe.


next/release

:tada: This PR is included in version 1.3.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add entity-relationship model

Add separate section and entity-relationship diagram

Also quite strange to notice what account_id is, but w/o any note of the other fields

I agree. Maybe we should describe all the fields markdown and delete the diagram


add payment source

In the current Firebase Cloud Function example, users lack the ability to add a payment source that they can later initiate a charge on

Signed!

@jamesdaniels made some changes


Refactor frontend modules/controller

This PR includes

Removed disableAlarmButton.
Refactored AlarmModal to have one component which returns just the content inside the modal, and one component which returns the content wrapped inside an AlarmModal popop.
Using a Range object (interface with lower and upper) instead of a variable-length array for alarm limits (This is done in #413 as it was linked to changes to multistepwizard).
Marked ValueModal and ControlInfo for deprecation.

Updated JSdoc comments and fixed #429!

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
Were any of these contributions also part of work you did for an employer or a client? No.
Does this work include, or is it based on, any third-party work which you did not create? No.


created login page

Added a login page that extends the home page
Created a views.py inside side_hustle
please review code
Closed PR #31, #44
#41 Assigned by shay

Everything looks fine

Also, fix the subject line.
You should capitalize the subject line.

I'm fine with this, but you'll have fix the conflicts


Make doc icons consistent with the code completion icons

@kasperpeulen
Currently code completion has icons, but the doc comments don't. It would be nice if we could make the display of these two things consistent with each other.
Could we include the icons from code completion into the docs?

I've got this allmost done now, except for one issue, which is that the dartdoc and completion api give different information about what kind of type the element is.
If some element has a both a getter and a setter, dartdoc seems to mark it as field.
Where the completion api makes a difference between regular fields and setters which is also a getter (or the other way around :P)

If some element has a both a getter and a setter, dartdoc seems to mark it as field.

I actually don't think this is a bug, but an artifact of how setters and getters are defined.

@devoncarew Not totally sure what you mean, but I do think it makes sense to treat something which is both a getter and a setter, as a field.
Anyway, I guess we should have the completion UI icons and the dartdoc ions look the same. Thoughts ? @devoncarew

fixed by https://github.com/dart-lang/dart-pad/pull/221


Move Interval trait to utils, added in #75

Linking to https://github.com/bigdatagenomics/utils/pull/75

Closed by #1046?

Closed by https://github.com/bigdatagenomics/adam/pull/1046.


build: add more utils to regression test

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#952  👈
#948
#946
#945
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on  Graphite

crates/gateway/src/lib.rs line 7 at r2 (raw file):
Previously, aner-starkware wrote…
Blocked until approved by @dorimedini-starkware .

Please verify with GW team that this change is OK.


[FFM-3503]: Fixes custom logger

Fixes #40

Sample app output with custom logger:
$ npm run start

><EMAIL_ADDRESS>start
> node index.js

Starting application
Application started
[test logger] [ 'Starting PollingProcessor with request interval: ', 60000 ]
[test logger] [ 'Fetching flags started' ]
[test logger] [ 'Fetching segments started' ]
[test logger] [ 'Starting StreamProcessor' ]
[test logger] [ 'StreamingProcessor ready' ]
[test logger] [ 'Starting MetricsProcessor with request interval: ', 60000 ]
[test logger] [ 'MetricsProcessor ready' ]
[test logger] [ 'finished setting up processors' ]
[test logger] [ 'Stream connected', Event { type: 'open' } ]
[test logger] [ 'Stopping PollingProcessor' ]
[test logger] [ 'Fetching flags finished' ]
[test logger] [ 'Fetching segments finished' ]
[test logger] [ 'PollingProcessor ready' ]
[test logger] [ 'PollingProcessor stopped' ]
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
[test logger] [ 'Start sending metrics data' ]
[test logger] [ 'Metrics server returns: ', 200 ]

Sample app output with defaults:
$ npm run start

><EMAIL_ADDRESS>start
> node index.js

Starting application
Application started
Starting PollingProcessor with request interval:  60000
Fetching flags started
Fetching segments started
Starting StreamProcessor
StreamingProcessor ready
Starting MetricsProcessor with request interval:  60000
MetricsProcessor ready
finished setting up processors
Fetching segments finished
Fetching flags finished
PollingProcessor ready
Stream connected Event { type: 'open' }
Stopping PollingProcessor
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
Evaluation for flag test and target:  false { identifier: 'harness' }
PollingProcessor stopped
Start sending metrics data
Metrics server returns:  200


Add a dockerfile, with the idea to potentially parallelize and run on a cloud service

Potentially useful to others. I will let you be the judge of that.
Usage:
To build: docker build -t entelect-2018:latest .
To run (interactive): docker run -it entelect-2018:latest bash (and from the resulting interactive shell: make run)
To run (non-interactive): docker run entelect-2018:latest make run
To run a cluster of containers from an image like this, one could use docker-compose and a common mounted volume. If interested, I can submit an example docker-compose file too.

@Blaarkies Oh, sorry. I will sort it out and delete this PR.


Isolated (non-k8s) performance tests

Clear instructions on how to run
There is a well-known location to publish and compare results.
Targeting iperf, nighthawk, netperf tcp crr, fairness (measure tbd)
Measure resource usage (CPU, RAM)
These tests may be the same as the E2E ones, but can easily be run either 1 or 2 machines with only the testing infra and the zTunnel.

I ran it adhoc, I think we want to make it trivial to run (e.g cargo bench --test throughput) or whatever

Has a open PR for it, should be done soon.


Fix play/pause symbol behavior if multiple bars have the same name

The get_spotify_status.sh now sends messages to each Polybar with matching name
I hope this PR is properly formatted, I'm new to GitHub collaboration and bash programming :/

fixes #9

LGTM. Thanks for your work! I don't think you're new to bash. Your code says otherwise haha.


[Backport staging-23.11] go_1_21: 1.21.6 -> 1.21.8

Changelog: https://go.dev/doc/devel/release#go1.21.0
Signed-off-by: Paul Meyer<EMAIL_ADDRESS>(cherry picked from commit 5b02c75ac07a1ad525f1d7bfc305a4359d0f2917)
Description of changes
Manual backport of https://github.com/NixOS/nixpkgs/pull/293563
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Included in staging-next-23.11 (PR #293976).  I just cherry-picked it, as I wanted to also correct the version in commit message.


Superset API token through Keycloak

Description/Context

We need to access the Superset API and thus require a way to generate a token with appropriate levels of permission.
Plan/Design

Given our Superset integration with Keycloak, we need to find a way to generate a token using the Keycloak endpoint that can be used to auth against the Superset API.

I've started out by using the existing integration to obtain a token. In order to do that, I had to enable the service account roles on the superset client.
curl -X POST \   'https://sso-ci.ol.mit.edu/realms/ol-data-platform/protocol/openid-connect/token' \   -H 'Content-Type: application/x-www-form-urlencoded' \   -d 'grant_type=client_credentials' \   -d 'client_id=<client_id>' \   -d 'client_secret=<client_secret>
Using the newly obtained token, tried a GET request to access the Superset API:
curl -X GET \   'https://bi-ci.ol.mit.edu/api/v1/dashboard/' \   -H 'Authorization: Bearer <token>
This generated the following error:
{"msg":"The specified alg value is not allowed"}
Decoding the token, it shows that the default Keycloak algo generated token is RS256. Going through the flask-app builder docs which is what Superset is based on, it relies on python Authlib to decode the token. I didn't came across anything that hinted that Authlib does not allow RS256. I accessed the superset docker container and using the python interpreter was able to decode the Keycloak generated token. Despite that, tried switching the algo in the realm settings in Keycloak to using HS256 to test things out. The error this time around was:
{"msg":"Signature verification failed"}
After some additional digging, came across a discussion to add the following keys to superset_config.py:

JWT_ALGORITHM = "RS256"
JWT_PUBLIC_KEY = "keycloak_public_key_cert"

With those values in place, I tried accessing the API and this time around, the error was:
ERROR:superset.views.base:invalid literal for int() with base 10: '81236d7a-c521-4119-87b5-14da680e3c9c' Traceback (most recent call last):   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1823, in full_dispatch_request     rv = self.dispatch_request()   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1799, in dispatch_request     return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)   File "/usr/local/lib/python3.10/site-packages/flask_appbuilder/security/decorators.py", line 100, in wraps     verify_jwt_in_request()   File "/usr/local/lib/python3.10/site-packages/flask_jwt_extended/view_decorators.py", line 83, in verify_jwt_in_request     _request_ctx_stack.top.jwt_user = _load_user(jwt_header, jwt_data)   File "/usr/local/lib/python3.10/site-packages/flask_jwt_extended/view_decorators.py", line 141, in _load_user     user = user_lookup(jwt_header, jwt_data)   File "/usr/local/lib/python3.10/site-packages/flask_jwt_extended/internal_utils.py", line 25, in user_lookup     return jwt_manager._user_lookup_callback(*args, **kwargs)   File "/usr/local/lib/python3.10/site-packages/flask_appbuilder/security/manager.py", line 2163, in load_user_jwt     user = self.load_user(identity)   File "/usr/local/lib/python3.10/site-packages/flask_appbuilder/security/manager.py", line 2157, in load_user     user = self.get_user_by_id(int(pk)) ValueError: invalid literal for int() with base 10: '81236d7a-c521-4119-87b5-14da680e3c9c'
It appears that Superset is using the value of sub key in the token to call the get_user_by_id function which requires an int instead of the Keycloak generated value. So far I have been unable to change that to an int or force Superset to use a different key by adding a Keycloak mapping. Tried doing the following:

Added a User Attribute in the mappers called sub with an int value
Added a key called superset_api with a hardcoded int value (verified that it is being added to the token) and added JWT_PAYLOAD_USER_ID = superset_api in the superset_config.py

Links

https://github.com/apache/superset/issues/2488
https://github.com/keycloak/keycloak/discussions/25226

The current failure mode should be addressed by https://github.com/mitodl/ol-infrastructure/commit/0857304a26ea370d542a20e79f8e0b96dcd5b873 once it gets deployed

Tested this again and ran into the same error as before. I did decode the JWT returned from Keycloak and verified that it does contain the preferred_username field.

We were able to resolve this for now by creating a Keycloak user and assigning it to a Superset role with the required permissions. In addition we had to add the two Superset keys/values to the config mentioned above. Ideally we'd be able to use the logged in user session to obtain a Keycloak token, however the API call requires the user password and with Touchstone users, don't think that'll actually work. For now we're gonna settle on creating the Keycloak account and generating the token that way.

Tested this on both QA and prod and it worked as expected. Closing issue.

@shaidar, hello man! you can write examples of work requests? Thx

@shaidar Thank's to your description i was able to configure api access in my superset instance with keycloak :) This is my setup if anyone would need to do the same
import json
import urllib.request
from jwt.algorithms import RSAAlgorithm

JWT_ALGORITHM = "RS256"
JWT_DECODE_ALGORITHMS = ["RS256"]

# URL to the JWKS endpoint
jwks_url = "<keycloak>/protocol/openid-connect/certs"

def fetch_keycloak_rs256_public_cert():
  with urllib.request.urlopen(jwks_url) as response:  # noqa: S310
      jwks = json.load(response)

  public_key = RSAAlgorithm.from_jwk(
      json.dumps(jwks["keys"][0])
  )
  return public_key

JWT_PUBLIC_KEY = fetch_keycloak_rs256_public_cert()

and then in CUSTOM_SECURITY_MANAGER i overwrite flask function load_user_jwt to mitigate problem with sub by using id field wich in my case contains username. Then i get user using superset  get_user_by_username function.
from flask import g
class CustomSsoSecurityManager(SupersetSecurityManager):
      <...>
      def load_user_jwt(self, _jwt_header, jwt_data):
          name = jwt_data.get("id", None)
          user = self.get_user_by_username(name)
          g.user = user
          return user

@FGrobelny Does your config work for accessing the Superset security endpoint? So for example if you want to create role definitions through the API which would be accessing the security endpoint using the token generated by Keycloak, do you get a 403 error or no?

I needed this to be able to obtain csrf token /api/v1/security/csrf_token and call /api/v1/chart/warm_up_cache and it works. With this setup you have access to api endpoints based on superset roles of user returned from load_user_jwt.
So let's say you have a superset-admin role in keycloak that maps through AUTH_ROLES_MAPPING to Admin role in Superset.
And you use your access token obtained from  keycloak openid-connect/token to query superset api - superset will see that you have an admin role and grant access based on that.
You can also enable keycloak service account and use that to perform some admin actions. Then you would need to map this service account to some account existing in superset
def load_user_jwt(self, _jwt_header, jwt_data):
...
name = jwt_data.get("id", None)
if name == "service-account-superset":
   name = "admin"
...


[MOB-1362] in-app presentation timer

There may be a memory leak. InAppPresenter has a reference to HtmlMessageVC and HtmlMessageVC has a reference to InAppPresenter.
Can you please confirm that the view controller etc is getting deallocated?

Have you tested how this works with slow loading images?

Yes! I'm able to trigger the delay timer with an intentionally huge in-app (in our own test project). I also have a very small text only in-app to test for HTML loading first. Confirmed, they trigger the correct functions as expected in my own wireless network.

InAppParsingTests.testDoNotShowMultipleTimes is failing because of fixes.
The other failures are unrelated.
Also have you checked that deInit of IterableHtmlMessageViewController is being called?

InAppParsingTests.testDoNotShowMultipleTimes is failing because of fixes.
The other failures are unrelated.
Also have you checked that deInit of IterableHtmlMessageViewController is being called?

Yep, I think I know the cause of the failed test.
Yep, the deinit is definitely being called.

I think this is ready to get a +1. We should wait to merge this after we release version 6.2.5 of our SDK.


Angular split not working properly when integrated in angular material tabs inside tab-content

I am using Angular material tabs and inside the first tab i m putting the angular split but it won't fetch the size for the first . It takes 100% of the last '

'
I had tried using your angular-split version 2.
https://stackblitz.com/edit/angularsplit-splitarea-width-error
As you can see in above example that first "" size is  set to "30" but it won't fetch the size

Thanks for creating the issue.
I tried your stackblitz, you're right it fails using 2.0.1 but if you install 3.0.0-beta.9 it works!
I don't think i'm gonna update 2.x but 3.0.0 release is soon..
I'm not used to angular material but i've seen weird behavior regarding split height so I made some tests and got this:
https://stackblitz.com/edit/angularsplit-splitarea-width-error-ax1mtj?file=src%2Fapp%2Fapp.component.css

FYI I saw a similar issue using angular-material and angular-split 2.x. In my case, the gutter was immobile and would not drag at all to resize. Following @bertrandg 's hint, I switched to 3.0.0-beta.9 and the problem went away.
Please let me add that angular-split is a first-class library. We use it in a number of projects, both open source and in-house. Many thanks @bertrandg and looking forwards to v3!

@mflorence99 Thanks, I appreciate! ;)

Version 3.0.0 released, it should works better now! ;)


CUDA: Support Enum/IntEnum in Kernel

This PR adds support to Enum/IntEnum to kernel. Tested cases include: compares, use as constants, explicit/implict convert to ints and vectorize.

gpuci run tests

I don't think it's trivial to support this just yet. From this page we may need to implement some functions on device?

Ah - once overloads and the high-level extension API works on the CUDA target, this should be easier to re-visit (if there are hashes written only using overload_method and intrinsics then support for them should come "for free").

gpu ci run tests

gpuci run tests

/azp run


MINOR: Preserve the assignment order from the LeaderAndIsr request

Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

cc @hachikuji @mumrah @soondenana

LGTM. Change is pretty simple and consolidates assignment and isr handling.
So how is this going to be useful (i.e. preserving the assignment order?). There was a discussion about this, but I didn't catch all of it.

Thanks for the reivew!

So how is this going to be useful (i.e. preserving the assignment order?). There was a discussion about this, but I didn't catch all of it.

This change makes it so that we are making change to the assignment and the isr at the same time as part of the LeaderAndIsr request. We want to preserve order mainly for consistency with the Controller's code and data representation.

All the tests in Scala 2.12 with JDK 11 and Scala 2.11 with JDK 8 passed.

We should include the motivation in the PR description.

We should include the motivation in the PR description.
Done.

please retest this

retest this please

retest this please

So the main benefit of this patch is that we can consolidate the replica creation logic in order to ensure replica/isr invariants are maintained. We also retain the ordered representation of the replicas, which is useful for debugging if nothing else. Is that right?

That is correct. Thanks for the review. Update the PR based on your comments.

Looks good overall. Unless it's too much trouble to separate, maybe we could do the cleanup changes (renaming, removing unused code, etc) as a separate PR. I definitely like the cleanup, but it muddles the real purpose of this commit.

I tend to clean up code and I see it. If I don't do it then, I tend to move to the ticket/PR and forget to go back to clean up the code. I'll avoid doing this in future PRs.

Thanks for the review @mumrah !

I tend to clean up code and I see it. If I don't do it then, I tend to move to the ticket/PR and forget to go back to clean up the code.

I do the same, otherwise I may never end up cleaning code. What I have done before is to split the commit in two (using "git add -i" to select hunks) before sending for review, one for actual issue and another just containing cleanup.