Error while uploading SARIF file using action  github/codeql-action/upload-sarif

Hello expert,
I am trying to upload a SARIF file generated by a trivy scan. Whereas the SARIF file is generated, the upload of the file in the security tab failed with the message:
Run github/codeql-action/upload-sarif@v3
  with:
    sarif_file: trivy_report.sarif
    checkout_path: /home/runner/work/aws-htc-grid/aws-htc-grid
    token: ***
    matrix: null
    wait-for-processing: true
  env:
    TRIVY_REPORT_FILE: trivy_report.sarif
    ACTIONS_STEP_DEBUG: true
Uploading results
  Processing sarif files: ["trivy_report.sarif"]
  Validating trivy_report.sarif
  Combining SARIF files using the CodeQL CLI
  Adding fingerprints to SARIF file. See https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs for more information.
  Uploading results
  Successfully uploaded results
Waiting for processing to finish
  Analysis upload status is pending.
  Analysis upload status is failed.
Error: Code Scanning could not process the submitted SARIF file:
locationFromSarifResult: expected artifact location

Do you have any clues  what could be wrong with my SARIF files or how to improve observability of the action ?

@stacke: Is this one for your team?

I checked and it seems that all issue as well a location.
Please find below the SARIF file.
{
  "version": "2.1.0",
  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
  "runs": [
    {
      "tool": {
        "driver": {
          "fullName": "Trivy Vulnerability Scanner",
          "informationUri": "https://github.com/aquasecurity/trivy",
          "name": "Trivy",
          "rules": [
            {
              "id": "AVD-AWS-0066",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "Lambda functions should have X-Ray tracing enabled"
              },
              "fullDescription": {
                "text": "X-Ray tracing enables end-to-end debugging and analysis of all function activity. This will allow for identifying bottlenecks, slow downs and timeouts."
              },
              "defaultConfiguration": {
                "level": "note"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0066",
              "help": {
                "text": "Misconfiguration AVD-AWS-0066\nType: CloudFormation Security Check\nSeverity: LOW\nCheck: Lambda functions should have X-Ray tracing enabled\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)\nX-Ray tracing enables end-to-end debugging and analysis of all function activity. This will allow for identifying bottlenecks, slow downs and timeouts.",
                "markdown": "**Misconfiguration AVD-AWS-0066**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|CloudFormation Security Check|LOW|Lambda functions should have X-Ray tracing enabled|Function does not have tracing enabled.|[AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)|\n\nX-Ray tracing enables end-to-end debugging and analysis of all function activity. This will allow for identifying bottlenecks, slow downs and timeouts."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "2.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "LOW"
                ]
              }
            },
            {
              "id": "AVD-AWS-0057",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "IAM policy should avoid use of wildcards and instead apply the principle of least privilege"
              },
              "fullDescription": {
                "text": "You should use the principle of least privilege when defining your IAM policies. This means you should specify each exact permission required without using wildcards, as this could cause the granting of access to certain undesired actions, resources and principals."
              },
              "defaultConfiguration": {
                "level": "error"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0057",
              "help": {
                "text": "Misconfiguration AVD-AWS-0057\nType: Terraform Security Check\nSeverity: HIGH\nCheck: IAM policy should avoid use of wildcards and instead apply the principle of least privilege\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource 'df72e57f-3373-4d89-a731-ecde18753d1d:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)\nYou should use the principle of least privilege when defining your IAM policies. This means you should specify each exact permission required without using wildcards, as this could cause the granting of access to certain undesired actions, resources and principals.",
                "markdown": "**Misconfiguration AVD-AWS-0057**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|Terraform Security Check|HIGH|IAM policy should avoid use of wildcards and instead apply the principle of least privilege|IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource 'df72e57f-3373-4d89-a731-ecde18753d1d:*'|[AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)|\n\nYou should use the principle of least privilege when defining your IAM policies. This means you should specify each exact permission required without using wildcards, as this could cause the granting of access to certain undesired actions, resources and principals."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "8.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "HIGH"
                ]
              }
            },
            {
              "id": "AVD-AWS-0088",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "Unencrypted S3 bucket."
              },
              "fullDescription": {
                "text": "S3 Buckets should be encrypted to protect the data that is stored within them if access is compromised."
              },
              "defaultConfiguration": {
                "level": "error"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0088",
              "help": {
                "text": "Misconfiguration AVD-AWS-0088\nType: CloudFormation Security Check\nSeverity: HIGH\nCheck: Unencrypted S3 bucket.\nMessage: Bucket does not have encryption enabled\nLink: [AVD-AWS-0088](https://avd.aquasec.com/misconfig/avd-aws-0088)\nS3 Buckets should be encrypted to protect the data that is stored within them if access is compromised.",
                "markdown": "**Misconfiguration AVD-AWS-0088**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|CloudFormation Security Check|HIGH|Unencrypted S3 bucket.|Bucket does not have encryption enabled|[AVD-AWS-0088](https://avd.aquasec.com/misconfig/avd-aws-0088)|\n\nS3 Buckets should be encrypted to protect the data that is stored within them if access is compromised."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "8.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "HIGH"
                ]
              }
            },
            {
              "id": "s3-bucket-logging",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "S3 Bucket Logging"
              },
              "fullDescription": {
                "text": "Ensures S3 bucket logging is enabled for S3 buckets"
              },
              "defaultConfiguration": {
                "level": "note"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/s3-bucket-logging",
              "help": {
                "text": "Misconfiguration s3-bucket-logging\nType: Terraform Security Check\nSeverity: LOW\nCheck: S3 Bucket Logging\nMessage: Bucket has logging disabled\nLink: [s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)\nEnsures S3 bucket logging is enabled for S3 buckets",
                "markdown": "**Misconfiguration s3-bucket-logging**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|Terraform Security Check|LOW|S3 Bucket Logging|Bucket has logging disabled|[s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)|\n\nEnsures S3 bucket logging is enabled for S3 buckets"
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "2.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "LOW"
                ]
              }
            },
            {
              "id": "AVD-AWS-0090",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "S3 Data should be versioned"
              },
              "fullDescription": {
                "text": "\nVersioning in Amazon S3 is a means of keeping multiple variants of an object in the same bucket. \nYou can use the S3 Versioning feature to preserve, retrieve, and restore every version of every object stored in your buckets. \nWith versioning you can recover more easily from both unintended user actions and application failures.\n"
              },
              "defaultConfiguration": {
                "level": "warning"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0090",
              "help": {
                "text": "Misconfiguration AVD-AWS-0090\nType: CloudFormation Security Check\nSeverity: MEDIUM\nCheck: S3 Data should be versioned\nMessage: Bucket does not have versioning enabled\nLink: [AVD-AWS-0090](https://avd.aquasec.com/misconfig/avd-aws-0090)\n\nVersioning in Amazon S3 is a means of keeping multiple variants of an object in the same bucket. \nYou can use the S3 Versioning feature to preserve, retrieve, and restore every version of every object stored in your buckets. \nWith versioning you can recover more easily from both unintended user actions and application failures.\n",
                "markdown": "**Misconfiguration AVD-AWS-0090**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|CloudFormation Security Check|MEDIUM|S3 Data should be versioned|Bucket does not have versioning enabled|[AVD-AWS-0090](https://avd.aquasec.com/misconfig/avd-aws-0090)|\n\n\nVersioning in Amazon S3 is a means of keeping multiple variants of an object in the same bucket. \nYou can use the S3 Versioning feature to preserve, retrieve, and restore every version of every object stored in your buckets. \nWith versioning you can recover more easily from both unintended user actions and application failures.\n"
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "5.5",
                "tags": [
                  "misconfiguration",
                  "security",
                  "MEDIUM"
                ]
              }
            },
            {
              "id": "AVD-AWS-0132",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "S3 encryption should use Customer Managed Keys"
              },
              "fullDescription": {
                "text": "Encryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys."
              },
              "defaultConfiguration": {
                "level": "error"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0132",
              "help": {
                "text": "Misconfiguration AVD-AWS-0132\nType: CloudFormation Security Check\nSeverity: HIGH\nCheck: S3 encryption should use Customer Managed Keys\nMessage: Bucket does not encrypt data with a customer managed key.\nLink: [AVD-AWS-0132](https://avd.aquasec.com/misconfig/avd-aws-0132)\nEncryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys.",
                "markdown": "**Misconfiguration AVD-AWS-0132**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|CloudFormation Security Check|HIGH|S3 encryption should use Customer Managed Keys|Bucket does not encrypt data with a customer managed key.|[AVD-AWS-0132](https://avd.aquasec.com/misconfig/avd-aws-0132)|\n\nEncryption using AWS keys provides protection for your S3 buckets. To increase control of the encryption and manage factors like rotation use customer managed keys."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "8.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "HIGH"
                ]
              }
            },
            {
              "id": "AVD-AWS-0190",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "Ensure that response caching is enabled for your Amazon API Gateway REST APIs."
              },
              "fullDescription": {
                "text": "A REST API in API Gateway is a collection of resources and methods that are integrated with backend HTTP endpoints, Lambda functions, or other AWS services. You can enable API caching in Amazon API Gateway to cache your endpoint responses. With caching, you can reduce the number of calls made to your endpoint and also improve the latency of requests to your API."
              },
              "defaultConfiguration": {
                "level": "note"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0190",
              "help": {
                "text": "Misconfiguration AVD-AWS-0190\nType: Terraform Security Check\nSeverity: LOW\nCheck: Ensure that response caching is enabled for your Amazon API Gateway REST APIs.\nMessage: Cache data is not enabled.\nLink: [AVD-AWS-0190](https://avd.aquasec.com/misconfig/avd-aws-0190)\nA REST API in API Gateway is a collection of resources and methods that are integrated with backend HTTP endpoints, Lambda functions, or other AWS services. You can enable API caching in Amazon API Gateway to cache your endpoint responses. With caching, you can reduce the number of calls made to your endpoint and also improve the latency of requests to your API.",
                "markdown": "**Misconfiguration AVD-AWS-0190**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|Terraform Security Check|LOW|Ensure that response caching is enabled for your Amazon API Gateway REST APIs.|Cache data is not enabled.|[AVD-AWS-0190](https://avd.aquasec.com/misconfig/avd-aws-0190)|\n\nA REST API in API Gateway is a collection of resources and methods that are integrated with backend HTTP endpoints, Lambda functions, or other AWS services. You can enable API caching in Amazon API Gateway to cache your endpoint responses. With caching, you can reduce the number of calls made to your endpoint and also improve the latency of requests to your API."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "2.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "LOW"
                ]
              }
            },
            {
              "id": "DS026",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "No HEALTHCHECK defined"
              },
              "fullDescription": {
                "text": "You should add HEALTHCHECK instruction in your docker container images to perform the health check on running containers."
              },
              "defaultConfiguration": {
                "level": "note"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/ds026",
              "help": {
                "text": "Misconfiguration DS026\nType: Dockerfile Security Check\nSeverity: LOW\nCheck: No HEALTHCHECK defined\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)\nYou should add HEALTHCHECK instruction in your docker container images to perform the health check on running containers.",
                "markdown": "**Misconfiguration DS026**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|Dockerfile Security Check|LOW|No HEALTHCHECK defined|Add HEALTHCHECK instruction in your Dockerfile|[DS026](https://avd.aquasec.com/misconfig/ds026)|\n\nYou should add HEALTHCHECK instruction in your docker container images to perform the health check on running containers."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "2.0",
                "tags": [
                  "misconfiguration",
                  "security",
                  "LOW"
                ]
              }
            },
            {
              "id": "AVD-AWS-0178",
              "name": "Misconfiguration",
              "shortDescription": {
                "text": "VPC Flow Logs is a feature that enables you to capture information about the IP traffic going to and from network interfaces in your VPC. After you\u0026#39;ve created a flow log, you can view and retrieve its data in Amazon CloudWatch Logs. It is recommended that VPC Flow Logs be enabled for packet \u0026#34;Rejects\u0026#34; for VPCs."
              },
              "fullDescription": {
                "text": "VPC Flow Logs provide visibility into network traffic that traverses the VPC and can be used to detect anomalous traffic or insight during security workflows."
              },
              "defaultConfiguration": {
                "level": "warning"
              },
              "helpUri": "https://avd.aquasec.com/misconfig/avd-aws-0178",
              "help": {
                "text": "Misconfiguration AVD-AWS-0178\nType: Terraform Security Check\nSeverity: MEDIUM\nCheck: VPC Flow Logs is a feature that enables you to capture information about the IP traffic going to and from network interfaces in your VPC. After you've created a flow log, you can view and retrieve its data in Amazon CloudWatch Logs. It is recommended that VPC Flow Logs be enabled for packet \"Rejects\" for VPCs.\nMessage: VPC Flow Logs is not enabled for VPC\nLink: [AVD-AWS-0178](https://avd.aquasec.com/misconfig/avd-aws-0178)\nVPC Flow Logs provide visibility into network traffic that traverses the VPC and can be used to detect anomalous traffic or insight during security workflows.",
                "markdown": "**Misconfiguration AVD-AWS-0178**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|Terraform Security Check|MEDIUM|VPC Flow Logs is a feature that enables you to capture information about the IP traffic going to and from network interfaces in your VPC. After you've created a flow log, you can view and retrieve its data in Amazon CloudWatch Logs. It is recommended that VPC Flow Logs be enabled for packet \"Rejects\" for VPCs.|VPC Flow Logs is not enabled for VPC|[AVD-AWS-0178](https://avd.aquasec.com/misconfig/avd-aws-0178)|\n\nVPC Flow Logs provide visibility into network traffic that traverses the VPC and can be used to detect anomalous traffic or insight during security workflows."
              },
              "properties": {
                "precision": "very-high",
                "security-severity": "5.5",
                "tags": [
                  "misconfiguration",
                  "security",
                  "MEDIUM"
                ]
              }
            }
          ],
          "version": "0.53.0"
        }
      },
      "results": [
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: \nType: cloudformation\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": ""
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml\nType: cloudformation\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'cloudformation:DescribeStacks' on wildcarded resource '*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 109,
                  "startColumn": 1,
                  "endLine": 109,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml\nType: cloudformation\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource 'arn:${AWS::Partition}:logs:*:*:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 109,
                  "startColumn": 1,
                  "endLine": 109,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0088",
          "ruleIndex": 2,
          "level": "error",
          "message": {
            "text": "Artifact: deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml\nType: cloudformation\nVulnerability AVD-AWS-0088\nSeverity: HIGH\nMessage: Bucket does not have encryption enabled\nLink: [AVD-AWS-0088](https://avd.aquasec.com/misconfig/avd-aws-0088)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 279,
                  "startColumn": 1,
                  "endLine": 290,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "s3-bucket-logging",
          "ruleIndex": 3,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml\nType: cloudformation\nVulnerability s3-bucket-logging\nSeverity: LOW\nMessage: Bucket has logging disabled\nLink: [s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 279,
                  "startColumn": 1,
                  "endLine": 290,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0090",
          "ruleIndex": 4,
          "level": "warning",
          "message": {
            "text": "Artifact: deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml\nType: cloudformation\nVulnerability AVD-AWS-0090\nSeverity: MEDIUM\nMessage: Bucket does not have versioning enabled\nLink: [AVD-AWS-0090](https://avd.aquasec.com/misconfig/avd-aws-0090)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 279,
                  "startColumn": 1,
                  "endLine": 290,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0132",
          "ruleIndex": 5,
          "level": "error",
          "message": {
            "text": "Artifact: deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml\nType: cloudformation\nVulnerability AVD-AWS-0132\nSeverity: HIGH\nMessage: Bucket does not encrypt data with a customer managed key.\nLink: [AVD-AWS-0132](https://avd.aquasec.com/misconfig/avd-aws-0132)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 279,
                  "startColumn": 1,
                  "endLine": 290,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/dev_environment_cloud9/cfn/cloud9-htc-grid.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0190",
          "ruleIndex": 6,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/grid/terraform/control_plane/openapi_private.tf\nType: terraform\nVulnerability AVD-AWS-0190\nSeverity: LOW\nMessage: Cache data is not enabled.\nLink: [AVD-AWS-0190](https://avd.aquasec.com/misconfig/avd-aws-0190)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/grid/terraform/control_plane/openapi_private.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 124,
                  "startColumn": 1,
                  "endLine": 137,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/grid/terraform/control_plane/openapi_private.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0190",
          "ruleIndex": 6,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/grid/terraform/control_plane/openapi_public.tf\nType: terraform\nVulnerability AVD-AWS-0190\nSeverity: LOW\nMessage: Cache data is not enabled.\nLink: [AVD-AWS-0190](https://avd.aquasec.com/misconfig/avd-aws-0190)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/grid/terraform/control_plane/openapi_public.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 123,
                  "startColumn": 1,
                  "endLine": 136,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/grid/terraform/control_plane/openapi_public.tf"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/image_repository/lambda_runtimes/Dockerfile\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/image_repository/lambda_runtimes/Dockerfile",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/image_repository/lambda_runtimes/Dockerfile"
              }
            }
          ]
        },
        {
          "ruleId": "s3-bucket-logging",
          "ruleIndex": 3,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/init_grid/cloudformation/grid_state.yaml\nType: cloudformation\nVulnerability s3-bucket-logging\nSeverity: LOW\nMessage: Bucket has logging disabled\nLink: [s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/init_grid/cloudformation/grid_state.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 153,
                  "startColumn": 1,
                  "endLine": 172,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/init_grid/cloudformation/grid_state.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "s3-bucket-logging",
          "ruleIndex": 3,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/init_grid/cloudformation/grid_state.yaml\nType: cloudformation\nVulnerability s3-bucket-logging\nSeverity: LOW\nMessage: Bucket has logging disabled\nLink: [s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/init_grid/cloudformation/grid_state.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 239,
                  "startColumn": 1,
                  "endLine": 258,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/init_grid/cloudformation/grid_state.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "s3-bucket-logging",
          "ruleIndex": 3,
          "level": "note",
          "message": {
            "text": "Artifact: deployment/init_grid/cloudformation/grid_state.yaml\nType: cloudformation\nVulnerability s3-bucket-logging\nSeverity: LOW\nMessage: Bucket has logging disabled\nLink: [s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "deployment/init_grid/cloudformation/grid_state.yaml",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 67,
                  "startColumn": 1,
                  "endLine": 86,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "deployment/init_grid/cloudformation/grid_state.yaml"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: docs/workshop/Dockerfile\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "docs/workshop/Dockerfile",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "docs/workshop/Dockerfile"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: examples/submissions/k8s_jobs/Dockerfile.Submitter\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "examples/submissions/k8s_jobs/Dockerfile.Submitter",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "examples/submissions/k8s_jobs/Dockerfile.Submitter"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: examples/workloads/c++/mock_computation/Dockerfile.Build\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "examples/workloads/c++/mock_computation/Dockerfile.Build",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "examples/workloads/c++/mock_computation/Dockerfile.Build"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: examples/workloads/java/mock_computation/Dockerfile\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "examples/workloads/java/mock_computation/Dockerfile",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "examples/workloads/java/mock_computation/Dockerfile"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: examples/workloads/java/quant_lib/Dockerfile\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "examples/workloads/java/quant_lib/Dockerfile",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "examples/workloads/java/quant_lib/Dockerfile"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: examples/workloads/python/mock_computation/Dockerfile.Build\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "examples/workloads/python/mock_computation/Dockerfile.Build",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "examples/workloads/python/mock_computation/Dockerfile.Build"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: examples/workloads/python/quant_lib/Dockerfile.Build\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "examples/workloads/python/quant_lib/Dockerfile.Build",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "examples/workloads/python/quant_lib/Dockerfile.Build"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: source/compute_plane/python/agent/Dockerfile.Lambda\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "source/compute_plane/python/agent/Dockerfile.Lambda",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "source/compute_plane/python/agent/Dockerfile.Lambda"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: source/compute_plane/python/agent/Dockerfile.Local\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "source/compute_plane/python/agent/Dockerfile.Local",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "source/compute_plane/python/agent/Dockerfile.Local"
              }
            }
          ]
        },
        {
          "ruleId": "DS026",
          "ruleIndex": 7,
          "level": "note",
          "message": {
            "text": "Artifact: source/compute_plane/shell/attach-layer/Dockerfile\nType: dockerfile\nVulnerability DS026\nSeverity: LOW\nMessage: Add HEALTHCHECK instruction in your Dockerfile\nLink: [DS026](https://avd.aquasec.com/misconfig/ds026)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "source/compute_plane/shell/attach-layer/Dockerfile",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "source/compute_plane/shell/attach-layer/Dockerfile"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: terraform-aws-modules/lambda/aws/iam.tf\nType: terraform\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource '08dc8bb2-e5b3-478e-9e5d-d02a9064d6c4:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/lambda/aws/iam.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 130,
                  "startColumn": 1,
                  "endLine": 130,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/lambda/aws/iam.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: terraform-aws-modules/lambda/aws/iam.tf\nType: terraform\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource '11be5e6e-eedc-422d-be69-4f5aa9e53e28:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/lambda/aws/iam.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 130,
                  "startColumn": 1,
                  "endLine": 130,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/lambda/aws/iam.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: terraform-aws-modules/lambda/aws/iam.tf\nType: terraform\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource '2f226c54-6f2d-454b-9da0-aa1bfe547896:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/lambda/aws/iam.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 130,
                  "startColumn": 1,
                  "endLine": 130,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/lambda/aws/iam.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: terraform-aws-modules/lambda/aws/iam.tf\nType: terraform\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource '5bf0c93e-0bee-47bd-b82d-6107c3423a95:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/lambda/aws/iam.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 130,
                  "startColumn": 1,
                  "endLine": 130,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/lambda/aws/iam.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: terraform-aws-modules/lambda/aws/iam.tf\nType: terraform\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource 'a64b0897-3644-42e4-bc9f-418cd15ede0d:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/lambda/aws/iam.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 130,
                  "startColumn": 1,
                  "endLine": 130,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/lambda/aws/iam.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0057",
          "ruleIndex": 1,
          "level": "error",
          "message": {
            "text": "Artifact: terraform-aws-modules/lambda/aws/iam.tf\nType: terraform\nVulnerability AVD-AWS-0057\nSeverity: HIGH\nMessage: IAM policy document uses sensitive action 'logs:CreateLogGroup' on wildcarded resource 'df72e57f-3373-4d89-a731-ecde18753d1d:*'\nLink: [AVD-AWS-0057](https://avd.aquasec.com/misconfig/avd-aws-0057)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/lambda/aws/iam.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 130,
                  "startColumn": 1,
                  "endLine": 130,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/lambda/aws/iam.tf"
              }
            }
          ]
        },
        {
          "ruleId": "s3-bucket-logging",
          "ruleIndex": 3,
          "level": "note",
          "message": {
            "text": "Artifact: terraform-aws-modules/s3-bucket/aws/main.tf\nType: terraform\nVulnerability s3-bucket-logging\nSeverity: LOW\nMessage: Bucket has logging disabled\nLink: [s3-bucket-logging](https://avd.aquasec.com/misconfig/s3-bucket-logging)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/s3-bucket/aws/main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 25,
                  "startColumn": 1,
                  "endLine": 34,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/s3-bucket/aws/main.tf"
              }
            }
          ]
        },
        {
          "ruleId": "AVD-AWS-0178",
          "ruleIndex": 8,
          "level": "warning",
          "message": {
            "text": "Artifact: terraform-aws-modules/vpc/aws/modules/vpc-endpoints/main.tf\nType: terraform\nVulnerability AVD-AWS-0178\nSeverity: MEDIUM\nMessage: VPC Flow Logs is not enabled for VPC\nLink: [AVD-AWS-0178](https://avd.aquasec.com/misconfig/avd-aws-0178)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "terraform-aws-modules/vpc/aws/modules/vpc-endpoints/main.tf",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 28,
                  "startColumn": 1,
                  "endLine": 51,
                  "endColumn": 1
                }
              },
              "message": {
                "text": "terraform-aws-modules/vpc/aws/modules/vpc-endpoints/main.tf"
              }
            }
          ]
        }
      ],
      "columnKind": "utf16CodeUnits",
      "originalUriBaseIds": {
        "ROOTPATH": {
          "uri": "file:///github/workspace/"
        }
      }
    }
  ]
}

Thanks for posting the SARIF. The problem is that Code scanning does not support the originalUriBaseIds field. This means that the first result object:
        {
          "ruleId": "AVD-AWS-0066",
          "ruleIndex": 0,
          "level": "note",
          "message": {
            "text": "Artifact: \nType: cloudformation\nVulnerability AVD-AWS-0066\nSeverity: LOW\nMessage: Function does not have tracing enabled.\nLink: [AVD-AWS-0066](https://avd.aquasec.com/misconfig/avd-aws-0066)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "",
                  "uriBaseId": "ROOTPATH"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 1,
                  "endLine": 1,
                  "endColumn": 1
                }
              },
              "message": {
                "text": ""
              }
            }
          ]
        },

contains an empty URI and therefore cannot be processed by code scanning.
Note: even with originalUriBaseIds it seems to point to a directory and not a file, so I am unsure what that means in terms of the result.

Hi @starcke !
According to the documentation:

You can check a SARIF file is compatible with code scanning by testing it against the GitHub ingestion rules. For more information, visit the Microsoft SARIF validator.

SARIF reports with an empty artifactLocation.uri successfully pass validation at https://sarifweb.azurewebsites.net/Validation, which, according to the documentation, confirms their compatibility with GitHub Code Scanning. However, uploading such reports via the github/codeql-action/upload-sarif action results in an error, indicating a potential mismatch between the validation process and the actual handling of SARIF files by GitHub.

Hi @nikpivkin
That is unfortunate, but I am afraid we do not maintain the web-based validation. I see you already found the place to report it.
It is unlikely we'll be able to handle these cases as we need the URI to determine which file to attach the finding to.


[RUN-3019] Make gReplayScript testable: Enable gReplayScript features when recording

https://linear.app/replay/issue/RUN-3019/make-greplayscript-testable-enable-greplayscript-features-when

Hum...

I feel like we can improve the name replay-only-gReplayScript.
Also, we want to expose the IsGReplayScriptEnabled logic to more places, where we guard features behind an IsReplaying flag, such as our force-variable-context-allocation modifications.


Use sphinx for documentation

Our docs are currently a few markdown files hosted inside this repository. It'd be easier for users to find information (via search, table of contents) if this was instead rendered by sphinx (or some other documentation tool).
This could initially be hosted on readthedocs.
/kind documentation

Sounds good. We need a similar thing for cert-manager too.
I’m happy with Sphinx, or if we can keep it simple with something like
Jekyll/Hugo then that works for me too. It’d be great if a semi reusable
pattern can be invented for all of our OSS projects.
My one big requirement is that they must be versioned. Ideally with a drop
down menu somewhere (or similar) that lets users switch between different
versions of documentation.
Having a separate repo to host the docs has the added benefit of not tying
docs releases to application releases, which are often slower and more
involved (cherry picking PRs into release branches can become a PITA over
time what with merge conflicts etc). This problem becomes worse/harder if
we also use documentation artefacts as part of our test suites, so I’d be
okay with not doing that, especially initially (perhaps we could have e2e
suites for our documentation too, but separate from the main e2e suite for
navigator).
On Wed, 28 Feb 2018 at 11:41, Louis Taylor<EMAIL_ADDRESS>wrote:

Our docs are currently a few markdown files hosted inside this repository.
It'd be easier for users to find information (via search, table of
contents) if this was instead rendered by sphinx (or some other
documentation tool).
This could initially be hosted on readthedocs.
/area documentation
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jetstack/navigator/issues/268, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbPybFuOD7OvN93yvrjcfVT0NysLPeks5tZTtQgaJpZM4SWhBl
.

Readthedocs makes the documentation versioned by default (based off the git tag), so I think we're okay there.
I'd rather keep the docs in-tree, since it makes reviewing feature+associated documentation easier, and it's apparent which version of the codebase the documentation is referring to.

We're now on readthedocs here: http://navigator-dbaas.readthedocs.io/en/latest/
Still to do: set up the webhook to do automated builds, maybe move to a domain like navigator.jetstack.io


Make the summary of the architecture more general

This is an architecture for modern webapps
Will still work on iOS, just not with Service Worker
Try not to emphasise the SW part as much as we do

This was done in the write-ups we're getting out later. Incoming refactor of readme.


GraphQL compiler errors inconsistent with regular compiler errors

For example, this is a compiler error I got for a GraphQL service:
ERROR [test2.bal:(12:5,14:6)] Invalid GraphQL union type member. Only distinct service types are allowed

For compiler errors (including for compiler plugins provided by the Ballerina platform) the convention we have used is to start the message with a lower case letter. The above will look inconsistent, especially in the presence of other errors which adheres to the regular convention. e.g.,
ERROR [test2.bal:(12:5,14:6)] Invalid GraphQL union type member. Only distinct service types are allowed
ERROR [test2.bal:(6:42,6:43)] invalid resource parameter type: future<int>

Completed via #1149


Mixin args into kwargs earlier in template()

In short: @view('some_template', template_lookup='./app/my_vews') won't work
I want to add a lookup-path for templates in my app, so I hook view and add temlate_lookup to kwargs but it doesn't work.
from . import bottle
from .bottle import route, request, response

from . import config

view = functools.partial(bottle.view, template_lookup=[config.PATH + '/pages'])

This patch fix the problem by mixin args earlier.

Good find, nice fix. Thanks.


boost SHA512 mismatch

Expected:
a1c7338e2d2dbac8552ede7c554640d22cbb2fda7fbc325dc3cdcb51e769713626695426ffc158cbe0e1729dd9a7b5ad18af4800d74e24539e8d8564268c2b9d
Current:    CF83E1357EEFB8BDF1542850D66D8007D620E4050B5715DC83F4A921D36CE9CE47D0D13C5D85F2B0FF8318D2877EEC2F63B931BD47417A81A538327AF927DA3E

I had cleaned my build folder several times, and tried to install boost several times. Each time returning with the same incorrect hash. Tried one more time and everything works. Goblins in the wires or something. So thanks for having hash checks.

Yeah, Sourceforge is really problematic. Hopefully #83 will help with this!


[$500] All - Settings - Red dot remains after error is cleared

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/31713
Action Performed:
Pre-requisite: user must be logged in

On staging, enable "Simulate failing network requests" in Settings > Preferences
Go to Settings > Profile > Contact method
Add a phone number as a new contact method
Wait for the pending add operation to fail
Once you see the red dot, click on the contact method and clear the error

Expected Result:
The red dot should disappear after the error is cleared
Actual Result:
The red dot remains on user avatar on the home screen and in settings
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] Windows: Chrome
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/12fb6405-23e2-4fe2-99ac-b11d63ce21b5
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012ec660a67cb6d223
Upwork Job ID:<PHONE_NUMBER>937179136
Last Price Increase: 2023-12-20

Proposal
Please re-state the problem that we are trying to solve in this issue.
All - Settings - Red dot remains after error is cleared
What is the root cause of that problem?
In deleteContactMethod, we are clearing errorFields.deletedLogin but we aren't clearing errorFields.addedLogin which is a part of the failureData of addNewContactMethodAndNavigate.
When we delete a contact method, we expect a green dot to show up while the deletion is being processed, this is added intentionally by using pendingFields.deletedLogin: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE as shown below in the code, however this green dot is override by red dot because of errorFields.addedLogin
https://github.com/Expensify/App/blob/fe2d0d1ca481a05ad281e4bea85f31b11b88a817/src/libs/actions/User.js#L186-L200
What changes do you think we should make in order to solve the problem?
We should clear that errorField on contact method deletion so the red dot doesn't show up during the deletion process
function deleteContactMethod(contactMethod, loginList) {
    ....
    value: {
        [contactMethod]: {
            ....
            errorFields: {
                deletedLogin: null,
                addedLogin: null,
            },

Result
https://github.com/Expensify/App/assets/74202751/b09cd38c-32d3-45e9-97a6-e33bbed29a1f

Proposal
Please re-state the problem that we are trying to solve in this issue.
Red dot remains after error is cleared when network connection is simulating slow network requests
What is the root cause of that problem?
The root cause of the problem is that in Contact Page there is an additional check which hides new contact requests with pendingAction "delete".
const hideChildren = shouldHideOnDelete && !isOffline && pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !hasErrors;

However, this check is missing from userUtils "hasLoginListError" function.
function hasLoginListError(loginList: Record<string, Login>): boolean {
    return Object.values(loginList).some((loginData) => Object.values(loginData.errorFields ?? {}).some((field) => Object.keys(field ?? {}).length > 0));
}

What changes do you think we should make in order to solve the problem?
Logic on both ends should be kept consistent so I would suggest we implement the same checks in userUtils and call it. This will maintain the DRY principle as well as is easier to maintain.

What alternative solutions did you explore? (Optional)
N/A

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0163c31a5a31c72f3f

@ntdiary Any feedback on my proposal?

@ntdiary My solution to begin with has been adding addedLogin: null in the optimisticData, sure alternatively we could make it errorFields: null, with that being said though, essentially addedLogin is probably the only error field here that will be affecting the behaviour in the context of this component. is the suggestion to update proposal to errorFields: null exclusive to @tienifr?

🚀

@ntdiary do we feel good about the latest proposal from @tienifr ?

Let's get this moving forward if so, as it's blocked

@tienifr @ntdiary can you please take a look into https://github.com/Expensify/App/issues/34758 and check if it's related ? cc @dangrous

Hi! I just wanted to call it out here - I'm closing out https://github.com/Expensify/App/issues/34758 as not a bug, but I'm pretty sure it means that QA was never able to successfully QA this issue. It would be great if y'all could make sure this works as expected on this issue!

@ntdiary let's do the bugzero checklist here

Next step is with @ntdiary to do the regression steps

cc @miljakljajic can you please proceed with the payment on this issue? Thanks!

Paid and paid!


python3Packages.tablib: 0.12.1 -> 1.0.0

Motivation for this change
noticed it was broken reviewing  #79060
did some cleanup as well
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

unfortunately pandas 1.0.0 got merged between me reviewing the other PR and this one, which makes these all broken

@GrahamcOfBorg build python3Packages.tablib python38Packages.tablib

darwin failure unrelated to PR


⚠ ClamAV has degraded performance

In 9981ae2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 81 ms

Resolved: ClamAV performance has improved in 5f20442 after 8 minutes.


fix warnings

Leading whitespaces before Go directives in comments.
Incorrect usages of fmt.Printf, fmt.Println, and similar formatting and printing functions.
Redundant parentheses in expressions and types.
Types in variable and constant declarations that can be omitted since they can be inferred by the compiler. Such types are redundant, omitting them may improve readability of the code.
Type conversions that may be omitted.
Aliases of imported packages that may be omitted.

Thanks for the cleanup, it all looks reasonable to me. Were the changes recommended by some utility?

Thanks for the cleanup, it all looks reasonable to me. Were the changes recommended by some utility?

I don't know exactly. I'll show you how I do it. I use goland.

enter the inspection code
I get this result

Use with care.
I don't agree with all the recommendations.


(DRAFT) Fix input for macro_rules generated proc-macro

This PR fixed a bug which rustc insert Group with Delimiter::None for macro_rules generated proc-macro call.
No test is added for this PR because it is quite convoluted to add such a test.
Fixes #7787
[edit]
Just tested in bunt crate, didn't work, convert it to draft.

Hmm, the code in rustc does seem to do the same thing, it looks like it's surrounding each macro argument that comes from metavariables like $tt in a Delimiter::None group. Not sure how it handles repetition though.

Hmm, the code in rustc doesn't seem to do the same thing, it looks like it's surrounding each macro argument that comes from metavariables like $tt in a Delimiter::None group. Not sure how it handles repetition though.

Then it is very complicated to solve. We lost all meta variables related information after expansion. (TokenMap only provide information of Origin but not meta variable)
Maybe we could add these information in TokenMap but it is not trivial to do.
Let close it first.


Powers active when unchecked, inactive when checked

Using Foundry v11.302, HERO system 3.0.0-alpha.
Steps to reproduce:

Create new PC.
Import Streak.hdc (see attached zip file).
In the Attacks tab, roll the "Flurry Of Blows I" attack. It lists the Effective Strength of 65. This is incorrect.
In the Powers tab, click on the Active box for "21) Push It! Push It Good!". It unchecks and immediately rechecks itself.
Roll the "Flurry Of Blows I" again, this time the Effective Strength is 20. This is the correct value.
Uncheck the Active box for "21) Push It! Push It Good!".
Roll the "Flurry Of Blows I" attack. It lists the Effective Strength of 65. This is incorrect.

Streak.zip

All powers default to ON.  Push It! Push It Good! is adding STR+45.   20+45 = 65 STR.  I see there is a totaling options dropdown.  Perhaps I can use that to default the power to off.

Confirmed the toggles are glitchy.

Fix will be included in 3.0.1-alpha release.


NullReferenceException when using the simulator

Environment

Source of VRTK: Github
Version of VRTK: eb55971012b6b4d550105b04f02c4f4340bcba60
Version of Unity3D : 5.6.1p3
Hardware used: Vive
SDK used: SteamVR / Simulator

Steps to reproduce
Use the simulator from the SDK switcher
Expected behavior
Can look up & down
Current behavior
Looking is limited to left & right accompanied by a NRE:
NullReferenceException: Object reference not set to an instance of an object
VRTK.SDK_InputSimulator.UpdateRotation () (at Assets/VRTK/SDK/Simulator/SDK_InputSimulator.cs:365)
VRTK.SDK_InputSimulator.Update () (at Assets/VRTK/SDK/Simulator/SDK_InputSimulator.cs:250)

I can't recreate this.
I'd recommend re-downloading and double checking your installation.

I was getting this error, then updated to the latest last night and I still get the error (Different line).
@bddckr noticed the issue with @virror 's PR - something to do with the prefab not having a neck.

Yeah @virror only updated the SDKSetups prefab that is used in the example scenes, so anyone using the Simulator prefab directly will need to wait for @virror's fix 😄

ah right ok, so the simulator in the example scene works because it's part of the SDK Setup prefab, but the simulator camera rig prefab is broken?

@thestonefox Exactly.

PR with fix https://github.com/thestonefox/VRTK/pull/1302


[BUG] refine-nextjs-router is incompatible with nextjs ^12.0.3

First of all, thank you for your great work~
Describe the bug
refine-nextjs-router is incompatible with nextjs ^12.0.3
To Reproduce

npx superplate-cli xsky-asst
Select your project type › refine-nextjs
Edit package.json, set next version to ^12.0.3
yarn install
yarn dev

Screenshots

Server Error
TypeError: Cannot read properties of null (reading 'push')

This error happened while generating the page. Any console logs will be displayed in the terminal window.
Call Stack
useHistory
<EMAIL_ADDRESS>(44:25)
NextRouteComponent
<EMAIL_ADDRESS>(134:21)
processChild
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/react-dom/cjs/react-dom-server.node.development.js (3353:14)
resolve
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/react-dom/cjs/react-dom-server.node.development.js (3270:5)
ReactDOMServerRenderer.render
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/react-dom/cjs/react-dom-server.node.development.js (3753:22)
ReactDOMServerRenderer.read
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/react-dom/cjs/react-dom-server.node.development.js (3690:29)
Object.renderToString
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/react-dom/cjs/react-dom-server.node.development.js (4298:27)
Object.renderPage
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/next/dist/server/render.js (621:45)
Object.defaultGetInitialProps
file:///Users/weiyang/Ones/fun/xsky-asst/frontend-ng/xsky-asst/node_modules/next/dist/server/render.js (301:51)
Function.getInitialProps
node_modules/next/dist/pages/_document.js (145:19)

Desktop (please complete the following information):

OS: MacOS Monterey
Browser: Chrome
Version: 95.0.4638.69

Hey @wy-z ,
We've released<EMAIL_ADDRESS>Could you approve this issue fixed?

<EMAIL_ADDRESS>worked for me, thanks again!

I've just bootstrapped refine from the documentation tutorial https://refine.dev/docs/getting-started/overview/#quick-start and selected Airtable as the provider. It then gave me a similar error as above. I saw that the router in the starter is not set to that version but I still get the error even after I changed it manually.

Error

error - TypeError: Cannot read properties of null (reading 'push')
    at useHistory (/home/jonathan/projects/live-tabs/tutorial/node_modules/@pankod/refine-nextjs-router/dist/refine-nextjs-router.cjs.development.js:44:25)
    at NextRouteComponent (/home/jonathan/projects/live-tabs/tutorial/node_modules/@pankod/refine-nextjs-router/dist/refine-nextjs-router.cjs.development.js:134:21)
    at processChild (/home/jonathan/projects/live-tabs/tutorial/node_modules/react-dom/cjs/react-dom-server.node.development.js:3353:14)
    at resolve (/home/jonathan/projects/live-tabs/tutorial/node_modules/react-dom/cjs/react-dom-server.node.development.js:3270:5)
    at ReactDOMServerRenderer.render (/home/jonathan/projects/live-tabs/tutorial/node_modules/react-dom/cjs/react-dom-server.node.development.js:3753:22)
    at ReactDOMServerRenderer.read (/home/jonathan/projects/live-tabs/tutorial/node_modules/react-dom/cjs/react-dom-server.node.development.js:3690:29)
    at Object.renderToString (/home/jonathan/projects/live-tabs/tutorial/node_modules/react-dom/cjs/react-dom-server.node.development.js:4298:27)
    at Object.renderPage (/home/jonathan/projects/live-tabs/tutorial/node_modules/next/dist/server/render.js:596:45)
    at Function.getInitialProps (/home/jonathan/projects/live-tabs/tutorial/.next/server/pages/_document.js:618:19)
    at Object.loadGetInitialProps (/home/jonathan/projects/live-tabs/tutorial/node_modules/next/dist/shared/lib/utils.js:69:29) {
  page: '/[resource]'
}

I have only added one resource and followed the tutorial at https://refine.dev/docs/#creating-a-list-page

Hey @IgnusG,
Could you delete package-lock and node_modules and try "npm i" again?

Seems that the error stayed the same :(

Seems that the error stayed the same :(

Could you try again create a new project with superplate?

Seems that the error stayed the same :(

Could you try again create a new project with superplate?

Works now! Thanks for the support :)


Fix RedundantInitialize warning about RedundantCopDisableDirective #11025

Fixes https://github.com/rubocop/rubocop/issues/11025
When AllowComments is enabled for RedundantInitialize, then the presence of any comments will bypass finding an error. This is true even if the comment is a disable directive. This causes no offense to be recorded and when RedundantCopDisableDirective is run it will then erroneously report an error. This PR will check to see if the comments contain a disable before bypassing the inspection.
A question I have is where to add a test for this. This issue occurs when the two cops are run together. RedundantCopDisableDirective spec uses fake locations for the offenses and RedundantInitialize spec only checks itself.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Can you add a repro test?

@koic done 👍

@HeroProtagonist This looks good. Can you squash your commits into one?

@koic squashed!

@HeroProtagonist Thank you!


[Q] LB service host ports

Sorry if this has been asked before, but I couldn't find previous issues or documentation that explain this.
I have the Rancher load balancer (rancher/server:v1.6.4 and rancher/lb-service-haproxy:v0.7.5) set up to forward port 443 to a service. This works correctly but I am unsure how it is working.

docker ps does not show host port 443 being routed to the LB container.
Host commands like ss and netstat do not show that any process is listening on 443.
iptables shows no rules for port 443.

I am confused as to how I can successfully connect to my host on 443 externally without seeing it explicitly being routed on the host.

Turns out iptables does show the rules, I just wasn't looking in the right place.
Rancher puts its stuff in a CATTLE_PREROUTING chain, and you need to look at the NAT table to see these.
iptables -L -nt nat will show them.

@cavemandaveman sounds like you've solved it on your own... safe to close?

Yes, thank you.


[AST] [ERROR] parser /app/Bus/AuthBus.php SyntaxError

System and Python Environment

Item
Tooltip
Value

System
uname -a
Linux localhost.localdomain 3.10.0-1160.el7.x86_64 #1 SMP Mon Oct 19 16:18:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Python
python -V
Python 3.6.1

Cobra
python kunlun.py
v2.6.5

Description
AST解析错误，这是因为啥？

就是那个页面在ast化爆语法错误了，有可能是有不支持的语法


BitFinex open orders returns 0

I seem to have a [BUG REPORT]
I'm trying to get my open orders from BitFinex by using the GetOpenOrderDetailsAsync method. This always returns 0 open orders, even though there are open order on BitFinex.
The exact same method works fine for Binance.
The API keys are correct, for I am able to get a result from the GetAmountsAsync method from BitFinex.
Is this a bug or is there something I'm not thinking of here?

Do you use symbol argument or try to fetch all the orders? May be it's a problem with symbol normalizing and futher comparison. Try to debug and see is there any nonnull return value after request here:
https://github.com/jjxtra/ExchangeSharp/blob/b7680f7e040a1dca172c778e32fb5c09966a7c57/ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs#L707

Closing due to inactivity. Feel free to re-open this issue if you have further input.


Make sure all affected jobs are killed on node disconnects

Previously we run the broadcastKillToParticipatingNodes logic only if
the node that was killed didn't coordinate any jobs at all. But it's
necessary to always run that to ensure there are no stuck jobs.

Codecov Report

Merging #6911 into master will decrease coverage by 0.04%.
The diff coverage is 62.5%.

@@             Coverage Diff              @@
##             master    #6911      +/-   ##
============================================
- Coverage     83.17%   83.12%   -0.05%
+ Complexity    13299    13292       -7
============================================
  Files          1527     1527
  Lines         49375    49385      +10
  Branches       5940     5942       +2
============================================
- Hits          41067    41052      -15
- Misses         5524     5546      +22
- Partials       2784     2787       +3

Impacted Files
Coverage Δ
Complexity Δ

...obs/transport/NodeDisconnectJobMonitorService.java
75.67% <62.5%> (-13.22%)
11 <5> (+1)

...main/java/io/crate/auth/user/AlterUserRequest.java
47.36% <0%> (-42.11%)
5% <0%> (-2%)

...in/java/io/crate/lucene/match/CrateRegexQuery.java
43.47% <0%> (-30.44%)
4% <0%> (-4%)

...io/crate/protocols/postgres/types/VarCharType.java
70.83% <0%> (-20.84%)
9% <0%> (-1%)

...execution/dsl/projection/MergeCountProjection.java
66.66% <0%> (-11.12%)
5% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
87.17% <0%> (-10.26%)
2% <0%> (ø)

.../io/crate/execution/dsl/projection/Projection.java
90% <0%> (-10%)
6% <0%> (-1%)

...main/java/io/crate/blob/v2/BlobIndicesService.java
68.05% <0%> (-6.95%)
20% <0%> (-3%)

...ava/io/crate/execution/engine/BucketForwarder.java
86.11% <0%> (-5.56%)
9% <0%> (-1%)

...ution/engine/distribution/ModuloBucketBuilder.java
73.68% <0%> (-5.27%)
10% <0%> (-1%)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac5c2cb...8a81b28. Read the comment docs.


Add "role" key to webview property.

this.props.role is used in webview.js but role key was missing in the webview properties.
Simple fix, GTM.

We are already passing the role to the tabs. Do we really need this?

Yeah, it's being used at one place in webview.js, which now shows undefined behavior, and webviews don't have access the properties of the tabs. If they can then it won't be required, but this is a simple solution than trying that in a very complicated way.

Thanks, @abhigyank.


docs: link to 1.0 README until 2.0 is published

The README currently has usage documentation for an unreleased version of this module. It should be updated to link to the existing 1.0 usage doc in the readme.
Fixes: https://github.com/cloudevents/sdk-javascript/issues/174
Signed-off-by: Lance Ball<EMAIL_ADDRESS>

Closing. Made obsolete by the release of 2.0.0


Change Elasticsearch backend configuration key

logstashElasticHost is not used in code base, only 'logstashElasticHosts'

Thanks, this changed when the elastic library we used was updated. The new elastic library takes a set of hosts, and learns about the rest of the cluster from that set (i.e. hosts that have been removed or added).


Add README for our Kubernetes Infrastructure

(add more detail)
Helm Playbook #196
Infrastructure setup  #173 #172
Document our processes and approaches so that others can potentially use

@earth2travis there was some talk about us not using this moving forward. We may want to revisit that conversation and then close this out if we're moving away from it


fix: remove print statements in except block

The print statement results in unwanted console output. It's not controllable. Since in the client there is no logger, no printing is better than print(e).
In projects using this client such statements are rather annoying.

I agree the CLA


[BLOCKING] AppBuilder().automaticBuildAndRun broken on windows

[Details]
the AppBuilder().automaticBuildAndRun method is brokn on windows
[Stacktrace]
PS C:\Users\Home\Documents\deno-tutorial> deno run --allow-net --allow-read --allow-write --allow-env --allow-run -c tsconfig.json --unstable  src/mandarine/app.ts
Download<EMAIL_ADDRESS>error: Unsupported scheme "c" for module "c:UsersHomeDocumentsdeno-tutorialsrcmandarineapiapi.controller.ts". Supported schemes: [
    "http",
    "https",
    "file",
]
Imported from "file:///C:/Users/Home/Documents/deno-tutorial/.mandarine_target/target.ts:2"

[Scenario]
Steps to reproduce the behavior:

Create a new mandarine project in windows
Use the automatic app builder
run it

[Expected behavior]
It would start
[Screenshots]
If applicable, add screenshots to help explain your problem.
![https://cdn.discordapp.com/attachments/727894026606608414/772003980452560966/unknown.png]
[OS]
Windows 10
[Environment]

Mandarine version: 2.2.0
Deno version: 1.4.6
Deno v8 version: <IP_ADDRESS>
Deno typescript version: 4.0.3

[Additional]
Took a look in target.ts and it seems to be that the directories are wrong

Fix released in 2.2.1 https://github.com/mandarineorg/mandarinets/releases/tag/v2.2.1

Seems like this hasn’t been fixed for some windows. Reopining


Upgrade to react-15.0

npm test runs fine.

@bdwain thanks for pull request, given https://facebook.github.io/react/blog/2016/04/08/react-v15.0.1.html should depend on ^15.0.1 instead ?

It should pull in the latest version anyway according to the semver. the ^ specifies >= 15.0.0 < 16.0.0

Right - thanks

thanks @kasperp . any chance you can publish this change soon so it can be used?

Yeah - I'll get a release ready


Make SystemIdMarker reflect-able

Make SystemIdMarker reflect-able.

You need to register the type as well. Automatic registering types is not landing yet iirc

Thats true, there is almost automatic registering based on recursive registering, but thats that

You need to register the type as well. Automatic registering types is not landing yet iirc

I had a discussion about this on the discord and the conclusion seemed to be to dynamically register it when needed.
If I were to register it manually where would that be?

Normally, the plugins register all the types they need to use.
but with bevy_ecs thats another subject, you should probably leave it as it is and register it yourself. bevy_ecs doesn't seem to register directly any of its types


Convert common TeX to unicode

I set it up here, and noticed a few TeX artifacts.
I would suggest at least converting two dashes (--) to an en-dash (–) as those are very common and hard to type.

PR #17 starts working on this (see below). Should tag v0.1.1 or v0.2.0 shortly after it's merged.
@simonbyrne Do you know of a list of these kinds of replacements or should we just add to it as we go along?
I was able to find lists for math TeX to unicode (https://github.com/svenkreiss/unicodeit/blob/master/unicodeit/data.py) but not so much for text TeX to unicode.

I agree we probably don't want the full unicodeit list, as it seems to include both math and text commands

This is due to spurious spaces being inserted by the BibTeX parser. Upstream issue is https://github.com/Azzaare/BibParser.jl/issues/5.

Should we leave this open until the upstream is closed?

Yes, probably a good idea.

Hi there! Sorry for the long wait, spurious braces should not be a problem anymore.
It might only be a crude parser that I handcrafted, but BibParser.jl got updated today (v0.1.11)
(the new parser should handle any valid BibTeX entry, but do not replace LaTeX commands from a @preamble nor converts LaTeX to Unicode)

I've created a GitHub repo to convert LaTeX ⇋ Unicode: https://github.com/Humans-of-Julia/LaTeXUniCode.jl
It is almost empty at the moment, but I will work on it during summer (as I will be in between two jobs, I can have some fun!)
Anyway, if some of you want to join, you're all welcome aboard.

The function tex2unicode is there, but it does not seem to be applied to pages, which is where I see them most often:
pages = {1 -- 45},

Could this be done?

tex2unicoe is currently only applied to title?
https://github.com/ali-ramadhan/DocumenterCitations.jl/blob/886bbb740ea2f814ec67e321e61ae16149e58fc2/src/bibliography.jl#L50-L54
Or am i misunderstanding it?

No you are right. Hmm, I thought I'd made a PR also applying it to the output of xin... guess I forgot :/

I converted all my .bib files ti Unicode therefore i did nor realize that applying it to the authors and maybe published_in might fix it to others.

Reopening this. We're still seeing issues, e.g. Jo { \~a } o Teixeira, over at the ClimateMachine.jl refs.

@charleskawczynski Is { \~a } valid Tex? As far as i know in order to get ã one have to use \~{a} or even \tilde{a} (not sure if the later one is supported by bibtex).
Source: https://en.wikibooks.org/wiki/LaTeX/Special_Characters#Escaped_codes


build: TestQueryContext flake on linux-amd64-race

https://storage.googleapis.com/go-build-log/588411a7/linux-amd64-race_a24d74de.log
cc @kardianos

@kardianos, dup of #19024? But https://go-review.googlesource.com/c/36794/ doesn't skip this one.


Some static features are in the query-document feature set

Move the following features into the static document feature set since they can all be precomputed and don't depend on the query (note that url slash count and url length are already there, but they need to be removed from doc_entry and friends):
    // The number of times the <title> tag appears in the document
    int tag_title_count = 0;
    // The number of times the <heading> tag appears in the document
    int tag_heading_count = 0; // Indri heading field includes tags h1-h4
    // The number of inlinks in the document
    int tag_inlink_count = 0;
    // The number of times the <applet> tag appears in the document
    int tag_applet_count = 0;
    // The number of times the <object> tag appears in the document
    int tag_object_count = 0;
    // The number of times the <embed> tag appears in the document
    int tag_embed_count = 0;

    // Number of slashes in URL
    int url_slash_count = 0;
    // URL length
    size_t url_length = 0;

To add to this, f_url_slash_count is output via the config.ini according to the documentation, but f_url_length was omitted. So if one is using a config copied from the documentation you will see this behaviour.


The dependency on the "CanvasProxyInteractor" is not made clear at all

Describe the issue
We ran in to some very odd issues with the MRTK UX, to the point where null reference exceptions where appearing sporadically as the UI was being hovered over or interacted with.
On investigation, ALL of the errors were due to the absence of the "CanvasProxyInteractor" being active in the scene.
Feature area
If a component, such as the "CanvasProxyInteractor" interactor is required for features to work within a MRTK scene, then it both needs to:

Be identified by components that rely on it (e.g. a UX component on a Canvas using a "UGUI input adapter") should highlight that a dependency is missing from the scene, be it a "CanvasProxyInteractor" or another "IProxyInteractor" style class
Documentation needs to be clearer to STATE that such a component needs to be in a scene if it is a depdendency.

Do you have a callstack from any of the null reference exceptions?

LMGTFY
Two exception stacks I can offer after breaking the solution again (disabling the CanvasProxyInteractor"
NullReferenceException: Object reference not set to an instance of an object
Microsoft.MixedReality.Toolkit.UX.UGUIInputAdapter.OnPointerEnter (UnityEngine.EventSystems.PointerEventData pointerEventData) (at Library/PackageCache/com.microsoft.mrtk.uxcore@421d14e45036/Interop/UGUIInputAdapter.cs:195)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerEnterHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:22)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:262)
UnityEngine.XR.Interaction.Toolkit.UI.UIInputModule:Update() (at Library/PackageCache/com.unity.xr.interaction.toolkit@2.0.0/Runtime/UI/UIInputModule.cs:111)

NullReferenceException: Object reference not set to an instance of an object
Microsoft.MixedReality.Toolkit.UX.UGUIInputAdapter.OnDeselect (UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/com.microsoft.mrtk.uxcore@421d14e45036/Interop/UGUIInputAdapter.cs:270)
Microsoft.MixedReality.Toolkit.UX.UGUIInputAdapter.OnPointerExit (UnityEngine.EventSystems.PointerEventData pointerEventData) (at Library/PackageCache/com.microsoft.mrtk.uxcore@421d14e45036/Interop/UGUIInputAdapter.cs:211)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerExitHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:29)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:262)
UnityEngine.XR.Interaction.Toolkit.UI.UIInputModule:Update() (at Library/PackageCache/com.unity.xr.interaction.toolkit@2.0.0/Runtime/UI/UIInputModule.cs:111)

Both are caused by the same effect, as the "protected IProxyInteractor ProxyInteractor" lookup fails to find any registered "IProxyInteractors" active in the scene and just returns NULL, causing ANY events requesting it to cause a NullReference check.  This would in theory affect any of the events in the "UGUIInputAdapter".
What I do not understand is what the failure is sporadic, does not always occur and will raise an exception on one "StatefulInteractable" object and not another.
But handling the null reference failure is also wise @keveleigh  :D

Thanks for the call stacks! CC @Zee2

@SimonDarksideJ, well aware of this; will be fixed in an upcoming update. UGUIInputAdapter will gracefully fallback if no proxy interactor is available.
In addition, we're going to be baking the proxy interactor into the default rig prefab to help avoid these points of confusion in the future!

Fixed in #10711.

Fixed in #10711.

@Zee2 just to clarify, I'm not sure I see the two potential null refs mentioned above changed in that PR.
It seems like the following two sections would still null ref if ProxyInteractor is null (along with some others as I was looking through), unless your change in that PR prevents these methods from being called?
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/45ea6a3b2a6bd5fef1ff3e1f7b5b8c25416850c9/com.microsoft.mrtk.uxcore/Interop/UGUIInputAdapter.cs#L206-L209
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/45ea6a3b2a6bd5fef1ff3e1f7b5b8c25416850c9/com.microsoft.mrtk.uxcore/Interop/UGUIInputAdapter.cs#L285-L288

You're right that it doesn't technically guard against those nullrefs; but, then again, they'd have very little reason to occur if the proxy interactor was baked into the rig.
I'll open this again for a future PR that'll do more safeguarding/explanation.

NREs resolved here!


Error: stan: connect request timeout StreamingConnection

Hello, I a running a nats docker container and I am using io.nats to connect to it. But when I try creating a StreamingConnection object I get stan: connect request timeout error. I looked at https://github.com/nats-io/stan.go/issues/285 and looked for the cluster id, however I see the nats container doesn't have a streaming module in the .conf file so I'm more or less at a dead-end. I tried using the nats-streaming docker but then I get this error:
Jul 31, 2023 5:16:04 PM io.nats.client.impl.ErrorListenerLoggerImpl exceptionOccurred
SEVERE: exceptionOccurred, Exception: java.net.SocketTimeoutException: Connect timed out
Here is how I have my java code setup inside a static main method:
        String[] servers = {"nats://ruser:T0pS3cr3t@<IP_ADDRESS>:4222"};
	io.nats.client.Options.Builder builder = new io.nats.client.Options.Builder();
        builder.maxReconnects(-1);
        builder.connectionName("fhirNotifications");
        builder.servers(servers);
        io.nats.client.Options natsOptions = builder.build();
        Connection nc = Nats.connect(natsOptions);
        Options streamingOptions = new Options.Builder().natsConn(nc).build();
        StreamingConnection sc = NatsStreaming.connect("my_cluster", "ibm-fhir", streamingOptions);

I did not edit any of the config files just as a sidenote.
If you can point in the right direction that would be very helpful, ty :)

@jordanperrin It looks like you are using the JNATS (nats.io/nats.java) client? What server are you trying to connect to, STAN or NATS?
STAN is completely end of life and not supported, and nats.java does not connect to STAN, just NATS.


feat: secrets, authentication functions, ponies

There's a fair amount here with the individual commit messages telling the story. Some highlights:

Add the concept of before functions to almost all function types. First user-facing before function is an authentication function
Add Cyclone secret field re-encrypting
Cyclone redacts all secret field values (i.e. "secret strings") so they aren't displayed back in any part of the system (i.e. logs, debugging, function output, results, etc.)
Update TypeScript function hinting to support new requestStorage.* functions, authentication function types, etc.
Add new "password" widget kind which uses <input type="password"/> rendering of an attribute value's contents
Add gh to Veritech container for use by asset authors

bors try

bors try

Ok, this puppy's ready for some eyes and a brave merge!

bors merge


Change pub-type to prod

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/di-graph/terraform-config-validator?version=dev:5f0552d800d23b8e2de9502642596471845f88a8

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/di-graph/terraform-config-validator?version=dev:c27f7539536d28404874564bdb825ad1030864e1

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/di-graph/terraform-config-validator?version=dev:c34cd51f53b820d2d7f7f5222ab9d975dafd9dac

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/di-graph/terraform-config-validator?version=dev:c34cd51f53b820d2d7f7f5222ab9d975dafd9dac

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/di-graph/terraform-config-validator?version=1.0.0