Expand Autocomplete Tool

Description
This PR extends the Autocomplete tool to the rest of grammar spec, and builds out additional functionality that improves the UX.
Changes

Supporting HUMAN_GIVE_COMMAND, GET_MEMORY and PUT_MEMORY dialogue types
preprocess_datasets_for_autocomplete.py pulls existing annotations for unannotated commands from datasets, and creates a JSON file serving as the key-value store in backend
autocomplete_postprocess.py postprocesses the annotations, removing extra keys and outputting data in format ready to be used by ground truth and training
Autocomplete README created with instructions to run tool end to end
Template README updated
Example commands removed command_dict_pairs.json
Add route to run postprocessing script and push data to S3 on button click
Fix bug around setState being async
Rename paths
Address bugs and UX requests from hack session testing

The tool is ready for use for internal parse tree annotations.
Fixes # (issue)
#52
Type of change
Please check the options that are relevant.

[x] Bug fix (non-breaking change that fixes an issue)
[x] Proposes a change (non-breaking change that isn't necessarily a bug)
[x] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
https://user-images.githubusercontent.com/19957918/106351742-d4cec500-6292-11eb-891a-0dc0927fe5ab.mov
Testing
Please describe the tests that you ran to verify your changes and how we can reproduce.
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[x] I have added Docstrings and comments to the code.
[x] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[x] New and existing unit tests pass locally with my changes.
[x] I have added relevant collaborators to review the PR before merge.

All comments + issues addressed, merging (pending CI)


[FLINK-19782][python] Remove antlr traces in flink-python

What is the purpose of the change
A user found that we are using antlr in flink-python (with a vulnerability). We are not using antlr in flink-python, there are just some metadata files which were not properly removed from the shading.

Thanks for your review. I'll address the comment and merge the change.


Issue on new update-This is test issue please ignore

Issue on new update-This is test issue please ignore Please

test

test2


Update 1.17 config.toml for release 1.20

Updated config.toml for release v1.20
Versions were updated based on latest patch releases
/hold until 1.20 release day

Thanks @annajung
/lgtm

/approve
Checked this against the patch release list, loaded the netlify preview to check the drop-down worked correctly.

/hold cancel


Create a deb package for hotspotd daemon

Contact a Debian maintainer/developer.
Ask them to have a look at hotspotd and whether it is of any use in the distro.
List down what all changes need to be done to integrate this in Debian.

Tired. Too much work. Won't Fix.


Fix for SR-4683

Consists of adding another case (subscripts) to the code in ASTMangler.cpp, added in 11f66f8ce39b95c62191a6291780b2316b5863bd, that fixed SR-1795.
Resolves SR-4683.
@swift-ci Please smoke test and merge

@greglutz Invoking CI requires privileges.  That said, thanks for the patch, it looks great!
@swift-ci please smoke test

Sorry, I had it indented right initially. I think it went through
  too many busy-body editors.
--Greg

On 4/26/17 5:05 PM, Xiaodi Wu wrote:

  @xwu commented on this pull request.

  In lib/AST/ASTMangler.cpp:
  >        }

} else if (const auto *SDecl = dyn_cast(decl)) {

   Params = SDecl->getIndices();

Drive-by nit: de-indent by two spaces?
—
  You are receiving this because you were mentioned.
  Reply to this email directly, view
    it on GitHub, or mute
    the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/apple/swift","title":"apple/swift","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/apple/swift"}},"updates":{"snippets":[{"icon":"PERSON","message":"@xwu commented on #9046"}],"action":{"name":"View Pull Request","url":"https://github.com/apple/swift/pull/9046#pullrequestreview-34992393"}}}

@greglutz Your patch is crashing in the demangler.  Take a look at test/SILGen/property_abstraction.swift and
test/SILGen/constrained_extensions.swift.

@greglutz Your change looks good. The crashes in the demangler are caused by a bug in the mangler, which is not related to your change. I'll push a fix shortly.

@swift-ci please smoke test

@swift-CI please smoke test

There is one test file which needs to be updated. Here is the diff:
diff --git a/test/SILGen/constrained_extensions.swift b/test/SILGen/constrained_extensions.swift
index d1856d00af..800b220098 100644
--- a/test/SILGen/constrained_extensions.swift
+++ b/test/SILGen/constrained_extensions.swift
@@ -48,7 +48,7 @@ extension Array where Element == Int {
     return e!
   }

-  // CHECK-LABEL: sil @_T0Sa22constrained_extensionsSiRszlE9subscriptSiycfg : $@convention(method) (@guaranteed Array<Int>) -> Int
+  // CHECK-LABEL: sil @_T0Sa22constrained_extensionsSiRszlE9subscriptSiyt_tcfg : $@convention(method) (@guaranteed Array<Int>) -> Int
   public subscript(i: ()) -> Element {
     return self[0]
   }
@@ -119,7 +119,7 @@ extension Dictionary where Key == Int {
     return Dictionary(x: ()).instanceMethod()
   }

-  // CHECK-LABEL: sil @_T0s10DictionaryV22constrained_extensionsSiRszr0_lE9subscriptq_ycfg : $@convention(method) <Key, Value where Key == Int> (@guaranteed Dictionary<Int, Value>) -> @out Value
+  // CHECK-LABEL: sil @_T0s10DictionaryV22constrained_extensionsSiRszr0_lE9subscriptq_yt_tcfg : $@convention(method) <Key, Value where Key == Int> (@guaranteed Dictionary<Int, Value>) -> @out Value
   public subscript(i: ()) -> Value {
     return self[0]!
   }
@@ -153,10 +153,10 @@ extension GenericClass where Y == () {
     set {}
   }

-  // CHECK-LABEL: sil @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxycfg : $@convention(method) <X, Y where Y == ()> (@guaranteed GenericClass<X, ()>) -> @out X
-  // CHECK-LABEL: sil @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxycfs : $@convention(method) <X, Y where Y == ()> (@in X, @guaranteed GenericClass<X, ()>) -> ()
-  // CHECK-LABEL: sil [transparent] [serialized] @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxycfmytfU_ : $@convention(method) <X, Y where Y == ()> (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @inout GenericClass<X, ()>, @thick GenericClass<X, ()>.Type) -> ()
-  // CHECK-LABEL: sil [transparent] [serialized] @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxycfm : $@convention(method) <X, Y where Y == ()> (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @guaranteed GenericClass<X, ()>) -> (Builtin.RawPointer, Optional<Builtin.RawPointer>)
+  // CHECK-LABEL: sil @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxyt_tcfg : $@convention(method) <X, Y where Y == ()> (@guaranteed GenericClass<X, ()>) -> @out X
+  // CHECK-LABEL: sil @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxyt_tcfs : $@convention(method) <X, Y where Y == ()> (@in X, @guaranteed GenericClass<X, ()>) -> ()
+  // CHECK-LABEL: sil [transparent] [serialized] @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxyt_tcfmytfU_ : $@convention(method) <X, Y where Y == ()> (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @inout GenericClass<X, ()>, @thick GenericClass<X, ()>.Type) -> ()
+  // CHECK-LABEL: sil [transparent] [serialized] @_T022constrained_extensions12GenericClassCAAytRs_r0_lE9subscriptxyt_tcfm : $@convention(method) <X, Y where Y == ()> (Builtin.RawPointer, @inout Builtin.UnsafeValueBuffer, @guaranteed GenericClass<X, ()>) -> (Builtin.RawPointer, Optional<Builtin.RawPointer>)
   public subscript(_: Y) -> X {
     get { while true {} }
     set {}

I've managed to construct that file. Should I do the submitting? If
so, as a new pull request, or a modification to my original one?

Just commit onto this branch, or squash and force-push.  Either way, you don't have to open a new pull request for this.

Okay, I guess I've done that (committed onto my SR-4683 branch).
Sorry for my lack of familiarity with git...

@swift-ci please smoke test

Thanks for the fix!


fix($animateCss): avoid flicker caused by temporary classes

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
Adding the temporary classes immediately, while forcing a reflow before starting the animation, could cause flickering. Currently, only ngHide/ngShow animations are affected (but theoretically any future animation relying on tempClasses would be).
See #14015.
What is the new behavior (if this is a feature change)?
The temporary classes are not applied until the animation actually starts, which avoids the flickering.
Does this PR introduce a breaking change?
No. (Since tempClasses was an undocumented, private feature (currently only used for ngHide/ngShow), no other built-in or custom animations will be affected).
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
This is an alternative approach to #15463.
Fixes #14015.

I think that's good.
Ideally, not every drive would have to add the temp classes, but since there are no custom drivers (to my knowledge), this is irrelevant.
Just to clarify, before this change was it possible to use a temporary class to trigger a css animation? I.e. a temporary class applies a transition that makes the animator detect an animation.

Just to clarify, before this change was it possible to use a temporary class to trigger a css animation? I.e. a temporary class applies a transition that makes the animator detect an animation.

It was and it still is. This PR only affects adding the classes in beforeStart(), at which point the animations are determined. The tempClasses are used elsewhere, so this PR does not affect that:
Animaton works with this PR)

Actually, the current ngHide example from the docs doesn't work correctly for the "show" (ng-hide-remove) action with this patch, see https://plnkr.co/edit/tyteqvfPbhcwrBKXpn5c?p=preview
When you comment in the patched angular-animate (copied from you pen), the show action doesn't animate anymore.

😞 It's always possible that I've missed something. If #15463 works, I'm happy to go with that.
I've had too much ngAnimate lately to investigate further 😩

My PR actually has the same problem ... the thing is that the plnkr example I posted puts the actual transition css on the temporary class, which is not something we advocate. I'm not sure where I got this plnkr / css from, maybe an issue or something?
So if we are okay that this way of defining animations is wrong, then we could use this PR.

The question is: Can we fix the issue without breaking the usecase?

I don't think so. The rAF call that causes this is elementary to the way ngAnimate works. Removing it or working around it would probably mean a big rewrite.

In that case, I vote for fixing it with a breaking change (i.e. that animation styles on temporary classes won't work) for 1.7.0.

Bad news: I've re-tested the plnkr with our patches, and even with the regular ngShow / ngHide example from the docs, they don't work for showing: https://plnkr.co/edit/tyteqvfPbhcwrBKXpn5c?p=preview (the current ngAnimate file is active, but use the patches and it doesn't work).
I thought this didn't work because the transition was set on the temporary class, but this is not the case.

Here's the original repro to test again: https://plnkr.co/edit/l70kaJ?p=preview (flickers in IE11)

Yeah, I realized our both our fixes are problematic. I started looking into the issue again 😞

I give up 😱 Unfortunately, I couldn't get to the bottom of this in a reasonable amount of time 😞
It only happens on IE for me (which is not great for debugging :grin:) and there are work-arounds available:

If you don't mind destroying and recreating the view, you can use ng-switch.
If you want to keep the view around (but hidden), you can use ng-class="{'ng-hide': checked}"

In any case, I am going to close this PR, because it breaks a valid usecase, so is not an appropriate fix anyway.


[css classes] cellClass with singleClickEdit duplicates classes on every focus

A grid with editable cells that have cellClass definitions duplicates the classes on every focus when singleClickEdit is enabled.
Here is a modified example from the site to highlight the issue: https://jsfiddle.net/tvtuz6sq/1/
Here is an example of the Firebug DOM inspector and multiple focuses:

thanks. will take a look.

@ceolter Further testing shows it happens regardless of singleClickEdit.
Double clicking around multiple cells, slowly you will start to notice classes duplicating.
It's just more consistent with singleClickEdit enabled.
And welcome back from your holiday!

@Bodom78  thanks for the welcome back!!!
As a workaround, you can consider using cellClassRules, as far as i remember, it is more robust with regards adding / removing classes.
eg cellClassRules = {
   'my-class-black-background': 'true' // expression is true, ie always use this class
}

@ceolter Excellent, cellClassRules works well. I overlooked that property and it will defiantly be useful down the road.

tracked by https://ag-grid.atlassian.net/browse/AG-95

Hi,
We are changing the process and closing all issues with a ticket number since they can be tracked from our pipeline https://www.ag-grid.com/ag-grid-pipeline/
Thanks
===============
If you are an ag-Grid Enterprise Customer, please raise this in our Zendesk support system - contact<EMAIL_ADDRESS>for access. This is our primary channel for Support.
Bugs Raised Here:
We will do a periodic review of GitHub issues for any bugs raised and these can be tracked on our pipeline page: https://www.ag-grid.com/ag-grid-pipeline
Feature Requests/Support Raised Here:
We are reviewing how we process Feature Requests that come from GitHub. We currently have a very full pipeline of work which will be our priority for the coming months.
As a result, we don’t have capacity to take feature requests from GitHub.
We will review this as we move through our current backlog.
Thanks for your understanding.
ag-Grid Team.


Feature request: Hide taskbar icon to system tray

Not even sure if possible, but could there be an option to remove the taskbar icon when the player is shrunk down? As in have the mini player with the controls open and on the desktop but with out having the taskbar icon and instead having it in the system tray.
The taskbar gets extremely full very fast and while i love the mini player just even an option to hide it to the system tray would be a huge quality of life change.

I believe that this is possible.  However it violates Microsoft's design guidelines.
You shouldn't have a window that exists without a TaskBar indicator.  This is one of the reasons Skype for Desktop now doesn't minimize to tray when the window stays open.  It now minimizes normally to your taskbar.
From a design standpoint this makes sense, as if I have nothing on my taskbar I wouldn't expect to see a window floating around the place.
As always up for discussion below, but for now from me.  It's a wontfix

The application already has an icon that it is tied to in the system tray so while it is weird to have duplication of icons one in the sys-tray and one on the task bar i can see where Microsoft is coming from. Having the standard of if its on the desktop it has an icon on the bar makes sense, this prevents computer challenged people from having problems.
On the other hand it is extremely frustrating to have this duplication and clutter. An option to consolidate the icons into one. Just haveing the program tie it self to the system tray icon it already has would be nice. But in the end i can not fault you for stick to the guidelines how ever much i think it causes needless clutter.

Too bad widget/gadgets where more or less nixed making the mini player a gadget would be literally a dream come true :(

Someone made a Rainmeter script for this a while back.  Quick google search should find it if a desktop widget is what you're after 👍

At least there is an option floating around never touched rainmeter either so this will be "fun" to learn.


Branches/stable 1.8

Thank you for contributing to Nginx!
Nginx does not use GitHub for code submissions.
Please visit http://nginx.org/en/docs/contributing_changes.html and follow the instructions there to submit changes.


pylint not  working

When I write PYTHONPATH as the root directory of the project in the .env file, pylint does not work and there is no error message.

Thanks for the bug report, but unfortunately we need some more information from you in order to triage this issue appropriately. Please edit your opening comment by providing a filled-in copy of our issue template. Once you are done please leave a comment to that effect.


Add page weights to concepts -> storage pages

Updates page weights for concepts/storage pages. Matching the current English language sorting:
volumes.md:weight: 10
persistent-volumes.md:weight: 20
projected-volumes.md:weight: 21 # just after persistent volumes
ephemeral-volumes.md:weight: 30
storage-classes.md:weight: 35
dynamic-provisioning.md:weight: 40
volume-snapshots.md:weight: 45
volume-snapshot-classes.md:weight: 46 # just after volume snapshots
volume-pvc-datasource.md:weight: 60
storage-capacity.md:weight: 70
storage-limits.md 80
volume-health-monitoring.md 90
windows-storage.md  100

See Issue 325093.
@natalisucks

/kind cleanup

@chrisnegus GitHub says that there is a merge conflict. It would be great if a rebase is performed.

/sig storage

Did this already get done in a different PR?

It looks like it.
I'm going to close this as complete. Thanks for participating in the docs sprint @chrisnegus!

Sorry I didn't see this sooner. Someone else did the changes intended by this PR. Closing it was right.


Separate context bridge for electron-auth

We have an electron preload script, that exposes some ipc message handling for itwinjs channels on the window, namely core-electron and electron-auth.
Luckily for us, its the same api rn in both and theres no collision, but if there ever arises a time when there is a difference in the apis, it might cause an issue for us. It also really bothers me that we have pretty much the exact same file duplicated across both pkgs. Wondering if we need to consolidate, have an electron-common pkg or some shim. Also wondering if maybe core-electron takes a dep on electron-auth or vice versa. Just food for thought, something Id like to discuss further with our electron experts

My two cents (not really what you guys were talking about, but related)...
Studio has a problem with this package because @itwin/electron-authorization assumes authorization takes place on Electron's main process.
But Studio might soon have a separate process for the iTwin backend, so authorization can not take place on Electron's ipcMain.
What I suggest, is either:

Without needing to pull along all of our backend code which is required from core-electron: ElectronMainAuthorization (and the frontend client as well) should allow the user to specify the IPC to use in the config (i.e., the IpcSocketBackend/IpcSocketFrontend instance), else it can default to ipcMain
Pulling along all of our backend code which is required from core-electron: use IpcHost instead of ipcMain, use IpcApp instead of window.itwinjs

I can submit a PR with the config change if you agree

Completed in #144


[FLINK-26064][connectors/firehose,kinesis] Using own event loop group…

… for async clients now

What is the purpose of the change
Introduces own event loop group whenever we create an http client for the aws sdk clients. The issue was found here.
Also reverts the Ignoring of the Firehose integration test cases.
Brief change log
Introduces new event loop group on creation of http client in aws base utility class.
Verifying this change
Added unit test to verify usage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)n
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)n
The serializers: (yes / no / don't know)n
The runtime per-record code paths (performance sensitive): (yes / no / don't know)y
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)n
The S3 file system connector: (yes / no / don't know)n

Documentation

Does this pull request introduce a new feature? (yes / no)n
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)n

@dmvk Dear David, please let us know if this fix encompasses all that you were hoping for after our discussion in #18553 . Looking forward!

It seems that there is still some pool, that we're not closing, can you take a look?

Thanks @dmvk , looks like the .close() is non-blocking from:
https://github.com/aws/aws-sdk-java-v2/blob/750f16463f4fe5d36139b410189cabba6d5ee5aa/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java#L198
I can also confirm this by adding a Thread.sleep(100) straight before the System.out.println(X); which removes any sdk/netty related threads from the thread dump.
Please let me know if this alleviates your concerns.

I have been taking a deeper dive into this issue and am no longer inclined to make this change. I have verified that when running on a cluster, each job creates it's own aws-java-sdk-NettyEventLoop threads, and jobs do not interfere with each other. Running test cluster with 1 TM 1 CPU and 2 slots, posting 2 identical jobs. First job produces 2 threads:
"aws-java-sdk-NettyEventLoop-0-0" daemon prio=5 Id=76 RUNNABLE
"aws-java-sdk-NettyEventLoop-0-1" daemon prio=5 Id=77 RUNNABLE

Second job produces 2 threads:
"aws-java-sdk-NettyEventLoop-0-0" daemon prio=5 Id=95 RUNNABLE
"aws-java-sdk-NettyEventLoop-0-1" daemon prio=5 Id=96 RUNNABLE

Third job produces more threads etc. Killing jobs does not impact the other running jobs. You will notice the thread names are the same. This is because they are isolated in different job classloaders and cannot see each other to increment the pool number.
I have also managed to consistently reproduce this issue locally, and backup @dmvk findings. To reproduce this I made the following changes (My test code):

Switch the Flink job submission to executeAsync()
Move the test client initialisation to after job submission

The problem in the flaky tests is that the FlinkUserClassLoader has the Launcher$AppClassLoader as it's parent classloader. This is the same classloader used by the test code. This means that both test code and Flink job can "see" the same ELG. As @dmvk pointed out, the Netty thread inherits current thread context classloader. The issue seems be be a race condition, since these clients are async, I guess that whoever makes the request first creates the Netty thread (not yet confirmed). The test blocks for Flink job to finish, which destroys the FlinkUserClassLoader and results in the classloader leak on the Netty threads.

Based on this, I am not inclined to create a new ELG per sub task, since this will potentially create a large resource overhead. This would also impact our current Kinesis EFO source, since it already uses the AWS SDK v2 async clients. Instead I would prefer to fix it in the test, either by setting a separate ELG on the test clients, or migrating to synchronous clients. I prefer the latter, since there is no need to spin up a thread pool for these tests!
The tradeoff would be that this issue could still surface for people running embedded Flink mini clusters. However, given the compromise I am willing to accept this.
@dmvk please give me your thoughts. Also, happy to discuss if easier.

@dmvk Would be good to get your thoughts please.

If there are two jobs running on the same TM and they're both using the shared ELG, how comes they can't interfere with each other?
In general I'm inclined to use the shared reference counted ELG, but we'd probably have to scope it per jobId.
I have some time for the discussion today and then I'm off until Monday.

I think I see your point, as long as the SDK is loaded from the user jar, there are actually two instances of this SharedELG singleton, because they class have been loaded by a different classloader (this can be easily verified by running jmap -histo <pid>).
How does this change for the case when the SDK is not shipped with the user jar and is loaded from the system classpath (parent) instead?

If there are two jobs running on the same TM and they're both using the shared ELG, how comes they can't interfere with each other?

When 2 jobs are running on the same TM, they are already using separate ELG already, because they are created in static namespace of Flink User classloader.

In general I'm inclined to use the shared reference counted ELG, but we'd probably have to scope it per jobId.

Based on above, we already have a shared reference counting ELG scoped per job. So for a single job, multiple sources/sinks using AWS async clients will share the same thread pool

I think I see your point, as long as the SDK is loaded from the user jar, there are actually two instances of this SharedELG singleton, because they class have been loaded by a different classloader (this can be easily verified by running jmap -histo ).

Correct yes. I confirmed this by observing the new Netty threads created for each ELG, as explained in my previous comment.

How does this change for the case when the SDK is not shipped with the user jar and is loaded from the system classpath (parent) instead?

In this case we would have a single shared ELG for all jobs on the TM. However, since the AWS SDK jar is loaded by parent classloader I assume the Netty threads would be spawned via AWS SDK threads also loaded from parent classloader, thus attaching parent context classloader. But this is just a guess.

However, since the AWS SDK jar is loaded by parent classloader I assume the Netty threads would be spawned via AWS SDK threads also loaded from parent classloader, thus attaching parent context classloader. But this is just a guess.

My intuition would be that this will use the user classloader as the threads are spawned from the user code. Maybe we could solve that by overriding the thread factory from the ELG and setting the context manually (not sure if thats doable)?

Maybe we could solve that by overriding the thread factory from the ELG and setting the context manually (not sure if thats doable)?

Possibly. Would we check which classloader the ELG is using and replicate that to the thread context?
If we are going to this extent, maybe we could add a static Map<JobId, ELG> in the AWS util class and to create a separate ELG per job as discussed (and copy the counting aspects of SharedSdkEventLoopGroup). I am not sure how we would acquire the job ID though, are there any context objects we can grab this from?
Do you think this edge case is worth the investment now? Since it is non-standard to bundle and load these dependencies  from the parent classloader. I am sure there are plenty of edge cases similar to this where static namespace in parent loader cause issues. For example, Kafka Security providers.

We have been blocking a series of other fixes behind this ELG issue. The reason was that the ELG issue was not well known and we did not want to introduce additional risk. Now the ELG issue is well understood, I want to unblock other PRs so we can move forward. We will proceed as follows:

[FLINK-26064] Fix and re-enable the flaky test using synchronous clients

This will unblock the following:

[FLINK-25948] Close KDS clients
[FLINK-25848] Fail fast when invalid credentials supplied
[FLINK-25846] Graceful shutdown on Interrupt
[FLINK-25793] Reduce throttling

I have created a new issue to cover the ELG fix, and still marked as a blocker for 1.15:

[FLINK-26256] ELG fix

Based on above, we already have a shared reference counting ELG scoped per job. So for a single job, multiple sources/sinks using AWS async clients will share the same thread pool

FYI Just occurred to me that current Kinesis EFO source shades and relocates AWS SDK/netty classes. So for Kinesis EFO source and Kinesis Async Sink we would actually have 2x ELG, caused by the shading.

The reason was that the ELG issue was not well understood and we did not want to introduce additional risk. Now the ELG issue is well understood, I want to unblock other PRs so we can move forward.

👍

Do you think this edge case is worth the investment now? Since it is non-standard to bundle and load these dependencies from the parent classloader.

I think as long as this is documented / user knows what needs to be done when this issue occurs, I'd say it's ok-ish limitation.


Recently I've been using the ipchain test chain. What's the difference between an address starting with TCB and an address starting with 2?

The address starting with TCB is normal address.
The address starting with 2 is multiple signature address.


AND expression gives wrong result

The expression {} && 'abc' returns {}.  Should be 'abc'
The expression {} || 'abc' returns 'abc'.  Should be {}

Actually ... this is per the JMESPath spec.  The truthy evaluation of {} is false -- unlike JavaScript


v1.9.1

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Yeah we were working on this in PR ( #13 ). If you have bandwidth to handle Julien's suggestion and update that PR, we can get it merged and then go on to new versions.

I do not have permissions to change the files in that PR :(

@conda-forge-admin , please rerender

Sorry I overlooked something previously. Have one question above.


Redirect back after signin

Coverage increased (+0.007%) to 94.067% when pulling b3c59c1a88b0bffb8563e3065732fc3528ab5fb5 on cody-signin-redirect into ad62bf6929d9d98eac2c8e63239083e914cf9c9f on main.


Drop FSM support

FSM support is (the most) popular meta-model in MBT field and we need it in long term.
However, the annotation system that JCUnit provides for it is complex and expensive to support.
In JCUnit 0.10.x, it will be temporarily dropped and pulled back in a future version.

Done


Stable hash broken in 3.3.x

Description
While installing native base on a clean expo project, got an error :
While trying to resolve module `stable-hash` from file `/node_modules/native-base/lib/module/hooks/useStyledSystemPropsResolver.js`, the package `.../node_modules/stable-hash/package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved about

CodeSandbox/Snack link
Fresh install
Steps to reproduce

Create a new expo project
Install native base following instructions (built on a mac M1)
Run on iOS

Note:, web builds ok
NativeBase Version
3.3.x (3.3.7)
Platform

[ ] Android
[ ] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
No response
Additional Information
If native base reverted to 3.2.x problem is fixed
Possibly related to this commit:
https://github.com/GeekyAnts/NativeBase/commit/9f4d744708397b3e524bb8e26e48aea92c7f2a3a
stable hash is a relatively new library: https://github.com/shuding/stable-hash
So it might be that the author swapped the package without a release?

check this comment


Support to store PipelineRun data into ConfigMap

What type of PR is this?

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Please check the following list before waiting reviewers:

[ ] Already committed the CRD files to the Helm Chart if you created some new CRDs
[ ] Already added the permission for the new API
[ ] Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

Support to store PipelineRun data into ConfigMap

/cherrypick release-3.3


test: add exclude path to dart analyzer

Description
When using dart 3.5.0, the util/run_tests_analyze --allow-infos command fails due the following warning by the analyzer:
warning • test/integration/util/test_assets/pubspec_helpers/conditionally_ignored/pubspec.yaml:1:1 •
          The 'name' field is required but missing. Try adding a field named 'name'. •
          missing_name

Simply excluding the file in tools/serverpod_cli/analysis_options.yaml fixes it.
Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[x] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[x] I added new tests to check the change I am making.
[x] All existing and new tests are passing.
[x] Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.

I have read the CLA Document and I hereby sign the CLA


Fix sporadic CI failure

System CI sometimes fails to compile
May be a problem with the use of brpc

invalid since we had integrated drpc instead of brpc.


How to include with CMake?

What I've done
In my CMakeLists.txt I have
cmake_minimum_required(VERSION 3.0)
project(minecart C)
set(CMAKE_C_STANDARD 99)

# Adding Raylib
include(FetchContent)
set(BUILD_EXAMPLES OFF CACHE BOOL "" FORCE) # don't build the supplied examples
set(BUILD_GAMES    OFF CACHE BOOL "" FORCE) # don't build the supplied example games
FetchContent_Declare(raylib GIT_REPOSITORY https://github.com/raysan5/raylib.git GIT_TAG master)
FetchContent_MakeAvailable(raylib)

# Adding raylib-nuklear
include(FetchContent)
set(RAYLIB_NUKLEAR_BUILD_EXAMPLES OFF CACHE BOOL "" FORCE) # don't build the supplied examples
FetchContent_Declare(raylib-nuklear GIT_REPOSITORY https://github.com/RobLoach/raylib-nuklear.git GIT_TAG master)
FetchContent_MakeAvailable(raylib-nuklear)

# Adding our source files
file(GLOB_RECURSE PROJECT_SOURCES CONFIGURE_DEPENDS "${CMAKE_CURRENT_LIST_DIR}/sources/*.c") # Define PROJECT_SOURCES as a list of all source files
set(PROJECT_INCLUDE "${CMAKE_CURRENT_LIST_DIR}/sources/") # Define PROJECT_INCLUDE to be the path to the include directory of the project

# Declaring our executable
add_executable(${PROJECT_NAME})
target_sources(${PROJECT_NAME} PRIVATE ${PROJECT_SOURCES})
target_include_directories(${PROJECT_NAME} PRIVATE ${PROJECT_INCLUDE})
target_link_libraries(${PROJECT_NAME} PRIVATE raylib raylib-nuklear)

# Setting ASSETS_PATH
target_compile_definitions(${PROJECT_NAME} PUBLIC ASSETS_PATH="${CMAKE_CURRENT_SOURCE_DIR}/assets/") # Set the asset path macro to the absolute path on the dev machine
#target_compile_definitions(${PROJECT_NAME} PUBLIC ASSETS_PATH="./assets") # Set the asset path macro in release mode to a relative path that assumes the assets folder is in the same directory as the game executable

And my main.c
#define RAYLIB_NUKLEAR_IMPLEMENTATION
#include "raylib-nuklear.h"
#include "raylib.h"

#define SCREEN_WIDTH (800)
#define SCREEN_HEIGHT (450)

#define WINDOW_TITLE "Window title"
#ifndef ASSETS_PATH:
    #define ASSETS_PATH "./assets"
#endif

int main(void)
{
    InitWindow(SCREEN_WIDTH, SCREEN_HEIGHT, WINDOW_TITLE);
    SetTargetFPS(60);

    Texture2D texture = LoadTexture(ASSETS_PATH"test.png"); // Check README.md for how this works

    // Create the Nuklear Context
    int fontSize = 10;
    struct nk_context *ctx = InitNuklear(fontSize);

    while (!WindowShouldClose())
    {
        // Update the Nuklear context, along with input
        UpdateNuklear(ctx);
        // Nuklear GUI Code
        // https://github.com/Immediate-Mode-UI/Nuklear/wiki/Window
        if (nk_begin(ctx, "Nuklear", nk_rect(100, 100, 220, 220),
                NK_WINDOW_BORDER|NK_WINDOW_MOVABLE|NK_WINDOW_CLOSABLE)) {
            if (nk_button_label(ctx, "Button")) {
                // Button was clicked!
            }
        }
        nk_end(ctx);

        BeginDrawing();

        ClearBackground(RAYWHITE);

        const int texture_x = SCREEN_WIDTH / 2 - texture.width / 2;
        const int texture_y = SCREEN_HEIGHT / 2 - texture.height / 2;
        DrawTexture(texture, texture_x, texture_y, WHITE);

        const char* text = "OMG! IT WORKS!";
        const Vector2 text_size = MeasureTextEx(GetFontDefault(), text, 20, 1);
        DrawText(text, SCREEN_WIDTH / 2 - text_size.x / 2, texture_y + texture.height + text_size.y + 10, 20, BLACK);

        DrawNuklear(ctx);
        EndDrawing();
    }

    CloseWindow();

    return 0;
}

What happens
When I build I get the following error
$ make
Consolidate compiler generated dependencies of target glfw
[ 68%] Built target glfw
Consolidate compiler generated dependencies of target raylib
[ 93%] Built target raylib
Consolidate compiler generated dependencies of target minecart
[ 96%] Building C object CMakeFiles/minecart.dir/sources/main.c.obj
D:/Minecart/sources/main.c:2:10: fatal error: raylib-nuklear.h: No such file or directory
    2 | #include "raylib-nuklear.h"
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/minecart.dir/build.make:77: CMakeFiles/minecart.dir/sources/main.c.obj] Error 1
make[1]: *** [CMakeFiles/Makefile2:182: CMakeFiles/minecart.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

But raylib on its own works fine. What do I need to do differently?

Did you get it working????

No sadly, just went with good old ImGui on GLFW.


Can "admin" be defined here in terms of RBAC or Azure AD Role?

Hi Team,
Could you please define what is meant by admin in terms of RBAC or Azure AD role?
Is it a "Global Administrator" or another Azure AD role?
Or is it an "Owner" RBAC role or another RBAC role?
Think it would be great to get some clarity here on this page!
Thanks
Jack

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39e6e511-6049-99d3-68bf-5705d2d6f49e
Version Independent ID: d2209fa8-80ba-d3e2-e2f0-87822c011025
Content: Set directory-level inactivity timeout for users of the Azure portal
Content Source: articles/azure-portal/admin-timeout.md
Service: azure-portal
GitHub Login: @mgblythe
Microsoft Alias: mblythe

@jtracey93 Thank you for sharing your feedback. I have assigned this to our document author @mgblythe to further clarify the query and evaluate how the document can be enhanced to reflect your feedback. Thanks

Thanks @jtracey93 and @BharathNimmala-MSFT - I'm looking into this, and I'll reply back here.

@jtracey93 - it's the Global Administrator - I'll update the docs. Thanks for checking! #please-close


CUDA: Warn when debug=True and opt=True

As per Issue #7214, using debug=True with opt=True can cause NVVM to crash (or the link can fail with an error message from ptxas). We can't easily stop the user from doing this by default as it might break a lot of existing code (particularly that which uses debug=True to force a check for exceptions) but we can warn them.
This commit adds a warning when debug and opt are both True, and some tests for most cases. The debuginfo tests are also updated so that they don't trigger the warning and make the test suite noisy. However, I chose not to "fix" the tests that check for a raised exception (e.g. in test_exception and test_fastmath) - I think the test suite should be emitting warnings there to highlight/remind about the fact that we need to split debug=True into at least two options (e.g. debuginfo=True and exceptions=True).
Fixes #7214.

Reference an existing issue

/AzurePipelines run

Thanks for the patch, looks good on inspection. Does numba.cuda.compile_ptx need similar, IIRC that's public facing?

Good point - I've added a warning there too. I haven't added a test, because triggering the warning also sends NVVM down the path where it may crash. However, I've verified the change manually:
from numba import cuda

def f():
    pass

cuda.compile_ptx(f, (), debug=True, opt=True)

emits:
$ python test.py
/home/gmarkall/numbadev/numba/numba/cuda/compiler.py:220: NumbaInvalidConfigWarning: debug=True with opt=True (the default) is not supported by CUDA. This may result in a crash - set debug=False or opt=False.
  warn(NumbaInvalidConfigWarning(msg))

Buildfarm ID: numba_smoketest_cuda_yaml_88.

Thanks for the patch, looks good on inspection. Does numba.cuda.compile_ptx need similar, IIRC that's public facing?

Good point - I've added a warning there too. I haven't added a test, because triggering the warning also sends NVVM down the path where it may crash. However, I've verified the change manually:
from numba import cuda

def f():
    pass

cuda.compile_ptx(f, (), debug=True, opt=True)

emits:
$ python test.py
/home/gmarkall/numbadev/numba/numba/cuda/compiler.py:220: NumbaInvalidConfigWarning: debug=True with opt=True (the default) is not supported by CUDA. This may result in a crash - set debug=False or opt=False.
  warn(NumbaInvalidConfigWarning(msg))

Thanks for adding that, I've also manually verified the same.

Buildfarm ID: numba_smoketest_cuda_yaml_88.

Passed.


Update Lambda versions

docs: ✏ Fix typo
docs: 📝 Update versions for all supported Lambda runtime for:

Spanish
French
Korean
Polish
Portuguese
English

Thanks!


Utilizing useListNavigation in child elements of floating element

I'm making a multi select combobox and I would want to place my input element inside the floating element just above the listbox element but this means I can't use the useListNavigation hook since it adds attributes and event listeners to the root floating element. Would it be possible to somehow pass it along to a child element of the floating element?

You can call useInteractions multiple times and have different prop getters to spread.
The emoji picker demo does that

Thanks, that's just what I'm looking for.


Feature/regulatory statements setup

Changes needed for futurenow setup

I will merge this as I tested  and didn't find any problems and is blocking Dieter from checking a css problem in the editor,
but feel free to give comments on code quality and will implement them


feat(go): add resources support

[Moved from PR #737]
Introduction
This PR refactors the wit-bindgen-go to mainly support WIT Resources.
Should close https://github.com/bytecodealliance/wit-bindgen/issues/696 and https://github.com/bytecodealliance/wit-bindgen/issues/615
Resources
This PR has enabled WIT resources in the Go binding generator. The user interface for dealing with imported and exported resources look something like this
Exported Resources

Unlike other types that each interface generates a Go interface to implement, exported resource generates its own Go interface. Suppose we have a WIT that looks like

export exports: interface {
    resource x {
      constructor(a: s32);
      get-a: func() -> s32;
      set-a: func(a: s32);
      add: static func(x: x, a: s32) -> x;
    }
}

Then the generated Go code contains an interface ExportsX waiting to be implemented. This interface has all the methods GetA and SetA in it except constructor and static functions, which belong to the WIT interface's generated Go interface. The Go code looks like:
type ExportsImpl struct {}

type MyX struct {
	a int32
}

func (e ExportsImpl) ConstructorX(a int32) ExportsX {
	return &MyX{a: a}
}

func (x *MyX) MethodXGetA() int32 {
	return x.a
}

func (x *MyX) MethodXSetA(a int32) {
	x.a = a
}

func (e ExportsImpl) StaticXAdd(x ExportsX, a int32) ExportsX {
	return &MyX{a: x.MethodXGetA() + a}
}

Note that if there are no methods in the exported resource, than the generated Go interface is just an empty interface. Any struct implementation would work.
Imported Resources
Now moving on to the imported resources. Imported resources have a better Go semantics than exported ones. For example, given the following WIT resource
import imports: interface {
    resource y {
      constructor(a: s32);
      get-a: func() -> s32;
      set-a: func(a: s32);
      add: static func(y: y, a: s32) -> y;
    }
  }

You can use the Go APIs to interact with resource Y in the following way:
y := NewY(1)
if y.GetA() != 1 {
panic("y.GetA() != 1")
}
y.SetA(2)
if y.GetA() != 2 {
panic("y.GetA() != 2")
}

y2 := StaticYAdd(y, 3)
if y2.GetA() != 5 {
panic("y2.GetA() != 5")
}

y.SetA(5)

if y.GetA() != 5 {
panic("y.GetA() != 5")
}

Note that if the resource is empty (meaning it doesn't have any methods), then that resource's representation is just a int32.
More Improvement

This PR refactors the lib.rs file into smaller files, each dealing with their own responsibility. For instance, there is a bindgen.rs file dealing with function generator, and interface.rs dealing with interface generator.
It adds a new gofmt flag that runs gofmt to generated Go files.

Breaking Changes

It separated exported types from imported types. This is BREAKING change that the existing usage of exported types need to be prefixed with a Export to fix some minor bugs. More on this later with the package refactoring work.

I think this PR is ready to review. I will write more in detail what this PR has changed.

Yea, I will resolve the comments in #757 and rebase onto it.

@Mossaka want to rebase this and I'll do a final pass?

Rebased

I will merge once the CI passes. Thanks for reviewing @alexcrichton

And thank you again for your work on this!

sorry wrong button


Added header to pages #320

https://github.com/user-attachments/assets/a817b728-b0b5-490f-bdd0-4976ef13a2d1
Changes made:

I have added a header to hospital.html page and also i felt like other pages like ambtracker and driver page also needs headers so i added the same header in those pages too for better accessibility.
Major change which i have made is that in hospital.html page, i removed manage driver and manage ambulance options from main page and added them in the header, to improve user experience
Enhanced UI of hospital.html page (Matched color theme with logo, hover effects, etc)

I made this thinking that the dashboard page will appear after user logs in. @mansiruhil13 , if you didnt like any of the above changes, tell me, i will undo them.

What type of error is this btw? Due to this error some times my commits dont get merged in main repository and they dont get reflected in the website 🥲


Align VSTS Tasks NuGet Restore, Packager, and Publisher to Select NuGet version - include version 4

Now that VS 2017, .Net Core Tools 1.0, and NuGet 4.0 are released the appropriate build tasks need to be bumped to leverage
An open question is will NuGet Restore be necessary for new solutions/projects with the availability of background restore and msbuild /t:restore

We're planning this work now, using the upcoming tool installers to decouple version management from all the NuGet tasks.
In the meantime, here's a workaround if you need NuGet 4 immediately.

Add a PowerShell Script step before your NuGet steps. Choose the Inline Script option and enter Invoke-WebRequest https://dist.nuget.org/win-x86-commandline/v4.0.0/nuget.exe -OutFile $(build.artifactstagingdirectory)\nuget.exe

In your NuGet steps, set Path to NuGet.exe (in the Advanced section) to $(build.artifactstagingdirectory)\nuget.exe

Perfect - thank you!
Taking the exact same approach with getting the release version of the .NET Core CLI tools installed on the hosted agent
Feel free to close

Here is a little more complicated script that still fits within the space requirements of a inline script. It will only download the 4.0 nuget if it detects that 4.0 or newer has not been installed yet.
if (-not (Test-Path $(Build.BinariesDirectory)\nuget.exe))
{
    $doDownload = $true
}
else
{
    $nuGetVersion = Get-ChildItem D:\Tools\nuget.exe | Select-Object -ExpandProperty VersionInfo | Select-Object -ExpandProperty ProductVersion
    if ([System.Version]$nuGetVersion -lt [System.Version]"4.0.0")
    {
        $doDownload = $true
    }
}
if($doDownload)
{
    Invoke-WebRequest https://dist.nuget.org/win-x86-commandline/v4.0.0/nuget.exe -OutFile $(Build.BinariesDirectory)\nuget.exe
}

Note this script uses $(Build.BinariesDirectory)\nuget.exe instead of $(build.artifactstagingdirectory)\nuget.exe for the custom NuGet path as that folder would be more approprate for downloading a binary tool like nuget that may get reused between builds.

Here is a slightly more complex version that still fits within the space limits of a inline script
if (-not (Test-Path $(Build.BinariesDirectory)\nuget.exe))
{
    $doDownload = $true
}
else
{
    $nuGetVersion = Get-ChildItem $(Build.BinariesDirectory)\nuget.exe | %{$_.VersionInfo} | %{$_.ProductVersion}
    if ([System.Version]$nuGetVersion -lt [System.Version]"4.0.0")
    {
        $doDownload = $true
    }
}
if($doDownload)
{
    Invoke-WebRequest https://dist.nuget.org/win-x86-commandline/v4.0.0/nuget.exe -OutFile $(Build.BinariesDirectory)\nuget.exe
}

This script checks to see if nuget.exe already exists and is version 4.0.0 or newer. if it does not exist or is a old version it downloads it.
Note this saves to $(Build.BinariesDirectory)\nuget.exe instead of $(build.artifactstagingdirectory)\nuget.exe as the binaries folder is not cleaned between builds and is where downloaded tools should be put.

Hey all. Really appreciate the work. I am new to all of this but I can no longer run .NET Core builds in BitBucket anymore. I get the error: "Can't find project.json" as obviously that has been replaced by .csproj. Is this something I have to fix or that BitBucket has to change? Below is my very simple and basic .yml file. Thanks in advance for any guidance, I've been searching a lot.
`# This is a sample build configuration for .NET Core.
Check our guides at https://confluence.atlassian.com/x/5Q4SMw for more examples.
Only use spaces to indent your .yml configuration.
-----
You can specify a custom docker image from Docker Hub as your build environment.
image: microsoft/dotnet:onbuild
pipelines:
default:
- step:
script: # Modify the commands below to build your repository.
- dotnet restore
- dotnet build
- dotnet test TestName`

Not an agent issue. It's the nuget task that's offering v4. Tasks are in that repo.
The packaging team just checked that in so it should in the VSTS next rollout
Microsoft/vsts-tasks@3e3ec62

see #873 5 days ago
For all those waiting ;)

@marvinpuethe In deeper investigation from VSTS I saw that there are version check boxes in the nuget package area in settings of the builds and saw there was not a 4.0.  So do you think that the above issue fix being rolled out will fix that entirely?
My other question would be if this affects bitbucket at all or is this something that bitbucket would have to fix as well? Would ne nice if it could be fixed from a VS2017 update but I'm not sure how that works, I'm just sayin.
Thanks for any responses.

@DanJ210 Sorry but I'm not participating in the development. Maybe @bryanmacfarlane could help you out.

@alexmullans is from the packaging team doing the work.

I can't speak to BitBucket at all - as far as I know, nothing in this library of VSTS build tasks relates to BitBucket.
For VSTS, we have an update going out in the current deployment to make NuGet 4 available as an option in the NuGet Installer task. We'll have a more comprehensive update with support for the new tool installer framework next sprint, but the current deployment should get you unblocked.

Thanks for your response @alexmullans. I was waiting for the update before I responded but after the VS2017 update and creating a new project out of the ASP.NET Core templates, builds are still failing on VTFS. Using Hosted 2017 as provided. What's crazy is that the first error is failing because project.json cannot be found. I thought this was getting changed?
Sorry for my newbieness but I guess there's an update slated for the actual VTFS site that allows me to select nuget package 4.0, I don't see that option as of now so that's the next thing I'm waiting for. Until that happens I can't publish to azure after builds so I'm a little stressed.
Thanks for all you guys/girls do.

@DanJ210 the option for NuGet 4 is available now - look in the Advanced section of the NuGet Installer task. I saw a PR out to make that the default for the ASP.NET (PREVIEW) template, but not sure that made the current deployment.

Duplicate of #3756

@alexmullans Hey alex. I appreciate the help. I did see the NuGet 4 selection when creating or editing a VTFS build and yes that does solve the NuGet problem which is awesome! I still can't get builds to pass. I'm using projects that I create directly from VS2017 templates that I do not edit myself at all, I run them as is. Empty, Web API and Web Application all still fail, not on NuGet but on building directly. Here is a screenshot showing exactly what I'm trying to explain.
If I am posting these in the wrong place perhaps you wouldn't mind giving me a small nudge in the correct area. Thanks.

It is now possible to pick NuGet 4 with NuGet Restore and NuGet Publisher. However, we still cannot pick version for NuGet Packager.

@mbp yep, we're still working on a set of updates to the Packager and Publisher tasks. In the meantime, this workaround will work for the Packager task.
@DanJ210 this is a good place to post, but unfortunately I'm not super-familiar with the Visual Studio Build task. I'm trying to find someone else internally who can help.

Is there an ETA for the update to NuGet Packager?
This issue and having to do a workaround isn't a great story when I'm trying to convince a new customer to use VSTS....
Thanks

Spec is finished, work is starting this week. Most likely, it'll land in the deployment after next, so ~1 month from now.

This is fixed by #4397. We're releasing a new unified NuGet task that will use NuGet 4.0 by default but that can also pick up any version of NuGet provided by the new NuGet Tool Installer task.

Glad to hear this has been fixed. What's the process of using this? Is it an update for VSTS to I need to wait? Is in in the market place? Many thanks.

The tasks will be deployed as part of the next deployment in 2ish weeks. You'll see a notification on your task that a new version is available.

Is this available for on premises TFS? If not, when will it be?

This work will land in TFS 2018.


could StateMachine::apply work without cloning the entire state for each mutation?

this is more of a question than an issue, so please let me know if you'd want this moved elsewhere.
i've been looking for a data structure in Rust that would allow for remote replication and easier undo/redo systems. aper seems like it might fit the bill pretty well! however, from glancing over the documentation and examples, i have just one concern: StateMachine::apply requires to clone the entire state for each mutation. this is probably fine for smaller states like in the guide and examples, but i could imagine this becoming a bottleneck in a bigger state struct. do you think it could be possible for StateMachine::apply to take mut self instead of &self? then it could just return Self back to the caller and cloning wouldn't be necessary. alternatively, perhaps could it take &mut self and simply mutate the state directly without returning Self?

Hi Max, good question!
It would be possible, and it actually worked like that originally. One of the problems I had with that approach is that it's hard to handle conflicts -- ideally, if a conflict occurs, we want to guarantee that the data structure has not been modified at all, so that transitions are "atomic". But if we allow mutating the state directly in apply, there is no way to do that unless we have a copy to revert to. So either way, we would be making a copy.
One solution, if we assume that conflicts are rare, might be to only occasionally snapshot the current state, and keep a log of transitions between snapshots. In case of a conflict, we would replay the transitions to recreate the state just before the conflicting transition.
The approach I chose instead is to lean more heavily on immutable.rs types, which allows two copies of the same data structure to share the same data in memory for the parts that overlap. This means that clone is O(1). The tradeoff is that read/write operations are more expensive, but not worse than O(log n).
A nice thing about this approach is that we have to copy quite a bit anyway to support optimistic updates (since we need to keep an "optimistic" and "server-sent" state), so by making copy cheap, those necessary copies become cheaper too.

thanks for the quick and thorough reply! 🙌
using aper with im-rs makes a lot of sense indeed and i also overlooked that issue with conflicts. they are not really a reality in my use-case tho, and i also don't require the optimistic state as i can always wait for my "server" (another process communicating via IPC) to respond with possible changes. having said that, perhaps choosing aper would be over-engineering for my case and maybe i could just get by with a more vanilla Rust solution perhaps using im-rs.


chalice new-project fails with invalid syntax

chalice new-project chalicetest
Traceback (most recent call last):
  File "/usr/local/bin/chalice", line 9, in <module>
    load_entry_point('chalice==0.5.0', 'console_scripts', 'chalice')()
  File "/usr/local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 542, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2569, in load_entry_point
    return ep.load()
  File "/usr/local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2229, in load
    return self.resolve()
  File "/usr/local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2235, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python3.5/site-packages/chalice/cli/__init__.py", line 88
    print event['timestamp'], event['logShortId'], event['message'].strip()
              ^
SyntaxError: invalid syntax

The documentation states in the README "Note: make sure you are using python2.7". It looks from your paths like you're using Python3.5. I'd suggest grabbing a python2.7 virtualenv.

I think we should add something like
assert sys.version_info < (3,)
but I agree with @garethr that you should read docs first.

@andriisoldatenko Are you proposing adding this to the setup.py?

https://github.com/awslabs/chalice/pull/204
@jamesls

Closing, #204 has been merged.


Mini R2 cannot send REST commands or use this script

Hi,
I recently purchased the Mini R2 and upgraded the firmware to 3.7.6. REST POST commands do not work (get stuck in sending mode). Also, this script gets stuck at "GETTNG MODULE INFO". I can ping the device and can confirm it is connected to the router. I can also control it fine using the ewelink app. Any ideas?

Got it to work. For anyone else wondering:

Removed the device from the ewelink app.
Put device in DIY mode.
Made sure there are no active request to the device IP (pings,  sonoff-ota-flash-cli script running from any terminal, REST requests in progress, etc.) because sonoff can only handle a single request at any moment.
Sent REST commands and received the responses successfully.
At this point, still this script was getting stuck at "GETTING MODULE INFO". I found this tutorial that outlined how to also push the firmware using a REST command.

and voilà!


flicker and crash

i build this and i see esp when round starts in 1 second then it disappears and when i play it crash
is this normal?

How to debug the dll ? @haram

Component list offset seems to be wrong. It returns 0xED, which cannot be dereferenced


Chacnge db

Codecov Report

Merging #7 (4cbfd7a) into master (a39eeb7) will increase coverage by 0.18%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   59.49%   59.67%   +0.18%
==========================================
  Files           7        7
  Lines         553      558       +5
==========================================
+ Hits          329      333       +4
- Misses        180      181       +1
  Partials       44       44

Flag
Coverage Δ

app
59.67% <66.66%> (+0.18%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components
Coverage Δ

app
59.67% <66.66%> (+0.18%)
:arrow_up:


Tutorials

PR Type

[ ] Breaking change
[x] Feature
[ ] Patch

Brief Description

This PR improves the build system support for Python bindings, including installing and packaging them. It adds a preliminary set of Python bindings (notably absent from the bindings are the MPI bindings, vide infra), as well as unit tests and tutorials which use the Python bindings.
Not In Scope

Python bindings for the MPI API of ParallelZone are not included. While it is possible to write such bindings, it's not clear to me that we want to go down that path as opposed to relying on say mpi4py. This requires more design and, in any case, can be added on later as need be. For now we assume all MPI operations are done in C++.
PR Checklist

[x] Is documented
[x] Is tested
[x] Adheres to applicable organization standards

TODO:

[x] Depends on https://github.com/NWChemEx-Project/NWXCMake/pull/18
[x] The build currently does not work because of a bug in CMaize which prevents the Python target from depending on the C++ target. @zachcran has a patch for this here.
[x] With the above patch the build and install work; however, there is an rpath issue with the final executable which requires the user to set LD_LIBRARY_PATH; @zachcran is looking into this.

This is r2g. A couple of notes:

All Python bindings are now off by default

To enable Python bindings with pybind11 the flag is BUILD_PYBIND11_PYBINDINGS
To enable Python bindings with Cppyy the flag is now BUILD_CPPYY_PYBINDINGS
N.B. the two flavors of Python bindings are NOT API compatible.

If you enable pybind11 bindings you will also need to specify NWX_MODULE_PATH, which is where the NWChemEx Python modules should be installed.
If BUILD_PYBIND11_PYBINDINGS is enabled there are a number of Python tests which will be run


[MWPW-153881] Table section not initially expanding on mobile

This adapts the logic so that table sections can be expanded on mobile without having to change the filters.
It also brings in a few small changes requested in another thread:

Regular links that have more than 1 word should not span multiple lines

Before
After

The font size and line height of the first column needs to be increased from XS to S

Before
After

The gap between CTA buttons should be reduced from S to XS

Before
After

There shouldn't be a border radius between table columns on mobile

Before
After

Resolves: MWPW-153881
Test URLs:

Before: https://table-review--milo--overmyheadandbody.hlx.page/drafts/ramuntea/table-tiger-team-mwpw-152305?martech-off&georouting=off
After: https://mobile-table-sections--milo--overmyheadandbody.hlx.page/drafts/ramuntea/table-tiger-team-mwpw-152305?martech-off&georouting=off
Before: https://table-review--milo--overmyheadandbody.hlx.page/drafts/ramuntea/table-tiger-team-kyung-overhaul?martech-off&georouting=off
After: https://mobile-table-sections--milo--overmyheadandbody.hlx.page/drafts/ramuntea/table-tiger-team-kyung-overhaul?martech-off&georouting=off

Hey @robert-bogos! We have a separate story to address unit test failures, https://jira.corp.adobe.com/browse/MWPW-153609. The build is still somewhat unstable, they will all be addressed in one go at a later time.
@narcis-radu - that is due to CORS issues for pricing on such feature branches. Navigating to https://main--milo--adobecom.hlx.page/drafts/ramuntea/table-tiger-team-kyung-overhaul?martech-off&georouting=off should provide better insight into the final output.


ip6defrag: implements an IPv6 defragmenter

Sometimes we need a IPv6 defragmenter lib

hey @txthinking, I'm happy to merge this into the gopacket/gopacket fork :) feel free to move your PR over there


Feature request: New zoom mode

As per title, is it possible for the "click" zoom mode to return to original size during the second click.
Current behaviour:

Click on image, image zoom
Click on image again, nothing happens
Move out from image, goes back to original size

Desired behavior:

Click on image, image zoom
Click on image, goes back to original size

Have you tried the 'toggle' zoom mode instead of 'click'? If 'toggle' is not what you are looking for could you try and explain the difference between 'toggle' and what you want?


Pino: Allow logging trace metadata under different keys

Is your feature request related to a problem? Please describe
The current pino instrumentation from @opentelemetry/instrumentation-pino injects 3 fields into each log, trace_id, span_id and trace_flags. These fields are useful, but the snake case naming is slightly problematic in my case, where my company has strict logging standards and we'd like to use camelCase.
Describe the solution you'd like to see
Allowing a different set of keys to be used in the config (this is assuming you are configuring the instrumentation via getNodeAutoInstrumentations from @opentelemetry/auto-instrumentations-node).
'@opentelemetry/instrumentation-pino': {
  camelCase: true
}

Describe alternatives you've considered
Reformatting the log manually, via the logHook config.
'@opentelemetry/instrumentation-pino': {
    logHook: (span, record) => {
      // Reformat the injected log fields to use camelCase, eg. trace_id -> traceId
      const context = span.spanContext();
      record.traceId = context.traceId;
      record.spanId = context.spanId;
      record.traceFlags = context.traceFlags;

      // Be extra safe, in case someone manually logged these fields, even though they shouldn't
      if (record.trace_id === context.traceId) delete record.trace_id;
      if (record.span_id === context.spanId) delete record.span_id;
      if (record.trace_flags === context.traceFlags) delete record.trace_flags;
    },
  },

Additional context

I think it would be more flexible to allow to override the actual key names instead of adding just one more fixed set. e.g
'@opentelemetry/instrumentation-pino': {
  traceIdKey: 'traceId', // default is 'trace_id
  spanIdKey: 'span.id', // default is 'span_id'
  trace_flags: 'my-trace-flags'  // defaults to 'trace_flags'
}

Not stale

This could also be useful for specific log destinations. For example. GCP requires the following format:
   const trace = `projects/${projectId}/traces/${traceId}`;
      res['logging.googleapis.com/trace'] = trace;
    }
    res['logging.googleapis.com/trace_sampled'] = traceFlags;
    res['logging.googleapis.com/spanId'] = spanId;

@drewcorlin1 This can be closed now, right (it was handled by #1867)?

@drewcorlin1 This can be closed now, right (it was handled by #1867)?

Yes!


form.validating always false

Laravel Precognition Plugin Version
0.5.1
Laravel Version
10.22
Plugin
Vue w/ Inertia
Description
I can't see form.validating change while validating
Steps To Reproduce
<input v-model="form.first_name" @change="form.validate('first_name')" />
 --- {{ form.validating }} ---

const form = useForm('post', '/my-route', {
 first_name: null
})

Hey there,
I'm not able to reproduce this issue. If I create a fresh Laravel Breeze application:
composer create-project laravel/laravel preconition-test
cd preconition-test
composer install laravel/breeze
php artisan breeze:install vue
npm install laravel-precognition-vue

Then paste the following in the Welcome.vue file...

<template>
    <form @submit.prevent="submit">
        Name
        <input
            id="name"
            v-model="form.name"
            @change="form.validate('name')"
        />

            {{ form.errors.name }}

        Email
        <input
            id="email"
            type="email"
            v-model="form.email"
            @change="form.validate('email')"
        />

            {{ form.errors.email }}

            Validating: {{ form.validating }}

        <button :disabled="form.processing">
            Create User
        </button>
    </form>
</template>

Then build and serve the app...
npm run build
php artisan serve

I see the following. Note: I've added a 3 second sleep to my public/index.php file to make sure we see the change...
https://github.com/laravel/precognition/assets/24803032/b8273030-e45f-42c8-9a7e-93ec450c86b5
If this is still an issue, we made need a repository that reproduces the issue in isolation.

@timacdonald the issue is on laravel-precognition-vue-inertia

@makroxyz thanks for letting me know. Missed that sorry.
Fixed here: https://github.com/laravel/precognition/pull/49
Thanks for reporting this!


RTL support

It seems the package does not working correctly on rtl mode also there are FlashList rtl related issues still open.

https://github.com/Shopify/flash-list/issues/840
https://github.com/Shopify/flash-list/issues/544

https://github.com/SimformSolutionsPvtLtd/react-native-story-view/assets/13810855/3d5213b8-2e58-4202-a7d0-bc8c9ef21d41

Thanks for the work. I know that the RTL has always been a pain to all frontend frameworks. But it still has a big population. Currently package is not usable in RTL mode. Please see the behavior of RTL on below recording, compared to LTR. As mentioned in this issue, the problem may be arising from FlashList, RecyclerListView or FlatList.
https://github.com/user-attachments/assets/97f1a936-a615-4707-b39f-c098ec0ea201


Make tests compatible with pytest v8.x

Hey :wave:  Arch Linux maintainer here.
The test test_get_valid_history_without_current fails when using pytest v8.x in the following manner:
======================================================== short test summary info =========================================================
FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[le cat-result0] - AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x', 'café ô']
FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[diff x-result1] - AssertionError: assert ['ls cat'] == ['ls cat', 'café ô']
FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[fuck-result2] - AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x', 'café ô']
FAILED tests/test_utils.py::TestGetValidHistoryWithoutCurrent::test_get_valid_history_without_current[cafe \xf4-result3] - AssertionError: assert ['ls cat', 'diff x'] == ['ls cat', 'diff x', 'café ô']
======================================== 4 failed, 1793 passed, 62 skipped, 273 warnings in 4.04s ========================================

The issue stems from the function thefuck/utils.py:get_all_executables() and seems to be related to the memoization decorator used.
Disable memoization for the failing tests with the fixture no_meomize to resolve the issue.

Thanks! Shamelessly backporting for Fedora :smile:


Frontend Dev(HTML, CSS, JS): HTML Tables

Description 📜
I would like to make documentation on HTML tables, covering all the information related to tables .

Domain of Contribution 📊

[ ] Frontend Dev (HTML, CSS, JS)

/assign

@code-reaper08  please assign this issue to me.

/assign

/assign documentation

/assign


Corrects indentation for config of probes

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

Codecov Report
Base: 50.14% // Head: 73.87% // Increases project coverage by +23.73% :tada:

Coverage data is based on head (1065802) compared to base (209c0c9).
Patch coverage: 69.21% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #257       +/-   ##
===========================================
+ Coverage   50.14%   73.87%   +23.73%
===========================================
  Files          13       25       +12
  Lines         357      731      +374
===========================================
+ Hits          179      540      +361
- Misses        178      191       +13

Impacted Files
Coverage Δ

clean_expired_records.py
0.00% <0.00%> (ø)

historical_system_profiles/mgmt_views/v0.py
100.00% <ø> (ø)

kafka_listener.py
0.00% <0.00%> (ø)

standalone_flask_server.py
0.00% <ø> (ø)

wsgi.py
0.00% <ø> (ø)

..._system_profiles/notification_service_interface.py
35.00% <35.00%> (ø)

...ical_system_profiles/baseline_service_interface.py
39.13% <39.13%> (ø)

historical_system_profiles/archiver.py
55.05% <54.41%> (+55.05%)
:arrow_up:

...torical_system_profiles/drift_service_interface.py
66.66% <66.66%> (ø)

historical_system_profiles/probes.py
66.66% <66.66%> (ø)

... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Allow Acceptance tests to run in multiple ginkgo nodes

Currently the currently targeted org is always looked up in the config file in the home directory of the user. Although we use a different cluster per ginkgo node, they both use that file to refer to the targeted org. This results in flaky tests (e.g. https://github.com/SUSE/carrier/blob/main/acceptance/apps_test.go#L14) because the test may target an org but the other ginkgo node may target another in the meantime so when the first test tries to list the deployed apps, it lists those of the org of the other ginkgo node.
This may not be a problem for the developer since they will probably use only one carrier instance per machine per user but it is a problem for tests.
One solution would be to be able to override the default config location with a command line arg or an environment variable.
After fixing this, we should revert back to using more ginkgo nodes (https://github.com/SUSE/carrier/pull/137/commits/cf01b573a601beb0fa1c6aaa727814f0fa1df22d).

[ ] Environment variable for config directory.
[x] Global cli option for the same.
:warning: Check for ordering issues with the backend clients and their usage of config.
[ ] Change :cat2: to use the above to place config into node-specific directories
[ ] change :cat2:  back to use of 2 ginkgo nodes

We already have a global option --config-file (possibly since Vlad's work was added).
There is no associated environment variable.


Added a new operation to Stellar

Hello @quyse!
Support new operation PathPaymentStrictSend to Stellar.

Hi! Thanks for the PR, but I have already fixed this problem a day ago, just forgot to push to this repo (pushed just now). We have been mostly using Gitlab for a while. I guess I should archive this Github repo for clarity. The Gitlab repo is here: https://gitlab.com/coinmetrics/haskell-tools . Sorry for the confusion.


Zipties

About the PR
Adds zipties which are basically just white cablecuffs with slightly tweaked numbers and new sounds. They have a slightly edited sprite (I included the cablecuff attribution from ss13 in the zipties json, not sure if its necessary seeing as cablecuffs already attributes it).
They're intended for use by security and primarily the warden to prevent prisoners getting a free pair of cuffs in their cell.
Puts them in the Sec-tech vendor and adds a ziptie box which can be ordered as part of the new 'restraints crate' from cargo.
Changelog

:cl:

add: Using information extracted from captured Assistants, security now have access to single-use zipties from the security dispenser and cargo's new restraints crate.

Uhhh people cuff prisoners in their cells? Bucklecuffing in 13 was against the rules and surely you get them to strip out of their prisoner uniform on exit so have nothing?
I thought cable cuffs were for non security to craft.
Useful non the less.

I see people bucklecuffing more often than not at the moment, but even if you don't it's one less thing to worry about when you go into the cell to uncuff the prisoner - or you can just let them uncuff themselves at no risk.

Sure, I've no issues with this, just thought I'd bring it up and can always be tweaked in future.


Remove underscore

I believe we may be able to accomplish all underscore functionality using native functionality.

Resolved by #98


Database encryption key storage

Hello,
I see this issue on how to improve security #188
And there is this brief description here
https://core.telegram.org/tdlib/docs/classtd_1_1td__api_1_1set_database_encryption_key.html
Do I understand it right, that if I'm using setDatabaseEncryptionKey explicitly, then I'm responsible to store it in some secure manner (e.g. on a HSM)?
But what about default encryption key? Does it provide any security at all or is it just about obscurity?
Where does tdlib store database encryption key on windows?
Is default encryption key hardcoded? Is it same for each client? Or for each OS user? Or for each tdlib-based app installation?

Do I understand it right, that if I'm using setDatabaseEncryptionKey explicitly, then I'm responsible to store it in some secure manner (e.g. on a HSM)?

Yes, unless you receive it from the user.

But what about default encryption key? Does it provide any security at all or is it just about obscurity?

If the user can launch the app, then it can access all the data anyway by design.

Where does tdlib store database encryption key on windows?
Is default encryption key hardcoded? Is it same for each client? Or for each OS user? Or for each tdlib-based app installation?

None of these is specified.

None of these is specified.

Ok, I understand it's not public contract. But can you at least give a hint on where in the source code should I look to figure out current implementation?
I need to decide whether I should engage myself into using setDatabaseEncryptionKey

If the user can launch the app, then it all the data can be accessed by the user. Whoever has access to filesystem can read all stored data, unless you protect it with a user-provided password.


OCaml changes are sometimes ignored

Adding let _ = foo to an ocaml file is claimed to have no changes. I edited ~line 4350 of clientLsp.ml.

No longer a problem in the tree-sitter parser.


Is it possible to set an array of countries available to select?

User story - I would like to make only certain countries clickable - let say I have data to display only for those not for all countries.

@GreatEarl
You can always handle the onRegionSelect/Click based on your own needs.
Furthermore, you can always color these regions differently from the non selectable.
See example here: https://stackoverflow.com/questions/12934000/jvectormap-country-colors


Attachments of ics

Do you know if there is any possibility to read iCal Attachments from Swift? You know, iCal dates are allowed to have attachments like images... Would be a nice feature for your project, too :)

Hey! Thanks for the idea! I actually can't say that I have a lot of experience with ical per se, but technically this is definitely something for the roadmap here! 😊
I've been meaning to get back to this project for a small while now and bringing it to a state where it can actually be used. Hopefully soon 😊


Improve Extensions documentation

Summary
Fixes #9481

Occurred changes and/or fixed issues

Improve extension docs in order to include information about cluster-level products
Add info about LocationConfig wildcard param for resource *
Fix broken Getting Started example (missing route definition because of changes to custom 404 pages done a while ago)
Fix Developer Load block as the env variable EXCLUDE_PKGS doesn't work on a local dev env anymore (very old docs)
Fix multiple parts of docs
Improve types definition to prevent linter complains on top-level and cluster-level products examples
bump shell version

Note: Tried to extend RouteConfig type multiple times, but always hit some kind of problem, so opted to go with a more generic Object definition in types in a couple of areas. RouteConfig doesn't have/allow params route param, which is strange, imo.

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

FYI @nwmac


LICENSE section on Readme

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[ ] New extensions are written in Swift 4.
[ ] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[ ] I have added tests for new extensions, and they passed.
[ ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[ ] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

Adding License #378 :)

Why you working off a fork @LucianoPAlmeida? 😂

That's a really good question @SD10 and I really don't know why 😂


build: Improve ddev-php-base and ddev-webserver image build and change PHP and Node.JS defaults

The Issue
Preparing for working on including less PHP versions by default in the ddev-php-base image.
I found a few things to work on:

[x] PHP config files were partly in ddev-php-base and partly in ddev-webserver. They need to be consolidated in ddev-php-base and removed from ddev-webserver.
[x] PHP 8.3 and PHP 8.4 config files didn't get fully sorted out and updated.
[x] We still need to update the base config files for PHP 8.4. Currently they're just copy of PHP 8.3
[x] Change the ARG/ENV specification of what packages to use for each PHP version and architecture to specifying those with a yaml file instead of the huge complex situation we have right now.
[x] Update PHP default version to 8.3
[x] Update Node.JS default version to 22

Manual Testing Instructions
Automated Testing Overview

Release/Deployment Notes

Thanks for catching that @stasadev . You may be able to get a better feel of this by looking just at the major changes to Dockerfile(s) and the script and the php-packages.yaml file.

Update PHP default version to 8.3

Could have sworn I already had to do this :(  Was forced to do it by broken test. But I don't see it!

The only question I have is why there are only 4 INI files in PHP 5.6-8.2? And much more in PHP 8.3, 8.4

I'm confused as well. I guess IMO we should only do the ones that we require specific changes in. So 5.6-8.2 would probably be the strategy we'd want.
I guess when we upgraded to 8.3, we just took all the files. Then copied then when we did 8.4.
I'd rather only do the ones that possibly have values we want to override.

It was foolish of me to try to change the PHP and Node.js defaults in this issue, so I have reverted those changes. Not sure what I was thinking.

Here's hoping that my removal of the version changes didn't lose anything I had encountered along the way. It's a lot easier to look at now though.


Actor Studio sidebar button vanishes after creating a character

Happens as soon as the character is added to the game.

Fixed in https://github.com/geoidesic/foundryvtt-actor-studio/releases/tag/1.0.2


Modifies ComputeAggregatePoly to closer match specs

When n ==1 which is the case that there is only one blob and one commitment; the aggregated polynomial and commitment is the first item in the list of polynomials and the first item in the list of commitments

How about #15 instead?

Closed in favour of the one mentioned above.


BLOCKED: Chore/update find funeral director

Ticket for this PR: https://trello.com/c/QXxgSELk/1306-list-management-funeral-directors-update-time-out-period

@RichardBray the changes pertaining to the field layout in the find results look ok to me, however, there are other changes included in this PR which appear to be mainly code style reformatting.  If this is the case and there's no functional changes, can you please revert them as it's confusing when reviewing actual changes.  Also, the timeout changes to increase to 8 hours are not included here, can you advise on this one?

@RichardBray the changes pertaining to the field layout in the find results look ok to me, however, there are other changes included in this PR which appear to be mainly code style reformatting. If this is the case and there's no functional changes, can you please revert them as it's confusing when reviewing actual changes. Also, the timeout changes to increase to 8 hours are not included here, can you advise on this one?

Hey @alisalaman-cyb really sorry but this PR isn't ready to be reviewed. I should have made that more obvious. I made it a draft and added BLOCKED to the title but I don't think that was obvious enough.
I'll amend the title to NOT READY FOR REVIEW which should help.
But yeah this PR was done ages ago and a lot has changed since then so I might just scrap this branch locally and do it again 🤷


fix: Optimize the contact callback process.

Sorry for late. Yes, this is a breaking change, it's my mistake for description.
The original code may cause a bug when register more than one same class, such as I register two Football. Then the two class both will be selected in the functions of 'ContactTypes' and both will be callback. So maybe the two balls will both move if we don't do anything else to make the two Football different.
About "why there are no need to register the callbacks". Because the 'Contact' call back from the forge2d (beginContact, endContact) already tell us both the contacted objects. 'Contact' includes the two bodies and the two fixtures that contacted. And we also can get the contacted object using the 'userData' of 'BodyDef'.
Using my modified code, the listening callback can be like below:
class Football extends PositionBodyComponent with ContactCallback {
...
@override
void begin(a, b, Contact contact) {
// Here a is the Football, b is another contacted object.
}
@override
void end(a, b, Contact contact) {}
}
---------------- new above --- old below --------------
Description
The callback process is no need to do 'register' and 'forEach' loop to fetch.
There will be a problem when two same class A in the listener list, because the forEach and _mayCallback will callback the both but only one is in the contact.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
[x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
[x] I have did tests for ALL new/updated/fixed functionality.
[/] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[/] I have updated/added relevant examples in examples.

Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?
YES, this is a breaking change.
Related Issues
#1321

You'll have to explain a bit more what you are doing here, why is there no need to register the callbacks?
And also you have marked this as a non-breaking change, but since you are removing functions from Forge2DGame it is a breaking change. (Breaking changes are okay though)

@BlockRen it is failing the analyzer and the formatter (I can help you with those issues if you want), but more importantly I think I need the change explained to me to be able to properly review this.

@spydon Have you seen https://github.com/marketplace/actions/dart-analyze-with-annotations? It's similar to our analyzer, but reports directly into the PR.

@spydon Have you seen https://github.com/marketplace/actions/dart-analyze-with-annotations? It's similar to our analyzer, but reports directly into the PR.

I have indeed, we have discussed adding it, don't remember what our conclusion was but we should definitely try it. And probably run it as a second non-mandatory step, since I guess that one can't be as nicely parallelized.

@spydon Have you seen https://github.com/marketplace/actions/dart-analyze-with-annotations? It's similar to our analyzer, but reports directly into the PR.

I have indeed, we have discussed adding it, don't remember what our conclusion was but we should definitely try it. And probably run it as a second non-mandatory step, since I guess that one can't be as nicely parallelized.

Conclusion was: lets try it. Or in Lukas, leettsss dooo iiiiit

LGTM.
Edit: I cannot remove my verification, apologies. Didn't see pending comments from @spydon, I agree with him.

@abgutierrez have you tried it?

More explanation added in the comment. Thank you.

@BlockRen it is failing the analyzer and the formatter (I can help you with those issues if you want), but more importantly I think I need the change explained to me to be able to properly review this.

More explanation added in the comment. Thank you.

@BlockRen it is failing the analyzer and the formatter (I can help you with those issues if you want), but more importantly I think I need the change explained to me to be able to properly review this.

More explanation added in the comment. Thank you.

Thanks! Could you update the example that is using contact callbacks in flame_forge2d?
https://github.com/flame-engine/flame/blob/main/packages/flame_forge2d/example/lib/contact_callbacks_sample.dart

Closing this in favor of #1547


climate summary files don't display using text.php

Just discovered this. Yields an error, e.g.,
[domain]/text.php?report=NOAA/NOAA-2021-02.txt
results in
"; echo file_get_contents($report); echo ""; } ?>
The file exists ok in the NOAA directory.
Happy to give your Ajax and jQuery version a test or to fix if you know already what causes this. Not immediately obvious to me right now what's wrong.

Working fine for me - https://www.loughlinstown.ie/text.php?report=NOAA/NOAA-2021-02.txt

OK. I may have made a breaking change to template (am working on a test system with Ubuntu, Python3 and some other changes from my old RaspiOS install) but if this bit is changed/changing ...

Just to confirm I have the same issue with latest unchanged version of (Sofaskin-CW9009-master) template. I changed HTML_ROOT to /var/www/domain but don't think that should matter; files are created in the right place; am using a virtual host with Apache2; WeeWX 4.4.
Just noticed that the title line displayed in the header, between coordinates and date/time reads
Climate Summary for $title"; ?>
Penny drop: it helps to have PHP installed /groan. Solution
sudo apt install php libapache2-mod-php
sudo systemctl restart apache2

Maybe add something explicit to the installation instructions? :-)
If new solution saves 18Mb of space and PHP cruft that would be nice.

It's a good point to mention that PHP module needs to be installed if your running your own web server. Most commercially available web spaces offer PHP by default so this hasn't been a big issue. Anayways, I did add some instructions for this to the readme.
I do have a javascript version working which would remove the PHP requirement but I haven't added it to the code base yet.

Fixed


gRPC edits

I also removed 5 articles that were not included in the TOC

@mairaw We should have your name in the Editors section in index page. I am ok with all other changes.


Support nested stream blocks

A streamfield can contain stream blocks.
A struct block can contain stream blocks.
possible solution here: https://github.com/nhsuk/wagtail-factories/blob/dev/src/wagtail_factories/blocks.py#L158
For blocks:
from wagtail.core import blocks

class MySubStreamBlock(blocks.StreamBlock):
    foo = blocks.CharBlock()
    bar = blocks.CharBlock()

class MyStructBlock(blocks.StructBlock):
    sub_stream = MySubStreamBlock()

class MyStreamBlock(blocks.StreamBlock):
    struct = MyStructBlock()

This requires a factory definition of:
import factory
import wagtail_factories
from . import blocks
from .models import HomePage

class MySubStreamBlockFactory(wagtail_factories.StreamBlockFactory):

    foo = "foo"
    bar = "bar"

    class Meta:
        model = blocks.MySubStreamBlock

class MyStructBlockFactory(wagtail_factories.StructBlockFactory):

    sub_stream = wagtail_factories.StreamBlockSubFactory(MySubStreamBlockFactory)

    class Meta:
        model = blocks.MyStructBlock

class MyStreamBlockFactory(wagtail_factories.StreamBlockFactory):

    struct = factory.SubFactory(MyStructBlockFactory)

    class Meta:
        model = blocks.MyStreamBlock

class HomePageFactory(wagtail_factories.PageFactory):

    content = wagtail_factories.StreamFieldFactory({
        "struct": MyStructBlockFactory,
    }, **{
        "0__struct__sub_stream__0__foo": "foo",
        "0__struct__sub_stream__1__bar": "bar",
        "0__struct__sub_stream__2__foo": "foo2",
    })

    class Meta:
        model = HomePage

I am only using stream blocks as a sub-block of struct blocks in my project, so I haven't tested other combinations of blocks. E.g stream block as a sub-block of a stream-block, stream block inside a list block.

I have opened a work-in-progress PR for this #26

Thanks @mikemonteith for raising - this is addressed in #55


TapTarget / FeatureDiscovery isOpen not working

Expected Behavior
When calling tapTarget with isOpen: true (M.TapTarget.init(elem, options, true);) the Feature Discovery is open on load
Current Behavior
The Feature Discovery is closed but can be opened using a manual toggle (see toggle button in Codepen)
Possible Solution
Steps to Reproduce (for bugs)
Create a Page following the manual: http://materializecss.com/feature-discovery.html
Initialize tapTarget with isOpen: true
See this Codepen: https://codepen.io/anon/pen/pVzqVJ
Your Environment

Version used: 1.0.0-beta
Browser Name and version: Firefox 59.0.2 x64
Operating System and version (desktop or mobile): Pop_Os (Ubuntu) on Desktop

Properties are not the same as passable options. Once you initialize your plugin you can access properties on the instance.
For example:
var instance = M.TapTarget.init(elem, options);
instance.isOpen // Read only property whether the tapTarget is open or not

You can use the open() method after you initialize it if you want it to start open.

I misunderstood that, thank you for you help.


[move-prover][refactoring] Integrating verification analysis into the transformation pipeline.

This PR moves the analysis of what functions need to be verified in the presence of cross-module invariants into the transformation pipeline. This information is needed for the new SpecInstrumenter in the pipeline, but it was not available until now.

Adds a new verification_analysis.rs step to the pipeline. This computes an annotation indicating whether a function is verified and/or whether it needs to be inlined because it is transitively called by a verified function. The implementations is derived from @emmazzz previous work on integrating this in the main prover's lib.rs.
The new analysis replicates the old one, but also adds additional information regards whether a function is needed in it's inlined variant for verification (which is the case if it is transitively called from a verified function and is not opaque). The v2 compilation scheme exploits this and only generates Boogie for needed functions, which should drastically reduce the smt2lib output we pass to Z3.
Also moves the modifies static analysis out of main prover's lib.rs and into spec instrumenter. The spec instrumenter decides what can be done for modifies at compile or runtime, so this is good place for this code.
Extends generic pipeline infrastructure to be able to implement initialize and finalize trait functions, and other changes.
Removes functionality from move-model for tracking verification info as this is now represented as an annotation.

Both new and old compilation scheme have been adopted to this change, which should be tested good by existing tests.
The major file to look at is verification_analysis.rs.
Motivation
Prover refactoring.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Existing tests.
Related PRs
NA

/land

:broken_heart: Test Failed - ci-test-success

/land