Store Gateway does not start after image version upgrade from v0.7.0 to v0.8.1

Ping: @bwplotka
Thanos, Prometheus and Golang version used:
Thanos: quay.io/thanos/thanos:v0.8.1
Prometheus: prom/prometheus:v2.13.0
Object Storage Provider:
$ cat /config/thanos.yaml
type: GCS
...

What happened:
I've updated all the Thanos stack I'm using, from the v0.7.0 to v0.8.1. Everything works as expected (I've seen incredible memory savings in Thanos Sidecar, amazing job!) except the Store Gateway component.
It simply does not start and dies with a 2 exit code.
What you expected to happen:
It starts as before!
How to reproduce it:
It's happening in our productive environment, our staging stack, which uses its own bucket,  works correctly with the same parameters.
Parameters:
      --data-dir=/data
      --log.level=debug
      --index-cache-size=500MB
      --chunk-pool-size=2GB
      --grpc-server-tls-cert=/etc/pki/thanos/tls.crt
      --grpc-server-tls-client-ca=/etc/pki/thanos/tls.ca
      --grpc-server-tls-key=/etc/pki/thanos/tls.key
      --objstore.config-file=/config/thanos.yaml

Full logs to relevant components:
Excerpt of the pod describe:
Last State:     Terminated
      Reason:       Error
      Exit Code:    2
      Started:      Tue, 15 Oct 2019 19:12:56 +0200
      Finished:     Tue, 15 Oct 2019 19:23:23 +0200

Logs of v0.8.1

level=debug ts=2019-10-16T08:00:41.916594638Z caller=main.go:120 msg="maxprocs: Leaving GOMAXPROCS=[8]: CPU quota undefined"
level=info  ts=2019-10-16T08:00:41.924413863Z caller=main.go:168 msg="Tracing will be disabled"
level=info  ts=2019-10-16T08:00:41.924630438Z caller=factory.go:39 msg="loading bucket configuration"
level=info  ts=2019-10-16T08:00:41.929235164Z caller=cache.go:172 msg="created index cache" maxItemSizeBytes=262144000 maxSizeBytes=524288000 maxItems=math.MaxInt64
level=debug ts=2019-10-16T08:00:41.981473465Z caller=store.go:162 msg="initializing bucket store"

When I go back to the earlier version it works.
Logs of v0.7.0

```
level=debug ts=2019-10-16T08:00:41.916594638Z caller=main.go:120 msg="maxprocs: Leaving GOMAXPROCS=[8]: CPU quota undefined"
level=info ts=2019-10-16T08:00:41.924413863Z caller=main.go:168 msg="Tracing will be disabled"
level=info ts=2019-10-16T08:00:41.924630438Z caller=factory.go:39 msg="loading bucket configuration"
level=info ts=2019-10-16T08:00:41.929235164Z caller=cache.go:172 msg="created index cache" maxItemSizeBytes=262144000 maxSizeBytes=524288000 maxItems=math.MaxInt64
level=debug ts=2019-10-16T08:00:41.981473465Z caller=store.go:162 msg="initializing bucket store"
level=debug ts=2019-10-16T08:08:37.879383906Z caller=store.go:166 msg="bucket store ready" init_duration=7m55.871106642s
level=info ts=2019-10-16T08:08:38.655822385Z caller=main.go:305 msg="enabled gRPC server side TLS"
level=info ts=2019-10-16T08:08:38.657352493Z caller=main.go:322 msg="gRPC server TLS client verification enabled"
level=info ts=2019-10-16T08:08:38.697338919Z caller=store.go:209 msg="starting store node"
level=info ts=2019-10-16T08:08:38.729108826Z caller=main.go:341 msg="Listening for metrics" address=<IP_ADDRESS>:10902
level=info ts=2019-10-16T08:08:38.729094252Z caller=store.go:199 msg="Listening for StoreAPI gRPC" address=<IP_ADDRESS>:10901
level=debug ts=2019-10-16T08:21:49.523658907Z caller=bucket.go:771 msg="Blocks source resolutions" blocks=2 MaximumResolution=0 mint=1571192190000 maxt=1571214090000 lset="{kubernetes_cluster=\"kube-eu-west\",kubernetes_environment=\"production\"}" spans="Range:<PHONE_NUMBER>000-1571205600000 Resolution: 0"
level=debug ts=2019-10-16T08:21:51.538999187Z caller=bucket.go:871 msg="stats query processed" stats="&{blocksQueried:2 postingsTouched:94 postingsTouchedSizeSum:1237720 postingsToFetch:0 postingsFetched:94 postingsFetchedSizeSum:1238440 postingsFetchCount:4 postingsFetchDurationSum:849477981 seriesTouched:93 seriesTouchedSizeSum:13619 seriesFetched:93 seriesFetchedSizeSum:20945152 seriesFetchCount:7 seriesFetchDurationSum:2209205202 chunksTouched:368 chunksTouchedSizeSum:243771 chunksFetched:368 chunksFetchedSizeSum:9558188 chunksFetchCount:76 chunksFetchDurationSum:19410111834 getAllDuration:1848805649 mergedSeriesCount:47 mergedChunksCount:368 mergeDuration:60013656}" err=null
```
It works!

Anything else we need to know:
I've configured the compact component as:
compact
      --log.level=info
      --retention.resolution-raw=30d
      --retention.resolution-5m=30d
      --retention.resolution-1h=10y
      --consistency-delay=30m
      --data-dir=/data
      --objstore.config-file=/config/thanos.yaml
      --wait

And as far as I see it's doing its work:
Logs of compact

```
level=info ts=2019-10-16T08:15:49.780661885Z caller=main.go:170 msg="Tracing will be disabled"
level=info ts=2019-10-16T08:15:49.781448872Z caller=factory.go:39 msg="loading bucket configuration"
level=info ts=2019-10-16T08:15:49.794832718Z caller=compact.go:251 msg="retention policy of raw samples is enabled" duration=720h0m0s
level=info ts=2019-10-16T08:15:49.794912434Z caller=compact.go:254 msg="retention policy of 5 min aggregated samples is enabled" duration=720h0m0s
level=info ts=2019-10-16T08:15:49.794926786Z caller=compact.go:257 msg="retention policy of 1 hour aggregated samples is enabled" duration=87600h0m0s
level=info ts=2019-10-16T08:15:49.794940895Z caller=compact.go:341 msg="starting compact node"
level=info ts=2019-10-16T08:15:49.794949212Z caller=prober.go:114 msg="changing probe status" status=ready
level=info ts=2019-10-16T08:15:49.795056156Z caller=main.go:353 msg="listening for requests and metrics" component=compact address=<IP_ADDRESS>:10902
level=info ts=2019-10-16T08:15:49.795165313Z caller=prober.go:143 msg="changing probe status" status=healthy
level=info ts=2019-10-16T08:15:49.795233513Z caller=compact.go:1063 msg="start sync of metas"
level=info ts=2019-10-16T08:15:50.312216312Z caller=compact.go:1069 msg="start of GC"
level=info ts=2019-10-16T08:15:50.315245595Z caller=compact.go:1075 msg="start of compaction"
level=info ts=2019-10-16T08:15:50.658389331Z caller=compact.go:264 msg="compaction iterations done"
level=info ts=2019-10-16T08:15:50.658457513Z caller=compact.go:271 msg="start first pass of downsampling"
level=info ts=2019-10-16T08:15:53.992421826Z caller=compact.go:277 msg="start second pass of downsampling"
level=info ts=2019-10-16T08:15:56.741387181Z caller=compact.go:282 msg="downsampling iterations done"
```

Environment:

OS:

$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.2 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.2 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Kernel:

$ uname -a
Linux gke-kube-eu-west-highmem-8-fbfa03ef-lvvr 4.15.0-1034-gke #36-Ubuntu SMP Thu Jun 6 11:16:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Others:
I've stoped during a moment the compact and verified the status of the bucket

Logs

$ thanos bucket verify --objstore.config-file=/config/thanos.yaml
level=info ts=2019-10-16T10:02:43.886890278Z caller=main.go:170 msg="Tracing will be disabled"
level=info ts=2019-10-16T10:02:43.887322586Z caller=factory.go:39 msg="loading bucket configuration"
level=warn ts=2019-10-16T10:02:43.888069338Z caller=verify.go:49 msg="GLOBAL COMPACTOR SHOULD __NOT__ BE RUNNING ON THE SAME BUCKET" issues=2 repair=false
level=info ts=2019-10-16T10:02:43.888110263Z caller=index_issue.go:29 msg="started verifying issue" with-repair=false issue=index_issue
level=info ts=2019-10-16T10:26:30.883476024Z caller=index_issue.go:130 msg="verified issue" with-repair=false issue=index_issue
level=info ts=2019-10-16T10:26:30.88374969Z caller=overlapped_blocks.go:26 msg="started verifying issue" with-repair=false issue=overlapped_blocks
level=info ts=2019-10-16T10:26:35.466468212Z caller=verify.go:68 msg="verify completed" issues=2 repair=false
level=info ts=2019-10-16T10:26:35.466838815Z caller=main.go:218 msg=exiting

It took more than 20 minutes, but finally worked.

Hi? Any probes configured? (:

True!
Indeed I found the liveness was a problem and I added initialDelaySeconds: 600. I'll try it again with initialDelaySeconds: 1800 and I'll let you know if it worked.
On any case, is it now doing anything else that justifies the longer startup time?

In case you use kube-thanos we recently added liveness probes and found that those are not properly made use of. Thus we removed liveness probes from kube-thanos entirely.
Before, we simply didn't have liveness probes on the store and simply never saw that.
Even if you don't use kube-thanos, you might have been bitten by the same scenario?!

:+1:

Ok, by now I'll assume working with v0.7.0, please don't do any breaking change until you improve the startup! ;)

The difference is that even without any memory limit nor probes it does not start. When the process reaches more or less 9 minutes it stops working and it's restarted by Kubernetes.
When I apply the same config with 0.7.0 it starts serving traffic after 5 minutes.

Thanks, investigating.

I've not seen any OOMKill event in my cluster logs :(

Spent some time on reproducing this but unfortunately no luck. Startup time and query seem to be not affected by v0.8.1 on my setup. We will keep an eye on this though.
Plus hopefully, new loading will improve loading to 0.

Cannot reproduce it here as well. https://github.com/kiwigrid/helm-charts/blob/master/charts/prometheus-thanos/templates/store-gateway-statefulset.yaml#L67-L83 might be the culprit.

Yesterday I removed the probes to be sure they weren’t producing the problem. 😔

It would be good to have an extra flag or more verbosing level than the current debug. Could it be possible? I could start a process using an image created from a branch and check it in production.

We can do that indeed if you want to help.

Of course!

Hi again,
I investigated it a bit on my own and bisected different commits using thanosbench
Bisection clearly saw almost 2x baseline memory usage against testing data after this commit: https://github.com/thanos-io/thanos/pull/1482 PR (commit).
I think some dep upgrades could introduce this, but I did not have time to look into profiles. It might be worth to grab this problematic commit and compare profiles with v0.7.0 or commit earlier. We need to dig deeper to know.
However, we could see different regression results on the different dataset:  https://cloud-native.slack.com/archives/CK5RSSC10/p1572426624394000
It's interesting what this commit could change. I need to focus on other things so help wanted to investigate deeper. I don't think it's a blocker, but it's not nice indeed.

Yesterday I give a try to the master version of the image (quay.io/thanos/thanos:master-2019-11-26-825f1199) and it works as expected. ;)


fix(storage): fix mem_store.flush(delete_ranges)

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Delete keys in given delete_ranges in RangeKvStateStore.
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

this https://github.com/risingwavelabs/risingwave/issues/8007 ?


[RFE] Add Inspektor Gadget as Minikube Addon

Current situation
Users who want to try Inspektor Gadget on Minikube needs to install it manually.
Minikube has addons but Inspektor Gadget is not among them:

$ minikube addons list
|-----------------------------|----------|--------------|--------------------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |           MAINTAINER           |
|-----------------------------|----------|--------------|--------------------------------|
| ambassador                  | minikube | disabled     | 3rd party (Ambassador)         |
| auto-pause                  | minikube | disabled     | Google                         |
| cloud-spanner               | minikube | disabled     | Google                         |
| csi-hostpath-driver         | minikube | disabled     | Kubernetes                     |
| dashboard                   | minikube | disabled     | Kubernetes                     |
| default-storageclass        | minikube | enabled ✅   | Kubernetes                     |
| efk                         | minikube | disabled     | 3rd party (Elastic)            |
| freshpod                    | minikube | disabled     | Google                         |
| gcp-auth                    | minikube | disabled     | Google                         |
| gvisor                      | minikube | disabled     | Google                         |
| headlamp                    | minikube | disabled     | 3rd party (kinvolk.io)         |
| helm-tiller                 | minikube | disabled     | 3rd party (Helm)               |
| inaccel                     | minikube | disabled     | 3rd party (InAccel             |
|                             |          |              |<EMAIL_ADDRESS>           |
| ingress                     | minikube | disabled     | Kubernetes                     |
| ingress-dns                 | minikube | disabled     | Google                         |
| istio                       | minikube | disabled     | 3rd party (Istio)              |
| istio-provisioner           | minikube | disabled     | 3rd party (Istio)              |
| kong                        | minikube | disabled     | 3rd party (Kong HQ)            |
| kubevirt                    | minikube | disabled     | 3rd party (KubeVirt)           |
| logviewer                   | minikube | disabled     | 3rd party (unknown)            |
| metallb                     | minikube | disabled     | 3rd party (MetalLB)            |
| metrics-server              | minikube | disabled     | Kubernetes                     |
| nvidia-driver-installer     | minikube | disabled     | Google                         |
| nvidia-gpu-device-plugin    | minikube | disabled     | 3rd party (Nvidia)             |
| olm                         | minikube | disabled     | 3rd party (Operator Framework) |
| pod-security-policy         | minikube | disabled     | 3rd party (unknown)            |
| portainer                   | minikube | disabled     | 3rd party (Portainer.io)       |
| registry                    | minikube | disabled     | Google                         |
| registry-aliases            | minikube | disabled     | 3rd party (unknown)            |
| registry-creds              | minikube | disabled     | 3rd party (UPMC Enterprises)   |
| storage-provisioner         | minikube | enabled ✅   | Google                         |
| storage-provisioner-gluster | minikube | disabled     | 3rd party (Gluster)            |
| volumesnapshots             | minikube | disabled     | Kubernetes                     |
|-----------------------------|----------|--------------|--------------------------------|

Impact
It is a barrier for new users to learn about Inspektor Gadget.
Ideal future situation
Users could start Minikube with Inspektor Gadget enabled with:
$ minikube start
$ minikube addons enable gadget

Implementation options
The addons would only add IG in the Minikube cluster but it would not install kubectl-gadget.
Additional information

Similar was done for Headlamp: https://github.com/kubernetes/minikube/pull/14315

cc @yolossn @joaquimrocha

https://github.com/kubernetes/minikube/pull/15869


Wave Header Incorrect

First of all many thanks for this great module.
When trying to use it we discovered an issue with .wav-file that was generated.
Android refused to play the file.
After some comparisons we found the header of generated files are incorrect.
While a some music players accept that, others like on Android do not.
The documentation we found shows that file length is calculated like this:
"Size of the overall file - 8 bytes, in bytes (32-bit integer). "
So that means that line 48 of AudioFunctions should be:
writer.Write (audioLength - 1);
Then the data length is filelength minus the header.
And line 74:
writer.Write (audioLength-44);
Best regards,
Marco

This very well could be the case... most of that code I adapted from the public domain. Could you point me to the docs you mention above?

That's described on many pages, but this is one of them:
https://wiki.fileformat.com/audio/wav/

Based on that spec it seems to already be compliant:
audioLength is the data length, not the file length. It's the byte count of the captured audio data.

5 - 8 | File size (integer) | Size of the overall file - 8 bytes, in bytes (32-bit integer). Typically, you'd fill this in after creation.

The overall file length would be audioLength + header length (44 bytes). The 36 being used now is 44 - 8 bytes. So:
Size of the overall file - 8 bytes == audioLength + 44 - 8
Also, since audioLength is a byte count, and they want this value in bytes, we stick in that unit. audioLength - 1 would in essence just be subtracting 1 byte from the total count.

41-44 | File size (data) | Size of the data section.

Since audioLength is the data length (and not file length), no need to subtract 44 for the header.
How were you having issues playing the files? The built in audio player uses the MediaPlayer API on Android and I've never seen issues there.

The Android default media players simply stated they could load the file.
Also the MediaPlayer API couldn't play it normally.
Please check the WriteWavHeader () method.
The header code overwrites the first 44 bytes to store the header.
So it's not adding 44 bytes to the file length.
Line 48 I gave was in the description was incorrect.
The source changes contain the correct change:
writer.Write ((Int32)(audioLength - 8));

So weird... I've never seen issues with MediaPlayer in my testing. But great catch! audioLength actually IS the file length here, so my basic assumption was wrong.


Firefox function instead of string

Version: 4.10.5
Browser: Firefox 46.0.1
Error:

TypeError: str.indexOf is not a function

Notes:
The implementation of endsWith(str, suffix) is being called with str as a function, the origin of the call is from gerund(o).
PS:
This doesn't happen when you run the demo in 4.10.5 because that demo is pulling the library from<EMAIL_ADDRESS>If you change that to 4.10.5 the demo fails as above. Simply loading that library in Firefox fails.

AHHHH!

Davy, thank you so much for this.
I've rolled-back the used library version to 4.5.1, and the website loads now. That was a great idea.
The issue involves me forgetting to use hasOwnProperty, and the word 'watch' gets conjugated, it passes-around Object.watch().
I'll look at a proper fix for this very soon
cheers man

:+1:
PSS: So far this is a really cool Javascript library! I'll definitely be thinking of ways to leverage this kind of functionality in future projects.


Binding attachment before a clusterInvoker invoke.

Binding attachments into invocation so that a rpc invoke have a same invocation
Fix a bug that the ForkingClusterInvoker don't clear attachment when a rpc invoke is over.

Codecov Report

Merging #2125 into master will decrease coverage by 0.08%.
The diff coverage is 79.41%.

@@             Coverage Diff             @@
##             master   #2125      +/-   ##
===========================================
- Coverage     54.19%   54.1%   -0.09%
+ Complexity     5085    5081       -4
===========================================
  Files           559     559
  Lines         24922   24926       +4
  Branches       4442    4443       +1
===========================================
- Hits          13506   13487      -19
- Misses         9380    9402      +22
- Partials       2036    2037       +1

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/dubbo/rpc/protocol/AbstractInvoker.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...bo/rpc/cluster/support/AbstractClusterInvoker.java
70.47% <66.66%> (-0.12%)
42 <0> (+1)

...bbo/rpc/cluster/support/ForkingClusterInvoker.java
85.71% <83.33%> (+0.42%)
7 <6> (ø)
:arrow_down:

...che/dubbo/remoting/transport/mina/MinaChannel.java
42.25% <0%> (-11.27%)
15% <0%> (-1%)

...e/dubbo/remoting/transport/netty/NettyChannel.java
57.5% <0%> (-8.75%)
19% <0%> (-2%)

...he/dubbo/remoting/transport/netty/NettyClient.java
72.88% <0%> (-8.48%)
12% <0%> (-1%)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
77.2% <0%> (-1.48%)
29% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
58.33% <0%> (-0.84%)
30% <0%> (-1%)

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
88.88% <0%> (+5.55%)
7% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6e6f3...d03a7b1. Read the comment docs.


List Row setting breaks some dropdowns

Steps to reproduce:
Enable "apc.listRow" with height and fontSize
Open a dropdown for icons in the settings editor - I search for "terminal default icon":

This is what the dropdown is supposed to look like, with apc.listRow off:

should be fixed with v0.3.0


Add new pre-commit hook.

Hi Milos,
Created a new way of sharing git-hooks across all php-projects.
Created a PR to get some feedback from you.
The idea is with just one dependency set git hooks without having to configure anything else.
This will also allow you to use the exact same hooks on all different projects without any effort and all contributors will have the same.

Scrutinizer failed with some dependencies, not sure why, when travis passed... Have retried it now... Will see
Other thing that catch my eye is your GPL3 license... Not sure how that is compatible with MIT license.
It's doing some magic with composer I'm not familiar with.
Have to see trough, can not merge this right now.

@tmilos Updated license to MIT, just want to help all open source projects with this git-hooks-php package :)

Sorry @BernardoSilva but some people are against "fiddling with their Git configuration", think we won't add this: https://github.com/lightSAML/lightSAML/pull/3
cc @cb8


Unable to Build

I cannot build this software, because https://github.com/ShayBoxs-Forks/clap-verbosity-flag is not a publicly accessible repository.

I have released a maintenance update and switched to the upstream clap verbosity flag crate

Thanks. It builds now.


Enhance validation and defaults of bias metric config form

We need a few improvements to the bias metrics config form:

The default value populated for the"violation threshold" field should be based on the user selected type of the bias metric config. Reference the defaultDelta values specified here: https://github.com/opendatahub-io/odh-dashboard/blob/694ada2446c53e48364f6c0f8e7020af79164435/frontend/src/pages/modelServing/screens/metrics/const.ts#L26-L71

DIR threshold delta has an acceptable range of 1 >= x >= 0 - this needs to be validated (SPD does not have this constraint).

Also when duplicating a bias metric config, the "Metric name" field should be prepopulated with "Copy of x" where x is the name of the config being duplicated.

--

Tracker: #1127

Do we also want to add tooltips and descriptions in this issue? They are all the enhancements for the configuration form. Or do you want to create a separate issue to trace that? @alexcreasy

@DaoDaoNoCode Oh yeah, meant to put that in, updating now :)


MRC-1202: Fix for initializing the http protocol since kubes env will…

… always be http

Looks good to me.


FloatActionButton Mini

Trying to make a mini FloatingActionButton I set the width and height of the com.rey.material.widget.FloatingActionButton to 30dp, but I found that it can not get smaller than a number arround 40 dp , actually do not know if it's the image which prevents the FAB to get smaller of what , but what I think is good to be done is for it to be able to scale down the image inside, so a mini FAB can be achieved.
http://www.google.com/design/spec/components/buttons-floating-action-button.html#

Can you post the xml and code you used?

xml :
    <com.rey.material.widget.FloatingActionButton
                style="@style/FloatMini"
                android:id="@+id/getAccountListBtn"
                android:layout_width="@dimen/btn_float_mini"
                android:layout_height="@dimen/btn_float_mini"
                android:layout_alignBottom="@id/AccountText"
                android:layout_alignParentEnd="true"
                app:fab_iconSrc="@drawable/search_account"/>

Style:
<style name="FloatingWaveColorActionButton" parent="Material.Drawable.Ripple.Wave.Light">
    <item name="rd_rippleColor">#33000000</item>
    <item name="fab_backgroundColor">#FF2196F3</item>
    <item name="fab_elevation">4dp</item>
</style>

<style name="FloatMini" parent="FloatingWaveColorActionButton">
    <item name="fab_elevation">0dp</item>
</style>

dimen:
<dimen name="btn_float_mini">30dp</dimen>

drawable:

The size of FAB is set by fab_radius attribute, not by android:layout_width and android:layout_height attribute. Please view Button wiki page for more available attributes.

My mistake!
would have been perfect if it was working with height and width too,
the library is awesome though
keep up the great work man !


Investigate Codecov not showing coverage correctly

Seems coverage reports are not rendering.
Could this be to do with the reports being merged that use Windows-style paths on Windows and POSIX-style paths on Linux and MacOS?
How do we fix this?

Hi, can you check the link below?
https://docs.codecov.com/docs/unexpected-coverage-changes

Think the issue is more around the file previews not showing up, than the coverage differing :-)

You were right about the issue i think it's about paths
https://codecov.freshdesk.com/support/solutions/articles/43000593943-files-not-showing-in-codecov-fixing-paths-

I am wondering if a simpler solution may be just to have a shell script that uses the JaCoCo CLI  to merge the reports manually, if possible, and then upload the single report to CodeCov.
Another solution might be to use XSLT to somehow fix the path names if that is the issue.
I'll try making a PR that disables the windows runners (won't merge it, but it should be enough to trigger a new report being made and uploaded). If this shows the file contents on codecov, it means that the Windows-style paths are the issue!

Doesn't seem to be this. I am a bit baffled. Might need to open an issue with CodeCov to get some help on this one.

Seems to have magically fixed itself, weirdly.


Weird route

https://routeplanner.bike.brussels/#14.20/50.8724/4.3544?sb=true&o=4.3524161,50.8725291&d=4.3718563,50.8699161&p=profile1
Not exactly sure why it jumps on PP + SZ instead of staying on B.

This part is oneway, also for cyclists:
https://www.openstreetmap.org/way/526248199

Aaand it's pretty clear this is not the case on the ground:
https://www.mapillary.com/app/?pKey=8qYaGeUjitWp8vGFzA-khg&focus=photo

Yep ! I was looking at it too !
Thanks for the catch and the fix ! 👌

Should be fixed tomorrow after data update:
https://www.openstreetmap.org/changeset/86125165
To be closed when confirmed! Thanks @jbelien :heart_eyes:

I also fixed oneway attributes for

https://www.openstreetmap.org/way/559845586
https://www.openstreetmap.org/way/812447827

Route is correct now but it appears in black.
But after I cleaned the local storage, it was back to the original issue (using PP + SZ instead of B)

We are testing a new routing profile in one of the three instances. Thanks for spotting this, the routes being black is something broken that we didn't notice yet. cc @pietervdvn

Cause of the issue, the change in route profiles changed the output. For example:
       "name": "Rue Marie-Christine - Maria-Christinastraat",
        "highway": "tertiary",
        "maxspeed": "30",
        "surface": "asphalt",
        "_relation:brussels:bicycle_network_by_operator": "yes",
        "_relation:commute:bicycle_network_by_operator": "yes",
        "_relation:b2w:bicycle_network_by_operator": "yes",
        "_relation:bicycle_network_is_bicycle_network": "yes",
        "profile": "bicycle.brussels",
        "distance": "580.07404",
        "time": "139.79376"

use to be this:
        "name": "Rue de Molenbeek - Molenbeeksestraat",
        "cycle_network_colour": "#F6A31A",
        "highway": "residential",
        "surface": "sett",
        "cycle_network": "yes",
        "StadGenk": "yes",
        "Anyways": "yes",
        "BrusselsMobility": "yes",
        "profile": "bicycle.brussels",
        "distance": "59.274055",
        "time": "14.801773"

Most likely the 'cycle_network_colour' attribute is needed.

Ok the update is done but route still doesn't look very good:

Awesome! Thanks :)

I don't really understand that "decision":

And would it be possible to "prioritize" to stay on route B (even if it's a bit longer) ?

Split into:
https://github.com/anyways-open/cycling-routeplanner/issues/33
https://github.com/anyways-open/cycling-routeplanner/issues/34


Add a Open Source Licence

Could you add an open source licence like BSD or Apache 2.0 to your repo? I would like to use it but without the licence it is a bit nebulous what I can do with the code.

Which one would be the most permissive?

BSD https://opensource.org/licenses/BSD-3-Clause
Basically it allows others to use you work. They only need to cite the fact that they used your work and maintain the existing copyright info

Done


Adding an option to (de)activate Pilot integration into the Traefik dashboard

What does this PR do?
This PR adds an option (--pilot.dashboard or TRAEFIK_PILOT_DASHBOARD) to remove pilot usage in the dashboard.
When set to false, it removes both the buttons in the navigation bar and the side panel.
Motivation
It will allow the use of the traefik dashboard without pilot ever being called.
Closes #7360
More

[ ] Added/updated tests
[X] Added/updated documentation

Additional Notes
Co-authored-by: Jean-Baptiste Doumenjou<EMAIL_ADDRESS>

What does this PR do?
This PR adds an option (--pilot.dashboard or TRAEFIK_PILOT_DASHBOARD) to remove pilot usage in the dashboard.
When set to false, it removes both the buttons in the navigation bar and the side panel.
Motivation
It will allow the use of the traefik dashboard without pilot ever being called.
Closes #7360
More
* [ ]  Added/updated tests

* [x]  Added/updated documentation

Additional Notes
Co-authored-by: Jean-Baptiste Doumenjou<EMAIL_ADDRESS>
This should be set to false by default ( i.e.: OPT-IN in accordance to European GDPR law )

Should either be false by default or dashboard should only be shown if --pilot.token/TRAEFIK_PILOT_TOKEN is set. I'd prefer the latter one to avoid adding another config switch altogether.

Should either be false by default or dashboard should only be shown if --pilot.token/TRAEFIK_PILOT_TOKEN is set. I'd prefer the latter one to avoid adding another config switch altogether.

I agree, there is no need to turn off what should be turned off by default

That would be a breaking behaviour change, which we will try to avoid obviously (as we respect semver). As we will have an update to the platform as well.
For splitting the config, this is intentional and I can explain why. In use cases, it should be possible to send data to pilot but just have one Traefik instance with the button. Thus, we decided to split configs.

Will this also disable the usage of plugins? Since they depend on Pilot?

Hi @pascalandy,
This PR remove the pilot integration in the dashboard, It does not change the behaviour for traefik plugins.

Is it expected that this option can't be set in static config files? ie in YAML file it complains:
command traefik error: field not found, node: dashboard

pilot:
    dashboard: false

(Can raise as an actual issue if needed)

@RealOrangeOne what is your Traefik version?
This option will be available in the v2.4.8 (the Docker image will be available soon)

the Docker image will be available soon

Ah, that'd explain it! Did a pull and assumed it updated. Will eagerly await!

Adding it to the example configuration yaml & toml files would have also been helpful.


Reduce size of incident_cls.pt

To enable GH tracking of incident_cls.pt, we need to decrease it's size significantly. It seems like we're doing this by pre-meaning the cls embeddings for each incident ID.

This should also include switching the formatting of this state from a torch.Tensor of shape NxMx768 for N incident_ids, M incident_reports per id, and 768 values in the CLS for each report, to <ID(1), N_INC(1), MEAN_CLS(768)>(~150)

We might want to add to this issue the requirement that we remove mean-ing from runtime calculations of the cosine similarity.


feat: port to typescript

Description

Port to TypeScript
Use @swup/cli for bundling
Includes version bump
Includes changelog update

Checks

[x] The PR is submitted to the master branch
[x] The code was linted before pushing (npm run lint)

sorry formatting :)


Connection time to wifi

With a wifi network defined, i find that the i-gate often doesn't connect and launches the hotspot too quickly.
I might have to reboot it a couple of times for it to establish connection to the defined network.
(on the previous version, where there were multiple AP's defined, i also found it would do a lap of them before successfully connecting)
Is there a setting in the code that defines this wait time that i can tweak and confirm it resolves the issue?
The new web interface is much easier to configure than doing it in VSC - thanks.

Hi,
when it achieves the wifi connection does it keeps connected?
could it be the router to slow?

Hi Rich,
Yes, once connected it stays up.
My config here is a Draytek 2862 non wifi router, with 2x draytek AP902 access points, so not poor quality internet service provider supplied devices.
I am using  lilygo T3_v1.6 1
The behaviour appears to be consistent.
From a cold power up, it fails to connect to the wifi and launches the hotspot.
Pressing the reset button to cause a reboot, without removing power, it connects straight away at the reboot.
I can try and provide a video if you want?
Many thanks for the software! Developers such as you are much appreciated!
Regards
Jon Eyes
Sent from my Galaxy
-------- Original message --------
From: "Ricardo Guzman (Richonguzman)" @.>
Date: 05/04/2024 13:01 (GMT+00:00)
To: richonguzman/LoRa_APRS_iGate @.>
Cc: Jon Eyes @.>, Author @.>
Subject: Re: [richonguzman/LoRa_APRS_iGate] Connection time to wifi (Issue #67)
Hi,
when it achieves the wifi connection does it keeps connected?
could it be the router to slow?
—
Reply to this email directly, view it on GitHubhttps://github.com/richonguzman/LoRa_APRS_iGate/issues/67#issuecomment-2039621838, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2Y66CGZTGVCYSFRDFI4BLY32OCNAVCNFSM6AAAAABFU64UMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGYZDCOBTHA.
You are receiving this because you authored the thread.Message ID: @.***>

the solution is not very good, but what if it stays like it is?
when you reboot it connects right away...  does the AP reboots after a few mins to try to connect to wifi by its own ?

Ok, let me remove power and try again.
Are you thinking it may reconnect when the auto AP times out through no client connection?
Regards
Jon Eyes
Sent from my Galaxy
-------- Original message --------
From: "Ricardo Guzman (Richonguzman)" @.>
Date: 05/04/2024 17:40 (GMT+00:00)
To: richonguzman/LoRa_APRS_iGate @.>
Cc: Jon Eyes @.>, Author @.>
Subject: Re: [richonguzman/LoRa_APRS_iGate] Connection time to wifi (Issue #67)
the solution is not very good, but what if it stays like it is?
when you reboot it connects right away... does the AP reboots after a few mins to try to connect to wifi by its own ?
—
Reply to this email directly, view it on GitHubhttps://github.com/richonguzman/LoRa_APRS_iGate/issues/67#issuecomment-2040235541, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2Y66GDPFKWFDDA6BDZRNTY33OWXAVCNFSM6AAAAABFU64UMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGIZTKNJUGE.
You are receiving this because you authored the thread.Message ID: @.***>

I reset the auto AP to a 2 minute time out.
The Auto AP switches off, and it doesn't try to connect.
If I reboot it using the reset button, it fails the first time and then if I reboot it agaon using the reset button while the auto AP  is active, it connects straight away.
Regards
Jon Eyes
Sent from my Galaxy
-------- Original message --------
From: Jon Eyes @.>
Date: 05/04/2024 17:47 (GMT+00:00)
To: richonguzman/LoRa_APRS_iGate @.>
Subject: RE: [richonguzman/LoRa_APRS_iGate] Connection time to wifi (Issue #67)
Ok, let me remove power and try again.
Are you thinking it may reconnect when the auto AP times out through no client connection?
Regards
Jon Eyes
Sent from my Galaxy
-------- Original message --------
From: "Ricardo Guzman (Richonguzman)" @.>
Date: 05/04/2024 17:40 (GMT+00:00)
To: richonguzman/LoRa_APRS_iGate @.>
Cc: Jon Eyes @.>, Author @.>
Subject: Re: [richonguzman/LoRa_APRS_iGate] Connection time to wifi (Issue #67)
the solution is not very good, but what if it stays like it is?
when you reboot it connects right away... does the AP reboots after a few mins to try to connect to wifi by its own ?
—
Reply to this email directly, view it on GitHubhttps://github.com/richonguzman/LoRa_APRS_iGate/issues/67#issuecomment-2040235541, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2Y66GDPFKWFDDA6BDZRNTY33OWXAVCNFSM6AAAAABFU64UMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGIZTKNJUGE.
You are receiving this because you authored the thread.Message ID: @.***>

I experienced few times that after saving some settings on my iGate (Lilygo T3_v1.6 1) it won't connect to local WiFi. I have to connect to AP and reboot board, after that works fine.

After discussing the issue with Andy GM0UDL today, he suggested setting the AP time to 0 to disable it, as others in his area have had success with that option.
I've tried this tonight and the problem persists, except the AP doesn't start.
Rebooting the T3 again and it connects to wifi straight away.
Is this an issue peculiar to this hardware, as two of us have the same issue?
Regards
Jon Eyes
Sent from my Galaxy
-------- Original message --------
From: KD9PKP @.>
Date: 14/04/2024 15:32 (GMT+00:00)
To: richonguzman/LoRa_APRS_iGate @.>
Cc: Jon Eyes @.>, Author @.>
Subject: Re: [richonguzman/LoRa_APRS_iGate] Connection time to wifi (Issue #67)
I experienced few times that after saving some settings on my iGate (Lilygo T3_v1.6 1) it won't connect to local WiFi. I have to connect to AP and reboot board, after that works fine.
—
Reply to this email directly, view it on GitHubhttps://github.com/richonguzman/LoRa_APRS_iGate/issues/67#issuecomment-2054081060, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2Y66GJUH2GW257DMSTTS3Y5KHQZAVCNFSM6AAAAABFU64UMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJUGA4DCMBWGA.
You are receiving this because you authored the thread.Message ID: @.***>

sometimes the Wifi/Router won't allow to be reconnected right away.... so in this delta/time the boards does a complete process of all wifi available to connect and starts again to get finally connection.
sometimes works supper fast, sometimes not.
we were talking about having the AP being "killed" after configuration to only stay in the "keep on trying on the Wifis saved" and not get again into WIFI AP mode

Yes.
However, even when the AP times out, it won't connect to the saved wifi unless the device is rebooted
Regards
Jon Eyes
Sent from my Galaxy
-------- Original message --------
From: "Ricardo Guzman (Richonguzman)" @.>
Date: 16/04/2024 06:51 (GMT+00:00)
To: richonguzman/LoRa_APRS_iGate @.>
Cc: Jon Eyes @.>, Author @.>
Subject: Re: [richonguzman/LoRa_APRS_iGate] Connection time to wifi (Issue #67)
sometimes the Wifi/Router won't allow to be reconnected right away.... so in this delta/time the boards does a complete process of all wifi available to connect and starts again to get finally connection.
sometimes works supper fast, sometimes not.
we were talking about having the AP being "killed" after configuration to only stay in the "keep on trying on the Wifis saved" and not get again into WIFI AP mode
—
Reply to this email directly, view it on GitHubhttps://github.com/richonguzman/LoRa_APRS_iGate/issues/67#issuecomment-2058280580, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU2Y66C2AIFP3M7OUFRMB4DY5S37NAVCNFSM6AAAAABFU64UMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGI4DANJYGA.
You are receiving this because you authored the thread.Message ID: @.***>

this should be solved with new code added recently

Hi Rich,
I've upgraded to the latest version with a clean install - it's still the same.


SSL Error: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed

I am using Python 2.7.9 with OpenSSL 1.0.1f 6 Jan 2014 .
On building the following code
 from firebase import firebase
 firebase = firebase.FirebaseApplication('https://test.firebaseio.com',None)
 data = {'testVal': '0'}
 result = firebase.post('/user', data)
 print (result)

However I got the following error
    File "/usr/local/lib/python2.7/dist-packages/firebase/decorators.py", line 19, in wrapped
      return f(*args, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/firebase/firebase.py", line 329, in post
      connection=connection)
    File "/usr/local/lib/python2.7/dist-packages/firebase/decorators.py", line 19, in wrapped
      return f(*args, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/firebase/firebase.py", line 97, in make_post_request
      timeout=timeout)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 340, in post
      return self.request('POST', url, data=data, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 279, in request
      resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 374, in send
      r = adapter.send(request, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 213, in send
      raise SSLError(e)
  requests.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)

However, I ran the same code on cloud9 IDE, it ran with no issues.
It has Python 2.7.6 and OpenSSL 1.0.1f 6 Jan 2014
Hence, using virtualenv for Python 2.7 solved the problem for me.


Public vs private classes

•	Lots of public classes which don't need to be public (not public in C# version).

This was solved by PR #40


Add support for using specific kernel release

This patch adds support for explicitly specifying the kernel release to be used, through a dedicated command-line argument. The -r, --release flag has been introduced for this purpose. It requires a string argument in the format of a kernel release (e.g. 5.3.0-45-generic, generally the same format as output by uname -r).
The gen_stap.sh script will assume the kernel release to be the output of uname -r in case no explicit release is given at the command line.
Two additional checks have been performed to validate the input release against the filesystem.

Good feature, thanks.


Add zigbee2mqtt

RE-CHECK!

Automated adapter checker
ioBroker.zigbee2mqtt

:thumbsup: No errors found

[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
[ ] :eyes: [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, zh-cn)
[ ] :eyes: [W400] Cannot find "zigbee2mqtt" in latest repository

Add comment "RE-CHECK!" to start check anew

Hi,
hhere a short review feedback:

not critical but if you use Async you shoulkd also await it ... or use the "Non async" method :-) e.g. https://github.com/o0shojo0o/ioBroker.zigbee2mqtt/blob/main/main.js#L55
please also close the websocket/mqtt connections on unload

Rest I only fly over and looked ok ... Please check and adjust the above

Thank you for your review, I have fixed all the points.

@Apollon77 are there still open points?

Yes me finding time for recheck.

Add to stable @2.5.0

Update stable to v2.6.0

oooooohhhhh @o0shojo0o one thing ... type "lighting"??? I think it is more or? type "hardware" like ziugbee adapter?
A change here would be "io.package change on github" and the PR here ... Can you please do that before I merge?
A new release is not urgently needed ... enough for next update

fixed ;)


Timeout should be positive error in connection.rb:17

  redis = Redis.new(:host => ":memory:", :driver => Rlite::Connection::Hirlite)
  redis.set 'key', 'value'
#ArgumentError: timeout should be positive
#hirlite-<IP_ADDRESS>/lib/hirlite/connection.rb:17:in `connect'

Using:
Mac OS 10.10.1
Ruby 2.1.2

Thanks for the report, I'm looking into it.
As a work around, you can provide :connect_timeout with a positive number.

What version of Redis gem are you running?

The problem happens if you are not using the gem redis 3.2.1 because :timeout was renamed to :connect_timeout.
I've changed rlite-rb to stop validating the parameter (which was ignored anyway) and will be fixed in the next release https://github.com/seppo0010/rlite-rb/commit/dc7d5e03418996195285c6a5d14994fb94da064b
In the meanwhile, you can either provide :connect_timeout or update your gem.


ContextualHelp: Update type descriptions and forwardRef

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Since contextual help has a different placement default would it make sense to override that prop too?

Since contextual help has a different placement default would it make sense to override that prop too?

Good catch, I forgot about that. Just pushed a fix.


Run zip file on another computer to make sure it works

Testing on the windows computer in 163. Running 3.3.1 - had to install tidyverse,

Ran on Emily's windows computer using R 3.5.2, no RStudio, and sourced the compile.R script from the command line.  In order for this to work you have to set the working directory first:
setwd("C://Users/pinsky_lab_admin/Downloads/OceanAdapt/") source("compile.R:)
Messages but no errors.


packaging issue: deployment of tests

What happened
The issue is that the setup.py is deploying the tests folder under the root python path and not under this package one.
So it's end up under /usr/lib/python3.11/site-packages/tests rather than /usr/lib/python3.11/site-packages/kube-hunter/tests and so conflicts with other packages having the same issue.
Anyway usually test are not shipped in a release package so the easiest would just to remove them. Else they should be deployed in the children directory.
It's explained in ArchLinux packaging guidelines for Python: https://wiki.archlinux.org/title/Python_package_guidelines#Test_directory_in_site-package
Expected behavior
No file deployed on the root python path.

Usually this fix in setup.py is enough:
-packages=find_packages(),
+packages=find_packages(exclude=["tests*"]),

But this method is not used here, so I won't PR as I don't know what's required to exclude the tests folder in this case.


Add YouTube to MP4 (https://youtube321.com

Added a website to download YouTube videos to MP4. No ads or BS, safe and free.

Bump

https://github.com/Igglybuff/awesome-piracy/pull/524#issuecomment-848969254


Should ARVRController method name match InputEvent nomenclature?

InputEvent uses "device" property to let programmer know which input device emitted the event, but ARVRController uses get_joystick_id() method to identify it.
It is a bit confusing know that they are the same ID stuff due to different name usage.
Or aren't they the same ID ?

Ping @BastiaanOlij

Hey @rodolforg ,
Hmm good question, not sure. The reason the ARVRController uses the joystick id is because we tie into the joystick API of Godot. So a controller is registered as a joystick, the joystick API will then send out input events as needed.
I'm not sure how the joystick id relates to the device id in the events, they may be the same

Ping @Hinsbart , do you know how the device id in the events relate to the joystick id?

They are the same, yes.


Appendix: Publish an Addon

This PR contains information on how to publish an Addon in the marketplace.
It contains:

an opinionated approach for CI/CD & release management
information on how to publish to global.repo.jmix.io
Information on how to update versions in Jmix BOM

Open topics:

Information on how to register a new addon for the marketplace

Please replace "addon" with "add-on" everywhere in the text.

@mariodavid - could you finish the work according to my comments above? Perhaps directly in master since the PR is merged.


operator raise error want to expand pvc but storageClass doesn't support it, need to handle this case manually

Operator Version:  v0.39.0
Kubernetes:  v1.28.3-eks-4f4795d
vmcluster yaml:

apiVersion: operator.victoriametrics.com/v1beta1
kind: VMCluster
metadata:
  name: vmcluster
  namespace: monitoring
spec:
  clusterVersion: v1.93.4-cluster
  retentionPeriod: "12"
  replicationFactor: 2
  vmstorage:
    replicaCount: 3
    storageDataPath: "/vm-data"
    storage:
      volumeClaimTemplate:
        spec:
          resources:
            requests:
              storage: 200Gi
    resources:
      requests:
        cpu: "1"
        memory: 4Gi
      limits:
        cpu: "2"
        memory: 6Gi
  vmselect:
    replicaCount: 2
    cacheMountPath: "/select-cache"
    extraArgs:
      search.maxUniqueTimeseries: "3000000"
      search.maxSamplesPerQuery: "10000000000"
      search.maxQueryLen: "65536"
    storage:
      volumeClaimTemplate:
        spec:
          resources:
            requests:
              storage: 10Gi
    resources:
      requests:
        cpu: "1"
        memory: "500Mi"
      limits:
        cpu: "1"
        memory: "2000Mi"
  vminsert:
    replicaCount: 2
    resources:
      limits:
        cpu: "1"
        memory: "1000Mi"

operator error logs:

{"level":"error","ts":"2023-12-11T06:44:02.329Z","logger":"client_utils","msg":"want to expand pvc but storageClass doesn't support it, need to handle this case manually","pvc":"vmstorage-db-vmstorage-vmcluster-1","stacktrace":"github.com/go-logr/logr.Logger.Error\n\tgithub.com/go-logr/logr@v1.2.4/logr.go:299\ngithub.com/VictoriaMetrics/operator/controllers/factory/k8stools.growSTSPVC\n\tgithub.com/VictoriaMetrics/operator/controllers/factory/k8stools/expansion.go:165\ngithub.com/VictoriaMetrics/operator/controllers/factory/k8stools.HandleSTSUpdate\n\tgithub.com/VictoriaMetrics/operator/controllers/factory/k8stools/sts.go:83\ngithub.com/VictoriaMetrics/operator/controllers/factory.createOrUpdateVMStorage\n\tgithub.com/VictoriaMetrics/operator/controllers/factory/vmcluster.go:294\ngithub.com/VictoriaMetrics/operator/controllers/factory.CreateOrUpdateVMCluster\n\tgithub.com/VictoriaMetrics/operator/controllers/factory/vmcluster.go:63\ngithub.com/VictoriaMetrics/operator/controllers.(*VMClusterReconciler).Reconcile\n\tgithub.com/VictoriaMetrics/operator/controllers/vmcluster_controller.go:77\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234"}

Are you trying to increase storage size in vmstorage.storage.volumeClaimTemplate.spec.resources.storage?
operator will report this error when you try to increase the size and the storageClass under it doesn't support resize.

metoo
{"level":"error","ts":1702452176.854926,"logger":"client_utils","msg":"want to expand pvc but storageClass doesn't support it, need to handle this case manually","pvc":

metoo operator version v0.39.4
Setting WATCH_NAMESPACE to a specific namespace reports this error.
Setting WATCH_NAMESPACE to an empty value does not report this error.
{"level":"error","ts":1702452176.854926,"logger":"client_utils","msg":"want to expand pvc but storageClass doesn't support it, need to handle this case manually","pvc":

@jicki Yeah, that's on purpose. When single namespace is been specified, operator doesn't have enough permission to list storageClass clusterwide, so the error will be reported when trying to grow storage size in vmstorage.storage.volumeClaimTemplate.spec.resources.storage.
https://github.com/VictoriaMetrics/operator/blob/134141147207487310328ea2fca74ff8dfac4da2/controllers/factory/k8stools/expansion.go#L194-L199

Hello, it's a limitation of single namespace mode for operator as @Haleygo mentioned.
Current work around for it - add specifal annotation for persistentVolumeClaimTemplate: operator.victoriametrics.com/pvc-allow-volume-expansion: "true"
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMCluster
...
spec:
  ....
  vmstorage:
   ....
    storage:
      volumeClaimTemplate:
       metadata:
         annotations:
              operator.victoriametrics.com/pvc-allow-volume-expansion: "true"
        spec:
          resources:
            requests:
              storage: 200Gi

Exists persistent volumes must be manually annotated.

Must be properly fixed at v0.42.0 release


[useIsFocusVisible] Restore focus-visible polyfill if tab was hidden for a long time

Tested https://codesandbox.io/s/detect-blur-due-to-tab-out-vt5qr?file=/src/App.js in IE 11, Firefox 78, Edge 91 and Chrome 95 (deploy: https://codesandbox.io/s/detect-blur-due-to-tab-out-vt5qr?file=/src/App.js).
Will confirm with https://codesandbox.io/s/interesting-breeze-xy5qh?file=/src/Demo.tsx

Actually it's not that important and requires too much testing. And it may even just work incidentally.


Information not specific enough - Encryption in the Microsoft Cloud

What about TLS 1.3 or in general newer TLS than 1.2 (means: TLS > 1.2)? See last paragraph on the site.
No info about encryption with AES although this article (https://docs.microsoft.com/en-us/office365/enterprise/office-365-sharepoint-online-data-deletion) states that we get more information about that in this article.
this article (https://docs.microsoft.com/en-us/office365/enterprise/office-365-sharepoint-online-data-deletion) mentions this:

In SharePoint Online, all content that a customer uploads is broken into chunks, encrypted (potentially with multiple AES 256-bit keys), and distributed across the datacenter.

Is it just one datacenter? I think the data is synced over multiple datacenters. What does potentially mean here? This is too vague.
I think both articles should be updated and clarified with respect to each other.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 817fbe87-a720-b940-e27b-3e98b20e68e3
Version Independent ID: f998f64e-e05a-0ce1-85cd-30bbd537b5ae
Content: Encryption in the Microsoft Cloud
Content Source: microsoft-365/compliance/office-365-encryption-in-the-microsoft-cloud-overview.md
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

？

Spam comments will be removed without notice.

potentially = one or more. data synced over multiple datacenters for geo.


problem about evaluating

Hi tianwei,
i want to try to use the evaluation for tracking, and i just run as follow:
python tools/nusc_tracking/pub_test.py   --work_dir work_dirs/ --checkpoint detection_dirs/detection.json
work_dirs is empty, detection.json from your model zoo:
https://drive.google.com/file/d/1GJzIBJKxg4NVFXF0SeBzmrL87ALuIEx0/view
but the following error was encountered:
KeyError: 'fd8420396768425eabec9bdddf7e64b6'
the code going wrong is as follow in pub_test.py:
`nusc_annos = {
"results": {},
"meta": None,
}
size = len(frames)
print("Begin Tracking\n")
start = time.time()
for i in range(size):
    token = frames[i]['token']

    # reset tracking after one video sequence
    if frames[i]['first']:
        # use this for sanity check to ensure your token order is correct
        # print("reset ", i)
        tracker.reset()
        last_time_stamp = frames[i]['timestamp']

    time_lag = (frames[i]['timestamp'] - last_time_stamp)
    last_time_stamp = frames[i]['timestamp']

    preds = predictions[token]

    outputs = tracker.step_centertrack(preds, time_lag)
    annos = []

`
i found the variable size is 6019, but the variable prediction size is 6008.
I don't know where I was wrong what should i do? thank you!

this file is the test set's detection result. You need to set these two arguments for test set
https://github.com/tianweiy/CenterPoint/blob/c9822e1202ff1b197db237d284f546e8cb98d766/tools/nusc_tracking/pub_test.py#L29
otherwise, use the val set's predictions

Where should I download the val set's predictions from? Can you give me a link in detail? I dont know which one i shoulddownload.

this file is the test set's detection result. You need to set these two arguments for test set
https://github.com/tianweiy/CenterPoint/blob/c9822e1202ff1b197db237d284f546e8cb98d766/tools/nusc_tracking/pub_test.py#L29
https://github.com/tianweiy/CenterPoint/blob/c9822e1202ff1b197db237d284f546e8cb98d766/tools/nusc_tracking/pub_test.py#L30
otherwise, use the val set's predictions

Where should I download the val set's predictions from? Can you give me a link in detail? I dont know which one i shoulddownload.

https://drive.google.com/drive/folders/1fAz0Hn8hLdmwYZh_JuMQj69O7uEHAjOh
this should work.
BTW, all links are in this section https://github.com/tianweiy/CenterPoint/blob/master/configs/nusc/README.md#voxelnetdepreacted

https://drive.google.com/drive/folders/1fAz0Hn8hLdmwYZh_JuMQj69O7uEHAjOh
this should work.
BTW, all links are in this section https://github.com/tianweiy/CenterPoint/blob/master/configs/nusc/README.md#voxelnetdepreacted

I tried and it worked. Thank you for answering my question when you are very busy

sure, no problem


fix: use tempdir prefix

In rare cases, if a generate operation is forcefully cancelled/panics, the tempdir used for git cloning might not be cleared up.
The default .tmp prefix leaves the tempdir hidden and hard to know which program created it.
Having cargo-generate prefix adds clarity and visibility.
The same is true when running tests, for instance if you cancel the pre-push hook.

Done


s3 backend?

I'd love to roll this out, but having an s3 backend would be great for scaling. Any plans to add this in the future?

Actually I have a local testbuild which uses backblaze buckets for (backup) storage. Have no experience with s3 though


New VIPER framework for Swift 3

I'm helping to this repo and looks fine for adding it to this list.

@buguibu looks like a nice tool. Thanks for your PR 🚀


add dev-container config file

Add dev-container to the project. Now, whenever somebody wants to contribute to this project, they don't have to install all the dependencies in their pc. Instead one can use vscode dev-container to create a container in docker and develop in that container and install all the dependencies in that environment so that after completion you can delete all the dependencies.
refer this link for more info

Thanks for the contribution, however I've already been working on some devcontainer configs that include GPU support as well as setting up dependencies and defaults. I've created PR #104 for them, take a look and let me know if it works for you.

I am actually working on a project related to large language models and I have come across this dev containers while working on this project. It required a lot of python dependencies and several other sql packages. I think these dependencies should be dealt with by dockerfile so that the dockerfile can also be used to deploy the project. I see that you are trying to install torch library in json file. I don't think that is good idea. It is best to write a dockerfile that installs all the needed dependencies in the dev container and link the json file to the dockerfile like this

I also faced another problem which is rebuilding the whole container everytime there is a need to install more dependencies. Rebuilding the container everytime would waste a lot of time. This happens when vscode detects changes in the json file. Instead what you guys can do is write a makefile in the root directory(we can simplify the commands by this makefile) see the below image(make dev-install runs this command). refer this link

I have also noticed that you have added black formatter and pylance linter. I suggest you guys use flake8 as linter. I think adding them as githooks(pre-commit) would make the git commits more neat and error free. Instead of adding them as extensions vscode which would only highlight parts where there is an error. refer this link  . git hooks for black and flake8 are available in github.

I think these dependencies should be dealt with by dockerfile so that the dockerfile can also be used to deploy the project.

True, but

I also faced another problem which is rebuilding the whole container everytime there is a need to install more dependencies.

then you have this problem.

I see that you are trying to install torch library in json file.

So perhaps the better answer is to solve this with a custom devcontainer component (as one of the benefits of not using a dockerfile is the ability to use those components)

I have also noticed that you have added black formatter and pylance linter. I suggest you guys use flake8 as linter. I think adding them as githooks(pre-commit) would make the git commits more neat and error free. Instead of adding them as extensions vscode which would only highlight parts where there is an error. refer this link  . git hooks for black and flake8 are available in github.
I know that all these things kind of defeats the purpose of dev-container. But I would like to think that dev-containers are thin line between host os and dev os so that we know where everything related to the project is and what those are so that we can delete them later.

We use actions to reject PRs which I prefer to git hooks as it can prevent pushing code; and code should always be pushed so you don't lose it, even if it's not in a working state. But the setup of all this in the container could be improved.
Can we close this PR and move discussion to #104 ?

okay....


HTTP feed fetcher improvements

Send an Accept header asking for feed formats (instead of the current */*)
Don’t send A-IM without an If-None-Match or If-Modified-Since.
Fixed Train-Case in “Accept-Encoding” header.

LGTM. How did you figure out that these changes need to be made? Specific feeds?

How did you figure out that these changes need to be made? Specific feeds?

I’ve been going through caching and delta feed logic for a bunch of open source news readers. Feed subscriptions consume the most amount of bandwidth from my own website. Broken cache implementations seemed to be the root cause; and I went ahead and added delta feed support to a whole bunch of new feed readers. I’m not sure how much it will help, but it was worth a shot.

Thanks, I appreciate it. I've already deployed the changes, have you noticed an improvement?


Fix custom text

Order was incorrect, custom text should precede everything else, custom language text should precede built in strings.

Thank you. I will Upload your fix in a Week.
Am Freitag, 9. September 2016 schrieb Ben Croskery :

Order was incorrect, custom text should precede everything else, custom
language text should precede built in strings.
You can view, comment on, or merge this pull request online at:
https://github.com/browser-update/browser-update/pull/312
Commit Summary

Fix custom text

File Changes

M update.js
https://github.com/browser-update/browser-update/pull/312/files#diff-0
(6)

Patch Links:

https://github.com/browser-update/browser-update/pull/312.patch
https://github.com/browser-update/browser-update/pull/312.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/browser-update/browser-update/pull/312, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIErKhkLIQatO_ship5s7g9Ub1LG6HGgks5qoYAWgaJpZM4J5MLe
.

Will this be happening today?  Would love to roll this out on our website. Thanks for all your work!

This will happen on Monday or Tuesday.
Alistair Calder<EMAIL_ADDRESS>schrieb am Fr., 16. Sep. 2016 um
18:37:

Will this be happening today? Would love to roll this out on our website.
Thanks for all your work!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/browser-update/browser-update/pull/312#issuecomment-247647769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIErKt6LnHA9wE2bgTFt7ERq4zTYFIyQks5qqsWxgaJpZM4J5MLe
.

The fix is now online!

Thank you for the fix!


Make AccessToken be usable without making a request

Now to use the whole api we must obtain access token from the service. Then it must be saved somewhere (documentation suggests to serialize it to a file) but the access token can not be restored from anything but serde_json structure. Why is it so? Why can't we create AccessToken manually if we know all it's fields?

Thank you for your interest in vkrs.
I think there is no real reason, just because vkrs is in develop and a lot of stuff have not been done yet. Unfortunately, @kstep and I currently have a lack of free time. Let's hear from him.

Actually, I haven't thought about it ) I believe it is a nice thing to have. Unfortunately, @Vinatorul is right about the lack of time. I've got a lot of real-life problems now, so I don't have enough time and energy to take part in Rust community. But if you are willing to contribute, I'll be happy to review and accept any PRs.


fix: use device defaults for MAX_ACC_OUT_READ on PCIe Gen5

According to PRM, the value of MAX_ACC_OUT_READ should be set to 0 on PCIe Gen5 devices to enable the auto mode.
However, we have observed that on the ConnectX7 devices setting this value to 0 results in FW not being able to load.
Until further clarification is provided, let's use the device defaults.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 60.311%

Files with Coverage Reduction
New Missed Lines
%

internal/controller/nicdevice_controller.go
5
78.25%

internal/controller/nicconfigurationtemplate_controller.go
6
87.06%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.1%

Covered Lines:
1743

Relevant Lines:
2890

💛  - Coveralls


Routes uploader requests yml file

Issue Summary
In Safari 13.0.4 on macOS 10.15.2, the 'Upload routes YAML' button triggers a file browser that only allows selection of files ending in .yml. These are not accepted by the application, which requires a .yaml extension. This results in routes not being uploadable with Safari.
To Reproduce

In Safari, click the 'Upload routes YAML' button in Labs.

This doesn't happen in Firefox or Chrome. In Firefox, all files are selectable, in Chrome, yaml files are selectable.
Technical details:

Ghost Version: 3.2.0
Node Version: 10.18.0
Browser/OS: Safari 13.0.4
Database: MySQL

Can't confirm the bug as not a Mac user, but think the right place to dig for a possible fix would be somewhere here - https://github.com/TryGhost/Ghost-Admin/blob/3.2.0/app/controllers/settings/labs.js#L28.
@formerandroider can you please provide a screenshot to confirm the behavior?

FWIW only the yaml extension is supported in the core, not yml
https://github.com/TryGhost/Ghost/blob/72679aefb9d332c9f9f2c9f6ef4d8296d88bdce9/core/frontend/services/settings/loader.js#L15-L18
I think the inherent issue is how browsers handle mime types. It might be easier to just specify the extension (e.g. .yaml) rather than the mime types, if all supported browsers understand it. MDN Ref

Yup, you are right @vikaspotluri123! Found this confirming commit from you - https://github.com/TryGhost/Ghost-Admin/commit/a5bfd3616

@gargol note the unelectable yaml file, but the selectable yml file.

I downloaded a local copy and modified it such that the accept field on the actual file input consisted of the file extension rather than the MIME types, and that allowed me to select the correct file (though the changes I made weren't the best in terms of code quality).

@formerandroider can you please provide a screenshot to confirm the behavior?

I can confirm as well. Just went through the same issue today and was wondering what was up. Running on Ghost version 3.3.0. Same browser version.

Have checked the reason behind why there's only support for .yaml extension on the server-side. It's intentionally limited to one to be in line with the official recommendation - https://yaml.org/faq.html. The preference is to stick to the official extension name and not modify for quirky naming.
If this becomes a blocking or very ubiquitous problem we can review and reopen the issue.
The possible approach, if it has to be implemented, could be allowing for both extensions .yaml and .yml but renaming and saving uploaded file on the server-side using single standardized .yaml extension.

@gargol I think you’re somewhat missing the point. It’s not possible to choose .yaml flies when using Safari, only .yml files are enabled by the file picker, which are then blocked server side.

Oh! Sorry, completely had this backward then :sweat_smile:  In that case it's strictly a frontend problem and any PR to fix this in Safari is welcome :v:

For the sake of ... workaround for this:

rename it to routes.yml and try to upload
you will get error
rename to  routes.yaml and it will let you upload it

It worked for me so may save you some time.


bevy_render 0.11.3 using old code? Compute Shader example won't compile

Bevy version
bevy 0.11.3
bevy_render 0.11.3
What you did
copied example code for compute_shader_game_of_life.rs into new project along with shader code in assets/shaders folder
What went wrong
Build fails with:
error[E0599]: no variant or associated item named PrepareBindGroups found for enum RenderSet in the current scope
src\main.rs:79:50
prepare_bind_group.in_set(RenderSet::PrepareBindGroups)
Additional information
Using "Go to definition" in VSCode shows the enum that is, I believe, the version of lib.rs from 2 months ago (July 4th commit):
https://github.com/bevyengine/bevy/blob/608367f9059c4391cade8dfbc811a8e02255ae25/crates/bevy_render/src/lib.rs
Not the more recent ones with PrepareBindGroups added around the end of August.

Where was the compute_shader_game_of_life example copied from?
Here's a link to the version that works with the latest release of Bevy: https://github.com/bevyengine/bevy/blob/latest/examples/shader/compute_shader_game_of_life.rs
The main branch likely has breaking changes, but examples are always kept in a working state.

Ah, thank you! That explains it. That version does compiles fine.
So, basically, I need to go to the examples via the link on the main readme.md to have them work with the cargo releases.


Arabic langs migrate from 1.2.x to 1.3.x

Hi @hideki,
we want to migrate our app from 1.2.x to 1.3.x couchDB, but now we found a big issue.
relevant issue: https://github.com/couchbase/couchbase-lite-android/issues/880
1.2.x didn't support Aracic langs (due to error in replication which we report).
It's fixed now, but with this error was related next one with:
Caused by: com.couchbase.lite.internal.database.sqlite.exception.SQLiteException: no such table: maps_١ (code 1): maps_X is arabic character.
But what happen now:

User use Arabic/Persian language in phone
User used old couchDB 1.2.x in app
Couch db create a table with name maps_١ which works (because he don't switch to non-arabic lang)
no user data was synced due to error with: bedarg: ١-524d55825877d7e4b46f01ed56fe98c9 (first character is persian, not EN one 1 character) - it's fixed in 1.3.x
now we upgrade to 1.3.x which fix maps_١, but it require table: maps_1, but for arabic language there is no table maps_1! It's maps_١. And app crash on it.

We have no solution now, how to fix this, because user hasn't backed up data on main couchDB due to replication error in 1.2.x
Solution should be I think:
Look that exists: maps_١, if exists rename it on: maps_1 and not crash.
Process: com.droid4you.application.wallet, PID: 16040
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.droid4you.application.wallet/com.droid4you.application.wallet.activity.MainActivity}: com.couchbase.lite.internal.database.sqlite.exception.SQLiteException: no such table: maps_1 (code 1): , while compiling: SELECT key, value, docid, revs.sequence FROM 'maps_1', revs, docs WHERE 1 AND revs.sequence = 'maps_1'.sequence AND docs.doc_id = revs.doc_id ORDER BY key, docid LIMIT ? OFFSET ?
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2491)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2564)
    at android.app.ActivityThread.access$800(ActivityThread.java:170)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1441)
    at android.os.Handler.dispatchMessage(Handler.java:111)
    at android.os.Looper.loop(Looper.java:194)
    at android.app.ActivityThread.main(ActivityThread.java:5576)
    at java.lang.reflect.Method.invoke(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:372)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:955)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:750)
 Caused by: com.couchbase.lite.internal.database.sqlite.exception.SQLiteException: no such table: maps_1 (code 1): , while compiling: SELECT key, value, docid, revs.sequence FROM 'maps_1', revs, docs WHERE 1 AND revs.sequence = 'maps_1'.sequence AND docs.doc_id = revs.doc_id ORDER BY key, docid LIMIT ? OFFSET ?
    at com.couchbase.lite.internal.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method)
    at com.couchbase.lite.internal.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:718)
    at com.couchbase.lite.internal.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:431)
    at com.couchbase.lite.internal.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:595)
    at com.couchbase.lite.internal.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:64)
    at com.couchbase.lite.internal.database.sqlite.SQLiteQuery.<init>(SQLiteQuery.java:37)
    at com.couchbase.lite.internal.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:48)
    at com.couchbase.lite.internal.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1300)
    at com.couchbase.lite.internal.database.sqlite.SQLiteDatabase.rawQuery(SQLiteDatabase.java:1239)
    at com.couchbase.lite.storage.SQLiteStorageEngineBase.rawQuery(SQLiteStorageEngineBase.java:183)
    at com.couchbase.lite.store.SQLiteViewStore.runQuery(SQLiteViewStore.java:1010)
    at com.couchbase.lite.store.SQLiteViewStore.regularQuery(SQLiteViewStore.java:623)
    at com.couchbase.lite.View.query(View.java:358)
    at com.couchbase.lite.Database.queryViewNamed(Database.java:2194)
    at com.couchbase.lite.Query.run(Query.java:446)

Note to self: 792

Test scenario:

set phone to Arabic/Persian lang
use coucDB 1.2.x
create couchDB object (internally create maps_١)
upgrade in project couchDB to 1.3.x
app crash on: no such table: maps_1

@hideki have we fixed this in 1.3.0?

We fixed this issue in 1.3.0.
@mtrakal
Could you please confirm if this issue is already addressed?

Hi,  @hideki, @pasin
No, migration from 1.2.x to 1.3.x is not working.
When you start from 1.3.x from begining it's ok,  but not when you migrate from old database.
See please scenario in my second comment. It's different scenario from scenario described in #880

Moře detailed :

switch lang in phone to arabic
first time run app (or delete app data), no created  database
start app with couch 1.2.x
continue by scenario in my original second comment

It's caused by view which we created, and solution is, set new version of this view. But without change the version it still crash.
View view = getDatabase().getView(NON_RECORD_ITEMS_VIEW_NAME);
        view.setMap(new Mapper() {
            @Override
            public void map(Map<String, Object> document, Emitter emitter) {
               ...
                }
            }
        }, "1");
        return view.createQuery();

When upgrade to 1.3.x just upgrade version of view fix this issue. From "1" to "2"

Next issue after upgrade is, that original objects have first revision stored in local couch which looks like:  ١-524d55825877d7e4b46f01ed56fe98c9 (start with ١ arabic representation of 1).
This object is never synced to backend couchDB (due to character in revision). But this objects are not synced neither after upgrade. Because a arabic/persian character is still in revision (or previous revision when you update object).
This could have solution like:

check current revision,
if current revision contains non-english character
update object revision
purge old revisions.

Hi @mtrakal,
Sorry for slow reply.
As workaround, can your app delete index when app migrates? Then the app could re-index data.
Thanks!
Hideki

Hi @hideki ,
for first issue we just increase version of view to 2. It works.
For the second issue I created this method for migration, it's not much optimized, but looks as working for us.
It could throw OOM when there will be much documents, and maybe another issues, but we need to fix it asap for Arabic/Persian.
After migration we set setMaxRevTreeDepth to default 20.
    public void fixArabicObjects(final PersistentConfig persistentConfig, final OttoBus ottoBus) {
        new AsyncTask<Void, Void, Void>() {
            @Override
            protected Void doInBackground(Void... params) {
                Query allDocumentsQuery = getDatabase().createAllDocumentsQuery();
                allDocumentsQuery.setAllDocsMode(Query.AllDocsMode.ALL_DOCS);
                try {
                    QueryEnumerator rows = allDocumentsQuery.run();
                    int count = rows.getCount();
                    if (count > 0) {
                        int current = 0;
                        final ArrayList<UnsavedRevision> unsavedRevisions = new ArrayList<>();
                        while (rows.hasNext()) {
                            QueryRow queryRow = rows.next();
                            Document document = queryRow.getDocument();
                            String revisionNumber = document.getCurrentRevisionId().split("-")[0];
                            boolean convert;
                            try {
                                // check that number us in english format and not arabic
                                long originalNumber = Long.parseLong(revisionNumber);
                                String englishNumber = String.valueOf(originalNumber);
                                convert = !englishNumber.equals(revisionNumber);
                            } catch (NumberFormatException eN) {
                                eN.printStackTrace();
                                convert = true;
                            }

                            if (convert) {
                                UnsavedRevision newRevision = document.createRevision();
                                unsavedRevisions.add(newRevision);
                            }
                            current++;
                        }
                        getDatabase().runInTransaction(new TransactionalTask() {
                            @Override
                            public boolean run() {
                                for (UnsavedRevision unsavedRevision : unsavedRevisions) {
                                    try {
                                        unsavedRevision.save();
                                    } catch (CouchbaseLiteException e) {
                                        e.printStackTrace();
                                    }
                                }
                                return true;
                            }
                        });
                        try {
                            Database database = getDatabase();
                            // maybe use purge revisions
                            database.setMaxRevTreeDepth(1);
                            database.compact();
                            persistentConfig.setCouchDb12x13xMigrationComplete();
                        } catch (CouchbaseLiteException e) {
                            e.printStackTrace();
                        }
                    } else {
                        persistentConfig.setCouchDb12x13xMigrationComplete();
                    }
                } catch (CouchbaseLiteException e) {
                    e.printStackTrace();
                }
                return null;
            }
        }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
    }

Hi @mtrakal,
Thank you for sharing your workaround solution.
As you have a workaround solution for this, we will not fix this.


update splash page screenshot

Cute animal pic
Because everyone likes pictures of animals.

Link to Trello card (if applicable)
If this PR relates to a Trello card, don't forget to reference this PR on the card as well.
https://trello.com/c/BGQuFDrG/138-chore-update-splash-page-screenshots
Description
The commit messages say what you did; this should explain why and how.

[x] Description is in Trello card

Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally.
log out to see login screen
Impacted areas of website
Provide URLs and/or a description of where to look.
homepage
Show me
Provide screenshots/animated gifs/videos if necessary.

Reviewer tasks:

[ ] Pulled branch and ran code locally (or viewed on preview deployment, if applicable)
[ ] Reproduced the issue to review in the browser
[ ] Reviewed code
[ ] Updated Trello card (if applicable)

 Chore: Update splash page screenshots

@mirisuzanne @SondraE We merged this yesterday as an improvement regardless, but I'm happy for your post-merge feedback or suggestions.

looks great


devtools dependency fail in the new build of container.

In the new build of methylation_both container, the devtools was failed to be installed. Therefore a new implementation to use biocManager to install packages from GITHUB was used.

why devtools fails to install? You can also use remotes::install_github()

why devtools fails to install? You can also use remotes::install_github()

It has to do with some dependency issues up to the package system_font. But since I used BiocManager to install most of the packages, including the sesame from GitHub, in this container, I think my current way should simplify things

New implementation works


Installation error: configure: error: /bin/sh ./config.sub unknown-Darwin failed

Hi,
I am trying to install scsnv in MacOS Ventura and am encountering the following issue when I do 'make' in build directory:
`configure: error: /bin/sh ./config.sub unknown-Darwin failed
make[2]: *** [/scsnv/external/htslib/libhts.a] Error 1
make[1]: *** [src/CMakeFiles/libhts.dir/all] Error 2
make: *** [all] Error 2
`
Can you please let me know what might be the problem here? I have tried looking this issue up but to no avail. Any help is highly appreciated.
Thank you.
Best regards,
Nash

Hi.  I am not sure why it isn't compiling.   I don't use MacOS anymore.  But have you installed the xcode command line tools?   Could you try cd external/htslib and type autoreconf -i && ./configure --without-libdeflate and tell me what the output is?
Thanks


MacOS - Cilsil/System.Private.CoreLib.dll: No such file or directory

# ./run_infersharp.sh MyProject/LearningSomething.Web/bin/Debug/net5.0/LearningSomething.Web.dll
Processing {MyProject/LearningSomething.Web/bin/Debug/net5.0/LearningSomething.Web.dll}
Copying binaries to a staging folder...\n
cp: Cilsil/System.Private.CoreLib.dll: No such file or directory
Code translation started...
./run_infersharp.sh: line 60: ./Cilsil/Cilsil: No such file or directory
Code translation completed. Analyzing...

./run_infersharp.sh: line 62: /Users/me/workspace/learning/b1/infer/lib/infer/infer/bin/infer: No such file or directory
mkdir: infer-out: No such file or directory
./run_infersharp.sh: line 64: /Users/me/workspace/learning/b1/infer/lib/infer/infer/bin/infer: No such file or directory

Running from a bash shell in MacOS, looks like some paths are incorrect.
Are infersharp and run_infersharp.sh compatible with MacOS?

Hi Devis, we have not tested Infer# on MacOS. We will look into this.
Thanks for bringing this to our attention.

Hi Devis, we tested the script on a Mac and it was able to work with the paths correctly with the latest v1.2 release. However, we currently do not have support for MacOS.
I will rename the issue and tag it as a feature request.


async_create_task is not supported after python3.8

E [2022-06-19 02:52:24,037] Task exception was never retrieved
future: <Task finished name='Task-4' coro=<CryptoXLibClient.start_websockets() done, defined at /home/ubuntu/.local/lib/python3.10/site-packages/cryptoxlib/CryptoXLibClient.py:219> exception=Exception('Unsupported Python version! Only versions 3.6.x, 3.7.x and 3.8.x are supported.')>
Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cryptoxlib/CryptoXLibClient.py", line 227, in start_websockets
    tasks.append(async_create_task(
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cryptoxlib/version_conversions.py", line 40, in async_create_task
    raise Exception(f'Unsupported Python version! Only versions 3.6.x, 3.7.x and 3.8.x are supported.')
Exception: Unsupported Python version! Only versions 3.6.x, 3.7.x and 3.8.x are supported.
/usr/lib/python3.10/asyncio/base_events.py:1897: RuntimeWarning: coroutine 'WebsocketMgr.run' was never awaited
  handle = None  # Needed to break cycles when an exception occurs.
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Hi @xiandong79, I assume you are running with python 3.10. I have tested the library only up to python 3.9 (the error message has a mistake and should read 3.9.x) and that's why officially supported it only up to that version. I will run a few more tests for 3.10 and will add into the list of supported versions. If you spotted some other problems, please let me know.

@xiandong79 I pushed changes on branch p310. When we resolve the issue with aiohttp from the other thread, I will officially deliver it.

Delivered in 5.3.0.


Fix landmarks

Partially addresses #1428.
This PR fixes some Axe errors related to landmarks (duplicate main landmark, indistinct landmarks, and some content not contained within a landmark).
After
Here's how the browser "sees" the landmarks after this PR:

(the above screenshot was taken with the "landmarks" ad hoc tool in the Accessibility Insights browser extension)
Here's how the landmarks are shown in the VoiceOver rotor (Caps Lock + U):

Before
Here's how the browser sees landmarks before this PR

Landmarks in VoiceOver rotor:

cc @trallard

seeems like this is waiting on #1425, I'll mark as draft until that one is in

I think I'm going to need some help with the translation system. I changed the string "Section Navigation" to "In this section" but I'm not exactly sure what I need to do to get the translation files in order.

thanks @gabalafou!


Auto export of Luxor functions

Implements #70 -- let me know if there is anything else you want to tweak from this!

You should remove using Luxor from the test cases.


Configurable number of rows for gallery preview

Describe your suggested feature
Currently there are 4 rows for gallery preview in manga description screen, which is too many. As discussed on discord, request to make the row number configurable (like 1 or 3)
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.8.4.
[X] I will fill out all of the requested information in this form.

@jobobby04 is it possible to disable the gallery image preview for next stable release, until the row count is configurable?

Nope

Any update on this?


Configuration of laserscan topic #247

This pull request adds an option to configure the laserscan topic by launchfile and will be included in the next release.
The PR is created to increase the visibility of branch https://github.com/SICKAG/sick_scan_xd/tree/feature/laserscan_topic, see comment https://github.com/SICKAG/sick_scan_xd/issues/247#issuecomment-1911567061.

obviously now part of the master branch - see https://github.com/SICKAG/sick_scan_xd/commit/abd456030afbdbdc397e17450a99f935014923d2
I still find the workflow within this repo quite confusing...why do you not comment and close these PRs/Issues and feature branches then - once you pulled the changes into the master branch?

Hello,
thank you for your feedback. We will discuss this internally and try to come up with a good solution.
Best regards,
Manuel

Hello,
we added a develop-branch as the default branch to the repository. Please use this branch in the future for pull requests. We will try to review and merge these quickly into the develop branch.
Best regards,
Manuel


Critical: bloatware removal broken

Line 30, the *s around .NET are not necessary and break the removal portion of the script.
With the -NoMatch operator on the following lines (31-33), it is already matching parts of strings in the $WhitelistedApps string. The *s are NOT wildcards in the context of PowerShell -Match or -NoMatch regex.
If you wanted to, you cold change the -Match to a -Like, which uses simplified Powershell regex language, where the *s are wildcards, and where partial string matching is not already implied.
Otherwise, just remove the *s around .NET and that should fix the script.
 [regex]$WhitelistedApps = 'Microsoft.ScreenSketch|Microsoft.Paint3D|Microsoft.WindowsCalculator|Microsoft.WindowsStore|Microsoft.Windows.Photos|CanonicalGroupLimited.UbuntuonWindows|Microsoft.XboxGameCallableUI|Microsoft.XboxGamingOverlay|Microsoft.Xbox.TCUI|Microsoft.XboxGamingOverlay|Microsoft.XboxIdentityProvider|Microsoft.MicrosoftStickyNotes|Microsoft.MSPaint|Microsoft.WindowsCamera|*.NET*'
PS> $testvar = 'there is an error'
PS> $testvar -match 'error'
True

This is now resolved. Thank you!


workingDiff inconsistency

see https://github.com/lennym/moment-business-time/issues/12
var SeriousBusinessTime = require('serious-business-time');
var moment = require('moment');

var workinghours = {
    0: null,
    1: ['09:00:00', '17:00:00'],
    2: ['09:00:00', '17:00:00'],
    3: ['09:00:00', '17:00:00'],
    4: ['09:00:00', '17:00:00'],
    5: ['09:00:00', '17:00:00'],
    6: null
}
var businessTime = SeriousBusinessTime.createInstance(moment, workinghours);

var date = moment('2016-03-18 15:00')

businessTime.workingDiff(date, moment('2016-03-18 10:30'), 'hour')       // 4 ok
businessTime.workingDiff(date, moment('2016-03-18 10:30'), 'hour', true) // 4.5 ok
businessTime.workingDiff(date, moment('2016-03-18 14:15'), 'hour')       // 0 ok
businessTime.workingDiff(date, moment('2016-03-18 14:15'), 'hour', true) // 0.75 ok

// `* -1` here only until https://github.com/Bizzby/node-serious-business-time/issues/5 will be fixed
businessTime.workingDiff(date, moment('2016-03-18 10:30'), 'day') * -1 // 1 expected to be 0
businessTime.workingDiff(date, moment('2016-03-18 10:30'), 'day', true) * -1 // 1 expected to be 4.5 / 8 = 0.5625
businessTime.workingDiff(date, moment('2016-03-17 10:30'), 'day') * -1 // 2 expected to be 1
businessTime.workingDiff(date, moment('2016-03-17 10:30'), 'day', true) * -1// 2 expected to be 1 + (4.5 / 8) = 1.5625

see also https://github.com/lennym/moment-business-time/issues/12#issuecomment-199838810


Added translations

Added translation system
Added german translation

Coverage increased (+0.03%) to 93.233% when pulling 7daf9138f8634840244fedb9e8fe05ff00e95c06 on feature/translation into 8ba86ce0ed997314b3ac45b057b15ded1c265067 on master.

@czpython
> ?: (1_8.W001) The standalone TEMPLATE_* settings were deprecated in Django 1.8 and the TEMPLATES dictionary takes precedence. You must put the values of the following settings into your default TEMPLATES dict: TEMPLATE_DIRS, ALLOWED_INCLUDE_ROOTS, TEMPLATE_CONTEXT_PROCESSORS, TEMPLATE_LOADERS.
> No changes detected in app 'aldryn_apphooks_config'

Coverage increased (+0.03%) to 93.233% when pulling 93a449ae6e6cd8510cbcc0abeb9f57c553c75ae5 on feature/translation into 8ba86ce0ed997314b3ac45b057b15ded1c265067 on master.

@FinalAngel hmm the models.py change was only a style change.. nvm migrations although not sure about the test migrations.


Fix Path in index.html after move to /dist

If the <script>  tag inindex.html has the  src path"dist/bundle.js"
then when previewing index.html in the browser the follwing error is produced after the build: ... /dist/dist/bundle.js net::ERR_FILE_NOT_FOUND
Changing the src path to "./bundle.js"  in the <script> tag resolves the error and produces the desired result after the build.

@montogeek we should close this one, right?

Thanks!


Never uses #REQUIRED in <!ATTLIST>

#IMPLIED != #REQUIRED

Expected :#REQUIRED
Actual   :#IMPLIED


Unable to use Continue on Windows with a dev container

Slack thread
The extension is not working. It says the "The window is not responding". This is on Windows with a dev container

Continue is now packaging the Python server as an executable, which is likely to solve a number of issues on Windows, including this one.


Angular-backed interface

Tiny Angular application that parses the original README.md file and translates it into a searchable master list/detail structure.

Initial pull. Lots to fix, but functional.
Sample here:
https://rawgit.com/lbotinelly/remote-jobs/master/index.html

This is awesome!! :+1:

Functional global search:

This is super cool, thanks @lbotinelly!

Thank you, @alephmelo and @dougaitken!

Wow, this is cool! Were you thinking this would work well for a github pages site?

@jessicard ty! That's a possibility, since there's no backend processing whatsoever. Do you have anything in mind you'd like to see?

I kept thinking about this when you first posted the issue @jessicard
If you want to fling something on a gh-pages branch Lee then we can play
with it from there, sound like a plan Jessica?
On Tuesday, 8 December 2015, Leo Botinelly<EMAIL_ADDRESS>wrote:

@jessicard https://github.com/jessicard ty! That's a possibility, since
there's no backend processing whatsoever. Do you have anything in mind
you'd like to see?
—
Reply to this email directly or view it on GitHub
https://github.com/jessicard/remote-jobs/pull/169#issuecomment-162992740
.

@lbotinelly Do you want to create a gh-pages branch and we can look into this from there, separate from the main repo. It'll also allow us to use that if we choose to go in the web-app direction for visitors to use the data :+1:

Sounds good! I'll give it a try this weekend (or earlier if possible).
On Thu, Jan 14, 2016 at 10:35 AM, Doug Aitken<EMAIL_ADDRESS>wrote:

@lbotinelly https://github.com/lbotinelly Do you want to create a
gh-pages branch and we can look into this from there, separate from the
main repo. It'll also allow us to use that if we choose to go in the
web-app direction for visitors to use the data [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/jessicard/remote-jobs/pull/169#issuecomment-171675581
.

No worries @lbotinelly. One thing I think would be good is when you click on a company further down the list, the readme still parses at the top of the page, it doesn't "float" down to where you have clicked. Just an idea :+1:

Hey @lbotinelly, are you still interested in doing something like this? I was thinking we could start a pages branch and go from there?

closing in favour of discussion in #44 if and when I decided to take that somewhere.


Rename package to match directory

I'm going to close this after #96.  The data library doesn't behave well but I'll probably obsolete that "real soon now"


[OSPP] The codes of Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs

The PR of the proposal is in PR
This PR is merged in the branch named feature-lifelong-n.
This PR is about the codes of Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Ianvs.
This PR is a modification of the last PR

The code is overall fine but the conflict need to be resolved by fetching the latest version

/lgtm

lgtm

/approve


Expose stats to template

This PR

feat(roc-package-web-app-react): Expose new stats object to template values

Makes it possible to get all the chunks (css, scripts) in the template.

fix(roc-package-webpack-node-dev): Use new stats object format

This also solves a problem where we wouldn't find the bundle based on the build.name
being different than the default "app".

feat(roc-package-webpack-dev): Export stats as object with all chunks

Paired with @dlmr  on this one! 🎉

Looks good!

Force-pushed the amended commit with feedback addressed.


Fix some lint warnings

Use singlequote instead of doublequoe on Sample.android.js
Remove invariant of Sample.ios.js that is not used

Looks reasonable to me

@facebook-github-bot import

@facebook-github-bot shipit

Woops, something went wrong with the bot