Mark distribution as multi-release

As explained in https://github.com/apache/pinot/pull/12131, we need to distribute Pinot as a multi-release Jar. The reason is that we distribute Pinot as a uber-jar with all dependencies in the same jar and some of our dependencies are multi-release jars.
Not marking the jar as multi-release was incorrect in the past, but it seems to be not problematic until recently, when we updated some libraries that fail if the sources for Java 11/17/21 were not used in these runtimes.
I thought I already marked the jar as multi release, but https://github.com/apache/pinot/pull/12289 proved otherwise. When I actually fix the issue, I've found that our code was failing when multi-release was enabled. The reason is that specifically in Java 11 (AFAIK not in Java 21), when multi-release is enabled,

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5cc7231) 61.55% compared to head (3c43eca) 46.41%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12300       +/-   ##
=============================================
- Coverage     61.55%   46.41%   -15.15%
+ Complexity     1153      944      -209
=============================================
  Files          2415     1808      -607
  Lines        131508    95314    -36194
  Branches      20310    15397     -4913
=============================================
- Hits          80956    44240    -36716
- Misses        44626    47910     +3284
+ Partials       5926     3164     -2762

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
46.41% <ø> (-15.01%)
:arrow_down:

skip-bytebuffers-false
46.41% <ø> (-15.14%)
:arrow_down:

skip-bytebuffers-true
?

temurin
46.41% <ø> (-15.15%)
:arrow_down:

unittests
46.41% <ø> (-15.15%)
:arrow_down:

unittests1
46.41% <ø> (-0.21%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Split up CHESTS permission

See https://github.com/DevotedMC/NameLayer/issues/42

Closing as this is fundamentally at issue with how inventory management works in Minecraft, see https://github.com/CivClassic/Citadel/pull/52#event-4158737950


M3-865 Isolate Mock Data

Purpose
Abstract away all mock data that exists inside individual tests inside their own contained files. Hopefully this will encourage more unit tests
New Mock Data

App Tokens
PAT Tokens
NodeBalancers
ExtendedNodeBalancers
Disks

Coverage increased (+0.05%) to 26.531% when pulling 6d5dbdd2b2a8ea5744c63e78775af272c45fe254 on martinmckenna:M3-865-isolate-mock-data into e0ef92b7855220e5a99df5e8f762868a9c485abb on linode:develop.


Re-add some APIs to MTRBaseDevice, but deprecate them.

Some of the 1.0-targeted API changes did not happen soon enough.

Not happening in this form, after the API revert.


Add drag & drop file

Pls add a feature to drag & drop file to chatbox.

you mean drag a file like pdf or ppt and use it as context?


Update uniffi version to 0.24.1

Also adds a set of tools to help keep the same version everywhere.
Also rename the ffi crate back to its previous non-standard name to avoid some issues with the Gradle plugin, see https://github.com/matrix-org/matrix-rich-text-editor/blob/main/platforms/android/README.md

Codecov Report
Patch coverage has no change and project coverage change: -0.25 :warning:

Comparison is base (3b15882) 90.20% compared to head (e67a988) 89.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   90.20%   89.95%   -0.25%
==========================================
  Files         111       82      -29
  Lines       16115    14674    -1441
  Branches      565        0     -565
==========================================
- Hits        14536    13200    -1336
+ Misses       1558     1474      -84
+ Partials       21        0      -21

Flag
Coverage Δ

uitests
?

uitests-ios
?

unittests
89.95% <0.00%> (+0.83%)
:arrow_up:

unittests-ios
?

unittests-rust
89.95% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

uniffi-bindgen/src/main.rs
0.00% <0.00%> (ø)

... and 30 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Unhandled Rejection (TypeError): Cannot read properties of undefined (reading 'indexOf')

Can someone explain why I am getting this below error?
i did modify the minting part as:
if (index > -1)
{
   setIsMinting(true)
}
else
{
   throw Error;
}

get an answer yet?  I'm dying with this.

any luck?


Another attempt at pipeline build job fixes

Signed-off-by: jonahjon<EMAIL_ADDRESS>Description of changes:
Attempt at fixing build pipelines.

/lgtm


[log4cplus] Update to 2.0.7

Describe the pull request

What does your PR fix?
Updates log4cplus to 2.0.7

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes

Does your PR follow the maintainer guide?

Yes

Thanks for the version update!


[BUG] HasUniqueRoleAssignments property is null when using Get-PnPListItem

Notice
Many bugs reported are actually related to the PnP Framework which is used behind the scenes. Consider carefully where to report an issue:

Are you using Invoke-PnPSiteTemplate or Get-PnPSiteTemplate? The issue is most likely related to the Provisioning Engine. The Provisioning engine is not located in the PowerShell repo. Please report the issue here: https://github.com/pnp/pnpframework/issues.
Is the issue related to the cmdlet itself, its parameters, the syntax, or do you suspect it is the code of the cmdlet that is causing the issue? Then please continue reporting the issue in this repo.
If you think that the functionality might be related to the underlying libraries that the cmdlet is calling (We realize that might be difficult to determine), please first double check the code of the cmdlet, which can be found here: https://github.com/pnp/powershell/tree/master/src/Commands. If related to the cmdlet, continue reporting the issue here, otherwise report the issue at https://github.com/pnp/pnpframework/issues

Reporting an Issue or Missing Feature
Set $ListName to a document library name
Get-PnPListItem -List $ListName fetches all items in the list, but the items' HasUniqueRoleAssignments property is null.
Expected behavior
The value returned for HasUniqueRoleAssignments should be True or False.
I confirmed that SharePoint Online does have the value stored by using this cmdlet:
Get-PnPProperty -ClientObject $ListItems[0] -Property 'HasUniqueRoleAssignments'
Actual behavior
$ListItems = Get-PnPListItem -List $ListName
$ListItems[0] | FL
Note that the value for HasUniqueRoleAssignments is null / blank
Steps to reproduce behavior
See Actual behavior
What is the version of the Cmdlet module you are running?
PnP.PowerShell 2.2.0
Which operating system/environment are you running PnP PowerShell on?

[X] Windows

hi @v-khong , this is by design and not a bug.
It will only retrieve the property when requested.


Custom task - Finetune with different data ?

I collected part of my .wav files for training in a single directory since it is done in librispeech example.  (Is it necessary ?)
But then, I do not know to adjust transcriptions so it gives the error below not surprisingly.
Traceback (most recent call last):
File "preprocess/generate_len_for_bucket.py", line 122, in
main()
File "preprocess/generate_len_for_bucket.py", line 112, in main
for idx, s in enumerate(SETS):
UnboundLocalError: local variable 'SETS' referenced before assignment
What are changes which should be done for finetuning or training for any task on different data set?
Thanks in advance

Hi,
I think you need to check out these lines.
Simply make the SETS list accommodate your custom data directory.
Andy

Hi,
I changed that script and also dataset.py files. I could use my own data in csv format with their paths and transcriptions for asr task.
But I want to use this great toolkit for other tasks like zerospeech 2021 . What possible steps for a task like this ?

Hi,
I changed that script and also dataset.py files. I could use my own data in csv format with their paths and transcriptions for asr task.
But I want to use this great toolkit for other tasks like zerospeech 2021 . What possible steps for a task like this ?
@andi611

Hi, do you plan on using the zerospeech 2021 data for pre-train? Or do you simply want to adopt the pre-trained models to the zerospeech 2021 task?
For the first case, I think you can do the same to the zerospeech 2021 data, and pre-train your own model like u already did.
For the second case, we do have a simple solution, please see this page here.
If I'm missing your point, please do kindly provide more information ;)
Thanks,
Andy.


Fix incorrect docs for Cider nREPL handler.

Context
The FAQ contains an incorrect Cider nREPL handler. All other instances reference the correct var.
Related issues:
Contributor Checklist

[ ] Review Contributing Guidelines.

[ ] Commits contain discrete changes, messages include context about why the change was made and reference the relevant issues.

[ ] Provide functional tests. (under modules/gradle-clojure-plugin/src/compatTest)

[ ] Update documentation for user-facing changes. (under docs/)

[ ] Ensure all verification tasks pass locally. (./gradlew check)

[ ] Ensure CI builds pass on all Java versions. (watch for commit statuses once the PR is opened)
TIP: If troubleshooting a CI failure, look for the build scan URL near the bottom of the Gradle output.

Thanks for catching this!


What is the proper way to check if a PDF is password protected?

Previously, I used this piece of code to open a document and ask a password if the PDF appears to be password protected:
func openDocument() {
  do {
    document = try PDFDocument(filePath: pdfFilePath, password: password)
  } catch let err {
    switch err as? CGPDFDocumentError {
    case .some(.passwordRequired):
      askPassword(firstTime: true)
    case .some(.couldNotUnlock):
      askPassword(firstTime: false)
    default:
      break
    }
    return
  }

  DispatchQueue.main.async {
    self.document?.currentPage = self.page
    self.openViewer()
  }
}

However, this doesn't work anymore as the exception thrown in CGPDFDocument.swift isn't forwarded. Right now I have implemented this workaround just below the catch above, but if feels dirty:
  if document?.documentRef == nil {
    askPassword(firstTime: true)
    return
  }

What would be the proper way to check if a PDF is password-protected?
Thanks,
Rutger

You would be correct to assume the error should be propagating through. It looks like when we added in the ability to open a PDF from Data instead of just a file path this functionality broke. We moved all of the logic to a computed property so that calling it each time would pull from the latest variables that had been set. However, computed properties do not allow for throwing errors, so that is where the holdup is. A solution will be to move that logic to a function. However we will then have to either make the password, filePath and fileData variables read-only or will have to have the documentRef recompute when they are changed. Due to my schedule this change will be a couple of days, for the time being checking for nil is the best option, unfortunately that won't tell you if it was any of the other errors however. Sorry for the inconvenience!

Hi @pushchris, thanks for responding! I'll use the nil-check for now, and update as soon as an update is available.

#8

@rbresjer sorry for the delay, I have pushed code that moves opening of a PDF context to its own method. Would you mind pulling from the master branch and letting me know if it resolves the issue for you? If so I'll go ahead and publish a new version. Thanks

@pushchris Hi Chris, thanks, I just tested and it works!


Hard to scroll filter contents on touch because it opens keyboard

A general issue with typeable multiselects...

This seems to be a react-select issue, callously disregarded by the project for a while: https://github.com/JedWatson/react-select/issues/3526
The only suggesting is turning off isSearchable.

Fixed with pull request 51 / my searchable branch.


Incompatibility with Meteor 3.0.0-rc.4

Failing on rc.4, hoping you guys can modernize it.
Thank you!

published v4 with meteor v3 support


error: couldn't create a temp dir: Permission denied (os error 13) at path "/tmp/rustc0EYM3K"

This started happening suddenly. I don't remember any changes with my docker setup, Rust setup, Cargo setup, or anything else.
Compiling my project suddenly fails with a permission error:
   Compiling bots v0.5.0 (/project/bots)
     Running `rustc --crate-name full-command-redacted`
error: couldn't create a temp dir: Permission denied (os error 13) at path "/tmp/rustc0EYM3K"

cross version:
└─[$] <git:(rivertam/quick-renames*)> cross --version
cross 0.2.1
cargo 1.45.0 (744bd1fbb 2020-06-15)

This is unlikely to be related to cross: did you previously run Docker as root and then as a normal user? Check the permissions of "/tmp/rustc0EYM3K" using ls -la "/tmp/rustc0EYM3K".

That's unusual, since creating temporary directories should be fine for a normal user. Can you post the output with --verbose when running, if possible, and if you're using rootless Docker or the container engine? It's quite possible --user 1000:1000 might cause it so you can no longer write to the mounted filesystem (due to a lack of permissions) if using rootless docker.

Yeah, I bet it was a problem with Docker. Maybe something with BuildKit. Don't bother -- thanks for the response.


State Params Question

Hi.
I really like how you're passing component references and state settings with the state.params class in the states for your battleroyal example. I'm a little confused by how you're not getting a null reference when you initialize the state machine. I don't see you instantiate the params classes anywhere? Sorry still relatively new...

Hi, thanks!
The params classes such as AttackParams are declared in AnimalController.cs. These classes have the [Serializable] attribute applied, which takes care of creating an instance of the class and serializing it on the inspector.
Hope it helps! Let me know if it fixed your problem.


[BEAM-7744] LTS backport: Temporary directory for WriteOperation may not be unique in FileBaseSink

Temporary directory for WriteOperation in FileBasedSink is generated
from a second-granularity timestamp (yyyy-MM-dd_HH-mm-ss) and unique
increasing index. Such granularity is not enough to make temporary
directories unique between different jobs. When two jobs share the same
temporary directory, output file may not be produced in one job since
the required temporary file can be deleted from another job.
To avoid fore-mentioned issue, this commit changes the temporary
directory name from a second-granularity timestamp to UUID.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @chamikaramj @aaltay
CC: @kennknowles

Can you please include some description of the change in the commit message and the pull request title and body?

Thanks! That is a great description. It seems we had a problem that does not have to do with your change. I will try again and see if we still have this problem with maven central.

Run Java PreCommit

Run Java PreCommit

Timeline of build that failed to fetch deps: https://scans.gradle.com/s/3q7zofz6vgbso/timeline (it failed on zookeeper but I think this is not important)

run java precommit

LGTM. Thanks.

run java precommit

Hmm now I have seen this reliably. Last time I checked that dep was fine but maybe something is wrong specifically.
org.gradle.api.internal.tasks.TaskDependencyResolveException: Could not determine the dependencies of task ':beam-sdks-java-io-google-cloud-platform:shadowTestJar'.Open stacktrace
Caused by: org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':beam-sdks-java-io-google-cloud-platform:testRuntime'.Open stacktrace
Caused by: org.gradle.internal.resolve.ArtifactNotFoundException:
Could not find powermock-api-mockito-sources.jar (org.powermock:powermock-api-mockito:1.6.4).
Searched in the following locations:
    file:/home/jenkins/.m2/repository/org/powermock/powermock-api-mockito/1.6.4/powermock-api-mockito-1.6.4-sources.jar

Yea, just built locally and I see:
Download https://repo.maven.apache.org/maven2/org/powermock/powermock-api-mockito/1.6.4/powermock-api-mockito-1.6.4-sources.jar

run java precommit

I wonder if actually these are symptoms of the disk being filled. I could not find evidence clearly in the console log, and I was unable to SSH to the machine to check. But it does seem reliable with this PR.

Run Java PreCommit

Run JavaPortabilityApi PreCommit

@kennknowles @aaltay Java precommit passed. PTAL. Thanks!

I am guessing the other error for JavaPortabilityApi test is fine because the error is "14:13:05 Task 'javaPreCommitPortabilityApi' not found in root project 'beam'." It does not look like test exists in this branch.