Create new topic Prestashop

initial info - Create new topic Prestashop

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

PrestaShop is currently used by 300,000 shops worldwide and is available in 60 different languages.

Hello,
I have a question for you. I'm looking to put together a team. A small
business.
No joking. What if I was able to show that I am Satoshi Nakamoto in 15
minutes. I need a small team of 10 people or leass, to help explain the
best ways to get my wallets in the best source for everyone. Would that be
METAMASK? BITCOIN WALLET ??? THINGS LIKE THAT.
WOULD YOU BE INTERESTED IN TALKING FURTHER? YOU CAN CALL ME OR TEXT.

SCOT RINGA
3193203284
On Sun, Mar 19, 2023, 12:01 Alejandro Lazcano @.***>
wrote:

initial info - Create new topic Prestashop
Please confirm this pull request meets the following requirements:

I followed the contributing guidelines:
https://github.com/github/explore/blob/main/CONTRIBUTING.md.
I have no affiliation with the project I am suggesting (as a
maintainer, creator, contractor, or employee).

Which change are you proposing?

Suggesting edits to an existing topic or collection
Curating a new topic or collection
Something that does not neatly fit into the binary options above

Curating a new topic or collection

I've formatted my changes as a new folder directory, named for the
topic or collection as it appears in the URL on GitHub (e.g.
https://github.com/topics/[NAME] or
https://github.com/collections/[NAME])
My folder contains a *.png image (if applicable) and index.md
All required fields in my index.md conform to the Style Guide and
API docs: https://github.com/github/explore/tree/main/docs

PrestaShop is currently used by 300,000 shops worldwide and is available
in 60 different languages.

You can view, comment on, or merge this pull request online at:
https://github.com/github/explore/pull/3639
Commit Summary

e32594a
https://github.com/github/explore/pull/3639/commits/e32594a0444267c7176f7b060d948fdc6ee8654e
Create new topic Prestashop

File Changes
(1 file https://github.com/github/explore/pull/3639/files)

A topics/prestashop/index.md
https://github.com/github/explore/pull/3639/files#diff-679adc4f29df7a496e3dfc04ad03e6b321f5e6835b17523dc543c2aa443c1e26
(16)

Patch Links:

https://github.com/github/explore/pull/3639.patch
https://github.com/github/explore/pull/3639.diff

—
Reply to this email directly, view it on GitHub
https://github.com/github/explore/pull/3639, or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4E4AGQYQ4H2IZHCOF27F23W443VPANCNFSM6AAAAAAWAG7FUU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@Kristories I was just working on it. The truth is that years ago I did not have to do PR, my role as project manager has made me forget some things. I appreciate his predisposition and accompaniment, really, he is very helpful to me 💯

Ok, Looks like I fell asleep on the keyboard last night and made a mess. Everything is fixed now :) finally the tests are all ok and the PR for New Topic Prestashop is ready.


Combine several markdown files to one pdf file

Thanks, I am gonna look over it and try to merge it soon!


example on how to use AC3 audio?

Is there an example on how to use AC3 audio?
The AC3 audio codec is experimental in ffmpeg and pyav falls over with an appropriate error
For example:
output_audio_stream = output.add_stream("aac")
returns:
av.AVError: [Errno 733130664] Experimental feature

This will be a fun one. On my machine, that codec is marked experimental, but my trivial tests don't seem to care (on "aac", "vorbis", or any of the others which do self-identify as experimental).
Can you tell us about your OS and FFmpeg/LibAV version?

Hi,
Its CentOS release 6.6 (Final)
ffmpeg is version 2.3.3
libavcodec.so.54   Version 1.2.6

I'm going to close this issue, in the FFmpeg versions currently supported by PyAV, both aac and ac3 streams seem to work fine.


add ec2 CreateTags to roles

needed after https://github.com/openshift/hypershift/pull/786

/retest


DAT-17896 Trigger functional and harness tests by request

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Does this mean the test execution flow will now change and if we want to trigger Test-harness and Functional Test execution we need to add their respective labels, right? Does this apply to contributor's PRs as well as internal PRs?
Thanks,
Daniel.

Does this mean the test execution flow will now change and if we want to trigger Test-harness and Functional Test execution we need to add their respective labels, right? Does this apply to contributor's PRs as well as internal PRs?
Thanks, Daniel.

yes, sir.
and should be the same procedure for contributor's PRs
but unfortunately I can't test this in branch

I have a few more questions:

Why are functional tests and test harness triggered without the required tags? Is that what you mentioned it wasn't possible to test in this branch? @rberezen
I see most of the checks are being executed twice using pull_request and pull_request_target. What does it mean each of these? Is this the expected behavior running checks for each of them? @jandroav @sayaliM0412

Thanks,
Daniel.

I have a few more questions:

Why are functional tests and test harness triggered without the required tags? Is that what you mentioned it wasn't possible to test in this branch? @rberezen
I see most of the checks are being executed twice using pull_request and pull_request_target. What does it mean each of these? Is this the expected behavior running checks for each of them? @jandroav @sayaliM0412

Thanks, Daniel.

yes, can't test in branch
looking at it, removed   pull_request: types: [labeled] where it is not necessary...checking

Looks fine to me. You could move the "Check runTestHarnessTests label" above the checkout step if you cared to.

@rberezen +1 to @StevenMassaro comments. It will save us some extra ticks.

I have a few more questions:

Why are functional tests and test harness triggered without the required tags? Is that what you mentioned it wasn't possible to test in this branch? @rberezen
I see most of the checks are being executed twice using pull_request and pull_request_target. What does it mean each of these? Is this the expected behavior running checks for each of them? @jandroav @sayaliM0412

Thanks, Daniel.

@MalloD12 should be better now, no more extra run for unit/integrations tests


Data loading docs

Initial outline for the "Data loading" section of the start docs

Stuff moved forward from here so just cleaning up. Thanks for all your work.


[fix][doc] Add config of IO and acceptor threads in proxy

Modifications
Similar to 15818, the doc changes implemented in #15340 were labeled with the 2.10.1 release after the PR was merged.
This doc PR catches up with the improvements in 2.10.1 docs, as well as fixing a few broken links that missed the time window to inherit from 2.10.0.
Documentation

[x] doc

Ping @Anonymitaet for review.


only show pytest panel if error

status-bar blink green if success during 500ms

@jgirardet ,
I am thinking and its better if this behavior may be configured in the plug-in settings too, so backward compatibility is not broke and maybe some users wants to see the panel on every run, even without failures.
So, could you add a new configuration named: "Only show test status panel on failures". The default value should be false the keep as it is today. If you need help on how to do this, I can help you.
Thanks again!

hello,
did you have time to check it ?

Sorry for the delay! I have fixed the conflicts and merged!

ok cool


Add quick start guide to README

A primary action item from today's meeting was adding a clearly-defined quick start guide to this repo. The README serves as the primary documentation so that is probably the right place for it. Thanks @tz33cu for this helpful suggestion.

What do people think about outsourcing some of the stuff in the README to the website, where the latter could then serve as the primary documentation. The quick start guide could then also be part of the website, and we could link to it from the README.

I think quick start should be concise and would be a high priority item to keep near the top of the README (and duplicated on the website), as this is the one piece of information we want to make sure people find. I agree that more detailed info (tables, detailed preprocessing instructions, etc.) on the website makes sense.

I think we can close this because @jerrylin96 has added this via this commit. Jerry, now that we are several people managing the GitHub repo, it would be great if you could submit PRs (rather than pushing directly to the main branch) so we can keep track of what is happening. :) Thanks so much!


Returning all permissions on a caller

Is there a way to return a list of all privileges and/or restrictions on a given caller?
I'd like to return a list of the logged in user's permissions so I can display/edit them in an admin panel, and I can't see a way to easily retrieve all permissions.
Thanks!

Hey @Mattnmoore, are the allowed and denied calls the one's you're looking for?

Almost, it looks like those methods require a specific resource/action. I was looking for something like $user->getPermissions() and having that return an array containing all permissions for that user, if that makes sense.
I ended up writing a custom solution to accomplish what I'm looking for, I was just curious if there was something built in.
P.S. this is an awesome package, it's been my favorite ACL package so far. I'm using the Laravel driver as well, thanks for writing that, @driesvints!

Hmm, I see what you mean. I actually have found the need myself sometimes to retrieve the permissions directly so perhaps I should just make it public. I first want to see if I can't find another way to make this happen, though.

Need this too.


Window size for PDF Journals

If possible, a feature that automatically renders PDF journals in a vertical size of the maximum and the width in relation to that (assuming no one plays foundry in pivotal mode) would help tremendously in the legibility of PDFs. With the default resolution, PDFs are very hard to read (at least mine are) and the first thing I need to do when opening a PDF is to resize the window to the maximum height possible so that they become somewhat legible.
Would such a feature be possible and in scope of PDF Pager?

Are you asking for the journal window to be made as tall as possible when a PDF is opened?

Yes, that'd be helpful I think. Similar to the way PDFoundry was. If there were a way to remove the journals header as well this would be even better. As I said: I don't know if this is out of scope for this module but it would make PDFs easier to handle without zooming in.

A little while ago I added an option to set the default zoom level. This doesn't address the window size problem (which is tricky for me to force), but hopefully makes part of the PDF a little larger and easier to read initially.

I don't know if a journal can be forced to open with a specific size but if so, a neat way to do it would be to save the last window size as flags when closing and setting that size with that size next time it is opened.

I don't know if a journal can be forced to open with a specific size but if so, a neat way to do it would be to save the last window size as flags when closing and setting that size with that size next time it is opened.

That sounds like a sensible idea. If the size is stored on the Actor, then the window would have to be sized once for each actor that is opened, but probably better than having to resize every time that the Actor window is opened.

Version 0.39.0 saves the window size when a fillable PDF is used for Actor Sheets.
I don't know if this is also required for normal journal entries.

I'd argue it's especially important for regular journal entries. I use a lot of PDFs to have access to the rules which have no official FVTT support and having to resize them every time I log in is a bit tedious. Would much appreciate if you'd do this for journals as well. =)

Having the size of journal windows to be saved is a more general issue with Foundry, rather than being specific to PDF Pager.
I'm sure that many users would prefer the default size of their non-PDF journals to be remembered too.


Lowercase image_name

Currently step fails with this error:
ERROR: invalid tag "ghcr.io/inCaller/prometheus_bot:latest": repository name must be lowercase

This PR attempts tries lowercasing repository name.

BTW you can enable automerge.


Can't power up a VM if Internet connection is down

Errors when power up a VM with vagrant-r10k plugin used and Internet connection is down:
==> default: vagrant-r10k: Beginning r10k deploy of puppet modules into /home/tresi02/git/projeqtorquebec/puppet/externalmodules using /home/tresi02/git/projeqtorquebec/puppet/Puppetfile
[R10K::TaskRunner - ERROR] Task #R10K::Task::Module::Sync:0x000000019db4e8 failed while running: Couldn't update git cache for https://github.com/saz/puppet-timezone.git: "fatal: unable to access 'https://github.com/saz/puppet-timezone.git/': Could not resolve host: github.com"
RuntimeError: Couldn't update git cache for https://github.com/saz/puppet-timezone.git: "fatal: unable to access 'https://github.com/saz/puppet-timezone.git/': Could not resolve host: github.com"
I don't know if it is a limitation of R10K (the version used by vagrant-r10k) or if it is something that we can fix in vagrant-r10k directly.

I'm terribly sorry... somehow I hadn't seen this issue. I've been incredibly busy (~16 hour days) this week trying to get a work project out the door, but I should have some time next week to look into this and try to come up with a solution.
That does seem completely understandable to me... r10k is intended to deploy modules, so I wouldn't expect it to work nicely without connectivity. So I guess it's a limitation of r10k... but I don't really see how things could work otherwise.
The actual "problem" here is that vagrant-r10k treats R10K failures/errors as provisioning failures. I strongly believe this is the right default behavior; if you tell vagrant-r10k to do something (deploy modules) and it can't, it should make you abundantly aware of that, not fail silently.
So the question becomes how to allow a user to tell vagrant-r10k to ignore errors?

simple way: add a config flag to ignore any r10k errors. We could try to get fancy and ignore only the errors that result from DNS not working or inability to connect, but that would require parsing exception strings generated by r10k, which shouldn't really be relied on.
maybe better way: add a command line option to vagrant up to ignore errors, or maybe just to skip r10k.
simply don't run r10k when we don't have connectivity. But aside from trying to get data (i.e. from httpbin.com) and seeing if it works or not, there's no cross-platform way that I know of to determine if we have connectivity.

@tremblaysimon any thoughts on this? Until I get a fix implemented, you can always just comment out the vagrant-r10k config when you're working without connectivity...

No problem with the delay we all have our priority and I understand that!
I agree with you that R10K failures/errors are provisioning failures too.
Since it is a R10K problem when there is no connectivity  I think I will address it to R10K project directly. And of course the best workaround currently is to comment out vagrant-r10k config in Vagrantfile...
And hopefully it isn't a problem that we face often (lack of connectivity).
P.S. I think vagrant-r10k isn't using latest version of R10K ? I will test latest R10K version directly and see if errors happen when there is no connectivity.

Maybe we should close that issue and just let it there if someone else face the same problem someday.

As of #9 / #23 (not yet released), vagrant-r10k can be completely skipped by running with --no-provision or by commenting out the code.
What remains for this is to, in VagrantPlugins::R10k::Action::Deploy.deploy, catch whatever specific error is raised when a repo can't be accessed, and present that to the user in a cleaner format, suggesting the workaround of (1) ensuring the repo path is right, or (2) either commenting out the vagrant-r10k config or running with --no-provision.


Support for Python Intellisense can't handle "from  import *" construct

This issue has been moved from a ticket on Developer Community.

[severity:It bothers me. A fix would be nice]
In an editor window for a Python file, possible code problems are marked. For example, an undefined symbol has a green squiggle line.
Browsing support for Python can handle 'import' statements and correctly import browsing data for such modules. It appears, though, that the construct:
from  import *

Is not properly importing names defined in the module. "from ... import ..." imports names into the current namespace, without the module name prefix. Visual Studio shows such names as undefined. If you explicitly import names from a module, VS shows them as defined. See the attached recording.

Original Comments
Feedback Bot on 3/5/2023, 10:08 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Hi there, I can only see limited screenshots from the repro steps uploaded. In order to understand your issue better, I have created a simplified version of your code. 😊Based on my understanding, are you indicating that you're only seeing the func1() in consume.py has the green squiggles? What does the error say?
# declare.py
def func1():
    print("func1")

def func2():
    print("func2")

# consume.py
from declare import *
from declare import func2
func1()
func2()


Parsing event callback failed with "UnimplementedEvent" on mock API

On the line:
let event = Event::parse_http(&request).unwrap();

Relevant panic:
called `Result::unwrap()` on an `Err` value: UnimplementedEvent { version: "test", event_type: ChannelSubscribe }

Using the mock API command:
twitch event trigger subscribe -F https://localhost:3002/public/twitch/callback -s EVENTSUB_VERY_SECRET_CHANGE_ME

As a workaround, this will modify a request's headers to replace the "test" version with the expected "1":
if parts.headers["twitch-eventsub-subscription-version"] == "test" {
    parts
        .headers
        .insert("twitch-eventsub-subscription-version", "1".parse().unwrap());
}

this was fixed in https://github.com/twitchdev/twitch-cli/pull/165 and included in 1.1.7, make sure you've updated your version.
Does upgrading twitch-cli work better?

Looks like the twitch bucket for scoop wasn't updated with 1.1.7 until 3 days ago, updated it and now it works, thanks!

Hi @LaylBongers,
Apologies for posting off-topic here, but this is the only way I know how to reach you. It appears you have the name "clockwork" registered on Crates.io. Would you potentially be interested in selling this package name? I would be happy to pay a fair sum for it. If so, please email me at<EMAIL_ADDRESS>https://github.com/carbidegames/clockwork/issues/2


"Prolog" option duality

I use Linux with bash. So the hardcoded default "Prolog"->"~.zshrc" doesn't work well for me. Also, in order to have a nodejs that is not too old, I installed a fresh nodejs using nvm. In order for this to be recognized, I have found that I can provide a "Prolog" -> "source ~/.nvm/nvm.sh" option. The problem is that "Prolog" is also an option for Graphics so when I generate a diagram in "PDF" format, the option is also sent to the resulting Graphic resulting in a error.

Thank you for your interest in this paclet!
I will review and test your proposed changes and submit a new paclet version soon.

Sorry, for my delayed response...
MermaidJS has the option "ShellSession" -> Automatic. I think it is more consistent the to change "Prolog" into "ShellSessionProlog". What do you think?

This issue should be fixed in the version 1.0.5 of the paclet.


⚠ CIOOS Pacific ERDDAP dataset ECCC_MSC_BUOYS has degraded performance

In 91e1bed, CIOOS Pacific ERDDAP dataset ECCC_MSC_BUOYS (https://data.cioospacific.ca/erddap/tabledap/ECCC_MSC_BUOYS.htmlTable?wmo_synop_id&time>now-3hours&distinct()) experienced degraded performance:

HTTP code: 503
Response time: 21095 ms

Resolved: CIOOS Pacific ERDDAP dataset ECCC_MSC_BUOYS performance has improved in 9f74961 after 3 minutes.


怎么对图片进行批量推理呢？

https://github.com/haotian-liu/LLaVA/issues/1009#issuecomment-1907974004

https://github.com/haotian-liu/LLaVA/issues/754#issuecomment-1907970439


Resolved Bug 586 and 594 : Dark Theme Text Is Not Display Proper And Dark Theme Selected Value Is Not Visible Proper

Description

Dark Theme Text Is Not Display Proper And Dark Theme Selected Value Is Not Visible Proper:

Offcanvas
Textarea
Admin Dashboard
Select List

Make the changes to colorvariables-dark.scss  and button.scssfile.
Dark Theme Text Is Not Display Proper And Dark Theme Selected Value Is Not Visible Proper.

Screenshots :
OffCanvas :

Textarea :

Admin Dashboard :

Select List :

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Changes Reviewed and PR Approved


[memdb] Online delete broken

Issue Description

Steps to Reproduce

Expected Result

Actual Result

Environment

Supporting Files

https://github.com/Xahau/xahaud/commit/2bc5a8b1e89e1279cf8bf6e30be2cfa160828099

https://github.com/Xahau/xahaud/pull/378/commits/8b0d42785cc1f4fd3f2b2582d8db4f38ef93b31d


Add functions and objects for Temporary Directories

🎉 Functions for interacting with temporary directories
Closes #232.  Split from #238 to make a version that should be portable to all ign-common4 platforms.
Summary
Adds free functions and a RAII object for interacting with operating system temporary directories.  This is useful for writing tests or utilities that need to access a temporary location that can be cleaned up at the end of execution, rather than using build artifact directories or users' home folders.
Free Functions:

tempDirectoryPath() - retrieve OS-specific location of temporary directory
createTempDirectory() - create a directory in the tempDirectoryPath, expanding template strings where necessary.

Obejcts:

TempDirectory - Object that will create a temporary directory and optionally clean it up when it goes out of scope.

Test it
Usage is demonstrated in the TempDirectory_TEST.cc unit tests.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Failure in focal CI is due to flaky test that uses timings.

Windows is failing https://build.osrfoundation.org/job/ignition_common-ci-pr_any-windows7-amd64/1390/consoleFull#15419766088ff58640-3599-4406-a210-216932f1748c

This will require switching ignition common to use colcon:  https://github.com/ignition-tooling/release-tools/pull/511

@osrf-jenkins retest this please

@ahcorde should be good now.  windows.h has to be first, which breaks when alphabetized.

this pull request may not work properly on debian buster with armhf: https://github.com/ignitionrobotics/ign-common/issues/255


feat(medical-record): add update and remove feature

Overview
Currently we're supported to add medical record with no option to edit or remove them. It's seem so intolerant for the doctor to correct their typos.
Testings

[x] Update medical record
[x] Remove (soft-delete) medical record

Codecov Report

Merging #68 (a1497c5) into master (ff1ec09) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          204       212    +8
=========================================
+ Hits           204       212    +8

Impacted Files
Coverage Δ

src/app/medical_record/services/usecases.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1ec09...a1497c5. Read the comment docs.

I just saw it on code, you shouldn't update the patient id and polyclinic id after the medical record is created. Please fix it.


Release v1.3

[ ] Expose linear scan
[ ] Make the inner tables return the amount of memory they use
[ ] Parameter search in the wrapper
[ ] Add query objects to wrapper for multi-threaded querying (#6)
[ ] Add check in wrapper for k and bit-packed table (#45)

Might be good to take care of a few clean-up issues like #32 and #14 also.


Convert/Quantizer bf16 support

Currently using a finetuned model loaded/trained using bf16. Upon calling the convert.py on the checkpoint, it throws unexpected bf16 error.
CUDA_VISIBLE_DEVICES=0 python convert.py -c train.parquet -r 200 \
 -i  /checkpoint-136 \
 -b 4.625 -hb 6 \
 -o test_quant

Traceback (most recent call last):
  File "/home/exllamav2/convert.py", line 53, in <module>
    model.load(lazy = True)
  File "/home/exllamav2/exllamav2/model.py", line 227, in load
    stats = self.set_device_map(gpu_split or [99999])
  File "/home/exllamav2/exllamav2/model.py", line 185, in set_device_map
    footprint = module.weight_footprint()   # Footprint, in bytes
  File "/home/exllamav2/exllamav2/attn.py", line 109, in weight_footprint
    self.q_proj.weight_footprint() + \
  File "/home/exllamav2/exllamav2/module.py", line 114, in weight_footprint
    self.footprint = self.load_multi(["weight"], measure = True)
  File "/home/exllamav2/exllamav2/module.py", line 67, in load_multi
    size += _tsize(st, self.key + "." + k)
  File "/home/exllamav2/exllamav2/module.py", line 23, in _tsize
    else: raise ValueError(f"Unexpected datatype {dtype}: {key}")
ValueError: Unexpected datatype BF16: model.layers.0.self_attn.q_proj.weight

env
Python 3.10.10
Torch Version: 2.2.0.dev20230913+cu121
Safetensors Version: 0.3.3
Transformers: 4.34.0.dev0

checkpoint config.json
{
  "_name_or_path": "/root/llama2-13b-hf/",
  "architectures": [
    "LlamaForCausalLM"
  ],
  "auto_map": {
    "AutoModelForCausalLM": "flash_llama.LlamaForCausalLM"
  },
  "bos_token_id": 1,
  "eos_token_id": 2,
  "hidden_act": "silu",
  "hidden_size": 5120,
  "initializer_range": 0.02,
  "intermediate_size": 13824,
  "max_position_embeddings": 4096,
  "model_type": "llama",
  "num_attention_heads": 40,
  "num_hidden_layers": 40,
  "num_key_value_heads": 40,
  "pretraining_tp": 1,
  "rms_norm_eps": 1e-05,
  "rope_scaling": null,
  "rope_theta": 10000.0,
  "tie_word_embeddings": false,
  "torch_dtype": "bfloat16",
  "transformers_version": "4.34.0.dev0",
  "use_cache": false,
  "vocab_size": 32000
}

I'm a little skeptical of using BF16 in the first place, and what losing those 3 bits of precision means when further quantizing the model. But I am working on it.
I thought I'd found a BF16 model to test on, but it turned out it wasn't. Do you have a HF link for a model that definitely has some BF16 tensors?

Well, I've spent too long looking for a BF16 model to test, so I've just added the BF16 slice type with an element size of two. Not sure how well it will work, but it should now be able to read BF16 weight tensors and convert them to FP16 when loading.

Yeah. I don't know of a public bfloat16 model to test either. The one I have is company property so I can't upload it and looks like based on your own tests, many of the models uploaded to the HF repo are mislabeled.
For now we are working around the problem by retraining the model where the llama2 is loaded as default f16 but training is still bf16 so that when model/checkpoint saves, it is still f16. Before we were loading and training as bf16.

Successfully convert b16 llama2-7b model. Just had to restart conversion due to memory issues. But it resumed perfectly.
Sysytem specs: 32GB RAM, 12 GB VRAM(3080Ti)
python test_inference.py -m ./model/converted/ -p "Once upon a time,"
 -- Model: ./model/converted/
 -- Options: ['rope_scale 1.0', 'rope_alpha 1.0']
 -- Loading model...
 -- Loading tokenizer...
 -- Warmup...
 -- Generating (greedy sampling)...

Once upon a time, there was a little boy who lived in a village. 1. The little boy was very naughty. 2. He was always fighting with other children. 3. He was always breaking things. 4. He was always making trouble. 5. He was always getting into trouble. 6. He was always getting into fights. 7. He was always getting into trouble. 8. He was always getting into trouble. 9. He was always getting into trouble. 10. He was always getting into trouble. 11. He was always getting into trouble. 12

Prompt processed in 0.01 seconds, 5 tokens, 379.03 tokens/second
Response generated in 0.81 seconds, 128 tokens, 158.43 tokens/second

Does anyone have some benchmarks for float16 vs bfloat16 quality impact post-quantization?

I thought I'd found a BF16 model to test on, but it turned out it wasn't. Do you have a HF link for a model that definitely has some BF16 tensors?

https://huggingface.co/Thireus/WizardLM-70B-V1.0-BF16/

There are still some open questions around the loss of dynamic range when converting from BF16 to FP16, and whether it has an impact performance during or after quantization. I'll close this issue for now anyway, since BF16 models no longer fail to convert.


Add Fleet package policy and epm support

Add Fleet EPM (Elastic Package Manager) support, currently only provides for installing and uninstalling packages.
Add Fleet Package Policy support.
Add acceptance tests
Add documentation

Linter seems broken (possibly by force pushes). Going to close this PR and try a new one.


Error creating Proc with explicit receiver

$crystal --version
Crystal 0.27.2 [60760a546] (2019-02-05)

LLVM: 4.0.0
Default target: x86_64-unknown-linux-gnu

a = 15
b = ->a.divisible_by?(Int32)
Module validation failed: Invalid bitcast
  %74 = bitcast i32 %73 to i8*, !dbg !19
 (Exception)
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
Error: you've found a bug in the Crystal compiler. Please open an issue

Playground link
I've generally been having issues with trying to use Procs with a receiver. In Ruby I use the method method often. Crystal's syntax seems like it would be an improvement.

This is fixed in master. I fixed it in https://github.com/crystal-lang/crystal/pull/7334

@asterite Are you sure it's the same issue? The one you mentioned was about parsing, whereas this one parses well, and the error refers to LLVM.

Pretty sure. In the PR I mention that I also found bugs with creating procs for methods of primitive types and that I fixed that.

This does not produce the same error on the current master, as far as I can tell. Getting Crystal to compile on Ubuntu was interesting. But, uh:
~/s/c/crystal ❯❯❯ bin/crystal eval "a = 15; b = ->a.divisible_by?(Int32); pp [3,5,7].map(&b)"
Using compiled compiler at `.build/crystal'
[true, false, false]
~/s/c/crystal ❯❯❯ bin/crystal eval "a = 15; b = ->a.divisible_by?(Int32); pp [3,5,7].map(&b)"
Using compiled compiler at `.build/crystal'
[false, true, false]
~/s/c/crystal ❯❯❯ bin/crystal eval "a = 15; b = ->a.divisible_by?(Int32); pp [3,5,7].map(&b)"
Using compiled compiler at `.build/crystal'
[false, false, false]

That probably shouldn't do that?
~/s/c/crystal ❯❯❯ bin/crystal --version
Using compiled compiler at `.build/crystal'
Crystal 0.28.0-dev [5282fdf91] (2019-03-23)

LLVM: 4.0.1
Default target: x86_64-pc-linux-gnu

Yeah, I can confirm this non-deterministic behaviour on master.

with this:
a = 15
b = ->a.divisible_by?(Int32)
b.call(3)
b.call(3)
b.call(3)

The results will be wrong most of the time, but each call produces the same results: either all true or all false.

Not sure it is the same bug:
class A
  @p : Proc(Int32, Bool)
  def initialize(i)
    @p = ->i.<(Int32)
  end
end

A.new 1

Module validation failed: Invalid bitcast
  %1 = bitcast i32 %i to i8*, !dbg !11
 (Exception)
  from ../../../../../../crystal/src/int.cr:1091:11 in 'finish'
  from ../../../../../../crystal/src/compiler/crystal/codegen/codegen.cr:69:7 in 'codegen'
  from ../../../../../../crystal/src/compiler/crystal/compiler.cr:172:16 in 'compile'
  from ../../../../../../crystal/src/compiler/crystal/command/spec.cr:76:14 in 'spec'
  from ../../../../../../crystal/src/pointer.cr:286:59 in 'run'
  from ../../../../../../crystal/src/compiler/crystal.cr:11:1 in '__crystal_main'
  from ../../../../../../crystal/src/crystal/main.cr:105:5 in 'main'
  from src/env/__libc_start_main.c:94:2 in 'libc_start_main_stage2'
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

Works in master, fixed in https://github.com/crystal-lang/crystal/pull/9824


train vespcn model error in VSRTorch

Traceback (most recent call last):
File "train.py", line 124, in
main()
File "train.py", line 118, in main
t.fit([tloader, vloader], train_config)
File "/home/disk1/hym/pycharm_remote/VideoSuperResolution-master/VSRTorch/Framework/Trainer.py", line 127, in fit
self.fn_train_each_step(label, feature, name, post)
File "/home/disk1/hym/pycharm_remote/VideoSuperResolution-master/VSRTorch/Framework/Trainer.py", line 148, in fn_train_each_step
loss = self.model.train([feature], [label], v.lr)
File "/home/disk1/hym/pycharm_remote/VideoSuperResolution-master/VSRTorch/Models/Vespcn.py", line 25, in train
sr, warps, flows = self.vespcn(*frames)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/disk1/hym/pycharm_remote/VideoSuperResolution-master/VSRTorch/Models/vespcn/ops.py", line 100, in forward
warp, flow = self.mc(target, r)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/disk1/hym/pycharm_remote/VideoSuperResolution-master/VSRTorch/Models/vespcn/ops.py", line 58, in forward
flow0 = self.coarse_flow(torch.cat([ref, target], 1))
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/container.py", line 92, in forward
input = module(input)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/container.py", line 92, in forward
input = module(input)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/disk1/hym/anaconda3/envs/pytorch100/lib/python3.7/site-packages/torch/nn/modules/conv.py", line 320, in forward
self.padding, self.dilation, self.groups)
RuntimeError: Expected 4-dimensional input for 4-dimensional weight [24, 6, 5, 5], but got 3-dimensional input of size [16, 64, 32] instead

Change to video related dataset.

Thank you. I have solved it.

When I run python train.py --model=srcnn --cuda --dataset=mydata in pytorch environment.
Traceback:
Traceback (most recent call last):
  File "train.py", line 17, in <module>
    from VSRTorch.Models import get_model, list_supported_models
ModuleNotFoundError: No module named 'VSRTorch'

I didn't change VSRTorch's path, So I don't know what happen with this.
Thanks.

Sorry, I soved it.


Crash Report - CrisF#3405

Multiple crashes.
Before crashing coda client status shows statuses like
Max observed block length:  264
Local uptime:               7m22s
Chain id:                   b90b8b744074d8cc9d864925b58d1f882b1c2e89a46245be3e0a969d39de43a0
Git SHA-1:                  4395e9162b55323e76141c174ed585a0bf8cce81

Missing details like height etc.
Crash reports not being generated.
Crash Report - CrisF#3405.txt

Closing this issue as it is stale for a long time.


Fix: Person logic to login user

What's the purpose of this pull request?
The login (field person) is unstable when you have the vtex_session in FastStore.
How it works?
The vtex_session cookie now is only used at the getSessionOrder and the session will only use the authCookie with a POST to maintain the session always updated without loosing the checkout object in order to sync the cart.
How to test it?
Create a vtex_session and the authCookie at the local env with valid values and check the expected behaviour.
https://github.com/vtex/faststore/assets/67066494/f11b52ca-4692-4a66-8498-3efefaa1bbbf

We won´t go thought with this PR.
This fix will be done here: https://github.com/vtex/faststore/pull/2013


Services: Limit autocomplete suggestions

Small UX fix to https://github.com/studentinsights/studentinsights/pull/2708, avoiding suggesting a longer list on click.

selfie


Update to the latest official sentry sdk major version

Now module is using 5.30.0 version of Sentry SDK
Last released version is 6.10.0

This would be resolved for all times if @sentry/node would be a peerDependency instead of dependency

this has been updated


Release v1.7.0 not backwards compatible

Commit 1b03b84ed0573c46c8f36c5a864ccfe0ed0daeeb added a dependency to an MSL icon which was newly introduced in MSL v3.2.3. As a result MDD v1.7.0 unintentionally will not work if used with a previous MSL version. We should probably aim for a bug fix release v1.7.1 which establishes backwards compatibility.

So basically this means, we only increase the version of the uses annotation (as e4c854a47c961a57634d47171c60d84968b1147c) did, to please the Dymola auto-conversion, but nost not actually update library code to utilize new features. Sigh. If we only had impact.

Unfortunately, I don't know a better way using the current version handling facilities. This uses(...) annotation should be enhanced, but I suppose that would mean to agree on a common versioning scheme like SemVer and support it in a standardized fashion.

I've made a draft release for v1.7.1 and planned to publish it this Friday, 2019-04-05. This can be moved to a later date if there pop up some other issues which should be solved.


Adding Laravel Octane

Thanks for the PR. Laravel Octane was already there, but under a different section.


Mark the fingerprints of all inhibiting rules

Before this change, Alertmanager would mark just the fingerprint of the first inhibition rule to inhibit an alert, rather than the fingerprints of all inhibition rules that inhibit the alert. This is different from silences which mark the IDs of all silences that silence an alert, not just the first silence.
This commit changes how inhibition rules work to match the behavior of silences, such that the fingerprints of all inhibition rules that inhibit the alert are marked.
This change is expected to increase CPU usage as the inhibiter has to do more work, matching the label set against all inhibition rules instead of stopping at the first match. However, this is no different from how silences mute alerts.

@beorn7 I see the comments were added in this PR here. What were the performance issues observed that caused inhibition rules to behave different from silences?

I just realized this code is broken when the source_matchers for an inhibition rule matches two or more alerts. In this case, the inhibition rule cache returns the fingerprint of just one of the inhibiting alerts rather than all fingerprints (link).

Here are the relevant PRs https://github.com/prometheus/alertmanager/pull/379 and https://github.com/prometheus/alertmanager/pull/1774.

I really don't remember the detailed motivations here, just that it was complicated. Maybe the problems you have encountered above have to do with the reason.

OK so I created a number of benchmarks to better understand how performance would be affected with this change. The four benchmarks do the following:

BenchmarkSmall benchmarks the performance of 10 inhibition rules, where each inhibition rule has just one matching alert.
BenchmarkLarge benchmarks the performance of 100 inhibition rules, where each inhibition rule has just one matching alert.
BenchmarkLarge100Alerts benchmarks the performance of 100 inhibition rules, where each inhibition rule has a 100 matching alerts.
BenchmarkLarge1000Alerts benchmarks the performance of 100 inhibition rules, where each inhibition rule has 1000 matching alerts.

Here are the benchmarks from main:
BenchmarkSmall-8             	  145978	      8385 ns/op
BenchmarkLarge-8             	    6493	    178084 ns/op
BenchmarkLarge100Alerts-8    	    2560	    469184 ns/op
BenchmarkLarge1000Alerts-8   	      97	  10678130 ns/op

Here are the benchmarks from this branch:
BenchmarkSmall-8             	  131640	      9057 ns/op
BenchmarkLarge-8             	    5191	    219634 ns/op
BenchmarkLarge100Alerts-8    	     340	   3199206 ns/op
BenchmarkLarge1000Alerts-8   	       3	 377728514 ns/op

The benchmarks show that, when an inhibition rule has 1000s of alerts matching the source_matchers field, then Mutes becomes up to 30x slower. But this kind of makes sense, because we are now marking all 1000 alerts that are inhibiting the target alert, rather than just one. This can happen in practice if the label matchers in source_matchers are too coarse-grained. In practice, I'm not sure people use inhibition rules like this, and instead use fine-grained alerts to trigger inhibitions.
I still need to benchmark the performance difference when an alert matches multiple inhibition rules at the same time.
Here is the code:
// Copyright 2024 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package inhibit

import (
	"bytes"
	"context"
	"strconv"
	"testing"
	"time"

	"github.com/go-kit/log"
	"github.com/prometheus/common/model"

	"github.com/prometheus/alertmanager/config"
	"github.com/prometheus/alertmanager/pkg/labels"
	"github.com/prometheus/alertmanager/provider/mem"
	"github.com/prometheus/alertmanager/types"
	"github.com/prometheus/client_golang/prometheus"
)

// BenchmarkSmall benchmarks the performance of a small number of inhibition
// rules, where each inhibition rule has just one matching alert.
func BenchmarkSmall(b *testing.B) {
	runBenchmark(b, 10, 1)
}

// BenchmarkLarge benchmarks the performance of a large number of inhibition
// rules, where each inhibition rule has just one matching alert.
func BenchmarkLarge(b *testing.B) {
	runBenchmark(b, 100, 1)
}

// BenchmarkLarge100Alerts benchmarks the performance of a large number of
// inhibition rules, where each inhibition rule has a lot of matching alerts.
func BenchmarkLarge100Alerts(b *testing.B) {
	runBenchmark(b, 100, 100)
}

// BenchmarkLarge1000Alerts benchmarks the performance of a large number of
// inhibition rules, where each inhibition rule has a lot of matching alerts.
func BenchmarkLarge1000Alerts(b *testing.B) {
	runBenchmark(b, 100, 10000)
}

// runBenchmark runs an iteration of benchmarking the inhibitor for a
// specified number of alerts and inhibition rules.
func runBenchmark(b *testing.B, numInhibitionRules, numAlertsPerInhibitionRule int) {
	r := prometheus.NewRegistry()
	m := types.NewMarker(r)
	alerts, rules := newBenchmark(numInhibitionRules, numAlertsPerInhibitionRule)
	it, err := mem.NewAlerts(context.TODO(), m, time.Minute, nil, log.NewNopLogger(), r)
	if err != nil {
		b.Fatal(err)
	}
	defer it.Close()
	// Put the alerts into the mem store.
	for _, a := range alerts {
		tmp := a
		if err = it.Put(&tmp); err != nil {
			b.Fatal(err)
		}
	}
	ih := NewInhibitor(it, rules, m, log.NewNopLogger())
	defer ih.Stop()
	go ih.Run()
	// Wait 1ms for the inhibitor to seed its cache.
	<-time.After(time.Second)
	b.ResetTimer()
	// Run the benchmark.
	for i := 0; i < b.N; i++ {
		// Match the labels for each inhibition rule.
		for j := 0; j < numInhibitionRules; j++ {
			name, value := nextChar(j+2), nextChar(j+3)
			if ok := ih.Mutes(model.LabelSet{model.LabelName(name): model.LabelValue(value)}); !ok {
				b.Fatal("Expected mute", "labels", name, value)
			}
		}
		// Do the same number of calls, but this time with
		// labels that will never match the inhibition rules.
		for j := 0; j < numInhibitionRules; j++ {
			name, value := nextChar(numInhibitionRules+j), nextChar(numInhibitionRules+j+3)
			if ok := ih.Mutes(model.LabelSet{model.LabelName(name): model.LabelValue(value)}); ok {
				b.Fatal("Unexpected mute", "labels", name, value)
			}
		}
	}
}

// newBenchmark creates the alerts and inhibition rules for the benchmark.
func newBenchmark(numInhibitionRules, numAlertsPerInhibitionRule int) ([]types.Alert, []config.InhibitRule) {
	var (
		alerts = make([]types.Alert, 0, numInhibitionRules*numAlertsPerInhibitionRule)
		rules  = make([]config.InhibitRule, 0, numAlertsPerInhibitionRule)
	)
	for i := 0; i < numInhibitionRules; i++ {
		for j := 0; j < numAlertsPerInhibitionRule; j++ {
			alerts = append(alerts, types.Alert{
				Alert: model.Alert{
					Labels: model.LabelSet{
						model.LabelName(nextChar(i)):     model.LabelValue(nextChar(i + 1)),
						model.LabelName(strconv.Itoa(j)): model.LabelValue("0"),
					},
					StartsAt: time.Now(),
					EndsAt:   time.Now().Add(24 * time.Hour),
				},
			})
		}
		rules = append(rules, config.InhibitRule{
			SourceMatchers: config.Matchers{
				labels.MustNewMatcher(labels.MatchEqual, nextChar(i), nextChar(i+1)),
			},
			TargetMatchers: config.Matchers{
				labels.MustNewMatcher(labels.MatchEqual, nextChar(i+2), nextChar(i+3)),
			},
		})
	}
	return alerts, rules
}

func nextChar(i int) string {
	var b bytes.Buffer
	for i >= 0 {
		if i >= 26 {
			b.WriteRune('z')
			i -= 26
		} else {
			b.WriteRune(rune(97 + i))
			i = -1
		}
	}
	return b.String()
}

OK so I created a number of benchmarks to better understand how performance would be affected with this change. The four benchmarks do the following:

x_inhibition_rule,_1_inhibiting_alert-8 benchmarks the performance of x inhibition rules, where each inhibition rule has one inhibiting alert.
1_inhibition_rule,_x_inhibiting_alerts-8 benchmarks the performance of 1 inhibition rule, where the inhibition rule has x inhibiting alerts.
100_inhibition_rules,_1000_inhibiting_alerts-8 benchmarks the performance of 100 inhibition rules, which 1000 inhibiting alerts each.
x_inhibition_rules,_last_rule_matches-8 benchmarks the performance of x inhibition rules, where just the last inhibition rule inhibits, and all other inhibition rules are no-ops.

Here are the benchmarks from main:
BenchmarkMutes/1_inhibition_rule,_1_inhibiting_alert-8         	 1424942	       810.7 ns/op
BenchmarkMutes/10_inhibition_rules,_1_inhibiting_alert-8       	 1384290	       817.0 ns/op
BenchmarkMutes/100_inhibition_rules,_1_inhibiting_alert-8      	 1355450	       819.5 ns/op
BenchmarkMutes/1000_inhibition_rules,_1_inhibiting_alert-8     	 1334260	       850.6 ns/op
BenchmarkMutes/10000_inhibition_rules,_1_inhibiting_alert-8    	 1355574	       842.5 ns/op
BenchmarkMutes/1_inhibition_rule,_10_inhibiting_alerts-8       	 1227871	       906.0 ns/op
BenchmarkMutes/1_inhibition_rule,_100_inhibiting_alerts-8      	  490380	      2227 ns/op
BenchmarkMutes/1_inhibition_rule,_1000_inhibiting_alerts-8     	   97848	     12087 ns/op
BenchmarkMutes/1_inhibition_rule,_10000_inhibiting_alerts-8    	   10827	    104526 ns/op
BenchmarkMutes/100_inhibition_rules,_1000_inhibiting_alerts-8  	  100384	     11609 ns/op
BenchmarkMutes/10_inhibition_rules,_last_rule_matches-8        	 1103008	      1023 ns/op
BenchmarkMutes/100_inhibition_rules,_last_rule_matches-8       	  345433	      3303 ns/op
BenchmarkMutes/1000_inhibition_rules,_last_rule_matches-8      	   40462	     26343 ns/op
BenchmarkMutes/10000_inhibition_rules,_last_rule_matches-8     	    4449	    252129 ns/op

And here are the benchmarks from this branch:
BenchmarkMutes/1_inhibition_rule,_1_inhibiting_alert-8         	 1352847	       819.4 ns/op
BenchmarkMutes/10_inhibition_rules,_1_inhibiting_alert-8       	  283840	      4123 ns/op
BenchmarkMutes/100_inhibition_rules,_1_inhibiting_alert-8      	   30540	     35556 ns/op
BenchmarkMutes/1000_inhibition_rules,_1_inhibiting_alert-8     	    3244	    353088 ns/op
BenchmarkMutes/10000_inhibition_rules,_1_inhibiting_alert-8    	     290	   3649391 ns/op
BenchmarkMutes/1_inhibition_rule,_10_inhibiting_alerts-8       	  316680	      3682 ns/op
BenchmarkMutes/1_inhibition_rule,_100_inhibiting_alerts-8      	   37304	     28697 ns/op
BenchmarkMutes/1_inhibition_rule,_1000_inhibiting_alerts-8     	    4122	    280268 ns/op
BenchmarkMutes/1_inhibition_rule,_10000_inhibiting_alerts-8    	     361	   2952918 ns/op
BenchmarkMutes/100_inhibition_rules,_1000_inhibiting_alerts-8  	      34	  32002771 ns/op
BenchmarkMutes/10_inhibition_rules,_last_rule_matches-8        	 1054029	      1065 ns/op
BenchmarkMutes/100_inhibition_rules,_last_rule_matches-8       	  342032	      3387 ns/op
BenchmarkMutes/1000_inhibition_rules,_last_rule_matches-8      	   38838	     27282 ns/op
BenchmarkMutes/10000_inhibition_rules,_last_rule_matches-8     	    4356	    262349 ns/op

I also benchmarked Mutes for silences:
BenchmarkMutes/1_silence_mutes_alert-8         	 1328642	       867.0 ns/op
BenchmarkMutes/10_silences_mute_alert-8        	  558032	      2151 ns/op
BenchmarkMutes/100_silences_mute_alert-8       	  105117	     11372 ns/op
BenchmarkMutes/1000_silences_mute_alert-8      	    8367	    135013 ns/op
BenchmarkMutes/10000_silences_mute_alert-8     	     745	   1576070 ns/op
BenchmarkQuery/100_silences-8                  	   65757	     18499 ns/op
BenchmarkQuery/1000_silences-8                 	    7033	    164574 ns/op
BenchmarkQuery/10000_silences-8                	     298	   3876756 ns/op

The benchmarks shows the following:

Inhibitor.Mutes is O(N) relative to the number of inhibition rules. The more inhibition rules there are the more comparisons need to be made. No surprises here.
Since in main branch inhibitor.Mutes stops at the first inhibiting rule, when there are lots of inhibition rules it's faster for an alert to be inhibited than not inhibited. This is not the case in this branch though, as we are matching all inhibition rules. No surprises here either.
It seems that having lots of silences doesn't scale well either. In fact silences seem to scale the same as inhibition rules do with the changes in this branch. This is surprising and so I want to double check this further as I know Bjorn did some optimizations here.
With sensible limits, I think we can have reasonable performance for both inhibition rules and silences, where we track all inhibiting alerts and silence IDs up to some sensible limit.


reqstatus: fixed segmentation fault of req_status_show_field directive

If req_status_show_field is enabled and req_status_zone_add_indicator is
diabled, rmcf->user_defined_str will be NULL, then referring its "elts"
field causes segmentation fault.
The following configure will cause segfault with command sbin/nginx -t:
req_status_zone server_status "$host" 50M;
req_status server_status;
server {
    listen 8882;
    location = /us {
        req_status_show;
        req_status_show_field bytes_in bytes_out;
    }
}

Try to fix https://github.com/alibaba/tengine/issues/804

$ gdb --args sbin/nginx -t
(gdb) r
Starting program: /home/xiaochen.wxc/work/github/tengine-xiaochen/output/sbin/nginx -t
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x000000000052157d in ngx_http_reqstat_show_field (cf=0x7fffffffbf70, cmd=0x7d9d00 <ngx_http_reqstat_commands+224>, conf=0x84f2d8)
at src/http/modules/ngx_http_reqstat_module.c:344
344         user = rmcf->user_defined_str->elts;
(gdb) bt
#0  0x000000000052157d in ngx_http_reqstat_show_field (cf=0x7fffffffbf70, cmd=0x7d9d00 <ngx_http_reqstat_commands+224>, conf=0x84f2d8)
    at src/http/modules/ngx_http_reqstat_module.c:344
#1  0x000000000043593d in ngx_conf_handler (cf=0x7fffffffbf70, last=0) at src/core/ngx_conf_file.c:395
#2  0x00000000004354e9 in ngx_conf_parse (cf=0x7fffffffbf70, filename=0x0) at src/core/ngx_conf_file.c:251
#3  0x000000000046e2eb in ngx_http_core_location (cf=0x7fffffffbf70, cmd=0x7c2290 <ngx_http_core_commands+784>, dummy=0x841658)
    at src/http/ngx_http_core_module.c:3448
#4  0x000000000043593d in ngx_conf_handler (cf=0x7fffffffbf70, last=1) at src/core/ngx_conf_file.c:395
#5  0x00000000004354e9 in ngx_conf_parse (cf=0x7fffffffbf70, filename=0x0) at src/core/ngx_conf_file.c:251
#6  0x000000000046d9b9 in ngx_http_core_server (cf=0x7fffffffbf70, cmd=0x7c2060 <ngx_http_core_commands+224>, dummy=0x82c630)
    at src/http/ngx_http_core_module.c:3220
#7  0x000000000043593d in ngx_conf_handler (cf=0x7fffffffbf70, last=1) at src/core/ngx_conf_file.c:395
#8  0x00000000004354e9 in ngx_conf_parse (cf=0x7fffffffbf70, filename=0x0) at src/core/ngx_conf_file.c:251
#9  0x0000000000464591 in ngx_http_block (cf=0x7fffffffbf70, cmd=0x7c19e0 <ngx_http_commands>, conf=0x82b8a8) at src/http/ngx_http.c:250
#10 0x000000000043593d in ngx_conf_handler (cf=0x7fffffffbf70, last=1) at src/core/ngx_conf_file.c:395
#11 0x00000000004354e9 in ngx_conf_parse (cf=0x7fffffffbf70, filename=0x82aa18) at src/core/ngx_conf_file.c:251
#12 0x0000000000431be6 in ngx_init_cycle (old_cycle=0x7fffffffc0c0) at src/core/ngx_cycle.c:278
#13 0x0000000000416e88 in main (argc=2, argv=0x7fffffffc3b8) at src/core/nginx.c:350
(gdb) p rmcf->user_defined_str
$1 = (ngx_array_t *) 0x0
(gdb) p rmcf->user_defined_str->elts
Cannot access memory at address 0x0

Tested-by: Xiaochen Wang
Date: Wed Nov 30 14:17:24 CST 2016
git log:

commit 6452dd4d0f37257b074a89103aeef7ccc0a172b9
Author: Xiaochen Wang<EMAIL_ADDRESS>Date:   Wed Nov 30 12:07:17 2016 +0800

    reqstatus: fixed segmentation fault of req_status_show_field directive

    If req_status_show_field is enabled and req_status_zone_add_indicator is
    diabled, rmcf->user_defined_str will be NULL, then referring its "elts"
    field causes segmentation fault.

case result:

$ TEST_NGINX_BINARY=/home/xiaochen.wxc/work/github/tengine-xiaochen/objs/nginx prove -I /home/xiaochen.wxc/work/github/tengine-xiaochen/tests/nginx-tests/nginx-tests/lib tests/nginx-tests/cases/reqstat.t
tests/nginx-tests/cases/reqstat.t .. 242 at tests/nginx-tests/cases/reqstat.t line 165.
tests/nginx-tests/cases/reqstat.t .. ok
All tests successful.
Files=1, Tests=52, 44 wallclock secs ( 0.03 usr  0.00 sys +  2.29 cusr  0.16 csys =  2.48 CPU)
Result: PASS

Report-generated-by: http://wxc.oss.aliyuncs.com/ttest.sh


[SPARK-37508][SQL][DOCS][FOLLOW-UP] Update expression desc of CONTAINS() string function

What changes were proposed in this pull request?
Update usage doc of CONTAINS() string function to
_FUNC_(left, right) - Returns a boolean. The value is True if right is found inside left.
    Returns NULL if either input expression is NULL. Otherwise, returns False.

To clarify that when left and right expression both not NULL and if right is not found inside left, returns False
Why are the changes needed?
Make function description more clear
Does this PR introduce any user-facing change?
DESCRIBE FUNCTION EXTENDED contains's usage now return:
contains(left, right) - Returns a boolean. The value is True if right is found inside left.
    Returns NULL if either input expression is NULL. Otherwise, returns False.

How was this patch tested?
Verified it after documentation build or SQL command such s DESCRIBE FUNCTION EXTENDED contains.

ping @MaxGekk

Test build #145866 has started for PR 34786 at commit c79b4f4.

make it more clear

Please clarify that you're documenting when to return false.

Existed UT

Existing unittests don't cover this. You can simply say you verified it after documentation build or SQL command such s DESCRIBE FUNCTION EXTENDED contains.

Make function description more clear

Please describe why. e.g.) to guide users about when false is retured.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50341/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50341/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50341/

Test build #145866 has finished for PR 34786 at commit c79b4f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145866/

Test build #145903 has started for PR 34786 at commit 9733987.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50378/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50378/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50378/

Test build #145903 has finished for PR 34786 at commit 9733987.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145903/

im gonna just merge. the build failure is fixed in https://github.com/apache/spark/commit/f570d01c0d009bb035d3c89d77661a5432f982cb

Merged to master.


Hugo does not output filenames with '=' character

Hugo Version: v0.25.1
I have a content file called ./content/store/example-category/MR240-TP2=110.html with front matter like so:
{
   "title": "Big Long Example Title for MR240-TP2=110 in Example Category",
   "slug": "MR240-TP2=110",
   "type": "store",
   "layout": "item",
   "header": "store-item.header.html",
   "url": "/store/example-category/MR240-TP2=110/",
   "category": "Example Category",
   "catSlug": "example-category"
 }

When hugo generates the output folder, I see the following file ./output/store/example-category/MR240-TP2110 . Notice the absent '=' character. This is undesirable behaviour, AFAIK '=' is a permitted character in URIs.
Thanks for your help,
Schmorrison

@bep Any thoughts about this? Is this behaviour expected by hugo?
I have tried generating the pages with
preserveTaxonomyNames
RemovePathAccents

set in the config.toml in all possible combinations but haven't seen a change in the generated file names.
If this behaviour is expected, then I don't think it has been documented anywhere.
Thanks,
Schmorrison


PR to support for Edit & Chat endpoints?

Hey @PavelLaptev, I just tried the plugin and it works like a charm ✨
Would you be interested on an intial PR to support edit & chat completions? (gpt-4, gpt-4-32k, gpt-3.5-turbo)
It might represent a significant change on the code structure of the TextCompose, to support the different models, endpoints and fields (chat completions requires a role: "user" as pair, inside the prompt message).

Let me know before I get deeper in the rabbit hole!
Best,
Davo

Hi, @davo 👋 Thank you for your feedback 🙂
Of course, go ahead. If you have any ideas, improvements and even you can contribute, I will be happy to check your PR.
btw, "Edit" sandbox is already here. But might be I missunderstood.

Also, I am currently working with images generation/edit API in the "main" branch. So, things in the "images" domain may work odd if you decide to try it, sience it's not finished yet.


Is the icon of vs code changed again

VSCode Version: 1.37.0-insider (user setup) (34e0ed575230b5c8168289995d59edf274539631)
OS Version: Windows_NT x64 10.0.16299

Steps to Reproduce:

Open VS Code

same issue, but my vscode after downgraded to 1.36 via "Update available!"

Fixed by https://github.com/microsoft/vscode/commit/ef893f0cfe7d80bd695005cfea24d481a4722bb3


Support Lenovo G50-70

I like your project and want to have my laptop supported
it is Lenovo G50-70, I guess all the Lenovo G50 series are alike
and if possible some older thinkpads too.
Or is it working this way, stopping randomly at some rate just like Vantage because it stopped for me at 85%
Anyway, it would be great also to have the power mode supported for older laptops!
Thanks.

It is supported for battery mode but not power mode, if you need help I own the device.


Update crowall.py

Add support for Mac.

Firstly, thanks for your work. :heart:
And have you test it in your Mac?  If so, I will merge it as soon as possible.
Hearing from you, :cake:

Your welcome~
Yes, It works on my Mac. : )
here is the screenshot.

:+1:
Thanks for your working. :smile:


Registration confirmation email does not work

showed up during the workshop, user tried with Safari

Intrested to work on this can i?

Thank you for your kind offers, we have resolved this issue in the meantime.


chore: add RELEASE.md

Codecov Report
Patch coverage has no change and project coverage change: -2.57 :warning:

Comparison is base (c6706cc) 52.82% compared to head (d537884) 50.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   52.82%   50.26%   -2.57%
==========================================
  Files          69       69
  Lines        5077     5077
==========================================
- Hits         2682     2552     -130
- Misses       1817     1985     +168
+ Partials      578      540      -38

Flag
Coverage Δ

2.1.4
17.31% <ø> (-18.87%)
:arrow_down:

<IP_ADDRESS>
46.70% <ø> (ø)

2.2.2
?

2.3.3
17.47% <ø> (-18.87%)
:arrow_down:

<IP_ADDRESS>
47.37% <ø> (ø)

2.4.1
35.94% <ø> (-0.48%)
:arrow_down:

<IP_ADDRESS>
47.44% <ø> (ø)

<IP_ADDRESS>
47.44% <ø> (ø)

2.5.2
17.54% <ø> (-18.87%)
:arrow_down:

2.6.1
?

<IP_ADDRESS>
47.44% <ø> (ø)

2.7.2
17.54% <ø> (-18.87%)
:arrow_down:

<IP_ADDRESS>
?

2.8.3
17.54% <ø> (-18.87%)
:arrow_down:

<IP_ADDRESS>
48.98% <ø> (ø)

3.0.2
?

<IP_ADDRESS>
?

3.1.1
?

<IP_ADDRESS>
?

3.2.2
?

<IP_ADDRESS>
?

community
36.41% <ø> (-1.56%)
:arrow_down:

enterprise
48.98% <ø> (-2.60%)
:arrow_down:

enterprise-nightly
?

integration
50.26% <ø> (-2.57%)
:arrow_down:

nightly
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add level badge

Inlined the logo (saves a kb) and also made a light variant.
ref Level/deferred-leveldown#29

@ralphtheninja gh-pages was last updated 2 years ago, but master has a bunch more commits.. Is it safe to run npm run deploy?

To be honest, I have absolutely no idea.

OK.
I'll first build it locally, go over the commits, make sure everything works. And we can always rollback, it's just a static site.


Allow interpolating AbstractVector{<:AbstractVector}

if function (A::LinearInterpolation{<:AbstractVector{<:Number}})(t::Number) were generalized beyond <:Number to perhaps <:AbstractVector then

You could support e.g. Vector{SVector}
function (A::LinearInterpolation{<:AbstractMatrix{<:Number}})(t::Number) could be written in terms of a reinterpret/reshape and the previous definition. The package would have to come to depend on StaticArrays.jl, as far as I can tell, however.

And so on for the interpolation methods that only require vector space operations on the data.

It would be great to have some way of interpolating vector-valued time series, e.g.,
CubicInterpolation(t, u, dims=1)

if u is a matrix with time in the first dimension.

The Vector{SVector} case works after #78.

Fixed by #78


TAMAYA-277: Minor code clean-up from Sonar report

This makes some minor changes, based on the Sonar report.

I pushed this to my own fork, which results in a failed sonar analysis (as @peculater mentioned earlier). I can also close this and re-do the PR from the apache repo itself, if that would be better.

Can you do this apart from your fork? Would it change if we moved the Sonar analysis to the after-success-part? I guess not, right ....


uncaught type error

hello,
I'm getting this error and neither the thumbnail nor the video information are loaded
Uncaught TypeError: Cannot read property 'split' of undefined
at o (lazyframe.min.js:1)
at i (lazyframe.min.js:1)
at n (lazyframe.min.js:1)
at t (lazyframe.min.js:1)
at testconfiltros.php:987

nevermind, fixed it ... it was a dailymotion video causing disruption...


Proposal: Rewrite with untagged variants

Proposal
Rewriting the bindings by the polymorphic variant using the untagged variant in ReScript v11. e.g. https://github.com/rescript-react-native/rescript-react-navigation/blob/main/src/NativeStack.res#L9-L19
Benefit
Using variant versus polymorphic variant gives us more information at compile time, and is more idiomatic.

With all the new features regarding variants in ReScript 11, I agree that normal variants should be preferred over polymorphic variants for writing new bindings. This was also our philosophy in the new rescript-mui bindings where we make heavy use of untagged variants.
OTOH, for the case of rescript-react-navigation,

this would mean breaking changes with little visible benefits to the user
it is not just rescript-react-navigation but also rescript-react-native itself that currently prefers polymorphic variants, and we should probably remain consistent with it.


dhallPackages.Prelude: 13.0.0 -> 19.0.0

Motivation for this change
The current version of the Dhall prelude is quite a ways behind. Is there any reason not to update this as soon as new releases come out? If the prelude is too far ahead then the dhall package should fail to normalize the prelude during the build.
cc @Gabriel439
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ehmry: Yeah, it should be regularly updated.  Part of what I'm doing right now is building the infrastructure to make that easier (including the dhall-to-nixpkgs utility)


QA: FsRe: AddToStore with UID that already exists

EPIC:
#491 Fluids Report Implementation
PARENT:
#493 Add to Store (C) Fluids Report Object
SIZE:
4 hours = 1/2 day = 1 point
QA: Fluids Report: POST with UID that already exists – Size (1 pt)

Update: Duplicate Card. Closed.


huntr - Command Injection Fix

https://app.huntr.dev/users/69 has fixed a security vulnerability (Command Injection) :hammer:. 69 has been awarded $25 for fixing the vulnerability through the huntr bug bounty program :dollar:. Think you could fix a vulnerability like this? Get involved at https://huntr.dev/!Q | AVersion Affected | ALLBug Fix | YESOriginal Pull Request | https://github.com/418sec/ios-simulator/pull/2

Provided fix for https://github.com/macacajs/ios-simulator/issues/15! 🍰


Either indent or space, not both

First of all... thanks a lot for this. But could you let us choose weither to divide paragraphs inte EITHER space OR indentation. Both of these are typographically correct. But to use both of them at the same time is not. :) Could you put this logic into the library?

@Hambern thanks for using Typesettings. By default it will indent paragraphs that are siblings and set a negative margin top that is equal to the default margin bottom. This results in sibling paragraphs separated only by indent and allows other elements like images to be separated below body text by a rhythm based margin. Please take a look at the following CodePen.
CodePen Example:
http://codepen.io/ianrose/pen/RGgxPB
The SCSS Ruleset:
https://github.com/ianrose/typesettings/blob/master/_typesettings.scss#L321-L326
Let me know if this answers your question.


Failure to create secret when building Android on OSX in Unity Cloud Build

Thanks to the updates in 1.1.6 here https://github.com/natmlx/natml-unity/issues/55 I now see an error message when the build fails instead of simply crashing.
[error] [2023-05-11T23:59:41Z - Unity] 2023-05-11 16:59:41.853 Unity[9988:76191] NatML Error: Failed to create secret with status: -25300
[2023-05-11T23:59:42Z - Unity] 2023-05-11 16:59:41.959 Unity[9988:76191] NatML Error: Failed to create secret with error: Error Domain=NSOSStatusErrorDomain Code=-25308 "failed to generate asymmetric keypair" (errKCInteractionNotAllowed / errSecInteractionNotAllowed:  / Interaction is not allowed with the Security Server.) UserInfo={numberOfErrorsDeep=0, NSDescription=failed to generate asymmetric keypair}
[2023-05-11T23:59:42Z - Unity] Obtained 256 stack frames.
[2023-05-11T23:59:42Z - Unity] #0  0x007fff227aa0bd in SecKeyCopyPublicKey
[2023-05-11T23:59:42Z - Unity] #1  0x000001609204a2 in NMLModelConfigurationCreateSecret
[2023-05-11T23:59:42Z - Unity] #2  0x00000197f38818 in  (wrapper managed-to-native) NatML.Internal.NatML:CreateSecret (NatML.Internal.NatML/SecretCreationHandler,intptr) [{0x7f8562e1c0b8} + 0xa8]  (0x197f38770 0x197f388bd) [0x118926a80 - Unity Child Domain]

So far I've only seen this with Android builds running on OSX in the Unity Cloud Build environment. I haven't run enough builds on Windows to rule out a possible failure there as well, but I'm sure the error will be different if it occurs.
Assuming this is a build environment issue if you have any details on what could be the issue I'll bounce the issue over to Unity.

Gotten a similar report of this. Looking into it.

I have the same error when building AAB for Android using Unity Cloud. The APK builds fine but the AAB fails.
I am using Unity 2021.3.25f1 and building using a Windows OS with default sdk set as Android target sdk.

Just throwing my hat in the ring and saying I'm experiencing the same issue. Works fine with iOS- fails on Android. Also using OSX as build host.


QSIPrep should fail when missing critical files

Summary
We are processing a large database of multishell acquisitions.  Occasionally, the bvec/bval files did not transfer with the dataset. If QSIPrep runs on these files, it simply runs without termination. I recognize that this could addressed by due diligence checking, but it's more interesting despite a bids validator error and missing essential files, the processes don't terminate. My sys admin got a hold of me that these images ran for 24+ hours without terminating and also without getting beyond denoising the diffusion.
Additional details

QSIPrep version: 0.20.0

What were you trying to do? Preprocess a dataset that includes intermittent files that have missing bvec/bval files
What did you expect to happen? I would expect that if there are no bvec/bval files, either QSIPrep fails immediately or the anatomical pipeline runs and then terminates.
What actually happened? Anatomical runs but then PIDs stay active indefinitely.
Log file attached
QSIprep_log.txt

I like this idea a lot. I always use this flag when I run qsiprep. Should the flag to use the former default behavior be something like --continue-despite-errors?

I'd vote for keeping the name the same,
parser.add_argument('--stop-on-first-crash', action=argparse.BooleanOptionalAction, default=True)

This allows existing scripts to work with --stop-on-first-crash and also enables --no-stop-on-first-crash.


Make - dash not required for piping

The dash is frequently used in unix commands to refer to standard in/out . But it is really really easy to miss.
If at all possible, it would be great to default to standard in if no input argument is given for many of the functions.

Preliminary work with the counts function makes me think we can fix this by using:
default=click.open_file('-')

This uses click's open_file helper to open up standard in as the default input. According to the docs, this also autocloses the handle, so there aren't any negative side effects.
the full argument specification would be something like:
@click.argument('tokens', type=click.File('r'), default=click.open_file('-'))

With this in place, both - and non dash piping seems to work fine.
textkit text2words test_data/alice.txt | textkit count --limit 3

",",2418
the,1516
',1127

textkit text2words test_data/alice.txt | textkit count --limit 3 -

",",2418
the,1516
',1127

Please!  The dash annoys me. It feels more unixy to not require it, tbh.  Good idea!


DJMcMayhem: Blacklist fuk

DJMcMayhem requests the blacklist of the username fuk. See the Metasmoke search here and the Stack Exchange search here.

Superseded by #1802


winrm limitations

Not sure if this is a bug or something which has not yet been implemented yet. If the latter it should probably be documented.
I just tried to call a host.file(filename).exists against a windows machine and it failed when it tried to call uname which will obviously fail..
INFO:testinfra:RUN CommandResult(command=u'uname -s', exit_status=1, stdout=None, stderr="'uname' is not recognized as an internal or external command,\r\noperable program or batch file.\r\n")

Which methods are supported when using the winrm backend?

Hello, Indeed, for now the support on windows is limited to running commands with run(), check_output().
I think file module could work if someone write a windows compatible module.


ORC-395: Support ZSTD in C++ writer/reader

Support ZSTD block compression/decompression for C++ writer/reader. Test cases have been added to TestCompression.cc

@omalley @majetideepak Can you take a look at this? Thanks!

@wgtmac  I will take a look at this today. Do you know what is the current behavior on the Java side with this compression format?

@majetideepak There is a PR https://github.com/apache/orc/pull/268 from @xndai to support Java reader to decompress ZSTD. It uses aircompressor which has the java implementation of zstd decompressor while zstd compressor is not released yet. Combining that PR with this, we can confirm end-to-end functionality and consistency. Though hadoop 2.9.1 has added ZStandardCodec for both compressor and decompressor, we don't have enough incentive to leverage it because of its JNI implementation.

To provide some benchmark results, I did some tests on my laptop using TPC-H 1GB dataset and C++ tools csv-import and orc-scan were used with default configuration.
Writer CPU Time (unit: second)

name
zlib
zstd

customer
1.976
0.777

lineitem
50.754
19.990

nation
0.002
0.003

orders
11.054
4.895

part
1.893
0.771

partsupp
8.791
3.512

region
0.002
0.002

supplier
0.130
0.056

Reader CPU Time (unit: second)

name
zlib
zstd

customer
0.084
0.063

lineitem
2.263
2.094

nation
0.001
0.001

orders
0.454
0.340

part
0.071
0.061

partsupp
0.343
0.253

region
0.000
0.001

supplier
0.006
0.005

File Size (unit: byte)

name
zlib
zstd

customer
7494965
7670751

lineitem
162544602
178904712

nation
1760
1882

orders
34599561
38028670

part
4273944
4676560

partsupp
25766380
29498151

region
1026
1097

supplier
474099
478017

In total, ZSTD writer time has 148.6% saving and reader time has 14.4% saving. File size is 9.4% bigger for ZSTD. The result provides a basic idea of performance comparison between them. As we use default configuration (ZLIB default level is -1 and ZSTD is 3), it may be unfair because ZSTD has 22 levels while ZLIB has 9 in total. If we choose different levels or different datasets, the result can vary a lot and ZSTD can beat ZLIB on file sizes. Overall, ZSTD seems to be a good compression option.

@majetideepak I think it makes sense to use org.apache.hadoop.io.compress.ZStandardCodec so compression and decompression can work end to end. In the future, if we have a native java implementation of zstd, hopefully we can just update the hadoop library. I will find a time to update my PR. By the way, since this codec class is only available in the latest hadoop library, there might additional work involved to upgrade the library.

@xndai I am not very familiar with the Java side. Looking at the ZSTD support in parquet-mr, it looks like they only added the ZSTD support but skipped the tests. The parquet-mr library has not upgraded the hadoop library as well.
https://github.com/apache/parquet-mr/blob/9fa86cca1af7dabc21701247efd89f6085945bd2/pom.xml#L80
https://github.com/apache/parquet-mr/commit/132b2a8c553bdcfd445e88680beac6f225c50ac4#diff-6a038e86a0fc009909af954b3589cd95R159
Can we do something like that here?

@majetideepak From the links you provided, it looks like they only added the meta for ZSTD but not use it. Also, it uses hadoop 2.7.3 which does not have ZStandardCodec implementation yet.

@majetideepak Can you take a look at this again? Thanks!

I have created a PR to port this feature to the java side: https://github.com/apache/orc/pull/306. However, hadoop 2.9.0 (which is the first version has ZStandardCodec) is not built with zstd native support by default. So I cannot add any test inside to avoid test break and that's why parquet-mr skips its test as well. parquet-mr uses hadoop v2.7.3 because it uses reflection to create the codec. @majetideepak

@wgtmac  thanks for these changes! I will take a look at both patches by end of tomorrow.

@wgtmac @majetideepak please take a look at the latest patch and related comments. I have a memory management refactoring that's pending on this PR to be accepted. Thx.

@wgtmac, is there more work to be done on this JIRA? I see some comments from @xndai .

@majetideepak @wgtmac I only have one minor feedback. Other than that, change looks good to me.

@majetideepak @xndai  Sorry that I forgot to push the last change. Please check it again. Thanks!

LGTM. Thx!

Hi @majetideepak , do you have any other feedback? If not, I plan to commit this change. Thx.

+1 LGTM


Security enhancements

Adding encryption to messages to ensure the privacy of user data during message exchanges.

I will use the PyCryptodome library

Adding encryption to messages to ensure the privacy of user data during message exchanges.
I will use the PyCryptodome library

i was about to open this issue after the server issue ends so could you wait 2 more days ? I will notify you of it when it starts.

Adding encryption to messages to ensure the privacy of user data during message exchanges.
I will use the PyCryptodome library

i was about to open this issue after the server issue ends so could you wait 2 more days ? I will notify you of it when it starts.

Yes, I can wait, no problem! 😊


Chapter 7 - dep add step doesn't appear to work.

dep ensure -add<EMAIL_ADDRESS>results in the pictured errors so I'm stuck quite early.
Not sure if I'm being dumb and missing a step.
Also I don't know Go at all,  should I just skip the whole terratest thing or is there a "Enough Go to use Terratest" thing I can do ?
thank you !

Did you follow the exact steps in the book?

I think so ! I'll revisit in case I didn't but I rechecked it after issues. Am usually decent at following steps.
But I guess the separate question of how much Go I need to understand applies. Like if I get this working will I still struggle ?

okay this time it hung for ages and then seemed to do the thing
Not sure why it's saying that message RE importing in the project though. seems ok


[Blocked] Upgrade pulsar-client to meet compliance

Signed-off-by: Shubham Sharma<EMAIL_ADDRESS>Waiting for apache team to backport the changes to v0.8.0. If the backport is not done before our v1.7 release, we will go ahead with this PR which points to the commit that fixes the license issue https://github.com/apache/pulsar-client-go/pull/735
Description
Per reference issue, updating pulsar client to a compliant version - https://github.com/apache/pulsar-client-go/pull/735
go get github.com/apache/pulsar-client-go@128d8ea3e24035a49fc81a516b01bc57b654a64a
make modtidy-all

Issue reference
Please reference the issue this PR will close: #1479
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
(NA) Created/updated tests
(NA) Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@shubham1172 seem this is going to be in v0.8.1 -- https://github.com/apache/pulsar-client-go/tree/v0.8.1-candidate-1

Yes @berndverst, we are waiting for them to release the v0.8.1 version. I have added more details on the linked issue.


photo-display post type: no #bigimg on small screens

big img div should not be displayed on small screens.

done


Make DYNAMIC_CRC_TABLE configurable in CMake

Actually it looks like this DYNAMIC_CRC_TABLE define no longer works correctly.

I am not sure that is something we want to support either, is there any reason to except for saving flash space in embedded?

We used to use it at work to keep down executable size. But there are some benefits to not using it, namely you don't have to worry about calling initialization function to create the tables. I would be in favor of removing what is left of it (since it is broken now). Also having a separate tool that generates the crc tables  (makecrct) makes for nice separation of code.

Yeah, lets remove it. The code is complex enough without having complexity that is not really needed.


Warnings with terraform v0.12.20

Warning: Interpolation-only expressions are deprecated

  on .terraform/modules/lambda-scheduler-stop-start/diodonfrost-terraform-aws-lambda-scheduler-stop-start-61fcfa4/main.tf line 39, in resource "aws_iam_role_policy" "schedule_autoscaling":
  39:   role = "${aws_iam_role.scheduler_lambda.id}"

Terraform 0.11 and earlier required all non-constant expressions to be
provided via interpolation syntax, but this pattern is now deprecated. To
silence this warning, remove the "${ sequence from the start and the }"
sequence from the end of this expression, leaving just the inner expression.

Template interpolation syntax is still used to construct strings from
expressions when the template includes multiple interpolation sequences or a
mixture of literal strings and interpolations. This deprecation applies only
to templates that consist entirely of a single interpolation sequence.

(and 11 more similar warnings elsewhere)

Warning: Quoted type constraints are deprecated

  on .terraform/modules/lambda-scheduler-stop-start/diodonfrost-terraform-aws-lambda-scheduler-stop-start-61fcfa4/variables.tf line 21, in variable "resources_tag":
  21:   type        = "map"

Terraform 0.11 and earlier required type constraints to be given in quotes,
but that form is now deprecated and will be removed in a future version of
Terraform. To silence this warning, remove the quotes around "map" and write
map(string) instead to explicitly indicate that the map elements are strings.

------------------------------------------------------------------------

Note: You didn't specify an "-out" parameter to save this plan, so Terraform
can't guarantee that exactly these actions will be performed if
"terraform apply" is subsequently run.

Hello,
These issues were fixed during the migration to Terraform 0.12 in version 2.0.0 of this module.


Can't login Google

The next button in Google Sign in page simply doesn't work, no matter if you:

click Next button by mouse
press Enter key in the Email or phone input box
press Tab key until Next button is focused, then press Enter key or Space key

I am also having this issue on a mac running 10.11.6

I was having the problem on macOS 10.11. Recently updated to macOS 10.14 and today login is working (App crash when starts, have to performed the instruction according to https://github.com/radiant-player/radiant-player-mac/issues/668#issuecomment-443803030)

Ive got the same issue.
I must admit though that I am still on Yosemite and for me, upgrading to a newer version of macOS isnt an option. The only newer officially supported Version for my beloved cranky old 2009 Macbook Pro is El Capitan, so not much to be gained there anyway.
;)
That said, any workaround or bugfix for older Verions of macOS would greatly be appreciated! :)

Radiant is not currently maintained, see https://github.com/radiant-player/radiant-player-mac/issues/675#issuecomment-472638065 for more context.


use {= version} constraints for packages

i find this much easier than to rethink when we need to bump versions, and in practise, I'm only really willing to support one version across the repository.

any opinion on this? @haesbaert @yomimono

Does this version get auomatically substituted by dune-release or something? I'm failing to find links on this syntax quickly because version isn't the best search string.

@yomimono it's in opam (2.0 i assume): https://opam.ocaml.org/doc/Manual.html#pkgvar-version

Ah, OK - I was looking at a different bit of packaging documentation and missed this entirely; thanks for the pointer.  In that case this seems fine, I'll merge it.


fix the issue of readme in cosmos service

Fix the issue #19471 of readme in cosmos service.

@kushagraThapar  - This link http://www.slf4j.org/ caused this error, because the link is not a secure link. However I found this link in other service.

Can we delete this link or change it to a secure link( however I can not fiind other secure link.)

@Melanie-Ma - there is no other secure link for SLF4j, I would rather not have any link for SLF4j, and just keep it as it was originally. Other Java and maven links are good, so let's keep them, but revert the slf4j link.

@kushagraThapar - Done

@kushagraThapar - Done

Thanks @Melanie-Ma - I will merge the PR now.


Docker not working after upgrade to 1.5.2

I have RancherOS running on bare metal.
I ran the upgrade to 1.5.2, it upgraded ok and prompted me to reboot. It started rebooting, was disconnected from ssh but it never reboot correctly. So I went and rebooted the machine manually.
After rebooting docker wasn't working. By that I mean no docker containers seem to be running and docker ps doesn't show anything and never returns, I have to hit CTRL+C to be able to do anything.

[rancher@rancher ~]$ docker ps
^C
[rancher@rancher ~]$ sudo system-docker logs docker
time="2019-06-01T12:04:57Z" level=info msg="Starting Docker in context: console"
time="2019-06-01T12:04:57Z" level=info msg="Getting PID for service: console"
time="2019-06-01T12:04:57Z" level=info msg="console PID 758"
time="2019-06-01T12:04:57Z" level=info msg="[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOSTNAME=rancher HOME=/]"
time="2019-06-01T12:04:57Z" level=info msg="Running [system-docker-runc exec -- 16a8d34efe3416a7545299bafd8ee8725384edbb80c33204105a8720c5639631 env PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOSTNAME=rancher HOME=/ ros docker-init --log-opt max-file=2  --log-opt max-size=25m --group docker --host unix:///var/run/docker.sock]"
time="2019-06-01T12:04:57Z" level=info msg="Found /usr/bin/dockerd"

Running docker-18.06.3-ce.
If I change the docker engine at runtime I get this:
[rancher@rancher log]$ sudo ros engine switch docker-18.06.2-ce
INFO[0011] Project [os]: Starting project
INFO[0011] [0/20] [docker]: Starting
Pulling docker (docker.io/rancher/os-docker:18.06.2)...
18.06.2: Pulling from rancher/os-docker
4b91cfc73f66: Pull complete
Digest: sha256:8883a26e0a3bbcc47fab6d39daa1a3f542715ff64681e9b9702555b0f8ae1a58
Status: Downloaded newer image for rancher/os-docker:18.06.2
INFO[0018] Recreating docker
INFO[0019] [1/20] [docker]: Started
INFO[0019] Project [os]: Project started
[rancher@rancher log]$ docker ps
Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.38/containers/json: dial unix /var/run/docker.sock: connect: permission denied

Duplicate of #2484
See this comment https://github.com/rancher/os/issues/2484#issuecomment-445088750

I tried a fresh install, I cannot reproduce.
Can you provide more steps?
Which console? Which version did you upgrade from?

I think I had 1.5.1 before. Which console? Bash?
I'm not saying it happens to everybody, but I would like to know how I can get docker working again.

Please check this file  /var/log/docker.log, maybe you can find the reason.

I'm guessing one or some of the containers got corrupted because after I removed the containers it works fine.


TextImageDataset bottlenecks

The init method
The init method is quite fast - but when dealing with more than 100k image-text pairs, it can take quite awhile.
These few lines result in full scans over the length of both the image_files list and the text_files list a couple of times:
        path = Path(folder)

        text_files = [*path.glob('**/*.txt')]
        image_files = [
            *path.glob('**/*.png'), *path.glob('**/*.jpg'),
            *path.glob('**/*.jpeg'), *path.glob('**/*.bmp')
        ]

        text_files = {text_file.stem: text_file for text_file in text_files} # full scan
        image_files = {image_file.stem: image_file for image_file in image_files} # full scan
        keys = (image_files.keys() & text_files.keys()) # Probably okay
        self.keys = list(keys)
        self.text_files = {k: v for k, v in text_files.items() if k in keys} # Full scan
        self.image_files = {k: v for k, v in image_files.items() if k in keys}  # Full scan

Is there any way to speed this up? Or at least give the user an option to cache the lists into a file for resuming?
Smaller optimizations
Other parts of the data loader may bottleneck on slower configurations (although it hasn't been an issue really):
If the user isn't shuffling, and doesn't mind a Dataloader with less "variety" in it, you can actually cache the "sequential_sample" method like so -
# loader.py
from functools import lru_cache
# ...
    @lru_cache(maxsize=None)
    def sequential_sample(self, ind):
        if ind >= self.__len__() - 1:
            return self.__getitem__(0)
        return self.__getitem__(ind + 1)

This way, you only load the tensors for the text and image once on your first epoch.
This will however eliminate any "side effects" used in the method. As such, the value randomly chosen for your "resize_ratio" will remain the same for that tensor during each epoch.
If you were really crazy, and wanted to lose even more variety in your dataset, you could do something similar to the skip_sample() method and turn on shuffling. This has the added benefit (?) of caching the corrupted indices of your dataloader and returning another (cached) image-text-pair in your dataset instead. You can raise/lower your maxsize to increase/decrease the amount of cache hits/misses and therefore the frequency of side effects - which could be tinkered with to find a good value which helps your loss and the bottleneck.
    @lru_cache(maxsize=4096)
    def skip_sample(self, ind):
        if self.shuffle:
            return self.random_sample()
        return self.sequential_sample(ind=ind)

I hope this is already happening in the background via either Python or torch.Dataset. One thing that couldn't possibly hurt however, would be to add an lru_cache(maxsize=1) to the __len__() method.
    @lru_cache(maxsize=1)
    def __len__(self):
        return len(self.keys)

Maybe we should convert our datasets to tar.gz and work with WebDatasetloaders? This might be a faster approach than optimizing reading text and image folders, doesn't it? But cool anyway to get some extra speed of the current approach! (Y)

Maybe we should convert our datasets to tar.gz and work with WebDatasetloaders? This might be a faster approach than optimizing reading text and image folders, doesn't it? But cool anyway to get some extra speed of the current approach! (Y)

I agree. WebDataset is perfect for our usecase.

Added early beta support for WebDatasets:
https://github.com/lucidrains/DALLE-pytorch/pull/280

Added early beta support for WebDatasets:
#280

Added full support for WebDatasets: https://github.com/lucidrains/DALLE-pytorch/pull/280
Anyone wants to try the new feature out or review the changes?