Visualization error

Hi,
I have some problems with the figures. Every time i try to generate a plot, the numbers (e.g., p-values) are not complete. This occurs not only with this module-trait heatmap, also whith the heatmap of two-objects comparison. Do you have any idea of why this is occurring?
This is an example;

Hi @gerapskx
Which version of pyWGCNA are you using? Does this also happen with a provided example?
Also if you saved the plot, would you be able to see the complete plot?

Hi @gerapskx
Which version of pyWGCNA are you using? Does this also happen with a provided example? Also if you saved the plot, would you be able to see the complete plot?

I am using 2.0.4,
Actually it started to happen recently, (possible three-two weeks ago)
If i save the plot, still shows like my example

hmm...
Do you mean it worked before and suddenly without any changes such as updating packages, you encountered this?

hmm... Do you mean it worked before and suddenly without any changes such as updating packages, you encountered this?

Yes.

I'm not sure if that's something related to PyWGCNA and unfortunately, I'm unable to reproduce your error.
one thing to check is to plot it separately with values stored at AS_OE.moduleTraitCor and AS_OE.moduleTraitPvalue using sns.heatmap().
It might be something related to your Seaborn package or its dependencies. I found this issue maybe you had the same thing??

I'm not sure if that's something related to PyWGCNA and unfortunately, I'm unable to reproduce your error.
one thing to check is to plot it separately with values stored at AS_OE.moduleTraitCor and AS_OE.moduleTraitPvalue using sns.heatmap().
It might be something related to your Seaborn package or its dependencies. I found this issue maybe you had the same thing??

I just did the same but for the seaborn package, now it is working. Thank you so much!


Debugging messages in production

The following code lies on lines 636 to 638
  console.log(height);
  console.log(windowHeight);
  console.log(widgetHeight);

and outputs in production.

removed.
Was actually checking the original code, as there were some issues. Missed though :)


Prevent docking windows (shelf and clipboard) from showing on launch

On my system, the value for hidden was being toggled every time Quicksilver shut down.
I noticed that there wasn’t necessarily an explicit value for (BOOL)hidden, but there are several places where behavior is determined by its value.
If hidden is initially YES, the plug-ins will still show the window based on the saved state, so this doesn’t break the state-preserving behavior. If it’s initially undefined, then it evaluates to NO (and the plug-ins do nothing to override that), which is what caused the problem.

Does this also let you dock the window, or is that still broken?

Does this also let you dock the window, or is that still broken?

That one’s still a mystery. Doesn’t work in a clean account either. Could it be hardware somehow? No hurry as I won’t be able to look at it for a while, but would you mind sending me a diff of your Quicksilver preferences with the Shelf docked and undocked?

That ones still a mystery. Doesnt work in a clean account either. Could
it be hardware somehow? No hurry as I wont be able to look at it for a
while, but would you mind sending me a diff of your Quicksilver preferences
with the Shelf docked and undocked?

Can do, but not right now either.
I remember we discussed the possibility of it being something to do with 2
screens. Have you tried with just one? But to be fair, I often use 2 and it
works for me. Are you on a desktop?
On 10 February 2012 18:26, Rob McBroom <
<EMAIL_ADDRESS>
wrote:

Does this also let you dock the window, or is that still broken?

That ones still a mystery. Doesnt work in a clean account either. Could
it be hardware somehow? No hurry as I wont be able to look at it for a
while, but would you mind sending me a diff of your Quicksilver preferences
with the Shelf docked and undocked?

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/692#issuecomment-3911614

This causes docked windows to always display on startup, not good :(

This causes docked windows to always display on startup, not good :(

Well, I couldn’t possibly have tested that. :-) So I guess this’ll have to wait until 66. I’ll open a separate issue on the docking business when I get a chance to describe my latest findings. It could turn into a lengthy discussion and it’s not central to this pull request.

So I guess thisll have to wait until 66.

Seeing as how this doesn't work for me... I guess so!
I'll release 65 pre tomorrow if you don;t get in before me ;)
On 10 February 2012 19:59, Rob McBroom <
<EMAIL_ADDRESS>
wrote:

This causes docked windows to always display on startup, not good :(

Well, I couldnt possibly have tested that. :-) So I guess thisll have to
wait until 66. Ill open a separate issue on the docking business when I
get a chance to describe my latest findings. It could turn into a lengthy
discussion and its not central to this pull request.

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/692#issuecomment-3913280

I had to add the canFade check into saveVisibilityState. It's all
pretty complicated...
See my comment here: https://github.com/quicksilver/Shelf-qsplugin/pull/3
"The fix: On quit, we need to check if the shelf window is visible (using
hidden). If not, then we need to check if itcanFade - i.e. it's docked.
Apparently a docked shelf window is visible according to the OS, but the
hidden method doesn't say so that it's visible. i.e. when the window is
docked, canFade returns yes but hidden returns NO, but even though the
window isn't ACTUALLY hidden (it's peeping out from the side of your
window)
Confusing :)"
On 13 February 2012 14:55, Rob McBroom <
<EMAIL_ADDRESS>
wrote:

Is it canFade that tells it whether or not the thing is docked? Maybe
thats whats causing the setting to get saved incorrectly for you (causing
the window to always show). With my change here merged in, I wonder if the
check for canFade in the plug-ins saveVisibilityState: is even
necessary. Can you try removing it?

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/692#issuecomment-3941083

Confusing for sure. It seems like there are two things we care about: Is the window open? Is the window docked? (which means open but not showing)
But the setting only stores one value, and that value answers yet a third question: Should I show the window on start up?
Correct me if I’m wrong, but if the stored setting is NO, the window will not be restored at all. If the setting is YES, the window will be both open and shown on screen (whether it was docked or not). It sounds like what you’re expecting it to do is open the window, but don’t show it (keep it off screen).
Still confused, but I think the correct solution is for the plug-ins to test canFade on start-up, not on shut down. In other words, they need two values to determine correct start-up behavior, but the plist only stores one. I’ll do some testing here to confirm.

Still think I’m on the right track, but still confused. The plug-in either calls showClipboardHidden:, causing the panel to display, or it doesn’t. There is no third “open it but keep it hidden off screen” behavior to choose from, so how did this ever work?
Does the showClipboardHidden: behave differently based on sender? And is the difference determined by the default value of (BOOL)hidden which I have attempted to change? That’s the only thing I can think of.
Sorry to bug you with so much of this. It seems that in order to get the sliding dock behavior, I have to hit ⌘L and resize the panel after every launch. (This is the case with B64 as well, so it wasn’t this change.) So I’m unable to test whether a docked panel gets restored correctly on launch with different settings since it never gets restored correctly under any circumstances. :-)

QS decides whether or not the window is docked or not (canFade) based on whether the window's rect overlaps the screen rect. I think this is where the bug comes in with multiple screens.
be
I think so, too.
@skurfer can you debug the canFade method and figure out what [[self screen] frame] returns when you have two displays and when you have only one?
Btw. how are your two screens set up and where do you try to dock the window?

Crap. I posted a long reply here yesterday and it’s not here. Trying again.
I think I know why you didn’t know about this bug. If I dock the panel, it never shows on startup. Using a build without this change, try moving one of your panels so it floats. Close it, then restart a few times. Does it appear on every other launch? Or just run defaults read com.blacktree.Quicksilver QSPasteboardHistoryIsVisible and watch it flip on and off. :-)
Skipping a lot of detail, but I was right about being able to fix Patrick’s complaint by altering the plug-in to determine startup behavior at startup instead of at shutdown, but there’s still a problem. Now docked windows don’t work on startup.
I think in order to work, they need to be opened then immediately hidden. This change prevents them from being hidden, as Patrick pointed out. (The first line of hide: says if (hidden) return;.) My change to the plug-in (to address that problem) prevents them from opening at all. So I’m now thinking this can be fixed without altering the plug-ins, so I’ll look into it and send the commits when I’ve figured it out.

can you debug the canFade method and figure out what [[self screen] frame] returns when you have two displays and when you have only one?

See #696 - I think multiple displays have been eliminated as a problem. Like I said on that issue, I can get some limited docking to work, and in that case, canFade returns the correct value.

Figured out the problem in my head while I was at lunch (but not the solution yet).
On launch, hidden is undefined, so for practical purposes, it’s NO.
If the preference to show the panel on startup is YES, the panel’s hide: method gets (indirectly) called, which sets hidden = YES. On shutdown, if hidden == YES, the preference is written as NO.
If the preference to show the panel on startup is NO, the panel’s hide: method is never called, leaving hidden as it’s default value of NO. On shutdown, if hidden == NO, the preference is written as YES.
So it flips every time the application runs.


[anaconda] - werkzeug - GHSA-f9vj-2wh5-fj8j - patch to remove vuln - v3.0.3 to v3.0.6

Dev Container Name

Anaconda

Package Name

Werkzeug

Changelog

changed pinned version earlier from v3.0.3 to v3.0.6 in apply_security_patches.sh
updated tests to verify that new image contains updated v3.0.6 for werkzeug

Checklist

[x] Checked that applied changes work as expected

Updated the werkzeug library version to the latest stable version 3.1.3

@brettcannon relative

Sorry, but I don't understand whey I was looped in on this as the link provided points back to this PR.


Allow to set using SSL in http config

Allow to set using SSL in sails.config.http.serverOptions

I need this because I use my serverOptions tu support SNI with the SNICallback and I do
var serverOptions = {
  SNICallback: function (domain, cb) {
    console.log("SNICallback from domain:", domain);
    MultisiteService.getCurrentSiteConfig(domain, function (err, siteConf) {
      if(err) return cb(err);
      var dirname = MultisiteService.getSitePathFromSiteConf(siteConf);
      var ca_path = path.join(dirname, siteConf.ssl.ca);
      var key_path = path.join(dirname, siteConf.ssl.key);
      var cert_path = path.join(dirname, siteConf.ssl.cert);

      sails.log.debug(dirname, ca_path ,key_path, cert_path);

      var ctx = tls.createSecureContext({
        ca: fs.readFileSync(ca_path),
        key: fs.readFileSync(key_path),
        cert: fs.readFileSync(cert_path),
        passphrase: siteConf.ssl.passphrase
      });

      cb(null, ctx);

    });
  }
};

And I do not neet to set key and cert in my local.js, but I can work it around with just set them to true.

@JumpLink just to be clear, are you saying the current workaround for your issue is to set sails.config.ssl.key and sails.config.ssl.cert to true?  Because I'd almost rather just document that than add a new usingSSL config that would be a little confusing to document...

Yes this is true, take a look at my config/local.js as an example.
This is necessary, because sails checks if this variables are set:
var usingSSL = sails.config.ssl.key && sails.config.ssl.cert;
This is the only way I can use my custom 'serverOptions' with ssl, see config/http.js
If you do not need your own server options, this is not necessary.
My patch would fix this problem as you can activate ssl with serverOptions.usingSSL = true;.

@JumpLink, ended up simplifying this a bit by allowing you to just set sails.config.ssl to true: https://github.com/balderdashy/sails/commit/23e4d4df1293e00d63b2c46f1a1b87d77631c4e1#diff-b6a9d24b106300f5b5fda5b3eb4d093aR34
Also added some tests for https.  Thanks for the PR though!


Prep v1.15.0 release

Prepare an operator release.

Note: I rebased on top of https://github.com/pulumi/pulumi-kubernetes-operator/pull/559 to pull in the changelog entry update. Thanks for submitting this!


Severe color deviation in Windows 11

I'm not sure if this is a bug, or rather a problem with my configuration. I tried using the light theme in my daily use of the Windows system and found a significant deviation from the displayed rendering. I don't think this is a problem with my computer. I tried using another brand new Windows 11 computer and it also showed the same color deviation, but when I tried using the Ubuntu system, I didn't encounter this problem. The effect is as follows:
In the Windows environment

In the Ubuntu environment

I really like this theme and hope it can help me solve this problem or provide possible solutions

System: Windows 11
VSCode version：1.90.2
Vitesse Theme：0.8.0

I don't know - and honestly there is nothing I can help - this repo is just a bunch of hex colors - we can't define how they are rendered. Issue tracker is for tracking bugs not for questions, btw.

Thank you very much for your answer! Also sorry, I don't seem to know enough about elegantly asking questions, I'll go back and learn, thanks again!

I don't know - and honestly there is nothing I can help - this repo is just a bunch of hex colors - we can't define how they are rendered. Issue tracker is for tracking bugs not for questions, btw.


Switch to new image registry

s/registry.svc.ci.openshift.org/registry.ci.openshift.org/
/cc @sttts

/retest

/retest

/lgtm
/approve

/hold
Checking with ART to see if the change would be best be automated.


Update guide-view.js

Description of the Change

Change git icon in welcome guide to the one from the status bar

Release Notes

Change welcome guide

Hey @CynicallDude, thanks for the contribution!
Could you please check the linter error.
As a nice to have, you could include screenshots for the icon change (current and the new).

@lkashef I have no clue why is there linter error. By the way, down below the screenshot.

You could look into the error from the CI:

I am not 100% but it looks like you need to add a trailing space or line-break after the line you added.
After you fix the linting problem, It's best to run ./script/lint on your local machine, instead of waiting for the whole CI process to verify it's fixed.


Performance bottleneck

Hi,
Thank you for the awesome infinit-tree library. When I try to load 80k+ nodes under a single node, this line incredibly slows down the loading :
https://github.com/cheton/flattree/blob/6b0f5163f647014cb232f615c6427f6caa0817b9/src/flatten.js#L123
I think you can change this line with a less expensive check :
if(index === current.children.length-1)
I gained 1.4 seconds with this. Can you confirm that I didn't break something ? It seems to me that the original check does a long roundtrip to just do that simple check.
Thank you,
Yassine

That's a good point. This change will definitely reduce the time for searching the array for the specified node. Thank you for the finding.

Thank you.

Just published 0.11.1 to address the performance issue.


npx breaks on NPM v7

In npm 7, the 'npx' command has been changed to use 'npm exec' under the hood.
reference: https://github.blog/2021-02-02-npm-7-is-now-generally-available/

More specifically:

https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/
https://blog.npmjs.org/post/626173315965468672/npm-v7-series-beta-release-and-semver-major

But, what does it break in porter? A breaking change doesn't break anything in itself if you didn't make use of it, so it's always something else that breaks.


hotfix/restrooms2

This change is

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 11 unresolved discussions.

byuSuite/Apps/DepartmentDirectory/controller/DepartmentDirectoryListingViewController.m, line 215 at r1 (raw file):

            CampusBuildingsMapViewController *vc = [[CampusBuildingsMapViewController alloc] initWithNibName:BUILDINGS_MAP_VIEW_NIB_NAME bundle:nil];

            //TODO: self.listing.building is the building acronym and doesn't need to be parsed from self.listing.location

Remove TODO and solve it

byuSuite/Apps/MapMyClasses/controller/MapMyClassesViewController.m, line 297 at r1 (raw file):

            [self.map zoomToFitMapAnnotationsWithUserLocation:YES];
        } else {
            [self setMapZoomForiPad:self.map];

Is there a difference on iPad

byuSuite/Apps/MapMyClasses/controller/MapMyClassesViewController.m, line 337 at r1 (raw file):

        }

        if (buildingFound) {

It looks like we remove this part... Is there a reason we don't need it?

byuSuite/Apps/RestroomLocator/RestroomLocator.storyboard, line 1 at r1 (raw file):

<?xml version="1.0" encoding="UTF-8"?>

Rename this to Restrooms.storyboard

byuSuite/Apps/RestroomLocator/RestroomLocatorBuildingSelectionViewController.h, line 16 at r1 (raw file):

@protocol ByuRestroomBuildingSelectionDelegate <NSObject>

- (void) updateSelectedBuilding:(CampusBuilding*) building;

Add space after CampusBuilding

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 87 at r1 (raw file):

        //user has authorized feature to use location services
        [self.locationManager startUpdatingLocation];
        [self loadClosestBuildingToUserLocation];

Is this a duplicate of above? Are we loading twice?

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 104 at r1 (raw file):

- (void)createRestroomsSucceeded:(ByuRestrooms *)restrooms
{
    self.successfulCallbackCounter++;

I think we can do this without a counter. Just check to see if both are loaded in the loadDataIfReady

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 121 at r1 (raw file):

//Called in four different places in the code, but really only ever called once when the view loads.
//It shows up so many times in this file to ensure all prerequisite data has been loaded prior to this function call.

Is this comment still true even though you changed the loading logic?

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 219 at r1 (raw file):

-(void)configureLocationManager {
    self.locationManager = [[CLLocationManager alloc] init];
    self.locationManager.delegate = self;

Do we need to be a delegate and start updating location? Or can we just requestWhenInUseAuth?

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 265 at r1 (raw file):

-(void)loadDataIfReady {
    //decrement for each successful callback that has been recieved
    if (--self.successfulCallbackCounter == 0) {

Instead of using a counter here, just check if both objects are non-nil

byuSuite/Classes/ReusableClients/CampusLocations/CampusLocationsHelper.m, line 35 at r1 (raw file):

                    //obj has the function

                    /*

So did we decide that IMP was the best way to go? For some reason I thought we were leaning the other way...
By the way the comment looks great! :p

Comments from Reviewable

Review status: 11 of 12 files reviewed at latest revision, 11 unresolved discussions.

byuSuite/Apps/MapMyClasses/controller/MapMyClassesViewController.m, line 297 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Is there a difference on iPad

The deltas, or zoom, for iPad are larger than for the iPhone and the setMapZoomForIpad: changes deltas to look the best depending on whether it's landscape or portrait mode. -zoomToFitMapAnnotationsWithUserLocation: just shows BYU campus with no specific level for zoom, just whatever fits best.

byuSuite/Apps/MapMyClasses/controller/MapMyClassesViewController.m, line 337 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> It looks like we remove this part... Is there a reason we don't need it?

I'm not sure what part you're talking about, the -loadData? Line 342 is just an empty line

byuSuite/Apps/RestroomLocator/RestroomLocator.storyboard, line 1 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Rename this to Restrooms.storyboard

Will do after this code review

byuSuite/Apps/RestroomLocator/RestroomLocatorBuildingSelectionViewController.h, line 16 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Add space after CampusBuilding

I haven't formatted anything yet, so you could see the changes as clearly as possible, but I definitely will after this code review

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 87 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Is this a duplicate of above? Are we loading twice?

Nope. -loadClosestBuildingToUserLocation checks if self.buildingWithRestrooms has been loaded or not. If it hasn't yet, then the method does nothing. The first time -locationManager:didChangeAuthorizationStatus: is called, self.buildingsWithRestrooms usually hasn't been loaded yet and so it won't do anything. The main reason -loadClosestBuildingToUserLocation is in -locationManager:didChangeAuthorizationStatus: is because if the user turns off location services and then turns it back on, -locationManager:didChangeAuthorizationStatus: will be triggered and the user could be in a new location, so I figured we could find the closest building with restrooms to them.

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 104 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> I think we can do this without a counter. Just check to see if both are loaded in the loadDataIfReady

Done.

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 121 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Is this comment still true even though you changed the loading logic?

It shows up three times in the file. It gets called once if the user doesn't change their location services authorization. Whenever the authorization changes, it will get called. Would you like me to scrap the comment?

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 219 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Do we need to be a delegate and start updating location? Or can we just requestWhenInUseAuth?

I believe we do need to be a delegate, because in order to show the closest building with restrooms to the user, we need the user's location, which means we need to be a delegate and get their location. Once we get the user's location, we stop updating their location. This logic is in -locationManager:didUpdateLocations: and explained in the comment above it

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 265 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Instead of using a counter here, just check if both objects are non-nil

Done.

byuSuite/Classes/ReusableClients/CampusLocations/CampusLocationsHelper.m, line 35 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> So did we decide that IMP was the best way to go? For some reason I thought we were leaning the other way...
>
> By the way the comment looks great! :p

Yes we decided IMP was the way to go. If you'll allow suppressing a warning then we can do that instead. It's easier to tell what's going on when the warning is being suppressed. I'm honestly not sure which is the best way to go. They both "suppress" the warning

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

byuSuite/Apps/MapMyClasses/controller/MapMyClassesViewController.m, line 297 at r1 (raw file):
Previously, nateyj (Nathan Johnson) wrote…
> The deltas, or zoom, for iPad are larger than for the iPhone and the setMapZoomForIpad: changes deltas to look the best depending on whether it's landscape or portrait mode. -zoomToFitMapAnnotationsWithUserLocation: just shows BYU campus with no specific level for zoom, just whatever fits best.

Let's test it and possibly get rid of it

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 121 at r1 (raw file):
Previously, nateyj (Nathan Johnson) wrote…
> It shows up three times in the file. It gets called once if the user doesn't change their location services authorization. Whenever the authorization changes, it will get called. Would you like me to scrap the comment?

I think so. Unless there's any info in it to explain how to use it. I think the number of times it's called the programmer can figure out on their own

byuSuite/Classes/ReusableClients/CampusLocations/CampusLocationsHelper.m, line 35 at r1 (raw file):
Previously, nateyj (Nathan Johnson) wrote…
> Yes we decided IMP was the way to go. If you'll allow suppressing a warning then we can do that instead. It's easier to tell what's going on when the warning is being suppressed. I'm honestly not sure which is the best way to go. They both "suppress" the warning

Let's use the suppress warning. Sorry. :-/

Comments from Reviewable

Review status: 5 of 11 files reviewed at latest revision, 5 unresolved discussions.

byuSuite/Apps/MapMyClasses/controller/MapMyClassesViewController.m, line 297 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Let's test it and possibly get rid of it

got rid of it

byuSuite/Apps/RestroomLocator/RestroomLocatorRootViewController.m, line 121 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> I think so. Unless there's any info in it to explain how to use it. I think the number of times it's called the programmer can figure out on their own

Done.

byuSuite/Classes/ReusableClients/CampusLocations/CampusLocationsHelper.m, line 35 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Let's use the suppress warning. Sorry. :-/

Done.

byuSuite/Apps/DepartmentDirectory/controller/DepartmentDirectoryListingViewController.m, line 215 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
> Remove TODO and solve it

Done.

Comments from Reviewable

Reviewed 7 of 7 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Regen for update modelerv4 version

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Enhancements to CreationView

Make git password and username not required
Add checkbox 'is repository public or private' (and make user/password requried for private)
'Test connection' button that tries to clone repo on backend and validates credentials

I think it's already implemented: #638 and others


[ENH] Implement a per-prefix admission-controlled ObjectStore.

This implements a wrapper around object store that allows us to implement the limiting that we have today by simply wrapping an object store in the AdmissionControlledObjectStore.  It offers per-prefix request management rather than a global limit.

100% correct, @sanketkedia.  As we discussed offline I misread what .shared did.


Update .travis.yml

installing  mysqlclient for macos via homebrew

Coverage decreased (-0.8%) to 67.466% when pulling f7a38a377531830ee5514095e122e40b0f41743f on abhijithneilabraham:patch-2 into 5b85d998c30ddc6772b56310713530224466083a on clips:master.


Lock Portrait Mode - video not working

Hi,
As i said previously, really really great player :)
I'm wondering, I have setup my project on Portrait mode only. But the Video can not start if set up like that . . ..
Is there a way to "unlock" the portrait mode only for when the Video play ?
Thank sa lot for your help :)

There are no limits. You can configure your ui to fit Portrait mode.


Updated mesos proto buffer to the latest version

This allows mesos-go to support the ContainerInfo property in both the
ExecutorInfo and TaskInfo and therefore allows to use the default mesos
executor to start Docker containers

Looks like the changes from this PR have already merged in from other, parallel PRs. Thanks for submitting!


Pin setuptools version to fix installation with pip

Description
This PR pins the setuptools version to the latest version that's used in the project's CI.
Resolves #1950 that was introduced due to https://github.com/pypa/setuptools/issues/3693
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[x] Bug fix
[ ] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[x] Check that your code adheres to our coding style.
[ ] Write unittests.
[x] Run the unittests and check that they’re passing.
[x] Run the benchmarks to make sure your change doesn’t introduce a regression.

Test procedure:

Install package from source with python setup.py develop && pip install .
Run unit tests with cd cvxpy/tests && pytest
Run benchmarks with ``

Test results:

Unit tests: 852 passed, 289 skipped, 543 warnings in 41.25s
Benchmark: 9 passed, 3 skipped, 1 warning in 6.43s

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@phschiele @SteveDiamond I would appreciate a review and let me know if there is anything I can do to have this patch released to pypi

@piiq can you clarify more what happened? I saw your link, but is this bug in setuptools going to be fixed soon, or is this a permanent problem due to deprecation?

Thanks for the reply @SteveDiamond
If i understand correctly it's a permanent problem due to deprecation on the setuptools side that the numpy maintainers are not planning to adjust to. From this comment in a numpy issue thread I understood that numpy does not and will not support setuptools>60, but all versions up to the 65.5.0 were ok.
For cvxpy the problem is that it breaks the build process of SCS when installing with pip on a platform for which wheels with pre-built SCS binaries are not provided.
I've explicitly pinned the versions in pyproject.toml, setup.py and setup.cfg to be lower than the highest version that's installed onto the build system in continuous_integration/install_dependencies.sh. This solves the failing build issue because this pinned setuptools version is lower than 65.5.0.
For a test that the patch works as expected on an Apple Silicon machine I run pip install cvxpy or pip install git+https://github.com/cvxpy/cvxpy.git@master and see the SCS build fail and I run pip install git+https://github.com/piiq/cvxpy.git@bugfix/pin-setuptools and see that the build succeeds


New table of included metrics etc. - Question about Murphy Score

I am currently working on a new table listing the metrics/tools/tests included in scores, for inclusion in readthedocs. It is still a work in progress, but you can take a look here: https://scores.readthedocs.io/en/228-documentation-testing-branch/included.html
I have some questions about Murphy Score.

(1) Could somebody please take a look at how I have presented Murphy Score?
I wasn't sure how to best present the Murphy Score information. Please feel free to make any changes as you see fit, or let me know of any changes you would like me to make.
Note: the API for continuous.murphy_thetas was not available - hence the TBA.

(2) Should I list Murphy Score in both continuous and probability?
The API has it listed in both continuous and probability. Summary.md lists it in both continuous and probability. But the readme only lists it in continuous. So I wasn't sure what to do.

(3) This is more of a note to myself, although if somebody happens to know the solution, that would be great!
I initially had grid tables, but with the length of the URLs, they became very hard to read (and, as such, I imagine may have been hard to maintain). So I changed the tables to list view.
However, I have just realised re. Flip-Flop Index and Murphy Score - depending on the size of your browser window, the table is not necessarily keeping the Name/API/Tutorial/Reference(s) information in line with one another.
So if Flip-Flop Index and Murphy Score each continue to be listed as two separate lines within one row (not sure if I have used the right terminology), I will need to figure out how to keep each in line with their associated information, or otherwise enter them as separate rows.
I'll try and look into that later, and update here if I solve it. But if anyone happens to know the solution, please feel free to let me know!

Regarding (2), I think put Murphy score in both the continuous table and the probability table. I have gone back and forth on this a little, so others may have a different view. But if I were using this as an index into the API to find things, I think it's clearer to have it there than to omit documentation of a method which is present, even though it's a duplicate. I wouldn't rely on people reading the whole document, they are likely just to look at the bit they are interested in.

Regarding (2), I think put Murphy score in both the continuous table and the probability table. I have gone back and forth on this a little, so others may have a different view. But if I were using this as an index into the API to find things, I think it's clearer to have it there than to omit documentation of a method which is present, even though it's a duplicate. I wouldn't rely on people reading the whole document, they are likely just to look at the bit they are interested in.

Done.

Regarding (1), I am very happy with the current presentation layout.
I note the API links in all cases are to 'continuous'. The links in the probability parts of the table should link to the 'probability' part of the API even when they are the same underlying thing.


Integration scalelite for multiple bigbluebutton server

Hi Toshke ,
Your solution is really impressive.
I followed your youtube and cloudformation template and it worked.
As you have created the logic for the autoscaling group, but not any launch configuration.
It would be great if you can integrate scalelite at the top of it.

https://github.com/blindsidenetworks/scalelite/

@prabhatpankaj  Thanks!

but not any launch configuration.
AutoScaling Group launch data is defined through LaunchTemplate, rather then old school launch configuration

As for the scalelite, I'll take a deeper look at the architecture diagram, but from first glance it looks like it would be rather large undertaking


Add missing wireframe example to example readme

#562 added a new Example, but forgot to also document it in the examples readme.

Thank you!


Prefect-Ray spins up workers before the inputs for the worker tasks are ready / before the task's dependencies are complete

Hi folks, we're using Prefect and Ray to orchestrate distributed workflows.  When we generate a future x = task_1.submit() , if we pass that future as an input to another task, y = task_2.submit(x=x), Ray will spin up a worker for task_2 with the requested resources, and this worker will wait on x.result().
This is obviously undesirable! If we had x1 = task1(); x2 = task2(x1=x1); x3=task3(x2=x2); ..., all the later tasks in the pipeline would be wasting worker resources while waiting for the earlier workers to complete. We would like the worker for a task to only launch when the task inputs become ready.
Is this known behavior / does anyone know how to solve this?
Here's a working example, using  "prefect==2.9.0", "prefect-ray==0.2.4", "ray[default]==2.2.0"
from prefect import flow, task
from prefect_ray import RayTaskRunner
from prefect_ray.context import remote_options
import time

@task
def task_a():
    time.sleep(100)
    return 'a'

@task
def task_b():
    return 'b'

@flow(
    task_runner=RayTaskRunner(
        address="ray://ray-cluster-kuberay-head-svc:10001"
    )
)
def multi_test():
    with remote_options(num_cpus=1, num_gpus=1):
        x = task_a.submit()
    for i in range(10):
        with remote_options(num_cpus=1, num_gpus=1):
            task_b.submit(wait_for=[x])

if __name__ == '__main__':
    print(multi_test())

When run, we immediately get 11 workers created, per the image.

Hey @alexub thanks for the issue! We made a trade-off here on task run orchestration: if we submit early we can orchestrate more task runs at once because orchestration itself is distributed.
Is there a way to stop Ray from starting a worker per task or a way to cede a task from consuming its annotated resources temporarily?
This will probably requires changes over in PrefectHQ/prefect to have a reasonable solution. We may need to include a toggle that allows orchestration of the task in the flow run rather than on the task runner or we could remove annotations for the function we use to orchestrate the task and then submit the task again from inside the orchestration task with annotations? Complicated 😬

Hi @madkinsz, thanks for the quick response. I think what we need is simpler than that. The default TaskRunner already does not start the task until all the dependencies clear. We just want to have similar behavior when using Ray, so that a worker for task2 doesn't start or provision resources until task1 is finished.

Thanks @madkinsz . Early submission is a problem because for chains of dependent GPU tasks, this will cause them to use O(N^2) gpu hours instead of O(N), for a chain of length N.
It looks like the early submission may have been intentionally introduced by https://github.com/PrefectHQ/prefect-ray/pull/69 ?  As a stopgap, is there a way to add a flag in the RayTaskRunner to let the user choose between local orchestration (the old behavior, with its bottlenecks) or early submission (with its extra spend)?
I'd also potentially suggest adding a warning to documentation or at runtime w.r.t. early submission as this behavior isn't what users might expect after using the default TaskRunner.
Longer term, it seems like a solution could be some form of distributed orchestration which does not happen on the same workers the actual job tasks run on. e.g. perhaps the RayTaskRunner could spin up some orchestration tasks, which themselves submit the job tasks, and the number of orchestration tasks could be user configurable to allow for very large task loads.

Hey together,
I expect that Ray should be able to do the instance provisioning for a task not before the object references of a former task are resolvable.

The Ray documentation describes that a Ray remote function does not get executed until the object references are resolved: https://docs.ray.io/en/latest/ray-core/tasks.html#passing-object-refs-to-ray-tasks
The chaining challenge is described in the Ray documentation: "Ray will release CPU resources when being blocked." https://docs.ray.io/en/latest/ray-core/tasks/nested-tasks.html#yielding-resources-while-blocked
@pcmoritz proposed not to call the ray.get() but let the Ray scheduler figure out the resolution of the futures/object references. Maybe this could be the issue here (https://github.com/PrefectHQ/prefect-ray/pull/69#issuecomment-1429082091).

Our observations with the current implementation:

With CPUs, we do not observe this behavior: The (Ray) tasks are in the state running_in_ray_get until the futures are resolved. During this time, the cluster does stop scaling and does not get overprovisioned.
With a chain of tasks, whereas several CPU tasks are followed by one GPU task, we see the behavior you describe: The GPUs are started directly at the beginning and are not used till the CPU tasks are ready. This is something we encountered just this week.

I will ping the Anyscale Ray people to see if they can have an eye on this issue and perhaps help with an idea or solution.

ray will wait for upstream object refs as long as they are directly passed as parameters. with prefect, the input futures are wrapped in the parameter kwargs so that ray won't use them. created a draft PR #81 that solves this problem by passing the object refs additionally directly as args.


Suggestion: provide settings to show/hide the context menu in explorer

It seems a little difficult to hide the context menu of "open with vscode" in explorer once installed, which is complained about by some users(including me, in fact).
I think it's necessary to provide settings in vscode to show/hide the context menu in explorer(the menu on file and in directory separately will be better) , that would be more user-friendly, right?

You can decide about this during installing vs code.

Thanks for your response.
Actually, I know I can decide this during the installation. However, it will be better to give us user a chance to change our decision without reinstalling, right? Especially when we need to show/hide the menu on file and the menu in folder seperately. For example, I prefer to retain the menu where I right click a file/folder while remove the menu where I right click in the folder and desktop, will it be Ok?

Apologize for my poor English, but I really want to make vscode a better product since I love it very much.


[dox] Add missing Params and Returns to std.path docs.

Plus various doc improvements.
This PR adds Params: and Returns: sections to the docs of all public functions in std.path that don't already have these sections. Some rewording was done to eliminate repetition in the resulting docs.

Looks good, please squash the commits

Done.

Auto-merge toggled on


Is is possible to disable the dsmr_datalogger process from starting all together?

I'm trying out your DSMR Reader add-on, nice work, was trying to port it too, but stopped of course.
Is there a way to disable the dsmr_datalogger process from being started?
I use the API to supply data to the instance via rest calls.
So no network or serial device involved.
I'm on version 0.1.0 now.
...
...
2021-02-22 10:56:40,919 INFO exited: dsmr_datalogger (exit status 0; expected)
2021-02-22 10:56:41,925 INFO spawned: 'dsmr_datalogger' with pid 5844
2021-02-22 10:56:42,928 INFO success: dsmr_datalogger entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2021-02-22 10:56:48,896 INFO exited: dsmr_datalogger (exit status 0; expected)
2021-02-22 10:56:49,900 INFO spawned: 'dsmr_datalogger' with pid 5845
2021-02-22 10:56:50,902 INFO success: dsmr_datalogger entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2021-02-22 10:56:56,860 INFO exited: dsmr_datalogger (exit status 0; expected)
2021-02-22 10:56:57,866 INFO spawned: 'dsmr_datalogger' with pid 5846
2021-02-22 10:56:58,869 INFO success: dsmr_datalogger entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)

Hi! Yes it's possible. You need to set the 'DATALOGGER_MODE' to 'receiver' and restart the addon.

Yes, working, thanks!


Documentation does not include tool choice option

Describe the bug
The README example of using functions does not mention the tool choice parameter, which intermittently caused issues during implementation. Sometimes, the API would use our function, resulting in a finish_reason being tool_calls. Other times, the API would not use our function, with a finish_reason being stop.
To Reproduce
Steps to reproduce the behavior:
Follow the functions example in the README.
Expected behavior
We expected the function call to be used consistently with a finish_reason of tool_calls.
Screenshots
N/A
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Released in v7


[FLINK-5508] [mesos] Introduce ZooKeeperUtilityFactory to create ZooKeeper utility classes

This PR is based on #3155 and #3156.
This commit adds utility classes to abstract the CuratorFramework dependency from ZooKeeper
utility classes away. That way it is possible for modules outside of flink-runtime to use
these utility classes without facing the problem of a relocated curator dependency.

Thanks for the review @tzulitai. I'll address your comments and then merge this PR.


Add timeout on Invoke-request call

Add timeout on all web request call.
This is for the issue: https://github.com/azure/azure-sdk-tools/issues/2600

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

@sima-zhu I think there is an issue associated with this fix. Can you please link to it in the description?

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Styling

As my Visual Studio is set to auto-format on save, it would reformat the braces of this project all the time as FluentFTP uses K&R brace styling as opposed to the default Allman style.
This made it a bit of a pain point for me to contribute, as I had to disable auto-formatter when editing this project.
This PR adds some more styling rules to .editorconfig to prevent using IDE defaults.
None of the changes should alter the behavior of FluentFTP.
I've made a commit per type of change to make reviewing easier.

Very large PR, but seems to be excellently done. Thanks!


Did everything still unable to use fitView along side of any external component

Describe the Bug
I have been trying to use "fitView" with a custom made button, made for toggling the view of my reactflow diagram from horizontal to vertical, i have tried every method but have failed to make fitView work inside the toggle view function. It either says fitView is not a function(when i use useReactflow for using fitView inside other components). Please help me for fixing this issue.
this is my togglelayout function inside LayoutFlow component, which uses dagre for auto-layouting and also toggles the horizontal and vertical view:
const toggleLayoutDirection = () => {
setShowEdges(false);
setZoomOut(true); // Trigger the zoom out animation
setTimeout(() => {
const newDirection = layoutDirection === 'BT' ? 'RL' : 'BT';
setLayoutDirection(newDirection);
const { nodes: newNodes, edges: newEdges } = getLayoutedElements(
nodes,
edges,
newDirection
);
setNodes([...newNodes]);
setEdges([...newEdges]);
setZoomClass('');
setZoomOut(false); // Reset the zoomOut state after the animation is complete
setShowEdges(true);
}, 200);
};
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Just try to use fitview inside any external component
Expected behavior
It will most of the times say that "fitView is not a function" and if there is no error, the fitview function will not work.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

-Windows 10
-Browser : Chrome

Verson: 11(reactflow)

Additional context
No response

why are you opening an issue and a discussion with the same question? This is really annoying. I will close the issue since it's a duplicate of #3079

why are you opening an issue and a discussion with the same question? This is really annoying. I will close the issue since it's a duplicate of #3079

Since i am a new user here so i didn't know where would be the right place to post this issue, sorry to annoy you.


fix(nodebuilder/p2p): Fail out on init if invalid network specified through flag

Found during debugging. Self-explanatory.

Closing in favour of #1357


next: Dialog with svelte transition breaks pointer events

Describe the bug
When using Dialog.Content with forceMount pointer-events: none is added to the body element. event without forceMount pointer-events: none is added when the content is open leading to the page being un responsive. have not been able to get transitions to work smoothy without |global that causes other issues.
Reproduction
https://stackblitz.com/edit/github-shpwk7?file=src%2Froutes%2F%2Blayout.svelte,src%2Froutes%2F%2Bpage.svelte,tailwind.config.cjs
Logs
No response
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.6.3
    bits-ui: ^1.0.0-next.23 => 1.0.0-next.23
    svelte: ^5.0.4 => 5.1.0

Severity
annoyance

Ah, I think I know the cause of this. Thanks for bringing it to my attention! Will get a fix pushed asap!
Appreciate you taking the time to try these out and help find these issues 💯

This is proving to be trickier than I initially anticipated. I can fix this issue today, but it breaks non-child functionality. Going to keep looking into it this week and will hopefully come to a resolution.


Update dialog pattern with new non-modal content

Stub

Some of the work being done with disclose component ect. can be added for context to dialog pattern.
Topic was talked about on June 3, 2021 in the design crit with @mbgower and @joshblack

Some notes on focus behavior that came up:

Modal dialog

When opened by the trigger element, focus shifts to the first interactive element in the dialog
Focus is trapped in the dialog
Pressing escape will close the dialog

Nonmodal dialog

When opened by the trigger element, focus shifts to the first interactive element
Focus is not trapped in the dialog
Pressing escape will close the dialog
Moving focus out of the dialog will close the dialog


Integrate aarch64 assembly: src/arm/64/mc16.S

Integrated:

rav1e_avg_16bpc_neon
rav1e_prep_8tap_regular_16bpc_neon
rav1e_prep_8tap_regular_sharp_16bpc_neon
rav1e_prep_8tap_regular_smooth_16bpc_neon
rav1e_prep_8tap_sharp_16bpc_neon
rav1e_prep_8tap_sharp_regular_16bpc_neon
rav1e_prep_8tap_sharp_smooth_16bpc_neon
rav1e_prep_8tap_smooth_16bpc_neon
rav1e_prep_8tap_smooth_regular_16bpc_neon
rav1e_prep_8tap_smooth_sharp_16bpc_neon
rav1e_prep_bilin_16bpc_neon
rav1e_put_8tap_regular_16bpc_neon
rav1e_put_8tap_regular_sharp_16bpc_neon
rav1e_put_8tap_regular_smooth_16bpc_neon
rav1e_put_8tap_sharp_16bpc_neon
rav1e_put_8tap_sharp_regular_16bpc_neon
rav1e_put_8tap_sharp_smooth_16bpc_neon
rav1e_put_8tap_smooth_16bpc_neon
rav1e_put_8tap_smooth_regular_16bpc_neon
rav1e_put_8tap_smooth_sharp_16bpc_neon
rav1e_put_bilin_16bpc_neon

Future work:

rav1e_blend_16bpc_neon
rav1e_blend_h_16bpc_neon
rav1e_blend_v_16bpc_neon
rav1e_emu_edge_16bpc_neon
rav1e_mask_16bpc_neon
rav1e_warp_affine_8x8_16bpc_neon
rav1e_warp_affine_8x8t_16bpc_neon
rav1e_w_avg_16bpc_neon
rav1e_w_mask_420_16bpc_neon
rav1e_w_mask_422_16bpc_neon
rav1e_w_mask_444_16bpc_neon

Advances #2376.

Coverage increased (+1.7%) to 82.02% when pulling 236ed34c3cbd324d4be374687a6511291e6cc7e5 on barrbrain:aarch64-mc16 into d435f94e14b8d9f88f651d22153e78cb2036a3b8 on xiph:master.


Added New duck

Description
Here my contribution to "The Duck Gallery".
Here is my contribution to "The Duck Gallery".
I have added a new duck image.
You must respect the following conditions

Your contribution must respect the code of conduct
It's your first PR to this repository
You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
You have not changed the image of the duck
The image filename must be your GitHub username (ex: your-username.png)
You are using your own GitHub user and it's the same as the PR author
Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Hi @kunal-511 , thanks for your contribution. For this type of contribution, you just have to add a duck and list on the contributor js file. Please reset your changes on package-lock and yarn lock file 🙏

I have updated the code please merge it

I have updated the code please merge it

I always see changes on lock file 😕

resolved please merge

now check added the required file


🔬 iOS "Notch" on Safari Ignores Theme Colors

Describe the bug
On iOS, in Safari, the notch is a plain white, ignoring dark mode theme colors (or an image background). In landscape mode, colors are respected, but background images do not extend to the edges of the screen.
To Reproduce
Steps to reproduce the behavior:

Go to https://blowfish.page on iPhone Safari
If in light mode, click moon icon
See white bar above theme (and light search bar)
In landscape mode, see correct color change but bad background image behavior

Expected behavior
Theme content smoothly interacts up to edges of available display; iOS search bar colors respect darkness
Screenshots

Desktop

OS: iOS 16.1.2
Browser: Safari 16

Hugo & Blowfish versions
Hugo v0.110.0, but this issue persists even on the public Blowfish site.
Checked out Blowfish main at 55f6cc
Additional context
This is a tricky issue to solve. The correct fix will probably be to expand background elements to the edges of iPhones with the relevant meta tags, and defining a safe region for content in the stylesheet. This is fine with images, but it probably won't fix the underlying coloring problem for other pages because apple appears to choose colors with the theme-color meta tag before the stylesheets are loaded. That precludes the use of the theme colors defined in the blowfish stylesheets.
My own hotfix just manually updates the theme color metadata at build time using colors defined in the site parameters (ugly, I know). It's technically responsive, but I've had to turn off the "theme switch" button because it doesn't update the meta tag - that might be another thing that needs to happen.
This iPhone-specific issue is annoying to see and annoying to fix. I'm using my "bandaid" for now so I don't need to update the stylesheets or any of the javascript. If this is fixed correctly, it would be fantastic.

Solved in https://github.com/nunocoracao/blowfish/pull/546


Add Cloud SQL Client role for IAM users and service accounts

TL;DR
Add Cloud SQL Client at the project level alongside Cloud SQL Instance User, to permit connections via the Cloud SQL Auth Proxy
Terraform Resources
resource "google_project_iam_member" "iam_connect_binding" {
  for_each = {
    for iu in local.iam_users :
    "${iu.email} ${iu.is_account_sa}" => iu
  }
  project = var.project_id
  role    = "roles/cloudsql.client"
  member = each.value.is_account_sa ? (
    "serviceAccount:${each.value.email}"
    ) : (
    "user:${each.value.email}"
  )
}

If we want to make this optional, then we can add a count that checks a module variable.
This is similar to the existing code; it changes the resource name (from iam_binding to iam_connect_binding) and role (from roles/cloudsql.instanceUser to roles/cloudsql.client).
Detailed design
This module adds IAM users and service accounts to the instance users list, and also adds Cloud SQL Instance User at project scope: https://github.com/terraform-google-modules/terraform-google-sql-db/blob/f96f71ed00e590a56083bb4faffc5b54e4583603/modules/postgresql/main.tf#L218-L250
When using IAM authentication and connecting with the Cloud SQL Auth Proxy, we also require the Cloud SQL Client role, as described in the documentation:

Thus, I am proposing that we also add roles/cloudsql.client at project scope, or make it optional subject to some configuration option. Both predefined roles are required because we require all three of the permissions:

cloudsql.instances.connect
cloudsql.instances.get
cloudsql.instances.login

Additional information
If we agree this design makes sense, I'd be happy to contribute a PR!

As per GCP docs https://cloud.google.com/sql/docs/mysql/connect-admin-proxy#before_you_begin:

For a user or service account, make sure the account has the Cloud SQL Client role. This role contains the cloudsql.instances.connect permission, which authorizes a principal to connect to all Cloud SQL instances in a project.

The whole IAM binding should be removed from the module. The reasoning is described in this issue https://github.com/terraform-google-modules/terraform-google-sql-db/issues/381

@jawnsy When this PR https://github.com/terraform-google-modules/terraform-google-sql-db/pull/382 will merged. You can use something like this to grant required cloudsql roles. Obviously, you can wrap it up into some modules for convenience.
locals {
  iam_user_emails = [
<EMAIL_ADDRESS><EMAIL_ADDRESS>  ]
  cloudsql_iam_roles = [
    "roles/cloudsql.client",
    "roles/cloudsql.instanceUser"
  ]
  # Generate pairs of [member, iam_role] for creation of iam_bindings
  iam_user_role_bindings = [for iu in distinct(local..iam_user_emails) : [for role in local.cloudsql_iam_roles : {
    email : iu
    is_account_sa : trimsuffix(iu, "gserviceaccount.com") == iu ? false : true
    role : role
  }]]
  iam_user_role_bindings_flatten = { for o in flatten(local.iam_user_role_bindings) : "${o.email}|${trimprefix(o.role, "roles/")}" => o }
}

resource "google_project_iam_member" "iam_binding" {
  for_each = local.iam_user_role_bindings_flatten
  project  = var.project_id
  role     = each.value.role
  member = each.value.is_account_sa ? (
    "serviceAccount:${each.value.email}"
    ) : (
    "user:${each.value.email}"
  )
}

It will create resources for each pair. Example:
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Closing as obsolete due to #381


Update asset.hpp

asset should be no negative number
for example:
         #define CORE_SYMBOL S(4,SYS)
         eosio::asset amount(0, CORE_SYMBOL);
         eosio::asset amounthalfmax(max_amount/2, CORE_SYMBOL);
         amount -= amounthalfmax;

It should not pass through

It is possible to represent negative amounts.  This change would break things.


The extension still works if the browser doesn’t redirect to the new domain name, any possibility of a fix?

This extension stopped working when the domain name was changed from Twitter to X, but some browsers fail to redirect. The extension still works perfectly in the rare case that the old URL is displayed in the address bar, so it appears that the only reason the extension stopped working is because of the different domain name. Will there be a fix for this?

did you end up finding a work around?


icd: Document parametization for VulkanSC

Added so that future maintainers know why these variables exist.

CI Vulkan-Tools build queued with queue ID 21895.

CI Vulkan-Tools build queued with queue ID 21895.

CI Vulkan-Tools build # 1054 running.

CI Vulkan-Tools build # 1054 passed.

CI Vulkan-Tools build queued with queue ID 21929.

CI Vulkan-Tools build queued with queue ID 21929.

CI Vulkan-Tools build # 1055 running.

CI Vulkan-Tools build # 1055 passed.


Cannot Install on MacPorts KiCAD

Describe the bug
I installed the plugin via the PCM, however there's no icon in the toolbar. All my other plugins work (all from the official repository).
To Reproduce
Install KiCAD on an M1 Mac via MacPorts
Go to the PCM, add custom repository, install KiCAD JLCPCB Tools
Log:
Extracting package 'com.github.bouni.kicad-jlcpcb-tools'.
Extracted package
Removing downloaded archive 'com.github.bouni.kicad-jlcpcb-tools_v2022.09.01.zip'.
Done.

PCM says that the plugin is installed
Open PCBNew, no JLC button in toolbar.
I also tried manually installing via git with no luck. Is there any way to check and make sure it's installed?
Expected behavior
JLC icon should appear in toolbar
KiCad Version
MacPorts KiCAD (ARM Build)
Application: KiCad

Version: 6.0.7, release build

Libraries:
	wxWidgets 3.1.5
	libcurl/7.85.0 OpenSSL/3.0.5 zlib/1.2.12 brotli/1.0.9 zstd/1.5.2 libidn2/2.3.3 libpsl/0.21.1 (+libidn2/2.3.2) nghttp2/1.50.0

Platform: macOS Version 12.6 (Build 21G115), 64 bit, Little endian, wxMac

Build Info:
	Date: Sep 22 2022 05:42:28
	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.6.0
	Curl: 7.85.0
	ngspice: 36
	Compiler: Clang 13.0.0 with C++ ABI 1002

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON

Check preferences -> preferences -> action plugins
If there's a problem you should see a attention icon that gives more info.
Let me know if that's the case

Ah thank you!
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/akelly/Documents/kicad/6.0/scripting/plugins/kicad-jlcpcb-tools-main/__init__.py", line 4, in <module>
    from .plugin import JLCPCBPlugin
  File "/Users/akelly/Documents/kicad/6.0/scripting/plugins/kicad-jlcpcb-tools-main/plugin.py", line 5, in <module>
    from .mainwindow import JLCPCBTools
  File "/Users/akelly/Documents/kicad/6.0/scripting/plugins/kicad-jlcpcb-tools-main/mainwindow.py", line 18, in <module>
    from .fabrication import Fabrication
  File "/Users/akelly/Documents/kicad/6.0/scripting/plugins/kicad-jlcpcb-tools-main/fabrication.py", line 8, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

I ran /opt/local/Library/Frameworks/Python.framework/Versions/3.10/bin/python3 -m pip install requests and that fixed it

Glad you firgured it out 🥳


Live Data & IGList Grid by Type

I have been using IGList for about 6 months now and I have two questions:

In the red section, I currently have the data in a separate model object called Game along with all of the other items called Video/Audio/Gallery etc.  I am looking for the best way to update just the Game object when live scoring is happening.  Suggestions?

In the orange section, I want to be able to have all gallery items next to each other in groups of two.  I was curious the best way to attack this in IGList.  Would this be more of a data manipulation or is there a more elegant way to implement this in IGList.

Thank you for any advice on these two topics

Is there anyone that has any advice on this?

For #1, take a look at this comment about signal/delegate architectures and propagating events to section controllers.
For #2, IMO you should break those all up into separate section controllers:

One for the image + text
One for image + text-overlay
And one for audio or w/e that is on the bottom

That way you can model your data into very specific pieces, and each of your section controllers should only have a single purpose/cell instead of getting to tangled. Hope this helps!


Consolidated MockModel Class for CLV Testing

pytest fixtures for both fitted and mocked model objects are scattered across the CLV testing suite. It may be worthwhile to consolidate these into the MockModel class  @wd60622  created last year. This would clean up conftest.py and speed up CI runs.

Will do another pass at these some time soon


Report a bug of Engine::Get()

GraphExecutor should hold Engine::_GetSharedRef() to a class member engine_ref_, or sometimes Engine might be deconstructed before GraphExecutor was deconstructed. Note that in ~GraphExecutor(), Engine::Get()->DeleteOperator() was called.
This bug is similar to https://github.com/apache/incubator-mxnet/issues/309 , which has been fixed yet. In this bug, sometimes ObjectPool<ThreadedOpr>, ObjectPool<OprBlock>, ObjectPool<VersionedVarBlock>, common::ObjectPool<ThreadedVar>, might be deconstructed before ThreadedEngine was deconstructed.
Why this shared_ptr bug appears everywhere? It's a general C++ problem. A simple example as follow:
engine.h
#pragma once

#include <memory>

class Eng {
 public:
  virtual ~Eng() = default;
  virtual void Print() const = 0;
};

// src/engine/engine.cc
class Engine : public Eng {
 public:
  Engine();
  ~Engine();

  static std::shared_ptr<Engine> _GetSharedRef();
  static Engine* Get();

  void Print() const;

 private:
  char *name_ = nullptr;
};

typedef Eng *get_t();
typedef std::shared_ptr<Engine> get_ref_t();

engine.cc
#include "engine.h"

#include <stdio.h>

Engine::Engine() {
  name_ = new char[8];
  snprintf(name_, 8, "HELLO");
}

Engine::~Engine() {
  printf("BEGIN ~Engine\n");
  if (name_)  delete name_;
  printf("  END ~Engine\n");
}

std::shared_ptr<Engine> Engine::_GetSharedRef() {
  static std::shared_ptr<Engine> sptr(new Engine());
  return sptr;
}

Engine* Engine::Get() {
  static Engine *inst = _GetSharedRef().get();
  return inst;
}

void Engine::Print() const {
  printf("name=%s\n", name_);
}

extern "C" Eng *get() {
  return Engine::Get();
}

extern "C" std::shared_ptr<Engine> get_ref() {
  return Engine::_GetSharedRef();
}

executor.h
#pragma once

#include <memory>

#include "engine.h"

class Executor {
 public:
  virtual ~Executor() = default;
  virtual void Print() = 0;
};

// src/executor/graph_executor.cc
class GraphExecutor : public Executor {
 public:
  GraphExecutor(void *eng);
  ~GraphExecutor();

  static std::shared_ptr<GraphExecutor> _GetSharedRef(void *eng);
  static GraphExecutor* Get(void *eng);

  void Print();

 private:
  void *eng_;
  std::shared_ptr<Engine> engine_ref_;
};

typedef Executor *create_t(void *);

executor.cc
#include "executor.h"

#include <dlfcn.h>
#include <stdio.h>

#include "engine.h"

GraphExecutor::GraphExecutor(void *eng) {
  eng_ = eng;

  get_ref_t *get_ref = (get_ref_t *) dlsym(eng_, "get_ref");
  engine_ref_ = get_ref();  // TODO: import!
}

GraphExecutor::~GraphExecutor() {
  printf("BEGIN ~GraphExecutor\n");
  Print();
  printf("  END ~GraphExecutor\n");
}

void GraphExecutor::Print() {
  get_t *get = (get_t *) dlsym(eng_, "get");
  Eng *eng = get();
  eng->Print();
}

std::shared_ptr<GraphExecutor> GraphExecutor::_GetSharedRef(void *eng) {
  static std::shared_ptr<GraphExecutor> sptr(new GraphExecutor(eng));
  return sptr;
}

GraphExecutor* GraphExecutor::Get(void *eng) {
  static GraphExecutor *inst = _GetSharedRef(eng).get();
  return inst;
}

extern "C" Executor *create(void *eng) {
  return GraphExecutor::Get(eng);
}

test.cc
#include "engine.h"
#include "executor.h"

#include <dlfcn.h>
#include <stdio.h>

int main() {
  void *handle_engine = dlopen("libengine.so", RTLD_LAZY);
  void *handle = dlopen("libexe.so", RTLD_LAZY);

  create_t *create = (create_t *) dlsym(handle, "create");
  Executor *executor = create(handle_engine);
  executor->Print();

  //dlclose(handle_engine);
  //dlclose(handle);
  return 0;
}

Makefile
all:
gcc -std=c++11 -g engine.cc -fPIC -shared -o libengine.so
gcc -std=c++11 -g executor.cc -fPIC -shared -o libexe.so
g++ -std=c++11 -g test.cc -rdynamic -ldl -o b.out
make
./b.out
You will run well. But if there is no "engine_ref_ = get_ref();" in GraphExecutor::GraphExecutor(void *eng), it will coredump. This is the same problem as the bug.

I don't know how to paste the code elegantly, would anyone teach me please....

@lovickie You should use ```  to surround your code.
AFAIK, destruction order has been a long-standing problem here. Many years ago, when C++ 11 was not that popular, there were naked pointers everywhere...There should have been tons of PRs trying to fix this, but if there is any problem, you are more than welcome to submit a PR.

Thanks for submitting the issue @lovickie
@mxnet-label-bot [Bug, Backend, C]

More information as follows.
My project x, use mxnet to do sth, and also provides python api. When import mxnet before import x, the destruction ran well. But if import x before import mxnet, it would coredump when destruction. Finally I found this bug.
Thank reviewers for checking my PR.

The PR has been merged. @lovickie Can this issue be closed?


Disable a drag source

When dragging an element into the layout, just like in the drag example http://codepen.io/wolframhempel/pen/d508753b29c3001c24218bf3a6b25141 it would be good to have a way to disable the drag source once its added to the layout, to prevent adding multiple versions of the same item.
For adding by click this is easy enough to do by adding a check in the click handler function to see if the element exists in the layout already, but for drag there doesn't seem to be a simple way to achieve this.
Something along the lines of:
myLayout.removeDragSource(element);

In a my past thread ( #143 ) I spoke about the same thing and I wrote that I currently solved manually adding .disable CSS class to already dragged elements with the following rules to disable further dragging:
.disabled
{
   opacity:0.7;
   pointer-events:none;
   cursor:not-allowed;
}

Anyway, a standard method would be likeable

I also solved this problem externally to the plugin by manually adding/removing drag source bindings as appropriate.

I would like to take advantage of incoming next release to push on this feature. CSS code could be one I suggeste above, while JS should apply this class direclty on source element after dragging operation, in order to disable it.
Can someone implement this simple feature?
Thanks

PRs welcome: I don't have the time or bandwidth to look into feature I'm not going to be using on my own project, sorry! However even if it doesn't make this release, I'm going to try and make releases happen more often, apologies for the long gay between them.


Pagination and PageSize

Pagination | Whether to render pagination relevant
I just want to disable "PageSize component" because in a small space the table is overlaping one to the other, I think that having the option to disable pagination and pageSize component is a good change for the Library

:Pagination=false

@kenberkeley  :Pagination=false will disable both page size and pagination, I want to keep pagination but disable page size component

Well... how about $('div[name=PageSizeSelect]').remove()?

well, it can be included also on the configuration of the datatable component, right?

use your own fork might be better

too many scenarios result in too many config options

https://github.com/OneWayTech/vue2-datatable/blob/master/src/index.vue#L13
the usage of a row in the parent is not compatible with the edge case with 1 col
since you are using a default spacing it is not compatible with all the cases
Using 2 rows is better or give the user the option to set that configuration, it is a 3 lines change that improves UX for some cases.

also
$('div[name=PageSizeSelect]').remove() wont work because it is not wrapped in a div PageSizeSelect is a label
https://github.com/OneWayTech/vue2-datatable/blob/master/src/PageSizeSelect.vue#L2

😂😂😂

After removing the element $('label[name=PageSizeSelect]').parent().remove(); the view is displayed to the left and not centered. @kenberkeley

So... nice wrap man! you made it

trust me: use your own fork
i am no longer work for OneWay

bug reports are welcome but refactor might not...

@r9software following line will help you to remove/hide parent col.
$('label[name=PageSizeSelect]').parent().css({'visibility':'hidden'});

Hey @kenberkeley  is there a way to force a reload of the table? I want to include a dynamic header value but I have not figure out how

how about this...
<datatable v-if="tableVisible" v-bind="tableConfig" />

this.tableVisible = false

// set dynamic values ...

this.$nextTick(() => {
  this.tableVisible = true
})


Clarify which angle is needed for DirectionalBias

The docstring at this line is not clear enough.
My understanding is that we need to provide the angle with reference to the x axis, in clockwise direction. That's what I inferred from looking at the results of that line (clever way of not interpolating the data btw 😉), providing the wrong angle means one may look at across-track instead of along-track direction.
Ii not clarified, I think it's more intuitive for most people to see it as the angle w.r.t. the y axis, because satellite images are typically only slightly rotated compared to that axis.

Closed by #526


[BUG] Error message has a serialized class and is difficult to parse programmatically

When an error occurs on a contract, the error message includes the class name and is difficult to parse as a string.
Python version

Python 3.7.9
Expected Behavior

The error message only contains str or JSON like dict instead of class
Current Behavior

The error message has a stringified class
Possible Solution

Convert class to JSON dict first? (fast solution)
Or grab the important fields from the class and compose a nicer error message (ideal solutioin)
Steps to Reproduce

Create a contract that you know will error (I am using starknet-devnet)
Call method that causes error
See error message.
It looks something like this:
Transaction was rejected with following starknet error: TransactionFailureReason(code='TRANSACTION_FAILED', error_message='Error message: Already initialized\nError at pc=0:118:\nAn ASSERT_EQ instruction failed: 1 != 0.\nCairo traceback (most recent call last):\nUnknown location (pc=0:132)').

Notice the part that says TransactionFailureReason, that is like a class.. I really just want the code and the error_message from it but I have to parse the whole thing as a string.
Context (Environment)
Makes parsing and forming custom errors challenging.
Detailed Description
Use more primitive data types.
Possible Implementation

Good idea, we've should have used code and message from TransactionFailureReason instead of the whole class in the first place.
Fortunately this seems easy to fix.


[move-prover] Add "assume !$abort_flag" at each label

Motivation
This PR makes the following changes:

add "assume  !$abort_flag" at each label
replace "assert !$abort_flag$ at the beginning of a procedure with "assume !$abort_flag"
enable loops.move test

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Enabled a test.
Related PRs

My one little concern about having "assume !$abort_flag;" at the beginning of each basic block is that: it could introduce a contradiction when $abort_flag is set to be "true", but the procedure does not exit right away due to a bug/mistake.
Could we also add "assert !$abort_flag;" somewhere properly to make sure the absence of this situation?

I had thought about your concern when I was deciding whether to put assert or assume at each label.  I realized that putting an assume is sound because whenever $abort_flag is set to true, control jumps to the end of the function and from then on the entire call stack is unwound.  All this is being done inside the translator from Move into Boogie. So unless there is a bug in this translation scheme, putting an assume should be sound.

I'm concerned that this is just special-casing one particular instance of the loop havoc problem. Isn't there a better and more general solution?

Indeed, it is special handling for $abort_flag.  Unfortunately, the only general solution I know is automatic inference of loop invariants.  We are currently not doing that and instead requiring the programmer to supply loop invariants manually.  We could have approached the problem similarly for $abort_flag except that $abort_flag is a variable introduced by the translation.

@bors-libra r=junkil-park

:pushpin: Commit 99ecd65 has been approved by junkil-park

:hourglass: Testing commit 99ecd653681121378e0521e2007a14c5fd1c95e3 with merge 707e6891c98135af893e8d5abe77136f2bb1e8d4...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: junkil-park
Pushing 707e6891c98135af893e8d5abe77136f2bb1e8d4 to master...


Out of stock products can still be bought if in the cart before stock goes to zero

Originally reported by: Bertrand Le Roy (Bitbucket: bleroy, GitHub: bleroy)

Bitbucket: https://bitbucket.org/bleroy/nwazet.commerce/issue/51

In addition to what's in the title, I can also add out of stock products to the cart from a cached page. I'll work on a fix for this.

What I have done so far on this:

Server-side check so that when you add products to the cart, if you are trying to add more than however many are available, it will only add the available quantity, unless back-order is allowed.
If you still wish to increase the quantity in order, you can. In the cart views, beside the number, you will have a string telling you how many are in stock, and whether back-order is allowed.
If you have in the cart out of stock product, the checkout buttons will not show.

Still to do:

verify the inventory on checkout. The complexity on this is that ICheckoutService, as it is, does not have anything enabling that check: everything is left to the implementation. e.g., For Stripe, I am going to change the Ship method in the controller, so it does that check and in case it fails it redirects to the cart (with a message)


OpenApiResponseWithBody - Does not handle classes with IImmutableList

Hi,
This is really a great extension, just tried it out and will use it on all the azure functions we have! I noticed that there was a problem rendering the response body of a class when it has a property type of IImmutableList. I tried changing to IList and that works fine.
public class ResponseDto{
   public ImmutableList<some class> List {get;}
}

renders just an empty class like so:
{
   "list": {}
}

It would be great to add support for IImmutableList!

@torepaulsson Thanks for the issue! I'll take a look.

@torepaulsson I hope this PR #247 sorts out your issue. Please wait for the 0.9.0-preview release!

That was very quick, thank you!


the /repo/ URLs give you the zipfile for cpan dists, not the repo

That works like designed, even though repo might be a misnomer now that we have CPAN.
/repo/ end point points to dist source, like GitHub/GitLab repo, or the CPAN archive. /dist/ points to human-vieable contents of the dist (currently still a repo for GitHub/GitLab; for CPAN a modules.perl6.org file viewer page)

That works like designed

Just to clarify: this issue still needs to be fixed and we need an endpoint that would redirect to dist's repo, even for CPAN dists (with current functionality of /repo/ stuffed under some other route)


fix: Properly include css

This hasn't been rebased properly.
It would be really awesome if you could finish this within the next week(s). This branch no longer "just" addresses the issues that led to its development in the first place and it makes it really hard to collaborate in any meaningful way, since it will be a nightmare to rebase. E.g. currently there are probably more than a couple of instances where stuff hasn't been rebased properly.
Also it would be awesome if you could fix your .vimrc to remove trailing whitespace. It really leads to a ton of commit noise and is annoying for people using a real editor :neutral_face:. E.g. some editors remove it automatically (see https://github.com/Famous/engine/pull/88/files), which changes the git blame for no good reason.

@alexanderGugel or, alternatively, you could set your editor to not care at all about whitespace like mine and avoid that commit noise.

@DnMllr I did so, but as in the PR I linked, most people don't.

@DnMllr Please merge. This prevents people from using this branch.
I really don't want to start a discussion about trailing whitespace. It's generally accepted that it's bad practice.
See https://github.com/Famous/engine/pull/88/files
See https://github.com/Famous/engine/pull/161/files#diff-43a6c35d5198b3c9ba1949ef620b2974L3
Again, just a minor thing, but it would be great if we could follow conventions here.

Fixed in upstream. Would be really cool if you could add this to your .vimrc: http://stackoverflow.com/a/1618401/3773544 Thanks.


Chinese and Japanese translations

Translation to Chinese(Native)/Japanese(Near Native)
Should I contact author? @ransome1
Thank you

Hi @nutnutwin. Chinese and Japanse translations would be amazing. To do so, the only thing you would need to do is to fork sleek and start doing the translations based on https://github.com/ransome1/sleek/blob/master/src/locales/en/translation.json.
The Chinese translations for instance would then need to be put into https://github.com/ransome1/sleek/blob/master/src/locales/cn/translation.json and a pull request would need to be created by you, so you can be officially be listed as a contributor.
Alternatively or if you're not familiar with the Github process, you can just download https://github.com/ransome1/sleek/blob/master/src/locales/en/translation.json, do the translations in separate JSON files and send them to me by email (ransome@uber.space). I would then take care of the rest.

@ransome1 Great
not very familiar with GitHub Fork, but will try
If not successful, will let you know, and send the json to you.

@nutnutwin, I assume you are working on a computer, that has a Chinese font installed? Then please feel free to try out this pre-release of v1.0.5, see your translations in action and share your feedback :)
https://github.com/ransome1/sleek/releases/tag/v1.0.5-5
Let me know if it works or if anything is missing. I'll check it tomorrow in detail on a Windows VM (Windows has a Chinese font installed per default).

@ransome1 Great! I tried it out, and found

some problems on my side
Will fix and request pull
some probelms with font/zoom/layout
Will report as issue

@ransome1 Hi I am not extremely familiar with font mechanism
but it seems to be using a fallback font for some of the characters
wonder which font is specified? (is it app-wide font?

@nutnutwin, I added four fallback fonts which, according to the interwebs, are capable of handling SC without any issue. Namely:

"Arial Unicode MS"
"Microsoft JhengHei"
"微軟正黑體"
"Microsoft YaHei"

So the whole fallback chain now looks like this in this order: "FreeSans", Helvetica, "Arial Unicode MS", Arial, "Noto Sans", "DejaVu Sans", "Microsoft JhengHei", "微軟正黑體", "Microsoft YaHei", sans-serif;
If all those fonts are not available on the users computer, the next fallback will be a sans-serif font selected by the OS and that will eventually lead to the behavior we can see on your screenshots. But I assume that Chinese users will most likely have either one of te four fonts installed or a proper sans-serif fallback font installed.
Also I enhanced the due date and recurrence picker function, responsible for settings the width of those elements dynamically. I tested it on my Win 10 Vm and it looked good. Can you confirm this?
I replaced the old new builds with new ones: https://github.com/ransome1/sleek/releases/tag/v1.0.5-5

@ransome1
I would love to try, but the URL does not contain any binary?

I forgot to include your latest translation file and the new version is being built right now.

Ok, the new builds are up: https://github.com/ransome1/sleek/releases/tag/v1.0.5-5
This is the portable zipped version: https://github.com/ransome1/sleek/releases/download/v1.0.5-5/sleek-1.0.5-5.zip

Still some Characters showing improperly
possible to dump a log where your font is falling back to?
BTW the new/edit Button shows fine

Can you tell me which signs are showing improperly? Do you see a pattern? For instance "only when set bold" or only when sign is in a headline?
To see which font is actually rendered, you could take a look into the Chromium Developer Tools. In sleek, press Alt and the top menu will show up. In "About" there is an option to open the Developer tools.
Within in dev tools you need to use the element selector and select an element, that contains a font. Then if you select the tab "Computed", you need to scroll to the bottom and the font, that actually has been rendered, will be listed.

Described with more detail here: https://stackoverflow.com/questions/884177/how-can-i-determine-what-font-a-browser-is-actually-using-to-render-some-text/20830300#20830300

This is the font rendered on my Windows 10 VM:

And when I recreate your screenshot above, on Win10 it looks like this:

@nutnutwin, I also found an old Windows 7 laptop in pretty much default configuration. This is what sleek in 1.0.5-5 looks like in Win7

Does this look correct?

Both your Windows 10 and Windows 7 Screenshot looks perfectly fine
In my Screenshot, "任务列表" on the Top Left is not shown properly, with "务" falling back
It is highly likely just my problem, as I tweak with system font a lot.
for example,

Force all font to my liking
Use specific language for non-unicode application(for running Japanese language old apps)

My bad.
Could you please provide some info on your VM configuration?(or just out of box?) I might try that later, Thank you.
@ransome1

It is this VM out of the box: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/
Font settings cannot be changed within this VM, as it is restricted. I assume this is the default Win10 configuration. But I can't say fo sure.

Great!
Will find some time for the debug tools(not familiar with web developing)
Once I pin down the problem will report here

@nutnutwin, I was thinking about wrapping up the 1.0.5 tomorrow and deploy it through all channels. Should I wait a bit longer for the Japanese translations or shall we put them into the next release (1.0.6)?

@nutnutwin, I have another question for you. Are you working on an OS that is set to Chinese? I was wondering if, after deleting sleeks config files, the Simplified Chinese translation is automatically chosen, or if the fallback to English sets in.

@ransome1 as I mentioned(I think you saw it already) I will do the Japanese translation after you put the business entry to avoid misunderstanding.
Not very gitty though...
For personal PC OS(where problem is produced), I believe I either

clean installed English OS(this is the same env with you I believe)
Specified Chinese on installation, and installed English as a language pack(and applied to UI)

I have 2 PCs @Company with Clean English Installation, I will check if they work properly

@nutnutwin, on your personal computer, could you at some point please

switch yur OS to Chinese
delete sleeks config files (if you're using the zipped one from Github, just delete the "user-preferences.json" in that folder)
Start sleek and check if sleeks language detection is actually detecting your Chinese setup or if it falls back to English and has to setup to Chinese manually

@ransome1 something to share
I tried using sleek(out of box, just switched to SC) on

2 personal PC(English/English+SC package)
2 business PC(definitely English Clean Install)
they all show font fallback problems
so it has to be my tweak problem...

as for your request:
"switch your OS to Chinese" means installing Chinese Language Package on English Windows, and set as UI language?
or Re-Install as SC?
Thank you

I think switching to a Chinese language pack should be fine. As soon as Windows shows Chinese signs instead of English letters, the language autodetection should trigger. But this only works if sleeks config is being deleted before starting.

@ransome1
will do it later

No hurry, it's getting late here anyway ;)

@nutnutwin, SC has been released with https://github.com/ransome1/sleek/releases/tag/v1.0.5

@ransome1 Thank you. Just one problem, as is mentioned before, "Zoom" in "View" stay English
I didn't find entry in Translation.json
Not a big deal though

@nutnutwin, sorry I kind of missed this. I need to enhance this in the code. Can you provide the two translations here, so I can add them?

@ransome1

SC: "缩放"
JP: "ズーム"(will add in jp/Translation.json) later

@nutnutwin, ok so here are the last entries that havn't been translated into any language besides English yet:
"helpTabKeyboardSubtitle": "When add/edit todo window is open",
"helpTabKeyboardTR13TD1": "Increase/decrease priority",
"helpTabKeyboardTR14TD1": "Remove priority",
"helpTabKeyboardTR15TD1": "Increase/decrease due date",
"helpTabKeyboardTR16TD1": "Remove due date",
"helpTabKeyboardTR17TD1": "Archive completed todo in done.txt"
Would be great if you could provide SC and JP.

"helpTabKeyboardSubtitle": "当显示新建/编辑任务窗口",
"helpTabKeyboardTR13TD1": "增加/减少优先度",
"helpTabKeyboardTR14TD1": "移除优先度",
"helpTabKeyboardTR15TD1": "延后/提前到期日期",
"helpTabKeyboardTR16TD1": "移除到期日期",
"helpTabKeyboardTR17TD1": "将done.txt中已完成任务归档"
@ransome1 let me give you SC first

@nutnutwin, on your personal computer, could you at some point please
1. switch yur OS to Chinese

2. delete sleeks config files (if you're using the zipped one from Github, just delete the "user-preferences.json" in that folder)

3. Start sleek and check if sleeks language detection is actually detecting your Chinese setup or if it falls back to English and has to setup to Chinese manually

OK I did this exactly and the language detection didn't work, please see details below

Start with English
delete "user-preferences.json"
Switch Display Language to SC
signout/signin to take effect
start sleek.exe
stays English

JIC I tried downloading a fresh zip
URL
nothing changed
need some kind of log? (might be human error though)

I think the issue is, that the language detection modules was expecting a locale starting with "cn", but is propably getting "zn" (this is the default locale on OS set to Chinese, right?) delivered from your OS.
I reuploaded the zipped version which is now setup for "zn": https://github.com/ransome1/sleek/releases/download/v1.0.5/sleek-1.0.5-win.zip
Maybe you could give this a try.

@nutnutwin, now that sleek is available in SC, we are basically able to widen the audience accordingly. As of now only a small percentage of sleeks users are Chinese and I wouldn't mind changing this. But I must admit, I have not a lot of knowledge on Chinese (open source) app distribution. Are you aware of important Chinese app platforms which might be interesting to focus on?

I think the issue is, that the language detection module was expecting a locale starting with "cn", but is propably getting "zn" (this is the default locale on OS set to Chinese, right?) delivered from your OS.
I reuploaded the zipped version which is now setup for "zn": https://github.com/ransome1/sleek/releases/download/v1.0.5/sleek-1.0.5-win.zip
Maybe you could give this a try.

did try

got a clean download
switch the display language to SC
boot sleek.exe
sleek UI in SC
@ransome1

Just to double check: You are confirming that on your PC set to SC, a fresh copy of sleek (with no previous configuration file) is loading the Chinese translations on first app start, correct?

I think the issue is, that the language detection module was expecting a locale starting with "cn", but is propably getting "zn" (this is the default locale on OS set to Chinese, right?) delivered from your OS.
I reuploaded the zipped version which is now setup for "zn": https://github.com/ransome1/sleek/releases/download/v1.0.5/sleek-1.0.5-win.zip
Maybe you could give this a try.

did try

got a clean download
switch the display language to SC
boot sleek.exe
sleek UI in SC
@ransome1

Just to double check: You are confirming that on your PC set to SC, a fresh copy of sleek (with no previous configuration file) is loading the Chinese translations on first app start, correct?

Yes

a fresh copy of sleek (with no previous configuration file)
I redownloaded, so I do not have to deal with configuration file(to avoid human error)
@ransome1

@nutnutwin, now that sleek is available in SC, we are basically able to widen the audience accordingly. As of now only a small percentage of sleeks users are Chinese and I wouldn't mind changing this. But I must admit, I have not a lot of knowledge on Chinese (open source) app distribution. Are you aware of important Chinese app platforms which might be interesting to focus on?

I totally agree.
Unfortunately, I have no expertise on publicizing/marketing apps to specific user group(OS Engineer here)
But I would take this chance to see who might be interested in text based ToDo management
(in my case,

dont have access to common apps in company
hate company apps(GSuite/Outlook
prefer text(easy to backup/snap, customizable

Might write a few blogs somewhere in SC platforms...it will take some time though

@nutnutwin, that would of course be amazing! But don't get me wrong, I don't want you to push into things you have no time for doing to. In fact with my initial question I was referring to Chinese app stores (in the likes of Snap Store, Windows Store, Flathub) or websites that mirror the Github (like SourceForge), that my European kind isn't aware of.

@ransome1 Great
I wasn't aware of your Timezone though,
me in JST(+9hour from UTC)

@nutnutwin the last issue of this (Input placeholder and values were shorten) should be solved in https://github.com/ransome1/sleek/releases/tag/v1.1.0-rc.4
We might be finally able to close this issue :) Looking forward hearing your feedback.

@ransome1
I downloaded the version specified and it looked like this.
Will try the newest one later
(sorry didn't see the notification

@nutnutwin is this Windows on your screenhsot?
If so could you double check the version? This is what the 1.1.0 looks like on my Windows 10 VM:

@ransome1
https://github.com/ransome1/sleek/releases/download/v1.1.0/sleek-1.1.0-win.zip
I tried this one it worked
Thank you for the work so far


[fix] Fix permalink for 132/response-unknown-fields

Fixes #410.

Unit tests failed???

Shall we add a meta check for this kind of typos?

Yes, but I see no reason to block this PR on it (as you did not either).


Always use callback; Fix on-the-fly install [BREAKING]

This pull request includes two major fixes:

start_server always resolves/errors using the provided callback function (breaking change) (see #12)
Fix "on-the-fly" MongoDB server installation, when requesting a custom MongoDB version (see #30)

It also improves error handling for a bug in mongodb-download (see e1b03861a2cb6b0f17353027fe618bc26fa47d44)

@winfinit -- do you have interest in this?
My forked version of this project is being used somewhat heavily by my company. Would you be interested in inviting myself (or all of AerisWeather on as collaborators, so we can continue to help maintain it?

@eschwartz I am interested, but it is a project that I am looking at on my free time. Issue with this, as with everything else, it is not that this projects isn't working, it is working for me also, it is not working for some people due to various reasons.
that said, if you are interested to help, absolutely, but I would need someone who would be committed to fix not just "his/her stuff" but understand others requirements, and make sure we don't break anything for anyone else.
every pull request that i am getting, is not simply getting merged because I do want to understand what is being fixed, and if it is going to break anything for others.

I am interested, but it is a project that I am looking at on my free time

I completely understand, which is why I offered to help :)

because I do want to understand what is being fixed, and if it is going to break anything for others.

That's the problem on my end -- I don't totally understand everything going on in this library, and I don't have any great way to test that all behavior still works, besides running my own use cases against it. All I can say with this update is that I tried hard not to break any previous behavior (though, as I mentioned, there are breaking changes to the interface)

but I would need someone who would be committed to fix not just "his/her stuff" but understand others requirements,

So far, all the work I've done on this has been on my company's dime. To be honest, there's probably not going to be any appetite for working on Github issues that aren't directly related to what we're trying to accomplish.
On the other hand, there is work that we're doing on our forked repo that could get merged into a single place, and which could potentially help other users of the repo.
Maybe this is better as a pull-request-relationship for now, but I just thought I'd bring it up...

@eschwartz I gave you access to merge things yourself, just be nice to roll stuff back if someone complains :)
most of my time with this project is taken by various bugs in very specific environments, for example, I am running OS X, and i have few CentOS and RHEL boxes for my projects, so that is not a problem to test, however i don't have windows machine, so someone reported fork option not available on mongod on windows (i would think they would mimmic somehow that behavior, by creating a service or something ...), so I would have to find windows machine, test it, and figure out how to provide similar behavior, same goes for every CI environment that this project isn't working on...

Throwing out there that I was about to open an issue about several bugs before I saw this PR, which addresses them (though it looks like it still has the curious behavior of callbacks whose err arg may be populated yet not actually an instance of Error). Any chance of this getting merged, or if not, might eschwartz’s fork be published?

@winfinit gave me access to the repo, to merge these changes in. I just haven't had time to do it yet.

guys, there was a complete rewrite of this project and mockgoose, so I am closing this pull request