with_structured_output not working for Llama 3.1 models + converse

Thanks for adding tool/with_structured_output support to ChatBedrockConverse!
It is working great for models like mistral_large. However, the Llama 3.1 models don't work with with_structured_output, and  always return a plaintext message with ChatBedrockConverse. These models support with_structured_output on other langchain providers (groq, Ollama), and the raw models support tool calling, so they should work here as well?
There are no errors when calling with_structured_output, but the text returned in plaintext not json/tool call, and the response dict never has a "parsed" entry, just raw return.
I've tried 3.1 8B and 70B, neither works (and both works on the other platforms mentioned).
AWS docs confirming these models should support tool use: https://docs.aws.amazon.com/bedrock/latest/userguide/conversation-inference.html
Thanks

with_structured_output doesn't seem to work for me either for the following tested model:

anthropic.claude-3-sonnet-20240229-v1:0
anthropic.claude-3-5-sonnet-20240620-v1:0
anthropic.claude-3-haiku-20240307-v1:0
mistral.mistral-large-2407-v1:0
meta.llama3-1-70b-instruct-v1:0
cohere.command-r-plus-v1:0

(took me a bit to realize as I have a gpt4o-mini fallback)
ParamValidationError('Parameter validation failed:\nInvalid length for parameter toolConfig.tools[0].toolSpec.description, value: 0, valid min length: 1')Traceback (most recent call last):
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/langchain_core/language_models/chat_models.py", line 624, in generate
    self._generate_with_cache(
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/langchain_core/language_models/chat_models.py", line 846, in _generate_with_cache
    result = self._generate(
             ^^^^^^^^^^^^^^^
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/langchain_aws/chat_models/bedrock_converse.py", line 445, in _generate
    response = self.client.converse(
               ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/botocore/client.py", line 565, in _api_call
    return self._make_api_call(operation_name, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/botocore/client.py", line 974, in _make_api_call
    request_dict = self._convert_to_request_dict(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/botocore/client.py", line 1041, in _convert_to_request_dict
    request_dict = self._serializer.serialize_to_request(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/eppick/projects/long_writer/.venv/lib/python3.12/site-packages/botocore/validate.py", line 381, in serialize_to_request
    raise ParamValidationError(report=report.generate_report())
botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid length for parameter toolConfig.tools[0].toolSpec.description, value: 0, valid min length: 1

Langsmith trace for Claude Sonnet 3 (same error for all models): https://smith.langchain.com/public/1ba1a190-b1c5-447b-9883-9e17277966b1/r
I also included all my depedencies:
dependecies.txt

@CyranoB  "mistral.mistral-large-2407-v1:0" works for me. Are you using ChatBedrockConverse on the latest version of the library?

I found the issue, I was using langchain_core.pydantic_v1 BaseModel (like in the langchain doc) instead of typing_extensions TypedDict (like in langchain-aws test case).
The following code words (including with meta.llama3-1-70b-instruct-v1:0)
class Division(TypedDict):
    name: str = Field(description="The division name (e.g Chapter 1, Section 1.1, etc...)")
    description: str = Field(description="one sentence description of the division")
    instructions: str = Field(description="A few sentences of instructions on what to write for this division and in what style")
    word_count: int = Field(description="The word count of the division")

class Outline(TypedDict):
    title: str = Field(description="A title for the writing")
    divisions: List[Division] = Field(description="The list of divisions")
...
model = ChatBedrockConverse(model="meta.llama3-1-70b-instruct-v1:0", temperature=0)
structured_planing_llm = model.with_structured_output(Outline)
query = "I need to write a report on the history of the internet"
prompt = load_prompt("prompts/build_outline.yaml").format(query=query)
outline = structured_planing_llm.invoke(prompt)

Interesting. I'm using json schema. Seems like it's not fully working with standard APIs? Will try that.

Could you post the version of the code using BaseModel that isn't working? That sounds like a bug

Amazon must have fixed this. Same test cases that failed last week now pass!


switch(remainder) case 2 & 3 in 32-bit appears to not modify hash

In the JavaScript function library.x86.hash32, the switch(remainder) statement at line 243 modifies k1 in  each case. However, for case 3 and 2, h does not appear to be modified by k1 before exiting the function (in case 1, it is clearly modified).
What am I missing?

Unsure what I saw previously, so I'm closing this issue as it seems k1 is indeed modified in each case.

Unsure what I saw previously, so I'm closing this issue as it seems k1 is indeed modified in each case.


[Loc] Fix for localization in constants and updated notebook and sql-…

…database-projects

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 41.669%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
26431

Relevant Lines:
57452

💛  - Coveralls


Elm 0.19?

Hey hey, I’m the greatest fan of linter-elm-make – it was one of the main reasons why I switched back from VS Code to Atom! Massive thank you for all the hard work you’ve put into this module.
Do you have plans to upgrade linter-elm-make to support Elm 0.19? Right now attempting to open an Elm 0.19 project results with this:

And man, Elm 0.19 is such a tremendous improvement! Super fast incremental builds are especially useful for linter-elm-make – it will feel much faster now!

Hi @architectcodes, it will take lots of effort to support Elm 0.19 since many things have changed.  You can try the latest version of Elmjutsu for error highlighting.
https://github.com/halohalospecial/atom-elmjutsu#error-highlighting


workspace settings does not override specific exclude pattern of global settings

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.80.0
OS Version: x64 W10

Steps to Reproduce:

Exclude all subFF in all node_modules in global settings.json
// it works well and hide all subFF of each node_modules

"files.exclude": {
    "**/node_modules/*/": true
}

Set this exclude to false in workspaces settings
// it works well and display all subFF of each node_modules (so global settings overloaded)

"files.exclude": {
  "**/node_modules/*/": false,
}

Set this exclude to false for specific subfolder in workspaces settings
// it does not works and all subFF of specific node_modules still excluded

"files.exclude": {
  "sub_folder/node_modules/*/": false,
}

I'm able to reproduce this issue on the latest Insiders using the User and Workspace setting.json files.

Settings that have an object form (such as this one) are merged on each level, so if you want to disable a pattern from one layer you need to explicitly repeat it again on that layer set to false.


Update Readme and docs

Add badges: Npm version, tests and coverage status

Remove some irrelevant Thrift-related section from docs

@moderakh  Please also merge - I don't have permissions for that 🙂


CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)

Thanks for the review(s) @jonmeredith - greatly appreciated. Should be all set now.


Import filters from AdGuard Base foreign section

AdGuard Base has a section for Macedonian sites:
https://github.com/AdguardTeam/AdguardFilters/blob/master/BaseFilter/sections/foreign.txt#L5028-L5052
If all of those sites are covered in your list, then a pull request[1] could be sent to remove those filters from AdGuard Base.
[1]: Well actually we should have to wait until your list is officially added to AdGuard (https://github.com/AdguardTeam/FiltersRegistry/issues/354 and https://github.com/AdguardTeam/FiltersRegistry/pull/752).

:wave:  Thanks for the notice!
I copied the filters from AdGuard and added a couple of them that were missing for the target websites.
Everything should be ok now.


Allow multiple output formats

Running this should create each table file three times, with three different extensions:
airtable-export ... --yaml --json --ndjson

The new --yaml option is only needed if you specify at least one other format, since it's the default.

I could setup a demo repository for this.


Test Eclim

Eclim provides the ability to access Eclipse code editing features (code completion, searching, code validation, and many more) via the command line or a local network connection, allowing those features to be integrated with your favorite editor. Eclim provides an integration with Vim.
http://eclim.org/index.html
https://www.youtube.com/watch?v=K4bYiQik6lE
http://www.lucianofiandesio.com/vim-configuration-for-happy-java-coding
https://github.com/ervandew/eclim/releases
wget http://downloads.sourceforge.net/project/eclim/eclim/2.3.2/eclim_2.3.2.jar
java -jar eclim_2.3.2.jar

http://www.stefreitag.de/wp/2015/10/04/java-im-vim/

https://levlaz.org/installing-the-latest-version-of-eclipse-ide-mars-in-debian/

Rejected.
LEAN


Exceptions?

Just a quick question: are exceptions implemented? When I try running a dead-simple program that throws an InvalidOperationException, I get the following output:
Call to an unimplemented runtime method; execution cannot continue.
Method: RhpThrowEx

This makes me think that exceptions are not implemented, yet we have System.Private.StackTraceGenerator, which presumably would be used in creating stack traces for exceptions. If exceptions are not yet implemented, what does that project do?

That is correct - EH is still to be implemented.
CC @smosier

yet we have  System.Private.StackTraceGenerator

We have moved all existing code that we believe will be needed for the project to github. Now, we are working on integrating the parts together. E.g. the same applies to reflection - there is a lot of code related to reflection, but reflection is not functional yet.

Whats the plan here with respect to ModuleHeader?  The current bootstrapped registers a SimpleModuleHeader which does not contain, well, much of anything.  All of the code in the StackFrameIterator and RuntimeInstance seem to presume that all the Module's will have a full ModuleHeader.
I'm happy to pitch in here, but whats the plan of record?

Never mind -- I just saw https://github.com/dotnet/corert/pull/886

The good stuff is actually coming in #851. It should be a list of <section id, start/end> so that we have flexibility about which sections to included in different configs.

This is tracked by #509, #910 and #911.


Feature Request: objectFit: auto-contain, but the other way around

Currently objectFit: auto-contain fits the image by its longer side.
In my case I would like to fit image by shorter side, so it always covers the whole space
vertical-cover or horizontal-cover works exactly as I need, but it requires manual calculations to decide which cover to use.
Current behavior:

Would like a feature to get this behavior:

Did you try the auto-cover option?

I think I get the idea but I struggle to see the expected behavior on your example image. Could you highlight where the image borders are please?

vertical cover won't work for long image

I have to manually change objectFit to horizontal-cover

I guess someone made a PR with the thing I look for. What a blessing :)
https://github.com/ValentinH/react-easy-crop/pull/466

Hi All!
That should be exactly what I was looking for.
Please, take a look at the PR I've created and the sandbox to see live example


R15 Bug

Everytime I open up and use a r15 character it just glitches out.

Have you checked if this happens without Bloxstrap too? https://github.com/pizzaboxer/bloxstrap/wiki/Switching-between-Roblox-and-Bloxstrap

Roblox Player works perfectly fine but when I do it on BloxStrap is just bugs out, I don't know why it just started happened yesterday. I changed no settings and it just bugged on other games too that does r15 animation

I fixed it, It was just a bug with chibi and other games. It needs a restart and change to default settings and leave it for a day for is to correct is self. ty for reaching out though :)


feat(pubsub): reduce contention in lease management

I found that the lease management layer suffered from too much
contention. Basically each ack() and nack() call required a lock, as
the hash map with all the pending messages is updated. After updating
this hash map the code calls the StreamingSubscriptionBatchSource
stage to do more work, which requires additional locking. This PR
collapses the functionality of the SubscriptionLeaseManagement stage
onto StreamingSubscriptionBatchSource, reducing the number of locks
per ack()/nack() call.
These improvements in locking overhead are minor, but collapsing the two
layers simplifies other changes I want to make, such as (1) suspend
Read() calls if the number (and/or size) of outstanding messages is
too high, (2) create multiple AsyncPull streams on the same session, and
(3) maybe avoid copying the large ack_id strings (160 bytes!) and use
a more efficient in-memory representation.
I also simplified the timer management to periodically update the
leases. We use a single periodic timer to check if the leases need an
update, and piggy back the update with any other pending nacks and/or
acks. That is less accurate, but the periodic timer is executed about
100 times a second, and the leases need to be updated every 10 seconds
(we actually do it ever 5). Good enough I think.
Part of the work for #5512 and #5431

This change is

PTAL

I am going to close this for now, I noticed some regressions (increased flakiness) in local testing and cannot seem to be able to fix them. Sorry to waste your time @devbww.


Missing class on FRBRoo [F50, F38]

We added at the end of the file 2 new properties of efrbroo (efrbroo:F38_Character and efrbroo:F50_Controlled_Access_Point). But they are currently not in the efrbroo ontology.
Pierre is going to ask them (opening an issue?).'
Discussion started on #15

Done https://github.com/erlangen-crm/efrbroo/issues/1
the classes are missing in the owl file.

can we close this issue ?

Clearly not, since the DOREMUS ontology still imports the old version of efrbroo.


Update constants

change epoch_start/epoch_stop to train_epoch_start/train_epoch_stop to match spec
update mask-rcnn keys to match spec and place them in alphabetical order

Logging WG: revert the rename, push to next round


Can't get window instance after page load

Hey!
I'm trying to get the window instance after page page.waitForNavigation but the window is undefined.
PAGE_PUPPETEER_OPTS = {
  networkIdle2Timeout: 5000,
  waitUntil: 'networkidle0',
  timeout: 3000000,
};
await page.waitForNavigation({ waitUntil: 'domcontentloaded' });
// await page.waitForFunction(() => window.__NUXT__ !== undefined);
// await page.waitForSelector('#__nuxt');
const windowObject = await page.evaluate(() => {
  return window.__NUXT__;
});

console.log(windowObject);

result is undefined or catching timeout

Please follow https://github.com/rebrowser/rebrowser-patches/issues/13 - it's exactly the same issue.
I'm gonna post a solution for this issue probably this week.

Also page.evaluateOnNewDocument code is never executed. I wonder if it is related problem and will get fixed with fix for page.evaluate() or is it separate issue?

@jarmo-fi evaluateOnNewDocument works fine in rebrowser-patches, so it might be something related to puppeteer-real-browser
cc @zfcsoftware

@nwebson tested rebrowser and looks like it indeed works, but only with env variable
REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable
So this could be also isolation problem.
cc @zfcsoftware

@jarmo-fi Could you please share your code so I can tested it locally?

https://github.com/zfcsoftware/puppeteer-real-browser/tree/access-window
https://github.com/zfcsoftware/puppeteer-real-browser?tab=readme-ov-file#i-cannot-access-functions-in-window-object-what-should-i-do
Hi, I added a branch for this. You can access it using the example there. If I find a better method in the future, I will add it.

@zfcsoftware for me the suggested solution does not work as I need to be able to call a function (which I have injected earlier) in the page.
So for function calling there is no way currently in puppeteer-real-browser? As said, this works fine with  std puppeteer + rebrowser-puppeteer with environment variable REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable.
Maybe something similar could be implemented to puppeteer-real-browser too? I'd prefer to use puppeteer-real-browser as it can access cloudflare sites while rebrowser cannot.
Also I tried to use puppeteer-real-browser side-by-side with rebrowser-puppeteer for my different usecases, but looks like puppeteer-real-browser somehow takes over and the evaluate does not work even when puppeteer is later started by rebrowser
@nwebson my code is way too complicated (and private) to be copied here. But what exact code part you are looking for? In short I launch rebrowser-puppeteer normally and all the evaluate and evaluateOnNewDocument functions work the same as in normal puppeteer. But only if REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable and set before app is launched

https://github.com/zfcsoftware/puppeteer-real-browser/tree/access-window https://github.com/zfcsoftware/puppeteer-real-browser?tab=readme-ov-file#i-cannot-access-functions-in-window-object-what-should-i-do
Hi, I added a branch for this. You can access it using the example there. If I find a better method in the future, I will add it.

Sorry, but i dont understand this use case. What javascript i must add to access it? In my page i also have javascript that is nuxt in script tag. I have access to it in Devtools like so:

but not when using puppeteer-real-browser

@zfcsoftware for me the suggested solution does not work as I need to be able to call a function (which I have injected earlier) in the page.
So for function calling there is no way currently in puppeteer-real-browser? As said, this works fine with std puppeteer + rebrowser-puppeteer with environment variable REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable. Maybe something similar could be implemented to puppeteer-real-browser too? I'd prefer to use puppeteer-real-browser as it can access cloudflare sites while rebrowser cannot.
Also I tried to use puppeteer-real-browser side-by-side with rebrowser-puppeteer for my different usecases, but looks like puppeteer-real-browser somehow takes over and the evaluate does not work even when puppeteer is later started by rebrowser
@nwebson my code is way too complicated (and private) to be copied here. But what exact code part you are looking for? In short I launch rebrowser-puppeteer normally and all the evaluate and evaluateOnNewDocument functions work the same as in normal puppeteer. But only if REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable and set before app is launched

https://github.com/zfcsoftware/puppeteer-real-browser/tree/access-window https://github.com/zfcsoftware/puppeteer-real-browser?tab=readme-ov-file#i-cannot-access-functions-in-window-object-what-should-i-do
Hi, I added a branch for this. You can access it using the example there. If I find a better method in the future, I will add it.

@zfcsoftware Sorry, but i dont understand this use case. What javascript i must add to access it? In my page i also have javascript that is nuxt in script tag. I have access to it in Devtools like so:  but not when using puppeteer-real-browser

I added a new test, please check it. It is possible to access the whole window object with the related method.
https://github.com/zfcsoftware/puppeteer-real-browser/blob/access-window/success2.js
https://github.com/user-attachments/assets/b31df979-d783-4a33-a4f8-331f0345db41

@zfcsoftware I added a new test, please check it. It is possible to access the whole window object with the related method.
https://github.com/zfcsoftware/puppeteer-real-browser/blob/access-window/success2.js

Your code seems to inject function to the page to store some value to field. And the field + value is then accessible using evaluate function. But I still do not see how to call a JS function in page from node. I am not looking to get any values from the page but specifically I have to call JS function several times in a row AFTER the page have loaded and the Cloudflare tests are passed.
And as I said, this works fine in normal puppeteer and in rebrowser-puppeteer with REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable env variable.
Any possibility to get such REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable functionality to the puppeteer-real-browser? This would be great as then it could be used as real replacement for puppeteer
Attached are my samples
One for puppeteer - tests pass + console logging works
One for rebrowser-puppeteer - no console logging, but tests pass if I start it like this:
export REBROWSER_PATCHES_RUNTIME_FIX_MODE="enableDisable"; node functiontest-rebrowser.js
And one for puppeteer-real-browser - tests fail + no console logging
It would be really great to get this working. As we can see it should be possible the same way as rebrowser does it.
tests.zip

REBROWSER_PATCHES_RUNTIME_FIX_MODE

REBROWSER_PATCHES_RUNTIME_FIX_MODE I'll update REBROWSER_PATCHES_RUNTIME_FIX_MODE to changeable, I think that should solve your problem.

I get it, now it's working. Thanks)

REBROWSER_PATCHES_RUNTIME_FIX_MODE

REBROWSER_PATCHES_RUNTIME_FIX_MODE I'll update REBROWSER_PATCHES_RUNTIME_FIX_MODE to changeable, I think that should solve your problem.

@zfcsoftware Yes, I think so. Please let us know when this code change is in place. Looks like very small change to set the environment variable REBROWSER_PATCHES_RUNTIME_FIX_MODE only if it is not already set

@zfcsoftware when i use createCDPSession with proxy i'm getting Error: net::ERR_INVALID_AUTH_CREDENTIALS

I would suggest using REBROWSER_PATCHES_RUNTIME_FIX_MODE=alwaysIsolated as it's more secure and stable.
📣 I just made a post how to access main world objects from isolated context, please read it here: How to Access Main Context Objects from Isolated Context in Puppeteer & Playwright
ℹ TLDR: use page.evaluateOnNewDocument to listen for window messages and eval code, use page.evaluate to send window message with your payload and get response from the main world.
It worked just fine for several clients of mine, please let me know (discord or here) if it doesn't work for you.

@nwebson Thanks for the article! This looks very interesting. I will check and test how to use this logic.

@nwebson This works nicely. Thanks!
@zfcsoftware So no need for me REBROWSER_PATCHES_RUNTIME_FIX_MODE=enableDisable
Are Events safer than somewhat simpler BroadcastChannel for bot detection?

@nwebson I'm new to this and didn't understand how to use your approach to get window.__NUXT__. Can you please give some examples.

@jarmo-fi I'm glad it worked! 🎉
@pwnz22 just use the code from the article, but instead of
await page.evaluate(() => window.evaluateMain(() => document.getElementsByClassName('div'))

use
await page.evaluate(() => window.evaluateMain(() => window.__NUXT__)

@nwebson It's working. Many Thanks)


How can I create the address if I want to share it later? (probably not a showstopper)

Currently when I press "Receive" the address will be created only if I share it somehow right now. If I wanna use that address later I need to tap "Share" and then tap "Copy" or actually share it somewhere. Maybe there should be an easier way to create an address without sharing.

Updates screes here:
https://app.zeplin.io/project/5c73dc8aa74b4b4085a86a91/dashboard?seid=5ce2394739f2e51e01fd8c6f
If user only opened screen and didn't do anything at all and used back button address shouldn't be created.
If user made some changes on the screen and used back button show that alert https://zpl.io/2jMW6BO
Tap on "Close and save address for later" button should bring user back to the previous screen (address created and saved).

no alert

If user only opened screen and didn't do anything at all and used back button show this alert https://zpl.io/2jMW6BO

checked


Allow clients to send custom HTTP headers

To send custom HTTP headers, add the option :headers to the request. For example:
# With no headers (default)
client.hello(name: "World")

# With custom request headers
client.hello({name: "World"}, headers: {"X-Auth-Foo": "xfdsa", "My-Header": "foobar"})

It is also possible to set the 'Content-Type' header to send a single JSON request from a Proto client and vice-versa.
client.hello(name: "World") # uses application/protobuf by default
client.hello({name: "World"}, headers: {'Content-Type': 'application/json'}) # makes a JSON request

❤


netlify: fix build

Work around https://github.com/sphinx-doc/sphinx/issues/5417.
Testing: I wonder if the right tox is being used?

Nope...


Justified Text for Images

Severity (0-4)
Heuristic Transgressed/Supported
Where in the interface/application
Issue
Remedy

3
Accessibility & Consistency
Technical interests section - Image alt texts
Alt text tags contain redundant "Logo" suffix and some images have accessibility warnings
Remove redundant "Logo" suffix from alt texts and ensure all images have proper descriptive alt texts

2
Visual Design & Layout
Technical interests section - Text alignment
Text is not properly aligned and has inconsistent spacing
Adjust CSS to ensure consistent text alignment and spacing in cards

2
Feedback & Visibility
Technical interests section - Images
Some images have broken or incorrect aspect ratios
Standardize image sizes and maintain aspect ratios using CSS object-fit

1
Consistency
Technical interests section - Text formatting
Inconsistent use of colons and text formatting in descriptions
Standardize text formatting and remove unnecessary punctuation


Turn speaker on

First of all thanks for this plugin.
Is it possible to start a call with speaker switched on automatically?

Sorry for Delay on replay. Thank you.
Let me check and add a feature to call with speaker option.

Added The Features & Tested on Android. Unable to Test with iOS.

@Seblon1 I don't have time to complete it currently i have completed the Speaker-On. If you need any feature let us know.


CVE-2024-21538 cyberchef

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
CVE-2024-21538

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[SPARK-37827][SQL] Put the some built-in table properties into V1Table.propertie to adapt to V2 command

What changes were proposed in this pull request?

put the build-in properties into CatalogTable when store in InMemoryCatalog exclude HiveExternalCatalog.
filter the build-in properties when ShowTablePropertiesCommand ShowCreateTableCommand DescribeTable ShowTableProperties

Why are the changes needed?
#discuss
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add ut testcase and existed ut testcase.

@cloud-fan @imback82 @huaxingao Could you take a look? Thank you very much.

thanks, merging to master!


what's the structural thought of portia's server-side?

Hi, can you just describe the structural thought of portia's backgroud  , e.g.  what's the relatiionship between slybot and slyd ?

 It has some other endpoints, one of which is used for extracting data. This is done by loading up the requested spider and requested page and then extracting data from that page using slybot.
Slybot is the part that also extracts data and follows links during a crawl.


add WLR_USE_XDG_DIR option

This patch add a option to toggle between XDG_RUNTIME_DIR and "/dev/shm".
If wlroots run inside a strict snap, they didn't have access to "/dev/shm".

I'd prefer not to merge this. Instead, I'd suggest you add /dev/shm to a whitelist.

I'd prefer not to merge this. Instead, I'd suggest you add /dev/shm to a whitelist.

Or alternatively snap should have options to bindmount/symlink another directory or mount a tmpfs for that path.

Mounting a tmpfs of "/dev/shm" didn't work at the current snapd implementation:
error: cannot validate snap "sway": layout "/dev/shm" in an off-limits area
A whitelist would be very wlroots-specific and also requires some patches for the snap daemon.
It would be best if you could configure the temporary directory in wlroots. E. g. with Environments Variables.

I consider this being a snap bug.

Who even runs a Wayland compositor in a snap in the first place?

@ddevault
It's for a kiosk system.

And?


Remove Clickoutside

NOTE: This PR is incomplete and more of a proof of concept.
Clickoutside is not native and does not play nice with any clicks that invoke stopPropagation. This is especially apparent when using react-select and react-datepicker on the same page.
Instead of refocusing after every blur of the datepicker input and only hiding the calendar onClickOutside, we can hide the calendar when the datepicker is blurred except in the case where the blur is caused by a calendar mousedown where we set a flag that tells the datepicker to refocus and continue to show the calendar.

oops, i meant to open this on my own fork


fastboot mode

How do I know if my device is in adb or fastboot mode? Thank you very much

fastboot is not officially supported: https://github.com/yume-chan/ya-webadb/issues/343
The only difference I know is the first part (pieces[0]) in banner:
https://github.com/yume-chan/ya-webadb/blob/b920c72e6b7e41fe7cd8aa2832fc617ab9ba9f96/libraries/adb/src/banner.ts#L17-L19
ADB daemon returns device and recovery mode returns rescue or sideload


Move require gli from bin/hook to lib/hook.rb

markdown_document_listener uses code from gli, so without this, you can't require hook as a library without having to require gli yourself.

Thanks for all the help. I've merged all PRs and pushed a new gem.

Thanks, appreciate it, and this gem!


Cannot install 1.3.0 via conda,  HTTP 000 CONNECTION FAILED

Cannot install by using conda install -c plotly plotly-orca due to connection error...

@hongchaopan this is surprising: it currently works for me. Can you make sure your network settings are correct?


bedrock players not having a valid uuid

Description
i use geyser and floodgate and it has a . in front of their name so when i tried to add them to a group they dont have a valid uuid so i cant add them to a group.
Reproduction Steps
do /lp user .Rock_Duck_84 group add all
then it says not a valid uuid
Expected Behaviour
add player to group
Server Details
Previous version: git-Paper-349 (MC: 1.19.3)
LuckPerms Version
not sure
Logs and Configs
No response
Extra Details
No response

Set allow-invalid-usernames: true in config.yml


DOCS-3465 Android Data Collected Edit

What does this PR do?
Removes the country_subdivision_iso_code facet.
Motivation
RUM Docs Slack
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #921 (7ab07c7) into master (efbe62a) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   83.08%   83.01%   -0.07%
==========================================
  Files         267      267
  Lines        9047     9047
  Branches     1453     1453
==========================================
- Hits         7516     7510       -6
- Misses       1137     1141       +4
- Partials      394      396       +2

Impacted Files
Coverage Δ

...ndroid/core/internal/persistence/file/EventMeta.kt
80.00% <0.00%> (-10.00%)
:arrow_down:

...droid/rum/tracking/FragmentViewTrackingStrategy.kt
82.61% <0.00%> (-4.35%)
:arrow_down:

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
87.93% <0.00%> (-0.57%)
:arrow_down:

...rc/main/java/com/datadog/opentracing/DDTracer.java
55.65% <0.00%> (-0.42%)
:arrow_down:


debugging 'unknown error'

Hi, I recently started getting 'unknown error' with a questionmark in the label over the notifier icon.
I have no clue where to look for more detailed information so I can either fix it or update you guys with a more precise problem to fix :)
any ideas on where to look or how to debug this thing?

@saelfaer
The "Unknown error" comes from switch statement in main.js
That would be a place to start I guess.

I'm getting this error too, and my api key is definitely correct.

Also happens for me every time my pc boot up again from sleep mode. I have to click on the icon before it starts checking again.

Ah that makes sense. I have a laptop so I'm constantly putting it in sleep mode. It would be nice if this error could be fixed though.


Fix typo in sojourner3 badge name

Hey, just a quickie typo fix.

Fixed by #31. Published as 0.13.1


Allow for Account.SignTxns(params T[] txns)

There's currently (in version 2.2.0 at least) only Acount.SignTxns(T[] txns) and it would be more convenient to have it with the params keyword like it's being used througout the SDK.

On this note, is it somehow possible to use the params T[] for different types of transactions at once or is it intended to be used only with the same transaction type?
For example, you have a PaymentTxn and one AppCallTxn, then you have to call TransactionGroup.Of(payTxn.GetId(), appCallTxn.GetId()).GetId() instead of just TransactionGroup.Of(payTxn, appCallTxn).GetId(). That is because T requires to be ITransaction and IEquatable<T>.
I did a quick google search but I couldn't find anything about making this possible and my C# skills are to limited to figure something out on the get-go 😀

There is a simple way to do that (but causes allocations), cast them to ITransaction interface:
public byte[] SignTxns(params ITransaction[] txns);

There is another way using generics and type args that won't cause allocations, but there is a limit to the number of transactions supported (there's an upper limit of 16 transactions per group anyway)
public byte[] SignTxns<T0, T1, ..., TN>(T0 txn0, T1 txn1, ..., TN txnN)
    where T0 : ITransaction
    where T1 : ITransaction
    // ...
    where TN : ITransaction
{
    // create an array of transaction ids and add them one by one...
}

And perhaps also an option to allow for a custom group id with SignTxns? There's a place in the auction demo where 3 transactions are being sent with the same group id but with 2 different accounts.

The SignTxns should  just sign only the transactions that they can sign. At the moment you'd have to combine them:
var txns = new Transaction[3] { /* my txns */ };
var signedByAcct1 = acct1.SignTxns(txns);
var signedByAcct2 = acct2.SignTxns(txns);

var signedTxns = new SignedTxn[3];
for (var i = 0; i < txns.Length; i++)
{
  signedTxns[i] = signedByAcct1[i].Sig.Equals(default)
    ? signedByAcct2[i]
    : signedByAcct1[i];
}

Maybe to make this easier in the meantime, I could add SignedTxn.IsSigned property?
Ideal API?
If we can get a consistent interface across all IAccount, then we could do the following:
Account acct = /* my account */;
KmdAccount kmdAcct = /* kmd account */;
WalletConnectAccount walletConnectAcct = /* WalletConnect account */;

var txnGroup = TxnGroup.Of(assetOptInTxn, assetTransferTxn, payTxn);
var signedTxnGroup = await txnGroup.SignBy(acct)
  .SignBy(kmdAcct)
  .SignBy(walletConnectAcct);

algod.SendTransaction(signedTxnGroup);

If you need to share the TxnGroup across different clients, then you implement your own IAccount interface.

The SignTxns should sign only the transactions that have Sender == Account.Address.

So you basically have to always pass all the transactions to both signers and it'll only sign the ones the signer cares about. This works fine if you do it that way, but if you're not always passing all the transactions to the signers, then you'd end up with different transaction group id from what I can see.
That's how the func looks right now and it would just disregard whatever group you assigned beforehand if you did so.
public SignedTxn<T>[] SignTxns<T>(T[] txns) where T : ITransaction, IEquatable<T>
{
    TransactionId id = TransactionGroup.Of(txns).GetId();
    SignedTxn<T>[] array = new SignedTxn<T>[txns.Length];
    for (int i = 0; i < txns.Length; i++)
    {
        T txn = txns[i];
        txn.Group = id;
        array[i] = (txn.Sender.Equals(Address) ? SignTxn(txn) : new SignedTxn<T>
        {
            Txn = txn
        });
    }

    return array;
}

This might cause some troubles for some people and perhaps it'd be good to check if the group id is already assigned and not take care of the group id? But I like your ideal API example, it looks like a good approach!

This works fine if you do it that way, but if you're not always passing all the transactions to the signers, then you'd end up with different transaction group id from what I can see.

There's a security reason it's like this for WalletConnect. If you give the wallet a transaction that doesn't have the full group, and the wallet assumes that the group id is correct, then you can fool the wallet into believing you're going to send a transaction.
Account is a local signer, but it has this interface only because I'm trying to keep the API similar between different types of accounts. Probably would be clearer if it was named SignTxnGroup instead of SignTxns. If you want to manually assign group id, it's easy to do that via SignTxn. It will not replace the existing transactions:
// if you're concerned about allocations, you can use Linq faster: https://github.com/jackmott/LinqFaster
using System.Linq;

var signed = txns.Select(account.SignTxn).ToArray();

I see, that makes sense. Yea, warnings are always good! :)

@bernhardrieder hey there, just wanna say that I moved this issue into a project in the @CareBoo org. I'm planning this ticket for a Version 3 release using the Ideal API. You should be able to see the progress in that board.
I'll be using that board going forward for planning.

Blocked by #130

duplicate of #131


Running mriqc on QSM data

Hi there,
I'm trying to use mriqc to run quality checks (specifically signal-to-noise) on quantitative susceptibility mapping data. I'm using docker to call the mriqc functions, and it appears to be working. However, I am not getting any output, and I figured this was due to the type of data I am running. Is there a potential workaround for this?
Thank you in advance

Hi @ChristiEssex, I'm not positive it will work very well on QSM data. Unless you have made some effort to disguise the input as T1w or T2w images, I presume MRIQC is just not finding any workable images.
What is the structure of the data you are passing in?

Closing due to lack of activity. Please reopen if necessary.


Return transaction stub if no current transaction

Return a stub that accepts any method call instead of nil. This makes it safe to call methods on the current transaction regardless of wether AppSignal is active.

:+1:


Login needs to be fixed

User is able to enter with any user name and password.

you need to create new table users in database having unique usernames and password coulmns in it.Also, do the neccessary changes in signup code to collect the username and password.


3/09/21

I am learning Continuous Integration (CI).

11/22/2023 I am learning Continuous Integration (CI).


fix: switch version error

An error occurred when switching the element-plus version.

@sxzz Please review this code, thanks!


Combine datamap UI redux store with admin UI's store

Is your feature request related to a specific problem?
As we open source datamap UI by merging it with admin UI, they will need to merge their redux stores.
Describe the solution you'd like
Most of the redux slices can likely just take admin-ui’s version, except for datamap.slice.ts
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Blocked by https://github.com/ethyca/fides/issues/2975

moving to done


where is the welcome page?

Issue Type: Feature Request
The welcome page is not showing
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 10.0.17134

'Help > Welcome' opens it and on the page there is a checkbox at the bottom left to have it open automatically on startup.


Some cleanups

The first commit monomorphizes add_system_inner which I think was intended to be monomorphized anyway. The second commit moves the type argument of GraphNode to an associated type.

Solid improvement. One thing to note is that this is a public API change and will likely have to be mentioned in future migration guide/changelog.

bors r+


fix: add missing --block option to cast age examples

The examples of the cast age reference show non working commands due to the missing --block option. This commit fixes them.

closing this since cast age no longer requires --block argument


HPA docs for Rancher 2.6 is not available

Rancher 2.6 does not have HPA doc page updated.
To navigate to that page, you can click on How-to Guides --> New User Guides --> Kubernetes Resources Setup --> Horizontal Pod Autoscaler
You can also click on this link which takes you to that page.

Closing as duplicate of #26.


Radius Not Valid

While trying to add a location on the map it does not allow me to enter any information.  Every number I try (even if I hit the up or down arrow) returns "Radius not valid".

  Must be over 100m....

lol got us both


feat(issue-557): adding descriptions for build triggers

Issue: #557  Adding more color to what each build trigger does.
To reproduce:

Execute full script sh setup.sh or solely delivery (if you have a working version of Emblem already set up) scripts/configure_delivery.sh to update terraform google_cloudbuild_trigger resources
After full deployment, you should see the descriptions for each trigger updated like so:

Thanks @rogerthatdev!


[FR] Third Party Licenses

Generate the Third-Party-License file:
https://www.mojohaus.org/license-maven-plugin/add-third-party-mojo.html

See also: https://www.versioneye.com/ .


make tesla brighter

About the PR

I propose making tesla and small balls lightning brighter.
From testing out, any pop-ins at all due to pvs are very rare and small.
Why / Balance

Super spooky, good. And it's a giant ball of lightning after all!
Media
https://github.com/user-attachments/assets/687a0e84-80a7-4ba4-8291-f7e3446f5c9e
tesla and miniballs difference

made mini ball slightly brighter too

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Made tesla a lot brighter.

Moth players on their way to suicide to tesla ball

бля чё это за говно ебаное


enable github projects feature

https://lists.apache.org/thread/cx3t7g9rs44tchoz4jytb74sdtlq16zk

Funny coincidence: Just today we created a project wit the new GitHub projects features for Play.
Have a look here: https://github.com/orgs/playframework/projects/3/views/1
Also, since like 2 days "GitHub Roadmaps" is in public beta: https://github.blog/changelog/2023-01-31-roadmap-in-projects-public-beta/
You can see an example if you click on "Roadmap" our project for Play 2.9.
Just wanted to mention this here since I was just checking this out myself today :wink:


build: Set up tests

This PR sets up Jest for testing and adds an initial test for buildCollectionFullName.
It also includes a number of additional improvements:

Add more type definitions for Zotero
Move preferences related code into new prefs directory
Bump @dvanoni/zotero-plugin to avoid copying tsx, .DS_Store, and __test__ files

@SocketSecurity ignore<EMAIL_ADDRESS><EMAIL_ADDRESS>


Generate new bindings

Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[ ] All commits in this PR have Signed-Off-By trailers (with
git commit -s), and the commit message has max 60 characters for the
summary and max 75 characters for each description line.
[ ] All added/changed functionality has a corresponding unit/integration
test.
[ ] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[ ] Any newly added unsafe code is properly documented.

@russell-islam Generate for ARM64 too and check it builds

@russell-islam Generate for ARM64 too and check it builds

I did and it build fine.

@russell-islam Generate for ARM64 too and check it builds

I did and it builds fine.

Add the new ARM64 bindings to this PR


Extract IBC queries paths into conditional modules

Since these paths currently differ between the Go implementation
and the ICS, we need to be able to switch them up at compile-time
for when we will need to test against the Go implementation.

Closes: N/A
Description
Since these paths currently differ between the Go implementation
and the ICS, we need to be able to switch them up at compile-time
for when we will need to test against the Go implementation.

For contributor use:

[ ] Wrote tests
[ ] Updated CHANGELOG_PENDING.md
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@db92c72). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master     #24   +/-   ##
========================================
  Coverage          ?   17.7%
========================================
  Files             ?      26
  Lines             ?     428
  Branches          ?      36
========================================
  Hits              ?      76
  Misses            ?     325
  Partials          ?      27

Impacted Files
Coverage Δ

modules/src/path/ics.rs
0% <0%> (ø)

modules/src/path/cosmos.rs
0% <0%> (ø)

modules/src/path.rs
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db92c72...a3792b7. Read the comment docs.


Slide preview thumbnail

Is it possible to get a thumbnail of the next or previous slide, which I can then display on the slider
Something like https://dl.dropboxusercontent.com/u/26243182/owl-preview.png

+1

+1


Release Paketo Go buildpack

Release in the week of May 17th if relevant changes or dependency updates are merged.
What steps did you take to close this issue? What resources did you use? How long did you spend on this task this week? Answer in a comment.

Released v0.7.0

In an effort to de-clutter the project board, we are moving away from recurring issues such as this one. This task will instead  be added to a checklist of tasks to be completed on a weekly basis.


enable mergify for scala-steward PRs

Codecov Report

Merging #246 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   83.85%   83.69%   -0.16%
==========================================
  Files         107      107
  Lines        1251     1251
  Branches       22       22
==========================================
- Hits         1049     1047       -2
- Misses        202      204       +2

Impacted Files
Coverage Δ

...ules/core/src/main/scala/net/BitVectorSocket.scala
77.77% <0.00%> (-11.12%)
:arrow_down:

...ore/src/main/scala/net/BufferedMessageSocket.scala
92.30% <0.00%> (-3.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec89f66...b07e180. Read the comment docs.


DOCS: Adopt autoapi v3 for our API doc generation.

📚 Documentation

We currently use apidoc for our API Docs, which look like this: https://scitools-iris.readthedocs.io/en/latest/generated/api/iris.html.
Autodoc headline:

Sphinx AutoAPI is a Sphinx extension for generating complete API documentation without needing to load, run, or import the project being documented.
In contrast to the traditional Sphinx autodoc, which requires some manual authoring and uses code imports, AutoAPI finds and generates documentation by parsing source code.

I have locally trialed using autoapi which generally is:

presented better
uses the autosummary for modules and classes (table summary)

There is a build warning that can be resolved with some investigation but the main issue blocking the adoption is the use of inline comments to document attributes using #: str: this is a comment before the attribute is defined.  autoapi works using the triple quotes after the attribute is defined but this would mean changing lots of comments already present and it is limited to a single line.
Lets watch https://github.com/readthedocs/sphinx-autoapi/issues/344 to see if support for #: comments is added, if so we can look at adopting autoapi.

@tkknight Should this pull-request be in draft?

@tkknight doh! my mistake, this is an issue, all good 😆


[CMSIS-NN] enable USMP with CMSIS-NN

This commit mainly enables the USMP with CMSIS-NN codegen.
In order to do that, CMSIS-NN functions needed to contain BufferMaps. This commit adds the necessary BufferMaps as well.
All the tests are modified to run with USMP while the networks tests run with and without USMP.

This is blocked on #10022

Friendly ping for reviews! @ekalda @lhutton1 @ashutosh-arm @leandron

Thanks @manupa-arm. I suppose it was already in a good state to be merged :)

cc : @Mousius
I think I have missed @lhutton1's comment (Sorry!) which I will address in a follow up.

No worries, nothing major :)

Thanks @manupa-arm!


UPDATE ON LOGO Dev Profiles

Updated the LOGO style with gradient colors and added ANIMATION to it!
Please feel free to merge this style!

Should I make mobile responsive and PR again? is everything else alright?
@oyepriyansh


Save selected subtitle

Fixes #701.
The selected subtitle index is stored in the same way as the current time of the playing file. It might be overkill to do this on every render, but I could not see other obvious places to put it, since subtitles can be added/selected in multiple ways.

I don't think this works. The subtitles list can come from two different places: either from the torrent, or added by the user. You can drag .srt and .vtt files onto the player, or select them from the open file dialog after clicking CC.
The subtitles list can change from one time you play a file to the next, so we can't save an index into that list.

instead of index, you could save the subtitle path. make sure to distinguish whether it's a relative path (for a file inside the same torrent) or an absolute path (for user supplied subtitles)

@dcposch You are right, I changed the PR so now it saves the absolute path for the selected subtitle, is that okay?
Also I changed the addSubtitles function: if the added file is a duplicate it is still possible to auto-select it. This also makes it possible to re-enable a subtitle by dragging it.

LGTM!

Rebased for #693

Thanks!

Good job, guys! ;)


Just wanted to say thanks!

Hey, just wanted to say thanks for making this project. I got set up successfully with it today inside my Svelte project and it's a great WYSIWYG library. Nice to see it just work! Thanks for all your hard work on this and for sharing it for others to use 👍

@moreofmorris  That is music to my ears 🎶. Thank you for your kind words.

Absolutely agree, this is very helpfull. Thanks for creating this


Added pep.py -- Sparse Gaussian processes using Power Expectation Propagation

This approach allows interpolation between FITC (EP or alpha = 1), and Titsias's variational (VarDTC, VFE when alpha = 0).
Reference: A Unifying Framework for Sparse Gaussian Process Approximation using Power Expectation Propagation https://arxiv.org/abs/1605.07066

Current coverage is 49.05% (diff: 0.00%)

Merging #448 into devel will decrease coverage by 0.14%

@@              devel       #448   diff @@
==========================================
  Files           189        190     +1
  Lines         18204      18256    +52
  Methods           0          0
  Messages          0          0
  Branches       2533       2533
==========================================
  Hits           8956       8956
- Misses         8822       8874    +52
  Partials        426        426

Powered by Codecov. Last update 0007ecc...eee1fba

Wow! That's super cool Thang!
@mzwiessle, @zhenwendai it would be great to get this incorporated as soon
as feasilble. @zhenwendai do you have time to take a look?
Neil
On Wed, Oct 19, 2016 at 6:29 PM, Codecov<EMAIL_ADDRESS>wrote:

Current coverage https://codecov.io/gh/SheffieldML/GPy/pull/448?src=pr
is 49.05% (diff: 0.00%)
Merging #448 https://codecov.io/gh/SheffieldML/GPy/pull/448?src=pr into
devel https://codecov.io/gh/SheffieldML/GPy/branch/devel?src=pr will
decrease coverage by 0.14%
@@              devel       #448   diff @@
Files           189        190     +1
Lines         18204      18256    +52
Methods           0          0
Messages          0          0
Branches       2533       2533
Hits           8956       8956          - Misses         8822       8874    +52
Partials        426        426
Powered by Codecov https://codecov.io?src=pr. Last update
0007ecc...eee1fba
https://codecov.io/gh/SheffieldML/GPy/compare/0007eccd79fafdcde177e9ac30866b41d25811ba...eee1fba8adee3f2c4601f9888c24cb8f5dcb188a?src=pr
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SheffieldML/GPy/pull/448#issuecomment-254866907, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIKWneAEfUhojNCoxDsG1oSokkkFQkiks5q1kWFgaJpZM4KbFDb
.

Hi All,
I also provide a script comparing different techniques here https://github.com/thangbui/sparseGP_powerEP/blob/master/python/sgp/tests/test_PEP_GPy.py
Thanks,
Thang.

Great stuff! Could you add the test script as a test in GPy so the code is being tested within the GPy tests?

@mzwiessele I added a test script which checks grads (as in fitc) and makes sure special cases of PEP are FITC and VarDTC -- not sure if this is enough.

Great work! Thanks a lot, @thangbui! The test case of PEPgradienttest sometime fails randomly because of the random generated dataset. Could you fix the seed?
The codecov does not get updated with the recent commit. I don't know why.

@mzwiessele could have a look at why the added test case is added but the coverage does not increase. I am not familiar with codecov.

Sure as soon as I have recovered, Ill give it a thorogh look.

On 2 Nov 2016, at 02:03, Zhenwen Dai<EMAIL_ADDRESS>wrote:
@mzwiessele could have a look at why the added test case is added but the coverage does not increase. I am not familiar with codecov.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

It is simple: Tests for nosetests need to have "test" in their name. pep.py is not being run as a test....

Thanks @mzwiessele and @zhenwendai for the merge!

Thanks for the contribution! Looking forward to the next module : )


rpi5.yaml: set actual name for meta-xt-prod-devel-rpi5 repo

Since the main layer was renamed I have set an actual name to the repo which is meta-xt-prod-devel-rpi5.

Reviewed-by: Grygorii Strashko<EMAIL_ADDRESS>


Unclear How to write to object

Firstly, great effort on this, stumbled across this and being able to demo data logging based on Bacnet objects is great!
I am trying to get a setpoint to write and it is not overally clear on how to write a value to the system.
In the inject node I have placed this into poll and given the value I need to change the value for. In this example setting the value to 26

In the write list I have selected the object I would like to write to

and in the properties i have selected unsigned_Int

Every time the value is injected the debug output shows underfined

I have tried adding in the message topic the reference to the object name as you can have more than one object in the write list.
Can you explain who the values are meant to be populated into the write node and if you have more than one object selected how to write to the different objects or if you have to use seprate  write nodes for each object you are going to write to.
Thank you again for you work in this.

Hi @ChrisFarrant  - thanks for your feedback.
You're on the right track here - the inject node should only have a single payload property, with the write value. This will send a bacnet write command to all of the chosen points in the Write List tab of write node.
If you want to write different data types to different bacnet object types - you should use separate write nodes for every type / object.
However I dont think "unsigned_int" would be the correct application tag for a Analog Value. Have you tried using the "REAL" application tag ? Also, are you able to write to this point / priority using other tools like Yabe etc ?
You can findmore documentation regarding this node here:
https://wiki.bitpool.com/bitpool-edge/connectors/bitpool-edge-bacnet
Docs are slightly outdated, but still relevant. We also plan to deploy more updates to this node, including icon changes indicating points that are Read-only or; Read/Write.

Thank you for your quick reply, the point is writeable and every other device is set to write at the same level 9, I have changed the inject node to this:

and the write to this

and still get this in the debug output

It still gets an undefinded on the output#;
Below is the flow layout

I would assume that the payload is not formatted correctly as I keep getting undefined and never triggers a write.
Thank you you

I have tried the inject and have the same result.

You wont see any output from the Write node for the msg.payload property. Change the "debug Write" node to show "complete msg object", and you will see the selected points and payload there.
Also currently there is no output from the gateway when a write command is sent. Its best to check with a follow up read command or other bacnet explorers to see if the value has been written.

You wont see any output from the Write node for the msg.payload property. Change the "debug Write" node to show "complete msg object", and you will see the selected points and payload there. Also currently there is no output from the gateway when a write command is sent. Its best to check with a follow up read command or other bacnet explorers to see if the value has been written.

Thank you for your reply, I have changed it as requested and below is the screen shot.

The message looks to be formatted correctely
Expanded:

The value was already at 26, changing the inject value to 24

Pressing the poll for Read show that the value did not change.

All devices in the system are set to write a level 9 which the same level as it has been set to.

I have also tried it on REAL and Unsigned ingt and the same result no write to object

That is strange. Just to confirm a few things:

Are you using the latest version of the node ?
What operating system are you running node-red on? In a docker container or directly onto OS?
Are you comparing the output of the Read poll after sending a Write? Or just the present value displayed in the point tree ?
Can you try and delete the write node, deploy node-red and then replace the write node ?

Can confirm it is working consistently across different controller types for me:

Closing due to inactivity, please try again with latest module version. If the issue is still present, come say hello in our discord or create a new issue.


FAQ misconceptions

Mocha does not require describe, etc to be in the global namespace; the default interface (bdd) does, however. It is one interface amongst several.

Mocha provides TAP output as an available reporter but is not otherwise tightly bound to TAP.

is a common misconception, but I'm not sure where 2) came from.

Addressing bloat and performance are two issues on Mocha's radar. Would appreciate any suggestions or assistance!
Thanks. Looks pretty cool :+1:

Is not supposed to be in the list and instead refers to point 1. Sorry on mobile

dammit

Ok, I've clarified it in the readme, but the reality is that most people just use the default interface. The TAP part is regarding node-tap/tape, not Mocha. Feel free to do a PR if you think anything else could be said better or something. I'm not trying to bash on Mocha. Just my opinion on it. I was a happy user for a long time.

Thanks.  I don't expect everyone to be in love with Mocha; it has some fundamental flaws that need addressing.  If we end up stealing some of your ideas, please consider it flattery. :smile:

Please do. I would like to see Mocha improve too. AVA is not for everyone. Most will continue using Mocha. I'm just trying to move testing forward for everyone :)


Turbolinks not emitting events for "unsupported" browsers

Perhaps this is "feature not a bug" territory, but seems like before https://github.com/turbolinks/turbolinks/commit/14f07ff12343f77f393ac6c7b571322f3b4e493f, events like turbolinks:load and friends would still be fired, which was useful as it meant that all the other JS would still continue to work, even if turbolinks wasn't supported (I'm possibly completely wrong here...)

You’re right, we should fire turbolinks:load in unsupported browsers. Not sure how best to handle this right now, but please feel free to explore and open up a pull request if your app needs this functionality.

I feel like the solution in https://github.com/turbolinks/turbolinks/pull/166#issuecomment-305398602 is preferable. It feels a bit odd that a library would emit events when it's not supported.


node.js deployment: Error MSB3428: Could not load the Visual C++ component "VCBuild.exe"

Issue:
npm deployment produces the following error
remote: Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
remote: MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe". To fix this, 1) install the .NET Framework 2.0 SDK, 2) install Microsoft Visual Studio 2005 or 3) add the location of the component to the system path if it is installed elsewhere.  [D:\home\site\wwwroot\node_modules\tsd\node_modules\bufferstream\node_modules\buffertools\build\binding.sln]

To reproduce:

enable git for a azure web site
clone locally
add a package.json (see contents below)
git push to trigger deployment

package.json
{
	"name": "s",
	"description": "s",
	"version": "0.6.0",
	"author": {
    	"name": "Microsoft Corporation"
 	},
	"private": true,
	"engines": { "node": ">= 0.10.0 < 0.11.0" },

	"dependencies": {
		"tsd": "*"
	}
}

Are there any plans to remove this limitation? MSBuild is present, so I don't see why the VC++ build tools couldn't be as well.
We're trying to move over to Azure Websites but it seems running node.js is a little trickier than we originally thought because of limitations like this.

Every time that I want to love Azure I run in to issues like this and end up struggling for hours trying to figure out work arounds.
This seems like a very silly limitation as all it would take to fix it is installing the appropriate build tools.  Is there any plan to fix this or are we left to figure out workarounds indefinitely or switch away from Azure to a competing cloud computing provider?

+1

This is a blocker issue for a lot of people. It is almost impossible to build a decent workflow or a decent application without one or more native modules.
Nobody wants to put hundred on megabytes of node_modules dependencies inside their source control repository.
And how can we build a continuous deployment script if we can't put the "npm install" command inside our scripts ? (obviously npm install is failing due to node_gyp modules)
Please add VC++ build tools ! We don't want workarounds, we want a first class user experience when using Node.js on Azure !

Yes, being able to build native modules would remove so many workarounds needed to deploy a complex node.js project!

Can we have an update on that ?

Sorry, there is no useful update at this time. We know it's a pain point, and we're still hoping there will be a solution in the future.

Is it not possible to install a VC++ compiler on the platform ?

There is more to it. It's not just a matter of installing one thing and having everything start to work. We did experiment with this at the time and there were several additional issues.

@francesconero @DavidRouyer Could you please share the name of specific native node modules that you are hitting this issue with?
Some that we already know about:

socket.io
bufferstream

The ones I have problems with both come from the mongodb package (although one recently became an optional dependency):

bson-ext
kerberos

Actually, every module depending on node-gyp in my opinion. Your can find a list here.
Take dependencies of dependencies into account.
For example, karma and protractor need socket.io.
Database drivers (sqlite3, pg/ng-native, node-oracle, node-mssql (not sure), etc.) ...

@DavidRouyer we're looking for specific ones that we can use for testing, and we'd want to prioritize the testing with modules that we know people are actually trying to use, so not the full list of everything that uses node-gyp. We'll look at the specific ones you mentioned, thanks!

Other question: if we had a solution that only worked with npm 3.x, would that be acceptable? Or are people still using the old one?

I think it would be awesome! I'm sure there are still people using 2.x versions (me, for example), and the main problem I see is that peerDependencies were removed in npm 3.x.
But I mean, what better occasion to migrate the install than this? Also I think most projects would upgrade from npm 2.x to 3.x without even touching the package.json.
May I ask a question out of curiosity though? Does the npm3 requirement stem from the path length limitation?

I think npm 2.11.x or later is all good !
I think a lot of people have made the switch to node v4.
For people who wants stability, they can use the v4 LTS branch shipped with npm 2.14.x by default.
For people who wants to use the latest version of node, they can use the v4 branch with npm 2.14.x or npm 3. (The v5 branch is coming very soon and will be shipped with npm 3 by default).

The requirement comes from the supported versions of VS in node-gyp that shipped with npm in a given version. VS 2015 started being supported by node-gyp that shipped in npm 2.11.2 while VS 2013 support shipped with npm 1.3.21. Ideally we will support one version of the compiler, either 2013 or 2015, but we wanted to see if it's okay to only support newish npm releases (>= 2.11.2)

@ahmelsayed makes sense, thanks! But why jump to npm 3.x, which introduces unrelated breaking changes?

We just thought that 2015 was only supported in 3.x, but apparently it's supported starting from 2.11.2, David had it initially saying 3.x but has updated his comment since then to say 2.11 :)

Of course! Sorry to have missed that. I wish they sent notifications for updates to comments you replied to :)

One more thing we could use from you: if you could share some simple repos that use those packages and are currently blocked by it, we would use that to validate that things work end to end. Ideally, it should be a simple repo such that:

pushing it today results in the VCBuild.exe issue
it should work fully if native modules can be successfully compiled

@davidebbo should the project be a website? The native modules I use are used to interat with mongodb, so you would have to set up an instance before the project worked. It wouldn't be just a simple deploy unfortunately.

Another approach: email me (david.ebbo (AT) microsoft.com), and we can get you set up on a test site that has the fix, where you can try whatever you need.

The fix we made is deployed, and should allow npm native compilation to work. Some notes:

There is a known perf issue that causes the compiler server process (mspdbsrv.exe) to hang for about a minute on first invocation.
We've tested the following npm packages: https://github.com/KuduApps/NodeAppWithNativeNpmModules/blob/master/package.json.
For a reason that is not fully understood yet, a subset of those packages (hiredis, bcrypt, libxmljs, fibers, node-expat, kerberos) fail to install on free/shared Web Apps, but install fine on dedicated Web Apps (i.e. basic/standard).
Let us know if you run into an issue with a specific package.

Hi @davidebbo,
We're having an issue with the following module which is not in the list of tested packages:  lwip.
Repro and deployment logs can be found here: https://github.com/Benjiiim/azure-appservice-test
Any advice if this should work or if we need to install more dependencies through the custom script, would be greatly appreciated.
Thanks

@Benjiiim can you open a new issue? It will make it easier to track this one case instead of this long thread.

lwip_logs.txt

attached log file from the build in the web app, I also have the npm-debug.log if that is required.
thanks


View tree comparaison : the program crashed

Hello, version 2.2.5
When clicking on "View -> skill tree comparaison", the program crashed. I can't launch the program again (it crashes at startup, exception is different from #290 )
Local lang = french
debug.txt

That happened to me once, too. But I couldn't reproduce it because I deleted the PersistentData.
To fix your program not being able launch you have to find your PersistentData.xml, find <TreeComparisionEnabled> and replace the true inside of <TreeComparisonEnabled>...</TreeComparisonEnabled> with false.
Would be nice if you could post the contents of that file before changing it. That would enable us to fix the bug.

Thanks for the reply, here is the file (with a .txt extension in order to be supported by github.
PersistentData.txt
The workaround works.


Add support for partial commits of a changeset

Use the CommitDialogChangesBrowser as in https://github.com/carlrobertoh/CodeGPT/blob/f3357ff0a6f16be79b9a8be70de18cd6513541f2/src/main/java/ee/carlrobert/codegpt/actions/GenerateGitCommitMessageAction.java#L154

I think I already do this with  val includedChanges = commitWorkflowHandler.ui.getIncludedChanges() in https://github.com/Blarc/ai-commits-intellij-plugin/blob/ff8f4ba5936c38737a4f7a3effe65978d2e61a7f/src/main/kotlin/com/github/blarc/ai/commits/intellij/plugin/AICommitAction.kt#L32C8-L32C76.

Your implementation seems to include the whole gitt-diff instead of only the selected changes. Running the same backend and commit prompt, I had huge differences in the generated output. Yours seemed quite off (as if the whole gitt-diff was used for the input), the other one on point.

Even more, if you deselect a single line in the commit dialog, it won't be added to the prompt:


Added version_tree module to support versioning of arbitrary objects …

…in IPFS

@iamtrask, here's the initial implementation of a versioning API for IPFS that we were discussing: it allows committing objects along with an IPFS parent hash (if not root), and retrieving the chain of ancestors from a node to its root.
I had to make some design and performance choices to get this implemented, so let me know if any of them don't fit the use-cases you have in mind.
A couple of things to take note of:

For the chain of ancestor methods, I'm using an iterator so that we can avoid cluttering the API with a limit parameter, but can still get arbitrary-length ancestor chains.
These methods also return the full contents of the chain of ancestors (in the form of VersionTreeNodes), instead of just their identifying multihashes.  Changing this should be trivial.
This isn't directly related, but I'm requiring an ipfsapi.Client to be passed in to either init or each method. What do you think about having a singleton in the ipfsapi.Client class? It wouldn't require refactoring existing code and it means we can avoid passing around the object all over the place or creating it in multiple places.  The only reason I can think of that this wouldn't work would be if a given worker node wants to have multiple clients with different configurations for connecting to IPFS daemons.
I'm planning to write some unit tests but wanted to ask you if there's any guidelines I should be following for doing so.  I tested it manually end-to-end on IPFS and it seems to work.

This looks fantastic!! If I could make one request - would you be so kind as to create / include a jupyter notebook showing how you use it? This will greatly help others use your work. Please include it in (https://github.com/OpenMined/Grid/tree/master/notebooks/experimental)

I do also greatly enjoy your very well commented and highly readable code!

Will do.  Any thoughts on the unit tests, or is the Jupyter notebook sufficient for now?

General notes -- great stuff!  Really like your coding style here, it's very well written.  I also like that this isn't specific to pubsub, torch, keras, etc.
As far as unit tests go, if you can provide some simple test cases in the notebook or a separate file, that'd be rad.  That way we can integrate those into a formal testing module when it's ready.  Whatever testing you did to verify on your own over IPFS should be good.

The Jupyter notebook is about half-done;  Ideally, I'll push it sometime this weekend.

Hey @vbawa, I should have ping you yesterday that I was also working on a notebook. I am sure they will be complementary. Here is an example how we can version control weights of a model.
https://github.com/yanndupis/Grid/blob/weights_version_control/notebooks/experimental/Weights_version_control.ipynb
This class is awesome, we could version control anything we want. I will push this notebook once your PR is merged.

Alright, sorry for the delay.  I've pushed a Jupyter notebook with usage examples and some basic explanation.  @jvmancuso, let me know if there's anything else you'd like to see changed here.

This is a gorgeous Pull Request - absolutely love the generic support for tree storage in IPFS.


Update Composer dependencies (2023-02-16-00-11)

Visual regression test passed!
View the visual regression test report


All output goes to stderr

Could a debug flag be added so that I can disable the warnings going from this gem to stderr? Our sysadmins are getting an email every night because we use this gem in a cron job.
I'll take a whack at a patch for this.

Sorry for being so rubbish at picking this up. Totally makes sense and thank you very much for the patch.

Version 0.0.4 now released:
https://rubygems.org/gems/waveinfo


ajborka's contributions

Added myself to the contributors list, fixed a grammatical error in the code of conduct, and reformatted readme.md for easier reading.

Here are further clarifications on the change request:
Steps 2 and 3 needed compliant html source code for the images. The images also needed alt text to comply with accessibility guidelines. Step 4 is the original text formatted into a step number. The rest of the directions might need some rework to help users better understand how to modify and commit other files than contributors.md. Here are my comments on your markdown share version:
Under clone it to your computer, the statement
Now clone this repo to your machine. Click on clone button and then copy to clipboard icon
Has grammatical errors. The statement
git clone
Should have an explicit URL in the address. Some users may get confused on what URL they copied. Further, most users might not want to fork, clone, and copy the repo through clickable buttons. They need to understand what they are typing and how it fits together. The line
git clone  https://github.com/this-is-you/first-contributions.git https://github.com/this-is-you/first-contributions.git
the placeholder ‘this-is-you’ makes no sense because it is not explained. Under commit changes, the statement
Add those change using git add
Has grammatical errors. The statement
git add Contributors.md
May have negative consequences on commits because the user might have changed more than contributors.md. Of course, these are your directions, but users need to know how to handle multiple file change sets. Hope this helps understand my changes.
From: Roshan Jossey<EMAIL_ADDRESS>Sent: Wednesday, December 28, 2016 9:53 PM
To: Roshanjossey/first-contributions<EMAIL_ADDRESS>Cc: Andy Borka<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Roshanjossey/first-contributions] ajborka's contributions (#29)
@Roshanjossey requested changes on this pull request.
Hey @ajborka https://github.com/ajborka : Thank you for your contribution. I see you've put in a lot of effort in to your first pull request. I can appreciate that. Especially the change to code of conduct. Good catch.
Coming to readme file, I'm not sure if the changes made there will add much value for our users. I'd like users to understand what they're doing on each step of the process. Adding a link to readme of another repo might confuse users. Also having a clear discretion ( by formatting) between what are commands to be run in console would help a lot.
That being said, I believe there can be a lot of improvement in the readme. Like providing discretion between each step. I'll share a version of readme which is much better than this. https://markdownshare.com/view/f1e73ab8-3f0f-47c5-ac55-0bd5fa4560a4
If you feel strongly about your changes, feel free to get back to me. Let's discuss about it. After all this is a combined effort
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roshanjossey/first-contributions/pull/29#pullrequestreview-14627727 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJvvbquEFRPxg_JLtTbgNpFam0NPXU6qks5rMyCogaJpZM4LXCHi .

@ajborka: Thank you for clarifying. Now I have a much better sense of what you're trying to change.

Steps 2 and 3 needed compliant html source code for the images. The images also needed alt text to comply with accessibility guidelines.

We definitely need this change

Under clone it to your computer, the statement

Now clone this repo to your machine. Click on clone button and then copy to clipboard icon

Has grammatical errors.

clone and copy to clipboard are buttons. I don't think this is a grammatical mistake. That said it'd be better to make that difference between text and name of a button apparent.

git clone

Should have an explicit URL in the address.

It cannot be an explicit URL. Users should be cloning from their fork of the repo. so this-is-you in the example url https://github.com/this-is-you/first-contributions.git is user's github username.
ie, it changes for each user. It might add value to mention what this-is-you means

Further, most users might not want to fork, clone, and copy the repo through clickable buttons.

Agree. Users can choose any method to do this. We just provided one of the most beginner friendly way of doing this.

They need to understand what they are typing and how it fits together.

I'm very aligned to this philosophy

The statement

git add Contributors.md

May have negative consequences on commits because the user might have changed more than contributors.md.

I beg to disagree here. In the tutorial we're instructing to make changes to Contributors.md file.   That's why the command is explicitly to add that file.
If command was git add . or git add *. Someone who made changes to other file might accidentally commit those changes as well. It's like a safe guard. Again users must know they are tracking Contributors.md file. If somebody changes Readme, It's a better practice to run git add Readme.md.

Also these are screenshots from your fork of this repo https://github.com/ajborka/first-contributions

You can see all the text is cluttered together. Also as I mentioned earlier, It's better to use proper formatting for commands to be run in console like
console command

I think markdown is broken because of html h2 and br tags. Headings can be formatted with vanilla markdown. For example
Providing ## in beginning of a line makes it like h2 heading
Also I think the title Instructions for contributing to this repository is unnecessary. It's what the whole thing is about at the moment

Your recommendations make sense. I don’t know much about markdown and how it works. That is why I instinctively used html code. Where should we go from here? I use PHP Storm, so the current readme.md does not apply to my environment. As a side question, what are the next steps in the tutorial? I noticed that you have a web app based on reactive.js in it.
From: Roshan Jossey<EMAIL_ADDRESS>Sent: Thursday, December 29, 2016 5:10 AM
To: Roshanjossey/first-contributions<EMAIL_ADDRESS>Cc: Andy Borka<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Roshanjossey/first-contributions] ajborka's contributions (#29)
@ajborka https://github.com/ajborka : Thank you for clarifying. Now I have a much better sense of what you're trying to change.
Steps 2 and 3 needed compliant html source code for the images. The images also needed alt text to comply with accessibility guidelines.
We definitely need this change
Under clone it to your computer, the statement
Now clone this repo to your machine. Click on clone button and then copy to clipboard icon
Has grammatical errors.
clone and copy to clipboard are buttons. I don't think this is a grammatical mistake. That said it'd be better to make that difference between text and name of a button apparent.
git clone
Should have an explicit URL in the address.
It cannot be an explicit URL. Users should be cloning from their fork of the repo. so this-is-you in the example url https://github.com/this-is-you/first-contributions.git is user's github username.
ie, it changes for each user. It might add value to mention what this-is-you means
Further, most users might not want to fork, clone, and copy the repo through clickable buttons.
Agree. Users can choose any method to do this. We just provided one of the most beginner friendly way of doing this.
They need to understand what they are typing and how it fits together.
I'm very aligned to this philosophy
The statement
git add Contributors.md
May have negative consequences on commits because the user might have changed more than contributors.md.
I beg to disagree here. In the tutorial we're instructing to make changes to Contributors.md file. That's why the command is explicitly to add that file.
If command was git add . or git add *. Someone who made changes to other file might accidentally commit those changes as well. It's like a safe guard. Again users must know they are tracking Contributors.md file. If somebody changes Readme, It's a better practice to run git add Readme.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roshanjossey/first-contributions/pull/29#issuecomment-269608343 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJvvbsfjzE8hctIWES1bBlOJjiJG-W4gks5rM4bwgaJpZM4LXCHi .

Cool @ajborka. I'm happy that you could understand my points.
How to take these changes forward
I guess we could sit together and work on this on a collaborative markdown tool. Maybe this
https://hackmd.io/KYdgrAbAhsEIwFoBGVoICwCZ3oQDjjABMEAzATgAY909zzT0i8g=?both
I'm from India so my Dec 30 8:00pm (evening) will be your Dec 30 7:00am (morning). Please get back to me with a time slot that'll work for you.
Once we're happy on the changes, you can just copy that and add another commit to the pull request.
About taking the project forward
This project didn't start off as a tutorial (at least in my head). I wanted to address a lot of problems faced by first time open source contributors. The web app I'm working on which will mostly be the ui, will have a set of open source projects listed with links to easy issues that beginners can work on.  Further improvements will be like users to sign up and get notified about new beginner level issues in projects they subscribe. I'm thinking it'll be mostly in javascript in a serverless architecture
I didn't want to build any of these without getting proper validation that this might be useful. Thats why I started it as a tutorial to contribute to same project (kinda meta right?)

I will figure out something for the time. Will the repository cover more advanced topics?
From: Roshan Jossey<EMAIL_ADDRESS>Sent: Thursday, December 29, 2016 11:40 PM
To: Roshanjossey/first-contributions<EMAIL_ADDRESS>Cc: Andy Borka<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Roshanjossey/first-contributions] ajborka's contributions (#29)
Cool @ajborka https://github.com/ajborka . I'm happy that you could understand my points.
How to take these changes forward
I guess we could sit together and work on this on a collaborative markdown tool. Maybe this
https://hackmd.io/KYdgrAbAhsEIwFoBGVoICwCZ3oQDjjABMEAzATgAY909zzT0i8g=?both
I'm from India so my Dec 30 8:00pm (evening) will be your Dec 30 7:00am (morning). Please get back to me with a time slot that'll work for you.
Once we're happy on the changes, you can just copy that and add another commit to the pull request.
About taking the project forward
This project didn't start off as a tutorial (at least in my head). I wanted to address a lot of problems faced by first time open source contributors. The web app I'm working on which will mostly be the ui, will have a set of open source projects listed with links to easy issues that beginners can work on. Further improvements will be like users to sign up and get notified about new beginner level issues in projects they subscribe. I'm thinking it'll be mostly in javascript in a serverless architecture
I didn't want to build any of these without getting proper validation that this might be useful. Thats why I started it as a tutorial to contribute to same project (kinda meta right?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roshanjossey/first-contributions/pull/29#issuecomment-269731727 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJvvbrkAto7OsCLONcF2leQLfd3iCBObks5rNIsHgaJpZM4LXCHi .

@ajborka: Nice to hear that. It's not mandatory that we spend some time together. Just make necessary changes to the markdown shared and share your thoughts as necessary. I suggested that we sit together and pair on it because it'll tighten the feedback loop and get it done faster.
I'm not sure what exactly you meant by advanced topics.
If its more in the the lines of how to contribute to open source project through github, I've shared with you most of the things I have in my roadmap. I need to validate that anything I build on this project is useful to users from users itself.
I'd love any inputs from your side on how to take this project forward. We can use github as a planning tool too. Open an issue on any topics that might help a first time open source contributor. We can discuss further in the issue thread and take action on it.

Hey @ajborka: Any updates on this? Do you require any more information from me to take this forward?

Sorry. I had an emergency at home yesterday, and it took up almost all day to get under control. I can start working on this issue again tonight. Aside from this, I shouldn’t need anything from you before the next pull request.
From: Roshan Jossey<EMAIL_ADDRESS>Sent: Monday, January 2, 2017 11:41 PM
To: Roshanjossey/first-contributions<EMAIL_ADDRESS>Cc: Andy Borka<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Roshanjossey/first-contributions] ajborka's contributions (#29)
Hey @ajborka https://github.com/ajborka : Any updates on this? Do you require any more information from me to take this forward?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roshanjossey/first-contributions/pull/29#issuecomment-270051361 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJvvbj_3iIsArpzQs75SUR08Eb4KEXjUks5rOdFRgaJpZM4LXCHi .

Ok, sorry for the delay. My emergency is now taken care of completely. I have included my changes to the readme file and a fix to the contributors.md file (a fix for my username). I had a few problems with the url string being enclosed with angled brackets (html style code), so had to make a few changes. Let me know if the readme is good for you. I changed it back to the original and clarified a few steps.

Awesome @ajborka. Your changes looks good to me. Merging.
You've made a major contribution to this project. I'm proud of you. I'd love it it you could continue this and be a major contributor throughout the lifetime of this project. We can learn some javascript and Reactjs together. Also experiment with serverless architectures.

Yes… Sounds good to me. Let’s open some issues and start brainstorming. As you mentioned before, the project is meant for beginner open source contributors, so we need to keep it simple for now. Of course, as we advance, there will be more complicated issues to report and fix, but the simple ideas will get us started.

On Jan 4, 2017, at 11:20 PM, Roshan Jossey<EMAIL_ADDRESS>wrote:
Awesome @ajborka https://github.com/ajborka. Your changes looks good to me. Merging.
You've made a major contribution to this project. I'm proud of you. I'd love it it you could continue this and be a major contributor throughout the lifetime of this project. We can learn some javascript and Reactjs together. Also experiment with serverless architectures.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roshanjossey/first-contributions/pull/29#issuecomment-270560710, or mute the thread https://github.com/notifications/unsubscribe-auth/AJvvbpMlY5V48EtKkAXbXr950yRIfGtrks5rPG-KgaJpZM4LXCHi.


Remove underscore prefix from (almost) all files

What is the expected enhancement?
As we are transitioning from relative imports to absolute imports:
from ._module import Class ---> from qiskit.module import _module

We are introducing code like:
circuit = _quantumcircuit.QuantumCircuit()

... this code is telling me that I want a QuantumCircuit class from an internal/private _module, but QuantumCircuit is not internal nor private.
The concept of internal classes has been diffused during all this time, and I don't think we have this concept anymore, at least not in the vast majority of the files.
So in order to keep code cleaner, I'd suggest to remove underscore prefix from all the files that we have doubts about its domain and files we know they are meant to be used by other components (I'd say all of them).
This is somewhat of a large change, mostly style related so I'm labeling this issue as discussion just in case someone has different views.

I could do this, once said discussion has happened of course!

I'm fine with doing this, but my only concern is the external messaging. Personally I don't see an issue with a leading underscore with an import inside the same repo, to me having a module with a leading underscore means we're not providing an external api stability contract on that module. If we're going to change that for all the modules marked as private we'll have to change how we develop things. Otherwise we'll have to make it very clear which interfaces we're defining as stable and which ones we're not.

There are not that many currently:
$ grep -rI 'import _' qiskit | cut -f 2 -d ':' | sort | uniq
            from qiskit.tools.jupyter.jupyter_magics import _html_checker  # pylint
    from qiskit.tools.visualization._utils import _validate_input_state
from . import _node as node
from . import _schema_validation
from . import _util
from .version import __version__
from qiskit import __path__ as qiskit_path
from qiskit._util import _has_connection
from qiskit.circuit.decorators import _op_expand
from qiskit.qasm import _qasm
from qiskit.qasm._node import _node
from qiskit.tools.visualization import _latex
from qiskit.tools.visualization import _matplotlib
from qiskit.tools.visualization import _qcstyle
from qiskit.tools.visualization import _text
from qiskit.tools.visualization import _utils
from qiskit.tools.visualization._utils import _validate_input_state
from qiskit.version import __version__

Currently, there are not that many:

Actually that grepping seems to be missing some files - we are at ~70ish currently.

What else is still pending here @diego-plan9 ?

Should be finally closed after #2095 :tada:


Disable driver fallback to GLES2 by default

GLES2 is not designed to be a drop-in replacement for the GLES3 backend,
so the fallback mode has to be used knowingly. It can make sense for
simple projects which make sure to handle the differences between both
rendering backends, but most users should stick to one supported backend.
By making it opt-in, we can now use this parameter to define whether to
export ETC textures to Android and iOS when using GLES3 + Fallback.
Fixes #26569.
Also made the option boolean and renamed it to avoid conflict with the
previous String option (which would always evaluate as "true" otherwise).

need to change gles version on manifest too when export apk.
https://github.com/godotengine/godot/blob/45e7306b5adec09746fefda902a5414e5b53fdfa/platform/android/AndroidManifest.xml.template#L14

need to change gles version on manifest too when export apk.

Ouch... I'll give it a try.

Added the code to change the glEsVersion attribute on Android, when using GLES3 and Fallback mode off.
According to aapt, it seems to work. I haven't actually tested the resulting APKs though.
$ diff -aur aapt_test_gles2 aapt_test_gles3
--- aapt_test_gles2     2019-03-05 16:28:06.897228917 +0100
+++ aapt_test_gles3     2019-03-05 16:05:36.097323065 +0100
@@ -706,7 +706,7 @@
       A: android:largeScreens(0x01010286)=(type 0x12)0xffffffff
       A: android:xlargeScreens(0x010102bf)=(type 0x12)0xffffffff
     E: uses-feature (line=18)
-      A: android:glEsVersion(0x01010281)=(type 0x11)0x20000
+      A: android:glEsVersion(0x01010281)=(type 0x11)0x30000
       A: android:required(0x0101028e)=(type 0x12)0xffffffff
     E: application (line=22)
       A: android:label(0x01010001)=@0x7f080000

$ diff -aur aapt_test_gles2 aapt_test_gles3_fallback


Therapist List Icons are not shown anymore

Hi Stefan,
I noticed that the therapist list http://www.viszerale-therapie.at/therapeuten.php looks broken at the moment. Icons and images seem to be missing.
Tested on Mac OS X and Firefox/Chrome
I did a few deployments in the last days, do you see if something wen't missing inbetween?
Thx for checking
Andreas

Hi Andreas,
in the frontend I see only a displaced heading.
If you're still busy on issues please fix that css too - THX!

Stefan
-----Original Message-----
From: Andreas Schönefeldt<EMAIL_ADDRESS>To: "Andreas-Schoenefeldt/viszerale-therapie.at"
<EMAIL_ADDRESS>Cc: multireadsts<EMAIL_ADDRESS>Date: Thu, 25 Feb 2016 04:25:16 -0800
Subject: [viszerale-therapie.at] Therapist List Icons are not shown anymore
(#22)

Hi Stefan,
I noticed that the therapist list
http://www.viszerale-therapie.at/therapeuten.php
[http://www.viszerale-therapie.at/therapeuten.php] looks broken at the
moment. Icons and images seem to be missing.
Tested on Mac OS X and Firefox/Chrome
I did a few deployments in the last days, do you see if something wen't
missing inbetween?
Thx for checking
Andreas
—
Reply to this email directly or view it on GitHub
[https://github.com/Andreas-Schoenefeldt/viszerale-therapie.at/issues/22].

You are right, looks like a temporary missfunction of my browser - I fixed the css.


Update js.md

to ensure response is an object with "result" field otherwise its keyed with "vec_length(?)" field

Thank you @7flash !