NTR: vascular smooth muscle cell dedifferentiation

Hello,
Could I please request the new term "vascular smooth muscle cell dedifferentiation"
As a child of GO:0043697 cell dedifferentiation
Potential definition: The process in which a vascular smooth muscle cell (a non-striated, elongated, spindle-shaped cell found lining the blood vessels) loses the structural or functional features that characterize it in the mature organism, or some other relatively stable phase of the organism's life history. Under certain conditions, these cells can revert back to the features of the stem cells that were their ancestors.
Based on PMID:19088079 (Induction of microRNA-221 by platelet-derived growth factor signaling is critical for modulation of vascular smooth muscle phenotype), this appears to be a normal process for vascular repair.
"Unlike many terminally differentiated cells, smooth muscle cells (SMCs) can switch between differentiated and dedifferentiated phenotypes in response to changes in the local environment (2). In response to vascular injury, quiescent contractile vSMCs reduce the expression of SMC-specific genes such as α-smooth muscle actin (SMA), smooth muscle calponin (CNN), SM22α (SM22), and smooth muscle myosin heavy chain, increase proliferation, and synthesize collagens and matrix metalloproteinases (2, 9). Although this phenotype switch is believed to be essential for repair of vascular injury, deregulation of this process also plays a role in the pathogenesis of various human diseases, including atherosclerosis, hypertension, asthma, and cancer."
Please add the references;
GOC:rph
GOC:BHF
GOC:BHF_miRNA
Thanks,
Rachael.

Also, we were just discussing this term in relation to phenotype switching. We thought that maybe "cell dedifferentiation" (GO:0043697) should be a child of "phenotype switching" (GO:0036166)?

I think it's ok to add under 'phenotype switching' esp with current definition specifically saying that this applies to smooth muscle cells.

Added:
[Term]
id: GO:1990936
name: vascular smooth muscle cell dedifferentiation
namespace: biological_process
def: "The process in which a vascular smooth muscle cell (a non-striated, elongated, spindle-shaped cell found lining the blood vessels) loses the structural or functional features that characterize it in the mature organism, or some other relatively stable phase of the organism's life history. Under certain conditions, these cells can revert back to the features of the stem cells that were their ancestors." [GOC:BHF, GOC:BHF_miRNA, GOC:rph, PMID:19088079]
subset: termgenie_unvetted
is_a: GO:0036166 ! phenotypic switching
is_a: GO:0043697 ! cell dedifferentiation
created_by: tb
creation_date: 2016-03-22T20:25:11Z

Does the switching include both directions? If so, then the dedifferentiation would be part of it, right? The other direction/part would be cell development because presumably if the switch is only between two cell types, even the dedifferentiated one is committed.

@rachhuntley - comment on the switching being both directions?  This affects whether dedifferentiation is part_of or is_a phenotypic switching.

Hi,
It looks like it is reversible, there are a few references stating this for smooth muscle cells
This one's title says it all: "Evidence From a Novel Human Cell Clone That Adult Vascular Smooth Muscle Cells Can Convert Reversibly Between Noncontractile and Contractile Phenotypes " PMID:10455062.
Also;
http://www.ncbi.nlm.nih.gov/pubmed/18300422 "We postulate that the latter epigenetic changes may provide a mechanism for 'cell lineage memory' during reversible phenotypic switching of vascular SMCs."
http://atvb.ahajournals.org/content/23/9/1510.long: "We have shown that FGF-2 and PDGF-BB induce a switch from the spindle-shaped to the rhomboid phenotype in pig SMCs.29 This is associated with increased proliferation and a decrease in expression of differentiation markers. A similar effect has been obtained for spindle-shaped SMC clones. In both situations, this shape change is reversible when treatment is ceased."
I haven't looked extensively in other types of phenotypic switching, but this one in Candida also talks about reversible phenotypic switching;
http://www.ncbi.nlm.nih.gov/pubmed/25481846 "After 5 days of incubation, C. guilliermondii switched spontaneously and reversibly among two phenotypes distinguishable on CuSO4 containing agar, white and dark brown."
I hope this is enough, but if you want me to look into this more I can do it on Tuesday as we're on Easter holidays now.
Happy Easter all!

Looking at the 'phenotypic switching' branch again, I found this term, ' reversion of cell type to default state involved in phenotypic switching' which is a part_of child.  What do you think about moving 'vascular smooth muscle cell dedifferentiation' to be a child of this term instead? @ukemi , @rachhuntley
http://amigo.geneontology.org/amigo/term/GO:0044664#display-lineage-tab

What is the default state though? I would say for smooth muscle cells, if anything it would be the "differentiated" state, since dedifferentiation occurs in order to repair injury.
(by the way, I'm really not here until Tuesday...)

The parent term does refer to the same phrasing, '...ends when the morphology of a population of cells has reverted back to the default state...'  Maybe tweak def to remove that, esp. since the emphasis is on reversibility.
Yes, you're not there at all.  Just talking to myself.

Not to yourself. I think default state is problematic in these cases, because it depends on viewpoint. But I agree with Rachel. If I needed to pick one, I would think the 'default' state would be the differentiated state in this case because without injury, that's what happens to the cell.

How about removing reference to a 'default' state?
change:  A reversible switch of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations.  Phenotypic switching begins with changes in cell morphology and altered gene expression patterns and ends when the morphology of a population of cells has reverted back to the default state, accompanied by altered expression patterns.
To:   A reversible switch of the phenotype of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations.  Phenotypic switching begins **when a cell type changes in **cell morphology and altered gene expression patterns and ends when the morphology of a population of cells has switched to that of another cell type, accompanied by altered expression patterns.
I'm not quite sure how to adapt 'reversion of cell type to default state involved in phenotypic switching' to this def.  Maybe 'reversion of cell type to initial state involved in phenotypic switching'?  The term does not have any annotations associated to it.

HI Tanya,
I like the change in definition.
For the second part, 'reversion of cell type to initial state involved in phenotypic switching', I'm getting a little confused as this sounds like dedifferentiation back to the stem-like cells.
So we're saying that phenotypic switching happens in both directions; in the case of SMCs, towards differentiated cells and then back to dedifferentiated cells. So the term phenotypic switching should have two child terms, one for each direction. "cell dedifferentiation" could come under one of these terms and maybe there should be another term, e.g. "reversion of cell type to differentiated state" could come under the other (maybe called "reversion of cell type to stable state")?
I assume phenotypic switching doesn't always involve cell differentiation?

What if we just get rid of ''reversion of cell type to default state involved in phenotypic switching'?  There are no annotations?  You're more of a phenotype switching expert than I am, do you know if phenotypic switching can occur without cell differentiation?
Maybe:
phenotypic switching (PS)
--[p]cell dedifferentiation  (differentiated cell to dedifferentiated cell)
--[p]cell differentiation involved in phenotypic switching (dedifferentiated cell to differentiated cell in context of PS)

I'm by no means an expert, I've only been reading about it since I opened this ticket!
Phenotypic switching of mammalian SMCs always seems to mention cell differentiation/dedifferentiation. As for other species, there is this paper on yeast (http://www.ncbi.nlm.nih.gov/pmc/articles/PMC196463/), it opens by saying "During the development of eukaryotic organisms, the establishment of specific cell lineages from a multipotent progenitor often involves multiple differentiation steps that are regulated, at least in part, at the level of gene transcription."..."Therefore, as cells progress along a developmental pathway, they switch from one state of differentiation to another by changing gene expression programs."
So it looks like it could be differentiation, if so I agree with your proposal.
I'm off on holiday again today (those Brits with all their vacation days!), but back on Tuesday so apologize in advance for my silence.
Maybe @ValWood could comment on whether phenotypic switching always involves cell differentiation in yeast?

I've been following and so far it seems OK to me. Wild-type  Pombe doesn't do the thing defined as 'phenotype switching' (unfortunate name for a process!), but it does do mating-type switching. This is not defined as a type of phenotype switching. So as far as I can see this seems OK...the  filamentous growth described wold be a type of differentiation.
@mah11 does it sound OK to you?

I'm not sure about the revised def.
I think the def should state "from one cell type or form to another"
rather than the phenotype of. I'm not sure that  the "of te phenotype of the cell" part makes sense (Midori will be able to correct me if I am wrong). Its a switching between cell types (unfortunate name as I said).
Also  it is not clear that/if the expression pattern switches back to the original expression pattern?

Arggh, Wikipedia says
Phenotypic switching in C. albicans include the switch from white cells to opaque cells in need for sexual mating.
AND
A second example occurs in Melanoma, where malignantly transformed pigment cells switch back-and-forth between phenotypes of proliferation and invasion in response to changing microenvironments, driving metastatic progression.
I wonder if this should not really  be in GO as a term called "phenotype switching". This could be misused., and it seems to be used for a number of different types of switch.
I think the phenotype switching term should go completely (or be renamed as reversible differentiation with  'phenotype switching' as a synonym
The original term 'phenotype switching'  as used by CGD really means
"transition from vegetative to filamentous growth"
def transition from a unicellular form to an invasive multicellular filamentous form upon infection of host tissue'
and should have parentage to
'regulation of filamentious growth' and 'reversible differentiation'
GO:0045023	G0 to G1 transition
GO:0070314	G1 to G0 transition
would also belong under  a term "reversible differentiation"

I don't have much to add; I have only done lab work with Saccharomyces, and I don't recall people using the phrase "phenotypic switching" even though S.c. can do pseudohyphal growth. I certainly wouldn't wade in on the subject in bigger eukaryotes!
I do agree that mating type switching is not phenotypic switching. What little I've seen about phenotypic switching seems to imply that there isn't an accompanying change in genotype (and in mating type switching there is).
I'm not as bothered as Val by the suggestion to add "switch of the phenotype of a cell" to  the switching def, but I don't think it adds much. I do wonder whether a cell really has to make a full round trip from state 1 to state 2 and back to state 1 as the current def says, though. I get that if a given type/morphology/whatever change is irreversible we might not want to count it as phenotypic switching, but is a reversible change from state 1 to state 2 not a phenotype switch itself, even before it does the go-back-to-state-1 part? I genuinely don't know. The dedifferentiation def sounds like it's only one direction, though.
This question also makes the terms for parts of phenotypic switching bother me a bit (in addition to the concern about saying "default state", which I think are well founded).
I don't think of G0<->G1 as differentiation at all. Those transitions are more like cell cycle transitions than differentiation, which is a developmental phenomenon.
I think I've gone on rather too long for someone who doesn't actually know these processes in detail ...

Who have we got from CGD who can help us?  I've sent an email to the email listed here and see if anyone gets back to us.
http://www.candidagenome.org/cgi-bin/suggestion

Comments from CGD:
Hi Tanya,
Marek will take a look, but I read over the github page, and white opaque switching (as far as I understand it) is not to do with regulating filamentous growth.  From PMID 19853498, white opaque switching is:
"an epigenetic switch between two distinct types of cells, referred to as white and opaque. These two cell types differ in many respects, including their cell and colony morphologies, their metabolic states, their mating behaviors, their preferred niches in the host, and their interactions with the host immune system“
so I don’t think putting it under 'regulation of filamentious growth’ is a good idea.  In some sense, maybe it’s 'reversible differentiation’, but I’m not sure, so I’ll let Marek comment more.
Cheers,
Gavin

Hi Tanya,
Thanks for contacting us. I don't have much to add to what Gavin has already said. Phenotypic switching, as used in CGD, is a reversible transition between two distinct cell types (in C. albicans referred to as white and opaque) and it is an entirely separate process from filamentous growth. I am not sure why the current definition of phenotypic switching even mentions C. albicans and the transition from unicellular to filamentous form. It sounds like an off the cuff example of phenotypic switching, which it is not; this sentence should be removed.
I am not convinced that reversible differentiation would be a suitable parent for phenotypic switching, though. It does not involve acquiring specialized structures, for one thing, and it doesn't commit cells to any particular stable phase. The current placement of phenotypic switching in the ontology, as a child of cellular process, seems appropriate, since this is a distinct process from anything else.
I hope this helps, but feel free to ask if something's unclear and you need more input.
Best regards,
Marek

Checking with Marek wrt CGD annotations to the phenotypic switching terms.  I will modify the def to remove reference to 'unicellular to filamentous form' switching on his advice.

His reply:
Hi Tanya,
Yes, this modified definition would work for Candida and I imagine it should also work for other cases, whatever they might be, since the only part that has been removed is about Candida and filamentous growth, which was incorrect.
On the second thought, however, I also don't like the sentence about when the phenotypic switching begins and ends. As I understand it, phenotypic switching is the transition between two states, whereas the definition seems to imply that this is an alternative state that is not default, whatever that means. I would change the text to something like this:
A reversible switch of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations. Phenotypic switching involves changes in cell morphology and altered gene expression patterns.  Phenotypic switching also occurs in multicellular organisms; smooth muscle cells (SMCs) exhibit phenotypic transitions to allow rapid adaption to fluctuating environmental cues.
I hope this sounds good to you.
Thanks,
Marek

Old definition for reference:
A reversible switch of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations. Phenotypic switching begins with changes in cell morphology and altered gene expression patterns and ends when the morphology of a population of cells has reverted back to the default state, accompanied by altered expression patterns. For example, Candida albicans switches from a unicellular form to an invasive multicellular filamentous form upon infection of host tissue, and from white cells to opaque cells for sexual mating. Phenotypic switching also occurs in multicellular organisms; smooth muscle cells (SMCs) exhibit phenotypic transitions to allow rapid adaption to fluctuating environmental cues.

Comments?

I think the new definiton sounds good. So, is it correct that the Candida example does not involve differentiation? The cells are changing between two different types. In which case, would we need a new is_a child term, as Val suggests, such as 'reversible differentiation', then we can have the structure that Tanya suggested underneath this
--[p]cell dedifferentiation (differentiated cell to dedifferentiated cell)
--[p]cell differentiation involved in phenotypic switching (dedifferentiated cell to differentiated cell in context of PS)

I checked with Marek.
Hi Tanya,
I'll keep an eye on github in case something comes up and I'd like to chime in. So far, I am OK with 'reversible differentiation', as Val suggested.
Regards,
Marek

Looks like we're converging on something like this.  Please review and give a thumbs up or thumbs down.

Change definition of 'phenotypic switching' to:
A reversible switch of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations. Phenotypic switching involves changes in cell morphology and altered gene expression patterns.  Phenotypic switching also occurs in multicellular organisms; smooth muscle cells (SMCs) exhibit phenotypic transitions to allow rapid adaption to fluctuating environmental cues.

Current structure of terms:

Updated structure of terms:

reversion of cell type to default state involved in phenotypic switching, GO:exists (OBSOLETE THIS,
NO ANNOTATIONS, not unambiguous, replaced by two alternatives under reversible differentiation)
phenotypic switching, GO:exists
--[R] bunch of regulation terms stay where they are
--[p] other part_of children besides the one above stay where they are
--[i] reversible differentiation, GO:new1
----[p]cell dedifferentiation involved in phenotypic switching, GO:new2
------[i] vascular smooth muscle cell dedifferentiation, GO:exists
----[p]cell differentiation involved in phenotypic switching, GO:new3
cell differentiation, GO:exists
--[i]cell differentiation involved in phenotypic switching, GO:new3
cell dedifferentiation, GO:exists
--[i]cell dedifferentiation involved in phenotypic switching, GO:new3
----[i] vascular smooth muscle cell dedifferentiation, GO:exists
--[i] hepatocyte dedifferentiation, GO:exists

Sounds good.

Thumbs up from me too. Thanks Tanya.

Make that three.

Obsoletion email sent today.  Obsoletion and new term creation scheduled for April 26th.
Dear all,
The proposal has been made to obsolete the following term:
GO:0044664,  reversion of cell type to default state involved in phenotypic switching
The reason for obsoletion is that the term is ambiguous and two non-ambiguous terms will be created to take its place.
All details here:
https://github.com/geneontology/go-ontology/issues/12354
There are no annotations to this term.
We are opening a comment period for this proposed obsoletion. We'd like
to proceed and obsolete the terms above on April 26, 2016.
*** Unless objections are received by April 26, 2016, we will assume
that you agree to this change. ***
On behalf of the GO ontology editors,
Tanya Berardini

Thanks Tanya - sorry about the quick fix label :)

Finally done.
+id: GO:0090677
+name: reversible differentiation
+namespace: biological_process
+def: "A phenotypic switching process where a cell reversibly differentiates and dedifferentiates from one cell type into another." [GOC:curators]
+is_a: GO:0036166 ! phenotypic switching
+id: GO:0090678
+name: cell dedifferentiation involved in phenotypic switching
+namespace: biological_process
+def: "A cell dedifferentiation process that is a part of a reversible switch of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations." [GOC:curators]
+is_a: GO:0043697 ! cell dedifferentiation
+relationship: part_of GO:0090677 ! reversible differentiation
+id: GO:0090679
+name: cell differentiation involved in phenotypic switching
+namespace: biological_process
+def: "A cell differentiation process that is a part of a reversible switch of a cell from one cell type or form to another, at a frequency above the expected frequency for somatic mutations." [GOC:curators]
+is_a: GO:0030154 ! cell differentiation
+relationship: part_of GO:0090677 ! reversible differentiation

and obsoleted id: GO:0044664
-name: reversion of cell type to default state involved in phenotypic switching
+name: obsolete reversion of cell type to default state involved in phenotypic switching

Thanks Tanya!


0.11.0.rc1

First release of the New Year: 0.11. Lots of stuff has happened again, bunch of bug fixes, clean ups and new platforms/components.

MySensor revamped and switch support added (@MartinHjelmare)
Sensor: YR platform added (@danielhiversen)
Device Tracker: Geofancy platform has been renamed to Locative (@philipbl)
Automation: Add sun condition (@philipbl)
Switch: command_switch can now poll for state (@happyleavesaoc)
Switch: wemo now uses subscription to states instead of polling (@pavoni)
Telldus Live support added (@molobrakos)
Vera now uses subscription to states instead of polling (@pavoni)
New template helper method is_state_attr(entity_id, name, value) added (@andythigpen)
Device tracker: OwnTracks transition events now supported (@xifle)
Light: Philips Hue platform now supports multiple hubs (@rhooper)
Notify: Free Mobile platform added (@HydrelioxGitHub)
New MQTT Eventstream component to connect two Home Assistant instances over MQTT (@moonshot)

The PyChromecast dependency is also updated with this release! Woohoo!


[Feature] Persist Data Blocks and Index Batches into a Local Retry Queue

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Implement functionality in the liaison component to persist data blocks and index batches into a local queue. This queue will be a retry mechanism for scenarios where target data nodes are unavailable during data writing operations. By queuing the data locally, the liaison can attempt to resend the data to the appropriate data nodes later, ensuring data integrity and reliability.
Use case
No response
Related issues
No response
Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@hanahmily I removed your new label, the label should target to major components rather han features.
Otherwise, we will receive a hug set of new labels.


Tutorial

we need to include a case study for how to implement a basic discretizer to illustrate the process

I would like to take up this task, if no one else is already working on it. Pls do let me know if you have any suggestions or directions to keep in mind.

This is a bigger task than you might think, A tutorial would be a basic how to for putting together a discretizer package. Really we are waiting for someone to use this as a case study then put up a write up of that, but you could try building a toy clone of MethodOfLines.jl, see here for the principle that it works on: https://docs.sciml.ai/MethodOfLines/stable/howitworks/
https://docs.sciml.ai/MethodOfLines/stable/devnotes/
This is a big job, so you may want to tackle something else. This is likely something I'm going to have to do but I am willing to support if you are keen.


Override all WordPress content files when running first provisioning

I’m using VCCW v3 with Git like as repository-example-of-wp.
But I clone the repository with VCCW in another PC and provisioning it, There seems to be updated all files under /wordpress/ directory in spite of no differences than before.
This event doesn’t occur with VCCW v2.
Is it possible to override only changed files when running first provisioning?
Operating System: OSX 10.10.5
Vagrant Version: 1.9.6
Virtual Box Version: 5.1.22
Just cloning the repository

After running first provisioning

Are themes and plugins updated or deleted?
I think WordPress core should always be updated.

In this repository, I added only an original theme (not default themes) and media files in /uploads/ directory.
These files also have been overridden(or change time stamps) when running provisioning, in spite of they are not WordPress core files.
https://github.com/littlebirdjp/vccw-env-for-theme-build

Could you give me a output of the ls -al or git status or so.
I am sorry I can't understand your problem and I don't have enough time to vagrant up your project.
I want to know what was changed. timestamp of the file was changed? file contents was modifiled? file was deleted? or file mode was changed???

I’m sorry for not telling details.
I tried to  git status and ls -al -R before and after provisioning both on my repository.
As the result, all existing files under /wordpress/ directory have changed git status to modified.
And in comparison with la -al -R command, existing files under /wordpress/ directory have changed permissions from -rw-r—r—(644) to -rwxr-xr-x(755).
I also tried to compare those files by a diff tool, but there are no changes on source code or as binary data between them.
So, the problem is that if there are any files under /wordpress/ directory previously, those files have been changed permissions to 755 when running provisioning.
And just now, I noticed that this problem would be solved by using git config core.filemode false in order to ignore permission changes.
It will be OK to close this Issue.
(But is it a proper action for VCCW...?)

Thanks for your report. We will investigate the situation. 😄

Ah, we should remove following.
https://github.com/vccw-team/vccw/blob/master/provision/playbooks/wordpress.yml#L32


Biolink Model Validation

We need to be able to test for the version of biolink used and if the model elements in the trapi endpoint are compliant.
We can get the version from the smart API spec and the subset of biolink from the meta_knowledge_graph

Substantially resolved by PR https://github.com/TranslatorSRI/SRI_testing/pull/23


add some railway related symbols

tram
unsecured railway crossing ("locomotive")
secured railway crossing ("fence")
(speed) bump

Great stuff, thank you!


Added Zoom.Zoom version 5.7.543

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

That's no fun


Upgrade Metacat .xsl files to style EML 2.2.0

See list of new features in https://github.com/NCEAS/eml/issues/269.

See NCEAS/metacat#1239


Break up an app into subprojects with Angular CLI?

Apologies if this isn't the appropriate medium in which to ask this question.
I have what's currently a medium-sized Angular 5 app with several lazy-loaded feature modules. What I'd like to do is be able to break the app up so each of these feature modules is a sub-project that can be built and tested independently.
With the new support for generating "libraries", would I be able to leverage Angular CLI for this purpose? The main piece I don't know about is how I would pull in those sub-projects into the main app when the app is built/run (we do not want to publish the sub-projects to an npm registry).
Would Angular CLI 6 fit this use case?

Heya, you should be able to break the project apart into libraries. You don't need to publish them into npm either, when you generate a library we set tsconfig configuration to look for the library in its built folder.
You just have to build them in the right order.

That sounds great! Thanks for the information.


Decrease minimum Swift version to 5.5

Decreased the minimum Swift version from 5.7.1 to 5.5 to support building in Xcode 13 on macOS 11.

@mdmathias The package resolves on Xcode 13.4.1 so we must not be using any features that require a Swift toolchain newer than 5.6.1. I don't have an older version of Xcode installed to check for Swift 5.5 toolchain compatibility but your CI should verify for us.


[$2000] Chat - Deleted image URL crashes the app on mac and windows (works fine on mobile)

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app and login with user A (device 1)
Open any group chat
Login with any other user that is in the above group in another device (device 2)
Send any image attachment from device 2 in group chat
From device 1, open the attachment in preview, copy the URL and send it in the group
From device 2, delete the attachment sent in step 4
From device 1, click on the URL and observe that app crashes instead of showing 'Hmm its not here' page like it does on android chrome

Expected Result:
App should display 'Hmm its not here' page when we open link of delete image like it does on android chrome
Actual Result:
App crashes when we open link of delete image
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.36-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/ba3b4fad-0ce0-4461-a168-3f86b3e55d04
https://github.com/Expensify/App/assets/93399543/46d534ad-cb0d-424c-8932-b9b647e364a0
Expensify/Expensify Issue URL:
Issue reported by:  @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688488679783719
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0113703c85388c5be7
Upwork Job ID:<PHONE_NUMBER>849125888
Last Price Increase: 2023-08-02

Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Deleted image URL crashes the app on mac and windows
What is the root cause of that problem?
when attachment not found we throw js error not handle the error with UI
https://github.com/Expensify/App/blob/f9a8529f18696b2584d57c960933cefdf7b2e6af/src/components/AttachmentCarousel/index.js#L187-L190
What changes do you think we should make in order to solve the problem?

we need to handle when page = -1 and show error screen

if (page === -1) {
      this.setState({showNotFound: true});
      return;
}

//wrap content with
<FullPageNotFoundView
     shouldShow={this.state.showNotFound}
     ...
     />

</FullPageNotFoundView>

What alternative solutions did you explore? (Optional)

@mananjadhav - Looks like we have a few proposals here that might work.

Checking those today.

@twisterdotcom Thanks for the bump. I reviewed the proposals, and both have the correct RCA. I just need to verify the pros and cons of both. I'll have that confirmed by tomorrow.

Thanks for the patience here. Apologies folks, it takes time when we have similar proposals with edited history. I think @ahmedGaber93's proposal covered most expects from the beginning and hence we should be using their proposal.
🎀 👀 🎀 C+ reviewed.

Thanks for the review @mananjadhav, assigning @ahmedGaber93 🚀

@mananjadhav PR is now ready for review.

We had the PR finished, but the component was refactored to functional component and had conflicts. We've resolved this but need sometime to review again and test.

@marcochavezf We've got some conflicts due to another issue and I've raised a comment to clarify the change. https://github.com/Expensify/App/issues/21334#issuecomment-1656859609

Seems the other PR caused a regression. Waiting for a resolution there.

Seems that the other issue was agreed on dismiss the modal, this is a bummer because seems the implementation would change in this PR, thoughts? @mananjadhav @ahmedGaber93

@marcochavezf @mananjadhav
from this comment they agree to dismiss modal only for their issue and leave us to handle our issue.

I think those are separate. The issue you linked is as vistiting any other resource you dont ahve access to or does not exist. I think we can continue here with dynamically closing the modal and we can leave that other issue to be handled separately

We can do the both NotFoundPage for deeplinks, and dismiss modal for live update.
The other issue use not accurate condition for live update page === -1.
https://github.com/Expensify/App/blob/024d210bc0b5a0454b62a72de60057af67cdd045/src/components/AttachmentCarousel/createInitialState.js#L53-L55
I suggest remove it from here it use it inside this use effect
    useEffect(() => {
        const initialState = createInitialState(props);
        // if file is found in prevState attachments and not found in newState attachments.
        // this mean the file is deleted in live update so dismiss modal here.
        if(_.find(attachments, (a) => a.source === props.source) && !_.find(initialState.attachments, (a) => a.source === props.source)) {
            Navigation.dismissModal();
        }
        ...
    }, [props.reportActions]);

What do you think about this fix? @mananjadhav @marcochavezf

Yeah I think we can do that. My concern is that _.find for a lot of attachments could be expensive? I am not aware maximum number of attachments in the chat. Are you aware @ahmedGaber93 ?

@mananjadhav

I am not aware maximum number of attachments in the chat. Are you aware @ahmedGaber93 ?

I am also not aware of that, but we already use _.findIndex through attachments here.
https://github.com/Expensify/App/blob/024d210bc0b5a0454b62a72de60057af67cdd045/src/components/AttachmentCarousel/createInitialState.js#L52
and we can simplify it to
// replace this !_.find(initialState.attachments, (a) => a.source === props.source
// with initialState.page === -1
// it calculate in createInitialState no need to calculate it again
if(_.find(attachments, (a) => a.source === props.source) && initialState.page === -1)) {

// it found in oldState
// _.find(attachments, (a) => a.source === props.source)

// it not found in newState
// initialState.page === -1

I am happy to increase to 2000 for the increased work. Can we retain @ahmedGaber93 as the assignee for this?

Thanks @twisterdotcom. Yes we can retain @ahmedGaber93.

I was away for the weekend, and I'll be reviewing this tomorrow.

We're again blocked by conflicts causing additional changes. @ahmedGaber93 is working through it.

Apologies but I am finally going on Parental Leave. I am reassigning to another member of the team.

Apologies but I am finally going on Parental Leave. I am reassigning to another member of the team.

This was deployed on production 2 days back but the title wasn't updated.

@mallenexpensify Can you post the payout summary? This is in production for 7 days, but the title wasn't updated.

The Attachment not found was intentionally added, and we didn't consider this a bug until we had this issue. Moreover based on multiple iterations, we moved through dismissModal, etc. but all of them were expected behaviors. Hence there is no regression PR.
But I do think we should add regression test as it involves App crash. The test steps from the PR are good for the regression steps here. wdyt @marcochavezf @mallenexpensify ?
@mallenexpensify quick bump on the previous comment for the payout summary.

@dhanashree-sawant can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01e88042a91e290cf6
For issue payment, I see days elapsed: 22 which would mean a 50% penalty.  Is there any reason this shouldn't be applied @mananjadhav and @marcochavezf ?
TestRail GH created https://github.com/Expensify/Expensify/issues/313988
@twisterdotcom  I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday?  Thx

@mallenexpensify the scope of the issue was changed multiple times. Hence we increased the bounty to 2000. I don't think there would be any penalty here, and also no timeline bonus.

Thanks @mananjadhav
Issue reporter: @dhanashree-sawant paid $250 via Upwork
Contributor: @ahmedGaber93 paid $2000 via Upwork
Contributor+: @mananjadhav is due $2000 via NewDot.
Closing.. I think we got everything.. right?

@mallenexpensify I think this needs to be opened until @JmillsExpensify approves it on NewDot.

It shouldn't need to, but I'll reopen, assign to Mills and let him close again.  Per the internal StackOverflow post

If you are assigned an issue that they are the C+ on, you can close the issue as soon as the Contributor and bug reporter and regression steps have been completed.

Okay in previous issues I've seen issues kept open. Waiting for @JmillsExpensify to process this one though.

$2,000 payment approved via NewDot based on BZ summary.


Can I use the pretrained models to do grammar checking?

Can someone help me with the documentation where I could use the pre-trained models to check the grammar corrections in a sentence?

We have no such documentation specifically, but if you Google grammar checking transformer plenty of resources come up.


2022-12-24-p.323: Wrong scale of y-axis for grid approximation plot.

The y-axis of the plot on page 323 (Latex) is supposed to show p(θ), yet it's y-ticks are from 0 to 4. I think they should go from 0 to 0.04.

I figured out that this isn't an error but rather me misunderstanding the meaning of p(θ).


Clean and streamline Java client API testing

Identify tests which we have excluded and make sure that we run it both in Jenkins and nightly regressions. This covers SSL runs and other type of authentications.

Jenkins jobs are available for these tests.


Add configuration for default $EDITOR override

I'd like to use WebStorm when running git peek, however my $EDITOR environment is set to vim and I'd prefer to keep it this way because I prefer working in the terminal when working with git for interactive rebases.
I know I currently can overcome this by writing git peek -e webstorm url however it would be nice if I could save a default editor once I set up git peek that I won't have to remember adding the flag each time

The good news is this is already implemented! See here: https://github.com/Jarred-Sumner/git-peek#private-repositories--choosing-an-editor
If you create a $HOME/.git-peek file with this:
EDITOR="webstorm"

It should work.
The file is a dotenv file. So if there are any other environment variables you want to change you can do that there too (e.g. GITHUB_TOKEN)


PI-8252 Added a second optional param to the category route

Coverage decreased (-0.02%) to 1.695% when pulling c6e6e5e6b1f2e66ca2b71a0b9dc3cdac1386cb68 on PI-8252-Category-link-leads-to-whitepage into cbf5979a7fb147ee0acaf19b2a6e51006d928104 on master.


Known performance issues regarding FPS, Frame Times and Vsyncs

I'm opening up this issue here so that others can share there experiences.
Some known issues you might run into are the following:

Steam capped at 15, 30, or any other refresh rate that you wouldn't expect
Games run fine, but when the overlay is opened the FPS is capped to 15,20,30 etc.
Sudden frame time spikes that toggling between a random target back to off resolves
Frame times remain high no matter what until you reboot the system
Enabling/Disabling VRR can cause consistent frame time issues until you reboot
The FPS limiter doesn't do anything when vsync isn't enabled in game like it does on the Steam Deck

Some or all of these issues are known to have issues on actual deck hardware when it's not running on SteamOS. When testing the neptune 6.1 kernel the issues go away.

Using RX 6400.
When opening Overlay FPS drops from e.g. 50 to 7.
Need to restart game to fix it.

Using RX 6400.
When opening Overlay FPS drops from e.g. 50 to 7.
Need to restart game to fix it.

Thanks for sharing. This is actively being worked on. We have it working under specific conditions with a few unknowns. Once we sort that out we'll get the fix into our testing branch.

I've noticed a persistent issue where certain refresh rates do not work well with VRR and it brings down the framerate/frametimes.
E.g. on my RX 6800, if I set a frame limit of 90 fps, the game will be fine without VRR; then when I turn it on, the framerate drops dramatically or becomes highly erratic. I might get drops back and forth between 75 and the low 80s, or it might tank all the way down to 45 fps.
My current workaround is to turn the refresh up to my monitor's maximum (170 Hz), set the target framerate to half of the refresh (85 fps) and turn on VRR, so it will get around 92 fps because VRR causes it to slightly break the frame limit.


Example from README is not working

First of all, thanks for this awesome library.
Describe the bug
When running the example from the README with the version 1.0.0 I get the following error:
TypeError: __init__() missing 4 required positional arguments: 'name', 'neg_termset', 'extension_name', and 'chunk_prefix'

To Reproduce
Steps to reproduce the behavior:

Go to a Python terminal and run the following example:

import spacy
from negspacy.negation import Negex

nlp = spacy.load("en_core_web_sm")
negex = Negex(nlp, ent_types=["PERSON","ORG"])

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: __init__() missing 4 required positional arguments: 'name', 'neg_termset', 'extension_name', and 'chunk_prefix'

Expected behavior
Expecting it to work as in the README example with the latest version.
Desktop (please complete the following information):

OS: Linux PopOS
Spacy: 3.0.1

whoops! That line was supposed to be removed from the README. Can you take a look and try again? Thank you for raising the issue!
nlp = spacy.load("en_core_web_sm")
nlp.add_pipe("negex", config={"ent_types":["PERSON","ORG"]})```

Is it working on your side? Here is still failing for this example:
ValueError: [E002] Can't find factory for 'negex' for language English (en). This usually happens when spaCy calls `nlp.create_pipe` with a custom component name that's not registered on the current language class. If you're using a Transformer, make sure to install 'spacy-transformers'. If you're using a custom component, make sure you've added the decorator<EMAIL_ADDRESS>(for function components) or<EMAIL_ADDRESS>(for class components).

And for the next one too:
from negspacy.negation import Negex
from negspacy.termsets import termset

ts = termset("en")

nlp = spacy.load("en_core_web_sm")
nlp.add_pipe(
    "negex",
    config={
        "neg_tersmset":ts.get_patterns()
    }
)

Error:
thinc.config.ConfigValidationError:

Config validation error

negex -> neg_tersmset   extra fields not permitted

Sorry another typo in the README. Change "neg_tersmet" to "neg_termset". Thank you for pointing these out!
    "negex",
    config={
        "neg_termset":ts.get_patterns()
    }
)


Bug

There is a systemic vulnerability in the plugin. Since there is no world control, the requested file can be deleted like
/mv delete ../ ../plugins.

I dont believe its possible, it need to be a MVWorld before its possible to delete it, just tested and this is what I got.
> mv delete "../../plugins"
[18:05:52 INFO]: The command mvdelete has been halted due to the fact that it could break something!
[18:05:52 INFO]: If you still wish to execute mvdelete
[18:05:52 INFO]: please type: /mvconfirm
[18:05:52 INFO]: /mvconfirm will only be available for 10 seconds.
> mvconfirm
[18:05:53 INFO]: World '../../plugins' could NOT be deleted!```

I dont believe its possible, it need to be a MVWorld before its possible to delete it, just tested and this is what I got.
> mv delete "../../plugins"
[18:05:52 INFO]: The command mvdelete has been halted due to the fact that it could break something!
[18:05:52 INFO]: If you still wish to execute mvdelete
[18:05:52 INFO]: please type: /mvconfirm
[18:05:52 INFO]: /mvconfirm will only be available for 10 seconds.
> mvconfirm
[18:05:53 INFO]: World '../../plugins' could NOT be deleted!

/mv delete .../.../plugins Would you try
I have many friends who have the problem.
There is no world control in the plugin.

Will need more info. Run /mvversion -p and send the link generated here for the server that is having the issue. Also ensure they are on the latest version of mv 4.2.2

Will need more info. Run /mvversion -p and send the link generated here for the server that is having the issue. Also ensure they are on the latest version of mv 4.2.2

You can share an announcement for this problem in the old version, where I will do the necessary tests.

old version? You need to test it with the latest version of MV as I do know MV changed the way delete command works to fix this issue about a year ago. So if you are using an old unsupported version of MV, then nothing I can do other than tell you to update.

I understand, thanks, I will inform my friends.


Question for the occupancy grid code of Raymatching.cu

I am a little confused about the implementation of occ, why we need to /8 when define the grid?
       self.register_buffer('density_bitfield',             torch.zeros(self.cascades*self.grid_size**3//8, dtype=torch.uint8))
And when we query the occ, also /8 and & (1 << (idx % 8)), Why?
       const bool occ = density_bitfield[idx / 8] & (1 << (idx % 8));

I suspect that the reason is because the authors defined the density_bitfield using uint8, but since the values within density_bitfield only need to represent 0 or 1, a single element can represent the values for 8 positions.
Therefore, when indexing, the expression const bool occ = density_bitfield[idx / 8] & (1 << (idx % 8)) is used to access the corresponding bit.


when to use *pointer vs value in .Where, .Find, .First, .FirstOrCreate etc.

This is not a bug report, rather a problem that I encountered using this library.
The documentation is not very clear when it talks about using pointers or values when its passed to for example:
db.Where(&User{}).Find(&out)

or

db.Where(User{}).Find(&out)

The cases where you need to provide pointer is understandable - that is needed for .First() and Find() to mutate the &user and &users:
db.First(&user, 1)

or

db.Find(&users, User{Name: "foo"})

or

db.Find(&users, &User{Name: "foo"})

What bothers me, is that the documentation is not consistent, the pointers and values are thrown randomly in each example
Can you please clarify the correct usage. Thanks

i used convention for it as it follows
db.Where(User{}).Find(&out)
db.Where(User{}).Find(&out, User{Name: "test"})
usr := ...
db.Delete(usr)

pointer only when data needs to be mutated and value for other params


feat: add try/catch to setActive because an exception could be encoun…

When I used the play method of just_audio, I met a crash exception as shown in the figure below. After testing, if an exception is thrown in the setActive of the audio_session, the mobile application will crash. Although I can not reproduce the problem in the log below. I still consider adding a reinforced logic in the setActive method to avoid the failure of code excution here. Or is there a more appropriate way to deal with it?

Although that comment is talking about setActive(false) whereas in your case it would be setActive(true). Either way, your PR makes sense in case setActive is called from an inappropriate state.

Thank you, this is now merged.


reg: Add Query and Delete functions

This PR adds 2 new functions for registration support in acme.Client:

QueryRegistration: This performs a POST on the client
registration's URI and gets the updated registration info.
DeleteRegistration: This deletes the registration as currently
configured in the client.

The latter, while a part of the IETF draft, may not be 100% functional in LE yet, my tests showed that resources were still available after deletion. If anyone knows for sure would be nice to know :)

Thank you for this pull request.
I've added a few comments inline.

Hey @xenolf great thanks for the review! I will update this code and re-push ASAP.

@xenolf all updated and ready for follow-up review!


Network methods 2

This PR adds support for a few more network methods. Specifically:

getNamesOwned
getGracePeriod
getNamespaceBurnAddress

I added a button to test getNamespaceBurnAddress too :).

@shreyasthiagaraj you should tests this against the sample app documentation to make sure the sample is still working with your changes.
https://docs.blockstack.org/ios/tutorial.html


Ruby: refactor init/shutdown logic to avoid using atexit; fix windows

Fixes https://github.com/grpc/grpc/issues/17799
It looks like grpc-ruby on Windows is running into the issue described in this interesting blog post. Currently, in the ruby extension on Windows, Ruby loads the grpc-ruby extension library, and that library sets up an atexit handler to call grpc_rb_shutdown, which then calls into the C-core dll. Apparently, on Windows each dll has it's own separate atexit stack, and the order of process shutdown goes roughly as follows:

main thread falls of main and starts to kill off background threads
the dll's present in the library have their own atexit handlers called as a part of their unloading

So in grpc-ruby extension's atexit handler, it calls grpc_shutdown and proceeds to try to await timer threads to signal their completions, but the timer threads are no longer running, and so we hang.
Overall it seems atexit is dubious. So this PR refactors the grpc_init/grpc_shutdown logic as follows:

At the top of the "alloc" hook of every ruby object that has a dependency on C-core, call grpc_ruby_init
At the end of every such object's GC hook, call grpc_ruby_shutdown
Wrap the lifetime of grpc-ruby background threads (the call creds thread and the connection poller thread) in a grpc_ruby_init/grpc_ruby_shutdown pair.

Note that we no longer schedule grpc init and shutdown only once, and I've deleted the comment on why that's needed. But I believe the described scenario would have been broken for a long time anyways :), because there are ruby-level grpc background threads for which we don't make any attempt to cleanly reset their state at the end of a ruby VM's lifetime.

cloud to prod interop test failure: https://github.com/grpc/grpc/issues/18004


Sound to late

 Issue by portalgamesmais
Friday Mar 03, 2017 at 13:06 GMT
Originally opened as https://github.com/Sticktron/LockGlyphX/issues/45

Spin only plays after already unlocked (every theme)

 Comment by portalgamesmais
Friday Mar 03, 2017 at 13:07 GMT

Sound only plays*


Create more instances that should survive the upgrade

This is just a test so far. Obviously it should be parametrized somehow ... both qa_crowbarsetup and the heat template... @abel-navarro maybe you have some good idea as you've started with the original heat solution?

Although this proposal is correct I would rather make the number of instances configurable, otherwise there's lots of boilerplate. The solution I proposed some time ago (https://github.com/SUSE-Cloud/automation/pull/1580) did already give you that option. In that solution there was not the concept of east-west or north-south traffic.
The north-south part is easy. Just pass an outside IP as done in this PR or even hard code it. The east-west part looks a bit more complicated.
It shouldn't be hard to adapt the template to always have two VMs per network (east-west) and then use the ping between them.
I tried to look a solution for daisy chaining the pings (VM(n+1) to VM(n)) but doesn't look easy to implement with heat, so my other proposal should be better.

Yes, I know it should be configurable, I just do not want to spend more time with it ;-)

abel-navarro approved these changes a minute ago

I actually want to make it configurable and I'm against merging myself :-)

@jsuchome @abel-navarro

no news since months
needs rebase
do-not-merge-yet label

Is this PR still needed and will you update it or can we close it?

We can close it I think


Support StringValue as resource_references

Gapic-generator should support adding google.api.resource_reference annotations to StringValue fields. Currently, it only appears to support annotating plain string fields with resource_reference.

We updated some Bazel build target arguments that were being specified incorrectly. Once we did this, the errors related to resource_references resolved. So this might doesn't appear to be an issue anymore.

Confirmed this is no longer an issue.


Does the plugin support native ads?

I did not find any plugins that support native ads. Thanks.

Refer to https://github.com/floatinghotpot/cordova-admob-pro/issues/391#issuecomment-221457376, it seems not possible.
Maybe you could help if you know how to do it.

Close as if it is impossible.

@ratson Links to those URL are no longer available. Can you share why NativeAd is not possible?

@ratson  I thinks that is possible. Can you use same technique like facebook ads plugin for display native ads?


building an index for remote zarr sources fails, due to single_zarr bug

Was hoping to use single_zarr to build an index for multiple remote zarr sources, for benchmarks against remote netcdf files, but it seems it's a test helper for combining local zarr's only.
The following call, in single_zarr, fails, if the refs are remote, as it doesn't pass the storage options.  Simply adding the parameter didn't work either, since do_inline builds fsspec.filesystem in an incompatible way.
    refs = do_inline(refs, inline_threshold)

Do you have a complete code snippet with public remote zarr data, by any chance?
It seems that maybe the line should be
refs = do_inline(refs, inline_threshold, remote_options=storage_options)

(or just set your inline threshold BIG when doing the individual datasets, as a workaround)

See #349 , which goes some way to solving this, but there are outstanding issues.

Thanks a lot Martin,
I was going to say I can create a public azure remote, but S3 and Google
remotes would have the same problem anyway. I didn't know about the zip
one, that's handy for testing.
It looks like I can't use kerchunk anyway,  our timestamp dimensions size
is not fixed between files and I get the chunk size mismatch error. Will
have to wait for your zep3 implementation..
Kind regards,
Oz
On Tue, Aug 15, 2023 at 4:23 PM Martin Durant @.***>
wrote:

See #349 https://github.com/fsspec/kerchunk/pull/349 , which goes some
way to solving this, but there are outstanding issues.
—
Reply to this email directly, view it on GitHub
https://github.com/fsspec/kerchunk/issues/347#issuecomment-1679122411,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAY7QZFC3XUXZUQFUZPDHUDXVOH5PANCNFSM6AAAAAA3OUOU44
.
You are receiving this because you authored the thread.Message ID:
@.***>

(if you want to comment on the zarr-python varchunks PR and/or the zep03 discussion saying you need this to progress, it may help move things along)


Add Sortable Component for drag/drop

Add Sortable Component for "dragon-drop" (drag and drop)

This update adds a new Sortable component, built using react-sortable-hoc. Sortable enhances react-sortable-hoc a lot. Child components added to the new Sortable component automatically get wrapped with the various HOC provided by the react-sortable-hoc library.
Example
Any child components placed inside this component automatically become sortable.
<Sortable>
  <Card>Jacobim Mugatu</Card>
  <Card>Lord Business</Card>
  <Card>Brennan Huff</Card>
</Sortable>

The SidebarCollapsibleCard component has been enhanced with sortable abilities using the DragHandle from react-sortable-hoc.
Finally, a new drag SVG icon has been added for the Drag Handler UI.
Resolves: https://github.com/helpscout/blue/issues/43
Note: It doesn't look like react-sortable-hoc provides aria roles. And it looks like the library lacks tests. In terms of functionality, it most fits what we need. We may need to enhance it in the future though.

Changes Unknown when pulling 1f7d8c02084b1596c5e35e5a21a5be3cc62ed43e on dragon-drop into ** on master**.


Invalid call to lazypipe().pipe(): argument is not a function

Here is my gulpfile:
'use strict';

var browserSync = require('browser-sync');
var conf = require('./conf');
var gulp = require('gulp');
var gulpif = require('gulp-if');
var lazypipe = require('lazypipe')
var path = require('path');
var rename = require('gulp-rename')
var sourcemaps = require('gulp-sourcemaps')
var uglify = require('gulp-uglify')

var src  = conf.getFiles('assets')('js')
var dest = path.join(conf.paths.static, 'js')

var compressjs = lazypipe()
  .pipe(sourcemaps.init())
  .pipe(uglify())
  .pipe(uglify())
  .pipe(sourcemaps.write())
  .pipe(rename({suffix: '.min'}))
  .pipe(gulp.dest(dest))

function scripts(watch, compress) {
  return gulp.src(src)
    .pipe(gulp.dest(dest))
    .pipe(function() {
      return gulpif(compress, compressjs)
    })
    .pipe(gulpif(watch, browserSync.reload({stream: true})))
}

gulp.task('scripts', function() {
  return scripts(false, false);
});

And when I run gulp scripts I get the following error:
/Users/shawn/www/projects/skiftcreative/skift/app/themes/material/node_modules/lazypipe/index.js:11
			throw new Error("Invalid call to lazypipe().pipe(): argument is not a funct
			      ^
Error: Invalid call to lazypipe().pipe(): argument is not a function.
    Remember not to call stream creation functions directly! e.g.: pipe(foo), not pipe(foo())
    at validateStep (/Users/shawn/www/projects/skiftcreative/skift/app/themes/material/node_modules/lazypipe/index.js:11:10)
    at Function.build.pipe (/Users/shawn/www/projects/skiftcreative/skift/app/themes/material/node_modules/lazypipe/index.js:36:4)
    at Object.<anonymous> (/Users/shawn/www/projects/skiftcreative/skift/app/themes/material/gulp/scripts.js:17:4)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at /Users/shawn/www/projects/skiftcreative/skift/app/themes/material/gulpfile.js:16:5

I have read #3 but looking over my code, it looks correct. Basically I want to use gulp-if to test if I want to do compression (passed as 'true' in another task). But on this part of the code:
var compressjs = lazypipe()
  .pipe(sourcemaps.init())

the .pipe() method seems to be undefined. looking at all the examples, as well as here https://github.com/robrich/gulp-if#works-great-with-lazypipe
Any idea? Thanks.

Please read the error message, it explains what you are doing wrong.

This response isn't helpful. I just ran into the same issue. It seems as though this error is asking for:
coffeeTasks = lazypipe()
  .pipe(coffeelint())
  .pipe(coffeelint.reporter())
  .pipe(coffeelint.reporter('fail'))
  .pipe(sourcemaps.init())
  .pipe(coffee({header: true}))
  .pipe(sourcemaps.write())

gulp.task 'build', ['clean'], ->
  return gulp.src(paths.coffee)
    .pipe(coffeeTasks)  #<<<<<<<<<< no () here
    .pipe(gulp.dest(paths.jsSrcRoot))

I've tried with with coffeeTasks() and coffeeTasks and I get the same error. What's up??

@ghostsquad
Seriously?  Take 2s and read the error message:

Invalid call to lazypipe().pipe(): argument is not a function.
Remember not to call stream creation functions directly! e.g.: pipe(foo), not pipe(foo())

It's says, clearly, to use pipe(foo) not pipe(foo()).  Arguments to the pipe creation function can be passed in as additional parameters to the lazypipe().pipe` function.  All this is provided as examples within the docs..

Yep, my bad.. I didn't read it closely enough. :(
Anyways, thanks for the module!!! :)


accepting intellisense item dismisses inline completion

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.73.0
OS: Windows_NT x64 10.0.22000

Steps to Reproduce:

Install the Intellicode Completions extension
Open a typescript file and type console.l, you will see log selected in the Intellisense menu. You will also see log("") show up as an inline completion
Hit tab to accept the Intellisense item. You will see the inline completion go away.

cc @hediet

This issue potentially is related to this one https://github.com/microsoft/vscode/issues/163431

I did some digging and looks like this PR introduced this bug - https://github.com/microsoft/vscode/commit/9b0ae4dd79e05597cefa4e411e144a21e2fc7ceb
I tested this by building Code-OSS with head at commit bdd63955e5b (#163293) which was made right before the above-mentioned commit. I see expected behavior as below.

@hediet I was able to repro this bug in the simple extension with the code you provided. I used VS Code Insiders latest version.
I used the same code you gave me but if you want to look at it, here's the branch - https://github.com/juihanamshet1/vscode-extension-samples/tree/juih/dev/163481-repro
Here's the GIF of the repro

Something that I noticed while debugging this is that the commit() function on line 510 in inlineCompletionModel.ts doesn't get called when I hit Tab.

Checked out the latest main and the undo bug has been fixed, thank you :)
I saw this new bug with the intellisense + inline completion interaction - documenting it below. It's reproducible in the sample extension that I posted in the previous message.

Unfortunately, I cannot reproduce :(

Tabbing "assert" did not trigger any of the registered editor commands associated with Tab.

This sounds like the context key was not set correctly and is probably also the cause of the bug I ran into when I shared my screen. Maybe this got fixed by the a fix in the suggest widget.

This was fixed in the latest Insiders, thank you!


Add operator Smooth L1 Loss

Smooth L1 Loss is a loss first introduced in Fast R-CNN, which is a compromise of l1 and l2 losses. Parameter sigma is related to the turning point from square to linear. In default state num_args will be set as 2, stating that only data and target are supplied to this loss function. For a more direct comparison with original caffe version, this implementation also supports two additional inputs:  inside_weight which scales input data and outside_weight which scales output loss.

Since the numpy loss is too slow for training, we rewrite it in cpp to enable gpu. Please review and merge. @antinucleon @tqchen

can you check if it is possible to use the new operator interface to simplify the loss?  e.g. https://github.com/dmlc/mxnet/blob/master/src/operator/loss_binary_op-inl.h

On first glance I think it is possible. I will try to work on that soon.
In addition, I would say smooth l1 loss is similar to https://github.com/dmlc/mxnet/blob/master/src/operator/regression_output-inl.h. Is there a plan for the port to new interface of regression output?

The old code will be kept for now. But we would encourage to move to the new one when possible as it is shorter to implement, and be able to expose to both ndarray and symbolic interface

@tqchen Could you update the create new operator document?

We can reduce to 2 inputs and use element-wise multiplication to preserve the merits of inputs inside_weight and outside_weight. I had no luck finding out how to add a scalar input or a parameter beside two symbol inputs. In detail, I would like to know how to add a float parameter sigma to this operator. Could you please point me where to find that out? @tqchen

Another problem lies in the composition of loss function.
data = mx.sym.Variable('data')
inside_weight = mx.sym.Variable('inside_weight')
outside_weight = mx.sym.Variable('outside_weight')
sym = outside_weight * mx.sym.SmoothL1(name='bbox_loss', data=inside_weight * data)

Using executor.backward() would prompt Because the last operator is not Loss function, head_gradient is required in calling backward. Is there a way to resolve this problem?

Remove the dependency on out_grad in DeclareBackwardDependency will make the layer a loss layer

If we want to make the behavior of the objective a true objective function. What we can do is

Make sure the forward outputs a (1,) scalar of the loss function value
Backprop as what we did in softmax entropy loss.

Then you can do composition like
loss = alpha * softmax_cross_entroy(out1, label1) + beta * softmax_cross_entropy(out2, label2)
exec = loss.simple_bind()
head_grad = mx.nd.ones((1,), dev)
# propagate 1 as head gradient back,
exec.backward([head_grad])

In your case, i guess you can likely do
data = mx.sym.Variable('data')
inside_weight = mx.sym.Variable('inside_weight')
outside_weight = mx.sym.Variable('outside_weight')
sym = outside_weight * mx.sym.SmoothL1(name='bbox_loss', data=inside_weight * data)
loss = mx.sym.sum(sym)

# propagate 1 as head gradient back,
head_grad = mx.nd.ones((1,), dev)
exec.backward([head_grad])

Thanks for comment. A dummy head gradient would make a composition of loss function work, thus making the utilization of new operator api possible. However, I wonder if this would compromise the top level training api, especially the distributed training feature.

This won't compromise anything as long as we add support of head grad in
training API. So they would work for distributed setting. We can also add a
special operator that propagates 1 in backward pass to mark terminal loss
On Tue, Apr 26, 2016 at 10:06 PM Jian Guo<EMAIL_ADDRESS>wrote:

Thanks for comment. A dummy head gradient would make a composition of loss
function work, thus making the utilization of new operator api possible.
However, I wonder if this would compromise the top level training api,
especially the distributed training feature.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/pull/1953#issuecomment-214970961

@tqchen Does it mean we still need to pass gradient by ourselves? This is counter intuitive, and not friendly to users.

Let's discuss a workaround here. Stay tuned.

@winstywang @precedenceguo This can be easily fixed with a MakeLoss layer that takes data_shape=(batch_size, 1) and outputs (1,) as summed loss. For backward, simply set in_grad to mx.nd.ones((batch_size, 1))

That's very good to know. How to use EnvArguments to pass an extra parameter float sigma?

@precedenceguo  You need to add set_enable_kwargs to true in registration.Then the EnvArguments will contain the kwargs, which you can use dmlc's parameter structure to initialize

Came into template deduction problem using newer operator interface.
mshadow::Tensor<xpu, 2, DType> mdata = data.get<xpu, 2, DType>(s);
mshadow::Tensor<xpu, 2, DType> mtarget = target.get<xpu, 2, DType>(s);
mshadow::Tensor<xpu, 2, DType> diff = mdata - mtarget;

First error is the minus operation. How to fix this?

mshadow::Tensor<xpu, 2, DType> diff = mdata - mtarget;

diff need to be first get from some container, before you assign it

Thanks for comment. I overlooked this and ScalarExp previously. I feel sorry to say that I didn't figure out how to access kwargs or initialize parameters with dmlc parameter structure from operator_utils.h.  In this example, parameter DType sigma2 = 1.0 should be replaced by the square kwargs sigma. Could you please provide an example on this?

@precedenceguo Look into the operators. Do something like this:
struct ConcatParam : public dmlc::Parameter<ConcatParam> {
  int num_args;
  int dim;
  DMLC_DECLARE_PARAMETER(ConcatParam) {
    DMLC_DECLARE_FIELD(num_args).set_lower_bound(1)
    .describe("Number of inputs to be concated.");
    DMLC_DECLARE_FIELD(dim).set_range(0,  4).set_default(1)
    .describe("the dimension to be concated.");
  }
};  // struct ConcatParam
DMLC_REGISTER_PARAMETER(ConcatParam);
ConcatParam param_;
param_.Init(kwargs);
std::cout << param_.dim;

How to make gradient of composition loss function work?
For inside_weight, gradient is not right since the product inside_weight * (data - target) functions as input together. This can be fixed by making inside_weight an operand.
However,  there are problems with outside_weight.
data = mx.sym.Variable('data')
target = mx.sym.Variable('target')
inside_weight = mx.sym.Variable('inside_weight')
outside_weight = mx.sym.Variable('outside_weight')
sym = outside_weight * mx.sym.smooth_l1(name='loss',
        data=inside_weight * (data - target), scalar=1.0)
a = mx.nd.array([[1., 2., 3., 4., 5., 6.]])
b = mx.nd.array([[0.99, 0.5, 3.5, 2., 7., 10.]])
c = mx.nd.ones(a.shape)
d = mx.nd.array([[2, 2, 2, 2, 2, 2]])
executor = sym.simple_bind(ctx=mx.cpu(), data=a.shape, target=b.shape,
        inside_weight=c.shape, outside_weight=d.shape)
executor.forward(is_train=True, data=a, target=b, inside_weight=c, outside_weight=d)
head_grad = mx.nd.ones(executor.outputs[0].shape)
executor.backward(out_grads=[head_grad])

The output is
[[ 0.00999999  1.         -0.5         1.         -1.         -1.        ]]
instead of
[[ 0.01999998  2.         -1.          2.         -2.         -2.        ]]
i.e. missing the outside_weight.

you don't need inside weight. Modify the backward of smoothl1 like this: ASSIGN_DISPATCH(igrad, req,

               out_grad*F<mshadow_op::smooth_l1_gradient>(src, ScalarExp<DType>(sigma2)))

Thanks for pointing that out. Numerical test stands sound now.

any updates on this? @precedenceguo

Here is a summary of this pull request. Starting as a normal operator with variable argument number, a smooth l1 loss operator is presented. Then it is reformatted as a binary operator, utilizing the uniform operator framework. After that it is rewritten as an unary operator since it functions like a sin, or any other element-wise operator with same input and output shape.
We can composite what we have now to be use this as a loss in object detection
sym = outside_weight * mx.sym.smooth_l1(data=inside_weight * (data - target), scalar=1.0)
sym = mx.sym.ElementWiseSum(sym, name='bbox_loss')

The second line is used to give a name to the composition loss. I have tested this composition loss and it gives the same output as the corresponding numpy loss.
I am not sure why the r-test in travis would fail.
I am not sure about why th

Thanks, great work.
One note: ElementWiseSum still needs head_grad. Are you feeding ones to backward?
@thirdwing Do you know why the r test is failing?

I know and it has been fixed in https://github.com/dmlc/mxnet/pull/2014/files yesterday.

@precedenceguo You just need to merge in the most recent code from master and travis test should be fixed

Yes, a gradient of ones is feed to backward to make this composition work.
head_grad = mx.nd.ones(executor.outputs[0].shape)
executor.backward([head_grad])

You can add a op that does nothing on foward and set in grad to 1 on
backward so that it can work with original api
On May 3, 2016 7:01 PM, "Jian Guo"<EMAIL_ADDRESS>wrote:

Yes, a gradient of ones is feed to backward to make this composition work.
head_grad = mx.nd.ones(executor.outputs[0].shape)
executor.backward([head_grad])
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/pull/1953#issuecomment-216720487

Then can this new op be used directly as a loss layer? In fast rcnn, the smoothl1loss needs to be grouped with cls loss, then how to use the "head_grad"?

out_grads can be a list of NDArray for the case of multiple outputs. See executor.backwards declaration in python/mxnet/executor.py. What we are proposing here is a MakeLoss layer that does nothing but propagate ones of proper shape to every inputs. This special layer has no backward dependency and can be used as the last layer.

@precedenceguo Thanks for your comment. Then the last layer can be defined as:
sym = outside_weight * mx.sym.smooth_l1(data=inside_weight * (data - target), scalar=1.0)
sym = mx.sym.ElementWiseSum(sym, name='bbox_loss')
with sym ready to be grouped with other symbol. Is it right?

That's right. @wp8619

Thanks very much. @precedenceguo

Could you please give an example of how to write the MakeLoss layer? @precedenceguo

Head gradient should have the same shape as output. The new MakeLoss layer can spare this effort and add a grad_scale to many unary and binary operators.
loss = outside_weight * mx.sym.smooth_l1(data=inside_weight * (data - target), scalar=1.0)
bbox_loss = mx.sym.MakeLoss(name='bbox_loss', data=loss, grad_scale=1.0)

LGTM now.
@precedenceguo Is this ready to be merged?

Yes, I think so. Please review and consider.

hi, thanks for the commit!
I wonder which kind of evaluating metrics should I use when using make loss op?

It depends on what to evaluate. For smooth l1 loss, there is no need for special metric since raw output is enough (the loss value).

We should have a DummyMetric that just print the output value. The Torch
metric sort of does this. Can can make a alias and better document it
On Sun, May 8, 2016 at 8:35 PM, Jian Guo<EMAIL_ADDRESS>wrote:

It depends on what to evaluate. For smooth l1 loss, there is no need for
special metric since raw output is enough (the loss value).
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/pull/1953#issuecomment-217769643

Thanks a lot! @precedenceguo

Sorry I don't exactly understand how this works yet.
If the smooth l1 op produced a (w, h) tensor, and make loss op take it as an input. So, the output tensor will also be (w, h) dim. Do you mean that this output tensor is the loss value?  And if i want to get the total loss value(a single number), should I sum the output tensor? @precedenceguo

The output is element-wise loss. Sum the output will give a single number.


Adds a plugin for heptio-e2e tests

Closes #139
Signed-off-by: Chuck Ha<EMAIL_ADDRESS>

@chuckha you'll need to configure the sonobuoy-plugins-deployer project for jenkins.  I copied the project, but we'll need to enable.
That's a good work item to enqueue.

wow. total face palm. forgot to add the actual important file to the commit. thanks CI!

Deployer for sonobuoy-plugins works properly this should not be unblocked.

@k8k - once this is merged you should be unblocked on the scanner side.


When auto formatting (Windows ctrl+alt+a), it jumps to the last line of code.

VSCode Version: 1.3.1
OS Version: Windows 10

Steps to Reproduce:
I've been experiencing this issue mostly on HTML files.

Select all (ctrl+a)
Autoformat (ctrl+alt+a)

Most of the times it jumps to the last line of code, and when you have 3000+ it is a bit frustrating to search where you where.

@animanoir I'm assuming you're using an extensions to format. The built-in formatter uses Shift+Alt+F.
The formatter should behave like that:

no selection -> format whole file
selection -> format selection

In your scenario: After step 1 you have a selection that goes from position 0 to the end of the file. The caret is at the end of the file. After the format, the code reveals the caret. Thus, it scrolls to the end. Long story short, you should not have to use step 1 at all to format a whole file. If the extension you use requires that, please file an issue against them.


(maint) Add skeletor team as codeowners

@austb

Did you want this against 7.x?

I thought codeowners respects the default branch? (which is main)

I'm pretty sure it is per-branch:  https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location

Each CODEOWNERS file assigns the code owners for a single branch in the repository. Thus, you can assign different code owners for different branches, such as @octo-org/codeowners-team for a code base on the default branch and @octocat for a GitHub Pages site on the gh-pages branch.

Updated. Will figure out a mergeup once this lands.

@donoghuc merged!


test: integration tests trap and poller

Description
This PR adds integration tests for trap and poller
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Refactor/improvement

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

Codecov Report

Merging #426 (4c91982) into develop (2ab97e2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

:exclamation: Current head 4c91982 differs from pull request most recent head eebe742. Consider uploading reports for the commit eebe742 to get more accurate results

@@             Coverage Diff             @@
##           develop     #426      +/-   ##
===========================================
+ Coverage    86.98%   87.02%   +0.04%
===========================================
  Files           23       23
  Lines         1398     1403       +5
===========================================
+ Hits          1216     1221       +5
  Misses         182      182

Impacted Files
Coverage Δ

splunk_connect_for_snmp/common/profiles.py
94.87% <100.00%> (+0.42%)
:arrow_up:

splunk_connect_for_snmp/customtaskmanager.py
96.11% <100.00%> (+0.03%)
:arrow_up:

splunk_connect_for_snmp/inventory/tasks.py
95.08% <100.00%> (+0.04%)
:arrow_up:

splunk_connect_for_snmp/snmp/manager.py
94.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab97e2...eebe742. Read the comment docs.


refactor(client-services): make invitations service stateful

copilot:all

Current dependencies on/for this PR:

main

PR #2939   👈

This comment was auto-generated by Graphite.


(visualizer) specify height in jupyter_cell

This PR allows the user to specify the height of the rendered HTML div when calling jupyter_cell(), which is good for people on HiDPI screens who don't use UI scaling

Codecov Report

Merging #97 (53b9e7a) into master (1793962) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   73.33%   73.12%   -0.21%
==========================================
  Files          11       11
  Lines        1035     1027       -8
==========================================
- Hits          759      751       -8
  Misses        276      276

Impacted Files
Coverage Δ

src/meshcat/visualizer.py
75.47% <100.00%> (-0.23%)
:arrow_down:

src/meshcat/geometry.py
91.89% <0.00%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1793962...53b9e7a. Read the comment docs.


Integrate Android webrtc with Google Facebook detection Api

I am trying to integrate android webrtc with Face detection to use one camera but find no common ground between both of them as webrtc is using "org.webrtc.VideoSource" and facedetection is using "com.google.android.gms.vision.CameraSource". how do I eliminate one of the camera? Code for webrtc camera initialization is

    VideoCapturerAndroid vc = VideoCapturerAndroid.create(VideoCapturerAndroid.getNameOfBackFacingDevice(), null);

    // VideoCapturerAndroid vc = VideoCapturerAndroid.create(VideoCapturerAndroid.getNameOfFrontFacingDevice(), null);

    localVideoSource = peerConnectionFactory.createVideoSource(vc, new MediaConstraints());
    VideoTrack localVideoTrack = peerConnectionFactory.createVideoTrack(VIDEO_TRACK_ID, localVideoSource);
    localVideoTrack.setEnabled(true);

    AudioSource audioSource = peerConnectionFactory.createAudioSource(new MediaConstraints());
    AudioTrack localAudioTrack = peerConnectionFactory.createAudioTrack(AUDIO_TRACK_ID, audioSource);
    localAudioTrack.setEnabled(true);

    localMediaStream = peerConnectionFactory.createLocalMediaStream(LOCAL_STREAM_ID);
    localMediaStream.addTrack(localVideoTrack);
    localMediaStream.addTrack(localAudioTrack);

and code for camera of Google Face detection is:
 mCameraSource = new CameraSource.Builder(context, detector)
            .setRequestedPreviewSize(640, 480)
            .setFacing(CameraSource.CAMERA_FACING_BACK)
            .setRequestedFps(15.0f)
            .build();
}

@shoaib086 Did you find anything?


iOS13 fatal exception: NSRangeException

Hi,
We are having an issue on iOS 13:
MMPlayerView | MMPlayerItem.swift line 44
MMPlayerItem.__deallocating_deinit + 44

Fatal Exception: NSRangeException
Cannot remove an observer <_NSKeyValueObservation 0x281f48c40> for the key path "status" from <MMPlayerView.MMPlayerItem 0x28077b980> because it is not registered as an observer.
MMPlayerItem.__deallocating_deinit

Are you aware of it?
Thx!

Hi, I fixed on pod '5.0.9', try again!!

Hi, you are deprecated iOS 11 too? Right now the library only supports one production version, iOS 12...

I think support two version (ios12,13) is enough

I am getting error:
Terminating app due to uncaught exception 'NSRangeException', reason: 'Cannot remove an observer <_NSKeyValueObservation 0x282f08450> for the key path "status" from <MMPlayerView.MMPlayerItem 0x2837a6400> because it is not registered as an observer.'
Are you aware of it?
Thanks


[SPARK-37518][SQL] Inject an early scan pushdown rule

What changes were proposed in this pull request?
Currently, Spark supports push down filters, aggregates and limit. All the job is completed by V2ScanRelationPushDown.
But V2ScanRelationPushDown have a lot limit.
Users want apply custom rule for push down after V2ScanRelationPushDown failed.
Why are the changes needed?
Easy for users to apply custom pushdown rules.
Does this PR introduce any user-facing change?
'Yes'.
Users can inject custom early scan pushdown rules.
How was this patch tested?
New tests.

Test build #145854 has started for PR 34779 at commit a3bc014.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50329/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50329/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50329/

Test build #145854 has finished for PR 34779 at commit a3bc014.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145854/

LGTM(non-binding)
Generally speaking, it is useful. @beliefer Can you give a simple example to show the actual user case?

Spark SQL supports aggregate pushdown only for standard aggregate function. But some databases have some non-standard aggregate function, This PR open a door for flexible customization.

Test build #145870 has started for PR 34779 at commit 746278a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50345/

Thanks for your explanation @beliefer

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50345/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50345/

Test build #145870 has finished for PR 34779 at commit 746278a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145870/

cc @cloud-fan and @maryannxue FYI

Since we already have this extension point inBaseSessionStateBuilder, I'm OK to expose it in the developer API. My only concern is we should document it clearly.

Since we already have this extension point inBaseSessionStateBuilder, I'm OK to expose it in the developer API. My only concern is we should document it clearly.

OK

Test build #145986 has started for PR 34779 at commit 9596820.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50462/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50462/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50462/

Test build #145986 has finished for PR 34779 at commit 9596820.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

OK. Let me close it.


Make some validation functions static in validation.cpp

eg ReadRawBlockFromDisk():
https://github.com/bitcoin/bitcoin/blob/cd6cb9745e13a62e130b11f78a13bcc1d424b05e/src/validation.cpp#L1177
eg GetWitnessCommitmentIndex() (which was made public in https://github.com/bitcoin/bitcoin/pull/16956)

Why? Sounds like needless code churn for no reason.

Because the interface in header file should be kept the minimum size possible, and implementation hidden in the cpp file.

Sure, to the extent where it makes sense. But at the same time it make testing hard and provokes the same discussions over and over again:
How do I tests this method?

Do I put the function def in the header and remove the static? Preferable, imo.
Do I put the function def in the unit test file and remove the static? Ugly, because the function def goes out of sync or must be updated twice
Include the whole cpp file in the unit test to keep the static? Ouch


ARROW-16716: [C++] Add Benchmarks for ProjectNode

Create project_benchmark.cc and add to CMakeLists
If anyone can shed some light or guidance on the comments I made below, that would be extremely helpful!

Two other general questions:

How to measure the data rate, since it seems we are measuring in rows / batches.
I saw some examples of controlling the threads used in ExecuteScalarExpressionOverhead, how can we control threads per core?

Hi @westonpace, following up on our JIRA conversation with @icexelloss, here is the open PR for Projection Benchmarks. I think it is ready for review (however, I cannot request it as a first time contributor).

Hi @westonpace, I was able to debug everything -- InputFinished references output_[0], which was null for our ProjectNode, so I added a dummy sink to take care of that.
I did observe a speedup, but it does not exactly match my outputs for the ExpressionOverhead testing I have on my laptop. Let me know if I missed something in my code.

I did observe a speedup, but it does not exactly match my outputs for the ExpressionOverhead testing I have on my laptop. Let me know if I missed something in my code.

So I guess the problem is that if we call InputReceived manually then we do not get any parallelism (that is today handled by the source node).  So I think we will need to do that manually as well.
We could manually schedule in the benchmark by creating a new TaskScheduler.  Here is a rough example that could be cleaned up.  It's a bit complex but we could start to share this logic if we are going to test all the nodes.

I did observe a speedup, but it does not exactly match my outputs for the ExpressionOverhead testing I have on my laptop. Let me know if I missed something in my code.

So I guess the problem is that if we call InputReceived manually then we do not get any parallelism (that is today handled by the source node). So I think we will need to do that manually as well.
We could manually schedule in the benchmark by creating a new TaskScheduler. Here is a rough example that could be cleaned up. It's a bit complex but we could start to share this logic if we are going to test all the nodes.

Yes, I had an inkling it had to do with the batch delivery especially with some of the metrics being slower than the source + projection + sink versions.
By the way, I found that the TaskScheduler is actually less performant for some reason, does it compete with ExpressionOverhead on your setup?

If you could also point me in the right direction for #13302, that would be extremely helpful -- thank you so much Weston!

Interesting, yes I'll definitely take a look at this benchmark. I'd also be interested in comparing this to just using OpenMP - I may draw that up at some point as well. As of right now I think ThreadIndexer may be a prime suspect for at least some of the overheads.

Benchmark                                                                             Time             CPU   Iterations UserCounters...


istanbul-ignore-file comments getting ignored

Issue :
When using babel, istanbul-ignore-file comments are ignored and the files are included in coverage. setting useBabelrc: false gives the desired outcome.
The repo I'm providing tests both .ts and .js because I wasn't sure if the issue was ts-jest or some other factor. For the js files I was able to get jest to respect the istanbul comments by trying a different preset: @babel/preset-env instead of the metro-react-native-babel-preset I need for react native. For the ts files the istanbul comments are ignored regardless. I wonder if there's some common reason?
Expected behavior :
Files with /* istanbul ignore file */ should be omitted from coverage reports.
Minimal repo :
https://github.com/donovanhiland/ignoring-istanbul-ignore-file
Possibly related issue opened here:
https://github.com/facebook/metro/issues/360

i get errors for ignored ts files:
Running coverage on untested files...Failed to collect coverage from /Users/.../db.ts
ERROR: Cannot read property 'coverageData' of null
STACK: TypeError: Cannot read property 'coverageData' of null

but the file does not show up in the coverage report.

+1

hi @donovanhiland , is the issue still reproducible for you with latest version of jest, ts-jest ? If yes, would you please update your reproduce repo ?

Reproducible on ts-jest 25.2.1 and jest 25.1.0

Thanks for the information @jbolotin , I will close the issue then

In my case the pragmas wouldn't work unless I had:
coverageProvider: 'babel'
in my jest.config.js


update gpt to 2024 08 06 model

This will be a breaking change, tagging it for 0.3 - will plan to merge it once we start building out that next breaking point release.


Swipe down to dismiss

Is there a way to swipe down to dismiss the ModalViewController? If so, how can this be done? Can that be added in a next update? Please let me know, thanks!

No, there is no way currently, and I'm not planning on adding this feature at the moment. It would be a great addition though. if anyone wants to pitch in, PRs are always welcome.

I ended up implementing it myself. Checkout commit 181f663
I'm going to document it better tomorrow, but for now you can check out the sample project.

Works great! Appreciate the implementation. Thanks 👍

Great. I've added the swipe direction and improved the docs. Released version 3.1.0.
👍


[infra] add openstack terraform deployment

See https://github.com/polyxia-org/infrastructure/pull/4


Edit Mode for new markers not working.

[ ] I'm reporting a bug, not asking for help
[ ] I've looked at the documentation to make sure the behaviour is documented and expected
[ ] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using:1.0.2
Leaflet Draw version I'm using:0.4.2
Browser (with version) I'm using: Mozilla Firefox 50.1.0
OS/Platform (with version) I'm using: Ubuntu 16.04.1 LTS
step 1 : Create a marker
step 2 : Enable edit mode

What behaviour I'm expecting and which behaviour I'm seeing
The expected behaviour is I could edit the geometry, but an error happens.

TypeError: e is null
<EMAIL_ADDRESS>Line 6

I can do it with with lines, but not with markers. See the fiddle linked to see the error in action.
Minimal example reproducing the issue

[x] this example is as simple as possible
[ ] this example does not rely on any third party code

Using jsfiddle .

The JS Fiddle is broken, I'll update the JS Fiddle base-template to use the newer version (0.4.9) and see if this issue persists.

I have updated the fiddle. I hope is working now.

@ddproxy is there any update on this issue or perhaps a workaround we could try?


Convert this into telegram bot

Convert this project into a Telegram bot which can be deployed on ubuntu server.

@kerokaboom I take the responsibility for it

@kerokaboom I take the responsibility for it

🎉

No bro not u, sometimes you suck. In your bypass bot you don't allow to add their own drive.
At least leave this project in its on. Keep your monopoly away.

@kerokaboom Bro My Bot was never to public and store things
It was just made to temporarily get gdrive links for easy cloning
If you took an incorrect interpretation it's your fault.
And Last of All ,learn to speak with manners...

@kerokaboom What are you even Bro?
You never understand what the Bot was meant for.
It was not be used as Clone Bot


Introduce ARM64 support on Windows

Fixes #3257

CLI version looks great. Thank you!
Will there be a binary for node.js npm as well?

Hi @marcel-more, not sure – the Node client is being reworked in the https://github.com/duckdb/duckdb-node-neo repository. This will eventually replace the current Node driver as the official one and by then it will surely support Win64 Arm. However, I'm not sure whether Win + Arm64 support will happen in the coming weeks. It's likely best to build it yourself for now.


nginx not connecting to PHP fpm

I have this working on a different computer, so I need a way of diagnosing what might be wrong on this new installation. Is there any other diagnostic information I can access?
I've tried taking it up and down with and without --build, restart docker daemon, rebooting the computer.
I did change the port numbers in the .env.
Info:

Docker version 17.12.0-ce, build c97c6d6
Laradock commit ($ git rev-parse HEAD): acbe716
System info (Mac, PC, Linux): Linux
System info disto/version: , CentOS 7

Issue:
502 Bad Gateway

Expected behavior:
Laravel page should show

Reproduce:
N/A

Relevant Code:
docker-compose logs php-fpm
Attaching to laradock_php-fpm_1
php-fpm_1              | [20-Feb-2018 16:45:29] NOTICE: fpm is running, pid 1
php-fpm_1              | [20-Feb-2018 16:45:29] NOTICE: ready to handle connections

 docker-compose logs nginx
Attaching to laradock_nginx_1
nginx_1                | 2018/02/20 16:45:43 [error] 6#6: *1 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "GET /foo.php HTTP/1.1", upstream: "fastcgi://<IP_ADDRESS>:9311", host: "localhost:8881"
nginx_1                | <IP_ADDRESS> - - [20/Feb/2018:16:45:43 +0000] "GET /foo.php HTTP/1.1" 502 568 "-" "Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3350.0 Safari/537.36"

Sorry, started fresh with .env, now works.


selector-no-redundant-nesting-selector false positive with multiple &s

The selector-no-redundant-nesting-selector rule warns about this pattern, although it cannot be avoided:
.foo {
    & > .bar:not(&--1):not(&--2):not(&--3) {
//  ^ Unnecessary nesting selector (&) (scss/selector-no-redundant-nesting-selector)
        background: red;
    }
}

// compiles to:
.foo > .bar:not(.foo--1):not(.foo--2):not(.foo--3) {
    background: red;
}

When rewriting to the following (as suggested by the rule), the compiled result becomes invalid:
.foo {
    > .bar:not(&--1):not(&--2):not(&--3) {
        background: red;
    }
}

// compiles to:
// (note missing `.foo` at the start)
> .bar:not(.foo--1):not(.foo--2):not(.foo--3) {
    background: red;
}

This was already reported in #472 for Less, but the corresponding PR didn't fix this particular issue.
I suggest allowing leading &s if there are other &s appearing later in the selector.
Versions:
node-sass 4.14.1
stylelint 14.1.0
stylelint-scss 4.0.0

Thanks! Looks like a bug.


please upgrade to jest@26+

this currently using jest@24 which causes issues (https://github.com/microsoft/create-react-app-uifabric/issues/14)

this creates a boilerplate project, it should make an effort to include the most maintained dependencies

this will be fixed when we bump react scripts to v4

this will be fixed when we bump react scripts to v4


temporarily disable google_api_key to test ITs

Coverage remained the same at 80.803% when pulling 8dfc5c70825932a91efec378f93cb8103f6229e0 on neozwu:testapikey into 38bace41fbedbc6ea5ef2962ca774d3ef09d411c on GoogleCloudPlatform:master.

experiment done. so close the PR.


How can I create package with architecture Neutral?

Hi
I can create Neutral (Any CPU) in Visual Studio --> Publish --> Create App Package.
But I think msstore package command only support x86, x64 and arm64 parameter.
If Neutral is not supported, is it possible to build package which includes multiple architecture in one appxbundle?

Sorry for the delay in getting back here.
What type of project is this for? UWP? You can provide a list of archs, and it will pass it down to build them all.


Menu cut if the page is too short?

Seems like the sub-menu of the admin areas are cut by the container.
Unfortunately it's a 1.0.9, so not exactly up-to-date...

This was fixed in 2.0 ... possible even in 1.1