⚠ Bofrost.lu has degraded performance

In a7e8a9e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 890 ms

Resolved: Bofrost.lu performance has improved in a199cd6 after 6 minutes.


default k2-related jobs to k8s v1.5.3

k2 no longer supports k8s v1.4.x, only v1.5.x and above

LGTM


[Emmet] per-language "Trigger expansion on tab"

Using tab to complete an element is useful in HTML, but ends up causing a lot of false triggers in JS and TS. I do want emmet in JS in general, but only in the suggestions list and not just when I press tab anywhere. I tried to enable the setting for only HTML files but the setting was not available on a per-language basis.

@rzhao271 verification steps?

Hm, doesn't seem to work. Will leave verification steps here and reopen the issue.

In the Settings editor, search @lang:javascriptreact emmet.
Disable the emmet.triggerExpansionOnTab setting. If it's already disabled, click the checkbox twice so that the checkbox is unchecked and the blue bar shows up.
Change the query to @id:emmet.triggerExpansionOnTab.
Enable the setting.
In an empty HTML file, type ul>li, press escape, and press tab. The abbreviation should expand.
In an empty jsx file, type ul>li, press escape, and press tab. The abbreviation should not expand.

@Raymo111  Just to make sure I am verification this correctly, after following those steps:

In html, tab always expands the abbreviation even if the suggest widget is not active
In JS, pressing tab will still expand the abbreviation if suggestions are active (as I'm accepting the suggestion) but without the suggest widget open, tab does nothing

Is that correct? I was confused by the case where the suggest widget is open

SGTM. I also expect the tab to expand the abbreviation when accepting completions. Maybe I can add that to the setting description.

@Raymo111  Just to make sure I am verification this correctly, after following those steps:

In html, tab always expands the abbreviation even if the suggest widget is not active
In JS, pressing tab will still expand the abbreviation if suggestions are active (as I'm accepting the suggestion) but without the suggest widget open, tab does nothing

Is that correct? I was confused by the case where the suggest widget is open

Uhhh I think you pinged the wrong person.

Reopening this issue because the current solution breaks the case where the user has the setting set to off by default (https://github.com/microsoft/vscode/issues/160059).
The solution worked fine in the case covered by the verification steps, where the user has the setting set to on by default and then expands the abbreviation. The solution doesn't work when the user has the setting set to off, because at that point, even running the command palette command doesn't expand the abbreviation.
Therefore, the proper solution needs to distinguish between running the command from a command palette, and running the command via keybind.


mcuboot with enabled  serial recovery does not compile

Describe the bug
The mcuboot, selected by west,  does not compile since b85250108cef66033cdb0bdbecea5d3e7926c62f commit to Zephyr.
To Reproduce
0. Download overlay file and replace with the download dir

Go to zephyr root
west build -b nrf52840dk_nrf52840 --build-dir voot bootloader/mcuboot/boot/zephyr/  -t menuconfig -- -DOVERLAY_CONFIG=<dir_to>/serial-recovery.overlay.txt
See linker error

Expected behavior
A clear and concise description of what you expected to happen.
Impact
Not able to compile mcuboot for serial recovery.
Environment (please complete the following information):

OS: Ubuntu 20
Toolchain zephyr sdk 0.12
Commit 5e9d6d638c627f66da25b2393ac63e3846c59594

serial-recovery.overlay.txt

@nordic-krch

Actually, there is already a fix in uarte:
...

Yes, but it is compiled-out using complier, and now need to use preprocessor instead.
Easy to fix then :D

MCUboot upstream fix: https://github.com/mcu-tools/mcuboot/pull/1009


Cleanup Chalice tests

Closing and making the changes in master: https://github.com/getsentry/sentry-python/pull/3858


Ability to enrich feeder's records with extra fields

Imagine there is a CSV file with member IDs:
member
1
2
...

Now, image there is a third-party service providing auth tokens for this members, allowing to call the system under the test on their behalf.
What is needed in the test is a pair member + token, but the CSV feeder builder doesn't allow to enrich the records with extra fields, only convert them:
val members = csv("data/members.csv").random.convert{ case("member", member) => ... }

What would be great is to have an enrich method like:
val membersWithTokens = csv("data/members.csv").random.enrich{ record => record("token", TokenService.getForMember(record("member"))) }

I don't think we'll implement this, unless there's more demand for it, in particular as it's very easy to implement on your side:
val members = csv("data/members.csv").random.apply().map{  aMapRecord => someOtherMapRecord }

@slandelle, will this construct be lazy or will it read all the data into memory?

It won't change the behavior. apply returns an Iterator.

Ok, thanks for the quick reply with explanations!


There are thousands of devices begging for an "update"

Since latest SafetyNet update there are thousands of devices unable to use Xposed framework and modules. BUT there is a new tool called Magisk which allows installing modules without being detected by SafetyNet checks.
I don't know anything about porting/or writing a Magisk module, but I have been dying to ask you this: is there, by any chance, a possibility of you having a look on what Magisk is to see if your module can be ported to Magisk?
Please :). I now maaanyyy people would be relieved.
Your module is awesome.

Magisk is a framework for systemless modification on the system partition. In other words, you can load and unload on the fly binaries like su busybox and app_process_xposed.
Xposed framework is for modifications on the behavior of an app or system frameworks and needs a modified app_process on the system partition that lets do modules their work. Thats why you see xposed systemless...  Means that magisk can unload the modified app_process whenever the user want.
This two are completely different frameworks and magisk is not to modify behavior of an app at runtime...  Just binaries on the system partition

Thanks for your answer @igoticecream.
I just thought that the new magisk versino (with its magisk manager that includes "download" and "modules" tab could eventually function similar to Xposed.
But thanks a lot man :)
I'll just keep hoping someone finds a solution to hide xposed from the SafetyNet Checks

Those modules are for system modification like viper4android mkdule which
installs drivers at system partition and such...  Different kind of modules
Niantic will drop safetynet sooner or later, they are losing way to many
players because of this
On Sun, Oct 23, 2016, 17:28 zapahacks<EMAIL_ADDRESS>wrote:

Thanks for your answer @igoticecream https://github.com/igoticecream.
I just thought that the new magisk versino (with its magisk manager that
includes "download" and "modules" tab could eventually function similar to
Xposed.
But thanks a lot man :)
I'll just keep hoping someone finds a solution to hide xposed from the
SafetyNet Checks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/igoticecream/Snorlax/issues/29#issuecomment-255615782,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADu8a2b2j6ObsoUSTKb6uW2juYxDfv5uks5q29FugaJpZM4KePt6
.

--
Pedro Díaz


chat: unable to leave emoji reaction on mobile web

Describe the bug, optionally with screenshots
Unable to leave emoji reaction on mobile web, the emoji selection box is auto-dismissed just after it appears
To Reproduce
Steps to reproduce the behavior:

Go to any channel
Tap on a message to get context menu to show
Tap on emoji reaction item

Expected behavior
Emoji selection box appears and allows me to select an emoji reaction
Additional context:

Tlon-hosted planet
Firefox on Android

https://user-images.githubusercontent.com/1013230/220159391-6da0a16e-9de7-418f-8a1d-6ab6e501bd7a.mp4

I can repro. This seems to be a firefox specific issue.

I repro'd this on my ship that's using the ~binnec version of the app earlier today, but after the latest update to binnec I'm not seeing it anymore. @alecananian are you still seeing this?

Confirmed with alec that this issue has been fixed.


Autocomplete should happen in Chrome address bar

http://stackoverflow.com/questions/7630144/how-to-add-google-chrome-omnibox-search-support-for-your-site


wormhole: fix concurrent map access

seen a few crashes in eu-de-1 with 200+ nodes

Could we defer the unlocks? Adding additional branches may setup for deadlocks.

@Nuckal777 I added defer statements for unlocking were possible


[klein] create a new port

Describe the pull request

What does your PR fix?
It adds a new port for klein.

Which triplets are supported/not supported?

Updated the version files
Formatted manifests

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
Command failed: ninja -v
Working Directory: D:/buildtrees/klein/x86-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
D:\buildtrees\klein\config-x86-windows-out.log

Call Stack (most recent call first):
D:/installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:351 (vcpkg_execute_required_process)
ports/klein/portfile.cmake:9 (vcpkg_cmake_configure)
scripts/ports.cmake:139 (include)

It seems that the build system can't execute ninja -v? Should I add DISABLE_PARALLEL_CONFIGURE to vcpkg_cmake_configure?

-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
Command failed: ninja -v
Working Directory: D:/buildtrees/klein/x86-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
D:\buildtrees\klein\config-x86-windows-out.log

Call Stack (most recent call first):
D:/installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:351 (vcpkg_execute_required_process)
ports/klein/portfile.cmake:9 (vcpkg_cmake_configure)
scripts/ports.cmake:139 (include)

It seems that the build system can't execute ninja -v? Should I add DISABLE_PARALLEL_CONFIGURE to vcpkg_cmake_configure?

@JPMMaia ,Thanks for your pr,
From the error log on CI, you don’t need to add DISABLE_PARALLEL_CONFIGURE to vcpkg_cmake_configure. this is the latest error log of CI. Could you please take a look?
config-x86-windows-out.log

@JPMMaia ,If this pr is ready to be reviewed, please let me know

@JonLiu1993 thanks for updating the git version and fixing the builds! I marked it as ready for review.

@JPMMaia ,Please run the command "./vcpkg x-add-version klein --overwrite-version" then submit the change again

@strega-nil-ms I believe I applied the changes you requested.


Merging for release of v0.7

@KarolKaczmarek - Ready to merge this to master and release as v0.7. Let me know if you need anything on my end.

Thanks @BrianFarnhill , it's published: http://www.powershellgallery.com/packages/xSharePoint/


dropdown menu to select the database client is broken

It is happening here too :(
I can take a look on this later today.


Fix clippy warning, use rustc 1.76

Sorry to put my foot in the doorway but I'd like that example to not throw red X-es all over the other PRs.

Sorry I am not sure I follow but it does not satisfy clippy anyways :D

Sorry to put my foot in the doorway but I'd like that example to not throw red X-es all over the other PRs.

The CI should stop it from getting merged anyways, no need to cancel manually.

Hmm I thought I remember Noah saying that clippy isn't a required status check

Hmm I thought I remember Noah saying that clippy isn't a required status check

Now it is :smiling_imp:. It's easy to satisfy, I think it should be required.


Remove redundant session paths in srr.py

Fixing #143.

Hello @t-sanchez! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pymialsrtk/pipelines/anatomical/srr.py:

Line 229:25: E128 continuation line under-indented for visual indent
Line 235:41: E127 continuation line over-indented for visual indent
Line 279:26: E225 missing whitespace around operator
Line 279:80: E501 line too long (88 > 79 characters)
Line 282:80: E501 line too long (82 > 79 characters)
Line 283:80: E501 line too long (94 > 79 characters)
Line 287:80: E501 line too long (82 > 79 characters)
Line 513:49: W291 trailing whitespace
Line 514:25: E128 continuation line under-indented for visual indent
Line 514:63: W291 trailing whitespace
Line 515:25: E128 continuation line under-indented for visual indent
Line 516:25: E124 closing bracket does not match visual indentation
Line 523:17: E128 continuation line under-indented for visual indent
Line 523:80: E501 line too long (81 > 79 characters)
Line 524:17: E124 closing bracket does not match visual indentation
Line 557:17: E128 continuation line under-indented for visual indent
Line 558:17: E124 closing bracket does not match visual indentation
Line 596:20: E225 missing whitespace around operator
Line 598:1: W293 blank line contains whitespace
Line 600:37: E128 continuation line under-indented for visual indent
Line 601:37: E128 continuation line under-indented for visual indent
Line 602:1: W293 blank line contains whitespace


Search and filter in conclusion view

On a large codebase when using the conclusion view, I want to be able to search and filter based on some attributes.

Filter by column attributes has been added in #118.


Ganache core chrash

Using the latest version of Metamask crashes ganache-core module when confirming a create-listing transaction in Metamask.
**Environment: **

origin-js (with ganache-core at 2.2.1), origin-dapp on master
Eth network localhost
Metamask version 4.12.0 (doesn't happen on 4.11.2)

Steps to reproduce:
Just create any normal listing and after clicking "Confirm" in Metamask origin-js container should chrash with the following error:

And browser should display these errors:

The problem seems to be that somehow we can not subscribe to events like newBlockHeaders  using http connection but works fine using web-sockets.

@nick @tyleryasaka @franckc if anyone of you has time, can you try to confirm the problem?

hmm can not consistently reproduce the problem atm... :/


Fix merging issue: $path variable may be null

$path can be set earlier with ->setPath() call.
So when a null $path is passed, $this->getPath() should be used.
It was implemented this way before, but was lost probably while resolving merging conflicts (see e4401ea20b687675178db34738a93bffd628919e).

@GrahamCampbell
Sorry. Done.

:+1:


Get our Vocel partner hooked up with the app

You don't need to build out a full deploy infrastructure for this.  This is just to get the APK available to our Vocel partner and an account that they can use to take a look at this on their phone.

Vocel is testing the app now


[Rust][CI] Move CI over to new Rust crates and try to fix flaky test.

This PR finishes the move to the new Rust bindings and tries to integrate them into existing TVM docs and CI.

@jroesch can you comment out the flaky error first? since it is confirmed but was not fixed https://github.com/apache/incubator-tvm/issues/6009

THanks @jroesch @mwillsey , this PR is now merged


Resolving Node.js packages

I really like the static nature of source resolution during Wizering as an alternative to bundling.
Further to this, it could be worth implementing the full Node.js resolution algorithm to automatically bundle dependencies from npm as well.

Checking in. I still really want to expose existing JavaScript libraries in components. For example, I want to be able to use the TypeScript compiler as a component service. With the latest tools, it currently fails:
~/ms/component/packages/cowsay> npx tsc
~/ms/component/packages/cowsay> jco componentize cowsay.js --wit src/cowsay.wit -o cowsay.wasm
Error opening file ./typescript.js (resolved to /var/folders/xm/hr4sq0d567vfs0xdth9t38zc0000gn/T/ad9807ff193c/sources/typescript.js): No such file or directory
Error: the `componentize.wizer` function trapped

Caused by:
    0: error while executing at wasm backtrace:
           0: 0x7a84c5 - <unknown>!<wasm function 12579>
           1: 0x7a798a - <unknown>!<wasm function 12356>
           2: 0x50cf26 - <unknown>!<wasm function 1721>
           3: 0x33853e - <unknown>!<wasm function 485>
       note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
    1: Exited with i32 exit status 1
(jco componentize) Error: Failed to initialize the compiled Wasm binary with Wizer:
Wizering failed to complete
    at componentize (file:///opt/homebrew/lib/node_modules/@bytecodealliance/jco/node_modules/@bytecodealliance/componentize-js/src/componentize.js:260:13)
    at async componentize (file:///opt/homebrew/lib/node_modules/@bytecodealliance/jco/src/cmd/componentize.js:11:25)
    at async file:///opt/homebrew/lib/node_modules/@bytecodealliance/jco/src/jco.js:200:9

The simplest example to get started:
src/cowsay.ts
import * as ts from 'typescript';

export const cow = {

  tsVersion() {
    return ts.version;
  }

};

It is implementing this wit:
src/cowsay.wit
package local:cowsay;
world cowsay {
  export cow: interface {
    ts-version: func() -> string;
  }
}

There are a lot of cool use cases if this could be made to work. The host would be Node.js.

@cataggar I agree that it would be cool to have full node.js resolution. In the meantime, I think bundling should help unlock the above use case you shared.

@karthik2804, that would be amazing if there was a way to unlock the above use case! What do you mean by "bundling"?

@cataggar using a bundler like webpack or rollup to do the module resolution at build time and output one singular JS file that can be passed as input to jco componentize.
ref: https://webpack.js.org/ or  https://rollupjs.org/

@karthik2804, thanks for the advice. I'll try it.

I was not able to get it to work with rollup. The stacktrace is something about "async componentize". I put a reproducible project in https://github.com/cataggar/StarlingMonkey15 .
git clone git@github.com:cataggar/StarlingMonkey15.git
cd StarlingMonkey15
npm ci
npm run build

Results in this error:
~/ms/StarlingMonkey15> npm run build

> build
> npm run build --workspace=cowsay

><EMAIL_ADDRESS>build
> npm run bundle; npm run componentize

><EMAIL_ADDRESS>bundle
> npx rollup -c

src/cowsay.ts → cowsay.js...
(!) src/cowsay.ts (4:18): Error when using sourcemap for reporting an error: Can't resolve original location of error.
/Users/cataggar/ms/StarlingMonkey15/cowsay/src/cowsay.ts:4:18
(!) Missing exports
https://rollupjs.org/troubleshooting/#error-name-is-not-exported-by-module
src/cowsay.ts
version is not exported by ../node_modules/typescript/lib/typescript.js
2: export const cow = {
3:     tsVersion() {
4:         return ts.version;
                     ^
5:     }
6: };
created cowsay.js in 2.2s

><EMAIL_ADDRESS>componentize
> npx jco componentize cowsay.js --wit src/cowsay.wit -o cowsay.wasm

Redirecting call to abort() to mozalloc_abort

Error: the `componentize.wizer` function trapped

Caused by:
    0: error while executing at wasm backtrace:
           0: 0x7a3ec5 - <unknown>!<wasm function 11740>
           1: 0x7a7fee - <unknown>!<wasm function 12478>
           2: 0x7a84e0 - <unknown>!<wasm function 12582>
           3: 0x72c8c0 - <unknown>!<wasm function 6861>
           4: 0x352387 - <unknown>!<wasm function 522>
           5: 0x6ad3b2 - <unknown>!<wasm function 4800>
           6: 0x74ed01 - <unknown>!<wasm function 7670>
           7: 0x36bb2f - <unknown>!<wasm function 562>
           8: 0x4dcd55 - <unknown>!<wasm function 1527>
           9: 0xa91cf - <unknown>!<wasm function 79>
          10: 0x3424d4 - <unknown>!<wasm function 498>
          11: 0x66ac73 - <unknown>!<wasm function 4035>
          12: 0x625349 - <unknown>!<wasm function 3385>
          13: 0x422874 - <unknown>!<wasm function 940>
          14: 0x4225c1 - <unknown>!<wasm function 940>
          15: 0x2d00ad - <unknown>!<wasm function 358>
          16: 0x1fc7ba - <unknown>!<wasm function 186>
          17: 0x50ceed - <unknown>!<wasm function 1721>
          18: 0x33853e - <unknown>!<wasm function 485>
       note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information
    1: wasm trap: wasm `unreachable` instruction executed
(jco componentize) Error: Failed to initialize the compiled Wasm binary with Wizer:
Wizering failed to complete
    at componentize (file:///Users/cataggar/ms/StarlingMonkey15/node_modules/@bytecodealliance/componentize-js/src/componentize.js:260:13)
    at async componentize (file:///Users/cataggar/ms/StarlingMonkey15/node_modules/@bytecodealliance/jco/src/cmd/componentize.js:11:25)
    at async file:///Users/cataggar/ms/StarlingMonkey15/node_modules/@bytecodealliance/jco/src/jco.js:200:9
npm error Lifecycle script `componentize` failed with error:
npm error code 1
npm error path /Users/cataggar/ms/StarlingMonkey15/cowsay
npm error workspace<EMAIL_ADDRESS>npm error location /Users/cataggar/ms/StarlingMonkey15/cowsay
npm error command failed
npm error command /opt/homebrew/bin/nu -c npx jco componentize cowsay.js --wit src/cowsay.wit -o cowsay.wasm
npm error Lifecycle script `build` failed with error:
npm error code 1
npm error path /Users/cataggar/ms/StarlingMonkey15/cowsay
npm error workspace<EMAIL_ADDRESS>npm error location /Users/cataggar/ms/StarlingMonkey15/cowsay
npm error command failed
npm error command /opt/homebrew/bin/nu -c npm run bundle; npm run componentize

I debugged this for a bit and uploaded the debug sources with details in https://github.com/bytecodealliance/wizer/issues/121 .

Hey @cataggar a bit late here (I assume you're past this now!), but I did manage to get including external libs working with Rollup -- if you can ignore the wasmCloud specific stuff,  I was able to pull in valibot for use in one of our example components.


Update triggers project

Changes

Updates shipwright-io/build to v0.13.0 plus necessary code changes
Updates some locations where Go version was not updated to 1.21
Updates the envtest version to a specific one that does not require Go 1.22

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE

/lgtm


Clean up logos

Removed some old logo images that no longer needed.

@acordonez I don't think this would affect any of current working flows but just tagged you for your interest.


Updates to PrecipTable and Added New Stratified Sampling Notebook and .py file

Added updates to the PrecipTable file so that it works with the NOAA website format. Added files EventTable_Stratified.ipynb and hydromet_stratified.py to calculate runoff events with a stratified sampling approach. The new functions from hydromet_stratified.py eventually can be merged into the hydromet.py file.

This PR was reviewed by creating branch pr/42. Since extensive updates were made, including resolving conflicts, the content of this PR will be merged in PR #44 and this one will be closed.


Update how-to-create-load-test-app-service.md

Removed the banner stating where to get support as this is now supported by CSS, instead of engineering team.

[!IMPORTANT]
This feature is currently supported through Microsoft Developer Community. If you are facing any issues, please report it here.

@ninallam -

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Documentation doesn't describe terminology

A detailed description of the proposed feature
Documentation should be amended with information about what the terminology used in brew actually refers to.
The motivation for the feature
I have used brew for years and I still don't quite understand what a cask or a tap or a fomula is. It makes it a black box where I just know which magic commands that I need to invoke in order to install, update, and remove features.
How the feature would be relevant to at least 90% of Homebrew users
90% of users are not maintainers of the project, so they would not know other than through reading 3rd-party blogs or Stackoverflow posts. Definition of terminology should be established by the project owners. Especially when it is non-standard.
What alternatives to the feature have been considered
Not sticking to a brew terminology. I mean, that's really the underlying problem. We're trying to retrofit one domain language to another.

https://docs.brew.sh/Formula-Cookbook#homebrew-terminology

The terminology is a preface to the "Formula Cookbook", which in a section a section of the documentation for contributors.
Am I the only one seeing a problem with that?

Am I the only one seeing a problem with that?

Probably not but I'm not sure I see any actionable outcomes from your request. We cannot at this stage rename everything (it would make it confusing to all existing users) and we have documented this and it shows up for a search of "homebrew mac terminology".

It could be a topic in the Users section of the documentation. As of now, there is no description of what these items mean. In fact, the first item in the list at https://docs.brew.sh/ is a link to the man page, which makes little sense without an understanding of the terminology.

In fact, the first item in the list at https://docs.brew.sh/ is a link to the man page, which makes little sense without an understanding of the terminology.

I disagree.

A list of terms from "Troy Prog Blog"

Which defines the terminology almost completely correct.

2. The homebrew FAQ, which has no mention of terminology

https://docs.brew.sh/FAQ#is-there-a-glossary-of-terms-around which uses the word "terminology"

3. "Formula Cookbook", which as an end-user gives me no hints as to this is where I should go to look for terminology.

Search for "terminology" on the page (as hinted by the search result).

That should probably tell you that it is not in a good place for an end-user...

No, it tells me you do not think it's in a good place and not that the majority of users agree with you.

It could be a topic in the Users section of the documentation.

We'd consider a PR that moved this from the Formula Cookbook to that section.

The fact that you think the man page makes sense without understanding the terminology probably is a consequence of you already having a great first-hand understanding of said terminology. The command listed is:
install formula:
    Install formula.

That's it. What's a formula? It's something I install.
Also, I'd argue that the fact that Troy felt it necessary to create his own list of terms at a time where the terminology list in the contributor section already existed should speak to the fact that it might not be located and descriped all too well.
Anyway, I can see that there is no way I can convince you that it is important that users understand the non-standard brewery domain terminology used in homebrew.

We'd consider a PR that moved this from the Formula Cookbook to that section.

I'd love to, but your dismissiveness makes me think that this would just be a waste of time.

Anyway, I can see that there is no way I can convince you that it is important that users understand the non-standard brewery domain terminology used in homebrew.

There's not no way but you've been unsuccessful so far in convincing me that for Homebrew to be useful to a user you need to understand our definition of "formula".

I'd love to, but your dismissiveness makes me think that this would just be a waste of time.

 I've spent my weekend discussing this issue with you. "Dismissiveness" would be to ignore what you are saying rather than spend my time pointing out where you've said things that aren't accurate.

If you can find a single PR in a project I currently actively maintain in which I've ignored a request for review on a PR for months at a time I'll be very surprised. If you can find any PR in this project that has gone ignored for months (without unaddressed feedback) I'll also be surprised. I don't appreciate the insinuation here and I'd recommend against throwing around these sort of accusations on open source projects. Locking this because this conversation has become unproductive: I'll happily review a PR.


[BUG] About tab takes FOREVER to load

🔵 Describe the bug:
The about tab in the GSE options take forever ( like 10s ) to load and pulses 100% CPU until loaded.
🔵 To reproduce: (Steps to reproduce the behavior)
ESC -> Options -> Addons -> GSE - About
🔵 Desktop (please complete the following information):

OS: Linux Tumbleweed - 560 NVidia drivers - Wayland
Wow retail - ELVUI

🔵 GSE Version:

Version: 3.2.14-a
Downloaded From: WoWup - CF

🔵 Additional context:
This also makes the wow ui ( not client ) crash into 50000 lue errors until reloaded. The about window shows up fine tho.
And after a reload the client is fine again as well .. until you hit about again.

A fix for this is on wago/curseforge as alpha GSE-3.2.14-a-2-g904436d  This should be significantly improved.  It will be part of the 3.2.15 release.


why doesn't await PLC.getControllerTagList(tagList) work?

Current Behavior

returns:
node:436) UnhandledPromiseRejectionWarning: #
(Use node --trace-warnings ... to show where the warning was created)
(node:436) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict
(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:436) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Expected Behavior

it should get tag list from PLC.
Possible Solution (Optional)

Context

const {Controller, Tag, TagList} = require('ethernet-ip');
const PLC = new Controller();
const tagList = new TagList();
PLC.connect('address ip', 0).then(async () => {
await PLC.getControllerTagList(tagList);
console.log(tagList);
});
Steps to Reproduce (for bugs only)

Your Environment

Package version (Use npm list - e.g. 1.0.6):
Node Version (Use node --version - e.g. 9.8.0):
Operating System and version: windows 7
Controller Type (eg 1756-L83E/B):
Controller Firmware (eg 30.11):

Should be require('st-ethernet-ip') .To show the actual error add a catch() to the end of the PLC.connect() function.  reply back what you get.
const {Controller, Tag, TagList} = require('st-ethernet-ip');

const PLC = new Controller();
const tagList = new TagList();

PLC.connect('address ip', 0).then(async () => {
await PLC.getControllerTagList(tagList);
console.log(tagList);

}).catch(e => { console.log(e) } );

something like that? { generalStatusCode: 5, extendedStatus: [ 0 ] }

OK now it says: [object Object].

That error is Request Path destination unknown: Probably instance number is not present
Are you connected to the ethernet port on the controller or a card plugged into a slot?
Also double check IP address and check controller properties on the security tab that you don't have the communications restricted.

I pinged that address ip and everything is fine. PLC model is Intel(R) 82579LM Gigabit Network Connection.

PLC models that this library is compatible with are Compactlogix and Controllogix from Allen Bradley.  I believe  Intel(R) 82579LM Gigabit Network Connection is not a PLC


pytorch: safetensors library hardcodes using CUDA if only device index is provided

In relevance to:

https://github.com/huggingface/transformers/issues/31941

safetensors library hardcodes returning CUDA device if only device index is provided. This causes runtime errors running huggingface models with pipeline(device_map="auto") as noted in https://github.com/huggingface/transformers/issues/31941 (see this issue for repro steps). Hardcoding is happening here:
https://github.com/huggingface/safetensors/blob/079781fd0dc455ba0fe851e2b4507c33d0c0d407/bindings/python/src/lib.rs#L296-L297
A possible solution might be to return the device returned by torch.device(N). Note however that this will work for non-CUDA devices only after the following change in pytorch will be merged:

https://github.com/pytorch/pytorch/pull/129119
This change modifies behavior for torch.device(N) to return current accelerator device instead of cuda device. This seems to be anticipated change by huggingface according to https://github.com/huggingface/accelerate/pull/2874#issuecomment-2204803710.

CC: @faaany @muellerzr @SunMarc @guangyey

FYI, https://github.com/pytorch/pytorch/pull/129119 got merged, so solution which I outlined should now be possible.

I have implemented a fix for this issue as I do see it. Please, help review https://github.com/huggingface/safetensors/pull/500.


feat(threads): adds ignore blocks

The idea here is to just ignore blocks when listing that have been flagged as "ignore".
fixes #172

i've updated my mobile PR here https://github.com/textileio/textile-mobile/pull/270 with this as the fmwk


SAP showing solidarity - Closing all businesses

SAP has closed all their businesses in Russia and will ignore the ~800.000.000 Euros they made in Russia every year.
I hope that's enough to get SAP Archivelink off this list.

Thanks! Please unclude a link to the source, if possible. I'm goin to remove SAP, ASAP :)

@cyb3rko ?

Ok, I just saw the numbers differ. I updated it to "only" 468 million, as this is the minimum the company loses in a year now.
One of the many sources is this page:
https://www.computerweekly.com/news/252514133/SAP-and-Oracle-express-solidarity-with-Ukraine-against-Russia
Important cite:
"Economic sanctions against Russia are an important mechanism in the efforts to restore peace,” said Klein. “We are in constant exchange with governments around the world, have every confidence in their guidance, and fully support the actions taken so far. We are stopping business in Russia aligned with sanctions and, in addition, pausing all sales of SAP services and products in Russia.”

Thank you! Fixed


Add a Gitter chat badge to README.md

lukashinsch/spring-boot-actuator-endpoint-list now has a Chat Room on Gitter
@lukashinsch has just created a chat room. You can visit it here: https://gitter.im/lukashinsch/spring-boot-actuator-endpoint-list.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Coverage remained the same at 94.23% when pulling 389456ddd38c8678e2b2ac88830a3e6c52a1c1a7 on gitter-badger:gitter-badge into 4683a7327d66e8a1b4fc67ceb856a60730a3902d on lukashinsch:master.


How to get result from conditional update

I tried using a custom ResultListener, but it doesn't always work correctly.
public class ResultListener implements LWTResultListener {

  private boolean applied;

  @Override
  public void onSuccess() {
     applied = true;
  }

  @Override
  public void onError(LWTResult lwtResult) {
    applied = false;
  }

  public boolean isApplied() {
    return applied;
  }
}

From my caller class, I call isApplied() but it seems that the onSuccess method is called asynchronously. The caller class doesn't see the updated value of applied field

I understand your problem but it's the nature of asynchronous execution. To solve this, in my integration test, I have the following pattern:

  final CountDownLatch latch = new CountDownLatch(1);
  final AtomicBoolean success = new AtomicBoolean(false);

 //When
        manager
                .dsl()
                .update()
                .fromBaseTable()
                 ...
                .withLwtResultListener(new LWTResultListener() {
                    @Override
                    public void onSuccess() {
                        success.getAndSet(true);
                    }

                    @Override
                    public void onError(LWTResult lwtResult) {
                    }
                })
                .withResultSetAsyncListener(rs -> {
                    latch.countDown();
                    return rs;
                })
                .executeAsync();

        //Then
        latch.await();
       assertThat(success.get()).isTrue();

First I declare 2 variables:

a countdown latch, to be triggered when the ResultSet is available asynchronously
an atomic boolean (or any AtomicXXXX class) that is by nature thread-safe to update the result of the asynchronous operation

With withLwtResultListener() I passed in an instance of LWTResultListener to set the atomic boolean value to true
However, if you only do that, the main thread will call immediately assertThat(success.get()).isTrue() before the LWTResultListener has a chance to be called ...
Therefore I need to add an withResultSetAsyncListener() to trigger the latch count down when the result set is available asynchronously.
In the main execution thread, I block on latch.await() until the latch.countDown() is called.
You can adapt this pattern to your use-case

Thanks!


Memo When Sending to T-address

Subject
There shouldn’t be a memo field when sending to a t-addr
Your environment

version of YWallet: 1.4.1
platform and version. iOS 16.6

Steps to reproduce
Sending single txn from Orchard to a t-addr.
My problem
Ywallet allows user to fill out a memo when sending to a t-addr, but t-addr can’t receive memos. This is confusing. Suggestion: have memo area be grayed out or disappear if recipient address is a t-addr.

The user is free to fill the form in any order. We let them enter a memo before the address. Therefore, we don't disable the memo field.

I would consider graying out the memo field if a t-addr is entered.
Allowing a user to take an action that they think is doing one thing
(including a memo to a t-addr recipient) while in reality not doing that
thing adds confusion and friction to an experience which is already
confusing to many users.
On Thu, Sep 28, 2023 at 16:52 hhanh00 @.***> wrote:

The user is free to fill the form in any order. We let them enter a memo
before the address. Therefore, we don't disable the memo field.
—
Reply to this email directly, view it on GitHub
https://github.com/hhanh00/zwallet/issues/99#issuecomment-1740134756,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV7URA3UWWWSUMYQ666RRVLX4YEUTANCNFSM6AAAAAA3SUI7YA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Adding git tag as an attribute to ComponentRun

Addresses #176

[x] Add git tag as an attribute to ComponentRun
[x] Update log_component_run and register functions inside client.py to set git tag automatically
[x] Update ORM accordingly (should git tags be a separate table?) UPDATE: for simplicity, store git tags as "," delimited str instead
[x] Update tests
[ ] Update Blueprint.js info card
[x] Update CLI info card (?)
[x] Add alembic upgrade script
[x] Add example of using git tags with DVC in documentation

@jeannefukumaru how is this going? I can take care of the UI if you are interested :)

Hi @shreyashankar thanks for checking in. Yes the UI task would be useful to get help on. Apart from that the alembic migration script needs to be added, and also an example in the documentation of how to use the git tag with DVC. I got side-tracked for a bit but should be good to submit this for review by the end of the week.

Ok awesome -- no worries! Let me know if there is anything else I can take off your plate, I will get started on the UI stuff after you submit for review

@shreyashankar pull request is ready for review ~ I've added an example under the examples/ folder for how to get started using mltrace and dvc together. Happy to make changes as needed especially if we have more ideas on how to add versioning to more aspects of mltrace

Awesome; thanks! Will take a look at it sometime today :)

Awesome -- I'll take a stab at the UI stuff today


Add faking for backend routes to application builder

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>

This PR is an unfortunate investment in ApplicationBuilder which is likely to be deprecated soon for being replaced with something more Feature-friendly. That being said, the PR introduces new injectables, making it welcome in codebase.

Trying to see the bigger picture: I'm thinking we instead of this PR consolidate API-based messaging to abstracted messaging (which is currently implemented as IPC). That would mean the current fake messaging could take over, and we would be able to control the phenomenon from single abstraction. We would have one way to do one thing, ie. messaging.

That would be a HUGE ask, and I think it would be a better use of time if we could instead start writing unit tests for the whole flow (including requesting from kube resources). Since those sorts of requests will probably always need to be done of HTTP.


Add timeout utility function

This PR adds the timeout utility function. It also updates all the tests, example code and examples to use it.
Closes #111

What do you think about testing the timeout? Both options seem a bit strange, but thankfully Vitest has time faking built in - https://vitest.dev/api/vi.html#fake-timers - so hopefully it'd be quite straightforward

What do you think about testing the timeout? Both options seem a bit strange, but thankfully Vitest has time faking built in - https://vitest.dev/api/vi.html#fake-timers - so hopefully it'd be quite straightforward

Yeah so currently it's indirectly tested through all other tests. Testing it directly should be possible (without fake timers) though. I'll add something.

What do you think about testing the timeout? Both options seem a bit strange, but thankfully Vitest has time faking built in - https://vitest.dev/api/vi.html#fake-timers - so hopefully it'd be quite straightforward

Added some tests, 1 without fake timers (since I wanted to verify the microtick) and 1 with fake timers (to check the longer duration).

Very cool...i'm wondering if we should expose utils as an export instead of "polluting" the main export. We could also export didCancel from there.
WDYT? Feel free to merge if you think it should be from the main one or refactor and merge otherwise! 🚀

We didn't seem to have a very clear strategy about that yet, let's discuss during the sync.


[FIX]In some cases the merged XML was missing blocks or fields

Bob,
Both where problematic in the past. This is the reason we took them out in the old module (the Java one).
I would prefer taking them out now (just like we did in the past) and pick the implementation of annotation and image merge up in a later stage.

Allright, that seems fair enough to me (for the time being).
I created issue #16 to handle those image and annotation elements in the merge.


better deconversion

About the PR
when all headrevs die:

all revs get a window explaining they got deconverted
role is now removed when deconverted

Why / Balance

during a fight its hard to see the popup or losing icons, a window explaining that is imposible to ignore.
fixes #21828

Technical details
copy pasted ghost reviving menu idk if it can use xaml or something now
Media
the window

no longer valid

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no
Changelog
:cl:

tweak: Revolutionaries that are deconverted by headrevs dying get a window shown explaining that they are no longer antagonists, to help with tunnel vision.

Is "You forget everything that happened since being converted" even true though? It does not seem to be part of the rules nor MRP's New Life Rule. Seems like a weird inclusion.

its not a rule but:

makes it clearer that revs arent liable for anything they did :trollface: which is already how its done in practice
you shouldnt really act on information while you are hypnotised

this is based on gameplay from mrp idk how lrp shitters handle it

could remove the amnesia bit if admins think its best

If we want a rule change on how Deconversion memory works that should come separately from this no? That's an over-arching rule change and the only way to learn about it is through this specific end-game prompt (not even on mind-shielding deconversion, which is where this seems more important to mention...).

revs cant testify to what a headrev did while they are converted

This is a very large change in the dynamics of a Revs round than what seems relevant to the scope of this PR (notification of deconversion), and seems far more important to mention during a mind-shielding than in the aftermath of HRs dying anyway, as all it really does when being mentioned there is remove any RP relating to the consequences of your actions/coping and such.
I'd rather see the amnesia mention removed and memory retention decided upon as an actual rule change from admins first, given how much it changes.

Consensus is that Revolutionary conversion is brainwashing, not hypnosis.

Is it a good idea to make UI with C#? I think it can be done with XAML easier and will make the code more readable

thank you 🙏  unconverted revs gibbing clown will now know they're not rev and gib clown in peace.


pip installation fails: ImportError: No module named PIL

trying to install with pip in a virtual env on linux mint 18 fails:
(env27) USERNAME@BOX ~PATH $ python --version
Python 2.7.12
(env27) USERNAME@BOX ~PATH $ pip --version
pip 8.1.2 from /home/USERNAMEPATH/env27/local/lib/python2.7/site-packages (python 2.7)
(env27) USERNAME@BOX ~PATH $ pip install matplotlib2tikz
Collecting matplotlib2tikz
  Using cached matplotlib2tikz-0.5.16.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-MfzOn6/matplotlib2tikz/setup.py", line 7, in <module>
        from matplotlib2tikz import __version__, __license__, __author__, __email__
      File "matplotlib2tikz/__init__.py", line 15, in <module>
        from matplotlib2tikz.save import save
      File "matplotlib2tikz/save.py", line 6, in <module>
        from . import image as img
      File "matplotlib2tikz/image.py", line 6, in <module>
        import PIL
    ImportError: No module named PIL

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-MfzOn6/matplotlib2tikz/
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
(env27) USERNAME@BOX ~PATH $

EDIT: upgrading to pip to 9.0.1 doesn't help
Suggestions as to why?

No idea. requirements.txt lists Pillow so pip should pick up on this. Have you tried installing Pillow separately?

Manually installing pillow solved my problem, thanks;
(env27) USERNAME@BOX ~PATH $ pip install pillow
Collecting pillow
  Downloading Pillow-4.0.0-cp27-cp27mu-manylinux1_x86_64.whl (5.6MB)
    100% |████████████████████████████████| 5.6MB 165kB/s
Collecting olefile (from pillow)
  Downloading olefile-0.44.zip (74kB)
    100% |████████████████████████████████| 81kB 785kB/s
Building wheels for collected packages: olefile
  Running setup.py bdist_wheel for olefile ... done
  Stored in directory: /home/USERNAME/.cache/pip/wheels/20/58/49/cc7bd00345397059149a10b0259ef38b867935ea2ecff99a9b
Successfully built olefile
Installing collected packages: olefile, pillow
Successfully installed olefile-0.44 pillow-4.0.0
(env27) USERNAME@BOX ~PATH $ pip install matplotlib2tikz
Collecting matplotlib2tikz
  Using cached matplotlib2tikz-0.5.16.tar.gz
Building wheels for collected packages: matplotlib2tikz
  Running setup.py bdist_wheel for matplotlib2tikz ... done
  Stored in directory: /home/USERNAME/.cache/pip/wheels/41/4f/87/63fc4df5294c688f447f92255e40842917b217eb84ef93ee3b
Successfully built matplotlib2tikz
Installing collected packages: matplotlib2tikz
Successfully installed matplotlib2tikz-0.5.16
(env27) USERNAME@BOX ~PATH $


Python debug configuration is added

Python debug DAP configuration is added for handlers.
This sample can be helpful for beginners who wanted to debug python.
I spent 2 weeks to figure it out. Thought of adding the sample here so that others need not to spend the same amount of time.
Thank you so much for this kickstart.nvim .

Hi, thanks for the contribution but I have very mixed feelings about this one.
This isn't how I configure nvim-dap-python, and I think a single example will suffice just fine.
I'm tempted to close this unless you can make a super compelling argument for your change :)

I have added pytest debug configuration and profiler debug configuration as well.
For a beginner there will be confusion where to configure what , so I added it.
If you think these additional configurations can be added in much simpler way then it would be good if you can add those examples (I also will learn from it) :)

I can appreciate that. The problem is that there are a million different languages and everyone has different favorites. If we add them all kickstart will become ENORMOUS and impossible to maintain.
Here's a link to my debug configuration that might give you some ideas, but I'm closing this for now. Thanks again for the contribution!


feat: resolve multiple function/event selectors in one openchain.xyz request

Motivation
Currently, the number of HTTP requests to openchain.xyz is equal to the number of selectors to resolve, which is not optimal.
On the current master, the following cast run takes ~11 seconds:
# run twice to ensure that the blockchain state is cached, and almost all time is spent on openchain.xyz requests
$ rm ~/.foundry/cache/signatures
$ cast run -q 0xa4fd571d66e89df8ed0ff4cf2eaea0ef56b75470715b89253cb833598e08ffec

I've added println!("get {url}"); to selectors.rs:58 and got:
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x7527b51c
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x128acb08
get https://api.openchain.xyz/signature-database/v1/lookup?event=0xc42079f94a6350d7e6235f29174924f928cc2ac818eb64fed8004e115fbcca67
get https://api.openchain.xyz/signature-database/v1/lookup?function=0xa9059cbb
get https://api.openchain.xyz/signature-database/v1/lookup?event=0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x70a08231
get https://api.openchain.xyz/signature-database/v1/lookup?function=0xfa461e33
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x022c0d9f
get https://api.openchain.xyz/signature-database/v1/lookup?event=0x1c411e9a96e071241c2f21f7726b17ae89e3cab4c78be50e062b03a9fffbbad1
get https://api.openchain.xyz/signature-database/v1/lookup?event=0xd78ad95fa46c994b6551d0da85fc275fe613ce37657fb8d5e3d130840159d822
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x66e27b0c
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x095ea7b3
get https://api.openchain.xyz/signature-database/v1/lookup?event=0x8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b925
get https://api.openchain.xyz/signature-database/v1/lookup?function=0xe5d7bde6
get https://api.openchain.xyz/signature-database/v1/lookup?event=0xb9ed0243fdf00f0545c63a0af8850c090d86bb46682baec4bf3c496814fe4f02
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x2cc2878d
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x23b872dd
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x52bbbe29
get https://api.openchain.xyz/signature-database/v1/lookup?event=0x2170c741c41531aec20e7c107c24eecfdd15e69c9bb0a8dd37b1840b9e0b207b
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x9d2c110c

Solution
openchain.xyz's api supports multiple selectors in one request - let's use that feature.
After the proposed changes, cast run ... took 2.8 seconds - x4 faster than before
get https://api.openchain.xyz/signature-database/v1/lookup?function=0x9d2c110c,0xa9059cbb,0x2cc2878d,0xfa461e33,0x128acb08,0x52bbbe29,0x66e27b0c,0x7527b51c,0x70a08231,0x022c0d9f,0x095ea7b3,0xe5d7bde6,0x23b872dd
get https://api.openchain.xyz/signature-database/v1/lookup?event=0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef,0xc42079f94a6350d7e6235f29174924f928cc2ac818eb64fed8004e115fbcca67,0x2170c741c415
31aec20e7c107c24eecfdd15e69c9bb0a8dd37b1840b9e0b207b,0x8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b925,0xd78ad95fa46c994b6551d0da85fc275fe613ce37657fb8d5e3d130840159d822,0xb9ed0243fdf00f0545c63a0a
f8850c090d86bb46682baec4bf3c496814fe4f02,0x1c411e9a96e071241c2f21f7726b17ae89e3cab4c78be50e062b03a9fffbbad1

cc @Evalir @onbjerg

@onbjerg, are there any more 'big changes' planned? I've noticed a merge conflict, and while I can resolve it, it won't be a quick 1-minute task due to the changes in d46bcb3dd, so it's better to do it only once

@Evalir, what do you mean by 'needs clippy'? It seems that other MR no longer fail on clippy nightly. Unfortunately, I don't have the rights to restart the clippy check in this MR, should I force-push just to restart pipeline?


Can it be uploaded/released to pypi.org?

Thanks a lot for the great repository.
Would it be possible to release the package to pypi.org? This way the pip installation becomes easier without the need to git clone the repository.
Thanks a lot

Good advice. But I am afraid this repo is not ready for a pre-built package version. I need to figure out how to package custom ops into the package and add enough unit tests.


DUPLO-4820 : Error: No infrastructure named 'default' was found

DUPLO-4820 : Error: No infrastructure named 'default' was found

Task linked: DUPLO-4820 TF: not able to plan admin-tenant for default infrastructure


Improve HostConfig.prepareUpdate

In the HostConfig in BlueprintRenderer.js the prepareUpdate method is pretty innefficient. It creates an update payload that contains all the old properties and all the new properties. Instead, it should create an update payload containing only new or changed properties so that we don't call into View::setProperty on things that haven't changed

Fixed in 99433ec74879f43f429cbadd4c7bc1d0c3dadb33


Catching some more errors

Commit 2 is the only one with real substance here (at least I hope) - without it the hard validation doesn't get set when creating or updating a taxon name.
p.s. I don't mind submitting these error-catching fixes, but feel free to weigh in on whether they're worth it. Personally I almost only work in docker development, so I have to deal with the red overlays, but actual users never see them, so the error-catching changes have no effect on them.

All error catching is good.  Errors that happen "anonymously" are not OK :).

Codecov Report
Attention: Patch coverage is 53.84615% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 58.20%. Comparing base (cf4d96a) to head (13fe2a5).
Report is 27 commits behind head on development.

:exclamation: Current head 13fe2a5 differs from pull request most recent head d3256ce. Consider uploading reports for the commit d3256ce to get more accurate results

Files
Patch %
Lines

app/models/internal_attribute.rb
15.78%
16 Missing :warning:

lib/query_batch_request.rb
16.66%
5 Missing :warning:

app/controllers/data_attributes_controller.rb
25.00%
3 Missing :warning:

lib/queries/query/filter.rb
81.81%
2 Missing :warning:

app/models/concerns/shared/query_batch_update.rb
0.00%
1 Missing :warning:

...pp/models/dataset_record/darwin_core/occurrence.rb
0.00%
1 Missing :warning:

app/models/dataset_record/darwin_core/taxon.rb
0.00%
1 Missing :warning:

lib/utilities/geo.rb
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           development    #3872       +/-   ##
================================================
- Coverage        84.74%   58.20%   -26.54%
================================================
  Files             2106     1626      -480
  Lines            77772    50528    -27244
================================================
- Hits             65908    29411    -36497
- Misses           11864    21117     +9253

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Extension issue

Issue Type: Bug
Extension Name: vscode-eslint
Extension Version: 2.1.23
OS Version: Darwin x64 20.6.0
VS Code version: 1.60.0

{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 10,
		"activateCallTime": 47,
		"activateResolvedTime": 11,
		"activationReason": {
			"startup": false,
			"extensionId": {
				"value": "dbaeumer.vscode-eslint",
				"_lower": "dbaeumer.vscode-eslint"
			},
			"activationEvent": "onStartupFinished"
		}
	},
	"runtimeErrors": [],
	"runningLocation": 1
}

Actually these number look pretty good. Totoal < 100ms. Was there anything additional that made you file the issue?

Without the additional information we can't work on this issue. Please ping when the information is available and we will reopen the issue.


[Corus] Add Séries+

Checklist

[x] I'm reporting a site feature request
[x] I've verified that I'm running youtube-dl version 2019.04.24
[x] I've searched the bugtracker for similar site feature requests including closed ones

Description

Possible to add support to the site serieplus.com group of Corus.
https://www.seriesplus.com/videos/
Thank.
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.seriesplus.com/emissions/soupon-de-magie/videos/la-robe-idale/1490021955940/', '-v']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2019.04.24
[debug] Python version 3.7.3 (CPython) - Windows-10-10.0.17763-SP0
[debug] exe versions: ffmpeg N-93678-g4b7166c9d5, ffprobe N-93678-g4b7166c9d5
[debug] Proxy map: {}
[generic]<PHONE_NUMBER>940: Requesting header
WARNING: Falling back on generic information extractor.
[generic]<PHONE_NUMBER>940: Downloading webpage
[generic]<PHONE_NUMBER>940: Extracting information
ERROR: Unsupported URL: https://www.seriesplus.com/emissions/soupon-de-magie/videos/la-robe-idale/1490021955940/
Traceback (most recent call last):
  File "c:\users\barat\appdata\local\programs\python\python37\lib\site-packages\youtube_dl\YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "c:\users\barat\appdata\local\programs\python\python37\lib\site-packages\youtube_dl\extractor\common.py", line 529, in extract
    ie_result = self._real_extract(url)
  File "c:\users\barat\appdata\local\programs\python\python37\lib\site-packages\youtube_dl\extractor\generic.py", line 3320, in _real_extract
    raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.seriesplus.com/emissions/soupon-de-magie/videos/la-robe-idale/1490021955940/```

This one is pretty easy to do once #22075 is resolved


Port NULL as s-c-s sink

From @sabbyanandan on November 14, 2015 0:14
As a developer, I'd like to move null module from XD to s-c-s repo, so I can use it as sink to build streaming pipeline.
Acceptance:

null as sink module is available in spring-cloud-stream-modules repo
maven repo includes null module with respective group/artifact/version detail

Copied from original issue: spring-cloud/spring-cloud-stream-modules#78

This issue was moved to spring-cloud-stream-app-starters/app-starters-release#12


Unable to parse template file paket.template No indented block following name 'tags' line 10.

Starting the build script the first time the following message comes up:
# NOTE: Aside from the Project Name, you may leave any
# of these blank, but you will need to change the defaults
# in the generated scripts.

So I left the tags field empty. Unfortunately the release process needs it:
Starting Target: NuGet (==> All)
C:\...\ProjectScaffold-master\.paket\paket.exe pack output bin version  1.0.2 releaseNotes  "
SourceLink removed since it throws errors."
Paket version <IP_ADDRESS>
Paket failed with:
        Unable to parse template file C:\...\ProjectScaffold-master\src\test\paket.template:
No indented block following name 'tags' line 10.
Running build failed.
Error:
System.Exception: Error during packing ..
   bei Fake.Paket.Pack@68.Invoke(String message) in C:\code\fake\src\app\FakeLib\PaketHelper.fs:Zeile 68.
   bei Fake.Paket.Pack(FSharpFunc`2 setParams) in C:\code\fake\src\app\FakeLib\PaketHelper.fs:Zeile 68.
   bei FSI_0005.Build.clo@180-16.Invoke(Unit _arg9) in C:\...\ProjectScaffold-master\build.fsx:Zeile 181.
   bei Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in C:\code\fake\src\app\FakeLib\TargetHelper.fs:Zeile 411.

Are tags mandatory for publishing NuGet packages?

I can reproduce this error by also leaving the tags empty. A bit of experimentation showed the following:

If Paket sees a "tags" line followed by an "empty" line in paket.template (that is, four spaces with no text after them, which is what gets produced by the init.fsx script when you leave the tags empty), this error occurs.
If the "tags" line, and the spaces-only line that follows it, are removed, Paket runs without complaining.
If the "tags" line and its following spaces-only line are commented out, Paket also runs without complaining.

I suggest that if the user presses Enter (without typing in anything) during any part of the init.fsx question script, so that the corresponding field (like "tags") is empty, the paket.template file should be generated with that line present but commented out. With, perhaps, a suitable sample to show how it should be populated once the user uncomments it. E.g., if the user doesn't select any tags, then this is how the "tags" section of paket.template gets written:
# Tags should be space-separated.
#tags
#    tag1 tag2 tag3

@rmunn

I suggest that if the user presses Enter (without typing in anything) during any part of the init.fsx question script, so that the corresponding field (like "tags") is empty, the paket.template file should be generated with that line present but commented out. With, perhaps, a suitable sample to show how it should be populated once the user uncomments it. E.g., if the user doesn't select any tags, then this is how the "tags" section of paket.template gets written:

Can you send a PR for that? thanks


Integrate Structured Logging

Specification
Structured logging is to use JSON on the STDERR logs. This exposes more of the data, and allows us to create a standard for the set of fields to be used.
There's no real official standard for structured logging. But journalctl and syslog defines some common fields. The fields can be similar to our formatting that we already use, but this time in a JSON format. Additional data fields can be encoded too.
We could put a json formatting in somewhere that provides the JSON serialisation.
This can be especially useful since we are also looking into adding error chaining, which we have done in a few places. But by creating our own @matrixai/error we can implement error chaining. https://github.com/MatrixAI/js-polykey/issues/304
Additional context

https://github.com/MatrixAI/js-polykey/issues/304
https://www.structlog.org/en/stable/
https://github.com/uber-go/zap
https://github.com/MatrixAI/js-polykey/pull/283#issuecomment-986400664 - where an error came up and no context was there, but all in the data which required manual serialisation

Tasks

...
...
...

Need to consider a couple of things:

Common fields that should align with other structured logging mechanisms
The --format field used for output formatting can double as for logger formatting too
How does error chaining come into play here, and how should these be shown?
How does stack traces come into play here? Stack traces don't have sensitive information, they are just traces of what functions called what functions.

So basically the problem is this:

Does --format apply to just STDOUT or also to  STDERR? I believe it should apply to both. Especially as STDERR will likely be relied on upon quite a bit by pk agent start. So doing something like pk agent start --format=json --verbose will then ensure that INFO messages get logged out to STDERR by with JSON structure rather than human readable messages. This will be important for any kind of long-term debugging of the PK agent.
If --format applies to STDERR as well, this then affects the PK CLI calls which would mean any exception plus INFO messages would also become JSON. This is OK as we can expect that once --format=json is used, we would actually want this to be worked by a computer.

Therefore any usage by a computer should always use --format=json. It would affect exception output on STDERR, logging messages to STDERR, and output to STDOUT.

One additional issue is the "level of verbosity". This is basically controlled by --verbose. But when we output an exception to STDERR, we don't currently show the stack trace atm. The root exception handler by the PK agent and in PK CLI calls don't show the stack trace. The stack trace is useful for tracing where the error comes from.
Right now verbosity only controls INFO, WARNING... etc. We could do something where one chooses to use logger.debug to show the stacktrace as well if the logger level is appropriate. But this requires a conditional check on the logger's effective level.
Something like:
if (this.logger.getEffectiveLevel() > ...) {
  this.logger.debug(e, ...); // include stack trace
} else {
  this.logger.info(e, ...); // don't include stack trace
}

A similar situation would apply to errors being thrown over the GRPC boundary as discussed here https://github.com/MatrixAI/js-polykey/issues/249.
I reckon something can be automated if we integrate the design of js-logger with js-errors library here https://github.com/MatrixAI/js-polykey/issues/304, such that when an error is being logged out, we gain additional context depending on what the log level is. Of course what errors is passed over GRPC also depends, some errors we only want to write to the agent's STDERR, other errors we want to propagate to the GRPC client, and in other cases we would want to "map" agent-local errors to GRPC API errors.
This would mean something like catch a local agent error, write that out to STDERR on the agent on the RPC handler, then create a new error to be propagated to the GRPC client. We have to separate client errors from server errors like in HTTP where there is 4xx errors vs 5xx errors. 5xx errors would be caught by the exit handler, and put to STDERR. 4xx errors are not, they would be emitted by the RPC handler. We would only log them out to STDERR if the RPC handler handled the error, and also that this is a problem for the agent itself.

Node v16 should be reporting the error chain nicely now.

@emmacasolin FYI this issue addresses the idea of how the exceptions (including the error chaining) will eventually be displayed on the CLI or STDERR logging.

Note that the cause property is actually an ES2022 feature, but nodev16 does support it, but because we haven't fully updated our standards to it, we will forget that it actually exists on the standard errors.

Any kind of structured logging will be intended for machine consumption and filtering. That's because any logging of server errors may contain a long stack string, and that information is likely to be quite noisy on basic log readers.

@emmacasolin this would still be needed to ensure that --format json affects STDERR logging.

Some thoughts...
We've been hitting various performance and other network buggy issues which are hard to debug because of concurrency and that asynchronous work are happening out of order.
I think we need to improve our structured logging to provide a better observability into the runtime of our program.
To do this, I'm thinking that we need to incorporate some new ideas:

use perf_hooks to get proper timing data: https://blog.logrocket.com/experimental-node-js-testing-the-new-performance-hooks-31fcdd2a747e/
use async_hooks to hook into Node's asynchronous contexts to understand when something asynchronous is running, and the architecture of them together
We should include some new formatting symbols like trace from #4 and also time stamp symbols too
We need a log viewer/trace viewer that we can use locally (possibly in the browser, possibly in the terminal) that can understand the structured logs and give us context:

https://www.oreilly.com/library/view/distributed-systems-observability/9781492033431/ch04.html
https://copyconstruct.medium.com/distributed-tracing-weve-been-doing-it-wrong-39fc92a857df
https://incident.io/blog/tracing

Get some ideas of prior art with respect to opentelemetry and related structured logging systems:

https://github.com/tokio-rs/tracing
https://github.com/tersesystems/blindsight

JSON vs Structure logging:

https://github.com/hynek/structlog (I believe human readable is structured logging)
https://github.com/sirupsen/logrus

Right now we have a different way of reporting exceptions/errors vs our logging, that is when exceptions are reported we are printing them a certain way in our CLI. But we should also be able to make use of loggers to log out the same exceptions. Perhaps we should be unifying something between js-logger and js-errors
Log viewers - it seems all terminal log viewers only view linear logs https://github.com/tstack/lnav, but you do have browser based viewers that can provide more useful trace understanding: https://github.com/openzipkin/zipkin and https://github.com/jaegertracing/jaeger. However, there are terminal and related tools that visualise via a flamegraph, which usually uses the profiler, instead of distributed trace formats. However this is basically the samething, but nobody has built it.

https://www.jwhitham.org/2016/02/profiling-versus-tracing.html
https://www.npmjs.com/package/0x
https://datalust.co/seq
https://www.datadoghq.com/knowledge-center/distributed-tracing/flame-graph/
https://github.com/Celtoys/Remotery
https://www.speedscope.app/
https://nodesource.com/products/nsolid
https://github.com/pamburus/hl
https://signoz.io/blog/distributed-tracing-nodejs/

Point is flamegraph was only invented by Brendan Gregg back in 2013/2014. But the same idea can be applied to view an entire trace of the entire distributed system. But also works for a local system too. But the tooling isn't really solid though and seems heavyweight for local debugging. So something inbetween might be useful.

Some clarification on terminology.
There's a "standard" for structured logging as exemplified by https://www.structlog.org/.
In that structure, it is not using JSON, but using a human readable structure.
This issue is more about JSON as a structured logging format.
I believe the human readable structure as demonstrated by structlog is a good idea, and we can move our logging format to fit that format eventually. But JSON logging is simply more powerful for any machine analysis of logs.
However atm, I'm not sure what the deal is with information like trace #4, and how structlog would handle information like that. It's not human readable to have information like that on one single line (which is the default for most loggers), it's simply too much information. And if we want to preserve human readability, newlines/tabs/columns on the terminal must be used. The question is, is it really possible to enable easy machine parseability while still using whitespace as a formatting operator for human readability on the terminal? Maybe the goals are in conflict.
Some more info here: https://github.com/hynek/structlog/pull/407
I think we should go as far as we can to maintain structured logging for both human readability AND machine parseability.
In #4 I suggested that if we ever do need to use literal newlines or whitespace operator for formatting, it must always be done with some indentation. That way, one can say that any newline that has   ahead of it, is still a continuation of the same log message.
But it's a bit more complicated than that. Because you need a "lookbehind" to say that whatever is before the   must not also be a \n.
So this should be fine as that terminates the message:
ABC \n

But this should not be considered an end to the message
ABC \n
  ABC\n

But this would get confused with:
ABC \n
  ABC \n

Where it is 2 messages.
So if there are spaces after \n, then that must be joined up with the first message.
Then machines should be able to parse individual messages.

However do note that such usage of newlines are unlikely to be parseable easily, since it depends on logging analysers that know that this can occur. I reckon that it should be possible to code a custom parser for lnav that understands such a formatter though.
However it looks like it still isn't entirely a solved problem: https://github.com/tstack/lnav/issues/410 (multi-line matching).
This further shows that any usage of multiple lines for a log can only really be usable on the terminal and custom log parsers.
But at that point the JSON structure should be used instead.

@tegefaulkes @emmacasolin follow this for more structured logging research.

Also I noticed that structlog talks about "context", that almost sounds like opentelemetry's idea of spans.
My opinion is that "context" can be done by hooking into async_hooks, however that won't work for distributed spans, which goes across process contexts, so at some point it has to be done through decorators.
It does seem that decorators would be the most expressive way of doing this, as this is basically a sort of AOP (aspect oriented programming) cross-cutting concern. We would want to avoid having to add lots of line-noise, but still be able to drop down to imperative logging for flexible control in edge cases where a decorator just doesn't work.

Because PK is a decentralised system, we do have calls that propagate from 1 agent to another agent. Debugging this is crucial, but not necessarily possible in production unless we control all the parties to the interaction. Right now there's a bug in the NAT testing PR where signalling involves agent 1 asking the seed node to ask agent 2 to reverse hole punch. If there's a delay anywhere here, we end up with timeout errors.

Structured graph visualisation with contexts/spans/traces. I think we take a page from the git graph, and use things like: https://github.com/nicoespeon/gitgraph.js.
Along with the ink library: https://github.com/vadimdemedes/ink we may even extend the react components to eventually the GUI too show a trace on what is occurring in the system.

To solve this issue, I'm just going to incorporate json as formatting style. In terms of the actual data being logged, it'd be similar to what is already available under our formatting. I might incorporate similar keywords to what is already available to align. But the contexts and spans would have to be done in a separate issue.
A JSON format would be one step towards producing traces JSON data that can then be analysed and visualised. There is a relationship between this and "state" simulacra, but somewhat independent. State simulacra is generally specific to the state being modelled, while tracing is very generic and applies to any contextful based systems.

@emmacasolin please change up PK to start using the formatting.jsonFormatter when --format=json is set on the CLI as per https://github.com/MatrixAI/js-logger/issues/3#issuecomment-994229643.


Avoid exposing client keystore and truststore passwords in the JDBC URL

Hello,
At present, we have in beeline-site.xml:
beeline.hs2.jdbc.url.zk_cluster: jdbc:hive2://{{ hive_site["hive.zookeeper.quorum"] }}/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2;principal={{ hiveserver2_site["hive.server2.authentication.kerberos.principal"] }};sslTrustStore={{ hive_truststore_location }};trustStorePassword={{ hive_truststore_password }}
and as you can see, we have hive_truststore_password in the JDBC URL. Exposing this password in URL can be a security concern. We can hide this password from JDBC URL when we protect these password in a local JCEKS keystore file and pass the JCEKS file path to URL instead.

As below, i tested this JDBC URL and it works:
beeline -u 'jdbc:hive2://{{ hive_site["hive.zookeeper.quorum"] }}/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2;principal={{ hiveserver2_site["hive.server2.authentication.kerberos.principal"] }};ssl=true;sslKeyStore=/etc/ssl/certs/keystore.jks;storePasswordPath=localjceks://file/etc/hive/conf/hive.jceks'
What do you think ?
Thanks,

The truststore only contain public certificates and to modify it you must have the write permission on the truststore file so it is not a security issue to expose the password of the truststore (see #98).
You replace the truststore by the keystore in the URL and public certificate should not be inside the keystore so I don't understand why your proposition works.

Thanks, i found this Jira Hive also https://issues.apache.org/jira/browse/HIVE-27308

Yes I agree to use jceks instead of writing the password in the URL but I don't understand why this is working with a keystore instead of a truststore and to read the key inside the jceks we do not need a password too ?

Hi @hamdiazz,
This patch is not included in TDP versions of hive, so what do you mean by "deployed it on two dev environment".
Have you deployed apache version of hive or patched TDP ?
If not, the parameter would probably be ignored by beeline. You might check if beeline is working without property. (You may have certificate in JRE default trustore).
In that case, this PR will fail on other setups than yours.

Hi @Pierrotws,
I was inspired by the APACHE HIVE PR, but it was deployed on patched TDP.

Beeline is working without property.

The problem being to remain compatible with the existing one, we cannot modify the Ansible code based on the principle that the user has a patch version of Hive.
If there is a release of Hive with this modification, we can make a condition on the deployed version but this is not the case for the moment.

To be discussed for Hive 4. Closing for now.


Add Travis for Linux

Linux should be added as an additional environment for Travis CI.
Last time the test suite was run via Docker it passed with a couple false-negatives seemingly due to JSONEncoder implementation differences between between Mac and Linux. These tests should be fixed or workarounds should be found before adding integration.

May be an issue on Linux with 2.0

May be an issue on Linux with 2.0


centered footer

It looks pretty good :) will merge in for now. We should try to fix the way it looks when its shrunk to a mobile size :


Integrate elm-review

#862

@anvmn We should integrate it into CircleCI, right?

@AronNovak

@anvmn We should integrate it into CircleCI, right?

Well, we may at some point, but we better start on some other project, as here we get very large code base.
Also, with current setting, I get errors that I wouldn't consider as such. For example:

The problem here is that this logic is part of Simplify rule, which suggests many good changes, but as far as I've seen, it's not possible to select what we want to aplly, and what not.
We can probably copy it to be a custom rule, and make the changes we want, but at current moment, I don't think it justifies the effort.
Another issue we got is that it also removes all unused code, which is not always correct, as we may want to save it for future use.


Change close button UI in connect your wallet

Description
New playground,
The close button in the Connect wallet really does look like it is disabled in dark mode.

Fixed at development_tooltip__color https://github.com/threefoldtech/tfgrid-sdk-ts/pull/1626

2d54818

it seems my code overwritten :)
https://github.com/threefoldtech/tfgrid-sdk-ts/commit/6819bfbc2c9e70e12eb4030fde22f28693fa7bf1
created new PR
https://github.com/threefoldtech/tfgrid-sdk-ts/pull/1634

Verified,
Devnet 911c562.
Close button UI improved.

Verified:

Devnet
13a87cf


fix!: revamp gateway implementation

What does this PR do?
This PR revamps the implementation of gateway object to make it more flexible.
Motivation
Fixes https://github.com/traefik/traefik-helm-chart/issues/1126.
Fixes https://github.com/traefik/traefik-helm-chart/issues/1132.
More

[x] Yes, I updated the tests accordingly
[x] Yes, I ran make test and all the tests passed

LGTM. Maybe add a comment in the docs that the port must match ports.web and ports.websecure.


DRFDocs not showing delete, post, etc. options but regular docs do?

Heyo! Thanks so much for releasing this, it is beautiful.
I am a little confused on why I'm not seeing POST/DELETE/etc. on the DRF docs version, but I can see it on the regular API docs:

Looks like I can only do GET/OPTIONS?
Here's some code:
from rest_framework import viewsets, mixins

from api import serializers
from competitions.models import Competition

class CompetitionViewSet(mixins.ListModelMixin,
                         mixins.CreateModelMixin,
                         mixins.UpdateModelMixin,
                         mixins.DestroyModelMixin,
                         viewsets.GenericViewSet):
    """Tyler loves pizza!!!"""
    queryset = Competition.objects.all()
    serializer_class = serializers.CompetitionSerializer

from django.conf.urls import url, include
from rest_framework import routers

from . import views

router = routers.DefaultRouter()
router.register(r'competitions', views.CompetitionViewSet)

urlpatterns = [
    url(r'^', include(router.urls)),

    url(r'^api-auth/', include('rest_framework.urls', namespace='rest_framework')),

    url(r'^docs/', include('rest_framework_docs.urls')),
]

It's probably something silly I'm overlooking, thanks!

still an issue on drfdocs: 0.0.11
but corrected in current master files.
but still an issue: @detail_route and @list_route don't show the correct methods

@soraphis thanks! Can you fork + make a PR for this?

there already is a PR open that should fix this: #132
its open since 2016 though.
and it should be noted, that i've made a dirty fix for the most obvious probablems, but there are still problems left regarding this, e.g.:
class MyViewSet(viewsets.ModelViewSet):
    serializer_class = ser.MySerializer

    # ...

    @detail_route(methods=['post'], serializer_class=ser.AnotherSerializer)
    def my_detail_route(self, request, pk=None):
        # ...

my quick-and-dirty fix will not show the serializer fields of AnotherSerializer in the docs (but it will show the post method available)
it currently does not bother me enough to fix this - sorry. but for a PR this should be addressed too!

Using this style, I was able to make it work:
from rest_framework.viewsets import GenericViewSet
from rest_framework.generics import ListAPIView, CreateAPIView, RetrieveAPIView, DestroyAPIView

class DataViewSet(ListAPIView, CreateAPIView, RetrieveAPIView, DestroyAPIView, GenericViewSet):
    pass

I think that this is about the same behavior, just different classes.. that seem to work? This is for a simple dummy app that does nothing, so I'm not sure if this breaks other things.

Guys after a month someone could tell me if this is fixed? I'm struggling to make it works!

No, no updates here. We need a way to help maintainers get updates through... some kind of reward system...

I also have this issue.
The perms are se so that if they are logged in, they should get CRUD access; but I only see GET and OPTIONS


Clean install of edge and edge blog engine fails

When doing a clean install of edge refinery (RVM: ruby 1.9.2, Rails 3.2.1)
rails new wtf -m https://raw.github.com/resolve/refinerycms/master/templates/refinery/edge.rb

rails s shows me the site, everything looks OK.  After adding the edge blog engine, my resulting Gemfile.lock has the following revision numbers:
refinery ff56e243
i18n  79b90b32
settings 9a2d8d32
blog 594dd8c
After rails g refinery:blog, migrating, seeding, and restarting the server, the blog index fails with the following:
NoMethodError in Refinery/blog/posts#index

Showing /home/.../core/app/views/refinery/_content_page.html.erb where line #1 raised:

undefined method `render_content_page' for #<#<Class:0x00...48>

I tried this a few days ago and everything was going well, so I'm thinking this is an issue with the edge version.  I would like to submit a failing test, but while I look into it....
Kyle
p.s. I'm new to Refinery, but I'm really liking what I see - looking forward to a stable 3.1 or 3.2 release!

cc @craigambrose

HI @kpassa615
The issue is because I've recently moved some logic out of that template into a helper method. This is all inside the Pages engine, but it's used by the blog engine. The controller in question in the blog engine needs to reference the helper module (which I'm pretty sure is Refinery::Pages::ContentPageHelper). I'll try and get to that at some point today.
Craig

Every Refinery engine will have to add helper Pages::ContentPagesHelper in controllers so I think this needs to be included globally.

Yeah, I guess so. I'll do that.

Inside pages/lib/refinery/pages/engine.rb in after_inclusion block:
::ApplicationController.send :helper, Refinery::Pages::ContentPagesHelper

WDYT?

Yeah, that's the best I can think of. It still seems a bit wrong that the Blog controller depends on the Page object at all, but that'll have to wait for the next release. I'll have a pull request with that change shortly.

:+1::+1::+1:, though @parndt was talking about preferring to use the class, rather than a helper to call the presenter. I'm not sure how that would work, given it needs access to content_for blocks.

@robyurkowski I'm not entirely sure either. I'm happy to keep improving this code, but it'll have to be tweaked further post release.

@ugisozols That technique doesn't work for Admin controllers. The Pages engine admin controller needs this helper in order to preview. Just checking on the blog engine now.

Fix done. It's in a pull request for refinery at
https://github.com/resolve/refinerycms/pull/1353

@craigambrose, that seems to do the trick.  Started a new app with the blog engine and it works.  Thanks!


Value getting nil

Hi,
I have response with array of dictionary and I have key("featured" type NSNumber) in json object but after getting in model it turn nil.
({
"exclude_from_main_feed" = 0;
featured = 1; // Number
"feed_image_height" = 2080;
"feed_image_width" = 960;
"forum_groups" =             (
);
})

To deserialize a collection (array or dictionary) of objects, you'll need to correctly decorate the class property so that JSONModel knows what to instantiate. In particular, you may have to add an empty protocol to your class header which you can then use for the collection property. Take a look at the Model Collections section in the documentation for more details and some examples.

Thanks


Prepare 1.0 release

Proposed Changes
Just like https://github.com/knative/operator/commit/c4f85b54fa432260d52e6ec7c079788d8ad557ae this

Downloads all eventing-sources releases
Updates the scripts with the pinned versions.

Release Note

NONE

/assign @houshengbo

/lgtm
/approve