dumper.py POST request with non utf8 encoding crashes mitmproxy

Problem Description
I have a client that uses cp1255 encoding. When it poses to download I get:
Addon error: Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/mitmproxy/addons/dumper.py", line 246, in response
    self.echo_flow(f)
  File "/usr/local/lib/python3.8/dist-packages/mitmproxy/addons/dumper.py", line 218, in echo_flow
    self._echo_request_line(f)
  File "/usr/local/lib/python3.8/dist-packages/mitmproxy/addons/dumper.py", line 166, in _echo_request_line
    self.echo(line)
  File "/usr/local/lib/python3.8/dist-packages/mitmproxy/addons/dumper.py", line 70, in echo
    click.secho(text, file=self.outfp, **style)
  File "/usr/local/lib/python3.8/dist-packages/click/termui.py", line 548, in secho
    return echo(message, file=file, nl=nl, err=err, color=color)
  File "/usr/local/lib/python3.8/dist-packages/click/utils.py", line 272, in echo
    file.write(message)
UnicodeEncodeError: 'utf-8' codec can't encode characters in position 138-143: surrogates not allowed

Steps to reproduce the behavior:

I am not sure, but I think posting non-unicode chars from the client seems to be breaking it, Is there a way I can capture from the dumper what its trying to do?

System Information
Mitmproxy: 5.1.1
Python:    3.8.2
OpenSSL:   OpenSSL 1.1.1g  21 Apr 2020
Platform:  Linux-4.14.171-136.231.amzn2.x86_64-x86_64-with-glibc2.29

Yeah, this definitely looks like a bug. Thanks!

@mhils, I also wish to take a look at this one, if you don't mind 🙃

I think this is fixed. If anyone can still trigger this, please comment here with steps how to reproduce. :)

Don't think I have how to test it here.


cache service lister to prevent initiating everywhere

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
98e6ee95b23a10b0c1dbe0dd135d4a66bf7bd0de
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
98e6ee95b23a10b0c1dbe0dd135d4a66bf7bd0de
link
/test lint_istio

unit-tests_istio
98e6ee95b23a10b0c1dbe0dd135d4a66bf7bd0de
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Some Unit Test for Razor Templating are failing, when global .gitgnore config has core.autocrlf = false

that's because of the
.gitignore
[core]
	autocrlf = false

the the \r\n and \n problem while comparing input and output.
Steps to reproduce on a windows machine

checkout (in my case release)
execute build.com

We decided on using either embedded resource of multiline @ strings in our tests to work around. There's quite a few strings that are constructed at test runtime using Environment.NewLine - these need to be changed.

9c63d1d


Julia Loader

🚀 Feature
This is an issue for writing all necessary information for the Julia loader. We can use this to talk about any doubts, design decisions or implementation details.
For building and testing the Julia loader:
cmake -DOPTION_BUILD_LOADERS_JL=ON .. # Run this only once, to enable or disable (with OFF) the loader compilation
make jl_loader_bootstrap # Builds the Julia Loader boostrap, use it whenever you modify the source/loaders/jl_loader/bootstrap/lib/bootstrap.jl
make jl_loader # Builds the Julia Loader, it is linked to jl_loader_bootstrap (you can run this only and it will build the bootstrap.jl too), use it whenever you modify the C/C++ source source/loaders/jl_loader/source/jl_loader_impl.cpp
make julia-new # Builds the new.jl script, run this whenever you modify the script source/scripts/julia/new/source/new.jl
make metacall-julia-test # Build the Julia Loader test, use it whenever you modify the test ( source/tests/metacall_julia_test/source/metacall_julia_test.cpp ), you do not need to rebuild the test if you only modify the jl_loader, it is loaded dynamically
ctest -VV -R metacall-julia-test # Run this for testing the loader

When creating a PR, before committing, use:
make clang-format

You need clang-format 11, if your distro has a smaller version than 11, you can see the install instructions of 11 (for debian / apt) here:
https://github.com/metacall/core/blob/cb35037aaf5578807995e1899374f82c72f39411/tools/metacall-environment.sh#L370
Proof of Concept
The proof of concept done by Nikhil Narang ( @nikhilnarang2001 ) can be found here:
5_6114092993344439109.zip
For compiling it:
gcc -o test -fPIC -I/Applications/Julia-1.6.app/Contents/Resources/julia/include/julia -L/Applications/Julia-1.6.app/Contents/Resources/julia/lib -Wl,-rpath,/Applications/Julia-1.6.app/Contents/Resources/julia/lib julia.c -ljulia

Here's the base implementation for the loader: https://github.com/metacall/core/commit/cd015706c0e4c2d05e648460b7a1b99b796b61b0

Can I work on this issue?

Can I work on this issue?

Absolutely, go ahead.

@giarve Should I work on this Issue if it's still not resolved?
Please assign it to me

@giarve Should I work on this Issue if it's still not resolved? Please assign it to me

Yes you can. Open a pull request as "draft" once you have some code to show that you are working on it.

Thanks a lot @giarve
I'll start working on it

@giarve
Hey man, I think it's been a while since the last request...do you mind if I work on this if it's still open?


Locale can flip what the , and . operators mean

This is the content of a workbook file with both versions of the formula, saved under the German locale:
<sheetData>
  <row>
    <c r="A1" t="str">
      <f>TEXT(0, "#.##0,00")</f>
      <v>0,00</v>
    </c>
  </row>
  <row>
    <c r="A2" t="str">
      <f>TEXT(0, "#,##0.00")</f>
      <v>,000</v>
    </c>
  </row>
</sheetData>

What is needed to support this is an option to parse/treat the separators according to the locale:
numfmt("#.##0,00", { locale: "de", localeParse: true })(0) // 0,00
numfmt("#,##0.00", { locale: "de", localeParse: true })(0) // ,000
numfmt("#.##0,00", { locale: "de", localeParse: false })(0) // ,000
numfmt("#,##0.00", { locale: "de", localeParse: false })(0) // ,000

I've made an attempt at solving this within the parser (as per example above) and I didn't like it. It added execution time for all patterns as well as too much complexity. A better approach may be something like this:
const pattern = numfmt.delocalize("#.##0,00", { locale: "de" }); // "#,##0.00"
const formatter = numfmt(pattern, { locale: "de" });
const output = formatter(0); // 0,00

As visible in #27 the problem also extends beyond the comma and decimal point: Color names are localized as well which either means providing translation tables for all 8 colors (black blue cyan green magenta red white yellow) for all languages, or an option or callback to provide translations/color names, or just being liberal about this and allowing anything inside [] not identified as "something else" (condition, duration, locale...) as color.


[Installation] No update on older projects possible, no bower components when installing via CLI or manually, different node modules

First I try a update from version 6.2.4 to 6.4.1, terminal saying update was sucessfull but cannot see any modifications in the files, version here stills 6.2.4
Then try to install a new instance at first manually and get:
bower                           ENOENT No bower.json present
then with CLI and get:
You're all set!
✓ New project folder created.
✓ Node modules installed.
✓ Bower components installed.
But no bower_components installed!
Also wondering about the difference by the node modules. Exec npm install on a manual install and I get 32 node module folder, but do this on a CLI install will serve 788 (!!!) node module folder.
It seems your framework get more messy with every update!
So how can I get a working Zurb Template?

@zitrusblau As far as I'm aware, all of the dependencies in the CLI projects are now NPM modules. Foundation is still available on the Bower ecosystem, however for a CLI generator, it doesn't make sense to have the dependencies spread across multiple package ecosystems.

@codetheorist Sure this make no sense.
But it would make a big sense to document such essential changes. So that a simple templater like me must not search hour for hour to understand how to get this working.
However, I still don't know how to update existing projects. After bower update in a project folder the bower_components still the same as before update. There is no section in documentation which explain the update procedure, only in the forum are some articles which all mention to use bower update.

Additionally, now I don't know how to select and exclude libraries. Someone know what is the new method? I think that I have to configure /node_modules/foundation-sites/webpack.config.js, but I don'n know how.

The simplest way to update while still using one of the older builds approaches is to skip the webpack build entirely and use the compiled javascript files from /node_modules/foundation-sites/dist/js.
Alternatively, you could update your build system to look similar to the new zurb stack... see

@kball
For me this is really not simple!
I was trying to update the foundation framework within an existing WordPress theme via bower_update which doesn't work. The terminal result you can read in my first post here. I got no foundation-sites folder within the node_modules!

I think I'm a little confused about what's happening here... are you attempting to update the framework, the template, or both?  Unfortunately the templates themselves are not really set up well to be updated after you've set up a project - they're templates, not libraries - so if that's what you're doing that may well be the problem.
If you're updating an older project, it probably would make sense to simply update your bower reference and then point your config.yml to the distfiles... I'm happy to help you work through this, is the project somewhere you can share?

Ha ha, if you're confused, what should I say?! ;)
I want to update the framework of course. I've an existing project of a WordPress Theme, build with Foundation 6.2.4 basic template, which comes with bower_components folder. I want to update to Foundation 6.4.1. So I edited the bower.json within the bower_components and made a bower update with the following result:
`bower cached        https://github.com/FortAwesome/Font-Awesome.git#4.7.0
bower validate      4.7.0 against https://github.com/FortAwesome/Font-Awesome.git#^4.7.0
bower cached        https://github.com/zurb/motion-ui.git#1.1.1
bower validate      1.1.1 against https://github.com/zurb/motion-ui.git#~1.1.0
bower cached        https://github.com/zurb/foundation-sites.git#6.4.1
bower validate      6.4.1 against https://github.com/zurb/foundation-sites.git#~6.4.1
bower cached        https://github.com/jquery/jquery-dist.git#2.1.4
bower validate      2.1.4 against https://github.com/jquery/jquery-dist.git#~2.1.4
bower cached        https://github.com/jquery/jquery-dist.git#3.2.1
bower validate      3.2.1 against https://github.com/jquery/jquery-dist.git#>= 3.0.0
bower cached        https://github.com/ten1seven/what-input.git#4.1.6
bower validate      4.1.6 against https://github.com/ten1seven/what-input.git#~4.1.3
Please note that,
motion-ui#1.1.1 depends on jquery#~2.1.4 which resolved to jquery#2.1.4
foundation-sites#6.4.1 depends on jquery#>= 3.0.0 which resolved to jquery#3.2.1
Resort to using jquery#>= 3.0.0 which resolved to jquery#3.2.1
Code incompatibilities may occur.
bower extra-resolution      Unnecessary resolution: what-input#~4.1.3`
All Foundation files still the same as before and I've no foundation-sites within the node_modules and also I've no config.yml! So how can I update the framework with this project?

@zitrusblau you have no foundation-sites within node_modules because you need to update your package.json file:
https://github.com/zurb/foundation-sites-template/blob/master/package.json
You also need to copy files like config.yml from the template manually and update the gulpfile.js and run npm install.
I'm going to close this out since it's old, but feel free to reopen if you need more help or what I said wasn't clear. If that's the case, please provide a link to your repo so I can give you exact directions. Thanks!


Fix documentation issue in global endpoints

Purpose
Resolves #11134

I am closing this PR until we refactor endpoints for 0.985.0. Let's fix this, once we done with new endpoint changes.


Error loading lua

Hi, I have just typed all of your code into my init.vim file from the FAQ an open nvim in my terminal and it said:

and when I go to my init.vim file and I found the '%' is inside [%YOUR_LSP_SERVER%] in line 105.
do I need to type something? like my LSP_server? if so, where can I find them?
nothing changed on your script.
I have typed:PlugInstall but it is still the same
I have also typed:checkhealth and it said ok for the plug.
p.s. I am using window;

Could you provide the your configuration or reproduction steps? I can't solve this issue for now.

My configuration: set completeopt=menu,menuone,noselect
lua <<EOF
  local cmp = require'cmp'
  -- Global setup.
  cmp.setup({
    snippet = {
      expand = function(args)
        vim.fn["vsnip#anonymous"](args.body) -- For `vsnip` users.
        -- require('luasnip').lsp_expand(args.body) -- For `luasnip` users.
        -- require'snippy'.expand_snippet(args.body) -- For `snippy` users.
        -- vim.fn["UltiSnips#Anon"](args.body) -- For `ultisnips` users.
      end,
    },
    window = {
      -- completion = cmp.config.window.bordered(),
      -- documentation = cmp.config.window.bordered(),
    },
    mapping = cmp.mapping.preset.insert({
      ['<C-d>'] = cmp.mapping.scroll_docs(-4),
      ['<C-f>'] = cmp.mapping.scroll_docs(4),
      ['<C-Space>'] = cmp.mapping.complete(),
      ['<CR>'] = cmp.mapping.confirm({ select = true }),
    }),
    sources = cmp.config.sources({
      { name = 'nvim_lsp' },
      { name = 'vsnip' }, -- For vsnip users.
      -- { name = 'luasnip' }, -- For luasnip users.
      -- { name = 'snippy' }, -- For snippy users.
      -- { name = 'ultisnips' }, -- For ultisnips users.
    }, {
      { name = 'buffer' },
    })
  })
  -- `/` cmdline setup.
  cmp.setup.cmdline('/', {
    mapping = cmp.mapping.preset.cmdline(),
    sources = {
      { name = 'buffer' }
    }
  })
  -- `:` cmdline setup.
  cmp.setup.cmdline(':', {
    mapping = cmp.mapping.preset.cmdline(),
    sources = cmp.config.sources({
      { name = 'path' }
    }, {
      { name = 'cmdline' }
    })
  })
  -- Setup lspconfig.
  local capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities())
  require('lspconfig')[%YOUR_LSP_SERVER%].setup {
    capabilities = capabilities
  }
EOF

my Plug:
Plug 'neovim/nvim-lspconfig'
  Plug 'hrsh7th/cmp-nvim-lsp'
  Plug 'hrsh7th/cmp-buffer'
  Plug 'hrsh7th/cmp-path'
  Plug 'hrsh7th/cmp-cmdline'
  Plug 'hrsh7th/nvim-cmp'

  " For vsnip users.
  Plug 'hrsh7th/cmp-vsnip'
  Plug 'hrsh7th/vim-vsnip'

  " For luasnip users.
  " Plug 'L3MON4D3/LuaSnip'
  " Plug 'saadparwaiz1/cmp_luasnip'
  " For snippy users.
  " Plug 'dcampos/nvim-snippy'
  " Plug 'dcampos/cmp-snippy'
  " For ultisnips users.
  " Plug 'SirVer/ultisnips'
  " Plug 'quangnguyen30192/cmp-nvim-ultisnips'

I am also experiencing this same error using the example config found in the README.md


feat: add ListCard component to design system

Description
This PR adds a new component called ListCard which is a molecule component. It displays a card with information about a list. The card includes the list name, whether it is public or private, the number of contributors, and avatars of the contributors. The component also includes buttons to delete the list and navigate to the list's overview page. The StackedAvatar component is also updated to include a classNames prop for custom styling.
Generated using OpenSauced.

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
closes #1669

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[x] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

The alignment seems a bit off in the screenshot with Contributors and the images

The horizontal alignment seems a bit off in the screenshot with Contributors and the images

Its as a result of the white background on the storybook layout. when used on the insights page, it looks aligned


Add TvOS support for SwiftPM

Thanks @skrew!
Do you want to have push access to the repository? If so, just drop me a line :-)
Before we release v0.5.0, I wish I (or someone else) figure out the fix the flaky test spotted in 3d0d42fafd481f9bd58aeaf5ac641eef46698908. There is a bug in GRDBCombine, it may crash the hosting app, it's concurrency-related, and I haven't understood it yet.


Update specs2-cats, specs2-core to 4.9.3

Updates

org.specs2:specs2-cats
org.specs2:specs2-core

from 4.6.0 to 4.9.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

labels: library-update, semver-minor

Superseded by #115.

Superseded by #115.


Home Assistant 2023.1.2 Xiaomi Gateway 3 Error does not start

Logger: homeassistant.setup
Source: setup.py:210
First occurred: 05:56:45 (1 occurrences)
Last logged: 05:56:45
Setup failed for custom integration xiaomi_gateway3: Unable to import component: cannot import name 'Command' from 'zigpy.zcl.foundation' (/usr/local/lib/python3.10/site-packages/zigpy/zcl/foundation.py)
2023.1.1 is OK

Me too. HOW TO DO?

Back to 2023.1.1 restore backup for now. :(

#911


Please have a look at my px4flow test logs

@jgoppert @mhkabir I am using px4flow to do hovering. I do a lot of tests indoor and outdoor. My problem is sometimes I just cannot enter the position hold mode. I suppose that when I switch to position mode, the local position set point doesn't change means that it is trying to hold the position. Am I right? In my tests, all the setups are same. I can understand that sometimes the flow quality is not good causing the falls, but sometimes everything seems good to me, while the LPSP changes. I cannot find any explanation for that. Is there any requirement for position hold?
Here are some of my test logs:
This is one relatively successful test outdoor:
http://logs.uaventure.com/view/CnsqRVDuGcoNLjHrLNqi5C
These are indoor tests:
http://logs.uaventure.com/view/RCzaUZ4PeMuAqr5zGh3zoY
http://logs.uaventure.com/view/9n6FoBZe5xrkWoT6FMCZLH
http://logs.uaventure.com/view/Qow9Td9UM9Z6NFN9eSLKfH
http://logs.uaventure.com/view/9PUxJ3EvLo9ErE4BWCpqTQ
These are outdoor tests:
http://logs.uaventure.com/view/eNWbJn8ZPFYa5HD99bfLUi
http://logs.uaventure.com/view/o85N9MvvFw5ZE4aWoMzV3a

There were some changes on the Flow code that may improve the quality of the readings and avoid drops on the position lock. Please update your PX4Flow firmware and let us know how it goes.


Service Bus Backplane for high scaleability

Are there any efforts underway or does there already exist an Azure Service Bus backplane such that I can scale out multiple instances of MQTTNet servers?  Something similar to the SignalR backplane here: https://docs.microsoft.com/en-us/aspnet/signalr/overview/performance/scaleout-with-windows-azure-service-bus.

Hi,
sorry but such a solution does not exist.
Best regards
Christian

Thanks.
Any ideas or recommendations on how one might want to scale this thing out?
On Thu, May 10, 2018 at 1:59 PM, Christian<EMAIL_ADDRESS>wrote:

Hi,
sorry but such a solution does not exist.
Best regards
Christian
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chkr1011/MQTTnet/issues/254#issuecomment-388133850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBEEaXTOSDqRkqk36J1zzu8kyRb0wxwks5txH_tgaJpZM4T5S19
.

A key decision is to figure out how you would partition data.
A naive example: if you were building a Slack clone, I would partition based on company ID as user form company A never sends message to a user from Company B in slack. If a user is part of two different companies, they login separately to each company in Slack, and for all intents and purposes those are two entirely independent users and connections.

Choose your partitionKey, say CompanyID, and each topic should include the patititonKey, say:
companyid/6/users/56/etc..
write a function that processes the partitionkey to return a server. For example you have two servers online, odd CompanyID connect to server1, even CompanyID connect to server2.
Put this function into a HTTPserver, and make it return the URI of MQTT server.
Before connecting, each MQTT client asks this server where it should connect
Bam! You are scaling with almost no code written specifically for scaling.

Ofcourse there are cases where this wouldn't work, but that's probably all the advise I can give. 🚚

@djarvis - I'm not sure if you're trying to scale the server or the client in your example, but we ran into this same issue.
We put emqtt.io on the server side, as it supports clustering / node based deployment by default, and wrote some custom code to throw it into an azure cloud service.  We can scale it up or down and it creates nodes and attaches them automatically.
On the client we use Christians mqtt.net library, and use shared subscriptions.  (our client is a web server subscribing to messages coming through the server from sensors...IOT devices).
With the shared subscription model, only 1 web server in the scaled set will handle any given message.  We then added a second level of scale-out....we turn around and when the mqtt.net client in the web server process receives a message, it turns around and calls itself at a URL that matches the topic, and the payload becomes the body.
Because it will call back out of the load balancer, any one of the web servers can handle an incoming request.
topic:  /mysensor/serialnumber
url : /api/mysensor/{serial number}
public async Task HandleSensorPost(string serial number, [frombody] dynamic body){}
This ends up working fantastically.  We run the MQTT.NET client as a microservice inside an ASP.NET Core 2.1 container, as an IHostedService
Hope that helps


cargo: bump time crate

Workaround for https://github.com/rust-lang/rust/issues/127343
Fixes https://github.com/josh-project/josh/issues/1353

@christian-schilling this now mentions it's outdated. Anything I should be doing here?

@christian-schilling this now mentions it's outdated. Anything I should be doing here?

I rebased it once more...that should do it.


AttributeError

When i train my model model (with ludwig train -mdf model_definition.yaml --data_csv ./rsna-bone-age/boneage-test-dataset.csv ) ludwig loads my model definition but after finishing it i get "AttributeError: 'NoneType' object has no attribute 'items' ".
Model Definition data and terminal log are attached.
-Ludwig 0.21
-MacOS 10.14.5
-also tried on google colab
Archiv.zip
Terminal.txt

modify your model definition like below:
input_features:
    -
        name: id
        type: image
        preprocessing:
                height: 500
                width: 500
                resize_method: interpolate
                scaling: pixel_normalization
                encoder: stacked_cnn

output_features:
    -
        name: sex
        type: category

training:

    epochs: 10
    early_stop: 5

This should fix the error. In your original model definition, the preprocessing section would be None because it doesn't follow the nested structure required for yaml files.
Let us know if that solved the issue.

Thank you very much it worked.


Upgrade to use Go v1.20.6, NodeJS v18.17.0 and golangci-lint v1.53.3

Upgrade package and fix lint related changes to use newer Go version

@johnnyaug I've replace the tools.go deps in golangci-lint and run it explicit from the make file.
It removed all the deps from our current go.mod.
Also added an option in the makefile to download golangci-lint locally.


[enhancement]: Allow importing SD 2.x models in RAM (or pre-specify the configuration in models.yaml)

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Simple problem:
I have a SD 2.1-based Safetensors model.
I would like to load it on the fly, the same way I can currently load and convert SD 1.x-based Safetensors/Ckpt models on the fly.
However, the import prompt only allows me to save the converted model to disk and then load it from there.
Is it possible to instead specify the model type (I'm referring to this) in advance, and loading the model in RAM?
Alternatives
No response
Aditional Content
No response

Also, FP16 import should really be an option, 4.8 GB is heavy for a single model.


KBC-2777 gcs purge test

Jira: KBC-XXX
Connection PR: https://github.com/keboola/connection/pull/3858
Before asking for review make sure that:

[x] New client method(s) has tests
[x] Apiary file is updated
[x] You declared if there is a BC break or not (will affect next release of a client)

Jo som to trosku rebasnul :)


Fix #336 - Upgrade Knative Serving to 0.39.0

Description of the change:
Closes #336. This is an important upgrade to fix a few bugs and minor CVEs.
Motivation for the change:
See #336 notes.
Checklist

[ ] Add or Modify a unit test for your change
[ ] Have you verified that tall the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Apologies for late review, looks good merging.


Fix cabal warnings about missing files

The README.md and ChangeLog.md files were not moved along in #127, breaking
the build for repos that list cardano-prelude as a
source-repository-package:
cabal: filepath wildcard 'ChangeLog.md' does not match any files.

Fix this by moving them to the cardano-prelude folder.

bors r+


YALL_CALL_LOG does not add newline after the content

It was a buffer overrun problem (#57) which have been fixed.


Change in value of docker inspect's HostOptions.AuthOptions.StorePath

I am seeing a change in what an inspect call returns for the store path:
docker-machine inspect -f '{{.HostOptions.AuthOptions.StorePath}}' default
In docker-machine version 0.5.4, build 6643d0e, arch=darwin I get
/Users/devoid/.docker/machine/machines/default

In docker-machine version 0.6.0, build e27fb87, arch=darwin I get
/Users/devoid/.docker/machine

Could this be related to #2062 ?
I am specifically looking at StorePath since in 0.5.4 it appeared to be what I needed to use to replicate the docker env default value for DOCKER_CERT_PATH. Should I be using a different value to get this?

Any help here? I would just like to know what the right value is to set DOCKER_CERT_PATH. Right now I am setting it with the following:
// var i inspect struct { ... formatted to extract values from json }
if i.HostOptions.AuthOptions.ServerKeyPath != "" {
	certPath, _ := path.Split(i.HostOptions.AuthOptions.ServerKeyPath)
	err = os.Setenv("DOCKER_CERT_PATH", certPath)
}

Thank you!


node 16

support node 16

Has Discord said anything about this?

#40 may fix this

This is merged in


Bypass workflow checks for non-code related files

Can we bypass workflow checks for non-code related files (not code, not configuration/data)?  e.g.  txt, md, rtf, pdf, etc...
e.g.  Fix for typo in a README is prevented from being merged because of other build issues.
https://github.com/LibertyDSNP/frequency/pull/710

I believe dorny/paths-filter@v2 has an option to exclude files using filters-exclude

Sorry, this was actually in the Rust doc and not in the README.


run in linux x86_64 server

if if i wan't to run cvte model on linux server,  will it work?
mace support run on linux x86_64 server?

@Jellyrick MACE can run on x86_64 without any optimization. So it can only used for validation.
However, CUDA support is in the near roadmap and x86_64 optimization may also be added in the future.
By the way, what's your use case, ASR cloud service?

@Jellyrick MACE can run on x86_64 without any optimization. So it can only used for validation.
However, CUDA support is in the near roadmap and x86_64 optimization may also be added in the future.
By the way, what's your use case, ASR cloud service?

@llhe yes, i wan't use ASR cloud service
when i build shared lib for aarch64_linux_gnu + cpu_gpu use build-standalone-lib.sh
got error:
"""
external/half/include/half.hpp:275:8: error: missing space between ‘""’ and suffix identifier
half operator""_h(long double);
"""
any suggestions?

@Jellyrick If you are also interested in mobile device deployment, you can have a try. Now x86 server or desktop is not well supported and will be VERY SLOW, it's not suggested to use it.
To build with x86, you can use cmake:
sh tools/cmake-build-host.sh

or bazel:
bazel build mace/libmace:libmace_static --config linux --config optimization

on you host (suppose your host and default c++ compiler is x86)

@Jellyrick If you are also interested in mobile device deployment, you can have a try. Now x86 server or desktop is not well supported and will be VERY SLOW, it's not suggested to use it.
To build with x86, you can use cmake:
sh tools/cmake-build-host.sh

or bazel:
bazel build mace/libmace:libmace_static --config linux --config optimization

on you host (suppose your host and default c++ compiler is x86)

@llhe thxs, i don't have an arm device; i will try this on x86 server

(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 341: invalid start byte


feat: loosening up the npm engine requirements to easily allow npm@8

🧰 What's being changed?
Installing this library with npm@8 generates a warning that it actually wants npm@7. Since either work, and the npm requirement is only really there for local development I'm removing it.
And in order to make sure that the library still works okay without this on Node 12 and Node 14 I'm updating our CI workflow to install npm@8 on these versions. This is unnecessary on Node 16 because Node 16 ships with npm@8 already.
🧬 Testing

[ ] Tests pass?

Is there possibly an issue with people simultaneously using 7 & 8 or are they cross compatible enough?

@ilias-t npm@7 and npm@8 are cross-compatible, it's just when you throw npm@6 do you get warnings from the new lock file format that they introduced in npm@7.

@ilias-t npm@7 and npm@8 are cross-compatible, it's just when you throw npm@6 do you get warnings from the new lock file format that they introduced in npm@7.

Maybe we should specify npm7 and above then?

it still installs fine on npm6, you just need to manually install peerDeps.


getting more info around a ci build failure

Unfortunately can't reproduce this locally or in codespaces, so putting up a PR to gather more data.

Yeah, I was thinking that we could also print what DEBUG_HELPERS=true prints by default when failures happen.

To reproduce locally, run the tests like this:
SUITE_NAME=bundler1 rspec ./spec/dependabot/bundler/file_updater_spec.rb:796

We should document this much better, but our suites run against both versions of bundler by having fixtures that require either bundler 1 or bundler 2, and that SUITE_NAME variable determines which fixtures are pulled in

I think I figured it out, this patch should do the trick I believe!
diff --git a/bundler/helpers/v1/lib/functions.rb b/bundler/helpers/v1/lib/functions.rb
index fb69fdb37..dd24d1d4b 100644
--- a/bundler/helpers/v1/lib/functions.rb
+++ b/bundler/helpers/v1/lib/functions.rb
@@ -144,6 +144,9 @@ module Functions
         token.gsub("@", "%40F").gsub("?", "%3F")
       )
     end
+
+    # Use HTTPS for GitHub if lockfile
+    Bundler.settings.set_command_option("github.https", "true")
   end

   def self.relevant_credentials(credentials)

If it looks ok, feel free to add it here, or I can open a separate PR.

The failures seem to happen because the bundler1 fixtures for those tests reference git dependencies over the git:// protocol which GitHub no longer supports. The bundler2 fixtures reference them using https, which is preferred.

Hmm @deivid-rodriguez that doesn't work for me testing locally. Feel free to put up a PR, perhaps I am missing something. Thanks!

I swear it passed @jurre's reproducer command line when I first tried it, but I just retried and I'm now getting a different error 😲. I'll double check tomorrow in more detail.

closing in lieu of #4869


tag / release mismatch

There appears to be a mismatch between the tagged version of this repo on Github and the corresponding release on pypi.
When installing into a clean python3 docker image I get the following.
root@92cd0a798183:/# pip3 install botocore
Collecting botocore
  Downloading https://files.pythonhosted.org/packages/be/72/d4a9a185f634798641ed73c921643a1428a2c7526d96e2e8dd93a6c7add2/botocore-1.12.154-py2.py3-none-any.whl (5.4MB)
    100% |████████████████████████████████| 5.4MB 379kB/s
Collecting python-dateutil<3.0.0,>=2.1; python_version >= "2.7" (from botocore)
  Downloading https://files.pythonhosted.org/packages/41/17/c62faccbfbd163c7f57f3844689e3a78bae1f403648a6afb1d0866d87fbb/python_dateutil-2.8.0-py2.py3-none-any.whl (226kB)
    100% |████████████████████████████████| 235kB 5.2MB/s
Collecting docutils>=0.10 (from botocore)
  Downloading https://files.pythonhosted.org/packages/36/fa/08e9e6e0e3cbd1d362c3bbee8d01d0aedb2155c4ac112b19ef3cae8eed8d/docutils-0.14-py3-none-any.whl (543kB)
    100% |████████████████████████████████| 552kB 3.2MB/s
Collecting urllib3<1.25,>=1.20; python_version >= "3.4" (from botocore)
  Downloading https://files.pythonhosted.org/packages/01/11/525b02e4acc0c747de8b6ccdab376331597c569c42ea66ab0a1dbd36eca2/urllib3-1.24.3-py2.py3-none-any.whl (118kB)
    100% |████████████████████████████████| 122kB 8.1MB/s
Collecting jmespath<1.0.0,>=0.7.1 (from botocore)
  Downloading https://files.pythonhosted.org/packages/83/94/7179c3832a6d45b266ddb2aac329e101367fbdb11f425f13771d27f225bb/jmespath-0.9.4-py2.py3-none-any.whl
Collecting six>=1.5 (from python-dateutil<3.0.0,>=2.1; python_version >= "2.7"->botocore)
  Downloading https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Installing collected packages: six, python-dateutil, docutils, urllib3, jmespath, botocore
Successfully installed botocore-1.12.154 docutils-0.14 jmespath-0.9.4 python-dateutil-2.8.0 six-1.12.0 urllib3-1.24.3
You are using pip version 9.0.1, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Note this installs urllib3<1.25 based on the line
Collecting urllib3<1.25,>=1.20; python_version >= "3.4" (from botocore)

However looking at setup.py for the 1.12.154 tag of this repo
it appears that urllib3==1.25 should now be allowed.

Can confirm, I get the following when installing certbot and certbot-dns-route53
ERROR: botocore 1.12.154 has requirement urllib3<1.25,>=1.20; python_version >= "3.4", but you'll have urllib3 1.25.2 which is incompatible.

https://github.com/boto/botocore/pull/1737 may fix this.

Yes, I confirm: #1737 should very likely fix this issue (it's not an issue of tag/release, but the patch being incomplete).

Closing issue, #1737 has been merged.


Removed _book folder

Netlify is using the _book folder. Will require an action?

you will need to delete the netlify deployment script and switch to using the quarto publish action.
ideally you want the build artifacts (e.g. _book) to run in CI/CD rather than remembering to be commited. The alternative would be to utilise a git pre-commit hook to either do the building then, or to require you to have built the _book folder first (ala readme-rmd-pre-commit.sh)

Workaround is currently to publish quarto publish netlify from the terminal and we are working on a way to get access to the NHSR Community url to move away from Netlify publishing.


Livewire: data-turbolinks-permanent, no-cache and livewire do not work together

I want to use livewire with turbolinks. I want to use the data-turbolinks-permanent attribute, so I can persist elements and the no-cache attribute in the meta tag to disable caching, but doing this results in an error:
index.js:23 Uncaught TypeError: Cannot read property 'data' of null
    at new Component (index.js:23)
    at index.js:77
    at Array.forEach (<anonymous>)
    at Livewire.value (index.js:76)
    at Livewire.value (index.js:68)
    at HTMLDocument.<anonymous> (crash:223)
    at Object.e.dispatch (turbolinks.js?33cb:5)
    at r.notifyApplicationAfterPageLoad (turbolinks.js?33cb:6)
    at r.visitCompleted (turbolinks.js?33cb:6)
    at r.complete (turbolinks.js?33cb:5)

I'm not sure whether this is laravels issue or turbolinks, so I posted this issue on both repos.
index.blade.php
<head>
    <meta name="turbolinks-cache-control" content="no-cache">

    <!-- Scripts -->
    <script src="{{ mix('js/app.js') }}" defer data-turbolinks-track="reload"></script>
    <script src="{{ asset('js/jquery.js') }}"></script>

    <!-- Styles -->
    <link href="{{ mix('/css/app.css') }}" rel="stylesheet" type="text/css" data-turbolinks-track="reload">
    <livewire:styles/>
    @stack('styles')
</head>
<body>
    @livewire('somecomponent')
    <livewire:scripts/>
    @stack('scripts')
</body>

somecomponent.blade.php
<div class="somecomponent" id="somecomponent" data-turbolinks-permanent>
    // Content of somecomponent
</div>

@push('scripts')
    <script data-turbolinks-eval="false">
        // Change content of somecomponent
    </script>
@endpush

app.js
import Turbolinks from 'turbolinks'
document.addEventListener("livewire:load", function(event) {
    Turbolinks.start()
})

Hey @SamQualt63 I don't think this is an issue with Turbolinks. If you discover that data-turbolinks-permanent and no-cache don't work together, then please post a minimal demo here. Thanks!


[release-v1.1] Patch knative-eventing with tracing config when installing tracing

The goal is to move patching the knativeeventing resource from
run_e2e_tests to install_tracing and better separate installation from
running E2E tests.
The run_e2e_tests function is reused in serverless-operator repo and
there we might install tracing earlier. Patching the knativeeventing
resource at that point brakes the installation.
The run_e2e_tests function should really just run tests and not change
product installation.
This is required for https://github.com/openshift-knative/serverless-operator/pull/1453

/cherrypick release-v1.2

/cherrypick release-v1.3

/hold

Holding this as https://github.com/openshift-knative/serverless-operator/pull/1458 should be merged first.

/test ci/prow/48-e2e-aws-ocp-48

/test 48-e2e-aws-ocp-48

/test 48-e2e-aws-ocp-48

/hold cancel
The related PR was merged.


Allow file to be regex + output browser_download_url + bug fix

See #6
Additionally, it fix a bug where if the created_at value of two releases are the same (happens if the build is done on another repository), the alphabetical order was used instead of the published_at value, resulting in choosing the wrong latest release. It now uses correctly the published_at value.

@madrobot You're absolutely right for the commit name, I'm sorry.
In the last two commit I allowed prefix to be explicitly set to empty string (useful for targeting all tags), and fixed the CI

@madrobot Ok I'm done modifying stuff. By the way, I see that it generated a lot of change in the dist directory, do you want me to delete change made in dist so you can regenerate it yourself?

@madrobot Which notes? I cannot see them :'(

Ok, dependencies are now up to date :tada:

By the way I still can't see your notes, but I tried to guess the required change in my last commit :')

@madrobot Whaaaat? Most changes are just dependencies update, I really don't understand your reaction.

@madrobot ?


const [a, b] = xs = [1, 2] produces wrong error: TS2304: Cannot find name 'xs'

TypeScript Version:  2.1.5
Code
const [a, b] = xs = [1, 2];

Expected behavior:
No compile errors.
Actual behavior:
Compiler reports bug.ts(1,16): error TS2304: Cannot find name 'xs', but emits correct javascript.

Because it is an error. A statement with consecutive assignment like var a = b = 123 will make a global variable b in sloppy mode, and an error in strict mode. Note the first var a is declaration, the second b =  is just an assignment.
Try this in node.
'use strict'
var a = b = 123

So you should declare xs first. let xs = []; const [a, b] = xs = [1, 2]; should work.


Space parity on Mac

Summary of Problem
On Windows everything works good, but when I want to connect the device and run the app on a Mac I cant connect to the device Binding #open had an error [Error: Invalid parity setting 5].
I read somewhere that parity "space" is not supported on Linux-based systems. I can connect to it using parity "none", "even" and "odd", but I dont receive any messages with those settings. Can I convert the messages somehow from space to none/even/odd parity?
Code to Reproduce the Issue
const serialport = new SerialPort(path)
const port = new serialport('/dev/tty.SLAB_USBtoUART', {
    baudRate: 921600,
    dataBits: 8,
    stopBits: 1,
    parity: 'space',
    lock: true,
    autoOpen: true,
    xon: false,
    xoff: false
});
// Code

Versions, Operating System and Hardware

SerialPort@ ^7.1.5
Node.js v10.16.0
Mac
SLAB_USBtoUART

I don't know converting is possible. I'm looking for a way to connect to the device on a Mac, like I can on Windows.

I can connect it with parity "even", but if I do that the messages arent correct.


Experiment with a web evolution timeline

Add a page which displays a graph showing the years on the x-axis, and the number/names of features on the y-axis.
Might be an interesting visualization of the evolution of the web platform over the years that web-features focuses on.

Adding the ability to filter by browser would be interesting too.

https://web-platform-dx.github.io/web-features-explorer/timeline/


Fix: Implement cancelOnDisconnect

Status
READY
Description
Implements cancelOnDisconnect to fix #15. One side effect of this change is that a StateError will be thrown if the device is not connected and characteristic.device is accessed. In FlutterBluePlus, a new BluetoothDevice is created from this getter, since it only needs the remoteId to be constructed, whereas in FlutterBluePlusWindows, BluetoothDeviceWindows requires platformName which is not available from the characteristic. Let me know if you believe this should be refactored to prevent this.
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

LGTM


Tốt

good
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33613b2d-d607-ec47-1254-ae540d07ad59
Version Independent ID: aba728f0-0d3c-73fd-c7fe-68e69b6a753f
Content: Security guide for Microsoft Teams overview - Microsoft Teams
Content Source: Teams/teams-security-guide.md
Service: msteams
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

Vui

OK

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Moving elements to another list too fast produces Cannot read property of 'option' error

Sortable.js:188 Uncaught TypeError: Cannot read property 'options' of null(anonymous function) @ Sortable.js:188_onDragOver @ Sortable.js:664handleEvent @ Sortable.js:934
Moving elements from one list to another too quickly results in some of them producing the error message above.
How to reproduce: On the Sortable Demo page, create 15-20 new elements in the 'AngularJS / ng-sortable' section. Now drag each of them as quickly as you can from the left list to the right list. Check console.
(Note: For illustration of the bug I was using the angular portion of the Demo page because its the only one where you can add more elements and also be able to move those elements to another list, but the issue is the same without angular).

Try master.


Federation: "InvalidChangeBatch: Duplicate Resource Record" error while configuring Route53

 Issue by crigor
Monday Feb 27, 2017 at 01:13 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/42131

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.):
No.
What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.):
InvalidChangeBatch

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug report.

Kubernetes version (use kubectl version):
1.5.1
Environment:

Cloud provider or hardware configuration: AWS
OS (e.g. from /etc/os-release): Ubuntu 16.04.1 LTS
Kernel (e.g. uname -a): Linux ip-172-20-4-64 4.4.0-59-generic #80-Ubuntu SMP Fri Jan 6 17:47:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Install tools: Custom
Others:

What happened:
I have 2 clusters in aws, 1 in us-east-1 and 1 in us-east-2. I set up cluster federation using https://github.com/kelseyhightower/kubernetes-cluster-federation as my guide.
I created a replica set with 4 replicas of nginx. 2 ran on each of the 2 regions. All good.
I created a service, the federation controller manager created CNAMES for nginx4.default.federation.svc.us-east-1.federation.com and nginx4.default.federation.svc.us-east-2.federation.com. This looks correct.
Eventually nginx4.default.federation.svc.us-east-1.federation.com was changed to an A record when the endpoints became healthy while nginx4.default.federation.svc.us-east-2.federation.com remained a CNAME.
This is the error from federation-controller-manager 1.5.3 (I also tried 1.5.1).
I0226 07:47:30.273951       1 dns.go:237] Recordset &{0xc421552a80 0xc4202da4d8} already exists.  Ensuring that it is correct.
I0226 07:47:30.273981       1 dns.go:268] nginx4.default.federation.svc.us-east-2a.us-east-2.federation.com.: Healthy endpoints [ae0cf9867fbf611e6954b023f939bc0f-805436699.us-east-2.elb.amazonaws.com ae0cf9867fbf611e6954b023f939bc0f-805436699.us-east-2.elb.amazonaws.com] exist.  Recordset &{0xc421552a80 0xc4202da4d8} exists.  Reconciling.
I0226 07:47:30.301127       1 dns.go:274] Have recordset &{0xc421552a80 0xc4202da4d8}. Need recordset {0xc421553500 0xc420ef8340}
I0226 07:47:30.301156       1 dns.go:282] Existing recordset &{0xc421552a80 0xc4202da4d8} is not equivalent to needed recordset {0xc421553500 0xc420ef8340}, removing existing and adding needed.
I0226 07:47:30.362002       1 service_helper.go:120] Error ensuring DNS Records for service default/nginx4 on cluster additionalzonesftw: InvalidChangeBatch: Duplicate Resource Record: <IP_ADDRESS>
status code: 400, request id: d35e1156-fbf7-11e6-b1d9-afb55cf95a01
Notice the 2 healthy endpoints are for the same ELB ae0cf9867fbf611e6954b023f939bc0f-805436699... Could this be the cause of InvalidChangeBatch: Duplicate Resource Record?
What you expected to happen:
I expected nginx4.default.federation.svc.us-east-2.federation.com to be an A record instead of CNAME.
How to reproduce it (as minimally and precisely as possible):
Set up cluster federation on AWS. Create a replica set. Create a service.
Anything else we need to know:

 Comment by shashidharatd
Monday Feb 27, 2017 at 07:02 GMT

related issues  #35637  #36757

 Comment by matt-potter
Wednesday May 03, 2017 at 16:32 GMT

Hi! We see the exact same issue on 1.6.2. Using kubefed to create a federation control plane, and then joining the the host cluster to the federation. Deploy a RS and a Loadbalancer service, and this leads to both the service in the federation cluster context and the service in the host cluster context referencing the same ELB address (is this correct behaviour?). I can see the controller manager detecting the same endpoint multiple times and trying to add entries to a route53 record, which fails as it contains duplicate values:
I've replaced some of the values in the log, but the LOADBALANCER-***... entries are all the same ELB.
I0503 15:22:50.057373       1 dns.go:225] Recordset &{0xc4215600e0 0xc42048f3d8} already exists.  Ensuring that it is correct.
I0503 15:22:50.057403       1 dns.go:256] nginx-fed.default.federated.svc.eu-west-1a.eu-west-1.*******.: Healthy endpoints [LOADBALANCER-***.eu-west-1.elb.amazonaws.com LOADBALANCER-***.eu-west-1.elb.amazonaws.com LOADBALANCER-***.eu-west-1.elb.amazonaws.com] exist.  Recordset &{0xc4215600e0 0xc42048f3d8} exists.  Reconciling.

I0503 15:22:50.135302       1 dns.go:262] Have recordset &{0xc4215600e0 0xc42048f3d8}. Need recordset {0xc4214b6af0 0xc42048f488}

I0503 15:22:50.135343       1 dns.go:270] Existing recordset &{0xc4215600e0 0xc42048f3d8} is not equivalent to needed recordset {0xc4214b6af0 0xc42048f488}, removing existing and adding needed.

I0503 15:22:50.135584       1 route53.go:50] AWS request: route53 ChangeResourceRecordSets

I0503 15:22:50.273914       1 endpoint_helper.go:161] Error ensuring DNS Records: InvalidChangeBatch: Duplicate Resource Record: ***IP ADDRESS***
	status code: 400, request id: 5e8ae720-3014-11e7-94d1-99d1a5bc81fa

 Comment by nikhiljindal
Monday May 22, 2017 at 19:02 GMT

I do not understand the issue here.
I do not see a scenario where federation will try to create multiple DNS records resolving to same IP address.

from @matt-potter
this leads to both the service in the federation cluster context and the service in the host cluster context referencing the same ELB address (is this correct behaviour?)

I am not too familiar with our type=LoadBalancer service implementation on AWS, but does that create Route53 DNS records?
If yes, then I can see how that can cause a problem if Route53 does not allow creating multiple DNS records resolving to the same IP address.
But then @crigor said DNS worked fine for him in zone us-east-1, which should not have happened?

 Comment by matt-potter
Monday May 22, 2017 at 19:18 GMT

@nikhiljindal Apologies, I forgot to link in my PR - but this one I submitted and is currently open resolves this issue I believe. It only occurs when a cluster spans multiple availability zones in the same region. https://github.com/kubernetes/kubernetes/pull/45492

 Comment by nikhiljindal
Monday May 22, 2017 at 19:36 GMT

Thanks @matt-potter That PR seems to target multi-zone clusters. The original description on this issue talks about single-zoned clusters (2 clusters, one each in us-east-1 and us-east-2).
Can you briefly explain what you think the issue here is? Describe a scenario where federation will try to create multiple DNS records resolving to same IP address.

 Comment by matt-potter
Monday May 22, 2017 at 19:52 GMT

@nikhiljindal The implication from the log in the initial issue report from @crigor is that the cluster in us-east-2 does in fact span multiple zones. The output reads Healthy endpoints [ae0cf9867fbf611e6954b023f939bc0f-805436699.us-east-2.elb.amazonaws.com ae0cf9867fbf611e6954b023f939bc0f-805436699.us-east-2.elb.amazonaws.com] exist and that is generated by the getHealthyEndpoints function here: https://github.com/kubernetes/kubernetes/blob/master/federation/pkg/federation-controller/service/dns.go#L224 The only way, as far as I can tell, that you will get duplicate entries in the returned array is if the same ELB (and therefore cluster) spans multiple availability zones.
Essentially, the federation controller iterates over the endpoints per zone (here https://github.com/kubernetes/kubernetes/blob/master/federation/pkg/federation-controller/service/dns.go#L262), but in a multi zone environment you will get the same ELB address in each zone, resulting in the duplicates in the returned array.

 Comment by quinton-hoole
Thursday Sep 07, 2017 at 23:16 GMT

We don't support federation of multi-zone clusters at the moment.  There are several similar issues.  If anyone can present some useful use-cases for federating multi-zone clusters, I will re-prioritize this, otherwise it goes on the backlog as a nice-to-have.

cc @crigor


Bug/Feature Request: suppress requirements.lock generated timestamp

Checking in requirements.lock files is a great way to make package generation reproducible.
However, the generated: timestamp leads to unnecessary changes in requirements.lock files when invoking helm dep update. These changes tend both to obscure the important differences in lock file deltas (the changed subchart versions) and to cause unnecessary merge conflicts in version control.
In the degenerate case where none of the dependency versions are changed, 'helm dep update' will generate a lock file identical except for the timestamp. I'm uncertain whether this last behavior holds when updating a lock file in place (I'm seeing https://github.com/kubernetes/helm/issues/2731, so am always deleting and re-generating the lock file).
Notably, the other mainstream dependency-lock file formats I'm familiar with (e.g. Gopkg.lock) do not include a generation timestamp. Same dependency versions -> same lock file is a useful property.
Proposal: Add a --no-stamp flag for helm dep update which suppresses the generated timestamp. Or just eliminate the timestamp entirely, but perhaps that is too large a change.
In the meantime, would manually stripping out the timestamp be likely to break things? A quick examination of the helm codebase suggests that the timestamp is written but never actually read and used.

/remove-lifecycle stale
If the proposal is acceptable, we would be happy to implement it.

closing as inactive.


Slugify should handle Æ, Ø, Å, æ, ø, å (#27)

This fixes the dataset population on the organization page for the Athenæum of Philadelphia and covers several other possible characters. It's likely this pattern should be further refined.

@ddohler In util.js you'll find this branch that's used to filter down the datasets by organization:
export function createDatasetFilters (filters) {
  return function (dataset) {
    const conditions = []
    if (filters.organization) {
      conditions.push(dataset.organization && slugify(dataset.organization) === filters.organization)
    }

slugify was taking a dataset.organization of athenæum-of-philadelphia and turning it into athen-um-of-philadelphia, which didn't match the filters.organization of athenæum-of-philadelphia. It was really straightforward once you mentioned that disabling JavaScript fixed the behavior. The duplication of the JavaScript and the Jekyll filtering confused me there, but it seems like the JS filtering is necessary as a part of integrating JS search.


FEAT-#3336: support nunique aggregate in OmniSci backend

What do these changes do?
Support nunique aggregate in groupby.agg method.

[x] commit message follows format outlined here
[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #3336
[x] tests added and passing
[x] module layout described at docs/developer/architecture.rst is up-to-date

@ienkovich , can you explain what is the difference between previous and current implementation? It seems to me they are identical but implemented on different layers.

I prefer to make the translation of nunique to distinct count on a lower level to avoid multiple places where we have to make such a translation. With this approach, we don't need additional changes to have nunique aggregation in groupby.agg.


Add Nong Song:

Song Name
Jumper x Hello
Artist Name
Waterflame & OMFG
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=Z_WrSy2muHs
Direct File Link
No response
Song ID
-6
Start Offset [ms]
0
Extra
No response

reject
adjust the song id to 6 instead of -6


Add new operator to be able to change audit-log-maxage, audit-log-maxbackup, audit-log-maxsize

How can this PR be verified?
Modify the number of audit-log-maxage, audit-log-maxbackup, audit-log-maxsize when use this operator
Is there any change in kubo-release?
no
Is there any change in kubo-ci?
no
Does this affect upgrade, or is there any migration required?
no
Which issue(s) this PR fixes:
https://github.com/cloudfoundry-incubator/kubo-deployment/issues/362
Release note:
Add new operator to be able to change audit-log-maxage, audit-log-maxbackup, audit-log-maxsize in Kube-apiserver args.

/repoen

Hey @obeyler
Could you please add a description in manifests/README what this ops-file does?

@obeyler Your commit have been merged into develop
A few things for next time:

PR branches should be created off of develop instead of master
Run unit tests ./bin/run_tests before submitting. There was a small typo in test-standar-ops.sh causing them to fail.

These were easy enough for us to change but please do take note of them for a smoother PR process in the future. Thanks for the PR!


Add Tweets User Mentions Api

I am not sure where should call getUserMentionsTweets in ClientApp, just put it in onMapInit method and use test id<PHONE_NUMBER>933003776. Please review. Thanks

I am not sure where should call getUserMentionsTweets in ClientApp, just put it in onMapInit method and use test id<PHONE_NUMBER>933003776. Please review. Thanks

Hey meng, we won't need to call this from clientApp, it will be called someone on the server. However, have you got this to work? I tried calling the api from postman and got this:

Hi @davidmjiang I make it like http://localhost:3000/api/usermentionstweets?twitterId=1350123171933003776. you can have a try. I will remove changes in clientapp

Ok, the api is working now. I wonder if we should be cleaning up the response so that we get back only what we're interested in, which is the array of tweets. Or do you think that will be done at a different step?


Update sts to 2.13.6

Updates software.amazon.awssdk:sts from 2.11.14 to 2.13.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk", artifactId = "sts" } ]

labels: library-update, semver-minor

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   46.57%   46.57%
=======================================
  Files          24       24
  Lines         277      277
=======================================
  Hits          129      129
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b073fa...24aa137. Read the comment docs.


fix dma channel

fixes #171

to make it more nice we maybe want to get rid of the magic number and use the Dma enum from esp-idf-hal/spi https://github.com/esp-rs/esp-idf-hal/blob/master/src/spi.rs#L63 since esp-idf-svc already depends on esp-idf-hal ?

@ivmarkov  Any plans to introduce e2e tests, so these issues wouldn't happen again?

@ivmarkov Any plans to introduce e2e tests, so these issues wouldn't happen again?

We have very limited number of resources, in that I am only doing this in my free time, and the Espressif folks are currently focused on the bare-metal portfolio, where there is a lot to catch on.
With that said, I'm absolutely for introducing tests (and documentation), however - given the resource availability - I think the community should step in and contribute in these areas. :)

@ivmarkov Any plans to introduce e2e tests, so these issues wouldn't happen again?

We have very limited number of resources, in that I am only doing this in my free time, and the Espressif folks are currently focused on the bare-metal portfolio, where there is a lot to catch on.
With that said, I'm absolutely for introducing tests (and documentation), however - given the resource availability - I think the community should step in and contribute in these areas. :)

I would love to help here, but from what I can tell to test this correctly would need to run on an actual device. To be fair I'm not too sure how to run tests on a real device :/ To do this properly I feel we would need to have some fleet of esp32/s2/s3/c3. This does feel like something Espressif could easily build.
Do you know any examples of how to run tests on real devices? If we had a framework here on how to do it, I would be willing to contribute more tests.
Interesting that Espressif doesn't bet more on Rust. I hope they do financially support this project at least :)


decide if user exists by calling server api and not by checking gun record

this can help not to initialize user storage and just initialize wallet on user  signup

in #2184


Update META6.json

You had an additional comma, you can't have speculative trailing ',' in strict JSON

I had already made the change. Thanks for your help, though!


Microsoft Edge: Object doesn't support property or method 'Symbol(Symbol.iterator)'

My React app generates a JS bundle with browserify+babel (presets "react" and "es2015", and plugins "transform-runtime", "transform-object-assign" and "transform-object-rest-spread"), and it includes  react-tooltip.
When in Microsoft Edge 15, I get this error when the <Tooltip> component is "rendered":
Object doesn't support property or method 'Symbol(Symbol.iterator)'

I know that there are some issues with Babel + Symbol and that, sometimes, a Babel polyfill is required (I don't use polyfills in my app but just Babel runtime transformations as listed above). However, Edge does natively support Symbol. I mean: typeof Symbol() === "symbol" and so on.
So no idea about the origin of this error. However it just happens when using react-tooltip.
The error stack points to here (look for "// HERE"):
exports.default = function (target) {
  target.prototype.bindRemovalTracker = function () {
    var _this = this;

    var MutationObserver = getMutationObserverClass();
    if (MutationObserver == null) return;

    var observer = new MutationObserver(function (mutations) {
      var _iteratorNormalCompletion = true;
      var _didIteratorError = false;
      var _iteratorError = undefined;

      try {
        for (var _iterator = mutations[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
          var mutation = _step.value;
          var _iteratorNormalCompletion2 = true;
          var _didIteratorError2 = false;
          var _iteratorError2 = undefined;

          try {
            for (var _iterator2 = mutation.removedNodes[Symbol.iterator](), _step2; !(_iteratorNormalCompletion2 = (_step2 = _iterator2.next()).done); _iteratorNormalCompletion2 = true) {
              var element = _step2.value;

              if (element === _this.state.currentTarget) {
                _this.hideTooltip();
                return;
              }
            }
          } catch (err) {
            _didIteratorError2 = true;
            _iteratorError2 = err;
          } finally {
            try {
              if (!_iteratorNormalCompletion2 && _iterator2.return) {
                _iterator2.return();
              }
            } finally {
              if (_didIteratorError2) {
                throw _iteratorError2;
              }
            }
          }
        }
      } catch (err) {
        _didIteratorError = true;
        _iteratorError = err;
      } finally {
        try {
          if (!_iteratorNormalCompletion && _iterator.return) {
            _iterator.return();
          }
        } finally {
          if (_didIteratorError) {
            throw _iteratorError;  // HERE
          }
        }
      }
    });

    observer.observe(window.document, { childList: true, subtree: true });

    this.removalTracker = observer;
  };

  target.prototype.unbindRemovalTracker = function () {
    if (this.removalTracker) {
      this.removalTracker.disconnect();
      this.removalTracker = null;
    }
  };
};

Friendly ping.

I'm seeing this pretty consistently too.  Any planned fix?

Same issue here.

+1

+1

+1

Quick solution:
// Pollyfill for Edge - react tooltip
NodeList.prototype[Symbol.iterator] = [][Symbol.iterator]

+1, same problem

How to use that quick solution? That error is breaking some javascript on IE

IE 11 broken by this also, as it doesn't even have Symbol. Going to try including the source in my own project.

Guys, as the README clearly states this project is looking for maintainers:

I learnt a lot from creating and maintaining react-toolip, but now I start putting my focus on other challenges, so just let me know by sending email to<EMAIL_ADDRESS>if you have interests in maintaining the project :)

So it's expected that the author won't fix this. If someone has the knowledge and the will to maintain this project, please contact him.
I do know that adding +1 in the issue comments is much easier than taking the work with you and solving problems, but this is what we have.

I fixed this by replacing
for (const mutation of mutations) {   for (const element of mutation.removedNodes) {
with the loop equivalent:
for (var m1 = 0; m1 < mutations.length; m1++) {         const mutation = mutations[m1]         for (var m2 = 0; m2 < mutation.removedNodes.length; m2++) {           const element = mutation.removedNodes[m2]
Make this substitution in src/decorators/trackRemoval.js and rebuild.

I am version 3.4.0, still broken on IE 11. Error is Symbol is undfined at for (var _iterator = mutations[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {

Resolution to this issue for IE 11 for me is to install polyfill which can make babel to compile Symbol

Install babel-polyfill
npm install --save babel-polyfill

Import babel-polyfill before react-tooltip
import "babel-polyfill";

If you are not using npm then you can use cdn to add polyfill js like:
<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.6.15/browser-polyfill.min.js">

@kristiankeane I adopted your solution of simply using a 'for' loop.
Everyone who has the opportunity, please try this again with v3.4.2, and re-open if needed.


Define how throwaway accounts are to be created

To simplify deployment of contracts, we will:

Deploy contracts using a "throwaway account"
Set the owners of the token and marketplace contracts to a multi-sig wallet

The question is: what are the steps to create the "throwaway account"? Also, the throwaway account needs ETH to pay for the gas for the deployments. So, this process needs to include transferring enough ETH to the throwaway account. Plus, we should transfer back any ETH before we throw away the account.
cc @joshfraser

It's easy to create a new wallet in Metamask. I'm happy to send funds to whoever is doing the deploy.

We currently deploy all our contracts (token, marketplace, identity) using the same account because we use the truffle migrate tool.
Are we comfortable throwing away the account we use for deploying the identity contracts ?
Is there any chance we would need that account for some operations on those contracts in the future ? I can't think of anything but CCing @tyleryasaka and @nick to make sure...

We don't actually have to throw away the keys, the point is that the ownership is going to be transferred to a mutisig wallet. The identity contacts don't have an owner, so it shouldn't matter for them.

Yes, you are right, the identity contracts don't have an owner so should not matter.


Callback function not receive

Hi, i tried the example in ESP32:
#include <WiFi.h>
#include <WebSocketsClient.h>  // include before MQTTPubSubClient.h
#include <MQTTPubSubClient.h>  //https://github.com/hideakitai/MQTTPubSubClient

WebSocketsClient client;
MQTTPubSubClient mqtt;

void setup() {
    // start your network
    WiFi.begin("blabla", "blublu");
    // connect to host with MQTT over WebSocket securely
    client.beginSSL("public.cloud.shiftr.io", 443);
    client.setReconnectInterval(2000);
    // initialize mqtt client
    mqtt.begin(client);
    // connect to mqtt broker
    mqtt.connect("arduino", "public", "public");

    // subscribe callback which is called when every packet has come
    mqtt.subscribe([](const String& topic, const String& payload, const size_t size) {
        Serial.println("mqtt received: " + topic + " - " + payload);
    });
    // subscribe topic and callback which is called when /hello has come
    mqtt.subscribe("/paradise/paradise_msg", [](const String& payload, const size_t size) {
        Serial.print("msg:  ");
        Serial.println(payload);
    });
}

void loop() {
    // should be called to trigger callbacks
     mqtt.update();
     // publish message
     static uint32_t prev_ms = millis();
     if (millis() > prev_ms + 1000) {
        prev_ms = millis();
        mqtt.publish("/paradise/paradise_msg", "world");
    }
}

and a HTML/Javascript client:
<html>

<head>
<title>Msg MQTT </title>
  <!-- https://github.com/mqttjs/MQTT.js -->
<script src="mqtt.min.js"></script>

<script>
  const options_shiftr = {
        clean: true, // retain session
        connectTimeout: 4000, // Timeout period
        // Authentication information
        clientId: 'arduino',
        username: 'public',
        password: 'public',
  }
  const connectUrl = 'wss://public.cloud.shiftr.io:443'
  const client = mqtt.connect(connectUrl, options_shiftr)

  client.subscribe("/paradise/paradise_msg")

  client.on("message", function (topic, payload) {
    console.log ("Recv: " + payload.toString());
  })

  client.on('connect', function () {
  console.log('connected ao broker')
})

</script>
</body>

</html>
</head>

This client receive all message send by ESP32, but ESP32 dont receive in callback.
I need help to solve this.
Thank you

Nothing appears to be sent from JS. What are you sending?

Hi. ESP32 sent and JS just receive.
Callback function in ESP32 should receive the message , right?

Yes

But don´t receive

？？？

Hi. ESP32 sent and JS just receive.

You should send some message from us to esp32

I believe I am having a similar issue, see code below:
I am able to listen for messages coming from the ESP32 on my Home Assistant client, but anything I send to the "/Hello" subscription from HA does not show up on the ESP32 serial monitor. Not only that, but if I am understanding this correctly I should be seeing "/hello world" after each message publishing, right? Because the ESP32 is subscribed to those messages even if it is the one sending them.
Thanks for any guidance, some screenshots are below.

#include <WiFi.h>
#include <MQTTPubSubClient.h>
const char* ssid = "OMICRON420";
const char* pass = "";
WiFiClient client;
MQTTPubSubClient mqtt;
void connect() {
connect_to_wifi:
Serial.print("connecting to wifi...");
while (WiFi.status() != WL_CONNECTED) {
Serial.print(".");
delay(1000);
}
Serial.println(" connected!");
connect_to_host:
Serial.print("connecting to host...");
client.stop();
while (!client.connect("<IP_ADDRESS>", 1883)) {
Serial.print(".");
delay(1000);
if (WiFi.status() != WL_CONNECTED) {
Serial.println("WiFi disconnected");
goto connect_to_wifi;
}
}
Serial.println(" connected!");
Serial.print("connecting to mqtt broker...");
mqtt.disconnect();
while (!mqtt.connect("arduino", "mqtt_user", "mqttpassword")) {
    Serial.print(".");
    delay(1000);
    if (WiFi.status() != WL_CONNECTED) {
        Serial.println("WiFi disconnected");
        goto connect_to_wifi;
    }
    if (client.connected() != 1) {
        Serial.println("WiFiClient disconnected");
        goto connect_to_host;
    }
}
Serial.println(" connected!");

}
void setup() {
Serial.begin(115200);
WiFi.begin(ssid, pass);
// initialize mqtt client
mqtt.begin(client);

// subscribe callback which is called when every packet has come
mqtt.subscribe([](const String& topic, const String& payload, const size_t size) {
    Serial.println("mqtt received: " + topic + " - " + payload);
});

// subscribe topic and callback which is called when /hello has come
mqtt.subscribe("/hello", [](const String& payload, const size_t size) {
    Serial.print("/hello ");
    Serial.println(payload);
});

connect();

}
void loop() {
mqtt.update();  // should be called
if (!mqtt.isConnected()) {
    connect();
}

// publish message
static uint32_t prev_ms = millis();
if (millis() > prev_ms + 1000) {
    prev_ms = millis();
    mqtt.publish("/hello", "world");
}

}

Does the example sketch work?

New experiment based in example WiFiMQTToverWebSocketSecure.ino and client HTML/JS
ESP32 code:
#include <WiFi.h>
#include <WebSocketsClient.h>  // include before MQTTPubSubClient.h
#include <MQTTPubSubClient.h>

const char* ssid = "blabla";
const char* pass = "blueblue";

WebSocketsClient client;
MQTTPubSubClient mqtt;

void connect() {
connect_to_wifi:
    Serial.print("connecting to wifi...");
    while (WiFi.status() != WL_CONNECTED) {
        Serial.print(".");
        delay(1000);
    }
    Serial.println(" connected!");

connect_to_host:
    Serial.println("connecting to host...");
    client.disconnect();
    client.beginSSL("public.cloud.shiftr.io", 443);
    client.setReconnectInterval(2000);

    Serial.print("connecting to mqtt broker...");
    while (!mqtt.connect("arduino", "public", "public")) {
        Serial.print(".");
        delay(1000);
        if (WiFi.status() != WL_CONNECTED) {
            Serial.println("WiFi disconnected");
            goto connect_to_wifi;
        }
        if (!client.isConnected()) {
            Serial.println("WebSocketsClient disconnected");
            goto connect_to_host;
        }
    }
    Serial.println(" connected!");
}

void setup() {
    Serial.begin(115200);
    WiFi.begin(ssid, pass);

    // initialize mqtt client
    mqtt.begin(client);

    // subscribe callback which is called when every packet has come
    mqtt.subscribe([](const String& topic, const String& payload, const size_t size) {
        Serial.println("mqtt received: " + topic + " - " + payload);
    });

    // subscribe topic and callback which is called when /hello has come
    mqtt.subscribe("/paradise/paradise_msg", [](const String& payload, const size_t size) {
        Serial.print("recv:  ");
        Serial.println(payload);
    });

    connect();
}

void loop() {
    mqtt.update();  // should be called

    if (!mqtt.isConnected()) {
        connect();
    }

}

Client HTML/JS
<html>

<head>
<title>Msg MQTT v1</title>
  <!-- https://github.com/mqttjs/MQTT.js -->
<script src="mqtt.min.js"></script>

<script>
  const options_shiftr = {
        clean: true, // retain session
        connectTimeout: 4000, // Timeout period
        // Authentication information
        clientId: 'arduino',
        username: 'public',
        password: 'public',
  }
  const connectUrl = 'wss://public.cloud.shiftr.io:443'
  const client = mqtt.connect(connectUrl, options_shiftr)

  client.subscribe("/paradise/paradise_msg")

  // callback message received
  client.on("message", function (topic, payload) {
    console.log ("Recv: " + payload.toString());
  })

  client.on('connect', function () {
  console.log('connected ao broker')
})

  // send message every 2 second
  setInterval(function () {
                            client.publish("/paradise/paradise_msg", "Hello mqtt");
                           }, 3000);

</script>
</body>

Result:

Conclusion:
ESP32 connect to wifi and broker, but don´t receive message

To help us isolate the problem, please try the following steps.

Can the example publish and subscribe to the message /hello “as is”?
Can your js code subscribe to the message /hello published by your device (as same as 1)?
Remove publishing /hello on your device and add publishing /hello from your js code. Can the device and your js code subscribe /hello as before?
Replace /hello to your message. Can the device and your js code subscribe to your message?

To help us isolate the problem, please try the following steps.
Can the example publish and subscribe to the message /hello “as is”?
Device just publish
Can your js code subscribe to the message /hello published by your device (as same as 1)?
yes work fine
Remove publishing /hello on your device and add publishing /hello from your js code. Can the device and your js code subscribe /hello as before?
Device don´t receive(subscribe) , JS client receive (subscribe)
Replace /hello to your message. Can the device and your js code subscribe to your message?
no
Conclusion
Subscribe on Device ESP32 don´t work
Video demo:
https://youtu.be/lpCVfJUjCBI

Thanks, I will try later (currently, I don't have any devices)

Thanks

The problem was just an order of connect() and subscribe() order. See https://github.com/hideakitai/MQTTPubSubClient/pull/27 for details.

Thank you. Work fine!!!


Add SetSockOpt definitions related to Linux Kernel TLS.

kTLS is implemented as a TCP ULP, so add a SetSockOpt impl for it.

kTLS parameters are pushed to the kernel using setsockopt(SOL_TLS),
so add SetSockOpt impls for them.

Other test fixes:

Change setsockopt tests to bind to port 0 so that
they bind to an unbound port and don't affect each other.

Fix skip! macro used to skip tests to generate its own block so that
it can be used as an expr.

What does this PR do
Implement additional definitions needed to set up kTLS.
Checklist:

[x] I have read CONTRIBUTING.md
[x] I have written necessary tests and rustdoc comments
[x] A change log has been added if this PR modifies nix's API

The Linux CI did fail with EADDRINUSE. I did notice when I was writing the test that all the setsockopt tests that did bind were using the same port, and I wondered how it was that they never stepped on each other. I guess it was just luck that nobody hit it before.
Should I change my test and all the others to use unique ports?

Yes, you should change the port number.

Will do.

Also, would it be possible to add some docs? It isn't obvious how to use this.

The documentation is https://docs.kernel.org/networking/tls.html . I'll add comments explaining which setsockopt call each of the structs maps to.

And is there any overlap with PR https://github.com/nix-rust/nix/pull/2065 ?

No. The steps of using kTLS are:

Set up TCP connection.

Do TLS handshake however you want, say using rustls or openssl.

Enable the TLS ULP on the TCP socket. (setsockopt(TclUlp, b"tls") from this PR.)

Import the TLS secrets for sending and receiving to the TCP socket. (setsockopt(TcpTlsTx, ...) and setsockopt(TcpTlsRx, ...) from this PR.)

Read and write to the TCP socket using regular socket syscalls. Reading should use recvmsg because the kernel will send cmsg's with level == libc::SOL_TLS and type == libc::TLS_GET_RECORD_TYPE whenever there is a non-application data / post-handshake record. (The recvmsg changes in #2065 )

There are a bunch of tests that don't pass under cross.  If you're sure that this test failure is cross-induced, you could skip the test in CI by adding #[cfg_attr(qemu, ignore)].

 If you're sure that this test failure is cross-induced, you could skip the test in CI by adding #[cfg_attr(qemu, ignore)].

Yes, that is what I had been battling with.

Done, and verified with my test program.

@asomers @SteveLauC Ping.

Normally, asomers will maintain Nix on Friday/weekend

@SteveLauC Ping. This has been ready to merge for two weeks now, and I'm tired of fixing all the merge conflicts from the other newer PRs that keep getting merged :)
This is also blocking more fixes I want to make to the GetSockOpt / SetSockOpt traits.

Understand, let's merge this!


prepone

@sannihith1995 thanks for taking the time to open this Pull Request, however it does not match the overall style of the project.  I am going to close it, please re-open if you have a non-style reason for making this change.


Add WithTailChecker option to depacketizer

While Galene is now using its own samplebuilder, it would be good
to avoid splitting the community by having the public interfaces
diverge too much.  This means preventing internal details of the
samplebuilder from leaking into other parts of Pion.
An earlier commit sneaked in the IsDetectedFinalPacketInSequence
method to the rtp.Depacketizer interface.  Not only does this
break compatibility with earlier versions, it requires every single
implementation of rtp.Depacketizer to implement essentially the
same code.  It is also conceptually wrong, as the job of finding
the end of the packet belongs in the samplebuilder, not in the
depacketizer.
In this commit, we treat partition ends similarly to partition
starts: we add a new callback to the samplebuilder whose role
is to determine whether a packet ends a partition.  A new option
WithPartitionTailChecker, analogous to WithPartitionHeadChecker,
can be used to set that field.  Tests are adapted.

Since we have IsDetectedFinalPacketInSequence I am going to close this as wontfix for v3.*
The API disagreement is unfortunate, but I think we need to stick with it until v4. @jech If you feel strongly I am in support of completely reworking the public API for v4 we have a couple other things for it as well.

@Sean-Der in that case, I suppose we move the PartitionHeadChecker into the codec too, in order to avoid having an inconsistent API.  I'll see if I have time to submit a PR in time for 3.1.0.


Fix incorrect file name in step 2.5

Step should refer to openstack_user_config.yml* not openstack_user_variables.yml*

:+1:

@git-harry forget your vote?

@prometheanfire I figured that was implied.

@git-harry it is, but better to be explicit then implicit (or so I've been told :P)


Support pagination

I see python lib suports pagination, but it is lacking over here. Please support it.
Thanks

This seems to have been here a lifetime, is this API even maintained?


fix: azure sas key url encoding

Description
The object store crate encode the sas key values internally. When passing in an already encoded sas key, they would get double encoded. Since sas keys acquired from the azure portal and azure storage explorer are encoded, and this is "ususally" how a user would get them we decode them before passign them to object store.
I was not completely sure what the desired bahvior should be, alternatively we could update the documentation, to show a sas keys from the portal should be handled.
import deltalake
from urllib.parse import unquote

storage_options = dict(account_name=storage_account, sas_token=unquote(sas))
dt = deltalake.DeltaTable(azure_uri, storage_options=storage_options)

Related Issue(s)
closes #910
Documentation

The proposed workaround
import deltalake
from urllib.parse import unquote

storage_options = dict(account_name=storage_account, sas_token=unquote(sas))
dt = deltalake.DeltaTable(azure_uri, storage_options=storage_options)

does not properly work in latest deltalake-0.6.4.
SIG section in the SAS token ends with %3D, which is = URL encoded
In result, PyDeltaTable is trying to access the URL with removed = from the end.
Ex.:
Original URL Suffix:

URL Suffix from the PyDeltaTableError: Signature fields not well formed. exception

That is correct. THis issue has been fixed in a previous PR that is on main, but not yet in the released python bindings. #1007


Android-Kotlin: 02.2 Collection in Kotlin

I would like to work on this issue. ( Collection in Kotlin )

yeah, you can start working.
Supervisor @rahulsain

I want to make video content on this, May I ?
Lavleen Agrawal (Batch 5 - Android Kotlin)
@sitamadex11

I want to make video content on this, May I ?
Lavleen Agrawal (Batch 5 - Android Kotlin)
@sitamadex11

and I am working on documentation on this Topic

yes

I would like to contribute into this topic . Can you please assign the documentation part to me.

@shubhmittal07 Doc part of this issue has already been merged

@LavleenAgrawal Any update regarding your task?

@sitamadex11 yes sir completed...but remaining to attach on github because it isnt allowed to create multiple pull request....and i dont know how to attach it to same pull request...please guide

@LavleenAgrawal you should make your desired changes in your branch through which you have made the PR. If you still can't resolve please ping us on discord.

@LavleenAgrawal extremely sorry for late reply.


flutter gen-l10n treats decimalPatternDigits as invalid

$ flutter gen-l10n
Because l10n.yaml exists, the options defined there will be used instead.
To use the command line arguments, delete the l10n.yaml file in the Flutter project.

Number format decimalPatternDigits for the count placeholder does not have a corresponding NumberFormat constructor.
Check the intl library's NumberFormat class constructors for allowed number formats.

$ flutter --version
Flutter 3.7.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 12cb4eb7a0 (2 weeks ago) • 2023-03-01 10:29:26 -0800
Engine • revision ada363ee93
Tools • Dart 2.19.3 • DevTools 2.20.1

lib/l10n/app_en.arb
{
  "test": "Hey {count}",
  "@test": {
    "placeholders": {
      "count": {
        "type": "double",
        "format": "decimalPatternDigits"
      }
    }
  }
}

Thanks for filling the issue and PR, @Albert221
This issue is reproducible on the latest stable and master channels with the source string and error message as above.
Related documentation: https://pub.dev/documentation/intl/latest/intl/NumberFormat/NumberFormat.decimalPatternDigits.html

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.7, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.7.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (10 hours ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.9.0-8.0.pre.19, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.9.0-8.0.pre.19 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d043c93e1a (2 hours ago), 2023-03-15 21:44:10 -0400
    • Engine revision 903ea2eabc
    • Dart version 3.0.0 (build 3.0.0-322.0.dev)
    • DevTools version 2.22.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (4 available)
    • SM T225 (mobile)       • R9JT3004VRJ                          • android-arm64  • Android 13 (API 33)
    • iPhone 14 Pro (mobile) • AB2EBB55-6852-40A7-9A12-057128370920 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 111.0.5563.64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

@thkim1011 can you take a look at this?


Rename API to importPlugin

This should help with having same name in both System and on ServerHost

@typescript-bot cherry-pick this to release-4.8

@typescription cherry-pick this to release-4.8

@typescript-bot cherry-pick this to release-4.8


fix: add the path to the origin url

When gitlab is hosted in a nested path (e.g. http://www.company.com/gitlab) the release MR creation would fail because it would try and fetch the repo without the path (/gitlab) in the origin URL.
This MR adds the path to the origin url.

Thanks for your contribution first! Are you trying to fix #116?

I was getting the exact same error as #116 but the cirsumstances described there is different.
It looks as though the gitlab instance in that issue is hosted at the root path (/) so this MR is unlikely to make a difference.