[release-1.3][BugFix]VMIController: creation should be observed

manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/12850

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/cc @xpivarc

/cherry-pick release-1.2
/cherry-pick release-1.1
/cherry-pick release-1.0

@Barakmor1 Please have a look at the failures

@xpivarc Strange does it look like a flake to you?

@xpivarc Strange does it look like a flake to you?

I would rebase on top of new release-1.3 just in case.

@xpivarc Strange does it look like a flake to you?

I would rebase on top of new release-1.3 just in case.

It is up to date, i'll try to retest to make sure it's a flack
/retest

@xpivarc Please note that mostly 1.31 lanes are failing

/test all

/retest-required

/hold cancel

/unhold
/retest-required

/unhold

/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-storage

/test pull-kubevirt-e2e-k8s-1.31-sig-compute-1.3
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations-1.3
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial-1.3
/test pull-kubevirt-e2e-k8s-1.31-sig-network-1.3
/test pull-kubevirt-e2e-k8s-1.31-sig-operator-1.3
/test pull-kubevirt-e2e-k8s-1.31-sig-storage-1.3

/override pull-kubevirt-e2e-k8s-1.31-sig-compute
/override pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
/override pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/override pull-kubevirt-e2e-k8s-1.31-sig-network
/override pull-kubevirt-e2e-k8s-1.31-sig-storage
/override pull-kubevirt-e2e-k8s-1.31-sig-operator
/override pull-kubevirt-e2e-kind-1.27-vgpu

/override @kubevirt-bot
pull-kubevirt-unit-test-s390x

/override pull-kubevirt-unit-test-s390x

/override pull-kubevirt-fossa
/override pull-kubevirt-fuzz
/override pull-kubevirt-goveralls


fix: XML Document CA1574

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0026855-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-nightly/nuget/v3/index.json) [PRBUILDID]


Variable substitutions in text

A system for including variable values in dialogue and choice texts would be a good addition. Currently this is left to the consumer I guess.

Implemented this.


chore(ai): code review

What this PR does 📖

Trying out AI code review

no merging, just a bot saying what he thinks about the code 😂

example

Have this been tested out any on uplink to get any ideas on how it would give its "thoughts" on the code? Will it be in a single response or over multiple responses?

one way we can test this, is to add some sample rust code in here and see what the bot does
i tested this locally, hence the screenshot above but not in the CI

just added a rust sample code full of bugs to see what the bot does 😂

so bot was running he says
LGTM! :+1:
lol 😅
@dariusc93 what are your thoughts in that code? the sample.rs thing i've added in the PR
chatGTP says it has the following errors

This code contains several errors:

Line 8 tries to add a string and an integer together.
Line 12 tries to access an index that is out of bounds for the vector v.
Line 16 tries to assign the result of a string concatenation to a variable that is not mutable.
Line 18 tries to assign an integer value to a variable that has been explicitly declared as an i32.
Line 20 tries to access an element of a tuple that doesn't exist.
Line 24 tries to pop a character from an empty string.
Line 26 tries to access an index that is out of bounds for the array arr.
Line 30 uses an incorrect syntax to format a string.
Line 36 compares an Option<i32> to None using the wrong operator.

This code contains several errors:

Line 8 tries to add a string and an integer together.
Line 12 tries to access an index that is out of bounds for the vector v.
Line 16 tries to assign the result of a string concatenation to a variable that is not mutable.
Line 18 tries to assign an integer value to a variable that has been explicitly declared as an i32.
Line 20 tries to access an element of a tuple that doesn't exist.
Line 24 tries to pop a character from an empty string.
Line 26 tries to access an index that is out of bounds for the array arr.
Line 30 uses an incorrect syntax to format a string.
Line 36 compares an Option<i32> to None using the wrong operator.

Is that in regards to the sample file? If so, it is off because

Line 12 is a else statement so its not trying to access an index that is out of bounds
Line 16 is a vector
Line 18 is a blank line
Line 20 is a string, not a tuple
Line 24 is a new i32 variable
Line 26 is a tuple, not an array
Line 30 is a new string, which is correct
Line 36 is a string

yes so, the bot from the PR says is all good
he replied LGTM
but then i asked chatGTP and he said that list of bugs about that file yes lol

so based on your reply both bot and chatgpt are wrong right? lol

so based on your reply both bot and chatgpt are wrong right? lol

The problem is mostly that the lines in the quote there dont add up with the lines in the sample.rs that is problematic. Lining it up, the problems are there, such as out of bounds, trying to add a string to an int, invalid element for the tuple, trying to print a Option, etc. (just stuff i can visibly see producing an error without running the code - pretty sure passing the sample into playground or in the IDE would show the errors and/or warnings).

yes got it lol but that feedback wasn't from this bot, this bot only said ''LGTM'' so even worse than the bad feedback from chatGTP 😅

will close the PR because bot doesn't work he just says LGTM


mlmym - frontend similar to old reddit for lemmy

link

easily copyable link
https://mlmym.org/

Thanks it's now added


Start Page

What do you guys think?

Wheres the code for this?

on the home-page branch?

what file? i cant seem to find it?

main.py


Entries in TOC without an ID are skipped when computing extent of TOC

When computing the extent of the TOC (i.e., the page range), TOC entries that do not have an ID are skipped. This can happen if sectids is unset on the document. As a result, the extent of the TOC may not match the extent of the TOC when inked in the primary document.
The converter should assume that all TOC entries provided are suitable for adding to the TOC and thus should not attempt to filter them.

The following document can be used to reproduce the issue:
= Document Title
:doctype: book
:toc:
:pdf-page-size: A5
:!sectids:

preface

== Chapter 1
== Chapter 2
== Chapter 3
== Chapter 4
== Chapter 5
== Chapter 6
== Chapter 7
== Chapter 8
== Chapter 9
== Chapter 10
== Chapter 11
== Chapter 12
== Chapter 13
== Chapter 14
== Chapter 15
== Chapter 16
== Chapter 17
== Chapter 18
== Chapter 19
== Chapter 20
== Chapter 21
== Chapter 22
== Chapter 23
== Chapter 24
== Chapter 25
== Chapter 26
== Chapter 27
== Chapter 28
== Chapter 29
== Chapter 30


[Feature Request] Form inputs and submit event

Existing Component
Yes
Component Name
Form
Description
Scenario:
Login form, filling username then password
Expected behaviour:
Pressing enter triggers the submit action of the form
Current behaviour:
Nothing happens

You need to listen to the key events of <el-input>

How?
I've tried with @keyup, but it doesn't trigger. If you mean to use the @change event, wouldn't it be too "verbose"?

Check out the first question of https://github.com/ElemeFE/element/blob/dev/FAQ.md


Trying add Osram Lightify Motion Sensor and Lightify Switch (4 buttons)

Hi
i'm successfully add Lightify Motion Sensor and Lightify Switch to deCONZ, but only Motion Sensor appears in Homebridge:
[10/18/2017, 7:47:21 PM] Loaded plugin: homebridge-hue
[10/18/2017, 7:47:21 PM] Registering platform 'homebridge-hue.Hue'
[10/18/2017, 7:47:21 PM] ---
[10/18/2017, 7:47:21 PM] Loaded config.json with 0 accessories and 1 platforms.
[10/18/2017, 7:47:21 PM] ---
[10/18/2017, 7:47:21 PM] Loading 1 platforms...
[10/18/2017, 7:47:21 PM] [Hue] Initializing Hue platform...
[10/18/2017, 7:47:21 PM] [Hue] config.json: warning: pilipsLights: ignoring unknown key
[10/18/2017, 7:47:21 PM] [Hue] config.json: warning: waitTimeSwitch: deprecated
[10/18/2017, 7:47:21 PM] [Hue] homebridge-hue v0.5.38, node v6.11.4, homebridge v0.4.28
[10/18/2017, 7:47:21 PM] [Hue] config.json: {"platform":"Hue","name":"Hue","host":"<IP_ADDRESS>","users":{"xxxxxxxx":"yyyyyyy"},"sensors":true,"excludeSensorTypes":[],"lowBattery":25,"lights":true,"pilipsLights":false,"wallSwitch":true,"groups":true,"group0":false,"rooms":false,"schedules":false,"rules":false,"heartrate":5,"timeout":5,"resource":true,"parallelRequests":10,"waitTimeResend":300,"waitTimeSwitch":100,"waitTimeUpdate":20}
[10/18/2017, 7:47:21 PM] [Hue] <IP_ADDRESS>: bridge request 1: get /config
[10/18/2017, 7:47:21 PM] Loading 0 accessories...
[10/18/2017, 7:47:21 PM] [Hue] <IP_ADDRESS>: bridge request 1: ok
[10/18/2017, 7:47:21 PM] [Hue] deCONZ-GW: deCONZ gateway v2.4.82, api v1.0.4
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: gateway request 2: get /
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: gateway request 2: ok
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 0 lights
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 0 groups
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: /sensors/1: CentraLite Motion Sensor-A (ZHAPresence) "Presence 1"
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: /sensors/1: warning: unknown ZHAPresence sensor {"config":{"on":true,"reachable":true},"ep":1,"etag":"3d81dcc4abb28dbe1664767b34a4650f","manufacturername":"CentraLite","modelid":"Motion Sensor-A","name":"Presence 1","state":{},"swversion":"����������������","type":"ZHAPresence","uniqueid":"00:0d:6f:00:0b:ec:8e:3c-01-0500"}
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: /sensors/2: CentraLite Motion Sensor-A (ZHATemperature) "Temperature 2"
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: /sensors/2: warning: unknown ZHATemperature sensor {"config":{"on":true,"reachable":true},"ep":1,"etag":"3d81dcc4abb28dbe1664767b34a4650f","manufacturername":"CentraLite","modelid":"Motion Sensor-A","name":"Temperature 2","state":{},"swversion":"����������������","type":"ZHATemperature","uniqueid":"00:0d:6f:00:0b:ec:8e:3c-01-0402"}
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 2 sensors
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 0 schedules
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 0 rules
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 2 accessories
[10/18/2017, 7:47:22 PM] [Hue] Initializing platform accessory 'deCONZ-GW'...
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: 2 services
[10/18/2017, 7:47:22 PM] [Hue] Initializing platform accessory 'Presence 1'...
Scan this code with your HomeKit App on your iOS device to pair with Homebridge:
┌────────────┐
│ 033-56-174 │
└────────────┘

[10/18/2017, 7:47:22 PM] Homebridge is running on port 51836.
[10/18/2017, 7:47:22 PM] [Hue] deCONZ-GW: listening on ws://<IP_ADDRESS>:443
[10/18/2017, 7:47:23 PM] [Hue] deCONZ-GW: gateway request 3: get /config
[10/18/2017, 7:47:23 PM] [Hue] deCONZ-GW: gateway request 3: ok
[10/18/2017, 7:47:23 PM] [Hue] deCONZ-GW: gateway request 4: get /sensors
[10/18/2017, 7:47:23 PM] [Hue] deCONZ-GW: gateway request 4: ok

It would seem the switch isn’t exposed by the deCONZ REST API plugin.  Is it supported by the plugin?
This motion sensor is new to me, but it’s loooking ok.  You might need a bit for deCONZ to setup attribute reporting before the temperature is shown.

The switch isn't supported currently. Ok
The sensor didn't work reliable compared to hue one. Ok
But both Switch and Sensor working fine within native Lightify app.
Thanks.

Not even other plugins (specifically for Lightify) support the switch and motion sensor.


more-specific return type for Charon3.core:JSONDecoder.decodeResource

mirroring the issue request here because it gets much more attention than Charon -
JSONDecoder.decodeResource currently returns a SCIMObject, but can be made much more type-safe without further code changes - public <T extends AbstractSCIMObject> T decodeResource(String scimResourceString, ResourceTypeSchema resourceSchema, T scimObject)
https://github.com/wso2/charon/issues/114
https://github.com/wso2/charon/pull/115

Fix committed with https://github.com/wso2/charon/commit/515002ab5b16de52035b564d0c6997cbfa43db5c


Fix Markdown blocks without labels render

Fix #322
Result

@Rachit1313 I'll get you to review this.

@Rachit1313 I'll get you to review this.

looks good to me but not confident enough. Is it possible for you to have a quick look?


Improved shutdown

When the duration is over -- display a message in case some requests are still pending
On SIGKILL shutdown, display a message asking for confirmation if there are some pending requests
cc @chartjes

also, the current loop shutdown is ugly and can be improved

for instance, ending the sizing does not go through all the worker teardowns.
we also need to avoid sleeping when the worker is not started yet. we need a trigger (like an event, or smaller sleeps, or an alarm)

sometimes molotov will hang at end of test - particularly if the server-under-test has high latency.  traffic generation clearly terminates but the end of test acknowledgement / report never happens.

I think an interactive confirmation is overkill. the new mode implemented in #107 is good enough - once we've validated with @rpappalax that it works as expected.


COLOS-19: CI enhancement

Issue ID
Continuation of #21
What has been done?

[x] Created a reusable workflow for the build and push docker image workflow
[x] Updated the build.yml file to check for the modified files and run the CI pipelines for the services that had changes

Sceenshots/Videos

Noice


More derived from

[ ] Tests added / passed
[x] Passes black dask / flake8 dask
[x] Towards #1815

This PR is in the same vein as #5709 and #5710. I didn't add any tests since I am just adding a disclaimer to docstrings.

Thanks!


ES5 class methods are not picked automatically if they are not at the root of the module

Hello,
I'm in the middle of a crusade. I have a class and I want it to be part of a module. If the class is no the same file where the module is declared everything works as expected: the class appears as part of the module with all its members. This is the exact thing that I was expecting, excellent!
But, if the class is in another file and I want it to be part of the module then I have to decide between  duplication of information on the module page or losing the automatic pickup of the class methods. I don't think this is the intended behavior, because it is quite confusing and inconsistent. Why declaring a class inside a module works and declaring it as part of the module does not?
Let me ilustrate this with a simple example:
This works flawlessly if this is the only file with the @module tag:
/**
 * @module  stuff
 */

/**
 * @function PersonsFactory
 * @param {Object} deps The class dependencty
 */
module.exports = function Factory(deps) {

    /**
     * @class
     * */
    const Person = function Person( name ) {
        this.name = name;
    };

    /**
     * Greets the user
     * @returns {void} Returns nothing
     */
    Person.prototype.greet = function greet() {
        console.log( 'I Use deps', deps );
    }

    return Person
}

However, none of this works as expected:
/**
 * @memberof module:stuff
 * @function HumanFactory
 * @param {Object} deps The class dependencty
 */
module.exports = function Factory(deps) {

    /**
     * @class
     * @memberof module:stuff
     * */
    const Human = function Human( name ) {
        this.name = name;
    };

    /**
     * Borns
     * @returns {void} Returns nothing
     */
    Person.prototype.born = function greet() {
        console.log( 'I Use deps', deps );
    }

    return Human
}

/**
 * @memberof module:stuff
 * @function HumanFactory
 * @param {Object} deps The class dependencty
 */
module.exports = function Factory(deps) {

    /**
     * @class module:stuff.Human
     * */
    const Human = function Human( name ) {
        this.name = name;
    };

    /**
     * Born as human
     * @returns {void} Returns nothing
     */
    Person.prototype.born = function greet() {
        console.log( 'I Use deps', deps );
    }

    return Human
}

If I create a second file with the @module tag at top, then the class will be properly documented, all the methods will appear as part of class and the class will be included on the module. The problem is that the main page of the module will have all it's members duplicated.

This example doesn't really make sense to me, because in both of the source files, you're assigning to module.exports. If module:stuff exports a single class, it seems like it has to export either PersonsFactory or HumanFactory, but not both.
Can you provide a better example?

Sorry @hegemonic , could you please expand on why does this make no sense to you? The file exports a factory that returns classes. I want to document both the factory and the class itself and I want to group all of them under the same module.
I think it is quite common to do require('myModule') to get the default export and also `require('myModule/person') to get a part of it, and both needs to be documented.
Does it make more sense after this explanation?

From JSDoc's perspective, that means you have two modules, not one. You'll need to document your code as two separate modules.
Module 1:
/** @module myModule */

/** Your docs here */
module.exports = function Factory(deps) {};

Module 2:
/** @module myModule/person */

/** Your docs here */
module.exports = function Factory(deps) {};

The example you gave will work if I have two different elements that belongs to the same module, fine. But what I have is a factory of classes. I want to document the class, but I also want to make clear that it should be called through the factory.
Splitting the class and the factory into two modules will force me to change the structure of my code, which I think it something that a documentation tool should not you force to do.
Regards


TimeCounter and restart

The time limit in TimeCounter is given in ms and then converted in ns which is leads to very small values when used with restart strategy.

Remove override limit on solution


Timeout to LocalDb in build validation pipeline

https://github.com/abbgrade/PsSqlTestServer/actions/workflows/build-validation.yml?query=branch%3Adevelop
Connections to LocalDb fail with an timeout.

done


Update OCI SDK from v27 to v38

With the new v38 OCI SDK, manually created and deleted an OKE clusters without any hiccup.

Thanks for the pull-request!


Some comment/question for “Set Up Rust”

Hello, newcomer here. Thanks for the wonderful series.
A comment and question about this post http://os.phil-opp.com/set-up-rust.html
I'm using Rust rustc 1.14.0-nightly (aef18be1b 2016-10-25), the part about missing fmod and fmodf functions seems doesn't happen to me. Probably it's already fixed?
Also, it's about the cargo part. Probably mentions/shows that cargo has been added in .PHONY target, and also cargo clean added in clean target in the Makefile (Tho, haven't checked if it's mentioned in the future post).

Thanks a lot for the report!
--

the part about missing fmod and fmodf functions seems doesn't happen to me. Probably it's already fixed?

I can no longer reproduce the linker error either. Thanks for the pointer! It seems like rustc no longer generates/needs those functions…
However, the most recent post (“Returning from Exceptions”) fails without --gc-sections:
target/test/debug/libblog_os.a(core.0.o): In function `_$LT$f32$u20$as$u20$core..num..dec2flt..rawfp..RawFloat$GT$::from_int::h2f372ef48b3d835a':
core.cgu-0.rs:(.text._ZN59_$LT$f32$u20$as$u20$core..num..dec2flt..rawfp..RawFloat$GT$8from_int17h2f372ef48b3d835aE+0x2): undefined reference to `__floatundisf'
target/test/debug/libblog_os.a(core.0.o): In function `_$LT$f64$u20$as$u20$core..num..dec2flt..rawfp..RawFloat$GT$::from_int::hbecf33dde444988c':
core.cgu-0.rs:(.text._ZN59_$LT$f64$u20$as$u20$core..num..dec2flt..rawfp..RawFloat$GT$8from_int17hbecf33dde444988cE+0x2): undefined reference to `__floatundidf'
Makefile:43: recipe for target 'build/kernel-x86_64.bin' failed

I guess it's because of the custom target: The “Set Up Rust” code shows the same error when compiled for a custom target (even without a feature key).
So I can think of two possible solutions:

Find a different motivation for --gc-sections in “Set Up Rust” (e.g. binary size). Most projects should use --gc-sections (AFAIK rustc uses it by default for executables), so it's good to introduce it early.
Remove any mention of --gc-sections from “Set Up Rust” and only introduce it when the error occurs for the first time in “Returning from Exceptions”. This would fit better into our “don't fix problems before they occur” approach.

--

Probably mention/show that cargo has been added in .PHONY target, and also cargo clean added in clean target in the Makefile

Good catch! Yeah, we should really do that.

In my incarnation of this kernel, I setup xargo in the first commit that adds rust with the custom target because having a sane build system and cross compile story is important from the beginning. Rather than viewing it as fixing a problem before it starts, I'd view it as doing the right thing from the beginning.

@ahmedcharles When I wrote the Set Up Rust post, xargo didn't exist and cross compiling was much more difficult. So I decided to use the standard x86_64-unknown-linux-gnu target as long as possible. I'm currently working on a complete overhaul of the blog and I think the new version will use xargo right from the start.

Closing since this was about the first edition, which is no longer maintained.


Include only extensions used in metadata + introduce SerializationContext

This PR continues from #847 and fixes the issue where extensions not used during serialization were written to the file metadata.  The fix necessitated adding a hook to yamlutil.dump_tree to modify the tagged tree after it had been converted, since only then do we know what extensions were used.
My long-term goal for the new SerializationContext class is for us to pass that object around instead of the AsdfFile itself.  Currently when AsdfFile.write_to is called, it modifies the AsdfFile instance in order to write with the specified parameters.  Some of these modifications are permanent, which breaks the contract of write_to (it's documented as an "export" type of operation that doesn't change the AsdfFile), and some are merely awkward, like these:
    def _post_write(self, fd):
        if len(self._tree):
            self.run_hook('post_write')

        # TODO: there has got to be a better way to do this...
        if hasattr(self, '_all_array_storage'):
            del self._all_array_storage
        if hasattr(self, '_all_array_compression'):
            del self._all_array_compression
        if hasattr(self, '_auto_inline'):
            del self._auto_inline

The new Converter API will receive an instance of SerializationContext in its ctx argument instead of AsdfFile, and in 3.0 all ctx arguments will contain SerializationContext.

A person might wonder where the tests are for this change.  It's difficult to test, since the problem only occurs when multiple extensions are loaded via entry points.  There is already a nice test for extensions that are passed to AsdfFile:
https://github.com/eslavich/asdf/blob/eslavich-add-serialization-context/asdf/tags/core/tests/test_history.py#L255
I'm content with that, but let me know if you think I should figure out a way to test the entry points case.


adds server-logging functionality to BlazeBuilder

This PR adds basic support for the Common Log Format as discussed @ #1708
A few things are still missing or unclear:

A request that fails and gets handled by ServiceErrorHandler[F] seems to yield a Response[F] without a Content-Length header. Blaze handles this "elsewhere", like in https://github.com/http4s/http4s/blob/d973c013ca0913ed3250d4c8eefbf8e2e7647ece/blaze-core/src/main/scala/org/http4s/blazecore/Http1Stage.scala#L70. At this point the response is disregarded so the logger will output an unhelpful "-" instead of the actual byte-count
Request[F] has a value .remoteUser which is is always None. Not sure what this is for.

The initial implementation focuses more on performance than elegance as a logger at this level means a performance hit for every request. It may need to be even more low-level.
Packages, naming and formatting will probably need some clean-up. I will address this as I go.

Just ran scalafmt on everything.

Now using org.log4s.Logger for logging. Users need to configure logging in logback.xml like so:
    <logger name="org.http4s.server.logging.ServerLogging" additivity="false">
        <appender class="ch.qos.logback.core.ConsoleAppender">
            <encoder>
                <pattern>%msg%n</pattern>
            </encoder>
        </appender>
    </logger>

I'm experimenting with collecting the logging data into an internally mutable datatype as it is parsed. It will take some more effort before it's ready though.

This PR seems stale and is largely blaze-focused, which is no longer developed here.


[10.x] Lockable Model Route Bindings

Problem Explanation
This feature allows developers to apply a lock on implicitly resolved models. Consider the following example:
Route::post('/user/{user}', function (ImplicitBindingModel $user) {
    if ($user->paid) {
        throw ValidationException::withMessages([...]);
    }

    // Pay user ...
    $user->update(['paid' => true]);

    return $user;
});

Since the controller action requires a read to $user->paid (some property indicating the user has been paid which must only happen once), there is a potential exploit by calling this function twice in quick succession. Since both calls happen at the same time, they retrieve $user->paid === false for both occasions, causing the code to be executed in both occasions as well. This requires a transaction in order to run it correctly.
Solution: Route withLocks()
By using the withLocks() option on your route (requiring the SubstituteBindings middleware), you can now make sure that models are retrieved with a read-lock using Eloquent's lockForUpdate(), using:
// New example
Route::post('/user/{user}', function (ImplicitBindingModel $user) {
    // Pay user etc.
})->middleware(['web'])->withLocks();

The controller action is now automatically wrapped in a transaction, with read-locks applied to all implicitly bound models. This also works with withTrashed() (this enables retrieval of soft-deleted models) so ->withLocks()->withTrashed() will work as expected too.
Old situation: DB::transaction(...) and manually retrieving models
An explicit way to do this currently (showing the current limitation) is:
// Old example
Route::post('/user/{user}', function ($userId)
{
    return DB::transaction(function () {
        $user = User::query()->lockForUpdate()->findOrFail($userId);

        if ($user->paid) {
            throw ValidationException::withMessages([...]);
        }

        // Pay user...

    });
});

Implicit model bounding cannot take place in the old situation, since the model would have been retrieved before the transaction commenced.

A very, very bad suggestion. You shouldn't wrap a controller call in a transaction, because the controller may have network calls (http, message brokers) whose delays can lead to longer transaction times, the number of which is usually limited. Increasing the number of concurrent transactions will degrade the database. And you should certainly not use locks in such scenarios.

Yes it is obvious that this approach does not work if your controller actions are bound to take seconds. What would you suggest in a scenario were all actions are local (and fast) ? I guess using a cache lock has some merit but it seems much more logical to use database level tools like row level locks.
Verzonden vanaf Outlook voor Androidhttps://aka.ms/AAb9ysg

From: kafkiansky @.>
Sent: Friday, January 27, 2023 8:01:42 PM
To: laravel/framework @.>
Cc: Bert @.>; Author @.>
Subject: Re: [laravel/framework] [10.x] Lockable Model Route Bindings (PR #45832)
A very, very bad suggestion. You shouldn't wrap a controller call in a transaction, because the controller may have network calls (http, message brokers) whose delays can lead to longer transaction times, the number of which is usually limited. Increasing the number of concurrent transactions will degrade the database. And you should certainly not use locks in such scenarios.
—
Reply to this email directly, view it on GitHubhttps://github.com/laravel/framework/pull/45832#issuecomment-1406951505, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACQDEI3CPGIL4PTZYUDHYW3WUQLRNANCNFSM6AAAAAAUI5FN34.
You are receiving this because you authored the thread.Message ID: @.***>

Yes it is obvious that this approach does not work if your controller actions are bound to take seconds. What would you suggest in a scenario were all actions are local (and fast) ? I guess using a cache lock has some merit but it seems much more logical to use database level tools like row level locks. Verzonden vanaf Outlook voor Androidhttps://aka.ms/AAb9ysg
…

I suggest using small explicit transactions where necessary. This is nothing new, though. You see a problem where there is no problem.

Too much magic.
Too much coupling.

Too much magic. Too much coupling.

Where is the magic exactly? I can agree with the coupling argument in that this uses database-level locks instead of other options like cache locks. But before attempting to code such an abstraction I'd like to know if it even is a desired feature to have.


Can't find hooks for content modification

The readme includes the following statement: Provides hooks for handling authentication, content modification, etc.
I was hoping that the hook for content modification would allow for zipping a file when it is received, and for examining the headers of the request for metadata, but I don't see the hooks.
So far, I've added connection.on('file.stor', ...), but the payload seems to be only 'open' or 'close', not something that gives access to modifying the file when it lands.
Could you point me in the right direction?

Never mind. I realized that my overall approach was wrong.


Validation: May 6th. Fixed Alt-text and Invalid-author

Fixed several alt-text missing issues and invalid-author

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Angelines-YG sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@Rick-Anderson
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge

@Rick-Anderson
Requested changes have been made.
Please review within five business days and merge or comment in the PR with any additional changes you’d like to see. Thank you!


fixed some scala code style

val defines a fixed value (which cannot be modified)
var defines a variable (which can be modified)

fixed all(about 65) the "var could be a val"  scala code warnings in the whole project

@QiangCai  please review this PR

LGTM.

rebased. @ravipesala @QiangCai pls check. thanks

LGTM

rebased @QiangCai

LGTM


CONTRIBUTING.md

Missing Contributing.md file
Description
This pull request enhances the CONTRIBUTING.md file for the BuddyTrail by providing clearer guidelines and a more structured format.
Related Issues

Closes #45

Type of PR

[X] (Documentation update)

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Hey @PriyaGhosal  I have raised the PR
Do assign me the labels "GSSOC-Ext", "hacktoberfest-accepted" and "level2" or else my contribution wont be counted
Thanks

@archanasingh11 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution to GSSOC'24 EXTENDED! 🎉

Can u explain me why my merge is appearing in red color


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_cco6tu61ix/clone/recipe/meta.yaml:17: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_cco6tu61ix/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_cco6tu61ix/clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_cco6tu61ix/clone/recipe/meta.yaml:44: invalid_url: https://autobahn-python.readthedocs.io : Not reachable: 404
WARNING: /tmp/abs_cco6tu61ix/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_66obp2b_76/clone/recipe/meta.yaml:17: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_66obp2b_76/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_66obp2b_76/clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_66obp2b_76/clone/recipe/meta.yaml:44: invalid_url: https://autobahn-python.readthedocs.io : Not reachable: 404
WARNING: /tmp/abs_66obp2b_76/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
Errors were found


Migrate Projects And Events From v4 To v5

We have an existing self-hosted v4 instance of Exceptionless and would like to update to v5 at some point. Is there a way to migrate our existing data (projects, events, etc.) from v4 to v5? We are using file storage to store the events. Let me know if you need more info from me. Thanks!

There is no migration needed for data on disk or elastic. If you update the paths and connection string in docker-compose you could use your existing cluster and storage. I'd recommend doing this until the next major version as it would make the migration to Elasticsearch 7 a bit easier. However, if you wanted to move it over you could just copy the files from the current structure into the directory configured in the docker compose and then do an elasticsearch snapshot in the old cluster and restore it in the new cluster.

Please let us know if you have anymore questions or need anymore help.

Ok, that makes sense. I'm not very familiar with Docker, so I was thinking I needed to move data and stuff. Thank you!


Adding Support for Uint8arrays in createTypedArrays

We have added support for Uint8arrays when using IndexDatatype.createTypedArrays in IndexDatatype.js for issue #10349 . We have added a numberOfVertices check inside of the function and created a new constant called TWO_FIFTY_SIX_BYTES inside Math.js
We have corrected a few test cases inside Core/Geometry/Pipeline, Core/IndexDatatype, Scene/PrimitivePipeline, Scene/Model/GeoJsonLoader.
We are a little confused on how to \ correct the render test cases, because there is an internal GL_INVALID_OPERATION: Insufficient buffer size error. Most of the errors are just expecting to render some pixel but not rendering it.
We would like some help on how to get started correcting the following test cases:

[ ] Scene/Geometry3DTileContent
[ ] Scene/Vector3DTileContent
[ ] Scene/Vector3DTileGeometry
[ ] Scene/Vector3DTilePolygons
[ ] Scene/Vector3DTilePolylines

Thanks for the pull request @Charlyjcmu!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@j9liu As you opened the original issue, would you mind providing some guidance on the tests here? Particularly around the error:

DeveloperError: IndexDatatype.UNSIGNED_INT requires OES_element_index_uint, which is not supported on this system.  Check context.elementIndexUint.

If this requires a particular extension, should there be a fall back in place for systems that its not supported on?

@ggetz I'll take a look at this PR but I am confused why the UNSIGNED_INT would be causing errors now, since this PR is just adding support for typed arrays with uint8 or UNSIGNED_BYTE. Was there no fallback in the first place for using UNSIGNED_INT ?
It also seems like this functionality is provided by WebGL2, and only in WebGL1 is the extension needed. So what would the correct procedure be for checking UNSIGNED_INT support when #10894 is merged?

Thanks @j9liu!

Was there no fallback in the first place for using UNSIGNED_INT ?

Context.elementIndexUint has a check in place already, but bases on the test result, my guess is that value is not being properly accounted for.

It also seems like this functionality is provided by WebGL2, and only in WebGL1 is the extension needed. So what would the correct procedure be for checking UNSIGNED_INT support when https://github.com/CesiumGS/cesium/pull/10894 is merged?

It will still be possible to opt into WebGL1, in which case we should still be checking for extension support. The above function should already account for that.

I'll have to return to this later but from snooping around I found a couple things:

There's this part of the code that has a Uint16 vs Uint32 bit check that we missed
https://github.com/CesiumGS/cesium/blob/27abb992eb5a434f1c9391f5e926643473ebc985/packages/engine/Source/Renderer/VertexArray.js#L678-L697
This is what happens in the 3D Tiles Terrain Classification sandcastle (which uses Vector3DTileContent). This also happens in the ArcticDEM sandcastle.

Something I noticed about EllipseGeometry while trying to debug it: it looks like both Uint16 and Uint8 arrays get made at some point in the progress. So if these differently-sized indices get packed together, they're going to lead to bad results. We'd need to look closer into that code though to figure out what incorrect assumptions are being made.

Hi @Charlyjcmu,
Were you and your team going to continue work on this? Even though it has become more difficult than expected, I'm willing to investigate the areas that are producing these bugs and provide guidance on what needs changing.
Otherwise, this PR will be closed for inactivity and I will update the issue to describe the full scope of this problem.

Yes, our team will keep working on it. We took a break for a while, but we will keep working on it for a while longer.


No links in email for admin created account

Hello,
Yesterday, I did something on our Gogs instance on behalf of a friend:

Created his account,
Added him to an organization,
Added him to a team.

My friend received various emails confirmations, and the links were pointing to the Gogs website rather than to our instance.
Gogs version <IP_ADDRESS>6 Beta from docker image.
Not tested with <IP_ADDRESS>7 Beta #develop.

I can confirm this with version <IP_ADDRESS>7 the E-Mail does not contain any link to the instance where the account has been created.

If it was admin created the account, yes I can confirm there is no link to the instance. Is this the case?

@Unknwon yes that's the case.

@Unknwon Yes, you nailed it. As i said, I basically went through the whole user creation on behalf of my friend using my administrative account.

It looks like as follows right now:


BaseSequencer class uses deprecated type WorkspaceSpec

Describe the bug
BaseSequencer class uses WorkspaceSpec type, marked as @deprecated.
https://github.com/vitest-dev/vitest/blob/63f8b07042e9885d74daca7e175351c47078b99a/packages/vitest/src/node/sequencers/BaseSequencer.ts#L5
Reproduction
You should see a warning about using the deprecated WorkspaceSpec type during the build process.
System Info
System:
    OS: Linux 6.8 Ubuntu 22.04.5 LTS 22.04.5 LTS (Jammy Jellyfish)
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz
    Memory: 3.77 GB / 15.40 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 20.12.1 - ~/.volta/tools/image/node/20.12.1/bin/node
    Yarn: 3.7.0 - ~/.volta/tools/image/yarn/3.7.0/bin/yarn
    npm: 10.5.0 - ~/.volta/tools/image/node/20.12.1/bin/npm
    bun: 0.1.5 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 130.0.6723.58
    Chromium: 129.0.6668.100
  npmPackages:
    @vitest/coverage-v8: ^2 => 2.1.1
    vitest: ^2 => 2.1.3

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

What is the problem? It uses deprecated object because the arguments will change in Vitest 3, we can't just replace it.


Switch microk8s enable wrapper to Python script

For now, it's just a clone of the old bash script, with the ability to handle unix-style flag arguments. Using click however, will allow expanding the enable scripts to be full click subcommands, instead of just bash scripts.
Fixes #1446

@knkski do we drop the checking for addons if they are already running?  If yes, i think this is required, sometimes users manually edit the resource, and when the user enabled it again, it loses their previous changes.

@balchua: The use case for dropping that check is a result of #1397. If a user enables kubeflow and it either fails or the kubeflow namespace is later deleted, a user will be unable to either enable or disable kubeflow.
It would be nice to have microk8s.enable kubeflow support redeploying in case of a failed enable attempt, but maybe there's a better way to handle that. @ktsakalozos, @balchua: thoughts? cc @RFMVasconcelos, who I think also had opinions on that.

Thanks @knkski for the info. Instead of dropping that altogether, maybe we can consider adding idempotent: true or false into the addon-list.yaml?  If idempotent is true then we dont reapply otherwise we reapply.
Another option i can think of is an option --force that users can pass to the enable action.  Example:
microk8s enable --force kubeflow
These are just options on top of my head.

sometimes users manually edit the resource, and when the user enabled it again, it loses their previous changes.

The enable script used to reapply the manifests without checking if the addon was already enabled. This was causing some confusion [2] and we had to fix it [1].
@knkski kubeflow enables the dns addon but I also think it expects the forward dns to be correctly set. Will the kubeflow deploy in an environment where <IP_ADDRESS> is not reachable?
[1] https://github.com/ubuntu/microk8s/pull/927
[2] https://github.com/ubuntu/microk8s/issues/958

So does it mean that enable command do not need to check whether it is enabled or not?

Sorry I was not clear. We need to keep the current behavior of not re-applying the addon manifests. We have to respect any configuration users have on the running workloads.

Aaa ok. Thanks for clarifying.

I've updated this PR so that it keeps the current behavior of not enabling already-enabled addons, for everything but Kubeflow, which has it's own logic for handling that. Namely, it will allow disabling Kubeflow even if Kubeflow is already disabled, which lets us fix #1397.
I didn't create a idempotent: true section in addon-list.yaml, opting instead for a hardcoded check for the kubeflow addon, but I could add that if desired.

Thanks @knkski.  Im good with that.  The unix style args is nice.

@knkski there are a few conflicts in this PR. Do you think you could address them so we get this PR ready for 1.20? Thank you.

Just reverted this PR, there are a few things (probably minor) that will need a bit more attention.
On enable/disable we request the status of each addon [1]. We should first make sure the API server is running or else the get status fails with:
14:55:29 2020-11-27 at 12:55:29 | INFO + /snap/microk8s/1829/actions/enable.cilium.sh
14:55:29 2020-11-27 at 12:55:29 | INFO Traceback (most recent call last):
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/scripts/wrappers/enable.py", line 32, in <module>
14:55:29 2020-11-27 at 12:55:29 | INFO enable(prog_name='microk8s enable')
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/usr/lib/python3/dist-packages/click/core.py", line 716, in __call__
14:55:29 2020-11-27 at 12:55:29 | INFO return self.main(*args, **kwargs)
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/usr/lib/python3/dist-packages/click/core.py", line 696, in main
14:55:29 2020-11-27 at 12:55:29 | INFO rv = self.invoke(ctx)
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/usr/lib/python3/dist-packages/click/core.py", line 889, in invoke
14:55:29 2020-11-27 at 12:55:29 | INFO return ctx.invoke(self.callback, **ctx.params)
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/usr/lib/python3/dist-packages/click/core.py", line 534, in invoke
14:55:29 2020-11-27 at 12:55:29 | INFO return callback(*args, **kwargs)
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/scripts/wrappers/enable.py", line 25, in enable
14:55:29 2020-11-27 at 12:55:29 | INFO enabled_addons, _ = get_status(get_available_addons(get_current_arch()), True)
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/scripts/wrappers/status.py", line 157, in get_status
14:55:29 2020-11-27 at 12:55:29 | INFO kube_output = kubectl_get("all")
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/scripts/wrappers/common/utils.py", line 169, in kubectl_get
14:55:29 2020-11-27 at 12:55:29 | INFO return run("kubectl", kubeconfig, "get", cmd, "--all-namespaces", die=False)
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/scripts/wrappers/common/utils.py", line 39, in run
14:55:29 2020-11-27 at 12:55:29 | INFO result.check_returncode()
14:55:29 2020-11-27 at 12:55:29 | INFO File "/snap/microk8s/1829/usr/lib/python3.5/subprocess.py", line 659, in check_returncode
14:55:29 2020-11-27 at 12:55:29 | INFO self.stderr)
14:55:29 2020-11-27 at 12:55:29 | INFO subprocess.CalledProcessError: Command '('kubectl', '--kubeconfig=/var/snap/microk8s/1829/credentials/client.config', 'get', 'all', '--all-namespaces')' returned non-zero exit status 1

Similar case is when we enable/disable addons. We used to wait for up to 30 seconds for the API server to get ready [2]. This way if an addon enables/disables the apiserver we would not fail in [3].
The last thing that needs some mending is the --help. Most of the addons do not have a --help so we are pushing the users to this wrong path:
ubuntu@ip-172-31-40-63:~$ microk8s.disable --help
Usage: microk8s disable [OPTIONS] ADDONS...

  Disables one or more MicroK8s addons.

  For a list of available addons, run `microk8s status`.

  To see help for individual addons, run:

      microk8s disable ADDON -- --help

Options:
  --help  Show this message and exit.
ubuntu@ip-172-31-40-63:~$ microk8s.disable dns -- --help
Disabling DNS
Reconfiguring kubelet
Removing DNS manifest
serviceaccount "coredns" deleted
configmap "coredns" deleted
deployment.apps "coredns" deleted
service "kube-dns" deleted
clusterrole.rbac.authorization.k8s.io "coredns" deleted
clusterrolebinding.rbac.authorization.k8s.io "coredns" deleted
DNS is disabled

We should get back the old help message.
[1] https://github.com/ubuntu/microk8s/pull/1467/files#diff-44f8a77098734624eb59a3c59e17024d622e15fb9927eb4d6f3583ac724ffe25R25
[2] https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/wrappers/microk8s-enable.wrapper#L31
[3] https://github.com/ubuntu/microk8s/pull/1467/files#diff-cea8894ac12cb68765874a03fba91e79d22c596d86633886b5c02abe52829448R246


cannot run the tool with conda

Thanks for implementing TAMPA. I installed the tool with conda:
conda config --add channels defaults
conda config --add channels bioconda
conda config --add channels conda-forge
conda create -c etetoolkit -y -n CAMIViz python=3.7 numpy  ete3  seaborn pandas matplotlib biom-format
conda activate CAMIViz

But when I try to run python src/profile_to_plot.py within the CAMIViz env, I get the following error:
python: can't open file 'src/profile_to_plot.py': [Errno 2] No such file or directory

Sorry about that, we have renamed profile_to_plot.py to tampa.py. The README as also been updated. Could you please try running it again?

Thanks for the response.
I had an error while trying to install with github:
$ git clone git@github.com:dkoslicki/TAMPA.git

Cloning into 'TAMPA'...
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be established.
ED25519 key fingerprint is SHA256:+DiY3wvvV6TuJJhbpZisF/zLDA0zPMSvHdkr4UvCOqU.
This key is not known by any other names
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

which I solved with:
git clone https://github.com/dkoslicki/TAMPA

I'm not sure what I'm doing wrong. But if I try to run the test example, I get an error:
$ python src/tampa.py -i data/prediction_multi.profile -g data/ground_truth_multi.profile phylum -s CAMI_HIGH_S001 -b basename -k linear -c False -r 1600 -o .

False
CAMI_HIGH_S001
Traceback (most recent call last):
  File "src/tampa.py", line 337, in <module>
    if __name__ == "__main__": main()
  File "src/tampa.py", line 334, in main
    generateFigure(PF, sample, rank, output_base_name, output_path, file_type, plot_l1, scaling, output_dpi, use_profile, fw, fh, limit, limit_value)
  File "src/tampa.py", line 106, in generateFigure
    PF.make_tax_id_to_percentage(sample=sample)
  File "/Users/milanese/Desktop/TAMPA/src/ProfilesLayout.py", line 168, in make_tax_id_to_percentage
    self.profile_tax_id_to_percentage = self.predictions_to_tax_id('profile', sample)
  File "/Users/milanese/Desktop/TAMPA/src/ProfilesLayout.py", line 151, in predictions_to_tax_id
    predictions = sample_dict[sample]['predictions']
KeyError: 'CAMI_HIGH_S001'

Sorry about that, could you please try
python src/tampa.py -i data/mad_yalow_0.profile.txt -g data/ecstatic_nobel_0.profile.txt phylum -s marmgCAMI2_short_read_sample_0 -b metaphlan_motu -k linear -r 1600  -o .

I get:
$ python src/tampa.py -i data/mad_yalow_0.profile.txt -g data/ecstatic_nobel_0.profile.txt phylum -s marmgCAMI2_short_read_sample_0 -b metaphlan_motu -k linear -r 1600 -o .

False
Input file could not be read.

And actually data/mad_yalow_0.profile.txt is not in the repo:
$ ls data/mad_yalow_0.profile.txt
ls: data/mad_yalow_0.profile.txt: No such file or directory


Cannot import PG_OP

Hi,
Thank you for sharing the code.
I followed the instruction to setup the environment and successfully compile the files. However, I met the following error, when I try to import PG_OP.
 import PG_OP
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: /home//PointGroup/lib/pointgroup_ops/PG_OP.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN6caffe26detail36_typeMetaDataInstance_preallocated_7E

I am using CUDA 10.2, PyTorch 1.1.0 and python3.7.
Thank you in advance.

OK, after struggling for more than 10 hours,  I finally figured out the way to set up the environment. For anyone who may get stuck in the future,
Test Environment:  CUDA 10.2 + PyTorch 1.5.0 (conda installed)+ python 3.7
1. conda create -n pnt_group python=3.7
2. conda install pytorch==1.5.0 torchvision==0.6.0 cudatoolkit=10.2 -c pytorch
3. pip install all the pkgs in the requrement.txt except for torch
4. conda install all the dependencies on the instruction until spconv compiling

I recommend to compile pointgroup_ops first, as it is likely to fail in the first trial due to the extremely less reference. Issue #4 is very helpful.
5. export INCLUDE_PATH=/path/to/conda/envs/pnt_group/include:$INCLUDE_PATH
6. python setup.py build_ext --include-dirs=$INCLUDE_PATH$
7. python setup.py develop

Now test the installation
python
>> import PG_OP

In my case, I first got a error saying ImportError: libcudart.so.10. This is due to the missing of cudatoolkit. It should not happen if we follow step 2. The I got another error saying
ImportError: libc10.so: cannot open shared object file: No such file or directory

I still do not know why it happens, but we can temporally do
export LD_LIBRARY_PATH=/path/to/conda/envs/envs/pnt_group2/lib/python3.7/site-packages/torch/lib/:LD_LIBRARY_PATH

I did not source it just in case it will mess up with other environments.
Next, we need to install spconv 1.2 for Pytorch 1.5. The one contained in this repo. is not compatible!
8. git clone https://github.com/traveller59/spconv.git --recursive
9. edit the spconv/functional.py as Li does in this commit https://github.com/llijiang/spconv/commit/740a5b717fc576b222abc169ae6047ff1e95363f
10. remove the '-Wall' line in /path/to/conda/envs/pnt_group2/lib/python3.7/site-packages/torch/share/cmake/Caffe2/Caffe2Targets.cmake
11. python setup.py bdist_wheel

This step will throw out tons of warnings, but it seems fine to ignore them.
12. cd /spconv/dist/
13. pip install *.whl (we just generated in step 11)

The code works fine for me after all of these installation.


[FEATURE] Chargeback a mindflayer beam

Feature
I've always wanted to be able to chargeback a mindflayer beam. perhaps it could have some interaction with the core eject, and create a blue explosion with more damage, and a good amount of style points to go with it.
Usage
This would solve no problems but would make for really stylish gameplay and cool combos, which is kinda the point of the game.

This feature requires a little bit more explanation.


CONTRIBUTING: Add notes about how to contribute.

@mjmartineau This is document is a work-in-progress.


Improving Vim modeline regex

Fixes #2389

/ cc @pchaigno

Looks good to me :+1:
On the same subject, do we check the whole file for modelines? Could we limit it to the first 20-30 lines (in case there's a header in comments)?

On the same subject, do we check the whole file for modelines? Could we limit it to the first 20-30 lines (in case there's a header in comments)?

We check the whole file because there's a subset of people/editors? that add these to the bottom of files :-\


Add grievejia to the allowlist

I understand that this project is experimental and breakages are possible. Wouldn't rely on it for anything critical. Just want to try it on one of my personal project.

This is fine by me, as long as you can give us feedback on how it works for you. An issue here with any good/bad experiences would be appreciated.


Removing showing updates on never updated assets

Fixes #436
Changes proposed in this PR:

Removes datatokens.createTime & datatokens.tx from the ReceiptData query
Removes showing updates on never updates assets (using only datatokens.updates)

yeah, that package-lock: long story short, with npm v7 (which is default with Node.js v15) the lock file will automatically be updated to lockfileVersion v2 upon doing npm install. But npm v7 comes with some more challenges for us so we were holding off on too many dependency updates.
For now, what would work for this PR, is to get the old Node.js v14/npm v6 lock file, if you use nvm:
nvm use 14
npm i
git commit
git push

This should restore the v1 lock file version. Also we kinda forgot to document the need for npm below v7, since it only arises as problem when adding/changing dependencies.
Other than that, the actual fix works perfectly on first quick look 🥳

I guess we can do it like this for now. In the future this will be a bug. You can have assets from outside the market that don't have this order. When we split the market and add multiple pools and other flows this will be inaccurate as well. You can create the ddo before the asset very easy.


Add "Website Visitor" Widget in Footer

Describe the feature
I would like to add a "Website Visitor" widget in the footer of the website that shows the number of visitors so far. This widget will update in real-time or upon page refresh to provide an accurate count of the total visitors.
This feature will enhance user engagement by providing visible visitor statistics and can be a useful metric for site administrators to track traffic.
Add ScreenShots
Preview of proposed Website Visitor widget:

Please assign this issue to me under the gssoc label
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I would love the opportunity to contribute and work on this project.
Could you please assign the issue to me? I’m eager to dive in and make a meaningful impact. Thank you for considering my request!

This is not required


Update to new AbstractDifferentiation.jl

Potential alternative to https://github.com/JuliaDiff/Diffractor.jl/pull/228
There's something weird and wrong happening with failing tests though. If I include all the stuff into my REPL, @test_broken behaves properly, but if I actually do ] test then a bunch of them propagate their failures outside of the @test_broken so I had to manually comment them out to get them to behave.

bump @oxinabox


Download not working

All downloads after apktool_2.0.0rc4.jar result in 0-byte files.

Yes aware. Out of my control. Blame bitbucket.
http://connortumbleson.com/apktool/ (mirrors)

The mirror works, thank you.

https://github.com/iBotPeaches/Apktool/commit/93ab25887db150525ed70a89138ac514d6578f5f#commitcomment-16560635 - Post Mortem if interested.


Support MVC 5's @Html.Validate() helpers

MVC 5 (and likely earlier versions) provides the following HTML helpers that are not present in MVC 6:

Validate(this HtmlHelper htmlHelper, string modelName)
ValidateFor<TModel, TProperty>(this HtmlHelper<TModel> htmlHelper, Expression<Func<TModel, TProperty>> expression)

May decide this should be part of #1232 but that's a triage decision...

These helpers had to do with the Ajax based validation we are not carrying forward


"Store" has changed to "Apps"

In Teams desktop and web clients, as of today.
Refer to section https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/apps/apps-upload#upload-your-package-into-a-team-or-conversation-using-the-store.
Refer to related issue, https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3066.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 328c86a9-1384-3f07-0b68-947f5ad9b5ab
Version Independent ID: 9a8e000a-87ed-1357-0b28-feee59311149
Content: Upload your custom app in Microsoft Teams - Teams
Content Source: msteams-platform/concepts/apps/apps-upload.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

Duplicate of #964

This is not a duplicate as it refers to a different page in the MS docs site. Both doc pages need to be updated and other report doesn't reference the same page. You should re-open this issue and fix the doc page.


/api/v1/tags/ returns an empty list

When adding a trailing slash on the tags api call it will search for an empty key which is not allowed. This should be the same as doing a search with /api/v1/tags.

There is already a test case for this scenario. Problem was for an older internal endpoint only.


Can I set the caption for the whole project to be included in the translation file?

In the app.json file, it is possible to set the name of the project.
"id": "fc6df0b5-53e3-43a2-b538-35df4f62e8ac",
"name": "Seminar Module",
"publisher": "D. E. Veloper",
The name from the app.json is also used as the heading in the Departments menu.
Can the caption of the project be included in the translation file somehow?

Hi @peikba, this is not possible for now. See #2374.


docs(design): Added accessibility docs for checkbox

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
There was no description in the checkbox docs
Fixes: N/A
What is the new behavior?
Added a description and accessibility information for the checkbox docs
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

There's an open PR #953 for adding docs to checkbox.

There's an open PR #953 for adding docs to checkbox.


Improvement for Azure.ResourceManager.Compute: specify some types

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Compute


Expose/separate browser devtools from web devtools

I went to "Tools > Toggle Developer Tools" and somehow Web Inspector loses context and I end up with a representation of the Tofino internals and not the page/site itself:

We should probably be explicit that this is for browser development, not web development and expose a traditional web dev tools option here as well (and rename the current one)

I think we should use a different shortcut for the 'browser toolbox' version (maybe cmd/ctrl+alt+shift+i), and possibly have it auto-open when running via npm run dev.  Then keep the current shortcut reserved for the web page inspector.

Right-click and 'Inspect element' already works. We might want to have better UI for this though at some point.


[INLONG-2035][Bug] Agent use wrong tid __ to generate message

[INLONG-2035][Bug] Agent use wrong tid __ to generate message
Fixes #2035
Motivation
Agent use wrong tid __ to generate message
Modifications
Agent use right tid  to generate message
Documentation

Does this pull request introduce a new feature? (no)

Codecov Report

Merging #2039 (9b3a7e0) into master (786b667) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2039   +/-   ##
=========================================
  Coverage     12.28%   12.28%
- Complexity     1158     1159    +1
=========================================
  Files           413      413
  Lines         35225    35225
  Branches       5542     5542
=========================================
+ Hits           4326     4328    +2
+ Misses        30132    30127    -5
- Partials        767      770    +3

Impacted Files
Coverage Δ

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
45.31% <0.00%> (-0.40%)
:arrow_down:

.../tubemq/corebase/policies/FlowCtrlRuleHandler.java
34.51% <0.00%> (+0.44%)
:arrow_up:

.../inlong/tubemq/corebase/policies/FlowCtrlItem.java
40.00% <0.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786b667...9b3a7e0. Read the comment docs.


SSSS

SSSSSS

SS

@bren4ireland thanks for your interest in Microsoft Graph. This appears to be a mistake, so I'm closing this pull request. If that's not the case, please provide context.


xmls and masks

Hey,I was following your tutorial but i am not able to get about xmls and masks in annotation folder.

You will not get any xml file but just masks. Mask will be saved in the directory of image and then you need to move colored masks to annotation folder. Follow https://www.youtube.com/watch?v=tX-xcg5wY4U&t=171s

Yeah thanks,that helped.
On Mon, Dec 31, 2018, 23:18 Vijendra Singh<EMAIL_ADDRESS>wrote:

You will not get any xml file but just masks. Mask will be saved in the
directory of image and then you need to move colored masks to annotation
folder. Follow https://www.youtube.com/watch?v=tX-xcg5wY4U&t=171s
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vijendra1125/Custom-Mask-RCNN-using-Tensorfow-Object-detection-API/issues/1#issuecomment-450673921,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Af--HSo5wcEeGPZA7wq9ee-Bq4dd7ikfks5u-k3fgaJpZM4ZlMwL
.

I am glad to know that it helped.


Divide by zero encountered in double_scalars for StatsTestUI

This error took place when running a F-test analysis on all four sample files.
C:\workspace\MultiscaleStatisticalAnalysis\StatsTestsUI.py:285: RuntimeWarning: divide by zero encountered in double_scalars
  f_val = np.round_(var[1] / var[0], 4)

Currently in the process of recreating this error. Seems to be possible by running a discrimination analysis on all four samples.

Having difficulty recreating error. Could have been resolved after fixing workbook issues (#9).

This issue has not occurred in quite some time. As of now, it will be closed until further notice.

Error has re-occured:
C:\workspace\MultiscaleStatisticalAnalysis\StatsTestsUI.py:285: RuntimeWarning: divide by zero encountered in double_scalars
  f_val = np.round_(var[1] / var[0], 4)
C:\workspace\MultiscaleStatisticalAnalysis\StatsTestsUI.py:282: RuntimeWarning: divide by zero encountered in double_scalars
  f_val = np.round_(var[0] / var[1], 4)

This was accomplished by running an f-test on all four sample files. The alpha value was set to 0.05, the max-f was 0.95, and the scales were set to the min and max respectively.

Graph does not appear to be being interferred with (although that is hard to determine).

Variance for the f values are being set to zero. I would assume this was meant to occur, but dividing a larger value by zero seems incorrect. A quick bandaid fix would be setting the f_val to zero if this is going to occur, but I am not sure what that would mean for the math.

This issue will be fixed in an upcoming patch, and does not need to be in the following release.


Attempting to validate a object without discriminator field results in exception

When a schema have a discriminator property and this property is provided an invalid value, it results in an exception. It did not happen on version 1.10.0. I believe this started to happen somewhere along the 1.10 version, probably on 1.10.1 or 1.10.8.
Definition exemple:
      oneOf:
        - $ref: '#/components/schemas/content.text'
        - $ref: '#/components/schemas/content.file'
      discriminator:
        propertyName: type
        mapping:
          text: '#/components/schemas/content.text'
          file: '#/components/schemas/content.file'

If so instead of using type as either text or file, I use something like audio I no longer get a validation error and instead get a exception:
Cannot read property 'type' of undefined TypeError: Cannot read property 'type' of undefined
And happens at:
at runValidate (/home/rafael.souza/git/api-control/node_modules/openapi-enforcer/src/schema/validate.js:82:86)
It seems to fail on the value[key] (value is undefined for some reason in this case).

Hello @rafael-org! Are you running the latest version of the OpenAPI Enforcer and seeing this bug? I just created and ran the following tests without any problems, so if you're on the latest version of the enforcer then I'll need some more help recreating the scenario so I can properly test and fix it.
Here is the test I ran:
const def = {
    openapi: '3.0.0',
    info: { title: '', version: '' },
    paths: {},
    components: {
        schemas: {
            'content.text': {
                type: 'object',
                properties: {
                    type: {
                        type: 'string'
                    },
                    content: {
                        type: 'string'
                    }
                }
            },
            'content.file': {
                type: 'object',
                properties: {
                    type: {
                        type: 'string'
                    },
                    content: {
                        type: 'string',
                        format: 'byte'
                    }
                }
            },
            content: {
                oneOf: [
                    { $ref: '#/components/schemas/content.text' },
                    { $ref: '#/components/schemas/content.file' }
                ],
                discriminator: {
                    propertyName: 'type',
                    mapping: {
                        text: '#/components/schemas/content.text',
                        file: '#/components/schemas/content.file'
                    }
                }
            }
        }
    }
}

it('should validate correctly with valid discriminator property name', async () => {
    const openapi = await Enforcer(def, { hideWarnings: true })
    const err = openapi.components.schemas.content.validate({
        type: 'text',
        content: 'hello'
    })
    expect(err).to.equal(undefined)
})

it('should produce a valid exception with invalid discriminator property name', async () => {
    const openapi = await Enforcer(def, { hideWarnings: true })
    const err = openapi.components.schemas.content.validate({
        type: 'audio',
        content: 'hello'
    })
    expect(err).to.match(/Discriminator property "type" as "audio" did not map to a schema/)
})

I tried many versions. On the actual API we were using 1.10.0 (I think because of this), I have been trying to update to 1.12.5 (on the 1.13.1 I stumbled on the https://github.com/byu-oit/openapi-enforcer/issues/109, thanks for the fix by the way, it worked).
This is the specification I am trying to test openapi.yaml.txt. I get this error on a test with the following payload on /v2/channels/whatsapp/messages:
      {
        from: 'SENDER',
        to: 'RECIPIENT',
        contents: [
          {
            type: 'attachment',
          },
        ],
      }

I gonna try to test it using you code to see if it also happens.

We use { fullResult: true }, I think that must be related to the issue.
On your code when I use it both tests fails because no .components is undefined.

Are you saying that if I change the tests to use the fullResult option that you're seeing that cause test failures?
Here is my update (minus the def value which I've left unchanged), but I'm not seeing any test failure:
it('should validate correctly with valid discriminator property name', async () => {
    const [ openapi, error ] = await Enforcer(def, { fullResult: true })
    expect(error).to.equal(undefined)

    const err = openapi.components.schemas.content.validate({
        type: 'text',
        content: 'hello'
    })
    expect(err).to.equal(undefined)
})

it('should produce a valid exception with invalid discriminator property name', async () => {
    const [ openapi, error ] = await Enforcer(def, { fullResult: true })
    expect(error).to.equal(undefined)

    const err = openapi.components.schemas.content.validate({
        type: 'audio',
        content: 'hello'
    })
    expect(err).to.match(/Discriminator property "type" as "audio" did not map to a schema/)
})

Indeed I was not destructuring it. I am going to test with our spec to see if I can pinpoint the exactly issue I am having.

Okay, two things I noticed testing:

Just by creating a simple specification I was unable to replicate the issue
Validating using the schema the exception do not occur: it only happens doing request validations
Also, it only happens when the object have properties that do not match any schema.
Testing with production: true and production: false produced a tiny bit different results

Debugging I noticed that when the error occurs, the value variable that suppose to be { from: 'SENDER', to: 'RECEIVER', contents: [ [Object] ] } was { from: 'SENDER', to: 'RECEIVER', contents: [ undefined ] } (and with production: true it was { from: 'SENDER', to: 'RECEIVER', contents: [ ] }).

So, for some reason the sequence of events to get a request validate against our spec was resulting in the "original" (not the actual original) contents array being changed.
Digging a little deeper I found it seemed to be related to the deserialization of the body

But now I feel like I am chasing around my tail. But I did found that the array gets changed somewhere in the call of the schema.deserialize on https://github.com/byu-oit/openapi-enforcer/blob/master/src/enforcers/Operation.js#L651 (the object is okay before the call and not okay afterwards). Because of this, later it fails to generate the proper error message on the following stack:
  https://github.com/byu-oit/openapi-enforcer/issues/108
    Zenvia spec
      schema message.whatsapp
        ✓ should validate correctly (611ms)
        ✓ should produce a valid exception with invalid schema (377ms)
      post on messages
        ✓ should validate correctly (419ms)
        ✓ should produce a valid exception with invalid schema (text property) (383ms)
        1) should produce a valid exception with invalid schema (url property)

  4 passing (2s)
  1 failing

  1) https://github.com/byu-oit/openapi-enforcer/issues/108
       Zenvia spec
         post on messages
           should produce a valid exception with invalid schema (url property):
     TypeError: Cannot read property 'type' of undefined
      at runValidate (node_modules/openapi-enforcer/src/schema/validate.js:82:86)
      at value.forEach (node_modules/openapi-enforcer/src/schema/validate.js:136:21)
      at Array.forEach (<anonymous>)
      at runValidate (node_modules/openapi-enforcer/src/schema/validate.js:135:23)
      at keys.forEach.key (node_modules/openapi-enforcer/src/schema/validate.js:168:21)
      at Array.forEach (<anonymous>)
      at runValidate (node_modules/openapi-enforcer/src/schema/validate.js:160:18)
      at schema.allOf.forEach (node_modules/openapi-enforcer/src/schema/validate.js:48:13)
      at Array.forEach (<anonymous>)
      at runValidate (node_modules/openapi-enforcer/src/schema/validate.js:47:22)
      at Schema.validate (node_modules/openapi-enforcer/src/enforcers/Schema.js:215:9)
      at deserializeAndValidate (node_modules/openapi-enforcer/src/enforcers/Operation.js:652:42)
      at Operation.request (node_modules/openapi-enforcer/src/enforcers/Operation.js:294:33)
      at OpenApi.request (node_modules/openapi-enforcer/src/enforcers/OpenApi.js:146:38)
      at Context.it (test/routes/openapi-enforcer-issue-108.spec.ts:111:33)

I am starting to guess that it might be because we also are using allOf, both on root element as on the content array.
Here is the test I adapted from yours using our spec/def (it is in a yaml file). Only the last (fifth) test fails.
I will later try to chase it a bit more.
import * as Enforcer from 'openapi-enforcer';
import { expect } from 'chai';
import * as yaml from 'js-yaml';
import * as fs from 'fs';
import * as path from 'path';

describe.only('https://github.com/byu-oit/openapi-enforcer/issues/108', () => {

  describe('Zenvia spec', () => {

    const def = yaml.safeLoad(
      fs.readFileSync(path.join('config', 'openapi.yaml'), 'utf-8'),
    );

    describe('schema message.whatsapp', () => {

      it('should validate correctly', async () => {
        const [openapi, error] = await Enforcer(def, { fullResult: true, componentOptions: {} });
        expect(error).to.equal(undefined);

        const err = openapi.components.schemas['message.whatsapp'].validate({
          from: 'SENDER',
          to: 'RECEIVER',
          contents: [{
            type: 'text',
            text: 'hello',
          }],
        });

        expect(err).to.equal(undefined);
      });

      it('should produce a valid exception with invalid schema', async () => {
        const [openapi, error] = await Enforcer(def, { fullResult: true, componentOptions: {} });
        expect(error).to.equal(undefined);

        const err = openapi.components.schemas['message.whatsapp'].validate({
          from: 'SENDER',
          to: 'RECEIVER',
          contents: [{
            type: 'audio',
            content: 'hello',
          }],
        }, { readWriteMode: 'write' });

        expect(err).to.match(/Discriminator property "type" as "audio" did not map to a schema/);
      });

    });

    describe('post on messages', () => {

      it('should validate correctly', async () => {
        const [openapi, error] = await Enforcer(def, { fullResult: true, toString: true });
        expect(error).to.equal(undefined);

        const [, err] = openapi.request({
          path: '/channels/whatsapp/messages',
          method: 'POST',
          query: {
          },
          headers: {
            'content-type': 'application/json',
            'x-api-token': 'some-api-token',
          },
          body: {
            from: 'SENDER',
            to: 'RECEIVER',
            contents: [{
              type: 'text',
              text: 'hello',
            }],
          },
        }, { allowOtherQueryParameters: [] });

        expect(err).to.equal(undefined);
      });

      it('should produce a valid exception with invalid schema (text property)', async () => {
        const [openapi, error] = await Enforcer(def, { fullResult: true, toString: true, componentOptions: { production: false } });
        expect(error).to.equal(undefined);

        const [, err] = openapi.request({
          path: '/channels/whatsapp/messages',
          method: 'POST',
          query: {
          },
          headers: {
            'content-type': 'application/json',
            'x-api-token': 'some-api-token',
          },
          body: {
            from: 'SENDER',
            to: 'RECEIVER',
            contents: [{
              type: 'audio',
              text: 'hello',
            }],
          },
        }, { allowOtherQueryParameters: [] });

        expect(err.toString()).to.match(/Discriminator property "type" as "audio" did not map to a schema/);

      });

      it('should produce a valid exception with invalid schema (url property)', async () => {
        const [openapi, error] = await Enforcer(def, { fullResult: true, toString: true, componentOptions: { production: false } });
        expect(error).to.equal(undefined);

        const [, err] = openapi.request({
          path: '/channels/whatsapp/messages',
          method: 'POST',
          query: {
          },
          headers: {
            'content-type': 'application/json',
            'x-api-token': 'some-api-token',
          },
          body: {
            from: 'SENDER',
            to: 'RECEIVER',
            contents: [{
              type: 'audio',
              url: 'hello',
            }],
          },
        }, { allowOtherQueryParameters: [] });

        expect(err.toString()).to.match(/Discriminator property "type" as "audio" did not map to a schema/);

      });

    });

  });

});

But, even though I did not find the source yet, perhaps you can with this information.

Thank you for all the research and for providing a working example of the bug. As I dug into this I found a flaw in the deserialize logic when it comes to discriminators. I also decided to look at related functions such as serialize, populate, and random and found similar logic gaps. Ironically the validate was the only function that did not have the bug and that's why my initial posts on this thread did not show the problem.
I've published a fix for this to NPM as version 1.13.3. Thank you again for the help.


Setting a Default Request Timeout for REST API Calls

Testing FireFly DX in an env with a bad network, I noticed DX would "hang" for roughly 2m10s on each req attempt until ETIMEDOUT was thrown:
2021-12-09T18:41:37.758Z [INFO ]: FireFly Data Exchange running on http://<IP_ADDRESS>:5000 (API) and https://<IP_ADDRESS>:5001 (P2P) - log level "DEBUG" app.ts
2021-12-09T18:42:06.511Z [INFO ]: New WebSocket client connected (client count: 1) app.ts
2021-12-09T18:42:06.511Z [INFO ]: New WebSocket delegate assigned app.ts
2021-12-09T18:44:36.353Z [DEBUG]: post https://firefly-dx.example.com/api/v1/messages utils.ts
2021-12-09T18:46:46.263Z [ERROR]: post https://firefly-dx.example.com/api/v1/messages attempt 0 [undefined] Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1159:16) utils.ts
2021-12-09T18:46:46.765Z [DEBUG]: post https://firefly-dx.example.com/api/v1/messages utils.ts
2021-12-09T18:48:57.334Z [ERROR]: post https://firefly-dx.example.com/api/v1/messages attempt 1 [undefined] Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1159:16) utils.ts
2021-12-09T18:48:57.836Z [DEBUG]: post https://firefly-dx.example.com/api/v1/messages utils.ts
2021-12-09T18:51:08.406Z [ERROR]: post https://firefly-dx.example.com/api/v1/messages attempt 2 [undefined] Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1159:16) utils.ts
2021-12-09T18:51:08.907Z [DEBUG]: post https://firefly-dx.example.com/api/v1/messages utils.ts
2021-12-09T18:53:19.478Z [ERROR]: post https://firefly-dx.example.com/api/v1/messages attempt 3 [undefined] Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1159:16) utils.ts
2021-12-09T18:53:19.979Z [DEBUG]: post https://firefly-dx.example.com/api/v1/messages utils.ts
2021-12-09T18:55:30.550Z [ERROR]: post https://firefly-dx.example.com/api/v1/messages attempt 4 [undefined] Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1159:16) utils.ts
2021-12-09T18:55:31.051Z [INFO ]: Event emitted message-failed/2962a5f9-d6b6-4d19-9746-2dfedc054d1e app.ts
2021-12-09T18:55:31.052Z [ERROR]: Failed to deliver message Error: connect ETIMEDOUT <IP_ADDRESS>:443 handlers/messages.ts

According to https://github.com/axios/axios/issues/1739 and https://axios-http.com/docs/req_config, setting this should make it so these reqs fail much more quickly.

1 second does seem pretty aggressive. Is there a reason this particular value was chosen?

@nguyer none really short of I expect DX's themselves to be quick w/ these responses so the real latency they experience should only be due to geography and load balancers / proxies in-between.
I'd be alright something more like 2s - 10s if need be, just don't think it should be much longer than 10s.

Agree with the observation and the change that followed bumping the timeout from 1 to 10 seconds. Note that these calls are used not only for sending messages, but also for transferring files. On slow connections large size files could take several seconds.

That's a great idea, we could make the code adjust the timeout dynamically depending on the size of the payload to be transferred. But in principle, using 5 seconds as set in this PR I think is pretty safe for now. Unless someone wants to transfer a file that is over a hundred MB, we should be good.

This worked as expected:
2021-12-12T23:36:27.521Z [ERROR]: post https://firefly-dx.example.com/api/v1/messages attempt 4 [undefined] Error: timeout of 5000ms exceeded
    at createError (/firefly-dataexchange-https/node_modules/axios/lib/core/createError.js:16:15)
    at RedirectableRequest.handleRequestTimeout (/firefly-dataexchange-https/node_modules/axios/lib/adapters/http.js:328:16)
    at RedirectableRequest.emit (events.js:400:28)
    at Timeout.<anonymous> (/firefly-dataexchange-https/node_modules/follow-redirects/index.js:164:12)
    at listOnTimeout (internal/timers.js:557:17)
    at processTimers (internal/timers.js:500:7) utils.ts


debianutils: init at 4.8.1

Motivation for this change
I needed run-parts
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)

[X] run-parts
[ ] add-shell
[ ] installkernel
[ ] ischroot
[ ] remove-shell
[ ] savelog
[ ] tempfile
[ ] which

[X] Fits CONTRIBUTING.md.

The build failure seems to me to be unrelated to the introduced changes.
Please confirm

Thanks!


Support Swift 1.2

Alternative take on #24. I went for replacing the Int? in testTryTFailure with String? which doesn't produce that odd integer coercion. No hard feelings if you'd rather make the changes there. :ok_hand:

Nice one.


[Bug]: Not properly working with VersionStrategy::DIFF

What happened?
If you use VersionStrategy::DIFF (default) only changed values are stored, so the revision view breaks when you update a filed that wasn't saved in the version before
How to reproduce the bug

Use VersionStrategy::DIFF as strategy
Create a new Model with title, content fields
Update the title => only new title will be saved
Update the content => only new content will be saved
Click "Revisions" and page breaks since content is not present on the previous version

Package Version
0.0.6
PHP Version
8.2
Laravel Version
11
Which operating systems does with happen with?
Linux
Notes
This isn't directly related to this plugin i guess but to the Diff class you wrote for the upstream package...
From my understanding: In DIFF Mode you can't directly compare one version to the previous one. You'll have to either load the first version, apply every diff and compare the result to the current one OR go back till you have all keys which where changed in the current version and show them from there

https://github.com/overtrue/laravel-versionable/issues/56

@mutschler Have you tried to use VersionStrategy::SNAPSHOT, thats what we are going to keep in future.

yeah i've tried that and it works. However i didn't plan to keep full snapshots on the data but only save the changes. Full Snapshots provide too much overhead. Since i've already red upstream that there are plans for dropping DIFF strategy i've came up with something else...
However i've spent some time looking into it before and it's actually relatively easy to fix. Actually revertWithoutSaving already does most of the things needed by looping through all changes up to the current one, so you'll get the keys you need to have when comparing. I'm gonna check if is still got my solution lying around somewhere if you're interested ;)

I will check.
@overtrue maybe you should read this.

@mutschler I am open for a pr or any code block that helps.

i've pushed the code which seemed to work for me here https://github.com/mutschler/laravel-versionable/compare/5.x...patch-2#diff-bc02aa2ebc8787a5e9d2158b017a5ad142a2caff5e24d98e540b7a6442e94fdd not really sure if the if/else part for loading the $newContents is really needed but i did it that way for a reason i can't really rememer right now.
As mentioned before it's more or less the same thing revertWithoutSaving does: Load initial data and apply each pach up to the latest previous version to that data, then remove all unneeded keys from the array

@mutschler I think its fixed and working for you? I am closing for now, feel free to open if you still have issues.


Remove some console warnings

Upgrade frontend-components
Warning for not using BreadcrumbItem inside a Breadcrumb

Codecov Report

Merging #186 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   88.94%   88.95%
=======================================
  Files         114      114
  Lines        2389     2391    +2
  Branches      429      429
=======================================
+ Hits         2125     2127    +2
  Misses        262      262
  Partials        2        2

Impacted Files
Coverage Δ

src/pages/PolicyDetail/Skeleton.tsx
100.00% <100.00%> (ø)


Fix minor typo in Pin.remove examples.

Just a quick PR for a typo I found :)
Love the project btw - very clean code!

Thanks!


Link doesn't work in react 18 with StrictMode

Example in Usage doesn't work when you wrap App component to a React StrictMode

@bakugod Can you reproduce the bug in stackblitz/codesandbox on some bundler (for ex. vite)?


More ibm -> linuxforhealth renaming

Is your feature request related to a problem? Please describe.
There's a few more code-related locations that we should migrate before our 5.0

the 'ibm' directories under fhir-examples (json and xml)
ibm-* prefixes for internal search parameters
ibm.com URIs in extension URLs

Describe the solution you'd like
No more references to IBM in code artifacts
Describe alternatives you've considered
Acceptance Criteria
References to 'ibm' from the codebase are reduced to a reasonable set.  "reasonable" here is up for interpretation, but should not include ibm.com urls in data
Additional context

QA:

There are no ibm directories under fhir-examples
There are no unnecessary instances of the prefix ibm- in the codebase
There is one unnecessary instance of ibm.com in the codebase.

However, for item (3) in SearchExtensionsTest:
                .extension(Extension.builder()
                        .url(EXTENSION_BASE_URL + "favorite-uri")
                        .value(uri("http://www.ibm.com"))
                        .build())

as this is just a unit test, there is no leak of this value in the product runtime. The test can be cleaned up at a convenient time in the future.


Allow not specify image.registry in the values of the helm chart

The changes in this PR aim to fix the problem described in this issue
https://github.com/provectus/kafka-ui/issues/2367

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[x] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@RustamGimadiev @azatsafin PTAL

@joseacl thanks for another contribution :)


Kubernetes v1.7.9 master and worker nodes flapping

Is this an ISSUE or FEATURE REQUEST? (choose one): ISSUE

What version of acs-engine?:
master:
commit 9ca92cbe31324dbd2c02093ae97536613b0c1d00 (HEAD -> master)
Author: Alexander Gabert<EMAIL_ADDRESS>Date:   Tue Nov 21 17:51:31 2017 +0100

    typo intersted (#1808)

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)

Kubernetes 1.7.9
Azure region: Central US

What happened:
I'm seeing both masters and worker nodes regularly flap between Ready/NotReady on new v1.7.9 clusters with no activity. The following is output from new v1.7.9 and v1.8.2 clusters over ~25m:

controller-manager logs don't reveal much, other than confirming that nodes are transitioning to/from a NotReady state.
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:17.734930       1 controller_utils.go:285] Recording status change NodeNotReady event message for node k8s-master-26603479-0
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:17.735064       1 controller_utils.go:203] Update ready status of pods on node [k8s-master-26603479-0]
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:17.735402       1 event.go:218] Event(v1.ObjectReference{Kind:"Node", Namespace:"", Name:"k8s-master-26603479-0", UID:"da7ecb87-cfd3-11e7-b69f-000d3a9476c0", APIVersion:"", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'NodeNotReady' Node k8s-master-26603479-0 status is now: NodeNotReady
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:17.874493       1 controller_utils.go:220] Updating ready status of pod kube-addon-manager-k8s-master-26603479-0 to false
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:18.086843       1 controller_utils.go:220] Updating ready status of pod kube-apiserver-k8s-master-26603479-0 to false
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:18.238899       1 controller_utils.go:220] Updating ready status of pod kube-controller-manager-k8s-master-26603479-0 to false
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:18.453973       1 controller_utils.go:220] Updating ready status of pod kube-proxy-j24f7 to false
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:46:18.634162       1 controller_utils.go:220] Updating ready status of pod kube-scheduler-k8s-master-26603479-0 to false
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:49:09.490344       1 controller_utils.go:285] Recording status change NodeNotReady event message for node k8s-agent-26603479-2
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:49:09.490371       1 controller_utils.go:203] Update ready status of pods on node [k8s-agent-26603479-2]
kube-controller-manager-k8s-master-26603479-2 kube-controller-manager I1122 22:49:09.490496       1 event.go:218] Event(v1.ObjectReference{Kind:"Node", Namespace:"", Name:"k8s-agent-26603479-2", UID:"c67e02a4-cfd3-11e7-b87f-000d3a947f4f", APIVersion:"", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'NodeNotReady' Node k8s-agent-26603479-2 status is now: NodeNotReady

When a node enters NotReady, it's status becomes unknown, indicating that the kubelet temporarily stopped or couldn't connected to the apiserver:
Name:               k8s-agent-26603479-2
Roles:              agent
Labels:             agentpool=agent
                    beta.kubernetes.io/arch=amd64
                    beta.kubernetes.io/instance-type=Standard_D2_v2
                    beta.kubernetes.io/os=linux
                    failure-domain.beta.kubernetes.io/region=centralus
                    failure-domain.beta.kubernetes.io/zone=1
                    kubernetes.azure.com/cluster=trestles-centralus-v179-5a15f7c1
                    kubernetes.io/hostname=k8s-agent-26603479-2
                    kubernetes.io/role=agent
Annotations:        node.alpha.kubernetes.io/ttl=0
                    volumes.kubernetes.io/controller-managed-attach-detach=true
Taints:             <none>
CreationTimestamp:  Wed, 22 Nov 2017 14:23:33 -0800
Conditions:
  Type                 Status    LastHeartbeatTime                 LastTransitionTime                Reason              Message
  ----                 ------    -----------------                 ------------------                ------              -------
  NetworkUnavailable   False     Wed, 22 Nov 2017 14:24:05 -0800   Wed, 22 Nov 2017 14:24:05 -0800   RouteCreated        RouteController created a route
  OutOfDisk            Unknown   Wed, 22 Nov 2017 14:51:17 -0800   Wed, 22 Nov 2017 14:50:40 -0800   NodeStatusUnknown   Kubelet stopped posting node status.
  MemoryPressure       Unknown   Wed, 22 Nov 2017 14:51:17 -0800   Wed, 22 Nov 2017 14:50:40 -0800   NodeStatusUnknown   Kubelet stopped posting node status.
  DiskPressure         Unknown   Wed, 22 Nov 2017 14:51:17 -0800   Wed, 22 Nov 2017 14:50:40 -0800   NodeStatusUnknown   Kubelet stopped posting node status.
  Ready                Unknown   Wed, 22 Nov 2017 14:51:17 -0800   Wed, 22 Nov 2017 14:50:40 -0800   NodeStatusUnknown   Kubelet stopped posting node status.

How to reproduce it (as minimally and precisely as possible):

Provision a stock Kubernetes v1.7.9 cluster

@jackfrancis @jchauncey FYI

Sounds like a similar issue like the ones we have/have had on North Europe since a couple of weeks. Or does this always occur, or just sometimes?