[NT-1373] Show Location on DiscoveryPostcardCell for LightsOn Tag

📲 What
Shows the location on DiscoveryPostcardCell when DiscoveryParam's tagId is lightsOn, defaults the editorial collection to use magic sort.
🤔 Why
Previously we were hiding the location when the sort was not distance, but we would like to show the location for all sorts and only hide it when the tagId is something other than lightsOn.
🛠 How
Updated the behaviour in DiscoveryPostcardViewModel and related tests.
✅ Acceptance criteria

[ ] Location is visible on the the updated DiscoveryPostcardCells in the Lights On editorial collection.
[ ] Location is not visible on DiscoveryPostcardCells in other feeds.

Looks good. When I tried to run the project however, I see the updated project cards. I might be bucketed in that experiment so maybe thats why I didn't see the location.

Yeah looks like location has not been added to the new project cards yet.


Null safety for containers

Dart version 2.14.2 on MacOS.
I ran into this today:
The argument type 'Future<Uint8List?>' can't be assigned to the parameter type 'Future<Uint8List>'.
This is because a function was returning Future<Uint8List?>, but assigned to a variable marked Future<Uint8List>.
However, I know that in this particular instance of the function call, the return value will in fact be Future<Uint8List>. But I don't have a way to add a null check ! to tell the compiler that this is okay, since functionCall()! will only assert that the outer Future object is not null, not the inner Uint8List.
It seems to me that there should be a way to add a null check to the inner type. This isn't just limited to futures; really any container will experience this same problem (such as List)
I'm wondering if this is something the dart team would consider adding.

I think you might need to make an extra distinction here: If the future is actually a Future<Uint8List> rather than the statically known Future<Uint8List?>, then you're able to use a cast, and there should not be a problem:
Future<int?> f() => Future<int>.value(42);

Future<int> g() async {
  var fut = f();
  if (fut is Future<int>) return fut;

  // `fut` is a subtype of `Future<int?>` which is not a subtype of `Future<int>`,
  // e.g., it could be a `Future<int?>` or a `Future<Null>`.
  var value = await fut; // Could throw, but let's ignore that.
  if (value != null) {
    return value;
  } else {
     // Failing, do whatever is appropriate.
    throw "Encountered null in g!"
  }
}

So you may have the kind of future that you need (Future<Uint8List>), or you may actually have the nullable-element variant (Future<Uint8List?>), in which case you may still have the right kind of value (Uint8List), and you would then be able to build the required future. Finally, you could have null, which would presumably give rise to some error handling.
The feature you mention wouldn't be possible:

there should be a way to add a null check to the inner type

You can do that today, if it is actually concerned with the type argument of the future (or whatever type you're working on). But I suspect that you're actually looking at the middle scenario where the enclosing container does have the nullable type argument, but the value that you obtain (by awaiting the future, or iterating over the collection object, or whatever it is) turns out to be non-null. But there is no way you can detect that the "inner object" isn't null without running all the code which is there to compute that inner object (e.g., you have to await the future).

I'll close this issue because I don't see anything which is not working as intended. @Fnalsk, please create a new issue if you still see something that you think is not working!


Fix snyk code issue: Path Traversal

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #541
Special notes for your reviewer:
Release note:
none

Local scan result:
% snyk code test --org=openshift-ci-internal

Testing /Users/yussufshaikh/GitHub/ibm-powervs-block-csi-driver ...

✔ Test completed

Organization:      openshift-ci-internal
Test type:         Static code analysis
Project path:      /Users/yussufshaikh/GitHub/ibm-powervs-block-csi-driver

Summary:

✔ Awesome! No issues were found.


Option "only use resource calendars" doesn't work

When launching the app if you select option "only use resource calendars" from the second setup screen, it doesn't let you proceed. It let's you proceed only by choosing your own calendar. Similarly, if you choose your own calendar and then try to access "ALL ROOMS" it lists just your own and if you try to change option "If this option is enabled, non-resource calendars will be shown" from settings, no calendars are shown at all (tried to refresh as well).

Magically it started to work today 👍

@hypn00o Great to hear. We currently are not with due time to give the support to this repo, but if there are some more errors let us know.


1.6.0 for VSCode reintroduced the syntax bug for escape double quote

VS Code version: 1.7.1
C# Extension version: 1.6.0
Steps to reproduce
in a .cs file, if the string as an escape double quote \", Omnisharp will not show proper syntax for the code following it.
Like the code below:
            configContent = rgx.Replace(configContent, $"name{suffix}\"");
            File.WriteAllText(_testConfigFile, configContent);
        }

Note: C# Extension version 1.5.3 doesn't have this bug.
Expected  behavior
the code after \" should still show the proper syntax.
Actual behavior
the code after it shows as string, until the next double quote.

Thanks for taking the time to report this issue!
cc @ivanz

Will fix this and add some tests when I am back from holidays in a week or so 👍

Same issue, another example:

I'll have fixes for this in the near future.

Both of these examples should be working in the next release:

for reference: this bug was reported and fixed before: https://github.com/OmniSharp/omnisharp-vscode/issues/442

The bug regressed. This is fixed properly now and tests are in place to ensure it doesn't return. We've written a completely new TextMate grammar for C# that is much more robust than what shipped previously.


BUG docs haven't been updated to say that Signed-Releases looks for .sigstore bundles.

Describe the bug
#3772 introduced .sigstore to the Signed-Releases check but the documentation doesn't mention it.
Reproduction steps
Steps to reproduce the behavior:

Take a look at https://github.com/ossf/scorecard/blob/90a3708b19883d176d84dc23e3b399b53f1ee1e9/docs/checks.md?plain=1#L594-L597
Then https://github.com/ossf/scorecard/blob/90a3708b19883d176d84dc23e3b399b53f1ee1e9/probes/releasesAreSigned/impl.go#L38

Expected behavior
Documentation matches code
Additional context
Check doesn't seem to work as expected with .sigstore bundles #3913

Are you interested in sending a PR? We have instructions for updating documentation:
https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#updating-docs


Add deprecation notice to README

Deprecate package in favor of create-react-app v2.1

The repository should also be archived.


Parse certificates created through kubectl

https://github.com/rancher/rancher/issues/14921

LGTM


accumulate plotly graph lines when there are multiple repositories

e.g. for the research software directory https://www.research-software.nl/software/research-software-directory, it seems there is little activity because the graph shows only the activity on the landing-page repo, but not the other related repos.
Maybe we could adapt the script such that it accumulates the data for an array of repos? Not sure how that affects how we use the GitHub ID field in de admin interface currently.

I added a key githubids to all elements in collection software as follows:
cd stack
# (pull child repos)
docker-compose up --build
docker-compose exec mongo mongo
> use test
> db.software.update( {}, {'$set': {githubids:[]}}, false, true)

Months without commits should be plotted on yaxes=0, see https://github.com/research-software-directory/frontend/pull/69

This is done as of https://github.com/research-software-directory/tasks-nlesc/commit/4a5321cbca8bd9ab155b4df330bb7675f2a9c4f5


❇ Add Layout Attribute and improved action space

This PR

makes sure, that always a valid Qiskit.QuantumCircuit.layout attribute is set after the compilation (even when it is compiled with non-qiskit compilation passes)
removes unnecessary sabre layout and routing actions (mapping is still in there)
improves the Qiskit O3 optimization action such that it does not synthesize and map automatically any more

@burgholzer Some test and the documentation fails because the pre-trained models do not match the currently used action space any more. I will fix this issue after the integration of BQSKit to only re-train it once.
Maybe it makes sense to merge this (and soon, the BQSKit integration branch) into its own dev branch and re-generate the pre-trained models from that branch. What do you think?


Dark mode text contrast too low

Even in a dimly-lit environment, active text elements lack contrast, making them hard to read.

Any chance of some screen shots of specific examples?

Current

Recommended
Set --text-color to #e6e1dc (same as --navigation-text-color).


LHN - The name of the archived workspace room after merge is "Chat report"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4430652&group_by=cases:section_id&group_id=229067&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Admin: Log in with an expensifail user
Admin: Create a workspace
Admin: Invite two expensifail users (account A and B)
Admin: Write a single message in each of the new members workspace rooms
Log in with Account A and log out
Log in with Account B and log out
Admin: Remove account B from the workspace
Account A: Log into OD and merge with account B
Account A: Log into ND
Account A: Open the archived workspace room

Expected Result:
It should display it's correct name even if I don't open it.
Actual Result:
The name of the archived workspace room after merge is "Chat report". It changes to the correct name after opening it.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/cd5c3afd-de5c-4b70-a2fe-2062325ff178

View all open jobs on GitHub

We think that this bug might be related to the  #collect project.

I disagree, I couldn't recreate when performing these actions reasonably and normally, and given even in this niche situation, if it does self resolve when clicking on the offending report, I'm not worried about this causing mass confusion to end users. Therefore closing.
https://github.com/Expensify/App/assets/9133401/9c2747ba-624d-44fd-b2a4-9625ecef05d6


Microsoft service should not be hardwired to use West coast endpoint

Line 77 in microsoft.py is hardwired to use westus.api.cognitive.microsoft.com, which doesn't work for everyone. This needs to be made configurable.
(Thanks to Matt Cook at Harvard for reporting this.)

This is fixed in commit aea5369.


script don't show correctly items KNUCKLES_MORGANA

Hello,
i found that the script don't show correctly
"KNUCKLES_MORGANA" (.3 .2) (it show only few items from market)
T5_2H_KNUCKLES_MORGANA (not show)
Thanks.

@madvac any chance you can send raw sniffer logs? I might get a better idea at what is going wrong with that

Hello,
well i dont know how to get raw logs (have zero programming experience).  I am now using your "examples".
If you tell me how to get raw logs, i can send it to you.
THX for your time.

@madvac ok, is this problem only happening on one computer or at one in game market? If these aren't helpful I can chat with you on discord to work out ur issue.

hi
is there any chance to write me how to get raw logs ...or is it too
difficult?
i test it in HO, bridgewatch, carleon (so i think it do it on all
markers).
i can try it on anotoher PC (tomorow i try it on linux client)
some times if there only 2 items it dont show any output....
if there is 3 items it show sometime 1, sometime only 2.
But maybe its my side problem.
P.S.: diskcord: I cant speak too much english.
Dne 14.04.2022 17:53, Heinrich Harms napsal:

@madvac [1] ok, is this problem only happening on one computer or at
one in game market? If these aren't helpful I can chat with you on
discord to work out ur issue.
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you were mentioned.Message ID:
@.***>
Links:
[1] https://github.com/madvac
[2]
https://github.com/hrichharms/AlbiPy/issues/6#issuecomment-1099328084
[3]
https://github.com/notifications/unsubscribe-auth/AHMG2TLG3HSOHZHPZ2UQ5FDVFA5PTANCNFSM5TH5HHMQ

Hi,
i have raw packet log.
u can contact me on discord: madvac#5584
i will send u also output from script.


Fix FQDN length issues for private cluster

Private cluster fqdn format is *.UUID.privatelink.<region-name>.azmk8s.io, use first 63 char as container name.

💡 Addition: https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#container-names for Container names must be from 3 through 63 characters long.

@JunSun17 how could we get this merged?

A new release is also required after this PR gets merged.


OpenJDK purge error

In developer.sh the line "apt purge openjdk" produces an error message. Perhaps it needs to be more specific about what mint openjdk package needs to be removed. openjdk-7-jre-headless, maybe? Having some openjdk laying around after the Oracle Java 8 stuff is installed doesn't seem to cause real problems....

Having the openjdk lying around isn't a problem, as you have said. It was being (unseccessfully) removed to reduce the size of the end box. I'll try a more specific 'openjdk-7-jre'.

OK, not a serious problem, it wasn't clear why openjdk was being uninstalled. I typically uninstall it manually and replace it with Oracle's JDK when I prep an image, just to reduce confusion on the part of users, but I wasn't sure if it caused problems with scala or something like that...


[Tracking] Solo5 tasks for Mirage 3.0 release

#Solo5 tasks under consideration for the Mirage 3.0 release, with (rough priority) and @mentions for those currently working on a task:

[x] (1) CI improvements and end to end testing (@mato).

mirage/mirage-skeleton Travis CI should build Solo5 targets. (done)
end to end testing and improved standalone tests: #112, #113, #114, #115, #120
Related issues: mirage/mirage#584.

[x] (1) Stabilise virtio drivers (@ricarkol).

Iterative cleanups so that we always have something working.
Aim to move implementation to v1.0 of the spec.
Related issues: #78.

[x] (1) Audit ukvm interfaces.

ukvm hypercall/device interfaces need assertions about invariants, eg. for out of range pointers or buffer sizes passed in by the guest.
Related issues: #99, #117

[x] (1) Audit ukvm ELF loader.

There are multiple issues with the ukvm ELF loader. See #126.

[x] (2) Clean up interrupt and trap handlers.

Switch to a single .S source for interrupt and trap handlers, use gas macros where needed rather than bash-script driven code generation.
Add internal interfaces and infrastructure to register/unregister interrupt handlers.
Improve debugging value of trap handlers (backtraces and other info?).
Related issues: #32.

[x] (2) FreeBSD support (@mato, @hannesm).

Priority bumped by the need to test virtio on Byhve.
See #61, #102 for details.

[x] (2) ukvm host feature detection.

Friendly error message if ukvm doesn't support the host CPU or KVM interface.
Related issues: #9.

[ ] (3) Improved memory protection.

Guard pages, verify W^X is used as appropriate, unmapped zero page.

[x] (4) Integrated mkimage tool.

#110

@hannesm Should we consider supporting bhyve for Mirage 3.0? Depends on how much time you have from now until the (end-September) planned release.

@mato appreciated.  still needs someone to do the tedious cleanups of include files... I'll focus on opam signing in september, and can't promise much time on bhyve

The "clean up interrupt and trap handlers" item is now complete. I'm not going to deal with backtraces, stack unwinding on x86_64 without frame pointers is a very deep rabbit hole best left to a debugger.

With the last batch of changes (#108, #109) virtio now appears stable, hurrah. I've ceremonially updated the checkmark.

@mato we probably should uncheck "Audit ukvm interfaces" until we have something satisfying for https://github.com/Solo5/solo5/issues/117 so that it doesn't get forgotten

@djwillia Ok, unchecked, checked the other two items now that we have automated tests and ukvm messages have been cleaned up

Hi folks, I'm also tracking the priority 1 items from here over on https://github.com/mirage/mirage/issues/592.  Is Audit ukvm interfaces the only thing left to check off?

@amirmc Yes, that's correct, and it depends on #117 which I hope to fix today or tomorrow.

I've added a P1 item to audit the ukvm ELF loader, since while reviewing #123 I ran into several problems with it. See #126 for the issue.

Since everything is ticked off, including the ELF loader fixes, can this now be closed? :)

OPAM releases of the individual subcomponents still need to be tagged and CHANGELOGs written. I'm waiting for @yomimono to give me a go-ahead on this, presumably after the OPAM metadata changes in https://github.com/mirage/mirage-dev are ready for a "beta1" release of Mirage 3.

Oh, and #146 needs merging which I'll do ASAP after I have some ACKs on it.

Solo5 packages are now released and OPAM metadata is in mirage/mirageos-3-beta so I'm closing this as done.


chore(ci): migrate actions/upload-artifact and actions/download-artifact to v4

What this PR does / why we need it:
Part of #5357
Relevant guide: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Codecov complains about the received report: https://app.codecov.io/github/Kong/kubernetes-ingress-controller/commit/0f82d8a5915eac822107d7257132914f3c0feeb7

Codecov report has been processed and it works now. 🎉


"cvxpy.error.SolverError: The solver XPRESS is not installed."

Describe the bug
I installed XPRESS  for Windows 10, with their community license.
Still, when I try to solve a problem with solver=cvxpy.XPRESS, I get this error:
cvxpy.error.SolverError: The solver XPRESS is not installed
To Reproduce
problem = cvxpy.Problem(cvxpy.Maximize(1), constraints = [])
problem.solve(solver=cvxpy.XPRESS)

Expected behavior
Problem should be solved.
Output
cvxpy.error.SolverError: The solver XPRESS is not installed
Version

OS: Windows 10
CVXPY Version: cvxpy-base 1.2.1

Hi @erelsgl. Can you please provide more information? What happens when you try import xpress?

Ah, I see my mistake - I installed XPRESS on my Windows system, but did not pip install xpress.


[FEAT]: LiteLLM Embedding Provider support

What would you like to see?
Add support for LiteLLM as an embedding provider if available and possible to be done.

Thanks, @timothycarambat and @shatfield4.
As discussed earlier here, we've added new models (Ollama) to LiteLLM. We would like to request modifications to the anything-llm UI to allow us to add these new models for embedding documents.
Specifically, we need changes in Settings > Embedding Provider > Embedding Provider to enable the selection of a custom embedding provider from LiteLLM.
Thank you!


Needs in your little help with file versions.

Hello gentlemens,
A lot of thanks for your work and supporting the tool! I also find your product very helpful!
I just have one small request.
I have noticed that several *.exe files (listed below) have version <IP_ADDRESS> on the "Details" tab in the file's properties.
redis-benchmark.exe
redis-check-aof.exe
redis-check-rdb.exe
redis-cli.exe
redis-server.exe
Is it correct behaviour?
if not...  would you kindly change the file versions for 7.0.7 and 7.0.8 releases to avoid misunderstandings in the future.

Thanks,i will change it next Sunday


⚠ BeyondHD has degraded performance

In d8b1614, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 502
Response time: 15577 ms

Resolved: BeyondHD performance has improved in ffbea81 after 25 minutes.


Image list 2.0 & doc improvements

Fixes #1256
(plus some documentation improvements)

^ shows that code was highlighted better earlier but now its all black. Expected?

Sorry a bit malfunctional css

@prateekbh This is now ready, dark docs improvements (e.g. the site now saves your settings), test improvements, image list upgrade and a few smaller things

Just a request I can really use smaller PR reviews though neutral_face

Yes I try but when you fix one thing, you get the next bug/issue and so on and shortly you have a bunch of fixes
This time I just improved the image list page and then fixed all the bugs caused by it

Right now there only a few components left and then some structural thing that we have to decide if we want to tackle them in 2.0

And I guess all the greenkeeper branches could be delete, because there are like 50+ useless branches


'varint' and 'decimal' scylla types does`t work properly as a maps key.

gocql data parsing from scylla defines 'varint' scylla type as 'big.Int' go type.
big.Int not compareble.
Not compareble types can`t be as a maps key.
gocql got out of the situation by create pointer on big.Int.
This led to the fact that a maps key - pointer, not a  big.Int.
With 'decimal' same situation because gocql defines 'decimal' as inf.Dec go type, which contains big.Int.

@dkropachev how easy to fix?

@dkropachev how easy to fix?

This fix is too complicated, i won't merge it.
I am working on another one, that is less crazy, but still on the line.


Include stack trace when modules fail to load

Debugging failed module loads is difficult without a stack trace, this change includes the stack trace when the module fails to load.

@KevinDyer @nanpx I like this change!


feat(GlobalHeader): Update enterprise home text

Overview

Changes 'My Percipio' to 'Home' in enterprise header variant

PR Checklist

[ ] Related to designs:
[x] Related to JIRA ticket: WEB-2304
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change
[x] This PR includes testing instructions tests for the code change
[x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.
PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

🚀 Styleguide deploy preview ready!https://64276f11a6d9130f65ddb3a0--gamut-preview.netlify.appDeploy Logs


Set up SQLite db

An SQLite database is needed, full details will be provided soon.

Recipe tables
Tables needed for recipe storage:
Table of ingredients

Ingredient ID
Ingredient name
Ingredient description

Table for quantities of ingredients

Ingredient ID
Quantity
Measurement size (teaspoon)

Table for recipe ingredient quantity

Ingredient ID
Recipe ID

Table of recipes

Recipe ID
Recipe name
Recipe description
Recipe difficulty rating
Preparation time - int in number of minutes
Cook time - int in number of minutes
Recipe serving - int (example 4)
Recipe source - varchar url size

Recipe notes table

Recipe ID
Note

Recipe methodology table

Recipe ID
Step number
Method element

User management
For user management we will need the following tables with the following columns:
Users

User ID
Username
First name
Last name

PasswordHashes

User ID (FK) - integer
Password hash - SHA-256 varchar

Favourites table

User ID
Recipe ID

Database set up with basic requirements, later requirements will be delt with in separate tickets


discussion: canvas?

Hi sindresorhus,
Sorry for opening an issue, but a friend and I were discussing whether or not it'd be possible to render/use HTML5 Canvas elements as wallpapers.
Since you've dug around cross-platform wallpaper APIs & the discussion is mostly on-topic, I figure I'd ask.
Thanks!

Yes, you could use node-canvas to render an image and then set it with wallpaper. If you're looking for something interactive, you'll have to do it in a running application. On OS X you can programmatically set a window as background, and you can put whatever in that window, including a webview with Canvas. You can actually do exactly this with Electron today, see https://github.com/electron/electron/pull/3509.

Awesome! Thanks for the quick tip 😺


Unexpected Resultant Image

Good day,
I had tried to run a test on the mentioned datasets based on the commands suggested in the repo, but I could not understand the output.

Is there anything that I am missing or I did something wrong?
Thanks for the help and time.

Hi @IcedDoggie,
Did you download the trained model?
What was the exact command you used?
A proper example would be like:
python main.py --precision half --save_dir REDS_L1 --demo true --demo_input_dir /home/seungjun/Research/dataset/REDS/train/train_blur/000 --demo_output_dir temp

Here, the REDS_L1 directory contains the trained model in the README.
Maybe the --save_dir was not set to the trained directory. I get a similar result when not using a randomly initialized model. I will clarify the demo command.

It works now! Thanks a lot :)
The error i made is that I didn not specify REDS_L1.


change messaging for access in the library

Ref #4043
It's got some questions.

Closed as the test has been captured on the issue.


More options in LabelStyle?

Thanks for a great library.
I'm trying to make a tool tip for features on the map by adding an additional layer with a label. It is working well so far. To make it look like a normal tool tip I would need sharp corners and a border. This isn't supported by the current LabelStyle but would be quite easy to implement in the LabelRenderer.
Would there be an interest in a merge request where I add Rounding, BorderThickness and BorderColor to the LabelStyle and LabelRenderer.
If there's an interest I would create merge requests both for develop/3.0.0 and master.

That would definitely be interesting and something I had hoped happened earlier.
If you do this then please include your changes into the label rendering test.
Something to look into is to RichTextKit. It was introduced into Mapsui by charlenni. It is used for callouts/popups. You can see it in the info sample and in the Xamarin.Forms specific samples. The rendering somehow looks nicer. And in the current implementation has support for some of the features you mention. I think all the text rendering should use it.
Unfortunately there is currently a problem with callouts on iOS. I don't know if this is a general problem with RichTextKit. If this is the case perhaps we need to stick to the SkiaSharp way of rendering text. See https://github.com/Mapsui/Mapsui/issues/1216#issuecomment-963842736.
You could also ignore migration to RichTextKit for now and just improve what we have currently.

I think I'll start with just the small changes, that should be a fairly small change.
If the bug on iOS isn't resolved it is probably better to create a RichTextLabel or something similar so that existing applications don't break.

You mean a RichTextLabelStyle next to the existing LabelStyle, so that will have two options, a pretty one and a 'save' one that will work on all platforms? That is probably the best way to go.

You mean a RichTextLabelStyle next to the existing LabelStyle, so that will have two options, a pretty one and a 'save' one that will work on all platforms? That is probably the best way to go.

Exactly

That means each time we have a problem with a part in a version, we make a new one to circumvent this problem?
I would say, that the right way to go is to use RichTextKit everywhere. It is very difficult to creat a correct LabelStyle. Think about all the languages out there with different fonts. And keep in mind, that Skia and SkiaSharp ended to support DrawText.

I created merge requests for the 3.x branch and for master. See #1368 and #1369.

That means each time we have a problem with a part in a version, we make a new one to circumvent this problem?
I would say, that the right way to go is to use RichTextKit everywhere. It is very difficult to creat a correct LabelStyle. Think about all the languages out there with different fonts. And keep in mind, that Skia and SkiaSharp ended to support DrawText.

Since the rendering is different when using rich text than the current implementation I would consider changing the rendering a breaking change. Any changes to 3.x would then be safest to put in a new Style. For next major version it is not as clear cut. Do we expect the upstream bug to be fixed before we want to release 4.x? If that's the case the LabelStyle can change. If there's a need for a release before that point, then it is probably safer to create a new Style and Renderer.
I wasn't aware that DrawText was deprecated, that is a good reason to change the existing renderer.

That means each time we have a problem with a part in a version, we make a new one to circumvent this problem?

I would say, that the right way to go is to use RichTextKit everywhere. It is very difficult to create a correct LabelStyle. Think about all the languages out there with different fonts. And keep in mind, that Skia and SkiaSharp ended to support DrawText.

I am also in favor of RichTextKit everywhere, but if the current version has a problem with RichTextKit this is not the right time to make that change. Introducing a new RichTextKitLabelStyle would be a step in the migration process. When RichTextKit is stable all DrawText can be removed. This is how I have done many migrations in the past.
But actually, this morning I had a closer look at CalloutStyle and I think this could function in the role of RichTexKitSLabeltyle, perhaps with a few modifications. So we do not need to introduce RichTextKitSLabeltyle.
Also, I am still not sure if there is a problem with RichTextKit.


Provide a way to construct arbitrary json objects

The only way to produce json objects is by casting from objects and named tuples and converting a string from to_json.
I think we want something like
function json_object_pack(els: array<tuple<str, json>>) -> json (though it could also be SET OF instead?)
Annoyingly, postgres's json construction functions aren't great from an "arbitrary input" perspective, but it should still be doable?

json_object_agg for consistency with array_agg, and have a set of input.

json_object_pack is better for consistency with our own JSON API: https://www.edgedb.com/docs/stdlib/json#function::std::json_object_unpack

Hmm. Not really.  We have array_agg and array_unpack

I produced this mess of an implementation:
create or replace function json_merge(objs jsonb[], lo int8, hi int8)
returns jsonb
as $function$
select (
    case when (lo + 1 = hi)
    then objs[lo]
    else json_merge(objs, lo, (lo+hi)/2) || json_merge(objs, (lo+hi)/2, hi)
    end
)
$function$
language sql;

create or replace function json_object_pack(
    els edgedbpub."79d8ede8-30f1-a805-fbc3-503ece3c9205_t"[])
returns jsonb
as $function$
select json_merge(body.args, 1, array_length(body.args, 1) + 1)
from (
    select array_agg(jsonb_build_object(x."0", x."1")) as args
    from unnest(els) as x
) as body
$function$
language sql;

... before I realized that jsonb_object_agg existed, but was listed on the aggregates doc page instead of the json one.


[SPARK-41395][SQL] InterpretedMutableProjection should use setDecimal to set null values for decimals in an unsafe row

What changes were proposed in this pull request?
Change InterpretedMutableProjection to use setDecimal rather than setNullAt to set null values for decimals in unsafe rows.
Why are the changes needed?
The following returns the wrong answer:
set spark.sql.codegen.wholeStage=false;
set spark.sql.codegen.factoryMode=NO_CODEGEN;

select max(col1), max(col2) from values
(cast(null  as decimal(27,2)), cast(null   as decimal(27,2))),
(cast(77.77 as decimal(27,2)), cast(245.00 as decimal(27,2)))
as data(col1, col2);

+---------+---------+
|max(col1)|max(col2)|
+---------+---------+
|null     |239.88   |
+---------+---------+

This is because InterpretedMutableProjection inappropriately uses InternalRow#setNullAt on unsafe rows to set null for decimal types with precision > Decimal.MAX_LONG_DIGITS.
When setNullAt is used, the pointer to the decimal's storage area in the variable length region gets zeroed out. Later, when InterpretedMutableProjection calls setDecimal on that field, UnsafeRow#setDecimal picks up the zero pointer and stores decimal data on top of the null-tracking bit set. Later updates to the null-tracking bit set (e.g., calls to setNotNullAt) further corrupt the decimal data (turning 245.00 into 239.88, for example). The stomping of the null-tracking bit set also can make non-null fields appear null (turning 77.77 into null, for example).
This bug can manifest for end-users after codegen fallback (say, if an expression's generated code fails to compile).
Codegen for mutable projection uses mutableRow.setDecimal for null decimal values regardless of precision or the type for mutableRow, so this PR does the same.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests.

By the way, there's a similar-looking problem with type CalendarInterval:
set spark.sql.codegen.wholeStage=false;
set spark.sql.codegen.factoryMode=NO_CODEGEN;

select first(col1), last(col2) from values
(make_interval(0, 0, 0, 7, 0, 0, 0), make_interval(17, 0, 0, 2, 0, 0, 0))
as data(col1, col2);

+---------------+---------------+
|first(col1)    |last(col2)     |
+---------------+---------------+
|16 years 2 days|16 years 2 days|
+---------------+---------------+

In this case, however, the bug doesn't appear to be in InterpretedMutableProjection, but in the way the unsafe buffer is initialized, so I will address it separately.

Merged to master.
cc @rednaxelafx and @cloud-fan for a posthoc review when you find some time.

Thanks @HyukjinKwon @rednaxelafx


sigma for R,L,phi

Make calculations/reasoning for whatever value ends up being used.

By that I mean explain the calculation for mixing the different source values for resistivity and conductivity of stainless steel. --> Appendix.


Fix searching for --compile_args_from=

Hi,
Thanks for your extensions, which allows using clangd with cmake without needed additional per project configuration even with non-standard cmake.buildDirectory path :)
While using it, I found that adding  "--compile_args_from=lsp" to clangd.arguments vscode-clangd setting was ignored by the vscode-clangd-cmake extension.
The reason is that indexOf only search full matches and I did not have exactly --compile_args_from=.
Replacing with a find instead allow search the first item that starts with --compile_args_from= and then get the value afterward.

Thanks for the correction


Mudrod-132 Simplify command line log ingestion

This pull request should simplify the mudrod-engine command line tool used for log ingestion.
It includes a fix for https://github.com/mudrod/mudrod/issues/132 among other improvements made to the documentation/usage of the mudrod-engine command line tool.

I've updated the documentation slightly https://github.com/mudrod/mudrod/wiki/Command-Line-Interface
I still don't understand this directory structure thing or how these configuration parameters are used https://github.com/mudrod/mudrod/blob/master/core/src/main/resources/config.xml#L27
The reason is because my data directory looks nothing like
dataDir/
    /httplog
        /httplog
    /ftplog
        /ftplog
    /RawMetadata
        /1.json
        /2.json

I set my dataDir to -dataDir /Users/greguska/data/mudrod/201611/. That directory contains 2 files:
FTP.201611.gz
WWW.201611.gz

And the ingestion seems to work fine with this structure.
I think further clarification is still needed.

It seems like I'm almost there. I was able to run the full ingestion locally but it failed part of the way through:
2017-05-03 15:46:33,879 INFO  pre.SessionStatistic (SessionStatistic.java:execute(66)) - Starting Session Summarization.
[Stage 10:========================>                               (42 + 4) / 96][Stage 10:==========================>                             (45 + 4) / 96]2017-05-03 15:46:44,796 ERROR executor.Executor (Logging.scala:logError(91)) - Exception in task 47.0 in stage 10.0 (TID 445)
java.lang.NullPointerException
	at java.io.Reader.<init>(Reader.java:78)
	at java.io.InputStreamReader.<init>(InputStreamReader.java:72)
	at org.apache.commons.io.IOUtils.copy(IOUtils.java:1407)
	at org.apache.commons.io.IOUtils.copy(IOUtils.java:1433)
	at org.apache.commons.io.IOUtils.toString(IOUtils.java:585)
	at org.apache.commons.io.IOUtils.toString(IOUtils.java:563)
	at gov.nasa.jpl.mudrod.discoveryengine.MudrodAbstract.initMudrod(MudrodAbstract.java:71)
	at gov.nasa.jpl.mudrod.discoveryengine.MudrodAbstract.<init>(MudrodAbstract.java:56)
	at gov.nasa.jpl.mudrod.weblog.structure.RequestUrl.<init>(RequestUrl.java:43)
	at gov.nasa.jpl.mudrod.weblog.pre.SessionStatistic.processSession(SessionStatistic.java:236)
	at gov.nasa.jpl.mudrod.weblog.pre.SessionStatistic$2.call(SessionStatistic.java:157)
	at gov.nasa.jpl.mudrod.weblog.pre.SessionStatistic$2.call(SessionStatistic.java:147)
	at org.apache.spark.api.java.JavaRDDLike$$anonfun$fn$4$1.apply(JavaRDDLike.scala:153)
	at org.apache.spark.api.java.JavaRDDLike$$anonfun$fn$4$1.apply(JavaRDDLike.scala:153)
	at org.apache.spark.rdd.RDD$$anonfun$mapPartitions$1$$anonfun$apply$23.apply(RDD.scala:796)
	at org.apache.spark.rdd.RDD$$anonfun$mapPartitions$1$$anonfun$apply$23.apply(RDD.scala:796)
	at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
	at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
	at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87)
	at org.apache.spark.scheduler.Task.run(Task.scala:99)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:282)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

It seems to be having an issue reading elastic_settings.json from the classpath. I'll keep looking.

Again I am stuck.
Opened new issue https://github.com/mudrod/mudrod/issues/162

Issue https://github.com/mudrod/mudrod/issues/162 is resolved with @quintinali latest commit https://github.com/mudrod/mudrod/pull/159/commits/819f54fe76624bc3ff2fec3dfa75e79a7c5b025a
However, there is a new problem https://github.com/mudrod/mudrod/issues/163

Issue https://github.com/mudrod/mudrod/issues/163 is not blocking log ingestion. It will be tracked separately from this PR.
I was able to run full log ingestion locally. I'm going to merge to master and run log ingestion on production.


Suggestion: It would be better to support all kSecAttrAccessible values

For example, you may want to store a secret but prevent it to be carried to another device via encrypted backup. This would be a reasonable thing to want for example if you are encrypting you database with a passphrase stored in the KeyChain, and you want that database to be readable only in the device where it was created. Regards!

Makes complete sense to me. I really just wanted to steer people away from using the "Always" option but it does feel like I should support everything EXCEPT for "Always".


⚠ SceneTime has degraded performance

In fd57744, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 12393 ms

Resolved: SceneTime performance has improved in e3aed3f after 12 minutes.


Enhanced Rate Us Option - #1353

Hello Project Admin,
I solved this  Issue - #1353
I Enhanced Rate Us Option please kindly go through it

It's not looking good!


Cleaned "-" that was breaking xml

There was "-" leftover that was breaking xml syntax.

Here is breaking commit https://github.com/MicrosoftDocs/windows-itpro-docs/commit/dfddbf78ef31b3741c03de0e5ae5211e04cd11a3#diff-540ffe49bd32e95e8b2a5da5ba1a565e


styled-components as vs clean-tag is

I noticed recently that Rebass Grid has deprecated the is prop in favour of styled-components' as prop. However I'm using clean-tag to ensure my components' style props are cleaned from the DOM, and so using the is prop from clean-tag to set element tags where needs be. I tried dropping the is prop on my components and using as instead, but this seems to mess up clean-tag's prop cleaning (none of the style props are cleaned in the DOM when I do this).
This may be a niche use case, but wondering if you have any guidance on how to handle this? If I want to use Rebass Grid in addition to my components made with styled-system, using either as or is props depending on the component could get super confusing for other devs consuming these components.

I'd definitely recommend using styled-components as prop over the is prop implementation in clean-tag, since it's a more "official" thing now. Unfortunately SC v4 still didn't get rid of the HTML attribute whitelist issue, but I've generally been leaving the props that aren't stripped away in the HTML output rather than trying to blacklist the styled-system props. It's not ideal, but I think it's an okay compromise. If you do need to remove those extra props, I'd really recommend forking clean-tag or rolling your own to strip things out. Just be aware that SC handles whitelisting on HTML tags and extended components differently


Unable to read warning text

What's the issue:
Unable to read warning text on a repository due to the background colour (#fffccc).
Steps to reproduce:

Open a repository with a warning (https://github.com/DefinitelyTyped/DefinitelyTyped)
Check the warning text.

Screenshots:

Solutions:
Change the background colour of the class .warning.
What version is affected by this problem:
Verified on version 2.1.1.
Thank you for this, it's been a great help :D

Thanks for the detailed report. Will definitely fix this.

This problem has been fixed in the latest update.


Basics: alter the definition of root for Windows

Rather than use a "root" for Windows, use the drive-relative path as a
"root" to terminate iteration/recursion.  Windows does not present the
file system as a unified singular rooted tree and instead has a forest
and thus the level-1 path is conceptually close to the root desired.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]

@swift-ci please test

@swift-ci smoke test


remove a thing

Topic: removeStuff

#
head
base
diff
date
summary

0
e8252757
6120bfdf
diff
Jan 3 15:44 PM
1 file changed, 1 deletion(-)

Reviews in this chain:
└https://github.com/dukeofcool199/revup/pull/40 remove a thing


"Run Test" adornment doesn't update it's position

Environment data

VS Code version: 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8)
Extension version (available under the Extensions sidebar): 2018.12.1
OS and version: Linux x64 4.20.3-200.fc29.x86_64
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.2
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv

Expected behaviour
When test method/class definition changes it's position, "Run Test" adornment should move along with it.
Actual behaviour
"Run Test" adornment stays on its previous line and does'n follow the test. Look at line 23.

After VSCode restart the adornment position updates.
Steps to reproduce:

Write any Python test;
Wait until VSCode discovers the test;
Insert/remove line before test definition.

Please could you update to the latest version of the extension and test once again.
Finally, please could you provide the contents of your settings.json file?

Now it works as intended. Thank you!


import util

Hey,
I cant find a module names "util" in doc2vecc.py, do you mean "utils"? Or is it a custom module that is not included in the repo?
Thank you,
Boraly

Hi!
My bad, thanks for pointing this out. "util" was a custom module that originally wasn't supposed to be needed in the public repo. I added the dependency in the latest commit cb78ba95f33276fcd9fd1621c5566bdf16c9d339.
Does doc2vecc.py work for you now?

Hey,
I will try it out later. Thanks for the commit.
Another "mistake" I found was at doc2vecc.py at line 76 "self.alpha = .025 if cbow else .05".
It has to be the opposite way like you discribe at the params:
":param alpha: The starting learning rate; default is 0.025 for skip-gram and 0.05 for CBOW"
If I am not mistaken it will be 0.025 when cbow is True, else 0.05.
Thanks in advance,
Boraly

Hey,
doc2vecc.py is working! But I compared the results of the python version with the wrapper of the original code and it seems off:
(array([[ 5, 41, 78, 37, 19]]), array([[1.        , 0.9760333 , 0.9714191 , 0.9690429 , 0.96645737]],       dtype=float32)) (array([[  5, 144, 482, 436, 271]]), array([[1.        , 0.95579517, 0.95314723, 0.95248544, 0.946822  ]],       dtype=float32))
I calculated the most similar documents for the document 5. At the top you can see the results of the python code and at the bottom the wrapper. I used the same hyperparameters and same corpus. I found, that the vectors of the python code are all much closer together. If I calculate the cosine similarity of the top 100 documents the lowest it gets is 0.917. For the wrapper its 0.816.
Comparing it to the "normal" Doc2Vec Algo its much closer together, too. Here I get the following results with the same hyperparameters:
(array([[  5, 231, 144,  39, 271]]), array([[1.        , 0.9001148 , 0.8840287 , 0.8789093 , 0.86690176]],       dtype=float32))
,whereby the cosine similarity of the 100th document is 0.641.
Do you know if its normal, that the vectors of Doc2VecC are much closer then with Doc2Vec? And do you maybe know why?

Great! I fixed the default alpha mess up in doc2vecc.py. I cleaned up the code a bit too.
I wasn't able to pinpoint why the wrapper produces different vectors but the pymodule version didn't at least appear worse with some minor testing.
My first bet for Doc2VecC vecs being closer is that it converges faster during training. At least with some simple test data, I got similarly close vectors for Doc2Vec by increasing the number of training epochs.


[Mechanism refactoring] Inconsistence between subgraph and script for pool/P2P repartition

Current Behavior
There is inconsistency in the distribution mechanism between the subgraph and the script.
On the subgraph, we are first updating the market indexes (lastPoolIndex, lastP2PIndex) and accruing interests for suppliers/borrowers, before updating the MORPHO distribution index. On the V1 of the mechanism, That is changing nothing since we are not using the scaled balances. However, on the V2, we are using market indexes to choose the rates of the MORPHO rewards between p2p and pool users for one market side (ex supply cUSDC market), depending on the repartition (ex, if there is 60% of users matched, we are distributing 60% of the rewards to the P2P market).
And, in order to choose this repartition, we are comparing underlying balances after the index update.
But, on the script, we cannot know what is going to be the indexes at the next update. And, because interests are accrued at 2 different rate between p2p market and pool market, the repartition between p2p and pool markets is different before and after an index update. This is the approximation of this mechanism: we are considering that this repartition is the same between 2 market update.
But do we have to choose the initial repartition, i.e. the repartition at the last MORPHO indexes update, or the repartition just before an update of the MORPHO indexes, i.e. the repartition after the pool/p2p indexes update (with interests accrued).
The first version is used in the script (we are using last indexes), but in the subgraph, we are updating MORPHO indexes after handling a P2PIndexesUpdated

Suggestion
I suggest to keep using the repartition of the last update, which is known before an index update, and permit to give accurate estimation offchain.
So the fix is to update the MORPHO indexes just before updating pool/p2p  indexes in the subgraph.

Weve decided to never migrate to the second mechanism so I close this ticker


Password logins disabled / no keys

During the setup ssh password logins are disabled but no keys are generated / imported.
This means that on reboot there's no way for the user to login.

Assumptions section on the readme says about logging in with key and not password. My starting point for this script was my own use/testing, and ssh is far more convenient when creating lots of instances to test with.
For local testing, I can understand using a password, so I'll consider adding some kind of '--insecure' flag for this use-case.
I'd counter with: creating ssh keys is pretty painless, and even if you're not using a provider that adds the public key on creation, importing a public key is quite straightforward (ssh-import-id-gh <username> will import a key that you've added to your github account).
My concern is this being used to create an instance that is open to public signups, where password auth there would mean access to the system, then root/sudo access to user data. Maybe an --insecure flag will provoke a red warning.


Remove component method / or a better way to destroy them.

Removing component from screen should be easier and as easier as adding.
We should be able to set the destroy method or pass an argument true from the wrapper
this.text.destroy(true);
Or have this kind of API : this.add(text);  & this.remove(text);
Have a look on Starling, the whole display list concept, is pretty easy and could fit here.
Let me know if you need help on this, I'd be happy to help.

Alright I submitted a PR to add the remove method.
 But that will be something to the v1 since it is a major breaking change.

This is already fixed on the develop branch and should be on the next release.


About number of LiDAR channels

Thank you for your team's wonderful work! I am wondering the many channels are the 5 LiDARs in Waymo open dataset? Could you please provide some details? Thanks a lot!

Not sure what do you mean by 'channels'. We have detailed description of the LiDAR in the paper.


Fixing an issue when a partial application takes a udt as argument

Fixes https://github.com/microsoft/qsharp-compiler/issues/973, as well as https://github.com/microsoft/qsharp-compiler/issues/955 and https://github.com/microsoft/qsharp-compiler/issues/964. Confirmation and an additional test case will follow shortly.

Abandoned in favor of https://github.com/microsoft/qsharp-compiler/pull/991.


How can I bulk download a csv of links?

Essentially I have a CSV of links, each link I can put into the tool and it downloads properly. I want to be able to just put the entire list in.

Hello! Thanks for filing the issue.
This is a good feature I'd like to add. Your solution definitely works, but bulk workloads are something I'd like to support, especially if there are people asking for it.

Going to call this fixed with this PR: https://github.com/mchaynes/geodatadownloader/pull/65


fix(deps): bump @module-federation/runtime version

fixes #158

Thanks @JamesMHenderson
Some tests are failing 🤔
You change is pretty straightforward though

@gioboa I've redone the package update, ran the unit test locally and they all now pass, but I am having issues running the multi-example script think this is due to me running on a windows environment

@gioboa is it possible to get a version of the package release including this change?

@gioboa is it possible to get a version of the package release including this change?

Yup, I'll cut a release right now. I was waiting to include other fixes but a new version sounds reasonable to me.


orderBy proprety

I've managed to display the elements in the loading order which is not enough for me. My object has a proprety called elementType and I'd like to display those elements first and the rest of elements after.
I've tryed with no success :
source="elements | orderBy:'elementType' "
source="elements | orderBy:'card.elementType' "
source="elements | orderBy:'elements.elementType' "

Did you ever solve this?


Regex with positive lookahead crashes at runtime when accessing match.output

Description
Using a regex with a positive lookahead sometimes crashes @ runtime. See the example in the reproduction
Reproduction
let regex = /(?=([1-9]|(a|b)))/
let input = "Something 9a"
let matches = input.matches(of: regex)
for match in matches {
	print(match.output) // accessing `.output` here crashes at runtime: Thread 1: EXC_BREAKPOINT (code=1, subcode=0x225246848)
}

Stack dump
Thread 1: EXC_BREAKPOINT (code=1, subcode=0x225246848)

Expected behavior
No crash
Environment
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Additional information
No response

This also reproduces with just /(?=(9))/ for the regex.
Don't have a fix yet, but found the cause... The issue appears to be that a positive lookahead is implemented as:
      ...
0:    save(restoringAt: success)
1:    save(restoringAt: intercept)
2:    <sub-pattern>    // any failure restores at 'intercept'
3:    clearThrough(intercept) // remove intercept and any leftovers from <sub-pattern>
4:    fail             // -> 'success'
5:  intercept:
6:    clearSavePoint   // remove 'success' restore point
7:    fail             // propagate failure
8:  success:
      ...

The fail at (4) is the path of success through the lookahead – that instruction drops the position (and other state) back to where it was at the start of the lookahead pattern, and then moves the instruction pointer to (0), which advances the instruction pointer to (8), where pattern matching continues. Unfortunately, the state restoration in the fail also resets the capture group information, erasing any capture data that was saved while matching the lookahead pattern.


punica LoRA kernels require compute capability >= 8.0

I'm benchmarking the multiple lora feature on V100, compute capacity is SM 7.5.
The code fails to run with this error.
Is multiple lora supported on sm75 GPUs like V100?

It looks like https://github.com/punica-ai/punica doesn't support sm75. Please feel free to open a feature request there!


Semifinal files for lean Project

we might do some last minute changes to the presentation based on timing

Lean files are reverted into original state as requested

Thanks, but there is still an issue with the lean-toolchain and lake-manifest.json files. You should update to the same version as the repo.
Could you pealse explain further what the problem is with these files?
As far as i know, the contents of the 'lean-toolchain' and 'lake-manifest.json' files are exactly the same.

Thanks, but there is still an issue with the lean-toolchain and lake-manifest.json files. You should update to the same version as the repo.

Could you pealse explain further what the problem is with these files? As far as i know, the contents of the 'lean-toolchain' and 'lake-manifest.json' files are exactly the same.

Weird. There must be a subtle difference but I am not seeing it in the git diff. I suggest:

Reverting your changes on the lean-toolchain file.
Stashing your changes in the other file.
Do a git pull on the repo.
Unstash your files and commit them to the repo.

The lean-toolchain file should not be part of your pull request.

I restored the lean-toolchain file to its original form.
Hopfully should fix the problem


Dropped 100% sync committee message and sync committee contribution and proof

Describe the bug
This is from a test mainnet node subscribing to all subnets.
After #5350 after a while when there are 30% of dropped attestations, 100% of sync committee messages and sync contribution and proofs are dropped since then and node is not able to recover (after I restart it gets back to 0% drop)

while beacon_attestation topic is consistently at around its max size

Expected behavior
Right now when adding a gossip message, we delete exactly 1 gossip message.
As we have to drop 30% - 40% of attestations anyway, how about drop 30% - 40% of attestation messages when queue is at max size to allow the node to recover @dapplion ?

this is stable test mainnet node v1.10.0


fix: dep

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No prompt for SSH passphrase using remote-ssh

Type: Bug
Connecting to a linux host from windows using remote-ssh.  When I try to push/pull from VSCode, it doesn't work.  I have a passphrase on my key and I don't get prompted for it, instead I get and an error with the following in the Git output window.
Access is not allowed because you are not enrolled in Duo. Please contact your organization's IT help desk.

Access is not allowed because you are not enrolled in Duo. Please contact your organization's IT help desk.

Access is not allowed because you are not enrolled in Duo. Please contact your organization's IT help desk.

Permission denied (publickey,gssapi-keyex,gssapi-with-mic,keyboard-interactive).
fatal: Could not read from remote repository.

However I can push/pull from the terminal with the same key just fine.
VS Code version: Code 1.73.0 (8fa188b2b301d36553cbc9ce1b0a146ccb93351f, 2022-11-01T15:34:06.111Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
Connection to 'ssh-remote+spiderman' could not be established
Remote OS version: Linux x64 3.10.0-1160.31.1.el7.x86_64
Remote OS version: Linux x64 5.4.0-120-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.76GB (13.97GB free)

Process Argv

Screen Reader
no

VM
0%

Connection to 'ssh-remote+spiderman' could not be established

Item
Value

Remote
SSH: spiderman

OS
Linux x64 3.10.0-1160.31.1.el7.x86_64

CPUs
Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (4 x 2593)

Memory (System)
15.51GB (13.68GB free)

VM
100%

Item
Value

Remote
SSH: widow

OS
Linux x64 5.4.0-120-generic

CPUs
Intel(R) Xeon(R) Gold 5215 CPU @ 2.50GHz (40 x 1000)

Memory (System)
62.54GB (33.44GB free)

VM
0%

Extensions (35)

Extension
Author (truncated)
Version

separators
ale
2.4.1

vscode-eclipse-keybindings
alp
0.16.1

systemd-unit-file
coo
1.0.6

output-colorizer
IBM
0.1.2

better-cpp-syntax
jef
1.16.3

vscode-peacock
joh
4.2.2

dotenv
mik
1.0.1

jupyter-keymap
ms-
1.0.0

remote-ssh
ms-
0.92.0

remote-ssh-edit
ms-
0.84.0

remote-wsl
ms-
0.72.0

remote-explorer
ms-
0.0.2

rewrap
stk
1.16.3

reopenclosedtab
uyi
1.1.0

vscode-icons
vsc
12.0.1

vim
vsc
1.24.3

vscode-todo-highlight
way
1.0.5

githistory
don
0.6.19

gitlens
eam
13.0.4

jenkinsfile-support
ivo
1.1.0

vscode-smart-column-indenter
lmc
0.0.13

git-graph
mhu
1.30.0

vscode-docker
ms-
1.22.2

isort
ms-
2022.6.0

python
ms-
2022.18.2

vscode-pylance
ms-
2022.11.20

jupyter
ms-
2022.9.1202862440

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.12

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-slideshow
ms-
0.1.5

ansible
red
1.0.90

vscode-yaml
red
1.10.1

code-spell-checker
str
2.11.0

gitblame
wad
9.0.1

(2 theme extensions excluded)

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Updated to 1.73.1 and the problem still exists.

I can reproduce this with a wsl target -> no prompt for credentails e.g. when fetching a repo vscode-git client will hang (obviously due to expectation for creadentials). Since no prompt is given one has to reload window so git restarts and do every ssh related git command in terminal. btw: when using https as remote prompting for credentails works as expected


Remove string.prototype.trim package

This function has good browser support (ES5), and for older browsers it
should be shimmed, so it seems relatively safe to use the prototype
method directly instead of the string.prototype.trim package.
http://kangax.github.io/compat-table/es5/#test-String.prototype.trim
I believe this will reduce the bundle size impact of this package by
18.5 KiB.

Since we're able to make this change with webpack's aliasing internally (it saved 6-7k), I don't think there's a need to do it here. Please reopen if you disagree.

That's fine with me!
However, I just wanted to clarify the total savings amount. In my analysis, it would be closer to 19 KiB if we didn't have a different module (object.entries via react-with-styles-interface-aphrodite) importing es-abstract/es5.js. ;)


error in the build of the app

i have migrated to the latest version of strapi, and i want to add the sitemap addon but the issue is in the react-router-dom dependency where strapi require version 6 of it and the strapi webtools->sitemap use react-router-dom v5
i'll provide you with my dependencies of the package.json using node version 20.
the scenario is from my terminal im using @latest because i have this issue since yesterday so i was trying to seek the latest:
yarn add @pluginpal/webtools-core@latest
then,
yarn add @pluginpal/webtools-addon-sitemap@latest
then,
yarn build
i got this error:
[vite]: Rollup failed to resolve import "@strapi/design-system/v2" from<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
i tried then to upgrade the helper-plugin:
yarn add @strapi/helper-plugin@latest
then i built the app and got the following error,
node_modules/<EMAIL_ADDRESS>(6:9): "Redirect" is not exported by
"node_modules/react-router-dom/dist/index.js", imported by "node_modules/<EMAIL_ADDRESS>file: C:/Users/user/repos/Talmaro/TalmaroCMS/node_modules/@pluginpal/webtools-addon-sitemap/node_modules/@strapi/helper-plugin/dist/index.mjs:6:9
the following are the dependencies of my package.json:
"dependencies": {
"@pluginpal/webtools-addon-sitemap": "^1.0.0-beta.10",
"@pluginpal/webtools-core": "^1.0.0-beta.15",
"@strapi/plugin-users-permissions": "5.4.1",
"@strapi/provider-upload-aws-s3": "^5.4.1",
"@strapi/strapi": "5.4.1",
"@strapi/utils": "^4.8.2",
"pg": "8.8.0",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react-router-dom": "^6.0.0",
"strapi-plugin-populate-deep": "^3.0.0",
"strapi-v5-plugin-populate-deep": "^4.0.4",
"styled-components": "^6.0.0"
},
"engines": {
"node": ">=18.x.x",
"npm": ">=6.0.0"
},

Hi @HashemSalameh,
The sitemap plugin does not yet support Strapi 5. See #186.


Save in Log File?

Hi is it possible to save the output in a logfile?
When using this script when I am connected via Putty to my Server then it generates the whole info but I can not scroll fully up anymore to see the info for all shows.
Would love to be able to just add something like this to the command: --logfile /location/folder/intro-detection-info.log

I tried it like this:
./intro-detection-info http://DOMAIN:32400/ TOKEN > introinfo.log
But the result is like this and sadly not really readable:
+--------------------------------+--------+----------+--------------------------------+
|              SHOW         | SEASON | DETECTED |       COMMENT             |
+--------------------------------+--------+----------+--------------------------------+
| Show 1              |      1 | Partial | Episodes 1, 10, 11 and 13 do   |

I've released a new version that allows you to run the application with --colors=false. There's also --format=csv to get a more machine-friendly output.


Update build to the newest infrasture

Issue description
See: https://github.com/micronaut-projects/micronaut-liquibase/pull/262

closed via https://github.com/micronaut-projects/micronaut-problem-json/pull/172


When the mPLUG-2 model can be released?

When the mPLUG-2 model can be released?

Is there any plan to release the pretraining code of the mPLUG-2?

Can we expect mPLUG-2 codebase to be released in a month or so for the academic use ?


Set up manual build stages for travis

Working towards https://github.com/dart-lang/angular/issues/820, all manual edits for now

Crazy cool, @jakemac53 !
The last master branch build took over 2hrs - https://travis-ci.org/dart-lang/angular/builds/336288174

@alorenzen @matanlurey are you willing to take this PR as is while I work on mono_repo support? Or would you prefer to wait?

Looks good. Let's merge this internally if you're ready @jakemac53?

Yep, ready whenever. Not sure exactly what the workflow looks like here, did you want me to do it or do you folks handle it?

@jakemac53 I'll handle it today!

Merged. Will sync in the next batch.


[RHOAIENG-4334] 'Job' Name (in code) alignment

Closes: RHOAIENG-4334
Description
Renamed "Job" to "Recurring run"
How Has This Been Tested?
Check the codebase to ensure that all instances of 'job' are either replaced with 'recurring run' or that the corresponding function/type is marked as deprecated.
Also, run and check all the functionality of pipelines in dashboard to ensure everything is working as expected.
Test Impact
No tests added, modified the previous tests to accommodate the change.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

tested job flows and things work as expected
/lgtm
/approve


METAMODEL-241: Fixed

This fix is implemented by further diving deep into the depths of OpenJDK. I'm not really fond of going down that route, but it seems to be the way to go if we really want to keep deserialization support.
Thanks to @LosD for the good hint on what had changed in OpenJDK by the way!

Oh wow that is nasty. But if that's what it takes, that's what it takes.
LGTM!


Browser demo should let you test the grammar in the browser

I think the primary issue to overcome here is laziness. :P

http://omrelli.ug/nearley-playground/


Bugfix/batch logic

Fixes a logic error in the batch processing method described in #187.
Also raises a NotImplementedError for trying to use the batch processing method due to the problem with rtree serialization described in #187.
Bumps version to v0.4.5 to release this bugfix.
@jhoshiko could you take a look when you get a chance?

Until we resolve the parallelization issues (most likely by implementing a new approach), I think returning a NotImplementedError is the best choice. The changes look good to me!


Fixed not finding JDBC driver class when creating multiple connections

Sometimes JVM crashes with multithreaded test case. The cause is that JPype does not support multithreading.
originell/jpype#211

Codecov Report

Merging #8 into master will increase coverage by 0.13%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   87.31%   87.44%   +0.13%
==========================================
  Files           7        7
  Lines         465      470       +5
==========================================
+ Hits          406      411       +5
  Misses         59       59

Impacted Files
Coverage Δ

pyathenajdbc/connection.py
80.39% <83.33%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50cd80...925f59a. Read the comment docs.

It seems that the JVM crashes no longer because it synchronized the function that starts the JVM.

That certainly solves the issue,
Thank you so much :+1:


History expansions with pasted words

% ho hello world
zsh: command not found: ho
% ec!!
echo hello world
hello world
%

In the above, ec!! is red (typeset -a region_highlight=( '0 4 fg=red,bold memo=zsh-syntax-highlighting' )), but shouldn't be.
Compare #713.

Aside: I dumped region_highlight there by doing:
f() { typeset -p region_highlight > /dev/tty }
zle -N f
bindkey '^T' f


Exception: winston.Logger is not a constructor

An exception is thrown when initializing express-winston, apparently the error is in:
express-winston/index.js
I think the latest update to Winston broke this build.

This should be part of the winston-3 branch https://github.com/bithavoc/express-winston/tree/winston-3 @makrandgupta is on it.

Attached is the stack trace:
TypeError: winston.Logger is not a constructor
    at new winstonLogger (common\logWinston.js:28:20)
    at Object.<anonymous> (common\gracefulExit.js:8:17)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)
    at Module.require (internal/modules/cjs/loader.js:650:17)
    at require (internal/modules/cjs/helpers.js:20:18)```

 options.winstonInstance = options.winstonInstance || (new winston.Logger ({ transports: options.transports }));
                                                          ^

TypeError: winston.Logger is not a constructor
    at Object.errorLogger (/mnt/c/Users/Acer/projects/coachtools/backend/node_modules/express-winston/index.js:120:59)
    at Object.<anonymous> (/mnt/c/Users/Acer/projects/coachtools/backend/src/server.js:99:28)
    at Module._compile (module.js:652:30)
    at loader (/mnt/c/Users/Acer/projects/coachtools/backend/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/mnt/c/Users/Acer/projects/coachtools/backend/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)

@surfaceowl createLogger is a function. so just use const logger = winston.createLogger(...

Solved this by:
npm uninstall winston
then:
npm install<EMAIL_ADDRESS>

as @Kogs said:
if using "winston": "^3.0.0" do:
var logger = winston.createLogger({

 transports: transports
});

and if using older "winston": "^2.4.0" do:
var logger = new winston.Logger({

 transports: transports
});

Yep, but you need to keep in mind that also the transports are configured in a different way with winston": "^3.0.0.

@hiro5id I agree. The problem is not fixed thoroughly. I am using 'express-winston' in addition with 'winston' like this:
app.use(expressWinston.logger({
  transports: [
    new (winston.transports.Console)({
      json: true,
      colorize: true
    }),
    new winston.transports.File({
      filename: 'logs/success.log'
    })
  ]
}))

Here I'm using "express-winston": "^2.5.1"
If I use<EMAIL_ADDRESS>this problem pops out. I can only replace it with the older version. However, I still want to keep up with the latest version of winston if possible.

@makrandgupta what's the ETA for winston-3 support?

summoning @makrandgupta

My apologies for going dark. I have had no time to work in this. Everything that I did is already pushed into the v3 branch. I could assist another developer make the port happen but won't be able to take point on this one.

Oki doki @makrandgupta
Any other volunteer? I’m gonna add a message to the Readme asking for contributors.

Guys,
I was able to get it running with this:
app.use(expressWinston.errorLogger({
  winstonInstance: winston.createLogger({
    transports: [
      new winston.transports.Console({
        json: true,
        colorize: true
      })
    ]
  }),
  exceptionToMeta: function(err){
    return err;
  },
}));

Anyone who has used this site, make sure to replace all instances of
const logger = new (winston.logger)
replace the
const logger = (winston.createLogger)({
drop the new and rename the funciton createLogger and you are good to go!

A PR was merged recently (https://github.com/bithavoc/express-winston/pull/178) to clarify that the current version of express-winston only supports winston <3. I realize this "fix" is not ideal, but it does prevent users from seeing the error reported here and allows us to add winston@3 support when we're ready.
Between the above change, and the fact that we have an issue open for adding winston@3 support (https://github.com/bithavoc/express-winston/issues/163), I think this issue is redundant, so I'm going to close it.


Does OLM operator have a cache for CSV metadata?

Type of question
Are you asking about community best practices, how to implement a specific feature, or about general context and help around the operator-sdk?
General Question
Question
Our end-to-end testing (github actions) runs on a nightly basis and for each suite (6 of them in total), the operator, operator bundle and bundle index images are compiled and pushed to the external registry interface of our testing cluster (OCP4.10 on IBM Cloud). The tests are then geared to use these images from imagestreams and catalogsources, also created by the tests. At both the start and conclusion of each test suite, actions are executed to clean-up the cluster and leave it in as vanilla a state as possible.
However, at times the tests fail and one of the issues has been lack of permissions for the operator service account. This is easily fixable by updating the RBAC config so that a slightly different CSV is included in the bundle. And this is where things go wrong ...
Despite modifying the CSV, the CSV installed in the tests is old (eg. 2022-06-07T18:37:13).
Now I have checked:

The bundle image being compiled for the tests has the CSV modification;
The bundle image as accessed by the imagestream has the CSV modification;
Cleared out any images in the registry by scheduling the prune cronjob;
Restarted the OCP registry as this, apparently, clears out the image cache.

... And still the old CSV is being installed.
Does the OLM have an internal cache of CSVs that it maintains and periodically updates?
If so, how can I clear it out, eg. restarting the OLM operator?
Thx.
Environment

operator-lifecycle-manager version:
As reported in OCP -> RELEASE_VERSION: 4.10.15

Kubernetes version information:
OCP 4.10.15_1520

Just a guess: any chance you're reusing an image tag for this bundle? Bundle manifests are unpacked before installation into a ConfigMap whose name is based on a hash of the bundle image reference and not unpacked again if the ConfigMap already exists. @dinhxuanvu: Wasn't there an issue for this somewhere?
If this is the case then you can work around it by either referencing the bundle image by digest instead of tag in the catalog, or updating your teardown process to delete the unpacking ConfigMaps in OLM's namespace.


Update ERBh gem

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.7%) to 95.439%

Totals

Change from base Build<PHONE_NUMBER>:
-1.7%

Covered Lines:
1151

Relevant Lines:
1206

💛  - Coveralls


fix: add extension

Caused issues downstream for Brightspace/folio-app. Seemed to be the only .js extension missing. Resulting error
Module not found: Error: Can't resolve '@brightspace-ui/core/helpers/dom' in '/home/runner/work/folio-app/folio-app/node_modules/@brightspace-ui-labs/facet-filter-sort/components/applied-filters'
Did you mean 'dom.js'?
BREAKING CHANGE: The request '@brightspace-ui/core/helpers/dom' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

Darn, fixed this in the new version of the applied filters but forgot to come back and fix it in this one

No worries. Super easy fix 😄.


Update French translation (done on Transifex)

Hi @tananaev, for your information, I have added few French translations into transifex. I have taken @l-e-o-n-c-e edition and also update other empty fields.
Best,
Jonathan Dreyer

Thank you. We will include updated translations in the next release.


Confirm  tag ommital works on IE11

See /public/views/layouts/main.hbs - it would probably take about five seconds to add <head> and </head>.

Still allowed under HTML5 and is cleaner ;)

But does IE11 like it?

.subjective.avi
"Is cleaner" is pretty vague. Old browsers aren't going to appreciate not having the <head> tag, I imagine.

The invalid label, by the way, isn't for your opinions. If the issue is subjective, please use the discussion tag

Can we confirm that IE11 is OK with it? Until then I'd rather keep this issue open

Fairly sure it does - browsers always render something, even if the input is dodgy - have you ever seen a webpage that cannot load because of malformed html?

IE11 is automatically separating the <head> and <body> elements and there are no errors in the console, so it can definitely handle it. Separating the head and body in their tags is more of a practice than anything.
If everyone does vote to have the <head> added, I don't see a problem with it being there. It get in the way or matter much in the long run.

Just thought I'd note that it is completely valid HTML. https://validator.w3.org/nu/?doc=http%3A%2F%2Fosdev.tk%2F

Still valid under HTML5

There you go :package:

I'm pretty sure IE9+ (at least) should be fine with no head, and it's unlikely that we'll ever target any older versions, especially since Scratch supports IE9+.

Closed because the name of the issue was "Confirm tag ommital works on IE11", and it does.


Cole - integrate local code into new repo

@cbmckni - to integrate code from local machine into repo

My local code is already integrated into the "cbmckni" branch. Do I need to do anything else?

@cbmckni - create a pull request and ensure there are no conflicts with the master branch.
Once a PR is in place it's easier for me to review the contents and make suggestions.


CIP-???? | Plutus support for Multi-Scalar Multiplication over BLS12-381

The CIP proposes an extension of the current Plutus functions to provide support for the efficient computation of the multi-scalar multiplication over the BLS12-381 curve. This operation is crucial in a number of cryptographic protocols that can enhance the capabilities of the Cardano blockchain.
Rendered Proposal

invited (on Discord) @dkaidalov to introduce at next CIP meeting (https://hackmd.io/@cip-editors/96) and also offered to tag Plutus team once he can confirm commits (with Plutus code & spec changes) are done for the time being.

This will be implemented after the CIP is approved and merged, though we first need to have the CIP reviewed and approved (not just grammars etc., but also technical aspects like type and semantics of the proposed functions).

This all looks fine to me now.

Merging to save time at packed meeting, since we have more than quorum already a couple hours before the meeting 😎


use scheduledExecutorService replace timer

When threads are processing timed tasks in parallel, when Timer runs multiple TimeTasks, as long as there is no timeout exception, other tasks may be automatically terminated. Using ScheduledExecutorService does not have this problem.

Codecov Report

Merging #3241 (ddab5af) into develop (44bdeed) will decrease coverage by 0.45%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop    #3241      +/-   ##
=============================================
- Coverage      48.08%   47.63%   -0.46%
+ Complexity      4575     4078     -497
=============================================
  Files            552      478      -74
  Lines          36521    32983    -3538
  Branches        4818     4385     -433
=============================================
- Hits           17561    15711    -1850
+ Misses         16747    15229    -1518
+ Partials        2213     2043     -170

Impacted Files
Coverage Δ

...ocketmq/store/schedule/ScheduleMessageService.java
74.74% <60.00%> (+0.50%)
:arrow_up:

...rg/apache/rocketmq/common/stats/StatsSnapshot.java
84.61% <0.00%> (-15.39%)
:arrow_down:

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-8.70%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...va/org/apache/rocketmq/common/stats/StatsItem.java
50.00% <0.00%> (-5.00%)
:arrow_down:

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
59.13% <0.00%> (-2.16%)
:arrow_down:

.../rocketmq/broker/filter/ConsumerFilterManager.java
72.19% <0.00%> (-1.80%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
77.72% <0.00%> (-1.49%)
:arrow_down:

... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bdeed...ddab5af. Read the comment docs.

Coverage increased (+0.1%) to 54.232% when pulling ddab5af4227575e90c6eba96d714632005ca75a1 on zhaohai1299002788:dev-scheduledExecutorService-replace-timer into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.


Listener 'observer' take a while to fire ?

I'm building application that want to show user step in realtime but listener take too long to invoke.
Is it possible to show healthkit user step in realtime ?
this is my code
async componentDidmount() {
    AppleHealthKit.initHealthKit(HKOPTIONS, (err, res) => {
        if (err) {
            console.log('error initializing Healthkit: ', err);
            return;
        }
        AppleHealthKit.setObserver({ type: 'Walking' });
        NativeAppEventEmitter.addListener('observer', () => console.log('fetch new data'));
    });
}

AppleHealthKit.setObserver - this is mostly for background and we can't control when healthKit would fire this event.
It might happens in 5 mins or 20

So initStepCountObserver() use to detect value change when application in foreground
and setObserver use to detect value change when application in background ?
if i understand it correctly. Is this code below use setObserver with react-native-background-timer in a right way or not ?
BackgroundTimer.runBackgroundTimer(() => {      //code that will be called every 3 seconds     AppleHealthKit.setObserver({ type: 'Walking' });     NativeAppEventEmitter.addListener('observer', () => console.log('fetch new data')); }, 3000);

initStepCountObserver

I've checked that, no - it also use background way.
Under both this calls https://developer.apple.com/documentation/healthkit/hkobserverquery is used.
So, if you need to do it in foreground, I can suggest you only to check every second(or so) for new data available or not.
But normally, from my experience, HealthKit publish information with some delay (even in native Health app you can't see step changes with each your step during walking)


Add OverlappingInstances ?

Hello,
Thanks for sharing the module.
It is very useful but I find that I need different instances for some types.
I am wondering if you could add OverlappingInstances Pragma to allow users to override the instance, when the need arises. It is a pita to create a newtype just to override the Arbitrary instance.
Thanks
Joe

@joe9 in recent GHC (starting from 7.10.3, IIRC) you can write
instance {-# OVERLAPPING #-} Arbitrary (Vector Int) where
   ...

(out of curiosity, what instances you want to overlap?)
And to be sure: we won't make any instance overlappable with only weak reasons. They introduce quite a lot of headaches.


[1.16.3] V:4.3.1 at ATM6-Pack, Enchanting Stats at the Shelfs not shown

Hello,
Vanilla Bookshelfs and ohters at (First Level) all have the "Enchanting Stats: Eterna +1.00"
but only the next tier Item "Hellshelf" and "Seeshelf" has an "Enchanting Stats: Eterna +1.50 and Quanta +1.50"
And i know from Valhelsia, the last tier "Endshelf" has "Enchanting Stats" too.
In addition, the extended Hellshelf, Seeshelf and Endshelf do not have Enchanting Stats too, in ATM6.
Is it the Pack or is the Mod? I dont know.
Thanks
Bye bye

This is the issue that 4.3.2 fixes.

Note that while 4.3.2 fixes that issue, searching for stats in jei will not show the items as that is blocked by forge: https://github.com/MinecraftForge/MinecraftForge/pull/7410


How to upsample with snt.Conv2DTranspose

I want to upsample some tensors and imitate the following code with Sonnet modules:
# (1,1,x) -> (5,5,64)
outputs = tf.layers.conv2d_transpose(data, filters=64, kernel_size=1, strides=5, padding='valid')

# (5,5,64) -> (15,20,64)
outputs = tf.layers.conv2d_transpose(outputs, filters=64, kernel_size=(3, 4), strides=(3, 4), padding='valid')

# (15,20,64) -> (30,40,32)
outputs = tf.layers.conv2d_transpose(outputs, filters=32, kernel_size=2, strides=2, padding='valid')

# (30,40,32) -> (60,80,32)
outputs = tf.layers.conv2d_transpose(outputs, filters=32, kernel_size=2, strides=2, padding='valid')

# (60,80,32) -> (120,160,7)
outputs = tf.layers.conv2d_transpose(outputs, filters=7, kernel_size=2, strides=2, padding='valid')

I tried:
outputs = snt.Conv2DTranspose(64, (5, 5), kernel_shape=1, stride=5, padding='VALID')(data)

outputs = snt.Conv2DTranspose(64, (15, 20), kernel_shape=1, stride=2, padding='VALID')(outputs)

outputs = snt.Conv2DTranspose(32, (30, 40), kernel_shape=(3, 4), stride=(3, 4), padding='VALID')(outputs)

outputs = snt.Conv2DTranspose(32, (60, 80), kernel_shape=2, stride=2, padding='VALID')(outputs)

outputs = snt.Conv2DTranspose(7, (120, 160), kernel_shape=2, stride=2, padding='VALID')(outputs)

data has shape (?,1,1,218). The TF version works fine but the Sonnet version yields:

ValueError: Incompatible shapes between op input and calculated input gradient.  Forward operation: non_visual_dec_node/tranpose_model_node/conv_2d_transpose/conv2d_transpose.  Input index: 2. Original input shape: (?, 1, 1, 218).  Calculated input gradient shape: (?, 5, 5, 218)

Closing out some old issues, please reopen if this is still a blocker.


spender term in ERC20WithPermit is incorrectly used

Current implementation of ERC20WithPermit uses the term spender to refer to the source account from which tokens are transferred from, while both the EIP (see https://eips.ethereum.org/EIPS/eip-20) and major implementations (like e.g.  OpenZeppelin, https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a55b7d13722e7ce850b626da2313f3e66ca1d101/contracts/token/ERC20/ERC20.sol#L163) use the same term to refer to an account that's been authorized to spend tokens on behalf of another. This can lead to confusion (it almost happened to me recently preparing a DAO proposal), and has an ABI-compatible fix.

@cygnusv if you have a minute I'd love a spot check!
https://github.com/thesis/solidity-contracts/pull/18


Unclosed object binding patterns do not give correct completions

Now that #3615 is in, here's an annoying one for editors without brace completion:
interface Thing {
    abcdef: any;
}

interface I {
    property1: Thing;
    property2: string;
}
var foo: I;
var { property1: { /**/ } = foo;

Expected: abcdef is in the completion list.
Actual: property1 and property2 are in the completion list.

This is a hard one to get right just because of the grammar.

Right - this shouldn't be a bug. I forgot that an initializer is valid on a nested binding pattern.


Atomic-lib get_resource doesn't pass agent in request to atomic server, forcing all resources to be public

Standard atomic lib sample:
    let test_article = "atomic-server/ontology/terraphim-ontology/class/article";
    let fetched_new_resource2 = store.get_resource(test_article).unwrap();
    println!("Fetched new resource: {:#?}", fetched_new_resource2);

only works for public resources because the agent isn't passed to get_resource even if it's set on the server.
The fix is rather simple - use a passing agent like in crate::client::post_commit, but I am thinking may be worth creating another
get_resource function and use the builder pattern to call like this store.get_resource(test_article).with(agent). To my understanding, there are performance implications for validating auth which is not needed for public resources.
References for builder pattern 1 2

Same as #787 perhaps?

Closing as duplicate, let me know if I misunderstood


doc: Fix typos in MQTT example documentation

Signed-off-by: Jacob Siverskog<EMAIL_ADDRESS>

Codecov Report

Merging #15084 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #15084   +/-   ##
=======================================
  Coverage   52.92%   52.92%
=======================================
  Files         309      309
  Lines       45268    45268
  Branches    10451    10451
=======================================
  Hits        23956    23956
  Misses      16544    16544
  Partials     4768     4768

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77546a0...d83c585. Read the comment docs.


Use instance profile for AWS creds

@lumoslabs/devops

@apurvis Made the changes, check again?

Removed.


bpfman operator release v0.5.2

bpfman operator release v0.5.2
This pr fixes some incorrect version tags in my previous commit for release v0.5.2.
Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Are you familiar with our operator pipeline?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Your submission should not

[ ] Add more than one operator bundle per PR
[ ] Modify any operator
[ ] Rename an operator
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/pipeline restart operator-hosted-pipeline

Pipeline failed due to it is trying to modify the existing bundle: bpfman-operator:'0.5.2


Update Header UI and Enhance UI/UX in Markdown Previewer Layout

This issue aims to enhance the user interface of the Markdown Previewer repository by updating the Header's UI and making various UI/UX improvements. These changes will help make the Markdown Previewer more visually appealing and user-friendly.
Navbar UI Update:

Design and implement a more modern and visually pleasing header.
Ensure that the updated header is responsive and looks good on various screen sizes and devices.

Dark & Light Mode Button:

Update the Dark & Light Mode button to include spacing on the left and right.

Layout Update:

Ensure spacing between elements is uniform and visually appealing.
Review the width of different sections or elements and adjust them to create a balanced, user-friendly layout.

@LakshanRukantha, please go through contributing.md before you create any PR.

@LakshanRukantha Please Assign it to me I would like to contribute in it


fix(hotspare): schedule replicas individually

When >1 replicas fail at the same time, the core agent was running the
scheduling algorithm once and then using the result to create new replicas.
The fix is to run the scheduling algorithm for each new replica we're adding.
This way we always make sure that we respect the scheduling rules.

bors merge