Unable to find Component by displayName when using React.forwardRef

Current behavior
Unable to find a childComponent by displayName when shallow rendering the parent while using  wrapper.find("displayName") unless displayName includes ForwardRef(childComponent) || ForwardRef
I'm aware of some issues regarding forwardRef, and displayName so I've tried a few different approaches.
Test:
  it("renders text", () => {
    component = shallow(<Parent {...props} />).find("Button");
    component.simulate("click");
    expect(props.toggleText).to.have.been.called;
    expect(component.children().text()).to.contain("text");
  });

Default approach: (Above test fails)
childComponent only discoverable via find by "ForwardRef"
const Button = forwardRef((props, ref) => (
  return (
    <button
      className={props.className}
      ref={ref}
    >
      {children}
    </button>
  )
));
export default Button;

Approach #1: (Above test fails)
childComponent only discoverable via find by "ForwardRef(Button)"
const Button = (props, ref) => {
  const {
    className,
  } = props;
  return (
    <button
      className={className}
      ref={ref}
    >
      {children}
    </button>
  );
};

const buttonWithRefForwarding = forwardRef(Button);
buttonWithRefForwarding.displayName = "Button";

export default buttonWithRefForwarding;

Output of wrapper.debug():

  <ForwardRef(Button) className="btn">
    Text here
  </ForwardRef(Button)>

Approach #2:
(Above test passes with this approach in the parentComponent unit test above, but fails right out of the gate for the Button unit tests)
const Button = function Button(Component) {
  const returnedButton = (props) => {
    const {
      className,
    } = props;
    return (
      <button
        className={className}
        ref={ref}
        >
          {children}
      </button>
    );

    function forwardRef(props, ref) {
      return returnedButton;
    }

    return React.forwardRef(forwardRef);
  }
}

export default Button;

Failing Button Unit test:
describe("<Button />", () => {
  let component;
  let props = {
    className: "class"
  }
  beforeEach(() => {
    component = shallow(<Button {...props} >{children}</Button>);
  });

  These both fail -->
  it("should have a displayName, () => {
    console.log(component.displayName) <-- undefined
    console.log(component.debug()) <-- '{{ $$typeof: Object(Symbol(react.forward_ref)_16.czyhiszjh),
    render: [Function: forwardRef] }}'
  })

  it("should set displayName", () => {
    const button = mount(

        <Button {...props}>{children}</Button>

    );
    expect(button.find("Button")).to.have.length(1);
  });

Console output on failure:
✗ should set displayName
	Invariant Violation: Objects are not valid as a React child (found: object with keys {$$typeof, render}). If you meant to render a collection of children, use an array instead.
	    in Button
	    in div (created by WrapperComponent)
	    in WrapperComponent

Output of wrapper.debug() In the parentComponent:

  <Button className="btn">
    Text here
  </Button)>

Output of wrapper in the childComponent:
ShallowWrapper()

Output of wrapper.debug() In the childComponent:
''

Output of wrapper.find('Button') In the childComponent:
ShallowWrapper()

Output of wrapper.find(Button) In the childComponent:
ShallowWrapper()

Expected behavior
Users should be able to use wrapper.find('displayName") to make assertions on a childComponent that uses React.forwardRef without having to set the displayName with ForwardRef(childComponent) || ForwardRef
Your environment
Mac OS High Sierra 10.13.6
Mac Book Pro
API
shallow
Version

library
version

enzyme
@3.6.0

react
@16.5.2

react-dom@
16.5.2

react-test-renderer
@16.5.2

Adapter

library
version

enzyme-adapter-react-16
@1.5.0

enzyme-adapter-utils
@1.8.0

This has been resolved. The issue was needing a clean install after updating all dependencies.
Running rm -rf node_modules followed by npm i was the solution.
Appreciate your help.

This appears to be working for me with latest enzyme and the enzyme adapters. Can you try updating enzyme-adapter-react-16?

I'll close this with some more test cases :-)


Can't connect to DB , with engine = sa.create_engine("ibmi://user:pass@host") result in missing system odbc error

weird result for a malformed connection string on ubuntu 20.04.4 , python 3.8.10
https://github.com/IBM/sqlalchemy-ibmi/blob/6a0a5038f1e1d6955af46ae6e61e8440a903fedd/sqlalchemy_ibmi/base.py#L864
fixed by remove last semicolon :
return [["Driver={%s}; UNICODESQL=1; TRUEAUTOCOMMIT=1; XDYNAMIC=0" % (

I had this exact same issue; thank you openmax!

@openmax  -- went ahead and made the update.  released as https://pypi.org/project/crazy-ibmi .  Assuming that @kadler  and @naveen-ram  have moved onto other projects.  Please let me know if you'd like to be added as a contributor to the new project.

@2ps thank you , no need to be added as contributor .

This seems to have been fixed with #139


Extensions:  workbench.extensions.installExtension(...) should prompt for confirmation

The workbench.extensions.installExtension(...) API should prompt for user confirmation.
CC @isidorn

vscode.commands.executeCommand("workbench.extensions.installExtension"... is the right API.
@sandy081 what do you think about making this command prompt users for confirmation? Without it extensions can just install extensinos in the background without user consent (security problem)

Without it extensions can just install extensinos in the background without user consent (security problem)

Please note that once an extension in installed it has access to all commands.
It is required not to show the dialog for the extensions calling this API. Being said that, when Settings Sync is enabled we show a dialog asking users to install and sync this extension instead of automatically syncing this extension to all user machines.

It is required not to show the dialog for the extensions calling this API.

Why is it required to not show the dialog?

It is to provide better user experience for the user I believe. For example we have helper extensions to set up remote experience which will install remote extensions with out showing a dialog.

I still think those flows could prompt. For transparency.
fyi @bamurtaugh

Maybe silly question - what would the implication be here for extension packs? Technically that'd be installing multiple extensions from just one.

Not a silly question. Extension packs will not be affected by this change.
Sine for those, extensions do not explicitly call the installExtension command API. They statically state what extensions are in the Pack and then @sandy081 takes care of the rest.


Upgrade to version 6.71

Solution

Upgrade to version 6.71

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme

Own CI results for Revision: 2d45b20b24e9d4a1fd0c92682bfc38f7175fcc4a


One slice left menu

Left menu will be better if we can keep menu items in first row without additional slice on the way.

done


slides added by 'slickAdd' are not 'unslicked' on 'unslick'

When I add a slide with slickAdd after the slide has been initialized and then I do unslick slick doesn't unslick the added slide

Can you please provide a jsfiddle of the issue?


old dockers ?

Hi, so I am using docker dusty/galactic-pytorch-l4t-r32.6.1, and i noticed that thre some missing packages ?
I am not able to to sudo apt-get install ros-galactic-diagnostic-updater , orsudo apt-get install ros-galactic-xacro?
Is it normal ? I was able to build packages from source but why isnt it available inside the ros2 docker ?
thank you

Hi @an99990, there aren't any apt packages for foxy/galactic for 18.04, and these containers are based on Ubuntu 18.04 (same as JetPack 4.x).  Hence all packages are built from source.

oh i understand, thank you for the prompt answer


Return, don't fail, when extension used by non-root module

This fixes the following scenario:

Two bazel modules, both of which depend on toolchains_llvm
Both modules are bzlmod enabled with MODULE.bzlmod files
Both MODULE.bzlmod files specify a llvm toolchain
The second modules depends on the first via bazel_dep

Expected results

the second module can depend on the first, and operations use the llvm toolchain that it defines

Actual results

build fails with Error in fail: Only the root module can use the 'llvm' extension

Resolution
Instead of failing, we just return. This keeps the behaviour of only being able to actually use the llvm extension in the root module, but we don't error out.
A more complex but similar example is that from rules_python where they will still register the toolchain, but it will not be marked as the default toolchain if it is not called from the root module: https://github.com/bazelbuild/rules_python/blob/main/python/private/bzlmod/python.bzl#L102

As per @fmeum's comment in #243, dev_dependency is one "solution" for this. I'm definitely open to the tack this PR takes though; the dev_dependency route doesn't seem ideal.
But, from a composability standpoint, doing nothing for non-root modules doesn't seem ideal either though; I see a couple of issues:

rdeps of the module that uses toolchains_llvm will have to pull in and configure toolchains_llvm themselves — even if these rdeps don't themselves make direct use of a C/C++/etc toolchain or anything else from toolchains_llvm
If I understand correctly how bzlmod extensions (with isolate = False) work, rdeps configuring toolchains_llvm will need to be careful to use the same repo names as their dependencies so that use_repo/register_toolchains calls in their deps' MODULE.bazel files don't error

For the common use case (using toolchains_llvm solely via the registered C/C++ toolchain and not using other outputs like @llvm_toolchain//:omp, using llvm_toolchain as the repo name, rdeps that themselves would need/want toolchains_llvm anways) the above is perhaps acceptable: configuring a C/C++ toolchain is arguably something that's best decided by the top-level module anyways. (Though dev_dependency is maybe a better solution here; it sidesteps the repo name issue...)
However for modules that use other outputs from llvm_toolchain than just the C/C++ toolchain (i.e. binaries like clang-format, libraries like OpenMP) the first issue seems unacceptable — I should be able to properly encapsulate my module's OpenMP dep, users of my module shouldn't need to be aware of it (afaik this is not possible under a "skip non-root modules" scheme, even with isolate = True).

The least-worst solution I can come up with that addresses the above is to have toolchains_llvm create repositories for all modules and to handle conflicts (in repo names) by choosing the tag that's closest to the root module (as rules_python does) and by warning users/nudging them towards isolate = True.
re: gating toolchain resolution for non-root modules: I'm not super convinced that we need to do this (my understanding is that toolchains registered by the root module/by modules closer to the root module have precedence in toolchain resolution; rules_python's reasoning for this restriction is here) but if we want to, it should be easy to emulate with :all patterns that potentially expand to nothing or by using the hub pattern that rules_python uses (unlike rules_python we don't provide a "default" toolchain in toolchains_llvm though).
@jsharpe @fmeum: WDYT?

Yeah, using dev_dependency=True is totally fair for a lot of use cases. If we want to keep the fail call then perhaps we should update the message to suggest this solution.
Based on your analysis, I believe it means that my change shouldn't be needed for simple cases, and doesn't solve the problem for more complex ones. Is that accurate?

I see two separate threads here:

Having one "official" way of using toolchains_llvm in a module that is also meant to be used by other modules.
Supporting transitive module's needs to access LLVM toolchains without the root module's support.

For 1., I think that we should stick to and recommend dev_dependency: It's built right into Bazel, which means that it works uniformly for all extensions without special support, and is also self-descriptive in that you can immediately tell a certain extension tag won't do anything if the module isn't the root module.
Keeping the fail but having its message suggest using dev_dependency is thus my favorite approach within the scope of this PR.
Dealing with 2. is much more difficult, which is why I would prefer to keep the fail until we have properly thought through the interactions around this. It likely entails moving away from user-supplied register_toolchains calls, as rules_python and rules_go have done. This does add a fair share of complexity though. isolate = True is also not a sufficient answer as it can result in linking the same library twice in different versions.
For tools such as clang-format, having a module register an LLVM C++ toolchain just to access it sounds overly complicated to me. We could offer a more lightweight way to achieve this (say by not registering the cc_toolchain, thus avoiding the problem of reconciling toolchain requirements) or direct such modules to accept a label pointing to clang-format as part of their configuration instead of bringing it in themselves.
I do lack the knowledge about OpenMP to assess what a good way would be to bring it in. Does it have be kept in sync with compiler versions?


[ENH] Changing function names in datatypes check to lower_snake_case

Reference
Tries to fix Issues #1817
What does this implement/fix? Explain your changes.
The pull request changes the names of the functions in datatypes to lower_snake_case.
Does your contribution introduce a new dependency? If yes, which one?
No it doesn't.
What should a reviewer concentrate their feedback on?
Please check whether the deprecation has been done properly. If there are any changes needed to be done for the same.
Any other comments?
--
PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Couldn't find any private functions in check that aren't in lower_snake_case.

As discussed, there are a couple in the sub-folders, the _check modules.
(just recording here summary of our slack discussion)

Thanks, looks good!
Before I merge this: can you confirm that none of these functions is referenced outside the datatypes module?

@fkiraly I had a look. And no. The functions aren't referenced outside datatypes.


Use remote HPO when running the notebooks

Use remote HPO when running the FBN1 notebooks and suggest downloading HPO from a remote URL in the documentation.
We need this functionality to run CI in pyphetools.
The PR, however, needs pyphetools to be released first, because the current pyphetools version does not allow using a URL, and the FBN1 notebooks would explode when running HpoParser, since HpoParser currently needs hp.json as an existing local file, and URL is not a local file.
Therefore, if using remote HPO sounds OK, we first must do the following, before accepting this PR:

merge the PR with the CI workflow in pyphetools that runs FBN1 notebooks here
release pyphetools with a new patch version
merge this PR and possibly update the FBN1 phenopackets for consistency.
update the target commit in the pyphetools notebook CI workflow, basically to fix the line 6 of the workflow:

@pnrobinson pls give me thumbs up if sounds good, or let me know if anything looks fishy. Thanks!

The current version of pyphetools does allow not indicating the URL and this will pull back the latest version of hp.json. The problem is that apparently on some systems there is an SSL error. Probably we need to document that the user will need to do this including https://cheapsslweb.com/blog/ssl-certificate-verify-failed-error-in-python.
This appears to be working on your machine, but I am guessing this is something that can go wrong on machines "out there" so we need to anticipate this problem?

@pnrobinson
After adding OntologyStore to hpo-toolkit==0.5.0, we can easily load the latest HPO (or a specific version) without unnecessary network traffic.
I updated few FBN1 notebooks to showcase the usage (e.g. cells 2..4 here).
I'd like to merge this PR to finalize setting up CI in pyphetools. The merge will update all the FBN1 notebooks AND the phenopackets. The changes in phenopackets include:

moving the time at last encounter to disease | onset time of  phenopackets are mainly the
update of timestamps
update of variation descriptor id

The changes are not a result of my work but arise from the other pyphetools updates.
Pls give me a :+1: if it looks good!

@ielis
Sorry, when I first saw this it was work in progress.
pyphetools can download remote hp.json, but AFAICS the problem is that with certain settings, hpotk fails.
Here are possible solutions:
https://support.chainstack.com/hc/en-us/articles/9117198436249-Common-SSL-Issues-on-Python-and-How-to-Fix-it
Some could be added to the notebooks, e.g.,
import ssl
ssl._create_default_https_context = ssl._create_unverified_context

possibly others could be added to hpotk, e.g.
import ssl
import certifi from urllib.request
import urlopen

request = "https://.../hp.json"
urlopen(request, context=ssl.create_default_context(cafile=certifi.where()))

(not tested)
but I would not think we need to change the code in phenopacket-store?

The SSL issue should be resolved in hpo-toolkit>0.5.0, however, I haven't had a chance to test it because never saw the SSL issue.

@ielis not sure where we are with this PR. There are some conflicts because I cleaned up the repo. Can we tidy up and merge? Also, it would be nice to have a default place to download the hp.json to

So this is running all of the notebooks with each release?

No, not in phenopacket-store but in pyphetools - the screenshot in the 1st PR post shows how pyphetools can use phenopacket-store in CI. This is ensure that the documentation is accurate - the notebooks are up to date. In other words, if we make a breaking change in pyphetools we should propagate the change across the notebooks to prevent users' frustration.

How will we know if there was an error?

The CI will fail if the notebook does not finish with exit status of 0.

The CI only runs FBN1 notebooks because running everything would take too long. However, we should consider adding a GitHub action that will run all the notebooks and package the phenopackets upon each phenopacket-store release. There are ways for doing that..


From python to js

Hi,
I love your job!  Thank you!
I tried the script this week and it works very well.
I am running the script through a nodejs server which creates a png and sends it to print.
Do you think it is possible to translate python to js using node-bluez ?

Thank your your great feedback. Happy to hear it works for you!
You should be easily able to port the Python code to JS or basically any other language. The only requirement is that the used bluetooth SDK supports serial data (RFCOMM).
The library you posted contains a nice example for serial BT communication.


Checksuming fails

It get killed while trying to get the checksums for server and client:
TASK [atosatto.minio : Get the Minio server checksum for amd64 architecture] ***********************************
objc[27057]: +[__NSCFConstantString initialize] may have been in progress in another thread when fork() was called.
objc[27057]: +[__NSCFConstantString initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
ERROR! A worker was found in a dead state

TASK [atosatto.minio : Get the Minio client checksum for amd64 architecture] **********************************************************************************************************************************
objc[27916]: +[__NSCFConstantString initialize] may have been in progress in another thread when fork() was called.
objc[27916]: +[__NSCFConstantString initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
ERROR! A worker was found in a dead state

This doesn’t look like Ansible but rather Python error. Can you try to export the following and try again?
export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES

I encountered this as well. Seems to be an issue with Ansible: https://github.com/ansible/ansible/issues/49207

This doesn’t look like Ansible but rather Python error. Can you try to export the following and try again?
export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES

Long time no see (I'm sorry!). Problem still exists, but the export helps. Thanks!


add new base workflow to block fixup commit merges

Using Git's feature of fixup commits is a good practice for pull requests. But all fixup commits must be always resolved first before merging the pull request finally. To ensure nobody can forget this, it is always very useful to have the continuous integration pipeline to verify this.
I'm completely open to rename the workflow from base to anything else. No strong opinion here. I thought about something like shared or so. 🤷🏾

Thanks @weilbith for submitting this.
As far as I understand, this action will only prevent a subset of "fixup" commits -- the ones that were done via git commit --fixup. I'm not sure if I ever saw those in our PRs -- I think fixup commits made in a regular git commit fashion are much more common, and there is no way to automate checking against those. In those cases, I typically tend to point that out during the review process.

@istankovic ofc it can only apply for "proper" fixup commits. The practice of developers to do "manual" fixup commits with messages like "improve function by pull request review" needs to be tackled on a different level and can barely be solved by a technical solution. One thing that could help is to force the usage of conventional commits (which are interesting in general) and an according linter to enforce this.

Yeah, I agree in general, though I'd be wary of being very strict about everything -- I think discussing why we should do certain things and not others is rather more useful in helping everyone understand and is in practice more pleasant. And yes, as you said, this is not a thing to be solved on a technical level.

Sounds good. This is not yet an actual open source project with a community. In such a case technical restrictions where possible are very helpful to have continuous quality guarantees without too much human management effort. But that is not (yet) the case. So talking in the team and making an agreement can be good enough.


Horizontal scroll on Resource view

I am using the resource view on react big calendar with 100 resources. how can i maintain the horizonal scrolling on clicking on any event? currently the calendar scroll back to the first resource position

to all the world struggling with horizontal scroll, just add overflow-x: auto;

or add width: 95vw to parent div

Have you managed to solve horizontal scrolling?
Scrolling itself works fine with grid, but with multiple resources with each re-render, it goes to start.

Add overflow-x: scroll  into .rbc-time-content and works just fine


Empty translations when rendering pages

Bug report: https://forum.getkirby.com/t/staticbuilder-kirby-as-a-static-site-generator/4084/26
So basically how the l::set and l::get system works in Kirby:

L::$data is an empty array.
On page load for multilang websites, Kirby identifies the current language from the URL (e.g. /fr/foo/bar) and loads the corresponding PHP file in site/languages/fr.php.
In this file, using the L class instead of the C class (c::set) is just convention. There's nothing special about it. It's a static class with an array and the get/set methods.

When rendering from /staticbuilder/, Kirby does not set the current language and does not load this language-specific config file. We then go to great lengths to set the page's language when rendering each version, but don't load those files either. Not sure what would be a decent solution. :/
Possible workaround, in e.g. site/snippets/header.php:
<?php
// make sure to load the translations
$langfile = $kirby->roots()->languages() . '/' . $site->language()->code() . '.php';
if (file_exists($langfile)) include_once $langfile;

The work around works!

Ref the workaround code above, I found that it only worked on the home/index page. To get it to work on sub pages I had to include rather than include_once.

Good catch, thanks.


feat: Automatically install and configure Keycloak SSO for Kubernetes platform (#312)

What type of PR is this?

/kind enhancement
/kind code-refactoring

What does this PR do / why we need it:

Automatically install and configure Keycloak SSO for Kubernetes platform. This is a followup PR for Automatically install and configure Keycloak SSO for OpenShift Platform.
This PR also refactors sso.go file. sso.go file should not hold any code related to keycloak, It should merely act as a hook or handler. So, all the keycloak related code is moved to keycloak.go. This will make on-boarding other SSO's easy.
Documentation.

Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[x] Documentation has been updated.

Which issue(s) this PR fixes:
#312
Fixes #?
#312
How to test changes / Special notes to the reviewer:

clone the repository and checkout the PR.
run operator-sdk run local
Follow the documentation docs/usage/keycloak/kubernetes.md

IMO, it is a bad descision to use Template to implement OS side of Kelycloak deployment. The only difference between OS and K8s is OS has OS Route. In the PR, OS and K8s implementations take two complete code paths. Now, we have two code path to test and maintain. It is already screaming very loud for refactoring.

Sure, the only other difference is the use of Deployment Config for OS and Deployment in Keycloak, I think there is no significant advantage of using Deployment Config as well.

IMO, it is a bad descision to use Template to implement OS side of Kelycloak deployment. The only difference between OS and K8s is OS has OS Route. In the PR, OS and K8s implementations take two complete code paths. Now, we have two code path to test and maintain. It is already screaming very loud for refactoring.

Sure, the only other difference is the use of Deployment Config for OS and Deployment in Keycloak, I think there is no significant advantage of using Deployment Config as well for this use-case.

@wtam2018 As discussed this will be taken in a different PR. We need to perform a spike to verify the feasibility of installing RHSSO(Keycloak for OpenShift) using deployments or stateful sets.

if there are no further review comments. This can be merged. Verified on both openshift and kubernetes :)
@jannfis

@wtam2018 @wtam2018 This PR is hung in here for a while now. Can you please approve and merge it ?


Adds github actions SVG, and renames to github-runner

Adding this SVG image as the charm's icon, and renaming from github-runner-operator to github-runner

Trying to get it to charmhub :)
will be published shortly under its new name


split data request from cmor csv table

for domain dependent data request, we will

[x] split main data request into table with priority colums (data-request/dreq_main.csv): from this table, we create a human readable xlsx, one sheet per priority, more human readable...
[x] remove priority colum from main cmor cvs table (cmor-table/datasets.csv): from this table, we will create cmor tables. It's kind of a basic database containing detailed meta data.
[x] make a check, that each out_name, frequency combination from any data request in data-request/*.csv is available in the datasets.csv table.
[x] add short description to README

Adding a new data request (for a certain domain) would start by copying the dreq_main.csv and modifying or extending it. If it is extended, a new entry in cmor-table/datasets.csv would probably be required (would be catched by the test).
Any data request can define their own priorities which are not going into cmor-table/datasets.csv.
Example of human readable xlsx derived from data-request/dreq_main.csv (one sheet per priority):
dreq_main.xlsx
Additional domain dependent data requests would go into data-request/dreq_{domain_id}.csv.
see also #36

@jesusff @gnikulin
I implemented here suggestions by @jesusff from #36. Once this is merged, i can add the tables with ocean variables. I think this is a good solution to make the data request independent from cmor tables and make it more humand readable...

Another couple of related points:

We already have a domain-specific (AFR) data request embedded in the main/default data request (search for Africa in the original https://github.com/WCRP-CORDEX/data-request-table/blob/c6603fb/CORDEX-CMIP6/data-request.csv). This simple case could be used for a test.
We might have an issue with the comments. These are dropped from the domain-specific CSV but they can be useful to explain the rationale for including a given variable or switching a priority. Currently, there are different uses for the comments. Namely:

Clarify the computation of the variable, as in CMIP. This is discussed in #20
Clarify the rationale for a variable being requested (e.g. "requested by CORDEX-Africa", "requested for urban modeling")
Warn of CORDEX-specific variables ("not in CMIP or in CF")
Track changes in the variable definitions ("long_name fixed, 2022.09.22")

* the _cell_method_ column in the domain-specific tables. Do we expect the same _out_name_ and _frequency_ requested with different cell_methods in different domains? that would be a nightmare. Or is it there just to remind "humans" of the expected aggregation for each variable? This column complicates the xlsx file with merged cells, but I assume you are trying to mimick the original excel DR, which included the **agg**regation flag (**i**, **a** codes)

The latter one, exactly. It's just useful to have the aggregation method in the table to make users think of it depending on the frequency (which they couldn't distinguise when creating the goodle spreadsheets). We could still translate it when creating the xlsx file into something like i or a. Nevertheless, in the original CORDEX data request, it was the most painful work to figure the cell methods out if it's not provided by the data request in case of new variable frequency combinations. The tests should capture cases when users want different cell methods than in the data request, also, if they use wrong standard names, units, or long names.

* the naming "main" for the general CORDEX table. We could maybe call it "default", as this would be the basic data request table, unless a particular domain defines their own.

Agreed, "default" seems to be a better description!

Another couple of related points:
* We already have a domain-specific (AFR) data request embedded in the main/default data request (search for Africa in the original https://github.com/WCRP-CORDEX/data-request-table/blob/c6603fb/CORDEX-CMIP6/data-request.csv). This simple case could be used for a test.

* We might have an issue with the comments. These are dropped from the domain-specific CSV but they can be useful to explain the rationale for including a given variable or switching a priority.

Ok, yes, these should be restored in the data request, but i think they don't neccessarily need to end up in the cmor table. In the cmor tables, i would prefer the comments to clarify the computation of the variable.

We already have a domain-specific (AFR) data request embedded in the main/default data request (search for Africa in the original https://github.com/WCRP-CORDEX/data-request-table/blob/c6603fb/CORDEX-CMIP6/data-request.csv). This simple case could be used for a test.

Done!

Ok, let's wait until @gnikulin can have a look at this!

@gnikulin i would like to go on with this PR so i can closes some more issue that depend on the new tables structure. Do you think this approach makes sense?


LowerBound and UpperBound were inverted

Shame. Fortunately, I sort them when use, so it didn't affect anything


Remove install-state.gz from tracking

According to this, we can remove this file safely:
".yarn/install-state.gz is an optimization file that you shouldn't ever have to commit. It simply stores the exact state of your project so that the next commands can boot without having to resolve your workspaces all over again."

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-1.azurewebsites.net


Add MyFTSO

Add MyFTSO

A few comments;

The icon is not centered in the image, please fix.
Please optimize the image with https://tinypng.com/.
You are currently using the same address for Flare and Songbird, the best practice and recommendation is to use separate addresses, however we can accept your current setup if you want.

Did all the requested changes. Thanks in advance.

Great! A side-effect is that you need to have a separate copy of the image with the new address in the URI, we require one image per address.

Sorry, just uploaded the requested file!


Adds support for catching multiple exception types from PHP 7.1

RFC

Rebased on master

I took the liberty of tacking on non-caputuring catches rfc since it's so related. Hope that's ok

Thanks!


#535 - Proxy traps not triggered for __lookupGetter and _lookupSetter

just need to call GetPrototype instead of GetPrototypeNoTrap in JavascriptOperators::GetAccessors

@Yongqu can you review?

:+1:

:shipit:


Removes deprecated warning on import turicreate

Python 2.7.16

Was this not part of the 5.8 release?

It was in the 5.8 branch but not in master. So I just added it.

On Oct 8, 2019, at 11:09 AM, Toby Roseman<EMAIL_ADDRESS>wrote:
Was this not part of the 5.8 release?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/apple/turicreate/pull/2394?email_source=notifications&email_token=ALM5MVVD4K6U6NSTVYHZYDDQNTEETA5CNFSM4I5GOUQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAVCYYQ#issuecomment-539634786, or mute the thread https://github.com/notifications/unsubscribe-auth/ALM5MVQMEO6OBTHVTP2XEXTQNTEETANCNFSM4I5GOUQQ.

@shreyajain17 - Great! Thanks for letting me know, and thanks for find and fixing this in the first place.
Perhaps in the in the future, it would be better to review and merge it into master. Then cherry-pick it into the release branch.

Yeah I agree.

On Oct 8, 2019, at 2:47 PM, Toby Roseman<EMAIL_ADDRESS>wrote:
@shreyajain17 https://github.com/shreyajain17 - Great! Thanks for letting me know, and thanks for find and fixing this in the first place.
Perhaps in the in the future, it would be better to review and merge it into master. Then cherry-pick it into the release branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apple/turicreate/pull/2394?email_source=notifications&email_token=ALM5MVRQM42R34URT6EY3WTQNT5YPA5CNFSM4I5GOUQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAVXEKY#issuecomment-539718187, or mute the thread https://github.com/notifications/unsubscribe-auth/ALM5MVUZOMWN3CQOMKXJSP3QNT5YPANCNFSM4I5GOUQQ.


[BUG] Event driven navigation in looping Pager

Describe the bug
When using a looping Pager, updating the Page element with .update(.next) works as intended until the last page, and then stops.
To Reproduce
import SwiftUI
import SwiftUIPager

struct SampleView: View {
    @ObservedObject var page1 = Page.first()
    var data = Array(0..<5)
    var body: some View {
        Pager(page: page1, data: data, id: \.self) { element in
            Text("\(element)")
                .frame(width: 300, height: 300)
                .background(Color.gray)
        }
        .onAppear {
            Timer.scheduledTimer(withTimeInterval: 2, repeats: true) {_ in
                withAnimation {
                    page1.update(.next)
                }
            }
        }
    }
}

Expected behavior
When it gets to the last page, I expect it to animate going the next page (the first one), like it would with user input.
Environment:

OS: iOS 14.7.1 (with support for 13.6)
Device:  iPhone SE 2020
SwiftUIPager version: 2.3.1

@louis1001 thanks for reporting. This should be easy to fix, I'll see if I can get some time for that.
The issue is here in case you wanted to raise a PR yourself. Page needs to know Pager is looping so that it returns the right index.
It might be more complicated than that but that's a start

Thanks!
I'll take a look at it.
My first impulse is to give Page a Pager? that it could check.


add new custom base image

to allow us to customize the base image, put a new Dockerfile containing the modifications hive wants so that this can be built by CI, and then used as hive's own base image

/lgtm


Add from community finden

Worked through several gluon-communities in
https://freifunk.net/wie-mache-ich-mit/community-finden/
Stopped adding them as I hit <100 clients per community

Let me rebase that real quick.

Yep, and please drop the Merge commit on the way


Initial release

Health-checker is designed to be a simple HTTP web server that attempts to connect to one or more ports via TCP when it receives an inbound HTTP request. For more info, see the README in this PR.
The only omission from this PR are automated tests, but those felt relatively cumbersome to write to in proportion to the confidence they built. Opinions on the value of tests, and if applicable, what type of tests would be suitable here are welcome.

I'm going to merge this now so I can make sure my CirlceCI config is working correctly, but feedback is very welcome, and I'll incorporate in a follow-up PR.


feat(proxy) frame size and fragment count limits

Notable Changes:

proxy: new client_max_frame_size/upstream_max_frame_size option (applies to singular and aggregated frames) limits frame size
proxy: new client_max_fragments/upstream_max_fragments option limits the number of buffered fragments
tests: added a repeat query arg to the server fixtures that causes the server to loop until calls to recv_frame() time out or return a close frame (~might be okay to make this the default behavior~ nope, it breaks tests)

Both of the limits cause a close frame with status 1009 and reason Payload Too Large (copied from HTTP 413) to be sent to the source of the offending frame. The peer websocket is sent a 1001 ("going away") close frame with no payload. These things are hard-coded now but can be made configurable if desired.
Closes #10

@eskibars this limit targets both the client and upstream equally for limits. Do you know if this is sufficient for $client's use-case, or do we need individual limits (one for the client, another for the upstream) additionally/instead?

Probably makes sense to split this into distinct client/upstream limits, because I think a common use case will be to limit the size of inbound messages from the client while leaving the server unrestricted.

I've split the options into client/upstream.

Probably makes sense to split this into distinct client/upstream limits, because I think a common use case will be to limit the size of inbound messages from the client while leaving the server unrestricted.

+1.  I think we need separate limits


git remote get-url origin fails with Git <2.7

This command isn't available with git <2.7: https://stackoverflow.com/questions/4089430/how-can-i-determine-the-url-that-a-local-git-repository-was-originally-cloned-fr
Failed on my machine, updated Git, works great. But I'm using Netlify and it looks like their build system is also using an older Git version. I'll let them know but I guess they won't be able to update it soon. Could you use a more compatible command like git config --get remote.origin.url?
Thanks.

Thanks for letting me know, I'll sort out a fix within the next hour! 😊

I've just published v0.1.2 now. If you update, all should be working :)
Thank you for your patience!

That was quick, thanks!


[MOB-1604] revise service extension to be reactive

🔹 JIRA Ticket(s) if any

MOB-1604

✏ Description

revises the notification service extension to not faultily trigger
refactored to avoid giant singular functions
added/integrated last attempt and/or failure cases

Sending back to WIP!

This looks good to me. But please wait for @vbabenkoru to approve before merging.
Also, hopefully you have tested the following scenarios.

Multiple buttons including delete and text type.
Rich media url.

@vbabenkoru since you did the initial implementation please take a second look. Thanks!

Moving this to [WIP] since I ran into a discrepancy between what the current unit tests check for and manual testing cases. It needs a little more investigation to determine the EXACT correction to make.


Failover remote ssh relaylogs

This PR introduces multi-replicas syncing via relay logs, to eventually be invoked by failover logic.
Syncing is done by remote SSH, if configured so.
related:

https://github.com/github/orchestrator/pull/42
https://github.com/github/orchestrator/pull/32

At this time master failover based on relay log syncing over SSH is working.

I'm merging this for now, and will further iterate in a next PR. Functionality is in place and is mostly tested to work well.
There are various potential optimizations and configurations I would like to consider while further working with the merged PR.


new api.namespaces settings

part of: https://github.com/kiali/kiali/issues/5516

A quick test to make sure nothing broke - run the molecule test that exercises the label selector (now label_selector_include)

Install minikube and Istio
make -e CLUSTER_TYPE=minikube -e MOLECULE_SCENARIO="accessible-namespaces-test" -e MOLECULE_USE_DEV_IMAGES="true" build build-ui cluster-push molecule-test

That test should pass.

all tests pass on minikube and openshift (see https://github.com/kiali/kiali/pull/5521#issuecomment-1271713489) so this is good to go.


No proper README.md Structure

Issue Description
The README.md file is not properly structured and it's missing the tech stack, screenshots and important links to code of conduct and contributing.md files.
Steps to reproduce
Update the README.md file to a proper structure, add the tech stack, screenshots and important links
Labels
Gssoc 24
Priority
High

@Anishkagupta04 I have prepared a proper README.md file for Rapiddoc Healthcare Website,  it would be great if you assign me this issue.
I will push the changes right away.

@Anishkagupta04 I want to work upon this, it would be great if you assign me this issue.

@Anishkagupta04 please add the labels for gssoc and issue level so that the project gets verified


Problem with Keras application model when used with ThreadPoolExecutor().

System information

Have I written custom code (as opposed to using example directory):  yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  19.04
TensorFlow backend (yes / no):  yes
TensorFlow version:  2.0
Keras version:  2.3.1
Python version: 3.7
CUDA/cuDNN version:  N/A
GPU model and memory:  N/A

Describe the current behavior
I am trying to extract image features using Keras application models. For fast processing, I used this method with python ThreadPoolExexutor().
with ThreadPoolExecutor(1) as executor:
results = executor.map(feat.feature_cnn, links)
when I tried to access results (Generator Type)
for result in results:
print(result)
Output:
Traceback (most recent call last):
File "test.py", line 34, in
for item in results:
File "/usr/lib/python3.7/concurrent/futures/_base.py", line 598, in result_iterator
yield fs.pop().result()
File "/usr/lib/python3.7/concurrent/futures/_base.py", line 428, in result
return self.__get_result()
File "/usr/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/home/ismaeel/Desktop/DuplicationTool/DuplicationTool/Descriptor/Feature.py", line 26, in feature_cnn
feat = self.model.predict(img)
File "/home/ismaeel/Desktop/DuplicationTool/DuplicationTool/toolenv/lib/python3.7/site-packages/Keras-2.3.1-py3.7.egg/keras/engine/training.py", line 1452, in predict
if self._uses_dynamic_learning_phase():
File "/home/ismaeel/Desktop/DuplicationTool/DuplicationTool/toolenv/lib/python3.7/site-packages/Keras-2.3.1-py3.7.egg/keras/engine/training.py", line 382, in _uses_dynamic_learning_phase
not isinstance(K.learning_phase(), int))
File "/home/ismaeel/Desktop/DuplicationTool/DuplicationTool/toolenv/lib/python3.7/site-packages/Keras-2.3.1-py3.7.egg/keras/backend/tensorflow_backend.py", line 73, in symbolic_fn_wrapper
if _SYMBOLIC_SCOPE.value:
AttributeError: '_thread._local' object has no attribute 'value'
Describe the expected behavior
It should display the features of images
Code to reproduce the issue
feature.py
import numpy as np
from numpy import linalg as LA
import urllib

from keras.applications.inception_v3 import InceptionV3
from keras.preprocessing.image import image
from keras.applications.inception_v3 import preprocess_input

class Feature:

    def __init__(self):

        self.input_shape = (224, 224, 3) # CNN Input 512 feature vector length
        self.weight = 'imagenet'
        self.pooling = 'max'
        self.model = InceptionV3(weights = self.weight, input_shape = (self.input_shape[0],
                        self.input_shape[1], self.input_shape[2]), pooling = self.pooling, include_top = False)

    def feature_cnn(self, imagelink):

        img = image.load_img(imagelink, target_size=(self.input_shape[0], self.input_shape[1]))
        img = image.img_to_array(img)
        img = np.expand_dims(img, axis=0)
        img = preprocess_input(img)
        feat = self.model.predict(img)
        norm_feat = feat[0]/LA.norm(feat[0])
        return norm_feat

test.py
from concurrent.futures import ThreadPoolExecutor
from Descriptor.Feature import Feature

feat = Feature()

image = 'airplane.png'

links = [image, image, image, image, image, image, image, image, image, image, image, image, image, image, image]

with ThreadPoolExecutor(1) as executor:
    results = executor.map(feat.feature_cnn, links)

for item in results:
    print(item)

.

Same issue. I am trying to train a model in QThread(multi-thread with PyQt5), and I got
File "D:\Anaconda3\lib\site-packages\keras\backend\tensorflow_backend.py", line 73, in symbolic_fn_wrapper
   if _SYMBOLIC_SCOPE.value:
AttributeError: '_thread._local' object has no attribute 'value'

If I downgrade tensorflow to 1.14, It works well.

TensorFlow backend (yes / no): yes
TensorFlow version: 2.0(cpu)
Keras version: 2.3.1
Python version: 3.7

How to fix it?. @Dref360 @fchollet

Dear sir, please do not close this issue. I think this issue still exist with tensorflow2.0 backend@ismaeelnawaz


item not a widget

I have only one OpenHab item in my json config file (though many more in openhab).  This item is a relay switch connected to a raspberry pi that works well in OpenHab (it uses a rules to execute bash commands to turn on and off the relay).  When I run Homebridge, Homebridge seems to fetch the OpenHab devices and connects to the sitemap without error, but when it loads accessories, this error appears 8 times:
   [openHAB] Platform - The widget ' ' is not an item.

Homebridge then reports it is running, and I can use the MiLight Platform and accessories, but there is nothing there for Openhab.  I am not sure how to address this.  Any help would be appriciated.
BTW - I will eventually try to connect to my Zigbee and Z-wave devices that are controlled by a rooted Wink Hub via Bash commands executed with OpenHab rules.  Most of these items are Number items with Rules controlling Bash commands telling the Wink Hub what to do. If there is more I need to know to continue with this approach, that would also be appriciated.

I also got this error with the widget name of space, and also got errors for every Frame and Group name in my sitemap.  The homebridge-openHAB parser seems to have difficulty with items that are defined inside Frame {} or Group {} blocks, which for me is everything.  Homebridge wasn't seeing any of my 30+ items. My solution was pull out all the items from my default sitemap and make a homebridge.sitemap file that just contained the items without any framing or grouping.

Thanks,
That approach would seem to render the OpenHab interface useless.  Am I wrong on that, or is it possible to use 2 sitemaps with openhab?  I still have very much on OpenHab that will never be used with Homebridge.
BTW - I think I found a work-around by using the Homebridge-AppleScript add-on to execute my bash scripts instead of trying to get them executed through OpenHab.

Useless? Not at all. OpenHAB supports multiple sitemaps, the default being default.sitemap.  You might use multiple sitemaps for different buildings (sites), or have a sitemap for testing.  Or, in my case, a sitemap that I tell Homebridge to use.  See the OpenHAB docs on how to specify alternate sitemaps. The only (minor) annoyance is having to touch two files (one for OpenHAB, one for Homebridge) when I add items to my Zwave network, but that's minor price to pay for having HomeKit integration.

Indeed homekitbridge only supports a flat sitemap. so an additional sitemap has to be created. Which makes perfect sense given that openhab can do a lot more than homekitbridge (at least at the moment)

Now from this version (0.1.21) the plugin supports every type of sitemap. I have added a new option "skipItem" in customAttr to avoid load item in Homekit catalog, let me know if it works.

Initially none of the items from my default openHAB sitemap were recognized. With this update, basically all were added to the iOS apps, even though I had not entered their characteristics in config.json.

Yes! All the items of the selected sitemap are loaded by default. If you want to skip an item You should add the item's name and the relative skipItem attribute to true in customAttr section.


Call Variants in "Ambiguous" assigned reads

It is possible that mutations in highly conserved regions between human and mouse are not included in our final VCF file. Reads with these variants are likely to be assigned to "ambiguous" from ngs_disambiguate
As @huqiwen0313 noted in #24:

The reason I think these regions would be interesting is if variants appear in the conserved regions, they are more likely to be functionally related. I did not see a database list all of the cancer-associated variance in the conserved regions, but there are some related papers (e.g. https://www.nature.com/articles/srep22124, https://www.ncbi.nlm.nih.gov/pmc/articles/PMC3919555/).

It will be good to run all downstream steps in the ambiguous sets as was performed with human.

I will close this issue for now, but consider revisiting if deemed necessary in the future. Currently, only a small proportion of reads were mapped ambiguous


Fix script type in lib/softcover/builders/utils/page.js

x-mathjax-config is only for MathJax settings, we need a generic script/javascript in order to run the Hub.Queue command.
Fixes  https://github.com/softcover/softcover/issues/127  for me.

Thanks for the contribution. The use of x-mathjax-config is taken directly from the MathJax documentation, so I think it's right, and it works fine on all systems I know of. Also, the given pull request includes a bunch of debug puts statements; if you're sure of these changes and want to re-submit them, please make a commit removing any unnecessary calls to puts.


Show all loaded recordings as tabs

When you have loaded more than one recording, show them all as tabs instead of hiding them under the Rerun menu.
The current hiding of them makes it difficult to discover that there are many recordings open, and makes it difficult to switch between them to compare.
Having them all as tabs lets you quickly switch between and compare them, and we can even allow docking them to compare side-by-side.

Closing in favor of:

https://github.com/rerun-io/rerun/issues/2298


Send identification data with error reports

That way we can get data about the user when we receive support feedback.

Investigation revealed we do this already.


remove print statements

Is your feature request related to a problem? Please describe.
There are some print statements which fill the logs in tools like homeassistant when pyasic is used
Describe the solution you'd like
no print statements
Additional context
Found this one: https://github.com/UpstreamData/pyasic/blob/e1500bb75c9d365d33b5606cb55a06ca7cd4ef18/pyasic/web/bosminer.py#L149C1-L150
but there might also be others

Removed those, just forgot some of those.  I'll work on your other issue and see what I can do there, then I'll release a version with the fixes.

Done in 0.36.5


yes ive read the other "" posts on here and yes its related to all media it seems, i can confirm that audio messages dont display either and the bubble with "". hope you have time and add all the media support.

@nionby It looks like it is fixed in the latest version, isn't it? At least I remember there was one version where I was able to play audio.


Get-CsUserPstnSettingsm, Add Attribute handling

Received Message (No Attribute handling):
Get-CsUserPstnSettings

Cannot display the prompt for "Identity" because type "Microsoft.Rtc.Management.AD.UserIdParameter" cannot be loaded.

Expected Message:
Get-CsUserPstnSettings

cmdlet Get-CsUserPstnSettings command pipeline position 1
Supply values for the following parameters:
Identity:

Workaround
Get-CsUserPstnSettings -Identity [Username]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4adcb580-485c-47f2-990f-a4ec1c5fcc89
Version Independent ID: 40d62681-94d6-727a-4c57-8c42f1b4b1d8
Content: Get-CsUserPstnSettings (SkypeForBusiness)
Content Source: skype/skype-ps/skype/Get-CsUserPstnSettings.md
Service: skypeforbusiness-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

Hi @weyCC81, thank you for your feedback.
I've tested it with the latest version of the Teams PowerShell Module (3.0.0) and it works:

@dariomws Thank you very much for the contribution and sharing this explanation. @weyCC81 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


FAQ refers to information not present

Describe the bug
At https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/blob/850e2051e9f29b30064c43fdd5a60b0122a74188/_docs/faq.md#i-have-sensors-that-are-missing the answer says that information on enabling more logging is above. I suspect it is referencing another FAQ entry that is actually below it.
Reproduction steps
Go to the URL provided
Expected behaviour
Logging information is linked rather than referred to by position
Tariff Code
N/A
Integration Version
N/A
Home Assistant Version
N/A
Fresh Install?
Not specified
Home Assistant Logs
N/A

Thanks for bringing this to my attention. This has now been resolved.


Fix UI cluster closing issues while using text based filtering

Fix the issue on the UI when using text filtering neither the close all button nor the clusters itself couldn't open and close the clusters correctly.

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.22%. Comparing base (d3e7731) to head (c1a8498).
Report is 1 commits behind head on master.

Files
Patch %
Lines

src/store/zap/mutations.js
0.00%
3 Missing :warning:

src/components/ZclClusterManager.vue
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   65.20%   65.22%   +0.01%
==========================================
  Files         188      188
  Lines       19792    19792
  Branches     4231     4233       +2
==========================================
+ Hits        12906    12909       +3
+ Misses       6886     6883       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Benjamin Bezzeg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


test armhf

@homunkulus r+

:pushpin: Commit 8d0ce7f has been approved by japaric

:hourglass: Testing commit 8d0ce7f with merge 8d0ce7f...

:broken_heart: Test failed - status-travis

@homunkulus r+

:pushpin: Commit 296219b has been approved by japaric

:hourglass: Testing commit 296219b with merge 296219b...

:broken_heart: Test failed - status-travis

:pushpin: Commit 9481f75 has been approved by japaric

@homunkulus r+

:hourglass: Testing commit 9481f75 with merge 9481f75...

:broken_heart: Test failed - status-travis

@homunkulus r+

:pushpin: Commit 6185f6a has been approved by japaric

:hourglass: Testing commit 6185f6a with merge 6185f6a...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing 6185f6a3bd4fe7dac00758255d0f38da97479725 to master...


Implemented diagnostic for SA1214: StaticReadonlyElementsMustAppearBeforeStaticNonReadonlyElements

Fixes #74.

I made several notes in the diff. Before you make the changes, you should think about the following as well (which you may or may not use, but either way it's good to think about).
An alternative implementation could use a single forward pass through the FieldDeclarationSyntax members of the type, and have a single state variable foundStaticNonReadonlyField. When this state variable is true and a static readonly field is encountered, report a warning. When you reach the end of the members, you are done. This works because the members are enumerated in lexigraphical order.

Thanks @sharwell . I will fix it soon.

No problem. Also, I was tougher on this than I normally am. I try to do that every once in a while to keep people thinking outside the box. :smile: You should know that all of the work you've done for this project is very much appreciated. :tada:

No problem. Good feedback is a very valuable feedback, If I make some errors/bad desgins, it's always good if someone points them out to me. That's the best way to avoid them in future.

In addition to the items marked in the diff, I made the following changes while merging this:

Use AnalyzerConstants.EnabledByDefault
Use .ConfigureAwait(false) when awaiting a Task
Rename asynchronous methods to include the Async suffix


Include back locking load test for aarch64 linux

Signed-off-by: Mesbah<EMAIL_ADDRESS>

Test passing 5x grinder with latest jdk11 aarch64 linux build: https://ci.adoptopenjdk.net/view/work in progress/job/Grinder/250/


add design code icons

when i switch from house layer to design-code layer at first icons appear and only after that houses' colors disappear. it seems that it would be better to do it reversely but i am not sure that it is possible to adjust such behaviour


[CROSSDATA-279] [CORE] Create External Table Base

Once the change suggested by @darroyocazorla had been committed, :+1:

+1

+1


Read an array from a HDF5 file in one step

Currently in order to read an array from a HDF5 file we need to do:
metadata:
  grid_x_extents: { type: array, subtype: int64, size: 1 }
  grid_x:
    type: array
    subtype: double
    size: [ '$grid_x_extents[0]' ]
plugins:
  decl_hdf5:
    - file: 'my_file.h5'
      on_event: [read_grid_x_extents]
      read:
        grid_x_extents: {size_of: grid_x}
    - file: 'my_file.h5'
      on_event: [read_grid_x]
      read:
        grid_x: ~

    std::vector<size_t> n_points(1);
    PDI_multi_expose(
            "read_grid_extents",
            "grid_extents",
            n_points.data(),
            PDI_INOUT,
            NULL);

    std::vector<Coord1D> mesh(n_points[0]);
    PDI_multi_expose(
            "read_grid",
            "grid",
            mesh.data(),
            PDI_INOUT,
            NULL);

The step with n_points seems excessive. Would it be possible to read the array in one step, e.g.:
metadata:
  grid_x_extents: { type: array, subtype: int64, size: 1 }
  grid_x:
    type: array
    subtype: double
    size: [ '$grid_x_extents[0]' ]
plugins:
  decl_hdf5:
    - file: 'my_file.h5'
      on_event: [read_grid_x]
      read:
        grid_x: ~

    Coord1D* mesh;
    PDI_multi_expose(
            "read_grid",
            "grid",
            mesh,
            PDI_INOUT,
            NULL);

This would be even better if a C++ argument could be passed in place of the pointer

You would like PDI to allocate the memory for you? This opens the question of which allocator to use. But definitely something that would make sense to offer our users. Thanks for the idea.


Terraform fails for depends_on and list("string") cases

Hello.
hcl2json works nice, but there are some cases that after conversion don't work.
Here you can see a list of fixtures used for different converter.
Passing of those tests almost garanties that json file will be executable and valid for terraform.
Terraform init/plan fails for at least two cases. depens_on(depends_on.hcl) case and type case.
Depends_on case has to be without interpolation.
In case of type - interpolation don't has to present as well. type is reserved key for variables.
Example :
variable "availability_zones" {
  type    = list(string)
  default = ["az1", "az2", "az3"]
}

Thank you.

I believe this is hitting a known limitation of hcl2json. From the README:

Note, however, that there are some corner cases where it may not be exactly equivalent, especially if the target application makes use of static analysis.

Both depends_on and type use static analysis in terraform.
Solving this would require hcl2json to know the schema of the target application. I'm not opposed to having some way to supply a schema to hcl2json to handle this case, but I don't currently have the time to design and implement this. Pull requests welcome though :). Having a schema available would also make going in the revers direction (json to hcl) possible.
My biggest question is, what would the schema file look like? Right now, schemas are typically defined exclusively using go code in the application itself, but for this use case it would be better to have a separate file (json, or maybe hcl?) that specifies the schema, preferable in a format that is general enough it could be used by other tools, not just hcl2json.


Add a tool resource for web development

Currently there are only few tools for web development. You task is to find resource that you think is helpful and worth sharing with anyone.
Please make sure that you read the Contributing guidelines before raising a pr

@jfmartinz I want to work on this issue, Can you please assign this to me sir/ma'am?

Can I be assigned this?

Thank you @jfmartinz.

No problem @RitaDee.


[Issue]Field immutable, When using [Expandable] and [ShowIf]

[CreateAssetMenu(fileName = "NewObj", menuName = "ScriptableObjects/Test_Expandable1")]
    public class Test_Expandable1 : ScriptableObject
    {
        public enum AAA
        {
            A,
            B,
            C
        }

        public AAA a;// When a is equal to AAA.A, a cannot be changed
        [ShowIf("isA")]
        [Expandable]// Comment this line, then a can be changed
        public Test_Expandable2 d;
        public bool isA => a == AAA.A;
    }

Unity Version : 2021.2.10f1
NaughtyAttributes Version : 2.1.1
OS : Windows 10

Update to 2.1.2. I just merged a PR that fixes it - #295


SkyFloatingLabelTextField.framework: required code signature missing

I am unsure if this is a bug or local issue.  I am positing it here to see if anyone else is experiencing the same problem.
I had a fully working project with no problems.  I then recently upgraded to the latest version of SkyFloatingLabelTextField (v3.4.1) and also upgraded Cocoapods (v1.5.0) and I am now getting a strange error in the storyboard editor.

file:///..../Base.lproj/Main.storyboard: error: IB Designables: Failed to render and update auto layout status for LoginViewController (WxM-Yi-A5J): dlopen(SkyFloatingLabelTextField.framework, 1): no suitable image found.  Did find:
SkyFloatingLabelTextField.framework: required code signature missing for 'SkyFloatingLabelTextField.framework'

I have tried uninstalling the SkyFloatingLabelTextField cocoapod and then reinstalling it with no change
The app runs fine in the simulator, the storyboard editor is unusable since it renders the SkyFloatingLabelTextField in strange positions.
Xcode Version: 9.3
SkyFloatingLabelTextField Version: 3.4.1
Deployment Target:  11.2
Base SDK: 11.3
Method of Integration: CocoaPods
Any advice would be greatly appreciated.

+1

+1

+1

+1

Hey everyone. That doesn't sound too good. Does reverting to 3.4.0 solve the issue for the time being. I'll have a look at what changed between 3.4.1 and 3.4.0, but my hunch is that nothing changed which would cause this.

I had a look and there's nothing in 3.4.1 that I think would have caused this. Can everyone please try this https://stackoverflow.com/questions/40110392/required-code-signature-missing-for-a-library. Also please refrain from +1 comments as they make the thread hard to read, use reactions instead.

Thank you @k0nserv
I'll use reactions next time
I went through solutions in the link but couldn't find _CodeSignature folder in SkyFloatingLabelTextField.framework in finder

No, rolling back to 3.4.0 does not fix the issue.  Could it be an incompatibility with Cocoapods 1.5? I noticed it has some updates for static libraries that maybe causing this issue? http://blog.cocoapods.org/CocoaPods-1.5.0/

@bludginozzie That's a possibility for sure. I'll have to have a look and see if there are any actions for library authors under 1.5.0

Thank you, the workaround works great.

I also have this same issue when integrating via Carthage the log file points to the .swiftlint.yml file and when I try to build manually I have to comment out that script to get it to build.

@merlin910 I'm not quite sure how to disable custom scripts when Carthage is used.

the error was gone after i paste the below code in my pod file. and install the pod once again.

Workaround for Cocoapods issue #7606

post_install do |installer|
installer.pods_project.build_configurations.each do |config|
config.build_settings.delete('CODE_SIGNING_ALLOWED')
config.build_settings.delete('CODE_SIGNING_REQUIRED')
end
end


Fix empty IP for backend when dnsrr in Docker swarm mode

What does this PR do?
Fixes #1494
Currently we don't manage DNSRR resolution mode in Docker swarm mode. This PR only excludes services with DNSRR resolution mode.
We will try to implement DNSRR resolution mode in Docker swarm mode ASAP
More

[x] Added/updated tests

We will try to implement DNSRR resolution mode in Docker swarm mode ASAP

is there an issue being tracked for this work?

Looks like the problem still exists - 1.5.2 and Docker Swarm:
deploy@www3:~$ sudo sudo ./traefik  -c traefik.sample.toml
INFO[2018-02-16T03:14:50+01:00] Using TOML configuration file /home/deploy/traefik.sample.toml
WARN[2018-02-16T03:14:50+01:00] web provider configuration is deprecated, you should use these options : api, rest provider, ping and metrics
WARN[2018-02-16T03:14:50+01:00] web option is ignored if you use it with one of these options : api, rest provider, ping or metrics
INFO[2018-02-16T03:14:50+01:00] Traefik version v1.5.2 built on 2018-02-12_10:55:08AM
...
DEBU[2018-02-16T03:14:50+01:00] Validation of load balancer method for backend backend-nginx failed: invalid load-balancing method ''. Using default method wrr.
DEBU[2018-02-16T03:14:50+01:00] Configuration received from provider docker: {"backends":{"backend-nginx":{"servers":{"server-nginx-1":{"url":"http://:80","weight":0},"server-nginx-2":{"url":"http://:80","weight":0},"server-nginx-3":{"url":"http://:80","weight":0},"server-nginx-4":{"url":"http://:80","weight":0}},"loadBalancer":{"method":"wrr"}}},"frontends":{"frontend-Host-test-test-nl-0":{"entryPoints":["http"],"backend":"backend-nginx","routes":{"route-frontend-Host-test-test-nl-0":{"rule":"Host:test.test.nl"}},"passHostHeader":true,"priority":0,"basicAuth":[]}}}
DEBU[2018-02-16T03:14:50+01:00] Creating frontend frontend-Host-test-test-nl-0
DEBU[2018-02-16T03:14:50+01:00] Wiring frontend frontend-Host-test-test-nl-0 to entryPoint http
DEBU[2018-02-16T03:14:50+01:00] Creating route route-frontend-Host-test-test-nl-0 Host:test.test.nl
DEBU[2018-02-16T03:14:50+01:00] Creating backend backend-nginx
DEBU[2018-02-16T03:14:50+01:00] Creating load-balancer wrr
DEBU[2018-02-16T03:14:50+01:00] Creating server server-nginx-4 at http://:80 with weight 0
DEBU[2018-02-16T03:14:50+01:00] Creating server server-nginx-2 at http://:80 with weight 0
DEBU[2018-02-16T03:14:50+01:00] Creating server server-nginx-3 at http://:80 with weight 0
DEBU[2018-02-16T03:14:50+01:00] Creating server server-nginx-1 at http://:80 with weight 0

And on the docker side:
deploy@www3:~$ sudo docker service inspect nginx
[
    {
...
            "EndpointSpec": {
                "Mode": "dnsrr"
            }
        },
...
    }
]

Hi @caseycs,
Could you open a new issue with a detailed configuration please ?

Træfik configuration
Compose file with your stack

@mmatur thanks, I tried to make it as clear as I can: https://github.com/containous/traefik/issues/2869


Add more flexibility for distance and tolerance measurements

This PR adds a new DistanceMeasurement option to the preexisting DistanceConstraint and DelayConstraint constraints.
export type DistanceMeasurement =
  | number
  | Coordinates
  | CoordinatesX
  | CoordinatesY;

interface DistanceConstraint {
  distance: DistanceMeasurement;
}

interface DelayConstraint {
  delay: number;
  tolerance: DistanceMeasurement;
}

The goal of this option is to let a user specify which axis, x, y or both (xy) the activation distance, or tolerance should be measured on.
This option is useful for drag and drop contexts that are restricted to a single axis.
Example usage:
const sensors = useSensors(
  useSensor(PointerSensor, {
    activationConstraint: {
      distance: { y: 7 },
    },
  }),
  useSensor(KeyboardSensor, {
    coordinateGetter: sortableKeyboardCoordinates,
  }),
);

An alternate solution could be to allow distance as an object, e.g. distance: { x?: number, y?: number }
But it's up to you 🙂

@clauderic I haven't been able to test this locally, I ran into hook issues when linking the package.
Please let me know if you have any trouble or concerns with the change. It would be great if we could get this, or something similar working.

@clauderic Thanks for jumping into the PR, I've added some test cases in https://github.com/clauderic/dnd-kit/pull/171/commits/c60600011205073c051eaaa01c3154299b73c799

This has shipped in version 2.1.0 of @dnd-kit/core, thanks again for your contribution

Thanks for the quick turn around @clauderic!


If local.properties is a symbolic link it is rewritten to a copy of the file

probably by maven when setting compilation time

not maven itself; but makefile touches the file https://github.com/ufal/lindat-dspace/blob/lindat/utilities/project_helpers/scripts/makefile#L178


Inconsistent implementation about when the validation of job's spec failed

In below codes, when validate the job's spec failed, the process is different. The MPIJob will return an err, so the MPIJob will not continue to creating corresponding pods/services, it will try again after some time. The PytorchJob/TFJob will just print an error log then continue, but it maybe cause unexpected results in the future.
I think we need to discuss what exactly we should do when we validate job's spec failed then we apply it to all Jobs. In my opinion, it should not continue after validating job's spec failed, and we not only to print error log, but also need to record a warning event so that users can know why their Job is blocking through kubectl describe XXJob.
Referring to point4 of https://github.com/kubeflow/training-operator/issues/1703
https://github.com/kubeflow/training-operator/blob/82af677072bfae01099439d587f2791eb41c08d1/pkg/controller.v1/mpi/mpijob_controller.go#L135-L138
https://github.com/kubeflow/training-operator/blob/82af677072bfae01099439d587f2791eb41c08d1/pkg/controller.v1/pytorch/pytorchjob_controller.go#L133-L135
https://github.com/kubeflow/training-operator/blob/82af677072bfae01099439d587f2791eb41c08d1/pkg/controller.v1/tensorflow/tfjob_controller.go#L158-L160

Thanks for reporting.
Yes. we should not continue if validation fails. Also, recording a warning event is a great idea. Can you fix this?

/cc @gaocegege @terrytangyuan

Yes, I think MPI controller is doing it correctly.

@terrytangyuan Since error is returned when Validation fails in MPI,  reconcile function will be called again.

It looks like not to complete this issue.
/reopen

/lifecycle frozen


⚠ GitLab Server has degraded performance

In ab91371, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11961 ms

Resolved: GitLab Server performance has improved in d4354ca.


python311Packages.ipython: 8.4.0 -> 8.11.0

python311Packages.ipython: 8.4.0 -> 8.11.0

Release: https://github.com/ipython/ipython/releases/tag/8.11.0

(Note: It targets staging because this package is broken for Python 310 there.)
Found this building:

cmake-language-server

python3.10-orjson

python3.10-ipython

(Will provide more info soon.)

@ofborg eval

At nixpkgs repository, I have executed:

editorconfig-checker pkgs/development/python-modules/ipython/default.nix

Any idea of why it is failing?

Thanks @marsam !


Something happen with 1.1.4

My ACNH Version is 1.1.4.
After I  spawn item, the bag I choosen been cleared. and Item is not been spawed.
Thank you very much for everything you have done!

In order to help you, more details are required.
Because the editor works just fine with ACNH 1.1.4a.

Which firmware version are you using?
Which sys-botbase version are you using?
Which CFW are you using?
Can you see your whole inventory once connected?

firmware is 9.2.0
sys-botbase version is 1.4
CFW is 0.10.5
Can see whole inventory once connected. Just spawn item cannot see on switchACNH.
Maybe sys-botbase is not tested on Atmosphere (0.10.5). Maybe is I need to wait for update.

Big thank for your help.

Try using this build of sys-botbase:
https://github.com/olliz0r/sys-botbase/files/4472143/exefs.zip
This seems to fix issues with Atmosphere 0.10.5.
Just replace your sys-botbase exefs.nsp with the one from the archive.


Add camera and no image

when I am doing RL, I add a camea and rander it but i can not get a image , code below:
self.cam = self.scene.add_camera(model='pinhole',
                                         res=(640, 480),
                                         pos=(0,0,1),
                                         lookat=(5,0,1),
                                         fov = 40,
                                         GUI=True)
        self.scene.build(n_envs= self.num_envs)
        # self.cam_pos = self.Piper.get_links_pos()[:, self.Piper.get_link('link6').idx - 1].cpu().numpy()
        # for i in range(self.num_envs):
        #     single_cam_pos = self.Piper.get_links_pos()[i, self.Piper.get_link('link6').idx - 1].cpu().numpy()
        #     self.cam.set_pose(pos=single_cam_pos)
        cv2.waitKey(1)
        self.cam.render()

How to solve it?

waitkey(1) should be after render().
Could you check the variables returned by render() and see if it's meaingful?

waitkey(1) should be after render().
Could you check the variables returned by render() and see if it's meaingful?

I have tried but it also don not work , render() return a 4 length tuple and the first element seems meaningful with shape (320,320,3) but also nothing to see


Update cert chain summary output to include the 'Not Before' value also

Currently the 'Not After' value is exposed as the Expiration value in the summary output.
Example from checking github.com via the lscert tool:
$ lscert --server github.com

Connecting to remote server "github.com" at port 443

=============================
CERTIFICATES | AGE THRESHOLDS
=============================

- WARNING:      Expires before 2020-12-05 15:42:50 +0000 UTC (30 days)
- CRITICAL:     Expires before 2020-11-20 15:42:50 +0000 UTC (15 days)

======================
CERTIFICATES | SUMMARY
======================

- OK: 2 certs found for service running on github.com at port 443
- OK: Provided hostname matches discovered certificate
- OK: leaf cert "github.com" expires next with 550d 20h remaining (until 2022-05-10 12:00:00 +0000 UTC)
- OK: [EXPIRED: 0, EXPIRING: 0, OK: 2]

============================
CERTIFICATES | CHAIN DETAILS
============================
Certificate 1 of 2 (leaf):
        Name: CN=github.com,O=GitHub\, Inc.,L=San Francisco,ST=California,C=US
        SANs entries: [github.com www.github.com]
        KeyID: 63:2:D2:5D:2:5F:F7:8D:D5:5A:12:9E:76:11:36:96:86:2C:8A:48
        Issuer: CN=DigiCert SHA2 High Assurance Server CA,OU=www.digicert.com,O=DigiCert Inc,C=US
        IssuerKeyID: 51:68:FF:90:AF:2:7:75:3C:CC:D9:65:64:62:A2:12:B8:59:72:3B
        Serial:<PHONE_NUMBER>473588541993819712332065657
        Expiration: 2022-05-10 12:00:00 +0000 UTC
        Status: [OK] 550d 20h remaining

Certificate 2 of 2 (intermediate):
        Name: CN=DigiCert SHA2 High Assurance Server CA,OU=www.digicert.com,O=DigiCert Inc,C=US
        SANs entries: []
        KeyID: 51:68:FF:90:AF:2:7:75:3C:CC:D9:65:64:62:A2:12:B8:59:72:3B
        Issuer: CN=DigiCert High Assurance EV Root CA,OU=www.digicert.com,O=DigiCert Inc,C=US
        IssuerKeyID: B1:3E:C3:69:3:F8:BF:47:1:D4:98:26:1A:8:2:EF:63:64:2B:C3
        Serial:<PHONE_NUMBER>546166222510380951761917343
        Expiration: 2028-10-22 12:00:00 +0000 UTC
        Status: [OK] 2907d 20h remaining

Adding the 'Not Before' value (not sure of label name yet) would be helpful in fairly quickly identifying when a cert was generated/replaced.

The Valid From label seems to fit well and matches what Windows shows in the cert infobox:

This brings into question the existing Expiration label. I'm tempted to update it for consistency:

Valid To
Valid Until

The latter seems to read better (at the moment).

From Chromium on Ubuntu 18.04:

Issued On and Expires On read well, and are potentially clearer than what I'm currently using.

From Firefox, also on Ubuntu 18.04:

I think for now I'll use Issued On as the new label, and keep the existing Expiration label as-is.


Update to CodeMirror 6

The online page currently uses an old version of CodeMirror 5.  We would like to upgrade to CodeMirror 6.
This would be a great first bug if you've worked with CM6 before, and would like to contribute to Peggy.  It's likely that the pegjs language mode for CM5 will also need to be rewritten for this to work.  In that case, we'll be happy to host a new project in the PeggyJS GitHub org, and give you control over that repo.

Monaco editor isn't really that hard to set up. Why not switch to an editor that can support something like this? (ugliest code alert; press Next and hover in either column);

Would you consider a PR with more serious rewrite for the /online page? I probably know where the idea of CodeMirror came from, but probably could do better this time.

Yes, I'd look at a PR that switched to something that isn't CodeMirror.  I'm not tied to CM at all, and maintenance costs matter to me, so simpler is better particularly for non-core functionality.

Yeah, I was actually also thinking, would not switch to monaco?

I am strongly in favor of moving to Monaco, after having tried it on another project.


Bump hadolint 2.1.0

I was hoping it's going to fail because of email address check in new release (https://github.com/hadolint/hadolint/releases/tag/v2.1.0), apparently it does not :)


Support f-strings for common cases

Provides support for common f-strings cases (without format specs). Essentially, adds support for FORMAT_VALUE and BUILD_STRINGS opcodes.
https://docs.python.org/3/reference/lexical_analysis.html#f-strings

@ehsantn thank you for posting this, I have added it to the queue for review.

@ehsantn thank you for posting this, I have added it to the queue for review.

Thanks for the review @stuartarchibald . I applied the changes. Let me know if anything else is needed.

Sorry for the delay. CI is passing now.

Sorry for the delay. CI is passing now.

Thanks @ehsantn


fix(build): chunkhash/contenthash not work in extractCSS

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix https://github.com/nuxt/nuxt.js/issues/6439
extractCSS HMR is unnecessary to be enabled and it will generate timestamp in chunk source, so the chunkhash will be different in  multiple builds of same file
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #6520 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6520      +/-   ##
==========================================
+ Coverage   95.67%   95.67%   +<.01%
==========================================
  Files          79       79
  Lines        2706     2707       +1
  Branches      698      698
==========================================
+ Hits         2589     2590       +1
  Misses        101      101
  Partials       16       16

Flag
Coverage Δ

#e2e
100% <ø> (ø)
:arrow_up:

#fixtures
50.6% <100%> (+0.01%)
:arrow_up:

#unit
92.35% <0%> (-0.04%)
:arrow_down:

Impacted Files
Coverage Δ

packages/webpack/src/utils/style-loader.js
94.28% <100%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7688825...a90b0fd. Read the comment docs.


Updated with working docker files

Added traefik config to all the dockerfiles in the repo.

Looks good to me, we can merge to main


Navigate from var to the declaration of inferred type

If I have an unannotated variable whose type is inferred by the analyzer, I'd like to be able to navigate (e.g. via Ctrl + Left Click in IntelliJ) to the declaration of said type.
Example:
class Foo {}

Foo createFoo() => new Foo();

main() {
    var f = createFoo();
//  ^
//  Ctrl + Left Clicking here should take me to class Foo
}

I like that suggestion! Thanks!

+1!

@jwren @alexander-doroshko
After https://codereview.chromium.org/2769813005/, server is now producing the required output, but it isn't showing up yet in IntelliJ. Is IntelliJ doing something "smart" that is causing these regions to be filtered out?
Here's a sample of the output (with comments added to highlight the two regions linked to the class String):
1490291222252:Noti:{
  "event"::"analysis.navigation",
  "params"::{
    "file"::"/Users/brianwilkerson/dart/personal_test/test.dart",
    "regions"::[
      {"offset"::8,"length"::4,"targets"::[0]},
      {"offset"::44,"length"::4,"targets"::[1]},
      {"offset"::55,"length"::3,"targets"::[2]}, // link from 'var'
      {"offset"::59,"length"::1,"targets"::[3]},
      {"offset"::69,"length"::5,"targets"::[4]},
      {"offset"::75,"length"::1,"targets"::[3]},
      {"offset"::81,"length"::6,"targets"::[2]}, // link from 'String'
      {"offset"::88,"length"::1,"targets"::[5]},
      {"offset"::98,"length"::5,"targets"::[4]},
      {"offset"::104,"length"::1,"targets"::[5]}],
    "targets"::[
      {"kind"::"LIBRARY","fileIndex"::0,"offset"::8,"length"::4,"startLine"::1,"startColumn"::9},
      {"kind"::"FUNCTION","fileIndex"::0,"offset"::44,"length"::4,"startLine"::5,"startColumn"::6},
      {"kind"::"CLASS","fileIndex"::1,"offset"::3291,"length"::6,"startLine"::92,"startColumn"::16},
      {"kind"::"LOCAL_VARIABLE","fileIndex"::0,"offset"::59,"length"::1,"startLine"::6,"startColumn"::7},
      {"kind"::"FUNCTION","fileIndex"::2,"offset"::307,"length"::5,"startLine"::8,"startColumn"::6},
      {"kind"::"LOCAL_VARIABLE","fileIndex"::0,"offset"::88,"length"::1,"startLine"::8,"startColumn"::10}
    ],
    "files"::[
      "/Users/brianwilkerson/dart/personal_test/test.dart",
      "/Users/brianwilkerson/Dev/dart/dart-sdk/lib/core/string.dart",
      "/Users/brianwilkerson/Dev/dart/dart-sdk/lib/core/print.dart"
    ]
  }
}

and here's the test file I used:
library test;

//import 'dart:async';

void main() {
  var s = '';
  print(s);
  String t = '';
  print(t);
}

Navigation in IntelliJ works only where it expects a reference. We need to adapt the IDE for this case. YouTrack issue is welcome.
BTW how does it handle var a = 1, b = true;?
Also: the standard way to jump to the variable type in IntelliJ is Cmd+Alt+B on the variable declaration or reference (also in the main menu Navigate -> Type Declaration). This never worked for Dart, but you may try it in Java to see how it works. We may think about making it work for Dart (it's only an IDE-side task I believe, we can query var type using hover or doc info I believe).

BTW how does it handle var a = 1, b = true;?

It only creates a navigation region in cases where all of the variables have the same inferred type, so in this case there would be no region.

in this case there would be no region

Cmd+Shift+B will still work (if we implement it :))

Glad to see some progress made here. Will the change include final or should I file a separate issue for it?


adding words with apostrophes only adds the portion before or after the apostrophe

for example, I've tried to add the word 'would've" and simply can't  It will allow "would" or "ve" but not "would've"

This is a duplicate of #375.
But you shouldn't be adding such words to the dictionary. 've 's and other contractions are available separately, so that you can combine them with any word. Just type 96853183 and you will get would've

This is a duplicate of #375.
But you shouldn't be adding would've to the dictionary. 've 's and other contractions are available separately, so that you can combine them with any word. Just type 96853183 and you will get would've.
The problem with other words, such as "rock'n'roll", will be solved in the other issue.

It might be that it should work, but typing '9685313' results in "would,vd" instead of "would've'.  '8428155' yields "that,kl" instead of "that'll".
So something is malfunctioning

Then make sure you are using the latest version and that you have re-loaded the dictionary to get some new words.

"would've" now works with latest version.  "That'll and "It'll" don't.
Why can't we add our own contractions to the dictionary?

Why can't we add our own contractions to the dictionary?

Because they will mess up automatic word breaking and because they may appear instead of other suggestions. This is what has probably happened on your phone.
The other possibility is that it is lagging too much, which also produces incorrect suggestions sometimes.
Either way, both problems will be solved in the next release, which will also bring a lot of new English words. So please, be patient until then.


Install docs spruce-up & VS for Mac and VSCode mentions

Fixes https://github.com/NuGet/docs.microsoft.com-nuget/issues/1841
Spruced up the document overall, eliminated some redundancy. VSMac and VSCode are now line-items in the table, rather than just mentioned in a paragraph.
VS2010 - took the time to install it so here's a screenshot for reference:

Docs Build status updates of commit 5d2fd76:
:clock10: Pending: waiting for processors (11 builds ahead of you)
:warning: Docs Build is busy, currently there are 11 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 5d2fd76:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/install-nuget-client-tools.md
:warning:Warning
View
Details

docs/install-nuget-client-tools.md

Line 20: [Warning] Cannot find bookmark '#visual-studio' in 'install-nuget-client-tools.md'

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ed53cae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/install-nuget-client-tools.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6767511:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/install-nuget-client-tools.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Incorrect Documentation Link

The following links are incorrect.
Winternl
Possible Replacement: https://docs.microsoft.com/en-us/windows/win32/devnotes/winternl
Files

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 553d1c23-33bc-4c56-495a-1dec42919413
Version Independent ID: 21da7206-cda5-12b0-e4d3-3cff9c5860d7
Content: Libraries and Headers - Windows drivers
Content Source: windows-driver-docs-pr/kernel/libraries-and-headers.md
Product: windows-hardware
Technology: kernel
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Thanks for the heads up!  I just updated the links.  The fix should appear on the live site within a few minutes.


how can i receive a email

I have use your code can send a emil.then and i also want recive a email ,how can i do it?

Hi there,
This library is only for sending email.


feat: add basic visual feedback on Button interactions

Why
While using BSky app, the one thing which lead to triggering multiple follows and unfollows in a row for me was lack of visual indication for the Button interactions (since the actions could take a second or two, I often thought that I have missed the button, especially on mobile device).
How
This PR adds the very basic visual interaction feedback for user, when pressing or hovering the Buttons. Opacity value can be tweak as you wish. Definitely it's not a robust and ideal solution, but it should be a good beginning for UX improvements when it comes to the intractable components.
Preview
https://github.com/bluesky-social/social-app/assets/719641/876a678e-0400-4777-8a04-198a5c6a1cb3

Thanks for the PR! There's a simpler & more efficient way to do this which I implemented here: https://github.com/bluesky-social/social-app/pull/708

Yup, your approach should be a bit more performant, thank you follow up on that and addressing this issue so quickly! 👍


List<Map<String, Object>> body parameter produces Array[undefined] data type on Swagger UI

I have HTTP POST API method like this:
@POST
public Response postFoo(@NotNull List<Map<String, Object>> foos) {
    ...
}

On the generated swagger UI, the body Data Type is showing Array[undefined].
I have tried adding @ApiParam to the foos param with example property set but the body data type is still showing Array[undefined].
Is there a way to override the body's data type on the swagger UI?

Please open this on swagger-ui


ICMP Scan: sending ICMP for IPs not listed in the ARP cache

Hi, I'm experimenting with "sx" and found an interesting issue.
Well, I was trying to ICMP scan a local WiFi network. First of all, I generated the ARP cache file. After that I run the ICMP Scan. Everything seems to work, but the interesting thing that I'm talking about is: I generated a PCAP file while I was scanning the network and noted that even though I had just provided an ARP cache of 3 entries, sx had sent ICMP packets for all the subnet I provided in the command line.
I was expecting ICMP packets only for the 3 IP addresses/MACs listed in the ARP cache file. This is the ARP cache I used:
{"ip":"<IP_ADDRESS>","mac":"d8:c6:78:1f:bc:90","vendor":"MitraStar Technology Corp."} {"ip":"<IP_ADDRESS>","mac":"c8:5d:38:29:6b:08","vendor":"HUMAX Co., Ltd."} {"ip":"<IP_ADDRESS>","mac":"c8:5d:38:29:77:2f","vendor":"HUMAX Co., Ltd."}
Another thing that I noticed was that for each ICMP packet sent and which the MAC was not listed in the ARP cache, "sx" included the MAC address of the first entry in the ARP cache as the Ethernet frame destination address.
For example, for the IPs:

<IP_ADDRESS> -> MAC d8:c6:78:1f:bc:90
<IP_ADDRESS> -> MAC d8:c6:78:1f:bc:90
<IP_ADDRESS> -> MAC d8:c6:78:1f:bc:90

Is it how it's supposed to work?
p.s) I'm using a development version. sx version dev
Thanks for any feedback.

Hi @ronaldoafonso !

sx had sent ICMP packets for all the subnet I provided in the command line.
yes, sx tries to scan all ip addresses provided in the command line, arp cache file just provides initial information (starting context) that is necessary to perform the scan.

Another thing that I noticed was that for each ICMP packet sent and which the MAC was not listed in the ARP cache, "sx" included the MAC address of the first entry in the ARP cache as the Ethernet frame destination address.

I can guess that <IP_ADDRESS> address is the default gateway for your network, sx tries to find mac address for a scanned ip address in ARP cache and if it is not present in the cache then sx fallbacks to the mac address of the default gateway. This is why d8:c6:78:1f:bc:90 address is used for packets for all addresses that were not explicitly specified in the arp cache file.
Would like to note that If you want to exclude IPs from scan you can use --exclude option.

Ok @v-byte-cpu , I got it.
Thanks very much for your answer.
I'm just experimenting "sx" and I'd say that I'm liking it. It seems a very nice tool. :)

Thank you for the kind words :)


define the crd to deploy a new user

The format should be this one:
 spec:
    email: <email>
    password: <password>
    namespaces: <namespace>
    redis:
       enabled: <flag>
       prefix: <prefix>
       password: <redis-password>
    s3:
       enabled: <flag>
       bucket: <bucket>
       password: <s3-password>
    mongodb:
        enabled: <flag>
        database: <database>
        password: <mongodb-password>
    route:
       enabled: <flag>
       host: <hostname>

also add the detection login that will trigger deployment of resources (separated tickets)

What do we really mean by "detection login that will trigger deployment of resources (separated tickets)"?
For the CRD spec maybe we should use something like this, to avid using s3 which refers to a specific object-storage provider.
spec:
    email: <email>
    password: <password>
    namespaces: <namespace>
    redis:
       enabled: <flag>
       prefix: <prefix>
       password: <redis-password>
    object-storage:
       enabled: <flag>
       bucket: <bucket>
       password: <s3-password>
    mongodb:
        enabled: <flag>
        database: <database>
        password: <mongodb-password>
    route:
       enabled: <flag>
       host: <hostname>

and in case the object-storage is activated we will create 2 buckets -data and -web? Alternatively, as in  the other ticket referring to bucket creation we use -data and -web we can also remove the bucket attribute. Unless we will opt to create a bucket named  and tow subfolders -data and -web

Final implementation decision/assumptions.
We will deploy a new wsk.user CRD with spec as following
spec:
    email: <email>
    password: <password>
    namespace: <namespace>
    redis:
       enabled: <flag>
       prefix: <prefix>
       password: <redis-password>
    object-storage:
       enabled: <flag>
       bucket: <bucket>
       password: <s3-password>
    mongodb:
        enabled: <flag>
        database: <database>
        password: <mongodb-password>
    route:
       enabled: <flag>
       host: <hostname>
       password: <web-bucket-password>
       bucket: <bucket>

The implementation will provide a new python kopf based operator nuvolaris.user that will implement the deploy/undepoloy these components:

a new OpenWhisk namespace by using the wskadmin tool to add a new namespace/password entry in the internal couch-DB
a new bucket, which will be typically called, namespace-data if object-storage.enabled=true
a new mondodb database, if mongodb.enabled=true
a new object-storage bucket, typically called namespace-web to be used to serve static content and a specific NGINX-ingress route which will make accessible the static content exposing the given hostname over a https endpoint.
a new redis database, if redis.enabled=true (the effective implementation still needs to be defined for multitenancy)

implemented


Increment version for fleet releases

Increment package version after release of Azure.ResourceManager.DatabaseFleetManager

API change check
API changes are not detected in this pull request.