Notify soundPath is not changing.

When I try to change notify options I do this :
Lobibox.notify.OPTIONS = {
    'class': 'animated-fast',
    soundPath: 'sounds/',

    // You can override options for large notifications from here
    large: {
        width: 500
    },

    // You can override options for small notifications from here
    mini: {
        'class': 'notify-mini'
    },

    // Default options of different style notifications
    success: {
        'class': 'lobibox-notify-success',
        'title': 'Success',
        'icon': 'glyphicon glyphicon-ok-sign',
        sound: 'sound2'
    },
    error: {
        'class': 'lobibox-notify-error',
        'title': 'Error',
        'icon': 'glyphicon glyphicon-remove-sign',
        sound: 'sound3'
    },
    warning: {
        'class': 'lobibox-notify-warning',
        'title': 'Warning',
        'icon': 'glyphicon glyphicon-exclamation-sign',
        sound: 'sound5'
    },
    info: {
        'class': 'lobibox-notify-info',
        'title': 'Information',
        'icon': 'glyphicon glyphicon-info-sign',
        sound: 'sound2'
    }
};

This works but, soundPath is not changing. I get the same default 'src/sounds/' soundPath.
I managed to fix this by placing soundPath directly in Lobibox.notify like this:
      Lobibox.notify(

        // 'warning', 'info', 'success', 'error'
        arguments.type,
        {
            title:true,
             ...
            soundPath: 'sounds/',
            sound: true,
            position: 'bottom right'
        }

      );

I will look at this and fix ASAP.
On Nov 2, 2015 4:30 PM, "Muhamed Krlic"<EMAIL_ADDRESS>wrote:

When I try to change notify options I do this :
Lobibox.notify.OPTIONS = {
'class': 'animated-fast',
soundPath: 'sounds/',
// You can override options for large notifications from here
large: {
    width: 500
},

// You can override options for small notifications from here
mini: {
    'class': 'notify-mini'
},

// Default options of different style notifications
success: {
    'class': 'lobibox-notify-success',
    'title': 'Success',
    'icon': 'glyphicon glyphicon-ok-sign',
    sound: 'sound2'
},
error: {
    'class': 'lobibox-notify-error',
    'title': 'Error',
    'icon': 'glyphicon glyphicon-remove-sign',
    sound: 'sound3'
},
warning: {
    'class': 'lobibox-notify-warning',
    'title': 'Warning',
    'icon': 'glyphicon glyphicon-exclamation-sign',
    sound: 'sound5'
},
info: {
    'class': 'lobibox-notify-info',
    'title': 'Information',
    'icon': 'glyphicon glyphicon-info-sign',
    sound: 'sound2'
}

};
This works but, soundPath is not changing. I get the same default
'src/sounds/' soundPath.
I managed to fix this by placing soundPath directly in Lobibox.notify like
this:
  Lobibox.notify(

    // 'warning', 'info', 'success', 'error'
    arguments.type,
    {
        title:true,
         ...
        soundPath: 'sounds/',
        sound: true,
        position: 'bottom right'
    }

  );

—
Reply to this email directly or view it on GitHub
https://github.com/arboshiki/lobibox/issues/1.

If you want to change default parameters of the plugin, try the following thing
Lobibox.notify.DEFAULTS = $.extend({}, Lobibox.notify.DEFAULTS, {
    soundPath: 'sounds/',
    //write down all parameters you want to override
});

Hello @l0oky , let me know if my answer helped you.

Yes It worked.
What's the main difference between Lobibox.notify.DEFAULTS and Lobibox.notify.OPTIONS?
It didn't change If I were to put it in Lobibox.notify.OPTIONS but works on Lobibox.notify.DEFAULTS?

Lobibox.notify.DEFAULTS are default options for single notification. You can override any default options when calling
Lobibox.notify(type,{
   //options
});

But Lobibox.notify.OPTIONS are general available options for different size and color notifications.
For example: By default title is enabled in Lobibox.notify.DEFAULTS but actual title value is taken from Lobibox.notify.DEFAULTS according to the type of notification.

soundPath is option of only DEFAULTS not OPTIONS. So if in example or in documentation soundPath is shown in OPTIONS it is mistake

Thanks. I think, though, I am not sure (because I am not very familiarized with your source code), that you don't need DEFAULTS and OPTIONS but only one of them OPTIONS or DEFAULTS. Because both serve a very similar or the same purpose to change default settings. Only in  Lobibox.notify( you can change options for this instance of notify. Am I correct?

Yes maybe you are correct and OPTIONS and DEFAULTS can be combined in
one. This plugin needs more work to improve and become hight level
notification plugin. Now it's like said in between beta and stabe
versions.  Unfortunatelly I do not have time to work on it.  I am going to
continue improving this plugin, but I do not know exactly when.
On Nov 7, 2015 11:55 AM, "Muhamed Krlic"<EMAIL_ADDRESS>wrote:

Thanks. I think, though, I am not sure (because I am not very familiarized
with your source code), that you don't need DEFAULTS and OPTIONS but only
one of them OPTIONS or DEFAULTS. Because both serve a very similar or the
same purpose to change default settings. Only in Lobibox.notify( you can
change options for this instance of notify. Am I correct?
—
Reply to this email directly or view it on GitHub
https://github.com/arboshiki/lobibox/issues/1#issuecomment-154652058.

The plugin is good as is, slight modifications can only make It more developer friendly but other than that, great work! I'm already using this for commercial purposes :)

I am glad that you are using it and you like it. For any other questions I
am ready to help you.
On Sun, Nov 8, 2015 at 12:30 AM, Muhamed Krlic<EMAIL_ADDRESS>wrote:

Closed #1 https://github.com/arboshiki/lobibox/issues/1.
—
Reply to this email directly or view it on GitHub
https://github.com/arboshiki/lobibox/issues/1#event-457982013.


Foyer Handlers

Description
In #71, @mattwthompson provided an outline processing data from foyer. This PR presents a draft implementation for creating PotentialHandlers for data from foyer.
Co Authors:

@daico007
@justinGilmer

Here are couple of issues:

Currently, we are taking in a parmed structure, atomtyping it with foyer, and creating a system object. However, one question is on the creation of a openff.toolkit.Topology object out of the structure. This seems trivial but I am not sure if this is in the scope of this PR.
For a FoyerBondHandler we need the slots that were created using a FoyerAtomTypes, which seems logical but I am not sure if it's intended to be used in such fashion

Checklist

[ ] Add tests
[ ] Lint
[ ] Update docstrings

Apologies for some of the confusion with making the linters happy. I need to add some developer docs that explain how to automate that.
Quick thoughts on your questions:

We should avoid using ParmEd as an intermediary. As long as Foyer is intended to take in mBuild compounds, they should be used as the source of topological data. Converting among these objects is not trivial; maybe simple for simple cases, but carefully outlining conversions between rich objects, and the unsupported behavior, is tricky.
"Slots," which deserve a more descriptive name, should be generated from the topology itself. So, bond "slots" are tuples of atom indices generated by inspecting the graph of the topology.

Partially documenting the expected keys in Potential.parameters for various handlers:
Bonds: k, length
Angles: k, angle
Torsions: k, phase, periodicity
vdW: sigma, epsilon
Electrostatics: not stored as a Potential, just stored as a unit-tagged float

There are couple of points to be addressed here:

Two types of torisions are currently extracted from foyer. RB and Periodic. Which means, there will be two handlers for them. For Periodic Torsions, k, phase and periodicity have been used but for RBTorsions. c0, .... c5 have been used for their parameters.
For angle params, I have used theta as angle. Which should be changed.

Also, after https://github.com/mosdef-hub/foyer/pull/389. The system creation should consider taking an OpenFF Topology instead of parmed structure.

RBTorsions

The best way to handle this is probably to have a separate RBTorsionsHandler that is separate from the ProperTorsionsHandler objects that already exist, similar to how OpenMM has separate forces for each. I can handle this in a separate PR as it's a useful feature outside the scope of Foyer interoperability.

https://github.com/openforcefield/openff-system/blob/b5ecee428ef55402f5ab3c37ab3189c5b2a8d1b8/openff/system/components/foyer.py#L189-L301.
I have added support for them but instead of two, I created four handlers:

FoyerPeriodicProperHandler
FoyerPeriodicImproperHandler
FoyerRBProperHandler
FoyerRBImproperHandler
This is done specifically because the topology keys differ in their order for dihedral/impropers, which I figured should be handled separately. The duplicate interactions are handled in foyer itself.

Excellent!
What's missing at the moment is that exporters currently don't support RB-style torsions at all, so there's nothing for FoyerRBProperHandler to hook into, so we can't run energy tests. This is a bigger task so it may not be appropriate to handle it here.

@mattwthompson can we document expected Parameter Keys, the expression for the Potential from each of the OpenMM forces and their units, I having a hard time to find default units, specially for  derived quantities which some of the parameters seem to be.

I'm looking for ways to get the following information out of foyer.Forcefield

1-4 scaling factor for LJ terms
1-4 scaling factor for electrostatics
Mixing rule/combination rule

@umesh-timalsina @daico007 @justingilmer how do you feel about merging this in its current state and then expanding the tests in a follow-up?

@mattwthompson. Apart from the @classmethod that converts a OFF-Topology into a foyer topology-graph, I don't see any issue.

Happy to remove that code from here if it's in the next Foyer release

I'm looking for ways to get the following information out of foyer.Forcefield

1-4 scaling factor for LJ terms
1-4 scaling factor for electrostatics
Mixing rule/combination rule

@mattwthompson see https://github.com/mosdef-hub/foyer/issues/397. First class support doesn't exist currently but will be added to foyer.

Perfect! Thanks @daico007


Added absl::Status support to grpc_closure.error

Superseding https://github.com/grpc/grpc/pull/26239
Instead of fiddling with the raw pointer of absl::Status which #26239 tried to achieve, this PR simply makes the error_data.error to be able to have absl::Status using ManualConstructor.
Due to the life-time management difference between grpc_error* and absl::Status, *cl->error_data.error = GRPC_ERROR_NONE; is added when the closure instance could destroy. I intentionally don't use Destroy() method for this case because those instances can be reused.

Thanks for CCing me. Since we have too many grpc_closures in several hot structures, this will increase the memory usage significantly.  I think keeping the union would be worth the costs.
The scratch space is used only by the combiner. If we really need to deunionize to move to absl::Status,  Craig do you think it is possible to create a special combinable_closure that has a pointer to its lock, so that at least other users don't get impacted by this change? If that's feasible, we could get rid of scratch space in the closure.

That could work... I'm really curious as to why we don't just add the absl::Status to the grpc_closure union though - we can definitely do so in C++11.

@ctiller Oh it might be possible to keep using union here if I can spot when to call ctor and dtor of absl::Status. Let me play with it.

I changed this to keep the existing union so there is no size increase. I double-checked the PR but please take a careful review on the code where error_data.error gets out of scope and its content should be wiped. If it fails to do it, it could cause a memory leak.

I don't see an error_data.Destroy() call anywhere, which I assume means we expect to leak if anythings left in this place.

@ctiller Assigning GRPC_ERROR_NONE is effectively calling Destroy for absl::Status, which is why error_data is set to GRPC_ERROR_NONE before being called. I hope that this can cover all cases.

Can you run this with MSAN and the flag flip to use absl::Status

@ctiller To run MSAN isn't feasible yet because all pieces should be merged to run it. I can share the result later.

@ctiller PTAL on the last commit adding Destroy instead of zero assignment.

I don't think I can LGTM this, sorry.
I agree that it'll work right now, and I even suspect it's quite likely to not cause an issue in the future.
If this were purely internal, I'd probably request a few inches of comments and a timeline to back it out - because in that case we act like a monorepo and so the consequences of this going wrong would be localized.
This is not, however, purely internal, and puts a constraint on matching absl version and grpc version forever in a way that we can't guarantee, and if the assumed contract here is ever broken ('its safe to create an absl::Status but not destroy it') the burden of that constraint falls not on us or the Abseil team, but on our mutual users.
I think one of the things we should be trying to do is provide good examples as we publish open source code, and I think that this approach falls short there.
Did we try the approach of making ok/cancel be a 0/1 pointer, and using the full pointer value as a pointer to absl::Status? I think that approach makes the right trade-off between performance and maintainability, and importantly doesn't tie another team to a forever constraint for which they have not agreed.

I was tempted to encapsulate access to either absl::Status or grpc_error* without using many #if GRPC_ERROR_IS_ABSEIL_STATUS blocks but the number of blocks are small so I decided not to assuming this will exist for a short period of time.

Hey, the approach seems good. I'm worried about extra allocations on the cancellation path though: we cancel a timer for every successful request, and so this could be quite heavyweight.
Could you maybe work with @nanahpang to run this through some internal load tests and verify that the impact here is ok?
If this change is within noise there I'm ok moving forward.

@ctiller Yeah. Sure, I'm planning to do some benchmark work to assess the performance impact. But, this isn't the only PR to run the test. (it requires a few other PR in place) so how about getting this merged since it shouldn't affect anything without enabling the flag. And if the performance is not acceptable, I will follow up on it. WDTY?


Add linktolatest option for RollingFileWriter

see https://github.com/pmwmedia/tinylog/issues/149
I'm not sure how to implement the assertions in the test.  The build is not working on my machine (javac 11.0.7)
tinylog/tinylog-api/src/main/java/org/tinylog/runtime/LegacyJavaRuntime.java:[58,43] cannot find symbol
[ERROR]   symbol:   class Reflection
[ERROR]   location: package sun.reflect

If you find the idea acceptable, could you please help me with this part?  Thank you!

Thank you very much for your pull request :) You need Java 9 to compile all tinylog artifacts. Java 11 and later don't include sun.reflect.Reflection anymore in favor to the new stack walker API. Java 9 and 10 are the only Java versions that can compile the legacy reflection API as well as the new stack walker API. tinylog supports both and decides on runtime which to use.
Is there any way to implement it without using Files.createSymbolicLink()? The problem is that Android added this class with API level 26, but some developers still have to support older Android versions.

It wasn't as easy as i expected to find a jdk 9 installer and to remember how to do things in java 1.6 , but it finally builds.  Please let me know what you think.

Today, I read about creating symbolic links in Java without using the NIO API. Unfortunately, there is really no native Java API for it prior Java 7. Creating a process for executing OS commands as you did is the only way. However, the disadvantage is that these commands are OS depending. For example, it won't work on Windows.
However, I think your feature is very useful for computer applications, but I don't see any use case for Android apps. Therefore, I prefer to use your previous approach with the Files class from the NIO API. You could check if tinylog is running on Android and log an error message. Otherwise, you can execute your code. I have just added a method to detect whether running on Android: RuntimeProvider.isAndroid().

By the way, I have a question about removeLinkToLatest(): Why do you delete the symbolic link?

I renamed removeLinkToLatest to filterOutSymlinks.  It exists in case the user puts the symlink in the same folder as the actual log files.  The logic seems much easier to read now with the java 7 sdk.
However, I am having trouble getting the build to succeed (it seems to exclude java 7 sdk):
[ERROR] /Users/juanliska/Documents/startrack/code/tinylog/tinylog-impl/src/main/java/org/tinylog/writers/RollingFileWriter.java:129: Undefined reference: java.nio.file.Path
[ERROR] /Users/juanliska/Documents/startrack/code/tinylog/tinylog-impl/src/main/java/org/tinylog/writers/RollingFileWriter.java:129: Undefined reference: java.nio.file.Path java.nio.file.Files.createSymbolicLink(java.nio.file.Path, java.nio.file.Path, java.nio.file.attribute.FileAttribute[])

Thanks for your useful comments!  I made the suggested changes.

@pabl0rg Can you reproduce the failed JUnit test on your local machine?

Actually it seems that test case was not actually needed/wanted. (symlinks should only updated on rollover)

@pabl0rg I have merged your pull request! Thank you very much for your contribution :)
I just noticed that you used an email address<EMAIL_ADDRESS>for your commits that isn't linked to your GitHub profile. Could you add it (https://github.com/settings/emails)?

Done!  Thank you and sorry I didn't fix the tests.  I came down with covid and my thinking has been foggy.

@pabl0rg Thank you very much! Health has first priority of course. I hope you feel already better. Get well soon!


python sum even fibonacci was broken, some a's and b's were moved around and some other tiny things

done


Canceling ipykernel install does not put an error in the output

This was with IW.

Cell like 'print(1)'
Create venv that doesn't have ipykernel
Set as active
Run cell
Hit cancel on install ipykernel

Expected:
Cancellation error in the output
Actual:
Nothing in the output.

Wait. This only happens after setting remote and then killing the remote server.
If I reset to 'None' for the remote, the cancel error shows up just fine.
Same issue as #9806 then


PUB-856 Altered header text, added header and gov.uk links

JIRA link
https://tools.hmcts.net/jira/browse/PUB-856
Change description
Header text and link amended, gov.uk link added to logo.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ X] No

can you add some unit tests in there just to cover these additions

Should be done now

can you add some unit tests in there just to cover these additions

Should be done now


replication_slots is broken when there is no logical replication slot

Hello,
It seems replication_slots  check is broken here : https://github.com/OPMDG/check_pgactivity/blob/602ae71f4caa0a169ea9ba2a8ba63ea6230fb4b7/check_pgactivity#L5811
If there is no file in pg_replslot $row->[3] is empty and you go this error :
Argument "" isn't numeric in numeric gt (>) at /opt/sensu-plugins/check_pgactivity line 5811.

I will try to address this issue soonly.
Regards,

I investigate and this occurs before 10 due to null as replslot_files:
https://github.com/OPMDG/check_pgactivity/blob/90796a14752c9e830241a09766d41f6ed3df9560/check_pgactivity#L5703
We could change to 0 but I don't remember why we do not count replslot_files before 10? We could have spill files since 9.4 if we use logical replication slot (even without native logical replication) ?
So I see to solutions:

Replace null by 0 in 9.4's query
Count replslot_files in 9.4

First fix is quick, second not :)

@anayrat isn't that a change you introduced in https://github.com/OPMDG/check_pgactivity/pull/176?  I didn't follow that PR so I have no idea why the slot files aren't checked before 10.  Can you check if you can get this metric for pg9.4+ too?

You're right, it seems I added logical replication slot support since 10 due to native logical replication appeared in 10. But, as I mentioned in this PR, spill files can appear since 9.4. I'll work on this.

Thanks!

What up here? @anayrat, will fix your stuff? :)

Sorry, I forgot this issue :(
I do not have time to spend on this. I think, the best that could be done is to count replslot_files in 9.4.

So maybe this check should be set as compatible with 10+ and mark this issue as a futur enhancement? If it makes sense and we deal with it before 9.6 is deprecated :D
I'm not sure when someone will have time to spend on this...

Fixed in PR #273


use more recent api for python-lz4

Closes #3156.

Looks great to me.  Thanks for identifying and resolving this @thrasibule !  Merging.

When will this be released as a new version?  Looks like it almost-but-not-quite made the cut for 0.17.0.

https://github.com/dask/dask/issues/3192


Discord GitHub Bot

Pull Request Template
script name - discord github bot
Brief about script
This is a python3 script that sends github notifications from any repository to a discord channel of user preferences. It uses discord python module for discord bot api and github api to get repo notifications.
Issue no.(must) - #692
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder (Name of folder should be in lowercase with no space in between) (E.g. meet_schedular)
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt (Include version numbers too e.g. pandas==0.0.1) with my script
[x] Just including required dependencies in requirements.txt (Don't include Python version too)

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Wow, really useful script :)


pint-submit and more docs fixes for compute graph and solution-set name changes in integration update

Based on #139

OK this should be good to go, going to merge this into the main integration-update branch and then see how CI is looking.


Allowing toggle of rsyslog.d purge

May want to also consider allowing other parameters to be overridden via the server and client classes.  This one seems useful though.

I'm going to close this.  This change would require a deeper refactor.


ref!: adopt log/slog + other prom configs, drop custom logging pkg

I would call this a breaking change, as there are updates to command line flag interactions.
Changes included:

convert --debug bool flag -> --log.level string flag. this aligns with prom conventions. This project uses urfave/cli for application commands/flags rather than kingpin as other go packages do, so I couldn't use the promslog/flag pkg directly. Rather, I use our upstream promslog/kingpin configs in the configs we pass here for urfave/cli. We can decide to move off urfave/cli and/or adopt kingpin in the future.
removes pkg/logging in favor of using prometheus/common/promslog. A small utility function is included in main to simplify some boilerplate with logger initialization, since we instantiate in main in a few places. All functions have been converted to accept/use *slog.Loggers rather than the custom logger interface.
the removal of the custom logging pkg also removes the IsDebugEnabled() method, but this is fine because the logger is leveled; debug logs will not print unless --log.level debug is passed at the command line, there is no need to check if debug is enabled at log time in the vast majority of cases.
Updates tests as needed; updates nop loggers, test signatures that used IsDebugEnabled(), etc.
enable sloglint in golangci-lint, remove go-kit/log configs

Supercedes #1577
cc: @SuperQ

Thanks, we'll probably slowly convert over other things like urfave/cli to Prometheus community normal components over time.

Looking into the config verification failure in tests

Alright, I fixed up the verification test; panic was caused by a typo/wrong variable reference. Sorted out now :+1:

Bump, lemme know if there's any other feedback :+1:

Thanks!


update Fluent Python by Luciano Ramalho 2nd Edition Year 2022

Great, thanks for updating the resource. Keep up the good work!


Fix zephir compilation error on Imagick

annot compile phalcon with zephir via travis-ci on latest 3.0.x version.  This is related to #12509 and the reverted fix of https://github.com/phalcon/cphalcon/commit/3e7168561420dc39361019f4942007daf4850f15
I guess the fix should not be reverted in 3.0.x or changes from master need to be backported. We cannot build phalcon anymore in our build environment. 👎
Zephir\CompilerException: Class '\Imagick' does not implement static method: 'getVersion' in /home/travis/cphalcon/phalcon/image/adapter/imagick.zep on line 363
	   let version = \Imagick::getVersion();
	---------------------------------------^

Regarding https://github.com/phalcon/cphalcon/issues/12525#issuecomment-270094940 the latest dev zephir should be used. I don't like that solution but it's the decision from phalcon team.. 🙄

Thanks @gabel - Noticed this a few days ago. Phalcon really needs to stop breaking production. I'm talking with a few of the guys to see we can also fix the Imagick changes. Will test this and get this merged very soon!

May have issues pulling latest tag because of minimum stability. Hopefully can get a new release cut very shortly.

@virgofx Thanks for taking care... the new tag fixes it again..

Great, thanks for the feedback @gabel


Add a note about localization to CONTRIBUTING.md

I've added some notes about localizations. Please review and fix as needed.

Excellent, thanks @miloskroulik. Merged!


Implement PSR15?

Will implement PSR15 ?

Hi,
It's certainly on my list of things to add - which framework/library are you currently using which is PSR-15 compatible (just mainly so I can 100% check it is working correctly).

zendframework/zend-expressive-skeleton:^3.0.0rc4

Just so you know, I've spent most of today working on this and have got a proof of concept seeming to work in https://github.com/bairwell/middleware-cors/tree/psr15compatibility : adding ``$aggregator = new ConfigAggregator([
\Bairwell\MiddlewareCors\ZendFramework\ConfigProvider::class,```
to config.php in a Zend Expressive project does seem to be including it, but I haven't managed to pass in settings or fix all the broken unit tests yet (I've also taken the chance to update dependencies and change a few other bits of code). It's still a work in progress, but should be done soon.


Create golden tests?

Hi there!
Monarch looks awesome. I haven't seen anything about creating images of stories, then testing they don't change later.
I'm using https://pub.dev/packages/golden_toolkit which is great to avoid unwanted design changes/regressions.
It would be awesome to create goldens from monarch then test it: great design, then great tests!
Thanks for your cool work here!

Love the feedback!
Visual testing is definitely on our roadmap. We can't wait to start working on it. We think Monarch can drastically improve the golden test experience.
For now, if you are using golden_toolkit, then you can call your stories from your golden tests. Something like this should work:
// my_stories.dart
Widget primaryButton() => ...;
Widget secondaryButton() => ...;

// my_golden_tests.dart
testGoldens('my buttons', (tester) async {
  await tester.pumpWidgetBuilder(
    Center(
        child: (GoldenBuilder.column()
              ..addScenario('primary button',
                  primaryButton())
              ..addScenario('secondary button',
                  secondaryButton())
            .build()),
    surfaceSize: ...,
  );
  await screenMatchesGolden(...);
});


Ribbon Button

Have a ribbon icon to open random note modal.

Update 0.0.11 includes this feature.


Add ERC20 token

Project current situation: beta release https://Belance.io
Media publications: https://www.investing.com/crypto/erc20/news , https://news.bitcoin.com/?s=erc20 , https://coinranking.com/coin/erc20-erc20/news , https://cointelegraph.com/search?query=erc20 , https://www.bloomberg.com/search?query=erc20 , https://www.newsbtc.com/?s=erc20&lang=en
Gas limit: 60,000
Listed exchanges: ERC20 already listed on Mercatox, Kuna, TokenStore and ForkDelta:
Mercatox https://mercatox.com/exchange/ERC20/ETH
https://mercatox.com/exchange/ERC20/BTC
KUNA  https://kuna.io/markets/erc20btc
ForkDelta https://forkdelta.app/#!/trade/ERC20-ETH
TokenStore https://token.store/trade/ERC20
Basic information of the project:
ERC20  is payment method for Belance platform, future project and application and more. Real token utility. Belance is a large unique blockchain platform which combines many opportunities and connects everyone in the blockchain world. The real toke utility. The ERC20 Token is a growing currency which will be adopted as a payment gateway. Whether you’re building your new project or searching for
something unique, Belance is the first platform where there are unlimited opportunities to connect and discuss with others
regarding the cryptocurrency and blockchain industry. Also
connect with professionals to help your own project by hiring a specialist to complete a specific task within your project.
Promote and advertise your own skills and specialities to clients. Ask questions on any topic related to the blockchain or become
a blockchain blogger. Belance is a one stop place for everything
for everyone who is interested in or connected to the blockchain world
More about ERC20 Token

Website: https://index-erc20.io

Whitepaper: https://belance.io/aboutbelance.html
Twitter: https://twitter.com/ERC20_
Telegram: https://t.me/erc20coin

Project current situation: beta release https://Belance.io
Media publications: https://www.investing.com/crypto/erc20/news , https://news.bitcoin.com/?s=erc20 , https://coinranking.com/coin/erc20-erc20/news , https://cointelegraph.com/search?query=erc20 , https://www.bloomberg.com/search?query=erc20 , https://www.newsbtc.com/?s=erc20&lang=en
Gas limit: 60,000
Listed exchanges: ERC20 already listed on Mercatox, Kuna, TokenStore and ForkDelta:
Mercatox https://mercatox.com/exchange/ERC20/ETH
https://mercatox.com/exchange/ERC20/BTC
KUNA  https://kuna.io/markets/erc20btc
ForkDelta https://forkdelta.app/#!/trade/ERC20-ETH
TokenStore https://token.store/trade/ERC20
Basic information of the project:
  ERC20  is payment method for Belance platform, future project and application and more. Real token utility. Belance is a large unique blockchain platform which combines many opportunities and connects everyone in the blockchain world. The real toke utility. The ERC20 Token is a growing currency which will be adopted as a payment gateway. Whether you’re building your new project or searching for
  something unique, Belance is the first platform where there are unlimited opportunities to connect and discuss with others
  regarding the cryptocurrency and blockchain industry. Also
  connect with professionals to help your own project by hiring a specialist to complete a specific task within your project.
  Promote and advertise your own skills and specialities to clients. Ask questions on any topic related to the blockchain or become
  a blockchain blogger. Belance is a one stop place for everything
  for everyone who is interested in or connected to the blockchain world
More about ERC20 Token

Website: https://index-erc20.io

Whitepaper: https://belance.io/aboutbelance.html

Twitter: https://twitter.com/ERC20_

Telegram: https://t.me/erc20coin


[ENH] Optional crop-to-FoV added into GenerateSamplingReference

Should address poldracklab/fmriprep#722
Adds a fov_mask input to GenerateSamplingReference. This mask corresponds to the brain mask calculated from the T1w, and should not contain the brain stem.
The mask is resampled into target space, and then the bounding box is calculated. Finally, the FoV is adjusted to that bounding box.

This should be ready to review and merge 👍

I would recommend testing it on one of the OpenfMRI limited FOV datasets to
see check that it behaves correctly in extreme cases.
Best,
Chris
On Mon, Oct 23, 2017 at 10:22 PM, Oscar Esteban<EMAIL_ADDRESS>wrote:

This should be ready to review and merge 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/niworkflows/pull/205#issuecomment-338877293,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkpz-NlY9EWU9BpdKDo7Os2uNHvxzYks5svXQUgaJpZM4QDnne
.


Make time attr round-trippable

https://apidock.com/ruby/Time/nsec

The lowest digits of #to_f and #nsec are different because IEEE 754 double is not accurate enough to represent the exact number of nanoseconds since the Epoch.

The more accurate value is returned by #nsec.

This converts time from a float to integer so it can become round-trippable.
This is a breaking change! The existing records are not compatible with the new version.
Test Plan

[x] Modified test cases to cover this behavior

This is related to #72 as well

support negative time
:mag_right: Click to see changes since last update.

Codecov Report

:exclamation: No coverage uploaded for pull request base (028f5ff20a6c20a051ac9e4810440c5087428b9d@028f5ff). Click here to learn what that means.
The diff coverage is n/a.

@@                             Coverage Diff                             @@
##             028f5ff20a6c20a051ac9e4810440c5087428b9d      #75   +/-   ##
===========================================================================
  Coverage                                            ?   94.52%
===========================================================================
  Files                                               ?       31
  Lines                                               ?     1279
  Branches                                            ?        0
===========================================================================
  Hits                                                ?     1209
  Misses                                              ?       70
  Partials                                            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028f5ff...e303ae7. Read the comment docs.


is this library maintained anymore?

We get a lot of compiler warnings like below
 warning: found quoted keyword "coveralls" but the quotes are not required. Note that keywords are always atoms, even when quoted. Similar to atoms, keywords made exclusively of Unicode letters, numbers, underscore, and @ do not require quotes
   ../deps/raygun/mix.exs:36

I am willing to open a PR to fix the issues, but I see no activity and some of the PRs which are probably addressing the issue have received no comments so far.

Willing to accept and merge the PR
Sent from my iPhone

On May 20, 2020, at 12:40 AM, Anantha Kumaran<EMAIL_ADDRESS>wrote:

We get a lot of compiler warnings like below
warning: found quoted keyword "coveralls" but the quotes are not required. Note that keywords are always atoms, even when quoted. Similar to atoms, keywords made exclusively of Unicode letters, numbers, underscore, and @ do not require quotes
../deps/raygun/mix.exs:36
I am willing to open a PR to fix the issues, but I see no activity and some of the PRs which are probably addressing the issue have received no comments so far.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Add syntax highlighting

Add simple, template independent WooWoo syntax highlighting.
(This will be expanded on in the future by adding dynamic template-aware syntax highlighting.)

Note that there are currently issues implementing grammar for language features which use nesting (making it non-regular) and for features which use indentation awareness (making it non-context-free).


New anatomy term for a fruitless expressing neuronal cluster

FBrf0210397 identifies and describes a fruitless cluster similar to pC1 (FBbt:00110621 & FBbt:00110507) and pC2 (FBbt:00110611& FBbt:00110487) with sex specific differences that they call pC3.
This paper has been cited 100+ times, although I'm not sure how many refer to pC3. The recentish paper FBrf0234085 from the same lab does.

Hmm, the pC clusters seem to be characterised by expression of DOUBLESEX, not fruitless. To me, it looks like pC1 and pC2 are not the same thing as the fruitless-expressing neurons that they are listed as exact synonyms for.
FBrf0210397 shows some colocalisation, but this is far from 100%
I think the dsx neurons should have their own classes - there are at least four papers using this set of  terms now (pC, aDN, SN, TN, etc).


[Haxe] Now "Find All References" and "Rename" works with String Interpolation

Result:

We should not be adding this kind of feature in FD built-in engine and move to leveraging the Haxe compiler service to find references.

Okay, so I have to fix it


Feat/46 unit testing

Preparing the application for Unit testing. And making the first few unit tests #46
Following pull request also includes #54

Testing Github builder
Please don't add reviewers or review this PR

Unit testing is integrated and CI/actions has changed to validate unit tests


.zap file upgrade process

Use case is as follows:
1.) You create a .zap file for an application using some set of XML files.
2.) You then at some later point, open the .zap file against a DIFFERENT, usually NEWER set of static ZCL XML files.
3.) At this point zap need to do the following:
a.) Detect that this is the case.
b.) Walk the user through some kind of "upgrade" process upgrading things that need upgrading.
c.) There are things that can happen automatically (new mandatory attributes, cluster versions.)
d.) There are things that have to happen with user assistance, so they need to get some warnings and notifications, etc.
e.) In either case, the final step of the "upgrade" process is telling user what has changed and allowing him to say: "Ooops, sorry, no! Just keep the file as it was! It was a mistake all long, I just loaded wrong XML files...." so user can back-out of the whole upgrade process.

Continuing discussion here:
@tecimovic Why do we want to keep notifications around from an old upgrade?
My understanding is to make sure the user is reminded of what has changed since they created their original app.
What if:
1.) a user loads a very old .zap file that causes an array of upgrades
2.) which displays many notifications describing what has changed - then they save off the newly upgraded file WITHOUT dismissing the notifications
3.) This implies that the saved off file IS upgraded hence would not need any warnings when reloaded
4.) So when they reload this newly saved file, even though it is upgraded, it will show the warnings of the original "old" .zap file.
The more advanced user might find dismissing warnings that used to exist irritating.


SWIFT Compiler Error: 'Material' is ambiguous for type lookup in this context

First it all, Thanks for sharing, the project from the readme it looks a very nice resource to learn about Reality Kit
I have cloned your repo however, when I tried to compile it, I got the the following issue:
'Material' is ambiguous for type lookup in this context
Do you know why it happens?,
Thanks!!

Hi mmolero.
I fixed those errors.
Now, you can build this project.
It has happened on importing SwiftUI(no needed) and RealityKit. System did not know "Material" is which one's.
And I fixed libraries compile errors.
Thank you for telling me about these bugs.
If you have some problem again, please tell me any time.
Daisuke

Now it works
I will let you know if I find more issues
Thanks!!!


Important: Which effects are asynchronous?

Since the redux-saga middleware can resolve Promises, meaning, it behaves similarly to the async / await pattern of using generators, it's unclear which yields (with effects) are synchronous and which are asynchronous.
To clarify, I'm asking, which effects use a Promise / setTimeout / callback function (that could be called asynchronously), inside the middleware.
Obviously all the blocking effects are going to be asynchronous, but what about the non-blocking? Is there a guarantee that the yield to a non-blocking effect will return to the yielding generator in the same event loop cycle (without a context switch)?
If this is ambiguous, could we add it into documentation for each effect?
Why this is important
Every context switch could cause a potential race condition. I need to be able to know when a context switch can happen, to be able to reason about potential order of instruction execution.
The most vulnerable place where this can happen is the rootSaga where you register a lot of listeners (e.g. with takeEvery). Does each yield takeEvery cause a context switch?

You can easily figure this out:
const log = setTimeout(() => console.debug("timeout"),0);

function* root() {
  log();
  yield fork(saga1);
  log();
  yield spawn(saga2)
  log();
  yield put(event);
  log();
}

Didn't run but IMHO all 3 effects are non blocking and will execute before any log statement.
For put effect doc also mentions a blocking put.resolve(action).
Don't know the subtilities of all the effects but IMHO non blocking ones do not involve any context-switch.

Basically all effects are handled synchronously until async thing happens so there is no much context switching there. That means that only things like promises and take (as it set up the one time listener for action) will block and be handled async.

@vjancik
Do you feel that should be expressed better in the docs? would you be willing to provide a small docs PR with it?

Going to close this, if you have any further questions - please just ask :)

I think it would be helpful to list which calls are blocking and which are not.
I was initially confused why takeLatest examples in the docs did not require using all, then discovered that it does not wait.
See the last example here https://redux-saga.js.org/docs/basics/UsingSagaHelpers.html and compare the rest of the document suggesting using all or similar means to manage the root saga: https://redux-saga.js.org/docs/advanced/RootSaga.html
Glossary page defines blocking and non-blocking calls, but does not list which ones are what: https://redux-saga.js.org/docs/Glossary.html
The API reference should also ideally list which function is blocking and which is not. It is using the  word wait, but it would help if it tagged the blocking ones explicitly: https://redux-saga.js.org/docs/api/
Also, I believe at the library level, the names could be changed in the next major version to make this less confusing. Compare Clojure's core.async which provides blocking and non-blocking calls, differing with a ! at the end of the name: https://clojuredocs.org/clojure.core.async/>!! and https://clojuredocs.org/clojure.core.async/>!
Happy to provide a PR for the doc changes or enhancements if this makes sense. Just wanted to outline my experience as a beginner with saga.
Changing the function names probably would require more discussion.

Such list is available here: https://github.com/redux-saga/redux-saga/blob/9949c91d7293e0e216e4c7785360e928625a5757/docs/api/README.md#blocking--non-blocking


Using dkml-base-compiler instead of ocaml-base-compiler

dkml-base-compiler is a new compiler package in the Opam repository. Among other things, it builds a cross-compiler for macOS (x86_64 + ARM64) and unofficially can build cross-compilers for Android (ARM32, etc.).
I can't figure out the command line options so that dkml-base-compiler.4.12.1~v1.0.0 is used as the compiler during opam monorepo lock rather than ocaml-base-compiler.VERSION.
Context: For my own internal needs I have been using the dunified Opam repository but do not use the opam monorepo tools; instead I use Opam build command configuration so that opam install . uses dune -x darwin_arm64 to build every Opam package dependency. That style of cross-compilation may be too complicated for other people. So not only would I like others to use opam monorepo with dkml-base-compiler but I've got some "dkml-workflows" tooling I'll be releasing that will create "native" (including cross-compiled) artifacts on GitHub Actions.
If needed, I have a Makefile that can be used to see the problems doing opam monorepo lock with dkml-base-compiler:
$ git clone https://github.com/diskuv/dkml-workflows-monorepo-example.git
$ cd dkml-workflows-monorepo-example
$ git reset --hard 2afd44bb59d41cf38cb382ad679b03b16fbffc85
$ make monorepo-pull
opam switch create . dkml-base-compiler.4.12.1~v1.0.0 \
          --yes \
          --deps-only \
          --repo default=https://opam.ocaml.org,dune-universe=git+https://github.com/dune-universe/opam-overlays.git

<><> Installing new switch packages <><><><><><><><><><><><><><><><><><><><>  🐫
Switch invariant: ["dkml-base-compiler" {= "4.12.1~v1.0.0"}]
The following actions will be performed:
  ∗ install dkml-base-compiler        4.12.1~v1.0.0
  ∗ install base-unix                 base
...
Done.
# Run eval $(opam env) to update the current shell environment
OPAMSWITCH="$PWD" && if [ -x /usr/bin/cygpath ]; then OPAMSWITCH=$(/usr/bin/cygpath -aw "$OPAMSWITCH"); fi && \
          opam monorepo lock your_example --ocaml-version=4.12.1 --require-cross-compile -vv
opam-monorepo: [DEBUG] Detected local packages:
                       your_example:/private/var/folders/8z/_n2pwgb92fx3sbkgkzhb484m0000gn/T/dkml-workflows-monorepo-example/your_example.opam
==> Using 1 locally scanned package as the target.
opam-monorepo: [INFO] Target package: your_example.
opam-monorepo: [INFO] Solve using current opam switch: /private/var/folders/8z/_n2pwgb92fx3sbkgkzhb484m0000gn/T/dkml-workflows-monorepo-example
opam-monorepo: [DEBUG] Removed dkml-base-compiler from formula as it is opam-provided
opam-monorepo: [DEBUG] Removed dkml-base-compiler from formula as it is opam-provided
opam-monorepo: [DEBUG] Removed dkml-base-compiler from formula as it is opam-provided
opam-monorepo: [DEBUG] Removed conf-dkml-cross-toolchain from formula as it is opam-provided
opam-monorepo: [INFO] Selected packages from dune-only run of solver: astring.0.8.5+dune,
                      base.v0.15.0, base-bigarray.base, base-bytes.base,
                      base-threads.base, base-unix.base, bos.0.2.1+dune,
                      camlp-streams.5.0.1, camomile.1.0.2,
                      cmdliner.1.1.1+dune, cppo.1.6.9, csexp.1.5.1,
                      diskuvbox.0.1.0, dune.3.4.1, dune-build-info.3.4.1,
                      dune-configurator.3.4.1, either.1.0.0,
                      findlib.1.8.1+dune, fix.20220121, fmt.0.9.0+dune,
                      fpath.0.7.3+dune, headache.1.05, logs.0.7.0+dune2,
                      lwt.5.6.1, mdx.2.1.0, menhir.20220210,
                      menhirLib.20220210, menhirSdk.20220210, ocaml.4.12.1,
                      ocaml-base-compiler.4.12.1,
                      ocaml-compiler-libs.v0.12.4, ocaml-config.2,
                      ocaml-options-vanilla.1, ocaml-version.3.5.0,
                      ocamlfind.1.8.1+dune, ocamlformat.0.24.1,
                      ocp-indent.1.8.1, ocplib-endian.1.2, odoc-parser.2.0.0,
                      ppx_derivers.1.2.1, ppx_deriving.5.2.1, ppxlib.0.27.0,
                      re.1.10.4, result.1.5, rresult.0.7.0+dune,
                      seq.base+dune, sexplib0.v0.15.1, stdio.v0.15.0,
                      stdlib-shims.0.3.0, uchar.0.0.2+dune2,
                      uucp.14.0.0+dune, uuseg.14.0.0+dune, uutf.1.0.3+dune,
                      your_example.zdev
opam-monorepo: [ERROR] Solving opam-provided dependencies could not find a solution
opam-monorepo: [ERROR] Can't find all required versions.
Selected: conf-dkml-cross-toolchain.4.12.1 ocaml-base-compiler&your_example
          ocaml-base-compiler ocaml-base-compiler ocaml ocaml-base-compiler
          ocaml-system
- astring -> astring.0.8.5+dune
    User requested = 0.8.5+dune
...
- dkml-base-compiler -> (problem)
    Rejected candidates:
      dkml-base-compiler.4.12.1~v1.0.0: In same conflict class (ocaml-core-compiler) as ocaml-base-compiler
...
- ocaml-options-vanilla -> ocaml-options-vanilla.1
    User requested = 1
- ocaml-system -> (problem)
    Rejected candidates:
      ocaml-system.4.12.1: In same conflict class (ocaml-core-compiler) as ocaml-base-compiler
...
make: *** [your_example.opam.locked] Error 1

For now I'm hand editing the .locked file.

Hi @jonahbeckford. I'm afraid that's currently not possible since the compiler names are hardcoded because for dependency resolution these have to be special-cased.
However, it should be possible to rework the code to e.g. allow overwriting the default name of the compiler and using the flags: compiler field from OPAM to avoid having to hardcode ocaml-variants and ocaml-base-compiler in the base_packages, which I think would be a solid improvement.


Materialize Select Problem

Hi...
I don't know if this a bug or not, i create a form with with a select and a text area. 2 button for reset and submit, the problem is when i click the select, the button is floated in front of select options.

Looks like a bug. The dropdown menu should have higher z-index IMO.

there is https://github.com/Dogfalo/materialize/issues/1337 which says it's fixed but not released - I have the same problem but I don't know when next release happens

i think it release with many bug fixed or new feature, hope so...

i put this in extra.css.
dropdown-content {
z-index: 3;
}
and works

This was still an issue in version 0.96.1, but appears to have been fixed with 0.97.1.


Constant crashes of rainmeter out of the box

After installation of WebNowPlaying v2.0.7 and enabling it got crashes of rainmeter

send me the log from eventviewer

Faulting application name: Rainmeter.exe, version: <IP_ADDRESS>03, time stamp: 0x66cdefa9
Faulting module name: KERNELBASE.dll, version: 10.0.19041.4717, time stamp: 0x16b0a901
Exception code: 0xe0434352
Fault offset: 0x000000000003b699
Faulting process id: 0xa580
Faulting application start time: 0x01daff9ab66e478a
Faulting application path: C:\Program Files\Rainmeter\Rainmeter.exe
Faulting module path: C:\Windows\System32\KERNELBASE.dll
Report Id: 461bdee8-9eff-47b7-a6b6-a0395cdeea92
Faulting package full name:
Faulting package-relative application ID:

Application: Rainmeter.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Net.HttpListenerException
   at System.Net.HttpListener.AddAllPrefixes()
   at System.Net.HttpListener.Start()
   at WNPReduxAdapterLibrary.WNPHttpServer+<StartThreaded>d__6.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

someone on the rainmeter discord fixed the same problem like this, give it a shot and see if that's also your problem.

No, still crashes

tried a simple restart? anything else using the port 8974?

I don't know what the reason but somehow after a time it starts work. My suggestion playing with firewall was helpful, thnx

alright


Build does not fail if x11 is not installed on build machine

Describe the bug
When building xfreerdp (version 2.0.0-rc4 in my case), the build did not fail (what I would have expected) when not finding the x11 dependencies in the system.
The build setup only built the library parts of the package, but not the actual xfreerdp binary.
There was no error that x11 dependencies where missing.
To Reproduce
Steps to reproduce the behavior:

Spin up a VM/container/whatever without x11 installed at all (in my case I used a centos6.7, but I'm positive that this might also happen on other unices without x11 installed)
Try the default ./configure && make or cmake build
try to find the xfreerdp binary. I didn't.

Expected behavior
A clear error and failed build because building a X binary without X development libraries installed on the system can never(?) work?
** Application details

Version of FreeRDP: v2.0.0-rc4
Command line used: not applicable
output of /buildconfig: No such file or directory
OS version connecting to: Not applicable

Desktop (please complete the following information):
Not applicable
Smartphone (please complete the following information):
Not applicable

@matthiasbeyer Could you give some more detailed data on your build? (e.g. cmake run output)?

On a sidenote, there is not ./configure && make for freerdp...
X11 is not strictly required to build freerdp (only if you try to build e.g. xfreerdp)


[FLOC-2542] CentOS logs

Corresponding master fix for #1729.

Thanks @itamarst
I'll merge this so that @jongiddy can create a release PR.


Unable to build for ios

Currently unable to build for ios platform even after removing and re-adding it. It just get stuck halfway (as per screenshot)
ionic build ios --release
Tried using cordova-ios 4.2.1, 4.1.1 and 4.1.0
I have also tried starting a brand new ionic app, which result in the same problem

My current system information:
Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.3.0
Xcode version: Xcode 8.0 Build version 8A218a

I have the exact same problem, I even tried with different version of ionic and cordova in case it was related (ionic 1.7.16 and cordova 5.4.1 lead to the same problem)
system information using the script provided:
Cordova CLI: 6.4.0
Ionic CLI Version: 2.1.8
Ionic App Lib Version: 2.1.4
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: OS X El Capitan
Node Version: v6.7.0
Xcode version: Xcode 8.1 Build version 8B62
Here is a script that helps reproducing the issue:
#!/usr/bin/env bash

BASE_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)

CORDOVA_VERSION=6.4.0
IONIC_VERSION=2.1.8

TOOLS_FOLDER="${BASE_DIR}/tmp_tools"
PROJECT_NAME="demo"
PROJECT_FOLDER="${BASE_DIR}/${PROJECT_NAME}"

if ! which yarn > /dev/null ; then
  echo "Yarn already installed"
else
  echo "Installing yarn globally to speed up installing ionic/cordova packages"
  npm install -g yarn
fi

echo "Creating a local node_module for ionic and cordova"
mkdir -p "${TOOLS_FOLDER}"
cd "${TOOLS_FOLDER}"

rm -rf "${TOOLS_FOLDER}/node_modules"
yarn add --no-lockfile cordova@${CORDOVA_VERSION} ionic@${IONIC_VERSION} || { echo "An error occured while installing cordova/ionic, restart the script"; exit 1; }

# Exporting it to path in order to get access to it from command line directly
PATH="${TOOLS_FOLDER}/node_modules/.bin:$PATH"

ionic info

echo "Recreating ionic project ${PROJECT_NAMWE} in ${PROJECT_FOLDER}"
#Delete any previous version of the project
rm -rf "${PROJECT_FOLDER}"
ionic start --appname "${PROJECT_NAME}" --id "com.test.${PROJECT_NAME}" "${PROJECT_FOLDER}"
cd "${PROJECT_FOLDER}"

echo ""
echo "#####################################################################################"
echo ""
echo "Debug build will fail because of signing issue and it's normal, at least it builds!"
echo "Press a key to build debug version"
read
ionic build ios --device

echo ""
echo "#####################################################################################"
echo ""
echo "The build will fail silently if you add the --relase flag"
echo "Press a key to build release version"
read

ionic build ios --device --release

echo "The release build is completed (but the process did not complete)"

PS: Also with ionic >= 2 or cordova >= 6, the emulator won't start on the first try for some reason using the same project creation process

Hi @cnadeau, are you on Sierra? You could try to move your files to a folder that doesn't sync with iCloud (i.e. Downloads folder). That seems fix the problem. Let me know how that goes.

No, El-Captain, just did tried in ~/Downloads but still, I get the same behavior
Thanks for the suggestion :-)


Cannot run project

Error:
System.DllNotFoundException: Unable to load DLL 'libuv': The specified module could not be found.
(Exception from HRESULT: 0x8007007E)
   at Microsoft.AspNet.Server.Kestrel.Networking.Libuv.NativeMethods.uv_loop_size()
   at Microsoft.AspNet.Server.Kestrel.Networking.UvLoopHandle.Init(Libuv uv)
   at Microsoft.AspNet.Server.Kestrel.KestrelThread.ThreadStart(Object parameter)

OS: Ubuntu 14.04
Runtime: CoreCLR

@aayushkapoor206 I had the same issue yesterday on Windows when updating to the latest packages. It seems the libuv.dll is in the runtimes folder of the Microsoft.AspNetCore.Server.Kestrel package but not lib folder.
Assuming its the same to fix on Ubuntu, go to your packages folder, find ..\Microsoft.AspNetCore.Server.Kestrel\ and copy the dll from the relevent runtimes folder to the lib folder everywhere where your Microsoft.AspNetCore.Server.Kestrel.dll exists. Hopefully that will get you up and running again.

If you're using rc1 packages you actually need to install libuv yourself.
sudo apt-get install make automake libtool curl
curl -sSL https://github.com/libuv/libuv/archive/v1.8.0.tar.gz | sudo tar zxfv - -C /usr/local/src
cd /usr/local/src/libuv-1.8.0
sudo sh autogen.sh
sudo ./configure
sudo make
sudo make install
sudo rm -rf /usr/local/src/libuv-1.8.0 && cd ~/
sudo ldconfig

https://docs.asp.net/en/latest/getting-started/installing-on-linux.html?highlight=libuv#install-libuv
It's definitely a pain. RC2 will be shipping with libuv.so.


[SUPPORT]

When the partition column contains the slash character ("/"), Hudi could write the data incorrectly or do not read the back.
Test (I use some helpers to write and read Hudi data, they write write data to the local FS and read it):
class HudiPartitionPathTest extends AnyFlatSpec with Matchers with TestHudi {
  "Partition paths" should "be generated properly" in {
    val data = rows(
      (1, "one", "partition with space"),
      (2, "two", "partition with space"),
      (3, "three", "partition-with-dashes"),
      (4, "four", "partition-with-dashes"),
      (5, "five", "partition="),
      (6, "six", "partition="),
      (7, "seven", "partition%"),
      (8, "eight", "partition%"),
      (9, "nine", "partition"),
      (10, "ten", "partition"),
      (11, "eleven", "partition/"),
      (12, "twelve", "partition/"),
      (13, "thirteen", "partition/slaanesh"),
      (14, "fourteen", "partition/slaanesh")
    )
    val path = createHudiDataset(
      getClass.getName,
      data,
      schema("id" -> "int", "value" -> "string", "partition" -> "string")
    )
    val fsPartitionPaths = allFSPartitionPaths(new File(path), path.length + 1)
    println(fsPartitionPaths mkString "\n")
    val df = readHudiDataset(path)
    df show false
    val partitionPaths = df.select("_hoodie_partition_path").dropDuplicates.collect().map(_.getString(0)).toSet
    fsPartitionPaths shouldEqual partitionPaths
  }

  private val filter: FilenameFilter = (_, name) => !name.startsWith(".")

  def allFSPartitionPaths(dir: File, prefixLength: Int): Set[String] =
    (dir.listFiles(filter) foldLeft Set.empty[String]) { (paths, file) =>
      if (file.isFile) paths + file.getParent.substring(prefixLength)
      else paths | allFSPartitionPaths(file, prefixLength)
    }
}

The output is
daas_date=partition
daas_date=partition-with-dashes
daas_date=partition with space
daas_date=partition%
daas_date=partition/slaanesh
daas_date=partition=
+-------------------+---------------------+------------------+-------------------------------+-----------------------------------------------------------------------+---+------+---------------------+-------------------+
|_hoodie_commit_time|_hoodie_commit_seqno |_hoodie_record_key|_hoodie_partition_path         |_hoodie_file_name                                                      |id |value |daas_date            |daas_internal_ts   |
+-------------------+---------------------+------------------+-------------------------------+-----------------------------------------------------------------------+---+------+---------------------+-------------------+
|20240226105035783  |20240226105035783_6_0|11                |daas_date=partition/           |961e9ba8-acef-4957-9357-7032702f1bb2-0_6-4-16_20240226105035783.parquet|11 |eleven|partition/           |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_6_1|12                |daas_date=partition/           |961e9ba8-acef-4957-9357-7032702f1bb2-0_6-4-16_20240226105035783.parquet|12 |twelve|partition/           |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_1_0|9                 |daas_date=partition            |9f1a3606-25a2-4e79-93fe-f0c03c86cf3d-0_1-4-11_20240226105035783.parquet|9  |nine  |partition            |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_1_1|10                |daas_date=partition            |9f1a3606-25a2-4e79-93fe-f0c03c86cf3d-0_1-4-11_20240226105035783.parquet|10 |ten   |partition            |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_2_0|3                 |daas_date=partition-with-dashes|49d7ac36-67ba-44df-be90-9d73b51fdbc2-0_2-4-12_20240226105035783.parquet|3  |three |partition-with-dashes|2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_2_1|4                 |daas_date=partition-with-dashes|49d7ac36-67ba-44df-be90-9d73b51fdbc2-0_2-4-12_20240226105035783.parquet|4  |four  |partition-with-dashes|2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_3_0|1                 |daas_date=partition with space |9d33b484-0e8c-4299-ab8b-235d6c3a3d5d-0_3-4-13_20240226105035783.parquet|1  |one   |partition with space |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_3_1|2                 |daas_date=partition with space |9d33b484-0e8c-4299-ab8b-235d6c3a3d5d-0_3-4-13_20240226105035783.parquet|2  |two   |partition with space |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_0_0|7                 |daas_date=partition%           |8e4bfc08-37f8-4f4e-877b-ff5b2218dbd5-0_0-4-10_20240226105035783.parquet|7  |seven |partition%           |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_0_1|8                 |daas_date=partition%           |8e4bfc08-37f8-4f4e-877b-ff5b2218dbd5-0_0-4-10_20240226105035783.parquet|8  |eight |partition%           |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_5_0|5                 |daas_date=partition=           |1134b457-b713-48e2-ace4-a99981b3efd8-0_5-4-15_20240226105035783.parquet|5  |five  |partition=           |2024-02-26 08:25:05|
|20240226105035783  |20240226105035783_5_1|6                 |daas_date=partition=           |1134b457-b713-48e2-ace4-a99981b3efd8-0_5-4-15_20240226105035783.parquet|6  |six   |partition=           |2024-02-26 08:25:05|
+-------------------+---------------------+------------------+-------------------------------+-----------------------------------------------------------------------+---+------+---------------------+-------------------+

As you can see rows 13 and 14 was not read, and "partition" and "partition/" on the file system have the same path (I am not sure about the impact, but probably there could be performance issues).
Maybe it would be great to quote some characters in partition paths?
Environment Description

Hudi version :
0.13.1

Storage (HDFS/S3/GCS..):
Local FS

you are right, we should enode the partition path for these special characters.

@eshu I tried to insert these values and at least read/write worked fine. I do understand in case of slash it created the inner sub folder. Were you able to make it work by encoding them. Let us know in case you need any other help here or Feel free to close if all good.
columns = ["ts","uuid","rider","driver","fare","city"]
data =[(1695159649087,"334e26e9-8355-45cc-97c6-c31daf0df330","rider-A","driver-K",19.10,"san francisco"),
<PHONE_NUMBER>788,"e96c4396-3fad-413a-a942-4cb36106d721","rider-B","driver-L",27.70 ,"san-francisco"),
<PHONE_NUMBER>179,"9909a8b1-2d15-4d3d-8ec9-efc48c536a00","rider-C","driver-M",33.90 ,"san_francisco%"),
<PHONE_NUMBER>016,"e3cf430c-889d-4015-bc98-59bdce1e530c","rider-C","driver-N",34.15,"sao/paulo")]

spark = get_spark_session(spark_version="3.2", hudi_version="0.13.0")

inserts = spark.createDataFrame(data).toDF(*columns)

hudi_options = {
    'hoodie.table.name': tableName,
    'hoodie.datasource.write.recordkey.field' : 'uuid',
    'hoodie.datasource.write.precombine.field' : 'ts',
    'hoodie.datasource.write.partitionpath.field': 'city',
}
# Insert data
inserts.write.format("hudi"). \
    options(**hudi_options). \
    mode("overwrite"). \
    save(basePath)

spark.read.format("hudi").load(basePath).show()

@ad1happy2go It does not work in my example. Did you tried it?

Yes I tried this - https://github.com/apache/hudi/issues/10754#issuecomment-1979027421
Can you try the same?

@eshu Any updates on the same?


fix: move development dependencies to devDependencies

Closes #158

Seriously thanks again for calling that out and fixing it!

No problem!


If Conda needs this, they can patch it themselves

The title of this PR is a little hostile.
I'll gladly provide input on behalf of conda packagers if you need some in the future.

but I agree, we can patch things ourselves, but it does help to collaborate....


Change store path

Pull Request Test Coverage Report for Build 967

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 88.048%

Files with Coverage Reduction
New Missed Lines
%

broker/lib/fabrik/DBManager.js
1
98.85%

Totals

Change from base Build 961:
-0.02%

Covered Lines:
6205

Relevant Lines:
6818

💛  - Coveralls


Preformatted text is partly hidden

I can't read preformatted text in a post completely cause the part beyond the right edge is unreachable. In the browser version preformatted text is fully accessible by horizontal scrolling (in Fennec, my old Jolla Browser has the same problem).
For example see topic: Can't call/Audio not working
Jolla Phone with SFOS <IP_ADDRESS> and SFOS Forum Viewer 0.7.4

I'm afraid open in webview/browser will have to work as a workaround, seen how quickddit does it and it's buggy as hell (the horizontal scroll causes half of the clicks to incorrectly register and you can get stuck in the middle of a long code post which hardly ever scrolls as half of the clicks get lost), without reparsing the whole richtext and manually wrapping... yeah not something we'll do anytime soon. If you've seen an app that does it properly pls reopen, might reinvestigate it then


Remove znet-bookkeeping.[h|c] files

Problem
In order to makes it easier to move forward on #3464, I'm trying to extract the parts that are not fully dependent on ZAP.
It should makes it easier to understand the scope of various changes from #3464
This PR is the part of #3464 that removes znet-bookkeeping.h and net-bookkeeping.c files from the gen/ folders.
Summary of Changes

Delete znet-bookeeping.h and net-bookkeeping.c files from the various gen/ folders.
Update the name of some methods in src/app/util/af-main-common.c and src/app/util/util.cpp with the Callback prefix. Basically the znet-bookkeeping methods were just calling those
emAfInit -> emberAfInit. emAfInit uses to call emberAfMainInitCallback and emberAfInit and emberAfMainInitCallback was an empty stub.

I pushed an update that removes the changes to the nrf5 examples since #3605 has removed them.

@jelderton @saurabhst @BroderickCarlin @hawk248 ?


[Dev-Build] support building with FIPS feature

Requirements
Support building binaries and images for these components:

[x] TiDB
[x] TiKV
[x] PD
[x] TiCDC
[x] BR
[ ] Dashboard
[ ] Operator

Required informations
Go version
go 1.21.x
How to build

[ ] TiDB pingcap/tidb
[ ] TiKV tikv/tikv
[ ] PD tikv/pd
[ ] TiCDC pingcap/tiflow
[ ] BR pingcap/tidb
[ ] Dashboard pingcap/tidb-dashboard
[ ] Operator pingcap/tidb-operator

Which one is need to change the runtime base images?

[ ] TiKV's base image: https://github.com/tikv/tikv/pull/15944/files#diff-ee3aa9f430cddf671a78d1a6c60b26067bfe2f1c4d6f5be04dd8731fd1474ea5

To build such binary, we can add an env variable "ENABLE_FIPS=1".
E.g.,
PD: make build -> ENABLE_FIPS=1 make build
TiDB: make server  -> ENABLE_FIPS=1 make server
TiKV: ROCKSDB_SYS_STATIC=1 make dist_release -> ENABLE_FIPS=1 ROCKSDB_SYS_STATIC=1 make dist_release

Is it enough, do we need to change buider image and product image?

Implementation of building logic: https://github.com/PingCAP-QE/ci/pull/2615

We need to support one more project:

https://github.com/pingcap/ng-monitoring, ENABLE_FIPS=1 make

complete tidb-dashboard in https://github.com/PingCAP-QE/ci/pull/2721

tikv runtime dockerfile: https://github.com/PingCAP-QE/artifacts/blob/main/dockerfiles/products/tikv-fips.Dockerfile


Dev to sprint

It's like deja vu. Like I've been here before...

It's like deja vu. Like I've been here before...


ENH 2022.20

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin rerender

@conda-forge-admin rerender

@conda-forge-admin rerender

@conda-forge/core Do you all understand the rerender results here? I put cfitsio 4.0.0 in a local conda_build_config.yaml but the ci support files still have 4.1.0 in them.

@conda-forge-admin rerender


⚠ Bofrost.at has degraded performance

In 106e334, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1573 ms

Resolved: Bofrost.at performance has improved in 5855a79.


Update/fix loader errors associated with the new study doc

FEATURE REQUEST
Inspiration
The implementation of the new StudyLoader broke a few things.  Attempting to load existing data runs into exceptions unrelated to the validity of the data.
Description
The following are some errors as reported in our testing in #1040.

[x] #1061

[x] This was a formula difference.  This might be a real error.  Get-or-create couldn't find the compound using the name and formula perhaps and added a row, causing a difference @hepcat72

[x] I think these errors were fixed in the latest version, but check that they are no longer an issue:

[x] Tracers sheet was unaltered, but resulted in an error that the Tracer Group Name "None" was used for multiple rows. @hepcat72
~[ ] #1062~
[x] Unable to convert column Run Length to type int64 @hepcat72
[x] expected str, bytes or os.PathLike object, not NoneType @hepcat72
~[ ] #1063~

Alternatives

None
Dependencies

#1040
#1037

Comment

None

ISSUE OWNER SECTION
Assumptions

List of assumptions that the code will not explicitly address/check
E.g. We will assume input is correct (explaining why there is no validation)

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected Components

change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job

Requirements

[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking

DESIGN
Interface Change description

None provided
Code Change Description

None provided
Tests

[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking

I converted 2 of the items in this issue to separate issues.  They are not critical issues.  Avoiding errors that have to do with a previous loader error by skipping subsequent loads is only to avoid errors.  Users can just ignore those error for now (by addressing errors top to bottom. The other error about empty lines can be fixed by users by removing empty lines.  The old loaders avoided this by the fact that there was an option in the sheet merge to skip empty rows.  We no longer merge sheets prior to the load attempt.  We can add a feature to skip those empty rows, but it's a "nice-to-have" feature.

The code is done for this. I will put a branch on dev, but I should break it up into multiple PRs.

Critical exceptions that cause the web page not to render are fixed.  All other exceptions listed in the status report are less critical and will be handled by separate issues.


support Windows paths in error parser

Hopefully this works.  It's a bit hard to tell as tests never pass on Windows.  Spin the CI wheel! 😃

Oh, I was expecting CI to run the tests 🤭

probably better to try on the windows-ci branch?

this will be superceded in the 0.11 which will have proper windows support


[Feature Request] [MGS3]: Option to disable the forced 4x MSAA

Feature Summary:
I want to play the game without it being in slow-motion, but my main computer is dead and I only have a laptop right now. An option to disable the 4x MSAA would improve my framerate.
Is your proposal related to a problem?
MGS3 runs at 30fps max in 800x600, which shouldn't happen with a PS2 game. PC Gaming Wiki says the game uses a forced 4x MSAA that can't be disabled, which I suspect is the cause.
Describe the solution you'd like
An option to completely disable anti-aliasing.
Describe alternatives you've considered
None

which shouldn't happen with a PS2 game
MGS3 in the MC isn't a PS2 game, it's a HD Remaster made for the PS3 with chunks of the engine replaced with Bluepoint's Blast Factor remaster engine, which was then ported to DirectX 11 nearly a decade later.

Assuming you're using a nvidia graphics chip, follow this guide - it fixes the issue 9 out of 10 times.
https://www.youtube.com/watch?v=rvaAfCBCJ2M

if it doesn't would you mind sharing what your laptop's GPU is?

It's an 10th gen Intel UHD Graphics. I guess I probably should've expected it to not run well...

Ah.
https://gpu.userbenchmark.com/Compare/Nvidia-GTX-970-vs-Intel-Iris-Plus-G7/2577vsm888370
Unfortunately your Integrated graphics chip is WAY below the minimum system requirements for MGS3.

System Requirements
Minimum:
    Requires a 64-bit processor and operating system
    OS: Windows 10(64-bit OS required)
    Processor: Intel(R) Core(TM) i5-7500
    Memory: 8 GB RAM
    Graphics: NVIDIA GeForce GTX 970
    DirectX: Version 11
    Storage: 15 GB available space
    Sound Card: DirectX 11 compatible sound card
    Additional Notes: Xinput Controller required

Yeah, guess I'll just have to wait till my computer is fixed


New version: evernote.evernote version 10.71.2

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

In what way is this 10.71.2?


Submit recovery code when enter is pressed

Details

Submit recovery code when enter is pressed
Fixed Issues

$ https://github.com/Expensify/App/issues/28092
PROPOSAL: https://github.com/Expensify/App/issues/28092#issuecomment-1736938685
Tests

Sign in with account who has 2fa enabled
Enter magic code from email
In authenticator code step switch to using recovery code
Enter any recovery code and press enter
Make sure pressing enter submits the input

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/59907218/6ee1d106-c3ff-497a-8619-f7880af0da4c

Mobile Web - Chrome
https://github.com/Expensify/App/assets/59907218/0c56e48a-fe5b-47c1-a6c7-4105df34766d

Mobile Web - Safari
https://github.com/Expensify/App/assets/59907218/e356526e-1d0e-4ffa-9316-d6dc6347db53

Desktop
https://github.com/Expensify/App/assets/59907218/a7b0c9fa-f062-4b1e-bd5f-067eb9d0a1bf

iOS
https://github.com/Expensify/App/assets/59907218/99b4b7f9-5e41-4f7e-9beb-0e4de6826ded

Android
https://github.com/Expensify/App/assets/59907218/e5c303f1-e43b-495a-aa2b-a27ad99990cf

@alitoshmatov The enter key is not working in safari?

@abdulrahuman5196
Yes it is not working, but I think it is a separate issue, since it is consistently not working in other parts of the app too
https://github.com/Expensify/App/assets/59907218/2eb815c2-41cc-4eff-8c4e-9502fd184a2c

@abdulrahuman5196 Yes it is not working, but I think it is a separate issue, since it is consistently not working in other parts of the app too

If so could you kindly link any GH is available or report a new bug in bugs slack channel?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/46707890/1e8cd522-d740-4657-aa37-0de09d455c46

Mobile Web - Chrome

https://github.com/Expensify/App/assets/46707890/112e5c4e-8817-45c1-808c-c5a4d21a17ef

Mobile Web - Safari

Desktop

https://github.com/Expensify/App/assets/46707890/2ea72d61-74f8-4b50-8746-59804620a2a0

iOS

https://github.com/Expensify/App/assets/46707890/37c9c71d-5656-4a16-8dad-f799dbb2861b

Android

https://github.com/Expensify/App/assets/46707890/76bcf254-8a77-46ce-b0da-12ca7bb5e9a5

Could not find existing issue. Reported it in the slack

@abdulrahuman5196 pressing 'go' button works for me on safari and native iOS app. I'm on iOS 17.0.2

@MonilBhavsar Another issue is created for this https://github.com/Expensify/App/issues/28569, and it seems like this is fixed by another PR. Would be great if we could merge this pr if no other issues left

Sounds good, thanks!
I'm assigned to that issue, so will follow up

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.78-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.79-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


PBL-25234, PBL-25484 can't cope with per-identifier targetPlatforms

This adds full support (to the beta.cloudpebble.net branch) for resources with multiple identifiers, where each identifier may have a different setting for 'targetPlatforms', bringing CloudPebble closer to fully supporting all facets of Pebble's appinfo.json
The following screenshot shows how the interface is now able to display multiple IDs for a PNG resource, and each ID has a delete button. (fixing "PBL-25484 Cannot delete secondary font configurations in CloudPebble")

As with fonts at the moment, a button at the bottom of the page allows users to add a new identifier.

This PR needs to be reopened against the correct branch.

New PR: #234


Update tough-cookie version due to security vulnerability

There has been a new release of tough-cookie to fix the following:
The tough-cookie module is vulnerable to regular expression denial of service. Input of around 50k characters is required for a slow down of around 2 seconds.

Unless node was compiled using the -DHTTP_MAX_HEADER_SIZE= option the default header max length is 80kb so the impact of the ReDoS is limited to around 7.3 seconds of blocking.

At the time of writing all version <=2.3.2 are vulnerable

See: https://nodesecurity.io/advisories/525

Coverage remained the same at 100.0% when pulling 7f2bff24ccab9458bf49e580c8e611329b397a4b on sophieklm:tough-cookie-update into 7239e1e41d475ef840375ace4a6cbc6d8b53ce1e on request:master.

Thanks a lot @sophieklm ! I just published<EMAIL_ADDRESS>which includes the fix.