chore(Dashboard): Simplify scoping logic for cross/native filters

SUMMARY
PR https://github.com/apache/superset/pull/30438 introduced optimizations to enhance performance by reducing backend requests for cross and native filters. However, due to a lack of clarity around the specific use cases these functionalities are meant to support, and in response to reports of certain broken use cases (such as https://github.com/apache/superset/issues/30687), this PR simplifies the scoping logic to accommodate all use cases while still addressing the original issue of preventing requests for charts that are out of scope.
Specifically:

When in global scope, all charts will be affected by the filter
When in specific scope, only the selected charts will be affected by the filter

Fixes https://github.com/apache/superset/issues/30687
TESTING INSTRUCTIONS

Create a native or cross filter
Change the scope to be global
All charts will be affected by the filter
Change the scope to only specific charts
Only charts that were selected should be affected by the filter

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

cc @fmannhardt @Mainer-g00t @fbgeobit

/testenv up

@geido I'm not sure if this bug is related to your PR but it's something really important to make your changes clear for users.
https://github.com/user-attachments/assets/1ab2a1e0-93e9-4714-9eaf-b3ffc4025b87
The applied scopes seems to be correct when loading and highlighting charts. It looks like there's a bug when rendering the scope tab as it's not correctly identifying that not all charts are selected.

https://github.com/user-attachments/assets/96c90e0f-5325-4785-ba2b-243e0adcf27c
Given that the first chart belongs to a different dataset but was selected in the scope:

Should it indicate that the filter was applied?
Should the query also apply the filter?

Should it indicate that the filter was applied?
Should the query also apply the filter?

@michael-s-molina the backend takes the judgement here about what should be applied and what not. I think if the filter is inapplicable it should not be applied and there should not be an indication as well. The user is informed that the chart will reload by loading when the filters get applied, that should give enough confidence to the user that there was an attempt to apply the filter but it was deemed inapplicable at query time.

The applied scopes seems to be correct when loading and highlighting charts. It looks like there's a bug when rendering the scope tab as it's not correctly identifying that not all charts are selected.

I believe this issue existed in master due to excessive optimizations of the state. I'have fixed it in the latest commit.

/testenv up


improvements to test scripts

There is no need to run test-setup.sh for test-couchdb
When we check out the pouchdb git repo, we can use --depth 1 to make it faster

timebomb after 24 hours


What's the purpose of keeping LoginConfig in a separate package?

Unlike all the other elements the LoginConfig annotation sits lonely in an org.eclipse.microprofile.auth package.
This is at least weird especially when JPMS (Jigsaw) style modularity comes into play and sooner or later this will affect Jakarta EE given the service loading mechnism via the old "services" folder does not work anymore if you use a newer JDK and modules and it may eventually be replaced completely.
It should work to have more than one top level package even in a modular MP JWT but why was only this annotation separated, was the idea to eventually migrate or graduate it into Jakarta EE annotations?

Hey @keilw I'm going to close this one as a duplicate of #182 - where we are actually considering to drop this annotation altogether - I'd prefer not to keep one issue discussing removing it and another one proposing a breaking move to a different package - even if we do keep it in 2.0 then it would be the last thing I'd consider prioritizing upon - please do not hesitate to put your argument for keeping it at #182

Hey @keilw I'm going to close this one as a duplicate of #182 - where we are actually considering to drop this annotation altogether - I'd prefer not to keep one issue discussing removing it and another one proposing a breaking move to a different package - even if we do keep it in 2.0 then it would be the last thing I'd consider prioritizing upon - please do not hesitate to put your argument for keeping it at #182

@keilw I commit to re-opening it if the resolution of #182 would be to keep LoginConfig around, thank you

@keilw I commit to re-opening it if the resolution of #182 would be to keep LoginConfig around, thank you


[FLINK-5886] Python API for streaming applications

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

It may take a while until i can review this; the 1.3 feature freeze just kicked in and it's time to test all the new features in depth.

In the last change, I've rebased locally on top of origin/master, so I did git push -f to the master branch in my fork.

I'm gonna take a deeper look now, and play around with it a bit.
Be aware that if you rebase the branch again you will hit a myriad of checkstyle violations, we will have to suppress the checks for method names for this module.

I can't seem to get the tests running.
In the IDE i get this exception:
null
Traceback (most recent call last):
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_7475612982544297474\plan.py", line 3, in <module>
    run_all_testsae1bf92fc871d56dae4598b332a87804.main()
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_7475612982544297474\run_all_testsae1bf92fc871d56dae4598b332a87804.py", line 71, in main
    Main().run()
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_7475612982544297474\run_all_testsae1bf92fc871d56dae4598b332a87804.py", line 45, in run
    tests.append(__import__(test_module_name, globals(), locals()))
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_7475612982544297474\test_filter.py", line 25, in <module>
    from utils.python_test_base import TestBase
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_7475612982544297474\utils\python_test_base.py", line 19, in <module>
    from org.apache.flink.api.java.utils import ParameterTool
java.lang.NoClassDefFoundError: org/apache/flink/api/java/utils (wrong name: org/apache/flink/api/java/Utils)
	at java.lang.ClassLoader.defineClass1(Native Method)

On the command-line the tests do run, but fail with this exception:
Submitting job ... 'test_filter'
Get execution environment
2> (50, u'hello')
null
Traceback (most recent call last):
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_-7332098182433468284\plan.py", line 3, in <module>
    run_all_testsae1bf92fc871d56dae4598b332a87804.main()
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_-7332098182433468284\run_all_testsae1bf92fc871d56dae4598b332a87804.py", line 71, in main
    Main().run()
  File "C:\Users\Zento\AppData\Local\Temp\flink_streaming_plan_-7332098182433468284\run_all_testsae1bf92fc871d56dae4598b332a87804.py", line 59, in run
    print("\n{}\n{}\n{}\n".format('#'*len(ex_type), ex_type, '#'*len(ex_type)))
TypeError: object of type 'java.lang.Class' has no len()
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.835 sec <<< FAILURE! - in org.apache.flink.streaming.python.api.PythonStreamBinderTest
testJob(org.apache.flink.streaming.python.api.PythonStreamBinderTest)  Time elapsed: 17.393 sec  <<< FAILURE!
java.lang.AssertionError: Error while calling the test program: null

When running the example against a local cluster i got this exception
java.io.IOException: java.io.IOException: The given HDFS file URI (hdfs:/tmp/flink_cache_-4117839671387669278) did not describe the HDFS NameNode. The attempt to use a default HDFS configuration, as specified in the 'fs.hdfs.hdfsdefault' or 'fs.hdfs.hdfssite' config parameter failed due to the following problem: Either no default file system was registered, or the provided configuration contains no valid authority component (fs.default.name or fs.defaultFS) describing the (hdfs namenode) host and port.

Regarding the exception -
java.io.IOException: java.io.IOException: The given HDFS file URI ...
In general, using the python interface requires a valid configuration of shared file system (.e.g HDFS), which designed to distribute the python files.
Someone can bypass this issue by set the second argument to 'True' when calling to env.execute(...) in the python script.

I'm trying to track down the root cause for the checks failures without a success. Obviously, the given project (flink-libraries/flink-streaming-python) in master branch passes the verify with success in my environment.
Please advise,

The check failed because the spotbugs plugin found something; this plugin isn't run by default when calling mvn verify. You can run the spotbugs locally by adding -Dspotbugs to the maven invocation.
The found problem is the PythonEnvironmentConfig class, which contains public static non-final fields. I propose making these non-static and explicitly pass around a config object where needed.

The thing is that I use the PythonEnvironmentConfig.pythonTmpCachePath attribute to deliver information from the PythonStreamBinder to a class that is called from the python script.
How would you suggest to do it otherwise?

The only usage i found is in UtilityFunctions#smartFunctionDeserialization, which is only called from various java UDF classes. Unless there is another usage hidden somewhere i would suggest to add a PythonEnvironmentConfig argument to the smartFunctionDeserialization method, and all UDF classes.

One of the critical attributes is PythonEnvironmentConfig::pythonTmpCachePath, which is used in the following places:

PythonStreamExecutionEnvironment::execute:362
PythonStreamExecutionEnvironment::execute:400
PythonStreamBinder::prepareFiles:117

On the client side, the temporary files are prepared for distribution by the PythonStreamBinder and then processed by the ``````PythonStreamExecutionEnvironment::executefunction, which is called from the Python script. When the python script is executed on the TaskManager, this attribute remainsnulland thus, theexecute``` returns immediately.

Referring to the issue with the PythonEnvironmentConfig  above, Is there any other global indication that I can use to test whether a given function is executed on the TaskManager?

There is none that I'm aware of. It is also possible for the JM and TM to run in the same JVM, say for tests or in local mode.
I can't think of a nice way to solve this, so I suggest we simply disable the check for the PythonEnvironmentConfig class.


feat: remove fee to dao

resolves #56
:notebook: Overview
Removes fees paid to dao, distributing fees to fee receipient only if owner sets a positive fee. Also initializes minimum period to 1 to prevent flashbot transactions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 52 (36.54%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.6%) to 12.566%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/protocol/RigoblockV3Pool.sol
19
52
36.54%

Files with Coverage Reduction
New Missed Lines
%

contracts/protocol/RigoblockV3Pool.sol
3
47.89%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
211

Relevant Lines:
1517

💛  - Coveralls


Ensure storage location exists and allow relative paths

This commit is a follow-up to #1061 which only contains the two features below:
Ensure directories exist on startup, and create them if not.
Allow specifying relative paths in VSCode settings that are resolved based on the workspace folder.
I was not able to add any automated tests for this, but overall it seems to be working well in my manual testing.
The PR has an origin PR https://github.com/Azure/Azurite/pull/1147, which was merged by mistake, and reverted. So raise again.

@dpolivy
I have re-raised the commit in PR https://github.com/Azure/Azurite/pull/1147 in this PR.
If you would like a better track for the PR progress, you can close this and open a new one.

@dpolivy I have re-raised the commit in PR #1147 in this PR. If you would like a better track for the PR progress, you can close this and open a new one.

@blueww I'm not sure I have the ability to close this, but I'm happy to open a new one if you like for better tracking. In the meantime, I will reply to your comments above and can address in a new PR if needed.

/azp run

@XiaoningLiu @blueww Any further comments/changes needed here for this PR?

@dpolivy Can you please add a changelog entry and resolve the conflicts? PR is generally good to us.

@XiaoningLiu I rebased the branch off main and added a ChangeLog entry. Let me know if there's anything else!


Thread to claim topics for added quiz material (Deep Learning with Flux.jl Course)

Post the topic you will be making a quiz on here. Note that if another student claims the task, you should choose a different topic. Please do not claim a topic here unless you have claimed the task on the Code-in site
Topics must be picked from the below list:

Introduction to Neural Networks
Deep Learning with Flux
Recongnizing handwriting with a neural network
Final summary test consisting of questions for the entire course

Note that these quizzes can only cover material that was found in the actual videos that are in the Deep Learning with Flux.jl course on JuliaAcademy.org.
Note the quiz can be less than 7-10 questions if the section doesn’t have enough content for that many questions but for this section the videos are longer and should have plenty of content for a quiz.

I'll work on recognising handwriting with a neural network!

I can work on Deep Learning with Flux

I am claiming Introduction to Neural Networks.

I'll work with final summary


[Chat] [IOU] Create IOUConfirm step

If you haven’t already, check out our contributing guidelines for onboarding!

Upwork Posting: https://www.upwork.com/jobs/~01744b3390e36e5f36
This issue builds on top of the existing IOU Modal, which was implemented in this PR. The IOU Confirm step page has already been created and is a controlled component (IOUModal manages its state).
The Confirm step allows users to confirm the 'request money' (1:1) or 'bill split'(multiple participants) amount and the participants they are requesting payment from. To open the Modal, you can navigate to localhost:8080/iou/request AND localhost:8080/iou/split.
You can also launch the IOUModal by temporarily modifying the routes in CreateMenu. Launch the request money flow with Navigation.navigate(ROUTES.IOU_REQUEST) and the bill split flow with Navigation.navigate(ROUTES.IOU_BILL)
Mobile & mobile web

Web & Desktop

Deliverables:

The title should match the title from the Participants step (step 2). This will be 'Split' or 'Request', followed by the amount. (for example: 'Split $42.00' || Request $42.00)
If the IOU flow is for a bill split, then we should display the current user under the 'WHO PAID?' title (this is not shown for the request money flow)
We then need to display all participants other than the current user. With the amount that they will need to pay (total amount, split equally between amount of participants)

If 'Bill split' flow, then we should reuse the list from the IOUParticipantsSplit page
If 'Request money' flow, then we simply display a single user under the 'To' heading

An input field should allow the user to input an optional comment for the IOU request
The button label should read 'Request $[currency][amount]' or 'Split bill' if there are multiple participants
A new API function should be created within API.js: createIOUTransaction, which will be called from IOUModal to create the IOU (details for this request can be found below).
When the user hits this button, we should pass the comment input string up to IOUModal via the existing onStepComplete callback (or something similar), and we should then call the new createIOUTransaction API function from within a new IOUAction function.

We should show a loading indicator in the button (using ButtonWithLoader), by setting the Onyx IOU key to IOU: {loading:true}. We should display a loading indicator in the Button while this is true.
Within this new IOUAction function we should await a successful response to createIOUTransaction, and then pass the returned reportID value to GetIOUReport, to retrieve the full IOUReport details
Then, we should persist the simplified version of these details to Onyx, just like we are doing here

Finally, back in IOUModal we should subscribe to the reportIOU_ Onyx key. Once we notice that the new IOU data has been persisted to Onyx (when we persist the data in step 7, we should receive this in our Onyx subscription). Once this value is not null, we know that the report has successfully been created and persisted to Onyx, so we can close the IOU Modal.

CreateIOUTransaction API
Example of the API which is used to create the IOU request / split.
curl --request POST \
  --url 'https://expensify-jules.ngrok.io/api?command=CreateIOUTransaction' \
  --header 'Content-Type: multipart/form-data; boundary=---011000010111000001101001' \
  --cookie 'email=jules%252B3%2540expensify.com; accountID=12; authToken=66ADF90...22AE918' \
  --form<EMAIL_ADDRESS>\
  --form currency=USD \
  --form 'comment=Pizza 🍕' \
  --form amount=550

Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/157782

Hey @Jag96, I notice you have self-assigned this issue. Is it still pending a proposal? In that case, I would like to contribute to this issue. The issue's a continuity to an earlier issue I contributed in: #1694
My proposal:

Modify getTitleForStep in IOUModal to match the title from IOUParticipants step for the IOUConfirmation page

We have two ways to render a page:
  I. If it's Bill Split:

  - In the IOUConfirmation step, add a Text component with the "WHO PAID" label at the beginning of the page. Under the text, we display the current user with a tick mark next to them using `OptionRow`
  - Then, in the second section of the page, we display "WHO WAS THERE" text similarly
  - We reuse the `OptionsSelector` list that is used on the `IOUParticipantsSplit` page

  II. If it's Request:

  - Add a text component with "TO" label at the beginning of the page.
  - Use `OptionRow` to display the participant without a tick mark.

An input field should be added within both flows to ask the user for an optional comment for the request. I will reuse the TextInputWithFocusStyles for this purpose.

Finally, the button label should have conditional logic to display either 'Request $[currency][amount]' | 'Split bill' based on the flow

I will create a new API.js function called: createIOUTransaction to create the IOU

I will use the existing onStepComplete callback to call createIOUTransaction API function within a new async createNewTransaction function in IOUAction

Within the function, we will set loading true for the Onyx IOU key by setting it as Onyx.merge(ONYXKEYS.IOU, {loading: true}) before calling createIOUTransaction. I will pass this loading to the button loader's isLoading prop.

We then await a successful response to createIOUTransaction and pass the returned reportID to get IOUReport using GetIOUReport

We then set loading false for the Onyx IOUKey as well by setting it as: Onyx.merge(ONYXKEYS.IOU, {loading: false});

Moreover, we persist the simplified version of the report we get from getSimplifiedIOUReport(iouReport) in Onyx.

Also, I will subscribe IOUModal to the reportIOU_ Onyx key, so that when we persist a report in the above step, the IOUModal receives the event. When it does, we will know that the report has been successfully created, so we can close the IOUModal

Hi, I would like to work on this issue. Here is my proposal:

The title should match the title from the Participants step (step 2). This will be 'Split' or 'Request', followed by the amount. (for example: 'Split $42.00' || Request $42.00)

I will modify first if condition here to have same title with Participants step:
https://github.com/Expensify/Expensify.cash/blob/fa6185b2c51fdc0f28ab9cbc48b8a306f64a537d/src/pages/iou/IOUModal.js#L65-L73

If the IOU flow is for a bill split, then we should display the current user under the 'WHO PAID?' title (this is not shown for the request money flow)

I will pass hasMultipleParticipants prop to IOUConfirmPage component to distinguish bill split and request money. If it is a bill split, I will show  'WHO PAID?' title.

We then need to display all participants other than the current user. With the amount that they will need to pay (total amount, split equally between amount of participants)

If 'Bill split' flow, then we should reuse the list from the IOUParticipantsSplit page

I will pass participants array from IOUModal's state to IOUConfirmPage component as a prop. With iouAmount and participants list, I will calculate the amount they will need to pay within IOUConfirmPage component.
https://github.com/Expensify/Expensify.cash/blob/fa6185b2c51fdc0f28ab9cbc48b8a306f64a537d/src/pages/iou/IOUModal.js#L48

If 'Request money' flow, then we simply display a single user under the 'To' heading

Again, using hasMultipleParticipants prop, I will show 'To' heading with single participant.

An input field should allow the user to input an optional comment for the IOU request

I will add TextInputFocusable element for optional comment.

The button label should read 'Request $[currency][amount]' or 'Split bill' if there are multiple participants

Again, using hasMultipleParticipants prop, I will have custom button label.

A new API function should be created within API.js: createIOUTransaction, which will be called from IOUModal to create the IOU (details for this request can be found below).

I will create an API function that makes a POST request with CreateIOUTransaction command with required fields similar to this one:
https://github.com/Expensify/Expensify.cash/blob/4bc32214cd2158a02053da8bf6c3619ad3505d63/src/libs/API.js#L486-L491

When the user hits this button, we should pass the comment input string up to IOUModal via the existing onStepComplete callback (or something similar), and we should then call the new createIOUTransaction API function from within a new [IOUAction]
(https://github.com/Expensify/Expensify.cash/blob/fa6185b2c51fdc0f28ab9cbc48b8a306f64a537d/src/libs/actions/IOU.js) function.

I will add a function in IOUModal that calls createIOUTransaction API function and I will pass this function to IOUConfirmPage as onStepComplete prop.

We should show a loading indicator in the button (using ButtonWithLoader), by setting the Onyx IOU key to IOU: {loading:true}. We should display a loading indicator in the Button while this is true.

In this new function, I will update Onyx IOU key to IOU: {loading:true} .

Within this new IOUAction function we should await a successful response to createIOUTransaction, and then pass the returned reportID value to GetIOUReport, to retrieve the full IOUReport details

I'm going to use promise and then to await API call to pass returned reportID value to GetIOUReport.

Then, we should persist the simplified version of these details to Onyx, just like we are doing here

Then I will update Onyx with new data.

Finally, back in IOUModal we should subscribe to the reportIOU_ Onyx key. Once we notice that the new IOU data has been persisted to Onyx (when we persist the data in step 7, we should receive this in our Onyx subscription). Once this value is not null, we know that the report has successfully been created and persisted to Onyx, so we can close the IOU Modal.

I will add withOnyx to IOUModal in order to subscribe to the reportIOU_ Onyx key.
https://github.com/Expensify/Expensify.cash/blob/10a21d6778da60aa913f820e2c93888efb585a9e/src/pages/iou/steps/IOUConfirmPage.js#L45-L47

Thanks for both of your submissions. We'll go with @barun1997 as his submission was first.

@Julesssss  Thanks for the assignment! I will start working on it right away.
@Jag96 I've applied for the job posting in Upwork. Please kindly take a look.

Hi @Julesssss, I am working to complete this issue, but I just wanted to gain some clarity on createIOUTransaction. After a successful transaction creation, it returns a reportID. In the issue note:

2\. Within this new IOUAction function we should await a successful response to `createIOUTransaction`, and then pass the returned `reportID` value to `GetIOUReport`, to retrieve the full IOUReport details

it is mentioned that this reportID should be passed to GetIOUReport but GetIOUReport expects debtorEmail - so, my thought process is to instead implement it the way it's implemented in actions/Report.js since we already have a reportID:
https://github.com/Expensify/Expensify.cash/blob/2b0674b94819926f38e71b4c5c8edf25bebe1ecb/src/libs/actions/Report.js#L228-L241
Please let me know if I'm missing something!

it is mentioned that this reportID should be passed to GetIOUReport but GetIOUReport expects debtorEmail.

Ah yes, this changed recently. I should have let you know. You've got it though, that would be the ideal solution 👍
Let us know if you have any other questions!

Ahh, gotcha! Thank you.

@Julesssss, just a final question regarding API call for createIOUTransaction for Split Bills.
The example is:

curl --request POST \
  --url 'https://expensify-jules.ngrok.io/api?command=CreateIOUTransaction' \
  --header 'Content-Type: multipart/form-data; boundary=---011000010111000001101001' \
  --cookie 'email=jules%252B3%2540expensify.com; accountID=12; authToken=66ADF90...22AE918' \
  --form<EMAIL_ADDRESS>\
  --form currency=USD \
  --form 'comment=Pizza 🍕' \
  --form amount=550

It works perfectly when I send a single debtorEmail, but for Split, we'd have multiple emails. Can you give me an example for CreateIOUTransaction in the case of a Split Bill? Thank you for your help!

Ah yes, this is a totally different API. I probably should have shared all of them, rather than those I thought would be necessary 🙃
/CreateIOUSplit
curl --request POST \
  --url 'https://expensify.com/api?command=CreateIOUSplit' \
  --header 'Content-Type: application/x-www-form-urlencoded' \
  --cookie 'email=jules%252B4%2540expensify.com; accountID=308; authToken=A823E45...9261A0266' \
  --data reportID=786 \
  --data amount=100 \
  --data currency=USD \
  --data 'splits=[{"amount":50,"email":"jules+4<EMAIL_ADDRESS>

Haha! Makes sense now. Thank you! @Julesssss

Can you please link to your draft PR once you have one @barun1997?

Reopening this, it seems that there is still a regression related to the original fix. cc @barun1997

I will take a look, thank you!

Hi, I looked at this issue today, but still can't seem to wrap my head around it to find a proper solution. The problem is that I fixed the original solution by restricting it to flexGrow0 so it doesn't take the remaining space. But if I do let it grow using flexGrow1, it takes all the available space.

I will make another try tomorrow, but I'm open for your suggestions!

I don't have any specific suggestions, but it might be worth sharing the problem in the expensify-open-source channel to get more eyes on the problem.

@Julesssss  Thank you! I have shared it in the Slack Group.

@barun1997 have you done any further investigation on how to fix this?

Hi, just to be clear on the specification required:
Is this something we're looking for? https://www.loom.com/share/68ef6b07a742462b955680c094189834
I've not been able to somehow constrict the space, but the solution above would work, with a caveat of having an input field just above the button like this:

Is this something we could accept?

Having the input at the bottom with only a few participants is not ideal.
I'm tagging @shawnborton, who may have some ideas on how to solve the scrolling problem.

@Julesssss  That's no longer a problem now, fortunately! Just wondering if the scroll action (with comment fixed as in the video) is the desired UX?

@barun1997 that looks good! Will check out the PR


Visual Studio Debug Problem (Unity 2017.3)

Hello, I downloaded the 2017.3 branch, then opened the video capture example, changed unity project settings as described in the readme and build the solution (through unity) .
The problem is that when i try to run the project (debug ,x86 ) on the hololens emulator using Visual Studio 2017, I got the following error :
https://pastebin.com/BC4fD1NV
(pasted there because it's too long)
I'm asking here because i see only a list of file paths and i can't understand why, thank you.

That was the error list, I always end up having "can't find .../projectpath/Unity.Hololens.dll" .
Others hololens projects deploy without problems .


ImportError: No module named vision

This might be a noob question but after I setup apache2 and sql following README, I tried turkic command in vatic directory.
But no matter I try turkic setup --dabatase or turkic publish --offline or any turkic command
All I got is this same error:
Traceback (most recent call last):
File "/usr/local/bin/turkic", line 5, in
pkg_resources.run_script('turkic==0.2.5', 'turkic')
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 528, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 1394, in run_script
execfile(script_filename, namespace, namespace)
File "/usr/local/lib/python2.7/dist-packages/turkic-0.2.5-py2.7.egg/EGG-INFO/scripts/turkic", line 12, in
import cli
File "/home/yufeiw/VATIC/vatic/cli.py", line 11, in
from vision import Box
ImportError: No module named vision
I am a newbie for python, but I think the code is looking file vision.
Therefore I tried to copy vision from pyvision to vatic. It worked HOWEVER I run into another importError:
File "/home/yufeiw/VATIC/vatic/vision/init.py", line 1, in
from annotations import *
ImportError: No module named annotations
(I do find file annotations.pyx in the folder though)
It seems like moving files around is not the correct approach.
What did I do wrong? and What should I do? Thanks

I am facing the exact same issue. Anyone has an idea?

I am also facing the same issue. and I tried to install pyvision using :
$python setup.py build
$sudo python setup.py install
nothing happend, and I tried to run python in the pyvision folder, when import vision, it has the same problem of no module named annotations.

I tried this
https://github.com/cvondrick/vatic/issues/16
after using cython 0.20 it seems working and installed pyvision successfuly.

As said by @yhzyhzyhz, it works when installing cython 0.20 then rebuilding and installing pyvision
sudo pip install cython==0.20
cd pyvision
sudo python setup.py build
sudo python setup.py install

@iraadit I installed vision successful!

Installed /usr/local/lib/python2.7/dist-packages/pyvision-0.3.1-py2.7-linux-x86_64.egg
Processing dependencies for pyvision==0.3.1
Finished processing dependencies for pyvision==0.3.1
But it's still worry!

import vision
Traceback (most recent call last):
File "", line 1, in
File "vision/init.py", line 1, in
from annotations import *
ImportError: No module named annotations

I am having the same issue trying to install Vatic. No module named vision

@hukangrong were you able to solve the issue you had with ImportError: No module named annotations? I have the same issue and I see the problem is due to missing annotations.py file.

@BhargavaRamM do you know what you need to use in your project? In my project, I skip this problem by compiling "features.pyx" and importing features model in my project. So I don't fix this problem.

@hukangrong I did the same thing you did. I compiled annotations.pyx file to create annotations.so. This resolved the ImportError. Thanks.

@hukangrong I am having the same issue trying to install Vatic. How do you compiled annotation.pyx? Can you share your commands? Thanks

Same thing here, ImportError: No module named vision.

@evgenykam Sorry for too late to response. I give you the example of compiling features model.
cython -a features.pyx gcc -shared -pthread -fPIC -fwrapv -O2 -Wall -fno-strict-aliasing \       -I/usr/include/python2.7 -o features.so features.c


Source Control > Discard All Files not working properly

VSCode Version: <IP_ADDRESS>-insider
OS Version: Win 10

Steps to Reproduce:

Create one unversioned file and edit 2 other files (for example)
Go to "Source Control"
Go to "..." => "Discard all changes"
On the popup choose the "discard all 3 files" button

Only the unversioned file is removed. I have to do it again to discard the 2 other versioned changes.

Is there anything special about your setup? Files have weird names? Is it a network share? Can you reproduce on other workspaces?

Here are some information about the workspace:

The repository uses Git with VS Team Services.
I have the .gitignore from https://github.com/github/gitignore/blob/master/VisualStudio.gitignore
The app I'm working on is a React app created with create-react-app
I have the VS Team extension for VSCode installed and configured for the repo (https://marketplace.visualstudio.com/items?itemName=ms-vsts.team)

I don't have any others workspaces that uses vscode (the others use Visual Studio). I can create a new dummy project on VSTS and try there if you want.

@pellea Yes please do.

Here are the complete steps to the bug:

New Project in VSTS (Scrum template)
Initialize wtih a README or gitignore (only gitignore)
PS> git clone https://xxxx.visualstudio.com/_git/VSCodeDebug vscodedebug
PS> cd vscodedebug
PS> create-react-app . --scripts-version=react-scripts-ts
PS> explorer .      && right click open vscode here
Source control > "initial commit" > ctrl+enter
Source control > ... > push to ... > select remote repo > enter
See the beautiful Gif video for the remaining part :)

After the first discard, can you click the App.tsx change to see what changes appear?

There is no changes. The file has been reverted.

But the SCM viewlet still shows that the file has a change. If you click it, Code doesn't show any change? What does git diff -- App.tsx return?

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   src/App.tsx

no changes added to commit (use "git add" and/or "git commit -a")
PS D:\dev\vscodedebug>

and after discarding the second time:
PS D:\dev\vscodedebug> git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
PS D:\dev\vscodedebug>

Hm... git status says the file is dirty, but git diff returns no changes. Sounds like some line ending issues. What are your core.autocrlf and core.safecrlf settings?

git config core.autocrlf => true
git config core.safecrlf => nothing

Can you change core.autocrlf to false and try again?

That doesn't seem like a good idea without breaking every projects I own on the machine...

After you've set the core.autocrlf option and committed a .gitattributes file, you may find that Git wants to commit files that you have not modified. At this point, Git is eager to change the line endings of every file for you.
The best way to automatically configure your repository's line endings is to first backup your files with Git, delete every file in your repository (except the .git directory), and then restore the files all at once.

I'm just interested in knowing whether that is what actually causes the issue. You can switch it back once you confirm it.

I executed the command "git config --global core.autocrlf false" and it does the same thing. I have to discard twice. (git status show the file as modified)

Does it happen too if you run with code --disable-extensions?

@joaomoreno same behavior

Can you show me what comes up in Git: Show Git Output when you run the discard action?

Here is the log:
> git clean -f -q -- d:\dev\vscodedebug\src\Test.tsx
> git checkout -q -- d:\dev\vscodedebug\src\App.tsx
> git status -z -u
> git symbolic-ref --short HEAD
> git rev-parse master
> git show :src/App.tsx
> git rev-parse --symbolic-full-name --abbrev-ref master@{u}
> git rev-list --left-right master...origin/master
> git for-each-ref --format %(refname) %(objectname) --sort -committerdate
> git remote --verbose

OK, can you try running those same commands in the command line?
git clean -f -q -- d:\dev\vscodedebug\src\Test.tsx
git checkout -q -- d:\dev\vscodedebug\src\App.tsx

What is the outcome?

So what happens if you run the command as it is, with the absolute path?

Sorry ... the second command is nor working. If I want to remove the App.tsx file I need to run it twice.
It seems the issue I have is actually not related to VSCode.

Got it! Let us know if you ever find a fix, I'd be interested in knowing what it is.

I updated the git tools to version 2.16.2.
The issue is fixed (I had the 2.16.0 version).


fixed messed up code and footer

fixed #318

@Priyanshi662 fixed the footer and all the messed up code, had a hard time in figuring out what is breaking the footer code so it would be great if you could increase the difficulty label. Thanks.


[FLINK-19165] Refactor the UnilateralSortMerger

What is the purpose of the change
This is a preparation for introducing a sorted inputs in BATCH execution
mode. It refactors the UnilateralSortMerger into more composable pieces.
Additionally it adds the option to use a push-based approach instead of
spawning a Reader thread that consumes from an input iterator.
The PR still has a couple of shortcomings:

the combine function is not being opened (however it did not work well even before that, the function was being closed before the merge stage)
it misses tests for the push-based approach (however the reading thread simply encapsulates the push-based producer)
it misses a test for testing closing all threads on an exception (the exception handler was reworked)

Verifying this change
This change is already covered by existing tests.
Some tests are still to be added.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Is this class only used in the DataSet API, or is it also used in the SQL runtime (batch case)?
If the latter is true, we should verify that there is no performance impact through this refactoring by running a benchmark before/after.

It is used exclusively in the DataSet API so far. SQL runtime (blink) has its own version that originates from this classes but diverged substantially. We can think of unifying it in the future but so far I did not want to change the sql runtime.

Looks good to me, +1 to merge
Given that the previous sorter implementation had pretty extensive tests (also heavy tests to be manually executed, IIRC) it should be fine as long as we retain these tests.

Thanks for the review @gaoyunhaii, I addressed your comments. Could you have another look?

Could you have another look @kl0u @gaoyunhaii ?

Very thanks @dawidwys for the PR! I re-checked the PR and now there should be no issues from my side.

Thank you @StephanEwen @gaoyunhaii @kl0u for reviewing. I will merge it now.


Make E2E Tests Easier To Debug

Right now the E2E tests are quite hard to troubleshoot if something goes wrong.  The main issue I face is that there is no way of replacing one of the components (e.g. the server) with one that you have attached a debugger to.  As a result I often find myself trying to debug via println which is somewhat slow going.  I think in an ideal world debugging these tests would work as follows:

Run some command (ideally a docker compose) to bring up the system into a state suitable for the e2e tests.  This command should allow you to specify which Armada components you don't want to bring up.
Launch the Armada component(s)  that you excluded in 1) from your IDE. This enables them to be debugged if necessary
Run the E2E Tests (ideally from your IDE).  Any Breakpoints specified in 2) will be hit.
Quickly reset the system to the initial state.

Things to think about:

Right now we create a special network for everything to run on (I believe we do this because otherwise KIND doesn't work on WSL), but this means that it's hard to have a non-docker component (i.e. something running in your ide under a debugger) talking to the other armada components/
There is some functionality in the armada makefile to do some of this already (e.g. run without setup), maybe some of this could be reused.
Our makefile is already pretty complex, any solution that can reduce complexity (e.g. by using docker compose) would be good
The above mechanism should also allow for developing against the whole armada system locally if required.
Whatever solution we come up with should also be used for the actual E2E tests.

We have at least these methods for bringing up an environment:
https://github.com/G-Research/armada/tree/master/docs/dev
https://github.com/G-Research/armada/blob/master/makefile#L388
And some setup scripts here:
https://github.com/G-Research/armada/tree/master/scripts
I think the above should be merged into a single procedure.
The default config for e2e tests are here:
https://github.com/G-Research/armada/tree/master/e2e
The default config for built components are here:
https://github.com/G-Research/armada/tree/master/config
I think we should merge these to have a single default config that we also use for e2e tests. At least as far as possible.
We have both the legacy e2e tests and the new test suite now. I'd like to replace the legacy e2e tests with the test suite.

Hey team! Please add your planning poker estimate with Zenhub @suprjinx @dejanzele @richscott @kannon92 @jayofdoom


Different behaviors when converting PaddleOCR into Onnx with different opset version.

I tried to convert PaddleOCR text detector model (PP-OCR 2.0 version) into ONNX model. The conversion was successful but the output from ONNX model did not match with the output from the original model (using paddlepaddle).
I also figured out by using different opset from 10-13, I got different results. It seems that using opset 10, I got pretty similar results (not sure if it's 100% similar) compared to the original model but using opset 11 12 and 13, I got completely different results.
Can anyone help check and fix this strange behavior?
Thanks in advance.

I tried to convert PaddleOCR text detector model (PP-OCR 2.0 version) into ONNX model. The conversion was successful but the output from ONNX model did not match with the output from the original model (using paddlepaddle).
I also figured out by using different opset from 10-13, I got different results. It seems that using opset 10, I got pretty similar results (not sure if it's 100% similar) compared to the original model but using opset 11 12 and 13, I got completely different results.
Can anyone help check and fix this strange behavior?
Thanks in advance.

Hello, there's something I need to confirm

which inference engine you are using,  and which version

I'm using paddle 2.0 for this model (https://paddleocr.bj.bcebos.com/dygraph_v2.0/ch/ch_ppocr_mobile_v2.0_det_infer.tar) and onnxruntime to run onnx model.
The script to run paddleocr is here (https://github.com/PaddlePaddle/PaddleOCR/blob/release/2.1/tools/infer/predict_system.py)


USB ports reset during sleep/wakeup; USB drives ejected

When a device is plugged in and the computer goes to sleep and wakes up, the device gets reset and the port is re-enumerated. If the device is a USB mass storage drive, then the user sees a "unsafe removal" message.
The behaviour is different for the PCH XHCI ports versus the PEG XHCI ports. For PEG, this happens only during the first sleep. Then, everything is normal. However, for PCH ports (and TB3 USB ports) the reset always happens.
The culprit appears to be a hardware or BIOS issue. The PCI PM_Enable bit should be retained across D3 sleeps, however by the time XNU is woken up, the PM_Enable state is lost. This could be a hardware bug or it could be the resume path in the UEFI firmware messing with the USB device. Evidence for the latter is that a USB keyboard that is plugged in has the LED briefly show up during wake, then goes off, and later comes back on again.
In addition to the PM_Enable state lost, it appears that all other state is lost as well, which is why the ports are reset on resume. A proper fix would require a patched BIOS. A workaround would be to silently re-enumerate the device without user notification (Linux does this). The way the IOUSBMassStorage driver works makes this solution difficult to implement because the USB device is a child of the port that is reset.
Marking as won't fix since BIOS patching is beyond the scope of this project.
Workaround: for devices that require preserving state across sleep/resumes, use only the PEG slots (the blue port on the front or the USB-C port on the front). After reset from the first sleep, the device should sleep/wake without issue.

@osy86 please write to me on email I could have solution for that.

Hi, mind saying why it cannot be discussed here? There’s other people interested who might also want to hear what you have to say. Thanks.

@osy86 email please me, and I will explain and we can share here what we get

Another symptom: with the Apple wifi card installed, WoL on wifi works the first time you sleep. However, it stops working after a darkwake and must be fully woken up and slept again before it works. I think this is because the Wifi card is disconnected on darkwake and isn't properly re-initialized.

Here is a resume log from ubuntu. Notice how the USB wakeup errors and the thunderbolt disconnect errors are seen in ubuntu as well. However, in ubuntu, workarounds exist to make the error handling transparent to the user.
[   37.985055] PM: suspend entry (deep)
[   37.985057] PM: Syncing filesystems ... done.
[   37.986712] Freezing user space processes ... (elapsed 0.001 seconds) done.
[   37.987931] OOM killer disabled.
[   37.987931] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[   37.989094] printk: Suspending console(s) (use no_console_suspend to debug)
[   38.111940] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[   38.114771] sd 0:0:0:0: [sda] Stopping disk
[   38.123334] e1000e: EEE TX LPI TIMER: 00000011
[   40.640915] ACPI: EC: interrupt blocked
[   40.688455] ACPI: Preparing to enter system sleep state S3
[   40.689393] ACPI: EC: event blocked
[   40.689393] ACPI: EC: EC stopped
[   40.689394] PM: Saving platform NVS memory
[   40.689400] Disabling non-boot CPUs ...
[   40.691507] smpboot: CPU 1 is now offline
[   40.692246] IRQ 139: no longer affine to CPU2
[   40.693281] smpboot: CPU 2 is now offline
[   40.694946] smpboot: CPU 3 is now offline
[   40.697638] smpboot: CPU 4 is now offline
[   40.698288] IRQ 122: no longer affine to CPU5
[   40.698291] IRQ 124: no longer affine to CPU5
[   40.698294] IRQ 125: no longer affine to CPU5
[   40.699321] smpboot: CPU 5 is now offline
[   40.699869] NOHZ: local_softirq_pending 202
[   40.699876] NOHZ: local_softirq_pending 202
[   40.699910] IRQ 126: no longer affine to CPU6
[   40.699913] IRQ 127: no longer affine to CPU6
[   40.699920] IRQ 144: no longer affine to CPU6
[   40.700931] smpboot: CPU 6 is now offline
[   40.701536] IRQ 123: no longer affine to CPU7
[   40.701544] IRQ 130: no longer affine to CPU7
[   40.701547] IRQ 132: no longer affine to CPU7
[   40.702581] smpboot: CPU 7 is now offline
[   40.705525] ACPI: Low-level resume complete
[   40.705630] ACPI: EC: EC started
[   40.705630] PM: Restoring platform NVS memory
[   40.707634] Enabling non-boot CPUs ...
[   40.707666] x86: Booting SMP configuration:
[   40.707666] smpboot: Booting Node 0 Processor 1 APIC 0x2
[   40.709244] unchecked MSR access error: WRMSR to 0x10f (tried to write 0x0000000000000000) at rIP: 0xffffffff86473f98 (native_write_msr+0x8/0x30)
[   40.709246] Call Trace:
[   40.709250]  intel_pmu_cpu_starting+0x87/0x260
[   40.709252]  ? mce_intel_feature_init+0x42/0x160
[   40.709253]  ? x86_pmu_dead_cpu+0x30/0x30
[   40.709255]  x86_pmu_starting_cpu+0x1a/0x30
[   40.709257]  cpuhp_invoke_callback+0x8a/0x580
[   40.709258]  ? cpumask_next+0x1b/0x20
[   40.709260]  ? topology_phys_to_logical_pkg+0x29/0x70
[   40.709261]  notify_cpu_starting+0x5d/0x80
[   40.709262]  start_secondary+0xed/0x200
[   40.709264]  secondary_startup_64+0xa4/0xb0
[   40.709382]  cache: parent cpu1 should not be sleeping
[   40.709411] intel_pstate: Disabling energy efficiency optimization
[   40.709466] microcode: sig=0x906e9, pf=0x8, revision=0x8e
[   40.710521] microcode: updated to revision 0xb4, date = 2019-04-01
[   40.710583] CPU1 is up
[   40.710602] smpboot: Booting Node 0 Processor 2 APIC 0x4
[   40.711014]  cache: parent cpu2 should not be sleeping
[   40.712218] CPU2 is up
[   40.712236] smpboot: Booting Node 0 Processor 3 APIC 0x6
[   40.712647]  cache: parent cpu3 should not be sleeping
[   40.713845] CPU3 is up
[   40.713861] smpboot: Booting Node 0 Processor 4 APIC 0x1
[   40.714355]  cache: parent cpu4 should not be sleeping
[   40.714416] microcode: sig=0x906e9, pf=0x8, revision=0xb4
[   40.714609] CPU4 is up
[   40.714627] smpboot: Booting Node 0 Processor 5 APIC 0x3
[   40.715037]  cache: parent cpu5 should not be sleeping
[   40.715170] CPU5 is up
[   40.715270] smpboot: Booting Node 0 Processor 6 APIC 0x5
[   40.715679]  cache: parent cpu6 should not be sleeping
[   40.715830] CPU6 is up
[   40.715849] smpboot: Booting Node 0 Processor 7 APIC 0x7
[   40.716263]  cache: parent cpu7 should not be sleeping
[   40.716411] CPU7 is up
[   40.722192] ACPI: Waking up from system sleep state S3
[   40.726445] ACPI: EC: interrupt unblocked
[   40.727567] pcieport 0000:07:00.0: Refused to change power state, currently in D3
[   40.731914] pcieport 0000:08:01.0: Refused to change power state, currently in D3
[   40.731915] pcieport 0000:08:02.0: Refused to change power state, currently in D3
[   40.731916] pcieport 0000:08:04.0: Refused to change power state, currently in D3
[   40.755238] pcieport 0000:08:00.0: Refused to change power state, currently in D3
[   40.763274] xhci_hcd 0000:3d:00.0: Refused to change power state, currently in D3
[   40.775209] thunderbolt 0000:09:00.0: Refused to change power state, currently in D3
[   40.899741] ACPI: EC: event unblocked
[   40.900074] usb usb1: root hub lost power or was reset
[   40.900076] usb usb2: root hub lost power or was reset
[   40.900381] usb usb3: root hub lost power or was reset
[   40.900382] usb usb4: root hub lost power or was reset
[   40.903233] sd 0:0:0:0: [sda] Starting disk
[   40.923237] xhci_hcd 0000:3d:00.0: Refused to change power state, currently in D3
[   40.923262] xhci_hcd 0000:3d:00.0: WARN: xHC restore state timeout
[   40.923263] xhci_hcd 0000:3d:00.0: PCI post-resume error -110!
[   40.923263] xhci_hcd 0000:3d:00.0: HC died; cleaning up
[   40.923268] dpm_run_callback(): pci_pm_resume+0x0/0xb0 returns -110
[   40.923272] PM: Device 0000:3d:00.0 failed to resume async: error -110
[   40.927413] [drm] PCIE GART of 256M enabled (table at 0x000000F400000000).
[   41.218186] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   41.218994] ata1.00: ACPI cmd ef/10:06:00:00:00:00 (SET FEATURES) succeeded
[   41.218995] ata1.00: ACPI cmd f5/00:00:00:00:00:00 (SECURITY FREEZE LOCK) filtered out
[   41.218996] ata1.00: ACPI cmd b1/c1:00:00:00:00:00 (DEVICE CONFIGURATION OVERLAY) filtered out
[   41.219417] ata1.00: supports DRM functions and may not be fully accessible
[   41.223827] ata1.00: ACPI cmd ef/10:06:00:00:00:00 (SET FEATURES) succeeded
[   41.223828] ata1.00: ACPI cmd f5/00:00:00:00:00:00 (SECURITY FREEZE LOCK) filtered out
[   41.223829] ata1.00: ACPI cmd b1/c1:00:00:00:00:00 (DEVICE CONFIGURATION OVERLAY) filtered out
[   41.224221] ata1.00: supports DRM functions and may not be fully accessible
[   41.227494] ata1.00: configured for UDMA/133
[   41.237623] ahci 0000:00:17.0: port does not support device sleep
[   41.237768] ata1.00: Enabling discard_zeroes_data
[   41.243399] usb 1-9: reset full-speed USB device number 3 using xhci_hcd
[   41.300140] usb 4-2: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd
[   41.519419] usb 1-3: reset high-speed USB device number 2 using xhci_hcd
[   41.619251] [drm] Fence fallback timer expired on ring sdma0
[   41.795532] usb 2-3: reset SuperSpeed Gen 1 USB device number 2 using xhci_hcd
[   41.899403] usb 1-9.3: reset full-speed USB device number 8 using xhci_hcd
[   42.083405] usb 1-3.2: reset full-speed USB device number 4 using xhci_hcd
[   42.131256] [drm] Fence fallback timer expired on ring sdma0
[   42.263343] usb 1-3.3: reset full-speed USB device number 5 using xhci_hcd
[   42.643344] [drm] Fence fallback timer expired on ring sdma0
[   42.685492] [drm] UVD and UVD ENC initialized successfully.
[   42.795479] [drm] VCE initialized successfully.
[   42.807281] OOM killer enabled.
[   42.807281] Restarting tasks ...
[   42.807586] xhci_hcd 0000:3d:00.0: remove, state 4
[   42.807591] usb usb6: USB disconnect, device number 1
[   42.808156] done.
[   42.809214] xhci_hcd 0000:3d:00.0: USB bus 6 deregistered
[   42.809218] xhci_hcd 0000:3d:00.0: remove, state 4
[   42.809222] usb usb5: USB disconnect, device number 1
[   42.809357] xhci_hcd 0000:3d:00.0: Host halt failed, -19
[   42.809360] xhci_hcd 0000:3d:00.0: Host not accessible, reset failed.
[   42.809459] xhci_hcd 0000:3d:00.0: USB bus 5 deregistered
[   42.860918] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   42.860919] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   42.871563] video LNXVIDEO:00: Restoring backlight state
[   42.871666] PM: suspend exit
[   42.891216] usb 1-9.1: new full-speed USB device number 9 using xhci_hcd
[   42.992752] usb 1-9.1: New USB device found, idVendor=05ac, idProduct=820a, bcdDevice= 1.00
[   42.992753] usb 1-9.1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
[   42.995208] input: HID 05ac:820a as /devices/pci0000:00/0000:00:14.0/usb1/1-9/1-9.1/1-9.1:1.0/0003:05AC:820A.0008/input/input41
[   43.007433] e1000e: eno1 NIC Link is Down
[   43.059763] hid-generic 0003:05AC:820A.0008: input,hidraw3: USB HID v1.11 Keyboard [HID 05ac:820a] on usb-0000:00:14.0-9.1/input0
[   43.067327] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   43.067328] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   43.147194] usb 1-9.2: new full-speed USB device number 10 using xhci_hcd
[   43.248800] usb 1-9.2: New USB device found, idVendor=05ac, idProduct=820b, bcdDevice= 1.00
[   43.248801] usb 1-9.2: New USB device strings: Mfr=0, Product=0, SerialNumber=0
[   43.251465] input: HID 05ac:820b as /devices/pci0000:00/0000:00:14.0/usb1/1-9/1-9.2/1-9.2:1.0/0003:05AC:820B.0009/input/input42
[   43.268598] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   43.268599] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   43.303391] audit: type=1400 audit(1567962438.596:8): apparmor="STATUS" operation="profile_replace" profile="unconfined" name="/snap/core/7270/usr/lib/snapd/snap-confine" pid=3326 comm="apparmor_parser"
[   43.310366] pci_bus 0000:09: busn_res: [bus 09] is released
[   43.310397] pci_bus 0000:0a: busn_res: [bus 0a-3c] is released
[   43.311389] hid-generic 0003:05AC:820B.0009: input,hidraw6: USB HID v1.11 Mouse [HID 05ac:820b] on usb-0000:00:14.0-9.2/input0
[   43.319233] audit: type=1400 audit(1567962438.612:9): apparmor="STATUS" operation="profile_replace" profile="unconfined" name="/snap/core/7270/usr/lib/snapd/snap-confine//mount-namespace-capture-helper" pid=3326 comm="apparmor_parser"
[   43.327329] pci_bus 0000:3d: busn_res: [bus 3d] is released
[   43.327382] pci_bus 0000:3e: busn_res: [bus 3e-71] is released
[   43.327429] pci_bus 0000:08: busn_res: [bus 08-71] is released
[   43.472590] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   43.472591] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   43.679072] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   43.679073] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   43.883348] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   43.883351] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   44.084795] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   44.084796] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   44.293871] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   44.293872] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   44.496641] atkbd serio0: Unknown key released (translated set 2, code 0x7c on isa0060/serio0).
[   44.496643] atkbd serio0: Use 'setkeycodes 7c <keycode>' to make it known.
[   44.809138] usb 1-9.1: USB disconnect, device number 9
[   44.872005] Bluetooth: hci0: BCM: chip id 73 build 1126
[   44.872988] Bluetooth: hci0: BCM: product 05ac:828f
[   44.873995] Bluetooth: hci0: BCM: features 0x07
[   44.889953] Bluetooth: hci0: ubuntu
[   45.083454] usb 1-9.2: USB disconnect, device number 10
[   45.554940] e1000e: eno1 NIC Link is Up 100 Mbps Full Duplex, Flow Control: Rx/Tx
[   45.554942] e1000e 0000:00:1f.6 eno1: 10/100 speed: disabling TSO
[   45.555012] IPv6: ADDRCONF(NETDEV_CHANGE): eno1: link becomes ready

Seems like Macs have HOST_CTRL_PORT_LINK_REG.DIS_LINK_CM set in the PCH XHCI controller (offset 0x80EC) by default while on the NUC it is a hidden BIOS option that is default disabled. In compliance mode, ports have to be reset before they can be used. This is a potential root cause.

After reversing the majority of the sleep-resume UEFI path, it's evident that the PM_Enable bit loss/XHCI controller reset is a hardware issue/design issue and cannot be fixed in BIOS. The best we can do is patch OSX's XHCI driver to be aware of this quirk but this is a extremely difficult task because of how the drivers are designed (children of the device cannot be re-associated).


Add python37 to travis CI.

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   92.19%   92.19%
=======================================
  Files          20       20
  Lines        1423     1423
=======================================
  Hits         1312     1312
  Misses        111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc82d1...35c7eff. Read the comment docs.


Add diffusion map example

Notebook should run dynamics and analyze results for a system with interesting collective variables - check literature

Merged into a workflow epic for now


Move responsibilities from initAll to the components

What
Move as many responsibilities from initAll to the components so that initAll is doing as little as possible.
For example, the data-module selector is only defined in initAll.
Add any new methods to the JavaScript API reference
Why
To make it easier to include the JS for components without needing to import or use the initAll function.
Who needs to know about this
Developers
Done when

[x] initAll does as little as possible.
[ ] Any new methods are clearly documented in the JavaScript API reference

Reopening waiting for alphagov/govuk-frontend-docs#443 to be merged.


[FEATURE] Allow undefined environment values.

Is your feature request related to a problem? Please describe.
So I have a setup where parts of my config are optional. ie the env variables are not required.
For example, Consider the following yaml file.
app:
   type: ${TYPE}
   feature1:
        someFieldForFeature1:  ${SOME_FIELD_FOR_FEATURE1}
   feature2:
         someFeildForFeature2: ${SOME_FIELD_FOR_FEATURE2}

Here based on the value of app.type I'm validating either app.feature1 or app.feature2  after the yaml was parsed.
So when my env look likes following
TYPE=feature1
SOME_FIELD_FOR_FEATURE1=value

I'll get an error
Unknown environment variable referenced in config: SOME_FIELD_FOR_FEATURE2. Specify environment variable or use defaults syntax..
Describe the solution you'd like
Maybe add a config flag to allow this which would be by default false.
const yaml = readYamlEnvSync('config.yaml', process.env, {
    allowUndefinedEnv: true,
});

Describe alternatives you've considered
I wrote the functions from scratch using js-yaml not really useful.

Hi. @kareem-abdul thank you for the issue. Have you tried to provide a getProperty function? You can write your own logic for undefined case.

Hi @vara855 , I'm assuming you meant this,
const yaml = readYamlEnvSync('config.yaml', (key) => process.env[key]);

Unfortunately, this does not work either.

Hi, @kareem-abdul. I've made changes, you can check that playground
fixed in v2.0.5


Preventing Web splash screen

Is there a way to disable showing the initial splash screen in the web view?

Yeah, we need an option for that.
Right now it could be done through copying original index.html and customizing it to disable the splash animation.

A user reported an issue after using a modified index.html in https://github.com/flet-dev/flet/discussions/3643#discussioncomment-10048875. Some other assets file don't get rendered anymore.
Needs investigation.


Add history-mode fields to Edition schema

government: slug/id, of the Government that first published the
document
is_political: boolean, true if the content is considered political

These fields will be used to mark some search results as being under
history mode, where political content from previous governments will
be marked as such. This will need to know if a government is current
and the name (not slug) needs to be displayed in the UI,
Government will be expanded from the slug via the Government API [1],
which will be done by Rummager, or the Frontend.
Indexing is_political and government, rather than is_historic,
means that when a government ends it's results will be updated
without needing to reindex all political documents.
[1] https://www.gov.uk/api/governments

After a discussing with @edds and @rboulton i'm going to add another field, so closing this PR until thats done.


bob: Update to clarify ambiguity regarding shouted questions

TL;DR: the problem specification for the Bob exercise has been updated. Consider updating the test suite for Bob to match. If you decide not to update the exercise, consider overriding description.md.

Details
The problem description for the Bob exercise lists four conditions:

asking a question
shouting
remaining silent
anything else

There's an ambiguity, however, for shouted questions: should they receive the "asking" response or the "shouting" response?
In https://github.com/exercism/problem-specifications/pull/1025 this ambiguity was resolved by adding an additional rule for shouted questions.
If this track uses exercise generators to update test suites based on the canonical-data.json file from problem-specifications, then now would be a good time to regenerate 'bob'. If not, then it will require a manual update to the test case with input "WHAT THE HELL WERE YOU THINKING?".
See the most recent canonical-data.json file for the exact changes.
Remember to regenerate the exercise README after updating the test suite:
configlet generate . --only=bob --spec-path=<path to your local copy of the problem-specifications repository>

You can download the most recent configlet at https://github.com/exercism/configlet/releases/latest if you don't have it.
If, as track maintainers, you decide that you don't want to change the exercise, then please consider copying problem-specifications/exercises/bob/description.md into this track, putting it in exercises/bob/.meta/description.md and updating the description to match the current implementation. This will let us run the configlet README generation without having to worry about the bob README drifting from the implementation.

This issue is quite old and the above link is not pointing to the most recent bob file. You can find the latest canonical data and README here: https://github.com/exercism/problem-specifications/blob/master/exercises/bob/

This issue is outdated and Bob has been updated.


WIP: Click-to-place behaviour for mouseButton tools

Seems ready to merge, no bugs that I can find anymore
Changes:

Allow users to 'click-to-place' on mouseButton tools. E.g. Instead of click-dragging to create the length tool, the user simply clicks twice on the image.

Live demo(s):
https://rawgit.com/swederik/cornerstoneTools/toolBehaviour/examples/allImageTools/index.html
https://rawgit.com/swederik/cornerstoneTools/toolBehaviour/examples/annotation/index.html
https://rawgit.com/swederik/cornerstoneTools/toolBehaviour/examples/angleTool/index.html
https://rawgit.com/swederik/cornerstoneTools/toolBehaviour/examples/wwwcRegion/index.html

Merging since this seems stable. If anyone notices weirdness related to handle movement, let me know and I will investigate.


Spurious warning when assigning a method of a Sendable object to a @Sendable closure

Motivation
The Swift 5.10 compiler (Xcode version 15.3 beta 2, 15E5188j) emits a spurious warnings with the following code:
struct S: Sendable {
    func f() { }
}

let s = S()

// Converting non-sendable function value to '@Sendable () -> Void' may introduce data races
let closure: @Sendable () -> Void = s.f

The warning can be removed with a syntactic change:
let closure: @Sendable () -> Void = { s.f() }

It gets even more vexing with more complex signatures:
struct S: Sendable {
    func f(_ value: Int) throws { }
}

let closure: @Sendable (Int) throws -> Void = s.f // ideal, but compiler warning
let closure: @Sendable (Int) throws -> Void = { try s.f($0) } // no warning, but meh

Another example:
func f(_ closure: @Sendable (Int, Int) -> Bool) { ... }
f(==) // ideal, but compiler warning
f { $0 == $1 } // no warning, but meh

Proposed solution
Please have the compiler accept the first form:
struct S: Sendable {
    func f() { }
}

let s = S()

// No warning
let closure: @Sendable () -> Void = s.f

Alternatives considered
No response
Additional information
No response

This will be resolved with SE-0418: Inferring Sendable for methods and key path literals

Related, although might not be the case with the current toolchain in Xcode 15.3 beta: https://github.com/apple/swift/issues/67279#issuecomment-1937858584


Accessibility fixes

405004: Accessibility : MAS40B : INSPECT : Python+Python Environments : Name property for the items in the database does not contain the number of modules
404512: Accessibility : MAS36 : Keyboard : Python+Cookiecutter : 'Installed/Recommended/GitHub' expand collapse buttons are not accessible in CookieCutter window
Also prevents some images from getting focus.

:+1

:+1


Make the base, label, and readout font colors configurable.

This continues making our theming more flexible.

Fixes #1075.


Explain why "aws-smithy-types" 0.54.2 was yanked

Can we update the release note on why this version was yanked?
error: failed to select a version for the requirement `aws-smithy-types = "^0.54.2"`
candidate versions found which didn't match: 0.54.1, 0.54.0, 0.53.1, ...
location searched: crates.io index
required by package `avalanche-types v0.0.250`

I updated the release notes: https://github.com/awslabs/smithy-rs/releases/tag/release-2023-02-06
There is a 0.54.3 now that resolves the issue that led to the yank.

Thank you!


(MAINT) Bump puppet submodule for calling_all_functions fix

This commit bumps the Puppet submodule that Puppet Server is using to a
new commit which includes a fix for the calling_all_functions Puppet
acceptance test.  This test has been sporadically failing in the Puppet
Server acceptance test pipeline.

Self-merge, (paddlin) alert.  The only turmoil in this PR is a bump to the Puppet submodule which moves forward one commit from where it was previously in order to pick up a Puppet acceptance test change.  Travis passed so the submodule SHA would have to be valid.  Really want to see a fully green run of the Puppet Server master pipeline to help bolster confidence for the puppet-agent release coming up soon.

Retroactive :+1:


Cow: Watch afroculinaria.com

Cow requests the watch of the watch_keyword afroculinaria\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

afroculinaria\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'at author's request; probably not spam'


Scale existing matrix

Multiple CSS transform3D matrices have been created for a base width of 640px.
Sadly those matrices won't scale, there are no relative units.
I want to use rematrix to scale up all these coordinates by a scale factor.
However, I noticed that when using rematrix' scale operation on an existing matrix,
that this scaling is added as native operation, and not the matrix itself is scaled.

I don't understand. Do you have a question, or example?

@jlmakes: So let's say I defined a CSS matrix3d transform, using the matrix construction set tool.
The issue is that the matrix itself is defined for exactly these dimensions, there is nothing relative/fluid about this.
When I now want to use this matrix for an element which width will change (mostly increase) because of the page layout, the matrix won't adjust by itself.
I could try to scale up the parent element using scale transform, but it doesn't seem to work either.
What I try to achieve is that an element that is transformed according to this matrix can be resized up and down together with its matrix.


Set client hostname same as callsign.

This changes the client hostname from ESP32-XXXXXX to Callsign. The idea is to make DHCP server log less confusing, as on a big network it can have many ESP32-XXXXXX entries.
Developed and tested together with S54B.

white space is correct in the commit?

What do you mean? The indentation with tabs is correct.

after WiFi.setHostName is a whitespace in the commit info, that's all

Ah I didn't see it, thanks for spotting. It compiles correctly, even though it is better to remove the whitespace, you're correct.

is a precaution, to avoid setting hostname to "" for any reason. If you are confident that it is impossible to have empty callsign, this check can be removed.

expressif library is very problematic to accept setHostname call, because it only changes a string in memory and the name change only happens after wifi mode changes - if the card is already in station mode, the call will succeed but the hostname will not change. It is requred to change the mode after setHostname, so I though it is better to put it to MODE_NULL  so we have a clean change to MODE_STA. Since we are doing this immediately after reboot so I am sure the card is not in Station mode, but again it is here as a precaution since it doesn't hurt.
See https://github.com/esp8266/Arduino/discussions/8816#discussioncomment-4751623

I see this change in DHCP request (visible in wireshark) and in the DHCP server logs. People will see that on the router, in wifi network management and other network tools. But this does not impact mDNS so you still need to access the device by IP address in the browser.

if desired, I can also prepare a mDNS functionality so you can automatically access the device by http://S57PNX-10.local instead of <IP_ADDRESS>

I avoided the initial revision as the Callsing is always validated to be "non" NULL
please test the updated Main.

The RFC standards for hostnames only allow a-z, numbers and -. Space and underscore are  not allowed (as it can cause problems later on in DNS). Case is not sensitive.
I suggest to change the hostname to "IGATE-"+Config.callsign.

nice info (did not know it... updated!)

No worries, it's a standard from 1985 :)  RFC952
Testing looks good here, OK to close this PR.

added to iGate


Project licence?

Hi, I wish to make a package out of this project to complement the vban suite but sadly I can't add it anywhere due to no licence. Can you select one for this project?

Hi,
Totally forgot to add a license for this project!
I just added an Apache licence 2.0 in commit https://github.com/VBAN-manager/VBAN-manager/commit/5d1d5f888ff1d222dffd931aea5828f62d1c4c48
In what kind of package do you want to add VBAN-manager?

I have the foundation laid out for a Gentoo package, have to research a bit how similar packages are done. Nothing impossible :)

Ok, the difficulty of packaging VBAN-manager is that it's not a software but a web application relying on apache and PHP, a solution could be to put A2/PHP on dependency list, to put VBAN-manager in a special folder (something like /opt/VBAN-manager/) and automaticaly add a configuration to Apache2 to virtualhost anything.com/VBAN-manager to /opt/VBAN-manager/, exactly like PHPmyAdmin does


Code Review 20-04

So far so good @Jawad-Nazari! 👍

@federicaulzurrun :

Everything it's perfect and congrats on adding input data to LocalStorage!
I would make your code even better if you added explanatory comments! check the following link to JavaScript Best pranctice

@LarryIVC :

Very good work but you could consider applying the good practices of HTML by applying semantic elements like the main, header, section, etc.

Very good work @Jawad-Nazari  but you could consider applying the good practices of HTML by applying semantic elements like the main, header, section, etc.

Hi @federicaulzurrun @LarryIVC 👍
Thank you for your time and for reviewing my code. I will consider your advice while coding next time.


[stable/openvpn] Add CRL support

This PR adds CRL support, including a script to revoke clients.

/assign @sameersbn

In my testing, I found that just updating the file correctly updated the CRL, as long as the file was accessible by nobody (since openvpn drops privileges after initialization).  I wasn't aware that this was contradictory to the docs, so maybe it's worth some additional testing by others.  I also didn't test removing certs from the CRL, though I think that's an uncommon use case.

@MarcoGlauser I confirmed that openvpn is checking the file mtime and reloading if newer: https://github.com/OpenVPN/openvpn/blob/3e5561d34099f28a759865efff0523005116b6a1/src/openvpn/ssl.c#L579-L588

Just realized the bot didn't pull in the chart owner, @jfelten

/assign @jfelten

@MikeSchuette @jfelten could not be assigned. can someone else do it? I'd really like to see the PR being merged.

@jmastr I don't know who else to ask or what the protocol is for this repo.  (This is my first PR here.) @jfelten is listed as the chart owner, so I don't know why he can't be assigned.  I'll try to ask in Slack.

@mattfarina is it possible to re-open this one?

Let me try this /assign @mattfarina

Hi, Any update on this one as don't really want maintain our charts and the work done by @MikeSchuette looks really good?

@jfelten Are you maintain this chart?

@sameersbn are you going to approval this?

@scottrigby @seanknox any input?


feat: Add preconfigured support for Smart Agent

The issue where exporters set with the environment variable can't be external also exists for the propagators. The argument was that it is only the environment variable and you are suppose to set custom propagators through the configuration setup code. Is that possible for exporters as well? If not that may be what we want to contribute back.

Sent https://github.com/open-telemetry/opentelemetry-ruby/issues/1365

There's still a docs suggestion to merge


Enable tests

All but one test seems to be passing.  I may have broken it in a previous checkin.  Won't get back around to look at this until tomorrow morning.

You may reopen PR to restart the build.


Document how to control environment when using tools

I'm creating a console application using .net core 2.2 with EF Core 2.2.2. Here I'm struggling to maintain Azure SQL Server connection strings dynamically based on the Environment Variable i.e Dev, stage and Prod environment. The connection strings are maintained separate appsettings.(Environment).json files. So I need to get the connection string from the appsetting.(Environment).json file and pass it to the optionsBuilder.UseSqlServer("Azure SQL DB Connection") function  when I run my console application.  Please help me to resolve this issue.
appsettings.Dev.json
{    "Database": {     "ConnectionString": "Server=xxxxxxxxxx.database.windows.net,1433;Database=qualcontract;User Id=xxxxxx;Password=xxxxxxxx"   } }
I have not seen like this example in MS document.
Thanks in advance,
Parthi Karnan

duplicate of #1338
@ParthiKarnan  see https://github.com/dotnet/docs/pull/20598 which will be live soon.
@smitpatel can you close this duplicate

@ParthiKarnan  see https://docs.microsoft.com/en-us/dotnet/core/extensions/configuration


1007 add notes field to show views

Completed issue #1007. Permitted users can now add notes to reservations and equipment items from their respective show views. In order to get this functionality for the equipment items, I had to change around the update method in the equipment_objects_controller to accept a new_notes parameter.

@connormcl is this ready for review? If so, use the "4 - Needs Review" label, thanks!

Hmmm, looking at how this was implemented I'm not sure that we want to use the #update method for notes. More specifically, I think we can actually remove the "notes" field from the Reservation edit form and separate notes from general object edits. Here's why - notes in both objects are intended as an immutable history of the object, not as an editable parameter. Therefore, there's a difference between editing an object (e.g. changing the start date of a reservation) and adding a note to the history, and we should utilize different controller / object methods to handle those actions.
Here's how I think things should go:

Remove the notes field from the reservation edit form
Take out notes handling from Reservation#update (and go back to the old version of EquipmentObject#update)
Write separate add_notes methods for both the Reservation model and the EquipmentObjects / EquipmentItems model

These should append / prepend something like "### [USER] made a note on [DATE]:\n\n#{new_notes}" to the notes parameter (Reservation notes go from oldest to newest while Equipment Item notes go from newest to oldest).
Also make sure that the heading level matches the other items we put in the notes - I think Reservations use h3's and Equipment Items use h4's.note that

Make the forms in the show views PUT to a new controller method (something like ReservationsController#note)

Don't forget to add the relevant routes!

I'll leave a few inline comments as well to clarify, let me know if that makes sense!

Also note that your view edits will have to be modified post-#1116 to fit with the newer version of Bootstrap.

Looks much better! One thing I noticed is that we're not authorizing this action or the display of the form at all; in other words, any user that can view the relevant pages can leave notes. I'm not sure that this is a bad thing - since notes are intended as an immutable history, the worst thing that could happen is that someone "spams" the notes for a given reservation or equipment item.
We should authorize the controller actions to limit the #note actions to those who should be able to access the form (e.g. checkout persons and higher for equipment items, checkout persons and higher for arbitrary reservations and patrons for their own reservations). This will ensure that someone can't send a PUT request and add notes that way. What do you think about limiting the character counts of a given note addition? It doesn't have to be too small (e.g. tweet size) but this way we'll prevent abuse of this feature. @squidgetx, thoughts?

The permissions you outlined look good, and I think we probably only need to rate-limit for patron level users

What do we want the character limit to be for patron level users adding notes to their reservations? Also, what's the best way to conditionally validate this length for only these users?

I've also added the above permissions, and I'll submit the whole pull request after I add the rate-limiting and merge master into this branch.

Let's do the authorization via CanCanCan and the rate limiting in a custom model validation. In terms of the length, let's say 500 characters? We want users to be able to leave a reasonably informative message if necessary without overloading our notes field.
Looking at our schema, we don't specify a limit for our reservation notes, but we do for our equipment items (16777215 characters, to be precise). More problematically, we don't have a mechanism for handling overflow (I'll open up a new issue for that). Reservations will likely have much shorter notes in general, so it's possible a higher limit than 500 characters would be ok, but let's get the mechanism in place and then we'll make a final decision.
One other thought I had - let's toggle the notes_unsent flag when anyone adds notes to a reservation so admins are notified automatically (although that e-mail probably needs to be refactored). We might want to also implement a similar mechanism for equipment items so that admins know if something comes up with a given equipment item (again, out of scope).

This PR should be good to go!

Left a bunch of inline comments, here are a few more thoughts:

Since we're likely to add similar functionality for user profiles (see #1188), we should probably separate out this functionality into a module so that it can easily be added to all of the relevant models / controllers (and maybe even views). Things to consider:

In most cases we'll be prepending the notes but I still think that appending them for reservations might make more sense - I'm open to discussing this and just prepending everywhere for simplicity.
We'll have different permissions levels for commenting; for example, patrons can comment on their own reservations but no one elses, checkout persons can comment on reservations and equipment items but probably won't be able to comment on users (or see user comments), and admins / superusers will be able to comment on everything.
We'll also have permissions-dependent validations (as we've already started implementing)

If we can easily modularize this functionality now then we could potentially merge that issue into here. Another related issue that we might want to consider here is #1166, more particularly handling the case where we'd overflow the database field, although it's probably better to leave it separate (and it will be easier to implement assuming we modularize this).

We need tests for this to make sure that all validations are working (see above). I'm reluctantly ok to skip unit tests as long as we at least have integration tests for everything, but it would really be better if we put together shared examples for "notable" models and controllers that tested the overall behavior, ensured that each model actually implemented said behavior, and checked the handling of both valid and invalid requests to each controller (particularly to make sure permissions / validations were all working as expected).

On second thought, let's get this merged in without major refactoring to make it more general purpose and then we'll use #1189 as the bucket issue for refactoring (likely including #1166 and #1188). You should still resolve the inline comments I left above, and also implement basic integration tests for going to an equipment item and a reservation as each user role and validating that the form works as expected.


intro example AuthEffects injectable implements OnDestroy

I don't think the implements OnDestroy part of intro.md is intentional and should be removed.

OnDestroy is not imported in the displayed code
Injectables don't have a lifecycle so OnDestroy or OnInit are not used

Injecatables do have OnDestroy hook.

Angular calls lifecycle hook methods on directives and components as it creates, changes, and destroys them.
https://angular.io/docs/ts/latest/guide/lifecycle-hooks.html

Docs on lifecycle hooks don't mention anything about lifecycle hooks for providers, much less injectables. I believe implementing abstract classes unnecessarily like this just bogs code down.

The implements OnDestroy is vestigial from previous versions of @ngrx/effects and needs to be removed. However, @DzmitryShylovich is correct in that providers can implement some lifecycle hooks.

Hmm. Interesting. I can't find anything in the docs about that.


Initial version of the /regions API

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/341/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/299/


Check too long files - limit set to 3000 for the moment

We can see that Travis Fail cause 2 files has more than 3000 lines :)


:sparkles: Support for C++ fuzz functions in the fuzzing check, add more const LanguageNames for clients

What kind of change does this PR introduce?

Add support for C++ built-in fuzz functions check as a part of scorecard's fuzzing check.
Add corresponding unit tests for C++ fuzz func matching
Add more const LanguageNames in clients/languages.go.

[x] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
Scorecard supports (1) ClusterFuzzLite, (2) OSS-Fuzz, and (3) Go built-in Fuzzing in the fuzzing check.
What is the new behavior (if this is a feature change)?**
Checking for C++ fuzz functions now is included in the fuzzing check.

[x] Tests for the changes have been added (for bug fixes/features)

Special notes for your reviewer
Does this PR introduce a user-facing change?
Yes, same as in PR #1979.
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Users now can check for C++ fuzz functions in their repo as a part of the fuzzing check, and with param `--details`, detailed fuzz function names and positions can be seen in the result.

@oliverchang @navidem @metzman can you take a look?

@laurentsimon  I think this PR is also ready to be merged - almost forgot this one :/

Keep this PR active.


parser btc address with balance and random scanner hex

Please link parser btc addres with balance or database link upload
How to run the scanner in the random hex range?

help me set the command line with the instructions below
BitCrack.exe [OPTIONS] [TARGETS]
Where [TARGETS] are one or more Bitcoin address
Options:
-i, --in FILE
Read addresses from FILE, one address per line. If FILE is "-" then stdin is read.
-o, --out FILE
Append private keys to FILE, one per line.
Bitcrack.exe ......?


python-unit-test-launcher

Add more unit tests to geopmpy package for the launcher module.

Fixed by 627cb7925d929ae9dffc1ab77f2bab89e1e29062


Nested card-based accordions don't behave as expected

Accordions with nested cards don't open/close as expected: https://jsfiddle.net/6Laqymq0/

X-Ref: #18160

/me kicks @twbs-lmvtfy back to life
https://jsfiddle.net/6Laqymq0/

Hi @cvrebert!
You appear to have posted a live example (https://fiddle.jshell.net/6Laqymq0/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 47, column 5 thru column 127: Attribute href not allowed on element div at this point.
line 51, column 5 thru column 127: Attribute href not allowed on element div at this point.
line 56, column 11 thru column 136: Attribute href not allowed on element div at this point.
line 60, column 11 thru column 136: Attribute href not allowed on element div at this point.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

@aimeos Please fix those.

@cvrebert Makes no difference: https://fiddle.jshell.net/6Laqymq0/1/

@cvrebert As an improvement, a "data-href" attribute should be used so we aren't forced to add an  tag only for the "href". It works well without the additional tag.

@aimeos The plugin already supports a data-target attribute for such cases.

I'm gonna say this is on-hold until we get Accordions working with Cards in the first place (#18375).
Once that's fixed, we'll recheck whether nested Card-based Accordions work properly.

Closing because I think #22251 addressed this? Please holler if not.


Updating block lists

Operating System
Raspberry Pi
Architecture
64-bit
Platform
Linux
Project
Aduard Home
Browser
Other
Issue
Other (explain in description)
Issue Description
I added all the url's with the python script, do these block lists get updated with new urls automatic or if there is a script that can be run to keep all block lists up to date. I remember with pihole I used to run a script to update all block lists.

@Jonesyj83 you can manually update it from within adguard home interface (check for updates button) in blocklist section. I think it updates when Pi restarted. To have a script to create a cron job,  i will have to find the code to see what triggers "check for updates". Or you can ask in Adguard home repo devs.


Revert selinux policy postinstall filenames

#209
note this won't work in a ubi container since selinux-policy-devel has been removed

Yep, this is why I gave up on having a molecule scenario in jws-dot to test selinux. However, we do need to think about something for the next releases. As proven by this issue, we need to be sure selinux is tested.


Turn off autocorrect on prompts

When using DialogAndroid.prompt the TextInput will autocorrect input by default... which is kinda annoying.
Can we provide an option that disables this?

I patched the source file in react-native-dialogs in order to achieve what I wanted:
file:
reactnativedialogs/modules/DialogAndroid.java
make sure to import input types on top of file:
+ import android.text.InputType;
and replace this (368-370):
- if (input.hasKey("type")) {
-   mBuilder.inputType(input.getInt("type"));
- }
with this:
+ mBuilder.inputType(InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS);
Notice, you will get a default text keyboard WITHOUT suggestions

closing this

This is something that we should introduce into the lib.


NetAdapterRss Resource Additional Properties

Description
The NetAdapterRss resource only allows enabling/disabling Rss, but Set-NetAdapterRss can set other parameters.  I use some these parameters when configuring VMQ on Hyper-V hosts.
Proposed properties
NumberOfReceiveQueues
Profile
BaseProcessorGroup
BaseProcessorNumber
MaxProcessorGroup
MaxProcessorNumber
MaxProcessors
NumaNode
Special considerations or limitations
MaxProcessorNumber and MaxProcessors are interdependent so setting them both could cause conflicting settings.

Good idea. If implementing this I'd suggest moving this resource to be data driven - similar to DnsClientGlobalSetting (see https://github.com/PowerShell/NetworkingDsc/blob/dev/Modules/NetworkingDsc/DSCResources/MSFT_DnsClientGlobalSetting/MSFT_DnsClientGlobalSetting.data.psd1).
I'm planning on doing some work on NetworkingDsc over the next few weeks since my most recent PR was completed. This one could be a good one to implement reasonably easily.

I'd love to implement it, but I only just learned DSC.  I have some learning to do before I can start contributing!

No worries @nmdange2 - if you're ever interested in contributing, the community over here are always happy for the help and will support and guide you through the process! We all started at the same place :grin:

Just wanted to comment on this that due to changes in WS 2019, I don't need these features so much anymore.  I'm ok closing this issue unless someone else wants these features.
https://techcommunity.microsoft.com/t5/Networking-Blog/Synthetic-Accelerations-in-a-Nutshell-Windows-Server-2019/ba-p/653976


Update referrers.json

Above - Headliner is using another TLD as well - I'm seeing traffic from headliner.link as well as traffic from the naked headliner.app domain as well. I think this should, if you'll pardon the Pokemon reference, catch 'em all.

Thanks!  I'll add some examples from OP3 in a followup


VM: Remove redundant DeepCopy - cleanupRestartRequired & addRestartRequiredIfNeeded

What this PR does
cleanupRestartRequired and addRestartRequiredIfNeeded don't require a Copy anymore.

Fixes #
Why we need it and why it was done in this way
Special notes for your reviewer
Release note

NONE

/cherry-pick release-1.2

Hi,
I see this was introduced very recently with https://github.com/kubevirt/kubevirt/commit/524d64f8526c47a and looking at the PR that introduced it, there was a discussion about this. So, this is just a follow-up from https://github.com/kubevirt/kubevirt/pull/11054#discussion_r1478948059
In the future, please add this kind of info in the Special notes for your reviewer to speed up review :)
/lgtm

Hi,
I see this was introduced very recently with 524d64f8526c47a and looking at the PR that introduced it, there was a discussion about this. So, this is just a follow-up from #11054 (comment)
In the future, please add this kind of info in the Special notes for your reviewer to speed up review :)
/lgtm

@victortoso I have added a note to PR description ;)


Fixed small typo in Readme

Makes it kind of hard to do a copy/paste 😅

Thanks!

Coverage remained the same at 81.773% when pulling 8d91eccc76f7fcb952c729c551056469e43b7fbb on svdgraaf:patch-1 into f29a4fe2eee39f7ef018c125d460ee8898856ce4 on Rebilly:master.


Host the docs on a permanent domain

We are hosting our documentation via github docs, on nhsuk.github.io/nhsapp-frontend.
The problem here is that our domain is tied to both the github org name, and github itself. If we ever want to move away from either of these, then our domain will have to change.
We can keep hosting via github docs but add a custom domain so that we have more freedom to move where it's hosted in future.

Decide what the domain should be. Here are examples of some other design systems:

service-manual.nhs.uk
design-patterns.service.justice.gov.uk
design.tax.service.gov.uk

Implement the domain name change

The domain for the app itself is www.nhsapp.service.nhs.uk

design-system.nhsapp.service.nhs.uk ?


[TextExtractor] default enabled until Win10 + infobar in Settings page

Summary of the Pull Request
Making the TextExtractor module disabled by default for Win11 or greater and enabled until Win10.
Adding an infobar to the settings page with recommendation to use the Snipping Tool instead (only visible for Win11 or greater)

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

And where can the user find info about the "why" ? :)

I presume disabling the entire module on Win11 would go too far? 😅

/azp run

I presume disabling the entire module on Win11 would go too far? 😅

It's not disabled :) It's just "disabled by default" on first install (meaning no Settings exist yet)

I meant, if Snipping Tool is better, one could choose to make this module more like invisible... But that's just an idea.

@jay-o-way some people may prefer the PowerToys tool still as we can do one thing the current snipping tool cannot.

@jaimecbernardo please move forward with this PR