Fixing import module woes

Note: this ticket is not yet well-specified, intended to serve as an area to get the ball rolling and collect requirements. Some familiarity with existing makefile-based owltools pipelines would help.
Minimal annotations
When creating import modules, I generally make the annotations minimal. Labels (plus the necessary logical axioms for reasoning of course). Sometimes this is not ideal; editors of the main ontology like to be able to search by syns, see definitions at least. E.g. https://code.google.com/p/envo/issues/detail?id=131
Currently the strategy is to tweak the makefile according to requests from the main ontology editors. E.g. sometimes we change the command to include syns/defs. The main reason not to include these is simply to avoid VCS churn (e.g. for GO the import modules are regenerated daily, people frequently need the set of external terms referenced handy)
Extending the import module
If editors need an external term not currently in an import module, we often put them through a hellish procedure. Some README-editors files have a baroque procedure involving switching to a URI view, pasting in the desire URI, then regenerating the imports. With GO editors add to an imports-requests obo file and Jenkins will include the term in the import module when they wake up next morning.
Short of having this fully integrated into Protege it would be nice if there was an easy to run command line way of extending the import module.
Another thing that would be useful would be a way of seamlessly swapping out the import module for the full ontology (with some catalog trickery plus handling of syncing a local copy of the full ontology). This would allow the editors unhindered search of the full external ontology. This can sometimes overwhelm Protege (e.g. CHEBI or Uberon as externals) so an intermediate strategy may be useful (e.g. a module that includes all classes and logical axioms, but excludes axiom annotations, for example)

OntoFox should not be out of the question. I generally find I need the full version of the external ontology (or some version of it) pre-processed by custom commands in place first, and I like using code that is documented parts of the OWLAPI and I feel that this is the best target for longer term development (ideally the whole module extraction business should be much more dynamic and driven by different requirements - e.g. a reasoner would extract a module for one purpose, a Protege user another, a downsream user another).
But other opinions are available

OntoFox started as a MIREOT tool, then added some tricks that make sense in SPARQL. The OntoFox import format covers a range of options, including remapping superclasses and annotation properties, and extracting partial hierarchies. We should support these features but pull them apart into separate, composable commands. We should be able to specify all the commands needed to build an ontology (and its subsets) in a build file.
OntoFox has limitations that we need to overcome:

use local copies of ontologies instead of a central triplestore
use specific versions of ontologies, not just whatever is in the store

I think we should fetch versioned ontologies to a local cache, then build a OWLAPI IRIMapper for the cache. The cache could be project-specific (like Ivy) or user-specific (like Maven) -- I think I prefer the former.
Specifying versions is really important, but people are lazy. We should include a command to update all dependencies to the latest version (and make it easy to roll back). Then we should enforce the use of versioned ontologies.
Once the source ontologies are handled, we can start by supporting two main import methods: MIREOT (isolated terms) and modules (using the Syntactic Locality Module Extractor). We can get more control over modules by stripping axioms first.

Let's discuss the ivy vs maven thing next call

I’ve developed an approach that I use for one of our projects for dealing with similar needs. I also built some tooling for it but I’m redeveloping it in a different way so the existing tooling will not evolve beyond bug fixes for now.
My approach was the following:

We have one or more of input axiom sets (source ontologies)
We have an OWL configuration file that describes what axioms should be copied from input sets, (i.e. the ontologies). I use OWL entity annotations to mark entities as “include”, “include-with-subs”, “exclude”, “exclude-with-subs”, etc. These are OWL annotations on the corresponding entities; they can be added like any other annotations in protégé. They are like tags.
The tool looks at the input sets, the configuration file, and then acts accordingly to generate the output axioms, a single owl file.
The configuration file also lists “builders” that should be applied by the tool against the input axioms. A builder is a named algorithm that extracts some axioms based on the configuration. You can think of them as commands but they are represented in an ontology annotation in the configuration file. Several builders can be specified to apply a chain of actions by the tool but. The builders are contributed by Jar files that provide a named factory for instances of the builders.
See this file for example:
https://open.med.harvard.edu/svn/eagle-i-dev/datamodel/trunk/src/isf/module/eaglei/eaglei-module-configuration.owl
It only lists the “simple-inferred” builder in one of the ontology annotations. When the tool is ran, it first runs the “simple-inferred” builder against the source closure that is specified with the eaglei-module-source.owl import. Few other ontology annotations and configuration files add the following features:
While the builders run, if any of the extracted axioms are in the “exclude” set, they are not added to the output. The “exclude” set is represented in another OWL file. See the SVN directory for the above file.
After the builders run, there is a “include” set to add additional axioms that can’t be extracted by the builders.
The tooling I wrote is called OwlCL, which stands for “owl command line”. It is based on Guice, and it is extensible by simply adding jars in the extension directory. You can see the project here: https://github.com/ShahimEssaid/OwlCL  I was planning on continuing with this tool but I’m now favoring a different approach so I’m not evolving it any more beyond bug fixes for my own use. Few of the existing commands are also broken but I will fix them as needed.
As I said above, the tool is being replaced with a more general framework based on the Java CDI framework. The above approach, or some better version of it, will be re-implemented in the new framework. I am working on this whenever I have time but I don’t want to promise anything until it is ready for a show and tell. The new tool is basically a generic “CDI command execution framework and runtime container” that enables all the Java EE features of CDI in Java SE. This framework can then be embedded in Protégé to provide may commands (invoked from menus), or in Gradle and have the commands wrapped with Gradle tasks to be driven by a Gradle build, or wrapped in a command line interface such as JCommander to use it from the command line. The framework doesn’t have a specific interface; it just has a client API that can be embedded in different interfaces. I’ll hopefully have something soon that I can document and share to get some initial feedback.

For the Ivy vs Maven issue, I think we need to pick a repository structure (not the specific deployment tools) and then we can reuse existing tools to work with it. For example, Ivy can work with Maven repositories but Maven doesn't understand the Ivy repository structure unless there is a plugin that can help with that.
My approach would be to define how we will use the Maven repository structure and versioning to share ontology artifacts, define what is an "ontology artifact", how such an artifact be used in Java SE, OSGi, OWL-API, direct URLs import, etc. This will require that the artifact contain multiple representations of the ontology (as a jar file, as a compressed/uncompressed rdf files, other syntaxes, etc.) to accommodate these different use cases for the same ontology. I have some ideas for this but I first need to test them in a prototype.
I would then pick an API to work with the above Maven rapository. My recommendation is to use Ivy. It is more sophisticated, better documented, and is a pure dependency resolution framework as opposed to the Maven APIs that also include a build API. Currently, Maven is using Eclipse's Aeather framework under the hood to do the dependency resolution but the last time I looked at the API there was not enough documentation, and I don't think there is a lot of use of this API beyond the company that develops Maven related tooling (Sonatype). Gradle uses Ivy for dependency resolution so the Ivy API is part of the Gradle core.


GCP: fixed accounttypes typo.

Fixed typo in dashboard.  Thanks to @cstewart87 for catching this.

Coverage remained the same at 52.726% when pulling 590cb2603a03511b02f81278de551888ab52f7d7 on supertom:acct_type into 3374be6ba15889fa1a1e1163d945f44784fdb3bd on Netflix:develop.


[WFAPI-3182] Removing support for Ruby 2.2.1 and older

LGTM

Hi, I am trying to fix the build with this PR. Turn out we have this test:
# subscriber_spec.rb

# cannot use PubSub::Subscriber here because it would be evaluated before
# our overrides for Redlock below are processed
describe "PubSub::Subscriber" do
[...]
  describe '#subscribe' do
    it 'should work' do
      PubSub::Subscriber.subscribe
      ExampleUpdate.new(name: 'some name').publish
      expect(ExampleUpdate).to receive(:process) do
        raise NotImplementedError
      end
      expect do
        PubSub::Poller.new.poll
      end.to raise_error(NotImplementedError)
    end
  end
end

I’m really not sure about what it is testing. It breaks the suit because we can't simply call PubSub::Subscriber.subscribe, since it has a send on it. Any ideas on how to stub that?
\cc @adamcohen

@hannelita I noticed that test as well, it fails locally for me, but I thought it might have been something to do with my setup.  I looked at the failed build in Jenkins and it was due to the incorrect ruby version, and I wasn't able to see the output of the failed Travis build, so I couldn't verify that the issue was happening elsewhere.
In any case, I think we can get rid of that test since I'm not sure what it's testing either, as it seems to be making an actual live request.  I've tried stubbing out all the method calls, and ended up going down a rabbit hole with a huge number of mocks and expectations.

@adamcohen yep, I tried several things as well. If you are curious, this is the failure, after removing the 2.2.1 build error:
Failure/Error: PubSub::Subscriber.subscribe
     Aws::Errors::MissingCredentialsError:
       unable to sign request without credentials set

Basically, the before config for aws does not work; possibly because we have a class method (subscribe) with a send.
We can open a ticket trying the following:

testing the private methods of subscribe.rb;
brainstorming a convenient way to stub subscribe class
WDYT?

@adamcohen  My point with this test is that it looks meaningless - expecting the rise of NotImplementedError does not look like a good way to test the subscribe function.

@hannelita The test was added in https://github.com/westfieldlabs/pub_sub/pull/61 and it passed jenkins at the time, so it looks like it did work at one point.  I'm not sure why it's stopped working. I've tried checking out the code from the last point where the tests were passing, and even tried changing all my gem versions to the same as Jenkins, and it still fails with the Aws::Errors::MissingCredentialsError error.
Apparently there are some stubs that can be used for testing AWS, there's some notes about it here, so this might be worth addressing in the future.
As it stands, it's very difficult to test the PubSub::Subscriber class since it's comprised of one single public method self.subscribe and 9 private methods, so we can't test each method in isolation.
I don't think we're losing much by removing this test, since it didn't work, and it's difficult to understand what it's doing, so it looks like it should be rewritten.  I've created PEEPS-2553 so we can track this requirement.

I'm curious though - why are the Jenkins tests still failing if the minimum ruby version has been changed to 2.2.2?

@adamcohen It's Jenkins being naughty. It looks like we ran into this issue: https://issues.jenkins-ci.org/browse/JENKINS-33687 . See log:
New build name is '#112 17c75189'
Variable with name 'BUILD_DISPLAY_NAME' already exists, current value: '#112 17c75189', new value: '#112 17c75189'
[ssh-agent] Stopped.
Collecting metadata...

Jenkins fixed, I'll merge it @adamcohen @adbatista


Turn off optimizely on build.

Yes, I really do mean it.
Fixes #5811

@angaither But this code is being executed on pull stage.
Did you intend it to?

@sergii-tkachenko yes, just so we can turn off it off locally #1507

@angaither Can you also drush pmu (pm-uninstall) it?

@sergii-tkachenko sure, but why would we also need to uninstall?

@angaither Because that's the correct way to turn modules off.
It will destroy its schema and remove its variables. See optimizely_uninstall();

@sergii-tkachenko I don't think we need to uninstall it, it's just removing tables, all we want is the JS to not be executed locally

:+1:


Make main readme/docs less intimidating

I can do more here if you would like

Been meaning to do this.. Thanks!


Use dependency management

Right now enry is a Golang:

library
application in cmd/

As it's a library, it would make sense to start using dependency management \w go modules \wo checking in the vendoring.

This can be go modules as soon as it's support is more matured and go 1.12 is out.

https://golang.org/doc/go1.12 is out 🎉

This is also a good time to change all the imports from gopkg.in to github.com ones.


user-switchable menumode

Hi, I have not seen information about a toolbox option and I would like to ask before touching anything. within customization / various
there is an option that will be called user-switchable menumode
I don't know exactly what you mean could you help me?
Thank you very much and congratulations on your good work.

I think this is caused by faulty design of the screens, and bad testing at Seat.
Driving modes without the button is currently not yet possible. Maybe I'll find a way.

Hello I activate green menu but where I find the telent on MIB 2.5 to access with dlink 100

Hello I activate green menu but where I find the telent on MIB 2.5 to access with dlink 100

I don't really understand the question, especially not if I try to relate it to this topic.

I look for the item on the green menu to access dlink dub100 not internet (telent)

I look for the item on the green menu to access dlink dub100 not internet (telent)

This is never in the menu on MIB2


Add Issue templates and PR templates.

Goals ⚽
I've been looking through the Issues to find some issues to triage, but found many issues without any details about them. I figured that we would benefit a lot from using issue/PR templates and getting more information about the problems.
Please let me know if you think different format/types should be used to these templates.
Implementation Details 🚧
Added bug_report.md, general-questions.md, and feature_request.md for issue templates, and pull_request_template.md for PR template.

Very nice! I like it. Meant to do this at some point, so very appreciative for this PR.


Allow public embedding dashboards and charts

Fixes #69

Codecov Report

Merging #79 (dd3c529) into master (30f5e00) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         8    +2
  Lines          303       347   +44
  Branches        63        39   -24
=========================================
+ Hits           303       347   +44

Impacted Files
Coverage Δ

datasette_dashboards/__init__.py
100.00% <100.00%> (ø)

tests/test_dashboard_chart_embed.py
100.00% <100.00%> (ø)

tests/test_dashboard_embed.py
100.00% <100.00%> (ø)

tests/test_dashboard_view.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix broken link in notebook README.md

This replaces the old jupyter notebook link which is no longer available on jupyter.org with the new working link.

Old link is broken and the new link looks correct.

@iAliJ thanks for contributing this fix!


Changes between Smithy-Python mainline

Issue #, if available:
Description of changes:
This contains changes to Smithy-Python, mostly to make it more extensible for our use case.
I've gone into some depth to justify each change. I would like to merge these upstream and want to make a good case for these changes to Smithy-Python team.

ConfigGenerator.java

Bug fix. This file generates invalid code if there are no operations on the service.
Before: _ServiceInterceptor = Union[ (unclosed bracket)
After: _ServiceInterceptor = Union[None]. There are alternative solutions here that I'd be happy with. But this is a low-importance edge case.

DirectedPythonCodegen.java

Make DirectedPythonCodegen public.
Smithy-Dafny creates its own SmithyBuildPlugin.
This differs from the Smithy-Python SmithyBuildPlugin by not calling runner.performDefaultCodegenTransforms() nor runner.createDedicatedInputsAndOutputs();.
These settings transform the input Smithy model shapes before generating code.
However, Smithy-Dafny-generated Dafny code does NOT perform these transformations.
As a result, the generated Dafny transpiled into Python does not align with the Smithy-Dafny generated Python.
Disabling these calls to the runner disables the model transformations.
The SmithyBuildPlugin requires access to DirectedPythonCodegen. By making it public, the plugin can access it.
(An alternative to making this class public is to modify the logic of Smithy-Python's PythonClientCodegenPlugin to not transform the model, or to allow disabling the transforms. This is a more complicated approach that would change Smithy-Python's implementation, so I decided against this.)

PythonSettings.java

Make PythonSettings not final.
The PythonSettings contains useful codegen settings that Smithy-Dafny (and Smithy-Python) access during generation. (e.g. get generating service ShapeID).
However, PythonSettings does not allow adding arbitrary settings.
Smithy-Python has a use case to add a generationType setting modelling whether this is 1) a localService shape, 2) a wrapped localService shape, or 3) an AWS SDK shape.
Since PythonSettings is final, it cannot be extended.
This change makes PythonSettings not final to allow it to be extended for our use case.

StructureGenerator.java

Make StructureGenerator public.
Smithy-Python does not generate code to model shapes that are not used by the service under generation.
Smithy-Dafny has a use case to generate code for these shapes in case another localService uses a shape defined in a model. (Dependency shapes).
Ideally, we could 1) identify all shapes that need generation, and 2) perform generation for those shapes.
1 can be done within Smithy-Dafny by finding shapes in the model that are not used by the service under generation.
2 can be done by calling Smithy-Python's generator for these shapes. This generator is the StructureGenerator, which is private.
Smithy-Python calls its StructureGenerator to generate all structure shapes.
By making this public, we can plug in Smithy-Python's codegen here and use the same code generation as Smithy-Python.

BUILD

Remove BUILD. I don't think we would commit this change, but this lets me build on Mac. Ideally we would find an alternative approach.
Mac writes its build artifacts to build. MacOS is case-insensitive. If a BUILD file is present, it is unable to write build artifacts to build. The package still builds without this file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Some thoughts on each patch, as I'm hoping we can minimize how many we actually need, and also make sure that we don't have more coupling between smithy-dafny and smithy-python than we absolutely need.

ConfigGenerator.java

Seems like a reasonable bug fix. But why do we ever need services with no operations?

DirectedPythonCodegen.java

Could you clone the model before invoking smithy-python on it instead? That seems like a good idea for all cases where smithy-dafny uses other existing code generation tools.

PythonSettings.java

I'd be a lot happier if we added smithy-dafny-specific configuration to our CLI and https://github.com/smithy-lang/smithy-dafny/blob/main-1.x/codegen/smithy-dafny-codegen/src/main/java/software/amazon/smithy/dafny/codegen/DafnyClientCodegenPluginSettings.java instead. Does smithy-python itself actually need to know about generationType?

StructureGenerator.java

It might be pretty reasonable to make StructureGenerator public. But on the other hand I know the Smithy team will be adding a shapes property to services specifically for supporting codegen on shapes that aren't otherwise in the service closure: https://smithy.io/2.0/guides/building-codegen/overview-and-concepts.html#type-generation

BUILD

This one is definitely reasonable and hopefully will be accepted. :)

But why do we ever need services with no operations?

We really don't. But Smithy-Dafny has a LocalService TestModel that has no operations. This is required to have that generate valid code.

Could you clone the model before invoking smithy-python on it instead?

If I understand you correctly, this won't help.
Are you asking if creating a model_clone.smithy file will work?
The transformation happens at runtime inside the CodegenDirector. The literal model file is not transformed, but the model stored in memory is transformed before it is used for any code generation.
wrt. using other code generation tools, there is no "standard" here, so there isn't a great pattern to apply here. ex. Smithy-Typescript disables one of the transformations Smithy-Python uses.

Does smithy-python itself actually need to know about generationType?

Maybe not, but it's certainly cleaner if it does...
Let me tackle SDK generation before we decide this. I'll have a better sense of whether this is needed then.

Does smithy-python itself actually need to know about generationType?

No, this is removed in the latest commit.


Workflow: Add Xiaomi Mi 13 Build

Description
[Description of the changes you are submitting]
Checklist

[Y] Have you tested the change you are submitting?
[Y ] Is the commits history nice and clean?

https://github.com/CodeNinja-sys/edk2-msm/actions/runs/5165224596/jobs/9304613646 a uefi installer

@CodeNinja-sys commit history isn't "nice and clean"

@CodeNinja-sys commit history isn't "nice and clean"

well, it's not so terrible yet


Feature: Add flat json driver

This adds a new driver which allows for storage of model data in a flat json file structure.  For example, a model named "Post" would store all of its entries in content/posts.json.
Use case:
I personally am using this to allow importing whole models into javascript without any api endpoint.

Still want to do this, but will need to be done on the 2.x branch.


DBAAS-1193: workaround to the ack-rds-controller v0.1.3 upgrade issue

Description

With ack-rds-controller v0.1.3, the label selector of the deployment of the operator is changed.
However, this field is immutable.
As a result, upgrading ack-rds-controller from an older version to v0.1.3 fails.
Jira: https://issues.redhat.com/browse/DBAAS-1193
The workaround is to use the RHODA operator to check the status of the ack-rds-controller v0.1.3 csv.
If the upgrade issue is detected, RHODA operator will delete the deployment of the ack-rds-controller.
Then the deployment of the ack-rds-controller will be re-created automatically, and the upgrade will contiune.
Verification Steps

Upgrading RHODA v0.0.3 to 0.0.4.
Check if the upgrade succeeds and if the ack-rds-controller is upgraded to v0.1.3.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (Definition of Done)

[ ] All acceptance criteria specified in JIRA or in issue number have been completed
[ ] Unit tests added that prove the fix is effective or the feature works
[ ] Documentation added for the feature
[ ] all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

ack on the hold, just gimme a shout whenever you're ready. Thx!

Coverage for the new function fixRDSControllerUpgrade	 is 81.8%.


[Fix #3426] Fixes Style/RedundantParentheses for indexing with literals.

Style/RedundantParentheses would not report an offense when parentheses surrounded an indexing operation for a literal, but would work with a regular function call. This PR fixes this issue by also including strings, arrays, and hashes in the node matcher.
I stuck with the a method call offense, but perhaps there's a better wording (even though technically it is a method call to :[])?

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

I stuck with the a method call offense, but perhaps there's a better wording (even though technically it is a method call to :[])?

Yeah, that's OK.

👍


babel-jest can't handle template strings within a require statement in with --watch flag

🐛 Bug Report
When running require within a block of code that contains a template string (e.g. require(images/${imageURL})), babel-jest fails to resolve the template string properly when running jest --watch. It works fine without the --watch flag.
To Reproduce
Run jest --watch with babel-jest set as the transformer on a file that contains the following:
const ImageLink = ({ linkPath, linkLabel, imageSource }: ImageLinkProps) => (
  <Link to={linkPath}>
    <img alt={`Navigation link to ${linkLabel}`} src={require(`$images/${imageSource}`)} />
    {linkLabel}
  </Link>
);

Expected behavior
The above code is valid and works without issue when transformed by babel-jest without the --watch flag. I expect it to work without issue with --watch set as well. However, I currently get the following error from jest (which in turn doesn't run, due to a non-existent file):
Could not locate module $images/${imageSource} mapped as:
/home/thisissami/code/s2sFrontEnd/static/images/${imageSource}.

Please check your configuration for these entries:
{
  "moduleNameMapper": {
    "/^\$images(.*)/": "/home/thisissami/code/s2sFrontEnd/static/images$1"
  },
  "resolver": null
}

This clearly means that babel-jest is not resolving the template string within the require, and is rather treating the template string as a normal string. When changing the above code to the following, babel-jest transforms without issue with the --watch mode:
const ImageLink = ({ linkPath, linkLabel, imageSource }: ImageLinkProps) => {
  const src = `$images/${imageSource}`;

  return (
    <Link to={linkPath}>
      <img alt={`Navigation link to ${linkLabel}`} src={require(src)} />
      {linkLabel}
    </Link>
  );
};

Run npx envinfo --preset jest
Paste the results here:
  System:
    OS: Linux 4.15 Pop!_OS 18.04 LTS
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
  Binaries:
    Node: 10.8.0 - ~/.nvm/versions/node/v10.8.0/bin/node
    npm: 6.4.0 - ~/.nvm/versions/node/v10.8.0/bin/npm
  npmPackages:
    jest: ^23.5.0 => 23.6.0

Would you mind putting up a quick reproduction that does not use react but still show the error?

I have created a reproduction may related to this issue: https://github.com/otakustay/jest-bug-demo
yarn
jest --watch
jest will be success while jest --watch will fail

This is also referenced in #4552

The same thing happens if using the --findRelatedTests cli option. Any updates?

@SimenB @thymikee any updates? There's been a reproduction for several months now.

Here's another reproduction using React. https://codesandbox.io/s/jest-test-wylir If you run that with jest --watch it will not work. Adding this to update that using newer ES dynamic imports, the same thing happens. it is not limited to just require.

@SimenB @thymikee if you guys can point me to where the relevant files would be, I'd be happy to take a look and see if I fix this bug. It's really frustrating to have to have 2 different sets of code (one for running the server, and one for testing) that we have to keep commenting out/in - depending on what our use case is.
The requirement by jest --watch to define the url in a separate variable before requiring/importing it makes it so that webpack is unable to resolve things, as it interprets an alias in the url (which we are using) as an actual destination.

Hi @thisissami, I've just taken a look at this.
@otakustay's repo seems like a different issue and it has been discussed in #4552 already.
Unfortunately, your Codesandbox contains a lot of incompatible dependencies, such as Jest 24 and Babel 6, and lots of extra code, so I'm not sure how useful it is to debug this. I took the time to make a proper minimal repro that I think describes the same issue: https://github.com/jeysal/jest-7511-repro
I haven't had the time to dive into this much deeper though. It's clearly caused by configuring a moduleNameMapper and adding an import that it applies (doesn't happen otherwise), but I'm not sure why this matters or why it doesn't crash otherwise (no idea what code decides not to detect a template string as a dependency when doing static analysis to figure out dependencies for watch/findRelatedTests).
If you want to have a go, the interesting places are probably jest-haste-map and its dependencyExtractor (where the files are statically searched for dependencies), SearchSource where the findRelatedTests operation is performed, and jest-resolve-dependencies, which is used there, and jest-resolve, which is in turn used there and considers the moduleNameMapper option.

Thanks for the info @jeysal. I've found a workaround in the meantime that allows our codebase to not need to change between running jest --watch and everything else. For the files in question, just removing the alias and instead having a ../../../../folder1/folder2/file does the trick. I'm accordingly not going to bother, given that there's a large number of possible locations.
I do find it a bit weird that running jest without the --watch flag works without issue though. I wonder what changes there that makes aliases problematic.

I think after playing around with various things, the bigger issue is the alias. i tried breaking things out into 2 normal strings being concatenated together (before trying this workaround), and the alias wouldn't work with --watch mode using that approach either.

I do find it a bit weird that running jest without the --watch flag works without issue though. I wonder what changes there that makes aliases problematic.

The static analysis, trying to figure out dependencies between files in order to determine which tests relate to SCM-changed files and need to be rerun, is probably the thing happening only in watch mode that breaks down here.

same problem here

You can verify the above by running jest --only-changed (or jest -o for short) which does the same thing --watch does when it comes to VCS

Using --watchAll works correctly.


[Bug Report] Infinite join/leave loop with a custom build

Describe the bug
I have built the bot with openjdk-14 as well as latest maven on Debian 10.10 and once I start the bot ( java -Dnogui=true -jar JMusicBot-Snapshot-All.jar ) and try to play something - it just leaves and re-joins in an infinite loop.
To Reproduce
Steps to reproduce the behavior:

Build the bot on Debian 10.10
Run the bot
Play anything

Expected behavior
It should not get into that infinite join/leave loop obviously.
Debug Info
System Properties:
  java.version = 14
  java.vm.name = OpenJDK 64-Bit Server VM
  java.vm.specification.version = 14
  java.runtime.name = OpenJDK Runtime Environment
  java.runtime.version = 14+36-1461
  java.specification.version = 14
  os.arch = amd64
  os.name = Linux

JMusicBot Information:
  Owner =<PHONE_NUMBER>21864450
  Prefix = !!
  AltPrefix = null
  MaxSeconds = 0
  NPImages = false
  SongInStatus = false
  StayInChannel = false
  UseEval = false
  UpdateAlerts = true

Dependency Information:
  JDA Version = 4.2.1_253
  JDA-Utilities Version = 3.0.5
  Lavaplayer Version = 1.3.75

Runtime Information:
  Total Memory = 54
  Used Memory = 18

Discord Information:
  ID =<PHONE_NUMBER>22149634
  Guilds = 4
  Users = 6

Additional context
I am using my own fork as I did some custom changes, although it's totally unrelated and the issue remains the same with the main (unmodified) branch. If you still need to take a look though you can find it here - https://github.com/FALL1N1/MusicBot

Building this bot yourself is not supported. If you encounter this issue on a released, unmodified jar, feel free to open a new ticket.


adding onStart and onStop callback

I'm not sure this feature is necessary. Instead of a callback, just make a wrapper function that runs whatever code you want in addition to calling start/stop.


Add caching for request endpoints

Add  caching to the api endpoints. A possible solution would be the use of the spring-boot-starter-cache package.


IRSA configuration is failing with 6.1.0/5.2.0 release

I am deploying KES on EKS(eks.3 = kube 1.18). The controller is up and running with IRSA configuration. However, it keeps failing to fetch for the secrets from the AWS Secrets Manager using the worker instance profile.
logs:
ERROR, User: arn:aws:sts::<account_id>:assumed-role/alz-gdp-pg1-dev-eks2021010820415829350000000e/i-0bbb53922975471c2 is not authorized to perform: secretsmanager:GetSecretValue on resource: arn:aws:secretsmanager:eu-central-1:<account_id>:secret:hello-service/credentials-6O9nph"}

Below is my configuration:
values.yaml :
  AWS_REGION: eu-central-1
  AWS_DEFAULT_REGION: eu-central-1
  DISABLE_POLLING: true
  LOG_LEVEL: debug

serviceAccount:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam:: <account_id>.:role/kes-sa-role

image:
  repository: <account_id>.dkr.ecr.eu-central-1.amazonaws.com/kubernetes-external-secrets
  tag: 6.1.0 # and for 5.2.0

securityContext:
  fsGroup: 65534

ServiceAccount:
apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::<account_id>:role/kes-sa-role
    meta.helm.sh/release-name: kes
    meta.helm.sh/release-namespace: default
  creationTimestamp: "2021-01-10T22:56:27Z"
  labels:
    app.kubernetes.io/instance: kes
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: kubernetes-external-secrets
    helm.sh/chart: kubernetes-external-secrets-6.1.0
  name: kes-kubernetes-external-secrets
  namespace: default
  resourceVersion: "510649"
  selfLink: /api/v1/namespaces/default/serviceaccounts/kes-kubernetes-external-secrets
  uid: 74f04504-aee2-44cd-96de-eab47b9cd2a3
secrets:
  - name: kes-kubernetes-external-secrets-token-zjvx6

trust-policy:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "",
      "Effect": "Allow",
      "Principal": {
        "Federated": "arn:aws:iam::<account_id>:oidc-provider/oidc.eks.eu-central-1.amazonaws.com/id/3D3B84B370338EB5B8A6728992E7930F"
      },
      "Action": "sts:AssumeRoleWithWebIdentity",
      "Condition": {
        "StringEquals": {
          "oidc.eks.eu-central-1.amazonaws.com/id/3D3B84B370338EB5B8A6728992E7930F:sub": "system:serviceaccount:default:kes-kubernetes-external-secrets"
        }
      }
    }
  ]
}

I fixed with:
securityContext:
fsGroup: 1000
the to the fact the node process is running with uid and gid 1000 inside the container

I fixed with:
securityContext:
fsGroup: 1000
the to the fact the node process is running with uid and gid 1000 inside the container

thanks @c4m4, it still falls to instance profile.
                                                                                AGE
hello-service   5m1s        ERROR, User: arn:aws:sts::<account_id>:assumed-role/alz-gdp-pg1-dev-eks2021010820415829350000000e/i-004293898db050175 is not authorized to pe
rform: secretsmanager:GetSecretValue on resource: arn:aws:secretsmanager:eu-central-1:<account_id>:secret:hello-service/credentials-6O9nph

thanks @c4m4, it still falls to instance profile.
                                                                                AGE
hello-service   5m1s        ERROR, User: arn:aws:sts::<account_id>:assumed-role/alz-gdp-pg1-dev-eks2021010820415829350000000e/i-004293898db050175 is not authorized to pe
rform: secretsmanager:GetSecretValue on resource: arn:aws:secretsmanager:eu-central-1:<account_id>:secret:hello-service/credentials-6O9nph

@jihed could you check if you are using the role arn in any secret yaml, you need to specify the role on in the serviceaccount

@jihed could you check if you are using the role arn in any secret yaml, you need to specify the role on in the serviceaccount

@jihed could you check if you are using the role arn in any secret yaml, you need to specify the role on in the serviceaccount

I use role only on the ServicAccount. Not on external secrets.

@jihed could you check if you are using the role arn in any secret yaml, you need to specify the role on in the serviceaccount

I use role only on the ServicAccount. Not on external secrets.

check in your role, if you have the assume policy

check in your role, if you have the assume policy

Here's my assume role policy document:
Am I missing something ?
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Federated": "arn:aws:iam::<account_id>:oidc-provider/oidc.eks.eu-central-1.amazonaws.com/id/3D3B84B370338EB5B8A6728992E7930F"
      },
      "Action": "sts:AssumeRoleWithWebIdentity",
      "Condition": {
        "StringLike": {
          "oidc.eks.eu-central-1.amazonaws.com/id/3D3B84B370338EB5B8A6728992E7930F:sub": "system:serviceaccount:default:*"
        }
      }
    }
  ]
}```

Here's my assume role policy document:
Am I missing something ?
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Federated": "arn:aws:iam::<account_id>:oidc-provider/oidc.eks.eu-central-1.amazonaws.com/id/3D3B84B370338EB5B8A6728992E7930F"
      },
      "Action": "sts:AssumeRoleWithWebIdentity",
      "Condition": {
        "StringLike": {
          "oidc.eks.eu-central-1.amazonaws.com/id/3D3B84B370338EB5B8A6728992E7930F:sub": "system:serviceaccount:default:*"
        }
      }
    }
  ]
}```

I am using terraform to create the iam policy, this is what I have:
data aws_iam_policy_document external-secrets_read_sc_document {
  statement {
    sid    = "ExternalSecretsRead"
    effect = "Allow"

    actions = [
      "secretsmanager:GetSecretValue",
      "secretsmanager:ListSecrets",
      "secretsmanager:ListSecretVersionIds",
      "secretsmanager:GetResourcePolicy",
      "secretsmanager:DescribeSecret",
    ]

    resources = ["*"]
  }

  statement {
    sid = "externalSecrestAssume"
    effect = "Allow"
    actions = [
      "sts:AssumeRole",
    ]
    resources = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/external-secrets-sc-role*"]
  }
}

I am using terraform to create the iam policy, this is what I have:
data aws_iam_policy_document external-secrets_read_sc_document {
  statement {
    sid    = "ExternalSecretsRead"
    effect = "Allow"

    actions = [
      "secretsmanager:GetSecretValue",
      "secretsmanager:ListSecrets",
      "secretsmanager:ListSecretVersionIds",
      "secretsmanager:GetResourcePolicy",
      "secretsmanager:DescribeSecret",
    ]

    resources = ["*"]
  }

  statement {
    sid = "externalSecrestAssume"
    effect = "Allow"
    actions = [
      "sts:AssumeRole",
    ]
    resources = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/external-secrets-sc-role*"]
  }
}

@c4m4 the shared IAM policy is for the iam_role inside ExternalSecrets in the roleArn ?

@c4m4 the shared IAM policy is for the iam_role inside ExternalSecrets in the roleArn ?

@jihed yes, I attached the sts policy to the role

@jihed yes, I attached the sts policy to the role

I work with @jihed.
The problem comes from a timeout due to the SDK unable to reach the private endpoints. We run it in a private environment and there is no internet connection. We do have all the endpoints required (sts, ssm and secretsmanager) they are reachable from inside the container with the correct IP.
I also tried to set directly the enpoint via the option:
env:
          LOCALSTACK: 1
          LOCALSTACK_SM_URL: https://secretsmanager.eu-central-1.amazonaws.com
          LOCALSTACK_SSM_URL: https://ssm.eu-central-1.amazonaws.com
          LOCALSTACK_STS_URL: https://sts.eu-central-1.amazonaws.com

however without success, any idea ?

I work with @jihed.
The problem comes from a timeout due to the SDK unable to reach the private endpoints. We run it in a private environment and there is no internet connection. We do have all the endpoints required (sts, ssm and secretsmanager) they are reachable from inside the container with the correct IP.
I also tried to set directly the enpoint via the option:
env:
          LOCALSTACK: 1
          LOCALSTACK_SM_URL: https://secretsmanager.eu-central-1.amazonaws.com
          LOCALSTACK_SSM_URL: https://ssm.eu-central-1.amazonaws.com
          LOCALSTACK_STS_URL: https://sts.eu-central-1.amazonaws.com

however without success, any idea ?

@markthebault No ideas but to my understanding it should be possible to get it working looking at earlier issues #232 and #348.
Not sure if you need to set the localstack config to get it working, I don't think so but I suppose it works as an override if you want to force specific endpoints even if its meant for local testing only :)

@markthebault No ideas but to my understanding it should be possible to get it working looking at earlier issues #232 and #348.
Not sure if you need to set the localstack config to get it working, I don't think so but I suppose it works as an override if you want to force specific endpoints even if its meant for local testing only :)

@markthebault Looking at #567 and #601
From #567

We use AWS EKS behind HTTP Proxy and use the IRSA feature with AWS Secrets Manager. Since there is no OIDC endpoint available as VPC endpoint, we need to pass a proxy configuration to get a valid session token. (..)

This seems related to the issues you are seeing?

@markthebault Looking at #567 and #601
From #567

We use AWS EKS behind HTTP Proxy and use the IRSA feature with AWS Secrets Manager. Since there is no OIDC endpoint available as VPC endpoint, we need to pass a proxy configuration to get a valid session token. (..)

This seems related to the issues you are seeing?

From EKS 1.19, SecurityContext is not required anymore.

see detail: https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-technical-overview.html

i think this isn't relevant anymore, closing it.


creatibutors modal: add support suggestion and autofill

[ ] Add a top level search field,

[ ] Display suggestions

[ ] Autofill the form when one of the suggestions is chosen

ld

[ ] Make modal collapsable

Comments regarding the implementation done in zenodo/react-invenio-deposit: Avoid using createRef for affiliations and identifiers. Instead use local component state + formik state + passing handlers as prop.

Closed via #410


Build zenithdb/zenith:latest in CI (zenithdb/console#125)

It works now, but I wasn't able to make it complete faster than 20m even with usage of pre-built image with postgres and rust dependencies installed. I've also did it with and without cargo-chief.
For some reason Docker doesn't use cached layers for postgres and rust deps for repetitive builds, when nothing has changed in vendor/postgres and Cargo.*

For some reason Docker doesn't use cached layers for postgres and rust deps for repetitive builds, when nothing has changed in vendor/postgres and Cargo.*

I think something is created in this directories during build that changes directory checksum and forces rebuild. I use special docker image to list all files that are copied to debug same behavior. I'll take a look

The last build finished in 4 minutes. Probably I've changed something in the zenithdb/build:buster and pushed it to the Docker Hub, which triggered all layers rebuilding on the next run. So it seems that you have to just forget about it, @kelvich :) Sorry, my bad

It seems that caching works fine. I've also added docs, so I'm going to merge this if there are objections


Traffic Portal: Can't add a new server (Key (status)=(1) is not present)

There is assumption in the code that the OFFLINE status is ID=1. In my lab database, there is no ID=1 and you can't create a server (status is empty, error 500 occurs)
https://github.com/apache/incubator-trafficcontrol/blob/d6c690f87200a2f9a26e7dbb136c85ff34ee005b/traffic_portal/app/src/modules/private/servers/new/index.js#L33

Verified on my CDN with this condition happening. Can now create a server using Traffic Portal.


es7 decorators error

I have installed using npm, and the decorator code throws an error running through babel 5.8:
Uncaught TypeError: (0 , _baobabReactDecorators2.default) is not a function
The code of the in node_modules is es5, and looks something like:
function root(tree) {
return function (Component) {
return (0, _higherOrderJs.root)(Component, tree);
};
}
So, the error makes sense. Is it my version of babel - or maybe the code that is output to node_modules?

Looks like the issue is in the browserify compile. It should look like this:
var _higherOrderJs = require('./higher-order.js');
function root(tree) {
return function (Component) {
return _higherOrderJs.root(Component, tree);
};
}

Hello @tonypee. Which baobab-react version are you using? I am using the latest one and never had a single issue with it. Is the code you are working on Open Source per chance so I can help you better?

Its<EMAIL_ADDRESS>I am using webkit for my build. Maybe thats it. Webkit cant build this code:
var test = function() { console.log('test') }
(0, test)()
Are you using browserify?

scratch that - it just needs a semicolon on the 1st line. I can get it to work using:
var branch from 'baobab-react/decorators').branch;
but when i try the es6 module format:
import branch from 'baobab-react/decorators';
it errors:
Uncaught TypeError: (0 , _baobabReactDecorators2.default) is not a function. Ill explore more if this is an issue with babel.

@tonypee  Shouldn't you import with "import {branch} from 'baobab-react/decorators'; ?

yup - sorry, this was back when i was just starting with es ;) my bad


nixos/doc/md-to-db.sh: handle path to nixpkgs with spaces

Motivation for this change
Without this change, the script will fail if the path to nixpkgs contains a space.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This change still wouldn't make paths with spaces work
There are too instances of
mkdir -p $(dirname "$OUT/$mf")

they needs to be changed to
mkdir -p "$(dirname "$OUT/$mf")"

to avoid splitting

You're right. Thanks for noticing. To be fair though, in my testing it did totally work without this change, the script just created a new empty directory outside of nixpkgs where it shouldn't have.


Correctly mount secrets

According to the Dockerfile reference for RUN --mount=type=secret, the parameter specifying the destination is supposed to be target, not dst

Feel free to merge when you are comfortable.  The only real rule around here: keep the tests passing.

I'm going ahead and merging, but in the future feel free to merge changes yourself.  Welcome aboard!

@rubys Thanks for merging! I'll keep that in mind for the next time.


Who can coding for me in python. only login, and trade. buy put call 5 ticks

Who can code in python for me,
login, and trade put call 5ticks.
Call> when ticks is Rising
Put > when tick is Falling

я


User guidance

Add a User manual to help the user understand the steps to follow to use the program.

@johri002 I want to pick this one .


Specifying an absolute path to a script breaks

When you specify an absolute path to a script on the filesystem you need to run, it currently breaks since we append an additional / to the command (./"path").
When we make this change, we should introduce a new flag "--only-repo-scripts" - which will disallow running scripts that don't exist in the repo.

Prepending the script that you want to run with sh
So that:
    command: "/absolute/path/to/script.sh"
Becomes:
    command: "sh /absolute/path/to/script.sh"


Bump to 0.20130412.17

This change is

@bors-servo r+

:pushpin: Commit 9f42981 has been approved by nox

:hourglass: Testing commit 9f42981 with merge d977ae0...

:sunny: Test successful - status-travis


[feature] Provide an option to disable fail-fast behavior and process as much of the task graph as possible

Thanks for your great project.   I'd like to learn to rust, so if any of the issues I've submitted could be good beginner tasks, let me know. I was halfway to fixing the powershell bug when you submitted your PR 😄
Is your feature request related to a problem? Please describe.

  Moon is very close to being a complete replacement for pre-commit, which would give me a single source of truth and a more elegant solution, but it's missing a few features.
Here are the required features (check boxes indicate whether moon satisfies the requirement):

[x] Install necessary toolchains to run tasks
[x] Specify file patterns for when to trigger a task (solved with inputs)
[x] Operate on staged files (solved with --affected --status=staged)
[x] Pass modified input files to the task  (solved with affectedFiles)
[x] * Return non-zero on failure of any task
[x] * Ability to process all tasks even if one fails   (solved with allowFailure)
[ ] stash outstanding changes before running tasks, then restore the stash on completion

* Tasks with an asterisk are not fully satisfied by moon, because we can't get both of these features at the same time.  See below.
That's really close!
As far as I can tell, moon immediately aborts all queued and unqueued tasks as soon as a failure is encountered (so long as the failed task does not have allowFailure = true).  For certain cases, like linting, failing fast is not desirable.  I would like an option to continue processing every task that does not have a failure in its upstream dependents.
For example, consider a repo with two projects -- foo and bar -- with a set of global tasks like this:
tasks:
  will_fail:
    command: 'false'
    options:
      cache: false

  will_succeed:
    command: 'true'
    options:
      cache: false

  lint:
    deps: [will_fail, will_succeed]
    command: "echo 'lint complete'"

When running moon run :lint I would like all will_fail and will_succeed tasks to run.  This is safe because they are not dependent on each other. The foo:lint and foo:bar tasks would not run their commands because they have failures in their deps (foo:will_fail and bar:will_fail respectively), so they are not safe to run.
This behavior is particularly desirable for lint tasks, where a developer wants to perform or get feedback on a number of (usually unrelated) tasks as aggressively as possible.   I don't want all of my check_yaml tasks to abort just because one of my check_python tasks fail:  I want to know all the failures up front so that I can address all the issues together.
Instead, what currently happens is that tasks are aborted as soon as the first failure is detected, so I have to fix, rerun, and repeat to progressively expose issues, which is a waste of time.
Describe alternatives you've considered
The closest that I can get to the desired behavior is to set allowFailure = true for my lint tasks.
tasks:
  fails:
    command: 'false'
    options:
      cache: false
      allowFailure: true

  succeeds:
    command: 'true'
    options:
      cache: false
      allowFailure: true

There are two problems with this:

I can no longer group these tasks together under another task, because tasks with allowFailure = true are not allowed to be depended upon.   This means that users need to provide the full list of lint tasks when calling moon run, or I need to create a wrapper script to do this for them.
If a task with allowFailure = true fails, moon run will still exit 0.  Thus, when used as a precommit hook, it will not stop git commit from proceeding.  This makes it completely ineffective as a precommit solution.

Describe the solution you'd like
Option 1:  global control over fail-fast behavior
One solution is a global option to disable the default fail-fast behavior.  pre-commit provides control over this behavior with a global option called fail_fast.  It defaults to false.
Unlike the task-level allowFailure option, moon run should still return 1 if a task fails with failFast = false.
This global option could be a CLI flag for moon run or an option in .moon/workspace.yml.
Option 2:  Add a task-level option to control failure propagation
A finer-grained solution could be to add an option to control the scope of failure propagation.
Possible semantics:

abortTasksOnFailure = "all", "downstream", or "none". Defaults to "all".
failurePropagationScope = "global", "project", "downstream", "none".  Defaults to "global".

"none" is equivalent to  allowFailure=true.  Only "none" would cause moon run to exit 0 on task failure.
Setting this in taskOptions within .moon/tasks.yml would have the effect of globally disabling the fail-fast behavior:
taskOptions:
  abortTasksOnFailure:  downstream

If a task with abortTasksOnFailure = all fails it should not abort a task with abortTasksOnFailure = downstream.

Additional context

We actually support this "fail immediately, or fail at the end" functionality already, but it's internal only right now. It's how moon run (immediate) and moon ci (end) work, even though the share the same code.
I can bubble this functionality up to a CLI flag so it can be toggled on and off.

Thanks for the quick response!

I can bubble this functionality up to a CLI flag so it can be toggled on and off.

That would be great.  I looked a little bit at running moon ci for my pre-commit hook, but it's missing --affected and --statusoptions.  In general, I like the idea ofmoon runbeing the all-purpose entry-point while other entry-points likemoon ci` are shortcuts for a particular configuration.

One other thing to note:  unlike moon ci the --summary option for moon run does not display if any tasks fail.  I guess this is a side effect of its "fail immediately" strategy.

One other thing to note: unlike moon ci, the --summary option for moon run does not display if any tasks fail. I guess this is a side effect of its "fail immediately" strategy.

Yeah, pretty sure it is. Will work correctly when everything runs.

Ok, I see what I need to change, so I'll submit a PR for this.
Do you have any thoughts on naming?    I see there's a general desire for one-word CLI flags, because there's an intent to move to kebab_case in 2.0.
Some options:

--noFailFast
--eager
--onFailure <FAIL_ACTION>  (valid modes:  "abort", "continue")
--abort <MODE> (valid modes:  "early", "late")

Instead of aborting immediately, execute as many tasks as safely possible.  Tasks with upstream failures will be automatically failed.


Error uploading filesets (SDF)

Hi,
I experience some issues with uploading molecular files (SDF).  I tested different files, but only a part of the content is used to calculate NP-scores.
6000 compounds → 45 NP-scores (performed on locally hosted website)
180 compound → 119 NP-scores visible (performed on naples.naturalproducts.net)
14 compound → 1 NP-score visible (performed on naples.naturalproducts.net)
4 compounds → 3 NP scores visible  (performed on naples.naturalproducts.net)
The files are created all in the same manner using DataWorrior.

Indeed, there is some filtering that is made in the NP-likeness scorer that can filter molecules out at different steps:

the SDF file doesn't contain correct molecular structures or some of them are not recognized as correct by the CDK SDF reader
molecules are too small (less than 5 heavy atoms) or contain forbidden elements
molecules are pure sugars - those are removed according to the original publication of the NP-likeness scorer, but there is a way to not do this, that is also implemented in the code
molecular structures without the sugars are too small (less than 5 heavy atoms)

I can help with the identification of the problem if you provide me with the molecules that worked and didn't work

In the attachment there is test-file with 14 related molecules. Only 1 worked.
Would be great to know what I do wrong =) .
Naples test set [14].zip

Did you had a change to look at the dataset?
I would really like some feedback so I can use the calculator for my research.
Thanks!

Hi, sorry about this, with the current situation I had a lot on my plate and totally forgot to answer.
I checked the file you provided me, and in there, indeed, only one molecule is read by the scorer. This comes from the exact format of the SDF file that you are using that is not recognized by the SDFreader from the CDK, as it is not canonical.
What are you using to generate the SDF file? Can you use instead of it a SMILES file?

I used ChemDraw to draw the scaffold and DataWarrior for enummeration and to generate the SDF file.  I believe this is the extended SDF file  (V3000), but I am not an expert.
I loaded this files back into ChemDraw and saved as "standard"  SDF and also as Mol file. Unfortunatly these still didn't work..
However, the "standard" SDF I could convert into a SMILES file via a online converter (https://cactus.nci.nih.gov/translate/). This file was worked well with the calculator.
Do you have any suggestions on how to generate SMILES files more straightforward. (I am a bit afraid of how ChemDraw is going to react when I am going to load 10k structures at once..)
Thanks!

I don't know DataWarrior, the format problem might come from here. Extended SDF files, if they are canonical are also accepted, so the problem comes from the non-canonicity of the generated SDF.
To translate SDF to SMILES I generally use OpenBabel (https://openbabel.org/docs/dev/Command-line_tools/babel.html)
Hope this helps!

Thanks. I will check it out.
I just tried loading 6k structures in ChemDraw. Was not a succes..


Upgrade to SPIRE 1.1.3

Signed-off-by: Mariusz Sabath<EMAIL_ADDRESS>

This PR removes the support for SPIRE lower than 1.1.0. Anything below that level will not compile.


Fixed issues in the outpainting with titan

Issue #, if available:
1- 'image_4_b64_str' variable does not exist, 'image_5_b64_str' should be used instead
2- 'black' and 'white' are inverted in the outpainting mask. As a result, the image created by titan is wrong
Description of changes:
1- use 'image_5_b64_str' instead of 'image_4_b64_str'
2- swap 'black' and 'white'
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

duplicate and will be fixed by #169


Rich text?

Is there any way to be able to paste rich text with the default settings? It'd be a really nice feature

use slate with react-datasheet is fun.


Support for reading and writing EXIF to file stream

Hey @Sobesednik
Thank you for the great repo! Would be awesome if you could also read and write EXIF to a file stream. Any plans for something like this?
var remoteURL = 'https://nodejs.org/static/images/logos/nodejs-new-pantone-black.png'
var upstreamServer = 'http://someupstreamserver/uploads'

request
  .get(remoteURL)
  .pipe(
      // TODO read EXIF
      // TODO write missing EXIF
      request
        .post(upstreamServer, function(err, httpResponse, body){
          res.send(201)
      })
  )

@tomchomiak hi thanks for the request, it is something we have looked at before, but didn't get time to address it. Will let you know when it's possible.

you might wanna try https://github.com/kapouer/node-streat

@Sobesednik Thank you so much!

@tomchomiak you can read from a file now
https://github.com/Sobesednik/node-exiftool#reading-metadata-from-a-stream
I will add stream writing in future because I think it's an awesome idea 👍

Any update on this?
I can submit a PR

@Sobesednik Thanks for your great work here!
It would definitely be useful to have the stream writing capability. Any word on when that feature may happen? Thanks!

I have an app whose only purpose is to download JPEGs to then upload them elsewhere with additional EXIF tags.
Writing EXIF as a transform stream would really be nice!


Why is docker volume create and rm not symmetrical?

I asked this question here first to make sure that I was not missing something obvious:
http://stackoverflow.com/questions/37684393/why-is-docker-volume-create-and-rm-not-symmetrical

hindsight
volumes don't require a name as one will be generated if not provided.

See https://github.com/docker/docker/issues/17194 and https://github.com/docker/docker/issues/18982

I think I think docker would be more user friendly if the --name flag is dropped from, or just made optional, WRT docker volume create.
So we could do:
docker volume create v1 or docker volume create --name v1.

Most other docker commands don't use the --name parameter:
Example
$ docker stop test_sshd
$ docker rm test_sshd
$ docker rmi eg_sshd

Again, this is because name is not required when creating a volume (much like docker run).
I'm not saying I don't like it, but have to be very careful about changing the CLI.

OK I see what you are saying - this actually works:
ole@MKI:~$ docker volume create
b11725085cf9614ceba0cf0304eec46219bc41e7df42a82e8311c3d3dd7e4330

ole@MKI:~$ docker volume rm b11725085cf9614ceba0cf0304eec46219bc41e7df42a82e8311c3d3dd7e4330
b11725085cf9614ceba0cf0304eec46219bc41e7df42a82e8311c3d3dd7e4330

But I don't think that doing:
ole@MKI:~$ docker volume create v1
docker: "volume create" requires 0 arguments.
See 'docker volume create --help'.

Usage:	docker volume create [OPTIONS]

Create a volume

Conflicts with that.  Even though the command line says it does.

Also the --name option can be kept for backward compatibility, while allowing docker volume create thenameofthevolume.

👍 Are you interested in handling this?
It should be much easier to do now since we've changed to a new CLI backend and can simply mark --name as hidden, then check for both --name being set and the name argument being set.

I could give it a shot, although I've never written any go (Mostly java / javascript, etc).  Could you point me to the code.

https://github.com/docker/docker/blob/master/api/client/volume/create.go

If you get stuck I'd like to give it a shot.

I'm through the code, but it's my first go read, so feel free.  I'm sure I'll learn a lot from seeing how it's done.

In that case I'd like to pick this up and take a shot at it since it doesn't look too hard.

Just realized that docker image rm does not work either ... It would be nice if all commands used the same convention.

Just sharing some more ideas:
docker image create image_name
docker image rm image_name
Thoughts?

@oleersoy see https://github.com/docker/docker/issues/8829

@thaJeztah perfect - thanks for pointing that out.

"It should be much easier to do now since we've changed to a new CLI backend and can simply mark --name as hidden, then check for both --name being set and the name argument being set."

@cpuguy83 I couldn't find any way to mark the flag as hidden; would appreciate some guidance if it is possible.

@ardnaxelarak
flags.Lookup("name").Hidden = true

Let me know if I can be of any more help

@dnephin Thanks, wasn't immediately obvious to me in godoc but I knew I had seen it.


Not able to set Microsoft Graph permissions

I created a new Azure subscription (free) and under the Default directory registered a new Cloud Service ASP.Net MVC Web Application. I also added a new user to the default domain. When I run the application everything works in the application connected with this Azure AD.
Now when I try to set permissions for Microsoft Graph I see no permissions there. And thats why my User.IsInRole and IsAuthenticated doesn't work.
Can you help ?

Is the user an AzureAD administrator (in Azure Active directory, choose a user, and go to "Directory Role")

Yes, both the users are Global Administrators.
User 1<EMAIL_ADDRESS>- this created the free subscription
User 2<EMAIL_ADDRESS>- added by User 1

I has a similar problem. I managed to have the "Microsoft Graph" service principal added to my subscription by navigating to the graph explorer (https://developer.microsoft.com/en-us/graph/graph-explorer), signing-in as one of the administrator and accepting the consent to access the graph.
HTH

This sometimes happen due to transient issues. If this issue still persists, please reopen this issue.


Feature/interactive player project setup

Description:
Added new swift package for DolbyIORTSCore and DolbyIORTSUIKit
Adds new app for Interactive Viewer
Pending:
Unit testing and CI/CD for the targets will be added as part of the next PR

Is it possible to apply the change from this PR? https://github.com/dolbyio-samples/rts-app-ios-viewer/pull/100

Is it possible to apply the change from this PR? #100

Done @CasperMok - add a new commit to address that cleanup


Refactoring metrics in RestServer

Just refactoring - no new functionality
Built and tested.

@pnarayanan Addressed comments and pushed some changes that had been left out of the last commit (w.r.t tests)


docker-compose: Update API URL on the Frontend's process

The frontend goes through the host to access the API (browser is in
the host machine).

Coverage remained the same at 72.942% when pulling 12f5fa3b37e0986ab2674dad68ba13fe422ab075 on quick-docker-compose-fix into be073f6af9b8d6ce145dff5d402bbc79a4485142 on master.


Obtain a DOI for RK-Opt via Zenodo

To cite RK-Opt, it might be nice to have a DOI from https://zenodo.org/. If you want, I can set up a .zenodo.json file.

For example, the journal of open source software requires a DOI, e.g. via Zenodo, see https://joss.readthedocs.io/en/latest/submitting.html#the-review-process.

I have flipped on Zenodo integration for both RK-Opt and NodePy, so when we do a new release we'll get a DOI.  I didn't see anything about the .json file, so if you know what to do about that please go ahead.

I've submitted a PR to nodepy and can do the same for RK-Opt. However, I will need the list (and order) of authors for that.


Generalized Relational Conv layer and tests

Proposed changes
GeneralizedRelationalConv layer from the NBFNet paper. Adopted from the NBFNet-PyG repo with the mlx-graphs framework.
As a weekend project, I re-implemented the whole NBFNet training/evaluation KG completion pipeline with MLX and MLX-graphs and reproduced (in the ballpark) most of the reported numbers, will publish the repo soon.
This layer implements a relational message passing layer (not R-GCN) where edges have discrete edge types and each layer learns its own relation embeddings matrix.
Originally, NBFNet works with 3D tensors of shape [batch_size, num_nodes, dim] where message passing is done separately for each item in the batch. In this version, I added support for both 3D and 2D ([num_nodes, dim]) inputs for compatibility reasons.
Available interaction functions in the message function:

addition (transe)
multiplication (distmult)
complex rotation (rotation)

Some features:

added a PNA aggregation - subject to scatter inefficiencies, but tests pass.
replaced mlx.nn.Linear with mlx_graphs.nn.Linear thanks to @TristanBilot when reproducing experimental numbers

Checklist
Put an x in the boxes that apply.

[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have updated the necessary documentation  <- Please point me where to add mode docs, I added quite some comments to the layer

Amazing! Thanks for your PR @migalkin. Just added one comment in addition to @francescofarina's reviews. It would be nice to also have your dataset in the lib, do you consider opening another PR?

Yes, the dataset PR is the next


Keep making API more ergonomic

Codecov Report

Merging #31 (8b0ae14) into main (ff10160) will increase coverage by 0.12%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   84.98%   85.10%   +0.12%
==========================================
  Files          15       15
  Lines        2138     2149      +11
==========================================
+ Hits         1817     1829      +12
+ Misses        321      320       -1

Impacted Files
Coverage Δ

src/buffet/piece.rs
68.75% <57.14%> (-1.07%)
:arrow_down:

src/h1/parse.rs
95.12% <100.00%> (+0.20%)
:arrow_up:

src/types/headers.rs
94.44% <100.00%> (ø)

src/types/mod.rs
42.10% <100.00%> (ø)

src/h1/body.rs
87.17% <0.00%> (ø)

src/buffet/roll.rs
86.17% <0.00%> (+0.49%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


BGP ASpath for Junos returns "field required" error

The commands sent to router looks good:
"show route protocol bgp table inet.0 aspath-regex ".* ASnum" detail | display xml"
The XML output is returned from the router, but on the GUI the "field required" is shown. No other error is generated by hyperglass.
Tested JunOS version - 18.4R3

This should be fixed in 1.0.0-beta.50 - release published just a few minutes ago. Can you update and test again, please?
Thanks,
Matt

After upgrade to beta.50 no change. However I noticed the same problem with BGP route query. If the route is not found in the table the output is The query completed, but no matching results were found. But when the route exists field required is given back. RPC output looks good for all commands.
Maybe I have to try with fresh install - not upgrade?

Is the XML output something you can share? I’m wondering if there’s something unique about one of the routes that requires an adjustment in the parser. If needed you can email it to<EMAIL_ADDRESS>

Thanks for sending the XML - that helped me narrow this down. Looks like it was because the route had no communities at all, and Junos left the communities key out of the response entirely. This should be fixed in 1.0.0-beta.51, but let me know if not.
Thanks!


Volume viewport voi synchronization

Volume viewport voi synchronization works only on viewports that share same volume. Shouldn't it be more open to how it works?
In voiSyncCallback.ts in tViewport.setProperties for Volume Viewport there is specified volumeId  which cause synchronization to work only on viewports with same volume as source viewport volume.

I'm not following what your issue is. You want to synchronize any viewport with any other viewport? like a CT with PT?

Exactly


[BACKLOG-39672] [PDI-20025] Updated the code to resolve the

httpMethod name from values defined in system properties before using it

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 28m 58s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/rest/core

:ok_hand: All tests passed!
Tests run: 31, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


Update FHIRRouter Azure Events to Store messageID

User Story

As a ReportStream developer troubleshooting issues,
I want to see the messageID alongside the reportID,
so I can more easily find the reports I am looking for
Description/Use Case

Update ReportAcceptedEvent and ReportRoutedEvent to include the messageID alongside the reportID and other info.
Risks/Impacts/Considerations

Dev Notes

Acceptance Criteria

[ ] ReportAcceptedEvent and ReportRoutedEvent both include messageID

Please add your planning poker estimate with Zenhub @david-navapbc

Please add your planning poker estimate with Zenhub @JFisk42

Please add your planning poker estimate with Zenhub @jack-h-wang

@arnejduranovic this is blocked on mapping this page: https://docs.google.com/spreadsheets/d/1oOy6JW4Mv5VL8DsoA05bYZCUa1JqP4GCYNPF5GJTLxQ/edit#gid=0
Arnej to create a ticket

Splitting off a new ticket for the enhancement to generate a uuid for fhir bundles that come in without an identifier.
Formerly this was included in the AC "FHIR spec says bundle.identifier is optional, create new one with generated UUID if missing via sender transform in convert step. This will give us enough info to link a message a receiver sends back to us to the original report submitted by sender."

Logged ticket for the split off AC: https://app.zenhub.com/workspaces/platform-6182b02547c1130010f459db/issues/gh/cdcgov/prime-reportstream/14532


game crash on 1.5.1

Cause: Not sure, but I was in an LTS match, and as soon as the next game started it crashed the client
nslog2022-02-21 00-38-14.zip

Kinda hard to reproduce this bug without knowing what might have caused it. That and considering that v1.5.1 has since been obsoleted I'm just gonna close the issue for being stale. If it happens again on a current version please re-open or make a new issue referencing this one.


Installation is stuck on Creating the database tables

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
2.2.1
Issue Description
After providing database info in the web installer the installer stucks in this step for ever without any change in the database.
Preconditions
Shared hosting
Steps to reproduce
Follow web installer to the step of database table creating
Expected Result
Database tables get created
Actual Result
No tables was created and the installer stucks
Screenshots

Additional context
No response

Changed database host from <IP_ADDRESS> to localhost and it worked


Error: Invariant failed: Hash history needs a DOM

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!
https://stackoverflow.com/questions/tagged/react-router
https://www.reactiflux.com/
First, apologize for my poor english, wish you can understand...
Hi, i have tried search in stackoverflow, but not found solution...
the error shows here:
ERROR in   Error: webpack-internal:///./node_modules/tiny-invariant/dist/tiny-invariant.esm.js:14
    throw new Error(prefix + ": " + (message || ''));
    ^
  Error: Invariant failed: Hash history needs a DOM

  - tiny-invariant.esm.js:14 invariant
    [.]/[tiny-invariant]/dist/tiny-invariant.esm.js:14:9

  - history.js:577 createHashHistory
    [.]/[history]/cjs/history.js:577:16

  - index.js:36 _default
    [.]/[dva]/lib/index.js:36:64

  - index.js:32 eval
    webpack-internal:///./src/index.js:32:53

  - index.html:7396 Module../src/index.js
    /Users/mac/Desktop/workspace/test/reproduce/code-reproduce/src/index.html:7396:1

  - index.html:21 __webpack_require__
    /Users/mac/Desktop/workspace/test/reproduce/code-reproduce/src/index.html:21:30

  - index.html:3 eval
    [.]/[html-webpack-plugin]/lib/loader.js!./src/index.html:3:34

  - index.html:5904 Object../node_modules/html-webpack-plugin/lib/loader.js!./src/index.html
    /Users/mac/Desktop/workspace/test/reproduce/code-reproduce/src/index.html:5904:1

  - index.html:21 __webpack_require__
    /Users/mac/Desktop/workspace/test/reproduce/code-reproduce/src/index.html:21:30

  - index.html:85
    /Users/mac/Desktop/workspace/test/reproduce/code-reproduce/src/index.html:85:18

Theoretically, project run in my local server, it should has dom.
This is my minimum reproducible repository address:
https://github.com/shauvet/code-reproduce/tree/dva-admin

Finally, i added in the webpackHtmlPlugin：
new HtmlWebpackPlugin({
      // filename: 'index.html',
      template: 'src/index.html',
      inject: 'body'  // here
})

And the error gone.


Questions about spdm_authentication()

https://github.com/DMTF/spdm-emu/blob/fca95c2de76720e5c8085966bc77fcab1f8604a7/spdm_emu/spdm_requester_emu/spdm_requester_authentication.c#L84-L108
Hi,
I am not pretty sure but these lines seem to verify the recent changes of allowing GET_DIGESTS/GET_CERTIFICATE after CHALLENGE.
Would you help take them out if they are not supposed to be part of a typical authentication procedure?
Thanks!

This is example to cover some case that digest get after authenticate. I dont think we should take them out.


Use browser/model/helpers/hash.js in gulp common.js tasks

test this

Codecov Report

Merging #1049 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   93.35%   93.18%   -0.17%
==========================================
  Files          39       39
  Lines        4185     4228      +43
  Branches      463      726     +263
==========================================
+ Hits         3907     3940      +33
+ Misses        278      267      -11
- Partials        0       21      +21

Impacted Files
Coverage Δ

browser/pages/confirm/controller.js
61.41% <0%> (-6.8%)
:arrow_down:

browser/model/devstudio-autoinstall.js
97.29% <0%> (-2.71%)
:arrow_down:

browser/model/helpers/hash.js
85.29% <0%> (-2.59%)
:arrow_down:

browser/main.js
95.58% <0%> (-1.39%)
:arrow_down:

browser/pages/account/controller.js
82.11% <0%> (-1.33%)
:arrow_down:

browser/pages/location/controller.js
92.5% <0%> (-1.25%)
:arrow_down:

browser/model/helpers/downloader.js
96.36% <0%> (-1.22%)
:arrow_down:

browser/model/installable-item.js
96.34% <0%> (-0.83%)
:arrow_down:

browser/model/jbossfusekaraf.js
95.09% <0%> (-0.83%)
:arrow_down:

browser/model/jbossfuse.js
99.23% <0%> (-0.77%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1796b4f...dd4604f. Read the comment docs.


[FEATURE] added google-auth

Related Issue

Added a feature for users to login with their google account

Closes: #33
Describe the changes you've made

Added social-auth setup in settings.py
Registered templates
Added index.html to use login/logout feature

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

@diyajaiswal11

@Aditya201551 can you plz add screenshots.

as I am getting an error on http://<IP_ADDRESS>:8000/accounts/google/login/ this route.

@harsh-9in I have made all the changes but I forgot that db.sqlite3 has been added to .gitignore so I will update this db file and then add it to this pr you will get the update commit within an hr and remaining all the changes done to the project will remain the same. Thank You

@harsh-9in i have updated the branch with required changes

@harsh-9in  great thanks!


Create mesos installation docs

Create 3 new docs to install calico-mesos:

Create and Install the Calico-Mesos RPM
Manual Install Calico
Create and Install Mesos + Net-Modules RPM

LGTM.  A few minor corrections which should get fixed before merge.
I'd like to see "download & install" the dominant paradigm rather than "build & install", but those fixes don't need to block the merge.  We can iterate here.

@spikecurtis We'll have to discuss whether we want to host the mesos/net-modules RPMs on the calico-mesos repo, the net-modules repo, or somewhere else. These changes can be addressed later in the week or next week and, to reiterate, do not need to block this merge.


Add git to runtime closure

Many of my nix builds seem to be failing with:
Dec 10 13:19:07 ivanm-dfinity-razer lorri[1797]:             "error: executing \'git\': No such file or directory",
Dec 10 13:19:07 ivanm-dfinity-razer lorri[1797]:             "error: program \'git\' failed with exit code 1",
Dec 10 13:19:07 ivanm-dfinity-razer lorri[1797]:             "(use \'--show-trace\' to show detailed location information)",

I haven't looked in to it too deeply, but my guess is that this has something to do with the way the runtime-closure is set up. I'm assuming that what I need to do is add git to the paths that are set as part of the "lorri-runtime-tools", but I'm wondering why this isn't done by default.

Even if this isn't done by default, it seems like runtime.nix should provide an easy way to add additional things that may be needed as runtime dependencies by lorri.

Hi @IvanMalison, would you be able to share an (ideally minimal) repro shell.nix?

My guess at the cause of this issue was incorrect. This actually has to do with the way the systemd unit is configured in nixpkgs, where the path is explicitly set to:
https://github.com/nixos/nixpkgs/blob/6b73d29775213361370f003fa4476bcf94572c28/nixos/modules/services/development/lorri.nix#L35
      path = with pkgs; [ config.nix.package gnutar gzip ];

on my machine, this yields:
Environment="PATH=/nix/store/sm740vh74gh7r8ww6q3wf067xkq1nb64-nix-2.3.1/bin:/nix/store/gpd7dd7i1jqcwr1wiszcxypjqk61nimc-gnutar-1.32/bin:/nix/store/xn2bim352zk1xv0s8vzqg6zc1znj7nl0-gzip-1.10/bin:/nix/store/j0lhk5xkky410h5v9af98sz6kd8cbp40-coreutils-8.31/bin:/nix/store/kmc865qs56czqk5k5vr0nj4zvfijlq7n-findutils-4.7.0/bin:/nix/store/20b535jb98hy7k4z8vkrlkjma212a3l5-gnugrep-3.3/bin:/nix/store/dv52knazq6pb1zv9pazzj666zg550zni-gnused-4.7/bin:/nix/store/qjnhav18gi6ry63cbkni4fh36kq13v32-systemd-243/bin:/nix/store/sm740vh74gh7r8ww6q3wf067xkq1nb64-nix-2.3.1/sbin:/nix/store/gpd7dd7i1jqcwr1wiszcxypjqk61nimc-gnutar-1.32/sbin:/nix/store/xn2bim352zk1xv0s8vzqg6zc1znj7nl0-gzip-1.10/sbin:/nix/store/j0lhk5xkky410h5v9af98sz6kd8cbp40-coreutils-8.31/sbin:/nix/store/kmc865qs56czqk5k5vr0nj4zvfijlq7n-findutils-4.7.0/sbin:/nix/store/20b535jb98hy7k4z8vkrlkjma212a3l5-gnugrep-3.3/sbin:/nix/store/dv52knazq6pb1zv9pazzj666zg550zni-gnused-4.7/sbin:/nix/store/qjnhav18gi6ry63cbkni4fh36kq13v32-systemd-243/sbin"

and so it is no wonder that git is not accessible from lorri.
It looks like you @curiousleo are responsible for this configuration, so I'm wondering why lorri needs to be set up with an explicit path in this way.

Perhaps this issue should be moved to nixpkgs?

@curiousleo As for a repro, anything that needs to fetch something using git seems to have this issue for me.

@curiousleo As for a repro, anything that needs to fetch something using git seems to have this issue for me.

Could you share a snippet of how your shell.nix is calling git?

I'm also getting this under NixOS when a package needs to go and fetch something from git, for example:
let
  erlangReleases = builtins.fetchTarball https://github.com/nixerl/nixpkgs-nixerl/archive/v1.0.2-devel.tar.gz;

  nixpkgs =
    import <nixpkgs> {
      overlays = [
        (import erlangReleases)
      ];
    };

in

with nixpkgs;

mkShell {
  buildInputs = with pkgs; [
    nixerl.erlang-22-1-8.erlang
  ];
}

nixerl is an overlay I created to make various Erlang releases available, it just calls override on the standard nixpkgs derivations with specific version numbers - that triggers downloading the source because the package isn't in the standard binary cache.
I'm having to run lorri daemon interactively at the moment to work around this issue.

Thanks for the repro shell @philipstears! Yes that looks like a packaging issue. I'll follow up on this

It is a little odd that builtins.fetchTarball calls git in the background - naively, it should just HTTP request the file and then unzip + untar it? But this demonstrates that Nix itself calls out to a git binary (rather than having a built-in git library, for example), so it shows the problem. Thanks!

That fetchTarball succeeds, it just brings down the overlay - ultimately it's the nixerl.erlang-22-1-8.erlang evaluation that will fail, which via a slightly circuitous route, ends up calling https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/erlang/generic-builder.nix#L13

The nixpkgs PRs have been merged. I think that should fix the issue. Thanks for the reports!


Problems with html:5 snippet

I´m trying to use the html:5 snippet on my project but is not working. Normally, when I type html on vsCode´s editor, the html:5 auto completes with:
<!DOCTYPE html>
<html lang="en">
<head>
	<meta charset="UTF-8">
	<meta name="viewport" content="width=device-width, initial-scale=1.0">
	<title>Document</title>
</head>
<body>
</body>
</html>

I´ve been looking on internet and asked for help in a frontend forum and in a group, but all ideas and suggestions failed:

disable all vscode’s extensions
check if VsCode is updated
created a new repository

I created a new index.html file on an old project to check if it´s working and yes it works! So, I suppose it´s something related to VsCode´s config. Does anyone have any suggestions? :blush:

What was previously happening? For example, was it not expanding, or were the suggestions not popping up?

Hi there. I found the solution for this issue. The snippet window was
minimized. Many thanks for your help anyway!!
S.
Em qui., 4 de fev. de 2021 às 13:59, Raymond Zhao<EMAIL_ADDRESS>escreveu:

What was previously happening? For example, was it not expanding, or were
the suggestions not popping up?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/115709#issuecomment-773458263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANP4TDCE43GKVIR27GK2GCDS5LG7VANCNFSM4XBNRSXQ
.


http://wikitrivia.atbaker.me is not available any more ?

Andrew:  Very interesting project, I was hoping to play with it at the above link. Seems no longer available?

Am also interested in this project but the thing is same issue

Hi guys - apologies for the late reply.
I'm not interested in maintaining this project anymore, but it's MIT licensed so you can do pretty much anything you want with it.
I'll add a note to the README now.


Using boltDB without mmap() support

We are using BoltDB for embedded devices and some of them use JFFS2 file system which is not mmap() friendly. Is there a way to make boltDB to fall back to the standard API if mmap is not an option? If it is 1000 times slower it would be okay as long as it works.

In that context, what about having Bolt as completely in-memory instead of using mmap with option to flush data on demand when needed?

Unfortunately there's not an easy way to detach Bolt from its underlying mmap. It's a pretty tight integration.