CLI updating channel with image null doesn't work (bug)

Hello,
I was trying to update a channel's image field via the CLI:
stream chat:channel:update -t 'messagingMembersOnly' -c "chatRoom_9nuDGTNQoEpF7NFzHhQ71U" --image=null
But that command had an unintended effect it set the image to "null" instead of null
I tried to undo this by updating all the fields:
stream chat:channel:update -t 'messagingMembersOnly' -c "chatRoom_9nuDGTNQoEpF7NFzHhQ71U" --daisieChatRoomUuid="chatRoom_9nuDGTNQoEpF7NFzHhQ71U"
--daisieIsBlocked=false
--daisieIsEmptyRoom=false
--daisieProjectUuid="project_xspmfR3Q6UdsSnjNa44tgE"
--daisieRoomType="project"
--name="my image is null :o"
--image=null
But then I get an 'Unexpected arguments' error for our custom fields (like daisieRoomType).
Is there a way to set a field to null instead of "null" ?

This isn't applicable anymore


Update GitHub Action Versions

GitHub Actions Version Updates

actions/checkout published a new release v3.5.0 on 2023-03-24T05:41:31Z
saadmk11/github-actions-version-updater published a new release v0.7.4 on 2023-03-15T16:41:04Z
github/codeql-action published a new release codeql-bundle-20230317 on 2023-03-17T13:39:55Z

Will hold off on GitHub-actions-update in favour of giving Dependabot a chance.


AES-GCM encryption error when plaintext length exceeds 512 bytes on arm64ilp32 program

Build configuration:
./Configure linux-arm64ilp32 shared
./Configure linux-arm64be shared

Error Description：AES-GCM encrypt result error
Conditions:

input plaintext length greater than 512 bytes
the arm64ilp32 or arm64be program, running on arm64 platform, big endian (On the little endian environment, the result is right)
enable asm (When configuring no-asm, the result is right)

After preliminarily analyze, the code where the condition of "input plaintext length greater than 512 bytes" is located on:
https://github.com/openssl/openssl/blob/4bf3ef720b85cc396f94249d870886b82d2ec2d3/providers/implementations/ciphers/cipher_aes_gcm_hw.c#L70

commit by PR: https://github.com/openssl/openssl/pull/9818/files#diff-2eaf76486e8bdcfa7c7440b3102e1f02be20f19a234fe064807b11da17d946e3
@zorrorffm  Hello Mr.Fang, I find a AES-GCM encryption error when plaintext length exceeds 512 bytes on arm64ilp32 big-endian program. Do you have any ideas?

@JerryDevis ,Thanks for reporting this issue, I will take a look.

@JerryDevis ,Thanks for reporting this issue, I will take a look.

@zorrorffm  Does this assembly implementation consider and test big-endian programs?

Honestly I didn't consider big-endian programs before.  I'm checking the code if the big-endian can be implemented after minor changes. If I can't make it in a short time, I will work around it by limiting the assembly workable to little-endian only.

@JerryDevis Out of interest, what system did you run this on? And was the problem caught by your own code, or by the unit tests?

System image: http://nycdn.netbsd.org/pub/NetBSD-daily/HEAD/latest/evbarm-aarch64eb/binary/gzimg/arm64.img.gz
Tool chain: arm64ilp32 or arm64be
The problem caught by our own code, when AES-GCM encryption with plaintext length exceeds 512 bytes.

Hmm, shouldn't this issue be closed now that #20489 has been merged, or am I missing something?

Yes, closing


A custom command for rendering timelapses

What would you like to see added?
I'm storing both my temp files and assembled timelapses on a network storage connected using NFS from a much more powerful machine than the one the bot is running on, and I'd like to leverage that power (and that would be much faster than transferring stuff over wifi over and over as well).
Would you be interested in accepting a PR implementing running a custom script for timelapse assembly?

I think it's safe to say that the PR is not coming/workaround was sufficient


Enhancement of the cron service and use of the SDK library

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Is there any issue related to this PR in other repository? (such as dojot/dojot)

dojot/dojot#2032

dojot/dojot#2033

dojot/dojot#2034

dojot/dojot#2078

dojot/dojot#2095

dojot/dojot#2035

Other information:

To using this service with dojot v0.8.0 will be necessary change the interceptor tokenParsingInterceptor to  tokenKeycloakParsingInterceptor, and this is available in the latest version of sdk lib. (https://github.com/dojot/dojot-microservice-sdk-js/blob/master/lib/webUtils/framework/interceptors/tokenKeycloakParsingInterceptor.js)


add ipv6 to example nginx config

ipv6 addition to example nginx setup config as per #710

That's fast haha. Great thanks!


fix(julials): add language-specific root marker

Proper Julia packages have a Project.toml in the root directory. Use that as root marker (but keep .git as a fallback).

Does julia ever have projects with submodules/nested project.tomls? in which case we could do something like I did (and reverted) in https://github.com/neovim/nvim-lspconfig/pull/1399

"Submodules" are a thing, but I haven't ever seen "subpackages" in the wild. That means little, though...

Ok, this seems reasonable so I'm merging, but if someone brings this up we can redirect them at #1399 for inspiration

I haven't ever seen "subpackages"

This is supported since some time ago, see e.g. https://github.com/timholy/SnoopCompile.jl which has SnoopCompileBot and SnoopCompileCore as sub-packages with their own Project.toml. I don't know which project root would make more sense here though.

In that case I should probably factor out the logic in #1399 into a root utility function. Comments/PRs welcome if there is a better/more reliable way to generally solve this.


Debian 11 Support in LLVM toolchain

Debian 11 (which was officially released August 14 2021) is not explicitly supported currently, but seems that using the following would work correctly.
os_name = "linux-gnu-ubuntu-18.04"
The check for OS version is here:
https://github.com/grailbio/bazel-toolchain/blob/master/toolchain/tools/llvm_release_name.py#L95-L100
Would you accept a pull request for this change?

This was picked up in f54297f4 when I was fixing the container test failures. The container test for debian now uses Debian 11. Thanks.


[Beta] Clicking on freeCodeCamp logo on sign in page directs to oauth's homepage

Looking forward for reporting a security issue:
Clicking on freeCodeCamp logo on sign in page directs to oauth's homepage.
To Reproduce

Go to https://www.freecodecamp.dev/signin
Click on freeCodeCamp logo

Expected behavior
It should direct me back to freeCodeCamp.org.
Desktop (please complete the following information):

OS: Windows 10 Pro 32 Bit Pro
Browser: Chrome
Version: 77.0.3865.90

Reproduced.  I'll take this one.

After briefly going through the code, it looks like this page isn't actually in this code.  It looks like an external redirect (AUTH0_DOMAIN) specified in the .env file before deployment, and that the page itself is actually run by auth0.  Therefore, I can't actually fix this issue in this repository.  Is that correct?

@lrm25 Visit this link to see the code which needs to be changed, but I am not sure if we should hard code freeCodeCamp.org into the href because in production we have a 302 redirect for taking us from https://auth.freecodecamp.org/ to https://freeCodeCamp.org when nav logo is clicked.
@raisedadead Should we do it or we'll have a redirect?

@vkWeb OK, it's in a different subproject.
The problem is that the freeCodeCamp logo link is '/', or the current page minus the queries.  In the case of the dev site, that's freecodecamp-dev.auth0.com.  Unfortunately, without the /login query, there's no data at that subdomain, and auth0's behavior in the case of a non-existent subdomain is to redirect the user back to auth0.com.  If you goof around and type in something like fdkjljfajdfadjfa.auth0.com, you'll see the same behavior.
Would a possible solution be to just get freecodecamp-dev.auth0.com to redirect back to the /login query?  That way, a fix to this issue wouldn't possibly affect the main freecodecamp.com site or the developer install.

Can't reproduce.


Fix license_finder job failure for PRs from a forked repository

Summary

For PRs from forked repositories, the license_finder job was failing because it could not reference repository variables and secrets.
Since the license_finder job is a required check for PR merging, there was a problem that PRs could not be merged even if they were approved.
This PR fixes the above.
Related Issue

Nothing
Changes

The license_finder job triggered by a PR from the fork repository will no longer update $LICENSE_REPORT.
Testing

PR from forked repository, license_finder job passes.✅

https://github.com/route06inc/giselle/pull/59

Other Information

Nothing

Thank you for your review.
https://github.com/route06inc/giselle/pull/57/files

# When triggered by a push to the default branch, $LICENSE_REPORT is not updated either.

It works well. 😄
https://github.com/route06inc/giselle/actions/runs/11587360483/job/32259433029


Added Documentation to GsonSerializer.java

Contains
Added Documentation to GsonSerializer. Used same methodology as in #3562
How to test
Ensure accurate descriptions in documentation. Make sure there are no issues with merging.
Outstanding before merging
N/A

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

I fixed the grammatical errors you pointed out

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

In honour of the merge-ocalypse I'm going to do just that.
Also because I can't spot any more issue with it and we've entered nitpick zone


[vcpkg] fix edit command on windows

cc @ras0219

Thanks for the quick fix Nicole :)

Thanks for the quick fix Nicole :)


Decide what should happen for loooooong text

render_comment_list([Comment(text_content="wow\nwow\nwow\nwow\nwow\nwow\nwow\n")], output_filename="output.mp4", resolution_scale=2)

This shows only the first four lines and clips all others.

Oh, actually comments_to_scene does split it into multiple scenes, but that's nothing to do with actual line numbers, so overflow still happens for some texts.


Adds glitch weather API to take home interview weather project.

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue: Closes #15598

Description

This will add the glitch weather API to the weather project challenge in the take home interview section. This means that users can get the weather without using an API key and using a HTTP Secure connection.

Thanks @MiloATH

@MiloATH Wow - excellent work! Thank you for fixing this! Could you also make this change off backup/master and create a pull request there? We should get this into production ASAP. Once it's merged there, @BerkeleyTrue can deploy it.


More explicit M17 way of calculating Uc with Eq. 10 and 14.

This method simply combines Eq. 10 and 14 from Massman et al. 2017 to calculate the Uc, which may result in changes too.  @angehung5 Can you test this?

Below is the comparison of wind profiles using original calculation and M17 formulation. M17 does better at Uc estimation and probably better at in-canopy wind, but the above-canopy wind speeds are way higher. Also the discontinuity at the canopy top is more significant when using M17.
I am not sure which approach is better. The original calculation has larger bias in terms of Uc but the overall profile is ok and more smooth. M17 has better performance in Uc but the shape of the overall wind profile is kind of strange.

Seems new M17 approach is overall better here,  and I don't see a greater
discontinuity (maybe a bit sharper).  What do other sites show, and for
those that have above canopy?  I agree its definitely higher in new M17
approach.
Thanks
On Wed, Jan 17, 2024, 5:37 PM Wei-Ting Hung @.***>
wrote:

Below is the comparison of wind profiles using original calculation and
M17 formulation. M17 does better at Uc estimation and probably better at
in-canopy wind, but the above-canopy wind speeds are way higher. Also the
discontinuity at the canopy top is more significant when using M17.
I am not sure which approach is better. The original calculation has
larger bias in terms of Uc but the overall profile is ok and more smooth.
M17 has better performance in Uc but the shape of the overall wind profile
is kind of strange.
xTE_wind_profile_0600_20200601_20200930_avg_sensitivity_uc_zh.jpg (view on
web)
https://github.com/noaa-oar-arl/canopy-app/assets/107704243/f04afd1c-adb3-4c6d-a368-3961c9f29668
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-oar-arl/canopy-app/pull/102#issuecomment-1897201058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGLFYNSRZTTBLDGUW66UYUDYPBHDVAVCNFSM6AAAAABB7DRWWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJXGIYDCMBVHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Seems the Uc estimation based on M17 works fine at Bartlett forest but is much higher at Chestnut, GoAmazon and Willow Creek, as well as above-canopy wind speeds. I would suggest sticking to current approach.

@angehung5 OK, I agree, its too high.  Sorry, but made another slight change to this M17 approach, which should lower it now.  Can you check once more these results at four sites?  Thank you!

Sorry, made another change for the zpd calculation to be consistent with updated M17 method.  Please check now after latest commit.

@angehung5  Closing this for now, as we will remain with original approach for now, and work on this in future for more robust unified stability/RSL approach following Bonan.


The internet test froze the system for 30 seconds

It tries to connect to the server. Sometimes it can lag. It's not our problem


COVID-19 images need Metadata

Nearly half of the images have source links mentioned in the commit message, which needs to be provided to all of the images.
Next, metadata must be attached to the dataset as a CSV file. It must include:

patient sex
patient age
imaging location (country)
imaging date
the chance of survival (if mentioned)
clinical admission symptoms (such as cough or dyspnea, etc.)
image findings
imaging view (AP, PA, AP Supine)
patient ID
offset of the images (if more than one image is captured, in different days)
whether a CT scan is performed after the CXR or not

Note: patient symptoms and image findings must be recorded in terms of including certain keywords, e.g. has_cough=True, has_dyspnea=False, has_fever=True for symptoms and consolidation=True, opacities=True, pleural_effusion=False for x-ray image findings.

Metadata Specifications
Metadata must have 27 columns, as follows:
filename: string. name of the file in the current directory. for example 739.jpg
patient_id: integer
sex: string. [male, female]
age: integer
modality: string, [x-ray]
view: string. [AP, AP supine, AP erect, PA, L]. The view is important because of some interpretations about images, such as heart size. If not mentioned, leave it blank.
label: string. diagnosis results separated with a comma. for example: COVID-19, Atelectasis
pcr_test: string. [positive, negative, None]. Whether the patient has had an RT-PCR test or not. If left as None means that the patient did not have any PCR tests. Otherwise, the result must be mentioned as positive or negative. If the image source did not mention anything, leave as None.
survival: boolean. Whether or not the patient has died. If not mentioned, leave it blank.
date: string. the date of the image in DD/MM/YYYY format. If day not available, just insert month and year. for example 21/Apr/2020.
location: string. City and country where the image is captured; no need to mention other things like hospital name. If city not available, just insert country. for example lyon, france or russia
admission_offset: integer. The number of days between capturing the image and admitting the patient into the institute. It can be <0 in a rare situation.
also_had_ct: boolean. Whether or not the patient was undergone a CT scan after or befor the x-ray image.
has_fever, has_cough, has_dyspnea, has_diarrhea: boolean. Presence of typical COVID-19 Symptoms at the admission.
has_other_symptoms: string. If other symptoms are present, just mention; for example chills. If any other clinical data, insert with its value; for example SpO2=95%
has_other_diseases: string. Name other diseases that the patient is suffering from at the admission.
had_medical_background: string. Name diseases present in patient's medical background. It is the same as has_other_diseases if not mentioned specifically.
airspace_opacities, consolidation, ggo: boolean. Presence of pneumonia findings in the x-ray image. These findings may hugely overlap, just set to 1 if directly mentioned in the image caption or interpretations. GGO stands for Ground Glass Opacities.
pleural_effiusion: boolean. Presence of rare findings of COVID-19 pneumonia.
other: string. Name other findings if mentioned specifically. (other than opacifications)
doi: string. DOI of the paper in which the image is illustrated. Leave it blank if not applicable.
url: string. Link to the image resource (required).
If any of the details above are not mentioned in the image source, leave as blank (if not specifically defined what to do in this case). I will provide a template CSV file with a number of records. Reach me if you want to contribute to preparing metadata


[material-ui][Alert] Change types to allow color override types to be added to iconMapping and severity props

[X] I have followed (at least) the PR section of the contributing guide.

Change Alert types to allow color override types to be added to iconMapping and severity props
Fixes https://github.com/mui/material-ui/issues/40264

@ZeeshanTamboli I've managed to step through a couple of the CI failures but there are a few others that are unrelated to my changes.


Can't dump

Trying to dump from my Hub, but i keep getting the error that the name can't be resolved.
Even if I specify the --dirigera.hostname= variable.
How can i resolve this issue?

Could you provide us with the full command you're trying to use?

Could you provide us with the full command you're trying to use?
Also the HUB is connected to the network?

Yes, the hub is connected and discovered. It's just when the script tries to connect, it uses the name of the hub instead of the IP. It fails because it can't resolve the name and then just stops.
Command: java -jar dirigera-client-dump.jar
OR:		 java -jar dirigera-client-dump.jar --dirigera.hostname=THE IP
As per documentation.
Tried on 2 different linux machines. Java version is verified to be v17.

I think I ran into this problem as well with the addon as well.
Try also adding --dirigera.port=8443

I think I ran into this problem as well with the addon as well.
Try also adding --dirigera.port=8443

I did already try that, and it didn't work. But now it does.
I did setup a local DNS resolver on my router, so i'm not sure if that's the reason, but it works now. I will get the dump, and clean it up a bit before posting.
Is it true that the script doesn't create a text/json file after a successful run?

It is indeed not writing a file. The console output is the "json"


[Backport 17.07] Gw field & waitgrp crash

This commit backport the following master fixes to 17.07 branch:

Waitgroup crash fix
-> Master PR: https://github.com/docker/libnetwork/pull/1885
Gw field fix
-> Master PR: #1887

@mavenugo PTAL

or @sanimej

LGTM


Store multiple crawls in a single database

This PR significantly alters the way this package uses a database. Instead of storing individual website crawls into separate SQLite database files, all crawls are now stored into the same Django database. This database can be configured to use any database backend supported by Django. Database tables are now managed by Django migrations, and a new Crawl model keeps track of the status of past crawls, including whether they succeeded or failed.
This PR also adds Python tests for 100% of testable Python code (excluding only the plugin to the wpull crawler, which is difficult to test without running a real crawl). This package has been migrated to pytest and pytest-cov for simpler testing and coverage checks. Moving forward, PR checks will fail if Python coverage drops below 100%.
(As a TODO, a future PR will need to add a management command to clean up old crawls, to ensure the database doesn't continue to grow indefinitely).

@willbarton in 844f245 I added a workaround to handle missing SVG icons in the Python tests, when we haven't run the frontend build. Like cf.gov, the frontend build copies the CFPB Design System SVG icons from node_modules to where Django can see and load them inline during template rendering. We don't want to have to run the frontend install and build steps in order to successfully run the Python tests.
To get around this, I've added a simple template loader that ignores missing SVGs. Cf.gov has a bunch of custom code that handles this a different way (by inserting a placeholder SVG) which I'd prefer not to copy here. Thanks to @anselmbradford for counsel on different options.
Currently this project only has a single settings file that doesn't disambiguate between testing or dev or production. As part of future work I'll split that out so that this new loader isn't running in production, but this seems a reasonable path forward for now.


Error installing fsqc via pip

Description
I'm running into issues when installing fsqc via pip as described in the readme.
Steps to Reproduce
Steps to reproduce the observed behaviour, in as much detail as possible:

create and activate an empty conda environment with python: conda create -n fsqc python, conda activate fsqc
Install fsqc via pip: pip install fsqc

Error Message
I'm getting the following error:

ERROR: Could not find a version that satisfies the requirement fsqc (from versions: none)
ERROR: No matching distribution found for fsqc

Expected Behavior
fsqc should be installed and accesible via cli and api
Screenshots

Environment

qatools-python Version: 2.0 I suppose
OS: openSUSE Leap 15.4

Thanks for the report, and sorry about that: the announcement about availability on pypi.org was a bit too early, but we are working on it and it should not take long. The same holds for dockerhub. I'll post an update when we're done. In the meantime, the GitHub install should still work.

Great! installing via GihUb worked just fine :)

The pip install should work now. Dockerhub might take a few more days, unfortunately.

Yes, works nicely! Thanks for your work @kdiers


Add http_build_query function.

https://www.php.net/manual/en/function.http-build-query.php

@dim-s is this gonna be merged? Any issue I can address?

@nstdio Can you do answer my code review comments?

I don't see any comments.

Hm,

I guess you need to submit the review

@nstdio I did, see the comments

It appears now, I'll address them, thanks :)


Noisy git status

Ignore the src/ subdirectory created by installing dummy authenticator

tickle travis after #74 is merged

Happy travis


.getElementsAtXAxis(e) may be poorly named

Documentation Is:

[ ] Missing or needed
[X] Confusing
[ ] Not Sure?

Please Explain in Detail...
The .getElementsAtXAxis(e) may have a poor name - since indexing can be done on multiple axes now.
Your Proposal for Changes
The function should be renamed, and, possibly, parametrized with the index field. See the discussion  that led to this.
Example
Not applicable

@Ludar-Pavel can I work on this issue?

Please do.

This API was removed in #7900 and replaced with a documented version of getElementsAtEventForMode


Test API for preselected items

Refs: #35551

[ ] any
[ ] any

Complexity: 1
A completion item can not be marked as preselected. That means the UI is more likely to select that item. 'More likely' because such items can still be filtered out or ranked low and then they aren't selected. Also, suggest memories overwrite the preselect-property. Test that all of that works.

FYI - to test against the latest API do the following:

open your extensions package.json file
change the engine.vscode property to *
run npm run postinstall (assuming you have the vscode module as dev-dependency)
undo the engine-version change from step 2

assigning @ramya-rao-a because of emmet

@jrieken Do you mean can here - A completion item can not be marked as preselected.?

ops. thanks @sandy081. corrected.

Verified that the pre-selected item is pre-selected when completion is triggered and there is no text before the cursor


Apply breaking changes from Veldrid

Prereqs:

[ ] New Veldrid package.

These are the breaking changes required resulting from https://github.com/ppy/veldrid/pull/45
@peppy Don't make a Veldrid package immediately. I just wanted this PR so it's easier for me to test across different platforms.

roger, ping me when required

This one should be ready to go now.


Napari widget

Adding napari widget to examine affinityvae model outputs in a new scripts directory

Napari pluggin tested in:

[x] 2D data model
[x] 3D data model
[x] 1 pose dimention
[x] > 1 pose dimentions

[x] Add readme

Napari environment installation works fine
for models trained with the current version of the code, all looks great


Query Compile Flags

Is there anyway to check compile flags of mxnet with python interface?
The way i'm trying to use is to locate libmxnet.so, and check linkage with ldd:
ldd libmxnet.so | grep cud

so that I can know whether cudnn is enabled, along with which version of cudnn i'm using.
Things become more complicated when there are multiple instance installed in the system, such as locations at ~/.local/lib/python2.7/dist-packages/, /usr/local/lib/python2.7/dist-packages/ and multiple version of the library might available in these directories.
I'm wondering is there any more friendly way to do this?
Or what additional work should be done to enable this feature?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


[FLINK-10585][tests] Fix RestServerEndpointITCase instability

What is the purpose of the change
This fixes a rare test instability that occurs if the RestServerEndpoint is only accessible via one protocol stack (either IPv4 or IPv6).
Brief change log

Re-create testing keystore and truststore (local127.keystore, local127.truststore)
Change RestServerEndpointITCase so that we explicitly bind the RestServerEndpoint under test on loopback address
Use java.net.URL to build restBaseUrl. This enables to bind the RestServerEndpoint to a IPv6 address
Extract method getTestResource in RestServerEndpointITCase

Verifying this change
This change is already covered by existing tests, such as RestServerEndpointITCase.
This change added tests and can be verified as follows:

Verify that RestServerEndpointITCase fails with BindException if rest port is occupied

Set RestOptions.BIND_PORT to "12345"
In another terminal, run nc -l <IP_ADDRESS> 12345
In another terminal, use netstat to verify that a tcp4 socket listening on port 12345 is open: netstat -vanp tcp | grep 12345
Run testsmvn clean integration-test -pl flink-runtime -am -Dtest=RestServerEndpointITCase -Dfast -DfailIfNoTests=false -Dsurefire.skipAfterFailureCount=1 -Djava.net.preferIPv4Stack=true

Verify that tests failed with: java.net.BindException: Could not start rest endpoint on any port in port range 12345
Verify that the terminal running nc does not show any output

Verify that RestServerEndpointITCase passes with IPv6:

Set RestOptions.BIND_PORT to "12345"
In another terminal, run nc -l <IP_ADDRESS> 12345
Run testsmvn clean integration-test -pl flink-runtime -am -Dtest=RestServerEndpointITCase -Dfast -DfailIfNoTests=false -Dsurefire.skipAfterFailureCount=1 -Djava.net.preferIPv6Addresses=true

Tests should pass

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc: @tillrohrmann


Postgis support

Postgis support would be really cool. E.g. showing coordinates as Lat / Long or even on a map.

Postgis support would be really cool. E.g. showing coordinates as Lat / Long or even on a map.

Sounds interesting. Although I think this feature is bigger than just Postgis.
We need a general support of spatial data types.

Something that would go a long way would be custom function autocomplete (code/content assist) since PostGIS has so many functions. As well, if a user could associate help text with each custom function they have listed for auto-completion. Something similar to the template functionality where they can add keywords and descriptions, export, import, etc. It wouldn't need to know the surrounding code, just the partial word they have typed. That could be useful for users of any less common functions (MADlib comes to mind, as well as user-created functions).
FWIW, I imagine viewing spatial data directly in the application would be a massive undertaking, as the user would want to style and compare different intermediate results. If the user creates throwaway tables for these steps, they can view these in QGIS (or any GIS software offering a database connection). Support for shp2pgsql/pgsql2raster/etc would enable a different workflow but that is PostGIS specific.
Finally, I just wanted to add - I just found out about this software today and I'm immediately switching over.

We'll add basic Postgis support in 4.3.5.
Show maps and other fancy stuff should be tracked in separate tickets (now it should be easy).

Postgis support was announced for release 4.3.5 in https://github.com/dbeaver/dbeaver/releases. However, I'm using that release installed from Ubuntu ppa repo and I still don't get autocomplete for postgis functions.
PostgreSQL version: 9.5
PostGIS version: 2.4.2

Adding that the support for evaluating spatial functions is there for both MSSQL and PostGIS, but the missing feature is the auto-complete of the spatial functions while typing the query. Great piece of software, and holds up to all our workflows so far!!

Cold you create a separate feature request.  It differs from Postgis implementation itself.

@serge-rider Done. https://github.com/dbeaver/dbeaver/issues/4047

pgadmin just added a spatial viewer. I'd love to never have to open pgadmin again, is a spatial viewer here yet for dbeaver? Is there an issue I can upvote?
http://www.bostongis.com/blog/index.php?url=archives/272-pgAdmin4-now-offers-PostGIS-geometry-viewer.html

This can be added in DBeaver, and this is not too hard as there are map widgets already.
Please create the feature request.

@chriszrc Chris, let me know if you do this, or if you want me to. Thanks, all!! This will be a great feature for DBeaver!!

@dpsspatial hi, I'm relatively new to dbeaver, and I'm not even aware of the map widgets, so maybe you would be better suited to create the feature requests? Also, any links to these map widgets?

I can add the request. The map widgets are what you've referenced in the Boston GIS article, so I'll include that too.

@dpsspatial Hi, just curious if you made the feature request? Could you include the link here? Thanks!

@chriszrc here you go: https://github.com/dbeaver/dbeaver/issues/4222, which I see you've commented on!

@dpsspatial lol, this link came up first in the google searches, well, now I'll know where to go, thanks!


Bump Creek to 0.4.2-SNAPSHOT

Coverage: 98.999%. Remained the same when pulling a196ee4756cd8dafc8531d793bee784ffe870f97 on big-andy-coates-patch-1 into 08996642e9617b15fdccbbe3f2dd5c57df9f0d5f on main.


Address Dark Reader settings translation issue

Description
Dark Reader settings were not properly translated; took the opportunity to harmonize the case when mentioning Dark Reader. Also removed the unmaintained/confusing en.json (maintained one is en-US.json).
Motivation and Context
Found while reviewing for https://github.com/getferdi/ferdi/issues/536 (see https://github.com/getferdi/ferdi/issues/536#issuecomment-615887427).
How Has This Been Tested?

Ran locally.
Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project (run $ yarn lint).

Forgot to push before asking for review 😅🙏


Nik

Representations of strategies fortress 3 and fortress 4.
Please let me know if they don't look like you wanted (if there are ugly) .

@Nikoleta-v3 I meant to plot the extra 3 FSM strategies used in this, so not the ones from the literature but the 3 ones specifically chosen (see src/players.py).

I see. Sorry about that.

Thanks for making these! Maybe we can put them in an appendix for comparison to the new ones (at least for the ArXiv perhaps?). Fingers crossed that we've chased down the last issue for the FSM players -- my expectations are high!
You might also consider some of the players in the library, say EvolvedFSM4. We'll need it for the ML paper  anyway.

Fingers crossed that we've chased down the last issue for the FSM players -- my expectations are high!

So there's actually 6 extra FSM :) Not sure if you followed on #20 but I actually had the wrong FSMs. Thankfully it's just the initial state that differs to what's currently there so shouldn't be too much of a pain to modify :) We can chat about if in our meeting tomorrow :+1:

#32 closes this.
It has a better title and explanation of the additions.


Vec<..> from &Tensor

Back in the day, tch-rs had the ability to convert from a Tensor to a Vec, for instance:
    let tensor = Tensor::arange_start(0, 6 * 2, opt).view([6, 2]);
    let index: &[_] = &[1, 3, 5];
    let result = tensor.i(index);
    result.print();
    assert_eq!(result.size(), &[3, 2]);
    assert_eq!(Vec::<i64>::from(result), &[2, 3, 6, 7, 10, 11]); // this is the conversion of interest

There are some helper functions here which are not part of the tch-rs library but have the same purpose (albeit they take a &Tensor and not a Tensor).
https://github.com/LaurentMazare/tch-rs/blob/main/tests/test_utils.rs

Would it make sense to add these helper conversion functions to the tch-rs library?

The From trait has been replaced with TryFrom, see the changelog if you want to check what might have changed compared to old version. You can probably grep the repo for try_from to find examples of this being used.

i see, it's a rust langwart nvm


Add TO Perl 1.3 routing

This is necessary, as we already have 1.3 endpoints in TO Go. So
Perl needs to route reqs to 1.3 too, so clients can use 1.3 entirely.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/529/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/483/


Continuous Error Messages from BTTN

I have noticed during my use of BTTN that lately, I have started to get error messages being sent. After doing some digging I noticed that a lot of the messages are because of Twitch.TV API returning a 502 HTTP code. I am looking into seeing if there is a more reliable way of getting twitch status and if not, then I will look into mitigation techniques to limit the issue. Please respond to this issue if you are experiencing a similar issue.

After looking into the issue, I have started work on some mitigation techniques, after testing the changes I will update if they work. If they do help with the issue, I will add the improvements to the 1.6 version.

Closing this issue, since Twitch seems to have fixed their API and there are no more errors. These changes have been reverted in my workplace, and have no plans on being added to a public version.


Add table of contents to API docs

Created table of contents with links to each section

@ddoria921 thanks! unfortunately there is a small problem: api.md is automatically generated and once we regenerate it the ToC will be gone again 😱
we might however be able to take advantage of something like https://github.com/emberjs/ember-test-helpers/blob/master/documentation.yml which then should be able to automatically generate a ToC from that (see https://github.com/emberjs/ember-test-helpers/blob/master/API.md#table-of-contents).

@Turbo87 I configured the docs script in the package.json to use the build command instead of the readme command. Then, I added configuration file. In the configuration I specified to include a assert.dom() section at the top and I copied over the example used in the existing API doc.
Check it out and let me know what you think. The end result looks a little different than how it is currently formatted, but it's the same information.

thanks :)


Question regarding FormattedItem<ENTITY> type helper

I saw in the documentation and tests, that FormattedItem<ENTITY> seems to be a valid way to get the inferred type from the schema. It returns the schema + created and modified.
Is there a way to omit or make those fields optional? As far as I understood, these internal values are set automatically.
Or is there a type helper that only returns the schema without internal attributes?
My usecases for the inferred types are to build lists of items, before writing them via batchWrite.
export type StationDescription = FormattedItem<typeof stationDescriptionEntity>;

/*...*/

const stations: StationDescription[] = [];

for (const data of someOtherDataSource) {
  const station = {
    id: data.id,
    foo: 'bar',
    address: data.address + 'x',
  }

  stations.push(station); // this would give an type error because `created` and `modified` are missing
}

example of another type that used FormattedItem

Yes, you can opt-out of the timestamp attributes, or fine-tune them to hide them.
Everything's here: https://www.dynamodbtoolbox.com/docs/entities/internal-attributes#timestamp-attributes

@ThomasAribart I tried the approach with the timestamps option but oddly, the typing is not working:
disabling globally:

disabling individually:

This is probably because you manually provided generics to the Entity (lines 66 to 68 in your example). timestamps options are another generic within the list (the 5th after the entity name).
This is annoying but in TS, you can either provide no generic (let TS infer them from your args), or provide all of them. There is no in between.
Simple remove the generics and you should be fine:
const stationUserPictureEntity = new Entity({
  name: "..."
  ...
})

awesome .. this solved the typing issue


Set Cropped width and height instead of cropit-preview width and height

is there anyway to get different width and height?
I don't want to use cropit-preview width and height for the cropped image. I want my image crop  to 1900x1080, but I dont want to show the preview 1900*1080.
Is it possible?

$(function() {
$('.image-editor').cropit({
imageState: {
// src: 'https://google.com.vn',
},
smallImage: 'allow',
width: 400,
height: 400,
});
});

@nguyenquangha what is smallImage usage?. I dont see any changes when apply it

You can use "exportZoom", an example for a preview 475*270
$('.image-editor').cropit({
...
exportZoom: 4,
width: 475,
height: 270,
...
});
the exported image size will be 1900px * 1080px

@stefensuhat @hamzazafeer I have a similar scenario. I only have a maximum height of 200px for my preview area where I'm implementing this, but it will be used for a wide range of sizes. I wrote a simple formula to calculate what to divide both dimensions so they properly scale to fit the 200px height preview area. Applied that number as the exportZoom property. Hopefully this helps.
var originalHeight = 1080;
var originalWidth = 1920;

var previewScale = (originalHeight / 200);

var previewHeight = Math.round(originalHeight / previewScale);
var previewWidth = Math.round(originalWidth / previewScale);

$('.image-editor').cropit({
          width: previewWidth,
          height: previewHeight,
          exportZoom: previewScale
});

@hamzazafeer your original image isn't a square so the preview can't be a square. Following the fomula your cropit properites should be:
$('.image-editor').cropit({
          width: 200,
          height: 400,
          exportZoom: 2.35
});

@f1nch This is super useful, thanks!

Hi @f1nch . Thanks for your solution and it;s great. But here is my additional requirements:
Your formula works great to define preview area.
Suppose 1920X1080, convert this through your formula new preview area would be 475X270.
I just want to reduce the image dimension  respect to preview area. I mean if image dimensions is 400X400 then it should be loaded as 100X100 inside preview area(475X270) not with original dimensions 400X400.
Is this possible? Please tell me how it can be done?
Thanks


Add widevine third party

Add 2 new command options to use widevine:

widevine-cdm-path: Path to widevine plugin
widevine-cdm-version: Version of the widevine plugin

Depends on https://github.com/atom/brightray/pull/178

Merged with #3957.


Configurable system for setting model execution sequence

Description
This PR:

Implements a new model configuration schema that allows the execution order of different model methods to be set:

[core]
modules=['soil','abiotic_simple']
[soil.priority]
init=['abiotic_simple]

This is an instruction that the soil model __init__ method should be run before the abiotic_simple __init__ method.

Implements a get_model_sequence function in main.py that sorts a dictionary of models according to the configured priorities for a given method.
Only currently implements init and update but can be easily extended to setup, spinup etc if needed.
Deletes the select_models function and instead adds Config.model_classes to get a simple dictionary of the configured model classes more directly (#334).
Updates the tests and adds specific tests of the functionality.
A couple of JSONSchema files had CRLF endings for some reason, so I've standardised back to LF.

One thing I'm not sure about - at the moment the code objects if the priorities for a configured model include model names that are not in the config. That basically makes defaults for different models impossible, because it relies on all the model priorities being included. It may make more sense to simple discard 'extra' model names from a priority with a warning.
Fixes #335 and fixes #334
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

I have updated the PR to:

Switch to depends as that gives a clearer sense of what the system does.
Updated the sequencer to check for unconfigured dependencies and then remove them with a warning. The simulation may well crash here, but this allows defaults to be set and left alone without having to constantly tinker with depends for the set of models.
Added a short description in the docs.


Does not make me breakfast

What is this?
A disgrace!

Stack trace or GTFO

java.lang.NoClassDefFoundError: com.life.food.meals.breakfast

Are you sure you included the dependency "Life" ?


Add Open Trace option to Menu & Trace Explorer

fixes #160
Signed-off-by: muddana-satish<EMAIL_ADDRESS>

Adding few screenshots:
Added a new menu item under File menu.

I have added it right under Open. Thoughts?
Added a new button in Trace Explorer.

Using 'Open Trace' option just opens the trace. It doesn't load it to the file explorer. (similar to Open functionality)
On Click of 'Open Trace' button in Trace Explorer:

On Click of 'Open Trace' in File menu.

I really like the open trace button in the trace explorer and the command short-cut with CTRL+SHIFT+P. Please have a separate PR for the menu contribution as described in my comments.

Thanks @bhufmann  for the update.
I removed the menu contribution and added just the 'open trace' button in trace explorer as part of this PR. For the shortcut, I will create a new PR and work on it.

@ebugden I opened #189 to track the discussion of the open trace behavior for multiple traces (for MVP) in a separate tracker.
@muddana-satish, this PR is independent to the outcome of that discussion. I suggest to add the "Open Trace" button in the trace explorer and CTRL+SHIT+P behavior as you proposed (without the file menu option) and merge it. Later on we can update the implementation based on the decision.

@muddana-satish, great UX improvement, thank you!
I know I'm late to the party, but wouldn't be better to change the string "You have not yet opened a trace." to something like "No open traces"? It's shorter and makes more sense if we consider the flow when a user opens a trace and then closes it. Of course we can defer this minor change to another PR.

@muddana-satish, great UX improvement, thank you!
I know I'm late to the party, but wouldn't be better to change the string "You have not yet opened a trace." to something like "No open traces"? It's shorter and makes more sense if we consider the flow when a user opens a trace and then closes it. Of course we can defer this minor change to another PR.

I think the intention is to keep it similar to what VSCode shows (screenshots in #160). I do not have a strong opinion on this. I am okay with the suggest change if it's okay for others as well.

@muddana-satish I think the intention is to keep it similar to what VSCode shows

Yes that was the intention. If the extension uses phrasing that is consistent with the rest of VS Code it will feel well integrated to users and so they intuitively trust it more easily. For most users, this sentence is probably their first interaction with the extension and we're wired to interpret anomalies as potentially "off".
If Theia uses different phrasing and/or 95% of users are using it with Theia, then integration with VS Code can be less of a factor.

@mirsky-work wouldn't be better to change the string "You have not yet opened a trace." to something like "No open traces"? It's shorter and makes more sense if we consider the flow when a user opens a trace and then closes it.

I'm not sure what you mean by "No open traces" makes more sense considering the user flow. This button is only visible if no traces are open (initially forgot to specify, just updated issue #160). If a user closes all their open traces and they read the text again, I think it's still clear that the text refers to the future.
If I were to hypothesize as to why VS Code uses longer wording I would guess:

It's human: It feels gentler and more human to read a full sentence. I like this because it's an easy way to make the tool feel approachable (and less cold and utilitarian).
It's specific: In "You have not yet <performed an action>", "You" specifies that it's the user's responsibility to perform the action and "yet" specifies that they are able to perform the action. Ex. "No trace server" vs. "You have not yet started the trace server". Granted it's debatable whether this extra clarity is required here.

tl;dr "You have not yet opened a trace." is specific, approachable, and consistent with VS Code. But if the full sentence is inconsistent with Theia or you guys much prefer "No open traces" you can go for it.

@ebugden, I was not aware that the phrasing complies with existing phrasing in VS Code, in that case I agree we should strive to comply.

It's specific: In "You have not yet ", "You" specifies that it's the user's responsibility to perform the action and "yet" specifies that they are able to perform the action. Ex. "No trace server" vs. "You have not yet started the trace server". Granted it's debatable whether this extra clarity is required here.

What about a future scenario, in which the user connects to a remote server, where there might be traces opened by other users?

Any objections me merging this patch? I think it's a great addition.

Any objections me merging this patch? I think it's a great addition.

LGTM!

As a last check, could you post an updated screenshot? Thanks for the updates!

@ebugden
Trace Explorer:

Command Palette:

Button description text "You have not yet opened a Trace." should be left aligned

"You have not yet opened a trace." is still centered here.

I'm making use of the existing theia styles. I have not created any particular style for 'Open Trace' button. In other words, the newly added button is in consistent with the other buttons in theia.

If you mean that the the text above similar Theia side panel buttons is typically centered then let's leave it centered. Otherwise, I suggest left-aligning "You have not yet opened a trace." to match VS Code.
I think centered text actually looks prettier in this particular case but:

Longer text blocks will need to be left-aligned for readability (ex. "Before you can view a trace, the trace server must..." #191 (comment)) and left-aligning all text blocks makes text display consistent
Left-aligned text stays in the same place when the side panel changes width

Centered (current version)

Left-aligned (to match VS Code)

If you mean that the the text above similar Theia side panel buttons is typically centered then let's leave it centered. Otherwise, I suggest left-aligning "You have not yet opened a trace." to match VS Code.

@ebugden Yes. In theia, it is centered. So I believe it's best to leave it centered to keep it consistent. I do not know how CSS theia classes take effect when we use it in VSCode. We may definitely need to revisit if it doesn't align correctly in VSCode.

I'm going to merge it now. We can revisit the style (centered or not) later on when migrating to VSCode. I like it centered as well :-)

Yes. In theia, it is centered. So I believe it's best to leave it centered to keep it consistent.

Sounds good! Thank you for answering all my detailed questions!


Update visual tests to use renamed extent (previously extents) function

Looks like I was (just) beaten to it! Duplicate of #217


Consider a rule to normalize annotation style

Expected Rule behavior
Enforce multiple annotations use array-form, individual-form, but not both at the same time in the same location.
// GOOD:
@A @B @C
fun sup() {}
// GOOD:
@[A B C]
fun sup() {}
// BAD:
@A @[B C]
fun sup() {}

I suspect people will also want to enforce one style over the other globally. That is to say, if there are multiple annotations at a site they must either use the @[A B] form or @A @B form. I'm not sure enforcement of one style or the other by default makes sense, but that's a conversation we can have with the community.
The Android style guide says that array-form can only be used with a declared annotation receiver and provided they do not have arguments (https://developer.android.com/kotlin/style-guide#annotations). I'm not sure this very specific restriction is worth fully honoring, but it's important to note since it's somewhat an argument against a global default style but not fully.
Some interesting cases to handle:
// GOOD, separate receiver
@A @field:[B C]
val string: String
// GOOD, separate explicit receivers
@set:[A B] @get:[C D]
val string: String
// BAD, should be combined to a single array
@get:[A B] @get:C
val string: String

This is an interesting proposal.

That is to say, if there are multiple annotations at a site they must either use the @[A B] form or @A @B form. I'm not sure enforcement of one style or the other by default makes sense, but that's a conversation we can have with the community.

I would definetly favor to implement a global code style. Consistency in code style is a key factor in making code in a project easy to read. It might be best to create a separate rule for grouping annotation into arrays versus ungrouping annotations from arrays. This rule indeed would need a setting with the preferred style. The style could be one of following:

ungroup (split arrays of annotations in individual annotations)
arrays (combine annotations for same receiver into an array with exception for annotations with parameters)
Disabling the rule, allows you to use a mixed style.

I wouldn't know what the best default would be. I have the feeling that the array annotations are more heavily used in Android development. The default can be set per coding style.

I would favor to have each array of annotation to be on a separate line. So
// BAD, array of annotation should go on separate line
@[A B] @get:[C D]
val string: String
// GOOD
@[A B]
@get:[C D]
val string: String

// BAD, array of annotation should go on separate line
@set:[A B] @get:[C D]
val string: String
// GOOD
@set:[A B]
@get:[C D]
val string: String

Is it acceptable, or even favoured, to reorder annotations? Given original code:
@B @A @field:[D C]
@F("foo")
@[E G]
val string: String

When reordering is not allowed, this would become:
@[B A]
@field:[D C]
@F("foo)
@[E G]
val string: String

If reordering is allowed, it could be written as:
@[A B E G]
@F("foo)
@field:[D C]
val string: String

where ordering is:

annotations without parameter and without receiver in alphabetical order combined in array
annotations with parameter(s), one per line
annotations with receivers but without parameters. Annotations for same receiver are combined in an array. Each annotation for that same receiver but having a parameter go on a separate line. The receivers are sorted alphabetically.

I wouldn't know what the best default would be. I have the feeling that the array annotations are more heavily used in Android development.

If you want a single data point, I've never seen array annotations used, and I didn't even know it was a thing. I'm mostly work in Android, but do work on general JVM/KMP as well.

We do use array notation for readability. Agree with Jake's original notation that we shouldn't mix the two on a single element, but imo both should be allowed.
I would argue against any kind of reordering.

...we shouldn't mix the two on a single element, ...
I would argue against any kind of reordering.

This seems contractdictory to me. Given sample below:

@B @A @field:[D C]
@F("foo")
@E @G
val string: String

A, B, E and G are all annotations without receivers. Jake's propopal is that those should be grouped into a single array. That would mean that the order of the annotations will change.

we shouldn't mix the two on a single element, but imo both should be allowed.

This would mean that whenever an element is annotation with an annotation containing parameters, that all other annotations on that element should be ungrouped as well.

Parking the issue for now, due to lack of input / consensus.


Script output gets lost after ! command

foo.vim:
echo "before"
silent !/usr/bin/true
echo "after"
cquit

$ vim --clean -u foo.vim; echo $?
before1

If I change cquit to quit:
$ vim --clean -u foo.vim; echo $?
before0

vim 8.0.1625, installed from Homebrew with --HEAD:
Actually, I tested this on 7.4.898 (system Vim), and same thing.  I'm baffled.
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Mar 21 2018 10:00:04)
macOS version
Included patches: 1-1625
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl               +farsi             +mouse_sgr         -tag_any_white
+arabic            +file_in_path      -mouse_sysmouse    -tcl
+autocmd           +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    -gettext           +netbeans_intg     +timers
+byte_offset       -hangul_input      +num64             +title
+channel           +iconv             +packages          -toolbar
+cindent           +insert_expand     +path_extra        +user_commands
-clientserver      +job               +perl              +vertsplit
+clipboard         +jumplist          +persistent_undo   +virtualedit
+cmdline_compl     +keymap            +postscript        +visual
+cmdline_hist      +lambda            +printer           +visualextra
+cmdline_info      +langmap           +profile           +viminfo
+comments          +libcall           -python            +vreplace
+conceal           +linebreak         +python3           +wildignore
+cryptv            +lispindent        +quickfix          +wildmenu
+cscope            +listcmds          +reltime           +windows
+cursorbind        +localmap          +rightleft         +writebackup
+cursorshape       -lua               +ruby              -X11
+dialog_con        +menu              +scrollbind        -xfontset
+diff              +mksession         +signs             -xim
+digraphs          +modify_fname      +smartindent       -xpm
-dnd               +mouse             +startuptime       -xsmp
-ebcdic            -mouseshape        +statusline        -xterm_clipboard
+emacs_tags        +mouse_dec         -sun_workshop      -xterm_save
+eval              -mouse_gpm         +syntax
+ex_extra          -mouse_jsbterm     +tag_binary
+extra_search      +mouse_netterm     +tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -framework AppKit   -mmacosx-version-min=10.12 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.26.1/lib/perl5/5.26.1/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc  -L/usr/local/opt/python/Frameworks/Python.framework/Versions/3.6/lib/python3.6/config-3.6m-darwin -lpython3.6m -framework CoreFoundation  -lruby.2.5.0 -lobjc

Oh, and removing "silent":
before
:!/usr/bin/true

Press ENTER or type command to continue

and what do you expect?

before
after

try disabling termcap mode: :set t_ti= t_te=

This works, though it changes the behavior of echon "\n" so it no longer adds a blank line?
For future wanderers, $TERM was screen-256color, it does this also for "screen" and "xterm" using Terminal.app.

(inside tmux)

Are you sure? For me this script works:
echo "before"
echo "after"
echon "-\n-"
cquit

chrisbra@debian ~ % vim --clean -u foo.vim; echo $?
before
after-
-
1

And this one:
set t_ti= t_te=
echo "before"
silent !true
echo "after"
echon "-\n-"
cquit

produces this output:
chrisbra@debian ~ % vim --clean -u foo1.vim; echo $?
before
after-
-

Ah, I think I see what you mean:
echo "before"
echo "after"
echon "\n"
cquit

produces this:
chrisbra@debian ~ % vim --clean -u foo.vim; echo $?
before
after

1

and
set t_ti= t_te=
echo "before"
echo "after"
echon "\n"
cquit

produces this:
chrisbra@debian ~ % vim --clean -u foo.vim; echo $?
before
after
1

So perhaps we need an extra character after the \n?
set t_ti= t_te=
echo "before"
echo "after"
echon "\n "
cquit

produces:
chrisbra@debian ~ % vim --clean -u foo.vim; echo $?
before
after

1

Maybe it is the t_TI and t_TE settings...  which in my xterm outputs ANSI strings that seem act weird..
See my later comments in https://github.com/vim/vim/issues/5617#issuecomment-588988152


Error when save and quit buffer or tab

Your plugin is incredible.After some updates every time I close a buffer this error occurs, on other occasions noice does not work

This should not happen. I can suppress the error, but that would just mask the problem.
Can you add some of the last logs? :Noice log

noice.log

other error

Cant reproduce. Please create a minimal.lua https://github.com/folke/noice.nvim/wiki/Minimal-`init.lua`-to-Reproduce-an-Issue
That last error should never happen. Unrelated to Noice. Some lsp server or plugin is submitting progress info without a client_id?

Cant reproduce. Please create a minimal.lua https://github.com/folke/noice.nvim/wiki/Minimal-`init.lua`-to-Reproduce-an-Issue
That last error should never happen. Unrelated to Noice. Some lsp server or plugin is submitting progress info without a client_id?

Maybe it's null-ls but maybe I'm not sure

Interestingly enough I (sometimes) get the same behaviour (of the first screenshot: "invalid window id") when moving buffers around from floating windows. Let me explain: with modern fuzzy finders (I use fzf-lua) you can list your buffers (opening such list in a floating window) and associate actions upon them via keymaps, for instance opening it in a split window, editing it, deleting it and so forth. When doing so I sometimes get the many errors as in the original question, but I haven't been able to reproduce it consistently.

Echo to @gennaro-tedesco message. Same issue here, but unable to reproduce. cry It happens usually when I start to split windows and open new tabs.

Is exactly my workflow

Yesterday, I fixed an issue that seems related to this in https://github.com/folke/noice.nvim/commit/a8402e84c1923885896ee83eefb0f492a9f9b620
Please let me know if this issue still happens

@folke

This only happens if I use noise
I am currently using Neovim 0.9.0

@CRAG666 what is your Noice config?

@folke

I would really need to have a way to reproduce this. I've never even once seen such an error.

I could try my configuration
@folke  this is my config
https://github.com/CRAG666/dotfiles/tree/master/config/nvim


Add marginTop to dev account list

What if we put it inside a FlatList?

Yeah but I don't think there would be a very significant improvement of performance as already there are only 7-8 items in this list!

You are right. No need for FlatList.
I landed a rework of how Screen works in general. There is a chance this auto-resolves this. Please, give it a try. If not, rebase/rework this one and I'll merge this.

Nope doesn't fix

I'll merge this then, when you rebase 👍

@borisyankov Something is going wrong on the current master, the text in the DevAuthScreen (Administrators & Normal users) are not visible as well!

@borisyankov Updated with flatList!

Cool. I guess any way of implementing it is OK, as long as it works :)


minor fixes and optimizations

Hi, just give you a little push in code readability and optimization. Also fixed a php error because of undefined variable.

Checked this PR today, it's safe and ready to be pulled

Do you have a branch with all your changes applied?

Yes i'm putting everything all together here https://github.com/Cerdic/scssphp/tree/maint/leafo/master but this is a work in progress, I'm still working on the #627 integration wich is at the moment coming with bugs

I cherry-picked the commits from this PR with the exception of 4cc12d6f. Currently, we use explicit use statements. In practice, I find this makes some refactoring easier (e.g., when changing the namespace of a class).


Request: BGPpeers failureDetectionMode feature in non enterprise version

Expected Behavior
Hello,
Do you have plan to add failureDetectionMode feature in BGPPeer crd for non enterprise version?
Refs:

https://github.com/tigera/operator/blob/master/pkg/crds/enterprise/crd.projectcalico.org_bgppeers.yaml#L54
https://github.com/tigera/operator/blob/master/pkg/crds/calico/crd.projectcalico.org_bgppeers.yaml

Current Behavior
failureDetectionMode not available in non enterprise version crd.
Possible Solution
Implement failureDetectionMode in non entreprise version.
Many thanks.

Sorry for no response for so long.
I wasn't aware of that difference. To me, failureDetectionMode seems like something that would be available in Calico too.
The operator is the installer for Calico so I don't really think this repo is an appropriate location to request this additional feature be added to Calico. I think the appropriate repo for this feature request is https://github.com/projectcalico/calico. I'm going to close this Issue since Calico would need this feature added before the operator could include it.


Earth's mean radius

Hi there,
I recently moved from my own distance calculating code to geokit and found that the calculations differ on one point - the earth's mean radius.
Geokit uses a mean radius of 6376.77 km / 3963.19 mi
Wikipedia says 6371 km / 3959 mi (http://en.wikipedia.org/wiki/Earth_radius)
What do you base the current geokit numbers on? Would you be open to changing it?
Keep up the good work!
Martin

Coming here from the oposite angle (been using Geokit for long, now implementing distance calculation in another language).
As far as I can see, this has not been updated yet.
Any reasons for that?

@amuino - I took over maintenance a few years ago but I never went through the "issues". I'm mostly a "pull request" maintainer, so I gladly review and accept/reject pull requests. If someone has done the code locally and wants to submit a PR (with tests) it should get through.


UIImagePickerController+Promise.swift not in pod 4.0

Currently my pod file looks like the following and UIImagePickerController+Promise.swift is not included in UIKit. Is there a way to include it through pod?
pod 'PromiseKit/CoreLocation', '~> 4.0'
pod 'PromiseKit/MapKit', '~> 4.0'
pod 'PromiseKit/MessageUI', '~> 4.0'
pod 'PromiseKit/UIKit', '~> 4.0'

We had to remove this, see #3.
However we probably should update the docs, you can still get this, it's just a separate pod:
https://github.com/mxcl/PromiseKit/blob/master/PromiseKit.podspec#L186

I see. The following worked for me. Thanks a lot!
pod 'PromiseKit/UIImagePickerController', '~> 4.0'

Reopening as we should update the docs.


Tabbed and Mica material Please!

Hi, do we have some plans to support Mica and Tabbed materials?

I don't use Windows, so I won't implement this, but pull requests are always welcome.

Hi, do we have some plans to support Mica and Tabbed materials?

Yes Mica would be great ...

will you be adding PR for this ?

I won't add a PR for this because I'm not familiar enough with C++ to do this.

will you be adding PR for this ?

I won't add a PR for this because I'm not familiar enough with C++ to do this.

C++ or CSS ? if its C++ , i am currently in the process of learning it, can you tell me things that i will have to know to implement this ? i will look them up and see if its possible for me ..

will you be adding PR for this ?

I won't add a PR for this because I'm not familiar enough with C++ to do this.

C++ or CSS ? if its C++ , i am currently in the process of learning it, can you tell me things that i will have to know to implement this ? i will look them up and see if its possible for me ..

DwmSetWindowAttribute - Microsoft Docs
DWMWINDOWATTRIBUTE - Microsoft Docs
I have a commit at https://github.com/frg2089/vscode-vibrancy-continued/commit/421f2f8b07d55aa334b476d90727074e0645587e . but it not worked.

I wish someone can do this, I don't have the tools to make this :(


Interchain tx/db nonce

Description
Removes clientNonce in Interchain Client, and uses dbNonce for transaction uniqueness.
Includes a breaking change to the InterchainTransactionSent event in InterchainClientV1

@coderabbitai review


Reflection spectroscopy

The doppler-shifting and everything would be the same. would just need to make sure the units work out.

yeah, and the difficulty would be on the spectrum side of things.


Empty button shown beneath spinner when latest Facebook SDK is used.

Facebook swizzles a lot and adds targets to buttons in order to track conversions. The previous criteria to show the button was if it had any targets. This PR add that a non empty button title is also required.
#587

Thanks!


fix(plugin-preview): Convert isMobileMode variable to boolean

When use html code element with isMobile prop, it renders wrongly because the isMobileMode variable should be boolean but is an object. This commit forcibly convert isMobileMode to boolean type.
Summary
Related Issue

Checklist

[x] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.杨呈祥 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you take a example? I don't know the bad case.

Can you take a example? I don't know the bad case.

like this:
<code src="@/stories/h5/selector/basic" isMobile={true} />

Mobile mode doesn't work without this commit change.

Thanks, you are right, but I fount another problem:
when we use isMobile props in code element,  the node value is a mdxJsxAttributeValueExpression,
so we can not  use isMobile={false} though you convert it to Boolean.


With multiple attribute specified, sometime it's impossible to delete first item

Happens usually when having multiple choices initially, then adding one/few more, then trying to delete first one.

Closing this down. Please follow the Bug template.


Fixed missing-timeout Pylint rule for client-python #3765

Fixed missing-timeout Pylint rule for client-python #3765 and removed missing-timeout from disable section in pylintrc as well.

What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
(Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.)

Fix: # (issue)
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including

Change in user-facing APIs.
Addition or removal of property keys.)

How was this patch tested?
(Please test your changes, and provide instructions on how to test it:

If you add a feature or fix a bug, add a test to cover your changes.
If you fix a flaky test, repeat it for many times to prove it works.)

@noidname01 can you please help to check this?

The title of PR should also be modified to confrom the rules, for example,
the title for this PR should be "[#3765] improvement(client-python): Fixed missing-timeout Pylint rule for client-python"


tagliatelle: issue with invalid struct

Tagliatelle is unable to detect issue with invalid tags
// MessedUpTags is to validate structtag validation is done
// without it, the tool could let think everything is ok, while it's not.
type MessedUpTags struct {
	// an invalid tag listed in the rule is supported.
	Bad string `json:"bad` // want "struct field tag `json:\"bad` not compatible with reflect.StructTag.Get: bad syntax for struct tag value"

	// an invalid tag not in the rule is supported.
	Whatever string `foo:whatever` // want "struct field tag `foo:whatever` not compatible with reflect.StructTag.Get: bad syntax for struct tag value"

	// a invalid tag supported by the rule, is not hidden by another broken tag
	Mixed string `json:"mixed" foo:mixed` // want "struct field tag `json:\"mixed\" foo:mixed` not compatible with reflect.StructTag.Get: bad syntax for struct tag value"
}

I worked on a fix, I'm about to publish.

Hello,
the goal tagliatelle is not to validate struct tags, there are already linters that manage that.

I agree with you, but it failed to validate an issue with the following code (example)
type Foo struct {
Mixed `json:"mixe" yaml:"mixed` // here the ending quote is missing
}

For me this, this is a legitimate use cases.
tagliatelle may not return information about what the problem is, but I think it should at least report, it cannot analyze the tag.
Because otherwise, it reports there is no problem at all with such a structure

In your example, tagliatelle will find the problem with JSON tag.
json(camel): got 'mixe' want 'mixed'

type Mixed struct{}

type Foo struct {
	Mixed `json:"mixe" yaml:"mixed`
}

Note: in this case, the tag yaml is useless because YAML parser use json tag by default.

But in the following example, the struct tag will be "ignore":
type Mixed struct{}

type Foo struct {
	Mixed `json:"mixe`
}

but I think it should at least report, it cannot analyze the tag.

The reflect API doesn't allow us to see a difference between a missing tag or a malformed tag.

Yes, I use it locally via golang-ci, also tagliatelle.
It's just that I installed tagliatelle directly, and failed to detect something, while doing my tests.
I agree with you and the need to keep your linter simple, so I will close this MR, and the issue, but I will open a new MR to document tagliatelle is not about validating struct, and that structtag is the perfect candidate to do that.


Running in console mode CTRL+C on OSX doesn't exit the process

Using Topshelf 4.0 and Mono 4.8, it appears to be stopping:

Control+C detected, attempting to stop service.
...
The Topshelf service has stopped.

But it doesn't exit the process.

I am experiencing the same issue on Server 2016. The service is stopped, but the process (e.g. the actual executable) is still running and I can see it in Task Manager.
How should I configure the service to always exit process after service is stopped?

I also have this problem on Windows 10. After running stop uninstall the process is still running and the service stays in the list. Ending the process from the task manager finishes the job, but this step shouldn't be necessary.

Yes, that's exactly the problem, but I don't know how to fix it...

I am closing all issues that haven't seen any activity. You're welcome to submit a PR to resolve the issue or provide more information.


fix repl freezing when typing C-

I made some changes to solve the problem of repl freezing when typing Ctrl-right/left arrow. I'm used to these key bindings in emacs and muscle memory makes linedit unusable for me, since the terminal suddenly becomes unresponsive.
I bound C-right to forward-sexp and C-left to backward-sexp.
I also added the clear-screen (screen refresh as in emacs) command (bound to C-l)
and new-sexp (bound to M-N)

I should add that I'm on linux (debian), don't know how my changes affect mac users


[strong] Strongify files in build/ which are passed to node during the b...

...uild.

These ones are compiled w/ node when building Traceur and should be safe to strongify, afaics.

LGTM


Datepicker: scroll page enable on iOS

When the Datepicker is open on iOS devices with Safari, users can still scroll the web page. This behavior is not permitted on other browsers for desktops and android devices.
It seems that the CSS property pointer-events used on the element with the class cdk-overlay-backdrop is not working in this environment.
I am using Angular 7 and it has been behaving this way since I have been using that feature a year ago. So, this is not version related.

Hello @laurent1! I tried this with iOS 13 w/ Safari 13 and it looks like with an open datepicker the only visible scroll was due to the iOS scroll bouncing/elastic scroll. Is that what you are referring to, or do you see cases where the full page can be scrolled (i.e. also actual content and it persists scroll position)

Closing as it seems to be working as expected on my end. Please let me know if you have more information. happy to re-open! thanks!


Add an option to include in-kind values in export of donations and distributions

Summary
Add an option to include in-kind totals for each item in exports of donations and distributions
Details

Add an option on the organization level to include in-kind values in exports of donations and distributions - Label:  "Include in-kind value in donation and distribution exports?'  Default it to no.  The question shsould go before Distribution Email Content on  the organization view/edit,
Adjust donation export to include in-kind totals for each item on each donation, interleaved with the item quantities,  when that option is true
Adjust distribution export to include in-kind totals for each item on each distribution, interleaved with the item quantities, when that option is true

Origin
Feature request from Austin Diaper Bank, see support channel starting Sept 15, 2024.
Criteria for completion

[ ] tests to support above behaviour
[ ] behaviour as described above
[ ] update user manual to reflect above behaviour

Notes
We checked with the stakeholder circle, and this should definitely be an opt-in,  rather than an all-banks thing.

I don’t fully understand the "In-Kind totals" you mentioned.
There is an "In-Kind Value" column in the exported donation file. Should it be renamed to "In-Kind Total"?
There should be a switch in the "My Organization" page to control whether the exported file includes in-kind value of each item. When the toggle is enabled, should the file include something like the following?

Adult Briefs (Large/X-Large)
In-Kind Value
Adult Briefs (Small/Medium)
In-Kind Value
...

I'm officially off at the moment, so I'm not going to dig .  Please verify whatever I say here against the code.  Wiithout digging,  I suspect that in-kind value in the donation file is the sum of all the in-kind values across the items.
If that's the case,  I'm torn between leaving it alone because someone might be using the title in their further processing, and renaming it for future clarity.    Let's rename it,  but please note in your PR that we will need to do communication to the users about that renaming.

I found two issues:

The donation filters have not been implemented in the export function.
What unit do the values use? Distribution uses dollars, but donations use cents.

These two issues are blocking progress to some extent.

Let's use dollars.    I'll put filtering into our queue as a separate issue.

OK, I will make some changes.

Is it necessary to put a dollar sign before the values?


[Feature]: Generate GitHub Actions for automatic testing and reporting coverage

Feature Title
Generate GitHub Actions for automatic testing and reporting coverage
Is your feature request related to a problem?
No response
Describe the solution you'd like
No response
Additional Context
No response
Optional Labels

[X] HIGH priority
[ ] LOW priority
[ ] good first issue
[ ] help wanted
[ ] wontfix
[ ] question/discussion

Done in the last PR


allow to use a proc to fetch public cert instead of a static url

So some providers (e.g. google/firebase) is using a JSON file to expose multiple x509 public keys instead of one plain file.

In this case, you should implement a custom authenticator proc which also fetches the RSA public keys and caches them respectively. I'm unsure how you determine which RSA key to use for verification for which runtime JWT. But if there is no way to detect it properly, you could probe each one until you find a valid combination.
This functionality could be interesting for others I guess. I will keep this issue open as a feature request. But it is doable with the library and custom code right now.


Bugfix/docstrings indent

some of the docstrings have the wrong indentation which causes the server to throw errors.
Apparently, unlike comments, docstrings are part of the function body in python, so they require that indentation

I branched from where I was working, not master


FAQ follow ups

Extra questions:

why consider using Helia over js-ipfs
why use Helia over the kubo-rpc-client
what mechanisms does Helia have for content and peer routing?
what data transports does Helia have

blog.ipfs.tech/state-of-ipfs-in-js was a snapshot in time. I think we should extract ou the parts that are relevant that are still true. We can point back to it as a historical pointer, but I think that should be a "Related / Historial Items" section likely in the manifesto doc. I think we want this repo to represent the latest state of affairs.

The FAQ now lives in the wiki: https://github.com/ipfs/helia/wiki/FAQ


Revert changes in AbstractPointGeometryFieldMapper

Description
The change made in AbstractPointGeometryFieldMapper class with commit https://github.com/heemin32/OpenSearch/commit/050389736599e40c49278e900d5060f75b959282 introduced a performace degradation during point data indexing. Reverting it therefore.
The change was about consolidating array format parsing code for point type in a single place to acheive following benefits.

Allow plugins to override array parsing logic. Plugins can add its own parsing logic for point field by providing object parser. However, it cannot override array format. Therefore, plugin have to use whatever implemented in AbstractPointGeometryFieldMapper class.
Enhanced code quality by removing duplicated code

There is no change in functionality because 1. There is no change in functionality in OpenSearch and 2. No plugins have its own parsing logic for point data in array format yet.
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/2888
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can you add details to the commit message about why this change was made originally and why it is safe to revert it without impacting any functionality?

ACK

Test Result (2 failures / +2)
org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials}
org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials}
Related issue: https://build.ci.opensearch.org/job/gradle-check/6880/console

@heemin32 Do you have an issue to re-add this code without the performance penalty?

@dblock Could you create backport 2.x PR?

[Backport 2.x] Revert changes in AbstractPointGeometryFieldMapper #5260

That was https://github.com/opensearch-project/OpenSearch/pull/5260 already I believe.


Open file or Open folder open a file explorer window behind all others

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Version: 1.83.1
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:45:31.402Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.14.0-1054-oem
OS Version: Ubuntu 22.04.3 LTS

Steps to Reproduce:

Open a vscode window
Use vscode keyboard shortcut or menu to open a file or a folder
The vscode window loose the focus, but the file explorer window open behind other windows.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.84.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/duplicate https://github.com/microsoft/vscode/issues/146422


Change json schema to allow trailing commas in dprint.jsonc

In a dprint.jsonc file in vscode there will be yellow squiggly underlines/warnings if there are trailing commas:

It is improper to warn about the trailing commas. Dprint will insist on putting the trailing commas there itself when running with default settings, and rightly so, in my opinion.
This is easily fixable. I created a workaround by adding this to my .vscode/settings.json file
  "json.schemas": [
    {
      "fileMatch": ["dprint.jsonc"],
      "schema": {
        "$ref": "dprint://schemas/config.json",
        "allowTrailingCommas": true,
      },
    },
  ],

That solves the problem, getting rid of the yellow squigglies and warnings, but there is no reason why "allowTrailingCommas": true can't be in the json schema by default. Let's add it to the json schema (which is partially defined in this vscode plugin and partially defined... elsewhere).
Note: I got the idea of augmenting the json schema with "allowTrailingCommas": true from https://github.com/microsoft/vscode/issues/102061#issuecomment-657080963 so it looks like this is an approved strategy.

Should be fixed now. I'll do a release later. Thanks!


feat: add morse code lolifier

close #18
Enjoy, example of online translator to play with http://morsecode.scphillips.com/translator.html (among many)

Issue #18 is assigned and in WIP, we are providing our own morse translator in another library

Sorry, but as Claude said, this lolifier is already in WIP status (https://github.com/lebris/morse)
I have to close this pull request.
Anyway, thanks for your contribution ;)

Oups, sorry i hadn't saw that claude was assigned (github newbie). Don't hesitate to look at it though, morse code is actually quite easy. I picked the symbol mapping somewhere on the web. Then some regexes did the trick.


⚠ Bofrost.nl has degraded performance

In 62d6416, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1557 ms

Resolved: Bofrost.nl performance has improved in f4c6186.


fix limit should not push into PartitionTopN when window's following frame is not current row

What problem does this PR solve?
limit should not push into PartitionTopN when window's following frame is not current row
Check List (For Author)

Test

[x] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


XSalsa20 under CI?

I see no mention of XSalsa in salsa-family/Makefile

Following this here: https://github.com/mitls/hacl-star/issues/79


Can this framework be added to the test?

https://github.com/steebchen/prisma-client-go
can join prisma into this test ?

@athxx yes it can be added. Free feel to contribute


Collapsing animation customisation feature

Hello! I'm trying to add some additional alpha animation to collapsing annotationViews animation, but it seems CKClusterManagerDelegate doesn't provide proper methods to do this. By using 'clusterManager performAnimations' delegate method  I can only manipulate animation code blocks but not the annotations that are going to animate.
I found a workaround for expanding animation simply by animate alpha separately in  mapView(_ mapView: MKMapView, didAdd views: [MKAnnotationView]) :
func mapView(_ mapView: MKMapView, didAdd views: [MKAnnotationView]) {         views.forEach { (annotation) in             annotation.alpha = 0.01             UIView.animate(withDuration: 0.5, animations: {                 annotation.alpha = 1.0             })         }     }
But I can't found a workaround for fade out animation on collapsing.
I need this because I have different shapes of annotationViews and the collapse animation because of that,  looks a little bit weird.
Please, add the ability to customise animations.

@mrfonda @l2comdev See https://github.com/hulab/ClusterKit/pull/80


macOS landing page still says 0.62

ref: https://github.com/microsoft/react-native-macos/issues/673#issuecomment-763869905

Waiting on push of 0.63 version of macOS docs. @acoates-ms has this part pending waiting on that (planned to do along side 0.64 RNW).


Gradient as a token is not applied

Describe the bug
I have the following color token: linear-gradient(105deg, rgba($color.tint.0, 1) 20%,  rgba($color.tint.0, 0) 65%)
When I apply it, nothing happens.

Here's the message I get in console:
www.figma.com-1660224422275.log

@surfinzap I tried to reproduce this, with the same formula you are using, only with my own color tokens and that seems to be working properly. Can you check if color.tint.0 is configured properly? You should also be able to see a preview of the gradient in the token.

Yeah, the color is configured properly, I can see the preview and how the variables are evaluated. Only the gradient is not applied. Let me know if there is anything else I can provide to help you investigate the issue.

This problem was caused by an extra space in the value:
Doesn't work: linear-gradient(105deg, rgba($color.tint.0, 1) 20%,  rgba($color.tint.0, 0) 65%)
Works: linear-gradient(105deg, rgba($color.tint.0, 1) 20%, rgba($color.tint.0, 0) 65%)
@six7 would this be something we could tackle with error handling or stripping out the extra spaces?

This problem was caused by an extra space in the value: Doesn't work: linear-gradient(105deg, rgba($color.tint.0, 1) 20%, rgba($color.tint.0, 0) 65%) Works: linear-gradient(105deg, rgba($color.tint.0, 1) 20%, rgba($color.tint.0, 0) 65%)
@six7 would this be something we could tackle with error handling or stripping out the extra spaces?

those are the exact same gradients, can you paste again?

@six7 let me paste it as a monospaced font to spot the difference:
⛔: linear-gradient(105deg, rgba($color.tint.0, 1) 20%,  rgba($color.tint.0, 0) 65%)
✅: linear-gradient(105deg, rgba($color.tint.0, 1) 20%, rgba($color.tint.0, 0) 65%)

I'll close this in favor of a more structured token input via #1199


fix recursion error

Fix recursion error with update to sceptre v2.1.2
https://github.com/cloudreach/sceptre/issues/558
Requesting a pull to Sage-Bionetworks:master from zaro0508:fix-recusion

Write a message for this pull request. The first block
of text is the title and the rest is the description.

not sure what happened here but this PR is messed up

The template looks weird... But the content looks fine.