feat(python): add ignore_missing to async drop_table() method

The sync method has this:
https://github.com/lancedb/lancedb/blob/37c359ed40e860d8f2eec3b72e53ab91a6ad82c8/python/python/lancedb/db.py#L495-L512
But the async method does not:
https://github.com/lancedb/lancedb/blob/37c359ed40e860d8f2eec3b72e53ab91a6ad82c8/python/python/lancedb/db.py#L889-L897
Note that the sync one is a wrapper around the async one, so if you move the implementation to the async, you can remove it from the sync one.

Hi @wjones127
I came across this issue and would like to work on resolving it. Could you please assign it to me?


Add bitcoind channels, lnd pending/total sats

CHANGE 1
Cleaned up the repeated instances of "/usr/local/bin/lncli --macaroonpath=${macaroon_path} --tlscertpath=${lnd_dir}/tls.cert"
CHANGE 2
Added in/out channels on bitcoind (As requested here: Stadicus#370)
CHANGE 3
Added balance locked in Pending Channels.
The importance of this is recognised by anyone that has had to do a lncli closechannel --force. The channel's csv_delay value may cause the pending balance to be locked up for a period of 1 week (or more). Seeing the funds are 'pending' is a bit less likely to cause panic.
CHANGE 4
Added a grand total of sats in

wallet
channels
pending on-chain transactions

Hi i tried it and it works. thanks

It is ok! Great improvement


Add Error handling for 4XX as API response

Done. But Java Client generator doesn't support custom errors from openApi it still only throws ApiException and not my custom exceptions


device view dumb components

@keybase/react-hackers

@cjb updated

:thumbsup: you could import this instead if you want to:
export type DeviceType = 'mobile' | 'desktop' | 'backup'


Allow excon 1.x and require base64 for modern rubies

This PR updates the gemspec to:

Allow excon 1.x
Update excon minimum to 0.97, which appears to have already been required anyway
Require base64 to silence the deprecation warning on Ruby 3.3

Local tests have been flaky and the swarm tests don't seem to run with my dockerd at all. However, apart from the swarm tests, I was able to get everything else to pass once. That might require updates to some of the GitHub URLs. I've excluded those updates from this PR as I'm not sure if they are really required or not. I'm happy to add them to the PR if that'd be helpful.

Hi @zarqman , thank you for this PR, your contribution is appreciated.
I believe some responses changed from 1.43 to 1.46, that would require some refactoring of the tests so that they pass. We can either add it to this PR or merge another branch before merging this one. In any case, we might also bump bundler version as the pipeline is not working at all.
Any thoughts on bumping min ruby version to 3.0  instead of 2.3 ?

Let's group all versioning modification in this PR. If you can manage to fix the tests too, it will be welcomed.
I acknowledge that tests have always been inconsistent. Maybe this is something to be improved later (in the form of simplification).
For the API version, this is what we have in the documentation:

A given version of the Docker Engine SDK supports a specific version of the Docker Engine API, as well as all earlier versions.

The Docker API is backward-compatible, so you don't need to update code that uses the API unless you need to take advantage of new features.

And, more important:

When using curl directly, specify the version as the first part of the URL. For instance, if the endpoint is /containers/ you can use /v1.46/containers/

Source: https://docs.docker.com/reference/api/engine/
But I'd like to implement this part in a separate PR.

Hi @zarqman
Support to older API versions is implemented with #9.
I had to make a few adjustments to pass the tests, everything should be good to go now.
You can rebase your branch to integrate these changes. Is it possible to upgrade minimum excon version to 1.x instead of 0.97?
I'll wait for this PR to release a new version. Thank you.

Rebased and Ruby bumped to 3.0. I took the liberty to cleanup some Ruby warnings too.
Between #9 and a couple other minor changes, tests run and pass on both excon 0.97 and 1.1.1.
Since excon was at 0.x for so long, and some other gems still have it locked to 0.x, I left the excon minimum at 0.97. dockerapi's usage of excon is pretty basic and both 0.x and 1.x work fine for now.
Let me know if anything else needs to be changed.

Just one thing, encapsulating print_response_to_stdout gives an error if we call the getter without initializing the variable:

Good catch. Fixed!

Thank you @zarqman


Replace over 16 question age question

What is the context of this PR?

Trello Card
Change the date of birth lms question.

How to review

Run lms with different people in 'who lives here' (1, 2, 5 etc)
Spec attached to card

There are 5 questions... ( Date of birth -> Age -> Sex -> Marital Status -> Nationality )
If DOB and Age aren't answered, then the 3 others should be asked.
If DOB is answered, Age should be skipped and if they're younger than 16, skip marital status and go to Nationality.
If DOB not answered, but Age is answered and if they're younger than 16, skip marital status and go to Nationality.

Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

Rebase needed @dcdarrell9


Expose more underlying sharp methods

I need to do a little more image transformation (transparent PNG to colored-background JPEG, for example) than is currently exposed through the plugin. This PR adds the methods I'm using.

Hi @PizzaBrandon,
Thank you for your interest in improving gulp-responsive! :+1:
I think the following changes are necessary:

expand the default config by new options https://github.com/PizzaBrandon/gulp-responsive/blob/master/lib/config.js#L60
add a check to the flatten option to avoid setting true by default https://github.com/PizzaBrandon/gulp-responsive/blob/master/lib/sharp.js#L55
add some kind of rename management to allow using the following config:

{
  'logo.png': {
    jpeg: true
  }
}

and get logo.jpg in output if rename option was not specified

Thanks. I'll look into this soon.

@PizzaBrandon
I think format/rename options are most difficult part of this PR, so PR can be divided into two parts:

background, embed, max, flatten - almost done
and output format option

it allow us to add new features as soon as possible :wink:

Closing since it seems I won't be able to get back to this for a while still.


Update minimum PHP version in German

As in e9046cf8eb2851a81808de176d8591825d47f412, this updates the minimum required PHP version in the German docs.

Thanks for the PR @MatzeKitt !

Thanks for the PR @MatzeKitt !


Responsive Navigation Menu

Fixes #1693
Adds a commit to #1725
@pavanjoshi914 please check if this PR is working fine. I made some changes to your PR.
@abstrekt please review.

@satu0king everything looks good

but if we increase username size for smaller windows it will collapse on left-aligned nav-items (I will fix that)

username contains dropdown which also contain signout button,for user convinience isn't  it should be visible at any view ?
also same class is applied to sign in button this will hide, sign in button  for smaller views

<EMAIL_ADDRESS>
@satu0king everything looks good

but if we increase project name size for smaller windows it will collapse on left-aligned nav-items (I will fix that)

A small suggestion:-
username contains dropdown which also contain signout button,also same class is applied to sign in button hiding username for smaller views will hide, sign in button and signout button also for smaller views
From user point of view isn't it better to have them visible for all views?
What's your opinion about it @abstrekt ?

@nitin10s

I will make the change and merge @pavanjoshi914
@abstrekt @nitin10s. We will need to undertake mobile support as a separate task as there is a lot more to do, we will handle fine tuning at the time.

I will make the change and merge @pavanjoshi914
@abstrekt @nitin10s. We will need to undertake mobile support as a separate task as there is a lot more to do, we will handle fine tuning at the time.

ohk sure sir....
plzz also have a check on this ,
visiblity hidden is not vanishing  the block of username. when cursor goes through that  block area   ,cursor changes from arrow to hand

@pavanjoshi914 can you raise a new PR to fix this please?

@pavanjoshi914 can you raise a new PR to fix this please?

transferred commits to #1858


Suggestion: docs(nextjs): The example using client components should delcare client and ssr inside the function component instead of outside it.

In the docs for Next.js SSR, there is this example:
// app/client/layout.tsx
'use client';

import { UrqlProvider, ssrExchange, cacheExchange, fetchExchange, createClient } from '@urql/next';

const ssr = ssrExchange();
const client = createClient({
  url: 'https://trygql.formidable.dev/graphql/web-collections',
  exchanges: [cacheExchange, ssr, fetchExchange],
  suspense: true,
});

export default function Layout({ children }: React.PropsWithChildren) {
  return (
    <UrqlProvider client={client} ssr={ssr}>
      {children}
    </UrqlProvider>
  );
}

However, as written, the server develops a cache across requests, since ssr and client are declared outside of any react component. These should be moved to inside of the component, so that a new client is used for each new request on the server side.
// app/client/layout.tsx
'use client';

import { UrqlProvider, ssrExchange, cacheExchange, fetchExchange, createClient } from '@urql/next';

export default function Layout({ children }: React.PropsWithChildren) {

  const ssr = ssrExchange();
  const client = createClient({
    url: 'https://trygql.formidable.dev/graphql/web-collections',
    exchanges: [cacheExchange, ssr, fetchExchange],
    suspense: true,
  });

  return (
    <UrqlProvider client={client} ssr={ssr}>
      {children}
    </UrqlProvider>
  );
}

(I may also be misunderstanding something around ssr, and if that's the case please let me know. However when I followed the docs as listed, I ran into caching issues)

That is a very good point, we should move that to a useMemo as well I suppose 😅 the most important one in this case would be to re-create the ssrExchange as that would be the one persisting data across invocations if the server lives for multiple requests.


"Tămășeu, Niuved, Parhida, Satu Nou" are villages in "Tămășeu" commune, "BIHOR" county

Description
When an user search a location, this appear in the drop-down menu
according to the law
Precondition
The website ( https://peviitor-ro.github.io/ui.orase/ ) is up an running.
Empty the search bar after every step

Steps 1
Write "Tămășeu"
Expected result
In the drop down menu you find "Sat Tămășeu, BIHOR(Tămășeu)
Comuna Tămășeu, BIHOR"
Test Data
Tămășeu

Steps 2
Write "Niuved"
Expected result
In the drop down menu you find "Sat Niuved, BIHOR(Tămășeu)"
Test Data
Niuved

Steps 3
Write "Parhida"
Expected result
In the drop down menu you find "Sat Parhida, BIHOR(Tămășeu)"
Test Data
Parhida

Steps 4
Write "Satu Nou"
Expected result
In the drop down menu you find "Sat Satu Nou, BIHOR(Tămășeu)"
Test Data
Satu Nou


Inaccurate Token progress model display

The token progress model should only show the names of the 3 steps when initiated at first and as the user approves the transactions and the swap progresses it should give feedback with the checkmarks and text.
(Last unsolved item of #57)

Here is the clickable prototype for this flow that shows the animation: https://www.figma.com/proto/PDSTzKx3Ljs4JNWbhMhye3/Tezex?node-id=542%3A14378&scaling=min-zoom&page-id=109%3A0&starting-point-node-id=542%3A13973&show-proto-sidebar=1


Typo in workbench.startupEditor readme description

VS Code Version: 1.57.0 Insiders
OS Version: Windows 10

'ccnfiguration' -> 'configuration'

Thanks, fixed via #127893.


Implemented OTP Length Selection in OTP Generator Project

🔴 Title : Implemented OTP Length Selection in OTP Generator Project
🔴 Description: Previously, the OTP generator project did not have an option for users to select the length of the OTP. I have now added a feature that allows users to choose their preferred OTP length (4, 6, or 8 digits) through a dropdown menu or even manually entering a number. This enhancement provides users with greater flexibility, as they can now generate OTPs tailored to their specific needs.
Screenshots 📷
Before:
screen-capture.webm
After:
screen-capture (1).webm

✅ Details to Include When Taking the Issue:
Name : Sneha Tiwari
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.): GSSOC, Hacktoberfest

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

@iamrahulmahato please review this PR and add suitable tags

@snehhhcodes mention the issue no

@iamrahulmahato #1474


Add drag n drop

Move blocks using drag n drop instead of point and click.
Logic stays the same (always move block below other block), just different ui.

This will probably add a lot of complexity, and is not very helpful now that we have block mode.
Since moving using drag n drop is good for moving blocks a short distance, and block mode is much faster for that.
The editor is now kept mainly for moving code long distances, that probably require scrolling, and scrolling with drag
n drop is never a fun experience. Better to just keep the current point and click behavior.
Unless requested, this feature won't be implemented.


If there is entity under hidden entity the entity will be hidden as well

When selected to not render players, if there is an NPC underneath of them the NPC will also not render.

I don't think this is possible to fix as the way Entity hider works is by simply not rendering something. Had the player been rendered the NPC would still be hidden from view which means it was never going to be rendered. We cannot force render an NPC, or at least I don't think we can.

I have a surprisingly small fix for this. Requires edits internally before it can be PRed to GitHub though.
https://gfycat.com/EverlastingLargeAlbino


make toggle button for log type filter on/off consistent in their beh…

…aviour
Before this commit the button group would behave differently on what happens when it is on or off and what happens when on or off is clicked again respectively.
With this commit, the button, which is clicked is always the active one, even though it was active before.
Ref:
https://discord.com/channels/685692524442026020/706075642885832764/1318593170354868285

What is the cause by the way?

What is the cause by the way?

A toggle group can have the "no button is enabled" state. In exclusive mode (where otherwise only one item can be enabled), this means a value in the onChange handler of null. null in our code meant off (we check if value is on). I think it is a different idea of ToggleButtonGroup. I would've expected to "toggle between buttons", however, it seems you can still enable and disable different toggle buttons 🙈
However, the doc indicates it pretty clearly, once I read it is was obvious 😅
https://mui.com/material-ui/api/toggle-button-group/

value of the selected buttons. When exclusive is true this is a single value; when false an array of selected values. If no value is selected and exclusive is true the value is null; when false an empty array.


perl: add .withPackages

implement perl.withPackages after python and lua

Tested on simple cases but might need review and more testing
$(nix-build -E "(import <nixpkgs> {}).perl.withPackages(p: [p.XMLParser])")/bin/perl \
  -MXML::Parser -e 'print $XML::Parser::VERSION'

test-driver with
      environment.systemPackages = with pkgs; [
        (perl.withPackages(p: [p.XMLParser]))
      ];

Fixes https://github.com/NixOS/nixpkgs/issues/59042

There are some perl modules which made using regular stdenv.mkDerivation (not buildPerlPackage), so they miss passthru.perlModule and are not compatible with perl.withPackages
I hit the problem with rrdtool and nix.perl-bindings, but there are more
Candidates are: net-snmp, dpkg, minin, git, monotone, rxvt, xscreensaver, slimserver, zoneminder, libapparmor, ...
Anyway, it is not a problem until we will start to replace $PERL5LIB manipulation with perl.withPackages

Eventually toPerlModule can be applied to those, but in my opinion that can be out of scope of this change. Also, some may also not be of interest to use as a module in an env.

Yes, maybe only the first commit is to merge, and the rest is for a new PR

I breaks nothing, so may be backported to 19.03 too

@volth you're incredible! Thank you for writing this.
Having an issue at the moment when I try to include some local perl modules. I'm likely doing something silly, but can't spot it at the moment. Here is my overlay file:
self: super: rec
{
  # pull in volth:perl-with-packages
  perlInterpreters = super.callPackages /home/andersea/nixpkgs/pkgs/development/interpreters/perl {};
  inherit (perlInterpreters) perl528 perldevel;

  perl528Packages = super.recurseIntoAttrs perl528.pkgs;
  perldevelPackages = perldevel.pkgs;

  perl = perl528;
  perlPackages = self.perl528Packages;
}

and relevant parts of my configuration.nix:
let
  # some perl module a developer here wrote
  Local = pkgs.perlPackages.buildPerlPackage rec {
    name = "Local-1.0";
    src = /home/andersea/Code/Local/Local;
    propagatedBuildInputs = with pkgs.perlPackages; [ Carp CGI Exporter IO MLDBM SpreadsheetParseExcel TextCSV_XS TimeLocal ];
  };
  LocalLDAP = pkgs.perlPackages.buildPerlPackage rec {
    name = "Local-LDAP-1.0";
    src = /home/andersea/Code/local-ldap/Local-LDAP;
    propagatedBuildInputs = with pkgs.perlPackages; [ NetLDAP FilePath Storable Encode MIMEBase64 MathBigInt ];
  };
  LocalSQL = pkgs.perlPackages.buildPerlPackage rec {
    name = "Local-SQL-1.0";
    src = /home/andersea/Code/local-sql/Local-SQL;
    propagatedBuildInputs = with pkgs.perlPackages; [ DBI DBDmysql ];
  };
in
  environment.systemPackages = with pkgs; [
    (perl.withPackages (p: with p; [
      Local
      LocalLDAP # another local perl module
      LocalSQL # and another
      CGI
      DataDumper
      DBDsybase
      DBDmysql
      DBI
      ImageSize
      IOSocketSSL
      MathBigInt
      MIMEBase64
      MIMELite
      NetSFTPForeign
      URI
      URIFind
      CGIMinimal
      HTTPMessage
      JSON
      LWP
      LWPProtocolHttps
    ]))
  ];

and finally the error:
sudo nixos-rebuild test
building Nix...
building the system configuration...
these derivations will be built:
  /nix/store/zd9d36w4pbviw0cxsm6qr87wr7f44yhl-perl-5.28.1-env.drv
  /nix/store/z7ydwmj5ria0i4fd02q2p1649rjv9fmx-system-path.drv
  /nix/store/yqzj12xkhhrlca4iy5p7b9myqd0znq6j-dbus-1.drv
  /nix/store/w64r8xbnxhvlx25gyx87zc29vqjj1zd6-unit-dbus.service.drv
  /nix/store/2kclngmy20942n0lvspnva6c4p2yqixh-user-units.drv
  /nix/store/b23nn6dlyyj7p7qi6cjk07nzp0a0wjw2-unit-systemd-fsck-.service.drv
  /nix/store/nbh0m33ybrgkvz0m6kjsr7crgdyn754k-unit-dbus.service.drv
  /nix/store/vvvxlrgcqg2m8r60fmxrbsxp2bnh7k3d-unit-accounts-daemon.service.drv
  /nix/store/vyw0l0nwbv6m2vzkqpa9ws5ky8yi1cbh-unit-polkit.service.drv
  /nix/store/vm9nr7q1hx5925h0638gg1ngri2r6lxm-system-units.drv
  /nix/store/lnl0cvqiba7vjn5zfc0fdrlfvcbl93ak-etc.drv
  /nix/store/nkdbn8ih7j88z48lh4ihs0j0khaxfyfz-nixos-system-gjh393-19.03beta172025.91fa6990b25.drv
building '/nix/store/zd9d36w4pbviw0cxsm6qr87wr7f44yhl-perl-5.28.1-env.drv'...
collision between `/nix/store/yjzba2jc4ivgsvbczc7fivc8rjga2mqa-perl5.28.1-Encode-2.98/share/man/man1/enc2xs.1.gz' and `/nix/store/ym08x87iqakxnk5v9n4cdb27xdwn4gpf-perl-5.28.1-man/share/man/man1/enc2xs.1.gz'
builder for '/nix/store/zd9d36w4pbviw0cxsm6qr87wr7f44yhl-perl-5.28.1-env.drv' failed with exit code 25
cannot build derivation '/nix/store/z7ydwmj5ria0i4fd02q2p1649rjv9fmx-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yqzj12xkhhrlca4iy5p7b9myqd0znq6j-dbus-1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vvvxlrgcqg2m8r60fmxrbsxp2bnh7k3d-unit-accounts-daemon.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vyw0l0nwbv6m2vzkqpa9ws5ky8yi1cbh-unit-polkit.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/b23nn6dlyyj7p7qi6cjk07nzp0a0wjw2-unit-systemd-fsck-.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nbh0m33ybrgkvz0m6kjsr7crgdyn754k-unit-dbus.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w64r8xbnxhvlx25gyx87zc29vqjj1zd6-unit-dbus.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vm9nr7q1hx5925h0638gg1ngri2r6lxm-system-units.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/2kclngmy20942n0lvspnva6c4p2yqixh-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lnl0cvqiba7vjn5zfc0fdrlfvcbl93ak-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/nkdbn8ih7j88z48lh4ihs0j0khaxfyfz-nixos-system-gjh393-19.03beta172025.91fa6990b25.drv': 2 dependencies couldn't be built
error: build of '/nix/store/nkdbn8ih7j88z48lh4ihs0j0khaxfyfz-nixos-system-gjh393-19.03beta172025.91fa6990b25.drv' failed

Anything you can easily spot?

that's great ! having some more homogeneity is good. And yeah there will be some caveats but there is time before the next release to polish things out.

@aanderse fixed

@volth I have tested:

[x] installing perl.withPackages [ ... ] system wide with a large number of perlPackages works as expected
[x] incron is able to utilize this system wide perl when running scripts that use #!/usr/bin/env perl as the shebang
[x] cgi scripts are able to utilize the system wide perl when running scripts that use #!/run/current-system/sw/bin/perl  as the shebang
[x] many random scripts that have been written over the years which are executed via perl script-name.pl or have #!/usr/bin/env perl as the shebang work properly
[x] apacheHttpd with mod_perl has no regressions, tested using several large pieces of existing perl code in my organizations infrastructure (note: services.httpd.extraConfig = ''SetEnv PERL5LIB ${lib.makeFullPerlPath (with pkgs.perlPackages; [ ... ])}''; was used to provide the perl environment)

that's great ! having some more homogeneity is good. And yeah there will be some caveats but there is time before the next release to polish things.

@teto I would argue perl on nix has some serious shortcomings (that I've recently become aware of) that @volth has corrected here. Consider this failure:
~> nix-shell -p perlPackages.DataDump --run 'perl -e "use Data::Dump; dd localtime;"'
Can't locate Data/Dump.pm in @INC (you may need to install the Data::Dump module) (@INC contains: /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/site_perl/5.28.1/x86_64-linux-thread-multi /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/site_perl/5.28.1 /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/5.28.1/x86_64-linux-thread-multi /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/5.28.1) at -e line 1.
BEGIN failed--compilation aborted at -e line 1.

With sufficient testing I would like to see this included in 19.03. Consider it a bug fix.

Consider this failure:

~> nix-shell -p perlPackages.DataDump --run 'perl -e "use Data::Dump; dd localtime;"'
Can't locate Data/Dump.pm in @INC (you may need to install the Data::Dump module) (@INC contains: /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/site_perl/5.28.1/x86_64-linux-thread-multi /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/site_perl/5.28.1 /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/5.28.1/x86_64-linux-thread-multi /nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/lib/perl5/5.28.1) at -e line 1.
BEGIN failed--compilation aborted at -e line 1.

It was broken by https://github.com/NixOS/nixpkgs/pull/38791, which I undid in my branch and maintained so. With perl.wtithPackage it is no longer needed

Please avoid a merge and rebase instead. Other than that, I think it would be good to get it in.

A good testcase would be perl.withPackages(p: [ ...all non-broken perl packages... ])
There might be more packages like perlPackages.Encode

Thanks everyone, especially @volth!
What is the plan for a 19.03 backport?

Added the "needs: port to stable" tag to keep track of it, need to catch-up with this issue and judge still.

@samueldr I think we should backport this, because it makes it possible to work around the problems introduced in https://github.com/NixOS/nixpkgs/pull/38791, which is very much needed

I think we should backport this

Then together with https://github.com/NixOS/nixpkgs/pull/60028, which is kind of bugfix for this PR

@Infinisil I keep in memory the optimization task. There is just an endless stream of fixes which conflict with the refactoring (https://github.com/NixOS/nixpkgs/pull/59997 https://github.com/NixOS/nixpkgs/pull/60028 https://github.com/NixOS/nixpkgs/pull/60171 https://github.com/NixOS/nixpkgs/pull/60238, now https://github.com/NixOS/nixpkgs/pull/60861)


ci: add PR preview

fixes: https://github.com/envoyproxy/gateway/issues/1009
see demo: https://github.com/zirain/gateway/pull/1
require two action secrets:

NETLIFY_SITE_ID
NETLIFY_AUTH_TOKEN

more usage can be found: https://github.com/nwtgck/actions-netlify

Secrets have been added.

Netlify credentials not provided, not deployable


TN-2287 followup fixes - display error when completion date is not within window

Followup fixes for this story:  https://jira.movember.com/browse/TN-2287
Noting where testing that when completion date entered was not within expected window,  error message did not display as would have expected - only seeing submission button being disabled, which can be confusing to user.
Fixes include:

display error message when completion date for paper manual entry is not entered within a valid PROM window
reset error message to null instead of empty string when clearing error, fix based on previous feedback

will re-open after more thorough testing


A bit more flexible filtering

Hey, I just made a Pull Request!
This is a suggestion of doing filtering. Not done, but i would like some feedback since i'm starting to feel it's getting a bit out of hand. This could be too flexible where you can add as many layers of filtering as you'd like, and allows with a few modifications for different kinds of group filtering. For example show entities that are starred && owned.
The right approach could be to do it way simpler and actually create different pages for each types and figure out how to pass down the correct count in the left filter menu.
Test are broken and there's probably stuff that i haven't cleaned up lying around still. Would like some feedback on the approach before continuing.
:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

@hooloovooo Hey. There are some overlapping changes merged into master. Don't forget to rebase/merge soon. Ping me if there are any uncertainties.

I even think we should pair program this one.

Let's do it! :)


Support to run training or inference without numactl and taskset.

@jerrychenhf Hi haifeng. This PR has been finished. Thanks!


Plugin is cutting off characters when reviewing files

This is what I see with refined-github turned on:

Here's what it should look like (refined-github off):

this should be fixed in the latest release, try updating.
see #1455 #1456 #1457

@Phrynobatrachus Awesome, that worked great. Weird that it hadn't auto-updated for me in Firefox 62, but it was a major version behind.


zdmo_cl_rap_generator_setup doesn't exist

I pulled the project to SAP S/4HANA Cloud but after that I check the class zdmo_cl_rap_generator_setup doesn't exist in branch abap-enviroment.
How should I proceed?

I have the same problem.

Same issue on SAP S/4HANA 2023 (ABAP.758). I even tried to copy the source code of the program from ABAP Cloud Trial (TRL).
It was possible to active it without any error, but it dumped when I ran it, so it was not really a solution.


Timeout

Hi @stephan1827
We're using your modified Python script with our own database fb. We're getting an issue where the python db connector is closing the connection after 60 seconds because of the configured http timeout. However, mpdatabase on the PLC is unaware the connection has closed and still believes it is connected.
Should we be connecting and disconnecting after executing each query or is there something obvious I am missing?

Hi @apinner84,
I think that is just the way it works. The mappDatabase library automatically reconnects when the connection is closed.

Here is a snip of what we are experiencing.

Timeout happened at 14:11:51
PLC tried to execute a query at 14:22:15 that ends in exception code1

What mapp version are you using?
Can you try to set "Connect" back to false when you are connected? Thats what is different from my sample and I also noticed that the CommandDone flag goes back to false in my sample. I am not sure if that makes a difference but its worth a whot.

We're using 5.16
I'll try that modification first. It's also possible that it's being caused by a download to the PLC.

Yes, you always should restart the PLC after changing anything in mapp. The mapp link is expired and will cause weird behavior. Calling it in the exit part of the task sometimes helps, but a restart is the safest option.

Haven't spotted the issue since making your suggested changes. Thanks.


contour pod from multiple CR in the same namespace is conflicted

What steps did you take and what happened:
1. Install operator from main branch.
kubectl apply -f "https://raw.githubusercontent.com/projectcontour/contour-operator/main/examples/operator/operator.yaml"

2. Install Contour (contour-internal and contour-external) in knative-serving namespace
Deploy contour-external
cat <<-EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: contour-operator
  name: knative-serving
---
apiVersion: operator.projectcontour.io/v1alpha1
kind: Contour
metadata:
  name: contour-external
  namespace: knative-serving
spec:
  gatewayClassRef: contour-external-gatewayclass
  namespace:
    name: knative-serving
  ingressClassName: contour-external
  networkPublishing:
    envoy:
      type: LoadBalancerService
---
kind: GatewayClass
apiVersion: networking.x-k8s.io/v1alpha1
metadata:
  name: contour-external-gatewayclass
spec:
  controller: projectcontour.io/contour-operator
  parametersRef:
    group: operator.projectcontour.io
    kind: Contour
    scope: Namespace
    name: contour-external
    namespace: knative-serving
---
kind: Gateway
apiVersion: networking.x-k8s.io/v1alpha1
metadata:
  name: test-gateway
  namespace: knative-serving
spec:
  gatewayClassName: contour-external-gatewayclass
  listeners:
  - protocol: HTTP
    port: 80
    routes:
      kind: HTTPRoute
      selector:
        matchLabels:
          knative-e2e-test: "net-ingressv2"
      namespaces:
        from: "All"
EOF

Deploy contour-internal
cat <<-EOF | kubectl apply -f -
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: contour-operator
  name: knative-serving
---
apiVersion: operator.projectcontour.io/v1alpha1
kind: Contour
metadata:
  name: contour-internal
  namespace: knative-serving
spec:
  gatewayClassRef: contour-internal-gatewayclass
  namespace:
    name: knative-serving
  ingressClassName: contour-internal
  networkPublishing:
    envoy:
      type: ClusterIPService
---
kind: GatewayClass
apiVersion: networking.x-k8s.io/v1alpha1
metadata:
  name: contour-internal-gatewayclass
spec:
  controller: projectcontour.io/contour-operator
  parametersRef:
    group: operator.projectcontour.io
    kind: Contour
    scope: Namespace
    name: contour-internal
    namespace: knative-serving
---
kind: Gateway
apiVersion: networking.x-k8s.io/v1alpha1
metadata:
  name: test-local-gateway
  namespace: knative-serving
spec:
  gatewayClassName: contour-internal-gatewayclass
  listeners:
  - protocol: HTTP
    port: 80
    routes:
      kind: HTTPRoute
      selector:
        matchLabels:
          knative-e2e-test: "net-ingressv2-local"
      namespaces:
        from: "All"
EOF

3. contour pod start running but only from contour-external Contour CR
$ kubectl  get pod -n knative-serving
NAME                         READY   STATUS      RESTARTS   AGE
contour-8846b749f-26gvk      1/1     Running     0          4m41s
contour-8846b749f-mrq5p      1/1     Running     0          4m41s
contour-certgen-main-4w66r   0/1     Completed   0          4m41s
envoy-5g699                  2/2     Running     0          4m41s

But both contour pods have --ingress-class-name=contour-external, not have --ingress-class-name=contour-internal
$ kubectl  describe pod -n knative-serving contour-8846b749f-26gvk |grep ingress-class
      --ingress-class-name=contour-external

What did you expect to happen:
In above case, there are 4 contour pods running the half of them have --ingress-class-name=contour-external and the rest of them have --ingress-class-name=contour-internal.

https://github.com/projectcontour/contour-operator/issues/18 will cover this issue. Closing.


Crash when casting Swift.Error to NSError

PromiseKit version: 4.1.7
Xcode version: 8.3.1
iOS version: 10.3.1

Hi everyone. I have an issue on the reject(error) part. Everything works fine on the debug mode. However on the release version crash occurs on that line. This error occurs on the iOS 10.3.1. Any help would be appreciated.
Thanks.

The problem occurs while casting Custom Error to NSError. I have posted an answer for this problem here: http://stackoverflow.com/questions/43225036/swift-3-1-crash-when-custom-error-is-converted-to-nserror-to-access-its-domain/43362207#43362207

I'm going to leave this open for other people to find.

Despite what the person in that SO thread said, casting a Swift.Error to NSError should not crash, even if you don’t implement the protocol. This is a feature of Swift’s toll-free bridging to Foundation that has existed since Error handling appeared.
I sincerely hope this is not a common issue :/

A sample crash-case would be useful, or some example code, I assume you are using AnyPromise?

I am using PromiseKit like this way:
func fetchAvatar(user: String) -> Promise<UIImage> {
    return Promise { fulfill, reject in
        MyWebHelper.GET("\(user)/avatar") { data, err in
            guard let data = data else { return reject(err) }
            guard let img = UIImage(data: data) else { return reject(MyError.InvalidImage) }
            guard let img.size.width > 0 else { return reject(MyError.ImageTooSmall) }
            fulfill(img)
        }
    }
}

What worked for me is to conform to CustomNSError protocol.

I think I have the same error. The crash seems to have to do with Error.isCancelledError. It crashes only in Release builds and the crash is at the catch. If I use the allErrors catch policy, it doesn't crash. Conforming my error to CustomNSError does fix the crashes as well.
I'll try to build a minimal crashing project.

Sigh, really need to run tests in debug AND release mode, sucks.

@pgrosslicht super thanks, your deduction has helped and I will push this hopeful fix:
            if let ne = self as? CustomNSError {
                return cancelledErrorIdentifiers.contains(ErrorPair(type(of: ne).errorDomain, ne.errorCode))
            } else {
                return false
            }

Tests fail, not a fix. Since apparently NSError does not confirm to CustomNSError. FFS.
Also I cannot actually reproduce this crash. If I run our tests built release with the framework built release, no crashes occur. The tests run over these code paths.
So really I need a test case.
Is it possible this was fixed in the most recent Xcode 8.3.2 update?

@mxcl I have been able to build a minimal reproduction here: https://github.com/pgrosslicht/PromiseKitCrashReproduction
But it seems that this has been fixed in Xcode 8.3.2. The reproduction worked, then I updated and  it stopped working. I removed the workaround from my original app and it worked there as well when compiled with Xcode 8.3.2. So if you want to test the crash, it only works with Xcode 8.3.1.

THE SAME

THE SAME

The same it’s fixed in Xcode 8.3.2 or the same it crashes?

The same it’s fixed in Xcode 8.3.2 or the same it crashes?

I have Xcode 8.3.2 and it crashes anyway with absolutely the same reason

Can you provide a testcase? Otherwise I can't fix this.

Can you provide a testcase? Otherwise I can't verify any fix I attempt works.

Ok, I will do that and notify you in this thread after. As I see now, app crashes if PromiseKit getting the variable "isCancelledError". In other ways it don't crash

I have verified that the provided TestCase does not crash with 8.3.2.
I guess I will try to get hold of 8.3.1 again and see with that.

Yes, agree. I clean cache and try. It does not crash with 8.3.2

Yes, agree. I clean cache and try. It does not crash with 8.3.2

K, great news. I am downloading 8.3.1, just for thoroughness. Will leave open for 2 weeks so anyone else experiencing the crash can easily find this report.

Yes, thank you.

error as NSError cast fails if the error object was created as NSError() (yes, without parameters, Swift allows it for some reason)


Analyzer - Add support to store values of metrics in data diagnosis

Description
Add support to store values of metrics in data diagnosis.

Would you please give an example in description for this feature?


python311Packages.pytest-raises: disable failing tests

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249338 run on x86_64-linux 1

19 packages built:

home-assistant-component-tests.emonitor
home-assistant-component-tests.enphase_envoy
home-assistant-component-tests.gogogate2
python310Packages.aioemonitor
python310Packages.aioemonitor.dist
python310Packages.envoy-reader
python310Packages.envoy-reader.dist
python310Packages.ismartgate
python310Packages.ismartgate.dist
python310Packages.pytest-raises
python310Packages.pytest-raises.dist
python311Packages.aioemonitor
python311Packages.aioemonitor.dist
python311Packages.envoy-reader
python311Packages.envoy-reader.dist
python311Packages.ismartgate
python311Packages.ismartgate.dist
python311Packages.pytest-raises
python311Packages.pytest-raises.dist


⚠ Bofrost.at has degraded performance

In ec200c4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1123 ms

Resolved: Bofrost.at performance has improved in 0432ff9.


Support for complex forwarding pipelines

Original issue opened by @jab1982 at https://github.com/kytos/flow_manager/issues/62.
Current Flow_manager Napp doesn't support complex forwarding pipelines, where more than one forwarding table is available. We need to find a way of expressing the pipeline we would like to use with a fallback option for switches that support a single forwarding table.

flow_manager now has been supporting managing flows on multiple tables, we've also released a new NApp of_multi_table responsible for managing pipelines and specifying on which table which NApp should use.


Document grid! function

In Toggle docs some grid! function is used that is documented nowhere.
Though I can guess its behavior, maybe it 'd be fine for it to be in the API section, or in the Plotting functions section? I don't really know. 😅

I don't really know how to to make it show in the API. I don't mind writing the docstring or whatever explanation with maybe an example, but the Documenter part would be up to you.
What do you think?


WIP: Add NFD Operator resource status checks

Add playbook and role to check for the NFD Operator resource statuses to ensure that the actual NFD Operator resource statuses align with the output of the NFD CRD status output.

/uncc jmencak

/test nfd-operator-e2e-master

@ArangoGutierrez I'll close this PR, it's outdated now and Courtney's gone
/close

the test ^^^ doesn't execute the code of the PR, see this comment:

I don't see any toolbox script nor ci_entrypoint_nfd-operator.sh call to this playbook (the entrypoint should call the toolbox, and the toolbox launches the playbook)

can always be reopened or reworked in a new PR


Improve upload tool user interface

Right now, the upload tool lets a user select a single file from their computer and upload it. Some ideas for improvement

Require that image to upload is a FITS file (fastest way to do this?)
Ask user if the image already exists in an external archive we support, and suggest they link to that instead (TBD...)
Add required fields for the user uploading the file to fill out, such as a checkbox agreeing the image is theirs or otherwise OK to share publicly, a checkbox agreeing to an appropriate creative commons license, and a valid contact email that won't be shared publicly (what else?)
Handle multiple file uploads gracefully (what is a reasonable upper limit?)
Show a progress bar during the upload process
Display the uploaded image(s) when the upload completes, along with the metadata that will be added to the metadata database, with a note saying they should contact us if anything looks wrong

Addressed in https://github.com/dirac-institute/trailblazer/pull/39.
New requests can be opened in the future to address improvements..


Cannot specify server id in speedtest.py like you can do for speedtest-cli

While both cli and py files perform the same functions, why does the py file have no option to specify the server id, like we can specify with the cli as parameter?
Is it possible to include this feature in the py file, so that we can make sure we test the speeds against a specific server, within our python script?

Oops, sorry... I found the way to specify server. Overlooked it in the wiki earlier.


Fix attempt 2

Change description

Removed destructing of config secrets

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Solved by https://github.com/hmcts/idam-user-dashboard/pull/152, closing


Config ignores toml struct tags

If we have a config struct in a plugin like

struct Config {
 Groups []*Group `toml:"group"`
}

Then telegram will fail at the start with could not find field in pluginname.Config matching group.
Most likely, it's caused by #295

@gotyaoi any ideas?

thanks for the report, @gotyaoi could you please take a look at this as soon as possible?

@ekini are there any plugins that currently rely on this behavior?

I'll take a look.

@sparrc although there are some plugins that use struct tags, all of them luckily work correctly,
except my unreleased plugin :)
[ekini@c7 telegraf]$ grep -R toml plugins/ outputs/
plugins/mongodb/mongodb.go:	CaCerts []string `toml:"cacerts"`
plugins/ping/ping.go:	PingInterval float64 `toml:"ping_interval"`
plugins/ping/ping.go:	// Build the ping command args based on toml config
plugins/system/cpu.go:	PerCPU   bool `toml:"percpu"`
plugins/system/cpu.go:	TotalCPU bool `toml:"totalcpu"`
plugins/procstat/procstat.go:	PidFile string `toml:"pid_file"`
outputs/influxdb/influxdb.go:	URLs      []string `toml:"urls"`
outputs/kafka/kafka.go:	RoutingTag string `toml:"routing_tag"`
outputs/amqp/amqp.go:	RoutingTag string `toml:"routing_tag"`
outputs/mqtt/mqtt.go:	Servers     []string `toml:"servers"

Ok, so those work correctly because they are, shall I say, close enough. The merging code currently strips underscores and lowercases to match between a key in toml and a field in the struct. The struct tag is not currently consulted. I'll put in matching on the struct tag.

@ekini Could you please give the patch from https://github.com/gotyaoi/telegraf/commit/d85cf9b9aefb072b8dba3467a01d59a01d490c18 a try? If that works for you, I'll rebase and submit a PR.

@gotyaoi it works, but it matches both "group" and "groups". I'd use something like ekini@600c48abf96506a8a5a6ed125d8648b0369e3df3
Also, I think it's better not to fail when config dir doesn't exist, because .rpm and .deb post-install scripts don't create it, but it's specified in startup script. Please, check ekini@5b96193b755a27b084aabc4ac3f62471ad6104d2

Ah, yes, that definitely makes sense. @sparrc that could probably be taken as is, or I could squash it down into one commit on my branch, whichever you would like.
Regarding the config directory, I think that if it's been specified at the command line, it should be an error if it doesn't exist. In that case, it should probably be created by the packages. I'll put together a commit for that a bit later.

@ekini I think that it's okay for it to error if the directory does not exist. The .deb and .rpm packages should create the directory if it's specified in the startup script.

@gotyaoi if you could squash and submit a PR, that would be easiest for me, thanks!


Simplify InstantRFC3339Module by using StdDateFormat from Jackson.

Trying to simplify #262 a bit.
Ping @martinfridh, @adamvoncorswant and @MrShish, thanks.

I copied the test case changes from #262, but ignored one...

Cool. would you mind keeping the old way of serializing the instant? Then at least, we have explicit code for how we want 'our' format to look like.

Sure thing (actually, I don't know why I changed the serialisation part, probably too late now. 😄), updated and force pushed, @adamvoncorswant.

I'm done, @MrShish and @martinfridh. Feel free to merge. Thanks. 😄

Thanks for merging, 😄

@xiaodong-izettle , you never "released" these changes to local artifactory? do you want to do it, or should I (I guess that how to do it is described in "Release steps" of README)?


Add /data folder back

sry to bother you for an extremely tiny bug,
however, i spend hours to find a software about checking and exporting steam market history , and finally find yours.
as other programmes are either failed to function or difficult to use, your programme gives me great help.Thank you!

Thanks @DiamondMofeng. I will close this pull request, because I decided to resolve this issue another way (see d92dd1e)


feature/fully-implement-expenses-api

Implemented the expenses api as an expess-mongo node project with token-based authentication

Its all systems go.


✨ Switch go package prefixes from edge-mc to kubestellar

This was produced with the following command
(now engineered to exclude the go...pyc file).
find * \( -name "*.go" -or -name go.mod \) | while read fn; do sed -i .bak 's:github.com/kcp-dev/edge-mc:github.com/kubestellar/kubestellar:' "$fn"; done

Summary
This PR modifies the go source files to switch all the package prefixes from github.com/kcp-dev/edge-mc to github.com/kubestellar/kubestellar.  The resulting sources will not build successfully until they reside at the new location.
Related issue(s)
This addresses part, only part, of #539 .

/cc @clubanderson
/cc @pdettori
/cc @francostellari

/retest

/lgtm

/lgtm
/approve


Add GitHub CI (azure pipelines) results to my.cdash.org

@thewtex Matt, do you possibly have a suggestion?
So far I tried the following:
- script: |
    pushd "$(ELASTIX_BINARY_DIR)"
    call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
    MSBuild.exe Experimental.vcxproj -p:Configuration=Release

At Testing/CI/Azure/ci.yml
https://github.com/SuperElastix/elastix/commit/44e0d40986afbd0e43896662c22a26a82066b94d
It did work: https://my.cdash.org/index.php?project=elastix&date=2020-10-08
But it's not really nice, as it requires an extra elastix build, which is quite time consuming! And that YML code is only for MSVC.
Note that our CTestConfig.cmake is already there: https://github.com/SuperElastix/elastix/blob/5.0.1/CTestConfig.cmake

@N-Dekker instead of calling MSBuild.exe, drive the build with ctest.exe, e.g.
ctest -DExperimental -CRelease

For the record, this issue is almost solved now, by @ViktorvdValk  😃


Test Fails in Travis abandonconflict.py

This issue tracker is only for technical/code issues related to goldcoin-core.
General goldcoin questions and/or support requests and are best directed to the https://www.goldcointalk.org/ forums.
For reporting security issues, please contact the Goldcoin developers on the goldcoinproject.slack.com slack channel.
Describe the issue
Is this a bug in the codebase(not a usage issue) that needs to be fixed?
If not please skip to below, otherwise answer the following.
What files need to be fixed? (Please list them all)
abandonconflict.py
What needs to be done?
Fix test case
Why?
https://travis-ci.org/goldcoin/Goldcoin-GLD/jobs/288792236

This python script connects to the daemon to get information and try to make transactions.

We need to get the daemon/client working first before tackling this issue.

Added https://pypi.python.org/pypi/goldcoin-scrypt/1.0.1 package needed by the travis builds.

This is related to issue #7.  We need to have the RegTest set up correctly.

This Issue was renamed because the Travis checks failed completely due to RegTest errors and was not limited to abandonconflict.py.  This issue allies to all tests.

After fixing the unit tests (src/test), more of these tests are passing.

We are getting close.  The qa tests are passing now (the python rpc tests).  However, we are getting this error when running the make check tests.  python cannot be found, though it is found to run the qa tests.

Making check in src

make[1]: Entering directory `/home/travis/build/goldcoin/Goldcoin-GLD/build/goldcoin-i686-pc-linux-gnu/src'

make[2]: Entering directory `/home/travis/build/goldcoin/Goldcoin-GLD/build/goldcoin-i686-pc-linux-gnu/src'

make  check-TESTS check-local

make[3]: Entering directory `/home/travis/build/goldcoin/Goldcoin-GLD/build/goldcoin-i686-pc-linux-gnu/src'

Running test/bitcoin-util-test.py...

make[4]: Entering directory `/home/travis/build/goldcoin/Goldcoin-GLD/build/goldcoin-i686-pc-linux-gnu/src'

pyenv: python3.6: command not found

The `python3.6' command exists in these Python versions:

  3.6

  3.6.1

make[3]: *** [check-local] Error 127

make[3]: *** Waiting for unfinished jobs....

This is due to an issue with Travis-CI.  Found a fix.

The above fix only helps with python 3 errors, which were on all HOST platforms.

Determined that this commit made changes to the Travis tests for windows platforms and caused them to fail because they to not have the zmq library.  #50f8d29a44ef592633f7d4857d9d22e33123e1ef

This still hasn't been resolved due to some intermittent time outs in some commands.
Pull request #28 was created to resolve this issue.


Undefined Variable Error

In score.py, in the method _cleanup_point of the class Part
_self.remove_point is called with o.end, however o is not defined within the scope of the method
I think the intention was to simply pass the parameter tp onto _self.remove_point and that definitely fixes the error, however, not sure if it is intended that way.

I think the intention was to simply pass the parameter tp onto _self.remove_point and that definitely fixes the error, however, not sure if it is intended that way.

Yes, that is the intention. Fixed by https://github.com/OFAI/partitura/commit/a30fda1e21a2c43beaf0a47446b1bdd24c422504


[Enhancement] Support -o also on pulseaudio mode

Looks like selecting the output with -o can used with PulseAudio also, so I am adding support for this.

Relates with this discussion.


Accounts: Adding a user to a meeting has no visual feedback

Problems:
At the moment it's quite hard to recognize, if a user was succesfully added to a meeting via the Account menu. Both ways to do it - user-line/three-dot-menu/add to meetings or via three-dot-menu/multiselect/select user/three-dot-menu/set-remove meeting - lack in visual feedback to easily recognize that the function had worked.
Also, if I want to add a user to a meeting, I can't see in the meeting overview selection, if the user is still part of it.
From my perspective, the UI needs an improvement.
Ideas:

by clicking on the user details an overview should appear, at least for superadmins or admins, to which meeting a user belongs
by opening the selection field of possible meetings, it would be nice, that meetings where the user is part of are marked
at least a dialog field would be nice at the end of the adding process, with a message that indicates success

I guess, this topic needs some discussion, how it can be improved. So feel free to add some ideas :)

Doesn't the Add to meetings page already display a results table if it worked? Could you elaborate how the information given there is unsatisfactory?
Otherwise, I would propose to maybe show a snackbar with "User added to x meetings" or something.
Generally showing meeting participation data somewhere in the account list or the account detail view would also be a possibility, although we would have to think about how we want to display it and the required traffic from the autoupdate service (showing the number of affiliated meetings per user in the account list, as we currently already do for committees would probably be pretty easy to implement, but may somewhat bloat the account list subscription).

This sounds good. I will take a look at it.
I agree with you, an explicit result - some kind of info box - could be nice to. But first i will take a look and check if it works out without a box.

We could also try to show a snackbar when the action is done, similar to the one from motion forwarding: Something like "x users were added to y meetings"

That sounds good to me. The bar should work as a feedback function.
About the content of the message, I'm not quite sure to what extent it can be generally valid. It would be nice to have an exact indication of how many users were added to which events. But that might be too detailed. @emanuelschuetze : A short, general info as suggested by Luisa should be enough, right? What do you think?

#2251 Dupe?

#2251 Dupe?

No


Wrap Yum Update

Would like to wrap yum updates so that if the log level would control the level of output text displayed
General idea
if Log level is less than X
it would run the yum update command with -q (Quiet)
if it is greater than X or equal to it would display all text
May also want to come up with a way to determine on the fly if it should use yum or apt-get

This may be a good way to tell if it is yum or apt
https://unix.stackexchange.com/questions/602840/if-condition-to-check-for-yum-or-apt
#!/bin/bash

if command -v apt-get >/dev/null; then
  echo "apt-get is used here"
elif command -v yum >/dev/null; then
  echo "yum is used here"
else
  echo "I have no Idea what im doing here"
fi


Upgraded project to build with Swift 2.3 and Xcode 8

Took the code through the upgrade wizard and upgraded the project to recommended settings.

Thanks! But I have a branch swift-2.3 that should support 2.3.

Ok great, thanks Caesar

From: Caesar Wirth<EMAIL_ADDRESS>Sent: October 31, 2016 10:17 AM
To: cjwirth/RichEditorView
Cc: JDurantFM; Author
Subject: Re: [cjwirth/RichEditorView] Upgraded project to build with Swift 2.3 and Xcode 8 (#85)
Thanks! But I have a branch swift-2.3 that should support 2.3.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cjwirth/RichEditorView/pull/85#issuecomment-257305306, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVTWjJ3deGaqW1lZx1C8Ke51GXaSspv3ks5q5fh5gaJpZM4KCY_j.


New analyzer code: Null-aware after non-null

Or something similar. While cleaning up existing NULL_AWARE_IN_LOGICAL_OPERATOR instances, I'm seeing a lot of code like this:
var foo = b && c?.d ?? false;

Precedence reveals that this statement is equivalent to:
var foo = (b && c?.d) ?? false;

which makes no sense. p && q is never null, so ?? doesn't make sense there. I'm not certain that this new code would be super useful when we now have NULL_AWARE_IN_LOGICAL_OPERATOR, but... probably?
CC @a14n

I suspect that the author thought it would be equivalent to
var foo = b && (c?.d ?? false);

The new Null Safety feature handles this code. "The left operand can't be null, so the right operand is never executed. • 32523.dart:4:28 • dead_null_aware_expression"


Cant fetch stored parameters more than 10

The library does not retrieve more than 10 stored parameters

Thank you for reporting the issue. This is a bug in the library.
The GetParametersByPath command has pagination by default with a max limit of 10 results according to the doc.

@albertomr86 any timelines if this can be fixed.?

Fixed starting at version 1.2.0


Feature/dynamic index meta path

Store temporary files generated from delta indexer in separate tmp folder in order to not clog up the src folder. The entire tmp folder is also ignored.

I will try to look on this during this week =)

@pkarw - I've added a check to see if the tmp folder exists.

@pkarw - Good catch, now it should be fine I think.


Stvno docker

@stvno I found the underlying issue and I also cleaned up a few more parts of the Dockerfile. Check it out when you have a min.

Pull Request Test Coverage Report for Build 1454

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.4%) to 45.66%

Files with Coverage Reduction
New Missed Lines
%

provider/gpkg/binary_header.go
2
100.0%

Totals

Change from base Build 1448:
1.4%

Covered Lines:
5392

Relevant Lines:
11809

💛  - Coveralls

LGTM


Expressions don't understand Infinity

Infinity in expressions is not treating as Infinity number, but as variable
Plunker
So it even can be override
Plunker

ng-if="reactor.operationTime === Infinity"

IMHO this is a simple expression, at least more than the hack that works for me:
ng-if="reactor.operationTime === 1/0"

Will do some necroposting here. :)
Another use case for that would be like this:
<select ui-select2="{ minimumResultsForSearch: Infinity }">
It doesn't make sense for me to add something onto scope for select2 configuration which is that simple - all I want is just hide search box, that's it. Otherwise I'd have to create controller or directive which would place this config on the scope for me, or to make some existing entity to do it. Then if we consider 3-4 such select2's on the page, and 3-4 is not even close to "many"... No, that's definitely overkill. But I'm using angular 1.5.0 and it still doesn't work. :(

I don't know if works for you, but in my case I use a hack: 1/0

@jjlorenzo Thanks for helping me, I've seen your earlier comment here. It can work of course, but I'm not fond of any kind of hacks if it could be done in a proper way. Also if tomorrow they'll change 1/0 behavior to throw an exception or return zero or whatever else then this code will break. I'm not excited of dealing with such things, so still +1 for implementing explicit support for Infinite

I'm totally agree with you, but comming from django world where the
template language are very limited, this design decision is not new for me.


Fix hahahugoshortcode issues in titles and table of contents

Not really satisfied since this is a workaround and not a fix of the initial issue.
But, it works :)

Questions
Answers

Description?
Fixes this issue: https://prestashop.slack.com/archives/CTKG1NKAP/p1677161298432549

Type?
bug fix

BC breaks?
no

Deprecations?
no

thanks @thomasnares


CLI: prisma generate fails as post-deploy hook

Describe the bug
When installing prisma via homebrew the post-deploy hook prisma generate fails because of a missing module.
To Reproduce
Follow the Get Started tutorial

Set up  Prisma
Change Datamodel

Step 4 - Regenerate your Prisma Client

After adding prisma generate as a post-deploy hook here is what my prisma.yml looks like...

Below is the output upon executing prisma deploy...

Expected behavior
When executing prisma generate on the command line, prisma successfully generates both the schema and the client in the generated directory.  I would expect the same behavior when prisma generate is executed as a post-deploy hook.
Versions:

Connector: Postgres
Prisma Server: 1.27.0
prisma CLI: prisma/1.28.0 (darwin-x64) node-v10.4.1
OS:  OS X Mojave 10.14.3
other dependencies: prisma-client

@RobertShaw1 : Did you install Prisma using brew or npm?

I installed Prisma using brew.  This is mentioned at the very beginning of the issue.

@timsuchanek : What additional info is needed for this issue?

@RobertShaw1 : Thanks, this information is enough, I am able to reproduce. However, this would need more debugging from my end for a fix.

@divyenduz : Thanks.  I just wanted to make sure the issue didn't get closed or marked as stale because there was additional info I needed to submit.  Your efforts are much appreciated.

@RobertShaw1
Can you please try the new version(1.30) from homebrew?

@pantharshit00
I got the same error message as described above.

I confirm this is happening in 1.31.0 (version 1.31.1 wasn't available in brew when I checked for updates).
As a workaround, appending sh -c solves the issue:
endpoint: http://localhost:4466
datamodel: datamodel.prisma

hooks:
  post-deploy:
    - sh -c prisma generate

I checked output of which prisma from post-deploy hook and it's the same as running it outside: /usr/local/bin/prisma. I also tried to remove node_modules/package.json just to confirm, that the app doesn't load any local files, but the error persists.


Extremely slugging performance on WSL

I just set up a new WSL environment, and trying to install some software with linuxbrew. However, I've noticed that it's very very slow. For example, installing node (even with the download cached) took almost 30 minutes!
02:42 tri ~
:; brew install node
nice: cannot set niceness: Permission denied
==> Downloading https://nodejs.org/dist/v7.9.0/node-v7.9.0.tar.xz
Already downloaded: /home/tri/.cache/Homebrew/node-7.9.0.tar.xz
==> ./configure --prefix=/home/tri/.linuxbrew/Cellar/node/7.9.0 --without-npm --with-intl=system-icu --without-snapshot
==> make install
==> Downloading https://registry.npmjs.org/npm/-/npm-4.2.0.tgz
Already downloaded: /home/tri/.cache/Homebrew/node--npm-4.2.0.tgz
==> ./configure --prefix=/home/tri/.linuxbrew/Cellar/node/7.9.0/libexec/npm
==> make install
nice: cannot set niceness: Permission denied
==> Caveats
Bash completion has been installed to:
  /home/tri/.linuxbrew/etc/bash_completion.d

==> Summary
🍺  /home/tri/.linuxbrew/Cellar/node/7.9.0: 3,077 files, 40.6MB, built in 27 minutes 21 seconds
03:16 tri ~

Is this the expected behavior? Is there a way to debug what might be causing the slowness? I noticed that it spent the bulk of the time on the make install step.

Hi, Tri. Installing Linuxbrew in /home/linuxbrew/.linuxbrew will speed it up greatly.
See https://github.com/Linuxbrew/brew/wiki/FAQ#why-install-in-homelinuxbrewlinuxbrew

Hi, the link you mentioned doesn't really explain the issue that I'm seeing.
And how do I install Linuxbrew in that directory? The default ruby installation script puts in the current user's home direectory.

Compiling node from source takes half an hour.
See for example https://travis-ci.org/Linuxbrew/homebrew-core/builds/221877938
and https://circleci.com/gh/Linuxbrew/homebrew-core/4938
Using a precompiled binary bottle will be much faster.
To install in a different directory
See http://linuxbrew.sh/#installation
mkdir /home/linuxbrew
git clone https://github.com/Linuxbrew/brew.git /home/linuxbrew/.linuxbrew
PATH="/home/linuxbrew/.linuxbrew/bin:$PATH"
brew update
brew install node

@sjackman why would installing it in /home/linuxbrew/.linuxbrew make it use a pre-built binary?

Nevermind. I think I understand it now. It was prebuilt with that path in mind.

Do you know why I keep seeing these messages?
nice: cannot set niceness: Permission denied

No, I don't. But you could open an issue at https://github.com/Microsoft/BashOnWindows
Did installing in /home/linuxbrew/.linuxbrew work for you, and was it faster to install node?

@sjackman

Hi, Tri. Installing Linuxbrew in /home/linuxbrew/.linuxbrew will speed it up greatly.

why is it then not the default? (I certainly have to build a lot myself but thought this was because of the ARM chip)
this is my config which was just paste and go from your hp
HOMEBREW_PREFIX: /home/pi/.linuxbrew
HOMEBREW_REPOSITORY: /home/pi/.linuxbrew
HOMEBREW_CELLAR: /home/pi/.linuxbrew/Cellar

thanks

@monouser7dig There are no prebuilt bottles for ARM, so you'll have to build everything from source.

why is it then not the default?

The plan is for it to be the default. We haven't made that switch yet.

So for me it wońt change anything anyway but thanks anyway!

I'm glad to see that you're using Linuxbrew on the Raspberry Pi! @maxim-belkin was looking for beta testers for ARM.

yeah works reasonable well, installed nano, vim, htop, ruby and some stuff though it
also using it on my Mac
dunno if I can help in some way I'd gladly do as far as I can
I read quite a bit into home-brew but don't think am really ready for doing something to the code itself


Research: Joining car.zst files in CloudFlare Worker

Issue summary

Can .forest.car.zst files be joined in a worker? It would require stripping the header frame from all but the first file. Can multiple javascript streams be efficiently joined?
Other information and links

@lemmih I guess we no longer plan to do it?

Yeah, no need for this anymore.


Copy as json bug

I want to copy trial's parameters rather than all trial parameters details.

In latest nni version(v1.4), we change the design. when you click the button named Copy as json, will copy it directly.


Fixed typos in Area Chart KS pages

for Core/React/Svelte/Vue.
@nolimits4web Please, I ask you to also review my PR which I submitted a few days ago to the framework7-recipes repository.
Thank you.

Thanks :)


Multi Selection Support

first of thanks for this Control it would be a prefect replacement for Avalonia DataGrid 'well it least for me!'
but can u add support for Multi Selection with ability to bind For the SelectedItems I've added Extension to support this but it would be great to have this Built-in
my code idk if it's the best way to do it! but it's work for me.
public class DataBoxExtended : DataBox.DataBox, IStyleable {
 public static readonly DirectProperty<DataBoxExtended, IList> SelectedItemsProperty =
     AvaloniaProperty.RegisterDirect(nameof(SelectedItems), o => o.SelectedItems,
         (Action<DataBoxExtended, IList>)((o, v) => o.SelectedItems = v), defaultBindingMode: BindingMode.TwoWay);

 public static readonly DirectProperty<DataBoxExtended, bool> IsSingleSelectProperty =
     AvaloniaProperty.RegisterDirect(nameof(IsSingleSelect), o => o.IsSingleSelect,
         (Action<DataBoxExtended, bool>)((o, v) => o.IsSingleSelect = v), defaultBindingMode: BindingMode.TwoWay);

 private bool _isSingleSelect;
 private IList _selectedItems;

 public DataBoxExtended() {
     _isSingleSelect = false;
     _selectedItems = null;
     RowsPresenter = new DataBoxRowsPresenter();
 }

 private protected DataBoxRowsPresenter RowsPresenter { get; set; }

 public IList SelectedItems {
     get => _selectedItems;
     set => SetAndRaise(SelectedItemsProperty, ref _selectedItems, value);
 }

 public bool IsSingleSelect {
     get => _isSingleSelect;
     private protected set => SetAndRaise(IsSingleSelectProperty, ref _isSingleSelect, value);
 }

 Type IStyleable.StyleKey => typeof(DataBox.DataBox);

 protected override void OnApplyTemplate(TemplateAppliedEventArgs e) {
     base.OnApplyTemplate(e);
     //var cm = this.FindControl<ContextMenu>("Cm");
     RowsPresenter = e.NameScope.Find<DataBoxRowsPresenter>("PART_RowsPresenter");
     RowsPresenter.SelectionMode = SelectionMode.Multiple;
     RowsPresenter.SelectionChanged += (_, _) => {
         SelectedItems = RowsPresenter.SelectedItems;
         IsSingleSelect = SelectedItems is { Count: 1 };
         SelectionChanged?.Invoke(null, EventArgs.Empty);
     };
 }

 public event EventHandler SelectionChanged;
}

I would like to see this feature in the DataBox too

Not planned. Keeping implementation as simple as possible.


Fix for new submit() method (PR #1058) also submitting the HTML form

Mew submit() method from PR #1058 also submitting the HTML form, which leads to navigating away from current page, at least in Firefox.
Reason: dispatched event was not cancelable, so preventDefault in onSubmit
couldn't cancel it.
Further information:

https://stackoverflow.com/a/40916998
https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable

Checklist

[ ] I'm updating documentation
[x] I'm adding or updating code

~[ ] I've added and/or updated tests~ (just fixing PR #1058 which didnt add new test)
~[ ] I've updated docs if needed~ n/a
[x] I've run npm run cs-format on my branch to conform my code to prettier coding style

[ ] I'm adding a new feature

Thanks! I wonder if there's a better way to implement submit()..


File to import not found or unreadable: abstracts/functions.

Hi people,
when I use attribute lang=...  in tag style the console generated this error:
Module build failed (from ./node_modules/sass-loader/lib/loader.js)....
File to import not found or unreadable: abstracts/functions.
in /.../components/Header.vue (line 4, column 1)
"@nuxtjs/style-resources": "^0.1.2",
"node-sass": "^4.12.0",
"sass-loader": "^7.1.0"

Please provide a reproduction repo or codesandbox.

Hi @manniL ,
I found (probably) the issue.
In my proj I've used many file scss imported in a single main file. That file cause the issue.
I've used a wrong method for import singular scss file.
@import  'test.scss', 'test2.scss', 'test3.scss';
instead of:
@import 'test.scss'; @import 'test2.scss'; @import 'test3.scss';
I think the problem is there. I've not that error on my console.

:+1:


Cannot generate compdb for targets that depend on objc_library

I get this:
ERROR: <REDACTED>/BUILD.bazel:7:11: in @com_grail_bazel_compdb//:aspects.bzl%compilation_database_aspect aspect on objc_library rule <REDACTED>:os_objc_extra:
Traceback (most recent call last):
	File "<REDACTED>/external/com_grail_bazel_compdb/aspects.bzl", line 279, column 44, in _compilation_database_aspect_impl
		compiler_info = _objc_compiler_info(ctx, target, srcs, feature_configuration, cc_toolchain)
	File "<REDACTED>/external/com_grail_bazel_compdb/aspects.bzl", line 214, column 61, in _objc_compiler_info
		defines = ["-D\"{}\"".format(val) for val in target.objc.define.to_list()]
Error: 'ObjcProvider' value has no field or method 'define'

I replaced some personal and company info with <REDACTED>.
Is this some known issue?

Same problem using 0.4.0 version of release, but after I tried to clone the repository and use it instead of using the released version this problem no longer occurs. I guess they fixed this in a recent commit?

What bazel version? I think probably at this point we can remove the objc provider usage because bazel uses ccinfo even for objc targets for compilation now

ERROR: /Users/bytedance/github/examples/tutorial/ios-app/BUILD:3:13: in @bazel_compdb//:aspects.bzl%compilation_database_aspect aspect on objc_library rule //:UrlGetClasses:
Traceback (most recent call last):
File "/private/var/tmp/_bazel_bytedance/dad233b544b1c15f2febf18120497cc8/external/bazel_compdb/aspects.bzl", line 270, column 44, in _compilation_database_aspect_impl
compiler_info = _objc_compiler_info(ctx, target, srcs, feature_configuration, cc_toolchain)
File "/private/var/tmp/_bazel_bytedance/dad233b544b1c15f2febf18120497cc8/external/bazel_compdb/aspects.bzl", line 203, column 13, in _objc_compiler_info
defines = ["-D{}".format(val) for val in target.objc.define]
Error: type 'depset' is not iterable
ERROR: Analysis of aspect '@bazel_compdb//:aspects.bzl%compilation_database_aspect of //:UrlGetClasses' failed; build aborted: Analysis of target '//:UrlGetClasses' failed
INFO: Elapsed time: 1.503s
INFO: 0 processes.
The error I came across is something like this. The version of bazel-compdb is 0.4.0, and the bazel I use is a modified version inside company, which is based on bazel 3.7.2. After I changed to bazel-compdb 0.4.5 this error no longer occurs.

Sounds like a separate issue, but either way it's fixed now?

It seems so. I just tried 0.4.5 version and it works fine for me.

Thank you guys. I am going to close this issue now, but please feel free to let me know if there is something still remaining.


No validation checks when overfit_pct is set

🐛 Bug
When setting the overfit_pct to any value between 0 and 1 (exclusive) in trainer, the validation checks are disabled.
To Reproduce
I have worked on a minimal example to reproduce the bug:
import pytorch_lightning as pl
import torch

class Dataset(torch.utils.data.Dataset):

    def __init__(self, input_dim, output_dim):
        super(Dataset, self).__init__()
        self.input_dim = input_dim
        self.output_dim = output_dim

    def __getitem__(self, idx):
        X = torch.rand(1, self.input_dim)
        y = torch.randint(0, self.output_dim, (1,))
        return X, y

    def __len__(self):
        return 1000

class Model(pl.LightningModule):

    def __init__(self, input_dim, output_dim):
        super(Model, self).__init__()
        self.layer = torch.nn.Linear(input_dim, output_dim)
        self.dataset = Dataset(input_dim, output_dim)

    def forward(self, x, y):
        yhat = torch.softmax(self.layer(x), -1)
        return F.nll_loss(logits, y)

    def train_dataloader(self):
        return torch.utils.data.DataLoader(self.dataset, batch_size=64)

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=1e-3)

    def training_step(self, batch, batch_idx):
        loss = self.forward(*batch)
        return {'loss': loss, 'log': {'loss': loss}}

    def validation_step(self, batch, batch_idx):
        loss = self.forward(*batch)
        return {'val_loss': loss, 'log': {'val_loss': loss}}

if __name__ == '__main__':
    model = Model(100, 10)
    trainer = pl.Trainer(overfit_pct=.01)
    trainer.fit(model)

Expected behavior
Validation checks occur normally
Environment
PyTorch version: 1.4.0
Is debug build: No
CUDA used to build PyTorch: 10.1

OS: Manjaro Linux
GCC version: (GCC) 8.3.0
CMake version: Could not collect

Python version: 3.7
Is CUDA available: No
CUDA runtime version: 10.2.89
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: /usr/lib/libcudnn.so.7.6.5

Versions of relevant libraries:
[pip] numpy==1.18.1
[pip] pytorch-lightning==0.7.1
[pip] torch==1.4.0
[pip] torchvision==0.5.0
[conda] mkl                       2020.0                      166
[conda] pytorch                   1.4.0           py3.7_cuda10.1.243_cudnn7.6.3_0    pytorch
[conda] pytorch-lightning         0.7.1                    pypi_0    pypi
[conda] torchvision               0.5.0                py37_cu101    pytorch

@jeffling @awaelchli mind check?

Yes there is a bug here, but I had to fix @qmeeus's code sample to make it visible.
The sanity validation checks run, but the validation at the end of the epoch doesn't.
Here is the fixed minimal code sample:
import pytorch_lightning as pl
import torch
import torch.nn.functional as F

class Dataset(torch.utils.data.Dataset):

    def __init__(self, input_dim, output_dim):
        super(Dataset, self).__init__()
        self.input_dim = input_dim
        self.output_dim = output_dim

    def __getitem__(self, idx):
        X = torch.rand(self.input_dim)
        y = torch.randint(0, self.output_dim, (1,))
        return X, y

    def __len__(self):
        return 1000

class Model(pl.LightningModule):

    def __init__(self, input_dim, output_dim):
        super(Model, self).__init__()
        self.layer = torch.nn.Linear(input_dim, output_dim)
        self.dataset = Dataset(input_dim, output_dim)

    def forward(self, x, y):
        logits = torch.softmax(self.layer(x), -1)
        return F.nll_loss(logits, y.flatten(0))

    def train_dataloader(self):
        return torch.utils.data.DataLoader(self.dataset, batch_size=64)

    def val_dataloader(self):
        return torch.utils.data.DataLoader(self.dataset, batch_size=64)

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=1e-3)

    def training_step(self, batch, batch_idx):
        loss = self.forward(*batch)
        return {'loss': loss, 'log': {'loss': loss}}

    def validation_step(self, batch, batch_idx):
        loss = self.forward(*batch)
        print('see that validation runs only in sanity check')
        return {'val_loss': loss, 'log': {'val_loss': loss}}

    def validation_end(self, outputs):
        loss = torch.stack([output['val_loss'] for output in outputs]).mean()
        return {'val_loss': loss, 'log': {'val_loss': loss}}

if __name__ == '__main__':
    model = Model(100, 10)
    trainer = pl.Trainer(overfit_pct=0.1, max_epochs=10)
    trainer.fit(model)

For the record, @qmeeus your code had these issues:

No val_dataloader defined
Wrong shapes returned in dataloader
Wrong shape for nll_loss labels

Actually overfit_pct argument is not documented in the Trainer class. We should fix that and say that setting overfit_pct is the same as setting train_percent_check, val_percent_check and test_percent_check.

False alarm! Turns out it is simply because you chose a too small value for overfit_pct.
Your dataset has size 1000, and dataloader has batch_size 64.
1000 / 64 ~= 15 batches
When you choose overfit_pct = .01, then that gives 15 * 0.01 < 1 batch.
@qmeeus Please let me know if it isn't clear. I think the behaviour of overfit_pct is correct.

@williamFalcon Should we make it so that overfit_pct does not round to 0 batches?

False alarm! Turns out it is simply because you chose a too small value for overfit_pct.
Your dataset has size 1000, and dataloader has batch_size 64.
1000 / 64 ~= 15 batches
When you choose overfit_pct = .01, then that gives 15 * 0.01 < 1 batch.
@qmeeus Please let me know if it isn't clear. I think the behaviour of overfit_pct is correct.

Awesome, thanks !


Support for other languages

Will the app support languages other than English?
If so, I would like to collaborate with a translation into Brazilian Portuguese

Hey,
I haven't thought about localization and have no plans for specific languages (well, I might do a Finnish translation, but I there aren't any other languages that I could translate it to myself). If you wish to provide a translation to Brazilian Portuguese, the help is very welcome.
I have some hardcoded text that I'll need to move over to the resources file such that they can be translated, but I can get that done within the next few days.
Here is the current resource file for the text in the app (link to the main branch that will update with my changes later): Strings XML
I don't know whether you are familiar with the xml structure, so a quick overview just in case:
The actual shown text is between the tags (a tag is surrounded by <>). For example, in <string name="app_name">YAM Launcher</string> , "YAM Launcher" is the text that would be displayed.
In terms of the translation, you could for example copy the xml file into a differently named file and translate it. Alternatively, you could just provide the translations without the xml as long as you indicate which text each translation corresponds to.

I'm working on the translation, at the moment it looks like this:

Since there is no way at the moment to support more than one language, I am just replacing the original

I finished everything I saw being possible in the values and xml folder

I finished everything I saw being possible in the values and xml folder

Thanks! I'll let you know once I have updated the xml stuff with everything.

I finished everything I saw being possible in the values and xml folder

Thanks! I'll let you know once I have updated the xml stuff with everything.

ok

Hey,
I have now updated the text across my application such that everything is defined in strings.xml. I have also tried to organize the file in some kind of a remotely reasonable manner.
You can now simply translate evrything in the xml and that should translate everything in the application.

Actually a small correction: The text in arrays.xml would also need to be translated as this controls the settings options.

I'm doing the translation, when I finish I'll make a merge request


Expired secrets do not need deleted prior to creating a new one. Also these docs might benefit from not using the MSOL module

A couple notes on this one:
The following statement isn't quite true:

For expired client secrets, first you must delete all of the expired secrets for a given clientId. You then create a new one with MSO PowerShell, wait at least 24 hours, and test the app with the new clientId and ClientSecret key.

From my testing, you do not need to delete expired secrets. You can simply create a new client secret and it will work, even if there's an expired secret still tied to the SP. Granted, this still makes sense to do, as an expired secret really doesn't do you any good.
Additionally, this doc might benefit from an update to not use the MSOL PS module. I think it's possible to do this via graph using
Add-MgServicePrincipalPassword but I haven't confirmed that yet. I certainly have done it with the Azure AD module using New-AzureADServicePrincipalPasswordCredential which appears to map to the previously mentioned graph command in https://learn.microsoft.com/en-us/powershell/microsoftgraph/azuread-msoline-cmdlet-map?view=graph-powershell-1.0
Lastly, I made a note on a related doc, but I think you can actually manage the keys from an app registeration if you do not register the app via the appregnew.aspx link, and instead, create the app initially in the azure portal (which creates the SP/Enterprise App). This has a couple of benefits, the big one being that tenant admins aren't needed to maintain the secret for the app, the person who created the app reg can actually manage it entirely. Given the appregnew.aspx does allow a non tenant admin to create the app in the first place, it makes sense I think to have a method for the person who originated the request to maintain the secret.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3d9d8235-c495-a7a3-a4a6-0d073db41d1d
Version Independent ID: bdd22da6-06c6-569d-fccf-fd55baa3cef8
Content: Replace an expiring client secret in a SharePoint Add-in
Content Source: docs/sp-add-ins/replace-an-expiring-client-secret-in-a-sharepoint-add-in.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Any update here?

About this page, I have another question.
With MSOnline, it was suggested 3 commands:
New-MsolServicePrincipalCredential -AppPrincipalId $clientId -Type Symmetric -Usage Sign -Value $newClientSecret -StartDate $dtStart -EndDate $dtEnd
New-MsolServicePrincipalCredential -AppPrincipalId $clientId -Type Symmetric -Usage Verify -Value $newClientSecret -StartDate $dtStart -EndDate $dtEnd
New-MsolServicePrincipalCredential -AppPrincipalId $clientId -Type Password -Usage Verify -Value $newClientSecret -StartDate $dtStart -EndDate $dtEnd
but with Graph, story is only about regenerate new Password Add-MgServicePrincipalPassword -ServicePrincipalId $appPrincipal.Id -BodyParameter $params. This last command had only new password but no change about Type/Symmetric and Usage/Sign or Usage/Verify (KeyCredentials). What's happen if no renewal is done about these KeyCredentials?

@dotnvo in the lastest doc, we are starting to use graph api to generate new passwords. App that registered from appregnew.aspx is an old version of AAD app. If the app that you registered from AAD can meet your business requirement, it's recommended to use the AAD app instead of the app registered in appregnew.aspx.

Following in case of an update here. Please see my comment on #9170.

@dotnvo in the lastest doc, we are starting to use graph api to generate new passwords. App that registered from appregnew.aspx is an old version of AAD app. If the app that you registered from AAD can meet your business requirement, it's recommended to use the AAD app instead of the app registered in appregnew.aspx.

My Add In is using an app-id that was created from the appregnew.aspx page within SharePoint. Is there any workaround for me to easily change that to use some new service principal via Azure AD? Please advise.

Please refer to latest discuss in #9170


fine_dehalo bug

Hiya!
Calling fine dehalo with mask radius 2 introduces halos instead of removing it, however, this bug does not occur when the mask radius is 1.
Image Comparison:
https://slow.pics/c/1thqunQi
Script:
src = core.d2v.Source(r'you.d2v')
src = depth(src, 16)
src = fine_dehalo(src, darkstr=0, mask_radius=2, ss=2)
src = depth(src, 10)
src.set_output()

It's not adding halos, it's dehaloing less in that specific region
It's intended: https://slow.pics/c/FoMLIXVt, just a quirk of the gradient radius being bigger.
You can see that the edges are bigger, so it's just catching that faint halo near the edge as edge too since the radius is bigger. For lines this thin you should, well, use a small radius.


limits: Add generic layer of limits  (e.g interceptors) for StoreAPI.

We can leverage gRPC interceptors to ensure configuring limits per chunks, series etc of StoreAPI
Open questions:

partial result or total cancel?

Good point from @brancz  is that interceptor limit might be not enough. We can deduce how much chunks etc we will have without fetching them... so more on query planning side already.

I was working on a proposal for the above issue, and I had some queries regarding it. It would be really helpful for me to get some more clarity about the problem that we are trying to solve :sweat_smile:

We can deduce how much chunks etc we will have without fetching them

Are we looking something like pre-flight checks for this?

so more on query planning side already.

Is this more like Query Logging?
@bwplotka

@bwplotka
I see the existing configuration in querier to limit the large queries and responses are
1. enablePartialResponse bool,
2. queryTimeout time.Duration,
3. storeResponseTimeout time.Duration,
Can I know what these configurations are missing to achieve in limiting the large queries and responses?
I have couple of questions here

So just to confirm will these interceptors be part of store API between querier & store, querier & sidecar right? as the query result is the aggregation of both.
And on what basis will grpc interceptors limit blocks? Based on the query range or based on the size of the block while querying the object store?

This can help me to understand what additional configurations need to be added and how interceptor logic needs to be implemented.

Still in progress. Meant for a later task.
On Sun, 31 May 2020 at 19:24, stale[bot]<EMAIL_ADDRESS>wrote:

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or
needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we
can always reopen an issue if we need!). Alternatively, use remind command
https://probot.github.io/apps/reminders/ if you wish to be reminded at
some point in future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2527#issuecomment-636508738,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O7NPLMIA2B7B7UIS6TRUKOFHANCNFSM4MRWL35Q
.

Still not done.

Proven to be hard. Let's start with "non-generic" ones first (:


Cranelift: support load and store data from a address with dynamic offset.

My original request is sum two variable length array element to element and store the result to result array . Below is an example:
array a : [1, 2, 3, 4, 5,  6,  7,  8,  9,  10]
array b : [1, 2, 3, 4, 5,  6,  7,  8,  9,  10]
result  : [2, 4, 6, 8, 10, 12, 14, 16, 18, 20]

According to cranelift-dynamic-vector, I found dynamic vector type currently only support scaling factors which are compile-time constants. So I have to sum element by element through a loop. For each iteration. I have to load and store the nth element by a dynamic offset, but I can't found any api to support this.
another solution is create a new address by sum a offset, but seems UB occurs.

@meijies the "dynamic vector" support is very incomplete: it was originally developed by aarch64 folks to support a new ISA extension (SVE), but was never finished.
If you want to loop through an array and add values, you can generate IR that has a loop, and compute the addresses just like you might do manually in assembly language: take the base address of the array and add the index (multiplied by element size). The "API" to support this consists of iadd (integer add), imul (integer multiply) or ishl (integer shift left), and the various load instructions.
Could you describe what UB you're seeing, with examples of the CLIF and the generated assembly?

@cfallin sorry, I misunderstood pointer offset, each pointer offset represents 1 byte but not 8 bytes, so for f64, the next element address = base address + index * types::F64.bytes()


refactor(MOPLAT-258): rename Scenes to Screens

This PR resolves MOPLAT-258
Description
rename Scenes to Screens

PR Checklist

[ ] I tested my changes on iOS and Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

I think you missed this ?https://github.com/artsy/energy/blob/d97bcf4f52b6c9393d93c86584db5f07d24f10d3/babel.config.js#L20
https://github.com/artsy/energy/blob/d97bcf4f52b6c9393d93c86584db5f07d24f10d3/tsconfig.json#L42


Remove geotiff dependencies from all

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@c1fbe14). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage        ?   90.39%
=======================================
  Files           ?      148
  Lines           ?    10838
  Branches        ?      511
=======================================
  Hits            ?     9797
  Misses          ?      877
  Partials        ?      164

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Notify TCOs when nightly functional tests fail

🗣 Description
This PR updates the nightly functional test workflow to send an email to the TCOs when the tests fails for one of their products.
Note that 1235 talks about removing AAD from the workflow because these tests had been failing for so longer.  That step was not necessary as these tests were updated to be passing.
💭 Motivation and context
Closes #1235
🧪 Testing
Added email code, ran nightly tests manually and on a schedule, verified that emails were sent out for failures but not for passes.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] These code changes follow the ScubaGear [content style guide]
[x] Related issues these changes resolve are linked preferably via [closing keywords]- [ ] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] All relevant functional tests passed.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.
[ ] Feature branch has been rebased against changes from parent branch, as needed
[ ] Resolved all merge conflicts on branch
[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

This PR will not be merged.  The notification work done by 1235 was subsumed into 1278.


New test

@chrismcmahon Here it is.

Usually I like to manage assertions such that each test has a single set of assertions that might fail. This makes failure analysis a bit easier. Put another way, "Then" steps should always assert something about the final state of the test. But this case makes sense I think.
We might consider refactoring this is the future so that the first "Then" step is labeled "When", e.g. "When I see the add source fields/And I click delete" but that is minor semantics and may not be desired. So full steam ahead then.


Fix interval

closes https://github.com/zackurben/alphavantage/pull/84

Coverage increased (+0.2%) to 93.711% when pulling adc304581413a9ddc92e49f8e72baeb6a116698a on fix-interval into d40a3dcbb3c4456bd652222e18642f9bcc6fe062 on master.


Upgrade Ruby to 2.7.1

Upgrade Ruby to 2.7.1, see commits for more details.

Heya, you mention seeing the commit for more details, but that's just the version number iterating.
Is there any other context worth knowing?
I guess this is part of the big Ruby modernisation push?

Skipping 2.7.1 and going to 2.7.2 instead


ping function call returns PONG when Redis server is not running (sock connection).

import aioredis
conn = await aioredis.create_redis_pool('unix:///var/run/redis/redis-server.sock?db=0')
await conn.ping()

returns b'PONG' even though the server is not running.
import redis
r = redis.Redis('unix:///var/run/redis/redis-server.sock?db=0')
r.ping()

raises the ConnectionError exception.
aioredis should not return b'PONG' on its own, it should only come from a Redis server.
Maybe self._process_data(data or b'PONG') (aioredis/connection.py) is the culprit?

@dstruck -
Thanks for the ticket and the initial investigation! Would you be willing to submit a PR with a potential fix for this problem?

Might this be already fixed, or had some other cause?
I get FileNotFoundError when redis isn't running and ConnectionRefusedError when I try to fake the file (was going to look at fixing this)

@miketzian -
It has not - would welcome a PR with a fix if you have time.

I'd be happy to, though I can't reproduce it. When redis isn't running, the socket file doesn't exist and I get a FileNotFoundError and not b'PONG'

My machine is Mac with aioredis1.3 and got FileNotFoundError either. @dstruck how to reproduct that pong?

This issue should be resolved as of #891 - please feel free to pull in the latest master and test to ensure this is the case.


fix cmake pthread complile

I think we need to add a dependency on pthread here.

Hi. Thanks for the patch. But can you please elaborate what is the issue exactly that you're fixing here. What doesn't work without this patch ?

Hi. Thanks for the patch. But can you please elaborate what is the issue exactly that you're fixing here. What doesn't work without this patch ?

Description:	Debian GNU/Linux 9.8 (stretch)
Release:	9.8
gcc version 9.4.0
I have encountered this problem
make -j 8

Thanks. it is clear now. But adding -lpthread is not the right fix. Some OSes don't have -lpthread. So I'll see what might be wrong.
P.S. Also for the later, please, consider learning how to quote regular text rather then posting screenshoots. Not as usable on mobile.

See my commit linked above. Should be fixed now.


resolveImage helper. using params and not / for paths so windows works

@keybase/react-hackers

:thumbsup:

actually have more fixes, stay tuned

@keybase/react-hackers ready for feedback again

:thumbsup:


Can we hide the children node when children is empty?

{         id: 'a',         parentId: '',         children: [             {                 id: 'a1',                 parentId: 'a',                 children: [                     {                         id: 'a1-1',                         parentId: 'a1'                     }                 ]             },             {                 id: 'a2',                 parentId: 'a',                 children: [                     {                         id: 'aq',                         parentId: 'a2'                     }                 ]             }         ]     }

The feature is rejected.
I have to take more time to think deeply about it.
here are my suggestions for you:

you can do it by yourself after you get the tree.
or check the length of children when enumerate  the tree.

The feature is rejected.
I have to take more time to think deeply about it.
here are my suggestions for you:
you can do it by yourself after you get the tree.
or check the length of children when enumerate the tree.