fix can't open concierge page

Details

Concierge chat does not open when we open https://new.expensify.com/concierge on a new tab or by deep link on native.
Fixed Issues

$ https://github.com/Expensify/App/issues/12776
PROPOSAL: https://github.com/Expensify/App/issues/12776#issuecomment-1320857774
Tests

Web

Open a new tab
Go to https://new.expensify.com/concierge
Verify the concierge chat is displayed

Native

Paste https://new.expensify.com/concierge to notes or messaging app
Open the link view New Expensify
Verify the concierge chat is displayed

Desktop

Open console from developer tools and enter this.document.location = "http://localhost:8080/concierge"
Verify the concierge chat is displayed

[x] Verify that no errors appear in the JS console

Offline tests

Web

Open a new tab
Go to https://new.expensify.com/concierge
Verify the concierge chat is displayed

Native

Paste https://new.expensify.com/concierge to notes or messaging app
Open the link view New Expensify
Verify the concierge chat is displayed

Desktop

Open console from developer tools and enter this.document.location = "http://localhost:8080/concierge"
Verify the concierge chat is displayed

QA Steps

Web

Open a new tab
Go to https://staging.new.expensify.com/concierge
Verify the concierge chat is displayed

Native

Paste https://staging.new.expensify.com/concierge to notes or messaging app
Open the link view New Expensify
Verify the concierge chat is displayed

Desktop

Open console from developer tools and enter this.document.location = "https://staging.new.expensify.com/concierge"
Verify the concierge chat is displayed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/50919443/204504269-f40b3b58-c565-4f4f-aa68-6d8e6f333122.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/50919443/204504768-0f52701b-4ba9-4d89-ac91-de0e12bf6d44.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/50919443/204504498-c8dd7dbe-00b2-4e3e-b3a8-113b7d4051eb.mov

Desktop

https://user-images.githubusercontent.com/50919443/204515663-5c105c86-5414-4264-9b2f-efc2c2118f1a.mov

iOS

https://user-images.githubusercontent.com/50919443/204504321-1a362315-d2bc-4129-a9f8-5090910b5ef1.mov

Android

https://user-images.githubusercontent.com/50919443/204502108-5b8bd0f7-0169-474f-891d-3f5e12b72799.mp4

Ah gotcha, so QA will know to do that based on the description in the OP? Or should we make it more detailed?

Thanks for the feedback! I have fixed the screenshot and updated the test step.

I updated it for @bernhardoj so that we can get this merged. Good to remember for next time though Bernhard!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @stitesExpensify in version: 1.2.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


error file name

Description
bad file name

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!

 All committers have signed the CLA.

This appears to have been fixed in the latest docs


Add image param if exists

FreeOTP supports an image in the QR URL.
See commit freeotp/freeotp-android@e1dbb3c6c3faf112a4bebb75057e0f739c52ac97, in particular this line.
Example of a real XML string entry (edited for obvious reasons):
<string name="OVH:EDITED-ovh">
{"algo":"SHA1","counter":0,"digits":6,"image":"https://www.ovh.com/images/totp/ovh.png","issuerExt":"OVH","label":"EDITED-ovh","period":30,"secret":[0,0,0,0,0,0,0,0,0,0],"type":"TOTP"}
</string>

It would be helpful to be able to backup and restore this (now it reverts to the default image).
I guess it only requires adding an optional field to params.

https://github.com/google/google-authenticator/wiki/Key-Uri-Format (which is the only document I know about the qr code format) does not mention an image url can be in the qr code, and I'm not sure if adding nonstandard fields in the qr code url is a good idea, even if freeotp supports it. If someone considers doing this, before sending a pull request to me, be sure to test the resulting qr code and document the results on authenticator apps on different phones, even old ones (at least the ones I've mentioned in the README).
Closing for now.


Improve az iot edge deployment create help text

After extensive work attempting to utilize the az iot edge deployment create command recommend the following:

Include specifications for deployment-id limitations, like in Azure Portal. (i.e. Lowercase and the following special characters are allowed: [-+%_*!']).  This was quite difficult to debug as the cli error code is useless.
ERROR: {'Message': 'ErrorCode:ArgumentInvalid;BadRequest', 'ExceptionMessage': 'Tracking ID:75a881e527b64b00abb4f282a12ce560-G:0-TimeStamp:03/10/2023 12:36:02'}
a. Further adding the cli error response messaging to include the above messaging would help future debugging.

The recommended format for custom-labels is straight up wrong.  From the documentation:

but what actually works:

Creating "space separated" creates one tag and dumps all the others into the value section of said key, e.g.

Instead of the desired:

Include an example of the format required by target-condition.  Only help I discovered was in this article and an example of intended use is highly helpful if this parameter is expected to be utilized.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3f635760-7886-3abb-0491-fcc728b4a90d
Version Independent ID: eeb3b44f-acc7-6f7e-7604-392d16722a26
Content: az iot edge deployment
Content Source: latest/docs-ref-autogen/iot/edge/deployment.yml
Service: iot-hub
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to CXP team

Hi @delarooster, would you mind sharing the whole command you ran? there is an example of using the command if you run az iot edge deployment create --help

Please make sure you are using the parameter in format of key-value pair(--custom-labels key0="value0" key1="value1") instead of an entire string(--custom-labels "key0=value0 key1=value1"), thanks!

Thanks @Elsie4ever about the recommendation, that's the final understanding I came to after iterating over many different inputs.  Appreciate the update on that second issue.
Any updates about the first or third point?  Would be entirely helpful to update documentation so someone else doesn't tread down the same path I had to traverse.

Regarding the first input, we will add the parameter help text about the specific naming for the deployment id.
Regarding the third input, the examples for target condition are already there

However, since it is hard to see, we will update the help text for the parameter too.

We've improved the command documentation taking into account the points you listed in the issue. Thank you for the feedback.


Make importing more flexible

Currently config file import sections will import just modules; however sometimes we want to use the from <foo> import style, which is not supported.  It would be more flexible and intuitive if there was a general preamble section that allowed for imports and general executable code.

I'm wanting to do more than just make importing more flexible -- I also want to allow for specialized code, such as functions, that can be referred to in the config file specified LEAP pipeline. E.g., I may want to define a pipeline operator before defining the pipeline, as I would need to do to resolve, say, partial function effects beforehand.

Replace imports in config file with preamble.  E.g.,:
preamble: |
    import re
    from pathlib import Path

    def foo():
        pass

Now the MNIST example config.yaml looks like this:
pop_size: 7
algorithm: bygen
bygen: # parameters that only make sense for a by-generation EA
  max_generations: 5
  k_elites: 2 # optional parameter for specifying the number (k) elites we keep per generation
problem: problem.MNISTProblem()
representation: representation.MNISTRepresentation()
pop_file: pop.csv # where we will write out each generation in CSV format
preamble: |
  import probe # need to import our probe.py so that LEAP sees our probe pipeline operator
pipeline:
  - ops.tournament_selection
  - ops.clone
  - mutate_randint(expected_num_mutations=1, bounds=representation.MNISTRepresentation.genome_bounds)
  - ops.evaluate
  - probe.IndividualProbeCSV('inds.csv') # our own probe to see every single created offspring
  - ops.pool(size=${pop_size})

Note the use of the | to preserve carriage returns in the multistring YAML variable for preamble.

Tested and works with the MNIST example.  Closing.


vscode-insiders remote server has license agreement prompt, fails to start

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.65.0-insider
OS Version: MacOS 12.3 Beta

Steps to Reproduce:

Launch vscode-insiders
Try to remote connect to linux host through ssh

Here is the error message of the vscode remote server:
server.sh is being replaced by 'bin/code-server-insiders'. Please migrate to the new command and adopt the following new default behaviors:
* connection token is mandatory unless --without-connection-token is used
* host defaults to `localhost`
*
* Visual Studio Code Server
*
* Reminder: You may only use this software with Visual Studio family products,
* as described in the license https://aka.ms/vscode-server-license
*
Do you accept the terms in the License Agreement?

Closing (issue is with vscode-remote-release).


Proposal: Ability to configure msgpack encoding, e.g. to ignore undefined properties

Hi 👋
Would it be helpful to anyone else if it were possible to configure the msgpack encoder.
For example msgpack has the option to ignoreUndefinedProperties, which is desirable in certain circumstances, eg. to reduce bandwidth or storage requirements.
Msgpack options could (for example) be provided with the client configuration. Something like:
const client = new FluentClient('tag', {
  msgpackOptions: {
    maxDepth: 42,
    ingnoreUndefined: true,
    // other msgpack options at https://github.com/msgpack/msgpack-javascript/blob/main/src/Encoder.ts#L15
  }
}

Would be happy to throw something together if it's interesting.
Thanks in advance

Hey! I think it would be interesting to know under which circumstances this would be useful. The library is mainly meant to communicate with fluentd / fluent bit, and I'm unsure that changing these parameters has much value, when the upstream still needs to understand what gets encoded. That said, this could maybe be useful for custom FluentServer implementations, but having that context would be helpful :)
Happy to review a PR if you have the time!


First pass at making on-prem product-generic

Signed-off-by: Graham Weldon<EMAIL_ADDRESS>This needs discussion, and a lot of review.
Calling all Jan Michael Vincents! @chefsalim

@predominant Thanks for the PR - will get to this shortly

Will add more feedback but on first run through initial feedback - this seems like quite a bit of change to absorb all at once. Changes to the migrate scripts especially are not easy to test, so unless you want to invest effort into testing those scenarios and signing off that they still work, we probably should roll those back. Another thing to consider is that we will likely move to a different installer in the not too distant future, so the utility of these changes may not be worthwhile.

This was premature. Will look at this again in the coming weeks. Thanks for the honest review @chefsalim - Much appreciated!


KEY_CONFIG.md vim keybindings code snippet left key is double mapped to open help

When copying the basic vim keybindings snippet from the docs I ran into a bug where the h key was double mapped to open_help and move_left. I suggest extending the snippet by remapping open_help to H like so:
(
    focus_right: Some(( code: Char('l'), modifiers: ( bits: 0,),)),
    focus_left: Some(( code: Char('h'), modifiers: ( bits: 0,),)),
    focus_above: Some(( code: Char('k'), modifiers: ( bits: 0,),)),
    focus_below: Some(( code: Char('j'), modifiers: ( bits: 0,),)),

    move_left: Some(( code: Char('h'), modifiers: ( bits: 0,),)),
    move_right: Some(( code: Char('l'), modifiers: ( bits: 0,),)),
    move_up: Some(( code: Char('k'), modifiers: ( bits: 0,),)),
    move_down: Some(( code: Char('j'), modifiers: ( bits: 0,),)),

    open_help: Some(( code: Char('H'), modifiers: ( bits: 0,),)),
)

wrong repo 🤦♂


Conflicting licenses in datastreams

There are two confliciting licences in the datastream library. This is one I happened to come across, there may be more.

Fixed.
https://github.com/CloudSixteen/Clockwork/commit/5b520488f183132c05f866341eed510dbae3b4e2


TritonCTS: multiple cell names in variable CTS_BUF_CELL cause segmentation fault

Having multiple cell names in the variable CTS_BUF_CELL causes TritonCTS to crash with segmentation fault.
With multiple cell names in this variable, the call
odb::dbMaster* master = _db->findMaster(inst.getMaster().c_str());
on line 329 of file OpenROAD/src/TritonCTS/src/DbWrapper.cpp returns a null pointer.This null pointer is passed to the function odb::dbInst::create
odb::dbInst::create (block_=0x14eaddf8, master_=0x0, name_=0x7ffffffec830 "clkbuf_0_clk")
and the line 1228     _dbInstHdr* inst_hdr = block->_inst_hdr_hash.find(master->_id); in file
OpenROAD/src/OpenDB/src/db/dbInst.cpp causes a segmentation fault.
I think a check should be built in to ensure that this variable has only one cell name.
By the way, while looking at the code I noticed the following inefficiencies in the file OpenROAD/src/TritonCTS/src/DbWrapper.cpp lines 110-115  :
if (getNumClocks() == 0) {
error("No clock nets have been found.\n");
}
    std::cout << " TritonCTS found " << getNumClocks() << " clock nets." << std::endl;
    _options->setNumClockRoots(getNumClocks());

The function getNumClocks() is called 3 times instead of calling once, saving the return value in a variable and subsequently using the variable later in the code.

We will address the crash.  The "inefficiency" is unimportant as the function is trivially inlined by the compiler:
    unsigned getNumClocks() const { return _numberOfClocks; }


Fix background position issue when device has physical menu

I've tested the sample app in some samsung devices (specially Samsung S5) with physical menu and the blur effect seems displaced and amplified as some developers noticed, but the same sample with other devices without physical menu seems correct.
The image below illustrate the bug:

And the fixed version with the code of this PR:

Thanks for this great library.

Close but not complete...
You need also to get navigation_bar_height_landscape or navigation_bar_width
Here is my fix:
 private void blur(Bitmap bkg, View view) {
...
  Resources resources = mHoldingActivity.getResources();
        if (resources.getBoolean(R.bool.blur_dialog_has_bottom_navigation_bar)) {
            bottomOffset = getNavigationBarOffset(mHoldingActivity);
        } else {
            rightOffset = getNavigationBarOffset(mHoldingActivity);
        }
...

 private int getNavigationBarOffset(Activity holdingActivity) {
        int result = 0;
        if(hasNavigationBar(holdingActivity)) {
            //The device has a navigation bar
            Resources resources = holdingActivity.getResources();

            int orientation = resources.getConfiguration().orientation;
            int resourceId;
            if (isTablet(holdingActivity)){
                resourceId = resources.getIdentifier(orientation == Configuration.ORIENTATION_PORTRAIT ? "navigation_bar_height" : "navigation_bar_height_landscape", "dimen", "android");
            }  else {
                resourceId = resources.getIdentifier(orientation == Configuration.ORIENTATION_PORTRAIT ? "navigation_bar_height" : "navigation_bar_width", "dimen", "android");
            }

            if (resourceId > 0) {
                return resources.getDimensionPixelSize(resourceId);
            }
        }
        return result;
    }

    private boolean hasNavigationBar(Activity holdingActivity) {
        boolean hasMenuKey = ViewConfiguration.get(holdingActivity).hasPermanentMenuKey();
        boolean hasBackKey = KeyCharacterMap.deviceHasKey(KeyEvent.KEYCODE_BACK);

        return !hasMenuKey && !hasBackKey;
    }

    private boolean isTablet(Context c) {
        return (c.getResources().getConfiguration().screenLayout
                & Configuration.SCREENLAYOUT_SIZE_MASK)
                >= Configuration.SCREENLAYOUT_SIZE_LARGE;
    }

still not working on xiaomi redmi note 3


Add passivemode for kube-ovn-speaker

What type of this PR
Examples of user facing changes:

Feature

Add the --passivemode option to the startup parameters of kube-ovn-speaker, the default is false.
if you want to enable the passivemode, only set --passivemode=true, then the kube-ovn-spekaer will listen 179 port,you can You can view it with the netstat -nlp .
/kind  feature
Which issue(s) this PR fixes:
Fixes #1594

Thanks! @KillMaster9


Wrong mountpoins for etc-ssl-certs volume in flannel-wrapper for coreos-stable-1409-7-0-v20170719, distributed on GCE

Seems like mountpoint for etc-ssl-certs volume, specified in flannel-wrapper is wrong:
        --volume etc-ssl-certs,kind=host,source=/usr/share/ca-certificates,readOnly=true \
        --volume usr-share-certs,kind=host,source=/usr/share/ca-certificates,readOnly=true \
It's duplicated with usr-share-certs volume, which prevents /etc/ssl/certs to be mounted properly.
Expected Behavior

Mount usr-share-certs volume as /usr/share/ca-certificates and etc-ssl-certs as /etc/ssl/certs
Current Behavior

Possible Solution

Fix flannel-wrapper typo?
Steps to Reproduce (for bugs)

1.Start flanneld with ssl support on coreos-stable-1409-7-0-v20170719 on GCE
2.Check flannel-wrapper
3.
4.
Context

Your Environment

Flannel version:0.8.0-amd64
Backend used (e.g. vxlan or udp):gce
Etcd version:3.2
Kubernetes version (if used):
Operating System and version:coreos-stable-1409-7-0-v20170719
Link to your project (optional):

@Unb0rn seems like it's fixed in this commit https://github.com/coreos/coreos-overlay/commit/e9eeca8d90023441703b18c49e29769299a86348
and flannel-wrapper is in a different repo :)


Documenting modules

It would make modules easier to manage and fix right now and in the future if they had names, description, and how they should be added to bot.py to make them work properly.

right everything follows modules.md apart from the reddit reader, and thats not finished yet

Having users hunt for where to paste in code in bot.py would be next to impossible with more complicated modules (like the reddit post one). I love the idea of OOP-ing everything (#13). Let's do that alongside this (or first).

I'm already half way though the conversion, won't be too long (I think)

Does modules documentation need to be rewritten?

I've already rewritten it


Update CODEOWNERS

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

/lgtm
/merge


Excluded pylint 2.6.1 and astroid 2.5.0 to circumvent AttributeError

See commit message.
No review needed.

Coverage remained the same at 38.163% when pulling 11535da081ec28c67b5172ba9ed412e903529018 on andy/fix-pylint into a8cfe8d870ad0c44af06c85115dab02ba53b2e64 on master.

With the release of pylint 2.6.2, the error has disappeared, so this PR is not needed anymore.


Add support for data availability queries

Add support for data availability queries (availableconstraint) defined by the SDMX 2.1 standard

Hi @FedorYatsenko —thanks for this contribution, much appreciated!
A couple of questions:

Do you know any existing SDMX web services that will give responses to such queries?
Can you give an example of code that uses this branch to query 1 or more of those services?

These would help me confirm the code works, and guide you in adding tests. Thanks in advance.

Hi @khaeru,
I'm afraid, I can't yet share a link to SDMX web services that will give responses to such queries. As @sychsergiy mentioned in the khaeru/sdmx#164, our data provider is hidden by a private network.
Consequently, I'm not sure if this help you, but here is the code we are using:
keys_dict = {
    'INDICATOR': ['PCPIHA_IX', 'PCPIHA_PC_CP_A_PT', 'PCPI_PC_CP_A_PT'],
    'COUNTRY':   ['111', '134'],
    'FREQUENCY': []
}
resp2 = sdmx_client.availableconstraint(
    'CPI',
    key=keys_dict,
    dsd=cpi_dsd
)

It generates the following link: .../availableconstraint/CPI/111+134.PCPIHA_IX+PCPIHA_PC_CP_A_PT+PCPI_PC_CP_A_PT.*.
And the following XML response: khaeru/sdmx-test-data#1
I am going to push a test for this file in this branch. Please let me know if I should change something.

Thanks for adding the specimen in the other repo. On the next push the tests on this branch should find it.
I need to at some point add a PR template with a check-list for contributors. For now, while you're working on this draft, could you please:

Add a line to doc/whatsnew.rst, following the style of the existing entries.
Rebase the branch on the latest main, resolving any conflicts (don't need to do this repeatedly, only when ready to review/merge).

I'll come back to review when you indicate I should.

Thank you for merging the specimen.
As for the whatsnew and updates to the latest main, I'll do that soon.

Thank you very much for approving these changes.

By the way: I see on the commit 31a7ba12b1f3f32df02d64cdbe4dba04e8c64687 that the associated username is "Fedir_Yatsenko", whereas your GitHub username appears to be "FedorYatsenko". I don't know why there is a mismatch (maybe difference between your local configuration and GitHub account), but as a result GitHub does not correctly associate the commit with your account, and you don't show up yet in the list of contributors: https://github.com/khaeru/sdmx/graphs/contributors 🥲
I'm sorry for not noticing this earlier. I'll add a :thanks: to doc/whatsnew.rst when I prepare the next release.

No worries. I just misspelled my name a little when creating my GitHub account.


[thci] configure backbone netif

The backbone netif is always set to eth0 in the original THCI.
This commit allows to configure backbone netif via THC parameter Param8.

@librasungirl Verified that it works as intended.


Test model equivalence between Jax and PyTorch workloads using param_shapes property

To test the equivalence of the model structure of the Jax and PyTorch implementations of the different workloads, we can add a pytest which checks wether the param_shapes property of the two workload implementations match. Currently, the param_shapes property is not implemented yet for the PyTorch workloads.

Addressed in PR #66.


Use NPM module named 'forever' to autoload

Bonescdipt should use NPM package named forever to run the scripts indefinitely and remove the autorun logic from its source. The link to that module is https://www.npmjs.org/package/forever

This issue was moved to beagleboard/bonescript#33


Extend the JSONB field access example

Extend the JSONB field access example to include accessing an array element.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cf84707c874700bbf01955fbab9b531b1ac6acb8/


Add attestation pool in beacon node ReceiveServer

How was it fixed?

[x] Add AttestationPool

get/get_all/add/remove

[x] Add ReceiveServer.get_ready_attestations

which return attestations that are ready to be included in block

[x] Expose ReceiveServer.get_ready_attestations to Validator

validator would get ready attestations from receive server when proposing

[x] Fix: validator should attest at second slot tick
[x] When receiving new not-yet-included attestation, check if it's already in the database

pending on #660

[x] Remove attestations from attestation pool when identical attestations are included in an imported block

To-Do

[ ] Clean up commit history

[ ] Add entry to the release notes PR

Cute Animal Picture

Easy to move at a later date if it is not.
Sent from ProtonMail mobile
-------- Original Message --------
On May 28, 2019, 6:57 AM, NIC Lin wrote:

@NIC619 commented on this pull request.

In trinity/exceptions.py:

@@ -68,6 +68,13 @@ class BadDatabaseError(BaseTrinityError):
pass

+class AttestationNotFound(BaseTrinityError):
Not sure if this is the right place for this exception. cc @pipermerriam @hwwhww
This exception is used when ReceiveServer can not find the Attestation in question in its AttestationPool.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Travis Build Script Doesn't Work

The Travis Build Script doesn't work: it runs npm start, which in turn runs electron .. Unfortunately, electron isn't being recognized as a command in my $PATH on Travis build, so hopefully I'll figure out a solution to that sooner or later.

Fixed in #5


[NEMO-482] Keep library versions updated

JIRA: NEMO-482: Keep library versions updated
Major changes:

Updates library versions, and performs migrations for the version updates

Minor changes to note:

NEXMark pom was updated to keep up with the changes

Tests for the changes:

Existing tests comply with the changes
NEXMark now also has an ITCase test

Other comments:

None

Closes #316

@taegeonum Could you check this PR?


Mentorship form

create form for requesting a mentor

There's an existing form on the mentor branch for this, but it should be verified


Simplify Deploying Apps ontop of BigBang with Flux

Is your feature request related to a problem? Please describe.
When deploying apps on top of big bang there are two options:

Specify some complicated flux manifests to deploy it in the same paradigm as BigBang
Deploy a native helm chart with Zarf performing the Helm install

Describe the solution you'd like
Add a parameter to ZarfChart
// ZarfChart defines a helm chart to be deployed.
type ZarfChart struct {
	Name        string   `json:"name" jsonschema:"description=The name of the chart to deploy, this should be the name of the chart as it is installed in the helm repo"`
	ReleaseName string   `json:"releaseName,omitempty" jsonschema:"description=The name of the release to create, defaults to the name of the chart"`
	Url         string   `json:"url,omitempty" jsonschema:"oneof_required=url,description=The URL of the chart repository or git url if the chart is using a git repo instead of helm repo"`
	Version     string   `json:"version" jsonschema:"description=The version of the chart to deploy, for git-based charts this is also the tag of the git repo"`
	Namespace   string   `json:"namespace" jsonschema:"description=The namespace to deploy the chart to"`
	ValuesFiles []string `json:"valuesFiles,omitempty" jsonschema:"description=List of values files to include in the package, these will be merged together"`
	GitPath     string   `json:"gitPath,omitempty" jsonschema:"description=If using a git repo, the path to the chart in the repo"`
	LocalPath   string   `json:"localPath,omitempty" jsonschema:"oneof_required=localPath,description=The path to the chart folder"`
	NoWait      bool     `json:"noWait,omitempty" jsonschema:"description=Wait for chart resources to be ready before continuing"`
	Flux        bool     `json:"flux,omitempty" jsonschema:"When Deploying the chart, leverage the Flux deployment to make a Source object and HelmRelease rather than Zarf performing the install"`
}

When flux is set to true, zarf would:
components:
  - name: demo-helm-releasename
    required: true
    charts:
      - name: podinfo
        releaseName: cool-name
        url: https://stefanprodan.github.io/podinfo
        version: 6.1.6
        namespace: helm-releasename
    images:
      - ghcr.io/stefanprodan/podinfo:6.1.6

Create:

Download the provided Helm chart from either Git or the helm repo
Download the required images for the helm chart

Deploy:

Upload the images to the registry
Upload the git repo to the gitea deployment
Create a GitRepository object pointing at the repo
Create secrets for each values file provided to the chart
Create a HelmRelease for Flux to deploy the Helm chart, configured with values

Example
This same process is followed by the creation of a Flux wrapper around BigBang in https://github.com/defenseunicorns/zarf/blob/033374bf17ee223f69af5517bcb3f96ff40292d4/src/pkg/bigbang/bigbang.go#L311-L492
Additional context
This should balance the need for light runtime for tiny edge with cloud based consistency and resources by allowing Flux to manage the lifecycle of Helm
In order to do this for OCI objects only, These things need to be fixed

[ ] https://github.com/helm/helm/pull/11623
[ ] Get helm to release that patch
[ ] Update Source controller with that helm version and finish https://github.com/fluxcd/source-controller/issues/807
[ ] Released Flux with new source controller tag
[ ] Get Flux through IronBank
[ ] Release Flux in BigBang
[ ] Profit

To faciliate the OCI upload of charts and pulling from Flux, we would need https://github.com/fluxcd/source-controller/issues/807 closed first since the Zarf registry is not https protected

This seems like the same thing i am interested in doing but just thought I would comment here if anyone has additional info. I am intersted in using Flux like BigBang but using a Helm Repository.  I wanted to just use existing registry that has the helm charts already but I can't seem to connect to it.  I assume its a OCI registry and suffers from that helm unsecure bug that exists in both helm and flux today.  Is there any alternative that I could use today minus hosting my own chart museum with zarf and pushing my helm charts there?

This was completed in #2005


Kubernetes: add the server to the serverlist only if it's ready

The current implementation add the server too early and doesn't take into account the readiness of the server.

Somewhat fixed in https://github.com/bolt-rip/Dockerizedcraft/commit/26e3746e9574668ebd164456bec2d42e30c041ff but I'm not happy with the change because the start docker phase isn't the same as the health_status: healthy phase.


[Typo] Fixed "initial" word in vars and typo v1

Maybe need to automate spelling check with something like this https://www.npmjs.com/package/eslint-plugin-spellcheck

@kybarg happy to accept a PR on the spell checker as part of our test suite, perhaps early such as after lint.
Thanks!


Add fields in CycloneDX BOM output using the Properties (name-value store)

Such as download_url, filename, primary_language, and homepage_url.
https://cyclonedx.org/use-cases/#properties--name-value-store
https://github.com/CycloneDX/cyclonedx-property-taxonomy#cyclonedx-property-taxonomy

See also https://github.com/nexB/aboutcode-cyclonedx-taxonomy for field references.


Docs: better autonomy test tutorial

What type of PR is this?
/kind documentation
What this PR does / why we need it:

Add NodeSelector for multi-node cluster.
Shorten pod eviction time from default 5 minutes to 5 seconds to accelerate autonomy test.

/assign @kadisi

/lgtm

/approve


Update rss.md - add specifics for feed template name and location

Add specific instructions for the sample feed template filename and location.
The existing instructions are unclear as to exactly where to save the feed template file to, and what it should be named.
It took two hours Googling and trying different options until figuring out that it's not "Place the file anywhere in your project" but "anywhere in the src directory". The existing docs don't say what this file should be named which could be confusing.

This is a good catch. Based on what I see of the repository linked on Discord, I think it might be a good idea to write ‘anywhere in your input directory’ instead of either ‘anywhere in your project’ (which is incorrect, as pointed out) or ‘in the src directory’ (which could be read to mean the file can only be placed in that specific directory, even though the input directory might not be named src and the file itself may be placed anywhere inside it, including subdirectories), with a link to the dir.input description for clarity.

Thank you!


chore: assign googleapis/cdpe-cloudai as codeowner

@busunkim96 Please could you take another look?

The samples failures are tracked in https://github.com/googleapis/python-documentai/issues/244. I'm going to merge this PR as the changes are unrelated to samples testing.


Edit button missing for workflows

See https://github.com/StackStorm/st2flow/issues/180 -- moving the issue over here as st2web is where it needs to be fixed.

Resolved


Go to start when refreshing or opening story

Pending @Naranja-Sagged's attempt to look into a fix, here's my workaround where refreshing or opening a story goes to the start of the song

Closing to remake with right name and closing


Exit code and test summary clarity request

Maybe I'm the only one who does this but when npm told me that
npm ERR<EMAIL_ADDRESS>test: `mocha --compilers js:babel-core/register --recursive --colors`
npm ERR! Exit status 40

And then
npm ERR<EMAIL_ADDRESS>test: `mocha --compilers js:babel-core/register --recursive --colors`
npm ERR! Exit status 5

I started googling for the exit code meanings e.g. "mocha exit code 40". I expected one of them to mean that the tests had an unhandled exception, perhaps the other had an unawaited promise, maybe there was another for failed tests, and another for warnings. Maybe it was a bit mask. I don't know. I would never have guessed that it's the amount of tests failed until I googled and found this:
https://github.com/mochajs/mocha/issues/2438
I assumed there was no output depicting the amount of tests failing because it was buried in between the full test output and the failure output. Which brings me to the feature request. Please print the total succeeded/failed summary at the very bottom of the output. Also more prominent banners between sections would be nice.
I would request that the exit code was just 1 when the tests fail, but I believe that will break backwards compat more than it's worth.

Agreed. The code here is the problem. Mocha should not co-opt a well known mechanism of error codes to mean something else. This is confusing.

this is useful for users in certain CI environments.

I think it would be better to let people opt in to this feature or enable another way of getting this data rather than use error code as a counter. It makes integration with other software hard.

feel free to send a PR which hides the behavior behind a flag, but it will need to be opt-out for now.


Translation Delivery

Translation Delivery

This pull request is for translation delivery. Please review and approve them.

This pull request is for translation delivery. Please review and approve them.

Will not be merged as this repository gets archived


[Gulp Task]: Global gulp version being used instead of my packages.json version

Issue Description
The global version of gulp installed on the agent is being used instead of the version installed via my packages.json. Before the gulp task is run, an npm install task is run successfully targeting the packages.json below. I've confirmed the packages.json version of gulp is installed during the npm step by turning on verbose logging.
My gulpfile.js and packages.json files are at the root of my repo.
Package.json
    "devDependencies": {
        "@types/chai": "^4.0.5",
        "@types/mocha": "^2.2.44",
        "@types/node": "^10.5.2",
        "chai": "^4.1.2",
        "del": "^3.0.0",
        "gulp": "^4.0.0",
        "gulp-delete-lines": "0.0.7",
        "gulp-flatten": "^0.4.0",
        "gulp-install": "^1.1.0",
        "gulp-mocha": "^6.0.0",
        "gulp-nuget": "^1.2.0",
        "gulp-run": "^1.7.1",
        "gulp-string-replace": "^1.1.1",
        "gulp-typescript": "^3.2.3",
        "mocha": "^4.0.1",
        "mocha-junit-reporter": "^1.17.0",
        "mochawesome": "^2.3.1",
        "request": "^2.87.0",
        "tfx-cli": "^0.5.14",
        "ts-node": "^7.0.0",
        "typescript": "^2.9.2"
    }

Task Inputs
Gulp task

File path: gulpfile.js
Advanced

gulp.js location: node_modules/gulp/bin/gulp.js

Error logs
2018-07-25T21:53:14.6303055Z ##[section]Starting: gulp
2018-07-25T21:53:14.6308242Z ==============================================================================
2018-07-25T21:53:14.6308366Z Task         : Gulp
2018-07-25T21:53:14.6308456Z Description  : Node.js streaming task based build system
2018-07-25T21:53:14.6308561Z Version      : 0.130.0
2018-07-25T21:53:14.6308644Z Author       : Microsoft Corporation
2018-07-25T21:53:14.6308741Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkID=613721)
2018-07-25T21:53:14.6308861Z ==============================================================================
2018-07-25T21:53:14.9819487Z [command]C:\Users\svccbld\AppData\Roaming\npm\gulp.cmd --gulpfile E:\agent_work\62\s\gulpfile.js
2018-07-25T21:53:17.5552020Z [21:53:17] Using gulpfile E:\agent_work\62\s\gulpfile.js
2018-07-25T21:53:17.5565027Z C:\Users\svccbld\AppData\Roaming\npm\node_modules\gulp\bin\gulp.js:129
2018-07-25T21:53:17.5565300Z     gulpInst.start.apply(gulpInst, toRun);
2018-07-25T21:53:17.5565577Z                    ^
2018-07-25T21:53:17.5565686Z
2018-07-25T21:53:17.5565858Z TypeError: Cannot read property 'apply' of undefined
2018-07-25T21:53:17.5566100Z     at C:\Users\svccbld\AppData\Roaming\npm\node_modules\gulp\bin\gulp.js:129:20
2018-07-25T21:53:17.5566424Z     at _combinedTickCallback (internal/process/next_tick.js:131:7)
2018-07-25T21:53:17.5566632Z     at process._tickCallback (internal/process/next_tick.js:180:9)
2018-07-25T21:53:17.5566957Z     at Function.Module.runMain (module.js:695:11)
2018-07-25T21:53:17.5567126Z     at startup (bootstrap_node.js:191:16)
2018-07-25T21:53:17.5567279Z     at bootstrap_node.js:612:3
2018-07-25T21:53:17.5921096Z ##[error]Gulp failed with error: C:\Users\svccbld\AppData\Roaming\npm\gulp.cmd failed with return code: 1
2018-07-25T21:53:17.5933925Z ##[section]Finishing: gulp

@daveVSTS, can you provide an ETA on this issue? We're currently blocked from getting our CI to work.

I'm running into exactly the same issue!
Folks should switch to GULP 4 - because of serious vulnerabilities in GULP 3 dependencies..
(which you can't as this issue is blocking it..)
Any ETA on this?

@azureDaveOps / @bryanmacfarlane, please update us on this issue's ETA, or provide a workaround / Gulp alternative recommendation if fixing is not a priority.
We're being flagged for using Gulp 3.x because of its security vulnerabilities, but have no supported upgrade path in Azure DevOps since Gulp 4 isn't supported.

Oh! Very sorry, I did not see that. I will reopen this.
The value you set is node_modules/gulp/bin/gulp.js, which is also the default. I wonder if that could be confusing things. Could you try placing that in a different folder or with a different name?

@moswald, unfortunately, I don't have control over where Gulp is installed -- NPM installs it in an upstream build pipeline task via my repositories package.json. Let me know if I'm missing something.

No problem. I was just hoping that it would be a quick thing to test. I'll investigate why this textbox isn't overriding your gulp location.

It will go out with the next version of Azure DevOps. I think we will begin deploying it the week after Thanksgiving.

@moswald, is the deployment still on for this week? Just trying to get a more accurate ETA. Thanks.

Yes, we've already deployed to the first ring of accounts. I'll follow up with you offline to find out when exactly you can expect to see it.


Add UNIS domain

@AugustoHTPereira There is something odd at the university website: for some reason the admission section tells about the admission in 2018. Did the university stop enrolling in 2018? I am sorry, I can misunderstand something at the website, because I read it with Google Translate.
Also, please clarify whether the institution is a university or a group of universities. If it is a group, where can I read which universities are in the group?

@philipto Thanks for the answer.
I realy don't know if the university have some agreement with JetBrains.
The university website it's terrible, but here is the link of courses page , and here is the computer science course page.
About the university, Unis it's a group of members and they have one university in many cities.

@AugustoHTPereira Pull request merged. Thank you!
FTR: more information about the university network: https://www.linkedin.com/school/grupounis/about/

@philipto Thank you!


Destructuring array will error if no match

const [, city, zipCode] = address.match(cityZipCodeRegex);
This will error if the address doesn't match, but can be fixed with:
const [, city, zipCode] = address.match(cityZipCodeRegex) || [];

Cool! Can you make a PR?

I did

Ah you beat me to it, sorry.
Sent from my iPhone

On 16 Jan 2017, at 17:44, Collin<EMAIL_ADDRESS>wrote:
I did
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Compatibility with non-edu version

Hi, I am planning to purchase a Unitree Go 1 Air, but from what I understand this SDK is not compatible with non-edu products.
Are there any alternatives to be able to communicate with the robot? Are there plans to extend compatibility to non-edu models as well?
Thank you

That's their business model ;)
You pay extra for the software interface...

This is what you need here:
https://github.com/MAVProxyUser/YushuTechUnitreeGo1/blob/main/SDK.md
Feel free to stop by and see us here for help using the SDK with non EDU models.
https://join.slack.com/t/robotdogs/shared_invite/zt-1fvixx89u-7T79~VxmDYdFSIoTnSagFQ


Rename bracket-push exercise

I had troubles with configlet because bracket-push exercise was renamed (exercism/problem-specifications#1501) .  Inspired by #277.
$ configlet generate cpp/
-> 1 error occurred:

* open D:\develop\github\exercism\problem-specifications\exercises\bracket-push\metadata.yml: The system cannot find the path specified.

Ah, I was hoping to try to get #276 merged first to reduce churn, but if you're getting hit with this it should be fixed. Thanks!
Also FYI, you can auto-close related issues using https://help.github.com/en/articles/closing-issues-using-keywords if you put the message in the first note in the PR :)
This is failing the CI because of the rename. The Rust track hit the same issue, because I based our script off of theirs: https://github.com/exercism/rust/pull/819
Luckily they already found the fix. I'm going to add their fix here myself and merge, there aren't any other issues as far as I can tell.


Handle timezone in comment report

The report time seems to be GMT. Is is expected? ... I would suggest at least adding Z : 2023-07-10 17:48:08Z to make it explicit.

Reported by @fleroux514

if you don't have anyone willing to do it so far, I'd be happy to volunteer :)

Yes please! That'd help a lot; assigning to you

it will be included into the next release v0.1.29


Minor corrections while reading through.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Haegi Could you have a look? I am not able to add reviewer.

Thanks. But I dont have authorization to merge either :(


Add the ability to append definitions, to avoid overwriting other distinct valid definitions

If an acronym has more than one use, we currently have to be careful about overwriting preexisting definitions. What if we could just append another one?
/gloss TA

ta
Thanks, pronounced "taah" or "tar", depending on where you're from in the UK.

/gloss TA += TA: Technical Assistance

ta
Thanks, pronounced "taah" or "tar", depending on where you're from in the UK.
TA: Technical Assistance

See also #27
This is a less complicated way of doing it though.

ohhhhh. I didn't see that one, sorry. Let me know if you'd like me to move comments to that issue.


Can't document internal functions

Can we make this work?
let a =
  (** xyz **)
  let b () = 1 in
  b ()

This should attach documentation to the internal function b.

fsdoc is gone. See #1939


CofR_image_sharpness stability tweaks

pre-padding image to keep centre when binned
intermediate search if high initial binning
More descriptive error message

@jakobsj  could you have a go on the sandstone data? I removed the internal padding as I don't think this is very easy for the user to tweak and really impacts performance, so you'll have to pre-pad the data to get a good FBP reconstruction (as you do already) and pass the padded data to the algorithm.
It also seems very noisy so you might have to lift the fit tolerance.


[9.x] Update HasAttributes.php

Being able to set append for relationships/dynamic properties without having manually call/loop to set appends.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Plugin config description

Closes #506
Waiting for @skllcrn to confirm the design
Also need some suggestions on the wording in the docs

Not directly related to this PR, but I feel the config window has too much vertical whitespace. Too much space above the description and between the form elements.

Not directly related to this PR, but I feel the config window has too much vertical whitespace. Too much space above the description and between the form elements.

It's set to padding: 32px 16px. I agree that there's a lot of vertical space, maybe change to 16px both sides? Or 24px 16px
cc @skllcrn

I agree, let's try making it quite a bit more compact with 16px on both sides for now?

Adjusted the padding to 16px:

It looks like the description has a bit too much line height.

And I would move the input label a tiny bit closer to the input.

Looks like the description is a smaller font size, which makes the line height a bit too generous. The description should be 14px, and halving the space between the input and label (to 8px) as @sindresorhus mentioned would improve it further.

Looking really solid buddy

Forgot to attach a recent screenshot:


Create ApolloGame.tlh-tlh.json

I started the initial Klingon file and did a few translations.

Since Klingon doesn't belong to a country, I think the language-code is simply tlh

Technically it belongs to a planet 😜


[Bug]: When we invite users to the default roles from the users tab the roles names are not listed on the UI

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we invite users to the default roles from the users tab the roles names are not listed on the UI

Steps To Reproduce

go to https://ee-2453.dp.appsmith.com/
login as a admin in the ee instance
Now go to users tab and invite<EMAIL_ADDRESS>with developer access with workspace w1
Now check in user tab ui the access isnot listed
but signup as<EMAIL_ADDRESS>the user has access for the workspace

Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
v1.9.39

this issue is fixed


NUnit 3 test adapter (.NET Framework) reports tests twice

Description
When running tests via VsTestConsoleWrapper, the following callbacks are called:

HandleDiscoveredTests(a bunch of tests)
HandleDiscoveryComplete(N, lastChunk: the same bunch of tests, isAborted: false)

Steps to reproduce
See #881 for repro cases and sample code. Based on the log files, this appears to be a bug in VSTest, not the adapter.
Expected behavior
HandleDiscoveredTests is called with a bunch of tests
HandleDiscoveryComplete is called with a lastChunk of null.
Actual behavior
HandleDiscoveryComplete is called with a lastChunk of previously-discovered tests.
Environment
Using Microsoft.TestPlatform <IP_ADDRESS> from the MyGet feed.
Using NUnit3 test adapter 3.8.0-alpha1 from NuGet.
Windows 10 v1703
This behaviour does not occur with the same adapter for .NET Core.

@yaakov-h I followed repro step but unfortunately I am not getting repro.
Can you please share with us a repro code.

Repro code at https://github.com/yaakov-h/VSTest893
Run build.cmd, then run.cmd.
The output I get from run.cmd is:
Running TestRunner for test assembly targeting .NET Framework 4.6...

Will test assembly that targets .NETFramework,Version=v4.6
Found extension NUnit3.TestAdapter.dll
HandleDiscoveryCompleted(totalTests: 1, lastChunk: [1 items], isAborted: False
Discovered 0 tests

Running TestRunner for test assembly tageting .NET Core 1.1...

Will test assembly that targets .NETCoreApp,Version=v1.1
Found extension NUnit3.TestAdapter.dll
HandleDiscoveredTests([1 items]
HandleDiscoveryCompleted(totalTests: 1, lastChunk: null, isAborted: False
Discovered 1 tests
  - TestProject.TestClass.TestMethod

Note that for .NET 4.6, HandleDiscoveredTests is never called, then HandleDiscoveryCompleted is called with a chunk.
For .NET Core 1.1, HandleDiscoveredTests is called with a chunk, then HandleDiscoveryCompleted is called with a null chunk.

@yaakov-h : This behavior is not a bug but by design. The TestPlatform doesn't say that last chunk will be null. See Sample Code
Benefit of having last chunk in HandleDiscoveryCompleted
TestPlatform send HandleDiscoveredTests if number of discovered test is more than a particular size(default is 10 (and this is customizable through run setting)) or time elapsed from last call of HandleDiscoveryCompleted is more than 1.5 second Code here
If any test left after above check we send it in last chunk of HandleDiscoveryCompleted Code here
Now consider a scenario where there is only one tests in test project:
We need to call only one event of HandleDiscoveryCompleted with last chunk which will have one test. Now if we don't want to send test in last chunk then we have to make two call
a) HandleDiscoveredTests with one test
b) HandleDiscoveryCompleted with last chunk null.
Why the behavior is different in case of netcore and net framework
This is due to internal implementation of how we run test for netcore test project.  You will see the same behavior if you will run .NET framework test with parallel enabled.
Can you please let me know what are the issue you are facing due to this behavior

Hmm, that makes sense.
I tried increasing the number of tests and I'm still seeing a difference between netcore and netfx. netcore appears to always call HandleDiscoveredTests with the last chunk of tests, then HandleDiscoveryCompleted with null, whereas netfx appears to always call HandleDiscoveredTests without the final chunk, then HandleDiscoveryCompleted with the final chunk.
As you said, that's expected.
Unfortunately it seems that I cannot reproduce the behaviour I saw previously where HandleDiscoveredTests was called with the final chunk, then HandleDiscoveryCompleted was called with the same final chunk.
I'm closing this issue as I can't reproduce my own bug (:frowning_face:), I'll re-open if I see it again.


Fixed link to Azure SDK Design Guidelines for .NET

Thank you for your contribution, @abatishchev!


Error obtaining render for panel [..]Retrying after 10s - Error 500

Hi @IzakMarais
I am getting this issue which everybody reported:https://github.com/IzakMarais/reporter/issues/39
My grafana version is 8.4.1
Error obtaining render for panel {Id:7 Type:graph Title:Test Graph GridPos:{H:11 W:12 X:0 Y:22}}, Status: 500, Retrying after 20s...

error rendering PNGs in parralel for dash {Title:: VariableValues: Rows:[] Panels:[{Id:2 Type:graph Title: GridPos:{H:11 W:12 X:0 Y:0}} {Id:4 Type:piechart Title: GridPos:{H:11 W:12 X:12 Y:0}} {Id:5 Type:graph TitleGraph GridPos:{H:11 W:12 X:0 Y:11}} {Id:6 Type:piechart Title:Graph( Pie Chart) GridPos:{H:11 W:12 X:12 Y:11}} {Id:7 Type:graph Title:Graph GridPos:{H:11 W:12 X:0 Y:22}} {Id:8 Type:piechart Title Graph( Pie Chart) GridPos:{H:11 W:12 X:12 Y:22}}]}: error getting panel {Id:2 Type:graph Title: Graph(From 4th March) GridPos:{H:11 W:12 X:0 Y:0}}: Error obtaining render: 500 Internal Server Error

Did you find a solution on this? I have tried various data types, graph, chart, stat ect but still getting the same error.
I installed the image render Grafana plug in, which was mentioned a few times to fix the issue but now I cannot even get the PDF to open.

I had the same error for a while. After looking into my Grafana Server, the error originated from missing libraries regarding the Image Rendering Plugin. It seemed like Grafana still couldn't render images even with the plugin.
As such, I installed all dependencies related to that subject (seen on a project called "Puppeteer") and it worked! :)
Dependencies:
ca-certificates fonts-liberation libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release wget xdg-utils
(from https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#chrome-headless-doesnt-launch-on-unix or )

THanks for the feedback @Dariod9 .


lower request timeout for faster recovery from partition in system tests

was debugging flaky partition 30_70 and 50_50 tests.
in both of those tests some nodes were "stuck" on requests to the peers that were on the other side of partition.
connections to them are blocked, but they wait for 25s to receive a response. this prevents them from moving to peers
on their own side of the partition and completing requests.
also since layer time is 15s, if they are blocked on several such requests they will not be able to make progress and fall into unsynced state.
https://github.com/spacemeshos/go-spacemesh/actions/runs/8375974512/job/22934603108
https://github.com/spacemeshos/go-spacemesh/actions/runs/8364722559/job/22900753485

bors try

bors merge

bors merge


Drop 'update default theme' configuration

Questions
Answers

Description?
Drop 'update default theme' configuration. We will systematically update the theme

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
-

Sponsor company
-

How to test?
The theme update configuration is no longer present, on the WEB or on the CLI. The theme is well updated

Hello @M0rgan01
Could you guys share the reasoning for this change? It is very common for users to use Classic and modify Classic. We all know it is not recommended, but it is what it is.
Is it because you plan to improve this setting or the plan is to always update the default theme?

Hi @kpodemski ! The theme will be updated in order to avoid that the theme is broken during a major update. The other configuration "PS_AUTOUP_CHANGE_DEFAULT_THEME" will be modified to retrieve a list of themes, and will switch to this one during the update

While I understand the reasoning, you could approach this differently. You could require people to upgrade their theme only if they do a major upgrade, and you could allow the theme to remain unchanged during patch and minor upgrades. I'm certain that we will hear complaints from people if we don't make any compromises.
cc @gericfo

@M0rgan01

and will switch to this one during the update

I hope you don't mean to switch to default theme automatically? 🤔 That would be a bad behavior.

@Hlavtox You can choose the theme you want to switch to.

@M0rgan01 Do I have an option to stay on the current theme, because I tested it on the new version and made it compatible?

@kpodemski @Hlavtox
We will suggest that you stay on the current theme, or switch to one of the themes present in the release.
If you had custom themes, you will still be able to use them after the release.
If you had directly modified the classic theme, which is bad practice for customizing themes, the modifications will be deleted with the upgrade.

@M0rgan01

If you had directly modified the classic theme, which is bad practice for customizing themes, the modifications will be deleted with the upgrade.

That's a risky choice not to let user decide, especially for the patch or minor upgrade, we will see how this goes.

We agree with you, but if we look at the metrics, 87% of users do not touch this option, and update their classic theme following an update.
Users must follow the parent/child feature for themes https://devdocs.prestashop-project.org/8/themes/reference/template-inheritance/parent-child-feature/.
If we see that this change poses a problem later, it is entirely possible to go back

@M0rgan01 The autoupgrade module must not touch a third party theme.

If you had custom themes, you will still be able to use them after the release.

Yes, but it must not switch to classic theme, because it completely messes up the shop - enables modules, disables modules, hooks modules, fucks up layout configuration. No go.

@Hlavtox

The autoupgrade module must not touch a third party theme.

It will not touch the third-party module.
There will be the possibility of remaining on the current theme so for me there is no problem

@M0rgan01 OK, that's good and OK! :-)


The function or variable 'center' is not recognized.

Hello,I have a question here.When I run synthetic1.m,it shows "The function or variable 'center' is not recognized." in the mbfpca function. I didn't find the center function in the project.

Hi, sorry for the late reply.
In the latest commit, this error has been fixed, and thus I'll close this issue.

Hi, sorry for the late reply.
In the latest commit, this error has been fixed, and thus I'll close this issue.


Add capatilisation to translation & some margin for the input

Details

https://github.com/Expensify/App/issues/4673#issuecomment-899671542
We need some top margin and capitalization of the required translation.
Fixed Issues

$ #4673
QA Steps

1.Click on the global create button
2.Click on request money
3. Set an amount
4. Select another user as an attendee

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop
[ ] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Confirmed on iOS and Desktop, will merge when the iOS check completes

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08.  :confetti_ball:


Issue140.awinters.2

Pull request questions
Which issue does this address
Issue number: #140
Why was change needed
For compatibility with<EMAIL_ADDRESS>release

CI totally expected. needs updated versions for sdk-graph-components and rest-api-client-ng. just fyi

It looks like you temporarily removed the bulk data stuff since it was not ready for primetime anyway so we could get this running on the 2.0 API -- is that the case? If so then I am fine with removal, just wondering when we will restore it.

Kind of, it was relocated to the entity-search-webapp project early on due to issues getting things to properly handle in sub-routes/lazy loaded modules. I just didn't remove it from the sdk until now, 2.0.0 seemed like a logical choice since breaking changes and such.


finding-percentage.py

The provided code stub will read in a dictionary containing key/value pairs of name:[marks] for a list of students. Print the average of the marks array for the student name provided, showing 2 places after the decimal.
Example
The query_name is 'beta'. beta's average score is .
Input Format
The first line contains the integer , the number of students' records. The next  lines contain the names and marks obtained by a student, each value separated by a space. The final line contains query_name, the name of a student to query.
Constraints
Output Format
Print one line: The average of the marks obtained by the particular student correct to 2 decimal places.
Sample Input 0
3
Krishna 67 68 69
Arjun 70 98 63
Malika 52 56 60
Malika
Sample Output 0
56.00
Explanation 0
Marks for Malika are  whose average is
Sample Input 1
2
Harsh 25 26.5 28
Anurag 26 28 30
Harsh
Sample Output 1
26.50

Congratulations for your Open source contribution. Don't forget to add a star on this repo.. Happy hacking


Refactoring E1029 to take exclusion criteria from a JSON spec file

Issue #, if available: None
Description of changes: I moved all of the hard-coded excludes into a new AdditionalSpecs/SubNeededExcludes.json spec file, and refactored rule E1029 to use it. Whilst this does not address the need for periodic updates to keep the rule in sync with discovered false-positives, it does mean any future updates can be done solely in the new json file, which in turn opens up opportunities to improve how this file is populated.
See https://github.com/aws-cloudformation/cfn-python-lint/pull/1646 for some background discussion.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

With the most recent change, this closes #1662

Properties like PolicyDocument, UserData, RequestMappingTemplate, ResponseMappingTemplate seem the same across resource types. Wondering if we could just treat them the same regardless of resource type rather than needing to specify every resource type with these properties


[Bug] An unknown error message poped when open Json file which contains "ScriptType"

Version: 0.1.2
Issue:
An unknown error message poped when open Json file which contains "ScriptType".

Resolved.


Permission node?

Is their a permission node to add? Using Luckperms with sponge. Cant run any commands in game which doesn't help much.

No, TickProfiler does not have any permission nodes.
By default some commands are only available for /opped users. You can change this in the config file.

Yeah it's just with permissions on sponge OP does nothing and everything is permission based after that
Get Outlook for Androidhttps://aka.ms/ghei36
On Wed, Jan 18, 2017 at 7:26 AM -0500, "Ross Allan" <notifications<EMAIL_ADDRESS>wrote:
Closed #59https://github.com/nallar/TickProfiler/issues/59.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/nallar/TickProfiler/issues/59#event-927374016, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADYBu3RWVJkKSLUbL4rJG-n4yoPeEIeTks5rTgTagaJpZM4Ler8i.

Try changing the settings not to require OP in the config file.

Closing due to combination of "not my problem" (I don't create permission nodes, if your sponge plugin breaks my mod then that's not my fault), and user not trying turning off the config options to require /op.

I did,  doesnt really break it and didn't really want users to have access to tps.  Kind of a bad attitude I'll find another tool thanks.

I did,  doesnt really break it and didn't really want users to have access to tps.  Kind of a bad attitude I'll find another tool thanks.

You didn't reply to me to let me know that that worked.
I can't add a permissions node without introducing a dependency on sponge which is unacceptable for most users of this mod. If there's a bug here it's that sponge/the permission system you're using for sponge doesn't allow you to configure permissions for mod commands.

Try adding permissions for TickProfiler.command.profile or possibly tickprofiler.command.profile. I'm not sure which capitalisation will work or if it's actually case sensitive.
It turns out that sponge automatically creates permission nodes for mod commands:

For any Forge mods that use the vanilla command API, command permissions are provided in the form .command..

For future reference, I was able to get tickprofiler.command.profile to work


Accumulation of hazardous gas

Keep track of the duration a person is exposed to the hazardous gas.
EV: Isn't this something that should be done by Floris?

Out of Scope


Don't try to load training_args.bin

While trying to load a fine-tuned model, I was getting this exception:
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/opt/venv/lib/python3.10/site-packages/vllm/entrypoints/api_server.py", line 82, in <module>
    engine = AsyncLLMEngine.from_engine_args(engine_args)
  File "/opt/venv/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 212, in from_engine_args
    engine = cls(engine_args.worker_use_ray,
  File "/opt/venv/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 49, in __init__
    self.engine = engine_class(*args, **kwargs)
  File "/opt/venv/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 97, in __init__
    worker = worker_cls(
  File "/opt/venv/lib/python3.10/site-packages/vllm/worker/worker.py", line 45, in __init__
    self.model = get_model(model_config)
  File "/opt/venv/lib/python3.10/site-packages/vllm/model_executor/model_loader.py", line 49, in get_model
    model.load_weights(
  File "/opt/venv/lib/python3.10/site-packages/vllm/model_executor/models/llama.py", line 248, in load_weights
    for name, loaded_weight in hf_model_weights_iterator(
  File "/opt/venv/lib/python3.10/site-packages/vllm/model_executor/weight_utils.py", line 74, in hf_model_weights_iterator
    state = torch.load(bin_file, map_location="cpu")
  File "/opt/venv/lib/python3.10/site-packages/torch/serialization.py", line 809, in load
    return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
  File "/opt/venv/lib/python3.10/site-packages/torch/serialization.py", line 1172, in _load
    result = unpickler.load()
  File "/opt/venv/lib/python3.10/site-packages/torch/serialization.py", line 1165, in find_class
    return super().find_class(mod_name, name)
AttributeError: Can't get attribute 'TrainingArguments' on <module 'vllm.entrypoints.api_server' from '/opt/venv/lib/python3.10/site-packages/vllm/entrypoints/api_server.py'>

Hi @lpfhs! Thanks for your contribution! Can you provide the name of the model that can cause this error for us to test out?

Just want to make sure this is a common pattern instead of a specific case for a specific model. Is this only introduced by the specific training script in FastChat, or any fine-tuned HuggingFace model will have this training_args.bin?

@zhuohan123 I think the issue is that FastChat has a custom TrainingArguments class, so when we're loading the pickle file, we need the definition of this custom class. From some web search, it seems transformers package is able to load training_args.bin if it's not a custom class (i.e. it's transformers.TrainingArguments).

running into the same issue


docs(readme): remove contributing guidelines

... this will be moved to the wiki for now.

Sorry, but I'd have one more request: We should also add a link to the wiki. Can you do this as well?


[component]: Segmented button

Description
Open issues:
Design:

[x]  Integrated new typography
[ ]  Spacing is defined
[ ] Documentation final

Design
https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=18-16
Tokens proposal

button-segmented-horizontal-border-radius
button-segmented-vertical-border-radius
button-segmented-active-fg
button-segmented-active-bg
button-segmented-default-fg
button-segmented-default-bg (should be transparent, do we need this at all?)
button-segmented-border
button-segmented-padding-block
button-segmented-padding-inline
button-segmented-font-size

Development
Implement this pattern as a radiogroup.
<fieldset class="segmented-button">
  <legend>Title ("Change view" or whatever makes sense, this should be hidden)</legend>
  <label>
    View 1
    <input type="radio" />
  </label>
  ...
</fieldset>

Other requirements

Use container queries to switch from horizontal to vertical mode
You can use the label to style the component and hide the input itself, it's also possible to put the label after the input and connect it through the for attribute. The for attribute is not necessary when the input is wrapped by the label.
Hide the legend element from view, but make it accessible to screen readers by using the visually-hidden mechanics

Implementation references

https://codepen.io/trevald-the-scripter/pen/eYpYgMp

Tasks
### 💻 Tasks
- [x] Review Design (All states present? Possible to implement?)
- [ ] HTML/CSS implementation
- [ ] Documentation in Storybook
- [ ] Unit tests
- [ ] End to end tests
- [ ] Visual regression tests
- [ ] Design review

@Vandapanda created a tokens proposal in the issue description.

Certain tokennames have been modified to comply with the naming conventions. Additional tokens added where necessary.


Mediation libraries support

According to the docs, mediation libraries still require using CocoaPods.

Is this on the roadmap, and does the team have an ETA they can share?
Thanks!

Hi @ilazakis,
Thank you for your inquiry. At this time we do not have an ETA that we can share but it is something we are aware is a need for developers (this post helps).
Thanks

For posterity's sake I've re-opened and marked it as a feature request 👍

google ads and mediations are the last components managed by CocoaPods in my project, really really hope this request could be considered.

You can also file your request on the Developer Forum.

Hi @malandr2; just checking if there are any updates on ETAs for this? Thanks in advance!

@malandr2 any update on this? using cocoapods in 2024 is a joke as SPM is the official package manager. it couldn't take more than a few hours to just support all mediation libraries in SPM. just add the direct links in Package.swift

I'm not sure what the reasoning is for not doing this, but could it be related to this issue?
tl;dr: The mediation libraries use 4-part version numbers (e.g. <IP_ADDRESS>) when Apple is requiring that it use 3 (12.2.1)? I don't claim to know your development flow, but I imagine changing the versioning scheme and/or tools that generate it shouldn't require too much development burden.
As mentioned in the other thread,

Now GoogleMobileAds requires xcode 15.3 and this dependency blocks it. Please post a fix on that!

So it would be very helpful if we would be able to do this.

Hi @malandr2, thank you for the ongoing discussion and support on this feature request; just checking in for any updates.
With Cocoapods in maintenance mode, and very soon in read-only mode, there's presumably a strong enough reason to prioritize this within the team?
Thanks!


Reanimated 2.3 support

Upgraded example app to Expo SDK 44
Upgraded React/React Native versions to Expo 44 versions
Upgraded React Native Gesture Handler & React Native Reanimated to 2.3

Status
Everything is working well here. The current version does also work with Reanimated 2.3. However, there is one problem.
LineChartPath Width issue
The only issue I'm seeing with Reanimated 2.3 is that, when you stop pressing down on the chart, the line path doesn't animate to its final state. Instead, it just snaps there. It's as if the withTiming is doing nothing.
Here's a comparison. Notice what happens to the path when I stop pressing down.

Reanimated 2.2 (correct)
Reanimated 2.3 (wrong

I'm investigating this, and will push it to this PR once I figure it out.

Solved the final issue. Turns out, Reanimated 2.3 doesn't animate if you conditionally all withTiming. I opened an issue for that here: https://github.com/software-mansion/react-native-reanimated/issues/2752.
Basically, this does not animate, since withTiming is conditional.
const style = useAnimatedStyle(() => ({
  width: isActive.value ? 100 : withTiming(300)
}))

The workaround is to always call withTiming, and to set a duration of 0 when we don't want to animate:
const style = useAnimatedStyle(() => ({
  width: withTiming(isActive.value ? 100 : 300, {
    duration: isActive.value ? 0 : duration
  })
}))

I implemented this strategy in this commit.
None of the changes in this PR are breaking. They are strictly forwards-compatible.
I think it's good to go. Would appreciate your review @jxom. Thanks!

Thanks for all your help @nandorojo! ❤


Add Project/Organization Branding to Resource Pages

We have had requests for adding branding to HydroShare resource landing pages. We want to be able to have some project-level branding so that we can easily identify that a resource was paid for, created by, and is associated with a project or an organization. Perhaps similar to the addition of a funding agency but with recognition in a prominent position on the resource landing page.

I would be supportive of having each resource hold a logo file that gets displayed somewhere near top right of the landing page.  I think we need a pass at redesigning the landing page after the AGU release to accommodate this issue and the coverage map issue #1052.  Assigning both of these as medium priority and to release 1.10.0

Look also at #518 when redesigning landing page.

Closing per backlog review meeting on 6/9/22. stale.


Add caddy server to arkade get

Description
Added Caddy binary to arkade get
Motivation and Context

[X] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required) #684

How Has This Been Tested?
Covered with unit tests and tested with e2e test as well.
Also tested with the usual shell script:

Are you a GitHub Sponsor yet (Yes/No?)

[ ] Yes
[X] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[X] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

[X] I have tested this on arm, or have added code to prevent deployment

Both of these last ones look wrong to me.
Windows x86_64 should not be a 32-bit ARM binary
The Windows/arm64 combo is showing 32-bit ARM which is wrong, and as we have discussed in the past, we don't have Windows / ARM64 binaries in arkade.


tunnelx: minor refactor and cleanup

Follow up of https://github.com/NixOS/nixpkgs/pull/239739
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@NixOS/darwin-maintainers I would like help with this derivation. I'm pretty sure it's possible to run it on Darwin.

From @Cu3PO42

The log states that the Mesa package is marked as broken on Mac. The package definition references this issue: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8634 which does not appear to be resolved yet.

I'll set platforms to Linux only.

I do not believe Mesa should be required for this package on Linux from what I'm seeing. Investigating now though.

Thanks :)

This package builds but I worry I may have broken the GUI components of survex in the process. I'm afraid I've never gone caving outside of Colossal Cave Adventure before; could you tell me how to exercise tunnelx's dependencies on those binaries?

There’s also a tracking issue for Mesa on Darwin.
https://github.com/NixOS/nixpkgs/issues/233265

I have no clue, maybe @goatchurchprime can help ?

Okay, I source dived and checked the survex executables tunnelx uses; they all start with this patch, even the aven GUI. Can't guarantee that this hasn't broken something on the survex side but it's clearly an improvement over the status quo; I'm going to call this good enough:
diff --git a/pkgs/applications/gis/tunnelx/default.nix b/pkgs/applications/gis/tunnelx/default.nix
index 174796b3bf5..21cc485e752 100644
--- a/pkgs/applications/gis/tunnelx/default.nix
+++ b/pkgs/applications/gis/tunnelx/default.nix
@@ -36,9 +36,10 @@ stdenv.mkDerivation (finalAttrs: {

     mkdir -p $out/bin $out/java
     cp -r symbols Tunnel tutorials $out/java
+    # `SURVEX_EXECUTABLE_DIR` must include trailing slash
     makeWrapper ${jre}/bin/java $out/bin/tunnelx \
       --add-flags "-cp $out/java Tunnel.MainBox" \
-      --set SURVEX_EXECUTABLE_DIR ${lib.getBin survex}/bin \
+      --set SURVEX_EXECUTABLE_DIR ${lib.getBin survex}/bin/ \
       --set TUNNEL_USER_DIR $out/java/

     runHook postInstall
diff --git a/pkgs/applications/misc/survex/default.nix b/pkgs/applications/misc/survex/default.nix
index b23cd02220b..6f2098ea477 100644
--- a/pkgs/applications/misc/survex/default.nix
+++ b/pkgs/applications/misc/survex/default.nix
@@ -45,14 +45,16 @@ stdenv.mkDerivation rec {
   buildInputs = [
     ffmpeg
     glib
-    libGLU
-    mesa
     proj
     wxGTK32
   ] ++ lib.optionals stdenv.hostPlatform.isDarwin [
     Carbon
     Cocoa
   ] ++ lib.optionals stdenv.hostPlatform.isLinux [
+    # TODO: libGLU doesn't build for macOS because of Mesa issues
+    # (#233265); is it required for anything?
+    libGLU
+    mesa
     libICE
     libX11
   ];

Unbelievable work, completely unexpected and brilliant. Thank you so much!

I was feeling a little bit concerned for merging the related pr too quickly and noticing later on that I missed plenty of things to do ... And in the meantime, the Darwin maintainers improved the Darwin support :)


CI should disallow stale Cargo.lock.

E.g. #301 changed a dependency but didn't include the Cargo.lock change.
This should be easy to fix by just adding --locked to the CI cargo commands, which will error if Cargo.lock isn't up to date.

Should we just remove it altogether? I don't know if it's particularly valuable here, especially when this is ostensibly a dynamic library, as opposed to a binary that people are installing and running on their own.


How to debug Client ?

Hello.
I want to Debug client.
Please tell me how ?

Build it with your desired settings in debug configuration. If you want to debug it with installation enabled you have to attach the Visual Studio Debugger once it's installed and running.

Thank you for fast answering.
You mean i set desired settings in client and after that build the project.
and run client and attach VS debugger to it.
Yes ?

set client project as active

Exactly.


database-setup-bug-fixes

Touch Listener hitbox correction.
Change back to MainMenu if game_uuid doesn't exist.
Added game over firebase field in game_uuid.
Removeing Game_Uuid on game over.
Added game_outcome tracker.
Leave button functionality.

Thanks for the changes!


⚠ Bofrost.be has degraded performance

In 1c9d86a, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1128 ms

Resolved: Bofrost.be performance has improved in c122897 after 6 minutes.


Node version

Just wondering if you might consider changing from node:lts-slim to something with a newer node version? :)

Which node version would you prefer? What is the requirement to have a newer version of node available/what benefit would it provide over LTS?

When we use an older version of node we get memory errors FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
But when running node 12 it works fine... guess there are improvements to memory usage. :)

We are using a workaround where we use node --max_old_space_size=3072 node_modules/@angular/cli/bin/ng build --prod --configuration=production and that works so there no critical need..
What are the benefits of not running node 12?
(v12 will have a "Active LTS Start" on 2019-10-22 so there are just a few days left 😁)

Under what conditions are you observing the issue? Is it during project build or test execution? Is it an ionic project or plain angular?

this is when building --prod.. a plain angular project.
There are several github issues on this topic :)
https://github.com/angular/angular-cli/issues/13734
https://github.com/angular/angular-cli/issues/15242
https://github.com/angular/angular-cli/issues/9157

Did you try to set this environment
NODE_OPTIONS=--max_old_space_size=4096 (or even 8192)
or use a custom build command to increase the the available memory?
"scripts": {
        "start": "node --max-old-space-size=4096 ./node_modules/@angular/cli/bin/ng serve",
        "build:prod": "node --max-old-space-size=4096 ./node_modules/@angular/cli/bin/ng build --prod",
}

Some commenters reported that using Angular CLI of at least 8.2.6 solved their memory problem - is that the case with your project as well?

Additional notes:
If you are running docker on Windows or Mac you might need to configure the docker VM to provide enough memory as well.
Node 12 will become LTS as of 2019-10-21 - the next image build after that date will therefore upgrade node.js automatically.

@everflux as stated earlier, yes we do use this workaround..
We are using CLI version 8.3.6
Our CI is an unix gitlab runner with 3GB ram if I remember correctly :)

sorey didn’t recollect your comment when writing the proposed work around.
I will leave this issue open until the lts node version is bumped to 12 which should be rather soon.
Thanks for getting in touch and your feedback!

Just realised that we had bigger issues using this image 😂
we have several issues similar to this one:
npm WARN checkPermissions Missing write access to /builds/fodi/fodi-market/node_modules/@angular-devkit/architect/node_modules/tslib

Node 12 is now LTS and in latest and 8.3.13 images.
Please open a separate issue if you encounter different problems or have improvement suggestions, thank you!


Doc Site Migration

Hello everyone! There has been a lot of changes over the pas one year with regards to the development of DeepStack. I understand many users have been unhappy with the fact that development has stalled on this project and the docs site is down.
My apologies for  this. Going further, I would be maintaining DeepStack has an individual project.
Henceforth, the docs can be found here.
https://deepstack.readthedocs.io/en/latest
In the next couple of weeks, I would be making updates towards release of a new deepstack with a focus on giving users the best AI tool and enabling hyper fast inference on a wide variety of hardware.
More updates would be posted as changes are made
Regards,
John Olafenwa

Hi,
How is the next release going?

I'm very happy that you plan to continue DeepStack.

I think this in not happening. No real activity.