Important link

Thanks for including how to change the value.  This points to an obsolete feature.  should refer to ChangeView.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 312e82a0-2119-24ed-2f39-42151b07aac4
Version Independent ID: 80e3a8e2-a361-43fc-0030-8e035c402123
Content: ScrollViewer.ZoomFactor Property (Windows.UI.Xaml.Controls) - UWP app developer
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.controls.scrollviewer.yml&version=GBlive&_a=contents
Product: uwp
Git Login: wdg-dev-content
Microsoft Alias: wdg-dev-content

Link was updated.


Windows fails to install because EVN variables do not exist

By default we use the check on line 2.
However, there are cases when neither of these variables exist.
I recently encountered this on the modern.ie win7 ie11 vagrant box when attempting to install selenium.
I suggest falling back to ENV['ProgramFiles'] when the previous values do not exist.

Sounds good. Can you please submit a PR?

Would replacing ENV['ProgramW6432'] with ENV['ProgramFiles'] be the best approach?

I don't know enough ruby to add appropriate tests.
There is actually a few cases to cater for http://stackoverflow.com/a/11211727
program_files = node['java_se']['arch'] == 'x64' ? ENV['ProgramW6432'] : ENV['ProgramFiles'] should do the trick.
On a 64 bit system ProgramW6432 will always point to C:/Program Files and on a 32 bit system ProgramFiles will always point to C:/Program Files.
Note: Although we are targeting the same directory ProgramFiles won't always point to  C:/Program Files on 64 bit systems hence the need for ProgramW6432.

This breaks the install...

I had to test for env variable:
https://github.com/dhoer/chef-java_se/blob/master/libraries/default.rb#L76-L82
See if this works for you.

Waiting for a thumbs up or down on this. If all is good, then I will release it.

I went ahead and released.  Please reopen if you are still having issues.


Documentation for Dashboard is wrong

Do you want to request a feature or report a bug?

Bug

What did you do?
Documentation is wrong

What did you expect to see?
This page: https://docs.traefik.io/operations/dashboard/#secure-mode
Says:
# Dashboard
#
# Optional
# Default: true
#
--api.dashboard=true

If I omit the parameter, Default: true should take place. But that's not true. Default value is actually false.
What did you see instead?
time="2020-06-24T15:25:19Z" level=error msg="api is not enabled" entryPointName=https routerName=dashboard@docker

Output of traefik version: (What version of Traefik are you using?)
Not relavant

What is your environment & configuration (arguments, toml, provider, platform, ...)?
Not relavant

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
Not relavant

The default value of --api.dashboard is true.

@ldez that doesn't make sense if you still need --api. Documentation is confusing.
In fact as a new traefik user i can tell you that documentation is a torture in general. Please, accept feedback and start improving it. There are many people with issues just because documentation is so confusing

We always accept constructive feedback, and we always appreciate constructive feedback.
The default value of --api.dashboard is true, and you have to --api to enable the api and dashboard.
The dashboard require the api, so dashboard is a sub-option of api.

Yeah, now i get it, but here is another example:
If you just set --api.dashboard=false you are enabling api and disabling dashboard? that is so confusing.
Plus if --api.dashboard is true but default, why that doesn't work? Documentation should state that you still need to enable api. Is not explained and not obvious

Plus if --api.dashboard is true but default, why that doesn't work? Documentation should state that you still need to enable api. Is not explained and not obvious

The default value of dashboard in --api.dashboard is true, but this default value is applied only if you enable the API.
The dashboard require the api:

the dashboard need that the api is enable.
if the api is not enable, the dashboard is not enable also.
if the api is enable, the dashboard is enable also.

We don't activate the api by default because of security reasons.

Then update documentation with this useful info, because now lacks of it and it's really confusing


KAFKA-6998: Disable Caching when max.cache.bytes are zero.

As titled, add a rewriteTopology that 1) sets application id, 2) maybe disable caching, 3) adjust for source KTable. This optimization can hence be applied for both DSL or PAPI generated Topology.

Defer the building of globalStateStores in rewriteTopology so that we can also disable caching. But we still need to build the state stores before InternalTopologyBuilder.build() since we should only build global stores once for all threads.

Added withCachingDisabled to StoreBuilder, it is a public API change.

[Optional] Fixed unit test config setting functionalities, and set the necessary config to shorten the unit test latency (now it reduces from 5min to 3.5min on my laptop).

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Simple benchmark with max.cache.bytes set to 0, comparing this branch:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2018-08-10--001.1533946299--guozhangwang--K6998-remove-cache-layer-0cache--39992c1/report.html
with trunk:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2018-08-10--001.1533945494--guozhangwang--trunk-0cache--7fc8509/report.html
The results shows that when caching is off, this branch is consistently better than trunk, resulting in 10 - 50 percent performance boost.

+1

@guozhangwang Feel free to merge after rebasing and green Jenkins build


Update mysql-connector-java to 8.2.0

About this PR
📦 Updates mysql:mysql-connector-java from 8.0.33 to 8.2.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "mysql", artifactId = "mysql-connector-java" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "mysql", artifactId = "mysql-connector-java" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #408.


Backwards compatible dangling parenthesis

I'm sure I had a ticket for this. But it seems to have disappeared. Maybe I dreamt it.
One of the biggest changes introduced by this fork was better dangling parenthesis behaviour. However, there is no option to get the old behaviour and this is stopping people from being able to upgrade scalariform, or in some extreme cases (like at my work) Eclipse.
Can you please look into this or let us know how to add the option. This is becoming really quite critical for me.

+1

I think this is the issue you're looking for. I also hope that you meant to say Ensime and not Eclipse :-P
+1 from me too.

@andrebeat well, Eclipse users can upgrade to ENSIME ;-) But actually I did mean Eclipse... some teams can't upgrade because their formatting all changes and that totally breaks merging and branching strategies. This is actually a really big deal.

I'm going to look into this today / tomorrow. @daniel-trinh I'll send you a PR and try to help round the troops of scala-ide to try and make the documentation around scalariform a bit better for people to know where active development is happening.

Note that #80 would address this (and by extension, #29).

@jawshooah awesome! I'll take a look at that

actually, I think you found the ticket that I thought I'd dreamt up. Dupe of #29


Title meaning

“ transactions with escrow protection and decentralized arbitration for all your online marketplace needs.”

What is escrow protection and does it connect with decentralized arbitration ?
What a you protecting from ?

Let's review this title to explain what the demo is actually showing.

Escrow protection is a mechanism where funds or assets are held by a neutral third party (the escrow) until both the buyer and seller meet the agreed conditions of a transaction. This protects both parties by ensuring that payments are only released once the terms are fulfilled. In the case of Deword the neutral third party happens to be the smart contract.
Decentralized arbitration connects to escrow by providing a way to resolve disputes. If an issue arises, an independent arbitrator steps in to decide the outcome. This system protects users from fraud, ensuring trust and fairness in transactions. It is decentralised because anybody can permissionlessly set up on the platform as an arbitrator. Users choose to use a particular arbitrator based on the reputation they have build over time.


[BUG] NPE during serialization for shuffle in array-aggregation-with-limit query

Describe the bug
Similar to #5140 when the column partition has only null data we hit an NPE with a query like this:
>>> spark.createDataFrame([ [None] ], 'a array<int>').selectExpr('ARRAY_MAX(a)').limit(1).collect()

throws
java.lang.NullPointerException
        at ai.rapids.cudf.JCudfSerialization$DataOutputStreamWriter.copyDataFrom(JCudfSerialization.java:645)
        at ai.rapids.cudf.JCudfSerialization$DataWriter.copyDataFrom(JCudfSerialization.java:592)
        at ai.rapids.cudf.JCudfSerialization.copySlicedAndPad(JCudfSerialization.java:1150)
        at ai.rapids.cudf.JCudfSerialization.sliceBasicData(JCudfSerialization.java:1440)
        at ai.rapids.cudf.JCudfSerialization.writeSliced(JCudfSerialization.java:1520)
        at ai.rapids.cudf.JCudfSerialization.writeSliced(JCudfSerialization.java:1563)
        at ai.rapids.cudf.JCudfSerialization.writeToStream(JCudfSerialization.java:1613)
        at com.nvidia.spark.rapids.GpuColumnarBatchSerializerInstance$$anon$1.writeValue(GpuColumnarBatchSerializer.scala:96)
        at org.apache.spark.storage.DiskBlockObjectWriter.write(DiskBlockObjectWriter.scala:283)
        at org.apache.spark.shuffle.sort.BypassMergeSortShuffleWriter.write(BypassMergeSortShuffleWriter.java:171)
        at org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59)

If there a non-null row then the result is correct:
>>> spark.createDataFrame([ [None], [[1]] ], 'a array<int>').selectExpr('ARRAY_MAX(a)').limit(10).collect()
22/05/12 02:58:31 WARN GpuOverrides:
*Exec <CollectLimitExec> will run on GPU
  *Partitioning <SinglePartition$> will run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> array_max(a#28) AS array_max(a)#30 will run on GPU
      *Expression <ArrayMax> array_max(a#28) will run on GPU
    ! <RDDScanExec> cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.execution.RDDScanExec
      @Expression <AttributeReference> a#28 could run on GPU

[Row(array_max(a)=None), Row(array_max(a)=1)]

Steps/Code to reproduce bug
Start pyspark REPL to execute steps above
Expected behavior
the failing query should return NULL for a NULL-valued array-typed row
[Row(array_max(a)=None)]
Environment details (please complete the following information)

anywhere, local dev

Additional context
N/A

I was unable to reproduce this with a local Spark 3.2.1 on rapids4spark hash e41a6f35 and cudf hash 2b204d04.
That being said, I can see in the cudf JCudfSerialization code how this might happen if a buffer is null in the column view.

I use https://github.com/gerashegalov/rapids-shell
rapids.sh -m=local[1] -cmd=pyspark

Dug into this, and the NPE is a result of bad behavior in cudf documented by rapidsai/cudf#10556.  The RAPIDS Accelerator evaluates an expression which must produce the same number of output rows as input rows.  After the bad segmented max evaluation the single row input column becomes a zero row output batch, but this is part of an overall projection which expects the number of output rows to be the number of input rows.  This ends up building a ColumnarBatch with a row count of 1 but the column within has a row count of 0, causing a non-zero copy of a null data buffer.

No plugin change needed if the cudf dependency is fixed.

fixed by https://github.com/rapidsai/cudf/pull/10876


Flask marshall_with many bug after change to version 1.1

After changing to from version 1.0.3 to 1.1 my marshall with many code breaks
from marshmallow import fields
from flask import Blueprint
from flask_apispec import marshal_with, doc
from database import Team
from marshmallow import Schema

bp = Blueprint("team", __name__, url_prefix="/teams")

class TeamSchema(Schema):
    id = fields.Str(required=True, dump_only=True, example="1")
    name = fields.Str(required=True, example="123 Abc")

@bp.route("")
@marshal_with(TeamSchema(many=True), description="A list of teams.")
@doc(tags=["Team"])
def search():
    """Fetch the list of teams, ordered by name."""
    return Team.query.order_by("name")

And gives the following error when invoked either by localhost/teams
TypeError: The view function did not return a valid response. The return type must be a string, dict, tuple, Response instance, or WSGI callable, but it was a list.
When running when changing to flask 1.0.3 it works. Without an error
Environment

Python version: 3.6.8
Flask version: 1.1
Werkzeug version: 0.15.5
marshmallow:  2.20.2

Sounds like a problem with flask_apispec. Check their docs.


Apply oversampling after image size estimation

To make NLINV and NUFFT perform in the same way and return the same image sizes the image dims are now estimated first by using the original trajectory before applying the internally used oversampling.

Thank you Martin! Your contributions are highly appreciated!


Question: What is the minimum size of an image that can be classified?

I want to use Bunny-Llama-3-8B-V to do binary classification (e.g. yes or no) on very small images. Specifically, I am going to use the cropped bounding box patch (which is the result of Object Detection) as input for Bunny-Llama-3-8B-V and verify whether the class of bounding box is correct. Can you tell me the approximate minimum image size that can be classified? The prompt will use the following input. The input images have various sizes and appearances as shown below.
prompt:
Based on the given image, answer the following question with 'yes' or 'no': Question: [Is there a person in this image?], Answer:
input image example:

The input image would be resized to 448x448 for Bunny-Llama-3-8B-V.

Close the issue for now if there's no further discussions. Feel free to reopen it if there's any other questions.


Cookbook: formatting the code

A simple cookbook that will show how to use formatting with Scala CLI. It should include:

basic run of fmt command
how to create a simple configuration file for Scalafmt (including links to full docs on Scalafmt page)

I can work on it. Please feel free to assign it to me.

@ganeshchand Please let us know if you need any help.

Hi, @ganeshchand are you still working on it, or I can take this issue? If yes, @lwronski what difference must the cookbook have in comparison to commands/format? I have a basic draft now, but it is too similar to the commands section. Also, I'm stuck with -F and --scalafmt-arg flags. Can you please say if one of the following is a correct and expected syntax:
scala-cli fmt -F "maxColumnWidth=100" -F "newlines.sometimesBeforeColonInMethodReturnType=true" .

or
scala-cli fmt -F "maxColumnWidth=100,newlines.sometimesBeforeColonInMethodReturnType=true" .

@sierikov -F isn't for passing the configuration, it's for passing scalafmt options directly.
In other words
scala-cli fmt -F -help

is the equivalent to
scala-cli fmt --scalafmt-help

To pass the configuration string directly, you can use --scalafmt-conf-str.
I suspect you're free to take this, since we haven't heard from @ganeshchand in a long while.

what difference must the cookbook have in comparison to commands/format

I'm not sure if we really still need a cookbook, but having one wouldn't hurt.
I'd imagine it would be a more step by step guide to using the tool, explaining how the configuration file is generated, but can also be saved and later modified, explaining each of the more niche options, and so on.
For inspiration, make sure to check:
scala-cli fmt --full-help --power

Also, instead of a cookbook, you might as well expand the existing commands/format doc.

I have opened a pull request with my initial intuition. Please have a look and say what you think. Is maybe it more intuitive to move/duplicate some sections in command/format?

@sierikov My apologies. This fell off my radar. Thank you taking over this.


Debug HTTP server

There are a lot of useful debug HTTP handlers to add for processes. Stuff like pprof, job management endpoints (quitquitquit, abortabortabort, health are common), process-level metrics, etc.
It would be nice to have gokit automatically spin up a debug port for listening with a bunch of defined (and possibly extendable) debug HTTP handlers.
This issue would benefit from #1, since by default we could have it listen on <IP_ADDRESS>:0, but be configurable to be something else.

the spacemonkeygo/monitor project has an HTTP handler that returns a list of running process tasks, in addition to a handler that returns a list of key/value stats about the process (environment information, any programmer-added metrics, etc)

Common read-only stdlib debug information like pprof, expvar, and simple health checking should indeed be made accessible, probably by default. I think it's up for debate whether they should be bound to a specific debug port and therefore exist in isolation, or multiplexed onto the HTTP port used in an HTTP transport. Probably that should be user-definable.
We may also define a set of utility endpoints like quitquitquit, though I'd prefer to give that opt-in semantics.
It all feels like it's properly in the domain of package server.

On 13 February 2015 at 05:57, Peter Bourgon<EMAIL_ADDRESS>wrote:

It all feels like it's properly in the domain of package server.

Agree


Update test-file-04.md

@v-caxian : Thanks for your contribution to the Azure documentation! The author, @TinaLiuGirl, has been notified to review your proposed change.

#please-close


[Feat] Move completed items to bottom of page

Love the extension. It'd be great if there was a keystroke that moved all completed tasks to the bottom of the page,

moving completed tasks to the bottom of the project seems better


update libcatclient.so for python

Update the libcatclient.so for pycat.
Remove some unused codes.
Provide centos6, ubuntu-14.04 and alpine Dockerfile. (To help to build the .so file)


Write unit tests for bot/rules/newlines.py

Write unit tests for bot/rules/newlines.py.
Implementation details
Please make sure to read the general information in the meta issue and the testing README. We are aiming for a 100% branch coverage for this file, but if you think that is not possible, please discuss that in this issue.
Additional information
If you want to work on this issue, please make sure that you get assigned to it by one of the core devs before starting to work on it. We would like to prevent the situation that multiple people are working on the same issue. To get assigned, leave a comment showing your interesting in tackling this issue.

Took at shot at this! Hopefully this is what you guys were looking for.


Allow specifying multiple directories using --with-global-runtime

As a packager, it would be useful to have Vim consider both /etc/vim and
$VIM/vimfiles as part of the standard 'runtimepath'.  The former would
be used by the sysadmin while the latter would be used by packaged
addons.
This PR enables that functionality by letting --with-global-runtime
specify a comma-separated list of directories.  For example, after
running ./configure --with-global-runtime='/etc/vim,$VIM/vimfiles',
then ./src/vim --cmd 'set rtp?' --cmd q reports:
runtimepath=~/.vim,/etc/vim,/usr/local/share/vim/vimfiles,/usr/local/share/vim,/usr/local/share/vim/vimfiles/after,/etc/vim/after,~/.vim/after

Codecov Report

Merging #3704 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3704      +/-   ##
==========================================
- Coverage   78.15%   78.14%   -0.01%
==========================================
  Files         101      101
  Lines      140527   140527
==========================================
- Hits       109825   109818       -7
- Misses      30702    30709       +7

Impacted Files
Coverage Δ

src/ex_cmds.c
80.02% <0%> (-0.23%)
:arrow_down:

src/if_xcmdsrv.c
84.17% <0%> (-0.18%)
:arrow_down:

src/channel.c
83.16% <0%> (-0.08%)
:arrow_down:

src/message.c
75.72% <0%> (-0.05%)
:arrow_down:

src/window.c
83.45% <0%> (-0.04%)
:arrow_down:

src/ex_docmd.c
80.09% <0%> (+0.01%)
:arrow_up:

src/os_unix.c
58.28% <0%> (+0.04%)
:arrow_up:

src/gui.c
58.14% <0%> (+0.05%)
:arrow_up:

src/buffer.c
79.29% <0%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79fd56...2a82910. Read the comment docs.


Added Savings Goal Calculator

Fixes Issue🛠

Closes #677
Description👨💻
Savings Goal calculator made successfully.
Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅
Tested locally.
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF

Is your calculator different from the one that we have Savings Calculator, I don't think so @diyaaa19

My calculator would tell how much savings we can make for specific number
of years. Specifically tells about savings in particular no. of years, the
existing calculator calculates interest, investment as well accumulated
over time. so they are slightly  different but work on the same principle.
On Mon, Jun 3, 2024 at 11:37 PM Rakesh Roshan @.***>
wrote:

Is your calculator different from the one that we have Savings Calculator
https://calcdiverse.netlify.app/calculators/savings-calculator/, I
don't think so @diyaaa19 https://github.com/diyaaa19
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/CalcDiverse/pull/1083#issuecomment-2145822207,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEE6UWVJAFG3SKPLDZMA56TZFSWETAVCNFSM6AAAAABIUQEFZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVHAZDEMRQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I'd be happy to make another calculator for something else, if this doesn't
work out.
On Tue, Jun 4, 2024 at 12:38 AM Diya Jain @.***> wrote:

My calculator would tell how much savings we can make for specific number
of years. Specifically tells about savings in particular no. of years, the
existing calculator calculates interest, investment as well accumulated
over time. so they are slightly  different but work on the same principle.
On Mon, Jun 3, 2024 at 11:37 PM Rakesh Roshan @.***>
wrote:

Is your calculator different from the one that we have Savings Calculator
https://calcdiverse.netlify.app/calculators/savings-calculator/, I
don't think so @diyaaa19 https://github.com/diyaaa19
—
Reply to this email directly, view it on GitHub
https://github.com/Rakesh9100/CalcDiverse/pull/1083#issuecomment-2145822207,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEE6UWVJAFG3SKPLDZMA56TZFSWETAVCNFSM6AAAAABIUQEFZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVHAZDEMRQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Pls work on new issues or you can take another up-for-grab issues if this also works on same principle, closing this PR @diyaaa19


This error will be reported every time it is started，

WAS Node Suite Error: OpenCV Python module still cannot be imported. There is a system conflict.
Traceback (most recent call last):
File "/home/ubuntu/ComfyUI/nodes.py", line 1734, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/home/ubuntu/ComfyUI/custom_nodes/comfyui_controlnet_aux/init.py", line 2, in
from .utils import here, create_node_input_types
File "/home/ubuntu/ComfyUI/custom_nodes/comfyui_controlnet_aux/utils.py", line 4, in
import cv2
ImportError: libGL.so.1: cannot open shared object file: No such file or directory
Cannot import /home/ubuntu/ComfyUI/custom_nodes/comfyui_controlnet_aux module for custom nodes: libGL.so.1: cannot open shared object file: No such file or directory

Please report the error to control net aux custom node. This is not my repos error.


Scaling output file format in win10?

Thanks for all your contribution which helps me a lot...
I have a question that in my system(win10).
I use svm-scale.exe to scale the data directly like svmguide1, and I get the output file svmguide1.scale, which is in format UTF16-LE, then the file cannot be used as the input of svm-train.exe;
But if I use the easy.py to finish the whole process, things seems to be all right, and the output file svmguide1.scale is in format ANSI;
Can I ask the reason of this difference?

how did you generate things by svm-scale.exe? I used the cmd window to generate a file by svm-scale.exe and can open the file by notepad/wordpad without problem


Update Azure object storage benchmark to use latest version.

The azure_blob_storage API hard-codes an old version so that it continues to work. We should update to the latest version.

Closing, feel free to open


My Access page giving a 500 error

When I log in with my Github account and go to My Access in Test environment, I get this page:

In the logs, I get this, but no other details:
TypeError: Cannot read property 'id' of null
    at /app/dist/www/server/pages/devportal/access.js:2582:145
    at arrayAggregator (/app/node_modules/lodash/_arrayAggregator.js:17:32)
    at /app/node_modules/lodash/_createAggregator.js:19:12
    at AccessList (/app/dist/www/server/pages/devportal/access.js:2579:41)

I think the issue is that there are ServiceAccess records with no ProductEnvironment, which in theory should not happen.
Why would there be records for:
select * from "ServiceAccess" where "productEnvironment" is null;

This might be a duplicate of #148, where I have added some filtering for if these sneak by the API.

Root cause is that it is possible to get orphaned Environments (Environments that are not associated with any Products).  This can occur when Products and Environments are updated via the Directory API.
This ticket will cleanup the orphaned records:
select * from "Environment" where product is null;

And will fix the Directory API (Batch Feeder) to avoid such issues in the future.

This error can also occur when an Environment is deleted.  In this case, existing ServiceAccess records get there productEnvironment attribute set to null.


documents in database limited to 4mb

This is an issue with JSON + MongoDB. There are work arounds to make MongoDB handle documents that are bigger than 4mb but its nontrivial.
Up until now we haven't had to deal with it. But if people upload huge classification datasets or something, its very conceivable that these could exceed 4mb.

Its actually 16mb. And it sounds like that if you do exceed 16mb it will actually just be kicked to disc maybe? In any case, on the redux branch we're more careful about this limitation. For algorihtms, there has been talk about a new 'list' class that can be appended to without limit


How to use HardwareButtons Enum ?

I can't find HardwareButtons in code.
Do I have to implement HardwareButtons enum by myself?

Change
import 'package:hardware_buttons/hardware_buttons.dart';

as:
import 'package:hardware_buttons/hardware_buttons.dart' as HardwareButtons;

then it'll find the variables properly :)


Allow several types for a single request parameter in swagger.json

Using swagger2.0 with Connexion.
I'd like to be able to define a request parameter in my swagger.json which allows any type (or a list of types).
I've tried using "type": "any" but swagger validation does not allow this.
I'd like to be able to do this to parameters which can be in either body, path or header.
Additional info:
Python 3.6.4
Connexion 1.5.2

If what you want is polymorphism, then there is a feature in OpenAPI v3 which allows the API to accept multiple types of objects with (using oneOf), but each type of object must still have a schema (i.e. be typed). OpenAPI v3 support is in work for connexion at the moment (https://github.com/zalando/connexion/pull/621).
Having type information is required by Swagger 2.0 https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#parameter-object
Connexion implements the OpenAPI spec, so your request is simply not possible with Swagger 2.0.
Good luck.

Would it be possible to have a parameter without any sort of validation? Could I create a custom validator to achieve this?

Would it be possible to have a parameter without any sort of validation? Could I create a custom validator to achieve this?
Even if you removed validation entirely, the type information is still used to deserialize/decode data provided by the user. You could potentially just type everything as "string"s and then cast them to whatever types later, but I wouldn't recommend it.

Can you say more about what you are trying to achieve?
Without understanding more about your constraints or your higher level goal, it seems like you are trying to work around the whole point of connexion.

Thank you for your response!
I have a parameter which changed its type in newer versions of my API, and I'd like to retain backwards compatibility (should be invisible to the client), by allowing the client to send the parameter in any of the allowed types.
Ways to achieve this would be to define a group of types allowed for the parameter, or allow any type, or skip validation altogether for this specific parameter.

Ok, yeah I think I'd recommend upgrading to OpenAPI 3 when it becomes available, and using polymorphism. That way you can do something like:
schema:
  oneOf: {
    "$ref": "#/components/schemas/NewSchema",
    "$ref": "#/components/schemas/BackwardsCompatibleSchema"
  }

If you need this capability while using swagger 2, you'll probably want to fork this project. If you can provide more details (a spec, your operation code, etc) I may be able to give you more extensive guidance.

Hey @erezatiya , I'm going to close this issue - please re-open if there's something I missed!


Fix niclips.to_iso_ras

The resampling that is performed in niclips.image.to_iso_ras, is sometimes causing the image shape to be changed (e.g. one dimension goes from 150 to 151 in one image, but not another). This adds the target_shape argument to the resample command to ensure the image retains the original shape after the iso_ras resampling.
Not an issue on single image figures, but potentially problematic when also including overlays (which currently require volumes to have the same shape). Wouldn't alter how overlays are handled currently.

Let's hold off on reviewing / merging this one, may not need it with an upcoming PR.

Closing this for #34


Attempt to fix hyperlink issue on Edge/IE

Instead of calling markSelection in focus and clearing browser selection (which will cause issue of losing focus on Edge), we will markSelection at the time users click to the hyperlink button. Also always clearing the highlighted selection when bootstrap dropdown closes or losing focus on hyperlink input.

I tested in Edge and Internet Explorer. It appears to fix the problem with not being able to use the hyperlink button.
I did notice, however, that it only works properly if you type text first, select that text, and then click the hyperlink button. If you simply click the hyperlink button and type your link, it does not add it to the editor window like it does in Firefox and Chrome.
Can someone else test and confirm my findings?

I have pushed @hungqcao changes to my fork with some minor edits of my own. I will create a new issue regarding discrepancies in how Chrome allows creation of a hyperlink straight from the button, without requiring a text selection while other browsers do not..

@kaptainkommie I will take a look at the issue about not having previous selection on Edge. I did notice it during testing though.

@hungqcao I created issue #127 for this, I have provided a bit more information there.


code uses fixed font size

i am wondering if it might make more sense to define the CSS style for <code> to not use a fixed font size (it is defined as font-size: 15px; right now). it is legal HTML to use <code> in places other than just regular text (for example in headings), and defining it with a fixed font size makes these usages appear rather badly formatted.

What is your use case??

On 2016-12-12 12:53, Pat Hawks wrote:

What is your use case??

using  in headings, which i tried and it looks ridiculous. i don't
think there is a reason that needs to happen, if the  CSS
definition was a bit more contextual.

Why are you using <code> in headings if you do not want a fixed-width font?
What is your use case?

On 2016-12-12 13:01, Pat Hawks wrote:

Why are you using || in headings if you do not want a fixed-width
font? What is your use case?

please read the topic. i don't want a fixed-size font (which is how it
is defined right now). i do want a fixed-width/tt-style one, but one
where the size makes sense in the context of where it is being used.

A fix has been suggested in #304


bucket: use block.MetaFetcher to fetch blocks

Issue link: https://github.com/thanos-io/thanos/issues/1941
Changes
use block.metaFetcher in bucket command

As a last think: Can you test manually? e.g thanos bucket web on some prepared bucket?

The web component gives this output

Thank you! Good job 🥇


Machine Translation Integration Into Bot Framework V4

Translator Object Updated to support language detection from message

Fixed translation numeric error (restore number from original message e.g.: 20:30 translated to 10:30 the translator will output 20:30 along with the translated message)

Added post processing internal class used to handle no translate templates for each language (e.g.: trouve moi (.*)   matched group 1 in the template file of French won’t be translated)

Locale Converter Middleware Added

Supports conversion between locales in date and time using Microsoft.Text. Recognizer to recognize dates

Now Supporting all English locales, French, Deutsch and Chinese

In progress :

Working on a sample showcasing machine translation Middleware and locale converter Middleware
Will add template translate to translator object which will allow automatic translation of template of a specific language to other languages automatically

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mostafaelaraby sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@mostafaelaraby ANy updates on this? This is a great piece of code, and we would love to get it merged in!

I would love to get this merged in. Anything we can do to help?


File load error message despite troubleshooting

I already tried the troubleshooting steps from this page.
I also tried setting the language of the original game and YgoMasterClient both to English and German, but only the language of the error message changed.
In the LocalSave folder I noticed something after copying the files from the original folder to the 00000000 folder and running YgoMasterClient.exe. A part of the file e2264531 at the beginning and at the end gets modified.
Furthermore, I created a Symbolic Link to the "Yu-Gi-Oh!  Master Duel" folder in "C:\Program Files (x86)\Steam\steamapps\common", but that didn't help either.

Have a look at https://github.com/pixeltris/YgoMaster/issues/22

Thanks for your reply. I didn't know that the client looks for the first folder in the LocalData one. After I renamed the folders that are unnecessary for the game, it worked. :)

I see, thanks for the info.

Fixed in v1.5


Publish the base code for Python user-models

The Python user-models wrap a C DLL (built with CFFI currently) and provide a Pythonic and more approachable way of creating user-models for the following components, with no need to write a DLL in Pascal/Delphi or C:

[ ] Capacitor controls
[x] Generator
[ ] Storage
[ ] PVSystem

So far we tested it mostly with generators.
These models can be used with either a COM instance (with limitations due to a bug) or DSS Python's instance.
Other tasks:

[x] Test with COM (v8 only and Edit limitation still present)
[x] Test with DSS C-API (DSS Python base)
[x] Test on Linux
[x] Test on MacOS
[ ] Provide at least one working example in version 0.10

Pushing this to 0.11.

Can you please provide a minimal example of usermodel definition for a generator and the following circuit solution?

Hi @f-rosato, I started working on a full example for the generator, I'll try to finish tomorrow.

@f-rosato Please check this notebook and the files in that folder:
https://github.com/dss-extensions/dss_python/blob/master/docs/examples/UserModels/PyIndMach012/README.ipynb
It's not a step-by-step manual but I tried to comment most of code to illustrate how to use it.
I found some issues with recent versions of OpenDSS 8 to handle later. I left some comments about them.
Funnily enough, I also found an issue with IndMach012 class in DSS C-API to investigate later, https://github.com/dss-extensions/dss_capi/issues/62. For now, if you're running on Linux/macOS, just comment the bad plots (plt.plot(time, outputs_pas[ch_pas], label='IndMach012', lw=3).

It's been a couple of years. Since the official OpenDSS still has bugs/incomplete support for user-models (including still v7 vs v8+ issues), we'll abandon the idea of supporting the same models as EPRI's official OpenDSS, releasing an alternative approach in the coming months.

It's been a couple of years. Since the official OpenDSS still has bugs/incomplete support for user-models (including still v7 vs v8+ issues), we'll abandon the idea of supporting the same models as EPRI's official OpenDSS, releasing an alternative approach in the coming months.

@PMeira I am trying to adapt this to write a Storage User-Model. Since, you mentioned there are some issues and this idea has been abandon are there any updates in future directions you are taking? I was wondering if you have tested this for other components apart from the Gen models.

@utamrakar Sorry about the extended delay on this topic. I was supposed to have at least one student to help on this, but my local team has been short-staffed for a while (mostly due to the pandemic).
I personally only used the Generator and CapControl user-models. I've seen some brief mentions of inverters (e.g. see slide 12 in https://documents.pserc.wisc.edu/documents/general_information/presentations/pserc_seminars/webinars_2021/Webinar_Slides_Ayyanar_Yang_Chongfuangprinya_8_31_21.pdf ), but it's unclear which kind of base model was used.
For the next release (0.12.0), only the Generator user-model will be left enabled on DSS Python. The low-level headers in DSS C-API are still there and are updated in the current beta releases, but you need conditional compilation (i.e. define DSS_CAPI_DLL when targeting DSS C-API) for some models due some internal changes in DSS C-API -- the generator model doesn't need that, so we can leave it enabled in DSS Python without extra work.
In 2021, we decided to move the base library (DSS C-API) from Pascal to C++. The results of that should be out still in this semester (we already have some results in a private branch). I shouldn't say too much since it's still in flux, but the new approach for user-models will be based on that, and the new/rewritten property system coming in v0.12.
For a general overview of the current development, please see also the main v0.12 PR at https://github.com/dss-extensions/dss_capi/pull/109


npm start error

I am getting following error while running npm start command, Please can you help me with this issue?
npm start

<EMAIL_ADDRESS>prestart C:\Users\kp\Documents\GitHub\my-proj
npm run build

<EMAIL_ADDRESS>build C:\Users\kp\Documents\GitHub\my-proj
tsc -p src/

<EMAIL_ADDRESS>start C:\Users\kp\Documents\GitHub\my-proj
concurrently "npm run build:watch" "npm run serve"

Error occured when executing command: npm run serve
Error: spawn cmd.exe ENOENT
at exports._errnoException (util.js:1029:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
at Module.runMain (module.js:607:11)
at run (bootstrap_node.js:425:7)
at startup (bootstrap_node.js:146:9)
at bootstrap_node.js:540:3
Error occured when executing command: npm run serve
Error: spawn cmd.exe ENOENT
at exports._errnoException (util.js:1029:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
at Module.runMain (module.js:607:11)
at run (bootstrap_node.js:425:7)
at startup (bootstrap_node.js:146:9)
at bootstrap_node.js:540:3
[1] npm run serve exited with code -4058
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\kp\AppData\Roaming\npm\node_modu
les\npm\bin\npm-cli.js" "start"
npm ERR! node v7.7.1
npm ERR! npm  v4.3.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: concurrently "npm run build:watch" "npm run serve"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'concurrently "npm run build:watch" "np
m run serve"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     concurrently "npm run build:watch" "npm run serve"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-quickstart
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\kp\AppData\Roaming\npm-cache_logs\2017-03-03T04_51_26_531Z-debug.log
C:\Users\kp\Documents\GitHub\my-proj>npm run build:w
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\kp\AppData\Roaming\npm\node_modu
les\npm\bin\npm-cli.js" "run" "build:w"
npm ERR! node v7.7.1
npm ERR! npm  v4.3.0
npm ERR! missing script: build:w
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\kp\AppData\Roaming\npm-cache_logs\2017-03-03T04_52_28_442Z-debug.log

Hi, try finding the package.json file in your root/home directory and remove that, than try running your project it may work.

I am getting a similar issue, has this been resolved yet

This repository is now deprecated. The Angular Quickstart project was a nice starting point for creating Angular applications. Now we recommend using the Angular CLI to create new Angular projects.
Starting from 1 November 2017, all the Angular documentation, at angular.io, is based on the Angular CLI.
Let's get started


Don't crash interpreter or read into uninitialized memory that much

Thank you, I intentionally left validation out. (I meant to measure the compute power required.)
Both the C++ and pure Python versions can fail for malcious input.
The input must always be a string of length 24. (please note that PyUnicode_CheckExact(arg) is also necessary.
Please also add the type and length check to the python method with the same error messages.
I already enabled the builds for the PR. i am also curious to see the benchmarks with validation added to just the C side.

With validation added to the C code:
-------------------------------------------- benchmark: 2 tests --------------------------------------------
Name (time in ns)             Mean            StdDev                Median            OPS (Kops/s)
------------------------------------------------------------------------------------------------------------
test_optimized_code       317.2077 (1.0)      0.1059 (1.0)        317.2156 (1.0)        3,152.5088 (1.0)
test_python_code        1,147.7448 (3.62)     3.3863 (31.97)    1,147.0371 (3.62)         871.2738 (0.28)
------------------------------------------------------------------------------------------------------------

My guess:
The numbers did not change much as no tests involve validation errors and branch prediction acts accordingly.
branch prediction has no power on the python code. when you add validation to the python code, it will degrade its performance noticeably.

I have added the checks as a single if of both sides: https://github.com/szabolcsdombi/optimization-demo/pull/3

build
-------------------------------------------- benchmark: 2 tests --------------------------------------------
Name (time in ns)             Mean            StdDev                Median            OPS (Kops/s)
------------------------------------------------------------------------------------------------------------
test_optimized_code       311.6846 (1.0)      0.0990 (1.0)        311.6799 (1.0)        3,208.3712 (1.0)
test_python_code        1,215.3566 (3.90)     1.7520 (17.70)    1,215.1658 (3.90)         822.8038 (0.26)
------------------------------------------------------------------------------------------------------------

Both the C++ and pure Python versions can fail for malcious input.

Only the C++ version can crash the interpreter or read unrelated memory, though.

I am fine with adding validation for the C side, protecting against misuse, (wrong type passed, wrong length passed)
I won't add the check on Python side as it will throw an exception for the basic types.

Both the C++ and pure Python versions can fail for malcious input.

>>> t = ''.__class__.__class__('T', (), {'__add__': lambda s,o: (lambda: 0).__class__((lambda: 0).__code__.__class__(0,0,0,0,0,0,b'\x88',(),(),(),'','',0,b'',(),()),{})()})()
>>> py_accept(t)
Segmentation fault (core dumped)

Obviously this object is highly unlikely to be the input to the function and the function itself should not be resilient to it.


scope should be checked for non-blank values before using them

Keep up the good work ;)

Thanks man :hamster:


SPR32 Format

Summary
Add support for the BSP2 map file format.

Per Spoike:

spr32  (version 32 sprites) are the same format except that all palette data is replaced with 32bit rgba data
FTE has an additional spritegroup type - SPR_ANGLED=2
(which causes it to pick a frame automatically based upon angle. the intervals info is ignored.)


Lazy getter improvement or alternative [FEATURE]

Describe the feature
Lazy getter is fine, but it's less useful than expected since it usually requires me to write an initialization method. I just wanted to write
	@RequiredArgsConstructor private static final class Data {
		private final Persistor persistor;

		@Getter(lazy=true)
		private final ImmutableList<Order> orders =
				persistor.newQuery(Order.class)....list();
	}

but this doesn't work as my persistor gets initialized from the constructor, i.e., after the field initializer runs. This forces me to extract the initializer into a method, which makes it much more verbose and diminishes the saving by Lombok.
I guess, the best solution would be
		@Getter(lazy=true)
		@InitializerToConstructor
		private final ImmutableList<Order> orders =
				persistor.newQuery(Order.class)....list();

where @InitializerToConstructor would move the initializer into the generated constructor (actually, into all of them).

Something like @InitializerToMethod just extracting the initializer into a method like I did manually would work as well.
It might be simpler to implement, however, the @InitializerToConstructor annotation would be useful in general, as the default Java behavior (running initializers before constructors) is rarely wanted (if ever).

An alternative would be a @Memoized annotation like
		@Memoized
		ImmutableList<Order> orders() {
			return persistor.newQuery(Order.class)....list();
		}

renaming the original method to something else and generating the field and its lazy getter named orders . While memoization could have tons of arguments (expiration, dependencies, etc.), this simple variant would be good enough for me.
Describe the target audience
Everyone needing a lazy getter depending on a field initialized in the constructor would profit from this.

What I understand from your description, you don't necessarily want to calculate the value only the first time it is requested, you're fine with immediately initializing it, but you want to calculate it based on a function on other constructor parameters.
Is that correct?

@rspilker In this case, I need both: The initializer expression should be "lazily executed" at the end of the constructor - I mean, it should see the persistor assigned, but it shouldn't be evaluated - the lazy getter should stay lazy. I'm trying to get a good example, but things are getting complicated.
Let's go the other path: @Memoized
Using a method instead of the field as the base for the lazy getter would also eliminate a part of the verbosity. Most of the implementation would be shared with lazy getter.
The first attempt
	@Getter(lazy=true)
	private final ImmutableList<Order> orders =
		persistor.newQuery(Order.class)....list();

doesn't work when persistor gets assigned in the constructor, so I had to fix it by extracting a method like
	private ImmutableList<Order> ordersBoilerplate() {
		return persistor.newQuery(Order.class)....list();
	}

	@Getter(lazy=true)
	private final ImmutableList<Order> orders =
		ordersBoilerplate();

What I'm proposing is a new annotation like
	@Memoized
	ImmutableList<Order> orders() {
		return persistor.newQuery(Order.class)....list();
	}

generating the same code as the fixed lazy getter(i.e., the user-written method should be removed or renamed, an Atomic*-field and a getter should be generated).
I'm not proposing any advanced caching, it's just a memoization of no-args methods as a lazy getter variant.

I came to this feature because I wanted to use a lazy getter yet still have an @With annotation work on the field and I also wanted the field to be present in AllArgsConstructor (but not RequiredArgsConstructor)
More background,
I have something like this:
@Value
@With
@Builder(toBuilder = true)
@RequiredArgsConstructor
@AllArgsConstructor
public class HashablePayload  {

    @Getter(lazy = true)
    @With
    byte[] hash = calculateHash();
    Payload payload;

    public byte[] calculateHash()  {

        byte[] payloadBytes = payload.toBytes();
        MessageDigest digest = MessageDigest.getInstance("SHA-256");
        return digest.digest(payloadBytes);
    }
}

HashablePayload represents something I transmit and receive across the network.  So when I am sending it, I want it to calculate the hash to be used when sending.  However when I am receiving it, I want to use the hash sent to me across the network so I can validate later that the calculated hash matches the hash received across the network.
Currently @Getter(lazy = true) is not compatible with @With and @RequiredArgsConstructor @AllArgsConstructor produce the same constructor which omits hash.
So you can not do
HashablePayload payload = new HashablePayload(new byte[0], new Payload())
nor
payload.withHash(new byte[0])
Might be able to support this use case with @Memoized like this:
@Value
@With
@Builder(toBuilder = true)
@RequiredArgsConstructor
@AllArgsConstructor
public class HashablePayload  {

    Payload payload;

    @With
    @Memoized
    public byte[] hash()  {

        byte[] payloadBytes = payload.toBytes();
        MessageDigest digest = MessageDigest.getInstance("SHA-256");
        return digest.digest(payloadBytes);
    }
}

Here the @With on the @Memoized method would instruct Lombok to allow the value to be set instead of calculated.  Presumably the @AllArgsConstructor would also include hash as a parameter.

I came to this feature because I wanted to use a lazy getter yet still have an @With annotation work on the field and I also wanted the field to be present in AllArgsConstructor (but not RequiredArgsConstructor)
More background,
I have something like this:
@Value
@With
@Builder(toBuilder = true)
@RequiredArgsConstructor
@AllArgsConstructor
public class HashablePayload  {

    @Getter(lazy = true)
    @With
    byte[] hash = calculateHash();
    Payload payload;

    public byte[] calculateHash()  {

        byte[] payloadBytes = payload.toBytes();
        MessageDigest digest = MessageDigest.getInstance("SHA-256");
        return digest.digest(payloadBytes);
    }
}

HashablePayload represents something I transmit and receive across the network.  So when I am sending it, I want it to calculate the hash to be used when sending.  However when I am receiving it, I want to use the hash sent to me across the network so I can validate later that the calculated hash matches the hash received across the network.
Currently @Getter(lazy = true) is not compatible with @With and @RequiredArgsConstructor @AllArgsConstructor produce the same constructor which omits hash.
So you can not do
HashablePayload payload = new HashablePayload(new byte[0], new Payload())
nor
payload.withHash(new byte[0])
Might be able to support this use case with @Memoized like this:
@Value
@With
@Builder(toBuilder = true)
@RequiredArgsConstructor
@AllArgsConstructor
public class HashablePayload  {

    Payload payload;

    @With
    @Memoized
    public byte[] hash()  {

        byte[] payloadBytes = payload.toBytes();
        MessageDigest digest = MessageDigest.getInstance("SHA-256");
        return digest.digest(payloadBytes);
    }
}

Here the @With on the @Memoized method would instruct Lombok to allow the value to be set instead of calculated.  Presumably the @AllArgsConstructor would also include hash as a parameter.


lnurl callback just appends '?params', ignores if there's already a '?' in the URL

If on a lnurl withdraw reply from the service you get "callback": "https://service.com/x?y=z" BLW will call it with https://service.com/x?y=z?k1=...&pr=..., which breaks everything.
It could detect if there's a ? already and then apply its own parameters with &k1=...&pr=....

yeah, possible ? this should be taken into account.

When doing a login the problem is even worse, as the initial lnurl is required to have querystring params (k1 and tag=login), but BLW calls the URL with something like:
/lnurl-login?tag=login&k1=banana?k1=[B@d7cca81&sig=&key=0226a0b9de7a671d4cebd97a3fb34c656c0d1b203e53a2b6712591c49fb335068e

Fixed in https://github.com/btcontract/lnwallet/commit/1bdef52552ea0a55adc760686209eb30fdc081d6


ssc600.xml.j2: create a template for the ABB VMs

The ssc600 SW needs to be configured through a libvirt xml file. It can't be created using the default guest.xml.j2 template from Seapath due to his slight differences. Thus, the ssc600.xml.j2 is created specially for the ssc600 VMs.

This will be done in another PR


upstream connect error or disconnect/reset before headers. retried and the latest reset reason: connection failure, transport failure reason: delayed connect error: 113

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Unable to deploy and test bookinfo application with Istio 1.18.2 on a local Linux machine by following https://istio.io/latest/docs/examples/bookinfo/ steps.
Istio setup completes successfully and all application pods are shown to be running without errors.
~/w/r/s/b/istio-1.18.2 ./bin/istioctl install --set profile=minimal -y
✔ Istio core installed
✔ Istiod installed
✔ Installation complete
Making this installation the default for injection and validation.

~/w/r/s/b/istio-1.18.2 kubectl label namespace default istio-injection=enabled
namespace/default labeled

Deployed bookinfo.yaml sample application: kubectl apply -f samples/bookinfo/platform/kube/bookinfo.yaml
~/w/r/s/b/istio-1.18.2 kubectl get po -A
NAMESPACE      NAME                                       READY   STATUS    RESTARTS   AGE
default        details-v1-7c7dbcb4b5-42wwr                2/2     Running   0          74s
default        productpage-v1-664d44d68d-6g6fn            2/2     Running   0          74s
default        ratings-v1-844796bf85-wbgkj                2/2     Running   0          74s
default        reviews-v1-5cf854487-rpn6j                 2/2     Running   0          74s
default        reviews-v2-955b74755-25dr4                 2/2     Running   0          74s
default        reviews-v3-797fc48bc9-fnqcc                2/2     Running   0          74s
istio-system   istiod-977466b69-zpmtp                     1/1     Running   0          25m
kube-system    calico-kube-controllers-674fff74c8-57ckt   1/1     Running   0          47h
kube-system    calico-node-kxfkp                          1/1     Running   0          47h
kube-system    coredns-5d78c9869d-jjcjh                   1/1     Running   0          47h
kube-system    coredns-5d78c9869d-k2hvt                   1/1     Running   0          47h
kube-system    etcd-prateek                               1/1     Running   0          47h
kube-system    kube-apiserver-prateek                     1/1     Running   0          47h
kube-system    kube-controller-manager-prateek            1/1     Running   0          47h
kube-system    kube-proxy-8ptlf                           1/1     Running   0          47h
kube-system    kube-scheduler-prateek                     1/1     Running   0          47h

~/w/r/s/b/istio-1.18.2 kubectl get svc -A
NAMESPACE      NAME          TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                                 AGE
default        details       ClusterIP   <IP_ADDRESS>    <none>        9080/TCP                                11m
default        kubernetes    ClusterIP   <IP_ADDRESS>        <none>        443/TCP                                 2d
default        productpage   ClusterIP   <IP_ADDRESS>     <none>        9080/TCP                                11m
default        ratings       ClusterIP   <IP_ADDRESS>      <none>        9080/TCP                                11m
default        reviews       ClusterIP   <IP_ADDRESS>   <none>        9080/TCP                                11m
istio-system   istiod        ClusterIP   <IP_ADDRESS>     <none>        15010/TCP,15012/TCP,443/TCP,15014/TCP   35m
kube-system    kube-dns      ClusterIP   <IP_ADDRESS>       <none>        53/UDP,53/TCP,9153/TCP                  2d

kubernetes installed using kubeadm: sudo kubeadm init and using calico CNI.
Running Step 5 from https://istio.io/latest/docs/examples/bookinfo/#start-the-application-services throws connection failure error:
~/w/r/s/b/istio-1.18.2 kubectl exec ratings-v1-844796bf85-wbgkj -c ratings -- curl -sS productpage:9080/productpage
upstream connect error or disconnect/reset before headers. retried and the latest reset reason: connection failure, transport failure reason: delayed connect error: 113

Version
~/w/r/s/b/istio-1.18.2 ./bin/istioctl version                                                                                13:36:28
client version: 1.18.2
control plane version: 1.18.2
data plane version: 1.18.2 (6 proxies)

~/w/r/s/b/istio-1.18.2 kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.27.4
Kustomize Version: v5.0.1
Server Version: v1.27.4

Additional Information
PFA bug-report
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

bug-report.tar.gz

Testing out few examples similar to https://istio.io/latest/docs/tasks/security/authentication/authn-policy/# shows that inbound connections to services behind the proxy are fine, but outbound connections from such services give a 503 HTTP error.

firewalld service was interfereing with envoy routing rules.
Workaround: Stopping firewalld system service allowed all requests to flow as intended.


Added Backpacks

denied as this is already in https://github.com/UselessBullets/bta-backpacks/releases/tag/v1.0.0


Language Server

Hi folks!
This issue is a request for a language server implementation to support schema editing in code editors. I'm filing this as requested by I believe @josephschorr in the discord.

Duplicate of #179


Bib predictor index error bug fix

attempt at fix for part 1 of https://github.com/allenai/scholar/issues/34858
I think we can work around the index error that keeps popping up this way.
tt verify integration test passes
next steps:

[ ] tt push
[ ] update timo-services config for bib-predictor to use new code which will trigger new deployment

I know it happened for example with this pdf: 3cf45514384bbb7d083ae53e19bdc22300e648ab / https://s3.console.aws.amazon.com/s3/object/ai2-s2-pdfs?region=us-west-2&prefix=3cf4/5514384bbb7d083ae53e19bdc22300e648ab.pdf
From reading the code I believe it means we are trying to get tokens from a bib entry spangroup (that was an mmda generated spangroup from a box that the detector model gives us) that has no tokens, but i didn't actually visualize the boxes we get for this PDF to confirm that suspicion. I'll see if I can easily do that somehow...

Haven't merged yet cause I wanted to prove my suspicion. Haven't done it yet, because unable to pull annos w/ spp_client for the example pdf, uncovering another bug. The problem seems to be that there are a mismatch in IDs of bibentry boxes and bibentry spangroups, which does point to my original suspicion (of model box having no tokens, therefore no spans to generate a spangroup), but since it causes problems with spp_client too I want to investigate more before deciding what to do.

@geli-gel is there sthn i can help w/ here?

Sure thanks Kyle, here's what I have so far:
I think that I recall seeing some code in mmda that makes text from spans unavailable to future spangroups in the same set of annos. I'm wondering if that's what's causing these spangroups with no spans -- for example we have 2 boxes drawn in the same area, however our box with id=0 ends up having nothing in anno store since it has no spans:

TODO:

[ ] make a test fixture and new test for this specific paper so that we can ensure it can run without failing

@geli-gel

I think that I recall seeing some code in mmda that makes text from spans unavailable to future spangroups in the same set of annos.

can u point to what you're referring to? i don't quite understand this

I'm wondering if that's what's causing these spangroups with no spans -- for example we have 2 boxes drawn in the same area, however our box with id=0 ends up having nothing in anno store since it has no spans

can u give me the PDF that's generating this?

@kyleclo sure, the paper above is sha 3cf45514384bbb7d083ae53e19bdc22300e648ab https://s3.console.aws.amazon.com/s3/object/ai2-s2-pdfs?prefix=3cf4%2F5514384bbb7d083ae53e19bdc22300e648ab.pdf&region=us-west-2# and this is the code I'm thinking of:
https://github.com/allenai/mmda/blob/56b715da485ef7d577bdc322f05d09f143c27590/src/mmda/types/document.py#L182
But also, I think the solution is to stop returning these overlapping boxes at their source - the model (filter returned bib entry SpanGroups to only ones that contain spans (text)).


[Feature] Mechanism to create dependency when using existing keyword

Is your feature request related to a problem? Please describe.
When referencing resources using existing keyword, there's no way to create an explicit dependency to make it avoid erroring with a "not found" error.
To give some context, my templates are organised as such:

a main.bicep file using module to create all resources
modules files under modules/<name>.bicep

Inside a module, sometimes I need to access a resource created in other modules.
For that, I'm using the existing keyword, sometimes even with a condition based on parameters. For example, in module/staticwebapp.bicep I have something like this:
resource containerApp 'Microsoft.App/containerApps@2022-03-01' existing = if (linkedBackend && backendType == 'container') {
  name: 'ca-${containerName}-${containerUid}'
}

When referencing that existing container app, if it's not deployed yet I'll get a "Not found" error, which is expected. But it would like to have an option so that when the conditions are met, making that existing reference also creates a dependency to the containerApp resource, to avoid the error.
Adding the dependency explicitly at the module level in my main.bicep file would be possible, but it would mean duplicating all the parameter processing in that file too to determine the dependencies, defeating the purpose of having an isolated module.
Unless I missed something, I don't thing there's currently a way to "wait" for a resource referenced by an existing keyword to be created?
Describe the solution you'd like
I would like a feature so that when referencing resources using existing keyword, an explicit dependency is added to avoid "not found" errors. The dependency of course would be added only if the if condition on the resource is met.

Closing as dup of #2716.
The workaround is to find where you are using that existing resource and put the dependsOn in that resource to the module that creates the resource. Something like:
module createContainerApp 'createContainerApp.bicep' = { ... }

resource containerApp 'Microsoft.App/containerApps@2022-03-01' existing = ... { ... }

resource useContainerApp '...' = {
  ...
  properties: {
     someProp: containerApp.properties.foo
     ...
  }
  dependsOn: [ createContainerApp ]


destroy:behaviour when cache directory is changed introduced

also did minor changes in the existing tutorial. As now DVC is removing all the files present in the current workspace.

@ryokugyu I'm not I understand the example. What does it have to do with with -f?

@ryokugyu I'm not I understand the example. What does it have to do with with -f?

my mistake, example is for what happens when the cache directory is changed and dvc destroy is executed.
Updated.

dvc destroy is deleting the foo file too.

@ryokugyu it's fixed in the development version and will be released soon. Most likely it means that you are running a version from PyPi.

@ryokugyu it's fixed in the development version and will be released soon. Most likely it means that you are running a version from PyPi.

Yes, in the development version. seems like my development version is also outdated.
making necessary changes in the example.
as of today, latest dvc version is:
0.41.3+baccc0

will write a bash script to update development version every day. 👍

@shcheklein I have made all the changes. Please review it.

@shcheklein requested changes has been done. please review this.


Markdown linting package and configuration file

Expected Behaviour
A markdown linting package, like markdownlint, that I can use to make sure my markdown files adhere to basic standards. Consistent markdown promotes usability for contributors.
I should be able to run linting locally as well as add it to an automated PR validation workflow (e.g., #79).
The repo should include a default configuration file specifying a rule set at the root of the project.  It would be more efficient to add the linting package to the template repo so that it's available to all users who request a new repo.
Reproduce Scenario (including but not limited to)
n/a
Steps to Reproduce
n/a
Platform and Version
n/a
Sample Code that illustrates the problem
n/a
Logs taken while reproducing problem
n/a

@timkim & @dmitrymatio,
If you think this would be useful for all template users, I'd be happy to create a PR. Just let me know.

Sounds good. The only way to lint right now is to run a build which isn't ideal. Send the PR and I'll close the issue once it's in.

My suggestion also relates to https://github.com/AdobeDocs/dev-site-documentation-template/issues/79

This issue can be closed by #81


Support a dedicated path for plugins instead of relying on LD_LIBRARY_PATH

In GitLab by @jbigot on Mar 23, 2018, 12:00

Superseeded by #196

closed


Fixes cursor position reset on input

When the input event is fired on a field formatted as a number, reFormatCardNumber will set the element.value to the reformatted value. This resets the cursor position and forces the user to replace their cursor
This resets the cursor position to the original placement after the value has been set.

@jessepollak -- friendly ping :)

Your branch is out of date do you mind resubmitting this PR and I will merge it.


feat: Accept non searchable fields in metadata

Description
This PR includes changes for those cases when users want to add some fields in metadata but do not enable searches on them with a leading underscore _.
Refs: #2571
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)

[x] New feature (non-breaking change which adds functionality)
[x] Improvement (change adding some improvement to an existing functionality)

Checklist

[x] I have merged the original branch into my forked branch
[x] I added relevant documentation
[x] follows the style guidelines of this project
[x] I did a self-review of my code
[x] I made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Feel free to merge.


[QUESTION] Milliseconds retry parameter not being set when calling flush.

Hello,
First of all, thanks for the hard work with a very simple-to-use package! I've had a bit of an issue where some Kafka messages were getting lost. I was using the send method in your ProducerBuilder class:
public function send(): bool
{
    $producer = $this->build();

    return $producer->produce($this->message);
}

Since I was producing lots of messages, I changed my code to use the sendBatch method, which fixed my issue and everything worked smoothly after.
After that, I dug into the problem a bit more and I realized the flush method in the Producer class is using the Laravel retry logic:
private function flush(): mixed
{
    return retry(10, function () {
        $result = $this->producer->flush(1000);

        if (RD_KAFKA_RESP_ERR_NO_ERROR === $result) {
            return true;
        }

        $message = rd_kafka_err2str($result);

        throw CouldNotPublishMessage::withMessage($message, $result);
    });
}

I was surprised since it seemed to me not as many messages should've been lost for me, even by sending them individually (with the send method I shared above) to Kafka with this nice retry logic when flushing. Then I realized, for the flush retry, the sleepMilliseconds parameter is not being set. So the code doesn't seem to be sleeping for any amount of time before retrying.
I was just curious about why you took that decision. I was thinking it could be better to sleep for some milliseconds and maybe you could even retry less than 10 times. Being that this method is used for both, the send and sendBatch methods, I think it would be worth it.
Also, curious about why you are using the retry Larvel helper here, but not the retry method in the Retryable class you created. Wondering if the same retry method should be used everywhere in the package.
Thanks again for your work!

Hey @joanorrit sorry for the late reply, but I'm having a really bush week 😅
I think the sleepMiliseconds makes sense here. Have you tested it with some specific number? TBH I have not faced this issue before so I'm not exactly sure what would be the best choice here.

Hi @mateusjunges, no worries at all!
I tested it on my end with 500 milliseconds and it did the trick for me. But is difficult to come up with a number that works for everyone. I believe, the ideal would be to default it to a small number (100 milliseconds) and then add some configuration so each user can configure it to their needs.
But this might be a bit overengineered and if it has to make your library more difficult to use it's probably not worth it. I'd say you could also make it so it sleeps for somewhere between 100 and 500 miliseconds for everyone, which should improve things a bit an not have a negative impact on the package.
At the end, if anyone is sending lots of messages at once, they should fix it by sending messaged in batches, not by retrying to re-flush. So probably a small number makes sense there.

the ideal would be to default it to a small number (100 milliseconds) and then add some configuration so each user can configure it to their needs

Yeah that's what I had in mind. I'll open a PR tomorrow. Thanks!

Hey @joanorrit should be fixed now.
You must add the flush_retry_sleep_in_ms key to your config/kafka.php file and configure it to the desired amount of time (in ms).

Hey, this looks great @mateusjunges! Thanks for the quick fix 😄 . Going to make use of this handy config variable!


Updates

Hi,
This looks like a nice start kit for a new app.
I have an existing app but I'm considering merging this setup to replace mine.
I'm still puzzled with the way this works.
After cloning this repo and running the setup tool, the whole .git folder is deleted.
I understand this needs to happen as you want your own repo for your app.
But then how to you make sure your slingshot setup is up to date with the latest additions and fixes made to this repo? Are you supposed to go over the commits one by one and apply them on your setup?

Great question. Yes, that's correct. This is just a starting point. There is no automated way to pull in changes down the road. I'm considering moving much of this to an npm package which would help automate such updates. But updates aren't trivial either way, since you may choose to change the core config in various ways which create conflicts down the road.
Thanks for the question!

@coryhouse I had been thinking about the packaged version of this. How were you thinking of accomplishing that?
How would you feel about a fork of CRA?

Here's the idea:
Put the following dependencies in either separate, or a single npm package:

.babelrc
/buildScripts
webpack configs (store json in build scripts. Reference in srcServer.js and distServer.js)

Eliminate .eslintrc and allow people to declare their own, or utilize rules of their choosing. Alternatively, reference existing preset like AirBnB, or create our own.
Other potentials:

.editorconfig
CI Configs
npm scripts (call buildScripts for all tasks, so package.json becomes just a list of func calls)

Why?

Centralize code for easy bug fixes and maintenance
Clean up the project structure so it's less intimidating
Abstract away config so it's programmatically forced to be consistent. This avoids debugging errors with ad-hoc configs.

CRA is awesome, but their eject model doesn't has a downside: You're either in the ecosystem or out. I think it makes more sense to use npm packages for a baseline config and then use traditional means to override. So, for example, keep the webpack config in slingshot-build-scripts npm package, and then use that json as the baseline which you can override. I'm still working through how to execute that last sentence, but if I get this right I think it'll be a big win over the eject model.

Makes sense. As much as I like eject, you end up having to take on everything for in most cases something small.
Not sure if this will help with webpack, but there is this package, webpack-merge.
Let me know if/how I can help.


Designs/0028_quantile_functions

This is the first design doc for our NSF grant and discusses the fairly narrow question of how best to add quantile functions to Stan Math for eventual inclusion in the Stan language so that they can be called by users (usually in the transformed parameters block). Although this is related to our ideas about speeding up the log-likelihood evaluation and also related to an exciting approach where the log-likelihood could be specified in a different way, this design doc is independent of those (future) design docs, although those future design docs will be influenced by this one.
It is essentially what I advocated in my StanCon presentation about how to do Bayesian inference without prior PDFs because the famous probability distributions were not intended to be used as priors and are difficult to use for that purpose because they were usually constructed to have elementary expressions for their expectation, variance, etc. But prior expectations are much more difficult for users to think about than prior quantiles, which motivates an alternative way to construct Stan programs where prior beliefs about the substantive parameters are conveyed through the quantile function that is applied in the transformed parameters block to a cumulative probability that is declared in the parameters block with an implicit standard uniform prior.
rendered docs here

Rendered version: https://github.com/stan-dev/design-docs/blob/designs/0028-quantile-functions/designs/0028-quantile-functions.md

I'd prefer a solution that just turns the checking off for users that want checking turned off.   That can be shared with our other "turn off checking" routines.

For the complementary case, the problem isn't precision of the function, it's the representational power of floating point.  The smallest epsilon for which 1 - epsilon != 1 is about 1e-16.  The smallest epsilon for which epsilon > 0 is about 1e-400.  So no matter what the quantile function does, we can't even formulate the argument 1 - 1e-20, because it's just 1 in floating point.  Having said that, I'm OK with less precise versions and no complementary versions to start.  We can always improve that later.

I'm Ok with either _qf or _icdf.

I think it'll be easier and more coherent to include the locations in the location/scale families.

I think that we need to decouple the general question of implementing quantile functions from the more contentious (well at least for me) issue of booting prior specification to quantile interpolation.
Let me start with comments on quantile functions for the existing families of one-dimensional probability distributions.  Given their various uses — including generating pseudo random numbers with truncations which is not discussed in the design doc — I don’t see any reason to not include them.
That said I think we should define some policy for whether or not quantile functions are required for any one-dimensional family.  Having a quantile function for every family unifies the interface so that users will always know what functions are available instead of having to look up what might be implemented, similar to the functions implemented in base R (which always have a density, a CDF, an quantile function, and a pseudo random number generator), but that also adds an additional burden to the introduction of new families.  At this point we’ve largely converged to a standard set of families so I don’t think it would actually be that much of a burden, but it’s not zero.
A corollary to this is whether or not we also require quantile functions for the one-dimensional discrete families to ensure a uniform interface across all of the one-dimensional families.  The design doc argues against this but they are very useful when simulating from truncated discrete distributions, and again it would ensure a uniform interface similar to base R.
As for naming I would vote for famliy_qf.
I’m not sure I understand the comments about the location parameter not being meaningful for the quantile functions.  A location parameter translates the quantile function up and down the real line, as demonstrated by the implementation of the Cauchy quantile function earlier.
The second issue concerns quantiles for prior modeling, and I think this is independent of the implementation of the standard quantile functions and can be spun off into a separate design doc arguing for the design and inclusion of a metalog function.
One general comment is that I don’t think we should be referencing grants, client contracts, or any other personal obligations in design docs.  Whether or not a feature is developed and then incorporated into Stan should be a decision of the community and not what any one developer might promise to an external entity.  In particular it would be nice to have a formal policy that prior to something like a design doc situation developers only promise implementations developed on external forks to keep everything compartmentalized.
Otherwise I have many reservations about jumping hard into metalog approaches.  I do agree that quantile elicitation can be extremely powerful — I use it almost exclusively for prior modeling in my courses and consultations — but no finite set of quantiles fully species a prior model.  Moreover the quantile constraints are only ever extracted with some uncertainty, as with any domain expertise elicitation, and prior models need to be robust to small perturbations of the quantiles.
In practice both of these limitations can be resolved by using enough quantile constraints to select a prior density function some a given family, for example by using the algebraic solver.  By restricting consideration to a given family we can use soft elicitation of global properties like tail behavior, skewness, and the like to complete the specification beyond the elicited quantiles.  This is facilitated common properties of the given family, in particular visualizations of the the density function.  At the same time because the standard families of density function are relatively smooth perturbing the quantiles will almost always result in density functions that are visually equivalent.
In my opinion the metalog approach makes this all too complicated.  The rigidity provided by the standard families is replaced with an interpolation whose details are hidden to the user.  Even if an ambitious user does go to the effort of visualizing the induced probability density function what control will they have to modify or tune the resulting shape?  If interpolation configurations are exposed then how interpretable, and useful to most users, will they be?  Similarly how robust will the interpolation be to the precise location of the input quantiles?
The abstracted  interpolation will have particularly significant consequences when only a few quantiles have been elicited, especially out in the tails which is where prior shape is often most important.  Eliciting more quantiles can help but that also places a much stronger burden on the user to translate more and more implicit domain expertise into quantitative constraints, which takes time and effort and training that often aren’t available.  At the same time there are plenty of studies that discuss how poorly we reason about extreme events which makes eliciting extreme enough quantiles to pin down asymptotic tail behavior a particular challenge.
At the very least I think there needs to be a substantial amount of research and experimental done to inform how something like metalog can be useful robustly, and I personally think it’s premature to consider it’s inclusion in Stan until then.  But again I think that this particular discussion should be separated from the discussion of the standard quantile functions.

I think that we need to decouple the general question of implementing quantile functions from the more contentious (well at least for me) issue of booting prior specification to quantile interpolation.  ... The second issue concerns quantiles for prior modeling, and I think this is independent of the implementation of the standard quantile functions and can be spun off into a separate design doc arguing for the design and inclusion of a metalog function.

I'll second that.

One general comment is that I don’t think we should be referencing grants, client contracts, or any other personal obligations in design docs.  Whether or not a feature is developed and then incorporated into Stan should be a decision of the community and not what any one developer might promise to an external entity.

I think it's OK to mention things as supporting docs if there's relevant content, but we're under no obligation as a project to merge features  just because one of our devs was funded to do so.  That's why we've been reluctant to write contracts that require something be integrated into Stan.

whether or not we also require quantile functions for the one-dimensional discrete families to ensure a uniform interface across all of the one-dimensional families.

Unless there's an easy way to implement them, I don't think we should require them.

I’m not sure I understand the comments about the location parameter not being meaningful for the quantile functions.

We should use the full set of parameters, including location.  Anything else is just inviting users to implement their own location adjustments and that's a mess of possible sign errors.

require quantile functions for the one-dimensional discrete families to ensure a uniform interface across all of the one-dimensional families.

I agree that they're super useful for truncated RNGs and should be included.  Just not required.

Thanks @betanalpha . I'm pretty much in agreement with @bob-carpenter 's responses.
The quantile functions in the location-scale family definitely depend the location parameter. The minor question is about the quantile density functions (derivative of the quantile function wrt to the depth), which don't depend on the location, but I'm happy with keeping the signatures consistent.
With the discrete distributions, what is the Stan use case for the _qf that isn't already satisfied by the _rng? If we are lacking _rng functions for any discrete distributions, we should add them, but that seems like more of a defect in current Math.
One general thing on these grant-motivated PRs. The grantee could have time management problems if Stan developers suggest adding potentially useful features to the design doc that were not part of the grant proposal. Not that we should be merging half-baked designs or implementations thereof (irrespective of grant funding), but I wanted to make it explicit why I was putting quantile functions of univariate continuous distributions into the design and put other related things in the section on things that are out of scope for this design doc. The latter things might be worth doing by someone eventually, but I don't think their absence should hold up progress on the univariate continuous quantile functions.

With the discrete distributions, what is the Stan use case for the _qf that isn't already satisfied by the _rng? If we are lacking _rng functions for any discrete distributions, we should add them, but that seems like more of a defect in current Math.

The main use case I’ve encountered is sampling from truncated discrete distributions, for example a Poisson distribution truncated to values between 0 and 10.  Naive rejection sampling approaches are prone to near-infinite loops if the source strength is too large which makes them dangerous for use in the generated quantities block.  Because the space is discrete the inverse CDF method can be implemented by summing over the probabilities, but it’s messy.  Having explicit quantile functions makes it much easier.
The bigger issue I’m worried about is consistency of the probability library.  Most of the probability libraries in R, Python, Mathematica, etc have a pretty uniform coverage of the exposed representations.  One you know the name of a family of distributions you know how to call the corresponding density, CDF, quantile function, rng, etc.  At the point the coverage in Stan is pretty uniform, but it’s becoming less and less uniform as more obscure families are added without all of the functionality.  If a user is assuming that everything will be uniformly available but gets an error message then can become frustrating assuming that there’s a spelling error or other typo somewhere and not just a non-implemented functionality.
It would be great to add functionality to the compiler to fill in these gaps so that if a user calls for some functionality that has not yet been implemented then they get a precise error message noting that gap and not the default error message noting the the function being requested just doesn’t exist.

One general thing on these grant-motivated PRs. The grantee could have time management problems if Stan developers suggest adding potentially useful features to the design doc that were not part of the grant proposal. Not that we should be merging half-baked designs or implementations thereof (irrespective of grant funding), but I wanted to make it explicit why I was putting quantile functions of univariate continuous distributions into the design and put other related things in the section on things that are out of scope for this design doc. The latter things might be worth doing by someone eventually, but I don't think their absence should hold up progress on the univariate continuous quantile functions.

Personally I think that any proposal should be judged on its merits for the project, and not any extraneous circumstances like a motivating grant.  A discussion for how many univariate quantile functions we need to implement without making the overhead too high for any contribution is a meaningful one independent of that grant context.  But if we continue to consider similar contexts then we’re prone to shifting these discussion away from what’s good for the project to what’s good for a single developer.

It would be great to add functionality to the compiler to fill in these gaps so that if a user calls for some functionality that has not yet been implemented then they get a precise error message noting that gap and not the default error message noting the the function being requested just doesn’t exist.

I think this is a great idea.  I opened a stanc3 issue to address it, quoting your comment as motivation:  https://github.com/stan-dev/stanc3/issues/987

any proposal should be judged on its merits for the project, and not any extraneous circumstances like a motivating grant.

I agree.  It's also supported by Stan policy which says nothing about preferential treatment for funded features.

When or how do we merge these? I really like this idea, hoping to make it "official". I mean, it's still a design doc so things can change or be updated, right?

I want to make some small changes to it first.


assert_eq prints escaped values

Describe the bug
assert_eq prints escaped values. For example:
assert_eq("]", " ]")

prints
   expect="\093"
   actual=" \093"

To Reproduce
Steps to reproduce the behavior:
Add assertion in test code:
assert_eq("]", " ]")

Expected behavior
Should print instead:
   expect="]"
   actual=" ]"

Picotron version
0.1.1D
Unitron version
0.4.0

Internally runner communicates with UI, by sending expected/actual arguments in a form of a string created by running pod(expected). This function escapes special characters. One of a special character is ] (it is used in pod metadata). But there is more - all non-ascii characters are encoded to \XXX form


Add gov.carbonic.finance to domains.json

Hi! What is your PR about?

[ ] Add a custom domain for your space

Closing this PR for now, feel free to open it again once you've done the changes.


Add a ROOT path constant for scan

Continuation of work on concerns raised in #5770
Replace use of Helper.gem_path with Snapshot::ROOT

👍


remove paragonie/random_compat

random_bytes() and random_int() are integrated with PHP 7

On that note we can also replace the symfony/polyfill-php* that are less then 71

@BackEndTea done :)


Support analysis over multiple systems

Example usage:
compare-mt ./example/ted.ref.eng example/ted.sys2.eng example/ted.sys1.eng example/ted.sys2.eng --compare_scores score_type=bleu,bootstrap=1000,compare_directions="0-1;1-2"
I will resolve the conflicts.

Thanks! Basically LGTM. Could you resolve the conflicts and we can merge?

Thank you! I am working on that!

Conflicts resolved! Please take another look.

Awesome, thanks!


Info panel displays duration for files of type "image"

There is no point to display "duration" field for files of type "image" but HomeAgllery does that with fake value of "00:00".

Hi @MarioSob
Thank you for your feedback. You are right. Duration is not necessary for images.
I will consider it when I will redesign the detail section. PRs are also welcome.

Closing it due inactivity. Please do not hesitate to reopen it if required.


296 upgrade to rails 5

Migration should be also changed a bit:
DEPRECATION WARNING: Directly inheriting from ActiveRecord::Migration is deprecated. Please specify the Rails release the migration was written for:

  class RemoveHttpAndHttpsFromPmt < ActiveRecord::Migration[4.2] (called from load at /home/marek/.asdf/installs/ruby/2.3.1/bin/rake:23)

Another element which can be easily fixed:
DEPRECATION WARNING: ActiveRecord::Base.raise_in_transactional_callbacks= is deprecated, has no effect and will be removed without replacement. (called from <top (required)> at /home/marek/git/atmosphere/spec/dummy/config/environment.rb:5)

It is defined in config/application.rb

This is strange:
λ leeloo dummy → λ git 296_upgrade_to_rails_5* → rails s
=> Booting WEBrick
=> Rails <IP_ADDRESS> application starting in development on http://localhost:3000
=> Run `rails server -h` for more startup options

As far as I know webrick was changed into puma in rails 5. Why it is started here?

See
https://devcenter.heroku.com/articles/getting-started-with-rails5#webserver
I've tried that and after adding puma to gemspec Webrick is not used any more.


DIP14: add serialization test vectors

Add serialization test vectors to DIP14 for xprivkey and xpubkey.

@QuantumExplorer @hashengineering Can you guys review this?

@QuantumExplorer @hashengineering Re-ping

Sorry for missing this.  I will add these new test vectors as unit tests to dashj to make sure that they work.

@dashameter did you use the version bytes as defined in this DIP?  They did not work for me.

@dashameter did you use the version bytes as defined in this DIP? They did not work for me.

I did. Do they not work for you in the javascript or in the java implementation?

@dashameter did you use the version bytes as defined in this DIP? They did not work for me.

I did. Do they not work for you in the javascript or in the java implementation?

The Java Implementation (dashj) as well as another tool called Bitcoin Address Utility which can convert a base58 string to a byte array. The data within the serialization of this PR matches the Java Implementation, but not the version bytes or checksum.

@dashameter did you use the version bytes as defined in this DIP? They did not work for me.

I did. Do they not work for you in the javascript or in the java implementation?

The Java Implementation (dashj) as well as another tool called Bitcoin Address Utility which can convert a base58 string to a byte array. The data within the serialization of this PR matches the Java Implementation, but not the version bytes or checksum.

@HashEngineering are you using the version bytes from this PR https://github.com/dashpay/dips/pull/81 ?

@dashameter yes, I was using the version bytes from #81.  My comments about the incorrect version bytes were because I was looking at the  commit history of this PR rather than the DIP14 document of the master branch.  Therefore I will close out the related issue #97 and approve of this PR.


Comparative tear sheet

Would it be an idea to build a tear-sheet that holds two return streams (the current and next iteration of an alpha for example) against the same light?

Yes, I think that would be very neat.

What kind of comparison would you imagine to see? That is, what plots would be affected? and in which way?
Currently I compare lots of different factors and to do it I simply save the plots to file and then I compare the saved images, much better than having them on the Notebooks (but then it depends on what program you use to view the images).

I would imagine this as putting for example a plot of both cumulative returns along with A-B to see the spread created in the new iteration of a model? The same approach could be applied to rolling sharpe, rolling IC, etc.
That way when comparing two alphas, you can more easily identify exactly where and by how much they differ.

It seems reasonable but we have to look plot by plot and see if it makes sense to create a comparative version for each of them and how to make the comparison. Some of the plots might become difficult to read  if we put too much overlapping data on them.

I think it should be possible to just pass in the same axes object twice and create comparisons that way. I don't think it's something we should add explicit support for.

makes sense, it was just a "thinking out loud" type of question :)
this can be closed in that case