Wrong Signature Thumbprint - Install Visual Studio - Windows Server 2022 Runner Image

Description
Install Visual Studio has the wrong signature thumbprint on the test.
==> azure-arm.build_vhd: Provisioning with powershell script: /agent/_work/1/s/runner-images/images/windows/scripts/build/Install-VisualStudio.ps1
azure-arm.build_vhd: Downloading Bootstrapper ...
azure-arm.build_vhd: Downloading package from https://aka.ms/vs/17/release/vs_Enterprise.exe to C:\Users\INSTAL~1\AppData\Local\Temp\vs_Enterprise.exe...
azure-arm.build_vhd: Package downloaded in 0.42 seconds
azure-arm.build_vhd: Signature thumbprint do not match expected.
azure-arm.build_vhd: At C:\Program Files\WindowsPowerShell\Modules\ImageHelpers\InstallHelpers.ps1:973 char:9
azure-arm.build_vhd: +         throw "Signature thumbprint do not match expected."
azure-arm.build_vhd: +         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
azure-arm.build_vhd:     + CategoryInfo          : OperationStopped: (Signature thumb...match expected.:String) [], RuntimeException
azure-arm.build_vhd:     + FullyQualifiedErrorId : Signature thumbprint do not match expected.
azure-arm.build_vhd:
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
N/A private build
Is it regression?
Yes - this worked on 19th August 2024
Expected behavior
All tests pass successfully and build completes successfully for Windows 2022 using the build code in runner images repo
Actual behavior
Our pipeline that builds the Windows 2022 image using the runner-images code from this repo is failing when attempting to install Visual Studio Enterprise and producing thumbprint error.
Repro steps
Run Packer build using the latest code in this repo for Windows Server 2022

@Ami-007 Thank you for bringing this issue to us. We are looking into this issue and will update you on this issue after investigating.

I am also having this issue. I see this issue frequently with this repository. Is there no way to have this automated in some way instead of doing manual fixes?

Hi @cupacheeno , the new image has been rolled out (20240912.1.1) .The issue is fixed now. kindly synch your main .Thanks

Hi @cupacheeno , the new image has been rolled out (20240912.1.1) .The issue is fixed now. kindly synch your main .Thanks

Where has 22 been fixed? I see a code update for 2019, but not for 2022. I have run a build and am still seeing the same error

Hi @Ami-007  , Please follow the official status page of Azure DevOps for updates https://status.dev.azure.com/_event/543117809

Hi @Ami-007 , Please follow the official status page of Azure DevOps for updates https://status.dev.azure.com/_event/543117809

What does that have to do with the price of eggs?
I’m telling you that you haven’t updated the VS signature for Windows 2022 builds. Which incidentally, is what this issue is about.

@vidyasagarnimmagaddi can confirm in our instance the runners now work as expected

Hi @Ami-007  , the visual studio signature thumbprint is already with the latest one,  windows-2022 is successful.
The thumbprint we are using is this F9A7CF9FBE13BAC767F4781061332DA6E8B4E0EE.Kindly check the same. thanks

Hi @Ami-007 , the new image version 20240915.1 is rolled out. And we see no issue with visual studio signature thumbprint. Kindly synch your main . Closing the issue. Thanks.

I still have this issue on main - and I did try "releases/win22/20241021" where I also have this issue!


SV Testbench Integration

The current setup is designed to work with CocoTB testbenches.  Hopefully, we can get SV test benches to work.  This will likely require some rework of the caravel-sim-infrastructure.

I found out that sv is already supported for the most part; we just need to remove the Docker aspect.  I got RTL sims working already after installing the riscv toolchain.


SSLV3_ALERT_HANDSHAKE_FAILURE when using Ed25519

I'm attempting to use websockets over TLS using a certificate signed with Ed25519.
I receive the following error:
flutter: HandshakeException: Handshake error in client (OS Error:
	SSLV3_ALERT_HANDSHAKE_FAILURE(tls_record.cc:594)
	HANDSHAKE_FAILURE_ON_CLIENT_HELLO(handshake.cc:603))
[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: HandshakeException: Handshake error in client (OS Error:
	SSLV3_ALERT_HANDSHAKE_FAILURE(tls_record.cc:594)
	HANDSHAKE_FAILURE_ON_CLIENT_HELLO(handshake.cc:603))
#0      _SecureFilterImpl._handshake (dart:io-patch/secure_socket_patch.dart:104:46)
#1      _SecureFilterImpl.handshake (dart:io-patch/secure_socket_patch.dart:147:25)
#2      _RawSecureSocket._secureHandshake (dart:io/secure_socket.dart:803:54)
#3      _RawSecureSocket._closeHandler (dart:io/secure_socket.dart:796:15)
#4      _RawSecureSocket._eventDispatcher (dart:io/secure_socket.dart:739:9)
#5      _rootRunUnary (dart:async/zone.dart:1444:13)
#6      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
#7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
#8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:733:19)
#11     _StreamController._add (dart:async/stream_controller.dart:607:7)
#12     _StreamController.add (dart:async/stream_controller.dart:554:5)
#13     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1837:35)
#14     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1307:18)
#15     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#16     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

In my Go backend:
2022/01/15 08:09:57 http: TLS handshake error from <IP_ADDRESS>:60355: EOF
2022/01/15 08:09:57 http: TLS handshake error from [::1]:60354: tls: peer doesn't support any of the certificate's signature algorithms

I'm using HttpOverrides to provide the certs but this is never hit. I believe the issue is located in secure_socket.dart and believe that Ed25519 is not yet supported.
Is Ed25519 supported in Flutter? Is it in the pipeline? Is my issue a red herring and not related to Ed25519?
 flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.8.1, on macOS 11.6 20G165 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.3)
[✓] VS Code (version 1.63.2)
[✓] Connected device (2 available)

• No issues found!

Hi @MousyBusiness, please provide a complete minimal reproducible code sample.
Also, what platforms are you experiencing this issue on?
Thank you

MacOS, my conclusion is ED25519 is not implemented as the flow works with ECDSA keys.
Unfortunately a minimum reproducable example would be exceedingly difficult.

Without a minimal reproducible sample, the issue is not actionable.
Also, seeing as socket code lives in dart, I believe it would be best if this issue is filed on the dart-lang/sdk repo.


"Fill Value" argument request for union_relations

Hi there,
I was using the union_relations macro to combine two datasets. Works great, but one thing I wish there was an option to do would be to have an argument to choose what to fill the null values for non-matching columns with.
For example, the datasets I was combining both contain the same dimension columns (time / location), but don't contain the same numeric metric fields. It would be useful for me to have the non-matching criteria be entered as as 0 instead of a null value as I use this data for modeling and have been using nvl to coerce the data to 0 before summing.
I was considering if a fill_value argument could be added to fill the unmatched columns with a whatever the argument is set to? I think this would add more flexibility to the union_relations macro than it currently allows and would generally make the function even more useful.
Appreciate it!

Hey @Horizon-cmchugh, this feels reasonable as long as it defaults to null for backwards compatibility reasons! I'd welcome a PR that changed this (and added tests)


[Dropdown] Multiple Select

como faço para não apagar o que selecionei no multiple select, ele apaga o que selecionei do select ai não posso selecionar duas vezes

Hi, could you please provide a test case with specific steps to reproduce the issue as per our contributing guidelines? You can fork this JSFiddle.

https://jsfiddle.net/WallaceMielniczki/ca0rovs3/16/ preciso selecionar a mesma turma duas vezes no multiple select

@WallaceMielniczki I think Google Translate’s failing me, can you please elaborate? I didn’t understand the part about selecting the same class twice.

sim desculpa, Select the same item from the selection twice

@WallaceMielniczki It’s not possible out of the box. You’ll either have to use a different UI pattern, or work around it somehow.


[deploy] Extend timeout if this is the first action run

Summary
In case we're waiting for serverless to stand up, let's extend the timeout to 10m instead of 1m30

Current dependencies on/for this PR:

main

PR #11   👈

This comment was auto-generated by Graphite.


iOS compilation error - CLLocation.sourceInformation

Environment
System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i7-3820QM CPU @ 2.70GHz
Memory: 725.22 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 18.9.0 - /usr/local/bin/node
Yarn: Not Found
npm: 8.19.1 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: Not Found
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.0 => 0.70.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Platforms
iOS
Versions

Android:
iOS: 14.4
react-native-geolocation: 3.0.3
react-native: 0.70.0
react: 18.1.0

Description
After installing react-native-geolocation and running pod install, I get the following build error:
Property 'sourceInformation' not found on object of type 'CLLocation *'

In file RNCGeolocation.mm
I see that the call is wrapped in @available but I don't know enough about Objective C to know why this would or wouldn't work:
  if (@available(iOS 15.0, *)) {
    mocked = location.sourceInformation.isSimulatedBySoftware;
  }

I am building for iOS 14.4 which does not have the CLLocation.sourceInformation property
Reproducible Demo
None at this time but I can provide if necessary

Thank you for reporting. Can you tell me more about what you exactly mean by building for 14.4?

@michalchudziak After just installation of react-native-geolocation throw same error for me as well.

I am facing the same issue could you please provide any solution?

I am facing the same issue could you please provide any solution?

Just buy new macbook.(atleast macbook 16 pro ). Because old models doesn't support ios 15 build.

@michalchudziak Sorry for the delay in responding but looks like others are having the same problem above. If you see my full environment list, I am using an older macbook with Catalina, so I am using XCode 12.4 and targeteting iOS v14.4.
as @Asmatchd shared in the screenshot, I am getting the same error

Having the same problem (on 2015 Macbook Air, Big Sur). Any suggested workarounds?

same error


flow: Add missing 'Context' types

Components with static contextTypes get injected the context
object (of type Context).
Some components had this injected but the types were missing.
This adds context: Context to all such components.

Thanks @borisyankov !
I tried looking at a couple of these files, because I was curious what the effect of adding this was -- and I found they don't seem to use context at all! This includes at least ZulipStatusBar and LightboxHeader.
This might be a consequence of @agzuniverse 's recent refactorings to push down styles that were coming from context but actually were specific to the component.
Would you just remove the context properties we're not using? That'd clean things up a bit further, and also would make it easier to study this change.

Meanwhile, I just went ahead and merged the first of these two commits.

The rest of the commits should now be ready to merge too.

@gnprice rebased. Looks ready to me.

Merged -- thanks @borisyankov !


Fix typo in error message

I noticed a typo in one of the error messages. That's all.

Thank you!


Tset Windowing Implementation [DO NOT MERGE]

Lets add documentation for Windowing TSet API

Let's add documentation for Windowing TSet API

Yes, let's do it.

Please remove the Pytorch related stuff as well.

My personal opinion is, we need to take off the link.countWindow(len, computeFn) and make is something like, link.countWindow(len).process(computeFn).
ATM we have both the options and it would be confusing for the user IMO. (we may put the identity function as the default compute)


Transpose for 3D tensor

I need to transpose a tensor of shape [i, j, k] into [j, i, k]. This is a result of a number of transformations, so I can't simply load it from memory in a different shape. The built in transpose tl.trans currently only supports 2D tensors.
Are there any workarounds that I could use to achieve this in the short term?

I don't think you want to use tl.trans that only transpose a tensor in a single block.
Here's a potential solution, but I haven't thought it very deeply.
Try to collapse the i, j dimension: think of it as [(i, j), k] and parallelize it on the (i, j).
For loading values in each block, recover i and j, and calculate the offset of (j, i), then store each block of values.

This might be possible, but I don't immediately see it -- I probably should have provided more context, sorry! Why would I not want to transpose a single block?
The transpose was to emulate torch.bmm, which afaik doesn't exist in triton. A pytorch version of what I'm really trying to do is:
a = torch.randn((i, j, k))
b = torch.randn((i, k, d))

out = torch.bmm(a, b) #  shape: [i, j, d]

I was trying to get the same result by effectively doing the following in triton
(a.permute(1, 0, 2)[:, :, :, None] * b).sum(2).permute(1, 0, 2)

I can see if there is a way to rethink the whole approach, if no workaround is possible. Alternatively, how hard would it be to contribute a change to enable this? Where should I look?

hmm, if you want to perform bmm only, I don't think you will need any transpose op.
You may want to just go implement it like what we did for matmul. The only differences are the ways in calculating offsets and parallelizing the blocks.

I guess I want to perform bmm as part of a triton kernel. In the above example a and b are blocks that have already been loaded with tl.load, and subsequently have had various computations performed on them. If I followed the approach of triton.ops.matmul I would have to write two intermediate matrices back to memory, perform the bmm, load the result, and continue with the rest of the kernel?
Sorry for my imprecise language, I'm still not very familiar with triton.

Maybe I still haven't got the high level ideas. Can you describe what you want to optimize in torch?
(a.permute(1, 0, 2)[:, :, :, None] * b).sum(2).permute(1, 0, 2) -> There doesn't seem to have any bmm ops

Here is some pseudo-code that describes what I am trying to do:
@triton.jit
def kernel(
    a_ptr,
    a_i_stride,
    a_j_stride,
    a_k_stride,
    b_ptr,
    b_i_stride,
    b_k_stride,
    b_d_stride,
    o_ptr,
    o_i_stride,
    o_j_stride,
    o_d_stride,
    BLOCK_I,
    BLOCK_J,
    BLOCK_K,
    BLOCK_D,
):
    i_start = tl.program_id(0) * BLOCK_I
    j_start = tl.program_id(1) * BLOCK_J
    k_start = tl.program_id(2) * BLOCK_K

    i_range_offs = tl.arange(0, BLOCK_I)
    j_range_offs = tl.arange(0, BLOCK_J)
    d_range_offs = tl.arange(0, BLOCK_D)
    k_range_offs = tl.arange(0, BLOCK_K)

    a_offs = (
        (j_start + j_range_offs[:, None, None]) * a_j_stride
        + (i_start + i_range_offs[None, :, None]) * a_i_stride
        + (k_start + k_range_offs[None, None, :]) * a_k_stride
    )
    # a_data: [BLOCK_I, BLOCK_J, BLOCK_K]
    a_data = tl.load(a_ptr + a_offs)

    b_offs = (
        ((i_start + i_range_offs[:, None, None]) * b_i_stride)
        + ((k_start + k_range_offs[None, :, None]) * b_k_stride)
        + (d_range_offs[None, None, :] * b_d_stride)
    )
    # b_data: [BLOCK_I, BLOCK_K, BLOCK_D]
    b_data = tl.load(b_ptr, b_offs)

    # MORE ALGORITHM HERE

    ############# START CODE THAT FAILS ##############
    # a: [BLOCK_J, BLOCK_I, BLOCK_K, 1]
    a = tl.transpose(a_data, (1, 0))[:, :, :, None]  # tl.transpose will fail
    # intermediate: [BLOCK_J, BLOCK_I, BLOCK_K, BLOCK_D]
    intermediate = a * b_data
    # intermediate: [BLOCK_J, BLOCK_I, BLOCK_D]
    intermediate = tl.sum(intermediate, axis=2)
    # output: [BLOCK_I, BLOCK_J, BLOCK_D]
    output = tl.transpose(intermediate, (1, 0))  # tl.transpose will fail
    ############# END CODE THAT FAILS ################

    # MORE ALGORITHM HERE

    o_offs = (
        (i_start + i_range_offs[:, None, None]) * o_i_stride
        + (j_start + j_range_offs[None, :, None]) * o_j_stride
        + (d_range_offs[None, None, :] * o_d_stride)
    )
    tl.store(o_ptr + o_offs, output)

There is more of the algorithm that operates on this block before and after the code that fails, so I can't directly load a_data transposed.
If the code that fails were in pytorch, it could be written either with torch.bmm or with permute. I don't know if there is currently a way in triton to do this.
out_bmm = torch.bmm(a_data, b_data)
out_trans = (a_data.permute(1, 0, 2)[:, :, :, None] * b_data).sum(2).permute(1, 0, 2)
torch.allclose(out_bmm == out_trans) # True

out_bmm = torch.bmm(a_data, b_data) # kernel1
out_trans = (a_data.permute(1, 0, 2)[:, :, :, None] * b_data).sum(2).permute(1, 0, 2) # kernel 2

How about this? I don't see any particular reason to fuse them together

It sounds like there is no way to transpose the first two dimensions of a 3d tensor currently. I'll see if I can rethink the approach.

out_bmm = torch.bmm(a_data, b_data) # kernel1
out_trans = (a_data.permute(1, 0, 2)[:, :, :, None] * b_data).sum(2).permute(1, 0, 2) # kernel 2

How about this? I don't see any particular reason to fuse them together

Hi @Jokeren,
I think for stuff like out_trans = (a_data.permute(1, 0, 2)[:, :, :, None] * b_data).sum(2).permute(1, 0, 2) # kernel 2
there would be some benefits in l2 cache reuse and eliminating kernel launches if we are to fuse them in a Triton kernel? Thanks.


Throw option_required_exception if option value is not present

Currently an std::domain_error is thrown in as(), but this does not show the missing option name. Proposed PR throws in ParseResult.operator[] when trying to get an option without a value.

This change is

Looks reasonable. The tests will need fixing though.

Sure, my bad I have not checked the tests. Also, it might be worth a consideration to remove the check in as() method. Unless there is a way to obtain OptionValue other than with ParseResult.operator[], that check will never trigger. Let me know if you agree, I'll update the PR.

I believe this has already been changed to something more suitable.


gnome-remote-desktop incompletely enables PipeWire, breaks audio and video playback

Describe the bug
The option services.gnome-remote-desktop.enable = true (enabled by default on GNOME) causes PipeWire to be enabled incompletely (https://github.com/NixOS/nixpkgs/blob/062a0c5437b68f950b081bbfc8a699d57a4ee026/nixos/modules/services/desktops/gnome/gnome-remote-desktop.nix#L28), i.e. without enabling ALSA/PulseAudio/Jack support. Since the switch to WirePlumber, this breaks all audio and video playback on some systems (see #163066).
As far as I can tell, the best option would be to disable gnome-remote-desktop by default, remove the services.pipewire.enable = true declaration from it, and add an assertion to let the user know that PipeWire must be enabled for gnome-remote-desktop to work.

FYI there is a pending pull request that tries to make GNOME be pipewire by default #163075

Should be fixed by #165231


BUG&TST: Fix area plot for Series and add test

There seems a little bug in SamplePlot that failed area plot. It is due to after sampling, since scol is not assigned, it will return a full DataFrame instead of Series. And looks like area plot turns good as well after fixing it.

Before the bug fixing, the area plot looks like:

Thanks!!!!


Invalid PAYMENT_PROCESSOR_COVER from the host to itself

Detected by @kewitz while investigating a PayPal issue for OCEU.
Contributions to hosts that get refunded create a PAYMENT_PROCESSOR_COVER transaction. It doesn't make sense for hosts to cover payment processor fees for themselves.
This bug has been there since the implementation of PAYMENT_PROCESSOR_COVER, but at the beginning it had no impact since we were debiting the host and, at the same time, crediting it for the same amount. It really became an issue when we introduced the condition that bypasses the double-entry approach if FromCollectiveId = CollectiveId.
Since then, we've only inserted the CREDIT, topping host's balances for the payment processor fee amount each time there was a refund.
Suggested fixes

Add a check for refundPaymentProcessorFeeToCollective to not do it when refunding a transaction that only involved the host account.
Add a test to check this behavior in test/server/lib/payments.test.js
Mark all transactions that have been created this way as deleted, estimate the impact on the host's balances, and notify them if needed.


Changes to the Weather Underground client library

Changes to the Weather Underground client components to add feels-like temp, UV index, month/day of the forecast, forecast text, and observation date/time text.

Dani...I added a few changes to the Weather Underground library as previously mentioned for the enhancements I made to the Color Weather Station.  If you agree, I would like to have these merged to the master copy of the library.  (This is my first pull request, so if I have not done this correctly, please let me know ;) ).

Hi Keith. Thank you for your contribution, it looks very good! Cheers, Dani


Is there a way to tell ruff to ignore comments?

Since Ruff is made to work in unison with Black, and Black doesn't reformat comments that exceed the line length, is there a way to tell Ruff to ignore these?

@xeon826 if you're using Black to enforce your line length I'd just recommend disabling E501 e.g. https://github.com/PrefectHQ/prefect/blob/a3a2f84ba17b8a4469f29fc2a2bfc6dbffd40ed0/.ruff.toml#L1-L2

I'm using ruff pre-commit and I added that to its ignore but I'm also using it as a linting tool and it gives me the diagnostic if comments exceed the line length, I feel like --ignore-comments would be a useful feature.

Why don't you put it in your Ruff configuration so it is always applied?
Note this is also a duplicate of https://github.com/astral-sh/ruff/issues/4429 and https://github.com/astral-sh/ruff/issues/4595
We cover this in the FAQ too.

I use it to check for line length as a linting tool in my environment, so I'd want it to report on lines that are too long, if I ignored E501 in my pyproject.toml I wouldn't get that behavior, I added an ignore for the rule in pre-commit because I don't want it to report on comments that are too long and prevent the commit. If I told ruff to ignore E501 all together it wouldn't report on it in my IDE diagnostics but that's what I want, by that I mean this:

pyproject.toml
[tool.black]
line-length = 88
skip-string-normalization = true
skip-magic-trailing-comma = true
preview = true
target-version = ['py39']

[tool.isort]
profile = 'black'

[tool.ruff]
line-length = 88
target-version = 'py39'
fix = true

.pre-commit-config.yaml
repos:
  - repo: https://github.com/astral-sh/ruff-pre-commit
    rev: v0.0.277
    hooks:
      - id: ruff
        files: "\\.(py)$"
        args: [--extend-ignore=E501]
  - repo: https://github.com/pycqa/autoflake
    rev: v2.2.0
    hooks:
      - id: autoflake
        files: "\\.(py)$"
  - repo: https://github.com/psf/black
    rev: 23.3.0
    hooks:
      - id: black
        language_version: python3.9
        files: "\\.(py)$"
        args: [--config=pyproject.toml]
  - repo: https://github.com/pycqa/isort
    rev: 5.12.0
    hooks:
      - id: isort
        files: "\\.(py)$"
        args: [--settings-path=pyproject.toml]

Black doesn't reformat comments that exceed the line length

@xeon826, are you referring to lines containing only a comment? Black has often rearranged my # type: ignore and # noqa comments, much to my chagrin, especially because I always include descriptive messages about why I'm ignoring something on that line.

As an aside, @xeon826, you can 100% replace the functionality of autoflake and isort with ruff, including all the customization in your pyproject.toml. This is 99% likely to be true of flake8 as well, unless you are enabling some esoteric extension rules outside of your pyproject.toml

@tylerlaprade Lines that are only a comment, yes. I'd remove autoflake but ruff doesn't include the expand-star-imports feature

Since this is a duplicate and there's a workaround I'm going to close this for bookkeeping purposes. Thanks for raising!

I'm using ruff-pre-commit and I added that to its ignore as a workaround but I'm also using ruff as a linting tool and it gives me the diagnostic if comments exceed the line length, I feel like --ignore-comments would be a useful feature.

i think so too.

--line-length <LINE_LENGTH>  Set the line-length

Don't we have a solution for this yet?


Introduce collision-free DOM IDs (fix #65)

@mpetuska Could you do me a favor and not squash commits? This allows me to keep track of what's merged.
Closes #65

How do you mean? Commits are only squashed on merge, so you're free to push to your feature branch however you prefer.

On squashing commits: When I work on multiple branches and create separate PRs from those, it gets very messy when merging back from upstream. I won't see which commits actually landed in upstream, and which ones I might have forgotten to put in the right branch to be included in a PR.

RE: Squashing
I'm still not convinced. Don't take it the wrong way, but I think master branch readability in any OSS project is more important than meeting any singe contributor's workflow.
It's probably not what you expected to hear back, but can I suggest not spreading yourself too thin and limit working on one or two issues at any given time. I do my best to be as responsive with PRs as I can, so that you wouldn't have them stewing and blocking you for too long. Additionally, all squashed commit messages are included into squash commit message, so you can have a look at those if you need a refresher of what's landed in master.

RE: Squashing
I'm still not convinced. Don't take it the wrong way, but I think master branch readability in any OSS project is more important than meeting any singe contributor's workflow.
It's probably not what you expected to hear back, but can I suggest not spreading yourself too thin and limit working on one or two issues at any given time. I do my best to be as responsive with PRs as I can, so that you wouldn't have them stewing and blocking you for too long. Additionally, all squashed commit messages are included into squash commit message, so you can have a look at those if you need a refresher of what's landed in master.

OK, different preferences here. I'm following the original Linux kernel style, where they never squash commits. Some aspects are explained here.

If you have pulled changes from another developer’s repository, you are now a custodian of their history. You should not change it.

Of course, this is your repository. I can only point out that squashing commits comes at a price.
Another consequence, while not relevant for me, is that contributors will be disadvantaged in the GitHub committer statistics, when a series of maintainer commits is preserved 1:1, while a series of contributor commits will be squashed n:1.

OK, different preferences here. I'm following the original Linux kernel style, where they never squash commits. Some aspects are explained here.

If you have pulled changes from another developer’s repository, you are now a custodian of their history. You should not change it.

Of course, this is your repository. I can only point out that squashing commits comes at a price.
Another consequence, while not relevant for me, is that contributors will be disadvantaged in the GitHub committer statistics, when a series of maintainer commits is preserved 1:1, while a series of contributor commits will be squashed n:1.

I see. Your second point raises some concerns. Let me stew on this for a while before I make any decisions.

If you are mainly concerned with GitHub statistics, that could be alleviated by using PRs with squashed commits for your own series of changes.
I can understand that a GitHub history with less noise would be ideal, but that seems hard to maintain in practice without losing information where it matters most: Most people tend to look no further than commit summary lines when reviewing Git history, as this is what most tools present.
Now let's say, someone starts to work on a change, then discovers a related issue, improves documentation and tweaks the build system. Often, such changes warrant a distinct commit message each, which would be lost in (summary line) history if squashed into one overarching commit.
An example, though probably not resulting from squashing, is 8663bed516db6722e1c3ba57278a0f22644b60d8, which suggests it deals with "contributing guidelines", but also changes the build system, adds tests, reconfigures Webpack, adds Sass and others.
Often there is a trade-off between losing important information in (summary line) history, or having to skip the occasional "fix typo" or "chore" commit.

I do raise PRs for most of my changes, although I must admit there have been quite a few "cleanup" commits unrelated to any particular issue that I've pushed straight to master.
As for details lost, my thinking is that if all changes go through PRs, they would have all the details in much more descriptive manner including comments and PR discussions. With all that, commit summary cannot even come close to that kind of comtext and squashing commits always leaves a reference to relevant PR.

I have tried to find some data on merge strategies and looked at a non-representative sample of projects. It seems that more recent projects tend to favor squashing commits on PRs. The same projects show micro-commits from maintainers, which would most probably be squashed if coming in via PRs.
Conclusions:

For contributors, the PR is the new commit.
For maintainers, different rules apply.
The "clean history" objective is not pursued consistently.
GitHub commit statistics are heavily biased towards maintainers.

For me, point 4 does not really matter as GitHub's commit and line count statistics seem pretty meaningless anyway. However, folks trying to impress potential employers might think differently.
There seems to be a lack of research on the consequences of choosing a commit strategy. I could not find any data about a strategy's potential of supporting specific workflows or encouraging specific types/sizes of contributions.
Regarding details lost, I agree that additional commit message lines and collateral like issue and PR discussions are valuable. I'd just be missing a compact yet complete, detailed changelog, which an unsquashed list of commit summary messages could provide (if done sensibly).

I'm maintaining a separate changelog in the repo to track changes feature wise. As for disparity between contributors and maintainers, I've just protected master branch to prevent direct pushes from anyone (including admins) so that anyone working on this repo would be on an equal footing.


Use sed for the core of logtail.php

Much faster than using PHP to extract intermediate lines.

Yes, there are several unix commands that can return the lines of a file between two line numbers. One of them is sed, which is a stream editor that can perform various text transformations on files or input streams. For example, if you want to extract lines 3 to 7 from a file named input.txt, you can use the following command:
sed -n '3,7p; 8q' input.txt

This command tells sed to print (p) only the lines that match the address range 3,7, and to quit (q) after reading the line 8. The -n option suppresses the default output of sed, so that only the lines you want are printed¹.
Another command that can return the lines of a file between two line numbers is awk, which is a programming language that can process text files or input streams. For example, if you want to extract lines 10 to 20 from a file named file.txt, and also include the line numbers in the output, you can use the following command:
awk 'FNR==10,FNR==20 {print FNR ":" $0}' file.txt

This command tells awk to print (print) the file record number (FNR) followed by a colon and the whole line ($0) for the lines that match the address range FNR==10,FNR==20. FNR is a built-in variable that stores the current line number of the file being processed³.
There are other commands that can return the lines of a file between two line numbers, such as head, tail, split, and cat. You can check the web search results I found for you to learn more about them. I hope this helps you with your unix query.
Source: Conversation with Bing, 12/23/2023
(1) Splitting a File at Given Line Numbers | Baeldung on Linux. https://www.baeldung.com/linux/split-file-at-line-numbers.
(2) Print line range from file, and include line numbers. https://unix.stackexchange.com/questions/605080/print-line-range-from-file-and-include-line-numbers.
(3) unix - Split a file into two files at a given line - Super User. https://superuser.com/questions/624237/split-a-file-into-two-files-at-a-given-line.
(4) Extract lines between two line numbers in shell - Stack Overflow. https://stackoverflow.com/questions/21759562/extract-lines-between-two-line-numbers-in-shell.
(5) With the Linux "cat" command, how do I show only certain lines by number. https://unix.stackexchange.com/questions/288521/with-the-linux-cat-command-how-do-i-show-only-certain-lines-by-number.
(6) Reading lines from a file based on a list of line numbers and writing .... https://unix.stackexchange.com/questions/146218/reading-lines-from-a-file-based-on-a-list-of-line-numbers-and-writing-output-to.


how to attach our own video surface to GVRViewSceneObject

We have our own custom exo-library plugin which provides the exo-player instance.
But GVRF allow only SimpleExoPlayer instance for GVRVideoSceneObjectPlayer so we decided to eliminate the GVRVideoSceneObjectPlayer which causes the missing logic to set surface.
We have our own surface which is not possible to attach to GVRVideoSceneObject so i decided to attach to GVRViewSceneObject.
steps i followed:
-> attach our surface view to Framelayout and then call
mPlayerScene = new GVRViewSceneObject(mGVRContext, playerlayout, PLAYER_WIDTH, PLAYER_HEIGHT);
but i can listen only audio without any video so please suggest how to achieve this behavior.
I did not find any api to set material type OESHorizontalStereo.ID for my scene.
A quick suggestion will be appreciated.
Thanks in advance.

@liaxim thanks for quick reply, as u said it's not working even after adding OESHorizontalStereo.ID to GVRViewSceneObject. I will check for alternate solution.

Hi @spakanati123,
GVRViewSceneObject will not work for this issue.
I am not sure whether the following code is what you need,
but I guess you could try it :)
final GVRTexture texture = new GVRExternalTexture(mGVRContext);
final GVRMaterial material = new GVRMaterial(mGVRContext, GVRShaderType.OES.ID);
final SurfaceTexture surfaceTexture = new SurfaceTexture(texture.getId());
final Surface  surface = new Surface(surfaceTexture);

surfaceTexture.setDefaultBufferSize(video.getWidth(), video.getHeight());

SceneObject videoObject = new SceneObject(gvrContext, width, height);

 material.setMainTexture(texture);
 videoObject.getRenderData().setMaterial(material);

Set surface instance to your player.

i fixed this issue by creating a wrapper class to connect to our exo-player plugin.
Thanks for your inputs @ragner , @liaxim


Question: PSD Thumbnails

Describe the bug
Not a bug, I guess. Maybe a bug in my code. More of a question.
I'm writing a simple function that takes a PNG and, after some transformations, saves it to PSD. Using Pillow for the transformations.
The PSDs are coming out without thumbnails which is causing blank previews in Explorer, XnViewMP. InDesign and so on.
How can I embed a thumbnail to the file?
To Reproduce
The function:
def savePSD(pil_img, psd_out):
    psd_file = PSDImage.new(
        mode="RGBA",
        size=pil_img.size
    )

    layer = PSDLayer.PixelLayer.frompil(
        pil_im=pil_img,
        psd_file=psd_file,
        layer_name="Layer 1"
    )

    psd_file.append(layer=layer)
    psd_file.save(psd_out)

Expected behavior
PSD file with a thumbnail.
File and screenshots
InDesign: https://imgur.com/AK3NPcA
Explorer: https://imgur.com/i6PvBBl
Environment

Python 3.12.7
psd-tools==1.10.0
pillow==10.4.0

Additional context
Add any other context about the problem here.

A thumbnail is saved in the Image Resources section of the PSD file, which is not yet supported when creating a file from scratch.


+ operator on a depset is forbidden

With pandoc rule v0.2, I encounter:
ERROR: in _pandoc rule:

File "/private/var/tmp/_bazel_regisd/06f542c1a539b08f2925af301e3c7ab9/external/bazel_pandoc/pandoc.bzl", line 3, in _pandoc_impl
ctx.actions.run(<5 more arguments>)
File "/private/var/tmp/_bazel_regisd/06f542c1a539b08f2925af301e3c7ab9/external/bazel_pandoc/pandoc.bzl", line 15, in ctx.actions.run
toolchain.pandoc.files + ctx.files.src
+ operator on a depset is forbidden. See https://docs.bazel.build/versions/master/skylark/depsets.html for recommendations. Use --incompatible_depset_union=false to temporarily disable this check.

This is new with Bazel release 1.1.0

Resolved in #7


Feature Request: Filter Option for Resizing.

Hey there! Great bit of work you've got here!
I'm currently using your plugin to downscale some PNGs for retina / non-retina support. Our artist took a great deal of care and time ensuring there was no aliasing of our PNGs for optimal compression, however, when downscaling, we run into a minor issue where Aliasing is applied.
Original:

Downscaled:

As there is no Filter Option as part of the grunt-image-resize task, there is no easy way to pass this into GraphicsMagick, however, it seems to be a fairly trivial task to add it.
On line 89 of image_resize.js:
var resizer = gm(filepath)
 .resize(imOptions.width, imOptions.height);

If I hack in:
var resizer = gm(filepath)
 .filter('Point')
 .resize(imOptions.width, imOptions.height);

I receive a Downscaled image with my specific use case solved for! Hooray!

Obviously, this is not the final solution for the code, I would propose we allow a new Option to be passed via Grunt, which is "filter" (Or "interpolation", I don't really care what we name it). Filter would default to what GraphicsMagick defaults to if not passed via Grunt.
Available options would include:
Point | Box | Triangle | Hermite | Hanning | Hamming | Blackman | Gaussian | Quadratic | Cubic | Catrom | Mitchell | Lanczos | Bessel | Sinc
From GraphicsMagick documentation, here: http://www.graphicsmagick.org/GraphicsMagick.html#details-filter
As most people want clean, smooth, aliased resizes which Grunt Image Resizes supports, this is definitely a unique use case, but it would be great to see it added!

Hi @normanrz!
Sorry to be off the loop, this was actually a quick hackjob with some poor documentation that worked perfectly for my use-case.
I'm glad that @dnarushevich jumped in to provide an alternate use case, and the GM method. In my use-case, I run this rarely to optimize external_assets before dropping them onto S3 with a week cache at least, so "faster" isn't required.
I can't promise I'll get something done anytime soon (I keep lazily dropping in the two lines I need when updates come out, sorry), but @dnarushevich / @normanrz , would you prefer something that allows unique resizer logic, and/or a series of options?
I would imagine you can pass either a function in the grunt command for the actual resize function, to satisfy Denis's use case, or options to filter resize. I could possibly use the function to ensure the filtering, without options to filter resize.


Basic smoke testing tool

Initial smoke testing tool
Add log output to smoke tester
Add flash testing to smoke tester
Move tests to separate directory
smoke_tester: Add option to test single board
Remove file added by mistake
Add test for stepping / SW breakpoints to smoke tester
Updated handling of DownloadOptions

This is very promising!!!


Segmentation fault in release compile

Issue
Starting a cursive application using the pancurses backend when compiled with cargo build --release causes a segmentation fault. The program starts, shows a window, but then crashes with a segmentation fault.
Setup
cargo 0.13.0-nightly (806e3c3 2016-10-26)
rustc 1.14.0-nightly (3f4408347 2016-10-27)

[dependencies.cursive]
version = "0.3"
default-features = false
features = ["pancurses"]

I don't have a code snippet to show this behavior, but I hope to make one during the weekend.

Interesting.
Does it work in debug mode ?
Does the examples work ? (From the cursive repository, cargo run --release --example key_codes --no-default-features --features pancurses)

It works in debug mode. I don't know about the examples. I'll try them either tomorrow or on Saturday.

gdb might also be of some help:
$ gdb target/release/your_binary
(...)
(gdb) run
(...)
(gdb) bt

Might be related to #88 and https://github.com/jeaye/ncurses-rs/issues/119

Is it fixed in latest version?

It is fixed in the latest version, thanks!


Not able to fetch profile image on recent chat list

Hello @sponzillo
Hope you are doing well
I am not able to fetch the image for the profile cell on the recent chat. I am using swift code to authenticate the user and passing the details of user profile like first name, last name, user id while creating a contact before opening the conversation screen.
Can you guide us if we miss something to configure for chat21 SDK?
Help in advance appreciated. Thanks

Facing same issue.

Can you give us a screenshot of the View facing the issue?
A.

Thanks in advance.


CAMEL-19285: prevent Kafka client from entering an endless loop

When an authentication error is thrown by Kafka, this could cause an endless loop in the client. Potentially affecting the Kafka broker due to an excessive connection retries in a short period.
This prevents authentication related errors to cause this.

Marked this one as a draft to wait for the 3.21 vote results.

Marked this one as a draft to wait for the 3.21 vote results.

3.21.0 vote is complete, let's merge.


feat(close-scroll-strategy): add scroll threshold option

Adds the threshold option to the CloseScrollStrategy that allows for the consumer to specify the amount of pixels that the user has to scroll before the overlay is closed.

Reworked based on our discussion @jelbourn, can you take another look?


Revert "Update android build tools."

This reverts commit d298017b5c23cca277aae020be6da3746d93c344.
fixes #633

This change is

@bors-servo: r+

:pushpin: Commit e38a6fd has been approved by jdm

:hourglass: Testing commit e38a6fd9f88906baedd35d4dd947d9fb3e7f7188 with merge 923fd885f75068fdeb1972e75a89cc4e6983f989...

:sunny: Test successful - status-travis
Approved by: jdm
Pushing 923fd885f75068fdeb1972e75a89cc4e6983f989 to master...


Can Nativescript get rid of moduleId (deprecated)

moduleId: module.id
...has be deprecated in Angular 4.
https://angular.io/guide/change-log
...can Nativescript be updated accordingly as it seems to be causing problems...
https://discourse.nativescript.org/t/relative-vs-absolute-template-paths-when-using-webpack-build/1516

How did you get rid of module.id?  I have Angular 7.1.4 and "nativescript-angular": "~7.1.0".

@DeepakArora76 are you making a Webpack build? Currently removing moduleId would work when passing --bundle (using Webpack)
tns run android --bundle

Here is a sample application that works without moduleId (but with Webpack builds)

Yeah - it is a Webpack based build, and the command line option --bundle solves the problem. Thank you for the reply.


FlexPanel enhancements (grow, shrink, basis, fixes)

Several enhancements to FlexPanel:

Fixed implementation of justify-content and align-content to follow the correct spacing calculation like in HTML. The original implementation was off in case of non-zero row and column gaps. Frankly, all variations looks kinda messy, but one is at least the standardized mess.

Fixed implementation of align-content in case of items overflowing out of available panel size. In HTML, it falls back to three basic cases.

Implemented flex-shrink and flex-grow. It's a very basic implementation which performs all calculations in the arrange stage. It covers the basic case of stretching items in wrap and no-wrap modes, as well as shrinking in no-wrap mode.

Proper flexbox implementation with fully functional flex-grow and flex-shrink would require support for flex-basis, much more sophisticated measure stage to handle min/max width/height constraints, resizing across main axis affecting cross axis and stuff like this. I don't understand HTML's and Avalonia's layout systems enough to properly match everything, so only basic implementation is included.
Maybe I'll implement flex-basis later. Using it as percent/absolute main axis constraint at the measure stage sounds potentially useful (?).
If anybody is curious, here's the official specification of the flex layout algorithm.
P.S. Is there any reason to use RowSpacing and ColumnSpacing property names instead of RowGap and ColumnGap? This seems to be the only mismatch with HTML flexbox naming. [EDIT] I see, there's Spacing in StackPanel.

@dotnet-policy-service agree

flex-basis supports the values min-content, max-content, fit-content in the standard which aren't supported (yet?). Would min-content and max-content correspond to Measure(Size.Empty) and Measure(Size.Infinity)? Would it make any sense?

It looks like min-content is similar to Left/Right/Center horizontal alignment, when fit-content is a Stretch alignment in XAML. max-content looks like Measure(Size.Infinity) for sure. Not sure if min-content should be Measure(Size.Empty) though, needs to be tested.

MinWidth, MaxWidth, MinHeight, MaxHeight constraints don't function like main and cross axis constraints in the Flexbox standard and don't affect arrangement of other items in a flex line

Yes, Min/Max constraints are used on the visual element directly, and parent Panel can't really redefine this behavior. It only can read this property and add side effects.

In general, I feel like unit tests would be a great addition to this PR as well, as flex panel lacks them, but let's merge it as it is.

Browsers contain tons of flexbox tests. This seems to be the source (of some of them?):
https://test.csswg.org/suites/css-flexbox-1_dev/nightly-unstable/ (BSD)
https://test.csswg.org/suites/css-flexbox-1_dev/nightly-unstable/xhtml1/reftest-toc.xht
The main problem is that tests are in the form of "HTML with flexbox in CSS" and "HTML without flexbox in CSS" as a reference, with assumptions on fonts and various metrics, if I understand correctly.
I think it should be possible to convert the relevant subset of these tests to C#...


Update DBConvert products info

I've updated the information about our products.
Thank you

Great thanks, merged.


Enhancement: Token Traits

It might be nice to have traits assigned to the tokens. There's already a trait for the monster "tokens", but it would be nice to have a trait for generic people tokens, named people tokens, furniture/covering, etc. It would be up to us to define the traits, but I thought it might be useful especially as the game grows.

Please add what you want and I will include.
Here are the token files:
https://github.com/NPBruce/valkyrie/blob/development/unity/Assets/StreamingAssets/content/MoM/base/tokens.ini
https://github.com/NPBruce/valkyrie/blob/development/unity/Assets/StreamingAssets/content/MoM/btt/tokens.ini
https://github.com/NPBruce/valkyrie/blob/development/unity/Assets/StreamingAssets/content/MoM/soa/tokens.ini


Change the color of dateString

Hi,
On my terminal(iTerm2 MacOS), i'm using a gray bg and the dateString is displayed in black

Is it possible to change the dateString color to blue/white/gray or add an option to choose it ?
Something like this:
new FriendlyErrorsPlugin({
    output: {
        dateString: {color: 'blue'}
    }
});

On node_modules/friendly-errors-webpack-plugin/src/output.js:54, i found this:
// Line 54:
const dateString = chalk.grey(date.toLocaleTimeString());

On github chalk depo documentation, there is no grey color !
I tried chalk.gray(date.toLocaleTimeString()) -> doesn't work !
So i change it to chalk.blue(date.toLocaleTimeString()) -> it works

Thanks

Hi @flashios09,
Grey seems to work fine on my color scheme, do you think we should change it?
Providing options to override the default colors seems like a reasonable solution if we can't find a good color scheme that works for everyone.
What do you think?

@geowarin unfortunately the grey doesn't work for me :(
I'm for adding an option to specify the dateString color and i will try to create a PR tonight.
I have another point to discuss, i always need to know when the last time i compiled(i mean the last save) and took time, if we have many eslint warnings, we have to scroll up to see the dateString and we don't have the took info, what about adding it at the end of the output.
Something like this:
    compiler.plugin('done', stats => {
      this.clearConsole();

      const hasErrors = stats.hasErrors();
      const hasWarnings = stats.hasWarnings();
      const date = new Date();
      const lastCompile = chalk.magenta(date.toLocaleDateString()) + " at " + chalk.blue(date.toLocaleTimeString());
      const time = getCompileTime(stats) / 1000;
      const took = (time < 5) ? chalk.green(time + "s") : chalk.red(time + "s");

      if (!hasErrors && !hasWarnings) {
        this.displaySuccess(stats);
        return;
      }

      if (hasErrors) {
        this.displayErrors(extractErrorsFromStats(stats, 'errors'), 'error');
        return;
      }

      if (hasWarnings) {
        this.displayErrors(extractErrorsFromStats(stats, 'warnings'), 'warning');
      }

      output.log();
      output.log("Last compile: " + lastCompile);
      output.log("Took: " + took);
      output.log();
    });

Yup I would love that change. :+1:
It also relates to #26.
If you could have a go a it that would be wonderful!


add proxy to versioned websites

Proxy istio.io/v-${RELEASE} to istiodocs-v01.firebaseapp.com/v-${RELEASE}.
This is generalized to support future release versions and assumes a
consistent v-{major}.{minor} naming scheme.
Fixes frontend proxying for https://github.com/istio/istio.github.io/issues/379

Thanks for the comments. Updated per your suggestions - PTAL.
I've tested this in the canary namespace. I'll roll it out to istio.io tomorrow after the PR is approved.


How to add watermark for Superset?

Recently, the unit began to use Superset, but the leaders felt that these charts did not have their own watermark and needed secondary development. Having seen enough echarts before, they could easily integrate the watermark, but found that Superset was very troublesome.
I wonder if Superset has some simple way to configure it in a file?
I found that the Superset front end USES nvd3 for visualization. I tried to add  directly in < SVG >, but the effect was very bad and terrible.
For Echarts, you only need to obtain CTX and use ctx.fillText(waterMarkText, 0, 0) when the front-end model is built.Can, in fact, or backgroundColor processing, then Superset can also be such a simple operation? For help

I have dealt with it well and need to add extra code. At present, my way is to add , (control transparency) and  tag in < SVG > for implementation. I don't know whether there is a more appropriate and official way to deal with it. Always feel their own way of dealing with low.
eg:
For css：

我是水印文字哦

...
...

For js：
const defs = svg.append('defs')
.append('pattern')
.attr('id', 'polka-dots')
.attr('x', -20)
.attr('y', -20)
.attr('width', 120)
.attr('height', 120)
.attr('patternUnits', 'userSpaceOnUse');
defs.append('text')
.attr('dy', '1em')
.attr('transform', 'rotate(-40 120,20)')
.style('filter', 'alpha(opacity:20)')
.style('opacity', 0.09)
.style('font-size', '20px')
.style('font-family', '20px Microsoft Yahei')
.text('我是水印文字哦')
svg.append('rect')
.attr('x', '0')
.attr('y', '0')
.attr('width', '100%')
.attr('height', '100%')
.style('fill', 'url(#polka-dots)');
PS: At present, the code is not functional processing, all fixed values.

Which file is added to this css and js?

Which file is added to this css and js?

Css is an intuitive display of the interface, you do not need to add it in the file, you really need to add js, add it in NVD3xxx.js, Superset actually contains two built-in charts (nvd3 and sibling folders)

get it,thanks a lot.


Enhanced Tag - Document Relation Function

We would like to (1) relate multiple documents and have the ability to add a tag to indicate they are part of the same group and (2) have a more automatic way to relate the documents.
So far, the process of relating nine documents has involved quite a few identical "add relation" actions. For the ninth document, I had to add eight separate relations. These nine docs are all part of the same grouping (a plan).
We would like to be able to create a tag for this plan, and then assign this tag to each relevant record.

In 2.2.9, models should be used to group documents for various purposes. See docs.


Possible encoder bugfix

Possible fix for https://github.com/jamesmunns/cobs.rs/issues/19 .
I do not have proficient understanding of the COBS protocol yet so it would be good if this is thoroughly reviewed.
I compared the Rust implementation with the C implementation from wikipedia and I saw that there is a similar process of an encode pointer double increment. However, this is only done if the algorithm is not finished yet, more explicitely when length is not 0.
In Rust, this is a bit more complicated. I figured that the state machine has to remember when there might be the possibility that the encoding process is done and the destination index does not need to be incremented anymore. I did this with a boolean flag for the encoder struct. If push is called again, then the index needs to be incremented, and this is done before it starts iterating over the data to be pushed.
I ran all the existing tests again and also added a new one for the issue case.

Any updates on this?

Any chance this could get checked and possibly merged anytime soon? I'd love to use the upstream again :)


setup_requires + distutils_extension

I have the following setup to attempt to use an AOT-compiled kernel in a python package, where the package doesn't require numba in the environment.
Directory structure
setup.py
simple_function.py
package_name/
    __init__.py

setup.py
from setuptools import setup, find_packages

# Lazy trick to make sure numba gets imported _after_ it's installed from setup_requires
class LazyExtensions(list):
    def __init__(self):
        super(LazyExtensions, self).__init__()
        self.__extensions = None

    @property
    def _extensions(self):
        if self.__extensions is None:
            from simple_function import cc
            self.__extensions = [cc.distutils_extension()]
        return self.__extensions

    def __len__(self):
        return len(self._extensions)

    def __iter__(self):
        yield from self._extensions

setup(
    name='package-name',
    version='0.0.1',
    packages=find_packages(),
    setup_requires=['numpy', 'numba'],
    ext_package='package_name',
    ext_modules=LazyExtensions(),
)

simple_function.py
from numba.pycc import CC

cc = CC('compiled')

@cc.export('add', 'f8(f8, f8)')
def add(x, y):
    return x + y

Installing this in an empty conda environment:
conda create -n test_env python pip
conda activate test_env

pip install -e .
# Correctly creates package_name/compiled.<env>.so, but:

python -c 'from package_name.compiled import add'

Results in the following error:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: dlopen(<my path>/package_name/compiled.cpython-36m-darwin.so, 2): Symbol not found: _nrt_atomic_add
  Referenced from: <my path>/package_name/compiled.cpython-36m-darwin.so
  Expected in: flat namespace
 in <my path>/package_name/compiled.cpython-36m-darwin.so

I'm not sure if the issue is with my "lazy eval" trick, or using numba in setup_requires in general. If I assume numba is already installed and import cc immediately, everything works as expected. However, I'd like to avoid making that assumption.
In case it's helpful,
conda -V
> conda 4.4.8

Thanks for the report. I think this an issue with compilation opposed to anything particular about the set up.

@NathanDeMaria  I'm just curious, did you solve your problem? I'm using the setup.py as in the tutorial. However, it's silly, because it demands to have numba already installed. Your trick LazyExtensions seems nice, but not sure if you were able to make it work. Thanks in advance.

No, I ended up giving up and just raising an error that says "must install numba before installing this package"
I think the suggestion above is right, and that the problem has something to do with where/how numba is installed as a result of setup_requires differing from if you just install it with pip install numba

Yeah, seems about right. However, I think that's one of the things that'd be cool to have in the tutorial; on how to create a proper package from numba with for example the setup_requires documented. Not sure myself how to do it though :disappointed: .

In the pyproject.toml file you can include numba in requires of build-system:
[build-system]
requires = ["setuptools>=42.0", "wheel", "numba>=0.55"]
build-backend = "setuptools.build_meta"

That way numba will be installed before your package will be installed allowing for AOT compilation.


Wrong shortcut descriptions?

The shortcut descriptions seems to be wrong - Ctrl+Alt+F5 will do "Rapid Application Publish without debugging" and Ctrl+F5 will do "Rapid Application Publish with debugging"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7efad2ff-bdd1-ca20-fc9d-334e44755402
Version Independent ID: 533bc507-d257-32c6-aad5-3b6cc08d6230
Content: Working with Rapid Application Development - Business Central
Content Source: dev-itpro/developer/devenv-rad-publishing.md
Service: dynamics365-business-central
Product: dynamics-businesscentral
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for pointing this out - the fix will be in the next refresh of the docs. Thanks!


Assignment.sh

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
adding and removing code
What did you learn from the changes you have made?
what these commands do
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
struggle to remember codes
How were these changes tested?
by checking commands
A reference to a related issue in your repository (if applicable)
none
Checklist

[x] I can confirm that my changes are working as intended
confirm

Hello Moniz,
I really appreciate your support.
Regards,
Gulrukh
Sent from my iPhone
On Dec 3, 2024, at 9:43 PM, mchan @.***> wrote:

@monzchan approved this pull request.
Your effort is highly appreciated!
—
Reply to this email directly, view it on GitHubhttps://github.com/Mrs-Aqeel/shell/pull/2#pullrequestreview-2477173613, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BM3IO4RV6VDV75RRU63KLSL2DZT4VAVCNFSM6AAAAABS7C3WDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZXGE3TGNRRGM.
You are receiving this because you authored the thread.Message ID: @.***>


I don't found swagger-play2 1.3.13 in maven repositories

Hello,
All is in the title :)
I need help
Thanks,

I published swagger-play2 1.3.13 on local but there are an error ;
play.api.UnexpectedException: Unexpected exception[ConfigurationException: Guice configuration errors:

1) Could not find a suitable constructor in play.modules.swagger.SwaggerPlugin. Classes must have either one (and only one) constructor annotated with @Inject or a zero-argument constructor that is not private.
at play.modules.swagger.SwaggerPlugin.class(SwaggerPlugin.scala:26)
while locating play.modules.swagger.SwaggerPlugin

1.3.13 was never finalized nor released.

Thanks for response.
Compatibility with play 2.4 is she expected soon ?

I'm afraid I don't know. However, some users have ported supported for 2.4, please follow https://github.com/swagger-api/swagger-core/issues/1144.

+1

+1

@kbenhdech et al. several changes went in last week for Play 2.4 support. Can you test again please?
@fehguy @webron do you think we could publish 1.3.13 given the recent changes that were made? Thanks again for reviewing and merging

Hi @benmccann and all, I just pushed the 1.3.13 artifacts from swagger-core.

Hi guys, can't find 1.3.13 in maven, any update ?

Is there any update?

Hi @sundriver @bulllog please consider 1.5.0-SNAPSHOT which is in sonatype oss.  It supports the most recent swagger specification (2.0) and is supported.

Swagger 1.5.0 Has an Issues with the basepath setting.
It double sets the path when set in the conf file.
Can 1.3.13 be pushed to maven repo?

what do you mean it double-sets it?  can you elaborate?


Environment variables are not additive

If I set an environment variable that depends upon another variable, it is not dereferenced correctly
Example:
"environment": [
{"name":"VAR1",
"value": "${workspaceFolder}"},
{"name":"VAR2",
"value": "${VAR1}"},
The result is:                ],
VAR1=/home/jack/dev/
VAR2=${VAR1}
Expected result is:
VAR1=/home/jack/dev/
VAR2=/home/jack/dev/
Since the built-in variable ${workspaceFolder} is being dereferenced (and any other number of built-ins too) there's no reason the same parser can't look for all other extant environment variables too.
You may run into an infinite loop, so it's important that a single pass is performed new variable being set, scanning for existing known variables only once.  Siince the syntax is already defined as  "${VARIABLE}" this should be trivial.

@Smit-tay The parsing needs to be done in VS Code. This parsing isn't done in MIEngine. Please file this issue on the VS Code C++ Extension github page.


DRAFT: Updating the library with docs, CI/CD, Improve syntax and unit test folder

DRAFT: Updating the library with docs, CI/CD, Improve syntax and unit test folder

Closing due to inactivity.


Adaptations for C++11 capable generator

Description

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):
Checklist:

[ ] A test for the new functionality was added.
[ ] All tests run without failure.
[ ] The new code complies with the TiGL style guide.
[ ] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

@bernhardmgruber Thanks for the PR. Could you please fix the build issues on the linux machines?
/home/travis/build/DLR-SC/tigl/src/generated/TixiHelper.h: In lambda function:
/home/travis/build/DLR-SC/tigl/src/generated/TixiHelper.h:108:75: error: parameter packs not expanded with ‘...’:
             auto child = tigl::make_unique<T>(std::forward<ChildCtorArgs>(args)...);

The build issue is a gcc bug, which got resolved in version 4.9.0. The build slave however runs gcc 4.8.4. I will try to find an easy workaround.

Thank you for the commits! Is this still WIP as the title suggests?
As you now use hard-coded std::unique_ptr, we should remove our own implementation of unique ptr just use the typedef tigl::unique_ptr = std::unique_ptr. If you want, I can do this.

I mainly wait for a reaction on the PR to the generator here: https://github.com/RISCSoftware/cpacs_tigl_gen/pull/25
I thought about hard coding std::unique_ptr, because by having a custom scoped pointer type, we could e.g. provide correct const-propagation (which std::unique_ptr does not have). I.e. using std::unique_ptr allows to retrieve a mutable CCPACSWingSegment from a const CCPACSWing, which might be unexpected. So to be absolutely correct, we should store subelements as std::propagate_const<std::unique_ptr (see https://en.cppreference.com/w/cpp/experimental/propagate_const) or, as I initially stated, create our own smart pointer, which correctly propagages const. However, std::propagate_const might not make it into C++20 and even if, I guess you do not want to have it for the next decade ;) And creating our own smart pointer just seems like an overkill.
So that's basically why I chose std::unique_ptr. I kept the alias tigl::unique_ptr to keep existing code working, but I added a deprecated attribute to warn its users.

We can expect to have at least 3.9 on the CI systems. I work on cmake modernization right now which also required at least some cmake 3 version.

I guess we are good ;)

Great! Thank you!


Shader warm up

This patch adds a default shader warm up process which moves shader compilation from the animation time to the startup time. This also provides an extension for runApp so developers can customize the warm up process.
This should reduce our worst_frame_rasterizer_time_millis from ~100ms to ~20-30ms for both flutter_gallery and complex_layout benchmarks. Besides, this should also have a significant improvement on 90th and 99th percentile time (50%-100% speedup in some cases, but I haven't tested them thoroughly; I'll let our device lab collect the data afterwards).
The tradeoff the is the startup time (time to first frame). Our flutter run --profile --trace-startup seems to be a little noisy and I see about 100ms-200ms increase in that measurement for complex_layout and flutter_gallery. Note that this only happens on the first run after install or data wipe. Later the Skia persistent cache will remove the overhead.
This also adds a cubic_bezier benchmark to test the custom shader warm up process.
This should fix https://github.com/flutter/flutter/issues/813 (either by defaultShaderWarmUp, or a customShaderWarmUp).

By how much does this regress the time to first frame benchmarks?

@chinmaygarde : time to first frame increases about 100ms-200ms for complex_layout and flutter_gallery. Please see my updated PR description.

@liyuqian Is this ready to land?

@goderbauer I guess so if the review from @jonahwilliams is a green light on the Dart side.
BTW, as I'm digging emails, I see that we're in a tree freeze due to P0 Google3/Fuchsia roll failure. Should I wait the tree to be reopened before merging this?

per the addition to runApp, I do not have a strong opinion on the API but others might

CC @Hixie for the review of API change to runApp.

Doing this on startup seems weird, since we're about to render the whole scene anyway. Don't we actually want to do this after startup?

Regarding where to call the warm-up: I guess the documentation in this patch doesn't really tell me enough to really evaluate things enough to review the patch.
I think the documentation should cover all of the following at a minimum, probably many more things that I'll think about once I know the answers to these questions. :-)

Does the warm-up happen synchronously relative to rendering frames, or will the frames keep rendering while the warm-up happens in the background? If it's asynchronous, when does it happen? Does it use CPU/GPU that slows down the frame rendering, does it happen while the threads are idle, something else?
Why does the warm-up have to happen every time the framework is started, instead of (say) when the engine is compiled, or when the app is compiled, or when the app is first run on the device?
How do you know what to write in a shader warm-up function?
What happens if you don't warm up the shaders? e.g. if the runApp triggers an animation, will that animation already force all the relevant shaders to be warmed up, negating the need for a separate warm-up?
Why 1000x1000? Why not 512x512 or 10x10 or 4096x4096? Or 5x1000? How do you know what size to make it?
Do things vary from device to device?
Some of the things we warm up seem really obvious and simple, like "stroke shaders". Why is this something that should be done from Dart code? Won't it affect any framework that uses dart:ui? Should Skia not do this itself?
We warm up text shaders. Are those font-specific? We use the string "Hello, World". Why not the empty string, or a space character, or "مرحبا"?
Does any of this matter with the Web backend?

Regarding where to call the warm-up: I guess the documentation in this patch doesn't really tell me enough to really evaluate things enough to review the patch.
I think the documentation should cover all of the following at a minimum, probably many more things that I'll think about once I know the answers to these questions. :-)

Does the warm-up happen synchronously relative to rendering frames, or will the frames keep rendering while the warm-up happens in the background? If it's asynchronous, when does it happen? Does it use CPU/GPU that slows down the frame rendering, does it happen while the threads are idle, something else?

Currently the warm-up happen synchronously on the GPU thread which means the rendering of the first frame on the GPU thread will be postponed until the warm-up is finished. I’ve added this to the comment.

Why does the warm-up have to happen every time the framework is started, instead of (say) when the engine is compiled, or when the app is compiled, or when the app is first run on the device?

The warm-up depends on the device’s GPU and driver so it can’t be done during compilation. The warm-up indeed only compiles the shader during the first run on the device. The current approach will cause a small overhead of drawing (without shader compilations) in subsequent runs. See the doc in https://github.com/flutter/flutter/pull/27660/files#diff-e158ae61bb7a8dd81f710e8f59aa23caR764.

How do you know what to write in a shader warm-up function?

I’ve added the following to the doc.
The draw operations being warmed up here are decided according to Flutter engineers' observation and experience based on the apps and the performance issues seen so far.
To decide which draw operations to be added to your custom warm up process, try capture an skp using flutter screenshot --observatory- port=<port> --type=skia and analyze it with https://debugger.skia.org. Alternatively, one may run the app with flutter run --trace-skia and then examine the GPU thread in the observatory timeline to see which Skia draw operations are commonly used, and which shader compilations are causing janks.

What happens if you don't warm up the shaders? e.g. if the runApp triggers an animation, will that animation already force all the relevant shaders to be warmed up, negating the need for a separate warm-up?

Suppose that there’s another animation later that’s very different from the start up animation. Without the shader warm-up of draw operations for the later animation, it will jank. With the warm-up, there’s a startup latency before the start up animation, and there will be no later janks.

Why 1000x1000? Why not 512x512 or 10x10 or 4096x4096? Or 5x1000? How do you know what size to make it?

Added the following to the doc
The size of [width]=[height]=1000 here are picked arbitrarily. The only goal is to have them not too far away from the actual resolution (very few mobile devices seem to have a resolution that is 10x larger or 10x smaller than 1000x1000). The size should have little effect on the shader warm-up. A custom shader warm up can pick another arbitrary number that's close to the targeted devices.

Do things vary from device to device?
Yes for the compiled shaders. Added the following to the doc:

This warm up needs to be run on each individual device because the shader compilation depends on the specific GPU hardware and driver a device has. It can't be pre-computed during the Flutter engine compilation as the engine is device agnostic.

Some of the things we warm up seem really obvious and simple, like "stroke shaders". Why is this something that should be done from Dart code? Won't it affect any framework that uses dart:ui? Should Skia not do this itself?

I guess the key question here is who has the information about when to initiate the warm-up process. Both dart:ui and Skia probably don’t know when is a good time to do a warm-up. The framework has such information (it knows when the app is first started). In the end, the warm-up is just calling some Skia draw functions directly. It’s probably not too different from Skia providing a warm-up function API which is then called by the framework at the right time.

We warm up text shaders. Are those font-specific? We use the string "Hello, World". Why not the empty string, or a space character, or "مرحبا"?

I didn’t know that we already warmed up text shaders. In that case, I can just delete the “Hello, World”.

Does any of this matter with the Web backend?

It probably depends on how Flutter for Web is implemented and how the web browser (mostly Chromium?) calls Skia. I’ll ask yegor and the Skia team.

cc @goderbauer

This patch adds a default shader warm up process which moves shader compilation from the animation time to the startup time. This also provides an extension for runApp so developers can customize the warm up process.
This should reduce our worst_frame_rasterizer_time_millis from ~100ms to ~20-30ms for both flutter_gallery and complex_layout benchmarks. Besides, this should also have a significant improvement on 90th and 99th percentile time (50%-100% speedup in some cases, but I haven't tested them thoroughly; I'll let our device lab collect the data afterwards).
The tradeoff the is the startup time (time to first frame). Our flutter run --profile --trace-startup seems to be a little noisy and I see about 100ms-200ms increase in that measurement for complex_layout and flutter_gallery. Note that this only happens on the first run after install or data wipe. Later the Skia persistent cache will remove the overhead.
This also adds a cubic_bezier benchmark to test the custom shader warm up process.
This should fix https://github.com/flutter/flutter/issues/813 (either by defaultShaderWarmUp, or a customShaderWarmUp).

I saw some back and forth with this PR in master, is now the final version merged?
Asking because I'm running the gallery demo from master on my iPhone and it's still janky the first time. Up to date, with flutter run --release.

I assume that it's still janky when you reopen the app and run the animation for the first time? If so, I guess that it's caused by something else. Can you please run the gallery demo with flutter run --profile --trace-skia, save the trace from observatory timeline, and upload it here so we can take a deeper look?

The same happens after closing the app (where closing means really closing, not only sending to the background).
Attached the trace. This is of a new installation, where I opened "Studies". Then for each of the 4 items inside, opened it and pressed back. There was jank in all of them (it skips a few frames, such that the push animation almost jumps to its finished state, in some more than the others).
dart-timeline-2019-2-19.json.zip

I can confirm that jittering on first startup still exists on iOS (just create any type of app with a list with 30 items with listview.builder and scroll it when you launch the app).

I recommend that anyone running into slowness on startup file a bug with a small repro test case. There are probably many unrelated causes. This PR was to solve #813 which was specifically about the slowness in the Gallery.

@Hixie My comment was about the gallery (not sure if you're addressing me as well).

I think Hixie's comment is only for @msw333 . For that list with 30 items issue, it would helpful if @msw333 could create a new issue, attach the trace and a single-file Flutter app that can allow us to reproduce the issue.
For @i-schuetz 's issue, yes it's currently still expected to have a little jank right after the new installation. Your trace is consistent with my local experiment with a new installation. But once I close the app and reopen it on my iPhone6S, the jank would disappear if I open the same item. Can you please confirm that it's also the case in your iPhone6? If not, can you please attach the trace of the second first-run after the installation?

We care about first-run performance too, very much in fact. :-)

Ok ;-). Hope that helps. Issue is observable in every flutter app I was using. iPhone X, 12.1.4 (iOS).
Issue is more observable when using a list which is a little more complex.
Videos don't give it justice, but show the issue:
https://www.youtube.com/watch?v=oHKNKi08qw8
https://www.youtube.com/watch?v=1mdM_Uv574w
Code to reproduce (just use as main.dart). Again, I can reproduce it with any flutter app on iOS. Especially observable within lists:
https://gist.github.com/msw333/dd0a06fb1fe8b4eb4ae627542202d43a

Thanks @msw333 ! That's very helpful. Let's further discuss this issue on https://github.com/flutter/flutter/issues/28113

Attached the trace from opening the 4 items after closing the app.
Also attached videos, one for directly after launching and another for after closing. As @msw333 says they don't do it justice, but still clearly noticeable.
As mentioned before after closing is better, but there's still jank.
trace_after_close.zip
videos.zip


Espressif: Detected overlap at address: 0x1000 for file: .../bootloader.bin

I get this error with devkitC and the wrover. I selected two partitions.
Flashing binaries to serial port /dev/cu.SLAB_USBtoUART (app at offset 0x2)...
usage: esptool write_flash [-h] [--flash_freq {keep,40m,26m,20m,80m}]
                           [--flash_mode {keep,qio,qout,dio,dout}]
                           [--flash_size FLASH_SIZE]
                           [--spi-connection SPI_CONNECTION] [--no-progress]
                           [--verify] [--compress | --no-compress]
                           <address> <filename> [<address> <filename> ...]
esptool write_flash: error: argument <address> <filename>: Detected overlap at address: 0x1000 for file: .../bootloader.bin
make: *** [flash] Error 2

How can I reset my selections?

Hello,
I think you have to create a partition and flash it over the one that is causing you trouble.
The process to create and flash partitions is described here: http://esp-idf.readthedocs.io/en/latest/api-guides/partition-tables.html#.
Hugues

Awesome. Thanks!


Deployment directories should be at a per source level.

Description
Separate Deployment directories should be created for each source that requires deployment item
Steps to reproduce

Create two C# UnitTest Projects.
Add Deployment Item in only one of the projects and not in second one.
Build the solution.
Put breakpoints in both the tests.
Select both the tests in Test Explorer and do debug selected tests.

Expected behavior
Only one test dll having [DeploymentItem] attribute should have been copied to Deployment Directories(i.e. UnitTestProject76) and other one should have run from UnitTestProject1/bin/debug and should not get copied to Deployment Directory.
Actual behavior
Both the test dlls gets copied in the Deployment Directories that are created.
This actually changes the behavior of tests when run on their own versus when run with other test assemblies that have deployment items causing confusion.

Because this bug is open for years now and based on similar fix we did for v3, I don't know if we should fix this or not because people are now relying on this behavior.

Moving forward by closing this ticket. Let's see if we get some requests in the future.


Add line number type hint for motion spans

Hi.
There is no way to identify from HTML if line numbers in Motions are ment to display inline or outline.
In order to provide the full line number functionality in the PDF we need a separation of the line number type provided by html
currently we can only identify that via js using scope.lineNumberMode
I need some further information in HTML.
currently we have stuff like
<span class="on-line-number" data-line-number="1" (.....) >
To parse between inline and outline I need something like
line-number-type="inline" ("outline")

since line numbers for PDF supposedly got some priority, we may shall solve this issue quickly.
Any suggestions?
@emanuelschuetze
@normanjaeckel
@CatoTH

we discussed this a little. Right now we can work without further information, but we honestly should consider providing further information later on, after we cleaned up the code and bought PDF generation in pdfmake upstream

@tsiegleauq We could just modify the markup on the fly in motions/pdf.js before calling convertHTML(). Replacing the line numbers by other tags or adding some data about the line numbering type shouldn't be a big problem.
(Not sure if that is really more elegant, though, as the way line numbers are rendered should be consistent for the whole document and not decided for each node individually.)


[Bug]: Login page, reveal the password not working (changePasswordFieldType)

Description
Login page, reveal the password not working (changePasswordFieldType)
Minimal Reproduction (if possible, example repository)
Login page, try to reveal the password.
Exception or Error
No response
Version
v4.0.0-beta.248

It is fixed in the latest version.


When exiting PIE, the editor gets stuck for a long time

When exiting PIE, the editor will be stuck for a long time. It is a problem with requesting data. We can only add a timeout, but we don’t know if it is correct. Do you think we should add this judgment?
https://www.bilibili.com/video/BV1e7WBeEERR
UnrealAssetAccessor.cpp
return asyncSystem.createFuture<std::shared_ptrCesiumAsync::IAssetRequest>(
[&url, &headers, &userAgent, &cesiumRequestHeaders](const auto& promise) {
FHttpModule& httpModule = FHttpModule::Get();
TSharedRef<IHttpRequest, ESPMode::ThreadSafe> pRequest =
httpModule.CreateRequest();
pRequest->SetURL(UTF8_TO_TCHAR(url.c_str()));
    pRequest->SetTimeout(10);

    for (const auto& header : headers) {
      pRequest->SetHeader(
          UTF8_TO_TCHAR(header.first.c_str()),
          UTF8_TO_TCHAR(header.second.c_str()));
    }

Adding a timeout is ok, but it's probably better to figure out why the server is taking so long to respond to some requests in your case. That's most likely the root of the issue here.


Feature Idea: Add a proxy-server to bypass CORS errors

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)
Docker Image
What is the version of Dejavu that you are using?
Future release
Describe the issue that you are seeing, or the feature request :-), include any screenshots as necessary.
Request: Setting up CORS config on an Elasticsearch cluster is an inconvenience. Popular hosting options like AWS's Elasticsearch Service do not even offer a way to configure one. Current workaround is to ask user to set up a proxy service which is a few hours of work and requires some skill, probably not the best out-of-the-box experience.
What we can do here is add a lightweight server with dejavu itself (Node.js for instance) and make all requests to the Elasticsearch cluster via this server, thus eliminating the CORS issue.
Drawbacks: This would only be applicable to the dev environment and Docker image, but not the hosted version of the app (which is confined to the browser runtime and the CORS restriction).
Wins: Without changing any CORS, dejavu will just work.

Given the update on #108 which should solve the AWS Elasticsearch CORS problem, this is now less appealing. There are still benefits of not having to set up CORS on a local Elasticsearch cluster, but we already provide templates for doing that.


rancher-compose commands without docker-compose file

Right now I am developing a kind of update (rancher services) script reacting on different circumstance in different locations and stumble over the docker-compose file.
Why is it necessary that this file is always given (excluding up command)?
If a service is running all information should be given on rancher/server and I guess rancher-compose command could be executed without having a local copy of the service compose file.
Afterthought: I did not tried it but I can imagine that it would work if I always create a docker-compose file only with the service name in it and then execute the rancher-compose command. Why not get rid of this step?

Second afterthought: Another use case
If someone only created services within rancher/server ui and want to do stuff with services with rancher-compose has to create docker-compose file to do so.
Maybe using a flag for rancher-compose to tell that there is not file only a server service.
rancher-compose --no-file restart service

Appendix to first afterthought. The following work and confirms my suspicions.
cat <<EOF | rancher-compose -f - -p stack restart service
service:
EOF

Closing due to inactivity.


.lock file issue again

The error just needs to get caught somewhere: I created a branch and checked it out from the same dialog, but I had a HEAD.lock file so it didn't work

Unable to duplicate - will reopen if it happens again.


Upgrade to PHP 8.1 types

For the 2.x branch of mini-asset, I would like to narrow the requirements to php 8.1 as this library can benefit from the type system improvements and reduced documentation boilerplate. It also helps to unblock a more completely typed AssetCompress package for CakePHP 5.x

Codecov Report

Merging #70 (fe76390) into 2.x (0542e03) will increase coverage by 0.10%.
The diff coverage is 78.43%.

:exclamation: Current head fe76390 differs from pull request most recent head 1d6fdaa. Consider uploading reports for the commit 1d6fdaa to get more accurate results

@@             Coverage Diff              @@
##                2.x      #70      +/-   ##
============================================
+ Coverage     77.71%   77.82%   +0.10%
+ Complexity      462      458       -4
============================================
  Files            52       52
  Lines          1234     1240       +6
============================================
+ Hits            959      965       +6
  Misses          275      275

Impacted Files
Coverage Δ

src/AssetCompiler.php
0.00% <ø> (ø)

src/Cli/MiniAsset.php
0.00% <0.00%> (ø)

src/Filter/ClosureCompiler.php
0.00% <0.00%> (ø)

src/Filter/CoffeeScript.php
0.00% <0.00%> (ø)

src/Filter/CssCompressor.php
0.00% <0.00%> (ø)

src/Filter/CssMinFilter.php
0.00% <0.00%> (ø)

src/Filter/Hogan.php
0.00% <0.00%> (ø)

src/Filter/JShrinkFilter.php
0.00% <0.00%> (ø)

src/Filter/JSqueezeFilter.php
0.00% <0.00%> (ø)

src/Filter/JsMinFilter.php
0.00% <0.00%> (ø)

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0542e03...1d6fdaa. Read the comment docs.


Remove duplicates from sorted array using 2 pointers

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
Added code of Remove Duplicates from sorted array using 2 pointer in cpp.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#4759

@ankitaggarwal23 all suggested changes are modified . Please Check and Merge PR if all go nice.

Closing this PR as of now. Open the new PR if you want this to be reviewed and add the proper details.


appgw.prohibitedTargets does not work with wildcard hostname

Using a values file with appgw.prohibitedTargets does not work with a wildcard in the hostname.
Typically, the following AzureIngressProhibitedTarget:
apiVersion: "appgw.ingress.k8s.io/v1"
kind: AzureIngressProhibitedTarget
metadata:
  name: prohibit-star.domain.com
spec:
  hostname: "*.domain.com"

cannot be added with the following values:
appgw:
    shared: true
    prohibitedTargets:
    - name: prohibit-star.blueplanner.com
      hostname: "*.domain.com"

The following error is generated:
Error: YAML parse error on ingress-azure/templates/crds.yaml: error converting YAML to JSON: yaml: line 6: did not find expected alphabetic or numeric character

@akshaysngupta any chance to add this to the upcoming release 1.7.3?
Fix is available for a while now in main but unfortunately not in any release. Would be highly appreciated :-)

it has been a while and we now have Release 1.7.4 unfortunately it does still not contain the changes merged to master branch to fix this issue.
So I might understand it wrong, but this issue is marked closed even though no release exists that contains the fix.
Please correct me if I am wrong.
The fix can be seen in here:
https://github.com/Azure/application-gateway-kubernetes-ingress/blob/17967aac7a51828b007bad192bd30e97a974514f/helm/ingress-azure/templates/crds.yaml#L27
hostname: {{ .hostname | quote }}
But in the current release it is still not fixed:
https://github.com/Azure/application-gateway-kubernetes-ingress/blob/3f62f1aa81317bf729b66a10c812bc349ce76b87/helm/ingress-azure/templates/crds.yaml#L27
hostname: {{ .hostname }}
Kindly asking to add the fix to the next release!

@pkerspe unfortunately I don't and I also wish this would be released.


Bug report: Status 500 on content-length >197700

Describe the bug
I get a status 500 every time I try submitting data > 197700.  That's not a specific number, but just my closest frame of reference based on sources used.
To Reproduce
Attempt to bake with the following python function:
def query_cyberchef(source_data):
headers = {
'Content-Type': 'application/json',
}
encodedBytes = base64.urlsafe_b64encode(source_data.encode("utf-8"))
encodedStr = str(encodedBytes, "utf-8")
data = {"input":encodedStr, "recipe":[{ "op": "From Base64","args": ["A-Za-z0-9-_=", 'true'] },{ "op": "Remove whitespace","args": ['true', 'true', 'true', 'true', 'true', 'false'] },{ "op": "CTPH","args": [] }]}
response = requests.post('http://localhost:3000/bake', headers=headers, data=json.dumps(data))
return response
Expected behavior
I would expect a Status code 200 with the has as the CTPH in the response.  This works on smaller files and I don't see anything other than the content-length that is different.
Node version:
14.15.5
Same results with 10.23.3
Additional context
Error: failed with status code 500
at ServerResponse.onResFinished (/home/redrobin/CyberChef-server/node_modules/pino-http/logger.js:51:33)
at ServerResponse.emit (events.js:327:22)
at ServerResponse.EventEmitter.emit (domain.js:467:12)
at onFinish (_http_outgoing.js:766:10)
at callback (internal/streams/writable.js:513:21)
at afterWrite (internal/streams/writable.js:466:5)
at afterWriteTick (internal/streams/writable.js:453:10)
at processTicksAndRejections (internal/process/task_queues.js:79:21)

To resolve this bug, you only need to change the app.use(express.json()) in the app.js file to ### app.use(express.json({ limit: '10mb' })); because the default request body size limit in Express is 100KB.


Steam Deck Black Bars - Aspect Ratio Fix?

Hey,
Even with both aspect ratio fixes I'm still seeing black bars on my Steam Deck. Is there anyway to fix this?
I'm running game at 2560x1660, but presume the issue retains when moving to default Deck res - 1280x800

Other than that, thanks very much for the fixes. I was really struggling with the sharpening filter.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Can you try this test build? It changes up how the aspect ratio is changed and how the resolution from the game is read.
WukongTweak_v0.8.3.zip

I play on my deck using steam remote play and it fills the entire 1280x800 on my screen when I use the fix. Here are my ini settings:
;;;;;;;;;; Ultrawide/Narrower Fixes ;;;;;;;;;;
[Remove Aspect Ratio Limit]
; Disables 2.3888~ aspect ratio limit.
; Make sure "Aspect Ratio" is set to "Automatic" in the Display menu.
Enabled = true
[Fix FOV]
; Fixes cropped FOV at <16:9 (4:3, 16:10 etc);
Enabled = true
;;;;;;;;;; General ;;;;;;;;;;
[Developer Console]
; Enable developer console.
; If the console does not open, check the README or "WukongTweak.log" for info on how to enable it.
Enabled = false
[Gameplay FOV]
; Add to gameplay FOV in degrees. (Valid range: -80 to 80)
; Game default = 0
AdditionalFOV = 0
;;;;;;;;;; Graphical Tweaks ;;;;;;;;;;
[Adjust Sharpening]
; Adjusts sharpening strength. (r.Tonemapper.Sharpen)
; Set to 0 to disable fully.
; Game default = 3.66667
Strength = 1
[Chromatic Aberration]
; Set to false to disable chromatic aberration. (r.SceneColorFringeQuality)
; Game default = true
Enabled = false
[Vignette]
; Set to false to disable vignetting. (r.Tonemapper.Quality)
; Game default = true
Enabled = true
[Virtual Shadow Maps]
; Set to true to enable virtual shadow maps.
; These can produce much higher quality non-RT shadows but may cause some visual errors.
; Game default = false
Enabled = false

Thanks both. I toggled resolution back and forth and the bars disappeared. Seems the game needed to switch to a different resolution before the fix came through.

Thanks both. I toggled resolution back and forth and the bars disappeared. Seems the game needed to switch to a different resolution before the fix came through.

Was that the case with the v0.8.3 test build I had sent or were you still using v0.8.2?

Thanks both. I toggled resolution back and forth and the bars disappeared. Seems the game needed to switch to a different resolution before the fix came through.

Was that the case with the v0.8.3 test build I had sent or were you still using v0.8.2?

That was on 8.3.

0.8.5 seems to have broken this. Previously, when I remote played on my Steam Deck at 1280x800 the game would fill the entire 800px vertical space. Now, I get black bars but the UI HUD elements fill the full height of the screen, overlapping the black bars at the top and bottom.


Cosmetic issue with graphing TI in cases with zeros for some lambdas

There is a cosmetic issue with graphing the dU/dlambda (dH/dlambda) curve in some cases with some lambda vectors being unchanging at zero, wherein there's a blank region in the graph. The data linked below will yield one such example.
I've also observed in some other cases, there are only x axis labels for some lambda components and not others.
Data for the first case: https://dl.dropboxusercontent.com/u/3409095/guilherme.zip

Hi David,
I would to thank you and the others developers for alchemical analysis, such a good tool that is helping me a lot.
I think I'm finding the same issue. I am not able to see your pictures but here is the link of some graphing I have obtained by alchemical analysis (https://drive.google.com/open?id=0BxeyUUtR8RLOWGFQZzkzOTdzVTA). It's not very important issue but it would be great fix the problem, do you have a solution?
Cheers,
Davide Bonanni

Thanks, @dbonanni . I know what the issue is (basically, the code makes too many assumptions about what lambda pathways you might be following and how to split those into components) but fixing it will require rather significant changes. As I don't currently have anyone actively developing this code, I'm waiting on:
a) alchemlyb to become mature enough (or maybe it is already) that it can replace much of the analysis code here and we can rewrite this mostly to focus on assessment of results/plotting/etc. rather than focusing as much on parsing, and
b) someone suitable who is going to start developing this again in my group
Thanks!

Thank you so much for your prompt reply @davidlmobley. I will look forward to future developments.
Good job and have a great day!


METAL-850: Update packages for OCP 4.16

/lgtm
You need a jira link.

tagged pkgs in production, waiting for repo sync

/retest

/retest

/retest


Update php_cs and use cache

Update php_cs and use cache

Coverage remained the same at 75.534% when pulling 0dc1b58768072a3826b41a3649d17689afd4746d on lucasmichot:feature/master/php_cs into ec1ca8266d9f8220cb0f90bbb84735137d180c90 on padraic:master.

Thanks!


Use vmsplice() for yes command

This results in a 4x speedp through a pipe, and a 2x speedup straight to
the terminal (on my laptop anyway).
I should state that I'm not sure if I have exhausted all possible error-inducing cases, since my knowledge of Linux file descriptors is limited. Perhaps it would be good to have a Linux-guru look at this code.

I have what is probably a better way to do this. As a note to my future self, here's some pseudocode:
// See https://stackoverflow.com/questions/3238788/how-to-determine-if-a-file-descriptor-is-seekable,
// we use fstat(), then S_IFREG
if stdout_is_regular_file {
    if stdout is_append {
        // vmpslice(), then splice() using offset that is the same length as the file (if you can determine it)
    } else {
        // vmspice(), then splice()
    }
} else {
    if stdout_is_fifo (and perhaps also socket) {
        // vmpslice()
        // here we check for Sys(EPIPE) error
    } else {
        // Slow write. I don't know when this case would occur.
    }
}

Was I perhaps not supposed to include Cargo.lock in the commit?

So, looking at this, I feel like it could be made into a VmspliceWriter or something and thrown into uucore, which would let us use it for other utilities (after expanding it most likely).

I’m working on a design for this now.  I have an important assignment due today, so I’ll finish the design tomorrow after the assignment is done.

There's a tentative implementation in #1362 now.

Pretty sure I implemented this in the linked PR (using a zero-copy writer in uucore).

ok, let's close it then :)