xiwi: page zoom results in black screen

installed a new chroot trusty.xiwi (via sudo sh ~/Downloads/crouton -t xiwi,xfce -r trusty -n trusty.xiwi)
on launching 'sudo startxfce4', I get a blank window. The extension says that a connection is established and that the chroot is running.
This is the output in crosh below. I can't run crouton version b/c i'm not sure how to access the chroot...

sudo startxfce4
Entering /mnt/stateful_partition/crouton/chroots/trusty.xiwi...
/usr/bin/startxfce4: Starting X server
X.Org X Server 1.15.1
Release Date: 2014-04-13
X Protocol Version 11, Revision 0
Build Operating System: Linux 3.2.0-70-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.10.18 #1 SMP Wed Dec 17 22:03:20 PST 2014 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=e4e36f0d-ca2b-5940-a7fe-a61287b5a2d8/PARTNROFF=1 hashtree=PARTUUID=e4e36f0d-ca2b-5940-a7fe-a61287b5a2d8/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=761f1bd944a291de8466b50f99e2f5c9ec30105a salt=e9c9a882999db80f8d36f8ea5d1dc9a1a344438ce74ec141b93cff89e5422d7c" noinitrd vt.global_cursor_default=0 kern_guid=e4e36f0d-ca2b-5940-a7fe-a61287b5a2d8 add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic
Build Date: 10 December 2014  06:15:52PM
xorg-server 2:1.15.1-0ubuntu2.6 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Thu Jan  1 01:39:03 2015
(++) Using config file: "/etc/X11/xorg-dummy.conf"
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension Present
Initializing built-in extension DRI3
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension SELinux
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
/usr/bin/xinit: XFree86_VT property unexpectedly has 0 items instead of 1
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Connected to extension, launched crouton in a tab window.
xfce4-session: No gpg or ssh authentication agent found
/usr/bin/xbindkeys_autostart: line 24: CONF: unbound variable
(xfwm4:22683): GLib-CRITICAL **: g_str_has_prefix: assertion 'prefix != NULL' failed
Error: target STRING not available
(polkit-gnome-authentication-agent-1:22725): GLib-CRITICAL **: g_variant_new_string: assertion 'string != NULL' failed
(polkit-gnome-authentication-agent-1:22725): polkit-gnome-1-WARNING **: Failed to register client: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.SessionManager was not provided by any .service files
(xfsettingsd:22745): GLib-CRITICAL **: g_str_has_prefix: assertion 'prefix != NULL' failed
(xfwm4:22683): xfwm4-WARNING **: The property '/general/double_click_distance' of type int is not supported
find_shm: Invalid signature, fetching new shm!
find_shm: Invalid signature, fetching new shm!
find_shm: Invalid signature, fetching new shm!
find_shm: Invalid signature, fetching new shm!
socket_client_read_frame_header: Connection close from WebSocket client.
find_shm: Invalid signature, fetching new shm!
find_shm: Invalid signature, fetching new shm!
socket_client_read_frame_header: Connection close from WebSocket client.
socket_client_read_frame_header: Connection close from WebSocket client.
find_shm: Invalid signature, fetching new shm!
socket_client_read_frame_header: Connection close from WebSocket client.
^C
Session terminated, terminating shell.../usr/bin/xinit: connection to X server lost
waiting for X server to shut down Hangup
Hangup
Running exit commands...
xscreensaver: 01:43:05: SIGHUP received: restarting...
xscreensaver: 01:43:05: running as vishad/vishad (1000/1000)
(xfsettingsd:22745): libxfce4ui-WARNING **: ICE I/O Error
(xfsettingsd:22745): libxfce4ui-WARNING **: Disconnected from session manager.
(xfwm4:22683): libxfce4ui-WARNING **: ICE I/O Error
(xfwm4:22683): libxfce4ui-WARNING **: Disconnected from session manager.
(xfce4-volumed:22777): xfce4-volumed-CRITICAL **: xvd_context_state_callback: The connection failed or was disconnected, is PulseAudio Daemon running?
g_dbus_connection_real_closed: Remote peer vanished with error: Underlying GIOStream returned 0 bytes on an async read (g-io-error-quark, 0). Exiting.
xfsettingsd: Fatal IO error 11 (Resource temporarily unavailable) on X server :1.0.
xfdesktop: Fatal IO error 11 (Resource temporarily unavailable) on X server :1.0.
xscreensaver: 01:43:05: Can't open display: :1.0
xscreensaver: 01:43:05: running as vishad/vishad (1000/1000)
xscreensaver: 01:43:05: Errors at startup are usually authorization problems.
But you're not logging in as root (good!) so something
else must be wrong.  Did you read the manual and the FAQ?
          http://www.jwz.org/xscreensaver/faq.html
          http://www.jwz.org/xscreensaver/man.html

(EE) Server terminated successfully (0). Closing log file.
/usr/bin/xinit: unexpected signal 2
...terminated.
Unmounting /mnt/stateful_partition/crouton/chroots/trusty.xiwi...
chronos@localhost / $ sudo startxfce4
Entering /mnt/stateful_partition/crouton/chroots/trusty.xiwi...
/usr/bin/startxfce4: Starting X server
X.Org X Server 1.15.1
Release Date: 2014-04-13
X Protocol Version 11, Revision 0
Build Operating System: Linux 3.2.0-70-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.10.18 #1 SMP Wed Dec 17 22:03:20 PST 2014 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=e4e36f0d-ca2b-5940-a7fe-a61287b5a2d8/PARTNROFF=1 hashtree=PARTUUID=e4e36f0d-ca2b-5940-a7fe-a61287b5a2d8/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=761f1bd944a291de8466b50f99e2f5c9ec30105a salt=e9c9a882999db80f8d36f8ea5d1dc9a1a344438ce74ec141b93cff89e5422d7c" noinitrd vt.global_cursor_default=0 kern_guid=e4e36f0d-ca2b-5940-a7fe-a61287b5a2d8 add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic
Build Date: 10 December 2014  06:15:52PM
xorg-server 2:1.15.1-0ubuntu2.6 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Thu Jan  1 01:43:17 2015
(++) Using config file: "/etc/X11/xorg-dummy.conf"
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension Present
Initializing built-in extension DRI3
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension SELinux
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
/usr/bin/xinit: XFree86_VT property unexpectedly has 0 items instead of 1
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error timeout
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Error: not connected.
Cannot connect to extension, retrying...
Connected to extension, launched crouton in a tab window.
xfce4-session: No gpg or ssh authentication agent found
Timeout waiting for extension to connect.
/usr/bin/xbindkeys_autostart: line 24: CONF: unbound variable
(polkit-gnome-authentication-agent-1:29506): GLib-CRITICAL **: g_variant_new_string: assertion 'string != NULL' failed
(polkit-gnome-authentication-agent-1:29506): polkit-gnome-1-WARNING **: Failed to register client: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.SessionManager was not provided by any .service files
Error: target STRING not available
(xfsettingsd:29517): xfsettingsd-WARNING **: Failed to get the _NET_NUMBER_OF_DESKTOPS property.
socket_client_read_frame_header: Connection close from WebSocket client.

before sudo startxfce4, go to a crosh / shell terminal and type:
sudo enter-chroot
cd /usr/local/bin
croutonversion
while in the chroot, may want to remove xscreensaver, perhaps that is what is blanking your screen?

before sudo startxfce4, go to a crosh / shell terminal and type:
sudo enter-chroot
cd /usr/local/bin
croutonversion
while in the chroot, may want to remove xscreensaver, perhaps that is what is blanking your screen?

The zoom to your window is set to non 100%.  You can right click on title bar and change it there.  That fixed it for me.

that was the fix! thanks! i guess any type of zoom affects rendering?

@linux4kix Thanks! Looks like a warning for the zoom level is necessary. On 1080p screens like the toshiba chromebook 2, having the default zoom != 100% is a bit of a necessity for daily browsing so I imagine this will be an ongoing problem.

@linux4kix I've spent hours trying to figure out why xiwi wasn't working for me! I imagine many users with 1080p screens will be running into this issue.

so i've been able to install xiwi on my chromebox with xfce and it works like a charm. for some reason, i can't get the copy/paste (shared clipboard) to work despite installing the extension target several times. any thoughts?

Did you install the crouton chrome browser integration extension to your
chromebook side ?
On Fri, Jan 2, 2015 at 10:31 PM, vsukul<EMAIL_ADDRESS>wrote:

so i've been able to install xiwi on my chromebox with xfce and it works
like a charm. for some reason, i can't get the copy/paste (shared
clipboard) to work despite installing the extension target several times.
any thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/dnschneid/crouton/issues/1295#issuecomment-68582964.

Oh, forgot to mention you can find the browser extension here:
Check out "crouton integration":
https://chrome.google.com/webstore/detail/crouton-integration/gcpneefbbnfalgjniomfjknbcgkbijom?utm_source=gmail
On Fri, Jan 2, 2015 at 10:31 PM, vsukul<EMAIL_ADDRESS>wrote:

so i've been able to install xiwi on my chromebox with xfce and it works
like a charm. for some reason, i can't get the copy/paste (shared
clipboard) to work despite installing the extension target several times.
any thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/dnschneid/crouton/issues/1295#issuecomment-68582964.

The performance of the new extension is much better, however I preferred the old behavior.  Now it fullscreens and sees the entire xrandr surface as a single desktop.  If you have an external monitor plugged in that can give a less than desirable output.  I preferred the old plugins behavior that would let me run my linux desktop on just one display.

I do have the extension installed... Copy paste actually works fine on my chromebook,  bit I can't seem to get it working on my chromebox.

@linux4kix it sounds like you reverted back to native xorg...
So if I understand correctly, having page zoom results in xiwi not displaying anything?  System zoom should work fine.

seems to be the case.

The main issue I have seen on my HP 14(2013) model, with Trusty XFCE,xiwi and the extension installed is I can never open Trusty with the extension on first boot, it constantly says 'Disconnected(retrying every 5 seconds)'. But once I open it with 'sudo startxfce4' thru the terminal, the extension works great.

@YrrchSebor - For clarification, I'm just wondering how you are attempting to open Trusty on your first boot, what command(s) are you using?

@:DennisLfromGA: I'm just clicking on the Crouton extension and trying to open it like that. It works after I've already started Crouton thru the terminal with 'sudo startxfce4', but if i haven't done that yet, the extension will keep saying it's trying to connect but it never does. I wasn't sure if this was by design or if the extension is supposed to open Crouton straight away..

@YrrchSebor - It's really by design; you have to open a cros shell and do your sudo startunity thing first, then the 'crouton integration' extension can 'see' it and will switch to it.
There's no way to start a chroot without first using one of the start* scripts in a cros shell.
That is, unless you're willing to go through some loops first, see 'Autostart crouton chroot at ChromeOS startup'.

@YrrchSebor @DennisLfromGA Well one could also install a DE/WM, add it to ~/.xinitrc and start the chroot with sudo enter-chroot xinit?

@montauk Yep. That's what I'm doing since I'm using Awesome. It's been working without a hitch.

@montauk - I was just explaining it using the conventional start* script syntax but, yep, you're right, there are other ways to start a DE/WM.

Thanks guys for the answers. I'm fine with using the terminal initially to open my chroot. I really like using the button above the number 6.... when my chroot is running, that button will show my Chromeos and Ubuntu desktops.

I just read this thread and am sure it must be what I'm seeing with my blank screen with KDE as well. I think it's the zoom issue.
Question: Is there a way to remove the xiwi target after I have installed it? Or better yet, if I want to revert back to the non-tabbed version of chroot (where I switch back and forth to chromeos/kde using ctrl-alt-shift-forward/back arrow method again) -- is there a way to do this? Put another way, I just want to disable the tabbed version. It doesn't work if I just uninstall the crouton integration extension, as crouton still wants to connect with it.
-Chris

@murphycc Run sudo sh -e ~/Downloads/crouton -u -t xorg -n your-chroot-name to go back.

Great! Thanks, Dylan.

Can BOTH crouton targets (extension AND xiwi)  be installed as the same time?  Or is it one or the other?  I performed a crouton update twice once to install the xiwi target and again to install the extension target.  After performing the second extension target update and launching crouton via the "sudo startxfce" command, my Chromebook rebooted to the recovery screen - lost all my configurations.  I believe crouton reset the dev_boot_signed_only to 1 which would not allow booting because I had previously executed the enable-vmx.sh script (which sets that variable to 0 and modifies kernel boot parameters).
Thanks Much for any Clarification!
Regards, Ron

@rrolsbe : xiwi depends on the extension (so it's either both, or just the extension).
See https://github.com/dnschneid/crouton/issues/765#issuecomment-69986327 for an answer to to second part.

In the past I have successfully installed precise with the xiwi,xfce extensions.
I want to run xbmc but other versions such as trusty and saucy do not  seem to work well, so I am stuck with precise.
Although I can successfully install precise, recently I cannot install the xiwi extension which is necessary for crouton integration.
sudo sh ~/Downloads/crouton -t xiwi -u
I receive the following message after an install, but only with a precise install
The following packages have unmet dependencies:
xserver-xorg-video-dummy : Depends: xorg-video-abi-11
Depends: xserver-xorg-core (>= 2:<IP_ADDRESS>1)
E: Unable to correct problems, you have held broken packages.
Any assistance would be appreciated.

That's #1294

Thank you!
Regarding broken upgrade to xiwi (#1294), I was able to install the missing dependencies and get precise working with crouton integration.
After installing precise
sudo sh ~/Downloads/crouton -t xfce
I then installed the missing dependencies
sudo apt-get install xorg-video-abi-11 xserver-xorg-core
and updated
sudo sh ~/Downloads/crouton -t extension -u

Indeed, there is an issue when zooming the page (right click on title bar->zoom).
For now, we probably do not want to allow zooming (we could later on, possibly with another setting similar to "HiDPI" option we currently have).
We could force the page zoom to 100%. There is now an API (https://developer.chrome.com/extensions/tabs#method-setZoom), but unfortunately it is only available on dev channel...
The alternative is to compensate for page zoom (PR coming).


components_exports.aws.ApiGatewayWebSocket is not a constructor

When trying to add ApiGatewayWebSocket, we receive error:
|  Error
|  TypeError: components_exports.aws.ApiGatewayWebSocket is not a constructor
|      at run (file:///Users/app/sst.config.ts:26:17)
|      at run (file:///Users/app/.sst/platform/src/auto/run.ts:39:26)
|      at file:///Users/app/.sst/platform/eval.ts:6:28
|      at ModuleJob.run (node:internal/modules/esm/module_job:217:25)
|      at ModuleLoader.import (node:internal/modules/esm/loader:316:24)
|      at importModuleDynamicallyWrapper (node:internal/vm/module:431:15)
|  Info        Downloading provider: aws

Config:
const api = new sst.aws.ApiGatewayWebSocket("APISocket");
Tried removing .sst folder and reinstalling dependencies

@tyrong,
Hello, I'm facing the same issue. I wonder if you solved it?


Abstract away settings logic using composition

Settings are now just POCO classes that are wrapped by the generic SettingsContainer class which contains the serialization logic and a changed event. It also implements a ISettingsContainer interface This cleans this logic up and allows us to treat settings in a more generic way (such as here https://github.com/AdamsLair/duality/pull/856/files#diff-3a2fbc8f3e471d6698b637e54ca23cffR998).
Also updated the naming of settings files according to #855.
Further possible improvements:

We can treat the settings container as a reference to the settings and no longer strictly need to go through DualityApp or DualityEditorApp anymore if we pass the container as a reference. This would actually remove the dependency on DualityApp or DualityEditorApp for alot of code which is a good thing. We might wanna do this in a separate PR to avoid inflating the scope of this PR though.

Is this ready for review, or still WiP?

Still WIP as I have to change the extension to .xml and do my own review

Added some minor change requests for the current implementation.
I'm a little bothered by the sudden influx of all the .Value indirections here, but due to the lack of serializer support for re-using the same instance, there's probably no way around that container design for now, as discussed in #855.

Agree it clutters the code a bit but thats also because its used through DualityApp which leads to a quite long name. Ideally you just want to give the code that needs it a reference to the settingscontainer and no longer depend on any static class anymore. Will be hard to do this throughout the code base without something like dependency injection though.

Ideally you just want to give the code that needs it a reference to the settingscontainer and no longer depend on any static class anymore. Will be hard to do this throughout the code base without something like dependency injection though.

I disagree on that one, I think there's a balance to be struck here. But that's a topic for another time 😁


[DO NOT MERGE] wip

I just want to run tests to see if I have better luck in GHA

I think we can close this. Is that right @TisVictress ?

Closing


Output generated C++ code

Fantastic idea, by the way!
I would like to be able to generate code (preferably C, but if not then C++) for each platform, from JS. I would then like to be able to go into each platform's C/C++ code and make platform-specific optimisations.
Is there any reason not to output the intermediate C/C++ code, at present?

Hi @ArcaneEngineer ,
Thank you !
You can output c++ code without compilation by using --generate
You can change the output directory with --tmp

@ArcaneEngineer is it ok ?


Ignore type annotations close #252, close #253

https://github.com/eleme/thriftpy/pull/253 https://github.com/eleme/thriftpy/pull/252

@lxyu

Comment:

Apache supports type annotations on fields, structs, enums, functions etc. example
Annotations are just ignored, but not parsed.
senumare now deprecated, so the senum annotations won't be supported.

Hi @hit9, any chance we can get this released to pypi?


Unchecked return value transferFrom

TITLE (Unchecked return value transferFrom )
While performing a transfer in USDC, either you should use safeTransferFrom or check it's return value according to it's IERC20 interface. USDC does return a boolean if something unintended has happened during the transaction and the funds would have not been sent. It is a rare case, that is why it is a medium and not a high.
https://github.com/PlutusDAO/plvGLP-looper/blob/9cb8dbc16183e7526382a07db259e61a1e1b191c/contracts/Ploopy.sol#L108
SEVERITY (either high or medium, see the rules)
Medium, not very likely, but can have unintended consequences if it happens
A LINK TO THE GITHUB ISSUE
https://github.com/PlutusDAO/plvGLP-looper/blob/9cb8dbc16183e7526382a07db259e61a1e1b191c/contracts/Ploopy.sol#L108
SOLUTION
Add require statement:
 //BEFORE

     USDC.transferFrom(data.user, msg.sender, data.borrowedAmount);

   //AFTER

       require(USDC.transferFrom(data.user, msg.sender, data.borrowedAmount), "wrong transfer");

It seems like USDC doesn't return false if any unintended has happened, it reverts the tx instead. U can take a look at
https://etherscan.io/address/0xb7277a6e95992041568d9391d09d0122023778a2#code

The solution to this issue is generally to use the safeERC20 library, and this issue/solution is marked as planned in #5


Chrome extension integration, woo!

Chrome extension + my functionality.
Global mass is visible
Small mini map in top right of window, near leader board.

Good work to say the least, @Inumedia but there is one problem, I believe this should be a separate mod because as soon as the minimap, show all mass, etc. is added we cannot advertise this "mod" on the reddit. Due to the rule Do not post cheats or anything else that might give one an unfair advantage. Posts like this will be taken down immediately and the user will receive a 3 day ban. But I do believe we could make this into a separate mod @electronoob ?

if this merge is met with a ton of resistance then we can rethink the situation. What I will be doing is attempting to merge in your changes, without using the main_out.js file that had to be hacked to make these mods work. I would rather patch on the fly than us host essentially a copy of the guys code, albeit obfuscated and freely world readable anyway.

I'm skeptical that such a method could work, but if you get something that does I'd be very interested in seeing it.

Okies, I've created /Intercept/ on the repo which demo's the new system for patching the game like I mentioned earlier. I would really appreciate it if you can start porting your mods over for inclusion.


Add BattleTrackerHook

Can you add BattleTracker hook that tells BattleTracker to stop tracking for deaths/kills when a player enters a minigame? It should also tell BattleTracker to resume when they finish/leave the minigame.
I was actually going to do this via a third plugin but couldn't find an API. I have the BT code ready though:
import mc.alk.tracker.Tracker;
import mc.alk.tracker.TrackerInterface;
import org.bukkit.Bukkit;
import org.bukkit.plugin.java.JavaPlugin;
public class Test extends JavaPlugin{
public static TrackerInterface ti = null;

public void loadTracker(){
	Tracker tracker = (Tracker) Bukkit.getPluginManager().getPlugin("BattleTracker");
	if (tracker != null){
		ti = Tracker.getInterface("MinigamesHook");
	} else {
		System.out.println("Warning BattleTracker not found. Implemantation disabled.");
	}
}

public void disableBattleTrackerForPlayer(String playername) {
	if (ti != null) {
		ti.stopTracking(playername);
	}
}

public void enableBattleTrackerForPlayer(String playername) {
	if (ti != null) {
		ti.resumeTracking(playername);
	}
}

}

If I am correct, you might be able to get a plugin called PerWorldPlugins. Try that for the moment, and have all your games in one world.

The plugin you mentioned would solve my issue if I had my minigames on one world and pvp zones on the other. However, I don't.

I know this issue is more than a year old (sorry) but with a 3rd party plugin you could hook Minigame events to track when a player joins/leaves a Minigame and enable/disable the BT tracking for that player accordingly.


Replace set..coderBufferLimit with set..coderBufferLimitLowerBound

Commit Message: Replace set..coderBufferLimit with set..coderBufferLimitLowerBound
Additional Description: Per #23774 the current behavior of setDecoderBufferLimit and setEncoderBufferLimit can be surprising if two filters both try to use it. This more reasonable implementation recognizes that there's no reason for a filter to want a smaller buffer, so if two filters both ask for a size, whichever requires the larger size should take priority. Making these function only act to increase the buffer-limit solves this, while renaming the functions makes it clear that the change has happened.
Risk Level: Low. There are few calls to these functions.
Testing: Tests modified slightly to cover the change.
Docs Changes: Updated flow_control.md
Release Notes: Yes, in changelogs.
Platform Specific Features: n/a

/retest

Making tests work with this change isn't work the effort.


Update documentation.

Codecov Report

Merging #2 (f08bdad) into main (e12c76c) will decrease coverage by 1.38%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   67.71%   66.32%   -1.39%
==========================================
  Files           9        9
  Lines         920      790     -130
  Branches      302      248      -54
==========================================
- Hits          623      524      -99
- Misses         46       54       +8
+ Partials      251      212      -39

Impacted Files
Coverage Δ

src/flag.rs
73.52% <ø> (ø)

src/perm.rs
71.42% <ø> (ø)

src/sys.rs
100.00% <ø> (ø)

src/util.rs
72.05% <ø> (+0.67%)
:arrow_up:

src/aclentry.rs
45.09% <5.88%> (-7.72%)
:arrow_down:

src/lib.rs
53.84% <100.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e12c76c...f08bdad. Read the comment docs.


Get the filtered results

Is there a way to get filtered results?
In the itemSelectionHandler, I get position and item. But the position is as per the filtered list & not the original list. Here filtered list means the list which is formed after the user enters a character on the textfield and original list means the list of items supplied to the textfield for filtering.
Please help with the above issue.

You'll find it in the new 1.1.2 version. Thanks!


Check CI status on master branch in release workflow

More details in https://github.com/apify/crawlee-python/pull/466#issuecomment-2312331905

We should also publish a new version of documentation after release (and updated changelog).

I managed to do this in https://github.com/apify/apify-client-js/pull/596 (https://github.com/apify/apify-client-js/actions/runs/11478924622), what do you think @B4nan @vdusek?

How does it work exactly? Does it verify if the "code checks" for the current commit are already passing, and if they are, it proceeds? If they are not, does it trigger them ?

How does it work exactly? Does it verify if the "code checks" for the current commit are already passing, and if they are, it proceeds? If they are not, does it trigger them ?

The checks are triggerred from a separate workflow that is started on push to master. The action periodically inspects them, fails if one of them fails, succeeds if they all succeed, and keeps waiting if they are not finished. Triggering the checks from the release workflow should not be necessary.

Thanks. It looks great then.


MachineSet controller listens for Machine resources.

The current implementation of MachineSet controller watches only the desired state of the cluster. This approach is not sufficient as there are other actors in the system that can easily change the current state (e.g. delete/add a Machine) of the cluster. Thus adding event handlers for Machines to our MachineSet along with appropriate handlers (requeue) seems to be valid approach.
See also:
#535
https://github.com/kubernetes/kube-deploy/pull/620#discussion_r172772002
https://github.com/kubernetes/community/blob/master/contributors/devel/controllers.md

This issue was moved to kubernetes-sigs/cluster-api#53


Hide AsyncRetryOp ctor.

This class inherits from enable_shared_from_this, which means it should be allocated by new and put in a shared_ptr. Therefore, the ctor should be private and there should be a Create member function returning a shared_ptr.

This is now obsolete, as the class was removed.


Percentage bar not filled completely in the left side

Tested with version 0.4a

I don't this problem.
Perhaps the theme is the problem.

With the different versions, your problem is still present?

no response

no response


fix: ResponseInterface

Description
Ref #4356
Fixes #5351

fix ResponseInterface
fix MessageInterface
deprecate

CodeIgniter::$useSafeOutput
CodeIgniter::useSafeOutput()

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

Added the docs.
I've found this PR is not enough to fix ResponseInterface.
But it seems a lot of changes will be needed, so I'm going to another PR.


i18n(zh-cn): Update authentication.mdx

Description (required)
Update authentication.mdx
Related issues & labels (optional)

#8908
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
guides/authentication.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Windows support

closes #1

Added process.platform to check what we're running node on.
macOS behaves as before
Windows asar path is constructed correctly
Other platforms now throw an informative error, instead of failing to find the asar path.

At the moment, the asar package needs to be globally installed, due to the exec('asar ...') line.
I don't know if this can be easily amended to use a local copy of the package instead, but for now i've added to the README that it should be globally installed.

Merged.
Thank you @beforan!


Electron: Support localhost URLs

As of 1.0.1, http://localhost:3000/graphql is not a valid URL Endpoint. This is because isURL looks for a TLD by default. I believe adding the { require_tld: false } option to the isURL below would fix this.
https://github.com/graphcool/graphql-playground/blob/9d459d998788985c22491c3c7013f078c548c0dd/packages/graphql-playground-electron/src/InitialView/InitialView.tsx#L72

Yes, I'll try to get to it today, after work 😄

Yea, this should really not happen:

Temporary workaround for now...
Select one of the sample api's.
Click settings button in top right.
Update route to use http://localhost:3000/graphql.
Should now work correctly.
That said, I look forward to when this is resolved. Great work on this tool!

@andrewtpoe Your workaround doesn't seem to work for me. It keeps the old schema


Add validation if user tries to look at a gameplay page for the wrong round

I fixed it so each gameplay page has its own URL with a name and a round number. That way if the user hits the back button, they won't completely ruin the game.  However, they should see a message rather than the input form and should not be allowed to resubmit.
We should do something similar if they manually manipulate the URL and try to go to a future round, although that's less likely.
We should add a way to get back into an existing game in case you really messed yourself up.

I do not plan to do anything here. After playing several games where other players did weird things, I think being able to go back to any page is kind of useful.


semver build jobs broken

The semver build jobs are failing to build: https://travis-ci.com/rust-lang/libc/jobs/200647230#L409
cc @ibabushkin

I am aware of the problem. I also have a partial fix laying around, but it is still failing some of semverver's own tests, mostly regarding trait impls. I'll push that to git and you can check whether the test failures affect the use of semverver for libc.

Thank you for looking into this @ibabushkin , I just wanted to notify you. We allow the build jobs to fail, so they should become "green" automatically once the next semverver version is released if all test pass, or "red" if semver changes are detected.

It's now worked with the pinned nightly version.


Wrong function is resolved

The js_sys crate has 2 functions called global: one in the outer scope and one in RegExp. When I try to use the outer one rustc handles it fine, but rust-analyzer consistently gives me docs and type hints for the RegExp one, and sometimes an error because that one takes 1 argument while the outer one takes 0.
This reproduces the problem for me on the latest rust-analyzer release:
Cargo.toml
[dependencies]
js-sys = "0.3.51"

main.rs
fn main() {
    let _res = js_sys::global();
}

Incidentally this example also triggers #5412

That's due to us not resolving attribute macros yet, cc #6029

The correct function does not have an attribute macro, only the one that wrongly gets resolved does, so shouldn't the problem be the other way around if that is the cause?

The RegExp::global function is declared in an extern block, which is being changed by the proc macro. To RA this looks like an ordinary extern function and since its defined prior to the actual free standing global function I believe that resolution just picks the first function as that's what RA sees first.


showTextDocument should support to open in the background

VSCode Version: 1.4.0
OS Version: OSX 10.11.6

Steps to Reproduce:

Open a document with openTextDocument
Then show the resulting document with the preserveFocus argument set to true showTextDocument(TextDocument, vscode.ViewColumn.One, true)
A new editor opens and still gains focus

preserveFocus means that the new editor does not take the current focus away (for instance it stays in the 2nd editor or the debug repl etc)

@jrieken I believe we're saying the same thing. Let's say the focus was on editor A. Then I execute a command that opens a document and shows that document in a new editor B with preserveFocus set to true. Shouldn't editor B open but editor A still have focus?

Yeah - seems like it. Tho, I cannot reproduce what you are saying
   let disposable = vscode.commands.registerCommand('extension.sayHello', () => {

        if (vscode.window.activeTextEditor) {
            vscode.window.showTextDocument(vscode.window.activeTextEditor.document, vscode.ViewColumn.Two, true);
        }

    });

Try a file that's not opened in any other editor and show it in the same view column.

Try a file that's not opened in any other editor and show it in the same view column.

Is that just a guess because also that works for me? Please provide reproduce steps that allow me to reproduce this

@jrieken

Open a folder
Open a file in that folder as the active editor
Run the sayHello command from the code below (make sure to change the path in the code below to a file in that folder)
The newly opened editor takes focus and covers the previously active editor

// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
var vscode = require('vscode');

// this method is called when your extension is activated
// your extension is activated the very first time the command is executed
function activate(context) {

    // Use the console to output diagnostic information (console.log) and errors (console.error)
    // This line of code will only be executed once when your extension is activated
    console.log('Congratulations, your extension "test-extension" is now active!');

    // The command has been defined in the package.json file
    // Now provide the implementation of the command with  registerCommand
    // The commandId parameter must match the command field in package.json
    var disposable = vscode.commands.registerCommand('extension.sayHello', function () {
        // The code you place here will be executed every time your command is executed

        vscode.workspace.openTextDocument('/full/path/to/file.js').then(function(TextDocument){
            vscode.window.showTextDocument(TextDocument, vscode.ViewColumn.One, true);
        });
    });

    context.subscriptions.push(disposable);
}
exports.activate = activate;

// this method is called when your extension is deactivated
function deactivate() {
}
exports.deactivate = deactivate;

Open a file in that folder as the active editor

You mean 'Open a file in that folder as the active editor in ViewColumn.One'?

@jrieken Yes

Ok. What you want is to open an editor in the background for which we currently don't have support

@bpasero Do we have support for the in the underlying API and how would/should it work in noTab mode? You wouldn't see the new editor unless you keep an eye on the open editors section in the explorer, right?

@jrieken that is right, for this behaviour it does not make a difference if you see tabs or not in the main editor area because you could be using the "open editors" view and will notice there how an editor opens "in the background".
Since you have tabs disabled, in this case you would need to close the top most editor until you reach the one that was opened in the background (in the same way as you do when you have tabs enabled).

I'm making a remote pair programming extension and want to allow a remote user to open a file and edit it without bothering the local user.
Here is the extension I'm using as a base: Motepair
Here is my extension's repo: vscode-motepair

I am also waiting for this feature as i want to open the summary page to open in the background so user who is working on other tab should not get disturbed and through API i can add text on that other tab in the background.
When user switch to that api he should see the extension summary.
Extension - code-settings-sync !

yes

The problem with this is that opening an editor in the background doesn't make an editor in the editor. Only documents that are current shown in an editor-widget are an editor in the API. So, when calling showTextDocument with some background-parameter will not return an editor instance but undefined. I'd say that is a little fuzzy and maybe this is the same feature request as exposing the tab model, because that's what this is, adding another tab (entry in the list of open editors).
Closing this as dupe of #15178 which is about exposing the tab-model


Contribution: Timing input Groups

Hi guys. How can one contribute to this project? I would like to tackle Timing input (easings, duration, fillMode, etc.) for groups but don't know if that is in development and I couldn't find any contribution guidelines.
Thanks

This is a pretty hard one to start with. We're constrained by the fact that the polyfill needs to emulate the web-animations-1 specification, then build features on top of that.
If you're still interested, maybe we could find an easier bug or feature for you to look at first?


Prometheus: Ensure tagged hosts maintenance status is reported consistently

When a host is not tagged, its maintenance status is reported in the cloudstack_hosts_total metric: maintenance_enabled is OFFLINE, maintenance_disabled is ONLINE.
When a host is tagged, its maintenance status is now also verified to ensure consistent behaviour.
Description
This PR fixes https://github.com/apache/cloudstack/issues/7470
In prometheus exporter, maintenance status for cloudstack_hosts_total_by_tag is not checked. While it is checked for cloudstack_hosts_total metric.
Classified by_tag or not, metrics should be the same.

Fixes: #7470

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Trivial change.
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5998


Solving SSL certificate problem

The update solves the SSL Certificate problem after the new security issue update.

:+1:  thanks works for me Accept PR please

Please check before making this kind of pull request. The thing is it should work for everyone, not just you. Also the Travis build failed here.

Thanks for your PR! It's an old one now and I'm just going through and cleaning things up.
Everything needs to pass tests, PRs need to be made into develop, and also it does need to work for everyone. Closing for now...


vs-code extension: Webpack build fails

Hey mate,
I had some difficulty getting the language server running in vs code this morning.
By the looks of things, the gradle file calls webpack to do the Typescript transpilation. On my machine, the webpack step was failing (but didn't fail the gradle build) which led to the extension not starting the language server.
I'm not familiar with webpack but this is the error I got from running webpack manually. Looks to be that it only happens when I run webpack with -mode production. Running webpack just by itself seems to work fine.

webpack production mode error
$ .\node_modules\.bin\webpack -mode production
C:\Github\groovy-language-server\vscode-extension\node_modules\webpack-cli\bin\cli.js:93
                                throw err;
                                ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type boolean
    at validateString (internal/validators.js:107:11)
    at Object.isAbsolute (path.js:350:5)
    at module.exports (C:\Github\groovy-language-server\vscode-extension\node_modules\webpack-cli\bin\utils\convert-argv.js:34:13)
    at C:\Github\groovy-language-server\vscode-extension\node_modules\webpack-cli\bin\cli.js:71:45
    at Object.parse (C:\Github\groovy-language-server\vscode-extension\node_modules\yargs\yargs.js:567:18)
    at C:\Github\groovy-language-server\vscode-extension\node_modules\webpack-cli\bin\cli.js:49:8
    at Object.<anonymous> (C:\Github\groovy-language-server\vscode-extension\node_modules\webpack-cli\bin\cli.js:365:3)
    at Module._compile (internal/modules/cjs/loader.js:774:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)
    at Module.load (internal/modules/cjs/loader.js:641:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Module.require (internal/modules/cjs/loader.js:681:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (C:\Github\groovy-language-server\vscode-extension\node_modules\webpack\bin\webpack.js:156:2)
    at Module._compile (internal/modules/cjs/loader.js:774:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)
    at Module.load (internal/modules/cjs/loader.js:641:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:837:10)
    at internal/main/run_main_module.js:17:11

running webpack without mode flag
$ .\node_modules\.bin\webpack
Hash:<PHONE_NUMBER>038cc0ad9f
Version: webpack 4.36.1
Time: 1655ms
Built at: 09/14/2019 10:08:59 AM
           Asset     Size  Chunks             Chunk Names
    extension.js  158 KiB       0  [emitted]  main
extension.js.map  632 KiB       0  [emitted]  main
Entrypoint main = extension.js extension.js.map
 [0] external "vscode" 42 bytes {0} [built]
 [7] external "path" 42 bytes {0} [built]
[11] external "fs" 42 bytes {0} [built]
[12] external "child_process" 42 bytes {0} [built]
[13] external "net" 42 bytes {0} [built]
[17] ./src/main/ts/extension.ts 5.85 KiB {0} [built]
[18] ./src/main/ts/utils/findJava.ts 2.4 KiB {0} [built]
[25] external "os" 42 bytes {0} [built]
[26] external "crypto" 42 bytes {0} [built]
    + 40 hidden modules

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

I can reproduce your error by using -mode, but it works with --mode (notice that there are two hyphens).


Twitter Bootstrap not working with bower and Angular 1.5.8

Hi, what is the correct way to install ui.bootstrap with bower? I installed with bower install -S angular-bootstrap and added ui.bootstrap dependence on index.js but does not work.
My index.js:
angular   .module('app', ['ui.router', 'ui.grid', 'ui.bootstrap']);
My bower.json
{   "name": "fountain-inject",   "version": "0.0.1",   "dependencies": {     "angular": "^1.5.8",     "angular-ui-router": "1.0.0-beta.1",     "angular-ui-grid": "3.2.1",     "bootstrap": "^3.3.7",     "angular-bootstrap": "^2.2.0",     "jquery": "^3.1.1"   },   "devDependencies": {     "angular-mocks": "^1.5.0"   } }
Thanks!!

why not publish your project  ?

@sickpalmex Please provide the details of the errors you have.


Add Plausible Template

Goal
Plausible is an analytics template designed for simple and privacy-friendly website tracking.
Payout
$250
Expectation
Create the Plausible template with easy deployment and minimal configuration. It should provide basic website analytics with a focus on user privacy. Ensure that users can track essential metrics like page views and referral sources. Comprehensive documentation will guide users in leveraging Plausible's analytics features effectively.

I'm working on this now! Here's my repo.
I will update here when I have a working and documented template.

Alright! I've got a template published on Railway, and a GitHub repository for the template to keep track of setup guides and feedback.
If you or the team have any feedback, we can chat through that here and/or over email (my email is mykal@tinybox.dev).
Had fun working on this, despite a few holes in the Plausible self-hosting docs!
Thanks for the opportunity y'all!

Beautiful work @MykalMachon! Thank you for slogging through the Plausible docs and submitting a template that just works ✨
I do have a couple of requests with regard to the documentation -

could you mention the optional variables and what they are used for?  doesn't have to be verbose, just a comment about what happens if they aren't added, and maybe a pointer to the Plausible docs where they can read more?
it would be amazing if you added some information about the project structure in the repo that is created.  Again, doesn't have to be long-winded, just mention that there is a railway.json file that is being used to orchestrate things within Railway (so good)
could you add a line about how PostGres and Clickhouse fit into the equation.  same as above, nothing crazy just clarify that PostGres is being used to store user data and clickhouse for analytics data

Once you're done with those tweaks, please push your code into this repo (https://github.com/railwayapp-templates/plausible) and update the template configuration to point here.  After that, send me an email at<EMAIL_ADDRESS>and I'll make one more pass at the template and start the payout process!

On it! going to get started on those changes now.


feat: added better typing for the Optional class and helper.

[x] Added or updated tests
[x] Documented user facing changes
[x] Updated CHANGELOG.md

Changes
Added a conditional return type to the optional() method along with template typing.
Made the Optional class a universalObjectCrateClass as it will return a value for all property names.

Can you rebase it on top of master branch instead of a merge commit? Thanks!

Thank you!

Hi @mad-briller
This change caused some errors in my testing.
For example now optional($this->some_carbon_date_time_field)->toIso8601String() produces the error Call to an undefined method Illuminate\Support\Optional::toIso8601String()
Could you take a look at that? Thanks.

i guess in the past this wasn't raised because of the explicit mixed present in laravel's phpdoc for optional(), now that phpstan knows it's Optional it's trying to make more guarantees about it
it may take a bit of work for me to do that and i'm not sure when i can get to it, my idea would be to make Optional generic and then use some property / method reflections to see if the proxied object has that property / method

Sure no problem. I also like the generics idea. I might look into that tonight!

oh sweet, i'll keep my eye out, thanks
if we do make Optional generic, the universalObjectCratesClasses definition for Optional can be removed, because the property reflection would want to take precedence and can return new MixedType in the case it is not present

@mad-briller On a second though I decided not to go generics way. There is no reason to complicate things. Since ?-> exists in PHP using optional is not needed anymore anyway. So I did this https://github.com/nunomaduro/larastan/commit/8cdd75dec47b7bc6d0bc0a524116da1df31ca2d3 We will still get better types when callback is used. But for calls just with the value, we assume mixed


Urgent: Timeouts not counting as failures in travis OR shippable

Take great care merging!
Example PR #6989 run (look at the "succeeded" builds):
https://app.shippable.com/builds/553207173ef75c0c00a39b55
https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/59007463

Somewhat related, #7008 (bug) and #7029 (fix, as yet unmerged) mean that "guestbook" and "shell" e2e tests are being silently skipped on all platforms since Wed last week (4/15).  #7029 should merge shortly and resolve the issue.

From the Travis run,
FAIL	github.com/GoogleCloudPlatform/kubernetes/pkg/tools	300.128s
+++ [0418 07:38:41] Combined coverage report: /tmp/k8s_coverage/v1beta3/20150418-072840/combined-coverage.html
Job #16301.2
https://coveralls.io/jobs/5516029
The command "KUBE_RACE="-race" KUBE_COVER="y" KUBE_GOVERALLS_BIN="$HOME/gopath/bin/goveralls" KUBE_TIMEOUT='-timeout 300s' KUBE_COVERPROCS=8 KUBE_TEST_API_VERSIONS=$KUBE_TEST_API_VERSIONS ./hack/test-go.sh -- -p=2" exited with 0.

So it looks like either the shell script is eating the exit code, or the test is exiting 0 even when tests fail. Similarly for Shippable, it seems.

I think #6899 broke this. It appears that hack/test-go.sh will always exit 0, even when tests fail or timeout. We should revert this change ASAP.

Fixed by #7058


[Custom Components]

Explicit Options
Due to performance reasons not all the options are bound to the component. If you want to reach fields from the schema, define in the fieldOptions array at the field registration.
I am creating custom input like select and i want to access values i.e. array. but when i am adding fieldOptions: ['values']  and try to bind
@Input() values: any;
in the component i am not able to see change in values as per doc it should be reflected in the document.
Implicit Custom Options
It is rendering in Edit form but
I tried to add customOption as well and tried to get it in
@Input() myoption
it's also not reflecting the changes i am getting 'undefined'.

I got it it's not reflecting in ngOnInit but it's working.No issues Thanks

@ashusaini It is interesting, I couldn't figure out how you were able to access the variables.
I have used 4.7.0/4.9.0 and even the latest 5 version too, but nothing is returning Custom Fields from Edit form. Only @input() placeholder is returning the value as expected, not even Key of the Component.
Kindly provide your expertise, Thanks

Hi, Thanks, I got it, Form.io Developers are attaching the fieldOptions as @Input fields, just that they are not available at NgOnInit.
Interesting if somehow make it work on NgOnIt. Thanks.
if (isArray(fieldOptions) && fieldOptions.length > 0) {
for (var key in fieldOptions) {
if (fieldOptions.hasOwnProperty(key)) {
this._customAngularElement[fieldOptions[key]] = this.component[fieldOptions[key]];
}
}
}


Updated parent dependency to 1.0.1-SNAPSHOT

Codecov Report

Merging #72 into devel will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              devel      #72   +/-   ##
=========================================
  Coverage     22.79%   22.79%
  Complexity      133      133
=========================================
  Files            57       57
  Lines          1316     1316
  Branches        117      117
=========================================
  Hits            300      300
  Misses          989      989
  Partials         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50f44f...82e6dec. Read the comment docs.


Support for up/down keys in iOS (terminal emulator)

I was trying to run through the nodeschool apps using an iOS terminal emulator (ex: Cathode) connected to a host running node and noticed that the up/down arrow keys didn't work in the menu. I used the code from this module to write a throwaway echo program and observed that iOS was producing x.79.y instead of x.91.y. I've verified this in a couple different emulator apps, so I'm assuming this is an iOS thing and not a quirk of the emulator. I haven't been able to find a reference that would make this more authoritative, but here's a PR based on what I can observe. (iOS7 on an iPad mini)

Thanks for the patch! Merged in 0.3.4.


Replace the old InvokerHealth with the actor based one

This is the next step towards the new invoker health protocol, should be merged after #1859 for sanity and risk minimization.

There is a test on the controller/loadbalancer side for the invoker actors.  Is there a unit test for the health ping through kafka?  Do we still have a composite test to actually go through the motion of an invoker  going down and back?

PG2 1143

LGTM


can't install

error:
ps_mbo. Employee->email is empty
also it says installed I see no database values for the module and reset the module gives this: Warning: mkdir(): No such file or directory. version 4.3
PS 801 php 8.1

Hello @tajriba ,
Thanks for your report.
We will take a look at this.
In the meantime, can you provide us more details, logs, screenshots of these errors please ?

Hi @tajriba
Thanks for your report
I'll ask some questions to help us understand your issue
Do you have access to the database?
Are you confortable enough to query the DB and see if you have an employee with firstname=Marketplace lastname=Prestashop ? (do not paste the line here, I just to know if the employee exists and has a non-empty email)
Did you do any special thing after installing MBO?
Thanks for your help

@tajriba,
As the mkdir function tries to create a folder, do you have a path specified in the error ?
If yes, please, ensure that you have correctly the rights to write on this folder.
Also, can you provide us a bit more of context ? Screenshots, stacktrace, logs ...
Thanks for your help.

I close this issue due to inactivity.
@tajriba, if you have some news, feel free to answer.
Thanks again.


Show more useful information when user input a short version of toolchain

I tried to install Rust 1.24 via rustup, but when I type
rustup toolchain install 1.24

it reports

error: toolchain '1.24' is not installed

It took me quite a while to figure out what's wrong with the version, but eventually I realized that it is because rustup expects the whole three-part version number. With 1.24.1 I successfully installed the toolchain I wanted.
But I think the error message here can definitely be improved, for example, maybe "error: toolchain '1.24' doesn't exist. Maybe you mean '1.24.0'". Or probably rustup should just handle this case transparently for users so that people don't need to type the whole version.

Currently the error you get is:

error: invalid toolchain name: '1.24'

I'm not sure I'd want us to "guess" the user meant 1.24.0 or even to start fetching channel manifests from 0.. until we find the latest patch for a given release because that's a lot of assumed work.
If I said rustup toolchain install 1.xx and it installed 1.xx.0, should it have created the toolchain 1.xx.0 or should it be called 1.xx still -- if it's the latter, would a later rustup update be expected to see if 1.xx.1 is available?
All in all I think this should be closed - the error message is now good enough and the behaviours suggested are problematic in terms of expectation meeting.
@upsuper if you a good idea of a workup for unsurprising (intuitive) UX for this, please open a fresh issue detailing it as an enhancement request.

I think a good start would be just say "maybe you mean 1.24.0", it would at least reassure user that it does indeed support installing a specific version, rather than leaving them doubt their impression.
The error message still seems to be just

error: invalid toolchain name: '1.24'

which I don't think it can be said "good enough". It's like rustc telling user that there is an error in their code without telling them where it is.

@upsuper if you a good idea of a workup for unsurprising (intuitive) UX for this, please open a fresh issue detailing it as an enhancement request.

I think I have made several suggestions in this post, and don't think it makes sense to open a new one for mostly the same issue. If you insist that this is not a problem, I'm not going to argue.

Your point that it doesn't help the user is well received.  I will see if I can improve matters a bit...

@upsuper It'd be super-handy if you could look at the examples on #2117 and tell me if that'd be good enough

Thanks for the PR.
I didn't think about even checking the named channels, but it indeed makes sense. The suggestion for x.y.0 should be good enough to inform user what to try, although I guess the wording could probably be bikeshedded a bit.

I want to avoid bikesheds until someone actively complains :D  I'll take that as an approval assuming the CI passes, thank you.


The 'or' expression does not evaluate parameters passed in correctly in certain cases

When using the or expression, it does not evaluate parameters that are passed in correctly in certain cases.
For example, there are two Boolean parameters:
parameter1 = False
parameter2 = False
when using
or(parameter1, parameter2)
it will result in True, even though it is expected to result in False
I printed the parameters individually and also did comparisons to test
eq(parameter1, 'false')
eq(parameter1, 'False')
eq(parameter1, False)
will all evaluate to True, and
eq(parameter1, 'true')
eq(parameter1, 'True')
eq(parameter1, True)
will all evaluate to False
so when using
or(eq(parameter1, 'true'), eq(parameter2, 'true'))
it will result with the correct Boolean False

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 77c58a78-a567-e99a-9eb7-62dddd1b90b6
Version Independent ID: 680a79bc-11de-39fc-43e3-e07dc762db18
Content: Expressions - Azure Pipelines
Content Source: docs/pipelines/process/expressions.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@ydu34 -- Yu, thank you for your research and feedback.  That article states:

or

Casts parameters to Boolean for evaluation

@juliakm -- Julia, is the following relevant to Yu's Boolean literals?  That is, are they mistakenly viewed as strings?

String

To Boolean: '' (the empty string) → False, any other string → True

Any non-empty string, whether 'True' or 'False' or any variation, is cast to a Boolean True.

@WilliamAntonRohm Yes, my guess here is that they are running into the constraint that all variables are really strings.
@ydu34 Are you working with parameters or variables in these examples?

Closing issue after no response for 2 weeks.


Add tests for fragment and other misc changes

This is adds some tests for fragment(all the babel stuff is at ❤ 😍 🎉 100%🎉😍 ❤  coverage) and a few other things...

make the function in the styled call anonymous
make the function in the fragment call an anonymous function instead of an arrow function so it's the same as styled
remove the call to styled if there are no styles(technically it's only if the hash is 0 so if there's whitespace the call to styled won't be removed(would it be a good idea to remove whitespace before hashing?))
run prettier on test, example and jest-utils
there were two dashes when fragments didn't have a name(e.g.frag--somehash), this fixes that
[ ] Make inline and fragment the same function (this broke a test)

Should all classes have the css- prefix?
Also, now this doesn't convert calls to css, was that intentional or is it cool if I add that?

Codecov Report

Merging #20 into glam-merge will increase coverage by 8.1%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           glam-merge     #20     +/-   ##
============================================
+ Coverage        70.1%   78.2%   +8.1%
============================================
  Files              11      11
  Lines             388     390      +2
  Branches           70      71      +1
============================================
+ Hits              272     305     +33
+ Misses             93      67     -26
+ Partials           23      18      -5

Impacted Files
Coverage Δ

src/inline.js
100% <ø> (+55.31%)
:arrow_up:

src/babel.js
100% <100%> (+12.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7874b...b4b384a. Read the comment docs.

yeah all classes should have the same prefix, this will make SSR hydration simpler when we get to it.
please add back the code for css calls :)

@threepointone totally my fault css isn't being transformed. I think @mitchellhamilton can just copy and paste the fragment code and add another branch to the if/else to transform this. Especially since he has generalized the inline function.


It's taking forever to load on iPad and iPhone

I noticed that the audio files used with Plyr is taking a really long time on devices like iPad and iPhone compared to the browser. Is there some extra configuration that I didn't see in the documentation? Or is it possible to add some sort of loading maybe?

Given it's just a thin layer on top of the native HTML5 player, it shouldn't really effect loading. It's also loading pretty much instantly for me on https://plyr.io other than the ads. If it's buffering, there's a loading state.


Timeline::compact_with_gc must honor Tenant::gc_block

After looking through, I cannot see why this could be dangerous considering timeline ancestor detach. Regardless, as Timeline::gc_lock is obtained we also need to check that Tenant::gc_block.start() returns an Ok(_), which should be held on for the execution of compaction.
Related: #8002

looking at the code, it seems that the gc_block is tenant level instead of timeline level. thinking about ways to integrate it...


[BB Bug]: Digital Twin in wrong Functional Cluster

Contact Details
<EMAIL_ADDRESS>Layer
AppLayer
Functional Cluster
FC Virtualization
BB name
Digital Twin
Problem Description
Wrong Functional Cluster, discuss better one

Some ideas:

digital models may be placed under BB-MU | Building Block Mockup Unit (In-Vehicle / On-Board Component) or BB-CSC | Building Block Cloud Stack Component (Cloud / Off-Board) depending on the system they model. They can be understood as a functional digital mockup unit. "A digital mockup is the digital description of a product" (source) and a functional digital mockup extends a digital mockup with a model of the product's behavior (source). Since mock up units / digital models could also be understood as Engineering & Support Tools, there is some ambiguity in their categorization.
digital shadows may be placed under BB-SC | Building Block Stack Component (In-Vehicle / On-Board) if they run in the vehicle or under BB-CSC | Building Block Cloud Stack Component (Cloud / Off-Board) if they run in the cloud / off-board. Alternatively, the distinction could be made based on the nature of the component they are shadowing, rather than their operational environment.
digital twins may also be placed under BB-SC | Building Block Stack Component (In-Vehicle / On-Board) if they run in the vehicle or under BB-CSC | Building Block Cloud Stack Component (Cloud / Off-Board) if they run in the cloud / off-board. Similar to digital shadows, the distinction could be made based on the nature of the component they are a twin of, rather than their operational environment.

Thanks for your concerns, we will include this topic in the next discussion and keep you updated.

Here is another source for Digital Twins: from the Digital Twin Consortium
Quotes from their definition:
Digital Twin Consortium Definition
Below, please find the Consortium’s digital twin definition:
A digital twin is a virtual representation of real-world entities and processes, synchronized at a specified frequency and fidelity.

Digital twin systems transform business by accelerating holistic understanding, optimal decision-making, and effective action.

Digital twins use real-time and historical data to represent the past and present and simulate predicted futures.

Digital twins are motivated by outcomes, tailored to use cases, powered by integration, built on data, guided by domain knowledge, and implemented in IT/OT systems.

The foundational elements of the definition are captured in the first sentence: the virtual representation, the real-world entities and processes it represents, and the mechanism by which the virtual and real-world entities are synchronized.
Source: https://www.digitaltwinconsortium.org/2020/12/digital-twin-consortium-defines-digital-twin/
Digital Twin Consortium is part of the Object Management Group®.

The current description of this BB is currently here

we suggest to add the definition of the Digital Twin Consortium as mentioned by Mario to the BB description,  as it represents the consolidated view of many in the industry. -> Lukas
we need to add this definition to the glossary (which by itself should be hosted on GitHub). The glossary is currently in deliverable D2.x --> Mario
we ask the author of this BB (Conti - @Phil0046 ) to refine its requirements. Then we can decide if it's a

digital twin
digital model
digital shadow

There is mistake in definition as a BB-SC element of the Middleware. This Building Block as Digital Twin (correct definition) shall be place in the Cloud (BB-CSC).
@madri2 Il propose to delete this BB-SC or to move it in BB-CSC. Are you OK ?

There is mistake in definition as a BB-SC element of the Middleware. This Building Block as Digital Twin (correct definition) shall be place in the Cloud (BB-CSC). @madri2 Il propose to delete this BB-SC or to move it in BB-CSC. Are you OK ?

I can't agree with categorizing the Digital Twin (or model) as a cloud element. For the purpose of Shift2SDV, the digital twin or model (depending on whom you ask) has the ability to generate target code, which would be directly placed in the Middleware. For example, we can create a formal model of business logic that can be easily simulated in various environments (including the cloud), but in the end, we generate code that represents the exact implementation/behavior of the model or digital twin. The same applies to Matlab/Simulink when generating target code using the Embedded Coder Toolbox

From Continental perspective it is a mistake for a MW service embedded in the vehicle for related vehicle control. The initial proposal what in the mindset of digital twins in cloud.
By the way, if you generate vehicle control code from your model (Matlab/Simulink embedded coder the service used to generate the code is a tool block and not a middleware vehicle embedded service, as you may decide offline that you model is ready as it has been validated (usually in the cloud, but code can be a code shadown embedded in the vehicle, where also off line you will make the decision to replace another control code as the new active one). The service used to make this code active by applying patch in embedded vehcile software will be performed throught OTA reproraming service, in order to master and security sign  what is the real software embedded in the vehicle.
If the code is an apps to be uploaded in the "protected non safety part of the vehicle", may be a different use case,  mastering of the software active is still required and OTA reprog services shall also be used (to garantee overall control of software uploaded).
But may be you have a different view (or use case) and to my eyes the naming "digital twins" missleading and shall be improved.

Status from WP2 meeting on 29-AUG-2024: Philippe (Conti) and Karol (Verum) both will provide definition for DigitalTwin.
If this leads to two sperate BB's, we will create them and attach definitions; otherwise it will be merged into the existing one (currently in MW layer)

From Continental perspective it is a mistake for a MW service embedded in the vehicle for related vehicle control. The initial proposal what in the mindset of digital twins in cloud. By the way, if you generate vehicle control code from your model (Matlab/Simulink embedded coder the service used to generate the code is a tool block and not a middleware vehicle embedded service, as you may decide offline that you model is ready as it has been validated (usually in the cloud, but code can be a code shadown embedded in the vehicle, where also off line you will make the decision to replace another control code as the new active one). The service used to make this code active by applying patch in embedded vehcile software will be performed throught OTA reproraming service, in order to master and security sign what is the real software embedded in the vehicle. If the code is an apps to be uploaded in the "protected non safety part of the vehicle", may be a different use case, mastering of the software active is still required and OTA reprog services shall also be used (to garantee overall control of software uploaded). But may be you have a different view (or use case) and to my eyes the naming "digital twins" missleading and shall be improved.

From my perspective, the Digital Twin within the "G1: Digital Twin for vECU" building block in Shift2SDV is a part of the software development environment. In this context, the Digital Twin can act as a platform-agnostic model that implements requirements and specifications. It can then be used for verification and validation activities, testing, running complex simulations (HIL, SIL, CPU emulation, middleware integration), and all shift-left activities. Ultimately, this Digital Twin serves as the source of the target code, which can be deployed via OTA update services.
In the context of Shift2SDV, our plan is to offer a cloud-based environment for Digital Twin-driven development. While it aligns with cloud-based development practices, I’m uncertain if it fits neatly into any specific cloud category BB.

Hi Karol
I do agree with your definition for a Cloud based environment with set of services to build and execute a Digital-Twin model.
My proposal for as Digital Twin (proxy) BB was very narrow, others services would be required that would be detailed in Shift2SDV.
So my proposal would be to rename the actual BB from BB-SC-TC as "Digital Twin proxy in Cloud" and to move it to BB-CMU category.
But it shall be aligned with Shift2DV forecoming project.
Does this new proposal fit Shift2DV BB definition plan ?
Shall this "proxy" BB be embedded to broader BB from BB-CMU that you already defined in Shift2SDV (and  that embeds proxy features) ?

was taken care of in #28


Package ExtensionsMetadataGenerator also required

I added Microsoft.Azure.Functions.Extensions package to an existing function app that didn't also include the package Microsoft.Azure.WebJobs.Script.ExtensionsMetadataGenerator.
In debug everything compiled and started without error but the function failed when invoked with a DI error. After adding the package it ran the Startup.Configure method and started working, not sure if this d should be added in the docs or the extensions package itself.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5786402e-9d88-5de0-607a-1c2a143af006
Version Independent ID: 15368d1c-b22e-7eb2-413f-cc0d41d2b909
Content: Use dependency injection in .NET Azure Functions
Content Source: articles/azure-functions/functions-dotnet-dependency-injection.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: jehollan

@marctalary Thanks for the feedback. We are currently investigating into the issue and will update you shortly.

@cgillum Any inputs regarding this.

@cgillum Just following up again in case missed the previous communication.

@marctalary I have assigned this to content author to review and update as appropriate.

I think, deployed or published version of Azure Functions failed to execute the dependency injection.
Unable to resolve service for type 'AzureFunctionPoc.IService' while attempting to activate 'AzureFunctionPoc.Hello'.

It seems that the project (csproj) must not directly reference the package Microsoft.Azure.WebJobs.Script.ExtensionsMetadataGenerator
See https://github.com/Azure/azure-functions-host/issues/3386#issuecomment-497492442

@marctalary - What project type are you using? Any Azure Functions project already includes a reference to this package by default
cc: @fabiocav, @brettsam

Probably an upgraded older one.  I would have still expected it as a dependency or reference to it in the docs.


Add a ToList() method

Add a ToList() method that converts the NonEmptyEnumerable to a List.

ToList is implemented as apart of Linq extension methods. There is not need to implement it again.


Bug: Mjx-over pushes down stacks out of line with surrounding text at certain sizes

Issue Summary
There are some vertical alignment problems with mjx-stack elements at different sizes. I've reproduced this in a CodePen, linked below.
Steps to Reproduce
View this CodePen: http://codepen.io/barillax/pen/mrNxPR
Notice that at various sizes, the hat, bar, acute, and dot'ed elements may align or not align with the surrounding text. I suspect this inconsistency extends to more mjx-underover pairs, but I haven't tested further.
In the word depósito, there also appears to be too much space to the right of the ó, but that might be better classified as a separate bug.
Technical details

MathJax Version: 2.7.0
Client OS: macOS Sierra 10.12.1
Browser: Chrome54.0.2840

I believe this is the same issue as #1498.  This is a WebKit bug in rounding up the size of the stack without adjusting the top position to accommodate it.  I do not know of a work-around.

Closed as duplicate.


Calling get_flag in dependencies results in a fatal error and exit

What happened?
I have a project that has a hierarchical structure.
Devspace throws a fatal error when using get_flag function in a dependency, eg.:
❯ cd main-project
❯ devspace deploy

info Using namespace 'devspace'
info Using kube context 'docker-desktop'
sub-project couldn't find flag profile
fatal exit status 1
(main project depends on sub-project)

This works fine if I deploy the sub-project directly:
❯ cd sub-project
❯ devspace deploy

info Using namespace 'devspace'
info Using kube context 'docker-desktop'
Ensuring image pull secret for registry: hub.docker.com...
build:sub-project Rebuild image sub-project because tag is missing
build:sub-project Building image 'sub-project:AqMuzV' with engine 'buildkit'
build:sub-project Execute BuildKit command with: docker buildx build --tag sub-project:AqMuzV --file Dockerfile -
build:sub-project Sending build context to Docker daemon  6.656kB
... snip docker output ...
build:sub-project Done processing image 'sub-project'
deploy:sub-project Deploying chart /Users/bernard/.devspace/component-chart/component-chart-0.8.5.tgz (sub-project) with helm...
deploy:sub-project Deployed helm chart (Release revision: 1)
deploy:sub-project Successfully deployed sub-project with helm

The relevant sections on both projects look like this:
pipelines:
  deploy:
    run: |-
      # this fails or not depending from where deploy is called
      profiles=$(get_flag "profile")

      run_dependencies --all
      build_images --all -t ${DEVSPACE_RANDOM}
      create_deployments --all

In the example I have used profile, which is global, but it also fails if I try to read deploy-specific flag like build-sequential eg:
❯ devspace deploy
info Using namespace 'devspace'
info Using kube context 'docker-desktop'
sub-project couldn't find flag build-sequential
fatal exit status 1

What did you expect to happen instead?
I expected deployment to work and if flag was set, I would like to see its value in dependency pipeline
How can we reproduce the bug? (as minimally and precisely as possible)
repro here: https://github.com/gustaff-weldon/devspace-dependency-flags
Local Environment:

DevSpace Version: 6.2.1
Operating System: mac
ARCH of the OS: AMD64
Kubernetes Cluster:
Local: Docker Desktop
Kubernetes Version: v1.25.2

Anything else we need to know?

@pratikjagrut is there any progress on this? This issue causes devspace to fail when deploying with dependencies...

@lizardruss I'm still getting this error in 6.2.5 using my reproduction repository (linked in description): https://github.com/gustaff-weldon/devspace-dependency-flags

Ok, looks like the fix has not been released in 6.2.5 https://github.com/devspace-sh/devspace/compare/v6.2.0...v6.2.5


fix: ui-background not setting the region rect and not hiding display:none

fix: ui-background not setting the region
fix: not hiding display:none
use Headers object in the fetch response

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (c249172) 48.33% compared to head (47c0f48) 48.36%.

Files
Patch %
Lines

...d-godot-lib/src/godot_classes/dcl_ui_background.rs
9.52%
19 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   48.33%   48.36%   +0.02%
==========================================
  Files         141      141
  Lines       17161    17169       +8
==========================================
+ Hits         8294     8303       +9
+ Misses       8867     8866       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Leaving BaseButton.shortcut_feedback enabled raises errors when a button is removed from the scene tree

Godot version
v4.2.beta2.official [f8818f85e]
System information
Godot v4.2.beta2 - KDE neon 5.27 22.04 - X11 - Vulkan (Forward+) - integrated AMD Radeon Vega 11 Graphics (RADV RAVEN) () - AMD Ryzen 5 3400G with Radeon Vega Graphics (8 Threads)
Issue description
Using a button with a shortcut resource and shortcut_feedback set to true raises errors in the debug console if the node is being removed from the scene tree.
I'm attaching a project reproducing the error that uses SceneTree.change_scene_to_file() to trigger the issue.
The following line shows up in the debugger when you hit Enter:
E 0:00:01:0012   start: Timer was not added to the SceneTree. Either add it or set autostart to true.
  <C++ Error>    Condition "!is_inside_tree()" is true.
  <C++ Source>   scene/main/timer.cpp:109 @ start()

Looking through Godot's source code, BaseButton::shortcut_input instantiates a Timer node that is started, but the condition to determine if the button node is leaving the tree is not checked:
// void BaseButton::shortcut_input(const Ref<InputEvent> &p_event) {
if (shortcut_feedback) {
    if (shortcut_feedback_timer == nullptr) {
        shortcut_feedback_timer = memnew(Timer);
        shortcut_feedback_timer->set_one_shot(true);
        add_child(shortcut_feedback_timer);
        shortcut_feedback_timer->set_wait_time(GLOBAL_GET("gui/timers/button_shortcut_feedback_highlight_time"));
        shortcut_feedback_timer->connect("timeout", callable_mp(this, &BaseButton::_shortcut_feedback_timeout));
    }

    in_shortcut_feedback = true;
    shortcut_feedback_timer->start();
}

Leaving shortcut_feedback unchecked solves the issue.
Testing the project under Godot 4.0 and 4.1 raises no errors.
Steps to reproduce

Add a button node to a scene
Add a shortcut resource to it (be sure shortcut_feedback is enabled)
Have the user interact with the button by its shortcut
Use remove_child to remove the button node after button is pressed

Minimal reproduction project
button-shortcut-feedback-bug.zip

When press Enter, NOTIFICATION_EXIT_TREE arrives earlier than call_shortcut_input, so the timer started after the node left tree and thus caused this bug.


Reuse Component in FIORI elements

Issue description

Hi Team,
We are working with flexible model or using the reuse the components in fiori elements. unfortunately not able to find the right documents. the customer want to apply the reuse the components in fiori elemets.
Feedback Type (Optional)
examples or samples
Page Title on SAP Help Portal (prefilled)
How to Use the Fiori Reuse Library
Page URL on SAP Help Portal (prefilled)
https://help.sap.com/docs/btp/sap-business-technology-platform/how-to-use-fiori-reuse-library

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

Hi there 👋 There's been no activity on this issue for a while, so we're closing it. If you've further information to provide, please comment below and add that information. We'll review it and reopen the conversation if necessary. Until next time, thanks!


Adapter Support For the Longformer family

🚀 Feature request

Adapter Support For the Longformer models
Motivation
For question-answering over long documents, especially when the answers are long (surpass the 384 or 512 max sequence length supported by other LMs e.g. BERT, RoBERTa... It is impossible for users to get the correct answers...
So it seems necessary for us to use longformer or bigbird models which accept longer input sequences... however longer sequences will lead to a increase of fine-tuning computation..
I read the paper about adapter-transformer and I found this solution to be elegant and perfectly mitigate the problems of long-answer question answering.
Unfortunately, there is not yet a support in the adapter library the supports for longformer architecture. I would like to ask if you are planning a support for the longformer models?
Thanks : )

mentioned in #442

I agree, this would be quit useful!


Pin down dependency versions and ghc version

Currently the repo doesn't specify which compiler version and dependency versions to use to build sensei and run the test suite. I tried running the test suite and it fails with newer ghc versions, since the tests expect a certain format of ghc error messages, but those have changed. (The travis file specifies ghc-7.10, btw.) Given that this package provides a list of executables and no library there should be no downside in fully pinning down the compiler version and all dependencies.
What do people think about adding a stack.yaml file?
cc: @sol @amarpotghan @qoelet

I certainly see no harm in taking that approach, pending @sol 's input.

Oh, I realized I was still on tag 0.3.0. 0.4.0 works with newer compilers. I'd still prefer having a stack file, but feel less passionate about that now.

https://github.com/hspec/sensei/blob/main/.github/workflows/build.yml ensures that sensei works with recent compilers.  We also have a daily schedule so that we detect breakage in a timely manner.
Closing.

https://github.com/hspec/sensei/blob/main/.github/workflows/build.yml ensures that sensei works with recent compilers.  We also have a daily schedule so that we detect breakage in a timely manner.
Closing.


Disable TSError underline in terminal

The issue
Whenever treesitter fails to parse some program, the errors are highlighted using underlines. This is especially annoying when the code is valid, but treesitter does not recognize it. Here is an example where treesitter highlights ~80 lines of valid C code and the theme adds an underline to all of that:

This is annoying because it becomes difficult to differentiate between i and j, for example, when it's underlined. It generally makes it much harder to edit by underlining multiple lines.
Possible solution
I temporarily solved this by removing gui=undercurl from the TSError highlight group in the compiled melange.vim file.
highlight TSError guifg=NONE guibg=NONE guisp=NONE gui=undercurl blend=NONE

to
highlight TSError guifg=NONE guibg=NONE guisp=NONE blend=NONE

In the lush code, I think the change would be removing this:
https://github.com/savq/melange/blob/aebc5256c8804ebad66676ab9ab591bed53170d9/lua/melange/init.lua#L261
Thoughts?
Is this an appropriate solution for this problem?

Thank you for making this theme, I've been using this for some time now and really liked it :heart:

Yeah, I'll probably be removing that soon.
For some grammars, error nodes behave nicely and highlights can be very informative, but for others the error nodes keep spreading and it becomes pretty useless.
I also noticed while having to read preprocessor heavy code 😅. It was so bad I made a note in the nvim-treesitter docs.

In the mean time you can add the following to your config:
augroup melange_fix
    au!
    au ColorScheme melange highlight! clear TSError
augroup END

That temporary fix works, thanks!


Build error: 'React/RCTDynamicTypeRamp.h' file not found

Environment
react-native -v: 0.68.56
xcodebuild -version: 14.0.1

Steps to reproduce the bug
Build using xcode
macos/Pods/Headers/Public/React-Core/React/RCTTextAttributes.h:11:9: error build: 'React/RCTDynamicTypeRamp.h' file not found

@amgleitman Could you help?
@k1mmm Have you tried doing a clean pod install / build?

I reinstalled xcode and now its working, might be the pod install och clean build folders failed when i tried it earlier or something. I'll close this, thanks!


Add go.mod file declaring proper semantic import path

As the latest version is tagged as v2.x.x in git, using the package as a Go module will require importing it as github.com/patrickmn/go-cache/v2, otherwise it will show up as:
github.com/patrickmn/go-cache v2.1.0+incompatible

in a dependent's go.mod.
See: https://github.com/golang/go/wiki/Modules#semantic-import-versioning
I know it's not pretty and introduces more things to maintain manually, but apparently it's what is supposed to be done in this context.

Unless I'm mistaken, if I merge this PR, the vast majority of people using Go 1.11 will suddenly revert to go-cache 1.0.0, something that's totally unnecessary and would decrease performance, all because of a tiny API difference in a corner nobody touches.

I don't think it'll be the vast majority right now as with Go 1.11 the module behavior is still opt-in (you have to work outside GOPATH or do GO111MODULE=on), so it should only hit people who do actively migrate. I would assume though that Go 1.12 turns on modules by default, so the issue you describe will most likely become an annoyance for everyone in 6 months time. So, yeah.

Is there a way to tell go mod to use 2.0.0 as the default?

I couldn't find anything on this topic. This is what go help modules will tell us about the situation (which leaves me wondering what the right thing to do is and what the actual implications of +incompatible can be):

Code written before the semantic import versioning convention
was introduced may use major versions v2 and later to describe
the same set of unversioned import paths as used in v0 and v1.
To accommodate such code, if a source code repository has a
v2.0.0 or later tag for a file tree with no go.mod, the version is
considered to be part of the v1 module's available versions
and is given an +incompatible suffix when converted to a module
version, as in v2.0.0+incompatible. The +incompatible tag is also
applied to pseudo-versions derived from such versions, as in
v2.0.1-0.yyyymmddhhmmss-abcdefabcdef+incompatible.

This is a similar issue in another repo I found: https://github.com/gofrs/uuid/pull/44
Maybe it's best not to merge this now (as there are no pending updates from what I understand) and keep an eye on how other package authors / the community starts dealing with the problem at hand.

Thank you for the info.
I wish they'd gone with "nomod" or something over "incompatible". It makes it sound like go-cache is broken now.

Yeah the naming is very unfortunate as it implies something is not working as intended. Anyways...


[Feature][Infra] Data Retention/Size Limit

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
The old data accumulates and exceeds my DB size. I want DevLake to have the ability to (automatically) remove the old data (regularly).
Description
Questions:

DB Size limit, what if I collect a lot of commits/issues, etc.
Time to store DB (time to collect or time that records get updated in the data source?)
What's the backup plan if DevLake accidentally deletes data due to bugs?
What's the backup plan if users accidentally delete data?

Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This issue would be awesome.
I believe we could have some type of "Job" to delete data older than 6 months? Were there any discussion of this in the past?

@Feggah  Not really, just some rough ideas.

For (3), we could perform soft deletes instead of hard deletes from our code. And just have a cron job to hard delete the entries once in a while. This way if data is accidentally deleted, it's still in the DB for a while and it can be restored.


Faster block_diag when blocks are equally shaped

Inspired from Severin Holzer-Graf : http://scipy-dev.scipy.narkive.com/wIFaUvms/sparse-block-diag-improvement
Vastly improve performances for small and big matrices

pep8 checker isn't completely happy yet - you can check locally with $ pep8 scipy/ benchmarks/benchmarks/

I haven't read through the proposed changes fully yet, but how does this differ from scipy.sparse.block_diag?

Not sure how the previous version work.
Here, I just increase the row and col of each new matrix of an offset that is the sum of all the previous matrices (origin)
Pretty straightforward.
Block_diag relies on bmat, and I guess it is a more general way of building sparse that cannot leverage on the fact that all block are aligned on the diagonal

Probably also needs some additional tests, to ensure the new code paths are covered.

@pascal-schetelat do you have time to add some tests and finish up this PR?

Yes. I might find some time by next week end to refactor it and add the tests.

Should I make a separate PR for the additional benchmark?
I started to work on them based on similar exemple but I might need some guidance...

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

@perimosocordiae :  is there anything missing to merge this PR?

@pascal-schetelat are you still interested in this? This looks close to ready, but there are a number of review comments to address still.

Yes I am, just need time to get back to it.

@pascal-schetelat would it be possible to get this merged some time? :P

Once gh-12356 is merged, we should re-evaluate this PR.

This PR is approaching its seventh birthday and has been inactive for more than two years. I hope it gets to move forward soon, but since performance improvements aren't typically considered "release blockers" I'm going to bump the milestone to keep the release checklist a bit more clear.


Added footer to Learnings page

Added a footer to the Learnings page looks like this.

@komalioruganti can you Resolve conflicts


Run statement changes is incorrect in browsers

Describe the bug
When running an update statement like const res = await database.run('UPDATE table SET x = ? WHERE y = ?', [2, 1], false);, the variable res.changes.changes is always 0 in the browser. When running on a device (I tested it on iOS), the variable is different from 0 and reflects the actual changed rows of the request.
To Reproduce
Run following code with the @capacitor-community/sqlite plugin in the browser:
const res = await database.run('UPDATE table SET x = ? WHERE y = ?', [2, 1], false);

console.log(res.changes.changes);

Expected behavior
I expect the res.changes.changes to be different from 0 when there were changes made.
Desktop (please complete the following information):

OS: Windows 10
Browser: Edge (Chromium-based) / Firefox
Version: 110.0.1587.46 / 109.0.1

Smartphone (please complete the following information):

Device: iPhone 11 Pro Max
OS: iOS 16

Additional context
n/a

@mtnair i will have a look thanks

@mtnair
Well i could not reproduce.
i have added a test in test2dbs.page of angular-sqlite-app-starter lines 108 to 113 and as you will see ret378.changes.changes return 1 which is correct.
Can you share a replicate of your app just demonstrating the problem on github , check also your code

@mtnair Any progress on your side ?

@mtnair No feedback so i close the issue. feel free to reopen it if required


feat: optimize the pod labeling

What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:

As title.

Checklist

[x] I have written the necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Please take note of the CI failures


Import Kafka security packages

Import Kafka security packages for logging to secured Kafka broker

May I ask you @jdmcmahan to create this PR against new main branch?

Sorry, looks like I forgot to my forked repo. I've created #401 instead. Thanks!