Publish to Heroku is broken: "WARNING:  You must pass the application as an import string to enable 'reload' or 'workers"

2019-11-13T16:27:59.821483+00:00 heroku[web.1]: Starting process with command `datasette serve --host <IP_ADDRESS> -i fixtures.db --cors --port 36817 --inspect-file inspect-data.json`
2019-11-13T16:28:01.856471+00:00 heroku[web.1]: State changed from starting to crashed
2019-11-13T16:28:01.750253+00:00 app[web.1]: Serve! files=() (immutables=('fixtures.db',)) on port 36817
2019-11-13T16:28:01.771524+00:00 app[web.1]: WARNING:  You must pass the application as an import string to enable 'reload' or 'workers'.
2019-11-13T16:28:01.837839+00:00 heroku[web.1]: Process exited with status 1

The problem is this code in uvicorn: https://github.com/encode/uvicorn/blob/020dd085a0a5b609f14ddd2b36fc0a97ba4df019/uvicorn/main.py#L297-L302
    if (config.reload or config.workers > 1) and not isinstance(app, str):
        logger = logging.getLogger("uvicorn.error")
        logger.warn(
            "You must pass the application as an import string to enable 'reload' or 'workers'."
        )
        sys.exit(1)

From this commit 4 days ago: https://github.com/encode/uvicorn/commit/b034f7a136c5e57a33ffd10ce2404cc1faee9033 - see Uvicorn https://github.com/encode/uvicorn/issues/478 and https://github.com/encode/uvicorn/pull/481
This is breaking because --workers "Defaults to the $WEB_CONCURRENCY environment variable  if available" - and it turns out on Heroku WEB_CONCURRENCY is set to 2 by default!

Short term fix: set --workers=1 when publishing with Heroku.

Using the Heroku web interface, you can set the WEB_CONCURRENCY = 1


Fix gojsonschema vendoring

Dependencybot only bumped the gopkg.toml and not the vendored code.
Fix #626
- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-gojsonschema-vendoring" git@github.com:silvin-lubecki/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Change for SSH access to GitLab repos

@sherl0cks FYI - porting change for allowing SSH access to GitLab repos

@oybed how are you planning to expose SSH in OCP, using NodePort?


In-memory Engine: sysbench oltp_read_write fails with "assertion failed"

Bug Report

[ 1260s ] thds: 1000 tps: 3672.80 qps: 66135.79 (r/w/o: 51438.80/14696.30/0.70) lat (ms,95%): 390.30 err/s: 0.20 reconn/s: 0.00
[ 1270s ] thds: 1000 tps: 3205.40 qps: 57609.17 (r/w/o: 44821.78/12787.09/0.30) lat (ms,95%): 450.77 err/s: 0.00 reconn/s: 0.00
[ 1280s ] thds: 1000 tps: 3209.40 qps: 57767.83 (r/w/o: 44928.03/12839.21/0.60) lat (ms,95%): 458.96 err/s: 0.20 reconn/s: 0.00
[ 1290s ] thds: 1000 tps: 3478.40 qps: 62660.73 (r/w/o: 48731.32/13929.31/0.10) lat (ms,95%): 397.39 err/s: 0.10 reconn/s: 0.00
[ 1300s ] thds: 1000 tps: 3507.80 qps: 63581.76 (r/w/o: 49465.57/14043.39/72.80) lat (ms,95%): 434.83 err/s: 25.00 reconn/s: 0.00
[ 1310s ] thds: 1000 tps: 3599.40 qps: 66926.87 (r/w/o: 52164.08/14412.19/350.60) lat (ms,95%): 434.83 err/s: 122.10 reconn/s: 0.00
[ 1320s ] thds: 1000 tps: 3425.52 qps: 63356.70 (r/w/o: 49359.23/13674.96/322.50) lat (ms,95%): 475.79 err/s: 107.10 reconn/s: 0.00
FATAL: mysql_stmt_execute() returned error 8141 (assertion failed: key:<PHONE_NUMBER>0000006b5f69800000000000000103800000000601a076038000000005f2dc36, assertion: Exist, start_ts:<PHONE_NUMBER>48712779, existing start ts:<PHONE_NUMBER>33691943, existing commit ts:<PHONE_NUMBER>46799677) for query 'DELETE FROM sbtest1 WHERE id=?'
FATAL: `thread_run' function failed: /usr/share/sysbench/oltp_common.lua:497: SQL error, errno = 8141, state = 'HY000': assertion failed: key:<PHONE_NUMBER>0000006b5f69800000000000000103800000000601a076038000000005f2dc36, assertion: Exist, start_ts:<PHONE_NUMBER>48712779, existing start ts:<PHONE_NUMBER>33691943, existing commit ts:<PHONE_NUMBER>46799677

What version of TiKV are you using?

v8.1.0-20240621-c57aef1 https://github.com/tikv/tikv/tree/v8.1.0-20240621-c57aef1
What operating system and CPU are you using?

No assertion failed.
What did happened?
assertion failed.

In the past month, we've run extensive sysbench tests, and the bug has not reoccurred.


Missing entry-point, although it is configured in the paeckchen.json

Version<EMAIL_ADDRESS>paeckchen.json:
{
  "input": {
    "entryPoint": "dist/index.js",
    "source": "es5"
  },
  "output": {
    "folder": "public/js",
    "file": "app.js",
    "runtime": "browser",
    "sourceMap": true
  },
  "debug": false
}

Command: ./node_modules/.bin/paeckchen
Result:
  cli ERROR Bundeling failed
Error: Missing entry-point
    at createContext (/Users/cleake/Documents/github/hyperlink.one/node_modules/paeckchen-core/dist/src/bundle.js:116:15)
    at /Users/cleake/Documents/github/hyperlink.one/node_modules/paeckchen-core/dist/src/bundle.js:129:23 +0ms

Example setup: https://github.com/clebert/ts-paeckchen-setup

The entry-point in the config must be named 'entry'.
This is currently a bit inconsistent but its not really a bug. I'll considering to rename this option in the config file for release 0.5.0


fix(themes): grid falling part

When resizing the Themes, the grid falls apart.
It is due to the fact that 1fr of grid-cols-[260px_1fr] needs to be minmax(0,1fr).
And there was a typo in the className as well, which was grids-col-2.
I fixed both of the mistakes.
AS-IS

TO-BE

Caught more mistakes and fixed them.
AS-IS

TO-BE


Proposal - allow renaming through the tree-controller

Hi,
I thought it will be really cool to add a method in the tree-controller to transit the node in to renaming state.
So now the user  can add an Edit button and the node changes it's state to beingRenamed.
Please checkout the commit, I think it can be really useful.
If you find it good I will propose a pull request.
Thanks,
TMaster

@TMaster Don't be shy - send a PR :)

Feature was merged :)


Gh 536 make named operation parameters appear in vertical list

Issue #536

I think there has been some miscommunication. The change should be done to the Operation chain builder, not the results table.
Specifically, there is a line in the parameter form which is: <div layout-wrap layout="row">. This line causes it to output as a row, rather than a column.
You can use the title input (which is 'Parameters' for NamedOperation parameters) to determine how to display the list (vertical for NamedOperations, as is for NamedViews).


DataGrid.Columns is not bindable

Describe the bug
Where is no clear way to bind collection of DataGridColumn to DataGrid. Because DataGrid.Columns is not bindable.
To Reproduce
Steps to reproduce the behavior:

Create DataGrid
Create ObservableCollection<DataGridColumn> and fill it with some DataGridTextColumn columns
Try to bind this collection to DataGrid.Columns

 <DataGrid 	Items="{Binding Items}"
			CanUserResizeColumns="True"
			Columns="{Binding Columns}">

See error

The value "Avalonia.Data.Binding" is not of type "Avalonia.Controls.DataGridColumn" and cannot be used in this generic collection. (Parameter 'value')

Expected behavior
Columns collection binding.
Desktop (please complete the following information):

OS: Windows
Version: 0.10.18

Context
I need to sort and store column sorting from code in MVVM app. Because column sorting is not perisistent then i switch between the Views. So i decided to store Columns collection in my ViewModel, in this case, logicaly i could have persistent sorting on columns. But while testing this aproach i find out what there are no clear way to have access to DataGrid.Columns from MVVM context.

I need to sort and store column sorting from code in MVVM app. Because column sorting is not perisistent then i switch between the Views. So i decided to store Columns collection in my ViewModel, in this case, logicaly i could have persistent sorting on columns. But while testing this aproach i find out what there are no clear way to have access to DataGrid.Columns from MVVM context.

Here's a workaround for you.

Have a ColumnViewModel, which has the sort direction and column order for a given column.  Probably some other property to use as a "key",
Have an attached property for DataGrid, where you can set an IEnumerable<ColumnViewModel>

When the value is set, add a behavior to the DataGrid's behavior collection

Have a DataGridColumnCustomizer behavior, that will:

Listen for changes to the Columns collection - When a new column is added to Columns, set its DisplayIndex and sort direction
Subscribe to DataGrid.ColumnDisplayIndexChanged - when a column's display index is changed, set the property on ColumnViewModel

That's the general idea anyway.


ApiParam does not support converters

I am using UUIDs extensively in both my response model as well as part of a REST URL. So, I created the following converter. In the API, I want to treat them as strings rather than the expanded Java object with leastSignificantBits and modeSignificantBits.
class Converter extends ModelConverter with BaseConverter {   def read(cls: Class[_], typeMap: Map[String, String]): Option[Model] = None   override def typeMap = Map("uuid" -> "string")    override def ignoredClasses: Set[String] = Set("java.util.UUID") }
This worked fine for the models. So, my ID field is described as a string. But for an ApiParam, this appears to have no effect. The UUID field is still represented as a full model rather than just a primitive string.

@fehguy this looks like a swagger 1.2 related issue - does it apply to 2.0 as well?

@olensmar correct, this is not a 2.0 issue--it should be fixed in 1.5.x, and in the develop_2.0 branch.


Add 'Drop nth bytes' operation

Added an operation to drop every 2nd, 3rd etc. byte starting at a given byte. Can be applied to each line. Tests included. Added 'Take nth bytes' in #695.

Hey!  This pull request has gotten rather old and that's our fault.  This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust.  Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

Hey, this PR has remained without updates for four weeks now.  I'll close it now, but feel free to re-open if you find time to contribute! 😄


Dash doesn't load on startup

Dev Home version
0.1001.389.0
Windows build number
10.0.22631.3007
Other software
OS Build Version: 10.0.22631.3007.amd64fre.ni_release.220506-1250
.NET Version: .NET 8.0.1
Steps to reproduce the bug
Every time I start the app it just hangs and spins loading the dashboard which simply has a single widget (the CPU widget). Unsure what the app is doing,
Expected result
Uncomplicated dash should load quickly
Actual result
Dash never loaded
Included System Information
CPU: 12th Gen Intel(R) Core(TM) i7-1265U
Physical Memory: 15.83GB (1.72GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome_0.1001.389.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_0.1000.393.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeAzureExtension_0.500.389.0_x64__8wekyb3d8bbwe
9932MartCliment.WingetUIWidgets_<IP_ADDRESS>_x64__g91dtg5srk15g
Widget Service:
MicrosoftWindows.Client.WebExperience_424.1301.40.0_x64__cw5n1h2txyewy

Logs are attached.
DevHome_20240205-094021.zip
I was a little worried I wouldn't be able to reproduce it, but I just hit the same state. This time my dashboard has all four basic widgets (cpu, memory, network, disk) and the issue didn't occur on startup. Instead it occurred when I returned to the dashboard screen after visiting others. Here's a screenshot of my dashboard and the Dev Home process in Task Manager.

Whoops, misunderstood where the logs were. The entire TempState is logs and I uploaded only a fraction. Here's the whole TempState directories
dev-home-azure-TempState.zip
devhome-github-TempState.zip
dev-home-TempState.zip

Thanks for the logs! I was just coming here to say that I saw similar behavior but apparently mine was due to a different scenario. From your logs, it looks like Dashboard isn't recovering from this error (pasted here so I can find again easily):
ERROR: Exception in SubscribeToWidgetCatalogEvents:
System.Runtime.InteropServices.COMException (0x800706BA): The RPC server is unavailable.

The RPC server is unavailable.

   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at WinRT.EventSource`1.Subscribe(TDelegate del)
   at DevHome.Dashboard.Views.DashboardView.SubscribeToWidgetCatalogEventsAsync()

Changing the name of this one, so I can differentiate from #2252


Remove references to the deprecated trio.ssl

Fixes #102

Pull Request Test Coverage Report for Build 22

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 91.971%

Totals

Change from base Build 19:
0.2%

Covered Lines:
378

Relevant Lines:
411

💛  - Coveralls

I guess we need to merge this and then do a release ASAP, because right now trio-websocket is crashing on import for any install that doesn't have trio pinned :-(

Thank you! I have just published version 0.6.0 containing this PR.

Thanks, and sorry about the breakage!


Incendiary projectiles and lava firestack reduction

About the PR

This PR reduces all firestacks applied by incendiary projectiles and lava.
It also doubles the amount of pellets in the incendiary grenades because of the individual projectiles not having an aoe effect anymore(the reason why they had less pellets to begin with) and their firestacks being heavily reduced.
Should fix #23421
Why / Balance

The recent changes to fire damage made incendiary weapons kill way too fast because of the amount of firestacks applied.
For example: the incendiary pellets from the shotgun each applied 1 firestack, this PR lowers that to 0.25, and even after these changes someone without armor that does not drop and roll will have taken 98 damage(someone who does immediatly drop and roll 70) if they get hit by all the pellets from 1 shot. Currently on master this would deal well above 200 damage, and even if someone starts rolling immediately they will be crit before the fire goes out.
New firestack amount for lava will make a human in a spationaut suit that grazes the lava and instantly drops and rolls take around 55 damage. If someone decides to stay inside the lava for at least 2-3 second(and drops and rolls immediatly after leaving), or instantly leaves but only start rolling after 3-4 seconds they will still go crit before they get rid of the fire.
Projectiles using IgniteOnCollide would also ignite people that weren't hit because of them igniting entities colliding with their fly-by fixture,. This PR adds a check that prevents entities igniting from collision with the fly-by fixture of a projectile.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Dygon

tweak: Incendiary projectiles and lava are less flammable.
fix: Incendiary projectiles no longer ignite entities while flying past them.
fix: Flare shells now ignite again.

I remember flare shells igniting people and it still had the IgniteOnCollide component, so I made them ignite people again.
Or was this an intended change and someone just forgot to remove the IgniteOnCollide?

I remember flare shells igniting people and it still had the IgniteOnCollide component, so I made them ignite people again. Or was this an intended change and someone just forgot to remove the IgniteOnCollide?

It was an intended change.

I remember flare shells igniting people and it still had the IgniteOnCollide component, so I made them ignite people again. Or was this an intended change and someone just forgot to remove the IgniteOnCollide?

It was an intended change.

Currently it does 13 damage if someone starts rolling immediatly and 30 damage if they don't do anything, should I remove it again/lower applied firestacks or is amount of damage fine?


Web Socket Endpoints

A description and example of how to use websocket endpoints in Mendix 8.13

@jds-mendix Here is the PR for the Web Socket endpoints.
Do we need to add a bit more information about where to put this code (e.g. explicitly say somewhere 'create a Java Action') and how to call it? Or is this information clear enough for anyone who is going to be using it?

@MarkvanMents I think that is clear. If it isn't, using web sockets would be a really bad idea. This is a 'low level' / 'advanced' feature.
Btw, in the very last line of the document I believe it should be 'If the client sends ...' not 'If the client send...'.

@jds-mendix Thanks for the response and the proofreading.
See attached image for where it will appear in the documentation.
I've made a couple of minor changes - including correcting the error you spotted. Are you happy for me to publish?


[2.x] Add Def.cacheTaskWithUpdate to update the task output after a cache reuse

After a cache hit of the incremental compilation we need to:

Unzip the jar to the backend output folder to enable incremental compilation.
Update the timestamps. Those timestamps are used by the testQuickFilter to decide which class needs to be rerun.

To do so I introduced:
Def.cachedTaskWithUpdate[A1: JsonFormat](inline a1: A1)(inline onCacheReuse: (A1 => A1)): Def.Initialize[Task[A1]]

The onCacheReuse is only called after a cache hit to update the output. The user can declare any task dependency in onCacheReuse with .value.
Example:
val foo = Def.task(1)
val bar = Def.task(2)
val fizz = Def.cachedTaskWithUpdate(foo.value)(res => res + bar.value)

The expansion of fizz looks like this:
val fizz = (foo, bar).mapN { (foo, bar) => // both foo and bar are dependencies of the task
  Def.cachedTask(input = foo) {            // only foo is used as an input
    action: _ => foo
    onCacheReuse: () => res => res + bar
  }
}

The behavior of fizz is:
sbt:example> show fizz
1 // computed and cached
sbt:example> show fizz
3 // taken from the cache and updated (1 + 2)
sbt:example> show fizz
3 // taken from the cache and updated (1 + 2)

After a cache hit of the incremental compilation we need to:

Unzip the jar to the backend output folder to enable incremental compilation.
Update the timestamps. Those timestamps are used by the testQuickFilter to decide which class needs to be rerun.

If possible, I feel like we should try to fix the incremental compilation and testQuick so they can work with the remote downloaded outputs instead. Even if we're introducing some side effects, I feel like it should be narrowly-scoped (maybe it should be Seq[Path] => Unit), and should always run to avoid potentially confusing results if misused/abused.

If possible, I feel like we should try to fix the incremental compilation and testQuick so they can work with the remote downloaded outputs instead.

It would be ideal. But also it means we cannot rely on timestamps in CompileAnalysis anymore, which could potentially break some plugins/projects. It's probably very limited though.
For incremental compilation, I think we can configure Zinc to always compile to a jar file. But I don't know how good that works, or if it has already been battle-tested.
For testQuick, if we cannot use the timestamps, we can still use the hashes. But that mean we need to compute the hash of each test even after a test which is a bit of overhead.

Even if we're introducing some side effects, I feel like it should be narrowly-scoped (maybe it should be Seq[Path] => Unit), and should always run to avoid potentially confusing results if misused/abused.

Yeah, I thought of that too and Seq[Path] => Unit is probably hared to abuse. I also wonder if Unit would not be even better (no input and pure side effect). Those Seq[Path] are opaque and it would be dangerous to guess which path is which output file. We can still use .value to find the file that we need to update.

For incremental compilation, I think we can configure Zinc to always compile to a jar file. But I don't know how good that works, or if it has already been battle-tested.

I think there's one build tool that regularly use compile-to-JAR, but if I recall correctly, it doesn't clean after itself to make deletion faster or something like that.
One idea I think worth perusing might be implementing Def.declareOutputDirectoryZip(...) where we pass in a zip file of classes/ directory as classes.zip, and by convention we'll unzip classes.zip to classes/. This way, we can reuse the caching mechanism of single file (caching a whole directory can be complicated because we'd have to check hash of hundreds of files potentially), while keeping the current compilation semantics.

Thanks! I started looking into the compile to JAR option last week. But if I don't manage to make it work well enough, I'll go ahead with declareOutputDirectoryZip.

I think there's one build tool that regularly use compile-to-JAR, but if I recall correctly, it doesn't clean after itself to make deletion faster or something like that.

I managed to make it work in sbt but as you said it does not clean after itself, which is I think an issue. Do you remember any discussion about that?


feat: enable multiquery

Description
Previous custom components was not allowing running multi-queries in the same SQL file. This PR merges all the queries into a single SQL script and replace the custom component with the BigqueryQueryJobOp google component
How has this been tested?
Please explain how you have tested the new changes.
Checklist

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have successfully run the E2E tests, and have included the links to the pipeline runs below
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have updated any relevant documentation to reflect my changes
[x] I have assigned a reviewer and messaged them

Pipeline run links:
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-train-pipeline-20230516134111?project=dt-turbo-templates-dev
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/xgboost-prediction-pipeline-20230516135109?project=dt-turbo-templates-dev
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-train-pipeline-20230516135752?project=dt-turbo-templates-dev
https://console.cloud.google.com/vertex-ai/locations/europe-west2/pipelines/runs/tensorflow-prediction-pipeline-20230516142755?project=dt-turbo-templates-dev

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun

/gcbrun


WIP: Tag connections as NewDbaConnection (True|False)

Should be adding NewDbaConnection NoteProperty and correctly setting it to $true or $false depending on whether we created a new connection or (wrapped and) returned one that was passed in to us. There's also a minor change to initialization of (and detection of existing_ Azure connections.
I'm only opening a PR at this stage (before I've worked on test changes) because I have questions about the code:
1. IsAzure?
There is a block starting on line 415/418 with the comment # Gracefully handle Azure connections which sets $IsAzure. It appears to me that if you go into that block, you don't come ever out (that is, it either outputs and continues the foreach loop, or it calls Stop-Function).  Despite that, the $IsAzure variable is checked in several places below that inside the foreach loop.  I think that referring to $IsAzure outside the block is a potential bug.
If it was my module, I would separate the function into private functions to be clearer that most of the code is exclusive: "Azure" or "NotAzure" and then within those, I would try to more clearly separate the "ExistingConnectionObject" vs "NewConnection" handling.
My concern is that maybe this exclusion is unintentional, and some of the code outside that loop really ought to run when it's azure.
2. Conditions in Azure connections
There's some confusing checks around Tenant or MFA and Credentials (see my #BUGBUG comments). I don't quite understand what the requirements are, but I'm sure the tests aren't consistent with the messages.

Type of Change

[x] Bug fix (non-breaking change, fixes #6211)
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Approach

Commands to test

Screenshots

Learning

If it was my module, I would separate the function into private functions

This would likely make it a lot clearer. This command is huge and got that way over time so it didn't occur to me. If you are up for it, I think this is a good approach

ping-a-ling 😅

The nerve of some people ... 😋
It's been intense at work, and then Thanksgiving, and I've been totally exhausted. I should have some time later this week.

LOL, I get itchy when a PR hangs out too long, even in WIP. I tried my best to wait it out! 🤗 Hope you're feeling better. I've been exhausted for about 6 months, so I get it.

Haven't heard back on this in a while. In order to avoid dissuading potential contributors seeing old PRs and thinking that we don't merge, I will close this but welcome the PR back when it is no longer in draft 💯


PyCharm Syntax Highlighting Support

Support for Syntax highlighting in PyCharm editor

this also provides support for intellij -  Martin Ashby is requesting that.

Instructions for implementing: https://plugins.jetbrains.com/docs/intellij/custom-language-support.html

Is there any progress on the Pycharm integration?

+1

+1


BS4 custom.scss issue

I must be the thickest person around.
Anyway, i'm trying to compile a slightly customised version of BS4, in this instance, number of columns/gutter size and form-control focus background colour.
I am using the source-download (using the instructions found in "Tool Setup" for windows, everything is working perfectly in that regard).
I went into my 'bootstrap' directory (the one that has node-modules, dist, scss, docs, etc...), shift-right clicked and chose 'Open Powershell window here' so that I could run the npm stuff, the environment is all set up and working, I can run 'npm run dist' and it creates all the css/min-css/js/min-js files in "dist".
I then went to follow the instructions for creating a custom.scss, I created that file in bootstrap/scss, imported all the optional stuff (the 'Theming' documentation has node_modules/bootstrap/scss which doesn't exist in my directory structure) so I changed it to match the bootstrap.scss file.
Changed $grid-columns, $grid-gutter-width, and $input-bg (I put these lines in before the import lines), re-ran 'npm run dist', checked the new bootstrap.css file and found it doesn't have my change for .form-control:focus in it.
I feel like i'm missing something, probably something minor.
If I make the change in _variables.scss and run 'npm run dist' it all works properly.

Fired up a brand new Debian 9.3 VM, installed everything necessary, downloaded the source ZIP file, extracted it, ran 'npm install', everything installed fine (much better than on Windows), created a custom.scss file in /root/bootstrap/scss, added in my custom stuff, ran 'npm run dist', all created with no issues, checked /root/bootstrap/dist/css/bootstrap.css, still have none of my custom stuff in there.
My custom.scss file contains the following:
`// Custom.scss
// Option B: Include parts of Bootstrap
// Override grid columns
$grid-columns:                48;
$grid-gutter-width:           8px;
// Override form-control focus colour, it needs to be lightblue!
$input-bg:                    "lightblue";
// Required
@import "functions";
@import "variables";
@import "mixins";
@import "grid";
`

Took the double quotes away from "lightblue", re-ran 'npm run dist', it errored out saying it didn't know what it was, so it is at least seeing the custom.scss file, it just doesn't appear to be doing much with it.

Are you importing custom.scss before variables.scss? If so, then your varriables will be overriden, assuming the names are the same

Importing custom.scss? I'm just doing what the 'Theming' page says to do 'https://getbootstrap.com/docs/4.0/getting-started/theming/'.
Though I don't have my directory structure set out like it shows because BS4 is the only NPM project thingy that I have (I didn't install BS4 from NPM, I simply downloaded the v4.0.0.zip file from github and extracted it, then made sure my node.js/Ruby environment was set up so that I could compile it).
My directory structure is basically '/root/bootstrap', all I want to do is customise a couple of things from BS4 without editing _variables.scss and the re-run 'npm run dist' so that my changes get compiled and I get a new .min.css and .min.js file that I can copy/paste to the webserver.
If I have to, I will just go back to changing _variables.scss, only reason I didn't want to have to do that was for in the future when a new BS4 patch comes out (such as the 4.1 that is currently being worked on).

Hi @ray73864 the guide is correct, please read https://getbootstrap.com/docs/4.0/getting-started/theming/#variable-defaults
If the guide is not clear enough, it'd be great if you could send a PR to improve it based on your struggles.
The trick, as @C-Lodder mentions,  is to load your variables before bootstrap. that's how SASS works.

That is how I have my custom.scss set up though.
My custom.scss is set up exactly as follows (as suggested by https://getbootstrap.com/docs/4.0/getting-started/theming/#importing):
// Custom.scss
// Option B: Include parts of Bootstrap

// Override grid columns
$grid-columns:                48;
$grid-gutter-width:           8px;

// Override form-control focus colour, it needs to be lightblue!
$input-bg:                    "lightblue";

// Required
@import "functions";
@import "variables";
@import "mixins";
@import "grid";

I placed my custom.scss into the same location as all the other Bootstrap 4 scss files (/root/bootstrap/scss), run 'npm run dist' but it never does anything.
What I can see is that under 'importing', it gives me 2 options, Option A is to just import all of Bootstrap's variables, etc... and Option B is to only import what I wish to change.
I am only choosing to change 3 things, all of which are in _variables.scss (Which I assume is being imported by @import "variables"?)
However, looking at the 'variable defaults' section, it shows the import as being 'Option A' (Import the entire of bootstrap), these 2 sections seem to contradict each other, the first section suggests that Option B is the right way to go, however the second section suggests that 'Option A' is the only viable option.
bootstrap.scss is just a file containing a whole lot of imports and nothing else.
Am I to ignore the fact that there are 2 possible ways? (Option A, and Option B), and just go with the 'Option A' method of importing the entire of bootstrap via bootstrap.scss?
This is my first time using SASS (I am a SASS virgin basically) and it is the only project I will ever need that uses SASS, so I'm finding a lot of it rather difficult (even though I have a need to customise a few things, especially the number of grid columns).
Also, I would do a PR, but to do a PR I would need to figure out why the documentation is unclear in the first place, to me, it seems like the documentation is fine but the SASS setup is wrong, but then, as said, I know nothing of SASS so can't make that judgement call.

If you need all of bootstrap the easier way to do it is like to create an scss file, let's call it app.scss where you'll import bootstrap.scss and _your-styles.scss:
@import "_your-styles";

Include all of Bootstrap
@import "node_modules/bootstrap/scss/bootstrap";

Then compile app.scss to generate a app.css file that you'll use on your app.

Point of clarification @ray73864—are you trying to compile your custom.scss file with our build tools  that are in this repository?

I am, yes, all I want to do is a minor customisation to BS4 without changing any BS4 files.
The only use I have for SASS is to compile BS4.

If you're using our build tooling, you'll need to modify it to build your own custom Sass file. See the scripts section in package.json, specifically the css-compile task at https://github.com/twbs/bootstrap/blob/9057d8da164bed683f49d30c6414753dad41de3e/package.json#L24. You'll need to change or add your custom.scss there.

Ahh OK, I figured since the Theming page said that a custom.scss should be created so that you don't have to modify the BS4 stuff that it wouldn't be necessary to do that.
If I have to alter the package.json file, then it would be just as easy to modify _variables.scss directly.

I would just not touch vendors files.
Copy the script over to your package.json after editing it like mdo said and using a _custom.scss.
That way if bootstrap releases a new version, you won't have to re-apply the changes to either package.json or _variables.scss

I'm still at a complete loss on this one.
I don't have my own package.json file, and looking at the Bootstrap 4 one, it looks like something out of a scary movie :(
I assume I would just create a directory structure such as: /root/bs4themes
Then inside that directory have my own custom.scss file, a simplified package.json, and the bootstrap4 directory?

Most tutorials are for bs4 alpha et beta. The nodejs way isn't really clear. There seems to be dozen of different explanation over the web.... and i'm lost right now.
I also tried to download the zip add a custom.scss. But the doc doesn't tell what to do to recompile : https://getbootstrap.com/docs/4.0/getting-started/theming
Maybe it's obvious to you because you wrote all the code, but for someone discovering the whole thing, it's really hard / esoteric.
Hope you won't get mad at me and just explain the whole process clearly.

@mmbpeople since custom.scss is importing bootstrap, then by compiling custom.scss into custom.css you'll get bootstrap + your things.
Maybe you are right and we need better guides. This will requiere an explanation of tooling, set up, etc. I don't know what is out of scope in this case.

I'm having similar issues with @mmbpeople in regards to understanding the documentation and figuring out the best way to compile bootstrap with custom changes.
I don't have a node project, so all I'm using node for is to compile Bootstrap to include my custom changes.
My directory is like this:
my-project/ ├── scss │   └── custom.scss │   └── custom-variables.scss └── vendor │   └── twbs │        └── bootstrap └── webroot      └── css      └── js
My custom-variables.scss file has the Bootstrap variables I've changed.
custom.scss imports my custom-variables.scss and bootstrap,scss:
@import "custom-variables"; @import "../vendor/twbs/bootstrap/scss/bootstrap";
I'm including my custom scss files outside the vendor folder so they are version controlled. The Bootstrap vendor source was retrieved using Composer.
The remaining issues are:

I have to manually edit package.json and change where it says 'scss/bootstrap.scss' (in css-compile) to '../../../scss/custom.scss'. This really isn't ideal since it's a change to a bootstrap source file, which isn't version controlled in the vendor directory. How else can I build Bootstrap with my custom.scss file?

Similar to 1. I want to change where the dist files are outputted. At the moment the compiled contents go into the vendor/twbs/bootstrap/dist directory. It would be better to have them outputted directory into my webroot directory. Yes I can change the output directories in the package.json file, but again this is a bootstrap source file, which isn't being tracked in my repo.

So I guess what I'm after is a way to customise the build process of Bootstrap that I can version track.
The documentation doesn't really touch on how to build Bootstrap with your custom changes at all.

Please read previous comments.
You don't need to change anything in Bootstrap's package.json
Make a a package.json file, then use this template, then copy the scripts section from Bootstrap's package.json and edit the references to bootstrap.scss to custom.scss

@wolfy1339, so this is how I understand it, and my progress:

Make a copy of package.json and put it in my scss directory
Run npm install
Change every directory in package.json so it properly references the bootstrap source files needed for building, and my own changes

The problem I have is with changing the directories. Running into a lot of problems while trying to 'npm run dist'. If I miss a directory change or do it incorrectly I cop a massive error in my vagrant machine. Disk usage ramps up to 100% and I have to relaunch the machine. I'll keep going but surely there another way that's much easier.

@ThomasNucleus I have to agree, that's a lot of directory changes one has to do, I'm pretty sure it's extremely easy to miss one.
I'm not even entirely sure which ones I am supposed to change and which ones I'm not. Some of them look obvious, others you just can't tell.
When the help page was talking about customising it, I was just expecting to be able to drop a custom.scss file into bootstrap/scss, run 'npm run dist' and hey presto BS4's package.json thingy would auto-detect that I had a custom file in there and go with it.
What I've basically decided on doing right now (because it is the easier way so far) is having a separate directory for each 'theme' that I need (right now I need a light and a dark one), changing _variables.scss to suit, running 'npm run dist', then renaming the resultant bootstrap.min.css file to 'bootstrap-light.min.css' and 'bootstrap-dark.min.css'.
Obviously it's not the right way, but it is the most simplest unless someone can give an 'Idiots Guide to Customising Bootstrap 4'.
I tried searching on the net, but most guides I found are for earlier versions of BS4, some talked about an _custom.scss, others talked about a custom.scss, and others still talked about a completely different file for customising, it's just a complete mess right now in terms of useful guides for those that only need nodejs to deal with BS4.

As the current documentation does not give any hint of "how to compile your own custom.scss" and the solution to change the package.json is ... not that simple, I solved the problem on my own.
I used the standard downloaded version of bootstrap 4.
I changed the scss/bootstrap.scss and added one single instruction at the beginning of the file:
@import "custom";
That feels like cheating and certainly is not ideal, but it requires the modification of a single file only and is simple to restore after an update.

Hrmm, adding my custom.scss to the top of bootstrap.scss didn't work either.
If I add it to the top of the file, I get my changes to the number of grids, I get my theme colours, but I don't have any of the other colours.
If I add it to the bottom of the file, I get my grid changes but nothing else.
I think i'm just going to go back to modifying _variables.scss, so far it is the only thing that has actually worked for me.

If you want to fully customize BS4, but also have access to its existing variables and functions, you cannot use bootstrap.scss.  You need to take (copy) the contents of bootstrap.scss, and place your customizations in the appropriate location.  Usually this means between @import "mixins" and @import "root"

I stumbled here, finally finding a workable solution in @biteater's suggestion of adding the import of custom at the top of bootstrap.scss
I have to +1 "Most tutorials are for bs4 alpha et beta. The nodejs way isn't really clear. There seems to be dozen of different explanation over the web.... and i'm lost right now."
The documentation for "theming" is stunningly bad, making enormous leaps and assumptions that someone will be able to piece together things they would have to already know to get a custom bootstrap built. I'd like to offer a PR, but I don't understand it beyond knowing that the kludge of adding the custom import works great.

@ddn my problem was that I tried that, but I needed to update things that required access to the different maps (for colours, etc...) and trying to change/add before they got imported by _variables.scss just caused the sass compiler to complain and die.
Right now my method is to basically have multiple folders for each theme that I want (in this case a light and dark theme) and then edit the _variables.scss file, recompile, copy the dist/bootstrap.min.css file to the webserver (since my webserver is too old to work with the version of node.js required) and rename it to bs4-(dark/light).min.css.

I'm also having the same difficulty.
I think it would be interesting, if it came by default, a custom.scss (empty) file, but already configured for compilation.
So a user who is starting up on Bootstrap customization would already have a starting point for change.

They don't though, and as is evidenced by a few people commenting here, the documentation makes no mention of how to make a custom.scss file work.
I've basically had to resort to just having several directories for BS4, each with various modifications to _variables.scss as the helpfile provides no help at all in this case.
It MAY help people who know and use SASS for other projects, but for someone who just wants to customise bootstrap4 itself it provides little help.
Though because I have to edit _variables.scss, I am basically stuck on Bootstrap 4.0, unable to really move up to another version until I notate what changes I made.

If you think the docs don't cover your case, you are welcome to make a PR. This issue is from the time we didn't explain it like we do right now.

I'm not entirely sure how I could make a PR to begin with. I simply don't understand how to do it and lack the time to try and work it out.
And near as I can tell, the documentation for 'Theming' in 4.1 is identical to what it was in 4.0 when I first created this issue.

Well, I need to clean up the issues at some point and yeah this is a no issue to my understanding.
Like I said, instead of spending time writing all this you could just edit the doc file to make your suggestion.

So, if your problem is having the issue open, let's open it again and I'll wait for PRs.

I managed to get a custom scss file to work per the documentation. Where I struggle is how to compile to a CSS file... It compiles and 'works', but the Autoprefixer isn't working as expected.
For example:
The .custom-select should set the css of appearance to none. In the bootstrap /dist, it looks like the following:     -webkit-appearance: none;     -moz-appearance: none;     appearance: none;, but when I compile in my project, I only get appearance: none;.
Is there any steps available for how to properly compile a custom theme? Does it involve the postCSS loader?

I've been using theme-kit lately, it's made things a little bit simpler as I couldn't get my head around how to make it work at all when looking at the BS4 documentation.

FWIW, I do think that the method shown in the docs is correct, with respect to how the custom Sass file should be written. For instance, this is my app.scss file:
$font-size-base: 0.875rem;
$enable-gradients: true;

@import 'colors.scss';
@import "../lib/bootstrap/scss/bootstrap";

I get my slightly smaller text, gradients, and some color overrides, no sweat. I think the issue most people get stuck on is how to get their custom file compiled. I'm lucky in that I code in Visual Studio, so all I have to do is install the Web Compiler extension, add a compilerconfig.json file, and the extension does all the work for me. Easy-peezy, lemon-squeezy.
So, would it be fair to say that what most people are really asking for is some guidance on how to setup Sass compilation in their chosen framework? Would that be on-topic? If so, could we establish some sort of checklist/wish-list for which frameworks are worth the effort, and whether that belongs in the docs or as wiki entries here on Github?

This issue faded away and the since then we've created https://github.com/twbs/bootstrap-npm-starter which should help show folks how to compile (at least with npm) a custom build of Bootstrap. I'm thinking we can link this from both the v4 and v5 docs to help show folks how it works.
Perhaps we also need a more comprehensive guide on the compiling aspect per the last comment here?

This issue faded away and the since then we've created https://github.com/twbs/bootstrap-npm-starter which should help show folks how to compile (at least with npm) a custom build of Bootstrap. I'm thinking we can link this from both the v4 and v5 docs to help show folks how it works.
Perhaps we also need a more comprehensive guide on the compiling aspect per the last comment here?

@mdo Not sure if you're actually asking for feedback, but:

I don't work with npm much, so the guide you linked (while very useful to most) wouldn't help old .NET curmudgeons like me.
The current Sass guide seems well written, to me. Not sure what you could do to make it "better."
There's (at least) a handful of Q/A entries on Stack Overflow that deal with setting up custom Bootstrap overrides (I may have even written one or two of those answers). This seems to be one of those things that seems terribly complicated until you've done it a few times.

Is any of that helpful?

@mdo Not sure if you're actually asking for feedback, but:

I don't work with npm much, so the guide you linked (while very useful to most) wouldn't help old .NET curmudgeons like me.
The current Sass guide seems well written, to me. Not sure what you could do to make it "better."
There's (at least) a handful of Q/A entries on Stack Overflow that deal with setting up custom Bootstrap overrides (I may have even written one or two of those answers). This seems to be one of those things that seems terribly complicated until you've done it a few times.

Is any of that helpful?

We've continued to iterate on the customization docs for v5, and I don't see us revisiting things for v4 at this point in time. Happy to see continued PRs if folks have recommendations for either release though. Otherwise, I think the expanded docs are pretty spot on for customizing Bootstrap with Sass and with CSS variables.
Additional guides for customizing on top of the compiled CSS can be found via Google—there's not much guidance there except to consider using PurgeCSS to improve page performance.


Set up config file

Create a config file for the project. Here's how I see the flow:

Create a config file readable by build.sh
Write the version number there, and insert that to guitar-exercises.ly
Use that version number in the name as well, to keep things consistent
Compile!

For bash protips: https://askubuntu.com/questions/743493/best-way-to-read-a-config-file-in-bash

Done!


Export tokio metrics to prometheus

It would be useful to see the state of the runtime in production (as stated elsewhere, we would have likely noticed the wallet sync not yielding back to the runtime earlier
Enabling metrics in trivial (adding the tokio-metrics crate) , the only question is whether we really need all the metrics (and how often we'd like to send them over.
Below in a print of all the metrics that we can enable
RuntimeMetrics { workers_count: 8, total_park_count: 3, max_park_count: 3, min_park_count: 0, total_noop_count: 1, max_noop_count: 1, min_noop_count: 0, total_steal_count: 0, max_steal_count: 0, min_steal_count: 0, num_remote_schedules: 0, total_local_schedule_count: 2, max_local_schedule_count: 2, min_local_schedule_count: 0, total_overflow_count: 0, max_overflow_count: 0, min_overflow_count: 0, total_polls_count: 2, max_polls_count: 2, min_polls_count: 0, total_busy_duration: 455.521µs, max_busy_duration: 455.521µs, min_busy_duration: 0ns, injection_queue_depth: 0, total_local_queue_depth: 0, max_local_queue_depth: 0, min_local_queue_depth: 0, elapsed: 502.308891ms }

I wouldn't know what any of these metrics means 😅
Is there an explanation to it?

you can see more info: https://docs.rs/tokio-metrics/0.1.0/tokio_metrics/struct.RuntimeMetrics.html#structfield.injection_queue_depth
I'll create a PR that exports them all, with descriptions taken from config (and with a link to the docs), and then we can pick them apart if we decide we don't need some of them.

Enabling metrics in trivial (adding the tokio-metrics crate) , the only question is whether we really need all the metrics (and how often we'd like to send them over.

Note: you can't configure how often they are being pulled by prometheus as they will all be bundled under the same endpoint under api/metrics

I'll create a PR that exports them all, with descriptions taken from config (and with a link to the docs), and then we can pick them apart if we decide we don't need some of them.

Can I propose a different approach: instead of enabling them and then looking into the metrics, look into the metrics first and decide which we need and then enable them?
This would save us some time in the case we don't need any ;)


[tools] Put test author into metadata

Historically test developer's name was put into file comments
immediately after license info. At the very beginning, this template is
OK for internal using.
As projects moving forward, these tests are expected to contribute to
upstream, e.g. W3C. It is important to put the author info into metadata
rather than into comment, because this comment including license and
author info must be removed before submission.
Sometimes, the authorship informations in metadata are used to
respect the authors, for example CSS WG nightly unstable lists all
authors in its acknowledgements section at
http://test.csswg.org/suites/css-transforms-1_dev/nightly-unstable/
Therefore both Intel and co-author Jieqiong Cui are acknowledged.
Sometimes, people can use this author metadata to talk test issues,
which is easier than finding author(s) via git log.
These templates are used for new test cases development; not for
existing tests.

@jennycao @Honry @ibelem could you please review this? Any comment is welcome.

CC @haoxli @chunywang @kangxu @JianfengXu

All, I will also try to leverage some good parts of

http://testthewebforward.org/docs/test-templates.html
https://www.chromium.org/blink/serviceworker/testing

Especially the Promises and Test Harness specific issues in the 2nd one.
Stay tune for the templates update and thank you for all feedback in advance.

Up!


[iOS Bootcamp] Week1 Assigment (Rotten Tomatoes app) - Review my app

My app is complete please review. /cc @codepathreview

One major issue I hit late yesterday: I am not using a storyboard, but IB. All the tutorial were using storyboard, so I had to proceed with my own hacks:
Placing the search bar on top of the table view, kind of mess up the with the navigation bar. One solution I found was to include the search bar inside the navigation bar with the option.
But then both the searchbar view and the navigation bar's search bar conflicted on the UI. Still, the search functionality works, though the UI experience is awful.

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

love Rest2Mobile
Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
Nice work implementing the Movie model.
Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
Nice work loading the images asynchronously.
Nice work setting up the proper modes for the images so that they are not stretched.
Nice work implementing the error message on network failure.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
--dirk

Thanks Dirk, /cc @codepathreview
I am actively involved in the rest2mobile project and I thought it would be a good use case. It also allowed me to fix a few bugs in rest2mobile as well :)
I appreciate your comments, I am still a rookie in app UI building and learning.
Yes, I should have moved the cell setup inside the cell impl itself: just run out of time to clean up everything :)
I'll take a look at the NYT code styling too.
Have a nice week-end (mine is completely booked with yelp app)
-manu


Bichard7 team

Hi,
The Bichard7 Next team needs all the review_after extended for another year, please.
2023 -> 2024
For example: https://github.com/ministryofjustice/github-collaborators/compare/main...richrace:github-collaborators:update-bichard7-collaborators

I'll take a look and get those extended.

Thank you


Manage own ignoring instead of with chokidar

To avoid creating chokidar instances (https://github.com/substack/watchify/pull/202 et al.)

Just FYI you could simplify some of your logic here by using multimatch or micromatch with their built-in array handling instead of minimatch

thanks @es128 - I'm trying to stick to the matching lib that browserify uses (minimatch via glob), but  I liked what I saw in micromatch.

multimatch is a pretty thin wrapper around minimatch that will just handle the arrays for you.

superseded by https://github.com/substack/watchify/pull/237 and https://github.com/substack/watchify/commit/7cfb8fa15e38989125f8c67546fe2488ca2f32ce


Optimize website based on LightHouse audit

I ran a LightHouse audit on https://search.maven.org/ and there are some points of improvement. (If you want to run this audit yourself, see https://developers.google.com/web/tools/lighthouse/#devtools )
Most notably, there are quite some large resources that are also render-blocking (such as main.js, polyfills.js and styles.css). It would be great if they are not render-blocking, but simply progressively enhance the HTML that is sent over initially. Moreover, these resources do not have a caching strategy and will thus be refetched every single time. Since I saw you are hashing your files (nice!), consider putting a long caching strategy, e.g. https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/http-caching#cache-control
I also saw you are using Webpack. (I saw this in the generated build files, but I saw no reference to webpack in this repository. Where is this coming from?) Consider taking advantage of code splitting (https://webpack.js.org/guides/code-splitting/) to lazy-load or only load code when it is used. There is quite a lot of script pushed to the client, but I do not think you need all of it right away.
You can also take a closer look at what is actually in your bundle with tools like https://www.npmjs.com/package/webpack-bundle-analyzer to see what you are shipping to the user. There might be package that you are loading right now that are unnecessary or replaceable with small custom functions.
For example, you are loading a lot of polyfills even on browsers that do not require them. See https://github.com/sonatype-nexus-community/search-maven-org/blob/ec51bc29f7b92cff4583aefaf8941b40e7959863/src/polyfills.ts#L21-L35 which loads polyfill code that should only be loaded on IE, as all other browsers work just fine.
Lastly, there is a new technology called service-worker which can speed up your repeating customers. You can automatically generate these workers with tools like Workbox (https://developers.google.com/web/tools/workbox/).

I can try to build this project tomorrow and see what I can do!
On Mon, 13 Aug 2018, 19:22 Jeffry Hesse<EMAIL_ADDRESS>wrote:

Man, what a thorough report. PR's welcome! A couple of us work on this in
our free time (Sonatype gives us a day every two weeks to work on cool
projects), so you likely won't see movement super quick, but we appreciate
the detail and the fact you did this!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sonatype-nexus-community/search-maven-org/issues/39#issuecomment-412596512,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFrDb4reSmcC0liHqxrzSBr1FmEAnvriks5uQbXKgaJpZM4V5lck
.

So I did an initial investigation. Sadly, the problem is a well-known problem with the Angular CLI. Apparently the Angular CLI uses Webpack under the hood, which does not understand how to tree-shake imports. Therefore imports like import { Component, isDevMode } from '@angular/core'; pull in the 500KB core bundle, even though only few parts are actually necessary.
I fear that an Angular expert has to take a stab at this, as I have not enough experience with Angular to tackle this problem :cry:

Apparently Angular DOES do Tree Shaking, but yeah, the big imports kinda prevent that from really working. I'll see if I can take a gander at this sometime, because you are right, I doubt we need absolutely the entire kitchen sink to run this.

@TimvdLippe and @DarthHater I have been looking into this and have made some good progress. I hope over the next couple of evenings to solidify the work and push it.

That is great news! Once you push it to this repo, please link the commit so that I can investigate. (Commit messages are always the same, making it impossible to read the git history in this repo :p )

@TimvdLippe I am not sure that will be possible... I am working of our private repo, maybe I can send you a patch? In the future we will likely do more work ourself on the public repo.

@TimvdLippe I pushed an update out to the production server
We have improved the lighthouse metrics in certain areas :

Some due to updated to code,

lazy loading of routes/modules
smaller images
changes to the index.html

Others due to changes to our webserver

cache control (there is a little more we are gonna do here)
gzip

From my test I can see performance has increased and lots of the request have smaller foot prints, there is for sure more that could be done, but I think that would be a harder task with the current frameworks we use. In short I followed several guides of Angular to help with increasing performance and the current deployment is the result of it.

@SirMaster Awesome work, yes a lot better! There are still some small improvements that can be made, but there has been a good amount of progress :tada:

@TimvdLippe yep more things to do, p.s. we disabled the caching for now. Hope to turn it on soon again, but we were having some issues with the classic site when it was turned on.

@TimvdLippe we enabled caching again for certain resources. With that and all the current changes, I believe that this is now handling most of the things currently possible for us to do.
I will close this issue, if you feel there are other specific areas that we can improve upon, feel free to create a new issues.
Once again a big thanks for taking the time to provide your feedback!


fix: Multiple controls to fix resources, visual states, and lightweight styling issues

GitHub Issue: #https://github.com/unoplatform/Uno.Gallery/issues/901
PR Type
What kind of change does this PR introduce?

Bugfix

Description
Fix multiple controls to fix resources, visual states, and lightweight styling issues (matching the latest changes in the uno material design file)
PR Checklist
Please check if your PR fulfills the following requirements:

Commits must be following the Conventional Commits specification
[ ] Tested the changes where applicable:

[ ] UWP
[ ] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[ ] Updated the documentation as needed:

[ ] General Doc Update
[ ] material-controls-styles.md
[ ] cupertino-controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[ ] Contains No breaking changes

If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

@Mergifyio backport legacy/2x release/stable/2.7

@Mergifyio backport legacy/2x release/stable/2.7


Add --ignore-inode option to backup cmd.

What is the purpose of this change? What does it change?
This PR adds --ignore-inode option to backup command, in order to support those filesystems that don't support fixed inodes, typically Fuse, pCloud, etc.
Was the change discussed in an issue or in the forum before?
It was already discussed #1631.
Checklist

[x] I have read the Contribution Guidelines
[x] I have added tests for all changes in this PR
[x] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Codecov Report

Merging #2047 into master will decrease coverage by 4.38%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
- Coverage   51.18%   46.79%   -4.39%
==========================================
  Files         176      172       -4
  Lines       14065    14036      -29
==========================================
- Hits         7199     6568     -631
- Misses       5817     6478     +661
+ Partials     1049      990      -59

Impacted Files
Coverage Δ

cmd/restic/cmd_backup.go
44.91% <100%> (+0.78%)
:arrow_up:

internal/archiver/archiver.go
68.62% <90.9%> (ø)
:arrow_up:

internal/backend/b2/b2.go
0% <0%> (-80.69%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-78.45%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-73.61%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-69.46%)
:arrow_down:

internal/backend/swift/config.go
36.95% <0%> (-54.35%)
:arrow_down:

internal/checker/checker.go
64.54% <0%> (-3.87%)
:arrow_down:

internal/archiver/blob_saver.go
92.59% <0%> (-2.47%)
:arrow_down:

internal/backend/s3/s3.go
60.15% <0%> (-2.26%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b39ae...1f6d98c. Read the comment docs.

This reduced the amount of time it took for converting my rdiff-backup snapshots to restic snapshots from over an hour to under 8 minutes. I would love to see it merged into restic mainline.

@fd0 yup, no problem on my side. I'll try and apply your requests. The idea of having a struct to handle multiple types of ignore flags was probably overengineered at this stage.

@robvalca this PR is incomplete, it looks like @giacomocariello did not have the time to rework it yet. So we need to wait until this happens (or somebody else volunteers to do it) :)

@fd0, @giacomocariello  do you think that I could take on this? I'm newbie in golang (and btw in github collab) but with the work already done and some help I think that I could finish this. :)


Use a dark theme for cards

I plan to use a dark theme for cards.

Closed by PR https://github.com/tenshiAMD/tenshiAMD/pull/14.


Register as an fman's plugin

https://fman.io/docs/sharing-plugins

and add the topics fman and plugin

Thanks for reaching out. Sorry but I deliberately removed the tags because the plugin is outdated and not working in current version of fman. See #17 for more details, haven't had time to fix it yet unfortunately.

Well, I've checked the README and the issues list about a possible intention.
Ok, I see.

I'll let the issue stay open so you get a notification when the plugin is ready for use again

@pravic FYI the plugin has been updated to work with the current fman version and is reregistered


If istio-sidecar-injector workload is removed or crashes, no pods can be scheduled to run

Bug description
In GKE I deleted one of my Node Pools in the cluster. As part of the removal, GKE removed workloads from the nodes in the pool. The sidecar injector pod was one of the workloads removed. When the istio-sidecar-injector pod was deleted by kubernetes all subsequent pod operations fail because kubernetes attempts to call the controller webhook that is not running. Can't start the sidecar workload for the same reason (catch-22): no endpoints available
describe any pod:
Internal error occurred: failed calling webhook "sidecar-injector.istio.io": Post https://istio-sidecar-injector.istio-system-datach-npe.svc:443/inject?timeout=30s: no endpoints available for service "istio-sidecar-injector"	0/1
Serving pods
At this point I had to delete the controller webhook config:
kubectl   delete  MutatingWebhookConfiguration istio-sidecar-injector
and re-run the istio manifests.
Although this happened during a node pool delete, I have seen the same behavior if the sidecar crashes or can't be scheduled.
Expected behavior
Able to recover from sidecar-injector workload restart or crash
Steps to reproduce the bug
Delete the sidecar-injector pod.
**Version 1.3.8 (also in 1.3.6)
How was Istio installed?
Helm + kubectl
Environment where bug was observed (cloud vendor, OS, etc)
GKE:  1.14.8-gke.33
Workaround:
delete the controller webhook config:
kubectl   delete  MutatingWebhookConfiguration istio-sidecar-injector
re-run istio manifests

By default MutatingWebhookConfiguration is opt-in and only targets namespaces labeled istio-injection=enabled. Did you add this label istio-system? Alternatively, if you changed MutatingWebhookConfiguration to be opt-out you'll need to add the istio-injection=disabled label to istio-system.

Understood, only my app namespace has that label. The problem is kubernetes
expects the webhook workload to be running, which it is not... I believe
the logic around the label is in the sidecar injector which is not running.
If admission webhook workload is not running kubernetes "throws" this error.
Thanks,
Brian
On Fri, Feb 14, 2020, 4:18 PM Jason Young<EMAIL_ADDRESS>wrote:

By default MutatingWebhookConfiguration is opt-in and only targets
namespaces labeled istio-injection=enabled. Did you add this label
istio-system? Alternatively, if you changed MutatingWebhookConfiguration to
be opt-out you'll need to add the istio-injection=disabled label to
istio-system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/21147?email_source=notifications&email_token=ABGY3XYY76DA54W7AXUZHH3RC4DDBA5CNFSM4KVKFYWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL2OXIA#issuecomment-586476448,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGY3X2PO7JG3ITJI7U7HTLRC4DDBANCNFSM4KVKFYWA
.

Ok I see, it's part of the match label on the mutatingwebhookconfiguration.
I looked at the labels on the wrong istio namespace, we have multiple in
same cluster and yes the one where it happenes has the namespace
label...thanks and sorry about that.
Brian.
On Fri, Feb 14, 2020, 4:28 PM Brian Aabel<EMAIL_ADDRESS>wrote:

Understood, only my app namespace has that label. The problem is
kubernetes expects the webhook workload to be running, which it is not... I
believe the logic around the label is in the sidecar injector which is not
running. If admission webhook workload is not running kubernetes "throws"
this error.
Thanks,
Brian
On Fri, Feb 14, 2020, 4:18 PM Jason Young<EMAIL_ADDRESS>wrote:

By default MutatingWebhookConfiguration is opt-in and only targets
namespaces labeled istio-injection=enabled. Did you add this label
istio-system? Alternatively, if you changed MutatingWebhookConfiguration to
be opt-out you'll need to add the istio-injection=disabled label to
istio-system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/21147?email_source=notifications&email_token=ABGY3XYY76DA54W7AXUZHH3RC4DDBA5CNFSM4KVKFYWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL2OXIA#issuecomment-586476448,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGY3X2PO7JG3ITJI7U7HTLRC4DDBANCNFSM4KVKFYWA
.


Stacking Item automatic do not work on some potion

When crafting potion, some of them do not stack depending of the type.
You can reproduce it by droping the potion on the ground and slide it on your character. Potion will go on your pack. Reproduce and you'll see item do not stack. When they are on backpack, you can stack them manually.
i_potion_Agility  do NOT work
i_potion_nightsight work.
Any hint?

It's not a bug, item like potions / scrolls stacks only when all of their values are equal.
So that means your agility potions has a different more2 value (the potion strength) and thus they cannot stack.

@drk84 why I can stack them manually?

[TYPEDEF t_potion]
ON=@Dropon_Item
IF <ARGO.BASEID> == <I.BASEID>
ARGO.AMOUNT += <I.AMOUNT>

REMOVE

ELSE
RETURN 0

ENDIF
Its why :-)


RTL support for Flowbite components

This PR adds native RTL support to the components from Flowbite via the RTL/LTR variants from Tailwind CSS

Amazing work, do we have an ETA for merging this change?

Hey @Oddadmix,
Thanks! Probably this week.
I usually document updates on Twitter/X: https://x.com/zoltanszogyenyi
Cheers,
Zoltan


Start cloud shell how?

How?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a825f031-250e-034d-e552-4b0d976d88b1
Version Independent ID: 626d7451-0b8e-051e-e512-0bf90be319a0
Content: QuickStart: Create a static HTML web app - Azure App Service
Content Source: articles/app-service/app-service-web-get-started-html.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@smiller7812 Thanks for the feedback! We are currently investigating and will update you shortly.

@smiller7812 Thanks for asking question! As its mentioned in the doc you may use any of the below mentioned method.

No idea what environment where you are, how to get there.
Worthless article.

From: SnehaAgrawal-MSFT<EMAIL_ADDRESS>Sent: Tuesday, March 10, 2020 10:01 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: smiller7812<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Start cloud shell how? (#49852)
@smiller7812https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsmiller7812&data=02|01||2a36f3dc55854be6f37308d7c4fb9018|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637194457035314813&sdata=c2F614oryNK6jWOWbxjt7zSftUcdfpgrayQFn8azAeU%3D&reserved=0 Thanks for asking question! As its mentioned in the doc you may use any of the below mentioned method.
[image]https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F46553948%2F76319592-75c43280-6305-11ea-9166-a6934d073eba.png&data=02|01||2a36f3dc55854be6f37308d7c4fb9018|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637194457035314813&sdata=y%2F8zE5DWM2ex9R1VI%2FGrZnc%2FfyNidRRrkp3e8Mt7Zug%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F49852%3Femail_source%3Dnotifications%26email_token%3DAM4QAHD2JGX3Q5CRCD7SQTLRGZB4NA5CNFSM4LE5CIJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLQ3NQ%23issuecomment-597102006&data=02|01||2a36f3dc55854be6f37308d7c4fb9018|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637194457035324821&sdata=QZn%2Fit71bSA2hyY70ZIuKEU7S5BxgDSusjBcRzefxNs%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM4QAHESL2YUZ4FZY3SERPTRGZB4NANCNFSM4LE5CIJA&data=02|01||2a36f3dc55854be6f37308d7c4fb9018|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637194457035334830&sdata=Jex5jxGFzif6ESJ1XHM3pBPfvyQglIdb5TFWUMawr4M%3D&reserved=0.

Thanks for the feedback! To elaborate on this Azure Cloud Shell is an interactive, authenticated, browser-accessible shell for managing Azure resources. It provides the flexibility of choosing the shell experience that best suits the way you work, either Bash or PowerShell.
You may refer to https://docs.microsoft.com/en-us/azure/cloud-shell/overview
Let me know if you have further questions on this your feedback is very important to us and we use it to continually improve our service.

Thank you.
That helps a little.

From: SnehaAgrawal-MSFT<EMAIL_ADDRESS>Sent: Wednesday, March 11, 2020 2:37 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: smiller7812<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Start cloud shell how? (#49852)
Thanks for the feedback! To elaborate on this Azure Cloud Shell is an interactive, authenticated, browser-accessible shell for managing Azure resources. It provides the flexibility of choosing the shell experience that best suits the way you work, either Bash or PowerShell.
You may refer to https://docs.microsoft.com/en-us/azure/cloud-shell/overviewhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fcloud-shell%2Foverview&data=02|01||26189ed7f8ec41b152a808d7c586b49e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195054646674156&sdata=Y2kUqhNXzqayR1x4hq2l6ZIA%2F0QpWEfw3SdMqt79JZI%3D&reserved=0
Let me know if you have further questions on this your feedback is very important to us and we use it to continually improve our service.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F49852%3Femail_source%3Dnotifications%26email_token%3DAM4QAHGSLTKMQ56S7D6XV7TRG4WTRA5CNFSM4LE5CIJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOOKH4Y%23issuecomment-597468147&data=02|01||26189ed7f8ec41b152a808d7c586b49e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195054646684147&sdata=DdPZjwaXpyX7JaB8F5XM709IW7cZ8DjpmryOdjlyOb8%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM4QAHCKFPPMFCVPKOC4DRTRG4WTRANCNFSM4LE5CIJA&data=02|01||26189ed7f8ec41b152a808d7c586b49e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195054646694146&sdata=K%2BBNblrEVtSasGlPfVKftZffgVvz0kqI1mwM6gH3O1o%3D&reserved=0.

@smiller7812 Gald to know it helps. We will close this out but if you feel you need more information please just let us know.


Docs do not contain information about sft.conf.

While debugging sft resolve, I bumped into message https://gist.github.com/lakshmi-kannan/02d6525eb31dab8bce68c53c9a548e1f#file-gistfile1-txt-L3 and tried to look up docs to get a sft.conf created on my box. I couldn't find the schema for the config. A sample config shipped with the client packages will also help.

The primary interface for this is through the sft config command line, which has been improved quite a bit since 1.15


Change label for the onion TXT record

I'd like to make it easy for people to point their domain or a subdomain at a set of entry proxies without needing to transfer their entire DNS hosting to an onion resolver service.
The easiest way I have found is for users to set a CNAME to a hostname which round-robins between all online entry proxies. For example:
$ dig cname.dnslog.me

 ;; ANSWER SECTION:
cname.dnslog.me.	2796	IN	CNAME	proxy.oniongate.com.
proxy.oniongate.com.	3599	IN	A	<IP_ADDRESS>
proxy.oniongate.com.	3599	IN	A	<IP_ADDRESS>

The problem is that it is not possible to specify any other records (including TXT records) on a CNAME. Some DNS providers and DNS servers provide a non-standard ALIAS record to get around this issue, but it is not widely support.
We can instead specify the onion address TXT record on a label under the CNAME record. An underscore subdomain is used in other protocols which use TXT records to serve data, it seems like an acceptable practice. I'd suggest an _onion label under the request domain.
$ dig TXT _onion.cname.dnslog.me

;; ANSWER SECTION:
_onion.cname.dnslog.me.	3181	IN	TXT	"onion=facebookcorewwwi.onion"
```

 I think it's better than we change the protocol to only request the TXT label from the subdomain now. It will be difficult to change once this software is deployed.

Looks good to me.
For example:
browser to DNS server: example.com.
DNS server to browser: IN CNAME proxy.oniongate.com. IN A <IP_ADDRESS>
browser to entry proxy on <IP_ADDRESS> (SNI): example.com
entry_proxy to DNS server: TXT _onion.example.com
DNS server to entry proxy: onion=facebookcorewwwi.onion
DNS server can be nameserver tool from https://github.com/DonnchaC/oniongateway/pull/17
(By the way, I think, #24 is better to implement after merging https://github.com/DonnchaC/oniongateway/pull/17 )

Unfortunately a CNAME can not be set for the apex domain such as example.com. They can only be set for subdomains.
However this is still useful when a user would like to have https://secure.media.org point to a hidden service while hosting the rest of their services on the clearnet.

I updated my comment to provide two scenarios: an apex domain and a subdomain.

In respect with https://github.com/DonnchaC/oniongateway/issues/25 the subdomain _onion can be changed to something more general, e.g. _backend.


CLI doesn't support darwin/arm64 (M1 mac) architecture

Using curl,
$ curl https://deepsource.io/cli | sh

deepsourcelabs/cli crit platform darwin/arm64 is not supported.  Make sure this script is up-to-date and file a request at https://github.com/deepsourcelabs/cli/issues/new

No relevant binaries are present in the Releases, either.

Fixes in 1358e94


Version 4.0.2

There are currently PRs open against the source repository to fix a memory leak in EventSource, and several of the other forks have already merged fixes for this.
I am still working to confirm for certain that this is the source of our crashes in the LD SDK, but perhaps it will aid your investigation.

Hey Justin,
Thanks for taking the initiative to submit this pull request! Were you able to reproduce the memory leak, or have other evidence from your crashes that it is happening?
Also, how come you're adding a new session?
I recognize that you might not have the answers to these questions; you asked a similar question about steps to reproduce the problem, plus the original author of that pull request also added a new session. And yet, we want to validate both the presence of the leak and that these changes resolve it before we merge the PR.

I'm closing this PR as we haven't gotten a response to the open questions. Feel free to reach out if you want to discuss this change further.


Society 62436 is listed as having 3 songs under cantometrics_sample but actually only has 1

So, the cantometrics_sample column currently contains the number of Cantometrics songs from the metadata sheet, which includes songs not yet coded (ids that start with NC). So, there are 3 songs from society 62436 that have metadata in Cantometrics, but only one is coded. Should we change this across the board?

Ok. Thanks for looking into this Stella.
It's a difficult choice. Should the cantometrics_sample column tell us the number of songs, or the number of songs you can analyse. I ran into a problem because I had assume it was the latter (ie. give me all societies with more than three songs to put into an analyses).
Perhaps this is somethin @pesavage can weigh in on when he is back from holiday.

I think we should only count those that are actually coded. Pretty sure that is the standard we adopted throughout the main manuscript.


Cell outputs can be repeated in UX

Cell 1:
%%sql --module taxi

DEFINE QUERY locations
  SELECT FLOAT(pickup_latitude) AS lat, FLOAT(pickup_longitude) AS lon, medallion
  FROM [833682135931:nyctaxi.trip_data]

DEFINE QUERY geohashes
  SELECT lat, lon,
         CONCAT(STRING(FLOOR(lat*1000+0.5)/1000), ':', STRING(FLOOR(lon*1000+0.5)/1000)) AS geoid,
         medallion
  FROM $locations
  WHERE lat != 0 AND lon != 0

DEFINE QUERY hotspots
  SELECT FIRST(lat) AS lat, FIRST(lon) AS lon, COUNT(medallion) AS pickups
  FROM $geohashes
  WHERE ABS(HASH(medallion)) % 1000 == 1
  GROUP BY geoid
  ORDER BY pickups DESC
  LIMIT 25

Cell 2:
print bq.Query(taxi.hotspots).sql

Result:
SELECT FIRST(lat) AS lat, FIRST(lon) AS lon, COUNT(medallion) AS pickups
  FROM (SELECT lat, lon,
         CONCAT(STRING(FLOOR(lat*1000+0.5)/1000), ':', STRING(FLOOR(lon*1000+0.5)/1000)) AS geoid,
         medallion
  FROM (SELECT FLOAT(pickup_latitude) AS lat, FLOAT(pickup_longitude) AS lon, medallion
  FROM [833682135931:nyctaxi.trip_data])
  WHERE lat != 0 AND lon != 0)
  WHERE ABS(HASH(medallion)) % 1000 == 1
  GROUP BY geoid
  ORDER BY pickups DESC
  LIMIT 25
SELECT FIRST(lat) AS lat, FIRST(lon) AS lon, COUNT(medallion) AS pickups
  FROM (SELECT lat, lon,
         CONCAT(STRING(FLOOR(lat*1000+0.5)/1000), ':', STRING(FLOOR(lon*1000+0.5)/1000)) AS geoid,
         medallion
  FROM (SELECT FLOAT(pickup_latitude) AS lat, FLOAT(pickup_longitude) AS lon, medallion
  FROM [833682135931:nyctaxi.trip_data])
  WHERE lat != 0 AND lon != 0)
  WHERE ABS(HASH(medallion)) % 1000 == 1
  GROUP BY geoid
  ORDER BY pickups DESC
  LIMIT 25

When executing results(), I also see the query metadata twice.

Have you seen this again since October?

Closing as obsolete/no repro.


Remove references in Makefile in the "Connecting Applications with Se…

…rvice" page
The page "Connecting Applications with Service" has some reference to a Makefile
(https://github.com/kubernetes/examples/blob/master/staging/https-nginx/Makefile)
that creates a key pair with a different name than expected in the example.
As this Makefile is being used in other examples, it's not possible to change the
key pair. So the user would need to edit the Makefile to align it with the expected
key pair name,
This page described an alternative way to create these resources, so I am making it
the only way, so that it's clear the steps the user needs to follow
It addresses #34322
Signed-off-by: Eduardo Patrocinio<EMAIL_ADDRESS>

Hi @patrocinio , please rebase this PR as this PR contains a merge conflict at its current state

👋🏻 @patrocinio Do you need any help rebasing the PR?
We couldn't merge this as-is as there is a conflict that the automatic system does not know how to resolve.
Here are some references/tips for the following:

merge conflicts and rebasing
squashing commits

Another option would be:
Close this pull request, and open a new one based on the main branch that makes the same changes. In the new PR, mention that it's a replacement for PR https://github.com/kubernetes/website/pull/34567
Thank you.

/close


[WFCORE-5413] Upgrade Apache sshd-common to a version that depends on slf4j 1.7.30

https://issues.redhat.com/browse/WFCORE-5413

#4594 also does this upgrade.


reboot.scss typo  (shttp --> http)

CSS-Tricks has TLS enabled by default, so we might as well change it to https directly.

@hnrch02 sg. updated.

Nice, thanks!

<3


Add fix for Signable::operator==

Description of the Change
Fix the wrong behavior of signable::operator==. And provide tests for it.
Benefits
Fix unordered set checks in operator==
Possible Drawbacks
Current solution consumes about N^2 operations. There is possible to improve it with O(N).

There is possible to improve it with O(N).

Not really (or I'm too silly, so please explain how), it's O(nlogn) with sorting (that basically requires copying though probably not efficient in that particular case), since SignatureRangeType is forward iterable. This optimization task probably requires some refactorings, so it would be nice to add the task in jira
Also please update the branch, so CI becomes green

@l4l
Solutions with O(N) is the following. Rework unordered_set with set. And fetch the first elements from left and right for 2lg(n) and check iterators for O(n) because iterating on the tree is O(1). The last step to check the equality size of left and right. So, we have: 2lg(n) + O(1)n + 2O(1) == O(n).

@kamilsa

Maybe we can change the signature set type to ordered set?

Yes, it possible. But I think the change doesn't relate to the current pr, isn't it?

@muratovv then we need to create the task in Jira for that


Enable testing in windy environments

Describe problem solved by this pull request
Previously, wind was a gazebo model plugin since wind was simulated by applying "force" on a link. Since wind was a element inside the model, models could have different wind simulated even if they are in the same world.
However, this has changed since https://github.com/PX4/sitl_gazebo/pull/462. Therefore, we can make the wind a property of the "world" and make different vehicles be affected to this no matter which vehicle is spawned in the world.
Describe your solution
To simulate a windy world, simply run the following.
make px4_sitl gazebo_plane__windy

Test data / coverage
Log: https://review.px4.io/plot_app?log=04b3ea46-2489-424d-904c-3e2aadf820cc
Additional context
Depends on PR https://github.com/PX4/sitl_gazebo/pull/467

@Jaeyoung-Lim the complex increases, but what if we make the windy another target that composes the final targer, and that you can use with any world?

Well because that requires one to manually set it on the SDF file. This is just a shortcut with a default value

@TSC21 Then we need to start generating world files... Wouldn't this be too complicated to be tractable?
@MaEtUgR Nothing actually, it is just that PX4/sitl_gazebo has its own wind messaging structure that is not compatible with upstream. We can also try to make it compatible with upstream wind topics but we have less control over what kind of wind/gust we can generate in this case.

@TSC21 Then we need to start generating world files... Wouldn't this be too complicated to be tractable?

Well not really. A simple python script would easily enable to add some lines to the world files that you wanted to use. No need for templating, although it could be worth to have a single template from where you could add certain properties to the existing world files. I.e imagine you want one specific world with wind - you pick the template, set what world you want to add wind to, and a new world with the suffix _windy is created and used.

Just to be clear: this PR is fine and the simple approach is fine. I was just trying suggesting we could make it a bit more flexible if that doesn't take too much effort.

@TSC21 I had some thoughts about this, and I think generating windy environments can be added separately in sitl_gazebo repository when it is built.
If we add these windy worlds to be generated in build time, would having a windy world for every world be something close to what we want?
We still need these worlds to exist to be able to spawn multiple vehicles into the world, so I think it would be better than generating a temporary world file at every make.

@TSC21 I had some thoughts about this, and I think generating windy environments can be added separately in sitl_gazebo repository when it is built.
If we add these windy worlds to be generated in build time, would having a windy world for every world be something close to what we want?
We still need these worlds to exist to be able to spawn multiple vehicles into the world, so I think it would be better than generating a temporary world file at every make.

Wouldn't that had too much duplication?

@TSC21 Or maybe a small set of environments? What I want to avoid is re-editing the world files when we envoke a makefile. So that it is a bit more simpler and easy to understand what it is doing.

If I could add my 2 cents here: it would be awesome if we would have an interface to easily set a specific windspeed, either during runntime (guess not easy), or else before running the sim with a environment variable. I really mostly care about the magnitude of the wind (horizontal), and not so much about the variance and variance.
If you guys prefer the approach here, then I'm also fine with it - and for me having just one windy world would suffice.

@Jaeyoung-Lim can we make a commitment to extend this as suggested in the above conversation we had? Thia is acceptablr as is but I think we can make much more flexible for the different worlda.

@TSC21 For sure!


Revert "feat: Provide scaler search and list external scalers from Artifact Hub"

Reverts kedacore/keda-docs#805

Could you sign the commit?


Can't choose or select radio button programatically on start

I'm trying to set selection on radio button programatically but i cant figure out how can i do that

For swift, please use isSelected instead.


Can we containerise this ??

I wanted to make a docker file of this. But was not able to do it is it possible ?

The registry server can be run via the Registry CLI (which uses Docker beneath the hood to run the registry) or manually using Docker.
To get started with the Registry CLI, follow this guide.
For running it manually, simply git-clone (1) the sunbird-rc/core repository and start the registry via docker-compose (1):
> git clone https://github.com/Sunbird-RC/sunbird-rc-core sunbird-rc/core
> cd sunbird-rc/core
> docker compose up


Add internationalization support

Since it looks as though there will be some reworking of the UI its probably a good idea to think about using an internationalization library and defining strings for various messages that get sent to the user.

moved to https://github.com/drone/drone-ui/issues/151


read-only INSERT forbidden?

I was a bit surprised that I can't insert a row with skdb_access set to read-only:
INSERT INTO messages (username, message, skdb_access) VALUES ('user2', 'msg3', 'read-only');
Could not eval query. Try `.help`
SkRuntimeExit [Error]: INSERT INTO messages (username, message, skdb_access) VALUES ('user2', 'msg3', 'read-only');
^
|
 ----- ERROR
Error: line 1, character 0:
cannot insert with skdb_access set to read-only (user f8b7WiJln5Scgj-T5inTJcn7Fi)
...

What are the valid values of skdb_access? Are they:  user ID; group ID; read-write; and that's it? Or are there are other valid predefined groups one can use?

read-only is only really useful for server-side virtual views.

Closing skdb-specific issues as skdb in its current form is being deprecated.


GameCenterManager compilation issues with 1.0.Beta2

RoboVM version 1.0.Beta02 has broken GameCenterManager and doesn't compile anymore. I've tried to fix it but the setters for the delegates have disappeared so there must be a "new way" of doing this but I'm not sure how. Will update if I find out how to do it.

@BlueRiverInteractive any idea when is gonna be available?
Right now beta-02 still has the issue.
Just to be sure, I have deleted Gradle cache and download everything again, but GameCenter is still broken.

You will need to use the nightly version of robovm. I've updated build.gradle of this repository to use the nightlies.


I am not able see the registration entry  on the trials page where we can see the token.

Read https://developer.chrome.com/docs/privacy-sandbox/third-party-cookie-phase-out/ for context before raising issues here.
For site-specific issues with third-party cookies, please report this via https://goo.gle/report-3pc-broken
I signed up for grace period but I am not able see the registration entry  on the trials page where we can see the token.

Hello @avinash-poptani, please follow each step of the instructions in the deprecation trial post. Let us know if you're still experiencing problems.

Thanks @clementsimon .
After resubmitting it worked. For failed registration got below response from support on Ticket
"Apologies for the trouble here. Our engineering team investigated and it looks like the registration failed on the backend. Can you please register again using the same email address and reference this in your submission?"
Closing the ticket now.


Fix Duration vs Interval comparisons and Interval as LHS

Which issue does this PR close?
Close https://github.com/apache/datafusion/issues/11891
Rationale for this change
We regularly want to allow queries of the form
SELECT * FROM records WHERE end_timestamp - start_timestamp > interval '2 seconds'

Until now that failed with
type_coercion: Cannot infer common argument type for comparison operation Duration(Microsecond) > Interval(MonthDayNano)

While working on that, I discovered you couldn't compare to an interval with the interval as the left hand side of the operation, so I fixed that too.
What changes are included in this PR?

fix Duration vs. Interval comparison - sense check - is it really as simple as it looks?
support more operators in machinery to support intervals as the LHF of binary operations
add tests for both

Are these changes tested?
Yes
Are there any user-facing changes?
Should be only the above changes to support SQL.

Thanks @samuelcolvin


How can I checkout the same git revision on a second build?

We have a system that allows us to have a VSTS build spawn one or more "child build(s)" which run in parallel to the parent build and then consolidate the results of the children so that we get an overall pass or failure on the main build. We do this with a utility that calls out to the VSTS REST API to create the child builds and then later to monitor their status. This part works fine and has been in use for some time.
Up until now, the child builds did not use our git-based source code and instead just operated on binaries shipped from the parent to the child. Recently, however, we decided that we need the child build to checkout the same git revision as the parent. So I added code that sends the revision of HEAD from the parent (output of git rev-parse HEAD) to the child and then a step on the child which does git checkout with that revision. This works fine for cases where a build is queued manually from any branch or a specific commit ID, but when a build is triggered automatically as part of CI for a pull request, the parent build runs on the result of merging the branch from the PR with our master branch, and the revision returned by git rev-parse HEAD apparently is unavailable on the child build.
Looking at the output of the Get Sources step, I see that the fetch command which VSTS uses in this case looks something like:
git >misc flags< --depth=1 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/56503/merge:refs/remotes/pull/56503/merge
The question for me is: where does it get the number 56503 or really that path in general. It looks like that ref contains the revision I want, so if I could communicate it to the child build I would be golden, but when I'm inside a build task I don't know how to get it. Is it a predefined variable? Or is there some code I can use to retrieve it?
My agents are all at version 2.120.2
My current tests are running on Windows Server 2012, but I will need this to work on OSX and Linux as well.
I use VisualStudio.com with my own private agents.  Account name is https://msdata.visualstudio.com

@simmdan try run a set in a PR to print out all ENVs. i believe there is  "build.sourceBranch": "refs/pull/767778/merge",

Yes, that's what I'm looking for.  Thanks for the help.


feat(tracing): introduce OpenTelemetry driver

Summary
With Envoy now supporting OpenTelemetry, LightStep has chosen to no longer support the LightStep Tracing driver. This driver and its config has been removed in Envoy 1.24.0. This is a blocker for upgrading Emissary-ingress to Envoy 1.24.

OpenTelemetry Introduced
LightStep Support Removedhttps://github.com/envoyproxy/envoy/pull/21370
OpenTelemetry Tracing Config

Plan

[ ] Introduce OpenTelemetry Driver
[ ] Deprecate LightStep with deprecation notices that it will be removed in the next minor version of Emissary-ingress
[ ] Provide upgrade documentation for moving from LightStep to OtelCollector - https://github.com/lightstep/opentelemetry-demo

@psalaberria002 - FYI in case you hadn't seen the removal.

@psalaberria002 - FYI in case you hadn't seen the removal.

Yes, I was aware of the changes. The otel exporters can send data directly to the Lightstep satellites 👍