[Table] z-index issue with dropdowns in table filters

z-index issue with dropdowns in table filters and the table below. Dropdown goes behind the table and you are unable to see the dropdown options
Steps to reproduce:

go to Table story
click on filters
click on select menu
see table over dropdown

:tada: This issue has been resolved in version 2.78.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

this doesn't seem to be working for me in the latest builds, you can see it on the carbon-addons-iot-react page:
https://carbon-addons-iot-react.com/?path=/story/watson-iot-table--stateful-example-with-expansion-maxpages-and-column-resize

:tada: This issue has been resolved in version 2.79.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

still having problems with this one

:tada: This issue has been resolved in version 2.79.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Still having this problem


20240322 mme write multi leader

Implemetation of DWG and DXF writers for MultLeader, MultiLeaderStyle
see #297

Approved and merged!
Good work!


add grpc for secret network

Do you work with SCRT Labs?  If not, can you please have someone from SCRT Labs confirm that this GRPC endpoint is provided by them?

Hi, yes, it's ours, but it's gRPC-web and not gRPC. :+1:

@assafmo by grpc-web, does that mean it should be added as a REST endpoint?

Ah sorry my mistake. I guess we can close the PR then.

No it's not REST

Ok, so does this need a new category?  Or does it go in either grpc or rest?

It needs a new category IMO.

RPC is HTTP POST where the data is wrapped as JSON and base64 for binary (Also called JSON-RPC)
LCD is REST proxy for RPC
gRPC is raw protobuf over TCP
gRPC-web is HTTP2 proxy for gRPC. HTTP2 means binary support in POST payload so no need to wrap with JSON and base64

LCD is being deprecated by cosmos soon, and RPC is a Tendermint API and it has some weirdness around request timeouts.
In secret.js we're migrating to use gRPC-web exclusively as it's supported in browsers while gRPC is not.
IMO cosmjs are planing to add gRPC-web support too (Cc @webmaster128 correct me if I'm wrong).

Oh snap @sunnya97 I wasn't aware I'm talking with you (THE Sunny), you probably know all of this 🤣😅

Hehe, nice quote from wiki:

gRPC's complex use of HTTP/2 makes it impossible to implement a gRPC client in the browser, instead requiring a proxy.[5]

Then it should be called grpc-web, not grpc. Both endpoints exists and serve different incompatible protocols. "grpc" must not be used as an appreviation of "grpc-web" because there is a real gRPC.


Multiple shaders

As the complexity of the game increases, we will need to support multiple shader pipelines.

Not needed


feat: package helm chart on push

Motivation
Since we build and publish a docker image for every pr and main push, we should do the same thing for the helm chart.
❯ helm show chart  oci://ghcr.io/caas-team/charts/sparrow --version 0.2.2-commit-3158f2d
Pulled: ghcr.io/caas-team/charts/sparrow:0.2.2-commit-3158f2d
Digest: sha256:4711bb41a28e0f17ab63faa2890a6c5f4f63822b50413ecaa9be94f23cb86f37

apiVersion: v2
appVersion: commit-3158f2d
description: A Helm chart to install Sparrow
icon: 'https://github.com/caas-team/sparrow/blob/main/docs/img/sparrow.png'
keywords:
  - monitoring
maintainers:
  - email<EMAIL_ADDRESS>    name: eumel8
    url: 'https://www.telekom.com'
  - email<EMAIL_ADDRESS>    name: y-eight
    url: 'https://www.telekom.com'
name: sparrow
sources:
  - 'https://github.com/caas-team/sparrow'
type: application
version: 0.2.2-commit-3158f2d

Changes
Packages the helm chart in the ci workflow on every pr and main commit, and releases it with its version and appVersion set to commit-<GIT_SHORT_SHA>. Ensures that, whenever we build a new docker image, we also have a helm chart available.
For additional information look at the commits.
Tests done

[x] ran pipeline
[x] helm upgrade -n sparrow sparrow oci://ghcr.io/caas-team/charts/sparrow --version 0.2.2-commit-3158f2d resulted in image ghcr.io/caas-team/sparrow:commit-3158f2d being used, as expected

TODO

[x] I've assigned this PR to myself
[x] I've labeled this PR correctly

@y-eight I don't think it's an issue tbh. The helm chart is currently 5.2 KiB small. We could push like a thousand charts for every docker image that we build. Don't think its worth the effort

TLDR; we should only create charts for new, working and tagged releases of sparrow. When we start doing proper E2E testing, we should re-evaluate how we handle charts and container images for usage with E2E testing. We don't really need a new container on each push and we most definetely don't need a new chart.
My two cents:
Even though size isn't an issue now, but management of the github packages leaves much to be desired. I haven't found a quick alternative to being able to clean up the package repository or create automatic cleanup rules. Yeah scripts do exists to do this and Github does have an API, must it's not something we should spend our time doing right now.
I'm already questioning if it's meaningful to create a container image and pushing it to github for each commit (we only have 500Mi of space for packages and each container is about 12Mi big. We don't even need to push the image to the registry to do the e2e tests (the local image can be pushed into the kubernetes cluster directly).
Do we need this to manually test the helm chart? Since we don't have any test automation, I doubt we're gaining something from having a OCI chart lying around, that we can deploy. I can just build my image locally (it's much quicker) and deploy the current helm chart locally (also quicker).

merging this, but definitely agree with you @puffitos


Feat: Add c# translation parser support

For a long time, the Godot engine lacks support for i18n string collection for C# scripts.
This PR implements CsharpTranslationParserPlugin by analyzing the AST returned by Roslyn and adds it to GodotTools.

I've observed that dalexeev is adding support for comments to this system.
But the corresponding PR has not been merged. In theory, I should follow up and let C# adopt the same approach to support comments. But obviously I need his changes to EditorTranslationParserPlugin. If dalexeev's PR is merged, I will follow up and add support for comments soon.
https://github.com/godotengine/godot/pull/98099

Hi, and thank you for your contribution 🙂
This is something I wanted to tackle for quite some time, but never got to, so I'm excited to see this PR! This is a quick first review, I haven't tested thoroughly.
Did you by any chance forget to commit your editor_internal_calls.cpp file? Since you are shifting the unmanaged callbacks array in Internal.cs, not having the native change that goes with it breaks everything. Although, we don't need to define an unmanaged callback here to register the parser. We can directly call AddTranslationParserPlugin(EditorTranslationParserPlugin) from GodotSharpEditor. E.g. look at how we instantiate, and dispose of, the export or inspector plugins.
I'm pretty sure the check for a MemberAccessExpressionSyntax prevents simple Tr(string)/TrN(string) from being picked up (while e.g. this.Tr(string)/this.TrN(string) would be fine). But from a broader perspective, I don't know if the implementation isn't too brittle as is. For instance, if I have something cursed like this in my codebase, all the calls to Foo.Tr(string) are going to be picked up as if they were calls to the translation server.
public static class Foo
{
    public static void Tr(string myString)
    {
    }
}

I'm wondering if we could easily make this more resilient. Otherwise, I think this would be a very good addition 🥳

To avoid recompiling godot completely on my poor computer, I did the actual coding and testing in another godot source code directory where I was working. It seems that I forgot to move editor_internal_calls.cpp when I moved to the clean directory.
Regarding the selection problem you mentioned. It seems that simple ast parsing cannot fully handle these situations well, and more semantic analysis may be needed to more accurately identify the functions that need to be captured.

I followed up on dalexeev's PR. Added support for translation comments.
In addition to supporting single-line comments, there are also multi-line single-line comments and C# multi-line comments.

Example
using Godot;
using System;

public partial class Test : Node
{
    public override void _Ready()
    {
            GD.Print(Tr("Tr1"));
            GD.Print(Tr("Tr2", "ctx_a"));
            GD.Print(Tr("Tr3")); // NO_TRANSLATE
            GD.Print(Tr("Tr4")); // TRANSLATE: Message 4
            // TRANSLATE: Message 5
            GD.Print(Tr("Tr5"));
            // Above comment.
            // TRANSLATE: Message 6 Line 1
            // Message 6 Line 2
            // Message 6 Line 3
            GD.Print(Tr("Tr6"));
            // Above comment.
            /* TRANSLATE: Message 7
             * Message 7 Line 2
             * Message 7 Line 3
             * Message 7 Line 4
             */
            GD.Print(TrN("Tr_n7", "Tr_n7_plural", 0, "ctx_b"));

            GD.Print(Tr("Tr8", "ctx_c")); // TRANSLATE: Message 8.1
            GD.Print(Tr("Tr8", "ctx_c")); // TRANSLATE: Message 8.1
            GD.Print(Tr("Tr8", "ctx_c")); // TRANSLATE: Message 8.2
            GD.Print(Tr("Tr8", "ctx_d")); // TRANSLATE: Message 8.3

            // TRANSLATE: Message 9

            // Empty line ^^
            GD.Print(Tr("Tr9"));

            GD.Print(Tr("Tr10")); // TRANSLATE: Message 10
            GD.Print(Tr("Tr11"));
    }
}

# LANGUAGE translation for i18n_test for the following files:
# res://test.cs
#
# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
#
#, fuzzy
msgid ""
msgstr ""
"Project-Id-Version: i18n_test\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8-bit\n"

#: test.cs
msgctxt "ctx_a"
msgid "Tr2"
msgstr ""

#. TRANSLATORS: TRANSLATE: Message 7
#. * Message 7 Line 2
#. * Message 7 Line 3
#. * Message 7 Line 4
#: test.cs
msgctxt "ctx_b"
msgid "Tr_n7"
msgid_plural "Tr_n7_plural"
msgstr[0] ""
msgstr[1] ""

#. TRANSLATORS: TRANSLATE: Message 8.1
#. TRANSLATE: Message 8.2
#: test.cs
msgctxt "ctx_c"
msgid "Tr8"
msgstr ""

#. TRANSLATORS: TRANSLATE: Message 8.3
#: test.cs
msgctxt "ctx_d"
msgid "Tr8"
msgstr ""

#: test.cs
msgid "Tr1"
msgstr ""

#. TRANSLATORS: TRANSLATE: Message 4
#: test.cs
msgid "Tr4"
msgstr ""

#: test.cs
msgid "Tr5"
msgstr ""

#: test.cs
msgid "Tr6"
msgstr ""

#: test.cs
msgid "Tr9"
msgstr ""

#. TRANSLATORS: TRANSLATE: Message 10
#: test.cs
msgid "Tr10"
msgstr ""

#: test.cs
msgid "Tr11"
msgstr ""

Hello, and sorry for the delay.
All of this feels quite good to me. I have a small doubt about the compilation context we are building, we might be missing some translation strings because of undefined conditional compilation symbols. I noticed this because some of my test files were calling Tr(string) from inside #if TOOLS sections, and thus weren't picked up.

I updated the support for conditional compilation, and now we can correctly handle the acquisition of i18n resources through compilation symbols.
But the bad news is that in order to ensure that all i18n resources are collected as much as possible in the editor, I enumerated the platform information, which led to multiple code syntax tree generation work, which brought huge performance problems.
This made the work that could be completed in 1 second before take nearly 20 seconds.
The code mainly consists of two parts:

Reference data collection (only executed once for each generation task): used to obtain the MetadataReference data of the target project.

Code scanning (needs to be performed for each file): by converting the code into a syntax tree, and then scanning the entire syntax tree, the semantic model is used to obtain the functions that meet the conditions.

The test found that after the new version enumerates the platform information, the data collection part takes 6~7 seconds to complete the work. The code scanning part, using the test case above, takes 7~8 seconds to complete.
In the old version, the whole work can be completed in just over a second.
In addition, the UI interface generated by pot currently does not do any progress display, which will freeze the editor interface for a long time when the generation task takes too long. This may be a problem that needs to be fixed.
cc @paulloz


SVD file contains names with multiple underscores in a row

I'm not sure if this is something that should be addressed in the SVD file, but it is a problem for us in so far that the code generated from it compiles only with warnings. We address this in this patch.
As I said, I'm not sure if this needs to be fixed upstream, but as I have to contact NXP about other issues anyway, I'm going to bring it up. The names are weird after all, and it's definitely not intentional, as those names seem to be generated from the human-readable description.

I've reported the issue to NXP: https://community.nxp.com/thread/465465

Migrated to new repository: https://github.com/lpc-rs/lpc-pac/issues/16


Unexplained intensity and number of disconnections and reconnections

We have been observing an unexplained intensity and number of disconnections and reconnections

I'll ditto this observation.  Here's a graph of bee_kademlia_currently_connected_peers for the past 12 hours on 3 of my mainnet nodes.   Interesting that only 2 of them have the square-wave appearance.


Suggested Updates to the README

Working on the README to provide more detail. Things will have to be changed with respect to technical details. This also implies that we are checking the application against Travis.

@germonprez What is wrong with the pip install from github?

Nothing wrong with it. Happy to change.
Yea, I think that the install script should be in this repo.

@germonprez Sounds good!


Polymod error Help.

Describe your problem here.

Whenever I run the setup.bat file, it can't install Polymod for some reason, any help is appreciated.
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

polymod isn't used in psych engine
so close this

Polymod is unused in Psych, so for that, use another engine that DOES support Polymod, like Kade and such.
So, please close this.


Invert --no-deps flag to be default on scoped execution

According to the docs, the task will run on the dependants of the scoped packages unless the --no-deps flag is passed.
It would be nicer if this was inverted so that the default case was to run the tasks excluding dependants and have a flag, say --include-dependants to run the task for dependants.
This would save typing for developers when running tasks in their local dev loop.
The --include-dependants flag can be used in CI scripts.

So we added a new flag called "--to" that does both at the same time. This preserves the behavior and actually becomes a nice syntactic sugar.


Use same classloader when filtering @Categories in JUnit

This fixes https://github.com/gradle/gradle/issues/3189
Previously we load JUnit Categories with application classloader,
which might mismatch with actually classloader (e.g. Powermock)
and result in invalid categories configuration. This PR uses same
classloader with Runner when loading category classes to avoid
this issue.

@acourtneybrown Could you please take a look at this? This looks like a simple issue.


Global grants should allow choosing read and/or write

The global grants filter should be configurable as to whether you're checking read and/or write. In some cases, we want to allow global reads for example, but not global writes.

if the use case for global-reads is website hosting, they should configure the bucket as a website, which will remove it from being considered a global read access system. in general i think any such global-reads for non website should be considered as a recorded exception via filter, rather than blanket allow by letting them go through.

The issue here is that when you add an exception, you add it for all global grants. It would be useful to have exceptions specifically for read or writes. One thought is to have the policy configured so you can say whether you're configuring enforcement of global reads, writes or both (default). Your yaml could have 2 policies - one for read, one for write - and you could have different exceptions for each.

makes sense and sounds good.

merged


uploading sample gateway mock api files

files to review

closing pr to trigger scan

reopen to trigger scan

retry scan trigger

retry scan

Looks good. I'm happy that you added more details to the logs, including the caught exception.

Thanks for your review @ImranAliMohammed. Please review again as i had to push some state change to the branch.

close and rerun the test

rerun the trigger


Ioniq 2019 CAN error

Describe the bug
Switched from Ioniq 2020 plug-in to the Ioniq electric 2019 (a supported car). Haven't got it working with either car. All it says is "CAN Error: Check connections" after a few seconds of booting. Uninstalled and reinstalled stock, swapped the cables, ( I have two sets of most cables because a reorder of new car harness)
With the Ionity 2020 I just got "non-supported car" message.

Provide a route where the issue occurs
26e73a0e32642dc4
openpilot version
0.8.16
Additional info
this bug report is for the 2019 Ionity electric.

It appears your car isn't broadcasting the FCA (forward collision assist) message, and we couldn't get any ABS firmware either. Does this car have Smart Cruise Control (it accelerates and brakes for cars), as well as automatic emergency braking?

wow you can read all that from the short time I was online?  are you sure you are looking at the right car and not the earlier ionig plug-in 2020?
to answer your question it does have forward collision assist. not sure what ABS firmware is? dosent all cars today have ABS breaking?
Q: will C3 not detect if you disable a feature in the setting like forward assist?

Does this car have Smart Cruise Control...

This part is vital to know from your 2019 Ioniq EV.

Just realised, its Ioniq not Ionity ofc.

https://i.ibb.co/9sW1xyw/20221120-022652.jpg
https://i.ibb.co/k6LmZcS/20221120-022635.jpg
When I go to the CC settings in the car, while the C3 is on I can't change the settings and it's stuck at "regular LKA" instead of "Active LKA" which I guess would be the correct settings?
If I remove/turn off the C3 I can change the settings freely again.
A thought: can the language difference in the car mess with the comma ai code somehow?

Have you disabled forward collision assist?

@danevito can you please confirm if your car is a 2019 Hyundai Ioniq Electric, with Smart Cruise Control?
It would also be very helpful if you can take a picture of all the buttons on the steering wheel in a single picture.

I am still wondering if the language difference can cause some confusion in C3?
Have other people with Ioniqs reported problem after a open pilot version upgrade in the past?

Is this related??
https://github.com/commaai/openpilot/pull/20706

@danevito can you post a route with this issue on the latest master branch, with raw logs uploaded?

• Share your device with me (https://connect.comma.ai/, gear icon, share by email<EMAIL_ADDRESS>share icon again to confirm), set the device name to your year/make/model and your Discord username (with #xxxx) so I can find it in the list.
• Go to https://connect.comma.ai, select the route with the issue, More info, next to "View in cabana" -> click "upload", then Files, View upload queue, and confirm all raw logs are uploaded.
• Post the route ID in this channel.

26e73a0e32642dc4|2023-01-15--12-02-50--1

I am only using the dashcam at the moment, do you want me to upload a route with open pilot on?

I am only using the dashcam at the moment, do you want me to upload a route with open pilot on?

@danevito going to need a route that has "CAN error" generated.

26e73a0e32642dc4|2023-01-16--19-40-46--1
this is the new one with CAN error

Are you sure you have a 2020 Ioniq EV? I checked your FW versions and they more closely match the 2019 Ioniq EV Limited, which when I run your route under that car, everything works fine as it expects the FCA message to be bad or not exist and doesn't rely on it. Perhaps your 2020 Ioniq EV is actually the American 2019 model year, as that would be a good explanation of why your car doesn't match our expectations of a 2020

Are you sure you have a 2020 Ioniq EV? I checked your FW versions and they more closely match the 2019 Ioniq EV Limited, which when I run your route under that car, everything works fine as it expects the FCA message to be bad or not exist and doesn't rely on it. Perhaps your 2020 Ioniq EV is actually the same as the American 2019 model year, as that would be a good explanation of why your car doesn't match our expectations of a 2020.
You were CAN fingerprinting to the 2020 because we were missing CAN fingerprints for the 2019, so once I add your versions to the 2019 this should be resolved.
@danevito can you confirm which harness letter type you purchased, and did it fit without any issues?

Ah, found the issue, not sure why I didn't see it before. Your car is fingerprinting as the 2020 Ioniq EV for two reasons:

We don't have your car's exact FW versions in the database
We only have a CAN fingerprint for the 2020 Ioniq EV

I added your versions here on this branch, let me know if you get a chance to test it:
https://github.com/commaai/openpilot/pull/26988
Installer URL: https://installer.comma.ai/commaai/fp-ioniq-20-as-19
To confirm, the Hyundai C harness worked for your vehicle?

@danevito merged, you should be good to go on master or master-ci branches:
Installer URL is now:
https://installer.comma.ai/commaai/master-ci

cheers m8, looks to be working alright.   uploaded and shared my first open pilot ride here: 26e73a0e32642dc4|2023-01-18--15-03-00--0
can you explain the difference in master-ci and master?  are both non-tested builds?
when will I be able to update to the current latest model?


Unequipping an item no longer removes the weight from the actors encumbrance

I am not sure if it was ever intentional, but previously I believe unequipping an item in the Actors character sheet would remove that items weight from the encumbrance calculation (it has been a good year since I last used Foundry). This way, I was able to simulate certain items being dropped on the ground before an encounter, so that the Actor is no longer encumbered.
This has apparently either been changed, or it is some kind of bug. Some details:
I set up a world with many different modules and imported a character from D&D Beyond. I am also using the variant encumbrance ruling, though I doubt that has much influence on whether an item being unequipped still counts towards the encumbrance. After discovering the aforementioned problem I disabled every module to make sure the behavior was still reproduceable, so it is not introduced by a module.
Since there are no other issues on this topic, I assume it must have been a deliberate decision to have the equipped status no longer influence the weight calculation, but is there another way to simulate a character throwing their backpack to the ground to get rid of excess weight? And I don't just specifically mean containers (which seems to be already considered in this issue), but sometimes my players would like to throw away their heavy crossbow and switch to their daggers (since they don't often mind the encumbrance penalty when using crossbows). Having to remove the item entirely (change its quantity), or change its weight each time, seems a bit excessive.

As far as I know, the system has always included the weight of unequipped items.

Thank you for your quick response. Perhaps I am misremembering something or confusing it with a module then.
Though I suppose given that, there won't be a change since obviously unequipping an item is not the same as dropping it. I suppose the easiest solution for my players shenanigans will then be to wait until unequipped containers no longer contribute to the weight and set up a "ground" container.


[Feature] Support environment variables for KubeRay operator chart

Why are these changes needed?
I realized that KubeRay operator chart does not support environment variables until https://github.com/ray-project/kuberay/pull/951#issuecomment-1477043319.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

cc @Yicheng-Lu-llll @jasoonn

LGTM!
I've also tested the changes as follows:
Step 1:
Update the kuberay/helm-chart/kuberay-operator/values.yaml file by adding the following lines:
env:
- name: test
  value: 'test-if-works'

Step 2:
log the environment variable when Reconciling
# in kuberay/ray-operator/controllers/ray/raycluster_controller.go
func (r *RayClusterReconciler) Reconcile(ctx context.Context, request ctrl.Request) (ctrl.Result, error) {
	var err error
	r.Log.Info("get env var", "test:", os.Getenv("test"))

Step 3:
Build a new kuberay image.
Step 4:
Install kuberay using the newly built image by running the following command:
helm install kuberay-operator --set image.repository=kuberay/operator --set image.tag=nightly .
Step 5:
Check the logs of the kuberay operator to confirm the environment variable can beaccesed:
kubectl logs $(kubectl get pods -o=name | grep operator)
should see the following output:
root@ip-172-31-14-57:/home/ubuntu/tmp/kuberay# kubectl logs $(kubectl get pods -o=name | grep operator) | grep "get env var"
2023-03-23T04:00:29.487Z        INFO    controllers.RayCluster  get env var     {"test:": "test-if-works"}

LGTM.
Can you update PR description with testing instructions like Yicheng comment?

Done


Added K.S.R College of Engineering to domain list

Could You add domain ksrce.ac.in Please?
Official website: https://ksrce.ac.in

@krishnanmano Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.

Thanks @philipto


Error in chang_ramsey and chang_credible lectures

Thanks @AnjuJoon .  Let's see if the build server picks this up.
We should perhaps add --upgrade to pip install polytope.
CC @mmcky

@jstac I will trigger a coverage run today. It is currently setup to only trigger once there is a change on master branch. It then runs coverage and website builds.

@jstac I have just updated this PR
https://github.com/QuantEcon/lecture-source-py/pull/544
I think the next thing to work on is:

compilation on travis or Docker so we can keep upgrading anaconda and associated packages in an easier manner.

I have triggered coverage builds on workstation and ec2 to check the latest. EC2 has the latest anaconda=2019.07

@jstac @mmcky should I add --upgrade to pip install polytope for now?


Update authors file.

Update authors file.
Use GitHub account when no email is provided.

@enolfc I wonder if we should just link to the GitHub profiles, letting users manage personal data (name, email) as they want.

OK so we just drop the full AUTHORS file and don't document anything in replacement?

So I've kept the info about repo maintainers, I guess it can be useful if people want to be able to contact someone directly.


Acting weirdly in the latest firefox v36.0.1

Hey guys,
First of all thanks a lot for this awesome script. I've been testing your plugin thoroughly and the lazy load works perfectly on chrome and opera, but in firefox it work very weirdly. I've using this lazysize on the wordpress site using the WP Retix Pro plugin (https://wordpress.org/plugins/wp-retina-2x/) which is incorporated with lazysize. A lot of image doesn't load. Even if it is  at the top of the page.
I've contacted the plugin author @tigroumeow but he said that there is no problem with the plugin end. So I would be glad if someone from the lazysize team take a look at this issue.
As my site is a live site and many people visit it every second, I cant keep the issue on the live site to show you guys. So I have deactivated lazysize for now until the issue got fixed. Instead I've screencasts a video where you will see the issue in details
https://www.youtube.com/watch?v=43DnBAEk3po&hd=1
I'll be really greatful if someone can help me with this.

Could you please give me the url of your page? This would help dramatically.

ofcourse here is my site : https://www.isaumya.com
but please note that as this is a live site with a decent amount of viewers, I've disabled the lazysize temporarily for the issue I've shown in the video :)

Well, this is hard. Basically at this point lazySizes already did everything, the only possible things are a) it did not find/invoke picturefill, b) you have changed your srcset` or picture`` config in FF from disabled to enabled or you use FF38 or c) there is an error in picturefill.
Your current https://www.isaumya.com/blog/ has one retina image. (Blogpost: Atlast! The new design has been released with Genesis). Do you see this image in FF?)

Yes currently everything is loading fine in firefox as the lazysize has been disabled. but as soon as I enabled it all things starts messing up. For a live test, if you want I can enable lazysize again on my site for few minutes and then you can test it thoroughly. Specially the shop section, blog section and other places. I hope it will help you to see the issue by yourself. Let me know if I enable it now and if you wanna see the issue live? Will be waiting for your reply.

This would be great! Enable it, just watching here.

It has been enabled and will remain enable unless you done testing it thoroughly. Do test my site on all major browsers, you will see the firefox specific issue. I didn't find this kind of issues in chrome or opera. But as I'm in windows didnt have the luck to test it in safari.
Let me know when you are done testing it, so that I can disable it. Will be waiting for your reply conformation.

ok, you can turn it off again. sorry, for taking so long.

Thats alright my friend. :) But what matters is did you find the issue behind this? I've turned it off for now :)

Ok, why did this take sooo long.  I only needed to set a breakpoint and guess what the debugger doesn't simply work. I hate it.
So yeah, the reason is quite simple. As soon as lazySizes is included picturefill is not included. But lazySizes either need picturefill or respimage to do the polyfill work. So you can fix it by just adding one of those scripts your own.
But we should hand it over to @tigroumeow again. So that he can make sure that both scripts are included.

But Retina 2x plugin already uses picturefill and its already working on my site. Did you see that?

Yes I know. But it seems, that as soon as you request lazySizes picturefill isn't added anymore

Well can you tell how to solve this weird issue? so that @tigroumeow can fix it. Also if this is the the issue what you are saying, then how it is not throwing any issue over chrome or opera? It will be really helpful if you give a solution for this weird issue. Like how this issue can be solved.

Because chrome, opera and safari do support this natively. I think @tigroumeow  thought, that lazysizes is a solution, that also polyfills. But in fact lazySizes relays on polyfills. But also can be used without a polyfill, but in that case an additionaly data-src has to be added.
I'm pretty sure he will understand as soon as he reads this.

And for you, you can fix it before he has done it by just adding picturefill manually.

I've already emailed @tigroumeow with the link of this thread. As he is from japan, its almost 5:40am there and he might be sleeping. I'm pretty sure that he will reply on this thread as soon as he sees it. Lets see what he have to say about this before doing any manual edit on his plugin code :) Every developer should respect others work, thats what I believe in. So let's see what he has to say about this. I'm pretty sure that if he understand the issue he will fix it :)

Ohayogozaimasu guys! Indeed, I thought lazySizes was standalone. I will fix this on Monday :) Thanks for all the debugging.
Not sure if I should start another thread about it but how is the script "SEO Improved"? Is it SEO for the website as a whole or SEO for the images? Personally, if I use a lazy script on my website, then Google will stop referencing the images. Did you actually find a solution for that? "src-set" is ignored by Google until now.

about this seo thing. It means, that lazyloaded assets (images) aren't hidden from googlebot. The solution is actually pretty simple. Since at least a half year the goolgebot executes JS, the only thing, that googlebot doesn't do is scrolling. The solution are two lines: here and here. This was added with version 1.0.1, but if you update your version you can test it on your site with google webmaster tools and the fetch as google tool.

Super, that sounds awesome. Just a last thing before I release a new version of the plugin. You wrote

Lazysizes does not need any JS configuration: Add the class "lazyload" to your images/iframes in conjunction with a data-src or data-srcset attribute."

I am using data-srcset if lazysizes is used, otherwise, with PictureFill alone, I use srcset. Can't I use srcset with both? Google should be able to reference both data-srcset and srcset?

Sadly, no. lazySizes needs data-srcset or another custom attribute otherwise, the browser already would load something.
With no configuration I mean you won't need to create instances or write configure something in JS.

Okay, understood. Thanks for all your help, that was very helpful :)


Tooltip is too slow when series has large number of points

Hi,
Thanks for creating a great package. I'm trying to figure out if I can use it for my projects.
I have a LineChartBarData with a few thousand points.  When I set LineTouchData(enabled: true), it takes a couple of seconds for the tooltip to appear over the mouse position after the mouse changes position.  Is there a way to make this faster/smoother?   Here's an example.   My user case is for the web.
import 'dart:math';
import 'package:fl_chart/fl_chart.dart';
import 'package:flutter/material.dart';
import 'package:intl/intl.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            TimeSeriesChart(),
          ],
        ),
      ),
    );
  }
}

class TimeSeriesChart extends StatelessWidget {
  TimeSeriesChart() {
    var current = DateTime(2021);
    final end = DateTime(2022);
    final hour = Duration(hours: 1);
    final random = Random(22);
    while (current.isBefore(end)) {
      dateTime.add(current);
      current = current.add(hour);
    }

    /// Generate a random series
    var acc = 0.0;
    values = List.generate(dateTime.length, (i) => random.nextDouble() - 0.5)
        .map((e) {
      acc += e;
      return acc;
    }).toList();

    /// I want ticks exactly at month boundaries
    xAxisTicks = List.generate(13, (i) => DateTime(2021, i))
        .map((e) => e.millisecondsSinceEpoch)
        .toSet();
  }

  final dateTime = <DateTime>[];
  late final List<double> values;
  late final Set<int> xAxisTicks;
  final fmt = DateFormat('MMMyy');

  List<LineChartBarData> generateData() {
    var data0 = LineChartBarData(
        spots: [
          for (var i = 0; i < dateTime.length; i++)
            FlSpot(dateTime[i].millisecondsSinceEpoch.toDouble(), values[i])
        ],
        barWidth: 1,
        colors: [
          Colors.green,
        ],
        dotData: FlDotData(
          show: false,
        ),
        isStepLineChart: true,
        lineChartStepData: LineChartStepData(stepDirection: 0.0));
    return [data0];
  }

  @override
  Widget build(BuildContext context) {
    return SizedBox(
      width: 700,
      height: 450,
      child: LineChart(
        LineChartData(
          minY: -24.0,
          maxY: 14.0,
          lineTouchData: LineTouchData(enabled: true),
          lineBarsData: generateData(),
          axisTitleData: FlAxisTitleData(
            show: true,
            bottomTitle: AxisTitle(titleText: 'Hourly data'),
            leftTitle: AxisTitle(titleText: 'Price'),
          ),
          titlesData: FlTitlesData(
            bottomTitles: SideTitles(
                showTitles: true,
                interval: 3600000, // each hour
                getTextStyles: (value) => const TextStyle(
                      fontSize: 14,
                    ),
                getTitles: (value) {
                  if (xAxisTicks.contains(value.round())) {
                    var dt = DateTime.fromMillisecondsSinceEpoch(value.round());
                    return fmt.format(dt);
                  } else {
                    return '';
                  }
                }),
            leftTitles: SideTitles(
              showTitles: true,
              reservedSize: 50,
              margin: 12,
              getTextStyles: (value) => const TextStyle(
                fontSize: 14,
              ),
              interval: 3.0,
              getTitles: (value) {
                return '\$${value.toStringAsFixed(1)}';
              },
            ),
          ),
          gridData: FlGridData(
            show: false,
          ),
          borderData: FlBorderData(
            show: false,
          ),
        ),
      ),
    );
  }
}

Thank you very much for any help!
Tony

Hi. mainly that's because your bottomTitles have a short interval which leads to drawing a lot of titles at the bottom (never mind you don't see them, I think they're white).
There are two solutions.
1 -> remove the interval property (or set it null, we try to find the best interval for you.
2 -> If you want to have a custom interval, calculate it to not show more than 10 - 20 titles

A short interval can be a factor. However, I found that _getNearestTouchedSpot iterates through all the spots, which is not very efficient. I have not dug too deeply, but there may be other places where that is done. I rewrote that method so it no longer iterates, but tooltips are still not as fast as they should be. I have not tested this extensively, but you get the idea:
LineBarSpot? _getNearestTouchedSpot3(Size viewSize, Offset touchedPoint, LineChartBarData barData,
     int barDataPosition, PaintHolder<LineChartData> holder) {
   final data = holder.data;
   if (!barData.show || barData.spots.isEmpty) {
     return null;
   }
   final chartViewSize = getChartUsableDrawSize(viewSize, holder);
   final spotCount = barData.spots.length;
   final idxTemp = (touchedPoint.dx / chartViewSize.width * spotCount).round();
   final idx = max(0, min(spotCount - 1, idxTemp));
   final spot = barData.spots[idx];
   if (spot != null) {
     return LineBarSpot(barData, barDataPosition, spot);
   }
   return null;
 }


chore!: Rename OriginalSquareSize to SquareSize so that same name to same thing.

Description
Since this is my first PR to Celestia. I list the steps for your reference.

fork the https://github.com/celestiaorg/celestia-core
create the branch according to issue
build and thest the unchanged code ( here are 2 errors of test, but I don't think it's relative, one is about http, and other is state index )
work out a solution ( include checking potencial affects to downstream projects like celestia-app, it will be break if we don't change it )
modify codes
review codes by compare to orign ( here is a unused function in block.go, but I believe I'm not relative )
build and test the code ( here are still the 2 errors )
compare to orign again to ensure the auto-generate file works
submit and push to my fork
create PR here

Closes: #853

Thanks for the detailed steps in the PR Description @HoytRen
I hope https://github.com/celestiaorg/celestia-core/pull/856 makes the steps in the README clearer for future contributors

I updated the PR. It seems here need 1 more check step after bulid to ensure the auto-generated file works, so I updated the discription, then @rootulp could use it later.

When I buld the project. Sometimes I got a dead lock error. I fell it could be important, then I put it here ( I'am not sure if I shoud create a new issue or I should look into it first ).
error01.txt

By the way, I'm thinking about that could we remove these auto-generated files from git ?

By the way, I'm thinking about that could we remove these auto-generated files from git ?

I don't think that's something we can safely do. if we removed them from git, then people would have to generate them before building, which is cumbersome. More importantly tho, depending on people's setup, the compilation of these files can differ (this one reason why the cosmos-sdk uses a docker image to compile), which would likely lead to a break in consensus. Also, this is a significant departure from what upstream tendermint does, which is a non-starter.

Yes, its a sound reason for keeping these files.
Thank you very much for telling me the make target, then I don't need to format it manually. I should not have a mistake like this.
I fixed it and please review it again. Feel free to tell me if here are something could be improved. I'm very happy to learn all of these.

It seems OK this time. thank you very much for your encourage.
I add proto-format and proto-gen to my local make file, let them always run, so that I don't repeat these mistaks.
Please review again.

Thanks a ton for this contribution @HoytRen !

Really happy to complete the task with the help from both of you 2. Let me think about next :)


Error: The model articles can't be found

Configuration as below:
{
  connection: {
    node: env("ELASTICSEARCH_HOST", "http://<IP_ADDRESS>:9200/"),
    auth: {
      username: env("ELASTICSEARCH_USERNAME"),
      password: env("ELASTICSEARCH_PASSWORD"),
    },
  },

  setting: {
    version: 1,
    validStatus: [200, 201],
    validMethod: ["PUT", "POST", "DELETE"],
    fillByResponse: false,
    importLimit: 3000,
    index_prefix: "",
    index_postfix: "",
    removeExistIndexForMigration: false,
  },
  models: [
    {
      model: "articles",
      pk: "id",
      plugin: true, // changed to true
      enable: true,
      index: "articles",
      relations: [],
      conditions: {},
      supportAdminPanel: true,
      fillByResponse: true,
      migration: true,
      urls: [],
    },
  ],
}

The Elastic Search admin panel also appears blank and while clicked on migrate it throws error 500
Screenshots below:

@sandiprb
Can you change plugin prop to false and test again

@sandiprb
Can you change plugin prop to false and test again

That worked @marefati110
Thanks a lot!!

That worked @marefati110
Thanks a lot!!

@sandiprb
Can you change plugin prop to false and test again

This worked for me as well.

@sandiprb
Can you change plugin prop to false and test again

This worked for me as well.


Rethink _

Should it have a clearer name? Should it have a helper for parsing too?

It's currently filling in for #[3, 2] and #{foo: 3, bar: 2} so maybe it would be better have it behave more specifically for object vs array args? or something
and it needs to be usable as a read-only object/array, and also a key for a map, or a value in a set

its fine

reopening - had a thought that this could become more of a 'serialise' function in general.
and objects could set something like toJSON or [Symbol.serialiser] to tap into it


Question regarding license

I noticed that there is a COPYING file at the root of the project (which I presume is because of using skeleton from fincs/hybrid_app). Would it not be a better idea to move that to a separate folder like licenses/hybrid_app.license. Reason I ask this is because I got confused about two licenses being provided for the project and had to do some headscratching to figure why the zlib license was present for.

Closed as this issue is solved or made irrelevant by the changes on the yoga branch.


Re-factor the PDFDataRangeTransport unit-tests and enable them in Node.js/Travis

There doesn't appear to be any particular reason for only running these unit-tests in browsers, since the PDFDataRangeTransport functionality itself should be back-end agnostic.

/botio unittest

Thank you for doing this!

Thanks for the very quick review!
I believe that we're now running all the possible unit-tests in Node.js/Travis, with the sole exception of test https://github.com/mozilla/pdf.js/blob/ff74a66672c2980aa3dc2dd1b6f1407026b831de/test/unit/api_spec.js#L656-L663


Select with Search option

Why there is no select with search option ?
Before opening:

Search for duplicate or closed issues
Read the contributing guidelines

Feature requests must include:

As much detail as possible for what we should add and why it's important to Bootstrap
Relevant links to prior art, screenshots, or live demos whenever possible

Please actually read and respond to the issue templates instead of including them in your comment :).

Why there is no select with search option ?

No idea what that actually would be. 😬 Please provide some examples or something.

Please actually read and respond to the issue templates instead of including them in your comment :).

Why there is no select with search option ?

No idea what that actually would be. 😬 Please provide some examples or something.

Closing until we hear more.

Closing until we hear more.

Yes, I was looking for a similar one too. And I was surprised that this was not implemented!
Here is an example of what the author is talking about and what I am talking about:

Closing until we hear more.

I would like to see something like this in the documentation, a very necessary element! I think many will be happy about this!


Add scripted_upsert to bulk_update_request

its the same as on update, just add it to bulk update request.
work on bulk as mention elasticsearch issue #19413

Thanks for your support. The scripted_upsert flag is available in 5.0.24+ which will be released later today.


Some more micro-optimizations

With the "Create less garbage during serialization and deserialization" commit the read performance still drops when I switch to JGroups 3.0.3, but at least now it's compensated by a significant increase in write performance:
Done 92,281,559 operations in 38.34 seconds using 5.1.0-SNAPSHOT/JGroups 3.0.2.Final
92,184,947 reads and 96,612 writes
Reads / second: 2,404,399
Writes/ second: 2,519
Done 91,291,477 operations in 36.25 seconds using 5.1.0-SNAPSHOT/JGroups 3.0.2.Final
91,206,383 reads and 85,094 writes
Reads / second: 2,516,126
Writes/ second: 2,347
===
Done 93,797,326 operations in 58.92 seconds using 5.1.0-SNAPSHOT/JGroups 3.0.3.Final
93,573,687 reads and 223,639 writes
Reads / second: 1,588,183
Writes/ second: 3,795
Done 84,604,761 operations in 46.94 seconds using 5.1.0-SNAPSHOT/JGroups 3.0.3.Final
84,439,591 reads and 165,170 writes
Reads / second: 1,798,769
Writes/ second: 3,518

Sanne, no, it's not reused - in fact we're creating two marshaller instances for each call (one global, one local), and two unmarshaller instances.
We do reuse marshallers in GenericJBossMarshaller, which is used in the HotRod code, and I think at some point we reused everything. But we had lots of problems with our Externalizers spawning a JBMAR instance of their own and we had to set isReentrant == true pretty much everywhere.

Ha, I'm not familiar at all with JBM. woudln't it be worth it to look at reusing only one in all cases?

@Sanne @danberindei JBMAR's Marshaller/Unmarshaller instances can possibly be reused. To provide a bit of history, when we first integrated JBMAR we had marshaller/unmarshaller as thread locals but in some cases we needed brand new instances when recursive marshalling/unmarshalling calls happened (i.e. marshall a command and while doing that, marshall a marshalled value). This, as Dan mentions, was difficult to maintain particularly when we decided to split between cache and global marshallers.
If you're working on more perf improvements, pooling is definitely worth a try.
Btw, in the future, cache/global marshaller split might dissapear again if https://issues.jboss.org/browse/ISPN-1413 is implemented because the granularity of the cache loader would be 1 to 1 with the cache manager.

@Sanne @galderz I'd love to get rid of the duplicate marshallers stuff - it's not just the fact that we create two marshaller instances, but we also serialize the parameters of a command into a buffer and then we serialize that buffer into another buffer that does into the JGroups message. i think we may even trim the buffer two times...
However, I'm not sure if that fits with where jsr107 is heading to. I have some catch-up reading to do ;-)

@danberindei I don't see how jsr107 is related. If by spec this is going to be impossible, then we'd better raise it there as something that needs to be changed: people will need to be able to implement it as efficient as possible. BTW specs should deal with API and functional expectations, not prevent you to do such things.

@Sanne I meant that jsr107 may allow different classloaders for each cache - so it may not be possible to map classloaders 1:1 to cache managers. I checked the jsr107 mailing list and it seems that there is now only one classloader per cache, however the API is kind of weird so I'm not sure it's going to stay this way: https://github.com/jsr107/jsr107spec/issues/49.


macOS Continuous Integration

I suggest CircleCi

Travis CI also can run CI on macOS.
https://docs.travis-ci.com/user/reference/osx/

We accept your contributions for macOS but we cannot spare time on macOS right now. macOS is out of our scope. Read the README.
Regarding Travis CI, if someone made a PR to support macOS build, we'll merge it.

not only adding macOS build, I'd appreciate if someone maintain macOS CI continuously.

Looking for someone who can do it.


fix preview erlang docs when TypeNames in signature

E.g. when previewing the docs for :code.load_binary.

While testing the feature, I stumbled upon the following issue:
Since commit 18a1b0e56c7e95da0d705dc3eb034fe7b686aacd Livebook freezes after clicking on the link to the docs. The console outputs the following content:

Good find. LiveView is detecting the click and terminating, but this should also have happened in earlier versions. Here is an example of a similar issue: https://github.com/phoenixframework/phoenix_live_view/pull/2611
It may be fixed on LiveView v0.19.0?

I updated to liveview 0.19.
Unfortunately the bug still exists

I think I found the issue. The doc link gets rendered like this:
View on Erlang Docs
Liveview wantsNewTab function evaluates to false, but the browser opens the link in a new tab.
So liveview unloads the live_socket which is unwanted behavior.
I tried to make monaco to render the docs with target="_blank", so wantsNewTab evaluates to true. Unfortunately I couldn't figure out how to do it.
I tried the following
~s(View on Erlang Docs)
and
~s/[View on Erlang Docs](#{url}){target: "_blank"}/
Do you have any tips?

@jannikbecher Monaco only allows certain attributes on the element, so _target is stripped out. A workaround that works is removing the empty href altogether, so that LV doesn't treat the click as navigation. Monaco only relies on the data-href since it supports custom handlers.
@chrismccord could we perhaps use a beforeunload event listener instead of the heuristic here?

@jannikbecher could you also add a test in intellisense_test.exs, we have on for hexdocs links :)

@jonatanklosko can you do me a favor and check if e.defaultPrevented is true if you bind to click in window for the monoco controlled anchors. I will have LV ignore anything that has been intercepted and prevented default behavior my downstream js. But that only works for you if they prevent default. Otherwise you can also have your own click hander in LB that stopPropagation for data-href anchors before it bubbles to LV

@chrismccord it is true! :)

@jonatanklosko LV main will respect defaultPrevented and also allows accept to be passed an an attribute which overrides the default value that LV sets, ie <.live_file_upload upload={...} accept=".jpeg" />. Give main a shot and if all looks well I'll cut a new release. Thanks!

@chrismccord both fixes work, thanks! There is one new error though, when navigating between any LVs:
caught TypeError: Cannot read properties of null (reading 'getAttribute')

in this line.

@chrismccord everything works! And no worries :)

Perfect, thank you!


Let the user know what  s/he gets when choosing a key-sequence

As a user, currently I don't understand in advance, if the key sequence I specified will or will not work, and if not, what are the reasons for that.
--
Thus, there's a proposition to add some explanatory text next to the key sequence selection UI, which would notify user about any nuances possible with the currently selected sequence.

Those nuances include:

Fn key cannot be combined with any other keys;
more than one non-modifier key in a sequence is not going to work;


Grant namespace list to global operators

Operators that support both single and all namespace installation should
request the smallest scope of permissions they need. A single-namespace
operator shouldn't require any cluster-level permissions. When placing
it into an operatorgroup selecting all namespaces, it will need list
and watch on namespaces

/retest

/retest
On Tue, Mar 19, 2019 at 12:09 PM OpenShift CI Robot <
<EMAIL_ADDRESS>wrote:

@ecordell https://github.com/ecordell: The following test failed, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/e2e-aws-olm aca9bfb
https://github.com/operator-framework/operator-lifecycle-manager/commit/aca9bfbbfdf47b2054fc34dd4e5df67e472932ca
link
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/764/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws-olm/1332 /test
e2e-aws-olm
Full PR test history
https://openshift-gce-devel.appspot.com/pr/operator-framework_operator-lifecycle-manager/764.
Your PR dashboard https://openshift-gce-devel.appspot.com/pr/ecordell.
Please help us cut down on flakes by linking to
https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests
an open issue
https://github.com/operator-framework/operator-lifecycle-manager/issues?q=is:issue+is:open
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/operator-framework/operator-lifecycle-manager/pull/764#issuecomment-474447876,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADix2lLx3W16fxK8B4hInhbXPbu-gOhks5vYQu3gaJpZM4b7CHU
.

/retest
On Tue, Mar 19, 2019 at 12:16 PM OpenShift CI Robot <
<EMAIL_ADDRESS>wrote:

@ecordell https://github.com/ecordell: The following tests failed,
say /retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/e2e-aws-olm aca9bfb
https://github.com/operator-framework/operator-lifecycle-manager/commit/aca9bfbbfdf47b2054fc34dd4e5df67e472932ca
link
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/764/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws-olm/1332 /test
e2e-aws-olm
ci/prow/e2e-aws aca9bfb
https://github.com/operator-framework/operator-lifecycle-manager/commit/aca9bfbbfdf47b2054fc34dd4e5df67e472932ca
link
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/764/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws/1548 /test
e2e-aws
Full PR test history
https://openshift-gce-devel.appspot.com/pr/operator-framework_operator-lifecycle-manager/764.
Your PR dashboard https://openshift-gce-devel.appspot.com/pr/ecordell.
Please help us cut down on flakes by linking to
https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests
an open issue
https://github.com/operator-framework/operator-lifecycle-manager/issues?q=is:issue+is:open
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/operator-framework/operator-lifecycle-manager/pull/764#issuecomment-474451985,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADixwDa8gVZpPN6MBceHTTZ_XX8cAIMks5vYQ1rgaJpZM4b7CHU
.

/retest


fix(trait): harmonize service port name

As Knative accepts a limited set of names, we can harmonize the default values to use the same accepted names.
Close #5409

Release Note
fix(trait): harmonize service port name

@lburgazzoli do you know if this change may create any problem for other deployment strategy or other clusters (ie, Openshift) by any chance?

In general if you use a service, it should not be an issue, however it may break customer deployment if they were using such name in any external tool  for any reason i.e. in prometheus' PodMonitor
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
  name: example-app
  labels:
    team: frontend
spec:
  selector:
    matchLabels:
      app: example-app
  podMetricsEndpoints:
  - port: http

I wonder if we should make this change knative only at least for now and eventually failing the integration if the use changes the port name for a Knative deployment.

As side note, this would probably cause all the integration Pods to be restarted when the operator gets upgraded

In general if you use a service, it should not be an issue, however it may break customer deployment if they were using such name in any external tool for any reason i.e. in prometheus' PodMonitor

Yes, if the monitoring is external, then, we cannot control that. I'll move this change to apply exclusively to Knative, however, there are several places where this is happening, so we need to make more verification about it.

Should be good to go now. I've worked to define a more generic approach and let any trait requiring to know the port name to use a function that will return the default based on the controller strategy used. It should be compatible with the existing Deployment as will still return http conversely to the previous commit.


Add ability to render specific products and plugin hub

Description
Render specific products based on the KONG_PRODUCTS env variable, which should be a  comma-separated list of the products to be rendered.
For example:
KONG_PRODUCTS=gateway,kic,hub make run

generates the pages for:

gateway
kubernetes-ingress-controller
plugin hub

It works by running two hooks in different stages of the generation process:

:site, :post_read: it skips pages that don't start with one of the specified product names - It always generates the home page.
:site, :pre_render: Mostly for single-sourced pages, it skips pages whose URLs don't start with one of the specified product names.

Testing instructions
Netlify link:
Checklist

[ ] Review label added
[ ] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

This is working great for me. We need to update the README and explain how to build specific versions.
How do you feel about wildcard matching e.g. KONG_PRODUCTS=gateway:3.*? Or even KONG_PRODUCTS=*:latest?


analysis bug

Environment data

Language Server version: Microsoft Python Language Server version <IP_ADDRESS>
OS: Darwin x64 18.0.0
VSCode Version: 1.38.1
Python version (& distribution if applicable, e.g. Anaconda): python 2.7.16 64-bit

Expected behaviour
p can go to function p inside t2
Actual behaviour
Cant go to definition
Code Snippet / Additional lnformation

class t1(object):
    def __init__(self, obj):
        self.obj = obj
        return

class t2(object):
    def p(self):
        print "haha"

a = t1(t2())
a.obj.p()

I'm not sure we'd be able to do this at the moment without you explicitly writing out that t1 is some generic structure with type annotations (but you're still on Python 2).
We already can't find what obj is:

Because it could be anything, and our analysis doesn't create specific versions of t1 for every invocation with a new "obj".


on readthedocs, star button is busted

There's a "Star" button in the upper left hand corner of the Puente docs on readthedocs. It's busted, though. We probably have to add something to docs/conf.py to fix it.

Per #74, we're ending Puente. Closing this out.


Represent sockets with a label placed above or beside the socket.

This is a preview image from UE Blueprint system

This is a sample node at the current state of the software

This solution interduces labels that appears upon hovering over the socket, which supports the direction of nut cluttering the scene with information.

This approach minimizes data shown on screen to be shown only when needed which calls for a more user friendly UI.
other ways like having the label above the socket made the nodes look bulky and blocky,


versions: Update kernel to 4.19.75

Include patches that fixes overlay2 issues.
Fixes: #2082
Signed-off-by: Salvador Fuentes<EMAIL_ADDRESS>

/test

Can confirm this fixes the issues we were facing pushing docker images using 4.19.73 - https://github.com/moby/moby/issues/39663#issuecomment-534809991


cant uninstall the game after use for the latest update

I used it for the latest update. Steam shown it needed to download files but it wont start. Then I tried to verify the game and tried to uninstall it. Both of them wont work and steam just keep loading. I also tried delet the game folder and it wont help.

I just tried it myself for the latest update and it works with no issues - I couldnt tell you what could have gone wrong for you.
One thing you can try is to delete the appmanifest_620980.acf file in your steamapps folder (two folders up from the beatsaber one) and see if that helps.

It works, thx


Makefile: for the generate-doc target don't use show-progress for wget

On old wget version show-progress won't work, it has been introduced on 1.16.2.
I think it would be better to simply use the verbose option and removing the -q one.
@astefanutti @squakez @nicolaferraro any thoughts?

No problem. I introduced it just for the sake of debugging, we can remove.


How we can change the CROP text on the top right to DONE?

🚨🚨 Important to remember that this library is maintained for free.
You can check the maintainers plans for the library in the Project tab.
If you really want to have some maintainer working in your feature please check the sponsorship options.
But feel free to suggest features and do yourself, this is a community driven open source library
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Obs if you have some code for it, feel free to assign yourself open the PR after this issue

We have this method you can setup on the options, let me know if do not solve
    /**
     * optional, set crop menu crop button title.

     * *Default: null, will use resource string: crop_image_menu_crop*
     */
    fun setCropMenuCropButtonTitle(title: CharSequence?): CropImageContractOptions {
        cropImageOptions.cropMenuCropButtonTitle = title
        return this
    }


Clear buttons inside fields are not accessible via keyboard

Expected Behavior
Clear button should be accessible through keyboard for 'Owner', 'Lifecycle', 'Tags'.
Actual Behavior

Navigate to Home on the left navigation.
Navigate to the main section of the page and launch NVDA.
Verify after inputing some data in Owner or Lifecycle or Tags that the clear button in those fields are accessible through keyboard.

Context
Ensure all interactive elements can receive focus and are actionable via keyboard. For example, links use the ENTER key while buttons should allow ENTER and SPACE key.
Clear button on top of each option in combo box is also not accessible.
Involved component(s):

EntityLifecyclePicker from '@backstage/plugin-catalog-react'
EntityOwnerPicker from '@backstage/plugin-catalog-react'
EntityTypePicker from '@backstage/plugin-catalog-react'
UserListPicker from '@backstage/plugin-catalog-react'

User Impact:
When any UI component are not accessible by using keyboard then user who rely on keyboard are facing difficulty and not able to perform any action and are completely block to perform any functionality on that control element.
A11y Conformance Level: A
WCAG Success Criteria: 2.1.1
Environment
Browser Information:
Google Chrome v100.0.4896.127
Firefox 99.0.1
Safari 15.4

It seems clear buttons, placed within Autocomplete comboboxes, display on mouse hover only.
For this reason, this component shouldn't be triggered by keyboard actions.
The autocomplete follows the https://www.w3.org/TR/wai-aria-practices/#combobox spec.
Reference to Material UI https://github.com/mui/material-ui/issues/30815

Got a bit confused here, but your second comment is highlighting the same thing as I conclude as well right, that this is actually the intended behavior? Is it fine to close this issue?

@Rugvip sure, it is fine to close this issue since the component it's located on the materialUI side. thanks!


GP July changes to PO migration - Hotfix 2

This hotfix PR corrects issues with PO lines and missing Beginning Balance dimensions.
PO Changes

Add Location Code association on the Negative Adjustment lines
Correct line Unit Cost and calculate Extended Cost
Split lines per receipt line to get more accurate Unit Cost per receipt line

GL changes

Beginning Balance entries were not including the dimensions, this change corrects this.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11718.


Feature Request: allow user to define the securityContext for the Policy Server deployment

Is your feature request related to a problem?
Users may have security policies to follow in order to be able to deploy workloads their Kubernetes cluster. Among this requirements can be some strict securityContext configuration. However, the current Kubewarden version does not allow user to change the securityContext used in the Policy Server deployment.
Solution you'd like
Allow  defining the policy server securityContext used in the deployment generated by the controller to deploy the policy server  in the policy server definition.
Alternatives you've considered
No response
Anything else?
This is a spin off the issue in the Helm chart repository

Maybe this is worth to be mentioned inside of the blog post about the 1.5.0 release

This change should be tested with telemetry enabled. Therefore, we ensure that the default securityContext for the pod will not break the telemetry sidecar container.

Awesome!


Re-tag and push our existing images in Docker Hub to GitHub Container Registry (GHCR)

Re-tag and push our existing images in Docker Hub to GHCR so that all our images are available in GitHub Container Registry as well.
Relates to https://github.com/kedacore/governance/issues/16

Do we really want to retag the old images? What is the benefit? (In order to consume them, we would need to change the old (already released) manifests.

As discussed offline, this was mainly to have all our artifacts in the new place; not perse to regenerate old artifacts/manifests.
https://github.com/orgs/kedacore/packages?type=source


Preserve input values in cache

Re-submission of https://github.com/hotwired/turbo/pull/70
This change will save the values of <input>s, <textarea>s, and
<select>s when creating a snapshot so that when you navigate back or
forward in history, form fields will not be reset.
This behavior was already present prior to 5dfc79e for <input>s
and <textarea>s but not <select>s (see
turbolinks/turbolinks#238).

Thank you for the review @marcoroth. I've re-structured the <select> cloning to avoid doubly index-based iteration and Array.from(...).forEach.

Beautiful, that's even better!


increase timeout for Linux unittest CI on CPU

Without specifying anything, timeout will be 30 minutes:
https://github.com/pytorch/test-infra/blob/09a6ae7404ad6628b21c079fdc499dd9ba6c8005/.github/workflows/linux_job.yml#L10-L13
It seems we barely were under that before: https://github.com/pytorch/vision/actions/runs/4286797892/jobs/7466846704
However, starting today, I saw a workflows cancelled, e.g. https://github.com/pytorch/vision/actions/runs/4304331778/jobs/7505214648
GPU already uses 120 minutes so we just align the two:
https://github.com/pytorch/vision/blob/924d373cc234bb837f09c9be0ca18fd138453d52/.github/workflows/test-linux-gpu.yml#L28
cc @seemethere

Root cause for the slowdown is a drastic perf regression starting with today's PyTorch nightly: pytorch/pytorch#95789. Given that we were already pretty close to the timeout before, let's still merge this PR.


Add GraphQL staking ledger functionality

What's going on here? Could you add a description of the changes you made @trevorbernard ?

The reason why I didn’t use the existing DB is because you can’t import staking ledgers when the indexer is running because it already has a reference to all the other column families.


Continue the workaround for https://github.com/borksh/bork/issues/42

I'm actually wondering whether it's worth skipping the check entirely. I don't know if/when mas will make this work again
https://github.com/mas-cli/mas#known-issues

Annoying. I will merge this but I will also happily accept a PR for skipping the check entirely at this stage.


Password strength

set constraints to verify password complexity.

minimum length = 8
should contain upper and lower case letters
should at least contain 1 alpha numeric characters
should contain numbers


Implement timeshift and delay operators

These two operators combined allow for replaying a data set in real-time—which is really useful when giving demos.
The timeshift [--replay-speed <replay-speed>] <field> operator adjusts a given series of time values $X_0, ..., X_n$ to $X_n' = T + \frac{X_n - X_0}{P}$, where $T$ is the time where the first value arrives at the operator, and $P$ is a factor describing the replay speed that defaults to $1.0$.
The delay <field> operator delays events until the current time is greater or equal to the value of the last entry in the given time series.
For example, the following pipeline replays all Zeek conn logs from the M57 trace used as an example in our documentation at 100x speed.
from https://storage.googleapis.com/tenzir-datasets/M57/zeek-all.log.zst read zeek-tsv
| where #schema == "zeek.conn"
| timeshift --replay-speed 100 ts
| delay ts

This is great and timeshift and delay work nicely together in your example.
Only request: let's make $T$ configurable so that user can anchor a time series at a given point.

Two observations: […]

I implemented both of these, and also a --relative-to-first option for delay that uses the first time value encountered as a baseline. Mind giving this a review?

I implemented both of these, and also a --relative-to-first option for delay that uses the first time value encountered as a baseline. Mind giving this a review?

I don't understand "relative to first". Here's how I'd like to think of this: my mental model is that I would like to wait by the inter-arrival times, which are the durations $T_{i+1} - T_i$ for every event $i$. It sounds like we're still thinking about timestamps in absolute terms? My expectation would be that I don't need to think about the first event. Conceptually, I want to "hold up" the current/last event by the time delta to it's predecessor.
If this is what actually happens, then that'd be best case and we only need to rename the option to, e.g., --inter-arrival-times to switch from the points on the timeline to the space between the points.

Here's how I'd like to think of this: my mental model is that I would like to wait by the inter-arrival times, which are the durations $T_{i+1} - T_i$ for every event $i$.

That mental model has a bug, as you're actually delaying every event by $min(0, T_{i} - T_{now} + delta)$, where $delta$ is one of the following:

$T_{now} - X$ if --relative-to X is used
$T_{now} - T_{0}$. if --relative-to-first is used
$0$ otherwise.

Let's review this in a call together tomorrow, I think that's gonna be easier.

@mavam the edit token is yours for docs.

This almost works, but we need one change: --start now is not the default for timeshift.

If I recall correctly then we discussed this already. If we do this, then we'd need a new --no-start option to return to the current behavior so that you can only apply the relative shift without also shifting by an absolute value.
Right now, the options match exactly for delay and timeshift: If --start is not set, the first time value is used as the starting time. I'd like to keep it that way.

Right now, the options match exactly for delay and timeshift: If --start is not set, the first time value is used as the starting time. I'd like to keep it that way.

That's where I am coming from as well, so that's good. 🙂
During my testing, I invoked timeshift ts and I realized that it's a no-op. That's what primarily prompted my feedback. That is, delay ts does something meaningful whereas timeshift ts does not.
But I also understand that we'd need --start-at-first again if we want the to be able to control the speedup separately. We cannot have both.


Update session-2.ipynb

Add info for keeping RGB range value when resizing your own images

Very helpful, thank you!


Improper error handling

When enabling s3 object storage, the errors from the api
https://cloud.linode.com/api/v4/object-storage/buckets Request Method: POST

are not shown in the dashboard. The popup window just closes.
I was enabling the object storage and it was responding with 400 due to :-
{
    "errors": [
        {
            "reason": "Bucket names must be between 3 and 63 characters, consist only of lowercase letters, numbers, . (period), and - (dash), start and end with a letter or number, and must not have adjacent . (period) and - (dash) characters.",
            "field": "name"
        }
    ]
}

Then too the dialog would just close without giving off any error.

Thank you for issuing a ticket! This was actually very timely since we recently implemented a fix for this. It will be out in our next release 9/3 👍


Decide which scripts/files are essential and which are redundant

Essential
Game windows:
- window 1: `molecule_builder.py`
- window 2: `feedback_buttons.py`
- window 3: `analysis.py`
- window 4: potentially `end_game_screen.py`
Redundant
-


fix(CLOUDDST-23731): cosign after push

Cosign sign requires images already been pushed to destination repo.

/ok-to-test

/test release-pipelines-e2e-suite

/test release-pipelines-e2e-suite

@emilyzheng can you sign the commit please?

@emilyzheng can you sign the commit please?

Signed now. I'd better avoid rebase from github UI next time :)

@emilyzheng can you sign the commit please?

Signed now. I'd better avoid rebase from github UI next time :)

Cool, thanks. Yeah, the rebase via UI is usually not great :)


Add support to Unix timestamp as double in the InfluxDB Sink connector

This PR is proposal to fix issue #625

It assumes Unix timestamps in seconds if type is double and coerce to Long with milliseconds precision
Add test

@afausti Thanks


Add bandit to CI for security linting

Added bandit to the CI to detect medium and high severity warnings about code we write.
(Made some fixes to handle the errors it found -- some were ignored (like hashing algorithms where security was not the intended purpose) and other small fixes were just made.)
For the timeout changes, I read that it's best to choose something that is 1 larger than a multiple of 3, and then beyond that I just chose values that I thought made sense for that particular piece of code.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[x] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@avishniakov good question. The problem with changing the hashing algorithm relates to backwards compatibility. i.e. anyone upgrading to a newer version would have the hashes stored in the database using the old algo but this update would mean we essentially wipe / invalidate their cache (in a way that perhaps does unexpected things). To do it in a graceful way would be fairly involved, I felt, where we'd have to maybe store the hashing algorithm in the database along with the hash itself.
Since none of the places where we're currently using old hashing algorithms involve security, I felt like it was an ok tradeoff. It will prevent us from adding any new places where we're using broken hashing algorithms and we can potentially consider switching out the places where it's ignored going forward as part of a bigger ticket.

You're right though that the fix is basically replacing md5 with sha256, but that would break things in unpredictable ways, I thought.

What was the reason for the various different timeout adjustments (5/7/31/#nosec) for the different requests?

@schustmi see the PR description. I didn't want to make it generically long, but that said I can also see that it might be confusing. Not sure what the right way to handle this is. Raw request.get() without a timeout passed in was flagged as a medium risk.


The meta info file could not be read Parse error, invalid metainfo checksum

Hello,
I need your help because I can't update firmware or install toolbox anymore since US2EU installed.
I have the following message every time I try to update or install toolbox: "The meta info file could be read Parse error, invalid metainfo checksum"
Please help me to fix this issue
Regards

Use google translate https://www.drive2.com/l/609057974605864068


Add op_vault-for-bitcoin-covenants-panel review to bitcoin-review-podcast

This PR adds op_vault-for-bitcoin-covenants-panel transcript review to the bitcoin-review-podcast directory.

Hey @satstacker21, it’s been some time since I last reviewed your submission, and there haven't been any updates since then. Do you have plans to work on the feedback provided?

I got pretty occupied with family time and my fiat job but I plan to resume
soon.
Regards,
Satstacker
On Wed, May 1, 2024, 10:51 Andreas @.***> wrote:

Hey @satstacker21 https://github.com/satstacker21, it’s been some time
since I last reviewed your submission, and there haven't been any updates
since then. Do you have plans to work on the feedback provided?
—
Reply to this email directly, view it on GitHub
https://github.com/bitcointranscripts/bitcointranscripts/pull/419#issuecomment-2088109692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3E327VLDXL264DDRGXOM4TZACNHPAVCNFSM6AAAAABDSYH4ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGEYDSNRZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @satstacker21, are you still planning to work on this?

No, I am not.
On Mon, Sep 23, 2024, 16:16 Andreas @.***> wrote:

Hey @satstacker21 https://github.com/satstacker21, are you still
planning to work on this?
—
Reply to this email directly, view it on GitHub
https://github.com/bitcointranscripts/bitcointranscripts/pull/419#issuecomment-2368210031,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3E327TZQRSY3IDILOG7XWDZYAICZAVCNFSM6AAAAABDSYH4ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGIYTAMBTGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Question: Unable to compile - "unknown type name ‘bool’; did you mean ‘_Bool’?"

Hello,
any idea what dependency am I missing?
I am unable to compile hello world example because of following errors:
   Compiling ext-php-rs v0.7.3
The following warnings were emitted during compilation:

warning: In file included from src/wrapper.c:1:0:
warning: src/wrapper.h:7:71: error: unknown type name ‘bool’; did you mean ‘_Bool’?
warning:  zend_string *ext_php_rs_zend_string_init(const char *str, size_t len, bool persistent);
warning:                                                                        ^~~~
warning:                                                                        _Bool
warning: src/wrapper.c:3:71: error: unknown type name ‘bool’; did you mean ‘_Bool’?
warning:  zend_string *ext_php_rs_zend_string_init(const char *str, size_t len, bool persistent)
warning:                                                                        ^~~~
warning:                                                                        _Bool

error: failed to run custom build command for `ext-php-rs v0.7.3`

Caused by:
  process didn't exit successfully: `/home/mrceperka/projects/mrceperka/ext-php-rs-example/target/debug/build/ext-php-rs-7bf2e69a5b04eccc/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-changed=src/wrapper.h
  cargo:rerun-if-changed=src/wrapper.c
  cargo:rerun-if-changed=allowed_bindings.rs
  TARGET = Some("x86_64-unknown-linux-gnu")
  OPT_LEVEL = Some("0")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_x86_64-unknown-linux-gnu = None
  CC_x86_64_unknown_linux_gnu = None
  HOST_CC = None
  CC = None
  CFLAGS_x86_64-unknown-linux-gnu = None
  CFLAGS_x86_64_unknown_linux_gnu = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "/usr/include/php/20180731" "-I" "/usr/include/php/20180731/main" "-I" "/usr/include/php/20180731/TSRM" "-I" "/usr/include/php/20180731/Zend" "-I" "/usr/include/php/20180731/ext" "-I" "/usr/include/php/20180731/ext/date/lib\n" "-Wall" "-Wextra" "-o" "/home/mrceperka/projects/mrceperka/ext-php-rs-example/target/debug/build/ext-php-rs-adeee84e1b8aaa1e/out/src/wrapper.o" "-c" "src/wrapper.c"
  cargo:warning=In file included from src/wrapper.c:1:0:
  cargo:warning=src/wrapper.h:7:71: error: unknown type name ‘bool’; did you mean ‘_Bool’?
  cargo:warning= zend_string *ext_php_rs_zend_string_init(const char *str, size_t len, bool persistent);
  cargo:warning=                                                                       ^~~~
  cargo:warning=                                                                       _Bool
  cargo:warning=src/wrapper.c:3:71: error: unknown type name ‘bool’; did you mean ‘_Bool’?
  cargo:warning= zend_string *ext_php_rs_zend_string_init(const char *str, size_t len, bool persistent)
  cargo:warning=                                                                       ^~~~
  cargo:warning=                                                                       _Bool
  exit status: 1

  --- stderr

  error occurred: Command "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "/usr/include/php/20180731" "-I" "/usr/include/php/20180731/main" "-I" "/usr/include/php/20180731/TSRM" "-I" "/usr/include/php/20180731/Zend" "-I" "/usr/include/php/20180731/ext" "-I" "/usr/include/php/20180731/ext/date/lib\n" "-Wall" "-Wextra" "-o" "/home/mrceperka/projects/mrceperka/ext-php-rs-example/target/debug/build/ext-php-rs-adeee84e1b8aaa1e/out/src/wrapper.o" "-c" "src/wrapper.c" with args "cc" did not execute successfully (status code exit status: 1).

Platform:

Ubuntu 18.04
cc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
rustc 1.56.1

Thanks :pray:

I will try to solve this with docker container... My ubuntu is probably to old :D :D

Solved with docker image.


Make make_scalar_function() result candidate for inlining, by removing the Arc

make_scalar_function serves as a template to implement functions, abstracting away processing of scalar values. While it's recommended to implement ScalarUDFImpl directly, a few functions still use the make_scalar_function helper, perhaps because it reduces code verbosity.
While make_scalar_function is a template function, it's not eligible for effective inlining because of the Arc<Fn> return type.
This commit removes Arc and unlocks inlining. The change impact was
verified manually using cargo rustc -p datafusion-functions-nested   -- --emit asm -C opt-level=2 and comparing the generated for
ArrayDistance::invoke exemplary function that uses
make_scalar_function. Only after the changes can
ArrayDistance::invoke call the array_distance_inner directly.
The change saves some small overhead on each invocation of a UDF, but doesn't improve per-row performance.

Makes sense to me -- thank you @findepi
What do you think about removing ScalarFunctionImplementation entirely? Or is it still important to have a typedef around the Arc 🤔

I think there some more usages of this type

I think we might be able to get there eventually, but @comphead is right, we're not there yet.
Some more stuff coming such as https://github.com/apache/datafusion/pull/12505, https://github.com/apache/datafusion/pull/12506.

Thanks again @findepi  and @comphead

The change impact was verified manually using cargo rustc -p datafusion-functions-nested   -- --emit asm -C opt-level=2 and comparing the generated for

FWIW with cargo-show-asm you could type something like this
cargo asm -p datafusion-functions-nested ArrayDistance::invoke
cargo asm -p datafusion-functions-nested make_scalar_function


(feature) Polymer: Reintroduce dispatched events.

See old src/behavior.js (https://github.com/canoo/dolphin-platform-polymer/blob/0.18.0/src/behavior.js).

self.fire('controller-ready');
self.fire('controller-destroyed');

Polymer v2 changed the this.fire("event-name") method call. Now we have to use
this.dispatchEvent(new CustomEvent("event-name", {
  bubbles: true,
  composed: true,
  detail: {}
})

I'll change the semantics and remove bubbles and composed, which will set them to the false default. This means, we need to register event handlers directly on the <dolphin-controller> element: controller.addEventListener("event-name", event -> {}).


Cannot detect VCS

trying to build helm from source

wget https://github.com/kubernetes/helm/archive/v2.4.2.zip
unzip v2.4.2.zip
cd helm-2.4.2/
make bootstrap build

[WARN]  The name listed in the config file (k8s.io/helm) does not match the current location (.)
[INFO]  Downloading dependencies. Please wait...
[INFO]  --> Found desired version locally bitbucket.org/ww/goautoneg 75cd24fc2f2c2a2088577d12123ddee5f54e0675!
[INFO]  --> Found desired version locally cloud.google.com/go 3b1ae45394a234c385be014e9a488f2bb6eef821!
[INFO]  --> Found desired version locally github.com/aokoli/goutils 9c37978a95bd5c709a15883b6242714ea6709e64!
[INFO]  --> Found desired version locally github.com/asaskevich/govalidator<PHONE_NUMBER>775e51966f0885f5cd27435916517b!
[INFO]  --> Found desired version locally github.com/Azure/go-ansiterm 70b2c90b260171e829f1ebd7c17f600c11858dbe!
[INFO]  --> Found desired version locally github.com/beorn7/perks 3ac7bf7a47d159a033b107610db8a1b6575507a4!
[INFO]  --> Found desired version locally github.com/BurntSushi/toml b26d9c308763d68093482582cea63d69be07a0f0!
[INFO]  --> Found desired version locally github.com/chai2010/gettext-go bf70f2a70fb1b1f36d90d671a72795984eab0fcb!
[INFO]  --> Found desired version locally github.com/coreos/go-oidc be73733bb8cc830d0205609b95d125215f8e9c70!
[INFO]  --> Found desired version locally github.com/coreos/pkg fa29b1d70f0beaddd4c7021607cc3c3be8ce94b8!
[INFO]  --> Found desired version locally github.com/cpuguy83/go-md2man a65d4d2de4d5f7c74868dfa9b202a3c8be315aaa!
[INFO]  --> Found desired version locally github.com/davecgh/go-spew 5215b55f46b2b919f50a1df0eaa5886afe4e3b3d!
[INFO]  --> Found desired version locally github.com/dgrijalva/jwt-go 01aeca54ebda6e0fbfafd0a524d234159c05ec20!
[INFO]  --> Found desired version locally github.com/docker/distribution cd27f179f2c10c5d300e6d09025b538c475b0d51!
[INFO]  --> Found desired version locally github.com/docker/docker b9f10c951893f9a00865890a5232e85d770c1087!
[INFO]  --> Found desired version locally github.com/docker/engine-api dea108d3aa0c67d7162a3fd8aa65f38a430019fd!
[INFO]  --> Found desired version locally github.com/docker/go-connections f549a9393d05688dff0992ef3efd8bbe6c628aeb!
[INFO]  --> Found desired version locally github.com/docker/go-units e30f1e79f3cd72542f2026ceec18d3bd67ab859c!
[INFO]  --> Found desired version locally github.com/docker/spdystream 449fdfce4d962303d702fec724ef0ad181c92528!
[INFO]  --> Found desired version locally github.com/emicklei/go-restful 09691a3b6378b740595c1002f40c34dd5f218a22!
[INFO]  --> Found desired version locally github.com/evanphx/json-patch ba18e35c5c1b36ef6334cad706eb681153d2d379!
[INFO]  --> Found desired version locally github.com/exponent-io/jsonpath d6023ce2651d8eafb5c75bb0c7167536102ec9f5!
[INFO]  --> Found desired version locally github.com/facebookgo/symwalk 42004b9f322246749dd73ad71008b1f3160c0052!
[INFO]  --> Found desired version locally github.com/ghodss/yaml 73d445a93680fa1a78ae23a5839bad48f32ba1ee!
[INFO]  --> Found desired version locally github.com/go-openapi/jsonpointer 46af16f9f7b149af66e5d1bd010e3574dc06de98!
[INFO]  --> Found desired version locally github.com/go-openapi/jsonreference 13c6e3589ad90f49bd3e3bbe2c2cb3d7a4142272!
[INFO]  --> Found desired version locally github.com/go-openapi/spec 6aced65f8501fe1217321abf0749d354824ba2ff!
[INFO]  --> Found desired version locally github.com/go-openapi/swag 1d0bd113de87027671077d3c71eb3ac5d7dbba72!
[INFO]  --> Found desired version locally github.com/gobwas/glob bea32b9cd2d6f55753d94a28e959b13f0244797a!
[INFO]  --> Found desired version locally github.com/gogo/protobuf c0656edd0d9eab7c66d1eb0c568f9039345796f7!
[INFO]  --> Found desired version locally github.com/golang/glog 44145f04b68cf362d9c4df2182967c2275eaefed!
[INFO]  --> Found desired version locally github.com/golang/groupcache 02826c3e79038b59d737d3b1c0a1d937f71a4433!
[INFO]  --> Found desired version locally github.com/golang/protobuf 2bba0603135d7d7f5cb73b2125beeda19c09f4ef!
[INFO]  --> Found desired version locally github.com/google/gofuzz 44d81051d367757e1c7c6a5a86423ece9afcf63c!
[INFO]  --> Found desired version locally github.com/gosuri/uitable 36ee7e946282a3fb1cfecd476ddc9b35d8847e42!
[INFO]  --> Found desired version locally github.com/grpc-ecosystem/go-grpc-prometheus 34abd90a014618f61222a1b0a7b7eb834a2d0dc3!
[INFO]  --> Found desired version locally github.com/howeyc/gopass 3ca23474a7c7203e0a0a070fd33508f6efdb9b3d!
[INFO]  --> Found desired version locally github.com/imdario/mergo<PHONE_NUMBER>c1639d9d78127b7d47c622b5d7b6dc!
[INFO]  --> Found desired version locally github.com/inconshreveable/mousetrap 76626ae9c91c4f2a10f34cad8ce83ea42c93bb75!
[INFO]  --> Found desired version locally github.com/jonboulle/clockwork 72f9bd7c4e0c2a40055ab3d0f09654f730cce982!
[INFO]  --> Found desired version locally github.com/juju/ratelimit 77ed1c8a01217656d2080ad51981f6e99adaa177!
[INFO]  --> Found desired version locally github.com/mailru/easyjson d5b7844b561a7bc640052f1b935f7b800330d7e0!
[INFO]  --> Found desired version locally github.com/Masterminds/semver 3f0ab6d4ab4bed1c61caf056b63a6e62190c7801!
[INFO]  --> Found desired version locally github.com/Masterminds/sprig 9526be0327b26ad31aa70296a7b10704883976d5!
[INFO]  --> Found desired version locally github.com/Masterminds/vcs 3084677c2c188840777bff30054f2b553729d329!
[INFO]  --> Found desired version locally github.com/mattn/go-runewidth d6bea18f789704b5f83375793155289da36a3c7f!
[INFO]  --> Found desired version locally github.com/matttproud/golang_protobuf_extensions fc2b8d3a73c4867e51861bbdd5ae3c1f0869dd6a!
[INFO]  --> Found desired version locally github.com/mitchellh/go-wordwrap ad45545899c7b13c020ea92b2072220eefad42b8!
[INFO]  --> Found desired version locally github.com/naoina/go-stringutil 6b638e95a32d0c1131db0e7fe83775cbea4a0d0b!
[INFO]  --> Found desired version locally github.com/pborman/uuid ca53cad383cad2479bbba7f7a1a05797ec1386e4!
[INFO]  --> Found desired version locally github.com/prometheus/client_golang c5b7fccd204277076155f10851dad72b76a49317!
[INFO]  --> Found desired version locally github.com/prometheus/client_model fa8ad6fec33561be4280a8f0514318c79d7f6cb6!
[INFO]  --> Found desired version locally github.com/prometheus/common ffe929a3f4c4faeaa10f2b9535c2b1be3ad15650!
[INFO]  --> Found desired version locally github.com/prometheus/procfs 454a56f35412459b5e684fd5ec0f9211b94f002a!
[INFO]  --> Found desired version locally github.com/PuerkitoBio/purell 8a290539e2e8629dbc4e6bad948158f790ec31f4!
[INFO]  --> Found desired version locally github.com/PuerkitoBio/urlesc 5bd2802263f21d8788851d5305584c82a5c75d7e!
[INFO]  --> Found desired version locally github.com/russross/blackfriday 300106c228d52c8941d4b3de6054a6062a86dda3!
[INFO]  --> Found desired version locally github.com/satori/go.uuid 879c5887cd475cd7864858769793b2ceb0d44feb!
[INFO]  --> Found desired version locally github.com/shurcooL/sanitized_anchor_name 10ef21a441db47d8b13ebcc5fd2310f636973c77!
[INFO]  --> Found desired version locally github.com/Sirupsen/logrus 51fe59aca108dc5680109e7b2051cbdcfa5a253c!
[INFO]  --> Found desired version locally github.com/spf13/cobra f62e98d28ab7ad31d707ba837a966378465c7b57!
[INFO]  --> Found desired version locally github.com/spf13/pflag 9ff6c6923cfffbcd502984b8e0c80539a94968b7!
[INFO]  --> Found desired version locally github.com/technosophos/moniker 9f956786b91d9786ca11aa5be6104542fa911546!
[INFO]  --> Found desired version locally github.com/ugorji/go ded73eae5db7e7a0ef6f55aace87a2873c5d2b74!
[INFO]  --> Found desired version locally golang.org/x/crypto d172538b2cfce0c13cee31e647d0367aa8cd2486!
[INFO]  --> Found desired version locally golang.org/x/net e90d6d0afc4c315a0d87a568ae68577cc15149a0!
[INFO]  --> Found desired version locally golang.org/x/oauth2 3c3a985cb79f52a3190fbc056984415ca6763d01!
[INFO]  --> Found desired version locally golang.org/x/sys 8f0908ab3b2457e2e15403d3697c9ef5cb4b57a9!
[INFO]  --> Found desired version locally golang.org/x/text 2910a502d2bf9e43193af9d68ca516529614eed3!
[INFO]  --> Found desired version locally google.golang.org/appengine 4f7eeb5305a4ba1966344836ba4af9996b7b4e05!
[INFO]  --> Found desired version locally google.golang.org/grpc 8050b9cbc271307e5a716a9d782803d09b0d6f2d!
[INFO]  --> Found desired version locally gopkg.in/inf.v0 3887ee99ecf07df5b447e9b00d9c0b2adaa9f3e4!
[INFO]  --> Found desired version locally gopkg.in/yaml.v2 53feefa2559fb8dfa8d81baad31be332c97d6c77!
[INFO]  --> Found desired version locally k8s.io/apimachinery fbd6803372f831e58b86c78d07421637a64ad768!
[INFO]  --> Found desired version locally k8s.io/apiserver 2308857ad3b8b18abf74ff734853973eda9da94d!
[INFO]  --> Found desired version locally k8s.io/client-go 5b0e11b577b35539f05523c47e94ed96a17f992b!
[INFO]  --> Found desired version locally k8s.io/kubernetes 0480917b552be33e2dba47386e51decb1a211df6!
[INFO]  --> Fetching vbom.ml/util.
[INFO]  --> Fetching github.com/huandu/xstrings.
[WARN]  Unable to checkout vbom.ml/util
[ERROR] Update failed for vbom.ml/util: Cannot detect VCS
[ERROR] Failed to install: Cannot detect VCS

Ugh... I should have cherry-picked the fix for that.
Here's the change you need to make to glide.yaml. Then do glide up && make bootstrap:
https://github.com/kubernetes/helm/blob/master/glide.yaml#L53-L55

Since this has been fixed in master I think this is good to close, eh?

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!

Resolved the issue. After going though the Glide code understood the root cause. Its not the glide issue. Glide must have flag to ignore server certificates.
Solution: Get Common CA certificates
Ubuntu - https://launchpad.net/ubuntu/xenial/+package/ca-certificates
Similarly search for other OS and install and try.

@iamsharife can you share more details on the issue you're describing? Thanks!

Trying to build v2.16.10 and I am seeing this same issue and other issues running make boostrap

Hi, @jchauncey - as Helm v2 is no longer being updated and will soon be out of support entirely, we suggest you use Helm v3: https://helm.sh/blog/helm-v2-deprecation-timeline/ - we will not be making any bugfixes to v2.
If you see a problem with Helm v3, please do open a new issue. Thanks!