Includes with relative path & other minor improvements

/home/msalinas/Documents/standalone-installations/cifParsers/libcifpp/src/pdb/cif2pdb.cpp: In function ‘std::tuple<int, int> cif::pdb::WriteCoordinatesForModel(std::ostream&, const cif::datablock&, const std::map<std::__cxx11::basic_string<char>, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&, std::set<std::__cxx11::basic_string<char> >&, int)’:
/home/msalinas/Documents/standalone-installations/cifParsers/libcifpp/src/pdb/cif2pdb.cpp:3362:15: warning: unused variable ‘pdbx_nonpoly_scheme’ [-Wunused-variable]
 3362 |         auto &pdbx_nonpoly_scheme = db["pdbx_nonpoly_scheme"];
      |

This warning appeared while compiling the library. The use of that variable below has been commented, so I think it's appropiate to do the same thing with the unused variable.
Edit: Now I also modified the includes inside the includes folder. This is done to support local usage of this library without the need of installing the library system-wide (which supports multiple instances of different versions used each one by a different piece of software). System wide installations should remain unaffected by this change.

Good point, thanks for this. I did some more changes on your patch and merged it into trunk

@mhekkel I am now having issues with those extra changes.
/home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/include/cif++/utilities.hpp:29:10: fatal error: cif++/exports.hpp: No such file or directory
   29 | #include "cif++/exports.hpp"
      |          ^~~~~~~~~~~~~~~~~~~

This is because exports.hpp is located in ./ relative to the file trying to include it, that's why in my PR I did not include the cif++/. If you wanted to use in a system-wide installation format, <cif++/exports.hpp> but that, even if changed to " ", does not get along with relative path access.
I would recommend removing "cif++/, because it won't mess with system-wide installations, since it will locally find the exports.hpp with the relative path instead of retrieving the same file after converting the system-wide format to a path in LD_LIBRARY_PATH.

If you want to use the library on another location, you should still use the cmake --install option with your own directory. That way the exports file is correctly generated and installed.
You cannot simply point to the location where you have a checked out copy of libcifpp. That's not how this is intended to be used.
BTW, I get the impression you're using regular makefiles (based on previous questions you had). May I suggest switching to cmake? It is an investment but certainly worth the time. cmake will also pick up the correct location of all files and libraries, even if you have a system wide version installed and want to use a private copy.

I am actually using the cmake commands provided by the readme file to compile and install the library (with minor minor tweaks, installing the library inside it's build directory instead of $HOME./local, because I want to contain the usage of this instance of the library to a single software project, and adding flag -DBUILD_SHARED_LIBS=ON to that command to produce a .so file instead of a .a so it can be used as a shared library inside the project).
Maybe later some makefile is being used to compile other cpp files and linked to the library, but that I have no control over, this is part of Xmipp, which is a huge codebase that would need an important refactor to deal with that, and I don't think it's nearly at my reach right now.
Regarding the install location and how does it affect the usage, I made a test installing the latest version in a different folder:
/home/msalinas/Documents/standalone-installations/libcifpp/
There, I ran the following commands:
git clone https://github.com/PDB-REDO/libcifpp.git
cd libcifpp
cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/home/msalinas/Documents/standalone-installations/libcifpp/ -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON
cmake --build build
cmake --install build

The library successfully installs in /home/msalinas/Documents/standalone-installations/libcifpp/build.
I also have a test.cpp file in /home/msalinas/Documents/standalone-installations/, as well as a makefile.
The test file imports the library using relative paths. Specifically, I have two import lines, one for the libcifpp instance in /home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/, and the other one in /home/msalinas/Documents/standalone-installations/libcifpp/ (I leave one of the commented to test how does compiling work with the other one).
So, with that, I added two commands in the makefile. One of them, executes the following line:
g++ -Wall -Wextra -g -pthread -I/home/msalinas/Documents/standalone-installations/libcifpp/include test.cpp -o test -L/home/msalinas/Documents/standalone-installations/libcifpp/build -lcifpp -lz

while the other runs:
g++ -Wall -Wextra -g -pthread -I/home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/include test.cpp -o test -L/home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/build -lcifpp -lz

They both seem to work just fine when the proper #include statement is active in the cpp file. However, there must be somehow something different in how things are compiled in the xmipp project, because that error appears when compiling after having run this installation commands:
cd /home/msalinas/Documents/standalone-installations/xmipp/
git clone https://github.com/PDB-REDO/libcifpp.git src/libcifpp
cd libcifpp
cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/ -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON
cmake --build build
cmake --install build

Which should pretty much be equivalent to the standalone version. In fact, running tree command on both libcifpp directories returns the same output.
However, I then changed all include paths to be relative to the file including. That means, if file cif++/pdb/tls.hpp wants to import file cif++/datablock.hpp, the include path should be "../datablock.hpp", and then no errors appeared while compiling.
I tried migrating those changes to the standalone instance, reinstalling with the new header includes, and compile again, which also resulted in no errors.
So, even if I'm not sure what is going on exactly that differs in usage between projects, as I am not able to effectively modify how xmipp compiles it's binaries linking external libraries, and using the relative path to the file importing instead of the include/ folder works in both scenarios, I would recommend using that, unless there's something else I don't know about, in which case, feel free to let me know, of course.

When I suggested to use cmake, I meant to use it in your own project instead of what you were using. But I understand that is not an option.
Installing in a different location should not be a problem. I just tried this:
cd ~/projects/libcifpp/
cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/tmp/x -DBUILD_SHARED_LIBS=ON
cmake --build build -j
cmake --install build
cd /tmp/
cp ~/projects/libcifpp/examples/example.cpp .
cp ~/projects/libcifpp/examples/1cbs.cif.gz .
g++ example.cpp -I /tmp/x/include -L /tmp/x/lib -lcifpp
LD_LIBRARY_PATH=/tmp/x/lib ./a.out

And that works. No need to change any include. The example.cpp file contains #include <cif++.hpp> but works equally well with #include "cif++.hpp"
BTW, the reason exports.hpp is generated at install time is because the contents depend on the platform you're using as well as whether you use shared or static libraries.

LD_LIBRARY_PATH=/tmp/x/lib a.out
Since I didn't specify a name for the output of the compiler, the default is used: a.out. And since the shared library is installed in a non-standard location, I need to specify the location of the shared library before I can run the application.
About including files, yes, if the include is specified using quotes ("") then the 'user' directories are search. If the include is specified using <>, only the system paths are searched.
Searching is done simply by appending the specified path to one of the user or system paths. First match wins. So if you include cif++/datablock.hpp and the include path contains /tmp/x/include where I installed libcifpp, then the file is found as /tmp/x/include/cif++/datablock.hpp.
Beware that if you use a name for a local file that is the same as a system header file, your local file is 'found', unless you specify the include using <> delimiters.
Now to your compilation problem. I've never used scons, but I do know by looking at it, you will have to specify the path to the include files for libcifpp in scons for your project. E.g. this line:
mpicxx -o applications/programs/mpi_angular_project_library/mpi_angular_project_library_main.o -c -mtune=native -march=native -flto -std=c++17 -O3 -Iexternal -Ilibraries -I/home/msalinas/Documents/standalone-installations/xmipp/src/xmippCore -I/home/msalinas/Documents/standalone-installations/xmipp/src -I/home/msalinas/Documents/miniconda/envs/scipion3/include -I/usr/include/hdf5/serial applications/programs/mpi_angular_project_library/mpi_angular_project_library_main.cpp

has several include paths added: each one is preceded by a -I. There is no include path specified for libcifpp. And that's why your code cannot find the cif++ include files.
So you will have to dive into the Scons configuration files to find a place where you can add the correct path.

Thanks for the explanation, helps a lot!
So, if I understood correctly, if you add the custom include folder to the system library paths, you sould have no issues using the #include "cif++/datablock.hpp" format, and I guess that #include "datablock.hpp" would work anyway, since it is using the path relative to the file with the include sentence.
About the installation log, I'm sorry, I just realised the include path to libcifpp is missing because this log was a re-run of the same command, so it was sometimes found in the now ... is up to date message, since they don't need recompiling. I initially did this because I wanted to dump the contents of the install output into a file, but when run from a fresh start, require some user interaction so the file wouldn't have been properly filled. I'll just copy it directly from the terminal instead.
This log file contains the original output where all compilation commands are shown (apologies in advance, the output log is huge, but you don't need to look through all of it):
[compile.log](https://github.com/PDB-REDO/libcifpp/files/11181656/compile.log)

You can see that in many lines, like this one:
/usr/bin/g++ -o external/condor/CNLSolver.os -c -mtune=native -march=native -flto -std=c++17 -O3 -I../ -I/home/msalinas/Documents/miniconda/envs/scipion3/include -I/usr/include/hdf5/serial -fPIC -I/home/msalinas/Documents/miniconda/envs/scipion3/include/python3.8 -I/home/msalinas/Documents/miniconda/envs/scipion3/lib/python3.8/site-packages/numpy/core/include -Iexternal -Ilibraries -I/home/msalinas/Documents/standalone-installations/xmipp/src/xmippCore -I/home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/include external/condor/CNLSolver.cpp

The path to the include directory is being properly added, which is something that happens dinamically.
But then, there are others (the ones causing the error), where the path is missing, which explains the error:
mpicxx -o applications/programs/mpi_angular_project_library/mpi_angular_project_library_main.o -c -mtune=native -march=native -flto -std=c++17 -O3 -Iexternal -Ilibraries -I/home/msalinas/Documents/standalone-installations/xmipp/src/xmippCore -I/home/msalinas/Documents/standalone-installations/xmipp/src -I/home/msalinas/Documents/miniconda/envs/scipion3/include -I/usr/include/hdf5/serial applications/programs/mpi_angular_project_library/mpi_angular_project_library_main.cpp

If I change the includes in all of those files to the format I proposed, the compilation completes successfully.
Additionally, I just made a test where the same test.cpp I was compiling before was now being compiled removing the library path in the include flag (-I/home/msalinas/Documents/standalone-installations/xmipp/src/libcifpp/include), and the same problem I am seeing in xmipp's compilation showed up: works only with relative paths to file including. So you were right all this time about that flag missing somewhere in my compile commands. However, changing the include format to mine still worked fine as if I added the -I flag with the include path, when I didn't.
So, as a last question for now (sorry about it, I have taken a lot of time from you), why is it better to use the #include "cif++/exports.hpp" format rather than the #include "exports.hpp" format? In my lack of knowledge, it seems like the first one only works correctly if you link properly the include folder when compiling, while the last one works no matter what.

Op 07-04-2023 om 23:46 schreef Martin Salinas:

why is it better to use the |#include "cif++/exports.hpp"| format
rather than the |#include "exports.hpp"| format?

You might have a file called exports.hpp in your project and
accidentally include the wrong one.
Besides, it is a matter of style, this way you explicitly specify the
exports.hpp file from the cif++ project.

I finally was able to find it and fix it. Thanks for your help!


Run indexer for multisig task

Run multisig indexer for following networks:

Polkadot
Kusama
Moonbeam
Hydration
Polkadot asset hub
Kusama asset hub
Polkadot People Chain
Kusama People Chain
AlephZero
Westend

The multisig option has to be changed for chains.json and chains_dev.json

Deployed stg and prod env:
https://github.com/novasamatech/infrastructure/tree/main/projects/subquery/proxy


Loading looping triggered sensors hangs

https://github.com/bluesky/yaqc-bluesky/blob/master/yaqc_bluesky/_is_sensor.py#L10
Offending line, could possibly update "wait until still" to read measurment id instead of busy for triggered sensors.
non-triggered sensors just have a null trigger message which is immediately marked as done
Triggered sensors call measure in trigger (see _has_measure_trigger.py) then wait_until_still which runs in a thread (see _base.py, last method)
This in turn waits until it goes not busy, which it never returns from
it's needed to get a measurement at init time (at least for our hardware... we should maybe make it a requirement for yaq that everything be populated correctly, at which point we could remove that....
￼
So essentially this comes down to "I understand what is happening, but not sure what the path forward is yet"

How about this:
while True:
    names = self.yaq_client.get_channel_names()
    if names:
        break
    time.sleep(0.01)

I think that trigger for has-measure-trigger maybe just looks at measurement-id
The thing is that some daemons (ni daq in particular) requires a measurement to have correct channel names.... it should be fixed on the daemon end perhaps, but is a larger fix there than this... (and not sure if other daemons have similar behavior)

My assumption is that channel names is an empty list until the first successful measurement.

most sensors it is not empty, ni specifically starts with the channel names it can tell by config, but ignores those that are provided by shots processing

OK, I'm wrong. My first thought is that's out of specification, but clearly it's something we do.
Given this, the robust solution is to ask the daemon for metadata each time describe is called. If we cannot reliably cache this, let's not try.

We could use the new functionality introduced by our friends at Diamond light source---the run engine now respects async describe.

I would support writing it into the spec, It actually appears that it does not affect gage, so pretty sure its only ni that needs addressing

Is this what you are thinking fora pragmatic spec?
MAY return empty metadata] at startup until first measurement, MUST not change contents of populated metadata once first measurement completes and metadata populates.
Would apply to

get_channel_names
get_channel_shapes
get_channel_units
likely others

Would also apply to mapping metadata?

Mapping can explicitly change, I'm not too fussed about if the keys change as we have mapping id to invalidate caches.
I would support channel names shapes and units being required to be fully correct at init time so if a measurement is required then init must sort that out... I could see some minor room for wiggle room that like the measurement is started in init but for some reason (e.g. the daq not having a trigger) does not complete in a reasonable time, that is undefined behavior and I'm not too interested being too hard on that.
I think perhaps we can sort out NI such that we can get that info from shots processing without real data.

I think we'll need to have a high bandwidth discussion @ksunden

leaving this issue open for the time being, as this behavior will be deleted once all dameons are in-spec


Feature/ui messaging

Description
Description of the feature or fix with link to the issue if existing
On what platform have you tested the change?

[x] Android - Emulator
[ ] Android - Physical device
[x] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Banner

Dialog

Snackbar

Note: ignore button row on dashboard, this has been removed
Please attach screenshots showing the change if relevant
Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevent
[ ] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

Do the changes to the podfiles and lock files mean we need to do a full build? Or will the OTA?


enable testing on linux & split building & testing into two separate …

…jobs
work in progress but I need to create a PR to see if the GitHub actions run successfully

Just curious ,how will this run on Linux since we use Foundation which is just for Apple platforms?

Foundation is available on Linux too: https://github.com/apple/swift-corelibs-foundation

Thanks, the documentation that I read was stale then.

Foundation on Linux is not as good as the one on Apple Platforms. Some API's are not implemented or crash at runtime but we are only using Data which should be fine.


App restart after capture image from camera

Description
Application is restarting after capture image from camera
How to repeat issue and example
const options = {
      quality: 0.6,
      isVertical: true,
      originalRotation: 0,
      title: '',
      storageOptions: {
        skipBackup: true,
        path: 'images',
      },
      cancelButtonTitle: 'cancel',
      takePhotoButtonTitle: 'Camera',
      chooseFromLibraryButtonTitle: 'Select from Gallery',
      mediaType: 'photo',
    };

ImagePicker.showImagePicker(options, response => {
      // console.log('Response = ', response);

      if (response.didCancel) {
        console.log('User cancelled image picker');
      } else if (response.error) {
        console.log('ImagePicker Error: ', response.error);
      } else if (response.customButton) {
        console.log('User tapped custom button: ', response.customButton);``
      } else {
        console.log('i am in else', response.uri);
        // You can also display the image using data:
        const source = { uri: 'data:image/jpeg;base64,' + response.data };

        this.setState({
          avatarSource: source,
        });
      }
    });

Additional Information

React Native version: 0.61.5
Platform: Android (5.0.1)
Development Operating System: Macbook

same as you

same here

same here, any solution @atifaziz1

same here

same here, but in my case its not always

same here, any solution @atifaziz1

Not yet. Still waiting for solution.

are this module still being under maintenance?

Same

Same here, but only happen on some android devices

Have you find solution guys?

I think the developer team is fixing the issue here https://github.com/expo/expo/pull/9349

Hi! same here. Any fix?

Any fix here? On android 10, just add android:requestLegacyExternalStorage="true" to <Application ... in Manifest file

Facing the same issue. Any updates?

Same problem here. Any idea?

Same problem here. Any idea?
plz help

Please create a new issue with as much info as possible.  If you're not on 3.x.x., then upgrade and try again.

I already upgrade it to 3.x.x still the issue occurs. Any solutions?

I already upgrade it to 3.x.x still the issue occurs. Any solutions?


Added background image

Added background image
#46

Background image is added and inverted for dark mode.

Lignt mode:

Dark mode:

This looks awsome,
but in Dark mode majority of the regions are still light.
could you fix it and make a PR again?


done

This pull request looks like it adds in an Amazon mod, then deletes all my stuff, then edits my readme to point to your website... I think maybe you didn't mean to make a pull request for this? Or am I missing something?

I dont know what this is brother,  I didn't send this.
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Eck @.>
Sent: Thursday, January 4, 2024 7:07:57 PM
To: Eck/EcksRimWorldMods @.>
Cc: Subscribed @.***>
Subject: Re: [Eck/EcksRimWorldMods] done (PR #1)
This pull request looks like it adds in an Amazon mod, then deletes all my stuff, then edits my readme to point to your website... I think maybe you didn't mean to make a pull request for this? Or am I missing something?
—
Reply to this email directly, view it on GitHubhttps://github.com/Eck/EcksRimWorldMods/pull/1#issuecomment-1877108550, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZRVQXGYUW2OXMKRQYOUQY3YM2WDLAVCNFSM6AAAAABBM2KZYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGEYDQNJVGA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Can I translate your private machine learning posts to Chinese?

Hi, I'd like to translate your private machine learning posts 1 & 2 to Chinese.
Can you give me the permission to translate and publish these posts on ai.jqr.com?
The translated text will also be published on some corresponding Chinese social network accounts.
Thanks.

Answered by author in email. 🎆


net/usrsock: fix outputted function name in debug prints

Summary
Patch fixes few misleading ninfo() debug prints in usrsock.
Impact
No functional change other than debug output.
Testing

nxstyle seems to have "off by one" error. The source files do not have lines that extend past column 78.

Thank you Juha!


CSV output should still provide error information

Currently there is no way to determine if or how many error responses occurred when outputting to csv. Add an option to give a more verbose csv output.

Will work on a pull request

And still open :(


Add waves

Signed-off-by: Ian Chen<EMAIL_ADDRESS>🎉 New feature
Summary
Added a waves demo that makes use of custom shaders.
Extended ShaderParams to support texture types (2d and cube map) so that users can pass textures to shaders.
Note: I took the shaders code from VRX, tweaked and simplified them a little for this demo. I left the copyright notices intact. Looks like @srmainwaring is one of the original authors.
Test it
Build and run the waves example:

Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nice @iche033! The original concept for the ocean shaders comes from this article https://developer.nvidia.com/gpugems/gpugems/part-i-natural-effects/chapter-1-effective-water-simulation-physical-models and was implemented in the demos for Ogre  (IIRC) and then in one of the examples in https://uuvsimulator.github.io/ (visuals only). There was some work with the VRX team to sync up the physics sim with the visuals (so boats would rise at the same time as the shader visuals moved the ocean).
For Gazebo classic I developed a more involved ocean simulation here https://github.com/srmainwaring/asv_wave_sim/tree/feature/fft_waves, which I've been meaning to port to Ignition. I think the hydrodynamics part has too many dependencies on libraries under GPL to submit a PR to Ignition, but the FFT ocean surface generator may be suitable for inclusion if there was interest.

@srmainwaring , cool thanks for the links and info!
I added a reference to the nvidia water simulation page in the shader code.

There was some work with the VRX team to sync up the physics sim with the visuals (so boats would rise at the same time as the shader visuals moved the ocean).

yeah we will be porting the wave field plugins over to Ignition too and also sync physics and the visuals.

For Gazebo classic I developed a more involved ocean simulation here https://github.com/srmainwaring/asv_wave_sim/tree/feature/fft_waves,

Nice! FFT based ocean waves will be great. From a quick look at the repo, I see that the wave simulation code depends on fftw which is GPL. What's the "FFT ocean surface generator"? Is that the part that depends on CGAL for generating meshes?

What's the "FFT ocean surface generator"? Is that the part that depends on CGAL for generating meshes?

The bit that depends on CGAL is the hydrodynamics plugin. There are two what ignition calls systems.
The first system generates surface waves in dynamically generated mesh. The FFT wave generator uses a FFT to create a wave spectrum - I've used fftw to implement, but another library could be used. There's also an OpenCL implementation included (but I might run into macOS unfriendliness with that as well in future).
The second system, hydrodynamics, calculates the pressure and drag forces on each triangle in the mesh using a technique described by one of the FarCry devs . It's an alternative to estimating volumes and calculating buoyancy that way. The advantage with the surface pressure approach is that it automatically determines which portion of the craft is submerged, and when there are waves it accounts for that as well (so for instance you may have the water level higher on one side of the vessel - which leads to a horizontal pressure differential). I used CGAL for ray intersection and a couple of other things - bounding boxes IIRC. That's a bit (lot?) more work to extract, but the whole calc should be parallelised anyway and would be improved with a rework.

I see thanks for the explanation! We'll likely not be able to depend on fftw due to its license so will need an alternative. A quick search yields this header only library. There could be others.

The second system, hydrodynamics, calculates the pressure and drag forces on each triangle in the mesh using a technique described by one of the FarCry devs .

interesting, that sounds like it produces a lot more accurate motion of the surface vehicle, like waves hitting the side of the boat.
I see the gif in your repo illustrating the more accurate behavior of objects floating on the waves. Nice.

The second system, hydrodynamics, calculates the pressure and drag forces on each triangle in the mesh using a technique described by one of the FarCry devs . It's an alternative to estimating volumes and calculating buoyancy that way. The advantage with the surface pressure approach is that it automatically determines which portion of the craft is submerged, and when there are waves it accounts for that as well (so for instance you may have the water level higher on one side of the vessel - which leads to a horizontal pressure differential). I used CGAL for ray intersection and a couple of other things - bounding boxes IIRC. That's a bit (lot?) more work to extract, but the whole calc should be parallelised anyway and would be improved with a rework.

Hey @srmainwaring this sounds quite interesting currently we do have a linear hydrodynamics plugin ported from the UUV sim that is suited for underwater vessels upstream. The approach you use does sound interesting as it means we don't need to calculate numbers for Added Mass and Drag Coefficients which are really hard to calculate. By any chance are you aware of the proposal for a maritime working group here? I think it'd be great to have your input in the said group.

@iche033 I've made a start porting this and the custom_shaders_uniforms examples to Metal: https://github.com/srmainwaring/ign-rendering/tree/feature/ign-rendering7-metal-waves
Aside from the Metal version of the shaders, a change to Ogre2Material is needed load the Metal shaders when using that graphics API. We'll need a way to select the graphics API in SetVertexShader and SetFragmentShader. The fragment program also needs an additional parameter shader_reflection_pair_hint in the case of Metal otherwise the uniforms are not handled correctly.
The missing piece is how to pass the textures: Metal expects the textures and samplers to be supplied in the argument list of metal_main() rather than being sent with the parameters where the rest of the uniforms are passed. I'd appreciate any insight you or @darksylinc might have on the best way to approach this in a general way that works for GL3+ and Metal.

The missing piece is how to pass the textures: Metal expects the textures and samplers to be supplied in the argument list of metal_main() rather than being sent with the parameters where the rest of the uniforms are passed. I'd appreciate any insight you or @darksylinc might have on the best way to approach this in a general way that works for GL3+ and Metal.

The way we handle it is just silly, using macros:
// Shared code;
void myFunction( float a PARAMS_ARG_DECL )
{
  ...
}

myFunction( 1.0f PARAMS_ARG );

// On GLSL
#define PARAMS_ARG_DECL
#define PARAMS_ARG
// This is a uniform
#define p_bandPower			bandMaskPower

// On Metal
#define PARAMS_ARG_DECL , constant Params &p, texture2d<float> myTexture
#define PARAMS_ARG , p, myTexture
// This is a uniform
#define p_bandPower			p.bandMaskPower

Whether this is a net win or net loss depends on the size of the shader. Small shaders it's not worth it (unless they're constantly being modified, since shared code needs to be modified for every API). Bigger ones it is worth it.

cool, thanks for porting the waves shaders to Metal!
As for the code inside ign-rendering for setting up textures to be used in shaders, I thought just creating the texture unit would be sufficient:
https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering6/ogre2/src/Ogre2Material.cc#L719-L756
Looking at an example material file in ogre-next, GLSL requires passing the textures as params, while I don't see that being done in Metal.
So the difference I see is that this call in ign-rendering may not be needed?
https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering6/ogre2/src/Ogre2Material.cc#L756

Thanks @darksylinc and @iche033 - very helpful.
Suppressing setting the named constant for textures when using Metal did the trick:

https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering6/ogre2/src/Ogre2Material.cc#L756

There is still something wrong with the shader (perhaps and orientation difference for Metal?) but the textures are being loaded and I'm not seeing the previous error
libc++abi: terminating with uncaught exception of type Ogre::ItemIdentityException:
OGRE EXCEPTION(5:ItemIdentityException): Parameter called bumpMap does not exist.
 in GpuProgramParameters::_findNamedConstantDefinition at /tmp/ogre2.2-20211021-27718-y2969/ogre-next-312bf406a77244afe230930e67e3e5d52a119507/OgreMain/src/OgreGpuProgramParams.cpp (line 2228)

hmm do you know if cube map is the issue or if it's a problem passing multiple textures? e.g. what if you pass just the cube map and no bump map?

I think it's the cubemap. With just the cubemap there is a segfault (null pipeline state object at the binding point again). With just the bump map its ok. I can add multiple 2D textures, although there is an issue that it's unclear which texture unit will be assigned to each texture (it's not necessarily the order in which the texture are added to the parameters)
I've added some debug lines in Ogre2Material to trace:
Added resource location '/Users/rhys/Code/osrf/ign_fortress_ws/src/ign-rendering/examples/waves/build/media/' of type 'FileSystem' to resource group 'General'
[Dbg] [Ogre2Material.cc:713] texUnit.name:     waterTex
[Dbg] [Ogre2Material.cc:714] texUnit.texIndex: 0
Texture memory budget exceeded. Stalling GPU.
Stalling was not enough. Freeing memory.
Texture memory budget exceeded. Stalling GPU.
Stalling was not enough. Freeing memory.
[Dbg] [Ogre2Material.cc:713] texUnit.name:     bumpMap
[Dbg] [Ogre2Material.cc:714] texUnit.texIndex: 1

which means I need to line up the texture arguments to the Metal fragment shader as:
fragment float4 main_metal
(
  PS_INPUT inPs [[stage_in]],
  texture2d<float>    waterTex        [[texture(0)]],
  texture2d<float>    bumpMap         [[texture(1)]],
  texturecube<float>  cubeMap         [[texture(2)]],
  sampler             waterTexSampler [[sampler(0)]],
  sampler             bumpMapSampler  [[sampler(1)]],
  sampler             cubeMapSampler  [[sampler(2)]],
  constant Params &p [[buffer(PARAMETER_SLOT)]]
)

It would be good to be able to select the texture unit when setting custom textures on the shader params:
  std::string waterTexPath = ignition::common::joinPaths(RESOURCE_PATH,
      "water.jpg");
  (*g_fsParams)["waterTex"].SetTexture(waterTexPath);

Here's the result of sampling a water texture and the bump map, no cube map.

It's working!

I tracked down a difference in OgreTextureUnitState between the way that Ogre::TextureTypes::Type2D and Ogre::TextureTypes::TypeCube are handled and it comes down to this test which is only applied for Type2D:
            // Load immediately ?
            if (isLoaded())
            {
                _load(); // reload
            }

and it turns out if you add the same test in Ogre2Material when setting the cubic texture on the texUnitState then it works:
        texUnit->setCubicTextureName(baseName, true);
        if (texUnit->isLoaded())
        {
          texUnit->_load();
        }

Now I still really don't understand how this manages to trigger setting the mPso in the mRenderSystem variable held by the RenderQueue, perhaps it's something to do with the HlmsCache being updated? @darksylinc may be able to shed some light on what's going on.
Anyway, the good news is that the two required functions are public, so no API changes are needed (or Ogre release).
I've currently rebased the changes for the waves on draft PR #554 which deals with most of the OgreMaterial changes, so will submit a PR for the waves when that's ready to merge.

nice! not very trivial given the backtrace. Glad to see it's working!

not very trivial given the backtrace.

Yeah, that part of the Ogre code down in the depths of the compositor is very complicated to follow - I'd almost given up (and was going to cheat by just using another 2D texture to mock up the reflection effects). I think this combined with your gazebo visual plugins PR provides the pieces I need to get my FFT waves plugin ported - so happy with that!

Now I still really don't understand how this manages to trigger setting the mPso in the mRenderSystem variable held by the RenderQueue, perhaps it's something to do with the HlmsCache being updated? @darksylinc may be able to shed some light on what's going on.

Low level materials are full of legacy code and behaviors (and a few wtf were they thinking?). Since ign-rendering decided to fully construct a low level material and its shaders via code, you're encountering some of the ugly sides.
We're keeping low level materials because:

They make porting easier
They're user friendly for specific stuff (e.g. compositor FXs)
They're very useful for specific scenarios (like rendering a particular object in a special way)
Most of them are defined via scripts so Ogre hides the esoteric calls needed to get it working correctly (like calling setCubicTextureName)

Sure, this is the function in OgreTextureUnitState where Type2D gets the reload treatment
https://github.com/OGRECave/ogre-next/blob/f8f59465a55d7cb812b8a568b913dad77890ef4a/OgreMain/src/OgreTextureUnitState.cpp#L196-L228
more to come...

The relevant code that sets the PSO is:
Hlms *hlms = mHlmsManager->getHlms( static_cast<HlmsTypes>( datablock->mType ) );

lastHlmsCacheHash = lastHlmsCache->hash;
const HlmsCache *hlmsCache = hlms->getMaterial( lastHlmsCache, passCache[datablock->mType],
                                                queuedRenderable, casterPass );
if( lastHlmsCache != hlmsCache )
{
    CbPipelineStateObject *psoCmd = mCommandBuffer->addCommand<CbPipelineStateObject>();
    *psoCmd = CbPipelineStateObject( &hlmsCache->pso ); //// <<<-------- here
    lastHlmsCache = hlmsCache;

    // Flush the RenderOp when changing shaders. Needed by D3D11/12 & possibly Vulkan
    lastRenderOp.vertexData = 0;
    lastRenderOp.indexData = 0;
}

uint32 baseInstance = hlms->fillBuffersForV1( hlmsCache, queuedRenderable, casterPass,
                                                          lastHlmsCacheHash, mCommandBuffer );

I suppose a bogus "if( lastHlmsCache != hlmsCache )" could cause the command to be skipped entirely.
But it's also possible hlmsCache->pso->rsData or MetalHlmsPso( hlmsCache->pso->rsData )->pso is nullptr.
If the latter is the case, then something went wrong in HlmsLowLevel::createShaderCacheEntry
There should be errors in the Ogre.log if the PSO failed to be created (which is possible!) while both shaders actually compiled fine.
Try seeing if inside MetalRenderSystem::_hlmsPipelineStateObjectCreated enters the exception:
NSError *error = NULL;
id<MTLRenderPipelineState> pso =
	[mActiveDevice->mDevice newRenderPipelineStateWithDescriptor:psd error:&error];

if( !pso || error )
{
	String errorDesc;
	if( error )
		errorDesc = error.localizedDescription.UTF8String;

	OGRE_EXCEPT( Exception::ERR_RENDERINGAPI_ERROR,
				 "Failed to created pipeline state for rendering, error " + errorDesc,
				 "MetalRenderSystem::_hlmsPipelineStateObjectCreated" );
}


Dracula for WinAmp

Hey, I've made a Dracula theme for WinAmp! Here's my repository: https://github.com/veevyo/dracula-winamp. It's my first time contributing to Dracula properly, so let me know if I need to fix anything up with my repository.

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉


When updating from Marten 1 to Marten 2 doing a WritePatch to get the migration file using AutoCreate.CreateOrUpdate or AutoCreate.Create throws exception

The patch sql file is generated correctly if AutoCreate.All is used. But throws this exception if that is changed to AutoCreate.CreateOrUpdate or AutoCreate.Create. As per #855 I couldn't test this with AutoCreate.None.
I assume this exception isn't going to be specific to updating from Marten 1 to 2, but this is my current test case.
ERROR: System.InvalidOperationException: Marten cannot derive updates for objects public.mt_streams

   at Marten.Schema.SchemaPatch.AssertPatchingIsValid(AutoCreate autoCreate)
   at Marten.Storage.
TenantSchema.ToPatch(Boolean withSchemas)
   at Marten.Storage.TenantSchema.AssertDatabaseMatchesCo
nfiguration()
   at Marten.CommandLine.PatchCommand.execute(IDocumentStore store, PatchInput input)

   at Marten.CommandLine.MartenCommand`1.Execute(T input)
   at Oakton.OaktonCommand`1.Oakton.IOak
tonCommand.Execute(Object input)
   at Oakton.CommandRun.Execute()
   at Oakton.CommandExecutor.<>c
__DisplayClass15_0.<Execute>b__0()
   at Oakton.CommandExecutor.execute(Func`1 execute)

Also, when AutoCreate.All is set, the patch changes for the mt_streams table (adding the created and tenant_id) are not being generated and the patch to modify the mt_append_event function is generated every time, even after it has already been ran.

I don't know Eric. I really wish you would have tried this out months ago when 2.0 was sitting in alpha.

Yeah, I wish we had time to start updating before last week. We found workarounds for these issues but I thought they should be documented in issues.

@ericgreenmix Try 2.2 when it's up on Nuget.

Yes, the main issue with this is fixed now. I am creating a separate issue for the mt_append_event function being generated every time and have a failing test for that I will be submitting


fix: Normalize paths on Windows.

Resolves
#1159
Proposed Changes
Fixed to generate a dependency on a POSIX style path.
In "depswriter.py", the path is normalized by the following code.
https://github.com/google/closure-library/blob/master/closure/bin/build/depswriter.py#L125-L136
Fixed the test code so that the npm run test of  closure-deps completes successfully on Windows.

Thank you for reviewing my PR.
I pushed the modified code, so please check it.

Looks good, I'll try to get this merged.  I notice that GoogleBot has neither asked you to sign the CLA, nor tagged the PR with the CLA label.  Have you signed the CLA yet?  If not, please find the relevant info on another CL (e.g. #1146).

Thank you for confirmation.
I already signed the CLA when I contributed another project.

@googlebot  I signed it!


_expire in SessionData is never set to the value passed when the initial call to sessionPlugin

Been looking at this code and found the _expiry is not being set to the value passed when the sessionPlugin function is called, in the options expireAfter:
My code using the sessionPlugin:
const app = new Elysia()
.use(sessionPlugin({
cookieName: "session", // Optional
store: mongoStore,
expireAfter: 15 * 60, // 15 minutes
})).get("/", () => 'Hi').listen(3010);
I added the following code on my local copy to bring this value in, example below (The idea is to use the long ms time value and save as string this will make it easy to work out if it has expired - ):
    if (createRequired) {
        const expire = options.expireAfter === null ? null : new Date(Date.now() + options.expireAfter * 1000);
        const initialData: SessionData = {
            _data: {},
            _expire: expire === null ? null : expire.toString(),
            _delete: false,
            _accessed: null
        }
        sid = nanoid(24)
        store.createSession(initialData, sid, ctx)
        session.setCache(initialData)
    }

This was part of work to build a MongooseStore to leverage off this work which I have the create step working and I'm will to share the code updates to get this piece working as it is very close to being complete.

_expire is managed by Session. You might want to look here

I understand, yet when I log the code it is not getting set and pushed to the store. It was always null, even when I set a value.

It must be managed by the store. Consider looking at the MemoryStore implementation. Also, I have added your store example to the readme here

You have a line of code:
    const session = new Session;         (line 18 - should that not be new Session())

That shouldn't have an impact. You're correct i should have included parentheses but it wouldn't change how that works because the constructor doesn't really take any arguments

My point is that on the session this is not call to "setExpire()" or check for it. So the value is null, and it is not set in the initialdata part when you call setCache(initialData: SessionData). This is my point, that it never gets set if you provide a value to "expireAfter".

It does https://github.com/gaurishhs/elysia-session/blob/main/src/index.ts#L36

Okay, I have tested this out and had to fix my MongooseStore to use async. Then all good with the expiry. There were a few things I needed to change to get the index.ts side working:
https://github.com/gaurishhs/elysia-session/blob/main/src/index.ts#L25
add the line:
sid = cookie.value;  --> this will stop the cookie having an empty value when you have a valid session cookie
https://github.com/gaurishhs/elysia-session/blob/main/src/index.ts#L62
https://github.com/gaurishhs/elysia-session/blob/main/src/index.ts#L27
sessionData = await store.getSession(undefined, ctx)  --> change the undefined to sid that was set earlier
https://github.com/gaurishhs/elysia-session/blob/main/src/index.ts#L28
store.deleteSession(undefined, ctx) -->the same issue as line 27 and this stops leaks in the store (well as much as you can - I have ideas around that and not something your project needs to handle. I think that is a store implementation issue).
I tested this a bit with JMeter and doing 3+ requests per workflow to verify the cookie was being processed correctly. That is when I made the above changes and everything worked well.
You were right on the expiry stuff and it works a charm. What you built here was really nice and clean. Appreciate the work and answering my issues.
Once I clean up the Mongoose store I'll send another copy for you that works if you would like - I had bugs that did not come up till I load tested this.


correct result message, added more tests

Coverage decreased (-0.3%) to 91.579% when pulling cd458824329b1de3e90cd8da357d346160c8c5cc on bugfix/repeated-message into e2fbaff33aa0ef25c489eaf8d9859311cc759ecc on master.

Coverage decreased (-0.3%) to 91.579% when pulling cf3c83abdded054ece4eaf0c95380d197f8b9fbd on bugfix/repeated-message into e2fbaff33aa0ef25c489eaf8d9859311cc759ecc on master.


Taking the order from solr

The new version of Active tripples can shuffle the order of the data coming from Fedora.  Solr preserves the order so we are going to use that.

Coverage increased (+20.6%) to 75.638% when pulling f9a77e52d73f8b56d3c3aed4fd67a1e5f1e0eaf3 on migrate_creator_order into 7807edd4030e8d0e47fd9265e05c2f2d2490a332 on develop.


Never actually shows what killed me

As the title says, this never shows the last hit. As a tank I'm always either dieing of a slow bleed because of poor or dead healer, or I'm getting killed by something that is a one hit kill. The latter is the only one I really need a plugin to tell me how I messed up, but that doesn't actually seem to be included?

I am still facing this problem now at 7.05. Has this issue ever been solved?


Unit Testing for Code Coverage

Added

Vitest-based configuration for unit testing
Unit tests for major non-discordjs classes, methods, and features

Notes

Discord.js mock testing of events, commands, and message passing is sorely lacking
An open-source package, gauntlet is being developed for this purpose

The tests look fine. I haven't run them yet, but I hope they work.
URL link for Build is not working as intended as of now. Might fix itself later by running workflows.

The url for build does not work in branches other than master. This is because the build workflow is only triggered upon a push to master (the result of merging this PR). I ran the existing tests many a time before pushing. Each existing test works with the current code base.

Also I do not believe the version needs to be incremented because we are just introducing tests not a feature (unless you think we should then change it appropriately. @JT2M0L3Y

is there a reason why you're doing __tests__/ instead of tests/?

This is a convention from other NodeJS projects I have seen. However, there is a good chance this is an older styling convention and we could rather use just a folder named /test to model a UNIX-like file system. Would this be preferrable?

Is there any way we can Mock the environment variables to reduce dependency on github? I think it's better to allow for isolation.

We could define a distinct, example set of environment variables that are compared during testing instead of using those passed into the Keys object by the workflow.

Might even consider tests with their files but we shouldn't do that prob.
I guess it does not really matter per this discussion. But essentially, if we do not anticipate other "test" folders then we should even move the folder to src/tests but we can do 'tests/. I'm more down for the latter but let me know what you think.


#130: Add AppVeyor integration to run tests on Windows 10

#130

AppVeyor integration is frozen until https://github.com/appveyor/ci/issues/1295 resolved.


Create AnyTxEnvelope

Component
network
Describe the feature you would like
#584 follow-up
Create a new struct AnyTxEnvelope replacing alloy_consensus::TxEnvelope here:
https://github.com/alloy-rs/alloy/blob/d68a6b787b2904061f0ae7fcc02ece8513e3c500/crates/network/src/any/mod.rs#L62
Additional context
No response

I've started to work on this, but I struggle to impl Encodable2718<AnyTxType> and Decodable2718<AnyTxType> for AnyTxEnvelope.
I created AnyTxEnvelope like this:
#[derive(Clone, Debug, PartialEq, Eq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct AnyTxEnvelope<T> {
    /// The signed transaction
    #[cfg_attr(feature = "serde", serde(flatten))]
    pub inner: Signed<T>,
    /// The transaction type.
    #[cfg_attr(feature = "serde", serde(with = "alloy_serde::num::u8_hex"))]
    pub r#type: u8,
}

It's used in AnyNetwork like that:
type TxEnvelope = alloy_consensus::AnyTxEnvelope<WithOtherFields<alloy_rpc_types::eth::transaction::Transaction>>;

But actually I'm not sure it's correct. wdyt?

Closing as this issue has been created as a follow up to #584, that won't be merged.


feat: update project structure to only include core components

Introduces @bpmn-io/properties-panel as core properties panel library.
Moves all BPMN related stuff to https://github.com/bpmn-io/bpmn-properties-panel/pull/1

Related to #5
Steps that need to be done after

rename project to bpmn-io/properties-panel (or something different if it doesn't fit) (done)
update repo URLs (done)
move BPMN specific issues to bpmn-io/bpmn-properties-panel (done)
release a first version

We added the disabled support for selects and text fields inside this PR, since they already follow the new project structure (cf.  #78, #79)

Updated ✌

Approved. ✅


publish with github action

it would simplify the process a little to use github action https://github.com/actions/starter-workflows/blob/d644b9852c31e860b279bea858a6ac4f9d1ae17a/ci/python-publish.yml to push the build.

https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/


recipe modernization, add license file

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

Notes:

The current build was built with py27, which is creating some downstream issues
adds the license as second download
minor fixups
proposes @bollwyvl as maintainer

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

@conda-forge/keepalive ready for review!

testing this locally: due to use of 2to3 this probably shouldn't have been made noarch...
@conda-forge-admin please rerender

the alternate approach would be to keep noarch: python, but set a lower bound on python, e.g. >=3.5

For reference, the issue with the currently-deployed version:
Python 3.7.8 | packaged by conda-forge | (default, Jul 31 2020, 02:25:08)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from keepalive import keepalive
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/tmphk59pf8k/lib/python3.7/site-packages/keepalive/keepalive.py", line 240
    except (socket.error, httplib.HTTPException), err:

@conda-forge/keepalive thoughts? going to ping gitter for a merge on this soon, probably...

sorry missed this.

Ah, very nice, thanks!


RBAC related error during draining

I've got and error log from running k8s-spot-rescheduler created with helm stable chart.
I0613 08:22:25.885787       1 event.go:218] Event(v1.ObjectReference{Kind:"Node", Namespace:"", Name:"ip-10-10-103-64.ap-northeast-2.compute.internal", UID:"e554192f-6e5b-11e8-83f1-02cebe856fe6", APIVersion:"v1", ResourceVersion:"4970345", FieldPath:""}): type: 'Normal' reason: 'Rescheduler' marked the node as drained/schedulable
E0613 08:22:25.887363       1 event.go:200] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"ip-10-10-103-64.ap-northeast-2.compute.internal.1537a706144e99db", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"56289", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, InvolvedObject:v1.ObjectReference{Kind:"Node", Namespace:"", Name:"ip-10-10-103-64.ap-northeast-2.compute.internal", UID:"e554192f-6e5b-11e8-83f1-02cebe856fe6", APIVersion:"v1", ResourceVersion:"4970345", FieldPath:""}, Reason:"Rescheduler", Message:"marked the node as drained/schedulable", Source:v1.EventSource{Component:"rescheduler", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63664471043, loc:(*time.Location)(0x290da60)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbec052f074c9f2d8, ext:4923937149480, loc:(*time.Location)(0x290da60)}}, Count:4, Type:"Normal"}': 'events "ip-10-10-103-64.ap-northeast-2.compute.internal.1537a706144e99db" is forbidden: User "system:serviceaccount:kube-system:spot-rescheduler-k8s-spot-rescheduler" cannot patch events in the namespace "default"' (will not retry!)

It seems patch verb need to be added below https://github.com/pusher/k8s-spot-rescheduler/blob/master/deploy/clusterrole.yaml#L21, but I'm not a rbac expert, so not sure if it will fixes this issue. I added patch verb, but my clusters already already autoscaled so that action doesn't executed again.

This will indeed fix the issue (AFAICT at least...) and was added in #52.


make QPS and Burst values configurable via pilot features

Make QPS and Burst values configurable via pilot features
[X] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[X] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Reference -

1.5 port
1.6 port

Hi @nirvanagit. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@nirvanagit: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

lint_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test lint_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-security-k8s-tests_istio

release-notes_istio
8af01c71d3c7243c458f23e8be25b3e5ded52bbb
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-security-k8s-tests_istio

release-notes_istio
3a3bcdb6c044f275fe5c8cf6e471c00528428e45
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

integ-galley-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-security-k8s-tests_istio

release-notes_istio
3a3bcdb6c044f275fe5c8cf6e471c00528428e45
link
/test release-notes_istio

unit-tests_istio
3a3bcdb6c044f275fe5c8cf6e471c00528428e45
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@nirvanagit: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
2f51cb251f40021383845ce8dc074769c1c35b7b
link
/test integ-operator-controller-tests_istio

unit-tests_istio
3a3bcdb6c044f275fe5c8cf6e471c00528428e45
link
/test unit-tests_istio

release-notes_istio
3a3bcdb6c044f275fe5c8cf6e471c00528428e45
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


What about PING option?

I was wondering if we have an option to ping to google and bing for newly created sitemap and thus encourage crawlers to crawl update ones.
This is an example:
http://www.google.com/webmasters/sitemaps/ping?sitemap=http://www.yourdomain.com/sitemap.xml

I'd rather not include an option like this. There is no guarantee that the sitemap is available at the specified url after it is generated. What happens in that case?

I agree with you. We are not accepting filename. Ping can thus only be used if we have a filename too.
-output sitemap.xml -ping
Assuming that base url option is compulsory.
This makes npm module almost complete cli tool

Will have to think about this. Not sure how to handle the pipe output (current) and the filename option. Maybe there are some more opinions.

I decided against this option. I'm sorry. You can easily do it yourself like this:
sitemap-generator http://www.yourdomain.com sitemap.xml && curl http://www.google.com/webmasters/sitemaps/ping?sitemap=http://www.yourdomain.com/sitemap.xml

Even if the path is given (as it is now since v6) the generator can not know for sure where it is located. For example it could be http://www.yourdomain.com/subfolder/sitemap.xml. The generator does not know about subfolder.


Replace internally developed CSR GEMM with a call to MKL

internally developed GEMM was removed
call to MKL's sparse GEMM was added into clusters assignment step in sparse K-means (see assign_clusters kernel)
incorrect use of communicator was removed
Sparse method was aligned with dense method. Now both methods give the same results on the same input data passed in sparse and dense layout respectively

/azp run CI

/intelci: run

/intelci: run

Re-run pre-commit: https://intel-ci.intel.com/ef3aa431-06ee-f183-af2d-a4bf010d0e2e

/intelci: run

The work was moved to #2959


Support to configure the model used by Navie

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/676
This PR

adds support for new Navie webview message select-llm-option
adds a new action Tools > AppMap > Set OpenAI API Key. This action is also used for message type own-key
changes some of the code to store the user-defined environment variables to fix a serialization problem with Map.of() immutable maps. A new test verifies that serialization is working.
adds code to avoid that the "settings changed, reload project" notification is displayed once on the screen
makes the reload notification show for "change of OpenAI key" and "change of a LLM environment variable"

Dialog to set the OpenAI API key:

:tada: This PR is included in version 0.66.0 :tada:
The release is available on:

v0.66.0
GitHub release

Your semantic-release bot :package::rocket:


feat: add Czech translation

Description

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Thanks for the PR @lksfrn !

Yeah, no problem. When this will be available in the release?


LSP completions don't work for sub-modules

The sub-modules completion doesn't work.
For eg. If i type import os there's a completion for it and works fine. Next however, if I try to access os.path, no completions show up for path or any of its related members. This is the behavior for all packages I use.
My Setup
Mac OS running M3 Max
helix editor configured as per this
Any help would be appreciated. Does pylyzer not fully support the helix text editor ?

This is an essential difficulty with completion.
Suppose we type os when the os module has not been imported and then import it using completion.
If we then type os.path. quickly, completion may not work correctly because the inserted module has not been checked and the os.path identifier has not yet been resolved.
In fact, if we type os.path. after the os module has already been imported, members should be listed correctly.
The incremental check has been improved in the latest version (v0.0.66), which has alleviated the problem, but the problem will remain essentially the same if your typing speed is fast enough.


SSR gives me ReferenceError: window is not defined

I'm using react-visibility-sensor 5.0.1 with NextJS 7.0.2

Same bug

+1

Hi @asundlihardig thanks for the report. Could you & others here please confirm whether it's fixed by #140 ?

@asundlihardig I had trouble trying to just npm install from the PR (I don't think the lib is updated).
I merged #140 onto my fork and pushed it under my org to npm, you can try installing the branch with
npm i -S @tgrx/react-visibility-sensor
this fixed my issue w/ Gatsby

Thanks @Falieson
While we're here, would anyone in this thread be willing to help make a quick demo repo using Gatsby or Next?
As mentioned in #128 I'm hoping to get a group of demos together that represent how people are using this component in production.  Moving forward, only features that are covered by Demos will be considered "officially supported", and others may be deprecated.

+1

Hi @hlolli , is that a "+1" to say that you're experiencing the issue as well, or confirming that the PR resolves it for you? (or both? :) )

@joshwnj I'm as we speak testing the PR from @Falieson, it works non-ssr, but not ssr, I'm getting runtime react error and it wont show me any stacktrace with minified react. So I'm trying to track down the bug and rule out if it's on my side. Will either edit this post or post about if it works or not!

@joshwnj the PR fixes my problem. I was at the same time bumping react which caused mismatch of a newline. Was an easy fix on my side fully unrelated to the visibility sensor!

I've published the fix at v5.0.2

Just leaving this here for future googlers:
We were having problems with one of our code-split components staging in loading state at SSR. So we basically had an entire page which would always render Loading... for the SSR pass. We're using https://github.com/faceyspacey/react-universal-component for our code split + SSR setup.
There's a whole lot going on on the page that was failing, but merely commenting out <VisibilitySensor> got rid of the loading state.
Sadly universal-component was not logging any errors or anything which made it quite hard to track down.
In the end, upgrading to 5.0.2 of this package fixed the issue :tada:

Hi @joshwnj Sorry for not responding to this before, but I have been traveling.
5.0.2 fixed the issue. Thanks a lot! ✌🏻
We are using react-visibility-sensor in a Next.js project hosted on Heroku.
Currently we have two usecases:

Lazyloading a static map
GA tracking an element when partially viewed.

Let me know if you want me to join #128


Updating Bigtable generated files.

Are the .proto files generated?  Or are we just copying them into the _generated package for clarity?
Also, do we have the process for re-generating these files documented?

The .proto files are copied from https://github.com/GoogleCloudPlatform/cloud-bigtable-client
Coping the .proto files is there for clarity / as a reference for the relevant concepts. IIRC it was your original encouragement (for datastore) that led us to start including them.
They are generated via make generate

They are generated via make generate

At one point, I wanted to work on the Makefile, but couldn't figure out how to reproduce the environment it expected.

Yeah it relies on gRPC being easy to install, which is not quite there yet. And AFAIK there is no good way to get the grpc_python_plugin without building from source.

I opened #1482 to track the build-from-protos issue.  LGTM.


add MQTT push gateway

Hi,
I'm building a push gateway for MQTT, and since I couldn't find anything that exists already, I thought I'd share.
I allocated port 9466 on the default port allocations page.
I'm not sure if the section is correct, but since I didn't find an obviously better one, I thought I'd add it right next to the existing MQTT exporter.
Signed-off-by: Michael Ziegler<EMAIL_ADDRESS>

how is MQTT user-specific :confused:

What you are doing here with MQTT is specific to you as far as I can see. An MQTT exporter would be monitoring MQTT itself, not using it as a data pipeline.

Pushing metrics is not a recommended way to use Prometheus, nor are non-HTTP data transfer mechanisms. I don't see anything to indicate that what you're working off here is some form of standard as opposed to something that you have created yourself. We want to list integrations with established systems and protocols, not facilitate the creation of brand new ones. I'm afraid we cannot list this here.


Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-library
org.scala-js:scalajs-test-interface

from 0.6.24 to 0.6.26.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

Merging #1022 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   85.37%   85.17%   -0.21%
==========================================
  Files          75       75
  Lines        2386     2374      -12
  Branches      173      172       -1
==========================================
- Hits         2037     2022      -15
- Misses        349      352       +3

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/shapes/SizedInstances.scala
78.57% <0%> (-14.29%)
:arrow_down:

...e/generic/extras/decoding/EnumerationDecoder.scala
88.88% <0%> (-11.12%)
:arrow_down:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0%> (-8.34%)
:arrow_down:

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
94.59% <0%> (-2.71%)
:arrow_down:

...les/core/shared/src/main/scala/io/circe/Json.scala
77.07% <0%> (-2.55%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
87.95% <0%> (-1.81%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
92% <0%> (+0.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361d7a...f8c83e0. Read the comment docs.

Included in #1015.


[Feature request] Allow "merging" of technical replicates in MQ exporter

E.g. I would like to able to construct an mqpar.xml with the following:
	<experiments>
		<string>Sample1</string>
		<string>Sample1</string>
		<string>Sample1</string>
		<string>Sample2</string>
		<string>Sample2</string>
		<string>Sample2</string>
...
	</experiments>

Instead of the current:
	<experiments>
		<string>Sample1_Tr_1</string>
		<string>Sample1_Tr_2</string>
		<string>Sample1_Tr_3</string>
		<string>Sample2_Tr_1</string>
		<string>Sample2_Tr_2</string>
		<string>Sample2_Tr_3</string>
...
	</experiments>

Whether this should be the default is debatable I guess.

Hi jpfeuffer @jpfeuffer , in MaxQuant Tutorial: experiment: everything that has the same name in the experiment column will be combined in the output – e.g. all slices of one gel lane belong to one experiment (everything that has the same identifier in experiment column will be summarized at the end), technical replicates belong to different experiments (otherwise, the intensities would be combined).  So I used Sample + technical as the experiment id. I am not sure if Allow "merging" of technical replicates  makes sense

Ah, thanks for pointing that out. I did not know that. I thought they might have a clever way of combining them. I will resort to statistical post-processing on the single replicate quantities then.


Adapt Rocket Chat to use GitOps/CCM

Update the Rocket.Chat deployment to use GitOps/CCM;

Needs to be closed. Wrong repo.


Fullwidth page fix and theme options update.

Fix the full page width issue, adds a theme option for the class and sets some sensible defaults for the various frameworks on that option.

I accidentally included a deactivation hook in roots-options.php which I had intended to remove. It wouldn't really hurt anything and may even alleviate a few headaches for some but it could just be superfluous. Let me know and I'll fix and re-pull if needed.

Could you remove the deactivation hook? We should consider it separately if it has some benefits. Don't want that change to get lost in this one. Otherwise, pull request looks like a needed solution.

I removed the deactivation hook. It's really only useful to make sure options are rebuilt when a change is made during development. Cheers.

thanks @johnnypeck - i would have pulled this in already but now i'm rethinking including the full width template. do you think it's worth it to keep it?

@retlehs I think it makes sense to have the full width. It's a very common use case and if anything shows an example full width layout to start with for a child theme to implement.

one last thing: in the options the label is called '#fullwidth CSS Classes'
it's just a class on the #main ID so a better label might be something like 'Full Width CSS Classes'
once that's updated i'll pull this in, thx @johnnypeck

@retlehs No worries. Good call on the option naming. Have a good one.

I went ahead and tried to implement this code and noticed this with 960.gs:
When I created a new page, say "Test," with the Full Width Template in 960.gs, I successfully saw the grid_12 class appear.
However, this did not work on my page named "Home." grid_7 and the sidebar still appear. I deleted the page and tried again, but still saw that the sidebar div was appearing. The only part of the commit I didn't add was the 'fullwidth' arg in the arrays for the other frameworks in roots-options.php.
Any idea on why this wouldn't work?
Thanks a lot for the work @johnnypeck and @retlehs.

@aboutaaron WordPress automatically uses front-page.php if it is present in a theme when you select a static home page. If it was not present in roots then you could use any template you like.

Any word on getting this pull request merged?

@retlehs Any word on getting this pull merged?

done with 9da422e00831d1f31f807e6546e9b6eac528f289, thx @johnnypeck


[svtplay] Work around broken fragment URLs for svtplay as described in issue 10909

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This pull request works around (or fixes, depending on your PoV) issue #10909 I have compared svtplay downloads that succeeded with svtplay downloads that failed. The succesful ones download their fragments from URLs of the form '<...>/dash-live/./< subdir >/< file >.m4a', whereas the failed ones attempted a download from '<...>/dash-live/< file >.mpd?alt=http://switcher.cdn.svt.se/./< subdir >/< file >.m4a' (note the lack of '/./' after 'dash-live' in this case). Immediately trying to download from the url specified in the alt= parameter failed, but rewriting the full url by collapsing the part after 'dash-live/' until the '/./' in the alt= parameter did work.
It looks (and is) somewhat ad hoc, but at least it works on the examples I tried.

You should treat the cause not the consequence.


Test and decide naming convention and implementation of Mixins

Background:
Mixins are one way to encapsulate functionality that can than be added to other classes. The other approach is using abstract base classes or non abstract classes to inherit from. All three approaches work via inheritance.
Points to discuss / test:
1. Naming convention

there is a convention that  one of the differences between mixins and classes is, that a class doesn't work if it only inherits from a mixin. Like so (using a View as an example:

# note that this mixin does not inherit from django's build in View-class.
class MyViewMixin:

    def mixin_method(self):
        pass

# this should not work according to the above convention (and it would not work as a view in django in this case)
class MyView(MyMixin):
    pass

# but this should work
class MyView(MyMixin, View):
    pass

Question here is: Do we want to adhere to this convention? Or do we need to diverge from it and communicate it in the dev-documentation?

the convention would be that if a class provides functionality that should be inherited but can be used via single inheritance, it should be not named a "mixin" but like the type of class that it extends (examples are TableView vs. TableMixin, etc.)
the other convention to take into consideration is that mixins should only inherit form other mixins, but not other classes.

2. Check compatability of our mixin implementation

If we use mixins that inherit from standalone classes, we need to check that all mixins that might be used on the same type of class are compatible with each other. The most common problem that might occur is an unexpected or unresolvable MRO (Method Resolution Order). For example:

class MyMixinA(View):

    # overrides save method of view
    def save(self, *args, **kwargs):
        super().save(*args, **kwargs)

class MyMixinB(View):

    # also overrides save method of view
    def save(self, *args, **kwargs):
        super().save(*args, **kwargs)

# this might break in certain conditions, which we should test.
# This class now inherits the build-in View class three times
class MyView(MixinA, MixinB, View):
     pass

We would need to test that all mixins we write for a certain type of class (like View, Table, Form, Model) are compatible with each other (i.e. can be used in the same class). It should also not matter in which order you add a mixin to the inheritance tree – as long as the django provided class comes last in the inheritance tree.
Usually python throws an error if the MRO can't be resolved, but we should test also if the functionality provided by each mixin still works as expected, even if the MRO does not break.

For reference on Mixin impemenations in Django see:

Classy Class Based Views
specific example on the difference between a implementing form functionality within a View and within a Mixin:

FormMixin
FormView

Regarding the topic of compatability of mixins, django itself warns that not all django provided mixins work together:

django docs

But we should still test that those mixins that we want to be allowed to be used together actually work.

Ahh, thanks, @gregorpirgie, now I finally know (again) why I was confused about the broader use of the term "mixin" during previous discussions. In my mind it wasn't just any class that other classes inherit from (but I couldn't remember what differentiated it).

Closing this. We discussed the issue at length, but the issue is not actionable. For the GenericModel we use the abc (abstract base class) namespace, so its clear that this is not a mixin


Update cluster profile secret section

Updates the docs with the new way of handling secrets.
/hold

/unhold

/lgtm


Node Prune does not work in new Macbook with M1 pro chip

executor failed running [/bin/sh -c apk add --no-cache bash curl git py-pip make &&   curl -sfL https://install.goreleaser.com/github.com/tj/node-prune.sh | sh &&   npm install node-dev -g && npm cache clean --force]: exit code: 1
This was the error I was getting. I changed the dockerfile to this
RUN apk add --no-cache bash curl git py-pip make &&
npm install node-dev -g && npm cache clean --force
RUN apk --no-cache add curl bash
RUN npx node-prune
to make it work

Thank you for info. We're going to fix it this week or maybe you want to do PR yourself, than feel free too :) The solution looks fine for me 👍

Fixed in new version


Vim-airline separator not showing properly in tmux

environment

vim: 8.0
vim-airline: 0.8 commit : c386332
OS: Ubuntu 17.04 32bit
What is your airline configuration: ???
if you are using terminal:
terminal: gnome-terminal with tmux
$TERM variable: screen-256color
does it happen in Vim: yes

actual behaviour
when using vim inside tmux , vim-airline separator not showing properly

expected behaviour
while using without tmux

.tmux.conf file:
set -g default-terminal "screen-256color"
setw -q -g utf-8 on
export TERM=screen-256color

vim-airline conf:
let g:airline_solarized_bg='dark'
let g:airline#extensions#tabline#enabled = 1
 let g:airline_theme='luna'
" let g:airline_theme = "hybrid"
let g:airline_powerline_fonts = 1
if !exists('g:airline_symbols')
	let g:airline_symbols = {}
endif

let g:airline_symbols.space = "\ua0"
let g:airline#extension#tabline#show_buffers = 0

let g:Powerline_symbols='unicode'

This is Unicode problem and tmux has solution to solve by adding -u
# I recommend you to put this in your ~/.bashrc
alias tmux='tmux -u'


Create Firebase config file (after firebase is set up)

Acceptance Criteria:
Add a firebase.js config file that has the Firebase API keys, and sets up Firebase in the project.