(PUP-11993) The rest of the Style/Redundant* cops!

For posterity, the Redundant/Self is auto-correct safe, but there is a subtle issue to be aware of. If the method being called is a writer/accessor, then you have to use self. For example, here's a class Foo with an accessor name:
❯ cat setter.rb
# frozen_string_literal: true

class Foo
  attr_accessor :name

  def noself(arg)
    name = arg
  end

  def useself(arg)
    self.name = arg
  end
end

f = Foo.new
f.noself('a')
puts "name '#{f.name}'"
f.useself('a')
puts "name '#{f.name}'"

Note the noself and useself methods behave differently:
❯ bx ruby setter.rb
name ''
name 'a'

This occurs because the noself method actually creates a temporary variable named name instead of calling the accessor!!
Rubocop does detect that the noself method isn't doing what it should and we have that cop enabled:
❯ bx rubocop setter.rb
...
setter.rb:7:5: W: [Correctable] Lint/UselessAssignment: Useless assignment to variable - name.
    name = arg
    ^^^^

And rubocop seems to have left alone places where a writer/accessor are being called:
❯ git grep -E 'self\.\w+ = ' lib | head
lib/puppet/application.rb:      self.run_status = nil
lib/puppet/application.rb:      self.run_status = :stop_requested
lib/puppet/application.rb:      self.run_status = :restart_requested
lib/puppet/application/face_base.rb:    self.render_as = format.to_sym
lib/puppet/file_serving/base.rb:    self.path = path
lib/puppet/file_serving/base.rb:    self.links = links if links
lib/puppet/file_serving/base.rb:    self.relative_path = relative_path if relative_path
lib/puppet/file_serving/base.rb:    self.source = source if source
lib/puppet/file_serving/fileset.rb:    self.ignore = []
lib/puppet/file_serving/fileset.rb:    self.links = :manage
...

So I think the RedundantSelf changes are ok.


(test) completed testing for available_times.feature, fixed some issu…

…es with the profile page view.

Looks good.


Build Error

Describe the issue
Hello, ive a big problem when i try to rebuild the project (ive installed yarn, typescript and react)
$ yarn build yarn run v1.22.22 $ tsc && vite build src/components/App.tsx(1,44): error TS2307: Cannot find module 'react' or its corresponding type declarations. src/components/App.tsx(51,54): error TS7031: Binding element 'type' implicitly has an 'any' type. src/components/App.tsx(51,60): error TS7031: Binding element 'message' implicitly has an 'any' type. src/components/App.tsx(51,69): error TS7031: Binding element 'speed' implicitly has an 'any' type. src/components/App.tsx(56,20): error TS7006: Parameter 'prevPosition' implicitly has an 'any' type. src/components/App.tsx(71,5): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(71,5): error TS2307: Cannot find module 'react/jsx-runtime' or its corresponding type declarations. src/components/App.tsx(87,7): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(98,7): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(99,7): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(109,7): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(110,5): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(131,5): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/components/App.tsx(140,5): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/hooks/useNuiEvent.ts(1,53): error TS2307: Cannot find module 'react' or its corresponding type declarations. src/main.tsx(1,19): error TS2307: Cannot find module 'react' or its corresponding type declarations. src/main.tsx(2,22): error TS2307: Cannot find module 'react-dom/client' or its corresponding type declarations. src/main.tsx(8,3): error TS2307: Cannot find module 'react/jsx-runtime' or its corresponding type declarations. src/providers/VisibilityProvider.tsx(7,8): error TS2307: Cannot find module 'react' or its corresponding type declarations. src/providers/VisibilityProvider.tsx(22,3): error TS7031: Binding element 'children' implicitly has an 'any' type. src/providers/VisibilityProvider.tsx(46,5): error TS2307: Cannot find module 'react/jsx-runtime' or its corresponding type declarations. src/providers/VisibilityProvider.tsx(52,7): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/providers/VisibilityProvider.tsx(56,7): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. src/utils/debugData.ts(16,19): error TS2339: Property 'env' does not exist on type 'ImportMeta'. error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Expected behavior
Build OK
To Reproduce
Try a build at local environment.
Media

Additional context

To fix this error, install the types and rebuild

you need to run command (yarn) to install depandencies befor the build command


Add .clang-format

After a bunch of testing, this Clang Format configuration is quite close to what is done most of the time in this repository. The only thing I've found which it breaks consistently is when an UDT is instanciated inline, the braces are split:
struct bar
{ } foo;

becomes
struct bar
{
} foo;

and (maybe worse cause that's how it's often written in this project)
struct bar
{ }
// comment
foo;

becomes
struct bar
{
}
// comment
foo;

. This along with disallowing the rest of multiple operator seperated items in argument position to flow to the last line if they are neccesary to split giving:
throw invalid_argument("Adiar requires at least "
                       + std::to_string(minimum_memory / 1024 / 1024)
		       + " MiB of memory");

becomes
throw invalid_argument("Adiar requires at least "
                       + std::to_string(minimum_memory / 1024 / 1024) + " MiB of memory");

Except for that, all changes I've observed it making is within "normal" for the codebase. Currently (as of clang format 18) the first problem is unfixable - a PR to fix it had been stuck since 2020, and has since been closed. The second I have not been able to find a solution to.
In the name of not letting the perfect be the enemy of the good, I still propose adopting this. It "fixes" a lot of inconsistent formatting as it is now, and I think it is a nice developer experience to be able to write a piece of code, and have most of the formatting taken care of by a tool.

To try it out, checkout this branch, and call
clang-format <file-name> -i

to have it reformat .

Great work. That would definitely be a great addition - especially when others than me actually want to contribute.
I tried to run it and found a few things. I can live with some other "compromises" to fix them.
1. Indentation of Member list
-    builder_ptr(const internal::node::uid_type &p,
-                const shared_ptr<const builder_shared> &sp)
-      : uid(p), builder_ref(sp)
-    { }

+    builder_ptr(const internal::node::uid_type& p, const shared_ptr<const builder_shared>& sp)
+        : uid(p), builder_ref(sp)
+    {}

Indentation is here 4 spaces rather than 2.
2. One-liner constructors
Exhibit A:
-    builder() noexcept
-    { }

+    builder() noexcept {}

Exhibit B:
-    exec_policy(const access &am)
-      : _access_mode(am)
-    { }

+    exec_policy(const access& am) : _access_mode(am) {}

Can the constructors always have line breaks after the arguments and the member initialisation list?
Line Breaks on boolean operations
-      return this->memory_mode()  == ep.memory_mode()
-          && this->access_mode()  == ep.access_mode()
-          && this->quantify_alg() == ep.quantify_alg()
-        ;

+      return this->memory_mode() == ep.memory_mode() && this->access_mode() == ep.access_mode()
+          && this->quantify_alg() == ep.quantify_alg();

If there is a line break, then I would prefer it breaks all of them. The idea being, that the 'vertical' dimension is the conditions and the horizontal then their content.
4. Weird 4-space indentations
In src/adiar/internal/algorithms/reduce.h. Is this related with trying to align the statement with return?
       adiar_assert(!arcs.can_pull_internal()
-                   || current_map.old_uid == arcs.peek_internal().target(),

       adiar_assert(!arcs.can_pull_internal()
+                       || current_map.old_uid == arcs.peek_internal().target(),
                    "Mapping forwarded in sync with internal arcs");

And in src/adiar/internal/algorithms/prod2.h. Here, it adds an odd additional indentation.
   using prod_priority_queue_1_t =
-    levelized_node_priority_queue<prod2_request<0>, request_data_first_lt<prod2_request<0>>,
-                                  look_ahead,
-                                  mem_mode,
-                                  2,
-                                  0>;

   using prod_priority_queue_1_t =
+      levelized_node_priority_queue<prod2_request<0>,
+                                    request_data_first_lt<prod2_request<0>>,
+                                    look_ahead,
+                                    mem_mode,
+                                    2,
+                                    0>;

Conflicting with Emacs
Overall the GNU style is Emacs-compatible. So, if there are settings in the GNU clang-format file that conflicts with this then the GNU setting would be the safest to use. The exception would be all settings that can be resolved with a 'newline' character (Emacs does not add newlines, but has an "intelligent" indentation). In general, I'm ok with being more GNU-like at the compromise of some parts of the codebase (which I indented manually).
Indentation of Member list
-    builder_ptr(const internal::node::uid_type &p,
-                const shared_ptr<const builder_shared> &sp)
-      : uid(p), builder_ref(sp)
-    { }

+    builder_ptr(const internal::node::uid_type& p, const shared_ptr<const builder_shared>& sp)
+        : uid(p), builder_ref(sp)
+    {}

Indentation is here 4 spaces rather than 2.
Comma in Member Initialisation List
In src/adiar/internal/data_structures/levelized_priority_queue.h
-    levelized_priority_queue(tpie::memory_size_type memory_given, size_t max_size,
-                             [[maybe_unused]] statistics::levelized_priority_queue_t &stats)
-      : _max_size(max_size)
-      , _memory_given(memory_given)
-      , _memory_for_buckets(memory_given - _memory_occupied_by_merger - mem_overflow_queue(memory_given))
-      , _memory_occupied_by_overflow(mem_overflow_queue(memory_given))
-      , _overflow_queue(mem_overflow_queue(memory_given), max_size)

+    levelized_priority_queue(tpie::memory_size_type memory_given,
+                             size_t max_size,
+                             [[maybe_unused]] statistics::levelized_priority_queue_t& stats)
+        : _max_size(max_size),
+          _memory_given(memory_given),
+          _memory_for_buckets(memory_given - _memory_occupied_by_merger
+                              - mem_overflow_queue(memory_given)),
+          _memory_occupied_by_overflow(mem_overflow_queue(memory_given)),
+          _overflow_queue(mem_overflow_queue(memory_given), max_size)

Here, Emacs would de-indent all but the first member initialisation by two. This is why, I move the , to the start of the line, because then Emacs nicely aligns everything.
Unexpected 4-space indentations
In src/adiar/internal/algorithms/reduce.h. Is this related with trying to align the statement with return?
       adiar_assert(!arcs.can_pull_internal()
-                   || current_map.old_uid == arcs.peek_internal().target(),

       adiar_assert(!arcs.can_pull_internal()
+                       || current_map.old_uid == arcs.peek_internal().target(),
                    "Mapping forwarded in sync with internal arcs");

And in src/adiar/internal/algorithms/prod2.h. Here, it adds an odd additional indentation.
   using prod_priority_queue_1_t =
-    levelized_node_priority_queue<prod2_request<0>, request_data_first_lt<prod2_request<0>>,
-                                  look_ahead,
-                                  mem_mode,
-                                  2,
-                                  0>;

   using prod_priority_queue_1_t =
+      levelized_node_priority_queue<prod2_request<0>,
+                                    request_data_first_lt<prod2_request<0>>,
+                                    look_ahead,
+                                    mem_mode,
+                                    2,
+                                    0>;

And in src/adiar/internal/data_structures/levelized_priority_queue.h
     ////////////////////////////////////////////////////////////////////////////
     /// \brief Total number of data structures in Levelized Priority Queue.
     ////////////////////////////////////////////////////////////////////////////
     static constexpr size_t data_structures =
-      buckets * sorter_t::data_structures + priority_queue_t::data_structures;

     ////////////////////////////////////////////////////////////////////////////
     /// \brief Total number of data structures in Levelized Priority Queue.
     ////////////////////////////////////////////////////////////////////////////
     static constexpr size_t data_structures =
+        buckets * sorter_t::data_structures + priority_queue_t::data_structures;

Struct Initialisation
In src/adiar/statistics.cpp, the indentation on the struct misaligns with Emacs.
-    return {
-      // i/o
-      internal::stats_arc_file,
-      internal::stats_node_file,
-
-      // data structures
-      internal::stats_levelized_priority_queue,
-
-      // top-down sweeps
-      internal::stats_count,
-      internal::stats_equality,
-      internal::stats_intercut,
-      internal::stats_optmin,
-      internal::stats_prod2,
-      stats_prod3,
-      internal::stats_quantify,
-      internal::stats_select,
-
-      // bottom-up sweeps
-      internal::stats_reduce,
-
-      // other algorithms
-      internal::nested_sweeping::stats
-    };

+    return {// i/o
+            internal::stats_arc_file,
+            internal::stats_node_file,
+
+            // data structures
+            internal::stats_levelized_priority_queue,
+
+            // top-down sweeps
+            internal::stats_count,
+            internal::stats_equality,
+            internal::stats_intercut,
+            internal::stats_optmin,
+            internal::stats_prod2,
+            stats_prod3,
+            internal::stats_quantify,
+            internal::stats_select,
+
+            // bottom-up sweeps
+            internal::stats_reduce,
+
+            // other algorithms
+            internal::nested_sweeping::stats};

Odd indentation for function call
In src/adiar/internal/data_structures/levelized_priority_queue.h.
-    static_assert(ptr_uint64::max_label+1 > ptr_uint64::max_label,
-                  "'ptr_uint64::label_type' should leave a window of at least one above 'max_label'");

+    static_assert(
+        ptr_uint64::max_label + 1 > ptr_uint64::max_label,
+        "'ptr_uint64::label_type' should leave a window of at least one above 'max_label'");

Emacs would in this case even with the 'newline' added indent it up to the ( parentheses.

Other (Personal Preference)
One-liner constructors
In src/adiar/builder.h
-    builder() noexcept
-    { }

+    builder() noexcept {}

In src/adiar/exec_policy.h
-    exec_policy(const access &am)
-      : _access_mode(am)
-    { }

+    exec_policy(const access& am) : _access_mode(am) {}

Can the constructors always have line breaks after the arguments and the member initialisation list?
Line Breaks on binary operations
In src/adiar/exec_policy.h.
-      return this->memory_mode()  == ep.memory_mode()
-          && this->access_mode()  == ep.access_mode()
-          && this->quantify_alg() == ep.quantify_alg()
-        ;

+      return this->memory_mode() == ep.memory_mode() && this->access_mode() == ep.access_mode()
+          && this->quantify_alg() == ep.quantify_alg();

If there is a line break, then I would prefer it breaks all of them. The idea being, that the 'vertical' dimension is the conditions and the horizontal then their content. But, it is fair, if that is not possible.
Similarly, in src/adiar/statistics.cpp
     uintwide total_runs = internal::stats_prod2.trivial_file
-                        + internal::stats_prod2.trivial_terminal
-                        + internal::stats_prod2.ra.runs
-                        + internal::stats_prod2.pq.runs;

     uintwide total_runs = internal::stats_prod2.trivial_file
+                        + internal::stats_prod2.trivial_terminal + internal::stats_prod2.ra.runs
+                        + internal::stats_prod2.pq.runs;

I think I have exhausted all observations on its changes (noted above). Overall, it looks really good! Most of the changes a perfect and makes older code align with styling I've adopted recently as I've learned more things.

To integrate clang-format with CMake add the following file
./cmake/clang-cxx-dev-tools.cmake:
# Slight variation on:
#   https://www.labri.fr/perso/fleury/posts/programming/using-clang-tidy-and-clang-format.html

# Get all src/ files
file(GLOB_RECURSE ALL_SRC_FILES
  ${PROJECT_SOURCE_DIR}/src/*.[chi]pp
  ${PROJECT_SOURCE_DIR}/src/*.[chi]xx
  ${PROJECT_SOURCE_DIR}/src/*.cc
  ${PROJECT_SOURCE_DIR}/src/*.hh
  ${PROJECT_SOURCE_DIR}/src/*.ii
  ${PROJECT_SOURCE_DIR}/src/*.[CHI]
)

# Get all test/ files
file(GLOB_RECURSE ALL_TEST_FILES
  ${PROJECT_SOURCE_DIR}/test/*.[chi]pp
  ${PROJECT_SOURCE_DIR}/test/*.[chi]xx
  ${PROJECT_SOURCE_DIR}/test/*.cc
  ${PROJECT_SOURCE_DIR}/test/*.hh
  ${PROJECT_SOURCE_DIR}/test/*.ii
  ${PROJECT_SOURCE_DIR}/test/*.[CHI]
)

# Adding clang-format target if executable is found
find_program(CLANG_FORMAT "clang-format")
if(CLANG_FORMAT)
  add_custom_target(
    clang-format
    COMMAND /usr/bin/clang-format
    ${ALL_SRC_FILES} ${ALL_TEST_FILES}
    -i
  )
endif()

# Adding clang-tidy target if executable is found
find_program(CLANG_TIDY "clang-tidy")
if(CLANG_TIDY)
  add_custom_target(
    clang-tidy
    COMMAND /usr/bin/clang-tidy
    ${ALL_SRC_SOURCE_FILES} ${ALL_TEST_SOURCE_FILES}
    -config=''
    --
    -std=c++11
    ${INCLUDE_DIRECTORIES}
  )
endif()

Then add the following to the root-directory CMakeLists.txt
# ============================================================================ #
# Formatting
# ============================================================================ #
include(cmake/clang-cxx-dev-tools.cmake)

Finally, add the following to the makefile to hide CMake.
# ============================================================================ #
#  CLANG TOOLS
# ============================================================================ #
clang/format:
	@mkdir -p build/ && cd build/ && cmake -D CMAKE_BUILD_TYPE=$(BUILD_TYPE) ..
	@cd build/ && make clang-format


Deprecated: Document.createDocuments

Describe the bug
It is no longer supported to create temporary documents using the Document.createDocuments API. Use the new Document() constructor instead.
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
(This issue is only a reminder, not sure to file that as a bug of feature)
To Reproduce
example: modules/items/item-sheet-ffg.js:711
Desktop (please complete the following information):

Foundry Version: v12.330
System Version: 1.903
Hosted on Forge: No

Hooray...


Error in GitHub Workflow: sfpowerscripts Orchestrator:Prepare with auth:accesstoken:store

Description
I am attempting to run the sfpowerscripts orchestrator:prepare command within a github workflow. Even though the authentication method used is auth:accesstoken:store, the following error is thrown:
    Error: Unable to execute command .. Error: Pools have to be created using
    a DevHub authenticated with auth:web or auth:store or
    auth:accesstoken:store

Steps To Reproduce

Authenticate using JWT with sfdx auth:jwt:grant.

Extract AccessToken using sfdx force:org:display.

Deauthenticate/remove the JWT auth configuration [sfdx auth:logout, rm -f ~/.sfdx/*.json].

Authenticate using the extracted AccessToken with sfdx auth:accesstoken:store.

Run the sfpowerscripts orchestrator:prepare command

Platform Details (please complete the following information):

OS: Ubuntu 22.04.3
Salesforce CLI(sfdx cli) Version: @salesforce/cli/2.14.6 linux-x64 node-v18.18.2
CI Platform: Github

@GiladKW the error message is misleading. dx@scale does not support the jwt login flow. There's a convo about it here: https://flxbl-io.slack.com/archives/CN9N54GF5/p1693248029499739

@rygramer How do we get access to this Slack workspace? Thanks!

Closing this one as its invalid


Allow specifying position on individual toasts

Like the title says, is there a way or will there be a way to specify per push the position of a toast?
I have a use-case where I would like to have a certain type of toast appear from the bottom of the screen and another where it would be ideal for it to be in the top right on the same page.

That's a good question. At the moment, multiple toast containers (and correspondingly, multiple toast stacks) is not supported - I'm assuming for your use-case, you'd like Type A toasts to appear in Position A, and at the same time, Type B toasts to appear in Position B, where both types may appear concurrently.
If you don't require both toasts to appear concurrently (or you don't need 2 toast stacks), then I think it's possible right now to dynamically change the toast container position when needed.
Adding support for multiple toast instances will be an interesting feature to add though. I'll think about what it entails and might add it in the next release. 😁

That's a good question. At the moment, multiple toast containers (and correspondingly, multiple toast stacks) is not supported - I'm assuming for your use-case, you'd like Type A toasts to appear in Position A, and at the same time, Type B toasts to appear in Position B, where both types may appear concurrently.

This is the correct behaviour I am looking for.

If you don't require both toasts to appear concurrently (or you don't need 2 toast stacks), then I think it's possible right now to dynamically change the toast container position when needed.

Sadly both toasts has the potential to show at the same time.

Edited the title to mark this as a feature request. We can use this issue to track progress or to hold discussions.

HI @asjur - this feature is added in the latest release. Essentially, you can now set a toast container target:
<SvelteToast target="myNewContainer" options={{ ... }} />

and send toasts to that target:
toast.push('Hello', { target: 'myNewContainer` })

More info here: https://github.com/zerodevx/svelte-toast#supporting-multiple-toast-containers
Will close this issue for now, but please re-open if you encounter any problems!


Admin.html upgrade & changes for using another expression on detail*.js

Just see the commit from Nov 13 is enough 👍
Add description and upload picture function for admin.html

add a description and upload input for editing event

add a upload picture function to upload a picture to the firebase

if not select a photo, it can be successfully leave the page without affecting imgURL.

changes for using another expression on detail*.js
-just change all to retrieveOnceFirebase function
-       database.ref(refPath).once("value").then(function (data)
+      retrieveOnceFirebase(firebase,refPath, function (data)

Nice


Persons: search in admin grid isn't working

It wasn't working because ElasticSearch module, it was installed but not configured.


Added my data

Good job @AmiteshPatra
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.
Note that this repo is excluded from Hacktoberfest but this PR is still eligible for ClueLess Swags.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

@Rajdip019  thanks for merging my PR, here's my profile URL : https://www.clueless.tech/profile/96640527


Paper of threshold EdDSA

Which paper is the implementation of threshold eddsa based on? Is it 'Provably Secure Distributed Schnorr Signatures and a (t, n) Threshold Scheme for Implicit Certificates'?

The implementation is based on an internal document. It's quite simple, however strictly speaking it's not precisely align to the original EdDSA scheme.


WIP Optimize commutation analysis

Summary
Aims to optimize commutation analysis by performing commutation tests in Rust.
Details and comments

Initial implementation. Only limited testing has been performed.
Future steps would be to create a similar function to Operator.compose() in rust.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

32 of 38 (84.21%)  changed or added relevant lines in 4 files are covered.
14 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.009%) to 87.256%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/accelerate/src/commute.rs
25
31
80.65%

Files with Coverage Reduction
New Missed Lines
%

qiskit/extensions/unitary.py
1
93.75%

qiskit/extensions/quantum_initializer/squ.py
2
80.0%

crates/qasm2/src/lex.rs
5
91.65%

crates/qasm2/src/parse.rs
6
97.6%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
74287

Relevant Lines:
85137

💛  - Coveralls


Kingsbury High school

This is a high school that also provides a Sixth Form which is also known as High Education providing BTECs and A Levels. This includes Computer science a level and IT BTECS.

@AhmedJeylani Pull request merged. Thank you!


Get additional parcellation stats

I have a pre-run version of Fastsurfer outputs (#256), but I'd like to get not just the DKT parcellation but also just aparc for use with Enigma Toolbox. I know there's the --fsaparc flag but I didn't use it the first time around.
Is there away to get the aparc parcellation stats without having to reprocess everything? I tried adding --seg_only --fsaparc but it complained about using the existing output directory.

Hey araikes,
if you already ran the recon-surf pipeline including the --surf-reg option (which is turned on by default), you can create the aparc stats using FreeSurfer commands by running mris_ca_label and mris_anatomical_stats (see also https://github.com/Deep-MI/FastSurfer/issues/89):
cd $SUJECTS_DIR/<subjid>/mri

# create atlas annotations (?h.aparc.annot)
mris_ca_label -l ../label/lh.cortex.label -aseg mri/aseg.presurf.mgz <subjid> ?h ?h.sphere.reg $FREESURFER_HOME/average/?h.curvature.buckner40.filled.desikan_killiany.2007-06-20gcs ?h.aparc.annot

# Get stats
mris_anatomical_stats -th3 -mgz -cortex ../label/?h.cortex.label -f stats/?h.aparc.stats -b -a label/?h.aparc.annot -c label/aparc.annot.ctab <subjid> ?h

Kind regards,
Leonie

Have you tested if the Enigma tools also take DKT? I am not familiar with it, but the two are very similar with one region missing in DKT. Enigma tools may still run.
Given that the DKT is the improved atlas it would be good to adjust the Enigma tools if necessary.

The aparc.DKTatlas and aparc differ in four structures. FastSurfer returns the DKTatlas segmentations by default, which has 31 labels per hemisphere (paper: https://www.frontiersin.org/articles/10.3389/fnins.2012.00171/full). The aparc+aseg.mgz (=aparc) is based on another atlas (Desikian, 35 parcels per hemisphere; paper: https://www.sciencedirect.com/science/article/abs/pii/S1053811906000437?via%3Dihub). The DKTatlas is basically an adaptation thereof where four labels (bankstss (1001, 2001), corpus callosum (1004, 2004), frontal pole (1032, 2032), and temporal pole (1033, 2033)) have been merged with other labels.

That's perfect. I knew there had to be something simple.
As far as using the DKT atlas, currently the plotting functions use just DK (or Schaefer atlases), so I'm working within what's available for the moment.

Yes, but would it not just skip plotting the missing labels? There are no additional labels in DKT which makes this really simple.

That's a fair point and one which I will need to investigate.

Just a few small edits based on Fastsurfer 2.0.x and Freesurfer 7.3.2, in case anyone else is looking for this (date is different for the lh.curvature.buckner40.filled file and aparc.annot.ctab is aparc.annot.mapped.ctab in the current Fastsurfer version.
cd $SUJECTS_DIR/<subjid>/mri

# create atlas annotations (?h.aparc.annot)
mris_ca_label -l ../label/?h.cortex.label -aseg mri/aseg.presurf.mgz <subjid> ?h ?h.sphere.reg $FREESURFER_HOME/average/?h.curvature.buckner40.filled.desikan_killiany.2010-03-25.gcs ?h.aparc.annot

# Get stats
mris_anatomical_stats -th3 -mgz -cortex ../label/?h.cortex.label -f stats/?h.aparc.stats -b -a label/?h.aparc.annot -c label/aparc.annot.mapped.ctab <subjid> ?h


Specify bytes version

Needed to do this for the v0.11.0 release, but I missed it on my first pass through. Also updated the release notes to hopefully prevent this error in the future.

bors r+


How to translate apt-get install X into packages: X?

Hi there,
I am a new user of this action. I guess this not a really a question for this action, but maybe you can help me out?
I don't know how move from
run: sudo apt-get install --yes texlive-xetex

to
- uses: teatimeguest/setup-texlive-action@v3
  with:
    packages: ???

What schemes or collections should I put here?
Thanks a lot.

It seems there's no direct correspondence for the texlive-xetex Ubuntu package.
As a starting point, you can try with
- uses: teatimeguest/setup-texlive-action@v3
  with:
    packages: |
     collection-basic
     collection-latex
     collection-latexextra
     collection-latexrecommended
     collection-xetex

Or, you could just do a full installation with scheme-full.

@afuetterer The list of installed TeX Live packages can be dumped in JSON format by the following command:
$ tlmgr dump-tlpdb --local --json > packages.json

So if you install TeX Live via apt and then run this command, you will see what packages are included in texlive-xetex.

Here are some supplemental notes:

Unlike other package managers such as pip or npm, TeX Live (tlmgr) has little dependency management, so generally it is hard to determine exactly which packages you need. But there are some tools for this problem:

TeXFindPkg – Query or install TeX packages and their dependencies
DEPP – Dependency Printer for TeX Live
texliveonfly – On-the-fly download of missing TeX live packages

act is very useful for testing and initial setup as it allows you to run CI workflows locally. If you are using a container environment such as docker, I would strongly recommend using it.
This action can be run on a node:20 image. (For reference, the config file I use can be found here)

If you are using XeTeX and just want to create PDFs for personal use, Tectonic might be a good alternative. It automatically installs dependent packages and appears to have GitHub Actions for setup.

I hope this helps.

Thank you both, I will try the suggestions.

Added "Troubleshooting" in README.md.
I am closing this issue for now, but feel free to reopen it if you have any problems.


Add new --upload option

we don't want to upload nightlies as release builds from all VM build machines,  only from the
real build machine, i.e. if run from the cron via bin/nightly-build.sh.  Also updated README.md for the
required fog gem.

@jrafanie please review.

this looks nice.
[soapbox]can we stop reindenting stuff? you added a few lines and it made it look like you changed 1/2 the script - git blame is no longer helpful either[/soapbox]

Nice @abellotti, good call, I forgot this would affect test builds.  Thanks :clap:

Looks good to me :+1:  @jrafanie Can we merge anyway ignoring the alignment stuff?

Looks good, merging.


[Feature] Can not add as library

Initial checklist

[X] Is this really a problem?
[X] I have searched the Github Issues for similar issues, but did not find anything.

Problem
yarn add @univerjs/base-render
YN0001: │ Error: @univerjs/core@workspace:^0.0.1: Workspace not found (@univerjs/core@workspace:^0.0.1)
Solution
Support use as a library.
Alternatives
No

We haven't released this package in npm yet.

Has any plan?

Has any plan?

Next month, we will release an early preview version.


Update 2015-03-31-5.0.0.md

Included some docs around a breaking change while following the ES6 spec on imports being hoisted.

Awesome, thank you @dariocravero!


Describe the bug
I tried to implement a Tag model as described in the documentation. Here is the pivot model definition. (Using static primaryKey = 'id' was just for my own sanity ^^)
export default class Taggable extends Model {
  static entity = 'taggables'

  static primaryKey = 'id'

  @Uid() declare id: string

  @Uid() declare tag_id: string

  @Uid() declare taggable_id: string
  @Attr() declare taggable_type: string
}

Adding tags to a model results in the following error
Error: [Pinia ORM] The record is missing the primary key. If you want to persist record without the primary key, please define the primary key field with the `uid` attribute.
    at throwError (pinia-orm.js?v=f6a016dc:121:9)
    at assert (pinia-orm.js?v=f6a016dc:125:5)
    at Taggable.$getIndexId (pinia-orm.js?v=f6a016dc:3583:5)
    at _Query.reviveOne (pinia-orm.js?v=f6a016dc:1485:27)
    at _Query.reviveRelations (pinia-orm.js?v=f6a016dc:1523:135)
    at _Query.reviveOne (pinia-orm.js?v=f6a016dc:1491:10)
    at pinia-orm.js?v=f6a016dc:1499:26
    at Array.reduce (<anonymous>)
    at _Query.reviveMany (pinia-orm.js?v=f6a016dc:1498:20)
    at _Query.reviveRelations (pinia-orm.js?v=f6a016dc:1523:76)

Looking into the tests I saw the pivot model is defined differently and using this definition does not throw an error
import { Model } from 'pinia-orm'
import { Attr, Uid } from 'pinia-orm/dist/decorators'

export default class Taggable extends Model {
  static entity = 'taggables'

  static primaryKey = ['tag_id', 'taggable_id', 'taggable_type']

  @Uid() declare tag_id: string

  @Uid() declare taggable_id: string
  @Attr() declare taggable_type: string
}

Don't know if that is expected behavior, thus an error in the documentation, or a bug.
Awesome work you are doing here, much love and big thanks. :heart:
Additional context
No response
Logs
No response

This is exspected bahavior because otherwise the pivot cannot have an relation to only one model. Thank's for finding that in the docs. Have to update it.


Remove code from load-balancing.md

Links to code, so dont need to repeat it (also prevent problem of any updates to code needing changed in 2 places)

Minor style guide edit.


Stopped working after 1.3.6 update

Hi, unfortunately GSM backend stopped working on my phone with 1.3.6 update from F-Droid.
(Asus ZF5, Android 4.3, unifiedNlp 1.6.2-dirty from F-Droid)
Same tower, same database (and tower present in database, checked using CellID and sqlite).
1.3.4 works OK, 1.3.6 - no location
(I've checked several times upgrading and downgrading apk)

Is this the same issue as reported in https://github.com/n76/Local-GSM-Backend/issues/62
Can you check your logcat and see if it is related to permission issues or broken pipes when trying to access the database?

adb logcat | grep NlpLocationBackendFuser
gives no information at all
I've checked "| grep Nlp" but even then logs are very scarce.
log.txt


Fix token used for fee label

The sell token should be used for the fee label (instead of the buy token).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 93.033%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
6725

Relevant Lines:
6973

💛  - Coveralls

Had to fix some conflicts @iamacook 🙇


Update Clojars with the latest

The latest version of proto-repl hosted on Clojars is 0.3.1. Your latest release is 1.4.20. It would be great to get an update. Thanks

I think you are mixing up proto-repl the atom plugin located in package.json - 1.4.21 and the proto-repl lein injection which is in proto-repl-lib/project.clj - 0.3.1


api docs not working (autogenerated ones)

I update the code of the api-console to the last version but discover two bugs.
One is in go-raml, I opened an issue on the go-raml project :https://github.com/Jumpscale/go-raml/issues/107
Other one is in the api-console itself, also opened a bug for it: https://github.com/mulesoft/api-console/issues/293


Asset package included scene should be complete

We include the desert scene, but all the assets as part of the scene are not.   Should probably pull them together so it functions.

I read some people offers a slim package with just the utilities and leave the scene and other demos in the repository, provide them as separate zip files or generate a custom package (like the one we have in the repo).

Gotcha.  Good to know.  If you have links, that would be useful.

Will leave scene in repo.
Also added a section in the Getting Started docs that details starting from the project in this repo in addition of starting from a new 3D project:
https://github.com/mozilla/unity-webvr-export/pull/319


Integration generates value change when value does not change

Hi,
I'm using the integration, but every start of the day, the integration generates a value change that generates an invalid statistic.
In Energy, I have configured the XXX Total Production sensor, but every day the integration reports the value 0 at some point and then the accumulated production, but this generates an effect as if at that minute there was a change...

sensor change history:

@douglasfl That spike is caused by the Energy Dashboard that tries to make sense of the first reading of the day. Try updating Home Assistant core and then see if the behavior is correct (there was change recently)


Provide more request headers when intercepting requests

When a request from the example code below is intercepted, the following request headers are available (same as in requestWillBeSent):

referer, user-agent, x-custom-header

But these are the full request headers that Chrome uses when making the request:

Referer, User-Agent, x-custom-header, Accept-Encoding, Host, Accept, Cookie, Connection

Some of those depend on how the actual request is made by Chrome, but these don't:

Cookie (currently I'm generating this by using the cookie API)
Accept (it's probably possible to find a sensible value for this based on the request type)

My end goal would be that I can make the request myself and it will have the same end result as if Chrome had made the request. (So even headers like Accept-Encoding would be helpful.)
The specific problem I've been debugging is that the backend I'm working with was sending different response content based on the value of the Accept header.

Example code:

var puppeteer = require("puppeteer");

(async () => {
  const browser = await puppeteer.launch({ headless: true });
  const page = await browser.newPage();

  await page.goto("http://example.com", { waitUntil: "networkidle2" });

  await page.setRequestInterception(true);
  page.on("request", request => {
    console.log("Interception:", Object.keys(request.headers()).join());
    request.continue();
  });
  page._client.on("Network.responseReceived", data => {
    console.log(
      "ResponseReceived:",
      Object.keys(data.response.requestHeaders).join()
    );
  });
  await page.evaluate(() => {
    document.cookie = "foo=bar";
  });
  await page.evaluate(() => {
    var myHeaders = new Headers();
    myHeaders.append("X-Custom-Header", "Hello");

    var myInit = {
      method: "GET",
      headers: myHeaders
    };

    var myRequest = new Request("http://example.com/?Asdf", myInit);
    fetch(myRequest);
  });

  await page.waitFor(1000);

  browser.close();
})();

@mattzeunert yeah I see; hope it'll work out nicely.

@aslushnikov using the new chrome v73 Network.responseReceived does not contain requestHeaders, only the first request have it. using --disable-site-isolation-trials --disable-features=IsolateOrigins,site-per-process --disable-web-security  have no effect too.
is there anything I can do to get the full headers of the requests with the new chrome versions? thank you


Fixed invalid REST calls URLs in ALM APIs docs

Q
A

content fix?
yes

New article?
no

Related issues?
n/a

What's in this Pull Request?
Fixed invalid REST calls URLs in ALM APIs docs

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/apis/alm-api-for-spfx-add-ins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

This was already previously fixed, so closing this one. Thx.


limit quantification bin numbers to the number of unique values in the column selected

When making a choropleth map (or others) , I am allowed to make a seven bin visualization style even though there are only three data points in the table. Should we limit the number of bins to the number of unique entries in the column?
Here's the data:

Here's the resulting CartoCSS:

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Runtime cleanup (Shim manager and task service)

This PR is a follow up for shim changes https://github.com/containerd/containerd/pull/5918, which addresses this todo.
It further decouples ShimManager and TaskService, so now shim manager is not aware about TaskService or any other service shim provides. Instead it manages generic shims instances, that can implement arbitrary number of services and just exposes a TTRPC client to them (via ShimInstance interface).
Previously it was challenging to make this change because of TaskList v1 dependency (v1 needs a list of Tasks while v2 needs a list of Shims). Since we updated supported Go versions (1.18, 1.19), which both support generics, we can implement multiple variations of TaskList - NSMap[runtime.Task] for v1 and NSMap[ShimInstance] for v2.

Thanks for generalizing the shim manager and providing a way to get access to the ttrpc client. It also seems like a suitable use for generics to me.


Next release planning

[ ] #320 - Fix sending messages starting with a space
[ ] #310 - Add manifest.json for nicer mobile experience
[ ] #307 - Replace all concatenated paths with Node's path.join
[ ] #286 - Display unhandled numerics on the client
Requires irc-fw fix
[ ] #256 - Add support for oidentd spoofing
[ ] #254 - Enable auto reconnection
[ ] #293 - Colon (:) is not correctly escaped in messages without spaces
[ ] Possibly fix SASL
Requires irc-fw fix

#325 ?

@astorije Possibly, will see how the discussion goes.

#288 (ping @williamboman so he gets notification in case yes) ?

#325 would be good to get in, because it's a big problem for people with dark themes. If we got that in, I would probably be happy with that being enough to push it to major release.
Especially as we generally seem happy with it, but yeah, let's have discussion on the actual topic.

By the way, if we are planning on organising releases proper like this rather than just whenever we feel like it, we should probably use the milestones on github. They work really nicely for dealing with that.

Closing this now that we have a proper milestone.


URL is not being played with HTTP header = "Authorization": "Bearer xxxxxx" in iOS

Version of react-native-audio-recorder-player
3.5.3
Version of React Native
0.70.6
Platforms you faced the error (IOS or Android or both?)
iOS
Expected behavior
The player should play URL with HTTP header = "Authorization": "Bearer xxxxxx". Works perfectly in android.
Actual behavior
There are no crashes or warnings. audioRecorderPlayer.startPlayer() returns the same URL as provided but addPlayBackListener is not called and the file is not being played.
Steps to reproduce the behavior
const currentPath = 'https://example.com/file/get?name=728bf7d0-af54-4c0f-b251-65e1cd057ecf.m4a';
const authorizationToken = 'xxx';
const startValue = await audioRecorderPlayer.startPlayer(currentPath, {
        Authorization: `Bearer ${authorizationToken}`,
    });
console.log('audioRecorderPlayer.startPlayer',  startValue);
    audioRecorderPlayer.addPlayBackListener(async e => {
        console.log('playback listener', e);
});

It seems the issue is not with this library but with our server.


Address JSON view for member map

indexes member address information in Solr
new JSON view to return map and member data with the same filters used on the members list view

@thatbudakguy codefactor is helpfully flagging a couple of todos I left in the code — I think they depend on what we decide we need from this view, so I probably need input from you to resolve.
IDK how we want to handle merging this one — do we merge into develop when you're happy with it even though it's not really functional on its own?

Codecov Report

Merging #643 into develop will increase coverage by 0.00%.
The diff coverage is 99.07%.

@@            Coverage Diff            @@
##           develop     #643    +/-   ##
=========================================
  Coverage    98.08%   98.09%
=========================================
  Files          218      219     +1
  Lines        11568    11671   +103
  Branches        63       63
=========================================
+ Hits         11347    11449   +102
- Misses         221      222     +1


HTTP body compression for gRPC requests

Does Envoy support HTTP body compression for gRPC requests?
The gzip filter works well for REST requests, but doesn't seem to work for gRPC requests, even when following the filter documentation.

I don't see why it wouldn't work, but I'm not sure. Maybe it has to do with content-type or encoding headers. cc @lizan @gsagula

gRPC compression is different from HTTP body compression on wire, it is per message compression, a compression-flag has to be encoded in to gRPC frame header. I don't think it is implemented in gzip filter. See https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md for details.

Thank you @mattklein123 and @lizan! I guess the gzip filter would also have to follow these guidelines to compress data. Would you consider gRPC compression as a feature improvement?

@jmjolysc yup switched over to enhancement.

@gsagula do you want to take this on?

@jmarantz I would love too, this seems relevant to the stuff that I've been doing. I just need to get some other compression and ext_authz things out of my way. I guess this could be included in the compression filter that I've been working on but in a separated PR of course.

So I was also needing this and going back to the OP, I think the problem w/ the gzip filter isn't that it lacks gRPC support, but rather that it lacks HTTP2 support.   The suspicion that @mattklein123 had about it being related to length or encoding headers looks spot on.  The gzip filter won't compress responses that don't have a content-length header,   and content-length and transfer-encoding: chunked headers are both no longer necessary in HTTP2.
I think it'd be ideal to initially just get HTTP2 compression working rather than try to get gRPC's custom compression protocol supported.  HTTP2 compression would be more broadly useful, yet would still cover gRPC, plus it's simpler and more hardened than gRPC's custom compression protocol.  As a datapoint, grpc-java still has its compression APIs as experimental due to some unresolved complexities and I've rarely seen it used.  So ideally Envoy would just take care of all our H1 and H2 compression the same way w/o bringing gRPC's compression scheme into the fold.

I think it's reasonable to detect that the connection is h2 and do compression even with the absence of the transfer-encoding: chunked header.


Uncaught TypeError: Cannot read property 'setScrollTop' of null

[Enter steps to reproduce below:]

...
...

2. ...

**Atom Version**: 1.12.6
**Electron Version**: 1.3.9
**System**: Mac OS X 10.11.3
**Thrown From**: [atom-beautify](https://github.com/Glavin001/atom-beautify) package, v0.29.13

### Stack Trace

Uncaught TypeError: Cannot read property 'setScrollTop' of null

At /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:318
TypeError: Cannot read property 'setScrollTop' of null
at atom-text-editor.TextEditorElement.setScrollTop (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:318:28)
at setScrollTop (/Users/daz/.atom/packages/atom-beautify/src/beautify.coffee:35:9)
at /Users/daz/.atom/packages/atom-beautify/src/beautify.coffee:131:13

### Commands

 -3:25 core:move-right (atom-text-editor.editor.is-focused)
 -3:23.1.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
 -3:20.6.0 core:select-all (atom-text-editor.editor.is-focused)
 -3:19.6.0 core:copy (atom-text-editor.editor.is-focused)
 -2:39.5.0 core:cut (atom-text-editor.editor.is-focused)
 -2:38.4.0 core:backspace (atom-text-editor.editor.is-focused)
 -2:36.8.0 core:move-down (atom-text-editor.editor.is-focused)
 -2:36.6.0 editor:newline (atom-text-editor.editor.is-focused)
 -2:35.7.0 core:paste (atom-text-editor.editor.is-focused)
 -2:34.3.0 core:save (atom-text-editor.editor.is-focused)
 -2:33 core:select-all (atom-text-editor.editor.is-focused)
 -2:32.6.0 core:copy (atom-text-editor.editor.is-focused)

8x -1:27.1.0 core:backspace (atom-text-editor.editor.is-focused)
-1:04.6.0 core:save (atom-text-editor.editor.is-focused)
-1:04.1.0 core:select-all (atom-text-editor.editor.is-focused)
-0:00.2.0 core:save (atom-text-editor.editor.is-focused)

### Config

```json
{
  "core": {
    "telemetryConsent": "no"
  },
  "atom-beautify": {
    "general": {
      "_analyticsUserId": "f2c99b15-7f53-46dc-a19c-e0021057dd67"
    },
    "html": {
      "beautify_on_save": true,
      "indent_inner_html": true,
      "indent_size": 2,
      "wrap_line_length": 0
    }
  }
}

Installed Packages
# User
atom-beautify, v0.29.13 (active)
atom-spotify2, v2.1.2 (active)
autoclose-html, v0.23.0 (active)
file-icons, v1.7.19 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (active)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (active)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages

Really annoying, that's why I used this quick fix:
change view?.setScrollTop value to view?.setScrollTop? value in ~/.atom/packages/atom-beautify/src/beautify.coffee.

Additional information from #1475 - http://stackoverflow.com/questions/41351215/atom-editor-atom-beautify-plugin-error-uncaught-typeerror-cannot-read-propert


Remove modernizePetshop.  liftAndShiftPetShop is the good code we wan…

…t to keep.

Somehow, we merged in two copies of the same code.  One was properly formatted.  The other wasn't.


..

Excuse me, what?

sorry i have just make an operational mistake when playing around with github. please delete this


Audio delay when using borderless option

It took me days to fin dout why my audio in cutscenes was getting progressively more desynced the longer it went on. I finally figured out its because if you use the borderless option in the HD fix then it causes this problem. Hope youre able to find a simple fix.

Is this still an issue with the latest version of MGSHDFix (v2)?


No IPv6 link-local address found

Hello Everyone,
I get the error

FATAL [main] MiscUtils: No IPv6 link-local address found on the network interface 'Software Loopback Interface 1' configured in the properties file

As I am on a windows machine, I have entered the command "route print", but none of the numbers in the interface list work for me. No matter which number (1, 5, 7, 13, 17, 19, 21) I choose, everytime the error above appeares. The interface list looks as followed:

===========================================================================
Schnittstellenliste
7...e8 d8 d1 aa 3c bb ......Intel(R) Ethernet Connection (6) I219-LM
17...4c 1d 96 1c 41 1c ......Microsoft Wi-Fi Direct Virtual Adapter
13...4e 1d 96 1c 41 1b ......Microsoft Wi-Fi Direct Virtual Adapter #2
21...4c e1 73 47 9e 43 ......Realtek USB GbE Family Controller
19...4c 1d 96 1c 41 1b ......Intel(R) Wi-Fi 6 AX200 160MHz
5...4c 1d 96 1c 41 1f ........Bluetooth Device (Personal Area Network)
1...............................................Software Loopback Interface 1
===========================================================================

Does anybody have an idea how I can solve this issue? Thank you very much in advance!
Greetings, Benedikt

On my Mac it is running fine, but I have to get it to run on windows. So I think, the configuration of the project itself is correct, but for windows, some options of the network adapter have to be changed.

Solved it! See: https://docs.microsoft.com/en-US/troubleshoot/windows-server/networking/configure-ipv6-in-windows  This value was set to 0xFF and I had to change it to 0x00

Same issue....following the windows instructions doesn't fix it.


Content-Length added to HTTP 304 and 204 responses not compliant with RFC7230

RFC7230 section 3.3.2 says:

A server MAY send a Content-Length header field in a 304 (Not Modified) response to a conditional GET request (Section 4.1 of [RFC7232]); a server MUST NOT send Content-Length in such a response unless its field-value equals the decimal number of octets that would have been sent in the payload body of a 200 (OK) response to the same request.

ie: HTTP 304 responses (which must not contain a body) can either set a Content-Length of what the body would have been, or must not set it at all.
Currently if an app:

asks cowboy to respond with a 304
doesn't pass an explicit Content-Length (which is allowed - and in fact RFC7232 section 4.1 suggests that it's best to omit the header entirely for 304s, to reduce transfer size)
and (correctly) doesn't pass a body to cowboy (since HTTP 304s shouldn't have a body)

...then cowboy adds Content-Length: 0 to the response, which is in violation of the spec.
In this case cowboy has no way of knowing what the original body size was (since the app truncated it already and didn't calculate/set a Content-Length before doing so), so Cowboy should not be adding a Content-Length itself.
STR:

Clone this repo and checkout revision c2beff7
Install erlang 18.3
cd examples/hello_world/
Modify toppage_handler.erl to match the below
make run
In another terminal, curl -i localhost:8080

Expected:
HTTP/1.1 304 Not Modified
date: Wed, 12 Apr 2017 21:05:03 GMT
server: Cowboy

Actual:
HTTP/1.1 304 Not Modified
content-length: 0
date: Wed, 12 Apr 2017 21:05:03 GMT
server: Cowboy

toppage_handler.erl:
-module(toppage_handler).

-export([init/2]).

init(Req0, Opts) ->
	Req = cowboy_req:reply(304, Req0),
	{ok, Req, Opts}.

Similarly for HTTP 204s, cowboy adds a Content-Type: 0 when RFC7230 section 3.3.2 says one should never be set at all:

A server MUST NOT send a Content-Length header field in any response with a status code of 1xx (Informational) or 204 (No Content).  A server MUST NOT send a Content-Length header field in any 2xx (Successful) response to a CONNECT request (Section 4.3.6 of [RFC7231]).

STR is the the same as the HTTP 304 STR above, but toppage_handler.erl should be:
-module(toppage_handler).

-export([init/2]).

init(Req0, Opts) ->
	Req = cowboy_req:reply(204, Req0),
	{ok, Req, Opts}.

Expected:
HTTP/1.1 204 No Content
date: Thu, 13 Apr 2017 15:17:43 GMT
server: Cowboy

Actual:
HTTP/1.1 204 No Content
content-length: 0
date: Thu, 13 Apr 2017 15:17:43 GMT
server: Cowboy

Yes it seems to be missing some cases when replying, thanks. Patch welcome.

This has been fixed for 204. The problem still exists for 304. I will get on to rfc7232 soon.

Many thanks :-)

(For posterity) Fixed by:
https://github.com/ninenines/cowboy/commit/b0519af42a4d3ee7e345967206bd1d0050e9061b
https://github.com/ninenines/cowboy/commit/292039362a6125dfd0a163d5b0a49b800bf80b11


added missing 'end block mark' which made broken block

Proposed changes
There is missing end block mark (```) for one of code blocks in page and it make broken page of reference manual for scp subcommand of docker-machine.

Thanks for keeping our docs easy to read!

Thanks, Because I need to read it better, :-)


Make Delayed::Worker.new idempotent

Calling Delayed::Worker.new multiple times would continue to re-add the plugins to the lifecycle.
Some gems and projects use the pattern Delayed::Worker.new.work_off to trigger delayed jobs in specs. Over time, as each call to .new added more callbacks to the chain, the callback chain would get very long and, in our case, caused a StackLevelTooDeep error.
Better would be to have a proper singleton:
Delayed::Worker.worker.work_off

In the absence of a proper singleton, this PR will make the pattern work: the lifecycle is re-initialized from the plugins list on instantiation.
For the enqueue action, which can accept callbacks but may happen in an application context where no worker has been instantiated, the lifecycle is lazily initialized from the plugins.

Many examples of this pattern in test suites: https://github.com/search?utf8=✓&q=Delayed%3A%3AJob.new.work_off&type=Code&ref=searchresults

Coverage increased (+0.06%) to 89.64% when pulling bdbbf60744665f5bb1d83bf28605fde9fee0d010 on idempotent_instantiation into 1f881569603e45b93b8b1f21ecfa85379645fe3c on master.

Coverage increased (+0.06%) to 89.64% when pulling f57d0aa106759510fd811879fb2de13bcdabf875 on idempotent_instantiation into 1f881569603e45b93b8b1f21ecfa85379645fe3c on master.

Coverage increased (+0.06%) to 89.64% when pulling f57d0aa106759510fd811879fb2de13bcdabf875 on idempotent_instantiation into 1f881569603e45b93b8b1f21ecfa85379645fe3c on master.


[ci skip] fix template syntax error

as title.

:+1: thank you!
Just FYI, there are tests that run against the README (so you can leave out [ci skip]). I ran the tests all locally against this ref to ensure that they were green.


BUG: better error handling for differing index names when running merge

Bug Description
When running merge on two different metadata files with different index names (i.e. sample-id and ID), the following error message is produced:

This provides little to no clarification regarding the issue being different index names (vs. the index name being set to None).
Steps to reproduce the behavior

Go to the Moving Pictures tutorial and download sample-metadata.tsv

Duplicate the sample-metadata.tsv file and save it as two different files (e.g. sample-md1.tsv & sample-md2.tsv)

Within one of the duplicated files, modify the index name (e.g. ID)

Run the following command:

qiime metadata merge \
--m-metadata1-file sample-md1.tsv \
--m-metadata2-file sample-md2.tsv \
--o-merged-metadata merged-md.qza \
--verbose

This will produce the error in the screenshot above.
Expected behavior
A new error should be raised that will check for matching index names within the two metadata files, so that the error above is handled with a message that is more informative to the user. Additionally, the help text for this method should include one or two sentences regarding index names needing to match.

Last one for now @hagenjp - these should all keep you busy for a while 🙂


Mario gif is not being installed when BPA is installed

This is a BP bug because it causes my bp integration tests to fail.
The log shows the issue - python setup.py install in BPA doesn't install any of the files from the graphics directory.
setup-error.txt

Now, this is weird - I didn't feel like I refreshed BPA at all, just did a clean install at a certain point into a new virtualenv.
Could my environment have changed?  I rebooted today for the first time in months, but I didn't feel like I changed anything!
Ongoing...

(I hand-installed this file so I can continue with my other branches fine...)

This is actually a known issue with BPA. I need to tweak the default paths
in ImageAnim
On Thu, Sep 28, 2017 at 7:32 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

(I hand-installed this file so I can continue with my other branches
fine...)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/441#issuecomment-332809275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6hyzBpRl8ttLotyhfxrrBaGFuu_wks5sm4PMgaJpZM4PnHgk
.

It does work if BPA is installed wtih "stetup.py develop"
On Thu, Sep 28, 2017 at 7:33 AM, Adam Haile<EMAIL_ADDRESS>wrote:

This is actually a known issue with BPA. I need to tweak the default paths
in ImageAnim
On Thu, Sep 28, 2017 at 7:32 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

(I hand-installed this file so I can continue with my other branches
fine...)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/441#issuecomment-332809275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6hyzBpRl8ttLotyhfxrrBaGFuu_wks5sm4PMgaJpZM4PnHgk
.

RIGHT!
That's the difference!  I did setup.py develop before!!

:) Log it with BPA if you'd like. I'll fix it.
On Thu, Sep 28, 2017 at 7:53 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

Closed #441 https://github.com/ManiacalLabs/BiblioPixel/issues/441.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/441#event-1269619513,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6uk631wxdk6TyZipLQr-QGDwESVJks5sm4jMgaJpZM4PnHgk
.


iOs banner makes the area behind untouchable if "No ad"

Describe the bug
In Russia Google does not load ad, but in different russian speaken countries ad is loaded correctly. In Russia because of Google send "No ad" response the area behind banner become untouchable. It means that banner height is not set and area uses for app logic. For example, at the bottom of the screen there is a "Settings" button that cannot be clicked due to a strange bug. From time to time.
Perhaps Google send some response and after that admob plugin logic set height is 0 but is starting to prepare area for ad that will never be loaded.
To Reproduce
Steps to reproduce the behavior:

Use VPN to Russia
Open app with banner
Find a button at bottom of screen
Check that it's not clickable (try to close app if it works and open again, try to use another app functions - bug appears suddenly)

Expected behavior
Area should be clickable
Additional context
Plugin version 4.1.0 ios

Same with version Google-Mobile-Ads-SDK 10.1.0 and 9.7.0


[nrf52840] prevent linker from dicarding strong nrf5CryptoInit implementation

Fixes #2896
Linker will discard libmbedcrypto_a-cc310_mbedtls.o when searching mbedTLS library, if it finds weak implementation of nrf5CryptoInit/Deinit before strong ones. Adding additional symbols to this file will prevent this behavior and make linker search libmbedcrypto_a-cc310_mbedtls.o even after weak implementations are found.
Signed-off-by: Robert Lubos<EMAIL_ADDRESS>

@chshu I'd appreciate if you could give it a try.


3rd party endpoint token local storage

In order to support private 3rd party models, users will need to pass API tokens alongside requests to Marqo. Users will pass the model’s name and API token (from cURL or py-marqo) which will be used for inferences. The py-marqo client will have the ability to save the model credentials somewhere locally as key-value pairs (which are overwritten by env vars).
In order to provide a user-friendly experience, py-marqo needs a feature to optionally store API keys and retrieve the appropriate ones for requests.
The usage could be something like this:
marqo.add_model_creds(('my-custom-model', 'my-secret-token'))
Which stores it in ~/.marqo/credentials

On indexes and searches the pattern could be this:
mq.index("my-ix").add_documents(
    [{"Title": "Where the wild things are"}],
    models_tokens=["my-custom-model"]
)


Correction for raw affiliation s:18:"Western University"

Correction needed for raw affiliation s:18:"Western University"
raw_affiliation_name: s:18:"Western University"
new_rors: 02grkyz14
previous_rors: 05cgtjz78
works_examples: W4389095781;W4382584538
contact: 3aac65539aac8b4f0525c4cb73dfe312:ff243096e75b6d36 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


no % for artefact

i have use scanner 1600x900 w/ 50 ms speed ,
scanner have 41 fail/621
all def% , atk % and hp%  main change to def,hp and atk w/ out %

work well when  screen is 1280x720

Are you saying the main stat for artifacts were listed as their flat variants? This is not possible because we force DEF/ATK/HP to become the % variants when it comes to the main stat for an artifact.

i have the same error here.
all "def_" artifacts are being written "def" instead.
take for instance this:
{"format":"GOOD","version":1,"kamera_version":"1.2.3","source":"Inventory_Kamera","artifacts":[{
"setKey": "GladiatorsFinale",
"slotKey": "sands",
"rarity": 5,
"mainStatKey": "def",
"level": 20,
"substats": [
{
"key": "critRate_",
"value": 9.7
},
{
"key": "enerRech_",
"value": 6.5
},
{
"key": "atk_",
"value": 15.2
},
{
"key": "hp_",
"value": 4.1
}
],
"location": "",
"lock": true,
"SubStatsCount": 4,
"Id": 91
}
]}

Please let us know if newer releases resolved this issue


Automatic Scaling for Disk Queue Length

What are the automatic action can be taken when disk queue length is high?
Looks auto scale out is to add instances, do it help disk I/O?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2550993f-34f1-d963-3ee5-3dcebe2a64d7
Version Independent ID: 3da9bc96-6e24-54fa-bd99-6a6a704f583a
Content: Monitor apps - Azure App Service
Content Source: articles/app-service/web-sites-monitor.md
Service: app-service
GitHub Login: @btardif
Microsoft Alias: byvinyal

Hello @RonnieQuan,
Thank you for your feedback! We will review and update as appropriate.

@RonnieQuan Thanks for asking question! Apologies for late response!  If I have understood right you want to know what automatic action would be taken if queue length grows. So, to elaborate on as mentioned in the document that A high disk queue length is an indication of an app that might be slowing down because of excessive disk I/O and Autoscaling could start additional instances of a service as the queue length grows. The Competing Consumers pattern describes how to handle this scenario.
You may refer to this article for more details on this:

Considerations for scaling threshold values for special metrics
How AutoScale rule works
Application design considerations

Let us know if you have query on this.

@RonnieQuan We will now proceed to close this thread. If there are further questions regarding this matter, please let us know.


always decycle objects before cloning

I guess it fixes  #862, #474 and #914

When is it gonna be merged?

previous PR about this problem hasn't been merged for 8 months. You can use @jifeon/winston#2.3.1, it contains only this commit on the top of winston#2.3.1

Thank you @jifeon! However, I couldn't seem to find the repos you mentioned. Could you please help?

@ngocketit  Repo is my fork: https://github.com/plyo/winston
It's published using npm namespace https://www.npmjs.com/package/@jifeon/winston
You can install it with
$ npm i --save @jifeon/winston

and use it like this:
import winston from '@jifeon/winston'

until this PR is merged. Then you can switch back to origin package.

I got error @jifeon/winston' is not in the npm registry but I could install it from your git repos. Thank you!

Any updates?

:+1:

Thank you for your contribution. Will try to get this out soon.

Will try to get this out soon.

So cool, it would be nice if you post npm version with the fix here

Hi,
as we discussed with @crabicode, seems to bring a regression about Error object.
Meta is {} when error is passed to the formatter func.
winston = require('winston')
logger = new (winston.Logger)({
    transports: [
        new (winston.transports.Console)({
            json: false,
            formatter: (...argv) => {
                console.log(argv);
                return 'baz';
            },
        }),
    ]
})

logger.info('foo', new Error('bar'))

I got on the console:
[ { colorize: false,
    json: false,
    level: 'info',
    message: 'foo',
    meta: {},
    stringify: undefined,
    timestamp: false,
    showLevel: true,
    prettyPrint: false,
    raw: false,
    label: null,
    logstash: false,
    depth: null,
    formatter: [Function: formatter],
    align: false,
    humanReadableUnhandledException: false } ]
baz

@indexzero, can we decide on further actions on merges, which brought that unwanted behaviour?

I'm trying to determine if this, or an alternative fix, ever got merged in and at which version?


Add Akeneo 6 support

Description
This Pull Request adds support for the newest Akeneo 6 version.
Related issue
Resolves #73
Resolves #74
How can this be tested?

Installation on an Akeneo v6 instance should work without issues.
Automatic tests should pass

Scrutinizer seems to use its own composer file. It can be handled with the Scrutinizer config: https://scrutinizer-ci.com/docs/tools/php/code-sniffer/


[sensor_ctrl] D3 Signoff

Description
No response

Analysis of changes since previous signoff
sensor_ctrl got previously signed off at D3 in 9f31bc3b2ea59614655532e00294248f7bbbb04a and that wasn't changed when the version was increased to 2.0.0 in d352f0cf45299ed1a9715ca72fce052be21cb00b. So technically, sensor_ctrl is currently still signed off at D3. For completeness' sake, however, here are the changes since the previous D3 signoff (git log --pretty=oneline 9f31bc3b2ea59614655532e00294248f7bbbb04a..HEAD hw/top_earlgrey/ip/sensor_ctrl/rtl | tac, thus old to new):

e063764dd06f0c61dad3f992cee794d13679c716 [tlul] Add access latency and ifetch to adapter_reg
0ba10b3cd3157d233c6a9a21676b058971399b99 [reggen] Add CIP_IDs and bump all major versions
fbd888eea85260f03095b7b7f12537638ca27183 Revert "[reggen] Add CIP_IDs and bump all major versions"
1b16ca2122d956f4b1f909ba2e996b01ff22001e [reggen] Add mubi support SWAccess that sets/clears a reg
de31bdf1c26be2714ca787c6041a56eb56eb7d1e [reggen] Remove the devmode input
eef87110bb60997becccdf1cec4ed736ea673b99 [rtl,sensor_ctrl] Fix CDC bug
61a237e1973d6a29d377c2be871139553c7d344f [util/reggen] reverse order of substruct generation
d352f0cf45299ed1a9715ca72fce052be21cb00b [sensor_ctrl] Add enable register for AST alerts
30d7e787c753caaa03fe68a4a70da1bbcbc1d96f Add the project name to the copyright header
8b15c287f8b8e5618681b4d9d1a28ea7d400ed72 [top_earlgrey,sensor_ctrl] Add input disable attribute for manual pads
4c15bdc9fa0d882c5d53068d9d86658c2a48ee07 [sensor_ctrl] Change reset value of ALERT_EN CSRs to MuBiTrue
39157f7a7ac94e42f05cde9daa8ae8cde9d900e1 [top_earlgrey,sensor_ctrl] Add pull attributes for manual pads


Cuda: Out of memory

After running the command:
python test.py --ckpt synthetic
I got the error (I am using GTX Titan X)
RuntimeError: CUDA out of memory. Tried to allocate 1.92 GiB (GPU 0; 11.92 GiB total capacity; 10.85 GiB already allocated; 56.62 MiB free; 128.66 MiB cached).
Could you check the issues?

It is because the size of input image is too big, you can add the '--cpu' option or slice the input image.
I think slice the images is better.


feat: update with official zh-TW translation

Main changes:

Updated all the language variables with the official translation
Few changes using regional nick names due to no official translation in Splatoon 3 (e.g. some words in Splatoon 1, 2)
Getting sentences correct in zh-TW which is much more readable.

Please let me know if there's anything wrong or buggy. I also found that there're so many duplicated words in those files. Maybe we could create a environment for the strings which could be used as a variable rather than writing them down every time.

Great job!
This is just a confirmation:
I don't know Chinese at all, in the Japanese sense, "所有" is "ownership" or "have".
Is "所有" a reasonable translation for "Any Something"?
For example, "Any Stage" means "do not filter by stage."

CI is failing, but don't worry about it.

I don't know Chinese at all, in the Japanese sense, "所有" is "ownership" or "have".

You are right. Chinese and Japanese are pretty likely the same.
"所有" does means "ownership" or "have" in some sentences, but also means "all" here, exactly like "全部", which is the same in Japanese.

Is "所有" a reasonable translation for "Any Something"?
For example, "Any Stage" means "do not filter by stage."

Does "Any Stage" mean "do not filter by stage" here? I am not sure where the variable is using, so I couldn't answer the question.
At first I would think "Any Stage/Weapon" as "All Stage/Weapon" in filter while I don't select any particular objects, so it sould be showing all at default.
Please let me know if I need to do some changes.

Messages like "Any Stage" or "Any Weapon" are used in such filters.
It does not matter if the expression is natural to Chinese speakers, as is the case with "すべての(All of)" in Japanese.

There should be more updates for Splatfest and Salmon Run Next Wave and I'll keep it up once it's merged to dev.
Some strings will also be improved in the following PR. Thanks for the checks!

wow!


First and Fourth argument of @each directive are a path

https://laravel.com/docs/9.x/blade#rendering-views-for-collections
@each('view.name', $jobs, 'job', 'view.empty')

Hi,
Thank you for you observation.
For the moment I've just added the autocomplete of the first blade path and the declaration finder.

We will keep the issue opened until a valid parser is added for this directive and the fourth parameter is seen as a view path.

Thanks 👍

Hi
Also @includeWhen, @includeUnless has path on second argument,
and @includeFirst has an array of paths on first
@includeWhen($boolean, 'view.name', ['status' => 'complete'])

@includeUnless($boolean, 'view.name', ['status' => 'complete'])

@includeFirst(['custom.admin', 'admin'], ['status' => 'complete'])

Thanks


Dynamic Prompt

We currently store a pre-formatted string to be used as the prompt. This is great because it's never slow, but horrible because it can't change as the shell lives. We need to support both run-time updating prompts (this issue), and configurable prompts eventually.
For now I'd be happy if updating your hostname updates a prompt like short_style without restarting.

The prompt now reads from $PS1 before each line, in #51.


Can't login to keybase

I can't seem to login to keybase using the cli or the application.
When I login with the app, I type in my username and passphrase, but then it removes my avatar on the screen and hangs. When I type in keybase login in the shell, it'll eventually just time out.
my log id: b38349dfa063b7fcaf82631c

It looks like there a passphrase prompt window showing somewhere (perhaps occluded by another window) that is blocking further requests.
If you quit keybase via menubar app and start it again, it should be ok.  Or find the passphrase prompt window.

@patrickxb I tried uninstalling, reinstalling and only doing it from the command line to no avail. I think something was corrupted. I ended up just resetting my account and starting from scratch. That seems to have resolved the issues. Thanks!


Now you can download any playlist without interrupts.


Center block-grid elements on smaller widths

By default, the block-grids are not centered when the viewport is skinnier:

You can fix this by adding a text-align:center to the parent tr like so:

Then it will look like this:

I think this is likely the more desired effect for mobile when working with block-grid and may be worth considering adding it to ink's default styles.

Thank you!  This helped me.  I do want them centered

It looks like this is pretty easy to achieve with one css rule. By default we still want block-grid elements to float left to maintain consistency with f4s. Let us know if there's a better way we can improve this!


Localstorage on many servers instances

Hello, first, congratulations for this module, awesome!
I would like to know how its work for an app with multiple instances, like on AWS with a load balancer and Auto scaling system...
It will preserve the localstorage for all instances, example, if a save some users information on localstorage, its will be shared between others instances OR the instances have your own localstorage ?

Stating the obvious, but please be aware that the lib is not built for multi-concurrency or distributed scenarios. It just isn't supposed to go there. That being said, I would say that keep LocalStorage per instance of your AWS container is fine.
For what it's worth, in the latest v2.1.0 release I've started working on the 'read-only' mode. This is still a work in progress, but theoretically you can refer to the same localstorage file as much as you want. I can't stress enough that this is very much a work in progress, though. ;)
Hope that helped a bit.


Creating custom url for user

Functionality:
Added username to profile and access with link
Solution:
Added username as.  new field in user profile.
And added check operation before they can update it.
Risk level:

[x] high
[ ] medium
[ ] low

How to test:
Check in edit user or in link of user profile.

The create user API is also not working

The look of the check availability button could be improved and it should be clickable if clicked and then username change
Or
The function to check for username could be done automatically when user types something using the onchange function.


Access the values of the population with best fitness function

Apart from obtaining the best fitness score, is it possible to access the values that correspond to the best score?

@Namyalg it is accessed on the attribute best_individual_.


task result

Hello Chris,
I just finished your task. Here is link to GitHub https://github.com/hrnciar/redhat-js and link to Firebase https://redhat-js-58d31.firebaseapp.com. Most of time I spent with trying to do bonus challenge. I was able to save and load state to Firebase but not both at the same time.
Tomas

Hrmmm... im on a busted mobile now, and so maybe its me missing something
... But I don't see any alert when I click the button on the live, hosted
site. Did you test on any mobile devices (smaller screens) too? I didn't
find the code for this in the app sources master branch either. Take
another couple days. Let me know if you got any farther, by Wednesday end
of day.
-Chris
On Dec 4, 2017 9:24 AM, "Tomáš Hrnčiar"<EMAIL_ADDRESS>wrote:

Hello Chris,
I just finished your task. Here is link to GitHub
https://github.com/hrnciar/redhat-js and link to Firebase
https://redhat-js-58d31.firebaseapp.com. Most of time I spent with trying
to do bonus challenge. I was able to save and load state to Firebase but
not both at the same time.
Tomas
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kejbaly2/redhat_interns_rock/issues/2, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADlvfIuv7NwPx11RCZoIh8UbBjdF8woAks5s86wigaJpZM4Q0RrO
.

Oh, I am sorry, I tried something with loading state from Firebase and forget to put it back. It should be fine now, I uploaded back version from Github. You can find source code in index.html file.
Tomas

On 4 Dec 2017, at 16:58, Chris Ward<EMAIL_ADDRESS>wrote:
Hrmmm... im on a busted mobile now, and so maybe its me missing something
... But I don't see any alert when I click the button on the live, hosted
site. Did you test on any mobile devices (smaller screens) too? I didn't
find the code for this in the app sources master branch either. Take
another couple days. Let me know if you got any farther, by Wednesday end
of day.
-Chris
On Dec 4, 2017 9:24 AM, "Tomáš Hrnčiar"<EMAIL_ADDRESS>wrote:

Hello Chris,
I just finished your task. Here is link to GitHub
https://github.com/hrnciar/redhat-js and link to Firebase
https://redhat-js-58d31.firebaseapp.com. Most of time I spent with trying
to do bonus challenge. I was able to save and load state to Firebase but
not both at the same time.
Tomas
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kejbaly2/redhat_interns_rock/issues/2, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADlvfIuv7NwPx11RCZoIh8UbBjdF8woAks5s86wigaJpZM4Q0RrO
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/kejbaly2/redhat_interns_rock/issues/2#issuecomment-349006237, or mute the thread https://github.com/notifications/unsubscribe-auth/AMetiFr3DSl8w7-G_i16gU0P8PNHBUXtks5s9Ba5gaJpZM4Q0RrO.

Try moving the code to .Vue component instead of using CDN in index.html.
I'd like to see how far you get with the button state bonus stuff still.
Wednesday. Let me know. :)
-Chris
On Dec 4, 2017 5:06 PM, "Tomáš Hrnčiar"<EMAIL_ADDRESS>wrote:
Oh, I am sorry, I tried something with loading state from Firebase and
forget to put it back. It should be fine now, I uploaded back version from
Github. You can find source code in index.html file.
Tomas

On 4 Dec 2017, at 16:58, Chris Ward<EMAIL_ADDRESS>wrote:
Hrmmm... im on a busted mobile now, and so maybe its me missing something
... But I don't see any alert when I click the button on the live, hosted
site. Did you test on any mobile devices (smaller screens) too? I didn't
find the code for this in the app sources master branch either. Take
another couple days. Let me know if you got any farther, by Wednesday end
of day.
-Chris
On Dec 4, 2017 9:24 AM, "Tomáš Hrnčiar"<EMAIL_ADDRESS>wrote:

Hello Chris,
I just finished your task. Here is link to GitHub
https://github.com/hrnciar/redhat-js and link to Firebase
https://redhat-js-58d31.firebaseapp.com. Most of time I spent with
trying
to do bonus challenge. I was able to save and load state to Firebase but
not both at the same time.
Tomas
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kejbaly2/redhat_interns_rock/issues/2, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/
ADlvfIuv7NwPx11RCZoIh8UbBjdF8woAks5s86wigaJpZM4Q0RrO>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/kejbaly2/redhat_interns_rock/issues/2#
issuecomment-349006237>, or mute the thread <https://github.com/
notifications/unsubscribe-auth/AMetiFr3DSl8w7-G_
i16gU0P8PNHBUXtks5s9Ba5gaJpZM4Q0RrO>.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kejbaly2/redhat_interns_rock/issues/2#issuecomment-349008799,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADlvfOHif3_ym-h4QF8PsZjmW81fXbTiks5s9Bh6gaJpZM4Q0RrO
.

Hello Christ,
I just wanna let you know that on my GitHub is updated version of app. I got rid of CDN and changed app structure, but I wasn’t able to finish bonus task. I was struggling with connecting Firebase and my apps. I tried several thing by my own and then using onther addons like VueFire or Vuex.
Tomas

On 4 Dec 2017, at 18:13, Chris Ward<EMAIL_ADDRESS>wrote:
Try moving the code to .Vue component instead of using CDN in index.html.
I'd like to see how far you get with the button state bonus stuff still.
Wednesday. Let me know. :)
-Chris
On Dec 4, 2017 5:06 PM, "Tomáš Hrnčiar"<EMAIL_ADDRESS>wrote:
Oh, I am sorry, I tried something with loading state from Firebase and
forget to put it back. It should be fine now, I uploaded back version from
Github. You can find source code in index.html file.
Tomas

On 4 Dec 2017, at 16:58, Chris Ward<EMAIL_ADDRESS>wrote:
Hrmmm... im on a busted mobile now, and so maybe its me missing something
... But I don't see any alert when I click the button on the live, hosted
site. Did you test on any mobile devices (smaller screens) too? I didn't
find the code for this in the app sources master branch either. Take
another couple days. Let me know if you got any farther, by Wednesday end
of day.
-Chris
On Dec 4, 2017 9:24 AM, "Tomáš Hrnčiar"<EMAIL_ADDRESS>wrote:

Hello Chris,
I just finished your task. Here is link to GitHub
https://github.com/hrnciar/redhat-js and link to Firebase
https://redhat-js-58d31.firebaseapp.com. Most of time I spent with
trying
to do bonus challenge. I was able to save and load state to Firebase but
not both at the same time.
Tomas
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kejbaly2/redhat_interns_rock/issues/2, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/
ADlvfIuv7NwPx11RCZoIh8UbBjdF8woAks5s86wigaJpZM4Q0RrO>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/kejbaly2/redhat_interns_rock/issues/2#
issuecomment-349006237>, or mute the thread <https://github.com/
notifications/unsubscribe-auth/AMetiFr3DSl8w7-G_
i16gU0P8PNHBUXtks5s9Ba5gaJpZM4Q0RrO>.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kejbaly2/redhat_interns_rock/issues/2#issuecomment-349008799,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADlvfOHif3_ym-h4QF8PsZjmW81fXbTiks5s9Bh6gaJpZM4Q0RrO
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/kejbaly2/redhat_interns_rock/issues/2#issuecomment-349032157, or mute the thread https://github.com/notifications/unsubscribe-auth/AMetiPFUWqSb2vj2vL9Ix42tLhT9hSNyks5s9CgkgaJpZM4Q0RrO.


add a little spice to the CLI

add a 🤖 to the REPL prompt
rotating taglines
copy edits in usage page

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 52 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.1%) to 82.025%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/server/repl.ts
0
1
0.0%

src/server/taglines.ts
0
51
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
2474

Relevant Lines:
3092

💛  - Coveralls


Add Optional block, style advice blocks

This PR makes two changes to various question templates:
1. (optional) Optional blocks
Adds an (optional) Optional block to questions similar to what we see in the prototype.
This means we can stop using hint text to indicate questions are optional
2. styles for .question-advice and .hint classes
Adds a bunch of CSS to .question-advice and .hint classes, almost entirely cribbed from the buyer app's .section-description class which is used on section summary pages.
Once this gets merged, we can remove the duplicated stuff from the buyer app.
What this pull request is not doing:
1. fixing the duplicated questions
At the moment, the question itself appears duplicated on the edit question page (here's a screenshot). We need to pass the question into the macros because they become the <label> for the form fields, but the question is also used as a page heading for individual question pages.  Currently, we need to do both.
2. moving hint text
In the prototype, hint text has been moved underneath form fields.  I haven't touched it.
3. lead-in values for list questions
In the prototype, list questions have a short phrase as a heading (ie, "The supplier must:").  Doesn't look immensely difficult to add in, but I didn't do it.

optional question with tons of question advice, a hint, and an error

LGTM 👍


removing previous searched items after next search

Describe the bug
When something is searched in the image generator we get the results. After that when we search again the previous results are displayed the same way. Edit the program JS such that the previous results get removed as soon as the new results are fetched
To Reproduce
Steps to reproduce the behavior:

Go to 'js.js'
See error

Expected behavior
previous search get removed as son as next searched results are fetched

w3rt


sync content --stories api update

sb-mig sync content function will look like that, and will provide already working migrations of ALL stories from space to space, but will also support migrating from file to space, and from file to file. As a follow up to this ticket, will also implement migration only specific stories, but probably that will be done in GUI and at the end of the year.
From space to space - OAuthToken user used for migration is required to be added to both spaces
sb-mig sync content --stories --from 123456789 --to 123456789
sb-mig sync content --stories --from 123456789

From file to space  - OAuthToken user used for migration is required to be added to only his own space
sb-mig sync content --stories --from seed.stories --to 123456789
sb-mig sync content --stories --from seed.stories

From space to file - OAuthToken user used for migration is required to be added to seed space
sb-mig sync content --stories --from 123456789 --to seed.stories

PR that fixes this issue: https://github.com/sb-mig/sb-mig/pull/223

fixed by: https://github.com/sb-mig/sb-mig/issues/222

Final api:
sb-mig sync content --stories --from 12345 --to 6789

sb-mig sync content --stories --from 12345 --to some-file

sb-mig sync content --stirues --from some-file --to 6789