BUG OSS-Fuzz does not detect multiple repos fuzzed under a project

Describe the bug
https://github.com/argoproj currently uses oss-fuzz to perform fuzzing on the four repositories listed below:

https://github.com/argoproj/argo-workflows
https://github.com/argoproj/argo-cd
https://github.com/argoproj/argo-events
https://github.com/argoproj/argo-rollouts

I see that #2719 was recently merged and parses the results of https://oss-fuzz-build-logs.storage.googleapis.com/status.json.  I'm not sure if this fix would cover our case.  I do see the main project being detected in the build results, but not each repo as listed above.
Expected behavior
Fuzzing check to detect the repos that we have enabled for fuzzing.
Additional context
I appreciate all the hard work that has gone into this project.  Keep up the great work.

The project clones multiple sub project in a single docker file https://github.com/google/oss-fuzz/blob/master/projects/argo/Dockerfile

#2719 won't handle this as written. Since the main repo url is "github.com/argoproj", none of the sub projects would work.
It would be easy to convert extend the logic to fall back to searching the org:  e.g.github.com/argoproj/argo-cd -> github.com/argoproj. This would result in quite a few false positives though.

@spencerschrock I agree extending the logic would not be the best solution, as you stated this would create many false positives.
Do you have any other solutions or suggestions?  I'd really like to avoid refactoring the fuzzing checks we already have in place.

Hmm, the vast majority of main_repo fields from project.yaml files refer to a single repo. Only 6 oss-fuzz projects that point to a GitHub repo point to an org (~0.6%):
argoproj
dapr
knative
notaryproject
QubesOS
unicode-rs

We support looking for a .onefuzz file to detect microsoft OneFuzz, so I could see a similar .ossfuzz file as a possibility or even just a general .fuzzing file as a catch-all with a user filled explanation. Would be curious what other @ossf/scorecard-maintainers thoughts are.

Thank you all for looking into this, any updates would be appreciated.

Thank you all for looking into this, any updates would be appreciated.

Not much feedback on the issue from other Scorecard maintainers, but I can say we're planning maintainer annotations that would help address add context to situations like this. The design hasn't started, but its on our roadmap.


Hostport str/bytes conversion

Hostport is a string- splitting it with a bytes-encoded character results in a TypeError.

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   53.06%   53.06%
=======================================
  Files         343      343
  Lines       25778    25778
  Branches     3345     3345
=======================================
  Hits        13680    13680
  Misses      11402    11402
  Partials      696      696

Impacted Files
Coverage Δ

lib/python/treadmill/cli/admin/ssh.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db0634...ceeabe3. Read the comment docs.


fix(animations) animations should reset when unmounted

Animations in react apps weren't resetting because they were constructed outside of the component.
Before
The red "Hello World" animation isn't reset between page navigations.
https://user-images.githubusercontent.com/2461547/138531452-2810dd27-6f9b-4569-a064-4718bfaf0987.mov
After
https://user-images.githubusercontent.com/2461547/138531471-5be8424b-a9e0-4eff-bf05-7a690af294e1.mov

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 26.037%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

modules/core/src/animations/animation-manager.js
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
231

Relevant Lines:
773

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 26.037%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

modules/core/src/animations/animation-manager.js
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
231

Relevant Lines:
773

💛  - Coveralls


Add authentication [moved]

This is Issue 73 moved from a Google Code project.
Added by 2010-06-28T14:11:12.000Z by<EMAIL_ADDRESS>Please review that bug for more context and additional comments, but update this bug.
Closed (Fixed).
Original labels: Type-Enhancement, Priority-Low, Milestone-Release0.94
Original description
Add authentication to DataStoreImpl

maybe you could use the following code:
    Morphia morphia = new Morphia();
    ServerAddress addr = new ServerAddress("host", 27017);
    List<MongoCredential> credentialsList = new ArrayList<MongoCredential>();
    MongoCredential credentia = MongoCredential.createCredential(
        "username", "dbname", "password".toCharArray());
    credentialsList.add(credentia);
    MongoClient client = new MongoClient(addr, credentialsList);
    datastore = morphia.createDatastore(client, "dbname");


parsl provider error messages are lost

Describe the bug
This is based on a report in the #help slack channel
When the slurm provider fails to scale out, the code that is supposed to report that to the user fails in potentially several ways:

This seems to be static type error in the exception handling code for scale_out failing, when constructing a more specific exception - interchange indeed has no config.

Submission of command to scale_out failed
2022-01-27 14:33:58.605 funcx_endpoint.strategies.simple:43 [ERROR] Caught error in strategize : 'Interchange' object has no attribute 'config'
Traceback (most recent call last):
  File "/work2/04372/ejonas/anaconda/envs/s2s/lib/python3.9/site-packages/funcx_endpoint/strategies/simple.py", line 41, in strategize
    self._strategize(*args, **kwargs)
  File "/work2/04372/ejonas/anaconda/envs/s2s/lib/python3.9/site-packages/funcx_endpoint/strategies/simple.py", line 143, in _strategize
    self.interchange.scale_out(excess_blocks)
  File "/work2/04372/ejonas/anaconda/envs/s2s/lib/python3.9/site-packages/funcx_endpoint/executors/high_throughput/interchange.py", line 1151, in scale_out
    self.config.provider.label,
AttributeError: 'Interchange' object has no attribute 'config'

The parsl layer logs an error to eg parsl.providers.slurm but the endpoint admin was unable to find the relevant log message - maybe it should appear around the same place as the above report? The relevant parsl log line is:

            logger.error("Retcode:%s STDOUT:%s STDERR:%s", retcode, stdout.strip(), stderr.strip())

To Reproduce
Get endpoint to try to scale out with a broken provider/provider configuration
Expected behavior
The errors coming from parsl.providers should lead the user towards fixing the problem (in the example user's case, a quota exhaustion reported by sbatch) rather than being hidden
Environment
slurm
other component versions unknown

I've recreated this in my dev environment by replacing the submit call for my relevant local provider (kube.py) with return None, which emulates the slurm failure for the purposes of this buggy exception report - point 1 in the issue.
For point 2, I have discussed internally with @sirosen about logging parsl (and more) error messages to the endpoint logs.

The 2nd part of this might have been fixed by @rjmello 7b221920a9367b8629be4a454fb2ec81f2af2932

The 2nd part of this might have been fixed by @rjmello 7b22192

Correct; I'd expect the logs to show now.


fix(helm): Moved priority class declaration in the right position of dapr_placement_statefulset.yaml manifests

Description
Dapr, when deployed in HA mode with a priorityClassName defined as suggested in this doc, produce an invalid manifeset.
It add the priorityClassName inside the volumeClaimTemplates definition of dapr-placement-server StatefulSet.
Command used to produce the manifest
helm template .\dapr\ --set global.ha.enabled=true --set global.priorityClassName=system-cluster-critical > example-manifest-dapr.yaml

Produced volumeClaimTemplate of dapr-placement-server StatetfulSet:
  volumeClaimTemplates:
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      name: raft-log
    spec:
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 1Gi
      priorityClassName:
        system-cluster-critical

Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@elena-kolevska Is there anything else I can do on this pull request to make it merge?

I don't think so, we now have to wait for one of the maintainers to approve and merge.

@cicoyle  I think the errors in the actions are not related to my modification, right?


[SMALLFIX] Refactoring a test utility for waiting

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9416/
Test PASSed.

Merged build finished. Test PASSed.

Thanks for the improvement! overall LGTM, left a minor comment.
Can you also resolve the conflicts?

Thanks for the improvements @yupeng9 . I left a few comments, and could you resolve merge conflicts?

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9447/
Test PASSed.

I just had one extra question. Thanks!

Could you resolve conflicts? This looks good after that

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9491/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9492/
Test PASSed.


allow to edit languages that are not enabled in project settings

This will allow to edit languages that are not enabled in project settings but are in DB

Thanks, this is a good fix to have!


Color assigning for DB SelectOptions

I thoroughly enjoy using your client, it makes a lot of sense when you get the hang of it.
Unfortunately, I have been struggling with something that doesn't seem to stem from my code (feel free to contradict using the code provided below). When creating a new Page in a Database,  I add a few Select properties with SelectOptions while filling the Color and Name fields.
The API doesn't seem to receive the Color information though and the Options appear a different color every time in the Notion interface. This leads to the inability to add any more Pages due to the inconsistent colors.
I scoured the Notion API Interface and the docs of this API but I didn't seem to find any note about this.
In this specific example, City, Locality, Category, Opening Days, and Train Station are always random colors and I cannot seem to be able to set them.
package main

import (
	"context"
	"fmt"
	"html"

	"github.com/dstotijn/go-notion"
)

func CreateMuseumPage(mus Museum, db_id string, client notion.Client) (notion.Page, error) {
	specifics, err := ParseSpecifics(mus)
	city := ParseCity(mus.AddressLocality)
	categ := ParseCategory(mus.Themes)
	if err != nil {
		return notion.Page{}, err
	}
	params := notion.CreatePageParams{
		ParentType: "database_id",
		ParentID:   db_id,
		DatabasePageProperties: &notion.DatabasePageProperties{
			"Name": notion.DatabasePageProperty{
				Title: IntoRichTextArray(mus.Name),
			},
			"Description": notion.DatabasePageProperty{
				RichText: IntoRichTextArray(mus.ShortDescription),
			},
			"URL": notion.DatabasePageProperty{
				URL: &mus.DetailURL,
			},
			"Locality": notion.DatabasePageProperty{
				Select: &notion.SelectOptions{
					Name:  mus.AddressLocality,
					Color: city.Color(),
				},
			},
			"Category": notion.DatabasePageProperty{
				Select: &notion.SelectOptions{
					Name:  categ.String(),
					Color: notion.ColorOrange,
				},
			},
			"City": notion.DatabasePageProperty{
				Select: &notion.SelectOptions{
					Name:  city.String(),
					Color: city.Color(),
				},
			},
			"Closed": notion.DatabasePageProperty{
				Checkbox: &mus.TemporaryClosed,
			},
			"Openings": notion.DatabasePageProperty{
				RichText: IntoRichTextArray(specifics.opening),
			},
			"Phone": notion.DatabasePageProperty{
				PhoneNumber: &specifics.phone,
			},
			"Email": notion.DatabasePageProperty{
				Type:  notion.DBPropTypeEmail,
				Email: &specifics.email,
			},
			"Website": notion.DatabasePageProperty{
				Type: notion.DBPropTypeURL,
				URL:  &specifics.website,
			},
			"Train Station": notion.DatabasePageProperty{
				Select: &notion.SelectOptions{
					Name:  specifics.station,
					Color: city.Color(),
				},
			},
			"Opening Hours": notion.DatabasePageProperty{
				RichText: IntoRichTextArray(specifics.openingHours),
			},
			"Opening Days": notion.DatabasePageProperty{
				MultiSelect: CreateDayOptions(specifics.openingDays),
			},
		},
		Icon: &notion.Icon{
			Type:  notion.IconTypeEmoji,
			Emoji: categ.Emoji(),
		},
		Cover: &notion.Cover{
			Type: notion.FileTypeExternal,
			External: &notion.FileExternal{
				URL: mus.CoverPhoto.ResizableURL + "?max-h=600&max-w=1500",
			},
		},
	}
	fmt.Print("[NOTION] Creating page \"" + mus.Name + "\" in the Musea database...")
	page, err := client.CreatePage(context.Background(), params)
	if err != nil {
		return notion.Page{}, err
	}
	fmt.Println("Done")
	return page, nil
}

func CreateDayOptions(days []Day) []notion.SelectOptions {
	var select_options []notion.SelectOptions
	for _, day := range DaysToString(days) {
		select_options = append(select_options, notion.SelectOptions{
			Name:  day,
			Color: notion.ColorPurple,
		})
	}
	return select_options
}

func DaysToString(vs []Day) []string {
	vsm := make([]string, len(vs))
	for i, v := range vs {
		vsm[i] = v.LongString()
	}
	return vsm
}

func IntoRichText(base string) notion.RichText {
	t := &notion.Text{
		Content: html.UnescapeString(base),
	}
	rt := notion.RichText{
		Text: t,
	}
	return rt
}

func IntoRichTextArray(base string) []notion.RichText {
	return []notion.RichText{IntoRichText(base)}
}

type City int64

const (
	Brussels City = iota
	Gent
	Mechelen
	Antwerp
	NotImpl
)

func (me City) String() string {
	return []string{"Brussels", "Gent", "Mechelen", "Antwerp", ""}[me]
}

func (me City) Color() notion.Color {
	return []notion.Color{notion.ColorBlue, notion.ColorPurple, notion.ColorBrown, notion.ColorOrange}[me]
}

The resulting error doesn't really matter but I'll stick it in here in case you can learn more from it than I can :^)
[NOTION] Creating page "Musée Mode & Dentelle" in the Musea database...Done
[NOTION] Creating page "Musée de la Banque nationale de Belgique" in the Musea database...notion: failed to create page: Select option color doesn't match existing for 68ad963d-18a2-49b4-a6a9-96fe36552c33. Select option color doesn't match existing for b1f3eb78-f05c-493d-8843-2735ddd4300a. Select option color doesn't match existing for 385e8aaa-a523-4e99-9da9-7d2031ba6ab2. Select option color doesn't match existing for e6154c30-e6ac-4436-beb8-aa3c9acd0184. (code: validation_error, status: 400)

If you have any quick fixes for this, it would be absolutely amazing. Thank you in advance

After proxying the Request sent out by the client, it seems that the color is indeed included but the Notion API doesn't seem to care for it. Weird.
{
    "parent": {
        "database_id": "x"
    },
    "properties": {
        "Category": {
            "select": {
                "name": "Cultural",
                "color": "orange"
            }
        },
        "City": {
            "select": {
                "name": "Brussels",
                "color": "blue"
            }
        },
        "Closed": {
            "checkbox": false
        },
        "Description": {
            "rich_text": [
                {
                    "text": {
                        "content": "À travers des expositions thématiques annuelles, le Musée Mode & Dentelle présente des pièces significatives de l’histoire de la mode tout en mettant l’accent sur la création bruxelloise et belge."
                    }
                }
            ]
        },
        "Email": {
            "type": "email",
            "email"<EMAIL_ADDRESS>        },
        "Locality": {
            "select": {
                "name": "Bruxelles",
                "color": "blue"
            }
        },
        "Name": {
            "title": [
                {
                    "text": {
                        "content": "Musée Mode & Dentelle"
                    }
                }
            ]
        },
        "Opening Days": {
            "multi_select": [
                {
                    "name": "Mardi",
                    "color": "purple"
                },
                {
                    "name": "Mercredi",
                    "color": "purple"
                },
                {
                    "name": "Jeudi",
                    "color": "purple"
                },
                {
                    "name": "Vendredi",
                    "color": "purple"
                },
                {
                    "name": "Samedi",
                    "color": "purple"
                },
                {
                    "name": "Dimanche",
                    "color": "purple"
                }
            ]
        },
        "Opening Hours": {
            "rich_text": [
                {
                    "text": {
                        "content": "10:00-17:00"
                    }
                }
            ]
        },
        "Openings": {
            "rich_text": [
                {
                    "text": {
                        "content": "mar - dim: 10:00 - 17:00"
                    }
                }
            ]
        },
        "Phone": {
            "phone_number": "02 213 44 50"
        },
        "Train Station": {
            "select": {
                "name": "Bruxelles-Central",
                "color": "blue"
            }
        },
        "URL": {
            "url": "https://www.museumpassmusees.be/fr/offre/musee/959e91f7-94b9-4cb6-95f2-b814bbe57074/musee-mode-amp-dentelle"
        },
        "Website": {
            "type": "url",
            "url": "http://www.fashionandlacemuseum.brussels"
        }
    },
    "icon": {
        "type": "emoji",
        "emoji": "☸"
    },
    "cover": {
        "type": "external",
        "external": {
            "url": "https://media.museumpassmusees.be/d5baa098-aebb-414f-bd55-50358def63a8?max-h=600&max-w=1500"
        }
    }
}

I will take a look at reporting it to the Notion team but I'll leave the issue open in case you have any idea to fix this?
Cheers anyway!

Sorry for the late reply. Thanks for the kind words! Looking that the Notion API docs, the description of the color property says:

"Not currently editable."

So I believe it's correct that you cannot set a color for a select option when creating/updating pages/blocks.
At the moment notion.SelectOptions is used for create/update request data, so I guess it's a bit confusing because you could easily think that color is a valid property when creating/updating select options. Having separate types for upserting and reading select options would clear this up, but I think it's not worth the hassle of maintaining a bunch of extra types. So closing this issue for now.


Document the different behaviour for input binding payload between HTTP and gRPC

As illustrated by #1828, the difference in how the input binding payload is deliver to handler can be confusing to the user. I can't find any docs on the fact that in gRPC the metadata is part of the content delivered to the user as part of the handler properties and in HTTP the metadata elements are passed as part of the HTTP headers, not serialized in the content (HTTP body).

The same input binding setting metadata will cause Dapr to deliver to user code different metadata. In HTTP, the metadata delivered to the user will include additional elements:
Content-Length]: 0
User-Agent: fasthttp
Content-Type: application/json


Move genToken function out of data models

 genToken is the only thing that requires the models to use global state not tied to the model at all.
split it out into a function that takes a user instance as an argument , and returns said token.
( JWT token data should not be tied to the User model, that way the User model wouldn't be useful in another context)
Why does the data model have both an ID and a UUID?  (It's perfectly valid to have an UUID as the primary key )

Hey! Sorry for the long feedback cycle. I've actually re-written the entire project using Sanic now instead of Flask, added lots of testing, and other improvements (if you have some feedback on it now I'd appreciate that). Still have a Integer ID and UUID because I can think of some situtations where it might be nice to have both (such as merging different user databases). The JWT token generation is kept as a helper function on the model since it's only in the user context that a token is created, and it is functionality tied to that user.


Tutorial Groups: Improve readability of tutorial group table

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context
@krusche requested some changes to the way tutorial groups are displayed in the table to increase usability / readability.
Description

Remove seconds from time display (e.g. 14:00:00 -> 14:00) in commit 36d00e596b7a5455fa40dec0ed78e8d5f90ae7cf
Combine Time Weekday and Repetition pattern in one string (e.g. Every Week, Monday, 14:00-15:00) 070b15b6c621c512f6ed2a3e3bcbdf49779be4c3
Only show repetition frequency if it is not weekly  c3a2b8b480282af47202dda09a2faf8d6698d711
Show the average attendance as overlay to progress bar instead of new column eb773b316a3dd51da1075d903cfbe19a1e8a6f76
Combine capacity and registered students in one column 095c6db76fccee630159c481575ea88ba2a2538b
Only show language, campus, and online/offline columns if not all equal for all tutorial groups 1a31e0c4cad6be41fa26986493b5ef35c1d1b549

Steps for Testing

Verify that the time display does not show seconds for any tutorial group or event. For example, 14:00:00 should be displayed as 14:00.
Verify that the time weekday and repetition pattern are shown in one string for each tutorial group or event. For example, Every Week, Monday, 14:00-15:00 should be displayed instead of separate columns for time, weekday and repetition frequency.
Verify that the repetition frequency is hidden if it is weekly. For example, if the repetition pattern is Every Week, it should not be displayed at all in the column. It should be displayed if the group repeats every two weeks.
Verify that the average attendance is shown as an overlay to the progress bar for each tutorial group or event. For example, if the average attendance is 12, it should be displayed on top of the progress bar instead of in a new column.
Verify that the capacity and registered students are shown in one column for each tutorial group or event. For example, 10/20 should be displayed instead of separate columns for capacity and registered students.
Verify that the language, campus, and online/offline columns are hidden if they are equal for all tutorial groups. For example, if all tutorial groups or events have the same language (e.g. English), campus (e.g. Main Campus) and online/offline status (e.g. Online), these columns should not be displayed at all.

Review Progress
Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots
Before Instructor View:

Before Student View:

Before Instructor After:

Note: undefined bug is already fixed
Same Language, Campus, Online,Offline:

Before Student After:

Codecov Report

Merging #6354 (af72c75) into develop (f86c014) will increase coverage by 0.00%.
The diff coverage is 79.03%.

:exclamation: Current head af72c75 differs from pull request most recent head c07e9f5. Consider uploading reports for the commit c07e9f5 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6354   +/-   ##
==========================================
  Coverage      80.31%   80.31%
  Complexity     13010    13010
==========================================
  Files           2305     2307    +2
  Lines          89246    89296   +50
  Branches       13186    13197   +11
==========================================
+ Hits           71680    71721   +41
- Misses          9744     9745    +1
- Partials        7822     7830    +8

Impacted Files
Coverage Δ

...urse/tutorial-groups/shared/remove-seconds.pipe.ts
71.42% <71.42%> (ø)

src/main/webapp/app/shared/service/sort.service.ts
71.11% <76.47%> (+4.44%)
:arrow_up:

...rse/tutorial-groups/shared/meeting-pattern.pipe.ts
78.94% <78.94%> (ø)

...al-groups-table/tutorial-groups-table.component.ts
80.00% <80.00%> (+2.22%)
:arrow_up:

...tutorial-group-row/tutorial-group-row.component.ts
100.00% <100.00%> (ø)

...al-progress-bar/vertical-progress-bar.component.ts
85.71% <100.00%> (+0.34%)
:arrow_up:

... and 2 files with indirect coverage changes

Flag
Coverage Δ

client
76.47% <79.03%> (+<0.01%)
:arrow_up:

server
84.61% <ø> (+<0.01%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebd612...c07e9f5. Read the comment docs.


Deprecate and remove lesser-used API methods for JctFileManager and Workspace

We have lots of methods in classes like Workspace which will rarely ever be used, such as:

addPatchModulePathModule
addUpgradeModulePathModule
addNativeHeaderOutputModule
addSystemModulePathModule

etc.
To keep the API simple, deprecate these methods (and remove them entirely in the v1.0.0 branch).
Users can call .addModule(Location, String) or similar instead going forwards on the offchance they actually need to use these.

Closed by GH-418


bugfix fix base_compaction delete_sign handler

In vertical base compaction, same rows will be filtered in verticam_merge_iterator, we should skip these filtered rows when set agg flag of delete sign. For example, schema is a,b,delete_sign, and data is 1,1,1
1,1,0
1,1,0
2,2,1
2,2
and Block we get in VerticalBlockReader is
1,1,1
2,2,1
and we should set agg flag idex 0,4 to true when handle delete sign, so we add a function continuous_agg_count to skip same rows filtered in VerticalMergeIterator.
Proposed changes
Issue Number: close #16139
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.51 seconds
load time: 490 seconds
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230207093049_clickbench_pr_91300.html


Creating a resource tree leaving out intermediate nodes

Hi,
I have a question regarding "add_resource" from server\coap.py: Why don't we allow to leave out intermediate nodes while creating a resource tree? For example:
/small
/large
/other/color
/other/transparence
Why do we have to define /other before creating the sub nodes?
Regards

Hi, well it depends. If we allow the creation of sub nodes, without the parent node, which kind of resource will be the parent? What will happen when a client issues a request to "other"? Maybe NOT FOUND? I accept suggestions :-)


python311Packages.napari-svg: 0.1.6 -> 0.1.10

Diff: https://github.com/napari/napari-svg/compare/refs/tags/v0.1.6...v0.1.10
Changelog: https://github.com/napari/napari-svg/releases/tag/v0.1.10
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 284199 run on x86_64-linux 1

2 packages failed to build:

napari (python311Packages.napari)
napari.dist (python311Packages.napari.dist)

2 packages built:

python311Packages.napari-svg
python311Packages.napari-svg.dist


Use mutable attributed strings instead of concatenation

In Apple's WWDC 2012 talk that introduces attributed strings on iOS 6, they mention that modifying an attributed string is more efficient than concatenating multiple attributed strings. I would like to write some tests to confirm this, and if it is still true, change BonMot to use mutable attributed strings when building its strings.

Resolved in 4.0


Logo Proposal: Navigator

Hello!
I'm a graphic designer and I like to support open source projects. I would like to design a logo for your project if you interested, I will be happy to work with you! :)
Best Regards
Baran Pirinçal
Graphic Designer

That sounds great. Would love to set a logo that goes with the concept!

Do you have an any idea or suggestion about design decisions? Feel free to share with me
It would be better!

I'm not a very design-oriented person. Most probably my suggestions will be a hindrance. So go for it as you see fit 😄

@shaishavgandhi05
Hey again,
I want to get comments from you :)
Best Regards
Baran Pirinçal

Hey! This looks great. Can we skip the tag line "annotation processor that eliminates navigation boilerplate"?
Also, not sure if the pile of books are a good representation of what the library stands for. Might be interesting to have something that indicates navigation in terms of screens.

Hey, thank you!
I am little bit confused about function of the project because of that I am not sure how can I show navigation on it.  I am sorry but I did not imagine that. I would be happy if you explain more your navigation and screen idea. Anything can be okay for me like reference graphics , information text or logo design examples.
Best Regards
Baran Pirinçal

Sure. The project is basically used to help developers write code that will take the user from one screen to another.
For example, when you're using a mobile app, let's say a news app, you have a screen which has the list of headlines. You then click on one of them and it takes you to a screen which has the entire article. That flow looks something like
ListScreen -> DetailScreen

This library helps with writing code that will take the user from one screen to another like the example mentioned above.
Considering that, it might be useful to incorporate the idea of moving from one screen to another into the logo. I don't have a visual representation sadly. Hope this helps. Also, I appreciate the help!

@shaishavgandhi05
Hey, it is not finished.
I'm not sure... I just want to get comments from you.
Also we can add text below the icons

I like the idea of just adding the test below the icon. I like the second icon. Maybe we can do the icon and just plain text of "navigator" below it?

Liked the one on the right 😄

Hey again @shaishavgandhi05
I uploaded all variations of logo design and created pull-request.
Good luck with that!
Best Regards
Baran Pirinçal

Have added the logo to the Readme.md. Thanks for the contribution!


Rename this project/repo

Type: breaking|critical|major
Describe the bug
The reaction-next-starterkit name came about mostly as an inside joke that made it all the way to the repo. The name is extremely confusing to not only the community but within the Reaction team.
To Reproduce

Go to the reaction-next-starterkit repo.
Read the project name.
You should now be confused.

Expected behavior
A clear project/repo name that accurately conveys the reference/example intent of this project.
Additional context
I see two deliverables here before we actually change the projects name.

[x] Pick a new name: Current front runner example-storefront
[ ] Audit other Reaction repos that may reference this project by name. (i.e., reaction-platform)

to throw in my 2¢ it might be better to name repos example-storefront-<techname> for sorting/searching purposes within the reaction org.
Might it also be beneficial to separate these into a reaction-storefront grouping (like how we have reaction-contrib-org) where we can just have example-nextjs etc?
This might naturally alleviate the association between our versioned/supported headless API and the storefront jumping off examples.

@nnnnat Have we settled on a new name?


Release proposal: standard v9

Planned release date: Mar 1, 2017. (approx. 22 days from the date of this issue)
New features

Update ESLint from 3.10.x to 3.15.x.
3 additional rules are now fixable with standard --fix!

New rules
(Estimated % of affected standard users, based on test suite in parens)

Disallow mixing different operators without parens (no-mixed-operators) #566 (5%)
Enforce 1 newline at end of file (previously 1 or 2 were ok) (no-multiple-empty-lines) #733 (3%)
Disallow Unused Expressions (no-unused-expressions) #690 (3%)

Note: this affects users of the Chai test framework. Read about the changes you need to make.

Disallow redundant return statements (no-useless-return) #694 (1%)
Disallow Incorrect Early Use (no-use-before-define) #636 (0%)
Enforce that Promise rejections are passed an Error object as a reason (prefer-promise-reject-errors) #777 (0%)
Enforce comparing typeof expressions against string literals (valid-typeof) #629 (0%)
Enforce spacing around * in generator functions (generator-star-spacing) #724 (0%)
Disallow Unnecessary Labels (no-extra-label) #736 (0%)
Disallow spacing between template tags and their literals (template-tag-spacing) #755 (0%)
Disallow padding within switch statements and classes (padded-blocks) #610 (0%)
Enforce that Symbols are passed a description (symbol-description) #630 (0%)

Changed rules

Relax rule: allow TypeScript Triple-Slash Directives (spaced-comment) #660
Relax rule: allow Flow Comments (spaced-comment) #661

Sorry for all the notification spam today. I've been busy merging a lot of new rules for v9. 🛠 💻
So, a bit of background... I was planning to put a lot more rules into this release, but as I went along adding rules and testing the ecosystem impact, it got to a point where I realized we're already affecting a decent number of users.
So I think we should just call what we have so far v9 and release it before the end of the month. Then we can release v10 shortly thereafter, with the rest of these rules. Something like this:
2/8 (today) - v9 (beta)
3/1 - v9
4/1 - v10 beta
5/1 - v10

Sounds good to me

I'm happy to announce the immediate availability of a standard v9 release candidate. The version is 9.0.0-beta.0.
You try it out today by installing it: npm install<EMAIL_ADDRESS>--global
Cheers! 🎉

@SEAPUNK I did this intentionally to get more eyeballs on the new version, but I didn't realize it would false-alarm automated tools. Added a dist-tag.

Thank you!

standard 9.0.0 is released, one day ahead of schedule! 🎉
Change log: https://github.com/feross/standard/blob/master/CHANGELOG.md#900---2017-02-28
Tweet: https://twitter.com/feross/status/836710564130803714


Update expressroute-howto-circuit-arm.md

To get a list of all configured circuit, we need to run 'Get-AzExpressRouteCircuit' without any parameters.

@duongau
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


CAR.IONIQ_5 update for Ecu.fwdRadar values

missing firmware version for car. Including in here. From dongle id 5608f42aaece1463. Confirmed working on fork installed to comma 3

Your FW versions are already in openpilot, this is just a different version of the response.


Add changes to fix Prototype Impl page

Fixes https://github.com/wso2/api-manager/issues/1638

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Naduni Pamudika seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update state schemas for OTC/secondary feeds

Background
OTC volume is increasing, and states have custom requirements on how and where they want to receive data.
To date, we’ve built a filtering system that allows RS to have more flexibility send OTC data – to keep in the existing primary feed, to move to a second ELR feed, or to move to a download site.
States have expressed that the OTC data, as is, cannot be ingested into their surveillance systems without more default fields.
Goal is to offer a set of default fields we fill in if there is information missing
Proposed defaults
MSH 4.1

CDC PRIME OTC

MSH 4.2

For Over The Counter – Fake CLIA: 0OCDCPRIME

For At home testing with prescription – Fake CLIA: 0PCDCPRIME

For At home testing with prescription and tele proctoring – Fake CLIA: 0TCDCPRIME

All other CLIA fields

Put same as MSH 4.2

OBX-11, OBR-25

Result status is currently not being sent for OTC. If it cannot be sent, the default should be "F" for Final Result.

APHL Recommendations for Ordering Facility, Facility Name, address
At home testing over the counter purchase– patient buys and performs testing, result is obtained via app that then does the reporting; this may result in limited data fidelity (no verification a) that person tested = patient, b) of how the specimen was collected, c) if the test procedure was followed, d) if the interpretation of the result and subsequent reporting is accurate, unless the app preforms the interpretation, e) data about the patient is accurate)
Ordering Provider First Name (ORC-12.3/OBR-16.3) = “SA.OverTheCounter”
Ordering Facility Name (ORC-21.1) = “SA.OverTheCounter”
Ordering Facility Address (ORC-22) = <Copy patient address (PID-11)>
Ordering Facility Phone (ORC-23) = <Copy Patient Home Phone (PID-13); if not available, use default value ^^^^111^1111111>
Performing Facility Name (OBX-23.1) = “SA.OverTheCounter”
Performing Facility CLIA (OBX-15.1 and OBX-23.10) = 00Z0000014
Performing Facility Address (OBX-24) = “11 Fake AtHome Test Street^^Yakutat^AK^99689^^^^02282”
Allowed test kits with EUA for this purpose:
Ellume’s  COVID-19 Home Test_Ellume Limited -– OBX-17.1 = Ellume COVID-19 Home Test_Ellume Limited_EUA
Cue Health Inc’s Cue COVID-19 Test for Home and Over The Counter (OTC) Use – OBX-17.1 = Cue COVID-19 Test_Cue Health Inc._EUA
Lucira Health, Inc.’s Lucira COVID-19 All-In-One Test Kit – OBX-17.1 =Lucira COVID-19 All-In-One Test Kit_Lucira Health, Inc._EUA (will soon be updated in LIVD to:<PHONE_NUMBER>0001_DIT) - this is what will be sent via AIMS
ANY OTHERS???
Example message is for Ellume’s  COVID-19 Home Test sent by OneAbbott: InterPartner~CentralizedELR~OneAbbott~AIMSPlatform~Test~Test~2021012816241013~STOP~TestMessageSA.OTC_AL_FINAL
At home testing with prescription – patient is prescribed the test, obtains the kit, sample collection and test performance is unsupervised, result is obtained via app that then does the reporting; this may result in some limited data fidelity (no verification a) that person tested = patient, b) of how the specimen was collected, c) if the test procedure was followed, d) if the interpretation of the result and subsequent reporting is accurate, however data about the patient should be accurate – since it is coming from the provider’s health record)
Ordering Facility Name (ORC-21.1) = <Copy Ordering Provider Name (ORC-12/OBR-16), if no separate facility>
Ordering Facility Address (ORC-22) = <Copy Ordering Provider Address (ORC-24), if no separate facility>
Ordering Facility Phone (ORC-23) = <Copy Callback number (ORC-14/OBR17), if no separate facility number, else use default value ^^^^111^1111111>
Performing Facility Name (OBX-23.1) = “SA.Prescription”
Performing Facility CLIA (OBX-15.1 and OBX-23.10) = 00Z0000015
Performing Facility Address (OBX-24) = “12 Fake AtHome Test Street^^Yakutat^AK^99689^^^^02282”
Allowed test kits with EUA for this purpose:
Lucira Health, Inc.’s Lucira COVID-19 All-In-One Test Kit – OBX-17.1 =Lucira COVID-19 All-In-One Test Kit_Lucira Health, Inc._EUA (will soon be updated in LIVD to:<PHONE_NUMBER>0001_DIT) – this will be discontinued – is currently being reported via providers ONLY
Quidel Corporation’s QuickVue At-Home COVID-19 Test – OBX-17.1 = QuickVue At-Home COVID-19 Test_Quidel Corporation_EUA (will soon be updated in LIVD to:<PHONE_NUMBER>9373_DIT)
ANY OTHERS???
Example message is for Quidel Corporation’s QuickVue At-Home COVID-19 Test sent by OneAbbott: InterPartner~CentralizedELR~OneAbbott~AIMSPlatform~Test~Test~2021012816241013~STOP~TestMessageSA.Prescription_AL_FINAL
At home testing with prescription and tele proctoring – patient is prescribed the test, obtains the kit, sample collection and test performance is done under observation of the healthcare professional and results are reported via the app. This has verification a) that person tested = patient, b) of how the specimen was collected, c) if the test procedure was followed, d) if the interpretation of the result and subsequent reporting is accurate, e) data about the patient is accurate???
Ordering Facility Name (ORC-21.1) = <Copy Ordering Provider Name (ORC-12/OBR-16), if no separate facility>
Ordering Facility Address (ORC-22) = <Copy Ordering Provider Address (ORC-24), if no separate facility>
Ordering Facility Phone (ORC-23) = <Copy Callback number (ORC-14/OBR-17), if no separate facility number, else use default value ^^^^111^1111111>
Performing Facility Name (OBX-23.1) = “SA.TeleProctor”
Performing Facility CLIA (OBX-15.1 and OBX-23.10) = 00Z0000016
Performing Facility Address (OBX-24) = “13 Fake AtHome Test Street^^Yakutat^AK^99689^^^^02282”
Allowed test kits with EUA for this purpose:
Abbott’s BinaxNOW COVID-19 Ag Card Home Test – OBX-17.1 =<PHONE_NUMBER>1337_DIT
ANY OTHERS???
Example message is for Abbott’s BinaxNOW COVID-19 Ag Card Home Test sent by OneAbbott: InterPartner~CentralizedELR~OneAbbott~AIMSPlatform~Test~Test~2021012816241013~STOP~TestMessageSA.TeleProctor_AL_FINAL

@Adrian-Brewster to work on FAQ for our different options - 1) OTC in download site, 2) OTC in primary feed. Both cases we can't reformat

@mauricereeves What do you think about defaulting result status to F for final? I didn't see a result status field in the OTC files from stac so how would we even know if a record was final vs corrected?

Have we confirmed with states that once we create these filters, they will want to receive the OTC data in their primary feed?

Per Slack thread, yes we have a few lined up to receive this data
@MauriceReeves-usds what do you think about Brick's comment?
@Adrian-Brewster put together some draft, external messaging for your review: https://cdc-my.sharepoint.com/:w:/g/personal/qpu0_cdc_gov/ETUI9sOjLodCj_uewXj3DpIB2yWcFR8ArzNPXV6uoN7MWA?e=Kq8FdD

We need to restart discussion on OTC data. Closing this for now.


Table metadata desgin document and micro benchmark

What type of enhancement is this?
Performance, Tech debt reduction
What does the enhancement do?
After #1985 , we successfully refactored the table metadata in distributed mode, but missed some performance microbenchmarks and the design document, especially the metadata key format.
Let us do these jobs ASAP.
The microbenchmarks of table metadata operations may give us some insights into the potential performance bottleneck and help to resolve them.
Implementation challenges
No response

After #1985, we introduced many small transactions(like the following), and It's a nightmare to ensure the whole on_update_metadata is idempotent. 🥲
  async fn on_update_metadata(){
      update_table_info_kv().await();
      failpoint!('after_update_table_info');

      update_tableroute_kv().await();
      failpoint!('after_update_table_route');
      ....
  }

BTW, If we decided to use a large transaction instead of many small transactions(I guess we will, for two reasons: 1, the Etcd's linearized writes are expensive, 2. it reduces the number of fail points). Considers designing transactions like the following:
  async fn on_update_metadata(){
      let ignore_if_primary_key_updated = |x| {...}
      let txn = transaction::with_primary_key(primary_key, not_exists, ignore_if_primary_key_updated);

      update_table_info_kv(txn).await();

      update_tableroute_kv(txn).await();
      ....
      txn.await()?;
  }

WDYT @MichaelScofield  @fengjiachun @Fengys123

the doc is here

According to our current Txn API, do you mean to refactor it like this?

Nice idea, maybe we can give it a try. cc @MichaelScofield


[tests/functional] - Add functional test case covering SCK-SOCK migration

Description: Add a new test case that covers no duplicates scenario during migration from SCK to SOCK
NOTE: This case will currently fail. It will become green once https://github.com/signalfx/splunk-otel-collector/pull/3879 gets released

@atoulme, will these fixture changes break the implicit upgrade check added by https://github.com/signalfx/splunk-otel-collector-chart/pull/1051?

To get the EKS functional-tests up and running, you will have to close this PR and open up a different PR in a specific way due to recent project test updates. The EKS functional tests need to run with credentials that are only available in this repo.

Create your feature branch in the https://github.com/signalfx/splunk-otel-collector-chart repo and not your personal fork.
Create the PR with the feature branch in the https://github.com/signalfx/splunk-otel-collector-chart repo against the main branch.

This PR has conflicts and is open from a fork, this won't work with our test checks. Going to close and reopen from this repository.


Correct typos and formatting in differential calculus tutorial

Hi Aurélien,
This PR fixes a few minor typos, removes unnecessary import and %inline, corrects several formatting issues (e.g., explicitly adding && to the last row helps to render correctly in DataSpell IDE, although the GitHub's notebook viewer doesn't have any problems). Lastly, it corrects several equations and inequalities. Of course, none of them influence the final proofs, so they're mostly typos. It's hard to see the changes looking at the diff, so here they are:

$a\ln(b)=\ln(a^b) \; \to \; a\ln(b)=\ln(b^a)$

$-\dfrac{\theta}{2} < \theta < \dfrac{\pi}{2} \; \to \; -\dfrac{\pi}{2} < \theta < \dfrac{\pi}{2}$

$\cos^2(\theta) - 1 = \sin^2(\theta) \; \to \; \cos^2(\theta) - 1 = -\sin^2(\theta)$

$cos(a+b)=\cos(a)\sin(b)+\sin(a)\cos(b) \; \to \; \sin(a+b)=\cos(a)\sin(b)+\sin(a)\cos(b)$

I also changed two mentions of $\exp(\ln(a))$ to $e^{ln(a)}$ to keep it consistent throughout the text. IMHO, it looks better, but I understand that $e^{\ln(x^r)}$ might be less readable with a small font setting. So let me know if you'd like me to revert these changes.
You can compare rendered notebooks before merging: old and new.

Oh wow, thanks so much @vi3itor !
Everything looks great. 👍


Way to update a specific package without reinstalling the cluster (for development purposes only)

What would you suggest is the best way to update a specific package (to include a bugfix for instance) in an existing seapath cluster ?

have bitbake build the rpm and use a dbg image including dnf to be able to install/update via a rpm ?
have bitbake build a tarball and deploy the tarball manually ?

Thanks.

dnf may work some times
swupdate is the best way to upgrade without reinstalling


optimize websocket debug logger when http connection closed

fix #2180
fix typo
remove unnecessary qualifier

commit 有点乱，重新fork重新提交pr吧

closed because of #2182


Show award date field when trainee recommended

We recently made a change to show the award date as a separate row.
We've now found out that the QTS and EYTS award date will always be the same as the date the standards were met. This means there's no point showing both dates once the trainee has been awarding teaching status.
When the trainee has been recommended for QTS or EYTS, we'll say that they're waiting for their award. We'll also give the date when they were recommended for teaching status.

Once the trainee has teaching status, we'll just show the date they were awarded it.

 Sort out what date show on a record when a trainee is recommended for QTS or EYTS


fix: ignore "0" disk-serial md5 on client hash checks

Describe your changes
Some disk manufacturers do not have a disk serial set, defaulting to the number 0. This can cause lots of trouble over time as anyone with such a disk serial will not be able to verify unless manually approved by staff.
I think this check is safe to implement and does not disregard the actual purpose of this check.
I'm not sure this is the right place to implement it though.
Checklist

[ ] I've manually tested my code

it points out why an automatic restriction policy for this is generally flawed in my eyes

I mean, it doesn't automatically restrict. It just prevents verification (first login).

would prefer an allowed serials table adding on to what @tsunyoku said
perhaps we can add some default values in migrations or something

list config variable (with defaults) or a database table sounds better, just because if people find new ones then they don't have to PR every time.

hmm, haven't come across any other than this one so far but fair.

I mean, it doesn't automatically restrict. It just prevents verification (first login).

fair, i forgot. still sucks for both parties though

Would you rather use a database table or config? I feel like the config makes more sense, I wouldnt really put configuration values that are barely ever touched into the database.

hmm, haven't come across any other than this one so far but fair.

it's not really a predictable thing so yeah, the issue is just that manufacturers are not forced into creating unique identifiers (if any at all) so there is many cases of these clashing identifiers that depend on what the manufacturer decided or what the OS decided. there's no real way to deterministically solve this issue, which is why i mentioned any kind of auto enacting policy is quite flawed

Would you rather use a database table or config? I feel like the config makes more sense, I wouldnt really put configuration values that are barely ever touched into the database.

the advantage i see (probably doesn't matter in the future) is being able to modify without restarting. this wouldn't matter but bpy is stateful so it would mean yeeting sessions, multis etc. to change this. i guess it opens a can of worms about other config variables that exist, but this one in particular isn't sensitive and also not a simple toggle so i think it's justifiable.

Tested and working


Boolean inputs instead of String

Low priority issue.
Some of the biobb_canal properties (and maybe also in other biobb_dna bbs) should be changed from String to Boolean so that GUIs can use a switch.
Example:
https://github.com/bioexcel/biobb_dna/blob/b2021557f4fe270b184b0360a1ceae7608ffa051/biobb_dna/curvesplus/biobb_canal.py#L34C12-L34C66

Fixed, it will be available in the next 4.2.3 release


[CLOUD-2453][KEYCLOAK-7098] Add database connectivity check

prior launching the RH-SSO server when deploying the RH-SSO pod from persistent DB templates
Signed-off-by: Jan Lieskovsky<EMAIL_ADDRESS>

@rcernich @Crumby PTAL
Thank you, Jan

One thing I've noticed is the upstream OS mysql template uses wait-for-ready, where we don't seem to have that in our templates.
https://github.com/openshift/origin/blob/master/examples/db-templates/mysql-persistent-template.json#L84

Sounds like a simpler fix maybe?

@luck3y Thanks, Ken! Noticed that one, when searching how this could be done. Seems to have been introduced starting from v3.7. Tried, but it wouldn't help me in this specific case (the pods are still deployed from both sso and sso-mysql deployments at the same time, still leading to the JPA RH-SSO exception, without RH-SSO pod restart).
But seems to be something useful to apply to our templates too. IIUR when using that annotation, if the build failed, the template instantiation will fail immediately (thus the namespace might not be polluted by objects [services, routes], which wouldn't be working anyway).

@rcernich The readiness probe correctly fails currently, and is followed with container restart (4-times in 2 minutes). But the issue is we are starting RH-SSO pod, even when we know, it can't work properly (since it takes 2-3 minutes till MySQL pod is initialized properly).
For the JPA initialization code, tried to set up allocation-retry, allocation-retry-wait-millis, and blocking-timeout-millis / blocking-timeout-wait-millis timeout properties on the datasource, without luck so far (even having them set, no change in RH-SSO pod behaviour). But will explore the options further yet.

Closing (will submit different proposal).


Improve compatibility for finding other name format python libraries.

When I build this project on Ubuntu machine, I went into some troubles.
These troubles were caused by the followings.

CMakeLists.txt finds only libboost_python.so or libboost_python3.so.
So other name format library such as libboost_python-py35.so canot be found.

FindPythonLibsNew.cmake finds only libpython${MAJOR}.${MINOR}.so.
So libpython${MAJOR}.${MINOR}m.so cannot be found.

I fixed above issues. Please review this pull request.

@ar90n I'm sorry this has lingered for so long, but could you please try with the latest master to see if it also fixes your problem?  I suspect #56 may have fixed it.


Scale property does not work

I'm trying to scale the rigged hand using following code:
<script>
  (window.controller = new Leap.Controller)
    .use('riggedHand', {
      scale: 5.0
  })
    .connect()
</script>

Hand shows and works correctly, but scaling doesn't change anything. I'm using three.js r70, leap 0.6.4, leap-plugins 0.1.10 and leap.rigged-hand 0.1.7

I had the same problem, see the CHANGELOG, v 0.1.6, the property scale is removed.
It works with transform plugin, I just tried.
<script>   (window.controller = new Leap.Controller)     .use('transform', {       scale: 5.0     })     .use('riggedHand')     .connect() </script>


easytier: 2.1.0 -> 2.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for easytier is: Simple, decentralized mesh VPN with WireGuard support
meta.homepage for easytier is: https://github.com/EasyTier/EasyTier
meta.changelog for easytier is: https://github.com/EasyTier/EasyTier/releases/tag/v2.1.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.1.1 with grep in /nix/store/i3yl4m7yzc23gzh6dx91yx9izm33rv9f-easytier-2.1.1
found 2.1.1 in filename of file in /nix/store/i3yl4m7yzc23gzh6dx91yx9izm33rv9f-easytier-2.1.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

easytier

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/i3yl4m7yzc23gzh6dx91yx9izm33rv9f-easytier-2.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A easytier https://github.com/r-ryantm/nixpkgs/archive/b5b5aba10ae7a7a1770aa281b914f41311b064ad.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b5b5aba10ae7a7a1770aa281b914f41311b064ad#easytier

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i3yl4m7yzc23gzh6dx91yx9izm33rv9f-easytier-2.1.1
ls -la /nix/store/i3yl4m7yzc23gzh6dx91yx9izm33rv9f-easytier-2.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

easytier

Maintainer pings
cc @L-Trump for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Progress upload not found

Hi, i try the youtube example: https://github.com/google/google-api-nodejs-client/blob/master/samples/youtube/upload.js.
The callback work fine, and Video is on youtube
const req = youtube.videos.insert({
    part: 'id,snippet,status',
    notifySubscribers: false,
    resource: {
      snippet: {
        title: 'Node.js YouTube Upload Test',
        description: 'Testing YouTube upload via Google APIs Node.js Client'
      },
      status: {
        privacyStatus: 'private'
      }
    },
    media: {
      body: fs.createReadStream(FILENAME)
    }
  }, (err, data) => {
    if (err) {
      throw err;
    }
    console.log(data);
    process.exit();
  });

but the Req variable is "undefined"
console.log(req) => undefined
The progress upload fail:
const id = setInterval(() => {
  const uploadedBytes = req.req.connection._bytesDispatched;
  const uploadedMBytes = uploadedBytes / 1000000;
  const progress = uploadedBytes > fileSize
    ? 100 : (uploadedBytes / fileSize) * 100;
  process.stdout.clearLine();
  process.stdout.cursorTo(0);
  process.stdout.write(uploadedMBytes.toFixed(2) + ' MBs uploaded. ' +
    progress.toFixed(2) + '% completed.');
  if (progress === 100) {
    process.stdout.write('\nDone uploading, waiting for response...\n');
    clearInterval(id);
  }
}, 250);

How can I get the progress of upload? Thank you.
My step:

npm install googleapis --save
configuration oauth2.keys.json
video successfully uploaded on youtube but req variable empty

thank you!

Greetings folks!  This is now fixed, and includes a sample.  You can see it here:
https://github.com/google/google-api-nodejs-client/blob/master/samples/youtube/upload.js
This will be available in v28 :)


custome edge doesn't work

I've implemented my custom edge with desired style. I found, however, the default type was still used to form connections when I drag a handle to another when connecting. How can I solve it?

Edges and the connection line aren't the same.
That means if you use edge.type it will not affect the connection line.
There is a slot for the connection line that you can fill in with a custom component that has your desired styles.
See here the example for custom connection lines.

I haven't described the situation well. Actually I want a custom edge, not a custom connection line.
I added edges by moving mouse from a handle of a node to another. But eventutally edges of default type were added.

It work! The problem has stopped me one or two days. Your help did give me energy to go on. Sincere thanks to you!

@Yeenyeong  No problem! If you encounter problems, don't hesitate to ask as many questions as you need 😄

hi! the custom connection line example is not working.
I am trying to make the default connection line smoothstep,
<VueFlow :connection-line-options="{ type: 'smoothstep' }">

but doesn't seem to work

@loama Thanks for reporting, I'll check out what's going wrong :)

@loama fix will be released with next patch 1.14.3

awesome, thanks! @bcakmakoglu


"Azure Policy definition structure basics" JSON example doesn't validate

I'm using the page https://learn.microsoft.com/en-gb/azure/governance/policy/concepts/definition-structure-basics to learn about Azure policy definitions.
The page contains an example of a JSON policy definition, directly under the text "For example, the following JSON shows a policy that limits where resources are deployed".
Directly underneath that example JSON, there's a sentence ("For more information, go to the policy definition schema") that links to a JSON Schema describing a "policy definition" (https://schema.management.azure.com/schemas/2020-10-01/policyDefinition.json)
Here's the problem: the example JSON presented on the page is invalid, according to the JSON Schema linked to by the page. I uploaded the schema and the example to an online validator (https://www.jsonschemavalidator.net/s/vKp4ApuY), which points out two high-level errors:

Property properties has not been defined and the schema does not allow additional properties.
Required properties are missing from object: if, then.

Requested fix: this page should be updated to link to an authoritative schema that can validate the example successfully.

@jpluscplusm
Thanks for your feedback! We will investigate and update as appropriate.

@jpluscplusm
Thank you for bringing this to our attention.
I've delegated this to content author, who will review it and offer their insightful opinions.

Thank you for the documentation feedback. I created an internal backlog work item to review the issue. I'm closing the GitHub issue.

#please-close

Thanks @davidsmatlak. Will this issue receive any updates as this problem gets addressed?


Add support for non-deterministic branches in refute_node

Blocked on: #884
Previously, refute_node was implemented in a way that only supports refuting nodes after a Split, not an NDBranch. This PR removes that restriction.

Replaces the pre_constraints and last_constraint members of the RefutationProof class with a single refuted_constraints list, so that refutations can be easily built for NDBranch as well (which lack a branching condition). The implication is then written as refuted_constraints -> bottom, instead of pre_constraints -> last_constraint = false.
Removes the checks in construct_node_refutation preventing refuting nodes from a non-deterministic branch.
Adds a test that refuting a node from a non-deterministic branch succeeds.

Closing this, as the discussion above suggest that it's preferable to refute-node from a Split rather than an NDBranch, and that a better solution is to give the user a way to turn an NDBranch into a Split via a split-node functionality.


chore(build): Updated karmor install to deploy with relay server's service account and RBAC policies

Purpose of PR?:
Fixes #397
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Tested by building and using karmor-client's  install/uninstall function while verifying with kubectl.
Additional information for reviewer? :

Ref: kubearmor/KubeArmor#1525

Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

@rootxrishabh, Can you try rerunning the pipeline? It seems to work in my fork.

@Utkar5hM can you please handle the conflicts, then we can merge this PR.


Get rid of unnecessary coordination in Instrumentation.

Ok, these synchronized blocks are in place to prevent two concurrent requests making 2 separate instances of Meter or Timer in the associated HashMap.
However… com.rackspacecloud.blueflood.utils.Metrics$timer (and $meter) uses a com.codahale.metrics.MetricRegistry instance which is backed by a ConcurrentHashMap.
So this change just deletes all of Instrumentation's HashMaps and the synchronized blocks and uses com.rackspace.blueflood.utils.Metrics directly.

Coverage increased (+0.03%) to 29.29% when pulling 3f0e3dc01d697f3276a8aee94126cbfcf5448a39 on dreid:less-coordination-on-instrumentation into 8dab27675d934449bb0ed515833cf0e27b5f7a39 on rackerlabs:master.

+1
and as a bonus, we reduce our memory footprint. yay!


CLICKHOUSE-2720: WIP

Note: You should merge master branch into your branch before making a pull request, because otherwise the log is too long.


Fix the CloudFormation ValidationError message

It should be a string, not a tuple, and it has a different form.
I'm not sure if it used to be different, but in the most recent
boto3/botocore, the message is "Stack with id {id} does not exist"
>>> cf = boto3.client('cloudformation', region_name='us-west-2')
>>> try:
...     cf.describe_stacks(StackName='adfgfhghg')
... except botocore.exceptions.ClientError as e:
...     print e.response['Error']['Message']
...
Stack with id adfgfhghg does not exist

I am on boto3 1.4.2 and botocore 1.4.82 as of this commit message.

Coverage decreased (-0.08%) to 93.904% when pulling 76484a5f8de431302b1a559d9db189622d408900 on 2rs2ts:fix-cf-validation-error into a20906ff155494c4994db9a3faeacb141079363c on spulec:master.

Thanks!


refactor(sbb-menu): improve menu events and positioning

Improved handling of window-related events, improved positioning function, and extracted logic for focus trapping.

Codecov Report

Merging #1430 (0af3b40) into master (ab917b0) will increase coverage by 2.56%.
The diff coverage is 65.82%.

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
+ Coverage   54.85%   57.41%   +2.56%
==========================================
  Files          49       60      +11
  Lines        1659     2238     +579
  Branches      406      576     +170
==========================================
+ Hits          910     1285     +375
- Misses        671      864     +193
- Partials       78       89      +11

Impacted Files
Coverage Δ

src/components/sbb-clock/sbb-clock.tsx
0.00% <0.00%> (ø)

src/components/sbb-logo/sbb-logo.tsx
0.00% <0.00%> (ø)

src/components/sbb-signet/sbb-signet.tsx
0.00% <0.00%> (ø)

src/components/sbb-teaser-hero/sbb-teaser-hero.tsx
70.00% <ø> (-22.86%)
:arrow_down:

src/components/sbb-teaser/sbb-teaser.tsx
70.83% <ø> (ø)

...etable-barrier-free/sbb-timetable-barrier-free.tsx
100.00% <ø> (ø)

...ents/sbb-timetable-button/sbb-timetable-button.tsx
52.54% <ø> (ø)

...ts/sbb-timetable-cus-him/sbb-timetable-cus-him.tsx
76.92% <ø> (ø)

.../sbb-timetable-duration/sbb-timetable-duration.tsx
82.60% <ø> (ø)

...bb-timetable-occupancy/sbb-timetable-occupancy.tsx
100.00% <ø> (ø)

... and 54 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


run wpf sample app

When compiling and running the FlashCap.Wpf application I get a runtime error:
System.IO.FileLoadException: 'Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>
The only way to solve it was to add the package reference (latest version 6.0.0)
System.Runtime.CompilerServices.Unsafe
and update Epoxy.Wpf to the latest version 1.11.0
Happy to push the change if needed.

Thanks for getting back to me!
Just to be sure, I made a diff with updated various package references at feature/109, could you please try it?

I just tried and it compiles and runs without issues. Thank you!

Merged, thanks!


Update MoneyRequestView.js

Design Doc
Let's update MoneyRequestView.js

The following should only apply to users in the violations beta
Let's add a connection to the transactionViolations and policyCategories Onyx collections as shown in the code snippet below, which will go in the withOnyx section of the code at the bottom
Let's add the new onyx key for the transaction violation collection
Add a new transactionViolation prop
Pass the transactionViolation to the MoneyRequestView function
For each field that can have a violation, Inside OfflineWithFeedback and below MenuItemWithTopDescription let's add a View that wraps a Text component to show the violation text, as shown in the snippet below

The fields are merchant, amount, category, date, tag, comment, billable, receipt, and tax

Fields with violations that go into a new page, like a list page for the cate of category and description for instance, should show a RBR circle to the right, in front of the caret >. Screenshots below

withOnyx({
    …
    policyCategories: {
        key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${report.policyID}`,
    },
    transactionViolation: {
        key: ({report}) => {
            const parentReportAction = ReportActionsUtils.getParentReportAction(report);
            const transactionID = lodashGet(parentReportAction, ['originalMessage', 'IOUTransactionID'], 0);
            return `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`;
        },
    },
...

{Boolean(ViolationUtils.getViolationForField(transactionViolation, 'amount')) && (
    <View>
        <Text style={[styles.ph5, styles.textLabelError]}>{ViolationUtils.getViolationForField(transactionViolation, 'amount')}</Text>
    </View>
)}

@lindboe @cdanwards can you please comment here so I can assign you?
(@NicMendonca sorry about that ping, that was a mistake)

@cead22 I'm unable to see the 2 images listed at the end of the ticket description, do you mind providing screenshots?

Can you try refreshing the page? GH adds a token to the image URLs and if you had this tab open before or you opened a cached version of this page, the token may not work. Let me know if that still doesn't work

@cead22 Refreshing doesn't seem to work.
I'm not familiar with this token idea? The URL that I see that it is opening in my browser is https://github.com/Expensify/Expensify/assets/165133/557c3ea2-a268-4415-8331-0e5963b20a2c, if it helps.

@cead22 -- In you description you list:

For each field that can have a violation, Inside OfflineWithFeedback and below MenuItemWithTopDescription let's add a  View that wraps a Text component to show the violation text, as shown in the snippet below

The fields are merchant, amount, category, date, tag, comment, billable, receipt, and tax

There doesn't appear to be a tax field in this view. Should the tax warning go on the amount?

There doesn't appear to be a tax field in this view. Should the tax warning go on the amount?

No the tax ones will go into the tax field once we have it. You can ignore that field for now

As we discussed here it's possible to have multiple violations per field.
How should we handle that.
We could (whereviolations is the array of translated violations) :
1. Iterate over the array and map to individual text components :
{violations && (
    <View>
        {violations.map((violation) =>(
               <Text ... >{violation}</Text>
    </View>
)}

2. Join the members of the array with a comma in the text field:
        <Text ... >{violations.join(', ')}</Text>
)}

Let's go with 1. Every field except for receipt will only have 1 violation, and for the receipt ones, we want to show them one below the other, not separated by commas. Does that make sense?

Perfect thanks.

Off hold

@trevor-coleman is working on this.

Yeah it's done just need to update to match the changes from ViolationUtils and the PR will be up today.

Sorry this will take a bit longer, I'm used to being able to make PRs when the code is ready, but completing the checklist will take some time -- probably the rest of today at least.

PR is up: https://github.com/Expensify/App/pull/32594

Payment summary:
C+: $500 @aimane-chnaif (Upwork job here)

Paid, contract ended, sorry for the delay!


Add support for HDR/Apple EDR displays as well as 10 bit color

Adding this support entailed updating tev to the latest (non-backwards-compatible) version of nanogui, which entailed

porting all tev-specific nanogui features
making tev agnostic to the rendering API (now supports OpenGL and Metal)
updating many other dependencies while at it.

This means that there is significant potential for breakage and bugs, so I'm waiting with pushing out a binary release and leaving my fingers crossed that everything will be ironed out by those folks who stay up to date with master. (Thank you very much! :))
In other news: due to the newer nanogui, tev now requires a C++17-capable compiler.

The nanogui dependency doesn't compile for me on windows, the function childCount() here does not exist, that should probably have been child_count? Strange that the CI didn't catch this, or maybe I did something wrong.

The nanogui dependency doesn't compile for me on windows, the function childCount() here does not exist, that should probably have been child_count? Strange that the CI didn't catch this, or maybe I did something wrong.

Good catch, thanks! The bodies of assertions are only compiled in debug mode -- yet another example of why C macros are a bad thing.


redesign course-navigation, add table of contents

closes #138, closes #209

Can you please autoformat (i.e. Code > Reformat Code) src/module/Entity/config/module.config.php and src/module/Entity/config/types.config.php, so that there are no additional whitespace changes? Otherwise, we probably have merge conflicts in next PRs, too, like you had.

LGTM

LGTM @Knorrke


Add option to set the path of the dbca template

Currently dbca_templatename can't refer to a file outside of the ./templates sub-directory. This is a problem if you maintain a location with various dbca template files, outside of the role/playbook structure. So, it should be possible to provide the source path of the dbca template as well. I know that you can set dbca_copy_template to false and copy the template file yourself, but I feel that oradb_manage_db role should be smart enough to handle this simple scenario by its own. Another way to address this would be to specify the full path as part of the dbca_templatename property and apply a basename filter here and there, but I think it is more complicated and it doesn't pay off the trouble.

Great idea, looks fine for me.


Simulation problem

When I run the python velodyne_td3.py command, the following error appears

[](url

)

May I ask if the collision rate after training until the episode 240 that is close to the episode 240 in the readme you wrote is still 0.3 and not close to 0 in your picture, is this normal?

There is randomness to the training process so it might not always obtain the same result after the same amount of runs. You might want to either restart the training process or change the random seed for initialization. See if that helps.

Thank you, I will try to modify the value of the random seed later. In addition, I have another question is how many episodes you have validated before using the training results on the actual mobile robot.

For the implementation in the paper, I ran the training for about 800 episodes. Validation is just testing how well the network performs at any given time, and in this implementation, it is just information for the programmer and has no effect on the training itself. So when I ran the training for the method in the paper, there were no validation sets, just pure training for about 800 episodes. However, in practice, there is no set number of episodes that you have to run before you can transfer the network to a real robot as the convergence rate and how well the network performs will depend on multiple factors - random initialization, learning rate, reward function, number of parameters, replay buffer length and others. So I would suggest just training the network, looking at the data (have the q-values converged) and visually how well does the robot perform, and deciding when to stop the training based on that. I have run networks with 400, 500, 800, 1600 and various other numbers of training episodes on real robot, so there is no set number that you have to reach.

Thank you for your reply. Next, I will try to train different steps according to my own robot.

For the implementation in the paper, I ran the training for about 800 episodes. Validation is just testing how well the network performs at any given time, and in this implementation, it is just information for the programmer and has no effect on the training itself. So when I ran the training for the method in the paper, there were no validation sets, just pure training for about 800 episodes. However, in practice, there is no set number of episodes that you have to run before you can transfer the network to a real robot as the convergence rate and how well the network performs will depend on multiple factors - random initialization, learning rate, reward function, number of parameters, replay buffer length and others. So I would suggest just training the network, looking at the data (have the q-values converged) and visually how well does the robot perform, and deciding when to stop the training based on that. I have run networks with 400, 500, 800, 1600 and various other numbers of training episodes on real robot, so there is no set number that you have to reach.

Hi, are there some good ways to look at whether the q-values, which are related to continuous action values, are converged? Through the average Q-value, or other metrics?

Generally speaking, loss should be a good indicator that the Q values have converged. Meaning, that the values we get from the critic network are not any different from the target network. That suggests that they do not change anymore. Another way is to look at the maximal experienced Q value during any validation run. Once the max Q stops growing, we have an implication that the Q values have converged as the same or similar high-valued state (the terminal state of arriving at the goal) is constantly evaluated with the same value.
I probably will not have the time to implement and these this through tensorboard any time soon, but contributions are always welcome.

Thanks a lot for your excellent suggestions. Next, I will try to implement your suggestion with tensorboard. If it works, I will be back for sharing the code.

Hi,man,thank you for you code.I have a problem.Do you use Anaconda to create a new virtual environment? I use Anaconda to create a new virtual environment Python 3.6 and python IDE, but I can't find rospkg in this environment.have you ever encountered a similar error and how to solve this.thank you.

[libprotobuf FATAL google/protobuf/stubs/common.cc:61] This program requires version 3.14.0 of the Protocol Buffer runtime library, but the installed version is 2.6.1. Please update your library. If you compiled the program yourself, make sure that your headers are from the same version of Protocol Buffers as your link-time library. (Version verification failed in "google/protobuf/any.pb.cc".) terminate called after throwing an instance of 'google::protobuf::FatalException' what(): This program requires version 3.14.0 of the Protocol Buffer runtime library, but the installed version is 2.6.1. Please update your library. If you compiled the program yourself, make sure that your headers are from the same version of Protocol Buffers as your link-time library. (Version verification failed in "google/protobuf/any.pb.cc".) Aborted (core dumped) [gazebo-1] process has died [pid 31116, exit code 134, cmd /home/user/gym-gazebo/gym_gazebo/envs/installation/catkin_ws/src/gazebo_ros_pkgs/gazebo_ros/scripts/gzserver -e ode TD3-2.world __name:=gazebo __log:=/home/user/.ros/log/62fe2f2e-3663-11ec-9092-e0e1a951fbad/gazebo-1.log]. log file: /home/user/.ros/log/62fe2f2e-3663-11ec-9092-e0e1a951fbad/gazebo-1*.log [r1/urdf_spawner-2] process has finished cleanly log file: /home/user/.ros/log/62fe2f2e-3663-11ec-9092-e0e1a951fbad/r1-urdf_spawner-2*.log [gazebo-1] restarting process process[gazebo-1]: started with pid [31658] [ INFO] [1635256108.664795970]: Finished loading Gazebo ROS API Plugin. [ INFO] [1635256108.665881041]: waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting... [ INFO] [1635256109.568563987]: waitForService: Service [/gazebo/set_physics_properties] is now available. [ INFO] [1635256109.612805600, 1210.735000000]: Physics dynamic reconfigure ready. [ERROR] [1635256109.823214551, 1210.939000000]: Updating ModelState: model [r1] does not exist

Thank you for your reply. Next, I will try to train different steps according to my own robot.

Hi，man，Can I add you a wechat?

Hi,man,thank you for you code.I have a problem.Do you use Anaconda to create a new virtual environment? I use Anaconda to create a new virtual environment Python 3.6 and python IDE, but I can't find rospkg in this environment.have you ever encountered a similar error and how to solve this.thank you.

Check if your ROS is installed properly, initialized, and sourced in the new anaconda virtual environment. If you can't run roscore in your environment, then it is most likely an issue with your installation.

Hi,man,thank you for you code.I have a problem.Do you use Anaconda to create a new virtual environment? I use Anaconda to create a new virtual environment Python 3.6 and python IDE, but I can't find rospkg in this environment.have you ever encountered a similar error and how to solve this.thank you.

Check if your ROS is installed properly, initialized, and sourced in the new anaconda virtual environment. If you can't run roscore in your environment, then it is most likely an issue with your installation.

Thank you for your reply.

When I run the python velodyne_td3.py command, the error appears
QObject::connect: Cannot queue arguments of type ‘QVector’ (Make sure ‘QVector’ is registered using qRegisterMetaType().)

When I run the python velodyne_td3.py command, the error appears QObject::connect: Cannot queue arguments of type ‘QVector’ (Make sure ‘QVector’ is registered using qRegisterMetaType().)

That is not an error that I have encountered.
There is not enough information to go on. Please provide your setup and how you are trying to run the program. Ideally you should open a new issue for such a case.

Hi,
Thank you for sharing your code. I'm new to ROS/Gazebo. I have installed ROS noetic and played with some tutorials. To make the things simple, I have just loaded the Gazebo environment. It is observed that the robot does not move in the rviz, however, it is moving in Gazebo. The robot model, camera, and laser scan all show status error, e.g.  No transform from [r1/base_link] to [base_link]. Thanks in advance.
my file velodyne_ab.py looks like
#############################################
import os
import time
import numpy as np
from velodyne_env import GazeboEnv
#variables initialization
env = GazeboEnv('multi_robot_scenario.launch', 1, 1, 1)
for i in range(10000):
print("AB Step")
if(i%100 == 0 and i > 0):
env.reset()
print("%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%")
print("AB Reset the Environment")
print("%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%")
action = (1 + np.random.normal(0, expl_noise, size=action_dim)).clip(-max_action, max_action)
a_in = [(action[0] + 1) / 2, action[1]]
next_state, reward, done, target = env.step(a_in)

Hi,
Could you open a new issue and post a picture of your output of rviz or the log from the terminal? It's difficult to say what could be the issue without knowing more about the problem.
In the meantime, can you check what is the output of your rqt graph?
Also check what is your Fixed Frame in Global Options in Rviz?


display python pandas tables with BeakerX widget

Classic Beaker did this, and we should add it to our Python runtime.
https://github.com/twosigma/beaker-notebook-archive/blob/1.7.1/plugin/ipythonPlugins/src/dist/python3/beaker_runtime3.py#L337

this class is used to make dataframes have a new representation: https://github.com/twosigma/beaker-notebook-archive/blob/1.7.1/plugin/ipythonPlugins/src/dist/python3/beaker_runtime3.py#L406
and here's where that class is registered:
https://github.com/twosigma/beaker-notebook-archive/blob/8fdd6a65d2cbd93b209d83d92466cb3acdd4780c/beaker/runtime.py#L448

we want this code to produce our table widget instead of the default html:


disabled sourceMap

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   90.62%   90.62%
=======================================
  Files           6        6
  Lines         480      480
=======================================
  Hits          435      435
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6686e...699356f. Read the comment docs.


Small: Update # of properties to show sum total number with commas

Currently map returns # of properties as (for ex) 2000
Update to reflect the values with a comma (for ex) 2,000

sorry this should be in 'Staging', not 'Live', that was my mistake closing this ticket!

@jgaye Looks good in the pull request preview!

closed by #453


Could you fix youtube please?

{ error: true, message: 'TypeError: data.url is not iterable' }

working on it.

working on it.

Thanks ❤

fixed


MJML - Outlook 2013 Only - Images Crop

Hi everyone,
I try MJML , nice stuff ! but i have a little problem 👍
when i try this export , on outlook my img are crop..
you can see the code here : https://mjml.io/try-it-live/BJsg0M_Bm
and the example on outlook 2013 : https://d2tygfsszdug5i.cloudfront.net/client/vag6pg8137/media/4bme198jb8.PNG
and i don't find how to resolve that ( it try raw, padding, hieght on section on column , on image ...)

Hi @nanoarts which mjml version are you using ?
I couldn't reproduce, it seems to render fine on all outlook versions :

Usually the fix for this kind of outlook-image problem is to set style="line-height: 1;" on the td that's around the , but it's when you use a raw  tag, it shouldn't happen with

hi,
it's strange ...do you check on emailonacid ?
i using the MJML editor on my desktop ( i download him today from the website ) ( after i send with the editor a test email on email on acid )

@nanoarts yes i check on emailonacid
i tested again with the desktop app, using the "Copy html" button, and i get the same result.
if you still get this problem, could you copy the generated html here ?

ok thk to try i put some height on the html file and that's fixed ...but yeah i don't understand why i have that and not you ...
I have a new responsive email to do , so i will retry MJML :)

Well if we unable to reproduce, I'm closing the issue for now. Feel free to reopen if you find a way for us to reproduce

New mail same problem :
code here : ici
Screenshoot on emailonAcid : ici

I think I've found the issue but you'll have to fix it manually.
It seems like having an image inside a VML block inside a mj-wrapper need to have a width & height in order to be displayed properly.
So just set the mj-image height to the actual desired height and it works fine.
Note that there's a bug with padding in Outlook inside a vml block, so you have to remove the left & right padding on mj-image to center it properly.
I won't reopen the issue because it's quirk of Word (only 2013 tho 🤔) and it looks we can't really do anything without image height here

yep i use mj-wrapper because i need a background behind everything ...but if you have a another idea i can remove the mj-wrapper

ok i can put a height on image in the MJML editor ? or i need do that in the html build ? because when i try on the MJML editor : height="xxx" or style="xxxx" they are an error "attribut target are illegal " ...maybe its better with the online editor ( no error ^^ )

@nanoarts Validation errors are just warnings, meaning that the attribute is not handled and will just be ignored. This kind of validation is just not done on the online editor ;)
target wasn't handled on mj-image when the last app release was made, but this will be fixed in the next version.
Anyway this has no influence on the handling of the length attribute 👍

yops , so i try to remove the warper and cut my backgorund for every section ...
Like that's :
https://mjml.io/try-it-live/HyWWcWe87
and always problem on outlook 2013 ..And now with lotus ^^" ( i hate emailing :D )

Just keep the wrapper and set the height to image as mentioned here:
So just set the mj-image height to the actual desired height and it works fine.


The operation couldn't be completed installing helper

my log id: fd78e761c0a01a1cb9a27f1c
Installer: 1.1.46
Privileged Helper: Re-Install, Install Error: The operation couldn’t be completed. (CFErrorDomainLaunchd error 9.), Error: XPC Error: Connection invalid, Error, Bundle Version: 1.0.29
Updater: Unknown,
Service: Unknown,
Fuse: Unknown,
Mount directory: Unknown,
KBFS: Unknown,
CLI: Unknown,

Log:
Version: 1.1.46
Installables: (
    "Privileged Helper",
    Updater,
    Service,
    Fuse,
    "Mount directory",
    KBFS,
    CLI
)
Install: Privileged Helper
Connecting to keybase.Helper (privileged=1)
Connected
Retrying (attempt=1, requestId=0) after XPC error: Error Domain=MPMessagePack Code=-10 "XPC Error: Connection invalid" UserInfo={NSLocalizedDescription=XPC Error: Connection invalid, NSLocalizedRecoveryOptions=(
    OK
)}
Connection invalid, clearing connection
Cleared connection
Connecting to keybase.Helper (privileged=1)
Connected
Connection invalid, clearing connection
Retrying (attempt=2, requestId=0) after XPC error: Error Domain=MPMessagePack Code=-10 "XPC Error: Connection invalid" UserInfo={NSLocalizedDescription=XPC Error: Connection invalid, NSLocalizedRecoveryOptions=(
    OK
)}
Cleared connection
Connecting to keybase.Helper (privileged=1)
Connected
Retrying (attempt=3, requestId=0) after XPC error: Error Domain=MPMessagePack Code=-10 "XPC Error: Connection invalid" UserInfo={NSLocalizedDescription=XPC Error: Connection invalid, NSLocalizedRecoveryOptions=(
    OK
)}
Connection invalid, clearing connection
Cleared connection
Connecting to keybase.Helper (privileged=1)
Connected
Max attempts reached (4 >= 4)
Connection invalid, clearing connection
Removing /Library/PrivilegedHelperTools/keybase.Helper
Installing helper tool via SMJobBless
Failed, retrying
Install complete
Privileged Helper: Install Error: The operation couldn’t be completed. (CFErrorDomainLaunchd error 9.)
Error: XPC Error: Connection invalid
Error, Bundle Version: 1.0.29

Ignoring leaves me with a Keybase window that just says "Loading…".

I have exactly the same problem, and I hope we can get proper help!
`Installer: 1.1.55
Privileged Helper: Re-Install, Install Error: The operation couldn’t be completed. (CFErrorDomainLaunchd error 9.), Error: XPC Error: Connection invalid, Error, Bundle Version: 1.0.29
Updater: Unknown,
Service: Unknown,
Fuse: Unknown,
Mount directory: Unknown,
KBFS: Unknown,
CLI: Unknown,
KBNM: Unknown,
Log:
Version: 1.1.55
Installables: (
"Privileged Helper",
Updater,
Service,
Fuse,
"Mount directory",
KBFS,
CLI,
KBNM
)
Install: Privileged Helper
Connecting to keybase.Helper (privileged=1)
Connected
Connection invalid, clearing connection
Cleared connection
Retrying (attempt=1, requestId=0) after XPC error: Error Domain=MPMessagePack Code=-10 "XPC Error: Connection invalid" UserInfo={NSLocalizedDescription=XPC Error: Connection invalid, NSLocalizedRecoveryOptions=(
OK
)}
Connecting to keybase.Helper (privileged=1)
Connected
Connection invalid, clearing connection
Retrying (attempt=2, requestId=0) after XPC error: Error Domain=MPMessagePack Code=-10 "XPC Error: Connection invalid" UserInfo={NSLocalizedDescription=XPC Error: Connection invalid, NSLocalizedRecoveryOptions=(
OK
)}
Cleared connection
Connecting to keybase.Helper (privileged=1)
Connected
Connection invalid, clearing connection
Retrying (attempt=3, requestId=0) after XPC error: Error Domain=MPMessagePack Code=-10 "XPC Error: Connection invalid" UserInfo={NSLocalizedDescription=XPC Error: Connection invalid, NSLocalizedRecoveryOptions=(
OK
)}
Cleared connection
Connecting to keybase.Helper (privileged=1)
Connected
Max attempts reached (4 >= 4)
Connection invalid, clearing connection
Removing /Library/PrivilegedHelperTools/keybase.Helper
Installing helper tool via SMJobBless
Failed, retrying
Install complete
Privileged Helper: Install Error: The operation couldn’t be completed. (CFErrorDomainLaunchd error 9.)
Error: XPC Error: Connection invalid
Error, Bundle Version: 1.0.29`
If we can't resolve this problem, I'm going to be locked out.

Take a look here for the solution: https://github.com/keybase/client/issues/8905#issuecomment-335267082


Unable to parse file

When I try to export this game that was made in Unity version 2019.3.7, I get this error on some files:
Unable to parse file <filepath> [Parser Failure at line <line number>: Expect ':' between key and value within mapping]
I'm using unity 2019.3.7.
The game was built with Unity 2019.3.7.
I'm using the latest build from Source Forge.
Help with this error would be greatly appreciated.
EDIT: Also I noticed that the scripts that are exported don't load properly.

I found out that the parsing error do not prevent the game from starting it's just the scripts that do.


drivers: can: mcan: fix transmitter delay compensation support

Remove broken support for Transmitter Delay Compensation from the Bosch M_CAN backend driver. Even if this was enabled via Kconfig, the TDC bit in the DBTP register set during driver initialization is overwritten in can_mcan_set_timing_data(), turning TDC off.
Remove the unused "tx-delay-comp-offset" property from the base CAN FD controller devicetree binding. Having a static Transmitter Delay Compensation (TDC) offset is useless. The offset needs to match the data phase timing parameters in order to properly configure the second sample point when transmitting CAN FD frames with BRS enabled.
Add a utility macro for calculating the Transmitter Delay Compensation (TDC) Offset using the sample point and CAN core clock prescaler specified by a set of data phase timing parameters.
Enable Transmitter Delay Compensation in the Bosch M_CAN IP backend driver whenever the data phase timing parameters allow it.

Fixes: #70447

I'll add the release notes in a separate PR in order not to break any backports.