Volume up and down not working at all

Consent

[X] I have searched the existing issues and verified that there is no open issue for the same subject.
[X] I understand that the YTMDesktop Elgato Plugin has NO affiliation with Google, YouTube or the YTMDesktop application.

Current Behavior
the buttons dont work
Expected Behavior
the volume should be able to be adjusted from the streamdeck buttons, this is mainly the reason I downloaded this plugin
Steps To Reproduce

Place the icon on the streamdeck
Doesnt work after that

OS
Windows
OS Version
10
Plugin Version
v1.7.0
YTMDesktop Version
v1.13.0
How did you download the software?
Elgato Store
Anything else?
N/A

This seems to be a /duplicate of #28
Please make sure you're on one of the latest pre-/nightly releases, because v1.13.0 isn't supported anymore.
If this issue still persist, feel free to re-open it.


Configure Postgres utility binaries path in PgAdmin

What
PgAdmin needs access to the normal set of Postgresql utility binaries (e.g
pgdump, psql), and the path to them is normally defined in config_distro.py.
However, when installing them via the Apt build pack, they end up in
/home/vcap/dep/{x}/bin/, and so we need to set that path explicitly in
config_local.py.
How to review

Code review
Deploy and check that the binary paths are set in PgAdmin

Who can review
Anyone

@AP-Hunt The binary path is set to /home/vcap/deps/0/bin/
However on attempting to export a table as a csv I get an error

This is proving tricky, because the problem is with loading Perl 5 modules .. and I'm not very familiar with that.
I've tried adding the modules path to the PERL5LIB env var, but that didn't help.


After Release 1.23 server don't expand folders

HI,
After the release 1.23 my servers don´t expand to see the folders (Databases, Security and Server Objects). After downgrade to 1.22.1 version worked. But I´d like to know how to fix this problem in 1.23 version.
Tkx

Duplicate of https://github.com/microsoft/azuredatastudio/issues/12992


Search doesn't carry over the "extra" arguments

While the search form action url includes extra arguments, they don't get propagated further. The extra augment get dropped since the method is GET. It is expected behaviour of the form according to https://www.w3.org/TR/2011/WD-html5-20110525/association-of-controls-and-forms.html#form-submission-algorithm . The extra args need to be treated the same way as filters: they need to be rendered as hidden fields.

Thanks @nad2000!
I'm adding a test for this, and then copying the same approach for handling extra arguments while filtering.


[Snyk] Upgrade org.webjars:swagger-ui from 3.48.0 to 4.10.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.webjars:swagger-ui from 3.48.0 to 4.10.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Warning: This is a major version upgrade, and may be a breaking change.

The recommended version is 25 versions ahead of your current version.
The recommended version was released 2 months ago, on 2022-04-04.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

User Interface (UI) Misrepresentation of Critical Information SNYK-JAVA-ORGWEBJARS-2314887
484/1000  Why? Has a fix available, CVSS 5.4
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@corcoja  I added 'swagger-ui', when moving to 'springdoc-openapi-ui' from springfox. This was done a while ago and no vulnerability was found in that version, at that time.


Add docs on adding a multiple choice metric

I've been working on porting Japanese tasks from https://github.com/Stability-AI/lm-evaluation-harness. This PR is not about the porting in general, but a specific issue I had implementing some metrics we have added, like balanced accuracy.
This PR outlines the process I went through to add a metric. I know the process outlined here creates a usable metric/aggregation, though I am not sure it is the best way to do things, so I wanted to open this PR against the README to 1. make sure I'm doing the right thing 2. help anyone else who has to do the same thing in the future.
My understanding is that adding a metric requires three steps:

Register a metric function
Register an aggregation function
Modify the Task.process_results function so the aggregator gets the right input

Is that reasonable?
I have to admit I found this a very confusing process, in particular figuring out step three. I wrote this guide as though it was for multiple choice tasks only, since that's what I had in mind when I was working on this, but looking at the code now it looks like maybe this is the same for all custom metrics?

Thanks for the PR, the metrics part of the code was meant to be abstracted away to configs for users to focus on. Currently thinking about how to make it easier to add metrics as I also think the metric_fn + aggregation_fn we inherited from the previous version could be simplified.
Also depending on your metric, you might even just need to implement a different aggregation. That way, in a config you can write:
- metric: acc
  aggregation: balanced

Thanks for the feedback.
In this case I can't use metric: acc because that changes the arguments to the aggregation function, and I need (gold, pred). So I could use another metric like f1 and it would do what I want, but then the names in the config would not make logical sense.
I have to admit I don't understand why you have the metric/aggregation distinction - it seems to only make sense for very simple metrics like accuracy, and I noticed most of the metric functions mention they are just passthrough functions.
It feels like it would make sense to move the logic in Task that I reference in the README into the metric functions directly, but there's a lot of code there and I haven't spent time to work through all of it yet.

This isn't much different from lm-eval pre-refactor that needs the aggregation to be define separately from the per-sample performance metric. It's just that here both the metric and the aggregation are abstracted away and can be called from the config.
    def aggregation(self):
        return {
            "acc": mean,
            "acc_norm": mean,
        }

It's not ideal but it's meant to be permanent either.

Thanks very much for this PR and for the feedback!

My understanding is that adding a metric requires three steps:
Register a metric function
Register an aggregation function
Modify the Task.process_results function so the aggregator gets the right input
Is that reasonable?
I have to admit I found this a very confusing process, in particular figuring out step three. I wrote this guide as though it was for multiple choice tasks only, since that's what I had in mind when I was working on this, but looking at the code now it looks like maybe this is the same for all custom metrics?

The process is currently only this way for multiple choice metrics (and we certainly should improve this, in particular eliding step 3 so that one does not need to understand the entire codebase). For tasks that are generation-based, you should be able to simply add the metric and aggregation function and then just use the metric within the YAML.
I think we could merge this PR with the documentation as it stands now, and proceed to work on potentially removing the metric/aggregation distinction as well as in general improving the user experience adding a new multiple choice metric (likely refactoring out the multiple choice task's process_results() so that the behavior can be controlled by metric function implementations).

Maybe we should create a documentation file called "Advanced Usage Guide" which is for people who want to add things other than Tasks and Models, and include this there instead of the readme? I worry that setting the expectation that everything like this will go in the README will result in a substantial amount of clutter.

This currently is placed by this PR in docs/task_guide.md , which has been the designated place for all highly advanced configuration / addition instructions.
We could certainly further split the (Advanced) Task Guide into an additional docs page made only for those who'll need to go beyond advanced YAML configurations if desired / if it gets too cluttered.

Oh that works! I didn't look, just saw that the OP mentions the README. Sounds good.

Thanks very much @polm-stability for your feedback and this documentation!
Merging, with the understanding we’ll have to update this documentation since we have a change/improvement to this pain point incoming soon.


Add subdownloader

Hi,
I have made a CLI utility to download subtitles for movies and TV series.
you just have to execute a simple command to download subtitles for one or more file at a time.
I am using it daily and its very helpful hope it can help others too
https://github.com/beatfreaker/subdownloader
Thanks :smiley:

Nice!
One improvement I would consider is to split it into a CLI module and API module. That would make the code cleaner and allow other people to use the code programatically.
Example:
https://github.com/sindresorhus/hasha-cli
https://github.com/sindresorhus/hasha

Thanks.
Will implement the suggestion give in couple of days.


Implement spectral centroid

A measure of "brightness".
References (AD/MCI):

Beltrami et al. (2016): spectral centroid mean consistently a significant feature across tasks.
López-de-Ipiña et al. (2013)
Sumali et al. (2020)

Parselmouth implementation here.


Tunable controller options, and context aware logger :tada::tada::tada::tada::tada:

Code of the initial commit, contains using of klog directly, which is not a best practice when implementing controller using controller-runtime.
The controller runtime provides a context aware logging mechanism. It logs the context (resource name and namespace), and in a message plus parameter style. So we can search the message, to locate the code, and know the context through the parameter. Since log is not UI, format string can provide readable content, but it's not friendly for debugging.
Furthermore, the context logging is a wrapper, it supports numerous backend like klog, zap, etc. When use with klog, it can consume the -v option, so the  V could not only affect with our code, but also affect with the controller runtime itself.
Introduce a plugin like command line flag parsing mechanism, can help to define some module specific command line argument, in this way, we not need to define the command line argument in main.go or somewhere far away from the module logic code.

Thanks for your suggestion and contribution


feat: feat: add the much awaited create playlist page

I'm wondering rn why the actions are failing 🤔

I don't like having to hack the PR workflow.
I'd have to look into why it failed for this PR tomorrow. But for tonight, the hack would work


settings: Do not scroll to save button when typing in textarea / input.

In an unsaved state, when focus is in a textarea or an input of type text, we don't yet scroll the save button into view to not interrupt the user's typing. When the input / textarea loses focus, we scroll then if needed, triggered via the change event.
Fixes: issue reported on CZO here

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Works well in manual testing, and the code changes here look good to me. Marking for integration review.

Merged, thanks @N-Shar-ma!


Fix MM46418

Summary
https://github.com/mattermost/mattermost-mobile/pull/6578 added a workaround to fix an issue with scheme_admin. By looking at the code, the only possible issue I found is that we were observing the list and not observing with columns.
This should solve the issue.
Ticket Link
https://mattermost.atlassian.net/browse/MM-46418
Release Note
Technical debt

@cpoile Can you verify this is indeed not resurfacing the issue you saw in the original PR? Thanks!

@larkox I'm not sure, you would have to go through the reproduction steps -- do you want me to do that? (It might have to be later in the week then.)

@cpoile I would prefer if you did, since you know the best what and how it failed. This doesn't seem to be a time critical issue, since it is just about removing the patch that makes sure it works, so I am ok waiting.

@cpoile can you please test this?


Pre-populate image in Harbor registry

Pre-populate image Rancher hello-world (or anything which is more suitable e.g. nginx) to Harbor registry

@surajyadav-git Would you please specify which image to be pre-populated?

amended the terraform script to upload the required image to harbor registry in cd266d0803f6817a0e52e61c859e586b0f35551f


Potential issue with reflect.DeepEqual code

What version of Go are you using (go version)?

$ go version
go version go1.13.7 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/XXX/Library/Caches/go-build"
GOENV="/Users/XXX/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/XXX/.gvm/pkgsets/go1.13.7/global"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/XXX/.gvm/gos/go1.13.7"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/XXX/.gvm/gos/go1.13.7/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/XXX/Documents/WORK/SquareScale/HASHICORP/terraform-provider-aws/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/k0/35x3347j4s18t_h4z932f3nr0000gn/T/go-build598493337=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
See issue # 11059 in Terraform AWS Provider
and more specifically this part
DeepEqual fails because of the following item which is however perfectly identical in both cases:
 F: (schema.SchemaSetFunc) 0x4ec7530,

What did you expect to see?
If pointer addresses are identical true should be returned so something like:
	case Func:
		if v1.IsNil() && v2.IsNil() {
			return true
		}
		// Can't do better than this:
		return v1 == v2

might be better (IMHO)
What did you see instead?
DeepEqual returns false

After reading a bit more about function comparison, which does not seem very obvious, may be we could just parameterize the DeepEqual call so that this check can be disabled ? Just wondering ...

Per https://golang.org/ref/spec#Comparison_operators:

Slice, map, and function values are not comparable. However, as a special case, a slice, map, or function value may be compared to the predeclared identifier nil.

And per the reflect.DeepEqual documentation:

Func values are deeply equal if both are nil; otherwise they are not deeply equal.

Any change to that behavior would violate the Go 1 compatibility policy.

Sorry, we aren't going to make this change in reflect.DeepEqual.  There are many possible ways of doing equality comparisons.  DeepEqual is one of them.  Many people find it useful, but there are many possible variants.  We don't want to try to provide all those variants.  You can use DeepEqual as a template for your own equality function.

@ianlancetaylor @bcmills many thanks for this feedback, I fully understand.Many thanks again


Add derivation for ocs-url

Signed-off-by: Soham S Gumaste<EMAIL_ADDRESS>Description of changes
Add ocs-url to support one click installs from DE store pages like kde-store.com
Add .desktop file for handling ocs:// URI The build produces the needed desktop file for handling ocs:// URI

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[??] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

I cant get editorconfig to work on my emacs or vs code. Please could someone tell me how I could fix the error?

@trofi Thanks a lot for the review. I'll get to implementing the changes.

One more thing which is possibly related to Qt wrapping. Does the app start for you as is? Does it need KDE or something similar? Here is my failed attempt:
$ nix-build -A ocs-url
/nix/store/2b41jn5ldbrp4ish3lgpp5x5f8chs3bv-ocs-url
$ LANG=C ./result/bin/ocs-url
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

The following change gets something that runs for me and shows that I typed invalid URL:
--- a/pkgs/tools/misc/ocs-url/default.nix
+++ b/pkgs/tools/misc/ocs-url/default.nix
@@ -19,9 +19,8 @@ stdenv.mkDerivation rec {
   ];

   sourceRoot = "ocs-url";
-  dontWrapQtApps = true;

-  buildInputs = with libsForQt5.qt5; [ qtbase qtsvg qtquickcontrols qmake ];
+  buildInputs = with libsForQt5.qt5; [ qtbase qtsvg qtquickcontrols qmake wrapQtAppsHook ];

   # We are NOT in $sourceRoot here
   postUnpack = ''

Works for me as is now. Thank you!


Find and replace across worksheets in excel

Is there a way to do a find and replace across multiple worksheets in one excel file?  I have some values listed in cells in one worksheet and I'd like to be able to find that value and replace it with something different from another cell in a second worksheet.  Similar to a vlookup.  Thanks.

There is nothing built into the PowerShell module to do that. You would need to loop through all the sheets and cells and use PowerShell to find and replace.


Placeholder for %jobsr_jtop_name_[jname/number]_[[1-15]]%

Description of new idea or improvement on existing one
Changing the "%jobsr_jtop_name_[jname/number]_[[1-15]]%'s result to be just the "In-Game Name" itself
Detailed information what should do
I tried using the placeholder, but it seems like it turns with this

Even though the code for your placeholder is this:

Is there a possible way that to have an option whether it will have a "Preffix" or Change displayname or to just have In-Game Name itself?

Its returning players display name as being defined by plugins which manages this part. Showing players actual name can work if you are not using nickname commands and players name remains same as his displayname, other than this you would need to adjust how players display name is being defined by plugin which manages it, basically we are showing same thing as you would see in tablist.
What I can do is to simply add new placeholder which would show players name instead of his displayname.
260470406e09060a93b0fda84dccdf0ac4e62d3e


Uses the "util" standard package for message interpolation

GitHub

Fixes https://github.com/mswjs/msw/issues/844

Changes

BREAKING: the package no longer exports the interpolate function.

My only issue with https://github.com/browserify/node-util is the size increase. That library is over 10x the size of https://github.com/tmpfs/format-util
Both are maintained.

Good point. The tests are passing with format-util, I'll try it in another codebase that uses outvariant and update this pull request.


Rotation

Description of the new feature / enhancement
A simple screen rotaion shortcut
Scenario when this would be used?
rotate
Supporting information
No response

Can you describe in more detail the scenario where this is needed as a shortcut? /needinfo


Add Asset D.O.G.E.

Please review the following token
📑 Description
Department Of Government Efficiency (DOGE) Memecoin Community

Token Name: Department Of Government Efficiency (DOGE)
Project Website: https://dogegov.com
Explorer URI: https://basescan.org/address/0x67f0870BB897F5E1c369976b4A2962d527B9562c

✅ Checks

[x] I created a new folder with the token address (all in lowercase for EVM chains, case sensitive for Solana)
[x] I added the token's logo as a 32x32 PNG file, named logo-32.png
[x] I added the token's logo as a 128x128 PNG file, named logo-128.png
[x] I added the token's logo as a SVG file, named logo.svg
[x] My SVG logo is a proper SVG and not some base64 stuff
[x] My documentation/website clearly display the token address somewhere

please move the logos to the 8453 directory and also upload a true SVG that is completely vectorized. It can't contain links to a PNG


Introduce query/timeout/count metric

Follow-up PR to #10464.
This PR adds a new query metric query/timeout/count that represents the number of timed out queries during the emission period. Timed out query counts were previously clubbed under query/interrupted/count. Having a separate metric for timed out queries can make it a little easier for cluster operators to diagnose query issues better.
Marking this as Incompatible as query/interrupted/count no longer represents timed out query counts and user defined alerting/reports may need to be adjusted to factor in query/timeout/count along with query/interrupted/count.
It would be useful to add metricsMonitors to integration tests so that it provides better testing for PRs such as this.

This PR has:

[x] been self-reviewed.
[x] added documentation for new or modified features or behaviors.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

This looks good at initial glance. I'll test and submit a review tomorrow when I have some spare time


v6.0.0 - sample check inversion, profile => spans, major overhaul, and cleanup

removed RUM artifacts
removed Profiles
moved sampling decision from Event constructor to function calling Span constructor.
[API BREAKING] changed API signature of Span

3rd argument is settings object, not xtrace/parent
3rd argument must contain {inbound, doSample}
3rd argument optional {metadata}
inbound (boolean) the span is a top level span as the result of an inbound request. it will either start a trace or continue one from an external source.
doSample (boolean) sample this trace or not.

[API BREAKING] changed API signature of Event

3rd argument is metadata to use for the event creation.
4th argument is whether to edge back to the metadata or not. (might be able to avoid this).

stringToMetadata() consider error if opID is all zeros (call lower level bindings fn to avoid)

takes check out of probes/http.js

packages with probe naming considerations (and their tests)

director
express
koa-resource-router
koa-route
koa-router
restify

moved KV pairs out of event and into event.kv https://chromium.googlesource.com/external/github.com/v8/v8.wiki/+/60dc23b22b18adc6a8902bd9693e386a3748040a/Design-Elements.md
stubbed new function bindings.Context.getTraceSetting() for use by entry/root spans.
added XgetTraceSettings() to appoptics-bindings/napi-branch. will become replacement for all entry/root spans.
[API BREAKING] change signature of span builder function in startOrContinueTrace, instrument, runInstrument, instrumentHttp. This impacts many tests.
move all decision/metadata generation logic into bindings.Context.getTraceSettings(). (this is implemented in index.js until there is a production tested oboe ready to go with the API in it. when that's ready the code will start using the oboe facility and the javascript implementation can be removed.)
modified span builder function return value's finalize function: spanInfo.finalize(span, previousSpan)

(this is not ready to merge yet - depends on appoptics-bindings v6 for correct metrics decisions. in process of running the test matrices for this massive change. first release will be 6.0.0-rc and tagged "rc" so as not to be default install.)

I created the 6.0.0 branch to perform a selective squash merge (git rebase -i master) with so this branch is no longer needed.)


Transfer from pip packaging into git module type packaging

Want to configure the server context git sub module instead of pip packaging

That sounds good. I just created a new repo here. We can use this repo as a git sub-module for configuring different cluster profiles.
With that being said, let's aim to add/create different Snakemake profiles for each of the clusters: Biowulf, BigSky, Skyline, SLURM (generic option).


10/25/2018 01:47 : Create Pull Request for branch prTesting_2018102501 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Make class transforms work with multi-method specifications.

We had never tested or used the methods= kwarg when given as
a dictionary for multi-method transforms.  A dumb assert was breaking
it, this was remedied and the common transforms' arguments were made
"positional_or_kwarg" so that this method of transform specification on
classes will work with them.

Codecov Report

Merging #1832 (bd2517f) into main (fb77118) will increase coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
+ Coverage   70.31%   70.38%   +0.06%
==========================================
  Files          58       58
  Lines        4865     4865
==========================================
+ Hits         3421     3424       +3
+ Misses       1444     1441       -3

Impacted Files
Coverage Δ

flax/linen/transforms.py
95.60% <50.00%> (+1.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb77118...bd2517f. Read the comment docs.


Dependency and CI update

Go updates

Updated to go 1.20
Updated all dependencies

Test fixes

Updated sample files and URLs
Added testify/require in some non-checked scenarios
Updated some old references to ioutil only in the tests I modified

CI updates

Upgraded all actions to their latest versions
Tests are only done in the go version set up in the go.mod file.

coverage: 86.799%. remained the same when pulling 6b4f4cfeae562e23204cfc93e62a9a9e65d47f7c on fmartingr:update-dependencies-and-ci into 5d94be3832c247b4e642130569e3864a2439aca3 on bmaupin:main.

Thanks for your contribution!
I'm wondering if this is a bit much for one PR ...

I can see how pinning the github-actions to specific commit hashes would prevent builds from breaking, but it also seems like it could be a lot of work to keep it updated. I suppose the solution to something like that is dependabot? Speaking for myself, it's not something I really want to invest the time in to keep up-to-date, at least if everything is working fine (aside from the one broken test of course :sweat_smile: )
Why remove tests for older versions of Go? Ah nevermind, I see that support for Go 1.15+ was removed. Is this necessary? I'm not sure if anyone using this needs support for Go 1.15, but I don't see any reason to break it if it's working.
A new test image was added, which by itself isn't significant, but the old test image (gophercolor16x16) wasn't removed and the new test image is larger than the old one. Why the change? A small test image was purposefully chosen to keep the size of the repo small
Local test video/audio files were replaced with blank files. Again, why the change? The files are already in the repository history at this point so they're not taking up any extra space. I haven't checked out the code but I'm surprised this isn't breaking the mimetype of the file.
A new dependency was added. From experience I think it's probably best to keep dependencies to a minimum when possible, especially for libraries which can get used in a lot of places. Sometimes the tradeoff is worth it, particularly when new functionality is added. But in this case, require just saves a couple lines of code to check the error code

In particular, the broken test definitely needs to be fixed but I would consider upgrading to Go 1.20 to be a breaking change, and I would hesitate to force users to upgrade to Go 1.20 just to have fixed tests.
Let me know what you think. Also if there's any way I can update the contribution guidelines to be more helpful, let me know: https://github.com/bmaupin/go-epub/blob/main/CONTRIBUTING.md
... at the very least it might be worth adding a note about dependencies.
(Also @owulveryck feel free to chime in if you have any thoughts)
Thanks!

I am on vacation with limited access, but from what I see I fully agree with you @bmaupin especially on the maintenance of the CI dependencies (with the commit numbers).
On the other hand, I think this PR is mandatory, as the CI and dependencies needs some updates.

I forgot about updating dependencies :man_facepalming: I guess that's what happens when there's too much in one PR. I see now that the update to Go 1.20 is necessary in order to update the dependencies.
At any rate, I agree, we need to update dependencies.
But before we do anything, we need to fix the tests. They're failing due to a simple broken URL.
I'm wondering if there's a better site we could use that would be less likely to change (or get taken down in the future). Given that the current URL broke, I'd be hesitant to use that same site again. But maybe I'm being too idealistic :)
I did find this, which seems as good as any:

http://placehold.it/ may be the one you are looking for:
http://placehold.it/120x120&text=image1
http://placehold.it/120x120&text=image2
http://placehold.it/120x120&text=image3
http://placehold.it/120x120&text=image4

and you even can tell sizes and labels.

https://superuser.com/a/461451/93066

I've been out of the Go world so long, I didn't realize that updating dependencies would force the version of Go in this project to be updated as well. So that explains many of the changes here.
But that's still a major breaking change, right? If this library now only works with Go 1.20, that seems like we'd need to bump the version to v2. Which shouldn't be too big of a deal, it's just a version number.
I'll try to address any remaining issues by adding code reviews.

As general comment, I think is best if an http server is used during the tests for the URL downloads rather than downloading files from the internet, but I don't think you want me to address a change like that here?

I have fully reverted the changes to tests (because now the URLs works for me? Don't know what happened, but tests where failing for me on requests 🤷). I can do separate PRs to move the tests to an http server and to fix all deprecations being used, maybe even add a golangci-lint to actions as well.

I have fully reverted the changes to tests (because now the URLs works for me? Don't know what happened, but tests where failing for me on requests shrug). I can do separate PRs to move the tests to an http server and to fix all deprecations being used, maybe even add a golangci-lint to actions as well.

Thanks so much, that sounds great! Thanks for your contribution!


Unable to nullify string attribute using the update function...

Currently, string values on any of the data structs have the omitempty tag associated with them. Because of this, if I try to set a string value to it's nil value "", json.Unmarshal and json.Marshal leave off that attribute. This is a problem when trying to update a string field that I want to unset.
Steps to reproduce (using a variant as example):

[ ] Create a variant with v.InventoryManagement = "shopify"
[ ] Set v.InventoryManagement = ""
[ ] Call shopify.Variant.Updated(v)

Expected: The returned updated variant should have v.InventoryManagement == "" and that variant should no longer be set to have shopify track inventory.
Actual: The returned updated variant has v.InventoryManagement == "shopify" and that variant has no changes to it's inventory management in the admin console.
Proposed fix: Convert the string values to string pointers so that they can be explicitly nil-able.
If I'm thinking about the problem incorrectly, I'd love some feedback on how to unset string properties.

I can confirm that when I remove the omitempty from Variant.InventoryManagement the API call works as expected. I suppose an alternative solution to using string pointers would be to just remove the omitempty tag on all string attributes.

Update: As a work around I used the custom data structure workflow to create a variant that didn't  have the omitempty tag associated with its strings. I still think a better solution would be to have primitives be pointers and not have the omitempty tag but that may not be correct.

@ckeyes88 thanks for the comments and sorry for the trouble. I haven't been using this feature for a while, but according to the documentation, it sounds like the inventory_management is not meant to be set to the empty string:

If you track the inventory yourself using the admin, then set the value to "shopify". Valid values: shopify or the handle of a fulfillment service that has inventory management enabled. Must be the same fulfillment service referenced by the fulfillment_service property.

As such, I would be hesitant to remove the omitempty flag in this case for everyone, because it doesn't seem like the inventory management field is supposed to be empty in the default case? What do you think?

@dlebech Thanks for the response! I agree that it should not be set to "" in the API but rather null. I'm certainly not a shopify API expert so I'll defer to your judgement. However, when a product is first created with no inventory management tracking the value is null which when using a primitive string value in Go defaults to the nil string value of "". Once inventory_management is set to any valid value the only way that I know of to stop tracking inventory for that product is to nullify the inventory_management field, which again with the string primitive would be to set it to the empty string and have json.Marshal convert that to null. This is why my initial thought was that primitives that are optional should be pointer values so that people can explicitly set them to nil if they want to remove them altogether.

@ckeyes88 I see your point. When inventory management is initially unset, it will remain unset forever because of the omitempty, but if you want to completely unset a previously set value, you're out of luck. That's the gist of it right?
If we removed omitempty and changed the string to a pointer, it would correctly marshal to null, but for partial updates of other fields (e.g. if I just wanted to update the Price), inventory management would suddenly always be reset because it is null. That might lead to some confusion?
Because of the support for partial updates, it feels like omitempty is the safest thing to do. Do you have an idea to get around this? Perhaps we could consider making explicit reset methods for use-cases like this where resetting a field to null is a valid thing to do. Something like ResetInventoryManagement.
Would love to hear what others have to say about this. I think it's a bit of a conundrum, even though it seems very simple :)

Just adding some more reference information from an issue on the Go-Github sdk discussing the exact same problem and potential solutions.
More fuel for the fire

@ckeyes88 thanks for the links. This is perhaps an issue that can be tackled as part of some larger updates of the library since it also might require a breaking change.


handle_unary() not working?

Hi,
The following unary expressions break:
Expr '3 * -4' -> -4
Expr '3 / -4' -> inf
Expr '3 - -4' -> -1
Expr '3 + -4' -> -1

Code used is very basic:
#include <iostream>
#include "shunting-yard.h"

int main(int argc, char* argv[])
{
    TokenMap vars;
    vars["pi"] = 3.14;

    std::string str;
    for (int idx = 1; idx < argc; ++idx) {
        if (idx > 1)
            str += ' ';
        str += argv[idx];
    }
    std::cout << "Expr: '" << str << "'\n";
    std::cout << calculator::calculate(str.c_str(), &vars) << std::endl;
    return 0;
}

It seems rpnBuilder::handle_unary() is not creating the correct RPN output for the above cases; debugged RPN output of the above show:
compile: '3 * -4'
    RPN: TokenINT(3) TokenINT(0) TokenOP(*) TokenINT(4) TokenOP(-)

compile: '3 / -4'
    RPN: TokenINT(3) TokenINT(0) TokenOP(/) TokenINT(4) TokenOP(-)

compile: '3 + -4'
    RPN: TokenINT(3) TokenINT(0) TokenOP(+) TokenINT(4) TokenOP(-)

compile: '3 - -4'
    RPN: TokenINT(3) TokenINT(0) TokenOP(-) TokenINT(4) TokenOP(-)

Uhm, that is true! It was easy to reproduce, I wonder how it wasn't detected before. I will work on it.
Thanks!

Fixed @chan-tw, it seems I added this bug not long ago and there was not test to prevent me from doing it. I added a new test and fixed the bug.
Also, sorry for the delay for reading your post, either github did not bother to sent me an e-mail or gmail blocked it.

@VinGarcia Thanks, good fix.


Extract ReqContext from Endpoint

Extracted from PR #2860. Mainly moving code. Almost no logic changes.
Please merge PR #2827 & PR #2888 first.

/run-integration-tests

This PR is reviewable now. Friendly ping @AndreMouche @hicqu

/run-integration-tests

LGTM.


Last merging from branch dev to branch main after feedback

"Last merging from branch dev to branch main" until the next 😆

last from the last merging from branch dev to branch main until the end of the world


settings .ini

by default maxfps = 125, I think it would be better to use maxfps = -1 for most, there is no need to load weak video cards
[C&C95] [C&C95] [C&C95] and other profiles use maxfps = 60
I think it is necessary to remove these lines, which were most likely added automatically, and are simply confused, there is no usefulness for individual applications from this
disable automatic addition of the maxfps = parameter to application profiles, for most it is enough to use the global parameter, the more it depends on hardware rather than individual applications

Most games will not go above 60 FPS, so it's fine to have 125 maxfps (they will still render at 60 FPS). I only set it to 125 for C&C games, it helps a little to reduce the input lag for competitive online multiplayer.

Setting it to 60 + using forcefps=true will fix the flickering cursor. Campaign players complained about it so I set it up like this. 125 is used for online multiplayer because it's using a different executable and online players don't care about the flickering cursor, they rather have less input lag instead.

I only set up maxfps for cnc games to fix the flickering cursor, I will not use it for any other games

I only set up maxfps for cnc games to fix the flickering cursor, I will not use it for any other games
but used global parameter maxfps=125
I think you will correct it later, as I understand it, globally =-1, but for games c&c =125?

60 + using forcefps=true will fix the flickering cursor.
if using -1 globally, then fps will be ~ 60 on most monitors
but in profiles c&c is now set maxfps = 60, not 125

Yeah I could set 125 for the cncnet *-spawn.exe files and 60 for c&c single player .exe  files and global -1. That would work too

@FunkyFr3sh thanks, sort of figured it out


variable name could be improved

https://github.com/sector-f/failoverd/blob/672ed3011898df9287a34ca04b264988bc411f2b/main.go#L27
I suggest 'pinger' please let me know what you think thanks

Per Practical Go, "Short variable names work well when the distance between their declaration and last use is short."
Given that p is the primary focus of the main function, and that the main function is not very long, I am not convinced that the proposed change would actually improve readability.

fair!


⚛ Refactor library to use modern react techniques

NOTE:
2.0.0 will be rewritten from the ground up and thus this will no longer be a fork of Kaktana. You can follow the work on the new version at https://github.com/Qognica/react-lightweight-charts, which will be replacing this repository when it is finished

How do i update the candle stick chart from API call?


makeSubscription and getChannelNames wrong packet (as far as I can see)

I've been trying to use this library for a couple of days, and both makeSubscription and getChannelNames hasn't quite been working for me, so I opened up a dante controller and wireshark and went digging.
For the getChannelNames packet it looks like the commandID is 0x2000, and in the original code it's 0x2010 (lines 143 and 95), once I changed to 0x2000 I got the correct reply from the devices in the wireshark. Then next stage was writing the packet back to the deviceList array in the code, which I see was commented out and so I re-worked both the parse command and the array structure but that's for a later discussion.
For the makeSubscription as well as clearSubscription it looks like one of the arguments in commandArguments was wrong, once again when sniffing packets myself from a dante controller the command to make a subscription has the bytes after the destinationChannelNumber as 0x005c005f (I don't understand what each part of this packet represents, but it was consistent between different subscriptions as well as different devices, however I only tested this in my local system and maybe it's supposed to be something else elsewhere?) as opposed to the bytes hard coded in the library (line 231) where the bytes are 0x0005006d. Another this is the data length was considerably longer than what I saw in my system, and so I changed the padding (line 232) from 107 bytes to 83. Only after changing both did the command work. Same with clearSubscription, there it was just the padding but I fixed it as well.
I'm pretty new to this whole open source thing and don't really know what pull request etiquette is, so I figured I'd first open the issue and ask you how you like to proceed (if at all, of course).

update:
I figured out what the line is at line 231 (where the bytes 005c006d are hard coded into the buffer) - the 005c is the location of the source channel name and 006d is the location of the source device name within the buffer. So far it looks like the padding in the middle of the buffer are at a static 74 bytes no matter the length of either the device name or channel name, but that might change with different flows? need to look into it. In any case changed the code to calculate the correct values for those bytes.


Add clear_task_if_completed function to WorkerThreadPool

Currently every task must be waited on (wait_for_task_completion) for their resources to be removed from memory (https://github.com/godotengine/godot/issues/84888). This is addressed in the docs however said solution may not always be intuitive or ideal as the function known as "wait_for_task_completion" is used even in cases where no waiting is necessary as it does the double duty of waiting, and also clearing memory.
While it makes sense that if you wait for a task, and it finishes, it should be cleared from memory, it is not always intuitive that you HAVE to wait for a task that you know is completed (via is_task_completed) to prevent a memory leak.
This can currently be circumvented by using an if statement (if is_task_completed: wait_for_task_completion) however said usage is ugly and also unintuitive.
This commit adds a function which checks if the task is completed, and then returns true and clears resources if so. Essentially doing the same job as wait_for_task_completion if already completed, HOWEVER not binding the main thread (or the thread it is called from) in the case the task isn't.
This allows for resource clearing without accidentally pausing the entire thread if not completed, in the case of a non essential functions such as saving (which can be allowed to operate in the background without pausing the entire game/main thread)

Just merged the commit since most of the test seemed to have been working after the small fix :D

Ah I need to update the documentation, 1 second

Why not go overboard, make a new function named clear_task_when_complete which will automatically handle cleaning it out of memory? Sure, you can't wait on the task anymore, and you cant check when it finishes, but neither this function as well.

I was thinking it'd be nice to have a way for the developer to manually clear a task (and acknowledge that it was finished via the bool) without having to call the wait function, but yeah I think it's a good idea to implement a auto clear task function like you suggested.
Atleast for me I think having something like this would be nice in general though in the case the programmer needs to acknowledge the task being completed in a way which isn't as time sensitive as using a whole wait for.
I'll work on implementing a auto clear function as well though

I'm not quite sure this adds significant value. On the one hand, the current API is designed to mimic joining threads. Being that the case, code using the threadpool would be designed in a way that the need for something like this is avoided in the first place. On the other hand, while there may be scenarios where this may be useful, given how wary we should be of growing the engine, let alone its core, there should be a proposal, backed by a high amount of real-world demand. Other approaches would be discussed there. Also, maybe other ideas such as renaming wait to join could be scheduled for future releases, for instance.

Another idea I just thought of was combining the is_completed function that was already there with the function I wrote, giving a bool (or possibly just clearing the memory on true) which would dictate if the task would be cleared from memory as well!
Wanted to write it here as well since I just thought of it haha

All those ideas may have merit, but the point about needing real-world examples and discussing alternatives and roadmap in a proposal stands.

Alright! I'll start working on writing a proposal for the ideas I have and see what people think of them then! Thankyou for reading over what I had so far (I know it's alot haha)


feat(stack-creation): add the ability to specify git credentials

Close #1554
This PR introduces breaking changes as some parameters of the stack creation request have been renamed:

GitRepository -> RepositoryURL
PathInRepository -> ComposeFilePathInRepository

An image for this implementation is available via portainer/portainer:pr1722 (linux amd64 build).

@deviantony please let us know when you fix the build, thx !

An access with credential is not really useful IMO, I don't think we want to put our credentials on portainer, we could create a specific user with restricted access but it's really complicated, an ssh access would be way better.
Github, gitlab, they all have a concept of deploy key that can be used for this purpose, you can only clone the repository and it's a read only access.

@dcharbonnier sounds great and will probably be added as an enhancement. As a first step, I think that using inputs for credentials is fine (note that these credentials are not stored in Portainer).

ok @deviantony, so this PR works for me, I tested it.
Just I won't use it because IMO the point of taking a stack from a git url it to be able to version the stack and to update it with a simple button and the API.
If I have to destroy the stack and create a new one I don't see the enhancement but if some people want it it's done.

@dcharbonnier thanks for the feedback, now that this one is merged, feel free to open a feature request for that SSH support enhancement (we actually need to discuss about the UX for this one).


MRM-2051: upgrade dom4j due to cves

https://issues.apache.org/jira/browse/MRM-2051

@olamy I think the build failure in this PR is due to an issue with building docs that already exists in master branch - see https://pipelines.actions.githubusercontent.com/serviceHosts/93d3319c-2bda-4a44-b72d-644bc2d32974/_apis/pipelines/1/runs/264/signedlogcontent/3?urlExpires=2022-06-01T14%3A47%3A12.1341364Z&urlSigningMethod=HMACV1&urlSignature=REQ8ihqXSrHsEF03df5CfnKHQTnsGj6MPVJrUZhOGP8%3D

@pjfanning ooops correct I have fixed that now. maybe rebase your PR?


Updated python code

Changed Single-line import to multi-line imports according to PEP-8

Thank you for you contribution to the repo and the community


TypeError: host.split is not a function

Just updated to the latest version 0.5.54 but get this error when starting up HomeBridge:
[2018-1-1 20:59:42] [Philips Hue] homebridge-hue v0.5.54, node v8.9.3, homebridge v0.4.33
/usr/local/lib/node_modules/homebridge-hue/lib/HuePlatform.js:69
const elt = host.split('.');
^
TypeError: host.split is not a function

Could you please post your config.json?

{
"bridge": {
"name": "Homebridge Hue",
"username": "DD:21:3E:E2:DE:45",
"port": 51827,
"pin": "031-45-165"
},
"description": "Configuration file Homebridge Hue",
"platforms": [
{
"platform": "Hue",
"name": "Philips Hue",
"host": ["<IP_ADDRESS>"],
"users":
{
"001733FFFE20C331":"XaqXrRx5IB8oJvsivvJnUizSwwXUb6MOAI3KetdfO"
},
"lights": true
}
],
"accessories": [
]
}

Thanks.  As I expected.  If you remove the [ and ] or change the key to "hosts"<EMAIL_ADDRESS>won't crash.  Will publish v0.5.55 shortly, which once again will accept this config.json.

Fixed in v0.5.55.


[Feature]: Shift Rust info inside Blockchain card

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

i'm done with this. shd i create a pr?

@piyushw0203 yes go ahead

Issue resolved.


#12919: Cleanup relu_bw, acosh_bw, and few other ops

This is a sub branch PR that is created to simplify the work on branch virdhatchani/set_2_clean as

There is a lot of code line changes involved
CI cannot be re-run if I push a new commit into main branch

https://github.com/tenstorrent/tt-metal/actions/runs/11047532826 - passed
Hence Merging PR


how can set default for block: ${env.PICASSO_BLOCK_NUMBER}?

for example,
block: ${env.PICASSO_BLOCK_NUMBER:-42}

how it is in bash.

we using _.template to process the config file https://lodash.com/docs/4.17.15#template
https://github.com/AcalaNetwork/chopsticks/blob/b2d9b7dc3907e3c963b70f6e096e80521ae6ae2c/packages/chopsticks/src/cli.ts#L28


[NetAppFiles]Anf 27235 update for 2022 11 01

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

"API Readiness Check" fails.
@audunn what is the expected date that the new api-version get roll-out?

/azp run

/azp run

@weidongxu-microsoft can you have another look to see if we are ready to move this along?

@audunn
Yes, I think all is good. Do you want me merge it now?

@audunn
Yes, I think all is good. Do you want me merge it now?

Yes, thank you


Team text editor sync

Describe the bug
While working on a team task, the shared text editor does not sync the inputs properly if multiple people type at the same time. The words are typed, then disappear and reappear at some random position in the textbox.
To Reproduce

Go to any Team task with text exercise
Click on "open text editor"
Write in the field with multiple people at the same time
See bug

Expected behavior
We expect it to sync properly like any collaboration tool. If it doesn't work, disable the input for the other users while one is typing.
Screenshots
No response
Which version of Artemis are you seeing the problem on?
7.0.2
What browsers are you seeing the problem on?
Chrome, Safari, Microsoft Edge, Firefox
Additional context
No response
Relevant log output
No response

Please keep in mind that Artemis does not support real time collaboration. We just make sure that changes are synced quickly when one person works at the text at the same time.
Of course it would be nice to have real
time collaboration support, but this is challenging to implement

Thank you for your response. It would still be nice, if the UI suggests that it is not made for live collaboration. Maybe disable text input, while one user is typing? Of course this is more of a quality of life feature.


hello I have something to ask.

Where in the project are you using sentry, where are you using it?

No


Create Amplify sidebar in figma

And decide what to keep as-is, what to change

Ready for a first review @lucasveil @benteljones I have set up det design of the component in my test area here It still need some more examples, but the components to build a side bar is outlined. I'm thinking we can have a "ready made" bar as you can see, in addition to all components needed to put it up bit by bit. I have started a documentation which is also right there + a few examples. Will set up more examples of different usages of a side bar (with actions etc).

Put on hold until week 18 (after compact)

This is a new component


Update doc for CA1806 to mention new case

With PR https://github.com/dotnet/roslyn-analyzers/pull/3083 the rule will now start reporting on ignored disposable objects. The cause bullet points need to be updated accordingly.

Looks like dotnet/roslyn-analyzers#3083 was closed as partially redundant.

Yes you are right, I forgot to close this ticket! Thanks


Solving More Problems and Enhancing the repository

I have already solved more then 410+ problems on Leetcode, would like to contribute to the repo.

Great, you can start!

Please avoid any kind of redundancy.
See #18

Thanks!

Mention this issue in your PR, will close it with that PR.

Closed in #36

Hey, I guess you forgot to add, hacktoberfest-accepted tag , while merging the the branch.


Bug cover inversion state in webinterface

I see in the web interface cover state 100% when my cover is close and 0% when cover is open.
HA and GoogleHome give 0% close and 100% open.

That’s actually intended.
Matter specifies open and close state in the opposite than Home Assistant.
It seems that google home is doing that as well, right? So it’s not a problem, right?


Support binary for 32-bit builds

-m32 and binary mode don't work together: https://godbolt.org/g/6pRN77
/opt/compiler-explorer/gcc-7.1.0/bin/../lib/gcc/x86_64-linux-gnu/7.1.0/../../../../x86_64-linux-gnu/bin/ld: cannot find -lstdc++
/opt/compiler-explorer/gcc-7.1.0/bin/../lib/gcc/x86_64-linux-gnu/7.1.0/../../../../x86_64-linux-gnu/bin/ld: cannot find -lgcc_s
/opt/compiler-explorer/gcc-7.1.0/bin/../lib/gcc/x86_64-linux-gnu/7.1.0/../../../../x86_64-linux-gnu/bin/ld: skipping incompatible /opt/compiler-explorer/gcc-7.1.0/bin/../lib/gcc/x86_64-linux-gnu/7.1.0/libgcc.a when searching for -lgcc
/opt/compiler-explorer/gcc-7.1.0/bin/../lib/gcc/x86_64-linux-gnu/7.1.0/../../../../x86_64-linux-gnu/bin/ld: cannot find -lgcc
collect2: error: ld returned 1 exit status

Install g++-multilib.

I don't install g++ from apt - it's built directly from source. Do you know what setting I might be missing to have it wor? The scripts to build it are here: https://github.com/mattgodbolt/compiler-explorer-image/blob/master/gcc/build/build.sh - I explicitly disabled multilib; perhaps I need to enable it?

I checked what config g++ installed from apt uses.
--enable-multiarch --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib

Cool thanks I'll look into changing it. First up will be the nightly build
of GCC. If that seems to work we can rebuild the other GCCs too.
On Sun, 8 Oct 2017, 21:11 Mandar Kulkarni<EMAIL_ADDRESS>wrote:

I checked what config g++ installed from apt uses.
--enable-multiarch --with-arch-32=i686 --with-abi=m64
--with-multilib-list=m32,m64,mx32 --enable-multilib
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mattgodbolt/compiler-explorer/issues/495#issuecomment-335055661,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmsdYxbG8zepa6eQK49pjINHTYO2cGiks5sqYC9gaJpZM4O2W0d
.

So, the GCC I built locally with the changes to enable multilib et al worked, but the automatic build last night failed. And not in an obvious way, either (build logs attached). Hopefully it'll "fix itself" for tomorrow, but I'll try and take a look later anyway...we'll get there!
original_msg.txt

And of course as soon as I post that I find the error:
              ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
../../../../gcc-trunk-20171010/libgo/runtime/proc.c:169:4: error: #error unknown case for SETCONTEXT_CLOBBERS_TLS
 #  error unknown case for SETCONTEXT_CLOBBERS_TLS
    ^~~~~
../../../../gcc-trunk-20171010/libgo/runtime/proc.c: In function 'runtime_gogo':
../../../../gcc-trunk-20171010/libgo/runtime/proc.c:284:2: error: implicit declaration of function 'fixcontext'; did you mean 'setcontext'? [-Werror=implicit-function-declaration]
  fixcontext(ucontext_arg(&newg->context[0]));
  ^~~~~~~~~~
  setcontext
../../../../gcc-trunk-20171010/libgo/runtime/proc.c: In function 'runtime_mstart':
../../../../gcc-trunk-20171010/libgo/runtime/proc.c:485:2: error: implicit declaration of function 'initcontext'; did you mean 'setcontext'? [-Werror=implicit-function-declaration]
  initcontext();

Fixed for gcc 7.3 onwards. Anyone suffering for this on earlier compilers...let me know and I can rebuild them..I think...


runtime-core bug, cant use ts reduction for ‘props’ passed into setup function

Version
3.0.5
Reproduction link
https://codepen.io/alreadytaken1990/pen/ExgqOZK
Steps to reproduce
at runtime core line 492:
see the link
What is expected?
props passed setup function with  ts reduction
What is actually happening?
props: any

You've missed , before setup ().
It does work.

You've missed , before setup ().
It does work.

just in codepin miss that, see orgin code in runtime

just in codepin miss that, see orgin code in runtime


[tomlplusplus] Build error

Copy issue body from /Users/user/vcpkg/installed/vcpkg/issue_body.md

You have to do what you write there ;)

Please see https://github.com/microsoft/vcpkg/issues/30604 for how to report an issue.


Add support to deploy logs on OCP cluster

This PR adds support to deploy observatorium-logs on OCP cluster via launch script.

/lgtm

No @periklis currently CI only deploy's RHOBS metrics part. After this PR I am planning to add logs to CI as well

No @periklis currently CI only deploy's RHOBS metrics part. After this PR I am planning to add logs to CI as well

So you verified this only locally?

Yes on OCP cluster the components are deployed successfully.


Pascal error output

So that errors get highlighted for pascal just like for other compilers,
also removes the sourcecode temp folder from the output filenames

Looks good to me, and does not seem to break anything after testing. 👍


Cards are being voided when removed from Card Holder with full inventory

LaserIO version
1.3.1
Minecraft Version
1.18.2
Forge Version
40.1.54
Modpack & Version
Direwolf20 1.18 V1.7.0
Do you have optifine installed?
No
Describe the issue
When removing cards with shift right-click from the card holder, the card is voided if inventory is full
Steps to reproduce

Open Card Holder
Remove cards until inventory is full
Continue to remove cards
Excess cards are voided

Expected behaviour
I would expect excess cards to fall on the ground as per normal minecraft behavior
Screenshots
No response
Log files
No response
Additional information
No response

Should be resolved by: https://github.com/Direwolf20-MC/LaserIO/commit/1d745139d3ad1b8f7bc4ea3aaf261a0727602a87


Non-working:missing assets/blackhawk/uh60.lwo

i have modify and compile this project ok (replace library, change some gl* functions by QOpenGLFunctions_4_3_Core->gl* ), but i can not run ok.
Error parsing : assets/blackhawk/uh60.lwo -> Unable to open file "assets/blackhawk/uh60.lwo".
at file scene.cpp and functions void Scene::initialize()
i cannot find the lwo file
here is my environment
platform:windows 7 64bit
Soft: Qt 5.8.0_vs2013_x86
Library: assimp 3.1.1, ImageMagick-7.0.5-Q16

i have use myself model replace the lwo model,  it wonderful.
thank you.


Supporting state for acquireTokenSilent?

Core Library
@azure/msal-browser
Core Library Version
2.14.1
Wrapper Library
@azure/msal-react
Wrapper Library Version
1.0.0-beta.2
Description
Hi,
I see silentRequest is supporting:

scopes                 - Array of scopes the application is requesting access to.

authority              - Url of the authority which the application acquires tokens from.

correlationId          - Unique GUID set per request to trace a request end-to-end for telemetry purposes.

account                - Account entity to lookup the credentials.

forceRefresh           - Forces silent requests to make network calls if true.

extraQueryParameters       - String to string map of custom query parameters added to the /authorize call. Only used when renewing the refresh token.

tokenQueryParameters       - String to string map of custom query parameters added to the /token call. Only used when renewing access tokens.

redirectUri            - The redirect URI where authentication responses can be received by your application. It must exactly match one of the redirect URIs registered in the Azure portal. Only used for cases where refresh token is expired.

Can we support also state parameter? It is possible?
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
No response
Source
External (Customer)

Hi @jindrichkuba . Thanks for raising the issue, we'll look into adding the state parameter to the silent request type.

can I contribute for this change?

@jindrichkuba you are very welcome to contribute a PR for this change. Please review our contribution guidelines before you start to make sure your contribution experience is as smooth as possible! Feel free to update this issue with any questions you have. Thanks!


bug: Data is not created when one of the scrappers failed

Overview
It seems that whenever one of the scrappers fails, any investment data is not generated, whether one of them has finished successfully or not.
There are 2 issues that need to be fixed:

Results generated by scrappers should be handled independently, even when the scrappers are executed concurrently using Promise.all.
Past scrapping results should be saved to prevent API error.

According to this run, it seems that the action.... somehow fixes itself.
Unfortunately, it only works for one file and fails the other two.

Decided to use another CI service. It seems GH actions are unreliable.


SAK-31879 another commit because the between on the SQL doesnt make s…

…ense if you have 1000 consecutive events without a session
@bjones86 my last commit didn't solve the use case where the first 1000 events are not connected to a valid session. CC'ing you because I think you changed the previous Oracle clause to not use ROWNUM. Can you test this slightly revised query for performance?

@ottenhoff ran a few quick tests. Seems the new query is a slight improvement in terms of performance, and probably uses less temporary space on the DB.


Updates docker image ref to upgraded circleci-docker w/ go v1.15.5

Description
Updates golang from 1.15.2 to 1.15.5 for minor release that include address some security concerns:

go1.15.3 (released 2020/10/14) includes fixes to cgo, the compiler, runtime, the go command, and the bytes, plugin, and testing packages. See the Go 1.15.3 milestone on our issue tracker for details.
go1.15.4 (released 2020/11/05) includes fixes to cgo, the compiler, linker, runtime, and the compress/flate, net/http, reflect, and time packages. See the Go 1.15.4 milestone on our issue tracker for details.
go1.15.5 (released 2020/11/12) includes security fixes to the cmd/go and math/big packages. See the Go 1.15.5 milestone on our issue tracker for details.

Reviewer Notes
The merged PR for **step 1 ** in the upgrade is here.
Setup
See instructions for reference.
Update .tool-versions to point to new version of golang
If you've done some PATH sorcery to point to a specific Go version (as detailed here), you'll have to update that as well
(if you do not yet have asdf installed, see How to get up and running)

Run asdf install to install the new version

mylaptop ~ %: asdf install golang 1.15.5

Run asdf global golang <version> to update global version as well go version and asdf which go to check it worked

mylaptop ~ %: go version
mylaptop ~ %: go version go1.15.5 darwin/amd64

mylaptop ~ %: asdf which go
mylaptop ~ %: /Users/john/.asdf/installs/golang/1.15.5/go/bin/go

Changelog or Releases

golang

Code Review Verification Steps

[x] Request review from a member of a different team.
[x] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this Wiki explains more about the approach used.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against d3c48c04b4735f808b0d999d50430f3e0f8bfbbb


All the data is stored within a shared database

Created separeted issues to track the working progress

Please view the following issues: #42 , #43 , #44 , #45

all done!
from now on - features & maintenance only :)


feat(Menu): Add items shorthand

This PR:

Resolved old TODOs for Menu in docs;
Adds items shorthand for Menu:

const items [
  {name: 'Open'},
  {name: 'Save'},
]

<Menu items={items} onItemClick={handler} />

const items [
  {name: 'Open', onClick: onOpenClick},
  {active: true, name: 'Save', onClick: onSaveClick},
]

<Menu items={items} />

Looks like tests crashed, Maximum call stack exceeded.  I've retried tests without cache to see if it resolves the issue.
There are also a number of new lines added without coverage.  I suspect codecov will fail unless tests are added for the red lines here:

FWIW, you can see coverage info right on the PR with the codecov browser extension (shown above).  Also, you can open /coverage/lcov-report/index.html and drill down into specific coverage info.

There are also a number of new lines added without coverage.

I'll improve coverage and add docs soon.

Current coverage is 98.69% (diff: 100%)

Merging #506 into master will increase coverage by <.01%

@@             master       #506   diff @@
==========================================
  Files           102        102
  Lines          1520       1530    +10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1500       1510    +10
  Misses           20         20
  Partials          0          0

Powered by Codecov. Last update 2b84844...c77b459

Updated to master, seems we ready to go.

Reviewing, will merge if I can

Just cleaned up one unused param, will merge when tests pass.

Released in<EMAIL_ADDRESS>thanks much!


[SPARK-5909][SQL] Add a clearCache command to Spark SQL's cache manager

JIRA: https://issues.apache.org/jira/browse/SPARK-5909

Test build #27724 has started for   PR 4694 at commit a2702fc.

This patch merges cleanly.

Test build #27724 has finished for   PR 4694 at commit a2702fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27724/
Test PASSed.

Test build #27764 has started for   PR 4694 at commit 397ecc4.

This patch merges cleanly.

Test build #27764 has finished for   PR 4694 at commit 397ecc4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27764/
Test PASSed.

LGTM, merging to master, thanks!

@marmbrus Should we backport this to branch-1.3?

@liancheng Yes, please merge it to branch-1.3. Thanks!

I backported this.


[Key Vault - Administration] Integration test libraries failing in nightly runs

Key Vault - Administration nightly test runs are failing with:

Stack trace:

RestError: Invalid jobId was passed (Activity ID: 13358de0-6fb4-11ec-a1c3-002248511adf)
at handleErrorResponse (/mnt/vss/_work/1/s/sdk/core/core-client/src/deserializationPolicy.ts:251:17)
at deserializeResponseBody (/mnt/vss/_work/1/s/sdk/core/core-client/src/deserializationPolicy.ts:159:43)
at processTicksAndRejections (internal/process/task_queues.js:97:5)

AssertionError: expected promise to be rejected with an error matching /SAS token/ but got 'Invalid jobId was passed (Activity ID: 15dfcc2c-6fb4-11ec-a1c3-002248511adf)'
For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1280957&view=results
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1278515&view=results
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1247909&view=results

This is a known service-side issue when they are parsing the api-version querystring parameter. I'll follow up in a week or so once the fixes have been rolled out globally

Looks like the issue is resolved as of Monday - so we can go ahead and close this https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1336836&view=results


 (PATCH)
New - implemented a new feature. (MINOR)
Update - for a backwards-compatible enhancement. (MINOR)
Breaking - for a backwards-incompatible enhancement or feature. (MAJOR)
Docs - changes to documentation only.
Build - changes to build process only.
Upgrade - for a dependency upgrade.

An alternative is the commit message style used by Angular and a number of other projects (e.g. chore(upgrade): react to 0.14)

Current coverage is 100.00%

Merging #66 into master will not affect coverage as of c616207

@@            master     #66   diff @@
======================================
  Files           16      16
  Stmts          147     147
  Branches         0       0
  Methods          0       0
======================================
  Hit            147     147
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of c616207

Powered by Codecov. Updated on successful CI builds.

LGTM

Should this not be a pre-commit hook? How does post-test get run?

LGTM Merging :ramen:


[6.24] crashes while playing with new features, such as target info.

6.24-20241114-090523-9244-29788.dmp
6.24-20241115-171527-30596-28408.dmp
6.24-20241115-183125-18436-32548.dmp
6.24-20241117-083731-15068-32500.dmp
I found some bugs that may need fixing. For example, when clicking on info about an enemy or chest to read on the GW Wiki pages, the page crashes when opening. I was able to compile a list here.

Sorry, but your crashdumps aren't giving me a download and I cannot reproduce any crashes.

Sure. I'll do that.


Flannel interface down while using with kubeadm

I ran into the same situation as described in #676. Then as suggested on kubernetes slack, I ran
kubectl apply -f https://github.com/coreos/flannel/blob/master/Documentation/kube-flannel-rbac.yml
This fixed the issue of pods not coming up, but flannel interface is still down and pod throws the following error.
E0419 17:07:44.681897       1 network.go:102] failed to register network: failed to acquire lease: the server does not allow access to the requested resource (put nodes ubuntu)
E0419 17:07:45.684478       1 network.go:102] failed to register network: failed to acquire lease: the server does not allow access to the requested resource (put nodes ubuntu)
E0419 17:07:46.686523       1 network.go:102] failed to register network: failed to acquire lease: the server does not allow access to the requested resource (put nodes ubuntu)
E0419 17:07:47.688430       1 network.go:102] failed to register network: failed to acquire lease: the server does not allow access to the requested resource (put nodes ubuntu)
E0419 17:07:48.693074       1 network.go:102] failed to register network: failed to acquire lease: the server does not allow access to the requested resource (put nodes ubuntu)
E0419 17:07:49.698987       1 network.go:102] failed to register network: failed to acquire lease: the server does not allow access to the requested resource (put nodes ubuntu)

kubectl describe po kube-flannel-ds-3v4k4 -n kube-system

Name:		kube-flannel-ds-3v4k4
Namespace:	kube-system
Node:		ubuntu/<IP_ADDRESS>
Start Time:	Wed, 19 Apr 2017 23:55:48 +0700
Labels:		app=flannel
  	pod-template-generation=1
  	tier=node
Annotations:	kubernetes.io/created-by={"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"DaemonSet","namespace":"kube-system","name":"kube-flannel-ds","uid":"0979f02c-2521-11e7-8948-525400fb8bd2"...
Status:		Running
IP:		<IP_ADDRESS>
Controllers:	DaemonSet/kube-flannel-ds
Containers:
kube-flannel:
  Container ID:	docker://03f1ef629e80d05ffb41f257c704e96a959309da5cda1d31ec013df7ce6a7c61
  Image:		quay.io/coreos/flannel:v0.7.0-amd64
  Image ID:		docker-pullable://quay.io/coreos/flannel@sha256:689be113b2e7803514bf123d63d0fb41d347213b1fe12de7ddfe373281bb98cc
  Port:
  Command:
    /opt/bin/flanneld
    --ip-masq
    --kube-subnet-mgr
  State:		Running
    Started:		Wed, 19 Apr 2017 23:55:48 +0700
  Ready:		True
  Restart Count:	0
  Environment:
    POD_NAME:		kube-flannel-ds-3v4k4 (v1:metadata.name)
    POD_NAMESPACE:	kube-system (v1:metadata.namespace)
  Mounts:
    /etc/kube-flannel/ from flannel-cfg (rw)
    /run from run (rw)
    /var/run/secrets/kubernetes.io/serviceaccount from flannel-token-kj67g (ro)
install-cni:
  Container ID:	docker://32cba458841c4c7227b2ceb8f3d62f31112cd4db7218521702e8e6b1526c6d3a
  Image:		quay.io/coreos/flannel:v0.7.0-amd64
  Image ID:		docker-pullable://quay.io/coreos/flannel@sha256:689be113b2e7803514bf123d63d0fb41d347213b1fe12de7ddfe373281bb98cc
  Port:
  Command:
    /bin/sh
    -c
    set -e -x; cp -f /etc/kube-flannel/cni-conf.json /etc/cni/net.d/10-flannel.conf; while true; do sleep 3600; done
  State:		Running
    Started:		Wed, 19 Apr 2017 23:55:49 +0700
  Ready:		True
  Restart Count:	0
  Environment:	<none>
  Mounts:
    /etc/cni/net.d from cni (rw)
    /etc/kube-flannel/ from flannel-cfg (rw)
    /var/run/secrets/kubernetes.io/serviceaccount from flannel-token-kj67g (ro)
Conditions:
Type		Status
Initialized 	True
Ready 	True
PodScheduled 	True
Volumes:
run:
  Type:	HostPath (bare host directory volume)
  Path:	/run
cni:
  Type:	HostPath (bare host directory volume)
  Path:	/etc/cni/net.d
flannel-cfg:
  Type:	ConfigMap (a volume populated by a ConfigMap)
  Name:	kube-flannel-cfg
  Optional:	false
flannel-token-kj67g:
  Type:	Secret (a volume populated by a Secret)
  SecretName:	flannel-token-kj67g
  Optional:	false
QoS Class:	BestEffort
Node-Selectors:	beta.kubernetes.io/arch=amd64
Tolerations:	node-role.kubernetes.io/master=:Exists:NoSchedule
  	node.alpha.kubernetes.io/notReady=:Exists:NoExecute for 300s
  	node.alpha.kubernetes.io/unreachable=:Exists:NoExecute for 300s
Events:
FirstSeen	LastSeen	Count	From		SubObjectPath			Type		Reason	Message
---------	--------	-----	----		-------------			--------	------	-------
12m		12m		2	kubelet, ubuntu	spec.containers{kube-flannel}	Normal		Pulled	Container image "quay.io/coreos/flannel:v0.7.0-amd64" already present on machine
12m		12m		1	kubelet, ubuntu	spec.containers{kube-flannel}	Normal		Created	Created container with id 03f1ef629e80d05ffb41f257c704e96a959309da5cda1d31ec013df7ce6a7c61
12m		12m		1	kubelet, ubuntu	spec.containers{kube-flannel}	Normal		Started	Started container with id 03f1ef629e80d05ffb41f257c704e96a959309da5cda1d31ec013df7ce6a7c61
12m		12m		1	kubelet, ubuntu	spec.containers{install-cni}	Normal		Created	Created container with id 32cba458841c4c7227b2ceb8f3d62f31112cd4db7218521702e8e6b1526c6d3a
12m		12m		1	kubelet, ubuntu	spec.containers{install-cni}	Normal		Started	Started container with id 32cba458841c4c7227b2ceb8f3d62f31112cd4db7218521702e8e6b1526c6d3a

Flannel Manifests
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: flannel
---
kind: ConfigMap
apiVersion: v1
metadata:
  name: kube-flannel-cfg
  labels:
    tier: node
    app: flannel
data:
  cni-conf.json: |
    {
      "name": "cbr0",
      "type": "flannel",
      "delegate": {
        "isDefaultGateway": true
      }
    }
  net-conf.json: |
    {
      "Network": "<IP_ADDRESS>/16",
      "Backend": {
        "Type": "udp"
      }
    }
---
apiVersion: extensions/v1beta1
kind: DaemonSet
metadata:
  name: kube-flannel-ds
  labels:
    tier: node
    app: flannel
spec:
  template:
    metadata:
      labels:
        tier: node
        app: flannel
    spec:
      hostNetwork: true
      nodeSelector:
        beta.kubernetes.io/arch: amd64
      serviceAccountName: flannel
      containers:
      - name: kube-flannel
        image: quay.io/coreos/flannel:v0.7.0-amd64
        command: [ "/opt/bin/flanneld", "--ip-masq", "--kube-subnet-mgr" ]
        securityContext:
          privileged: true
        env:
        - name: POD_NAME
          valueFrom:
            fieldRef:
              fieldPath: metadata.name
        - name: POD_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        volumeMounts:
        - name: run
          mountPath: /run
        - name: flannel-cfg
          mountPath: /etc/kube-flannel/
      - name: install-cni
        image: quay.io/coreos/flannel:v0.7.0-amd64
        command: [ "/bin/sh", "-c", "set -e -x; cp -f /etc/kube-flannel/cni-conf.json /etc/cni/net.d/10-flannel.conf; while true; do sleep 3600; done" ]
        volumeMounts:
        - name: cni
          mountPath: /etc/cni/net.d
        - name: flannel-cfg
          mountPath: /etc/kube-flannel/
      volumes:
        - name: run
          hostPath:
            path: /run
        - name: cni
          hostPath:
            path: /etc/cni/net.d
        - name: flannel-cfg
          configMap:
            name: kube-flannel-cfg

Flannel rbac manifest
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
  name: flannel
rules:
  - apiGroups:
      - ""
    resources:
      - pods
    verbs:
      - get
  - apiGroups:
      - ""
    resources:
      - nodes
    verbs:
      - list
      - watch
  - apiGroups:
      - ""
    resources:
      - nodes/status
    verbs:
      - patch
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
  name: flannel
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: flannel
subjects:
- kind: ServiceAccount
  name: flannel
  namespace: kube-system

Interface state
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 52:54:00:fb:8b:d2 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global ens3
       valid_lft forever preferred_lft forever
6: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:c2:a5:ef:a1 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 scope global docker0
       valid_lft forever preferred_lft forever
7: flannel.1: <BROADCAST,MULTICAST> mtu 1450 qdisc noop state DOWN group default
    link/ether 62:92:55:65:70:e4 brd ff:ff:ff:ff:ff:ff

I just got this working myself.
Download kube-flannel.yml and update references to the flannel image from 0.7.0 to 0.7.1.
Re-run the configuration from scratch, but use
kubectl apply -f kube-flannel.yml
(your edited file)

This should be fixed now #690

@strigona-worksight Thank you very much. The above works.


Error generating file bonsai2_slowdust_generated_timestep.cu.o

Hi, I am able to build the project using cmake fine, but when I run the make command I get the aforementioned error. I have pasted the output below. Any help would be appreciated.

CMake Warning (dev) in CMakeLists.txt:
No project() command is present.  The top-level CMakeLists.txt file must
contain a literal, direct call to the project() command.  Add a line of
code such as
project(ProjectName)

near the top of the file, but after cmake_minimum_required().
CMake is pretending there is a "project(Project)" command on the first
line.
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Deprecation Warning at CMakeLists.txt:3 (CMAKE_MINIMUM_REQUIRED):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/sarl-ws-4/ismael/Bonsai-master/runtime
[  1%] Building NVCC (Device) object CMakeFiles/bonsai2_slowdust.dir/CUDAkernels/bonsai2_slowdust_generated_timestep.cu.o
nvcc warning : The 'compute_35', 'compute_37', 'compute_50', 'sm_35', 'sm_37' and 'sm_50' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
nvcc warning : The 'compute_35', 'compute_37', 'compute_50', 'sm_35', 'sm_37' and 'sm_50' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
ptxas info    : 13 bytes gmem
ptxas info    : Compiling entry function '_ZN3cub11EmptyKernelIvEEvv' for 'sm_35'
ptxas info    : Function properties for _ZN3cub11EmptyKernelIvEEvv
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 2 registers, 320 bytes cmem[0]
ptxas info    : Compiling entry function 'compute_energy_double' for 'sm_35'
ptxas info    : Function properties for compute_energy_double
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 20 registers, 360 bytes cmem[0]
ptxas info    : Compiling entry function 'compute_dt' for 'sm_35'
ptxas info    : Function properties for compute_dt
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 28 registers, 396 bytes cmem[0], 40 bytes cmem[2]
ptxas info    : Compiling entry function 'correct_particles' for 'sm_35'
ptxas info    : Function properties for correct_particles
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 30 registers, 432 bytes cmem[0], 28 bytes cmem[2]
ptxas info    : Compiling entry function 'setActiveGroups' for 'sm_35'
ptxas info    : Function properties for setActiveGroups
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 6 registers, 352 bytes cmem[0]
ptxas info    : Compiling entry function 'predict_particles' for 'sm_35'
ptxas info    : Function properties for predict_particles
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 22 registers, 384 bytes cmem[0]
ptxas info    : Compiling entry function 'get_nactive' for 'sm_35'
ptxas info    : Function properties for get_nactive
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 13 registers, 344 bytes cmem[0]
ptxas info    : Compiling entry function 'get_Tnext' for 'sm_35'
ptxas info    : Function properties for get_Tnext
0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
ptxas info    : Used 13 registers, 344 bytes cmem[0]
/usr/include/c++/11/bits/std_function.h:435:145: error: parameter packs not expanded with ‘...’:
435 |         function(_Functor&& __f)
|                                                                                ^
/usr/include/c++/11/bits/std_function.h:435:145: note:         ‘_ArgTypes’
/usr/include/c++/11/bits/std_function.h:530:146: error: parameter packs not expanded with ‘...’:
530 |         operator=(_Functor&& __f)
|                                                                                ^
/usr/include/c++/11/bits/std_function.h:530:146: note:         ‘_ArgTypes’
CMake Error at bonsai2_slowdust_generated_timestep.cu.o.cmake:280 (message):
Error generating file
/home/sarl-ws-4/ismael/Bonsai-master/runtime/CMakeFiles/bonsai2_slowdust.dir/CUDAkernels/./bonsai2_slowdust_generated_timestep.cu.o
make[2]: *** [CMakeFiles/bonsai2_slowdust.dir/build.make:714: CMakeFiles/bonsai2_slowdust.dir/CUDAkernels/bonsai2_slowdust_generated_timestep.cu.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/bonsai2_slowdust.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

Hi, I've not build the code in a while, but looking at the errors I suspect it has to do with the usage of a CUDA or compiler version that is too new. Maybe try it with an older CUDA version/C++ compiler.

Stumbled on this question because I'm updating the stack that has Bonsai integrated. I'm using Bonsai for QC visusalisation
I've created a Dockerfile for Nvidia Docker to work around the legacy as they are Fermi (SM35) + Ubuntu 20.04 CUDA 11.4 env.
The image injects the OpenGL on the host system and layers with the enviroment on top of the newer x session whilst binding to the legacy requirements in the container. A terminal can be started on the host system UI that gives access to the container.
Some specific settings on the host environment need to be set in order for this to work, this way Bonsai can go on and work with newer enviroments and hardware


Using other than official Whisper Models

Hey
I have been using buzz for sometime and it is an amazing effort. I have a question from you. If i want to use some modified or further trained whisper model, how can i use that model. As I have to use to it on system without direct internet access, how i can use a model from hugging face. Thanks in advance

Short answer is download necessary models on some computer with internet and then copy over to the computer without the internet.
Buzz stores models in it's cache folder. The folder is always in the same place, so you can copy it over from one computer with internet to another without the internet. To find the model folder go to Help -> Preferences -> Models. Download some models and click on the button to show model location. The folder is something like this C:\Users\YourUserName\AppData\Local\Buzz\Buzz\Cache\models
Also you can check this section on advanced preferences https://chidiwilliams.github.io/buzz/docs/preferences#advanced-preferences
This is a way for you to set custom model root. Might be useful.

If you select Huggingface as Whisper type when you add some file to be transcribed, you will be able to enter a Huggingface model id and Buzz will download the necessary model files

When I try to add Huggingface id to download mode, i received following error
Traceback (most recent call last):
File "multiprocessing\process.py", line 314, in _bootstrap
File "multiprocessing\process.py", line 108, in run
File "buzz\transcriber\whisper_file_transcriber.py", line 97, in transcribe_whisper
File "buzz\transcriber\whisper_file_transcriber.py", line 122, in transcribe_hugging_face
File "buzz\transformers_whisper.py", line 170, in transcribe
File "transformers\models\auto\auto_factory.py", line 563, in from_pretrained
return model_class.from_pretrained(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "transformers\modeling_utils.py", line 3144, in from_pretrained
raise EnvironmentError(
OSError: Error no file named pytorch_model.bin, tf_model.h5, model.ckpt.index or flax_model.msgpack found in directory C:\Users\hp\AppData\Local\Buzz\Buzz\Cache\models\models--lanmandragoran--urdu-whisper-large-v2\snapshots\7463b4079a018b48afc407f0e8dffe90f16368c0.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 4, in
File "buzz\buzz.py", line 38, in main
File "PyInstaller\hooks\rthooks\pyi_rth_multiprocessing.py", line 50, in _freeze_support
File "multiprocessing\spawn.py", line 122, in spawn_main
File "multiprocessing\spawn.py", line 135, in _main
File "multiprocessing\process.py", line 329, in _bootstrap
AttributeError: 'NoneType' object has no attribute 'write'

M

Buzz uses custom folders to download models, so you could move them to another system. You need to download models thru Buzz. Enter "lanman" in the search box and then select appropriate model.
Model downloading uses huggingface code to manage caches and versions so I am not sure you can download models thru browser or by other means. Best way to download models is to use Buzz to do that.
In your case all the files you see in the huggingface repo in "Files" section
should be in C:\Users\hp\AppData\Local\Buzz\Buzz\Cache\models\models--lanmandragoran--urdu-whisper-large-v2\snapshots\7463b4079a018b48afc407f0e8dffe90f16368c0
Error you get is saying that it can't find the model files.

I tried downloading through Buzz the large-v3-turbo model using huggingface and hit the same type of errors.
after attempting to download for about 5-10 seconds and sitting at 1% it throws shows a window with the title of "Unhandled exception in script"
just below that it says "Failed to execute script 'main' due to unhandled exception: 'NoneType' object has no attribute 'write'
then in its main display it says the following lines -
Traceback (most recent call last):
File "multiprocessing\process.py", line 314, in _bootstrap
File "multiprocessing\process.py", line 108, in run
File "buzz\transcriber\whisper_file_transcriber.py", line 97, in transcribe_whisper
File "buzz\transcriber\whisper_file_transcriber.py", line 122, in transcribe_hugging_face
File "buzz\transformers_whisper.py", line 170, in transcribe
File "transformers\models\auto\auto_factory.py", line 563, in from_pretrained
return model_class.from_pretrained(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "transformers\modeling_utils.py", line 3144, in from_pretrained
raise EnvironmentError(
OSError: Error no file named pytorch_model.bin, tf_model.h5, model.ckpt.index or flax_model.msgpack found in directory C:\Users\sssss\AppData\Local\Buzz\Buzz\Cache\models\models--openai--whisper-large-v3-turbo\snapshots\41f01f3fe87f28c78e2fbf8b568835947dd65ed9.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 4, in
File "buzz\buzz.py", line 38, in main
File "PyInstaller\hooks\rthooks\pyi_rth_multiprocessing.py", line 50, in _freeze_support
File "multiprocessing\spawn.py", line 122, in spawn_main
File "multiprocessing\spawn.py", line 135, in _main
File "multiprocessing\process.py", line 329, in _bootstrap
AttributeError: 'NoneType' object has no attribute 'write'

@dra6on1 @adijahangir123
Open the models folder you see in the error, f.e. C:\Users\sssss\AppData\Local\Buzz\Buzz\Cache\models
Delete the turbo model folder
Try to download again
I have seen random network errors from time to time, but usually retrying the download it eventually succeeds.

That  worked. It may be worth adding that as a note to the bottom  of the error output so people know to try it.

A mitigation to possible model download issues was added. If download fails the incomplete model download will be deleted so Buzz will automatically try to re-download it.
Also there is a note in the FAQ section on this.


'Slides' missing from @ionic/angular

Bug Report
Ionic version:

[x] 4.x
Current behavior:

Expected behavior:

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

Ionic info:

insert the output from ionic info here

Components has been renamed to match their name in the markup and to be more consistent between Ionic in other frameworks and the docs:
https://github.com/ionic-team/ionic/blob/master/CHANGELOG.md#angular-prefixed-ion--components

@manucorporat Prefixing with "Ion" did the trick. Thanks.
import { IonSlides } from "@ionic/angular";


[Enhancement] isReady method

Hey !
Thanks for wavesurfer it's awesome.
I was thinking about adding an isReady() function wich simply return true or false. The event 'ready' is working and I can recreate the isReady function by myself I know but that implies I can not unsub the event from another callback.
If you have any idea. Thanks ! :)

prs are always welcome.


Modify worker parameters

Codecov Report

Merging #2479 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #2479      +/-   ##
============================================
- Coverage     35.23%   35.18%   -0.05%
+ Complexity     2364     2361       -3
============================================
  Files           423      423
  Lines         19540    19540
  Branches       2383     2383
============================================
- Hits           6884     6876       -8
- Misses        12050    12055       +5
- Partials        606      609       +3

Impacted Files
Coverage Δ
Complexity Δ

...scheduler/alert/template/AlertTemplateFactory.java
42.85% <0.00%> (-28.58%)
2.00% <0.00%> (-1.00%)

...he/dolphinscheduler/common/thread/ThreadUtils.java
74.60% <0.00%> (-3.18%)
14.00% <0.00%> (ø%)

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.07% <0.00%> (-2.88%)
9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc36c77...a358b58. Read the comment docs.