ChargedParticles-Jackson

Hello!
I saw your project on Hacker News a while back and decided to give it a go. I don't know anything about algorithmic art OR programming in javascript, so it was an interesting challenge! I struggled to think of something interesting to draw, so I decided to think about what I do know a little bit about: physics!
I recently had the opportunity to take a physics class going over the basics of Maxwell's equations at a local community college. I was really struck by the beauty of Gauss's law, in particular, describing how the flux of electric field through any surface is directly proportional to total enclosed charge, regardless of how it's positioned. From this law follows Coulomb's law, describing the force between two charged particles.
My program takes a configuration of static charged particles and a single unbound charged particle, and draws its motion through the electric field the static particles generate.
The hardest challenge for me as figuring out a good way to draw the motion of the particle itself -- I briefly considered having a dot at intervals spaced evenly in simulated time, but I decided a single line would be prettier. I initially tried to record every 10th data point and interpolate a curve through them, which was in hindsight not a great idea. It was surprisingly slow at higher resolutions, and was really just throwing away data. I eventually came to my senses and recorded every data point into a polyline and displayed them all together, which worked quite well!
Even if I don't get accepted, I'm quite proud of my little program, and was really impressed at the pretty patterns it can make :)
Thanks for this awesome project! I doubt I would have ever explored this without it.

Great visualization! Thanks for the context in your PR.
You've earned your Blot. You can order it here.


ModelLoader doesn't allow loading a local checkpoint

Currently, as I understand it, it is not possible to provide a path to a file to load with ModelLoader. The supplied model_name_or_card cannot be a path to a checkpoint file.
The user should be able to provide a path to a local file to load into a model, like you can with the Huggingface CLI and functions. This file must contain the model_name and model keys.
Additional Context:
This would be very useful for fine-tuning and evaluating SeamlessM4T models.

Hi @zrthxn,
you can specify a local path in two ways:
from fairseq2.assets import default_asset_store
from fairseq2.models import load_model

model_card = default_asset_store.retrieve_card("foo")

model_card.field("checkpoint").set_("<path/to/file>")

load_model(model_card, ...)

or if you want to have a more permanent solution, you can create a YAML asset card (see src/fairseq2/assets/cards as example) in your ~/.config/fairseq2/assets where you can override an existing card by giving it the same name with a @user postfix.


Multiple sync issue as of 18.0.0

Description
A clear and concise description of what the bug is.

[ ] I have tested this issue on the latest Detox release and it still reproduces

Reproduction
Provide the steps necessary to reproduce the issue. If you are seeing a regression, try to provide the last known version where the issue did not reproduce.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Detox:
React Native:
Node:
Device:
Xcode:
iOS:
macOS:

Logs
If you are experiencing a timeout in your test

[ ] I have followed the instructions under Lower-level Idling Resources Debug and am providing the log below:

If you are seeing a build problem (e.g. during npm install)

[ ] I am providing the npm install log below:

Device and verbose Detox logs

[ ] I have run my tests using the --loglevel trace argument and am providing the verbose log below:

Sorry, there's no way we can assist with the submission of nothing more than the issue template......
Anyways, you are welcome to retry using Detox 18.1.1.

Sorry, there's no way we can assist with the submission of nothing more than the issue template......
Anyways, you are welcome to retry using Detox 18.1.1.

@d4rky-pl Ah sorry must have accidentally pressed submit before I finished writing.

@d4rky-pl Ah sorry must have accidentally pressed submit before I finished writing.


[Android] - Unable to add to project ("Unable to resolve dependency...")

In trying to implement the module in an Android project per the README.md, I am unable to get studio (or gradle) to properly use the project. I did notice that unlike other modules, the directory shows up empty

Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve project :react-native-unified-contacts.

Unable to resolve dependency for ':app@debugAndroidTest/compileClasspath': Could not resolve project :react-native-unified-contacts.

Unable to resolve dependency for ':app@debugUnitTest/compileClasspath': Could not resolve project :react-native-unified-contacts.

Unable to resolve dependency for ':app@release/compileClasspath': Could not resolve project :react-native-unified-contacts.

Unable to resolve dependency for ':app@releaseUnitTest/compileClasspath': Could not resolve project :react-native-unified-contacts.

I tried cleaning the project, and then received
Unable to find a matching configuration of project :react-native-unified-contacts: None of the consumable configurations have attributes.

Let me know what else you need about my project to help debug this issue.

Hey @mcconkiee

Have you installed the library using npm, pulling from master instead of a specific version - as outlined in #75 ?
Did you double check the Android install instructions in the readme? Including the two build.grade files as well as the settings.gradle and the MainActivity.java?

If so, use Invalidate Caches in Android Studio and then do a complete clean and rebuild.
I've reinstalled the module several times a day for the past few weeks and install seems to go fine. If you're still having trouble, please post the relevant parts of your package.json, MainActivity.java, both build.gradle files and settings.gradle
Paul

wow - ok #75 solved that!!! THANKS

Glad to hear it @mcconkiee.
Keep in mind that with the setup from #75, every time you run npm install, you will get updated code from this repo that may not be stable. Once we release a new version on npm, you should switch to using specific version numbers instead. But sounds like you're good to go for now!


Restructure patch ordering and dissolve 90000-wip-inflight-to-upstream.patch

Per discussion and suggestion from @lucasdemarchi  order patches to avoid patch order dependent patch failures.
Why are there nuttx-patches?
Upstream submission

Upstream may reject a patch for "not applicable" An example of this would be 00002-fix-shadow-wanings.patch PX4 build with stricter warnings than does upstream. The patch applies compiler specific pragmas that have been rejected upstream.

PRs that go upstream a can come back very different. a) they can get reformatted and the essence of the PR can be lost in b) multiple further upstream formatting commits or c) committed with other wip in upstream. This is not an issue on the PX4 branches tied to the PX4 NuttX upstream branch. The PX4 NuttX upstream branch tracks upstream NuttX master at a regular uptake rate and I have to keep it building and running. On PX4/Firmware master The PX4 NuttX is lagging behind upstream and we want only our changes.

Taken as is. This is not an issue on the PX4 NuttX upstream branch that tracks upstream NuttX master but on PX4/Firmware master that is lagging behind upstream these become backports.

What it 90000-wip-inflight-to-upstream.patch?
On the PX4 branches tied to the PX4 NuttX upstream branch: This file has the changes to keep the development and build moving along while the work in process is in flight to upstream. Depending on the outcome of the Upstream submission - the content can be 1) moved to a non-upstream able permanent patch. In Case 2) or 3) the contest can be removed once the PX4 NuttX upstream branch has been merged with the upstream NuttX master.
On the PX4 Firmware master branch:  This file has the changes to keep the development and build moving along while the work in process is iflight to upstream. Depending on the outcome of the Upstream submission - the content can be 1) moved to a non-upstream able permanent patch.
Or in case 2) and 3) Backported against masters NuttX submodules, This usually requires manual intervention to remove disjoint files that got committed upstream with the PX4 contribution or in the subsequent beautification edits.  Therefore the patch file is cleaned up and saved as a 6000 bp series patch file.
Why are you not using Git for this? (If I only could)
Workflow incompatibilities with upstream NuttX.

Upstream NuttX master may be used as a development branch from time to time. Lacking a re integration workflow means there will not be a clean commit set.

As has happened in the past a the upstream repos may be reorganized as submodule and then brought back into the tree.

Therefore rebasing will not work and even cherry picking can be difficult. With this KISS approach we can see all the changes PX4 requires to NuttX and edit and re-apply them when the upstream files set changes.
I am open to suggestions on a better way - to date I have not found one.

LGTM

@davids5 maybe we should keep the numbering only so we have a correct order in which patches are applied. Then the status we keep in the next "field". Example:
00001-PENDING-fix-xyz.patch
00002-BACKPORT-fix-abc.patch
00003-REJECTED-remove-shadow-warnings.patch
...

If the commit messages contain these words, you can even use git to add the correct patch when you are adding a new one:
git format-patch -1 --start-number <next-sequence-number> --src-prefix=a/NuttX/nuttx/  --dst-prefix=b/NuttX/nuttx/

Tha would also preserve the commit message, which would be nice, and allow to be easily applied.

@lucasdemarchi
The naming sounds good.
But I think you assuming I can get a clean commits from upstream. I am concerned that might bringing other unrelated changes as @zehortigoza just experienced. What would you suggest there?

At some point we'll need to revisit how PX4 wraps the Nuttx build. It generally works pretty well, but still has a few issues.
https://github.com/PX4/Firmware/issues/6501
https://github.com/PX4/Firmware/issues/6820
CMake ExternalProject_Add might be a better solution. https://cmake.org/cmake/help/v3.0/module/ExternalProject.html

If the unrelated changes are (potentially) harmful, I'd add an additional step of editdiff file.patch. Or the equivalent using git tools - you could have px4-stash branch in which you apply the  patches before generating it to be applied on PX4. If it's not harmful, just bring the change since we will get it nonetheless when we upgrade.

@lucasdemarchi Are you ok to merge as-is or do you want further cleanup before we do?

@LorenzMeier once CI is happy (I got the ordering correct for all builds) this is GTG.

@dagar

At some point we'll need to revisit how PX4 wraps the Nuttx build. It generally works pretty well, but still >has a few issues.
#6501
#6820

CMake ExternalProject_Add might be a better solution. >https://cmake.org/cmake/help/v3.0/module/ExternalProject.html

Continuing  "Revisit how PX4 wraps the Nuttx build" here


[WIP] APPS: Remove the format argument where it's not used

Also, restore a behaviour change, where load_cert() would look at
stdin when the input file name is NULL, and make sure to call
load_cert_pass() with a corresponding argument where load_cert() was
used in OpenSSL 1.1.1.
Fixes #13235

This pull request is ready to merge

Merged
22dddfb925da8775eaf4ee8c377da41e6535afe1 APPS: Remove the format argument where it's not used


Change in Context Response: Microsoft Bot

I have been building A Microsoft Bot, for a considerable amount of time. Until a couple of days back, the following response was never true when the control comes from the Personal Bot:
 if (context.activity.attachments && context.activity.attachments.length > 0) {       if (context.activity.attachments[0].contentType === "text/html") {           return;       }   }
However, something has changed recently that this context.activity.attachments[0].contentType === "text/html" condition becomes true all the time, for any message from the bot.
This is breaking my application, since I was unaware of the change.
Kindly provide insight around such changes, and how do we best keep up with the changes in data returned by the context.

@DivyaDev1992 - We will check on it and get back to you.

You can go through this What's new for developers in Microsoft Teams  document to discover Microsoft Teams platform features that are generally available (GA) and in developer preview.  Additionally could you please share  the repro steps to test out the above issue? Are you sending attachments using the bot?


App Status

Add App Status and build info to it
@crudd-mdsol @mdrynkorn-mdsol @eyomi-mdsol @rmillward-mdsol

LGTM


read_file: don't need one extra byte now

read_file is only used here:
https://github.com/commaai/openpilot/blob/91504176e403ca1bb6bd9491ce9e2075b7f4bae0/selfdrive/modeld/runners/snpemodel.cc#L28

Can we just use the other read_file instead of having two different implementations?

util::read_file is not suitable to read large file because it has redundant copies and many resize operations during read large file. it's almost 10x slower than read_file (tested on EON):
util::read_file("supercombo.dlc") : 2599 ms
read_file("supercombo.dlc", &out_size) : 260 ms

I suggest to keep read_file and optimize util::read_file later

Can we just optimize it now? Is it fast if you reserve the correct size before reading?

updated. This implementation is almost as fast as the C version.


Update create-a-new-reactjs-app.md

Following the – otherwise incredibly amazing guide – there seems to be an issue on the following page: https://sst.dev/chapters/create-a-new-reactjs-app.html
When installing sst to packages/frontend, it fails with the following error when running pnpm run dev:
Error: No app is set

Trace: Error: No app is set
    at use (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22/node_modules/sst/constructs/FunctionalStack.js:44:15)
    at EmptyStack.ApiStack (file:///Users/jonasthiesen/code/sst-example/notes/.sst.config.1694033489155.mjs:35:21)
    at stack (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22_@types+react@18.2.21/node_modules/sst/constructs/FunctionalStack.js:20:35)
    at App.stack (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22_@types+react@18.2.21/node_modules/sst/constructs/App.js:490:16)
    at Object.stacks [as fn] (file:///Users/jonasthiesen/code/sst-example/notes/.sst.config.1694033489155.mjs:131:29)
    at Module.synth (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22_@types+react@18.2.21/node_modules/sst/stacks/synth.js:63:20)
    at async buildApp (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22_@types+react@18.2.21/node_modules/sst/cli/commands/bind.js:86:13)
    at async Object.handler (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22_@types+react@18.2.21/node_modules/sst/cli/commands/bind.js:51:9)
    at process.<anonymous> (file:///Users/jonasthiesen/code/sst-example/notes/node_modules/.pnpm/sst@2.24.22_@types+react@18.2.21/node_modules/sst/cli/sst.js:62:21)
    at process.emit (node:events:525:35)
    at process.emit (node:domain:489:12)
    at process._fatalException (node:internal/process/execution:149:25)
    at processPromiseRejections (node:internal/process/promises:288:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)

To me this sounds like it's getting a new "instance" of sst is created that doesn't have the app setup, which then let me to investigate the examples you have, e.g. this one: https://github.com/sst/sst/blob/0101c9f86c4c8c7ac7c05939d51b05c9050e12b4/examples/react-app/packages/frontend/package.json
On that one sst is not installed into packages/frontend itself.
I removed sst from packages/frontend and it seems to work perfectly now.

That's weird. We should install it there. Are you using pnpm? Can you share your version?

Yes, I'm using pnpm.
sst version 2.24.22
pnpm version 7.24.3

Oh wow. It seems to be a pnpm version thing. Just updated to latest (v8.7.4) and it seems to work now.

Yup, closing this for now.


Tab order gets reset after rearranging by dragging tabs to the right

I'm using MacVim 7.4 (99).
I've got two tabs open in MacVim. I want to rearrange their order, so I drag the first tab to be after the second one. Now, I can't click on the other tab to switch to it, like I'd expect. I can continue typing in the current window, but I can't get to that other tab with the UI.
Next, I try moving tabs with  Cmd+Shift+}. The tab order gets reset to what it was before I dragged the tabs to change their order.
This only seems to be a problem when I drag a tab toward the right. If, instead of dragging the first tab to be after the second tab, I drag the second tab to be before the first one, I can use the tabs in their new order just fine. It's something about dragging one tab to be "after" another that doesn't work properly. Dragging a tab to be "before" works fine. So there's a workaround for people who have noticed this issue.
Here's a gif of what I experience:

This has happened for a long time for me. I thought maybe the new Yosemite style tabs would fix it but hasn't. Though it wasn't always broken I'm sure, many months ago it was fine.

I don't know if this is related, but I use Tim Pope's Obsession. And recently MacVim is not properly saving tab info. If I move a tab using :tabm1 for example, and then exit saving session info. When I reopen the session the tabs are in the order they were in before I issued the :tabm command.

It seems release 100 disabled Yosemite style tabs? The actual tab style hasn't affected this bug though, I experienced it before the tab change, during, and still now that it has been reverted. It's a shame Apple doesn't provide access to their tabs widget as so many apps have issues recreating tabs well.

For me, MacVim will refuse to rearrange tabs using mouse only if they have unsaved changes.
$ mvim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Mar 26 2016 06:40:26)
MacOS X (unix) version
Included patches: 1-1655
Compiled by<EMAIL_ADDRESS>...
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -L/usr/local/lib -L. -L/usr/local/lib  -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm  -lncurses -liconv -framework Cocoa   -fstack-protector  -L/System/Library/Perl/5.16/darwin-thread-multi-2level/CORE

$ ls .vim/plugged
YouCompleteMe        devdocs.vim          nerdtree             vim-coffee-script    vim-fugitive         vim-open-alternate
ack.vim              easy-gitlab.vim      tabular              vim-colors-solarized vim-haml             vim-ruby
auto-pairs           editorconfig-vim     tcomment_vim         vim-elixir           vim-javascript       vim-sensible
ctrlp-py-matcher     file-line            tern_for_vim         vim-endwise          vim-json             vim-togglecursor
ctrlp.vim            incsearch.vim        tube.vim             vim-expand-region    vim-monokai


Troubleshooting installation issue with CountLinesExtension sample

Version of SharpShell used: 2.7.2
Related type(s) of SharpShell-Server: Any
Windows version: 10.0.19045 Build 19045
I am trying to install CountLinesExtension sample from here https://github.com/dwmkerr/sharpshell/tree/main/SharpShell/Samples/ContextMenu/CountLinesExtension using the ServerRegistrationManager (srm) tool. You can see the log below, but it basically works every time.
I also tried calling individual commands. Running gacutil -l "CountLinesExtension" afterwards finds the assembly in cache.
Furthermore, I tried swapping out the COMServerAssociation(AssociationType.ClassOfExtension, ".txt") for COMServerAssociation(AssociationType.AllFilesAndFolders) and registering that. Still no luck.
These were tried with both Release and Debug builds.
I see Explorer reload (quick flash of all icons) a second after running the srm install command (the srm uninstall does not trigger a visible flash). But none of the text files, or any files at all in the case of AllFilesAndFolders, get the new context menu item.
Are there any other logs I can look at or could I be doing something wrong?
(CCleaner shows available Context Menu extensions and this newly registered extension does not appear in the list, if that is of any help)
Log Messages

2022-11-30 07:19:20.897Z - ServerRegistrationManager - SharpShell Diagnostics Initialised. Process ServerRegistrationManager.
2022-11-30 07:19:20.906Z - ServerRegistrationManager - Started the Server Registration Manager.
2022-11-30 07:19:20.916Z - ServerRegistrationManager - RegAsm: preparing to run C:\Windows\Microsoft.Net\Framework64\v4.0.30319\regasm.exe  ".\CountLinesExtension.dll"
2022-11-30 07:19:20.992Z - RegAsm - SharpShell Diagnostics Initialised. Process RegAsm.
2022-11-30 07:19:20.999Z - RegAsm - Registering server for type CountLinesExtension
2022-11-30 07:19:21.006Z - RegAsm - Preparing to register SharpShell Server CountLinesExtension as OS64Bit
2022-11-30 07:19:21.018Z - RegAsm - Registration of CountLinesExtension completed
2022-11-30 07:19:21.030Z - ServerRegistrationManager - RegAsm: exited with code 0
2022-11-30 07:19:21.036Z - ServerRegistrationManager - RegAsm: Output: Microsoft .NET Framework Assembly Registration Utility version 4.8.4084.0
for Microsoft .NET Framework version 4.8.4084.0
Copyright (C) Microsoft Corporation.  All rights reserved.
Types registered successfully
2022-11-30 07:19:21.042Z - ServerRegistrationManager -     .\CountLinesExtension.dll installed and registered.

I have been scratching my head with this one also. I would guess there is still no support for Windows 11. Check issue 364. I hope it helps.

I am currently using the System.Runtime.InteropServices.RegistrationServices class to automate the installation from the installer/debug project without any issues.
private readonly RegistrationServices _registrationServices = new();
// Registration
if (!_registrationServices.RegisterAssembly(GetType().Assembly, AssemblyRegistrationFlags.SetCodeBase))
{
       throw new InstallException("Failed to register the extensions.");
}

// Unregister
if (!_registrationServices.UnregisterAssembly(GetType().Assembly))
{
    throw new InstallException("Failed to unregister the extensions.");
}

This code can be executed from another assembly like a Console App referencing the extensions dll or directly through a System.Configuration.Install.Installer class within the extensions assembly that could be used as a Custom action from the visual studio installer project.
I personally never used the srm tool because the RegistrationServices class takes care of this.

private readonly RegistrationServices _registrationServices = new();
// Registration
if (!_registrationServices.RegisterAssembly(GetType().Assembly, AssemblyRegistrationFlags.SetCodeBase))
{
throw new InstallException("Failed to register the extensions.");
}
// Unregister
if (!_registrationServices.UnregisterAssembly(GetType().Assembly))
{
throw new InstallException("Failed to unregister the extensions.");
}

i am having trouble with registering dll for Windows 11 and i have tried your suggestion to get it work but had no luck
here my code
        Assembly asm = Assembly.LoadFile("CountLinesExtension.dll");
        // Registration
        if (!_registrationServices.RegisterAssembly(asm, AssemblyRegistrationFlags.SetCodeBase))

{
throw new InstallException("Failed to register the extensions.");
}
// Unregister
if (!_registrationServices.UnregisterAssembly(asm))
{
throw new InstallException("Failed to unregister the extensions.");
}
}
can you please guide me where i am doing at mistake?

Here is a full working example
`
[RunInstaller(true)]
public partial class RegAsmInstaller : Installer
{
private readonly RegistrationServices _registrationServices;
    public RegAsmInstaller()
    {
        InitializeComponent();
        _registrationServices = new RegistrationServices();
    }

    [SecurityPermission(SecurityAction.Demand)]
    public override void Install(IDictionary stateSaver)
    {
        base.Install(stateSaver);

        if (!_registrationServices.RegisterAssembly(GetType().Assembly, AssemblyRegistrationFlags.SetCodeBase))
        {
            throw new InstallException("Failed to register shell extensions.");
        }

        RefreshExplorer();
    }

    [SecurityPermission(SecurityAction.Demand)]
    public override void Commit(IDictionary savedState)
    {
        base.Commit(savedState);

        if (!_registrationServices.RegisterAssembly(GetType().Assembly, AssemblyRegistrationFlags.SetCodeBase))
        {
            throw new InstallException("Failed to register shell extensions.");
        }

        RefreshExplorer();
    }

    [SecurityPermission(SecurityAction.Demand)]
    public override void Rollback(IDictionary savedState)
    {
        base.Rollback(savedState);

        if (!_registrationServices.UnregisterAssembly(GetType().Assembly))
        {
            throw new InstallException("Failed to unregister shell extensions.");
        }

        RefreshExplorer();
    }

    [SecurityPermission(SecurityAction.Demand)]
    public override void Uninstall(IDictionary savedState)
    {
        base.Uninstall(savedState);

        if (!_registrationServices.UnregisterAssembly(GetType().Assembly))
        {
            throw new InstallException("Failed to unregister shell extensions.");
        }

        RefreshExplorer();
    }

    public void RefreshExplorer()
    {
        try
        {
            PInvoke.SHLoadNonloadedIconOverlayIdentifiers();
        }
        catch (Exception ex)
        {
            MessageBox.Show("Could not refresh Windows Explorer" + Environment.NewLine + ex.Message);
        }
    }
}

class PInvoke()
{
    [DllImport("shell32.dll")]
    public static extern bool SHLoadNonloadedIconOverlayIdentifiers();
}

`
Now in your VS Installer Project, you need to reference the dll containing this installer class in your Custom Actions screen. Right click on the installer project, View Custom Actions the right Click on Install and Select Add Custom Action, the select Application Folder.

The SourcePath should reference the output


fix: update ibm provider version to support cbr module

Description
Updated ibm provider version to support cbr module
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 2.2.3 :tada:
The release is available on:

GitHub release
v2.2.3

Your semantic-release bot :package::rocket:


Synchronize data splitting for composing and tuning

The metric for composer and tuner are different for same pipeline

For better interpretability, it should be synchronized.

Will be closed by #985.


Trigger a many-framework build on main changes

Make sure we didn't break anything by triggering an many-framework build when the many-rs main branch changes.

Closing as we now have a mono repo.


Add/Remove CookieJar methods must return value

Consider CookierJar return a boolean value on addCookie or removeCookie methods.
Issue: #14047

Landed in https://github.com/ariya/phantomjs/commit/d0388371cfda166d97165c1b68182857b954cc83


Live Feedback -> Live Satisfaction

@Munter - good point, I had a play with using describe.each to test both methods, but it got pretty clunky. I'll think about this in a future PR, want to get this merged for now.


Iox #433 rework build and test tooling

Pre-Review Checklist for the PR Author

[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[ ] All checks have passed
[x] Assign PR to reviewer

Notes for Reviewer
We have inconsistencies between the cmake build and the build script and documentation, this should be cleaned up.

buildflags in iceoryx_meta and build script
documentation
copyright headers in cmake files
add -O2 optimization for gcc/clang
harmonize buildflags in cmake and script
create a separate cmake file for all options where the user have an overview
move more build functionality from bash into cmake
test execution can be done in cmake (see tests.cmake in iceoryx_meta)
out-of-tree build for all examples

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

[ ] All checkboxes in the PR checklist are checked or crossed out
[ ] Merge

References

Closes #433

maybe its better to merge the docu PR first and then i resolve conflicts and adapt my doc afterwards


Revert "Revert "Use a normal SearchBuilder to get all sanity checks and preprocessing…""

Reverts vespa-engine/vespa#6964

@bratseth PR


Import JSON Templates

This new Template subclass makes it possible to import most Cloudformation templates as JSON and parse them as Troposphere objects. This is different from cfn2py in that it's not trying to write actual python code, but rather instantiate the actual objects without the need to edit it afterwards.
There are probably a few tropo-specific AWSHelperFns that won't be parsed correctly, but the ones included in the tests/examples_output are all supported. I believe an effort should be done to normalize the helper functions into something discoverable with a consistent use - but I have yet to really ponder on that issue.

Thanks!


Switching between users freeze session

Hi to you all and first, thanks for RDPWrap.
While I've been able to install and use RDPWrap in Windows 11 pro lastest version 9xx something (still, conf says : not supported), I have an issue I'm not too sure where to start looking. I've created 2 admin users, and I'm starting 2 rdp sessions concurrently using port 3392 (I'm already wondering if it's not an issue to use the same port for the 2 sessions ?).
As the 2nd session is opening, everything's fine, but if i switch back to the 1st user rdp session, everything is frozen, and I can't do anything except to disconnect.
Any idea what I'm doing wrong please ? Maybe there's an option I forgot to check ?
Thanks for your help !

hmm... oups. Everything pretty much solved.

rdpconfig shows fully supported now :

the "freeze" issue is related to a strange behavior from remmina (linux remote desktop app) : the frozen session switch issue is still there but as a workaround, if I minimize and then maxmimize the rdp session window again, everything is fine. So it has nothing to do with Windows, much less RDPWrap ^^´.
Sorry for the noise. I'm closing this issue. Thank you for your answer !


Bulk deleting over API?

Hey,
first of all, let me say that this project is awesome. Thank you very much for all the effort that you have put into it. We really enjoy working with LuckPerms.
I would like to know, what would be the best idea to accomplish bulk editing over your API. Once a month, we need to remove all players from a bunch of groups. Of course I can write SQL to do so, but I'm caring about synchronisation then. My second (hacky) idea was to use your CLI (/lpb bulkupdate) but that won't work because the command needs to be confirmed.
Can you give us a little help? :-)

Currently not possible with the API, and unlikely to be in the future.
The code for the bulkupdate system isn't very compact, and I'm not really comfortable exposing it in the API directly at the moment, as it prevents me from changing the implementation as freely in the future.
https://github.com/lucko/LuckPerms/tree/master/common/src/main/java/me/lucko/luckperms/common/bulkupdate
My suggestion would be to just execute the SQL query directly (since that's effectively all that bulkupdate does!), and then calling the sync method - either by running /lpb sync as console, or using the LuckPermsApi#runUpdateTask method in the API.
I hope that answers your question. :)


New cop Style/FirstParameterIndentation

Add a cop that checks the indentation of the first parameter in a method call. Part of solution for #1144 -- we also need a cop for "hanging closing parenthesis".
I saw a need for different styles:

consistent is the most common style if I look in my installed gems.
special_for_inner_method_call follows my emacs settings and @bbatsov's suggestion in #1144.
special_for_inner_method_call_in_parentheses is the middle ground that follows #1144 and the most prevalent style in the rubocop code base.

The code looks good to me, but I'd suggest describing in the class doc why it's fine for us to check only for the first argument as outsiders will likely be surprised by this.

Good idea. Updated the comment heading.

:+1:

Coverage decreased (-0.17%) to 99.47% when pulling 5526f812037861867913e493d264b0bb8b2a1a4e on jonas054:1144_param_indent into 2a506689c84471c5e2ff4992f0155f0472761942 on bbatsov:master.

Coverage decreased (-0.17%) to 99.47% when pulling 5526f812037861867913e493d264b0bb8b2a1a4e on jonas054:1144_param_indent into 2a506689c84471c5e2ff4992f0155f0472761942 on bbatsov:master.


How to configure (missing link in README file)?

So I have everything installed in brackets but only error it shows is when I put single (unclosed) curly bracket somewhere in the code. Otherwise it always shows green check mark even when there are errors. So I guess I must configure it somehow but I can't find clear instructions and the link to sample file in README.md is dead. How should the config file look, where do I put it and is there anything else that needs to be done in order for Brackets to be able to get all the files it needs?

You configure it the same way you'd configure eslint without Brackets. Just place .eslintrc file in your project like you can see for example here: https://github.com/adobe/brackets
Read more here: http://eslint.org/docs/user-guide/configuring

Extension should provide you the same results/checks that you get when you run eslint . from the command line/terminal of your project directory.

Tip: go to your project folder and run:
npm install -g eslint
eslint --init

That will create a configuration file for you.

Thanks! :)


Nominatim lookups failing for some parts of Brooklyn

A user in #osm IRC reported that they were not seeing the address field. This usually means that the Nominatim service is down (see #4198) but in this case the service is up and responding wtih "unable to geocode".
The query is here:
https://nominatim.openstreetmap.org/reverse?addressdetails=1&format=json&lat=40.5868726&lon=-73.9718928&zoom=13
And it works ok without the zoom=13 parameter:
https://nominatim.openstreetmap.org/reverse?addressdetails=1&format=json&lat=40.5868726&lon=-73.9718928
Maybe that part of Brooklyn is too near the coast and at low zooms, Nominatim picks a location in the ocean?  Needs investigation..

Looks like this was fixed upstream


SOL-95364: 400 Invalid Queue Endpoint return code

Added test to verify that the CCSMP subcode 164 is mapped correctly and is passed to the application through an error when a persistent receiver tries to provision and bind to a non durable queue but uses the name of a pre-existing durable queue.

@TrentDaniel, it looks like you have some failing unit tests in this PR - https://github.com/SolaceDev/pubsubplus-go-client/actions/runs/10925723303/job/30327880565?pr=63

@TrentDaniel, it looks like you have some failing unit tests in this PR - https://github.com/SolaceDev/pubsubplus-go-client/actions/runs/10925723303/job/30327880565?pr=63

@oodigie , this unit test failure seems to be a timeout during a test that was not changed by this branch. This branch only added a test, and did not make changes to the implementation or preexisting test that failed before. Have you seen a problem like this in the API before? If there is not already a ticket open to address this, then we should open one now. I was unable to reproduce the issue locally, although I only ran the test a few times.

I think if we should be fine if you rerun the Git-actions and it resolves. And also if you cannot reproduce the test failure locally. It probably might have been something with the node in Git-actions or some rare race condition test.

The use of a hardcoded solbroker in the v-rid name of the temporary endpoint name should be data driven. There is PUBSUB_HOSTNAME envar/testContext injection. The name should be message.hostname or testcontainer.broker_hostname driven not hardcoded.

When I run my poc solution locally, the API will create a non-durable queue on the broker with the string solbroker instead of localhost or whatever else I try to use for the queue. Either this is hardcoded into the API or its hardcoded in the broker, which could be possible since this aspect of the queue name is not configurable by the customer. @cjwmorgan-sol , if there are no other changes needed, please approve and merge this PR. If you have questions about the queue name, we can go over it tomorrow.

Either this is hardcoded into the API or its hardcoded in the broker,
This is configured in the broker using cli commands:

enable
configure
hostname <name>

When using containers it ends up as the container hostname from the docker compose.
I took a look into the testcontext. The testcontext.Messaging().Hostname is the messaging connection (or PUBSUB_HOST) not the broker hostname (PUBSUB_HOSTNAME). So as you have determined when set to localhost this will not work. There is no testcontext.TestContainer configuration that is accessible outside of the testcontext module. An accessor could be added, but there is another way as well using receiverInfo and binding a flow with a non-durable queue.
I would add the only other use of #P2P/QUE/v:solbroker in the tests attempts to subscription to a queue as a topic where #P2P/QUE/ prefix is likely enough. Ie the v:solbroker does not matter.
The usage here for the non-durable name queue the #P2P/QTMP/v:<vrid> must match the configured hostname. Leading to issues as the target broker hostname is not always solbroker.
I think the best approach here is to bind to a non-durable queue endpoint then get the name and parse out the vrid from the pattern #P2P/QTMP/v:([a-zA-Z0-9]+)/.* (note please double check the regex) if that parsing does not work default to solbroker though ideally default to testcontext.TestContainer.BrokerHostName then when empty default to solbroker.


Error when Your excel file can not be successfully loaded by pd.read_excel, please double check and submit again

Hi. I came across this error after submitting the file here: https://mmbench.opencompass.org.cn/mmbench-submission.  May I ask what may cause this problem?

Hi, would you please check it the submitted excel file can be successfully loaded by pd.read_excel?


Updating storybook breaks the current configuration

Describe the bug
Updating storybook, especially @storybook/preset-typescript from 1.2.0 to 3.0.0 breaks the current configuration. So, after updating, fix storybook.

I updated storybook, so this needs some work.


Issue with custom data.

I am currently running

SpongeForge version: RB 7.1.4

SpongeVanilla version: -

Java version: 8

Operating System: Debian 9

Plugins/Mods: spongeforge, pixelmon, economylite, luckperms, pixelmoney, uniquecosmetics

Issue Description
After updated my server to SpongeForge RB  7.1.4, some players are throwing exceptions when trying to login. Before SpongeForge RB 7.1.4 I was running SpongeForge 3392.
Stack trace
https://gist.github.com/teitss/f0607af91cd5aa57217578377277aad0

Your plugin needs to register keys during the event. The problem here is that the server has long since started and keys are only being constructed then, when they should be constructed during the registration event.
I'm leaving the issue open because we can improve the error handling and message to make this clearer for others in the future.

Alright, now I'm registering my data and keys in correct events, it's working fine, ty


Theme Localisation not working in dev-branch

Winter CMS Build
dev-develop
PHP Version
8.1
Database engine
MySQL/MariaDB
Plugins installed
No response
Issue description
The theme localisation works in 1.2.1 but not in dev-develop with the same theme
Screenshot from 1.2.1

Screenshot dev-develop

Theme-folder and theme-code is identical. The only difference: 1.2.1 runs on php 8.1 and dev-develop on php 8.0
Steps to replicate

Workaround
No response

Hmm, not sure why that wouldn't be working. Are you able to test it out with some debugging statements to see what's going wrong?
The logic gets kicked off at https://github.com/wintercms/winter/blob/develop/modules/cms/classes/Theme.php#L74-L76 and is executed here: https://github.com/wintercms/winter/blob/develop/modules/cms/classes/Theme.php#L579.
https://github.com/wintercms/winter/blob/develop/modules/cms/controllers/ThemeOptions.php#L138 should be running before the fields are rendered.
I'm guessing the recent Child Theme feature changes probably introduced the issue but not sure what it is at the moment.

I'll test it out tomorrow :)

@xitara Do you have the DarkBackend plugin installed?

@WebVPF I use dark reader extension in chrome.
I'm working on a darkmode plugin that looks similar, but it  isn't ready now

@xitara I'm sorry. I thought you had an older version of the DarkBackend plugin installed. Once the styles were similar.
Thought you need to reinstall plugin.
Here are screenshots of the plugin: https://github.com/WebVPF/wn-darkbackend-plugin/issues/6

I'll take a look :)

@LukeTowers I got it.
The themes. prefix was missung. Sent a pull request


Removed AFBase64EncodedStringFromString static function

More cleanup for OS X 10.9 / iOS 7.0
And more tests too. 😃

:beers:


Lint CMake files

What should be added?
A linter that ensures our cmake files are linted/formatted properly (or consistently at least)
https://github.com/cheshirekow/cmake_format was linked by @AnotherFoxGuy
Why should it be added?
Because having strict formatting in files is good. Good reason! xD

What is the reason for closure?

To clarify, I don't think there's much value in the formatting of the cmake files. Linting would be useful, but the linter is basically a formatter that just tells you things aren't formatted properly.
If there's a linter available that gives us actual warnings for things we do wrong, I'd be happy to have that implemented still, but it's not something I want to have an open issue for

There is also https://github.com/BlankSpruce/gersemi which allows you to check and format CMake files
You can also make it a git pre-commit hook: https://github.com/BlankSpruce/gersemi#pre-commit-hook


Failed to install 0.15.1 with 'stderr maxBuffer exceeded' error

Hi, I experienced the following issue on Mac OS 10.11.6 (and 10.11.5). Node v. 4.4.3.
npm info preinstall<EMAIL_ADDRESS>
><EMAIL_ADDRESS>preinstall /Users/anastasiazotova/lampa-docker/lampa-root/lada/node_modules/nodegit
> node lifecycleScripts/preinstall

[nodegit] Running pre-install script
[nodegit] npm@2 installed, pre-loading required packages
[nodegit] ERROR - Could not finish preinstall
{ [Error: stderr maxBuffer exceeded] cmd: '/bin/sh -c npm install --ignore-scripts' }
npm verb unsafe-perm in lifecycle true
npm info<EMAIL_ADDRESS>Failed to exec preinstall script
npm verb unlock done using /Users/anastasiazotova/.npm/_locks/nodegit-a5f407442d9071bb.lock for /Users/anastasiazotova/lampa-docker/lampa-root/lada/node_modules/nodegit
npm verb stack Error<EMAIL_ADDRESS>preinstall: `node lifecycleScripts/preinstall`
npm verb stack Exit status 1
npm verb stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:217:16)
npm verb stack     at emitTwo (events.js:87:13)
npm verb stack     at EventEmitter.emit (events.js:172:7)
npm verb stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:24:14)
npm verb stack     at emitTwo (events.js:87:13)
npm verb stack     at ChildProcess.emit (events.js:172:7)
npm verb stack     at maybeClose (internal/child_process.js:827:16)
npm verb stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
npm verb pkgid<EMAIL_ADDRESS>npm verb cwd /Users/anastasiazotova/lampa-docker/lampa-root/lada
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>preinstall: `node lifecycleScripts/preinstall`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script 'node lifecycleScripts/preinstall'.

Update: upgrading to node v.6.2.2 seems to have solved the issue.

Also reported against npm: https://github.com/npm/npm/issues/11670

Would that be possible to try that with an older node and npm 3.9.0? It would be good to check if this is really an npm issue. What version of npm did you have before with node v4?

I had npm v2.15.1 with node v. 4.4.3. I'll try to test it with the combination of node v.4.4.7 and npm 3.9.0 this weekend.

I tested it with node v. 4.5.0 and npm v. 3.10.6 (is this ok or should it be npm 3.9.0 specifically?) I installed nodegit successfully. These are nodegit-related messages that I see in the terminal:
><EMAIL_ADDRESS>preinstall /Users/anastasiazotova/lampa-docker/lampa-root/lada/node_modules/.staging/nodegit-1a22ffce
> node lifecycleScripts/preinstall

[nodegit] Running pre-install script
[nodegit] Configuring libssh2.
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

><EMAIL_ADDRESS>install /Users/anastasiazotova/lampa-docker/lampa-root/lada/node_modules/nodegit
> node lifecycleScripts/install

[nodegit] Running install script
[nodegit] Success: "/Users/anastasiazotova/lampa-docker/lampa-root/lada/node_modules/nodegit/build/Release/nodegit.node" is installed via remote
[nodegit] Completed installation successfully.

><EMAIL_ADDRESS>postinstall /Users/anastasiazotova/lampa-docker/lampa-root/lada/node_modules/nodegit
> node lifecycleScripts/postinstall

This seems to be an npm bug then. According to https://github.com/npm/npm/issues/11670 it was broken with npm v3.7.3 and worked after upgrade to v3.9.0, I don't know when and how exactly this got fixed.

It was crashing for me due to running npm install --save nodegit while having an npm-shrinkwrap.json file... I deleted the shrinkwrap and it installed fine.

Closing this as an npm bug.


Field level overrides

we can't mask a field by just replacing it with the word "mask" so we are adding a special function
an example is domo erasure

From Neville:

One thing to add: in my opinion we'll need to allow "field-level" overrides as the escape hatch here. For example, if I know I have a field in my database that simply cannot be hashed, despite being a string, I could specify something inline like:

fides_meta:
  - data_type: string
    masking_strategy: null_rewrite


refactor:load keywordChecker through SPI,make the code in KeywordCheckerFactory more stable

Ⅰ. Describe what this PR did
(1) Make the constructor of KeywordChecker(msql,oracle) public so that they can be loaded by SPI(EnhancedServiceLoader)
(2) Add keywordChecker resource file
(3) KeywordCheckerFactory no longer recognize specific db type,when more database types are supported in the future, its code does not need to be changed
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1957 into develop will increase coverage by <.01%.
The diff coverage is 93.33%.

@@              Coverage Diff              @@
##             develop    #1957      +/-   ##
=============================================
+ Coverage      55.29%   55.29%   +<.01%
- Complexity      2408     2409       +1
=============================================
  Files            429      429
  Lines          14279    14275       -4
  Branches        1676     1676
=============================================
- Hits            7896     7894       -2
  Misses          5675     5675
+ Partials         708      706       -2

Impacted Files
Coverage Δ
Complexity Δ

...urce/undo/oracle/keyword/OracleKeywordChecker.java
100% <100%> (+0.76%)
8 <1> (-1)
:arrow_down:

...source/undo/mysql/keyword/MySQLKeywordChecker.java
98.91% <100%> (+0.33%)
6 <1> (-1)
:arrow_down:

...eata/rm/datasource/undo/KeywordCheckerFactory.java
92.85% <92.3%> (-7.15%)
5 <4> (+1)

...server/store/file/FileTransactionStoreManager.java
56.19% <0%> (-0.32%)
29% <0%> (ø)

...o/seata/server/coordinator/DefaultCoordinator.java
48.41% <0%> (+0.39%)
28% <0%> (+1%)
:arrow_up:

...in/java/io/seata/server/session/GlobalSession.java
85.02% <0%> (+0.48%)
68% <0%> (+1%)
:arrow_up:

LGTM

thanks for your approval ,could you help to notify other reviewer to review this pr?

@CharmingRabbit Is it possible to add any test case to veriy this feature?

@CharmingRabbit Is it possible to add any test case to veriy this feature?

@xingfudeshi
This refactoring only changes the internal logic of the Factory and the creation logic of the specific keywordChecker. The usage scenario does not change.
Therefore, the existed test cases (KeywordCheckerFactorTest, OracleKeywordCheckerTest, MySQLKeywordCheckerTest) can completely cover the code after refactoring.


Segmentation fault when re-building

It builds without error on first rake build run, but then I get segmentation fault on the following rake build runs. Error dissapears when I run rake clobber before each run to clean stuff. Even when segmentation fault error shows, it looks like it's doing a good build. It seems to be consistently happening across all Ruby versions for me and is caused by the require of native.so.
Output for ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]:
$ rake build
Building hello_world
{}
cargo rustc --release -- -C link-args=-Wl,-undefined,dynamic_lookup
    Finished release [optimized] target(s) in 0.0 secs
[BUG] Segmentation fault at 0x00000000003780
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

-- Machine register context ------------------------------------------------
 RIP: 0x0000000000003780 RBP: 0x00007ffda040a440 RSP: 0x00007ffda040a228
 RAX: 0x00007fec25490e18 RBX: 0x00007fec2fb76180 RCX: 0x0000000000000000
 RDX: 0x0000000000000000 RDI: 0x00007fec25693040 RSI: 0x0000000000000000
  R8: 0x0000000000000000  R9: 0x00007fec2bdabe88 R10: 0x00007fec25693038
 R11: 0x00007fec2ba234a0 R12: 0x00007fec2548f848 R13: 0x000000000000002c
 R14: 0x0000000000000000 R15: 0x00007ffda040a230 EFL: 0x0000000000010202

-- C level backtrace information -------------------------------------------
Segmentation fault (core dumped)

Output for ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]:
$ rake build
Building hello_world
{}
cargo rustc --release -- -C link-args=-Wl,-undefined,dynamic_lookup
    Finished release [optimized] target(s) in 0.0 secs
[BUG] Segmentation fault at 0x00000000003780
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]

-- Machine register context ------------------------------------------------
 RIP: 0x0000000000003780 RBP: 0x00007ffca715fd80 RSP: 0x00007ffca715fb68
 RAX: 0x00007fc61006de18 RBX: 0x00007fc61b3d0200 RCX: 0x0000000000000000
 RDX: 0x0000000000000000 RDI: 0x00007fc61049a4e8 RSI: 0x0000000000000000
  R8: 0x0000000000000000  R9: 0x00007fc6165c2e88 R10: 0x00007fc61049a1c0
 R11: 0x00007fc61623a4a0 R12: 0x00007fc61006c848 R13: 0x000000000000002c
 R14: 0x0000000000000000 R15: 0x00007ffca715fb70 EFL: 0x0000000000010202

-- C level backtrace information -------------------------------------------
Segmentation fault (core dumped)

Output for ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-linux]:
$ rake build
Building text_transform
{}
cargo rustc --release -- -C link-args=-Wl,-undefined,dynamic_lookup
    Finished release [optimized] target(s) in 0.0 secs
[BUG] Segmentation fault at 0x00000000003720
ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-linux]

-- C level backtrace information -------------------------------------------
Segmentation fault (core dumped)

I think the issue has to deal with the fact that we've loaded the library in memory when we run rake build in the parent project.
Might be able to fix this by not loading the entire application when our rake build happens, but the default Rakefile looks like this:
require_relative 'config/application'

Rails.application.load_tasks

so that might be rather difficult...
You can see that native.so is loaded by printing out $" after the ParentBuildTask#build loop.

Issue is with copy_native.  We copy over the native library when it's already loaded.

Ah interesting, we've done a lot of our active testing on macOS which behaves a bit differently in this area. Probably the solution would be to detect the rake build happening and avoid loading the native extension in this case, if that is feasible.

is there a temporary workaround that doesnt involve rebuilding everything? my rust crate is rather large

Confirmed on Ruby 2.2, Rails 3.2 on Debian Jessie.


add_toolbar_button not works when compose window opens

gmail.tools.add_toolbar_button(logo_html, function() {
  // Code here
}, 'logo');

does not add button when compose window opens ,else it works well
api.dom.toolbar  returns as selector:"[gh='mtb']" , when compose window opens

First patan should be compose-instance from event.
That at least works for me.

why should i need compose instance to add button in gmail toolbar?

Just to double-check: Does this apply to the function always, or is this an error introduced with new Gmail?

'content_html' button shows onload

button doesn't shows when page reload by opening compose window

'content_html' button shows onload

button doesn't shows on page reload by opening compose window

That’s a known issue. You will have to re-add your buttons on reloads or layout changes.
That’s also the expected behavior which people have written code to anticipate in numerous extensions, so we won’t change that now.

issue fixed by re-add button


Treasury redesign

Description
Implements a redesign of the Treasury page.
Notes

This PR doesn't implement the Send Assets button modal, that will come in a later PR.
This also doesn't implement historical price, as the designs show in the Transactions list.  This is a bit more complex and will come in a later PR as well.
Coin icons and NFT images aren't returned via the Safe API on Georli.  I've checked the mainnet API and they return as expected, but for Georli this page is going to look janky, even when I have default images.

Still waiting on three assets:

Ether token icon
fallback NFT image
fallback coin icon

I've stubbed all three just with plain colors for now...
Issue / Notion doc (if applicable)
Figma design:
https://www.figma.com/file/nKTAQ6bivtHMwc3O5FG47l/📚-Fractal-Design-Handoff-|-Approved-Pages-|-October-2022?node-id=2252%3A19350
Closes https://github.com/decent-dao/fractal-interface/issues/616
Testing
Please test with DAOs that have a number of assets.  I've been using:
http://localhost:3000/#/daos/0xB87AD11E40F66137BD4cbB5f9d9438451000251B/treasury
Screenshots (if applicable)

Should we show $0.00 under the transfer amount, (if fiat isn't available for goerli probably should just be 0.00. UI looks lonely without it

Could you extract some of the methods (utils) and other components out of the Assets.tsx and Transactions.tsx to make it a little smaller files. I actually hadn't decided on whether to add this comment, so feel free to ignore, this could just be preference lol.

Yeah, I've tried to extract things we may likely reusing (like the gold address link), but I'm not sure there's much else we would want pulled out.
I would like to improve on the data formatting in some way, and have a central set of methods for getting common things like formatted price and such, as we're discussing in Discord

Should we show $0.00 under the transfer amount, (if fiat isn't available for goerli probably should just be 0.00. UI looks lonely without it

Yeah, I mentioned in the description, but this PR doesn't address the price in the transfers list, since the pricing data isn't returned in the Gnosis API here.
We'll have to use a different API for the historical price.  Coingecko has one that seems fine, but I figured I'd address that specific field in a followup PR, as this one was getting a bit large already.

@Da-Colon this has been refactored quite a bit, and ready to review again

Should the top Title stay static as you scroll?

I don't think so.  It would be weird to have a top nav and a static title I think

@Da-Colon I refactored a bunch and did some other cleanup of this.
For the NFT, Eth, and token default icons, now I see what you were saying before about Icon vs. importing as SVG.
Is there a way I can get those SVGs from the library?  I'd like to use them as fallbackSrc for the images.

@mudrila @tbwebb22 @christopherdancy could you guys this one one a look as well, I'd like to close this out

Is there a way I can get those SVGs from the library? I'd like to use them as fallbackSrc for the images.

@herbig cool beans I'll take care of that and those available as SVGs as well, in the morning, get it in a release.

is the eth icon being used as a fallback or can this svg be removed?

it's used in the same component that normally takes a URL for the token image, so I think it needs to be in here

@herbig weird this PR is stuck in a 'Some checks haven't completed yet' state.

This treasury page looks dope! I just have one question - looks like the treasury doesn't update real-time as the assets are deposited / withdrawn. I think this is because we are using the Gnosis API instead of on-chain events. Do we want the treasury data to update realtime or are we alright with the user needing to refresh for now?

Yeah.. since we're not listening to the contracts, we lose the realtime updating with the Gnosis API.
There might be a solution, like a background timer to trigger a refresh of data on a page or something, but that would need to be thought out.
For now, given we're using the Gnosis API for all of this I think that's alright.

This treasury page looks dope! I just have one question - looks like the treasury doesn't update real-time as the assets are deposited / withdrawn. I think this is because we are using the Gnosis API instead of on-chain events. Do we want the treasury data to update realtime or are we alright with the user needing to refresh for now?

Yeah.. since we're not listening to the contracts, we lose the realtime updating with the Gnosis API.
There might be a solution, like a background timer to trigger a refresh of data on a page or something, but that would need to be thought out.
For now, given we're using the Gnosis API for all of this I think that's alright.

Cool, sounds good.


Change "Share" to "Copy link to {thing}" on web

Fixes #1107
Are we supposed to run the lingui cli for every change like this by the way?

Are we supposed to run the lingui cli for every change like this by the way?

Not sure, this is all new territory

Another great PR, thanks!


Build a kernel with proper LOCALVERSION

Windows Version
Microsoft Windows [Version 10.0.19045.2728]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
No response
Other Software
No response
Repro Steps
Check kernel version string, uname -r or another tool.
Expected Behavior
No + at the end of kernel version.
Actual Behavior
<IP_ADDRESS>-microsoft-standard-WSL2+ indicating it was build from an unclean git branch.  The + confuses some apps. Kernel config does have proper string: CONFIG_LOCALVERSION="-microsoft-standard-WSL2"
Diagnostic Logs
No response

@kelsey-steele - do you know why there is a + at the end of the kernel version string?

@benhillis This is linked to the new build process for the kernel. I'll check in to getting that changed.


Better error handling when error parameter is not specified

Currently, if one of the free parameters in the noise model is not specified, the output error when trying to create a circuit is:

I believe it should be improved by checking first that the parameter is not None (because it is the default value). If it is None, raise an error saying that it was not set up. Also mention in the docstrings that a parameter cannot be setup to None and check that this is not the case when doing model.set_var_param.

I believe that the checking should happen when calling model.param (i.e. self.param in the screenshot from the issue). If one tries to access a param that has not been set up, an error should be raised.


Support for the execution policy API in JobSet

What would you like to be added:
The new executionPolicy API which allows to submit replicated Jobs in order.
When the first replicated Jobs are the reached required condition, the next replicated Jobs are created.
Note. The complex DAG workflow capability is out of scope of this API, since we don't want to implement workflow functionality as part of this KEP. Users should consider to use Argo Workflows or Tekton Pipelines if they need it.
The initial API design:
type JobSetSpec struct {
	ExecutionPolicy *ExecutionPolicy `json:"executionPolicy,omitempty"`
}

type ExecutionPolicy struct {
	// Order in which Jobs will be created. The default is AnyOrder.
	ExecutionPolicyOrder ExecutionPolicyOption `json:"executionPolicyOrder"`

	// After all replicated Jobs reach this status, the JobSet will create the next replicated Jobs.
	ReplicatedJobsStatus ReplicatedJobsStatusOption `json:"replicatedJobsStatus"`
}

type ExecutionPolicyOption string

const (
	AnyOrder ExecutionPolicyOption = "AnyOrder"

	InOrder ExecutionPolicyOption = "InOrder"
)

type ReplicatedJobsStatusOption string

// We don't add Ready condition here, since users can use the `startupPolicy` API for that.
const (
	ReadyStatus ReplicatedJobsStatusOption = "Succeeded"

	FailedStatus ReplicatedJobsStatusOption = "Failed"

	ActiveStatus ReplicatedJobsStatusOption = "Active"

	SuspendedStatus ReplicatedJobsStatusOption = "Suspended"
)

Why is this needed:
More context in this Kubernetes wg-batch thread: https://kubernetes.slack.com/archives/C032ZE66A2X/p1725400839102729
As part of the Kubeflow Training V2 APIs, we want to implement the LLM runtimes for LLMs fine-tuning: https://github.com/kubeflow/training-operator/issues/2170
That will require JobSet to orchestrate the sequence of 2-3 Jobs: Initializer -> Trainer -> Post-Processor.
The capacity management for such workload should be allocated for all Jobs combined and be controlled by Kueue.
When TrainJob is suspended, we will suspend all underlying Jobs.
I think, we might have more use-cases from the HPC side. Any thoughts @vsoch  @alculquicondor ?
This enhancement requires the following artifacts:

[x] Design doc
[x] API change
[x] Docs update

The artifacts should be linked in subsequent comments.
cc @tenzen-y @kannon92 @ahg-g @johnugeorge @akshaychitneni @shravan-achar

/kind feature
/kind api-change

SGTM!
(The description shouldn’t be a design but I think that we don’t need suspended. And you also declare ReadyStatus for the succeeded state)

This would be great! I agree to not try to create a workflow tool, but allowing this basic dependency structure is something that workflow tools can use. +1 from me.

That sounds like a really cool feature!  I'm curious about something though. Currently, in the Jobset, we have multiple policies like StartupPolicy and FailurePolicy. As we keep adding more features to our policies, we might to think about whether we should make them work together or if we need to set some restrictions.(for example, can StartupPolicy and ExecutionPolicy coexist) This way, users can avoid making a lot of mistakes when using them.

I think the feature makes sense; executing "Initializer -> Trainer -> Post-Processor" stages sequentially for LLM fine-tuning is an interesting concrete use case. @andreyvelich can you educate me on why the fine-tuning steps must be decomposed into separate jobs? Why can't the same job perform initialization, training, then post-processing?

As we keep adding more features to our policies, we might to think about whether we should make them work together or if we need to set some restrictions.(for example, can StartupPolicy and ExecutionPolicy coexist) This way, users can avoid making a lot of mistakes when using them.

@googs1025 we can add validation to the JobSet webhook which ensures the spec configurations are compatible with eachother.

@andreyvelich can you educate me on why the fine-tuning steps must be decomposed into separate jobs?

@danielvegamyhre Sure. Given the size of today's models (e.g. >100b params) and datasets, the download time for pre-trained model and dataset takes time, e.g. 1-2 hours. If we define this initialization steps as initContainer on the training Node, it will lock the GPUs that we allocate for this training Node.
We don't want to waste GPU resources when we do initialization.

As we keep adding more features to our policies, we might to think about whether we should make them work together or if we need to set some restrictions.(for example, can StartupPolicy and ExecutionPolicy coexist) This way, users can avoid making a lot of mistakes when using them.

The current JobSet APi is alpha. So, I think it would be great to consider how we can cooperate some policies and how we can consolidate some fields into one once we graduate to beta stage.
This is one of the reasons why we keep parking the alpha stage, as we discussed in the previous meeting.

If the goal is not to look the GPUs during other stages, it is important to note what your expectations are for the future when queuing in Kueue.
It sounds like we should be queuing the steps separately, meaning that we need separate "suspend" fields or 3 different objects.

This would be great! I agree to not try to create a workflow tool, but allowing this basic dependency structure is something that workflow tools can use. +1 from me.

My concern is where do we stop. You add this feature now, then someone comes and asks "what if we add X", and suddenly we have a workflow tool.

If the goal is not to look the GPUs during other stages, it is important to note what your expectations are for the future when queuing in Kueue. It sounds like we should be queuing the steps separately, meaning that we need separate "suspend" fields or 3 different objects.

Good point. Actually, I guess that the JobSet already has the same problem in the StartupPolicy. The problem is limited compared with executionPolicy, though. So, I'm wondering if we should investigate a solid approach to support the Jobs with ordering and steps.

My concern is where do we stop. You add this feature now, then someone comes and asks "what if we add X", and suddenly we have a workflow tool.

I have the same concern. So, if we introduce this feature, I think we need to consider API to prevent conditional parameters.
Specifically, the below API has potential extensibility, but I believe that we should not introduce such an extensibility.
type ExecutionPolicy struct {
	// Order in which Jobs will be created. The default is AnyOrder.
	ExecutionPolicyOrder ExecutionPolicyOption `json:"executionPolicyOrder"`

	// After all replicated Jobs reach this status, the JobSet will create the next replicated Jobs.
	ReplicatedJobsStatus ReplicatedJobsStatusOption `json:"replicatedJobsStatus"`
}

It sounds like we should be queuing the steps separately, meaning that we need separate "suspend" fields or 3 different objects.

I think that the separate "suspend" field and 3 different objects are hard to maintain and not straightforward.
So, I'm leaning toward the JobReadynessGate (current K8s does not support it) since it is a straightforward approach and intuitive, simple, and generic approach.

My concern is where do we stop. You add this feature now, then someone comes and asks "what if we add X", and suddenly we have a workflow tool.

+1

I think that the separate "suspend" field and 3 different objects are hard to maintain and not straightforward.

Are you referring to suspending each of the 3 jobs ( Initializer job, Trainer job, Post-Processor job) and resuming them one at a time as the prior job's execution completes?

My concern is where do we stop. You add this feature now, then someone comes and asks "what if we add X", and suddenly we have a workflow tool.

You are starting to sound like me! The answer is that we stop there with a "depends on." If you look at workload managers, it's fairly common to be able to say:
submit job a
submit job b that depends on a

And that's it. There is no further orchestration, suspend or waiting, etc. It's just a flat level depends on that can provide a simple API for actual workflow tools (that represent a dag) to use.

You are saying that you want to support arbitrary DAGs already, whereas the initial proposal is just to support a sequence of jobs. That's the kind of leaps I was rather against.

Where did I say that?

The answer is that we stop there with a "depends on."

Unless I misinterpreted what you were trying to say.

Depends on (in and of itself) does not create what most would consider substantial enough for a workflow DAG. It provides a minimal API in the workload manager so that workflow tools can more easily create complex logic.

https://hpc.nih.gov/docs/job_dependencies.html
https://flux-framework.readthedocs.io/projects/flux-rfc/en/latest/spec_26.html

The workload manager has no knowledge of checking state, submission, or custom action logic beyond the very simple "A depends on B." It's not really enough to be called a workflow but it enables workflow tools to better interact with it.  I am absolutely not saying that I want to support arbitrary DAGs. I am pointing out a common pattern in the workload manager ecosystem for HPC that has existed for decades, and made it possible for workflow tools to better integrate.

Do you have a minimal proposal for what jobset could provide? Are you saying that you want to say "jobset X depends on jobset Y"? I ask that because the current proposal is along the lines of "this jobset has multiple steps within it, each of which can be started after the other".
Those are two very different approaches.

No I don’t think depends on would fall on the level of the jobset, more likely the job.

No I don’t think depends on would fall on the level of the jobset, more likely the job.

I think having the "depends on" relationship operate on the ReplicatedJob level may be better - for example, for something like the "initializer -> trainer -> post-processor" use case described in this issue, I think we may want to have each stage be a separate ReplicatedJob (since for example, the "trainer" stage may be composed of several concurrent jobs running on different groups of infrastructure, but they all depend on the "initializer" stage being completed).

No I don’t think depends on would fall on the level of the jobset, more likely the job.

I think having the "depends on" relationship operate on the ReplicatedJob level may be better - for example, for something like the "initializer -> trainer -> post-processor" use case described in this issue, I think we may want to have each stage be a separate ReplicatedJob (since for example, the "trainer" stage may be composed of several concurrent jobs running on different groups of infrastructure, but they all depend on the "initializer" stage being completed).

Exactly, that is what I had in mind when I suggested this in the slack channel, similar to StartupPolicy which is executed at the ReplicatedJob level too. ExecutionPolicy and StartupPolicy are similar, but one is based on readiness status, the other based on completion status.

also, the suggestion here is not to have an API to explicitly define the chain, it is based on the order in the replicatedJob list, again similar to StartupPolicy.

No I don’t think depends on would fall on the level of the jobset, more likely the job.

I think having the "depends on" relationship operate on the ReplicatedJob level may be better - for example, for something like the "initializer -> trainer -> post-processor" use case described in this issue, I think we may want to have each stage be a separate ReplicatedJob (since for example, the "trainer" stage may be composed of several concurrent jobs running on different groups of infrastructure, but they all depend on the "initializer" stage being completed).

Exactly, that is what I had in mind when I suggested this in the slack channel, similar to StartupPolicy which is executed at the ReplicatedJob level too. ExecutionPolicy and StartupPolicy are similar, but one is based on readiness status, the other based on completion status.

Awesome, well if we are all aligned on this I can implement it.

The only thing we probably want to be configured is how many entries to run sequentially. The default (expressed as nil) is all, but the user could set it to 1 for example to run some initialization for the whole workload and the rest of entries can execute in parallel.

How should we calculate quota usage for such a sequence?

cc @mimowo @mwielgus

Yes, this proposal is only for Job sequence, and as @vsoch mentioned this concept exists in HPC space for a long time.

Awesome, well if we are all aligned on this I can implement it.

@ahg-g @danielvegamyhre Do we need a small KEP for it or we can jump directly to the implementation ?

How should we calculate quota usage for such a sequence?

@alculquicondor I think, in the first iteration we should calculate the quota as for normal JobSet (e.g. admin the JobSet if all replicated Jobs resources are available). However, it would be nice to admin/suspend steps in Job sequence separately.
But I feel that we should discuss it after we integrate Argo Workflow into Kueue: https://github.com/kubernetes-sigs/kueue/pull/2976

@ahg-g @danielvegamyhre Do we need a small KEP for it or we can jump directly to the implementation ?

We should have a KEP for this.

I think, in the first iteration we should calculate the quota as for normal JobSet (e.g. admin the JobSet if all replicated Jobs resources are available). However, it would be nice to admin/suspend steps in Job sequence separately.

I agree that we can leave implementation details for a second iteration. However, there are too many moving pieces here to completely ignore the question until later. We at least need a high level plan of how it's going to work.
Users will be very surprised that Kueue needs to reserve space for all of the steps of the sequence.

But I feel that we should discuss it after we integrate Argo Workflow into Kueue:

Not really. We need to figure out if the proposed design for Argo will also work for Jobset. I don't think it currently does, as the proposal relies on the pod group integration, which wouldn't be ideal for jobset.

/assign @andreyvelich


Add google-oauth

Google oauth

Merged into development branch and added some adjustment to handle case that local user can not be created.
Waiting to merge to master after code refactoring.
Thanks for your contribution!


Whole .NET API documentation favor C++ declarations & chaos in samples

Link to article:
For instance:
• Decimal Struct
• List<T>.BinarySearch(T)
• Parellel.ForEach<TSource>(IEnumerable<TSource>, Action<TSource>)
Problem:
• 1st 2 links lacks C# declaration and samples at all.
• Last combines C++ declaration with C# sample.
I am not sure why there are suddenly these C++ code passages perhpas they relates to C++.NET but
if I remember correctly there were always only C# codes (sometimes VB.NET). This C++ declarations, samples can be now widely found in whole .NET API documentation. Since C# is still the most used .NET language I found not appropriate to favor C++ over C#. There should be both C# and C++ declaration and C# and C++ sample or just C# ones.
Samples and declarations for other languages like VB.NET, F# are also missing so why there are abruptly favored C++ snippets?

There is language switch that I never noticed. For some reason C++ is default. I.e. not a bug.


Fails to build pg gem if postgresql::ruby is included

In order to get the pg gem to install I have to disable postgresql::ruby, wait for recipe to fail because of missing pg. Then, uncomment the include_recipe for postgresql::ruby, then re-run.
In addition, if I don't have default/override settings in my role for ['postgresql']['client']['packages'], that errors too because the default recipe hasn't run.
There's also a warning about compile time false when I run the ruby recipe.
Using Chef omnibus 12.3.0.

+1, I have to do the dame
pg gem fails to build because, for some reason, postgresql::ruby recipe runs before the recipe which installs the make package (despite being after in the run list).

Resolved as of release 4.0.0 - https://github.com/hw-cookbooks/postgresql/releases/tag/v4.0.0


Add let conditions

Occasionally, it can be useful to introduce a new variable in a condition list.
if (is BaseMemberExpression bme = that.primary,
    let text = identifierText(bme.identifier),
    (importMemberAliases[text] else text) in inlineAnnotations) {
    // ...
}

It would be nice if that was legal syntax, instead of having to use workarounds like this:
if (is BaseMemberExpression bme = that.primary,
    exists text = identifierText(bme.identifier) of String?,
    (importMemberAliases[text] else text) in inlineAnnotations) {
    // ...
}

However, there is one problem: let conditions as shown above are very different from let statements, expressions, and (once implemented: see #3483) comprehension clauses – they only introduce one variable, and they aren’t parenthesized. To introduce multiple variables, you would use multiple let conditions instead of one let with multiple patterns. I’m not sure how much that bothers me.

It seems to me that the natural syntax for this would be:
if (is BaseMemberExpression bme = that.primary,
    text = identifierText(bme.identifier),
    (importMemberAliases[text] else text) in inlineAnnotations) {
    // ...
}

The let keyword would be neither regular, nor necessary here.

Looks okay, but might be confusing/ambiguous if the expression happens to be boolean…

True. The = would be mistaken for an assignment operator.

OTOH, I'm pretty sure that assignments in ifs are something we already strongly discourage...

I briefly thought that value might be an alternative keyword to use instead of let, but then I realized that thinking this through most likely means full-featured declarations inside a condition list, either with inferred type (value) or with explicit type. And that starts to feel silly.

I guess what you are trying to achieve by
if (is BaseMemberExpression bme = that.primary,
    let text = identifierText(bme.identifier),
    (importMemberAliases[text] else text) in inlineAnnotations) {
    // ...
}

is either

possibility to have a else statement that executes if any of the conditions fail - without having to duplicate the else as in

if (is BaseMemberExpression bme = that.primary) {
    value text = identifierText(bme.identifier);
    if ((importMemberAliases[text] else text) in inlineAnnotations) {
        // ...
    } else {
        // ...
    }
} else {
    // duplicate code
}

minimize indentation

I do have to say that 1. is something that personally annoys me every now and then. I wonder if there could be some construct to avoid duplicating/outsourcing the else blocks even if you have nested if statements with code in between.. Kindof like throwing an exception "blah this didn't work out, fallback behaviour please".. Hmm could it perhaps even be plausible to use the exception construct but not actually throw exception.. i.e. optimize the case when it is caught locally AND exception object never used.. :) Not that I like try blocks very much.. they mess with the otherwise beautiful indentation of code :)


Windows 10 for Windows Containers

Is there any reason why only Windows Server is supported for Windows Containers? And is it going to be added the support for Windows 10 to use this feature?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3339a2e0-be29-1363-f588-b231d4472c02
Version Independent ID: 72dd11a3-704d-d0fd-6dfa-cf49f3352de3
Content: Container Jobs in Azure Pipelines and TFS - Azure Pipelines
Content Source: docs/pipelines/process/container-phases.md
Product: devops
Technology: devops-cicd
GitHub Login: @thomps23
Microsoft Alias: macoope

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot


Does not work on M1 Macs

M1 Macs should be able to run x86 instructions anyway
Unexpected error: Unsupported architecture
Error: Unsupported architecture

Please can you share the whole error ?
In which context are you using node-java-caller ?
There may be solutions: https://apple.stackexchange.com/a/431576

Sure
Java jre or jdk between 8 and 14 is required
Installing Java jre 14 in /[redacted]/.java-caller...
Unexpected error: Unsupported architecture
Error: Unsupported architecture
at Object.install (/[redacted]/node_modules/njre/lib/install.js:204:32)
at JavaCaller.manageJavaInstall (/[redacted]/node_modules/java-caller/lib/java-caller.js:254:43)
at async JavaCaller.run (/[redacted]/node_modules/java-caller/lib/java-caller.js:86:13)
at async CodeNarcCaller.startCodeNarcServer (/[redacted]/node_modules/npm-groovy-lint/lib/codenarc-caller.js:262:29)
at async CodeNarcCaller.callCodeNarcServer (/[redacted]/node_modules/npm-groovy-lint/lib/codenarc-caller.js:98:22)
at async NpmGroovyLint.callCodeNarc (/[redacted]/node_modules/npm-groovy-lint/lib/groovy-lint.js:235:32)
at async NpmGroovyLint.run (/[redacted]/node_modules/npm-groovy-lint/lib/groovy-lint.js:65:13)
at async /[redacted]/node_modules/npm-groovy-lint/lib/index.js:12:9
I am using it with the library: https://github.com/nvuillam/npm-groovy-lint/issues/214

Reproduced for me with the same library.
workaround

uninstall any Java VMs you have

install openjdk@11 with brew brew install openjdk@11

make it your default JVM as brew suggests sudo ln -sfn<EMAIL_ADDRESS>/Library/Java/JavaVirtualMachines/openjdk-11.jdk

I was able to start npm-groovy-lint after that

it doesn't work if any other JVMs of newer versions (>14) installed. For example, the one from IntelliJ IDEA

even if you specify java binary directly with the -j flag

even if you specify java binary directly with the -j flag

For me, being able to use the -j flag would be enough, but I noticed a bug for it so I raised #23 to address that.

I followed @direvius steps, and then I got:
Unable to start CodeNarc server: {
  "status": 1,
  "stdout": "",
  "stderr": "",
  "childJavaProcess": {
    "_events": {},
    "_eventsCount": 2,
    "_closesNeeded": 1,
    "_closesGot": 1,
    "connected": false,
    "signalCode": null,
    "exitCode": 1,
    "killed": false,
    "spawnfile": "/usr/bin/java",
    "_handle": null,
    "spawnargs": [
      "/usr/bin/java",
      "-Xms256m",
      "-Xmx2048m",
      "-cp",
      "/Users/me/project/node_modules/.pnpm/npm-groovy-lint<EMAIL_ADDRESS>      "com.nvuillam.CodeNarcServer",
      "--server"
    ],
    "pid": 10966,
    "stdin": null,
    "stdout": null,
    "stderr": null,
    "stdio": [null, null, null]
  }
}

["--server"]

npm-groovy-lint results in 0 linted files:

@christopher-francisco please can you share how you call node-java-caller ?

v3.3.0 looks to resolve this, so this issue can be closed.
This is the commit that resolves it https://github.com/nvuillam/node-java-caller/commit/ce4adfe754bdff10c5e4dfd1dc662f7c652eabc5 #50

Thank for you feedback @nzsimonc :)


Use the netty channel allocator to create write buffer

By creating a direct write buffer we can avoid an extra copy
as netty will copy a non-direct buffer to a direct buffer.
By avoiding the Unpooled allocation we can also reduce the
number of new allocations made as the channel alloc will use a
pooled allocation.

Thanks @leachbj
:+1:


plan to support 0.9

Is there any plan to support 0.9 any time soon?
as can be seen here it is now possible to have top-level key/values for things like tags and timestamp in the same level that database exists but I cannot find how to do it in current version of influxdb-client.

For now, you will be able to use this functionnality via the write function (see be476a4628d2505bb91d09fc047dc1d439ce93fc).

@ReAzem -- please reach out to me as needed, to get 0.9 support added to the Python library. I've written a fair amount of Python in my time, so can review coded as needed.
The API docs, in case you haven't seen them, are here:
http://influxdb.com/docs/v0.9/introduction/getting_started.html

@otoolep -- Thank you, If I have questions, I'll contact you. Are you available on IRC? I am always on freenode #influxdb as reazem.
@dashesy
The core functions of the lib now work with 0.9. I am closing I am inviting follow #109 for more details.

Email is best @ReAzem -- I don't tend to be on IRC that much.


SW-1590 Add trash can icon to delete and remove buttons

Add trash can icon to delete and remove buttons. Also make delete and remove buttons icon only in mobile (except for dialog boxes).

@alexTerraformation Everything looks great except we don't want the trash icon in the "Remove" and "Delete" buttons in dialog boxes.


"TypeError: loaders is not iterable" after upgrade to v4

After upgrading to external-svg-sprite-loader version 4, my app is now throwing the follow error when I run Webpack (version 4.25.1):
TypeError: loaders is not iterable
    at SvgStorePlugin.injectSpritesIntoRules (.../node_modules/external-svg-sprite-loader/lib/SvgStorePlugin.js:177:35)
    at SvgStorePlugin.apply (.../node_modules/external-svg-sprite-loader/lib/SvgStorePlugin.js:51:14)
    at webpack (.../node_modules/webpack/lib/webpack.js:47:13)
    ...

I followed the external-svg-sprite-loader version 4 upgrade instructions but I must be missing something because I haven't been able to figure this out.
My webpack.config.js now looks like this (abbreviated):
const SvgStorePlugin = require("external-svg-sprite-loader");

module.exports = (env, argv) => {
  return {
    module: {
      rules: [
        {
          test: /\.svg$/,
          include: path.resolve(__dirname, "node_modules/foo-bar/images"),
          use: {
            loader: SvgStorePlugin.loader,
            options: {
              name: "foo/bar-sprite.svg",
              iconName: argv.mode === "development" ? "[name]" : "[name]-[hash:5]"
            }
          }
        },
        {
          test: /\.svg$/,
          include: path.resolve(__dirname, "src/images"),
          use: {
            loader: SvgStorePlugin.loader,
            options: {
              name: "svgs/sprite.svg",
              iconName: argv.mode === "development" ? "[name]" : "[name]-[hash:5]"
            }
          }
        }
      ]
    },
    plugins: [
      new SvgStorePlugin()
    ]
  }
}

Thanks @bensampaio, that solved my problem! However, I swear that my Webpack build was previously working correctly, using the use: {} syntax. I upgraded from Webpack 4.19.1 to 4.25.1 at the same time that I upgraded external-svg-sprite-loader from 3.4.1 to 4.0.1, so maybe something changed with Webpack. At any rate, it looks like I was using use incorrectly, so thanks for alerting me to the problem. Also, thank you for this great loader!

It still keeps throwing the "TypeError: loaders is not iterable" error for me :
TypeError: loaders is not iterable
    at SvgStorePlugin.injectSpritesIntoRules (../node_modules/external-svg-sprite-loader/lib/SvgStorePlugin.js:177:35)
    at SvgStorePlugin.apply (../node_modules/external-svg-sprite-loader/lib/SvgStorePlugin.js:51:14)
    at webpack (../node_modules/webpack/lib/webpack.js:51:13)
...

Running webpack 4.41.2
My abbreviated webpack.config.js :
const SvgStorePlugin = require('external-svg-sprite-loader')

const webpackBaseConfig = function(env) {
  return {
    module: {
      rules: [
        {
          test: /\.svg$/,
          include: path.resolve(__dirname, "../src/imgs/icons"),
          use: [{
            loader: SvgStorePlugin.loader,
            options: {
              name: "icons-sprite.svg"
            }
          }]
        }
      ]
    },
    plugins: [
      new SvgStorePlugin(),
    ]
  }
}

Should this have been fixed or am I doing something not right?

@rekker the plugin searches in your webpack rules for occurrences of SvgStorePlugin.loader so it could be that the problem is in another rule in your config. Can you share the complete config?

Sure thing:
// Require Webpack
const webpack = require('webpack')

// Node's built-in path module, which prevents file path issues between operating systems
// Use NodeJS helper module to define correct absolute file reference paths
const path = require('path')

const MiniCssExtractPlugin = require('mini-css-extract-plugin')
//const ExtractTextPlugin = require('extract-text-webpack-plugin');

// Generates an HTML5 file for you that includes all your webpack bundles in the body using script tags
const HtmlWebpackPlugin = require('html-webpack-plugin')

// const RobotstxtPlugin = require('robotstxt-webpack-plugin').default;

const WebpackNotifierPlugin = require('webpack-notifier')

//const SpriteLoaderPlugin = require('svg-sprite-loader/plugin')
const SvgStorePlugin = require('external-svg-sprite-loader')
//const SVGSpritemapPlugin = require('svg-spritemap-webpack-plugin');

const CopyWebpackPlugin = require('copy-webpack-plugin')

const devMode = process.env.NODE_ENV !== 'production'

// MAIN WEBPACK CONFIGURATION
const webpackBaseConfig = function(env) {
  return {
    // Location of the index.js file
    // Where Webpack's begins it module compilation process
    entry: {
      // File containing our custom code
      global: './src/javascripts/global.js',

      // File containing our custom routes
      router: './src/javascripts/router.js',

      // File containing code from third party libraries
      vendor: ['jquery', 'picturefill', 'svg4everybody', 'slick-carousel']
    },

    // Newly compiled file configuration
    output: {
      // Save location of the newly compiled output file
      path: path.resolve(__dirname, '../web/build'),

      // What to call the newly compiled output file
      // [name] will be replaced with the entry objects key value.
      filename: '[name].config.base.js',

      // Path webpack will reference for looking for public files. Important for dynamic codesplitting
      publicPath: 'build/'
    },

    // Module Rules Systems => Configuration for webpack loaders
    module: {
      rules: [
        {
          test: /\.svg$/,
          include: path.resolve(__dirname, "../src/imgs/icons"),
          use: [{
            loader: SvgStorePlugin.loader,
            options: {
              name: "icons-sprite.svg"
            }
          }]
        },
        {
          test: /\.js$/,
          exclude: /node_modules/,
          use: {
            loader: 'babel-loader',
            options: {
              presets: ['@babel/preset-env']
            }
          }
        },
        {
          test: /\.scss$/,
          exclude: /node_modules/,
          use: [
            'style-loader',
            MiniCssExtractPlugin.loader,
            'css-loader',
            'sass-loader'
          ]
        },
        {
          test: /\.(png|jpg|jpeg)$/,
          exclude: /node_modules/,
          use: [
            {
              loader: 'url-loader',
              options: {
                limit: 25000, // less 25k
                name: 'assets/images/[name].[ext]'
              }
            },
            {
              loader: 'image-webpack-loader'
            }
          ]
        }
      ]
    },

    // Don't follow/bundle these modules, but request them at runtime from the environment
    // externals: {
    //     Modernizr: 'modernizr'
    // },

    // Plugins => Configure webpack plugins
    plugins: [
      // The DefinePlugin allows you to create global constants which can be configured at compile time.
      // Note: process.env.NODE_ENV is set within npm "scripts"
      new webpack.DefinePlugin({
        'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV)
      }),

      //new SpriteLoaderPlugin(),
      new SvgStorePlugin(),
      //new SVGSpritemapPlugin(),

      //new CopyWebpackPlugin([
      //  { from: './templates', to: 'static-templates' }
      //], { ignore: [
      //'./web/static-templates/_webpack.templates/_webpack.template.wrapper.twig'
      //]
      //}),
      // Generates an HTML5 file for you that includes all your webpack bundles in the body using script tags
      // NOTE: Add excludeChunks: ['fallback']
      new HtmlWebpackPlugin({
        template: './src/webpack.templates/_webpack.template.wrapper.twig',
        filename:
          '../../templates/_webpack.templates/_webpack.template.wrapper.twig'
      }),
      new WebpackNotifierPlugin({alwaysNotify: true})
    ]
  }
}

module.exports = webpackBaseConfig

I think the problem is your babel-loader configuration. As I mentioned above in this thread, according to the webpack docs, use is meant to be an array. It seems to work as an object but that is not documented so I don't know wether that's by coincidence or intended. This plugin traverses your config based on the multiple use cases described in the webpack docs. Since I would rather not make the traversing more complex I suggest you change your babel-loader config to this:
{
  test: /\.js$/,
  exclude: /node_modules/,
  use: [{
    loader: 'babel-loader',
    options: {
      presets: ['@babel/preset-env']
    }
  }]
},

Webpack docs of use: https://webpack.js.org/configuration/module/#ruleuse
My previous comment on this subject for reference: https://github.com/karify/external-svg-sprite-loader/issues/58#issuecomment-436169483

Holy moly, sorry totally missed that.. that fixed it!!! Thank you!


refactor(SubNav): move files, create storybook

Parent issue: https://github.com/github/primer/issues/1488
For reference, since the components are similar I took a look at:

https://github.com/primer/react/pull/2871

Checklist

[X] Ensure your chosen component has a component directory in the src directory
[X] Ensure the component has a root story file in the component directory
[X] Ensure that the root story file exports a Default story
[X] (Optional) Create a Playground story
[X] Move all other stories for the component into a .features.stories.tsx file
[X] Opt the component into storybook tests
[ ] (Optional) Create visual regression tests for the component

Not 100% sure how to write e2e tests, so left it since it was optional 👍


[ELE-1084] Add Elementary favicon to the report

https://elementary-community.slack.com/archives/C02CTC89LAX/p1686533920627359
ELE-1084

🥰. Yes, thank you for adding the issue here.  I will keep an eye on it!

Hello @Maayan-s! I would love to contribute to display the favicon icon of elementary. I belive adding the elementary icon inside <link rel="icon"> here  would be fine. What do you suggest?

Hi @manulpatel , Thank you! Our FE dev actually added it last night, for several reasons we manage the FE development on a different repo.

Okay got it! Thanks for the info.

Released in 0.8.1 🎉 @HotDiggityDogz