Using mailersend driver in laravel with a Mailable, errors out with message, One of template_id or text must be supplied

I am using mailersend driver in my laravel application. I have installed mailersend/laravel-driver successfully.
Configured my .env variables,
MAIL_MAILER=mailersend
MAILERSEND_API_KEY=xxxxx
MAIL_FROM_ADDRESS="no-reply@xxxx" MAIL_FROM_NAME="${APP_NAME}"
My mailable class:
`class ClientAccountCredentials extends Mailable
{
use Queueable, SerializesModels;
public function __construct(
    public Client $client,
)
{
}

public function envelope(): Envelope
{
    return new Envelope(
        to: [$this->client->email],
        subject: "Your {$this->client->company->name} Account Credentials"
    );
}

public function content(): Content
{
    return new Content(
        view: 'emails.client-account-credentials',
    );
}

public function attachments(): array
{
    return [];
}

}`
How it's initiated:
Mail::to(             users: $client         )->send(             mailable: new ClientAccountCredentials(                 client: $client,             )         );
The error
One of template_id or text must be supplied {"userId":1,"exception":"[object] (MailerSend\\Exceptions\\MailerSendAssertException(code: 0): One  of template_id or text must be supplied at /var/www/html/project/public_html/vendor/mailersend/mailersend/src/Helpers/GeneralHelpers.php:23)

Please contact our support https://www.mailersend.com/contact-us


[Bug]: [Fixed layout] Widgets at the bottom is cut with a row, When container like widgets in Fixed height is reduced in height

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we have container like widgets with some widgets inside, in fixed height, if we reduce the height of the parent widget, we are observing the bottom most widget are cut with one row
https://user-images.githubusercontent.com/104895602/216301117-706aec5b-964e-4502-9cd7-2930e62bbb3d.mp4

Steps To Reproduce

DnD a container like widget
Change the Height to Fixed
Increase the height of the widget
Dnd some widgets inside the parent widget
Now reduce the height of the parent widget
Now scroll to the bottom and observe the widgets at the bottom are cut by one row

Public Sample App
No response
Issue video log
No response
Version
Deploy preview

We are not able to reproduce the issue. Closing the issue.


Optimize BaseRelation.matches()

resolves #6842
Description
This PR optimizes the BaseRelation.matches() function in order to avoid costly string processing and comparison operations which are being done a very large number of times during certain large project runs of dbt build. On the large scenario described in #6842, it took my local run time for dbt build from 23m to 14m.
As written, we would lose the ApproximateMatchError exception, since determining whether a relation is a an approximate match was a large part of the time spent. We'll need to determine whether that is justified by the savings, or if there is a better way to avoid performing the check a large number of times.
At any rate, there is a lot of room for improvement in this bottleneck.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

@boxysean If you have a chance to kick the tires on this change, please do and let me know how it works for you. If it looks good to you, I'll discuss it with other stakeholders.

@peterallenwebb This is awesome!!
Perf bottlenecks in dbt
First, I want to offer some higher-level context for this change:

There are some "fixed costs" at the start of every run: parsing (files → manifest), graph generation (manifest → graph), cache population (run queries to build up relational cache on adapter).
All of those have to happen on the main thread, before we can do anything else, and they scale with the size of the overall project, rather than the number of nodes actually selected to run. That's particularly frustrating for developers in large projects who may just want to be running dbt build --select one_model. (There is an experimental config to modify cache population based on node selection.)
Once all those fixed costs are paid, we move into a queue. Now, each node can run, in parallel, on an independent thread—up to the number of --threads, depending on the shape of the DAG (interdependencies), and only the subset of nodes actually selected to run.
So: I would expect BaseRelation.get_relation() to run within those threads, and only for nodes that are actually selected to run. This does add up to a lot of time if running thousands of models, but I'd expect it to scale in proportion with that number of models, and to be parallelized across multiple threads. (Exception: In the case of deferral, we run adapter.get_relation as a fixed-cost step earlier on, to determine which upstream models do/don't exist in the target namespace.)
Finally, once we actually get into running models against the warehouse, dbt doesn't tend to be the performance bottleneck anymore. We're "I/O bound" by the time it takes to actually execute each query on the warehouse, which can be anywhere from <1s (create view) to many minutes (create table, merge). At this point, when users are thinking about performance, they're thinking about database performance, and dbt's role is mostly around making sure it's templating the right DDL/DML, with just the right keywords or magic incantations that make the data platform purr.
Of course, dbt can also try to avoid running duplicative queries. That's the motivation behind having the relational cache to begin with, populated at the beginning & accessed/update as we go along. That cache lookups should be much faster (overall) than running the same metadata queries, over and over, against the warehouse, while materializing every single model ("does this relation already exist?" "is it a table?").

This PR: proposed trade-off

As written, we would lose the ApproximateMatchError exception, since determining whether a relation is a an approximate match was a large part of the time spent. We'll need to determine whether that is justified by the savings, or if there is a better way to avoid performing the check a large number of times.

I could be open to making this change. The ApproximateMatchError is not particularly delightful for end users to see today. It is our attempt to surface an explicit error when we've missed matching up a user's defined relation to one in the catch, because of a very subtle discrepancy in casing/quoting. The alternative, unfortunately, is even more-confusing behavior, whatever is the fallout of missing the match. As it is, though, it's already pretty hard to debug, and the UX loss of removing this extra detection does feel outweighed by the UX improvement of a significant speedup.
A little history:

The original logic here goes all the way back to 2018: https://github.com/dbt-labs/dbt-core/pull/727
We modified this logic ~15 months ago (https://github.com/dbt-labs/dbt-core/pull/4076) as the resolution to an issue that was quite tricky to debug (https://github.com/dbt-labs/dbt-core/issues/3835)

A concrete example
Here's a simple case for reproducing when this exception would be helpful. On Snowflake, the default case is uppercase (both ANSI-compliant and annoying), and quoted identifiers are case-sensitive. This was the bane of my existence in 2018; since then, we've disable quoting for relation identifiers by default, and it's much more pleasant.
So if I create a model like:
-- models/my_model.sql
select 1 as id

I dbt run, it templates out a SQL statement like
create or replace view analytics.dbt_jcohen.my_model as (select 1 as id);

In Snowflake, this relation has a much more boisterous name: ANALYTICS.DBT_JCOHEN.MY_MODEL. It's unquoted, ergo case-insensitive, ergo uppercase. What happens, though, if I turn quoting on, for all dbt-created relations in my project?
# dbt_project.yml
quoting:
  identifier: true

Now, dbt is going to try to template a SQL statement like:
create or replace view analytics.dbt_jcohen."my_model" as (select 1 as id);

But we don't actually get all the way there, because first dbt populates the adapter cache, then it tries to match up my model with an entry in the cache, and it sees there's there's an almost but not quite matching entry. And we stop the whole thing in its tracks, because we want to avoid an ugly scenario.
$ dbt run
...
11:12:25  Compilation Error in model my_model (models/my_model.sql)
11:12:25    When searching for a relation, dbt found an approximate match. Instead of guessing
11:12:25    which relation to use, dbt will move on. Please delete "ANALYTICS"."DBT_JCOHEN"."MY_MODEL", or rename it to be less ambiguous.
11:12:25    Searched for: ANALYTICS.DBT_JCOHEN.my_model
11:12:25    Found: "ANALYTICS"."DBT_JCOHEN"."MY_MODEL"
11:12:25
11:12:25    > in macro create_or_replace_view (macros/materializations/models/view/create_or_replace_view.sql)
11:12:25    > called by macro materialization_view_snowflake (macros/materializations/view.sql)
11:12:25    > called by model my_model (models/my_model.sql)
...

If I try the same, having checked out your branch, I don't get that exception—the model succeeds!—because we didn't get a match, and we didn't check for an approximate match either. dbt successfully created a view named analytics.dbt_jcohen."my_model". Of course, depending on which of these queries I run in Snowflake, I will actually be querying a different view:
select * from analytics.dbt_jcohen.my_model;
select * from analytics.dbt_jcohen."my_model";

It's a gross situation, no question. But, in keeping with what I said above, I'm not convinced that the ApproximateMatchError exception does a whole lot to make the situation less gross—it just shoves the grossness in the user's face, earlier and a bit more explicitly.

Thanks for the explanation @jtcohen6!
I'd be curious to see some real-world results, but I won't have time in the next 1-2 weeks to review due to travel. A similar analysis to what I did here would help us determine the impact of @peterallenwebb's proposed change. I will ask my client to see if they could support.
I'd also be curious to see some unit tests on get_relation() 🙈

@jtcohen6 Yes, thanks very much for this clear explanation of where the practical performance concerns really are! I'll keep it in mind as I inevitably continue to tinker with performance. I definitely don't feel strongly about getting this change in if it is unlikely to make an impact under real world conditions.

@peterallenwebb If this proves to be a significant perf boost in an "in-the-wild" scenario, I'd be supportive of moving forward! Sounds like the next step here is testing with a real large project. We do have one of these for our own internal analytics :)

@jtcohen6 @boxysean I'm probably going to close this particular PR for now, since there are risks to any effective improvement, and we have not demonstrated that it is needed in the field.
That said, I have some interesting parting observations...
Our current strategy for looking up relations in the cache is compute-intensive, since it has to account for all the ways a relation name might be quoted or cased. Our strategy also takes time linear in the number of tables in the cache. The entire list of tables in the cache is scanned for a match every time a relation is looked up. A lookup in a cache with 1000 entries will be ten times slower than one with 100 on average. With some development effort we could make this a constant-time lookup with much lower overhead.
It's not clear how important this bottleneck is in real-world production scenarios, but the anonymized client project which @boxysean provided me has the following runtimes for dbt compile on my local machine:

Stock dbt: 23 minutes
With the optimization from this PR: 14 minutes
With a quick/dirty implementation of constant-time lookup: 7 minutes

As @jtcohen6 has pointed out to me, our multithreading model might blunt the impact of the compute savings in real-world scenarios. It's still interesting how much overhead is being spent on this operation, though.

It's still interesting how much overhead is being spent on this operation, though.

Agree that it's very interesting. If you think the right next step is to close this specific PR for now, given some unknowns in the risks & benefits, I won't argue. I do think we should keep #6842 open as a promising lead to revisit for perf improvements in the future.


draft io.ipynb

adding a section on reading (and a tiny bit of writing) files.

Pre-requisites above title
Pratical lab -> practical lab
Copied into Excel -> copied said data into Excel
In to -> into (x2)
Python variables, to determine our -> python variables to determine our
We might like -> we might require
Eaisly -> easily
emplying -> employing
copy the code -> Copy the code
Retrive -> retrieve
A array -> an array
Eachother -> each other
Its clear to see -> it’s clear to see
“read in the benzene” -> Read in the benzene
temeperature  -> temperature

Tone: lots of “you”, not a lot of “we”.
I feel like people can read and write data from this. All it needs to do.


Change all tests to use assert instead of constrain

Problem
Now that we are moving towards assert instead of constrain . We should modify our examples to use assert.
The examples live here
Proposed solution
In each example, rename constrain expr to be assert(expr).
Note: There is an assert example which uses the assert keyword instead of `constrain.
Alternatives considered
No response
Additional context
No response
Submission Checklist

[X] Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.

@ makluganteng This is a good first issue, if you are interested :)

@makluganteng This is a good first issue, if you are interested :)

Yup i can take this task

@kevaundray Hi, i kinda need help on setting up the env so that i could test it out

@makluganteng which point are you stuck at?

when im installing the direnv. nix --extra-experimental-features install nixpkgs#direnv

Hi @makluganteng ,
Thank you for the willingness to take up this task -- I'm going to re-assign this issue to someone on the team. If you are still having installation problems, please open up an issue for it and flag it on our discourse: https://discourse.aztec.network/c/noir/7


circular random animation only html and css

https://github.com/pranjay-poddar/Dev-Geeks/assets/120590200/10879113-d503-40f3-b679-1ef91636d110

@MohitGupta121 @TusharKesarwani Kindly assign this issue.

@MohitGupta121 @TusharKesarwani  raised the pr please review it


Split mastering plone training into 2?

At least visually, or somehow make the 46 chapters in https://training.plone.org/5/mastering_plone/index.html#mastering-plone-label be somewhat hidden to feel less intimidating?
At the very top it already says that 1-18 are the beginners training while the others are the advanced.
So maybe if we want to keep it in a single training, put a top-level "Beginners training" and "Advanced training" so that the listings are not so intimidating?

It gets even better :) currently some of the documents is a chapter are really really long :)
I am facing that currently with some parts, documents with more than 1000 lines are not ideal :)
I try some stuff to see what is a good and sane way to split these the long documents.

I think some refactoring has happened, so closing this


musl: 1.1.16 -> 1.1.17, build with stack protector

Motivation for this change
Release notes:
http://www.openwall.com/lists/musl/2017/10/19/1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Tested bootstrap-tools with:
$ nix-build pkgs/stdenv/linux/make-bootstrap-tools.nix -A test

since musl is used there.


Additional fix for vibrating windows

Previously we only checked if the listview could scroll down, which was
incorrect when the listview had already been scrolled to the bottom

Release 0.6.0 is now available
Thanks @teslacoil and @hzsweers!


bug: Tab Page cannot be without ion-navbar

Type: bug
Ionic Version: 2.x
Platform: all
If you have TabPage with subPages, none of them, or to be exact, TabPage cannot be without navbar.
Please implement this ability.
ps: don't forget to pass params that have been passed to TabPage to its subPages.
Thank you :)

Currently this is not on our roadmap.


TypeError: 'type' object is not subscriptable

Then report the following error！！！

Implemented later, a separate “import onnx_tool” will cause this problem

what do u mean a separate import?

I've tested with this  resnet18 model. It seems ok.

I mean “import onnx_tool” will error！

I've tested with this resnet18 model. It seems ok.

Can you tell me your python version or other environment boards?

python 3.10(I believe python3 is enough).  onnx 1.12.  numpy 1.22.4

I mean “import onnx_tool” will error！
can you share your code to reproduce the error? I believe this error is caused by variable name and script name conflict.

I mean “import onnx_tool” will error！
can you share your code to reproduce the error? I believe this error is caused by variable name and script name conflict.

I'm fixing it.

0.2.1 has fixed this bug. please install and check pip install onnx-tool -i https://pypi.python.org/simple

0.2.1 has fixed this bug. please install and check pip install onnx-tool -i https://pypi.python.org/simple

big guy, awesome！！

I met the same problem in python=3.8.16 and onnx-tool=0.8.0, like that:
# python -m onnx_tool -h
Traceback (most recent call last):
  File "/opt/conda/envs/onnxtool/lib/python3.8/runpy.py", line 185, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/opt/conda/envs/onnxtool/lib/python3.8/runpy.py", line 144, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "/opt/conda/envs/onnxtool/lib/python3.8/runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/__init__.py", line 7, in <module>
    from .graph import Graph
  File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/graph.py", line 8, in <module>
    from .node import create_node
  File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/node.py", line 125, in <module>
    class Node():
  File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/node.py", line 157, in Node
    def value_infer(self, intensors: list[Tensor], outtensors: list[Tensor]):
TypeError: 'type' object is not subscriptable

The list[Tensor] can not be used in python<3.9, could you consider using typing.List instead? @ThanatosShinji

Yes, I should use List instead. Thank you for reporting!
Best Regards

From: CescMessi @.>
Sent: Friday, September 22, 2023 5:05:42 PM
To: ThanatosShinji/onnx-tool @.>
Cc: ThanatosShinji @.>; Mention @.>
Subject: Re: [ThanatosShinji/onnx-tool] TypeError: 'type' object is not subscriptable (Issue #1)
I met the same problem in python=3.8.16 and onnx-tool=0.8.0, like that:
python -m onnx_tool -h
Traceback (most recent call last):
File "/opt/conda/envs/onnxtool/lib/python3.8/runpy.py", line 185, in _run_module_as_main
mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
File "/opt/conda/envs/onnxtool/lib/python3.8/runpy.py", line 144, in _get_module_details
return _get_module_details(pkg_main_name, error)
File "/opt/conda/envs/onnxtool/lib/python3.8/runpy.py", line 111, in _get_module_details
import(pkg_name)
File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/init.py", line 7, in
from .graph import Graph
File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/graph.py", line 8, in
from .node import create_node
File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/node.py", line 125, in
class Node():
File "/opt/conda/envs/onnxtool/lib/python3.8/site-packages/onnx_tool/node.py", line 157, in Node
def value_infer(self, intensors: list[Tensor], outtensors: list[Tensor]):
TypeError: 'type' object is not subscriptable
The list[Tensor] can not be used in python<3.9, could you consider using typing.List instead? @ThanatosShinjihttps://github.com/ThanatosShinji
—
Reply to this email directly, view it on GitHubhttps://github.com/ThanatosShinji/onnx-tool/issues/1#issuecomment-1731075292, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZZIQRTH64AW6RKG7YCEASTX3VIGNANCNFSM554HC6HA.
You are receiving this because you were mentioned.Message ID: @.***>

@CescMessi the new release has fixed this.


TileSet use texture Path instead of RID to prevent name conflicts.

This fixes https://github.com/godotengine/godot/issues/35756 which occurs because certain textures such as Atlas uses the RID of the shared Texture instead generating a RID of it's own. This prevents 2 Atlas Textures that share Textures from being used in the same TileSet.
There was also some memory allocation for Lists that I removed along the way.

@akien-mga any chance to merge pull to 3.2.4 RC2?

@akien-mga any chance to merge pull to 3.2.4 RC2?

Thanks!


add foreign key to SERVICE_POLICY table

[ ] Make service_template_id as the foreign key to the ID in service_template table.

let me do it

Nothing to implement. @WangLiNaruto figured out that the FK already exists as expected.


Handle the Taipy web worker at build

The webworker shoud be correctly handled at build prod, I assume needs to be at same level as js bundles ?

Already done


sentry: TCP server

For Sentry::stop() I have tried to use cancellation_signal directly, which would be ideal, but failed to make it work with either use_future or use_awaitable.
The idea of CancellationSignal implementation is taken from https://stackoverflow.com/questions/71310261/asio-c-coroutine-cancellation .
see also:

https://www.boost.org/doc/libs/1_79_0/doc/html/boost_asio/overview/core/cancellation.html
https://cppalliance.org/richard/2021/05/30/RichardsMayUpdate.html
https://www.youtube.com/watch?v=hHk5OXlKVFg

For Sentry::stop() I have tried to use cancellation_signal directly, which would be ideal, but failed to make it work with either use_future or use_awaitable.
The idea of CancellationSignal implementation is taken from https://stackoverflow.com/questions/71310261/asio-c-coroutine-cancellation .
see also:

https://www.boost.org/doc/libs/1_79_0/doc/html/boost_asio/overview/core/cancellation.html
https://cppalliance.org/richard/2021/05/30/RichardsMayUpdate.html
https://www.youtube.com/watch?v=hHk5OXlKVFg

Some days ago I read the same articles and saw the same videos for learning asio::cancellation_signal :smile: I've been able to use cancellation slots in Silkrpc. I don't know if my approach is orthodox, but it seems to work.

TODO:

ask questions on boost::asio repo about cancellation signal usage with coroutines and futures
ask questions on boost::asio repo about why || doesn't cancel in case of an exception
try to use std::promise and bind cancellation with a callback to manually forward the signal to the future

@canepat
I've posted some questions to asio:
https://github.com/chriskohlhoff/asio/issues/1093
https://github.com/chriskohlhoff/asio/issues/1094
and rewrote the timer-based stop signal with a promise idea:

cancellation_signal is emitted
the coroutine is cancelled
the rlpx_server_task_completion callback is invoked and triggers a promise
the related promise future joins and the program stops


Get rid of "stats" in SearchBuilder

Instead of passing around and accessing an array of values, introduce
SearchBuilder#page_from and #page_to to return the number of the
first and last result shown on this page respectively.
These can be calculated trivially from the total count of results, the
current page, and the number of items shown per page, so don't need to
be calculated separately based on whether we search Algolia or the DB.

Review app deployed to https://teaching-vacancies-review-pr-2832.london.cloudapps.digital


celery worker segmentation fault

if i run 'python manage.py celery worker --loglevel=info'  i get this error:
root@saltmaster:/opt/saltshaker# python manage.py celery worker --loglevel=info

 -------------- celery@fravm009025 v3.1.17 (Cipater)
---- **** -----
--- * ***  * -- Linux-3.19.0-25-generic-x86_64-with-Ubuntu-14.04-trusty
-- * - **** ---
- ** ---------- [config]
- ** ---------- .> app:         default:0x7fa5ef4e3550 (djcelery.loaders.DjangoLoader)
- ** ---------- .> transport:   amqp://guest:**@<IP_ADDRESS>:5672//
- ** ---------- .> results:     database
- *** --- * --- .> concurrency: 1 (prefork)
-- ******* ----
--- ***** ----- [queues]
 -------------- .> celery           exchange=celery(direct) key=celery

[tasks]
  . shaker.tasks.dashboard_task
  . shaker.tasks.grains_task

[2016-03-16 16:30:37,243: INFO/MainProcess] Connected to amqp://guest:**@<IP_ADDRESS>:5672//
[2016-03-16 16:30:37,271: INFO/MainProcess] mingle: searching for neighbors
Segmentation fault (core dumped)

Whats worng?
RabbitMQ is running and the queue and user credentials are correct.
Kind regards

maybe you can try it
sudo apt-get remove  python-librabbitmq
sudo pip install librabbitmq


Assertion redeclared during import w/ Gomega

package foo

import (
    "testing"
    . "github.com/onsi/gomega"
    . "github.com/franela/goblin"
)

trying to run go test produces the following error:
./foo_test.go:6:5: Assertion redeclared during import "github.com/franela/goblin"
        previous declaration during import "github.com/onsi/gomega"
FAIL    foo/foo [build failed]

go.mod
module foo/foo

go 1.14

require (
	github.com/franela/goblin v0.0.0-20200611003024-99f9a98191cf
	github.com/onsi/gomega v1.10.1
        ...
)

Maybe it's an import alias issue. Does this code solves your problem?
package foo

import (
   "testing"
   "github.com/onsi/gomega"
   . "github.com/franela/goblin"
)

That works but then calls to all of the imported functions from Gomega (Expect, Equal, RegisterFailHandler, etc) must be prepended. What I ended up doing is:
package foo

import (
   "testing"
   . "github.com/onsi/gomega"
   gob "github.com/franela/goblin"
)

func TestFoo(t *testing.T) {
    g := gob.Goblin(t)
   ...

I'll make a PR with the doc fixed.


Allow Postgres

I think the only issue preventing this project from using PostgreSQL is the custom DATE DQL.
One solution is to drop the custom function, e.g.
$dateTime = new \DateTime();
$qb
   ->andWhere('jobs.endDate BETWEEN :dateMin AND :dateMax')
   ->setParameters(
       [
            'dateMin' => $dateTime->format('Y-m-d 00:00:00'),
            'dateMax' => $dateTime->format('Y-m-d 23:59:59'),
       ]
    );

from https://stackoverflow.com/questions/25883616/how-can-i-use-date-in-doctrine-2-dql/50236819#50236819
My original motivation for PostgreSQL instead of MySQL was the free 10k row database Heroku provides, but they're discontinuing that later this year.  Still, I like postgres better for anything with JSON fields, and I find their full-text search acceptable.  Perhaps that's true with MySQL as well.

I'm not against allowing Postgres.
Maybe that DQL functions aren't necessary anymore. I added it back in 2019 when I rewrote the model from Mongo to MySQL.
Feel free to remove it to test if it's ok with Postgres.


⚠ Processors has degraded performance

In d86f36a, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 127 ms

Resolved: Processors performance has improved in abe8654.


fix(api): fix toLogical and toPhysical for positions

toLogical and toPhysical returned a position object with an incorrect y value. For toLogical this is a regression since 2.1.0.
Fixes #11638.

@amrbashir Added the changes file.


Allows special values in principal validation

This fix essentially adds a second principal validator callback that accepts "public" and a third principal validator callback that accepts "all_authenticated_users" as valid values. These new callbacks use the old callback for validation if the principal is not one of the special values. [ch3716]

@jimPruyne bump on this one as well

Good idea, Typer callbacks have some limitations which can be frustrating - I originally tried using a functools.partial to create functions mapped to specific special_vals but Typer didn't like when those functions were used as callbacks. The resulting code is smaller and easier to understand. Re-review?


Add implicit conversions and casts from T:Hashable <-> AnyHashable.

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

rdar://27615802

@swift-ci Please smoke test and merge.

@jckarter Mind reviewing the SILGen and runtime parts of this?
@DougGregor Mind reviewing the type-checker parts of this?

Passed tests on a separate Linux build.

Type checker parts look good!

@swift-ci Please smoke test.

Does the cast optimizer need to be adjusted for this change?

The cast optimizer uses the logic in DynamicCasts.cpp.

Looks good, thanks for taking care of this @rjmccall! I agree with @gribozavr that it'd be good to have more exhaustive tests for all the casting stuff.

Hey John. If the cast optimizer uses logic in DynamicCasts.cpp, please add specific sil tests that exercise the code in the cast optimizer. We have run into many issues with the cast optimizer not being updated properly in the face of these sorts of changes.

@swift-ci please smoke test Linux

@gottesmm The test is run under -O as well as not, but I'll also add specific cast-optimizer tests.

To be clear, the existing test exercises the code in DynamicCasts.cpp and fails if it's wrong.

The Linux failure is the same one that's been failing for a while in LLDB (which I just reverted), so let's give it one more go... I'd like to get this in so we can more easily test the combination of this change with my inference of existential element types for collection literals.

@swift-ci please smoke test Linux

Okay, addressed code review comments.
@swift-ci Please smoke test and merge.

Oh, I forgot to add specific cast-optimizer tests; I'll write that up separately.

Nah, added them to this one.  Done for now.
@swift-ci Please smoke test and merge.

Awesome! Once this is in, I'll write some integration tests to make sure dictionary literals work properly with AnyHashable.

@rjmccall Thanks!


Adds --validate=false to pachctl deploy.

Fix #2364

https://github.com/kubernetes/kubernetes/issues/53309 is crazy. Do they not test kubectl create?

I really have no idea... you'd think that would be a major piece of test coverage.


NancyFX Self Host and IPv6 issues

I have a client-server application that works using a https connection with a self signed certificate and a Nancy Selfhost server.
After installing the application i run the following scripts to prepeare the server.

Add SSL Certificate to store
Check witch ip:ports are configured with netsh http show sslcert
Remove all registrations with port number 4443 (only if they are found with previous step):

netsh http del sslcert ipport=<IP_ADDRESS>:4443
netsh http del sslcert ipport=[::]:4443
netsh http del urlacl url=https://+:4443/

And then add url reservation with: netsh http add urlacl url=https://+:4443/ user=everyone
Add SSL Certicates with:

netsh http add sslcert ipport=<IP_ADDRESS>:4443 certhash=XXX appid={XXX}
netsh http add sslcert ipport=[::]:4443 certhash=XXX appid={XXX}

Then I start the server. The code for starting the self host server is:
public void Start(string baseUrl) {
        string url = baseUrl;
        Uri uri = new Uri(url);
        var uris = new[]
                {
                    new Uri($"{uri.Scheme}://localhost:{uri.Port}"),
                };
        server = new NancyHost(new CustomBootstrapper(url, Api1, Api2, applicationConfiguration), uris);
        server.Start();
    }

In this code is the baseURL the Hostname of the machine.
The client server connection works in most cases, but one situation it doesn't. This is when i try to run the the server on a specific computer. It has the following differences from other servers:

Windows 8
Pinging the hostname of this returns a IPv6 adress.

When starting the client application, it gives the following error:
The underlying connection was closed: Could not establsh trust relationship for the ssl/tls secure channel
Now i'm stuck up, because I am not sure why it would not work.

Apparently there were some old url registrations active. After clearing those, it worked.


Support stop_token_ids in sglang API

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.
Motivation
Support stop_token_ids in SGLang API.
Modification

add API support.
always check whether the current token is in stop_token_ids.

Checklist

Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
Modify documentation as needed, such as docstrings or example tutorials.

Looks good. Please fix the CI.

@zhyncs Even with retrying, the moe throughput varies a lot. I modified this to 930.


Feature - Better stats modal

What's new
Few new things:

Show current day's stats.
Track total points.

LGTM


Android build APK breaking on config

I'm attempting to run ./gradlew assembleRelease in the android directory of my react-native app to build the APK. I expect the following code to replace my config files across the app however it's not resolving properly.
webpack.haul.js
const path = require("path");

module.exports = ({ platform, root }, defaults) => ({
  entry: `./index.${platform}.js`,
  resolve: {
      ...defaults.resolve,
      alias: {
          ...defaults.resolve.alias,
          config: path.join(root, 'config')
      }
  }
});

App.js
import React from 'react';
import {Text, View} from 'react-native';
import config from 'config';

// more code below...

When I run I get the following error:
Unable to resolve module `config` from `/Users/brendan/Projects/<project-name>/App.js`: Module does not exist in the module map or in these directories:
  /Users/brendan/Projects/<project-name>/node_modules

It seems to be working fine for the iOS build however for Android this issue is being thrown.
Your Environment

software
version

Haul
^1.0.0-beta.1

react-native
^0.44.0

node
v8.0.0

yarn
0.21.3

Did you follow the instructions here to setup the build? https://github.com/callstack-io/haul#getting-started

@satya164 yes, I followed the documentation and added
project.ext.react = [
    cliPath: "node_modules/haul/bin/cli.js"
]

to my android/app/build.gradle file
When I run yarn run haul start -- --platform android from my project directory it seems to build fine, it's only when I run ./gradlew assembleRelease that I get the breaking error.

What's your React Native version? Do you have source code which I can look at?

RN version ^0.44.0
And source code for which files?

It seems that if follow the documentation and add
project.ext.react = [     cliPath: "node_modules/haul/bin/cli.js"  ]
to my android/app/build.gradle but comment out apply from: "../../node_modules/react-native/react.gradle" below it, I'm able to run the app locally as well as build the apk file with the ./gradlew assemblyRelease command

Can you post a full example so we can debug it?

Hey @brendanscarano
Did You manage to solve the issue?

I had the same problem and solved it just by adding
project.ext.react = [ cliPath: "node_modules/haul/bin/cli.js" ]
as it said in docs.


[Feature Request] customize el-form-item element click event

Existing Component
Yes
Component Name
el-form-item
Description
    <el-form-item
      v-for="field in fields"
      class="form-item"
      :key="field.id"
      @click="formItemClick"
    >

the click event formItemClick doesn't be fired

must I use @click.native to fire those intial events?

Yes.


[Bug][mysql-cdc] com.ververica.cdc.connectors.mysql.source.utils.StatementUtils#initStatement leads to uncommitted transactions

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
1.16
Flink CDC version
2.3
Database and its version
Mysql 8.0 official docker image
Minimal reproduce step

Start flink-job with following config;

long checkpoint interval
Mysql source with parallelism > 1 and initial mode.

Wait for snapshot read
Before checkpoint complete
Several uncommitted transactions will be observed from mysql console. May cause SQL execution hang.

What did you expect to see?
No open transactions should be observed after snapshot read split finished. May cause SQL execution hang.
What did you see instead?
Several uncommitted transactions can be observed after snapshot read split finished. May cause SQL execution hang.
Anything else?
Not yet
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

code location
I am not sure if set auto-commit to false and never set back was intended . According to no isolation level required in jdbc connection, I will assume this is an issue.


Compiled metrics cannot deal with dictionaries in update_state

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: -
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): v2.4.0-49-g85c8b2a817f 2.4.1
Python version: 3.7.9
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 11.0/8.1.0
GPU model and memory: RTX2080Ti 11GB

Describe the current behavior
I have written a custom metric, subclassing from tf.keras.metrics.Metric. I also have a custom model,
subclassing from tf.keras.Model. I compile the model, passing this custom metric. When doing a single train step,
I update the state of the custom metric with prediction and target as dictionaries.
However, the autograph operation turns these dictionaries into lists, making it impossible for me to access the right item in the dictionary within the metric.
An error is thrown:
File "bug.py", line 41, in <module>
    model.train_step([])
  File "bug.py", line 17, in train_step
    self.compiled_metrics.update_state(y_true, y_pred)
  File "/home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/keras/engine/compile_utils.py", line 408, in update_state
    metric_obj.update_state(y_t, y_p, sample_weight=mask)
  File "/home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/keras/utils/metrics_utils.py", line 90, in decorated
    update_op = update_state_fn(*args, **kwargs)
  File "/home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/keras/metrics.py", line 177, in update_state_fn
    return ag_update_state(*args, **kwargs)
  File "/home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 670, in wrapper
    raise e.ag_error_metadata.to_exception(e)
TypeError: in user code:

    bug.py:27 update_state  *
        self.value.assign_add((y_true["a"] - y_pred["a"]) ** 2)
    /home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/util/dispatch.py:201 wrapper
        return target(*args, **kwargs)
    /home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/ops/array_ops.py:1009 _slice_helper
        _check_index(s)
    /home/mhueting/.pyenv/versions/tts_env/lib/python3.7/site-packages/tensorflow/python/ops/array_ops.py:886 _check_index
        raise TypeError(_SLICE_TYPE_ERROR + ", got {!r}".format(idx))

    TypeError: Only integers, slices (`:`), ellipsis (`...`), tf.newaxis (`None`) and scalar tf.int32/tf.int64 tensors are valid indices, got 'a'

Describe the expected behavior
I expect the dictionaries passed to the compiled metric container's update_state function to be preserved as dictionaries instead of converted into keyless lists.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
https://colab.research.google.com/drive/1DCYM2W3C5H2StxrdPeqqsvVGBtbVfNfJ?usp=sharing
import numpy as np
import tensorflow as tf

class Model(tf.keras.Model):
    def __init__(self, **kwargs):
        super().__init__(**kwargs)

    def call(self, x, training=True):
        # this model returns a dictionary of values
        return {
            "a": tf.constant([5]),
            "b": tf.constant([5]),
        }

    def train_step(self, data):
        # each sample also consists of a dictionary of values
        y_true = {"a": tf.constant([3]),
                  "b": tf.constant([4])}
        y_pred = self(4)

        # the metrics on this compiled metric container each care about
        # only one of the values in the dictionaries y_true/y_pred
        self.compiled_metrics.update_state(y_true, y_pred)

        return {m.name: m.result() for m in self.metrics}

class MetricForA(tf.keras.metrics.Metric):
    def __init__(self, name="metricForA", **kwargs):
        super(MetricForA, self).__init__(name=name, **kwargs)
        self.value = self.add_weight(name='value', initializer='zeros')

    def update_state(self, y_true, y_pred, sample_weight=None):
        self.value.assign_add((y_true["a"] - y_pred["a"]) ** 2)

    def result(self):
        return self.value

    def reset_states(self):
        self.value.assign(0)

class MetricForB(tf.keras.metrics.Metric):
    def __init__(self, name="metricForB", **kwargs):
        super(MetricForB, self).__init__(name=name, **kwargs)
        self.value = self.add_weight(name='value', initializer='zeros')

    def update_state(self, y_true, y_pred, sample_weight=None):
        self.value.assign_add((y_true["b"] - y_pred["b"]) ** 2)

    def result(self):
        return self.value

    def reset_states(self):
        self.value.assign(0)

if __name__ == "__main__":
    model = Model()
    metrics = [MetricForA(), MetricForB()]

    model.compile(metrics=metrics)

    # this results in an error, showing us that the dictionaries passed to update_state
    # are no longer dictionaries
    model.train_step([])

@mh-synth
I ran the code and face a different error, please find the gist here

Apologies - updated the colab and the standalone code. Running the Colab in its entirety now gives the error.

I am able to replicate the issue reported on tf 2.4 and nightly, please find the gist here.

I am able to replicate the issue reported on TF nightly
and TF v2.5 ..Thanks !

This issue still persists on the latest TF V2.11 and Tf-nightly. Please find the gist of 2.11 and tf-nightly for reference .
Thanks!

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


How to use for AWS Glue (pyspark)

Hi,
How to use this utility for AWS Glue?
Ask is to check patterns (date format, number format), global file structure and not null columns alone from a csv pattern file provided to us
Thanks

Hi @ankurshri , this project will be continued on awslabs/python-deequ.
Could you pls check out this tutorial? It might answer your question.


electron-prebuild renamed to electron error

Hi, when building I get this error:
npm WARN deprecated<EMAIL_ADDRESS>electron-prebuilt has been renamed to electron. For more details, see http://electron.atom.io/blog/2016/08/16/npm-install-electron
npm ERR<EMAIL_ADDRESS>postinstall: node install.js
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node install.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the electron-prebuilt package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs electron-prebuilt
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls electron-prebuilt
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/originaltebas/menubar-calendar/npm-debug.log
npm-debug.zip

Forget it. Ubuntu changing node path to nodejs
I solved it with sudo ln -s /usr/bin/nodejs /usr/bin/node


[New game]: Piano game

🎮 Game Request
I would like to add a piano where the user has to click on the key to produce sound.
Point down the features
I would like to add a piano where the user has to click on the key to produce sound.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @PVBharadwaj , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#2653

Hey @PVBharadwaj ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @PVBharadwaj !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


bump build number

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_d6gkd_sisb/clone/recipe/meta.yaml:25: http_url: http://ftp.gnome.org/pub/GNOME/sources/glib/2.69/glib-2.69.1.tar.xz is not https
ERROR: /tmp/abs_d6gkd_sisb/clone/recipe/meta.yaml:84: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
ERROR: /tmp/abs_d6gkd_sisb/clone/recipe/meta.yaml:94: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
ERROR: /tmp/abs_d6gkd_sisb/clone/recipe/meta.yaml:95: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
WARNING: /tmp/abs_d6gkd_sisb/clone/recipe/meta.yaml:97: missing_license_url: The recipe is missing a license_url
ERROR: /tmp/abs_d6gkd_sisb/clone/recipe/meta.yaml:97: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
Errors were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_7cx_yysdvl/clone/recipe/meta.yaml:25: http_url: http://ftp.gnome.org/pub/GNOME/sources/glib/2.69/glib-2.69.1.tar.xz is not https
ERROR: /tmp/abs_7cx_yysdvl/clone/recipe/meta.yaml:84: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
ERROR: /tmp/abs_7cx_yysdvl/clone/recipe/meta.yaml:94: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
ERROR: /tmp/abs_7cx_yysdvl/clone/recipe/meta.yaml:95: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
ERROR: /tmp/abs_7cx_yysdvl/clone/recipe/meta.yaml:97: invalid_url: https://developer.gnome.org/glib/ : URL domain redirect developer.gnome.org ->  docs.gtk.org
WARNING: /tmp/abs_7cx_yysdvl/clone/recipe/meta.yaml:97: missing_license_url: The recipe is missing a license_url
Errors were found


⚠ AsianCinema has degraded performance

In 1b2a209, AsianCinema ($ACM) experienced degraded performance:

HTTP code: 525
Response time: 20461 ms

Resolved: AsianCinema performance has improved in c2957d4.


Introduce standalone runner for Triton SPIRV Kernels

Adds skeleton for a standalone runner for SPIRV kernels generated by Triton. The runner aims to re-use as much existing Triton code as possible. Eventually, our goal is to link the generated spirv_utils.so bundle for kernel launch code resulting in little to no code duplication between Triton and the runner. The end state will allow a user to take a triton cache directory containing the _kernel.spv, a metadata file specifying parameters used for that kernel, and the spirv_utils.so library and run the kernel under the same conditions as executed in Triton to generate the cache. The only modification required for Triton will be setting an environment variable to ensure the kernel parameter metadata is placed in the cache when the cache is generated.
Currently, the runner expects input Tensors to be in Torch format. This tracks closely with Triton and minimizes conversion issues serializing python to c++ (or vice versa). Once XPU support for PyTorch lands in upstream, we can switch to using Torch to move the Tensors to XPU, and simply pass the XPU pointer to the SPIRV kernel in the runner just like we do in Triton.
Parameters for the SPIRV kernels are hard coded for a particular test case we wanted to reproduce. @kballeda is working on dynamically outputting parameters for SPIRV kernels in structured format, and C++ code to read those parameters and configure the sycl_launcher appropriately for the generated SPIRV kernel.
In addition to being able to easily reproduce issues standalone using the same input formats as Triton kernels, another benefit to this approach is it gives us a way to quickly test new versions of SYCL under the DPC++ compiler without Python indirection. While building the runner, I noticed quite a few SYCL deprecation warnings which I am looking at addressing in a subsequent PR.

@alexbaden this PR causes many regressions on OpenAI machine:
FAILED language/test_core.py::test_bin_op[1-int32-int64-+] - PermissionError: [Errno 13] Permission denied: '/tmp/src'

@alexbaden this PR causes many regressions on OpenAI machine: FAILED language/test_core.py::test_bin_op[1-int32-int64-+] - PermissionError: [Errno 13] Permission denied: '/tmp/src'

It should be fixed by https://github.com/intel/intel-xpu-backend-for-triton/pull/1417.


feat: Add context.Context support for methods and functions

Idea is to support functions of the form func(context.Context, any...) (any, error) (c.f. https://github.com/antonmedv/expr/issues/380).
Changes are lightweight:

A new OpCode is introduced for builtin.Function having context.Context as first argument,
This setting can be set using &builtin.Function{Context: true},
For methods, type check was modified to account for such kinds of method and the runtime was updated accordingly.

The original API is not modified.
The use cases include:

doing interruptable work with expr  (requests, etc.),
my personal use case is keeping track of created objects, using the context as a poor man's DI.

Alternatives using methods:
type env struct{
    context.Context
}

func (e *env) Do(s string) string {
    return s
}

lacks the type flexibility provided by builtin.Function.

Overall a good PR. I have a few comments.

Hello Anton,
I applied the requested changes. I chose to use a wrapper to use the same func slice in *vm.Program instead of duplicating it.
Thomas

Now ai think why do we need to pass context to functions via expr.VM.
This passing of context complicates vm arguments handling.
The VM itself doesn’t need context as I understand right now.
Maybe there’s better methods of passing context to user defined functions?

Or we can implement this via our own custom patcher. I think this is the right solution.

Added a doc on how to add context via patcher.

https://github.com/antonmedv/expr/blob/master/docs/Visitor-and-Patch.md#patch

FYI. I've implemented my own version of context patcher and added a config option https://github.com/antonmedv/expr/blob/f92bb7949de064a05d5b3a61d1b07abef0c521bb/expr.go#L157-L161
func ExampleWithContext() {
	env := map[string]any{
		"fn": func(ctx context.Context, _, _ int) int {
			// An infinite loop that can be canceled by context.
			for {
				select {
				case <-ctx.Done():
					return 42
				}
			}
		},
		"ctx": context.TODO(), // Context should be passed as a variable.
	}

	program, err := expr.Compile(`fn(1, 2)`,
		expr.Env(env),
		expr.WithContext("ctx"), // Pass context variable name.
	)
	if err != nil {
		fmt.Printf("%v", err)
		return
	}

	// Cancel context after 100 milliseconds.
	ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*100)
	defer cancel()

	// After program is compiled, context can be passed to Run.
	env["ctx"] = ctx

	// Run will return 42 after 100 milliseconds.
	output, err := expr.Run(program, env)
	if err != nil {
		fmt.Printf("%v", err)
		return
	}

	fmt.Printf("%v", output)
	// Output: 42
}


X11 clipboard sync

This adds (basic) synchronization between the xwayland and wayland clipboard.
It also fixes some found bugs in the polymorphic data-source implementation and cleans up some aspects of the xwm implementation (mainly removes the global state).
The xselection implementation is nothing beautiful and can be improved. It implements only the absolutely needed functionality and does not care about the icccm spec too much at places (i.e. the given timestamps are probably not always correct and it does not implement INCR data transfer but this is usually not needed).
It only works for text data on the clipboard at the moment but can be easily extended to further types (is there anything else the clipboard is used for?).
Note that it cannot be easily extended to support all types in a generic way though since we have to map the TARGETS atoms from x11 to mime types in wayland (and the other way around) and there is probably no general way to do this. Many applications and toolkits use mime types as x11 targets already though so we might simlpy guess there (not sure if this is a good idea and again, text is probably the only really important clipboard target).
Please tell me if there is anything that has to be done to consider this feature done for now.
This would additionally need some further testing it works for me with the wlc example and sway (mainly tested with chromium and termite on the both backends) but this is so ugly/easy to get wrong that all testing is appreciated.

Quick notes just from reading over your description:

(is there anything else the clipboard is used for?).

Images are pretty common. Also perhaps rich text (i.e. libreoffice).

Many applications and toolkits use mime types as x11 targets already though so we might simlpy guess there (not sure if this is a good idea and again, text is probably the only really important clipboard target).

Maybe we could have a hardcoded list of hairy conversions and then fall back on just copying it over? Do you know what other compositors do?
Syncronization works in both directions, right?

Synchronization works in both directions. Weston implements only text as well and i have no idea what gnome does (probably something similar to what you are describing).
So yes, try some conversions and then fall back sounds like a good idea, should i implement it like that?

Yep. See if you can at least figure out image data. Try copying it from a wayland web browser and pasting it into gimp.

Fixed the style issues and implemented the custom conversions with fallback to just offer the atom name as mime type if it might be one (the code checks if the atom name contains a '/' at least to not offer targets like TIMESTAMP or TARGETS which are obviously no mime types and not understand by any wayland application). Still works for me in basic test (chromium, firefox, terminal, etc), was not yet able to test it with images (most applications use filepaths/urls for images anyways).

Excellent. A quick glance looks good, I will get this tested and merged later today. Great work!

I tested this with image data and it did not work. Here are some easy steps to reproduce:

Open a web browser with wayland (i.e. env QT_QPA_PLATFORM=wayland-egl qutebrowser) and copy an image to the clipboard (the image, not its url)
Open gimp and file -> create -> from clipboard

That being said, this is better than what we had before. I'm going to merge this now and expect further issues to be resolved in further pull requests.


Combine Secondary and Primary 3D launcher docs

Merged the 3D launcher and deep link docs into a single article and updated any links across the docs site

:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/app-model.md
:warning:Warning
View
Details

mixed-reality-docs/3d-app-launcher-design-guidance.md
:white_check_mark:Succeeded
View

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/creating-3d-models-for-use-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

mixed-reality-docs/implementing-3d-app-launchers.md
:white_check_mark:Succeeded
View

mixed-reality-docs/implementing-3d-deep-links-for-your-app-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded

mixed-reality-docs/navigating-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

mixed-reality-docs/app-model.md

Line 259: [Warning] Invalid file link:(~/implmenting-3d-app-launchers.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/3d-app-launcher-design-guidance.md
:white_check_mark:Succeeded
View

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/app-model.md
:white_check_mark:Succeeded
View

mixed-reality-docs/creating-3d-models-for-use-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

mixed-reality-docs/implementing-3d-app-launchers.md
:white_check_mark:Succeeded
View

mixed-reality-docs/implementing-3d-deep-links-for-your-app-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded

mixed-reality-docs/navigating-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/3d-app-launcher-design-guidance.md
:white_check_mark:Succeeded
View

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/app-model.md
:white_check_mark:Succeeded
View

mixed-reality-docs/creating-3d-models-for-use-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

mixed-reality-docs/implementing-3d-app-launchers.md
:white_check_mark:Succeeded
View

mixed-reality-docs/implementing-3d-deep-links-for-your-app-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded

mixed-reality-docs/navigating-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

It looks like we are all merged. Is there any version you want me to run through?
From: Matt Zeller<EMAIL_ADDRESS>Sent: Monday, April 16, 2018 2:35 PM
To: MicrosoftDocs/mixed-reality<EMAIL_ADDRESS>Cc: Tom Mignone<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/mixed-reality] Combine Secondary and Primary 3D launcher docs (#308)
Merged #308https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmixed-reality%2Fpull%2F308&data=02|01|thmignon%40microsoft.com|464bd0e83e07405a05c008d5a3e1ee1f|72f988bf86f141af91ab2d7cd011db47|1|0|636595113113283492&sdata=XxUa%2FBfZjKfbMPOEmas7K%2BPnHU8Uvl3niEP4IRpVmR0%3D&reserved=0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmixed-reality%2Fpull%2F308%23event-1577356456&data=02|01|thmignon%40microsoft.com|464bd0e83e07405a05c008d5a3e1ee1f|72f988bf86f141af91ab2d7cd011db47|1|0|636595113113293501&sdata=h7nljusRSh%2Ba5aF%2BSSaHR0tNkqf2e3Ap4QiRkHZ0MrI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUWwQqib5wbVM70dkVTqApQ-os62wIFzks5tpQ6NgaJpZM4TXI-X&data=02|01|thmignon%40microsoft.com|464bd0e83e07405a05c008d5a3e1ee1f|72f988bf86f141af91ab2d7cd011db47|1|0|636595113113293501&sdata=9u6fPVEz1ueUEfPCAEwIG0mOIhA4wVyho%2FfEzjqSmfc%3D&reserved=0.


Is it possible to configure more than one drive at a time

I have several google accounts.  One for work, one for my consulting business, and for personal.   It would be really cool if there was a way to keep them all in sync.   I can probably come up with a hack to do this, but is there already a way built in to go-drive to do it?

Hello again @docbill. Actually if you navigate the closed issues, you can see how to do it. Unfortunately am currently in class and on my phone, so can't find you the links but in the closed issues something should come up

Thanks.  I see the approach.   I'll likely get myself in trouble with parallel operations that way.  Better will be not to have to keep track which drive is currently configured.   This gives me a good starting point...


feat: Customizable email subject name

SUMMARY
This feature allows users to customize the email subject when creating a report or an alert within Superset. This is driven by a need to include specific parameters within the email subject line, enhancing the specificity and resonance of alert or report notifications.
Changes:

Implementation of a new text input field within the 'create alert/report' interface, through which users can specify their desired email subject line.
If the text field is left blank, a default email subject line will be generated by the system.
The user interface will show the new text field solely when the email sending method is selected by a user.

This feature has been tested with Superset master branch.
This proposed feature has already been discussed in the Superset Improvement Proposal (see https://github.com/apache/superset/issues/25945)
BEFORE SCREENSHOTS

AFTER SCREENSHOTS

TESTING INSTRUCTIONS
To verify the changes made, please follow these steps: (Assume that there TAG for alert and report and open)

Go to the Alert and report creation page
Create one of them
Fill all the information that required
Select Notification method as "Email"
You will see input box for "email subject name"
Fill the desired subject name and save it
Wait for email send and check the email subject name

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[x] Changes UI
[x] Includes DB Migration (follow approval process in SIP-59)

[x] Migration is atomic, supports rollback & is backwards-compatible
[x] Confirm DB migration upgrade and downgrade tested
[x] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Run: superset db downgrade

Run: superset db upgrade

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8c32c6d) 69.18% compared to head (f7c7a9a) 59.04%.
Report is 5 commits behind head on master.

Files	Patch %	Lines
superset/commands/report/execute.py	0.00%	6 Missing ⚠
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

What should I do with this? Can you suggest please.

ping @eschutho and @lilykuang who are working on SIP-110.

@giftig @john-bodley Could you please help me review this PR again?

@puridach-w the code all looks ok to me but I'm not very familiar with the subject of reports. I think it'd be a good idea to get a review from @eschutho or @lilykuang since they're working on the related SIP John mentioned above; would be good to confirm what's done here aligns ok with that work.

/testenv up FEATURE_ALERT_REPORTS=true

Ping @eschutho I have already modified the code based on your comment.

Ping @eschutho Could you please help me review this PR again?

Ping @eschutho Could you please help me review this PR again?

A rebase of this branch should fix the CI issue you're seeing. 🤞

Hi @puridach-w ! Thanks for this new feature, it's looking good
About the subject line UI, I think we can make it a required field in the form, but filled out with the default report name when the form is opened and it can update as the user changes the inputs. If the user clears it they will see that the field is required. There should be patterns on the modal that you can look to for behavior of required fields (red asterisk for example), but let me know if there's anything you'd like help defining!
Thanks!

Hello @puridach-w, feel free to ping me when you are ready for another round of review. Thanks!

/testenv up FEATURE_ALERT_REPORTS=true

http://<IP_ADDRESS>:8080

/testenv up FEATURE_ALERT_REPORTS=true

FYI, I still haven't edited the code from yousoph comment. But I appreciate your care and attention. Thank you very much.

Np @puridach-w. There are a few conflicts as I just merged a PR that changes the styles of the A&R modal. I hope that does not become too much of a hassle. Let me know!

Ping @eschutho @geido I request another review of my PR? Thank you!

/testenv up FEATURE_ALERT_REPORTS=true

Hey @puridach-w doing some manual testing. It seems that the spacing is off here

Hey @puridach-w doing some manual testing. It seems that the spacing is off here

Hi @geido, the modifications have been completed. Could you please review them once more?

/testenv up FEATURE_ALERT_REPORTS=true

Hey @puridach-w if you look at the testenv above, you will see that there is a : in the placeholder. I think something might be broken in the placeholder logics.

Hi @geido , I've updated the placeholder logic, but now there are some failing checks in the [test-postgres-hive]. I haven't made changes to that area could you help me with the problem?

Ping @geido Could you please help me review this PR again?

/testenv up FEATURE_ALERT_REPORTS=true

@puridach-w not sure if this is related to your PR or not but I cannot add a report. It thinks recipients are not entered even though I did. Can you verify that, please?

@puridach-w not sure if this is related to your PR or not but I cannot add a report. It thinks recipients are not entered even though I did. Can you verify that, please?

Sure let me check

Codecov Report
Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.57%. Comparing base (2e5f3ed) to head (13f73d7).
Report is 31 commits behind head on master.

Files
Patch %
Lines

superset/commands/report/execute.py
0.00%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26327      +/-   ##
==========================================
+ Coverage   60.49%   63.57%   +3.08%
==========================================
  Files        1931      520    -1411
  Lines       76241    36899   -39342
  Branches     8566        0    -8566
==========================================
- Hits        46122    23459   -22663
+ Misses      28015    13440   -14575
+ Partials     2104        0    -2104

Flag
Coverage Δ

hive
49.21% <44.44%> (+0.05%)
:arrow_up:

javascript
?

presto
53.84% <44.44%> (+0.03%)
:arrow_up:

python
63.57% <44.44%> (+0.08%)
:arrow_up:

unit
57.72% <44.44%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @geido , as I checked, I found that the issue come from the updateNotificationSetting function in the AlertReportModal file. The problem arises because the function does not update the state with the new setting value, resulting in the recipient variable doesn't have a value. I've fixed this by adding an else statement to update the setting value.

/testenv up FEATURE_ALERT_REPORTS=true

/testenv up FEATURE_ALERT_REPORTS=true

Hey @puridach-w this is looking much better now. However, I noticed that you can add an empty space as a valid value for the subject. Should we probably strip it or allow for a minimum amount of chars? Wdyt?

Hey @puridach-w this is looking much better now. However, I noticed that you can add an empty space as a valid value for the subject. Should we probably strip it or allow for a minimum amount of chars? Wdyt?

Hi @geido. I agree and have added the condition to trap that case. Could you please review it again? There's a failed job under 'Build & Publish Docker Images / docker-build', but I noticed there is an open PR aimed at resolving the issue.

/testenv up FEATURE_ALERT_REPORTS=true


Replace 'devdocs' JS links

The links to devdocs.io pages have equivalent pages at https://developer.mozilla.org. Those page links are replaced with the MDN page links. If linking to MDN is not appropriate, then we'll have to figure something else out.
Closes #7058

looks great to me! i think MDN is pretty reliable, i feel like it should be all right to link to?


Add getters & other utility methods to Dialog

This PR adds a handful of new methods to allow access to internal Dialog properties that are currently write-only. It also adds some setters for previously read-only properties. The whole list is as follows:

replace_content, which allows one to take the contents of a Dialog without destroying the Dialog
get_h_align, which allows reading the current button row HAlign
get_title, which allows reading the current title
get_title_position, which allows reading the current title HAlign
get_padding, get_padding_lrtb, get_padding_left, get_padding_top, get_padding_right, and get_padding_bottom, which allow reading the padding in every way you can currently set it
iter_buttons for immutably reading the buttons on a Dialog
iter_buttons_mut, which is intended to replace the now-deprecated buttons_mut as usual Rust convention is to have iter in the name of methods that yield values as an iterator
set_focus, which allows stealing Dialog focus. (We clamp the values given to us for safety.)

You're free to veto any of these changes if you think they're excessive. (I suspect renaming buttons_mut might be going too far.)

Looks great, thanks again for all the work! :)


New pipeline

To resolve #235
Added 'json' moduleFileExtension, otherwise some tests fail.
I ported the babel-jest to our pipeline and started on something that might become a hook architecture at some point.
Would love to hear your thoughts.

Will get around to fixes tomorrow I think

@GeeWee If you can respond to my subsequent queries - I can push these changes in and you can review it tomorrow or when you have time

Definitely - @kulshekhar, that'd be awesome. I think I got around to all of them - let me know if you need anything more

Looks good to me atm.
Do we want some more tests to make sure we don't mangle sourcemaps, or do we think we know what we're doing? I don't know a lot about that part, I just noticed we don't actually test the process output anywhere.

Well, the tests check it indirectly. For example, https://github.com/kulshekhar/ts-jest/blob/master/tests/tests/ts-coverage.spec.ts checks for the coverage which would only work if the process function worked fine and passed the sourcemap back to jest

Yes I see, that makes sense. I'd like some direct tests at one point, but baby steps.
I'm ready to merge this in if you are.


docs: add the space between Chinese and English in varlet-ui

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #259 (54f7adc) into dev (f8131ee) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #259      +/-   ##
==========================================
- Coverage   96.33%   96.31%   -0.03%
==========================================
  Files         209      209
  Lines        4772     4772
  Branches     1015     1015
==========================================
- Hits         4597     4596       -1
- Misses        175      176       +1

Impacted Files
Coverage Δ

...rlet-ui/src/date-picker/src/month-picker-panel.vue
94.11% <0.00%> (-1.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8131ee...54f7adc. Read the comment docs.

Codecov Report

Merging #259 (54f7adc) into dev (f8131ee) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #259      +/-   ##
==========================================
- Coverage   96.33%   96.31%   -0.03%
==========================================
  Files         209      209
  Lines        4772     4772
  Branches     1015     1015
==========================================
- Hits         4597     4596       -1
- Misses        175      176       +1

Impacted Files
Coverage Δ

...rlet-ui/src/date-picker/src/month-picker-panel.vue
94.11% <0.00%> (-1.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8131ee...54f7adc. Read the comment docs.


"Mark as having spoiler content" doesn't work

Describe the bug
Whether I comment on a solution or reply to someone else, the "Mark as having spoiler content" doesn't work.
I can still flag something as spoiler afterwards tough, so not a big problem once you know about it.
To Reproduce
Steps to reproduce the behaviour:

Comment on solution.
Check "Mark as having spoiler content".
Realise that it was useless.

Contexts
Please complete the following information:

Codewars username : Haksell
OS: macOS Catalina 10.15.3
Browser: Google Chrome
Browser Version: 80.0.3987.149
I tried disabling browser extensions and the problem remains.

Just tried it myself, and the spoiler option doesn't work. The request payload is {markdown: "Test", masked: true, label: null}, so the server must be handling this incorrectly.

Fixed

@kazk now there's a related bug: when I edit a spoilered comment the "Mark as having spoiler content" checkbox isn't checked by default, so after editing the comment becomes un-spoilered again.

@Voileexperiments Thanks, it seems like that's been broken for a while. It's a regression from when I updated jQuery. I'll comment here when the fix is deployed.

Fixed the checkbox

@kazk Another regression discovered: After posting a comment (for me it was an issue) marked as spoilers the spoilers checkbox isn't reset to initial, unchecked state.

Fixed the another regression.


[$500] Web - Profile - Legal name not saved/no validation if language specific characters used

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Log in New Expensify with any account
Navigate to Settings > Profile > Personal details > Legal name
Enter first and last names which contain language specific characters e. g., "Stanisław" and "Kamiński"
Click on Save

Expected Result:
Either the Legal name should be saved or a validation error informing that such characters are not supported should be shown.
Actual Result:
User is redirected back to Personal details page, and the Legal name is briefly shown but disappears, no validation errors.
The same characters are correctly saved and rendered if used in Display name.
Reproduced with Polish, Turkish, Slovak characters.
Example names to reproduce:
Polish: Stanisław, Rafał, Kamiński.
Turkish: Çağrı, Şimal.
Slovak: Matúš, Mikuláš
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/733cb384-c8db-4c96-8a6b-64a17f151ad3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018f46e881dc753267
Upwork Job ID:<PHONE_NUMBER>429937664
Last Price Increase: 2023-12-19
Automatic offers:

sourcecodedeveloper | Contributor | 28066013

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Profile - Legal name is not saved if language specific characters are used.
What is the root cause of that problem?
The updateLegalName calls api "UpdateLegalName" and if the first or last name contains language specific characters, the backend replaces the name string with empty string.
https://github.com/Expensify/App/blob/b3ecf327c585ca323a628405f4ffc70877c601a0/src/libs/actions/PersonalDetails.ts#L189
What changes do you think we should make in order to solve the problem?
Need to add validation logic to ValidationUtils.isValidLegalName
https://github.com/Expensify/App/blob/b3ecf327c585ca323a628405f4ffc70877c601a0/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js#L58

The API request for Updating Legal Name is https://www.expensify.com/api?command=UpdateLegalName(POST method)
This is the payload ( https://prnt.sc/yCmHYb3m-Bys )
As we see, payload is correct. but if we see the response, it doesn't return the legalFirstname and legalLastName ( https://prnt.sc/e1JVZW0AyvVb)
So I think this issue is related on the Backend side.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0148c62c1a4c8e3182

The backend parses out input string when the regex on the backend matches with invalid input. The similar happens when setting workspace name. The issue should be handled on front end.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Profile - Legal name not saved/no validation if language specific
What is the root cause of that problem?
The validation check for the legal name only passes if the characters are in latin text
https://github.com/Expensify/App/blob/91c7d0c6a9c8c418ae0273dfb4c49f7de52ca2c1/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js#L58
What changes do you think we should make in order to solve the problem?
Add more language validations to the regex that tests the name validity
https://github.com/Expensify/App/blob/91c7d0c6a9c8c418ae0273dfb4c49f7de52ca2c1/src/libs/ValidationUtils.ts#L320C24-L320C24

Proposal from @sourcecodedeveloper looks good to me https://github.com/Expensify/App/issues/33294#issuecomment-1863006900
We already have FE logic to validate characters - let's adjust it
🎀 👀 🎀 C+ reviewed

@narefyev91 Thanks. I understand I need to wait to get assigned to the issue before preparing PR.

@narefyev91 Thanks. I understand I need to wait to get assigned to the issue before preparing PR.

Yup we need final review from @luacmartins

all yours @sourcecodedeveloper

@luacmartins thanks

@narefyev91 PR is ready for review.

@narefyev91 is now not in C+ team. I can take over if needed.

@luacmartins @mountiny Please advise.

@luacmartins was assigned before, can probably review the PR.

@mountiny one of the offers should be for the reviewer role but both the offers came out for the contributor role. The second offer should for the reviewer not contributor.

@sourcecodedeveloper nvm, not affect your payment

@situchan cannot be two contributors on the issue, one is contributor and other is reviewer. @mountiny please assign reviewer role.

@sourcecodedeveloper I will be reviewing https://github.com/Expensify/App/pull/33563. Ignore Melvin's comment

@situchan there cannot be two contributors assigned to the issue.

@situchan reviewing PR means reviewer role not contributor @mountiny please kindly switch roles.

@mountiny Please kindly settle the dispute and send nice reviewer role offer to @situchan. Thanks.

@mountiny just need to sending offer for reviewer role would only take few minutes. Another approach would be to since @situchan volunteered to be contributor, they can review the PR as contributor and direct their questions and queries to the assigned internal engineer. The assigned internal engineer that is @luacmartins can review their queries and then decide on the essential aspect and make suggestions. I can wait for @luacmartins to respond, the delay is not an issue as there is really no rush bonus and among other reasons to get the PR out.

@mountiny Thank so very much. made the sun shine again

Hmm, that actually made things a bit confusing, now each contributor has been sent two Upwork offers. No worries - since the original offers are for the correct amounts and since they have been accepted, we can use those (even though they both say "contributor", it's okay as long as we are paying the correct amounts). I'm going to withdraw the new offers to keep things simple.
Here are the offers we will be paying out once the PR is deployed:

Contributor+: @situchan - https://www.upwork.com/nx/wm/offer/28069800
Contributor: @sourcecodedeveloper - https://www.upwork.com/nx/wm/offer/28066013

@sakluger the first two offers should have been withdrawn instead of the new offers to line up with the correct roles. Keeps things tidy.

@sourcecodedeveloper - The amounts are the same for both roles, so it's okay if the role in the Upwork job title is incorrect, as long as everyone gets paid the correct amount. Since the original offers have already been accepted, I am going to use those offers when we need to pay out.

No PR caused regression. We can skip regression test as caught by QA team.

Sounds good, thanks!


Feature Request: Add maxRetry option for curtain

Problem
The BLE connection often fails on the first attempt
Solution
Add maxRetry option
Alternatives
No response
Additional context
No response

The maxRetry option is only included in the bot type: https://github.com/OpenWonderLabs/homebridge-switchbot/blob/52d0f8280a9e822b189556057d67b1b3c54f9235/src/settings.ts#L84
Most devices also seem to implement a retry method.


[Document] Draft a table comparing serialization frameworks

Ideally listing the major pros/cons/features etc. of each serialization framework. The idea is we will add an additional format to our existing REST API offering, not replace it. This doc will be used to make a decision in the next week or so.

Doc will focus on JSON RPC, gRPC, websockets, and any other suggestions people have

@666lcz added some documentation around REST vs RPC and explored some of the benefits of JSON RPC & gRPC. Just wanted to track that here as well


Issue While using PKCS12 (.pfx) Certificate in the Request

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
We are invoking an API that uses SSL Validation policy and requires a Certificate to be included in the request from a trusted CA. However, Bruno is throwing an error. Complete details are mentioned below:
Error Message: Error invoking remote method 'send-http-request': TypeError [ERR_INVALID_ARG_TYPE]: The "path"  argument must be of type string. Received undefined
Certificate Type: PKCS #12 (.pfx format - contains complete chain [Root, Intermediate and client] and private key)
Steps Followed:

Select the Method. eg: GET
Add the https url of the endpoint
Add Basic Authentication Credentials
Adding the certificate for the domain
Making a request

Steps Followed to Add the certificate for the domain:

Select the Collection
Navigate to Client Certificates
Enter the domain without https://
Select type as PFX
Choosing the file from the file system
Providing the correct Passphrase
Selecting Add

OS: Windows 10 Enterprise 22H2 (build: 19045.4529)
Bruno Version: v1.20.1
Additional Information:

We used the Type (Cert) while adding the client certificates and it is working fine.
We only have issues with the Type (PFX)
We also tried with Postman in order to validate if the pfx certificate file is correct and it is working as expected.

Replication of the Bug:

Please replicate the bug on your side by using any pfx certificate. The issue is with all CAs.
Due to enterprise limitation, we will not be able to share details about endpoints and other details but you can replicate the bug easily on your side

.bru file to reproduce the bug
No response
Screenshots/Live demo link

Having the same issue

Also experiencing this

Hey @sajid-akhtar, thank you for taking the time to report this bug and for providing such a detailed bug report. The Bruno team is aware of this issue and is working on fixing it. We will update you once the fix is ready. Thanks!

@sajid-akhtar do you have any estimations in mind ?

Hey @PHermanov, I think you tagged the wrong person here; it's OP. Anyways, the community can expect an update on the fix within a week.

Hey @sajid-akhtar, the fix has been released in the latest version of Bruno. Please download the latest version v1.22.0 After updating, could you please check and confirm if the issue has been resolved on your side as well? Thanks for your patience and for reporting the issue!

For me it no longer shows errors, but still not working. Server doesn't see the certificate

Hi @sanjai0py The issue is resolved for me. Thank you so much for quick fix.

Closing this issue is marked as resolved with thanks to @sajid-akhtar for taking the time to create this detailed bug report!


monkberry.js like templating syntax

  {% for todos %}

      {% if complete %}
        {{ text }}
      {% else %}
        {{ text }}
      {% endif %}

  {% endfor %}

this looks better in my opinion , feel free to add your counter arguments

I'm sorry but it's not enough to justify a significant breaking syntax change just because it looks better (which is subjective)


Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/storage/storage-account
Module Details
Change of primary ownership for module
Do you want to be the new owner of this module?
No
Module Owner's GitHub Username (handle)
KTremain
(Optional) Secondary Module Owner's GitHub Username (handle)
fblix

Hi @ktremain,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @ktremain,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
We just want to ask you to double check a few important things.
Please use the following values explicitly as provided in the module index page:

You must be the owner of the GitHub teams as outlined here.
Please check that your name has been updated in the module index page (this should happen shortly after you confirmed ownership).

You can now take ownership of this module and start improving it as needed! ✅ Happy coding! 🎉
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@fblix, can you please add @ktremain to both the -owners- and -contributors- GH teams, and make him a maintainer in both? Please confirm it here, when it's done. Thanks!

I've added @KTremain to both the owner and contributors GH Teams. He is now also a maintainer on both.

Thank you for confirming, I'll update the module index later today. I'm closing this issue now.


Feat: Added playtest consent UI

This pull request should close #63.

You need to run prettier, then we can merge (see the failed formatting check)

You need to run prettier, then we can merge (see the failed formatting check)

Done.

Don't even think I can still set the check, but for consistency: I also approve the PR.


[Removal]: Energetic Latte Robin

Hotspot Name
Energetic Latte Robin
Hotspot b58 Address
112fRXoETBSSZNPPJxD4DccGW7hkMaYCvL5at2CwRinpQ1YjAu85
Discord Handle
Jun#2772
Hotspot Manufacturer
Heltec Automation
Removal Reason
These hotspots (total 2) were also bought on the secondary market on Jan 28th but not notice it was included in the denylist since it is not posteded on https://blacklist.longap.community/.  However, I deployed these hotspots in the actual place without any gaming or spoofing activities. Maybe it used to be a gaming hotspot previously but it has been deployed properly since I bought it.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Hi the helium team,
Thanks for all you have done to maintain a health and honest network. Maybe I'm the unfortunate man who bought banned hotspot, but I deployed it at the right place to privide services to local devices as part of the network.
Pleas check the authenticity of the location with your algrothim again and it will prove my innocenc

e

i don't believe you have ability to install so many miners in PuDong since the real estate is super high as well as government body would like to control everything.
screenshots can explain everything (an example of one your miner Dandy Hazelnut Rook):

i don't believe you have ability to install so many miners in PuDong since the real estate is super high as well as government body would like to control everything.
screenshots can explain everything (an example of one your miner Dandy Hazelnut Rook):

But his photo is real

我不相信你有能力在浦东安装这么多矿机，因为房地产超级高，政府机构想控制一切。

It seems like you are not local people here at PuDong since you don't see there are plenty of tall apartment buildings that are NOT own by govs. That's where my family and friends really live in.

But his photo is real

sure, the photo is really because it is taken by a real person. however, whether the setup in the photo is really is a good question, since i can put just one antenna anywhere i can, then take a picture of it, representing all miners i have, right?

我不相信你有能力在浦东安装这么多矿机，因为房地产超级高，政府机构想控制一切。

It seems like you are not local people here at PuDong since you don't see there are plenty of tall apartment buildings that are NOT own by govs. That's where my family and friends really live in.

many places in china have a plenty of tall apartments for sure. however, originally the real estate only has 70-year life in the private hand, but now seems this issue has been postponed.
anyway, can you show all your setups of all your miners? only one setup can not say anything because most of your pictures only show a cable is attaching antenna in different locations, which can be faked easily.

It seems like you are not local people here at PuDong since you don't see there are plenty of tall apartment buildings that are NOT own by govs. That's where my family and friends really live in.

many places in china have a plenty of tall apartments for sure. however, originally the real estate only has 70-year life in the private hand, but now seems this issue has been postponed.
anyway, can you show all your setups of all your miners? only one setup can not say anything because most of your pictures only show a cable is attaching antenna in different locations, which can be faked easily.

 Community needs intelligent people who can provide brilliant ideas but not a wich hunt. Do not speak merely with your prejudice and please extend your scope (especially with China).

@[abhay]I'm eager for your reply. ths

@abhay I'm eager for your reply. ths

It seems like you are not local people here at PuDong since you don't see there are plenty of tall apartment buildings that are NOT own by govs. That's where my family and friends really live in.

many places in china have a plenty of tall apartments for sure. however, originally the real estate only has 70-year life in the private hand, but now seems this issue has been postponed.
anyway, can you show all your setups of all your miners? only one setup can not say anything because most of your pictures only show a cable is attaching antenna in different locations, which can be faked easily.

 Community needs intelligent people who can provide brilliant ideas but not a wich hunt. Do not speak merely with your prejudice and please extend your scope (especially with China).

Simply stating the truth about China. it is not prejudice because i lived not far away from you.


Adding the review doc

Creating PR for review

Unable to run from Use Cases on... Pods not getting IP's... unable to successfully debug the reason for this.