GroundPolylinePrimitive._initializeTerrainHeightsWorker fails when app is served via a proxied domain

GroundPolylinePrimitive._initializeTerrainHeightsWorker tries to load in the approximateTerrainHeights.json from a relative path.

GroundPolylinePrimitive.js

ApproximateTerrainHeights.initialize('../Assets/approximateTerrainHeights.json')

This then calls the buildModuleUrl function with that path before passing it to Resource.fetchJson

ApproximateTerrainHeights.js

ApproximateTerrainHeights._initPromise = Resource.fetchJson(buildModuleUrl(url)).then(function(json) {
            ApproximateTerrainHeights._terrainHeights = json;
        });

buildModuleUrl first does a check to see if it's running in node by checking typeof document === 'undefined' and if true, it just returns moduleID.
When inside a web worker, document is undefined and the relative path is returned as it would be in node. This is fine when the code is being accessed on the same domain as it's being served on.
But when you proxy the app, the relative path becomes http://proxied-url.com/../Assets/approximateTerrainHeights.json which doesn't exist as the JSON is being served on a different domain and so the Resource.fetchJson blows up.

Thanks for catching this before it went out in the release @madole!  I've opened up a pull request fixing it here: #6715

@madole @hpinkos does this also apply to non-worker requests for the terrain heights JSON too?
Seems like that would be asking for just http://proxied-url.com/Assets/approximateTerrainHeights.json, which presumably also doesn't exist.

yeah it's handled in buildModuleUrl, because the non-worker context would have document in scope, it'll build the path using CESIUM_BASE_PATH so it's just the workers that have the issue

Replaced by #6720 (though I'm going to keep this branch around until that one gets merged).

Whoops, meant to comment on the PR not the issue.


A fluid dropdown should be fluid

When we have a .fluid.dropdown inside of .inline.fields the dropdown is set to auto because of the .inline.fields
A fluid dropdown should always be 100%
This is an example
The dropdown should take all the red space but it does not
https://jsfiddle.net/dq9urpzn/8/

Fixed since Fomantic-UI 2.4
See https://jsfiddle.net/g40rd7b3/


nextjs syntax error

Hi,
I'm having a trouble implementing this into a NextJS application.
[ error ] /<path>/node_modules/styled-reset-advanced/src/index.js:1
import { css } from 'styled-components';
       ^

SyntaxError: Unexpected token {

I had the same problem and found that this happens because NextJS doesn't transpile the modules. Reference: https://github.com/zeit/next.js/issues/706
For now, we can use next-transpile-modules:
// next.config.js
const withTM = require('next-transpile-modules')(['styled-reset-advanced']);

module.exports = withTM();


How can I remove an experiment from the project?

How can I remove an experiment from the project?
Sorry to bother you, but I can't find the way to remove an experiment after some tries.
I only find the way to delete a project.
Thanks a lot!

Yes, just move to archive (right click archive)

Thanks a lot!

Any updates on this feature?

Hi @ktobah
We added a cleanup services that takes archived experiments and deletes them after X days.
(This way users do not accidentally delete tasks, while we still keep the archived "folder" relatively clean)
You can check the cleanup service here
BTW:
You can always delete specific tasks from code:
from trains.backend_api.session.client import APIClient
client = APIClient()
client.tasks.delete(task=task.id, force=True)

Thank you very much, I think using the API call can do it for me.


Added possible fix for issue with Dockerfile

Version updates fixed build and exec from docker container

@george-qubiz https://github.com/QubizApps/ops_toolbox/pull/5 seems to have fixed the AWS cli issue.
Is this PR still relevant?

Thanks for pointing it out, closed this now since the changes from this PR were merged in #5


Arrow Key Behaviour

AdolfoBaez brought up a good point in which the arrow keys don't really continue to affect the staff if the slider bar is de-focused.
Perhaps some UI functionality change is in order.

Nominally closed by bd9b108


go2rtc external access not working within the card

Checklist:

[x ] I updated to the latest version available
[ x] I cleared the cache of my browser

Release with the issue:
Last working release (if known):
Browser and Operating System:
iPhone

Description of problem:

I cannot get external access of go2rtc with duckdns
Frigate card diagnostic information

Javascript errors shown in the web inspector (if applicable):

Additional information:

The card exclusively communicates with Home Assistant (whether you use go2rtc or not), so it is very unlikely (impossible?) the card is responsible for any networking issues you are having. Put another way: If Home Assistant itself works remotely, the card should work "just as much". If it doesn't, that is an issue somewhere with HA or the Frigate backend, and not with the card.

Ok


merge Swift 2.0 branch

could you merge the Swift 2.0 branch now that it's in GM
thanks

I can't wait until Swift v2 support.

First Swift 2 compatible builds is available into the master branch


Having the lib retry to connect after a while if reconnect fails (e.g. connection outage)

If Internet connectivity is lost for more the 5 seconds, the lib will fail to reconnect and hang. Instead of this we could have it retry every 2 mins or so. Just ideas.

Exponential backoff is now implemented, will push later.


For Windows

Hello could you create it for windows?

@boorjiusss someone ported Aerial to Windows, check here : https://github.com/OrangeJedi/Aerial
The link was on the main page too.


ValueError "too many values to unpack (expected 2)" due to "text, text_lengths = batch.text"

I tried to run LSTM in "Updated Sentiment Analysis" with my own data, but the ValueError "too many values to unpack (expected 2)" occurs in "text, text_lengths = batch.text"......How can I fix it?
Isn't batch.text itself a set of batches containing tensors?  Why "text_lengths" is necessary? text_lengths=?
Thanks.

batch.text becomes a 2-element tuple when we use include_lengths = True in our TEXT field. We need to do this when using packed padded sequences as the LSTM needs to know the actual length of sentences without padding.
If you do not want to use packed padded sequences, then change text, text_lengths = batch.text to text = batch.text and remove all references to text_lengths. If you do want to use packed padded sequences, you need include_lengths set to True in your TEXT field.


.git/ directory ignore Pattern

The ignoring engine has throws error messages with ignore patterns like .git/. The tool throws the following error message:
.git/ is an invalid pattern

Commit 1048413e80bf33233ce0bad9abb572df36a34205 fixed the bug. It's validated on development machine with .git subdirectory


[cdc] Support debezium avro format

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

Can someone enable the CI test?

https://github.com/harveyyue/incubator-paimon/tree/dbz-format
@harveyyue This will show the result of CI

Hi, can you solve the conflicts?

Seem this PR is not active now. I will continue to work on it.

I was trying to test consuming debezium avro data using this branch. I found that it needed support for some complex types. I made changes here: https://github.com/harveyyue/incubator-paimon/pull/1/files
Not sure if they are appropriate as I had to change TypeUtils to handle complex types as well.

@umeshdangat I'm working on merging these codes into the master branch. When it is done, you can create a PR to support your needed types.

@yuzelin

@harveyyue Glad to hear from you! I just start to this. It's good if you are willing to continue to work on this.

@yuzelin @harveyyue  checking in to see if this is going to be picked up soon?

@JingsongLi can you help merge this?

Thanks @harveyyue for the contribution and all for your attention!


traderExampleLesson2.sol orfeed.getExchangeRate for Kyber exchange always returns zero

I've been trying to test out traderExampleLesson2.sol and I noticed that
function getKyberBuyPrice() constant returns (uint256){  //change this to SAI        uint256 currentPrice =  orfeed.getExchangeRate("ETH", "SAI", "BUY-KYBER-EXCHANGE",<PHONE_NUMBER>000000000);         return currentPrice;     }
Probably will not work once the contract is deployed. It always returns zero when that function is tried on etherscan when the parameters applied:
https://etherscan.io/address/0x8316b082621cfedab95bf4a44a1d4b64a6ffc336#readContract
Is something wrong with orfeed contract?
(when requesting price from uniswap that works fine)

The ether address Mike put is '0x00eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee'
This is wrong, it should be:
'0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee'


Miss Self-Hosted Option

The future of Codiad...
I absolutely love Codiad, probably one of the best projects I've worked on, and the community that got involved and kept it alive has been amazing. It was a hobby project for me that I saw turn into something bigger than I ever would have expected.
That being said, I consider the platform to be outdated. The biggest issue for me personally is the lack of testing and DOM-manip nature of jQuery vs. a modern reactive SPA framework. The architecture works at the level where Codiad resides but extending the features and functionality of the app would be a stretch and regressions would become hard to mitigate, so I generally feel, from an architectural standpoint, its future is limited.
As mentioned; it is MIT licensed, so I welcome public forks and any additional code against the application, but I presume maintenance by folks on the "core" will continue to dwindle.
For anyone looking for alternatives...
If anyone is interested, I would highly suggest c9/core, the public repo is easy to stand up, and I run it similarly to how I ran Codiad; on a DigitalOcean Droplet with fairly minimal resources.
I've maintained a strong interest in web-based editors, and CodeAnywhere, ShiftEdit, Theia, CodeTasty all feel to me like they try to approach things in a similar manner to Codiad - more editor than IDE.
Eclipse Che (project that runs Koding platform) is a much larger option for those looking for a lot more tooling and IDE-like features.
Originally posted by @Fluidbyte in https://github.com/Codiad/Codiad/issues/1071#issuecomment-418750764

I really wish that was kept alive, I have had it for quite some time now and really loved having the option of something self hosted that I could throw up without having to have a cloud based fee based service. I understand your sentiments and love that I got to actually experience using this tool. It has been an amazing help. Hope you are enjoying your new ventures and thank you for the countless hours I am sure you spent building this.

Thank you for the kind words. It's not at all that I've abandoned the concept, I still am a huge advocate for cloud-based development, however, this project is stale, and as mentioned before; the tech is just outdated.
To (hopefully) provide some assistance to those looking for an alternative - I highly recommend Theia, and it's my primary editor at the time of writing this. It is self hosted (but also available hosted through [GitPod[(http://gitpod.io). While it doesn't (yet) have the plugin ecosystem of VSCode it definitely provides the same core functionality and takes most of it's cues, and structure, from VSCode.
It's very simple to run your own IDE with Theia. I set this up running with PM2 behind a very simple NGINX proxy to provide basic auth and SSL (via LetsEncrypt).


[gitlab] Update api versions to support k8s 1.16

Signed-off-by: Anton Gorkovenko<EMAIL_ADDRESS>Is this a new chart
no
What this PR does / why we need it:
Update api versions (deprecated -> actual) to support k8s 1.16
ref: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Which issue this PR fixes

Special notes for your reviewer:

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped

/assign @lachie83

/ok-to-test

@zanhsieh please approve

@antongorkovenko
This chart has no owner. BTW, you might consider to contribute to the chart maintained by gitlab themselves since on README.md stated this chart is deprecated.


add callable interface to models

closes https://github.com/OxIonics/ionics_fits/issues/128

cc @m-malinowski @AUTProgram


Feature/quorum wo promotion

added condition to make nodes proposal optional, default = false
update doc

could not add any reviewers so reopening with hope that it will route automatically

Reviewed. We are closing this PR as not relevant anymore, because currently we are considering migration to new blockchain technology.


Build is Red

This is b/c test coverage decreased by 5% when I removed the tests from the coverage. We should be fine.


Verify resource is addressable when sender is using GVR

StartSenderToResource expects that the resource is addressable but we don't verify it before calling StartSenderToResource.
Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>

/cherry-pick release-1.9

/lgtm


Mark deprecated components as deprecated using JSDoc/TypeScript

Description
On the docs site, many components are marked as deprecated:

This PR updates the types so that those same components will appear as deprecated if used in an IDE:

As you can see, the message about the replacement components is also shown in by VS Code.
Deploy Preview
No discernible changes to the docs site.
Merge Checklist
n/a
Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @bradenmacdonald!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.

This process (including the steps you'll need to take) is documented here.

If it doesn't, simply proceed with the next step.

:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...

Blockers

This PR is waiting for OEP-1234 to be accepted.

Timeline information

This PR must be merged by XX date because ...

Partner information

This is for a course on edx.org.

Supporting documentation
Relevant Open edX discussion forum threads

:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/paragon-working-group.  Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

Overview of Review Process for Community Contributions
Pull Request Status Guide
Making changes to your pull request

When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

Thanks for the quick review @PKulkoRaccoonGang !


[WIP] Add support for roles

Added support for role
Added support for roles_path

Signed-off-by: Abhijeet Kasurde<EMAIL_ADDRESS>

Would also suggest rebasing this to upstreams main, some changes happened to the tests


[xkb] AltGr = Level3_Shift, 1dk = Level5_Latch

Until now, kalamine used to generate XKB layouts where the AltGr key was an ISO_Level5_Shift, and the 1dk was an ISO_Level3_Latch. This is unnatural and possibly confusing, e.g. :

Gnome Tweaks sets the AltGr key to a Level3 shift by default
the Compose key seems to always work with Level3 symbols, but not always with Level5

The reason for this was that I had never been able to make an ISO_Level5_Latch work… until now. And it’s so simple that I really can’t figure out how I could’ve missed that.
Anyway. Here’s a quick patch to test it. Let’s find out if it breaks on older systems.

Note that the *.xkb output is not affected — it still relies on the old two-group strategy.
This patch affects xkalamine install and the *.xkb_custom output, which rely on an 8-level strategy.

FTR, it turned out activating this ISO_Level5_Latch wasn’t as easy as expected, as this symbol seems to be ignored unless xkb/symbols/level5 is somehow included :

include "level5" works but applies the first option, which generally means the right Ctrl key becomes ISO_Level5_Shift ;
include "level5(modifier_mapping)" does exactly what we want, but that’s a Debian-specific patch (and it might have been dropped recently) ;
modifier_map Mod3 { ISO_Level5_Latch } works surprisingly well… except when there’s a dead key in 1dk 1dk — which is what we wanted to try for Lafayette and Ergo-L.

So it seems the most robust solution is to copy the relevant part of include "level5(modifier_mapping)" into our XKB patches :
replace key <MDSW> {
    type[Group1] = "ONE_LEVEL",
    symbols[Group1] = [ ISO_Level5_Shift ]
};
modifier_map Mod3 { <MDSW> };

The <MDSW> key (Mode_switch) has been introduced more than 10 years ago ; nowadays it’s just an alias for the more self-explanatory <LVL5> key, which has been introduced recently — and we should be confident this alias is here to last.
Kudos to @nivopol for his help on this !

Mentioning #55, as this <MDSW> solution is related to the support of dead keys in the 1dk layer.


Feat particleRenderer limitVelocityOverLifetime

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

add limitVelocityOverLifetime module for particleRenderer
in this module, introduce speed and dampen, drag, and speed could be separateAxes

What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

@coderabbitai review

@coderabbitai review


dts: arm: st: h7: add a template for stm32h7b3Xg

Same as stm32h7b3Xi.dtsi, half the flash.

wait wrong file


Visual Studio Crash when 'Open Folder'

VSCode Version: 1.4.0
OS Version: Windows 10 - Version 1511

Visual Studio Code crashes when trying to open any New folder . Below is the error i get -

Steps to Reproduce:

Go to File -> Open Folder

I tried looking into various issues reported here. Though could not find any solution to this particular problem. Can somebody please help?
Thanks in advance!

Same version of VS code and Windows but i dont have the problem.
btw : I have only "Open With Code" what do you mean about the steps.

Same version of VS code and Windows but i dont have the problem.
btw : I have only "Open With Code" what do you mean about the steps.

@dhruvajoshi8 does the crash happen after you selected a folder or before the folder dialog opens?

@bpasero The folder dialog opens successfully. The crash happens after I select a folder,

@ugurozturk/All Below are the snapshots -

Thanks!

I am very sorry to hear you are having issues with VS Code. I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

@bpasero Thanks for your input. However, I still face the same issue after executing from command prompt by disabling the extensions.

@dhruvajoshi8 does it reproduce when you try with our insiders release too?
We are releasing preview releases of the next stable VS Code version for everyone to try and give feedback. These preview releases are not 100% tested and might be unstable but contain our latest features and bugfixes. You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

@bpasero Already tried with the insider version <IP_ADDRESS>. Gets reproduced!

Also, I get the below error when i open a file.

@dhruvajoshi8 can you run "code --verbose" from the command line and attach the output until you see the crash happening. Also please open the dev tools console (Help > Toggle Developer Tools) to see if output is printed.
I think both cases are interesting: Try once with a crash when opening a folder and once when opening a file that leads to the extension host crash.

@bpasero
Below are attachments for the case where i re-created the 'Open Folder issue' as per above procedure -
The crash continuously happens as i navigate through Developer Tools

The Source for console -

Below is what i get on the prompt during the crash -

Prompt after i close the application -

I will attach the other case(Open File) in a separate comment.
Thanks!

Below are attachments for the case where i re-created the 'Open File issue' as per above procedure -

Thanks!

@dhruvajoshi8 sorry the screenshots are too blurry, I cannot see anything. Can you redo the ones for the console to see what kind of output there is?

@bpasero Below is the source code for error in console log for the 'Open Folder Issue' -

Below is the console log for the 'Open File Issue' -

Hopefully these are clear enough :)
Please let me know if any more information required.
Thanks!

I have tried this tool with the same version and same OS version on a different machine. It works!
Could these be because of my Hardware configuration(since i do not have the best config in market)?
I have a Sony Vaio i3 3rd Gen, 2GB RAM.
But i think this config should be enough. Please feel free to share your views.
Thanks!

Adding more people to this (@alexandrudima, @joaomoreno, @jrieken) to get more ideas.
@dhruvajoshi8 did you ever run Code as administrator maybe? I wonder if this could also be related to file permissions.

@dhruvajoshi8 If you open Windows's Event Viewer do you see any Code specific errors in there?

@dhruvajoshi8 can you

close Code
open the file C:\Users\<name>\AppData\Roaming\Code\User\settings.json with another editor
add "telemetry.enableCrashReporter": false
save
open a command line
set ELECTRON_ENABLE_STACK_DUMPING=true
run code from the command line code --verbose
send us the output you see when it crashes

My 2 cents.
Recently, while working on a project for the terminals (Windows) we caught the bug with Electron and NW.js, which kills the process of rendering  (even with Electron API Demos app). This was due to problems with Hardware configuration.
Try any application built on the Electron to exclude a problem with Electron. For example, Atom.

@mrmlnc well but he can still use VS Code as long as no file is opened...

@dhruvajoshi8 any improvements with our latest version (or the insiders build?) -- we no longer connect to the shared process on extension host startup.

@mrmlnc Do you might telling me what your launch.json looks like to intergrate with NW.js

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!

Closing, waiting on @dhruvajoshi8's reply.


fix: remove duplicate notice RouteShortAndLongNameEqualNotice

Summary:
This PR provides support to remove duplicate notice RouteShortAndLongNameEqualNotice. We only keep DuplicateRouteNameNotice.
Expected behavior:
RouteShortAndLongNameEqualNotice shouldn't longer be generated in RouteNameValidator.
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
~[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)~

Correct me if I am wrong, but I believe that these notices describe very different things. We should keep both.

DuplicateRouteNameNotice tells you that route1 and route2 have the same names:
RouteShortAndLongNameEqualNotice tells you that route1 has route_short_name == route_long_name

DuplicateRouteNameNotice

route_id
route_short_name
route_long_name

r1
U1
Southern

r2
U1
Southern

RouteShortAndLongNameEqualNotice

route_id
route_short_name
route_long_name

r1
L1
L1

Closing as no longer relevant as mentioned by @aababilov here and https://github.com/MobilityData/gtfs-validator/issues/971.


Transfer Pokemon not wrking

Expected Behavior

Actual Behavior

Your FULL config.json (remove your username, password, gmapkey and any other private info)

Output when issue occurred

Steps to Reproduce

Other Information
OS:

Branch:

Git Commit:

Python Version:

Any other relevant files/configs (eg: path files)

Short Description

Possible solution

How it would help others

Please read #5773 and #5768 for further information...


Boats: Move rules of conduct from pdf to webpage

See pdf file https://github.com/svpbde/svpb/blob/develop/boote/static/boote/AlgemRegelnVereinsboote.pdf

Actually keeping the rules as PDF allows to update the file easily, without requiring a port to HTML. This year, the old rules got replaced completely by the new board member in charge. Most board members will not know how to write HTML and just send PDFs to us.
If there are more frequent changes, we could consider adding a file upload to the media folder, but for the time being, I'm closing this issue.


Feat: useAbsolutePath for lcov reports

Istanbul now generates lcov.info reports with relative path rather than absolute as explains in this merge request. Thus, it is required to have a parameter to explicitly tell the plugin to use relative path.
useAbsolutePath: false

by adding above parameter to passing configs, this can be achieved now. If you are generating lcov reports using a latest istanbul reporter such as nyc or c8, this prop should be used.

Hi @samitha9125 , thanks for the PR.
It's hard to read the diff with all the formatting changes. Would it be possible to apply those changes and the prettierrc in a follow up PR?


Double tap gesture added to collection view does not work on bubbles

General information

JSQMessagesViewController version: 7.3.4
iOS version: 9.3.5
Devices/Simulators: iPhone 5S
Reproducible in the demo project? (Yes/No):  Yes
Any related issues: No

What happened?
I'm adding singleTap and doubleTap gestures to MyJSQMessagesViewController as follows:
    // Setup Double Tap gesture
    doubleTapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(didDoubleTapOnView))
    doubleTapGestureRecognizer.numberOfTapsRequired = 2
    doubleTapGestureRecognizer.delaysTouchesBegan = true
    doubleTapGestureRecognizer.delegate = self

    // Setup Single Tap gesture
    singleTapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(didSingleTapOnView))
    singleTapGestureRecognizer.numberOfTapsRequired = 1
    singleTapGestureRecognizer.delegate = self
    singleTapGestureRecognizer.requireGestureRecognizerToFail(doubleTapGestureRecognizer)

    // Setup Double Tap gesture
    if ((self.collectionView.gestureRecognizers?.contains(doubleTapGestureRecognizer)) != nil) {
        self.collectionView.removeGestureRecognizer(doubleTapGestureRecognizer)
    }
    self.collectionView.addGestureRecognizer(doubleTapGestureRecognizer)

    // Setup Single Tap gesture
    if ((self.collectionView.gestureRecognizers?.contains(singleTapGestureRecognizer)) != nil) {
        self.collectionView.removeGestureRecognizer(singleTapGestureRecognizer)
    }
    self.collectionView.addGestureRecognizer(singleTapGestureRecognizer)

Double Tap selector gets called correctly everywhere on the View except when user does it on the chat bubbles.
I'm also using the following delegate methods to log touch events:
didTapMessageBubbleAtIndexPath
didTapCellAtIndexPath
didTapAvatarImageView
For all 3 functions, I'm getting correct log. But these only work for single tap.
How can I handle double tap on chat bubbles?

@jessesquires
Alright, I've fixed it by modifying source code.
When I looked into JSQMessagesCellTextView, I noticed that doubleTaps were being ignored on UITextView to prevent the Cut/Copy/Paste dialog from showing up, as such:
- (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer
{
    //  ignore double-tap to prevent copy/define/etc. menu from showing
    if ([gestureRecognizer isKindOfClass:[UITapGestureRecognizer class]]) {
        UITapGestureRecognizer *tap = (UITapGestureRecognizer *)gestureRecognizer;
        if (tap.numberOfTapsRequired == 2) {
            return NO;
        }
    }

    return YES;
}

- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch
{
    //  ignore double-tap to prevent copy/define/etc. menu from showing
    if ([gestureRecognizer isKindOfClass:[UITapGestureRecognizer class]]) {
        UITapGestureRecognizer *tap = (UITapGestureRecognizer *)gestureRecognizer;
        if (tap.numberOfTapsRequired == 2) {
            return NO;
        }
    }

    return YES;
}

However, this would mean that any other gesture recogniser with numberOfTapsRequired = 2 that was added to UITextView or it's parent views would also be ignored.
However, there is a way to allow custom gesture recognisers with numberOfTapsRequired = 2 to be detected while at the same time ignoring the default iOS double tap gesture recogniser on UITextView.
Following are the changes required:
- (BOOL)gestureRecognizerShouldBegin:(UIGestureRecognizer *)gestureRecognizer
{
    //  ignore double-tap to prevent copy/define/etc. menu from showing
    if ([gestureRecognizer isKindOfClass:[UITapGestureRecognizer class]]) {
        UITapGestureRecognizer *tap = (UITapGestureRecognizer *)gestureRecognizer;
        if (tap.numberOfTapsRequired == 2) {
            if([gestureRecognizer isMemberOfClass:[UITapGestureRecognizer class]]) {
                return YES;
            } else {
                return NO;
            }
        }
    }

    return YES;
}

- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldReceiveTouch:(UITouch *)touch
{
    //  ignore double-tap to prevent copy/define/etc. menu from showing
    if ([gestureRecognizer isKindOfClass:[UITapGestureRecognizer class]]) {
        UITapGestureRecognizer *tap = (UITapGestureRecognizer *)gestureRecognizer;
        if (tap.numberOfTapsRequired == 2) {
            if([gestureRecognizer isMemberOfClass:[UITapGestureRecognizer class]]) {
                return YES;
            } else {
                return NO;
            }
        }
    }

    return YES;
}

The above change to return YES for isMemberOfClass for UITapGestureRecognizer will work for custom implementations of UITapGestureRecognizer with numberOfTapsRequired = 2  and ignore the default iOS response for double tap gesture recognizer

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Thread safety

This is to improve thread safety for static methods that may be called from multiple threads.
This change does not affect the thread safety of individual HttpRequest instances.
Use ThreadLocal for trustedFactory, as the documentation for the classes used makes no thread-
safety guarantees.
Make TRUSTED_VERIFIER final and initialize lazily using the lazy initialization holder class
idiom used in Effective Java item 71, as the implementation used is thread-safe.
Make connectionFactory volatile.  This requires implementers of the ConnectionFactory interface
to ensure that their implementation is thread-safe.
This also changes the static members used that were not final to use the more conventional
camelCase naming rather than ALL_CAPS.

hey folks, what are the odds of getting this merged in?

@rferreira are you having threading issues using this library?

@kevinsawicki nope, just a small false alarm a few weeks back.


Fix quoting

Fixes https://github.com/cashapp/sqldelight/issues/1525
This isn't quite finished yet, it's failing to parse CREATE TABLE "identifier with whitespace"(id INTEGER PRIMARY KEY); for some reason

Thanks for this angus, I cherry picked and fixed up for master in #119


Docker setup failed

I was just following down this, https://github.com/sea-bass/turtlebot3_behavior_demos

git clone https://github.com/sea-bass/turtlebot3_behavior_demos.git

cd turtlebot3_behavior_demos

docker compose build

However, at 3, I found the problem that the build failed with the below comments.
The detailed error can be found in the attached image files.

ERROR [overlay 5/6] RUN source /turtlebot3_ws/install/setup.bash  && colcon build --symlink-install
....
/overlay_ws/src/tb3_autonomy/src/autonomy_node.cpp:12:10: fatal error: behaviortree_cpp/loggers/bt_zmq_publisher.h: No such file or directory
FYI:

It seems like BehaviorTree.CPP removed their old ZMQ published in https://github.com/BehaviorTree/BehaviorTree.CPP/commit/4c789eae68eba30124e98a4ff09db796e5582d11 recently, so that breaks the master branch of that library.
For now, I've reverted the BehaviorTree.CPP repo to the 4.1.1 branch, but the next step is to upgrade the repo to move from Groot to Groot 2. Made https://github.com/sea-bass/turtlebot3_behavior_demos/issues/26 to track this.
Can you pull the latest version of this repo and try again?


'drop_duplicates' behaves differently when using 1 vs many coordinates for an index

What happened?
I am trying to drop_duplicates from a DataArray based on the values of some of the coordinates,
starting from a DataArray with coordinates, but no indexes.
To accomplish this, I call 'DataArray.set_xindex' with the appropriate coordinate names,
and then call 'drop_duplicates' on the resulting DataArray, like so:
from xarray import DataArray
import numpy as np

test_array = DataArray(
    np.random.rand(5),
    coords=dict(x=("sample", [1, 2, 1, 2, 1]), y=("sample", [-1] * 5)),
    dims="sample",
)

# output DataArray's 'sample' dimension has length 2, as expected
good = test_array.set_xindex(["x", "y"]).drop_duplicates("sample")
assert len(good) == 2

The above functions as expected; 'good' has had its duplicates dropped,
and we are left with a DataArray of length 2.
However, the following does not function as I would expect:
# All the 'y's are '-1', so we expect the same duplicates as before to be dropped,
# even if we don't include the 'y' values in the index.
bad = test_array.set_xindex("x").drop_duplicates("sample")
# But this assert fails! 'drop_duplicates' does not drop anything
assert not bad.equals(test_array)

What did you expect to happen?
I expected drop_duplicates to drop the duplicates when I was using only a single coordinate for the index.
Minimal Complete Verifiable Example
from xarray import DataArray
import numpy as np

test_array = DataArray(
    range(5),
    coords=dict(x=("sample", [1, 2, 1, 2, 1]), y=("sample", [-1] * 5)),
    dims="sample",
)

# output DataArray's 'sample' dimension has length 2, as expected
good = test_array.set_xindex(["x", "y"]).drop_duplicates("sample")
# And indeed there are only 2 elements left after dropping duplicates.
assert len(good) == 2

# All the 'y's are '-1', so we expect the same duplicates as before to be dropped,
bad = test_array.drop_vars("y").set_xindex("x").drop_duplicates("sample")
# But this assert fails! 'drop_duplicates' does not drop anything
assert not bad.equals(test_array.drop_vars("y"))

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.
[X] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
No response
Anything else we need to know?
No response
Environment

INSTALLED VERSIONS
commit: None
python: 3.11.5 | packaged by conda-forge | (main, Aug 27 2023, 03:34:09) [GCC 12.3.0]
python-bits: 64
OS: Linux
OS-release: <IP_ADDRESS>-microsoft-standard-WSL2
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: C.UTF-8
LOCALE: ('en_US', 'UTF-8')
libhdf5: 1.12.2
libnetcdf: 4.9.1
xarray: 2023.11.0
pandas: 2.1.0
numpy: 1.24.4
scipy: 1.11.2
netCDF4: 1.6.3
pydap: None
h5netcdf: 1.2.0
h5py: 3.8.0
Nio: None
zarr: None
cftime: 1.6.2
nc_time_axis: None
iris: None
bottleneck: None
dask: 2023.9.1
distributed: 2023.9.1
matplotlib: 3.7.2
cartopy: None
seaborn: 0.12.2
numbagg: None
fsspec: 2023.9.0
cupy: None
pint: None
sparse: None
flox: None
numpy_groupies: None
setuptools: 68.1.2
pip: 23.2.1
conda: 23.7.3
pytest: 7.4.2
mypy: None
IPython: 8.15.0
sphinx: None

FWIW I suspect this behavior is due to the different code-paths that are followed when constructing single-coordinate vs multiple-coordinate indexes in set_xindex.

Thanks for the report @jbweston. I think that drop_duplicates has not been refactored yet to fully support multiple coordinate indexes. I added it to the list in #6293.


No GH auth after update/restart

Issue Type: Bug
I restarted my insiders for update. Afterwards I had lost my GH signing:

I had the following entries in the GH Auth log. These errors keep coming until I reload the window. After window reload everything is back to normal.
[Error  - 14:34:47.25] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:35:17.28] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:35:47.40] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:36:17.51] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:36:47.62] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:37:17.74] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:37:47.85] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:38:17.101] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:38:47.112] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:39:17.124] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:39:47.138] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:40:17.152] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:40:47.166] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:41:17.175] Getting token failed: Error: UNIX[No such file or directory]
[Error  - 14:41:47.187] Getting token failed: Error: UNIX[No such file or directory]
VS Code version: Code - Insiders 1.49.0-insider (00754e4babebc9ee5aa881234bc16366c4f32aa9, 2020-09-02T05:43:25.834Z)
OS version: Darwin x64 18.7.0
Remote OS version: Linux x64 5.3.0-1020-azure

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.33GB free)

Process Argv
--crash-reporter-id d4b72415-0109-45b3-a1a7-967fdd12f0f4

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: az-devbox

OS
Linux x64 5.3.0-1020-azure

CPUs
Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz (4 x 2294)

Memory (System)
15.61GB (2.28GB free)

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

tsl-problem-matcher
eam
0.3.0

vsc-material-theme
Equ
32.8.0

vsc-material-theme-icons
equ
1.2.0

theme-monokai-pro-vscode
mon
1.1.17

vscode-docker
ms-
1.5.0

remote-containers
ms-
0.138.0

remote-ssh-edit-nightly
ms-
2020.8.19620

remote-ssh-nightly
ms-
2020.8.19620

remote-wsl
ms-
0.44.5

azure-account
ms-
0.9.2

vscode-github-issue-notebooks
ms-
0.0.49

vsonline
ms-
1.0.2739

material-icon-theme
PKi
4.2.0

vscode-ruby
win
0.27.0

vscode-eslint
dba
2.1.8

gitlens
eam
10.2.2

vscode-pull-request-github-insiders
Git
2020.8.39781

rainbow-csv
mec
1.7.1

hexeditor
ms-
1.2.1

vscode-github-issue-notebooks
ms-
0.0.49

vscode-markdown-notebook
ms-
0.0.10

vscode-typescript-tslint-plugin
ms-
1.2.3

(3 theme extensions excluded)

Upstream: https://github.com/atom/node-keytar/issues/147

Closing as a duplicate of https://github.com/microsoft/vscode/issues/115525


Support multiple prioritized queues

can you elaborate a bit about this change? I don't understand why you would need this over just installing multiple queues, with the same JobHandler.

We need to have prioritised queues. Ie we need to consume events from queue
1 before queue 2. This is so that we can process real time order events
before scheduled order events, before other lower priority events.

We need to have prioritised queues. Ie we need to consume events from queue 1 before queue 2. This is so that we can process real time order events before scheduled order events, before other lower priority events.

Why can't we just process them all at the same time? Are we resource limited by something? This seems like a resource limiting problem and we should solve it with a permit acquisition solution.

sorry, forgot to push. fixing now.


Add a Password Generator project to your Repo

hii @ghostmkg !
I want to add a password generator project to your web-development project. It will generate you a random password with you can copy to clipboard.

/assign


Moving custom Laravel rules to upstream PHP CS Fixer

Hello! It would be great to send a PR to PHP CS Fixer with the 3 Laravel rules.
Who's is brave enough to do this copy-paste job?

You? 😅

Start: right now! 🐎


Adds sorting parameter to series ltitools

This PR adds the option to specify sorting criteria to the series ltitools.
How to test this patch
Before this PR, it was not possible to set a sorting order in the series ltitools. Calling for example https://stable.opencast.org/ltitools/index.html?subtool=series&sort=title would have no impact to the sorting.
With the PR you should be able to make use of this parameter, either directly in the url or through the tool configuration of your LMS (as explained in https://docs.opencast.org/r/16.x/admin/#configuration/ltimodule/#specifying-lti-tools).
I could not test the patch with an LMS yet, so feel free to test, if you have this option.
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated tests
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits
[ ] explain why it needs to be merged into the legacy branch, if it is targeting the legacy branch

Tested with Moodle 4.1
Sorting works as it should, making it much easier to find a single video in a series of many.


Still error: Sign in to confirm you’re not a bot

Describe the bug
Sign in to confirm you’re not a bot
Error Details (Log)
I simply test this code
ytdl.getBasicInfo('https://www.youtube.com/watch?v=-u1Ge-QePfM').then((info) => {
    console.log(info.videoDetails.title);
  });

but this error still occur
{"error":"All player APIs responded with an error. (Clients: web, mweb, tv, ios)\\nFor details, specify logDisplay: [\"debug\", \"info\", \"success\", \"warning\", \"error\"] in the constructor options of the YtdlCore class.\\nNote: This error cannot continue processing. (Details: \\"Sign in to confirm you’re not a bot\\")"}

Environment

Video URL: https://www.youtube.com/watch?v=-u1Ge-QePfM
@ybd-project/ytdl-core version: lastest
Node.js version: v20.15.1
Operating system: ubuntu

Then I also manual add poToken and visitorData (get from https://github.com/fsholehan/scrape-youtube ) like below, but still same error
ytdl.getBasicInfo(videoUrl, { poToken: 'PO_TOKEN', visitorData: 'VISITOR_DATA' })

I had the same problem. Also I manually add poToken and visitorData but received the error:
{"error":"All player APIs responded with an error. (Clients: web, mweb, tv, ios)\\nFor details, specify logDisplay: [\"debug\", \"info\", \"success\", \"warning\", \"error\"] in the constructor options of the YtdlCore class.\\nNote: This error cannot continue processing. (Details: \\"Sign in to confirm you’re not a bot\\")"}


Add more subq patterns during Phenio transform

Phenio is relaxed by robot during the transform step, but this doesn't change every equivalence axiom to SubClassOf, just the "first level" (i.e., it doesn't act recursively).
See also https://github.com/ontodev/robot/issues/1007
There is likely a more complicated way to so this with SPARQL alone by defining what a nested subq pattern looks like, or we can just wait for it to be implemented in robot.

This PR uses ROBOT to achieve the same thing w/o the recursive method:
https://github.com/mgijax/mammalian-phenotype-ontology/pull/3480
Even if the recursive method works, it wont be enough for phenio, because you want the direct relations across the haspart buffer. It would really be good if you could just comment on the above PR saying that it would be great if that could be implemented soon, because its hard for me to push it through..


Added clamped spline interpolator, based on Burden, R and Faires, D. …

The function and classes that were defined inside the file attached to this repository follow the Apache Commons Mathematical Library Guidelines. This script contains the implementation of clamped splines based on Burden, R, and Faires, D. (2011). Numerical analysis. Pacific Grove, CA: Brooks/Cole Pub. Co. Oct. 2011, Boston, MA. ISBN-13: 978-0-538-73351-9. In contrast to natural splines, clamped splines force the direction of the ending points of a curve, as a result, the transition between two spline segments is less abrupt. The methods were tested with examples of the book mentioned previously.

The function and classes that were defined inside the file attached to this repository follow the Apache Commons Mathematical Library Guidelines. This script contains the implementation of clamped splines based on Burden, R, and Faires, D. (2011). Numerical analysis. Pacific Grove, CA: Brooks/Cole Pub. Co. Oct. 2011, Boston, MA. ISBN-13: 978-0-538-73351-9. In contrast to natural splines, clamped splines force the direction of the ending points of a curve, as a result, the transition between two spline segments is less abrupt. The methods were tested with examples of the book mentioned previously.

What is going on with this PR? The class already present in the javadoc for 4.0-beta1, but actually it's still it's not in the codebase.
https://commons.apache.org/proper/commons-math/javadocs/api-4.0-beta1/org/apache/commons/math4/legacy/analysis/interpolation/ClampedSplineInterpolator.html

@yaroska interesting, that the Javadoc is already included in 4.0-beta1. There is still my open feature request MATH-1650 Add clamped spline interpolation about integration of this new function pending. I should push it forward. Still open tasks:

Unclarity about if extending SplineInterpolator by simply overloading interpolate() function is the correct design approach here, or, if it should be realised differently. I was expecting a clearer feedback from the maintainers.
Tests are missing.

@yaroska I am a bit confused. What is the preferred workflow for proposing new functions to commons math? Here via GitHub pull requests or via JIRA issues with attached patch files? We are currently finalising the remaining tasks and would provide an update soon.

@michikommader It is recommended to discuss new features on the developer mailing list, or via JIRA issues.
GitHub is not the place to discuss complex new functionality but it does make it easier to review and merge agreed functionality. This is more so if the functionality is large. Note there are users on the developer mailing list that do not use GitHub so the audience is wider/different.

Thanks @aherbert for clarification. My JIRA issue MATH-1650 – which I mentioned above – was initially created after having consulted the mailing list. Then, I will continue posting updates and patches within the coming weeks there.


Rename InProcess{EnvironmentFactory,Harness} to Embedded{EnvironmentFactory,Harness}.

For consistency and to avoid confusion with the newly added ProcessEnvironmentFactory.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


@ #1 | basic ror-starter project setup

connect #1

timeout for reviewing, we need this for this afternoon demo. You can post-review the changes later, @duc4nh.


Google docs

#229

This PR merged with #292.
Closing this issue. Please re-open if you have a specific issue with the documentation that you want to address.


use team display names in dropdown menus

Currently support bot shows abbreviated team names in the dropdown menus when creating and reassigning a support ticket. This change makes it so that support bot will show the full team names in the dropdowns.
The support modal will now look like this:

And the Reassign Ticket modal will now look like this:

Looks good! The lists are clearer this way

I did notice that some of the teams have the word "Team" and some don't. Notice sure if they're actually all teams though, so maybe that explains the difference?

That's an interesting point. I'll bring it up with Rebekah, that seems kind of inconsistent, but maybe they're that way for a reason. That should be a simple update in the spreadsheet, though, if they want to change the names.


Enable Hacktoberfest Topic

💥 Proposal
Can an admin add a new topic for the repo?
This will need to be added for contributors to get credit for Hacktoberfest.

I've pinged @JoelMarcey as I don't think I can enable this myself.
Related link of the Hacktoberfest opt-in thing: https://hacktoberfest.digitalocean.com/hacktoberfest-update

Done.


Images not recomposing after changing the list of a LazyList

Please complete the following information:

Glide and Fresco v1.2.4

Describe the Bug:
I'm observing a Live Data List using observeAsState(). When I trigger a new event using value/postDelayed, the LazyList (LazyRow/LazyColumn) item recomposes everything (text, icons, colors) except the Glide/Fresco image, making the item keep the old image URL. I'm attaching a small video, you can see that when I remove an item for the list, the title and rating updates, but the image doesn't. This doesn't happen if I use the classic  Accompanist Glide library.
WhatsApp Video 2021-06-21 at 22.41.zip
Expected Behavior:
Whenever the list state changes, the image should recompose too.
Current Glide Code:
>@Composable
> fun PosterImage(posterURL:String){
>     GlideImage(
>                 imageModel = posterURL,
>                 contentScale = ContentScale.FillWidth,
>                 circularRevealedEnabled = true,
>                 placeHolder = ImageBitmap.imageResource(R.drawable.entry_placeholder),
>                 alignment = Alignment.Center,
>                 modifier = Modifier
>                     .fillMaxWidth()
>                     .height(170.dp),
>                 requestOptions = RequestOptions().diskCacheStrategy(DiskCacheStrategy.AUTOMATIC)
>             )
> }

Hi @davidsal,
Does the CoilImage face the same issue?
I think that seems to happen on the GlideImage only from now, I will check into the requests.
Thank you for your issue :)

@davidsal Same Issue for me, I am using Glide for Firebase Storage Reference!

Hi @madhurgupta10,
Thanks for sharing your issue :)
I'm working on this issue and it will be included in the next release probably today.
Thanks!

@davidsal @madhurgupta10
Released a new stable 1.2.8!

@skydoves Thanks a lot, the issue is fixed for me :)


Dispose of SmtpClient

I noticed you are creating an SMTP client here: https://github.com/kjac/FormEditor/blob/0df7ac67fead06e04b77bbd3fd9dfdb1317102f7/Source/Solution/FormEditor/FormModel.cs#L700
Looks like you aren't creating it with a "using" statement, so it may not be disposed of in a timely manner. That can be lead to periodic email send failures.
This same issue existed in the Umbraco core. You can read about the details here: http://issues.umbraco.org/issue/U4-6504
I can create a pull request if you like, but it should just be a quick fix.

Thanks @Nicholas-Westby 👍
I'll fix it asap. Of course you're more than welcome to submit a PR if you want to.

Here you go: https://github.com/kjac/FormEditor/pull/96

Cool. I'll prepare for a new release soon!

@Nicholas-Westby ...and it's released. Thanks again 👍


angular upgrade to v14 deletes dist folder

Command
build
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13
Description
ng build --configuration=prodfast

Generating browser application bundles (phase: setup)...
An unhandled exception occurred: EBUSY: resource busy or locked, rmdir '/project/dist'

In my build case, it's being built in docker like:
docker run --env-file .env.prod -v "/export:/project/dist"
This way, the build is done in a clean enviroment, and the output of dist is mapped the the host enviroment and gets pushed to prod systems
But now it is attempting to do a rmdir of dist, and since that is a mount point and not a folder, it fails and builds no longer happen.
Minimal Reproduction
build angular while the dist is actually a mountpoint instead of a folder
Exception or Error
An unhandled exception occurred: EBUSY: resource busy or locked, rmdir '/project/dist'

Your Environment
docker container inside bitbucket pipeline

Anything else relevant?
No response

I did find "deleteOutputPath": false, option to resolve the issue, not sure why I didn't need it previously.


[Bug]: Do not trust insecure registries by default

What happened?
I just tried to run the sample app cf push nginx --docker-image nginxinc/nginx-unprivileged provided in https://github.com/cloudfoundry/korifi/pull/2910 VM based CF deployment. It fails with this error message. There seems to be also some docs here why.
What you expected to happen
Maybe insecure registries could be supported with a special argument in case we think the it should behave like CF on VMs.
Acceptance Criteria
GIVEN that this is an accepted issue
WHEN I use an insecure registry
THEN it should fails by default
How to reproduce it (as minimally and precisely as possible)
check the descriptions
Anything else we need to know?
N/A
Environment
Kofiri version https://github.com/cloudfoundry/korifi/releases/tag/v0.9.0

Hi @beyhan and thanks for opening an issue!
The image that you have pushed is coming from the docker hub, which is not an
insecure docker registry. As a matter of fact it is the official docker
registry and only supports https.
We attempted to push nginxinc/nginx-unprivileged on a classical CF deployment
and here is the full error we're seeing when we run cf logs --recent:
ERR builder exited with error: failed to fetch metadata from [nginxinc/nginx-unprivileged] with tag [latest] and insecure registries [] due to unsupported schema version 2

The error is actually that the manifest schema of the image is not supported
and no insecure registries have been configured.
In kiubernetes it is not easy to run an image coming from an insecure regsistry
unless you own the docker daemon. More info in this
article
We do not see this as a korifi bug. However if we want to be able to push
insecure images (do we?) we can file a feature request.


Species Type: Clarifications on Molecule Syntax

The current version of the species type extension demands for molecule syntax:
"Use standard chemical notation, e.g.: H2O."
What is "standard chemical notation" specifically?
Notable cases:

Molecules with charge, e.g. OH-
complexes, e.g. [NiCN]+
organic compounds, e.g. C2O5OH, CH3COOH, maybe even CH3-COOH, CH3-CH2-CH3
pedantic there are more complex formulae which are "standard" too, but can't easily be translated to text, e.g. structural formulae
Are parenthesis allowed? e.g. SO2(OH)2 (admittedly non-standard)

Note that parenthesis need to be balanced, which increases parsing complexity: With paranthesis, this can't be parsed by regex.
Semantics: Are (H2)O and H2O considered equal?

This is a bottomless hole, so I'd like to suggest as a minimal version:

("An implementation must support at least the following notation. Additionally, more specific notation may be supported:")
A molecule is given as a sum formula, e.g. semantically only the amount per atom is extracted.
Parenthesis, brackets, (and braces) of any form are forbidden.
If an atom occurs twice its quantities are added. ("An implementation may derive additional information from this, e.g. anorganic groups like OOH.")
Only the total charge of a molecule can be specified by appending "^" *DIGIT ("+" / "-"), e.g. HCO^-, SO4^2-

If the digit is omitted it is assumed to be one, i.e. HCO^1- and HCO^- are equivalent.

Note: A total quantity of a molecule can not be given, i.e. 2H^+ is invalid.

Note: Depending on if an isotope is also an atom maybe use "atom or isotope" repectively.
Note: Potentially replace the charge separator character.

The answer for this is similar to https://github.com/openPMD/openPMD-standard/issues/260#issuecomment-1006464841:
We don't have a use case with a committed chemistry code yet and leave this open to the first one(s) that would like to adopt openPMD.
Note for the future reader: @s9105947 works on PIConGPU, which is an electromagnetic particle-in-cel code in laser-plasma physics (keV to MeV range physics, while molecules are eV physics and not covered by em. PIC.)

In this case I would suggest to remove the paragraph about molecules alltogether:
"The base standard does not encode molecules. However, an implementation MAY support molecules with an implementation-defined syntax."
In my opinion the current "use standard chemical notation" is not sufficiently clear.


(v0.9.1-release) Exclude known test failures on multilple platforms

cherry pick
#3660
#3659
#3664
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

This includes some update for linux-x64, which would be helpful for https://github.com/adoptium/aqa-tests/issues/3640#issuecomment-1129507362


Remove support for entity namespaces (Foo:Bar)

Another possibly controversial PR removing existing feature. Entity namespaces are basically obsolete since PHP 5.5 released 4.5 years ago and are superseded by much safer ::class pseudo-constant, which is refactoring- and autocomplete-friendly in IDEs.

I'm using this notation in DQL rather than FQCN as they can be quite long. Take a look at following:

Acme\Cms\Modules\BlogModule\Entity\Article (yes, this is a bit on extreme side but it shows the idea)
Blog:Article or BlogModule:Article

Removing this feature will make using DQL without builder quite cumbersome I think

Removing this feature will make using DQL without builder quite cumbersome I think

The issue with entity namespaces is that they're solving a problem that doesn't exist anymore (it did back then when Doctrine 2.0 was released for PHP 5.3, ::class is PHP 5.5+). Furthermore, it makes code harder to maintain, harder to read (subjectively) and harder to refactor (rename class, move to different namespace).
SELECT a FROM BlogModule:Article a WHERE a.author = :author

would become:
SELECT a FROM ' . Article::class . ' a WHERE a.author = :author

And with query builder, you won't even need string concatenation:
$qb->select('a')
    -> from(Article::class, 'a')
    -> where('a.author = :author')


General: Clean up Spring configurations

Checklist
General
:warning: This is a config change! :warning:

[ ] I tested these configs locally (Artemis) and with multiple docker setups (Artemis, MySQL, Jenkins, GitLab, Atlassian Stack).
[X] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[X] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context
This cleanup should make it easier to integrate new infrastructure setups and more profiles, like the upcoming ones from the deployment workgroup.
With the introduction of "default" secrets in one versioned file instead of multiple places in the documentation, this should make it easier for newcomers.
Description
This PR separates configurations depending on the used profiles.
It removes configuration value duplicates by restructuring.
We removed some unnecessary configuration values.
Migration Path
application-local.yml
As this file is by it's nature not versioned you have to compare it to application-local.yml.sample.
This is necessary as we extracted all secrets from the other configuration files, so that it's less likely that people use default secrets in production setups.
So make sure to include these secrets in your application-local.yml.
Probably you can exclude some of the other values which aren't mentioned in application-local.yml.sample as for most values you will probably use the new defaults if you are a developer.
Steps for Testing

take a look at the used profiles and especially the order how you load them (this is especially important for production systems)
try starting your every-day Artemis setup with these new configurations!
try to follow the instructions for copying the application-local.yml then startup a basic Artemis setup

Review Progress
Code Review

[ ] Review 1
[ ] Review 2
[ ] KIT review
[ ] UP review
[ ] feel free to add other universities using Artemis

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test

to be honest: I am not a big fan of splitting the config into too many files

There might be the option to just use one big configuration file.
But you would still do the splitting for certain profiles, as some keys, especially in the VCS and CI sections, are competing with each other with their default values.
At least, the introduction of the application-local.yml.sample with versioned defaults is necessary in my opinion and already advertised as the recommended way in the docs instead of editing the application-artemis.yml.

I don't see competing values. What do you mean?

I don't see competing values. What do you mean?

Depending on if you use the Atlassian Stack, the Jenkins/GitLab Stack or Artemis without any VCS and CI you have different default values for certain keys.
Different default values are for instance needed in artemis.version-control.ssh-template-clone-url:.
There are many keys which are just used either for the Jenkings/Gitlab Stack or the Atlassian Stack.
This leads to confusion for newcomers adapting their setups, but also for administrators who don't know what keys belong to which setup variation.

If you want to support multiple configurations locally, you should use multiple local yml files and add according profiles to the run config. We can add this to the documentation with examples if this helps newcomers.
I have this setup locally as well and presented it once in the dev meeting to other developers. This should be part of the onboarding process / tutorial...
It's bad practice to change values in the "normal" yml files because developers might accidentally commit and push these changes and leak their passwords. We should emphasis on this in the documentation as well, if this is not yet the case.
So splitting the config into multiple yml files only has disadvantages in my opinion. Please revert this change!

If you want to support multiple configurations locally, you should use multiple local yml files and add according profiles to the run config. We can add this to the documentation with examples if this helps newcomers.
I have this setup locally as well and presented it once in the dev meeting to other developers. This should be part of the onboarding process / tutorial...
It's bad practice to change values in the "normal" yml files because developers might accidentally commit and push these changes and leak their passwords. We should emphasis on this in the documentation as well, if this is not yet the case.

One of this PR's goal is exactly what you just mentioned :wink:

In the docs I added a hint box used in multiple places which recommends the usage of the application-local.yml file.
I removed all instances in the docs where application-artemis.yml was modified!

https://artemis-platform--5944.org.readthedocs.build/en/5944/dev/setup/#server-setup

This was a suggestion from my side. For me the spring configuration files were quite hard to understand when I started working on Artemis. It was not obvious to me which values correspond to which external system. I think it is easier to understand if all the possible config values for e.g. Jenkins  are in the -jenkins.yml. In the existing spring properties setup we had a lot of duplication and config mismatches that grew over time and are hard to grasp.
I suggested this change explicitly because we have to simplify and streamline the configuration for the docker and Kubernetes deployments. In these deployments all the config values come from the environment - so these configuration files will no longer be visible to potential Artemis users/administrators anyway (only developers may interact with these files). However, the (default) environment configuration for docker and Kubernetes has to be kept in sync with these spring configurations. In my opinion it is easier to split all the possible spring profiles explicitly so we can mirror changes in the docker-compose or helm values accordingly if a new spring property value has to be added in the future.
In addition to that this PR introduces a sample configuration for the local setup with instructions how to setup Artemis with the local external systems (See new docker configuration in https://github.com/ls1intum/Artemis/pull/5915) which encapsulates only the important spring values that have to be adjusted by a "normal" developer. This should streamline the onboarding of new developers.
Maybe we can have a short meeting in the next few days to discuss this change in more detail.

@Mtze
At the moment, we are still far away from a Kubernetes setup. Also, there might still be Artemis administrators who want to use the current setup, so we still have to support it for quite some time
I don't see an advantage to duplicate the values for VCS in a bitbucket and gitlab file and then even out comment them because developers should override them in a local file.

Disadvantage: Common values for VCS need to be maintained in multiple places, this is error prone and could also lead to issues
Disadvantage: I need to define all values in my local file, even if I don't want to override a default value

I am perfectly fine when we simplify the configuration, but the current changes do not simplify it. Instead, they make it even more difficult in the future.
From my point of view the following split makes absolute sense and must be kept:

application.yml --> General Spring Config for Dev and Prod
application-dev.yml --> Development specific adjustments of the Config
application-prod.yml --> Production specific adjustments of the Config
application-artemis.yml --> All Artemis specific values
Which values exactly are in 1, 2 and 3, we can certainly discuss and a cleanup would definitely help (the more values we have in application.yml, the better it would be. We can discuss whether 4 is necessary

What we should do in my opinion:

application-gitlab.yml --> move to application-artemis.yml (makes sense from my point of view to reduce the number of config files)
application-jenkins.yml --> move to application-artemis.yml (makes sense from my point of view to reduce the number of config files)
3. To discuss: application-artemis.yml --> move to application.yml

gitlab and jenkins whould be own entries below artemis, like athene and apollon are.

@krusche

At the moment, we are still far away from a Kubernetes setup. Also, there might still be Artemis administrators who want to use the current setup, so we still have to support it for quite some time

Yes, we're still early on in the process for the transition to a k8s setup. This change is one of many steps we should make at some point to ensure consistency between multiple deployment strategies (for now docker, ansible, and "manual"). Existing setups will still possible the same way they are now.   For production setups all the configuration values are supplied via one application-prod.yml which encapsulates all deployment specific values. We don't change that in this PR. Only the location of default values are different.
I agree with the split:

application.yml
application-dev.yml
application-prod.yml

you suggest (I believe this PR also fully implements this).
However, I think the split into spring profiles still makes sense. I agree that in this PR the amount of properties files "looks" complicated, but we only encapsulate the necessary config values for each system (So sort of "information hiding").
With the suggested solution a new developer who is concerned with e.g. gitlab/jenkins, can view and access all the interesting configuration values at a glance in the respective files. With the monolithic artemis.yml file on the other hand  it is not clear which values are Jenkins related or Bamboo related. Also the creation of custom -prod.yml files can be streamlined as all possible options for each external system are mentioned in the respective files.
Regarding the disadvantages  you mentioned:

Yes, if new common VCS or CI configurations are added, they have to be added to all the respective VCS and/or CI configurations. But I don't think this is a bad thing: New common values are rare and have to be tested very thoroughly  anyway. Explicitly adding the values to the files implies that the developer has thought about the value wrt. the external system. I would also add that most of the (in the end) common values start with an implementation/configuration for only one of the external systems and then are gradually expanded for the other options.
The local configuration will not change (correct my if I'm wrong @4ludwig4). Existing setups should still be functional after this PR is integrated. This solution only introduced a new layout of the local.yml but the core idea is the same. The local file encapsulates all the config values a developer has to provide for Artemis to work in the IDE. In this file we provide templates for all the external systems which can be un-commented depending on the developers preference/setup.

Regarding

gitlab and jenkins whould be own entries below artemis, like athene and apollon are.

I don't think that this is a good solution on its own, because we are no longe on the same level of abstraction in the config files (artemis.continuous-integration: {} -> artemis.jenkins: {}.
We would need the same entries for jira, bitbucket and bamboo then. This would be a large (and breaking) change.  If we want to go that route, I'm up for it but I still belief each system should have its own default config file.
I'll try to summarize the advantages and disadvantages of this change from my point of view
Advantages:

Clear separation of config values for each external system
Easy (initial) setup for new developers - They only have to use the sample -local.yml
Dependable config values ("If I load the jenkins profile I get the correct default values from application-jenkins.yml and have to provide the deployment specific values via -prod.yml or  -local.yml. I can see all possible option in the -jenkins.yml file")
Future proof: We can use the same config layout for k8s and the docker environment configuration.

Disadvantages

We have more files in the resources folder (I don't think this is a problem - we had already quite a few config files)
New common values have to be added to multiple locations (See my argument from above)

After all it is a matter of preference I guess. So if you're absolutely against this change we don't have to integrate it. But I hope we can still discuss this once more as I think this is conceptually a valuable addition/simplification in the long term. This PR is still in an early stage after all.

Regarding the split of the configuration files, it was decided in this developer meeting that we will split the spring configuration files and create a configuration file for each profile.
I will now resolve the merge conflicts and retest this PR.


updated .gitignore for vim and added a debug convenience

I find it easier to debug unit tests with node's debug mode.

Thank you!
BTW, I've just fixed the tests and bumped version to 0.2.0


Refine ConfigurationPropertiesNativeConfigurationProcessor

@snicoll While reviewing 7eef3c2447656c637c7b7a67f492b70633c1e032 and having a deeper look to ConfigurationPropertiesNativeConfigurationProcessor in order to add more tests to validate the behavior, I found several points I would like to discuss with you next week.
That would have been more obvious if I had added proper test (sorry for that), but the fact that a "class reflection entry only" was added for java. type as implemented here was done on purpose, so if you agree I would like to restore (and test) this behavior. Java types are usually handled in a special way by serialization library, so no need for constructor or method reflection config, but a reflection entry for the type is likely needed. That works without in our integration tests since those entries are contributed by other part of the application, but I think that would be cleaner to contribute them.
I am also wondering if we should also process reflection entries for:

Container types like Map or List (class reflection entry only)
All generic types (for example the key on maps)
Array reflection entries could be missing, so when we process Address[], maybe we miss a "class reflection entry only" for Address[] in addition to what we register for Address. I can check that in the boot-features sample.

cc @aclement

That works without in our integration tests since those entries are contributed by other part of the application, but I think that would be cleaner to contribute them.

In fact, that does not work so I will fix that regression with related tests asap.


AWS ECR login fails in windows-2022 20241211.1.0

Description
We've started experiencing failures to login to AWS ECR starting from windows-2022 20241211.1.0
We're using "big" runners, which have received the update to 20241211.1.0 on which we're experiencing this failure.
We're not experiencing this on windows-2022 runners, which still have 20241201.2.0
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions - Standard Runners
[X] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Works as expected in 20241201.2.0
fails in 20241211.1.0
Is it regression?
20241201.2.0
Expected behavior
I'm able to authenticate with AWS ECR using aws-actions/amazon-ecr-login@v1
Actual behavior
Error: Could not login to registry redacted.dkr.ecr.eu-west-1.amazonaws.com: WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Error saving credentials: error storing credentials - err: exit status 1, out: `A specified logon session does not exist. It may already have been terminated.`

Repro steps

Have the following steps in your workflow:

- name: Configure AWS Credentials
  uses: aws-actions/configure-aws-credentials@v4
  with:
    aws-region: eu-west-1
    role-to-assume: arn:aws:iam::redacted:role/redacted
    role-skip-session-tagging: true
    role-duration-seconds: 3600

- name: Login to Amazon ECR
  id: login-ecr
  uses: aws-actions/amazon-ecr-login@v1
  with:
    mask-password: true

Observe failure

Hi @PatTheSilent ,
Thank you for raising the issue , we will look into the issue and update Asap

Hi folks, just adding that my organization has also run into this issue. Our logs indicate we first experienced the failure at the end of last week (went unnoticed going into the weekend), and we continue to see it this morning.
As with @PatTheSilent, we are encountering this in a workflow that uses a GitHub-hosted large runner pool, and as with @mavimo, we're seeing it during the first<EMAIL_ADDRESS>step in our workflow.
One difference from @mavimo is that we are seeing this failure in 20241215.1.0 (i.e. 2024-12-15).
@kishorekumar-anchala please see below for some lightly sanitized logs, and please let me know if I can provide any additional information to help your investigation. This is a major blocker for building Windows-based Docker images in CI, so hoping our logs may help things along:
2024-12-16T16:40:46.7689783Z ##[debug]Starting: *** / ***
2024-12-16T16:40:46.7710528Z ##[debug]Cleaning runner temp folder: C:\a\_temp
2024-12-16T16:40:46.7811255Z ##[debug]Starting: Set up job
2024-12-16T16:40:46.7812545Z Current runner version: '2.321.0'
2024-12-16T16:40:46.7815921Z Runner name: 'windows-latest-16-cores_b1e07f54e0dd'
2024-12-16T16:40:46.7816683Z Runner group name: 'Default Larger Runners'
2024-12-16T16:40:46.7817474Z Machine name: 'runner'
2024-12-16T16:40:46.7833268Z ##[group]Operating System
2024-12-16T16:40:46.7833912Z Microsoft Windows Server 2022
2024-12-16T16:40:46.7834431Z 10.0.20348
2024-12-16T16:40:46.7834865Z Datacenter
2024-12-16T16:40:46.7835292Z ##[endgroup]
2024-12-16T16:40:46.7835714Z ##[group]Runner Image
2024-12-16T16:40:46.7836219Z Image: windows-2022
2024-12-16T16:40:46.7836684Z Version: 20241215.1.0
2024-12-16T16:40:46.7837631Z Included Software: https://github.com/actions/runner-images/blob/win22/20241215.1/images/windows/Windows2022-Readme.md
2024-12-16T16:40:46.7838991Z Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20241215.1
2024-12-16T16:40:46.7840242Z ##[endgroup]
2024-12-16T16:40:46.7841261Z ##[group]GITHUB_TOKEN Permissions
2024-12-16T16:40:46.7842891Z Contents: read
2024-12-16T16:40:46.7843409Z Metadata: read
2024-12-16T16:40:46.7843863Z Packages: read
2024-12-16T16:40:46.7844297Z ##[endgroup]
2024-12-16T16:40:46.7846921Z Secret source: Actions
2024-12-16T16:40:46.7847592Z ##[debug]Primary repository: ***/***
2024-12-16T16:40:46.7848217Z Prepare workflow directory
2024-12-16T16:40:46.7908402Z ##[debug]Creating pipeline directory: 'C:\a\***'
2024-12-16T16:40:46.7912530Z ##[debug]Creating workspace directory: 'C:\a\***\***'
2024-12-16T16:40:46.7914880Z ##[debug]Update context data
2024-12-16T16:40:46.7918147Z ##[debug]Evaluating job-level environment variables
2024-12-16T16:40:46.8115854Z ##[debug]Evaluating job container
2024-12-16T16:40:46.8118812Z ##[debug]Evaluating job service containers
2024-12-16T16:40:46.8121159Z ##[debug]Evaluating job defaults
2024-12-16T16:40:46.8144293Z Prepare all required actions
2024-12-16T16:40:46.8180459Z Getting action download info
2024-12-16T16:40:47.0495028Z Download action repository 'actions/checkout@v4' (SHA:11bd71901bbe5b1630ceea73d27597364c9af683)
2024-12-16T16:40:47.0578616Z ##[debug]Copied action archive 'C:\actionarchivecache\actions_checkout\11bd71901bbe5b1630ceea73d27597364c9af683.zip' to 'C:\a\_actions\_temp_77d28f9e-d1c4-4a3d-ae63-3c2b5add9e9b\0432622f-af9b-4cfe-9825-d03395055f4c.zip'
2024-12-16T16:40:47.1177177Z ##[debug]Unwrap 'actions-checkout-11bd719' to 'C:\a\_actions\actions\checkout\v4'
2024-12-16T16:40:47.1699031Z ##[debug]Archive 'C:\a\_actions\_temp_77d28f9e-d1c4-4a3d-ae63-3c2b5add9e9b\0432622f-af9b-4cfe-9825-d03395055f4c.zip' has been unzipped into 'C:\a\_actions\actions\checkout\v4'.
2024-12-16T16:40:47.1833111Z Download action repository<EMAIL_ADDRESS>(SHA:1bd1e32a3bdc45362d1e726936510720a7c30a57)
2024-12-16T16:40:47.4163680Z ##[debug]Download 'https://api.github.com/repos/actions/cache/zipball/1bd1e32a3bdc45362d1e726936510720a7c30a57' to 'C:\a\_actions\_temp_e7bfaf1a-8e0a-4cb1-97aa-2be44230fd2a\127191c6-7540-4f59-a000-2d3d935a26a0.zip'
2024-12-16T16:40:47.5137154Z ##[debug]Unwrap 'actions-cache-1bd1e32' to 'C:\a\_actions\actions\cache\v4.2.0'
2024-12-16T16:40:47.5878838Z ##[debug]Archive 'C:\a\_actions\_temp_e7bfaf1a-8e0a-4cb1-97aa-2be44230fd2a\127191c6-7540-4f59-a000-2d3d935a26a0.zip' has been unzipped into 'C:\a\_actions\actions\cache\v4.2.0'.
2024-12-16T16:40:47.6051169Z Download action repository<EMAIL_ADDRESS>(SHA:9780b0c442fbb1117ed29e0efdff1e18412f7567)
2024-12-16T16:40:47.8447404Z ##[debug]Download 'https://api.github.com/repos/docker/login-action/zipball/9780b0c442fbb1117ed29e0efdff1e18412f7567' to 'C:\a\_actions\_temp_c24a88d1-288b-4483-b6fa-645a767a2989\eefaa603-0ec6-4707-8610-a5137caf1478.zip'
2024-12-16T16:40:47.9064170Z ##[debug]Unwrap 'docker-login-action-9780b0c' to 'C:\a\_actions\docker\login-action\v3.3.0'
2024-12-16T16:40:47.9354894Z ##[debug]Archive 'C:\a\_actions\_temp_c24a88d1-288b-4483-b6fa-645a767a2989\eefaa603-0ec6-4707-8610-a5137caf1478.zip' has been unzipped into 'C:\a\_actions\docker\login-action\v3.3.0'.
2024-12-16T16:40:47.9405449Z Download action repository 'actions/setup-dotnet@v4' (SHA:3e891b0cb619bf60e2c25674b222b8940e2c1c25)
2024-12-16T16:40:48.1783669Z ##[debug]Download 'https://api.github.com/repos/actions/setup-dotnet/zipball/3e891b0cb619bf60e2c25674b222b8940e2c1c25' to 'C:\a\_actions\_temp_f956dbdf-b53a-4edf-bd1a-0d497761d038\eea64bcc-e283-456a-80e6-e1388ea871d8.zip'
2024-12-16T16:40:48.2615349Z ##[debug]Unwrap 'actions-setup-dotnet-3e891b0' to 'C:\a\_actions\actions\setup-dotnet\v4'
2024-12-16T16:40:48.3280162Z ##[debug]Archive 'C:\a\_actions\_temp_f956dbdf-b53a-4edf-bd1a-0d497761d038\eea64bcc-e283-456a-80e6-e1388ea871d8.zip' has been unzipped into 'C:\a\_actions\actions\setup-dotnet\v4'.
2024-12-16T16:40:48.3420374Z Download action repository 'aws-actions/configure-aws-credentials@v4' (SHA:e3dd6a429d7300a6a4c196c26e071d42e0343502)
2024-12-16T16:40:48.4711995Z ##[debug]Download 'https://api.github.com/repos/aws-actions/configure-aws-credentials/zipball/e3dd6a429d7300a6a4c196c26e071d42e0343502' to 'C:\a\_actions\_temp_f9bbd782-3859-4e96-8b45-1556e2cb4ef7\d9173f99-450d-4831-a378-67d23f11a006.zip'
2024-12-16T16:40:48.5112813Z ##[debug]Unwrap 'aws-actions-configure-aws-credentials-e3dd6a4' to 'C:\a\_actions\aws-actions\configure-aws-credentials\v4'
2024-12-16T16:40:48.5428440Z ##[debug]Archive 'C:\a\_actions\_temp_f9bbd782-3859-4e96-8b45-1556e2cb4ef7\d9173f99-450d-4831-a378-67d23f11a006.zip' has been unzipped into 'C:\a\_actions\aws-actions\configure-aws-credentials\v4'.
2024-12-16T16:40:48.5498172Z ##[debug]action.yml for action: 'C:\a\_actions\actions\checkout\v4\action.yml'.
2024-12-16T16:40:48.6148331Z ##[debug]action.yml for action: 'C:\a\_actions\actions\cache\v4.2.0\action.yml'.
2024-12-16T16:40:48.6221905Z ##[debug]action.yml for action: 'C:\a\_actions\docker\login-action\v3.3.0\action.yml'.
2024-12-16T16:40:48.6270378Z ##[debug]action.yml for action: 'C:\a\_actions\actions\setup-dotnet\v4\action.yml'.
2024-12-16T16:40:48.6333062Z ##[debug]action.yml for action: 'C:\a\_actions\aws-actions\configure-aws-credentials\v4\action.yml'.
2024-12-16T16:40:48.6499756Z ##[debug]Set step '__run' display name to: '***'
2024-12-16T16:40:48.6503450Z ##[debug]Set step '__actions_checkout' display name to: '***'
2024-12-16T16:40:48.6506256Z ##[debug]Set step '__actions_cache' display name to: '***'
2024-12-16T16:40:48.6509007Z ##[debug]Set step '__docker_login-action' display name to: 'Login (GitHub)'
2024-12-16T16:40:48.6511898Z ##[debug]Set step '__actions_setup-dotnet' display name to: '***'
2024-12-16T16:40:48.6515213Z ##[debug]Set step '__aws-actions_configure-aws-credentials' display name to: '***'
2024-12-16T16:40:48.6518688Z ##[debug]Set step '__run_2' display name to: '***'
2024-12-16T16:40:48.6521055Z ##[debug]Set step '__run_3' display name to: '***'
2024-12-16T16:40:48.6523641Z ##[debug]Set step '__run_4' display name to: '***'
2024-12-16T16:40:48.6526216Z ##[debug]Set step '__run_5' display name to: '***'
2024-12-16T16:40:48.6528696Z ##[debug]Set step '__run_6' display name to: '***'
2024-12-16T16:40:48.6531208Z ##[debug]Set step '__run_7' display name to: '***'
2024-12-16T16:40:48.6533829Z ##[debug]Set step '__run_8' display name to: '***'
2024-12-16T16:40:48.6536481Z ##[debug]Set step '__run_9' display name to: '***'
2024-12-16T16:40:48.6539081Z ##[debug]Set step '__run_10' display name to: '***'
2024-12-16T16:40:48.6542263Z Uses: ***/***/.github/workflows/***.yml@refs/heads/main (***)
2024-12-16T16:40:48.6545638Z ##[group] Inputs
2024-12-16T16:40:48.6546809Z   ***: ***
2024-12-16T16:40:48.6547653Z   ***: ***
2024-12-16T16:40:48.6549250Z   ***: ***
2024-12-16T16:40:48.6550056Z ##[endgroup]
2024-12-16T16:40:48.6551251Z Complete job name: *** / ***
2024-12-16T16:40:48.6645181Z ##[debug]Collect running processes for tracking orphan processes.
2024-12-16T16:40:48.6766419Z ##[debug]Finishing: Set up job

2024-12-16T16:41:24.3062620Z ##[debug]Evaluating condition for step: 'Login (GitHub)'
2024-12-16T16:41:24.3064675Z ##[debug]Evaluating: success()
2024-12-16T16:41:24.3065055Z ##[debug]Evaluating success:
2024-12-16T16:41:24.3065611Z ##[debug]=> true
2024-12-16T16:41:24.3065964Z ##[debug]Result: true
2024-12-16T16:41:24.3066493Z ##[debug]Starting: Login (GitHub)
2024-12-16T16:41:24.3150949Z ##[debug]Register post job cleanup for action<EMAIL_ADDRESS>2024-12-16T16:41:24.3175653Z ##[debug]Loading inputs
2024-12-16T16:41:24.3176832Z ##[debug]Evaluating: github.actor
2024-12-16T16:41:24.3177078Z ##[debug]Evaluating Index:
2024-12-16T16:41:24.3177298Z ##[debug]..Evaluating github:
2024-12-16T16:41:24.3177537Z ##[debug]..=> Object
2024-12-16T16:41:24.3177752Z ##[debug]..Evaluating String:
2024-12-16T16:41:24.3177955Z ##[debug]..=> 'actor'
2024-12-16T16:41:24.3178203Z ##[debug]=> 'austindrenski'
2024-12-16T16:41:24.3178433Z ##[debug]Result: 'austindrenski'
2024-12-16T16:41:24.3178933Z ##[debug]Evaluating: secrets.GITHUB_TOKEN
2024-12-16T16:41:24.3179171Z ##[debug]Evaluating Index:
2024-12-16T16:41:24.3179388Z ##[debug]..Evaluating secrets:
2024-12-16T16:41:24.3179608Z ##[debug]..=> Object
2024-12-16T16:41:24.3179795Z ##[debug]..Evaluating String:
2024-12-16T16:41:24.3179995Z ##[debug]..=> 'GITHUB_TOKEN'
2024-12-16T16:41:24.3180409Z ##[debug]=> '***'
2024-12-16T16:41:24.3180680Z ##[debug]Result: '***'
2024-12-16T16:41:24.3182010Z ##[debug]Loading env
2024-12-16T16:41:24.3185457Z ##[group]Run<EMAIL_ADDRESS>2024-12-16T16:41:24.3185672Z with:
2024-12-16T16:41:24.3185827Z   username: austindrenski
2024-12-16T16:41:24.3186111Z   password: ***
2024-12-16T16:41:24.3186272Z   registry: ghcr.io
2024-12-16T16:41:24.3186434Z   ecr: auto
2024-12-16T16:41:24.3186578Z   logout: true
2024-12-16T16:41:24.3186720Z env:
2024-12-16T16:41:24.3186861Z   ***: ***
2024-12-16T16:41:24.3187039Z   ***: ***
2024-12-16T16:41:24.3187235Z   ***:
2024-12-16T16:41:24.3187488Z   ***: ***
2024-12-16T16:41:24.3187904Z   ***: ***
2024-12-16T16:41:24.3188253Z   ***: ***
2024-12-16T16:41:24.3188466Z   ***: ***
2024-12-16T16:41:24.3188718Z   TARGET_BUILD_DATE_TIME: 2024-12-16T16:40:49.7896697Z
2024-12-16T16:41:24.3188963Z   TARGET_BRANCH: main
2024-12-16T16:41:24.3189137Z ##[endgroup]
2024-12-16T16:41:24.6663919Z Logging into ghcr.io...
2024-12-16T16:41:24.6675983Z ##[debug]Exec.getExecOutput: docker login --password-stdin --username austindrenski ghcr.io
2024-12-16T16:41:29.2672660Z ##[error]Error saving credentials: error storing credentials - err: exit status 1, out: `A specified logon session does not exist. It may already have been terminated.`
2024-12-16T16:41:29.2744000Z ##[debug]Node Action run completed with exit code 1
2024-12-16T16:41:29.2747840Z ##[debug]Save intra-action state isPost = true
2024-12-16T16:41:29.2748241Z ##[debug]Save intra-action state registry = ghcr.io
2024-12-16T16:41:29.2748596Z ##[debug]Save intra-action state logout = true
2024-12-16T16:41:29.2751044Z ##[debug]Finishing: Login (GitHub)

Thanks @mavimo, that does indeed get us unblocked in the meantime!

[!Note]
In the spirit of contributing copy/pasta for future readers, here's what we added just before the first login action step of each affected workflow:
- name: Temporary workaround for actions/runner-images#11172
  run: |
    mkdir --parents ~/.docker
    echo '{"auths":{"ghcr.io":{}}}' > ~/.docker/config.json
  shell: bash

Hello everyone,
Thank you for reporting the problem. We have identified root cause and working on fix.
The fix should be deployed within 1-2 days. Also, we are discussing internally a hotfix which can be deployed faster.

@maxim-lobanov can confirm my builds pass now without a problem

@maxim-lobanov Any idea what the propagation time is internally, e.g. to 1ES Pools? (still seeing failures here, not sure when we can expect recovery to unblock CIs)

@NickCraver sorry, I am not familiar with 1ES pools and didn't expect them to be impacted 🤔. This issue was related to configuration of Larger Runners in GitHub Actions and even Standard Runners were not impacted by this problem (Standard Runners and Larger Runners re-use the same image).
If you feel that it is the same issue on 1ES pools and timeline of issue matches, could you please share some additional logs from begin of job? Like image version, agent, etc.

we see image version 156.0.0 right now

I am bit confused because our image versions have different format like 20241211.1.0. So, I am not 100% sure that it is the same problem.

@maxim-lobanov Definitely can - they're internal links though, Teams? It may be unrelated, we're seeing issue with git credential storage on Windows that happened at the same time (starting Saturday) and it only applies to this image, not an older one running in another pool running the same tests in another region, so we have a data point there to compare to at least.

@maxim-lobanov Heads up we are seeing the same behavior on 20241215.2 internally.


Ricoh MP-C4503 PDF/PS/PXL provided ppds do not work but Gutenprint PPD works

Describe the bug
I have a Ricoh MP-C4503 copier and using the cups provided Gutenprint ppd file with no issue but it does not provide utilization of options like the attached finisher.
If I change the PPD file to the Ricoh provided ones located in openprinting then cups do send the job, and the printer shows a Job processing then cancelled with error like "The job was reset".
I tried by removing the printer and readd from scratch as well as just changing the driver from the working Gutenprint ppd file to the Ricoh provided file but get the same result.
To Reproduce
Steps to reproduce the behavior:

Add the printer using any printer manager program.
Follow instructions (either add a discovered network printer or add the printer's ip address directly)
When choosing the driver, I choose the Ricoh PPD driver downloaded from openprinting.org
Try to print a file or a click on "print test page"
Cups show job completed
Printer shows "the Job was resest"

Expected behavior
The printer prints.
System Information:

Fedora 38 64bit
Using any pdf viewer or print directly from command line
CUPS version:  2.4.6

For me all the generated PostScript files look OK and they display correctly with evince (which uses Ghostscript). So I am not able to locate any bug. Looks like the PPD provided by Ricoh perhaps supplies some incompatible or broken PostScript code with one of the options. As @malsaqer does not have the printer any more and will not necessarily get the same model as replacement I will close this bug here, and generally, if a printer supports other formats than PostScript, recommend using one of the other formats, as printer's PostScript interpreters are often buggy. Especially we see here that the printer in question works as a PDF or PXL printer.

For me all the generated PostScript files look OK and they display correctly with evince (which uses Ghostscript). So I am not able to locate any bug. Looks like the PPD provided by Ricoh perhaps supplies some incompatible or broken PostScript code with one of the options. As @malsaqer does not have the printer any more and will not necessarily get the same model as replacement I will close this bug here, and generally, if a printer supports other formats than PostScript, recommend using one of the other formats, as printer's PostScript interpreters are often buggy. Especially we see here that the printer in question works as a PDF or PXL printer.

We replaced the printer with ricoh MP-C3504 which works just fine using either PS or PDF providing PPD drivers!  Thank you for providing help with the previous printer with a fix that made it work until replaced.

Thanks for the update, @malsaqer !


styles(widget-space): Updated space row to pointer cursor on hover

@ianwremmel is there a DOM element that does what a button does but feels a tad better than button? I think it may be good to attach a role="button".


Add HTTP client generator

First of all, thank you for this well written Thrift library.
Want: to use Elixir with an existing Thrift web service written in Java.
History:
I tried to modify the reference Erlang Apache Thrift implementation for use in a web client.
It worked for me but not clean enough for PR merge (due to fundamental structural issues in the Erlang code). It was very ugly.
Then I found this project with clearly delineated functionalities and modules.
It enabled me to quickly create a working Thrift web service client generator for our needs (included in this PR)
Discussion:
You thoughts on having support for HTTP clients as part of this project?

Hi @vanjabucic, we are significantly changing how we generate clients/servers so that code generation is decoupled from client/server implementation. The start of the work is in https://github.com/pinterest/elixir-thrift/pull/441. Ideally a HTTP client would not do any generation once that PR is landed, instead we generate per protocol (e.g. BinaryProtocol), and then dispatch to generic client transport implementation (e.g. framed, or http). If we do include a http client I would prefer it to be https://github.com/ericmj/xhttp, though don't know if its ready for a release yet. Of course with other diff, it should be equally possibly for this to be inside or outside.

@fishcakez Sounds like a good idea. Having a pluggable transport would be good as I was also considering using RabbitMQ as a broker.
Anyhow, I will continue using my current branch until the new architecture is in place.
I am interested in creating the new HTTP transport via xhttp and will be following #441 closely.
Thanks


(auth-backend) Bugfix: Do not throw Exception if scopes dont exist. Refs #1786

Refs #1786
Currently, the OAuthProvider library in auth-backend throws an
Exception if scopes are missing in the start (initial) request
in the Authorization flow. Scopes are an optional parameter as per the
spec, so if scopes are empty, simply forward the empty scopes instead of
throwing an Exception
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

@Rugvip The tests passed and I also made a  request to the endpoint without the scopes. Passport handled the empty string fine.
I think it might be a good idea to add more tests but not sure how and what would be a good test at the moment. Maybe I can do it in another PR.

Yeah tests for the individual providers is kinda tricky because it mostly depends on how the provider service itself behaves. Tests are mostly added for the common abstractions right now, but we could definitely try expand the testing of the providers.
Good to merge this either way then 👍