V2 routing root index path issue

What version of Remix are you using?
1.11.0
Steps to Reproduce
npx create-remix@latest
Switch to V2 routing, and run remix routes
Expected Behavior
After the 1.11 update, leaf index.tsx routes should be recognised by the routing system (This works with remix-flat-routes).
/routes/index.tsx
<Route index file="routes/index.tsx" />
/routes/test/index.tsx
<Route path="test" file="routes/test/index.tsx" />
Actual Behavior
/routes/index.tsx
<Route path="index" file="routes/index.tsx" />
/routes/test/index.tsx
<Route path="test" file="routes/test/index.tsx" />

Can you check if 1.11.1 works for you?
https://github.com/remix-run/remix/releases/tag/remix%401.11.1

I'm seeing the same issue on 1.11.1 as well.
If I have app/routes/_index.tsx then I get the correct output from remix routes of:
<Route index file="routes/_index.tsx" />
When changing the filename to app/routes/index.tsx then the output of remix routes changes to:
<Route path="index" file="routes/index.tsx" />
My content then does not appear at localhost:3000
I've made a repo to reproduce is here - https://github.com/Deanmv/remix-issue-5216

@Deanmv index routes in v2 routing must be named _index.tsx. Naked index.tsx only works as the route file in flat-folders convention.
flat-files
routes/test.tsx => /test layout
routes/test._index => /test/ index route
flat-folders
routes/test/index.tsx => /test layout
routes/test._index/index.tsx => /test/ index route

@kiliman ah, looks like I've misunderstood that then. Ignore me 😄
Thanks for the example!

Routes can also be folders with a conventional index.tsx file inside defining the route module. The rest of the files in the folder will not become routes. This allows you to organize your code closer to the routes that use them instead of repeating the feature names across other folders.

Route File Naming (v2) #folders-for-organization
By "Can also" does that mean by opting into the v1 convention? or that you can use index.tsx in a folders with new v2 conventions.

@ianhernandez it's for V2

@ianhernandez the "can also" refers to v2 convention, a route can be a flat-file or a flat-folder (which is basically the route name as the folder name, and index.tsx is the route file).

I believe there is still an issue in Remix v1.11.1 with the flat-folder folder convention and index routes.
Consider the following structure (essentially similar example as in the docs):
routes/_main/index.tsx -> layout without URL nesting
routes/_main._index/index.tsx -> index path with _main layout, e.g localhost/ should map to this
routes/_main.foo/index.tsx ->  foo path with _main layout, e.g localhost/foo should map to this
If I understand everything correctly, this is how the convention should work, but running remix dev or remix routes yields an error, specifically: Error: Path undefined defined by route "_main._index/index" conflicts with route "_main/index"
Chaning to structure to the following:
routes/_main/index.tsx
routes/_main.index/index.tsx
routes/_main.foo/index.tsx
fixes the error, and running remix routes yield:
<Routes>   <Route file="root.tsx">     <Route index file="routes/_main/index.tsx" />     <Route path="foo" index file="routes/_main.foo/index.tsx" />   </Route> </Routes>
which seems correct, but the contents of routes/_main.index/index.tsx are not rendered in the Outlet of the _main layout. Route foo works as expected. Am I missing something ?

Just did the 15 min tutorial with the indie stack and can confirm - had to change app/routes/_index.tsx to app/routes/index.tsx and then adjust the remix config v2_routeConvention to false.

Yes, the transition to v2 routes will be messy, with so many tutorials still showing the old routing convention. Unfortunately, it's not backward compatible.
I have a migration script to go from v1 to v2 (flat routes). It's part of my remix-flat-routes package.

This needs to be highlighted in the blog tutorial, as it is currently broken. Either a quick fix of switching back to v1 routes or updating the tutorial to v2 routing.

Fixed by #5959


Better description needed

This site is linked to from chat description. Why is it officially unofficial?
What does that even mean?
Why aren't are mods contributors?

The description is intended to be silly. This site is not official in any way nor should its contents be considered official policy.
I'm not sure what you mean about the moderators not being contributors. If you click Contributors, you'll see that Doorknob (KeyboardFire), Dennis (DennisMitchell), and myself (Alex A., ararslan) are indeed contributors. Granted, all that means is that we've contributed code to the project. All of the current moderators have provided input on the contents of the site before it was hosted, and a number of folks in The Nineteenth Byte have provided suggestions.


Release ParmEd 4.0.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@simonbray you beat me to it.  I forgot that I removed xparmed from the code base for 4.0.  Everything else should still be there.

@simonbray you beat me to it. I forgot that I removed xparmed from the code base for 4.0. Everything else should still be there.

no worries, feel free to merge these yourself in future if you like

no worries, feel free to merge these yourself in future if you like

Now that I'm releasing 4.1.0, I was going to try this, but it turns out I don't have write permission to this repo so I can't.


changed the variable name to more general and changed page not found icon

#356

could you cut out the comment lines too? think they're fully obsolete

other than that, looks good to go!


Open ended fundraise

This is the functionality I would like to work on, needs conflict resolution

Hi,
in an attempt to clean up the current specification, I'm going to close old and outstanding pull requests. Please note, it's tagged as "old idea", so the work is not wasted and we can potentially review it at some point later.
Please feel free to resubmit it as new pull request, if you still think it's a good idea.


OCI: Add sh.brew.tab to the image manifest

The tab is needed to install the package using the SHA-256 of the single-architecture image.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

See for example the SHA-256 of the single-architecture images advertised under the OS / Arch tab of the multi-architecture image at https://github.com/orgs/brewsci/packages/container/package/bio/seqkit-mediatype-docker

Review period will end on 2021-04-06 at 00:00:00 UTC.

Review period skipped due to critical label.


Add Property to FSharpType to provide access to parameter group informarion

For Example:
let (|Function|Operator|Pattern|ClosureOrNestedFunction|Val|Unknown|) (symbolUse:FSharpSymbolUse) =
        match symbolUse with
        | CorePatterns.MemberFunctionOrValue symbol
            when not (isConstructor symbol) ->
                match symbol.FullTypeSafe with
                | Some fullType when fullType.IsFunctionType
                                    && not symbol.IsPropertyGetterMethod
                                    && not symbol.IsPropertySetterMethod ->
                    if FSharpTypeExt.isOperatorOrActivePattern symbol.DisplayName then
                        if symbolUse.IsFromPattern then Pattern symbol
                        else Operator symbol
                    else
                        if not symbol.IsModuleValueOrMember then ClosureOrNestedFunction symbol
                        else Function symbol
                | Some _fullType -> Val symbol
                | None -> Unknown
        | _ -> Unknown

And with an active pattern case symbol (FSharpActivePatternCase) of Function there is an overall type available via apc.Group.OverallType, which is an FSharpType
Yes we can format this with apc.Group.OverallType.Format displaycontext but that will give us a rather large string thats not east to present to the user:
FSharpSymbolUse ->Choice<FSharpMemberOrFunctionOrValue,FSharpMemberOrFunctionOrValue,FSharpMemberOrFunctionOrValue,FSharpMemberOrFunctionOrValue,FSharpMemberOrFunctionOrValue,unit>

Using the same example, here is the tooltip which uses the standard tootip text that VS/XS currently uses.

What I would like is a way of getting the parts that make up the type, much in the same was the CurriedParameterGroups and ReturnParameter give us access to these parts with a normal function.
This would allow for formatted tips that were easy to read, like this:

I think is all the information within an FsharpType to do this, its just a question of what the property would be called.  Use the same as MemberOrValueOrFunction:  CurriedParameterGroups/ReturnParameter, and whether the parts will still be FSharpParameter ?

One other idea is to have an overload of FSharpType.Format that allows a custom formatter to be used, the required type parts would be given to the function and would return a string.  This might be tricky as the parts will probably be TTypes etc from tastops, but I suppose they could be FSharpParameters or FSharpTypeParameters or something if we want to differentiate.


Removed duplicate table entry and fixed broken link

Summary
The website doesn't render HTML links inside markdown, see bottom of http://facebook.github.io/draft-js/docs/api-reference-data-conversion.html#convertfromhtml

We require contributors to sign our Contributor License Agreement, and yours has expired.

I literally signed it ten minutes ago, so maybe the CLA website is broken in some way?

Thanks for submitting this - it looks like other PRs have landed that fixed both these errors, sorry about that. https://github.com/facebook/draft-js/commit/3f424d1bdb2923a68a2e99672aeb2244a249bd7e is one. Closing this, but thanks and we'll work on looking at PRs faster going forward.


Skill Calculator: Option to disable members-only items

I think it would be good to add a toggle for members-only items within the skill calculator.
For a casual player like myself who is f2p (and doesn't have extensive knowledge of the game's items), it adds a fair bit of clutter to the skill calculator to have a lot of items that I'm unsure of whether they're actually skillable or not for me. I reckon it would be a nice qol change if there were a checkbox to enable/disable mem-only drops.
Thanks for your time.

I don't think this is worth adding since the skill calculator is not meant to explain what skilling methods are best, or how you should plan your skilling. It is only meant to calculate iterations of actions required to reach a certain goal. The wiki would be a better place to look at different skilling options.

Oh okay, thank you for the reply.


WIP supporting chain syntax

If you get a chance @jdalton or @d10 could you let me know if this will be sufficient.
TODOs

Identify chain functions used in the static analysis
Verify implementation

For chaining without lazy support I think this should be fine (though I don't write a lot of es6 I think the gist looks about right). How are you checking the chainability of a method.

I'm not I was going to bug you about that

I'm not I was going to bug you about that

Right now it's not driven by any config, just the order in which the methods are assigned. Those that chain are lumped together and those that don't are lumped together.
For simplicity (well ok I donno how simple that would be) if you are modifying code you could force all chains to .chain() then all to .value() at the end.

For the bump after next so like 3.8 I'll have the chaining logic moved to the chain module lodash/chain.

For simplicity (well ok I donno how simple that would be) if you are modifying code you could force all chains to .chain() then all to .value() at the end.

I don't think thats sufficent mainly because we're not modifying the users code so we won't know when the chain ends. Does cli maintain a list of the actions?

I suppose it might also be detected like this
isChainable = _.has(_()[method](), '__chain__');

Does cli maintain a list of the actions?

Right now it's not driven by any mapping, just the order in which the methods are assigned.

isChainable = _.has(_()[method](), '__chain__');

Well that works for all the ones that are chainable at any rate :) https://github.com/lodash/lodash/pull/1111

Any more hints/want to tackle this @jdalton - otherwise going to look at it tmw

function Foo() {}
Foo.prototype = _.create(_.prototype);
new Foo instanceof _; // true

Yeah but that wont handle all the lazy/ chain cases
On Apr 12, 2015 12:33 AM, "John-David Dalton"<EMAIL_ADDRESS>wrote:

function Foo() {}Foo.prototype = .create(.prototype);new Foo instanceof _; // true
—
Reply to this email directly or view it on GitHub
https://github.com/megawac/lodash-modularize/pull/2#issuecomment-91986843
.

Yeah but that wont handle all the lazy/ chain cases

Will it handle enough of the cases?

I was having difficulties having it handle the most basic cases without
import lodash from 'lodash/chain/lodash';;
import assign from 'lodash/object/assign';

function _(value) {
   if (!(this instanceof _)) {
     return new _(value);
   }
  return assign(this, lodash(value));
}

(ps thats from memory I'm on a different computer than the one I was attempting this on)
I was expecting it to just be just calling the base wrapper lodash.call(this, value)


Emoji

Hello,
I was using the 1.1.3 without issues, but today no more Emoji displayed. (Macbook pro M1, Monterey 12.5.1)

I updated to 1.1.7, but same display problem.
I can click on emoji, but they are just not displayed, even when writing the message. The emoji are correctly sent.

No problem with Google chat.

Let me know if I can help,
BR

I'm having the same issue on 1.1.7

Hello,
I've also the same issue. I'm currently investigating where is the problem.
If you've an idea, help is welcome ! 👍
Thanks


Database Seed

The seed command will create an admin user in the database
The email and password are passed with the command as arguments
Like below command, replace brackets with email and password.
npm run seed:db<EMAIL_ADDRESS>[password-******] // This is just an example.

@iamurmani Kindly review brother


Update ECS Telegraf Plugin info to "Amazon ECS"

Update ECS plugin title to "Amazon ECS" and all description information
URL for relevant page?
https://docs.influxdata.com/telegraf/v1.12/plugins/plugin-list/#ecs
What products and version are you using?
v1 Docs

Thank you, @sjwang90! Updated.


Allow UI introspection of test environments

If you make a room with Alice and Bob and send messages, it would be nice if we could provide a way for Element X or Element Web R to hook into one of these accounts so the test author can:

see if the test configuration makes sense
sanity check for any obvious errors that the test is not catching

For Element X this would just involve dumping the sqlite directory somewhere and then making the app read it. For Element Web R this would involve exposing the Chrome session of the client instance. The latter feels doable at this stage.

..except it need an entire element-web to be hosted, and that may not be storing the right things in the right places in localstorage/indexeddb. Maybe the EX route is easier then..?


Request: Set Fence Opacity

Is there a way to add setting the opacity of each fence?
What do you think?

The blur comes from Windows, but I can make the opacity adjustable


Added hover to events

Description
Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.
Fixes #134
Type of Change:
Delete irrelevant options.

Code
Quality Assurance
User Interface
Outreach
Documentation

How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
Checklist:
Delete irrelevant options.

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

@anubhavsingh16 Could you review and merge this?


Support for Flash Player v<IP_ADDRESS>1 - macOS

Here's the latest Flash Player release for macOS, version <IP_ADDRESS>1, released on Sep 10 2024 (GMT+8).
https://www.flash.cn/flashplayer/latest/install_flash_player_osx.dmg
https://www.flash.cn/flashplayer/latest/install_flash_player_osx_ppapi.dmg
If support for macOS version is not scheduled in the plan, please close this issue.

Support added:
https://github.com/darktohka/FlashPatch/releases/tag/v1.27.1
https://github.com/darktohka/clean-flash-builds/releases/tag/v1.46

Thank you!


Fix padding issues in 'Test job' view and track a branch page

Maybe a before/after screenshot? Not sure what changed (visually).


PG 10.x Foreign Key Constraints

Since moving to PG 10, FKs are not getting public. schema name cleaned up:
-ALTER TABLE ONLY dude_logs
-    ADD CONSTRAINT fk_rails_a1ad125ad2 FOREIGN KEY (dude_id) REFERENCES dudes(id);
+ALTER TABLE ONLY public.dude_logs
+    ADD CONSTRAINT fk_rails_a1ad125ad2 FOREIGN KEY (dude_id) REFERENCES public.dudes(id);

Another minor addition with search_path setting at top of file.
+SELECT pg_catalog.set_config('search_path', '', false);

I can certainly give a shot fixing this, but my regex-fu is admittedly a bit rusty, I might just cause us both more work!

Good catch, let me see if I can get that fixed today

@lfittl I actually believe this is happening with all previously cleaned public. instances, not just the FKs.

@cjolly Ah, so I've looked at this again and I don't think we should be cleaning those schema names up.
For additional context: The security change in 10.3 and 9.6.8 is whats causing public. to be added, to ensure any object referenced is the actual one in the public schema and not an injected object in another schema by a less privileged user.
Since that change is in the client tools the problem you are likely running into is that different developers in your team have different Postgres patch versions installed locally. First of all I think the best fix in practice is to have everyone upgrade to the latest patch release locally.
Second, if we make a change in this library, I would actually suggest we adjust it to always add public. (as well as the search path change), so we generate the same output even on old versions.
That is a bit more work though, which I personally can't invest in right now. Patches welcome of course :)

Aha. That make a lot of sense... as I couldn't really figure out where it was being stripped before in order to attempt a pull request. Makes sense now - cause it wasn't!
Not sure if you've seen it - but while investigating this I ran across https://github.com/rails/rails/pull/28154 - it looks like rails 5.2 has been making some attempts to normalize this file by removing all comment lines, too.
So, I guess we can call this Issue closed, as PG is very intentionally adding that schema namespace. I'll let you decide if you want to actually close it or if you want it open and visible for a while.
Thanks for taking a look!

Sounds good, I'll close this issue - thanks!

Would you be interested in a PR to optionally remove the public. prefixes?
if options[:remove_public_prefix] == true
  dump.gsub!(/\bpublic\.(\w+)/, '\1')
  dump.gsub!(/^.+set_config.+search_path.+$/, '')
end

@giovannibonetti Can you describe the use case for it?
As mentioned upthread, its actually a good thing when the objects in the schema are fully-qualified, as it avoids potential mistakes (and in some rare cases has security implications)


Documentation website?

Hi! I stumbled upon this repo after looking up tools for corefs, which ended up not working or were completely confusing. This one seems approachable. Is there a documentation website for coreferee?

As far as I am aware there is no documentation website for coreferee.
Are you looking for specific functionalities that are not in the README ?

I understand the basics of the tool. I wish I can know more

The documentation is all in the README.


Yaak trips Crowdstrike on Windows due to the app not being signed

What happened?
Attempting to run Yaak on a Crowdstrike secured Windows host will cause Crowdstrike to flag it and immediately kill the process.   Running the exe through Virus Total reveals that it's because Yaak (at least on windows) isn't signed.
Version
2024.9.1
What operating system are you on?
Windows
Relevant log output
No response

This is being tracked at https://feedback.yaak.app/p/sign-windows-release
signing Windows releases is a big pain as of recent, so I've been avoiding it as long as possible. I'm hoping to get it done in the next few months, though.

Cool, at least it won't get duplicated over here again then.

@LukeIGS do you have a way to bypass Crowdstrike to use it anyway?

I am not able to on my work machine, I plan to mess around with it using one of my personal machines.

K, I'm going to bump this in priority then, as I'm sure there are more people unable to use it


Glob patterns

This will solve a lot of pending issues related to high cpu usage, crashes and the need to exclude some folders. Especially the node_modules folder that, how state in some comments, should be excluded by default.
The PR creates an config option to exclude and one to only include a path to parse.
They can defined as Glob Patterns.
These are the issues that eventually can be closed:
#91
#62
maybe #64 ?
#47
#31
#27

Sorry for taking this long to reply, I could only find some time to review it on my weekend.

Pull request updated

@zignd @pungggi How can I exactly use this configuration? I tried all of the following:
"css-class-completion.includeGlobPattern": ".meteor/local/build/programs/web.browser/merged-stylesheets.css",
"html-css-class-completion.includeGlobPattern":
".meteor/local/build/programs/web.browser/merged-stylesheets.css",

"css-class-completion.includeGlobPattern": {
    "default": ".meteor/local/build/programs/web.browser/merged-stylesheets.css",
  }

"html-css-class-completion.includeGlobPattern": {
    "default": ".meteor/local/build/programs/web.browser/merged-stylesheets.css",
  }

But none work. In the code it's referred to as html-css-class-completion.includeGlobPattern:
https://github.com/zignd/HTML-CSS-Class-Completion/blob/043fe529cb770c2147fb0da62fff742a1c46784e/src/fetcher.ts#L6
https://github.com/zignd/HTML-CSS-Class-Completion/blob/043fe529cb770c2147fb0da62fff742a1c46784e/package.json#L35
But in the readme it's css-class-completion.includeGlobPattern:
https://github.com/zignd/HTML-CSS-Class-Completion#usage

Hi @vfonic, I have not released it yet. For some reason and I can't remember why. Anyway, thanks pointing out the error in the README.md, I will fix it and release a version containing this feature. If you check the README.md in the Marketplace, you will notice it doesn't have this section.
Regarding the usage, you need to use glob patterns, just like you do in the Search sidebar. You can also use multiple patterns and separate them by commas.

"html-css-class-completion.excludeGlobPattern": "**/node_modules/**,**/bower_components/**,src/vendor/**,src/view/**,src/plugin/**,src/assets/**",
  "html-css-class-completion.includeGlobPattern": "src/view/**/*.html,src/page/**/*.html,src/scss/**/*.scss,src/lib/**/*.css",

not work...


Cannot click with Wacom pen

I Use a Wacom table for accessibility reasons and can no longer click on anything in RocketChat 1.9.0 for OS X.
I suspect that it's an Electron issue as the Slack app had the same problem. Their latest released fixed this issue so maybe integrating the latest Electron will solve it for Rocket.Chat.Electron too.

Related to https://github.com/electron/electron/issues/7815

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


How to set track rounded corners only outside track.

I try to set rounded track.
I use isb_track_rounded_corners="true", but it set rounded inside seekbar too.

How to set round only start and end of seekbar.

Sorry，no support this.


Rename "appSecret" to "Teak API Key"

Needs to be renamed to make it consistent with the dashboard and to avoid confusing it with the Facebook appSecret.

Or update the description.


Version 2 doesn't work

@jedfoster example: https://jsfiddle.net/0679fux2/3/
At least in latest stable Firefox. Looks like the overflow: hidden is missing.
Previous version 1.0.0 works well.

Something changed in jQuery 3. Not sure what, but I'm dropping support for jQuery altogether. I haven't used it on a project in nearly five years. Readmore.js v3 should fix a lot of the jQuery-related issues that have come up.


Update developer install to modern package toml

compile_proto now a standalone script instead of a setup.py subcommand
setup.py replaced with pyproject.toml
compile scripts now look for pyproject.toml instead of setup.py to determine which folders are packages
remove bld.bat in nanover-core conda package -- not clear why this is the only one with such a script

Much of the way there but the package installation doesn't work properly (in conda only?)

The compile scripts weren't correct, but now seem to be working, now only conda packaging tests are failing I think.

Just need to fix mypy CI now..

I noticed that some tests are failing, The error occurs in the test test_remove_service  within the file python-libraries/nanover-essd/tests/test_essd_client_server.py. The assertion was checking that a ServiceHub instance was not in a set of ServiceHub instances, but it failed because it was found in the set.
@Ragzouken could you check before merging?

It's a recurring issue unrelated to this change.. it's irritatingly persistent https://github.com/IRL2/nanover-protocol/issues/154


Change URLs to fix tests

before: https://github.com/nf-core/sarek/runs/533843703
after: https://github.com/nf-core/sarek/runs/537050148
cf https://nfcore.slack.com/archives/CE6P95170/p1585137950001600

Works as expected: https://github.com/nf-core/sarek/runs/537090920
Thanks @ggabernet


Git fat pull has poor performance when dealing with large amount of binaries

Hi, this issue is related with #37, while has a different scenario.
I find that when dealing with a repository which contains large amount of binaries, the performance of
git fat pull becomes really bad.
We are migrating from clearcase to git these days and the git repository comes from a real cleacase vob, which is 600M and has 3420 binaries. I tested on a Ubuntu 14.04 machine with gigabytes network.
The test result of time git fat pull shows:
real 33m41.071s
user 21m6.557s
sys 11m13.053s

This is even slower than clearcase ~
Than I used cProfile and pstats to analysis the performance data, which shows the checkout() method is the hot spot, specifically these lines:
for digest, fname in self._orphan_files():
    sub.check_call(['git', 'checkout-index', '--index', '--force', fname])

Per my understanding, the checkout-index command does three things here:

find the specific file in the index
trigger the smudge filter
copy the actual content of binary file

Further test shows the first step takes most of the time, I think since the index is very large and contains a lot of files, git needs some time to find out a specific file from the index. When we have lots of orphan files, the checkout-index command need to be executed lots of times, which makes
the performance  really bad.
I come up with a rough solution —— move the checkout-index line out of loop and checkout all the files from the index instead:
 sub.check_call(['git', 'checkout-index', '--index', '--force', '--all'])

After this change, the performance improves a lot:
real 12m43.525s
user 8m12.750s
sys 4m22.912s

Will send a pull request and explain details later.
Any comments and suggestions of this issue are more than welcome.

I'm not really a maintainer on git-fat, but speaking for myself, I think this is a really nice improvement for performance.
Some thoughts I did have:
This requires the working copy to be clean to work, right? i.e. nothing unstaged in the working directory
The old behavior didn't require that, and you could git pull on an unclean working copy with no ill effects.
This can be nice on smaller repos when you're in the middle of some changes and forgot to "git pull", so it might be nice to have a command line switch to use the old behavior. Otherwise, you'd be forced to git stash, or checkin to a branch for a second which might take more time than the --all method saves on some repos.
Hopefully I'm understanding what you've done correctly, and what I'm saying makes sense.
Also, one might argue for the old behavior to be the default with the checkout-index --all behavior requiring a switch, because some folks may have some aliases/scripts/automation they've already written that will break if git fat pull starts requiring a clean WD. I'm not sure git fat is widely deployed enough to worry about that kind of thing, but just putting it out there..

Awesome, this could really help!  The one issue that I might see occuring is the racy git problem (which coincidently I just opened an issue on git-lfs for).
Basically, we have to be able to account for the case where the timestamp on the index is the same as the working copy.  We might be able to get away with calling checkout-index at the beginning of checkout() but we'd still have to check for orphans in the tree in case we have a case of the race.
See here for the critical lines of code.
Also @ajohnson23 brings up a good point which I didn't think about.  There may be cases where people don't want the whole index checked out, just the fat-files.  e.g. unstaged changes and switching branches is usually okay, but if we do checkout-index --all, I'm not sure it is okay.

Hi all,
Pull request 6a876f4 has been sent and thanks a lot for your comment!
Yes, checkout-index --all requires a clean work directory, otherwise those unstaged changes will lost. I have tried several solutions to handle this:
1.Stash the changes before checkout-index:
sub.check_call(['git', 'stash', '--keep-index'])
sub.check_call(['git', 'checkout-index', '--index', '--force', '--all'])
sub.check_call(['git', 'stash', 'pop'])

But this solution may ends up with a "merge confliction" status so finally I give it up .
2.Warn user when the work directory is dirty
This is current solution in the pull request, I feel it is not elegant enough, but due to my poor understanding of git I can't come up with a better one.
@ajohnson23 ,  add a command line switch is really a great idea, since most time the old behavior works well, only when dealing with large amount of binaries the new behavior makes sense, but we still need to find a solution to handle the dirty working directory.
@abraithwaite , I didn't touch those critical lines of checking orphans, to make sure not breaking the original behavior.
I only posted the test result of a medium-sized of a repository, when execute git fat pull against a large repository the old behavior would be extremely bad and hence unacceptable. So it would be awesome if we could improve the performance for these scenarios.

@ajohnson23 , add a command line switch is really a great idea, since most time the old behavior works well, only when dealing with large amount of binaries the new behavior makes sense, but we still need to find a solution to handle the dirty working directory.
@demonyangyue Personally I'm okay with keeping the "warn the user and exit" behavior for now, especially if the new behavior only happens when a command line switch is passed to git fat pull. Cleaning a working copy is something the user should probably handle their own way on their own terms.
If you're feeling like experimenting more, you could do something like (excuse the C-like pseudocode, I'm not a python scripter):
if( there are staged files ) {
        git commit -m "staged files"
}
if( there are unstaged files ) {
        git add -A
        git commit -m "unstaged files"
}
git checkout-index ...
if( there were staged files ) {
        git checkout --soft HEAD^
}
if( there were unstaged files ) {
        git checkout --mixed HEAD^
}

This is totally off the cuff, and I have no idea if it's a good idea, and it may not handle edge cases (or even non-edge cases) :)

Hi @ajohnson23 ,
Your suggestion about combining git commit and git reset to simulate stash looks really great, but I have some concerns about the corner case:

What if the program is in git checkout-index... line, and the user press "CTRL + C"
As you mentioned, the usre may want to handle their own way on the unstaged files, may not always git add -A,  for example  a user have done a lot of changes but want to abandon them before git fat pull :)

I totally agree with you that combine "warn the user and exit" with a command line switch should be better, I will revise the pull request if @abraithwaite also thinks this is the most suitable solution.

With git commit in this way nothing is truly ever lost -- it can be examined with "git reflog" and restored. And they can still abandon all of those unstaged changes/files even after the git fat pull (they'll still be unstaged).
The downside is, they'll also be in the local repository as an unreferenced commit :/ That won't go away until the next prune. So maybe that's what you're referring to. And good point on the Ctrl+C problem... you basically need to do everything in a transactional way to be safe, and while it's true they can restore things by looking at reflog later, it's a lot to expect of the user...
Anywho, I do think the git fat pull commandline switch + warn/exit is the best approach as you mentioned.
Thanks for noticing this little inefficiency, I think it will really help with pull performance. Even if it doesn't go into this repo I'll be patching my local copy :)

Btw, a really great use of this flag will be on automated build runners (continuous integration type stuff) where you never have an unclean working copy in the first place.


redefine mylog

To fix the error
/home/danisch/Bureau/NetSMF/src/GraphWalker.cc: In member function ‘void
GraphWalker::transformation()’:
/home/danisch/Bureau/NetSMF/src/GraphWalker.cc:59:30: error: operands to
?: have different types
‘GraphWalker::transformation()::<lambda(double)>’ and ‘GraphWalker::transformation()::<lambda(double)>’
auto mylog = FLAGS_log1p ? [&](double x) -> double {return log1p(x);} : [&](double x) -> double {return log(x);};
src/CMakeFiles/netsmf.dir/build.make:110: recipe for target 'src/CMakeFiles/netsmf.dir/GraphWalker.cc.o' failed
make[2]: *** [src/CMakeFiles/netsmf.dir/GraphWalker.cc.o] Error 1
CMakeFiles/Makefile2:87: recipe for target 'src/CMakeFiles/netsmf.dir/all' failed
make[1]: *** [src/CMakeFiles/netsmf.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

It could be slow, because it calls ?: a lot of times. An elegant refinement can be found here.


Placeholders should take into account answers on the path

What is the context of this PR?
Currently, placeholders do not take into account whether answers are on the path. Historically, this wasn't needed as it is not the placeholders' job to work that out, however, in v3 we added a placeholder transform first_non_empty_item which requires us to check that the answers are on the path.
How to review
See if the error is still occurs :

Launch mbs_0106

Click Start Survey

Submit No, I need to report for a different period

Enter a valid date range i.e 1 May 2016 to 20 May 2016

You should see the question has piped in your date range.

Go back to the first question and change your answer to Yes, I can report for this period

The next question will still pipe in your custom date range, but it should have piped in the date range from the metadata.

Check unit tests pass

Check type hinting comments

Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Answer dependencies: Placeholders should take into account answers on the path (3 SP)

This will need some rework but it will be better to discuss it instead of leaving comments here. However, some points to consider are:

Cross-sections dependency doesn't work.
The routing path is reevaluated multiple times which is very inefficient, it should only be evaluated once per section. Right now every answer id revaluates the path.
It doesn't take into account repeating sections. This should work within a repeat also.
first_non_empty_item should be unchanged. With the latest change, it won't work when you have more than 2 items.


Update Documentation for 1.0.0 Release

This PR just updates the installation and download links from from release candidate 2 (rc2) to the full 1.0.0 files.

Can one of the admins verify this patch?

I signed it!

We are merging back the changes in 1.0 branch to master at #7593, including the binaries URLs. Closing this one. Thanks @seanmarcia for noticing and sending the PR!


Access Violation

Hello and thanks for this wonderful project @scottoffen !
I started implementing in my project grapevine 4 since 5 was in rc. It was working quite fine but all my methods are async to I decided to move and try grapevine5.
I reimplemented routes as specified in the docs, added * as listening host through prefixes and all (I hope you can finish documentation because it is VERY scarce :-( ) but with grapevine5-rc7 as soon as I hit a route (for example a get route) the c# program containing the server immediately crashes with memory access violation.
has exited with code -1073741819 (0xc0000005) 'Access violation'.
Am I missing something? Thanks in advance!
EDIT: For what I can see the access violation crash is completely random, it happens on like 3/5 starts of the server both on get and post routes. Sometimes it is completely fine and works!
EDIT2: I found out rc6 is completely stable, so the problem must reside in some changes made in between, hope that can help ;)

What I'm asking for here is the minimum amount of code needed to illustrate the problem or demonstrate the behavior. Your example code leaves a lot of open questions that I have to guess about, but might be part of the problem. For example:

Why are you adding an additional listener prefix? Does the problem only present itself when you are listening on multiple prefixes? (the default prefix added by the builder is localhost:1234).

How are you adding the route to the router on the server? You don't include any class declaration with the RestResource attribute.

How are you generating the route? You don't include the RestRoute attribute on the method.
Do I need to create these models for Item and Result, both of which might have their own logic that you didn't include here, in order to duplicate the issue?
What does the static class Methods do? It looks like a repository of some kind, but are you hitting a database or a file or another service to get the Item?

Can you pair this down to a smaller example of this issue, because I am still not able to duplicate the issue.

I'm closing this issue because I cannot reproduce it and the original poster has not provided any additional details.


mvm_attributes.sp will not compile

I have all the dependencies installed, including StockSoup and smlib, but the compiler spits back this:
// E:\Servers\mvmserver\tf2\tf\addons\sourcemod\scripting\mvm_attributes.sp(159) : error 017: undefined symbol "SplitStringIter"
// E:\Servers\mvmserver\tf2\tf\addons\sourcemod\scripting\mvm_attributes.sp(159) : error 092: number of arguments does not match definition

You'll need to make sure that all the submodules are updated; the commit also changed the pinned version of stocksoup that the project depends on:
git submodule update --remote --checkout


Wallet connection issues on google chrome book

Repro steps:
on a chromebook
Navigate to terra.mirror.finance click connect wallet
install chrome wallet extension and setup wallet
Reload web site click connect wallet
extension loads and shows login page for wallet enter password and it shows wallet.
Web site doesn't register that wallet is connected
close extension page
wallet chrome extension page spams chromebook until you reboot it.
This is on a fresh install chrome book new out of box.

It sems I have a similar problem on my PC.
On Opera (Chrome based) the terra station extension wallet is not recognized when I want to connect to it. Well, it is detected by the web site of mirror finance but nothing happen when I click on it !
Could you help me please ?

I have the same problem with Opera. The wallet extension doesn't connect anywhere.


Feature request: input regex filter

It would be nice if you could filter the list of inputs with a regex.
Use case:
ffuf -w common.txt:FILE -w web-mutations.txt:MUT -w web-extensions.txt:EXT -u http://example.com/FILEMUTEXT

If you have a combination of multiple wordlists, the number of possible URLs the number of requests can easily sky rocket into the millions… 🚀
If would be great if you could apply a filter to the resulting URLs / requests to narrow down the list of possible URLs…

Hey @muhqu,
Do you have any examples?


Add NPC option for on player enters notable area

Currently I'm detecting if NPCs enter cuboids specified in a timed queue and was interested in seeing if adding NPCs as a valid entity to detect for could be implemented. For the same reason why an event like 'on player steps on block' wouldn't have compatibility for entities specifically, I would imagine that NPCs would be different for this kind of event because they are controllable rather than for the most part spontaneous

There's nothing equivalent to an 'NPC move event' so any event like this would have some inherent performance and clean-impl issues.

I'm going to consider this part of #1996


Use "gcloud config config-helper" to read the project ID from the Google Cloud SDK

Resolves #147

You definitely don't want commented out code in your commit

Trying to debug the system tests, I figured it out. Fix incoming.

@dhermes this should be ready for final review.


Remove $ for better terminal pasting

Description
Removing the $ sign on the yarn installation to avoid to remove it when we are copy/pasting into our terminal

If we want this convention then we should do it for all the readme files rather than just one.
I'm tempted to say a changeset isn't needed for this change - it can go out whenever we push a new release to these packages. We can skip adding a changeset to PR and add the Skip changelog label to the PR to make the check pass.

I've applied this fix to every README file in #2476.


Creating a new flutter project after setup for the first time using VsCode

I am trying to create a new flutter project using Vs code but it keeps on crashing, showing this error message below. Can someone help me on how to resolve it please, I am new with flutter and Vs code.
Oops; flutter has exited unexpectedly: "FileSystemException: Cannot copy file to 'C:\Users\Bryan\Documents\Java Source code,
practice\VsCodeprac\myproject\android\app\src\main\res\mipmap-hdpi\ic_launcher.png', path =
'C:\flutter_windows_1.22.4-stable\flutter\packages\flutter_tools\templates\app\android.tmpl\app\src\main\res\mipmap-hdpi\ic_launcher.png' (OS
Error: Access is denied.
, errno = 5)".

A crash report has been written to C:\Users\Bryan\Documents\Java Source code, practice\VsCodeprac\flutter_02.log.
This crash may already be reported. Check GitHub for similar crashes.
https://github.com/flutter/flutter/issues?q=is%3Aissue+FileSystemException%3A+Cannot+copy+file+to+%27C%3A%5CUsers%5CBryan%5CDocuments%5CJava+Source+code%2C+practice%5CVsCodeprac%5Cmyproject%5Candroid%5Capp%5Csrc%5Cmain%5Cres%5Cmipmap-hdpi%5Cic_launcher.png%27%2C+path+%3D+%27C%3A%5Cflutter_windows_1.22.4-stable%5Cflutter%5Cpackages%5Cflutter_tools%5Ctemplates%5Capp%5Candroid.tmpl%5Capp%5Csrc%5Cmain%5Cres%5Cmipmap-hdpi%5Cic_launcher.png%27+%28OS+Error%3A+Access+is+denied.%0D%0A%2C+errno+%3D+5%29

@Tawanny
This issue has been fixed and merged already. Please upgrade to latest master branch and try again to see if it works.

possible duplicate of https://github.com/flutter/flutter/issues/69116

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Generate image map in reference content

File A17 includes an image map.
Create imagemap content in mock reference file.
Create imagemap processor in HtmlToDita.

Started in #447

Is that link incorrect? It seems to go to Heroku and want me to log in?

Duh, sorry. Doing two jobs at once... Link updated.


How to set output_image_size when Eval

Hi
1、Can you explain what's different of the image_size of "content and style" when Train and Eval?
2、How to set output_image_size when Eval? (if your default setting is 1080,can you show me where you set in your code?)
3、Really thanks for your work

The --image-size --style-size determine the image sizes of content image and style image. They will resize the input images to the value in --image-size and --style-size parameters.
The output image size will be same as the input image size by default, if you are feeding in a really large image then I have added a command line parameter here , using which you can reduce the size of the output styled image, for eg setting --content-scale will produce an output image which is half the size of the input image.
😃

If I wanna use it to make a ios app like prisma in production enviroment,Can you give me some advices for reducing memory usage.I found pytorch's implement is better than tensorflow in fast-neural-style

I would suggest looking into using Caffe2 for that. You should be able to load the pytorch model in Caffe2 directly, you will have to convert weights to numpy and then load it in Caffe2. Then I think you can follow this tutorial to build an app for that.

When I try eval,I get a error(python2.7)
Dovan-Rmbp:fast-neural-style DOVAN$ time python neural_style/neural_style.py eval --content-image<EMAIL_ADDRESS>--model /Users/DOVAN/deeprely/fast-neural-style/saved-models/udnie.pth --output-image /Users/DOVAN/Desktop/ --cuda 0
Traceback (most recent call last):
File "neural_style/neural_style.py", line 210, in
main()
File "neural_style/neural_style.py", line 206, in main
stylize(args)
File "neural_style/neural_style.py", line 135, in stylize
content_image = Variable(utils.preprocess_batch(content_image), volatile=True)
File "/Users/DOVAN/deeprely/fast-neural-style/neural_style/utils.py", line 59, in preprocess_batch
(r, g, b) = torch.chunk(batch, 3)
ValueError: need more than 2 values to unpack
Can you tell me how to fix it

I just tested the implementation again on python 2.7 and it works. Can you try and install pytorch again in a clean environment using conda following the instructions from the pytorch site.

Actually I think it's an issue with loading .png images, I think it will work well for .jpg images. Similar issue was reported on the pytorch/examples version of this repo.
ref: https://github.com/pytorch/examples/issues/171

@abhiskk Hi,I have tried the jpg. But I still get this error:
Dovan-Rmbp:fast-neural-style DOVAN$ time python neural_style/neural_style.py eval --content-image<EMAIL_ADDRESS>--model /Users/DOVAN/deeprely/fast-neural-style/saved-models/udnie.pth --output-image /Users/DOVAN/Desktop/ --cuda 0
Traceback (most recent call last):
File "neural_style/neural_style.py", line 210, in
main()
File "neural_style/neural_style.py", line 206, in main
stylize(args)
File "neural_style/neural_style.py", line 135, in stylize
content_image = Variable(utils.preprocess_batch(content_image), volatile=True)
File "/Users/DOVAN/deeprely/fast-neural-style/neural_style/utils.py", line 59, in preprocess_batch
(r, g, b) = torch.chunk(batch, 3)
ValueError: need more than 2 values to unpack
I think this may be come from the Function parameters' error

@dovanchan what environment are you running this on, I just tested this implementation on python 2.7, on OSX and everything works well.

python2.7 on OSX 0.12.5   The same as you~

I am also used conda install pytorch ~

Are you sure you didn't edit anything, can you try re-cloning the repository and running it again, it should be working. Another option is to try it in python 3, if it fails in that also then something weird is happening. Also are you using --cuda 1 while running the stylizing code, pytorch's GPU version on OSX can misbehave.

This is my enviroment,I dont have change any setting,the same as you(python2.7 --cuda 0 ) I think may be because I am using the latest pytorch version?

yes that could be an issue, don't use the master version of pytorch right now, it's unstable I think because they are implementing numpy type indexing. Are you using this command to install pytorch:
conda install pytorch torchvision -c soumith  ?

Yes,I am using conda install pytorch torchvision -c soumith ~

Please follow the following steps accurately, use the default images in the repository for stylizing. I just followed the steps listed below one by one and was able to run it successfully.

Create new conda environment: conda create --name fnstest python=2.7
Activate environment: source activate fnstest
Install pytorch on OSX: conda install pytorch torchvision -c soumith
Clone repository: git clone https://github.com/abhiskk/fast-neural-style.git
Go inside the directory: cd fast-neural-style/
Download pre-trained models using the command: ./download_styling_models.sh
Run the command:
python neural_style/neural_style.py eval --content-image images/content-images/amber.jpg --model saved-models/mosaic.pth --output-image stylized_amber.jpg --cuda 0
Open image stylized_amber.jpg

I found the real problem now,
When I run the step that you offer,It will be successful;
But when I try a new content image,I got the error:
(fnstest) Dovan-Rmbp:fast-neural-style DOVAN$ time python neural_style/neural_style.py eval --content-image images/content-images/image1.jpg --model saved-models/mosaic.pth --output-image stylized_amber.jpg --cuda 0
Traceback (most recent call last):
  File "neural_style/neural_style.py", line 210, in <module>
    main()
  File "neural_style/neural_style.py", line 206, in main
    stylize(args)
  File "neural_style/neural_style.py", line 135, in stylize
    content_image = Variable(utils.preprocess_batch(content_image), volatile=True)
  File "/Users/DOVAN/fast-neural-style/neural_style/utils.py", line 59, in preprocess_batch
    (r, g, b) = torch.chunk(batch, 3)
ValueError: need more than 2 values to unpack

Here is the image I used:

The image that you shared is not in RGB format, you can convert it to RGB format using the following commands:
from PIL import Image
content_image = Image.open('/path/to/image')
content_rgb_image = content_image.convert('RGB')
content_rgb_image.save('/path/to/output/image')

Then you can run the neural style on the new image. I have also attached the udnie styled version of the image.
Apologies for the late reply.

Closing the issue, please comment if similar problems resurface.


Storageclusterpeer

add a new CR and controller to peer two block pools with the same name

used the command: operator-sdk create api --group ocs --version v1 --kind StorageClusterPeer --resource --controller to create the CR and controller
added logic for creating and deletion of storageClusterPeer

Depends on (in Order)

https://github.com/red-hat-storage/ocs-operator/pull/2480
https://github.com/red-hat-storage/ocs-operator/pull/2457
https://github.com/red-hat-storage/ocs-operator/pull/2493

Leave a note in the PR description saying which PR this is dependent on.

Testing:
Cluster 1(primary):
[rewantsoni ] date; oc get clusterversion -oyaml | grep clusterID; oc get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec .mirroring'; oc get storageclusterpeer
Wed Mar  6 11:38:12 IST 2024
    clusterID: 4293c939-42b2-4565-b22f-81f53df19844
{}
No resources found in openshift-storage namespace.

Cluster 2(secondary):
[rewantsoni ] date; oc get clusterversion -oyaml | grep clusterID; oc get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'; oc get cephrbdmirror
Wed Mar  6 11:40:37 IST 2024
    clusterID: a96546a7-5e86-4d6e-aded-b6664c3d8f3e
{}
No resources found in openshift-storage namespace.

After applying StorageClusterPeer:
Cluster 1(primary):
[rewantsoni ] date; oc get clusterversion -oyaml | grep clusterID; oc get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec .mirroring'; oc get storageclusterpeer
Wed Mar  6 11:41:48 IST 2024
    clusterID: 4293c939-42b2-4565-b22f-81f53df19844
enabled: true
mode: image
NAME                        AGE   PHASE
storageclusterpeer-sample   18s   Ready

Cluster 2(secondary):
[rewantsoni ] date; oc get clusterversion -oyaml | grep clusterID; oc get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'; oc get cephrbdmirror; oc get secret bootstrap-secret-e01e021da3ee4ed84ed95581cb7ae967
Wed Mar  6 11:43:16 IST 2024
    clusterID: a96546a7-5e86-4d6e-aded-b6664c3d8f3e
enabled: true
mode: image
peers:
  secretNames:
    - bootstrap-secret-e01e021da3ee4ed84ed95581cb7ae967
NAME         PHASE
rbd-mirror   Ready
NAME                                                TYPE     DATA   AGE
bootstrap-secret-e01e021da3ee4ed84ed95581cb7ae967   Opaque   2      99s

After deleting the StorageClusterpeer:
Cluster 1(primary):
[rewantsoni ] date; oc get clusterversion -oyaml | grep clusterID; oc get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec .mirroring'; oc get storageclusterpeer
Wed Mar  6 11:44:35 IST 2024
    clusterID: 4293c939-42b2-4565-b22f-81f53df19844
{}
No resources found in openshift-storage namespace.

Cluster 2(secondary):
[rewantsoni ] date; oc get clusterversion -oyaml | grep clusterID; oc get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'; oc get cephrbdmirror; oc get secret bootstrap-secret-e01e021da3ee4ed84ed95581cb7ae967
Wed Mar  6 11:45:27 IST 2024
    clusterID: a96546a7-5e86-4d6e-aded-b6664c3d8f3e
peers: {}
No resources found in openshift-storage namespace.
Error from server (NotFound): secrets "bootstrap-secret-e01e021da3ee4ed84ed95581cb7ae967" not found

/test ocs-operator-bundle-e2e-aws

Closing this in favour of https://github.com/red-hat-storage/ocs-operator/pull/2677


[Feature Request] Add support for enqueuing tbb::task into tbb::task_arena

Currently tbb::task_arena::enqueue supports "functors" only, and the only viable method for passing tbb::tasks into arena I see is something like this:
arena.enqueue( [task] () { tbb::task::spawn( *task ); } );

Would be really great to have some "native" support for tbb::task enqueuing in the tbb::task_arena.

Implemented in TBB 2019 U6.

Great, thanks!
Though since I'm unable to try it out any time soon I've got a question: does the implementation allow enqueuing from a thread with no task scheduler initialized?
I'm asking because the implementation looks quite similar to a hack I employed before, here's a snippet:
class task_arena_extensions
{
public:
    static void enqueue( tbb::task_arena& arena, tbb::task& task )
    {
        auto& friendlyArena = (friendly_task_arena&)arena;
        friendlyArena.initialize();
        friendlyArena.internal_enqueue( task, 0 );
    }

private:
    class friendly_task_arena : tbb::task_arena { friend class task_arena_extensions; };
};

And I had to replace it with arena.enqueue( [task] () { tbb::task::spawn( *task ); } ); since the hack didn't work for threads with no active task scheduler (due to either a crash in release or an assertion failure in debug, iirc here).

As of now, the implementation indeed requires the calling thread to have an active task scheduler. We will improve that in a following update. Thanks for your feedback!

Improved in TBB 2019 U8.

Great, thank you!


🌱 Begin cleanup after EdgePlacement downsync unification

Summary
This PR does some regularization and other cleanup following the recent regularization of the downsync API.
Related issue(s)
Fixes #

/cc @waltforme

/lgtm
/approve


Fix sortAlphabetically function

There is currently a method called sortAlphabetically that lives in /lib/sortAlphabetically.js.
It is incomplete and needs to be fixed!
Acceptance Criteria:

Running yarn test sortAlphabetically results in tests passing.
You have written a skeleton method for someone else to work on.
You have written tests surrounding your skeleton method.
Running yarn lint does not print any errors to the console!

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!

I'd like to give this one a go.

Awesome @micahduron !! I will apply the 'in progress' label. This buys you 24 hours. If you feel like you need more time, feel free to reach out and I will happily oblige. Thanks for contributing!

Thanks @micahduron


RFC Lists in JSONAlchemy records' config

Recently I encountered a problem with JSONAlchemy config (.cfg) files. I wanted to create a field which should be a list of strings inside the record. Here is the definition:
schema:
        {'emails': {'type': 'list', 'force': True, 'schema': {'type': 'string'}}}

When there is no key emails in the dictionary handled to Record.create method, I obtain:
>>> rec['emails']
[{'type': None}]

It seems that JSONAlchemy always understands schema as a base for a dictionary. Other than that, it works fine.
I can make it working by defining the field as:
schema:
        {'emails': {'type': 'list', 'force': True, 'items': {'type': 'string'}}}

But in this case I can't pass the validation, as Cerberus expects dictionaries inside the list.
https://cerberus.readthedocs.org/en/latest/#items-list
https://cerberus.readthedocs.org/en/latest/#schema-list
Please note that Cerberus' documentation is not complete.
What to do?

@MSusik What is the status of this issue?  The build you mentioned seems to be passing, and the line 1360 in the first log file shows no problem:

https://travis-ci.org/MSusik/invenio/jobs/42638809#L1360

Sorry, the correct one is:
https://travis-ci.org/MSusik/invenio/builds/42723050

Thanks.  Can be the problem be related to eval() and reserved keywords, as in #2593?

Unfortunately, it didn't fix the problem. Anyway, it shouldn't, as those problems touch different features.

Closed as issue was moved to the new repo.


Remove languages

[x] All languages removed, only es left.
[x] Routing removed.
[x] Menu entry removed.

@xphere ready to be merged?

Sorry, this should be WIP, some minor issues arose.

Ready to merge. Depends on https://github.com/elcodi/elcodi/pull/538 to be merged first.


Support Squash merges

SUMMARY
The following will support determining the PR number from a squash merge.  It currently depends on the default merge commit message syntax for a squash merge.
To be able to support none standard commit messages, some more logic would need to go in to use the API to query the PR by the commit SHA.
Addresses https://github.com/jefflinse/pr-semver-bump/issues/15
RELEASE NOTES

Support Squash merges for default squash merge message

LGTM


[WIP] Add HOOMD Engine

This PR adds basic support for the HOOMD-blue simulation engine. See issue #1055 for additional details.
To-do:

[ ] Write tests
[ ] Validate the example notebook (I have some trouble getting alanine dipeptide to change conformations at 500 kelvin, but 800 kelvin works alright. This may indicate problems in the atomistic force fields, which are not my area of expertise. I reached out to some collaborators who use HOOMD for atomistic simulations for help with this.)
[ ] Review comments from @dwhswenson in #1055 and see how to apply them here.

I'm not planning to finish this PR in the near future. However, if anyone is interested in picking it up and adding this feature, please feel free to use this as a starting point. I'm happy to answer questions / provide support, just ping me.
@dwhswenson / maintainers, feel free to close this if the PR rots for too long. I see some other engine PRs that are much older than this one -- and I apologize in advance for adding to that list.

Closing as stale.


Resolve #137

/cc @AlekseyMartynov

Calendar rewritten from scratch :sweat_smile:

Hooray? :)

Extracting a method removed one level of indentation, so the diff looks weird. Apart from that, there are not so much changes.

@MikhailTymchukDX
Calendar.js diff is quite massive. I can see some code style issues in it.

Sys.Extended.UI.CalendarSwitchViewMode (and other similar "enums") can be simplified to a plain object
Sys.Extended.UI.CalendarSwitchViewMode = {
    PreviousRange: 0,
    NextRange: 1,
    RangeZoom: 2
};

Wrong brace location for _isInYearsDateRange, _getRangeStartYear, _animateViewSwitch

Inconsistent line breaks around else

Really strange formatting here:
if(startYear > this._startDate.getFullYear()
        &&
        endYear < this._endDate.getFullYear())
    return true;

@AlekseyMartynov
2, 4 - corrected.
1 - is it OK that this will be the only extender that defines enums in that way?
3 - I checked every else section: everything is surrounded with CR LF. Do you mean extra empty lines between braces?

is it OK that this will be the only extender that defines enums in that way?

Why not. Good occasion to improve existing code along the way.

Do you mean extra empty lines between braces?

I meant
} else {

vs.
}
else {

Done.

enum definitions lack trailing semicolon

Fixed.

Ok, merge.


Select Not working on Laravel 5.4 validate

Here is may blade template

Return request

I use broswer-default class in select.

@dennist12 Can you elaborate your issue along with these screenshots?

The screenshot are the result of Laravel Request, the without the class browser-default and the last one with the class browser.

We can't provide help for specific frameworks that we don't officially support.

Thank you.

Using an identifier on the form tag and the attribute form on the select does fix the issue on Laravel 5.4.

        <form action="/market" method="POST" id="marketStore">
            <input type="hidden" name="_token" value="{{ csrf_token() }}">

                <input type="text" name="reference">

                <select name="third_id" form="marketStore">
                    <option value="1" selected>Amin</option>
                </select>

        </form>


Move from Travis to GitHub Actions

This is not ready yet, the reference tests fail on Windows (link) for some reason. It says it's trying to check file with names like C:\Users\RUNNER~1\AppData\Local\Temp\jl_HADs2B\dev\Basic\_git2_a06688, I have no idea where that basename is coming from.
GHA runs in about 10 minutes, whereas Travis takes about 18 (and it gets worse in the middle of  a work day).
Closes #211

I have no idea where that basename is coming from.

I think it's due to #211

So this is working now and #211 is fixed, but the failed nightly builds are marking this PR as failing despite continue-on-error: true. @SaschaMann do you know if there's a way for me to get the status passing with nightly failures?

@christopher-dG I'm not entirely sure what's going wrong, I would expect it to work. My guess would be that ${{ matrix.version == 'nightly' }} doesn't evaluate to true for some reason. Maybe it's "true"? Could you enable debug logs by setting the secret ACTIONS_STEP_DEBUG to true in this repo and then rerunning the build? I think you may have to paste the relevant logs for the step because I'm not sure if one can read debug logs without access to the repo.

Here's a log dump of a failing nightly run but I don't think there's anything relevant in there unfortunately.
One thing I did notice is that if I remove the continue-on-error line, then all the jobs get canceled as soon as one nightly job fails, whereas right now you can see the 1.0 and 1.x chugging away.

Maybe try this:
continue-on-error: matrix.version == 'nightly'

Or maybe this:
continue-on-error: ${{ matrix.version }} == 'nightly'

--
Instead of what you currently have, which is this:
continue-on-error: ${{ matrix.version == 'nightly' }}

but I don't think there's anything relevant in there unfortunately.

Usually it shows how those expressions are evaluated. The syntax itself is correct (if you do a code search, you can find plenty of workflow files where it's used in that way). Perhaps it needs to be at a step, not a job level, and you have to add it to each - uses: ... step? The example in the docs looks similar to what you have, though.

So it didn't work even if I just hardcoded continue-on-error: true. I'm wondering if it's a GitHub bug because this PR started out with some actual failing jobs which were not continue-on-error, so maybe those are what are preventing the status from being green. I'm just gonna merge it and if it still doesn't work I'll come up with something else.


decreased retrotransposon integration

PMID:26358720
decreased retrotransposon integration
synonym: decreased transposon integration involved in RNA-mediated transposition [GO:new]
xp GO:new from ticket https://github.com/geneontology/go-ontology/issues/13842

decreased retrotransposon integration FYPO:0006104
edit file: b99030e70d97daf5cf3f2093146f25c37c7b4d78
release: 767683a7bde6608b96c79e82ea54e5ebb1cefb23


Draft: :sparkles: System timezone on UNIX systems

This pull request adds support for system timezone on UNIX systems. It parses the TZif file under /etc/localtime to get the UTC offset at any given timestamp.
https://www.rfc-editor.org/rfc/rfc8536.html

[x] Basic implementation
[x] Correctly parse and use the TZ string from the footer in Version 3 TZif files see here
[x] Proper error handling
[ ] Tests

Codecov Report

Merging #3 (92d45e0) into main (985b2b2) will decrease coverage by 10.72%.
The diff coverage is 30.25%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
- Coverage   99.92%   89.20%   -10.72%
===========================================
  Files          18       25        +7
  Lines        3860     4364      +504
===========================================
+ Hits         3857     3893       +36
- Misses          3      471      +468

Files
Coverage Δ

src/cron.rs
99.10% <100.00%> (ø)

src/date.rs
100.00% <100.00%> (ø)

src/shared.rs
100.00% <ø> (ø)

src/time.rs
100.00% <100.00%> (ø)

src/util/date/manipulate.rs
100.00% <100.00%> (ø)

src/datetime.rs
99.70% <97.02%> (-0.30%)
:arrow_down:

src/main.rs
0.00% <0.00%> (ø)

src/util/offset.rs
82.75% <72.97%> (-17.25%)
:arrow_down:

src/local/data_block.rs
0.00% <0.00%> (ø)

src/util/date/convert.rs
92.10% <14.28%> (-7.90%)
:arrow_down:

... and 5 more


Implement workqueue

This PR adds a ServiceGroup workqueue.
Following the guidelines, all event handlers (SG and Pod for now) do is retrieve the appropriate SG key and add a job to the queue.
The worker then consumes these jobs, and performs the necessary operations.

@LiliC are your E2E test going to cover the functionality of the peer IP handling, e.g. that we correctly replace the IP of a dead pod?

@asymmetric My idea was we just need to test that a CM was updated after our Pod died, not sure we need to care about if it was the correct IP. Think that might be more unit tests, wdyt?

I tested this branch and it seems like writing IP is not working the same, compared to master.
When I create two SG one after another, the ConfigMaps contain the same IP.

Good catch! PTALA.

Are there any more blockers? If not, can this get a green-light?

I've created two issues: #65, #66.


Using col* css tags inside the elements other than div

Hi,
Although it's not a bug, I would like to know whether It's Good design or bad design to use col* tags other than Div.
If so, what's the difference between the actual Div vs Element layout.
If not, How do I stop that one may or may not be include that Css class in the element which is not a div.
For example,
I can use "col-md-12" inside "li". Is that allowed ?
Thanks,
Raja K

You can use most of our classes on just about any elements, though we encourage semantically neutral (<div>) elements or more purposeful elements like <section>, <article>, etc. Any of those works well. When you're mixing with other types of elements like list items, headings,  buttons, links, list items, and the like, you might run into unforeseen design issues or bugs.


Make Version implement Hashable.

There are quite a few scenarios where one might need a Dictionary<Version, …> and I happened to stumble across one of them today.

Muchas gracias, Marius! :bow:

Thank you, Vincent.


Implement tilde shortcut for Split

(This PR depends on #46, so #46 should be merged first.)
This PR implements a shorthand ~ for the newtype wrapper Split. So instead of cmd_unit!(Split("mkdir -p foo")); you could do cmd_unit!(~"mkdir -p foo");. As this is a shorthand for the Split constructor, it would only work for values of type &str.
This is a departure from the stance that cmd! and friends don't introduce any new syntax and only use their macro-powers to allow a variable number of arguments. However -- given that any other solution to whitespace splitting feels unsatisfying (as discussed in #46) -- I think this might be the least bad design.
One open question is, whether this negatively impacts code formatting.
Alternatively, I think we could further restrict the ~ shorthand syntax to only work in front of &str literals. But I don't really see how it's harmful to do:
let command = "echo foo";
cmd_unit!(~command);

Oh, and is there a better symbol to use than ~?

I actually think that needing to call split isn't that bad, and I've started to see the benefit of the macro not doing anything weird.
That being said, I think that ~ might be confusing, since at a glance, it looks like it might have something to do with home directory expansion.
I made this playground to check for all the symbols that could be used.
Of these, I lean towards @, since it's already used for array operations in Bash.

Yes, ~ can be confused with the home directory shortcut in shells. @ is better. Not sure whether there's other even better options. We could also consider something that's not just a prefix, like cmd!({"echo foo"});. Or cmd!(|"echo foo"|);.

One consequence of having this magic syntax, is that it only works at the top-level. So e.g. this doesn't work: cmd!([~"echo foo"]);. It's not clear to me whether having this work would ever be useful, but it'd be nice for consistency. It is easy to work around the issue with cmd!([Split("echo foo")]);, of course.


Copy/Paste results are out of order

Issue Type: Bug
When copying results to the query window, the pasted data is not in the same order as listed in the results.  Steps to reproduce:
declare @table table (num int)
declare @i int = 0
while @i<5
begin
insert into @table values (1), (2), (3)
set @i=@i+1
end
select num from @table order by num

Next, Copy the results from the grid and paste them into the query window or any text editor.  The pasted values are out of order.  When I do this, this is the pasted results:
1
1
3
3
3
3
3
1
1
1
2
2
2
2
2

I expect to see the pasted results to mimic the query results as shown below:
1
1
1
1
1
2
2
2
2
2
3
3
3
3
3

Similar copy/paste items: #7189, #2955, #1388, #26
Azure Data Studio version: azuredatastudio 1.13.0 (cacd481bff25c890e4130aee392569bae43b7e60, 2019-11-02T00:40:05.147Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (21.03GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

powershell
ms-
2019.9.0

profiler
Mic
0.9.0

@jjwillis It seems to be working fine for me. Could you go through the exact steps you're taking to copy/paste this? Are you selecting the entire column or selecting the cells manually?
@aaomidi Could you look into this?

This worked fine for me this morning after I read this.  Then I noticed a pending update, so I installed and now it is doing exactly as described above.  And I need my results to be in an order I expect.
Last week there were tabs at the end of each line.  This week, bad ordering.

@GUARD-TONYT - Could you also include the exact steps you're taking for the copy/paste? Especially with regards to how you're selecting the cells?

Open Azure Data Studio.  Now running:Version: 1.13.0 (user setup)
Commit: cacd481bff25c890e4130aee392569bae43b7e60
Date: 2019-11-02T00:40:05.147Z
VS Code: 1.38.0
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17134

Opened new Qry Window on a database.

Copy/Pasted T-SQL from above into qry window.  Clicked Run.

Grid appears as expected.

Clicked on Grid.  Then right-clicked, chose Select All, right-clicked again, Copy with Headers.

Opened Notepad.

Pasted Results.

The results appeared in incorrect order.  The results grid shows 5 of each number.  The pasted data is not in the correct order.
I then altered my query to show Alphabetical Data rather than numbers.  It too pasted in an order different than how the grid is displayed.  I can't seem find anything in common with how the order is displayed, but it consistently shows the pasted results out of order.

Try it with these results:
declare @table table (num int)
declare @i int = 1
while @i<=25
begin
insert into @table values (@i)
set @i=@i+1
end
select num from @table order by num

I installed the latest update to ADS.  Run the above statement and the results will display numbers from 1-25, one number on each row.  Here are several ways I can reproduce the results:

Click on the column header in the results to highlight the entire column, press Ctrl+C, click somewhere, like Excel or Notepad, and press Ctrl+V to paste.
Click on and cell in the results, press Ctrl+A to highlight everything, press Ctrl +C, click somehwere, like Excel or Notepad, and press Ctrl+V
Click on the space above the row numbers and to the let of the column heading to highlight all results.  Press Ctrl+C to copy, click somewhere, like Excel or Notepad, and press Ctrl+V to paste.
Repeated steps 1-3 using various combinations right click + copy and right click+paste.

I will note that there seems to be a pattern where row 1 and 2 are in order and row 3 is out of order.

I tried this again by selecting rows 1-10, it pasted correctly, then I tried this with rows 1-11 and it pasted wrong.  Then I selected rows 11-25 and it worked correctly.  Then I selected rows 10-25 and the 10th row appeared at the end and the rest were in correct order.
Then I increased my results to 100, selected row 11 and highlighted all until row 100 using shift + arrow, copied, and everything pasted correctly.  The issue seems to be around row 10.

I just tried it with this SQL to get numbers out of the equation:
declare @table table (phrase varchar(50))
insert into @table values ('A is for Apple'), ('B is for Bumble Bee'), ('C is for Charlie'), ('D is for Delta'), ('E is for Elephant'), ('F is for Fox Trot')
insert into @table values ('A is for Apple'), ('B is for Bumble Bee'), ('C is for Charlie'), ('D is for Delta'), ('E is for Elephant'), ('F is for Fox Trot')
select phrase from @table order by phrase

The results are in the order you would expect.  Once copied and pasted, they appear in an incorrect order.  It always appears the a 1st 2 are in the correct place, then afterward something is wrong.

I'm taking a look at this now.

This issue has been fixed in https://github.com/microsoft/azuredatastudio/pull/8072 and is currently in insiders. If you can, can you verify that ADS Insiders behaves properly?
This fix will be included in the next release.

@aaomidi I downloaded the ADS Insiders and the problem is corrected.  I tried all of the above samples and they now work as expected.  Thank you.

@Charles-Gagnon @aaomidi Verified that this bug has been corrected with the insiders build version.
Version: 1.14.0-insider (user setup)
Commit: a8eed6114b9b9b36fe2cd1902b690090bc547ca4
Date: 2019-11-04T08:59:32.766Z
VS Code: 1.38.0
Electron: 6.0.12
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.17763


Recursive aggregation of variables

Hi all, firstly, thanks for the amazing work with this package. A loots of features are really good to use and well documented. However, we still face the issue that with multiple levels in a variable, the manual aggregation of these becomes quite tedious.
Example:
Secondary Energy|Electricity|Wind|Onshore and Secondary Energy|Electricity|Wind|Offshore can be successfully aggregated with iDataFrame.aggregate(variable='Secondary Energy|Electricity|Wind', append=True)
However, when calling the aggregate function one level higher (e.g., iDataFrame.aggregate(variable='Secondary Energy|Electricity', append=True) without prior aggregation of the wind|onshore and wind|offshore variables to a combined wind variable, the values for onshore and offshore wind are omitted. Doing this aggregation with several variables and multiple levels each might lead to errors when presenting the aggregated variables.
Therefore, I think that an additional function handling a recursive/nested aggregation of variables would be really helpful. Such that you could call just aggregate(variable='Secondary Energy|*') und all levels below that variable would be subsequently aggregated.

Thanks @tburandt for this suggestion! This would definitely be really useful.
I'd suggest to add a keyword-argument recursive to the function, so that you can call it like
aggregate(variable='Secondary Energy|Electricity', recursive=True, append=True).
See the snippet below for a simple implementation of your request, which I did a while ago - it would be great if you could give it a try to implement this feature (and a related test) as an "out-of-the-box" feature.
for d in reversed(range(1, max(pyam.find_depth(df.data.variable)) + 1)):
    depth = pyam.find_depth(df.data.variable)
    var_list = df.data.variable[[i==d for i in depth]].unique()
    vars_up = pd.Series([pyam.reduce_hierarchy(i, -1) for i in var_list]).unique()
    for v in vars_up:
        df.aggregate(v, append=True)

Happy to assist if you take the lead!

Thanks for appreciating the usefulness :)
and yes I'm happy to work on this!

closing as implemented


Adds http response and requests logging capabilities

This feature was discussed in the issue 220. Current PR adds Logger protocol with three methods to log response, request and data, their default implementations via MoyaLogger and new MoyaProvider ivar called logger.  Also, I think we should add some info or instructions about logging to the Moya Documentation, although I don't know where to put it :disappointed: .

This looks great! Really good work. I've got a few really small pieces of feedback that I'll provide inline. Additionally:

Can you add a note to the changelog?
Documentation can go in the /docs directory. Add it to the Providers.md file (which describes the provider initializer).
The CI is failing because we really need to address #144. Could you update the MoyaProvider subclasses for ReactiveCocoa and RxSwift?

Let me know if I can help with anything – thanks again! :cake:

OK, that's all my feedback. Again, terrific work – thanks!

Looking good.
One concern that I have: The default logger uses multiple print statements to log a single request/response. I guess that multiple simultaneous requests/responses (on different threads) could corrupt the log output in a way that could be misleading to the user...
I would like to suggest to at least accumulate a the log output of each of the logNetwork... methods into a single String that gets printed at the very end of the method. This way, a single log is somewhat atomic.

Aye, that's a good idea @aschuch

@aschuch "I would like to suggest to at least accumulate a the log output" - very reasonable, thanks - will reimplement it to print everything  after we get either a response or error. Or may be we should use NSLog? Because NSLog() ensures that all strings passing through it are written in a thread safe manner to stderr. Or it will look not good in Swift code?

@ashfurrow  Thanks a lot for feedback! Yeah - there are lots of style errors, so I asked for review. Will fix it and add comments to protocol methods.

NSLog is a good question. Honestly I don't know. Anyone have any resources? Blog posts? Surely Mike Ash has something to say on the matter...

@ashfurrow "Could you update the MoyaProvider subclasses for ReactiveCocoa and RxSwift?". Sorry I'm not sure I understood your comment...
You mean only to add logger parameter to initializer in Reactive/Rx Moya extensions? Or add some FRP friendly implementation of the Logger? :smile:

@aschuch "Anyone have any resources? Blog posts?" - yes, we need some authoritative opinion here about the thread safety. Also I'm not sure if it is good from the code style viewpoint...

Yes, exactly – just the parameters :smile_cat:

I think it is reasonable to accumulate the request log output, then print the whole thing. Don't see any reason to use NSLog here. Also, I think its fine to log the request and the response separately (i.e. don't wait for a response to print request + response together).

As far as I can tell print doesn't write to the device log which NSLog does. It might be useful to debug things when you device is not connected. Since its extensible leaving it as just print is fine

Yeah, I think print is fine :smile: Don't sweat the small stuff, eh?
@AlexanderKaraberov Do you want this in before we release 3.0? It's a matter of adding this feature to an existing release, or forcing users to adopt 3.0 (with breaking changes) to use it.

Closing in favour of new work to be done on #238.

@ashfurrow Sorry for my slow response. So, I have to reimplement logger as a Moya Plugin?
Where can I find some guidelines how should I do this correctly?

@ashfurrow "Do you want this in before we release 3.0? It's a matter of adding this feature to an existing release, or forcing users to adopt 3.0 (with breaking changes) to use it." If I will understood new Moya Plugin system and reimplement logger I think we can include logger plugin in the 3.0 release.
P.S All the info about Plugins here: https://github.com/Moya/Moya/pull/238, right?

@ashfurrow Oh. Sorry Again, I'm sooo slow :smile:  (deleted previous comments),
As I found here. You have already merged it with Plugin reimplementation and code cleaning. Thanks for terrific clean-up work!
Are there smth. left for me in in the logger functionality? Or I can look for other features to implement :smiley:

I think the logger is well-covered, but we've got lots of open issues – feel free to dig in to any that look interesting to you!


Make use of docker build and push action

I think we can get caching if we make use of that action correctly

unneed now that this uses the release binary


Using FileKind, and creating result objects for non-Dart files

All analyzer/lib/src/dart/analysis/results.dart are Dart results. But we use ErrorsResultImpl to report errors in non-Dart files, like analysis_options.yaml, pubspec.yaml, etc. Which might very well be a good service for users, but the implementation is wrong. If a higher level tool (like DAS) needs a higher level abstraction of "an arbitrary analyzed file", it should wrap and split Dart analysis results vs. other file analysis results.

While I appreciate what you're saying, all of our user-facing tooling performs analysis on all of the files used in Dart development. If we want to have a parallel set of classes for the analysis of YAML files, that's fine, but it isn't just the analysis server that needs it, we also need this support to be available for plugins.

Maybe. I think we have some utilities from analyzer_plugin used in analysis_server. So, classes for YAML analysis results could live in analyzer_plugin, or even in analyzer - because we still have analyzer_cli that also analyses YAML files, and also constructs ErrorsResultImpl instances for them. We just should not pretend that these are Dart analysis results.


If ants' goroutine crash, will the whole software crash?

If ants' goroutine crash, will the whole software crash?
If so, how can we make it so that the software will still runs even if crash like erlang processes?

https://pkg.go.dev/github.com/panjf2000/ants/v2#WithPanicHandler

Possible to show example code for the usage of the function for reference? so as to get the potential of what we can do with this ants.
thx for the software.

https://github.com/panjf2000/ants/blob/94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0/ants_test.go#L238

ok thx!


GET /accounts/ID/media-accounts

GET /accounts/ID/media-accounts (with  virtual attribute "occurs") and filtering options like #47
#34

api will be removed in the next update


[Improvement](tablet clone) impr tablet sched speed and fix tablet sched fail too many times

Proposed changes
Issue Number: close #xxx

impr tablet sched speed;
fix tablet sched too many times and may block forever.
remove tablet sched ctx's dynamic priority;

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.57 seconds
stream load tsv:          503 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          30.1 seconds inserted 10000000 Rows, about 332K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.16 seconds
stream load tsv:          550 seconds loaded<PHONE_NUMBER>9 Bytes, about 129 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

run buildall

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.31 seconds
stream load tsv:          504 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         18 seconds loaded<PHONE_NUMBER> Bytes, about 124 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size:<PHONE_NUMBER>2 Bytes


Fix Remote AT encryption

Explicitly disable remote AT command encryption. As per the specs, it requires a secure session to be established with the destination, which we don't currently do.

Codecov Report

Merging #841 (d97c7d9) into dev (79cafd7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #841   +/-   ##
=======================================
  Coverage   83.16%   83.16%
=======================================
  Files         182      182
  Lines        4454     4454
=======================================
  Hits         3704     3704
  Misses        750      750

Impacted Files
Coverage Δ

zhaquirks/xbee/__init__.py
42.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79cafd7...d97c7d9. Read the comment docs.

Pull Request Test Coverage Report for Build 738396488

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.161%

Totals

Change from base Build 733037200:
0.0%

Covered Lines:
3704

Relevant Lines:
4454

💛  - Coveralls


No contract type found when using mainnet-fork

Environment information

ape and plugin versions:

$ ape --version
0.2.2

$ ape plugins list
  etherscan    0.2.0
  hardhat      0.2.0
  solidity     0.2.2
  alchemy      0.2.0

Python Version: 3.9.9 (pyenv)
OS: linux

What went wrong?
I am trying to initiate an erc20 contract like this:
contract = Contract('0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2')
But i get a warning: WARNING: No contract type found for 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
this problem occurs only if i am using a mainnet-fork. when connecting to mainnet everything's fine

it's working. thank you!!

released in https://github.com/ApeWorX/ape-etherscan/releases/tag/v0.2.1


problem

hello Ibrahim, I downloaded the application of GitHub and I modified the log directory, but when I exucute the app it shows me errors in java, so help me please :)

Hello,
it looks like you cannot connect to mysql . Plase check

spring.datasource.url=jdbc:mysql://localhost:3306/tododb?createDatabaseIfNotExist=true&amp;useUnicode=true&amp;characterEncoding=utf-8&amp;autoReconnect=true spring.datasource.username=root spring.datasource.password=root


fix files published to include all dist

Please publish a new version to npm, 0.0.2 is broken due to wrong "exports" in package.json
Tested this locally.


oci-distribution Push functionality

This PR includes the push function, which implements https://github.com/opencontainers/distribution-spec/blob/master/spec.md#push.
There are two tests that I didn't include as they involved a private registry and credentials:

Pushing a wasm to a registry with Basic authentication [PASS]
Pushing a non-wasm file (wascc provider archive) to a registry with Basic authentication [PASS]

I have also used a registry oci.registry.local, which I've pointed to a local unauthenticated docker registry, for my tests, and I'm open to modifying that depending on how this project aims to test this crate.
It involves a semver bump to 0.5.0 because the API for auth and pull changed to include the type of authentication, which is stored as the RegistryOperation enum.
Looking forward to your feedback! 🚀

FYI: https://github.com/deislabs/krustlet/pull/454

Started 1h 38m 0s ago

Oh, Windows...
Let's go ahead and merge this. Seems safe enough with the rest of the tests passing anyhoo.
Happy Holidays, @brooksmtownsend!


operator mariadb-operator (0.27.0)

Add operator mariadb-operator (0.27.0) to community operators

/merge possible

/merge possible


(PK) Create new proposal takes me to /login (S)

Reproduce:

Go to e.g. https://dao-dev.hypha.earth/#/testdao/
Click "New Proposal" in the sidebar

Expected behaviour:
I go to /proposals/create and can create a proposal
Experienced behaviour:
I go to /login

We no longer use PK login

@pugakn yes perfect, will close it now


vc_nonSyn failing to identify custom CNVs

Dear Maftools Team,
Similar to a previous post [https://github.com/PoisonAlien/maftools/issues/644], I've been looking at DepMap data and trying to run clinicalEnrichment specifically with a custom list of gene amplifications and deletions.
I've created both a custom CNV list and variant classification list to include Amp/Del and both seemed to load fine with the maf file:
my_vs = c("Frame_Shift_Del", "Frame_Shift_Ins", "Splice_Site", "Translation_Start_Site", "Nonsense_Mutation", "Nonstop_Mutation", "In_Frame_Del", "In_Frame_Ins", "Missense_Mutation", "Start_Codon_Del", "Stop_Codon_Ins",
"Amp", "Del")

 >depmap_maf = read.maf(maf = CCLE_mutations, rmFlags = TRUE, vc_nonSyn = my_vs, cnTable = Gene_CNV_status)
-Validating
--Non MAF specific values in Variant_Classification column:
  Start_Codon_Del
  Stop_Codon_Ins
-Removing 20 FLAG genes
-Silent variants: 402764
-Processing copy number data
-Summarizing
-Processing clinical data
--Missing clinical data
-Finished in 49.6s elapsed (25.9s cpu)

>depmap_maf
An object of class  MAF
                   ID summary         Mean Median
 1:        NCBI_Build      37           NA     NA
 2:            Center      NA           NA     NA
 3:           Samples    1763           NA     NA
 4:            nGenes   19460           NA     NA
 5:   Frame_Shift_Del   42836  24.29722065      7
 6:   Frame_Shift_Ins   25482  14.45377198      9
 7:      In_Frame_Del    7928   4.49688032      3
 8:      In_Frame_Ins    3220   1.82643222      1
 9: Missense_Mutation  701811<PHONE_NUMBER>5    214
10: Nonsense_Mutation   40169  22.78445831     11
11:  Nonstop_Mutation     958   0.54339195      0
12:       Splice_Site   43436  24.63754963     13
13:   Start_Codon_Del     147   0.08338060      0
14:    Stop_Codon_Ins     137   0.07770845      0
15:             total  866124<PHONE_NUMBER>5    260
16:               Amp     406   0.23028928      0
17:               Del   12739   7.22575156      5
18:         CNV_total   13145   7.45604084      5

I wanted to run clinicalEnrichment in specific cell lines looking only at CNVs in gene's of interest (not any other mutation) so I decided to subset the maf file to include only Amp/Del's. However, I was getting this error:
`>depmap_maf_sub = subsetMaf(maf = depmap_maf, tsb = cell_lines, genes = gene_list, query = "Variant_Classification == 'Amp'")

Error in `[.data.table`(vc.cast, , 2:ncol(vc.cast), with = FALSE) :
  Item 1 of j is 2 which is outside the column number range [1,ncol=1]`

It seemed that my custom variant classifications weren't being recognised so I exported the depmap_maf and re-read it to make sure everything did in fact read in correctly the first time:
`>depmap_maf_2 = read.maf(maf = depmap_maf_txt, rmFlags = TRUE, vc_nonSyn = my_vs)
-Validating
--Removed 11628 duplicated variants
--Non MAF specific values in Variant_Classification column:
  Start_Codon_Del
  Stop_Codon_Ins
  Amp
  Del
--Non MAF specific values in Variant_Type column:
  CNV
-Removing 20 FLAG genes
-Silent variants: 402764
-Summarizing
-Processing clinical data
--Missing clinical data
-Finished in 31.4s elapsed (22.6s cpu)`

However, similar to before, when I attempt to subset the maf I get the same error:
> depmap_maf_sub_2 = subsetMaf(maf = depmap_maf_2, tsb = cell_lines, genes = gene_list, query = "Variant_Classification == 'Amp'")

Error in `[.data.table`(vc.cast, , 2:ncol(vc.cast), with = FALSE) :
  Item 1 of j is 2 which is outside the column number range [1,ncol=1]

It would appear that my custom Variant_Classifications still aren't being recognised, causing the issue during the subsetting.
How do I create a list of Non MAF specific values if the vc_nonSyn option isn't working?
Thank you!

Hi,
Sorry for the late reply. Thanks for the issue, I have fixed the bug and it should work fine now.
I hope this helps, please feel to comment if needed.

Thanks @PoisonAlien! Will I need to clone the git version in order for the changes to be effective?

Hi,
You could install the package directly from GitHub.
BiocManager::install("PoisonAlien/maftools")


Fix error mitigation notebook

A problem with a heading was causing a plot to not work
Fixes #610

Summary
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.128%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3377

Relevant Lines:
5266

💛  - Coveralls


Linux instructions + Dockerfile [wip]

This is a dockerfile that will automate the creation of a Docker container with Orchard 2 and that will start "dotnet run" under Ubuntu 14.04 LTS. This is currently unstable due to the constant changes in the Core framework but it should work fine eventually.

Could we add something to the readme file too?

Readme or in the wiki ?

Here it is I updated the readme.md file. Please review :smile:

Good to get this in :) - even if we need to tweek it later


Feature Request: Portable executable

From a user side of view i would prefer to use a portable executable of xkcdpass on windows.
Python is normally not installed on windows computers or servers and may not be allowed in secure environments becaues it increases the systems attack surface.
A portable executable would also allow to install this tool via https://chocolatey.org/.
Would it be possible to provide a compiled exe as a regular release option?  I think this could be helpful for all kinds of windows users.

I could PR my docker setup if someone is interested :)