[$1000] IOS - Contact Method - keyboard open again for a second when user click on remove button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Action Performed:

Go to settings > profile > contact method
Click on new contact method
Enter any email and click on Add
Click on email
Open the keyboard if it's not open
click on remove button and confirm button

Expected Result:
Should not show keyboard after navigates to contact methods screen
Actual Result:
Show keyboard  for second after navigates to contact methods screen
Workaround:
None
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
**Reproducible in production?:**yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/c44035c2-c396-4995-bbda-fc1a593b9996
https://github.com/Expensify/App/assets/93399543/a1668af9-1474-4c00-ad51-8d88f48ec874
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686204508100569
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ce16ce28c89bd17e
Upwork Job ID:<PHONE_NUMBER>674507776
Last Price Increase: 2023-06-13

Reproduced on iPhone 13 with iOS 16.5, app version 1.3.26-4.
https://github.com/Expensify/App/assets/59587260/a34c5783-ec6f-4b4d-99c1-f2c1420abaa3

Proposal
Please Re-state that problem
keyboard opens again for a second when user click on remove button in contact method details page.
What is the root cause of that problem?
We are not dismissing the keyboard when the delete confirm modal opens. It just gets hidden due to the modal but after modal closes, it re-appears on the other screen.
What changes do you think we should make in order to solve the problem?
We should add onModalWilHide prop to ConfirmModal and BaseModal which will pass to ReactNativeModal.
This prop will help us schedule a callback just before the modal hides to dismiss the keyboard by calling Keyboard.dismiss()

In ContactMethodDetailsPage.js

In ConfirmModal.js

In BaseModal.js

We also have to import the Keyboard module from react-native in ContactMethodDetailsPage.js

I have chosen this approach as the best because if we try to hide the keyboard before navigating, it just doesn't work because it takes some time to hide the keyboard. Also, we cannot hide it onModalHide for the same reason therefore we have to use onModalWillHide at least in my testing. Moreover, I tried dismissing keyboard in the toggleDeleteModal() method but that causes the modal not to open again if we cancel the delete modal.
https://github.com/Expensify/App/assets/77237602/da395b0a-eea5-425d-9e12-8f8bca924ed6

@hungvu193 Your proposal is incorrect because when the remove button is clicked, the confirmDeleteAndHideModal method is executed
https://github.com/Expensify/App/blob/93957f0eb66a7e6998365b201a4c54ea2029ff60/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L185-L188
And the navigation to the previous page happens due to calling User.deleteContactMethod not in componentDidUpdate
https://github.com/Expensify/App/blob/93957f0eb66a7e6998365b201a4c54ea2029ff60/src/libs/actions/User.js#L285
And after testing, I can say that your solution has no effect on the problem.
https://github.com/Expensify/App/assets/77237602/d46f97b1-d028-460e-b222-8158ed977ab2

@tienifr Are you testing on a real device or simulator and if simulator then have you enabled keyboard with cmd + shift + k or just press cmd + k to bring it up every time?

Hello. Please check the screen recording and advise. My framerate on the iOS simulator is low but I've showcased my solution with slow animations and normal as well.
https://github.com/Expensify/App/assets/8914024/b4f2b2c3-f982-47f1-a6e0-ef92c7298062
After dismissing the modal, the keyboard shows back on the ContactMethodDetailsPage and then is animated out rather than showing up directly after the navigation animation is finished and on the Contact methods page.
Proposal
What changes do you think we should make in order to solve the problem?

In ContactMethodDetailsPage.js add

const dismissKeyboard = () => {
    return new Promise((resolve, reject) => {
      const frameListener = Keyboard.addListener('keyboardWillChangeFrame', () => {
        frameListener.remove();
        didListener.remove();
        resolve();
      });

      const didListener = Keyboard.addListener('keyboardDidHide', () => {
        frameListener.remove();
        didListener.remove();
        resolve();
      });

      Keyboard.dismiss();
    });
  };

In confirmDeleteAndHideModal() add:

this.toggleDeleteModal(false); // Hide the modal

dismissKeyboard().then(() => {
User.deleteContactMethod(this.getContactMethod(), this.props.loginList);
}

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01b69087c3abab2836

@sophiepintoraetz @cead22 Can you assign a new C+ here, there are multiple proposals. And I will not be able to get this soon.

Not overdue, @fedirjh please check out the proposals above!

@idevz1 your solution didn’t worked for me. Also from your screenshots, it seems you broke something, the contact was not removed.

Could you screen record my solution as well to see how it acts in your case? In my recordings I commented out the API call as I didn't want to send too many requests whilst testing and eventually get timed out by the server, so nothing was really broken.

@fedirjh Thank you for providing the screen recording. I noticed a couple of differences in your code vs my proposal.

In your version you edited the deleteContactMethod() whilst I edited confirmDeleteAndHideModal()
The order of the calls is reversed in your code. I call this.toggleDeleteModal(false); first

So just to confirm, I did no modifications to deleteContactMethod() and my confirmDeleteAndHideModal() looks like this:
 confirmDeleteAndHideModal() {
        this.toggleDeleteModal(false);
        dismissKeyboard().then(() => {
            User.deleteContactMethod(this.getContactMethod(), this.props.loginList);
        });
    }

we have proposals, @fedirjh is doing a good job of refining them so i don't think we need to adjust the bounty here.

@fedirjh - can we get a contributor assigned before the week is out? 🙏

Dipping out of this one since you've got it covered Sophie, let me know if you need any help!

@fedirjh thank you for your work on reviewing the proposals so far! Can we get one assigned?

@Nodebrute - appreciate some patience here - I've been OOO travelling. Additionally, the offer is in your inbox so you can help speed things along by requesting payment on that offer, rather than waiting on me - thanks!

@fedirjh - I'll release payment once you go through the PR checklist 🙏
@Nodebrute - payment released with timeline bonus.

Bumping @fedirjh

Payouts due:
Issue Reporter: $250 @gadhiyamanan - PAID
Contributor: $1500 @Nodebrute - PAID
Contributor+: $1500 @fedirjh - to request via NewDot
Eligible for 50% #urgency bonus? Y

Test https://github.com/Expensify/Expensify/issues/303405


Allow bar.increment(0) to update payload without advancing

Are you up for a PR for something like this? I'd love to update the message on the bar without advancing in situations where the total is less deterministic.

use update

I swear I didn't see that! O.o


Update latest details about external collaboration settings

Category

[x] Content fix
[ ] New article
[ ] Example checked item (delete this line)

Related issues

fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/2007

What's in this Pull Request?

Update the latest details about external collaboration settings in AD

@MikePlumleyMSFT, you might need to fix the metadata section for formatting

@MikePlumleyMSFT, you might need to fix the metadata section for formatting

Thanks for your inputs, I am new to this community, could you please guide me what meta data I need to update, I can see there is a meta data for this article on top of the page

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Copy review.

@JohanFreelancer9  - thanks for your inputs- I updated the changes as per your comments

@MikePlumleyMSFT - PR has been copy edited and is ready for final review. This is based on issue #2007.
Thank you.
cc: @kenwith

Primary nav should be via External Identities > External collaboration settings and screenshot should show this as in original. Also, extra details about each setting not needed. Updating via a separate PR.


Added owo english language

Added owo english language to the language selector as nadirabbas told me to.

Are you sure included the "OwO english" translation.json file?

Are you sure that you included the "OwO english" translation.json file?

it's in another pull request, I have no idea how github works, if it's a problem I'll try to change that

Can you link that PR?

Can you link that PR?

https://github.com/benawad/dogehouse/pull/1080

Here's the problem, your language selector code and the actual language are on two different branches (patch-3 for the translation, patch-4 for the selector). You need to commit the language selector code to patch-3 (so that everything is in the same place).

Here's the problem, your language selector code and the actual language are on two different branches (patch-3 for the translation, patch-4 for the selector). You need to commit the language selector code to patch-3 (so that everything is in the same place).

ok, I'll do that, is there a way to remove this request?

You can click the close PR button to close this PR.


Cannot install nvidia driver in docker on rc3.5

System information

OS Platform and Distribution (e.g., Linux Ubuntu 14.04): 14.04
Apollo installed from (source or binary): source
Apollo version (1.0, 1.5, 2.0, 2.5, 3.0): rc3.5
**Nvidia driver version : 410.72

I follow the document of "How to Run Perception Module on Your Local Computer". After I install nvidia driver as below, I get errors.
[How to install nvidia driver]
sudo ./NVIDIA-Linux-x86_64-410.72.run --no-opengl-files -a -s
[Error log]
ERROR: An NVIDIA kernel module 'nvidia-drm' appears to already be loaded in your kernel.  This may be because it is in use (for example, by an X server, a CUDA program, or the NVIDIA Persistence Daemon),
but this may also happen if your kernel was configured without support for module unloading.  Please be sure to exit any programs that may be using the GPU(s) before attempting to upgrade your
driver.  If no GPU-based programs are running, you know that your kernel supports module unloading, and you still receive this message, then an error may have occured that has corrupted an NVIDIA
kernel module's usage count, for which the simplest remedy is to reboot your computer.
ERROR: Installation has failed.  Please see the file '/var/log/nvidia-installer.log' for details.  You may find suggestions on fixing installation problems in the README available on the Linux driver
download page at www.nvidia.com.

After use below command to install nvidia driver, the problem is resolved.
sudo apt update
apt search nvidia-xxx
sudo apt install nvidia-xxx
nvidia-smi


FPS command

I wrote this really hastily and it probably doesn't work

your mother

your mother

unoriginal reply ngl
Fix the parsing error by resetting FPS_Counter before returning the FPS, and possibly add a min size or remove resizing altogether

when if you fix??

@Expertcoderz add the wontfix label ¯_(ツ)_/¯
@DimensionalFusion fix

No, I don't think I will.

Finally, closure at long last.


In-App Popup Notification Stopped Working on Mobile

Describe the bug
When I first started using the Reminder plugin, the overdues would trigger the popup notification in the mobile app with no issue. Semi-recently however they've mysteriously stopped triggering.
Expected Behavior
When a task is overdue, should issue an in-app popup notification.
Steps to reproduce

Install the plugin and add a reminder with an upcoming trigger date.
Open the app when a reminder is overdue.
Observe no popup notification issued (or like me, go weeks on end before realizing, hey didn't it used to issue these? 😵)

Regarding that last parenthetical, it took me a while to notice because they still issue just fine for me on Windows.
I tried checking for updates both for the base app (version 1.7.7) and by checking for plugin updates in the app. I also have the plugin enabled in the app. Checked for system updates, stopping and clearing app cache all that as well. Still doesn't do popups.
Operating system
Android

I am also not able to get notifications

After reading a few more threads, realized I was never opening the reminders tab in the app (left swipe). This started triggering the overdue items again. Hard to tell if there was more to it or not but maybe I did have some outdated app data reset when I opened the menu again Idk. 🤷♂


Feature request to print the layouts

This is a great tool and has helped me iterate on changes for my new minidox, so thank you.
It would be great if there was a way to print all the layouts to a document / system print. I'm currently print screening and cropping + copy pasting. :man_shrugging:

Interesting, do you use the VScode extension? Printing from that is probably out of scope but for me the web page version of this already works surprisingly well for printing:
http://ciantic.github.io/keymapceditor/#ergodox_ez|us|example
Shows me this in Chrome printing mode:

And you can if you for some reason want to turn on the background too.

Thanks for the prompt reply.
I did try the vs code extension, but you have to print out all the layers separately, and if you want them on a single cheat sheet, you'll have to somehow merge them. Granted, it's not a big job but it slows down iterations. I was hoping that there was some typescript foo to assemble the layouts on the same page. I had a quick look but my typescript is not up to scratch and wasn't sure how to even set up a dev env for it...
I realised providing this example might be helpful: see the "Print Layout" link in the Ergodox EZ configurator: https://configure.ergodox-ez.com/ergodox-ez/layouts/default/latest/0

Yes, I will try to do that for the web page version.
(I probably won't implement this for VSCode extension, because print preview in it is not probably easy to do.)

I also noticed that the drop down of keyboards (first dropdown) is "semi-sorted" alphabetically. I suspect whoever put it together started with an alphabetic but then other keys were added after that. It would be great if this was sorted -- I've scrolled up and down that list a couple of time now. Even better if I could just start typing at the top - sorry feature creep request!

Oh, maybe I should've entered a new issue for that, let me know -- happy to do that.

Yup, this is very rough around the edges. Feel free to add new issues here if you find, my projects languishes until I see a need to come back to them. With this I have to come back to it periodically because VS Code updates and what not.


Service Offering vs Service

In our Terminology section we define the follow terms:

Service: A managed software offering that can be used by an Application. Typically, Services will expose some API that can be invoked to perform some action. However, there can also be non-interactive Services that can perform the desired actions without direct prompting from the Application.
Service Offering: The advertisement of a service that a Service Broker supports.

To me that means that the Service Offering is the thing in the catalog with an ID and the Service is what logical function is provided to the application.
However throughout the spec, we use service to mean service offering. For example, ID of the service from the catalog. If present, MUST be a non-empty string.
I guess this is a result of the catalog having a services array. We have a Service Object described as a Schema of service objects but the metadata object is described as An opaque object of metadata for a Service Offering.
These two terms are pretty confusing to new readers. Could we clarify things? Happy to attempt a PR.

+1 to a PR


Update-DocsMsMetadata.ps1 should only update metadata if released package is later version

Only write the metadata JSON file if the releasing version is later than the released version (i.e. check the version in the metadata.json file for the expected moniker).

If metadata JSON file already exists for moniker:

If releasing version is later than the metadata JSON file version: update
Else: do nothing

Else: create the metadata JSON file for the releasing version

CC @weshaggard, @kurtzeborn
Just so we're very clear, this a Learn docs problem as GitHub.IO has docs for each and every released version.
This is not the right course of action and I'm not even sure there is one. Here's the problem; There are times when a second version of a library is in development, with a higher version than the currently recommended one. This doesn't mean that the second library's version is Beta and the first's version is always GA, as there are, and have been, minor version Betas released for the first. I can speak for Java in that Core, Identity and KeyVault libraries are just a few of the libraries that have done this.
Right now, Learn docs just kind of flip/flop between these versions depending on what was last released before the respective language repository's docs main is merged into live. Changing this script to only ever use the highest version is not the right move as we don't know which version of the library should be documented on Learn. Further, even if we added a mechanism for someone to choose at release time, that would require people paying attention which is also not something I'd bank on. I suggest closing this out as "not planned" and leaving things as-is.

The scenario that this targets is one of hotfix releases. Hypothetically:

Release azure-storage-blob at v1.2.3 -- Docs site shows docs at v1.2.3
Release azure-storage-blob with new features at v1.3.0 -- Docs site shows docs at v1.3.0
Major issue discovered in v1.2.3, release hotfix v1.2.4 -- Docs site now shows v1.2.4 instead of v1.3.0

In step 3 the docs site now shows documentation for v1.2.4 instead of docs for v1.3.0 (new features from step 2 are now missing).
This would be done on a per-moniker basis so a new beta package which supersedes a released GA package would not overwrite documentation.
After chatting w/ @JimSuplizio I agree that this should just be documented because it's possible for a new beta version of a package silently superseding all other published versions even if it's abandoned.
The real fix here is to have all versions of docs available on a docs site (i.e. github io docs).


Update sbt-bintray to 0.6.0

Updates org.foundweekends:sbt-bintray from 0.5.6 to 0.6.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.foundweekends", artifactId = "sbt-bintray" } ]

labels: sbt-plugin-update, semver-minor

Pull Request Test Coverage Report for Build 90

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.293%

Totals

Change from base Build 89:
0.0%

Covered Lines:
28

Relevant Lines:
41

💛  - Coveralls


[BUG] Context-menu(by right mouse click) is displayed when overlaying widget(by stack) is touched on iOS

Describe the bug
When the player widget is covered by other widget with Stack, touch event is not blocked by covering widget and unintended context menu(Account/ Loop/ Copy video URL/...) is popped up only in iOS
To Reproduce
Stack(
  fit: StackFit.expand,
  children: [
    player,
    Expanded(
        child: Container(
            color: Colors.yellow.withOpacity(0.3),
            child: Center(
              child: TextButton(
                  onPressed: () => print('button pressed'),
                  child: const Text('Overlay Button',
                      style: TextStyle(fontSize: 20.0))),
            )))
  ],
)

Container with TextButton blocks touch event and Player widget does not receive touch event correctly on Android.
But when tested on iOS, player receives a touch event and unintended menu pop up is displayed.
On Android, touch event is blocked by the Container

On iOS, touch event is delivered to the player and unintended menu popup is displayed

When I click the overlay button,
Android: nothing happens on player
iOS: player play/paused and menu popped.
Technical Details:

OS: iOS 15.5
Version [e.g. 22]
youtube_player_iframe: 3.0.4

Is there an update on this issue?
Maybe a resource that could help, scraping through the youtube API documentation made me realize that this context menu is not intended to be disabled.
I have tried using webviewx plugin to utilize their WebViewAware widget but even that has not helped me yet.

@nicejhkim Try updating the plugin to the latest version, this issue can be fixed by adding pointer-events to none for the body tag in CSS.
Check out the raw_youtube_player.dart file in this project and search for pointer-events property.

@nicejhkim Did you find a solution? I have the same problem on ios.

I couldn't find any solution for this issue. When I wrap the player with IgnorePointer() events are not reached to the player, but context menu is still popped up only on iOS.
I have tested on iOS 13, iOS 16, youtube_player_iframe 3.1.0 (with webview_flutter) and 2.3.0(with inappwebview) and get the same result.
I was going to make  custom controls on video screen which replace the original controls but I gave up on iOS.
Please let me know if anyone have a clue for this issue. : )

Going over to raw_youtube_player.dart and setting pointer-events to none worked for me.

@Ronak99
That works for me! Thanks!

dsf

@qbait
I disabled showControls option and made custom controls over the video.
Every control but Settings and Captions were possible.


Prepare the wasm crate for publishing on npm

Based on some discussion on the gitter.

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   41.15%   41.15%
=======================================
  Files          74       74
  Lines       16921    16921
  Branches     4471     4471
=======================================
  Hits         6964     6964
  Misses       7929     7929
  Partials     2028     2028

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a264017...55cc653. Read the comment docs.


Stage yeet propagate error to executor

Objective

Fix panic_when_hierachy_cycle test hanging
The problem is that the scope only awaits one task at a time in get_results. In stageless this task is the multithreaded executor. That tasks hangs when a system panics and cannot make anymore progress. This wasn't a problem before because the executor was spawned after all the system tasks had been spawned. But in stageless the executor is spawned before all the system tasks are spawned.

Solution

We can catch unwind on each system and close the finish channel if one panics. This then causes the receiver end of the finish channel to panic too.
this might have a small perf impact, but when running many_foxes it seems to be within the noise. So less than 40us.

Other possible solutions

It might be possible to fairly poll all the tasks in get_results in the scope. If we could do that then the scope could panic whenever one of tasks panics. It would require a data structure that we could both poll the futures through a shared ref and also push to it. I tried FuturesUnordered, but it requires an exclusive ref to poll it.
The catch unwind could be moved onto when we create the tasks for scope instead. We would then need something like a oneshot async channel to inform get_results if a task panics.

Closing in favor of merging https://github.com/bevyengine/bevy/pull/7448 in, and then using that.


remove ASN category in /#monitoring/hosts/19/services/create

I think putting the ASN check into the network category will suffice

Done.


Fix drag start by delaying side effects. #21.

Hmm, I'm getting some failing tests on this.  I had some failing previously because of a bug in phantom JS, but these are new fails. I'll have to make sure these pass first.

Not sure if I like all of the fallout I get from delaying the drag start actions.  I have to add a bunch of waits to my tests and I'm also getting errors in the console because of it.
Can you explain what kind of errors you were getting that this fix helped with?  Maybe there is another way to fix them.

@dgavey Oops, I never followed up here. See https://github.com/mharris717/ember-drag-drop/issues/21#issuecomment-171491797.


Fix issue #1258

Hello @mholt ,
this PR should fix issue #1258:
2016/11/24 16:10:41 [INFO] Obtaining new certificate for 1.caddy.domain.com
2016/11/24 16:10:42 [INFO] acme: Registering account for
2016/11/24 16:10:42 [INFO][1.caddy.domain.com] acme: Obtaining bundled SAN certificate
2016/11/24 16:10:43 [INFO][1.caddy.domain.com] acme: Trying to solve TLS-SNI-01
2016/11/24 16:10:45 [INFO][1.caddy.domain.com] The server validated our request
2016/11/24 16:10:45 [INFO][1.caddy.domain.com] acme: Validations succeeded; requesting certificates
2016/11/24 16:10:46 [INFO] acme: Requesting issuer cert from https://acme-staging.api.letsencrypt.org/acme/issuer-cert
2016/11/24 16:10:46 [INFO][1.caddy.domain.com] Server responded with a certificate.
2016/11/24 16:10:46 [WARNING] Stapling OCSP: no OCSP stapling for [1.caddy.domain.com]: ocsp: error from server: unauthorized
2016/11/24 16:10:53 [INFO] Obtaining new certificate for 2.caddy.domain.com
2016/11/24 16:10:53 [INFO][2.caddy.domain.com] acme: Obtaining bundled SAN certificate
2016/11/24 16:10:53 [INFO][2.caddy.domain.com] acme: Could not find solver for: dns-01
2016/11/24 16:10:53 [INFO][2.caddy.domain.com] acme: Trying to solve HTTP-01
2016/11/24 16:10:54 [INFO][2.caddy.domain.com] Served key authentication
2016/11/24 16:10:55 [INFO][2.caddy.domain.com] The server validated our request
2016/11/24 16:10:55 [INFO][2.caddy.domain.com] acme: Validations succeeded; requesting certificates
2016/11/24 16:10:56 [INFO] acme: Requesting issuer cert from https://acme-staging.api.letsencrypt.org/acme/issuer-cert
2016/11/24 16:10:56 [INFO][2.caddy.domain.com] Server responded with a certificate.
2016/11/24 16:10:56 [WARNING] Stapling OCSP: no OCSP stapling for [2.caddy.domain.com]: ocsp: error from server: unauthorized
2016/11/24 16:11:04 [INFO] Obtaining new certificate for 3.caddy.domain.com
2016/11/24 16:11:04 [INFO][3.caddy.domain.com] acme: Obtaining bundled SAN certificate
2016/11/24 16:11:04 [INFO][3.caddy.domain.com] acme: Trying to solve TLS-SNI-01
2016/11/24 16:11:06 [INFO][3.caddy.domain.com] The server validated our request
2016/11/24 16:11:06 [INFO][3.caddy.domain.com] acme: Validations succeeded; requesting certificates
2016/11/24 16:11:07 [INFO] acme: Requesting issuer cert from https://acme-staging.api.letsencrypt.org/acme/issuer-cert
2016/11/24 16:11:07 [INFO][3.caddy.domain.com] Server responded with a certificate.
2016/11/24 16:11:07 [WARNING] Stapling OCSP: no OCSP stapling for [3.caddy.domain.com]: ocsp: error from server: unauthorized
2016/11/24 16:11:40 [INFO] Obtaining new certificate for 4.caddy.domain.com
2016/11/24 16:11:40 [INFO][4.caddy.domain.com] acme: Obtaining bundled SAN certificate
2016/11/24 16:11:40 [INFO][4.caddy.domain.com] acme: Trying to solve HTTP-01
2016/11/24 16:11:41 [INFO][4.caddy.domain.com] Served key authentication
2016/11/24 16:11:42 [INFO][4.caddy.domain.com] The server validated our request
2016/11/24 16:11:42 [INFO][4.caddy.domain.com] acme: Validations succeeded; requesting certificates
2016/11/24 16:11:42 [INFO] acme: Requesting issuer cert from https://acme-staging.api.letsencrypt.org/acme/issuer-cert
2016/11/24 16:11:42 [INFO][4.caddy.domain.com] Server responded with a certificate.

Now better @mholt ?

Now that's more interesting. Why does this work? (And can you write a test for it?) What was causing the problem?

Now that's more interesting. Why does this work? (And can you write a test for it?) What was causing the problem?

https://github.com/mholt/caddy/blob/master/caddy.go#L229-#L231
[...] as listeners tend to report
// [::]:80, for example, when the matching address that
// created the listener might be simply :80.

--- FAIL: TestListenerAddrEqual (0.00s)
        caddy_test.go:82: Test 0 (<IP_ADDRESS>:2016 == [::]:2016): expected true but was false
FAIL
FAIL    github.com/mholt/caddy  0.026s

Everything okay @mholt? -- Is there something I need to change?

I'll take a look after the holiday

I'll take a look after the holiday

Sure, enjoy it :)

(I should figure out a way to add test coverage to CI) Do these tests cover every branch of the function?

Hello @mholt ,
no! It does not cover
if err != nil { //covered
                return lnAddr == addr // not covered
} //covered

if lnAddr == net.JoinHostPort("<IP_ADDRESS>", port) {  //covered
                return true // not covered
} //covered

I will create a new PR, you where a little bit to fast 😄


Fix a minor potential issue when rebatching for GpuArrowEvalPythonExec

There is a chance that the row number of the combined batches is
just a multiple of batch size, which results in returning this huge
ColumnBatch directly.
-    if (rc % targetRoundoff == 0 || rc < targetRoundoff) {
+    if (rc <= targetRoundoff) {
       return combined
     }

build

build

build


Zvt Checksum

Hi, i try currently to calculate the zvt protocol checksum. In the documentation i found the info the checksum is CRC-XModem but i found no config that work. I also try  public static Definition XModem but i think the TruncatedPolynomial is invalid.
Do you have any idea what the problem is? I would like to build the checksum calculation on a tested library.
Source: https://www.terminalhersteller.de/downloads/PA00P016_04_en.pdf -> 3.3 CRC-Calculation
The CRC-checksum is calculated using the CRC-XModem with polynomial x16+ x15+ x10+ x3.
All characters from the APDU plus ETX are used in the checksum calculation (see chapter Block-Structure)

This is my unittest
var data = new byte[] { 0x06, 0x00, 0x04, 0x00, 0x00, 0x00, 0x30, 0x03 };

var crc16 = new CRC16(new CRC16.Definition
{
	 TruncatedPolynomial = 0x1189
});
var crc16Checksum = crc16.ComputeHash(data);

var expected = new byte[] { 0x24, 0x89 };
Assert.IsTrue(expected.SequenceEqual(crc16Checksum));

This very simple logic gives the correct result
public static class CRCChecksum
{
    /// <summary>
    /// Returns [Lowbyte][highbyte]
    /// </summary>
    /// <param name="data"></param>
    /// <returns></returns>
    public static byte[] CalculateCRCBytes(byte[] data)
    {
        ushort crc = CalculateCRC(data);

        return BitConverter.GetBytes(crc);
    }

    public static ushort CalculateCRC(byte[] data)
    {
        ushort crc = 0;

        foreach (byte b in data)
            CRC(b, ref crc);

        return crc;
    }

    private static void CRC(byte b, ref ushort crc)
    {
        byte c1 = 0;
        for (int i = 0; i < 8; i++, b >>= 1)
        {
            c1 = (byte)(b ^ (byte)crc);
            crc >>= 1;
            if ((c1 & 1) != 0)
                crc ^= 0x8408;
        }
    }
}

Got it. The documentation is actually wrong. It's not the CRC16 that is used in XModem. It's the CRC16 that is used in Kermit. These two are very similar and often confused.
This will get you what you need:
var crc16 = new CRC16(CRC16.Definition.Ccitt);
var crc16Checksum = calculator.ComputeHash(data);


RBSE - ModSetting for organ rejection not respected

Describe the bug
QEE currently applies its own flavor of Organ Rejection when Rah's Bionics and Surgery Expansion (RBSE) is also enabled. Recently, RBSE was updated with a new ModSetting that allows players to toggle this on/off. QEE doesn't use this toggle, so it can result in confusing behavior for the player where some organs have rejection and others do not.
Expected behavior
One of two things:
a) Implement my own Organ Rejection ModSetting
or
b) Check the ModSetting of RBSE before applying the hedfiff
B seems the most preferable here.

Fixed in development branch. Changes will be applied next patch.


SqueezeNet pretrained model download link not working

The link http://data.dmlc.ml/mxnet/models/imagenet/squeezenet/squeezenet_v1.0.tar.gz for squeezenet model is not working. Please upload the squeezenet model

There's no more tarball files. The weights and json files are available as
http://data.dmlc.ml/mxnet/models/imagenet/squeezenet/squeezenet_v1.0-0000.params
http://data.dmlc.ml/mxnet/models/imagenet/squeezenet/squeezenet_v1.0-symbol.json

Thanks zhreshold.. got the model and json file.. Closing the issue


Conform Cargo's bench arguments

In cargo,
cargo bench

will invoke the benchmark with parameter --bench, indicating to run a benchmark, while
cargo test --benches

will invoke the benchmark without any parameters, indicating for a "test mode" (iterate 1 time).
Since criterion is a replacement for the harness, I think this behaviour should be supported, so that users can treat it equally just like "harness=true" benchmarks. For example, in our project, we run cargo test && cargo test --benches every time in CI because sometimes those benchmarks will just broken and this will detect it. However, these benchmarks may run for a long time, so only 1 iteration is enough. When we use criterion now, it is not possible to just write these commands because criterion based benchmarks will be run in bench mode and it takes a lot of time.

Nice to see there is already a milestone for it! Closing


Possibility to configure how  YAML is written YAML Block vs. Flow Style

Hi Selim,
thanks a lot for this great tool. Maybe i have missed it, is it possible to select how the YAML is written?  So that one can select Block vs. Flow Yaml style?
YAML Block Style
This is the style I use for all Obsidian tags.

---
tags:
  - toys
  - gifts
---
# Heading
Content begins here...

YAML Flow Style
Alternative, compact style that is still valid YAML, but handling it is not a very high priority for these tools. This is particularly the case for the tools designed to have minimal dependencies, which don't have an actual YAML parser.
---
tags: [toys, gifts]
---

Best Regards
Hassel

I tried everything, even built the string manually by concatenating values and when it saved it's still did not save it as I had specified. (yaml flow style)


Write scipt for render to create a html + remove notebook cell input

Hey @tonyshumlh
Please write a script to automate  creating HTML Thanks!

Dockerfile is updated for the package jupyter-book

Need to add .nojekyll file for Github Page

@WeilinHan8 linked the updated html report to README; update the summary in README (maybe change the reference as well)

Updated in https://github.com/UBC-MDS/DSCI_522_Group-11_Save-The-Earth/pull/47

Great, thank you Tony!


Updated Portis version to 4.0.0

@mimafogeus2 Thanks for this!

@mimafogeus2 could you update this branch with develop and then I'll merge, thanks!

@taylorjdawson - Done :)


[v2.7] Update ACI-CNI to <IP_ADDRESS>

There is ACI-CNI version <IP_ADDRESS> which is an upgrade to <IP_ADDRESS> we currently have included in KDM for RKE1 provisioned clusters.

Closing as ACI CNI changes were merged. @jeffinkottaram , please let me know if you encounter any issues with ACI CNI testing.

Closing again as RKE was bumped in rancher/rancher.


Fix error with elasticsearch(sniff_on_start=True)

What does this pull request do?
Checks if the span object is non-None before trying to access its context.
(Fix is incoming, pushing the test first to make sure it fails)
Related issues
Closes #1615

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-18T18:20:14.845+0000

Duration: 31 min 14 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
4975

Skipped
3420

Total
8395

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

:globe_with_meridians: Coverage report

Name
Metrics % (covered/total)
Diff

Packages
100.0% (68/68)
:green_heart:

Files
100.0% (227/227)
:green_heart:

Classes
100.0% (227/227)
:green_heart:

Lines
89.759% (17459/19451)
:+1: 0.008

Conditionals
77.18% (3186/4128)
:+1:

/test full


Rotate animation bug

When i have the new rotate animation on duscord gets messed up. The text gets kinda upside down but still not. The letters are the right way but the text is backwards and its read upside down

This has now been fixed in Version 1.0.2.


doc(apisix_upstream): fix apiVersion to v2beta3

error: resource mapping not found for name: "httpbin" namespace: "" from "httpbin-upstream.yaml": no matches for kind "ApisixUpstream" in version "apisix.apache.org/v1"

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[x] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

please see: https://github.com/apache/apisix-ingress-controller/pull/1134#pullrequestreview-1030448085

please see: #1134 (review)

OK， I'll close this PR.

@soulbird  You may not understand what I mean.
Whether it's done in #1134 or in this PR I think it's ok.
We welcome any type of contribution, these are valuable.
If you have the time and interest, then you can modify the content except #1134.
This way #1134 doesn't need to make any changes.

@soulbird You may not understand what I mean.
Whether it's done in #1134 or in this PR I think it's ok. We welcome any type of contribution, these are valuable.
If you have the time and interest, then you can modify the content except #1134. This way #1134 doesn't need to make any changes.

Let's see if the contributor is willing to continue to improve, if there is no feedback, I will complete it


Length mismatch in array init causes buffer overflow

When initializing an array, the value put in the length field is equal to the total number of allocated bytes, not the number of elements the array can hold.
Example:
use std::mem::MaybeUninit;
use crossbeam::epoch::*;

pub fn main() {
	let owned = Owned::<[MaybeUninit<usize>]>::init(10);
	let arr: &[MaybeUninit<usize>] = &*owned;
	println!("{}", arr.len());
}

This should print 10, but prints 88. In particular, it has only allocated space for 10 elements of data, so creation of arr in the example is UB.

I think the issue is in <[MaybeUninit<T>] as Pointable>::init(): (*ptr).size = size sets the length to the allocated size (in bytes) instead of the actual size (in elements).

Thanks! I filed #694 to fix this.

Beat me to it by a few seconds! I also filed #695.

Sorry, I didn't notice you were writing on a patch to fix this...

No worries, I like your patch better than mine anyways :).


[1.3] Google Home Can't connect to your device

Reproduction steps
I used silabs EFR32MG24 to develop the matter device. Use the following two SDKS, which support Matter 1.3.
SiliconLabs/matter_extension at v2.3.0 (github.com)
SiliconLabs/simplicity_sdk: The Simplicity Software Development Kit (SDK) is an embedded software de...
Google Home version: <IP_ADDRESS>
Nest Hub 2 software version: <IP_ADDRESS>3521407
I use the test certificate for development, in the multiple commissioning rounds of Google Home often appear 'Can't connect to your device', the error log is attached.
It usually appears after this step:

The choice Set up anyway will follow. It will come right after that:

failed-log.txt
Bug prevalence
1-2 times out of every five
GitHub hash of the SDK that was being used
matter-extension-2.3.0
Platform
efr32
Platform Version(s)
1.3
Type
Platform Issue
Anything else?
No response

Sounds like a Google Home issue, not a core Matter one.  Please report the issue to Google...


Workflow for lifter checking

Make a PluginLifterDebugWorkflow with extra lifting debug messages (tags??) that may be too slow to run on normal workflows. Would be a great resource for lifter plugin devs
Many good checks in Liftcheck: https://gitlab.com/rsnyder/binja-riscv/-/blob/master/src/liftcheck.rs
Could throw in other checks too if there are good ideas

Unknown registers #2307


web vimawesome.com can't load detail of plugin

Hi all,
I don't know where to report issues about the website functionality,
please deleted this one if i post in wrong place.
I found an issue when click detail of plugin, it's always display preloader
I think the problem is the javacript, in console log it's diplay
Uncaught TypeError: undefined is not a function   /static/build/js/app.js:1
Thanks.
Kahfi

I do get that console error too. There shows this on console: Uncaught TypeError: u.moment is not a function

Sorry folks. I broke this when I (stupidly) did #119.
Fixed here: 00e3b1ba1791ad59bda8a6436fc71b8d92d087f0
We should be back now.

@puterakahfi To your question, this is the right place to report issues with website functionality. Thanks for reporting the issue. :+1:


Include more modules in data preload

More questlines, houses, etc. should be included with the data preload.

[ ] Questlines
[ ] Houses
[ ] Objectives
[ ] Followers

Questlines:

Main Quest
College of Winterhold
Companions
Dark Brotherhood
Imperial Legion
Stormcloaks
Thieves Guild

Houses:

Breezehome
Honeyside
Vlindrel Hall
Hjerim
Proudspire Manor

Objectives (several are achievements):

Find 13 Standing Stones
Collect 15 Daedric Artifacts
Learn 20 shouts
Become a vampire
Collect all Unusual Gems

Followers:

Argis the Bulwark
Calder
Iona
Jordis the Sword-Maiden
Lydia

Maybe combat styles:

Necromancer
Summoner
Bound Weapons
Uses Followers
Unarmed
Dual-Wielding


Completion function never gets called

When I trace the incoming ClientRequest from my client I get the following request:
completion(LanguageServerProtocol.CompletionParams(textDocument: file:///home/ubuntu/Documents/PklLanguageServer/test.pkl, position: {0, 3}, context: Optional(LanguageServerProtocol.CompletionContext(triggerKind: LanguageServerProtocol.CompletionTriggerKind.triggerCharacter, triggerCharacter: Optional(".")))), (Function))
However, the completion() function never gets called no matter what. Other functions like for example semanticTokensFull work fine. What can I do?

Thanks for opening this issue. Just for context - this repo was extracted from the work done on hylo language server. It was originally added to https://github.com/chimeHQ/LanguageServerProtocol.
I don't fully understand all of the internals yet, so this is something I still have to figure out.

Ok, so the RequestHandler type has a lot of default implementations and that's worrying me because those area easy to get wrong.
The type signature for completions is:
func completion(id: JSONId, params: CompletionParams) async -> Response<CompletionResponse>
but in your code it is:
public func completion(id: JSONId, params: CompletionParams) async -> Result<CompletionList, AnyJSONRPCResponseError>
Use of Result directly shouldn't be an issue but I don't think CompletionResponse is equivalent to CompletionList. Have to check.

No it is not. Try changing your signature to match the protocol exactly and see if fixes things.

Thank you so much, I didn't notice it, working fine now!


Add Resources property to Application

Add Resources property to Application so it can behave same as this:
<Application x:Class="Core2D.Perspex.App"
             xmlns="https://github.com/perspex"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
    <Application.Styles>
        <Style>
            <Style.Resources>
                <SolidColorBrush x:Key="BorderBrush">#FFACACAC</SolidColorBrush>
            </Style.Resources>
        </Style>
    </Application.Styles>
</Application>

so it is possible to define resources like this:
<Application x:Class="Core2D.Perspex.App"
             xmlns="https://github.com/perspex"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
    <Application.Resources>
        <SolidColorBrush x:Key="BorderBrush">#FFACACAC</SolidColorBrush>
    </Application.Resources>
</Application>

Could you explain why exactly you want the second example to be possible? Would it be equivalent to the first example?
Or is the problem that you just don't understand why Resources were moved into Style when they are directly on the Control/Application in other XAML frameworks?

I want to have Resources property on Application (and also on UserControl) to define Application wide (and UserControl wide) reusable resources (e.g. brushes) used in Styles and in DataTemplates. This should be separated from Styles and DataTemplates as it can be used everywhere UserControl, Style, DataTemplate etc. Also this are actually the resources the you use and not related to styles only.
And second reason is that this is pattern used in other frameworks, especially in WPF, that I find very convenient and useful.
Finally this can be viewed as syntactic sugar, as you don't have to define style only for resource definition.
Please also tell why it was moved to Style, what was the reasoning.

Please also tell why it was moved to Style, what was the reasoning.

I'll start by explaining this. It's a long story, so be prepared for a read!
In WPF, styles are added to ResourceDictionary collections, and items in resource dictionaries need a key. The key is either the TargetType for styles that apply to otherwise unstyled controls of the specified type, or are explicitly keyed.
When WPF looks up a style, if there is no Style= property specified, it looks for the style by trying to find an element in the resource dictionary with a key == typeof(TheControl), otherwise it uses the key from the Style property. It walks up the tree, searching the resource dictionaries until a match is found, and that's your style. Only a single style can match a control (we're ignoring BasedOn here).
In Perspex we have a CSS-like system where many styles can match a single control, and the order in which they're defined matters. Resource dictionaries are unordered, so immediately we've ruled out a system like WPF's. Now we could make resource dictionaries in Perspex ordered, but that means we'd have to search every object in every resource dictionary for styles. That would be bad for performance.
So instead we store Perspex styles in a Styles collection, which is a) ordered and b) only contains styles. Makes sense?
Now when you want to build a theme in WPF, you create a XAML file containing a ResourceDictionary. But as we've already determined, we can't put styles in a resource dictionary. Instead, we have the XAML file contain a Style (or Styles collection for multiple styles). So where do we put resources in this case? You'll often want to define resources along with your styles for brushes etc, so it makes sense to put the resources under Style, right?
So that's why they're there.

I'll now address your issue:

I want to have Resources property on Application (and also on UserControl) to define Application wide (and UserControl wide) reusable resources (e.g. brushes) used in Styles and in DataTemplates. This should be separated from Styles and DataTemplates as it can be used everywhere UserControl, Style, DataTemplate etc. Also this are actually the resources the you use and not related to styles only.

Firstly, styles defined in Style.Resources can be used everywhere, they don't just have to be used in Styles. They already should be usable in UserControl, Style, DataTemplate (though there are probably bugs in some of these as I've not tested the feature that thoroughly yet!)
Now let me explain why I think you shouldn't be using them ;)
The reason style resources were introduced was to allow those resources to be overridden for a particular part of the UI. For example, you might want a flyout control in your window to use a dark style while the window uses the light style.
If you just want a named brush for the whole of your application, I'd suggest just exposing a static Brush from code. XAML is actually a really bad place for defining resources that won't change in any part of your UI for these reasons:

The resources have to be parsed
The tree has to be traversed to find them
XAML doesn't handle immutable objects
XAML syntax is really long-winded compared to C#

In general, I agree with this article which says:

VI. Avoid ResourceDictionary
This advice is practically impossible to follow, but do your best. There is a huge cost in constructing ResourceDictionaries, and depending on where you place them, you are probably constructing many more objects than you realize.

As an addendum: I know there are people who try to define their whole view layer in XAML, and say that using code-behind is bad. I always doubted that this was something to follow, but after implementing Perspex and knowing everything that goes on in the background of a XAML framework - I am positive that they are wrong. It's an incredibly verbose and wasteful (in terms of CPU) way to do things.
You're are not breaking MVVM by writing code in your view layer. Use the tool that makes most sense, and in many many cases that tool is code, not markup.


simplifies the requirements for using git and controls when the ebuild could not be carried out correctly

I had missed these 2 problems to solve :-(

This one too: https://github.com/Tatsh/livecheck/pull/235/files#diff-aa05bf77c6475621550b2c1514165c569eac97012c3d020c4f41b51a683716b1R402

Fix, thanks!

There is still one more.

Ready, thanks for your patience
all the best


Fixing typos in comments, variable names etc.

This PR fixes typos in comments, variable names, string literals etc.
No functional code changes!
Signed-off-by: Delyan Raychev<EMAIL_ADDRESS>

Codecov Report

Merging #2330 (42d0aea) into main (50a62d3) will decrease coverage by 0.20%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   57.26%   57.05%   -0.21%
==========================================
  Files         149      149
  Lines        6673     6673
==========================================
- Hits         3821     3807      -14
- Misses       2847     2861      +14
  Partials        5        5

Impacted Files
Coverage Δ

cmd/cli/install.go
65.62% <ø> (ø)

cmd/cli/metrics.go
58.82% <ø> (ø)

cmd/osm-controller/osm-controller.go
22.05% <0.00%> (ø)

pkg/catalog/dispatcher.go
60.78% <ø> (ø)

pkg/catalog/traffictarget.go
87.50% <ø> (ø)

pkg/catalog/xds_certificates.go
93.40% <ø> (ø)

pkg/configurator/client.go
84.67% <0.00%> (ø)

pkg/debugger/debugger_config_listener.go
0.00% <0.00%> (ø)

pkg/envoy/ads/response.go
74.07% <ø> (ø)

pkg/envoy/lds/listener.go
43.75% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1157046...0ced6b7. Read the comment docs.

Codecov Report

Merging #2330 (42d0aea) into main (50a62d3) will decrease coverage by 0.20%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   57.26%   57.05%   -0.21%
==========================================
  Files         149      149
  Lines        6673     6673
==========================================
- Hits         3821     3807      -14
- Misses       2847     2861      +14
  Partials        5        5

Impacted Files
Coverage Δ

cmd/cli/install.go
65.62% <ø> (ø)

cmd/cli/metrics.go
58.82% <ø> (ø)

cmd/osm-controller/osm-controller.go
22.05% <0.00%> (ø)

pkg/catalog/dispatcher.go
60.78% <ø> (ø)

pkg/catalog/traffictarget.go
87.50% <ø> (ø)

pkg/catalog/xds_certificates.go
93.40% <ø> (ø)

pkg/configurator/client.go
84.67% <0.00%> (ø)

pkg/debugger/debugger_config_listener.go
0.00% <0.00%> (ø)

pkg/envoy/ads/response.go
74.07% <ø> (ø)

pkg/envoy/lds/listener.go
43.75% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1157046...0ced6b7. Read the comment docs.

I really enjoyed this PR!

I really enjoyed this PR!


TestCafe can't find browsers on Window that are installed only for a current user

See https://github.com/DevExpress/testcafe-browser-tools/issues/128

+1 it doens't matter what I do reinstall ad chrome to my path ( I can start it with chrome from terminal ),
The testcafe package globally or locally installed will never see any listed browsers running testcafe -b
Installed Firefox didn't pop up on -b reinstalled testcafe still no luck and your docementation really lacks on this issue or how to force a default browser.

We've found the cause of the problem and we're going to fix it soon.
As a temporary workaround you can pass a path to the installed browser to TestCafe (See Portable Browsers).

I tried with portableChrome but no matter what browser I use it keeps saying unable to find browser. Even if I install the browser in my user folder

do you mean the approach like testcafe path:d:\chromeportable\chromeportable.exe tests/sample-fixture.js doesn't work on your side?

Nope, but it might be a problem with my work computer as well, regarding permissions, I will try and install firefox in my user Folder and try again.

but should it work with portable chrome'? Because that I tried and that also didn't work

but should it work with portable chrome'? Because that I tried and that also didn't work

what the error do you see in the report?

`testcafe path "/c/Users/barrybadpak/chrome/GoogleChromePortable" tests/**/*test.js -r list -S -s report/screenshots/ -e --selector-timeout 500000 --assertion-timeout 10000
Using locally installed version of TestCafe.
ERROR Was unable to open the browser "path:" due to error.
TypeError: Cannot read property 'trim' of undefined
at Object.callee$0$0$ (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\lib\api\get-browser-info.js:54:41)
at tryCatch (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at GeneratorFunctionPrototype.invoke [as _invoke] (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:334:22)
at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:105:21)
at tryCatch (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at invoke (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:146:20)
at C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:154:13`

also tried with adding the executable, /c/Users/barrybadpak/chrome/GoogleChromePortable/chrome.exe

testcafe path "/c/Users/barrybadpak/chrome/GoogleChromePortable" tests/**/*test.js

Your syntax is not quite correct. It should be like this:
testcafe "path:`C:\Program Files (x86)\Google\Chrome\Application\chrome.exe`" d:\temp\gh-1679.js

Note, it necessary to pass a path to a Chrome executable file.

I already noticed that and tried that same error, then I got it to work with the nightmare browser. But then I took the trouble of getting a new computer here at work with full root acces, that one does run with chrome and all my test pass. On my own computer not with root acces ( work laptop ) they all fail with nightmare. Any ideas?

Have you tried exactly the same syntax as in my example?
testcafe "path:`C:\Users\barrybadpak\chrome\GoogleChromePortable\chrome.exe`" tests/**/*test.js

It should be a : symbol after the path part and the path should be started with C:\.
If this command run is failed too please provide me.

On my own computer not with root acces ( work laptop ) they all fail with nightmare. Any ideas?

Do you mean you are able to run tests in nightmare but they are failed? If yes please let me know what the errors do you see?

https://github.com/ryx/testcafe-browser-provider-nightmare/issues/7 In nightmare I googled my errors and I think it has something to do with the fact that the window size is too small and the buttons don't appear properly ( our site is not so responsive yet ) but preferable I will try your command. Because during devloping seeing the test is way better :) ( the screenshots don't tell me a lot )

testcafe "path:C:\Users\barrybadpak\chrome\GoogleChromePortable\chrome.exe" tests/**/*test.js
I tried this too but it says same error:
testcafe "path:C:\Users\barrybadpak\chrome\GoogleChromePortable\chrome.exe" tests/**/*test.js
bash: C:UsersbarrybadpakchromeGoogleChromePortablechrome.exe: command not found
Using locally installed version of TestCafe.
ERROR Was unable to open the browser "path:" due to error.
TypeError: Cannot read property 'trim' of undefined
at Object.callee$0$0$ (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\lib\api\get-browser-info.js:54:41)
at tryCatch (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at GeneratorFunctionPrototype.invoke [as _invoke] (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:334:22)
at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:105:21)
at tryCatch (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:72:40)
at invoke (C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:146:20)
at C:\Users\barrybadpak\WORK\end-to-end-test\node_modules\testcafe-browser-tools\node_modules\babel-runtime\regenerator\runtime.js:154:13

but using the path with a CD command does work

That's because you should escape backslashes in Bash: http://wiki.bash-hackers.org/syntax/quoting. e.g. C:\\Users\\barrybadpak\\chrome\\GoogleChromePortable\\chrome.exe. Or use regular slashes: C:/Users/barrybadpak/chrome/GoogleChromePortable/chrome.exe

@AndreyBelym That worked! Though it started up the browser nothing seems to be happening. The full command im using now is
testcafe "path:/c//Users//barrybadpak//chrome//GoogleChromePortable//chrome.exe" -r list -S -s report/screenshots/ -e --selector-timeout 500000 --assertion-timeout 10000

Just stating that this all works perfectly fine one computer with root acces and the build in chrome browser

A workarround for this if your user does not have access to program files, copy paste the chrome folder somewhere within your user folder and specify the path.
"test": "testcafe path:C:\Users\barrybadpak\chrome\GoogleChromePortable\chrome.exe tests/**/*test.js -r list -S -s report/screenshots/ -e --selector-timeout 500000 --assertion-timeout 10000"
don't use ``

don't use ``

It's necessary if you have spaces in the path to the browser executable


merge pull request  from apollo/master

What's the purpose of this PR
XXXXX
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Read the Contributing Guide before making this pull request.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[ ] Run mvn clean test to make sure this pull request doesn't break anything.

merge pull request from apollo/master


Fix request attribute-related race condition in Logback request logging

Addresses #1672
i.d.request.logging.async.AsyncAccessEventAppenderFactory invokes AccessEvent. prepareForDeferredProcessing, which triggers a race with an identical invocation within Logback itself. The reported issue indicates that the race manifests in inconsistent logging behavior when request attributes are set within a resource class.
This change removes the prepareForDeferredProcessing call from dropwizard-request-logging. As far as I know, all IAccessEvents encountered by this class will be of concrete type AccessEvent and all non-async appenders extend OutputStreamAppender, so the prepareForDeferredProcessing method should always be invoked exactly once.

Coverage increased (+0.02%) to 82.423% when pulling d968d6a9fb4d317f9fe4defb591b5e14e41cbdf6 on evnm:dropwizard-request-logging/logback-attr-map-race-condition into 1e40fef4f4e8f048885b7ce6067bd9cd87a749b2 on dropwizard:master.

It's very strange to step on those thread-safety issues with Logback (or the SLF4J bridge). Let's see if the fix helps, I even don't known how to write a unit to reproduce it.

Coverage increased (+0.02%) to 82.41% when pulling 77eb5f8a671231a4c6badf6f8006af004cf1366c on evnm:dropwizard-request-logging/logback-attr-map-race-condition into e077d2cc8195673bf95a5ff86a06834fd190f83d on dropwizard:master.

Thanks, @evnm!

Cherry-picked to the 1.0,x branch.


Black produced different code on the second pass of the formatter.

Operating system: linux ubuntu
Python version: probly something like 2.7
Black version: black, version 18.6b4
Does also happen on master: maybe - kidding - probly nope you can care to try it again
what
Black produced different code on the second pass of the formatter.

also you should not put the dot at the end of the url, it takes you to Kansas otherwise

- Please report a bug on https://github.com/ambv/black/issues. This dif...
+ Please report a bug on https://github.com/ambv/black/issues . This dif...

error cli
error: cannot format /dada/dada.py: INTERNAL ERROR: Black produced different code on the second pass of the formatter.  Please report a bug on https://github.com/ambv/black/issues.  This diff might be helpful: /tmp/blk_2b7b0tid.log

Ran black like: black /dada/dada.py --check
pass

first pass
second pass

Scrambled diff
--- source
+++ first pass

@@ -447,25 +499,30 @@
                 if self.secret == "secret":
                     secret = "secret.secret.secret"

                 secret = "secret"
-                if xxxxxx.yyyyyyy_xxxx.__class__ != ttttt.DobeRobe and hasattr(  # noqa: E721
-                    xxxxxx.yyyyyyy_xxxx.pepepep, "bbbbbb"
+                if (
+                    xxxxxx.yyyyyyy_xxxx.__class__ != ttttt.DobeRobe
+                    and hasattr(xxxxxx.yyyyyyy_xxxx.pepepep, "bbbbbb")  # noqa: E721
                 ):
                     yyyyyyy_xxxx_name = xxxxxx.yyyyyyy_xxxx.pepepep.bbbbbb
                 bobuld = parachute_doris.asdat_asdsa(
                     args=(fo_foian(ronalda),),
                     buwas=buwas,
--- first pass
+++ second pass
@@ -504,14 +504,13 @@
                 if self.secret == "secret":
                     secret = "secret.secret.secret"

                 secret = "secret"
-                if (
-                    xxxxxx.yyyyyyy_xxxx.__class__ != ttttt.DobeRobe
-                    and hasattr(xxxxxx.yyyyyyy_xxxx.pepepep, "bbbbbb")  # noqa: E721
-                ):
+                if xxxxxx.yyyyyyy_xxxx.__class__ != ttttt.DobeRobe and hasattr(
+                    xxxxxx.yyyyyyy_xxxx.pepepep, "bbbbbb"
+                ):  # noqa: E721
                     yyyyyyy_xxxx_name = ffffff.yyyyyyy_xxxx.pepepep.bbbbbb
                 bobuld = parachute_doris.asdat_asdsa(
                     args=(fo_foian(ronalda),),
                     buwas=buwas,

Sorry for the longpost here's an ascii potato: ()

Please update the title with a proper description of the issue that has been found.
Also at time of writing the latest stable version is 18.9b0 and doesn't show this issue so perhaps close this ticket?

Could not reproduce in latest stable version.


As a part of issue #19, Implement the ability to instantly fly high above the clouds on click of "H" button.

As a part of issue #19, Implement the ability to instantly fly high above the clouds on click of "H" button.

The ability to instantly fly high above the clouds on click of "H" button is implemented.


X-Flow-ID Guidelines

The new guideline(s) should include:

How to handle X-Flow-ID
What are the boundaries (scope) of the X-Flow-ID
Which properties should apply to X-Flow-ID
When to generate a X-Flow-ID and how should it look like
Further explanations and reasoning

Related to / triggered by #228.

From the meeting: Maybe we can copy some text from the tracer library.

Is only explicitly defined in 103 of 250 apis.

From the meeting:

We want to have a guideline about distributed tracing
The flow-ID should be passed through events, too
Should API definitions include the definition of the header?

@whiskeysierra will collect ideas from @tkrop and @tfrauenstein, possibly also from @valgog and @dehora, and write it together.

I wrote my understanding of the current situation in a document and shared it with the guild + people mentioned above. This should be a starting point for the upcoming discussions.

From guild meeting: make contact with tracebility initiative.

@whiskeysierra Would like to have access to the doc you mentioned.

We might replace this with OpenTracing, which is currently being discussed. On hold for now.

We want to invite some experts from SRE team, and see whether the OpenTracing rollout will fulfill the needs we have with FlowID.

Can we discuss this issue in next API-Guild meeting how to get this done? For me it's not really clear how many changes should be done. Questions from my side are:

When the issue was created, @maxim-tschumak (Jun 22, 2017) had some hints about what guidelines should include like "How to handle X-Flow-ID", "What are the boundaries (scope) of the X-Flow-ID", etc... Is this still valid and should this be still considered?
There is also another comment from @ePaul (Sep 26, 2017) about new agreed requirements which are "We want to have a guideline about distributed tracing", "Theflow-ID should be passed through events, too" and "Should API definitions include the definition of the header"? I think a guideline about distributed tracing should be done by OpenTracing WorkingGroup. So there should be at least a link in the API-Guidelines to the guidelines or best practices of OpenTracing as further explanation. "Should API definitions include the definition of the header" might makes sense to introduce it in API-Guidelines.
Should we restructure topic Must: Use Only the Specified Proprietary Zalando Headers [183] at least section X-Flow-ID? I have the feeling that the existing description of X-Flow-ID gets messy if we add more information.


Update http-cache-semantics | Remove warning

This PR updates http-cache-semantics to a higher version so that the vulnerabilty warning disappears

Internal Tracking ID: EXPOSUREAPP-14718

Summarized all PRs into one to simplify testing #3380


Meaning of Confidence values

In coco dataset joints with zero values are always be like (0,0,2).
Can you please where you are using confidence value of (x,y,1) and (x,y,0).
What is the difference b/w confidence value=1 and 2?

reorder_map = [1, 7, 9, 11, 6, 8, 10, 13, 15, 17, 12, 14, 16, 3, 2, 5, 4]
I believe, you change this order according to OpenPose. As zero is nose in orignal COCO, you didnt mention zero in this ordering. Can you explain a little?

For code adjustment to a custom dataset, please check TRAIN-ON-CUSTOM-DATASET.md.

BTW, I am following all the settings provided in mentioned file :( .
Couldnt find the answer of my question from that file.

What is the problem you are solving? You may use any keypoints order you like in your project. COCO has 17 keypoints, OpenPose rearranges them and adds one more - neck. For compatibility with the original OpenPose order we have preserved this rearrangement.

Thank You alot. I have tained your model foer MPII and it is working fine.


Nice changes pulled from our BBR experiment

This change is

Pull Request Test Coverage Report for Build 77

9 of 16 (56.25%)  changed or added relevant lines in 1 file are covered.
13 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.4%) to 65.458%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ndt-server.go
9
16
56.25%

Files with Coverage Reduction
New Missed Lines
%

ndt-server.go
13
65.46%

Totals

Change from base Build 74:
-2.4%

Covered Lines:
307

Relevant Lines:
469

💛  - Coveralls


Fixup package

I based the initial package on my local output directory, but it turns out it was in a bad state. Respecified the dependencies against a clean build. I also twiked the nuspec to make it easier to consume from our VSTS build definition.

Going to push this to an experimental branch and test out the entire pipeline before sending the PR.


Loss of decimal precision when logging with Facades Log

Laravel Version: 5.5.45
PHP Version: 7.0.33
Database Driver & Version: Mysql Version: 5.7.26
OS: Ubuntu 16.04 x64 (Linux 4.15.0-50-generic kernel)

Description:
When I use the log component to log in the middleware, when some of the request parameters are decimal, there is a case where the precision is lost.
Steps To Reproduce:

~app/Http/Middleware/LogMilddleware.php

<?php
namespace App\Http\Middleware;

use Illuminate\Support\Facades\Log;
use Closure;

class LogMiddleware
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        Log::info("--------------------------------------------");
        Log::info($request->ip());
        Log::info($request->url());
        Log::info($request->all());
        return $next($request);
    }
}

~/app/Http/Kernel.php

<?php

namespace App\Http;

use Illuminate\Foundation\Http\Kernel as HttpKernel;

class Kernel extends HttpKernel
{
    /**
     * The application's global HTTP middleware stack.
     *
     * These middleware are run during every request to your application.
     *
     * @var array
     */
    protected $middleware = [
        \Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode::class,
        \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
        \App\Http\Middleware\TrimStrings::class,
        \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
        \App\Http\Middleware\TrustProxies::class,
        \App\Http\Middleware\LogMiddleware::class,  // <--------------Here
    ];
...

request data

{
	"datetime":"2019-05-17 12:00:00",
	"account_name":"KKK",
	"platform_bank_id":"100001",
	"platform_bank_name":"BANK",
	"amount":100.52,
	"total_amount":200.51
}

log info

[2019-05-17 14:43:47] local.INFO: --------------------------------------------
[2019-05-17 14:43:47] local.INFO: <IP_ADDRESS>
[2019-05-17 14:43:47] local.INFO: http://<IP_ADDRESS>:8000/api/info/receive
[2019-05-17 14:43:47] local.INFO: array (
  'datetime' => '2019-05-17 12:00:00',
  'account_name' => 'KKK',
  'platform_bank_id' => '100001',
  'platform_bank_name' => 'BANK',
  'amount' => 100.52,
  'total_amount' =><PHONE_NUMBER>9999999,
)

However
The data I get when I use the $request->get("total_amount")  receive parameters is correct.

I just tested this with the exact same setup and it works for me. Maybe there's some php.ini setting that could cause this?
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

This issue is also not locked and everyone is still free to discuss solutions to your problem!
Thanks!


Add ssh command

Add ssh command to implement the ssh flow as described in GEP-15 https://github.com/gardener/gardener/blob/master/docs/proposals/15-manage-bastions-and-ssh-key-pair-rotation.md#ssh-flow

PR to add ssh command https://github.com/gardener/gardenctl-v2/pull/4

resolved with https://github.com/gardener/gardenctl-v2/pull/4
/close


Switch from OpenSSL to LibreSSL

This was suggested by @JayH5 on PR #201 after it was merged.

That was fast. 😁  Thanks 🍰
I'm not really sure what the LibreSSL vs OpenSSL policy is with Alpine official images. But it seems to me that if LibreSSL is the Alpine default then that is what we should use, especially if other packages are installed that depend on LibreSSL and that then conflicts with OpenSSL.
But I'm sure @tianon will have an answer for us as always :)

In past conversions (when Alpine 3.5 switched from OpenSSL-by-default to LibreSSL-by-default) we only switched if packages we installed caused conflicts at build-time or run-time, but if this compiles and works, I'm +1 (especially since Alpine 3.5+ does use LibreSSL-by-default, so it makes sense for us to follow suit even/especially to ensure that compatibility works properly and packages can install).

LGTM, in other words :+1:


Fix Bug - Logo Animation

The logo animation should follow the page's scrolling until the description is hidden.

@InbarDanieli do you want to take it?

sure (:

@MichalPorag Looks like it was fixed (right?)
Do we have a "Done" column?


📃: Add Beginner-Level Python Projects

:red_circle: Title :Add Beginner-Level Python Projects
:red_circle: Aim :To provide beginner-friendly Python projects that help learners practice basic Python programming skills.
:red_circle: Brief Explanation :I would like to contribute a set of beginner-level Python projects aimed at enhancing the foundational understanding of core Python concepts. These projects focus on practical applications involving user inputs, date and time functions, and simple interactive features. They will serve as excellent practice exercises for new learners to improve their coding skills and confidence in Python programming.
Screenshots 📷
N/A
:white_check_mark: To be Mentioned while taking the issue :

Full name : Pasam Tharun
Contributor(GirlScript Summer of Code (GSSOC) 2024 - Extended Edition)

👋 Hey @UTSAVS26,
I really admire the work you're doing on this project and would love the opportunity to contribute! 🚀 I'm particularly interested in working on Beginner Projects, and I have experience with relevant skills/technologies that I believe can add value.
Could you kindly assign this issue to me? I’m excited to dive in and collaborate with you to make this even better! 😄
Looking forward to hearing from you and getting started!

@PasamTharun what is this? You closed the issue?

@UTSAVS26
Very sorry For closing the issue It was happened Unfortunately

@UTSAVS26  Please Assign it to me i Would like to contribute on this!

@PasamTharun you only maid the PR for the file onto your cloned repo not in the main repo.


Implement the network information gathering for both mac and linux

The main goal of this task is to find the way to get the core of our package resolved. I mean, how to get how much band with every process has used in certain period of time
This should be done for Linux and MacOS, probably using golang os core module

Upon further investigation, it appears that the OS module does not provide any information related to networking. Therefore, we need to determine if there is a built-in module (preferably) that can be used for this purpose or as a last resort, a third-party library. I will delve deeper into this and provide an update.

Upon further investigation, it appears that the OS module does not provide any information related to networking. Therefore, we need to determine if there is a built-in module (preferably) that can be used for this purpose or as a last resort, a third-party library. I will delve deeper into this and provide an update.

Perfect, eager to hear about this!!

@evert-arias maybe this could help
https://github.com/gherlein/gonetmon

@evert-arias this is another source I think we could use:
https://medium.com/cyberark-engineering/golang-monitoring-made-easy-with-version-1-16-df06f7477d75
In this article the author talks about a package called runtime/metrics

@evert-arias maybe this could help
https://github.com/gherlein/gonetmon

I'll check this out.

@evert-arias this is another source I think we could use: https://medium.com/cyberark-engineering/golang-monitoring-made-easy-with-version-1-16-df06f7477d75 In this article the author talks about a package called runtime/metrics

I already checked this and it doesn´t work for network stats

@evert-arias this is another source I think we could use: https://medium.com/cyberark-engineering/golang-monitoring-made-easy-with-version-1-16-df06f7477d75 In this article the author talks about a package called runtime/metrics

I already checked this and it doesn´t work for network stats

Exactly, can confirm.

These are the options:

https://github.com/shirou/gopsutil
https://github.com/drael/GOnetstat

My research suggests that https://github.com/shirou/gopsutil is the best cross-platform option. I’ll explore the library further.

These are the library's supported architectures:


Suggestion: vehicle category instead of LEO status

Not an issue, more a suggestion: to make this script optionally framework independent, you could add an option to have the script check for vehicle type instead of framework LEO status and by doing 2 things:

only show LEO observations to front right and left seat of emergency vehicles and
exclude occupants of emergency vehicles from seatbelt observations in general

The script already is standalone and does not require any dependencies, but offers optional out-of-the-box support for other frameworks if detected.
LEOs are not excluded from notifications to other LEOs and this will not be changed in the future, however, an optional configuration field may be added.
Please ensure everything you've stated in an issue is factually correct before submitting it.


Fix none bounds

Fix cplex interface so variable and constraint bounds can be set to None (unconstrained)

Current coverage is 87.03% (diff: 100%)

Merging #26 into devel will increase coverage by 24.48%

@@              devel        #26   diff @@
==========================================
  Files             5          5
  Lines          1789       1789
  Methods           0          0
  Messages          0          0
  Branches        377        377
==========================================
+ Hits           1119       1557   +438
+ Misses          611        150   -461
- Partials         59         82    +23

Powered by Codecov. Last update c31a94d...fb494a0

Looks good, thanks!


Updated frontend: implemented "Save" for CPU and Heap profiles.

Please look on my inline comments. I propose next implementation of saveToFile that fixes all my comments, but I don't test this code:
WebInspector.CPUProfileHeader.prototype.saveToFile =
WebInspector.HeapProfileHeader.prototype.saveToFile = function() {
  var fileName = this._fileName || new Date().toISO8601Compact() + this._profileType.fileExtension();

  this._onTempFileReady = function() {
    this._tempFile.read(function (data) {
      WebInspector.saveAs(new Blob([data], {type: 'application/octet-stream'}), fileName);
    });

    this._onTempFileReady = null;
  };

  if (this._tempFile) this._onTempFileReady();
};

That you think about this realisation? Is it working as expected?

I think you're going to save on every profile completed... I test it just now...
In case another option could be
WebInspector.CPUProfileHeader.prototype.saveToFile =
WebInspector.HeapProfileHeader.prototype.saveToFile = function () {
    var fileName = this._fileName || new Date().toISO8601Compact() + this._profileType.fileExtension();

    function readAndSave(ProfileHeader){
      ProfileHeader._tempFile.read(function (data) {
          WebInspector.saveAs(new Blob([data], {type: "application/octet-stream"}), fileName);
      });
    }

    if (this._tempFile == null) {
        this._oldOnTempFileReady = this._onTempFileReady;
        this._onTempFileReady = (function () {
            readAndSave(this);
            this._onTempFileReady = self._oldOnTempFileReady;
            if (this._onTempFileReady) {
                this._onTempFileReady();
                this._onTempFileReady = null;
            }
        }).bind(this);
    } else {
        readAndSave(this);
    }
}

Updated and squashed.

I added some inline comments. They are last before merging. You can publish here already squashed version for this pr.
Thank you for all front-end fixes. I'll start to review your features.

Done ;)

Landed as 99514aa3d211242505c6cf95da1e2ef953023c8f


What is it that makes this slow ?

I wonder what it is that makes this process slow ... is there something fundamental about ELF parsing that is slow?
Or maybe it's something in the way we rewrite files.
It would be interesting to profile this and know we're not doing anything silly; it seems like the kind of thing there are many opportunities to be sub-optimal (this may be down to how we use LEIF).
I'm not sure other python interpreters are up to version 3.11, so that avenue may be out.

I did a mostly literal translation of the python code to rust, using ElfStream from https://docs.rs/elf/latest/elf/ instead of LIEF. It is now much faster.


Selectable points

Is it possible to select points in a line chart, for example? I'm looking for a react graphing library that allows the user to select a point, or maybe even a single bar on a bar chart.

Hey, good use case. Select something and get more info for example, I guess.
Should be possible. There was an issue requesting something similar and I am working on that.

https://github.com/codesuki/react-d3-components/issues/19


Guessit dependency collinding with Flexget (feature request?)

Hi and thanks for your great work!
I'm using Subliminal with Flexget (https://github.com/Flexget/Flexget) and there is a conflict in GuessIt dependency (<2.0 for Subliminal and 2.0.4 for Flexget).
I don't know what it implies to move to Guessit 2.0.4 but I'd love (and think other flexget user too) if it is possible without breaking anything!

It's already done in develop branch along with major new enhancements.

Thanks a lot, I installed dev branch and it's working again!


[Bug Report] Box contains treats float(inf) unexpectedly

Describe the bug
When checking if a number is contained in a Box I get True but I expect it to be False.
Code example
Python 3.10.11 (main, May  4 2023, 15:26:51) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from gymnasium.spaces import Box
>>> Box(low=float("inf"), high=float("inf")).contains([-10])
True
>>> Box(low=-float("-inf"), high=float("inf")).contains([-10])
True

System info

gymnasium.version
'0.26.3'

Additional context
No response
Checklist

[X] I have checked that there is no similar issue in the repo

does this happen only with inf>

Ok, this is a really weird bug from the outlook
In short, Box internally changes the inf to  -inf which is why contains([-10]) is true.
In particular, the get_inf function ignores the actual value passed just knowing that it was an infinite (ignoring that you passed a positive infinity as the lower bound) and returns a positive or negative infinity depending on if it is for the lower and upper bound.
I agree that this is a hidden behaviour that you don't expected from the outside.
@mzat-msft Would you be interested in making a PR that raise a warning or error to users that they are doing something silly and should update to -inf

@mzat-msft This is actually a very interesting case.
What are you exactly trying to achieve with using equal sign infinites as bounds for the Box space?
I ask this because this behaviour (in theory) should produce a degenerate space:

what values belong in the space?
what should is_bounded("above") return on a space of Box(-inf, -inf)?

Fixing this issue is possible (though I'm more keen to just make the space throw an error to disallow this behaviour).
If you could let us know what use case this is for, perhaps it would allow us to make more informed decisions when fixing this "bug".

There's no use case per se. There was this typo in our code and just thought it would be useful for you to know about it.
I agree that raising a ValueError is probably this. Would that apply to Box(x, x) too?

Would that apply to Box(x, x) too?

I think it would be reasonable to do so but np.random.uniform(low=x, high=x) works therefore, I don't think we should disable it


how do i make the points in the map bigger to make it easier to identify?

import holoviews as hv
import datashader as ds
import dask.dataframe as dd
import geoviews as gv
from cartopy import crs

from holoviews.operation.datashader import datashade

hv.extension('bokeh', width=95)

%opts RGB     [width=1200 height=682 xaxis=None yaxis=None show_grid=False bgcolor='black']
%opts Shape (fill_alpha=0 line_width=1.5) [apply_ranges=False tools=['tap']]
%opts Points [apply_ranges=False ] WMTS (alpha=0.5)

color_key = {worda:'red',  wordb:'green'}
races     = {worda:worda, wordb:wordb}

color_points = hv.NdOverlay({races[k]: gv.Points([0,0], crs=crs.PlateCarree())(style=dict(color=v))
                             for k, v in color_key.items()})

census_points = hv.Points(df, kdims=['x', 'y'], vdims=['word'])

x_range, y_range = ((-13884029.0, -7453303.5), (2818291.5, 6335972.0)) # Continental USA

shade_defaults = dict(x_range=x_range, y_range=y_range, x_sampling=10, y_sampling=10, width=1200, height=682,
                      color_key=color_key, aggregator=ds.count_cat('word'),)
shaded = datashade(census_points, **shade_defaults)
shaded()

now it looks like this.

but i want the points more bigger like this

how can i change the code to achieve my gola? THANKS~!

So far, datashader only includes infinitely small points and infinitely thin lines, which would be invisible if not for the non-zero width of a pixel in the image.  Adding the ability of a point or line to have an extent is something we plan to add eventually, but for now, you have a couple of options:

Decrease the resolution of your image, making each isolated pixel more visible.
Add "from holoviews.operation.datashader import dynspread" (or "spread"), then use spreading to expand each pixel into the neighboring pixels.  Mathematically, this is not the same as having a non-zero extent, but it's an approximation to it that's valid when points are far apart (as most of the ones above are).  Both have parameters that you can change to choose just how big you want to make the dots.

If one of those options is useful to you, please post your updated code and image here as an example for others.  If not, please show the best you got and let us know what you were hoping it would still do.


Cleanup mpl circuit_drawer module (post 0.7)

What is the expected enhancement?
As pointed out in the review for https://github.com/Qiskit/qiskit-terra/pull/1450 there are a few artifacts leftover from the json->dag conversion for the mpl backend. Things like misleading variable names and out of date notes and comments. After the 0.7 release it would be good to go through the module and clean this up to make maintenance easier.

@nkanazawa1989 @mtreinish OK. Let's discuss about it together.


lookup issue

What class do i need to create to  use [LookupScript("path")] so the lookup from RoleCheckEditor loads from my own entity (which probably would be inside the created class)?
thanks a lot

What are you exactly trying to do. It seems hard to understand.
Please clearly mention your problem.

i changed all services in repository to get data from servicestack. When i try to apply a role on a user from the button inside the grid, the RoleCheckEditor.ts has a lookup service to get the checkbox options(getTreeItems())(which gets its valuews from RoleRow). Is there any way to get these checkbox options from another class?


Add new trove classifiers

See https://github.com/jupyterlab/jupyterlab/pull/10731

Sorry, I've read this today, because I was busy with the flood catastrophe in Germany. This PR sound good to me, I will change my own extensions as well ;-)

I will mark this one as a draft because while the new classfiers were accepted and merged into the https://github.com/pypa/trove-classifiers/pull/72 we are still waiting for a new PyPI Warehouse release with the updated version of trove-cassifiers: https://github.com/pypa/warehouse/pull/9882

This is now available https://pypi.org/search/?q=&o=&c=Framework+%3A%3A+Jupyter+%3A%3A+JupyterLab+%3A%3A+Extensions :tada: @ocordes it is a good time to add those to your extensions as we will be switching to searching extensions using these classifiers. I hope you all recovered from the flood!

Okay, thnx for the info. I updated my extensions as well :-) We are rebuilding our house at the moment, hopefully we have a functional heating until the winter month.


feat: Configurable i18n default translation language

Pull Request Checklist

[X] Description: Briefly describe the changes in this pull request.
[X] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.

Description
This pull request introduces the ability for users to control i18n translation during deployment, resolving issue #1256. Previously, i18n only automatically detected the local language and applied corresponding translated content. With this change, users can now decide whether to enable this feature or set a default language during the deployment phase by settingconfig.json.

I was not sure about returning default_locale in /api/config, maybe @tjbck can help with comments on this.
Changelog Entry
Added

Added default_locale to config.json and return it as backendConfig to the UI.

Fixed

Removed translation values for en-US as they are not necessary (keys are used as fallback).

Changed

Use default_locale if it's present, and navigator's language otherwise.

LGTM, Thanks for the effort!


feat(bottomnavigationbar) persist badge on pressed/selected

Currently the badge is removed when the tab is pressed or selected.
I suggest we leave it up to the user to determine when to clear the badge. There's the case where the badge is showing a notification count that may change when reading/clearing notifications. Without this, we have to repeatedly show the badge during navigation.

@lochstar i agree but it is a breaking change. I suggest to add a autoClearBadge property and default it to true to prevent breaking change for users.

@farfromrefug I'm having a bit of trouble getting the demo apps to run.
Can we merge this as is and I will create a separate PR for the badge property. Turns out only iOS supports stings, so I will keep it as a number only.


Prepare for new release of Bitbucket

Workflow links: https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/750727868, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/750728809.

Integration tests have passed for the new Bitbucket version and compatibility on Marketplace was updated accordingly.


Is it possible to obtain results for more than 15 products?

I am only able to get results of 15 products when I perform a search, even though I have set max_product_nb to a value greater than 15. Performing a manual search using the same keyword returns over 100 products on the amazon.com website. I'll appreciate any comments. Thank you.

Same problem here :(
It seems that Amazon may have changed the layout of the page.
We'll keep you updated.

Thx

I've noticed using a basic python scrapy code that SPONSORED products that are dynamically pulled via java script are not being extracted... If you found a solution that would be great

I've noticed using a basic python scrapy code that SPONSORED products that are dynamically pulled via java script are not being extracted... If you found a solution that would be great

That one works https://github.com/drawrowfly/amazon-scraper


Add story  --git-branch-standard

As per #38, unfortunately, it is not possible to get the user's mention
name from the api since the request to the /user endpoint is forbidden
if you are using an API Token.

Released in v1.9.0


Go to page UI

Hi, I really like your project and I'm trying to use it for work.
I need additional functions that allow me to easily move to a specific page. and I found a function updatePage().
But I thought it would be nice to exist as an official prop too, so I left an issue.

@nupamore please update to the latest version 1.4.18, then you can use current-page prop to set certain initial current page number
<DataTable
   :headers="headers"
   :items="items"
   :current-page=2
/>


Lock down versions in gemspec

I am considering changing all of the versions specified in the gemspec so be explicit rather than range based.
Initially I wondered if reveal-ck might sit in the same Gemfile as something like middleman, and middleman could produce a website while reveal-ck produced slides.
However-- I don't think anyone is using it like that, and the "range" operators on the libraries produces a maintenance problem. In effect-- reveal-ck can be though of an "application" rather than a "library," and so, the benefit of using range operators is lost.
Because it's an application, we'll instead lock in the versions of libraries that are verifiably working and then do incremental updates (which will be verified before working).
The attempt to work with "many libraries" has caused (or is suspected (by me) of causing) somewhere around 5-10 issues, and so, this should be helpful.

If you are a reveal-ck user that relies on the "range of included libraries" please speak up.
Thanks!

This has begun.
You can see progress over here: https://github.com/jedcn/reveal-ck/pull/37

This was done with release 3.0.1. You'll see all of the Runtime Dependencies are "=" signs now, and not ranges.
https://rubygems.org/gems/reveal-ck/versions/3.0.1


Add carbon default values as parameter to create_resources

Hello:
This allows default values to be passed in for carbon blocks, and it is useful in the event that you have many unique carbon backends.
Critique welcome.
Inspiration taken from https://github.com/jfryman/puppet-nginx/blob/master/manifests/init.pp#L300

Thanks for the contribution!


Rename project

Goals are:

simple to learn
easy to extend
fast by default

Rename this something less generic

Changing the name to Mana.

PHP Mana does not return any significant search engine results.

mana | ˈmɑːnə |
noun [mass noun]
(in Polynesian, Melanesian, and Maori belief) an impersonal supernatural power which can be transmitted or inherited.
This relates well with transmission between server and browser, and between code and the framework.

Fixed by #72


Add strip_bbcode() method to String

Adds a function to strip bbcode tags out of strings.
Example Code:
var s = "[color=#ffffff]Hello![/color]
print(s.strip_bbcode())

Result: Hello
Closes https://github.com/godotengine/godot-proposals/issues/5056

Sorry for that, I made the mistake of putting new changes on the same branch as this PR.

Any update on this? Since I was silly and didn't correctly branch from master, it means I can't submit my other PR about re-adding the center window function.

Any update on this? Since I was silly and didn't correctly branch from master, it means I can't submit my other PR about re-adding the center window function until this one is gone.

Accepting the pull request is a random process - sometimes it takes years to be accepted, in general if you have such problem - there is no shame to close the PR and then re-open a fixed version.


Typescript 4.1

It seems not to work with Typescript 4.1. The stack trace refers only to typescript paths but disabling the plugin in storybook has made it pass.
70% sealing React Docgen Typescript Plugin /Volumes/unix/.../node_modules/typescript/lib/typescript.js:2229
        return str.lastIndexOf(prefix, 0) === 0;
                   ^

TypeError: Cannot read property 'lastIndexOf' of undefined
    at Object.startsWith (/Volumes/unix/workplace/.../node_modules/typescript/lib/typescript.js:2229:20)

Could you provide a reproduction repo? None of the libraries (this plugin + react-docgen-typescript) directly depend on typescript. You should be able to edit the yarn.lock file to make sure only 1 version is present in your project


Http handler breaks websocket handlers

When the Deferpanic handler is used for wrapper of x/websockets handlers, the DP client breaks the protocol.

closing for now -> https://github.com/deferpanic/deferclient/commit/b4be079c5e4311de2f349cf1c7052ea67f44d76d


Question: synchronous read by key?

Hi, cool project!
I evaluate storage options for an existing project where we must keep backward compatibility and need a way to fetch data synchronously by a key.
So curious is it (at least theoretically) possible to have a sync method for reading by a key with existing architecture (even with perf penalty)?

They thanks!
Yes, you'd need to slightly restructure the get method and make sure you open the database with mainThread set to true.


Update registry-cache jobs to<EMAIL_ADDRESS>

/kind enhancement
What this PR does / why we need it:
Related PR on registry-cache side - ref https://github.com/gardener/gardener-extension-registry-cache/pull/139.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A

/approve