Fixed bad merge

Pull requests #505 and #474 got merged incorrectly. This fixes it.

Codecov Report

Merging #518 into master will decrease coverage by 0.01%.
The diff coverage is 98.70%.

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.02%
==========================================
  Files         215      214       -1
  Lines        7437     7389      -48
==========================================
- Hits         6972     6926      -46
+ Misses        465      463       -2

Flag
Coverage Δ

#dotnet
93.73% <98.70%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Bicep.Core.IntegrationTests/PrintVisitor.cs
100.00% <ø> (ø)

src/Bicep.LangServer/SemanticTokenVisitor.cs
0.00% <0.00%> (ø)

src/Bicep.Core.IntegrationTests/ParserTests.cs
100.00% <100.00%> (+1.75%)
:arrow_up:

...cep.Core.UnitTests/Parser/ExpressionTestVisitor.cs
100.00% <100.00%> (ø)

src/Bicep.Core/Parser/Parser.cs
94.24% <100.00%> (+0.05%)
:arrow_up:

src/Bicep.Core/Parser/Token.cs
100.00% <100.00%> (ø)

src/Bicep.Core/Syntax/SkippedTriviaSyntax.cs
100.00% <100.00%> (ø)

src/Bicep.Core/Syntax/SyntaxVisitor.cs
100.00% <100.00%> (ø)

...cep.LangServer.IntegrationTests/DefinitionTests.cs
100.00% <100.00%> (ø)

...icep.LangServer.IntegrationTests/HighlightTests.cs
97.50% <100.00%> (ø)

... and 5 more


Fix memory leak

After running this in production for some time, I found that sidekiq workers were running out of memory and crashing.
Finding memory leaks is hard, but I found the method described in https://gist.github.com/krasnoukhov/a036bb7bc8c8416e9481 to be extremely helpful.
The small change in https://github.com/mkcode/remote-resource/commit/776a0646ba1d962c67f518e6fb7e41b62330e3e9, using the object's singleton_class rather than class, brings the retained memory down to almost nothing.
That small change caused a race condition that a ruby vm crash. All C methods in ruby (which module_eval is) are consider to not safe. The fix for this is ripped from ActiveRecord, and how they create their attribute methods: https://github.com/rails/rails/blob/b6429b871ff8b73ebd10076ead6ed2c1f651da86/activerecord/lib/active_record/attribute_methods.rb#L55-L66
I was able to reliable test the thread safety be bringing sidekiq's concurrency up to 50 (the recommended max). It failed overtime before https://github.com/mkcode/remote-resource/commit/ce47626ce978a120be38d7920a61d6be5ff16f7d, and I could not get it fail after.

Use version 0.1.2 to get the PR


Events need a results landing page

We should really reimplement the old-site-style top-10 in every category results page, and make it the landing page for completed events.

Related to #1008

/results should exist as a synonym for /games, but the intention is that the better results page goes there.


navigateTo has no effect when a plugin is declared

Environment

Operating System: Darwin
Node Version:     v16.15.1
Nuxt Version:     3.0.0-rc.8
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      runtimeConfig, css, vite, typescript, modules, unocss
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://codesandbox.io/s/nuxt-3-navigateto-with-usefetch-15ihel
Describe the bug
To intercept every 401 error I receive from my API, I created a wrapper method of useFetch :
export function useApi(request) {
  return useFetch(request, {
    async onResponseError(ctx) {
      if (ctx.response.status === 401) {
        await navigateTo("/login", { replace: true, redirectCode: 401 });
      }
    }
  });
}

But somehow, it only works if I don't have any plugins declared.
If you comment every line of this file, the redirection works well, but as long as the defineNuxtPlugin function is called, the redirection does not work. Why ?
Additional context
No response
Logs
No response

@pi0, I've encountered an issue that I could use your help with. Everything seems to be perfect, but I'm running into an error on the pages/index.vue page when I try to reference a user attribute. I thought the redirection was supposed to take place before the template generation, right? Additionally, I'm curious if callWithNuxt functions the same as nuxtApp.runWithContext. Your insights would be greatly appreciated! Thank you.
https://codesandbox.io/p/sandbox/nuxt-3-navigateto-with-usefetch-forked-r4rz6m


Run flutter update-packages --force-upgrade.

Description
I ran flutter update-packages --force-upgrade, in order to bump up the version of flutter_gallery_assets to 0.2.1, to reconcile with the version used in flutter/gallery.
This PR contains the changes made to all .yaml files after running the command.
This change is required for the following PRs:

Add Web Benchmarks for Flutter Gallery (Flutter Side)
Add Web Benchmarks for Flutter Gallery (Gallery Side)

I decided to submit this as a separate PR, so that the version changes won't clutter the changes I make for the 2 PRs above.
Related Issues
https://github.com/flutter/gallery/issues/103
Tests
This is a version update. It does not require tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] ~I updated/added relevant documentation (doc comments with ///).~

This is a version update. It does not require documentation.

[ ] ~All existing and new tests are passing.~

This is a version update.
I only ran tests in packages/flutter/test/. They all passed.
tool_tests-commands-{linux,macos,windows} are failing.

[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.

This is a version update.
I only ran tests in packages/flutter/test/. They all passed.
tool_tests-commands-{linux,macos,windows} are failing.

@jonahwilliams could you please assist @pennzht with this PR? The tools tests are failing to run pub get for some reason.

The error is
Because test >=1.13.0 <1.14.5 depends on test_api 0.2.15 and every version of flutter_driver from sdk depends on test_api 0.2.16, test >=1.13.0 <1.14.5 is incompatible with flutter_driver from sdk.
So, because flutter_project depends on both flutter_driver any from sdk and test 1.13.0, version solving failed.

@jonahwilliams said:

you need to update https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L49
possibly other lines in the pubspec.yaml

@jonahwilliams said:

you need to update https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L49
possibly other lines in the pubspec.yaml

@Hixie Shouldn't flutter update-packages --force-upgrade do this automatically?

no, thats why we have the test

@jonahwilliams

no, thats why we have the test

Thank you very much for your message!
How should we resolve this issue (without breaking more tests)?

If we pin the test package in the Flutter SDK, should we just be depending on the test package as any instead of with a fixed version? It seems like having a fixed version here means that we'll be making life harder on developers to upgrade Flutter later.

We could also give it a caret ^. I think any dependencies should probably be avoided unless a user is specifically experimenting, so I'd be worried that adding it to the template would precipitate a bad practice


general build layout

We should take decision how we want the build layout to look like. In general there are two ways we could go:

Single monolithic build.gradle at the top level that contains everything
Small individual gradle subpojects for the languages, tests, packaging is with a modular layout

monolithic layout
Easier to understand because every thing is in a single file. Not even much knowledge about how gradle projects and their dependencies work is required to understand the build. It's simply a single script with a bunch of tasks and dependencies.
While it looks easy to understand at first glance it can be hard to understand at some pointer because these layouts tend to get messy. When you have a 500+ line build script things might be hard to understand as well.
modular build
Might be frighting to people with no gradle knowledge. Things can seem like magic because everything is in different files.
Much cleaner and small build scripts with a clear focus. They only declare dependencies and apart from the have single purpose they act on.
We would need at least this individual build projects:

all scripts
languages
tests
RCP
packaging

What is the difference between the RCP and packaging  projects?

Yes right, the packing job would package the plugins in a format that you can upload to they nexus or to plugins.jetbrains.com
And the RCP would really build a RCP with branding and MPS parts etc.
Maybe it would make sense to have two templates in the repository one that is really simple without a RCP that uses the monolithic approach. This could be useful for small projects or plugins that are distributed for MPS. And a second one that uses the modular approach. Which is more useful for projects that build a full blown RCP etc.
Maintaining both shouldn‘t be that much more effort I guess.


Enable whole show / season processing for bw_plex process

Currently, using bw_plex process --name foo requires the user to select an episode at the Select episodes: prompt. I did not find a way to enable the possibility to process all listed episodes.
A nice feature would be the ability to process a whole season.

The select support python slicing. The format is start, end, step
So say you want all episodes you just do ````::`````instead of a number.


Add support to %Cyanide.Binary{} when encoding binaries

{subtype_int, binary} wasn't handy, use %Cyanide.Binary{} for binaries
instead.
TODO: Use %Cyanide.Binary{} also when decoding.

Coverage decreased (-1.4%) to 98.592% when pulling c14715b1fbd45862e853ca3df3b85d1439b56ee5 on bettio:use-struct-for-binaries into 0a8e2edf350e2c646ebbbe016628a368dd504fb8 on ispirata:master.


feat(ssr): generate more useful names for imported modules

Description
Instead of using ___vite_ssr_import_1__ as the module identifier, use the basename of the import specifier like import_react and append a number if collisions occur. This makes debugging easier, as you don't have to guess which module is which, and the import_ prefix makes discovery easy.
Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

The newly merged export * as's test might also need to be changed.

What if these names collide with user names? Should the name at least be __vite_import_react or __import_react to play safe here?


Add "View file at this commit"

When I'm view a file's blame annotations, I sometimes want to trace back the history of a particular line.  So I can "compare line revision with previous", but that only tells me the last change on the line.  What would be nicer is if I could view the file at that commit revision, then use the regular functionality on that revision of the file.  So I could view blame annotations for that file's revision, then view the file at the commit revision for the last change on the line then, and so on.  That way I could trace back all the changes made for a particular line (as well as the state of the whole file at each change).

There should also be a "View file at parent commit" option actually, as to trace back the history of a line you want to be able to open the file at the commit just before it was changed, and then view blame annotations for that version.

@jez9999 If you use the Compare Line Revision with Previous command, the diff presented is the differences in the whole file for that commit. And you can keep walking back from the left-side of the diff further into the history -- and blame annotations are available inside each diff pane.
Are you asking for something else?

How do you "keep walking back from the left-wide of the diff further into the history"?

No response on this.  I think my original issue remains.

@jez9999 Sorry for the lack of response here. You can use the alt+, shortcut to open a diff with the previous revision -- see here: https://github.com/eamodio/vscode-gitlens#powerful-comparison-tools

I'm going to assume this answered the question -- please re-open if there is still an issue.


Compilation sometimes takes ages

I'm not quite sure what this is, but sometimes the compiler will take forever to compile a larger file (skip-stack-guard-page, f32, f64 all being good examples).
It would be good to profile and see what's up with this.

More notes to myself. I've done constant propagation now -- and still skip-stack-guard-page takes forever. This is because all of the locals are still let-bound to start. They are all redundant loads --- which we're forbidden to optimise away.
I hypothesise again that by doing a form of DCE where we bind all of the redundant loads to the same variable, so that they still occur, but without creating new variable names, we can solve this.

I'm marking this as complete as of e62285ee29b6009d4798e6e51a1e10a373ad54d9. There's still work to do, but larger programs are at least tractable now.


:wrench:  prepare release 1.9.2

Description
Prepare release 1.9.2
Checklist

[ ] My changes follow the contributing guidelines of this project.
[ ] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my changes work.
[ ] New and existing unit tests pass locally with my changes.

Coverage remained the same at 94.517% when pulling 3fe3b847ad60222814e8d473dc45594ad94aa0da on release/1.9.2 into 4939f0855138dafd4ff7eef84221e76618258912 on main.


Nightwatch Screenshot directory: Error: ENOENT - testarmada-magellan-nightwatch-plugin 8.0.8

Error in creating Nightwatch Screenshot directory: Error: ENOENT: no such file or directory, mkdir
[INFO] [Nightwatch Plugin] Updating Test Settings with Screenshot Config: {"desiredCapabilities":{"browserName":"chrome"},"nightwatchEnv":"chrome","id":"chrome","executor":"local","screenshots":{"enabled":true,"on_failure":true,"on_error":true,"path":""}}

Seems it's ignoring test_settings.default.screenshots which I'm trying to set enabled: false here. The issue does not happen if I revert from 8.0.8 to 8.0.3

@chiahrens ^^

reverted code back to 8.0.3 and released 8.0.9


Trainging Epochs

How many epochs does the task need to train to complete?
I trained 1000 epochs with the data I collected, but the results were poor.And trained 500 epochs with your dataset, and the results are also very poor.

Do you get good results with the checkpoint we provided? If yes, then there might be a config problem (images might not be pre-processed correctly or so). For testing, I recommend to use a circular track (both in simulation and in the real world) similar to what we used in our experiments (https://youtu.be/vdxB89lgZhQ?t=51).

There is no provided pretrained checkpoint file.
So, I got the error:
NotFoundError: /home/control02/drone_racing_ws/catkin_ddr/src/sim2real_drone_racing/learning/deep_drone_racing_learner/src/ddr_learner/results/best_model; No such file or directory


Refactored cfbs add and cfbs.json handling

Thank you for submitting a pull request! Maybe @vpodzime can review this?

Since there are no blockers I will merge and address comments in a follow-up PR.

And I wonder if this fixes #91 ?

@vpodzime it does not.


Datagrid not destroying row scopes when grid is child of isolate scope (component).

The issue seems to be that when we do use an isolate scope the $$destroyed property is not set on the new scope so it goes up the prototype chain to the highest level of the isolate scope to get this property. Since at this point the parent is already destroyed, it's skipping the destroy on all of the row scopes as it thinks they are already destroyed.
This seems to fix the issue but I wanted to check with you guys to see if there is a better way and/or something that we haven't thought of.
`function compileRow(index, el) {
var s = scopes[index], currentRow;
if (s && !s.$parent) {
s.$parent = scope;
}
if (!s) {
// fixes a bug expanding the last row and trying to scroll to it.
if (!scope.$$childTail && scope.$$childHead && scopes[index - 1]) {
scope.$$childTail = scopes[index - 1];
}
        s = scope.$new();

        // if the parent scope is isolate then the new scope will use prototypial inheritence
        // to get this property during the destroy phase. the issue is at the point of destruction
        // the parent scope has already been destroyed so it will bypass the destroy phase for this scope.
        // setting it to false will ensure that it does not go up the prototype chain and properly maintains the state
        // whether it has been destroyed.
        s.$$destroyed = false;

        //s.$on('$destroy', function() {
        //   console.log('DESTROY ' + s.$id + ' index:' + s.$index);
        //});
        processCompilation(s, index, el);
    } else if (s && (currentRow = getExistingRow(index)).scope() !== s) {
        // after rows are destroyed (memory optimizer) then they need to be recompiled.
        processCompilation(s, index, currentRow);
    }
    return s;
}`

I like your solution. I think it works well. I was worried about it causing an infinite loop but I don't think so because it will now have the false set locally to just that scope and should set the true there as well. I think it is a very good solution.

Thanks for the catch Ryan. Great to hear from you again. 👍 It is published as 1.6.13.

Sweet! Shoot me a note at my first and last name at gmail so I can get your latest email address! I wanna catch up and see how everything is going! The one on your github account is bouncing back.

Thanks, yes I forgot to update that email. :) talk to you soon.


Crimson Ed cease and desist

This project is too similar to product at red education, please cease and desist.

Closing as we have pivoted to calendar NFTs


Migrate stops without error

Hi,
I've backuped some email accounts via backup command in mirror mode. For testing purpose I tried to restore some bigger accounts (more than 5 GB) via migrate command into a temporal test account. Unfortunately it aborts, although the current folder and a lot of others folders, were not restored. Sometimes with and sometimes without any error message.

First try: Stop's without any error message. I noted, that the uid e.g. 10278 is not in sync with the counter e.g. 10271/13587.
~/imap-backup $ ./imap-backup.sh migrate<EMAIL_ADDRESS><EMAIL_ADDRESS>--reset --verbose
...
D, [2024-06-09T07:46:07.867108 #1] DEBUG -- : [Gesendet] uid: 9230 (9225/13587) - 76045 bytes
....
...
D, [2024-06-09T07:53:15.433479 #1] DEBUG -- : [Gesendet] uid: 10277 (10270/13587) - 4070463 bytes
D, [2024-06-09T07:55:28.537342 #1] DEBUG -- : [Gesendet] uid: 10278 (10271/13587) - 1414207 bytes
~/imap-backup $

Second try: With second --verbose
~/imap-backup $ ./imap-backup.sh migrate<EMAIL_ADDRESS><EMAIL_ADDRESS>--reset --verbose --verbose
...
C:
C:
S: * 9992 EXISTS
S: * 9992 RECENT
S: RUBY10671 OK [APPENDUID<PHONE_NUMBER> 31382] Append completed (0.098 + 0.217 + 0.096 secs).
D, [2024-06-08T21:47:49.482746 #1] DEBUG -- : [Gesendet] uid: 10000 (9993/13587) - 6286394 bytes
~/imap-backup $

Third try: Also I tried to restart the migration. For that I used the same migrate command, without reset option. But in that case, it's ends with duplicate mails. For example my archive contains 661 emails, and 1322 emails afterwards.
~/imap-backup $ ./imap-backup.sh migrate<EMAIL_ADDRESS><EMAIL_ADDRESS>--verbose
....
D, [2024-06-08T19:22:03.015870 #1] DEBUG -- : Creating IMAP instance: domain.com, options: {:port=>993, :ssl=>{:min_version=>771}}
D, [2024-06-08T19:22:03.288483 #1] DEBUG -- : [Archiv] 661 to migrate
D, [2024-06-08T19:22:03.288974 #1] DEBUG -- : [Archiv] uid: 1 (1/661) - 40732 bytes
D, [2024-06-08T19:22:03.774696 #1] DEBUG -- : [Archiv] uid: 2 (2/661) - 41652 bytes
D, [2024-06-08T19:22:04.050382 #1] DEBUG -- : [Archiv] uid: 3 (3/661) - 37830 bytes

PS: Note: I'm using imap-backup within docker container including a wrapper script. I will do some tests without docker as next step.
Who can help?

I also run into trouble on my MacBook, where I've installed imap-backup via home-brew. After the very huge sent folder with over 13.000 emails, were uploaded, it hangs up in the next folder. Now the program just hangs, so that I need to cancel it after long time without any progress.
....
D, [2024-06-09T19:42:45.692934 #80238] DEBUG -- : [INBOX/Avisen] uid: 56 (56/244) - 44285 bytes
D, [2024-06-09T19:42:45.977402 #80238] DEBUG -- : [INBOX/Avisen] uid: 57 (57/244) - 36568 bytes
D, [2024-06-09T19:42:46.261995 #80238] DEBUG -- : [INBOX/Avisen] uid: 58 (58/244) - 18641 bytes
D, [2024-06-09T19:42:46.553522 #80238] DEBUG -- : [INBOX/Avisen] uid: 59 (59/244) - 31520 bytes
D, [2024-06-09T19:42:46.846000 #80238] DEBUG -- : [INBOX/Avisen] uid: 60 (60/244) - 74774 bytes

Hi @martinpichlo
Thanks for opening this issue.
I suspect that there is a large email after uid 60 that is taking a long time to upload. Could you check network activity?
Also, please activate network logging with --verbose  --verbose to see if there are any clues there.


[Enhancement] Add acl request code to the permission verification for the admin role

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
Add the request code UPDATE_GLOBAL_WHITE_ADDRS_CONFIG = 53 to the permission verification for the admin role
Motivation
Add the request code UPDATE_GLOBAL_WHITE_ADDRS_CONFIG = 53 to the permission verification for the admin role
Describe the Solution You'd Like
Add the request code UPDATE_GLOBAL_WHITE_ADDRS_CONFIG = 53 to the permission verification for the admin role
Describe Alternatives You've Considered
No
Additional Context
No response

What's the purpose of this feature? Whether it is the admin role should be determined by other means.

If the ACL function is enabled and the client is assigned common user role, the client can modify the global whitelist configuration through this api to obtain super rights.  Therefore, I believe that the modification permission of this api needs to be verified for the admin role.
related issue 7929


Fixes #2279 Mapl3/tclune/#2729 mirror vertical dim

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description
Related Issue

I failed to document some details in the PR.   I added 2 new params for VERTICAL_DIM_SPEC:
   type(VerticalDimSpec), parameter :: VERTICAL_DIM_UNDEF = VerticalDimSpec(-1)
   type(VerticalDimSpec), parameter :: VERTICAL_DIM_NONE = VerticalDimSpec(0)
   type(VerticalDimSpec), parameter :: VERTICAL_DIM_CENTER = VerticalDimSpec(1)
   type(VerticalDimSpec), parameter :: VERTICAL_DIM_EDGE = VerticalDimSpec(2)
   type(VerticalDimSpec), parameter :: VERTICAL_DIM_MIRROR = VerticalDimSpec(3)

For now the default is still VERTICAL_DIM_NONE.  I think it should be changed to VERTICAL_DIM_UNDEF, but that will require a number of updates to yaml files for Test Scenarios.  Thus did not put in the current PR.


Refactor codebase to async/await - m365 pp dataverse until m365 pp managementapp, Closes #4992

Refactoring of the commands from m365 pp dataverse until m365 pp managementapp

m365 pp dataverse table get
m365 pp dataverse table list
m365 pp dataverse table remove
m365 pp dataverse table row list
m365 pp dataverse table row remove
m365 pp environment get
m365 pp environment list
m365 pp gateway get
m365 pp gateway list
m365 pp managementapp add
m365 pp managementapp list

Closes #4992

Thank you for this enhancement! We'll try to review it ASAP!

ready to merge

@nicodecleyre I will mark this as draft so that we won't overlook one little comment we could also include 👍

ready to merge 🚀.
Not to me

Refactor one small detail when merging 👍

merged manually. Awesome work 👏


impact Build issue with multiple project.

Hello,
With multiple projects impact build detect change in all projects and try to compile it.
example : You've got two project A & B with PLI in both. If you change a file in project B then when you build project A then PLI file  changed from project B is build in project A.
To avoid this i made this change in file impactUtilities.groovy (tag 2.4.0) line 411 :
                if ( !matches(file, excludeMatchers)) {
                                    if ( buildUtils.getAbsolutePath(file).startsWith(dir.toString())) {   /// <<<< ADD THIS LINE
                                      changedFiles << file
                                      if (!calculateConcurrentChanges) githashBuildableFilesMap.addFilePattern(abbrevCurrent, file)
                                      if (props.verbose) println "**** $file : " + buildUtils.getAbsolutePath(file)
                                    } /// <<< ADD THIS LINE

}

Hi @marvin42-fr ,
Thank you for reporting your finding. I think, I am not understanding the problem to 100% which you encountered.
If you are pulling in dependent repositories - let's say projectB into your build workspace for building projectA and invoke the impactBuild, you should rather consider the scoping through the applicationSrcDirs - see https://github.com/IBM/dbb-zappbuild/blob/main/samples/application-conf/application.properties#L16
We had published some strategies in here on how to configure it at https://www.ibm.com/support/pages/node/6381788
Wondering, if this is a actual defect in the build framework implementation of zAppBuild or a misunderstanding in the configuration.
Dennis

Hi Denis,
I review your strategies but it doesn't apply for us. We are using this stratgies to manage commons include and common progs but it's not the case here.
We split applications in multiples projects  for two reasons :
#1 regroup "business functions" & to manage different compilations options for the same language in the same application (batch,Tp,IMS,CICS,MQ & DB2).
#2 to manage a large amount of sources files in IDZ (too many files in single project lead to a non responsive IDE due to a lack of memory in our company workstations).
It look like this :

As you can it use the same repository so same root folder for each project.
Eric.

Sorry Eric, that the issue you have raised went quiet. I already took my summer vacations and just got back, and noticed, that this is still open.
Now, I understand your scenario. Let me try to recreate it. Looks like, that the multiple folders within the repo caused an issue in your build process, am I right?

Hi Eric,
I just tried to recreate the issue, with multiple folders in the same repo.  However, unfortunately, I don't see any issue with it. I went back to the original request, but also missed the problem statement (either no impacts found or too many impacts found).
Here is what I have configured: There is a single repository, which is named App-EPSM (unfortunately). It includes two "project" subfolders which both contain cobol source and copybooks:
/App-EPSC
/App-EPSM
/application-conf

I had changed a copybook in the App-EPSC component, which is also used in the App-EPSM component.
** --impactBuild option selected. Building impacted programs for application App-EPSM
** Getting current hash for directory /var/jenkins/workspace/App-EPSM/App-EPSM
** Storing App-EPSM : 8ee64345aaa2e00a49f96eedbd00347009d1688c
** Getting current hash for directory /var/jenkins/workspace/App-EPSM/App-EPSC/copybooks
** Storing App-EPSC/copybooks : 10912e03cf180c1a6a4bed889539828afc4ea8ea
** Getting baseline hash for directory /var/jenkins/workspace/App-EPSM/App-EPSM
** Storing App-EPSM : 11ddea50f00df85ee8af358987a8a1048ea2c30b
** Getting baseline hash for directory /var/jenkins/workspace/App-EPSM/App-EPSC/copybooks
** Storing App-EPSC/copybooks : 10912e03cf180c1a6a4bed889539828afc4ea8ea
** Calculating changed files for directory /var/jenkins/workspace/App-EPSM/App-EPSM
** Diffing baseline 11ddea50f00df85ee8af358987a8a1048ea2c30b -> current 8ee64345aaa2e00a49f96eedbd00347009d1688c
*** Changed files for directory /var/jenkins/workspace/App-EPSM/App-EPSM :
**** App-EPSC/copybooks/epsnbrpm.cpy

The Impact Analysis calculation correctly identifies the 3 files with a dependency to the copybook.
*** Perform impacted analysis for changed files.
** Performing impact analysis on changed file App-EPSC/copybooks/epsnbrpm.cpy
*** Creating impact resolver for App-EPSC/copybooks/epsnbrpm.cpy with [{"library": "SYSLIB", "searchPath": [ {"sourceDir": "/var/jenkins/workspace/App-EPSM", "directory": "App-EPSM/copybooks"}, {"sourceDir": "/var/jenkins/workspace/App-EPSM", "directory": "App-EPSM/copybooks-public"}, {"sourceDir": "/var/jenkins/workspace/App-EPSM", "directory": "App-EPSC/copybooks"} ]                },{"library": "SYSLIB", "searchPath": [ {"sourceDir": "/var/jenkins/workspace/App-EPSM", "directory": "App-EPSM/bms"} ]             },{"category": "LINK", "searchPath": [ {"sourceDir": "/var/jenkins/workspace/App-EPSM", "directory": "App-EPSM/link"} ]             }] rules
** Found impacted file App-EPSM/App-EPSM/cobol/epsmlist.cbl
** App-EPSM/App-EPSM/cobol/epsmlist.cbl is impacted by changed file App-EPSC/copybooks/epsnbrpm.cpy. Adding to build list.
** Found impacted file App-EPSM/App-EPSC/cobol/epscmort.cbl
** App-EPSM/App-EPSC/cobol/epscmort.cbl is impacted by changed file App-EPSC/copybooks/epsnbrpm.cpy. Adding to build list.
** Found impacted file App-EPSM/App-EPSC/cobol/epsnbrvl.cbl
** App-EPSM/App-EPSC/cobol/epsnbrvl.cbl is impacted by changed file App-EPSC/copybooks/epsnbrpm.cpy. Adding to build list.
** Calculation of impacted files by changed properties has been skipped due to configuration.
** Writing build list file to /var/jenkins/workspace/App-EPSM/outputs/build.20220803.041014.010/buildList.txt
App-EPSM/App-EPSC/cobol/epscmort.cbl
App-EPSM/App-EPSC/cobol/epsnbrvl.cbl
App-EPSM/App-EPSM/cobol/epsmlist.cbl

A few questions:

Was your collection probably containing broken dependency data?
Or do you have different resolution rules? Please be aware of the new SearchPathFinder and Dependency APIs!

If you believe, it does not require any further investigation, please let me know and we can close this issue.

Hello Denis,
My projects are organized like this :
/App-EPSC/application-conf
/App-EPSM/application-conf
because we have some specific application configuration for each project.
In this case if i run a build for only App-EPSC  then if something changed in App-EPSM then impact build will compile App-EPSM cobol file also.


Experiment with and store etag to make refresh more efficient

The GitHub api appears to have a way of retrieving whether a file has changed or not without using up a rate limit. https://developer.github.com/v3/#conditional-requests
Use this to make refresh more efficient (skip updating files with no updates) and use less rate limit.

A bit more info:
It doesn't look like the github mylyn library supports conditional requests.
However, a second library claims to http://github-api.kohsuke.org/ although it bears more investigation.

A few more comments: the above library claims to support caching, but in practice it seems to point to an old version of OkHttp and their example doesn't seem to compile properly.
For future looks at this possibility:

http://mvnrepository.com/artifact/com.squareup.okhttp/okhttp-urlconnection is required
Keep an eye on the library for updates to okhttp support


MOD variables replaced by TYPE

Old references to "module" are replaced by "type"

The conflict is now resolved


Conditional prompt questions

I have a list prompt in the question, choices are A and B. I want to show the following 2 prompts when user chose A and to show the next following 2 question when user chose B, how to do this?
It seems that vue-cli doesn't support functional when? In the following code, I just return false in when function, but it still prompts.
when: function (answer) {
  return false
}

You should be able to do when: 'lint === true'
ref https://github.com/vuejs/vue-cli#conditional-prompts

The doc doesn't tell this function, I'll try it.


How can i choise language

We have transChoice in your example repo, then how can i choose language?

Hello darkterminal,
In the example the language was set in bootstrap.php and did not allow for a way to dynamically change the language.
I have therefore expanded the example to show how the language can be switched by the user.
The language for the translator is now set using middleware (LocaleMiddleware).
The base template includes a template that adds links to the same page in different locales, see app/templates/_locale.html.twig. Using these links the user can switch the locale.
Each route starts with the locale, e.g. "/en/home" or "/nl/home", so the locale can determined from the path. In the current set up you can switch to the same page in a different locale. Another strategy would be to go to homepage of the selected locale if not all pages are available in all locales.

Great! Thanks for Answer @llvdl
But i have modify my code using $_SESSION to set Locale Language using Hyperlink.


Marshal to type

I split this into a few commits to make it clear that I'm mostly using old code (with fixes) to get the noms type from a go type.
The tests were derived from the marshal tests.

Codecov Report

Merging #3221 into master will increase coverage by 0.04%.
The diff coverage is 91.54%.

Impacted Files
Coverage Δ

go/marshal/encode.go
98.16% <100%> (+2.41%)
:white_check_mark:

go/marshal/encode_type.go
91.04% <91.04%> (ø)

go/nbs/table_reader.go
94.69% <ø> (ø)
:white_check_mark:

go/datas/http_batch_store.go
88.05% <ø> (+0.62%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1afbb9...b617580. Read the comment docs.


Showcase Angular Title service

Show how we can automatically update it through data within a Route.
Updated Root App Component, subscribing to NavigationEnd event and changing Title through MetaService when route finishes changing.
Currently only works in Browser, as we're not supplying the entire Html document. We'll have to look into fixing this later.
import { Component, ViewEncapsulation, Inject, OnInit, OnDestroy } from '@angular/core';
import { Router, NavigationEnd, ActivatedRoute, PRIMARY_OUTLET } from '@angular/router';
import { Title } from '@angular/platform-browser';
import { Subscription } from 'rxjs/Subscription';
import { isBrowser } from 'angular2-universal';
import { Meta } from 'app-shared';
import 'rxjs/add/operator/map';
import 'rxjs/add/operator/mergeMap';
import 'rxjs/add/operator/filter';

@Component({
    selector: 'app-root',
    template: `
        <div class="container-fluid">
            <app-nav-menu></app-nav-menu>
            <router-outlet></router-outlet>
        </div>
    `,
    styleUrls: ['./app.component.css'],
    encapsulation: ViewEncapsulation.None
})
export class AppComponent implements OnInit, OnDestroy {

    private defaultPageTitle: string = 'Angular Universal & ASP.NET Core Starter';
    private sub: Subscription;

    constructor(
        public router: Router,
        public activatedRoute: ActivatedRoute,
        public meta: Meta
    ) {}

    ngOnInit() {
        // Change "Title" on every navigationEnd event
        // Titles come from the data.title property on all Routes (see app.routes.ts)
        this.changeTitleOnNavigation();
    }

    ngOnDestroy() {
        // Subscription clean-up
        this.sub.unsubscribe();
    }

    private changeTitleOnNavigation () {
        this.sub = this.router.events
            .filter(event => event instanceof NavigationEnd)
            .map(() => this.activatedRoute)
            .map(route => {
                while (route.firstChild) route = route.firstChild;
                return route;
            })
            .filter(route => route.outlet === 'primary')
            .mergeMap(route => route.data)
            .subscribe((event) => {

                // Set Title if available, otherwise leave the default Title
                const title = event['title']
                    ? (event['title'] + ' - ' + this.defaultPageTitle)
                    : this.defaultPageTitle;

                // Temporarily only do this in the Browser
                // Until we can get entire Html doc (this is a .NET issue since we never pass the entire Document (only root-app))
                return isBrowser ? this.meta.setTitle(event['title']) : '';
            });
    }

}

Hi, the title doesn't seem to be changing when switching pages from the nav menu. I tested on the latest commit (93d54b2647879380960f77c15d9725b64cf86d5a).
I am saying this because I thought this was fixed, or did I think wrongly?
Thanks.

Do you have JS disabled?
Or is it happening client-side when normally going around the App in the browser?
Only ask about JS being disabled because the server changing the Title isn't working just yet, but hopefully very soon! Working with Steve to see if the Prerender tag can somehow pass things to a ViewData so we can set Title/meta that way (since we made .NET have all the control over the .
Anyway let me know! Got a fresh copy, seems to be working client-side at least though.

I am finding this feature working :)
No problem with this 🥇

My JS is enabled and it is happening client-side when normally going around the app in the browser.
I pulled down a fresh copy, I used NodeJS 6.9.4 and .NET Core 1.1.
I expect the title in the browser tab to change, but it does not.
I even tried it on another computer.
I am new to this so I might be doing something wrong.
Thanks.

Are you still seeing this issue with the Latest? @CDuane
What browser are you using by the way?

I've got an error now, let me first tell you what I did.

Cloned the repo
cd into the directory
npm install
dotnet restore
dotnet run

When I visit localhost:5000, it crashes with this error
Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[0]       An unhandled exception has occurred: Call to Node module failed with error: Prerendering failed because of error: Error: Cannot find module 'C:\Users\duane\Desktop\coreng\Client\dist\main-server'     at Function.Module._resolveFilename (module.js:470:15)     at Function.Module._load (module.js:418:25)     at Module.require (module.js:498:17)     at require (internal/module.js:20:19)     at findBootModule (C:\Users\duane\AppData\Local\Temp\tmpC6A7.tmp:111:17)     at findRenderToStringFunc (C:\Users\duane\AppData\Local\Temp\tmpC6A7.tmp:116:28)     at renderToStringImpl (C:\Users\duane\AppData\Local\Temp\tmpC6A7.tmp:75:51)     at C:\Users\duane\AppData\Local\Temp\tmpC6B8.tmp:113:19     at IncomingMessage.<anonymous> (C:\Users\duane\AppData\Local\Temp\tmpC6B8.tmp:132:38)     at emitNone (events.js:86:13)

@CDuane That's my fault! Apologies.
I'm pushing up the fix now, but basically to get past it, just run npm run webpack in the command line (from the root directory) then run your project, and you'll be all set.
I added a build step in postinstall to run both webpack:vendor & then run the regular webpack build, which will fix this for new installs :)
Thanks for pointing that one out!!

I'm happy to tell you that everything is working now.
The application runs, thanks to your fix, and the title changes when routing.
Thanks for your work.

Glad to hear it :+1:
More updates to come!

Hi ,
are we able in insert meta data in server side ?
Thanks

Not yet but soon there will be updates to the repo for Angular 4.0 and Meta will all be set :) @Aymankassas

Thank you ,
But i would to ask if we can run our code on server , why we can not insert meta by meta.service or insert it to head to html on server then send all html with meta to client

Hi @MarkPieszak , I think it is an important issue, but this issue-
https://github.com/MarkPieszak/aspnetcore-angular2-universal/issues/87
is more important.
What do you think?

It can be done, but it takes handling collecting all of the needed data manually during the server render and manually pulling it out from the serialized result, passing it back to .NET in the Controller, and then rendering things manually through ViewData[] as opposed to the TagHelper. (You can see what part of what it's going to look like very soon when I rollout the ng4.0 here).
Since we're using MVC (and it has control over the View and Html), we only pass Angular the <app> as opposed to the entire <html> doc. This is why it's a little trickier! I'll try to get it in there asap, give me a week or so!


HBASE-23182 The create-release scripts are broken

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m 27s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
shelldocs
0m  0s
Shelldocs was not available.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

:blue_heart:
mvndep
0m 36s
Maven dependency ordering for branch

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 10s
Maven dependency ordering for patch

:broken_heart:
shellcheck
0m  4s
The patch generated 3 new + 112 unchanged - 0 fixed = 115 total (was 112)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

:blue_heart:
asflicense
0m  1s
ASF License check generated no output?

3m  4s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-736/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/736

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 74d2ccb2db77 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-736/out/precommit/personality/provided.sh

git revision
master / 4d414020bb

shellcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-736/1/artifact/out/diff-patch-shellcheck.txt

Max. process+thread count
52 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-736/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

OK the shell check warnings tell us to use double quota but actually, double quota is the problem here...
For example, "-Papache-release -Prelease", will be considered as only one profile, which is "apache-release -Prelease"...

@saintstack  PTAL sir.
Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
shelldocs
0m  0s
Shelldocs was not available.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

:blue_heart:
mvndep
0m 36s
Maven dependency ordering for branch

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 11s
Maven dependency ordering for patch

:broken_heart:
shellcheck
0m  4s
The patch generated 2 new + 110 unchanged - 2 fixed = 112 total (was 112)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

:blue_heart:
asflicense
0m  0s
ASF License check generated no output?

2m 20s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-736/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/736

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux be02739bb7b6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-736/out/precommit/personality/provided.sh

git revision
master / b14ba58c5a

shellcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-736/2/artifact/out/diff-patch-shellcheck.txt

Max. process+thread count
52 (vs. ulimit of 10000)

modules
C:  U:

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-736/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

PUBLISH_PROFILES should be a bash array. Or use the fact that maven lets -P take a comma separated list to pass a single string.

Done.

Any other concners? @busbey @saintstack

OK, I need to apply the patch here to generate 2.1.8.
Ping @busbey  and @saintstack . Let's merge this?

+1 from me.

Hi @bharathv , this PR is for fixing the problems of the scripts and I've tested this twice when releasing 2.2.2 and 2.1.8, which means it works. So I think we could get this in first, and file a new issue to polish the scripts. If you have interest, the scripts also have other things which could be improved.


revise the path error in the get start demo

the path is not correct to start the demo project!

@jsf-clabot i have done the sign

Ah this is similar to #1291 -- please see my comment there. I think something else needs to be tweaked probably either one of the CLI commands or example config.

@skipjack ok! as your will ! but the now guide on the web can not work it out to show "hello webpack" when u open the index.html via brower!

ok! as your will ! but the now guide on the web can not work it out to show "hello webpack" when u open the index.html via brower! 404 to find bundle.js

@HAOGRE I think you misunderstood me. You are 100% correct that there is an issue, I'm just saying we should resolve that issue in a slightly different way. This is definitely a high priority and we'll make sure to have a fix merged by tomorrow at the latest. Let's close this and move the discussion to #1291.


make class targets selectable

This enables usage of the QuickBuilder in test environments where parts of those classes are given and others are not (like having the Book committed but not adding the BaseBook into VCS).
Real-world usage example:
<?php

/**
 * This file is part of the PropelBundle package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license    MIT License
 */

namespace Propel\PropelBundle\Tests\Security\Acl;

use PropelQuickBuilder;

use Propel\PropelBundle\Tests\TestCase as BaseTestCase;

/**
 * @author Toni Uebernickel<EMAIL_ADDRESS> */
class TestCase extends BaseTestCase
{
    protected $con = null;

    public function setUp()
    {
        parent::setUp();

        $this->loadPropelQuickBuilder();

        $schema = file_get_contents(__DIR__.'/../../../Resources/config/acl_schema.xml');

        $builder = new PropelQuickBuilder();
        $builder->setSchema($schema);
        if (!class_exists('Propel\PropelBundle\Model\Acl\map\AclClassTableMap')) {
            $builder->setClassTargets(array('tablemap', 'peer', 'object', 'query'));
        } else {
            $builder->setClassTargets(array());
        }

        $this->con = $builder->build();

        return;
    }
}

Makes sense, thanks!
As it's just for unit tests, it's not what we can call a "new feature", so good to merge. Can you write the same PR for Propelé ?


update overlay for misc.py

update overlay so it shows the mtnioned author's avatar instead of the author's avatar as so not to get confused

member = member or ctx.author logic is there already, you wouldn't need to check if member is None.


Links referring to moved documentation in readme.md

2 links in the Getting Started section of readme.md is referring to moved documentation. They should be changed to point to the new location.
The links are:

Enable OpenAPI documents to your Azure Functions HTTP Trigger (Preview)
Microsoft.Azure.WebJobs.Extensions.OpenApi

@cjakobsen Thanks for pointing out! While I mostly agree with that, I would remain pointing the same document.
Instead, I would provide two links – in-proc.md and out-of-proc.md in the document, https://github.com/Azure/azure-functions-openapi-extension/blob/main/docs/enable-open-api-endpoints.md
The same goes applied to this page. https://github.com/Azure/azure-functions-openapi-extension/blob/main/docs/openapi.md


Add CSS variables for easier theming

As discussed in #25 it would be better to use CSS variables in new themes instead of copy-pasting the whole CSS file while only changing a few colors

I have this finished but mixed up my branches. I need to wait until you merge #31 @Jeconias


rephrase documentation text

In section [2.1 — Layout] (http://ui.synergic.cz/section-2.html#section-2.1) is sais:

...have to remember WTF columns...

I dont think that things such as WTF should be part of official documentation.

I don't consider it much official, but OK, I'll remove it.


CSS Styling: Product pages

[x] Basic CSS layout for:

[x] Home page
[x] Favorites page
[x] Popular page
[x] Search page

Resolved by #77


Allow suggested edits

My colleagues and I do a lot of writing and editing, sharing and commenting, etc., in Markdown, and this looks like a great tool for the kind of work we do. It looks like the only major feature we rely on that Classeur is missing right now is the ability to suggest changes (as in Google Docs) or track changes (as in Word). When I share a doc with my colleagues, I don't want to give them full overwrite access—I want to be able to accept or reject their changes one by one. Is this on the roadmap for Classeur?

Hi @johnaxel
I just created another ticket for file history (#17) as it's definitely in the roadmap. As for the suggest mode, it would be easier to implement once we have that.

That's great! File history would be a huge help for gathering and folding in edits from others.

:heavy_plus_sign:


Error when creating scratch org

Summary
Error thrown when attempting to create a scratch org, appearing as of this morning.
Steps To Reproduce:

Executing: sfdx force:org:create -f config/project-scratch-def.json -a 'ScratchOrg' -v 'DevHub' -d 1

Expected result
Scratch org is created successfully
Actual result
Error is thrown:
npx sfdx force:org:create -f config/project-scratch-def.json -a 'ScratchOrg' -v 'DevHub' -d 1
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/6c28d0a9-4acd-4c4c-bfdf-0a465d8ed7bb.sh
Error: Cannot find module 'lodash'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /home/vsts/work/1/s/node_modules/salesforce-alm/node_modules/@salesforce
/command/lib/exported.js
- /home/vsts/work/1/s/node_modules/salesforce-alm/dist/commands/force/org/
create.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /home/vsts/work/1/s/node_modules/sfdx-cli/dist/cli.js
- /home/vsts/work/1/s/node_modules/sfdx-cli/bin/run
Code: MODULE_NOT_FOUND
System Information
SFDX Version: 7.115.1
Additional information
Feel free to attach a screenshot.

Hi, this is a very weird error, maybe an incomplete of corrupt installation ?
Can you try upgrading to the latest-rc to see if this error still continues ? npm install -g sfdx-cli@latest-rc

@calvinle1 I think this may have been related to some of the problems from sf
https://github.com/forcedotcom/cli/issues/1174 and/or
https://github.com/forcedotcom/cli/issues/1175
Any chance you can try this with version 7.118.1 which works in those scenarios?  We definitely haven't tested using npx like that.


[2206] Iterate UI for new cycle

Context
New recruitment cycle
Changes proposed in this pull request

Add next recruitment_cycle
Refactor org#show page

Guidance to review
🚢
After

 Interate publish frontend for upcoming cycle

I'm happy with design. I think someone else needs to review code/test changes.


Editing a call with comma doesnt work in new DMN Editor

1.12.0-alpha2

Open new DMN Table
Click on Edit Icon in first cell
Enter Values like "abc","def" and hit enter

See that nothing happens, in console we get a type error
"Cannot read property 'type' of undefined
at SimpleStringEditContextMenuComponent.addUnaryTestsListItem()
Note: Also on outside click the box closes, but nothing happens, values are not persisted.

We'll have a look at this :thumbsup:

This is fixed in dmn-js@2.


VS2017 Xamarin.Forms: CurrentPlatform is internal class in v.4.0.0

Hi,
Recently I updated my XF solution to utilize .NET Standard instead of PCL and updated the Client to v.4.0.0. Now I get a compiler error in my MainActivity where I call
Microsoft.WindowsAzure.MobileServices.CurrentPlatform.Init();
Installed packages in .NET Standard lib which targets .NET Standard 1.4:

Microsoft.Azure.Mobile.Client v.4.0.0:

Microsoft.Azure.Mobile.Client.SQLiteStore v.4.0.0:

Compiler Error:

For reference I put the Droid .csproj an packages.config on gist
and the .NET Standard library .csproj , too.
Quite interesting the the XF iOS project is compile and runnable with the same v.4.0.0 without any issue:

Further more I hit decompile on CurrentPlatform in MainActivity and AppDelegate and can see that

If you need more info please get back, i will provide as much I can.
best
Eric

After targeting my XF Droid .csproj to Android 7.1 I could compile but I don't know if that is the solution

Hi @ericbrunner
Library Microsoft.Azure.Mobile.Client v.4.0.0 depends on MonoAndroid v7.1 and won't work with versions lower than. But since we have .NETStandard support in the library, NuGet fallback to it on resolving dependencies and wrong assembly (not for Android) was included to your project.
So, your solution is absolutely right.
FYI: We downgraded MonoAndroid dependency version to v7.0 in Microsoft.Azure.Mobile.Client v4.0.1.


New feature proposal:Login Page

Child of #18
HTML preview : https://codepen.io/versha/pen/GRoqQWa
Login Page Layout Code :(https://github.com/VershaCoder/FrontEndTasks/blob/master/UpdatedLoginPage.html)
@YashKumarVerma

Use Github pages / codepen / any other service to show the layout.

tip: use layout similar to #21

@YashKumarVerma  I have updated the layout and added a link for layout preview.

There are instructions given on the parent issue of this issue about the changes that are to done and steps to be followed while doing a submission. Kindly check them out, and submit the work.

Okay, I'll check it out.


Upgrade go version

Signed-off-by: ashish<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

[/github/workspace/internal/config/releases.go:70] - G107 (CWE-88): Potential HTTP request made with variable url (Confidence: MEDIUM, Severity: MEDIUM)
// #nosec
> resp, err := http.Get(releaseAPIURL)
if err != nil {

Rerunning tests....

Security check still failing.

All green checks @Revolyssup @leecalcote good to merge?

good to go


How to make offside item scroll with page that is pushed offscreen.

If I have a left offside element that is larger than the screen, I can scroll it independently of
the main part of the page that is pushed to the right.
Is there a way to make both the main part of the page and the offside element scroll together down the page. So scrolling the main section also scrolls the offside element?
Thanks.
-- rouilj

Offside doesn't currently support this out of the box. You might consider extending default styles.


Stratify on member number

Split on Member number (Realisation in Iris speak). For postage stamp plots can just slice over each realisation and produce plot.
This will require a new constraint operator, as well as a way to go on to process multiple members.

This functionality already exists within CSET, but is not documented. I started looking at creating a function for this and it turns out that the generate_levels_constraint operator (because it takes in configurable coordinate names) does this. For now I will add documentation to generate_levels_constraint operator to show its hidden functionality, to close this issue. I will also create a separate issue to raise a question around the generality of the generate_levels_constraint operator.


Is dotnet interactive compatible with .net6 preview?

The package and version I'm asking about:

Running the #!about magic command results in the executing cell running without stopping. Running dotnet interactive --version results in the following:
$ dotnet interactive --version
Could not execute because the specified command or file was not found.
Possible reasons for this include:
  * You misspelled a built-in dotnet command.
  * You intended to execute a .NET program, but dotnet-interactive does not exist.
  * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.

I've installed the dotnet interactive exension via the vs code market place. The currently installed version is v1.0.2256021
Question

Is dotnet interactive compatible with .net6 preview? I'm on an M1 Macbook so I have to use .net 6 preview.

Any update this?

Not yet. Keep an eye on #1482.


Prompt user only once when quitting/restarting and canceling save dialog

Fixes #15238.
I think this slipped through during the refactoring performed in dc32018. With this pull-request we are fixing the issue and adding a new main process test to exercise this behavior and ensure we don't regress in the future.
/cc: @Ben3eeE @ungb for testing this, and @nathansobo @maxbrunsfeld for 👀.

The new test looks good. I like the addition of a new promise to make things predictable.


Rate limiter implementation

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

Fixed issues
#63

Without a database repository implementation?

I didn't plan on it, but I can try. What tasks can this be useful for?

I didn't plan on it, but I can try. What tasks can this be useful for?

See https://github.com/yiisoft/yii2/blob/master/framework/filters/RateLimiter.php and https://github.com/yiisoft/yii2/blob/master/framework/filters/RateLimitInterface.php

I didn't plan on it, but I can try. What tasks can this be useful for?

See https://github.com/yiisoft/yii2/blob/master/framework/filters/RateLimiter.php and https://github.com/yiisoft/yii2/blob/master/framework/filters/RateLimitInterface.php

added storage implementation, now it will be possible to add storage in the database

Current implementation not allow multiple limit descriptor in a single middleware. It is necessary to record more intervals and more limits, eg.
ID                    interval  limit
sms/user/12             60s     2
sms/user/12           3600s     10
sms/users               60s     40
sms/users             3600s     250

Created a new pull request with the implementation of the GCRA.
I'm closing this one.


Restore persistent workspace

What should I review?

https://github.com/camunda/camunda-modeler/commit/7929584166b1b06042175107480fec703f4d91d3
Sorry, I forgot to merge the branch into our development branch.

I would have expected a feature branch, mentioning this issue in the commit via Closes #910 instead :wink:.
Added some review hints via https://github.com/camunda/camunda-modeler/commit/7929584166b1b06042175107480fec703f4d91d3.


Add option to hide title bar

Probably hide it when title is empty

Fixed in 2.1rc1 (b0eac66ef121a743c79193d3969dd090f0037411)


Add common_data to each host

For the Anomaly detection use case, there is a section in the JSON under common_data which is applicable to all hosts.
So in the PR, the Consumer looks for common_data and attaches it to every host (in host_info)
P.S. Let's leave this PR open for some time and not merge it
Chances are we would not be showing the Anomaly detection results in Advisor (I just came to know about this)
If that is the case, we don't need this change right now.
/cc @bronaghs

@tumido Closing this PR because we currently would not be handling the AD/Advisor use case.
Thank you for your review though!


Override countries and states and preselect a default country

Closes #449

What I did

How to test

Checklist

[x] Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
[x] Make sure to add/update documentation regarding your changes.
[x] You are NOT deprecating/removing a feature.

:tada: This PR is included in version 4.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Bug]: The theme app extension can no longer find assets.

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Extension
Expected behavior
I would like to be able to npm run deploy.
Actual behavior
Only the Theme App Extension has an error.
Verbose output
2024-02-01T00:53:37.936Z: Creating directory at /private/var/folders/v2/k_ddyzwx76736rs3zqp4dyfr0000gn/T/422b0f2258894781ea41a0ccaf514f4e...
2024-02-01T00:53:37.936Z: Sync-creating directory at /private/var/folders/v2/k_ddyzwx76736rs3zqp4dyfr0000gn/T/d1f943f3d04eb08fe401e55171a260d7/bundle...
2024-02-01T00:53:37.937Z: Creating an empty file at /private/var/folders/v2/k_ddyzwx76736rs3zqp4dyfr0000gn/T/d1f943f3d04eb08fe401e55171a260d7/bundle/.shopify...
reservation-ui           │ Running theme check on your Theme app extension...
Failed to get file size: Error: ENOENT: no such file or directory, stat 'assets/index.js'
reservation-ui           │
reservation-ui           │ Bundling theme extension reservation-ui...
2024-02-01T00:53:38.026Z: Copying file from extensions/reservation-ui/assets/index.js to /private/var/folders/v2/k_ddyzwx76736rs3zqp4dyfr0000gn/T/d1f943f3d04eb08fe401e55171a260d7/bundle/583513e6-dc17-4394-9305-f4dd24fc1cfc/assets/index.js...

Reproduction steps

Update to the latest version (3.55.1) from 3.52.0
npm run deploy

Operating System
Mac OS
Shopify CLI version (check your project's package.json if you're not sure)
3.55.1
Shell
zsh
Node version (run node -v if you're not sure)
v20.10.0
What language and version are you using in your application?
No response
### Tasks

Failed to get file size: Error: ENOENT: no such file or directory, stat 'assets/index.js'

Is there a reference to index.js that doesn't resolve? This might be thrown by our fileSize util
By the AssetSizeAppBlockJavaScript check in here: https://github.com/Shopify/theme-tools/blob/c786b7eaf0939b2d9b9469b66a74d45f56e626c1/packages/theme-check-common/src/checks/asset-size-app-block-javascript/index.ts#L31
Which checks that the file referenced by
{% schema %}
{
  "javascript": "index.js"
}
{% endschema %}

Has a size within the bounds allocated. It's throwing an error because it can't find that file.

Same problem here, dont know if this will affect to deploy or only it's a warning

@isaacroldan, it looks like we're doing something out of order in shopify app deploy
https://github.com/Shopify/cli/blob/main/packages/app/src/cli/services/deploy.ts#L87-L119
Given that some folks have some kind of build process tacked on top of their theme app extension, I think we should run theme-check after that build process. The problem above occurs because the copying file happens after running theme-check and not before. We should build, then validate and not the other way around.

this.build(options) has a branch that runs themeCheckRun before bundleThemeExtension happens?

Maybe I'm misunderstanding what does what.

Same issue here but no build steps prior. Just an update of the CLI and API versions from 3.48.x to 3.56.1 our static assets just aren't found anymore. Is it a cacheing issue? As the files are expected to be found but just aren't (even though the path spat back out by the STDERR is correct and the files exist there). it shouldn't know that those files are there unless they're stored in memory, in which case did the file structure for theme app extensions change in the recent updates?

In response to this, I've tried symlinking the entire assets directory into the root of the app and no dice. Alongside that I then tried each subdirectory heading towards the original theme app extension UI assets folder. Still no dice. It just doesn't seem to be finding the files for whatever reason, but I also can't tell if that's true or not as the files could be being found, but it's just failing a small check that is inconsequential to the deploy and those files are being deployed anyway... Any updates on this @charlespwd ?

Hmm. @kirillplatonov If that's really the case then maybe it's just a matter of the theme check run not running at the correct root?
Can someone give me the following:

Exact set of commands that cause the problem
The exact layout of their files (preferably using tree), I'm not concerned about the non-TAE but I'd like to have something from .git root

I vaguely recall having logic in place for finding the root of a TAE (https://github.com/Shopify/theme-tools/blob/main/packages/theme-language-server-node/src/dependencies.ts#L32-L35)
But it looks like we only use that in the language server. That might be the issue actually. We don't infer the correct root for TAE and so the thing breaks.
Ah crap so it looks like the config is hardcoded but the root isn't set properly: https://github.com/Shopify/cli/blob/main/packages/app/src/cli/services/build/theme-check.ts#L68-L69
There's unfortunately no config way to fix this because of that (we don't even read the config). I believe that was by design and is indeed a problem.

If that's really the case then maybe it's just a matter of the theme check run not running at the correct root?

@charlespwd Yes, It seems to be the case. And it is consistent with my observations in the my previous comment

Exact set of commands that cause the problem

You can reproduce it with the freshly bootstrapped application like this:
pnpm create @shopify/app -d pnpm -p . --template=remix --name=test-theme-ext-error --flavor=javascript
cd test-theme-ext-error
pnpm generate extension --name=theme_ext # pick the theme app extension for type of extension when asked
# init asset
echo "console.log('blah');" > extensions/theme-ext/assets/test.js
# init block using this asset
echo '{% schema %}
  {
    "name": "Test",
    "target": "body",
    "javascript": "test.js",
    "settings": []
  }
{% endschema %}
' > extensions/theme-ext/blocks/test.liquid
# run the build (error should be in ouput)
pnpm shopify app build
# link assets to the root of project
ln -s $PWD/extensions/theme-ext/assets $PWD/assets
# run build again (no error)
pnpm shopify app build

Is there any update on this issue?

This issue just killed our app on several high-profile Plus stores, really need to fix asap please!

Any update for this issue? I have assets in extensions/theme-app-extension/assets folder and I suddenly started getting the same error:
Failed to get file size: Error: ENOENT: no such file or directory, stat 'assets/collection-swatches.js'
Failed to get file size: Error: ENOENT: no such file or directory, stat 'assets/product-swatches.js'

It breaks deployment from the CI:
Moving assets folder to root helped but it's really ugly workaround which kills existing conventions. Can we get a proper fix in CLI?

Thank you for the tip to move the assets folder to the root - at least we can get our app back up and running while this issue gets fixed!

@ryanm-bw Revert @shopify/app and @shopify/cli version to 3.52.0 fixed this for me but the issue needs to be fixed soon.

+1

Moving assets folder to root helped but it's really ugly workaround which kills existing conventions. Can we get a proper fix in CLI?

Thank you for the tip to move the assets folder to the root - at least we can get our app back up and running while this issue is fixed!

I don't think it will be fixed soon, unless everybody spams support. I pretty much posted everywhere you can imagine about this issue (slack,discord, facebook,twitter...) , and gave up after 24 hours.
Is still happening in every embedded app, it seems to happens more often in stores that recently installed the app.

Guys... I'm closing this discussion. Let me cook.


Streamline/cleanup adding of external dependencies

Steps to reproduce and a minimal demo of the problem
Adding an external JS dependency to a project requires changes to a lot of different files, leading to bugs, and unexpected behavior.  This is not fully documented. Ideally one would somehow simplify this.
Current behavior
In order to add a dependency, at a minimum it seems that one would have to patch the following files
package.json  (usually automated via npm)
tools/config/project.config.ts
tools/tasks/project/desktop.libs.ts
tools/manual_typings/project/...
tools/utils/project/systemjs-packages.ts    (optional?)
karma.conf.js
test-main.js

Within project.config.ts itself, there is SYSTEM_CONFIG.paths, SYSTEM_CONFIG.packages, then also SYSTEM_BUILDER_CONFIG.paths and .packages.
It is not 100% clear to me when one has to patch the .packages vs just the .paths.
Expected/desired behavior
It would be nice to have somebody provide an example of fully (including karma/jasmine, desktop, prod builds, etc) integrating a new dependency.
Ideally one could add a dependency to package.json, or some other place and other configs would just pick it up.
Other information

Hi @yvoronen Thanks for bringing this up, I will plan to provide 1 example of a library integration showing all the files requiring modification by the end of this month.

+1. Some libraries 'just work' after npm install --save. But for some it's a nightmare to get it working. I understand there are some conventions that try to capture majority of the cases but when it's outside of those conventions it's really hard and unclear.

This has been made much simpler with latest upstream parent changes.


fix typo in readme

Looks like typo

@maxkaido Thanks! But unfortunately the readme is not up-to-date, we recently migrated the project from flow to typescript, I'll create a ticket to update README

You can track the progress here: https://github.com/gnosis/safe-react/issues/1157

@mikheevm thanks for clarifying. I was wondering where flow has been used. Now it makes sense.


Network's status show incorrect

Describe the bug
Network's status show incorrect

Version test: http://file.cdmteck.com/s/qDBE2oH9jbX2cgx
Validation passed in cases:

Enable network
Disconnect network
Update provider

Re-test:

Add chain
Add provider
Show/hide network


Don't blindly add lib/ to load path on rspec configuration

This behavior is hardcoded here: https://github.com/rspec/rspec-core/blob/bebc52c9e7c411d4b1951e7b3169eeb8528daab8/lib/rspec/core/configuration.rb#L1271-L1271
And tested here: https://github.com/rspec/rspec-core/blob/bebc52c9e7c411d4b1951e7b3169eeb8528daab8/spec/rspec/core/configuration_spec.rb#L102
I'm sure it made total sense once, for the convenience of testing gems, where the code always lives in lib/.
But it's a big assumption on the part of rspec that this is a desirable behavior. For example, in an ordinary rails 4  / bundler / rspec 3 app, this causes the Bundler.require line in environment.rb to require matching ruby files from #{Rails.root}/lib/ rather than from bundler's gems when executing the rspec binary.

But it's a big assumption on the part of rspec that this is a desirable behavior.

Not really it's standard Ruby behaviour.

For example, in an ordinary rails 4 / bundler / rspec 3 app, this causes the Bundler.require line in environment.rb to require matching ruby files from #{Rails.root}/lib/ rather than from bundler's gems when executing the rspec binary.

It shouldn't do, it should cause it to look for #{Rails.root}/lib then bundlers gems, which is the same behaviour Rails itself has...

Hmm, maybe we're looking at it from different sides.  As does rspec generally (for example, the spec_helper.rb file). What precedent are you thinking of for a library to add code that doesn't belong to it to your load path upon initialization?

Rails does the same thing we do, we just need to do it earlier to get the same behaviour.

What precedent are you thinking of for a library to add code that doesn't belong to it to your load path upon initialization?

./lib is added to your load path in every single rubygem and by Rails, which covers the majority of Ruby code out there, we're for testing your code, thus we follow that convention as if we were something in your ./bin.

What is the desired end result that this behavior yields? I guess that the behavior was for convenience because when I removed the behavior, the only rspec-core spec that failed was the spec I linked to above that specifically tests for the behavior.

For your code the be able to require lib/my_file as require 'my_file' as you would expect.

Trust me, us adding lib is not an issue, are you encountering a problem? Because theres probably something else going on, for example using the same name for files in lib as your gems (which is a smell in itself and usually only used for monkey patching)

Trust me, us adding lib is not an issue, are you encountering a problem? Because theres probably something else going on, for example using the same name for files in lib as your gems (which is a smell in itself and usually only used for monkey patching)

Right, but this is not always desirable.
To account for my case of using rspec to test a rails app, we could either remove this convenient behavior and force people to opt-in by adding lib/ to their path in spec_helper.rb, or we could give an option to opt-out of this behavior, for example when using rspec-rails.

I'm afraid there's no option to opt-out of that behaviour from Rails so it would still happen.

Fortunately, rails adds lib/ to your path after Bundle.require is invoked in application.rb (in a default rails app). We could follow rails' lead in rspec this by adding lib/ to your path in an appropriate place in the default spec_helper.rb.
As a framework, rails is entitled to make decisions about what's in lib/. Similarly, rspec as a framework for testing gems would be likewise entitled. But rspec is more than that: you can test whatever you want with rspec, rails apps, scripts, etc.. This assumption about blindly adding lib/ with no recourse, well, it's a bit rude.

(it goes with out saying, but lib/ in a gem and lib/ in a rails app mean two completely different things...)

(it goes with out saying, but lib/ in a gem and lib/ in a rails app mean two completely different things...)

Not really, they mean the same thing.

This assumption about blindly adding lib/ with no recourse, well, it's a bit rude.

s/bit rude/standard ruby convention

Fortunately, rails adds lib/ to your path after Bundle.require is invoked in application.rb (in a default rails app).

Like I say, this should be entirely harmless, please tell me what the actual issue you have is.

lib/ in a gem is the ruby code constituting the gem.
lib/ in a rails app, well, people use it for different stuff, but it never constitutes the app; the bulk of the app lives in /app
The actual issue that prompted this was my picking up a rails app from other developers that included some monkeypatches (yes, monkeypatches are questionable, but people do use them :/). They had the app set up with minitest and everything is hunky dory. But adding the first rspec test and trying to figure out why the load path has been altered, meant stepping through the rspec code as I have done.
The current behavior offers no value but for a bit of convenience, and we can re-imagine it in a way that is less mystifying and offers rspec users more control/flexibility.

lib/ in a gem is the ruby code constituting the gem.

lib/ in a gem is ruby code constituting things expected to be consumed by another party, or from an executable.

lib/ in a rails app, well, people use it for different stuff, but it never constitutes the app; the bulk of the app lives in /app

lib/ in a rails app is ruby code constituting things expected to be consumed by the app itself, from my perspective thats the same pattern

The current behavior offers no value but for a bit of convenience, and we can re-imagine it in a way that is less mystifying and offers rspec users more control/flexibility.

Your the first person to mention this as causing an issue for them, as such theres no way we'd change the default behaviour that works in 99.999% of cases. I'd argue minitest is behaving surprisingly here as I don't think it's behaviour would necessarily match production usage here.

Fair enough, thanks for your consideration Jon.

By the way its worth noting that code you linked to doesn't do what you think it does, it only adds lib to the path when you tell us to require something for you... You could avoid this if you wanted to by simply not using the --require option.

I am not using --require :(

You are somewhere, check your .rspec and / or your spec helper for config.requires =

You're right! The default .rspec that rspec-rails gave me has --require spec_helper. I will investigate this.

The discussion here made me wonder when RSpec started to do this.  I discovered that it dates back to RSpec 1.2.9 in 2009:
https://github.com/dchelimsky/rspec/commit/010d2fd41dcab5df74cd066a210ab485673a1102
It's also prominently documented in our README:

# in spec/calculator_spec.rb
# - RSpec adds ./lib to the $LOAD_PATH
require "calculator"

In the 1.8 days, before the advent of require_relative, there was a common issue where files could be double-required if they were required with different forms (e.g. different relative paths, or one relative and one absolute).  The solution was to require everything relative to a $LOAD_PATH entry, and putting lib on the load path facilitated that, helping users to avoid double-require problems.  While users certainly could have put lib on the $LOAD_PATH (and still can today), in my experience, most ruby programmers do not like to manually put things on $LOAD_PATH, preferring to allow their tools (e.g. rspec, bundler, rubygems and rails) to setup the load path for them.  So yes, it's a convenience, but a valuable one that, as far as I know, had never received any complaints before now.
Making a change to no longer put lib on the $LOAD_PATH would be breaking for most users and as such, is something we'd only consider doing in RSpec 4.  That said, I personally like having lib on the $LOAD_PATH and am not convinced it's worth the pain it would cause most users to change.  It's not clear to me what problem it's actually causing for you.  Can you explain your problem some more?  Even though we're unlikely to change it here I'd still like to understand why you find it problematic.

This assumption about blindly adding lib/ with no recourse, well, it's a bit rude.

You do have recourse.  Additions to the $LOAD_PATH need not be permanent.  If you don't want lib on the $LOAD_PATH, it's trivial to remove it:
$LOAD_PATH.delete_if { |p| File.expand_path(p) == File.expand_path("./lib") }

Thanks for the suggestion and explanation. In my case, moving a single ruby file from lib/ to a new directory lib/monkeypatches/ fixes me up: without lib/monkeypatches/ in my path, bundler requires the gem rather than the monkeypatch.
Out of interest, besides backwards compatibility, what are the other considerations related to my idea to move adding lib/ to the path to the default spec_helper.rb, thus making the behavior explicit and configurable?

In my case, moving a single ruby file from lib/ to a new directory lib/monkeypatches/ fixes me up: without lib/monkeypatches/ in my path, bundler requires the gem rather than the monkeypatch.

Thanks for explaining.  I must have missed that above.

Out of interest, besides backwards compatibility, what are the other considerations related to my idea to move adding lib/ to the path to the default spec_helper.rb, thus making the behavior explicit and configurable?

Lots of people don't use the generated spec_helper.rb (or even know rspec --init will generate one for you!), so moving it into the generated file is insufficient, IMO.  There's also the problem of upgrades: if we moved it from a default to spec_helper.rb in RSpec 4, folks upgrading from RSpec 3 to 4 would have to know to add it themselves after upgrading or they'd get failures.  We successfully navigate the RSpec 2 -> 3 transition with many changes but I'm not convinced the benefit here is enough to warrant forcing users to make this change...and we're hoping RSpec 4 will be a much more modest upgrade process :).
Besides, as I said above, the load path is already configurable.  It's a global variable you can configure to you hearts content :).  It's a matter of whether it makes more sense to make 99% of users configure the load path to put lib on it, or default that on and make the 1% of users who don't want it configure the load path by removing lib from it.  The 99/1 split might sound extreme, but given your the first to complain, that ratio isn't far-fetched.

Makes sense Myron, thanks for the extra info.

I ran into this. I don't have ./lib in the $LOAD_PATH for my application (I do require "lib/foo" and so on). At one place I made a bad require, leaving of lib/. My tests was all green, but the application could not start.


pygrib.fromstring entire grib file?

would it be possible/difficult to support fromstring() entire grib file instead of a single message?

Not sure what the use case would be - fromstring is usually used to create a grib message object from a binary string.  If you have a bunch of binary strings strung together, they could be split up by looking for the "end of message" bytes (777), and then iterated over.

I would like to stream data from from internet and split the grib file without storing it on a file system. I guessed that there must be a message separator but I did not know about '7777' string. I tested your suggestion but unsuccessfully. Would you mind to show me an example? I can figure out the streaming from URL but I dont know how to split the messages. I would expect this line should give me number of messages but it does not. What I am doing wrong?
len(open('./nam_218_20160101_0000_001.grb','rb').read().split('7777'))

I think you need to add decode('ascii','ignore'), i.e.
(open('./nam_218_20160101_0000_001.grb','rb').read().decode('ascii','ignore')).split('7777')

If it works, each string should start with 'GRIB' and end with '7777'.

len(open('./nam_218_20160101_0000_001.grb','rb').read().decode('ascii','ignore').split('7777'))
gives length 7972 and only 448 starts with 'GRIB' string.

Note that you'll have to add the 7777 back to each string, since the split will remove it.

I could not get the string split method to work - turns out grib messages sometimes have '7777' in the body of the message and not just at the end.  Here's a script that does work (for me at least).
'''python
import pygrib, sys, struct
filename = sys.argv[1]
f = open(filename,'rb')
msgs = []
while 1:
# find next occurence of string 'GRIB' (or EOF).
nbyte = f.tell()
while 1:
f.seek(nbyte)
start = f.read(4).decode('ascii','ignore')
if start == '' or start == 'GRIB': break
nbyte = nbyte + 1
if start == '': break # at EOF
# otherwise, start (='GRIB') contains indicator message (section 0)
startpos = f.tell()-4
f.seek(4,1)  # next four octets are reserved
# 5th octet is length of grib message
lengrib = struct.unpack('>q',f.read(8))[0]
# read in entire grib message, append to list.
f.seek(startpos)
gribmsg = f.read(lengrib)
msgs.append(gribmsg)
convert grib message string to grib message object
for msg in msgs:
print pygrib.fromstring(msg)
'''

Here's a version that works for both GRIB1 and GRIB2:
import pygrib, sys, struct
filename = sys.argv[1]
f = open(filename,'rb')
msgs = []
while 1:
    # find next occurence of string 'GRIB' (or EOF).
    nbyte = f.tell()
    while 1:
        f.seek(nbyte)
        start = f.read(4).decode('ascii','ignore')
        if start == '' or start == 'GRIB': break
        nbyte = nbyte + 1
    if start == '': break # at EOF
    # otherwise, start (='GRIB') contains indicator message (section 0)
    startpos = f.tell()-4
    f.seek(3,1)  # next three octets are reserved
    # grib version number
    vers = struct.unpack('>B',f.read(1))[0]
    # length of grib message
    if vers == 2:
        lengrib = struct.unpack('>q',f.read(8))[0]
    elif vers == 1:
        f.seek(startpos+4)
        lengrib = struct.unpack('>i','\x00'+f.read(3))[0]
    # read in entire grib message, append to list.
    f.seek(startpos)
    gribmsg = f.read(lengrib)
    msgs.append(gribmsg)
# convert grib message string to grib message object
for msg in msgs:
    print pygrib.fromstring(msg)

I appreciate you taking your time. this answers my question. thx

I finally get time to use this more extensively but when I compared the results of using the method you posted above (where i split the grib file in memory) VS pygrib.open() of a physical file, I get a different number of messages. In fact, even the message length differs. Any idea why?

nope, no idea


Invalid function for getter 'WaterArea3D::get_flow_direction' for property: 'flow_direction'.

Using Godot 4.1.2, I get this error upon opening the editor and every time I run the game.
E 0:00:00:0654   ClassDB::add_property: Invalid function for getter 'WaterArea3D::get_flow_direction' for property: 'flow_direction'.
  <C++ Error>    Condition "mb_get->get_argument_count() != exp_args" is true.
  <C++ Source>   core\object\class_db.cpp:1065 @ ClassDB::add_property()

I've been out of town but I'll get a chance to take a look later this week for sure.

I can do some updates for Godot Engine 4.2 compatibility in the next three hours.

Made a pr https://github.com/godot-extended-libraries/hydro/pull/20

Thanks for the PR @fire; @sandsalamand I verified that this is fixed on both 4.1 and 4.2.


Use name validations from our API instead of the k8s core

Written by Paul, slightly modified by me.
(Supercedes https://github.com/kubernetes-incubator/service-catalog/pull/330)

@pmorie I'd like to understand the why behind using apivalidation.NameIsDNSSubdomain. I dove into the k8s impl, and I can see that a lot of components in there use this for names, but the code has no comment on why. I can see it ends up being rfc1123. That rfc is 97 pages. I am not familiar with it to know which section to look at.  The word 'subdomain' or any versions of it does not exist in that rfc.
I accept 'k8s does it' as a reason here (in fact, NameIsDNSSubdomain is what ValidateReplicationControllerName maps to, so this is not a functional change), but I'm asking for a direct link to the exact part of the rfc that defines we're talking about. It would be doubly nice if that link was then shoved into the upstream codebase.
Right now the field might as well be called 'isValidFloobleCrank'.
lgtm

isValidFloobleCrank

🥇


Creating a recipe: Authentication credentials were not provided

I cannot create a recipe because after clicking the "Submit recipe" button, the following error appears:
Form error! Please confirm that all the data is there.
However, as far as I can tell all required fields are filled in. In the console the following messages are logged:
Failed to load resource: the server responded with a status of 401 (Unauthorized)
authentication_credentials_not_provided.txt
Error: Unauthorized
unauthorized.txt
Authentication credentials were not provided. failed_to_load_resource.txt
After reloading the page, filling in and submitting the data again, the recipe is saved successfully.
Used Browser: firefox or chromium

I'm not able to reproduce this issue. It could just be a weird token/local storage issue. Can you provide some more details who how you got to that page and when you logged-in?
You also might wanna try in a private browsing mode.

The error occurred on a server where a nginx reverse proxy for ssl encryption is configured in front of the openeats nginx. In order to rule out that this configuration is the cause for this error, I set it up on my local computer.
It can be reproduced anytime on both setups with the following steps:

Open the website in private browsing mode.
Login
Click on Create recipe
Fill in: recipe name, course, cuisine, prep time, cooking time, servings, rating, an ingredient, a direction step, recipe information
Click on Submit recipe
Above the button the following error is shown: Form error! Please confirm that all the data is there
Also the errors previously described are logged in the console.
Click on Submit recipe
The same errors are shown and logged again.
Reload page
Fill in the same information again
Click on Submit recipe
The recipe is saved successfully.

I noticed that when the saving fails the following part is missing in the http request header:
`Authorization: "Token fac0577a795dab8b6215ab57e6a2c1a1d4bbd362"

`

Thanks for the detailed report. From what you are showing above, for whatever reason, the auth token isn't getting submitted along with the rest of the data. Which is weird. When a user is logged in, the auth token should be getting submitted alone with EVERY request. Meaning if the login failed for whatever reason, a user shouldn't be able to see any data due to a 401 error.
Anyways, I'm now able to replicate and will look into the issue.

Looks like the code was creating one and only one instance of a request object. This was causing the token to never be appended to the request. And also why refreshing the page "fixed" the issue, as a new instance was getting created.
#247 Fixes this issue by create a new request instance every time we query the backend. I'll update this ticket once I've done a bit more testing and merge the PR.

The code has been merged and master is updated with the fix. Feel free to put the latest.
Reopen if you are still having an issue.


Attempted fix for #1229 - multiple entries in node list for same host

Hey all, this is my attempt at a fix for #1229. It sounded like the approach seemed reasonable, so I thought I'd take a stab at it.
Tests pass for me locally against the unstable branch of redis. I tried to add a new test for my specific case where equality check in HostAndPort fails, so multiple nodes end up in the list, but there's already code to convert <IP_ADDRESS> --> localhost in HostAndPort, so it wasn't clear how I'd be able to test my particular situation safely in many different test environments.
I based my fix on the 2.8 branch, but I can switch it to the 2.9 or master branches if that makes more sense.
Thanks for considering!

@roblg thanks for submitting a patch. I believe it's heading in the proper direction. In order to test this you might try to setup JedisCluster like this:
    Set<HostAndPort> jedisClusterNode = new HashSet<HostAndPort>();
    jedisClusterNode.add(new HostAndPort("localhost", 7379));
    jedisClusterNode.add(new HostAndPort("some_other_host", 7379));
    JedisCluster jc = new JedisCluster(jedisClusterNode);
    // Assert on jc.getClusterNodes().size()

With the previous code JedisCluster will populate all the hosts in the cluster plus "some_other_host" (even though it's invalid). Your test needs to assert that supplied hosts are not added into the node list.

@marcosnils good call. I realized while I was writing the "invalid host" test that I was mistaken about how the 127 vs. localhost equality was happening. I actually got the "broken" behavior if I created a new HostAndPort("localhost", 7379), so I included a test for that as well.
PR updated.

@roblg LGTM. I'd like @HeartSaVioR or @xetorthio to review before merging.
I'd also like to schedule this for 2.9 as it changes the way JedisCluster is initializing. Even though I believe it "shouldn't" cause any problems, I propose to move it to a minor release just in case

@roblg
LGTM. Thanks for the work!
Btw, it would be more sense to move to master branch. We can take care of backporting if necessary.

@HeartSaVioR @marcosnils would you like me to update the PR to be based on master?

@roblg yes please. We'll take care to downmerge to 2.9

Yes, if you don't mind. Thanks in advance!

@marcosnils You're really fast! lol

@HeartSaVioR :tongue: going to bed. Can you please merge once changes are made?. Thx!.

@roblg Ah, one thing we didn't say... PR should be re-created against master. It's a limitation of Github PR.

@HeartSaVioR yeah that kind of surprised me. I've been using Bitbucket at work for several years. Got it sorted out though (I hope).


Can support clone mode

Hi mfuu,
Thank you for fixing the last issue v-model.
Recently I used the latest version and ran into another problem. In contrast to vue-draggle component library, which can support pull=clone mode but can't support virtual scrolling, vue-virtual-drag-list is a component that allows list groups to be cloned without adding new elements (put:false,pull:'clone'). Another list group can drag elements can also add elements (put: true/add, pull: true/remove).
See if you need to enhance the functionality of this component

sorry for late reply, please update to the latest version and use `pull: 'clone'´ in group.