Add homeAccountId to BaseException

What
Adding homeAccountId field in BaseException class to pass the homeAccountId information to errorHandler
Why
The interactive requests do not have the homeAccountId field populated to begin with. But this field is required to be returned back to application when we return IntuneAppProtecttionPolicyRequiredException. Otherwise applicaiton failed to do MAM registration.
How
Adding homeAccountId field in BaseException, and exposing a method to set it.
Testing
This change is part of fixing the bug https://identitydivision.visualstudio.com/Engineering/_workitems/edit/1998929/
Verified the scenario where Teams app could not sign in if user (with MAM and MFA policies) sign out once or if user tries to sign in after device registration
The changes to setHomeAccountId fields are in this Broker PR https://github.com/AzureAD/ad-accounts-for-android/pull/1975

We are returning IntuneAppProtectionPolicyRequiredException as opposed to BaseException right? So why do we need user id here on BaseException? I mean we are already exposing user id on IntuneAppProtectionPolicyRequiredException so apps should be using that.

We don't have the homeAccountId populated when we are creating IntuneAppProtectionPolicyRequiredException. This change is to enable passing homeAccountId so that we can return the IntuneAppProtectionPolicyRequiredException with it.
Corresponding Broker PR https://github.com/AzureAD/ad-accounts-for-android/pull/1975

We are returning IntuneAppProtectionPolicyRequiredException as opposed to BaseException right? So why do we need user id here on BaseException? I mean we are already exposing user id on IntuneAppProtectionPolicyRequiredException so apps should be using that.

We don't have the homeAccountId populated when we are creating IntuneAppProtectionPolicyRequiredException. This change is to enable passing homeAccountId so that we can return the IntuneAppProtectionPolicyRequiredException with it. Corresponding Broker PR AzureAD/ad-accounts-for-android#1975

I think populating it totally makes sense. My question was more about why we are populating it on BaseException as opposed to IntuneAppProtectionPolicyRequiredException?

Closing this PR. As we no longer need this change.


Fix ancestor layer traversal (#1484)

Signed-off-by: Dhammika Pathirana<EMAIL_ADDRESS>

Thanks, looks good to me. I broke this in commit 07342f7.
Could you write a test case for this, please? I'm a bit surprised this wasn't caught by existing tests. You need a branch of a branch to trigger it, I guess.

This was tripping #1484 and that test includes compaction splits. Probably don't see this in regular tests because of default compaction_distance and gc interval.

Thanks, looks good to me. I broke this in commit 07342f7.
Could you write a test case for this, please? I'm a bit surprised this wasn't caught by existing tests. You need a branch of a branch to trigger it, I guess.

This was tripping #1484 and that test includes compaction splits. Probably don't see this in regular tests because of default compaction_distance and gc interval.

Hmm, I don't think compaction & GC should affect this. Maybe I'm missing something. And I'm a bit surprised that test triggered this, AFAICS you would need to have a branch of a branch to be affected. I guess many of our tests actually do create a branch of a branch, as they first create 'empty' branch, and then the test branch from the empty branch. So the hierarchy is 'main <- empty <- [test branch]'. I think it'd be good to have a more explicit test case for a branch of a branch.

Hmm, I don't think compaction & GC should affect this. Maybe I'm missing something. And I'm a bit surprised that test triggered this, AFAICS you would need to have a branch of a branch to be affected. I guess many of our tests actually do create a branch of a branch, as they first create 'empty' branch, and then the test branch from the empty branch. So the hierarchy is 'main <- empty <- [test branch]'. I think it'd be good to have a more explicit test case for a branch of a branch.

Sure, I'll add a test to instrument this case. There are some tests that create grand-parent branches but I'm not quite sure why we don't hit this.

Thank you for fixing this.
It seems that my test caught this error too
I wonder, if this bug is a core reason of the #1433 issue ?

:+1: Does look like it's same issue. It's subtle and hard to repro.

Thank you for fixing this.
It seems that my test caught this error too
I wonder, if this bug is a core reason of the #1433 issue ?

+1 Does look like it's same issue. It's subtle and hard to repro.

Actually on second look I think it's a different issue. This is from 3 levels or more branching and page lookup getting stuck in immediate ancestor branch.

Both new tests - the unit test and the python test - are passing even without the code change.

Both new tests - the unit test and the python test - are passing even without the code change.

Ya, that's correct.
This is because without compaction layer map search always return a image layer match here,
https://github.com/neondatabase/neon/blob/867aede71516756ff0ec1dba540fe7fc23bb7113/pageserver/src/layered_repository.rs#L1458
but with compaction, key-range mismatch trigger layer map search failures. I haven't figured out a layer setup just right to trip it in tests :)

@hlinnaka fixed pytest to reproduce it. What do you think?


v0.5.10

Minor release with the following changes:

[CONFIG]: add timeout option for api in uiconfig (@generalectric - #1249)
[DEP]: Hotfix - pg version on docker (@nourchawich - #1257)
[DOCS]: Fix some broken links on the documentation (@arcxyz - #1261)
[HOTFIX]: Fix UI port (@cmroche - #1264)
[DB]: add schema to postgresql config for UI/API (@generalectric - #1271)
[EXCHANGE/KRAKEN]: Retry handling only on recoverable errors (@cmroche - #1278)
[DOCS]: typo (ajaz -> ajax) (@andyklimczak - #1279)
[BACKTESTER]: Fixing calculation issues with roundtrip table (@gauzzastrip - #1282)
[DB]: fix sqlite pragma to use config setting (@generalelectric - #1289)
[STRATS]: dynamically load indicators (@Gab0 - #1301)
[EXCHANGE/BITCOIN-CO-ID]: Add Bitcoin-co-id exchange (@danKHUU - #1303)
[UI]: FIX: upstream log messages again to server stdout (@andyklimczak - #1314)
[DOCS]: fix backtesting typos (@levithomason - #1321)
[DOCS]: improve layout of supported exchange table (@levithomason - #1322)
[DOCS]: fix link to example strats (@mcrust - #1329)
[STRATS/TULIP]: Fix for Tulip ADX (@mkondel - #1330 )
[EXCHANGE/KRAKEN]: Fixing prefixless alt coins in getProtfolio (kraken) + fee fix (@cmroche - #1335)
[PLUGIN] add IFTTT plugin (@TylerBJohnson - #1336)
[UI]: force all date rendering to UTC, fix #895 (@askmike - 2c5306e12bdad43a852199dac6e41a79628a6a69)

Dhe most downloaded docker image  https://hub.docker.com/r/barnumd/gekko/tags/ was last updated 7 months ago . Is this the 'official' docker image ?

@ovidiubuligan Based on the name of the owner, I would say that was an unofficial image. I've pushed yet another unofficial image in the mean time, feel free to grab it (from the 0.10.5 release). https://hub.docker.com/r/kurifu/gekko/ I'll see if I can automate the update of the image for the future.

@ovidiubuligan I've deleted and re-setup the repo above so that it is not automatically built from GitHUB, using a fork that I update regularly from this one. If you have some time, please visit and give the DockerHUB repo a star, it will help attract more people in the future to a regularly updated version.


Game screen turns green

My screen turns green after following directions. It was normal before doing it. I have an msi 65 stealth with a 2070 graphics card i9 i believe. Please help. Conment on my twitter so i can see the response. Thanku
https://twitter.com/UnMetalAlex/status/1488669301464834048?t=Td8X-hUn7ilUOWiQJ1L-Ug&s=19

I even self patch the 4gigs to see if that would fix it and changed my nvidia settings back to balanced. Plz help

Showing that it is normal before i do all the changes. And that i did download ur 1.0 version 18 part rar and opened successfully with password.

Can you try replacing "dinput8.dll" with this new one?
dinput8.zip
This one has the config menu turned off, just in case ImGui is the issue. That's the only possible cause I can think of :/

Can you try replacing "dinput8.dll" with this new one? dinput8.zip
This one has the config menu turned off, just in case ImGui is the issue. That's the only possible cause I can think of :/

Ok. I will try and report back. Thank you.

Can you try replacing "dinput8.dll" with this new one? dinput8.zip
This one has the config menu turned off, just in case ImGui is the issue. That's the only possible cause I can think of :/

Unfortunately it still turns green. I delete bio4 before putting in new one. I copy/paste into the bin32 thingy before doing the bio4. Even had to exclude Norton from deleting the dll8 thing. Plz help. I think i have a pretty good gaming laptop

If you delete dinput8.dll and open the game, is it still green?

If you delete dinput8.dll and open the game, is it still green?

Yes. No longer green. Thank you. What does dinput8 dll supposed to do? Id like to know. Thanku

Deleting it isn't a solution, sadly. The HD project needs it to fix a bunch of limitations of the original game.

New issue. Plz dont close. Now when i press start to play. New game. I picked Easy. It just closes out! Whole game stops

Yeah, that's because you need dinput8 for the game to work :/
Can you see if this version works?
dinput8.zip

Yeah, that's because you need dinput8 for the game to work :/
Can you see if this version works? dinput8.zip

Unfortunately not. Still nice and green. I dont want to play Matrix Evil 4. I am very patient. I did wait 8 years after all for this. I am so close i can taste it. Should i delete dinput8.ini and only keep ur dinput8.dll ? Is it a possible conflict with nvidia gsync?

Wait a second. On my computer screen its normal. But not on my lg cx . I just checked. I have the latest in hd cord 2.1 4k. So idk.

I'd suggest turning off each setting in the .ini one by one (especially the ones that are related to display) and retry the game every time you disable a setting. Might help to locate which tweak caused the issue.

Should i delete dinput8.ini and only keep ur dinput8.dll

No, you should have both.

Wait a second. On my computer screen its normal. But not on my lg cx . I just checked. I have the latest in hd cord 2.1 4k. So idk.

hmm, try changing "FixDisplayMode" to "false" in the .ini file.

Ok. That worked. I even did it with the original dinput8.ini using Notepad+

What does turning it false do?

One more question. I forgot how to quit game without shift tabbing force quit

Ok. That worked. I even did it with the original dinput8.ini using Notepad+

Oh, nice. If you use the original dinput8.dll file from the HD project, with "FixDisplayMode" set to false, it still works, right?
That option makes the game run on non-60Hz mointors. Not sure why it would cause the game to be green for some reason. Maybe the game is picking up some display mode that doesn't work correctly with your TV or something like that?

One more question. I forgot how to quit game without shift tabbing force quit

You press ESC when in-game, then click on "retry or load". There will be an option to return to the main menu. From there, you can quit the game.

Ok. I can also redo everything from start just to verify all this. So give me a second. Thankyou. And i am happy now. Im glad to have been the oddball in the situation cause im pretty tech handy.

Alright. New update.  Then i dont need to change anything. Very odd.  But if i use  both displays (not extended) i have to turn that option to False in notepad+

I see. Well, at least we have a workaround untill we can figure out why that happens.
Thank you for reporting the issue!

Thankyou greatly for ur work.

That's the only thing I can think of too - one of my worries with the FixDisplayModes patches was something like that could happen, didn't think we'd see it so soon though.
@MetalGearAlex1 if you're still around (or if anyone else has an issue like this), could you try running this EXE while connected to your TV, and then open the modes.txt file it creates & copy contents here?
D3D9Adapters.zip

Ok. I will give it a try. I will go to 1/2 display setting and do what u said. I just left it display 2 only to avoid the green screen. I will let u know in about an hour or sooner if thats ok.

Im gonna go do it now. But what is ironic about all this is i opened up a github account to find fixes for the pcsx2 regarding Resident Evil 4 many years ago. I feel honored to be the test subject again.

Maybe the game is picking up some display mode that doesn't work correctly with your TV or something like that?

That's the only thing I can think of too - one of my worries with the FixDisplayModes patches was something like that could happen, didn't think we'd see it so soon though.
@MetalGearAlex1 if you're still around (or if anyone else has an issue like this), could you try running this EXE while connected to your TV, and then open the modes.txt file it creates & copy contents here?
D3D9Adapters.zip

couldn't click on exe while ingame. don't know how to minimize but this is what text shows normally before.
#0 - 640x480@120
#1 - 640x480@59
#2 - 640x480@60
#3 - 640x480@119
#4 - 640x480@100
#5 - 720x480@120
#6 - 720x480@60
#7 - 720x480@59
#8 - 720x480@100
#9 - 720x480@119
#10 - 800x600@120
#11 - 800x600@60
#12 - 800x600@119
#13 - 800x600@100
#14 - 1024x768@120
#15 - 1024x768@60
#16 - 1024x768@119
#17 - 1024x768@100
#18 - 1152x864@120
#19 - 1152x864@60
#20 - 1152x864@119
#21 - 1152x864@100
#22 - 1176x664@50
#23 - 1176x664@60
#24 - 1176x664@59
#25 - 1280x720@120
#26 - 1280x720@60
#27 - 1280x720@59
#28 - 1280x720@50
#29 - 1280x720@100
#30 - 1280x720@119
#31 - 1280x800@120
#32 - 1280x800@60
#33 - 1280x800@119
#34 - 1280x800@100
#35 - 1280x960@120
#36 - 1280x960@60
#37 - 1280x960@119
#38 - 1280x960@100
#39 - 1280x1024@120
#40 - 1280x1024@60
#41 - 1280x1024@119
#42 - 1280x1024@100
#43 - 1366x768@120
#44 - 1366x768@60
#45 - 1366x768@59
#46 - 1366x768@50
#47 - 1366x768@24
#48 - 1366x768@23
#49 - 1366x768@25
#50 - 1366x768@30
#51 - 1366x768@29
#52 - 1366x768@119
#53 - 1366x768@100
#54 - 1600x1024@120
#55 - 1600x1024@60
#56 - 1600x1024@59
#57 - 1600x1024@50
#58 - 1600x1024@24
#59 - 1600x1024@23
#60 - 1600x1024@25
#61 - 1600x1024@30
#62 - 1600x1024@29
#63 - 1600x1024@119
#64 - 1600x1024@100
#65 - 1680x1050@120
#66 - 1680x1050@60
#67 - 1680x1050@59
#68 - 1680x1050@50
#69 - 1680x1050@24
#70 - 1680x1050@23
#71 - 1680x1050@25
#72 - 1680x1050@30
#73 - 1680x1050@29
#74 - 1680x1050@119
#75 - 1680x1050@100
#76 - 1920x1080@120
#77 - 1920x1080@60
#78 - 1920x1080@59
#79 - 1920x1080@50
#80 - 1920x1080@24
#81 - 1920x1080@23
#82 - 1920x1080@25
#83 - 1920x1080@30
#84 - 1920x1080@29
#85 - 1920x1080@119
#86 - 1920x1080@100
#87 - 3840x2160@60
#88 - 720x576@120
#89 - 720x576@50
#90 - 720x576@100
#91 - 720x576@119
#92 - 320x200@60
#93 - 320x200@144
#94 - 320x240@60
#95 - 320x240@144
#96 - 400x300@60
#97 - 400x300@144
#98 - 512x384@60
#99 - 512x384@144
#100 - 640x400@60
#101 - 640x400@144
#102 - 640x480@144
#103 - 800x600@144
#104 - 1024x768@144
#105 - 1152x864@144
#106 - 1280x600@60
#107 - 1280x600@144
#108 - 1280x720@144
#109 - 1280x768@60
#110 - 1280x768@144
#111 - 1280x800@144
#112 - 1280x960@144
#113 - 1280x1024@144
#114 - 1360x768@60
#115 - 1360x768@144
#116 - 1366x768@144
#117 - 1400x1050@60
#118 - 1400x1050@144
#119 - 1440x900@60
#120 - 1440x900@144
#121 - 1600x900@60
#122 - 1600x900@144
#123 - 1680x1050@144
#124 - 1920x1080@144

this is when it's on tv only display 2.. when it doesn't turn green.
#0 - 640x480@120
#1 - 640x480@59
#2 - 640x480@60
#3 - 640x480@119
#4 - 640x480@100
#5 - 720x480@120
#6 - 720x480@60
#7 - 720x480@59
#8 - 720x480@100
#9 - 720x480@119
#10 - 800x600@120
#11 - 800x600@60
#12 - 800x600@119
#13 - 800x600@100
#14 - 1024x768@120
#15 - 1024x768@60
#16 - 1024x768@119
#17 - 1024x768@100
#18 - 1152x864@120
#19 - 1152x864@60
#20 - 1152x864@119
#21 - 1152x864@100
#22 - 1176x664@50
#23 - 1176x664@60
#24 - 1176x664@59
#25 - 1280x720@120
#26 - 1280x720@60
#27 - 1280x720@59
#28 - 1280x720@50
#29 - 1280x720@100
#30 - 1280x720@119
#31 - 1280x800@120
#32 - 1280x800@60
#33 - 1280x800@119
#34 - 1280x800@100
#35 - 1280x960@120
#36 - 1280x960@60
#37 - 1280x960@119
#38 - 1280x960@100
#39 - 1280x1024@120
#40 - 1280x1024@60
#41 - 1280x1024@119
#42 - 1280x1024@100
#43 - 1366x768@120
#44 - 1366x768@60
#45 - 1366x768@59
#46 - 1366x768@50
#47 - 1366x768@24
#48 - 1366x768@23
#49 - 1366x768@25
#50 - 1366x768@30
#51 - 1366x768@29
#52 - 1366x768@119
#53 - 1366x768@100
#54 - 1600x1024@120
#55 - 1600x1024@60
#56 - 1600x1024@59
#57 - 1600x1024@50
#58 - 1600x1024@24
#59 - 1600x1024@23
#60 - 1600x1024@25
#61 - 1600x1024@30
#62 - 1600x1024@29
#63 - 1600x1024@119
#64 - 1600x1024@100
#65 - 1600x1200@120
#66 - 1680x1050@120
#67 - 1680x1050@60
#68 - 1680x1050@59
#69 - 1680x1050@50
#70 - 1680x1050@24
#71 - 1680x1050@23
#72 - 1680x1050@25
#73 - 1680x1050@30
#74 - 1680x1050@29
#75 - 1680x1050@119
#76 - 1680x1050@100
#77 - 1920x1080@120
#78 - 1920x1080@60
#79 - 1920x1080@59
#80 - 1920x1080@50
#81 - 1920x1080@24
#82 - 1920x1080@23
#83 - 1920x1080@25
#84 - 1920x1080@30
#85 - 1920x1080@29
#86 - 1920x1080@119
#87 - 1920x1080@100
#88 - 1920x1200@120
#89 - 1920x1440@120
#90 - 2048x1536@60
#91 - 2048x1536@59
#92 - 2048x1536@50
#93 - 2048x1536@24
#94 - 2048x1536@23
#95 - 2048x1536@25
#96 - 2048x1536@30
#97 - 2048x1536@29
#98 - 2560x1440@120
#99 - 2560x1600@60
#100 - 2560x1600@59
#101 - 2560x1600@50
#102 - 2560x1600@24
#103 - 2560x1600@23
#104 - 2560x1600@25
#105 - 2560x1600@30
#106 - 2560x1600@29
#107 - 3840x2160@60
#108 - 3840x2160@59
#109 - 3840x2160@50
#110 - 3840x2160@120
#111 - 3840x2160@119
#112 - 3840x2160@100
#113 - 3840x2160@24
#114 - 3840x2160@23
#115 - 3840x2160@25
#116 - 3840x2160@30
#117 - 3840x2160@29
#118 - 4096x2160@60
#119 - 4096x2160@59
#120 - 4096x2160@50
#121 - 4096x2160@120
#122 - 4096x2160@119
#123 - 4096x2160@100
#124 - 4096x2160@24
#125 - 4096x2160@23
#126 - 4096x2160@25
#127 - 4096x2160@30
#128 - 4096x2160@29
#129 - 720x576@120
#130 - 720x576@50
#131 - 720x576@100
#132 - 720x576@119

Thanks, it's interesting that your screen shows so many modes, even strange ones like 25/29Hz etc. I think issue is our patch only sees the first instance of each resolution, so if the list has eg. 1920x1080@25Hz followed by 1920x1080@60Hz, the game only ends up seeing the 25Hz one, good chance your screen is probably exposing something like a 25Hz mode but doesn't actually support it properly, turning it green instead.
Also didn't realize you had two displays connected, game seems to have really poor support for that, wouldn't be surprised if that is related somehow (eg. it seems to always check adapter 0 even if you edit INI to use other adapters)
Might try reimplementing the display-mode related funcs soon instead of just patching, so we could probably add stuff to only allow modes with same refresh rate as desktop.

i agree with you. seems like a hopefully easy fix for I'm sure there are people that may have this issue especially with laptops maybe.  thank you very much. just respond to me if you need me to try more things.

another note. i only edit ini to FALSE when on 1/2 displays.  but on tv only display to fix green screen. i do not have to edit the ini to FALSE.

I think issue is our patch only sees the first instance of each resolution, so if the list has eg. 1920x1080@25Hz followed by 1920x1080@60Hz, the game only ends up seeing the 25Hz one

So.. that is probably the reason they used the 60Hz check for the resolution list instead of comparing height+width. Hm.

New question. I got leon stuck looking up while using xbox controller while running. Happemed after i tried the f1 tweaks i think. But on mouse/keyboard he is fine while im running. Even switched out the xbox controller. Is there a way to reset the original re4 steam file settings? I think this is seperate from the patch itself.

I'm not sure why this is happening but I just came across that issue right now and what worked was plugging in the controller via USB to my PC and it fixes the issue, I can then unplug it and works fine. When i restart though i have to do it again because it resets back to the buggy mess it is. hope this helps.
update:
OK, so I think I found a fix. The problem is the game is recognize multiple controller profiles and it gets confused. What I did was go to Steam - Settings - Controller - General Controller Settings and ticked the following boxes: Guide Button Focuses Steam, Xbox Configuration Support and Generic Game-pad Configuration Support.

@MetalGearAlex1 any chance you can try this build out, and see if you can get green screen to occur?
re4_tweaks1.7.4-refreshRateCheck.zip
This one should filter the display modes so only ones that are 59Hz+ can be chosen, but I'm not sure if it'll actually help since the function we patch here (second EnumAdapterModes func) only seems to be ran when you open options menu, so not sure if that func is actually causing it, could be the first func we patch instead somehow.

Yes. I will give that a try.

Nope. Still green when 2 displays with those files i put in.
But on tv only display. Not green

Ahh too bad, but figured that'd probably be the case, I guess it must be something to do with our first patch that uses g_UserRefreshRate then - weird because that should be using refresh rate of desktop - but then again you are using two displays, so maybe it's picking refresh rate on the wrong one?

I will have to check it out in about 3 or 4 hours at the latest if thats ok. Im glad to help. It is fun to be part of the problem :) and the solution. I have been playing re4 repeatedly since ps2 days.

Thanks, so I guess that display is being forced to 120 but doesn't like it (I think it must be exposing 120 for game to try setting it though)
Could you try editing dinput8.ini, and change CustomRefreshRate to 60, and see if green screen appears at all with that?
Also could you try this build out: re4_tweaks1.7.4-EnumDisplayDevices.zip and see if green screen happens at all.
(make sure CustomRefreshRate is set back to -1 with that build)

I will try it. Fighting a gigante right now. I was also testing different resolutions in game. And discovered it turns green at a few them. One of them being the 4k option i think. Which is odd since i have a 4k lg cx. But no big deal. I will see what happens to ur tests.

Ok. I tried both things. Also did them both on 2 display and single display. No green screen at any resolution now. Seems it does not like 120. Forcing it to stay at 60 seems to be the answer.

Ahh nice, so the ZIP I posted also worked too? You had CustomRefreshRate set to -1 for that as well?

Yes. It was back to -1. And first test to 60 worked both ways. 2nd test with ur build worked being at -1 again. I dont know what u did. But i didnt have any more issues. Thank you. :)

Awesome! Glad to hear it helped, thanks for letting us know of the issue and all the testing too! Will hopefully have this merged in soon.

I have donated 60 $ to the cause because this is defibitely an HD rerelease i would pay for in store at a high... price. Stranger. Thanku.

OMG every open issue was tagged because of the formatting of # xx in this post. Is there a way to fix that?

lol
I tried removing the # xx in the post, but it looks like the mentions dont go away. Oh well.

Sho7ld be fixed now. I will come back to finish and celebrate this post when u get to 100 issues. Thanku


Retitle legend for DuckDB analysis charts

I mistakenly merged before applying changes to the DuckDB analysis charts regarding renamed legend titles which are more descriptive based on @gwaybio's feedback within #1 . This PR adds those changes in.

Thanks @falquaddoomi and @gwaybio !


When using drop on koalas dataframe and then merge, dropped columns persist

It seems that after dropping a col from a kdf, if we merge it with another one and create a new dataframe, the dropped column persists.
This is in databricks environment
e.g:
ks.__version__
'0.17.0'
df1=ks.DataFrame({'c1':[1,2,3],'c2':['a','b','c'],'c3':[0,1,2]})
df2=ks.DataFrame({'c1':[1,2,3],'c4':['x','y','z']})
df1=df1.drop('c2')
df3 = df1.merge(df2,on=['c1'])
print(df1.columns,df3.columns)
Index(['c1', 'c3'], dtype='object') Index(['c1', 'c2', 'c3', 'c4'], dtype='object')

Hi kermany :)
Maybe if you can, Could you give some detail environment your code are running at?
(maybe OS, python version, etc?)
because In my case, i failed to reproduce situation what you faced,
and there're no problem in jupyter notebook, python interpreter, python script either like below:

>>> df1=ks.DataFrame({'c1':[1,2,3],'c2':['a','b','c'],'c3':[0,1,2]})
>>> df2=ks.DataFrame({'c1':[1,2,3],'c4':['x','y','z']})
>>> df1=df1.drop('c2')
>>> df3 = df1.merge(df2,on=['c1'])
>>> print(df1.columns,df3.columns)
Index(['c1', 'c3'], dtype='object') Index(['c1', 'c3', 'c4'], dtype='object')

# issue782.py
import databricks.koalas as ks

df1=ks.DataFrame({'c1':[1,2,3],'c2':['a','b','c'],'c3':[0,1,2]})
df2=ks.DataFrame({'c1':[1,2,3],'c4':['x','y','z']})
df1=df1.drop('c2')
df3 = df1.merge(df2,on=['c1'])
print(df1.columns,df3.columns)

$ python issue782.py
Index(['c1', 'c3'], dtype='object') Index(['c1', 'c3', 'c4'], dtype='object')

Thanks for reporting, Have a nice day :)

hey @kermany thanks for reporting and @itholic thanks for trying it out.
Which koalas version did you use @kermany?

Thanks @itholic! This is using Databricks notebooks with koalas 0.17.0

The internal dataframe still has c2 even after dropping it.
df1 = ks.DataFrame({'c1': [1, 2, 3], 'c2': ['a','b','c'], 'c3': [0, 1, 2]})
df1 = df1.drop('c2')
df1._internal.sdf.show()

+-----------------+---+---+---+
|__index_level_0__| c1| c2| c3|
+-----------------+---+---+---+
|                0|  1|  a|  0|
|                1|  2|  b|  1|
|                2|  3|  c|  2|
+-----------------+---+---+---+

https://databricks-prod-cloudfront.cloud.databricks.com/public/4027ec902e239c93eaaa8714f173bcfc/7872419575180801/138200887632135/4764411236566651/latest.html

I think I found why this issue is happening for 0.17.0 (which me and @kermany use).

drop doesn't mutate DataFrame._internal.sdf but data_columns and column_index.
For 0.17.0, merge uses Dataframe._sdf which is Dataframe._internal.sdf.

But, from the commit below, merge starts using DataFrame._internal.spark_internal_df which selects columns with data_columns (code).
https://github.com/databricks/koalas/commit/468a757b658872c5379ac65ee9bcc8b1147bd3c9#diff-5ba644c40e914732959b9b4867f30c53L4991
I think @itholic uses the latest version which includes this commit and fails to reproduce this issue.

Seems like drop should actually drop the column in Spark DataFrame; otherwise, it might cause such issues somewhere else.
Yes, I used the latest branch too to reproduce.

@harupy since you debugged most of it, are you interested in fixing it? in drop(), I think self._sdf should drop the given column as well, not only in its metadata.

IMO, we should manage the columns only in metadata in such a case to avoid creating Spark DataFrame, but I have to admit I don't make it to handle all the cases yet.

Maybe we can drop the column for now ..? and we find a better way to clean up the unnecessary DataFrame creations.

Since the issue itself is now resolved, let me anyway resolve this issue.


[HELP] NODE DENY

Mar 07 11:36:57 WHIIPVR00291 microshift[164043]: kubelet E0307 11:36:57.280990  164043 kubelet.go:2471] "Error getting node" err="node \"whiipvr00291\" not found"

Mar 07 11:36:57 WHIIPVR00291 microshift[164043]: kube-apiserver I0307 11:36:57.315820  164043 node_authorizer.go:285] NODE DENY: 'WHIIPVR00291' &authorizer.AttributesRecord{User:(*user.DefaultInfo)(0xc010247380), Verb:"get", Namespace:"", APIGroup:"storage.k8s.io", APIVersion:"v1", Resource:"csinodes", Subresource:"", Name:"whiipvr00291", ResourceRequest:true, Path:"/apis/storage.k8s.io/v1/csinodes/whiipvr00291"}

Mar 07 11:36:57 WHIIPVR00291 microshift[164043]: kubelet I0307 11:36:57.316651  164043 csi_plugin.go:1036] Failed to contact API server when waiting for CSINode publishing: csinodes.storage.k8s.io "whiipvr00291" is forbidden: User "system:node:WHIIPVR00291" cannot get resource "csinodes" in API group "storage.k8s.io" at the cluster scope: can only access CSINode with the same name as the requesting node

Mar 07 11:36:57 WHIIPVR00291 microshift[164043]: kubelet E0307 11:36:57.381809  164043 kubelet.go:2471] "Error getting node" err="node \"whiipvr00291\" not found"

What is the cause of this and how to solve it ?

Thank you for reporting this issue, @AllenZMC.
From the log messages, it looks like your host name is defined with uppercase. We have a known issue about MicroShift not working in this configuration. See OCPBUGS-8411

@AllenZMC , The fix for this problem has been merged at #1453. Can you rebuild MicroShift binary in the main branch and confirm it works for you now?

/retitle [Bug] Microshift does not come up if the Hostname has an upper case letter

@ggiguash
How to cherry-pick to the release4.12 branch, I want to use the 4.12 branch to compile？

As commented in the PR #1470 , we'd like to avoid backporting this functionality to 4.12 release, which is a dev-preview.
/close


don't strip dots from usernames when creating facebook proofs

r? @maxtaco
@cjb and @malgorithms preferred to have dots preserved in Facebook usernames, since it's jarring to see your name rendered without them when you're used to seeing them. (Facebook is like GMail in that it lets you type whatever dots you want and still map to the same person.) Note that as with other proof types -- with the exception of HackerNews -- we still do case normalization. Does this sound reasonable to everyone?

👍


Updated k8s version & added prometheus (re-work)

Reworked from #329 @grkvlt
Updated k8s version & added prometheus
Ommited artifact renaming / invalid classpaths

Missing other pom.xml changes from #329

@grkvlt The pom changes have nothing to with the version bump or the addition of prometheus
This should be in a separate PR

Looks good & tested on Karaf/Classic on GCE and AWS

I've been through it all, comparing it closely with the changes made in https://github.com/brooklyncentral/clocker/pull/329 (which @grkvlt, @andreaturli and @mikezaccardo have tested I believe). It all looks really good. I've added a few very minor comments/questions.
There are two things I'd definitely like addressed or answered before merging:

the version should be 2.1.0-SNAPSHOT
why change hostname-override from HOST_SUBNET_ADDRESS to HOST_ADDRESS?

Also @m4rkmckenna I see this branch now has merge conflicts that will need to be resolved, before we can hit the merge button.

@aledsage

Updated versions in dfdb140
Replied to original comment

We had to swap the ip that the kubelet bound to as the "external" ip wouldnt resolve.
See here

LGTM - merging now.


Change adding handler code.

I noticed that if you had multiple spaces in the event string it added a too handlers[""]
eg:
joystick.on("start         end move", function(event) {
    ...
});

resulted in:
Object {start: Array[1], "": Array[8], end: Array[1], move: Array[1]}

good stuff. Thanks for noticing this.

Just made those changes, sorry I didn't follow the coding style across the rest of the code! Want me to squash the commits?

that's on me... I didn't put any rules about contributing. (I will soon)
In the meantime, would be really cool if you could also rephrase your commits to follow these guidelines otherwise the auto-generated changelog won't get your fix.
After that, I'll be happy to merge it :smile:.
Thanks a lot for your help ! :+1:

Awesome. Thanks a ton.


source distribution of inla

Are there somewhere instructions for a full source build of r-inla, including the inla binaries? I could only find binary install instructions from https://www.r-inla.org/download-install

Ah, I found some makefiles in r-inla/build-configs/linux

They are not very upgraded. Which OS you want to build for ?
On Tue, 2024-04-30 at 00:45 -0700, Edzer Pebesma wrote:

Ah, I found some makefiles in r-inla/build-configs/linux
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

For linux (I'm on ubuntu 22.04)

with
inla.binary.install()

you can install 22.04 builds
On Tue, 2024-04-30 at 03:31 -0700, Edzer Pebesma wrote:

For linux (I'm on ubuntu 22.04)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

you can download the build tree I use for Ubuntu 2204
hrue.r-inla-download.org/build64.tgz
if you want to compile it yourself
On Tue, 2024-04-30 at 03:31 -0700, Edzer Pebesma wrote:

For linux (I'm on ubuntu 22.04)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

Thanks. The first command, make download stops with
error: branch 'tag-' not found.
Fetching origin
Already up to date.
fatal: 'tags/' is not a commit and a branch 'tag-' cannot be created from it
Your branch is up to date with 'origin/devel'.

I guess because I didn't set the env. variable INLA_TAG. How should this be set?
Make taucs succeeded (after I changed gcc-12 to gcc-11 in GNUMakefile, and created directory /home/edzer/builds/build64/local/lib/).
make GMRFLib failed here:
ccache gcc-11 -I.. -I/home/edzer/builds/build64/local/include -DGMRFLib_PATH=\"/home/edzer/builds/build64/local/doc/GMRFLib/data\"  -I/home/edzer/builds/build64/local/include -O3 -ftree-vectorize -DINLA_WITH_PARDISO -funroll-loops -fvariable-expansion-in-unroller -Wall -Wextra -fopenmp -fopenmp-simd -pipe -pthread -fopenmp -I/usr/local/include -I/usr/include/suitesparse -DGITCOMMIT="\"111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01 2024 +0300\""   -c -MMD -MF .deps/fsort.d.tmp -o fsort.o fsort.c
In file included from fsort.c:36:
GMRFLib/fsort/fluxsort.h:45:10: fatal error: GMRFLib/fsort/quadsort.h: No such file or directory
   45 | #include "GMRFLib/fsort/quadsort.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:102: fsort.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm -f .deps/design.d.tmp
rm -f .deps/approx-inference--classic.d.tmp
make[1]: Leaving directory '/tmp/hr/build64/r-inla/gmrflib'
make: *** [GNUmakefile:75: GMRFLib] Error 2

any ideas how to get beyond that point?
The GNUmakefile suggests as final target to make inla, I guess that should be make inla.mkl? Anyway, trying to make inla.mkl it also breaks at
ccache g++-11 -I.. -I/home/edzer/builds/build64/local/include -DGMRFLib_PATH=\"/home/edzer/builds/build64/local/doc/GMRFLib/data\"  -I/home/edzer/builds/build64/local/include -O3 -ftree-vectorize -DINLA_WITH_PARDISO -funroll-loops -fvariable-expansion-in-unroller -Wall -Wextra -fopenmp -fopenmp-simd -pipe -pthread -DINLA_WITH_MKL -fopenmp -I/usr/local/include -I/usr/include/suitesparse -DGITCOMMIT="\"111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01 2024 +0300\""   -c -o high-prec-timer.o high-prec-timer.cpp
ccache gcc-11 -I.. -I/home/edzer/builds/build64/local/include -DGMRFLib_PATH=\"/home/edzer/builds/build64/local/doc/GMRFLib/data\"  -I/home/edzer/builds/build64/local/include -O3 -ftree-vectorize -DINLA_WITH_PARDISO -funroll-loops -fvariable-expansion-in-unroller -Wall -Wextra -fopenmp -fopenmp-simd -pipe -pthread -DINLA_WITH_MKL -fopenmp -I/usr/local/include -I/usr/include/suitesparse -DGITCOMMIT="\"111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01 2024 +0300\""   -c -MMD -MF .deps/fsort.d.tmp -o fsort.o fsort.c
In file included from fsort.c:36:
GMRFLib/fsort/fluxsort.h:45:10: fatal error: GMRFLib/fsort/quadsort.h: No such file or directory
   45 | #include "GMRFLib/fsort/quadsort.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:102: fsort.o] Error 1
make[1]: Leaving directory '/tmp/hr/build64/r-inla/gmrflib'
make: *** [GNUmakefile:62: inla.mkl] Error 2

Any help would be appreciated!

I think step 0 here would be to make a clean version of build64.tgz - it has a lot of binary objects in there - .so, .o, .a, .lib, .dylib etc, which look like hangovers from previous builds and other possibly non-open binaries.

Yeah, I did a
rm `find . -name *.so`
rm `find . -name *.o`

before I started.

You may need to be a bit more aggressive. That won't find versioned shareables eg libXYZ.so.1

You have to edit GNUmakefile to change some -IPATH... to where you are.
env INLA_TAG=devel make update
On Thu, 2024-05-02 at 06:29 -0700, Edzer Pebesma wrote:

Thanks. The first command, make download stops with
error: branch 'tag-' not found.
Fetching origin
Already up to date.
fatal: 'tags/' is not a commit and a branch 'tag-' cannot be created from it
Your branch is up to date with 'origin/devel'.
I guess because I didn't set the env. variable INLA_TAG. How should this be
set?
Make taucs succeeded (after I changed gcc-12 to gcc-11 in GNUMakefile, and
created directory /home/edzer/builds/build64/local/lib/).
make GMRFLib failed here:
ccache gcc-11 -I.. -I/home/edzer/builds/build64/local/include -
DGMRFLib_PATH="/home/edzer/builds/build64/local/doc/GMRFLib/data"  -
I/home/edzer/builds/build64/local/include -O3 -ftree-vectorize -
DINLA_WITH_PARDISO -funroll-loops -fvariable-expansion-in-unroller -Wall -
Wextra -fopenmp -fopenmp-simd -pipe -pthread -fopenmp -I/usr/local/include -
I/usr/include/suitesparse -
DGITCOMMIT=""111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01
2024 +0300""   -c -MMD -MF .deps/fsort.d.tmp -o fsort.o fsort.c
In file included from fsort.c:36:
GMRFLib/fsort/fluxsort.h:45:10: fatal error: GMRFLib/fsort/quadsort.h: No such
file or directory
   45 | #include "GMRFLib/fsort/quadsort.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:102: fsort.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm -f .deps/design.d.tmp
rm -f .deps/approx-inference--classic.d.tmp
make[1]: Leaving directory '/tmp/hr/build64/r-inla/gmrflib'
make: *** [GNUmakefile:75: GMRFLib] Error 2
any ideas how to get beyond that point?
The GNUmakefile suggests as final target to make inla, I guess that should be
make inla.mkl? Anyway, trying to make inla.mkl it also breaks at
ccache g++-11 -I.. -I/home/edzer/builds/build64/local/include -
DGMRFLib_PATH="/home/edzer/builds/build64/local/doc/GMRFLib/data"  -
I/home/edzer/builds/build64/local/include -O3 -ftree-vectorize -
DINLA_WITH_PARDISO -funroll-loops -fvariable-expansion-in-unroller -Wall -
Wextra -fopenmp -fopenmp-simd -pipe -pthread -DINLA_WITH_MKL -fopenmp -
I/usr/local/include -I/usr/include/suitesparse -
DGITCOMMIT=""111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01
2024 +0300""   -c -o high-prec-timer.o high-prec-timer.cpp
ccache gcc-11 -I.. -I/home/edzer/builds/build64/local/include -
DGMRFLib_PATH="/home/edzer/builds/build64/local/doc/GMRFLib/data"  -
I/home/edzer/builds/build64/local/include -O3 -ftree-vectorize -
DINLA_WITH_PARDISO -funroll-loops -fvariable-expansion-in-unroller -Wall -
Wextra -fopenmp -fopenmp-simd -pipe -pthread -DINLA_WITH_MKL -fopenmp -
I/usr/local/include -I/usr/include/suitesparse -
DGITCOMMIT=""111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01
2024 +0300""   -c -MMD -MF .deps/fsort.d.tmp -o fsort.o fsort.c
In file included from fsort.c:36:
GMRFLib/fsort/fluxsort.h:45:10: fatal error: GMRFLib/fsort/quadsort.h: No such
file or directory
   45 | #include "GMRFLib/fsort/quadsort.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:102: fsort.o] Error 1
make[1]: Leaving directory '/tmp/hr/build64/r-inla/gmrflib'
make: *** [GNUmakefile:62: inla.mkl] Error 2
Any help would be appreciated!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

I do not get why you want to compile your own. there are already precompiled
versions for several Linux OS's
inla.binary.install()

yes, it do contain prebuildt libraries. if you want a completely open source
version, you have to turn features off.
On Thu, 2024-05-02 at 08:03 -0700, Barry Rowlingson wrote:

You may need to be a bit more aggressive. That won't find versioned shareables
eg libXYZ.so.1
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

I do not get why you want to compile your own.

I think a lot of people use INLA for important work, and all I know use binary installs. I'm curious about the bus factor of the INLA project, its open source status, and whether I should use or recommend it for future work.

All the R-INLA code is completely open. It's build is too involved for CRAN and
it do, by default, depend on external binary only libs (essentially PARDISO).
We're working towards replacing the sparse libraries with a new open source one
based on tiles (https://icl.utk.edu/projectsfiles/plasma/html/doxygen/), but its
a lot of work. the build will then be even more involved, even though all is
open source.
We have discussed moving the R-interface on CRAN and require binary installs
outside, like JAGS require the jags program to the installed outside R. For this
I would need help by someone(s) who know how to handle CRAN
On Fri, 2024-05-03 at 02:26 -0700, Edzer Pebesma wrote:

I do not get why you want to compile your own.
I think a lot of people use INLA for important work, and all I know use binary
installs. I'm curious about the bus factor of the INLA project, its open
source status, and whether I should use or recommend it for future work.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

We have discussed moving the R-interface on CRAN and require binary installs outside, like JAGS require the jags program to the installed outside R.

Was this a public discussion, and if not is it public who you refer to by "we"? As a first step, IMO that would require a clean source code repository with clear instructions about how to build and install inla, and for instance a GitHub action that rebuilds it on every commit.

For this I would need help by someone(s) who know how to handle CRAN

Have you reached out to those who did this for jags (Martyn, Dirk)?

We=the people most closely involved in developing and maintaining the package (and related packages).

In the meantime I managed to compile inla, without pardiso:
/tmp/hr/build64$ local/bin/inla.mkl

	111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01 2024 +0300

*** Error: Expected argument after options.

Usage: local/bin/inla.mkl [-v] [-V] [-h] [-f] [-eVAR=VALUE] [-tA:B] [-mMODE] FILE.INI

and after quite a few tweeks on things in the tarball @hrue provided above. Is there from your side interest in the tweeks I had to make, and if so how should I provide them?

If you remove pardiso, then you should also remove libiomp5  which is required
since the paradiso lib include calls to Intels's openmp libraries, which is then
no longer needed, and one avoid potential conflict with libgomp from gcc
I know how the code works and I am able to edit Makefile's if I need to; but thx
anyway.
H
On Fri, 2024-05-03 at 12:03 -0700, Edzer Pebesma wrote:

In the meantime I managed to compile inla, without pardiso:
/tmp/hr/build64$ local/bin/inla.mkl
111175339d876568768a24f2b94df2cc7904b2c5 - Wed May 1 21:31:01 2024
+0300
*** Error: Expected argument after options.
Usage: local/bin/inla.mkl [-v] [-V] [-h] [-f] [-eVAR=VALUE] [-tA:B] [-mMODE]
FILE.INI
and after quite a few tweeks on things in the tarball @hrue provided above. Is
there from your side interest in the tweeks I had to make, and if so how
should I provide them?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Håvard Rue
Professor of Statistics
Chair of the Statistics Program
CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900
Kingdom of Saudi Arabia
@.***
Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

I know how the code works and I am able to edit Makefile's if I need to; but thx anyway.

OK, thanks, so from your side no worries about the open source status and/or bus factor.


Fix name handling of VMIs in VM templates

What this PR does / why we need it:
VMIs have to have the same name as VMs. Remove traces of code where in
some cases spec.template.metadata.name was taken into account instead
of metadata.name. If spec.template.metadata.name was given, some
imperative commands did not work, since virt-api and virt-controller got
confused.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3140
Special notes for your reviewer:
Release note:
NONE

Fixes #3140

Fixes #3140

:+1

/lgtm

@danielBelenky would be great if you could review it again.

/retest

@danielBelenky would be great if you could have another look.

/cc @davidvossel

put a hold on it just to see what you think about validation of the template.metadata.name field. Should we reject a vm with a vm.template.metadata.name field entirely since it isn't used?

I wanted to follow the pod template behaviour in k8s. Do you think this is too far fetched?

I wanted to follow the pod template behaviour in k8s. Do you think this is too far fetched?

no, that sounds reasonable. what happesn to the pod template's usage of name/generatename ? it's just ignored? I'm fine with mimicking whatever is done there.

no, that sounds reasonable. what happesn to the pod template's usage of name/generatename ? it's just ignored? I'm fine with mimicking whatever is done there.

Yes, it is just ignored.

/cherrypick release-0.30

/cherrypick release-0.30


Home Page

In the Home Page I would suggest replacing "an allergic" with "an allergy sufferer" or with an adjective "allergic".
In Chocolate Muffins Recipe there is an unnecessary dot after "12 muffins". I would capitalize first letters in the list entitled "Preparation before you bake" and would end them with dots.
and only fill HALF of maybe => and fill only HALF of each muffin cup
Use the mixer to combine all ingredients.(Note: => a space is missing
In "Butter biscuits":
is clean but dry => is clean and dry
a solid and greasy in touch ball. => a solid and greasy ball in touch
I would divide the instructions into smaller parts. For example before step 13 I would give a subtitle such as "AFTER 1 HOUR".
All in all, the guide is clear and easy to follow and contains all necessary instructions and recommendations.

In "Substitutes" => Milk I would write "PLENTY OF types"
In "Other tools" => Baking paper => Regardless of your choice ("of" is missing)
Regardless of your choice, before you put anything inside, you should put in baking paper first. (I added a comma)
In "Butter Biscuits Recipe", step 8 - I would put it as a note as it's not the essential part of the instructions.


Read multiple registers in one call

Is it possible to read multiple holding registers in a single call ?
i.e. modbusSTCPClient.ReadHoldingRegisters(1, 8000, 1);
followed by modbusSTCPClient.ReadHoldingRegisters(1, 9000, 1);

From what I see if I do the above I only get a 'raw_data' event being emmited for the first read register - 8000.

There are an example. The following code:
  //reading 1 register
  modbusSTCPClient.ReadHoldingRegisters(1, 0, 1);
  //reading 5 registers
  modbusSTCPClient.ReadHoldingRegisters(1, 10, 5);

get:
starting test
<Buffer 01 03 02 00 3b f9 97>
Map { '4x0' => <Buffer 00 3b> }

You only get the raw event and data event for the first indication.
It's because the client must wait for a slave response or timeout event for do a new indication.
The following code works fine.
 setTimeout(function(){
  //reading 1 register
  modbusSTCPClient.ReadHoldingRegisters(1, 0, 1);
  },50);

  setTimeout(function(){
  //reading 5 registers
  modbusSTCPClient.ReadHoldingRegisters(1, 10, 5);
  },150);

You can also add a new listener for data event.
modbusSTCPClient.ReadHoldingRegisters(1, 0, 1);
modbusSTCPClient.once('data', function(){
modbusSTCPClient.ReadHoldingRegisters(1, 10, 5);
})

I've been reading modbus tcp specification and should be possible to do what you want.
"Normally, on MODBUS serial line a client must send one request at a time. This means
that the client must wait for the answer to the first request before sending a second
request. On TCP/MODBUS, several requests can be sent without waiting for a
confirmation to the same server."
I will implement this feature and a "busy" event in next release.
Thanks for using this library.

Hi,
Nevermind, I implemented an event called 'new_available_request' in the modbus_master.js
This way, I`m notified when the currentModbusRequest has finished processing and I'm able to issue a new request.
Works fine for my intended usecase - asking the value of certain registers in one call.

Ok, I will fixed anyway in the next release.
Thanks.
2018-02-12 13:23 GMT+00:00 sergiupienar<EMAIL_ADDRESS>
Hi,
Nevermind, I implemented an event called 'new_available_request' in the
modbus_master.js
This way, I`m notified when the currentModbusRequest has finished
processing and I'm able to issue a new request.
Works fine for my intended usecase - asking the value of certain registers
in one call.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/hsocarras/nodbus-plus/issues/1#issuecomment-364921050,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWK3NNcL4LP4Wcgiode0G2lGK6XzLCksks5tUDtbgaJpZM4R-cOg
.


feat: [NO-JIRA] - Bump Pydantic version from 1.X to 2.X

This PR aims to upgrade elementary to start using Pydantic 2.0
Changes done:

Upgrade the Pydantic major version.
Update validator for field_validator due to deprecation.

Hey @afranzi thank you for submitting this PR!
The code quality and tests are failing.
Could you please install the packages from the dev.requirements.txt After that run the pre-commit and the tests:

pre-commit install
pre-commit run --all-files --verbose
pytest

🙏

Closing as unplanned for now.
Would love to understand the motivation for this a bit better.

Hello, any update on this request? it would be good to support the new pydantic version as I believe companies are moving ahead with the Pydantic 2.X version.

Hi, closing this PR as I had merged a different solution supporting both pydantic 1 and 2, should be available in our next release 0.14.1


feat: update Prometheus API to query metrics over a range

Partially Fixes (#1012)
Dependency: #1471
Changes made:

Updated prometheus.go to query metrics over a time frame

@rakshitgondwal thank you for contribution! :)

Thank you for the merge!


Depth buffer issue when using DepthOfFieldEffect

Description of the bug
Follow-up to #420.
By using dofEffect.circleOfConfusionMaterial.adoptCameraSettings and worldFocusDistance, I was able to get a dynamic target to change the focus. I got it to match up / work in @vanruesc's sandbox.
However, I still don't get it to work elsewhere...
For me it looks like the depth buffer is in a wrong format, and that the calculation to go from linearized near/far values to world distances and vice versa doesn't match some setting here. I checked that we're not using logarithmic depth.
Maybe these images of expected and not expected cases help:
In the below images,

the textured plane is cut off by near and far clip planes of 1 and 10
the white cube is the focus target - placed at 1, 10, ~5.5 and ~2.5

✔ Target at near clip plane - as expected: near clip plane is in focus

✔ Target at far clip plane - as expected: far clip plane is in focus

❌ Target at center between near and far - not expected: focus is too close

❌ Target at 1/4 between near and far - not expected: focus is too close

So there seems to be some nonlinearity going on, but I have no idea why.
To Reproduce
I'm unfortunately unsure how to reproduce / what's wrong in this setup so far. Happy to answer any questions to hopefully figure out what I'm doing wrong.
Expected behavior
Ability to set the worldFocusDistance and get that distance in focus.
Screenshots
see above
Library versions used

Three: 0.145.4
Post Processing: 6.29.1

Desktop

OS: Windows 10 and 11
Browser Chrome
Graphics hardware: RTX 2070 Max-Q and RTX 3070

Thanks for the screenshots :+1:
How are you setting the worldFocusDistance? You'd want to set this to the distance from the camera to the cube. Alternatively, try setting dofEffect.target to cube.position;

(my mistake convoluting R3F and three here, of course it's vanilla...)
Yes, this distance is the world distance from the camera to the cube. Also logged these values and made sure they match up with what I'd expect (e.g. in screenshots 2 and 3 the worldFocusDistance values logged are 5.5 and 2.5).
I get the same behaviour when using dofEffect.target = cube.position.
(side note, for that to work the cube must be a at sceen root / must not be transformed by it's parents if I'm not mistaken which I made sure of).

Strange.. I'll take a closer look this weekend.

side note, for that to work the cube must be a at sceen root / must not be transformed by it's parents if I'm not mistaken which I made sure of

Thanks for pointing that out. The implementation currently doesn't use getWorldPosition which is a bug.

For low near clip values (e.g. 0.01) I only get any focus when the target is at far clip distance, and basically all other target distances result in focus planes very close to the near clip plane.

Well, the shader does linearize depth, so this sounds like the camera settings aren't being set correctly for some reason.

Thanks!
Right now I'm literally calling this
        setInterval(() => {

            dof.circleOfConfusionMaterial.adoptCameraSettings(camera);
            dof.target = targetObject.position;

        }, 50);
        ```
to ensure for now not messing up any timing here and that the right camera values are used. (Of course tried without that as well),

What's weird is that it does seem to work for "target distance == near clip" and "target distance == far clip" but nothing inbetween.

Hi again! Were you by any chance able to look into the issue @vanruesc? Thanks!

Sorry, I've been too busy to get back to this. However, I was able to confirm that viewZToOrthographicDepth returns correct values.

I got it to match up / work in @vanruesc's sandbox.
However, I still don't get it to work elsewhere...

Any chance you could provide a failing example with code for me to look at?

@hybridherbst does this sandbox or video demonstrate the same issue you are talking about ?
https://user-images.githubusercontent.com/6885294/204822593-cee0b9d4-25a2-4f03-b472-fb0fc02db443.mp4

@optimus007 Thanks for the sandbox! The unexpected behaviour that can be observed when the target is off-center has to do with perspective projection. The object would probably remain in focus at all times with an orthographic camera. The effect translates the world distance to a linear, orthographic depth value which basically counters the perspective projection. I wonder if we could use perspective depth instead :thinking:
Right now, I'm busy with work and the v7 redesign. I'll eventually get to the DepthOfFieldEffect.
@hybridherbst Does your project use logarithmic depth? That would explain why you're only able to focus objects close to the near and far planes.

The expected behaviour described in this ticket would be achieved by calculating the distance from individual fragments to the camera instead of using the scene depth. This would result in a spherical focus field around the camera instead of a box-like field between the near and far plane.
I don't plan on changing the current CoC implementation in postprocessing v6, but the new implementation in v7 will use the distance-based approach.
Closing this in favor of #569.


Clean up docs

Codecov Report

Merging #59 (d341bea) into main (6222017) will decrease coverage by 18.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #59       +/-   ##
===========================================
- Coverage   92.33%   73.51%   -18.81%
===========================================
  Files           9        9
  Lines         860      857        -3
  Branches      111      111
===========================================
- Hits          794      630      -164
- Misses         43      196      +153
- Partials       23       31        +8

Impacted Files
Coverage Δ

esparto/_publish.py
33.80% <0.00%> (-52.11%)
:arrow_down:

esparto/_content.py
55.50% <0.00%> (-40.00%)
:arrow_down:

esparto/_adaptors.py
60.00% <0.00%> (-36.36%)
:arrow_down:

esparto/_contentdeps.py
73.91% <0.00%> (-26.09%)
:arrow_down:

esparto/_utils.py
67.50% <0.00%> (-25.00%)
:arrow_down:

esparto/_layout.py
92.22% <0.00%> (-0.60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6222017...d341bea. Read the comment docs.


Clone-able service

Add a trait that allows a client service to be cloned.

We've changed tactic here.


Remove generation of SPIR-V disassembly

Too much duplicated code and testing requirements. clspv should only output SPIR-V binary. Use SPIRV-Tools to disassemble the binary.
Start by deprecating the option in clspv.

Given the experimental nature of clspv and unless you know of someone relying on it (they shouldn't :)), I'm tempted to suggest to just remove support.

FWIW, no longer checking the output of -S roughly doubles the speed of the test suite. I can submit the change if people think it's the right time to do it.

Yes please if you have that change. In fact, you could also remove -S command line option and leave the code in SPIRVProducerPass to be stripped a bit later.

The main README.md confusingly still mentions the -S flag.

@notzed Thanks for reporting this!


Go Library Support

What happened:
Hi! 👋  I am leveraging the Syft Go library in my project to generate SBOMs. I'm wondering if there are any support expectations from maintainers around the library? Can I expect that this API will be around a while for use?
It appears that the CLI tool is well documented, but the library is not (that I could find). Is this for a reason? I'm worried that if I use the library, it might not be fully supported in the future. I'm essentially looking to see if the library is intended for use, and that it will be continued to be supported.
What you expected to happen:
I would have expected more documentation and/or examples of the Go Library in action.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
As a user, I would be happy to contribute some kind of documentation for the library, if the plan is to keep it around and make it more useable.

@sophiewigmore there are some thoughts on the next evolution of the API tracked in a previously opened issue: https://github.com/anchore/syft/issues/558 . Feel free to take a look -- feedback is more than welcome!


LSTM works now

The LSTM will only run on a 100 point long subsequence (default). Bidirectional LSTM hasn't been tested.

tested on a 100,000 data batch with hidden_size=64, lr=0.001


Add team response column to issues pending response table

Summary:
Add a "Team's Response" column to Issues Pending Response table in Tester Response Phase
Changes Made:

Add teamChosenResponse to the issue.model.ts and tester-response-template.model.ts
Add column to issue-pending.component.ts, issue-tables-columns.ts, and issue-tables.component.html

Proposed Commit Message:
Add team response column to issues pending response table

Testers currently need to click into each issue to see what the dev
team response is.

Let's show the response on the outside table.

@jonasongg Can you add a screenshot to show the change in UI?

@damithc Added, thanks!


Crash when pinging a port on an IPv6 host

When attempting to contact a host on a specific port, e.g. hostname:80, and the hostname resolves to an IPv6 address, vmPing crashes to desktop.
Wrapping the IPv6 address in square brackets and appending the port (as per RFC3986), e.g. [ipv6Addr]:80, results in the message "Unable to resolve hostname".
Sending a regular ICMP ping to the hostname or the IPv6 address (via vmPing or command line), works as expected. Using vmPing to connect to an IPv4 address on port 80 also works as expected.
vmPing 1.3.4, Windows 10 Enterprise 20H2 x64

Hey, I'll definitely take care of this. Hopefully within the next few weeks.

Fixed here: debe86d4459d83e1126e3f606091ea7b677fbd54
This will be included in the next release.

The changes are now available in release 1.3.8.


chore(ci): release main

:robot: I have created a release beep boop
docs: 0.33.3
0.33.3 (2024-12-09)
Bug Fixes

update header search page (#361) (4d4fc21)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

docs-v0.33.3
:sunflower:


Add support for JavaScript source maps

OpenNTF » JavascriptAggregator #739 SUCCESS
This pull request looks good
(what's this?)

OpenNTF » JavascriptAggregator #740 SUCCESS
This pull request looks good
(what's this?)

OpenNTF » JavascriptAggregator #741 SUCCESS
This pull request looks good
(what's this?)

OpenNTF » JavascriptAggregator #743 SUCCESS
This pull request looks good
(what's this?)

This change is pretty big.


Made Sonar a little bit happier.

SonarQube analysis reported 62 issues

 2 minor
 60 info

Watch the comments in this conversation to review them.
Top 10 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 SelectHymnWindow.cpp#L42: Function parameter 'callback' should be passed by reference.
 EntityEditor.cpp#L364: horizontal tab used
 EntityEditor.cpp#L366: horizontal tab used
 EntityEditor.cpp#L367: horizontal tab used
 EntityEditor.cpp#L369: horizontal tab used
 EntityEditor.cpp#L370: horizontal tab used
 EntityEditor.cpp#L371: horizontal tab used
 EntityEditor.cpp#L373: horizontal tab used
 EntityEditor.cpp#L374: horizontal tab used


Fix html viewer

Codecov Report
Base: 81.14% // Head: 90.45% // Increases project coverage by +9.31% :tada:

Coverage data is based on head (b1e9002) compared to base (f4b4477).
Patch coverage: 85.18% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           development      #19      +/-   ##
===============================================
+ Coverage        81.14%   90.45%   +9.31%
===============================================
  Files                8        9       +1
  Lines              663      786     +123
===============================================
+ Hits               538      711     +173
+ Misses             125       75      -50

Impacted Files
Coverage Δ

now_lms/__main__.py
0.00% <0.00%> (ø)

now_lms/auth.py
100.00% <ø> (+8.33%)
:arrow_up:

now_lms/config.py
69.56% <58.82%> (-25.68%)
:arrow_down:

now_lms/__init__.py
85.07% <65.75%> (+5.79%)
:arrow_up:

now_lms/bi.py
93.68% <100.00%> (+29.68%)
:arrow_up:

now_lms/db.py
100.00% <100.00%> (+7.25%)
:arrow_up:

now_lms/forms.py
100.00% <100.00%> (ø)

now_lms/misc.py
100.00% <100.00%> (ø)

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


stray logging statement in LoginView

Anyone want an 'easy pickings' ticket? :)
in LoginView, line 102, there is a line that says  logger.debug('Login process started').  That's not true, that statement is executed at import time.

Great @ccurvey, probably a regression from v0.50.0 to v1.0.0
Would you like to do a PR for that? I'd merge it in a hurry

Great @ccurvey, probably a regression from v0.50.0 to v1.0.0
Would you like to do a PR for that? I'd merge it in a hurry

That seems like a nice one to try to get me into the flow.  I'll see how fast I can get that set up.

That seems like a nice one to try to get me into the flow.  I'll see how fast I can get that set up.

That seems like a nice one to try to get me into the flow. I'll see how fast I can get that set up.

please PR to dev branch

That seems like a nice one to try to get me into the flow. I'll see how fast I can get that set up.

please PR to dev branch

fixed
https://github.com/knaperek/djangosaml2/commit/9fc197a12e2a7c2a1284ca493b9a98fcffb84340


[Bug] Activity played time is missing

Activity played time tracking is missing from the activity in Discord, but was working in 0.21 and works in arRPC (time is displayed on Discord)

Is this with a detected process or with an activity that uses IPC?

I've tested it only with an IPC activity

Which IPC activity? (preferably a game, or one I can test easily)

I've tried both VSCode extension and CustomRP but they don't show any time.
If I set a manual timestamp in CustomRP then the time shows but it's stuck at 00:00

What is the log output from rsRPC when trying these?

Here you go:
 Maicol@MAICOL-PC ~\Downloads  .\rsrpc.exe -d .\detectable.json
[2024-12-22 01:49:56] [IPC] Created IPC socket: \\.\pipe\discord-ipc-0
[2024-12-22 01:49:56] [Websocket] Server started on port 6463
[2024-12-22 01:49:56] [RPC Server] Starting client connector on port 1337...
[2024-12-22 01:49:56] [RPC Server] Starting IPC connector...
[2024-12-22 01:49:56] [RPC Server] Starting process server...
[2024-12-22 01:49:56] [RPC Server] Starting websocket connector...
[2024-12-22 01:49:56] [RPC Server] Done!  Thank you!


Cannot find module?

I created a file that imports my pure python module and runs a function, my hopes where to run transcrypt  on this and get my module as a javascript file with my example function as a hook into it.
Unfortunately it appears to Attempt to load module ... Can't find any of  .... error.
Unsure what I am doing wrong or how can I transcrypt a module ?

Hi
Sounds like what you want should be entirely possible.
Could you give me what's on the dots, so the exact, complete error mesage.
Also I'd like to know which Transcrypt version you're using.
Kind regards
Jacques

Thanks for the timely response.
https://github.com/ethereum/viper is the package
test.py:
#!/usr/bin/env python3

import viper
from viper import compiler_plugin

compiler = compiler_plugin.Compiler()

code = '''
funders:{sender: address, value: wei_value}[num]
nextFunderIndex:num
beneficiary:address
deadline:timestamp
goal:wei_value
refundIndex:num
timelimit:timedelta

# Setup global variables
def __init__(_beneficiary: address, _goal: wei_value, _timelimit: timedelta):
    self.beneficiary = _beneficiary
    self.deadline = block.timestamp + _timelimit
    self.timelimit = _timelimit
    self.goal = _goal

# Participate in this crowdfunding campaign
def participate():
    assert block.timestamp < self.deadline
    nfi = self.nextFunderIndex
    self.funders[nfi] = {sender: msg.sender, value: msg.value}
    self.nextFunderIndex = nfi + 1

# Enough money was raised! Send funds to the beneficiary
def finalize():
    assert block.timestamp >= self.deadline and self.balance >= self.goal
    selfdestruct(self.beneficiary)

# Not enough money was raised! Refund everyone (max 30 people at a time
# to avoid gas limit issues)
def refund():
    ind = self.refundIndex
    for i in range(ind, ind + 30):
        if i >= self.nextFunderIndex:
            self.refundIndex = self.nextFunderIndex
            return
        send(self.funders[i].sender, self.funders[i].value)
        self.funders[i] = None
    self.refundIndex = ind + 30
'''

print(compiler.compile(code))

and the output
(testpackage) a_:viper/ (feature/examples✗) $ cd blah                                                                                [18:09:03]
(testpackage) a_:blah/ (feature/examples✗) $ transcrypt                                                                                [15:21:37]
Transcrypt (TM) Python to JavaScript Small Sane Subset Transpiler Version 3.6.5
Copyright (C) Geatec Engineering. License: Apache 2.0

Usage: transcrypt [-h] [-a] [-b] [-c] [-d] [-dc] [-da] [-de] [-dm] [-dt] [-ds]
                  [-e [esv]] [-f] [-g] [-i] [-jk] [-jm] [-k] [-l] [-m] [-n]
                  [-o] [-p [parent]] [-r] [-s [symbols]] [-t] [-v] [-x ext]
                  [-*]
                  [source]

Aborted
(testpackage) a_:blah/ (feature/examples✗) $ transcrypt test.py                                                                                [15:21:42]
Transcrypt (TM) Python to JavaScript Small Sane Subset Transpiler Version 3.6.5
Copyright (C) Geatec Engineering. License: Apache 2.0

Error in program test.py, line 3:
	Attempt to load module: viper
	Can't find any of:
		/Users/a_/Backup/Experiments/testpackage/experiments/viper/blah/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/experiments/viper/blah/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/transcrypt/modules/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/transcrypt/modules/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/bin/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/bin/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python36.zip/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python36.zip/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/lib-dynload/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/lib-dynload/__javascript__/viper.mod.js
		/usr/local/Cellar/python3/3.6.0/Frameworks/Python.framework/Versions/3.6/lib/python3.6/__javascript__/viper.mod.js
		/usr/local/Cellar/python3/3.6.0/Frameworks/Python.framework/Versions/3.6/lib/python3.6/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/viper-0.0.1-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/viper-0.0.1-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/nose-1.3.7-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/nose-1.3.7-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/serpent-1.16-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/serpent-1.16-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/ethereum-1.3.7-py3.6.egg/__javascript__/viper.mod.js
		/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/ethereum-1.3.7-py3.6.egg/__javascript__/viper.mod.js

Aborted
(testpackage) a_:blah/ (feature/examples✗) $

Hi
Interesting project by the way.
There are some differences in the way Transcrypt handles module imports that are documented here.
It may be useful to see how some existing pure python modules have been handled.
I noticed that parser.py requires some standard library modules that cannot currently be compiled to javascript: Crypto.Hash | sha3, ast, tokenize, binascii, io, copy. That's not the reason for the current problem, but will be further down the list. I've not used modules with transcrypt, but hope this helps.

Due to your imports, Transcrypt is looking for viper.py. Since it can't find that it assumes that viper is a JS-only module and it starts looking for viper.mod.js.
Seems it's looking for viper.py in the wrong places.
From the error report you can deduce where it has been looking before it assumed that viper was a JS-only module and started to look in all those javascript subdirectories.
It will have attempted to find any of the following:
/Users/a_/Backup/Experiments/testpackage/experiments/viper/blah/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/transcrypt/modules/viper.py
/Users/a_/Backup/Experiments/testpackage/bin/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python36.zip/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/lib-dynload/viper.py
/usr/local/Cellar/python3/3.6.0/Frameworks/Python.framework/Versions/3.6/lib/python3.6/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/viper-0.0.1-py3.6.egg/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/nose-1.3.7-py3.6.egg/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/serpent-1.16-py3.6.egg/viper.py
/Users/a_/Backup/Experiments/testpackage/lib/python3.6/site-packages/ethereum-1.3.7-py3.6.egg/viper.py

Seems viper.py is in none of these locations.
Right?

yeah there is no such thing as viper.py,
it's an egg and installed via python setup.py install
as for dependencies they can mostly be cleaned up or made pure if it's possible to transpile

No further info.
Solved?
Will close it for now, feel free to reopen.


Improve readme + Tests 100% + MSI 100% + Psalm level 1 + PHP 8.0 static testing

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
-

👍


Fast upgrade

This is a small modification to allow users to manually change the upgrader scaling of upgradeSites.
Useful for when rapid room growth is needed.
Tested

Thanks for the suggestion, but I don't like this change -- it could make it very easy to unbalance the economy. I recently (I think since this PR) changed the upgrade scaling constant so that colonies will sit around with much less excess energy; this should balance itself without the need to adjust upgrade rates, which would be easy to forget to turn off.


"Pure" arrays not accessible in a Document

I am not sure if this is a bug or not.
I tried storing a "pure" array in a Document, like this:
$doc = Shanty_Mongo_Document:.create();
$doc->val = array('a','b','c');
$doc->save();
When I try to reload it, I get an error:
$doc = Shanty_Mongo_Document::find(...);
print implode(',', $doc->val);
Warning: implode(): Invalid arguments passed...
print_r($doc->val);
Shanty_Mongo_Document Object ( [_docRequirements:protected] => Array ( [_id] => Array ( [Validator:MongoId] => ) [_type] => Array ( [Array] => ) ) [_data:protected] => Array ( ) [_cleanData:protected] => Array ( 0 => 'a', 1 => 'b', 2 => 'c') ...
It seems that it transforms the array in a sub-document, but only during __get, as if I print_r($doc) everything seems fine. Browsing the source (0.3.0) I found this in Shanty_Mongo_Document (row 562):
if ($this->hasRequirement($property, 'Array')) {
return $this->_data[$property] = $data;
}
that leads me to thinking that I can force a requirement Array in the class, so I did it:
protected static $_requirements = array('val'=>'Array');
but then I get an exception:
Shanty_Mongo_Exception: No requirement exists for 'Array'
I solved it modifying Shanty_Mongo, adding on line 41:
static::storeRequirement('Array', new Shanty_Mongo_Validate_StubTrue());
This way everything works well (reading, writing, etc), or so it seems. :)
Is my patch correct or did you have something else in mind?

I have also found the control between making something a document / document_set / array slightly confusing and poorly documented.  What is the method to the madness?  I would be happy to rework the code or the documentation.

I also noticed that arrays, once stored in the DB, are retrieved as Shanty_Mongo_Document. I check whether the value is an array or a Shanty_Mongo_Document and when it's the latter, I use the export() method to get the original array.
I'm not sure if it is necessary to retrieve arrays as Documents from the DB, but it would indeed be more convenient if you got what you put in: an array.
By the way, if you change the requirement 'val' => 'Array' into 'val' => 'Validator:Array', it won't give you an error. The array returned as Document issue will still be there, however. I'm going to try your patch.

+1 for making the distinction between Document, DocumentSet and Array more clear.


fix for  [Sleep Quiet] Can't edit any setting #3484

Hello,
fixing the issue in Sleep Quiet app, found by @Tsht and cosmetic updates to 2 readme files.
I kindly ask for a review and if OK also for a merge.
Thanks!
Jan

also adding a modified version of the Nifty-A Clock (was not originally planned to be in this pull request, but i uploaded the files too early), if this is not OK, please reject the pull request and I will do 2 separate ones. thanks

Nice, thanks! No worries about the separate apps

@bobrippling >> thank you for verification and closing!


Make it easier to contribute

Work done:

Refactored configuration files
Made control messages configurable
Moved the auth stuff to a discord group
Uses a domain from config to generate archive URLs
Updated README with steps on getting started with contribution

Motivation
The old example config lacked a lot of values needed to get an instance of the bot up and running. This pull request makes it somewhat easier to get started.
Known Gripes
I load the configuration file manually twice in this pull request, which to me is somewhat unacceptable, however, I could not come up with a better way of creating what I wanted from it.

It's worth nothing I'd like to work on the web panel, however, there is no contributor chat where I would be able to collaborate with you on this. Rowboat is a super cool bot, so I'd love to contribute somewhat.

If you are looking for some sort of contributor chat: https://discordapp.com/invite/rowboat

Banned, lol.

@b1naryth1ef any chance of a re-review?

I spent some time on the weekend making this process easier with docker/docker-compose. I'll try to merge in some of your readme and config changes later tonight or tomorrow

sounds good

Works very well for me. Perhaps adding the emojis to the config would be helpful too.

closed, will make into new PR if needed


[Forms] Inline Label and Button 1px larger than the input

As you can see in the foundation 6 docs Inline Labels and Buttons section, the height of the label and the button is 1px larger than the input.
Tried in chrome and edge too, the heights are not the same.
I think the 22px height is only 21px for the input (possible rem calculation bug, or something else...).
Thanks,
Norbert.

Thanks! I think we fixed it in this commit 0bf07a2b0f801d6636e3e5cb41dbbb482ce765cd.


fix should not put bound expr into unbound group by list

Proposed changes
Issue Number: close #xxx

we put bound expr into unbound group by list by mistake.
This will lead to bind twice on some exprssion.
Since binding is not idempotent, below exception will be thrown for sql
select k5 / k5 as nu, sum(k1) from test group by nu order by nu nulls first

Caused by: org.apache.doris.nereids.exceptions.AnalysisException: Input slot(s) not in child's output: k5#5 in plan: LogicalProject[176] ( distinct=false, projects=[(cast(k5#5 as DECIMALV3(16, 10)) / k5#5) AS `nu`#14, sum(k1)#15], excepts=[] ), child output is: [nu#16, sum(k1)#15]
plan tree:
LogicalProject[176] ( distinct=false, projects=[(cast(k5#5 as DECIMALV3(16, 10)) / k5#5) AS `nu`#14, sum(k1)#15], excepts=[] )
+--LogicalAggregate[168] ( groupByExpr=[nu#16], outputExpr=[nu#16, sum(k1#1) AS `sum(k1)`#15], hasRepeat=false )
   +--LogicalProject[156] ( distinct=false, projects=[k1#1, (cast(k5#5 as DECIMALV3(16, 10)) / k5#5) AS `nu`#16], excepts=[] )
      +--LogicalOlapScan ( qualified=default_cluster:regression_test_nereids_syntax_p0.test, indexName=test, selectedIndexId=503229, preAgg=OFF, Aggregate function sum(k1) contains key column k1. )
    at org.apache.doris.nereids.rules.analysis.CheckAfterRewrite.checkAllSlotReferenceFromChildren(CheckAfterRewrite.java:108) ~[classes/:?]

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Fix build artifacts

This fix issue #180. go build is able to download a temporary source package and build the binaries into -pkgdir directory, which isolates the build environment from users' environment.
Also fixed the REPOSITORY_ROOT variable. This variable used to contains a trailing forward slash e.g. 'src/', which makes BUILD_DIR turns to an invalid path 'src//build'.

The download behavior of this go build command is undocumented yet and I think it was shipped with go1.11+. Tested on my personal laptop with go version 1.10 installed, directly invoke 'go build' command without downloading first failed - error message: unable to find the source package under GOPATH.


Added retryIfValue and onRetryIfValue to support retry on returned value condition

Resolves #45

Any news ?

Wouldn't retryIfResult and onRetryResult be better names?
"Value" seems a bit generic.
Additionally, are there any plans on merging this PR?


看了论文和代码想问一下，这实际上是一个关系分类的模型吗

semeval-10 和 TACRED这两个数据集是不是在验证集和测试集上都给定了实体对，然后预测该实体对的关系类别吗
所以这个模型不能直接给一句话，然后直接预测包含的实体对和关系吧...

Yes, if you have accessed to these two dataset, you can see that entities are given.
You can also jointly predict entities and their corresponding relations. For example, you can go through this paper: End-to-End Relation Extraction using LSTMs on Sequences and Tree Structures[(https://www.aclweb.org/anthology/P16-1105)]
Their model also detects entities.

Thank you very much~~


[FLINK-29586] Let write buffer spillable

Column format and remote DFS may greatly affect the performance of compaction. We can change the writeBuffer to spillable to improve the performance. In this way, at least one checkpoint will not result in a remote column file based compression.
This PR:

MergeTreeWriter can output rolling level0 files, because after the writeBuffer can spill, we should avoid too big file in level0.
Let UniversalCompaction not output level 0 result, because after the writeBuffer can spill, multiple level0 files will be generated, which may lead to useless work done by the compaction. We adjust the outputLevel to at least level1, which can ensure that the compaction must be effective.
Rename MemTable to WriteBuffer, it can spill now.
Introduce BinaryExternalSortBuffer.
Adjust MemoryPoolFactory, flushMemory can just flush memory, without producing level0 files.
Introduce write-buffer-spillable, about default value: When input changelog-producer is not enabled, it is enabled by default. When input changelog-producer is started, it is closed by default, because it currently does not support changelog producer input as input.

Performance improvement:
Before:

Checkpoint End to End duration: 30s-40s
After:

Checkpoint End to End duration: 50s-60s


Bump paas-admin to 0.106.0

What
Bumps paas-admin to v0.106.0
How to review

Code review

Who can review
Anyone

See also https://github.com/alphagov/paas-cf/pull/1877

Rebased - full diff is https://github.com/alphagov/paas-admin/compare/v0.104.0...v0.106.0

I reviewed Miki's changes and approved ... but I can't mark as approved because I'm the author of the PR


ability to use a heartbeat on workers and restart them if they fail to respond

This could help in case of error conditions that prevent worker processes from responding to requests.

2 years later and no comment. Guess this isn't gonna happen.
+1 anyway

The project is not abandoned, just not actively developed currently. Latest release was less than 2 months ago. There is hope :-)


GC: Replace updateUnusedRoutes with deleteSweepReadyNodes

updateUnusedRoutes was outdated and only used in GC test mode. Replaced the usage with deleteSweepReadyNodes which is used by sweep. This also makes the GC test mode logic similar to sweep which is the intended use of it - to mimic sweep in a cheap way in tests.

Looks ok to me, but I'd rather see Mark signing off of that change.


Feeshare: issues occur if protos are rebuilt

Discovered by:
bash scripts/protocgen.sh

Log:
panic: concrete type *types.MsgRegisterFeeShare has already been registered under typeURL /, cannot register *types.MsgCancelFeeShare under same typeURL. This usually means that there are conflicting modules registering different concrete types for a same interface implementation [recovered]
        panic: concrete type *types.MsgRegisterFeeShare has already been registered under typeURL /, cannot register *types.MsgCancelFeeShare under same typeURL. This usually means that there are conflicting modules registering different concrete types for a same interface implementation

Theory:
code changed and protos did not, or vice versa.  So now when protos get rebuilt things explode some.

Hopefully resolved by #439

two tests are failing:
--- FAIL: TestGenesisTestSuite (0.01s)
    --- FAIL: TestGenesisTestSuite/TestFeeShareInitGenesis (0.01s)
        suite.go:77: test panicked: parameter FeePercentage not registered
            goroutine 9 [running]:
            runtime/debug.Stack()
            	/usr/local/go/src/runtime/debug/stack.go:24 +0x64
            github.com/stretchr/testify/suite.failOnPanic(0x140005656c0, {0x101fce920, 0x14000e30830})

--- FAIL: TestKeeperTestSuite (0.03s)
    --- FAIL: TestKeeperTestSuite/TestCancelFeeShare (0.01s)
        suite.go:77: test panicked: parameter FeePercentage not registered
            goroutine 26 [running]:
            runtime/debug.Stack()
            	/usr/local/go/src/runtime/debug/stack.go:24 +0x64
            github.com/stretchr/testify/suite.failOnPanic(0x14000583040, {0x102a4ab40, 0x14000ed6be0})

@Reecepbcups / @vuong177 if you feel that this is now resolved, could you just note the root cause and close?  thanks!

Test "parameter FeePercentage not registered" failing was due to the PacketForwardMiddleware not being registered in the init params keeper function
Then protos switched from cosmos proto to gogoproto/proto since feeshare uses messages & not just queries (like the mint module)


removed duplicate section for GET /users/:id

The section "Get a user's profile information" appeared in duplicate. Removing second copy.
Awesome project BTW. I've considered myself a DRF master, but learned quite a few things from this recipe!

Superseded by PR #171


EWS Stub generation failed for iOS.

I've managed to generate ObjC code from ews WSDL file, but i get this strange function body.
+(NSMutableDictionary *)getPropertyMetaData {
    NSMutableDictionary *map = [OrderedDictionary dictionary];

    PicoPropertySchema *ps = nil;
    ps = [[PicoPropertySchema alloc] initWithKind:PICO_KIND_ANY_ELEMENT xmlName:@"allInternalOrAndOrRecipientIs" propertyName:@"allInternalOrAndOrRecipientIs" type:PICO_TYPE_OBJECT clazz:[FloJAXBElement<? extends Object> class]];
    [map setObject:ps forKey:@"allInternalOrAndOrRecipientIs"];
    [ps release];

    return map;
}

What is the purpose of this function and what should be it's correct body?

Hi @IuliuMoga
I've upgrade mwsc and pico to support ARC and be based on the latest AFNetworking version. Have a look here.

Thanks for your support!
I will try the new mwsc.


libvirt_restart_systemd of a nova.compute conflicts with the same section in libvirt.server.service

Basically nova.compute libvirt_restart_systemd is a duplicate of a same section in libvirt.server.service. It should be removed with dependency on libvirt.server.service or the worst case/workaround - renamed to libvirt_restart_systemd_nova.
Implications: saltstack-nova formula couldn't be used together with libvirt formula

This was already fixed by renaming the states accross the whole salt-formulas namespace.
Thanks for reporting this.


Inconsistent signed/unsigned integer type in SubMesh MaterialIndex

As noted in https://github.com/ignitionrobotics/sdformat/pull/831/files#r816364549, the SubMesh::MaterialIndex() accessor method and corresponding setter method both use unsigned int for the material index, but the value is stored internally as an int in Material.cc and explicitly uses a value of -1 to represent an unsigned value.
We should consider using std::optional<unsigned int> for this API in ign-common5.

We should consider using std::optional for this API in ign-common5.

That would be an elegant solution. A less elegant one, but that doesn't require a deprecation cycle and maintains API, would be to return something like std::numeric_limits<unsigned int>::max() for an invalid material.

I have a PR in progress that takes the std::numeric_limits<unsigned int>::max() approach for ign-common5. Should I continue down that path, or should I update the PR to use std::optional? I think that std::optional is the better option in this scenario and would prefer that approach, even if it requires tick tock.

I'm ok with optional :+1: tick-tocking return values can be tricky though, we may need to change the getter's name

I opened a PR that uses std::optional in a new method and deprecates the current MaterialIndex method: #319

Closed by #319


added functions

#3
Sphurthi yandamuri
PES2UG21CS241
I added  functions add two numbers , subtract, divide, power and fixed the volume of sphere

you've added function but it doesn't show up on the tkinter gui


[Datepicker] Interaction leads to page scroll

Clicking on the year scroll the page up. Probably an anchor issue.

Open https://baseui.design/components/datepicker/
Scroll the page a bit
Click on the year in the Datepicker

Current Behavior
Page scrolls up.
Expected Behavior
Scroll should not be affected.
Your Environment
BaseUI on https://baseui.design/components/datepicker/.

fixed


PGliteInterface should implement Disposable [Symbol.dispose]

TypeScript as of v5.2 added support for the Stage 3 ECMAScript Explicit Resource Management feature:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html#using-declarations-and-explicit-resource-management
So instead of having to write:
const conn = new PGliteWorker(this._connString)

try {
    const result = await conn.query(...)
    // ...
    return parse(result)
} finally {
    // ...
    conn.close()
}

We can write:
using conn = new PGliteWorker(this._connString)

const result = await conn.query(...)
// ...
return parse(result)

I think it will be a nice usability win if PGliteInterface implements the  Disposable interface

Hey, yep this would be a great use for these new features.
I would happily except a PR implementing it 👍

Hey @samwillis, I'm interest on trying to solve this issue, however I have no idea on where to start, could you possibly give me some pointers? :)


exclude aopalliance to avoid duplicate classes with spring-aop

Coverage remained the same at 92.278% when pulling b0fa02f7e02dc64f236e7e19be3e0d7e204f8237 on StephanPraetsch:fix_duplicate_classes into b40a2c580d2e582a95ca3b60d7b1a0e8051a5cb8 on Mercateo:master.


JSON should be in UTF-8...

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Windows 10
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.24
node: 7.3.0
os: win32 x64
@angular/common: 2.4.3
@angular/compiler: 2.4.3
@angular/compiler-cli: 2.4.3
@angular/core: 2.4.3
@angular/forms: 2.4.3
@angular/http: 2.4.3
@angular/platform-browser: 2.4.3
@angular/platform-browser-dynamic: 2.4.3
@angular/platform-server: 2.4.3
@angular/router: 3.4.3
@angular/upgrade: 2.4.3
@ngtools/webpack: 1.2.1
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

No. Custom code.
The log given by the failure.

Normally this include a stack trace and some more information.

throw new Error("An error happened while parsing " + this._tsConfigPath + " JSON: " + err + ".");
Error: An error happened while parsing ./tsconfig.json JSON: SyntaxError: Unexpected token  in JSON at position 0.
Mention any other details that might be useful.
Seems it requires UTF-8 format:
https://github.com/angular/angular-cli/blob/224250c113543f9828bd5fe27169cc92f7ed74e6/packages/%40ngtools/webpack/src/plugin.ts#L99-L104
Might be mentioning at least in a readme that UTF-8 format is required would a good point if it isn't - just close this issue. Thanks.

Thanks! We'll be in touch soon.

Thank you so much for leaving this here! I was banging my head on the wall wondering why I was getting the above error, checking the format for a while, then checked the encoding. My json file was UTF-8-BOM encoded which was causing this to fail. No reason it needed to be UTF-8-BOM so I changed it to UTF-8 and was able to get past my issue.
Why does the tsconfig have to be UTF-8 encoded though? Other tools were fine with it the way it was which made this a really frustrating issue for me to track down.