Correct CheckBoxFor to ignore ViewData

#1483
update tests to match
also demonstrate problem (then fix) in MVC sample

nits:

cover a couple more CheckBoxFor test cases
capitalize "CheckBox" consistently

/cc @pranavkm (and thanks for the thorough unit tests!)

Need a functional test instead of the sample update

:ok: think there's something similar in the existing functional test views where I could add the to-be-ignored ViewData entry

on second thought: this isn't a mainline scenario; it's about junk in the ViewDataDictionary.  suggest it's sufficient to push only the second commit (no change to the sample or a functional test).

Closed via 12565daf88603501521bf0315617be443fa5f705


File Syntax

Anyone object to eliminating tabs and using two spaces per indent?

I've done this for all the source except setunits: it's Lixing's code and I still need to familiarize myself with it.


Bump Eks-d release to latest on main

Issue #, if available:
Bump Eks-d release to latest on main.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


minijinja: 2.3.0 -> 2.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/mitsuhiko/minijinja/releases.
meta.description for minijinja is: Command Line Utility to render MiniJinja/Jinja2 templates
meta.homepage for minijinja is: https://github.com/mitsuhiko/minijinja
meta.changelog for minijinja is: https://github.com/mitsuhiko/minijinja/blob/2.3.1/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.3.1 with grep in /nix/store/bcb7z17j6iwhi4sab9fs7d0x5gp2snvq-minijinja-2.3.1
found 2.3.1 in filename of file in /nix/store/bcb7z17j6iwhi4sab9fs7d0x5gp2snvq-minijinja-2.3.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

minijinja

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bcb7z17j6iwhi4sab9fs7d0x5gp2snvq-minijinja-2.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A minijinja https://github.com/r-ryantm/nixpkgs/archive/ac0d413f5b52af2a1f6f4fce4fd33249dd5a61cb.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ac0d413f5b52af2a1f6f4fce4fd33249dd5a61cb#minijinja

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bcb7z17j6iwhi4sab9fs7d0x5gp2snvq-minijinja-2.3.1
ls -la /nix/store/bcb7z17j6iwhi4sab9fs7d0x5gp2snvq-minijinja-2.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

minijinja

Maintainer pings
cc @psibi for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge


Evaluate nickrosh/Evol-Replit-v1

A replit/replit-code-v1-3b finetune on Evol-Instruct-Code-80k-v1 that achieves 31.1% on humaneval
https://huggingface.co/nickrosh/Evol-Replit-v1
https://github.com/nickrosh/evol-teacher

Done by #58

Hey, could you please try it again with params=topk1? I didn't do any repetition penalty in my testing.

@nickrosh indeed much better without repeat penalty, this takes you to the top of the JS rankings for this model 🎉

haha sweet, thanks


is the rl pretrained model correct?

I downloaded the pretrained rl model in https://drive.google.com/drive/folders/1HG_d-PydxBBiDSnqG_GXAuG78Iq3uGdr.
I found the backbone.conv1.0.weight is in [32, 1, 7, 7], is the pretrianed model only trained with depth ?
if using rgbd, the shape of weight need [32, 4, 7, 7].

thank you!


Update request: tailscale 1.46.1 → 1.48.1

Package name:
Latest released version:

Current version on the unstable channel:
Current version on the stable/release channel:

[x] Checked the nixpkgs pull requests

Notify maintainers

Note for maintainers: Please tag this issue in your PR.

You don't need to open an issue if you're going to make a PR right after.

You don't need to open an issue if you're going to make a PR right after.

Apologies, my bad. I was not aware :(. I am only 1 day & 1 PR old here.


Prepare release notes for v1.6.36

containerd 1.6.36
Welcome to the v1.6.36 release of containerd!
The thirty-sixth patch release for containerd 1.6 contains various fixes
and updates.
Highlights

Ensure the CRIAPIV1Alpha2 warning's lastOccurrence is accurate (#10582)

Build and Release Toolchain

Update to go1.22.7, go1.23.1 (#10680)

Container Runtime Interface (CRI)

Cumulative stats can't decrease (#10671)
Fix memory leak with kubectl exec >= 1.30.0 (#10574)

Runtime

Fix bug where init exits were being dropped (#10676)
Update runc binary to 1.1.14 (#10667)

Deprecations

Ensure the CRIAPIV1Alpha2 warning's lastOccurrence is accurate (#10582)

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.
Contributors

Samuel Karp
Davanum Srinivas
Akhil Mohan
Akihiro Suda
Laura Brehm
Sebastiaan van Stijn
Chris Henzie
Cory Snider
James Sturtevant
Maksym Pavlenko
Mike Brown
Phil Estes
Shengjing Zhu

Changes
31 commits

77eba0908 Prepare release notes for v1.6.36
integration: regression test for issue 10589 (#10683)

ab9fedde2 integration: regression test for issue 10589
d0989e952 fifosync: cross-process synchronization

Fix bug where init exits were being dropped (#10676)

c9617c321 runc-shim: handle pending execs as running
15ad6ac67 runc-shim: refuse to start execs after init exits
7e6a18c24 runc-shim: remove misleading comment

Update to go1.22.7, go1.23.1 (#10680)

951af274c update to go1.22.7, go1.23.1

Cumulative stats can't decrease (#10671)

c8e5b1eb6 Cumulative stats can't decrease

move builds to go1.22 and testing to go1.23 (#10595)

0bbc90aee use git clone to install gogo/protobuf
383b2dcd1 move builds to go1.22 and testing to go1.23

Update runc binary to 1.1.14 (#10667)

fd70da38b update runc binary to 1.1.14

Fix TestNewBinaryIOCleanup on Go 1.23 and Linux 5.4 (#10591)

4fd7d4eef Fix TestNewBinaryIOCleanup on Go 1.23 and Linux 5.4

Fix memory leak with kubectl exec >= 1.30.0 (#10574)

6f9efd3a9 hide wsstream under internal/ to prevent external use
4694b84e8 golangci-lint should only look for problems in new code
05c2b1413 Run go mod tidy
a7b0c015d Add copyright headers
78f079926 switch over references to the new package
64430d636 Fix up some constant references
a37b08102 Copy over wsstream from k8s v1.31.0-rc.1 release

Ensure the CRIAPIV1Alpha2 warning's lastOccurrence is accurate (#10582)

d727961d2 Update CRIAPIV1Alpha2 warning lastOccurrence every call

update to go1.21.13 / go1.22.6 (#10577)

be0f0db07 update to go1.21.13 / go1.22.6

Dependency Changes
This release has no dependency changes
Previous release can be found at v1.6.35

Generated by:
$ ~/go/bin/release-tool -g -r -d -n --cache ~/.cache/release-tool -t v1.6.36 ./releases/v1.6.36.toml

@akhilerm done


Remove BigInteger from Codebase

For packet processing, we should use long and treat it as an unsigned long.
However, for other objects (e.g.,AccountBalance and BalanceTracker.getBalance) that are not in the Prepare/Fulfill flow, we should use BigInteger in order to support large negative balances that might overflow the capacity of an unsigned long.

In general, an account balance will comprise of two long numbers: one for the clearing-balance, and one for the prepaid balance. These two, when added together, will indicate the account balance.
In order to support all of the possible numbers, the "Balance" needs to be a BigInteger. However, for performance reasons, we can limit each of these to an unsigned long.

The biggest task that needs to be done is https://github.com/hyperledger/quilt/issues/201, which will update the PreparePacket contract to use a long instead of a BigInteger.

This is no longer an issue since Quilt is now using UnsignedLong, which is approx comparable to long in terms of packet marshalling/unmarshalling.


testing for acceptance

@agf2017 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@agf2017 Thank you for signing the Contributor License Agreement!


Develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-105 of 262 (59.92%)  changed or added relevant lines in 16 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 61.726%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

compass/exceptions.py
2
3
66.67%

compass/management/commands/initialize_db.py
0
2
0.0%

compass/clients/person_client.py
0
12
0.0%

compass/views/api/special_program.py
72
97
74.23%

compass/management/commands/load_legacy_eop_date.py
0
65
0.0%

Files with Coverage Reduction
New Missed Lines
%

compass/clients/person_client.py
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1853

Relevant Lines:
3002

💛  - Coveralls


Add negative binom to pygam

IMPORTANT: Please search among the Pull request before creating one.
Title

Implements negative binomial for pygam.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] New feature (non-breaking change which adds functionality)

Description

See above.
How has this been tested?

It hasn't. Will be in the mega test PR before official release (promise).
Closes

closes #302

Does this slow down the fit significantly? Something tells me that for Gaussian noise, this is much faster to fit than for NB.

@Marius1311 when you find the time, could you please check the math? I've been using this as an resource https://courses.ms.ut.ee/MTMS.01.011/2018_spring/uploads/Main/GLM_slides_9_NB.pdf + https://support.sas.com/documentation/cdl/en/statug/63033/HTML/default/statug_genmod_sect030.htm + https://en.wikipedia.org/wiki/Negative_binomial_distribution, but I may have become more confused.
I will check out the performance later.

Hi Mike, we know by now that droplet based single cell data is not zero inflated, so no need to include zinb. Which parts of the maths would you like me to check? Can you be more specific? i.e. are you worried about the distribution, about the optimization, about the linear model, etc.  We can talk about this tomorrow in our call.

I'm worried about the distribution, since that's the only thing I've touched. I am including comments in the code. Let's talk about it tomorrow.

Can you check against scipy scipy.stats.nbinom? i.e. just sample repeatedly from both and see whether they converge.

This is by now fairly outdated, closing in favor of #377.


If the address is not specified, it should show an error

Right now it seems to default to ldpos75fbb06210575fd8f7f62e0b9267d4386273fc80 - It's important to let the user know if they entered the wrong address.

I'm referring to this https://github.com/Leasehold/ldpos-commander/blob/master/lib/actions/transaction.js#L5 - It's in a few places.

fixed in 15ff3b8ab56613f7f6ab11eaf7678a117e0a0b26


Bug: TypeError: Cannot read property 'lineNumber' of undefined

Hi,
When there is a missing end, the plugin works just fine and displays the error as expected.
But when a ruby file is saved withot any ruby syntax errors, below exception is raised.
P.S. Thanks for the plugin and the time spent developing it. :+1:
OS: Ubuntu
Gem is installed in a project via bundler, gemfile in development dep.
ERR Cannot read property 'lineNumber' of undefined: TypeError: Cannot read property 'lineNumber' of undefined
    at /home/user/.vscode/extensions/zombocom.dead-end-vscode-0.1.2/extension.js:37:23
    at ChildProcess.exithandler (child_process.js:303:7)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:443:11)
    at Socket.emit (events.js:315:20)
    at Pipe.<anonymous> (net.js:674:12)

Hi. Thanks for the report. It's odd that this isn't catching the output https://github.com/zombocom/dead_end-vscode/blob/2f2560a073c93015e05d0baab0bf5e2853866e0f/extension.js#L15-L16
I need some more information to figure out why this is failing. Can you modify the file on disk at /home/user/.vscode/extensions/zombocom.dead-end-vscode-0.1.2/extension.js line 37 to add a console.log(stderr). Then let me know what that outputs? (You can change it back when you're done).
@mauro-oto I'm just now realizing that the dead_end gem doesn't return a non-zeo status when it's found a syntax error. I could perhaps add that functionality to the gem and then this extension can check for status rather than output? (I'm not sure if it's related to this issue or not though without more information).

Cannot reproduce anymore. Strange. Thanks for looking into this.


[Dark Mode] proposal details text isn't visible

Text contained in the proposal details page isn't visible

The view needs to be refreshed when the user switches to dark mode while the app is running.


Removing the Script Reference and adding the code

native on Article solving Issue #30743

@j0rt3g4 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This is not a valid change

@j0rt3g4 Thanks for filing the pull request, but could we just update the original script file? It is here: https://github.com/Azure/azure-docs-powershell-samples/blob/master/virtual-machine/create-managed-disk-from-snapshot/create-managed-disk-from-snapshot.ps1

Sure @cynthn

@cynthn @PRMerger20
https://github.com/Azure/azure-docs-powershell-samples/pull/236


build Support building an individual maven module.

Proposed changes
Current, if we build an individual FE maven module, e.g., build fe-core moudle via mvn clean package -pl fe-core, the below error would occur
[ERROR] Failed to execute goal on project fe-core: Could not resolve dependencies for project org.apache.doris:fe-core:jar:0.15-SNAPSHOT: Failed to collect dependencies at org.apache.doris:spark-dpp:jar:0.15-SNAPSHOT: Failed to read artifact descriptor for org.apache.doris:spark-dpp:jar:0.15-SNAPSHOT: Could not find artifact org.apache.doris:fe:pom:${revision}

It's because the maven module version is a property defined in the root pom.xml:
https://github.com/apache/incubator-doris/blob/246ac4e37aa4da6836b7850cb990f02d1c3725a3/fe/pom.xml#L121
This PR tried to fix this issue.

Use the version value in every pom.xml file instead of a property in the root pom.xml
If we want to change the project version, we could run the following commands in the fe dir:

mvn versions:set -DnewVersion=${new_version}
mvn versions:commit

Please see https://www.mojohaus.org/versions-maven-plugin/examples/set.html for more details.
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: no
Has unit tests been added: no
Has document been added or modified: no
Does it need to update dependencies: no
Are there any changes that cannot be rolled back: no

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

I think this is not a good way, the purpose of using reversion is to unify version management, has added maven flatten plugin, in the release will play flat version, as a dependency should also rely on maven on the determination of the version of the package

I think this is not a good way, the purpose of using reversion is to unify version management, has added maven flatten plugin, in the release will play flat version, as a dependency should also rely on maven on the determination of the version of the package

I think this is not a good way, the purpose of using reversion is to unify version management, has added maven flatten plugin, in the release will play flat version, as a dependency should also rely on maven on the determination of the version of the package
you can use mvn -Drevision=0.15-SNAPSHOT to compile child module
So here is my -1

Ah, I see, make sense to me, closing this PR.

you can use mvn -Drevision=0.15-SNAPSHOT to compile child module

It seems that using -Drevision does not work. So I reopen this PR. Looking forward to more thoughts about this.
cc @yangzhg @EmmyMiao87 @morrySnow @924060929 @morningman :)


Enabled chain and prediction logging

handler.ts

pass metadata to logger instead of directly writing it to message
TODO: review of metadate fields

index.ts

Changed log level for prediction chain logs to 'verbose' (same as in chain)
Added verbose prediction log message with: question, answer, chatId, chatflowId, ...

logger.ts

removed config.ts for now and use LOG_* env variables directly
write metadata to message where appropriate
_underscore metadata fields are only printed to JSON and if LOG_LEVEL=DEBUG
removed (unused) defaultMeta
Colorize Console logs
Removed timestamp from Console logs
Print metadata as pretty JSON to Console
Added server.log.jsonl
Added prediction.log and prediction.log.jsonl

TODO: we should also remove _underscore values from .jsonl logs

Hi @HenryHengZJ - your chain logging is awesome!
I integrated it better with the logger - so it just is still pretty printed in the console - but we can better control how metadata is printed in files or jsonl.
Todos: (needs review)

the metadata fields I pass in handler.ts need some review - i couldn't figure out which fields are really available
I introduced a convention, that _underscore metadata fields are not printed unless LOG_LEVEL=DEUBG -> but it's still printed to .jsonl => this can become VERY large

Next Steps:

the goal behind the efforts is (as mentioned) to provide a question / answer logging => after all the work (also from your side) I found out that all the info is in index.ts (btw. the file is becoming very large)
so I added a prediction.log and we are working on a UI for users in the backend - we would need to store the prediction log also in the DB - and then render it in the UI

Hope this PR makes it to main ! Thanks for your great work !

@matthias I think its good to have more details log, but these logs can grow very huge if we didnt have a job to clear/remove these logs.
From your changes, the logs have become harder to read:

as compared to previous:

Also wondering is there a need for jsonl file? It seems to just a duplicate of the .log files
In term of terminal/console logging, now we we have verbose logs on top of the original VERBOSE logs from langchain:

with much more details, but its too much info that I can't easily read whats happening
I find the original VERBOSE log is clear enough for me to see whats going on:


Support private registries in makeNodeJsModules

Some projects require downloading deps from private registries i.e. https://fontawesome.com/docs/web/setup/packages#alternate-per-project-setup-using-environment-variables
Would be useful to have a way to provide environment secrets so they can be used by npm

Context
Going deep on makeNodeJsModules, the current implementation tries to download each dependency as a nix derivation previously of npm install command (for caching, I guess).
It's using nixpkgs.fetchurl for downloading packages [1], but it resolves on 401 error for private registries due to fetchurl is not handling auth tokens on .npmrc such as npm install would do:

Suggested solution
collectDependencies function [2] must be modified to preload .npmrc auth tokens for handling the private registries. It sounds like a breaking change and, does anyone know if fetchurl would allow that?
There's a slightly related issue !1043 about the npm, node, and lockfileVersion problem. Any suggested solution can impact that issue.

@dsalaza4 @jpverde
According to NixOS wiki, there is a way to download private resources using fetchurl:

What do you think about this solution?
netrc-file can be created, but can we modify nix.conf file when makes start?

dream2nix ain't gonna cut it either. https://github.com/nix-community/dream2nix/blob/3802b906b4107e2d8bedc292d9c43779c4b4ec47/src/fetchers/npm/default.nix#L50
node2nix however seems closer to it https://github.com/svanderburg/node2nix/issues/172
nixpkgs.fetchUrl supports a curlOpts argument that can be used to pass the token, something like
__nixpkgs__.fetchurl {
  url<EMAIL_ADDRESS>  hash = "sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=";
  curlOptsList = [
    "--header" "Authorization: Bearer TOKEN_GOES_HERE"
  ];
}

Can confirm it works.


[Umbrella] Refactor application opertion methods.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I had searched in the issues and found no similar issues.

Describe the proposal
Because of very complex logic in ApplicationService . So I want to divide ApplicationService  into different service by deploy model for better isolation.
Task list

Application start method
Application cancel method
....

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Currently,I want to devide ApplicationService into different service by different functions, as below shows:

Anyone can supply better idea and welcome to discuss about this, just for better design.
Thank you!

Front end should update too.


feat: use runtime alias strategy

The existing shell init strategy lends itself to frequent state errors as VSCode sessions start and stop. It also carries the limitation of having to restart the shell after you start the VSCode session.
Executing the code_connect.py script before every call to code ensures that the proper socket is detected without fail. The latency drawback is nearly imperceivable, clocking in between 30-60 ms.
With this approach, we can do away with activate.sh and activate.fish... instead all we need is a simple alias like so
function code
  ~/.local/share/code-connect/code_connect.py $argv
end

Obviously, this would have broader implications for theREADME.md as well as https://github.com/chvolkmann/code-connect-fish-plugin. @chvolkmann let me know if this is something you're open to merging into your mainline.

Looks good so far! Had the plan to implement the validity check before every code call somewhere in the future, so I really appreciate the pull request!
Can you make sure to enable edit permissions to the PR once it's ready? Couldn't mark the previous PR as merged.

Hopefully the permissions issue is fixed now.

I've updated the usage instructions. Both bash and fish support using
alias code="/path/to/code_connect.py"

Thanks again for your contribution, I really appreciate it 🥳


Adds some checks on some XXX_New and XXX_Add functions

And of course also treat the callers.

@hardening:
I am fixing the channels right now, but using HRESULTS for return values, because that has much more significance. Could u please be so kind and split ur pull request so we dont have the channel fixes in right now ?

@hardening @MartinHaimberger I took the liberty and created a new pull request based on this but with the conflicting files omitted. Have a look to #2625.
@hardening If this is ok with you please close this pull request. Thank you.

migrated to https://github.com/bmiklautz/FreeRDP/tree/pull/2616


argo terminate marks task as Succeeded instead of Failed

Checklist

[ ] Double-checked my configuration.
[ ] Tested using the latest version.
[ ] Used the Emissary executor.

Summary
What happened/what you expected to happen?

When running argo terminate on a running workflow, it properly terminates the workflow, but marks the task as Succeeded. I would expect the workflow to be marked as Failed.

What version are you running?

argocli:v3.3.8

Diagnostics

Launch a workflow
While it is still running, call argo terminate on the workflow
The workflow will be marked as succeeded

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Could you check if your step is a retried step? Also what's the status of the previous step?

Hey @terrytangyuan - I'm not quite sure how to reproduce the issue. The pod was in a pending state when I saw the bug occur, but it seems to work as expected when the pods are in a running state.

I have the same problem, but I don't now how reproduce the issue.
My problem is, that when I Terminate a workflow sometimes the workflow pipeline is marked as success but see the pipeline in UI and I see that all next steps to pipeline since that I terminated workflow are omitted and marked as success.

In this picture it can see that problem. I terminated workflow in install_dependencies, however all next steps are marked success immediately

@DiegoFlop can you provide the version of Argo Workflows the operator is running and the version of Argo Workflow CLI you are using?


Rename input file parameters

Closes #324.
Tries to make the file inputs to the pipeline more descriptive and uniform, e.g. prefacing the parameter with the tool name it belongs to.

[x] Rename skip_short_variant_calling to skip_snv_calling
[x] Rename skip_assembly_wf to skip_genome_assembly
[x] Rename skip_mapping_wf to skip_alignment
[x] Rename skip_methylation_wf to skip_methylation_analysis
[x] Rename skip_phasing_wf to skip_phasing
[x] Rename variant_caller to snv_caller
[x] Rename parallel_snv to snv_calling_processes
[x] Rename cadd_prescored to cadd_prescored_indels
[x] Rename snp_db to echtvar_snv_databases
[x] Rename variant_catalog to stranger_repeat_catalog
[x] Rename bed to target_bed
[x] Rename hificnv_xy to hificnv_expected_xy_cn
[x] Rename hificnv_xx to hificnv_expected_xx_cn
[x] Rename hificnv_exclude to hificnv_excluded_regions
[x] Rename reduced_penetrance to genmod_reduced_penetrance
[x] Rename score_config_snv to genmod_score_config_snvs
[x] Rename score_config_sv to genmod_score_config_svs
[x] Rename parallel_alignments to alignement_processes
[x] Rename svdb_dbs to svdb_sv_databases

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core pipelines lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

One more thing: The workflow parameter for skipping short-variant calling is skip_short_variant_calling but in all other params they are referred to as SNVs, even if they also relate to indels e.g., skip_snv_annotation.

One more thing: The workflow parameter for skipping short-variant calling is skip_short_variant_calling but in all other params they are referred to as SNVs, even if they also relate to indels e.g., skip_snv_annotation.

Yeah. Here I wanted to rename skip_short_variant_calling to skip_snv_calling, to align with that they are called snvs in other parameters. I don't think it's ideal to call them snvs even though they contain indels as well.., but I don't know if it's more complicated to have "small variants", "snvs and indels", "snvs and small indels" in the parameters/file names? Any suggestion?

Great work! However, I found some spots where you missed renaming bed to target_bed and some other minor things and inconsistencies. I've got some more thoughts:

If I understood correctly, target_bed is only used for SNV calling. In that case, it should probably be called snv_calling_target_bed (or ..._regions, see one of the line comments)

Right now target_bed is used to limit SNV calling and methylation pileups, making the SNV-calling and methylation pileups quicker for targeted analysis. It's also passed to mosdepth to calculate depth per region. Ideally this bed would limit SV calling to the target regions, but now it's only filtering the results.
In Stockholm we will need to be able to output both variants from the whole genome, and filtered variants at the same time. I believe this would not be the usual use case for others, so perhaps we could have for example both a target_bed parameter and an snv_calling_target_bed. The snv_calling_target_bed is then by default set to target_bed, so a normal user get's expected results, but can also be overridden. Need to think about it some more.

Maybe it makes more sense to change skip_methylation_analysis to skip_methylaytion_pileup as that is all that subworkflow does. Or do we expect it to gain more functionality later on.

Yes, although it would be more correct currently, I hope we can at least add some visualisation track outputs to the workflow fairly soon. Even so, skip_methylation_analysis feels a bit broad maybe, because there's not much of an analysis going on.

Regarding your first point: I think calling everything "SNV" is preferable. Even if it isn't technically correct I think it's clear what it means and I like conciseness.
Ad 2: That sounds like a good alternative.
Ad 3: Maybe skip_methylation_summary?

Regarding your first point: I think calling everything "SNV" is preferable. Even if it isn't technically correct I think it's clear what it means and I like conciseness.

Let's go with snv then.

Ad 2: That sounds like a good alternative.

I made a separate issue for finer-grained control over regions (#503). Renaming --bed to --target_regions in this PR.

Ad 3: Maybe skip_methylation_summary?

Let's go with your suggestion of --skip_methylation_pileups, because that is what is does. If it changes, then we can change the parameter if needed.

Fixed!


Hold on release until postgis regression is resolved

There might be a regression in postgis support https://github.com/mojodna/tl/issues/3#issuecomment-73955887. Need to hold on 3.1.5 till this is ruled out.

I am not certain we need to hold on this @springmeyer it seems to be an issue in the XML file, not in mapnik?

solved in https://github.com/mapnik/mapnik/issues/2704. @BergWerkGIS - possible for you to regenerate a new Mapnik 3 SDK with this commit? https://github.com/mapnik/mapnik/commit/1ebd6afd9cba1629261b7d7e06473f242b64819b


Question about delete operation

Hi!
I move my project from activeandroid to requery and have some question.
For example, how can I do opeartion with blocking thread.
MyApplication.getInstance().getData().toBlocking().*?
Why this code not working?
MyApplication.getInstance().getData().toBlocking().delete(City.class).get();
List<City> wasCities=MyApplication.getInstance().getData().select(City.class).get().toList();
MyApplication.getInstance().getData().toBlocking().insert(cities);

wasCities contains items after deletion.

Hi. The issue here is delete().get() just creates the operation of type Scalar<Integer> that has to evaluated. You can evaluate it by calling value() or consume(Consumer<? super E> action). Something like:
Integer rowsDeleted = MyApplication.getInstance().getData().toBlocking().delete(City.class).get().value();
List<City> wasCities=MyApplication.getInstance().getData().select(City.class).get().toList(); // will be empty now

Will make this more clear in the examples and documentation. Sorry about any confusion. Thanks for reporting!

Thanks! Looks complicated)

The reason for that is that API is designed to be fully non-blocking/reactive. I agree its a little bit more complicated in blocking use cases, there will be some improvements there

I know, but using retrofit+rxAndroid I need blocking operation inside onNext. How can I do it simpler?
NetworkApi.getServerApi().getCities()
                .subscribeOn(Schedulers.io())
                .observeOn(AndroidSchedulers.mainThread())
                .subscribe(new Observer<List<City>>() {
                    @Override
                    public void onCompleted() {
                        sendBroadcast(new Intent(BroadcastHelper.ACTION_CITY_LOADED));
                        System.out.println("onCompleted");
                    }

                    @Override
                    public void onError(Throwable e)
                    {
                        ...
                    }

                    @Override
                    public void onNext(List<City> cities) {
                        System.out.printf("onNext %s\n", cities);
                        if(cities!=null)
                        {
                            MyApplication.getInstance().getData().toBlocking().delete(City.class).get().value();
                            MyApplication.getInstance().getData().toBlocking().insert(cities);
                        }
                    }
                });

I'm not sure that's what you want because then you are doing the database operations on the main thread then. You probably want to use the rx map() operator to apply functions to the observable which can do the database work before the final subscription.

Thank you! I did so and get more speed for UI.


occasional weirdness with not connecting over stdio USB when calling getchar and sscanf

see #575  and https://forums.raspberrypi.com/viewtopic.php?f=145&t=321326

Just having read that forum thread and #575 again, is it possible that some USB hosts are just "slow" to enumerate, and so the increased sleep-time in #575 gives these "slow" USB ports an increased chance of being able to enumerate the Pico in time? :shrug:  (that's just a random guess, I know very little about USB)
Any thoughts from @P33M ? (who I believe has intimate knowledge of the Linux USB drivers)

likely fixed by #918

closing due to #918 being merged into develop


comment about Microsoft.Data.SqlClient added

This may help new users see https://stackoverflow.com/questions/54472165/
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

closing and reopening for a fresh build.


WARNING: Failed to connect to ip-

When I run the following command
knife ssh "role:servers" "touch /home/ubuntu/file.txt"
(output)
WARNING: Failed to connect to ip-172-31-30-34.us-west-2.compute.internal -- SocketError: getaddrinfo: nodename nor servname provided, or not known
WARNING: Failed to connect to ip-172-31-43-208.us-west-2.compute.internal -- SocketError: getaddrinfo: nodename nor servname provided, or not known
WARNING: Failed to connect to ip-172-31-36-181.us-west-2.compute.internal -- SocketError: getaddrinfo: nodename nor servname provided, or not known
WARNING: Failed to connect to ip-172-31-1-220.us-west-2.compute.internal -- SocketError: getaddrinfo: nodename nor servname provided, or not known
I believe the IP addresses for each server is not correct. The IP addresses where auto-detected when I first ran the chef-client. How can I run chef-client and have it detect the correct public IP?
Note, these servers are running on AWS EC2, this shouldn't make a difference but could provide some direction. Thanks :)

You have opened an issue against the chef-client cookbook. It appears you are reporting a problem in chef-client itself. You should open an issue on https://github.com/chef/chef.


Collect more than 10 results + get meta description

Hello,
I can't manage to get more than 10 results for a keyword. Is there a way to set up this parameter ?
Also, is it possible to get the meta description for each URL. The one that Google display, not the one set up by the owner of the website.
Thank you!

Thanks for informing me, I'll see to it

About your first question, yes you can get more results by increasing the number of pages. if you're using the CLI script you can set pages with the -p= argument, and if you're using it as a lib you can set the pages= argument.
About the second thing, I'm not sure what you mean. File outputs contain most of what search engines display, including title and text, For example, a google search for "test" produces results like,
            {
                "host": "speedtest.net",
                "link": "https://www.speedtest.net/",
                "title": "Speedtest by Ookla - The Global Broadband Speed Test",
                "text": "Download the Speedtest app for more metrics, video testing, mobile coverage maps, and more. Get it on Google Play."
            },

Isn't that sufficient enough?


HSEARCH-3254 Handle .onMissingValue().use() properly for string fields in Lucene

https://hibernate.atlassian.net/browse/HSEARCH-3254

Pull Request Test Coverage Report for Build 1

34 of 43 (79.07%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 89.162%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/types/sort/missing/impl/LuceneReplaceMissingSortedDocValues.java
22
31
70.97%

Totals

Change from base Build 273:
-0.02%

Covered Lines:
18378

Relevant Lines:
20612

💛  - Coveralls

@yrodiere Hi. I'm adding more tests for the coverage.

done

@yrodiere thanks for the review. I think I've addressed the comments.

Merged, thanks!


Issue using Exclude for Style/BlockDelimiters

Expected behavior
I've added the following as I want to exclude Style/BlockDelimiters from running on one sub-directory. I expect it to not run on these files.
Style/BlockDelimiters:
  Exclude: app/services/item/queries/graph/*.rb

Actual behavior
Each time I run rubocop -c config/rubocop.yml, it exits instantly with the following Stacktrace. I've also tried naming the file directly but each time I run rubocop -c config/rubocop.yml, I get an instant error. I've removed this cop from my config (and kept the cop and it runs successfully, adding an exclude causes it to fail.
undefined method `map!' for "app/services/item/queries/graph/*.rb":String
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/config.rb:73:in `block in make_excludes_absolute'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/2.6.0/forwardable.rb:230:in `each_key'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/2.6.0/forwardable.rb:230:in `each_key'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/config.rb:69:in `make_excludes_absolute'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/config.rb:45:in `check'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/config.rb:37:in `create'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/config_loader.rb:53:in `load_file'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/config_store.rb:23:in `options_config='
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/cli.rb:88:in `act_on_options'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/lib/rubocop/cli.rb:38:in `run'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/exe/rubocop:13:in `block in <top (required)>'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/2.6.0/benchmark.rb:308:in `realtime'
/Users/markpreston/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/rubocop-0.88.0/exe/rubocop:12:in `<top (required)>'
/Users/markpreston/.rbenv/versions/2.6.6/bin/rubocop:23:in `load'
/Users/markpreston/.rbenv/versions/2.6.6/bin/rubocop:23:in `<main>'

Steps to reproduce the problem
Run rubocop -c config/rubocop.yml with the following:
Style/BlockDelimiters:
  Exclude: app/services/item/queries/graph/*.rb

RuboCop version
Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:
$ [bundle exec] rubocop -V
0.88.0 (using Parser <IP_ADDRESS>, rubocop-ast 0.3.0, running on ruby 2.6.6 x86_64-darwin19)

Failure on my behalf, bad formatting in my rubocop.yml, it was fixed with
Exclude:
  -  app/....


Restoring node feature concatenation in SAGEConv

I noticed that the concat functionality was removed from SAGEConv in this refactor here: https://github.com/rusty1s/pytorch_geometric/commit/16c6e0a18c6684b8faface5bc24344f0aafdcdea
Any plans to restore it? It's likely not a priority, but I can put up a PR when I have the time.

concat=True is now always enabled for SAGEConv. Do you need to use SAGEConv with concat=False?

I traced through the code manually, and it does look like the concatenation is there indeed. Sorry for the confusion and thanks for the cool library!


how to use Vietnamese language in template

hi everyone, i have trouble with the font, i have downloaded and built successfully but the text in Vietnamese is not correct
image
how can i fix this. Please help me, thank you

FIXED THANKS


Fix leftover connection to the "Open" signal in FileSystemDock

Fixes #28903. Regression caused by dcf27c71b75452ce5ca0bb849715ce4304ad694d.
I still have no clue what this signal is even used for, as it's not fired anywhere. @qarmin, does this fixes it in your side? Wait, no, I'm stupid, when I removed the signal I forgot to remove the actual connection to it, don't merge yet!
Okay, good to go.

Thanks!


eldritch for emacs

Is there any plan on providing emacs package for the theme?
Thanks in advance! :)

its not on my radar because i dont use it, but welcome to open a repo if youd like


[BEAM-646] Explicitly pass Pipeline in AppliedPTransform

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This changes the signature to only use expanded PInputs and POutputs.
This also requires passing the Pipeline object directly, as a root input
(PBegin) expands to no PValues, so the Pipeline cannot be reobtained
from the expansion.

R: @kennknowles

Yup, since an expanded PInput might not actually have anything in it, you can't use that to grab the pipeline.

(LGTM)

retest this please

Coverage increased (+0.01%) to 69.728% when pulling 3c6bea08f14cf42d0f16cf0094990e7a0ced7682 on tgroh:explicit_applied_transform_pipeline into 2eeeaa257c9336b2c48c3850c8508686a75be7b3 on apache:master.


Lowering aten.argmax.default to TTNN

Ticket
https://github.com/tenstorrent/pytorch2.0_ttnn/issues/571
https://github.com/tenstorrent/pytorch2.0_ttnn/issues/605
Problem description
aten.argmax.default not lowering to ttnn.argmax
What's changed

Add lowering aten.argmax.default to ttnn.argmax
Add test_argmax.py

Ok, I sent a new commit and this PR is ready.
But, I leave this issue https://github.com/tenstorrent/pytorch2.0_ttnn/issues/605 to tracking ttnn.argmax issue


TIME_GRAIN_ADDON not working in superset_config

I set up the following property in my superset_config.py:
TIME_GRAIN_ADDONS = {'P3M': 'quarter'}
But it doesn't display in the app.
The property TIME_GRAIN_BLACKLIST works fine though.
Environment

superset version: 0.36.0
python version: python 3.7.3

@mbh86 is there some reason you're not using P0.25Y that's already predefined and implemented for engines that support it?

@mbh86 is there some reason you're not using P0.25Y that's already predefined and implemented for engines that support it?

Thank you @villebro, I didn't know that. I will use it from now on.
Unfortunately, it didn't solve the issue.

What is the issue, apparently quarters are not showing up on the time grain dropdown? That should happen if the time grain in question isn't implemented for your database in db_engine_specs. What database are you on?

Exactly, the time grain is not showing up. The database is SQLite (examples database).

Unfortunately the quarter time grain hasn't been implemented for sqlite. If you are able to add it that would be a great idea for a PR!

Thank you for the info @villebro.


Remove unnecessary reference when iterating over page::Keyboard

All the enums in page.rs are Copy and repr(u8)/repr(u16) so it is more efficient to copy these by value than to use references. I didn't check if this pointer indirection actually gets optimized out by the compiler, but even if it is optimized out, this change simplifies implementation, by removing the additional lifetime. This way it is easier to implement iterator conversion, e.g. when converting keyberon::KeyCode to page::Keyboard. An example implementation of this conversion would be:
// This is just a PoC, the code could be cleaner and use some extension trait
pub struct KeyboardIter<I> {
    pub iter: I,
}

impl<I> Iterator for KeyboardIter<I>
    where I: Iterator<Item = KeyCode>
{
    type Item = usb_hid::page::Keyboard;

    fn next(&mut self) -> Option<Self::Item> {
        self.iter.next()
            .map(|kc| (kc as u8).into())
    }
}

// then use it like
let report = BootKeyboardReport::new(KeyboardIter { iter: layout.keycodes() })
// or to write report
keyboard_interface.write_report(KeyboardIter { iter: layout.keycodes() })

This would solve the problem mentioned in https://github.com/TeXitoi/keyberon/pull/99 (though I think the PR is still valid but for the reason described in the last sentence of my comment), and would allow @ithinuel to avoid creating large intermediate array.
I would also say, that it would be better to just require passing &BootKeyboardReport here instead of generic IntoIterator (same for NKROBootKeyboardInterface::write_report). This would be more consistent with other interfaces (e.g. ConsumerControlInterface) and it gives the user more control over the process of report creation/management, while it is still very easy to just write BootKeyboardReport::new(keys) directly if needed.

Yep, sensible optimisation.
Before merging the examples will need fixing up. As it's a breaking change I'll want to do a bit of house keeping before releasing on crates.

I would also say, that it would be better to just require passing &BootKeyboardReport here instead of generic IntoIterator (same for NKROBootKeyboardInterface::write_report). This would be more consistent with other interfaces (e.g. ConsumerControlInterface) and it gives the user more control over the process of report creation/management, while it is still very easy to just write BootKeyboardReport::new(keys) directly if needed.

With the managed interfaces I'm aiming to abstract the process of report creation/management away from the end user and present a unified interface for all type of USB keyboard. I agree that it may also be useful to provide a more low level interface for users that do want to interact at the level of the report. There's nothing in the library that would preclude this. I'll consider adding it.


modules: hal_nordic: dvfs: queue request when busy

Added one element queue to change frequency setting function, when previous dvfs sequence is still in
progress. Thanks to this EBUSY status will not be
longer reported and last frequency setting will be queued and applied as soon as pending change is done. This is needed by clock control.

Hi @hubertmis @anangl could You take a look? Maybe this is needed for next NCS?

I don't know nrfs details well enough to review this patch


Incorporate scopes into caching key for credentials

Ensure we only use cached credentials that match client ID, issuing authority and scopes. Otherwise, operations will fail with opaque error messages.
I encountered this doing test development of my own, but I'm guessing this is the underlying issue here: https://github.com/iTwin/itwinjs-core/discussions/3483#discussioncomment-2774943
We should do the same for Electron @evelynpreslar-bentley

Wouldn't it be simpler to keep the storage key as it is and just compare the requested scope to the cached scope, invalidating the cache if it doesn't provide the scope set being requested?
A single issuer + client-id pair shouldn't be associated with multiple sets of scopes at once, right?
I'd expect the requested scopes to differ only when an app is updated, not often enough to warrant caching multiple tokens at once.

Wouldn't it be simpler to keep the storage key as it is and just compare the requested scope to the cached scope, invalidating the cache if it doesn't provide the scope set being requested?

the cahced scope? where is that? youd have to introspect the current token right?

Wouldn't it be simpler to keep the storage key as it is and just compare the requested scope to the cached scope, invalidating the cache if it doesn't provide the scope set being requested?

the cahced scope? where is that? youd have to introspect the current token right?

I had the same question... the cached data doesn't include the scopes. I had thought about changing the stored blob to wrap the cached data and also put the scope in there, but thought this was simpler.

Wouldn't it be simpler to keep the storage key as it is and just compare the requested scope to the cached scope, invalidating the cache if it doesn't provide the scope set being requested?

the cahced scope? where is that? youd have to introspect the current token right?

I had the same question... the cached data doesn't include the scopes. I had thought about changing the stored blob to wrap the cached data and also put the scope in there, but thought this was simpler.

Our browser auth client caches the scope alongside the token, but we're not comparing it to anything because those tokens expire so fast.
I'm mainly concerned about the cache becoming filled with tokens stored under scope sets that aren't used anymore after a code change.

Wouldn't it be simpler to keep the storage key as it is and just compare the requested scope to the cached scope, invalidating the cache if it doesn't provide the scope set being requested?

the cahced scope? where is that? youd have to introspect the current token right?

I had the same question... the cached data doesn't include the scopes. I had thought about changing the stored blob to wrap the cached data and also put the scope in there, but thought this was simpler.

Our browser auth client caches the scope alongside the token, but we're not comparing it to anything because those tokens expire so fast.
I'm mainly concerned about the cache becoming filled with old tokens stored under scope sets that aren't used anymore after a code change.

Fair enough - I can make this change. I'll need to change the key slightly since I'm changing the stored data, but that's not a big deal.

Wouldn't it be simpler to keep the storage key as it is and just compare the requested scope to the cached scope, invalidating the cache if it doesn't provide the scope set being requested?

the cahced scope? where is that? youd have to introspect the current token right?

I had the same question... the cached data doesn't include the scopes. I had thought about changing the stored blob to wrap the cached data and also put the scope in there, but thought this was simpler.

Our browser auth client caches the scope alongside the token, but we're not comparing it to anything because those tokens expire so fast.
I'm mainly concerned about the cache becoming filled with old tokens stored under scope sets that aren't used anymore after a code change.

Fair enough - I can make this change. I'll need to change the key slightly since I'm changing the stored data, but that's not a big deal.
While I'm at it - thoughts on moving the issuerUrl into this blob and out of the key as well? Makes the entries easier to read in Credential Manager and I don't think it's a big lift to sign in again when switching environments...

For the browser auth client, it makes sense to include it to prevent random collisions across sites that happen to share a client ID.
For the cli and electron clients, it's probably less important, but I'd still advocate to keep it unless readability is preferable.
For tokens that can silently refresh for a long time I can see how re-signing in could get annoying.
For the key change, can't you just invalidate the cache if a mismatching or undefined scope is read?
That way all the old scopeless values don't get reused even though the key matches.

@evelynpreslar-bentley @calebmshafer Please review when you get a chance.


cpu.rb: drop field name and a colon from flags

Before this change:
$ brew ruby -e 'p Hardware::CPU.flags'
["flags", ":", "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce", "cx8", "apic", "sep", "mtrr", "pge", "mca", "cmov", "pat", "pse36", "clflush", "mmx", "fxsr", "sse", "sse2", "ht", "syscall", "nx", "mmxext", "fxsr_opt", "pdpe1gb", "rdtscp", "lm", "3dnowext", "3dnow", "constant_tsc", "rep_good", "nopl", "nonstop_tsc", "extd_apicid", "pni", "monitor", "cx16", "popcnt", "lahf_lm", "cmp_legacy", "svm", "extapic", "cr8_legacy", "abm", "sse4a", "misalignsse", "3dnowprefetch", "osvw", "ibs", "skinit", "wdt", "npt", "lbrv", "svm_lock", "nrip_save", "pausefilter"]
# ^^^^^^^^^^^^

After the change:
$ brew ruby -e 'p Hardware::CPU.flags'
["fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce", "cx8", "apic", "sep", "mtrr", "pge", "mca", "cmov", "pat", "pse36", "clflush", "mmx", "fxsr", "sse", "sse2", "ht", "syscall", "nx", "mmxext", "fxsr_opt", "pdpe1gb", "rdtscp", "lm", "3dnowext", "3dnow", "constant_tsc", "rep_good", "nopl", "nonstop_tsc", "extd_apicid", "pni", "monitor", "cx16", "popcnt", "lahf_lm", "cmp_legacy", "svm", "extapic", "cr8_legacy", "abm", "sse4a", "misalignsse", "3dnowprefetch", "osvw", "ibs", "skinit", "wdt", "npt", "lbrv", "svm_lock", "nrip_save", "pausefilter"]

Based on the output I saw for Arm processors (here), "Features" line has the same format and we can drop the first two elements of the array.
Alternative solution is to reject "flags", "Features" and ":" elements using
.reject { |f| ["flags", "Features", ":"].include? f }

CC @sjackman

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

Review period will end on 2020-11-30 at 18:32:57 UTC.

What do I do about the failing "review" check?

What do I do about the failing "review" check?

Review period will end on 2020-11-30 at 18:32:57 UTC.

https://github.com/Homebrew/brew/pull/9325#issuecomment-734947677
This policy is new.

I was under the impression that a review by a member should automatically disengage this requirement

I was under the impression that a review by a member should automatically disengage this requirement

I think PRs have to wait 24h anyway even with an approval.

Sounds good 👍

There's still a discussion ongoing on how exactly the review period should work: https://github.com/Homebrew/brew/issues/9224


Using in homestead virtual machine throws error.

I'll keep it short. I'm using Laravel homestead. At first, I was being dumb and I was trying to start the server outside of the vm. It would startup normally, my site just wouldn't be able to access it. When I finally started running it in the vm, I got this stack trace:
/home/vagrant/Projects/Blog/node_modules/laravel-echo-server/dist/echo-server.js:159
    emitPresenceEvents(socket, channel, members, member, action = null) {
                                                                                ^

SyntaxError: Unexpected token =
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/vagrant/Projects/Blog/node_modules/laravel-echo-server/dist/index.js:2:23)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)

Is this something I'm doing? Thanks.

Looks like a node issue with setting defaults in function parameters. Will be fixed in next release.

@Dastur1970
Yeah main cause of this is the fact that homestead comes with node 5 installed and that doesn't support parameter defaults.
Upgrading to node 6 will fix that, but might cause you other issues with gulp etc.
Probably best to hold off for a little while until @tlaverdure releases a newer version soon.


Review Google Analytics wrt managed access data

Need
We need to be sure that any information sent to third parties conform to our controlled-access data handling requirements.
The data browser sends user actions to Google Analytics in order to support understanding of user behavior on the site.  For example when searching for data the browser currently sends the facets selected and any search terms to Google Analytics.
If PII did make it into Google Analytics it could prove difficult to delete it.
Approach
One approach is to switch to a different analytics provider such as https://plausible.io/  for example that is open source and supports self-hosting and to host this within our security perimeter.
The Broad team uses Mixpanel on Terra so perhaps there is a self-hosting or privacy agreement in place there for us to investigate.
Another approach would be to review the requirements and privacy capabilities with Google Analytics and determine if there is a way to stay on the platform.

GCP is largely FedRAMP certified, so I wouldn't expect we would need to switch analytics platforms.
We should seek clarity on whether a search query with facets involves PII.
Are search results logged in Google Analytics?

Hi @theathorn no search results are logged at the moment, only the queries.

Completed.


HMAC, HKDF and ChaCha20

I think I was able to address most of your suggestions from the last PR. This includes a significant increase in the number of test cases for SHA-256, HMAC and HKDF as well. The biggest change from when you looked previously will be the HKDF Expand implementation. Feedback always welcome!

Looking at the extra tests for SHA256 - where is the source of these? The FIPS 180-4 document no longer seems to include test vectors. Is there an extra document or link that we could reference?

The new HKDF code was confusing me a bit, but I see why. In the rest of the code, array subtypes that end with a literal number are always constrained (e.g. "Bytes_32" is a constrained 32-byte subtype of Byte_Seq) and Unconstrained array types end in "Seq".  Your naming of "OKM_Index_256" and "OKM_256" doesn't follow that convention, so was confusing me. I think they should be "OKM_Index" and "OKM_Seq" respectively so it's more obvious that the OKM "out" parameter is unconstrained. I can see a few other potential implications as well. I will implement these, re-prove and test here this morning...

OK... proof and test results all looking good here with SPARK Community 2021. One comment above on the "Counter" parameter to AEAD Create procedure...

The extra SHA-256 test cases came from NIST at https://csrc.nist.gov/Projects/Cryptographic-Algorithm-Validation-Program/Secure-Hashing, using the byte-oriented test vectors.
With the OKM type naming I was hoping to leave room for SHA-512 implementations of HMAC and HKDF at some point, kind of like Digest_256 and Digest_512. TLS 1.3 doesn’t use them in it’s cipher suites but future specs might.
Ideally though, HMAC and HKDF would be able to use any underlying hash algorithm, so could be implemented as generics in the future.

OK... can you add a comment point at the source of those test cases?
I think we should leave OKM_Seq as an unconstrained type. We might have to increase its range in future, but then add specific constraints for each version via preconditions?
Agree - generics is the way to go for generalising over hash algorithms and so on.

OK... looks good - shall we go for a merge?

Phew, no pressure :) Using the updates I'm still able to do key exchange with the OpenSSL server, so I think we're in good shape.

I'm really impressed by the HKDF.Expand cleanup you did, BTW - it's much cleaner now.

OK... I will try for a "squash and merge" this morning. I will also then attempt a catchup merge from master onto my "new_mul" branch so it's up to date...


HDDS-5060. [SCM HA Security] Make InterSCM grpc channel secure.

What changes were proposed in this pull request?
Make InterSCM grpc channel secure.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5060
How was this patch tested?
Tested manually on docker ozone-secure-ha
Started Scm3 later, after some transactions are performed.
Config changes for testing:
OZONE-SITE.XML_ozone.scm.ha.ratis.log.purge.enabled=true
OZONE-SITE.XML_ozone.scm.ha.ratis.log.purge.gap=10
OZONE-SITE.XML_ozone.scm.ha.ratis.snapshot.threshold=5
scm3.org_1   | 2021-04-27 07:27:57,895 [grpc-default-executor-3] INFO server.GrpcServerProtocolService: 01c9e353-3886-4c6a-8c9b-f7278a473f30: Completed INSTALL_SNAPSHOT, lastRequest: 5249309c-73b8-4f8f-9b08-5cd73257f1df->01c9e353-3886-4c6a-8c9b-f7278a473f30#0-t2,notify:(t:2, i:43)
scm3.org_1   | 2021-04-27 07:27:57,929 [grpc-default-executor-0] INFO server.RaftServer$Division: 01c9e353-3886-4c6a-8c9b-f7278a473f30@group-EFC7205245FB: Failed appendEntries as snapshot ((t:2, i:43)) installation is in progress
scm3.org_1   | 2021-04-27 07:27:57,930 [grpc-default-executor-0] INFO server.RaftServer$Division: 01c9e353-3886-4c6a-8c9b-f7278a473f30@group-EFC7205245FB: inconsistency entries. Reply:5249309c-73b8-4f8f-9b08-5cd73257f1df<-01c9e353-3886-4c6a-8c9b-f7278a473f30#47:FAIL-t2,INCONSISTENCY,nextIndex=1,followerCommit=-1
scm3.org_1   | 2021-04-27 07:27:57,931 [grpc-default-executor-3] INFO server.RaftServer$Division: 01c9e353-3886-4c6a-8c9b-f7278a473f30@group-EFC7205245FB: receive installSnapshot: 5249309c-73b8-4f8f-9b08-5cd73257f1df->01c9e353-3886-4c6a-8c9b-f7278a473f30#0-t2,notify:(t:2, i:43)
scm3.org_1   | 2021-04-27 07:27:57,931 [grpc-default-executor-3] INFO server.RaftServer$Division: 01c9e353-3886-4c6a-8c9b-f7278a473f30@group-EFC7205245FB: Snapshot Installation by StateMachine is in progress.
scm3.org_1   | 2021-04-27 07:27:57,931 [pool-13-thread-1] INFO ha.SCMHAManagerImpl: Reloaded SCM state with Term: 2 and Index: 48

Thanks @bharatviswa504 for the fix and @xiaoyuyao / @vivekratnavel for the review. Committed this.


Downloadable dataset does not support .bz2 without tar

I tried to download labels.csv.bz2 and the downl. datasat failed to decompress the file as it wasn't .tar.bz2.

File that cannot be automatically decompressed and extracted yields a warning. Such file can be easily processed manually by overriding download function.


WARN Caps are averagely centred — v metrics check

capsHeight - hhea/typoAscender ~= - hhea/typoDescender (this is only recommended for fonts with Latin, Greek or Cyrillic as "main" script, I would go for allowing an error margin of 5% of UPM)
We also had the experience with Braah One: https://github.com/google/fonts/issues/6227
So also in case of non-caps fonts, we could have a similar rule.

This would be a great check, there is a twitter thread going over the rationale in detail here: https://twitter.com/romanshamin_en/status/1562801657691672576

I made a pull request for a new check covering this issue here: https://github.com/googlefonts/fontbakery/pull/4226

tl;dr: you might want to do more testing and investigation before implementing that check?
I just want to point out that there is a big assumption behind this, which I am very skeptical of: that all relevant environments people care about, do vertical centering of text using the same algorithm.
I am especially a bit suspicious of the implied claim that em-square as a distance from the origin is one of the metrics in question. I would also be curious as to WHICH descender metric is relevant, or whether that might vary as well.
In the case of Google’s own Flutter web framework, it appears to rely on sTypo metrics including sTypoAscender, and also possibly on… the baseline (?!). But I did not get enough feedback to be sure what was going on. See
https://github.com/google/material-design-icons/issues/1500

@tphinney Thanks for the feedback! I made a codepen here to try showing why this is a real issue: https://codepen.io/eliheuer/pen/KKrOamg
This kind of vertical centering works on the Web (Chrome) which I would argue is the most relevant environment. And to me it also just intuitively makes sense that you would want to center things this way.
This is only a WARN, so no one is forced to do this. But maybe this is a good best practice if you don't have any reason to do otherwise?
Here is Martian Mono, which is perfectly centered (Top: 42px, Bottom: 42px):

Here is Shantell Sans, which is NOT perfectly centered, but within the threshold to pass this test (Top: 46px, Bottom: 46px):

Here is Amiri, which is off by enough that it would get a WARN, note that this is visibly not centered (Top: 54px, Bottom: 62px):

Clarification: I was writing about Roman Shemin’s Twitter thread and his version of the vertical metrics check, which is significantly different than what Rosa proposed. Which one are you doing?

I implemented the check almost exactly as described by Rosalie, including the error margin of 5%.

    upm = ttFont["head"].unitsPerEm
    error_margin = upm * 0.05
    cap_height = ttFont["OS/2"].sCapHeight
    ascender = ttFont["hhea"].ascent
    descender = ttFont["hhea"].descent
    top_margin = ascender - cap_height
    difference = abs(top_margin - abs(descender))

    vertically_centered = difference <= error_margin

I don't like the use of sCapHeight since it's often set incorrectly. I don't mind this check being included but only as a warn. It's definitely something that should only apply to fonts intended for UI and only include scripts which have similar proportions (Amiri shows exactly why this doesn't work for most Arabic + Latin fonts).

I agree with @khaledhosny. To me this proposed check looks like trouble.

The in-person conversations at TypeCon 2023 convinced me it is a reasonable check.

Yeah, as long as it is Rosalie’s version and not Roman Shemin’s it is… not crazy. 😛

This issue is a great example of this problem: https://github.com/mui/material-ui/issues/29965


feat: Slit pool store module

Comment for commit Hide reserved shared asset without pool - there is a case, when user withdraws all liquidity from pool and pools automatically disappear but shared asset is already registered in chain and it will be alive and registered till somebody creates new pool for the same assets pair. UI cannot show correct name for such reserved asset without pool (it's name looks like 0x....) so we need hide it.


license: Replace old license reference

Replace old LicenseRef with the new one currently in use.
Ref: NCSIDB-717
Signed-off-by: Lukasz Duda<EMAIL_ADDRESS>

@Damian-Nordic @LuDuda can we merged that one? I would like to cherry-pick two configuration commits from the upstream, so I can update west-yml in sdk-nrf and include also this commit. Btw. commit title should be marked as [no up].


Add MGIT-Hyderabad to swot

@murthysrd I renamed lib/domains/ac/in/mgit.txt to lib/domains/in/ac/mgit.txt for you and merged pull request. Thank you.


Retrieve OTEAPI Core version and use as image version

Description:

Closes #71
Retrieve the OTEAPI Core version from requirements.txt and use that as a container image tag version. Keep using the "latest" tag version as well, pushing both.
Type of change:

[ ] Bug fix.
[X] New feature.
[ ] Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

[ ] Is the change limited to one issue?
[ ] Does this PR close the issue?
[ ] Is the code easy to read and understand?
[ ] Do all new feature have an accompanying new test?
[ ] Has the documentation been updated as necessary?

It looks like the version retrieval works as intended.

Everything works as intended. See the currently available versions for oteapi here to verify that the image indeed represents latest as well as the current oteapi-core dependency's version.

Codecov Report

Merging #107 (7f7e12c) into master (f910fad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   68.62%   68.62%
=======================================
  Files          18       18
  Lines         494      494
=======================================
  Hits          339      339
  Misses        155      155

Flag
Coverage Δ

pytest
68.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f910fad...7f7e12c. Read the comment docs.

Hmm, I think it would be nice to have some git tagging together with this as well, as it might otherwise be difficult to discern which commit each container image matches up with (except latest, which is always the HEAD of master).


Fix Capacitor iOS audio issue

This PR (delete as applicable)

Fixes a bug

Describe the changes below:
This fix addresses #5685, an issue with loading audio files when a Phaser project is wrapped in a Capacitor native app shell on iOS.
Capacitor on iOS often serves local files with a capacitor:// custom scheme, so just checking file:// leads to strange behaviour, extending the check to add capacitor:// resolves this issue.

👍

This pull request has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/audio-works-on-web-but-not-ios/3677/13


How to Build a Private repository

Is there a way we can build the private repositories on Tabris Cloud Build ?

I guess it is not possible..

Of course it's possible!  Taking a look at the https://tabrisjs.com/pricing page it notes that the free Developer account comes with unlimited cloud builds for 1 private repo.  If you upgrade to the Pro plan you'll get unlimited cloud builds for all private repos.
The private repo should be seen in your list of repos when you click "Create App".  Try hitting the refresh button at the bottom of the list if you don't see it.  If you still don't see it, read through #917

Yeah. I agree. I will go for Pro Plan soon..

Hi, guys! Any chances to get this fixed? I've tryed every suggested option and still see only public repoes

@sand123 Can you describe in more detail what you did and what you see?

If this is not related to the topic above please reopen a new issue.

I'm on developer plan and I cannot add private repo from Github in app.
I've revoked access in github account for tabris, granted again, deleted app and still - in repo list there're public repos only. Refresh list doesn't help

Hello it's still not currently possible to see a private repository in the cloud build when you have a free account on Tabris.

Same Problem here. Looks like this problem exists since four years.
Please fix this. Or take it away from freeplan. This was one of the points I choose this frameworks for testing.


Unhandled python OSError

Hi,
I'm using Artix and I would like to install it, but I have this error;
OSError: [Errno 8] Exec format error: '/usr/bin/glslangValidator'
ERROR: Unhandled python OSError. This is probably not a Meson bug, but an issue with your build environment.
WARNING: Running the setup command as meson [options] instead of meson setup [options] is ambiguous and deprecated.
PS: I've installed all dependancies
Regards

wrong repo...?

ooohps sorry didn't noticed ;(


Wallet Crash - Crashed but wallets stayed open

Error report received - was not doing anything with wallets (or related files) at the time but crash report popped up
Traceback
Traceback (most recent call last):
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/util.py", line 856, in run_with_except_hook
run_original(*args2, **kwargs2)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/network.py", line 1102, in run
self.wait_on_sockets()
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/network.py", line 1078, in wait_on_sockets
self.process_responses(interface)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/network.py", line 732, in process_responses
self.process_response(interface, response, callbacks)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/network.py", line 672, in process_response
self.on_get_header(interface, response)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/network.py", line 924, in on_get_header
chain = blockchain.check_header(header)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/blockchain.py", line 174, in check_header
if b.check_header(header):
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/blockchain.py", line 227, in check_header
return header_hash == self.get_hash(height)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/blockchain.py", line 453, in get_hash
return hash_header(self.read_header(height))
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/blockchain.py", line 431, in read_header
self.assert_headers_file_available(name)
File "/Users/cryptopoly/DGLD/cb-client-wallet/electrum/blockchain.py", line 361, in assert_headers_file_available
raise FileNotFoundError('Electrum headers_dir does not exist. Was it deleted while running?')
FileNotFoundError: Electrum headers_dir does not exist. Was it deleted while running?
Additional information
Electrum version: 3.2.2-286-g483d6b89-dirty
Python version: 3.7.3 (default, Mar 27 2019, 09:23:15) [Clang 10.0.1 (clang-1<IP_ADDRESS>)]
Operating system: Darwin-19.0.0-x86_64-i386-64bit
Wallet type: standard
Locale: en_GB

Looks like you deleted the headers dir


Update 03.01.06.PIPPA.md

Corrected a typo in the PIPPA text (whcih -> which)

Good catch, thanks!


Update supported-azure-ad-features.md

Updating supported features list for Azure AD B2C tenants to include not supported AAD P1\P2 features after a number of support cases

@kengaderdus
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@kengaderdus
Can you respond to the comment above?

emailed article author

sent email and Teams msg to author

Sent email to stakeholder, author, and contributor


Allow different forms of input

Project currently only allows input from Spout senders. Need to abstract our input to allow capture from at least webcams and screen recording.

Source interface created, webcam source added.


Implement async mode

Added in https://github.com/simonw/llm/releases/tag/0.18

PR:

#12

Merged in #13.


Query: adding constraints on drag and drop

Hello,
How can I enforce constraint on drag and drop area for a particular step type.
Say I want the particular task step (identified by step.type) to be added only at the end of switch node branches and nowhere else then how can such constraint be enforced?
Thanks!

I will add the constraint feature soon. Thanks for feedback.

Thanks!
While you are at it, kindly also include the step.type to class of the container div. This allows for styling the different step types (with same component types) differently using CSS.
Here is what I've done in the designer.js line #1352 (JS version from CDN) for this:
class: `sqd-task-group sqd-task-${step.type}`

in the method TaskStepComponentView::create()

Check this release.

This looks amazing!
Thanks,
Gaurav
On Fri, 9 Sep 2022, 9:19 pm Bart Tadych, @.***> wrote:

Check this release
https://github.com/b4rtaz/sequential-workflow-designer/releases/tag/v0.2.0
.
—
Reply to this email directly, view it on GitHub
https://github.com/b4rtaz/sequential-workflow-designer/issues/3#issuecomment-1242147098,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYT2FI67OW4MVHBGJB7PZPDV5NL7FANCNFSM6AAAAAAQGXIYBU
.
You are receiving this because you authored the thread.Message ID:
@.***>


388 swat mir page style

Fixed the bad page style for the SWAT Model Instance resource type [#388]

@mohamedmorsy - Please redo this pull-request for the develop branch, not master.

@mjstealey Sorry I forgot to change the master branch to the develop branch. could you tell me how to remove this pull request?

@mjstealey Sorry I forgot to change the master branch to the develop branch. could you tell me how to remove this pull request?

Closing this request due to wrong branch for merge


tab has been removed in makefile

Autoformat is really helpful to me, the only problem that I'm having is with makefile, currently autoformat removed all my tabs in makefile which doesn's look good.
How can I fix this?

I suppose you've found the
let g:autoformat_retab = 0

setting


CREST fleet endpoints

I finally got around to making some finishing touches to the docs I've been working on for a while and submitting a pull request.
I'm also using a new format for endpoint pages, which I would like to see applied to all other CREST endpoints. Best take a look at it :smile:

I'm all for putting endpoints under folder structures that are organized by functionality.
Looks good to me.

Can you supply at list one endpoint.md?
Also please list here in comments all of the available full path url/uri's dealing with fleet.

I hear some potential changes are ahead.
we should consider merging our good points and losing bad points, merging to one proposed template.
Should we do a side by side analysis or some such?

On first look, I like this proposed format. Have not yet compared properly with current, or with Chad's.
In the fleet_fleet page, it would be useful to explain where the link is obtained from and who can access the resources.

ccp has seen my temp .txt files so I will be deleting them.  It was mentioned that if a good list was available it would be an easy/quick fix after current priorities to fixup the EndpointCollections (soon to rename to RootEndpoint) to have a complete list.  I assume this could include fixups to the group/endpoint inconsistencies.
I bring this up here as I have not seen these fleet endpoints in any of my RootEndpoint/Options work and I wonder how many others there might be that the community might know about but are not in this documentation at this time (nor in the RootEndpoint like fleet).
I also mention this here as we should start a cleaner document to present to ccp on all known issues with RootEndpoint which could effect our choice of naming/doc-structure.

@CarbonAlabel will you please propose a single endpoint.md as your "template" and I will stick to and start modifying TournamentCollection.md as mine.  I'd like to start moving some stuff I see as good from yours to mine.  Perhaps this would help us merge towards a singular.

#221 for tournaments I have documented thusfar

https://github.com/timpanogos/eveonline-third-party-documentation/blob/master/docs/crest/misc/tournament/tournamentCollection.md my current stab, bringing @CarbonAlabel 's routing/navigation concept down ... I liked this a lot

Since opinions on the format proposed here seem to be mostly favourable, I'm going to open up an issue for deciding on a CREST endpoint documentation format, where we can discuss and further refine this format (or decide on another one), without the discussion being spread out over multiple PRs.

I do not see an issue .. I'd basically suggest just a couple things:

Title name ... make if the full access string name thus reflecting the full UID including version of the endpoint being documented.  i.e.

application/vnd.ccp.eve.Fleet*-v1+json

add the pseudo data structure in addition to the json sample.

In English sentences document the pseudo data structure and its use in navigation and/or other notes of interest about its use.  The sample should not need documentation.  I find bulleted lists that simply mirror the obvious from the data structure/samples as redundant.

In trying to gather all currently known endpoints in Tournament by looking at @OrthoLoess tournament PR, in combination to the static and realtime there are at least nine unique endpoints.
Now I'm back to the need of our documentation (and previous up thread concern) to closely follow the [group][endpoint] pattern where each group has a dedicated .md describing that group.  i.e. a tournamentGroup.md and a fleetGroup.md that then highlight documents that group and links all that groups endpoints.

@CarbonAlabel I do hope that my latest tournamentGroup.md suggestion highlights the importance of the titles of all endpoint.md's being the ccp given uid name/version.  I only have three hot links off of that group page, the other eight I lifted the navigation bullets from @OrthoLoess PR

you might run into issues with api versions for individual endpoints being much greater than others, if the offset in version numbers isn't an issue, that's fine with me, and resolving existing collisions is avoided as well.


Coral Dev Board runtime error during prediction

I'm working on a classification problem. I used Inception v3 model in Keras for classification. I did post training quantization and converted my hdf5 model to TFLite. Further, I compiled my TFLite model to use it on TPU instead of CPU on dev board. It's giving runtime error when I run this code during prediction on dev board
Describe the current behavior
Traceback (most recent call last):
  File "inference_try.py", line 25, in <module>
    interpreter.allocate_tensors()
  File "/home/mendel/.local/lib/python3.5/site-packages/tflite_runtime/interpreter.py", line 244, in allocate_tensors
    return self._interpreter.AllocateTensors()
  File "/home/mendel/.local/lib/python3.5/site-packages/tflite_runtime/interpreter_wrapper.py", line 114, in AllocateTensors
    return _interpreter_wrapper.InterpreterWrapper_AllocateTensors(self)
RuntimeError: Internal: :71 tf_lite_type != kTfLiteUInt8 (9 != 3)Node number 5 (EdgeTpuDelegateForCustomOp) failed to `prepare.`

Describe the expected behavior
Should predict the outcomes successfully and not give error on interpreter.allocate_tensors() statement.
Code to reproduce the issue
from tflite_runtime.interpreter import Interpreter
from tflite_runtime.interpreter import load_delegate

interpreter = Interpreter(
      model_path="/home/mendel/classification/inceptionV3Q_edgetpu.tflite",
      experimental_delegates=[load_delegate('libedgetpu.so.1.0')])

interpreter.allocate_tensors()

input_details = interpreter.get_input_details()
output_details = interpreter.get_output_details()

interpreter.set_tensor(input_details[0]['index'], img)
interpreter.invoke()
output_details1 = interpreter.get_output_details()[0]
answer= np.squeeze(interpreter.get_tensor(output_details1['index']))

See also #33558, and my comment there. https://github.com/tensorflow/tensorflow/issues/33558#issuecomment-545041049. Appears to crash when the model or input is large, despite the fact that the model easily fits into TPU on-chip memory.

The model you mentioned i.e., model.tflite, was that working fine or still giving error while executing? Looks like I'll need to reduce my model size to a huge extent so as to make it run successfully.
Edge TPU Compiler version 2.0.267685300

Model compiled successfully in 2804 ms.

Input model: inceptionV3Q.tflite
Input size: 21.30MiB
Output model: inceptionV3Q_edgetpu.tflite
Output size: 22.49MiB
On-chip memory available for caching model parameters: 4.75MiB
On-chip memory used for caching model parameters: 4.74MiB
Off-chip memory used for streaming uncached model parameters: 16.91MiB
Number of Edge TPU subgraphs: 1
Total number of operations: 165
Operation log: inceptionV3Q_edgetpu.log

Model successfully compiled but not all operations are supported by the Edge TPU. A percentage of the model will instead run on the CPU, which is slower. If possible, consider updating your model to use only operations supported by the Edge TPU. For details, visit g.co/coral/model-reqs.
Number of operations that will run on Edge TPU: 161
Number of operations that will run on CPU: 4
See the operation log file for individual operation details.

My model compiled and executed on the TPU without runtime error after I reduced model size (though I don't see why size reduction is/was needed, give the modest size even of my larger model). I did not retrain the smaller model, just used random weights as proof of concept.
Yes, @bhavitvyamalik, your model looks very large. I have no idea what the delays would be like when using "off-chip memory used for streaming uncached model parameters."

@bhavitvyamalik, Can you try the @mattroos's suggestion and let us know how it progresses. Thanks!

Since I was using InceptionV3 as my base model so even after reducing image size to 100x100 my model size was around 85MB which as @mattroos mentioned was too large. Eventually I had to change my base model to MobileNetV2 to bring model size under 3MB and then it worked like a charm!
@gadagashwini I'm still working on running InceptionV3 model on Edge TPU. Even though official documentation says inceptionV3 is supported still it doesn't work. Please look into if possible. Thanks!

I was able to run InceptionV3 model on EdgeTPU. The issue was not with size of the model but with the quantization process. Here is the code on how to quantize and convert the code to TFLite:
def representative_data_gen():
  for input_value in mnist_data[:100]:      //mnist_data list contains images
    data = np.array([input_value])
    yield [data]

opt = tf.lite.Optimize.DEFAULT
ops = tf.lite.OpsSet.TFLITE_BUILTINS_INT8
dtype = tf.uint8

converter = tf.lite.TFLiteConverter.from_keras_model_file(model_path)

converter.optimizations = [opt]
converter.representative_dataset = representative_data_gen
converter.target_spec.supported_ops = [ops]
converter.inference_input_type = dtype
converter.inference_output_type = dtype

tflite_quant_model = converter.convert()
open("model_quantised.tflite", "wb").write(tflite_quant_model)

Tensorflow version used was 1.15.0. If you use TF2.0 and use from_saved_model instead, it will give the same error.


Broken Download

I clicked the "download zip" option and cannot find a single dll file in there?
What files do I reference in my project and where do I get them?
Thank you

Hi hennyC,
For questions on Pcap.Net, please see the Pcap.Net Q&A Group.
"Download ZIP" button is a GitHub feature for downloading the latest code.
To download a release version, see the releases tab..
Boaz.


Fixed failed error in CoordinatedClient

Closes #1191.

This change is

PR is added to the queue for testing as 6. task. (ef15fa0)

Hi @andrew-aladev, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 87097594 build is completed (ef15fa0)
See https://github.com/ThaliTester/TestResults/tree/87097594ef15fa0_Fixed_failed_error_in_CoordinatedClient_andrew-aladev/ for the logs

Test 87097594ef15fa0(ef15fa0) has failed
See https://github.com/ThaliTester/TestResults/tree/87097594ef15fa0_Fixed_failed_error_in_CoordinatedClient_andrew-aladev/ for the fail logs


Integration Test - Release - 2020/10/20 23:14:33

Auto create for integration test. IssueCommandFlow

@PRMergerTest2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[Bug]: 404 error at URL: /txns/ShEv7_JAMt9EI8ZKQUL3t5K4yz677aAtL-u9IqGflxM

What happened?
Hi,
why are the HNT tokens gone? The Transaction failed!!
URL
https://explorer.helium.com/txns/ShEv7_JAMt9EI8ZKQUL3t5K4yz677aAtL-u9IqGflxM
What browsers are you seeing the problem on?
Chrome
Do you see the issue on Mobile or Desktop?
Desktop
Relevant log output
No response

I had this happen to two brand new miners this week.


Black Mesa - override textures

Black Mesa doesn't seem to respond to just placing the textures in the mod folder. This needs further testing, might require packing a VPK or changing the mod folder.

Works as per the guide here :
https://steamcommunity.com/sharedfiles/filedetails/?id=502670746


Menu Flickering

Menu flickers when script tick interval is changed from default value.

For anyone that finds this later: Don't change the time between the ticks, like never.
If you need to wait, save the time in a property and check it later.


Support muti user

Right now the application is single user only, a good way to improve is to have it support multiple users.

The first steps for this is done https://github.com/thewhitetulip/Tasks/commit/dacbef54e48d03db1dd23483fe85f0358fc5d652

https://github.com/thewhitetulip/Tasks/commit/6388fcf5a6242a3dee62a8095be5db67f66776e8
fixes this issue


Should fractionalDigits be called fractionalSecondDigits instead?

To be consistent with Intl.DateTimeFormat?

fractionalDigits has that name because "seconds" isn't the only unit that can have associated fractional digits. For example, if milliseconds is the largest unit displayed in the "numeric" style, then the fractional digits representing microseconds and nanoseconds will get appended to milliseconds, not to seconds.

Gotcha thanks!


chore: upgrade gradle action version

Upgraded the Gradle action version from v2 to v3
Replacing uses: gradle/gradle-build-action@v2 with uses: gradle/actions/setup-gradle@v3
The arguments parameter will be deprecated in Gradle action v3, we should use the run command instead of the arguments parameter

As of v3 this action has been superseded by gradle/actions/setup-gradle.
Any workflow that uses gradle/gradle-build-action@v3 will transparently delegate to gradle/actions/setup-gradle@v3.
Users are encouraged to update their workflows, replacing:
uses: gradle/gradle-build-action@v3

with
uses: gradle/actions/setup-gradle@v3

References:

https://github.com/gradle/gradle-build-action, https://github.com/gradle/actions/tree/main/setup-gradle
https://github.com/gradle/gradle-build-action/issues/996

Closes https://github.com/ocpddev/json-logging/pull/39

Please do not include the "closes" label as I don't want dependabot ignoring any version. I've edited it out for you but you kept adding it back.


CSS Modules Support

First and foremost I want to say, ssrx is impressive, thank you for the amazing work! It ticks a lot of boxes for me with its focus on solving one thing, that is building the client/server glue for ssr. I definitely will continue experimenting with ssrx.
During a quick try with the solid-router-simple I noticed that css modules don't seem to be supported. The style tags that are getting rendered in vite dev for css modules, have undefined as content.
I would've also tested this in the prod build, but the prod build seems to be broken at the moment ':), the build.server script deletes the client assets and it also does not even create a dist/server.js.

Thanks @katywings! I'll take a look this week.

Alrighty - https://github.com/marbemac/ssrx/releases/tag/%40ssrx%2Fvite%400.5.0 should fix the build issue, and also adds support for css modules. LMK how it works for you!

BTW I'm also working on updating things to support solid-router v0.10, which introduced a number of breaking changes. Will hopefully push that soon.

Good evening Marc
Wow, ty for the fixes <3! So far it works greatly on the old router, I will continue testing it :).
I actually also initially tried it with the newest solid-router version and a couple of router v0.10 compat changes in the example code, but that didn't work so easily - inconsistent suspense and css module styles (sometimes empty pages or missing styles), you probably already know what I am talking about ;).

Hi @katywings - I've just released some new versions, and updated the solid example. Please let me know if it works as you're expecting when you have a chance!

The new changes are superb, awesome work :)!

Inconsistencies with suspense and css modules seem to be indeed gone 💪
Even a quick lxsmnsyc/thaler integration worked like a charm so far
Not sure if this came with the new changes, but if you start the vite dev server and open localhost a bit too early in the browser, the server instantly crashes
Unrelated to this issue, but solid router just released a new version 0.11.0 that broke the server 🫠 (Error: Cannot find cache context)

Great!

Even a quick lxsmnsyc/thaler integration worked like a charm so far

Nice - curious, what are you after w thaler?

Not sure if this came with the new changes, but if you start the vite dev server and open localhost a bit too early in the browser, the server instantly crashes

Hmm, I'll see if anything can be done about this.

Unrelated to this issue, but solid router just released a new version 0.11.0 that broke the server

Yeahhh, seems like the new solid-router expects any code that leverages the new cache() to be run in an async context via import { provideRequestEvent } from "solid-js/web/storage"; - @ryansolid is this correct? Can't find any mentions of it in the docs though - is provideRequestEvent a private API or is it OK to use?
If ok to use I could incorporate that into the ssrx solid plugin easily.. the "simple" example becomes a little less simple, but not by much.

@marbemac The vite dev works greatly now, on all latest versions! The build on the other hand currently doesn't work, I think because the changes from 82510ab4d812f69413fe1500181d48a918a4558e only were released in the @ssrx/renderer but not the other packages such as @ssrx/solid.

Nice - curious, what are you after w thaler?

For me ssrx feels like a more minimalistic, less "biased / fully-featured" ssr formula compared to say vike or solid-start. This not only makes it as a great example and playground to learn how other meta frameworks join their pieces together, but also as a great foundation for projects which wanna trade away built-in features for more flexibility. thaler and [telefunc](https://telefunc.com/) both are meta framework independent solutions for the implementation of decoupled server functions, which perfectly fit into the ssrx thinking model regarding "choose your own stack" :).

The build on the other hand currently doesn't work, I think because the changes from https://github.com/marbemac/ssrx/commit/82510ab4d812f69413fe1500181d48a918a4558e only were released in the @ssrx/renderer but not the other packages such as @ssrx/solid.

That's exactly why - the examples worked locally because all the packages are locally linked 🤦♂. Should be fixed in the latest release!

For me ssrx feels like a more minimalistic, less "biased / fully-featured" ssr formula compared to say vike or solid-start. This not only makes it as a great example and playground to learn how other meta frameworks join their pieces together

That's exactly what I was after, I'm glad you're enjoying it! It's been a great learning experience for me as well.

thaler and telefunc both are meta framework independent solutions for the implementation of decoupled server functions

Yeah they're very cool, let me know how it works out for you! If the code is public, I'd love to see it.
What I've landed on for "decoupled server functions", that feels a bit less magical than thaler, is just tanstack query + trpc. Type-safe, trpc supports middleware and all the other goodies you'd expect, isomorphic on the client and server (on the server is just calls the trpc functions directly vs over http on the client). The caching/invalidation approach of tanstack query works nicely as well. Lastly, super easy to add a new function - just add it to the trpc router and it's immediately available on the query client for use. The react-router-kitchen-sink example shows all of this working together.

Yupp, trpc is indeed very nice :). In my case, the main reason for thaler/telefunc or other types of server functions is "plug-and-play". I am working on a oss cms that features visual building blocks, which can be very easily integrated by developers. My vision is that developers can share these building blocks with other developers without having to manually wire up server logic. The goal is that such blocks can even include basic server behaviour via server functions.