Testflight build number actions has issues with zero padded version numbers

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
Both the latest_testflight_build_number and app_store_build_number have issues fetching versions with a version number that is partly zero padded (For example 23.02.0). Fastlane returns an error saying it couldn't find a version on appstore connect even though it exists and there are builds available on Testflight for this version
Command executed
I created the following test lane to demonstrate the issue:
  lane :fetch_build do
    latestBuildNumber = latest_testflight_build_number(
      api_key: apiKey,
      app_identifier: "<APP IDENTIFIER>",
      version: "24.02.0"
    )
  end

Running it returns the following error:
Could not find a build for version 24.02.0 on ios platform on App Store Connect
Complete output when running fastlane, including the stack trace and command used
[14:13:12]: ------------------------------
[14:13:12]: --- Step: default_platform ---
[14:13:12]: ------------------------------
[14:13:12]: Driving the lane 'ios fetch_build' 🚀
[14:13:12]: -----------------------------
[14:13:12]: --- Step: setup_circle_ci ---
[14:13:12]: -----------------------------
[14:13:12]: Not running on CI, skipping CI setup
[14:13:12]: -------------------
[14:13:12]: --- Step: is_ci ---
[14:13:12]: -------------------
[14:13:12]: ---------------------------------------
[14:13:12]: --- Step: Switch to ios apiKey lane ---
[14:13:12]: ---------------------------------------
[14:13:12]: Cruising over to lane 'ios apiKey' 🚖
[14:13:12]: ---------------------------------------
[14:13:12]: --- Step: app_store_connect_api_key ---
[14:13:12]: ---------------------------------------
[14:13:12]: Cruising back to lane 'ios fetch_build' 🚘
[14:13:12]: --------------------------------------------
[14:13:12]: --- Step: latest_testflight_build_number ---
[14:13:12]: --------------------------------------------
[14:13:12]: Creating authorization token for App Store Connect API
[14:13:29]: Fetching the latest build number for version 24.02.0
[14:13:29]: Could not find a build for version 24.02.0 on ios platform on App Store Connect
[14:13:29]: Using initial build number of 1

Environment
🚫 fastlane environment 🚫
Stack

Key
Value

OS
14.2

Ruby
3.2.2

Bundler?
true

Git
git version 2.39.3 (Apple Git-145)

Installation Source
~/.rbenv/versions/3.2.2/bin/fastlane

Host
macOS 14.2 (23C64)

Ruby Lib Dir
~/.rbenv/versions/3.2.2/lib

OpenSSL Version
OpenSSL 3.1.4 24 Oct 2023

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-15.1.0.app/Contents/Developer/

Xcode Version
15.1

Swift Version
5.9.2

System Locale

Error

No Locale with UTF8 found 🚫

fastlane gems

Gem
Version
Update-Status

fastlane
2.219.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-aws_s3
2.1.0
✅ Up-To-Date

fastlane-plugin-versioning
0.5.1
🚫 Update available

fastlane-plugin-firebase_app_distribution
0.5.0
🚫 Update available

Loaded gems

Gem
Version

error_highlight
0.5.1

did_you_mean
1.6.3

syntax_suggest
1.0.2

bundler
2.3.21

pathname
0.2.1

rake
13.1.0

rexml
3.2.6

CFPropertyList
3.0.6

public_suffix
5.0.4

addressable
2.8.6

rubyzip
2.3.2

apktools
0.7.4

artifactory
3.0.15

atomos
0.1.3

aws-eventstream
1.3.0

aws-partitions
1.877.0

aws-sigv4
1.8.0

jmespath
1.6.2

aws-sdk-core
3.190.2

aws-sdk-kms
1.76.0

aws-sdk-s3
1.142.0

babosa
1.0.4

claide
1.1.0

colored
1.2

colored2
3.1.2

highline
2.0.3

commander
4.6.0

declarative
0.0.20

digest-crc
0.6.5

domain_name
0.6.20240107

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.109.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.3.0

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.3

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.3.0

gh_inspector
1.1.3

jwt
2.7.1

multi_json
1.15.0

os
1.1.4

signet
0.18.0

googleauth
1.8.1

httpclient
2.8.3

mini_mime
1.1.5

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

webrick
1.8.1

google-apis-core
0.11.2

google-apis-androidpublisher_v3
0.54.0

google-apis-playcustomapp_v1
0.13.0

google-cloud-env
1.6.0

google-apis-iamcredentials_v1
0.17.0

google-apis-storage_v1
0.31.0

google-cloud-errors
1.3.1

google-cloud-core
1.6.1

google-cloud-storage
1.47.0

json
2.7.1

mini_magick
4.12.0

naturally
2.2.1

optparse
0.4.0

plist
3.7.1

security
0.1.3

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.5.0

terminal-table
3.0.2

tty-screen
0.8.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.23.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

mime-types-data
3.2023.0218.1

mime-types
3.4.1

fastlane-plugin-aws_s3
2.1.0

fastlane-plugin-firebase_app_distribution
0.5.0

fastlane-plugin-versioning
0.5.1

java-properties
0.3.0

xcode-install
2.8.1

@LucaKaufmann The leading zeros are insignificant for App Store Connect or TestFlight. All components are treated as integer values only so even though it may appear (in App Store Connect) as 24.02.0, it is same as 24.2.0, you can verify it by fetching 'latest_testflight_build_number' for that version without using zero padding.

@arc-v2 you're correct! Running the action but providing version number 24.2.0 instead works:
[22:34:17]: --------------------------------------------
[22:34:17]: --- Step: latest_testflight_build_number ---
[22:34:17]: --------------------------------------------
[22:34:17]: Creating authorization token for App Store Connect API
[22:34:43]: Fetching the latest build number for version 24.2.0
[22:34:43]: Latest upload for version 24.02.0 on ios platform is build: 4

So is this an issue in the latest_testflight_build_number action then or somewhere else?

@LucaKaufmann I think this is an overall issue with TestFlight and App Store Connect API/Portal and how the version number is supposed to be composed of positive integers.

You could try the following
run bundle exec fastlane spaceship
in the console, after login in enter
filter = { app: 'com.your.app.id' }
filter["preReleaseVersion.version"] = '24.2.0'
filter["preReleaseVersion.platform"] = "ios"

Spaceship::ConnectAPI.get_builds(filter: filter, sort: "-uploadedDate", includes: "preReleaseVersion", limit: 1).first

Try again with  '24.02.0' for the version.
If only the first one works, we could consider patching the action to remove the extra '0'.
Feel free to propose a PR on fastlane/lib/fastlane/actions/app_store_build_number.rb
And if you are not good with ruby here's some code that could help
'24.02.0'.split(".").map{|c| c.to_i.to_s}.join(".")


multiple instruments

back testing (example strategies) with multiple instruments results in error:

\qtpylib\algo.py", line 881, in _update_window
df = tools.resample(df, resolution=resolution, tz=tz)
File "C:\Users\ahern\Miniconda3\lib\site-packages\qtpylib\tools.py", line 695, in resample
['idx']].min().max().values[-1]).replace('T', ' ')
IndexError: index -1 is out of bounds for axis 0 with size 0

I've got the same thing and I cannot fix it.


Build instructions missing

I am running an RPM based system and therefore cannot go with the Ubuntu distribution of Substance Composer.
Which steps are necessary to build the Substance Composer on Fedora 21, for example?

We're working on a new release of the composer. Instructions on native builds will follow when ready.


Allow parameter to generate Snapshot reports with columns and rows reversed

Feature Request
Motivation Behind Feature
The reason behind this is that during review, most displays are widescreen, and it really helps to have all of the first snapshot in all languages side by side to swipe left and right. Then it’s possible to move down to the next row for the second snapshot, etc. A big display is used for reviews also so it’s mounted in widescreen orientation.
The gain is this would allow more of the same snapshot on the display at once, organized together. This is standard for the review process to do one screen at at time in a group setting.
Feature Description
There is a reports_generator.rb that is run at the end of snapshot tests, and can also be called on its own. This by default will generate rows, one for each language, and columns, one for each snapshot.
The desire is to provide an argument or capability to reverse this. Each column would be each language, and, each row would be the same snapshot. Row 1 would be all the snapshot 1's, row 2 would be all the snapshot 2's, etc.
The default would of course still be left to the current report generation paradigm so as to not break existing usage.
Alternatives or Workarounds
None that I am aware of other than to hard code an HTML or write a separate script.

@joshdholtz I'd love to test this out wow! How would I switch my local version to this version? Is there a direction set somewhere I can follow?

@BJap Assuming you are using a Gemfile, you can change your Gemfile to...
gem 'fastlane', :git => 'https://github.com/fastlane/fastlane.git', :branch => 'joshdholtz-snapshot-rows-by-screenshot'

and then run bundle install
To verify its switched properly, you can run fastlane action snapshot and look at the available options for html_summary_format
Hopefully that does it for you 💪 🙃

@BJap Yessssss, gald it worked! I will make the code prettier now and also make it work for snapshot (incase you need this for Android as well)

@joshdholtz I am excited to see the progress on this. Did you need any more runs to test it out? I could show my Android team but I am unsure if we are using snapshot.


Update aws-java-sdk-dynamodb to 1.12.712 in scala-steward-dependencies

About this PR
📦 Updates com.amazonaws:aws-java-sdk-dynamodb from 1.12.710 to 1.12.712
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #200.


Add more javascript to app

Add more javascript to app as Github stil thinks the app is primarily HTML based.
(This quite annoys me - HIGH PRIORITY)
Will get done as I update the backend anyway...

Done, added enough JS now that Github has changed it to JS based project. Dunno why it does this.


Osei-b4:Asynchronous pr

[ ] I have pushed my progress to my fork of exercises repo

🥚 You understand the JavaScript Event Loop, and can demonstrate this by using setTimeout and setInterval to schedule simple tasks.

🥚 You can explain why Asynchronous Programming is important for programs that have blocking and non-blocking tasks.

🥚 You can explain the basics of the Client/Server model and HTTP requests and can fetch data from RESTful APIs.

🐣 You can break down an asynchronous problem into smaller tasks and solve it using promises. This includes identify which tasks depend on each other and which are independent:

dependent tasks: The return value from one task is required to start the next task, these must be completed in a specific order - .then
independent tasks: These tasks do not use each other's return values, they can be completed at the same time - Promise.allsystem.

🐣 You can fetch data from an API and render it into the DOM using /api-calls, /handlers and async/await syntax.

🐣 You can write unit tests for functions that return promises using async/await syntax.

@Osei-b4 don't forget the Milestone on the right.


[broadcastQueryClient] TypeError: PQueue is not a constructor

Describe the bug
Hi everyone!
I'm using "@tanstack/query-broadcast-client-experimental": "4.29.5" everything is working as expected but I do get an error: error - unhandledRejection: TypeError: PQueue is not a constructor     at _callee16$ (file:///[path-to-app]/node_modules/@tanstack/query-broadcast-client-experimental/node_modules/broadcast-channel/dist/esnode/methods/node.js:570:29)
Is there any known fix for this issue?
Many thanks in advance
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/ecstatic-dhawan-urkt30?file=%2Fpages%2F_app.tsx%3A1%2C1
Steps to reproduce
Go to the codesandbox and check the terminal, you should see something like: error unhandledRejection: Error [TypeError]: PQueue is not a constructor     at _callee16$ (file:///workspace/node_modules/broadcast-channel/dist/esnode/methods/node.js:570:29)
Expected behavior
No error.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

OS: MacOS
browser: chrome

Tanstack Query adapter
None
TanStack Query version
^4.12.0
TypeScript version
4.8.4
Additional context
No response

seems to be an issue specific to nextjs according to:

https://github.com/sindresorhus/p-queue/issues/103#issuecomment-1407762785

If you want to contribute this, we can make the type to use configurable to the plugin?
https://github.com/pubkey/broadcast-channel#methods


IAM Capability Required

The aws cloudformation deploy command does not indicate that it needs --capabilities CAPABILITY_IAM and as such, errors with the following message during execution:
An error occurred (InsufficientCapabilitiesException) when calling the ExecuteChangeSet operation: Requires capabilities : [CAPABILITY_IAM]

I understand that it may not be ideal to include this option by default, so that users are aware of the security repercussions, but I think it should be covered in the documentation, at minimum.
Overall, thanks for this example. It is exactly what I was looking for!

Thanks for mentioning that is is in the README. I would recommend calling it out more, because by default the aws cloudformation package command does not return that flag, as you seen in my below screenshot.

Since the README's sample command requires scrolling, it's very easy to miss, as you can see below:


poco can't find pcre.h

Package: poco:x64-windows
Vcpkg version: 0.0.71-ce477bf21998c80afc551de72c6140178de3a114
poco is unable to find pcre.h, build fails.
package-x64-windows-rel-out.txt

Duplicate of #475

@Shadowrom2020 Thanks for the ping. I'll continue the investigation on the other issue.
@KindDragon Thanks for marking this as duplicate, it really helps!


Web3-Onboard - add unpadLeadingZerosString [1/n]

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1739   👈

This comment was auto-generated by Graphite.


Update supported versions

update alpine
update fedora
Bazel 7 has not been released so extend Bazel 6

Thanks. Sent #21 to fix that.


Command line -p works but --plugin doesn't seem to

It seems for me the long version of the command line argument is not working for me. I'm simply passing the exact same path but with --plugin instead of -p.
Can anyone else repro this?
The code that parses the command line arguments looks like correct to me so I'm scratching my head here.
QCommandLineOption pluginOpt(QStringList() << "p"
                                           << "plugin",
                             tr("path to the plugin"),
                             tr("path"));

https://doc.qt.io/qt-6.2/qcommandlineoption.html#QCommandLineOption-3

I guess the longer version is being caught by Qt. It appears twice if run this command:
.\builds\vs-vcpkg\host\Release\clap-host.exe --help-all


Sorcery not working with simple form

When using sorcery with simple form I get undefined method 'model_name' for nil:NilClass

Hi @agustaf9
can you provide the form code? Maybe you're calling form_for current_user and current_user is nil?


Version 1.5.1 break recent article text

Hello
At recent articles Text Article Title does not wrap.

Hey, thanks for the heads up! It's fixed in version 1.5.2 ;)


Email Not Sent

hi man,
I have tried singup then got err 2/12/2018 2:28:54 PM2018/02/12 06:28:54 [signup.go:94][E] SignupController:Post - Got err inserting user to the database:  no LastInsertId available
and email not sent,
can you help me, please
regards
rino

@sciefylab not sure how much I can help you since you're getting the error from the ORM. Check https://github.com/astaxie/beego/issues/815 that might help you resolve the issue.

Hi TalLannder,
I have been modofied my controller line 94 and worked perfectly,
import (
...
"log"
)
...
_, err = o.Insert(&user)
if err != nil {
if err.Error() == "no LastInsertId available" {
log.Println(err)
} else {
log.Fatal(err)
beego.Error("SignupController:Post - Got err inserting user to the database: ", err)
flash.Error(signupform.Email + " already registered")
flash.Store(&this.Controller)
return
}
}
...
thanks you so much, Solved!!


Verify hostnames for SQL and WebApp before deploying resources.

Is your feature request related to a problem? Please describe.
Verify the SQL and Webapps hostnames are not used before deploying any resource.
Describe the solution you'd like
As soon as I press enter to execute the command error out if the hostnames for the sql and the webapp are already found to be used.  This will allow admins to quickly fix the issue without having to resort to clean half deployed SA.

Partly fixed on SQL but needed fixing on WebApp name


[collecting-info] collecting various imgpkg errors received

What steps did you take:
collecting various imgpkg errors that potentially have "weak" retries.
What happened:
[A small description of the result]
What did you expect:
[A description of what was expected]
Anything else you would like to add:
[Additional information that will assist in solving the issue.]
Environment:

imgpkg version (use imgpkg --version):
Docker registry used (e.g. Docker HUB):
OS (e.g. from /etc/os-release):

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

$ imgpkg copy -b registry.tanzu.vmware.com/tanzu-application-platform/tap-packages:${TAP_VERSION} --to-repo ${INSTALL_REGISTRY_HOSTNAME}/tap-repo/tap-packages

imgpkg: Error: Reading Images from Bundle:
  Retrieving images for bundle '...':


Enhancement: inject JS stack into errors originating from native code

Feature request
What are you trying to achieve?
The current error message thrown for unsupported/broken images (Error: Input buffer contains unsupported image format)  would be more helpful if it had the list of supported image formats in it. Also, Node.js shows no stacktrace for such errors.
When you searched for similar feature requests, what did you find that might be related?
Simply init sharp with some random data:
import sharp from 'sharp';

const buf = Buffer.from('12345');
try {
  const img = sharp(buf);
} catch (err) {
  console.log(err.message);  // Input buffer contains unsupported image format
  console.log(err.stack); // Error: Input buffer contains unsupported image format
}

What would you expect the API to look like?
The error message could look like: Input buffer contains an unsupported image format. Only the following image formats are supported: PNG, JPEG, WEBP, so users could easily fix the input data themselves without checking additional documentation.
As far as I can see the exception itself is thrown inside of native code. Not sure if something special needs to be done for it, so a proper stacktrace is shown (btw I run Node.js 16@macOS 13.3.1).
What alternatives have you considered?
See above
Please provide sample image(s) that help explain this feature
See above

This error is part of a class of errors that are thrown asynchronously from within C++ code where there is no access to the current JS stack.
To support a stack on errors (which would include everything up to and including the toBuffer or toFile call), we would probably have to wrap all native calls and, when there's an error from C++, generate a second "empty" error in JS and copy its Error().stack property to the first (or copy the message the other way).
As for which formats are supported, we should probably direct people towards inspecting sharp.format themselves.

This error is part of a class of errors that are thrown asynchronously from within C++ code where there is no access to the current JS stack.

should I then replace all calls of const img = sharp(buf) with const img = await sharp(buf)? Otherwise the whole node process will exit due to an unhandled async exception.

As for which formats are supported, we should probably direct people towards inspecting sharp.format themselves.

It does not really matter to which API we direct users in the error message. Main point there is something in this message, which helps to fix the actual error.

should I then replace all calls of const img = sharp(buf) with const img = await sharp(buf)? Otherwise the whole node process will exit due to an unhandled async exception.

The return value of toBuffer() and toFile() (when no callback is provided) is a Promise that can be awaited. As part of this you'll probably want to add some try/catch error handling, the same as any Promise-returning call.

The return value of toBuffer() and toFile() (when no callback is provided) is a Promise that can be awaited. As part of this you'll probably want to add some try/catch error handling, the same as any Promise-returning call.

my scenario is a bit different. I don't call toBuffer or toFile immediately on the instance. For example:
const sharp = require('sharp');

async function main() {
  let img = sharp(Buffer.from('12345'));
  if (1) {
    img = img.resize(100);
  }
  return await img.toBuffer();
}

(async () => await main())();

This code crashes node with unhandled exception:
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: Input buffer contains unsupported image format]

Changing  let img = sharp(Buffer.from('12345')) to  let img = await sharp(Buffer.from('12345')) has no effect, it still trows unhandled exception

Input is evaluated lazily when output is requested. The constructor returns a sharp instance (and not a Promise). The call to toBuffer() returns a Promise, which is rejecting in your sample code as there's nothing to handle it.

I'm still not quite sure the exception should be passed to node's triggerUncaughtException.
Just to compare:
const sharp = require('sharp');

async function test() {
  throw new Error();
}

async function main2() {
  return await test();
}

async function main1() {
  let img = sharp(Buffer.from('12345'));
  return await img.toBuffer();
}

(async () => await main2())();

main2 prints
/Users/elf/code/test/sharp/sharptest.js:4
  throw new Error();
        ^

Error
    at test (/Users/elf/code/test/sharp/sharptest.js:4:9)
    at main2 (/Users/elf/code/test/sharp/sharptest.js:8:16)
    at /Users/elf/code/test/sharp/sharptest.js:16:20
    at Object.<anonymous> (/Users/elf/code/test/sharp/sharptest.js:16:28)
    at Module._compile (node:internal/modules/cjs/loader:1191:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1245:10)
    at Module.load (node:internal/modules/cjs/loader:1069:32)
    at Function.Module._load (node:internal/modules/cjs/loader:904:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

while main1 prints
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: Input buffer contains unsupported image format]

event though toBuffer is awaited.

You'll need to add some kind of error handling to anything that returns a Promise as await only deals with the resolve path, not the reject path.
Anyway, we've gone way beyond the original suggestion, which was to include the stack property on any errors generated, and I still think that's a great idea so let's focus on that.

If an app has multiple Sharp calls, the error message should indicate the place where there was an exception.
Currently it contains totally helpless info about a crash.
I can wrap all the Sharp calls with such try{}catch:
try {
  someSharpCall();
} catch (e) {
   // or throw MyError(e)
   console.trace();
   throw e;
}

but I suppose Sharp itself should wrap a native text exception into JS exception with a stack trace.

To support a stack on errors (which would include everything up to and including the toBuffer or toFile call), we would probably have to wrap all native calls and, when there's an error from C++, generate a second "empty" error in JS and copy its Error().stack property to the first (or copy the message the other way).

I think this is probably a price worth paying.
If you are suggesting that this is too expensive at runtime, maybe it could be opt-out? I think most users will see an error as an exceptional case and want clear logging, even if it is slightly computationally expensive.
At present, if applications have multiple Sharp operations in a pipeline, and an error is thrown, then the maintainers cannot tell which of the operations failed, as all Sharp errors have no stack trace.

v0.33.0 is now available with a stack property on all Error instances either provided to callbacks or used as the rejection of a Promise.


increase-unit-tests-code-coverage-installable-item

Codecov Report

Merging #545 into master will increase coverage by 0.29%.

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   83.36%   83.66%   +0.29%
==========================================
  Files          25       25
  Lines        2368     2497     +129
  Branches      212      212
==========================================
+ Hits         1974     2089     +115
- Misses        394      408      +14

Impacted Files
Coverage Δ

browser/services/platform.js
87.9% <ø> (-1.58%)
:x:

browser/directives/breadcrumb.js
10% <ø> (-1.12%)
:x:

browser/services/request.js
20% <ø> (-0.84%)
:x:

browser/directives/pathValidator.js
82.97% <ø> (-0.36%)
:x:

browser/model/cdk.js
67.77% <ø> (-0.04%)
:x:

browser/pages/start/controller.js
44.79% <ø> (-0.04%)
:x:

browser/model/jdk-install.js
100% <ø> (ø)
:white_check_mark:

browser/model/helpers/installer.js
100% <ø> (ø)
:white_check_mark:

browser/pages/location/controller.js
100% <ø> (ø)
:white_check_mark:

browser/services/data.js
100% <ø> (ø)
:white_check_mark:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6434cbe...437766c. Read the comment docs.


Can I set animationTime per clickable zoom location?

Related to my other post, I'm looking for the best way to provide a smooth slow transition between locations in the viewer.  (I use the fitBounds method to target a rectangle location).  I've played around with animationTime and springStiffness.  Those options are set for all events on the page.
Is there a way to set per clickable event?
Question 2:
Is there a better way to provide a slow / smooth transition between points?
(as referred to in another post - 'the Ken Burns effect'?
<script type="text/javascript">
    var box1 = new OpenSeadragon.Rect(0.12, 0.05, 0.06, 0.02);
    var box1 = new OpenSeadragon.Rect(0.22, 0.18, 0.03, 0.01);

    var viewer = new OpenSeadragon.Viewer({
      id: "openseadragon-canvas",
      prefixUrl: "/openseadragon/images_TEST/",
      toolbar:       "toolbarDiv",
      tileSources: [
        "/zoom/Chattanooga1909/GeneratedImages/dzc_output.dzi",
      ],
        animationTime: "5.0",
        springStiffness: "5.0",
        showNavigator:  true,
        showHomeControl: true,
        showReferenceStrip:  false,
        autoHideControls: false
        });

        $('.loc1').click(function() {
        viewer.viewport.fitBounds(box1);
        });

        $('.loc2').click(function() {
        viewer.viewport.fitBounds(box1);
        });
  </script>

Unfortunately, we don't have a more nuanced mechanism for changing the animationTime and springStiffness, beyond reaching into the viewport's springs directly, like so:
$('.loc1').click(function() {
    viewer.viewport.zoomSpring.animationTime = 4.0;
    viewer.viewport.zoomSpring.springStiffness = 4.0;
    viewer.viewport.centerSpringX.animationTime = 4.0;
    viewer.viewport.centerSpringX.springStiffness = 4.0;
    viewer.viewport.centerSpringY.animationTime = 4.0;
    viewer.viewport.centerSpringY.springStiffness = 4.0;
    viewer.viewport.fitBounds(box1);
});

$('.loc2').click(function() {
    viewer.viewport.zoomSpring.animationTime = 6.0;
    viewer.viewport.zoomSpring.springStiffness = 6.0;
    viewer.viewport.centerSpringX.animationTime = 6.0;
    viewer.viewport.centerSpringX.springStiffness = 6.0;
    viewer.viewport.centerSpringY.animationTime = 6.0;
    viewer.viewport.centerSpringY.springStiffness = 6.0;
    viewer.viewport.fitBounds(box1);
});

BTW, you should passing them as numbers, not strings.
As for creating your own animations, we don't have any helpers for that, but you can set up your own animation code and move things directly via viewer.viewport.zoomTo(zoom, refPoint, true) with each frame. The true at the end bypasses the springs and moves it directly to that new location. You can also use viewer.viewport.panTo(center, true) in the same way. This is how I do the stately zooms on Chris Jordan's site, for instance:
http://chrisjordan.com/gallery/rtn/#silent-spring

Thanks for the set of options - I'll experiment with these.
And - yes, I caught the strings after posting.  Thanks.


Handle time intervals

As a developer, I'd like to be able to create my own UI/UX for time intervals, e.g skip credits
Acceptance Criteria

The player provides access to the time intervals

On Apple platforms TimeInterval is a type (a double, basically). Maybe we could cal this concept simply Interval if we want to have the same name on all platforms?


Considering separating osu! skins out of main repo

Maybe for the best.
Pros:

Non-osu! users won't have skins that they'll never use
Less code clutter on this repo, I guess
More focused on utilizing the osu! API for future osu! rainmeter skins (e.g. news preview, profile)

Cons:

Another repository to maintain

Or maybe it can be in the same repo.

Nevermind, might break https://github.com/meters-on-demand/cli.

Has been done: https://github.com/uhe-org/uhe/pull/9


Vis mods

Description

readded second graphic on buckets page
added async for auto-load and removed button on buckets page

Checklist:

[ ] Code follows the style guidelines
[ ] Code commented in relevant places
[ ] Changes to necessary documentation made
[ ] Has test cases for code.

Tests Performed:

[ ] Upload data to Datastore
[ ] Retreive data from Datastore
[ ] Map Visualization
[ ] Network Map Visualization
[ ] List other manual test cases performed


feat(TX-168): add Avalara phase 2 feature flag and new tax message

The type of this PR is: Feature

This PR resolves TX-168
Description
This PR removes the “VAT included in the price” on some artworks and preplaces it with "Taxes may apply at checkout. Learn more" in all artworks.
This update is hidden behind a new "Enable Avalara Phase 2" feature flag.
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[x] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

add Avalara phase 2 feature flag and new tax message on all artworks -rquartararo

iOS user-facing changes

Android user-facing changes

Dev changes

Before

After

This PR contains the following changes:

Cross-platform user-facing changes (add Avalara phase 2 feature flag and new tax message on all artworks -rquartararo)

  Generated by :no_entry_sign: dangerJS against 6ce79445cc33f9b26d7f6878d28e9a84ec73a0b6


can't set expiry for keys

I am on aioredis 1.2.0 and trying to set expiry for keys using the below syntax:
async def get_pool(self):
    if not self._pool:
        with (await self._lock):
            if not self._pool:
                self._pool = await aioredis.create_pool((self._host, self._port), minsize=self._minsize,
                                                        maxsize=self._maxsize)
    return await self._pool

async def set_key(self, key, value, namespace=None, expire=0):
    with (await self.get_pool()) as redis:
        if namespace is not None:
            key = self._get_key(namespace, key)
        await redis.execute('set', key, value, expiry=30)

This is the error which I get when I use expiry in execute for set:
TypeError: execute() got an unexpected keyword argument 'expiry'
however, I can do it by using expireat method like:
timestamp = int((datetime.datetime.now() + datetime.timedelta(0, expire)).timestamp())
await asyncio.ensure_future(redis.execute('expireat', key, timestamp))

Is there a way to set expiry in a single call with await redis.execute('set', key, value) or is this an issue?

facing the same issue

Facing the same issue

Hi, @ajay1mg
You are using RedisConnection.execute method (see the docs) which does not have expiry keyword argument.
Replace your command with the following:
await redis.execute('set', key, value, 'ex', 30)

(https://redis.io/commands/set)


Make fixed search component at collection detail

On collection when there is nothing on sale, it hops buy now here and there and missing pagination breaks the melody
Probably make it fixed so it can stay at one place?
EDIT, make Buy now disabled if there is nothing on sale and it's even easier fix as doesn't make sense to show user empty screen at all
Test at https://deploy-preview-1952--koda-nuxt.netlify.app/rmrk/collection/76df001719ad77e748-LZRO?search=&listed=false
(bug works until author making something on sale)
https://user-images.githubusercontent.com/5887929/150760135-12c0fec2-8ab5-42ce-b3f8-da5e57cc718c.mov

@yangwao I'll check this

@yangwao I'll check this

i've updated issue, best would be query collection if there is something on sale and if nothing, make buy now disabled


execution error

Hi, what can i do for this error please?
Steph.
[1306][2018.03.03 12:44:42]:[7204       ][PRINT   ]:[uploadr] --------- (V2.6.8) Start time: 2018.03.03 12:44:42 ---------
[1306][2018.03.03 12:44:42]:[7204       ][PRINT   ]:[uploadr] FILES_DIR: [/volume1/photo/test_dan]
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] Setting up database:[flickrdb]
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] Database version: [3]
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] Completed database setup
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] Checking if token is available... if not will authenticate
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] *****Removing empty Sets from DB*****
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] *****Completed removing empty Sets from DB*****
[1306][2018.03.03 12:44:43]:[7204       ][PRINT   ]:[uploadr] *****Adding Flickr Sets to DB*****
Traceback (most recent call last):
  File "uploadr.py", line 4544, in <module>
    flick.getFlickrSets()
  File "uploadr.py", line 3288, in getFlickrSets
    logging.info(xml.etree.ElementTree.tostring(
AttributeError: 'module' object has no attribute 'etree'

If you can edit file uploadr.py and find and follow these instructions:
import xml
CODING: For some systems this second import is required. To confirm.
Seems to avoid problem
logging.info(xml.etree.ElementTree.tostring(
AttributeError: 'module' object has no attribute 'etree'
import xml.etree.ElementTree
Let me know if it works. oPromessa

cool ;) it's works !


[18674] Include recently added XML supported tags in the documentation

To be discussed with @richiware when should this be included the documentation.
It is kept as draft.
Only 1 test failed locally regarding the difference between XML schema tag name for the Destination Order QoS (camelcase vs snakecase).
Fast DDS:
const char* DEST_ORDER = "destinationOrder";
XML schema:
<xs:element name="destination_order" type="destinationOrderQosPolicyType" minOccurs="0" maxOccurs="1"/>
All remain tests passes locally.

Closing this until we implement those features


Pipeline Caching - .net - Why packages.lock,json file is required?

This is about This is about https://docs.microsoft.com/en-us/azure/devops/pipelines/caching/index?view=azure-devops#netnuget
I don't believe that the information provided is enough to implement caching for .NET. for a Pipeline.
The documentation is:
If you use PackageReferences to manage NuGet dependencies directly within your project file and have a packages.lock.json file, you can enable caching by setting the NUGET_PACKAGES environment variable to a path under $(Pipeline.Workspace) and caching this directory.
Here are the first hurdle I'm dealing with:
Do you really need packages.lock.json for caching to work? If so, why?
I used the following key nuget | "$(Agent.OS)" | packages
My assumption is that the way it works is:

Check for cache and get data if data exists
(As a separate tasks) nuget restore:
a) if nothing has changed in the projects and there are no new packages out there then no changes
b) if projects changed or there are new packages restore updates the packages folder (this is the same as on my dev machine)
Build runs
The cache value is updated in the Post-job

This means there is no need for a lock file.
If this thinking is correct then having a dynamic key based on the hash of the lock file(s) would result in multiple caches when the lockfile changes and that would be wasteful since the old values will never be used. This makes me think I am not understanding this correctly.
In summary, I think the documentation could be extended to explain more how the caching works, what quotas there are, what to do in case of multiple lock files, what if there is no lockfile, etc.

@tymtam2 Thank you for the feedback, assigning this to the author for review.

Any news here?

This was passed off to @chasewilson and then @ramiMSFT, but was never addressed or acknowledged, and timed out with no resolution.  The documentation still provides no guidance for how to achieve pipeline caching of nuget dependencies when there's more than one package.lock.json in the universe (which I'd guess is about 90% of cases.  How often does one have a single .NET project in a CI pipeline? 😕)

Apologies for the delayed response. The content of the packages.lock.json will be hashed to produce a dynamic cache key. This will guarantee the uniqueness of the cache because every time a new dependency is added, your packages.lock.json will be different. See Configure the Cache task for details.
If you want to use multiple packages.lock.json, you can still use the following example without making any changes. The content of all the packages.lock.json files will be hashed and if one of the files are changed a new cache key will be generated.
variables:
  NUGET_PACKAGES: $(Pipeline.Workspace)/.nuget/packages

steps:
- task: Cache@2
  inputs:
    key: 'nuget | "$(Agent.OS)" | $(Build.SourcesDirectory)/**/packages.lock.json'
    restoreKeys: |
       nuget | "$(Agent.OS)"
       nuget
    path: $(NUGET_PACKAGES)
  displayName: Cache NuGet packages


Track organisation homepage as a finding page in Google Analytics

Add meta tag which marks the organisation homepage as being in the finding (navigation) stage of a user journey, as opposed to the thing (content) stage.
This will enable us to analyse how users navigate the site so that we can work out whether the new navigation pages are helping users find what they need.
Most pages use the shared meta tags in static to track this value, but organisation homepages are not in the content store so this meta tag must be added separately.
https://trello.com/c/SCsj2A9D/425-add-custom-dimension-to-page-view-tracking-on-new-navigation-pages

If it's not too much trouble, we could also add the page to the content store. Would be one less snowflake to worry about.

@tijmenb Sure! Does that mean adding it to this list like we did for the A/B example page? (In whitehall rather than frontend this time.) https://github.com/alphagov/whitehall/blob/master/lib/tasks/publishing_api.rake ❄

Yep. They're defined here: https://github.com/alphagov/whitehall/blob/master/lib/publish_static_pages.rb

@tijmenb I've raised #3101.
I think we need this change as well, though, because the the new content item will have the format placeholder, which won't be tagged with the finding document supertype. Or have I missed something?

Replaced by #3102 and #3101.


Fixed #9435 -- Redirected on empty path_info when APPEND_SLASH is set.

This fixes the bug #6978 was intended to fix. Tests are included. However, I am not certain that this will not cause problems when an HttpRequest object is created that is not a WSGIRequest, and when the common middleware is used. Will the line full_path = '' if request.path_info_is_empty else request.get_full_path() cause problems in that case, since request will be of a different class than WSGIRequest and therefore will not have path_info_is_empty? How would I add a test for this case?
https://code.djangoproject.com/ticket/9435

Perhaps looking at the CommonMiddleware tests in tests/middleware/tests.py would help. If you can rebase/squash your commits to remove the unrelated commits, that would be nice.

Still a little more testing to do before this is ready. I will update when that's done.

OK, I believe this is ready.

Hmm, it keeps failing the Windows check, and I'm at a loss for why (some git issue apparently).

OK, looks good now. Finally I think this is ready, but would be nice if someone more familiar with Django core than I took a glance at my changes.

Thanks, Tim. I will address these issues soon.

@frishberg would you mind revisit the remaining issues?

Closing due to inactivity.


Low USB Speed Error with PoE

Hi, using an Oak-D PoE, I can't get any of the examples to run. Getting this error:
RuntimeError: Spectacular AI SDK:  error: LOW USB SPEED!

############################################################################
Your USB connection speed 'UNKNOWN' is lower than required.
Please check that you have connected the device to an USB 3 port with an
undamaged USB 3 cable (blue interior). Speed SUPER or better is recommended.
############################################################################

I can get image and run other (non-Spectacular) scripts so the camera is definitely visible to the network.

We haven't (yet) tested with Oak-D PoE, but it should work. You can disable the USB speed check like this:
config = spectacularAI.depthai.Configuration()
config.ensureSufficientUsbSpeed = false
vio_pipeline = spectacularAI.depthai.Pipeline(pipeline, config)

I finally had a chance to test Oak-D PoE and by disabling the ensureSufficientUsbSpeed check as mentioned above I got it working without any other changes.
We'll fix this in the next version, so you'll just see the warning that the bandwidth may be limited, but it wont fail on it by default.


Tweaks to the documentation, build system and bending test

Hi @bsrunnels,
Me and @karthichockalingam, who I believe you have exchanged some emails with, have tried to compile Alamo and to run a simple cantilever problem.
While doing the former, we found some typos in the documentation and some quirks in the build system we had to work around since we aren't using MPICH. This PR includes a fix which should apply whether you are using MPICH or not.
Unfortunately, even though all tests passed, we still weren't able to run the cantilever problem. We've tried to fix the inputs file to the point where the problem seems to run and the solver seems to iterate but plotting the solution shows no deformation. Is this problem still a work in progress or should we be able to run it with a few extra tweaks?
Cheers,
-Nuno

@nmnobre Many of the tests in ./tests/ do not work and need to be removed as you noted. I am not sure whether the cantilever problem works (or has ever worked) but can take a look.

@nmnobre Many of the tests in ./tests/ do not work and need to be removed as you noted. I am not sure whether the cantilever problem works (or has ever worked) but can take a look.

I never meant to say they should be removed. I'd rather get them fixed. 🙂

I never meant to say they should be removed. I'd rather get them fixed. slightly_smiling_face

That would be great. Adding additional tests is a huge help. I assume you've already looked at the other inputs to see how to write headers that trigger the regression test system.
One thing to keep in mind, with the cantilever test specifically, is that the solver sometimes struggles with point loads applied at corners. For instance if you wish to apply a point load at the end of a beam, this will often produce divergent behavior. Instead it is recommended to apply a load on the face or to use a BC to apply a regularized (smoothed) load at the end.

Hi @bsrunnels,
I think this is now ready for another look.
As discussed, the configure tweaks now allow compilation with MPI libraries other than MPICH.
The GitHub workflows still only test with MPICH.
It'd be nice if you could have look at the cantilever beam input file, see if you catch any glaring mistakes.
Cheers :)


Feature request - after ES index Rails hooks

I'm thinking about creating PR to elasticsearch-rails that will introduce triggering of hook methods after indexation to ES was accepted
so similar way how you have in rails after_create and after_update you would have after_es_indexed, after_es_updated, after_es_deleted (or any other suggested names)
I'm planing to call the hook methods from https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-model/lib/elasticsearch/model/indexing.rb

InstanceMethods#index_document
InstanceMethods#update_document
InstanceMethods#delete_document

...if the hook methods are defined on a model (so something like model.try(:after_es_deleted) )
the reason is that I have a situation that I need to know if something is ES indexed without the need to trigger request to ES  => the after_es_updated hook updated an instance attr_accessor attribute I can just rely on the information in memory "it was indexed"
So before I spend time writing the PR can you give me some feedback if this is worthy to be introduced to the gem or not ? thx.

counterargument for this proposal is that all I need to do is

  def index_document
    super
    update_suggestability_flag
  end

  def update_document
    super
    update_suggestability_flag
  end

  def update_suggestability_flag
     if something
      @suggestable = true
     else
      @suggestable = false
     end
   end

but would be cool to have this hooks native in gem so I could do
def after_es_update
   update_suggestability_flag
end

def after_es_indexed
  update_suggestability_flag
end

Closing this as it's out of date.


Call failed: The repository does not exist in the registry

Hello, everyone !
My 'npx cdk bootstrap' command has successfully finished.
My 'npx cdk deploy' fails with the following error:
[16:16:50] Call failed: describeRepositories({"repositoryNames":["cdk-hnb659fds-container-assets-$AWS_ACCOUNT_ID-$AWS_REGION"]}) => The repository with name 'cdk-hnb659fds-container-assets-$AWS_ACCOUNT_ID-$AWS_REGION' does not exist in the registry with id '$AWS_ACCOUNT_ID' (code=RepositoryNotFoundException)
[16:16:50] genaiGenAIChatBotStack:  debug: No ECR repository named 'cdk-hnb659fds-container-assets-$AWS_ACCOUNT_ID-$AWS_REGION' in account $AWS_ACCOUNT_ID. Is this account bootstrapped?
After manually creating requested ECR repository with the commands:
export AWS_ECR_REPOSITORY_NAME=cdk-hnb659fds-container-assets-$AWS_ACCOUNT_ID-$AWS_REGION
aws ecr create-repository
--repository-name $AWS_ECR_REPOSITORY_NAME
and re-launching 'npx cdk deploy' the error is gone.
Could you pls. have a look at this and fix the issue ?
best regards
Alexey Shishkin

This was an issue with previous cdk versions. This should be solved with #357. Historic config in cdk.out can cause issues with the bootstrap. Check with a fresh environment and local to confirm.


Create python2.json

Python2 is still unfortunately, a dependency for a number of projects including some mainstream ones like node-gyp, etc. So, adding the manifest for it.
This will however, create conflicting python.exe executable, depending on which one is installed first. Not sure how to solve this. But I presume there is a clean way to do this, since jdk seems to do it. However, I'm creating a PR for this, since a working resolvable (since they are just the shims) conflict is better than nothing.

Python2 is already available in the versions bucket. https://github.com/scoopinstaller/versions/blob/master/python27.json
Run scoop bucket add versions to add the bucket.

Ah. Great. Thanks for the info.
PS: Consider adding that to the documentation? Would be helpful.

It's in wiki under buckets. Where would you suggest adding it? Main readme.md maybe?

I saw the extras bucket. But missed the versions one. My bad. But I guess
a little bit of highlight would be helpful. Wouldn't you think so? Perhaps,
a small section for all the included buckets, may be?
On Thu, Jun 8, 2017 at 10:30 PM, Richard Kuhnt<EMAIL_ADDRESS>wrote:

It's in wiki under buckets. Where would you suggest adding it? Main
readme.md maybe?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/lukesampson/scoop/pull/1548#issuecomment-307164818,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiJMYHMroHrO0aXuMLl16uRSbHXgEDVks5sCCiXgaJpZM4N0Vhv
.


Add CoronaTab.app dashboard site link

Hey guys 👋
You have done an absolutely amazing job with this project.
We have used it to build yet another dashboard : https://coronatab.app/dashboard
We also have a New Tab browser extension and a fully relational REST API
We also plan to localise the entire thing into all languages.
Again, can't praise your guys's work enough.
Cheers

Wow. This is beautifully presented. NICE WORK!

Wow. This is beautifully presented. NICE WORK!


Add rowPosition API in parquet record readers

Currently the parquet-mr RecordReader/ParquetFileReader exposes API’s to read parquet file in columnar fashion or record-by-record.
It will be great to extend them to also support rowPosition API which can tell the position of the current record in the parquet file.
The rowPosition can be used as a unique row identifier to mark a row. This can be useful to create an index (e.g. B+ tree) over a parquet file/parquet table (e.g.  Spark/Hive).
There are multiple projects in the parquet eco-system which can benefit from such a functionality:

Apache Iceberg needs this functionality. It has this implementation already as it relies on low level parquet APIs -  Link1, Link2
Apache Spark can use this functionality - SPARK-37980

Reporter: Prakhar Jain
Related issues:

Row positions are computed incorrectly when range or offset metadata filter is used (is related to)
Extend METADATA column to support row indices for file based data sources (is related to)
Release 1.12.3 (is depended upon by)

Note: This issue was originally created as PARQUET-2117. Please see the migration documentation for further details.

Xinli Shang / @shangxinli:
Thanks for opening this Jira! Look forward to the PR.

Prakhar Jain:
Resolving this issue as the PR is merged. @ggershinsky Could you reassign the Jira to me?

Prakhar Jain:
<EMAIL_ADDRESS>Yes I am working on this. Will share the PR soon.

Gidon Gershinsky / @ggershinsky:
<EMAIL_ADDRESS>Could you add [~prakharjain09] to the Parquet contributors.

Prakhar Jain:
<EMAIL_ADDRESS>@gszadovszky Could you please review the PR and provide your feedback. Thanks!


Add CardanoGens

Name: CardanoGens
Description: 1st Generative Art Collection living on the Awesome Cardano Chain
Link:   https://cardanogens.com/
Source: https://github.com/CardanoGens
Tags:
nft

Hi. We are waiting 2 reviewers right? or Is there any problem with our PR?

Closing due to not enough approvals for a long time. Please note that showcase projects need to provide a unique value from existing showcase items, feel free to join the discussion here: #243

Thank you for your response, we have checked the #243 and I do not get what is not unique value for our project.
Is it not an enough clone of an ETH project?
What is a problem that we are dealing here?
The idea is not cool?
We do not have famous paid shillers?
We provided you all the details you wanted.
We distribute the purchased token ASAP to our collectors.
None of our holders have any issues with our distribution.
We have done NO wash trading.
You can check each transaction, and check the collectors' wallets to see if we have made the purchases by ourselves or they have been bought by active members of the community.
Thank you.


Enable reusing most of MSIDAccountCacheItem in msalcpp

These changes allow msalcpp to almost entirely reuse MSIDAccountCacheItem by moving it's methods into a category that can be shared. The clientInfo property is handled very differently between the two codebases, so it was moved into it's own category, which allows msalcpp to provide a different implementation of it's getter & setter.

I see. Let's discuss other options how you can reuse that code.
But I strongly believe that isEqual, hash, and copying implementations belong to the class itself. It'll be just very unnatural for other devs coming in and not expecting isEqual being in the category.

I came up with a way to accomplish what we want from our side without requiring these changes. Closing.


When using the useQuery hook errors get cached.

Seems like our cache is pretty sticky in the hook, and will not clear out an error, once its resolved. We ran into an error with this when trying to get Firefox working and dealing with the external messaging script. Essentially we would poll and get errors because the script was not ready. Once the script was ready we got back data but the error persisted.

Seems like this is sorta an issue with queries as well. I have seen where the old data is shown after a loading state for a split second.


SwiftMailer handler's to_email cannot handle %env(json:FOOBAR)%

SwiftMailer handler's to_email config parameter is supposed to accept an array of email addresses. It works ok when the array is given literally, like:
# config.yml
handlers:
    email:
        type: 'swift_mailer'
        to_email:
            -<EMAIL_ADDRESS>            -<EMAIL_ADDRESS>
However, it crashes if the array comes from an environment variable:
# .env
<EMAIL_ADDRESS><EMAIL_ADDRESS>
# config.yml
handlers:
    email:
        type: 'swift_mailer'
        to_email: '%env(json:SUBSCRIBERS)%'

The error is:

Array to string conversion in /srv/www/acme/vendor/egulias/email-validator/EmailValidator/Validation/RFCValidation.php:30

I think the cause is that, this parameter being dynamic, its value gets replaced by a string placeholder, something like env_json_SUBSCRIBERS_d4fb785b4f5825b62c36d8476dab783b. This is the value the Config component sees when it parses the bundle's configuration. Since it's a string, it converts it to array('env_json_SUBSCRIBERS_d4fb785b4f5825b62c36d8476dab783b'). When the actual value is finally fetched, the param then equals<EMAIL_ADDRESS>"bar@a.com")) instead of the expected<EMAIL_ADDRESS>"bar@a.com").

Faced the same issue! Can be reproduced by https://github.com/vudaltsov/symfony-4-monolog-env-config

This issue is going to be fixed by this PR https://github.com/symfony/symfony/pull/23888.

Looks like it wasn't fixed by the mentioned PR.
In 4.1.0 I'm getting this:
[Symfony\Component\Config\Definition\Exception\InvalidTypeException]
  Invalid type for path "monolog.handlers.swift.to_email.0".
  Expected one of "bool", "int", "float", "string", but got "array".

Any updates on this?

After many tests, it seems the Environment Variable Processor returns the processed result into the parameter's first array item [0] instead of returning it as the parameter.
The error is quite clear : monolog.handlers.swift.to_email.0
The json processor returns the right value : an array of items. The issue is that it is set into monolog.handlers.swift.to_email.0 instead of monolog.handlers.swift.to_email.
Since the to_email arrayNode of the monolog Configuration.php only accept scalar values as items, it throws an error for having an array in [0].
I have found another error and it is that RFC 2822 accepts values like this string :
<email@email.com>,<email2<EMAIL_ADDRESS>but the clause in the monolog Configuration.php :+1:
->beforeNormalization()
                                    ->ifString()
                                    ->then(function ($v) { return $v; })

transforms this string into an array, which breaks Swift Mailer.
I'll dig more into how to fix this issue.

so is there any progress with this issue?

Any progress on this?

I also took a look at this. As a solution, I came up with using a custom email_prototype as a workaround.
Example:
monolog.yaml:
  symfony_mailer:
      type: symfony_mailer
      email_prototype: 'App\Email\ErrorMailPrototype'
      level: debug
      formatter: monolog.formatter.html
      content_type: text/html

App\Email\ErrorMailPrototype:
class ErrorMailPrototype extends Email
{
    /**
     * @param string[] $toArray
     */
    #[Required]
    public function setDefaults(
        #[Autowire('%env(csv:APP_ERROR_MAIL_RECIPIENTS)%')] array $toArray,
        #[Autowire('%env(APP_ERROR_MAIL_SENDER)%')] string $from,
    ): void {
        $this->to(...$toArray);
        $this->from($from);
        $this->subject('An Error Occurred! %message%');
    }
}


Set WEBDRIVERS=1 env var while running drivers

See https://github.com/titusfortner/webdrivers/issues/217#issuecomment-1019405659
@kapoorlakshya I've tested this on my machine (Ubuntu 21.10), and I've confirmed that it does make the env var available to my script. If you would be able to test this on Windows (mainly to make sure that it didn't break anything, not so much that the env var is present), that would be amazing. Thank you!
The reason I added intermediate scripts in bin/drivers/ is so that the env var is only set while that driver is actually running. I wanted to make sure that if a user launches a driver via this library and then launches a driver not via this library in the same script, it would have the env var set for the former but not the latter.
I totally understand if this is not an ideal change to this library. If not, my existing solution should work fine without the env var.

Yeah, this seems like an unnecessary complexity for a non-standard use case. You should be able to implement this in an alternate fashion locally if you need it.
Thanks!


pkg/trace/obfuscate: fix bug where obfuscation fails for autovacuum sql text

What does this PR do?
we are seeing query text like autovacuum: VACUUM ANALYZE fake.table fail obfuscation in the postgres integration check, and we want to be able to ingest things like this for DBM. It is failing due to the fact that it has a : followed by a space char. Because it has a :, the obfuscater assumes it is the beginning of a bind variable. Since the bindVar scanner code does not handle this case, obfuscation fails.
simply checking if the char in front of the : is a space will prevent this from happening
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe how to test your changes
Write here in detail how you have tested your changes
and instructions on how this should be tested in QA.
Describe or link instructions to set up environment
for testing, if the process requires more than just
running the agent on one of the supported platforms.
Checklist

[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] The need-change/operator and need-change/helm labels has been applied if applicable.
[ ] The appropriate team/.. label has been applied, if known.
[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The config template has been updated if applicable.

Note: Adding GitHub labels is only possible for contributors with write access.

You should add a release note for this.


Component Focus Problem

When I click on a component other than Input, it acts as if I was going to focus and type the cursor. This issue is also present on material-ui.com and the component we use. I can't write, just cursor and focus problem.

Thanks for the report.
What browser (exact version) and operating system were you using for that screenshot?

Hi,
Windows 10 Enterprise 1803
Google Chrome Version 88.0.4324.190 (64-bit)

Hi,
Windows 10 Enterprise 1803
Google Chrome Version 88.0.4324.190 (64-bit)

You probably enabled the feature "Navigate the website with text cursor". Try pressing the key F7 to cancel it.

@KyLoc20 is probably right. Will close it, we can reopen if that's not the case.

Yes, F7 worked. Thank you. @KyLoc20


Add Tests of BrotliDecoderChannel

Motivation:
Noticed there were no tests for BrotliDecoderChannel, so here are a few for you to add.
Modification:
Created test cases for BrotliDecoderChannel.
Result:
See test cases

Let me know if you want me to cut a release.

Let me know if you want me to cut a release.

Still working on the basics of integration on my side.
If you want to cut a release in the next month or two for your own reasons, don't let me stop you.
There's no rush for a release of brotli4j from me (yet).

I don't have any release timeline but I'd help in every possible way to help in your integration in Jetty. :)
Btw, is the PR up?

Thanks a lot!


Unexpected SWQoS behavior with --use-rpc

Problem
--use-rpc flag doesn't seem to do what it is expected to do. Testing it out on mainnet-beta results in longer times for deployment than without it. All test results were with a hello world program that consisted of 194 transactions to deploy. Tests were run with Triton RPC with SWQoS forwarding enabled.
With —use-rpc

Microlamports per CU paid
Time to deploy

8k
1:01:15.20

100k
54:24.73

100k
50:08.12

100k
42:45.98

100k
43:49.45

500k
41:59.93

Without —use-rpc

Microlamports per CU paid
Time to deploy

8k
26:51.28

10k
24:04.20

100k
29:31.04

Median priority fees of recent blocks were under the fees paid for each at the time of deployment. The expectation is that if you're deploying a program using --use-rpc with a RPC that is paired with a validator with stake via SWQoS, the deployment would be faster than just spamming the TPU ports of the leaders.

CC @ilya-bobyr

Just to clarify, 1:01:15.20 - this is 1 hour to run 194 transactions, correct?
Or are you deploying multiple instances of this program?

Just to clarify, 1:01:15.20 - this is 1 hour to run 194 transactions, correct?
Or are you deploying multiple instances of this program?

That was a single program deployment that took over an hour.
I'm not convinced this is not related to something at the infra-level depending on what RPC you're using. I ran with Helius and got the following:
with --use-rpc

Microlamports per CU paid
Time to deploy

500k
13.385

100k
23.531

without --use-rpc

Microlamports per CU paid
Time to deploy

100k
Still running 20 min in.. will update once completed

I'll do some more investigation and close this if it ends up just infra-related.

I worked with the rpc provider and was able to determine there was an issue forwarding txs with their infra. I was able to then get sub 30s deploys with their infra.
I'm going to close this issue as it seems to work as intended and the unexpected behavior was due to an infra issue.


 So I merged only the thing we lacked.

Oh, those were added by us? Ok, then I guess this PR isn't needed at all, my bad. We can then consider the Veekun alignment completed!
Yay hahahah

Great work with the PR's, I guess we're synced up again 😄


Selenide, Jenkins // After running jobs on locally deployed Jenkins, the screenshot in allure looks very strange (grey content)

Brief info:
I deployed Jenkins locally and configured the necessary plugins.
I take a screenshot during execution and in allure I see that screenshot is empty (black screen) in the report
Environment:
Allure Jenkins Plugin - Version 2.31.1
Selenide version - 7.3.2
Chrome version - 126.0.6478.127
What Operating System are you using (both controller, and any agents involved in the problem)?
Controller: Windows 11
Agents: Windows 11
Reproduction steps
I configured code to take a screenshot which was working previosly:
@Listeners({TextReport.class})
public class BaseTest {
@BeforeClass
public void configuration() {
SelenideLogger.addListener("AllureSelenide", new AllureSelenide()
.screenshots(true)
.savePageSource(false));
}
}
also attached pom.xml file:
pom.txt
I created locally freestyle job with a:
Source code management - Git,
Build Steps - Invoke top-level Maven targets - Goals: clean install
Post-build Actions - Allure report
Expected Results
After bulid done should be created allure report with a screenshot if test failed:
Local execution from IntelliJIdea:

Actual Results
After bulid done created allure report with a screenshot if test failed:
Execution from Jenkins - Screenshot is empty (black screen if download):

Screenshot:

Notes:
With the same code everything works month ago.
After installing a new version Jenkins with Allure Jenkins Plugin - Version 2.31.1 this issue happens.
Also attaching github project:
https://github.com/StasiukMarian/sep-2023-aqa.git

With the same code everything works month ago.

So if nothing changes in the code, it is obviously your environment issue not related to Selenide/Selenium. Dunno why you decided to report it to selenide repo.


since-branch and since now returns dependant workspaces

Previously the function GetChangedWorkspaces only returned the workspaces that actually had changed. GetChangedWorkspaces is now also adding the depdent workspaces so that a change to a workspace is correctly reflected in the following build.

🙏 thanks for the fix!


Issues in client.get_collection_view function?

When I try to get one collection I'm getting the following error:
File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 165, in get_collection_view
collection = self.get_block(
File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 118, in get_block
block = self.get_record_data("block", block_id, force_refresh=force_refresh)
File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 111, in get_record_data
return self._store.get(table, id, force_refresh=force_refresh)
File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\store.py", line 184, in get
self.call_load_page_chunk(id)
File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\store.py", line 286, in call_load_page_chunk
recordmap = self._client.post("loadPageChunk", data).json()["recordMap"]
File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 209, in post
raise HTTPError(
requests.exceptions.HTTPError: Invalid input.
Someone is getting the same error or there are any updates in the lib?

I'm seeing the same error as of 7-10 days ago

Same!

Yep, +1 for this

Yes. We are struggling with a few errors since 7-10 days ago.
429 Too Many Requests and Error and 400 error on get_block() call seems to have the same root problem.
Please any help would be really appreciate!!
Thanks 😃

This error is resolved by modifying 'call_load_page_chunk()' within 'store.py'.
    def call_load_page_chunk(self, page_id):
        if self._client.in_transaction():
            self._pages_to_refresh.append(page_id)
            return

        data = {
            "pageId": page_id,
            "limit": 100,
            "cursor": {"stack": [[{"table": "block", "id": page_id, "index": 0}]]},
            "chunkNumber": 0,
            "verticalColumns": False,
        }
        data = self._client.post("loadPageChunk", data).json()
        self.store_record_map(data)

POINT. Modify 'limit' to 100

This error is resolved by modifying 'call_load_page_chunk()' within 'store.py'.
    def call_load_page_chunk(self, page_id):
        if self._client.in_transaction():
            self._pages_to_refresh.append(page_id)
            return

        data = {
            "pageId": page_id,
            "limit": 100,
            "cursor": {"stack": [[{"table": "block", "id": page_id, "index": 0}]]},
            "chunkNumber": 0,
            "verticalColumns": False,
        }
        data = self._client.post("loadPageChunk", data).json()
        self.store_record_map(data)

POINT. Modify 'limit' to 100

If I update the call_load_page_chunk I'm having the following error:
Traceback (most recent call last):
  File "C:\Users\pfser\PycharmProjects\HousesNotion\Houses_update.py", line 166, in <module>
    cv = client.get_collection_view(notion_db)
  File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 216, in get_collection_view
    collection = self.get_block(
  File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 169, in get_block
    block = self.get_record_data("block", block_id, force_refresh=force_refresh)
  File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\client.py", line 162, in get_record_data
    return self._store.get(table, id, force_refresh=force_refresh)
  File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\store.py", line 184, in get
    self.call_load_page_chunk(id)
  File "C:\Users\pfser\PycharmProjects\HousesNotion\venv\lib\site-packages\notion\store.py", line 285, in call_load_page_chunk
    self.store_record_map(data)
AttributeError: 'RecordStore' object has no attribute 'store_record_map'

Unfortunately, simply adding a limit to the returns data call in call_load_page_chunk did not resolve the issue when looping through rows of large data sets.  I've added a rate limit that is working for 1000+ rows.
I have also tested this with merge #294 and it is working.

I had this error and figured out it only occurred when I want to load a page that is nested in a folder-like structure. Once I put it back to the top-level the error was gone... this is an unpleasant fix but feasible for now...

Any updates on that? I'm having this problem

Currently experiencing the exact same issue. Any idea how to fix that? Do you think the official api can help? :)

Ah, they changed the API again.  page_id needs to be provided is an object.
def call_load_page_chunk(self, page_id):

        if self._client.in_transaction():
            self._pages_to_refresh.append(page_id)
            return

        data = {
            "page": {
                "id": page_id
            },
            "limit": 100,
            "cursor": {"stack": []},
            "chunkNumber": 0,
            "verticalColumns": False,
        }

        recordmap = self._client.post("loadPageChunk", data).json()["recordMap"]

        self.store_recordmap(recordmap)


Undefined symbols for architecture i386

@TongChia
这样的错误，帮助一下
Undefined symbols for architecture i386:     -
"_CATransform3DIdentity", referenced from:
+[UPViews loadingImageViewWithOriginalPoint:] in libUPPayPlugin.a(UPViews.o)
"_CATransform3DMakeRotation", referenced from:
+[UPViews loadingImageViewWithOriginalPoint:] in libUPPayPlugin.a(UPViews.o)
"OBJC_CLASS$_CABasicAnimation", referenced from:
objc-class-ref in libUPPayPlugin.a(UPViews.o)
"OBJC_CLASS$_CAGradientLayer", referenced from:
objc-class-ref in libUPPayPlugin.a(UPUtils.o)
objc-class-ref in libUPPayPlugin.a(UPBaseViewController.o)
objc-class-ref in libUPPayPlugin.a(UPInitViewController.o)
"OBJC_CLASS$_CALayer", referenced from:
objc-class-ref in libUPPayPlugin.a(UPAlertViewEx.o)
"OBJC_CLASS$_PKPayment", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppTestPaymentSummaryViewController.o)
"OBJC_CLASS$_PKPaymentAuthorizationViewController", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppPresentingViewController.o)
"OBJC_CLASS$_PKPaymentRequest", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppPresentingViewController.o)
"OBJC_CLASS$_PKPaymentSummaryItem", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppPresentingViewController.o)
"_PKPaymentNetworkAmex", referenced from:
-[PingppPresentingViewController viewDidAppear:] in libpingpp+applepay.a(PingppPresentingViewController.o)
"_PKPaymentNetworkMasterCard", referenced from:
-[PingppPresentingViewController viewDidAppear:] in libpingpp+applepay.a(PingppPresentingViewController.o)
"_PKPaymentNetworkVisa", referenced from:
-[PingppPresentingViewController viewDidAppear:] in libpingpp+applepay.a(PingppPresentingViewController.o)
ld: symbol(s) not found for architecture i386

@TongChia
加入

错误：
Undefined symbols for architecture i386:     /
"OBJC_CLASS$_PKPayment", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppTestPaymentSummaryViewController.o)
"OBJC_CLASS$_PKPaymentAuthorizationViewController", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppPresentingViewController.o)
"OBJC_CLASS$_PKPaymentRequest", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppPresentingViewController.o)
"OBJC_CLASS$_PKPaymentSummaryItem", referenced from:
objc-class-ref in libpingpp+applepay.a(PingppPresentingViewController.o)
"_PKPaymentNetworkAmex", referenced from:
-[PingppPresentingViewController viewDidAppear:] in libpingpp+applepay.a(PingppPresentingViewController.o)
"_PKPaymentNetworkMasterCard", referenced from:
-[PingppPresentingViewController viewDidAppear:] in libpingpp+applepay.a(PingppPresentingViewController.o)
"_PKPaymentNetworkVisa", referenced from:
-[PingppPresentingViewController viewDidAppear:] in libpingpp+applepay.a(PingppPresentingViewController.o)
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
移除
    <!-- ApplePay -->
    <source-file src="libs/ios/Channels/ApplePay/libpingpp+applepay.a" framework="true"/>
    <header-file src="libs/ios/Channels/ApplePay/Pingpp+ApplePay.h" />

无错误
so ...

要引入  ？
现在的问题应该还是在 ApplePay 这块


Add Jailbreak Scratch

Thanks for the PR! We've simplified the process of adding your site/repo to the list. Instead of updating SITES.md you would add the utterances topic to your repo.


Fixes the Activerecord::TooManyRecords namespace:

Class TooManyRecords was in the ActiveRecord::MassAssignmentSecurity::NestedAttributes namespace, resulting in a UnitializedConstant exception

Not too sure if I should add a test for this.
Thanks :)

Thanks! A test would be useful, yes. Not sure how hard it is though. Could you give it a try?

Sure! I made the change, but no rush, review whenever you have time ;). Good night

Is this released already?

Not yet.


Organize models in a package

FEATURE DESCRIPTION
Feature Inspiration
A large models.py file is hard to look through and update.
Feature Description
Break up models.py into a models package (see https://docs.djangoproject.com/en/4.0/topics/db/models/#organizing-models-in-a-package)
Alternatives Considered
Comment
Take care to communicate with other developers so they are aware of this incoming PR and can avoid making large changes to the models.py file during this refactor.

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Requirements

List of conditions to be met for the feature
E.g. Every column/row must display a value, i.e. cannot be empty

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected/Changed Components

Files
Environment variables
External executables
Database tables
Cron job settings
Etc.

DESIGN
GUI Change description
Describe changes the user will see.
Code Change Description (Pseudocode optional)
Describe code changes planned for the feature.
Tests
A test should be planned for each requirement (above), where possible.

@fkang-pu @hepcat72 @lparsons Anyone currently "making large changes to the models.py file"?  Should I go ahead and embark on this, and is there a specific version of main I should branch from? (should I wait for any existing PRs or unknown branches to be merged first)?

I say go for it, I don't think any outstanding PRs touch models.py.


define huffman::table::canonicalize()

huffman::table::canonicalize() updates the existing codes in a table to
canonical form for DEFLATE:

All codes of a given bit length have lexicographically consecutive
values, in the same order as the symbols they represent;
Shorter codes lexicographically precede longer codes.

Change-Id: Idc3dceefe1b5d17a54f1dab29155a499c7e1d138

Codecov Report

Merging #88 (816fa4b) into Ic3798d8976d664827085a3f30374730ba3039645 (041bcb8) will decrease coverage by 0.36%.
The diff coverage is 95.23%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@                              Coverage Diff                              @@
##           Ic3798d8976d664827085a3f30374730ba3039645      #88      +/-   ##
=============================================================================
- Coverage                                      99.57%   99.22%   -0.36%
=============================================================================
  Files                                             11       11
  Lines                                            236      257      +21
=============================================================================
+ Hits                                             235      255      +20
- Misses                                             1        2       +1

Files Changed
Coverage Δ

huffman/src/detail/table_storage.hpp
100.00% <ø> (ø)

huffman/src/table.hpp
98.55% <95.00%> (-1.45%)
:arrow_down:

huffman/src/detail/static_vector.hpp
95.45% <100.00%> (+0.21%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Use context manager for all Open statements

In the python code base, all open statements lack a close statement.
Using a context manager, i.e.
with open(<filename>) as f:
    #do something with f
...

takes care of the proper file closing.

I would like to attach a label (Good first issue).

Don't worry about one liner open statements in the existing code. The file
would be closed automatically if the open statement didn't create a file
handler.
Junjun
On Fri, Sep 22, 2023 at 1:20 PM Cat Chenal @.***> wrote:

In the python code base, all open statements lack a close statement.
Using a context manager, i.e.
with open() as f:
#do something with f
...
takes care of the proper file closing.
—
Reply to this email directly, view it on GitHub
https://github.com/GunnerLab/Stable-MCCE/issues/256, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPRCWV3WLLD62OUT66WR6TX3XCG5ANCNFSM6AAAAAA5DM7HLY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


npc_agent in Scenario_4 will be blocked

Describe the bug
In npc_agent.py, the function that checks collision with other vehicles (_is_vehicle_hazard) only checks the x and y coordinates. While in scenario_4, the 'other_agent' is spawned with x and y that will block the ego agent (z=-500 does not help). Then the ego agent will always output an empty control command.
Expected behavior
The spawned other_agent does not block ego vehicle.
Desktop (please complete the following information):

OS: [e.g. Ubuntu 16.04]
CARLA Version [e.g. CARLA 0.9.6]
Python version [e.g. 2.7]
Version [e.g. 0.9.6]

Additional context
Add any other context about the problem here.

Hi,
this is a problem of the CARLA BasicAgent. Therefore, moved the issue to CARLA directly.


[connectedk8s] Update extension CLI to v1.10.4

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

We have set up live tests in our forked repository as a continuous integration (CI) check and have tested all lint, styling changes.
For the 'connectedk8s proxy' cli fix, we have added test:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations/ConnectProxy.Tests.ps1
As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

Thank you for your contribution! We will review the pull request and get back to you soon.

We have set up live tests in our forked repository as a continuous integration (CI) check and have tested all lint, styling changes.
For the 'connectedk8s proxy' cli fix, we have added test:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations/ConnectProxy.Tests.ps1
As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

please add some tests for this fix to verify if it could meet your expectations.


Issue #27372: workaround for SQL Server tables with triggers now require special EF Core configuration does not compile

The workaround on this page contains code that doesn't compile with EF Core 7:

'IConventionTrigger' does not contain a definition for 'GetName' and the best extension method overload 'RelationalKeyExtensions.GetName(IReadOnlyKey, in StoreObjectIdentifier)' requires a receiver of type 'IReadOnlyKey'

In the BlankTriggerAddingConvention class, the following method is problematic in both GetName method calls:
public virtual void ProcessModelFinalizing(IConventionModelBuilder modelBuilder, IConventionContext<IConventionModelBuilder> context)
  {
      foreach (IConventionEntityType entityType in modelBuilder.Metadata.GetEntityTypes())
      {
          StoreObjectIdentifier? table = StoreObjectIdentifier.Create(entityType, StoreObjectType.Table);

          if (table != null && entityType.GetDeclaredTriggers().All(t => t.GetName(table.Value) == null))
              entityType.Builder.HasTrigger(table.Value.Name + "_Trigger");

          foreach (IConventionEntityTypeMappingFragment fragment in entityType.GetMappingFragments(StoreObjectType.Table))
          {
              if (entityType.GetDeclaredTriggers().All(t => t.GetName(fragment.StoreObject) == null))
              {
                  entityType.Builder.HasTrigger(fragment.StoreObject.Name + "_Trigger");
              }
          }
      }
  }

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f1b683ae-c697-ebc8-d0aa-648d7573136e
Version Independent ID: f1b683ae-c697-ebc8-d0aa-648d7573136e
Content: Breaking changes in EF Core 7.0 (EF7) - EF Core
Content Source: entity-framework/core/what-is-new/ef-core-7.0/breaking-changes.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

@hbulens your code looks different from the one in our docs: our code sample uses GetDatabaseName, whereas you're using GetName.

You are right. Makes me wonder where I got the original code snippet from. Either way, all is well then!


Build for Apple Silicon

Hey, would it be possible to get a Universal build of this? Just upgraded my MacBook and would love to be able to run this app without Rosetta.

It should already run without Rosetta. Just to confirm I've downloaded the last version and it runs natively on my Mac with M1.

What's shown inside system info > applications on your machine?
If it shows Intel and you restored from a Time Machine Backup, you could try to reinstall the app. Maybe that helps.

Ah! You're right, it is working fine. I had downloaded an older version using the link on this page. I think you could use https://github.com/lovetodream/gitimoji/releases/latest/download/gitimoji.app.zip instead.


dropdown-menu style when append-to-body

Is your feature request related to a problem? Please describe.
Whenever a dropdown has append-to-body set to true, there's no way to add 'local' styles to the dropdown menu using CSS, since you can't filter the parent class, and just using .dropdown-menu would result in changes in all dropdown instances.
Describe the solution you'd like
Easier solution would be to add a menu-class/dropdown-menu-class prop to the dropdown component.
Describe alternatives you've considered
If the dropdown slot allowed other elements besides templates, the issue would also be solved, but I think that would result in a lot of CSS being rewritten to allow that.
Also, I know I can always just do the styling by JS, but I think CSS is always preferred.
Additional context
Quick example:
<dropdown :append-to-body="true" class="dropdown-test">
  <btn type="primary" class="dropdown-toggle">Dropdown</btn>
  <template slot="dropdown">

Option

  </template>
</dropdown>

body > .dropdown-menu {
 // ...
}

this will work as expected I guess?

I use other dropdown components with append-to-body, so doing that would also end up overriding the styles of other dropdowns. If you're ok with the dropdown-menu-class idea I can try implementing it on the weekend.

It's totally fine. Note that if you're targeting Vue.js 2, please make PR to 1.x branch, otherwise dev branch.

This is still an issue - a class property would be great since append-to-body only adds an
 to the body which you cannot specify - you can style if it's the only dropdown, but if you have multiple it will clash.


Multiple layers of Body Copy shown in ARSignUpSplashViewController.

Steps to reproduce:
-> Download app for the first time.
-> Click on login/Signup
-> Press back
-> Swipe the splashViewController and you can notice the previous body copy fixed statically.

@vijaytholpadi Great report :clap:
However, we’re in the process of completely overhauling the on-boarding, so we won’t be spending any time on this for now #1363. Thanks for taking the time, though!


⚠ Bofrost.lu has degraded performance

In 2b273af, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1507 ms

Resolved: Bofrost.lu performance has improved in 4dd0149 after 17 minutes.


Make engine suitable to run over PGA

Parent objective:  #11
Progress: 100%

[x] [P0] Fix the reported errors and do not crash
[x] [P1] Report errors with meaning information for tracing the root causes

@smola we cannot go deeper on Improve performance of engine over PGA before having more metrics/tracing info. To know how far we should go improving performance, we should add some number to this OKR, like expected percentage of performance improvement.

The latest engine versions have much better error reports and we fix all the execution errors that appeared.


MammothTemplateMixin + Some fixes to Identify_math_theorems

This PR adds MammothTemplateMixin, which can be used to apply the first template prompt from MAmmoTH here: https://github.com/TIGER-AI-Lab/MAmmoTH/blob/602da3df96f0dffdc092dcb1c8bf3ceef2f5eaf1/utils.py#L57 either with or without the separate ### Input field (when using a description, this is used.)
The changes required to apply this to a task are:

add the MammothTemplateMixin to
modify MyTask.doc_to_text() to apply doc_to_template instead following the example in this PR.

Note that the ordering left-to-right of inheritance matters here. This mixin should come prior to other, in order to use its fewshot_context method which then calls to super()'s fewshot_context in the correct order.
This PR also fixes identify_math_theorems somewhat, because it turns out that the official bigbench dataset loading script does preprocessing I didn't anticipate (namely, it had already added the description, which for this feature we do not want).

Open prompt engineering Qs:

Should we drop the trailing Answer: in doc_to_text if it'd be followed by "Response:"?
How should the fewshot setting be framed?

Putting merging this on hold, since it's likely we want to finetune on MetaMath.

Reverting the mammoth template mixin (at least for now, we can cherry-pick it in a future commit if we end up needing it) and merging.


Feedback Form UI/UX Fixed

Before:

After:

#852

@Its-Aman-Yadav please review this PR and merge this under GSSOC for any changes please feel free to contact

resolve conflicts @alpharsh

hey @Its-Aman-Yadav all the merge conflicts have been resolved and also the other components please review


Link checker action

Probably worth looking at what already is setup for https://github.com/canada-ca/template-gabarit and https://github.com/canada-ca/ore-ero


Array.filter callback parameter should not be required to return a boolean

The TypeScript definition for Array.filter specifies the callback must return a boolean, thus the code example at the bottom of this post fails to compile.  Here's the current definition:
filter(callbackfn: (value: T, index: number, array: T[]) => boolean, thisArg?: any): T[];

The spec says this about the callback parameter:

callbackfn should be a function that accepts three arguments and returns a value that is coercible to the Boolean value true or false.

Thus I propose the definition should be changed to:
filter(callbackfn: (value: T, index: number, array: T[]) => any, thisArg?: any): T[];

Note: using a double not-operator is a sufficient workaround with negligible implications
TypeScript Version:
1.8.7
Code
Playground
// the purpose is to weed out falsey values
let a = [1, 2, 3, undefined, 0, 42, ""].filter(i => i)
// "i => i" is an error because it does not return boolean
// the following has no error
let b = [1, 2, 3, undefined, 0, 42, ""].filter(i => !!i)

Expected behavior:
No compile errors
Actual behavior:
Compile errors

This appears to be a duplicate of issue #5850
To reduce noise in issue searches, we close issues that are already tracked somewhere else. If you think the linked issue is not actually the same, please leave a comment here (we do read comments on closed issues). Otherwise you can follow or chime in on the linked issue. Thanks!


Merge upstream 4.0.0

The braze modifications can be seen with https://github.com/braze-inc/knapsack/compare/v4.0.0...merge-upstream-4.0.0 (unfortunately this repo was not created as a fork of the upstream, so GitHub's native compare doesn't work)

Any notable updates?

yes, it is being tested upstream with ruby > 2.6 and bugs fixed in tracking test times
see the CHANGELOG diff in this PR https://github.com/braze-inc/knapsack/pull/1/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed


Update Proxy Dev Cert

Can't extend localhost past a year expiration, so gotta roll this cert every year.
Current cert expires august 5th!

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

I have verified that the new HTTPS cert slots in and is usable on:

a ubuntu codespaces machine.
my windows machine.
my WSL.
Paul Van Eck on the python team independently verified on his WSL as well.


Loading and then Unloading DLL with dependency locks the DLL

I follow the .NET docs tutorial at:
https://docs.microsoft.com/en-us/dotnet/standard/assembly/unloadability
and wanted to see if load/unload dll which has dependency will work.
I used AssemblyLoader with resolver:
class TestAssemblyLoadContext : AssemblyLoadContext
{
    private AssemblyDependencyResolver _resolver;

    public TestAssemblyLoadContext(string mainAssemblyToLoadPath) : base(isCollectible: true)
    {
        _resolver = new AssemblyDependencyResolver(mainAssemblyToLoadPath);
    }

    protected override Assembly Load(AssemblyName name)
    {
        string assemblyPath = _resolver.ResolveAssemblyToPath(name);
        if (assemblyPath != null)
        {
            return LoadFromAssemblyPath(assemblyPath);
        }

        return null;
    }
}

Then, I created 2 other projects, one is simple class without dependency, and the other is class that uses newtonsoft json as dependency. then I publish those classes and put the DLL in a folder inorder to load it from my app.
The first simple class which has no dependency, I loaded/unloaded with no problem, and able to delete the DLL.
The second DLL which has dependency was locked after unloading it, I try to wait for GC (as in the tutorial) , and loop forever, it never finishes. even if I try to delete the file after unload, it can't be deleted. seems like after running LoadFromAssemblyPath from my TestAssemblyLoadContext, some references are still in alive in the inner implementation of AssemblyLoadContext
Would be happy for some help, most of the people who use plugin probably has dependency, and not just a simple class i guess.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3283764-f15a-fa5f-5106-6f294c780f7b
Version Independent ID: b03cedce-9074-9686-0b31-045b2b4c862d
Content: How to use and debug assembly unloadability in .NET Core
Content Source: docs/standard/assembly/unloadability.md
Product: dotnet
GitHub Login: @janvorli
Microsoft Alias: janvorli

Thanks @winaterion. @janvorli can you help with this feedback?

The problem is in the newtonsoft json, not in the plugin having dependencies in general. The newtonsoft json cannot be unloaded due to some of its internal implementation details. See the https://github.com/dotnet/coreclr/issues/26271 for more details.

@janvorli I tried a different dependency, and it worked, But, I had to tweak the example in the documentation (at https://docs.microsoft.com/en-us/dotnet/standard/assembly/unloadability) in order for it to work, Seems like when I publish my library which has dependencies (like SharpCompress for example), the example in documentation still locks the file, so instead of getting the assembly as said in the docs, I had to read the DLL from stream, and it would fix the DLL locking problem:
using (var fs = new FileStream(pluginLocation, FileMode.Open, FileAccess.Read))
{
var pluginAssembly = loadContext.LoadFromStream(fs);
}
Thanks for the input though, newtonsoft would never work in any case, not even in stream ;)

@winaterion you should not need to use the file stream trick, it should still work as is. I think the file lock is probably just a temporary thing. What you can try (just to verify that) is to keep a list of weak reference to all the assemblies loaded by the AssemblyLoadContext.Load method and modify the loop with GC.Collect / GC.WaitForPendingFinalizers so that it checks not only the weak reference to the assemblyloadcontext, but also all the weak references to the loaded assemblies and exit the loop only after all the weak references are not alive. That would prove whether there is a real problem in the runtime or whether it is a timing issue.

@janvorli you are right, it seems to be working. I probably didn't clean some old DLLs because earlier when I run GC code, it went to infinite loop. All is perfect now, thanks for the support!  =)