Update GXJniAnalyze.cpp  释放资源时，同时释放弱引用

解决JS倒计时有使用数组的场景下crash 问题。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


sql_lab can not query data

Superset version
0.17
Expected results
Actual results
error log:
[2017-04-21 11:19:00,625] ERROR in app: Exception on /slicemodelview/show/148 [GET]
Traceback (most recent call last):
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
    return f(self, *args, **kwargs)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/views.py", line 469, in show
    related_views=self._related_views)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/baseviews.py", line 158, in render_template
    return render_template(template, **dict(list(kwargs.items()) + list(self.extra_args.items())))
  File "/data/superset_venv/lib/python2.7/site-packages/flask/templating.py", line 134, in render_template
    context, ctx.app)
  File "/data/superset_venv/lib/python2.7/site-packages/flask/templating.py", line 116, in _render
    rv = template.render(context)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/model/show.html", line 2, in top-level template code
    {% import 'appbuilder/general/lib.html' as lib %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/base.html", line 1, in top-level template code
    {% extends base_template %}
  File "/data/superset_venv/lib/python2.7/site-packages/superset/templates/superset/base.html", line 1, in top-level template code
    {% extends "appbuilder/baselayout.html" %}
  File "/data/superset_venv/lib/python2.7/site-packages/superset/templates/appbuilder/baselayout.html", line 2, in top-level template code
    {% import 'appbuilder/baselib.html' as baselib %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/init.html", line 46, in top-level template code
    {% block body %}
  File "/data/superset_venv/lib/python2.7/site-packages/superset/templates/appbuilder/baselayout.html", line 21, in block "body"
    {% block content %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/model/show.html", line 25, in block "content"
    {% block show_form %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/model/show.html", line 27, in block "show_form"
    {{ widgets.get('show')()|safe }}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/widgets.py", line 34, in __call__
    return template.render(args)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/widgets/show.html", line 33, in top-level template code
    {{value_columns[loop.index-1]}}
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)
Exception on /slicemodelview/show/148 [GET]
Traceback (most recent call last):
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/data/superset_venv/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
    return f(self, *args, **kwargs)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/views.py", line 469, in show
    related_views=self._related_views)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/baseviews.py", line 158, in render_template
    return render_template(template, **dict(list(kwargs.items()) + list(self.extra_args.items())))
  File "/data/superset_venv/lib/python2.7/site-packages/flask/templating.py", line 134, in render_template
    context, ctx.app)
  File "/data/superset_venv/lib/python2.7/site-packages/flask/templating.py", line 116, in _render
    rv = template.render(context)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/model/show.html", line 2, in top-level template code
    {% import 'appbuilder/general/lib.html' as lib %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/base.html", line 1, in top-level template code
    {% extends base_template %}
  File "/data/superset_venv/lib/python2.7/site-packages/superset/templates/superset/base.html", line 1, in top-level template code
    {% extends "appbuilder/baselayout.html" %}
  File "/data/superset_venv/lib/python2.7/site-packages/superset/templates/appbuilder/baselayout.html", line 2, in top-level template code
    {% import 'appbuilder/baselib.html' as baselib %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/init.html", line 46, in top-level template code
    {% block body %}
  File "/data/superset_venv/lib/python2.7/site-packages/superset/templates/appbuilder/baselayout.html", line 21, in block "body"
    {% block content %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/model/show.html", line 25, in block "content"
    {% block show_form %}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/model/show.html", line 27, in block "show_form"
    {{ widgets.get('show')()|safe }}
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/widgets.py", line 34, in __call__
    return template.render(args)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/superset_venv/lib/python2.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/superset_venv/lib/python2.7/site-packages/flask_appbuilder/templates/appbuilder/general/widgets/show.html", line 33, in top-level template code
    {{value_columns[loop.index-1]}}
**UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)**

Steps to reproduce

python version? db backend? connection string flags?

@mistercrunch  i find this problem reason is sql field alias not alpha characters

unicode in db metadata seems very risky, seems to me like it would create issues in many places/tools, but if you have lots of unicode I'd recommend using python 3.4+

Notice: this issue has been closed because it has been inactive for 344 days. Feel free to comment and request for this issue to be reopened.


Android root/Jailbreak detection won't detect Rooting/cloaking/dangerous apps

I've been doing a little bit of investigation and I don't believe the check for rooting apps such as Magisk will succeed based on setting up the app according to the documentation (even if you have something like Magisk installed, the root detection will not detect it and mark the device as not rooted).
I think the following would need to be added to the setup documentation for Android:

The following packages need added to the <queries> section of the Android Manifest to ensure they can be detected by the plugin:

	<queries>
		<!-- KnownRootAppsPackages -->
		<package android:name="com.noshufou.android.su" />
		<package android:name="com.noshufou.android.su.elite" />
		<package android:name="eu.chainfire.supersu" />
		<package android:name="com.koushikdutta.superuser" />
		<package android:name="com.thirdparty.superuser" />
		<package android:name="com.yellowes.su" />
		<package android:name="com.topjohnwu.magisk" />
		<package android:name="com.kingroot.kinguser" />
		<package android:name="com.kingo.root" />
		<package android:name="com.smedialink.oneclickroot" />
		<package android:name="com.zhiqupk.root.global" />
		<package android:name="com.alephzain.framaroot" />

		<!--  KnownRootCloakingPackages -->
		<package android:name="com.devadvance.rootcloak" />
		<package android:name="com.devadvance.rootcloakplus" />
		<package android:name="de.robv.android.xposed.installer" />
		<package android:name="com.saurik.substrate" />
		<package android:name="com.zachspong.temprootremovejb" />
		<package android:name="com.amphoras.hidemyroot" />
		<package android:name="com.amphoras.hidemyrootadfree" />
		<package android:name="com.formyhm.hiderootPremium" />
		<package android:name="com.formyhm.hideroot" />
		<intent>
			<action android:name="android.support.customtabs.action.CustomTabsService" />
		</intent>
		<intent>
			<action android:name="android.media.action.IMAGE_CAPTURE" />
		</intent>
	</queries>

The permission QUERY_ALL_PACKAGES permission is another option, but Google heavily restricts its usage since it gives access to sensitive data: https://support.google.com/googleplay/android-developer/answer/10158779?hl=en-GB The above <queries> list may be too overreaching as well and be rejected by Google Play review.

I just tested with a device with Magisk and it didnt detect it.

I just tested with a device with Magisk and it didnt detect it.

If you add the config above, does it work? I think this might be mainly a documentation / setup issue.

I just tested with a device with Magisk and it didnt detect it.

If you add the config above, does it work @Pmr-precure ? I think this might be mainly a documentation / setup issue.

Sorry for the late answer, i didnt try with the queries, but i dont want to risk it getting rejected on play store, you think it will?

I think Google is likely to scrutinise QUERY_ALL_PACKAGES and reject submissions with it that don't require it for their main purpose. The smaller, fixed list is maybe more likely to pass review.
However, I think one of the options is required for more comprehensive "root detection". You should be able to test it locally before submitting to the store to see if it detects Magisk for you. Ultimately then it would be your call to decide to submit it to the Play Store or not.


Removing leading zeroes in number mask

Fixes #176

Sweet, thanks a lot @lozjackson! I'd like to test and merge this along with the other PR, but some thing came up. I have next week off from work so if I don't get a chance to do it this weekend, hopefully it won't be later than next week. Thanks again!

no problem, take your time

This is awesome. Thanks @lozjackson!

Published in<EMAIL_ADDRESS>👍


LDG flap drag too high

Love the mod, great work! Thanks for updating to SU5. There is one area where performance differs from the POH significantly though. Flaps in landing position add too much drag and result in very bad climb performance. The POH states about 1000-1500 fpm at 50% payload if I recall correctly while the FS version (vanilla as well as your mod) only gets around 150 at the most.
About 50% torque is required to maintain a -500 fpm descent when in RL it should be about 20%.
Could you edit the landing flap drag to fix this?
Many thanks for reading and again, great mod so far!

Yes. I testing new drag coefficient.

Check new version, and if all ok, close the issue

Much better, thank you! Well done


#262: Full Flyway integration

numbered the SQL scripts for Flyway
changed PartitioningForDB class to contain keysToValuesMap instead of keysToValues according to validation
added sbt alias testAll for running all tests
database test for validation function moved to proper folder
set flywayBaselineVersion for upgrade purposes

While it's almost 70 files, changes are minimal. In majority of cases it's just a rename.

For the actual upgrade deployment these steps are necessary:
Manual:
sbt -Dflyway.url=<target db url> -Dflyway.password=<postgres user password> flywayBaseline
Add to deployment automation
sbt -Dflyway.url=<target db url> -Dflyway.password=<postgres user password> flywayMigrate
where

<target db url> is the database towards which the deployment is running, e.g. "jdbc:postgresql://localhost:5432/atum_db"
<postgres user password> is the password for the postgres super user at the above database

Depends on #265
Depends on #267
Closes #262

Release notes:
Reordered and fixed database structure scripts to allow Flyway usage for incremental migration of existing database (version 0.1.x). Known issues: there might be needed some manual steps if upgrading from database of version 0.2.0.

This item depends on:

AbsaOSS/atum-service#265
AbsaOSS/atum-service#267
By Dependent Issues.

This item depends on:

AbsaOSS/atum-service#265
AbsaOSS/atum-service#267
By Dependent Issues.

This item depends on:

AbsaOSS/atum-service#265
AbsaOSS/atum-service#267
AbsaOSS/atum-service#272
AbsaOSS/atum-service#275
By Dependent Issues.

LGTM, found a few minor things. But I want to ask: why the numbering like this? For example there is no V<IP_ADDRESS>.{sql|ddl} file, so there are gaps. There is V<IP_ADDRESS>.ddl instead. So we don't want increments?

It is incremental, but with gaps.
I put the gaps there between folders/schemas number ranges, so in case of testing, if something has to change, I won't be forced to renumber everything. And it actually happened 😉


pull request for e2e test at 12/14/2016 01:56:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Club Financial Contributors under readme.md

Under the Financial Contributors section of the readme file in the main repository, contributing for individuals and organisations is listed separated but they point to the same webpage.
Contribution for individual/organisation can be clubbed under 1 heading itself.

Working on it? - Yes.

Can I work on it @CodeSarthak ?


update hello-world.md

Just a little change to the naming convention under the create new branch section

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jlord31
Thanks so much for opening a PR! I'll get this triaged for review :zap:


Corruption collection bug

There is a bug in SQL Server where querying sys.dm_db_mirroring_auto_page_repair as a non sysadmin user will generate a dump ( EXCEPTION_ACCESS_VIOLATION).
This issue will appear when running the Corruption collection with a low privilege account where there is a mirroring endpoint on the instance and databases in a restoring state.
The issue was detected on  SQL 2019 CU19 (15.0.4298.1).  This was a server migration so log shipping was in place to migrate the databases from the old server and availability groups had been configured.
This seems to be a bug that Microsoft will need to fix, but the collection query could be updated to reduce the chances of this occurring.  Instead of checking if we have a mirroring endpoint using:
EXISTS(select * from sys.database_mirroring_endpoints)
We could check if we are mirroring any databases:
EXISTS(SELECT 1 FROM sys.database_mirroring WHERE mirroring_role IS NOT NULL)
This check might be slightly more overhead as sys.database_mirroring returns a row per database regardless if mirroring is enabled - but it should be a more accurate check that will avoid this bug in most cases.

Note: Microsoft support case was raised for this issue.  It seems unlikely that this bug will be fixed though so a workaround is required.

Using sys.database_mirroring doesn't add any overhead even on a server with over 5000 DBs.  Execution time < 1ms.

Included in 2.45.1 🚀


Nowcast sensor endpoint

Based off #355, only new commits are f3c84f2 and onward. Basically steals a bunch of the covidcast code for the PHP and uses a s lightly different table definition (which is still to be finalized).
TODO:

[x] more integration tests, especially testing the acquisition flow.
[x] update client

@krivard for review (let me know if theres anyone else I should tag)
cc: @mariajahja

Whoops, github lied to me about how many changes were in here. Not done yet, I'll be able to take a closer look tomorrow.

No worries, it's certainly on the longer side. Let me know if I can make the commits more clear (the first one, f3c84f2, is the big one.)

Whoops, github lied to me about how many changes were in here. Not done yet, I'll be able to take a closer look tomorrow.

No worries, it's certainly on the longer side. Let me know if I can make the commits more clear (the first one, f3c84f2, is the big one.)

Thanks for catching. Removed the old signal arguments

Thanks for catching. Removed the old signal arguments


Feature/440/changelog utility

close #440

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.501%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
3335

Relevant Lines:
8036

💛  - Coveralls

Can you post a sample output?

Can you post a sample output?

absolutely, here you go

## v<IP_ADDRESS>
**example changelog**

* changelog binary that allows to generate a changelog consisting of commit messages between current HEAD and the last tag

* add changelog target to the makefile

* Update reviewdog references to smithy.

* Updating .gitignore to ignore smithy files previously ignored by ocurity.

* Updating actions to leverage smithy references.

* Updating tests to leverage smithy.

* Updating lock.

* Update README to replace ocurity with smithy.

* Updating protobuf contracts to use smithy as reference.

* Updating docs to use smithy references.

* Updating examples to leverage smithy.

Can you post a sample output?

absolutely, here you go
$changelog --repo-path . --new-tag-name="v<IP_ADDRESS>" --new-tag-message="example changelog"
## v<IP_ADDRESS>
**example changelog**

* changelog binary that allows to generate a changelog consisting of commit messages between current HEAD and the last tag

* add changelog target to the makefile

* Update reviewdog references to smithy.

* Updating .gitignore to ignore smithy files previously ignored by ocurity.

* Updating actions to leverage smithy references.

* Updating tests to leverage smithy.

* Updating lock.

* Update README to replace ocurity with smithy.

* Updating protobuf contracts to use smithy as reference.

* Updating docs to use smithy references.

* Updating examples to leverage smithy.

I think this looks good but I'd like to not have blank lines between each commit report. It would also be cool to add a short timestamp to each commit, which can be helpful for debugging potential individual issues.

As far as I understand the logic, the workflow is that the user runs the utility with the new tag that they want to add and the script generates a list of commit messages since the latest tag (latest being the latest one based on the timestamps)
What happens if we release a new major version (v1.0.0) but until it's rolled out everywhere we release a patch version of the previous major tag (previous latest version v0.66.0 and we release v0.66.1). This utility would produce list of commit messages for the new tag v1.0.1 from v0.66.1 to now instead of from v1.0.0, right? I would expect it to use the current tag passed as a flag to figure out that closest one, and the closest one would be found based on just simple string sorting.
Also, I would expect that we could pass flags to just create a new major/minor/patch version based on the latest tag because that's the most common use case and it would allow us to remove the relevant make targets

Can you post a sample output?

absolutely, here you go
$changelog --repo-path . --new-tag-name="v<IP_ADDRESS>" --new-tag-message="example changelog"
## v<IP_ADDRESS>
**example changelog**

* changelog binary that allows to generate a changelog consisting of commit messages between current HEAD and the last tag

* add changelog target to the makefile

* Update reviewdog references to smithy.

* Updating .gitignore to ignore smithy files previously ignored by ocurity.

* Updating actions to leverage smithy references.

* Updating tests to leverage smithy.

* Updating lock.

* Update README to replace ocurity with smithy.

* Updating protobuf contracts to use smithy as reference.

* Updating docs to use smithy references.

* Updating examples to leverage smithy.

I think this looks good but I'd like to not have blank lines between each commit report.
It would also be cool to add a short timestamp to each commit, which can be helpful for debugging potential individual issues!
@northdpole

@andream16 , how about this?
## v<IP_ADDRESS>

**foobar**

2024-10-22T12:20:21+01:00: changelog binary that allows to generate a changelog consisting of commit messages between current
HEAD and the last tag
2024-10-22T12:18:06+01:00: add changelog target to the makefile
2024-10-31T11:02:12Z: workaround defectdojo expecting a non-empty scanstarttime for their engagments


Support CodeContracts

Fixes #389
Adds CodeContract support; should be noted that only some run-time features are supported as to avoid any rewriter implementation. Although as far as I can tell this allows for full static analysis support.

Spotted a bug in this at present.
When a project references another project which is using this CodeContracts implementation I am getting the following error:
The serializable type System.Diagnostics.Contracts.__ContractsRuntime.ContractException must inherit from another serializable type, System.Object or System.Record.

I will need to investigate this one further.

The problem you are experiencing is most likely due to the reference to System that was accidentally added.
I don't know a lot about code contracts, but do they really belong in mscorlib? or should we create a separate project/dll for them?

CodeContracts were moved into the mscorlib. I figured it would be worth a shot at adding it into the core runtime here. However if you would prefer this to be a plugin then please let me know.

Hmm, I'm not sure.
If they are in mscorlib, they can go in mscorlib here as well. But perhaps the runtime support can be in another JS file? What do you think?

The runtime support is configurable via the CodeContracts extension; and can be turned off completely.
Our usages are purely used within debug and never enter our release builds.
If you could walk me through the process of moving the runtime support to a separate js file and would still prefer that approach I would be happy to do so.

Removing the System reference still doesn't resolve the previous issue. Will look into this further tomorrow.

So further investigation to the issue I've uncovered that it's not really a problem but something that needs documenting somewhere. Basically its the CodeContracts runtime injection that appears to be incompatible; this isn't really a problem since all I was using it for was it define the CONTRACTS_FULL symbol in DEBUG.

Simply ensuring that Runtime Checking is disabled ensures that no code will be injected and solves the issue.
If however anybody still wants the runtime code to be injected we can simply define the compilation symbol as part of out build.

It should be noted that we have only ever encountered this as a issue when attempting to build a project that is referenced to a project using CodeContracts. This should not affect anybody that does not have the CodeContracts extension installed.
Would you classify this as a acceptable workaround?
In addition let me know if you need anything further.

We could probably just change the MetadataImporter to not process types in the System.Diagnostics.Contracts.__ContractsRuntime assembly.

Thanks for your response, could you provide some more information as to how I would go about implementing something along those lines? Sorry I am still fairly unfamiliar to all the internals of the transpiler.

Inside the MetadataImporter class there is a method called ProcessType. Add an if statement to the top of that method (if (type.Namespace == "System.Diagnostics.Contracts.__ContractsRuntime") return TypeScriptSemantics.NotUsableFromScript();)

Thanks for that. Although it doesn't seem to make a difference. I tried:
if (typeDefinition.Namespace == "System.Diagnostics.Contracts.__ContractsRuntime")
{
    _typeSemantics[typeDefinition] = new TypeSemantics(TypeScriptSemantics.NotUsableFromScript(), false, false, false);
    return;
}

I can't seem to attach to any of the build processes to get any further details unfortunately. Will look into this a bit more if I get some time later.

Latest commit appears to fix the problem. Funnily enough the assertion is correct when checking the types FullName as apposed to its namespace.

Will merge this manually into the 3.0 branch


Add Forum and Discord components back to network page

In the original design, we had a feed of discord announcements from the #developer-annoucements channel as well as a feed from the forum from the #breaking-changes feed.

static builds https://github.com/onflow/docs


Update integration policy

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>Add some space between commands
Before:

After:

/assign @qiujian16

/lgtm


Open a dev branch for committing

Currently we have only master branch. We should have dev branch for the changes to be committed so that master is clean and production version.

IMHO, the project is small enough that committing directly to master isn't going to be a problem.
You should fork the repo under your own github account, make commits in your fork and then open PRs to be merged into bfortuner/ml-cheatsheet.
Another best practices is to make individual changes in separate "feature branches" and then open small pull requests for each feature, e.g.
# Fork repo to your github then
cd MyProjects
git clone git@github.com:janardhanpshetty/ml-cheatsheet.git
cd ml-cheatsheet
git status
git checkout -b feature/docfix
# edit files
git add .
git commit -m"fixed something in doc"
git push

then github will automatically prompt you to open a PR from your branch feature/docfix.

Tried to create a feature branch but it failed to access :
git push --set-upstream origin feature/docfix
remote: Permission to bfortuner/ml-cheatsheet.git denied to janardhanpshetty.
fatal: unable to access 'https://github.com/bfortuner/ml-cheatsheet.git/': The requested URL returned error: 403

You've cloned the bfortuner/ml-cheatsheet.git repo, which you are not allowed to "write to".
You'll need to start over the process. Note the URLs in the sample commands I sent you. Here are th steps.

First you want to fork the bfortuner/ml-cheatsheet to obtain a clone of it under your own github account—use the [Fork] button and a 20 seconds later you'll have janardhanpshetty/ml-cheatsheet then run the commands:

cd MyProjects
mv ml-cheatsheet readonly-ml-cheatsheet
git clone git@github.com:janardhanpshetty/ml-cheatsheet.git
cd ml-cheatsheet
git status
git checkout -b feature/docfix
# edit files
git add .
git commit -m"fixed something in doc"
git push --set-upstream origin feature/docfix

Note I'm assuming you've setup an ssh key with github so you can use the git+... style URLs.
If this is not the case you have to change the URL in step 3 of the above code to the https:// style:
git clone https://github.com/janardhanpshetty/ml-cheatsheet.git

After that every time you push, you'll be asked for your github username and password.

@ivanistheone This helped thanks. Can you confirm on these steps for contribution ?
Fork brendan's repo
command line:
cd MyProjects
git clone git@github.com:janardhanpshetty/ml-cheatsheet.git
cd ml-cheatsheet
git status
git checkout -b feature/docfix
edit files
git add .
git commit -m"fixed something in doc"
git push --set-upstream origin feature/docfix
Collaborating
Create a pull request for my repo
Merge pull request on my github then
Make html and check the changes for my master repo
Create a pull request from my master repo to brendan's repo
Add reviewers
Once reviewed brendan or other committer is able to merge the change
One doubt is can we create a pull request from our feature branch directly to brendan's master branch without merging to our master, which is what is done currently ?

Steps look good, and yes opening the PR from the feature branch (as you've done) is the way to do it.

Yep as Ivan said. No need to create separate branches. Just clone the repo. Make some changes, then create a pull request!


Fix update patient

Fix #627

Coverage increased (+0.3%) to 65.461% when pulling 99399ef35dc275c5cb54c8631931359d35956294 on edrisse:fix-update-patient into 766ddeae2ab651aff24ad6d8e2820878428d3249 on esaude:master.


Much more error

2024-11-15 16:58:26 | ERROR    | 742 - bae | Unknown error: 'NoneType' object is not iterable
2024-11-15 16:58:41 | SUCCESS  | 116 - No change in js file: main.9234e34d.js
2024-11-15 16:58:41 | INFO     | 639 - Session Nguyet Pro logged in.
2024-11-15 16:58:42 | ERROR    | 208 - Error while getting user data. Response 401. Try again after 30s
2024-11-15 16:58:50 | ERROR    | 437 - 3322 | Error code 401 While trying to get data
2024-11-15 16:58:50 | WARNING  | 232 - 3322 | Failed to get special tasks data. Response code: 401
2024-11-15 16:58:50 | INFO     | 662 - 3322 | No special tasks now!
2024-11-15 16:58:50 | ERROR    | 437 - sake | Error code 401 While trying to get data
2024-11-15 16:58:50 | ERROR    | 458 - 3322 | Error code 401 While trying to get completed task

Banned


HideTooltip Function Interferes with Tooltip Display in Other Addons

Description
The HideTooltip function in Core.lua unhooks the previous OnShow script and hooks a new one, causing issues with the tooltip display in other addons. This interference can lead to tooltips not showing correctly. This causes issues in my 2 UIs KkthnxUI and NexEnhance. If you have a better approach let me know.
https://github.com/Kkthnx-Wow/NexEnhance
https://github.com/Kkthnx-Wow/KkthnxUI
basically, will break my tooltips and they won't be displayed correctly. Main issue is the skinning to the status bar doesn't show correctly or at all...
Problematic Code
local function HideTooltip(shouldHide)
  local hookFunction = function()
    if shouldHide then
      _G.GameTooltip:Hide()
    else
      _G.GameTooltip:Show()
    end
  end

  -- Need to call it immediately in case there's a tooltip still fading
  hookFunction()

  _G.GameTooltip:SetScript("OnShow", nil) -- unhook previous script
  _G.GameTooltip:HookScript("OnShow", hookFunction)
end

Suggested Code
local tooltipHidden = false

local function HideTooltip(shouldHide)
  tooltipHidden = shouldHide

  local hookFunction = function()
    if tooltipHidden then
      _G.GameTooltip:Hide()
    end
  end

  -- Need to call it immediately in case there's a tooltip still fading
  hookFunction()

  _G.GameTooltip:HookScript("OnShow", function(self)
    if tooltipHidden then
      self:Hide()
    end
  end)
end

If you want example, please let me know I can provide, and we can come up with a solution. Thank you for making such an amazing addon <3


Which pytorch version do you use?

Which pytorch version do you use?when I use your code,here is a problem with me .
import top_pool, bottom_pool, left_pool, right_pool
ImportError: /home/hdc/.local/lib/python3.6/site-packages/cpools-0.0.0-py3.6-linux-x86_64.egg/top_pool.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN2at15UndefinedTensor10_singletonE

@yuanfuqiang456  have you fixed this problem?

@yuanfuqiang456 have you solved this problem?

according to the version of cuda


[TS migration] Migrate 'PopoverMenu' component to TypeScript

Details

[TS migration] Migrate 'PopoverMenu' component to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/25096
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Click FAB and make sure Popover Menu looks ok.
[WEB AND DESKTOP] Press Arrow Up/Down and verify that the focused state changes.
[WEB AND DESKTOP] Verify the hover effect over the menu row - the background and text color should change.
Click on any menu item to ensure it works as expected.

Repeat the same steps with the next Popover Menus:

Settings -> Profile -> Tap on Avatar -> Upload photo Popover Menu
Any chat -> Tap add button in the chat input -> Attachments Popover Menu
Anu chat -> Three dots button in the header -> Three dots button menu

Storybook:

Open Storybook
Select PopoverMenu component
Make sure it looks and works the same way as before.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

Same as in the Tests section
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/23176449/660b30b7-e6b1-4683-84da-faf6fac0c63f

iOS: Native

https://github.com/Expensify/App/assets/23176449/ce74a73c-feb7-4b4d-912f-c4ac756a4e39

iOS: mWeb Safari

https://github.com/Expensify/App/assets/23176449/6d4f87a2-8590-4f64-9dc1-d8c90d09491b

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/23176449/a133e6cd-3e98-4f8d-92ee-ab03836da575

MacOS: Desktop

https://github.com/Expensify/App/assets/23176449/b875ab22-0a9b-4f67-b597-2c1bfd81d816

Note: android recording will be added as soon as the issue on the main branch will be resolved

@blazejkustra Thank you! Updated!

@sobitneupane kind bump 🙂

Sorry for the delay @VickyStash. I will review the PR tomorrow morning(NPT).

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.22-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.22-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Change docker tag

Instead of latest-dockerize, should be dockerize-latest as more intuitive.

Implemented


Add integration test cases - Closes #887

What was the problem?
This PR resolves #887
How was it solved?

[x] Add integration tests for following endpoint:

[x] /api/v2/transactions/export (http + rpc)
[x] /api/v2/exports/:filename (http)

[x] Add http-exports in namespaces.js to enable get.transactioins,export
[x] Fix swagger for endpoint api/v2/exports/{filename}

How was it tested?
Local + Jenkins

@nagdahimanshu Also, please ensure to add a few more test cases to cover the following conditions, both positive & negative scenarios:
	validParamPairings: [
		['address'],
		['publicKey'],
		['address', 'interval'],
		['publicKey', 'interval'],
	]


Improved cut analysis

Original report by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

This should result in a few functions added in either TESGroup, Dataset, or cuts.

A command to show results on all or a subset of cuts for a given pulse or set of pulses in human readable form. Have this command called by default when plotting traces.

Cutstats command would do something useful, im not exactly sure what yet.
a. Show total cuts by cut type in human readable format
b. Show/return a cut matrix, so diagonals would show how many pulses were cut by this cut only, off diagonals would show how many pulses were cut by this cut and another cut... i guess we could go to n-d but 2d will be easier to understand and might be enough info.  I think the diagonals will be the most useful.

Thoughts on where to implement these are welcome.

Original comment by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

ds.cut_summary() does this

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

I made your issue report more readable, but I think you're going to have to do the legwork.  Only you know what you mean!


Add functional option to circuit_key primitives util

Summary
Adds optional kwarg to request a purely functional key from the circuit_key primitives utility. This is necessary to avoid recomputation on circuits which are functionally equivalent but vary in non-functional data (e.g. name, id).
Details and comments
Default behavior is set to False (i.e. default key is not purely functional) this decision has been made for compatibility with the previous implementation, but I think setting the default to True would be preferred.
EDIT: default behavior set to True after discussion (see below).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 84.398%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/primitives/utils.py
4
5
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
59278

Relevant Lines:
70236

💛  - Coveralls

id was kept in the previous PR #8604 because I heard from @ikkoham that @jyu00 and @ikkoham had an agreement to make a composite key in addition to id. https://github.com/Qiskit/qiskit-terra/pull/8604#issuecomment-1247529117
If they agree to remove id and name, I'm fine to remove them. It makes the function simpler.

Yeah we talked about using id and len(data), but this is much better. I agree with removing id. In fact do we even have a use case for specifying functional=False?

Thank you, Jessie. We can simplify the code by removing id and name. Let's go for it.

IMO, I like to stay on the safe side for these rare cases, in which circuits have different  id and name but same functionality. As Imamichi-san indicated in the previous PR, collisions are occurring in the corner cases. There are probably collisions that we are not aware and id and name might help.
It is a preference which way to fall on the tradeoff between efficiency and safety, so let's take the efficiency side in this case.
I believe it is unlikely in normal use and let's hope no bug reports come in 🤞

Okay, let's do the following then:

We add the functional kwarg to allow @ikkoham to include non-functional data when needed.
We default to functional=True since this seems to be the best approach to avoid recomputation.
We add name to the non-functional key to better handle corner cases.
We get rid of id since it may cause conflicts when running different interpreters (e.g. client and server), and when running a single interpreter it stands in it of itself as a unique key: hence making all other values inconsequential in that case.

The PR should now be ready to merge 😉

Since this PR is not a new feature, but a follow-up of #8604 to improve efficiency, I would put it in at 0.22.


How to get raw text

Redirection to file gives output with styles
bard-cli "hello" >> bard.txt

Gives

^[[38;5;252m^[[0m^[[38;5;252m^[[0m  ^[[38;5;252mHello! How can I help you^[[0m^[[38;5;252m today?^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m^[[38;5;252m ^[[0m

How to get the raw files?

yep getting this fixed in the next release. the interactive mode will also have a component to write the previous answer into a file

fixed in a4f3b384ffccd34c75e5b1d9ad99c18384518a66


NIFI-11866 Update mvel2 to 2.5.0.Final

Summary
NIFI-11866
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

This succeeded in the local branch


Add standard interfaces like Disposable as Mixins in the Dart SDK

One of the the great features of OO languages is polymorphism based on known interfaces.
Unfortunately, Dart has neglected to define interfaces that are standard in other SDKs. This makes it impossible to write generic libraries without casting objects to dynamic and try to call a method hoping it will be available, therefore hurting type safety.
The two most missed ones are probably

Disposable
Serializable

But I'm sure there might be some more. Thanks to mixins it should be possible to introduce such interfaces even today into existing classes of the Dart SDK, Flutter and all packages where it makes sense and improve the situation.
cc @FMorschel

Just to point out the relation to issues like:

https://github.com/flutter/flutter/issues/149466
https://github.com/flutter/flutter/issues/137435

as an addition this was my original issue on Listenable that was closed unfortunately
https://github.com/dart-lang/sdk/issues/55816

For Flutter types specifically, https://github.com/flutter/flutter/issues/149466 is the new issue to track

Possible duplicate of #43490

I'll refer to #43490 for a disposable interface.
For Serializable as an interface, I have opinions.

Being serializable isdefinitely an opt-in feature, so an interface would make sense.
When people say "serialization" they often mean toJson, which is a horrible serialization format.

And they actually mean "return a map" which is a horribly inefficient way to generate a serialized JSON string.

An interface doesn't support deserialization, because that's a static function (otherwise you'd need an object to create an object), so it's serialization only.
It's very, very hard to make an serialization format that is optimal for everybody.

"JSON" is not a serialization format. For example, it doesn't support cyclic structures.
You need an interpretation on top.

So we can try to abstract over the format.
It's hard to make a serialization API that supports all the possible serialization formats that people would want to use.
Anything hard-coded into the SDK is likely to become insufficient in the future, maybe beacuse more language features are added, that also need to be serialized, and maybe just because it fails to support the favorite format-of-the-day.

I don't see a platform library provided serialization abstraction as a good choice. If it's not sufficient for anything in practice, it's a waste of code. If it's over-engineered (which is easy if you want to be sufficient for everything), then people will eventually choose a simpler version that matches their needs. Even if it gets just one thing wrong, you'll be better off using a different serialization approach.
And then the platform libraries are stuck with their original implementation, because there will always be some small amount of code that uses it, just because it's there.

@lrhn But reality is that we have throughout the Flutter SDK objects that already have a dispose() function.  And your extension method above still won't let me check if a type offers an dispose function so I have won nothing.
In relation to the Serializable I agree to you points but then make it a Mappable or JsonReady or what else interface that contains the toJson method. As we don't have reflection we need some safe way to know if expected functions exist

Throwing out one additional serialization format for your consideration here which is CBOR (Concise Binary Object Representation).
It has the following nice properties that might make it interesting:

Stable IETF standard format https://www.rfc-editor.org/rfc/rfc8949.html
Explicit goal of extremely small code size and fairly small message size
The underlying data model is an extended version of the JSON data model
The format is designed for decades of use.
Able to unambiguously encode most common data formats used in Internet standards
No data schemas required (i.e like JSON rather than Protobuf)
JSON interop
It’s extensible in that CBOR defines tags as a mechanism to identify data that warrants additional information beyond the basic data model. Both future RFCs and third parties can define tags, so innovation is “permissionless” but can still be coordinated.


[BUG] Popup Menu children

If you create a scene and make the first node a popup menu and move the menu before adding children, It will automatically click the popup menu when you try to click on the children of the node.
In godot stable 1.1

I tested this with the current development master branch (aad2bbdb6fb7c8217d7e75480b38e45f00cb3abd) and I wasn't able to click on the child node.  It did nothing.  I could click on the parent popup menu node however.
If you reverse it and have a button node as the root and then add a popup menu as the child, I wasn't able to select or move the popup menu.


Add more info on splitChunks.{cacheGroup}.test

explain [\\/] in examples
more info about what is available in test callback and how to get it

@montogeek updated the PR with the suggested change, build is green but it seems Travis can't send update to GitHub for some reason

All right i'll merge as is since author doesnt have time to address, and do a follow-up pr

Thanks!


Quick Introduction Feedback

I don't have a lot of go experience so I may offer a different perspective on the documentation than those that have worked with go for some time now.
Here are the notes I've taken up to "Create your first Entity" where I decided to call it a night after getting stuck.  I hope this can assist in augmenting the documentation for others.
notes

Hey @jjr2527 and thanks for the feedback! The best way to discuss about documentation improvement is by suggesting a specific change using a PR.
I'd be happy to see it get better (and more user friendly), because I'm the one who created these docs (took me ages btw).
Closing, but like I mentioned above, if you have specific change that you think can help others in the future, propose it using a PR and we can discuss about it! Thanks 😃


Add details about proxy support

Documentations mentions that outgoing access to port <IP_ADDRESS> and <IP_ADDRESS> port 443 is required.
But no recommendations as to what can be done for servers that have no direct access to Internet.
Is proxy supported and if yes - how to configure it?
When installing agent using "Remediate" in ASC recommendations section there is no way to specify proxy.
Qualys agent itself does support proxy and it can be defined in few places https://qualysguard.qg2.apps.qualys.com/portal-help/en/ca/agents/linux_proxy.htm and confirmed to work on a test VM with this extension installed - I can see in log that Qualys agent used proxy and is able to establish connection successfully.
However, extension management scripts ignore this proxy setting and fail to connect to Qualys servers. As result, extension will end up showing as "Failed".
Based on source code of extension management scripts (avme_common.sh) it does support proxy but it should be defined in a way that Azure does not overwrite it when it applies desired state configuration to this extension.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 747a2c52-c59c-dedc-9c72-6b6352ea2cab
Version Independent ID: 07e64d3e-26da-be39-de53-6e259c90545f
Content: Built-in vulnerability scanner in Azure Security Center
Content Source: articles/security-center/built-in-vulnerability-assessment.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@dc-isafonov Thank you for sharing your thoughts on this. We are engaging the content authors in order to improve the documentation as needed.
Thank you.

Hi @dc-isafonov, thanks for taking the time to leave your questions here.
The short answer is that proxy configuration is currently not supported for the Azure Security Center vulnerability assessment extension (powered by Qualys).
If and when this option is added, the page will be updated to include it.
Thanks again and feel free to comment here or open new issues when you have unanswered questions.
#please-close


Fix error in README

Hey Jeremy, long time watcher of your videos and a huge fan of the new live coding content, had to check out the repo after your latest video and just noticed a stray character in the README.
I also have a linter enabled for README files so it made some other formatting changes as well, happy to revert them and just fix the error if you'd like.
Cheers,
Riley from Australia :)

@Hoody91 Cool, thanks. Just merged. All good. Thanks!


Harden backup-utils for Cluster

Summary
The preflight checks from backup-utils v.312.0 onwards will better support customers using our cluster topology. These checks will improve the performance of backup-utils by performing the following checks:

Verify that all remote file systems are not read-only, and highlight the nodes that are not writable.
Log an error message from ghe-cluster-host-check for each cluster node that is offline, so that customers know which nodes to fix before starting to generate a backup.
On High Availability setups, backup-utils will now write the temporary .sync_in_progress lock file (which should pause network maintenance globally) to both the primary and replica nodes during backups.

🚢 This has shipped with GHES 3.12<EMAIL_ADDRESS>


organize and publish a better documentation

A first step would be to propose how to improve the documentation and where to publish it:

obviously caigo being a SDK, we should focus on the godoc first
we should propose a set of separated REAME-like to include the main subjects and feed them.

not managed for now. This issue is not properly documented


The value   -2 is not of type   SB-INT:INDEX when binding LENGTH

When trying to do a restart that sets a new variable value, every now and then entering the new value doesn't appear to do anything. Hitting return again prints the message,
"The value   -2 is not of type   SB-INT:INDEX when binding LENGTH"
The value is not always -2.

This is an issue with SBCL on Windows, nothing I can do about it.


Support for svd2rust v0.12.x

Is support of a new way of interacting with peripherals (using new svd2rust) planned?

Yes, of course. I was working on this during impl days, and I already have patches for svd2rust, but I'm still updating msp430-rt. I should finish in one or two days.

I still working on this, it took me longer than I thought, sorry.

@Yarikx @pftbest This can be closed as soon as v0.2.0 is published, assuming svd2rust v0.17.0 is a superset of v0.12.x. Do you object if I publish it now (msp430 and msp430-rt have already been published)?

Published v0.2.0, thanks!


859 buddy strings

Pull Request Template
What have you Changed(must)
Added solution to 859 buddy strings in C++
Write here what you have changed in the codebase
added file in the C++ folder
Issue no.(must) - #1140
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

@SSKale1 @Yashica7 @swaingotnochill @JOKUE2002 feel free to merge and check it.


Connecting wrapper component to redux store with shallow

Hi! I trying to use enzyme with redux and react-apollo 2. So I have one pretty simple problem, but have no idea how to fix it. I have 1 connected to redux store component and all works fine with this code:
import React from 'react'
import { shallow } from 'enzyme'
import configureStore from 'redux-mock-store'
import { MainRoute } from './..'

describe('MainRoute renders without crashing', () => {
  const initialState = { questions: [] }
  const mockStore = configureStore()
  let store
  let container

  beforeEach(() => {
    store = mockStore(initialState)
    container = shallow(<MainRoute store={store} />)
  })

  it('render the connected(MainRoute) component', () => {
    expect(container.length).toEqual(1)
  })

  it('check Prop matches with initialState', () => {
    expect(container.prop('questions')).toEqual(initialState.questions)
  })
})

I can pass store to this component and verify passed state. But when I use Apollo 2 (they removed redux integration in 2.x) I need wrap my component like this :
  beforeEach(() => {
    store = mockStore(initialState)
    container = shallow(
      <ApolloProvider client={client}>
        <MainRoute  store={store} />
      </ApolloProvider>,
    )
  })

And aftert this changes store is not connected to my component. How I can connect wrapped componet with shallow ?

You may want to look into .dive().

@ljharb, thanks for very fast response! I tried to use dive() like container.find(MainRoute).dive().prop('questions')  but got error (with wrapped to ApolloProvider component) :
    Invariant Violation: Could not find "client" in the context of "Apollo(Conn
ect(WithFeatureFlags))". Wrap the root component in an <ApolloProvider>

Probably I still missed something?

Instead of .find, I mean container.dive().dive() - one .dive per HOC/provider.

If I use container.dive(MainRoute).prop('questions') - props is undefinied
If I use container.dive(MainRoute).dive().prop('questions') and all other variations like container.dive().dive(MainRoute).prop('questions') - I get error as on example above
Invariant Violation: Could not find "client" in the context of "Apollo(Connect(WithFeatureFlags))". Wrap the root component in an <ApolloProvider>

It seems that I am completely confused

.dive takes no arguments.
OK, so let's step through this one by one. What is container? What is container.debug()?

container.debug() is
    <QueryRecyclerProvider>
      <Apollo(Connect(WithFeatureFlags)) store={{...}} />
    </QueryRecyclerProvider>

container.dive().debug():
  <Apollo(Connect(WithFeatureFlags)) store={{...}} />

After 1 more dive I see error as in previous examples

So, since one dive is "Apollo wrapping Connect wrapping WithFeatureFlags", container.dive().dive().debug() should be just "Connect wrapping WithFeatureFlags", and container.dive().dive().dive().debug() should be just WithFeatureFlags?

@ljharb, Yep you're right, but container.dive().dive().debug() throw exception about <ApolloProvider> from above. I think I need to try use mount for my case, but still hope that I can use shallow here

I'm not familiar with Apollo or ApolloProvider; however at this point I'd say it depends on how ApolloProvider is implemented.
I'm assuming here that you're using ApolloProvider in all these dive tests - it's definitely required. Can you confirm that?

Yep, my component is not working without ApolloProvide, so I going to ask Apollo team how to properly mock their components. Thanks for help in investigation, I think you can close this ticket


VRAM is not freed on errors

When using musicgen the process completes and all files are created, but I have blocked network traffic out and this causes an error. If you enable multi band after this, there is a chance that there will not be enough vram for it.
Not sure this is intended behavior since there seems to be a delayed cleanup between runs.
This error does not effect the outputs but it also puts the GPU in a state where VRAM is not freed, forcing a restart.
This is not the only error that puts the GPU in this state. It appears that pretty much any error, including but not limited to;
torch.cuda.OutOfMemoryError and errors when trying to download models puts the GPU in this state.

Thanks for the tip, the models should definitely free memory on failure. I
think some of them would free it on next load, but that's not ideal.
As for the issue itself, do you see any error messages in the console? I
don't think musicgen should be doing telemetry and I have disabled Gradio
telemetry. (By the way I have almost no idea what people are actually
using.)
On Thu, Apr 11, 2024, 8:48 AM rofoto @.***> wrote:

When using musicgen the process completes and all files are created, but I
have blocked network traffic out and this causes an error when ( i assume )
musicgen tries to send out telemetry.
This error does not effect the outputs but it also puts the GPU in a state
where VRAM is not freed, forcing a restart.
This is not the only error that puts the GPU in this state. It appears
that pretty much any error, including but not limited to;
torch.cuda.OutOfMemoryError and errors when trying to download models puts
the GPU in this state.
—
Reply to this email directly, view it on GitHub
https://github.com/rsxdalv/tts-generation-webui/issues/303, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTRXI2F7QKQBFO7GKNVSJLY4XFTHAVCNFSM6AAAAABGBKBVEKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTMNRRGAYTMNI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

this is the only other error I am seeing
"tts-6.0_webui\installer_files\env\lib\asyncio\proactor_events.py", line 165, in _call_connection_lost
    self._sock.shutdown(socket.SHUT_RDWR)
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host.

That's why I thought telemetry was the potential issue.

I think some of them would free it on next load, but that's not ideal.
After looking, it would appear that in some situations the vram is freed on the next run but ideally it can be cleared at the end of generation, just in case.

That error is because you still have a frontend and a server. This is
generally from gradio. Although it's not impossible that this could from
telemetry at some point, it's a different situation.
On Fri, Apr 12, 2024, 2:59 PM rofoto @.***> wrote:

this is the only other error I am seeing
"tts-6.0_webui\installer_files\env\lib\asyncio\proactor_events.py", line 165, in _call_connection_lost
self._sock.shutdown(socket.SHUT_RDWR)
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host.
That's why I thought telemetry was the potential issue.
I think some of them would free it on next load, but that's not ideal.
After looking, it would appear that in some situations the vram is freed
on the next run but ideally it can be cleared at the end of generation,
just in case.
—
Reply to this email directly, view it on GitHub
https://github.com/rsxdalv/tts-generation-webui/issues/303#issuecomment-2051035154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTRXI2VIKMSGVOLN36M7OTY45Z43AVCNFSM6AAAAABGBKBVEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGAZTKMJVGQ
.
You are receiving this because you commented.Message ID:
@.***>


feat: Implementation of Friend Pairing problem. Dynamic Programming

Detailed Description

Context

Possible Implementation

There is one problem of dynamic programming problem that each friend can go to some party single or pairing with another friend. Find the number of Ways N friends can go to party. Should I add the implementation in Dynamic Programming module.

Thank you for your interest in contributing. 👍
Before submitting a PR, please ensure the following:

The algorithm isn't a duplicate in this repository.
Make your code as per the repository standards.
Ensure that all the automated-tests pass.

Thank You.


What is the point of provide Model class as a second agruement of @persist?

In the example:
class SomeItem {
    @persist @observable  name = 'some'
    @persist @observable count = 0
}

class SomeStore {
    @persist('object') @observable         obj = { a: 1, b: 2 }
    ...
    @persist('object', SomeItem) @observable s = new SomeItem
    ...
}

What is the gain of create SomeItem class then pass it as a Model?
I try to create an empty model class to test and everything is still working :/. Did I miss something?
class Todo {}

class TodoList {
    @persist('list', Todo) @observable todos = [];
    ...
}

class SomeItem {
   @persist somethingNeedPersist = 'haha'
   somethingNeedntPersist = 'heihei'
}


Monitoring - Metrics for workload/pod/container are missing

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

run Rancher v2.2.2-rc9 container single installed
add a DO cluster with 3 nodes (1 etcd, 1 control plane, 1 worker)
enable cluster monitoring
deploy some workloads in the default project
go to check the metrics in the workload/pod/container page

Result:

The Grafana link works and we can see relevant statistics in the Grafana page
we expected to see the metrics for workload/pod/container

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.2.2-rc9
Installation option (single install/HA):
single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

Here is another scenario
In v2.2.1

as the admin, enable the cluster monitoring
deploy some workloads in the project p1
see the metrics for workload/container/pod
see Grafana icon

upgrade to v2.2.2-rc9

the metrics for workload/container/pod is missing
still can see the Grafana icon

Can be tested with rc10

The bug fix is validated with the following two test cases
Case 1

run Rancher v2.2.2-rc10 single install
add a DO cluster
as the admin, enable the cluster monitoring
deploy some workloads in the project p1
confirm that the metrics for workloads/pods/containers show up
log in as different roles to confirm that the RBAC around the metrics works as expected

Case 2

run Rancher v2.2.1 single install
as the admin, enable the cluster monitoring
deploy some workloads in the project p1
see the metrics for workload/container/pod
upgrade to v2.2.2-rc9
confirm that the metrics for workloads/pods/containers still show up


Playglobalsound fix

About the PR

Added a workaround to display server-side autocompletion hint for playglobalsound command which utilizes attributions.yml file
Fixed some of the "valid but not really" files fields in several attributions.yml across the project
Why / Balance

Eh idk it stopped working
Technical details

Main idea was to read yaml filed in SequenceDataNode, think I would need a [DataDefinition]s for that but it simply didn't work out for me cuz I'm newb
Loop populates another list in a try\catch then concats original ContentFilePath read with looped one if project is being compiled in release mode
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Fixed playglobalsound autocompletion

Manually parsing licensing of files (of which most audio doesn't even use yet so will skip most things) is really bad and will just break frequently (hence why you're just using a try-catch and dumping exceptions).
Just use the metadata prototypes.

Any hint on where it's utilized in the codebase?

AudioSystem, just lookup audiometadata in your IDE.

I ended up doing this.


Allow mocking of Win32 calls that take 9 and 13 arguments

Previous max was functionally 6; Fixed macros for 7 and 8, and added macros for 9 and 13 args. (10-12 argument function support not implemented).
Also added the REAL_MODULE_FUNC() macro. It's similar to INVOKE_REAL_MODULE_FUNC(...), but lets you reference the function instead of call it. That enables doing something like
ON_MODULE_FUNC_CALL(CreateEventW, _, _, _, _).WillByDefault(REAL_MODULE_FUNC(CreateEventW));

Nice, thanks, could you also add a description of the REAL_MODULE_FUNC macro to the README.md?


upgrade openldap-server

[ ] not sure how to upgrade olcAccess: (in config.ldif.j2)

olcAccess: to dn.children="{{ openldap_std_user_dn }}"
by dn.base="{{ openldap_writer_dn }}" write
by dn.base="{{ openldap_superuser_dn }}" write
by dn.base="{{ openldap_readonly_user_dn }}" read
by * none
should be replaced by
olcAccess: to dn.subtree="{{ openldap_std_user_dn }}"
by dn.base="{{ openldap_writer_dn }}" write
by dn.base="{{ openldap_superuser_dn }}" write
by dn.base="{{ openldap_readonly_user_dn }}" read
by * none
How to do it in upgrade file(s)?
dn: olcDatabase=bdb,cn=config
changetype: modify
delete: olcAccess ...
in one file

add: olcAccess ...
in another file

or
dn: olcDatabase=bdb,cn=config
changetype: modify
replace: olcAccess
olcAccess: to dn.subtree="{{ openldap_std_user_dn }}"
by dn.base="{{ openldap_writer_dn }}" write
by dn.base="{{ openldap_superuser_dn }}" write
by dn.base="{{ openldap_readonly_user_dn }}" read
by * none
or do I need to delete/add resp. replace all olcAccess entries of the database?
When trying, I got several times the error "ldap_sasl_interactive_bind_s: Can't contact LDAP server (-1)" and the slapd task on port 389 had disappeared

[ ] upgrade files with subversion are ignored:

TASK [common : debug] ***********************************************************************************************************************************************************************
ok: [fworch-srv] => {
"msg": [
"installed_version: 5.2.8",
"current_version: 5.2.9",
"all_upgrades_available: /home/achim/firewall-orchestrator/roles/common/tasks/upgrade/5.1.17.yml"
]
}
...
TASK [openldap-server : set list of relevant upgrade files (without extension)] *************************************************************************************************************
skipping: [fworch-srv] => (item=/home/achim/firewall-orchestrator/roles/openldap-server/files/../templates/upgrade/5.1.ldif.j2)
skipping: [fworch-srv] => (item=/home/achim/firewall-orchestrator/roles/openldap-server/files/../templates/upgrade/<IP_ADDRESS>.ldif.j2)
skipping: [fworch-srv] => (item=/home/achim/firewall-orchestrator/roles/openldap-server/files/../templates/upgrade/<IP_ADDRESS>.ldif.j2)

The first task is in my fork


moto 1.3.14 breaks boto3 access (again)

I believe this might be a reemergence of a past bug (https://github.com/spulec/moto/issues/2172).
The following code has two duplicate functions, but the second has a mock_ec2 decorator. Expected behavior would be establishing a mock ec2 client object only when using the function with the decorator, but the behavior is that it also impacts the session object (which is intended to use an instance profile).
The instance id used in both is an existing instance in my account at the time of the call. The mocked environment making the call to the EC2 instance should fail. It should be the only thing that fails.
#!/usr/bin/env python3

import boto3
from moto import mock_ec2
from pprint import pprint

def first_try():
    session = boto3.session.Session(region_name='us-east-1')
    pprint(f"first session = {session}")

    sts_client = session.client('sts')
    pprint(f"first caller identity = {sts_client.get_caller_identity()}")

    ec2_resource = session.resource('ec2')
    pprint(f"first image = {ec2_resource.images.filter(ImageIds=['ami-0591128407d57f32c'])}")

@mock_ec2
def second_try():
    session = boto3.session.Session(region_name='us-east-1')
    pprint(f"second session = {session}")

    sts_client = session.client('sts')
    pprint(f"second caller identity = {sts_client.get_caller_identity()}")

    ec2_resource = session.resource('ec2')
    pprint(f"second image = {ec2_resource.images.filter(ImageIds=['ami-0591128407d57f32c'])}")

if __name__ == "__main__":
    first_try()
    print('-' * 10)
    second_try()

$ ./example_code.py
"first session = Session(region_name='us-east-1')"
("first caller identity = {'UserId': 'XXXXXXXXXXXXXXXXXXXXX', 'Account': "
 "'XXXXXXXXXXXX', 'Arn': 'arn:aws:iam::XXXXXXXXXXXX:user/me', "
 "'ResponseMetadata': {'RequestId': 'e435dabd-9abe-40e5-8a7c-0fe2928142be', "
 "'HTTPStatusCode': 200, 'HTTPHeaders': {'x-amzn-requestid': "
 "'e435dabd-9abe-40e5-8a7c-0fe2928142be', 'content-type': 'text/xml', "
 "'content-length': '406', 'date': 'Thu, 16 Jul 2020 14:11:49 GMT'}, "
 "'RetryAttempts': 0}}")
'first image = ec2.imagesCollection(ec2.ServiceResource(), ec2.Image)'
----------
"second session = Session(region_name='us-east-1')"
Traceback (most recent call last):
  File "./example_code.py", line 32, in <module>
    second_try()
  File "/usr/local/lib/python3.8/site-packages/moto/core/models.py", line 88, in wrapper
    result = func(*args, **kwargs)
  File "./example_code.py", line 23, in second_try
    pprint(f"second caller identity = {sts_client.get_caller_identity()}")
  File "/usr/local/lib/python3.8/site-packages/botocore/client.py", line 316, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python3.8/site-packages/botocore/client.py", line 635, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the GetCallerIdentity operation: The security token included in the request is invalid.

Installed via pip3:
moto==1.3.14
boto3==1.14.13
botocore==1.17.13

Using the Python mocks (not server).
Is this expected behavior? Should the explicit use of a mock for a specific resource impact outside that resource scope?

Hi @snimark, that is the expected behaviour, yes. Botocore does not support credential mocking on a client/service basis, so they can only be mocked on a system level. So the moment you use any of the decorators, all boto-calls will use mocked credentials.
There is a workaround to un-mock the credentials, as described here: #3111.
Another workaround would be to manually start/stop mocking specific services:
`
def test_stuff():
do things with AWS sqs
mock = mock_ec2()
mock.start()
do things with mocked ec2
mock.stop()
do other things against AWS sqs
`
Hopefully that's helpful for your usecase?

Thanks for the reply. I will see about implementing this model of cherry picking the resources to mock in our tests.


Web Improvements

This issue is to coordinate the planning of possible enhancements to WLED HTML, js and CSS environment.  These issues are not bugs, but rather changes that can improve the development workflow going forward in my opinion.
We have to take into consideration the differences between an ESP8266 or ESP32 web server vs regular internet facing web sites. Final solutions have to take into consideration the limits of running a web server on ESP8266 or ESP32.
Current Concerns
Javascript inlined in web pages

would be nice to be able to run jslint
...

CSS is inline in web pages

would be nice to be able to run csslint
...

Some pages inject generated javascript via web server

easy to implement, but tightly couples to the web server implementation
makes it harder to decouple the UI from the WLED instance - ie, you dont need have UI served off the microcontroller, only expose the API from to get or update state

Hello,
I did my tests. With the current script (inliner) it is possible to turn the wled web page to a single HTML file with everything inlined.
You can test it out here.
As you can see in the screenshot these changes don't make more requests:

The script automatically injects the code from the extracted files here:

and here:

These changes makes it much easier to edit and work with the code. Also we don't have to do any extra steps while developing. We still only have to use the npm run build build command.

I wonder if that could be extended to vendoring iro.js and rangetouch.js as files as well? Not a huge concern but maybe an even more readability win.

Should be possible. I will have a look on it

I did it: https://github.com/WoodyLetsCode/WLED/tree/web-final


Please allow Javascript 'eval' functionality

I understand that 'eval' is disabled due to security concern.
However, please consider allowing the developer to decide if he/she wants to enable eval.
'Eval' is very useful in many NodeJS applications. I suggest perhaps just displaying a warning to developers who want to use eval instead of completely blocking the feature.

For the production environment enabling eval, even optionally, runs the risk of security issues for the entire platform and not just the one worker. For local dev using workerd only, we do now have the UnsafeEval binding type that you can use (e.g. env.unsafe.eval('...') and env.unsafe.newFunction(...). There's a sample worker that shows how to use it.


Portfolio list sections for mobile version

General requirements

Make sure the content of the "About myself" section is aligned with flexbox.
In order to lay out the elements in "Works" section you should use CSS Grid and Flexbox combined. Use CSS Grid in the main container that contains all of the cards and use Flexbox to lay out an individual card.
Please use ul and li for categories in "Work" section. Html, Css, and Javascript should be list items.
Please use ul and li for categories in "About myself" section. Languages, Frameworks, and Skills should be list items.
You don't need to implement the detail modal window that requires JavaScript.
You must stick to the design as much as possible (e.g., font, colors, images, text, margins).
Implement the button interactions (enable, hover, etc.).

Thank


chore: center the docs links

🤷♂

What:

Why:

How:

Checklist:

[ ] Documentation
[ ] Tests
[ ] Ready to be merged

[ ] Added myself to contributors table

Any reason why this has to be removed from the README file? Now you can't refer to the docs while  not having internet e.g. on the airplane :(

It's hard to keep in sync in two places - the rtl and dtl docs are already out of sync
You can pull down the repo for the docs if you'd like - it's all markdown

We should see what it would take to get the docs on https://devdocs.io and https://kapeli.com/dash and I wonder how hard it would be to make a service worker for the website 🤔

https://docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2
Maybe in Docusaurus 2.0
Opening this discussion on the docs repo

Never meant to sound negative just wanted to raise an accessibility issue 😇
Trying to synchronise both projects using the Dino definitely makes totally sense :)


fix: phone Number validate

Purpose of the pull request
、
issue：https://github.com/apache/dolphinscheduler/issues/14603
Brief change log

Modify the mobile phone number verification rules to support mobile phone numbers starting with 19
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

the second number can be 6

will wait all ohter ready to merge pr close and trigger this pr's CI

Codecov Report

Merging #14604 (39fbee9) into dev (3d033da) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 39fbee9 differs from pull request most recent head 996e1a6. Consider uploading reports for the commit 996e1a6 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14604      +/-   ##
============================================
- Coverage     38.47%   38.46%   -0.01%
+ Complexity     4559     4558       -1
============================================
  Files          1260     1260
  Lines         43747    43747
  Branches       4803     4803
============================================
- Hits          16832    16829       -3
  Misses        25045    25045
- Partials       1870     1873       +3

see 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Lazy param and type qualifier features

Thanks for your proposal. Not sure about what is your intent here.

Annotate a constructor parameter or function parameter, to ask resolution as "injected parameter"

There is already the @InjectedParam to use when you need an injected parameter.

I've added Lazy type detection in e789d5b748161b5fd7979561eb51c29337d812a8
Thanks for your proposal

My intent was to indicate the dependency will be injected like inject(), not like get()

I've added Lazy type detection in e789d5b748161b5fd7979561eb51c29337d812a8
Thanks for your proposal

Thanks for this feature! But my PR was not about just Lazy type detection, but also type qualifiers. Instead of using strings KClass<*> can be used in @Named annotations. Plus lazy type injection can run with this. It seems type qualifiers turned into a feature request that you closed the pr :)


HTTPError in middleware results in AttributeError when parsing body

Hi,
I am getting the following error when I try to access certain routes in my application:
self = <falcon.api.API object at 0x10d227758>, resp = <falcon.response.Response object at 0x10d227f50>
wsgi_file_wrapper = None

    def _get_body(self, resp, wsgi_file_wrapper=None):
        body = resp.body
        if body is not None:
            if not isinstance(body, bytes):
>               body = body.encode('utf-8')
E               AttributeError: 'dict' object has no attribute 'encode'

venv/lib/python2.7/site-packages/falcon/api.py:647: AttributeError

I use a middleware (jhildreth/falcon-jwt-checker to validate and decode JWTs, and the error is raised every time the middleware raises an HTTPUnauthorized error.
I spent some time with the debugger and found out that during the exception handling, the error from the middleware is converted into a suitable representation and put into resp.body as a dict like this:
body = {'description': 'Please provide a valid auth token.', 'title': 'Authentication Required'}

This breakes _get_body which doesn't expect a dict. I am super confused by this, because from my research so far raising an error is actually the expected behavior of a middleware.
Is this a weird edge case, a bug or an error on my part?

Sorry about taking so long in responding to this issue. I personally haven't run into this issue before. However it sounds like you're relying on a another middleware to convert your body dictionary as JSON. Out of the box, Falcon assumes the body is just string that can be encoded. So if you're not currently using a middleware to handle this, a simple json.dumps(...) should solve the problem.
We're currently trying to make this a little more straightforward for user. As a result, we do have a feature currently in review to add a media attribute to request and response which will accept an object and correctly handle the de/serialization. We're currently planning to have this included in Falcon 1.3.

I got this error when returning a Python object instead of a json dump of an object.

Hi @jdno and @bootrino !
Depending on the middleware order, things can indeed get complicated when different layers morph req.body along the way.
As @jmvrbanac mentioned, that was actually one of the major reasons behind unifying media handling.
I'm thus going to close this issue suggesting the revamped media handling as the preferred solution. It has been out in the wild for a while now :wink:
To be precise, using resp.media in lieu of resp.body should eliminate the ambiguity whether one is referring to the serialized version, or a raw response body (FWIW resp.body is now documented as of type string/bytestring, so setting it to a dict would be a somewhat loose interpretation of this attribute).


[Bug]: Combobox: highlighted element not scrolled into view when using v-model:selectedValue

Environment
Developement/Production OS: Windows 10 19043.1110
Node version: 16.0.0
Package manager<EMAIL_ADDRESS>Radix Vue version: 1.0.0
Vue version: 3.0.0
Nuxt version: 3.0.0
Nuxt mode: universal
Nuxt target: server
CSS framework<EMAIL_ADDRESS>Client OS: Windows 10 19043.1110
Browser: Chrome 90.0.4430.212

Link to minimal reproduction
https://stackblitz.com/edit/gbaaqa?file=src%2FApp.vue
Steps to reproduce

Assign a max height to the ComboboxContent component
Provide a controlled selectedValue, ie: model:selectedValue="selectedValue"
Start navigating the combobox results with down arrow keys

Describe the bug
When approaching the bottom of the combobox contents, and pressing down key, the highlighted element is no longer scrolled into view. The item is highlighted, but it's hidden "below the fold". If I manually scroll the list with my mouse, I can see the highlighted element.
Expected behavior
The highlighted element should always be scrolled into view.
Not sure what the root cause is, but it looks like deferring the scrollIntoView call here using nextTick fixes the issue:
  if (selectedElement.value instanceof Element)
    nextTick(() => selectedElement.value.scrollIntoView({ block: 'nearest' }))

Context & Screenshots (if applicable)

Also, probably related to this: even when not using a controlled selectedValue, then the following occurs:

Select a value that's below the fold, ie, not initially visible, but can be selected via keyboard as you move down (or scroll to the option using mouse)
Now that the value has been selected, press down arrow
The options menu opens, but the selected/highlighted element is not visible

Expected: the selected value should immediately be scrolled into view


fix minor typo in parameter

fixing a minor typo in a parameter name that keeps tripping me up

@TheBigBear technically not a typo, this behavior changed in one of the RCs and I just didn't update the docs. Thanks!


GH Pages deploy is not running

Looks like PRs are being merged against development instead of main.
pushing development commits to main should be enough.

I suggest tagging and deploy tags instead perhaps?

I agree, trunk should be enough to manage this build imho. For now I will create a PR to main and close this issue. Thank you.


Token filters - Normalization [DOC]

What do you want to do?

[ ] Request a change to existing documentation
[x] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Create a separate page for Token filter: Normalization
Part of META issue: https://github.com/opensearch-project/documentation-website/issues/1483
*Version: all

@vagimeli I can take this one


.save() is not inserting a new document

Hi,
Just trying out this awesome library and have gotten stuck on commit to the colleciton. if I use .save() then it is not inserting the new document. if i use insert_* then it is working fine.
There is no error being returned so it doesnt look like it is failing

Hi,
Could you provide the piece of code that does not work the way it's expected?

There was a scenario where the id can be assigned and the save many would try to update a document that does not exists. The default behavior will be to upsert in the version 2 that is being released now.


Nfts: Multiple approvals

Allows the item owner to make approvals to multiple accounts.
This feature is added to the pallet-nfts

Sure thing, will do the first thing tomorrow morning! Thanks for the contribution @Szegoo !

@jsidorenko Other than the formatting error that you fixed, is the other part of the code correct?

/cmd queue -c bench-bot $ pallet dev pallet_uniques

@jsidorenko Other than the formatting error that you fixed, is the other part of the code correct?

Sorry mate, I wasn't feeling well yesterday, will do a review shortly

@jsidorenko Other than the formatting error that you fixed, is the other part of the code correct?

Sorry mate, I wasn't feeling well yesterday, will do a review shortly

Sorry to hear that, take your time, I don't think this is that urgent :)

thanks :)

/cmd queue -c bench-bot $ pallet dev pallet_nfts

@Szegoo I've updated my js/uniques-v2-main-branch resolving the merge conflict, could you sync up with it?

@jsidorenko I synced this branch up, the CI checks are failing because the weights.rs file inside nfts needs to be updated. It seems like every [number] as Weight needs to be replaced with [number] as u64. This should be probably done in a separate PR.

Thanks, I'll update that in my branch. The new structure of weights was merged after I made a copy of the pallet, so I need to sync that now

@jsidorenko Is this PR waiting for an audit?

Since this PR points to the internal branch, I think we can merge it. If the auditors find smth - we could address this in a new PR

Pls post your polkadot address

Pls post your polkadot address

I have added my address, thanks!

/tip medium


Warnings on install

Thought you might want to know that installing the module produces some compilation warnings:
><EMAIL_ADDRESS>install /opt/apps/node_modules/diskusage
> node-gyp rebuild

make: Entering directory '/opt/apps/node_modules/diskusage/build'
  CXX(target) Release/obj.target/diskusage/src/main.o
  CXX(target) Release/obj.target/diskusage/src/diskusage_posix.o
../src/diskusage_posix.cpp: In function ‘DiskUsage GetDiskUsage(const char*)’:
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_bsize’ [-Wmissing-field-initializers]
     struct statvfs info = {};
                            ^
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_frsize’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_blocks’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_bfree’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_bavail’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_files’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_ffree’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_favail’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_fsid’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_flag’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::f_namemax’ [-Wmissing-field-initializers]
../src/diskusage_posix.cpp:10:28: warning: missing initializer for member ‘statvfs::__f_spare’ [-Wmissing-field-initializers]
  SOLINK_MODULE(target) Release/obj.target/diskusage.node
  COPY Release/diskusage.node
make: Leaving directory '/opt/apps/node_modules/diskusage/build'

Thanks for the report.
Could you please provide more information so I can attempt to reproduce the issue? I've just tried the install process on macOS, Debian and Ubuntu and couldn't see any compilation warnings.

What OS are you running?
What libc are you running?
What compiler and compiler version are you running?

Here are the details:
OS = Debian Jessie
Not sure exactly how to check for libc and compiler used. I have the build-essential package, so I guess they're glibc and gcc:
$ ldd --version
ldd (Debian GLIBC 2.19-18+deb8u10) 2.19

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.9/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 4.9.2-10' --with-bugurl=file:///usr/share/doc/gcc-4.9/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.9 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.9 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.9-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.9-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.9-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --with-arch-32=i586 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.9.2 (Debian 4.9.2-10)

Hope that's what you are looking for :)

Looks like you're running an old-ish version of GCC. Those specific warning messages are a bug in C++ prior to GCC 5.1.1. See this bug for more information.
Given they're just warnings, I'm happy to leave them as they are, rather than ignoring them in the build script.


Some questions about tutorial preprocessing step

Hi Dr. Cao, sorry to disturb you. I met some problems when I run the tutorials:

I found that normalize_total will yield errors based on updated scanpy. I wonder if I use: normalize_per_cell is also ok or not. Thanks a lot.

Thanks for the report! This is a known issue of scanpy 1.9.0 (scverse/scanpy#2210). You may try installing dask or upgrade to scanpy v1.9.1.

For the record, using normalize_per_cell is also okay, except that the function seems to be deprecated.


For merycorps/TolaActivity#2098, use unified change notice for success.

Closed because it needs to be merged to a different branch.