Remove duplicate test

Fixes #8

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2edc957). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   98.75%
=======================================
  Files           ?        1
  Lines           ?      161
  Branches        ?       71
=======================================
  Hits            ?      159
  Misses          ?        2
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for the review @shadowspawn!


Before Denali-Babel

So this line
  "denali": {
    "before": "denali-babel"
  }

Seems like it assumes too much, because if you wanted to use typescript, you wouldn't use babel, and then this addon is unusable. Maybe this should be a list of addons to check against, or a type of addon that babel and typescript fall under.
"before": {
  "type": "preprocessor",
  "category": "js"
}

needs some bikeshedding

Good point, hadn't thought of that.
I hesitate to add "types" or categories of addons. Getting the exhaustive list of types correct, and the boundaries between them, is difficult / impossible without lots of experience. Which means lots of potentially breaking API changes as we figure out "oh, we actually really need a js-preprocessor type and an asset-preprocessor type". And I'm not even sure there is an exhaustive list of types that satisfies all use cases. When faced with that kind of tradeoff, my gut says their's often a more fundamental primitive that could solve the problem.
As an alternative, we could support configuration at the app level to specify addon ordering, i.e.
// my-app/package.json
"denali": {
  "addons": {
    "denali-eslint": {
      "before": "denali-babel"
    }
  }
}

I think something like the above, where the consuming app can specify load order, would provide an escape valve - no matter what, you can always override the order. The downside here is it's more configuration for the end user. But we could ship addons like this one with some sensible defaults - i.e. "before": [ "denali-babel", "denali-typescript", "denali-flow" ]. I imagine there will only be a handful of commonly used addons that need explicit ordering like this, so maintaining that shouldn't be difficult, and there's no explicit guarantee that the load order is supported anyway. And the more esoteric use cases have the escape valve they need.
Thoughts?


[FIX][BE: PYTHON][ANCHOR] [Blog Dislikes] Delete Blog Dislike

User Story:
As a user, I want to be able to remove my dislike from a blog post so that I can manage my interactions and preferences on the platform.
Description:
Develop an endpoint that allows users to delete a dislike they previously added to a blog post. This feature enables users to adjust their engagement with content based on their changing opinions.
Purpose:
The purpose of this endpoint is to provide users with control over their dislikes, allowing them to update or revoke their feedback. This also helps maintain accurate engagement metrics for blog posts.
Requirements:

Authenticate the user to ensure they have the authorization to delete the dislike.
Verify that the dislike exists for the specific blog post and user.
Remove the dislike from the database upon request.
Ensure the endpoint returns a confirmation message upon successful deletion.

Acceptance Criteria:

The user must be authenticated to delete a dislike.
The endpoint checks that the dislike exists before attempting to delete it.
The dislike is successfully removed from the database if it exists.
A success message is returned to the user confirming the deletion.
Appropriate error messages are returned if the dislike does not exist or if there are issues with authentication.
-Unit and integration tests are implemented to cover various scenarios.

Expected Outcome:
Users can successfully delete their dislikes from blog posts, and the system accurately reflects these changes in the engagement metrics. The endpoint operates securely and efficiently, ensuring a seamless user experience.

Traderstechie is working on it


Gradient transform

This provides the Grad transform on graphs. Call Grad().process_graph(graph) to obtain the transformed graph.
Current state: Grad outputs something that looks sensible for all graphs I've tested, including closures and graphs with if/while loops. I also tried up to sixth order gradient on a while loop and it didn't crash, which is encouraging (sixth order takes 30 seconds, so I stopped there). However, I didn't run any of these graphs (can't, since the necessary operations are not implemented), so I don't know if they are indeed correct (the graphs can be a bit hard to read, unfortunately).

Progress report.
I've implemented backpropagators for a few primitives and if, ported the finite difference code from master, and added a zeros_like primitive. Then I ported several tests from master.
The good news is that the algorithm seems to be correct: correct gradients are obtained on simple arithmetic, if statements, closures and nested while loops. Worked on first try, too. There are, however, a few issues:

Using the current VM, zeros_like can't get the shape of a closure's gradient, because that involves fetching all closure variables, and some of them will cause Continue exceptions to be raised. I used a simple workaround: zeros_like(closure) generates the ZERO object, which has __add__ and __radd__ overriden to return the other argument, and __getitem__ to return ZERO. That seems to do the trick, but I used the same trick in master (though more as an optimization) and I recall it causing a few issues with higher order gradients. So I don't trust that solution very much. Might be worth looking into the Env idea.

Tuples are made via the make_tuple primitive, which takes a variable number of arguments. This means it's impossible to build a graph for J(make_tuple) (so I can't test second order right now). I can see the following solutions:

Add varargs support. An inference pass could try to eliminate them for optimization.
Special case make_tuple in the gradient pass.
Generate J(fn, n) where n is the number of arguments passed to the function. This would let J specialize on the number of arguments, in which case a graph could be generated for make_tuple with n arguments.
Replace make_tuple(a, b, c) by the composition of a binary function, for example cons(a, cons(b, cons(c, ()))).

For now I'm trying the last option: replacing make_tuple by the composition of cons_tuple calls. Seems to be working so far, just need to scaffold the tests for second order gradients to make sure everything's in order.

The functionality should be complete, and the tests pass, but there are still a few things I want to improve, like notation and documentation.
Note that this PR includes the modifications in #35, #45 and #46. You should review these before this one.

I'm closing this PR and making a new one.


Allow #[classattr] on associated constants

#[pymethods]
impl Foo {
    #[classattr]
    const MY_CONST: &'static str = "foobar";
}

Also I think the original #905 missed off a CHANGELOG entry, so can you add one here?
(Might want to wait to rebase on #915 to make life easier.)

Thank you!


New version: vim.vim version 9.0.1365

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@stephengillie

Hi @russellbanks and @chrisbra,
Packages must pass a Defender scan to be included in Winget's public manifests. Unfortunately, this error can't be waivered or manually validated.

@wingetbot run

there are already several new versions since 9.0.1365, so I particularly do not care for this version.
However, FWIW, I have seen to many false reports of anti-virus heuristic scans that claim bad behaviour, that I personally do not trust too much those anymore.
But just for the record, here is what virustotal thinks of it:

https://github.com/vim/vim-win32-installer/releases/download/v9.0.1365/gvim_9.0.1365_x86.exe
https://github.com/vim/vim-win32-installer/releases/download/v9.0.1365/gvim_9.0.1365_x64_signed.exe

Both report: "No security vendors flagged this URL as malicious"

I already send feedback here: https://github.com/microsoft/winget-pkgs/pull/98049#issuecomment-1464015087

Packages must pass a Defender scan to be included in Winget's public manifests. Unfortunately, this error can't be waivered or manually validated.

If there's no way to waiver this and new versions are passing fine, I'll close this as it's blocked until this specific version gets unflagged.

Close with reason: Blocked by Microsoft Defender SmartScreen;


[Enhancement] optimize analyze large partitions table FE oom

Why I'm doing:
when we create 35k partitions * 40 buckets table, and execute sample analzye.
we will get a sql like:
insert statistics......
select column_1, row_count, min, max from table
union all
select column_2, row_count, min, max from table
union all
select column_3, row_count, min, max from table

in PlanFragmentBuilder.visitPhysicalOlapScan, need compute scanRangeLocations for each table.
it's meanings need copy 35k * 40 * the num of tables tabletInfo...
update sample analyze sql to
insert statistics......
with xxx (select * from table)
select column_1, row_count, min, max from xxx
union all
select column_2, row_count, min, max from xxx
union all
select column_3, row_count, min, max from xxx

and force use cte reuse, let table process only once...
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@Merigify backport branch-3.3

@mergify backport branch-3.2 branch-3.3


liquidctl: 1.7.0 -> 1.7.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 130366 at 2c5f7fc7 run on x86_64-linux 1

2 packages built successfully:

liquidctl (python38Packages.liquidctl)
python39Packages.liquidctl


Add support for multiple test paths

Allow the form: python setup.py test --testCertainPath=test/python/WMCore_t/Algorithms_t/BasicAlgos_t.py, test/python/WMCore_t/Algorithms_t/MathAlgos_t.py
Needed for oracle tests where we will only test certain modules.
Currently passing in multiple paths gives errors.
Thoughts?

this is fixed


Stub handling for type check purposes

Feature request

I'm following up on this comment from a member of the Pylance team. As you can see from the screenshot below, Pylance doesn't recognize the Numba List type because it it isn't re-exported from numba.typed. It would be nice if the Numba types were automatically recognized by a type checker, so I'm asking if the stubs could be written in a way to make this possible.

Thanks for opening this request @abianco88. I took a look at the numba.typed module in question and now recall that the List and Dict re-exports are done under PEP-562. This "delayed" import was added in #6948 so as to prevent compilation from occurring at import time which obviously would slow down importing Numba.
I'm not sure with how type checking works with respect to PEP-562, but understanding that might help fix it. I suppose two immediate options are:

Redesign the typed container modules so as to push the delayed import further down the import chain so that type checking "just works".
Supply separate stubs.

This issue will be raised at the maintainer triage/public Numba meetings next week.


race condition between weave launch and the next command

The weave container process starts up asynchronously, so when weave launch returns, weave may not actually be ready to accept the next command.
This has been observed when the next command uses http, e.g. a weave status or weave connect. The symptom in this case is a silent exit with exitcode 7, which comes from the curl command when it cannot contact weave's http port.
One option would be to call weave status at the end of weave launch, looping a few times until we get an answer.  This would also give better error reporting in the case that weave launch has failed, e.g. due to an error in the command-line syntax.

I have implemented my suggestion in b256555 (on another branch)

Sadly that had a bug, fixed in https://github.com/bboreham/weave/commit/f19cf7db5


"Urzica" and "Stăvaru" are listed in the drop-down menu

Description:
When user writes ”Urzica” and "Stăvaru" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Urzica".

Expected results
The location is listed in the drop-down menu as "Sat Urzica OLT (Urzica)".

Step 2
Write in the search bar "Stăvaru".

Expected results
The location is listed in the drop-down menu as "Sat Stăvaru OLT (Urzica)".


A J: Watch full2info.com

A J requests the watch of the watch_keyword full2info\.com. See the Metasmoke search here and the Stack Exchange search here.

full2info\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Why should this be watched?

Coverage remained the same at 65.846% when pulling 4b8f3e56f515de23df2c588080964dd7bf382ead on auto-blacklist-1528693686.2023427 into 1f48698c58fd1d615928083a243e50273e08afb5 on master.

Need to watch this website. It appeared on M&TV, but it wasn't reported here.
https://chat.stackexchange.com/transcript/message/45086173#45086173

!!/approve

@tripleee This has appeared on M&TV, but it was not reported here. Link: https://movies.stackexchange.com/questions/89601/bad-movies-with-good-premises


Esplora blockchain scanner

Since esplora has now wrapped electrum rpc into WebSockets, we can create an esplora-based implementation of the blockchain scanner.

you can make JSONRPC calls via TCP directly actually

Closed by #33


Fix missing <unistd.h> header for sleep(3) definition

Clean up build warning:
src/calibrate.c: In function ‘Calibrate’:
src/calibrate.c:32:9: warning: implicit declaration of function ‘sleep’ [-Wimplicit-function-declaration]
32 |         sleep(1);

Thanks! running the tests

quick question what OS are you building on that shows this error? When we build in centos 7 I don't see this warning

I'm building this with debian breezy and sid.


The app fails to build for Android when Flutter upgraded to 3.0.

Describe the bug
I decided to upgrade Flutter to 3.0
The app doesn't build for Android.
Getting a few agora errors in the console i.e
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing
I have tried Agora 5.1.0 and 4.0.7
To Reproduce
Steps to reproduce the behaviour:

Upgrade Flutter to 3.0.
Try to make a build for Android

same error

We will support 3.0 in the next release.

@littleGnAl Could you please tell us when we can expect it?

@matthewfx I'm sorry that I can't estimate the time for it. We need to schedule the upgrade internally. I will update here if any feedback.

On the latest version, still can't run it.
e: D:\programming\flutter\installs\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.1\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraRtcEnginePlugin.kt: (263, 18): Type mismatch: inferred type is String? but String was expected
e: D:\programming\flutter\installs\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.1\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (16, 1): Class 'AgoraSurfaceViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: D:\programming\flutter\installs\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.1\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (20, 3): 'create' overrides nothing
e: D:\programming\flutter\installs\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.1\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (12, 1): Class 'AgoraTextureViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: D:\programming\flutter\installs\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.1\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing

Got this error, too.
And crashed in when clicking the top-left "back" button running with iPhone.

Its been 2 days since this issue has started when can we expect a fix?

new release also have these errors

+1

+1

in how much days you will upgrade it for flutter 3

big issue

The upgrade is done https://github.com/AgoraIO/Agora-Flutter-SDK/pull/680, but still waiting for the internal testing done, I think it should be released in the next few days.

thats great.

+1 still happening

We're so sorry that there's an issue that blocks the release https://github.com/flutter/flutter/issues/103630
You can dependency by git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

We're so sorry that there's an issue that blocks the release https://github.com/flutter/flutter/issues/103630, it caused the SurfaceView always render on the top left, but it works fine with TextureView
If the issue is acceptable for you, you can dependency it with the git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

any update?

We're so sorry that there's an issue that blocks the release flutter/flutter#103630, it caused the SurfaceView always render on the top left, but it works fine with TextureView
If the issue is acceptable for you, you can dependency it with the git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

This workaround works well for me! Thanks :)

@littleGnAl  It seems the issue flutter/flutter#103630 has been closed and an explanation has been given.

We're so sorry that there's an issue that blocks the release flutter/flutter#103630, it caused the SurfaceView always render on the top left, but it works fine with TextureView
If the issue is acceptable for you, you can dependency it with the git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

@littleGnAl, do we have performance difference between SurfaceView and TextureView?

We're so sorry that there's an issue that blocks the release flutter/flutter#103630, it caused the SurfaceView always render on the top left, but it works fine with TextureView
If the issue is acceptable for you, you can dependency it with the git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

Flutter 3.0.1 has been released by now. Does it contain the fix for the issue?

We're so sorry that there's an issue that blocks the release flutter/flutter#103630, it caused the SurfaceView always render on the top left, but it works fine with TextureView
If the issue is acceptable for you, you can dependency it with the git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

Flutter 3.0.1 has been released by now. Does it contain the fix for the issue?

Not yet.

We're so sorry that there's an issue that blocks the release flutter/flutter#103630, it caused the SurfaceView always render on the top left, but it works fine with TextureView
If the issue is acceptable for you, you can dependency it with the git package for a temporary workaround
dependencies:
  agora_rtc_engine:
    git:
      url: https://github.com/AgoraIO/Agora-Flutter-SDK.git
      ref: dev/flutter-upgrade-3.0

but for the disclaimer, it's a dev branch, you should pay attention if you want to use it in production.

@littleGnAl, do we have performance difference between SurfaceView and TextureView?

In Flutter, the performance of TextureView is better than the SurfaceView.

Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more details

e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-4.2.2\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraRtcEnginePlugin.kt: (146, 18): Type mismatch: inferred type is String? but String was expected
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-4.2.2\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (15, 1): Class 'AgoraSurfaceViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-4.2.2\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (20, 3): 'create' overrides nothing
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-4.2.2\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (15, 1): Class 'AgoraTextureViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-4.2.2\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (20, 3): 'create' overrides nothing
i am using agoraUIkit...
check all solution on stackover flow. nothing works. even i downgraded it still nothing work
please help me

Sorry for blocking your guys' upgrade, we have fixed this issue by changing the underly implementation, please try agora_rtc_engine: ^5.2.0.

Sorry for blocking your guys' upgrade, we have fixed this issue by changing the underly implementation, please try agora_rtc_engine: ^5.2.0.

@littleGnAl should we upgrade to Flutter v3.0.1?

Sorry for blocking your guys' upgrade, we have fixed this issue by changing the underly implementation, please try agora_rtc_engine: ^5.2.0.

@littleGnAl should we upgrade to Flutter v3.0.1?

It should be compatible with Flutter SDK 3.0.x

I am using agoraUIkit. Not agora-rtc-engine. Still get this error
On Fri, 20 May 2022, 7:51 pm Littlegnal, @.***> wrote:

Sorry for blocking your guys' upgrade, we have fixed this issue by
changing the underly implementation, please try agora_rtc_engine: ^5.2.0.
@littleGnAl https://github.com/littleGnAl should we upgrade to Flutter
v3.0.1?
It should be compatible with Flutter SDK 3.0.x
—
Reply to this email directly, view it on GitHub
https://github.com/AgoraIO/Agora-Flutter-SDK/issues/677#issuecomment-1132999436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYBTQIPFYY552NNVBLNHZXDVK6RFRANCNFSM5VWSHHLA
.
You are receiving this because you commented.Message ID:
@.***>

I am using agoraUIkit. Not agora-rtc-engine. Still get this error
…
On Fri, 20 May 2022, 7:51 pm Littlegnal, @.> wrote: Sorry for blocking your guys' upgrade, we have fixed this issue by changing the underly implementation, please try agora_rtc_engine: ^5.2.0. @littleGnAl https://github.com/littleGnAl should we upgrade to Flutter v3.0.1? It should be compatible with Flutter SDK 3.0.x — Reply to this email directly, view it on GitHub <#677 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYBTQIPFYY552NNVBLNHZXDVK6RFRANCNFSM5VWSHHLA . You are receiving this because you commented.Message ID: @.>

You would have to wait for an update of agoraUIkit to use the latest agora_rtc_engine.

The issue is fixed on the latest version of agora_rtc_engine and it works on flutter 3.0.1 too.

**but found the new update is still not working with flutter 3.0.1
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraRtcEnginePlugin.kt: (251, 18): Type mismatch: inferred type is String? but String was expected
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (16, 1): Class 'AgoraSurfaceViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (20, 3): 'create' overrides nothing
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (12, 1): Class 'AgoraTextureViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

**but found the new update is still not working with flutter 3.0.1
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraRtcEnginePlugin.kt: (251, 18): Type mismatch: inferred type is String? but String was expected
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (16, 1): Class 'AgoraSurfaceViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (20, 3): 'create' overrides nothing
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (12, 1): Class 'AgoraTextureViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter\.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

use  agora_rtc_engine: ^5.2.0

Please help me.. agoraUIkit is not working in flutter update. I need
solution as i have to release my app for production
On Sat, 21 May 2022, 4:02 pm Duhan BALCI, @.***> wrote:

**but found the new update is still not working with flutter 3.0.1
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraRtcEnginePlugin.kt: (251, 18): Type mismatch: inferred type is String? but String was expected
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (16, 1): Class 'AgoraSurfaceViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraSurfaceViewFactory.kt: (20, 3): 'create' overrides nothing
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (12, 1): Class 'AgoraTextureViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\agora_rtc_engine-5.1.0\android\src\main\kotlin\io\agora\agora_rtc_engine\AgoraTextureViewFactory.kt: (17, 3): 'create' overrides nothing
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':agora_rtc_engine:compileDebugKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more details

use agora_rtc_engine: ^5.2.0
—
Reply to this email directly, view it on GitHub
https://github.com/AgoraIO/Agora-Flutter-SDK/issues/677#issuecomment-1133600537,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYBTQINDLWU5Q3VFDYTANCDVLC7FTANCNFSM5VWSHHLA
.
You are receiving this because you commented.Message ID:
@.***>

@littleGnAl Please help me.. agoraUIkit is not working in flutter update. I need
solution as i have to release my app for production.

@alimajid124 I think it's better not to upgrade the Flutter SDK 3.x at this time if the AgoraUIkit is not supported yet

I have degraded flutter version still stuck with the same issue
On Thu, 2 Jun 2022, 5:19 pm Littlegnal, @.***> wrote:

@alimajid124 https://github.com/alimajid124 I think it's better not to
upgrade the Flutter SDK 3.x at this time if the AgoraUIkit is not supported
yet
—
Reply to this email directly, view it on GitHub
https://github.com/AgoraIO/Agora-Flutter-SDK/issues/677#issuecomment-1144797904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYBTQIJDL6764QOP64S2PS3VNCRGPANCNFSM5VWSHHLA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@alimajid124  I think providing a reproducible demo for your case is helpful


tiltfile: add kustomize(flags) for passing extra flags

Hello @landism, @milas,
Please review the following commits I made in branch nicks/kustomize:
47b9c3fd254ee425fe8603567f18741ff4cfc890 (2022-10-20 19:06:34 -0400)
tiltfile: add kustomize(flags) for passing extra flags
also print kustomize invocation like we do with helm
fixes https://github.com/tilt-dev/tilt/issues/5956
fixes https://github.com/tilt-dev/tilt/issues/5007
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

oops, wrong repo


Identify default execution environment config

Currently, the default config is set to
    "ansible-navigator": {
        "container-engine": "podman",
        "execution-environment": True,
        "execution-environment-image": "quay.io/ansible/ansible-runner:devel",

Refer https://github.com/ansible/ansible-navigator/blob/main/ansible_navigator/config.py#L32

the tox.ini file should be updated to reflect the final image as well

https://github.com/ansible/awx-ee/pull/70

https://quay.io/repository/ansible/ansible-navigator-demo-ee
we should have a tagged version here by 6/10 per shane


Ability to have Right-Angle Straight Lines - Pool Message Flows

QOL request:
Abilty to create right-angle straight lines with Message Flows from a task into a Pool.  There is not magnets to attach to.
Would be great if you could hold shift down when create a line and it would only support 90 degree movement or something similar.
Thanks!

NVM.  Was was dealing with large amount of pools, and did not see the existing 90 degree snap function that occurs after you let go.


zli cve should show an error if the image does not exist

Describe the bug
zli just prints nothing for missing images,
$ zli cve aci-zot -I c3/minbase:1.0.1955555
ID                SEVERITY  TITLE
$ echo $?
0

Expected behavior
an error message to distinguish between missing images and images with no CVEs would be useful

I tried recreating the issue and if the image doesn't exists I get this output:
$ bin/zli-linux-amd64 cve config-multiple-cve5000 -I img:tag
Error: repository: not found

And if the image exists but doesn't have CVEs, I get no output, not even the header:
$ bin/zli-linux-amd64 cve config-multiple-cve5000 -I busybox:latest


Suggestion: Submit to brew cask

This has been merged in https://github.com/caskroom/homebrew-cask/pull/10495


Bootstrap tables and buttons

Added bootstrap buttons and tables
Pull Request Description:
Added bootstrap buttons with block syntax support.
Added bootstrap tables with block syntax support.
New Pull Request Checklist:

[X] Reviewed contributing guidelines.
[X] good commit messages
[] Github issue added, if it exists.
[X] Added an entry to the Changelog.
[X] All tests passing: run npm test.
[X] New component tests include ember-a11y-testing to test accessibility.

See https://ember-bootstrap-controls.herokuapp.com/

changing values in component options appears to not do anything to the component displayed.
Having tabular data that forces the table to be wider than the small screen would be better to show how table responsive works.

@jweakley can you redeploy with
"Updated how freestyle tables is displayed. Fixed checkbox bug."
fixes in it so I can verify that it's fixed?

@flarinerin this PR has been redeployed

I recommend changing the table data to much longer examples so that table-responsive is needed and can display as expected. The class is being applied as expected but general users, new team members, and guests using our library will not be able to know the difference.

@flarinerin more data was added to the table and deployed for you to review.

Updates^^

When working on moving the logic from addon/templates/components/bootstrap/tables/-pagination-control.hbs into the js I noticed that there is a bug with displaying the pagination on the table-with-pagination. It currently renders in freestyle but does not show any content.
It seems like it does not show any content because the conditional on line 1 of ember-bootstrap-controls/addon/templates/components/bootstrap/tables/-pagination-control.hbs which is now showPaginationNav resolves to false. I it seems like it resolves to false because pageRecordsMeta seems to be undefined and is required in all cases for the showPaginationNav flag to become true.
I did some more looking and it seems like pageRecordsMeta is later set as a property on the component as a result of calculatePaginationTask running inside of didReceiveAttrs in ember-bootstrap-controls/addon/components/bootstrap/tables/table-with-pagination.js. There could be an asycn bug where where the
  {{#if paginationEnabled}}
    {{bootstrap/tables/-pagination-control
      pageNumber=pageNumber
      pageSize=pageSize
      totalPages=totalPages
      pageRecordsMeta=pageRecordsMeta
      onPage=(action 'onPage')
    }}
  {{/if}}

part of  table-with-pagination is getting the pageRecordsMeta before the parent component has time to define it.

I did some more digging and is also seems that -- at least in freestyle -- line 86 of table-with-pagination does not resolve because 1) rowsData is not an object, it is an array, and 2) because meta.page does not exist on rowsData. const paginationInformation = yield get(rowsData, 'meta.page');. Either the seed data given to the component is incorrect (I am assuming it is because we are trying to showcase pagination in freestyle ) or the component is behaving appropriately and there is something I am missing.

The seed data should be an ember data collection. I think we should make it be able to handle an array as well though. The problem is that arrays would not have any of the meta paging data so pagination controls don’t really make sense for an array. We might want to have the table work with arrays and have the wrapper be able to pick apart an ember data array.

I changed the rowData that is being passed to the table to be a ArrayProxy. The models have a meta object that has the pagination information.
I also tested it with passing only an array of objects with no meta, and the table was rendered without the pagination components.

If I change the per page dropdown to 5 should I expect the table to only show 5 rows? @jir-f
It currently does not adjust in this way.

Please read feedback

These are issues that would be nice to address in the future but are not blockers
https://github.com/wildland/ember-bootstrap-controls/issues/247
https://github.com/wildland/ember-bootstrap-controls/issues/244
https://github.com/wildland/ember-bootstrap-controls/issues/243


Adding a Group to a Site DOES change external sharing and exposes internal content :-(

Hi Vesa,
I helped a customer groupifying 2000+ classic SharePoint Site Collections, and approx 80% did have "Only people in your organization" in the Sharing option.
After groupying the sites they had "New and existing guests" :-(
So I wonder what is correct, the article is correct and the groupify code is misbehaving, or the article is wrong?
How to test:
Create a new STS#0 orSTS#3 site, set the sharing to "Only people in your org" in the Admin center
Go to the site, select "Connect to new Microsoft 365 Group"
Go to the Admin center, check the sharing settings
Cheers
/Kasper

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4f65999b-52d3-52dd-9bf6-559b2ec28817
Version Independent ID: 919b0add-acbb-628e-7a7d-19b09a3d1f22
Content: External sharing after Microsoft 365 group connection
Content Source: docs/transform/modernize-connect-to-office365-group-externalsharing.md
Service: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Just for Info: Vesa Juvonen has updated the documentation. The question remains: is it as per requirements that the Groupify code overwrites the Site Collection sharing setting? Are there additional documentation/articles out there getting this wrong?

@kasperbolarsen  - we are checking this now from the owning feature crew and hopefully will have a definite answer soon. Thanks for flagging this.


chore: add new orange and green base colors

Adding new base colors for orange and green so the contrast color becomes white.

This does not update any tokens, should it?

This does not update any tokens, should it?

No. This is just so that Lasse kan copy in the new tokens into Figma. He will then generate new tokens that will be pushed to code in a PR later.

This will be a merge conflict with #2290

Fixed the conflict, is it ok @Thunear ?

Yes this is great!


Quarkus Master - Classes that should be initialized at run time got initialized during image building

I observed some failures building camel-quarkus with the latest Quarkus 999-SNAPSHOT.
This happens on at least the HTTP and Telegram native tests. Given this is related to Netty, it's likely it fails for other extensions too.
INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on GraalVM Version 19.3.1 CE
[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] docker run -v camel-quarkus/integration-tests/http/target/camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-native-image-source-jar:/project:z --env LANG=C --user 1000:1000 --rm quay.io/quarkus/ubi-quarkus-native-image:19.3.1-java11 -J-Djava.util.logging.manager=org.jboss.logmanager.LogManager -J-Dsun.nio.ch.maxUpdateArraySize=100 -J-Dvertx.logger-delegate-factory-class-name=io.quarkus.vertx.core.runtime.VertxLogDelegateFactory -J-Dvertx.disableDnsResolver=true -J-Dio.netty.leakDetection.level=DISABLED -J-Dio.netty.allocator.maxOrder=1 -J-Duser.language=en -J-Dfile.encoding=UTF-8 --initialize-at-build-time= -H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy$BySpaceAndTime -H:+JNI -jar camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-runner.jar -H:FallbackThreshold=0 -H:+ReportExceptionStackTraces -H:-AddAllCharsets -H:-IncludeAllTimeZones -H:EnableURLProtocols=http,https --enable-all-security-services --no-server -H:-UseServiceLoaderFeature -H:+StackTrace camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-runner
[camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-runner:24]    classlist:   8,447.56 ms
[camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-runner:24]        (cap):   1,372.91 ms
[camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-runner:24]        setup:   3,101.71 ms
06:43:27,457 INFO  [io.und.web.jsr] UT026003: Adding annotated server endpoint class org.apache.camel.quarkus.component.http.it.GreetingServerEndpoint for path /ahc-ws/greeting
[camel-quarkus-integration-test-http-1.1.0-SNAPSHOT-runner:24]     analysis:  21,620.84 ms
Error: Classes that should be initialized at run time got initialized during image building:
 io.netty.util.concurrent.GlobalEventExecutor the class was requested to be initialized at build time (from the command line). To see why io.netty.util.concurrent.GlobalEventExecutor got initialized use -H:+TraceClassInitialization
io.netty.util.concurrent.ScheduledFutureTask the class was requested to be initialized at build time (from the command line). To see why io.netty.util.concurrent.ScheduledFutureTask got initialized use -H:+TraceClassInitialization
io.netty.util.concurrent.ImmediateEventExecutor the class was requested to be initialized at build time (from the command line). To see why io.netty.util.concurrent.ImmediateEventExecutor got initialized use -H:+TraceClassInitialization

com.oracle.svm.core.util.UserError$UserException: Classes that should be initialized at run time got initialized during image building:
 io.netty.util.concurrent.GlobalEventExecutor the class was requested to be initialized at build time (from the command line). To see why io.netty.util.concurrent.GlobalEventExecutor got initialized use -H:+TraceClassInitialization
io.netty.util.concurrent.ScheduledFutureTask the class was requested to be initialized at build time (from the command line). To see why io.netty.util.concurrent.ScheduledFutureTask got initialized use -H:+TraceClassInitialization
io.netty.util.concurrent.ImmediateEventExecutor the class was requested to be initialized at build time (from the command line). To see why io.netty.util.concurrent.ImmediateEventExecutor got initialized use -H:+TraceClassInitialization

	at com.oracle.svm.core.util.UserError.abort(UserError.java:65)
	at com.oracle.svm.hosted.classinitialization.ConfigurableClassInitialization.checkDelayedInitialization(ConfigurableClassInitialization.java:510)
	at com.oracle.svm.hosted.classinitialization.ClassInitializationFeature.duringAnalysis(ClassInitializationFeature.java:187)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$runPointsToAnalysis$8(NativeImageGenerator.java:710)
	at com.oracle.svm.hosted.FeatureHandler.forEachFeature(FeatureHandler.java:63)
	at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:710)
	at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:530)
	at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:445)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1407)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

I don't know if this is the culprit but there's a number of io.netty.util.concurrent classes here: https://github.com/AsyncHttpClient/async-http-client/blob/master/client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java


--no-threads doesn't seem to do anything (trying to use on lerna repo)

Describe the bug
I feel like I must be doing something wrong here...
I was curious if we could make use of vitest on lerna to help us run our tests as efficiently as possible.
It cannot complete because of a ton of these errors:

The fixtures we on the Nrwl team inherited when we took over stewardship of the lerna project do a process.chdir()ing
These errors with vitest are despite running with the --no-threads options
Reproduction
(This is not the end state of adding vitest to lerna because I would want to clean up the jest usage etc, but until I can get past this fundamental issue there is no point in going any further.)
I did the following:

checked out https://github.com/lerna/lerna
installed vitest with npm
added the following vite.config.ts

import { defineConfig } from 'vitest/config'

export default defineConfig({
  test: {
    globals: true,
  },
})

ran npx vitest
Hit the above mentioned error, so then ran npx vitest --no-threads and it made no difference

System Info
System:
    OS: macOS 13.0
    CPU: (10) arm64 Apple M1 Max
    Memory: 3.66 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.volta/tools/image/node/16.15.0/bin/node
    Yarn: 1.22.18 - ~/.volta/tools/image/yarn/1.22.18/bin/yarn
    npm: 8.12.1 - ~/.volta/tools/image/npm/8.12.1/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Safari: 16.1
  npmPackages:
    vitest: ^0.25.1 => 0.25.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

You cannot disable this behaviour. No threads just reduces the number of workers to one.

Apologies I’ve noticed this is actually a duplicate of https://github.com/vitest-dev/vitest/issues/1436, closing in favour of that one.
But would really appreciate any kind of hint of path forward for tests which need this…
I don’t believe it’s currently documented as part of the Jest migration guide and it should be because jest supports this just fine


make predict signature consistent

I prefer predict_at argument name for a couple of reasons:

It is more informative to newbie people
It is a language for "normal" human
It does not violate pep8 in function signatures. We don't follow pep8 always, but we shouldn't assume that users of GPflow do the same thing.
It shows the maturity of the project via respecting the rules - pep8 again.

In short, function interfaces must follow pep8 and internals can break pep8 sometimes.

@st-- the PR title says you're making the predict signature consistent. As a reviewer I'd need more information: what is the proposed chosen signature (you've chosen Xnew not foo or bar)? Where did that come from? Why that over alternatives?

I think X should be familiar notation for input points for anyone using GPs. I dislike predict_at because model.predict_f(predict_at) looks rather redundant and a bit confusing. How about X_prediction?

it sounds like there's two tasks here

choose a signature
implement it

my vote is to do them as separate tasks

Yes, I'm happy to do it in separate tasks. How about we use this draft-PR to discuss signature, and then once we've agreed on one, can turn it into a full ready-for-review PR afterwards?

@st--, do you mind if @joelberkeley-pio takes a lead on that and will work on these PRs?

How about X_prediction?

As I mentioned before, in function signatures we probably want to follow pep8 rules . Therefore, arguments should be lower case. I don't mind having an argument at, so that signature would look: predict_f(at: Data, ...).

I'd be very happy for other people to do the work once we've found a consistent name everyone can live with. Personally I think Xnew contains more information than at. I'm also not convinced that we must follow pep8 in function signatures.

@st-- what information in Xnew that isn't in at would you like to preserve?
as an aside, I'd like to know why the type checker didn't pick up this inconsistency. do we have a type checker?

what information in Xnew that isn't in at would you like to preserve?

That it is about inputs (X), and specifically new test points (new).
Some variant on "X" would be consistent with all the GP literature. Xnew would be consistent with both gpflow1 and GPy. Scikit-learn uses simply X.

as an aside, I'd like to know why the type checker didn't pick up this inconsistency. do we have a type checker?

There is no type checker run on GPflow.

Candidates so far:

Xnew - consistent with both gpflow1 and GPy
predict_at - PEP8, jargon-free
at - PEP8, jargon-free
X_predictions
X - like scikit-learn

what information in Xnew that isn't in at would you like to preserve?

That it is about inputs (X), and specifically new test points (new).

In the Bayesian optimization toolbox, we evaluate predict_f at points for which the model has already been optimized, if we're modelling from noisy data rather than using the observed values themselves. Isn't that a reasonable use case? In light of this, is new accurate for noisy observations?


Feat: add menu to header

This PR aims to add an optional property navigationMenu allowing to pass a list of JSX elements to add the navigation.
Please check this issue.
Some screenshots to see how it looks like:
Large screen:

Medium screen:

Small screen - burger menu closed:

Small screen - burger menu opened:

Mobile screen:

🔍  Please disregard the text color of the footer !
🙏 Don't hesitate to integrate it in another app such as Portal, Faucet or Dataset Deposit in order to test correctly the rendering (too limited on storybook), thanks !

Codecov Report

Merging #507 (87f18be) into main (2c2e023) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   98.05%   98.05%
=======================================
  Files          73       73
  Lines         821      821
  Branches      128      128
=======================================
  Hits          805      805
  Misses         14       14
  Partials        2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

/publish

:tada: This PR is included in version 1.18.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Bug] Google expanded pane preview images on click UI broken

Desktop (please complete the following information):

OS: Ubuntu 22.04 (Jammy) server via WSL2 on Windows 11
GodMode Version Self built

irrelevant now as we switched userAgent
(untested if fixed or not)


Secured wss:// protocol failing ?

I was wondering if the wss encrypted websocket protocol was implemented.
I can't seem to make it work and haven't seen anything in the code related to encryption.
oortcloud/node-ddp-client seems to have encryption support.
was just wondering...

It works out-of-the-box since it's part of the websocket implementation, not react-native-meteor.
I only use wss with my servers, for example.

Thanks for the help!
It was due to /websocket not being proxy-ed as a websocket on nginx. I only had setup websocket proxying for /sockjs


648 axissection label not cleared

Summary
Added call to RemoveFromView for _label as RemoveFromDrawMargin did not seem sufficient to remove the label
Solves
648

Thanks!


Cannot perform migration due to missing endpoint in the source tenant

Hi there,
I have followed the process described in the documentation and was successful. Even the verification attempts with the PowerShell returned the correct results just like depicted in the documentation.
Nonetheless, I cannot perform the migration because the endpoint is created just in the source tenant.
Basically, I am using the new Exchange Admin Center in the source tenant to perform the move and I am asked for an endpoint.
In the documentation there is a reference to an endpoint only with respect to the target tenant.
Is the procedure supposed to create an endpoint in the source tenant as well?
If not, how could I get around the issue of the missing endpoint in the source tenant?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c61c960c-f5c3-76f7-ac18-dfeaf30230e4
Version Independent ID: 3dc607b2-869e-976f-80da-d73cfb1210e5
Content: Cross-tenant mailbox migration - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/cross-tenant-mailbox-migration.md
Product: microsoft-365-enterprise
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@GRJ78 Thank you for your feedback. The endpoint is supposed to be created only in the target as this is a pull move. You can use the PS cmdlet Get-MigrationEndpoint Idenityoftheendpoint | fl Identity, RemoteTenant, ApplicationId, AppSecretKeyVaultUrl to check.
I'd recommend contacting Support via the Need help section on the admin center to assist you in creating the correct endpoints and organization relationship.
Thanks
Sri

Hi Sri,
Thanks for that information. The organizational relationships are in place as is the endpoint in the target tenant. What I was doing wrong is that I was trying to initiate the migration from the admin portal of the source tenant. I tried to do the same from the target tenant and it is working.
Nonetheless, I will have to contact support since the migration batch got stuck at "syncing" status.

@GRJ78 Thank you for the update. Sometimes the syncing state could also be due to throttling, so support can help increase the limit.
@yogkumgit There are no changes required in this document and the issue can be closed.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @GRJ78 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Support SpriteRenderer

from #155

I think it is possible. :)
However, shaders and components need to be modifiered.
First of all, I will develop it in another repository.

Nice work Bro!
Any updates for SpriteRenderer?)


First writer

To check on how much CPU is chewed up going from Eigen data types to Protocol Buffers in practice, do a simple writer which:

[ ] constructs the correct protocol buffers messages
[ ] converts to JSON
[ ] writes messages in newline delimited JSON to a file.
This should be a drop-in replacement for stream_writer for output, so
[ ] fork/hack CmdStan a little to do a comparison of this versus .csv output (which also has to convert to text).

First time reading too fast bites: turns out protobuf-to-JSON is NOT native in the C++ version of the library.  Not sure how I got that wrong.  Needs different strategy, likely just deal with binary serialization and then look at how practical it is to read these from an higher-level interface (R/Python).

protobuf3 to json will be in the C++ version. I think it might be there already somewhere but perhaps not documented. You see mentions of it in the changelog: https://github.com/google/protobuf/blob/4ab918674368e237e1cf6be467c1c4223dd2b510/CHANGES.txt
Here's the spec:

https://developers.google.com/protocol-buffers/docs/proto3#json

What will not be in protobuf3 is json->protobuf. Will this be a problem?

Only for doing JSON input into a CmdStan fork. I'll do the writer anyway and we can see where things go form there.  Do you know if they've declared that's "beyond scope" or if it's just a "we'll do it later"? I'm pretty sure there is a JSON parser in the tree now (your comment prodded me to dig through their code some more).

I'm sure a 3rd party will do the json->protobuf eventually. I think there's such a thing already for protobuf2

The PB -> JSON functionality is still buried in a utility that needs a bunch of internal protobuf arguments to run the PB -> JSON conversion function.  I'm going to wait on this until they release a cleaner API.  In the meantime we can deal with binary protobuf messages all the way to the client.  If you're curious it's in:
protostan/lib/protobuf/src/google/protobuf/util/json_util.h

This sounds like a solid plan.
On 02/26, Krzysztof Sakrejda wrote:

The PB -> JSON functionality is still buried in a utility that needs a bunch of internal protobuf arguments to run the PB -> JSON conversion function.  I'm going to wait on this until they release a cleaner API.  In the meantime we can deal with binary protobuf messages all the way to the client.  If you're curious it's in:
protostan/lib/protobuf/src/google/protobuf/util/json_util.h

Reply to this email directly or view it on GitHub:
https://github.com/sakrejda/protostan/issues/35#issuecomment-189413025

There's a new release of protobuf which looks like it has improved JSON support https://github.com/google/protobuf/releases


Remove kittens dependency; add custom macro for Traverse instances

😄

I'd prefer to use the same @deriveFixedpoint macro and substitute the Functor instance with a traversable one.

I thought Kittens doesn't support Traversable? So won't we need to write our own implementation to derive those instances?

Yeah, it doesn't support deriving Traversable, we'd need to implement derivation ourselves.  What I meant is that we wouldn't need a new macro right? or you mean that we should provide a macro annotation just for deriving the instance of a fixed point data type?


Reuse auth token for projects within an organization

Port from https://github.com/adobe/helix-sidekick-extension/pull/713

:tada: This issue has been resolved in version 1.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


bug: dex and example backend in many containers

Describe the bug
See https://github.com/kubestellar/kubestellar/pull/1363#discussion_r1419932698
Following is an excerpt from kubestellar, which shows that https://github.com/kubestellar/kubestellar/pull/1363#discussion_r1420339006 is incorrect.
ensure_espw
ensure_imws $imws
ensure_wmws $wmws
kubectl ws root &> /dev/null

if [ $subcommand == init ]; then
    exit 0
fi

Steps To Reproduce
See above
Expected Behavior
Only one copy of dex and example-backend run for the KCS.
Additional Context
No response

I was confused. The scripting in question is in the kubestellar command, which is only used in one container in the containerized case. In the non-containerized case it is expected that all invocations of the kubestellar command are on the same machine.


Include CWE mappings for all bandit issues

Is your feature request related to a problem? Please describe.
The internal vulnerability identifiers/issues used by bandit cannot be mapped to commonly used vulnerability metrics such as CWE. Some environments may require CWEs to be used as a standard for categorizing vulnerabilities. In addition, CWE mappings are very useful to consolidate vulnerability reports produced by different tools.
Describe the solution you'd like
Every vulnerability should get assigned a CWE identifier.
Describe alternatives you've considered
Additional context

Just opened up a PR for this issue: https://github.com/PyCQA/bandit/pull/613

Please reference this feature in your PR

I'd like to also see a parameter in the metadata for a link to the http://cwe.mitre.org/ site with the referenced ID.

I'd like to also see a parameter in the metadata for a link to the http://cwe.mitre.org/ site with the referenced ID.

Thanks again @ericwb. I addressed your comments in the PR 👍

Hello Team,
Is this enhancement already done ? Can someone help me on this?


Implement listCommand test coverage in TransactionParserTest.java

I moving this to v1.4 for further discussion. Reason: Personally, I feel there is no need for parser test for listTxn and list command as there is no parameter to test. The only thing to test is when list command in inputted, then the all persons are listed correctly in the PersonListPanel, vice versa for listTxn. I can add this in milestone v1.4 as part of local GUI testing.

@GavinSin Follow up required for this.

Currently, this is in my nice to have todo list. if I have time, I will do.
What need to be done:

In local GUI testing,
for filtered person list (by contact), after running list command, all persons are showed in left panel list.
for filtered transaction (by any filter), after running listTxn command, all transactions are showed in right panel list.

Hmm, since the RightPanel retrieves data from the filteredTransactionList, we can test:

That RightPanel changes when filteredTransactionList changes.
filteredTransactionList changes when listTxn command is executed

Hmm, since the RightPanel retrieves data from the filteredTransactionList, we can simplify the tests to:

That RightPanel displays the same transactions as in filteredTransactionList.
filteredTransactionList changes when listTxn command is executed

1 is trivial, 2 is already covered by the respective ListCommandTest classes


Add documentation and tests for biwrap

In this PR, and perhaps a couple more, I ask a bunch of questions about what code does, then add that to docs so hopefully everyone knows what it does

Questions from me might start slow at first but I hope to become more self sufficient as I gain more knowledge

You may check the docs here
https://github.com/ferrine/biwrap

You can make it autouse with yield

I know, left it not autouse because there were only two and I was debating adding tests for model in a class with a different fixture at a future point

@ferrine This one good? I'll make issues for @rpgoldman's comments to keep track

Hi, small concerns about
https://github.com/pymc-devs/pymc4/blob/master/tests/test_executor.py#L72
Better change to
@model(method=True)

and
https://github.com/pymc-devs/pymc4/blob/master/tests/test_executor.py#L82
in that case and not passing first argument which should be self

Hi, small concerns about
https://github.com/pymc-devs/pymc4/blob/master/tests/test_executor.py#L72
Better change to
@model(method=True)

and
https://github.com/pymc-devs/pymc4/blob/master/tests/test_executor.py#L82
in that case and not passing first argument which should be self

Noted. I can make those changes in another PR because theyre on master. Is this PR good to go?

Thanks @canyon289!


Comment out infer_spec_type_from_file_location! in generated helper.

We would prefer that people tag their specs manually (or via generators) and whilst our generators do generate tags we never removed the generated infer_spec_type_from_file_location!  as a default.
Fixes #2803

Released in 7.1.0

A combination of factors, it is better to be explicit about things to improve the "documentation" effect, it makes it less surprising when you include extra helpers into different types of specs and its less brittle as an implementation.

I think this really goes against the naming conventions that Rails instills.

I think this really goes against the naming conventions that Rails instills.

Rails doesn't automatically configure things based on directories either, you inherit from classes e.g. ActionController::Base

I think this really goes against the naming conventions that Rails instills.

Rails doesn't automatically configure things based on directories either, you inherit from classes e.g. ActionController::Base

I think it goes against the convention over configuration part of the doctrine. Maybe that's what @BenMorganMY wanted to talk about.

@fonji yep, this is primarily about ensuring convention over configuration. It's redundant for a Rails application to also have to specify the spec type and will end up encouraging bad configuration behaviour. This should not be the default in a Rails application.


Changing parameters once Llama is initialized makes it not consistent

Hi people 👋🏾 !
While using langchain and llama-cpp-python I've noticed that I had to initialise two instances of the model (one for the embeddings and another one for the inference). I wanted to change that: see this issue: https://github.com/hwchase17/langchain/issues/2630 by allowing to send the same llama "client" when initialising both objects LlamaCpp and LlamaCppEmbeddings and set the embeddings parameter to true/false when needed. However, I've noticed that this is not something it can be done currently with the library:
Reproducible code
from llama_cpp import Llama
llama = Llama(model_path=MODEL_PATH, verbose=False, embedding=False)
response = llama(prompt="Brasil is awesome") # it works
llama.embedding= True
embeddings = llama.embed("Spain is awesome") # it does not work

throwing this error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/adria.cabezasantanna/personal_projects/automatic-documentation/venv/lib/python3.9/site-packages/llama_cpp/llama.py", line 315, in embed
    return list(map(float, self.create_embedding(input)["data"][0]["embedding"]))
  File "/Users/adria.cabezasantanna/personal_projects/automatic-documentation/venv/lib/python3.9/site-packages/llama_cpp/llama.py", line 272, in create_embedding
    raise RuntimeError(
RuntimeError: Llama model must be created with embedding=True to call this method

Interestingly, if you initialise it as embeddings=True, you can do both, perform inference and get the embeddings:
from llama_cpp import Llama
llama = Llama(model_path=model_path, verbose=False, embedding=True)
embeddings = llama.embed("Spain is awesome") # it works
response = llama(prompt="Brasil is awesome") # it also works

Is there any reason behind not setting the embeddings parameter always to true? Why can't we change the parameter dynamically?

Any update?

@adriacabeza unfortunately the parameters cannot be updated after the model is instantiated. This would require re-loading the entire model anyways so currently I would recommend just calling the contructor again with your updated parameters.

This would require re-loading the entire model anyways so currently I would recommend just calling the constructor again with your updated parameters.

With the caveat that you probably won't want to do this if you're using a GPU until the upstream VRAM libllama memory leak bug identified in #223 is fixed.


 Details: Could not find file 'T:\reh0\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\reh0\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\reh0\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Modify AnnotationFilterInvocationDefinition#determineUrl to store grailsWebRequest with populated params [v3.0.0]

I noticed that there is a finally block in line 126 of AnnotationFilterInvocationDefinition which sets existingRequest with params unpopulated for the current request. However, I have an @Secured annotation with a closure where I need the params populated. In particular, I want to access the request's path variable via params.id.
I forked the project and modified the method such that the configured grailsRequest by the matched urlInfo is stored instead of existingRequest. I'm not sure which case needs the existingRequest to be stored back. Please advice. Thanks!
Below is the original AnnotationFilterInvocationDefinition#determineUrl method:
protected String determineUrl(FilterInvocation filterInvocation) {
        HttpServletRequest request = filterInvocation.httpRequest
        HttpServletResponse response = filterInvocation.httpResponse

        GrailsWebRequest existingRequest
        try {
            existingRequest = WebUtils.retrieveGrailsWebRequest()
        }
        catch (IllegalStateException e) {
            throw new IllegalStateException(
                'There was a problem retrieving the current GrailsWebRequest. This usually indicates a filter ordering ' +
                "issue (the 'springSecurityFilterChain' filter-mapping element must be positioned after the " +
                "'grailsWebRequest' element when using @Secured annotations).")
        }

        String requestUrl = calculateUri(request)

        log.trace 'Requested url: {}', requestUrl

        String url
        try {
            GrailsWebRequest grailsRequest = new GrailsWebRequest(request, response, servletContext)
            WebUtils.storeGrailsWebRequest grailsRequest

            Map<String, Object> savedParams = copyParams(grailsRequest)

            UrlMappingInfo[] urlInfos = PluginReflectionUtils.matchAllUrlMappings(
                    urlMappingsHolder, requestUrl, grailsRequest, httpServletResponseExtension)

            for (UrlMappingInfo mapping : urlInfos) {
                if (mapping.redirectInfo) {
                    log.trace 'Mapping {} is a redirect', mapping
                    break
                }

                configureMapping mapping, grailsRequest, savedParams

                url = findGrailsUrl(mapping)
                if (url) {
                    break
                }
            }
        }
        finally {
            if (existingRequest) {
                WebUtils.storeGrailsWebRequest(existingRequest)
            }
            else {
                WebUtils.clearGrailsWebRequest()
            }
        }

        if (!StringUtils.hasLength(url)) {
            // probably css/js/image
            url = requestUrl
        }

        String finalUrl = lowercaseAndStripQuerystring(url)
        log.trace 'Final url is {}', finalUrl
        finalUrl
    }

Hi @ sofiaguyang .  It's been some time since this issue was created.
Were able to find a resolution?

Marking this as Cannot Reproduce and closing.
I will be happy to reopen it if you would be so kind as to attach or link to a sample app which reproduces the problem.


Multiple Indices

Within config.php, is it possible to create another section to query a logstash index of a different name?
I tried adding one but it doesn't come up as an option when creating a new Search.
Example:
# Configuration for the logstash index that 411 queries.
    'logstash' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [],
        'index' => 'logstash-apache',
        'date_based' => true,
        'date_field' => '@timestamp',
        'src_url' => null,
    ],
     # Syslog configuration
    'syslog' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [],
        'index' => 'syslog',
        'date_based' => true,
        'date_field' => '@timestamp',
        'src_url' => null,
    ],
];

Unfortunately, doing this is a bit tricky at the moment:

Create the new Search class in phplib/Search/.
Add the new class to the type array in phplib/Search.php.

For your particular case, you can use the following two commands:

sed 's/Logstash/Syslog/g; s/logstash/syslog/g' phplib/Search/Logstash.php > phplib/Search/Syslog.php;
sed -i -E 's/(\$TYPES = \[.+?)(];)/\1, '\'Syslog_Search\''\2/' phplib/Search.php

Let me know if that works for you!

Thanks! I had reached that stage using your developer guide.
So, now I'm a stage further in that I now have a health check for Syslog and I can create a search choosing Syslog as the source. Valid data is returned on Test.
Just one problem left now, when creating a search with Syslog the 'Fields' and 'Description' fields are missing/not rendered. These seem to be referenced by htdocs/assets/templates/searches/search/elasticsearch/b.html
Is there something more that has to be done?

Great thanks!
Just one issue left now; when creating a search using Syslog as a source the 'Fields' & 'Description' fields are missing/not rendered. These seem to be referenced by /var/www/411/htdocs/assets/templates/searches/search/elasticsearch/b.html
Is there something more that needs to be done?

Whoops, forgot one step. Since this is an Elasticsearch search, you have to register it as such on the frontend. Add the following line to this file:
SearchView.registerSubclass('syslog', ElasticsearchSearchView);
Or apply this diff:
diff --git a/htdocs/assets/js/views/searches/search/load.js b/htdocs/assets/js/views/searches/search/load.js
index 50e61fb..b6db825 100644
--- a/htdocs/assets/js/views/searches/search/load.js
+++ b/htdocs/assets/js/views/searches/search/load.js
@@ -20,2 +20,3 @@ define(function(require) {
     SearchView.registerSubclass('logstash', ElasticsearchSearchView);
+    SearchView.registerSubclass('syslog', ElasticsearchSearchView);
     SearchView.registerSubclass('alert', ElasticsearchSearchView);

I made the change to register the new subclass in load.js, but still not seeing the 'Fields' & 'Description' fields. Running the Test function does retrieve valid data though.

Run grunt prod to rebuild assets and you should be (hopefully) good to go!

That did the trick!
Again, great project so many features.


Remove OpenShift API references for vanilla Kubernetes

Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] Optimization
[x] Documentation Update

Description
This PR updates the examples directory and remove *.openshift.io references
Related Tickets & Documents

Related Issue #595
Closes #595

@mukrishn ^^^


Docs: Enhance the quick start guide with a declarative approach

What problem are you facing?
The current quick start uses imperative commands from up to make it concise and hopefully easy to understand. This setup is not for production use-cases. There and in any GitOps powered workflows users should use a dedeclarative approach

How could Upbound help solve your problem?
Enhance the guide or write a new guide that shows the declarative style including all the options a user has.

In the Crossplane ecosystem, we currently utilize a marketplace for all configurations. This setup allows interested users to seamlessly install any configuration by simply clicking the 'Install' button, offering a declarative approach. https://marketplace.upbound.io/configurations/upbound/platform-ref-aws/


wait-for-job with backoff limit 0

Because backOffLimit can be 0, a zero value for pod status failed will
always cause the condition to return true.
Signed-off-by: James McElwain<EMAIL_ADDRESS>
[ ] this PR contains documentation
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

https://github.com/helm/helm/issues/9285 This PR will fix it.

closing as a duplicate of #9285.

@bacongobbler Is there another PR open for #9285? Happy if there's a more extensive fix out there, but this is the only one I see.

Oh! My apologies. I thought @yxxhero was referencing another PR. I'll reopen this.
I need more coffee.

This PR also closes #9313.

This PR also closes #9312.


Pr/259

Description
Please include a summary of the change and which is fixed.

Add A
Fix B

How has this been tested?
Please describe the tests that you ran to verify your changes.

[ ] Test A
[ ] Test B

I
Sorry for it.


module "/etc/nginx/modules/ngx_http_js_module.so" version 1017008 instead of 1016001 in /etc/nginx/nginx.conf:5

nginx -v
nginx version: nginx/1.16.1

Grabbed,
ngx_devel_kit-0.3.1
But build with below command,
./configure --with-compat --add-dynamic-module=/tmp/nginx_stable/ngx_devel_kit-0.3.1
Please help

The NDK can't be built as a dynamic module.  Not all Nginx modules can be dynamic.  Only modules that have the specific code in the module files to be built as dynamic modules can be dynamic.
Also, if you look at your error information, it's to do with the ngx_http_js_module - not NDK.


slf4j as provided?

I'm thinking the two slf4j JARs should be marked as provided as they are already deployed to common/lib

Thanks @ottenhoff


Always enable WinRM, enable it last, and skip SSH setup on WinRM hosts

Big changes

Always configure WinRM. The WinRM script set it up and then firewalled it off. Even on an SSH / Cygwin host we should still setup WinRM.

If we configure winrm too early then Packer can connect and it starts prepping the box to dump the image. If this is done while updates are still installing the result is a non-working box.  Instead lets drop WinRM setup down to the bottom to match what we're doing with SSH already. This also means that it will run after the update.bat script via  the post install updates script, which is now included on the floppies for this very reason

fixnetwork.ps1 is deleted since it wasn't actually necessary. The script sets all interfaces to the work profile so that WinRM will work. This isn't necessary as we set the interfaces to work in all our desktop autounattend.xml configs

We were trying to start SSH and also dropping off SSH keys on WinRM only boxes. Remove all those scripts on the WinRM boxes. This should probably be added to a single zz_setup_transport.bat script which would handle both based on a variable, but that's for another day

Other minor changes:

Order the scripts in the floppy section so they can be diff'd easier

Fix some bad logging in the winrm setup script that resulted in funky output

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

I misunderstood exactly how this was occurring. The real fix is to rename the start sshd script to be a start-transport script since that's what it's doing. It includes winrm and properly runs last.


Parameter maximum value

When adding a parameter (i.e. per_page), is there a way to set the maximum value?
The cleanest (only) way I've found so far is to pass the entire array of possible options:
optional :per_page, values: [*1..100], default: 10, type: Integer
Is there a better way to achieve this?

I'll label this as a feature request to support min and max, obviously there be dragons for non enumerable types ;)

#1568 added a new feature to the ValuesValidator that allows a Proc to be supplied for anonymous custom validations.  Using this, your example above might look like this.
optional :per_page, values: { proc: ->(v) { v.positive? && v <= 100 } }, default: 10, type: Integer

I should note that the ValuesValidator already accepted Ranges, so you also could have done this.
optional :per_page, values: 1..100, default: 10, type: Integer

For both your original example and my Range alternative, the validator will call include? on the passed value.  And, in both cases, that could result in up to 100 individual tests as it enumerates the Array or Range to determine whether the supplied value is a member.  This is probably not catastrophic with a relatively small Range, but doing something like 0..1000000 could cause some performance problems.
A way to avoid this is (again) to use proc to test using cover? instead of include?, which will instead check that the value is between the endpoints of the range.
optional :per_page, values: { proc: ->(v) { (1..100).cover? v } }, default: 10, type: Integer

Should we close this?

@jlfaber Thanks, that's a big help.
@dblock Yes, this looks like a valid workflow for this.


WinAppDriver does not recognize some properties on Window Server 2016

Hi Team,
I found some differences when running my tests on Windows Server 2016. Some attributes that have values on Windows 10 have empty values on Windows Server 2016. Is there any way to get those tests working on Windows Server 2016 o Windows server 2019?
Any help will be highly appreciated.

Does inspect.exe identify the properties?

Does inspect.exe identify the properties?

No. It doesn't.

Then it will Win app driver will also not work

Is there any OS related issue/difference you know of?

That is the way it has been implemented if the SW is under your control you can ask them to to expose controls

Understood but why values for those properties have the expected value on Win10 but no on Win2016?


Feature Request: Expose target:distance and origin:distance roll options to all checks

As title states. Requesting to have target:distance and origin:distance roll options exposed for all checks.
For my specific use case:
The lantern implement specifies "The lantern's magical light attempts to reveal the unseen. You and your allies in the lantern's area of bright light gain a +1 status bonus to visual Perception checks to notice anything that is also within the bright light, and a +1 status bonus to checks to [Recall Knowledge] against creatures within the bright light"
This (the bright light of the lantern) can be faked with rule elements and roll options since we know the radius of the bright light.

We currently have no way of identifying targeted checks besides attack rolls.

Fair enough, I have a janky workaround for it which will suffice


Brilliant Todo List Idea for TabWrangler

I still sometimes have problems focusing on one thing because of the right workflow even though I know about the right tools
There are times when I open a new tab to not forget to do something and wait for it to load and end up with too many tabs. Thankfully TabWranlger comes in and rescues me by taking them away.
I think something interesting would be if there was a shortcut that opened a new tab where I type what I want to do and then by pressing enter it gets wrangled as the next thing to do but reminding me to finish what I need to do and not worry about why I was going to open a new tab after I finish.
I can then easily open TabWrangler and see what I was going to do next.
I realize the ultimate problem is that we use new tabs as things to do, like a to-do list, and instead of loading the page TabWrangler could store the thing to do. Then when I open it again the to-do shows in fullscreen and I remember the new site I was going to go to and continue from there.
Thanks, very interested on your input

This sounds like a great idea, and I'd be curious to see an extension that enables a todo list based on tabs. This is beyond the scope of Tab Wrangler at the moment though; TW closes tabs based on a time interval and keeps a list of the tabs it closed. Since I have limited time to continue developing this extension, I'd like to keep its feature set tightly scoped until another volunteer who has more time to devote is able to explore interesting ideas like this one.
I appreciate the issues you open, please keep them coming.

Yea TabSnooze actually does this, but except TabSnooze has a different purpose. I found that having the shortcut to wrangle a tab, sort of does the job. So I don't really mind if this feature is implemented a while from now. I now just make a google search and just wrangle the google search, wrangle it and get back to it later. So honestly not sure if this is even necessary. But glad you like the idea

I appreciate the issues you open, please keep them coming.

Sure thing


roles not specified

Please for each command specify what roles are needed to execute the command.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e390289-90cc-30e2-de78-33b080f9c27d
Version Independent ID: df152c25-2434-0831-46b7-e9d0e3015f06
Content: az webapp config hostname
Content Source: latest/docs-ref-autogen/webapp/config/hostname.yml
Service: app-service-web
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@btardif is there some existing documentation we can point to for RBAC support for our APIs?
In general if a given RBAC acces doesn't work the command throws an error indicating the same.

please refer to the documentation - closing this since there is nothing we would fix here from CLI command perspective.


Registry::ElementNotFoundError not raised anymore if relation does not exist

rom-rails is now failing on Travis, e.g. here, because the database backing relations does not exist yet when running the app:db:schema:load task. Previously this problem was countered by catch Registry::ElementNotFoundError.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

And by "now", I mean after #106 was merged ;-)

I'm working on it but it's tricky. Now we end up with Sequel error because we try to access a dataset immediately. I have some ideas how to fix it. I will send a PR because I don't feel strong about the solution :/

This was fixed via this commit in rom-sql


DCIM Custom Field Search - Returning Wrong Info

Issue type
[ ] Feature request
[x] Bug report
[ ] Documentation

Environment

Python version:  Python 3.5.2
NetBox version:  2.1.4 (updated - previously wrote down wrong version of 2.0.5)

DCIM Custom Field Search - Returning Wrong Info
I setup a custom field to maintain our support contract information for each of the devices. I originally had 3 choices setup. I then got a bigger list of contracts and am now up to 13. When I search for devices in a field that I state has one coverage, devices with "Needs Coverage" show up. I click into the device and it has the custom field setup properly. When checking the API, it also reports the proper field back. However when I search for devices of each field type, they are showing up in the wrong place.
####Steps to Reproduce:

Click on Devices -> Devices
Go down the right hand column and select the drop down of the custom field (drop down field)
Search for devices, and devices with that custom field setting show up.

Please upgrade to the most recent release of NetBox (v2.1.4) to see if that resolves your issue.

Sorry Jeremy, I am at 2.1.4. Something got in my mind that I was a little ways back.
(v2.1.4)

@vanderaaj Could you please extend the steps needed to recreate this? Be sure to outline the process of creating the custom field first.

Do my best.

Created DCIM custom field on the Django admin page as a field selection custom field. I believe that I did that with 2.1.4
Added 3 fields to select (I thought there were only 3 service contracts)
I added a few devices to have the service contract

Then I found about 10 more service contracts
4) Went back into the Django admin console and went to the custom field
5) Added the additional 10 service contracts to the field
6) Created script to change the service contract field based on a spreadsheet with the contract information on it
7) The fields that are showing up duplicate are "Not Covered" and "Product name that starts with N.."

The remaining contract fields all start with a custom number

@vanderaaj You'll need to provide specific values for every field in the reproduction. You'll also need to provide the exact script that you ran; otherwise, we have no idea what was modified.

@jeremystretch makes perfect sense to me about wanting the full data, is there a method to get those communicated that isn't all over a Github public page? With this being our contract information, probably best to not have those contract numbers showing up.
I'm almost thinking that it may have been something with adding in additional contracts after adding data. Or else, just an input error on my part. I'm all for getting the data if it will help the community in the future. But if it is just to try to fix one individual user issue, I'm good with deleting and recreating the custom field. I've automated the process of getting each device into that field, so that isn't much work.

@vanderaaj

is there a method to get those communicated that isn't all over a Github public page?

All development activity is tracked publicly. You'll need to detail the steps needed to recreate the bug using sanitized or fabricated data. Starting up a separate instance of NetBox running a fresh installation is a good idea.

All good on the public dev. I thought a previous comment wanted the real live data. One more attempt...

Go to User Account on top right and select drop down to Admin
Click Add under Custom Fields
Create Custom Field as follows:
a. Object: "dcim > device"
b. Type: "Selection"
c. Name: "support_contract"
d. Label: "Support Contract"
e. Description: "Support Contract Information"
f. Required: Unchecked
g. Is filterable: Checked
h. Default: Blank
i. Weight: "100"

Custom Field Choices Set
Value: "NationalCoverage"
Value: "44223355: 8x5xNBD"
Value: "44223355: 24x7x4"
Set approximately 12 devices to the 3rd value, then I found more contracts.
Followed the same process to get into the dcim custom field.
Then added the following options
Value: "202438275: 8x5xNBD"
Value: "202438705: 8x5xNBD"
Value: "202531453: 8x5xNBD"
Value: "84284102: EMER"
Value: "93583721: P2E"
Value: "94283751: EMER"
Value: "94678217: PEA"
Value: "Needs Coverage"
Then I had a CSV file with device, contract and used the API to assign a contract to the device.
Then some devices that have the NationalCoverage contract show up in a query for
devices in Needs Coverage. When going into the device, it shows properly. The
search page just displays incorrectly.

When going into the device, it shows properly. The search page just displays incorrectly.

Please provide the query you're using to search.

Devices -> Devices, Scroll down the right hand search filter to Support Contract custom field drop down. Selecting NationalCoverage and then devices with Needs Coverage show up in the search.

I think I know what's happening. The PK for the "NationalCoverage" option is 1, and the PK for the "Needs Coverage" option is 11. The query is filtering on ?cf_support_contract=1, which is being evaluated as:
custom_field_values__serialized_value__icontains=1

This matches both serialized values 1 and 11. We need to modify the filter to only match on exact values for select fields.


644 Do not calculate total directory size unless it will be displayed

Addresses https://github.com/Peltoche/lsd/issues/644.
Any suggestions for how to implement a test for this?

TODO

[x] Use cargo fmt
[ ] Add necessary tests
[ ] Add changelog entry
[ ] Update default config/theme in README (if applicable)
[ ] Update man page at lsd/doc/lsd.md (if applicable)

Codecov Report

Merging #646 (4c775de) into master (7e49ca7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   86.43%   86.42%   -0.02%
==========================================
  Files          39       39
  Lines        4240     4242       +2
==========================================
+ Hits         3665     3666       +1
- Misses        575      576       +1

Impacted Files
Coverage Δ

src/core.rs
0.00% <0.00%> (ø)

src/flags/blocks.rs
92.98% <0.00%> (-0.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e49ca7...4c775de. Read the comment docs.

how about adding a test for displays_size like https://github.com/Peltoche/lsd/pull/646/files#diff-8992e6e5f254bdfb40335a8538fbcf0f0d77baba1b2f09b4358ab8c69aa344beL264
and add an integration test to check the functionality like https://github.com/Peltoche/lsd/blob/master/tests/integration.rs#L387

Hi @zwpaper! Looking at the integration tests it looks like they all run the command and verify the output. The change here is that we won't run a calculation that is currently not being displayed. This change can't be tested or detected by looking at the output of the command.
Maybe I can do the following?
impl Flags {
  fn should_calculate_total_size(&self) -> bool {
    self.total_size.0 && self.blocks.displays_size()
  }
}

Then maybe I can test the value of should_calculate_total_size given different configurations. My only concern is that the decision is not really a concern for Flags  but rather Core


s_client -proxy / -starttls are mutually exclusive

The option -proxy of openssl s_client works fine. The option -starttls also works fine. However, try putting both of them on command line. It breaks, these options don't work together. The problem is that -proxy option is implemented using starttls_proto (the option parsing code sets it to PROTO_CONNECT) and -starttls option overwrites the same variable again based on argument value. The suggested fix is to independently handle -proxy option before -starttls so the s_client can connect through HTTP proxy server and then use STARTTLS command.

We would need a CLA signed as this is IMO slightly outside of what we accept with CLA: trivial. https://www.openssl.org/policies/cla.html

Not sure whether this is a feature or a bug fix eligible for backport.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

Still working on (corporate) CLA.

Resolved, sorry for delay. CLA is now signed and sent via email.

@batrla you also need to fill in an ICLA.  We've received an update to Oracle's CCLA that covers you.

@batrla you also need to fill in an ICLA. We've received an update to Oracle's CCLA that covers you.

You should have received also ICLA. I signed & sent it about an hour ago to<EMAIL_ADDRESS>

Okay, haven't seen it yet.  It can take a bit of time.

Merged to master and 3.0 branches after adjusting the commit message slightly.


cannot enable project level monitoring - 2.2.3

We have two 2.2.3 clusters (previously were 2.2.2).  I've tried enabling project level monitoring , but each time get errors.

we have cluster level monitoring enabled, and it seems fine btw.

Project monitoring was temporarily disabled in 2.2.2 and 2.2.3. It is back in 2.2.4:
https://github.com/rancher/rancher/releases/v2.2.4
Closing the issue

thanks. works great!


Factor out MaterialLocalizations now that it depends on intl

With DatePicker localized, we'll have moved all our intl dependencies into one class, MaterialLocalizations, at which point we should factor it out into its own package so that people don't have to pay any of that cost if they don't want our localization logic. (The default localization for English can just have hard-coded logic for thousands separators, etc).
Suggestion from @HansMuller (entered here by @yjbanov):
Assuming that TimeOfDay isn't exclusively for the material time picker, we should consider moving it and the corresponding material localization code, to the widgets library and the WidgetsLocalizations class.

FYI, added a suggestion from @HansMuller to the description, based on discussion on https://github.com/flutter/flutter/pull/12166.


Is it possible to set a http_proxy in website agent?

Is there a way to make setting up a proxy easier? For example instead of re-exporting the .env just to put a http_proxy to the website-agent (similar to user_agent)? If yes, how can I check this. Thanks.

From the code it looks like setting the proxy option should work.

Thank you! Seems to work.