Fix #120 - Build on Mac with python3

Reference/Link to the issue solved with this PR (if any)
Issue #120 - build on Mac with Python3 fails to find boost-python
Description of the problem
setup.sh uses brew to install boost-python, but the version
that landed was for python2.7. Brew has two packages,
boost-python and boost-python3.
Description of the solution
For builds against python{3.4,3.5,3.6}, install boost-python3.
Description of the problem
build.sh invokes CMake, which uses the three CMakeLists.txt files
changed here.
Description of the solution
When building against python{3.4,3.5,3.6}, strip the period and
append the version when searching for the boost_python* library.
Tested on python 3.6.5 on Mac 10.13.4, with boost 1.67.0,
boost-python3 1.67.0, openssl 1.0.2o_1, cmake 3.11.0 installed.
The c submodule is at commit 248ef1489b15532d2617c95e1feefecba85d88d2
Checklist

[X] I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-python/blob/master/.github/CONTRIBUTING.md).
[no] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
If this is a modification that impacts the behavior of a public API

[no] I edited the corresponding document in the devdoc folder and added or modified requirements.

I submitted this PR against the correct branch:

[X] This pull-request is submitted against the master branch.
[ ] I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
[X] I have squashed my changes into one with a clear description of the change.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: alanjcastonguay sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@alanjcastonguay
Please fix the unit tests. They are failing with error:
http://azure-iot-gate.westus.cloudapp.azure.com:8080/job/python-OSX-X86/205/console
Best Regards,
Zoltan

@zolvarga - I can't see that resource; Jenkins says "alanjcastonguay is missing the Overall/Read permission"


Add catalog-info.yaml for Backstage

This pull request adds a Backstage entity metadata file to this repository so that the component can be added to the Staffbase Backstage App software catalog.
After this pull request is merged, the component will become available.
To make ownership visible add a CODEOWNERS file to this repo.
Feel free to make changes to the file. For more information, read about the descriptor format of catalog entities.
If you want to have additional information about Backstage, do not hestiate to get in contact with @Staffbase/diablo.

I have read the CLA Document and I hereby sign the CLA

recheck


Add swashbuckle

I see two warnings at line 125 of startup.cs stating that "DescribeAllEnumsAsStrings" is obsolete. Can this usage be corrected?

Unfortunately, to my understanding, this needs to be used due to the project is using Newtonsoft JSON serialization. Based on this thread (https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/1269) the new method that replaced the "DescribeAllEnumsAsStrings" is as of now just supported for the .NET built in JSON serialization and for Newtonsoft we need to still rely on the obsolete method.

I see two warnings at line 125 of startup.cs stating that "DescribeAllEnumsAsStrings" is obsolete. Can this usage be corrected?

Unfortunately, to my understanding, this needs to be used due to the project is using Newtonsoft JSON serialization. Based on this thread (domaindrivendev/Swashbuckle.AspNetCore#1269) the new method that replaced the "DescribeAllEnumsAsStrings" is as of now just supported for the .NET built in JSON serialization and for Newtonsoft we need to still rely on the obsolete method.

OK! I will merge the PR for now then.


Fix unguarded unregistration

Short description of what this resolves:
Not having this guard in place forces awkward testing practices, such as injecting NavControllers with mocked register/unregister methods just so the ngOnDestroy doesn't throw exceptions.
Changes proposed in this pull request:
Put guards against null parent
Ionic Version: 3.x
This bug is also present in Ionic 2.x but a separate pull request will be created.

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


Status code check

Sometimes api return error page instead of response
For example 400 bad request if you trying call GET method with long params(thats why also need to add method select https://github.com/vladkens/VK/pull/14)

Nice idea, but this breaks backward compatibility :(


update pyuavcan lib version and name

After updating uavcan python library, libuavcan_dsdlc stopped working with import error: ImportError: No module named uavcan.
In this PR I simply renamed uavcan lib to pyuavcan_v0 and updated pyuavcan submodule because as I understand previous version had different dsdl path. Now it seems to be ok.

@coderkalyan does it look okay to you?


Add unit test (webhook/config/config_test.go)

What problem does this PR solve?
Add unit test (webhook/config/config_test.go)
What is changed and how does it work?
Check List
Tests

Unit test

Code changes

Has Go code change

Side effects

NO

Related changes

NO

Does this PR introduce a user-facing change?:
NONE

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@69fec19). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #268   +/-   ##
=========================================
  Coverage          ?   39.89%
=========================================
  Files             ?       34
  Lines             ?     1529
  Branches          ?        0
=========================================
  Hits              ?      610
  Misses            ?      844
  Partials          ?       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fec19...e734353. Read the comment docs.

please resolve conflict @fewdan

/test

/test

@lucklove PTAL

/test


v2.ODataModel (1.26.6) submitChanges callbacks without BatchMode [Feature Request]

Currently the documentation says:

Important: The success/error handler will only be called if batch support is enabled!

Our PHP OData layer currently does not support batch requests. Our HANA SP85 does not support batch(MERGE) (hopefully SP90 will do) so i am not able to use the batchMode.
My CRUD controller will do a controlled SubmitChanges on Form Button SAVE click.
Currently i am not easily able to have a fnCallback for success/error on this!!!
I think we need a promise like callback collector that will do the job if all updates are fullfilled.
From my opinion the work for doing this leads to the currently missing implementation, or what is the reason?
Is this support on your roadmap?
Cheers Holger

Hi Holger,
I asked the responsible developer to have a look.
Cheers
Andreas

Hi Holger,
while the success/error handler of the submitChanges method are not called, if multiple CRUD requests are contained, the individual success/error handlers of each contained read/update/remove method will be called when submitChanges is executed. Isn't that sufficient for your need?
Regards,
Malte

Hi Goligo,
i will try if i can use hasDependingChanges also with oModel.update()
                 if (_bHasPendingChanges) {
                    oModel.submitChanges({ // does not work
                        success : function(oData) { // does not work without batch
                            console.log("submitChangesSuccess", oData);
                        },
                        error : function(oError) { // does not work without batch
                            console.log("submitChangesError", oError);
                        }
                        //eTag : ""
                    });
                    console.log("saveModel", oModel);
                } else {
                    console.log("no pending changes...");
                }

I will try oModel.update(sPath, oData, mParameters?) instead.
Will have a look if i can get the changed/binded (oData) data easily from v2Model

sPath (easy like "/UmeUser(1)")
oData (needs to know how to get oModel.getData/getObject for current path

Will see if this will work for me.
I will not manually collect all data from Input fields.
Cheers Holger

Hi Holger,
did it work?
If yes, please let us know so that we can close this issue.
If not, please follow up with us to further analyze it.
Cheers,
Michael

Hi Michael,
i just tried it out and get to know, that i did not understand the hint from Malte.
My current approach is also to use
this.getView().getModel().createEntry(sCreatePath, {});
to create a new entry like
UmeUsers('id-1426694995628-2')
It would be cool to use oModel.submitChanges() in this case (CREATE/ADD) also.
A manually update via
oBindingContext.getModel().update()
catches the correct error/success handler, but leads to some ugly side effects like errors on expanded navigation properties (because deep updates are not supported).
This works well inside .submitChanges().
So i had to manually things like
delete oEntry.UmeAccount;
How can i use oModel.submitChanges() with all the nice benefits but without batching.
How can i attach the the individual success/error handlers of each contained read/update/remove as Malte explained.
Any help would be greatly appreciated ;-)
Cheers Holger

I would also love to use submitChanges() while having my success/error functions called without using batch (I'm using ASP.NET Web API OData v1-3 package which does not support this).
I'm sure internally, you'd need to aggregate each request that is sent and completed before calling success/error callbacks.
Is there a reasonable alternative to find which sPath entries within the ODataModel are marked as pending changed (rather than entire model) so that we could loop through each key and call create/update/delete manually?

HI,
Did anyone solve this issue or is there a known workaround for it?
Regards, Alex

A question to people watching this issue: How would you expect the success/error handler to be called, if batch is not enabled? Often there are multiple requests triggered when calling submitChanges. Would you expect it to be called separately for each request which is sent, or do you expect a single success/error callback? If you expect a single success/error callback, do you expect the error-callback only if all requests failed or if one of the contained requests failed?

have any solution to call the Success or Error handlers for submit changes.. Please let me know ASAP.

After reading the explenation and posts here I have to say I don't really see a need for callbacks from submitChanges. The documentation on the other hand would benifit greatly from some explanation of the rationale behind the decision.
Anyway for anyone else comming here looking for a solution, hooking up the delegates on the individual methods work:
oModel.createEntry("/OrderSet", { success: function(oData, oResponse) {
	alert("Success!");
}, error: function(error) {
	alert("Error!");
}});
oModel.submitChanges();

Hi @hschaefer123 @ramu6984,
is the proposal by @t0PPy works for you?
ilhan

Looks good!
;-)

I was asked here to elaborate here for a callback, here we go:

odata 2.0
Two-Way-Binding
Batch=true

user can change multiple values in multiple linked entities, all bound to the xml view (e.g. a survey form with multiple questions)
There is a print button, which generates a pdf on the backend
we must save all input before printing, to create a matching pdf
app should set a busy indicator, while saving

Now we have this situation(user is pressing print):

if there are changes, we can set busy before submit and it works as expected
if there are no changes, nothing happens, view will stay busy.
Because of a bug https://github.com/SAP/openui5/issues/1756, there is no way to determine if we have to call submitChanges(), without accessing private accessors.

So it would be great to have one callback, called every time; Independent of error, success as requested here( https://github.com/SAP/openui5/issues/1755)

@bkrr I meant to use the issue you opened as this one is closed. I will copy the details in https://github.com/SAP/openui5/issues/1755 and we can continue in it.


getT call from goroutine

The idea is very smart, unfortunately it will not convert all cases for example following case where the getT function is called from goroutine.
func TestGetTInGoroutine(t *testing.T) {
	t.Run("fistTest", func(t *testing.T) {
		go func() {
			tt := getT()
			if tt != nil {
				tt.Fatal("log from goroutine")
			}
			// test will silently pass.
		}()
	})
}

This is specifically disallowed because the testing package requires that t.Fatal be called from the main testing goroutine.
Closing, sorry.


Entity delete error

server/src/datastore.js line: 73
Error: datastore.intValue is not a function.
Should use datastore.int instead.

@GabiAxel Could you push the fixed version to npm? Thanks.


New version: GiulioSorrentino.numeronesfortuneinavalonia version <IP_ADDRESS>

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

2024-12-27 13:28:27.450 [FAIL] Installer failed security check. Url: https://github.com/GiulianoSpaghetti/numfortune.avalonia.new/releases/download/2.0.4/numfortune.Avalonia-<IP_ADDRESS>-amd64.msi Result: 0x80004005 MSI (s) (9C:AC) [13:28:07:664]: Executing op: ComponentRegister(ComponentId={AD320266-F7AB-5CDE-8889-6FB989C181EC},KeyPath=2285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\9.0.0\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=1) MSI (s) (9C:AC) [13:28:08:336]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=1,,) Property(S): ErrorDialog = ErrorDlg MSI (s) (9C:AC) [13:28:08:430]: Windows Installer installed the product. Product Name: Microsoft .NET Runtime - 9.0.0 (x64). Product Version: 72.0.23369. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. Property(S): ErrorDialog = ErrorDlg MSI (s) (9C:08) [13:28:08:664]: Windows Installer installed the product. Product Name: Microsoft .NET Host FX Resolver - 9.0.0 (x64). Product Version: 72.0.23369. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. Property(S): ErrorDialog = ErrorDlg MSI (s) (9C:48) [13:28:08:914]: Windows Installer installed the product. Product Name: Microsoft .NET Host - 9.0.0 (x64). Product Version: 72.0.23369. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. Property(S): ErrorDialog = ErrorDlg MSI (s) (9C:9C) [13:28:10:570]: Windows Installer installed the product. Product Name: Microsoft Windows Desktop Runtime - 9.0.0 (x64). Product Version: 72.0.23378. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0.

(Automated response - build 931.)

Manual Validation ended with:

2024-12-27 13:32:59.497 [FAIL] Installer failed security check. Url: https://github.com/GiulianoSpaghetti/numfortune.avalonia.new/releases/download/2.0.4/numfortune.Avalonia-<IP_ADDRESS>-amd64.msi Result: 0x80004005 MSI (s) (B4:28) [13:32:38:703]: Executing op: ComponentRegister(ComponentId={AD320266-F7AB-5CDE-8889-6FB989C181EC},KeyPath=2285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\9.0.0\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=1) MSI (s) (B4:28) [13:32:39:390]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=1,,) Property(S): ErrorDialog = ErrorDlg MSI (s) (B4:28) [13:32:39:484]: Windows Installer installed the product. Product Name: Microsoft .NET Runtime - 9.0.0 (x64). Product Version: 72.0.23369. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. Property(S): ErrorDialog = ErrorDlg MSI (s) (B4:24) [13:32:39:734]: Windows Installer installed the product. Product Name: Microsoft .NET Host FX Resolver - 9.0.0 (x64). Product Version: 72.0.23369. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. Property(S): ErrorDialog = ErrorDlg MSI (s) (B4:D0) [13:32:39:999]: Windows Installer installed the product. Product Name: Microsoft .NET Host - 9.0.0 (x64). Product Version: 72.0.23369. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. Property(S): ErrorDialog = ErrorDlg MSI (s) (B4:B8) [13:32:41:718]: Windows Installer installed the product. Product Name: Microsoft Windows Desktop Runtime - 9.0.0 (x64). Product Version: 72.0.23378. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0.

(Automated response - build 931.)

@wingetbot run


QC: Feedback and reported issues

Reported issues from data providers

When uploading our data, it passes the screening with no errors, but when we select 'import cetaceans data to the database' an error message occurs

I emailed<EMAIL_ADDRESS>several times to request the R script, but have never had a reply so we are still waiting for this

We have emailed Joana regarding the missing vessels, but again no reply and the vessels are still not in the database - these were requested back in January.

The Data Standard says the abstract (in the identifiers table) can be a maximum of 500 words but the data rules on the portal limit it to 500 characters @NikiClear to update the data standard

Duplicate sighting status is mandatory even for single platform surveys, although this is supposed to be conditional for double platform surveys

Data rights holder isn’t actually free text as it states in the Data Standard, it is actually an EDMO code

Milling/non - directional behaviour and Globicephala and Balaenopteridae AphiaIDs: for these, you have to reselect every one from the dropdown menu even though they’re in exactly the same format and this is very laborious. Can this be looked into please so it automatically selects them from the dropdown when entered, like the other values do?

Survey with no sightings has failed validation and not able to upload, the system should accept surveys with no sighting records.

a.	This was caused by an internal call to a service as there were new species to be added to the DB from Lucy’s data; we didn’t catch this in testing as we worked with a file that had species that were already known to the database. NOW FIXED
b.	R script for bulk upload: we only have it for another data portal, JNCC was tasked with looking for resources to do this for Cetaceans
c.	Vessels; we are in process but this takes time as we need to get NOAA to approve, and they often do this in bulk at periodic intervals.
d.	Word/Character limit on Survey Abstract field (identifiers); Joana will change in data format (DATSU) to 8 000 characters (we can’t limit by words);  NOW FIXED
e.	Duplicate sighting – conditional mandatory; We think the data standard field should be ‘mandatory’ (as it is a vocab) and as it is in the template (the sighting number is conditional optional depending on the answer to duplicatesighting status).
f.	DataRightsHolder – we think we agreed to the EDMO, but we can’t find any documentation on that, can we confirm in next sprint
g.	Milling/non directional behaviour and Globicephala and Balaenopteridae AphiaIDs; @pcrjoana to have a dedicated session with Lucy to understand what she wants (not clear from description)
h.	Survey with no sightings; this was not anticipated as we agreed to have the whole sightings record as mandatory, not optional. To discuss at next sprint, it can be changed to optional if this scenario should be included.

a. This was caused by an internal call to a service as there were new species to be added to the DB from Lucy’s data; we didn’t catch this in testing as we worked with a file that had species that were already known to the database. NOW FIXED
b. R script for bulk upload: we only have it for another data portal, JNCC was tasked with looking for resources to do this for Cetaceans
c. Vessels; we are in process but this takes time as we need to get NOAA to approve, and they often do this in bulk at periodic intervals.
d. Word/Character limit on Survey Abstract field (identifiers); Joana will change in data format (DATSU) to 8 000 characters (we can’t limit by words); NOW FIXED
e. Duplicate sighting – conditional mandatory; We think the data standard field should be ‘mandatory’ (as it is a vocab) and as it is in the template (the sighting number is conditional optional depending on the answer to duplicatesighting status).
f. DataRightsHolder – we think we agreed to the EDMO, but we can’t find any documentation on that, can we confirm in next sprint
g. Milling/non directional behaviour and Globicephala and Balaenopteridae AphiaIDs; @pcrjoana to have a dedicated session with Lucy to understand what she wants (not clear from description)
h. Survey with no sightings; this was not anticipated as we agreed to have the whole sightings record as mandatory, not optional. To discuss at next sprint, it can be changed to optional if this scenario should be included.

RESPONSE:
b - R script- this had completely left my brain but now you mention it...I remember. We'll take this internally and see if we can convince our coders to take it on!
c. vessels - possibly a small communication error here, I thought Lucy was still in the process of sorting the details with Joana, rather than it be a case of waiting for NOAA to add them. If the latter is the case, not much we can do, although if there is a way to speed that up it would be fab as Orca are poised to get their data in.
e. duplicate sighting would be best as conditional, based on selecting double platform methodology. Otherwise all non double platform methods will have to complete this extra step with zeros.
f. datarightsholder - definitely free text! The datacustodian is the only one required to have an EDMO. This is to reduce the burden on data rights holders who have very little to do with their data, and commission it for e.g. offshore industry. Additional requirements to get an EDMO could be offputting and result in data not being submitted.
h I think we will have to make it optional as there will be some surveys with no sightings.

@NikkiTaylorJNCC  regarding e: if it's not a double platform, they can just enter that it is not a duplicate sighting and fill the record without any issue. If in DuplicateSightingStatus "No" is entered, DuplicateSightingNumber is not required. Do you still want to have DuplicateSightingStatus as conditional? To me it doesn't make much sense, because if it's not a duplicate, they have the option to enter "No".

@NikkiTaylorJNCC regarding e: if it's not a double platform, they can just enter that it is not a duplicate sighting and fill the record without any issue. If in DuplicateSightingStatus "No" is entered, DuplicateSightingNumber is not required. Do you still want to have DuplicateSightingStatus as conditional? To me it doesn't make much sense, because if it's not a duplicate, they have the option to enter "No".

@pcrjoana we can do either, but my thoughts were that if we make it conditional at the methodology stage, they don't have to worry about the extra step of filling out the duplicatesightingstatus as that has no relevance to non-double platform methodologies. But to be honest, i'm happy with the path of least resistance! Whatever is simpler to do, either make duplicatesightingstatus conditional based on double platform methodologies being selected, or make duplicatesightingstatus mandatory and maybe I need to try and make it clearer that non-double platform methods need to enter 'no' across the board here.

f. - done
h. - sightings record is now optional

@NikkiTaylorJNCC regarding e: if it's not a double platform, they can just enter that it is not a duplicate sighting and fill the record without any issue. If in DuplicateSightingStatus "No" is entered, DuplicateSightingNumber is not required. Do you still want to have DuplicateSightingStatus as conditional? To me it doesn't make much sense, because if it's not a duplicate, they have the option to enter "No".

@pcrjoana we can do either, but my thoughts were that if we make it conditional at the methodology stage, they don't have to worry about the extra step of filling out the duplicatesightingstatus as that has no relevance to non-double platform methodologies. But to be honest, i'm happy with the path of least resistance! Whatever is simpler to do, either make duplicatesightingstatus conditional based on double platform methodologies being selected, or make duplicatesightingstatus mandatory and maybe I need to try and make it clearer that non-double platform methods need to enter 'no' across the board here.

I kept it mandatory, and added the guidance that "No" should be filled in when single platform methodologies are used. Path of least resistance. ;-) They only need to fill that field with "No", as the other fields related to duplicate sightings are conditional on the basis of it being "Yes" or "Probable" (this condition is already impletemented).

v2.03 of data template live on web addressing the issues above;
will wait for next sprint before concluding and closing issue.


Improve readme and change log

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
-

👍


[Infra] Release .NET package to NuGet automatically when version changes

When the version changes in the main branch, automatically build and release the .NET packages to nuget.org

Completed.


policy for direct interaction and colocalization

Curation policy should be refined for the assigment of
this 2 interaction types:
- for Colocalisation see request 1397882 second case
(in summary can we consider that mass spec experiment
on very narrow subcellular area are detecting complexes?)
- for direct interaction we propose that only in vitro
interactions with both partner purified prior
interaction are direct interaction.
Reported by: luisa_montecchi

thanks www.movied.org


Problem with mouse events on edge on version 3.0

Hi :)
I am migrating my code to version 3.0 and I hit a wall in edge (works well in chrome) where the canvas objects don't respond to mouse events like onmouseover. Making it impossible for the user to select nodes.
While debugging I found that when I click on a node, the click event that is raised is for the diagram canvas div.

It was a cache issue :)

It was a cache issue :)


Fixed scroll in firefox

The scroll in firefox is binded to the documentElement instead the body.

Coverage decreased (-0.1%) to 37.743% when pulling 85f420a9d5d72244748cacc51053b104b7649eb1 on oscarotero:patch-1 into 95a8408082a3ed038defa09460e374f8ad39f6d9 on luruke:master.

Thank you @oscarotero


how to get universal-link params ?

i have  universal-link, when i  open  my website in gmail , it opened my app, but i cannot listen to  event open the link.
i don't use  [firebase dynamics link ]

@wangxingxing123654
Your question is better suited for StackOverflow, as this repo is to track bugs and feature requests. Please see https://flutter.dev/community for resources and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing from here.


Fix PolyphonicSequence.set_length on partial sequences (without END)

_trim_steps() mistakenly assumes sequences always end with an END event and skips the last event. However, while generating sequences, it is possible to call set_length() on unfinished sequences and _trim_steps() would fail as the last event would be STEP_END instead.
Also add test cases to cover this.

An example failure happened here. The full traceback:
WARNING:tensorflow:No priming sequence specified. Defaulting to silence.
INFO:tensorflow:hparams = {'rnn_layer_sizes': [256, 256, 256], 'decay_rate': 0.95, 'dropout_keep_prob': 1.0, 'batch_size': 1, 'decay_steps': 1000, 'clip_norm': 5, 'initial_learning_rate': 0.001, 'skip_first_n_losses': 10}
WARNING:tensorflow:<tensorflow.python.ops.rnn_cell.BasicLSTMCell object at 0x7f27065cad50>: Using a concatenated state is slower and will soon be deprecated.  Use state_is_tuple=True.
WARNING:tensorflow:<tensorflow.python.ops.rnn_cell.BasicLSTMCell object at 0x7f2703a73690>: Using a concatenated state is slower and will soon be deprecated.  Use state_is_tuple=True.
WARNING:tensorflow:<tensorflow.python.ops.rnn_cell.BasicLSTMCell object at 0x7f2703a73510>: Using a concatenated state is slower and will soon be deprecated.  Use state_is_tuple=True.
INFO:tensorflow:Checkpoint used: /magenta-data/leo3/train/model.ckpt-10
INFO:tensorflow:Need to generate 120 more steps for this sequence, will try asking for 600 RNN steps
INFO:tensorflow:Beam search yields sequence with log-likelihood: -2083.229592
Traceback (most recent call last):
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.py", line 262, in <module>
    console_entry_point()
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.py", line 258, in console_entry_point
    tf.app.run(main)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 43, in run
    sys.exit(main(sys.argv[:1] + flags_passthrough))
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.py", line 254, in main
    run_with_flags(generator)
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.py", line 224, in run_with_flags
    generated_sequence = generator.generate(primer_sequence, generator_options)
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/music/sequence_generator.py", line 204, in generate
    return self._generate(input_sequence, generator_options)
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/models/polyphonic_rnn/polyphony_sequence_generator.py", line 134, in _generate
    poly_seq.set_length(total_steps)
  File "/magenta/bazel-bin/magenta/models/polyphonic_rnn/polyphonic_rnn_generate.runfiles/__main__/magenta/models/polyphonic_rnn/polyphony_lib.py", line 172, in set_length
    assert self.num_steps == steps
AssertionError

With this fix, the assertion holds and the generation works as expected.

I signed it!

Wow, that was a fast fix! Thanks!


Does not compile bacause of hillbig/rsdic interface change

Errors
# github.com/hillbig/waveletTree
..\github.com\hillbig\waveletTree\waveletMatrix.go:206: cannot use rsdic.New() (type *rsdic.RSDic) as type rsdic.RSDic in assignment
..\github.com\hillbig\waveletTree\waveletMatrixBuilder.go:25: cannot use rsd (type *rsdic.RSDic) as type rsdic.RSDic in argument to f
ilter
..\github.com\hillbig\waveletTree\waveletMatrixBuilder.go:26: cannot use rsd (type *rsdic.RSDic) as type rsdic.RSDic in argument to f
ilter
..\github.com\hillbig\waveletTree\waveletMatrixBuilder.go:29: cannot use rsd (type *rsdic.RSDic) as type rsdic.RSDic in assignment
FAIL    XXXXX [build failed]

Environment
>go version
go version go1.5.2 windows/amd64
>godep version
godep v46 (windows/amd64/go1.5.2)

Workaround
use older version of rsdic such as:
"Rev": "698921b48c0a2d77cfaa3223083483d5c71dc8f3"

I'm still investigating this....
I'll post any useful info later.


BIP39 Support

Currently freewallet only supports generating addresses using the same method as counterwallet with a different derivation path than BIP39.
Need to update FreeWallet to handle generating addresses in both BIP39 and "Counterwallet" formats.

added BIP39 support with commit d7f78077e2315df454ead2717fdf4c0c895f709d


Commas in function that passed to @macro argument are treating as actual commas.

@macro call(func) { ($func)() }

$call!(fn {
    local a, b = "", false
})

$ clue test.clue
Error in test.clue:3:1!
Error: "Too many arguments passed to macro"

This has already been fixed in 4.0, but I can bring it to 3.0 if/when a new patch happens.
Until then, you could fix the issue by slightly changing the code:
@macro call(func) { $func() }

$call!((fn {
    local a, b = "", false
}))

The fix has been brought back to 3.0 and will be included in the next patch.


Option to launch everything floating by default

I think that launching everything as floating by default, unless set otherwise in the configuration would provide a much smoother experience for me.
Many applications don't work very well in tiled mode, and sometimes even if the main application works, any additonal windows spawned may not work.
I also prefer to work in a more hybrid model, where I don't really want to tile everything, if I open some small utility application for example for temporary use, it's probably easier to just leave it floating, use it and then close. This is also not really application dependent, for some tasks the same application might useful tiled next to the main application. I prefer to just setup the workspaces, for the stuff that I really need, either to be able to see something side by side, or a dedicated workspace for some application that I quickly need to switch to all the time.
I certainly almost never wants those apps to be launched in an existing workspace, since there's probably not enough room for that. And even if you have a dedicated misc workspace, it quickly gets too cramped to be usable.
For these applications the Windows taskbar or alt-tab is efficient enough, the application itself probably has to be driven by mouse anyway, so reaching for the mouse to swich is not really a drawback.
This option would also include not trying to restore everyhting after a reboot, or when nog is started again after an exit. But perhaps that could also be a separate option.

There's a lot here to comment on but to start I'll point out that you can currently get the effect you want (I think) by using min_height and min_width. When a window is created, nog checks its size and ignores anything smaller than those values. If you'd like nog to ignore everything you can just set those values in your config to something large.
nog.config.min_height = 5000
nog.config.min_width = 5000

I think an idea we've talked about in the past was to have a callback that runs on every new window with properties passed in of the window so that you can configure behavior that way, but I don't think we've created an issue specifically for it.
The min_height/min_width might make nog behave like you want now but it might be nice to have something like what I mentioned above too (or instead of)

I think an idea we've talked about in the past was to have a callback that runs on every new window with properties passed in of the window so that you can configure behavior that way, but I don't think we've created an issue specifically for it.

I think you are talking about the event system

Thanks,
I have been running with this workaround for a while now, and it seems to work fine. I'm not fully sure that it's the behaviour I really want though, since many times I would like the window to open directly in tiling mode. But the good thing is that it does not randomly tile popup windows, or even things like Windows store, which I saw getting tiled, even if it was't even open. I also no longer get ghost tiles, due to some window showing quickly and then getting hidden.
So I think a whitelist instead of blacklist would be the ideal, but the event system would of course be event better to fully allow me to customize what I want.


chore(main): release 1.0.2

:robot: I have created a release beep boop
1.0.2 (2024-09-15)
Bug Fixes

docs: update badge URLs in README.md (bf58d17)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.2
:sunflower:


KAFKA-16107 [2/N]: Fix inverted args & more tests

Small fix for argument order in onPartitionsAssigned callback, and more tests for disabling/enabling partitions while callback runs

Hey @dajac , comment addressed and rebased, thanks!

I triggered a new build as the last one timed out.

I was not able to get a clean build of this patch.

Hey @dajac seems like we got a good build now, and test failures are unrelated.


we can only buy the JetRacer component one by one?

Is there any link we can buy all the items in one package?

Hi Dep74,
Thanks for reaching out!  To my knowledge there currently are not any readily available third party JetRacer kits like there are for JetBot.
That said, please let me know if you have any questions or confusion on the bill of materials and I'm happy to help.  The feedback is very helpful for us and other users.
JetRacer or otherwise, I look forward to seeing what project you come up with :)
Best,
John


Dismiss import does not work in Vue 3 + Vite app

Describe the bug
When adding import { Dismiss } from 'flowbite'; to <script setup> script, console returns the following error
caught SyntaxError: The requested module '/node_modules/.vite/deps/flowbite.js?v=a9f96e8c' does not provide an export named 'default'

To Reproduce
Steps to reproduce the behavior:

Create a Vue 3 + Vite app
Install and configure flowbite according to the setup instructions
Try adding import { Dismiss } from 'flowbite'; in App.vue script setup
See error

Expected behavior
It should import the Dismiss class according to https://flowbite.com/docs/components/alerts/#example

Hey @jlariza,
Is this still an issue? Dismiss works with our new Vue guide and and Vue starter repo:

https://flowbite.com/docs/getting-started/vue/
https://github.com/themesberg/tailwind-vue-starter

Cheers,
Zoltan


"Create new issue" should point to .../issues/new/choose

Resolves https://github.com/fluxcd/website/issues/163
Signed-off-by: Rishabh<EMAIL_ADDRESS>

Nice one - well done @rishabh96b :apple:


fUCK YOU!

Environment (please complete the following information):

OS (mac):
Extension version ():fuck!

Describe the bug:

Repro steps:

Expected behavior:

Additional context:

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


patch method should ignore required: true

Description
the HTTP PATCH  method only partially updates an entity. This means that the entity is existing beforehand already. This means, that you can just send one attribute in a body to the PATCH endpoint with having some required fields, and it should still work
Expected behaviour
sending and incomplete body to a PATCH endpoints results in a 200
Actual behaviour
the schema is completely verified, no matter the HTTP method, and therefore throws a 400 because the object is not complete.
Steps to reproduce
add this to your OpenAPI3.yaml:
paths:
  /entity/{id}:
    patch:
      operationId: "does.not.matter.here"
      parameters:
      - name: relational_datasource_id
        required: true
        in: path
        schema:
          type: integer
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: "object"
              required:
              - name
              - connection_id
              - sql
              properties:
                id:
                  type: integer
                name:
                   type: string
                sql:
                   type: string

try now to patch this entity, but only try to update the sql field. connexion will complain that you did not supply the name, but it should not be needed.
Additional info:
Output of the commands:

python --version : 3.7.4
pip show connexion | grep "^Version\: 2.3.0"

Came across this issue recently, any update on this?

This is what readOnly and writeOnly are for.
The spec is behaving as expected. You have marked the fields required, and it is validating your assertion.

Here is some more info on readOnly and writeOnly:
https://swagger.io/docs/specification/data-models/data-types/#readonly-writeonly


[$250] Room-A "workspace" visibility room is created via whisper from a "public" visibility room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap fab -- start chat
Create a public visibility room
Create 2 room via whisper by sending message - eg : #35 #799
From the whisper message, tap yes
Note room created is highlighted
Now tap on room header -- settings -- visibility
Note room is a "public" visibility room
Now tap on any room highlighted ( created via whisper)
Now tap on room header -- settings -- visibility
Note room created is a workspace visibility room

Expected Result:
A "public" visibility room must be created via whisper from a "public" visibility room.
Actual Result:
A "workspace" visibility room is created via whisper from a "public" visibility room.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/0a530875-069f-4910-97f5-2b17425bee92

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021837194850505873695
Upwork Job ID:<PHONE_NUMBER>505873695
Last Price Increase: 2024-09-20

Issue OwnerCurrent Issue Owner: @justinpersaud

@Christinadobrzyn  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I can reproduce this with the steps in the OP. I think this can be external - let's start there and see what we think!

@DylanDylann, can you check out the proposal? Thanks!

I like @nkdengineer's idea to create the optimistic room data. With this approach, we have the ability to create a new room offline but still need to modify the visibility field on the BE side.
On the other hand, If we don't want to support this action offline, we can handle this issue on the BE totally by modifying the visibility field
🎀 👀 🎀 C+ reviewed

Heads up - I'm going to be ooo till 9/30. I'm not going to assign a BZ buddy to this since we're reviewing proposals. If you need someone in the meantime, feel free to reach out to the Bug team for a volunteer. thanks!

I think it's fine to support offline, proposal sounds good to me

@justinpersaud Could you give the final assignment to @nkdengineer ? Then we can start on PR

@justinpersaud We need to introduce a new param to send the list ID of new rooms when we create this via whisper action then BE can use this list ID to create new rooms on the backend side.

@nkdengineer do you have a suggested name for this new param you're proposing?

@justinpersaud I think it can be reportIDList

@justinpersaud friendly bump

Sorry I was out sick. I'll look into what we need to do for the backend changes to get this out.

Sorry, now that I am looking into this a bit more, what are we expecting the outcome will be in the event that there is a collision on the room name if we try to create a room offline and it was already created?

@nkdengineer can you take a peek at these questions when you have a moment? TY! https://github.com/Expensify/App/issues/49544#issuecomment-2405586903

@justinpersaud If the report was created, please send the preexistingReportID as the existing reportID for the report data of the reportID according to the room name in the API param. And then frontend already have the logic the clear the optimistic report.

@justinpersaud Could you help to check the above comment? Thanks

I'm wrapping up some other tasks right now internally, but hoping to look at the backend changes required later this week

@justinpersaud Kindly bump

Looked at the backend change just now and see we are defaulting to workspace visibility as we reported here, but I am asking if there is a specific reason why in our product channel

@DylanDylann @nkdengineer I am newer to working on these proposals so you'll have to bear with me here, but why are we passing in reportIDList, implying we would pass a number of reportIDs to the backend, right?
Won't we ever only be sending a single reportID to the backend to be created? Or are we going to queue up a backend call to ResolveActionableReportMentionWhisper with multiple reportIDs?

@DylanDylann and @nkdengineer can you follow up on this - https://github.com/Expensify/App/issues/49544#issuecomment-2442281063

Hey all,
I circled back internally and discovered this feature is actually working as designed. We want the visibility of rooms to always be set to workspace, regardless of where it is created by default.
Thanks for the initial work and investigation. I'll leave it with @Christinadobrzyn for any outstanding payment for work that was already done.

@Christinadobrzyn From https://expensify.slack.com/archives/C02NK2DQWUX/p1723055151068559?thread_ts=1723015261.405329&cid=C02NK2DQWUX, I think we should get full compensation

Okay sounds reasonable since the proposals were reviewed and the PR was created.
Payouts due:

[X] Contributor: $250 @nkdengineer (paid in Upwork - https://www.upwork.com/nx/wm/offer/104139931)
[X] Reviewer: $250 @DylanDylann (paid in Upwork - https://www.upwork.com/nx/wm/workroom/38546784/details)

No regression test needed. Closing this out!


FIX CI

Remove apt install make to see if that's needed at all.

Well this doesn't trigger the CI.


[ScrollView] Add support for nested scrollable views.

In larger complex view hierarchies it may happen that a ScrollView-based component is nested inside another ScrollView.
Currently a nested ScrollView won’t receive scroll events, only the outer parent ScrollView will. In order to receive them, you would have to push scroll event callbacks down each child component of the parent ScrollView and all of those would have to send them down to their children, just in case a component somewhere down the tree needs to receive such events.
The developer and user of that component shouldn’t need to jump through hoops to have ScrollView callbacks work, but should be able to write isolated components that are unaware of the presence of other ScrollView instances in the view hierarchy and have React Native deal with the details of dispatching events to all components that require them.
Examples
Contrived
Multiple ListView instances as part of a larger scrolling view:
<ScrollView>
  <Header />
  <ListView />
  <ListView />
  <Footer />
</ScrollView>

Often the advice is to add views that are supposed to be above or below a ListView as a header or footer of the ListView, but that doesn’t solve the case where both ListView instance have to scroll in tandem as part of the parent ScrollView.
Real-world
My real world example is a ‘tab view’ component that displays a ScrollView-based component that needs to paginate.
You can run the example app that’s contained in the repo to see it for yourself, or in our production app that is currently in the store, but here’s a short demonstration of the ‘WORKS’ grid component being nested inside the top-level ScrollView and still paginating onEndReached as expected:

Proof of Concept
For my app I wrote some 🐒-patches that do the following:

When a RCTScrollView is added to a view hierarchy, it registers for a RCTScrollEvent notification.
When a RCTScrollView receives a native scroll callback it first does its own JS scroll event dispatching and afterwards it posts a RCTScrollEvent notification for any child RCTScrollView instances to pick-up.
The child RCTScrollView instance creates a new RCTScrollEvent object that offsets the scrollview’s contentOffset to reflect its location inside the parent RCTScrollView.
The child RCTScrollView then dispatches the JS scroll event as normal and the component doesn’t know any better than that it has scrolled as normal.

Notes:

Please don’t judge my implementation as anything other than a POC of the high-level functionality.
I used NSNotificationCenter because there’s a potential 1-to-many relationship. I haven’t noticed any discernible lag in delivery, but there’s also no guarantee. A possible alternative would be to use a proxy object as the UIScrollView delegate that can dispatch events to multiple delegates (example).
While I have not yet used the callbacks for a ListView component in the current version of our app, I have tested and verified that the onEndReached callback gets triggered, thus I see no reason why the removeClippedSubviews optimisation wouldn’t work either. At least that’s my goal, as I will need this soon.

Discussion

I’m looking for suggestions as to how this should be implemented for it to be acceptable in React Native.
When I discussed this with @javache offline he suggested abstracting the scroll position/event part from ScrollView into a Scrollable container. That container could then create the ScrollView if not inside a parent ScrollView.
I want to spend the time to write the iOS implementation.
I currently do not target Android and thus don’t feel like I’m the right person to implement it for that platform at the moment, at least not from the get-go.

/cc @javache @nicklockwood

👍  Beautiful issue.
Good job

@facebook-github-bot label Good First Task

I don't think that's a good first task @charpeni ?

I agree, this will require some more significant changes in how we create scrollviews and dispatch scroll events.

Hi guys, any movement on this?

I'm running into this same issue.  In iOS it seems to work as expected for me, but in Android the inner ScrollView never receives horizontal pan gestures if it is contained in a ScrollView that can also scroll horizontally, e.g. a zoomed image in a gallery

@alloy just ran into this, any progress on the issue?

The provided monkey-patch still works perfect in production with latest RN. I haven’t had much spare time to discuss and cleanup this patch until last week when we shipped a new major version of our app.
@javache Can we catch-up sometime soon to talk it through?

Guys, adding TouchableWithoutOpacity inside nested ScrollView worked like a charm for me on android:
ScrollView > ScrollView(horizontal) > TouchableWithoutOpacity > ...

With 0.43.0-rc.2 I'm into the same problem when attempting to wrap a ScrollView around the new FlatList component; the onEndReached event won't triggered as expected

@ilyadoroshin  worked for me on iOS.

@AlanFoster Same with you. onEndReached  won't called if a  is wrapped by a , even if the  is at the bottom.

Has anyone other than @alloy found a workaround? Even if it's a monkeypatch approach, I am trying to resolve this.

@ilyadoroshin @restlessCalm FYI The issue described in the linked SO post is about a completely different scenario than what this ticket is about.

@AlanFoster @andrerfneves Did you try my monkey patches in latest RN and/or with FlatList? I haven’t upgrade to the latest yet, but the internal scrollview API hasn't’t changed much over the months, so should probably be ok.

@alloy how would you go about using such monekypatches? Not entirely familiar with iOS development. My issue is actually the same but on the Android platform. Any thoughts?

Ahh I see. No sorry I have no input on Android right now, only iOS. As to how to integrate these monkey patches, you can take a look at our OSS project they reside in.

Any solution to nested scroll views on Android?
I have a vertical SectionList inside a vertical ScrollView with RefreshControl. When the bottom of the outer ScrollView is reached and and can scroll down in the inner SectionList. But I can never scroll up in the inner SectionList because of the outer ScrollView's RefreshControl.

Same here. Any workaround? i have something like this:
<ScrollView>     <FlatList onEndReach={this.fetchNewPage} />   </ScrollView>

Greetings,
For anyone looking for a workaround for android, I have a solution that was tested successfully.
The core of the fix is to use NestedScollView instead of ScrollView. There's a library that already does this - https://github.com/mohtada-h/react-native-nested-scrollview, however it's not being maintained to support the latest RN.
I've created a patch that can be applied directly from a the root of a react native project. You can find the patch file here:
https://raw.githubusercontent.com/hemantasapkota/react-native-nested-scrollview/master/root.patch
Summary of the fix:
npm install react-native-nested-scrollview --save
# From the root of your RN project
wget https://github.com/hemantasapkota/react-native-nested-scrollview/blob/master/root.patch
# Apply the patch
patch -p0 < root.patch | 2>/dev/null

Final step would be to use NestedScrollView instead of ScrollView in your source project.

@hemantasapkota hello dude, i get this error with your solution:
react-native-nested-scrollview\android\src\main\java\com\mohtada\nestedscrollview\ReactNestedScrollViewManager.j
ava:37: error: ReactNestedScrollViewManager is not abstract and does not override abstract method flashScrollIndicators(ReactNestedScrollView) in ScrollComman
dHandler
public class ReactNestedScrollViewManager

package.js
	"dependencies": {
		"react": "16.0.0-beta.5",
		"react-native": "0.49.3",
		"react-native-html-parser": "^0.0.5",
		"react-native-loading-spinner-overlay": "^0.5.2",
		"react-native-navigation": "^1.1.236",
		"react-native-nested-scrollview": "^0.0.3",
		"react-native-platform-touchable": "^1.1.1",
		"react-native-scrollable-tab-view": "^0.8.0",
		"react-native-smart-loading-spinner-overlay": "^1.0.2"
	},

Hey @dviluk, seems like you're using [react, react-native] => [16.0.0-beta.5, react native 0.49.3] The patch that I posted was for [react, react-native] => [16.0.0-alpha.12, 0.48.4].
Between 0.48.4 & 0.49.3, RN has added a new method to the ScrollCommandHandler interface. To get the build working, use this patch.
--- node_modules/react-native-nested-scrollview/android/src/main/java/com/mohtada/nestedscrollview/ReactNestedScrollViewManager.java
+++ node_modules/react-native-nested-scrollview/android/src/main/java/com/mohtada/nestedscrollview/ReactNestedScrollViewManager.java
@@ -157,6 +157,10 @@ public class ReactNestedScrollViewManager
     }

     @Override
+    public void flashScrollIndicators(ReactNestedScrollView scrollView) {
+    }
+
+    @Override
     public @Nullable Map getExportedCustomDirectEventTypeConstants() {
         return createExportedCustomDirectEventTypeConstants();
     }

Copy the contents to a file, (example: rn-0.49.3.patch ) and execute the following:
patch -p0 < rn-0.49.3.patch

Hope that's helpful. PS: You'll still need to apply the first patch i posted in the earlier thread.

Hi @hemantasapkota , I tried your patch, but I'm getting this error:
Tried to register two views with the same name AndroidHorizontalScrollView
I'm currently using [react, react-native] => [16.0.0-alpha.12, 0.49.3], I run both patches by the way.
Thanks for your help dude!

@linoleum First off, probably should use 16.0.0-beta.5 to avoid dependency issues -- unless you still have the React.PropTypes or React.createClass code. Second, If you want to get rid of that error, you can just add a uniqueId function to the AndroidHorizontalScrollView name and it will disappear.
If you guys don't want to maintain huge patches for this on Android, you can instead copy over ReactScrollView.java and ReactScrollViewManager.java and change a few lines:

In ReactScrollView.java, extend NestedScrollView instead of ScrollView (also this line: NestedScrollView.class.getDeclaredField("mScroller");); add your missing imports from the ReactAndroid/.../scroll/ directory; comment out the conflicting onAttachedToWindow function.
In ReactScrollViewManager.java, change REACT_CLASS to be another name such as RCTNestedScrollView and import missing dependencies.

If someone else doesn't do this first, I'm probably going to try and open a PR to support android nested scrollviews and turn it on through a prop or something.

@linoleum00 @kpink224

Hi all,
https://snack.expo.io/rk93R9BCW
hacky way

@ashrithks Awesome example to show how to get this working with android.
The advantage of the NestedScrollView though is that it elegantly handles passing of the responder to the parent if you reach the bounds of the inner scrollview -- which by the way, iOS offers by default but is also not supported in react native 😞. Plus you don't have to flood the bridge with scroll events since it's all happening on the native layer.

@ashrithks i tried example app. It looks awesome. Thanks.

I haven’t followed all of the Android related chatter precisely, but if someone is maintaining a native solution that works similar to my iOS one, then we should maybe get in touch and chat about a unified solution that could go into React Native proper. Please ping me if that’s the case.

I can recommend https://github.com/kmagiera/react-native-gesture-handler for a better way to handle multiple ScrollViews on Android.

I have following structure
 (made scrollenbaled =false and refreshcontrol is enabled)

horizontal scrolling -- this is working

-Tabnavigator
-tab1
-listview (not scrolling)
-tab2
-listview (not scrolling)

I do i make the listview scroll ?

@jenskuhrjorgensen i'm experiencing the same issue!! Did you find any solution?? :(

@rekha110254 Nope - I was so lucky that the design changed instead! 🍀 😄

@chetankotkar i'm experiencing same issue!! Did u find any solution? :/

@ashrithks ur method is buggy, it doesnt work after u scroll down and then go up. tried it on a real device.

Anyone has the solution to this?
I have to use nested FlatList inside ScrollView, but onEndReached keeps firing without reaching the end...

Mine was ScrollView is rendered inside FlatList. The ScrollView scrolling effect doesnt work anymore but the FlatList is working fine.
Any solution for this?

#19543

nestedScrollEnabled works, first of all make sure your RN version is >= 0.56.0, because this property was introduced in 0.56.0. Add nestedScrollEnabled for inner/child ScrollView component.

@ivanzotov its not working.. its all waste of time upgrading to 0.56 right now..

As pointed out in earlier comments, now nested scrolling is possible on both platforms via nestedScrollEnabled (which needs to be explicitly set for Android to use it, and as Ivan pointed out you need to have it set in the inner list).

@kelset The OP is not about being able to scroll in nested scrollviews, though, that’s just something that many people have been discussing here but is off-topic.

Hey @alloy thanks for the clarification, but then I'm confused by:

The developer and user of that component shouldn’t need to jump through hoops to have ScrollView callbacks work, but should be able to write isolated components that are unaware of the presence of other ScrollView instances in the view hierarchy and have React Native deal with the details of dispatching events to all components that require them.

I mean, it seems to me that nestedScrollEnabled obtains that 🤔
Or there is a key "under the surface" difference that I'm missing? Was it more about reaching something closer to this?

he suggested abstracting the scroll position/event part from ScrollView into a Scrollable container

Anyway I'll reopen :)

Yeah it’s a nuanced issue 😄 It’s about having scrollviews inside a scrollview, which would disable the nested scrollviews from scrolling independently but still receive scroll events as if there were scrolling their own content. If you look at the GIF in the OP, you’ll see that per tab there’s only 1 large scrolling view, but there are actually some nested scrollviews in that hierarchy.

I discussed this issue with @alloy in person. This is a valid proposal and definitely a change we'd like to have in React Native but over the course of almost three years nobody has put themselves forward to actually implement it and we haven't had a need for this at Facebook either, hence I'm going to close this issue.
However, if you feel passionate about adding the right APIs without breaking existing code, please feel free to keep discussing the concrete implementation here and start sending PRs that gets us closer to this goal :)

Try this, It worked for me
<ScrollView {...parentProps}>
<ScrollView {...childProps} nestedScrollEnabled={true}>


Add ODBC driver

Hello. Thanks for this repository. This PR adds support for the PDO ODBC driver. I also added some documentation in the readme. Let me know what you think

About the failed travis build, the error is for php 5.6 and hhvm about using string for type hinting.
In PHP 7, that's fine, and is in fact required from phpcs.
Check this SO answer as a reference.
I'm not sure what's the right way to deal with this to pass on both php 7 and php 5.6

Thank you for taking the time to put this together.
To fix the phpcs warning, you have to remove the string type hint as we are targeting php 5.6. There was a typo in phpcs.xml.dist's php_version lock that kept phpcs from correctly figuring out what version we were targeting, I've now fixed it in master. Please update your branch and re-run your tests.
The readme should also now indicate that odbc is supported, please update this PR.

Done

Thank you for your work! I'll put out a phar release for this later today.

During testing I found a bug introduced by this PR. Unfortunate because I haven't had a chance to add a test suite yet, which surely would have caught it.
# php build/db-ping.phar mysql --host localhost
DB-PING localhost:3306
time=2017-01-19 22:20:16, from localhost:3306, connected., delay=2000ms, repeat=1x, exec=0ms, since success=0s, since fail=0s, 8
time=2017-01-19 22:20:16, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=0s, since fail=0s, 8
time=2017-01-19 22:20:18, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=2.0174s, since fail=0s, 8
time=2017-01-19 22:20:20, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=4.0191s, since fail=0s, 8
time=2017-01-19 22:20:22, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=6.0208s, since fail=0s, 8
time=2017-01-19 22:20:24, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=8.0229s, since fail=0s, 8
time=2017-01-19 22:20:26, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=10.0248s, since fail=0s, 8
time=2017-01-19 22:20:28, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=12.0265s, since fail=0s, 8
time=2017-01-19 22:20:30, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=14.0282s, since fail=0s, 8
time=2017-01-19 22:20:32, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=16.0299s, since fail=0s, 8
time=2017-01-19 22:20:34, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=18.0317s, since fail=0s, 8
time=2017-01-19 22:20:36, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=20.0334s, since fail=0s, 8
time=2017-01-19 22:20:38, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=22.0355s, since fail=0s, 8
time=2017-01-19 22:20:40, from localhost:3306, check passed., delay=2000ms, repeat=1x, exec=0ms, since success=24.0373s, since fail=0s, 8
-- localhost:3306 database ping statistics ---
13 tries, 13 successes, 0 failures, 0% fail tries
24.8725s time, 24.8725s success, 0s fail, 0% fail time

Notice the trailing , 8 on each line.
I think it has to do with your format processing code and the a flag, but I'll have to debug it when I have a chance later. If you have time, please submit another PR with a fix.


Feature/improve sentry coverage and audit capture

https://dsdmoj.atlassian.net/browse/FB-429

Did we look into Sentry scrubbing?
https://docs.sentry.io/data-management/sensitive-data/#server-side-scrubbing

Yes.
...configure scrubbing within SDK if possible so that sensitive data is not sent with the request.
...
In the SDKs you can configure a before-send function which is invoked before an event is sent and can be used to modify the event data and remove sensitive data
So that's what I'm doing.
This enables the same rules to be applied to both Sentry exceptions and logging.
Plus it handles dynamic input names which are under the person making the form's control while still providing some info about what the field contained.
Also, I don't access to the project settings ;)


python3Packages.mkdocs-simple-hooks: init at 0.1.5

Description of changes
https://github.com/aklajnert/mkdocs-simple-hooks/
Adding this package because it's required for updating ntfy-sh to 2.3.1.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 222899 run on x86_64-linux 1

4 packages built:

python310Packages.mkdocs-simple-hooks
python310Packages.mkdocs-simple-hooks.dist
python311Packages.mkdocs-simple-hooks
python311Packages.mkdocs-simple-hooks.dist


Throw an error if loading module source fails

Works around #450

Maybe we should do the same when reading package.json files?

@jasssonpet feel free to do so.


Mingw64 build failing: help needed

I am trying to build zynfusion on windows as per instructions here. It fails. I reinstalled the dependencies and tried again. It is still failing.
I am relatively new to the build/dependency process with any code, and need help.

For clarity, I clone zyn-fusion-build into a directory called G:/Projects/zynfusion/. My MSYS is in E:\Development\msys64\.

Last few lines of output:

-- Build librtosc and librtosc-cpp as static libraries
-- Found GCC Version >= 4.7
-- Include what you use: disabled (RTOSC_INCLUDE_WHAT_YOU_USE=OFF)
-- Found OpenGL: opengl32
-- Found FLTK: E:/Development/msys64/mingw64/lib/libfltk_images.dll.a;E:/Development/msys64/mingw64/lib/libfltk_forms.dll.a;E:/Development/msys64/mingw64/lib/libfltk_gl.dll.a;opengl32;E:/Development/msys64/mingw64/lib/libfltk.dll.a
-- Checking for module 'ntk'
--   Package 'ntk', required by 'virtual:world', not found
-- Checking for module 'jack'
--   Package 'jack', required by 'virtual:world', not found
-- Checking for module 'liblo>=0.28'
--   Package 'liblo', required by 'virtual:world', not found
-- Could NOT find Ruby (missing: Ruby_INCLUDE_DIR Ruby_CONFIG_INCLUDE_DIR) (found suitable version "3.3.0", minimum required is "1.8")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
--
-- Rtosc Build Configuration
-- =========================
--
-- PkgConfig enabled  -- package found
-- Liblo disabled     -- package NOT found
-- JACK disabled      -- package NOT found
-- NTK disabled       -- package NOT found
-- Perf Test(s) disabled
-- FLTK disabled      -- package found in unsupported version (expected 1.3)
-- Checking Include Path
-- Checking Library Path
-- Found ZLIB: E:/Development/msys64/mingw64/lib/libz.dll.a
CHECK_START;Performing Test CMAKE_HAVE_LIBC_PTHREAD
CHECK_PASS;Success
-- Found Threads: TRUE
CHECK_START;Looking for snd_seq_create_simple_port in asound
CHECK_FAIL;not found
-- ALSA not found
CHECK_START;Looking for sio_open in sndio
CHECK_FAIL;not found
-- SNDIO not found
CMake Warning at src/CMakeLists.txt:21 (find_package):
By not providing "FindECM.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "ECM", but
CMake did not find one.
Could not find a package configuration file provided by "ECM" with any of
the following names:
ECMConfig.cmake
ecm-config.cmake

Add the installation prefix of "ECM" to CMAKE_PREFIX_PATH or set "ECM_DIR"
to a directory containing one of the above files.  If "ECM" provides a
separate development package or SDK, be sure it has been installed.
CMake Warning at src/CMakeLists.txt:23 (find_package):
By not providing "FindLibGit2.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "LibGit2", but
CMake did not find one.
Could not find a package configuration file provided by "LibGit2" with any
of the following names:
LibGit2Config.cmake
libgit2-config.cmake

Add the installation prefix of "LibGit2" to CMAKE_PREFIX_PATH or set
"LibGit2_DIR" to a directory containing one of the above files.  If
"LibGit2" provides a separate development package or SDK, be sure it has
been installed.
-- Found FFTW3F: E:/Development/msys64/mingw64/include
CMake Error at rtosc/cmake/ColorMessage.cmake:53 (_message):
Could NOT find MXML (missing: MXML_INCLUDE_DIR MXML_LIBRARIES)
Call Stack (most recent call first):
E:/Development/msys64/mingw64/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message)
E:/Development/msys64/mingw64/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
cmake/FindMXML.cmake:16 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
src/CMakeLists.txt:44 (find_package)
-- Configuring incomplete, errors occurred!
make: *** [Makefile.mingw64.mk:70: build_zynaddsubfx] Error 1

I had same issue on Docker but it solved by using Native Ubuntu 22.04.

I wish CMake in general was better about outputting when a missing dependency was optional or not. In this case it looks like it's struggling to find mxml, so I'd see if building that dependency went well. If so then it may come down to the search path to find the version of mxml it wants to use?

As per the docker comment, that should be the most reliable method because the environment is going to be virtually identical, though it would be great to fix problems in other environments to reduce friction for people not containerizing their build.


withFilter example & typings

Loving the library! I'm trying to add filters to my subscriptions, but can't seem to understand the format.
Would it be possible to have the example in the repo use it?
I also noticed that since it doesn't return an AsyncIterator, typings kinda fail for graphql-codegen generated types

If I'm reading this correctly (https://github.com/andyrichardson/subscriptionless/blob/master/src/pubsub/publish.ts#L66), the filter object defined in withFilter is stored against the subscription in DDB (To remain stateless), however using equals would mean both payloads have to match in their entirety right?
E.g. a subscription payload of:
{
  "user_id": 1,
  "hello": "world"
}

Wouldn't match against a withFilter definition of:
withFilter(subscribe('MY_TOPIC'), (root, args, context, info) => ({
  user_id: args.user_id,
}));

Since withFilter doesn't include a hello key value pair?

My bad - re-read and noticed that it's creating those comparisons per key => value, not the overall object. My context generator wasn't working properly which was the issue.


[labs/observers] Add unobserve method to ResizeController and IntersectionController

Fixes: https://github.com/lit/lit/issues/3237
Context
ResizeObserver and IntersectionObserver both have a method to unobserve elements. This change adds the unobserve API to the respective reactive controllers.
I did not add this API to the MutationController as the MutationObserver does not natively support unobserve.
Fix
Add an unobserve method which calls unobserve on the native observer, but also removes the target element from the internal list of targets.
Test plan
Tested with unit tests.

Thanks @AndrewJakubowicz!! Beat me to it and excited to leverage this in my work. 🙏

Your welcome @Westbrook! Thank you for filing the issue! This has now been released in lit-labs/observers 1.1.0.


Added serializer and views for Flood rescue app

I have not added settings in this PR as I have tweaked a bit in my installation to add different database configuration.
I was regularly getting a 500 server error. Check my log file

This is for the api for a new app, for gps tracking stranded individuals


various packages: add mainProgram to meta

Description of changes
Make use of meta.mainProgram for some of my maintained packages which have a main binary.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Why you need explicit mainProgram? Since mainProgram = pname by default.

I didn't know that...


Vliu explorev2 bugs

Issues:

[x] Chart Container can't accomodate large chart https://github.com/airbnb/superset/issues/1676
Solution: I was afraid wrapping entire chart within the container would cause it to be squashed/look bad. So I made chart container scrollable.

[x] Druid datasource pops errors in views.py

Solution: use datasource_name for druid instead of table_name

[x] action buttons are not clickable in heatmap-v2
Solution: svg was not shifted downward in Chart Container, so it blocks the action button. Adding headerHeight to svg solved the problem.

needs-review @ascott

one comment, otherwise LGTM. :ship:


Simplify sending empty events

Objective
When using empty events, it can feel redundant to have to specify the type of the event when sending it.
Solution
Add a new fire() function that sends the default value of the event. This requires that the event derives Default.

fire looks a bit unclear to me. One needs to read the docs to learn what it does. Maybe send_default could be a better name?

I chose fire instead of send_default because the main purpose was to reduce boilerplate so I wanted something short. That's one of those situations where having variable arity functions would be great. Firing events is is a pretty common terminology as far as I know, but I don't mind changing it if people think it's a better choice.

not a fan of fire here, I do prefer something explicit even if longer

bors r+


read SSL certificate on C# Linux fails

Unhandled exception. Interop+Crypto+OpenSslCryptographicException: error:2006D080:BIO routines:BIO_new_file:no such file
   at Interop.Crypto.CheckValidOpenSslHandle(SafeHandle handle)
   at Internal.Cryptography.Pal.OpenSslX509CertificateReader.FromFile(String fileName, SafePasswordHandle password, X509KeyStorageFlags keyStorageFlags)
   at System.Security.Cryptography.X509Certificates.X509Certificate..ctor(String fileName, String password, X509KeyStorageFlags keyStorageFlags)
   at System.Security.Cryptography.X509Certificates.X509Certificate2..ctor(String fileName, String password)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Certificates.CertificateConfigLoader.LoadCertificate(CertificateConfig certInfo, String endpointName)

Issue confirmed.
Created a sample project, added:
X509Certificate2 x509 = new X509Certificate2("/var/run/secrets/kubernetes.io/serviceaccount/ca.crt");

and didn't see any trace indicating attempt to open file, while it did fail.

Issue confirmed. Created a sample project, added:
X509Certificate2 x509 = new X509Certificate2("/var/run/secrets/kubernetes.io/serviceaccount/ca.crt");

and didn't see any trace indicating attempt to open file, while it did fail.
Interop+Crypto+OpenSslCryptographicException: error:2006D080:BIO routines:BIO_new_file:no such file
   at Interop.Crypto.CheckValidOpenSslHandle(SafeHandle handle)
   at System.Security.Cryptography.X509Certificates.OpenSslX509CertificateReader.FromFile(String fileName, SafePasswordHandle password, X509KeyStorageFlags keyStorageFlags)
   at System.Security.Cryptography.X509Certificates.X509Certificate..ctor(String fileName, String password, X509KeyStorageFlags keyStorageFlags)
   at Program.<Main>$(String[] args) in /app/WebApplication1/Program.cs:line 26

just took a quick look as I had everything from mongodb issue open in a window so it was easy to search: https://github.com/dotnet/runtime/blob/ac02b66e41041e1cefd355eacaddb45bcb4f1741/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/OpenSslX509CertificateReader.cs#L17 calls BioNewFile for the handle which returns null which brings me here: https://github.com/dotnet/runtime/blob/ac02b66e41041e1cefd355eacaddb45bcb4f1741/src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.BIO.cs#L16 and which is related to
BIO* CryptoNative_BioNewFile(const char* filename, const char* mode)
{
    ERR_clear_error();
    return BIO_new_file(filename, mode);
}

which calls openssl_fopen: https://github.com/openssl/openssl/blob/c2a8226cba2757b251729620aedffeed23d73623/crypto/bio/bss_file.c#L57C1-L57C1
which is https://github.com/openssl/openssl/blob/c2a8226cba2757b251729620aedffeed23d73623/crypto/o_fopen.c#L38C1-L38C1 and the only thing i see unhooked is _wfopen


docs:  updated the supported versions table

Fixes: #1656

You need to leave the info for 0.18.x and 0.19.x in place -- we still have a lot of users on those versions. You need to add a new row and put the info for 1.* in the new row.

solved this check it.

Keptn V1 has reached EOL on December 22nd, 2023, so this PR has been closed.


Implement PrimaryKey for AssetInfo

See #20 for discussion on the matter.
I can add tests if there's agreement on the implementation.

@CyberHoward I think you should implement PrimaryKey for &AssetInfo instead of for AssetInfo. This allows you to avoid to clone the asset info and save gas in many cases. I'm going to change the implementation if you're not against it.

Sure, tho it might cause issues in the KeyDeserialize trait.

@CyberHoward In this commit you see I avoid all cloning and have no problem with KeyDeserialize.
In short, the key in the map is &AssetInfo, but when deserializing we deserializing to an owned AssetInfo.

@CyberHoward I create a pre-release including all the changes I've made today. Let me know if this works for you. If yes I will make a formal release: https://github.com/mars-protocol/cw-asset/releases/tag/v3.0.0-rc1


fix: certificate issues

Here I am fixing a few issues I have found so far that may be causing @JakeSCahill from being able to properly create a certificate with ACME. This may be a WIP.
Part of #203

Also remove commonName https://github.com/redpanda-data/helm-charts/pull/289/files#diff-ec07f07a47aa911db2b476d9fcdd33907646aadab5e83db1e9aa13d36ab671e5R37

Thanks @alejandroEsc!
It looks like caEnabled is also ignored.
I'm seeing a root certificate being generated even if I specify tls.cert.redpanda.caEnabled=false.
This is causing a failed Certificate to be generated that is looking for an Issuer called redpanda-redpanda-self-signed-issuer:
Normal  IssuerNotFound      12m   cert-manager-certificaterequests-issuer-selfsigned  Referenced "Issuer" not found: issuer.cert-manager.io "redpanda-redpanda-selfsigned-issuer" not found

I'm now able to get TLS working with Let's Encrypt and a custom domain 🎉 thanks @alejandroEsc !
This isn't a blocker, but I still get this disused root Certificate being created: https://github.com/redpanda-data/helm-charts/pull/289#issuecomment-1404934499

redpanda       redpanda-default-root-certificate         True    redpanda-default-root-certificate         15m

What I am seeing is what I was hoping not to see, so we may have to change a few things about certs but when i compute the values file from what you are doing, and even when i use my own values file, i get the following:
...
tls:
  certs:
    default:
      caEnabled: true
    redpanda:
      caEnabled: false
      issuerRef:
        kind: ClusterIssuer
        name: letsencrypt-prod
  enabled: true
tuning: {}
...

This is why the default cert is created. Ill investigate this a bit further.

This is a breaking change and I think it's still broken if someone uses a different issuer for the admin cert. We need to find a way to test this with different issuers.

Closing this PR. This will fix the issues we see when trying to use certs meant for external clients internally.


[$250] Search filters - Scrolling behavior after selecting currency and category is different

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : https://github.com/Expensify/App/pull/46566
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Launch New Expensify app.
Navigate to https://staging.new.expensify.com/search/filters
via deep link.
Tap Currency.
Scroll down and select a currency.
Note that the list does not scroll up after selecting a currency.
Tap Category.
Scroll down and select a category.
Note that the list scrolls up after selecting a category.
Repeat the steps above on web.

Expected Result:
The scrolling behavior in filters should be the same after selecting currency and category.
Actual Result:
On Android and iOS,
In Step 5, the list does not scroll up after selecting a currency.
In Step 8, the list scrolls up after selecting a category.
On web, mweb and desktop app,
In Step 5, the list scrolls up without animation after selecting a currency.
In Step 8, the list scrolls up with animation after selecting a category.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/62fd61af-3096-401e-841d-4f8f8ffe13bd
https://github.com/user-attachments/assets/4c649652-36c4-475a-9d1d-933f13fa259c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f10b9412daa7bb88
Upwork Job ID:<PHONE_NUMBER>946228601
Last Price Increase: 2024-08-08
Automatic offers:

dukenv0307 | Reviewer | 103492530
dominictb | Contributor | 103492533

Issue OwnerCurrent Issue Owner: @dukenv0307

We think this issue might be related to the #collect project.

Has the automation failed again @carlosmiceli? Is this done and ready to be paid?

Payment Summary:

Contributor: @dominictb paid $250 via Upwork
Contributor+: @dukenv0307 paid $250 via Upwork

Upwork job here

Contributors have been paid, the contracts have been completed, and the Upwork post has been closed.


Newer(?) TLD rejected from forgot password process

Issue Summary
Newer TLD rejected by forgot password process.
To Reproduce

Create a user with an email at a newer TLD, e.g<EMAIL_ADDRESS>Try to initiate the forgot your password process in the admin login.
Address rejected and error reports bad sender syntax.

Technical details:

Ghost Version: 2.25.1
Node Version: v10.16.0
Browser/OS: MacOS 10.14.5
Database: sqlite3

@daetal-us I'm not able to replicate this, from the description of your error message it sounds like it's possibly a problem at your smtp providers end. Ghost doesn't have any of its own error messages which would output a "bad sender syntax" error so I'm going to close this as an environment issue. If you need further support please use our forum.


Issue 2

Fix #2
Test URLs:

Before: https://main--piramal--aemsites.hlx.page
After: https://issue-2--piramal--aemsites.hlx.page

@Sk-Zahid , is this still in progress?
few observations so far:

The width of the dropdown is not full screen as on original site

mobile view is broken

@Sk-Zahid , is this still in progress?
few observations so far:

The width of the dropdown is not full screen as on original site

2. mobile view is broken

Please reload the page for mobile device

The selected item and its subitems also need to have a different background color (as on original site). Please see closely, the entire mobile menu isn't white (varies based on item selections)

This seems to resolve if other any changes please lets know

Hi @asthabh23  @mind-adobe @buuhuu ,
Please review the code and update us.


fix: no need to decompress buffer when downloading functions

What kind of change does this PR introduce?
This PR fixes the issue with downloading edge functions. Looks like the function payload is now automatically decompressed (from brtoli), so no longer need to decompress payload manually (couldn't find the change that caused the behavior change though)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 58.595%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
12.31%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
5665

Relevant Lines:
9668

💛  - Coveralls

This change broke deploying new functions. I've reverted it for it so we can investigate further.

This change broke deploying new functions. I've reverted it for now so we can investigate further.

Do you have an error report? This code path is different from deploying new functions.

Sorry I wasn't clear. It broke downloading of newly deployed functions. Steps to reproduce:
npx<EMAIL_ADDRESS>functions deploy hello_world
npx<EMAIL_ADDRESS>functions download hello_world

Error is the same as reported by Inian


fix: make description utf8

#199  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


[flows] adding pattern for TextInput, adding support for NavigationList

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.01%. Comparing base (5855995) to head (0e4c2da).
Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   85.77%   86.01%   +0.24%
==========================================
  Files          16       16
  Lines        3079     3133      +54
==========================================
+ Hits         2641     2695      +54
  Misses        438      438

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add section with instructions for building a Decision Environment

Add section with instructions for building a Decision Environment that includes the library.
This solves issue #5

Merging this in as #7 will fix the issues in the Ansible Lint testing here


Conmmunity

https://github.com/community/community/discussions/28867#discussioncomment-4195537

This person is shilling for a crypto scam?? I'd remove this "issue"


Implement testing using Jest and Puppeteer

For the initial release, I would propose that we please follow the approach supported in the official documentation: https://stenciljs.com/docs/testing-overview

@jrgriffiniii as a test for an automated maintenance task, this issue is being labeled as stale due to its age. Should you wish to reclassify this as a prioritized issue, please contact @samvera/maintenance for assistance. Thank you for your patience.


Added IA32_TSC_AUX MSR

My guest system relies on IA32_TSC_AUX and this patch allows it to boot further.
Since handle_cpuid_virtual always returns a constant set of features, I have skipped the check for the feat_rdtscp flag before reading/writing this register and simply added it to gmsr_list. Note that the rdtscp instruction not yet implemented in the emulator, since none of my guests used it, but I can implement it for the sake of consistency if you want.

I've addressed all issues except checking whether the host supports rdtscp, thus breaking pre-Nehalem hosts. I was thinking in adding the following changes to test for host features:

During HAXM initialization get relevant features via cpuid and store them in uint32_t[N] array.
Define X86_FEATURE_* values as (index << 5) | (bit), where index is an index into the previous array, and bit says the bit-index of the feature flag.
Define a cpu_has_feature function in cpu.c (this is the source file for host-related functions, right?).

This would be similar to what KVM does by relying on Linux' boot_cpu_has function. Of course, since HAXM is multiplatform, it'd be to check for the features by ourselves (as described above) rather than relying in OS utility functions.

The patch looks good now. We'll run a few tests before merging it.
Indeed, currently HAXM lacks an API to easily query host CPU features, and what you have proposed is definitely a good design.

Define X86_FEATURE_* values as (index << 5) | (bit), where index is an index into the previous array, and bit says the bit-index of the feature flag.

This is a scalable way to organize all the features. I was wondering if there's BSD-compatible code that defines similar macros for us to reuse. I checked FreeBSD, but it basically puts index in the macro name (e.g. CPUID2_SSE3), which is not very convenient. Anyway, we don't need many indexes at first, so defining them manually should be okay.

Define a cpu_has_feature function in cpu.c to do queries by relying on said array (I'm assuming cpu.c is the source file for host-related functions).

Yes, we could put the new API in core/cpu.c. But what about creating a new pair of source files, core/cpuid.{c, h}? In the beginning we only need the host CPUID query API,  but we might want to add more over time, e.g. caching the CPUID result for each guest, and eventually allowing each guest to customize its own vCPU features.

The patch looks good now. We'll run a few tests before merging it.

Great! If tests are passed, feel free to merge and I'll address the host feature checks in a separate PR.

Yes, we could put the new API in core/cpu.c. But what about creating a new pair of source files, core/cpuid.{c, h}?

That sounds much better, I will do that then.

I'll address the host feature checks in a separate PR.

Thanks!


Evaluation environment

We have a loss that is computed in mirroring mode but to be able to compare with classical neural networks maybe we need to add some special mode for that (without mirroring). But we do not want to make neurons non-trainable, it is against our idea.

Creating evaluation architecture we should keep in mind that because of incapsulation things required for evaluation are in different classes: environment manages data (can switch between train and validation data); neural network builder wraps environment activities and neurons from sampler into input neuron (so if we want to change input neurons behavior during validation, only the builder can do it). And neural network manages neurons ticking (though that ticking is synchronized with the environment now).

Maybe extend activities in the environment with a special field specifying that this activity now missing in the environment. So input neuron connected to that activity automatically will behave as usual neuron and no switchers need to be turned from the builder.


make run_assistant failed.

Just followed the readme and try to build the run_assistant..getting an error?
Please help to check what is the issue?
~/Linux-Google-Home/assistant-sdk-cpp$ make run_assistant
find: /googleapis/gens/google/api': No such file or directory find: /googleapis/gens/google/rpc': No such file or directory
find: `/googleapis/gens/google/type': No such file or directory
protoc -I=./googleapis/google/assistant/embedded/v1alpha2 --proto_path=.:./googleapis
--cpp_out=/googleapis/gens/google/assistant/embedded/v1alpha2
--grpc_out=/googleapis/gens/google/assistant/embedded/v1alpha2
--plugin=protoc-gen-grpc=/usr/local/bin/grpc_cpp_plugin
./googleapis/google/assistant/embedded/v1alpha2/embedded_assistant.proto
/googleapis/gens/google/assistant/embedded/v1alpha2/: No such file or directory
make: *** [/googleapis/gens/google/assistant/embedded/v1alpha2/embedded_assistant.pb.cc] Error 1
__git_ps1: command not found

It looks like you didn't clone or compile the protos first? Can you confirm that you have the googleapis directory?

Yes I have checked..it is there
On Tue, 7 Aug 2018, 23:21 Nick<EMAIL_ADDRESS>wrote:

It looks like you didn't clone or compile the protos first? Can you
confirm that you have the googleapis directory?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googlesamples/assistant-sdk-cpp/issues/38#issuecomment-411144464,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad-rXxp5IUtTRTF4AxIdiM1a6mDtJdsxks5uOdO1gaJpZM4Vxz5r
.

I've scheduled a CI build to see if I can reproduce.
Have you synced with the most recent changes to the Makefile? If so, maybe going back a few commits may yield better results. I know the most recent PR made some changes to the Makefile.
git checkout f88a48e2ba952c244037918fb0e3a0297fb2bab0 should take you back to a recent commit.

Is your issue related to #35? Can you delete the googleapis/google/ads directory and see if there's an issue?

I have deleted the directory before logging an issue. Will check with
recent changes after updating codebase... thanks
On Thu, 9 Aug 2018, 06:23 Nick<EMAIL_ADDRESS>wrote:

Is your issue related to #35
https://github.com/googlesamples/assistant-sdk-cpp/issues/35? Can you
delete the googleapis/google/ads directory and see if there's an issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googlesamples/assistant-sdk-cpp/issues/38#issuecomment-411601939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad-rX633SNm3v_c_dSXCSTfAmDWDyPO6ks5uO4fzgaJpZM4Vxz5r
.

Thanks Fleker...Now the build error is solved by taking the recent commit.
When i try to execute the step 6 and try to click the link to get the code it is giving me Error 500 (Server error): So i am not able to get the CODE..Can you give guidance to overcome this?

Get credentials file. It must be an end-user's credentials.

Go to the Actions Console and register your device model, following these instructions
Move it in this folder and rename it to client_secret.json
run get_credentials.sh in this folder. It will create the file credentials.json.

sakthi@indbrnblx039:~/Linux-Google-Home/assistant-sdk-cpp  ((f88a48e...))$sudo ./get_credentials.sh
Client id:<PHONE_NUMBER>70-gvsipi4d1t3nkdgd8d7l43j0h4k87drq.apps.googleusercontent.com
Client secret: TYdAXtgckAePPqmN2fBOUKGb
Please go to the following link to authorize, and copy back the code here:
https://accounts.google.com/o/oauth2/v2/auth?scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fassistant-sdk-prototype&access_type=offline&include_granted_scopes=true&state=state&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&response_type=code&client_id=215236190270-gvsipi4d1t3nkdgd8d7l43j0h4k87drq.apps.googleusercontent.com

You may need to first setup an OAuth consent screen


Are the timelines for deadlines appropriate?

I specify some timelines in the lab manual for how long it will take me to look at the items, and there is a request for deadlines to be added to the calendar (which I never really implemented for you!). Are these timelines appropriate? What is the best way to manage shared deadlines?
Should we specify a preferred approach for managing shared documents in the lab manual? If so, what is that preferred approach?

This is something we would like to discuss as a group in the next lab meeting

Resolved in pull request https://github.com/flanagan-lab/flanagan-lab.github.io/pull/6