UI-REACT: CORS error during local development

Describe the bug
I'm getting this error when I try to use TonConnectButton:
Access to resource at 'https://connect.tonhubapi.com/tonconnect/events?client_id=...' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Recently it was working fine.
Expected behavior
There is no CORS related errors
Current behavior
There are CORS related errors
Steps to Reproduce

Build simple react app:

import { TonConnectButton } from "@tonconnect/ui-react";

function App() {
  return (
    <TonConnectButton />
  );
}
export default App;

Run the app (npm start)
Open dev tools -> Console tab
See the error:

Access to resource at 'https://connect.tonhubapi.com/tonconnect/events?client_id=...' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Environment
Output of npm ls @tonconnect/{ui-react,ui,sdk,protocol,isomorphic-fetch,isomorphic-eventsource}:
└── (empty)

Operating System:
Windows 10
Browser:
Chrome
Additional context
No response

I am facing a similar issue with tonapi. When this happens, it immediately disconnects and reconnects, then gets the error again and goes into an endless reconnect loop,
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://bridge.tonapi.io/bridge/events?client_id=79b8f76e0c5beadddb74c5e686899f26dc248000ba3c4cc355b771bf8ba4ee4b&last_event_id=1718955940365240. (Reason: CORS request did not succeed). Status code: (null).


class-memaccess warning when compiling with GCC 8 or later

Building Sparsehash trunk or 2.0.3 from source with GCC 8.2 gives various class-memaccess warnings like these:
./src/sparsehash/internal/libc_allocator_with_realloc.h:68:40: warning:
‘void* realloc(void*, size_t)’ moving an object of non-trivially copyable type
‘class std::__cxx11::basic_string<char>’; use ‘new’ and ‘delete’ instead [-Wclass-memaccess]
     return static_cast<pointer>(realloc(p, n * sizeof(value_type)));
                                 ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

./src/sparsehash/sparsetable:1157:13: warning:
‘void* memcpy(void*, const void*, size_t)’ writing to an object of type
‘struct std::pair<const int, {anonymous}::Memmove>’ with no trivial copy-assignment;
use copy-initialization instead [-Wclass-memaccess]
       memcpy(group + i, group + i+1, sizeof(*group));  // hopefully inlined!
       ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

A regular allocator (e.g. std::allocator) must be used to avoid undefined behavior unless is_trivially_copyable<value_type> is true.  As Sparsehash is written today, the default is a custom allocator using realloc() which invokes undefined behavior for many common types, including std::string as either key or value type.
Discussion: https://stackoverflow.com/questions/52436264/google-sparsehash-uses-realloc-on-type-which-is-not-trivially-copyable

half fixed

Fixed by #153.


Error: Cannot find module '.../dev'

Hi, I am trying to install the package to begin development, but when I go to run the server(npm/nvm run dev), the output is telling me that 'Cannot find module '/Users/kev/Dev/tcd/dev'. It seems like the module was not installed correctly? But I've run the installation several times now with this repeated effect.

Please help me figure this out as this library looks awesome and I'd love to be a part of the community using and improving! I'm on a Mac M2 chip, fwiw, which is why I'm using nvm

Hello,
And if you use npm instead of nvm ?
npm run dev

did you install the nodejs dependencies before ?
npm install

I had to use nvm to install node -v 14.21.3

The error indicates that the node_modules folder does not exist. You must do npm install before npm run dev

Oh I see, I had to use nvm to run node, then npm to start the dev server

My game is loading a black screen, though that may be the expectation on a new project. Thank you for the assistance, I really appreciate your time and this library.


onChange handler does not exist

Following the guide and am getting this error from TSC:

compiling also fails
C:\Github\mydevice>devs devtools src/main.ts
using devs: v1.10.3, runtime: v6.3.0, node: v18.12.1 from C:\Github\mydevice\node_modules\@devicescript\cli\built
devs: v1.10.3, runtime: v6.3.0, node: v18.12.1
   http     : http://<IP_ADDRESS>:8081
   websocket: ws://<IP_ADDRESS>:8081
   tcpsocket: tcp://<IP_ADDRESS>:8082
   dbgserver: tcp://<IP_ADDRESS>:8083
building src/main.ts...
build src/main.ts Failed
src\main.ts:7:17 - error TS2339: Property 'onChange' does not exist on type 'Register<number>'.

7 sensor.pressure.onChange(10, async () => {
                  ~~~~~~~~
watching src/main.ts...

this compiles. Should the example be changed?
sensor.pressure.subscribe(async () => {
    // read sensor reading
...

https://github.com/microsoft/devicescript/commit/6a74959590ee4765727ac90be6697debe4de593d


wasi: add fd_write MVP implementation

Description
What is the purpose of the change?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Brief of your solution
Please describe your solution to solve the issue or feature request.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Codecov Report

Merging #15 (2b34ab2) into llvm_backend (bd25eb4) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           llvm_backend      #15   +/-   ##
=============================================
  Coverage         44.73%   44.73%
=============================================
  Files                 8        8
  Lines               418      418
=============================================
  Hits                187      187
  Misses              200      200
  Partials             31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd25eb4...2b34ab2. Read the comment docs.


Bug Fixes

[x] Fix #175  Comments tab should not be openable if 0 comments

@adcpm Loading on click should be there, as comments are not update realtime. Every time user click the loading button it will fetch the comment and will show them if there are any and if not the user can try again after sometimes by clicking it instead of refreshing the page.

@nil1511 we know already before fetching comment if there is any or not. We dont need to show a link and a loading when we know already there is 0 comment available.

@adcpm disabled click if no comments.


UserWarning: The given NumPy array is not writeable

Hi SketchGraphs Team,
I'm running the sketchgraphs generative model like this
python -m sketchgraphs_models.graph.train \
   --dataset_train /data/sg_t16_train.npy \
   --dataset_test /data/sg_t16_test.npy

I'm seeing a worrying warning from NumPy
 UserWarning: The given NumPy array is not writeable, and PyTorch does not support non-writeable tensors. This means you can write to the underlying (supposedly non-writeable) NumPy array using the tensor. You may want to copy the array to protect its data or make it writeable before converting it to a tensor. This type of warning will be suppressed for the rest of this program. (Triggered internally at  /opt/conda/conda-bld/pytorch_1607370156314/work/torch/csrc/utils/tensor_numpy.cpp:141.)
  self._offsets = torch.as_tensor(self._offsets).share_memory_()

I'm using Ubuntu 18.04.5 with a Quadro RTX 6000 GPU
Python 3.7.7
Pytorch 1.7.1
Cuda 11.0.221
Numpy 1.19.2
Full output from conda list is at the bottom of this message
I find I can fix the problem following the pytorch thread here like this
In (flat_array.py)[flat_array.py]
def __init__(self, offsets, pickle_data):
       """
       pickle_data : array_like
           an array of bytes representing the serialized data for all objects.
       """
   -   self._offsets = offsets
   -   self._pickle_data = pickle_data
   +  self._offsets = np.copy(offsets)
   +  self._pickle_data = np.copy(pickle_data)

This gets rid of the warning, but I'm worried it might be having side effects.  I'm seeing some very odd stuff happening.   Could you let me know if you think this fix is sensible.  I'm happy to make a PR to submit the change if it looks useful.
Also please let me know if you need any other details of my setup.

 As these tensors are just used as data, they are never written to and the warning can be ignored.
You can also copy the numpy array, but this will incur a large memory cost (proportional to the size of the dataset you are using).

OK.   Thank you.   This is good to know that the warning can be ignored.


implementation of the circular doubly linked list

Description
The program will implement the circular doubly link list with operation like insert, check empty, delete, count, search, display the circular doubly link list etc.
I will provide proper description about the circular doubly link list as well as the comments in the code.
gssoc'22
please assign this to me.
Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


Update cardano-node by 9.1.1, cardano wallet 2024.9.3, dbsync <IP_ADDRESS> and add conway config files

Change CARDANO_NETWORK variable to NETWORK in preprod/cardano-start.sh
Support docker compose version 2 (change from docker-compose to docker compose)
Update download.sh (add conway-genesiss.json)
Update preprod/docker-compose-cardano.yml (use cardano-node 9.1.1, cardano wallet 2024.9.3, dbsync <IP_ADDRESS>

Thank you!  Tested it end-to-end and everything is working for conway preprod.


Configure apiKey, additionalHeaders, and host through environment variables

Problem
There was a request to add additional configuration validation to the Go client as you could make requests with an empty apiKey. An empty check and early error return were added in a previous PR when passing apiKey directly: https://github.com/pinecone-io/go-pinecone/pull/18/files#diff-37c3a14781b4b6e74bcc0cfc8b2462ee2ae243a720a42669256248a3cb005f01R442-R444
We're also lacking the ability to specify an api key or headers through environment variables like the Python client, which can be a nice UX tweak for options in how you configure the client. Additionally, there's no way to specify a control plane host override, which is useful in situations where we need to hit a staging URL.
Solution

Refactor buildClientOptions() into a method on the NewClientParams struct rather than a function which receives the struct.
Add ability to specify PINECONE_API_KEY, PINECONE_ADDITIONAL_HEADERS, and PINECONE_CONTROLLER_HOST through environment variables. I kept the naming aligned with Python for now.

For these values, if the corresponding field has been passed through NewClientParams directly, the passed value will override anything set in the environment.

Add unit tests to validate override behavior, and headers being added as expected.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Infrastructure change (CI configs, etc)
[ ] Non-code change (docs, etc)
[ ] None of the above: (explain here)

Test Plan
CI and new unit tests.

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1207208972408325
https://app.asana.com/0/0/1207208968992757

Good improvement. It might be more clear to have multiple constructors vs ApiKey xor an Authorization header as a part of a headers array.
Technically, the ApiKey option is also just setting an Authorization header.

True, responded here: https://github.com/pinecone-io/go-pinecone/pull/22#discussion_r1596979649


add tests

Henry currently has no tests. It should have tests for at least easy-to-test things.

We should set up CI, too.


[Update translate] Synchronize nativescript-app-sync with nativescript-localize

Hi @EddyVerbruggen,
I use currently this plugin on my prod App, since we can not edit the Resources file and the translate wont be affected by the update. I've thought about how we can update the text or the translate on the app. I have done a little test, it work but I dont know how much it is a good solution !!
The idea is :
On the nativescript-app-sync side :
add a new options syncWithNsLocalize if is set create new boolean on the application settings  __SYNC_NS_LOCALIZE__
On the nativescript-localize side :
1- if __SYNC_NS_LOCALIZE__ is set we will import the json file __app__language__.json into localize.android.ts and localize.ios.ts
2- Override the string if the value that come from the json file dont match with the value from the resources file
I know the parser it is bizarre but I don't think yet if there is a better way to achieve this
// here it is the localize.ios.ts

const data = require('__app__language__.json');
let str = parser.parse(data, key, args);

if(str !== null && str  !== vsprintf(convertAtSignToStringSign(localizedString), args)) {
        console.log("VALUE ARE NOT SAME !")
        return str;
}

return vsprintf(convertAtSignToStringSign(localizedString), args);

const parser = {
    parse: (data: any, key: string, args?: any): string => {
        try {
            let splits = key.split(".");
            let value = null;
            for(let i = 0; i < splits.length; i++) {
                switch(i) {
                    case 0:
                        value = parser.value(data[splits[0]]);
                        break;
                    case 1:
                        value = parser.value(data[splits[0]][splits[1]]);
                        break;
                    case 2:
                        value = parser.value(data[splits[0]][splits[1]][splits[2]]);
                        break;
                    case 3:
                        value = parser.value(data[splits[0]][splits[1]][splits[2]][splits[3]]);
                        break;
                    case 4:
                        value = parser.value(data[splits[0]][splits[1]][splits[2]][splits[3]][splits[4]]);
                        break;
                    case 5:
                        value = parser.value(data[splits[0]][splits[1]][splits[2]][splits[3]][splits[4]][splits[5]]);
                        break;
                }
            }
            return vsprintf(value, args);
        } catch(e) {
            console.log(e)
            return null;
        }
    },
    value: (data) => {
        return data !== "undefined" ? data : null;
    }
}

Hi @shiv19, what do you think about this ?

Interesting idea.
So we could technically also add new localisation strings on the fly.
Instead of using the switch case, we could do something like this,
let value;
while(splits.length) {
  value = data[splits.shift()];
}

That way it can handle any length of splits :)
Not sure of the performance implications though.
It would be worth stress testing this on a large application.

Yes of cours :-D


Exception without proper message if there is no :db role in application

message:
cap aborted!
undefined method `roles_array' for nil:NilClass

Tasks: TOP => whenever:update_crontab
(See full trace by running task with --trace)
The deploy has failed with an error: #<NoMethodError: undefined method `roles_array' for nil:NilClass>

The problem is because there is no host here:
def setup_whenever_task(*args, &block)
    args = Array(fetch(:whenever_command)) + args

    on roles fetch(:whenever_roles) do |host|

I'm also experiencing this when specifying HOSTS as @mhfs mentioned. Is there a better workaround?

I'm running into this as well. I am trying to deploy to staging (where no hosts match the :db role), and it's complaining because no hosts are found. Any help? The PR above seems like it would work, but it was closed without comment also.

I just tried version 0.9.4 and it still has the same issue. Any chance this can be addressed?


[DON'T MERGE] debug CI

This is just to debug #11380.

Something new :smile:

unsuccessful-fw-test.log
Yay, I got a log after a force push.

RE: https://github.com/PX4/Firmware/pull/11401#issuecomment-461316952

Started by user Julian Oes
Restarted from build #6, stage ROS Tests.
.
.
[Pipeline] { (Build)
Stage "Build" skipped due to this build restarting at stage "ROS Tests"

You can't just restart that stage I guess. Need to restart the whole job.

You can't just restart that stage I guess. Need to restart the whole job.

This means the restart button should probably not be there...

It's because we're using stashes to hold onto the built px4 & sitl_gazebo package across stages. stashes don't persist between job builds. We might be able to address this problem if people think it is a worthwhile feature. The solution would involve pulling the artifact rather than the stash which does persist. I'm not sure how this would work if you hit restart a number of times greater than the artifacts are allowed to stick around (5 job builds currently), as the build discarder would likely throw it away at restart # 6 and we'd have the same problem.

It's confusing because restarting using the button used to work.

Interesting. I assume before the latest Jenkins upgrade? I can look into this.

Something new :confused: :

I'm looking at http://ci.px4.io:8080/blue/rest/organizations/jenkins/pipelines/PX4_misc/pipelines/Firmware-SITL_tests/branches/debug-jenkins-fw/runs/17/nodes/48/steps/134/log/?start=0
and I can see that the actuator message is 10 times published to uORB and only 9 times received on the simulator side.
I think the next step is to debug if it has been successfully sent by simulator_mavlink.

RE: https://github.com/PX4/Firmware/pull/11401#issuecomment-461456415 :+1:
Yeah... we're working it. Non-technically -- Flownodes are used to maintain states for Jeninks to resume builds when something bad happens. It has to do with durability settings, which you can't disable unfortunately. Anyway, hopefully changing EC2 instance type fixes it.

When you want it to fail it passes, need to force push this again.  :smile:

I can see that the actuator message is 10 times published to uORB and only 9 times received on the simulator side.

The same happened again. It's published to uORB and successfully sent via TCP 22 times but only 21 times received on the simulator side. Supposedly, with TCP these messages should not ever get lost. And we already use TCP_NODELAY to flush everything immediately.

Let's merge https://github.com/PX4/Firmware/pull/11426, then grind this branch (let jenkins run 20 consecutive builds) with the FW tests re-enabled.

Latest finding in the error case is this pattern:
INFO  [simulator] received HIL_SENSOR
INFO  [ekf2] publishing attitude
INFO  [pwm_out_sim] Published ORB_ID(actuator_outputs)
INFO  [simulator] Sent actuator_outputs
INFO  [simulator] received HIL_SENSOR
INFO  [ekf2] publishing attitude
INFO  [pwm_out_sim] Published ORB_ID(actuator_outputs)
INFO  [simulator] Sent actuator_outputs
INFO  [simulator] received HIL_SENSOR
INFO  [ekf2] publishing attitude
INFO  [ekf2] Mag sensor ID changed to 196616
INFO  [pwm_out_sim] Published ORB_ID(actuator_outputs)
INFO  [simulator] Sent actuator_outputs
INFO  [simulator] received HIL_SENSOR
INFO  [simulator] received HI
--> interruption from gzserver output, always somewhat like this interleaved
IL_SENSOR
INFO  [ekf2] publishing attitude
INFO  [pwm_out_sim] Published ORB_ID(actuator_outputs)
INFO  [simulator] Sent actuator_outputs
INFO  [simulator] received HIL_SENSOR

Exiting...

The two subsequent received HIL_SENSOR should not happen.

We're getting closer:
[Dbg] [gazebo_mavlink_interface.cpp:1084] Received HIL_ACTUATOR_CONTROLS (2592000, 2 592000000)

[Dbg] [gazebo_mavlink_interface.cpp:484] In OnUpdate.
[Dbg] [gazebo_mavlink_interface.cpp:719] sent mavlink sensor message
[Dbg] [gazebo_mavlink_interface.cpp:1084] Received HIL_ACTUATOR_CONTROLS (2592000, 2 596000000)
[Dbg] [gazebo_mavlink_interface.cpp:1084] Received HIL_ACTUATOR_CONTROLS (2596000, 2 596000000)

We receive two HIL_ACTUATOR_CONTROLS messages with the same timestamp.

Well, that workaround was either wrong or didn't work.

We get up to here but then sensors doesn't receive a gyro update:
https://github.com/PX4/Firmware/blob/6dfd526452c12d1e116951cec1389f613965cd0e/src/modules/sensors/sensors.cpp#L631-L632

@dagar upgrading the timestamper plugin in Jenkins to v1.9 might help here. It is supposed to fix the missing presence of timestamps in the console output for slave agents. https://plugins.jenkins.io/timestamper

@dagar upgrading the timestamper plugin in Jenkins to v1.9 might help here. It is supposed to fix the missing presence of timestamps in the console output for slave agents. https://plugins.jenkins.io/timestamper

Updated.

Nevermind... buffered stdout makes this mostly useless.

@dagar so here is the latest I've found:
What happens is that in sensors we usually enter px4_poll before the next gyro update becomes available. In that case we correctly get the update through the semaphore and move on.
For the failing case px4_poll in sensors is not called until after a new gyro sample has already been published. In this case we should never actually start waiting but return immediately from the poll here:
https://github.com/PX4/Firmware/blob/6302452066e3629f40d85823a07939eb192b1204/src/modules/uORB/uORBDeviceNode.cpp#L616-L626
According to @bkueng this should work unless there was already some orb_copy beforehand, although I wonder if this means an orb_copy by sensors or potentially someone else.
What we see from the printfs is that this appears_updated() returns false in the failing case.
INFO  [gyrosim] publishing sensor accel: 2100000
INFO  [gyrosim] publishing sensor gyro: 2100000
INFO  [accelsim] publishing sensor accel: 2100000
INFO  [sensors] before poll sleep with fds 8
INFO  [sensors] before poll with fds 8
INFO  [cdev] sensors: px4_poll: CDev->poll(setup) 8
INFO  [cdev] fds->events before: 1
INFO  [uorb] before appears_updated
INFO  [uorb] after appears_updated: not updated
INFO  [cdev] fds->events after: 1
INFO  [cdev] before px4_sem_timedwait, ts: 2.150000000 (sensors)

And if you're wondering why px4_sem_timedwait never times out: no more timestamp (in HIL_SENSOR) are sent from jMAVSim/Gazebo because it's still waiting for the last actuator control.
And if you're wondering why it only happens for fixedwing: this makes sense because there is only one path through the system, and if one pubsub copy fails somewhere, it falls apart.
For multicopter it seems like there is always one of the polls ready to grab the sample (or maybe there is even more going on that I don't understand).
I see two things to investigate next but I won't have time until Monday:

Try to reproduce this in the unit tests, so far I figured out to run them with make px4_sitl_test && make px4_sitl_test test. I would assume this is already in the test and works as expected but I haven't had time to check that.
Check what else could do the orb_copy and "steal" the sample from sensors if that's actually possible.

@dagar I think I've found the cause, now I just need to make a nice fix PR:
https://github.com/PX4/Firmware/pull/11401/commits/614e69cd65cb3ff67d3c15eb51bf01de5212f79f
The problem is that orb_copy is done on parameter change for the temperature calibration.

Not needed anymore, now that #11485 is in.


What the hell is wrong with the repo, getting all weird images, don't care the steps.😣

Describe the bug
I installed everything following this guide: https://pastebin.com/uE1WcSxD
The only steps i did different are:
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118
sudo apt-get install cuda=11.8.0-1

Everything seems to works fine but (while training), when i create images with AUTOS's GUI (i tried INVOKEAI too, same issue) all the images looks weird.
In the next image, you can see the training data used and the result images when using AUTO's:

💡And this is not a matter of steps numbers, i tried with different steps counts (1000 - 4500) and always get same weirds images.
I used this script to do the conversion to ckpt: https://pastebin.com/ct6mTzAA
But as i said before, it's not a conversion script problem, because i used the model in Diffusers format in INVOKEAI and i get the same weird results.
If someone could tell me what is wrong with the repo would be great.
Reproduction
Training process console:
(diffusers) zerocool@DESKTOP-MMG43AJ:~/github/diffusers/examples/dreambooth$ ./my_training.sh
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/accelerate/accelerator.py:249: FutureWarning: `logging_dir` is deprecated and will be removed in version 0.18.0 of 🤗 Accelerate. Use `project_dir` instead.
  warnings.warn(
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/transformers/modeling_utils.py:429: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  with safe_open(checkpoint_file, framework="pt") as f:
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/torch/_utils.py:776: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  return self.fget.__get__(instance, owner)()
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/torch/storage.py:899: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  storage = cls(wrap_storage=untyped_storage)
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/safetensors/torch.py:99: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  with safe_open(filename, framework="pt", device=device) as f:

===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
bin /home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/libbitsandbytes_cuda118_nocublaslt.so
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py:145: UserWarning: /home/zerocool/anaconda3/envs/diffusers did not contain ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] as expected! Searching further paths...
  warn(msg)
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py:145: UserWarning: /usr/lib/wsl/lib: did not contain ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] as expected! Searching further paths...
  warn(msg)
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py:145: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('runwayml/stable-diffusion-v1-5')}
  warn(msg)
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching in backup paths...
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py:145: UserWarning: Found duplicate ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] files: {PosixPath('/usr/local/cuda/lib64/libcudart.so'), PosixPath('/usr/local/cuda/lib64/libcudart.so.11.0')}.. We'll flip a coin and try one of these, in order to fail forward.
Either way, this might cause trouble in the future:
If you get `CUDA error: invalid device function` errors, the above might be the cause and the solution is to make sure only one ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] in the paths that we search based on your env.
  warn(msg)
CUDA SETUP: CUDA runtime path found: /usr/local/cuda/lib64/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 6.1
CUDA SETUP: Detected CUDA version 118
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/cuda_setup/main.py:145: UserWarning: WARNING: Compute capability < 7.5 detected! Only slow 8-bit matmul is supported for your GPU!
  warn(msg)
CUDA SETUP: Loading binary /home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/bitsandbytes/libbitsandbytes_cuda118_nocublaslt.so...
/home/zerocool/anaconda3/envs/diffusers/lib/python3.9/site-packages/diffusers/configuration_utils.py:203: FutureWarning: It is deprecated to pass a pretrained model name or path to `from_config`.If you were trying to load a scheduler, please use <class 'diffusers.schedulers.scheduling_ddpm.DDPMScheduler'>.from_pretrained(...) instead. Otherwise, please make sure to pass a configuration dictionary instead. This functionality will be removed in v1.0.0.
  deprecate("config-passed-as-path", "1.0.0", deprecation_message, standard_warn=False)
Caching latents: 100%|██████████████████████████████████████████████████████████████████| 35/35 [00:05<00:00,  6.10it/s]
04/19/2023 19:46:10 - INFO - __main__ - ***** Running training *****
04/19/2023 19:46:10 - INFO - __main__ -   Num examples = 35
04/19/2023 19:46:10 - INFO - __main__ -   Num batches each epoch = 35
04/19/2023 19:46:10 - INFO - __main__ -   Num Epochs = 58
04/19/2023 19:46:10 - INFO - __main__ -   Instantaneous batch size per device = 1
04/19/2023 19:46:10 - INFO - __main__ -   Total train batch size (w. parallel, distributed & accumulation) = 1
04/19/2023 19:46:10 - INFO - __main__ -   Gradient Accumulation steps = 1
04/19/2023 19:46:10 - INFO - __main__ -   Total optimization steps = 2000
Steps:   1%|▌                                                    | 19/2000 [00:33<45:12,  1.37s/it, loss=0.167, lr=1e-6]

Logs
No response
System Info

diffusers version: 0.15.0.dev0
Platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35
Python version: 3.9.16
PyTorch version (GPU?): 2.0.0+cu118 (True)
Huggingface_hub version: 0.13.4
Transformers version: 4.28.1
Accelerate version: 0.18.0
xFormers version: 0.0.18
Using GPU in script?: 1080 TI
Using distributed or parallel set-up in script?:

Same here, but only when using 8 bit adam. Without it it works perfectly fine. It seems like 8 bit adam causes the model to overfit very quickly. I've been trying to find a workaround for days but haven't gotten anywhere so now I'm justing playing around with steps and learning rate until something works.

Same here, but only when using 8 bit adam. Without it it works perfectly fine. It seems like 8 bit adam causes the model to overfit very quickly. I've been trying to find a workaround for days but haven't gotten anywhere so now I'm justing playing around with steps and learning rate until something works.

Check your bitsandbytes, there is a good chance you have a version above 0.35.0 and if so downgrade your bitsandbytes to 0.35.0 and train again. Basically there have been known issues with any bitsandbytes above 0.35.0 since the end of 2022 when using AdamW8bit, etc.
https://github.com/kohya-ss/sd-scripts/issues/523


Encyption in azure-cni?

Is this a request for help?:
Kind of?

Is this an ISSUE or FEATURE REQUEST? (choose one):
FEATURE REQUEST

Which release version?:
lateset

Which component (CNI/IPAM/CNM/CNS):
CNI?

Which Operating System (Linux/Windows):
Linux

For Linux: Include Distro and kernel version using "uname -a"
Ubuntu 16

So we're pretty new to cni plugins but we were looking for a way ensure service to service encryption between all pods on an aks cluster. We're looking at service mesh but we were thinking something lower level might offer more garuntees. Seems like calico/weave might offer pod 2 pod encryption. We were wondering if Azure CNI had considered a similar functionality. We've a pretty hard dependency on AKS at this point so azure-cni would be our main option. Even if you have no intention of pursing encryption in the azure-cni plugin that would be helpful info too.
Which Orchestrator and version (e.g. Kubernetes, Docker)
Kubernetes

we dont have a plan to support encryption between pods in this cycle. Will consider this workitem in future.


Fix blank screen displaying if oauth token is invalid

Also snips out some more DJANGO_API feature toggle code.
Closes #740.

I've got a couple opinions on this,

I feel like this would be better placed in publishRest.restoreLogin. Since that's where the error originates from, it'd be a good place to contain the error conditions
We should logout the user if this condition is reached. Since currently no logout is performed, the request will continue to fail until the user logs in again.

The following is what I had in mind:
    async restoreLogin() {
      await oauthClient.maybeRestoreLogin();
      if (!oauthClient.isLoggedIn) {
        return;
      }

      try {
        // Fetch user
        this.user = await this.me();
      } catch (e) {
        // A status of 401 indicates login failed, so the exception should be supressed.
        if (e.response.status === 401) {
          await oauthClient.logout();
        } else {
          // Any other kind of exception indicates an error that shouldn't occur
          throw e;
        }
      }
    },

@mvandenburgh what do you think?


Mixing template & !reference doesn't work?

Minimal .gitlab-ci.yml illustrating the issue
---
.docker_build: &docker_build
  image: docker/compose:latest
  stage: build
  services:
    - docker:dind
  variables:
    DOCKER_BUILDKIT: 1
    IMAGE_TAG: $CI_REGISTRY_IMAGE/php-$PHP_VERSION:$STAGE
---
build-php82: &build-php82
  <<: *docker_build
  variables: !reference [.docker_build, variables]
    PHP_VERSION: 8.2

Expected behavior
Shouldn't it work to expand variables from .docker_build?
for build-php82 it should finally look like this I think, combining variables from .docker_build and build-php82:
  variables:
    DOCKER_BUILDKIT: 1
    IMAGE_TAG: $CI_REGISTRY_IMAGE/php-$PHP_VERSION:$STAGE
    PHP_VERSION: 8.2

Or do I have something screwed in my code? Looking at this docs it should be possible:
https://docs.gitlab.com/ee/ci/yaml/yaml_optimization.html#nest-reference-tags-in-script-before_script-and-after_script
Host information
gitlab-ci-local 4.39.0

I'm not finally sure it work's, but I think my mistake was mixing !reference and the inheritance syntax <<: *docker_build which I figured out I can replace with extends: .docker_build. Just having to check it works as expected.
Currently testing this which at least began to run without initial errors:
---
.docker_build: &docker_build
  image: docker/compose:latest
  stage: build
  services:
    - docker:dind
  variables:
    DOCKER_BUILDKIT: 1
    IMAGE_TAG: $CI_REGISTRY_IMAGE/php-$PHP_VERSION:$STAGE
---
build-php82: &build-php82
  extends: .build-php82
  variables: !reference [.docker_build, variables]
    PHP_VERSION: 8.2

Looking inside existing unit-tests for this tool it seem's it's already covered like figured out in previous comment:
https://github.com/firecow/gitlab-ci-local/blob/b011e73b63ea5ba8ba7aa1c2d3f411791d9d8617/tests/test-cases/extends/.gitlab-ci.yml


Add more comments to hellodapr test app

Description
Add more comments to hellodapr test app
Issue reference
N/A
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[x] End-to-end tests passing
[ ] Extended the documentation
[ ] Specification has been updated
[ ] Provided sample for the feature

/ok-to-test


Clown Corps: Encourage reader to sort the chapters properly

Hopefully fixes #2107
Checklist:

[x] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[x] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[x] Have removed web_hi_res_512.png when adding a new extension

With your previous comments it is clear that this hasn't been tested. The changes are also made through GitHub's web editor, further confirming this.

I'm fine with the PR being closed if there is a better in-app , but I would like to mention that I very specifically did test the app. It still works just as well.
In fact, it does work a bit better:
Old:

New:

The history count is not very accurate at it is. I only noticed this after my original PR that adds this source was merged, but I didn't think it was worth the hassle of making a new PR to fix it.
If you look through all my previous commits, you will see that all of them are made through the GitHub interface.
I copy my code from Android Studio to GitHub.
I do it like this, because I do not want to set up git on my computer.
Please be assured that I did, and always do, test my PRs before I make them.


possible wrong anchor index?

https://github.com/qqwweee/keras-yolo3/blob/e6598d13c703029b2686bc2eb8d5c09badf42992/yolo3/model.py#L196
Should the indexes be "[[3,4,5], [0,1,2]]" in else?

Of course.

Yes


Remove obsolete table called schema_info & session

What problem does this pull request solve?
Remove obsolete db tables from db/schema
@DavidBiddle could you check your local instance to see if you have schema_info, because it was added over 4 months ago but it could be that it has been removed since.
@thomasiles could you check your local instance and make sure it does not include sessions table.
Trello card:

Things to consider when reviewing

Ensure that you consider the wider context.
Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

I agree with these changes, I dropped my database and ran all the migrations through, and the resultant schema file was missing these two tables.


Add screenshots or an online demo

It's a nice interface, would be interesting to give potential users an impression before they compile it on their own.

Thanks.


Circle ci

Bring Circle test configuration into Master branch.

The CircleCI dashboard shows compilation failures and successes. Does it
also show warnings if they do exist?
On Mon, Aug 26, 2019 at 11:25 AM sgpearse<EMAIL_ADDRESS>wrote:

@sgpearse https://github.com/sgpearse what will be the visible impact
of these changes once this PR is merged?
The main visible impact will be the appearance of either a green checkmark
or red X next to our PR's, indicating whether the PR builds on Ubuntu 16.
Build reports will be compiled on our CircleCI dashboard, linked below:
https://circleci.com/gh/NCAR/workflows/VAPOR
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NCAR/VAPOR/pull/1838?email_source=notifications&email_token=AAGG6JL5A7DYDOPDNNASH5LQGQGYXA5CNFSM4IPCYCSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FBSWY#issuecomment-524949851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGG6JNSIXYTOIB3WNRTWLDQGQGYXANCNFSM4IPCYCSA
.


What's the module name which has all these awesome commands?

Didn't see it on this page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2648ec32-2716-4f6e-20f1-1a989aa8cc45
Version Independent ID: 53e81f24-1e27-9c50-439b-7916e7d1045d
Content: SkypeForBusiness Module
Content Source: skype/skype-ps/skype/skype.md
Service: skypeforbusiness-powershell
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

Hello @Mike19130
You can find information on how to run these cmdlets in the introduction of the article:

The following cmdlet references are for Skype for Business and Microsoft Teams. You can find information on installing the module for Skype for Business Online here: https://docs.microsoft.com/office365/enterprise/powershell/manage-skype-for-business-online-with-office-365-powershell. If you are using Skype for Business Server then the cmdlets are available in the Skype for Business Server Management Shell and you can find information about it here: https://docs.microsoft.com/skypeforbusiness/manage/management-shell.

Hope this information helps you.

@get-itips Thank you very much for the contribution and sharing this explanation. @Mike19130 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


How to increase number of shards per index

Current default configuration is 5 shards per primary, as indecies grow this can cause performance issues if the index grows over 3-400gb in size, the shard number is set upon index creation.  Where do we specify the number of shards per index?

The number of shards is specified in the index template matching the log index
https://opensearch.org/docs/latest/opensearch/index-templates/
You can modify existing index templates to increase the "number_of_shards" property, but the simplest method to split indices into more smaller shards is to rotate indexes more often, e.g. by switching from monthly to daily indexes in the user.ini file.

Hi, have you read this doc? https://github.com/aws-samples/siem-on-amazon-opensearch-service/blob/main/docs/configure_siem.md#changing-opensearch-service-configuration-settings

If you have still issue, please reopen the isseu.


Merge master branch to prTesting1_201906051056 branch

Docs Build status updates of commit 9c8c3fa:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 9c8c3fa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Code Editor Formatting

I still haven't figured out the best way of implementing a decent Code Editor in QML...
The QML TextEdit object provides access to a QQuickTextDocument instance, but the docs say that You are not allowed to modify the document.... So my guess is that the QTextCursor API can't be used for text processing. So there's still some research to do..

Is it really worth it writing a custom editor? Maybe a simpler option is to write a Visual Studio Code plugin instead?

Yes, I agree. It would be much simpler to rely on an external editor. But still, there are many advantages of a built-in solution and I'd like to try one last approach.
Until a proper implementation, I'd like to remove the current editor and use a different strategy. I already developed a simple prototype which relies on Qt's FileSystemWatcher. A plugin might not be necessary since most editors have some way to support QML syntax.

Yeah exactly, that would have been the second thing I would have proposed; just reload qml based on a file watcher. But a plugin would make it possible to highlight lines with errors in the editor during runtime.

I've got a first working solution and made the editor read-only for now. I'm going to close this issue since it's not really relevant anymore.
Let me know what you think of the current implementation!

What about just using the QML TextEdit so experimentation is possible? It doesn't have to have full auto complete ala QtCreator but some ability to edit would be nice.


[move][changelog] Changelog entry for Move Packages

Add changelog entry for Move Package System

Thanks for the review (and the kind words)! I don't think this has to go in today as the branch cut has been pushed out. I was just talking with Bob and I think trying to get this into the book before the cut would make sense as well if possible (I'll put up a separate PR for that tomorrow morning).


navbar-text jumping down when resizing from small to large window

I am running bootstrap 3.3.5, but I can reproduce this since 3.3.1.
Basically, on a navbar that contains an element with navbar-text class, resizing this element from a small screen to a larger one causes the navbar-text to jump down on a second line within the navbar. Refreshing the screen puts the navbar in the right position.
The issue is currently reproducible in our production environment (https://www.heldendervolksmusik.eu/login) in Chrome and Safari (have not tested with IE or FireFox). Steps:

Size the browser window to small screen (so that the collapsible navbar menu appears)
Increase the size of the screen so that the the collapsible disappears. You will see that the navbar-text jumps to a second line.
Refresh the screen. The navbar-text element will be correctly positioned within the navbar.

Please create a simpler reduced testcase; see https://github.com/twbs/bootstrap/blob/master/CONTRIBUTING.md#bug-reports

I can reproduce this in Chrome, but not in Safari 8.0.8 or Firefox 42 or IE11.
Seems like a Chrome bug, possibly related to your custom CSS. We'll need a simplified test case to confirm that.

Hey there!
We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 14 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.
Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.
Thanks!
(Please note that this is an automated comment.)


ARROW-4051: [Gandiva] [GLib] Add support for null literal

Add #GGandivaNullLiteralNode.
Remove return_type property in #GGandivaFunctionNode to use ggandiva_node_get_return_type().

Codecov Report

Merging #3197 into master will increase coverage by 1.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3197      +/-   ##
==========================================
+ Coverage   86.43%   87.48%   +1.05%
==========================================
  Files         504      446      -58
  Lines       69628    65862    -3766
==========================================
- Hits        60181    57620    -2561
+ Misses       9350     8242    -1108
+ Partials       97        0      -97

Impacted Files
Coverage Δ

go/arrow/array/table.go

go/arrow/math/uint64_amd64.go

go/arrow/internal/testing/tools/bool.go

go/arrow/internal/bitutil/bitutil.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/array/null.go

go/arrow/datatype_nested.go

go/arrow/array/string.go

go/arrow/math/uint64_avx2_amd64.go

go/arrow/array/builder.go

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1934f...0ac03b4. Read the comment docs.

CI failure is unrelated. I'll merge this.

Thanks!

TODO: GArrowField keeps GArrowDataType passed in garrow_field_new() and provides it by property.

I’ll send a pull request to address it.


Typewrite-like centered writing

Did you check the docs?

[X] I have read all the zen-mode.nvim docs

Is your feature request related to a problem? Please describe.
It would be amazing to have typewrite-like experience by moving beginning of the document to the middle of the window. As words are written, new lines are always centered to the middle. Please see video below:

Describe the solution you'd like
A typewriter flag option to enable this type of writing experience.
Describe alternatives you've considered
Using iA Writer instead of nvim? :sad:
Additional context
No response

We don't need a new feature for this. Setting scrolloff to a large number will do. For example,
opts = {
  window = {
    options = {
      scrolloff = 999,
    },
  },
},

I tried that but there was no change whatsoever. Doing :set scrolloff 999 directly did nothing, too. What should be result of setting this option?

Just tried running nvim -u NONE with plain config and setting scrolloff doesn't seem to do anything.

It's :set scrolloff=999.

Either your config does not respect scrolloff, or your file does not have enough lines of visible text to satisfy scrolloff setting. The later is documented:
'scrolloff' 'so'        number  (default 0)
                        global or local to window global-local
        Minimal number of screen lines to keep above and below the cursor.
        This will make some context visible around where you are working.  If
        you set it to a very large value (999) the cursor line will always be
        in the middle of the window (except at the start or end of the file or
        when long lines wrap).

scrolloff documents desired behavior but it doesn't seem to work at all. I tested it on long files (>400 lines) with nvim 0.10 and 0.9.5 on three independent workstations.

scrolloff does not what it described and shown in the original comment. It scrolls the text so that (when possible) there are always at least five lines visible above the cursor, and five lines visible below the cursor.

I would love a feature like this. Any other suggestions or plans to support this kind of functionality in zen-mode?


'keybase id max' returns an error

When I id max I'm seeing this: error: Subkey 4af88842f72a59565c669bde980a3f0d01fe04df expired at<PHONE_NUMBER> but we checked for time<PHONE_NUMBER>

My guess is this is an error in subkey merging.  There are two signatures on that subkey, and the subkey merge operation is using the signature with the shorter expiration time; that's somehow overwriting the extension by the second signature.

That server fix did indeed fix this bug, but I wonder if we should fix the subkey merging algorithm to take subkey that expires furthest into the future.  This was my original plan but I nixed it to make things simpler.

New kbpgp @v2.0.28 has the improved subkey merging algorithm.  This is likely the right approach.


extra space after a number in section a

environment

vim: 8.1.0022
vim-airline: master
OS: arch linux
terminal: Konsole
$TERM variable: xterm-256color
color configuration (:set t_Co?): 256, termguicolors

I'm trying to show the window numbers of inactive windows in the first slot, where the mode usually goes, except for the previous window where I show a '#'.  There seems to be a spurious space when this string is a number, but not when it is a symbol (see the '#' in the screen shot).  The following example should reproduce this.  When switching between windows, the numbers change and there is always a space after the number.

minimal working example
set nocompatible
let &rtp  = '~/.vim/plugged/vim-airline,' . &rtp
let &rtp .= ',~/.vim/plugged/vim-airline/after'

filetype plugin indent on
syntax enable

let g:airline_mode_map = {
            \ 'n'  : 'N',
            \ '__' : '',
            \}
let g:airline_left_sep = ']'
let g:airline_left_alt_sep = '>'

function! AirlineWinnr()
  return winnr() == winnr('#') ? '#' : winnr()
endfunction
call airline#parts#define_function('mywinnr', 'AirlineWinnr')
call airline#parts#define_condition('mywinnr', '!w:airline_active')

au User AirlineAfterInit let g:airline_section_a
    \ = airline#section#create(['mywinnr', g:airline_section_a,])

let g:airline_inactive_collapse = 0
let g:airline_skip_empty_sections = 1

set spell
sp|sp|wincmd _

actual behavior

expected behavior
There should be no extra space after the window number.

Hm, that is interesting. I cannot offhand see, what is responsible for that.

Compare:
 :let &statusline='%{"L"}%{" |"}'

to
:let &statusline='%{"1"}%{" |"}'

Apparently it is the same as this feature/bug: https://github.com/vim/vim/issues/1431
When an expression evaluates to an all digits string, it is handled as a number and not a flag (set itemisflag = FALSE).  This is actually documented, but the space removal behavior is not (only comma removal).
I don't see the point of all this special casing- when an expression is used, I might expect it to be treated as a literal string, regardless of whether it looks like a number or not.  I would submit a patch, but I am not quite bold enough to suggest changing ancient code of which I don't fully understand the original intent.
Furthermore, I suppose it's possible vim-airline and others already expect and use workarounds for this which will break if a change is made.  In particular, if I change itemisflag = FALSE for STL_VIM_EXPR, then there will always be an extra space after the mode symbol ("NORMAL") and the left_alt_sep which is still not the desired behavior.

Ah, I remember that discussion. I agree, changing this code in Vim will likely introduce more problems with fancy statusline plugins. So for now let's just keep this open.


ci: Pull request created in a GitHub action does not trigger workflows with pull_request trigger

Pull request created in a GitHub action does not trigger workflows with pull_request trigger
See: #87
Needs to investigate - maybe related to https://github.com/orgs/community/discussions/65321 and/or https://github.com/orgs/community/discussions/57484

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run.
If you want to run workflows from those events, you'll need to provide a PAT.

Document for WA: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

It's resolved via #89
Result: #90

Using PAT instead


docs(Form): update to latest standards and make minor fixes

refactor
fix placeholders in read-only example
add missing .
add one example for inline group fields

Current coverage is 99.49% (diff: 100%)

No coverage report found for master at e3c972b.

Powered by Codecov. Last update e3c972b...474370f

Thanks again!


Creating and respecting dice.conf file

Add one sub-command in dice called init-config that would create the .conf file for DiceDB. This file should be exactly what redis.conf is. It is okay if we are not supporting all options and configurations mentioned. Let's respect the following to start with

port
requirepass

go run main.go init-config

The default path of the dice.conf file should be /etc/dicedb/dice.conf. But by passing -o in init-config we should be able to change the location.
Also, add support for flag -c <path to config file> that user can pass while starting the server. and we should read the config and respect the configurations.
go run main.go server -c /etc/dice.conf

When the server starts, if -c flag is passed, read and use that config file. if not

check dice.conf in current directory
check /etc/dicedb/dice.conf file

maintain this as a list in the code so that we can define the order in which we will check the presence of the conf file.
Also, when the server starts, output the dice.conf file it is using.
Note, For every configuration in dice.conf there will be a sane default and if no conf exists, we use that sane default.

@arpitbbhayani would like to work on this.

@lucifercr07 thanks for taking this up. go for it!

could you assign it to me?

@arpitbbhayani  Can you assign me this issue. I want  to work on this

Hello @vinitparekh17,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

@arpitbbhayani Can I pick this up?

@arpitbbhayani To add to this, presence of flags to cmd line params will always have highest priority than config file. I really liked how convoy uses configs, combining with presence of flags

Hello @vinitparekh17,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

Hello @arpitbbhayani,
Thank you for the reminder. I’ve been actively incorporating feedback from the community and am working to complete the task soon. You can check the progress in the PR here.
I appreciate your patience and will provide updates as I move forward. If you have any questions or additional feedback, please let me know!
Thanks again.

Hello @vinitparekh17, I see your PR got merged. https://github.com/DiceDB/dice/pull/450/
Thank you so much for taking this up. this was one of the most critical things that we wanted for a great UX and so happy to see this getting merged :) super thanks for doing this.
should I close this issue now?

Hello @vinitparekh17, I see your PR got merged. #450
Thank you so much for taking this up. this was one of the most critical things that we wanted for a great UX and so happy to see this getting merged :) super thanks for doing this.
should I close this issue now?

@arpitbbhayani, It's an honor to be part of this community, and I look forward to working on more issues like this in the future.
If our desired outcome has been fulfilled, we can go ahead and close this issue. Once again, thank you for your patience and for giving me the opportunity to contribute.

Closing the issue, merged as part of https://github.com/DiceDB/dice/pull/450. Thanks @vinitparekh17 for contributing.


CMS-566: fix issue in which some seasons didn't have any dates at all

Jira Ticket
CMS-566
Description
This changes the one-time-data-import script so that seasons and dates will only be created for active features. Some inactive features have missing dates or dates that are also inactive.
Given that the API considers which features are active and which features have dates, we don't want to create "seasons" for features that wouldn't be returned by the API anyway.
Note that this requires the database to be recreated and all the syncing process to be done from scratch. Just follow steps 1 to 7 in the readme.
The required: false  in the query is to make the query a left outer join instead of an inner join. This was causing 500 errors given that in some cases dateable was being returned as null even though the feature had a dateable.

I discovered that required thing when I was doing the query for the CSV too :D it was kind of hard to get my head around it in a nested code structure compared to just writing a query, but it makes sense now.


Names of the member roles

The names for the roles of project members is a little bit misleading. Perhaps "owner" could be changed to "maintainer".

And is it possible to write an help text for the roles to explain their privileges?

A help text is already available on the invite member page.


Formatting "line-comment" with "\r\n" are not support

Some system end line with \r\n, and the LINE_COMMENT_REGEX is /^((?:#|--).*?(?:\n|$))/.
So the situation like -- some line comment xxx \r\n balabala cant not be formatted right.
Hope to support this situation. Many thanks!

I saw this was fixed in PR #64. In the meantime while we wait for it to be merged you can use my fork I published with this fix. https://www.npmjs.com/package/sql-formatter-plus

This fix is now available in 3.1.0 release.

This fix is now available in 3.1.0 release.


Upon restart some stacks never start

⚠ Please verify that this bug has NOT been reported before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
When the host is restarted (Truenas scale running jlmkr / dockge) some stacks start but others show exited or not up completely.  If i go into the stacks manually and click start they start without issue.

👟 Reproduction steps
Restart the host
👀 Expected behavior
all stacks should start without issue
😓 Actual Behavior
some stacks do not start.  Speculation that the docker sock exposed by traefik is not available and is required by other stacks, no way to do "depends on" between stacks.
Dockge Version
1.4.2
💻 Operating System and Arch
Truenas Scale (<IP_ADDRESS>.3) / Jlmkr running - Debian release 12 codename bookworm
🌐 Browser
Firefox - most current
🐋 Docker Version
20.10.24+dfsg1
🟩 NodeJS Version
No response
📝 Relevant log output
No response

the docker sock exposed by traefik is not available

I am not sure I understand: the docker socket is provided by docker (and the OS) and Traefik just makes use of it.

Might be the wrong status bug, which I still don't know how to 100% reproduce it. They maybe actually up.

The apps themselves are NOT up.  Take the arr's stack above where some say started and some are not.  The overseerr app is up however sonarr / radarr is not and returns a 404 when i attempt to access.  I wish i could stack rank or priority order start the compose files at a minimum (assuming i couldn't depend on another app in a diff stack) to buy time for the picky stacks such as my arr's stack.
With respect to the docker sock.  from a security perspective, the docker sock is not directly exposed and instead is exposed through the socket-proxy service seen in the traefik stack.  I tried making other stacks depend on the status of another however that doesn't work because you can't make one compose depend on another (from what i gathered)

I'm having the same issue , but I am new to docker so it may be that.
I have linkding , readeck and uptime-kuma setup and working.
However readeck doesn't start , or perhaps does start and fails.
If I start it manually it works perfectly.

same for me in that if i restart it manually it works.  It just never fully loads on a server restart.

I created a new ProxMox LXC , installed Docker - just the command line version this time.
Copied the data directory across.
This starts Readeck on Host restart every time so far.

Glad your issue is resolved however, mine is not and i have no indication why those containers won't start without manual intervention


Problem matcher is slightly off

This seems like the "fault" of cargo fmt rather than this action, but FYI — the lines for the problem matcher are slightly off:
https://github.com/PRQL/prql/pull/2558/files#diff-d8cf470395314450935c363c0f82ef23888873d109e7df81e131728c66265e84L128-L132

It looks like this is because the line number reported by rustfmt is from the top of the code it shows. I think technically the selection for GH should match to the lines marked with -, rather than the 128:
Diff in /Users/maximilian/workspace/prql/prql-compiler/src/lib.rs at line 128:
     parser::parse(prql)
         .and_then(semantic::resolve)
         .and_then(|rq| sql::compile(rq, options))
-        .map_err(
-            error::downcast
-        )
+        .map_err(error::downcast)
         .map_err(|e| e.composed("", prql, options.color))
 }

Just looked at how these work — looks like it's not sophisticated enough from GH's side to handle this well: https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md
So feel free to close...

Problem matcher are not powerful enough to alter the extracted data in any way. They are only as powerful as regex and have to work with the line information as printed by rustfmt.
Any more complex processing would require it's own action.
You can remove the problem matcher if the inaccuracy is a problem.
echo "::remove-matcher owner=rustfmt::"

There is an action to show the rustfmt results as an execution summary document. It still uses the line numbers as printed by rustfmt. https://github.com/actions-rust-lang/rustfmt/


bug: logs emitted on RPC failures when forking are not descriptive enough

Component
Forge
Describe the feature you would like
It's quite common in our codebase to experience CI failures related to RPC errors. For example:
Could not instantiate forked environment with fork url: ***
or
[FAIL. Reason: backend: failed while inspecting]

Here are some logs for more context
https://github.com/moonwell-fi/moonwell-contracts-v2/actions/runs/10927647686/job/30334305230?pr=350
https://github.com/moonwell-fi/moonwell-contracts-v2/actions/runs/10944099346/job/30385149157
It would be really great if the error messages from Forge could give us more details. We are not Rust engineers, so it's tough for us to figure out what's causing the issue.
Thank you!
Additional context
No response

@anajuliabit would it be possible to provide more informations on the failure (which RPC, fork block heights, etc), we're looking into a constant reproducing the issue to understand where the issue lies and provide a better err message. thank you!

@anajuliabit would it be possible to provide more informations on the failure (which RPC, fork block heights, etc), we're looking into a constant reproducing the issue to understand where the issue lies and provide a better err message. thank you!

The providers we are using are BlastAPI and Alchemy for Base and OP mainnet. The errors seem to occur on both.
On some networks like Moonbeam we are only using BlastAPI because that's the only provider we have.
The 520s seem to be intermittent and not correlated with any single network or RPC provider. Perhaps you could implement an exponential backoff/retry for these instead of crashing?

The 520s seem to be intermittent and not correlated with any single network or RPC provider. Perhaps you could implement an exponential backoff/retry for these instead of crashing?

Hey @lyoungblood you could try setting --fork-retries and --fork-retry-backoff` to avoid such see https://book.getfoundry.sh/reference/cli/forge/script#forge-script


Disable recurrent backups for Windows

Do not propose recurrent backups in config wizard on Windows systems

Keep the portable option in time2backup.bat


can't import cPickle from rdkit.six.moves

from rdkit.six.moves import cPickle fails due to a recent change included in #2315 and affecting the bundled six module at line https://github.com/rdkit/rdkit/blob/master/rdkit/six.py#L209
Removing this module might be planned for the next patch release, so this issue may be just FYI (the change applied to rdkit.six looks like may have been unintended).

RDKit Version: 2019.03.1
Platform: linux

We almost certainly should remove rdkit.six, but that would probably be for the 2019.09 release.
How did you encounter this?

Some internal rdkit addons have been importing six from rdkit for historical reasons and convenience, but I guess they could be quickly ported to use an independently installed six package (for now, until support for python 2 is dropped there too).

What is the final solution to this error? Is there an alternative command to import cPickle. I'm working on someone else's code where they used this import command. What would be an appropriate replacement?

I don't think there is any good reason to use cpickle today. If you are using python 3, replace it with pickle.
https://stackoverflow.com/a/37138791

@greglandrum Is there a reason to have this issue still open?

Nope. Closing it.


TDA SPIKE [DO NOT REVIEW]

Context
Move along. Nothing to see here.

 TDA Apply - Update review app for user testing

 Update and add one more page to the degrees on TDA Apply prototype for user testing


GNU utilities are being unnecessarily used

As it stands, Danger uses the GNU utilities (mostly touch, grep, and head) in a handful of places. This makes it a bit tricky to use Danger on platforms lacking the GNU utilities (such as Windows) without resorting to messy UNIX-emulation solutions.
I don't see any reason why these calls couldn't be replaced with native Ruby methods (touch with File.open, etc) and have begun to work on this in a local fork.
@KrauseFx suggested I open an issue on this to encourage people to comment on this change, should there be any objections.

Yeah, using FileUtils is cool with me 👍  - is there a good/free CI service that can run window images so we can run the test suites on it?

@orta appveyor.com
I'm also happy to help move us over to ruby stuff instead of backticks

Nice one @segiddins - I've set us up with Appveyor - https://ci.appveyor.com/project/orta/danger-47jiu
Might affect upcoming PRs so will figure that one as we come to it

https://www.appveyor.com/docs/lang/ruby - docs on ruby
I assume we need something like:
# appveyor.yml
install:
  - set PATH=C:\Ruby22\bin;%PATH%
  - bundle install

build: off

test_script:
  - bundle exec rake spec

Alright, that's both it working on Windows, and it staying that way via CI in #333 👍


Fixed typos, cleanup in README.

Updated text for clarity - can you review, thanks.

Great, thanks!


init CloudWatch Forwarder module

Created a terraform module that empowers terraform users to setup Axiom's CloudWatch forwards through IaC.
note: This PR creates a forwarder module and takes care of creating logs groups, there is no subscriber or unsubscriber involved.
Its currently missing the right config for releasing and thus the docs is missing an installation guide.

we decided to make the terraform part of the original cloudwatch-forwarder repo to optimize for easier maintenance.


Rename to metatrain (Python) and mtt (CLI)

As we agreed before this is renaming to the new name metatrain choo choo.
After we merged, I will rename the Github project (which will brake the links on your local repos).
If you have better ideas for the short description (whichI will also add to the sidebar of the Github project)
description = "Train machine learning models for atomistic systems."

I am happy for suggestions. This also holds for the first paragraph of the README.rst.
additional change
Besides the renaming, I also updated the completion script to complete the new commands in eval and export which we lately added. This includes the completion for the architecture_names in the export command.
$ mtt export <tab>
experimental.alchemical_model  experimental.pet               experimental.soap_bpnn

📚 Documentation preview 📚: https://metatensor-models--220.org.readthedocs.build/en/220/

Why mtt and not just mt?

Why mtt and not just mt?

mt already exists at least on Linux
MT(1)                                                               GNU CPIO                                                              MT(1)

NAME
       mt - control magnetic tape drive operation

SYNOPSIS
       mt [-V] [-f device] [--file=device] [--rsh-command=command] [--version] operation [count]

Also I prefer three character command.

Sure, we can wait and merge the gap branch first.


Statistics Calculator Step 22 Bad Error Message

Describe the Issue
The below code returns this error message

If the array.length is even, your median variable should use the getMean function to calculate the mean of the two middle numbers. Your first argument should be the value of sorted at array.length / 2, and the second at array.length / 2 - 1.

But, getMean only accepts one argument - an array. The error message needs to be corrected/clarified.`
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-advanced-array-methods-by-building-a-statistics-calculator/step-22
Your code
const getMedian = (array) => {
  const sorted = array.sort((a, b) => a - b);
    const median = array.length % 2 === 0
    ? (sorted[sorted.length / 2 - 1] + sorted[sorted.length / 2]) / 2
    : sorted[Math.floor(sorted.length / 2)];
}

Expected behavior
Error message should be accurate. Perhaps

If the array.length is even, you should use the getMean function to calculate the mean of the two middle numbers. You should pass an array with two entries to getMean. The first entry should be the value of sorted at array.length / 2, and the second at array.length / 2 - 1.

Screenshots
No response
System
All
Additional context
No response

This challenge is tough, and the wording is slightly confusing. How about...
If `array.length` is even, pass an array with its two middle numbers to the `getMean` function.
The first item in the array argument should use the value at index `array.length / 2` of `sorted`,
and the second should use the value at index `array.length / 2 -1]` in `sorted`.

Minor proposed tweaks - I've found that it gets confused a lot. Also, we the array isn't really "using" anything so much as having values set from the sorted array.
If array.length is even, pass an array with the two middle numbers from the sorted array to the getMean function.
The first item in the array argument should be the value at index array.length / 2 from sorted and the second should use the value at index array.length / 2 - 1 from sorted.

Sounds good to me - I think we go with your last suggestion there @jeremylt 👍 The file that needs to be changed is here: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-advanced-array-methods-by-building-a-statistics-calculator/635090f47eb6d9563a6fed05.md We want to update the third hint with the new suggestion.
An issue with the https://github.com/freeCodeCamp/freeCodeCamp/labels/first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum


Full CallerID support for Bson/gRPC APIs and tabletconn

@alainjobart
Now the VTTablet & tabletconn should fully support CallerID

LGTM


Adding docstrings for array, assert and panic macros

What it solves?
It solves this issue #6541
Changes Made
This PR is adding the docstrings for some macros in the basecode. Specifically for assert!, panic!, array! macros.
Status
This PR still work in progress. But I would like to receive some feedback about the work so far.
Errors
I dont know why I'm getting these errors for some of the macros related to format. Look these screenshots:

In many places in the code of the macros I'm getting those weird errors.

This change is

Lmk what you think now sir.

I was inside of the Reviewable but I did not find a way to comment through that tool, sorry. Is my first time using it.

Previously, mkaput (Marek Kaput) wrote…

Please use Reviewable for commenting

I dont know why I'm getting these errors for some of the macros related to format. Look these screenshots:

You need to import the indoc macro, add use indoc::indoc

Got it sir. Now I know how to comment through reviewable. Thanks.

crates/cairo-lang-semantic/src/inline_macros/assert.rs line 11 at r2 (raw file):
Previously, orizi wrote…
Please rebase to use the latest rust fmt version.

Done.

crates/cairo-lang-semantic/src/inline_macros/array.rs line 80 at r2 (raw file):

            - Elements are added in the order provided.
            "#}
            .to_string(),

I think I addressed what you suggested. If not, please lmk.

crates/cairo-lang-semantic/src/inline_macros/assert.rs line 142 at r3 (raw file):
Previously, orizi wrote…
maybe we should have an example with this style?
in panic as well.

Done.

crates/cairo-lang-semantic/src/inline_macros/assert.rs line 132 at r3 (raw file):
Previously, orizi wrote…
shorten or split line. (under 100 rust chars)
also elsewhere if still exists.

Done.

I dont find the assert_eq! macro, it doesn't exist on the basecode?

I found the assert_eq! macro in cairo-lang-test-plugin. And inside of the assert.rs file is not too clear for me where to add the function. Do I add it just next to the generate_codefunction and thats it?


Fix xfailing tests.

These test broke as a result of changes in the file and url structure of the application, but there are no apparent issues in the application.

No longer relevant.


support asymmetric padding without implementing custom layers in caffe when converting tf to caffe

The padding problem is well explained in Error in mobilenet conversion from Tensorflow to Caffe Different way of padding.
A possible solution is implementing a custom padding layer in caffe and then modifying mmdnn to use that layer, which needs a lot of extra work. I think we could use symmetric padding and then crop when converting, which is easier for users.
For example, when converting a convolution layer 'conv_2D_6' of of padding like (pad_w, pad_h, pad_w+1, pad_h) from tensorflow to caffe (note for tensorflow, asymmetric padding can only be pad_w vs pad_w+1, pad_h vs pad_h+1, if I haven't got wrong):

change the horizontal padding from (pad_w,pad_w+1) to (pad_w+stride, pad_w+1+(stride-1)).
The extra paddings of length stride at left brings one extra column at left of the convolution result while extra paddings of length (stride-1) at right is discarded during convolution. So the result of inputs with symmetric padding is the original result plus one extra column at left.
use a crop layer remove the first column.

The same strategy applies to pool layer.
After using that, our model passed the test with error=1e-5, L1 error=0.006, SNR=64.10, PSNR=79.12.
I also tested on MobileNets v1, it achieves a better result than the wiki.

Result after modifying:
error: 0.29709578305482864
L1 error: 0.6029861
SNR: 6.288722375836028
PSNR: 36.219608961427426
Origin result on wiki:
error: 0.61917245
L1 error: 1431.8882
SNR: 5.100172946375377
PSNR: 19.59308572747237

By computing the SNR of input and output of each layer, I think the reason for the still poor SNR of MobileNets v1, seems to be relu6, which is not supported in caffe.

you can look it #153

@ujsyehao Thanks, I hadn't found a similar approach has been implemented.

@CuiXiaoDao It is an effective method, the relu6 layer is easy to implement.


Use PPA's to install dependencies on Ubuntu installation script

Reading the source code of the installation script for Ubuntu install_ubuntu.sh I see that the following dependencies and its dependents are build from source or compiled

i3 gaps
Polybar

Maybe the code can be refactored to use PPA's?
I have personally use this PPA to install some of those dependencies, which is maintained by the regolith-linux team
Hope this helps to avoid less bugs like those mentioned in #107 ?

Hello sir,
I have personally never used the PPA directly (I've used i3 on Ubuntu like only once in the past), so I don't know if there would be any major difference. But in general it's a good idea to use it to avoid dependency issues. Would you mind creating a PR with the suggested changes?

Hi!
Yeah I would have no problem to create a PR, give me a week to test with those changes, if there is no Pull Request means that my experiment failed.


imagemagick: 7.1.0-23 -> 7.1.0-24

Motivation for this change
https://github.com/ImageMagick/ImageMagick/blob/7.1.0-24/ChangeLog
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 159893 run on x86_64-linux 1

6 packages built:

imagemagick
imagemagickBig
imagemagick_light
perlPackages.ImageMagick
python310.pkgs.Wand
python39.pkgs.Wand


Non-emoji Unicode characters show up as big text when sent alone

Here is an example with Apple's curly quotes


Added bar and line chart for issues

Description
A responsive chart component that displays issue counts from a GitHub repository. It allows users to filter issues and choose between daily, monthly, or yearly views. The chart type can be switched between bar and line graphs.

Fixes #140

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

Hi @Aarzookhunger,
please review this PR

@mehul-m-prajapati can you please add screenshots for open vs closed issues like you mentioned in the issue.?


Revert "Add segmented control to gallery (#19192)"

This appears to trigger an error during AOT snapshot of the gallery as
follows:
stdout: [   +6 ms] Building AOT snapshot in release mode (ios-release)...
stdout: [  +15 ms] Extra gen_snapshot options: [--print_snapshot_sizes]
stdout: [   +7 ms] /usr/bin/arch -x86_64 /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot --await_is_keyword --causal_async_stacks --packages=.packages --url_mapping=dart:ui,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart --url_mapping=dart:vmservice_io,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/sdk_ext/vmservice_io.dart --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_vm_entry_points.txt --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_io_entries.txt --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S /Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/main.dart
stderr: [+9324 ms] Error: 'file:///Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/demo/cupertino/cupertino_segmented_control_demo.dart': error: line 19 pos 1: circular dependency for function _CupertinoSegmentedControlDemoState
stderr: [        ] class _CupertinoSegmentedControlDemoState extends State {
stderr: [        ] ^
stderr: [  +33 ms] Dart snapshot generator failed with exit code 254
stderr: [        ] Snapshotting (IOSArch.arm64) exited with non-zero exit code: 254
stdout: [        ] Built to build/aot/.
stdout: [  +10 ms] "flutter aot" took 9,485ms.

This reverts commit 9d49ee3bf06e634e53331b544dbb640453f81348.

Landing on red in hopes of fixing the redness.


Update index.markdown section "high fees will solve spam" misconception

I didn't even pay attention that this section was empty, thank you for completing it.


Minor copy edits

Apostrophe, indefinite article, and comma for clarity
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

Suggest reviewers if you know who should review the PR, using the GitHub Reviewers UI.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@rhires I made more changes - please review.


Create a simple custom desk structure in Sanity

Add the necessary stuff (plugin) to use a custom desk structure in Sanity

Note to self: Casing is important :sweat:


feat: rest server streaming support

TODO: add docs, look more at the headers retrieving code.

I don't think this will cope with characters that are split between byte arrays. I think we should create a StreamReader and read text from that instead.
Good point. Switched to using StreamReader.

I don't see how this handles } in string values
It tries to parse them and fails. Added comments to clarify.

We need to work out how to handle failure without just swallowing the exception. (I don't think that's the exception that will be thrown, either.)
This failure is checking for complete object in buffer. I've refactored to better explain. (This was the exception that was being thrown. I agree that a more obvious one is better. Switched.)

I've tested it with Firestore (which uses their server-streaming queries for a lot of things) and all tests pass, except for BIDI ones.
Those are not supposed to pass, but WILL require additional work (by their authors) since the NotImplemented error gets swallowed in an unobvious way.

Addressed the comments, please take another look.

Merging now, and then will investigate the TextReader change which has some test failures at the moment.


The system could not find the phone book entry for this connection.

When i run the Makeprofile script i get the following error.
Get-VpnConnection :  VPN connection ~VPNNAME~ was not found. : The system could not find the phone book entry for this connection.
At line:9 char:16

$Connection = Get-VpnConnection -Name $TemplateName

           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (~VPNNAME~:root/Microsoft/...S_VpnConnection) [Get-VpnConnection], CimException
FullyQualifiedErrorId : VPN 623,Get-VpnConnection

I looked everywhere on the internet to find a solution but i cant find it anywhere

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7453068-95eb-2a42-fd0b-553ae593adb0
Version Independent ID: b39b2cb7-25b1-2af3-4954-dbcc04c836e9
Content: Configure Windows 10 Client Always On VPN Connections
Content Source: WindowsServerDocs/remote/remote-access/vpn/always-on-vpn/deploy/vpn-deploy-client-vpn-connections.md
Product: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

I checked if there was a phonebook entry and there was one of my VPN

@FareeZz It seems like your issue is solved.  I will close now.  Please feel free to reopen if you still have a problem.

In my case I was really just misspelling the VPN connection name. I just enumerated the connections first with Get-VpnConnection in powershell to find the correct name.


[Text Analytics] Adding TEST_AUTH_MODE env var

Fixes #11043.
I am proposing something like this for other packages as well to parameterize the test suite over the method of authentication. What do you guys think?

@deyaaeldeen I added a utility function called matrix that I have used to unify AAD/API Key Form Recognizer training test suites. You can take a look at sdk/formrecognizer/ai-form-recognizer/test/utils/matrix.ts for the source and at sdk/formrecognizer/ai-form-recognizer/test/public/formtrainingclient.spec.ts for an example of how I use it. It doesn't support what you're talking about here with being able to opt out of one or the other, but it might be a good jumping-off point for getting this functionality working elegantly.

I'm a bit confused on why this is needed!
Generally, if there's an issue with the authentication methods, we should fix and write tests in Identity.
Is this because of a customer facing issue? Or is this because the identity tests are insufficient?

Generally, if there's an issue with the authentication methods, we should fix and write tests in Identity.

@sadasant This is not a bug in Identity. If there were an issue with the authorization flows, then we would fix that in identity and add tests there. This is a developer quality-of-life thing for us. Sometimes early service deployments (preview/ppe/canary, etc.) may have problems authenticating our tokens, so this is a convenience feature for us to be able to inhibit the AAD tests without having to go in and insert a lot of .only into our tests.

@deyaaeldeen if this is about testing a credential that only lives in the Text Analytics client, I believe we should test the credential as we're testing the other credentials in identity! If that makes sense.

I will get in contact with the Identity Crew about the idea of moving AzureKeyCredential to Identity, and I'll get in contact with Engineering about potentially running all client tests with all the available credentials.

Now that textanalytics has tests that only work with API Key, we need to rethink our approach to this. I will close it for now.


Update Contributing.md

I want to add how to contribute using GitHub Desktop in the contributing.md file ,which makes it easy for beginners to contribute effectively.

not required.


Fix README typo + tweaks.

s/interface-stream-muxer/interface-ipfs-core, and a couple of other small tweaks.

I'm liking the aggressive linking you're doing recently. +1.

@RichardLitt man, ever since I learned about markdown footnote links they've soo been my jam :heart:

I reverted the phrasing back to how it was before for promises, but linkified them.

thank you @noffle :)


Fix editurl in ui form generation

In PageAction.php, edit url should start with the module frontname instead of grid ID

Thanks for the bug report and potential fix @khaled-badenjki.

Also, writing some tests is often a great way to convey the above information, but we accept words around here as well :)

Thank you @astorm for the reply.
To recreate this issue, refer to my response
After we have created the table grid, let's add a new row (either through database or using Add New button if it's working properly)
In the grid, go ahead and click edit under the Action column. An error will be thrown and you will be redirected to the dashboard index page.
To resolve this issue manually, go to
Robusta\ProductBrand\Ui\Component\Listing\Column\Robustaproductbrandlisting\PageActions
and replace
robusta_product_brand_listing with
robusta_productbrand
under the item edit url.
If the layout is rendering properly, It would show you the edit form.
This potential fix simulates the manual edit i described above.
If I entered a bad input during generating the module or this is an intended behavior please let me know.


Specify local or remote Jupyter server for connections broken

Issue Type: Bug
Communicating the migration instructions after factoring out Jupyter extension from the Python extension has been ham-handed.
among others: https://github.com/microsoft/vscode-jupyter/issues/1057
It is not at all clear that to get to the pop-up selection menu to input a new server in the ctrl+shift+p menu, input Jupyter: Specify local or remote Jupyter server for connections.
If I select Jupyter: Specify local or remote Jupyter server for connections, even if its the same server it is already connected to, VS Code will force me to reload/restart VS Code.  If I don't restart and select Jupyter: Specify local or remote Jupyter server for connections again, I get a VS Code ERROR:

Command 'Jupyter: Specify local or remote Jupyter server for connections' resulted in an error (command 'jupyter.selectjupyteruri' not found)

Also, how can I delete urls from the list of recently used servers+tokens? It is keeping a list of all of the Jupyter servers that have long since been shut down.
Is it possible to specify the server in the .code-workspace settings like I used to before the Jupyter extension was factored out of the Python extension? It was much more convenient to simply specify "python.dataScience.jupyterServerURI": "http://<IP_ADDRESS>:8888/?token=*******************" in the settings.
Why was the python.dataScience.jupyterServerURI setting not ported over to the Jupyter extension as jupyter.jupyterServerURI along with most of the other python.dataScience settings?
Extension version: 2020.11.358541065
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (1.95GB free)

Process Argv
--crash-reporter-id f652528b-5678-4b12-9ca0-3de6b1e1135f

Screen Reader
no

VM
0%

why can't I simply specify something similar to the following in my .code-workspace file ?
"settings":  {
    "jupyter.jupyterServerType": "remote"
    "jupyter.jupyteruri": "http://<IP_ADDRESS>:8888/?token=*************************************"

Where does the Jupyter extension save the remote jupyter server URI?

now I am getting

Unable to open 'Interactive - #1': Cannot read property 'createKey' of undefined.

and

Unable to write into workspace settings. Please open the workspace settings to correct errors/warnings in the file and try again.

well ... here is one ....
https://github.com/microsoft/vscode-jupyter/blob/68bee5c0117a9c7b7fd6f27ebc492e072d15daa8/package.nls.json#L109

How can I set serverUriStorage.Uri directly?
https://github.com/microsoft/vscode-jupyter/blob/68bee5c0117a9c7b7fd6f27ebc492e072d15daa8/src/client/activation/migrateDataScienceSettingsService.ts#L56-L58

Sorry but setting the server URI directly is not supported. You have to use the command. It's stored in encrypted storage as this value may contain a token to a Jupyter server that you wouldn't want to expose on your file system.

python.dataScience.jupyterServerURI setting not ported over to the Jupyter extension as jupyter.jupyterServerURI

This should have happened automatically. It doesn't get ported to the same setting as it doesn't exist though. What should have happened is that it was encrypted and stored internally.

Communicating the migration instructions after factoring out Jupyter extension from the Python extension has been ham-handed.

Was there something else you're having trouble with besides your remote setting?

We're also planning on revamping the remote support. Something more akin to this is coming:
https://github.com/microsoft/vscode-jupyter/issues/1366

Agree that this is very confusing (change in behavior of python.dataScience.jupyterServerURI), I could not figure out why my environment suddenly changed. There is no explanation of changes due to migration (that I could find) in the docs. Also there is no explanation of what @rchiodo mentions above about the server URI being kept in encrypted storage. Is there any way to view this setting?

Is there any way to view this setting?

The only way to view the setting is to bring up the 'Specify local or remote Jupyter server for connections' picker. It will show the current value at the top:

We should probably have a 'what's changed' in the release notes that describes what's changed.
I can do a brief summary here:

All python.dataScience settings are now jupyter. settings except for one exception
python.dataScience.jupyterServerURI has been removed. You can no longer set this in your settings.json. It's encrypted now. You have to use the command above.
In the VS Code insiders version, we will default to using the new native notebook support. See
https://devblogs.microsoft.com/python/notebooks-are-getting-revamped/ and the blog post that came out with the new jupyter extension:
https://devblogs.microsoft.com/python/python-in-visual-studio-code-november-2020-release/

As far as I remember that should be the sum total of the differences. I'll add a bug to put this in our release notes (and or documentation)