top toolbar and bottom status bar both scroll along with roster

If you have enough contacts/instances in your roster, when you try to scroll the entire window moves, causing the uproxy-toolbar and the status bar to both move off the screen.  We should change this so that only the roster scrolls, but the uproxy-toolbar remains fixed at the top and the status remains fixed at the bottom.

@jpevarnek - any ideas here?

@dborkan I have a few (for some reason, I thought both of those scrolling was expected behaviour)


Frozen string literal regression

From the commits history I've seen there was some work done to make nokogiri compatible with --enable-frozen-string-literal.
However, this fails for me on ruby 2.3.3 on ubuntu xenial:
$ export RUBYOPT="--enable-frozen-string-literal --debug=frozen-string-literal"
$ gem install nokogiri -v '1.7.1'
Building native extensions.  This could take a while...
ERROR:  Error installing nokogiri:
	ERROR: Failed to build gem native extension.

    current directory: /home/mnovichkin/.rvm/gems/ruby-2.3.3/gems/nokogiri-1.7.1/ext/nokogiri
/home/mnovichkin/.rvm/rubies/ruby-2.3.3/bin/ruby -r ./siteconf20170323-28235-1jnrn5d.rb extconf.rb
checking if the C compiler accepts ... *** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/home/mnovichkin/.rvm/rubies/ruby-2.3.3/bin/$(RUBY_BASE_NAME)
	--help
	--clean
extconf.rb:422:in `<main>': can't modify frozen String, created at extconf.rb:161 (RuntimeError)
yes

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /home/mnovichkin/.rvm/gems/ruby-2.3.3/extensions/x86_64-linux/2.3.0/nokogiri-1.7.1/mkmf.log

extconf failed, exit code 1

Gem files will remain installed in /home/mnovichkin/.rvm/gems/ruby-2.3.3/gems/nokogiri-1.7.1 for inspection.
Results logged to /home/mnovichkin/.rvm/gems/ruby-2.3.3/extensions/x86_64-linux/2.3.0/nokogiri-1.7.1/gem_make.out

As you can see: extconf.rb:422:in ': can't modify frozen String, created at extconf.rb:161 (RuntimeError)`.
Seems extconf.rb used to be  --enable-frozen-string-literal compatible (hence https://github.com/sparklemotion/nokogiri/commit/53f9b66ee60342a639ff1c1e60b75558ea3be4ac). But now it isn't, so I deduce it's a regression.
I propose adding frozen string literal comment to every existing file in the project, and settling up the rule to have one in each new ruby file.
So, I've made a PR #1622. It's just all the comments added, but nothing else changed. Seems like it would break stuff. I won't be doing anything more in there, so it's more like a starting point to start with.
I guess only core nokogiri maintainers can solve this regression once and for all. Please, do something.

This is a bug in ruby-2.3. Several libraries delivered with ruby-2.3.x are broken in regards to frozen string literals. You must upgrade to ruby-2.4 in order to use this feature.
Nokogiri is already fully compatible to frozen string literals and we're running all tests on ruby-2.4 with frozen string literals enabled. There is no need to add comment lines to each and every file.


key "is_general" not present

{"type":"channel_created","channel":{"id":"<elided>","is_channel":true,"name":"parents","created":1439250835,"creator":"<elided>"},"event_ts":"1439250835.968977"}
key "is_general" not present
Please report this failure to the github issue tracker

@mpickering, if it's alright with you, I'm going to keep opening issues for these even when the fix is straightforward, just to keep track of all these API mysteries explicitly.

The same thing happens with the is_member key.

SGTM - maybe the is_general key got deprecated? IIRC there used to be a privileged room called #general which everyone joined by default - is that still the case. If it's unclear then best to keep it as a Bool and default it to False I think?

The #general room still exists and is mandatory.  I haven't seen any errors parsing Channel objects during normal operation -- they seem to only happen when a channel is created.
I'm happy to default to False if you like.

This was closed with #29.


Unable to Access Kafka Using Public IP of Laptop

Encountering an error where the Kafka consumer is unable to connect using the public IP of the laptop.

Solution: use the local IP address (e.g., 192.168.x.x) instead of the public IP.


Update gke driver

This change updates the example driver to match the latest version of the
existing GKE driver.  This is to support testing of the kontainer driver
import system in the rancher validation tests.
Issue:
rancher/rancher#12698

LGTM


BMC Logo

BMC has provided legal approval for the logo to be used on the INI Site

Thanks for adding. Can you commit this to the logos folder https://github.com/inclusivenaming/website/tree/main/static/img/logos
Also can you put down an email contact so we know who to reach once the legal part is sorted out?

you actually added the image in the main directory rather than the logo folder. If you open up the folder, you can open the PR against that folder

@shahed-al can you close this since we already have #57 ?


[Feature]: Generics for Combobox

Describe the feature
I'm not entirely sure how we would implement them, but I notice the DX of the combobox is not amazing regarding the filter function and the emits for model-value, because it's not fully type save. I feel that it would be rather complex to implement this nicely because of the composable nature of radix. I might have a go sometime to experiment with solutions, but I'm also interested to hear ideas of the community/creators about this and if this is actually something we should want to persue.
Additional information

[x] I intend to submit a PR for this feature.
[ ] I have already implemented and/or tested this feature.

Thanks for bringing this up @pietdevries94 .
Actually the use of filter-function is an alternative way. You can also render the list as such.  (Will add more examples in docs soon)
As for the modelValue, you are right that due to the composable nature of Radix, we cant technically inferred the modelValue properly without adding more props, even with Vue3.3 generic component.  However you are welcome to experiement!!!


GRPC Integration Tests - Any equivalent WebApplicationFactory?

ASP.Net Core WebApi uses WebApplicationFactory for integration tests. Is there any equivalent factory for Grpc integration tests?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d298a6c-8ddc-dbc8-d219-0fa7138442c2
Version Independent ID: b96be346-958a-cfcd-d80a-c352d64223e8
Content: Create a .NET Core gRPC client and server in ASP.NET Core
Content Source: aspnetcore/tutorials/grpc/grpc-start.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @JunTaoLuo
Microsoft Alias: johluo

I still use WebApplicationFactory but https://docs.microsoft.com/en-us/aspnet/core/grpc/clientfactory?view=aspnetcore-3.0 helps.


Changed accessibility of properties to protected

It's very helpful, when properties like response and request are accessible in the custom feature context class, if you want to add some extra functionality that's currently not supported.

This would mean we would have to maintain BC on all these properties, which is bad for maintenance (it would make it impossible to merge #35 for instance)

It's hard to imagine that properties like $this->request or $this->response would change their name or go away in any foreseeable future

+1 for exposing the request and response. It makes it far easier to extend the context. For example, when making a POST request I want to examine the headers. Can't do it because I don't have access to $this->response.  Maybe even better would be to expose $this->client. It has a well defined interface.

@valthebald they will change their type in the near future, because of #35, meaning it would be a BC break if it is exposed

Maybe could you provide some concrete use cases for that?
It's maybe possible to find another way.
@stof Is this is going to be merged, #35 should be indeed be merged first.

Specific use case is like others mention - extending the base context class.
+1 for #35 to be merged first, and in that case, child classes won't need $this->request, only $this->response and/or $this->client

This is a needed feature, testing requires flexible extensions and accesible data.

@Gerschtli Can you please rebase your PR since #35 is merged?

Closed, see #69


Since the last update...

Sometimes, the game stops, i can access the menu, but , for example, a minotaur starts a charge in the original campaing, and in the middle of the charge it stops, never ending the move. The animation still running.
And another issue since the last patch is that I have a druid with a Bear as ally and the menus of the bear are not shown. You can move the bear, but cannot access the buttons. Is like the GUI is outside the screen. But only with the bear.
Thank you!

Fixed on DEV. Will have a new fox release today.

great! thank you!


Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[*] Android
[ ] UWP
[ ] .NET Standard

Version of Library
6.2.6
Version of OS(s) listed above with issue
Android 7.0 and above
Steps to Reproduce

Do not implement Pair to Device method
Try to connect to BLE Gatt server without pairing.
It doesn't get connected.
Move to Device settings and pair server device
Come back to the application and connect, it gets connected.
It works fine on IOS.
Can you please let me know is there any configuration parameter needs to sett to make this work on Android as well, as my BLE server doesn't have pairing capabilities, my requirement is to connect without pair.

Expected Behavior

Connect Device without pairing, it should get connected

Actual Behavior
Connecting device, without pairing, it is not getting connected on Android

This isn't anything the library is causing or can change for you.  iOS usually is the one that calls for pairing when you try to work with secure characteristics.

Thanks for your response.
But the same piece of code works differently on Android and IOS, and on android, it doesn't get connected until we pair it. Can you please help and provide some insight into it, that what could be the cause for such behavior.
To connect , we are using   ->   selectedDevice.Device.Connect();

I don't have any insight to offer.  It has nothing to do with the code in the library.  I use the API of the OS under the hood.  It is how the OS is handling it for whatever reason.


Make Frontend IO Component System-Agnostic

This PR:

Removes some hardcoded paths added as constants that are used nowhere (f27c7a240527230bca37d1bde8bf601a6f6856b7, a5ec46ea479a1ea9a7bc528716b20bcbd168f1c6)
Adds in OS check logic to make file prompt to open at the root directory (b1653cdd93eb8b0d51e26a2c846ca88e297314f1)

First two changes are fine, those were all left-overs of projects I'd been working on and re-making the UMLs for constantly and the OS agnosticism is definitely preferable; that whole Main class is basically where you decide if you're gonna use a UI or 'run headless', so to speak, via the runLoose() function. Removing it isn't a biggy but I pretty much always keep either runReal() or runLoose() uncommented for personal usage; I'll make a public Main version and .gitignore my personal environment for running things.
I'll merge that after pushing the changes to the issues you were having.


deployment-stack failed to create

Error shown during the deployment-stack creation in cloudformation:

The following resource(s) failed to create: [LiveEventsKmsKey, HandRaiseSendMessagePermission, MessagingSendMessagePermission, HandRaiseAuthorizePermission, HandRaiseOnDisconnectPermission, LiveEventCloudFrontDistribution, HandRaiseConnectRoute, HandRaiseOnConnectPermission, ChimeMeetingsAccessPolicy]. . Rollback requested by user.

The SAM has AdministratorAccess policy. Not sure why this is happened.
Thanks

Can you post a screenshot of the first error that happened during creation? That is usually the cause of the rollback and would better help us understand what is going wrong. Thanks.

Hi,
It start fail on SiteDeploymentLayer

In Terminal, it stopped on this step:

Thanks

SOLVED
I learn that we need a unique deployment stack name, I'm using similar deployment stack name in the tutorial :
-s live-event-deployment-stack
it will try to create an exist S3 bucket name.

Another things is the region, (currently) must be in the us-east-1, I'm trying to deploy in ap-southeast-1 and it fail.


Regression in 5.2.1 while using InjectionFactory

this worked fine in 5.2.0 (as well as previous versions) and not anymore in 5.2.1.
 class Program
    {
        static void Main(string[] args)
        {
            WorksOnUnityContainer520(new UnityContainer());

            Console.ReadLine();
        }

        static void WorksOnUnityContainer520(IUnityContainer container)
        {
            container.RegisterType<ITestService, TestService>(new InjectionFactory(c => new TestService(new ModelA())));

            var testService = container.Resolve<ITestService>();

        }

        #region Model

        public interface ITestService
        {

        }

        public interface IModelA
        {

        }

        internal sealed class TestService : ITestService
        {
            private readonly IModelA _a;

            public TestService(IModelA a)
            {
                _a = a;
            }
        }

        internal sealed class ModelA : IModelA
        {

        }

        #endregion
    }

I switched to using InjectionConstructor which still works as expected.

Think about this line of code:
RegisterType<ITestService, TestService>(new InjectionFactory(c => new Tes...));

Are you registering a map between ITestService and TestService?
Or perhaps you are registering map between ''ITestService'' and InjectionFactory(c => new TestService(new ModelA())?
If you think about these two, they are mutually exclusive.

Viewed that way you are absolutely right. Still, this did work in older versions, but I guess it can be viewed as a bugfix then. I switched all my cases to InjectionConstructor, which is the correct (and shorter/better) solution anyway. Thanks for the clarification.

I've added note to Release with explanation


Spike: in private kernel, do we need to enforce that non-transient reads are for the current contract address?

Once https://github.com/AztecProtocol/aztec-packages/pull/1331 is merged, the private kernel will accept unique_siloed_note_hashes as input for non-transient reads. It therefore no longer silos read_requests by contract address.
Should the private kernel be enforcing that non-transient reads correspond to the proper contract address?

tagging @iAmMichaelConnor as he was the one that proposed the question

I'll try and reword the question for my own brain:
There are cases where a contract will want to read some persistent note from the notes tree (aka private data tree). Should we allow Contract A to read a note which 'belongs' to Contract B? If we don't want to allow that (and instead only allow a contract to read its 'own' notes), the kernel circuit should check that the contract address inside the siloed_note_hash matches contract of the function currently being processed.
I think it would be complicated to allow a contract to read another contract's notes. On most occasions, a note will not be constant, and so a contract would need to be sure that the note it is reading is a 'current' (not-yet-nullified) note. To be sure of this, the contract would need to produce a nullifier for that note. But nullifiers get siloed by the kernel circuit. So Contract A could never produce the nullifier for Contract B's notes. (This is by design: it would be bad if a contract could nullify another contract's notes). So Contract A can never be convinced of the 'current-ness' of a note of another contract, if it were to read it itself.
Now, I suppose Contract A could read notes from Contract B if those notes are known to be constant. But that feels quite niche, and feels like a potential footgun for developers. The protocol doesn't know what a 'constant' note is: it's up to the developer designing Contract B to implement 'constantness' if they want it. And then it would be up to the developer of Contract A to be aware of that constantness to then have the confidence to read Contract B's note.
Also, we've designed the oracle and DB to accept queries of the form "give me the notes for this storage slot of this contract address". It would be dangerous to allow Contract A to make requests to the DB for any other contract's notes. It would leak secrets and those secrets could be maliciously emitted as events by Contract A. Because of this danger, I don't think the oracle should ever make exceptions, and should only ever provide notes to the 'owning' contract.
A simple alternative is to have Contract A make a call to Contract B, then Contract B reads the note (emitting a nullifier, if required), and returns the note's contents back to Contract A.
Ok, so should the protocol (kernel circuit) enforce that Contract A cannot read Contract B's notes? Or can we rely on it being impractical and ill-advised to do so, because the rpc server would need to be modified, and contract developers shouldn't develop contracts which require an insecure and 'hacked' rpc server to perform reads across contracts?
I would lean towards enforcing the check. This will make it simpler for us to analyse the security of the protocol. It's far better to implement constraints which match our expectations, rather than underconstrain and see unexpected behaviour in future. Calling contract B to make a read will cost an extra round of kernel recursion, but that feels acceptable to me.

As one of the authors of an EIP to allow Ethereum contracts to directly read state from other contracts, I fully agree with your conclusion of not allowing this in Aztec. I think the security implications of a contract leaking secret notes from another are enough to forbid it.

Answer is yes we should enforce this. Created ticket here https://github.com/AztecProtocol/aztec-packages/issues/2847


ARROW-3761: [R] Bindings for CompressedInputStream, CompressedOutputStream

Need to look how test this.

Codecov Report

Merging #2962 into master will increase coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
+ Coverage   86.44%   87.38%   +0.94%
==========================================
  Files         490      422      -68
  Lines       68852    63679    -5173
==========================================
- Hits        59519    55648    -3871
+ Misses       9247     8031    -1216
+ Partials       86        0      -86

Impacted Files
Coverage Δ

rust/src/record_batch.rs

go/arrow/array/table.go

rust/src/array.rs

go/arrow/math/uint64_amd64.go

go/arrow/internal/testing/tools/bool.go

go/arrow/array/bufferbuilder.go

go/arrow/internal/bitutil/bitutil.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/array/null.go

go/arrow/datatype_nested.go

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9769644...1737158. Read the comment docs.

Are you working on this somewhere else?

I'm not.

Looks like you may need to git reset --hard to https://github.com/apache/arrow/commit/8ccc977a9b861dcaeeea56543477eefdc3d96b37 and then rebase. It should be in your reflog

There are no tests here. What would you like to do?

I’m still unsure how to test this. I’ll look around in pyarrow next time i look at this branch

Got it. I think we just generate random bytes and write them to a compressed file, then read them back in and compare

Makes sense. IIRC I tried to serialize a record batch but that did not work out well.

Thanks. I’ll use that in testing.

This will likely need to be rebased once #3043 is merged


Is there "getting started" documentation?  Or documentation for clients?

I found #15, but what seems to be there is comprehensive documentation of every function, including internals that I might wish not to know about.    Also, just the basic model---this library looks more stateful than the Haskell or other QuickCheck things I am used to.
What would you recommend to identify the key API points a new user would need in order to get started?  What would I actually put in a file passed to lqc on the command line?

Right, this is a good point. Maybe it is a good idea to add an introduction markdown file (or another section to the README) describing the basic stuff.
The examples in https://github.com/luc-tielen/lua-quickcheck/tree/master/spec/fixtures/examples showcase the basic API for non-stateful properties but for FSMs right now you need to look at the specs..
Regarding statefulness, what do you mean by this? The generators themselves?

The command you put into #19 was a good start---I have a somewhat clearer idea what is going on.  That and a quick guide to specifying generators would be a good jumping-off point.
Regarding statefulness, the property function seems to have a side effect on global state, rather than passing a property to a quickcheck function.  I think I was looking for an API more like Haskell.  Now, having studied the example, I see that the imperative code in the examples showcase is meant to look declarative.
Incidentally, an additional part of the documentation would be to point to the set of names that are bound into the global environment in a spec file.  I would have expected to have to require the lqc API, but it looks as if such functions as property and int are just sitting there waiting to be called.

I had some time to write out some extra docs today (see #21).
You are completely right about statefulness, property and fsm register themselves to a global array of properties before the runner starts checking them all. I mainly tried to be declarative in the look and feel when using the library (and this is now mentioned in the README).
Thanks for pointing out some stuff that wasn't immediately obvious to me after implementing it fully 😄.
If you still feel stuff is missing or needs to be more clarified, feel free to open a issue/PR and add the missing pieces 😉.


How to make it works with Laravel Passport?

Currently, when I login via laravel passport (Password Grant Tokens), it doesn't record this login information in authentication_log table.

For ref. look into the src/Listeners/ folder. This package listens for the Auth Events (Login/Logout). So if you want this package to update the data when using passport, be sure to call the laravel's login event

Thanks @TechTailor,
As checked, can i use these two events for login and logout?
1.Login event
event(new \Illuminate\Auth\Events\Login(
            $this->guard(),
            $user,
            false
        ));

2. Logout event
event(new \Illuminate\Auth\Events\Logout(
            $this->guard(),
            $user
        ));

This worked for me (Passport):
        $user = $request->user();
        event(new \Illuminate\Auth\Events\Logout(
            auth()->guard(),
            $user
        )); // to trigger logout event

        $request->user()->token()->revoke();

Thanks @TechTailor,
As checked, can i use these two events for login and logout?
1.Login event
event(new \Illuminate\Auth\Events\Login(
            $this->guard(),
            $user,
            false
        ));

2. Logout event
event(new \Illuminate\Auth\Events\Logout(
            $this->guard(),
            $user
        ));


[0.2] Don't require backbones for every Node opacity not in a Canvas cache

Right now, if a Node has non-full opacity it will typically trigger the creation of a Backbone (i.e. like a layer split) for that Node, due to the more complicated logic needed for switching between cases.
We'll want to support SVG group opacity as long as everything underneath can be SVG, and we'll need to implement the equivalent "everything underneath must be rendered in a single SVG block". This will need to handle (transparently) the case where a Canvas-only node is added, changing the subtree's renderer bitmask (we'll need to create a Backbone in that case to apply the proper opacity effect), or switching the other way.
This is most likely necessary due to the amount of Node opacity being used, and will have a memory advantage due to creating many fewer layers (especially now that we are using SVG as the default). Unsure about the expected level of overhead necessary.

Brain dump for https://github.com/phetsims/scenery/issues/293, which also includes notes relevant to https://github.com/phetsims/scenery/issues/158, and https://github.com/phetsims/scenery/issues/396.
Opacity: CSS opacity available on all platforms, so we can fall back to applying it on backbones. This is necessary for any two or more blocks that contain instances under the same opacity unless they overlap (see opacity test cases).
Clipping: Non-rectangular clipping not available on IE10,IE11, so we can't always fall back to a backbone. Luckily we don't have the same opacity issue, and can apply clipping independently to two blocks whose instances are under the same clip region (there might be minor anti-aliasing differences on edges, but should be suitable for our needs).
Thus if we have the structure:
A (clip)
  B (opacity)
    C (canvas only)
    D (svg only)
  ...

Non-IE browsers can handle it with:
Backbone with clip
  Backbone with opacity
    Canvas block
    SVG block
  …

However IE will require rearranging the order the filters are applied (which is OK with opacity/clip) since we can't apply clip always to backbones:
Backbone with opacity
  Canvas block (with clip from A)
  SVG block (with clip from A)
…

For the long term, this suggests that rendering state records filter-instance pairs that need to be applied (instance info so we can apply the correct transforms, where above A's clip will be applied to D's SVG tree). This will support checks for reordering and that general process.
Another tricky bit is ensuring we don't always create backbones for opacity (the root of this GitHub issue). So given:
E (svg only)
  F (svg only, opacity)
    G (svg only)

We don't want to turn it into:
SVG block for E
Backbone (opacity)
  SVG block for F,G

But instead:
SVG block (includes opacity applied to the SVG group)

The trick is that currently the decision about whether to construct a backbone is done in the render state update. At this point, we don't have a list of drawables from children yet, but we have things like compatible renderer information, etc. Notably, "will renderer X be able to display the entire subtree". If we greedily commit to the SVG group opacity if everything can be rendered as SVG, it means everything below needs to be in 1 single block and all be rendered as SVG. This would mean ignoring layerSplit hints, renderer hints, or any and all preferences specified. That's less than ideal.
We'd need to add information to the RendererSummary about whether there is any information at all (renderer flags, layerSplit flags, other hints) that would potentially cause any sort of split. This would cause additional general overhead, but then we'd be able to commit to either a backbone or group opacity.
The potentially preferred option would be to delay the decision of whether we choose a backbone or group opacity until AFTER we get back all of our drawables. This would respect all hints below, and then use group opacity (or a Canvas cache) if available. This might require moderate changes, but be more flexible and stable in the long-term. This may require splitting the updateRenderState() into "affects cascading information" and "doesn't affect cascading information". Notably, we'd need to figure out tricky bits if there are canvas cache flags where normally we would choose between that and a backbone.
We're also avoiding any drawable-list rewriting of descendant's orders. For instance, if a child has drawables "svg, canvas, canvas, svg", we don't want to replace "canvas, canvas" with "" between the two "svg" drawables, since this messes with the child's drawable list and could cause errors.
Notes on filters (different places and ways of applying them)
Backbone: CSS opacity, CSS clip rect() for all browsers, CSS clip-path (no IE), CSS mask (no IE)
Applied directly to SVG element: SVG opacity, SVG clip-path, SVG masking
Canvas/WebGL cache/framebuffer: opacity, WebGL clipping, masking
Stacked and applied on block OR Canvas cache: Canvas clipping (as 0.1 handled clipping)
Side-lining to work more on WebGL base implementation.

We won't override how the renderer selection system works at all, but will instead detect if everything WILL render in SVG/Canvas (by switching the renderer summary to note things both for "can EVERYTHING be rendered with SVG" and "can SOMETHING be rendered with SVG".
This is necessary, since if Canvas is preferred to SVG (in the preferred renderers), we will only render everything as SVG if there is NO node that can be rendered with Canvas.

Completed.

Can you comment briefly on how this relates to scenery webgl development?

The underlying work will also makes it possible to recognize when everything under a certain instance will be displayed with Canvas, so that we could render that into a texture and display it as WebGL (think paths/text).

Sounds great, thanks.


Change visibility of Store from 'open' to 'public final'?

I was wondering what people override the default Store for.
Could we 'close' it make it a public final class Store<State>?
The ReSwift library itself compiles just fine with public final; the tests override subscription methods, so they require just public.
It might have consequences for 3rd parties, but I wouldn't know which kind.
What are all your thoughts on this?

The store is commonly overridden to provide reactive bindings, or to provide a thread-safe store. I would not recommend closing its access.

Makes sense.


Fix an issue that Dragging the iOS text selection handles is jumpy and iOS text selection update incorrectly.

I noticed that iOS Cupertino Style Text Selection Handle dragging is not smooth，selection always update to previous text line.
After read source code，I found that different style text selection handle has different relative position to text line.
To Material text selection, handle is below the text line.
To Cupertino text selection, handle overlaps the text line.
But when dragging handle and update selection, before this PR，Material Handle and Cupertino Handle use same offset to shift drag point to actual text position when user drag the handle, the offset is Offset(0.0, -handleSize.height).
Actual text position is the point RenderEditable use to get TextPosition and update selection.
Because Material Style Handle is  below the text line,this offset is useful to RenderEditable update right selection.
But Cupertino Style Handle is overlaps the text line,so it cause selection update wrongly, selection always update to previous text line.
And EditableText don't allow baseOffset greater than extendOffset,it cuase endHandle drag not smooth.
Before this PR,the source code is as follows：
  void _handleSelectionEndHandleDragStart(DragStartDetails details) {
    ...
    final Size handleSize = selectionControls!.getHandleSize(
      renderObject.preferredLineHeight,
    );

    _dragEndPosition = details.globalPosition + Offset(0.0, -handleSize.height);
    final TextPosition position = renderObject.getPositionForPoint(_dragEndPosition);
    ...
  }

The logic is as follows：

But I think for different style handle, should return different Offset getOffsetFromHandleToTextPositionto help RenderEditable update selection rightly.
getOffsetFromHandleToTextPosition is Offset use to shift drag point in handle to actual text position when user drag the start handle or end handle. Actual text position is the point RenderEditable use to get TextPosition and update selection.
For Material Style Handle, getOffsetFromHandleToTextPosition return Offset(0.0,-handleSize.height).
For Cupertino Style Handle, getOffsetFromHandleToTextPosition return Offset(0.0,0.0).
I think the right logic is as follows：
  void _handleSelectionEndHandleDragStart(DragStartDetails details) {
    ...
    final Size handleSize = selectionControls!.getHandleSize(
      renderObject.preferredLineHeight,
    );

    final Offset offsetFromHandleToTextPosition = selectionControls!
        .getOffsetFromHandleToTextPosition(handleSize);

    _dragEndPosition = details.globalPosition + offsetFromHandleToTextPosition;
    final TextPosition position = renderObject.getPositionForPoint(_dragEndPosition);
    ...
  }

you can reproduce this bug in any CupertinoTextField with multiline.
this is reproduce video:
use same offset Offset(0.0,-handleSize.height)  to update selection:
https://user-images.githubusercontent.com/30322203/183806830-e84c959a-07d0-450f-aa5e-294917bf8b6a.mp4
After use different getOffsetFromHandleToTextPosition  to update selection:
https://user-images.githubusercontent.com/30322203/183832611-b7d20360-6712-4da9-b86e-2cf29c807059.mp4
List which issues are fixed by this PR. You must list at least one issue.
https://github.com/flutter/flutter/issues/106703
If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

cc @chunhtai

Any Updates? @chunhtai @LongCatIsLooong

I think you are right, we should try to avoid use more and more tricky value.Because getHandleAnchor used to locate different style handle from same point, I believe there is some way that can shift handle touch point to actual text position.
I will try.

You are dead right that the current code, which hardcodes the drag offset to Offset(0.0, -handleSize.height), is incorrect. I tried out your PR on my machine and it works beautifully.
However, all of these offsets are very tricky, and I think @chunhtai is right that there might be some overlap with getHandleAnchor and your getOffsetFromHandleToTextPosition.
Would it be possible to come up with some Offset to add to _dragEndPosition using the handle height and getHandleAnchor that doesn't require saving a separate value but that works just as well?
Playing around on native Android, to me it seems like the handle jumps to the next line at the point where my finger is at the same position on the new line as when the drag began on the original line. Maybe I'm wrong and it's just using some constant offset like this though. I'm not sure if it would be doable to make something like that work here for us.
Overall though, I think this is a great improvement and it feels so much better when I try this out. If none of my ideas above work, I'm probably ok with the getOffsetFromHandleToTextPosition solution too.
Oh and also, I think you should add a new test for this if you can. Would it be possible to reproduce the bug shown in your video in a test by dragging a handle horizontally and expecting that the selection hasn't jumped to a different line?

I commit new changes use getHandleAnchor to compute correct offset Instead of tricky offset getOffsetFromHandleToTextPosition.Please review this new changes.
@justinmc @chunhtai
And I think add a new test is necessary，I would try commit the test code later，you can review the logic code first.

I add a test case in cupertion/text_field_test,that reproduce the bug shown in my video in a test by dragging a handle horizontally and expecting that the selection hasn't jumped to a different line.
@justinmc @chunhtai

Thanks for following up. I think the test looks great. Most of my comments are nits.
Could you look at this issue with the touch point between lines though? I noticed that the point at which my mouse contacts the handle changes when the handle moves between lines. In the gif below, the gesture starts pointing at the blue circle, but after moving down one line, the cursor is pointing higher up, at the middle of the blue line.
Do you think that's possible and worth it to fix? As it is, this PR is a huge improvement, so if it's not practical to get that right I can open a separate issue for it.

emm... I think the issue shown in the video is a new problem.I notice native iOS has some nice behavior that Flutter don't match.For example, drag handle move between lines,allow baseOffset and extentOffset order swapping,long press would show the floating cursor and magnifier,etc. I think should open new issue for it. And I will open some new issue for textfield to describe the problem I found and open some PR to fix it later.

Is there anything else I need to change？
@justinmc

Alright I'm ok with that. Can you open an issue and include my gif above and tag me? The other two issues you mentioned should be fixed on master: the magnifying glass and the handle order swapping, but let me know if they're not.
I think the logic in the PR is pretty much fine and it seems to work well, but now I just want to make sure the comments and naming are all easy to follow. I've left some comments below.

ok, I make some change in comments and naming, try to make it easy to understand and follow. Please review again.
@justinmc
About issues, I notice magnifier show up on drag handle, but on native iOS,long press could change the caret with floating cursor and magnifier.
And problem shown on your gif that behavior when drag and move handle between different lines.
And I found I can't swap handle order on master branch like the follow video.
https://user-images.githubusercontent.com/30322203/185344552-0239b156-ecd3-437c-93db-000df1d2cc60.mov
Because my work in company this year is optimize the text input experience in flutter.
I will open some issues about different behavior with native textfield later. I need to record the comparisons videos.
And I will open PR with my solution try to optimize the text input experience later.

Any updates？ @justinmc

Is there anything else I need to change？
And I don’t know why ci task failed.

I open two issue and mention you @justinmc
https://github.com/flutter/flutter/issues/110305
https://github.com/flutter/flutter/issues/110306
about handle order swapping and different behavior when move between different lines.

Any updates about this PR? @justinmc
please review my latest comments and naming.

@ksballetba To fix the CI failure, try to rebase your branch against master and then use force push.

@ksballetba To fix the CI failure, try to rebase your branch against master and then use force push.

Thanks, I will try.

Any updates about this PR? There's been no updates for 12 days.😑
@justinmc @chunhtai

Any updates for this PR in this week？👨🏻💻
@justinmc

Sorry for the delay here, I'm just getting back from Flutter Vikings.
Thanks for adding all of the comments, but I still don't think the calculation in _getOffsetToTextPositionPoint is quite right. On iOS, dragging near the top or bottom of either handle seems to still jump to the next line. I don't fully understand what _getOffsetToTextPositionPoint is calculating and why that should be the correct adjustment.
What if we did a mapping from the height of the handle to the height of the line? So from the red height to the green height in this picture:

So an offset at the left purple dot would be mapped to something like the right purple dot:

I feel like that would work on Android too... What do you think? Or if not, can you explain a bit what _getOffsetToTextPositionPoint is calculating and why that's what we need?

First，we need know what getHandleAnchor do.
getHandleAnchor use to locate different style handle from same handleLayerLink.
Material Style Handle show locate below the textline，Cupertino Style Handle show overlaps the textline.
The anchor point is the point that is aligned with a specific point in the text. A handle
often visually "points to" that location.
For Material Style Handle：

For Cupertino Style Hanlde：

In the previous conversations,we both think should avoid  tricky value.So I try to compute _getOffsetToTextPositionPoint  by getHandleAnchor.
I will explain how to compute this value by Image
When drag evet happen on center of handle:
For Cupertino Style Hanlde：

For Material Style Hanlde：

Try to shift center of handle to top by half of handle height.
Try to shift handle top to selection end point by dy of handle anchor.
Try to shift selection end point to center of correct text line by half preferred line height.

When drag evet happen on bottom or top of handle:
For Cupertino Style Hanlde：

For Material Style Hanlde：

I think the center of handle is where easiest to drag like other dragable widgets.  So I suppose center of handle as start point,the center of correct line as target point to compute _getOffsetToTextPositionPoint. When drag evet happen on bottom or top of handle, the target point will locate below or above the center of corrcet line. But still in the correct line,
so RenderEditable could update selection correctly.

Sorry for the delay here, I'm just getting back from Flutter Vikings.
Thanks for adding all of the comments, but I still don't think the calculation in _getOffsetToTextPositionPoint is quite right. On iOS, dragging near the top or bottom of either handle seems to still jump to the next line. I don't fully understand what _getOffsetToTextPositionPoint is calculating and why that should be the correct adjustment.
What if we did a mapping from the height of the handle to the height of the line? So from the red height to the green height in this picture:

So an offset at the left purple dot would be mapped to something like the right purple dot:

I feel like that would work on Android too... What do you think? Or if not, can you explain a bit what _getOffsetToTextPositionPoint is calculating and why that's what we need?

If we did a mapping from the height of the handle to the height of the line, we need know relative position from drag event and handle. if drag event happen on top of startHandle, the mapping result will be a smaller value. if drag event happen on bottom of startHandle, the mapping result will be equal with drag event.
And EndHandle and Android Handle has different mapping rule. It seems a little complex.

Any updates？ @justinmc

Any updates？ @justinmc

Will follow up on this tomorrow, sorry for the delay.

Sorry for the delay here. I checked out your branch, and if I drag directly horizontally, then it will jump to the next line:
Screen.Recording.2022-10-07.at.3.19.34.PM.mov
Is that something you could fix?
I'm also still fixated by the fact that this isn't how it works natively. Natively, the jump between lines happens such that the point that I contacted the handle stays the same. Maybe we could achieve this by using getLocalRectForCaret?
If not, that's probably ok for now since this is such a big improvement over the current behavior. It would be great if you could fix the problem in the video, though.

I have no idea about this problem temporarily, but I think maybe should make some verification to make sure drag directly horizontally will not jump to the next line.
This PR provide a same shift method for different platforms to make update selection correctly as far as possible, and could merge first.
I think the problem in the video could be tracked in issue and fixed by new PR.

@justinmc Hi,The conversation has been going on for two months👀 , I hope we could communicate more frequently, and could merge this improvement.
The problem you mentioned could be tracked in issue and fixed by new PR.


Maintainer wanted

Hi folks; unfortunately, I just don't have the time or inclination to maintain this any more. I've kept telling myself I'll get around to modernising this, but as I'm no longer using this on any projects, it's unlikely I'll ever get around to it.
I'm happy for someone to fork this, take it over etc., but I won't be maintaining it any more (not that I was doing much with it anyway...
Opinions/thoughts/suggestions welcome. Previous contributors would be favoured.
I will mark this repo as archived in ~2 weeks.

:(
Em ter., 25 de ago. de 2020 às 10:05, James Titcumb <
<EMAIL_ADDRESS>escreveu:

Hi folks; unfortunately, I just don't have the time or inclination to
maintain this any more. I've kept telling myself I'll get around to
modernising this, but as I'm no longer using this on any projects, it's
unlikely I'll ever get around to it.
I'm happy for someone to fork this, take it over etc., but I won't be
maintaining it any more (not that I was doing much with it anyway...
Opinions/thoughts/suggestions welcome. Previous contributors would be
favoured.
I will mark this repo as archived in ~2 weeks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/asgrim/ofxparser/issues/62, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIRTRJ7X7PBMZ627XGWUNTSCOZK7ANCNFSM4QKUCCBA
.

Since there has been no take-up, I am abandoning this project on Packagist and archiving it on GitHub. If someone else forks and regularly maintains, I'm happy to provide a replacement package marker on Packagist. Thanks folks!


proposal: affected/package: slices

HI! In order to improve development efficiency, I believe it is necessary to provide more popular array slices functions, including but not limited to the following item:

Filter: returns the elements matched, it may be like this:

func Filter[S ~[]T, T any](s S, f func(T) bool) (r S) {
	for i := range s {
		if f(s[i]) {
			r = append(r, s[i])
		}
	}
	return r
}

Map: returns the new elements converted, it may be like this:

func Map[S ~[]T, M []N, T, N any](s S, f func(T) N) (m M) {
	m = make(M, len(s))
	for i := range s {
		m[i] = f(s[i])
	}
	return m
}

Delete: remove the indexed element, it may be like this:

Attention! what the Delete function is in go now has a bug!! like this:

s := []int{0, 1, 2}
fmt.Println(slices.Delete(s, 1, 2)) // [0,2]
fmt.Println(s) // [0,2,2] Terrifying! I don't think that `s` become [0,2,2] is your want!!!

// BTW! If you do not accept the proposal, please also modify the Delete function. maybe like this:
r = make(S, len(s)-1)
copy(r, s[:i])
copy(r[i:], s[i+1:])

// here is a fixed version, it can be use like slices.Delete(s, len(s)-1) or slices.Delete(s,-1)
func Delete[S ~[]T, T any](s S, i int) (r S) {
	if i < 0 {
		return deleteByIndex(s, len(s)+i)
	}
	return deleteByIndex(s, i)
}

func deleteByIndex[S ~[]T, T any](s S, i int) (r S) {
	switch i {
	case 0:
		r = s[1:]
	case len(s) - 1:
		r = s[:i]
	default:
		r = make(S, len(s)-1)
		copy(r, s[:i])
		copy(r[i:], s[i+1:])
	}
	return
}

Looking forward to your reply.

1 and 2 were previously rejected, see https://github.com/golang/go/discussions/47203#discussioncomment-1034432.
3 exists as an in-place operation, see https://pkg.go.dev/slices@master#Delete.

1 and 2 were previously rejected, see #47203 (comment). 3 exists as an in-place operation, see https://pkg.go.dev/slices@master#Delete.

Delete is a bug function, are you serious?

1 and 2 were previously rejected, see #47203 (comment). 3 exists as an in-place operation, see https://pkg.go.dev/slices@master#Delete.
About 1.
again, In order to improve development efficiency! Go language should be oriented towards application development infrastructure rather than algorithmic programming. Am I miss somthing?...
If there are no other solutions(apis), should we consider making it exsit? They are popular function interfaces, and you should really consider it seriously.

We plan to first develop a plan for iterators (see the earlier discussion at #54245).  Once we understand whether or how iterators should be available in Go, we can consider what a general Filter or Map function might look like.  We want to avoid moving too fast and winding up with differing versions of these functions.


Custom Panes and Pane Management

It would be excellent to be able to create/delete/manage custom map panes and then be able to specify which panes your layers get added to.  This would allow fine tuned control over css changes to groups of layers at once, allow you to solve z-index issues, and this would even be an excellent solution for #1734.
What has brought about this, is that I use a lot of SVG objects on my map application.  There are certain svg elements that I want to be above others all the time (with regards to z-index).  However svg elements don't use z-index, and instead the elements added to the DOM last are the ones shown on top.  The problem is that I add and remove a lot of the SVG elements to the map during normal usage of the mapping application.  So this constantly changes which SVG elements are on top all the time.
Custom map panes would solve this problem and give the user a LOT more fine tuned control over their groups of layers and how they are displayed and interacted with.
Any thoughts on this?

@mourner Does this only work with markers? I was trying to use it for a FeatureGroup, and had no luck.
var filterPane = map.createPane('filterPane');
var drawnItems = new L.FeatureGroup({pane: filterPane});

The shapes I add to the FeatureGroup still get drawn in the overlay-pane.

To answer my own question, it appears FeatureGroup does not take an options object. You must set the options explicitly, after creation.
var drawnItems = new L.FeatureGroup();
drawnItems.options.pane = 'filterPane';

@rwwagner90 it does, it just accepts a string rather than reference that I see in your sample.

@mourner I thought, based on the sample code above, either would work?

Hmm, I should look into why it didn't...

I actually was incorrect, when I said that it worked setting it to the string. I had changed something else to make it work. Setting the pane in a FeatureGroup appears to have no effect on where the shapes are drawn. They are still drawn in the overlay layer. However, using the renderer works.
var renderer = (L.SVG && L.svg()) || (L.Canvas && L.canvas());
map.createPane('filterPane');
renderer.options.pane = 'filterPane';
draw = {
      polyline: {
        metric: true,
        shapeOptions: {
          renderer: renderer,
          color: color,
          weight: 5,
          fillOpacity: 0
        }
      },
      polygon: {
        allowIntersection: false,
        showArea: true,
        drawError: {
          color: '#b00b00',
          timeout: 1000
        },
        shapeOptions: {
          renderer: renderer,
          color: color,
          weight: 5,
          fillOpacity: 0
        }
      },
      rectangle: {
        shapeOptions: {
          renderer: renderer,
          color: color,
          weight: 5,
          fillOpacity: 0
        }
      },
      circle: {
        shapeOptions: {
          renderer: renderer,
          color: color,
          weight: 5,
          fillOpacity: 0
        }
      },
      marker: false
    };

Is there a way to just get the shapes drawn in the FeatureGroup added to the pane I choose, without doing this renderer stuff?

When will this feature be in a release?

@mourner what is the supported way to use custom panes with a FeatureGroup containing shapes? I can have them show up in the correct custom pane when I first draw them, by passing a renderer in, but then when I come back to the page later, and load the shapes, I don't know how to tell it to add those shape objects to the correct pane. Help would be appreciated! This custom renderer stuff doesn't really have any documentation.

@rwwagner90 What do you mean "passing a renderer in"? Can you provide a code sample of that? I'm curious.

@Jakobud if you look a couple comments up, I posted my drawing options code. You'll see that I create a renderer, and then pass it in for each shape type's drawing options.

Hmmm. That is interesting. I didn't realize you could specify a renderer to use in vector layer options.
With the existing 0.8-dev pane management, you can create a custom pane, then create a custom renderer and add that renderer to the custom pane. Then if you just specify the renderer then it should work...   What exactly is the problem you are having?

Actually I just re-read your comment. You should be able to create a custom pane, then create a custom renderer and chose that custom pane in the renderer options.
Then, whenever you add a vector layer, specify that renderer, and it should end up on that custom pane in that renderer DOM object.

@Jakobud you are right. I was trying to just set it for the FeatureGroup though. I think it makes sense that I should be able to pass the renderer in the options object for the FeatureGroup, and not have to set it for every vector, but I can set it each time for now.

I honestly haven't worked with FeatureGroups before. Are feature groups supposed to work in a way where the individual items in a feature group are supposed to inherit the options of the feature group? If so, yeah I would expect you to be able to specify the renderer only in the feature group and the layers would inherit the renderer option. But I'm not sure. I'm brought up this approach over on #2786. It seems very straightforward. Better than what I was proposing.

@rwwagner90 I'm looking back at your code. Where are you getting the shapeOptions in your layer options? I've never heard of that before. Is shapeOptions a FeatureGroup thing?
Also how are you specifying the renderer in the options for a vector layer and having it use that layer? I don't see anything to handle that in the code:
https://github.com/Leaflet/Leaflet/blob/master/src/layer/vector/Path.js
According to that, a vector layer is going to get it's renderer from the this._map.getRenderer(this) (https://github.com/Leaflet/Leaflet/blob/master/src/layer/vector/Path.js#L27).
Can you elaborate a bit on what you are doing exactly?

Nevermind I think I figured it out here:
https://github.com/Leaflet/Leaflet/blob/master/src/layer/vector/Renderer.js#L67

shapeOptions is for leaflet.draw. It's not a pure Leaflet example. Here is roughly how you would do a renderer in pure Leaflet:
map.createPane('myPane');
var renderer = (L.SVG && L.svg()) || (L.Canvas && L.canvas());
renderer.options.pane = 'myPane';
var drawOptions = {renderer: renderer};
var layer = L.rectangle(shape.points, drawOptions);
map.addLayer(layer);

This feature is stable? It can be included to stable release?

@gorshkov-leonid It was added to the latest dev branch. See here:
https://github.com/Leaflet/Leaflet/pull/3266
I am using similar code in production here http://ps2maps.com

Great, thank you. And one more question, vector renderer can be extended to show custom labels, DIV-s - not only vector geometries?

Can be better declare method getPaneNames to provide ability iteration over all panes...

Vector renderers are for rendering either SVG or Canvas elements on the map. That's it. Custom labels are not necessarily vectors and can be put on their own custom panes just like normal.
Look at map.getPanes() to return a list of the panes.

Pane is DIV. As i understand position of DIV that has been insterted to pane should be synchronized manually during operations pan/zoom? So to automatically synchronization screen coordinates with specified longitude-latitude can I implement ILayer interface with mixing Renderer? Can you help me find documentation that API?.

@gorshkov-leonid it should only be synchronized on zoom. For an example of a very basic layer implementation, you can look at the ImageOverlay source.

Thank you very much. Sorry of dilettant question. May be better in future to describe in future 'best-practice' example in  http://leafletjs.com/examples.html.

Not sure where to ask about this, but how would I add shapes manually to these custom FeatureGroups and renderers and whatnot? I'm using Leaflet.Draw and when I draw the shapes, everything works, but if I want to prepopulate with some stored shapes, it adds the shape and then Leaflet.Draw does not know about the shape. How do I fix this?

I figured out the issue. I had to do this:
   let layer = L.geoJson(this.get('valueGeoJson'), {color: '#C12A0F', renderer: this.get('renderer')});
      this.addLayerToMapAndShapesArray(layer.getLayers()[0]);

How do I create just one layer object so I don't have to do layer.getLayers()[0]?

Hi, I cannot make the show/hide feature work...
All I want is to have different groups so that I can split my markers based on some criteria and then show/hide them with checkboxes as a group (should be more optimal than iterating them).
I have a difficulty to do it. I added 1 pane per 1 group (and added the group to the pane), so that I can (in theory) do “display = none” on the pane.
But it does not work, it seems that the pane does not contain the feature group in order to hide it when the pane also hides.
I will appreciate your feedback! Thanks!

@af7 look at #3266

Thank you, but is this needed for markers too or just vector layers?
All I have are markers that use a DivIcon with SVG inside their 'HTML'. Then I add these markers to FeatureGroups, based on some criteria.
Should i apply a custom renderer when creating the marker? (I understand that 'renderer' is not related to markers though).
All I want is to make the FeatureGroups show/hide. I would not even add them to a different 'Pane' per group if I had something like 'map.hideGroup(group1)' and 'map.showGroup(group2)'. I understand that you tie the show/hide logic with panes (and this logical), but then why aren't the layers of the group added to the pane, while I did added the group to the pane?

You can show/hide marker planes or vector planes or whatever planes you want. You don't need a custom renderer for markers.

Thanks Jake, I understand I can do this but I do not know how. I did not see any "show/hide" method for panes (I assume you mean "panes", not "planes").
And the other problem is that I added markers to a FeatureGroup which then I added to a custom pane. It appears that the markers of this group are not added inside the pane, so when I do "display:none" on the pane then nothing disappears.

There is no show/hide method. Simply use css or jQuery.
$('markers-pane').hide();
Or animate the CSS opacity, or do whatever you want. The panes are simply DOM elements so you can do whatever you want with them to show/hide them.

Are you doing this on the 1.0 beta 1 branch? This doesn't work in 0.7.x.

Ok, I manage to do this (with display:none) that was not that actual problem.
The proplem is that when you add a featureGroup to a pane, then the markers that are added afterwards to this group are not children of this pane's DIV, so they are not hidden.

That sounds like that may be a bug with the 1.0 beta1 branch then. Have you tested this with other things? Try adding markers to custom panes? Or vector lines? etc? Do they work or do you get the same result?

I tested it with simple markers and it worked. It appears that adding the FeatureGroup to a Pane has the problem with the markers of the group.

Is there a way to add a tileLayer above an objects pane, currently? I have a tile layer that's just labels which I'd like to have over a group of polylines...

@hilarykitz We've just written a tutorial on that: http://leafletjs.com/examples/map-panes.html

Whoa exactly what I was looking for, thanks so much :)

@IvanSanchez update: is there any way to still allow cursor interaction with the polylines?

@hilarykitz pointer-events css was set to none:
map.getPane('labels').style.pointerEvents = 'none';

Just don't do that if you still want to interact with the polylines.

@Jakobud that pointer-events applies to the labels pane, not to the polylines pane. And it might not even be needed if https://github.com/Leaflet/Leaflet/pull/3937/files (or a slight modification of that) gets merged.

Could someone maybe explain a bit, how to use featureGroups with map panes, I'm not entirely sure I  understand

Hi @Delboyeire, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features.
For questions on using Leaflet, please use Stack Overflow or GIS Stack Exchange.
Note: currently panes are of no use with Layer/Feature Groups themselves, only for non-group layers (like Markers, vector shapes, etc.). See posts mentioned in https://github.com/Leaflet/Leaflet/issues/4#issuecomment-358930860


[FP]: CVE-2022-45688 on<EMAIL_ADDRESS>

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:json-java_project:json-java:1.13:*:*:*:*:*:*:*
CVE
CVE-2022-45688
ODC Integration
{"label"=>"Maven Plugin"}
ODC Version
6.1.1
Description
his vulnerability affects the https://github.com/stleary/JSON-java not the https://github.com/java-json-tools/json-patch

You should upgrade your dependencycheck version before filing long-resolved false-positives


Converting Error

Looks like missed ";" after break cause converting error
package
{
	public class Test
	{
		private function func():int
		{
			switch( platform )
			{
				case 1:
					return 1;
					break
				case 2:
					return 2;
					break
			}

			return 0;
		}
	}
}

ERRORS: These files were not written due to source parsing errors:
In Test.as(12) : Unexpected :

Line 12 - "case 2:"

I too am getting this error with the latest git version, is there a fix available?

I too am getting this error with the latest git version, is there a fix available?

Unfortunally looks like no, I manually fix sources before converting

Thanks for the update. Is @SlavaRa still maintaining this project?

@JonnyTech I can fix it on the weekend.


Removal of nonfunctional package_api_docs lint

Background
The lint hasn't been functional for a long time. However, it has also been around and added to analysis options for a long time. Instead of trying to fix it and introducing a bunch of new warnings on SDK update, let's deprecate and promptly remove it.
Keeping it around in its current state sets false expectations for developers who expect it to be ensuring their package's libraries are well documented.
Replacement
If anyone is interested in proposing implementing a replacement, it can be added under a new name, so developers can be aware when they opt-in to enabling its new behavior. Please open a new lint proposal if you are interested in that work.
Removal plan

Publish this issue as notice and for pointing to as a reference.
Remove it from analysis_options.yaml files across the dart-lang and flutter organizations.
Deprecate the lint in the SDK before the first Dart 3.7 beta release (cl/389585).
Remove usages of the lint elsewhere across the open-source ecosystem.
Depending on how the deprecation goes, remove the lint in either Dart 3.7 or 3.8.

This lint has been deprecated and removed from dependent repositories and major lint sets.
https://dart-review.googlesource.com/c/sdk/+/396780 is ready for review and finalizes the removal. Thanks all.


added chemistry guide to guidebook

Changelog
:cl:

add: Added chemistry guide

please test your PR in game

updated, fucked with it a little. probably wont work

Run this command in your windows powershell after targeting your Repo directory and fix the changes, there is YAML formatting errors which means we cant merge it.
dotnet run --project Content.YAMLLinter

why in god's name with Resources/Locale/en-US/guidebook/guides.ftl consistently creating merge conflicts? ive tried fixing it but it doesn't want to work

Any news on when this'll be merged?

Fixed all those things, should be ready now

All checks are passed, changes are approved, no conflicts either. Any news on if or when this'll get merged? I'd rather close the PR if it won't, because it's been open for a month now.


Hidden Power Glitch Fixed

OK @Zarel, I ran this with npm test and no errors, tested it out a few times, and all went well. Close it anyway for another reason if you have to, but the tests went well.
(This is the Z-Move Hidden Power code)

Someone still needs to fix this in the client

Not the baneful bunker thing, the original pullreq

Thanks for the contribution! I'll need to investigate since the problem should most likely be fixed somewhere else, though.

Reverting in a second

I didn't have time to review this from now, but I just tested this.
This was never broken, there's no need to fix it.
In the future, please test things before you try to fix them.


[SR-15703] MainActor isolation fails when synthesized async function (from Objective-C method) throws an error

Previous ID
SR-15703

Radar
rdar://89479707

Original Reporter
@toddreed

Type
Bug

Status
Resolved

Resolution
Done

Attachment: Download

Environment
swift -version
swift-driver version: 1.26.21 Apple Swift version 5.5.2 (swiftlang-13<IP_ADDRESS> clang-13<IP_ADDRESS>)
Target: x86_64-apple-macosx12.0

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
@kavon

Priority
Medium

md5: c52cb58ce3c02bb5270368dfb10304f1

Issue Description:
When calling a synthesized async function (i.e. synthesize from an Objective-C method) from a @MainActor function in Swift, execution resumes on a background thread instead of the main thread when the function throws an error.
Example: in the code the below, the assertion in the catch block fails.
@main
class MainActorBug {

    @MainActor
    static func main() async {
        let adder = Adder()
        do {
            let result = try await adder.add(-5)
            assert(Thread.isMainThread)
            print("The answer is \(result)")
        } catch {
            assert(Thread.isMainThread, "Not on main thread")
            print(error)
        }
    }
}

To reproduce:
unzip MainActorBug.zip
cd MainActorBug
swift run MainActorBug

The implementation of this fix introduced a regression. It has been reverted in https://github.com/apple/swift/pull/58397 , so I'm reopening this issue until that is resolved.


Add files via upload

This is a space made in order to add my school named TESCo.

@JorgElectro tesco.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


[BUG] Fails to run obcommand that has spaces

Please Review Before Posting!

[x] I checked that the bug does not happen in the CodeMirror Vim demo. If it does, please report it there and not here.
[x] I'm reasonably sure that this bug is indeed about the Vimrc file support and not a general Vim in Obsidian issue. If it's a general Vim issue, report it here.

Describe the bug:
I want to map a templater template to a key. I added it to the obsidian commands using the Template Hotkeys section in the templater settings. The command id is templater-obsidian:path/to/template.md. In my case, the templates folder has a space, therefore the id looks like this: templater-obsidian:path to/template.md. I added the following lines to my config:
exmap insert_template obcommand templater-obsidian:path to/template.md
nmap <Space>t :insert_template

When I press <Space>t, it only outputs in the console Error: obcommand requires exactly 1 parameter.
Is there a way to make it work (without having to rename the folder)? If not, I'd suggest adding support for "command:that has spaces" (edit: actually I don't know if this is how it would be done in a .vimrc).
Environment (please complete the following information):

OS: Windows 11
Vimrc plugin version: 0.9.0

I don't think this can be fixed right now because it's a limitation of CodeMirror Vim and you can't customize the delimiters; however, I found a way around it. You can use the Command Alias plugin, customize a new command, and find the new command id without space through :obcommand (the command id like this obsidian-command-alias-plugin: Alias: XXXXXXXXX) , and map the new command directly.

Never heard of that plugin. It works well, thank you!


Typo "@cleartext"→"@cleartext"

https://docs.microsoft.com/en-us/sql/t-sql/functions/signbycert-transact-sql?view=sql-server-2017

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


@extend not compiling in css

Here is my simple css
%bee-color {
  background: blue;
}

#bee-cluster-1 {

  .bee-1 {
        @extend %bee-color;

  }
}

This is compiling to
#bee-cluster-1 .bee-1 {     @extend %bee-color: ; }
Which gives me an unnamed property error in browser. Setting it with an @include mixin will result in correct compiling.

Running the current version 4.0.0, it works fine for me.
//compiles to
#bee-cluster-1 .bee-1 {
    background: blue
}

Please consider upgrading to a newer version and provide your project version next time for better debugging :)
PS: In my experience 🐝s are rather black and yellow/gold, and so are their hives, but that´s just my experience ^^

Hmm, it's not transforming for me either. I'm using<EMAIL_ADDRESS>This...
%constrain-content-width {
  max-width: 1100px;
  margin: 0 auto;
}

.header {
  @extend: %constrain-content-width;
}

compiles to...
.header {
  @extend: %constrain-content-width;
}

Variables are compiled fine, though. I just can't get extend to work.
If it helps, I am using PostCSs & precss in the context of  Hugo. So, the way I'm using it is this:
<head>
  ...
  {{ $style := .Resources.GetMatch "styles.pcss" | resources.PostCSS (dict "use" "precss") }}
  <style>{{ $style.Content | safeCSS  }}</style>
</head>


Any idea if this will work on the Dualsense Edge? (Feature request)

Probably would like to add this as a feature request too if it doesn't currently work.

I don't have one to try personally, but people on some facebook groups said that it's working. let me know if you have any issues with that


Actually compilable version of Ending::DeletedCallback

92.whatever percent matching, when the game ends and you save/discard your replay, the screen just stays white, with the menu music playing, I haven't tested if it's a problem with the code, because I have to play for 40 minutes to test LOL. We need some way to better jump to the game ending if we are going to feasibly test this.

Got implemented in #285


No run file

can you elaborate the issue

if you're looking where does the 007-thebond.py  is , it's in the  src folder


[update] reviewdog.yml

I changed a github actions's yml bit.
This patch only review for master branch and can detect errors and drop ci.
Like this

https://github.com/kazukazuinaina/vim-airline/runs/431470464

@chrisbra
I want to merge this patch.
Is it okay?

thanks!


Inference Speed Unstable Problem

Hi~~
Firstly, I want to say this project is very helpful which helps me deploy my deep learning model on ARM successfully.
Then, there is a problem I met during testing the model inference speed. For a deep learning model, machine translation model, for example, the inference speed is unstable, Here is a detailed description:
1. Translating the same single source sentence to the target sentence is various and no rules to follow. Testing the same sentence for 200 times and there are 3 or 4 times the speed is slower than average.
2. The inference speed and the length of a source sentence is non-linear. Sometimes translating a very long sentence say 30 words will consume a shorter time than a very short sentence which may only have 5 words. While as far as I know, the inference time is related to the length because the model will generate the target word one by one to form the target sentence.
I'm not sure if the problem is related to the TensorFlow-serving-arm image, but I can't find a useful answer on google. Do you come across this problem when deploying the DL model? I would appreciate it very much if you would help me with it.

Hello,
I'm glad this project was able to get your model up and running quickly. Unfortunately, I have not encountered the issues you describe, but my projects don't have very strict tolerances for serving response times.
Are you able to eliminate other potential causes such as I/O or other resource bottlenecks of the ARM device itself?

Closing for now since I haven't yet received any response.


Fix integration test from clone

With this pull request we reverse logic determining whether to run pipeline tests or not during development.
So that we can clone code and run all tests without any failing due to missing local.settings.json
This entails the need to provide an environment variable in our pipeline.

What is now the recommended way of running these tests during development?

With today's commits to this pull request, a new attribute inherited from XUnit Theory will ensure that tests are skipped if no integrationtest.local.settings.json file is present, thus it is now possible to run all tests in the Charges domain right from Git clone.
As prior to this pull request, you can set up your own integrationtest.local.settings.json and run all integration tests using Azure sandbox resources.


your 'Info.plist' file is named 'info.plist'

meaning the app won't work on any case-sensitive file-system

Thanks for raising this. It will be addressed by #686

Fixed in new release. Thanks all.

awesome thanks

actually, in 2.0.40-beta it is still lowercase "info.plist" so i cannot confirm this has been resolved

@matryer - just double check you've removed info.plist from your local app/assets/Mac dir. As the FS is case insensitive it'll pick it up.

Can someone else's brain please confirm that this is right?

Let's see if this is better: https://github.com/matryer/xbar/releases/tag/v2.0.41-beta

sorry but i don't see any improvements:
ls -la /Volumes/Install\ xbar/xbar.app/Contents/
total 8
drwxr-xr-x  5 julian  staff   170 Apr  5 16:49 .
drwxr-xr-x  3 julian  staff   102 Apr  5 16:49 ..
drwxr-xr-x  3 julian  staff   102 Apr  5 16:49 MacOS
drwxr-xr-x  3 julian  staff   102 Apr  5 16:49 Resources
-rw-r--r--  1 julian  staff  1116 Apr  5 16:49 info.plist

i downloaded xbar.v2.0.41-beta.dmg and did not check the tgz version

I’m baffled. Might just drop my iMac out the window.

@core-code ok - how about now? (And thank you for your patience while we get this right)

its fixed now, thanks!


mendely word plugin problema

Automation error
Catastrophic failure (-2747418113) in Mendeley Plugin?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e42d3bb-a2dd-4f4a-a12d-6e2817727ffd
Version Independent ID: 528bb34c-5e0a-d434-b93a-0fc3b407fe93
Content: Automation error (Error 440)
Content Source: Language/Reference/User-Interface-Help/automation-error-error-440.md
Product: office
GitHub Login: @o365devx
Microsoft Alias: o365devx

@crisjavper
Thanks for your feedback. We use Github issues for documentation bugs, not for developer support. Please try the VBA developer community on Stack Overflow (https://stackoverflow.com/questions/tagged/vba) where you can get help from actual developers. If you find a bug in our documentation, please let us know! Thanks!


Provide auto-complete for custom commands

I would be great to have user-defined commands (e.g. \newcommand{\Bold}[1]{\textbf{#1}}) showing up in the completions list.
In my case I have a latex_commands.tex file, included in the root document (using \include{latex_commands}), where I keep all my custom commands. TexStudio handles with and its the only thing that bothers me when using Atom-Latex.
Is it possible to provide such a feature?

Currently custom commands are read only from active editors, and not all files from the project.
As a workaround, try opening latex_commands.tex once!

Well, the file was already open in one tab but the commands inside doesn't show up...
For info I have Atom-Latex 0.8.1 installed with Atom 1.18.0

Nevermind my previous comment - All include{} files are also parsed for commands. Let me look a bit deeper.

I found a solution, I had the "Symbol" provider selected in autocomplete-plus settings, changing it to "Fuzzy" makes the completion work as you mentioned

Nice, didn't know of that one! :-)

But it still doesn't seem to work with included but not open files

Yes, as the included files are parsed for commands of the format \command{}{}{} currently.
So \newcommand{\Bold}[1]{\textbf{#1}} leads to suggestions of \newcommand{ } and \textbf{ }
I will have a look at recognising \newcommand{} and \def but it's not going to be that quick ;-)

Hello, so this is still true: autocompletion for custom commands works only after using the command once?
Would it be possible to make an option to always include any custom command to the auto-completion list? I have a large commands.tex file which I use in different projects and I do not remember any single  command exactly. So in a new project I have to manually look up any command which was not used before. Even better would be a possibility to pass a package which has some \newcommand \renewcommand entries and to automatically ad all of them to the completion. By this you will add a very handy feature of including "custom" commands which you need only in some projects (like beamer...).

@stakaz All depended tex files are parsed for commands - so your commands.tex file should also be parsed (when it finds a  \incldue{commands.tex}) and should show up in the suggestions. Or are you experiencing different behaviour?
About the package commands - that indeed would be lovely - but I can't off the top of my hat think of an elegant solution to do it. Unless each package exports a list of commands/documents it in a parse able fashion?

Well, I have the following sturcture:
root.tex
    \import{preamble_report}
preamble_report.tex
    \import{preamble_global}
preamble_global.tex
     \import{commands}

Used commands from commands.tex ar shown as suggestions but not all.

Could you share a sample of the commands that are proving to be problematic?

Essentially every unused command. Example would be:
\newcommand{\pardiff}[2]{\frac{\partial #1}{\partial #2}}
\newcommand{\id}{\mathds{1}}

I have also tried to use \include{commands} directly in the root.tex file but no luck.

I have the solution: \include{commands.tex} needs to have the file in the same root folder. Now everything is working as expected.

Oh now, I have another thing: commands without arguments expend to \command{} while it would be enough to have \command.

Oh that is interesting about the path issue - this is a bug not a feature ;-)
I will have a look.
Noted about the \command will fix that as well :-)

The thing with the path of include is that it can only point to the root directory or child directory but not to another place. Otherwise latex cannot create an .aux file. So the question is: should also \import work for adding commands to autocompletion or not?


Post windows when shown doesn't work on Linux.

Describe the bug
I set "Post windows when shown" on the "General" tab of the "Preferences" window and then brought up various windows and it always showed the windows normally on Linux. On Windows, it brought up the windows on the notepad.
Desktop

OS and version: Linux
VisIt Version: 3.1.1

Niether 3.0.1 nor current develop branch appear to behave as desired on OSX either.
Worse, as I post windows manually...I don't see anything in the main panel. Thats because the post area is all collapsed. One has to know to go there and drag it up before you see anything posted there.

Adding -noconfig makes it work on OSX

I am unable to duplicate this on my local linux (rhel6) machine, using installed visit 3.1.2.
I removed ~/.visit/config and ~/.visit/guiconfig
I ran visit 3.1.2, turned on the 'Post Windows when shown' and save settings. I then opened a window, it was posted.
I closed visit and reran. My settings were preserved and windows were posted when opened.

Setting this option using develop on my mac (Catalina) seems to work as expected.

This also appears to work as expected when I'm running on Pascal.


Allow validation from rules next to custom Request class

For me it's annoying - especially in a large project - to write custom FormRequests for the validation of each and every CRUD. Laravel provides already functionality to validate the "default" Request using a set of rules in an array.
This PR adds this functionality to Backpack

A new inspection was created.

A new inspection was created.

The inspection completed: 3 new issues, 1 updated code elements

The inspection completed: 3 new issues, 1 updated code elements

Hello @sjefmoling
Thanks for raising the issue and providing a PR to it.
When you say that Laravel provides a way to validate with an array in controller you are talking about: https://laravel.com/docs/8.x/validation#manually-creating-validators ??
If this is the case, why not use the Laravel way? The way I see it, we are just creating an "overlay" over already implemented Laravel features with no actual benefit ?
Let me know if I missed something here.
Best,
Pedro

Although there're many workarounds, I think it will also benefit to keep the code (c)lean and to prevent the nessecity to override the trait store() and update() methods just for validation. Now one needs to add
`public function update(Request $request)
{
$request->validate([ ... ]);
    return $this->traitUpdate( );
}`

@sjefmoling I like the idea of moving the validation to the controller (optionally). It'd be one less file to worry about.
I'd rather have the validation rule defined inside the same addField() statement though, I think it'd be easier for the dev to write everything in one go. After all, that's when you realise that field is required, when you add it to the form. So I think a cooler way to approach this would be to have the update() and store() methods check if any of the fields have a validation or rules attribute (don't know what a good name for this would be). If so, it would validate them.
Of course, both approaches will have a downside (any controller-based validation, really). If you have a complex validation, or custom validators, or you need to specify different messages for the validators... you'd still be better off using a separate Request file...

sounds like a workable solution too. Naming remains difficult, but personally I'd choose rules

I think I've figured out how to do this with no downsides:
// so you can still do this
CRUD::setValidation(ArticleRequest::class);
CRUD::setValidation('App\Requests\ArticleRequest');

// but you can also pass a rules array (optional second parameter for messages)
CRUD::setValidation($rules, $messages);

To sum up, setValidation() would accept three things for the first parameter:

string => it's a FormRequest
classname => it's a FormRequest
array => create a Validator object and run it (optional second parameter as messages array)

// I expect most people will just do:
CRUD::setValidation([
    'title' => 'required|unique:posts|max:255',
    'body' => 'required',
]);

What I especially like about this approach is that the validationRules and validationMessages are stored in a setting. Which can also be populated by the addField() statement, so in the future the dev might also be able to do:
CRUD::field('title')->type('text')->validationRules('required|unique:posts|max:255');
CRUD::field('title')->type('markdown')->validationRules('required');

// during the validation, we'd see that validationRules and/or validationMessages is populated,
// and we'd create a custom Validator with them and run it; no need to call
// CRUD::setValidation() anymore if at least one
// CRUD::field()->validationRules() is defined

So in total you'd have THREE ways of validating fields:
// Option 1 - pass the FormRequest (it will ignore any defined validationRules)
CRUD::setValidation(ArticleRequest::class);
CRUD::setValidation('App\Requests\ArticleRequest');

// Option 2 - inline validation when defining the field
CRUD::field('title')->type('text')->validationRules('required|unique:posts|max:255');

// Option 3 - define a custom validator (it will override the inline-defined validation rules)
CRUD::setValidation([
    'title' => 'required|unique:posts|max:255',
    'body' => 'required',
]);

Hey @sjefmoling ! I have great news - I've built upon your PR, implemented the ideas above, and...

You can now do ALL of the above. I think will be my preferred method will be inside fields - after all that's when I think about what validation rules that field should respect.
Please take a look at https://github.com/Laravel-Backpack/CRUD/pull/4004 , tell me what you think and what your favorite way to do this will be 😀
Thanks again for submitting this 🙏
This is gold!

Closing - let's move the conversation to https://github.com/Laravel-Backpack/CRUD/pull/4004 which includes this PR and one more way of doing this.

Great sollution! Love what you did with it and love to see it moving to production!


chore: Remove client subscription for delete branch

Description

Delete branch can take more time if we are trying to delete the branch with lot of resources and the client may cancel the request. This leads to the flow getting stopped midway producing corrupted DB objects. The PR ensures that even though the client may have canceled the flow, the delete branch should proceed uninterrupted, and whenever the client runs sync branch flow valid branch list will be available.

Fixes #13822
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

JUnit TC
Manual testing

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=63bbb47

/ok-to-test sha=c8e8251

/ok-to-test sha=ab7caf2


[WIP] Add copy to method to content provider

Allows content provider to optimize creation of files directly from the blobstore. This could be used to call copy file range on file systems which support it.

Marked as work in progress, updated to not make interface changes


Review needed: OTel for Beginners - The JavaScript Journey -  Ep. 1 What is OTel?

Background
OTel for Beginners is a YouTube series aimed to help beginners get started on their JavaScript journey.
The target demographic is developers new to observability and OTel (including high school & college students).
This episode was intentionally designed to be rudimentary so that even a layperson can explain OTel and observability to others.
The rest of the series will be more technically driven and will have hands-on experience (see concept roadmap for more details)
Review needed
The deck has the script in the presenter's notes section.
What I would like help with is for someone to read over the script and the deck and ensure there isn't any incorrect info or something that does not align with OTel's vision or messaging.
If you find anything, please use the comment feature on the Google slide deck.
Please ignore [A] in the script - these are cues to activate animation during recording.
Timeline
This episode will air in January.
To meet the release timeline, the review should be completed by December 13th, 2024.
Thank you so much for your help! I appreciate you!

Hello!
Could I have get a pair of eyes on this script?
Looking to film this episode soon.
Thank you!

The deck has the script in the presenter's notes section.

@LisaHJung That deck link is to "What is OTel?" slides that covers intro material, and doesn't (yet) get into JavaScript-specifics. Is that correct?
I work on some parts of OTel JS and was going to review for JS-related content.  I skimmed the slide notes and they look reasonable to me.

I will get into JavaScript specifics starting in episode 2 and beyond.
I will start filming this episode.
Thank you so much for your help!


请问可以实现自动管理入群吗？

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
能否实现发送验证码到对方edu邮箱，对方回复正确验证码后加群成功？谢谢！
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
[enhancement]

I want this feature too!


Interactive learning: Fix  "No such file or directory: 'data/core/stories.md'"

Proposed changes:

Create output paths for stories.md and domain.yml file if path not exists.

related to http://github.com/RasaHQ/rasa/issues/3504
Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog
[x] reformat files using black (please check Readme for instructions)

Hey guys,
I am still facing this issue. Just the update the rasa to the latest stable version. Seems like not working.

@Nomiluks can you check which rasa version you have installed? is it 1.0.1?


ERROR in Cannot find module './_Stack'  @ multi main

on npm start the above error pops up.

This should be fixed now


Admission Controller self-signed cert requires SAN

Where is the problem?
https://docs.konghq.com/kubernetes-ingress-controller/1.3.x/deployment/admission-webhook/
What happened?
When following the instructions (or downloading the code from https://bit.ly/install-kong-admission-webhook), I get the following error when any call touches the admission controller:
Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "validations.kong.konghq.com": Post "https://kong-validation-webhook.kong.svc:443/?timeout=10s": x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0

What did you expect to happen?
This error is a result of how the SSL certificate is created:
openssl req -x509 -newkey rsa:2048 -keyout tls.key -out tls.crt -days 365  \
  -nodes -subj "/CN=kong-validation-webhook.kong.svc"

The fix is to add an alternative name:
openssl req -x509 -newkey rsa:2048 -keyout tls.key -out tls.crt -days 365  \
  -addext "subjectAltName = DNS:kong-validation-webhook.kong.svc" \
  -nodes -subj "/CN=kong-validation-webhook.kong.svc"

NOTE: The default openssl on a Mac is LibreSSL 2.8.3 which currently does not support -addext (needs LibreSSL 3.1.0 or higher). Mac users should be instructed to use OpenSSL via brew or equivalent.
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

@Kong/team-k8s Can you take a look at this issue and verify that the fix is one we should document?

@lena-larionova the -addext suggestion is valid and is what we should add to docs. Up to you whether or not it makes sense to include a disclaimer for OS X openssl tool version info or not--hopefully OS X bumps their default toolset soonish, but I'm not a Mac person and don't know what timelines for that are/typical dev environment expectations around installing newer versions of TLS utils.

Came across this while reviewing old issues and realized that it was still open, but the docs pages actually do use a command that includes SANs, and have (I think) a command that adds them even with the outdated OS X LibreSSL. This issue is actually for the script, which resides in the KIC repo, not docs. Fix for that in https://github.com/Kong/kubernetes-ingress-controller/pull/2394
Closing this in favor of that since I can't auto-close on merge from another repo.


Guidance on connection string

Can we add some guidance on what the connection string should look like when using Managed Identity and RBAC instead of SAS?
An example such as
Endpoint=sb://{namespace}.servicebus.windows.net/;Authentication=Managed Identity

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c25a321-1f2d-4fec-a957-cfca751941df
Version Independent ID: 9e73bfda-aa08-ee1f-2c17-5cbabe9155b9
Content: Managed identities for Azure resources with Service Bus - Azure Service Bus
Content Source: articles/service-bus-messaging/service-bus-managed-service-identity.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

Related: https://github.com/Azure/azure-service-bus/issues/322#issuecomment-573939529

@4nandP this is more of a question related to the Microsoft.Azure.Services.AppAuthentication library the specific connection string it supports (which is used internally by the Service Bus SDK).
So, to use a User Managed Identity with this library, you would have to set AzureServicesAuthConnectionString to RunAs=App;AppId={ClientId of user-assigned identity} as mentioned in the doc, in addition to setting Authentication= Managed Identity in the service bus connection string.
But do note that this won't work for Azure Functions (as discussed in the related thread) for the Consumption Plan either way, since the Scale Controller won't be able to able to use the same Managed Identity.
Hope that clears some things up and thanks for the feedback! We have assigned this issue to the content author to review and update accordingly.

Added a note for the Event Hubs connection string
https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-managed-service-identity#use-service-bus-with-managed-identities-for-azure-resources
#please-close


[Docs] Checkbox, RadioButton, Toggle, Toolbar - Add title and description to examples. Toolbar - Rename directory.

For #2927.

@mbrookes Awesome. Could you squash down the last commit? I think that we can merge then :tada:.

Put the toolbar changes is a single commit? Can do - they originally were, and I separated them. :broken_heart:

Put the toolbar changes is a single commit?

Yes, I think that it would be better for the history.

Could you squash down the last commit?

Done. And speaking of last commits... This is the last set to finish the new style examples!

@mbrookes Yes it's, we will do a release soon. I'm pretty happy about how the documentation is now :tada:, it's x10 better than 3 months ago.

@oliviertassinari - indeed it is! #2996 is making me sad though. :cry:  That's the biggest gap in the docs right now.


add i18n using nicksnyder/go-i18n/v2/i18n

This was only a partimplmentation. Messages have been defined, but the they have not been fully integrated. The PowerShell generators do not yet use the newly defined messages.


Update README.md

spelling

I am almost done with it, just working on the config flow now, Thanks for the pull request!

Working great outside of units and HACS format as far as I can tell!:

Perfect, I will add units now good call.

Also have you seen anything for Atmos or WaterOne?

No, I can't help with these too much as I don't have an account to figure out how their websites work. Sorry.


Trouble implementing with vuejs webpack template

I'm using the basic webpack template from vue-cli and I cannot get access to $gsap. I'm attempting to access it from a component via this.$gsap and I get an error saying it is undefined.
[Updated]
I can access this.$scrollmagic but not this.$gsap. I ended up having to import TimelineMax to use it.

I have the same problem here.
@pirony, could you take a look into this.


New Island Sanctuary Area weather forecast request

In Patch 6.2, Island Sanctuary add many weather-based animals we could catch.
If there is a weather forecast, it will be a great help for players.

Sorry, forgot to update, it's added now.


build(c): bump vendored fmt

This should fix a clang-18-only deprecation warning.
Fixes #1705.

ah, the file names conflict now, hmm

aha, I didn't realize there was a docker image for the clang18 R uses!


通过SessionDelegate子类实现URLSessionDataDelegate更多的协议

https://github.com/onevcat/Kingfisher/issues/1619
https://github.com/onevcat/Kingfisher/pull/1620

This looks good, can it be merged?

LGTM. Merged and I will tag it with a release later!


Implement HxLib (UI)

Implement Basic HxLib features:

Multi-channel PubSub
DOM / JQuery Element Wrappers ("widgets")
Basic Windows
Basic Window Management

Multi-channel pubsub implemented in global HxBus singleton (window.HxBus or system.bus)
Basic windows implmented as HxPanel (accessible as system.panels or under /mnt/desktop with WASH)


Modis hero update

It was mentioned 17a2h-061 looks a bit light against the white text overlay. I reviewed all the hero imaged on pc datacatolog and decided 09a1, 10a2, 13a1, 17a2h, 43a4, and 64a1 look a bit light too. All these hero images are updated in this PR. Either a different section of the thumbnail was cropped or the image was slightly darkened to help.

Thanks!