Replace all single quotation marks with apostrophes

Replace both the left and right single quotation mark characters with apostrophes since they are much more prevalent. The quotation marks also cause a compilation error in one of the code examples.

@TylerMSFT
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


support hf datat with no gold spans

@rfriel

Codecov Report

Merging #524 (56c4c16) into main (d440623) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%
==========================================
  Files         128      128
  Lines        9872     9876       +4
==========================================
+ Hits         9007     9009       +2
- Misses        865      867       +2

Impacted Files
Coverage Δ

dataquality/integrations/hf.py
100.00% <ø> (ø)

dataquality/utils/helpers.py
87.75% <33.33%> (-3.55%)
:arrow_down:

dataquality/dq_auto/ner_trainer.py
39.39% <100.00%> (+1.89%)
:arrow_up:

dataquality/dq_auto/tc_trainer.py
44.82% <100.00%> (+1.97%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


correct currentConfig

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

GitHub release
v1.4.0

Your semantic-release bot :package::rocket:


Docs updates for available metrics

Fixes #131
Fix spelling of russellrao; List all metrics

Updated the list of metrics based on the ValueError produced when
calling an incorrect error.

Hello @birdsarah! Thanks for submitting the PR.

In the file umap/umap_.py, following are the PEP8 issues :

Line 48:80: E501 line too long (84 > 79 characters)
Line 105:80: E501 line too long (97 > 79 characters)
Line 122:13: E303 too many blank lines (2)
Line 201:80: E501 line too long (88 > 79 characters)
Line 206:80: E501 line too long (82 > 79 characters)
Line 215:80: E501 line too long (81 > 79 characters)
Line 225:80: E501 line too long (80 > 79 characters)
Line 248:80: E501 line too long (80 > 79 characters)
Line 447:80: E501 line too long (87 > 79 characters)
Line 478:80: E501 line too long (82 > 79 characters)
Line 524:80: E501 line too long (80 > 79 characters)
Line 595:80: E501 line too long (82 > 79 characters)
Line 1112:80: E501 line too long (80 > 79 characters)
Line 1170:80: E501 line too long (80 > 79 characters)
Line 1174:80: E501 line too long (80 > 79 characters)
Line 1178:80: E501 line too long (82 > 79 characters)
Line 1179:80: E501 line too long (80 > 79 characters)
Line 1180:80: E501 line too long (84 > 79 characters)
Line 1188:80: E501 line too long (80 > 79 characters)
Line 1192:80: E501 line too long (80 > 79 characters)
Line 1193:80: E501 line too long (82 > 79 characters)
Line 1239:80: E501 line too long (80 > 79 characters)
Line 1287:80: E501 line too long (84 > 79 characters)
Line 1289:80: E501 line too long (82 > 79 characters)
Line 1290:80: E501 line too long (81 > 79 characters)
Line 1341:80: E501 line too long (101 > 79 characters)
Line 1367:80: E501 line too long (81 > 79 characters)
Line 1384:80: E501 line too long (86 > 79 characters)
Line 1423:80: E501 line too long (92 > 79 characters)
Line 1582:80: E501 line too long (82 > 79 characters)
Line 1619:80: E501 line too long (84 > 79 characters)
Line 1622:80: E501 line too long (85 > 79 characters)

Coverage remained the same at 94.562% when pulling 8c9bd92396caa78f76253a7751500d1f55ba2d10 on birdsarah:131_spelling_of_metric_names_in_docs into 1e9a85b8f01fbaaf27eca42a4ba2cfaf03962bb7 on lmcinnes:master.

Thank you!


Buy domain name, configure it

We’ll want to set up “nice” subdomains for users.

[x] Determine if Route 53 offers API access to create new CNAME records.
[x] Pick a name, buy it
[x] Host DNS at AWS Route 53
[ ] Connect to setup script.

Lower priority than https://github.com/codeforamerica/ceviche-cms/issues/74

Route53 does allow record creation via the API, but DNS propagation can be slow and I don’t think we should use it. Other options include placing instances of CMS on a single host, or proxying instances to multiple hosts.

Bought chime-cms.org, chimecms.org, and chime-cms.com. Someone squatted chimecms.com so we’ll be ignoring that for now.

:bell: :dancers:

What looks better as the official domain, chime-cms.org or chimecms.org? The latter matches the Github org name, which we could change if we like the dash.

The latter (no hyphen).

Great. I'll do redirects from the hyphenated version.

Too late, but luckily in agreement too.
On Thursday, February 26, 2015, migurski<EMAIL_ADDRESS>wrote:

Great. I'll do redirects from the hyphenated version.
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/ceviche-cms/issues/73#issuecomment-76212066
.

--
Cyd Harrell
Product Director
<EMAIL_ADDRESS>

Since my comment above, we’ve identified a need for a central Ceviche service to route Google callbacks and perform other functions, so I think it can also act as a proxy while DNS propagation takes place.


Set DOCKER_VERSION on user's jupyter containers

Read in the DOCKER_* values from docker.env and pass them along to the container so that it can access its docker host more easily. DOCKER_VERSION specifically lets them use dvm to install the right docker client.

Thanks! 🍰

I ❤  merging things.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 2cd9551, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 8094 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 2340ca8.


can i use v3 with latest react native (55)and react(16.3)

please do mention the configuration if anyone used it iam getting errors while doing that

Have you tried v3 branch with latest RN?
https://github.com/aksonov/react-native-router-flux/pull/2853
Thanks to @DavidPineda


System.ArgumentException: An item with the same key has already been added.

jaijairai-flex2
System.ArgumentException: An item with the same key has already been added. Key: my-MM
  at System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) [0x0015a] in <c5a54dbe91cb4981b725403e1a171987>:0
  at System.Collections.Generic.Dictionary`2[TKey,TValue].Add (TKey key, TValue value) [0x00000] in <c5a54dbe91cb4981b725403e1a171987>:0
  at LfMerge.Core.DataConverters.ConvertLcmToMongoLexicon.LcmWsToLfWs () [0x0009f] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge.Core/DataConverters/ConvertLcmToMongoLexicon.cs:617
  at LfMerge.Core.DataConverters.ConvertLcmToMongoLexicon..ctor (LfMerge.Core.ILfProject lfProject, LfMerge.Core.Logging.ILogger logger, LfMerge.Core.MongoConnector.IMongoConnection connection, SIL.Progress.IProgress progress, LfMerge.Core.MongoConnector.MongoProjectRecordFactory projectRecordFactory) [0x00079] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge.Core/DataConverters/ConvertLcmToMongoLexicon.cs:65
  at LfMerge.Core.Actions.TransferLcmToMongoAction.DoRun (LfMerge.Core.ILfProject project) [0x00104] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge.Core/Actions/TransferLcmToMongoAction.cs:64
  at LfMerge.Core.Actions.Action.Run (LfMerge.Core.ILfProject project) [0x0010d] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge.Core/Actions/Action.cs:142
  at LfMerge.Core.Actions.SynchronizeAction.DoRun (LfMerge.Core.ILfProject project) [0x003d4] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge.Core/Actions/SynchronizeAction.cs:196
  at LfMerge.Core.Actions.Action.Run (LfMerge.Core.ILfProject project) [0x0010d] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge.Core/Actions/Action.cs:142
  at LfMerge.Program.RunAction (System.String projectCode, LfMerge.Core.Actions.ActionNames currentAction) [0x000ed] in /build/lfmerge-7000072-9dfRZq/lfmerge-7000072-<IP_ADDRESS>/src/LfMerge/Program.cs:128

This should be either 614 or 616 (in master), depending on whether or not FW8 was being used. So my guess is the ServiceLocator.LanguageProject.AllWritingSystems has two items with either duplicate ID's or LanguageTag's.

Since this issue occurred a long time ago, we need to re-verify that this is still a problem.
@josephmyers TODO:

[ ] verify that jaijairai-flex2 is still on HOLD
[ ] if still on HOLD, take it off HOLD and re-do the S/R.
[ ] If the error persists, then debug it.


CZ: Individuals type 2

Hi,
When I use this library to validate the Czech VAT number "CZ699000899", is returns false, yet when I use the site of VIES (http://ec.europa.eu/taxation_customs/vies/) it says that the VAT number is valid.
Maybe the validation rules changed of perhaps there is an error in the validation? According to the code this should be a Czech Individuals type 2 number.
Kind regards

@Steefanieee Hm, that might happen. If you would know any info about that change -please let me know. I'll try to check it

I found another library, sharing the same name, that implements this check properly: https://www.braemoor.co.uk/software/vat.shtml

This gist also contains a fix for it:
https://gist.github.com/svschannak/e79892f4fbc56df15bdb5496d0e67b85


indexing strings with str[expr]

You can't index strings yet:
x := "good faith and wisdom 2 u my child";
y := x[0]; // goof

panic: interface conversion: parser.Type is parser.PrimitiveType, not parser.ArrayType

We should do this after pascal-style strings are done.


Incompatible with BufExplorer plugin

hi！
I Found some compatibility issues  after upgrading MacVim.
But the old version (b4winckler/macvim) has no problem.
Select file:
Escaped
Error detected while processing function <SNR>18_BESelectBuffer[20]..WinManagerFileEdit[71]..<SNR>43_RefreshWinManager[64]..BufExplorer_ReSize:
line   15:
E15: Invalid expression: $
Error detected while processing function <SNR>18_BESelectBuffer[20]..WinManagerFileEdit[71]..<SNR>43_RefreshWinManager[142]..<SNR>43_ResizeAllExplorers[11]
..BufExplorer_ReSize:
line   15:
E15: Invalid expression: $

Open new window:
Error detected while processing function <SNR>43_ToggleWindowsManager[4]..<SNR>43_StartWindowsManager[156]..BufExplorer_ReSize:
line   15:
E15: Invalid expression: $
Press ENTER or type command to continue

My BufExplorer plugin version: 7.2.8
Thanks!

Why don't you use the latest BufExplorer?

BufExplorer_ReSize:15 in version 7.2.8 is attempting to do exe $. execute takes a string, and $ isn't one. My guess is that vim used to accept this due a bug and it's since been patched (although vim's version history is difficult to easily scan, so I gave up looking for the specific change after a few minutes).
Later version of BufExplorer use normal! $ instead of exe $ (starting here).
This isn't a MacVim bug. I think you're just going to have to update your version of BufExplorer.

ok, thanks! :)


Error during "tree-sitter generate"

I've been following https://github.com/EmranMR/tree-sitter-blade/discussions/19 to set up this project in NeoVim. However, when running :TSInstall blade, I'm getting the following error:
nvim-treesitter[blade]: Error during "tree-sitter generate"
file:///Users/klimeryk/.local/share/nvim/tree-sitter-blade/grammar.js:1
module.exports = grammar({
^

ReferenceError: module is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and '/Users/klimeryk/.local/share/nvim/tree-sitter-blade/package.json' contains "type": "module". T
o treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///Users/klimeryk/.local/share/nvim/tree-sitter-blade/grammar.js:1:1
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async file:///Users/klimeryk/.local/share/nvim/tree-sitter-blade/[eval1]:489:16

Node.js v20.17.0
Failed to load grammar.js

Caused by:
    node process exited with status 1

Looking at recent changes, seems that https://github.com/EmranMR/tree-sitter-blade/commit/5eae5e1677191bb42506bf160906e34612a438b0 might have caused this? Removing type: module from package.json indeed allowed me to install it successfully (https://github.com/klimeryk/tree-sitter-blade/commit/6d0cb7902db63daf694dd2c74a8e1da772114feb). But I'm not sure if that's the ideal fix, depending on if you do want it as ES module or not.

Hi all, sorry for the delay and the inconvenience this has caused. This was due to the ESLint's recent migration from commonJS to ES module!
Please pull the new commit and it should work fine now :).

@cdarken Mmm you are right, let me give it another shot, issue is if I remove module from package.json it messes with the CI. Let me give it another shot, I am just going to remove CI action for now, until I figure this out. The tree-sitter and its dependencies are all commonJS unfortunately... :/

Thanks for the fix - confirmed it's working now again 🙇


wallabag: 2.3.1 -> 2.3.2

Semi-automatic update. These checks were performed:

built on NixOS
found 2.3.2 with grep in /nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2

cc "@schneefux"

Success on x86_64-darwin (full log)
Partial log (click to expand)
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/doctrine/doctrine-cache-bundle/Tests/travis/install-deps.sh: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/doctrine/instantiator/.travis.install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/doctrine/migrations/build-phar.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/doctrine/orm/docs/bin/generate-docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/paragonie/random_compat/build-phar.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/sensio/distribution-bundle/Resources/bin/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/sensio/distribution-bundle/Resources/bin/build_demo.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2/vendor/symfony/symfony/src/Symfony/Component/Intl/Tests/Data/Bundle/Reader/Fixtures/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
/nix/store/ilgakbchs8rqy5kzybyj0hks5czb3syy-wallabag-2.3.2

Success on x86_64-linux (full log)
Partial log (click to expand)
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/doctrine/orm/docs/bin/generate-docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/doctrine/doctrine-cache-bundle/Tests/travis/install-deps.sh: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/doctrine/migrations/build-phar.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/doctrine/instantiator/.travis.install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/paragonie/random_compat/build-phar.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/sensio/distribution-bundle/Resources/bin/build_demo.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/sensio/distribution-bundle/Resources/bin/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2/vendor/symfony/symfony/src/Symfony/Component/Intl/Tests/Data/Bundle/Reader/Fixtures/build.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-wallabag-2.3.2.drv-0 in /nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2...
/nix/store/m39kk8d2vibl17jm2zsbvscx9giyinjv-wallabag-2.3.2

Success on aarch64-linux (full log)
Partial log (click to expand)
these paths will be fetched (33.35 MiB download, 108.10 MiB unpacked):
  /nix/store/z68r2mv1q9alzy6v0185wkvg4f3f0r0y-wallabag-2.3.2
copying path '/nix/store/z68r2mv1q9alzy6v0185wkvg4f3f0r0y-wallabag-2.3.2' from 'https://cache.nixos.org'...
/nix/store/z68r2mv1q9alzy6v0185wkvg4f3f0r0y-wallabag-2.3.2


error following this tutorial

I followed the tutorial and when i try to execute the cell below is the error i am getting
Current State: INITIALIZING
Thread State: RUNNABLE
at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:307)
at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:201)
Caused by: java.lang.AbstractMethodError
at org.apache.spark.internal.Logging$class.initializeLogIfNecessary(Logging.scala:99)
at org.apache.spark.eventhubs.EventHubsConf.initializeLogIfNecessary(EventHubsConf.scala:47)
at org.apache.spark.internal.Logging$class.log(Logging.scala:46)
at org.apache.spark.eventhubs.EventHubsConf.log(EventHubsConf.scala:47)
at org.apache.spark.internal.Logging$class.logWarning(Logging.scala:66)
at org.apache.spark.eventhubs.EventHubsConf.logWarning(EventHubsConf.scala:47)
at org.apache.spark.eventhubs.EventHubsConf.set(EventHubsConf.scala:66)
at org.apache.spark.eventhubs.EventHubsConf$$anonfun$toConf$2.apply(EventHubsConf.scala:395)
at org.apache.spark.eventhubs.EventHubsConf$$anonfun$toConf$2.apply(EventHubsConf.scala:395)
at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:733)
at scala.collection.Iterator$class.foreach(Iterator.scala:893)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1336)
at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
at org.apache.spark.sql.catalyst.util.CaseInsensitiveMap.foreach(CaseInsensitiveMap.scala:28)
at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:732)
at org.apache.spark.eventhubs.EventHubsConf$.toConf(EventHubsConf.scala:395)
at org.apache.spark.sql.eventhubs.EventHubsSource.(EventHubsSource.scala:54)
at org.apache.spark.sql.eventhubs.EventHubsSourceProvider.createSource(EventHubsSourceProvider.scala:66)
at org.apache.spark.sql.execution.datasources.DataSource.createSource(DataSource.scala:286)
at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$1$$anonfun$applyOrElse$1.apply(MicroBatchExecution.scala:80)
at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$1$$anonfun$applyOrElse$1.apply(MicroBatchExecution.scala:77)
at scala.collection.mutable.MapLike$class.getOrElseUpdate(MapLike.scala:194)
at scala.collection.mutable.AbstractMap.getOrElseUpdate(Map.scala:80)
at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$1.applyOrElse(MicroBatchExecution.scala:77)
at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$1.applyOrElse(MicroBatchExecution.scala:75)
at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$2.apply(TreeNode.scala:288)
at org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$2.apply(TreeNode.scala:288)
at org.apache.spark.sql.catalyst.trees.CurrentOrigin$.withOrigin(TreeNode.scala:77)
at org.apache.spark.sql.catalyst.trees.TreeNode.transformDown(TreeNode.scala:287)
at org.apache.spark.sql.catalyst.trees.TreeNode.transform(TreeNode.scala:277)
at org.apache.spark.sql.execution.streaming.MicroBatchExecution.logicalPlan$lzycompute(MicroBatchExecution.scala:75)
at org.apache.spark.sql.execution.streaming.MicroBatchExecution.logicalPlan(MicroBatchExecution.scala:61)
at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:277)
at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:201)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4137b0cc-898b-b25c-6321-fe98f22f803d
Version Independent ID: 4ec1e187-7e69-e5da-b6dd-cb03b6db9366
Content: Tutorial: Stream data into Azure Databricks using Event Hubs
Content Source: articles/azure-databricks/databricks-stream-from-eventhubs.md
Service: azure-databricks
Product: unspecified
GitHub Login: @lenadroid
Microsoft Alias: alehall

@cfarre Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

is there any other sample/tutorial that we can follow? we have a spark / iot hub project that we need to ramp up with. currently there is no guidance for us

@cfarre hi, I haven't seen this error. Try detaching and reattaching a notebook to the cluster?
Could you also add more details:

What steps have you performed before the error occurred?
Are you using the Databricks 4.0?
Have you imported all the libraries?
What code are you trying to execute?

we are using databricks 4.0
we have imported all the libraries
below is the code. it fails here
incomingStream.writeStream.outputMode("append").format("console").option("truncate", false).start().awaitTermination(
import org.apache.spark.eventhubs._
// Build connection string with the above information
val connectionString = ConnectionStringBuilder("<EVENT HUBS CONNECTION STRING>")
  .setEventHubName("<EVENT HUB NAME>")
  .build

val customEventhubParameters =
  EventHubsConf(connectionString)
  .setMaxEventsPerTrigger(5)

val incomingStream = spark.readStream.format("eventhubs").options(customEventhubParameters.toMap).load()

incomingStream.printSchema

// Sending the incoming stream into the console.
// Data comes in batches!
incomingStream.writeStream.outputMode("append").format("console").option("truncate", false).start().awaitTermination(

Everything looks right.
If after cluster restart and re-attach of the notebook there's still an error, and if the connection string/hub name is correct for the Event Hubs, I'd recommend creating a support ticket in Azure Portal to look further into what exactly is happening in Spark.

do you have pointers to more code snippets?
after i get the messages with below code how can i display them to check if they are correct or dump them in a table?
val messages = incomingStream.selectExpr("cast (body as string) AS Content")
Modified code
val incomingStream = spark.readStream
.format("eventhubs")
.options(eventHubsConf.toMap)
.load()
eventhubs.printSchema
val messages = incomingStream.selectExpr("cast (body as string) AS Content")

Here are some more examples: https://docs.databricks.com/spark/latest/structured-streaming/streaming-event-hubs.html

Doc says use Spark Event Hubs connector - com.microsoft.azure:azure-eventhubs-spark_2.11:2.3.1 but very next picture shows com.microsoft.azure:azure-eventhubs-spark_2.11:2.3.0. If I use *:2.3.0 I am getting same error as mentioned above. If use *:2.3.1 then I am getting below error
notebook:1: error: object eventhubs is not a member of package org.apache.spark
import org.apache.spark.eventhubs._
^
notebook:4: error: not found: value ConnectionStringBuilder
val connectionString = ConnectionStringBuilder("Endpoint=sb://iothub-ns-XXXXXX-XXXX-1XXXXXXXXXX.servicebus.windows.net/;SharedAccessKeyName=iothubowner;SharedAccessKey=XXXXXXXXXXXXXXXXX")
^
notebook:8: error: not found: value EventHubsConf
EventHubsConf(connectionString)
Will try another way but good to know the cause of it?

okay.. Reattach Notebook works...Any thoughts what happens behind the scene ?

Thanks @rawatsudhir1. I believe 2.3.1 is the right one.
You are getting "not found: value EventHubsConf" because after you add libraries to the cluster, notebook can't pick that up immediately until you re-attach it.
If you've created a cluster, then added all the libraries, and only then created a new notebook - it would have all the correct libraries already assigned correctly, and you won't have to re-attach.
Re-attach helps if there're changes in libraries you add/remove. I believe with removal of libraries you sometimes have to reload the cluster for it to take effect.
Hope this helps.

@cfarre We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

@rawatsudhir1 Hi There. Spark structured streaming API . can we connect to Azure Service Bus queues not the EVntHub?


ilike filter

Motivation
ilike filters are used commonly to do basic case insensitive search.

Proposed Solutions
add ilike filter behind a feature gate for supported databases to column expressions

Current Workarounds
adding lower on both the term and the parameter #672

This already exists: https://docs.rs/sea-query/latest/sea_query/extension/postgres/trait.PgExpr.html#method.ilike

oh I am so sorry. I think my local version did not had the feature enabled.


Improve offline support

I use a prepaid phone and no data. It does not appear this app supports creating tracks and photos without data. I would like to be able to contribute through Wifi when my trip is complete.

Hi @JesseKPhillips , the app should definitely be able to record offline. I recently came back from a trip outside my country and that was how I recorded, then upload on the Wi-Fi. Are you using iOS or Android? When you say it's not creating tracks what do you see exactly in the app?
Thanks!

Maybe he's confusing viewing the map as blank as not being able to record?

Hi, I'm using the Android app. It looks like this isn't related to being offline and instead it isn't working with my phone. The problem I'm seeing starts when I click the record button from the camera view. During record it presents a black screen with a minimap, as I drive the black screen will "flash" and a blue mark added to the map. During the entire trip none of the stats change (photo count, track distance, etc). Thank you for your time.


Add PyCharm

PyCharm (A Python IDE): https://www.jetbrains.com/pycharm/
Add PyCharm into the global gitignores directory.

Thanks, but we're using Global/JetBrains.gitiginore to track the rules for all their IDEs.
We also refreshed it recently in #1475 to reflect the official documentation.


Getting an error string 1-4 required

Getting error that booking didn't got through string 1-4 required.

One of the beneficiaries mgiht be registered on multiple phone numbers.


error 403 in my own cors-anywhere server

hi
i have an issue with google
in my own cors-anywhere server at centos 8 i see this error :(
"
google sorry
We're sorry...
... but your computer or network may be sending automated queries. To protect our users, we can't process your request right now.
"
please help me

can i clear coockies?
or cache?
this issue not resolved when i restart server and all services!


Delete gw with its deployment

Description
list all domains on all available interfaces
Changes
add getDeploymentIps that returns an array of all ips on the contract
Related Issues

#3485

Tested Scenarios
added a 5 gw on the different network interfaces and delete the deployement

Checklist

[ ] Tests included
[X] Build pass
[ ] Documentation
[X] Code format and docstrings
[ ] Screenshots/Video attached (needed for UI changes)

please resolve conflicts

will open another pr to make sure no conflicts


[Snyk] Security upgrade echarts from 5.5.0 to 5.5.1

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Cross-site Scripting (XSS) SNYK-JS-ECHARTS-7300340
  576

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)

Closing as already have a PR open for this fix


Log Analytics workspace deletion improvements

mention that workspaces must exist to be purged
mention that to recover a workspace the resource group must exist
add reference to Get-AzOperationalInsightsDeletedWorkspace
removing misleading statement about a warning
some minor whitespace fixes

related:  azure/azure-powershell#12841, azure/azure-powershell#12862

@fowl2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@fowl2 The markdownlint config file that some Microsoft Docs repos use, and which is available in Visual Studio Code, specifies/requires a blank line before and after headings. See https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md022.

Could you resubmit a PR that doesn't include deleting blank lines after all headings? Thanks. We'll close this PR.

@fowl2 We can keep this PR open for author @bwren to review your other suggested revisions. I can edit the file to back out the blank line deletions before merging if the PR is approved. Thanks!

I'm editing from the GitHub web UI so don't have the benefit of that linter and the file was inconsistent to start with.  Anyway, I've added back in the lines.

@fowl2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@fowl2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bwren Could you review this pull request? Thanks!

tagging @bwren - can you take a look?  thanks.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MGoedtel @bwren @rboucher @DavidCBerry13 - Would one of you be able to review this community contribution from September 2020 or recommend a Microsoft SME who can? Thanks.

@MGoedtel @bwren @rboucher @DavidCBerry13 - Would one of you be able to review this community contribution from September 2020 or recommend a Microsoft SME who can? Thanks.

Changes are fine for the most part. A few comments:

Header should remain: "Permanent workspace delete" as purge has different connotation in Log Analytics.
Use "permanently deleted and not purged. Also a comma is missing in "Note": Any workspace that has already been soft-deleted, must be recovered before it can be permanently deleted.
In PowerShell section:

This should move to the top: PS C:>Select-AzSubscription "subscription-name-the-workspace-was-in"

@yossi-y Thanks for the review.
@fowl2 The product team has provided feedback on your pull request for when you have a chance to take a look and make updates. Thanks.

Changes are fine for the most part. A few comments:

Header should remain: "Permanent workspace delete" as purge has different connotation in Log Analytics.
Use "permanently deleted and not purged. Also a comma is missing in "Note": Any workspace that has already been soft-deleted, must be recovered before it can be permanently deleted.
In PowerShell section:

This should move to the top: PS C:>Select-AzSubscription "subscription-name-the-workspace-was-in"

@yossi-y Thanks for the review.
@fowl2 The product team has provided feedback on your pull request for when you have a chance to take a look and make updates. Thanks.

Review comments addressed, except for adding a comma to the note, which I don't believe is correct.

Hi @fowl2 - Unfortunately, the article you propose updating has been moved, so the pull request can't be merged in. Would you submit the update in a new pull request? Sorry for the extra step and thanks for your contribution. We'll close this pull request.


Breaks fonts in data urls

Ref: https://github.com/ben-eb/gulp-cssnano/issues/3
data:application should be skipped as well as data:image.

Released as 2.0.3.


Add missing call to batch.begin() in example.

@sorced-jim Thanks for the patch!  ISTM that a better fix for that example would be to show using the batch as a context manager, e.g.:
       >>> from google.cloud import datastore
       >>> client = datastore.Client()
       >>> with client.batch() as batch:
       ...     batch.put(entity1)
       ...     batch.put(entity2)
       ...     batch.delete(key3)

Can you adjust and re-push after signing the CLA?

Closing this due to lack of CLA.
We appreciate your contribution, @sorced-jim, but we can't review or merge without a CLA. If you do sign the CLA please feel free to let us know and we'll re-open.


Add documentation, Docstrings, References

@blackrosedragon2
You can take the reference format from here.
https://github.com/cjlovering/predicting-inductive-biases/blob/f97038502fcbb6129e33460a54a972ff2bc56ce5/main.py#L382
You can take the Docstring and Function Header Format from here
https://github.com/SforAiDl/decepticonlp/blob/master/decepticonlp/metrics/char_metrics.py


Allow running Background once per feature

Right now, as per typical Gherkin standards, a Background section is run once for every Scenario.
Although understandable, this really breaks down when running complex integration tests with expensive setup.
If we know all the Scenarios in a Feature file are just read-only (e.g. testing GET commands of a REST API), then tearing down and setting it all up again between every scenario adds significant execution time.
This is especially evident on Scenario Outlines / Examples (e.g. when sending different variations of an invalid JSON payload to a REST API to ensure input validation tests). Having to setup/teardown between every execution Scenario Outline is painfully inefficient.
Please consider some way to allow running a Background only once per feature.
Maybe new heading "Feature Background:" (vs just "Background")...that would be easiest.
This would make a world of difference for shops like ours that have complex integration test suites for REST APIs in microservices. Really, a WORLD of difference.
This is the biggest single complaint I hear about Cucumber from every single developer on my team.
Thank you in advance.

You can make sure a step definition's body is run only once like this:
import io.cucumber.java.api.en.Given;

public class MyStepdefs {
    private static boolean somethingExpensiveDone = false;

    @Given("something expensive")
    public void somethingExpensive() throws InterruptedException {
        if(!somethingExpensiveDone) {
            somethingExpensiveDone = true;
            doSomethingExpensive();
        }
    }

    private void doSomethingExpensive() throws InterruptedException {
        Thread.sleep(3000);
    }
}

Would that work for you @jacek99?

@aslakhellesoy unfortunately, that would be totally insufficient. We have complex setups that involve 10-15 entities (and multiple REST calls) to set up base data for some test condition (common requirement in a multi-tenant application where most configuration & data is different from one customer to another).
I've seen one very complex BDD where the Background section is 300 lines.
And then multiple Scenarios that test various queries against that setup.
So a single "something expensive" step is really not a good solution here, unfortunately.
"Feature Background"" or "Setup:" is really what we need....

Could you please explain what's insufficient with the workaround I posted?

I've seen one very complex BDD where the Background section is 300 lines.

This is not what Cucumber is designed for. It's not a testing tool, it's a communication tool, and 300 lines is too long for communication. See https://cucumber.ghost.io/blog/the-worlds-most-misunderstood-collaboration-tool/

@aslakhellesoy the setup varies from one Feature file to another, we'd have to write a Given "something expensive" step separately fro every such complex Feature and it would hide what sort of data was set up for the Scenario.
Cucumber is a testing too. I am sorry...I totally disagree with your comment. I have used it for testing AND communication for over 10 years now, across 3 different language implementations.

You can call it whatever you want, but it doesn't change the fact that I designed Cucumber to be a tool for simple, readable executable specifications with slow, heavy setup, used in a "test-after" context (as opposed to "test-first".
We won't be adding this feature, but I have created a new ticket to collect various extensions people are requesting: https://github.com/cucumber/cucumber/issues/595
When/if such an extension API is implemented, you should be able to implement a custom extension yourself.
Sorry I can't be of more help.

I regret you closing this. We're a heavy Cucumber user and it has been great for us. We are pushing the envelope on using Cucumber for REST microservice integration tests...for complex, multi-tenant applications with complex data conditions.
I've had the exact same requirement in all of my last 4 jobs when using Cucumber and we struggled with it every time.

It conflicts with the overall philosophy of Cucumber. As the lead of this project I need to be conservative about what goes into the tool.
I believe that adding this is encouraging people to use Cucumber differently from what I believe is good practice. That's my prerogative.

I respect that.
But also ask you to consider understanding that it may be very usable in other scenarios, very different than its initial design.
I'd go with Cucumber over writing integration tests in Java/JUnit any time of the week. Massive improvement in every aspect.

Yes, I understand that. The thing is, there is over a million people using Cucumber, and only half a dozen people maintaining it on a regular basis (in their spare time, unpaid).
If you want this feature, you'll have to implement it yourself. Because it's something I don't think should be part of the official release, I want to provide an API where you can plug it in.
I can't promise when/if this extension API will be available, but I'd be happy to guide anyone who volunteers to build it.

If I might add my thoughts here...
From a purely semantic perspective, a Background clearly applies to every use case in a feature. Execution-wise, however, both interpreting it to only happen once per feature or interpreting it to happen once per use case are perfectly reasonable approaches. As it happened, Cucumber went with the 'once per use case' implementation. So @jacek99 wanting a way to use the alternative interpretation is not unreasonable.
But @aslakhellesoy is also perfectly justified in his concerns about the motivation for this alternate implementation. Gherkin is a communication tool that facilitates easy to understand specifications. Cucumber is a (for lack of a better term) 'testing tool' that allows those specifications to be executed. We all love executable specifications, right?
Conflict like I am seeing in this thread seems to come from the fact that a big portion of the user base (okay, let's be honest, the majority) focusing on the executable half of 'executable specification' while the designers often focus on the specification half. But we can be both. Backgrounds that can either be 'once per feature' or 'once per use case' is a legitimate goal*. The question is how to get there. It can be done today (as demonstrated by @aslakhellesoy 's example code) but are there other ways? Ways that might facilitate both 'specification' and 'execution'. Let's resolve that question, if we can.
TLDR: Feel free to continue debating on the best way to achieve an alternate implementation of Background (new keyword, flags in step defs or hooks, etc.) but, please, actually have that debate.
*I'm going to assume that the feature is otherwise a good feature. Yes, users can mis-use Gherkin and have a 300 step Background but they will do that whether or not that background runs once or many times. Let's not throw the baby out with the bathwater.

Additionally: Because a Background is just as meaningful to the reader whether it is executed once per feature or once per use case, instead of adding a new keyword or having to do step def/hook magic, perhaps we could simply have a command line flag that controls which in which mode backgrounds run?
--repeat-background and --no-repeat-background?

@enkessler not a good option, since this varies by Feature. We have simple feature files where the current Background functionality is perfect, as the subsequent Scenarios mutate the state...so tearing down/up is required.
I would say only 10-15% of our BDDs have such a heavy set up time that we need this "run background once per feature"...but those BDDs account for most of the test suite execution time ....


Package on npm does not contain the code from repository

Package that is available on npm is missing some lines in the lib/clients/rtm/client.js, particularly the updateMessage function. Here is the diff of the file from the npm package and file from your github repository.
diff lib/clients/rtm/client.js lib-github/clients/rtm/client.js

33a34
> var ChatFacet = require('../web/facets').ChatFacet;
208a210,216
>
>   /**
>    * Allows access to some chat functions
>    * @type {ChatFacet}
>    * @private
>    */
>   this._chat = new ChatFacet(bind(this._makeAPICall, this));
630a639,647
> /**
>  * Helper for updating a sent message via the 'chat.update' API call
>  * @param message {object} message The message object to be updated,
>  * see /lib/clients/web/facets/chat.js for more details
>  * @param {Function=} optCb Optional callback
>  */
> RTMClient.prototype.updateMessage = function updateMessage(message, optCb) {
>   return this._chat.update(message.ts, message.channel, message.text, message.opts, optCb);
> };

Howdy. That's simply because I hadn't released those changes yet. I have a couple of bugs I'm looking at first, and I'll try to get a release out today or Monday.


[WIP] RHIDP-2065: [QE] Automate Scenario - Telemetry

Description
Add tests that verify analytics-provider-segment is enabled by default and that it can be disabled by configuration.
Which issue(s) does this PR fix

Fixes RHIDP-2065

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] E2E Tests are updated and passing

How to test changes / Special notes to the reviewer

/test e2e-tests

/test e2e-tests

/retest

/retest

/retest

/test e2e-tests

/lgtm

/cherry-pick 1.2.x

/cherry-pick 1.2.x


Using Rolldown with Vite v6

Description
Applied changes from #24 and #27 to the main branch after the environment API PR is merged.
Also fixed errors on Windows and cleaned up some unneeded changes.
#24 implemented build-time dep optimization partially, but I didn't include that change in this PR.
e2e test status

Playground Name
Dev
Build
Reasons

alias
✅
✅

assets
✅
✅
note: watch mode tests are skipped

assets-sanitize
✅
✅

backend-integration
✅
❌
https://github.com/rolldown/rolldown/issues/1842#issuecomment-2296345255

build-old
✅
✅
-

cli
✅
✅
-

cli-module
✅
✅
-

config
✅
✅
-

csp
✅
✅
-

css
✅
✅
-

css-codesplit
✅
❌
manualChunks

css-codesplit-cjs
✅
✅
-

css-dynamic-import
✅
❌
https://github.com/rolldown/rolldown/issues/1842

css-lightningcss
✅
✅
-

css-lightningcss-proxy
✅
✅
-

css-no-codesplit
✅
✅
-

css-sourcemap
✅
✅
-

data-uri
✅
✅
-

define
✅
✅
-

dynamic-import
✅
❌
https://github.com/rolldown/rolldown/issues/1842, https://github.com/rolldown/rolldown/issues/1843

dynamic-import-inline
-
✅

env
✅
✅
-

env-nested
✅
✅
-

extensions
✅
✅
-

external
✅
❌
https://github.com/rolldown/rolldown/issues/2041

fs-serve
✅
✅
-

glob-import
✅
❌
remove empty CSS generate chunk https://github.com/rolldown/rolldown/issues/1842

hmr
✅
✅
-

hmr-root
✅
-
-

hmr-ssr
✅
✅
-

html
✅
✅
-

import-assertion
✅
✅
-

js-sourcemap
✅
❌
manualChunks

json
✅
✅
-

legacy
❌
❌
🟡pending support system format

lib
✅
❌
🟡pending support umd format

minify
-
✅
-

module-graph
✅
-
-

multiple-entrypoints
✅
✅
-

nested-deps
✅
✅
-

object-hooks
✅
❌
object hook sequential

optimize-deps
✅
❌
- the rolldown missing export always is error, but the rollup has error or warn level, ref https://github.com/rolldown/vite/pull/27/commits/bfc679efab9d3eb0ef3cee1611506518bcc33a23  -https://github.com/rolldown/rolldown/issues/2031  - using Array input generate name is not expected, the entry name will be like index~1.js

optimize-deps-no-discovery
✅
✅
-

optimize-missing-deps
✅
✅
-

preload
✅
✅
-

preserve-symlinks
✅
✅
-

proxy-bypass
✅
✅
-

proxy-hmr
✅
✅
-

resolve
✅
✅

resolve-config
-
✅

ssr
✅
✅
-

ssr-alias
✅
✅
-

ssr-conditions
✅
✅
-

ssr-deps
✅
✅
-

ssr-html
✅
✅
-

ssr-noexternal
✅
-
-

ssr-pug
✅
✅
-

ssr-resolve
-
✅
-

ssr-webworker
✅
✅

tailwind
✅
✅
-

tailwind-sourcemap
✅
✅
-

transform-plugin
✅
✅

tsconfig-json
✅
✅
-

tsconfig-json-load-error
✅
✅
-

wasm
✅
✅
-

worker
✅
❌
https://github.com/rolldown/rolldown/issues/1842

missing feature list that was supported by esbuild / rollup

watch mode (https://github.com/rolldown/rolldown/issues/2028)

options.watch
watcher.on('event', listener)
related hooks: shouldTransformCachedModule, watchChange, closeWatcher
this.addWatchFile

meta on module info: this can be workarounded as it's not part of the public API
umd format
system format
generating multiple formats in one build: output is currently an object instead of an array
options.attributes for resolveId hook
SourceMap type does not support toString and toUrl: not necessary but better for easier migration
resolveImportMeta hook: can use transform hook for Vite's usecase
options.preserveEntrySignatures: not necessary but nice for smaller bundles
cancelling the running build / scan (esbuild docs): since rolldown is fast, it's not important to have this feature, but would be nice to reduce energy consumption

improvements needed later on Vite side

convert optimizeDeps.esbuildOptions into optimizeDeps.rollupOptions automatically if possible
cache this: https://github.com/rolldown/vite/commit/bb8b41f215244254b81b63a580fc1ef0c6e77dac#diff-00039b783552b3f2a608918986716e01b1a71996da1a8ad5493a102a1e969d7bR659-R662

native plugin incompatibilities

alias: does not support customResolver option
transform: passes typescript experimental decorators as-is, does not read / use tsconfig.json

I expect this reproduction to either (a) fail with "legacy decorators are not supported" error or (b) read the tsconfig.json and transform legacy decorators.

json: does not support UTF-8 with BOM (reproduction)
import-glob: does not support ./**.js (** not ending with /) and does not work in many cases (reproduction)
data-uri: does not support spaces after , (reproduction)

also the load fallback plugin need to skip data uri like the non-native one (0097b1550baec8e8307f6ade4bfdeaf573fec12a)

manifest: cannot use data on Vite side (e.g. css/assets) and needs to be environment-specific

I cannot make a simple reproduction for this one. If you only enable the native manifest plugin and run build in playground/backend-integration, you can see the manifest not containing css and assets field in index.html.

load-fallback: when it fails to load, the plugin errors, but it should fallback to id with query instead (reproduction)
resolve

does not run .replaceAll('\\', '/') on the resolved id (reproduction [windows only])
does not support https://github.com/vitejs/vite/issues/3040, probably oxc-resolver does not support this case (reproduction)
does not support https://github.com/vitejs/vite/pull/12786
does not support https://github.com/sapphi-red/package-json-browser-tests#:~:text=entry.js%3A
  require('pkg')
node_modules/pkg/package.json%3A
  { "main"%3A "main.js"%2C "browser"%3A { "./dir/index.js"%3A "./file" } }
node_modules/pkg/main.js%3A
  require('./dir')
node_modules/pkg/file.js%3A
  input.works %3D true

TODO list for me

[ ] check esbuild / rolldown difference around this part: https://github.com/rolldown/vite/commit/bb8b41f215244254b81b63a580fc1ef0c6e77dac#diff-456b3c61f2f19b160b6a5016cb9a180500c4e3b3a9a41a192ca24670637e7706L766-R807
[ ] think about what to do with commonjsOptions
[ ] think about how to make chunk metadata work: https://github.com/rolldown/vite/commit/2b6769097a386322cb442c412b703e7d8c64e5d2#diff-2ff9d6929734c74a7dc8a2043c2f5455f57c18d36940b024ad45b8c0a01d4aaaR5-R33
[x] check crash reason: https://github.com/rolldown/vite/actions/runs/10826081396/job/30036319615?pr=43#step:9:26

it was because the document contained hand written !~{003}~ https://github.com/vitejs/vite/blob/main/docs/guide/backend-integration.md#:~:text="_shared-!~{003}~.js"%3A {

[ ] pass env specific value to nativeBuildImportAnalysisPlugin option: https://github.com/rolldown/vite/pull/43/commits/f92519b0942898681950ac15b39ccd4879327e26#diff-121079017d1fa98d6a0ea3354d5c73df45ab277078228cd7384c7a4e84c5a813R182
[x] support this.environment in options hook: d1f1aafddb0a2bc0eacea93e808905b5ceb4b701

FYI, alias: does not support customResolver option
this is by design, if use  customResolver in native plugin, there is no performance difference between js Alias and rust alias, since you always need to perform a tsfn, and make plugin execute single threaded

for all native plugin incompatibilities section, could you give a more specific testcase?

@IWANABETHATGUY I've made reproductions for the cases other than resolve plugin related ones. (I'm going to make for the resolve related ones now.)

I fixed the import-meta glob reproduction, it was using import.meta.dirname but wasn't supported by stackblitz yet.

I fixed the import-meta glob reproduction; it was using import.meta.dirname but wasn't supported by stackblitz yet.

Can you file these issues on rolldown

Made the reproductions for resolve related ones.

Can you file these issues on rolldown?

Did you mean to quote https://github.com/rolldown/vite/pull/43#issuecomment-2370297757 instead of https://github.com/rolldown/vite/pull/43#issuecomment-2370416926, right?

Made the reproductions for resolve related ones.

Can you file these issues on rolldown?

Did you mean to quote #43 (comment) instead of #43 (comment), right?

Sorry, yeah I mean https://github.com/rolldown/vite/pull/43#issuecomment-2370297757

Done 👍
I didn't make an issue for "manifest: cannot use data on Vite side (e.g. css/assets) and needs to be environment-specific" and "does not support https://github.com/vitejs/vite/pull/12786 (reproduction, expected to have console.log preserved in the output)" for now as I'm not sure what the next step is and the issue will be opaque / unactionable.

Maybe we should squash it instead of merge

Yeah. I always forget it...


Project/aot trimming/building

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

1108 of 2115 (52.39%)  changed or added relevant lines in 59 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-9.8%) to 78.057%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sly/parser/generator/ParserBuilder.cs
22
23
95.65%

src/sly/parser/parser/llparser/bnf/RecursiveDescentSyntaxParser.cs
11
12
91.67%

src/sly/parser/parser/llparser/ebnf/EBNFRecursiveDescentSyntaxParserStarter.cs
5
6
83.33%

src/sly/parser/syntax/grammar/ClauseSequence.cs
3
4
75.0%

src/sly/parser/syntax/grammar/GroupClause.cs
5
6
83.33%

src/sly/parser/syntax/grammar/OneOrMoreClause.cs
1
2
50.0%

src/sly/parser/syntax/grammar/TerminalClause.cs
4
5
80.0%

src/sly/parser/syntax/grammar/ZeroOrMoreClause.cs
1
2
50.0%

src/sly/parser/generator/RuleParser.cs
26
28
92.86%

src/sly/parser/parser/llparser/ebnf/EBNFRecursiveDescentSyntaxParser.Option.cs
12
14
85.71%

Totals

Change from base Build<PHONE_NUMBER>5:
-9.8%

Covered Lines:
7030

Relevant Lines:
8755

💛  - Coveralls


Updates to tokenlist.schema.json

This pull request changes the tokenlist.schema.json to match the schema of the example: https://raw.githubusercontent.com/SYNC-Network/collection-lists/main/test/schema/example.tokenlist.json.

@jl-chain I need to use the GitHub reference to this file, can you please merge this PR? Thank you!

Got it


Remove unnecessary disabled trace func

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.11%. Comparing base (70980f8) to head (7cbab5a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (70980f8) and HEAD (7cbab5a). Click for more details.
HEAD has 18 uploads less than BASE

Flag
BASE (70980f8)
HEAD (7cbab5a)

19
1

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #500      +/-   ##
===========================================
- Coverage   100.00%   94.11%   -5.89%
===========================================
  Files           20       20
  Lines         2311     2311
===========================================
- Hits          2311     2175     -136
- Misses           0      136     +136

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


better e2e dfp testing

as discussed on E-M we should

insert into the dns cache localhost:80/localhost:443 and send requests sans ports and
change the E-M sample apps to send multiple requests

Bah, 1) doesn't work because we create the resolved address with the host's port.
[dns_cache_impl.cc:319] main thread resolve complete for host 'localhost:443': [<IP_ADDRESS>:39601] <-- cached port
[dns_cache_impl.cc:393] host 'localhost:443' address has changed from  to <IP_ADDRESS>:443  <-- cluster's port
probably safe to change but higher risk than reward


about the field 'dyna_id' in the result file xx.dyna

Hi, thanks for the incredible work. It seems the expected field was missing during the transform process.
Describe the bug

The field 'dyna_id' in the result file xx.dyna generated by foursquare.py was None.
ref. code: https://github.com/LibCity/Bigscity-LibCity-Datasets/blob/145f66256a9cc056826abe06d33d8d0e13c926cf/foursquare.py#L63
Code to Reproduce
https://github.com/LibCity/Bigscity-LibCity-Datasets/blob/145f66256a9cc056826abe06d33d8d0e13c926cf/foursquare.py

Expected behavior

dyna_id should be clarified in dyna['dyna_id'] = dyna.index or other ways.
Actual result

output file (sample):

dyna_id,type,time,entity_id,location
,trajectory,2012-04-03T14:00:09Z,0,2388
,trajectory,2012-04-04T14:00:09Z,0,2388
...

Versions

Windows-10-10.0.19043-SP0
Python 3.8.12 (default, Oct 12 2021, 03:01:40) [MSC v.1916 64 bit (AMD64)]

@WenMellors

Thanks for your comment. The bug is just as you said, and we fix it now.


Tests looking for files that do not exist

When I build and run ctest, most of the tests fail because they're looking for the wrong files. Evidently they're looking for files like "example/linear-algebra/Tines_Gemm.ptr.x", but what's available is Tines_Gemm.ptr.single.x and Tines_Gemm.ptr.double.x. I modified src/unit-test/Tines_Test_Driver.cpp to have it look for the single and double files where appropriate, but there are some other tests failing due to missing files.
Could you advise if I'm building improperly or if the tests need to be fixed?

@kevinholst Oh.... I am sorry that I check this issue late. You probably build correctly and the testing seems to be outdated. I will fix that soon.


Upstream openmina changes

@dannywillems This contains the diffs we use for openmina
Merging this will allow us to depend directly on your master branch, without having to maintain our own fork
cc @adonagy @binier , some commits belongs to you

Just removed https://github.com/o1-labs/proof-systems/commit/dde0cdda6d24473c0e4737b8a30a21cc924ff3cc from the PR.
Now waiting on:

https://github.com/o1-labs/proof-systems/pull/2755 to be merged, to remove https://github.com/o1-labs/proof-systems/commit/63255e9bca0d219f6fb221f5464f03dd3675ee7b.
https://github.com/o1-labs/proof-systems/pull/2750#discussion_r1837928155


Possible codegen error for overloaded operator with a primitive type as first arg

static member (*)(a,v:Vector) = Vector(a*v.x, a*v.y) produces wrong code
repro code
type Vector(x:float,y:float) =
  member this.x = x
  member this.y = y
  //static member inline (+)(v1:Vector,v2:Vector) = Vector(v1.x+v2.x,v1.y+v2.y)
  static member (*)(v:Vector,a) = Vector(a*v.x, a*v.y)
  static member (*)(a,v:Vector) = Vector(a*v.x, a*v.y)

let a = Vector(1.0,2.0)
let b = Vector(2.0,1.0)
let v1 = 2. * a;
let v2 = b * 3.;

printf "%A" v1
printf "%A" v2

generates the wrong code for v1
  var Vector = exports.Vector = function () {
    function Vector(x, y) {
      _classCallCheck(this, Vector);

      this["x@6"] = x;
      this["y@6"] = y;
    }

    _createClass(Vector, [{
      key: "x",
      get: function () {
        return this["x@6"];
      }
    }, {
      key: "y",
      get: function () {
        return this["y@6"];
      }
    }], [{
      key: "op_Multiply",
      value: function op_Multiply(v, a) {
        return new Vector(a * v.x, a * v.y);
      }
    }, {
      key: "op_Multiply_1",
      value: function op_Multiply_1(a, v) {
        return new Vector(a * v.x, a * v.y);
      }
    }]);

    return Vector;
  }();

  _fableCore.Util.setInterfaces(Vector.prototype, [], "App.Vector");

  var a = exports.a = new Vector(1, 2);
  var b = exports.b = new Vector(2, 1);
  var v1 = exports.v1 = 2 * a;
  var v2 = exports.v2 = Vector.op_Multiply(b, 3);

resulting in nulls.
printf "%A" v1
printf "%A" v2

null
app.fsx:23 {"x@6":6,"y@6":3}

Expected:
Correct code or warning if this is not yet supported.

For custom operators I was just checking the first argument in the naive assumption it would always be the same as the second one :/ This must be fixed, thanks for the report!

Unfortunately this has proven to be trickier than I expected. Checking the type where the operator is coming from is difficult when it's not the same as the first operand. Also, in your example there are two implementations for * and overload resolution for custom operators is problematic as well in Fable's current state 😞
For now, I'm just disallowing this behaviour and throwing a compile type error message, so the user knows what must be fixed. I hope that's ok but please tell me otherwise.

Thanks to modifications of Fable AST in the latest version, now it's possible to use overloaded custom operators! 🎉 It's also OK to put the type holding the operator as second argument. Can you please give it a try with fable-compiler/fable-core 0.5.1 and check if it works for you? Thanks!


Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor

ManifestEvaluator was implemented in https://github.com/apache/iceberg-rust/pull/322 whereas some functions are set to todo.

@Fokko, can you please assign this to me? @sdd, would it be okay if I work on this?

Please do! That would be great 😁

@s-akhtar-baig Assigned, thanks!

@s-akhtar-baig
are you still working on this? If you like I could try to help you out here?

Thanks @marvinlanhenke, but I have made good progress on the task and will be creating a pull request in the next few days.

https://github.com/apache/iceberg-rust/pull/367 should close this issue. Most tests from pyiceberg have been implemented but some that are remaining will be covered in a follow-up PR.


[Geolocation] Expose option for distance filtering on location updates.

My original implementation involved creating a RCT_ENUM_CONVERTER with CLLocationAccuracy on iOS and a Hashmap on Android that would convert string values to doubles for distance filtering.
I got this to work just fine but realized that I made things more complicated than they needed to be and simplified everything by just have the option be a decimal value (in meters) that works both for iOS and Android.
The only thing i'm not sure about is if we can set arbitrary values for CLLocationManager's distance filter.
@nicklockwood  Any idea?

@christopherdro my understanding is that the distance filter is separate from the idea of "accuracy", but is instead related to minimum distance for a "change" in location to have occurred.  It seems that in this case, using an arbitrary double value should be just fine.

@lelandrichardson That's correct the idea of accuracy and distance are different.
Here is what docs say about distance filter.

The minimum distance (measured in meters) a device must move horizontally before an update event is generated.

It seems to me like using a double should work fine :+1:

+1 confirmed working

Upon further testing, I believe there is an edge case where on Android 0 is treated as no distance filter but on iOS actually does filter results (perhaps 0 -> infinity)
To make this more intuitive we could set 0 to kCLDistanceFilterNone

@rt2xx that makes sense to me.

@rt2zz Nice catch!
Entering 0 as an option would still default RCT_DEFAULT_LOCATION_ACCURACY since the conditional would still evaluate it as false.
This should now be working properly with the updated nested ternary operator.

Possible solution for #1240

@facebook-github-bot shipit

is distanceFilter working properly now.

yes


Is this gem still under active development?

The last commit was almost 9 months ago, and there are 26 open issues, many of which have no response, and some of which provide pull-requests that have not been incorporated.
Is there an alternative gem for handling IP addresses or does IPAddr make this one redundant?

@bluemonk Is there any updated release data for version 1.0?

Hi Manuel,
This is the to-do list before releasing 1.0, in order of importance (the
way I see it):

Fix #40 (and the broken summarization code)
Fix #49
Add support for hashes, ranges and sets
Migrate tests to rspec or at least minitest

The other PR's have been either patched or are in the process to. Mike is
helping me now and he's digging into those, so we'll probably release 0.9
before 1.0.
Thanks,
Marco
On Thu, Mar 19, 2015 at 10:47 PM, Manuel Rüger<EMAIL_ADDRESS>wrote:

@bluemonk https://github.com/bluemonk Is there any updated release data
for version 1.0?
—
Reply to this email directly or view it on GitHub
https://github.com/bluemonk/ipaddress/issues/47#issuecomment-83772105.


Add ifreddyrondon to Contributors list

@ifreddyrondon, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

Hi @Roshanjossey thank for merged the PR. This is my first PR into an open source project, I always wanted to contribute but when look for issues into projects I generally do not understand the issues very much, maybe this related to that I need to understand a little more the projects before contributing.
In this case the issue and the README with the tutorial was super clear and I was able to finish the whole process in no time. Thank you again.

@ifreddyrondon, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


Add Title Generator to Support Programmatic Titles

Discussed in https://github.com/pydantic/pydantic/discussions/4044

Originally posted by zkulis May  4, 2022
Background
Currently, Pydantic allows specifying a string literal for the title value used in the exported JSON Schema. For BaseModel, this is accomplished via the Config class:
from pydantic import BaseModel

class MyDataClass(BaseModel):
   class Config:
      title = "My Data Class"

For BaseModel fields, an explicit title string may be specified with a Field instance:
from pydantic import BaseModel, Field
from typing import List

class MyDataClass(BaseModel):
   matchCriteria: List[str] = Field(default_factory=list, title="Match Criteria")
   class Config:
      title = "My Data Class"

Feature Request
It would be beneficial if Pydantic provided a programmatic way to set the title value for both models and fields, similar to the functionality provided by alias_generator here. Specifically:

A title_generator class attribute in the Config class, and
A title_generator parameter in the Field constructor.

In both cases, the title_generator would take a Python callable that receives:

The BaseModel class name for the first case
The field alias for the second case

This is demonstrated below:
import re
from pydantic import BaseModel

def make_title(name: str):
   def _capitalize(v: str):
      return v[0].upper() + v[1:]
   return re.sub(r"(?<=[a-z])([A-Z])", r" \1", _capitalize(name))

class MyDataClass(BaseModel):
   matchCriteria: List[str] = Field(default_factory=list, title_generator=make_title)
   class Config:
      title_generator=make_title

The resulting JSON Schema would be:
import json
print(json.dumps(MyDataClass.schema(), indent=2))

{
  "title": "My Data Class",
  "type": "object",
  "properties": {
    "matchCriteria": {
      "title": "Match Criteria",
      "type": "array",
      "items": {
        "type": "string"
      }
    }
  }
}

I agree this is a good idea, should be fairly straightforward in v2.

I'll just repeat some of my comment from https://github.com/pydantic/pydantic/issues/1361:
I have no problems with this, but I think that we should give the model-config-key and field-info-key different names — rather than using title_generator for both, we should use class_title_generator or similar for BaseModels/dataclasses/etc., and field_title_generator for field titles, otherwise I think it will lead to confusion.
I'll also note that this will require some care around the use of something like field_title_priority with similar behavior to alias_priority, and perhaps similar for model_title_priority.

In v1 the following workaround seems to work:
class _Base(pydantic.BaseModel):
    class Config:
        @staticmethod
        def schema_extra(schema: dict[str, Any], model: type['_Base']) -> None:
            schema['title'] = f'{model.__module__}.{model.__name__}'

Thinking about this some more it's not actually the title I want to control over but the ID generated as the key in the components map. The title is just for human consumption, I want to preserve the model's module name in the generate OpenAPI spec so I can generate an OpenAPI client with a similar structure.

I guess it is closed with ConfigDict.title?

Is there any news for this title generation feature?
When creating model json schemas, the current default title generation often does not play nicely when using aliases or alias generators. Consider the following toy example:
from pydantic import BaseModel, ConfigDict
from pydantic.alias_generators import to_camel

class MyModel(BaseModel):
    my_field: str
    my_other_field: int

    model_config = ConfigDict(alias_generator=to_camel)

When calling MyModel.model_json_schema(), the fields are converted to camel case as expected, but the titles come back as Myfield and Myotherfield. My guess is that the title generation in pydantic.json_schema.GenerateJsonSchema.get_title_from_name assumes a certain naming style to generate sensible titles.
As a workaround I am currently using a custom GenerateJsonSchema class that overrides get_title_from_name, which is then passed to model_json_schema(schema_generator=...) to better suit my case.
Having a title generator on the model config would be a convenient solution to this problem. The definitions for both the alias generator and title generator would be closer to each other, and it is more obvious what kind of values the title generator should mostly expect.


Added Rect (rect_) properties to the c# migration table

While working on https://github.com/godotengine/godot/pull/70913, I found that the rect_/Rect migration was only added to the gdscript table (in https://github.com/godotengine/godot/pull/64396), but not to the C# table.
Now the rect_/Rect migration is in sync with the gscript table, except custom_minimum_size (is done in  https://github.com/godotengine/godot/pull/70913)

Thanks!


[BUG] Current published version isn't supported on build gradle 7.3+

Describe the bug
FAILURE: Build failed with an exception.

* What went wrong:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher.
The following dependencies do not satisfy the required version:
project ':flutter_background' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

To Reproduce
Using the following settings in the Android build.gradle:
buildscript {
    ext.kotlin_version = '1.7.10'
    repositories {
        google()
        mavenCentral()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:7.3.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

Expected behavior
Working builds.  It looks like the issue has already been addressed on the master branch and may just require a new release to pub.dev to resolve.
Screenshots
n/a
Smartphone:

n/a

Logs

```
```

[✓] Flutter (Channel stable, 3.3.6, on macOS 13.0 22A380 darwin-arm, locale en-US)
    • Flutter version 3.3.6 on channel stable at ...
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6928314d50 (7 days ago), 2022-10-25 16:34:41 -0400
    • Engine revision 3ad69d7be3
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at ...
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = ...
    • Java binary at: ...
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Android Studio (version 2021.3)
    • Android Studio at ...
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.72.2)
    • VS Code at ...
    • Flutter extension version 3.50.0

Hey @JulianAssmann, can you please have a look into this when you get time?

Hi @JulianAssmann Are you still maintaining this plugin? A lot of Flutter packages rely on this awesome package. We would be really glad if you could update this lib. Thank you

Hi @aytunch,
I currently do not own an Android device anymore. I'm trying to get my hands on one, but keep in mind I'm doing this for free and don't want to invest into hardware for the sole purpose of supporting this library.

@JulianAssmann I can confirm that the master branch does not have this issue, so this just needs a new release. I understand that you can't invest any money into hardware for testing, but this should already be tested, and is working :)

@JaffaKetchup I'm relying on your judgement and have released the current master branch to pub.dev. It would be great if you could confirm the current version is still working.
Thank you all for your contributions!

@JulianAssmann I'll report to the people waiting on this. Thanks :)


Plugin "pages " > "content" don't work.

Do not inject from content on "pages"

Can replicate. The editor is replaced for .txt but not for .htm files.


emitVerilog on the ChiselStage object

Type of issue: feature request

Impact: API addition (no impact on existing code)
emitVerilog on the ChiselStage companion object should generate a Verilog file (like the class function).
Furthermore, having the args in the object method would be nice too, as one most of the time wants to specify the target folder.

We did this intentionally but I totally agree that the inconsistency is confusing. When we switched things from Driver to ChiselStage we realized we didn't have any way of running Chisel and FIRRTL without writing files so we wanted an API to not write files. That being said, this wasn't the right way to do it.
So we should make them consistent as this issue says, and remember that the default case is writing files. ChiselStage being the name of the main entry point is a bit confusing on its own, perhaps we should add an object Chisel3?

I would propose to have then two methods: emitVerilog() to write a file (returning nothing, i.e., Unit) and getVerilog() returning just the string. Where to put it? Maybe on an object Chisel3? However, this is a method that does something with a (new) module. So logically it should be a method on Module.

I am trying to implement this. However, I am a bit confused about the splitting of Chisel code into src/main/..., which contains utilities and stage stuff and code that lives in core/src/main/.... I am not able, or don't know, how I can access code from src/main in core/src/main. The compiler simply tells me that chisel3.stage does not exist.
What is the reason for splitting the Chisel source into two folders? And why is the access only possible from one direction into the other?
Sorry for spamming this thread with basic Chisel development questions.

Sorry for spamming this thread with basic Chisel development questions.

No worries at all, this should be in a CONTRIBUTORS doc but alas.

What is the reason for splitting the Chisel source into two folders? And why is the access only possible from one direction into the other?

There are actually 4 projects in Chisel, as separate compilation units.

plugin is the compiler plugin, no internal dependencies
macros is most of the macros used in Chisel, no internal dependencies
core is the bulk of the source code of Chisel, depends on macros
src/main is sort of the "main" that brings it all together and includes util, depends on core

Other than the plugin, the reason there are 3 is a fundamental limitation in Scala that you cannot define and use macros in the same compilation unit. macros obviously implements some macros, but so does core (see CompileOptions).
One may wonder why the CompileOptions macros live in core instead of macros. In this case, we're taking advantage of the previously mentioned limitation--lots of Chisel APIs take an implicit CompileOptions (which is how we implement import chisel3._ vs. import Chisel._), the macro will materialize a default if none is provided. We found it very error prone to ensure we're propagating the user-provided CompileOptions rather than accidentally materializing them via the macro. By moving the macro implementation into core, we cannot screw this up any more; you'll get a compiler error if you don't propagate CompileOptions properly.
While it's not super clean cut, the basic dividing line between what belongs in core vs. src/main is that things that touch lots of APIs that are private to package chisel3 tend to live in core, while stuff that is either pure chisel (eg. util) or things that are mainly just code on top (like Stage) live in src/main.

Could we move stage.* into core? In that case we could simple call the relevant functions from RawModule.


Simplistic release test stub

Check for the following issues before releasing, detecting before packaging and publishing:

There must be a version description section in CHANGES.md
The version is not yet published, redundant with cargo publish but saves a bit of time

Nice! Merging.


Hi Im using react-native:0.73.6 after capturing photo or video if I try to close the view I have: FATAL EXCEPTION: mrousavy/VisionCamera.main 💭

Question
this is the error thrown from android logcat

do you have a patch for this?
What I tried
No response
VisionCamera Version
3.9.1
Additional information

[X] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Enable photo={true}.

Or video={true}


Fix exception when reading ORC char type data

An error occurs when reading data of the ORC char type:
presto:velox> select * from char_test_v1;

Query 20231030_074827_00003_6dk3r, FAILED, 1 node
Splits: 2 total, 0 done (0.00%)
[Latency: client-side: 0:02, server-side: 0:02] [0 rows, 0B] [0 rows/s, 0B/s]

Query 20231030_074827_00003_6dk3r failed:  {} not supported yet.CHAR Split [Hive: file:/Users/wypb/data/hive/warehouse/velox.db/char_test_v1/20231030_074307_00005_vc27y_ee660f74-da12-4bda-b938-2896336b3710 0 - 477] Task 20231030_074827_00003_6dk3r.<IP_ADDRESS>

This PR maps the ORC CHAR type to the VARCHAR type of Velox.
CC: @Yuhta @mbasmanova

Hi @mbasmanova Thank you for your reply, I have refactored the relevant code, please help me review again, thanks.

See com/facebook/presto/orc/reader/SliceSelectiveStreamReader.java
    public static int computeTruncatedLength(Slice slice, int offset, int length, int maxCodePointCount, boolean isCharType)
    {
        if (isCharType) {
            // truncate the characters and then remove the trailing white spaces
            return Chars.byteCountWithoutTrailingSpace(slice, offset, length, maxCodePointCount);
        }
        if (maxCodePointCount >= 0 && length > maxCodePointCount) {
            return Varchars.byteCount(slice, offset, length, maxCodePointCount);
        }
        return length;
    }

Are there any downsides in mapping CHAR type to VARCHAR type. These types are not exactly the same, are they?

There are not exactly the same, I feel like there might be a problem with specifying the length of char.

Hi @mbasmanova I have refactored the relevant code, please help me review again, thanks.

Are there any downsides in mapping CHAR type to VARCHAR type. These types are not exactly the same, are they?

@wypb Don't we need to resolve this question before moving forward with this PR?
Maybe extract refactoring into a separate PR so that piece can be merged independently.

Are there any downsides in mapping CHAR type to VARCHAR type. These types are not exactly the same, are they?

There are not exactly the same, I feel like there might be a problem with specifying the length of char.

@wypb, @mbasmanova : Mapping char to varchar type here is prone to many issues:

We lose metadata about the length of the char field.
Char fields have semantics around truncation and padding which Velox varchar doesn't honor.
Because of the truncation and padding behviors, function semantics are different between char and varchar.
Also Velox varchar type by itself is of unlimited length, so its not simple to do some hacks around limiting length either.

It might be better for us to support the char(n) type as a first-class Velox type and map this field to it.


every first/second/fourth/last monday every two months

Can I do this with recur:
"every first/second/fourth/last monday every two months"?

This repository seems to be defunct but this plugin is very useful.  Since @c-trimm has not touched it in 6 months I have made some updates and moved it to: https://github.com/bramski/moment-recur-js
Please revisit your issue there, thanks!

Currently, moment-recur does not support the ability to specify the n-th weekday of a month.


Enhanced the structure and also added some new sections

I have enhanced the structure of the contributing.md file and also added some new sections. Added the screenshots also of the sections which all I have added.
Changes I have made :-

Enhanced the project structure
Added Code of conduct that was given in the project
Added need help with the basics section
Add project structure section
Add additional method of contributing through GitHub desktop section
Add good coding practices section
Add the help and support section
Add the pull request section
Add issue report process section

fixes:[#488 ]
closes:[#488 ]

I have done all the enhancements. Please kindly check it once.


wew

Deploy preview for recalc ready!
✅ Preview
https://recalc-nwtkvck6k-tervay.vercel.app
Built with commit 673b8d89c93e673c312688a1bb1dedac8c223536.
This pull request is being automatically deployed with vercel-action


test: increase jest test timeout

Description
Testing CI after increasing jest test timeout from 30sec to 40sec. I also bumped the local timeout since in my Windows machine is required for tests to pass, so this may be also affecting other contributors.
This is what it took to run test-serve
Test Suites: 28 passed, 28 total
Tests:       228 passed, 228 total
Snapshots:   18 passed, 18 total
Time:        27.369 s

and test-build
Test Suites: 25 passed, 25 total
Tests:       200 passed, 200 total
Snapshots:   0 total
Time:        22.155 s

Additional context
There may be another issue to fix here, but the timeout is generating a lot of noise in CI at this point.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Closing, this is no longer needed after https://github.com/vitejs/vite/pull/3097

Reopening this PR. We are getting timeouts issues even after fixing the server close race. I think it makes sense to merge this one, while we continue to improve the test suite.

Yes, but it is failing because of the timeout, maybe because this new test already pushed the test suite to pass the limit.

I think you are right @Shinigami92, I tried locally and I also see this error after increasing the timeout.

Can you try setting DEBUG=pw:api to try to narrow down why they are failing?

I did but looks like it is an issue with the test itself, all other tests are working correctly. Closing this PR again, we should directly talk in https://github.com/vitejs/vite/pull/3081


If browser states are order agnostic, allow for them to be listed as obj rather than arr

@eastridge suggests supporting both

Browser states are not order agnostic. Multiple can apply at the same time, so order of instantiation matters (if a Radium user adds active styles after hover styles, active styles will take precedence if there is overlap).

That was easy :)


Add SQS handler script

Description:
This PR adds SQS handler script to adot layer
This mentions presence of /opt/otel-sqs-handler but script doesn't exist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you please add if any testing results are available.


Binaries should link openssl statically

See http://users.rust-lang.org/t/expect-disruptions-to-multirust-rs-self-updates/5015/2?u=luthaf for the error.

I've been looking at this all day and I still haven't figured out why our travis setup isn't producing statically-linked bins. My only suspicion is that running cargo test outside of the docker image is overwriting the dockered bins, but I haven't proven it yet.

This works, but I run into another issue. See #131.


[rlp-v2] WasmPlugin reconciliation

Reconciliation of the Istio WasmPlugin CR with wasm rules generated for each limit definition from the affecting RLPs – triggers based on routeSelectors and when conditions, and RL data (descriptors) to activate the limits in Limitador and additional counter qualifiers.
Implements Direct Policy Attachment of RLPs targeting a HTTPRoute or a Gateway (WasmPlugin part).
Highlights

[x] Reconciliation of HTTPRoute RLPs → Wasm rule conditions generated out of the limit's when conditions and HTTPRouteRules selected by the routeSelectors, and data that activates the limit in Limitador plus additional counter qualifiers
[x] Fix pattern expression for hostnames with the right operator (endswith)
[x] Compute the domain intersection between the hostnames specified in the HTTPRoute and the hostnames specified in the Gateway, so it doesn’t generate wasm rules for the wrong gateway/hostname
[x] Stop repeating RLPs for each hostname within the wasm config (see https://github.com/Kuadrant/wasm-shim/issues/35#issuecomment-1607140659)
[x] Reconciliation of Gateway RLPs → Fetch all HTTPRoutes accepted by the Gateway that do not have a RLP of its own, and then fake a HTTPRoute with all rules from those HTTPRoutes, to to generate sets of wasm rules (conditions and data) for each limit of the gateway RLP
[x] Prevent use of routeSelectors in RLPs that target a Gateway
[x] Stop merging gateway RLP rules into the route RLP configs – otherwise we would be implementing (partially) Inherited Policy Attachment instead.
[x] Do not generate conditions for gateway policy wasm rules from HTTPRoutes that have a RLP of its own
[x] Avoid building a wasm plugin config if there are no rules to apply

Verification steps
Topology:
          *                       *.internal
          │                           │
          ▼                           ▼
┌──────────────────────┐    ┌───────────────────┐
│     (Gateway)        │    │     (Gateway)     │
│ istio-ingressgateway │    │ internal-gateway  │
└─────────┬────────────┘    └─────────┬─────────┘
          │                           │
          └─────────────┬─────────────┘
                        │
                  ┌─────┴───────┐
                  │ (HTTPRoute) │
                  │  toystore   │
                  └─────────────┘
                         ▲
                         │
             ┌───────────┴───────────┐
             │  (RateLimitPolicy)    │
             │ toystore-per-endpoint │
             └───────────────────────┘

① Setup:
make local-setup

kubectl -n kuadrant-system apply -f - <<EOF
apiVersion: kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant
spec: {}
EOF

kubectl apply -f examples/toystore/toystore.yaml

② Create a second Gateway:
kubectl -n istio-system apply -f - <<EOF
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: internal-gateway
  annotations:
    kuadrant.io/namespace: kuadrant-system
    networking.istio.io/service-type: ClusterIP
spec:
  gatewayClassName: istio
  listeners:
  - name: default
    port: 80
    protocol: HTTP
    hostname: '*.internal'
    allowedRoutes:
      namespaces:
        from: All
EOF

③ Create a HTTPRoute:
(Notice the route specifies 2 gateway parents and 3 host names, where all 3 host names bind the route to the istio-ingressgateway gateway and one of them to the internal-gateway gateway.)
kubectl apply -f - <<EOF
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: toystore
spec:
  parentRefs:
  - name: istio-ingressgateway
    namespace: istio-system
  - name: internal-gateway
    namespace: istio-system
  hostnames:
  - "*.toystore.acme.com"
  - "*.toystore.io"
  - "*.toystore.internal"
  rules:
  - matches:
    - path:
        type: PathPrefix
        value: "/toys"
      method: GET
    - path:
        type: PathPrefix
        value: "/toys"
      method: POST
    backendRefs:
    - name: toystore
      port: 80
  - matches:
    - path:
        type: PathPrefix
        value: "/assets/"
    backendRefs:
    - name: toystore
      port: 80
EOF

④ Create the RateLimitPolicy:
(Notice one of the limits applies to only one host name.)
kubectl apply -f - <<EOF
apiVersion: kuadrant.io/v1beta2
kind: RateLimitPolicy
metadata:
  name: toystore-per-endpoint
spec:
  targetRef:
    group: gateway.networking.k8s.io
    kind: HTTPRoute
    name: toystore
  limits:
    toys:
      rates:
      - limit: 50
        duration: 1
        unit: minute
      counters:
      - auth.identity.username
      routeSelectors:
      - matches: # matches the 1st HTTPRouteRule (i.e. GET or POST to /toys*)
        - path:
            type: PathPrefix
            value: "/toys"
        hostnames:
        - "*.toystore.acme.com"
      when:
      - selector: auth.identity.group
        operator: neq
        value: admin
    assets:
      rates:
      - limit: 5
        duration: 1
        unit: minute
      - limit: 100
        duration: 12
        unit: hour
      routeSelectors:
      - matches: # matches the 2nd HTTPRouteRule (i.e. /assets/*)
        - path:
            type: PathPrefix
            value: "/assets/"
EOF

⑤ Verify the Limitador CR was reconciled correctly:
kubectl get limitador limitador -n kuadrant-system -o yaml

Expected output
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador
  namespace: kuadrant-system
  …
spec:
  limits:
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 5
    namespace: istio-system/istio-ingressgateway#*.toystore.acme.com
    seconds: 60
    variables: []
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 100
    namespace: istio-system/istio-ingressgateway#*.toystore.acme.com
    seconds: 43200
    variables: []
  - conditions:
    - default/toystore-per-endpoint/toys == "1"
    max_value: 50
    namespace: istio-system/istio-ingressgateway#*.toystore.acme.com
    seconds: 60
    variables:
    - auth.identity.username
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 5
    namespace: istio-system/istio-ingressgateway#*.toystore.io
    seconds: 60
    variables: []
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 100
    namespace: istio-system/istio-ingressgateway#*.toystore.io
    seconds: 43200
    variables: []
  - conditions:
    - default/toystore-per-endpoint/toys == "1"
    max_value: 50
    namespace: istio-system/istio-ingressgateway#*.toystore.io
    seconds: 60
    variables:
    - auth.identity.username
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 5
    namespace: istio-system/istio-ingressgateway#*.toystore.internal
    seconds: 60
    variables: []
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 100
    namespace: istio-system/istio-ingressgateway#*.toystore.internal
    seconds: 43200
    variables: []
  - conditions:
    - default/toystore-per-endpoint/toys == "1"
    max_value: 50
    namespace: istio-system/istio-ingressgateway#*.toystore.internal
    seconds: 60
    variables:
    - auth.identity.username
  - conditions:
    - default/toystore-per-endpoint/toys == "1"
    max_value: 50
    namespace: istio-system/internal-gateway#*.toystore.acme.com
    seconds: 60
    variables:
    - auth.identity.username
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 5
    namespace: istio-system/internal-gateway#*.toystore.acme.com
    seconds: 60
    variables: []
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 100
    namespace: istio-system/internal-gateway#*.toystore.acme.com
    seconds: 43200
    variables: []
  - conditions:
    - default/toystore-per-endpoint/toys == "1"
    max_value: 50
    namespace: istio-system/internal-gateway#*.toystore.io
    seconds: 60
    variables:
    - auth.identity.username
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 5
    namespace: istio-system/internal-gateway#*.toystore.io
    seconds: 60
    variables: []
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 100
    namespace: istio-system/internal-gateway#*.toystore.io
    seconds: 43200
    variables: []
  - conditions:
    - default/toystore-per-endpoint/toys == "1"
    max_value: 50
    namespace: istio-system/internal-gateway#*.toystore.internal
    seconds: 60
    variables:
    - auth.identity.username
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 5
    namespace: istio-system/internal-gateway#*.toystore.internal
    seconds: 60
    variables: []
  - conditions:
    - default/toystore-per-endpoint/assets == "1"
    max_value: 100
    namespace: istio-system/internal-gateway#*.toystore.internal
    seconds: 43200
    variables: []
status:
  conditions:
  - lastTransitionTime: "2023-07-06T13:36:32Z"
    message: Limitador is ready
    reason: Ready
    status: "True"
    type: Ready
  observedGeneration: 2
  service:
    host: limitador-limitador.kuadrant-system.svc.cluster.local
    ports:
      grpc: 8081
      http: 8080

⑥ Verify the WasmPlugin CRs were reconciled correctly:
kubectl get wasmplugin kuadrant-istio-ingressgateway -n istio-system  -o yaml

Expected output
apiVersion: extensions.istio.io/v1alpha1
kind: WasmPlugin
metadata:
  name: kuadrant-istio-ingressgateway
  namespace: istio-system
  …
spec:
  phase: STATS
  pluginConfig:
    failureMode: deny
    rateLimitPolicies:
    - domain: istio-system/istio-ingressgateway#*.toystore.acme.com
      hostnames:
      - '*.toystore.acme.com'
      - '*.toystore.io'
      - '*.toystore.internal'
      name: default/toystore-per-endpoint
      rules:
      - conditions:
        - allOf:
          - operator: startswith
            selector: request.url_path
            value: /toys
          - operator: eq
            selector: request.method
            value: GET
          - operator: endswith
            selector: request.host
            value: .toystore.acme.com
          - operator: neq
            selector: auth.identity.group
            value: admin
        - allOf:
          - operator: startswith
            selector: request.url_path
            value: /toys
          - operator: eq
            selector: request.method
            value: POST
          - operator: endswith
            selector: request.host
            value: .toystore.acme.com
          - operator: neq
            selector: auth.identity.group
            value: admin
        data:
        - static:
            key: default/toystore-per-endpoint/toys
            value: "1"
        - selector:
            selector: auth.identity.username
      - conditions:
        - allOf:
          - operator: startswith
            selector: request.url_path
            value: /assets/
        data:
        - static:
            key: default/toystore-per-endpoint/assets
            value: "1"
      service: kuadrant-rate-limiting-service
  selector:
    matchLabels:
      app: istio-ingressgateway
      istio: ingressgateway
  url: oci://quay.io/kuadrant/wasm-shim:latest

kubectl get wasmplugin kuadrant-internal-gateway -n istio-system  -o yaml

Expected output
apiVersion: extensions.istio.io/v1alpha1
kind: WasmPlugin
metadata:
  name: kuadrant-internal-gateway
  namespace: istio-system
  …
spec:
  phase: STATS
  pluginConfig:
    failureMode: deny
    rateLimitPolicies:
    - domain: istio-system/internal-gateway#*.toystore.internal # <==== this will have to change or it will activate different limits/increase different counters
      hostnames:
      - '*.toystore.internal'
      name: default/toystore-per-endpoint
      rules:
      - conditions:
        - allOf:
          - operator: startswith
            selector: request.url_path
            value: /assets/
        data:
        - static:
            key: default/toystore-per-endpoint/assets
            value: "1"
      service: kuadrant-rate-limiting-service
  selector:
    matchLabels:
      istio.io/gateway-name: internal-gateway
  url: oci://quay.io/kuadrant/wasm-shim:latest

Closes #200
Relates to #156

High level, reviewed the verification steps and they are what we should expect (I have not run them yet). Always under the assumption of when a policy targets a HTTPRoute, that policy fully replaces any other policies that might exist targeting the HTTPRoute's parents Gateways.
One nitpick: For the rlp-4 applied to the route-2, the empty conditions (also absence of the conditions field which is options) works like "catch all" and matches all requests for the given hostname in the wasm-shim. No need to add
 - conditions:
        - allOf: # from route-2
          - operator: startswith
            selector: request.url_path
            value: /

verification steps working

Tested removing httproutes and rlp's to see how reconciliation handles and works as expected :muscle:

I think now I (fully) understand the route selector concept. We really need to document it clearly.  If routeSelector are thought as traffic qualifiers for rate limiting, that may lead to unexpected behavior. routeSelectors are (surprise) nothing else than a HTTPRoute rule (route) selector. And the traffic qualifiers for rate limiting are the (selected) HTTPRoute rules.
 One (like me) might expect to be GET /v1*

Verification steps working, both guides!
BTW, super useful to extract to a user guide 📖


[lighthouse] add reference for "Excessive DOM" audit

Whoops!
There were 2 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/lighthouse/audits/dom-size.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/tools/lighthouse/audits/dom-size.md#L57 - '