Images associated with substitution references are lost

The following bits are snipped a few different ways.  See links for actual text.  I am no reStructuredText expert so hopefully my terms aren't too incorrect, but it seems that while the substitution reference does get processed enough to result in the substitution definition's target being presented as the link, it does not process the definition's image.
https://github.com/altendky/qtrio/blob/eddc9446fda97567dd4e44971ff088bd0380743b/docs/source/README.rst
|documentation badge|
<snip>
.. _documentation: https://qtrio.readthedocs.io
.. |documentation badge| image:: https://img.shields.io/badge/docs-read%20now-blue.svg?color=royalblue&logo=Read-the-Docs&logoColor=whitesmoke
   :target: `documentation`_
   :alt: Documentation

becomes
https://github.com/altendky/qtrio/blame/eddc9446fda97567dd4e44971ff088bd0380743b/README.rst#L9-L12
`documentation <https://qtrio.readthedocs.io>`_

The full scenario is that I am trying to render my .rst readme including .. literalinclude:: as well as badge images since GitHub won't process literalincludes.
https://github.com/altendky/qtrio/pull/233
.rst result as rendered on GitHub.

.html result as rendered on Read the Docs.

Thanks for the report. I haven't found the time to dive into this issue, but will try to do so.

@macfreek thanks for checking in.  I understand there are many things to be done.  If I didn't have so many I would spend more time on this myself.  :]

It turns out that this is a lot more difficult than I anticipated.
The short version is:

reStructuredText has very little support for nested elements, like an image in a table, or bold/italic markup in a hyperlink.
The only way to use such nested elements is to use substitution, like substitution images or substitution (text) replace.
Sphinx uses the docutils standalone.Reader, which does the substitution before handing the result over to the Writer. (using the references.Substitutions Transform).
Hence, the writer only sees the already substituted result, with a nested element. However, there is no (easy) way to turn this into valid reStructuredText. At least not knowing the original unsubstituted doctree,
So it seems the Builder need to choose a different Reader, which may not even be possible.
I've posted a plea for feedback to sphinx-dev.

Awesome...  :]  Thank you for digging into this.
While I'd rather do it with 'proper' .rst tooling, I could 'solve' my underlying issue with a jinja template or even simpler since it is actually just about the lack of support on GitHub for literalinclude.  Or I could do away with the ugly table that I got talked into a few months back.  :]  Anyways, I'm still itchin' to do it right and appreciate your effort.  I look forward to a response providing you with a path forward to help us all.
I just realized I hadn't included the relevant GitHub issue where they rejected supporting includes.  Anyways... https://github.com/github/markup/issues/172#issuecomment-33241601

There are indeed two distinct issues here: support for substitutions (|reference|), and support for the literalinclude directive. I'll have a look in the second later. Some full working days coming up first. My above comment was mostly a summary of finding of the root cause, which (hopefully) allows me to start finding a solution when I find some spare time.
  That's the primary interest in restbuilder to begin with.  :]

I seem to have hit a few limitation of the reStructuredText syntax. I don't think there is a possibility to fully support both file includes and substitutions.
Rather than closing this as a wontfix, I would appreciate to hear a bit more about the desired use case, and what you can live without: substitutions or includes.
An example
Let me explain the (technical) challenge with an example:
In index.rst::
|test123|_ is the best test!

.. include:: substitutions.rst

and in substitutions.rst::
.. |test123| replace:: test number *123*
.. _test123: https://example.org/test/123

In two steps, this produces a perfectly valid doctree. First the include is transformed::
<paragraph><reference refname="test123"><substitution_reference refname="test123">test123</substitution_reference></reference> is the best test!</paragraph>
<substitution_definition names="test123">test number <emphasis>123</emphasis></substitution_definition>
<target ids="test123" names="test123" refuri="https://example.org/test/123"/>

And secondly, the substitution_reference and (hyperlink) reference are transformed::
<paragraph><reference refuri="https://example.org/test/123">test number <emphasis>123</emphasis></reference> is the best test!</paragraph>
<substitution_definition names="test123">test number <emphasis>123</emphasis></substitution_definition>
<target ids="test123" names="test123" refuri="https://example.org/test/123"></target>

Note that the substitution_definition and target definition remain, although there are both resolved.
Now this is perfectly fine doctree, which creates perfectly fine HTML:

test number 123 is the best test!

Sadly, it does not simply create the desired reStructuredText::
`test number *123* <https://example.org/test/123>`_

This will not parse the emphasis, just <reference refuri="https://example.org/test/123">test number *123*</reference>.
This is very similar to what you see: an unparsed piece of reStructuredText in a place where you expected it to be rendered. In your case, it is a link or an image in a table. (Note: restbuilder incorrectly leaves some part out, but even if it would include it, you would not see the image you expect).
As noted before:

reStructuredText has very little support for nested elements, like an image in a table, or bold/italic markup in a hyperlink.
The only way to use such nested elements is to use substitution, like substitution images or substitution (text) replace.

Attempt at a workaround
So my first attempt was to leave the substitutions intact. Technically, it seems simple. Sphinx and docutils run about 40 transformations, from (adding) smart quotes, toctree, to reference transforms. I just had to disable one of them: substitution transforms.
I managed to do that.
Sadly, this approach seems too fragile, and I have now decided not to continue. The reasons it is fragile are:

Sphinx does not provide an API to do this, so I had to replicate a few hundred lines of code. it works, but will add overhead to ensure that the extension code and the Sphinx code remain compatible.
It breaks the doctree caching of Sphinx. By disabling a particular transform, the resulting doctree is different. It now still contains these unresolved substitutions. When you first output rst, than output html, the HTML writer will receive the cached doctree, and is confronted with these unresolved substitutions that it doesn't understand. This requires more hackery to remove the caches.
Resolving substitutions are sometimes useful. Sphinx has the powerful ability to keep track of referencing targets across different files. A substitution may not just contain a "replace" or "image" directive, but also some more advanced directive that may rely on these cross references. Perhaps that may continue to work, perhaps not. Normally Sphinx takes care of that. By keeping the original reference in place, I am not so sure if all that should be resolved, is resolved.

Second approach
The bottom line why your code is failing is because it has nested markup. In your case, an image and hyperlink in a table.
What restbuilder is doing now is simply ignoring all nested markup. Either break of the out markup structure, e.g. "close" the table, and add the image underneath the table, and start a new table. That will be a mess. What it does now is simple skip the inner markup, or display the inner markup as plain text.
One possible options is to get the parsed doctree, with all substitution done, and detect nested markup, and in those cases, try to create a custom substitution. It might fail in some cases, but at least I don't have to go the whole duplication-of-code and break-caching route, and may support a few common cases, like markup in hyperlinks and images in tables.
I managed that, but it was non-trivial.

Thank you both for all the effort on the problem and the detailed explanations.
I think I had run into the limited nesting support in a couple small situations before without really internalizing it.  This strikes me as a significant flaw, but it apparently hasn't actually caused me all that much trouble in other cases.  I think it is time for me to take this limitation to heart and just avoid nesting.
Then it seems I can use restbuilder to compensate for GitHub not supporting literalinclude...
I feel a bit bad walking away after you have done so much and also before you have totally given up, but it seems like the robust path for me to take in the future and frees you from the responsibility we place on ourselves when someone is waiting on our efforts.  If you do continue, I can certainly test things out.

I feel a bit bad walking away after you have done so much and also before you have totally given up, [...]

No worries. As far as I'm concerned I don't have an obligation to offer this support, and you certainly don't have an obligation to use it 🙂
I'm more concerned that you assume I will give up 😛
As for the effort, it took a bit of time, but it did help me understand some of the internals of sphinx and docutils, which also help get this rst builder in the shape I like it to be. I appreciate your offer to test things, and may held you to it :)


Port to Visual Studio

Should be mostly folder organization plus some new build steps, but get this thing live on VS

duplicate of #49


Error when opening C/SIDE Enviroment

Hi guys,
i found an error when creating a container for a German database. For example using the following command:
New-CSideDevContainer     -containerName $containername
-ImageName microsoft/dynamics-nav:2017-de     -licenseFile "D:\mydevlicense.flf"
-Credential $credential     -memoryLimit 4G
-updateHosts     -auth NavUserPassword
-accept_eula
When I try to open the C/SIDE development environment I receive the following error:

Microsoft Dynamics NAV Development Environment
Die Wahlmöglichkeit 'yes' ist nicht vorhanden.
Die Wahlmöglichkeiten sind:
Nein, Ja
OK
The problem is the created link to the development environment:
If I check the properties -> target I see the following:
"C:\DEMO\Extensions\nav2017latestcu\Program Files\100\RoleTailored Client\finsql.exe" servername=nav2017latestcu\SQLEXPRESS, Database=CronusDE, ntauthentication=yes
To make this work I have to change ntauthentication=yes to ntauthentication=ja. I guess this behavior also occurs with other languages.

I think this has to do with settings in your zup file, try setting your language to English or remove your zup file.

in fact I should be setting ntauthentication to 1 instead of yes - 1 is the same in all countries:-)

@freddydk that's even better 👍

@richardrobberse: I had no zup file when the error first occured
@freddydk: Great idea 🥇

This is fixed in navcontainerhelper <IP_ADDRESS> - just released


notification language changed

I polled this morning (dev) and likes are displayed on /notifications/system 👍
This is great but the notification language changed from German to English:

Works fine after last pull.


Add Sematext as a partner.

Description
Add Sematext as partner.
Issues Resolved
N/A
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@otisg You're live! https://opensearch.org/partners/sematext.html


Help with Understanding

First, please, forgive me for intruding on you like this.  I saw no other way to reach out to you.
I have been working on a Python program to fill out Unified Credentialing Applications similar to this one but for a different state.  It has been a journey trying to sort out all that needs to be navigated with PDF's.  I was trying to figure out how to deal with check boxes and came across your post here.  It has been helpful, but there is much I am unable to piece together in your article.
In the article you mention print (annotation['/AP']['/N'].keys()) but I am unable to sort out what annotation is with respect to your code.  I looked at the GitHub repository but am not able to glean what it is referencing.
In another (brilliant) function that you show:
def field_type(annotation):
    ft = annotation['/FT']
    ff = annotation['/Ff']

    if ft == '/Tx':
        return 'text'
    if ft == '/Ch':
        if ff and int(ff) & 1 << 17:  # test 18th bit
            return 'combo'
        else:
            return 'list'
    if ft == '/Btn':
        if ff and int(ff) & 1 << 15:  # test 16th bit
            return 'radio'
        else:
            return 'checkbox'

You use the annotation again, but the only thing I can come up with is its the form field name?  But another thing came up in trying to emulate that code.  I have no /Ff in the few PDF's I have looked at so far.  Without that, is it possible to test the bits?
Again, forgive me for the intrusion like this.  I have beat my head against my computer screen, laptop and desk for a couple days now trying to sort this out and this was the only way I saw to reach out to you.  If you can offer any assistance that would be awesome.  If not, I completely understand.

It's all good.  I never got it all sorted out and it kind of fell to the back burner.  The ultimate goal was to take the credentialing form, point it to the user information/data and it fill in the form and save it.  I just never could work through the PDF structure to get at all the fields.
I had conversations with some of the traveling nurses at the hospital I work at (Network Engineer) and it seemed to be a common complaint about how long it took to fill out that form in particular and others and the number of times they had to do so.  I had hoped to leverage my meager Python knowledge to help them out but never could sort it all out.


Multipart copy for big files

Fixes #287
@mariusvniekerk , I don't think we can ask moto to test this for us - would you?

Yeah moto is going to want to allocate it in memory. Doubt that's super feasible.

This should be the rough shape, and I suppose we can test by copying smaller files with smaller, chunks, so long as each chunk is >5MB?

Yeah the constraint is that you can't copy with a range going from 0 to <5MB

We can allow specifying the chunk size as a variable and just default it to something biggish

Alternatively we could use https://github.com/boto/s3transfer directly.  This doesn't seem to need boto3 at all.

@mariusvniekerk , seems like a bad idea to rely on a thread pool for something commonly used in conjunction with Dask. I was thinking, conversely, that it would be nice to provide Dask as an up/download manager for the various file systems - if their implementations are reasonably thread-safe!

I doubt that most dask operations copy objects within / between buckets :)


st2workroom express installation could auto-update to latest stable

Fixed by https://github.com/StackStorm/puppet-st2/pull/27


Use mp4v encoding instead of h264

Hi @theRealProHacker ,
Using h264 as a codec for mp4 causes issues on many platforms since it falls under a GPL license (see) but is used in this library:
https://github.com/theRealProHacker/PyGameRecorder/blob/97551c66c3a5eaa1b9c30527f9139699d32e9c8f/src/pygame_screen_record/ScreenRecorder.py#L439-L440
You actually refer to StackOverflow where they suggest using mp4v instead. Is there a reason you decided to use "h264"? Otherwise, I guess using "mp4v"  would be the better choice :)
codec_dict = {"avi": "DIVX", "webm": "WEBM", "mp4": "mp4v"}

Hi, thanks for raising this issue. I actually linked the SO answer because it says at the bottom that web browsers (only) support h264 and I felt like this would be a good reason to prefer it over mp4v.
But I also made codec_dict publicly/globally available and mutable on purpose, so that users can alter it for their needs and use the codec they prefer the most. I think that's even mentioned somewhere in the README. So the easiest work-around is simply doing codec_dict["mp4"]="mp4v" (or whatever FOURCC you like) before you save any recording.
What I really want, is FFmpeg to select the optimal codec automatically from the file extension. It should be possible, but I don't know how to do it.
For that reason, h264 might be a good alternative.
mp4v will always work, but the product might not be displayable everywhere (from my experience). With h264 it will most likely not work, but it's always more optimal.
Either it just works or it doesn't and FFmpeg chooses the next best alternative automatically. The bad console byproduct is irrelevant in most pygame applications (pygame produces it anyway).
I don't think there are any licensing problems by simply referring to the codec, right?
I'll leave this issue open, until everything is documented that should be documented.
If you have any further questions or suggestions, It'd be a pleasure to listen to your valuable insights.

Thanks for your detailed answer!! No there shouldn't be any issues by only referring to it.
I feel like the readme is a tiny bit involved, so finding such information can be difficult.  Maybe a troubleshooting section discussing such things could be helpful for others in the future :)


Simple project config results in typescript compilation error "Could not find a declaration file for module 'lodash'"

Bug Report
Importing the package and using it in a basic typescript app results in the typescript error Could not find a declaration file for module 'lodash'.
This error can be fixed if you manually install @types/lodash (by running yarn add @types/lodash -D). However, for a good developer experience, this shouldn't be necessary - (perhaps @types/lodash should be among the dependencies of the package, or included through some other build mechanism).
Steps
I've made a sample repo that demonstrates the issue - repo steps are in the README there.
To reproduce from scratch, here are the high-levels steps.

Set up a simple "hello-world" typescript + react project using the tooling chain of your choice.
Add fluent-ui-react to the project.
Add a simple button component to your app.

Expected Result
TSC should compile without warnings.
Actual Result
node_modules/@fluentui/react/dist/es/components/Carousel/Carousel.d.ts:3:20 - error TS7016: Could not find a declaration file for module 'lodash'. '/Users/Andrew/Projects/fluent-ui-react-test/node_modules/lodash/lodash.js' implicitly has an 'any' type.
  Try `npm install @types/lodash` if it exists or add a new declaration (.d.ts) file containing `declare module 'lodash';`

3 import * as _ from 'lodash';
                     ~~~~~~~~

node_modules/@fluentui/react/dist/es/components/Dropdown/Dropdown.d.ts:3:20 - error TS7016: Could not find a declaration file for module 'lodash'. '/Users/Andrew/Projects/fluent-ui-react-test/node_modules/lodash/lodash.js' implicitly has an 'any' type.
  Try `npm install @types/lodash` if it exists or add a new declaration (.d.ts) file containing `declare module 'lodash';`

3 import * as _ from 'lodash';
                     ~~~~~~~~

node_modules/@fluentui/react/dist/es/utils/applyAccessibilityKeyHandlers.d.ts:2:20 - error TS7016: Could not find a declaration file for module 'lodash'. '/Users/Andrew/Projects/fluent-ui-react-test/node_modules/lodash/lodash.js' implicitly has an 'any' type.
  Try `npm install @types/lodash` if it exists or add a new declaration (.d.ts) file containing `declare module 'lodash';`

2 import * as _ from 'lodash';
                     ~~~~~~~~

Version
0.43.0
Testcase
See the sample repo I created.
I investigated creating a sample on codesandbox.io, but it appears that they use react-scripts to do the compilation, which won't check (I think) for errors in npm packages the way that tsc does.

Hey @astegmaier, thanks for reporting!
We have some projects tests to avoid such issues, but we missed this. I opened #2323 to catch this and going to provide a fix there.


Update ubuntu runner version #2110

Why:

Specifying ubuntu-latest launch Ubuntu 20.04 but the docs states that is still Ubuntu 18.04
#2110

What's being changed:
Moved ubuntu-latest label to Ubuntu 20.04 instead of 18.04.
I just don't know if you still consider Ubuntu 20.04 as a preview.

@thibauds Thanks so much for opening a PR! I'll get this triaged for review ⚡

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

Thank you for this contribution! 🙇 It looks like this change is still being rolled out (https://github.com/actions/virtual-environments/issues/1816). Once the roll out it complete, we will remove this notice entirely. I am going to close this issue, but I hope you will continue contributing in the future!

Thank you for this contribution! 🙇 It looks like this change is still being rolled out (https://github.com/actions/virtual-environments/issues/1816). Once the roll out it complete, we will remove this notice entirely. I am going to close this issue, but I hope you will continue contributing in the future!


fix(SDK): IBM Cloud SCC Java SDK

javadoc generate goal executed in deploy phase

:tada: This PR is included in version 0.0.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Raise error after bad coords while padding

Raise a ValueError if any bad coordinate is found in the DataArray while padding. A bad coordinate is defined as any additional coordinate present in the DataArray that shares at least one of the dimensions along which the grid will be padded. The error message suggests the user to drop the offending coordinate before trying to pad the grid.

This went under my radar but I think I'll merge this.

Thanks @roxyboy!


nllb.py and madlad.py points to the incorrect HF repositories

Branch  Main
Environment  Google Colab
RAM/vRAM  16gb vram
Script with parameters  nllb.py; madlad.py
Data layout or HF dataset  facebook/nllb-200-distilled-1.3B; google/madlad400-7b-mt-bt; nllb-200-distilled-600M
Problem description/Question
Hi, I was testing the benchmark script and I found that it´s pointing wrong to some Hugginface repositories. I guess that the actual problem is on the files nllb.py and madlad.py
When executing them, it´s triying to get the config.json from a wrong url, that points to the HugginFace repositories. Above is the url that the software tries to use, and below the correct ones that I checked that they work:
https://huggingface.co/facebook/nllb-200-DISTILLED600M/resolve/main/config.json
https://huggingface.co/facebook/nllb-200-distilled-600M/resolve/main/config.json
https://huggingface.co/google/madlad400-7b-bt-mt-bt/resolve/main/config.json
https://huggingface.co/google/madlad400-7b-mt-bt/resolve/main/config.json
https://huggingface.co/facebook/nllb-200-DISTILLED1.3B/resolve/main/config.json
https://huggingface.co/facebook/nllb-200-distilled-1.3B/resolve/main/config.json
This is an example of the error that I am getting:
Input: !python benchmark.py en eu nllb_distilled1.3b
Output:
/usr/local/lib/python3.10/dist-packages/transformers/deepspeed.py:23: FutureWarning: transformers.deepspeed module is deprecated and will be removed in a future version. Please import deepspeed modules directly from transformers.integrations
  warnings.warn(
2024-02-12 07:37:14.626071: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:9261] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-02-12 07:37:14.626122: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:607] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-02-12 07:37:14.628076: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1515] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-02-12 07:37:16.078312: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
[---- LLaMa2Lang ----] Starting benchmarking from en to eu for models ['nllb_distilled1.3b'] on 100 records on device cuda:0
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/_errors.py", line 270, in hf_raise_for_status
    response.raise_for_status()
  File "/usr/local/lib/python3.10/dist-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://huggingface.co/facebook/nllb-200-DISTILLED1.3B/resolve/main/config.json

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/transformers/utils/hub.py", line 389, in cached_file
    resolved_file = hf_hub_download(
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/file_download.py", line 1374, in hf_hub_download
    raise head_call_error
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/file_download.py", line 1247, in hf_hub_download
    metadata = get_hf_file_metadata(
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/file_download.py", line 1624, in get_hf_file_metadata
    r = _request_wrapper(
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/file_download.py", line 402, in _request_wrapper
    response = _request_wrapper(
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/file_download.py", line 426, in _request_wrapper
    hf_raise_for_status(response)
  File "/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/_errors.py", line 320, in hf_raise_for_status
    raise RepositoryNotFoundError(message, response) from e
huggingface_hub.utils._errors.RepositoryNotFoundError: 401 Client Error. (Request ID: Root=1-65c9cab0-385f3047149c5c1844aa14bd;e916b38a-b643-499b-a742-f5c9d4a5454d)

Repository Not Found for url: https://huggingface.co/facebook/nllb-200-DISTILLED1.3B/resolve/main/config.json.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated.
Invalid username or password.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/content/LLaMa2lang/benchmark.py", line 109, in <module>
    main()
  File "/content/LLaMa2lang/benchmark.py", line 86, in main
    translator = NLLBTranslator(device, True, quant4_config, False, max_length, model_size)
  File "/content/LLaMa2lang/translators/nllb.py", line 40, in __init__
    model = AutoModelForSeq2SeqLM.from_pretrained(model_name, device_map=device, quantization_config=self.quant4_config, load_in_4bit=True)
  File "/usr/local/lib/python3.10/dist-packages/transformers/models/auto/auto_factory.py", line 488, in from_pretrained
    resolved_config_file = cached_file(
  File "/usr/local/lib/python3.10/dist-packages/transformers/utils/hub.py", line 410, in cached_file
    raise EnvironmentError(
OSError: facebook/nllb-200-DISTILLED1.3B is not a local folder and is not a valid model identifier listed on 'https://huggingface.co/models'
If this is a private repository, make sure to pass a token having permission to this repo either by logging in with `huggingface-cli login` or by passing `token=<your_token>`

I have tried fixing from a phone so can you try again? Also for #54

I have tried fixing from a phone so can you try again? Also for #54

Thanks.
I have analyzed all models and there are still the same kind of bug in nllb_distilled1.3b and nllb_distilled600m. The rest works fine.
#54 Is fixed  (I saw that an 16 GB VRAM GPU is not enough. But I was able to finish the benchmark with an 40 GB VRAM GPU).

@ErikTromp Sorry to bother you. Did you check my above message?

Yeah sorry I will fix it next week, currently on vacation without access to a development device

No problem. Enjoy your holidays!

Maybe @mirekvink can help already

Nope, it's holiday time :)

From: Erik Tromp @.>
Sent: Thursday, February 15, 2024 5:09:19 PM
To: UnderstandLingBV/LLaMa2lang @.>
Cc: Mirek Vink @.>; Mention @.>
Subject: Re: [UnderstandLingBV/LLaMa2lang] nllb.py and madlad.py points to the incorrect HF repositories (Issue #53)
Maybe @mirekvinkhttps://github.com/mirekvink can help already
—
Reply to this email directly, view it on GitHubhttps://github.com/UnderstandLingBV/LLaMa2lang/issues/53#issuecomment-1946428863, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACWSN5NBBY4AATM7I54KNIDYTYXK7AVCNFSM6AAAAABDEKAUSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWGQZDQOBWGM.
You are receiving this because you were mentioned.Message ID: @.***>

@elBlacksmith works now, mind you that you need to add a hyphen for the distilled ones (missed that before):
python benchmark.py en nl nllb_distilled-1.3b,nllb_distilled-600m

@elBlacksmith works now, mind you that you need to add a hyphen for the distilled ones (missed that before): python benchmark.py en nl nllb_distilled-1.3b,nllb_distilled-600m

Thanks!


Autocomplete improvement

We should improve Autocomplete.
Now for some reason, it works in the second case ( i.film_id ), but doesn't work in the first case (f.film_id ) (see attachment)
https://github.com/dbeaver/dbeaver/assets/84867187/755ff083-5944-4126-9909-55e54fb06150
SELECT  i.inventory_id ,
a2.address_id
FROM
 public.album a1,
 public.address a2,
 public.actor a3,
 public.accounts a4,
 public.film f
INNER JOIN public.inventory i on f.film_id = i.film_id
 WHERE  a4.id =1

Can't reproduce on DBeaer 23.0.5


[ENH] investigate use of abc for base classes, write STEP

@TonyBagnall recently suggested to use of abc for classifiers in *#1873, #1708), and this was also previously discussed a number of times: #1424, #1708, #510, #420.
I do think we need to work out a STEP for this, it would be a major change to the interface framework.
There are some open questions that I have:

which classes would inherit from ABCMeta?
how do we deal with optional abstract methods?
how does this integrate with the tag system in BaseObject? This could be updated using ChainMap.
are there any problematic interactions of the public/private nesting pattern fit/_fit?
we would still like to have capability tags that tell us whether an optional method is implemented or not, e.g., predict_proba or predict_interval. How would this interact with abc?
how would downwards compatibility and deprecation work here?
what about polymorphic estimators, e.g., a pipeline that can act like a transformer or a forecaster? Would abc not complain about missing transformer methods if it happens to behave like a forecaster and vice versa?

There's probably more once we have a proper design discussion, this is only off the top of my head.

Why is this an issue. This is the standard best practice way of doing abstract methods in python why wouldn't we do it.

To answer your questions more directly though I think you're overcomplicating  a lot of it. Literally it will feel the same as the current raise NotImplementedError except it's standardised and more util methods (and ides can better support auto implement functionality):

which classes would inherit from ABCMeta?
BaseClusterer, BaseClassifier, BaseForecaster etc. Essentially any estimator/transformer that current uses raise NotImplementedError(). This is because ABC just does what that does.

how do we deal with optional abstract methods?
Optional abstract methods aren't really abstract method. What I think you are wanting is just method overriding. So add a default behaviour and override it in the parent class when you want to change the default behaviour.

how does this integrate with the tag system in BaseObject? This could be updated using ChainMap.
This wouldn't touch any of this?

are there any problematic interactions of the public/private nesting pattern fit/_fit?
No.

we would still like to have capability tags that tell us whether an optional method is implemented or not, e.g., predict_proba or predict_interval. How would this interact with abc?
It doesn't touch it. It's an abstract method it doesn't touch functionality.

how would downwards compatibility and deprecation work here?
Abc has been supported since 3.6. Again you don't deprecate anything you're just moving away from raise NotImplementedError().

what about polymorphic estimators, e.g., a pipeline that can act like a transformer or a forecaster? Would abc not complain - - about missing transformer methods if it happens to behave like a forecaster and vice versa?
These aren't abstract methods. But I know they exist and where this happens just raise NotImplementedError. We shouldn't be not using the best practise stuff where it's appropriate just because a niche scenario it doesn't work.

which classes would inherit from ABCMeta?
ones with abstract methods currently raising errors if not implemented

how do we deal with optional abstract methods?
this has no meaning. The definition of an abstract method is one a subclass must implement. Either there is sensible default behaviour, or its abstract. If you want to still raise errors for optional methods, or just pass if it makes sense, thats fine. ABC doesnt stop you doing this.

how does this integrate with the tag system in BaseObject? This could be updated using ChainMap.
not sure why making methods abstract would influence tags at all

are there any problematic interactions of the public/private nesting pattern fit/_fit?
how can there be? In fact it enforces correct behaviour at compile time, thats the whole point

5.we would still like to have capability tags that tell us whether an optional method is implemented or not, e.g., predict_proba or predict_interval. How would this interact with abc?
if you want a method optional, it should not be abstract. You just carry on as before.

how would downwards compatibility and deprecation work here?
see chris's answer

what about polymorphic estimators, e.g., a pipeline that can act like a transformer or a forecaster? Would abc not complain about missing transformer methods if it happens to behave like a forecaster and vice versa?
dont make them abstract unless the have to be implemented by subclasses. I honestly dont understand you points, I think you have misunderstood the meaning of abstract methods, or at least the meaning we teach our first years. If you want to use them in some weird non standard way for forecasting, go for it, maybe there is even a python histroy of it, I dont know. However, I dont know why you are persistently blocking such a simple, uncontroversial change for classifiers when ABC is already used in benchmarking (which you managed), and why you did not object to its use in clustering and distances.

which classes would inherit from ABCMeta?
BaseClusterer, BaseClassifier, BaseForecaster etc. Essentially any estimator/transformer that current uses raise NotImplementedError(). This is because ABC just does what that does.

I worry a bit about the overhead this causes.
Should not BaseObject inherit from it, and nothing else?

Optional abstract methods aren't really abstract method. What I think you are wanting is just method overriding. So add a default behaviour and override it in the parent class when you want to change the default behaviour.

No, this won't work - there are methods that have no sensible default behaviour and should raise an error. Examples: predict_interval for forecasters.

how would downwards compatibility and deprecation work here?
Abc has been supported since 3.6.

Your answer is besides the point: I mean, downwards compatibility with sktime itself before we make the change.
Are we certain this won't break custom estimators, for instance? If so, what is the argument to be certain?

what about polymorphic estimators, e.g., a pipeline that can act like a transformer or a forecaster?
We shouldn't be not using the best practise stuff where it's appropriate just because a niche scenario it doesn't work.

Very shaky argument imo. Polymorphic pipelines are not nice, the pipeline is in fact a central object in sklearn-like libraries. I am against abc unless we can ensure that polymorphic pipelines such as the sklearn one work properly.

@TonyBagnall

I think you have misunderstood the meaning of abstract methods, or at least the meaning we teach our first years.

I know what abstract methods are and how they work in abc.
A descendant will exception if it doesn't override all the abstracts declared by abc.

which classes would inherit from ABCMeta?
ones with abstract methods currently raising errors if not implemented

Why not BaseObject? I don't like that we inherit from multiple classes again.

how do we deal with optional abstract methods?
this has no meaning. [...] Either there is sensible default behaviour, or its abstract.

Disagreed, I think you don't get the conceptual point here: some base types have methods that have no sensible default and descendants do not need to implement them, so cannot be abstract. Example is predict_quantiles for forecasters.

overall, I'm happy with answers to 3, 4, 5. I'm not happy and concerned about the others.

Ultimately I don't really mind, if you object we won't do it, but it seems a really odd block to me, clearly missing some nuance in your design. So do you want to strip ABC out of the code base?

Ultimately I don't really mind, if you object we won't do it, but it seems a really odd block to me, clearly missing some nuance in your design. So do you want to strip ABC out of the code base? If so, could you start with benchmarking and then we will follow

I'm actually in favour since it's elegant. I just don't want to miss an important problem this may cause, such as complicating the extender contract.

I'm really confused now, you blocked my pr making classifier abstract but want it? I'll reopen the PR

I'm really confused now, you blocked my pr making classifier abstract but want it? I'll reopen the PR

Sorry for not being clear:

I like the general idea and am quite supportive of it
I think we need to clarify some open design questions before we can merge the concrete PR

This is not a contradiction! All I want is us avoiding waking up to a bad surprise because we did not think the design through.
I still consider some of my questions above open or not sufficiently answered.
E.g., how does the extender contract concretely change?

I think we have implicitly decided not to use abc, becaus:

it clashes with inheritance patterns in which some methods that are abstract should be overridden only in conditional cases, depending on tags. For instance, BaseForecaster._predict_interval etc should only be implemented if the capability:pred_int tag is set.
it clashes with the pattern of having a default private logic that uses other methods if not overridden, e.g., getting )predict_quantiles from _predict_interval or vice versa in BaseForecaster

Also see another example of this problem here where we had to remove abc: https://github.com/sktime/sktime/pull/4527


Add recruitee

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.


Make event name helper and use it on tooltip & popover to reduce dist sizes

Two ideas come to mind. 1) Use eventName() in more components. 2) Get rid of EVENT_KEY.

Two ideas come to mind. 1) Use eventName() in more components. 2) Get rid of EVENT_KEY.

Totally aligned with your idea. I want to take it bit by bit to keep PR with few changes. In case it merged, it will be easier to continue change other components


Import space and baseline in variables.scss

Fixes #142

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ARROW-3965 [Java] JDBC-To-Arrow Configuration

https://issues.apache.org/jira/browse/ARROW-3965
This creates an object which configures the BaseAllocator and Calendar used during to configure the translation from a JDBC ResultSet to an Arrow vector.

@siddharthteotia @atuldambalkar can you review this?


go build cannot find versioned package when in vendor folder

What version of Go are you using (go version)?

$ go version
go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jrliu/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jrliu/Projects/go_pkg:/Users/jrliu/Projects/common_git/src/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/2f/dd68lmkj44xbb6t17wzr7mfr9snms2/T/go-build042915927=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
My project is based on "github.com/xitongsys" (which is based on "github.com/colinmarc/hdfs")
When I run "go build", there is no problem when those dependences are located in GOPATH/src.
When I move those dependences to myProject/vendor, and run "go build", the build will fail:
-->
vendor/github.com/colinmarc/hdfs/client.go:13:2: cannot find package "github.com/colinmarc/hdfs/v2/hadoopconf" in any of:
...
I know the "colinmarc/hdfs" uses the module-feature, and "github.com/colinmarc/hdfs/v2" is the name of module.
Can anybody help me and I cannot find any helpful information from the Internet.
What did you expect to see?
Build success
What did you see instead?
Build failed

Please give us the exact set of steps to reproduce this issue.

@agnivade Thanks for your quick reply.
The step is as follows:

Create a project (named "temp") with a go file written as:
--
package main

import (
"github.com/xitongsys/parquet-go/ParquetFile"
"github.com/xitongsys/parquet-go/ParquetWriter"
)
type Model struct {
F1 string parquet:"name=name, type=UTF8"
}
func main() {
// Write
fw, _ := ParquetFile.NewLocalFileWriter("/tmp/test.parquet")
pw, _ := ParquetWriter.NewParquetWriter(fw, new(Model), 4)
stu := Model{F1: "f1"}
pw.Write(stu)
fw.Close()
}

Run "go get github.com/xitongsys/parquet-go/..." to get the required dependencies. Then you can get a lot of dependencies under "$GOPATH/src"

Run "go build" under our project. Then the building is OK.

Move all dependencies to "$GOPATH/src/temp/vendor".

5 Run "go build" again. Then the building is failed like:
vendor/github.com/colinmarc/hdfs/client.go:13:2: cannot find package "github.com/colinmarc/hdfs/v2/hadoopconf" in any of:
...
vendor/github.com/colinmarc/hdfs/client.go:14:2: cannot find package "github.com/colinmarc/hdfs/v2/internal/protocol/hadoop_hdfs" in any of:
...
vendor/github.com/colinmarc/hdfs/client.go:15:2: cannot find package "github.com/colinmarc/hdfs/v2/internal/rpc" in any of:
...
Does this make sense?

@agnivade Thanks for your quick reply.
The step is as follows:

Create a project (named "temp") with a go file written as:

package main
import (
"github.com/xitongsys/parquet-go/ParquetFile"
"github.com/xitongsys/parquet-go/ParquetWriter"
)
type Model struct {
F1 string parquet:"name=name, type=UTF8"
}
func main() {
// Write
fw, _ := ParquetFile.NewLocalFileWriter("/tmp/test.parquet")
pw, _ := ParquetWriter.NewParquetWriter(fw, new(Model), 4)
stu := Model{F1: "f1"}
pw.Write(stu)
fw.Close()
}

Run "go get github.com/xitongsys/parquet-go/..." to get the required dependencies. Then you can get a lot of dependencies under "$GOPATH/src"

Run "go build" under our project. Then the building is OK.

Move all dependencies to "$GOPATH/src/temp/vendor".

Run "go build" again. Then the building is failed like:

vendor/github.com/colinmarc/hdfs/client.go:13:2: cannot find package "github.com/colinmarc/hdfs/v2/hadoopconf" in any of:
...
vendor/github.com/colinmarc/hdfs/client.go:14:2: cannot find package "github.com/colinmarc/hdfs/v2/internal/protocol/hadoop_hdfs" in any of:
...
vendor/github.com/colinmarc/hdfs/client.go:15:2: cannot find package "github.com/colinmarc/hdfs/v2/internal/rpc" in any of:
...
Does this make sense?

I did everything that is written in your instructions and probably realized what the problem is. Maybe you forgot to create a subfolder in vendor github.com. I create a subfolder that solved your problem.
├── main.go
├── temp
└── vendor
    └── github.com
        └── xitongsys

Thanks @wenkaler
But I think the dir structure should be (in my computer):
$GOPATH
|-- src
|-- temp
|-- main.go
|-- vendor
|-- github.com/
|-- xitongsys/...
|-- ...
I don't think I forgot the "github.com" folder.
Thank you anyway.

Thanks @wenkaler
But I think the dir structure should be (in my computer):
$GOPATH/src
|-- temp
|---- main.go
|---- vendor
|------ github.com/
|-------- xitongsys/...
|------ {other libs}/...
I don't think I forgot the "github.com" folder.
Thank you anyway.

Sorry, @ljr900723. I explain, temp is binary file program.

 …/go/src/temp: tree  -L 3
.
├── main.go
├── temp
└── vendor
    └── github.com
        └── xitongsys

 …/go/src/temp: ls -lah
total 16M
drwxr-xr-x  3 dmitriy dmitriy 4.0K Mar 14 18:00 .
drwxr-xr-x 10 dmitriy dmitriy 4.0K Mar 14 17:55 ..
-rw-r--r--  1 dmitriy dmitriy  388 Mar 14 17:57 main.go
-rwxr-xr-x  1 dmitriy dmitriy  16M Mar 14 18:09 temp
drwxr-xr-x  3 dmitriy dmitriy 4.0K Mar 14 18:00 vendor

Please correct me if I'm wrong, but this sounds more like a question that would be more appropriate for a forum, rather than a bug in go build.
Closing this issue, but please continue the conversation using the guidelines at https://golang.org/wiki/Questions or continue the discussion here.


Shared tooltip !

All info & code is the same as the previous PR but Circle CI got jammed up on that one, so I opened a new PR for it.

:rocket: PR was released in v0.19.0 :rocket:


Strings

Description of the tutorial
A tutorial folder on creating, accessing, and modifying strings in the c program.
Do you want to be assigned to work on this?
(mark [x])

[X] YES
[ ] NO

Optional: Any additional info you want to add
It could be divided into three files including one for creating, accessing and modifying strings in c program.

@sabderemane here is a new tutorial idea.  Would like to work on adding tutorials on strings. Your feedback and views on it.

You're assigned now @RR-08


What type of update are you requesting?
A new version of an existing package
Current Package Identifier
JetBrains.CLion
Package Version
2023.1.5
Please describe the changes you would like to see
https://www.jetbrains.com/clion/download/
currenly latest version is 2023.1.5

This issue has been resolved in #112593

Hi @cjwddtc
This issue should mark as complete.

Hi @cjwddtc This issue should mark as complete.
CC @stephengillie


[Test] Reduce number of infura calls

Stats on receipt tests for 10878 infura calls
Infura calls:  10878 {
      'eth_blockNumber_[]': 78,
      'eth_getBalance_["0x259ec51efaa03c33787752e5a99becbf7f8526c4","latest"]': 720,
      'eth_getBalance_["0xd3ced3b16c8977ed0e345d162d982b899e978588","latest"]': 3600,
      'eth_getBalance_["0x55985f5c5cc9cc1a4263feb11ab5a1d6cbef3bba","latest"]': 144,
      'eth_call_[{"data":"0x70a08231000000000000000000000000d3ced3b16c8977ed0e345d162d982b899e978588","to":"0x4aacb7f0ba0a5cff9a8a5e8c0f24626ee9fda4a6"},"latest"]': 2640,
      'eth_call_[{"data":"0x70a08231000000000000000000000000259ec51efaa03c33787752e5a99becbf7f8526c4","to":"0x4aacb7f0ba0a5cff9a8a5e8c0f24626ee9fda4a6"},"latest"]': 528,
      'eth_call_[{"data":"0xdd62ed3e000000000000000000000000d3ced3b16c8977ed0e345d162d982b899e978588000000000000000000000000dccf3b5910e936b7bfda447f10530713c2420c5d","to":"0x4aacb7f0ba0a5cff9a8a5e8c0f24626ee9fda4a6"},"latest"]': 2640,
      'eth_call_[{"data":"0xdd62ed3e000000000000000000000000259ec51efaa03c33787752e5a99becbf7f8526c4000000000000000000000000dccf3b5910e936b7bfda447f10530713c2420c5d","to":"0x4aacb7f0ba0a5cff9a8a5e8c0f24626ee9fda4a6"},"latest"]': 528
    }

After introducing json rpc interception:

Optimize request interception with in-memory cache:

puppeteer interception does not work with service worker requests
https://github.com/puppeteer/puppeteer/issues/4208
https://jarrodoverson.com/post/using-chrome-devtools-protocol-with-puppeteer-737a1300bac0/

More aggressive caching

local test passed, somehow github action kept failling. Switching to travis


[POC] composition in dockerfiles

fixes: 14124
Enable collapsing and including subimages in a dockerfiles
Signed-off-by: Sam Abed<EMAIL_ADDRESS>

ping @docker/core-maintainers

Thank you @samsabed! Unfortunately, I'm going to close this as a duplicate of #12749 (which isn't merge yet, but where some discussions are ongoing).

Sorry @samsabed , I'm closing this for it is a duplicate of #12749 :(
Feel free to add your feedback there or explain here why this PR is different.


Add default search for BrowseViews

For the person browse overview we use a special SearchBackendConfig. This is good and should not change.
However, the bread.views.BrowseView actually supports filtering via a URL parameter ("q" by default). This is currently not used anywhere.
We need to add support so that any browse view can have a simple default search. BrowseView.get_queryset has the filtering via djangoql implemented, this should be reused. We need to implement a configuration parameter so that a default SearchBackendConfig can be used for any view
An example use case would be the report browse view. Right now there is no way to search for the name of a report. After this is implemented, the report view should have a search-bar (via SearchConfigBackend) which allows to search by name. The browse view for reports should only need a small additional parameter to enable that search bar.
Important: This functionality should not use the resultcontainerid of bread.layout.components.search.Search but work via URL-queries and page reloads. It might be a bit challenging to implement this so that both ways work.

Done.

Done as in this PR #110

Moved from Test to Development because I got some comments from @saemideluxe to adjust something.

I have almost completed the default search box for BrowseView. However, I still encounter a problem distinguishing between the general search input box one and one that might appear in other places (like a navigation bar).

 Or maybe we should temporarily remove the default value based on the GET queries.

Okay for now


Replace "URL/url/redirection" with "link"

This is to match the terminology of the project itself ("Custom Links") and that of the "create new link" form.

Coverage decreased (-0.0008%) to 98.069% when pulling 7fa7ca9d7564da29579e8b9d93b4f3bece1c8040 on rename-url-to-link into f0580b01cdfe7bd183354804e998c17a2fbcd607 on master.

Coverage decreased (-0.0008%) to 98.069% when pulling 7fa7ca9d7564da29579e8b9d93b4f3bece1c8040 on rename-url-to-link into f0580b01cdfe7bd183354804e998c17a2fbcd607 on master.

Coverage decreased (-0.0008%) to 98.069% when pulling 01764d7cd2017597c64e40230c228efb2943eb89 on rename-url-to-link into f0580b01cdfe7bd183354804e998c17a2fbcd607 on master.


Write comprehensive control-plane PKI design doc

The past weeks have shown that the control-plane PKI is far from a finalized design. Many aspects has been discussed and lots of decisions have been made. To have them all in one place we need a comprehensive design doc that merges the basic (but outdated) description in the book with the various documents that have been produced in the past few weeks, and adds any missing points left.
Here is a collection of what has been written so far (some of the things might already be outdated):

TRC Design by @Oncilla: https://docs.google.com/document/d/1T5UMI6IZldaFXMpPYCmCgVqGWGc4O3jYewWHYejE6eA/edit?usp=sharing
Trust Verification Specification by @scrye: https://docs.google.com/document/d/1Nfw8RuF73x18fMefKwoPRHzenqbZDH0BlhV-p2xZNhY/edit?usp=sharing
Notes on validation by @scrye: https://docs.google.com/document/d/1X_mIfuXqF3fx8_2BT0-Lyu-eS33JOFa6irWtj_BDGTw/edit?usp=sharing

Comprehensive docs will be written as part of https://github.com/scionproto/scion/issues/1645 as the CPPKI gets finalized. Closing this as duplicate.


Logz Content Validation Issue for github.io website

Section link:

https://azuresdkdocs.blob.core.windows.net/$web/python/azure-mgmt-logz/1.1.0b1/index.html#indices-and-tables

Reason:
Link validation issue: Broken link.
Repro step:
When you open link1 and click the Module Index of the current page, it cannot display the correct page. The error message is as shown below:

@rohit-ganguly, @lmazuel for notification.

Close this issue as we'll put it into a summarzied one.


feat: discussions comments and user/discussions api

@StewartJingga yes we can do that too, no problem with that

@StewartJingga but after thinking again, I think better to keep it in its own package. Even if it is fully dependent, would that be a problem?

@StewartJingga I think better to keep it in its own package. Even if it is fully dependent, would that be a problem?
My concern is, we need to have discussion.DiscussionRepository and discussion.CommentRepository instead of discussion.Repository alone.

We can still keep discussion.Repository since the package name is discussion. Also we might not even need discussion.CommentRepository, we could have AddComment() method on discussion.Repository.
My concerns are:

Having comment as its own package could give a wrong impression that it is a standalone feature while it is not.
Having it under a discussion makes sense because they are the same domain and the hard dependency proves that.
Lastly (this is personal preference, can be ignored), discussion and comment are one feature and it feels good to know that we can port discussion feature to other codebase/module with just moving one folder (package/module).

Having comment as its own package could give a wrong impression that it is a standalone feature while it is not.
It wouldn't really matter whether it is standalone feature or not right? We better keep the domain as granular as possible. I don't think combining comment inside discussion would matter that much.

Having it under a discussion makes sense because they are the same domain and the hard dependency proves that.
Yes it does make sense but again I don't think having hard dependency would really matter here

Lastly (this is personal preference, can be ignored), discussion and comment are one feature and it feels good to know that we can port discussion feature to other codebase/module with just moving one folder (package/module).
I agree on this. But it is also would make it easier to copy comment package if we need comments feature only in other use cases.

Anyway, let me try updating it according to your sugggestion.

@StewartJingga comments moved to discussion package, please review it again stew :pray:


How to save licenses so that player can play local widevine content offline

Player request license information every time when player played widevine content saved locally.
If player do not request license information, the following error will occur.
Error Message:
Domain=ShakaPlayerErrorDomain Code=6008 "Shaka Error DRM.LICENSE_RESPONSE_REJECTED (Unknown internal error.)"
UserInfo={NSLocalizedDescription=Shaka Error DRM.LICENSE_RESPONSE_REJECTED (Unknown internal error.), ShakaPlayerErrorSeverityKey=2, ShakaPlayerErrorCategoryKey=6}

We have confirmed that player does not reacquire license information when playing widevine content downloaded with ShakaPlayerStorage.
We think this behavior is different from the #201 answer.
If player dont need to require license info with playing widevine content downloaded with ShakaPlayerStorage, is there a way to play without reacquiring license info like ShakaPlayerStorage do?

If you want to store offline content, you should use ShakaPlayerStorage.  You can't just store licenses to reuse them.  Using ShakaPlayerStorage will cause us to request an offline license and the CDM will store the license persistently.  We don't support requesting or reusing offline licenses for streaming playbacks.  See also google/shaka-player#1956.


Dash Provider

Tasks

[ ] Implement Dash Provider
[ ] Installation Docs (https://www.vidstack.io/docs/player/getting-started/installation)
[ ] Provider Docs (https://www.vidstack.io/docs/player/providers/dash)

References

https://github.com/Dash-Industry-Forum/dash.js
https://github.com/vime-js/vime/tree/master/core/src/components/providers/dash

Hey @mihar-22, is there any priority for this feature?

Not at the moment @iSuslov, we already have a lot to do and Dash is not the highest priority for us (at this time). Our player roadmap covers what we're focused on for future reference.

Any updates on this? Roadmap link no longer works

Looking for update here too! Need DASH if I'm moving over


Deprecating single hyphen refmt args

This aligns refmt parameters with GNU's recommendations of two hyphens (--) for long-form parameters.  We also additionally support two short-form parameters, -h and -i for --help and --interface.
This also defaults --interface to false; the biggest change here is that piping stdin from the terminal now assumes that it is not an interface unless explicitly told so.  refmt would fail out in this situation before this PR.
I have left support in for the old flags but now log deprecation messages to stderr.  This might cause some regressions if people are piping stdout to a file and not handling stderr.

Thank you for doing that!

Wonderful!

@jasonrose Thanks!

@jasonrose late, but thanks for the upgrade path. This ensured that nuclide isn't suddenly broken.


can't run examples

[bernardo@arch]: ~/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/Chapter1_Introduction>$  [bernardo@arch]: ~/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/Chapter1_Introduction>$ ipython notebook [TerminalIPythonApp] WARNING | Subcommandipython notebookis deprecated and will be removed in future versions. [TerminalIPythonApp] WARNING | You likely want to usejupyter notebook` in the future
Traceback (most recent call last):
File "/usr/bin/ipython", line 5, in
start_ipython()
File "/usr/lib/python3.6/site-packages/IPython/init.py", line 119, in start_ipython
return launch_new_instance(argv=argv, **kwargs)
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/lib/python3.6/site-packages/IPython/terminal/ipapp.py", line 300, in initialize
super(TerminalIPythonApp, self).initialize(argv)
File "", line 2, in initialize
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/lib/python3.6/site-packages/IPython/core/application.py", line 446, in initialize
self.parse_command_line(argv)
File "/usr/lib/python3.6/site-packages/IPython/terminal/ipapp.py", line 295, in parse_command_line
return super(TerminalIPythonApp, self).parse_command_line(argv)
File "", line 2, in parse_command_line
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 514, in parse_command_line
return self.initialize_subcommand(subc, subargv)
File "/usr/lib/python3.6/site-packages/IPython/core/application.py", line 236, in initialize_subcommand
return super(BaseIPythonApplication, self).initialize_subcommand(subc, argv)
File "", line 2, in initialize_subcommand
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/lib/python3.6/site-packages/traitlets/config/application.py", line 445, in initialize_subcommand
subapp = import_item(subapp)
File "/usr/lib/python3.6/site-packages/ipython_genutils/importstring.py", line 31, in import_item
module = import(package, fromlist=[obj])
ModuleNotFoundError: No module named 'notebook'
[bernardo@arch]: ~/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/Chapter1_Introduction>$ jupyter notebook
Error executing Jupyter command 'notebook': [Errno 2] No such file or directory
`

This is very much a 'dump your problems on the community' type report.

I wasn't blaming anyone.. I was just trying to get some help..
But alright, I'll close the issue.


update configs idenitfied during perf tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding pudl0124 metadata, improving error reporting for missing collections

Coverage decreased (-0.03%) to 99.97% when pulling 4e9b3db16d4231728a17c9514783ff5256222262 on pudl0124 into 9c7946b604759b86005b13e720507cf48671570d on master.

Coverage decreased (-0.03%) to 99.97% when pulling 20c4c096d2960d169adfd8b658c4b80e9595a238 on pudl0124 into aaccacb697727bcc8f24dc22c7b56d0c7ea6d0ac on master.

Coverage remained the same at 100.0% when pulling c1509670437d15f29ee9fa0b748a8a05fd996197 on pudl0124 into aaccacb697727bcc8f24dc22c7b56d0c7ea6d0ac on master.


bold rendering not working

The formatting samples page renders like this in github:

but like this in the demo (as viewed in my recent Firefox using Mac OS X 10.10.5):

On the other hand, the demo renders properly (shows boldface) in Safari.
(There is also a difference in darkness of H6, which I didn't show. It is gray (not black) in github rendering, but not in the demo rendering.)

I have a guess at a solution. I had a similar problem (since opening this issue) in trying to customize the default jekyll theme to use the 'Open Sans' google web font. After much experimentation and some web research I found out two things I needed to do to make it work:

tell google exactly which font weights I want -- I guess you are already doing that:

    <link href='http://fonts.googleapis.com/css?family=PT+Sans:400,700' rel='stylesheet' type='text/css'>
    <link href='http://fonts.googleapis.com/css?family=Open+Sans:300,700' rel='stylesheet' type='text/css'>

tell the browser exactly what I mean by 'bold', since Firefox and Safari seem to interpret it differently:
b, strong {
font-weight: 600;
}

(added to my _base.scss).
(The browsers may also differ in what they do if they can't find the exact weight you specify or the one they decide to look for -- I'm not sure.)
From searching for related things in your code, I am guessing you use this font:
$base-font-family: 'PT Sans', Helvetica, Arial, sans-serif;

but you might be specifying the weight for plain text as 300, and Firefox might be deciding to interpret bold as 400 (whereas Safari uses something bolder, or maybe synthesizes the bolder font), and then your link above which loads this font from google only loads PT+Sans:400,700, so in Firefox both plain and bold turn into 400. At least that was happening in my code at one stage, before I changed it to load 300,400,700.
(I didn't investigate anything about the H6 dimness difference.)

I'll look into this over the weekend, thanks for the report!

Same problem here, but with the default theme for Jekyll. My I ask how did you solve it for your website @oresmus?

@carlosgs I solved it as specified in my second comment above -- load the font weights I want, and add a rule to tell the browser to use those weights for bold (since otherwise Safari and Firefox use different weights, and if one is not found they might round it to one that is found, even if that's equal to the non-bold weight). Feel free to scan my code for details (probably searching for "font" and "bold" in all *.html and *.scss files will show you all relevant things), in case I forgot anything in my comment above -- but I don't think I had to do anything else, for that issue in particular.

Oh, sorry I'm as blind as a bat :scream: It works perfectly after adding the font weight to the _base.scss file, indeed. Thank you!! :-)


Created a dataset where the release_date is a numeric timestamp

Can you please replace the current dataset instead of adding a new one ? please.

It's done

Why do this new dataset have 6 times more lines than the old one ?

cat movies.json | jq '.[]' |jq -c 'try (.release_date |= if . == null or . == "" then . else (. | strptime("%Y-%m-%d") | mktime )  end) catch (.)'  >> movies_ranged.json
Added -c for minify version.
Since try and catch doesnt work on mapping function I had to append a file with each object.
Because of that, the final file is not formatted well.
Missing wrapping '[]' around all objects.
Missing comas after each object.
vim command to add a comma at the end of each object '%s/}/},/g'


Hit detection broken if view projection does not have an extent

Describe the bug
getFeaturesAtPixel and forEachFeatureAtPixel are attempting to get the extent width and failing if the view projection has been set up without an extent or simply uses the code from proj4.def
To Reproduce
Click on the map and see the error reported https://codesandbox.io/s/confident-mcnulty-s4v0n
Expected behavior
As in previous versions, it should not be necessary for projections to have an extent to be used in this way.

Thanks for reporting this, @mike-000. Would you be able to provide a pull request with a fix?


Test Syncing Settings Profiles

Refs: https://github.com/microsoft/vscode/issues/154243

[ ] win @rebornix
[ ] linux @roblourens
[ ] mac @isidorn

Complexity: 4
Create Issue

You can now sync settings profiles using settings sync. Test that profiles are getting synced correctly
Note: You can open VS Code Insiders on two different user data directories and extension directories and test syncing between these two instances.

Creating/Updating/Removing a profile is getting synced
Data in the profile is getting synced (Settings, Keyboard Shortcuts, Snippets, Extensions, Tasks & UI State)
You can disable syncing profiles by unchecking Settings Profiles entry after running the command Settings Sync: Configure
Test handling and resolving any conflicts in profiles data. You can create conflicts using following steps

Disable syncing Settings on one machine
Change the theme in different profiles
Change the theme to different value in other machine also
Enable syncing settings on first machine
This shall trigger conflicts

Please do exploratory testing by thinking about other scenarios

I updated the assignees so I get the mac, since my win machine is not corp joined so I can not login and turn on settings sync. Hope that is fine 😊

Works well. This issue makes the experience very hard for me https://github.com/microsoft/vscode/issues/161955

I'm testing across machines (Windows as my main device) but I didn't seem to get the settings to be synced. This is what I did

Create a profile on Windows
Change some settings
Switch to macOS
Force setting sync
Profile is fetched successfully, everything sets to default

Now that on my macOS, I have a fresh state but the settings changes on Windows are not synced to macOS, or vice versa. @sandy081 did I miss anything here?

This worked fine once, but I'm mainly blocked on #162051

@rebornix I am wondering if you have hit the same issue as @roblourens in the issue he created #162051. I just tried your steps (Windows <-> Mac) and sync worked for me. I think there could be an issue with settings sync server at that moment, can you please try to reproduce by enabling log level to trace and provide following logs

Settings Sync log
Shared Process network requests (see if there are any requests to settings sync server are hanging?)

@sandy081  I got this 405 error saying Last sync resource does not exist for my custom profile.
[2022-09-28 12:29:02.483] [settingssync] [info] Auto Sync: Triggered by Activity
[2022-09-28 12:29:02.484] [settingssync] [info] Sync started.
[2022-09-28 12:29:02.605] [settingssync] [info] Profiles: No changes found during synchronizing profiles.
[2022-09-28 12:29:02.643] [settingssync] [info] Settings: No changes found during synchronizing settings.
[2022-09-28 12:29:02.650] [settingssync] [info] Keybindings: No changes found during synchronizing keybindings.
[2022-09-28 12:29:02.657] [settingssync] [info] Snippets: No changes found during synchronizing snippets.
[2022-09-28 12:29:02.663] [settingssync] [info] Tasks: No changes found during synchronizing tasks.
[2022-09-28 12:29:02.669] [settingssync] [info] GlobalState: No changes found during synchronizing ui state.
[2022-09-28 12:29:02.671] [settingssync] [info] Syncing profile. jupyter-notebook
[2022-09-28 12:29:02.673] [settingssync] [info] Settings (jupyter-notebook): Not synced yet. Last sync resource does not exist.
[2022-09-28 12:29:02.731] [settingssync] [info] Request failed {"url":"https://vscode-sync-insiders.trafficmanager.net/v1/collection/0eb4a354-436d-4e40-b8a2-4d41ff366584/resource/settings/latest","status":405,"execution-id":"b8139f6f-74a4-4ee4-8208-d16ddf474316"}
[2022-09-28 12:29:02.736] [settingssync] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: Server returned 405
    at y.request (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:169412)
    at async y.readResource (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:163672)
    at async d.getRemoteUserData (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:32311)
    at async d._sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:22423)
    at async d.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:21523)
    at async p.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:145440)
    at async l.syncProfile (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135807)
    at async l.syncRemoteProfiles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135314)
    at async l.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:134810)
[2022-09-28 12:29:02.736] [settingssync] [error] settings: Server returned 405
[2022-09-28 12:29:02.738] [settingssync] [info] Keybindings (jupyter-notebook): Not synced yet. Last sync resource does not exist.
[2022-09-28 12:29:02.799] [settingssync] [info] Request failed {"url":"https://vscode-sync-insiders.trafficmanager.net/v1/collection/0eb4a354-436d-4e40-b8a2-4d41ff366584/resource/keybindings/latest","status":405,"execution-id":"b8139f6f-74a4-4ee4-8208-d16ddf474316"}
[2022-09-28 12:29:02.800] [settingssync] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: Server returned 405
    at y.request (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:169412)
    at async y.readResource (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:163672)
    at async d.getRemoteUserData (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:32311)
    at async d._sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:22423)
    at async d.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:21523)
    at async p.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:145440)
    at async l.syncProfile (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135807)
    at async l.syncRemoteProfiles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135314)
    at async l.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:134810)
[2022-09-28 12:29:02.800] [settingssync] [error] keybindings: Server returned 405
[2022-09-28 12:29:02.802] [settingssync] [info] Snippets (jupyter-notebook): Not synced yet. Last sync resource does not exist.
[2022-09-28 12:29:02.931] [settingssync] [info] Request failed {"url":"https://vscode-sync-insiders.trafficmanager.net/v1/collection/0eb4a354-436d-4e40-b8a2-4d41ff366584/resource/snippets/latest","status":405,"execution-id":"b8139f6f-74a4-4ee4-8208-d16ddf474316"}
[2022-09-28 12:29:02.932] [settingssync] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: Server returned 405
    at y.request (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:169412)
    at async y.readResource (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:163672)
    at async S.getRemoteUserData (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:32311)
    at async S._sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:22423)
    at async S.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:21523)
    at async p.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:145440)
    at async l.syncProfile (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135807)
    at async l.syncRemoteProfiles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135314)
    at async l.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:134810)
[2022-09-28 12:29:02.932] [settingssync] [error] snippets: Server returned 405
[2022-09-28 12:29:02.935] [settingssync] [info] Tasks (jupyter-notebook): Not synced yet. Last sync resource does not exist.
[2022-09-28 12:29:02.999] [settingssync] [info] Request failed {"url":"https://vscode-sync-insiders.trafficmanager.net/v1/collection/0eb4a354-436d-4e40-b8a2-4d41ff366584/resource/tasks/latest","status":405,"execution-id":"b8139f6f-74a4-4ee4-8208-d16ddf474316"}
[2022-09-28 12:29:03.000] [settingssync] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: Server returned 405
    at y.request (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:169412)
    at async y.readResource (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:163672)
    at async v.getRemoteUserData (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:32311)
    at async v._sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:22423)
    at async v.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:21523)
    at async p.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:145440)
    at async l.syncProfile (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135807)
    at async l.syncRemoteProfiles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135314)
    at async l.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:134810)
[2022-09-28 12:29:03.000] [settingssync] [error] tasks: Server returned 405
[2022-09-28 12:29:03.002] [settingssync] [info] GlobalState (jupyter-notebook): Not synced yet. Last sync resource does not exist.
[2022-09-28 12:29:03.171] [settingssync] [info] Request failed {"url":"https://vscode-sync-insiders.trafficmanager.net/v1/collection/0eb4a354-436d-4e40-b8a2-4d41ff366584/resource/globalState/latest","status":405,"execution-id":"b8139f6f-74a4-4ee4-8208-d16ddf474316"}
[2022-09-28 12:29:03.172] [settingssync] [error] Unknown (UserDataSyncError) syncResource:unknown operationId:unknown: Server returned 405
    at y.request (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:169412)
    at async y.readResource (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:163672)
    at async vt.getRemoteUserData (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:32311)
    at async vt._sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:22423)
    at async vt.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:21523)
    at async p.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:145440)
    at async l.syncProfile (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135807)
    at async l.syncRemoteProfiles (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:135314)
    at async l.sync (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:134810)
[2022-09-28 12:29:03.173] [settingssync] [error] globalState: Server returned 405
[2022-09-28 12:29:03.173] [settingssync] [info] Sync done. Took 690ms

@Tyriar May I know what does this mean

"https://vscode-sync-insiders.trafficmanager.net/v1/collection/0eb4a354-436d-4e40-b8a2-4d41ff366584/resource/settings/latest

405 implies method does not exist.

@sandy081 that means either the manifest or the collection does not exist for the user

I am not sure if this can be possible. @rebornix Lets sync directly to see if I can unblock you for testing.


Integration (cypress) test coverage

Acceptance criteria

[x] I can understand integration test coverage
[x] I have a coverage badge with percentage in the README

Tasks

[x] Review this doc https://docs.cypress.io/guides/tooling/code-coverage
[x] Implement in code
[x] Implment in CI
[x] Add the badge in the README

FIXED long time ago.


fixdisable nereids to test pr

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Upgrade Monocle?

Is there any plan to upgrade the Monocle package? version 0.0.1 does not compile with swift 2 compiler.
https://github.com/robb/Monocle/commit/2ef01aa0d3cc33f1a0aa6ba1e583c39a58aa1dbf

Thanks for reminding me about this, I will hopefully find some time for this soonish. Contributions are very welcome too! :)

@felixjendrusch sure! :D
I think you need to upgrade ValueTransformer first https://github.com/felixjendrusch/ValueTransformer/pull/4


Question, not a bug

Describe the bug
What's the best way to add "tools" as "file_search"? Simple question, tried various options but always got error saying expecting an object but found array or the other way round
To Reproduce
see code
Code snippets
$open_ai = new OpenAi('myOpenAiKey');

            $data = [
                'model' => 'gpt-3.5-turbo',
                'name' => 'test7cGPT35Turbo',
                'description' => 'my assistant descriptionB 35turbo',
                'instructions' => 'you should cordially help me',
                'tools' => ["type" =>"file_search"],
                'file_ids' => ['file-validFileID'],
            ];

            $assistant = $open_ai->createAssistant($data);

OS
PHP Apache
PHP version
PHP Version 7.4.33
Library version
3.5 - 2023-02-10 latest version including V2 assistants Beta:

Asking questions using issues doesn't seem efficient. Can we move this conversation to our Discord server?
https://discord.gg/xpGUD528XJ


drivers: flash: do not enable FLASH_MSPI by default

FLASH_MSPI should not be enabled by default.
Fixes #74349
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

looks like we have a fix already.. https://github.com/zephyrproject-rtos/zephyr/pull/74356


feat: Create Consequence Services

As per wireframes it should be similar to stops with two drop downs. The stops dropdown should not populate until the service is selected from the service dropdown then a user can select a value from the stops dropdown. When a service is removed all the stops associated should be removed.

I think this page needs the direction option according to AC7


Fix typ issue _computer_vision_client.py

Fix typ issue
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Thank you for the contribution.
Unfortunately, these files are generated automatically and we don't manually modify them.


Apps targeting Android 12

Manifest merger failed : android:exported needs to be explicitly specified for element <receiver#com.yc.video.old.other.NetChangedReceiver>. Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined

这是来自QQ邮箱的假期自动回复邮件。Hello, I'm busy now, unable to reply you timely


[song-directory-to-songbook] index sometimes points to wrong pages

[song-directory-to-songbook] index sometimes points to wrong pages

Apparently happens when index is more than 1 page long
Possibly can be fixed by simply adding an extra pdflatex at the end

Fixed via https://github.com/UC3Music/songbook-tools/commit/8aa30e3ae93c41d2e1fe543e5af97ae52ed7dcc8


Lucene.net + GrainServices

Two years later, a lot has changed.
I think Lucene and GrainServices will work better for this.
I will try to implement it.

Did you get a chance to do this? Where did you get to?

Work in progress :) Lucene relay have issues with performance

I am very curious to understand how you solved the problems I mentioned: https://github.com/OrleansContrib/Orleans.Indexing/pull/4
If you have a working solution I will send you a big gift ;)

@SebastianStehle
I have something here https://github.com/managed-code-hub/Orleans.Indexing
still in progress, but anyway it works


Provide a release tarball

It would be nice if you would consider adding proper source release tarballs,
as GitHub auto-generated tarballs are not immutable. This is an issue [1] for
operating systems creating packages for mmdblua. Thanks in advance.
[1] https://marc.info/?l=openbsd-ports&m=151973450514279&w=2

Yes, we don't have luarocks on OpenBSD, so we have ports for Lua modules. Packages are built from source tarballs, and checksums are performed on the tarballs, which is causing issues with GitHub auto-generated tarballs.

Have you considered using the .src.rock file?

I suppose it would be possible to use this as a fallback solution, but having a tarball would be easier than dealing with nested ZIP files :)

Ah I didn't realise it was nested.
FWIW, luarocks was the only supported compilation/installation for most of my lua projects; so providing a .src.rock file as the "source tarball" seemed like the simplest solution.
However this one is a simple project where there is no compile step; and installation is simply copying files to the correct location... which makes it tempting for maintainers to skip using luarocks.
Hrm. trying to think of the best way to integrate things into my release process.

FWIW I just tagged a v0.2 release.
How do you suggest I create the release tarball for you?
Is git archive enough? note that some tests require a git submodule.

I assume git archive is what's used to produce the auto-generated tarballs such as the one generated by triggering this URL? https://github.com/daurnimator/mmdblua/archive/v0.2.tar.gz
If so, that would be perfect, yes. You can simply upload mmdblua-0.2.tar.gz as a release asset. Thanks!

The git archive format is now stable (see discussion at https://www.mail-archive.com/aur-general@archlinux.org/msg33169.html), so this is not required.


Reports stopped working nothing is output running ember test

My options file is here: https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/tests/blanket-options.js
After I tag each release I run ember test then push the lcov.dat report up to code climate. my project is usually at 90-95% coverage, after I pushed it was at 27%. seems like it never finished writing the report.
So I deleted the lcov.dat file and ran ember test again but no file was written. I change the config from lcov to json but still no output, no coverage.json file written.
Its been working for me using the latest ember-cli 1.13.8 and node v4.0.0 / v0.12.2 ( I use nvm ).
Today the coverage report went missing so I tried switching back and forth between node versions and also ran my nombom to replace all the npm and bower modules. Still nothing.
I did add some tests since the last tag https://github.com/pixelhandler/ember-jsonapi-resources/compare/0.6.3...0.6.4 So I checked out the last tag 0.6.3 and the report is generated. So it seems that something about the new tests may be messing with the report. The main difference in my new test is using sinon mock server in pervious tests I was not using that.

I'm able to recreate this with your repo - will try to dig in to figure out where breakage is (and improve diagnostics) - might be a few days :-(

@pixelhandler If i .skip https://github.com/pixelhandler/ember-jsonapi-resources/compare/0.6.3...0.6.4#diff-e16d0508d82b53099bba5c4e58a82075R11 the lcov.dat is written.
I use sinon in my mocha test projects with no ill effects but haven't used the sandbox stuff.
It's possible that sandbox is mucking with the junit hooks - what I can tell is that when running 0.6.4 as is the POST with the coverage data is never being sent to the coverage middleware.

I think since i added a fake xhr in my test it blocks the request to write the report - so I can only mock specific requests, not all requests (allow /write-blanket-coverage to still work with XHR)

@jschilli forgot all about this convo. Thanks for helping :)


Theme: Crontab selection in scheduled backup

If you try to schedule a backup in Virtualmin and you open the complex schedule, the pop-up window isn't themed.

I know. It's in my to do. It's complicated to do. Will be there.
Upgrade to 18.00. Just out.

I just update and then noticed it.
Anyway, thanks!

It wasn't themed before, right?

No, it wasn't but I noticed it today for the first time, only after update the theme I tried that option

Version 18.01 made some things on that part of of the page look strange. I will fix it right away in 18.02.
Theming for all popup is comming in the future.

Please upgrade.


Cursor is invisible when adjacent to minimap with word wrap enabled

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:34:09.706Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

spellright
ban
1.0.27

python
don
0.6.9

cpptools
ms-
0.12.1

csharp
ms-
1.11.0

PowerShell
ms-
1.4.1

sort-lines
Tyr
1.3.0

If you have word wrap enabled, and move the cursor right to the end of the line, immediately next to the minimap, then the cursor becomes invisible.
Here is an example screenshot where the cursor at at character 79 and is visible.

Here is a screenshot where I've moved the cursor one position to the right, to character 80, and now the cursor is invisible.

Reproduces without extensions: Yes/No

@Eldaw From what I can tell from the screenshot, the word wrap is not turned on in your case, can you help confirm that? When the wordwrap is turned on, you are not likely to see minimap covering the code.

As I mentioned in the title and in the description, word wrap is on.
I have been able to work around this issue by making the entire application window a few pixels wider in order to create a small gap (less than the size of one character) between the end of the text and the start of the minimap.
So the issue is that it's possible for the application window to be sized such that there is no gap between the final visible character and the start of the minimap area, and in these cases there is no space for the cursor to be visible and so it isn't visible.
If you experiment with changing the width of the application window (by a pixel at a time if necessary), then you will also be able to reproduce this issue.


Unable to import workspace from file car_workspace.json

I'm trying to import the car workspace but I get the following error:
Unable to import workspace from file car_workspace.json. Error: {"error":{"intents":[{"examples":[{"text":["text can not contain the following characters: tab, new line, carriage return, slashes."]}]},{"examples":[{"text":["text can not contain the following characters: tab, new line, carriage return, slashes....
The same happens if I try to edit the "Car Dashboard - Sample" that is provided within the service and is available in the list of  workspaces
Not sure if this is relevant but I already have 2 workspaces created.

Yes this is a known error that we are addressing. @doconnor78 will you be able to update this workspace as well?

Is there any easy workaround ?

@leandrodvd There is an easy workaround, just search through the json and remove / and \ from the intent and entity training data. Please take a look at my pr:
https://github.com/watson-developer-cloud/car-dashboard/pull/74
It has an updated workspace with the fixes in place, feel free to copy that workspace instead:
https://raw.githubusercontent.com/watson-developer-cloud/car-dashboard/ad38bf588fda8041e22eced32d6166ddc5024715/training/car_workspace.json
@ttlew I've already put in a PR for this repo, awaiting access to the other repos to replicate the fix.

Fixed by @doconnor78


Telemetry Rules CRUD Integration Tests

Description and Motivation
Add integration tests for the Telemetry microservice. The tests cover the following:
On start, verify that default device groups are created by seed data.
Create:

Create rule with Instant calculation
Create rule with Average calculation for 1, 5, and 10 mins
Idempotent PUT rule by ID <-- there is a bug in the service and this test fails
Read:
Get rule by ID
Update:
Disable rule with PUT
Delete:
Delete rule returns OK

Change type

[ ] Bug fix
[ ] New feature
[x] Enhancement
[ ] Breaking change (breaks backward compatibility)

Checklist:

[x] All tests passed
[ ] The code follows the code style and conventions of this project
[ ] The change requires a change to the documentation
[ ] I have updated the documentation accordingly

Closing dupe of https://github.com/Azure/azure-iot-pcs-remote-monitoring-dotnet-tests/pull/30


JAMES-1823 quotaUpdater is invoked more than one time for a message addition or deletion

I'm not sure if my solution is appropriate and on the right direction from the perspective of the system and its architecture because I don't fully understand it. My purpose in the patch is not to register the same listener duplicately in an instance of DefaultDelegatingMailboxListener. For this, I've added some code and data structure for checking duplication. If my solution isn't suitable for the whole system, you don't have to use it.

In DefaultDelegatingMailboxListener, the intent was to add a business logic layer over listener lists, especially about updating stored listeners upon events.
In over worlds, there is no need to add logic for avoiding multiple storage of listeners as it is some tasks of underlying layers (not to mention that your implementation is not concurrent friendly, as applied at the wrong layer).
To obtain desired effect, you should modify type for globalListeners in MailboxListenerRegistry to ConcurrentSkipListSet or over concurrent friendly set datastructure.

After investigations, Collections.newSetFromMap(new ConcurrentHashMap<MailboxListener, Boolean>()) is better.

Thank you for your contribution @leepaul21 .
Sorry for not merging it sooner.
I'm looking to do a Marie Kondo on the PR's and clean them up.
Is this something that we can merge?
CC @chibenwa : Can you please give a hand?
If this is not an issue anymore, let's close it.

It had been adressed in another pull request, it is no longer an issue. We can safely close this.


Code Tidy: @JsonTypeName on API Command objects duplicates command names

noticed when doing a review we have code like
@JsonTypeName("dropIndex")
public record DropIndexCommand(

And we now have the CommandName enum, so we could do CommandName.DROP_INDEX.getApiName()
this ticket is to update the @JsonTypeName for all commands: collections, keyspaces, tables etc .

I looked into this, but unfortunately this cannot be done the way things are, because values for Annotation properties must be proper static constants. So, although it is possible to refer to Enum constants for Enum-valued Annotation properties, like hypothetical:
@MyAnnotation(commandEnum = Command.CommandName.AlterTable)

we can NOT, unfortunately, use
@JsonTypeName(Command.CommandName.AlterTable.getApiName())

(or, if it was public, field apiName).
We would need to add true (static) constants for names to refer to, like
public final static String COMMAND_NAME_ALTER_TABLE = "alterTable"

to do this. This might be doable so will play with the idea a bit.

@amorton Created minimal PoC pr (#1645) to show how this could be done, but wanted to confirm this makes sense (original approach is not possible with Java annotations, AFAIK).


Mazumder - Create FDA slides for monthly meeting

Adding sub-ticket for EQAPOL slide for myself

[ ] @penningtonea create EQAPOL slide due Friday 4/7


GitHub: search from actions

Just got another idea for the GitHub finder part:
if releases/tags exist but jars are not included, try to look for Actions that are related to the last commit there

There is one smaaaaaall problem here. Most assets in GitHub actions are archives, and there is no way to get individual files.

Ah yeah, good point.