Geocoding returning 0 values on lat/long

Describe the bug
I'm trying to use the Geocode Address function in the Dynamics 365 Workflow tools to geocode new addresses in my D365CE instance. I followed these instructions: https://github.com/demianrasko/Dynamics-365-Workflow-Tools/blob/master/docs/Geocode Address.md and got it to work correctly once, and now I'm only pulling back zeros.
The only difference between the example and my setup, is that I'm using dynamic values from the record (see screenshot). Again, it worked the first time I tested it, and then I have only gotten zeros back like it can't match the address.
The workflow shows as successful, but the data coming back from Bing is blank. I've tried verified addresses and even re-tried the one address that worked, but all I get are zeros. I tried creating a new Bing API Key, and still had the same behavior. Does anyone have any ideas about what could be going on?
Expected behavior
I expected to receive back the correct latitude and longitude.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 103.0.5060.134

CRM Version 9.2.22064.202  - online - WorkflowTools version: <IP_ADDRESS>

Hello did u fix that ?


Violation of PRIMARY KEY constraint 'PK__t4h_Docu__3214EC07B34ED974'. Cannot insert duplicate key in object 'dbo.t4h_Document'. The duplicate key value is (81)

This Issue was first reported on Orchard Core:
https://github.com/OrchardCMS/OrchardCore/issues/9088
In short:
Trying to create new Users in Orchard Core did not work and created the error and Stack-Trace reported to the ticket above.
Context:

Two Instances of Orchard Core were running at the same time on the same database, one of them in Visual Studio, one as a live preview.
Identifiers table seemed to have a value above max id of documents, but the ids causing this error were in the range below max id
After stopping both instances and just starting one, the system recovered after one insuccessful try.
Even after this one instance recovered, the inserted new ids were below max id and the nextval value in identifiers pointed to the same value as when the system did not work.
Obviously, as lower ids could be inserted, there are unused ids below max id in my documents table

Hypothesis

There is a mechanism (intended or not), that recovers unused ids below max id, but the ids that one instances claims in the range below max id are not represented in the database and therefore not communicated to other instances.

Version
In my Orchard Core Version <IP_ADDRESS> RC2 stable, the used YesSql still seems to be way below the current version.

As a reminder
In case the nextval of the Identifiers table was not updated correctly, we could take into account, at least on startup, the current max Id of the related document table, this to prevent to lease a new block overlapping existing Ids.

I don't agree. See the table name Primary Key constraint triggered here for the Docu ... ment table. So if you have 2 different Identifiers table and one that starts from an Id that is already taken in the Document table then it will trigger this Violation.

Repro steps
Create a new tenant using SQL Server with the "sa" user which should be in the "dbo" schema by default.
https://user-images.githubusercontent.com/3228637/147000330-1aba388b-16a8-4a01-a9b5-5765b30e9fdd.mp4
Here we can find the "sa" user on the database by looking at the "dbo" user. It's the defaults permissions set by SQL Server ...
Here is the setup screen of Orchard using the sa user in the connection string :

Once the setup is done you should get the database tables generated like these :

We can see that there is only one "Identifiers" table created from setup which is totally fine.
Now let's create a new user to assign to our database and that would also be an owner of this database.
We will create this users and assign him a different schema than "dbo" and for the exercice we will use "db_owner" as it should work too.

Now let's modify our database connection string in the appsettings.json file of our newly created tenant.

Now let's restart debugging in SQL Server to see if this works.

I'm getting this exception now because I forgot to assign the user membership on the database.

Now it's working because I affected the proper membership on the user :

But let's see if what it did to the database :

Now I have 2 different "Identifiers" table.
Et voilà! Repro steps 😄

Means that for SQLServer which should use a schema prefix for all queries. And would probably be in the configuration. Could be as part of the table prefix too, or on top of that since if would be {schema}.{prefix}{table} for Orchard. So maybe the dialect? Can it be specified in the connection string?

Quick answer is no for the connection string though will start reading this :
https://www.sqlshack.com/a-walkthrough-of-sql-schema/

PostgreSQL must have the same issue.
https://www.postgresql.org/docs/9.1/ddl-schemas.html

Easy fix, have a schema property in the dialect, use "dbo" as default, let users change it to something else if they need. Update the dialect to use the schema and the prefix when formatting the table name.


Sync with upstream

This PR contains recent changes from the upstream.

[x] I’ve added tests to confirm my change works.
[x] (If changing formatting output/API or CLI) I’ve added my changes to the CHANGELOG.md file in the Unreleased section.
[x] I’ve read the contributing guidelines.

Codecov Report
Base: 99.21% // Head: 99.21% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (1ad2b6a) compared to base (8554a22).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           ilyamatsuev/dev      #17      +/-   ##
===================================================
- Coverage            99.21%   99.21%   -0.01%
===================================================
  Files                    7        7
  Lines                 2690     2689       -1
  Branches               594      581      -13
===================================================
- Hits                  2669     2668       -1
  Misses                  20       20
  Partials                 1        1

Impacted Files
Coverage Δ

src/comments.ts
99.43% <ø> (-0.13%)
:arrow_down:

src/parser.ts
98.12% <100.00%> (+0.04%)
:arrow_up:

src/printer.ts
99.61% <100.00%> (+<0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


add file editorconfig

Add a editorconfig for python files patterns.

hey @icarodgl , thanks for the contribution
I don't know editorconfig file, can you explain us more? is in any way complementary or conflicting with #52 ?

This file is compatible with all editors, thus helping other contributors who want to use a different IDE.


Consider using python3Full for home-assistant

Issue description
Certain custom Home Assistant components, such as ble_monitor which I'm attempting to package require Python built with Bluetooth support (a.k.a. bluezSupport) which is present in the "full" flavor of Python, but not the default one in nixpkgs (python3).
I would like to suggest using pythonFull for home-assistant instead. Considering that home-assistant is already a large derivation with a closure size of around 800MB, this should hopefully not have too large of an impact:
$ nix path-info -Sh $(nix-build -A python312 '<nixpkgs>')
/nix/store/9yj3k8zvnb4pkbyjaxmb1wkn6ayrxvxy-python3-3.12.4       165.6M
$ nix path-info -Sh $(nix-build -A python312Full '<nixpkgs>')
/nix/store/52fcvpkl4cy8gz6qjxm0crfx2m4xgrdj-python3-3.12.4       187.0M

While one can always home-assistant.override { python312 = python312Full }, this results in having to rebuild all of H-A's Python dependencies, which may take up to multiple hours on modest hardware. My understanding is that if home-assistant used python312Full by default, Hydra would cache these and local rebuilds would not be necessary.

You might want to tag the maintainers of home-assistant

You might want to tag the maintainers of home-assistant

Ah, I meant to! :slightly_smiling_face: Thanks
/cc @fabaff @Mic92

Wondering if we should just override bluezSupport, so we don't pull in x11 dependencies onto headless systems. I'm also not fond of the increased build and review cost of an overriden python package.
I think the best course of action is to understand why bluezSupport is not available in the default interpreter, and see if we can work around that.

The dependency on bluez pulls in half the world, that in turn depends on python3, which makes including it by default a bit annoying:

asciidoc
audit
autoPatchelfHook
gtk-doc
itstool
libxml2
libxslt
meson
ninja
gobject-introspection
re2c
systemd/udev
xorg

Certain custom Home Assistant components, such as ble_monitor which I'm attempting to package require Python built with Bluetooth support

Is that because https://github.com/ukBaz/python-btsocket requires it?

I guess it actually comes from https://github.com/frawau/aioblescan/blob/ac9d567af997a1e9d9f9a18bc23b3295825fa823/aioblescan/aioblescan.py#L1691.
Could we replace that with a constant as in https://github.com/ukBaz/python-btsocket/blob/e1f8d0c5d3166295d91ab1f1e9c0ad7a0559ca3b/btsocket/btmgmt_socket.py#L7?

I guess it actually comes from https://github.com/frawau/aioblescan/blob/ac9d567af997a1e9d9f9a18bc23b3295825fa823/aioblescan/aioblescan.py#L1691. Could we replace that with a constant as in https://github.com/ukBaz/python-btsocket/blob/e1f8d0c5d3166295d91ab1f1e9c0ad7a0559ca3b/btsocket/btmgmt_socket.py#L7?

Yes, that is the problematic line.
2024-09-09 14:31:18.368 ERROR (Thread-2) [root] Uncaught thread exception
Traceback (most recent call last):
  File "/nix/store/04gg5w1s662l329a8kh9xcwyp0k64v5a-python3-3.12.4/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
  File "/var/lib/hass/custom_components/ble_monitor/__init__.py", line 630, in run
    mysocket[hci] = aiobs.create_bt_socket(hci)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/j5l7w60m47xxcz49z738rdjx6hkxw1xs-python3.12-aioblescan-0.2.14/lib/python3.12/site-packages/aioblescan/aioblescan.py", line 1691, in>
    family=socket.AF_BLUETOOTH, type=socket.SOCK_RAW, proto=socket.BTPROTO_HCI
           ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'socket' has no attribute 'AF_BLUETOOTH'

I would be quite surprised if this is the only reason we fail when Bluetooth support is not compiled-in, but I can try to patch this out and see if that works :man_shrugging: To be honest, I have close to zero knowledge in how Python / Bluetooth / Bluez interact, and why other software (or even other Home Assistant components) use Bluetooth just fine. I guess those might be using the D-Bus API instead of creating low-level sockets?

An update on the above: I patched out the constants that aioblescan was hard-erroring on:
diff --git a/aioblescan/aioblescan.py b/aioblescan/aioblescan.py
index 3845b91..b994eb4 100644
--- a/aioblescan/aioblescan.py
+++ b/aioblescan/aioblescan.py
@@ -28,6 +28,10 @@
 import socket, platform, asyncio
 from struct import pack, unpack, calcsize

+AF_BLUETOOTH = 31
+BTPROTO_HCI = 1
+SOL_HCI = 0
+HCI_FILTER = 2

 # A little bit of HCI
 HCI_COMMAND = 0x01
@@ -1688,13 +1692,13 @@ def create_bt_socket(interface=None):
     sock = None
     try:
         sock = socket.socket(
-            family=socket.AF_BLUETOOTH, type=socket.SOCK_RAW, proto=socket.BTPROTO_HCI
+            family=AF_BLUETOOTH, type=socket.SOCK_RAW, proto=BTPROTO_HCI
         )
         sock.setblocking(False)
         if platform.system() == "Linux":
             sock.setsockopt(
-                socket.SOL_HCI,
-                socket.HCI_FILTER,
+                SOL_HCI,
+                HCI_FILTER,
                 pack("IIIh2x", 0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF, 0),
             )  # type mask, event mask, event mask, opcode
             if not interface:
@@ -1712,8 +1716,8 @@ def create_bt_socket(interface=None):
             import ctypes, ctypes.util

             sock.setsockopt(
-                socket.SOL_HCI,
-                socket.HCI_FILTER,
+                SOL_HCI,
+                HCI_FILTER,
                 pack("IQ", 0x00000000, 0x2000000000000000),
             )  # type mask, event mask
             if not interface:
@@ -1729,7 +1733,7 @@ def create_bt_socket(interface=None):

             adr = SockaddrHci(
                 ctypes.sizeof(SockaddrHci),
-                socket.AF_BLUETOOTH,
+                AF_BLUETOOTH,
                 (interface + "hci").ljust(32, "\0").encode("utf-8"),
             )
             if (

but no luck, it is now probably hitting the root problem of bluetooth support not being available?
2024-09-23 14:40:55.495 ERROR (Thread-2) [custom_components.ble_monitor] HCIdump thread: OS error (hci0): [Errno None] error while attempting to bind on interface 0: None

@AndersonTorres Any chance we can get a bluezMinimal derivation, that does not depend on Python, so we can use it to build the standard python interpreter with bluetooth support?

Yep! Just send the patches!
Right now I am adopting and fixing httplib update: https://github.com/NixOS/nixpkgs/pull/343963
But I can look at Bluez more carefully asap.


Error codes

This would be the first step for #105, feel free to update the codes.
The derive macro to allow customizing those error codes is still pending.

Thanks, @lasantosr!
@jprochazk do you plan to merge this feature? Would be very useful for me.


[WIP] Enable source link

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Roslyn\Microsoft.Managed.Core.targets(90,5): error : SourceRoot items must include at least one top-level (not nested) item when DeterministicSourcePaths is true [C:\projects\newtonsoft-json\Src\Newtonsoft.Json\Newtonsoft.Json.csproj]

@ctaggart What is the cause of this error and how do I fix it?

I don't know. What is your environment? I know it requires .NET SDK 2.1 is required. Can you give me a msbuild /version and a dotnet --info for that environment?

Any just to make sure your git repo is normal, can you run git rev-parse HEAD & git config --get remote.origin.url?

MSBuild is <IP_ADDRESS>72
https://ci.appveyor.com/project/JamesNewtonKing/newtonsoft-json/build/1.0.1535#L231
I'm not actually building with dotnet cli.

C:\Development\Source\Newtonsoft.Json [jamesnk/source-link ≡]> git rev-parse HEAD
33d60e09415a79ba9d397c436938f466858deccc
C:\Development\Source\Newtonsoft.Json [jamesnk/source-link ≡]> git config --get remote.origin.url
https://github.com/JamesNK/Newtonsoft.Json.git
C:\Development\Source\Newtonsoft.Json [jamesnk/source-link ≡]>

Normal looking?

I updated dotnet CLI to latest just in case and still have the same error.
C:\Development\Source\Newtonsoft.Json [jamesnk/source-link ≡]> dotnet --version
2.1.301

I think you are hitting this bug: https://github.com/dotnet/sourcelink/issues/62
May be try setting DeterministicSourcePaths to false.

I opened up #1747 for that change to this branch. My build is still going, but I'm going to sleep:
https://ci.appveyor.com/project/ctaggart/newtonsoft-json/build/28

When adding SourceLink support to my library I just used the generated NuGet Package in a local folder NuGet Package Source and tested it with a new console app. I also temporarily renamed my repo folder so it wouldn't find my local files.

You can use dotnet sourcelink test:
https://github.com/ctaggart/SourceLink#test
Unfortunately, it is not working yet. Both of these fail:
dotnet sourcelink test "C:\Users\taggac\Downloads\Newtonsoft.Json.11.0.3-beta1.nupkg"
dotnet sourcelink print-json "C:\Users\taggac\Downloads\Newtonsoft.Json.11.0.3-beta1\lib\netstandard2.0\Newtonsoft.
Json.pdb"

Rather than adding /p:DeterministicSourcePaths=false to everything like #1747, It is probably better to follow https://github.com/dotnet/sourcelink/issues/91 by adding this to the WPF projects:
<DeterministicSourcePaths Condition="'$(EnableSourceLink)' == ''">false</DeterministicSourcePaths>

The dotnet sourlink tests pass with #1747 changes.

You can now install sourcelink as a global .NET tool
https://www.nuget.org/packages/SourceLink/3.0.0-build.732
https://natemcmaster.com/blog/2018/05/12/dotnet-global-tools/

It is probably better to follow dotnet/sourcelink#91 by adding this to the WPF projects:

There are no WPF projects.
What exactly is ContinuousIntegrationBuild and DeterministicSourcePaths? Why doesn't DeterministicSourcePaths work and what does setting it to false mean?
I don't like setting values without knowing what the cause and effect is.

Merged. Thanks for your help @ctaggart

do you have a preview/nightly NuGet Package to test this? On myget I also only see the 11.0.2.

https://www.myget.org/feed/json-net/package/nuget/Newtonsoft.Json

thanks. Works, I see the SourceLink entry in the PDB (with dotPeek from Jetbrains) and stepping through the code works fine in VS2017 15.7.4

What exactly is ContinuousIntegrationBuild and DeterministicSourcePaths? Why doesn't DeterministicSourcePaths work and what does setting it to false mean?

ContinuousIntegrationBuild is an indicator that the build is a CI build as opposed to a dev build. Targets may decide to behave differently when running on CI vs. local dev build. For example, when both Deterministic is true and ContinuousIntegrationBuild is true we enable DeterministicSourcePaths.
DeterministicSourcePaths causes the build to normalize all paths generated to the DLL and PDB to be deterministic - that is do not depend on the directory the source code was built from and the OS it was built on. Without this feature on the PDBs would include full paths like C:\MyRepos\Newtonsoft.Json\Src\Newtonsoft.Json\ConstructorHandling.cs. With DeterministicSourcePaths on the paths will be normalized to /_/Src/Newtonsoft.Json/ConstructorHandling.cs. You can see this happening in the SourceLink entry - since SourceLink needs to map the directory of the repository to the raw github URL it maps /_/*.
The reason why DeterministicSourcePaths is only switched on for CI builds is local debugging. If it was enabled when you e.g. F5 in Visual Studio the debugger wouldn't be able to find the sources as they do not exist at /_/* location on your dev machine and they were not pushed to the github repo yet, assuming you don't push every time you debug.

Looking forward to 11.0.3 being published :-)

I blogged about it:
http://blog.ctaggart.com/2018/06/newtonsoftjson-enabling-source-link.html


the server responded with a status of 413 (Payload Too Large)

Operating system : Centos 7

Laravel version : 5.6

Package version : 1.8

Steps to reproduce your issue : Uploading a file of 27MB. In php.ini I already sette that filesize limit is 100MB.

Screenshots of browser console :

I forgot to change upload_max_filesize, my fault.


Provide category headings for places

Variable names speak for themselves in most cases, but it would still be useful.
A proposal for a simple, usable format : categories.json.txt

Hi,
We're not completely understanding the issue you're bringing. Can you clarify?
There's a Places Category property in the model here: https://github.com/OvertureMaps/schema/blob/main/schema/places/place.yaml#L23-L36
Here are the categories used in overture: https://github.com/OvertureMaps/schema/blob/main/task-force-docs/places/overture_categories.csv

Hi
Right now i’m using :
category = category.replace("_", " ")

category = category[0].upper() + category[1:]

To get the categories names.
It would be nice to have them directly in github. The icing on the cake would be to have translations as well.

Hi @bjperson, I'm not exactly sure if this is what you're looking for but I posted https://github.com/OvertureMaps/schema/issues/40#issuecomment-1774972538 how to find the complete list of categories including alternates with an attached csv.

Hi there,
I was just thinking of something like an "assets" directory in the repository that would contain mappings between category IDs and their human-readable names.
That's the first need I had to display them to my users.
I've almost finished translating it into French, so I can put it somewhere :-)
It could take the form of a "fr.json" file in the format suggested in my first post.
But I don't know whether it should go in the "data" repository or the "schema" repository.


Error on deployment... worked well up until now

Hi! I've been using this package as part of my deployment process for some time now, today I got the following error when my pipeline ran...
/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2

TypeError: Cannot read properties of undefined (reading 'split')
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4450
    at Array.forEach (<anonymous>)
    at Object.229 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:43[19](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:20))
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at Object.976 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4805)
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9078
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9799
    at Object.<anonymous> (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:98[20](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:21))
    at Module._compile (node:internal/modules/cjs/loader:1105:14)

Hi! I've been using this package as part of my deployment process for some time now, today I got the following error when my pipeline ran...
/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2

TypeError: Cannot read properties of undefined (reading 'split')
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4450
    at Array.forEach (<anonymous>)
    at Object.229 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:43[19](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:20))
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at Object.976 (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:4805)
    at __nccwpck_require__ (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:8812)
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9078
    at /home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:9799
    at Object.<anonymous> (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:98[20](https://github.com/karfu-git/Laravel-Ingester/actions/runs/4233945900/jobs/7355630423#step:12:21))
    at Module._compile (node:internal/modules/cjs/loader:1105:14)

can confirm I'm experiencing same issue as well.

Same issue on my end

Using the version<EMAIL_ADDRESS>for now. Seems to be working fine.

Using the version<EMAIL_ADDRESS>for now. Seems to be working fine.

Well caught! Up and running again

Same is happening for me, suddenly the deploy stopped working

I'll check now

Update merged, check with @main or v4.1.5

Issue is auto closed with a merge, reopen if it still happens.

Can you please also add your setup / list of envs, so I can add this case in e2e tests

Can you please also add your setup / list of envs, so I can add this case in e2e tests

Sure, my set up is as follows...
SSH_PRIVATE_KEY: ${{ secrets.KEY }}
REMOTE_HOST: ${{ env.HOST }}
REMOTE_USER: ${{ secrets.USER }}
TARGET: ${{ env.TARGET }}

My remote host is an AWS EC2, if that helps at all, so just using the hostname for that particular parameter.
Thanks for looking at this so quickly!


Bug Report - Can't type pipe "|" and quick edit mode doesn't work

Environment

Microsoft Windows [Version 10.0.18362.175]
terminal version 0.2.1715.0

Steps to reproduce
I have a Canadian Multilingual keyboard ant to do a pipe symbol I have to use the right alt and the key before the 1 on a us layout I don't kown which one it is but on my keyboard is a slash (/).
Expected behavior
Able to write a "|" without pasting it and able to copy thing in the terminal window.
Actual behavior
The other bug I found is that I can't copy paste something. Normally, with quick edit enable you do select the text + "enter" or right click on the window title copy. The paste works.

Using AltGr for symbols is a dupe to #521.
Your copy/paste issues could be one of a multitude of things assigned to @carlos-zamora.
Please file one issue per bug that you find.
Please search for existing issues for your concerns before filing new ones.
Otherwise, thanks for your feedback. I'm closing this issue as it's duplicate data.


Docker build

I made a docker build script so one can do a quick deploy on a server for easier testing.
Dockerfile.txt
one flaw with this as is, the cargo build script wants to build gui side also and I didn't see how to tell it to not without a manual edit.
as such I included a cargo update line so if someone edits the build list it builds without throwing errors.

The Dockerfile attached above has a number of problems that needed fixing to get it to build against the current version:

Syntax tweaks: capital "AS" in the first line, etc.
Skip "cargo update" to avoid invalidating all subsequent layers. Use the locked versions of the crates otherwise. Update on the host side only when necessary, which will copy the result in with the COPY step.
Use explicit "fetch" to avoid redoing that work if the build step fails.
Put the result into the second stage's preexisting /bin dir, not a separate /app dir.
Most important, build only the server binary, not the GUI. The GUI should run outside the container. Without this step, you need to bring in a lot more dependencies into the first stage: fontconfig, freetype, expat, zlib…

Copy the text below into a Dockerfile at the Crusader root, then build with docker build --tag crusader .:
FROM cgr.dev/chainguard/rust:latest-dev AS build
USER root
COPY ./src ./
RUN cargo fetch
RUN cargo build --release --package crusader

FROM cgr.dev/chainguard/wolfi-base:latest
COPY --from=build /work/target/release/crusader /bin/
RUN apk add --no-cache libgcc

EXPOSE 35481
ENTRYPOINT [ "/bin/crusader", "serve" ]

I've added a Dockerfile to the repo for the server now.

It's not particular to Rust at all. Each command you give (RUN in this case) gets baked to an immutable layer. When you say:
RUN cargo fetch
RUN cargo build …

the fetch steps get saved to a single layer and are never repeated until one of the layers above changes, in this case most likely because the COPY src contents change, thus sending new Cargo.lock/toml files.
Doing it in two steps like this instead of depending on cargo build to do an implicit fetch saves repeated fetches while you're debugging a build problem.


Noticeable disparity in speed tests with official CLI

It seems that there is quite a big difference in speed tests from the official CLI app vs speedtest-cli...
pi@pi4:~ $ speedtest-cli --server 26195 --simple
Ping: 27.909 ms
Download: 28.65 Mbit/s
Upload: 38.15 Mbit/s
pi@pi4:~ $ speedtest -s 26195

   Speedtest by Ookla

     Server: Indinet Service Private Limited - Kolkata (id = 26195)
        ISP: Siti Networks
    Latency:     1.77 ms   (0.30 ms jitter)
   Download:    66.46 Mbps (data used: 112.8 MB)
     Upload:    97.67 Mbps (data used: 130.0 MB)
Packet Loss:     0.0%

Sounds good.


ENH: Allow the build, test, package workflow to be triggered

Allow the build, test, package workflow to be triggered: remove the unnecessary braces around the workflow file variables.
Update the workflow file to match the latest ITK version as well as the remote modules' latest recommended versions.

@thewtex @dzenanz Any idea why the build, test, package Actions is not being triggered?

Build failures are due to ITKVtkGlue module being missing. Not so familiar with how this can be solved. VTK has also gone some mayor refactoring in its CMake discovery mechanism from 9.x, and I do not know if ITK has been able to accommodate to the changes. Maybe @phcerdan knows better/can suggest a solution.

Build failures are due to ITKVtkGlue module being missing. Not so familiar with how this can be solved. VTK has also gone some mayor refactoring in its CMake discovery mechanism from 9.x, and I do not know if ITK has been able to accommodate to the changes. Maybe @phcerdan knows better/can suggest a solution.

The dependency on vtkglue could be removed if the curvature filter is ported to itk.

The dependency on vtkglue could be removed if the curvature filter is ported to itk.

@samuelgerber thanks for chiming in ! In the meantime, maybe we'd need to figure out how to tell our CI builds to configure and build with the ITKVtkGlue module. I'm not sure how easy this is/have seen other remotes facing the same issue, and I do not recall having seen a solution (e.g. such as setting the Module_ITKVtkGlue to ON in the remotes). But let me know if you find the way.

Building VtkGlue in remote CI tests should be possible. Before build ITK step add a "build VTK step", and then add  -DModule_ITKVtkGlue:BOOL=ON and -DVTK_DIR:PATH=/path/to/vtk/build to ITK configure line.

This is an improvement as is, so merging.


[GHSA-9pgh-qqpf-7wqj] Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom

Updates

Affected products

Comments
Maintainer has merged https://github.com/xmldom/xmldom/pull/441 which backports the fix to 0.7.x branch and released as 0.7.6.
Updated changelog: https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md#076
Hopefully this would resolve the dependabot alert generated for this to allow for 0.7.6 to be considered as a fixed version as well, thanks.

Hi there @karfau! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

I'm not sure the claim is correct.
Would the update still make clear that the following version range is still affected: >=0.8.0 && <0.8.3?

Hi there @karfau! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@karfau I've fixed it now and have updated the summary details as well

Looks good to me. But I'm not familiar with the syntax of the json file.

I thought about it a bit more and updated the "Patched version field to the following semver range: ~0.7.6 || ~0.8.3 || >=0.9.0-beta.2.
The affected Range is now set to <0.7.6 || 0.8.0 || 0.8.1 || 0.8.2 || 0.9.0-beta.1.
I also updated the advisory description to reflect the fix for 0.7.6.

@bchew should I file another PR to update the description and also the CVSS vector and base score, which I took from https://nvd.nist.gov/vuln/detail/CVE-2022-37616.

@karfau thanks for getting the change in, the dependabot alert has been resolved for us with the upgrade to 0.7.6 🙂
This actually started when I used the Suggest improvements for this vulnerability link at https://github.com/advisories/GHSA-9pgh-qqpf-7wqj - which then automatically created this PR, this whole workflow is new to me as I have not done this before 😄
Did some brief digging and It looks like there is some syncing which happens between the repository advisory and the global one? https://github.com/github/advisory-database/commits/main/advisories/github-reviewed/2022/10/GHSA-9pgh-qqpf-7wqj/GHSA-9pgh-qqpf-7wqj.json So I am unsure if you would need another PR if you have already updated it in the repository..
Appreciate your efforts in maintaining xmldom! 🙂


Adding Javaprinter

Hi André,
found your awesome dockerfile - thanks for all the work you've done here so far.
Did you manage to setup Ordersprinter on Docker with the JavaPrinter, too? I'm currently struggling to set this up in addition.

Hi!
I do not use the javaprinter. But that shouldn't be a problem to move that to a separate container. What is your problem? Do you have Linux or Windows as your host? Do you have some stuff already?

Hi,
Thanks for your reply. In the meantime, I found a working solution that fits my need. In case any other users stumble upon this issue:
In our environment the OrderSprinter instance is running as as compose stack in portainer (using this template file, thank you!) and is publicly accessible in the internet through a proxy host in the nginx proxy manager.
In the Store there is a local windows Client on which the OrderSprinter PrintServer for Windows is running locally. This PrintServer is connected via http and prints out the receipts issued by the server instance.
It is important to notice that the PrintServee isn't capable of using HTTPS protocol, so in the proxy configuration you have to disable the force-ssl setting.
We're requested a SSL certificate in addition, so the mobile users can connect via HTTPS. We also set up an access control list via basic Auth in NPM to secure the connection to the OrderSprinter Instance as good as possible.
The information, that the PrintServer isn't supporting SSL at the moment is quite hidden in the documentation.
So, as this isn't an issue of this template, feel free to close this issue. Thanks!


Failed to add timing to MEI 3.0 files

Hi,
I've been happily working with the output after working through my problems from this issue: https://github.com/music-encoding/encoding-tools/issues/14
As a follow-up, I now want to run the meiAddTiming.xsl on the output.
I get the following error:
Saxon evaluation license expires in 11 days
The source file is not a 2013 version MEI file!
Error at xsl:message on line 272 of meiAddTiming.xsl:
  XTMM9000: Processing terminated by xsl:message at line 272 in meiAddTiming.xsl
Processing terminated by xsl:message at line 272 in meiAddTiming.xsl

Is there a way I can get around this? I don't see a way to downgrade from MEI 3.0 to MEI 2013 in order to run this process.

I mainly want to add the tstamp attribute to notes and rests. If using the xsl isn't possible, is there another way it might be possible to achieve this?

I'm currently bypassing the problem by removing the version check and this seems to work! Hopefully the output data is ok…

@odub: As you've discovered, the encoding tools have not been maintained as rigorously as they should be.  None of them come with a guarantee of fitness. 😃

To verify that removing the version check actually works, you should validate your output against the latest schema.


Remove Bodies from {:extern} functions

According to the people at AWS we can supply java files on the command line to Dafny.  This means they are then included in the compilation process.  That should, in theory, resolve the issue around functions with {:extern} bodies allowing us to remove an existing problem (#271).

@hmijail This will affect the Go build if it works.  It will also mean I can finally drop the /noExterns command line option, therefore paving the way to the new cli style.  I will try to get it working on the Java side today.

Argggh.  There are still problems of course!!!!  In particular, my default implementation file refers to Java dependencies.

So I need a default implementation which is an interface of some kind which contains a default dummy implementation that can be overriden.  How exciting.

Or another option is to inject lambdas, which would then remove any need for any {:extern} function.

So, I have a solution on the java side.  This would then need a port for the Go side.  However, a neater solution would be to solve it all in Dafny using lambda's.  Therefore, I'll explore this now that I know I have at least one workable solution.

Using opaque functions could be important here.  I wonder whether lambda's can be annotated?  If not, I suppose the dispatcher function could be.


Fix nix-build

Continued from #228.

I will update stack.yaml to point to the Kadena fork instead of mine once that PR is merged because stack doesn't fetch all refs and so isn't seeing it yet.

\o/

My theory is that the network tests are especially slow when using nix-build on macOS, and it's possible for a network request to be made before the server has properly started, which leads to a cascading test failure.

We saw something similar in other project - networking tests were uniquely slow on Mac. It was fixed by adding threadDelay calls at strategic places, @marklnichols would know more.

We considered using threadDelay here too but instead chose to do something more principled that actually confirms that the server is up before continuing.

This PR's name is incorrect now, as it depends on https://github.com/kadena-io/pact/pull/235.

Most of the delays/waits have been replaced with retrys with some ultlimate timeout value.  This avoids having to guess the right wait amount.  Its working in Stack, but the nix build is failing intermittently -- still not sure why.

Maybe the tests are especially slow under nix-build? https://github.com/kadena-io/pact/pull/236 should help make them faster, but I split that out into a separate PR because it's not strictly necessary.

I have noticed them go much slower under nix, yes. Especially on Mac.

@fosskers I remember hearing that sandboxes in macOS may perform poorly - if you're doing local builds and aren't too concerned with security/reproducibility, you might want to consider disabling sandboxing in your /etc/nix/nix.conf and see if it speeds things up.

^ @mightybyte


port to modern world

Changes:

upgrade postgres to use the psycopg 3 driver
skip mssql when not odbc driver installed
remove aiopg (no real update for 2 years) and better alternatives available
use hatch environments
use hatch test and fmt commands
use mariadb instead of mysql (fixes memory exhaustion)
use iterate for fetch_all (chunking would be nice)

TODO:

remove cruft
update ga actions
investigate appearing testsuite file
fix/replace scripts

nice, the failing tests were gone

I think I have an ok. Let's merge.


BUG: wide_to_long modifies stubnames

This is not a serious issue, but the list of stubnames passed into wide_to_long is modified by the function call.
INSTALLED VERSIONS
commit: None
python: 2.7.6.final.0
python-bits: 64
OS: Linux
OS-release: 3.13.0-43-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
pandas: 0.15.1
nose: 1.3.1
Cython: None
numpy: 1.9.1
scipy: 0.14.0
statsmodels: 0.5.0
IPython: 1.2.1
sphinx: 1.2.2
patsy: 0.2.1
dateutil: 2.3
pytz: 2014.10
bottleneck: None
tables: None
numexpr: 2.2.2
matplotlib: 1.3.1
openpyxl: 1.7.0
xlrd: 0.9.2
xlwt: 0.7.5
xlsxwriter: None
lxml: 3.3.3
bs4: 4.2.1
html5lib: 0.999
httplib2: 0.8
apiclient: None
rpy2: 2.5.2
sqlalchemy: None
pymysql: None
psycopg2: None

>>> import pandas as pd
>>> df = pd.DataFrame([[0,1,2,3,8],[4,5,6,7,9]])
>>> df.columns = ['id', 'inc1', 'inc2', 'edu1', 'edu2']
>>> df
   id  inc1  inc2  edu1  edu2
0   0     1     2     3     8
1   4     5     6     7     9
>>> stubs = ['inc', 'edu']
>>> df_long = pd.wide_to_long(df, stubs, i='id', j='age')
>>> df_long
        inc  edu
id age
0  1      1    3
4  1      5    7
0  2      2    8
4  2      6    9
>>> stubs
['edu']

Thanks for the report! I reproduced this with 0.15.2.
If you're feeling up for it, would love to get a PR with a fix. Should be pretty simple, I think.

Sure, I can do this. I'll submit by the end of this week.

closed by #9215


add tailwind elements to component collections

General

✏ Mark the necessary items without changing the structure of the PR template.

[x] Pull request template structure not broken

Type

ℹ  What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Fix
[x] Feature

Checklist

ℹ  Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉  Put an x in the boxes that apply.

[x] Title as described
[x] Make sure you put things in the right category!
[x] Always add your items to the end of a list

Open Source

[x] Link description does not contain a link to an author / third-party resource
[x] The documentation (README) contains a description of the project, illustration of the project with a demo or screenshots and a CONTRIBUTING section
[x] The documentation is in English.
[x] The project is active and maintained.
[x] The project accepts contributions.
[x] Not a commercial product

Apps/Websites

[x] The website is available without errors or ssl certificate problems, and load in a reasonable amount of time.
[ ] The website is using vuejs intensively. It should detect vue with vue-devtools.

If you cannot detect vue with vue-devtools due to work at non public pages (e.g. for enterprise website), you can send Pull Request with screenshot that detected it.

[x] The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.
[x] A commercial product using Vue, provided that guests could reasonably check out how Vue was used (i.e. A headless CMS which uses Vue for the Admin/editor Area and offers a free tier).

Thank you. Also look into making a resolver to make it easy to include in vite projects here: https://github.com/antfu/unplugin-vue-components#importing-from-ui-libraries


Owners Can't Star their Own Projects, but they can if they are under an Organization you own/manage

Is your feature request related to a problem?
Currently, starring your own projects is disabled. However, you can star projects under organizations that you own, which is almost the same effect.
Describe the solution you'd like.
Either allow us to start our own projects, or disable starring projects under organizations that you own (possibly also if you are an admin of).
Describe alternatives you've considered.
No current Alternatives
Other

I think its fine to star your own project. Github also lets you do that also

https://github.com/HangarMC/Hangar/commit/3704cdf46bb6e33ee52c7dd4bc5e51a8e9b04767


Git: Provide better filter on git checkout quick open

We use lerna for publishing our components to registry.
Every publish it creates a tag for every component.
When we try to find a branch from command line we should scroll huge amount of time through tag list to find a branch.

@budarin I'm not sure I understand the issue you report. Can you please add a gif recording to this issue?

/needsMoreInfo

I'm sorry - I cannot create gif but I have an image

You can just change the Checkout Type to "remote" in the git settings.

but I need to view local branches !
It doesn't solve the problem (

I want to discover what branches are - I don't know their names

The "remote" options shows local branches too. It ignores only tags.


Wrapper command fails with "local.properties" - no such file or directory

Hello!
When the wrapper upgrade creates a new PR, the wrapper command fails with the following message:
* What went wrong:
/home/runner/work/my-wrapper-upgrade/my-wrapper-upgrade/build/git-clones/MyProject/local.properties (No such file or directory)

This is happening because my local.properties file is NOT tracked in git (and it should NOT be).
Could you provide a way for us to run a small script which could be run after cloning and before wrapper command  (or at least a way to create these files empty)?
I actually have multiple *.properties files and the wrapper command fails for all of them.
The temporary solution was to add empty *.properties files but that creates many other problems, every time when I want to do a commit, which are part of the reason why these files should NOT be tracked in git.
Thank you!

Hello, can't you just add those properties file to .gitignore?

@alextu are you part of the plugin's development team?

@alextu I could see you are then let me explain:
I wrote "...my local.properties file is NOT tracked in git..." which means it is in .gitignore.
When ./gradlew upgradeGradleWrapperMyPrj command is executed, it will clone project MyPrj which does not have local.properties file since is not in git (due to being added to .gitignore).
After that the command ./gradlew wrapper --gradle-version=<latest_gradle_version> will run in the cloned repo. This comand will fail because it will do a gradle sync first, which requires local.properties to be present.
In my worflows I am running a small script which is creating the local.properies file just before running any gradle command.

I am using this plugin on at least 4 Android projects without any problems.
A "Gradle sync" is not a concept of Gradle itself but by IntelliJ and the Gradle integration.
Gradle of course runs a configuration phase of your project. If your project requires at this time a local.properties file you might see this error.
The problem might not be because of the plugin nor should it provide some hook/action to do  something before it got executed (IMHO). Rather you should check and adjust your project that it doesn't require a local.properties file at configuration phase.
Does this make sense?

@StefMa in those 4 Android projects, do you have the local.properties pushed (tracked) in the git repository?

Of course the local.properties file is not committed in those.
You can check https://github.com/ioki-mobility/TextRef together with that project https://github.com/ioki-mobility/GradleWrapperUpgrader
The first one is an android project while the second one uses this plugin.
Don't be confused that this lifes in another repo, it's just because the plugin is outside of the main project. But literally it doesn't matter where it is. It also works if directly added to the android project.
You have to check yourself which (maybe) custom task requires the local.properties to be available. Without sharing your project it is hard to help for me.

Thank you @StefMa for the hints and for the links to the repositories. Your answer pushed me to dig more where is that problem coming from and I found the reason and the proper way to fix it.
So I will close this ticket since it is not valid anymore.
Thanks a lot guys! <3


Manjaro install steps

Hi,
These are the install steps to enable it on my machine. Does it make sense to have in the README?
sudo pacman -S openblas lapacke cblas
phpize
./configure
make
make install
cat > /etc/php/conf.d/carray.ini <<EOF
extension=carray
EOF

@fabiomontefuscolo thank you, we sure can use it. Please submit the changes on https://github.com/phpsci/phpsci-carray/blob/master/docs/index.md instead of README because later all install steps will be moved to the docs.
Congratulations and thank you for figuring this out. I will close the issue for now and after your pull request I will link both

@fabiomontefuscolo thank you, we sure can use it. Please submit the changes on https://github.com/phpsci/phpsci-carray/blob/master/docs/index.md instead of README because later all install steps will be moved to the docs.
Congratulations and thank you for figuring this out. I will close the issue for now and after your pull request I will link both


Modify card and deck-level commands, update userguide, developerguide

Block card-level operations while user is not inside any decks
Block deck-level operations while user is inside a deck
Update project portfolio
Update user guide, developer guide

Pull Request Test Coverage Report for Build 452

13 of 20 (65.0%)  changed or added relevant lines in 10 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 83.728%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/DeleteCardCommand.java
1
2
50.0%

src/main/java/seedu/address/logic/commands/DeleteDeckCommand.java
1
2
50.0%

src/main/java/seedu/address/logic/commands/EditCardCommand.java
1
2
50.0%

src/main/java/seedu/address/logic/commands/EditDeckCommand.java
1
2
50.0%

src/main/java/seedu/address/logic/commands/ExportDeckCommand.java
1
2
50.0%

src/main/java/seedu/address/logic/commands/ImportDeckCommand.java
1
2
50.0%

src/main/java/seedu/address/logic/commands/NewDeckCommand.java
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/model/Anakin.java
1
80.77%

src/main/java/seedu/address/logic/commands/NewCardCommand.java
2
88.89%

Totals

Change from base Build 450:
-0.3%

Covered Lines:
1873

Relevant Lines:
2237

💛  - Coveralls


Support for Sonoma

I don't think Sonoma is stable enough until now, so I didn't try to Update to Sonoma


Idiomatic addition circuit

This is a proof of principle, re: #957

There's really no problem working with 5,000+-bit bloqs (and their decomposition) if they're written with a bit of care.
It's an incredibly simplifying assumption that we can expect to be able to do one level of decomposition without blowing our runtime/performance budget

(this bloq is a proof of principle I whipped up quickly. It would need to be integrated into the existing addition bloq. It's missing the first- and last-bit carry eliminations and the final cnots)

What's the issue with the existing adder? In my defense this is a holdover from very early cirq_ft so I'm totally on board with improving it

Tanuj said decomposing a 5000 bit Add takes 2 minutes. For me, it just crashes my machine with a recursion depth exceeded

The timing information is inaccurate in my original post. I need to time the whole cell. It's 1.03s (715ms without the binst graph part)


Use Tempo 2.6.1

Last two versions use a Tempo version with this issue and it was fixed in 2.6.1, see https://github.com/grafana/tempo/releases/tag/v2.6.1

Sorry, I just saw the PR that has not been merged yet. Feel free to close it.

pr is merged


program crash when i decompile .exe

Boomerang crash when i try to decompile and get the source code. Why. The problem is at last because i almost get the code.

Label this with "needs more info".

@JustGregory Thanks for the reminder
@Omardavinci  as the label says, we're going to need some more information about that crash:

What kind of executable are you trying to decompile (platform/ file format etc.) ?
Is this a freely available executable we can download and test ourselves ?

This sounds similar to what I experienced myself in #44 . I still need to remember to compile with debug symbols and add more informative output.
As Nemerle mentioned above, having the executable available to test would help. And which platform is Boomerang running under itself?

This could be the same problem I ran into in my environment (Debian 9, gcc 6.3.0, Qt 5.7.1). Some of the full_regression tests (e.g. pentium/switch_gcc) blow up in the final stage with the following error:
terminate called after throwing an instance of 'std::bad_weak_ptr'
what():  bad_weak_ptr
Aborted
I was able to work around it by changing this line in chllcode.cpp:
     case opIntConst: {
-        int K = exp.access<Const>()->getInt();
+        int K = exp.toString().toInt();
         if (uns && K < 0) {

This should be fixed in the current develop version, so I'm closing this. Please open a new issue if Boomerang still crashes.


Make API for accessing dedicated for plugin storage

I plan to add a type-safe listing by directories (to limit where plugins can change / delete / create files and improve the experience when used.).
There probably would be:

StorageElement: the root of any storage element.

EmptyStorageElement: element that does not have file / folder created.

createNewFile(): creates new file at current path.
mkdir(): makes dir on current path.
mkdirs(): makes dirs up to current path.

File: just file

write(ByteArray): writes bytes to file.
write(String): writes string to file.
readBytes(): ByteArray: reads bytes from file.
readString(): ByteArray: reads bytes from file.

Directory: just directory

operator get(String): gets child from current path. Returns StorageElement.


Adding support for pinning notes or adding favorites

Users can either pin notes that the deem important to the top or make then favorites which will also show those notes at the top.

Pin sounds better @Kayvee08

So should we add option to pin (important) notes ?

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.
Is the ideas feasible @Kayvee08 @serrq ?

What is the milestone for this feature? 1.6.0?

It will be 1.7.1 ig

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

Yeah right.
What do you think is this idea good or you can tell what you want to do

@aritra-tech bottomsheet is a good idea, but will see how others are incorporating this feature in terms of accessibility and UI.

Hey @serrq is the idea good to go that I have shared.

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.
Is the ideas feasible @Kayvee08 @serrq ?

This idea that I have told is okay for you? @serrq

Hey @Kayvee08 then that's the final idea lets work on it.
All the best

Okay, will start working on it @aritra-tech

is anybody looking into this ??, (Since #214 is not merged yet)

No @purushyb if you want you can pick it up

Hi @aritra-tech Can I look into this as well? Seems no one has provided an acceptable solution yet.

yeah please @andy-ife

Alright. Will keep you posted. Hoping to get my first gh contribution lol

Hmm. What do you say @aritra-tech

Hey @MianMuzammil67 sorry but @andy-ife is working on it
@andy-ife please continue

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.
Is the ideas feasible @Kayvee08 @serrq ?

This idea that I have told is okay for you? @serrq

@aritra-tech I'll go with this implementation if that's alright

All done @aritra-tech . Pull request #540

I will look into the changes and merge the PR @andy-ife
Thank you


Use Internal Mesos Task Status Case Class Model Instead of Protobuf Model

There is a lot of logic in the test code to craft Mesos task status because the Protobuf builder is a little cumbersome. We should introduce an internal case class model. This makes dealing with the status easier and is robust against changes to the proto buf model similar to internal models of AppDefinition and PodDefinition converted from their raml counter parts.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4143. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4143. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Update MCPI Modded code

oh @mobilegmYT there is problem that we are re-writing our ui so you can put a large description but for now please use the old description


Request | model outputs for Gigawords and CNN-DM test sets

Hi folks,
Thanks for releasing the code and checkpoints.
I'm doing some analysis on the model generated hypothesis.
If you have the model outputs for the Gigawords and CNN-DM test sets, could you please share them?
Regards,
Priyam

@priyamtejaswin Hi Priyam, we can share the outputs via email. Thanks!

Hello, our group also want to study the UniLM-Large outputs of GigaWord, however the given code failed due to cuda version. Could you sent it to<EMAIL_ADDRESS>

Hello, our group also want to study the UniLM-Large outputs of GigaWord, however the given code failed due to cuda version. Could you sent it to<EMAIL_ADDRESS>
@StevenTang1998 Replied via email.

Thanks for your help.


Consolidation on the "Summary" section

(1) The "Disk validation" section is moved up, right below the "Summary" section and is called "Prerequisites". Reason: It is so important that must not be buried. (2) Consolidated all elements of what MBR2GPT can do under a pre-existing bullet list and removed repetitions. (3) Created a list of what MBR2GPT cannot do.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Hi @skycommand.
The location\consolidation changes will be reviewed in a while. Knowing that a list of what MBR2GPT can't do is needed is great feedback. We'll review that as well.
As for the stylistic changes - that's the personal preference of the writer, and I don't see a reason to prefer one way over that other. In some case, these changes are inconsistent with the language used in the rest of the library. With that in mind, stylistic changes won't be implemented.
Thank you for your contribution.

Some of the stylistic changes are an improvement, others are not. We shouldn't call things folders when referring to a command prompt. They are directories.  When we say the app can be forced to run under the full version of Windows I think this is because it's necessary to add the "-force" option.

@greg-lindsay  Hi. Your point about "folder" is probably fair. But, skipping the prerequisite change and the list of what MBR2GPT cannot do, AFAIK that's the only style change I made. (Your point about "forced" is actually my contribution, not my deviation.) So we are left with:

Removal of "command prompt": That was factually inaccurate. One can run MBR2GPT from PowerShell or even from Run... dialog box. Since Windows 10 is bringing PowerShell to the front-line, this "command prompt" restricting elements is definitely taken to mean "but not from PowerShell!"
Addition of "the": It is a grammar point. Name of computer software, web services, software components and software technologies (which are all products of a source code) need no definite article only if they appear alone, e.g. "I run Windows". But a descriptor makes "the" necessary, e.g. "I run the Windows operating system." Hence, it is either "GUID Partition Table" or "the GUID Partition Table partition style".

There is of course the sentence "You can use MBR2GPT to perform the following" which I turned into "MBR2GPT can perform the following". If you don't consider it part of the consolidation efforts, yes, it can be seen as both another style change or a semantic change. "You can" is a meaning-restricting element that reduces accuracy: Not just you, but anyone or any non-human entity can do this with MBR2GPT. Still, since the reduction in accuracy is negligible, it leaps to the eye that avoiding second person pronoun in technical articles is a well-established matter of style.

Hi - I am reviewing the changes again now that I'm in the office.
I like the idea of moving the disk validation section up and renaming it to prerequisites, and I've done this.
Specifying "the" Master Boot Record partition style instead of just saying Master Boot Record is a solid correction.
I thought I had written "forced to" run but I see this is a requested addition. I was going to change that phrasing if I had written it, so I'll do that now by adding something more specific to the end of the sentence.
The next set of changes aren't really needed for clarity but I see that Windows 10 was used twice here so one instance should be eliminated (I had written a Windows 10 computer running Windows 10, which is a silly typo due to rewriting that sentence improperly).
The edit "MBR2GPT can perform the following" is too anthropomorphic.
The next change is good because it points out that the two bullets are essentially saying the same thing. Originally the two statements were different but an edit made them the same. I should have gone back and rewritten this so it wasn't redundant. However, the proposed changes are not correct because data disks are not supported. This gives me an opportunity to rewrite this section and point out that fact. Non-system disks might be supported in the future. We should not refer to disks as "arbitrary."
Thanks for all the suggestions on this page.  I am pushing out a rewrite today.

Also, in reference to running MBR2GPT from a PowerShell prompt. It's probably possible to do it. You would likely need to escape some of the command line parameters. It isn't the proper way to run a command line tool. The proper way to run a command line tool from PowerShell is to preface it with cmd /c which essentially runs it from a command prompt within PowerShell.

@greg-lindsay Sounds like you've approved most of my changes by now. I can only be happy.
On a second thought I agree: The word "arbitrary" is wordiness. I could simply write "Convert a disk without a Windows operating system." Of course, on the same vein, "data disk", which you suggested, would be wordiness too.
You say "perform" is anthropomorphic? Well, try search it in the Corpus of Contemporary American English (COCA). Sorry for not posting a link; COCA is a web app and is not link-friendly. Anyway, the word "performance" is vastly used by Microsoft. Why not "perform"?

@skycommand I want to just say again that I really appreciate all the suggestions you had. The changes have improved the article and fixed some silly errors, so thanks a ton!
W.r.t. perform it is just something my editor hammered into me when I started as a writer. Other writers might not have gotten the same advice, so it's possible you could see an application performing actions in some other articles.  But for a moment let's assume that a picture was hung in the hallway. Did a hammer hang the picture, or a person? This is obviously stretching the concept, but you get the idea. The article is extolling the virtues of MBR2GPT so it might be OK to talk about all the actions it can perform without sounding odd, but I like to place the power per se on the person using the tool rather than the tool itself. It's a minor point for sure.

@greg-lindsay Oh, yes. I remember that certain trend you are talking about! (With a pang of nostalgia.) It was wrong to say "armies will shatter, worlds will burn!" because neither do armies shatter for no reason nor do worlds burst into flames spontaneously. It was correct to write "armies will be shattered, worlds will be burned" to imply that we are deliberately withholding the subject of these heinous misdeeds. (Alternatively, include a subject and write in active voice.)
But this is no longer the tradition these days. The counterargument put forth today is that "you don't see 'spontaneously' in the original sentence, hence your assumption about it being there is your own. The sentence simply says 'armies will shatter' and does not explain why." I sincerely suspect this has come from Wikipedia. You see, there is a lot of pressure on editors there to neither assert nor imply something outside facts and not to use weasel words either. So, they write in active voice using intransitive verbs just to report the fact. "In 1998, two of the jungle areas burned." We don't know why and it does not matter, so the writer didn't imply or assert it as a heinous misdeed or otherwise.
As for the "Did a hammer hang the picture, or a person?", please be careful: there is a metonymy hidden in there! It can induce wrong conclusions. A hammer has a tiny but important role in a whole procedure leading to a picture being hung on a wall. MBR2GPT pretty much does everything; the only role a human has in it is giving the order.

You bring up some interesting points. This reminds me of an editorial change where I pushed back heartily. Consider these two similar sentences:
You can convert a system disk from MBR to GPT by using MBR2GPT.
You can convert a system disk from MBR to GPT using MBR2GPT.
Of course there are other options such as using "with" but let's ignore that for now. Which of the two do you prefer and think is correct? I preferred the second one as a general rule, but my editor had added "by" to every instance of "using" in an article I wrote several years ago.
The difference comes down to where you assign the power. To assign power to the tool, you say "using X you can achieve the impossible." To assign power to the user, you say "by using X you can achieve the impossible."
Usually I just go with what sounds better and don't think about it too much.
In the current doc I ended up removing the word "perform" and just saying you can use MBR2GPT to: (list).
I appreciate the discussion.


Google plugin update

Hi, could you try to just upload the changes to see what are the real changes on the code. thanks

Wow. How it happend?
Ok, I'll try


JayHorn crashes on trivial program

When trying to verify
public class Test {
    public int main(String[] args) {
        throw new RuntimeException();
    }
}

I get
2016-09-14 18:11:37,344 ERROR (main) [root] - java.lang.ArrayIndexOutOfBoundsException: 0
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 0
	at soottocfg.soot.memory_model.PushIdentifierAdder.addToPushesAndPulls(PushIdentifierAdder.java:53)
	at soottocfg.soot.memory_model.PushIdentifierAdder.addIDs(PushIdentifierAdder.java:41)
[...]

At that point, it is assumed that there is 1 entry point to the program. It looks like this somehow passes the earlier check and we end up with a program without entry points in the PushIdentifierAdder.

I'm adding sth to fail early right now


Enable Rosnav Agent Deployment

@tuananhroman pls  resolve conflicts

Conflict resolved, you didn't change anything in pedsim_manager except for formatting, right @tuananhroman ?

Also snuck in .rosinstall changes)

Conflict resolved, you didn't change anything in pedsim_manager except for formatting, right @tuananhroman ?

Yes, correct.


Move config/variables to a separate file.

No other changes made beyond moving the current variables/configuration into a separate config.js file.

Woah. My fault. Looks like I crossed up a couple of branches I had.
I updated the Gulpfile.js to use the lowercase version of config.

If there's a better way of handling this, I'm all for it!

Thanks for the PR @JeremyEnglert — I just tested it and merged it with the new branch. Way to go!


Improvement: Graphviz Collapsible Groups

How about adding a flag for graphviz output, that would show a graph of groups instead of layers? Therefore allowing for a higher-level graphical overview of the system.

Please, not yet!

Not a core issue/enhancement, moved to separate repo of my extensions instead.


Scroll if needed

Why do we implement our own scrollIfNeeded (https://github.com/phosphorjs/phosphor/blob/master/src/dom/query.ts#L89) instead of using the browser's scrollIntoView (https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView)?
Alternatively, I think the scrollIfNeeded algorithm could be improved by following (maybe with a threshold?) the spec for scrollIntoView: https://drafts.csswg.org/cssom-view/#element-scrolling-members

Our implementation is closer in behavior to this:
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded
Which is not widely supported by browsers.

If you can get scrollIntoView to behave like our scrollIfNeeded across browsers, I'm happy to ditch our version.

and scrollIfNeeded does take a threshold option, so I'm not sure I follow you on that part.

If you want, we can implement the algorithm with a threshold, if it's needed. I only see one place where it is used, and that doesn't use the threshold.

I still don't follow. The third argument to scrollIfNeeded is an optional threshold. What are you asking for here?

Our implementation is closer in behavior to this:
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded

Ah, then our implementation is buggy, in that it doesn't take into account the element width.

Bug is a strong word :) It's working as designed, but is only designed to scroll vertically: https://github.com/phosphorjs/phosphor/blob/master/src/dom/query.ts#L92-L95

I still don't follow. The third argument to scrollIfNeeded is an optional threshold. What are you asking for here?

I'm saying we could implement the algorithm in scrollIntoView, but with a threshold. Separately, I'm questioning the need for a threshold parameter, since it doesn't seem to be used, at least in this repo.

There's lots of functionality in this repo which is not used by the repo itself :) It was easy enough to add a threshold, which I knew would be a command request, so there it is.

Bug is a strong word :) It's working as designed, but is only designed to scroll vertically: https://github.com/phosphorjs/phosphor/blob/master/src/dom/query.ts#L92-L95

Even vertically, it has problems and is scrolling unnecessarily. For example, see https://github.com/jupyter/jupyterlab/issues/478.

PEBCAK - you're calling scroll into view on the wrong node.

It was easy enough to add a threshold, which I knew would be a command request, so there it is.

Easy enough, I know. I don't have your foresight that it will be requested, though, and saw it as a premature customization. Hence my questioning it...

You are asking it to scroll the large container node into view, instead of the element with focus. Call scrollIntoView on the input node, and I'll bet you'll see better behavior.

The point is that if you are asking a node that is larger than the viewport to scroll into view, and it's already in view, scrollIfNeeded, as implemented, will unnecessarily scroll so the bottom is aligned with the bottom.

Yeah, I realized that as soon as I typed my response.

The algorithm for scrollIntoView correctly handles this case where the element is larger than the viewport.

Yeah, I realized that as soon as I typed my response.

:)

I'm happy to submit a PR, though.

n.b., Here's a bit of background history.
scrollIfNeeded is used in a few spots in JupyterLab. We added it into phosphor so we wouldn't have to keep repeating ourselves when we switch over to mono-repo. The threshold argument doesn't exist in the JupyterLab versions, but since we were making it available to all future phosphor users, we decided it would be good to add that argument even though it's not being used.
For example, if you consider the notebook/widget version:
https://github.com/jupyter/jupyterlab/blob/master/src/notebook/notebook/widget.ts#L998-L1006
... you'll see that threshold was hard-coded. We decided to make that an argument instead in the phosphor version.

you'll see that threshold was hard-coded

Dummy me wasn't seeing it in the code I was originally looking at - thanks for pointing out at least one place it was being used. I'm still not sure it's a good idea to have the threshold. What was the problem without the threshold, and is it fixed if we implement a proper scrollIfNeeded?

I'm working on a PR.

cf #126

I don't remember what the original reason for the threshold was, I'm afraid.
The native scrollIntoView might actually be sufficient.

The problem with the native scrollIntoView is that several browsers don't support the options argument, which is what we need to get the "if needed" part of the behavior.

Oh right, good call, that was the catch.

Yeah, agreed that if we need the IfNeeded part, we'll have to implement our own.

Perhaps the threshold accounted for padding/border in the elements? In other words, if my element is padded by 10 pixels, then I'm okay with it being actually 10 pixels off screen...

I assume that's exactly the sort of reasoning that went into it, but I can't say so authoritatively.

fixed


plots: smoothing

Our default plot is not very informative when the number of data points is huge (1k):

We need to introduce some smoothing into the default plot or create a new smoothing template. The result should look like:

PS: I've done the last plot by adding loess transformation to the template which breaks the revision. We need to fix the revision or find another solution.
    "transform": [{
        "loess": "<DVC_METRIC_Y>",
        "on": "<DVC_METRIC_X>"
    }
    ],

Wrong project :)
Moving to core DVC.


test: test custom types ABI generation

This PR implements tests for the custom types generation from the ABI.
It also specifies that structs inside enums and enums inside structs are not yet implemented.
This is part of solving #6.

Passing CI :tada:

Marking as draft because I need to refactor extract_struct_name_from_abi_property


--output option?

I am using racon 1.4.21
I noticed that racon writes output to stdout.
If I redirect the output to a file I find that lines that are not fasta output are included.
See below for an example.
How about a --output option to get the fasta output while error or log messages are still send to stdout?
[racon::Polisher::initialize] loaded target sequences 0.068443 s
[racon::Polisher::initialize] loaded sequences 0.790975 s
[racon::Polisher::initialize] loaded overlaps 0.619227 s
[racon::Polisher::initialize] aligning overlaps [=>                  ] 0.273249 s^M[racon::Polisher::initialize] aligning overlaps [==>                 ] 0.273304 s^M[racon::Polisher::initialize] alignin
[racon::Polisher::initialize] transformed data into windows 0.078060 s
[racon::Polisher::polish] generating consensus [=>                  ] 1.051718 s^M[racon::Polisher::polish] generating consensus [==>                 ] 1.054752 s^M[racon::Polisher::polish] generating co

contig_1 LN:i:961746 RC:i:563 XC:f:0.989605
TCGCCAAGCTGCGCCTGCTGCTGGTGGAGGAGAAGGCGCGCGGGCTCGGCGTCGGCCGCGCCCTGGTCGAGCAATGCATCCGCGCCGCGCGCGAGAAGGGCTACAAAAAGATGACGCTGTGGACCCAGAGCATCCTGGTCGCCGCGCGCGGCATCTACGCCCGCGCCGGTTTTCAGCGGGTGAAAGAAGAGAAGCATCACAGC

Hello,
the log messages are sent to stderr, while the FASTA is sent to stdout. You can split them with racon <params> > out.fasta 2> log. Hope this helps.
Best regards,
Robert

I had tried that, but it didn't work for me.
I am running racon in a docker image:
docker run --rm -it -v $PWD:/mnt -w /mnt racon:v1.4.21 racon $FASTQ ${OUTPUT}/aln.sam $ASSEMBLY > racon.out
I can grep out the Polisher message lines from racon.out and produce a proper fasta file.
But I think racon would be easier to use if we have an output file option.

I solved my issue: I needed to run docker without the -t option, then stdout and stderr are separate again.

I am glad that it works :)


Update virtual-machines-linux-create-upload-vhd-redhat.md

More minor grammar updates.

Hi @JasonMAnderson, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (janders). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


flexget: 3.9.1 -> 3.9.3

Diff: https://github.com/Flexget/Flexget/compare/refs/tags/v3.9.1...v3.9.3
Changelog: https://github.com/Flexget/Flexget/releases/tag/v3.9.3
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250450 run on x86_64-linux 1

2 packages built:

flexget
flexget.dist


Pretrain weights

Thank you for code sharing! Could you please share current weights from imagenet? I plan to fine-tuning process on my task. So for my purpose none-final weights would be fine.

@N01Z3 The training is ongoing because of GPU resources. Once I finish, I will upload the pretrained model. Thank you for your interest.

@N01Z3 I have upload the pretrained model of SE-Resnext 50 on imagenet. Thank you for your interest.


Gravity vouchers

Issue vouchers to addresses sending funds which can be burned when they actually leave the ecosystem.

@byte-bandit is this okay to close?


[KAFKA-17030] Unattached voters will fetch from bootstrap voters

Voters should not assume that the leader will send them BeginQuorumEpoch requests - see https://issues.apache.org/jira/browse/KAFKA-17030 for more details.
If a voter is removed by the leader and hasn't replicated its own removal record yet, this change will help Unattached rediscover the leader (since the leader will not be sending BeginQuorumRequests to nodes it thinks are non-voters).
We can potentially prevent disruptive elections by these removed voters - before this change, unattached voters will sit for ~electionTimeout and then become candidates and start a disruptive election.
Pre-vote would prevent this disruptive election - but when implementing pre-vote we will then need a similar change to have nodes in Prospective state continue fetching from bootstrap servers/last known leader to prevent Prospective from becoming a terminal state.
Followers have a similar issue - if they are unable to communicate with the leader they should try contacting the bootstrap servers since they can't assume the leader will send beginQuorumRequests to them.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Discussed with @jsancio, voters that are followers should also fetch from bootstrap voters. Currently, if they are unable to reach their last known leader, they will transition to candidate without attempting to fetch from bootstrap voters

cc @jsancio

btw, noticed this comment (carry-over from when VotedState was a distinct state)
https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/QuorumState.java#L411-L412
I just want to confirm we do want Unattached nodes who have already voted to fetch from bootstrap voters? If so I will remove this comment

I just want to confirm we do want Unattached nodes who have already voted to fetch from bootstrap voters? If so I will remove this comment

It makes sense to me that replicas that voted should continue to fetch from the bootstrap server or leader until a leader is found. Again, I think that that comment made since when voters were static. Now that voters are not static, replicas cannot assume that the voter set is the same across all replicas in the cluster.


Open Access Week 2024

https://www.openaccessweek.org/
"Community over commercialization" for the second year in a row.

What stakeholders supercede the shareholders?

Happy to support people running events but we cannot commit to running things ourselves at this time (as we're already stretched with time/resources for ResearchEquals 2.0 etc.).


Cannot drag and drop data source object to the main view using VS2022.

Try to follow the steps of this tutorial but step 4 of the data binding section was not successful. Dragging the data source object to the main window view does nothing. This step actually works in VS2019 and VS2017.

@hal10091 -- thank you for your feedback.  Which docs.microsoft.com article are you following?  Meanwhile, please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

Duplicate of #7579.


Chapter 10: crud-service in collection.json missing the schema

I have written the crud-service schematic in Angular 14 so this may probably be an issue related to the Angular version, I thought of mentioning it since it took me a while to find the solution and I am afraid others could also struggle with it
After creating the crud-service schematic I kept getting the following error:
   Error: Unknown argument: name

But everything I wrote was the same as the code in this repo, the only way I could find to fix it is by adding @schematics/angular to the schematics project dependencies and then update the collection.json file in the following way:
    "crud-service": {
      "description": "Generate a CRUD HTTP service",
      "factory": "./crud-service/index#crudService",
+      "schema"<EMAIL_ADDRESS>    }

I assume that now Angular prevents unspecified options to be provided or something of that sort? :thinking:
Please let me know what you think :slightly_smiling_face: (and if you believe I am missing something)

(PS: very minor, I also noticed that the template for the schema is importing Observable rxjs, but it is not actually using it)


Storage: Fix page_id being mis-reuse when upgrade from cluster < 6.5 (#9041) (release-7.1)

This is an automated cherry-pick of #9041
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflash/issues/9039
Problem Summary:
https://github.com/pingcap/tiflash/issues/9039#issuecomment-2108567189
The root cause is:

When the cluster upgrade from version lower than v6.5.0 to higher or equal to v6.5.0, TiFlash will try to migrate the data from PageStorage V2 to PageStorage V3.
When the table has no data in the delta layer, it will run under PageStorage V3 mode
But we get a wrong max_id for this situation, we must use max_data_page_id = std::max(data_storage_v2->getMaxId(), data_storage_v3->getMaxId()); to avoid the page_id from being mis-reused. Otherwise it will cause data corruption and make tiflash fails to restart in the next restart

https://github.com/pingcap/tiflash/blob/eb6272c66624da39cde5e3b8605982a6db437de1/dbms/src/Storages/DeltaMerge/StoragePool.cpp#L518-L520
What is changed and how it works?

In StoragePool::restore, after "meta" and "data" transformed into PSV3, update the max_id by the maximum of that id in PSV2 and PSV3
Review other codes that call raiseXXXPageIdLowerBound()
Add unit test case

Check List
Tests

[x] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)

Deploy a cluster with tiflash replica and load some data, the cluster version < 6.5.0
Before upgrade, alter table ... compact tiflash replica to make the table has no data in the delta layer (this raises the possibility of the bug happening)
Upgrade the cluster to a version >= 6.5.0 and write more rows into table, then alter table ... compact tiflash replica
Restart the tiflash instance

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Fix the issue that metadata may be corrupt and make tiflash panic after upgrading from a cluster less than v6.5.0

/run-all-tests


Dependency upgrade and compat' with new tc-platform 1.0.8 beta and new monitoring service

:arrow_up: Compat' with new tc-platform 1.0.8 beta and new monitoring service
Depends on:

[x] Terracotta-OSS/terracotta-platform#163
[x] Creating tc-platform release 1.0.8.beta2

This PR should build when tc platform release 1.0.8.beta2 will appear in maven repository.

test this please

test this please

test this please


to_tensor and pil_to_tensor inconsistency

to_tensor uses from_numpy which never copies and always returns a CPU tensor. But pil_to_tensor uses as_tensor, which would return a CUDA tensor if the default tensor type is changed by the user (e.g., https://github.com/pytorch/pytorch/issues/39088). I think a discussion on what the correct behavior is is needed, followed with a patch to make the two functions consistent.

Hi Simon,
That's a good question, and I had a quick look at the linked discussion to get some more context.
In principle, I think that the current design of the DataLoader with multiprocessing is not ideal to support tensors being passed on the GPU (but I might be wrong).
This makes me think that we might want to enforce in torchvision that pil_to_tensor always returns a CPU tensor, but that can also be contradicting the contract of setting the global default device to be CUDA.
Thoughts?

I agree what the DataLoader is best suited to load CPU tensors. However, loading CUDA tensor is one of the things we support too, and unfortunately it seems that the DataLoader is one of the easier ways in PyTorch to do so.
However, I am hesitant to say that these methods should respect default_tensor_type, for potential BC reasons as to_tensor has existed for a long time. One common case should be that user (on Linux) sets default_tensor_type to CUDA and the forked DataLoader workers calls ToTensor().
Maybe we can specify in docs that these methods / classes move to CPU by default, and introduce an device= argument? :)

Personal opinion is to have a quick fix by forcing cpu tensors, which is a bug fix. And things will work without exceptions. Of course it might be specified in the documents.
The capability to load gpu tensors for multiprocessing could be discussed as new features, since it seems to require more efforts.

Loading to GPU is and has always been supported. It’s not a new feature.

Loading to GPU is and has always been supported. It’s not a new feature.

I'm not quite sure about that? Is their any way to use DataLoader to load data to GPU? Currently, when I set num_workers=0 or spawn start method, I still get CPU tensors based on what you have illustrated.
If I use Dataloader, I need to transform them to cuda manually. If I want to load data directly to gpu, I need to code the pipeline in dali by myself.
I might be not familiar with new pytorch features. Is there any update about that? It'll be a great news to know it's supported.
I see that the imagenet example still need to use cuda() to transform data to gpu, which is originally loaded from DataLoader.
https://github.com/pytorch/examples/blob/master/imagenet/main.py#L283-L284

It’s been in pytorch since a long time ago. Probably before 1.0 if I remember correctly. As long as you return a CUDA tensor from your dataset code and use proper start method, the main process will receive a CUDA tensor, regardless of num_workers.
It is always not advertised nor recommended because it makes CUDA memory management difficulty, moving to GPU really fast and not usually the bottleneck as long as you use pin_memroy.
This issue is not about whether pytorch supports loading CUDA tensors. It is about torchvision, a library built on top of pytorch, should return CUDA tensor or not in ToTensor that is called in the dataset code. Any dataset code that yields CUDA tensors has always been working fine.


Functionalize zsh completion script.

Let me first preface this by saying I don't use zsh so please let me know if this is a bad idea. On Fedora with bash, I install the completion.bash to the global directory and it works automatically once installed. With zsh, I try to install the completion.zsh to site-functions, but this doesn't work.
What seems to be missing is the compdef at the beginning (the shebang seems unnecessary since it's expected to be sourced) and the top-level code needs to be in a function (and install as _fzf.) This allows it to be loaded from the zsh site-functions directory automatically. The fzf call at the end allows it to be sourced just like before.
Anyway, like I said, I don't really use zsh, so I've only done minimal testing but this seems to work in both scenarios.

I'm a bash user and I don't really know about site-functions, I'll have to do some research before merging this. Any comments from zsh users are welcome.
Anyway, should we use a more descriptive name than _fzf? Such as _fzf_init_completion.

I was basing the name on this article using, e.g., _hello to complete hello. Additionally, most of the completions in site-functions followed thi pattern (except _mercurial for hg, for some reason). Of course, fzf completion works for more commands than just fzf, so I'm not sure how much the same name is needed.

With zsh, I try to install the completion.zsh to site-functions, but this doesn't work.

Files in site-functions aren't meant to be used as initialization scripts. Instead, each file in site-functions represent a single function that can be automatically loaded the first time you use it. It is intended to be used to speed up shell initialization. (See the Functions Section in the zsh docs)

What seems to be missing is the compdef at the beginning (the shebang seems unnecessary since it's expected to be sourced) and the top-level code needs to be in a function (and install as _fzf.) This allows it to be loaded from the zsh site-functions directory automatically. The fzf call at the end allows it to be sourced just like before.

By doing this, you're defining a completion function for the fzf command. By taking a quick look at the changes made in this PR, it looks like the initialization commands for fzf completion won't run until you hit fzf<tab>.

I think you're right; I must have been testing by running fzf <tab> first every time. This version definitely continues to work with the old method of sourcing the file manually. Do you have any suggestions on how this could be made to work with all commands supported by fzf?

I'm not sure that creating a specialized completion function for a set of commands is a good idea, because what we're trying to do isn't exactly an extension of the zsh completion system. Instead, we want to create a whole new completion system that is independent from the stock completion system.  completion.zsh already does this just fine by defining a ZLE widget, which is a function that can be bound to a key sequence.
There are good reasons for placing these widgets in site-functions , though. By placing widgets in a well-defined location, users will be able to assign them to any key sequence they like without having to source the scripts. It might even result in a slightly faster shell initialization time, since functions in site-functions won't be loaded until they are called. You might want to see my .zshrc and site-functions from my dotfiles if you want to go down this route. It contains modified widgets from completion.zsh.


Update AutoRest C# version to 3.0.0-beta.20240602.1

Update AutoRest C# version to 3.0.0-beta.20240602.1

API change check
API changes are not detected in this pull request.

About the changes in for BinaryData properties, I have mentioned here: https://github.com/Azure/azure-sdk-for-net/pull/44342
These changes are not actually changing anything.
For the new SystemData in DNS, it might be a problem, but this new type is internal therefore it is fine to merge here.
I will investigate it further to fix it.


Add XML tree builder and eventifier with scala-xml implementation

[x] Add tree builder abstraction
[x] Add tree envitifer abstraction
[x] Add scala-xml tree builder implementation
[x] Add scala-xml tree eventifier implementation
[ ] update documentation

Closes #56.

Poke @Korbik


Add optional passing of a choice of what test to run with -t

Allow passing a choice of tests to run to ci w/ -t. The format would be:
$ bash ci/run_ci.sh -t 'snafu/my_wrapper_dir'

The CI command would be:
/rerun all snafu/my_wrapper_dir

NOTE The jenkins build command still needs to be updated to accept the parameter

Results for SNAFU CI Test

Test
Result
Runtime

snafu/fio_wrapper
PASS
00:12:06

snafu/ycsb_wrapper
PASS
00:07:04

snafu/pgbench_wrapper
PASS
00:05:10

snafu/uperf_wrapper
PASS
00:21:14

snafu/iperf
PASS
00:03:39

snafu/sysbench
PASS
00:02:36

snafu/vegeta_wrapper
PASS
00:06:41

snafu/hammerdb
PASS
00:07:00

snafu/fs_drift_wrapper
PASS
00:08:01

snafu/smallfile_wrapper
PASS
00:08:59


chore: Fix audit vulnerabilities and update dependencies

This pull request addresses audit vulnerabilities by updating key dependencies, including "shadcn-ui" from version 0.8.0 to 0.9.4 and "@swc/cli" from version 0.3.12 to 0.5.2. Additionally, various other dependency updates and removals in package-lock.json have been made to ensure compatibility and improve performance. These changes enhance the project's overall dependency management and incorporate the latest features and fixes.

All FE tests passed!

very much needed, It would be great to keep dependencies up to date with every release :-) thank you for great work!


Runtime Config for Security Headers

Version
nuxt-security: 1.1.0
nuxt: 3.10
Reproduction Link
https://stackblitz.com/edit/nuxt-starter-tjhotm?file=modules%2Fsecurity%2Findex.ts
Hi.
I want to actually use the new "runtimeHooks" but there must be something i'm missing.
I use ENV Variables to define my Headers.
Within the new 'nuxt-security:ready' hook i want to read the values from the runtimeConfig and pass them to the 'nuxt-security:headers' hook.
Unfortunately none of these values are being applied. Some internal defaults are still being used.
Do i have to disable some default behaviour?

Hey @marcel-wtfoxtrot
Thanks for reporting this issue.
@huang-julien could you take a look? I think you are the best person for that question :)

hmmm i don't see any issue, can you add more step so i can reproduce it ?

Hey @huang-julien! Thanks for the reply!
The hooks are called and i can also access values from the runtime config.
They just do not seem to change anything to the response headers send along with the document.

I assumed it would be possible to change / remove the headers by calling the hooks.

setting false makes it fallback to the default/declared config at build time.
Do you have a minimal reproduction ?

Hi @huang-julien
i've updated my repo to give you some more insight.
https://stackblitz.com/edit/nuxt-starter-tjhotm?file=modules%2Fsecurity%2Findex.ts,app.vue,nuxt.config.ts,modules%2Fsecurity%2Fruntime%2Fplugins%2Fnitro.ts
If you enable the headers definition within the Module Options (modules/security/index.ts) the app is able to load and will render the welcome screen.
The same Options are being passed via 'nuxt-security:headers'. You can see them in the console.
in short:
using 'nuxt-security:headers' will not apply custom rules
using module options will apply our custom rules
Does this make sense?

I couldn't reproduce the render issue locally but i reproduced the issue with the headers thank you !

Thanks a lot guys.
I am afraid it does not change too much for me :(  .
https://stackblitz.com/edit/nuxt-starter-p4acfm?file=server%2Fplugins%2Fsecurity-plugin.ts
I was tinkering around with the settings and tried to add the exact headers from @huang-julien s test but i can't get them to show up in the documents response.
i try to add the following headers in the plugin:
contentSecurityPolicy: {
          'script-src': ["'self'", "'unsafe-inline'", 'some-value.com'],
          'frame-ancestors': "'*'",
        },

But the CSP header in the documents response is not altered:
base-uri 'none'; font-src 'self' https: data:; form-action 'self'; frame-ancestors 'self'; img-src 'self' data:; object-src 'none'; script-src-attr 'none'; style-src 'self' https: 'unsafe-inline'; script-src 'self' https: 'unsafe-inline' 'strict-dynamic';
(dev and production build).
I really don't understand whats going on here as, by looking at the tests, this is supposed to work just fine.

i don't have this issue, we do have some-value for script-src and * for frame-ancestors 🤔

Ok .. i will try that as well. Thanks for looking into!

Hey @huang-julien just did.
Pulled the stackblitz, yarn && yarn dev  -> did not work.
Checked out the nuxt-security yarn && yarn dev -> works like a charm in the playground project.
Went back to the stackblitz and debugged into :
https://github.com/Baroshem/nuxt-security/blob/main/src/runtime/nitro/plugins/00-context.ts#L41
Where i found a silent Error being thrown due to a missing import (setHeader -> undefined).
I can fix the behaviour by adding the imports.
Came back to comment.
Found this issue and PR that will fix it :) !
https://github.com/Baroshem/nuxt-security/issues/373
https://github.com/Baroshem/nuxt-security/pull/374
I believe it is still worth examining the differences in installing the module from its sources or via pgk manager as it obviously makes a difference in how dependencies & utils are installed / indexed.
Also i am not sure if the Tests work correct in that case ...


Consider supporting postgres for tracing

In addition to mysql.

if there postgres drivers that support dbapi2, then it should be simple, as here.
Are you interested in submitting a pull request?

psycopg2 does indeed follow PEP249 / dbapi2. I might take a stab at this, thanks!

Please reopen if needed


Make errors more verbose

The Error class in PRDownloader is not really helping when debugging as it doesn't provide the issue that causes the download to fail.
I'd suggest adding a Throwable parameter to the Error class.
Thanks

Hey @amitshekhariitbhu have you solve this problem?
Can we print error in readable format ?