Add git filters to ease branch switching for new contributors

This PR introduces a script that installs a smudge/clean filter for git. This lets contributors use their own signing info without needing to stash/reapply every time they switch branches or pull.

Looks great, thank you for bringing those issues to my attention!


File input/upload

Hey there,
First of all: this plugin looks / works great!
I'd like to see a field acting on file drag/drop / input, when using the current text field, this results in all path characters being inserted after one another 😀
What do you think? Could this be something worth it?

@S1SYPHOS apologies for the extreme delay. I had to step away from my open source work for a while.
I'm glad you like the inputs :smile:  and I think you're idea of drag and drop support for File Paths is interesting. The underlying Textual framework has come a long way since this request and since this inputs project was started. It filled a gap in the framework, which was largely read only at the time. I'd encourage you to see what the Textual docs (which are pretty detailed now) have to offer for this or similar solutions. Best of luck :four_leaf_clover: on your projects.
Textual now supports inputs natively -> https://textual.textualize.io/widgets/input/

Yeah they're doing a very fine job over there, thanks for your reply! 🙂


[1.4.x] Made AnalysisCallback thread-safe again. Re sbt/sbt#6198

This backports https://github.com/sbt/zinc/pull/957
For the parallel Hydra Scala compiler to work with sbt and zinc, it's paramount
that the AnalysisCallback is thread-safe. The bulk of the work was done in
sbt/zinc#410, but the changes introduced to support pipelined compilation were
not thread-safe, hence could potentially break compilation via Hydra.
There are three categories of concurrency hazards that are fixed:

Memory visibility issues (@volatile helps with this)
Compiler/JVM optimizations leading to instructions re-ordering (`@volatile
prevents this from happening in the sections of interest)
Race conditions due to concurrent read/write (AtomicBoolean CAS heals this)

Mind that instead of @volatile, it was perfectly fine to use
AtomicReference/AtomicBoolean, but I opted for @volatile in the places
where CAS were not required. The rationale is to apply KISS.

To validate this pull request against other sbt modules, please visit this link.


Apsis

Project Abstract

Please provide a brief description of your project here summarising key points (1-2 paragraphs).
If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

For which grant level are you applying?

[ ] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $50,000, 3 approvals
[x] Level 3:  Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[x] A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledged the terms and conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: frankyin-factual:x: shengdaYou have signed the CLA already but the status is still pending? Let us recheck it.

Sounds interesting. Before our call tomorrow, perhaps you could shed some light on the following points please:

If I understand correctly, you are shifting the security assumption down the line, from trusting the oracle operator to trusting the data provider itself? The data provider (e.g. price supplied) can still submit arbitrary and malicious data. Do you have plans for aggregating responses from various data providers, detecting outliers etc.?
What exactly does a "proof for an HTTP API invocation" consist of? I've never heard of the ability to prove that you made a request. Do you mean verification of the authenticity of the response received from the server?

Thank you for the prompt feedback!
For the first question, yes, it removes the trust requirement for oracle operators. This can be better seen from the image below. Data aggregation for data points from multiple data sources can be done by smart contracts in Apsis EVM, so that we could validate the both the data points and the aggregation process. Data aggregation is one of the primary use case of Apsis EVM.
For the second question, you are right, it is used to prove an HTTP response is received from the server at the specific timestamp. What we try to phrase is more from a miner or DApp point of view, which means proof that the data is received by one that makes the HTTP API, but who makes the request is not important. We could definitely phrase it to make it more clear.

Hi, thank you for your feedback on our application. Unfortunately, after further study we find that our previous solutions can't completely solve the shared key problem with the existing network protocols. Therefore, we've decided to suspend our application until we find a workable solution.
Thank you again for reviewing our application. We have strong belief in the web3 community and we will keep building on the Polkadot ecosystem.

@shengda Thank you for the update, I appreciate the honesty and openness about your project. Please let us know if you have found a workaround, and also in case you have another project you want to work on in the meantime. You might get inspired by our open RFPs: https://github.com/w3f/Grants-Program/tree/master/rfps.


ci(release): update workflow to sign checksum file

@fixes #18

Codecov Report

Merging #20 (fc050e5) into main (f6166ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   82.07%   82.07%
=======================================
  Files           4        4
  Lines         212      212
=======================================
  Hits          174      174
  Misses         27       27
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6166ce...fc050e5. Read the comment docs.


Add "winapi" (binding)

https://github.com/retep998/winapi-rs

The crate is now soft-deprecated, and if anything is the way forward in that regard, it will be windows-rs - so closing in favour of https://github.com/areweguiyet/areweguiyet/issues/62


Clarify ExternalNames are hostnames

Updates api-reference documentation to clarify that ExternalNames
are RFC-1123 hostnames and not DNS names.
Fixes #52266

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.9 Features: set Milestone to 1.9 and Base Branch to release-1.9
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.

This change is

I don't know how these docs work, but I'm pretty sure this should actually be changed in some source document and then the HTML re-generated.  Especially since the same exact text is used in other parts of the documentation as well.

@kyrias is correct. This doc is auto generated from upstream files. When I get a chance, I'll provide details.

Thanks @kyrias @steveperry-53 for your reviews. Okay, I was not sure of that. I will look into what source file needs to be changed and then re-generate the HTML.

I found the place in source file where change should go https://github.com/kubernetes/kubernetes/blob/f9e6142f925a33a9d8a252ab79b9dabbee596ea2/pkg/api/types.go. I am looking at how to re-generate HTML after you change this source file

This doc might help:
https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md#generate-code

@adnavare The code for generating the HTML is under revision. I think it would be best if I generated the HTML. Let me know when you're ready.

@xialonglee Thanks for the pointer. @steveperry-53: Okay I will update you. @xialonglee , @steveperry-53 So, now I have to submit a PR against kubernetes/kubernetes as well because source file is in that, right?

Thanks @steveperry-53 : As we chatted, i will point you to the link for changes made in source file once submitted.

Hi @steveperry-53 This is the PR against Kubernetes source file https://github.com/kubernetes/kubernetes/pull/54833

I think it is appropriate to close the issue from doc side given that a PR to change the source is proposed to fix it in the right way.


Force tags to be lowercase

Fixes: https://projects.bcc.no/#/tasks/35692468

I have converted this back to a draft as I need to fix #83 first. As @fredrikved noted the migrations are actually not executed properly.

Never mind. They do run, I was just looking at some tables in truncated mode...


Support Diffs for tables

pass table and snapshot id
get a dif of tables from 2 snapshots

look at call to api/v5.0/tables/url and provide a link to diffs table


SelectField doesn't open when floatingLabelText is clicked

Problem description
If you provide SelectField with a  floatingLabelText property and then click the SelectField where the floatingLabelText shows up, the SelectField doesn't actually open.
Steps to reproduce

Add a SelectField with a floatingLabelText
Hover mouse where the text is (note that its a text cursor style instead of a hand)
Try to click. Notice that nothing happens.

Versions

Material-UI: 0.15.0
React: 15.0.2
Browser: Chrome (50.0.2661.94 m)

One way of fixing this issue is to also provide floatingLabelStyle={{pointerEvents: 'none'}}. This should probably be the default though

Seems to have broken between 0.14.4 and 0.15.0. @jeffshaver Care to submit a PR?

@mbrookes i wouldn't mind submitting a pr. but is the proposed solution (making pointerEvents: 'none') the solution your guys want implemented or is there another way to fix this?

That should do the trick.


Next() on TagSet Cursor is linear with cursor count

Stress testing shows that the following code is causing long query times when the series cursor count is 42K:
   7.26s      7.26s    572:func (mc *seriesCursor) Peek() (key int64, value []byte) {
    25.20s     25.20s    573:    if mc.keyBuffer == -1 {
         .       60ms    574:        k, v := mc.cursor.Next()
         .          .    575:        if k == nil {
         .          .    576:            mc.keyBuffer = 0
         .          .    577:        } else {
         .          .    578:            mc.keyBuffer = int64(btou64(k))
         .          .    579:            mc.valueBuffer = v
         .          .    580:        }
         .          .    581:    }
         .          .    582:
    11.10s     11.10s    583:    key, value = mc.keyBuffer, mc.valueBuffer
     2.15s      2.15s    584:    return
         .          .    585:}

The implementation of Peek() simply put a wrapper around value-buffer code that has been in the query-engine for a quite a while. Peek() may be called a lot, but most of the time it will be returning stuff from memory. So the search is linear with the number of cursors.
Basically, all this peeking is a re-write of this:
https://github.com/influxdb/influxdb/blob/8ade485b5865e642b128a7cc6eb20c9da73d1b48/tx.go#L510

@benbjohnson : yeah, it was a problem before too. it's a linear search on every Next() call.

@dgnorton @jwilder

From a user's point of view this can actually cause write timeouts since it can cause queries to hold locks for too long.

Perhaps we can use this to build a priority queue of cursors:
http://golang.org/pkg/container/heap/
where the highest-priority cursor is the one with the lowest timestamp.

@dgnorton did your heap changes fix this?

@beckettsean  yes

Fixed by https://github.com/influxdb/influxdb/pull/3520


fix(helm): Accept dependency in requirements.yaml from charts directory

supersedes #3422
closes #3221

Working on the port for this

Port to v3: #6611


client: Add container template files operations

Add a new lxc config template <op> section to the CLI to perform operations related to template files.

@stgraber I changed the CreateContainerTemplateFile to match the API. I'm not sure if we want/need to allow passing content in the create command too in the CLI.


RBR transaction thread is disappearing from the LHN when navigating to another chat

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/36778
PROPOSAL: https://github.com/Expensify/App/issues/36778#issuecomment-1951585989
Tests

have an expense that you are the submitter on, which has violations
go to the transaction thread
notice that you see violations on the expense and that the RBR is shown in the LHN
navigate to a different chat
Verify that: the RBR chat stays "pinned" in the LHN as long as the RBR is present

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

have an expense that you are the submitter on, which has violations
go to the transaction thread
notice that you see violations on the expense and that the RBR is shown in the LHN
navigate to a different chat
Verify that: the RBR chat stays "pinned" in the LHN as long as the RBR is present

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/113963320/09b3d1df-b990-47a0-940b-cf94d547b915

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/c643fb0e-09d9-4226-976b-0c260065b44c

MacOS: Desktop

@tienifr Hmm it might be a known issue. Does it happen for all violations? I'll try and get this tested by Monday.

@tienifr I think you just need to enable the violations beta in Permissions.ts.

@tienifr This doesn't seem to work for me. With most recent mode:
https://github.com/Expensify/App/assets/27287420/31b8238e-a928-4d8a-a357-864339871e02
With focus mode:
https://github.com/Expensify/App/assets/27287420/63a9ebff-02dd-43ff-95d8-fa4cac2ee201

@tienifr Ah I think I see what you mean, but we can't just ask to enable the violations beta for all users :smile: Can we reuse the logic that's used for displaying the RBR dot?

Asked @cead22 for more details on when the violations beta will be enabled for all users.
Otherwise @jjcoffee's recommendation seems OK:

Can we reuse the logic that's used for displaying the RBR dot?

@tienifr Not sure if this is ready for re-review or not, but there's a failing jest test.

FYI violations beta should be removed in ~2 weeks

@tienifr Can you confirm if the violations beta needs to be enabled in order for this to work? I don't seem to see any difference from this.

@tienifr Ah gotcha, thanks! Can you update the test steps to include that the beta needs to be enabled?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@tienifr I'm not sure how the GBR are currently sorted, but I'm wondering if it might be a good idea to sort RBR by date? Or is there a performance hit for that?

@tienifr Can you add the missing screenshots/videos?

Currently, we're sorting by name

Okay I guess we can leave that for now then!

@AndrewGable Friendly bump for review :bow:

@tienifr - Conflicts

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

FYI I reverted this PR because it caused these blockers:

https://github.com/Expensify/App/issues/43252
https://github.com/Expensify/App/issues/43238

Please work on this fix again taking into account the issues above

Asking for clarification on #43238 as I'm not 100% on the expected result.
@tienifr Are you able to take a look at https://github.com/Expensify/App/issues/43252?

@jjcoffee left a comment on https://github.com/Expensify/App/issues/43238

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Awesome -- or amazing?

@dwrensha noticed that we're inconsistent about if a "3" rating is "Awesome" or "Amazing". See e.g.
https://apps.sandstorm.io/app/m86q05rdvj14yvn78ghaxynqz7u2svw6rnttptxx49g1785cdv1h
This PR standardizes on Amazing.
@neynah if you prefer to standardize on "Awesome" please say so here. I'll do that if you prefer!
Otherwise I'll merge & deploy this about 3-4 hours from now.

Running with "Amazing" for now. Will merge & deploy now.


Implement most binary i32 ops in amd64 native backend.

> go test -bench=BenchmarkU64Arithmetic github.com/go-interpreter/wagon/exec
goos: linux
goarch: amd64
pkg: github.com/go-interpreter/wagon/exec
BenchmarkU64Arithmetic10Interpreted-8   	  200000	     10012 ns/op
BenchmarkU64Arithmetic10Native-8        	 1000000	      2205 ns/op
BenchmarkU64Arithmetic50Interpreted-8   	   30000	     46081 ns/op
BenchmarkU64Arithmetic50Native-8        	  200000	      9988 ns/op
PASS
ok  	github.com/go-interpreter/wagon/exec	9.382s

Codecov Report

Merging #123 into master will decrease coverage by <.01%.
The diff coverage is 57.5%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   66.04%   66.04%   -0.01%
==========================================
  Files          41       41
  Lines        4138     4170      +32
==========================================
+ Hits         2733     2754      +21
- Misses       1134     1145      +11
  Partials      271      271

Impacted Files
Coverage Δ

exec/internal/compile/scanner.go
0% <0%> (ø)
:arrow_up:

exec/internal/compile/backend_amd64.go
77.07% <60.52%> (-0.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d88e75...a174af7. Read the comment docs.


Add the introduction video on the home page.

We have a fantastic video that talks briefly about what is the project and what it does. The point is to add this video somewhere on the home page.
https://www.youtube.com/watch?v=v_aTLxTJTZs

Done :) sorry for the delay!


IMP - KB 1 0 18 - Gantt view makes scroll bar for long task titles

Been playing around a bit with the Gantt view,
really like the Gantt approach for team planning purposes.

Improvement:

If the title of the task is long, the gantt view creates a scroll box which covers the text.
See left side of screenshot

Are you using Windows? which browser?

I get this in Firefox 40.0.3. Forced me to de-verbose a few of my Task titles (which was probably good).

Windows.
Firefox 40.0.3

Same result with with IE v 11.0.96

This issue is fixed in the development branch. (tested only with IE11 at the moment)


dpcpp ports amgx_pgm

This PR ports the amgx_pgm to dpcpp.
the current thrust::tie can not be translated to dpcpp by dpct.
@upsj Do you know something like thrust::tie inside oneDPL?

std::tie from <tuple>

no, the extra is our own effort.
it gives the same structure as the cuda and hip call including the share memory usage.
when the kernel call many times, the function in dpcpp is hard to align with other executor

@upsj @Slaedr I move those kernels to unified and add device_std as thrust for cuda/hip and as std for others

unified ~107.86ms
4.81%  3.1193ms         4  779.82us  129.02us  1.8408ms find_strongest_neighbor
0.05%  33.488us         4  8.3720us  6.4610us  10.141us match_edge

original ~107.108 (skip_sorting 62.4452)
4.82%  3.1674ms         4  791.86us  146.08us  1.8393ms find_strongest_neighbor
0.06%  36.687us         4  9.1710us  6.8120us  10.939us match_edge

only check mfem l-shape 1 level generation on V100
it does not give noticeable difference between these.
the main bottleneck is spgemm and sorting.
sorting takes ~ 40 ~ 45% of generation and spgemm takes ~10%
without sorting. spgemm (sum of RadixSort and spgemm_core) takes ~20% and find_strongest_neighbor takes ~10%


How to properly perform data augmentation on cached distance maps

Hi Hoel,
Thanks very much for posting your work on the boundary loss!  I really appreciate what you've done.  However I have a question with regards to data augmentation.  I am currently working on 3D organ segmentation, so computing the distance transforms on the fly in the data loader like in the 2D case would wreck havoc on I/O.  For 3D, the best way to compute this loss function is to pre-compute all of the signed distance maps for each volume and cache them so that we can load them quickly inside the data loader.  I do see a related issue open here that talks about it in some detail: https://github.com/LIVIAETS/boundary-loss/issues/29.  As mentioned by the author of the related issue, when it comes to data augmentation I don't see any other choice but to create the signed distance maps on the augmented volumes "on the fly" to accurately calculate them.  However, in the related issue you mentioned that you can perform the augmentation on the cached signed distance maps but I do not see how this can properly be applied as the values in the signed distance maps are not actually intensities.  In other words, caching the signed distance maps, then trying to perform augmentation on these does not operate in the same way that would be done with the input volumes as they directly deal with intensities.
To be more specific, suppose we have loaded in a batch of patches corresponding to original input volume, ground truth masks and distance maps.  If we do augmentation on these input volume patches and if they are subject to some affine transformation, the distance maps will naturally be affected as the affine transformation on the input volume will affect the placement of the voxels which will now affect the distances of these voxels to the ground truth surfaces from the masks.  The distance maps of course are not intensities or colours, so simply applying the same augmentation steps to the distance maps would treat them as actual intensities or colours so the final values after you run through the augmentation would not actually be the distances to the ground truth surfaces.
As I currently understand, the signed distance maps are computed "on the fly" with the resulting augmented volumes which I can see the augmentation of the input volumes being done here - https://github.com/LIVIAETS/boundary-loss/blob/master/dataloader.py#L320.  Noting the related issue, how would you properly handle performing augmentation on the distance maps so that the locations correctly capture the distances to the ground truth surfaces?
Thanks!

Hi, and thanks for the interest in our work.
I'm trying give you a partial reply now, but I might come back in a few days once I've had more time to think about it.
I didn't had to perform data augmentation for that work, though the options are there for offline data augmentation: https://github.com/LIVIAETS/boundary-loss/blob/master/preprocess/slice_wmh.py#L133
I.e., it will create N augmented copies for each image. (Though now that I think of it, I should probably invert the two loops now that I pre-compute a 3D distance map.)
In proper 3D, if you subpatch the volume, then yeah, you cannot even recompute a correct distance map based solely on the patch, so pre-computing is the only way.
Online data augmentation (what you are referring to) is indeed much more tricky. The timing of your question is interesting, as a few days back I was experimenting with it, noting that augmenting a ground-truth that is already one-hot encoded will break the simplex for a few pixels -- even a simple rotation would break it.
Now, a distance map might be a bit more resilient to that, depending what interpolation you are using (I would say, BILINEAR in place of NEAREST, to handle elastic deformations) and what actual transforms you are performing.  The way I see it (in my mind, this is theoretical), the following transforms would be possible:

horizontal/vertical flip
rotation
translation
affine (in the sense of rotation + translation)
and possibly a few others

As such, I would say that you can apply the same transforms, with different interpolation:

image: BILINEAR
class-labels: NEAREST
one-hot labels: don't
disttance map: BILINEAR

Feel free to post code-snippets of the data augmentation that you are using, it might help to test the feasiblity of it.

Thanks for your reply Hoel!  I didn't realize that you had the option of computing data augmentation offline as well as caching the distance map in individual slices.  This was very useful to see.  You are correct where the purposes of my work, I'm performing the segmentation in proper 3D where the input is a volume subpatch.  Overlapping volume subpatches are created, the segmentation is performed on each subpatch and are all assembled in the end to provide a volumetric 3D segmentation.
The transforms you've listed also make perfect sense.  In fact I may have to resort to just using these if I want to incorporate the boundary loss into what I'm doing.  However for perspective, I am using torchio as a framework to provide a batch of volume subpatches in the training loop which I can feed directly into the model so that the weights can ultimately be updated.
Here is a function I wrote that returns the list of transforms I apply to training + validation:
import torchio as io

def get_transforms() -> Tuple[tio.Compose, tio.Compose]:
    """
    Returns transform chains for training and validation/testing datasets
    for multi-organ 3D CT segmentation.

    Returns:
        A tuple of torchio.Compose objects for the transform chains.
    """
    training_transform = tio.Compose([
        tio.ToCanonical(),
        tio.Resample(1),
        tio.RandomMotion(p=0.2),
        tio.RandomBiasField(p=0.3),
        tio.ZNormalization(masking_method=tio.ZNormalization.mean),
        tio.RandomNoise(p=0.5),
        tio.RandomFlip(),
        tio.OneOf({
            tio.RandomAffine(): 0.8,
            tio.RandomElasticDeformation(): 0.2,
        }),
    ])

    validation_transform = tio.Compose([
        tio.ToCanonical(),
        tio.Resample(1),
        tio.ZNormalization(masking_method=tio.ZNormalization.mean)
    ])

    return training_transform, validation_transform

In order, ToCanonical reorients the volume so that the scans are in radiological RAS format (Right to Left, Anterior to Posterior, Superior to Interior), Resample resamples the voxels so that each one is normalized to 1 mm^3 iso.  RandomMotion and RandomBias randomly add in a random motion and bias effect that would be seen in MRIs if the subject were to move during the scan and intensity level variations due to field inhomogeneity.    The validation transforms are of course only a subset where we only represent the volume in canonical form, resample to 1 mm^3 iso and z-normalize.
After, you can build a list of torchio.Subjects then put it into  torchio.SubjectsDataset.  Here's the training set for example where there are a list of paths for the volume and corresponding labels:
    # Build a list of subjects - one for each volume
    subjects_train = [tio.Subject(
        volume=tio.ScalarImage(image_path),
        labels=tio.LabelMap(label_path))
        for (image_path, label_path) in zip(image_paths_train, label_paths_train)]
    # Build dataset given this list
    dataset_train = tio.SubjectsDataset(
        subjects_train, transform=training_transform)

Finally you can provide this to a torchio.Queue which you can wrap around a `torch.utils.data.DataLoader:
    patches_training_set = tio.Queue(
        subjects_dataset=dataset_train,
        max_length=max_queue_length,
        samples_per_volume=samples_per_volume,
        sampler=sampler,
        num_workers=num_workers,
        shuffle_subjects=shuffle_train,
        shuffle_patches=shuffle_train,
    )

    training_loader_patches = torch.utils.data.DataLoader(
        patches_training_set, batch_size=training_batch_size)

What is nice is that for the labels, they use a torchio.LabelMap so any intensity transformations are ignored as these are treated as categorical labels (obviously).  Therefore I can see using this to wrap around the signed distance maps so we only work with transformations that would be applicable to using segmentation masks.  Judging from your discussion, I can see that you agree that this should be the case.
However going wit\h this, you can then use this and start training your models.  The tio.SubjectsDataset will already provide augmented volume subpatches by first doing the transform on the whole volume, then providing the correct subpatches into this augmented volume:
        for batch_idx, batch in enumerate(training_loader_patches):
            # move to GPU
            inputs = batch['volume'][tio.DATA].cuda()
            targets = batch['labels'][tio.DATA].cuda()

            # find the loss and update the model parameters accordingly

I can see how using at most affine transformations on the distance map would properly reflect the actual distances to the ground truth surface with the exception of the scale.  Given the above, I'd like to know what your thoughts are when you come back to this, especially since I'm using a framework that directly provides volume subpatches in an easy manner.
Thanks!

Hi Ray,
Thanks for those pointers. I had forgotten about torchio (though I think it's still fairly new ?), it is a good reminder. Looks much simpler to use than sub-patching and reconstructing the 3D volume manually.
From a quick overview I would guess that the transforms handle image and label in a different fashion.
I will check that in more details after the MIDL deadline, but adding another implementation for a third input, as a distance map, might be a good option.
I guess that work would fall on me, it would be relevant for the community to be able to manipulate distance maps -- beyond its use for boundary loss. "Incompatible" transforms (if any) could simply raise an exception explaining why it cannot be done.
Hoel

Thanks for your comment Hoel!  Yes torchio is relatively new.  I would always have to create the data loader myself to extract subvolumes for training, but this makes it a lot easier to do it so I started using it just recently.  I've got some deadlines myself but after they're finished I wouldn't mind looking at this myself and seeing if I could make a PR to add this functionality into the current framework.  Until next time!


timed out

Device
iphone 7
Version
ios 15.8.3
Passcode?

[ ] Passcode is enabled.

Start going into detail..
My device couldn't jailbreak it says device is disconnected then timed out
Familiarity with palera1n

[ ] I am familiar with palera1n and how to use it!

Familiarity with CLI

[ ] I am familiar with the command-line!

I assume this is related to "Timed out waiting for download mode", I would recommend you troubleshoot on your own with your current setup to find out whats wrong.
I will be closing this issue as there's many duplicates regarding this which all usually can be solved with the same answer.

Thanks it was  just the simple trick just unplug the cable and reconnect it.
On Thu, Dec 19, 2024, 9:50 PM samara @.***> wrote:

I assume this is related to "Timed out waiting for download mode"
https://docs.palera.in/docs/troubleshoot/troubleshooting-steps/#timed-out-waiting-for-download-mode,
I would recommend you troubleshoot on your own with your current setup to
find out whats wrong.
I will be closing this issue as there's many duplicates regarding this
which all usually can be solved with the same answer.
—
Reply to this email directly, view it on GitHub
https://github.com/palera1n/palera1n/issues/524#issuecomment-2556159706,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BNMW3647DL6AOK6JRFM2VPT2GOAXFAVCNFSM6AAAAABS4C6THWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJWGE2TSNZQGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Provide non-SPI means of obtaining a Path from a gs://blah/lolcat.csv URI

Is your feature request related to a problem? Please describe.
The documentation requires using SPI to create a Path as follows:
Paths.get(URI.create("gs://bucket/lolcat.csv"))

I don't want to use SPI. I don't understand SPI. I just want a way to get a Path given a gs://blah/lolcat.csv style URI.
Describe the solution you'd like
Please provide some static function that takes a URI and returns a GoogleStoragePath

The other APIs of java file nio do need the FileSystem registered via the SPI.
For example, Files.newByteChannel(Path) leverages the SPI registered FileSystem in order to know how to open that byte channel.
If you aren't wanting to deal with the Java File NIO api at all, https://github.com/googleapis/java-storage sounds like more of what you'd want. With that library you can something like:
Storage s = StorageOptions.newBuilder().build().getService();
BlobId id = BlobId.fromGsUtilUri("gs://bucket/lolcat.csv");
byte[] bytes = s.readAllBytes(id);

Closing based on discussion, there's a path forward using java-storage instead of java-storage-nio. Please reopen if Ben's follow-up does not address your question.


Fix space between , and exclude_xplat (rl doesn't handle spaces)

@dotnet-bot test Ubuntu static_ubuntu_linux_debug please


Use OTP25 ets optimisations

Codecov Report

Merging #9 (e71cd86) into main (9180c95) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   76.77%   76.77%
=======================================
  Files           1        1
  Lines         155      155
=======================================
  Hits          119      119
  Misses         36       36

Impacted Files
Coverage Δ

src/segmented_cache.erl
76.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9180c95...e71cd86. Read the comment docs.


Is that possible to configure proxy for WebView2?

Instead of using system proxy, is that possible to configure proxy for WebView2 process specifically? Thank you.

This is resolved in another thread.


how to install with docker-compose

Hi, I need help with a guide or some tips on how to install this repo without any use of Kubernetes
Tnx!

Hi @benzaked, you can try http://github.com/IQSS/dataverse-docker, it's just simple docker-compose infrastructure.

hi, @4tikhonov tnx for the fast replay. I tried it earlier and I get GlassFish index.html every time I go to
http://localhost:8085 instead of dataverse login page.

Weird, as far as I know it was installed in a few places last week. I'll take a look.

Closing in favor of #118

@benzaked in addition to #118 you could take a look at https://github.com/IQSS/dataverse/blob/v4.17/conf/docker-dcm/readme.md . I don't think I ever ran the docker-compose file myself but my colleague did when working on adding S3 support to the Data Capture Module (DCM). Should work. For dev. :smile:

Thank you @4tikhonov and all. @4tikhonov I will love for an update If you succeed.


Can i control connected users using starlink-grpc-tools ?

I want to control connected users, like suspend internet access and get notified when new user is connected ?
How can i do that using this

If you mean WiFi connected users, then no, not with these tools. The scripts in this project do not operate on the router, only on the dish.

Is

If you mean WiFi connected users, then no, not with these tools. The scripts in this project do not operate on the router, only on the dish.

Is there any tools to control the router ?  (install OpenWRT) or any other way ?

I'm not aware of any such tools, but there may be. I haven't been keeping up to date on what people are doing with the Starlink router, because I don't use it myself.
If you want full router control, I recommend putting the Starlink router in bypass mode (or just remove it if you have a dish version where that is an option) and use your own router.


add docker compose to runnning development

Summary
add docker compose link in README.md, Kong Development, out-of-the-box

Development environment

kong 0.9.5
PostgreSQL 9.5.5

SSH Server for Docker containers

There is an official docker-kong repo including a docker-compose.yml curiously in the /compose folder.
https://github.com/Mashape/docker-kong
Although this might not be such dev ready as your version may be - but I would rather like to this example than a custom one.

@gabel that's right. @WALL-E please check that one.


Make zookeeper, kafka, controller use random port for integration tests

Description
To improve the integration test stability.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #6872 (37dfc2d) into master (ae2ff6f) will decrease coverage by 8.07%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #6872      +/-   ##
============================================
- Coverage     73.54%   65.47%   -8.08%
  Complexity       12       12
============================================
  Files          1420     1420
  Lines         69860    69870      +10
  Branches      10084    10085       +1
============================================
- Hits          51376    45744    -5632
- Misses        15080    20847    +5767
+ Partials       3404     3279     -125

Flag
Coverage Δ
Complexity Δ

integration
?
?

unittests
65.47% <71.42%> (+0.02%)
12.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2ff6f...37dfc2d. Read the comment docs.

This seems to require an implicit sequencing of findRandomOpenPort() and creating the listening sockets from within the services during startup. Otherwise, there's a chance of a conflict. (which doesn't actually happen bc the port isn't random) :P)

Agreed. I will change the method name to findOpenPort() since it's not random

This may (seemingly) make tests more "stable" but we may end up with an issue where things are not closed properly, and that is not detected until some random re-use of the same port, leading to transient failures.
Am I right, or am I missing something?

This may (seemingly) make tests more "stable" but we may end up with an issue where things are not closed properly, and that is not detected until some random re-use of the same port, leading to transient failures.
Am I right, or am I missing something?

I think the major issue we are facing is the test framework.
In reality, we won't run those multi-threaded programs in the same JVM multiple times. Also, this change will eventually make us be possible to use fork to run the integration tests


[ci] split SoftwareFrameworkTests from simple testbench simulation

This PR is based on #817 ~, so I'll keep it as a draft until that one is merged~.
Instead of building the processor check software together with other "toolchain testing software compilation" tasks, it is done at the same time the simulation is to be executed, in a separated job.
Moreover, since building the software and running the simulation was done using the same container image but in different steps (thus, spawning two containers), I changed it to call make target sim-check (from #817) directly.
By the way, I removed 'Container' from job names/ids, since currently all the steps are executed on containers. I believe that's just a leftover from some years ago, when the simple testbench was executed on GitHub's Ubuntu environment.

This is now rebased, after merging #817.


Cannot insert literal ""$$"

In a case where I'd like to have a literal $$ (in my case in a `...`). Pretty much nothing seems to let me do this. I've tried using HTML entities, escaping. All sorts of weird stuff like `$\$` but nothing seems to work.

Just passing by. Did you try escaping two dollar signs?
\$\$

@lukejanicke That works, yes, but not inside code blocks. It just renders it as \$\$ instead of $$


cat-datepicker is not aligned on the text baseline

Instead it is aligned on the top of the input

a bit mor info and a screenshot would be very helpful

how it should be:

How it currently is:


Add on_open handler to combo_box widget

This PR introduces an on_open event for the combo_box widget, bringing it in line with the functionality of the pick_list widget. Additionally, this update addresses the feature request outlined in ticket #2452.
Fixes #2452.

No problem happy to contribute :)


Added: Option to join to allow "without" method.

This fixes an issue when where you join data which could have private
the information you can specify an array of "without" keys which will
remove that tagged data from the joined data.
Also version bump for the one on NPM.

I think i'd rather make Model.without deep, or a deep version of it

Okies


Gh 489 deprecated classes

Attempted to remove usages of deprecated classes and methods of external libraries from the project. Have also removed deprecated classes (and their usages) from Gaffer.

Closing for now - will reopen when we are closer to a major release.


Squiz.Commenting.PostStatementComment should flag all types of trailing comments

Describe the bug
Squiz.Commenting.PostStatementComment flags only single-line trailing comments that start with //. But, as @jrfnl mentioned in https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/560#issuecomment-2237930952, # is also a valid single-line trailing comment in PHP and should be flagged by the sniff as well.
I wonder if single-line trailing comments using /* ... */ should be flagged as well or not. I think they should, as this is yet another valid type of trailing comment, but I'm not sure.
Code sample
$a = 1; // This comment is already flagged by the sniff.
$b = 2; # This comment is not currently flagged by the sniff, but it should be.
$c = 3; /* I believe this comment should be flagged as well, but this is an open discussion */

To reproduce
Steps to reproduce the behavior:

Create a file called test.php with the code sample above.
Run phpcs -s --standard=Squiz --sniffs=Squiz.Commenting.PostStatementComment test.php
See error message displayed

FILE: test.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Comments may not appear after statements (Squiz.Commenting.PostStatementComment.Found)
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

Expected behavior
Besides displaying an error message for line 1, which already happens, I expect PHPCS to display an error for line 2 and potentially line 3 as well.
Versions (please complete the following information)

Operating System
not relevant (Ubuntu 24.04)

PHP version
not relevant (8.3)

PHP_CodeSniffer version
master

Standard
Squiz

Install type
not relevant (git clone)

Please confirm

[x] I have searched the issue list and am not opening a duplicate issue.
[x] I have read the Contribution Guidelines and this is not a support question.
[x] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
[x] I have verified the issue still exists in the master branch of PHP_CodeSniffer.

I wonder if single-line trailing comments using /* ... */ should be flagged as well or not. I think they should, as this is yet another valid type of trailing comment, but I'm not sure.

I'm fine with flagging all three variants - with the explicit caveat that the /* */ style comment should only be flagged when single-line.
We might also want to have a think about whether all three should be flagged with the existing error code or that each type of trailing comment should have its own error code.
In principle, I think the same error code should be used as they are all trailing comments, but opinions may differ on this.


For UWP apps, SVGs not rendering in any version higher than 2.2.10-pre-408

I am writing a Xamarin Forms app that uses SVG images. For UWP apps, SVGs render in version 2.2.10-pre-408 but not in any version higher than that. I have tested in all versions starting at 2.2.10 to latest 2.2.12-pre-497 and SVGs will not be rendered in my UWP app. Everything works fine in my iOS and Android apps.

It's fixed with: https://github.com/luberda-molinet/FFImageLoading/commit/c49248972fd327c3945ddf64726658a098eecf90
Shortly, you must add NETStandard.Library package to solve your issues.


Add templates for easy maintaining

I saw this project is open to contributions, and it doesn't have Pull request and issue templates, it makes it easier for you to maintain your projects.
Here are links for reference:
Pull Request Template
Pull Request and Issue Template
I can work on this if you want it

ya sure go ahead.
We have already mentioned all those points for Issue and PR template in Contributing.md
So, You dont need to add those checkboxes that are in your referenced links.
just add one checkbox that says - [] I have read and I am following [the guide for creating a new <issue/PR>](put link here that I have given above)
that's all.
you can add this line in the end of the PR template:- fixes/closes#issue_id
Also, It would be nice if you could check for spelling typos and grammar errors throughout those 8 markdown files. (you can make another issue for this if you want)


Since 22H2, user pinned apps are removed

After updating to 22H2, the ConfigureStartPins CSP removes any apps that the user pins on start. The user can pin apps, but they are removed at restart. If this is expected, it should be clarified in the docs.

@di6parn Kindly indicate which document you are referring to. Thanks

@di6parn Kindly indicate which document you are referring to. Thanks

Oh, sorry, I thought it would be automatically linked.
I'm referring to Customize the Start menu layout on Windows 11

@lizgt2000 Please help us in resolving this issue. Thanks

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


Is it Possible to execute SharePoint $batch REST API using SharePoint App Only Token?

Is it Possible to execute SharePoint $batch REST API using SharePoint App Only Token from the console app?
Is there any demo Batch Wrapper available to make SharePoint $batch API call from console app?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 047ea71c-e866-b2dd-5530-8451de27ba4a
Version Independent ID: 3b886e81-c3b7-d5c1-136f-4cb827b4952f
Content: Complete basic operations using SharePoint REST endpoints
Content Source: docs/sp-add-ins/complete-basic-operations-using-sharepoint-rest-endpoints.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

It all depends on what you're doing within the batch. The token is used by each request within the batch.
More details on the docs for batching here: https://docs.microsoft.com/en-us/sharepoint/dev/sp-add-ins/make-batch-requests-with-the-rest-apis

Hey @andrewconnell  Thanks for reply.
As per https://docs.microsoft.com/en-us/sharepoint/dev/sp-add-ins/make-batch-requests-with-the-rest-apis, In Given sample I don't know what is purpose if "Expect; 100-Continue"
I have noticed this is not there if we make batch request from the browser.
POST https://fabrikam.sharepoint.com/_api/$batch HTTP/1.1
Authorization: Bearer <access token omitted>
Content-Type: multipart/mixed; boundary=batch_e3b6819b-13c3-43bb-85b2-24b14122fed1
Host: fabrikam.sharepoint.com
Content-Length: 527
Expect: 100-continue

--batch_e3b6819b-13c3-43bb-85b2-24b14122fed1
Content-Type: application/http
Content-Transfer-Encoding: binary

GET https://fabrikam.sharepoint.com/_api/Web/lists/getbytitle('Composed%20Looks')/items?$select=Title HTTP/1.1

--batch_e3b6819b-13c3-43bb-85b2-24b14122fed1
Content-Type: application/http
Content-Transfer-Encoding: binary

GET https://fabrikam.sharepoint.com/_api/Web/lists/getbytitle('User%20Information%20List')/items?$select=Title HTTP/1.1

--batch_e3b6819b-13c3-43bb-85b2-24b14122fed1--

Is there any reason why $batch API does not work with Cross-Site or SubSite?
Assuming For SharePoint App Token it has Sites FullControl Permission and wants to get data from multiple sites using single $batch endpoint.

I'm fairly certain that's not possible... batch can only target a specific site, not multiple sites

Thanks @andrewconnell I am closing this issue. As I get information which I required.


Added simple coverage report

Main Changes
Added a simple coverage report that shows you how many times each Expr case class is used in the tests.

The output currently looks ugly, in the future I'll look into the possibility of using CodeCov.
Other
The pull request also includes:

some refactorings
small improvements in error messages
a bug fix that would cause some tests to randomly fail.

Pipeline consistently fails with Compilation failed with scala.Parser$ParseException: parsing fail which I cannot seem to replicate locally, will have to look into that.

The issue was that my branch had an outdated Exception definition. That was fine locally but the pipeline used the remote definition since that would be the end result of the merge and thus kept failing.
Moral of the story; always merge the remote branch to your branch before making a pull request.

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@fd215bb). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev       #9   +/-   ##
======================================
  Coverage       ?   66.66%
======================================
  Files          ?        1
  Lines          ?       45
  Branches       ?        0
======================================
  Hits           ?       30
  Misses         ?       15
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd215bb...d0efa44. Read the comment docs.

gamer


Implement references like in pandoc

Can you please implement references like in pandoc does. I have references in BibTeX file so it's very good to have this feature to me.

I work on this project in my (very limited) spare time and have no need for such a feature. Therefore I have no reason to implement it. However, we have created a complete [Extension API][1] so that anyone can add whatever features they desire. You are welcome to implement the feature yourself. You can get started by reviewing the [tutorial][2].
[1]; https://pythonhosted.org/Markdown/extensions/api.html
[2]: https://github.com/waylan/Python-Markdown/wiki/Tutorial:-Writing-Extensions-for-Python-Markdown


ModuleNotFoundError: No module named 'Crypto'

/usr/local/lib/python3.8/site-packages/flask_sqlalchemy/init.py:833: FSADeprecationWarning: SQLALCHEMY_TRACK_MODIFICATIONS adds significant overhead and will be disabled by default in the future.  Set it to True or False to suppress this warning.
warnings.warn(FSADeprecationWarning(
Traceback (most recent call last):
File "/opt/echo/app/echo.py", line 8, in
app = create_app()
File "/opt/echo/app/init.py", line 24, in create_app
db.create_all(app=app)
File "/usr/local/lib/python3.8/site-packages/flask_sqlalchemy/init.py", line 1039, in create_all
self._execute_for_all_tables(app, bind, 'create_all')
File "/usr/local/lib/python3.8/site-packages/flask_sqlalchemy/init.py", line 1031, in _execute_for_all_tables
op(bind=self.get_engine(app, bind), **extra)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/schema.py", line 4464, in create_all
bind._run_visitor(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2103, in _run_visitor
with self._optional_conn_ctx_manager(connection) as conn:
File "/usr/local/lib/python3.8/contextlib.py", line 113, in enter
return next(self.gen)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2095, in _optional_conn_ctx_manager
with self._contextual_connect() as conn:
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2311, in _contextual_connect
self._wrap_pool_connect(self.pool.connect, None),
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2345, in _wrap_pool_connect
return fn()
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 364, in connect
return _ConnectionFairy._checkout(self)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 778, in _checkout
fairy = _ConnectionRecord.checkout(pool)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 495, in checkout
rec = pool._do_get()
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/impl.py", line 140, in do_get
self.dec_overflow()
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/langhelpers.py", line 68, in exit
compat.raise(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/compat.py", line 178, in raise
raise exception
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/impl.py", line 137, in _do_get
return self._create_connection()
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 309, in _create_connection
return _ConnectionRecord(self)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 440, in init
self.__connect(first_connect_check=True)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 661, in connect
pool.logger.debug("Error on connect(): %s", e)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/langhelpers.py", line 68, in exit
compat.raise(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/compat.py", line 178, in raise
raise exception
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 656, in __connect
connection = pool._invoke_creator(self)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/strategies.py", line 114, in connect
return dialect.connect(*cargs, **cparams)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 490, in connect
return self.dbapi.connect(*cargs, **cparams)
File "/usr/local/lib/python3.8/site-packages/cymysql/init.py", line 84, in Connect
return Connection(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/cymysql/connections.py", line 248, in init
self._connect()
File "/usr/local/lib/python3.8/site-packages/cymysql/connections.py", line 414, in _connect
self._request_authentication()
File "/usr/local/lib/python3.8/site-packages/cymysql/connections.py", line 513, in _request_authentication
self._caching_sha2_authentication2(auth_packet, next_packet)
File "/usr/local/lib/python3.8/site-packages/cymysql/connections.py", line 535, in _caching_sha2_authentication2
from Crypto.PublicKey import RSA
ModuleNotFoundError: No module named 'Crypto'
Process finished with exit code 1
This problem always occurs, there will be time.clock () and other problems after installation

Can you give all the commands you ran and any relevant files or logs for reproducing the issue

A Dockerfile FROM python:3.8-buster with RUN pip install crypto should work for you
$ docker run -it --rm python:3.8-slim-buster bash
Unable to find image 'python:3.8-slim-buster' locally
3.8-slim-buster: Pulling from library/python
8559a31e96f4: Pull complete
62e60f3ef11e: Pull complete
93c8ae153782: Pull complete
ea222f757df7: Pull complete
e97d3933bbbe: Pull complete
Digest: sha256:938fd520a888e9dbac3de374b8ba495cc50fe96440030264a40f733052001895
Status: Downloaded newer image for python:3.8-slim-buster

root@266fefa76028:/# pip install crypto
Collecting crypto
  Downloading crypto-1.4.1-py2.py3-none-any.whl (18 kB)
Collecting shellescape
  Downloading shellescape-3.8.1-py2.py3-none-any.whl (3.1 kB)
Collecting Naked
  Downloading Naked-0.1.31-py2.py3-none-any.whl (590 kB)
     |████████████████████████████████| 590 kB 22.4 MB/s
Collecting pyyaml
  Downloading PyYAML-5.3.1.tar.gz (269 kB)
     |████████████████████████████████| 269 kB 26.8 MB/s
Collecting requests
  Downloading requests-2.23.0-py2.py3-none-any.whl (58 kB)
     |████████████████████████████████| 58 kB 5.3 MB/s
Collecting chardet<4,>=3.0.2
  Downloading chardet-3.0.4-py2.py3-none-any.whl (133 kB)
     |████████████████████████████████| 133 kB 40.1 MB/s
Collecting certifi>=2017.4.17
  Downloading certifi-2<IP_ADDRESS>-py2.py3-none-any.whl (157 kB)
     |████████████████████████████████| 157 kB 31.7 MB/s
Collecting idna<3,>=2.5
  Downloading idna-2.9-py2.py3-none-any.whl (58 kB)
     |████████████████████████████████| 58 kB 10.0 MB/s
Collecting urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1
  Downloading urllib3-1.25.9-py2.py3-none-any.whl (126 kB)
     |████████████████████████████████| 126 kB 38.3 MB/s
Building wheels for collected packages: pyyaml
  Building wheel for pyyaml (setup.py) ... done
  Created wheel for pyyaml: filename=PyYAML-5.3.1-cp38-cp38-linux_x86_64.whl size=44617 sha256=e1ccff2d18a54bd317fc80503b07527b0ccef502f346ea2881c0cb12b161a7d1
  Stored in directory: /root/.cache/pip/wheels/13/90/db/290ab3a34f2ef0b5a0f89235dc2d40fea83e77de84ed2dc05c
Successfully built pyyaml
Installing collected packages: shellescape, pyyaml, chardet, certifi, idna, urllib3, requests, Naked, crypto
Successfully installed Naked-0.1.31 certifi-2<IP_ADDRESS> chardet-3.0.4 crypto-1.4.1 idna-2.9 pyyaml-5.3.1 requests-2.23.0 shellescape-3.8.1 urllib3-1.25.9


Unable to resolve module react-native/Libraries/Core/Devtools/parseErrorStack from .../node_modules/reactotron-react-native/dist/index.js

Good morning.
After cloning my repository on other computer, I have this error on simulator and device.
Unable to resolve module react-native/Libraries/Core/Devtools/parseErrorStack from .../node_modules/reactotron-react-native/dist/index.js: Unable to find this module in its module map or any of the node_modules directories under /Users/node_modules/react-native/Libraries/Core/Devtools/parseErrorStack and its parent directories
I figured out that the folder required in reactotron-react-native/dist/index.js doesn't exist 'react-native/Libraries/Core/Devtools/parseErrorStack'.
If I change
parseErrorStack = parseErrorStack || require('react-native/Libraries/Core/Devtools/parseErrorStack')
symbolicateStackTrace = symbolicateStackTrace || require('react-native/Libraries/Core/Devtools/symbolicateStackTrace')
to
parseErrorStack = parseErrorStack || require('react-native/Libraries/JavaScriptAppEngine/Initialization/parseErrorStack');
symbolicateStackTrace = symbolicateStackTrace || require('react-native/Libraries/JavaScriptAppEngine/Initialization/symbolicateStackTrace');
My app works again.
Any suggestion? Thanks a lot

What version of react-native are you running?

react-native 0.34.1

Look like perhaps in 35 they moved files around.  These are all internal facing files for React Native, so, stuff like this is going to happen.
One thing we could do is what @flaz83 is suggesting, is have fallbacks.  I kinda wish there was an external facing version number for React Native we could check to do stuff like this.  There was talks a while ago about putting something on window.navigator, but I haven't checked in a few months to see if that came through.
Sorry for the stress.  Great work in deciphering that.
Is upgrading your RN an option?  I ask because if it's not an option (which NO is totally a fine answer!!!), then I'll look into making the change you suggest.

+1 to this issue, running react-native 0.35.0. I cloned my repository on another computer and started getting this error today.

Looks like they moved the files around in version 0.37.  Bummer.
I have the require inside a try/catch already, but require seems to be one of those things that can bring the house down if it's missing.
Still looking at a few options here to support older versions.

I'm using react-native 0.35.0 and ran into the same issue. @flaz83 Your fix worked. Thank you!

flaz83 I'm confused by your suggested fix.
I don't see the line you're suggesting to change in reactotron-react-native/dist/index.js
Do you have your fix in a fork that I could point against?

reactotron/blob/master/packages/reactotron-react-native/src/plugins/track-global-errors.js
line 74

Got it. Thanks @flaz83
Fix works me as well.

Another question: How do I rebuild the reactotron-react-native/dist dir after making the change in reactotron-react-native/src/plugins/track-global-errors.js?

@kumarpatel '''yarn (or npm) run build''' <- assumes node_modules are installed

Hi,
One more with same error on RN 0.35.0

Same as above. RN 0.35.0, and the fix proposed by @flaz83 does resolve the issue for me as well.

Any news?

Ok.  Sorry for the grief folks.
This is caused because facebook change the location of its' internal files in 0.37.0.
So... here's our outs:

Upgrade to React Native 0.37.0 🎉

In the meantime, if you can't or wont (which i totally understand!!!) I just made a new package called reactotron-react-native-under-37.  Uninstall your old one and install this one.
When you import or require, use:
import Reactotron from 'reactotron-react-native-under-37'

I don't plan on keeping this around forever, but hopefully this will make your codebases behave again.
Feel free to log any issues you find with this.  I've moved my projects up to RN 40 now, so I won't be actively testing this.

Thanks man! Just hit this. Running React Native 33.
This might just be the push I need to write some more tests so I can upgrade react native versions to the latest and greatest, with at least some sort of safety net.

@skellock
met this issue,
React Native 0.42.0


Minor Documentation Issue

Just a small question, in this example,
import YourMagicContainer from 'react-magic-hat'
import ComponentA, {id as CompA} from 'components'
import ComponentB from 'components'

const renderFrame = ({id, actions}) => {
  const Component = id === CompA ? ComponentA : ComponentB

  return <Component {...props} {...actions} />
}

const Layout = () => (
  <div>
    <YourMagicContainer renderFrame={renderFrame} />
  </div>
)

Where is the props coming from in the renderFrame function? Should there be another argument destructured from pageObject? Thanks!

Hello @NicholasLYang
Thank you very much for opening the issue.
I fixed and also tried to clarify a bit more how that part works.
I'm gonna close the issue but feel free to reopen if you think it should be reopened.
Thanks again!


Sort and find the maximum value

Address TODO from this PR: https://github.com/opendistro-for-elasticsearch/anomaly-detection-kibana-plugin/pull/62
//TODO: sorting and find the maximum value?

Test Array#reduce with current findAnomalyWithMaxAnomalyGrade. If array size exceeds 100K, can see big difference.  findAnomalyWithMaxAnomalyGrade takes less than 2ms by average, while Array#reduce takes more than 15ms by average.
Will not tune this method currently to avoid performance issue.


Update the Readme of the Smooth-App

What

Readme needs to be updated as one cannot initially understand the features and functionalities of the application by only reading the readme.
For example, Readme should include a demo video of how the application works and flow/ structure of the application, which is missing.

Can I work on this issue @g123k @M123-dev ?

To be more precise, what do you want to work on?
The README itself and/or the video?
Because an external video on YouTube (a commercial one?) could be used

I would first start with the readme and if the commercial video already exist, I can integrate it in the readme itself.

The README has been revamped. Feel free to reopen.


Scrolling sizing, search bar placement

Not sure why this occurred since main branch did not have compiling issues. See if the current version of Container.tsx in main differs from incoming PR's Container.tsx in some way. To see if deployment would be successful, running npm run build should pass all tests.
From Vercel deployment:
Failed to compile.
--
06:10:01.436 |
06:10:01.436 | ./components/Container/Container.tsx:49:13
06:10:01.436 | Type error: Cannot assign to 'current' because it is a read-only property.
06:10:01.436 |
06:10:01.436 | 47 \|         ref(instance);
06:10:01.436 | 48 \|       } else if (ref) {
06:10:01.436 | > 49 \|         ref.current = instance;
06:10:01.436 | \|             ^
06:10:01.436 | 50 \|       }
06:10:01.436 | 51 \|     };
06:10:01.436 | 52 \|
06:10:01.506 | Error: Command "npm run build" exited with 1

-- Windsor

I think I know why this happened, in order to insert the search bar, I had
to modify container.tsx to make label a prop and enable that prop to accept
components and strings as a type. this might have broke it.
On Thu, Nov 23, 2023 at 7:01 AM Windsor Nguyễn @.***>
wrote:

Not sure why this occurred since main branch did not have compiling
issues. See if the current version of Container.tsx in main differs from
incoming PR's Container.tsx in some way. To see if deployment would be
successful, running npm run build should pass all tests.
From Vercel deployment:
Failed to compile.
06:10:01.436 |
06:10:01.436 | ./components/Container/Container.tsx:49:13
06:10:01.436 | Type error: Cannot assign to 'current' because it is a read-only property.
06:10:01.436 |
06:10:01.436 | 47 |         ref(instance);
06:10:01.436 | 48 |       } else if (ref) {
06:10:01.436 | > 49 |         ref.current = instance;
06:10:01.436 | |             ^
06:10:01.436 | 50 |       }
06:10:01.436 | 51 |     };
06:10:01.436 | 52 |
06:10:01.506 | Error: Command "npm run build" exited with 1
-- Windsor
—
Reply to this email directly, view it on GitHub
https://github.com/cos333project/compass/pull/15#issuecomment-1824312730,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPBOT35KBPBETM4V4BPXZLYF43I5AVCNFSM6AAAAAA7XUYNTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGMYTENZTGA
.
You are receiving this because you were assigned.Message ID:
@.***>

I think I know why this happened, in order to insert the search bar, I had to modify container.tsx to make label a prop and enable that prop to accept components and strings as a type. this might have broke it.
…
On Thu, Nov 23, 2023 at 7:01 AM Windsor Nguyễn @.> wrote: Not sure why this occurred since main branch did not have compiling issues. See if the current version of Container.tsx in main differs from incoming PR's Container.tsx in some way. To see if deployment would be successful, running npm run build should pass all tests. From Vercel deployment: Failed to compile. -- 06:10:01.436 | 06:10:01.436 | ./components/Container/Container.tsx:49:13 06:10:01.436 | Type error: Cannot assign to 'current' because it is a read-only property. 06:10:01.436 | 06:10:01.436 | 47 | ref(instance); 06:10:01.436 | 48 | } else if (ref) { 06:10:01.436 | > 49 | ref.current = instance; 06:10:01.436 | | ^ 06:10:01.436 | 50 | } 06:10:01.436 | 51 | }; 06:10:01.436 | 52 | 06:10:01.506 | Error: Command "npm run build" exited with 1 -- Windsor — Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXPBOT35KBPBETM4V4BPXZLYF43I5AVCNFSM6AAAAAA7XUYNTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGMYTENZTGA . You are receiving this because you were assigned.Message ID: @.>

Great! Merging...


ECMPS UI Updates - Monitoring Plan Screen Updates

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[x] Does this have a dev link been provided in the design?
[x] Is this traceable to a feature, epic, or PI?

User Story
As an ECMPS user, I want ECMPS UI to be updated so that the usability of the application is improved
Acceptance Criteria

When a user has multiple tabs for Configurations open, the color of the Inactive tab should be updated to a darker grey.  Update the color on the locked Configuration tabs to a darker grey ( #Base Dark 565C65)
Move the 'Last Checked out by' information
Update 'View Comments' and 'Reports' links to buttons (same as Evaluate and Submit)
Move the 'View Comments' and 'Reports' buttons next to Check back in
Remove pagination on any configuration tabs (Defaults, Loads, Spans from the Sections Dropdown)
Remove Keywords Filter on any configuration tabs (Defaults, Loads, Spans from the Sections Dropdown)
Move Evaluate and Submit buttons as in the prototype above the Revert to Official Record
Update the background for Evaluate and Submit buttons to a darker blue (Blue Base #005EA2)

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
https://xd.adobe.com/view/c0323c1f-e508-4e16-8551-5f66caf78487-9561/
Testing
Test Case:
Tester:
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[x] Is the user story ready to be deployed to the test/staging environments?

Test Passed


Just check pint

I killed all the other tests and added a simple pint calculation

But the weird thing is that in my other PRs it worked without a problem, so it must be somehow related to the changes in arbitrary_type as well


KubeRay 2023 Roadmap

2023 will come soon and let's brainstorm the wishlist for KubeRay and come up clear strategies for 2023.

What does KubeRay look like at end of 2023?
What's the concentrations (stability, ease of use, performance, features etc) for each release?
How can we achieve the goal? Does KubeRay have enough contributors? Does it have exptectd adoptions?

I finally get some time to work on this story.  I will work with community forks to create a draft version and make it available for public review by early March. The goal is likely to receive feedback on the project from a wider audience in order to refine and improve it before releasing a final version.
Hope this collaborative approach can help to ensure that the project meets the needs and expectations of KubeRay users and reflects the diverse perspectives of the community.

Do you plan to start collecting these ideas as issues/features here in repo?

@gvspraveen not yet. I have some items in mind and some of them have references. It would be great to combine maintainer's ideas and user's request together.
I wrote some rough ideas and let's collaborate on it.
https://docs.google.com/document/d/1Jnj8EjGvxUDrc5zSvevIXMKGEcI9E3i2KdmviCxEY8k/edit#

For scalability and stability, I think raycluster/rayjob/rayservice HA and support for different upgrade strategies should be taken into consideration.


Some gold standard phenotype nodes are not present in the merged KG

As per Guojing Cong:

I noticed some of the golden standard ids are not in the graph,  for example, 'HP:0025668'

I had expected all nodes with these gold standard phenotype vs. phenotype equivalency relationships to be present in the KG, but this may not be the case. Should check to see how many really are present in the graph or not.
monarch.owl does not import the entirety of HP or MP (see https://github.com/monarch-initiative/monarch-ontology/blob/master/monarch.owl) but it does import http://purl.obolibrary.org/obo/upheno/metazoa.owl and http://purl.obolibrary.org/obo/upheno/hp-mp/mp_hp-align-equiv.owl .

Possibly some of these nodes are newer HPO terms not present in our KG yet. For example, HP:0025668 doesn't seem to be on at least one HPO browser

I found six HPO terms present in the gold standard but not in the graph nodes:
HP:0025668
HP:0025675
HP:0025692
HP:0025707
HP:0025713
HP:0025722

and the same for MP:
MP:0021107
MP:0031312
MP:0031313
MP:0031314
MP:0031315
MP:0031316
MP:0031343
MP:0031344
MP:0031345
MP:0031347
MP:0031349
MP:0031350
MP:0031358

Ok thanks! You are not using upheno2?

This is an old issue but all of the above CURIEs are not present as of KG build 20241203.


Use always all available controllers.

If several controllers are specified, use always all of them.
This PR deprecates the availability of an hot standby controller.

Doesn't this straight-down remove the possibility of a hot-standby controller? Please write a mail to the dev-list first.


Unable to add blank tileset (from panel) without logging in to Ion

There isn't a reason to require a Cesium Ion login to add a blank tileset to the scene. For users currently stuck on this issue, a blank tileset can be added by searching for the "Cesium3DTileset" actor in the "Place Actors" panel.
The "Add Blank" option is greyed out when not logged in to Cesium Ion.

The option you're hovering over opens the panel to add a tileset from ion. You need to be logged in for that. There used to be an "Add Blank" button, but we got rid of it last release and replaced it with the "Blank 3D Tiles Tileset" item below the toolbar. Hopefully that one still works when not logged in to ion?

Ah I don't know how I missed that, I just got confused with what that symbol used to be! I think the panel works as intended then.


Int num_sanity_val_steps is always replaced by float limit_val_batches

The type annotations of num_sanity_val_steps: and limit_val_batches are int and Union[int, float] for percent or num_batches. The minimum of percent and num_batches will be percent. (except when num_batches==0)
https://github.com/PyTorchLightning/pytorch-lightning/blob/a59e140ee814d8818d121405582133cf6b767e1a/pytorch_lightning/trainer/trainer.py#L461
Maybe we can remove the dependency of limit_val_batches from num_sanity_val_steps and revert to
https://github.com/PyTorchLightning/pytorch-lightning/blob/1e68968ed7fb9b8f73df148dd48194d469655ea3/pytorch_lightning/trainer/trainer.py#L491

@williamFalcon @Borda should num_sanity_val_steps be limited by limit_val_batches? My understanding is they can be independent of one another.

@ananyahjha93 I asked william some time ago: https://github.com/PyTorchLightning/pytorch-lightning/pull/2246#issuecomment-650685045

Here: https://github.com/PyTorchLightning/pytorch-lightning/pull/2246#issuecomment-651398674
Shouldn't Trainer(num_sanity_val_steps=5, limit_val_batches=3) run 3 sanity val steps?

@awaelchli any comments on above? We can fix it then :)

It depends. What does it currently do in your example?

In the https://github.com/PyTorchLightning/pytorch-lightning/pull/2246#issuecomment-651398674 you said it should run for 5 val_steps but here https://github.com/PyTorchLightning/pytorch-lightning/blob/0097630a95bddc48d6fb5d3b9a58aef2e8e89b22/pytorch_lightning/trainer/trainer.py#L463-L466 it seems that it's running for 3 val_steps.
I suggest num_sanity_val_steps should be updated according to limit_val_batches(both float and int) and then we can merge https://github.com/PyTorchLightning/pytorch-lightning/pull/2892/ accordingly.

num_sanity_val_steps should be int or -1.
this is really meant to be a sanity check... floats will break this.


Hiredis 0.12.0

Hey everybody,
I have created a develop branch for hiredis, and would like to get this going by going through a variety of outstanding issues and pull requests to see what we might want to get tested and incorporated for the next official release :smiley_cat:!
Things I'm pretty sure we should merge:

#286 -- This one looks good.  I agree with @mattsta that we should probably backport dict.c from Redis, but it seems reasonable to incorporate this one first (as it's a quick one).
#285, #282, #267 -- Just a tiny grammar fixes, but they look correct to me, so we should merge.
#268 -- I need to test this one, but generally speaking I like being idiomatic and using const char * vs. char * so it's clear that the string isn't going to be modified.
#260 -- We've been using this in production for ages, and as of yet it has not ruined everything.  I think we should merge.
#251 -- This fixes a libuv compile error, and I favor it over the similar #258 as the non-static declaration isn't necessary at all as far as I can tell.

Things we might want to merge:

#279 -- This is probably technically correct, but it's not something that really bothers me one way or the other.  There are only a few calloc calls in hiredis, and they vary on argument order (when creating just 1 thing).
#264 -- This one looks fine to me, but I'm only mildly familiar with this TCP option.  Just read up on it and I don't see how it would cause any issues.
#261 -- I vote yes on this one, but @pietern mentioned that it would break downstream packages, so I'm curious in what way that would be.
#254 -- I would like some input from fancier individuals such as @mattsta or @badboy.  :smiley:
#250 -- IMHO I can see why this could be useful (in the case where a custom free was being used), but is not something I have personally run into.
#239 -- I'll investigate and test this myself, but on first glance it looks good.

So that takes us back roughly a year for pull requests.  I am going to familiarize myself with the ng branch next and see about moving that forward.  I think however this is a good start.  Most of these are very small and should be pretty safe.
Cheers guys!
Mike

All the PRs above look good (with changes where necessary).  I've got them in a local develop branch and I'll push it up here later today.

develop updated with:
f28872c Cleanup tabs and end of line whitespace
dad0516 Update dependency list in Makefile
9abfdf9 Build static library by default
1d2b4d3 Generate pkgconf during build
cc20232 Fix errno error buffers to not clobber errors
ba3e74c Refactor reading code into read.c
0cacb48 Fix sds building with C++
6a00a46 Fix redisAppendCommand error result
0c9ff5b Add GLib 2.0 adapter
e30c96e Add empty pointer check in error cleanup
d1e820d Add error check in redisContextInit
b6a8607 Fix redisvFormatCommand format parsing
9a753b4 Add API to free hiredis (sds) formattings
1b392eb Add API to free hiredis (char *) formattings
85c6bfb Fix build under kfreebsd
9b83ddc Fix clang analyzer warning
7c4d255 Add support for SO_REUSEADDR
a1bc89b Improve calloc() correctness
9c57314 Cleanup libuv adapter
40f7035 Improve redisAppendCommandArgv performance
3315c09 Use stricter function argument types
865a368 Fix README typos
2d814b8 Fix minor comment problems
abbd340 Fix README typo
2a6dbdd Free string if it is unused
a1f6ce0 Add syntax highlighting to README.md
Test/read/check those commits and keep suggesting a few more fixes/changes for the next version!

How about including the following patch to avoid the ugly warning:
/usr/include/features.h:148:3: warning: "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
      [-W#warnings]

Patch:
diff --git i/fmacros.h w/fmacros.h
index 9e5fec0..1beee89 100644
--- i/fmacros.h
+++ w/fmacros.h
@@ -3,6 +3,7 @@

 #if !defined(_BSD_SOURCE)
 #define _BSD_SOURCE
+#define _DEFAULT_SOURCE
 #endif

 #if defined(__sun__)

Any more requests before develop gets promoted to master in a few days?

Creating new version tomorrow.  Looking at the release page, the last proper release was over two years ago.  Whoops.

All good things are worth waiting for. (or in German: Was lange währt, wird endlich gut)

0.12.0 is done as of https://github.com/redis/hiredis/tree/7b51834c165133cf6816b1991920a55bdc64ea78
We can add any bug fixes in 0.12.x versions and the next major release will be 1.0.0.

oh, and big thanks to @michael-grunder and @badboy for doing all the real work of figuring out exactly what to add/fix and how to add/fix things out of the hiredis issues/PR backlog.  :)

Nice! Great work.

At this point it's mostly open source gardening.  You did all the real great work years ago.  :)

I'm happy to contribute here. Again thanks to all of you.


Add ability to create a contact

Ideally this would include viewing, editing, deleting, and adding a new contact but only having the ability to add a contact in the admin UI is fine for first pass

Viewing and deleting should already be implemented, but I'll double check next week. And Ill create a ticket for added the ability to edit an existing contact.


NIFI-12351 Improve MiNiFi Service Scripts for Windows

Summary
NIFI-12351
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@rliszli Thanks for the change, without going deeper into the code aspect could you please add some details either to the ticket or the PR or even better to the README to explain what the change addresses, what is the intended behaviour change and how it can be validated?

Concurring with @bejancsaba, it would be helpful to elaborate on the goal of these changes. I updated the pull request title to reflect that fact that the changes related to service scripts for MiNiFi on Windows, but it would be helpful to summarize the intended improvements.

Thanks for the suggestions and for the better naming. I added a short list for this PR containing the main elements of the change. I'll also update the minifi-java-agent-quick-start.md with a more detailed instructions on how to install as a service with the new scripts.

Thanks for the changes it is an area which clearly can benefit from some improvement. Maybe something is not right on my side but I'm getting the following
Previously I only tested it on Windows 10. After this included Windows Server 2019 as well. Now should work on both.

@rliszli This seems close to completion, aside from the one merge conflict. @bejancsaba I will defer to you for further review.

@rliszli and @bejancsaba any updates on bringing this pull request to completion?

@exceptionfactory: We still have one issue that needs to be addressed. I'll close the PR until it gets resolved.


[Class hierarchy] CL:0002278 'GIP cell', missing link to small intestine

CL term
CL:0002278 'GIP cell'
"An enteroendocrine cell of duodenum and jejunum that produces gastric inhibitory peptide."
Suggested revision and reasons
Could be improved by adding part_of 'small intestine' (where duodenum and jejunum are both located).
Thanks,
Paola

@paolaroncaglia ,
It looks like the GIP cell is already
'part of' some 'small intestine'

in the current CL release.
Can I close this ticket?

Thanks @rays22 , I'll close.


Add plot_forest

Split the current plot_forest into two functions plot_forest (intervals)  this issue and plot_ridge (mountain-range kde-like) #7
For list of dataset/inferencedata input we might need another loop strategy
NOTE: __variable__  only works for facetting right now, it is needed for this to work with aesthetics when there are multiple variables.

closed by https://github.com/arviz-devs/arviz-plots/pull/34