Add a yarn dependency source

As found in https://github.com/github/licensed/issues/30#issuecomment-386129385

The errors appear to be because my package.json file is actually intended for yarn, and uses some syntax that is not npm-compatible

Yarn's package.json files attempt to be compatible with NPM package.json files but can contain differences that cause the NPM dependency source to fail.
It looks like an indicator that yarn should be used and that npm shouldn't be used is the presence of a yarn.lock file.

I took a look through the yarn CLI and unless I'm missing something, it's nowhere near as easy to enumerate all the data that we need as it is from npm.
I could use some help figuring out either

how to enumerate the name, version, directory location (mandatory) and homepage, author (optional, but needed to have parity with the npm source)
if it's possible to use npm cli commands with a yarn package.json

I've started a pr to have the path added to yarn list --json: https://github.com/yarnpkg/yarn/pull/7462


Graceful failure when operations not implemented

https://github.com/NCATSTranslator/testing/issues/113

Now returns the appropriate 422


Add Storybook interaction tests with WDIO tests

The PR will add Storybook interaction testing to the service, meaning you can also create tests for the storybook components to interact with them which will automatically be picked up by the storybook runner.
Storybook Interaction Testing
Storybook Interaction Testing allows you to interact with your component by creating custom scripts with WDIO commands to set a component into a certain state. For example, see the code snippet below:
import { browser, expect } from "@wdio/globals";

describe("Storybook Interaction", () => {
    it("should create screenshots for the logged in state when it logs out", async () => {
        const componentId = "example-page--logged-in";
        await browser.waitForStorybookComponentToBeLoaded({ id: componentId });

        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-in-state`
        );
        await $("button=Log out").click();
        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-out-state`
        );
    });

    it("should create screenshots for the logged out state when it logs in", async () => {
        const componentId = "example-page--logged-out";
        await browser.waitForStorybookComponentToBeLoaded({ id: componentId });

        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-out-state`
        );
        await $("button=Log in").click();
        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-in-state`
        );
    });
});

Two tests on two different components are executed. Each test first sets a state and then takes a screenshot. You will also notice that a new custom command has been introduced, which can be found here.
The above spec file can be saved in a folder and added to the command line with the following command:
npm run test.local.desktop.storybook.localhost -- --spec='tests/specs/storybook-interaction/*.ts'

The Storybook runner will first automatically scan your Storybook instance and then add your tests to the stories that need to be compared. If you don't want the components that you use for interaction testing to be compared twice, you can add a filter to remove the "default" stories from the scan by providing the --skipStories filter. This would look like this:
npm run test.local.desktop.storybook.localhost -- --skipStories="/example-page.*/gm" --spec='tests/specs/storybook-interaction/*.ts'

New Custom Command
A new custom command called browser.waitForStorybookComponentToBeLoaded({ id: 'componentId' }) will be added to the browser/driver-object that will automatically load the component and wait for it to be done, so you don't need to use the browser.url('url.com') method. It can be used like this
import { browser, expect } from "@wdio/globals";

describe("Storybook Interaction", () => {
    it("should create screenshots for the logged in state when it logs out", async () => {
        const componentId = "example-page--logged-in";
        await browser.waitForStorybookComponentToBeLoaded({ id: componentId });

        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-in-state`
        );
        await $("button=Log out").click();
        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-out-state`
        );
    });

    it("should create screenshots for the logged out state when it logs in", async () => {
        const componentId = "example-page--logged-out";
        await browser.waitForStorybookComponentToBeLoaded({ id: componentId });

        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-out-state`
        );
        await $("button=Log in").click();
        await expect($("header")).toMatchElementSnapshot(
            `${componentId}-logged-in-state`
        );
    });
});

The options are:
clipSelector

Type: string
Mandatory: No
Default: #storybook-root > :first-child for Storybook V7 and #root > :first-child:not(script):not(style) for Storybook V6
Example:

await browser.waitForStorybookComponentToBeLoaded({
    clipSelector: "#your-selector",
    id: "componentId",
});

This is the selector that will be used:

to select the element to take the screenshot of
for the element to wait to be visible before a screenshot is taken

id

Type: string
Mandatory: yes
Example:

await browser.waitForStorybookComponentToBeLoaded({ '#your-selector', id: 'componentId' })

Use the id of the story that can be found in the URL of the story. For example, the id in this URL http://localhost:6006/?path=/story/example-page--logged-out is example-page--logged-out
timeout

Type: number
Mandatory: No
Default: 1100 milliseconds
Example:

await browser.waitForStorybookComponentToBeLoaded({
    id: "componentId",
    timeout: 20000,
});

The max timeout we want to wait for a component to be visible after loading on the page
url

Type: string
Mandatory: No
Default: http://<IP_ADDRESS>:6006
Example:

await browser.waitForStorybookComponentToBeLoaded({
    id: "componentId",
    url: "https://your.url",
});

The URL where your Storybook instance is hosted.

@christian-bromann ,
Thanks for reviewing!

One comment otherwise LGTM 👍
Let's not forget to copy the docs over to the website docs. We can also look into finding ways to automatically pull docs from this repository, if it helps. We do this for expect-webdriverio already.

I was doubting about creating the docs PR, due to the fact that we want to change the behaviour for V9, or do you think we can already put it in the docs in V8? If you say ok I will create a PR for it


inject log with labels

follow: https://github.com/istio/istio/pull/53106

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all


Parkinson's Disease Prediction Model Addition

Is your feature request related to a problem? Please describe.
Ans. Our repository emphasizes mental health prediction models, but it doesn't currently include one for Parkinson's disease. This is crucial as Parkinson's is linked to mental health issues like depression and anxiety. Predicting Parkinson's could indirectly support mental health efforts by enabling early intervention for interconnected conditions. Therefore, adding this model would align with our goal of promoting well-being.
Describe the solution you'd like
Ans. Let's add a Parkinson's disease prediction model. It would analyze demographics, medical history, and possibly genetics to predict the risk of developing Parkinson's.
Describe alternatives you've considered
Ans. We could collaborate with others, but an in-house model would give us more control.
Additional context
I'm eager to contribute, and I believe incorporating this model aligns with our goal of promoting overall well-being.

@priyankaangane
Parkinson's disease is not directly related to depression or anxiety, as these mood disorders are common non-motor symptoms of the condition. While not everyone with Parkinson's disease experiences depression or anxiety, these conditions can arise due to various factors associated with the disease. however, it still aligns with our objective in one way or another. Therefore, I'll assign this as a level 1 issue to you. is it fine by you?

@TAHIR0110
Thank you for considering the feature issue I raised. I understand that while Parkinson's disease isn't directly related to depression or anxiety, they can still be one of the aspects to consider. I'll address this level 1 issue accordingly.

@priyankaangane assigned!

Hey @TAHIR0110 I want to work on this issue.Kindly assign me this issue .

Hi @TAHIR0110  I wish to work on this issue. Kindly assign me this issue.

please assign me the project i want to work on it

Hi @TAHIR0110,
I wanted to inform you that I've submitted a pull request (#82 ) to address the issue [#41]. In the pull request, I've implemented functionality for Parkinson's disease prediction using machine learning models. This includes data preprocessing, model training, evaluation, hyperparameter tuning, and prediction based on both audio features and symptoms provided by the user.
I would appreciate it if you could take some time to review the changes and provide your feedback.
Thanks,
Priyanka Angane

hey @TAHIR0110  I would like to work on this issue. Can you please assign it to me?


Fix for DPI Scaled Monitors (and Screenshot scaling)

I have ran across an issue on my setup with the screenshots being offset compared to the screen coordinate system
After debugging and finding nothing I stumbled upon this
Basically on Windows if there is DPI scaling active the coordinates are also scaled.
This means there needs to be a change to the function in screenshot utils.
Feel free to merge my pull request, but I also fixed a secondary scaling issue (and blackmattered the code)
But the real changes are these:
screenshot_utils.py
    def mouseReleaseEvent(self, event):
        self.rubberband.hide()
        self.end = event.pos()
        selected_rect = QRect(self.begin, self.end).normalized()

        # Get the device pixel ratio
        screen = QApplication.primaryScreen()
        device_pixel_ratio = screen.devicePixelRatio()

        # Adjust the selected rectangle to account for the screen geometry and device pixel ratio
        screen_geometry = screen.virtualGeometry()
        selected_rect.moveTopLeft(selected_rect.topLeft() + screen_geometry.topLeft())
        selected_rect = QRect(
            int(selected_rect.x() * device_pixel_ratio),
            int(selected_rect.y() * device_pixel_ratio),
            int(selected_rect.width() * device_pixel_ratio),
            int(selected_rect.height() * device_pixel_ratio),
        )

        if selected_rect.width() * selected_rect.height() < 64:
            screenshot = self.screenshot.copy()  # Use the entire screenshot
        else:
            screenshot = self.screenshot.copy(selected_rect)  # Use selected area
        self.screenshot_taken.emit(screenshot)
        self.close()

def process_image(pixmap, min_size=256, max_size=1280):
    # Convert QPixmap to QImage if it isn't already a QImage
    image = pixmap.toImage() if isinstance(pixmap, QPixmap) else pixmap

    # Get the original size of the image
    original_width = image.width()
    original_height = image.height()

    # Ensure the scaled image fits within our constraints while maintaining aspect ratio
    if original_width <= min_size and original_height <= min_size:
        scale_factor = min(min_size / original_width, min_size / original_height)
    elif original_width >= max_size and original_height >= max_size:
        scale_factor = max(max_size / original_width, max_size / original_height)
    else:
        scale_factor = 1.0

    # Ensure the aspect ratio is maintained
    if original_width > original_height:
        new_width = min(original_width * scale_factor, max_size)
        new_height = int(new_width / original_width * original_height)
    else:  # original_width <= original_height
        new_height = min(original_height * scale_factor, max_size)
        new_width = int(original_width / original_height * new_height)

    # Create a scaled QImage object
    scaled_image = image.scaled(
        int(new_width),
        int(new_height),
        Qt.AspectRatioMode.KeepAspectRatio,
        Qt.TransformationMode.SmoothTransformation,
    )

    return scaled_image

main.py
    def handle_screenshot(self, screenshot):
        print("Handling screenshot")  # Debug print

        # Process the screenshot to ensure it is within the desired size range
        processed_screenshot = process_image(screenshot)

        self.selected_screenshot = processed_screenshot
        self.show()  # Show the window first
        QTimer.singleShot(
            200, self._post_screenshot_actions
        )  # Increased delay slightly

Thanks for sharing this, so this explains the offset on the 4k monitor.


RVGate rotation as multiple of pi radians, and RV synthesis routine

The RVGate is modified so that the rotation angle is more natural in multiples of pi radians. This way gates can be represented as points on a unit ball. We have the following correspondences:
RV(1, 0, 0) --> X
RV(0, 1, 0) --> Y
RV(0, 0, 1) --> Z
RV(1/sqrt(2), 0, 1/sqrt(2)) --> H
RV(1/2, 0, 0) --> sqrt(X)
RV(0, 0, 1/4) --> T

Also I added a new synthesis so we can convert all single qubit gates to RV.

Units of radians seems more natural to me but I don't feel super strongly.
Synthesis is nice to have but should rebase on top of #5827 once that lands.

Just as one might consider the XGate as the convenience function for RXGate(pi) I consider the RVGate to be the generalization of the Rx, Ry, Rz rotation gates but at arbitrary direction. It also has a standard meaning as for instance described at https://en.wikipedia.org/wiki/Euler's_rotation_theorem and here https://en.wikipedia.org/wiki/Axis–angle_representation.

Another alternative that might make things more convenient is to use axis-angle representation where you specify a vector of arbitrary magnitude and the rotation angle.

I don't want axis-angle because I need a smooth parameterization, ie one that has the property that if the distance between unitaries is small, so is the distance between the parameter vectors. More generally, want the jacobian to be well behaved at all points, so that local search works nicely.

Units of radians seems more natural to me but I don't feel super strongly.

It is radians still, but multiplied by pi.

Another alternative that might make things more convenient is to use axis-angle representation where you specify a vector of arbitrary magnitude and the rotation angle.

Yes if you specified the angle separately it would make sense to me. But here the angle is implicit in the magnitude of the vector. So I would consider "whole rotation" or "half rotation" about the axis to be more naturally represented by magnitudes.
You can think of it as equivalents of XGate().pow(1) or XGate().pow(.5) (not equivalent of RX).
The way it is, if you want to write the Hadamard gate it becomes RVGate(pi/sqrt(2), 0, pi/sqrt(2)) (pi over sqrt(2) seems weird to me). By the way I got the unit ball representation from fig 5 https://threeplusone.com/pubs/on_gates.pdf

By the same reasoning we could also make RXGate(1) = XGate() but it would be non-customary. For instance it more closely corresponds to the vector in eq. 2.58 in Nielson & Chuang.

I'm good to make two gates, one being a rotation with explicit theta and another with what Lev wants in terms of magnitude that represent fractional turns around the axis of rotation. But vector magnitudes in pi is not natural IMO. RX doesn't rely on magnitudes and so RX(pi) is good.

@levbishop How do you feel about the numerical advantage argument in that link I posted (Section 4.3)?

@levbishop How do you feel about the numerical advantage argument in that link I posted (Section 4.3)?

You mean the argument that binary fractional powers of paulis could be represented exactly without floating point roundoff? That seems has some small weight on making RX/RY/RZ take units of pi, but I don't buy it for RV. It wouldn't help eg for using RV to represent H (since sqrt(2) has no exact FP representation)

Since RVGate was released in its current form in Terra 0.17, it's not eligible to have its convention changed within our stability policy.  It's subjective which convention is better, but since we've already released in one, we can't change it now except for an overwhelmingly compelling technical reason, which I don't think the discussion here raises to.
The extended synthesis routines for the gate added in this PR still look good though - are these something we should continue with trying to merge?


3.11 and 3.10 stay always minimized in tray

OS: Xubuntu 20.04.1
App version: 3.1.X
Installation type: dpkg -i rocketchat_3.1.X_amd64.deb
Description
Application 3.1.0 and 3.1.1 started successfully but always stay minimized in tray.
I can't open application window after that at all!
Application running but present in tray only as icon. That's it.
Expected Behavior
Application version 3.0.7 doesn't have this bug.

Same for me.
OS : Kubuntu 20.04
App version : 3.1.1
Installation : flathub repo

Same for me.
OS : Kubuntu 20.04
App version : 3.1.1
Installation : flathub repo

Same for me.
OS : KDE Neon
App version : 3.1.1
Installation : debian package

Same for me.
OS : KDE Neon
App version : 3.1.1
Installation : debian package

Same here (Xubuntu).
Also every time I change View > Tray Icon (on or off), application will crash. Then it will start with Tray icon displayed/hidden as it should (according to setting).
kernel: [ 7424.091337] rocketchat-desk[14439]: segfault at ffffcba1294ab7f9 ip<PHONE_NUMBER>83e32d sp 00007ffc3bd75020 error 5 in rocketchat-desktop[55704074b000+5f8d000]
kernel: [ 7424.091346] Code: c3 cc cc cc cc cc cc cc cc cc cc cc cc 55 48 89 e5 41 56 53 48 83 ec 20 48 8b 87 98 fc ff ff 48 8d b7 98 fc ff ff 48 8d 7d d8 <ff> 90 b8 00 00 00 48 8b 5d d8 4c 8b 75 e0 4c 39 f3 74 1a 48 8b 3b
kernel: [ 7652.225593] rocketchat-desk[14623]: segfault at 8 ip 00005579facf673c sp 00007ffeb22446c0 error 4 in rocketchat-desktop[5579fac02000+5f8d000]
kernel: [ 7652.225604] Code: 55 d8 48 8b 45 e0 48 8b 0e 48 8b 5e 08 48 89 df 48 29 cf 48 c1 ff 03 48 39 c7 48 0f 43 f8 48 39 fa 74 95 48 8b 3c d1 48 8b 07 <ff> 50 08 48 8b 75 d0 48 85 f6 0f 84 d5 00 00 00 48 8b 45 d8 48 8b

Same here (Xubuntu).
Also every time I change View > Tray Icon (on or off), application will crash. Then it will start with Tray icon displayed/hidden as it should (according to setting).
kernel: [ 7424.091337] rocketchat-desk[14439]: segfault at ffffcba1294ab7f9 ip<PHONE_NUMBER>83e32d sp 00007ffc3bd75020 error 5 in rocketchat-desktop[55704074b000+5f8d000]
kernel: [ 7424.091346] Code: c3 cc cc cc cc cc cc cc cc cc cc cc cc 55 48 89 e5 41 56 53 48 83 ec 20 48 8b 87 98 fc ff ff 48 8d b7 98 fc ff ff 48 8d 7d d8 <ff> 90 b8 00 00 00 48 8b 5d d8 4c 8b 75 e0 4c 39 f3 74 1a 48 8b 3b
kernel: [ 7652.225593] rocketchat-desk[14623]: segfault at 8 ip 00005579facf673c sp 00007ffeb22446c0 error 4 in rocketchat-desktop[5579fac02000+5f8d000]
kernel: [ 7652.225604] Code: 55 d8 48 8b 45 e0 48 8b 0e 48 8b 5e 08 48 89 df 48 29 cf 48 c1 ff 03 48 39 c7 48 0f 43 f8 48 39 fa 74 95 48 8b 3c d1 48 8b 07 <ff> 50 08 48 8b 75 d0 48 85 f6 0f 84 d5 00 00 00 48 8b 45 d8 48 8b

Same here,
OS: Fedora 33
App version : 3.1.1
Installation: RPM package
Window Manager: Openbox 3.6.1
Panel: lxpanel 0.10.0
Version 3.0.7 works well.

Same here,
OS: Fedora 33
App version : 3.1.1
Installation: RPM package
Window Manager: Openbox 3.6.1
Panel: lxpanel 0.10.0
Version 3.0.7 works well.

Same here,
OS: Fedora 33
App version : 3.1.1
Installation: RPM package
Window Manager: Openbox 3.6.1
Panel: lxpanel 0.10.0
Version 3.0.7 works well.

Same here,
OS: Fedora 33
App version : 3.1.1
Installation: RPM package
Window Manager: Openbox 3.6.1
Panel: lxpanel 0.10.0
Version 3.0.7 works well.

same here, at first run all looks good, once the window is hidden and only the tray icon is visible, i found no way to recover - not even by restarting the client
OS: CentOS 7.9
App version: 3.1.1
Installation: RPM package
Desktop: MATE (mate-panel-1.16.2-1.el7.x86_64)
3.0.x worked fine, 3.1 is practically unusable.

same here, at first run all looks good, once the window is hidden and only the tray icon is visible, i found no way to recover - not even by restarting the client
OS: CentOS 7.9
App version: 3.1.1
Installation: RPM package
Desktop: MATE (mate-panel-1.16.2-1.el7.x86_64)
3.0.x worked fine, 3.1 is practically unusable.

Same for me with Linux Mint Cinnamon 20.1
Issue with 3.1.0 and 3.1.1.
3.0.7 - works fine

Same for me with Linux Mint Cinnamon 20.1
Issue with 3.1.0 and 3.1.1.
3.0.7 - works fine

Same Problem here
OS: Ubuntu 16.04.7
Desktop: MATE
3.0.7 worked fine but had some other problems

Same Problem here
OS: Ubuntu 16.04.7
Desktop: MATE
3.0.7 worked fine but had some other problems

Same for me. Also the icon doesn't update to show the notification red dot. One shouldn't count on it to see if you have missed messages.
RC Version 3.1.1
AUR Package
Manjaro 20.2.1
XFCE 4.14
Works after downgrading to 3.0.7

Same for me. Also the icon doesn't update to show the notification red dot. One shouldn't count on it to see if you have missed messages.
RC Version 3.1.1
AUR Package
Manjaro 20.2.1
XFCE 4.14
Works after downgrading to 3.0.7

Same here. The icon is also "frozen" for me and doesn't update with new messages.
OS: Linux Mint 20.1 Ulyssa
App version: 3.1.1
Installation: DEB package
Desktop: MATE 1.24.0
Downgrading to 3.0.7 works.

Same here. The icon is also "frozen" for me and doesn't update with new messages.
OS: Linux Mint 20.1 Ulyssa
App version: 3.1.1
Installation: DEB package
Desktop: MATE 1.24.0
Downgrading to 3.0.7 works.

Still nothing on this issue ?
I have the same :
OS: Fedora 33
App version : 3.1.1
Installation: Flatpak (Rocket.Chat                               chat.rocket.RocketChat                        3.1.1    stable  system )
Desktop: XFCE

Still nothing on this issue ?
I have the same :
OS: Fedora 33
App version : 3.1.1
Installation: Flatpak (Rocket.Chat                               chat.rocket.RocketChat                        3.1.1    stable  system )
Desktop: XFCE

I suggest to stick with version 3.0.7 until next release (let's hope they'll correct this).
Latest rocket won't reach orbit, I guess...

I suggest to stick with version 3.0.7 until next release (let's hope they'll correct this).
Latest rocket won't reach orbit, I guess...

We Reverted back to 2.16.2 as Jitsi calls are still broken in 3.0.7

We Reverted back to 2.16.2 as Jitsi calls are still broken in 3.0.7

Same here, Ubuntu 20.04 with kubuntu-desktop installed, 64bit.  I tried both the .deb package and building from source and both disappear as soon as I check "tray icon" in the menu.  Reverting to 3.0.7 fixed it for me as well.

Same here, Ubuntu 20.04 with kubuntu-desktop installed, 64bit.  I tried both the .deb package and building from source and both disappear as soon as I check "tray icon" in the menu.  Reverting to 3.0.7 fixed it for me as well.

FYI, I tested latest snapshot from snap => still not working.
OS: Xubuntu 20.04.1
Installation Type: snap
Version: 3.2.0-snapshot (2021-02-01)
Channel: latest/edge

I have done a git bisection with good=3.0.7 (dcf7a9c0a6f78ac87a1006d835b990055af56d1c), bad=current master (3b2d0aaa51eaf96442c3084eaeb8621465d40cee).
Result: this is an intermittent problem. Main window did not open with 3b2d0aaa5 in my first test, but opened with the exact same revision in my last test.
The source of the problem is not directly related to Rocket.Chat.Electron version 3.1.1 vs. 3.0.7. It possibly rather happens due to some dependency on a networking connection (like reported in #1950). While I was running the tests, I had some problems with network connections to the networks of GitHub, Google and some others (but not to the network in which my target Rocket.Chat server was located, I think).

I installed version 3.1.1 in Windows 10.
When I left click on tray icon (Windows behavior) =>> window will appear => OK
When I right click tray icon, and select Show from menu (Linux behavior) => Doesn't work
It looks like Show from tray menu is not working in Windows/Linux, rather than some network related problem(which would be strange).

Same here on Arch Linux + Plasma. RC 3.1.1
I've opted to not show the tray icon and let RC run in the taskbar, when I close the application, though, I really close it and I need to open it back, so, sometimes I'm missing some chats until I realize I don't have the application opened.

Same issue here: Ubuntu 20.04 with RC 3.1.1.

I deleted all files in .config/Rocket.Chat/ and was able to use the app again. Certainly not the best solution, but at least a work-around.

I deleted all files in .config/Rocket.Chat/ and was able to use the app again. Certainly not the best solution, but at least a work-around.

Just edit your config.json and modify these two keys:
"isTrayIconEnabled": true,  // => change this for false
"visible": false,   // => change this for true

The first key, disable systray icon and second key, restore the window from tray minimized.

Same issue here.

Same happening for me, rly annoying.

Can confirm this issue persists for me as well. This makes using the app extremely difficult if you want to manage how much of your screen estate is taken up.

Happening the same here for a while.
OS : Arch Linux with KDE Plasma 5
App version : 3.1.1
Installation : aur/rocketchat-desktop 3.1.1-1
When set / unset tray from the menu, the app crashes:
[Wed Mar  3 21:40:56 2021] electron[1750]: segfault at 8 ip 000055d17d2c6605 sp 00007ffe8878c820 error 4 in electron[55d17d136000+5e77000]
[Wed Mar  3 21:40:56 2021] Code: 43 d6 48 39 55 98 75 09 e9 87 00 00 00 48 8b 4d 90 48 8b 55 c8 48 39 c8 75 06 48 3b 55 98 74 74 48 8b 00 48 8b 3c d0 48 8b 07 <ff> 50 08 48 8b 45 c0 48 85 c0 74 88 48 8b 4d c8 48 8b 7d d0 48 8d
[Wed Mar  3 21:49:39 2021] electron[17826]: segfault at ffffec8518ee78d6 ip<PHONE_NUMBER>6b015f sp 00007ffd1adcc160 error 5 in electron[564147521000+5e77000]
[Wed Mar  3 21:49:39 2021] Code: 57 41 56 53 48 83 ec 28 64 48 8b 04 25 28 00 00 00 48 89 45 e0 48 8b 87 68 fc ff ff 48 8d b7 68 fc ff ff 4c 8d 75 c8 4c 89 f7 <ff> 90 b8 00 00 00 49 8b 1e 4d 8b 76 08 4c 39 f3 74 1f 4c 8b 3d 90

Same problem for KDE Debian 10

Same here:
Arch linux
Awesome WM
Every thing updated to the latest version.
Once you activate the tray icon and minimize it, the only way to restore it is to change de config file manually.

The problem seems to come from #1700, this change to be specific.

@tassoevan As the author of the PR, is there a reason to use the focused state to determine the window visibility ?
I can make a PR, I currently use a custom build with the aforementioned change reverted, and everything works.

@TibboddiT PR that fix issues for many users is always good to have. It also allows other to easly check if this solve issue for them and not search own solutions.

@TibboddiT A PR is a good thing, but it also has to be merged into the new version and thats the bigger Problem...


Move sampling into a Web Worker

This closes #3.
Video preview
(it's not that choppy in reality, my screen recorder has some artifacts)
Overview of changes:

Web workers support doing work out of the main thread and termination. However, this termination leaves the worker 'dead', and so it needs to be re-created. It also works in its own scope, and communicates only through messages.
As a result, the home page no longer stores a Stan model. Instead, the state we care about is the URL of the compiled Stan model

StanFileEditor.tsx was changed to set this, rather than doing any loading

The RunPanel now stores a worker. This is created whenever the URL changes, which also kills the previous worker. The same logic is re-used for cancellation.
The worker can receive two kinds of message:

load, which provides the url to import
sample, which provides a config object for the sampler (data, seed, etc)

The worker can reply with three kinds of message:

modelLoaded, sent after a load message is received and successfully handled
sampleReturn, sent after the sampler completed. Always has an error payload. If error === null, then it also has draws.
progress, sent during sampling based on the strings the Stan sampler prints at regular intervals.

Terrific!


when fails to fulfill all promises but each single promise fulfills

PromiseKit version: 4.5.0

I use PromiseKit to wrap a S3 uploading request. For a single uploding, I have this function which works fine:
private static let transferUtility = AWSS3TransferUtility.default()
static func uploadToS3(rawImage image: Data, photoId fileName: String, ext: String, exp: AWSS3TransferUtilityUploadExpression? = nil) -> Promise<AWSS3TransferUtilityUploadTask> {
    return Promise<AWSS3TransferUtilityUploadTask> { fulfill, reject in
        transferUtility.uploadData(image, bucket: JoJoBucket.normal.rawValue, key: "\(fileName).\(ext)", contentType: "image/\(ext)", expression: exp) { task, error in
            if let error = error {
                print("S3 err")
                reject(error)
            } else {
                print("Finish one S3")
                fulfill(task)
            }
        }
    }
}

I wrap the single uploading function into a multiple version using when which looks like below:
static func uploadMultipleToS3(photos: [S3Photo], exp: AWSS3TransferUtilityUploadExpression? = nil) -> Promise<[AWSS3TransferUtilityUploadTask]> {
    return Promise<[AWSS3TransferUtilityUploadTask]> { fulfill, reject in
        firstly {
            when(fulfilled: photos.map { uploadToS3(rawImage: $0.raw, photoId: $0.id, ext: $0.ext, exp: exp) })
        }.then { results -> () in
            print("S3 upload")
            fulfill(results)
        }.catch { error in
            print("upload err")
            reject(error)
        }
    }
}

However, when I use the uploadMultipleToS3 function, I can see all single task are fulfilled but the then block after when wasn't executed. I was wondering if I use when or PromiseKit correctly.
Hope to get pointers. Thanks for the awesome library!

Your promise code is fine.
Verify that indeed all the uploads are happening, and that they for such situations the fulfill or reject is indeed being called for each promise.
If all promises resolve then either the then or catch in your chain will be called. We're 99.999% certain these code paths in PromiseKit have no bugs at this point after 5 years of triage.

FYI this code:
static func uploadMultipleToS3(photos: [S3Photo], exp: AWSS3TransferUtilityUploadExpression? = nil) -> Promise<[AWSS3TransferUtilityUploadTask]> {
    return Promise<[AWSS3TransferUtilityUploadTask]> { fulfill, reject in
        firstly {
            when(fulfilled: photos.map { uploadToS3(rawImage: $0.raw, photoId: $0.id, ext: $0.ext, exp: exp) })
        }.then { results -> () in
            print("S3 upload")
            fulfill(results)
        }.catch { error in
            print("upload err")
            reject(error)
        }
    }
}

is the same as:
static func uploadMultipleToS3(photos: [S3Photo], exp: AWSS3TransferUtilityUploadExpression? = nil) -> Promise<[AWSS3TransferUtilityUploadTask]> {
    return when(fulfilled: photos.map { uploadToS3(rawImage: $0.raw, photoId: $0.id, ext: $0.ext, exp: exp) })
}

Hello Max,
Thanks for the response. It seems there is a problem with S3 SDK. All uploadings indeed happened but S3 returns the result of last uploading multiple times. I see multiple Finish one S3 is because the last one gets fulfilled multiple times instead of each one gets fulfilled.


Modified README

I've modified the title of the project, I liked more the title without the -.
- Memory-vs-Gender-Analysis-Game
+ Memory vs Gender Analysis Game

Some other changes are:
- Table of Content
+ Table of Contents

In About section
- Memory vs. Gender Analysis Game
+ Memory vs Gender Analysis Game

Thank you very much for your contribution. I will get to merging these changes soon.


Use new --skip-turbolinks flag

Rails 4.2 introduced -skip-turbolinks flag. We can remove some code and use that flag instead. What do you think?

Well I love this idea.

:+1:

I'm in favour of deleting code, :+1:

Looks good to me.

Thanks, @delphaber. Merged as 500f1a6.


Adding eureka accept to the vip resources

NetflixOSS » eureka » eureka-pull-requests #395 SUCCESS
This pull request looks good


Change dark guide colors to base01

This makes them more mellow against the base00 background and symmetric to light theme setup: light themes are [background-guides-text] 07-06-02, so dark counterparts should be 00-01-05, not 00-03-05
  =>

Thank you! :+1: When I rewrote the way stylesheets were handled a couple weeks ago I noticed the discrepancy in the syntax-variables file but completely forgot about it later. Moved part of the commit title to the body, hope you don't mind.

Sure man, no problem :+1:


Store data when not authenticated

Hi and thank you for this library, it's pretty great. One question, how can I persist data across page reloads, when the user is not authenticated. I want to store some information, and take that information to the server only when the user decides to create an account and thus becoming authenticated.
Thanks.

@tehmaestro it seems that your solution with invalidate() call will still trigger a delete if your have two parallel anonymous sessions in two tabs. Say, if tab 1 updates anonymous session then tab 2 will delete everything and, in your case, will hit a back-end.
I have the same problem as @tehmaestro and have an idea that maybe the best solution would be to have a configurable anonymous authenticator (not sure what would be the best name to call it). It would have only restore method and by default this method would do nothing.
And it seems that this fix isn't that trivial, there are corner-cases and many parts of session are affected.

Also, maybe it would make sense to have a subkey on session called anonymous or something like that wouldn't be affected by authentications/invalidations. Just thinking out loud :) Would be interesting to hear what @marcoow thinks.

I think the simplest fix would probably be to not clear the session when the authenticator's restore method returns a rejecting promise. Not sure whether this covers all edge cases though...

Hey, one problem I noticed while further researching this, is that, when not authenticated, although you can use this.set('session.something', something), using this.get('session.something;) does not work.
Only when the session is authenticated, setting and getting stuff from localStorage works.
I probably don't fully understand how Ember works, but I simply cannot find the lines of code that make the localStorage data available in the session object, when authenticated. I'm trying to modify the behavior so it fits my needs, but I just can't find it.
Could you point me to the right direction? How and when does the data became available in the session object, like this.get('session.data') . Thank you.

Yep. it uses Ember.ObjectProxy and the setUnknownProperty method to keep the store up to date.

I thought about the topic and I think the fact that the session clears itself in certain situations war wrong from the beginning. The fact that the session's current content doesn't constitute an authenticated state doesn't require all of its content to be cleared. Yet, there's probably a simple solution for the problem:
As both the authenticator's restore and invalidate method receive the session's current content as an argument it would make sense to - if that session content doesn't constitute an authenticated state which is the authenticator's task to decide anyway - have the authenticator remove the security-relevant attributes from the session content (which would in most cases be the token and if not then the authenticator would know which attributes have to be removed, e.g. expiration times or refresh tokens in the case of the OAuth 2.0 authenticator), resolve or reject with that updated session content and in the session itself simply replace its content with whatever comes back from the authenticator and never completely clear itself (although it probably makes sense to have a method in the public API for that). That solution would have several advantages:

the public API doesn't need to change
no new concepts like anonymous authenticators etc. have to be introduced
the session actually behaves like a real session in the way that it keeps data regardless of whether it's authenticated or not

There's 2 drawbacks that I would consider ok for a pre 1.0 release though:

custom authenticators would potentially have to be changed so that they always resolve or reject with the updated session content and also delete relevant attributes from it in the restore and invalidate methods
if data is persisted in the session that's relevant to security but the authenticator is unaware of that data would have to be deleted manually (in the sessionInvalidationSucceeded action if using the ApplicationRouteMixin or by handling the session's sessionInvalidationSucceeded event)

Would be great to get some opinions!

I think this sounds really good.
My personal case is:

the REST api is not stateless, because the API will be used only by my app. There are sessions and even cookies.
I allow users to access certain pages without creating an account. However, I do create a "guest" account in the backend, so I can monitor the actions and progress of the "guest" user.
Whenever he decides to create an account, I simply assign a username and password for him in the backend, and also, the frontend becomes authenticated.

So that's why I needed a frontend unauthenticated state. I wanted to keep data in localStorage as I'm tracking the user in the not-authenticated, no-profile-created-yet state.

I think the point is that the idea of the session is that it always exists regardless of whether it's authenticated or nor. Currently that's not the case though as as soon as you invalidate it all session data is lost (as it is when you reload the page without an authenticated session).
I'm not actually sure anymore though that the solution I suggest above is the way to go. The problem is that it moves the responsibility to decide which session attributes are actually security relevant and have to be deleted when the session is invalidated to the authenticator. The torii authenticatior e.g. though does not actually know which session attributes are security relevant as it only forwards these attributes from the torii provider. Also the solution makes the API for the authenticators more complex as they always need to resolve/reject with values, delete single properties from the data set etc.
A solution that uses a special session subway secure or so (similar to what @snovity suggests above) is probably simpler. Basically the idea would be to always leave the general session data (everything that's not in secure) untouched, never delete it etc. The only part of the session data that would be managed by the authenticators, deleted on invalidation etc. would be the secure subkey then. This makes the authenticator's API simpler and makes it easier to delete security-relevant keys on session invalidating (by simply deleting the complete subkey). I'll setup a 2nd pull request that implements this solution and see how this goes.

Awesome. Thank you.
I wanted to test it, but I was unable to get it working .. it works as before. Looking at the files, there is no "secure" mentions anywhere, so I'm guessing npm install ember-cli-simple-auth doesn't get this latest merge?

No, npm install ember-cli-simple-auth installs the latest released version.

I did a bower install ember-simple-auth, which reinstalled the bower packages, the version is indeed 0.7.3, but when searching for the keyword secure, in both the simple-auth.js and simple-auth.amd.js, there are no results.

Yes, this is only on master for now. You cannot install this with npm or bower.


Migrate custom KeyCloak realm(s) to Gold Cluster

Migrate the BC Digital Trust Services realms from the gzyg46lx instances in the Silver cluster to the digitaltrust-citz instances in the Gold cluster.
Affected clients and applications:
bcgov-citz-issuer

ISED Business Banking Initiative
BC Services Card
[x] dev - https://bcgov-citz-issuer-dev.apps.silver.devops.gov.bc.ca
[x] test - https://bcgov-citz-issuer-test.apps.silver.devops.gov.bc.ca
[x] prod - https://bcgov-citz-issuer.apps.silver.devops.gov.bc.ca

bcreg-registration-issuer

ISED Business Banking Initiative
Verifiable Credentials
[x] dev - https://bcreg-registration-issuer-dev.apps.silver.devops.gov.bc.ca
[x] test - https://bcreg-registration-issuer-test.apps.silver.devops.gov.bc.ca
[x] prod - https://bcreg-registration-issuer.apps.silver.devops.gov.bc.ca

bcreg-relationship-issuer

ISED Business Banking Initiative
Verifiable Credentials
[x] dev - https://bcreg-relationship-issuer-dev.apps.silver.devops.gov.bc.ca
[x] test - https://bcreg-relationship-issuer-test.apps.silver.devops.gov.bc.ca
[x] prod - https://bcreg-relationship-issuer.apps.silver.devops.gov.bc.ca

issuer-kit-demo-verifier-chat

issuer-kit-demo-verifier-chat
Verifiable Credentials
[x] dev - https://pctftest-dev.vonx.io
[x] test - https://pctftest-test.vonx.io
[x] prod - https://pctftest.vonx.io

inoculation-issuer

essential-services-delivery
BC Services Card
[x] dev - https://inoculation-issuer-dev.apps.silver.devops.gov.bc.ca
[x] test - https://inoculation-issuer-test.apps.silver.devops.gov.bc.ca
[x] prod - https://inoculation-issuer.apps.silver.devops.gov.bc.ca

bcvcpilot-admin

trust-over-ip-configurations
IDIR / GitHub
[x] dev - https://bcvcpilot-issuer-admin-dev.apps.silver.devops.gov.bc.ca
[x] test - https://bcvcpilot-issuer-admin-test.apps.silver.devops.gov.bc.ca/
[x] prod - https://bcvcpilot-admin.vonx.io

bcvcpilot-web

trust-over-ip-configurations
Verifiable Credentials - Invite from bcvcpilot-admin only
Does not care about the redirect URL registration for the verifiable-credential IDP with vc-authn.
[x] dev - https://bcvcpilot-issuer-dev.apps.silver.devops.gov.bc.ca
[x] test - https://bcvcpilot-issuer-test.apps.silver.devops.gov.bc.ca/
[x] prod - https://bcvcpilot.vonx.io

identity-kit-admin

identity-kit-configurations
IDIR / GitHub
[x] dev - https://identity-kit-admin-dev.apps.silver.devops.gov.bc.ca
[x] test - https://identity-kit-admin-test.apps.silver.devops.gov.bc.ca
[x] prod - https://identity-kit-admin.vonx.io

identity-kit-public

identity-kit-configurations
Verifiable Credentials - Invite from identity-kit-admin
Does not care about the redirect URL registration for the verifiable-credential IDP with vc-authn.
[x] dev - https://identity-kit-dev.apps.silver.devops.gov.bc.ca
[x] test - https://identity-kit-test.apps.silver.devops.gov.bc.ca
[x] prod - https://identity-kit.vonx.io

The bcgov-citz-issuer, bcreg-registration-issuer, bcreg-relationship-issuer, issuer-kit-demo-verifier-chat, and inoculation-issuer KeyCloak clients and associated application and vc-authn configuration has been migrated to the realms in the Gold cluster.  All applications have been tested and are functioning as they were when connected to the previous realms.  The basic steps followed to migrate the KeyCloak clients and associated applications can be found here; KeyCloak Migration

identity-kit-admin and identity-kit-public were migrated to the new realms and tested yesterday (Thursday Dec. 15th).

The dev and test environments for bcvcpilot-admin  and bcvcpilot-web have been migrated.  Just coordinating with the admins for the bcvcpilot-admin prod environment before migrating the last two applications.

All applications have been migrated:

https://github.com/bcgov/ised-business-banking-initiative/pull/35
https://github.com/bcgov/issuer-kit-demo-verifier-chat/pull/82
https://github.com/bcgov/essential-services-delivery/pull/123
https://github.com/bcgov/trust-over-ip-configurations/pull/121
https://github.com/bcgov/identity-kit-configurations/pull/16

Backup exports of all of the old realms have been collected.  All application clients were disabled as the applications were migrated.  All Keycloak admin access (other than mine) has been revoked on the old realms.  The SSO team will be disabling the realms and disposing of them in January.


[frontend] Description & locale buttons are transparent if user is not logged in.

Since they are white-text-colored on a white bg...
Actual:

Expected

Keep in mind that on hover text and bg colors should be swapped (white bg -> purple text, purple bg -> white text)
P.S.: It turnes out that active locale is not bold => fix this too

resolved in #2026


docs: 重新设计文档

区分SCOW的部署和集群其他部分的部署，重点突出SCOW的部署
SCOW部署部分分为：简介、快速开始（vagrant）、安装、配置、运维
将大部分图片和图表放到对应的文档的目录下，方便检索
尽可能去除所有有子文档的根目录文档

Codecov Report
Base: 64.61% // Head: 64.61% // No change to project coverage :thumbsup:

Coverage data is based on head (fdcf3f5) compared to base (4ff344a).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   64.61%   64.61%
=======================================
  Files         106      106
  Lines        2973     2973
  Branches      371      371
=======================================
  Hits         1921     1921
  Misses       1006     1006
  Partials       46       46

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[FLINK-4935] [webfrontend] Submit job with savepoint

This builds on top of #2712 and only the last commit 4265834 is relevant.
Allows to submit a job via the REST API and restoring from a savpeoint:

Changes

Adds documentation for the REST API /jars/:jarid/run command
Adds two new query parameters to run a JAR with the savepoint restore settings:

savepointPath: Sets the savepoint path
ignoreUnmappedState: Ignores unmapped state (default false)

minor comments, otherwise +1

Thanks for the review. I would like to merge this as soon as #2712 is in.


Recommended image type for source image to be thumbnailed.

Hello,
Very basic use case. User uploads image. I want to store a full size copy and then serve thumbnailed versions.
The thumbnails will be jpg or webp.
From a performance point of view is there a best format to use for the master image? jpg / webp / something else?
Also, is there any point storing the master image at a higher quality setting than the images that will be served? So, as an example, if I serve images at q:80, is there any benefit to using q:90 or even 100 for the master source image? Or is that just a waste of disk space?
Thanks in advance for any advice.

Assuming these are lossy, photographic-like images, I'd probably go for JPEG input of a "quality" at least as high as the highest you'll need for an output, maybe avoid the use of chroma subsampling too. (If the input is already JPEG don't re-process to change the quality as this will introduce another round of loss.)

Thanks @lovell. Yes, this would be photographic images. The user would be uploading a JPEG. Which would be run through sharp and saved. That would be the source image for future thumbnails. Just so I'm clear - you suggest not to use chroma subsampling when the source image is first saved or when the thumbnails are generated, or both? I was also planning to use the mozjpeg option. Is it best to avoid that on the source image too? Or can I use it for the source and thumbs? Thanks for the advice :-)

You'll probably need to experiment as it all depends on the source images.

Did some experiments and found the results quite surprising (not that I know anything about this stuff!). With the images I'm working with, it seems to make very little difference to the thumbnails if the source image has mozjpeg optimisations + chroma subsampling or not. The resulting thumbnail is either exactly the same size or extremely close and I can't see any difference in the image quality. Checking the speed with simple console.time, it also looks like it's either faster or almost as fast to create a thumbnail from a source jpeg with mozjpeg optimisations. So, for my case, looks like mozjpeg + chroma subsampling is best for source images and thumbnails. Thanks for advising to test it.

I hope this information helped. Please feel free to re-open with more details if further assistance is required.


1stand2ndweekUpdates

Quiz Creator
This PR consists of the updates for the first two weeks of the C4GT program
It consists of the weekly updates

@Prakhar-commits you still have conflicts please resolve them

@Prakhar-commits you still have conflicts please resolve them

These are vercel related conflicts cannot be resolved unless you have write access

Merged with #286


File tab drag & drop to Windows desktop using Chrome does not work after editing time with generate speed checked...

... then 2) closing Chrome GPXStudio tab and calling again GPXStudio makes the track not appearing back but displaying world map

Cannot reproduce. Do you still have this issue?

@mapa4


RN-0.73 change Android configs for RN 0.73 compatibility

Summary

Starting from React Native v0.73 , all libraries will need to be updated with these two one-liners due to Android Gradle Plugin upgrade
https://github.com/react-native-community/discussions-and-proposals/issues/671

React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x. This will require all the libraries to specify a namespace in their build.gradle file.
Details
I'd like to share some of the upcoming changes that will happen in 0.73, which is still a bit far, but we'd rather start earlier rather than later.
React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x, which brings a lot of improvements for Android apps but also a series of notable changes.
Most importantly:
App/Library Developers will now have to install and use Java 17
Library Developers will have to specify a namespace in their build.gradle file.
Specifically, the last change is a breaking change and will make libraries that are not specifying a namespace incompatible with React Native 0.73 (your project won't build).
Support for namespace was added in AGP 7.3.x, which ships with React Native 0.71. Libraries that published a new version with a namespace declared for 0.71 or 0.72 don't need further update. So we invite library authors to do those changes as soon as possible so by the time 0.73 is out, most of the apps are adapted.
What you need to change
Library authors will have to update their android/build.gradle file as follows:
android {
+   namespace = "com.iterable.reactnative"
    ...
}

and remove the package definition from their AndroidManifest.xml:
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="com.iterable.reactnative">
+          >
...
</manifest>

Further reading
Official Google documentation on namespaces is here.
Test Plan

What's required for testing (prerequisites)?
just build it
What are the steps to test it (after prerequisites)?
Compatibility

OS
Implemented

iOS
❌

Android
✅

Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I added a sample use of the API in the example project (example/App.tsx)

I added back the namespace to AndroidManifest to keep the previous RN compatibility
https://github.com/react-native-community/discussions-and-proposals/issues/671#issuecomment-1597386954

@felipemillhouse Thanks!

@felipemillhouse build fails on previous RN versions
`1: Task failed with an exception.

Where:
Build file '/Users/osamahafez/Software/ThatekWork/mobile/thatek-mobile/node_modules/react-native-permissions/android/build.gradle' line: 62

What went wrong:
A problem occurred evaluating project ':react-native-permissions'.

Could not set unknown property 'namespace' for extension 'android' of type com.android.build.gradle.LibraryExtension.`

also downgrading to older releases does not fix the issue except 2.0.0 and below

I fell it’s not related to the PR @osamahafez

@felipemillhouse you can see the issue on line 62 where you submitted the PR
here's the commit: https://github.com/zoontek/react-native-permissions/commit/c037cf19c60f55f24bd863ac307f31c886fb249d
Also I submitted an issue here https://github.com/zoontek/react-native-permissions/issues/787
if you like to investigate further on the matter

Is that change released in all versions that you seeing failing? I don’t think so. It’s a new change and it shouldn’t impact previous releases @osamahafez
You can test it checking the node modules folder, deleting the namespace there and trying to build it, likely it’ll fail also

If we confirm the root cause is that change, we need to submit another PR like:
// Conditional for compatibility with AGP <4.2.
    if (project.android.hasProperty("namespace")) {
        namespace = "io.sentry.react"
    }

@felipemillhouse I tested it after removing the line namespace = "com.zoontek.rnpermissions"
and build was successful

@felipemillhouse I tested it after removing the line namespace = "com.zoontek.rnpermissions"
and build was successful

Could you make a favor to test with this code?
if (project.android.hasProperty("namespace")) {
        namespace = "com.zoontek.rnpermissions"
    }


Corrected README grammar

Pre-Submission Checklist

[ ] Your pull request targets the staging branch of freeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ ] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description
I have corrected the grammar of the README.md file in the server directory.

:sparkles: :sparkles: LGTM. :sparkles: :sparkles:
Thanks @Aayush-N


Do not merge

@psturc should this be using the linked e2e test PR with the same branch name: https://github.com/redhat-appstudio/e2e-tests/pull/627
Not sure if the failure is an issue with the other PR or this PR just not using it.

@stuartwdouglas according this log this PR is using the related PR in e2e-tests.
According to the logged error it failed on this line

/test jvm-build-service-e2e

/test jvm-build-service-e2e

/test jvm-build-service-e2e

/test jvm-build-service-e2e

/test jvm-build-service-e2e

/test jvm-build-service-e2e


Please let me know how I can change the splash screen.

I would like to change splash screen on laravel-pwa.
How can I do this. Should I change manifest.json.
Pleaset let me know ASAP. Please give me the sample how can change splash screen if possible.

@dreampioneer this package generates offline HTML, and if you referring to that. than you can find in a public directory

@dreampioneer this package generates offline HTML, and if you referring to that. than you can find in a public directory

I am not sure. I would like to change the splash screen of laravel-pwa on mobile.
I can not find the option to change the splash screen on mobile.


Failed to Load Ad

Hi,
I just upgraded the version of plugin with the new api.
However, it is not showing ads any more just showing up an error 0 and reason Internal error.
I have verified my code 3 times here is the snippet
admob.banner.config({           id: admobid.banner,           isTesting: true,           autoShow: true,           size:admob.AD_SIZE.SMART_BANNER,         });         admob.banner.prepare();
@ratson any help appreciated

Is the trailing ,  meant to be there after the size option?

Hi @Script47 i have removed the trailing slash. Seems this is an issue with Lenovo K4 Note Phones. not sure what's wrong really, all other devices are working fine.


Add Strong-Name version

I try to reference this package in my wpf(.net 4.8 & .net 6) project which has strong-name , but unfortunately, it throw exception says this assembly need strong-name.

+1 here.
We are trying to reference this project in our MSFT internal application, but it also requires strong name.

Ok I'll try add add strong naming to an upcoming version. I haven't done much with this in the past so I need to figure it out.

@ardalis
Hi, thanks for the quick feedback.
I was running the internal package pushing and hit the following error message:
WARNING: File not StrongName signed: lib\netstandard2.0\Ardalis.Specification.dll
ERROR: File not AuthentiCode signed: lib\netstandard2.0\Ardalis.Specification.dll
So, I think the dll needs to be both "StrongName" and "AuthentiCode" signed.

Hi @ardalis
It seems like publishing package with target framework version above netcore, strong name is not required.
Could you please add multi-target to Ardalis.Specification with netstandard2.0 and net6.0?
https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named
Quote: For .NET Core and .NET 5+, strong-named assemblies do not provide material benefits. The runtime never validates the strong-name signature, nor does it use the strong-name for assembly binding.

I've done some research into this and looked at what other popular NuGet packages have done, and it looks like having you use StrongNamer (or similar tools) would be better than adding strong names to this package.
https://github.com/jbogard/MediatR/issues/86

@ardalis
I think you have looked into a very old thread. According to our internal tool, both MediatR and MediatR.Contracts are strong name signed.
But would you try another suggestion first? Make Ardalis.Specification multi-targets to both netstandard2.0 and net6.0.
It seems like net6.0 doesn't require the strong name check.

What's the last status here? Do folks still need this? Should we investigate this issue further?
Btw, @LangSensei we have updated the TFMs in the recent versions, now it multi-targets netstandard2.0 and net6.0, so at least you won't have issues with newer projects.


fix: fuzzy-find bonus for matching last characters of pattern and symbol

Closes #1546. I thought it best if we simply give a constant bonus when the last character of the pattern matches the last character of the symbol, but let me know if you can think of a better heuristic.
Also something I noticed is that we don't have any tests for the fuzzy-matching algorithm directly, rather we're testing this indirectly through the completion tests. I wanted to add a test for the aext example but wasn't sure where to put that, will be happy to make a new fixture for it if there isn't already somewhere I can sneak it into.

will be happy to make a new fixture for it if there isn't already somewhere I can sneak it into.

Yeah, feel free to just #eval underlying functions in a new test case!

Okay, so it turns out that it wasn't as simple as calling an underlying function since the logic to get & sort the matching symbols is implemented in the watchdog itself. I could perhaps extract that to an external function but for now I've taken the easy route of modifying the test runner. LMK if this approach is acceptable -- it also uses a hack to replace URI references to within the local file system with the placeholder file://__root__ after the test output has been produced.

Oh, haha it looks like CI will actually need some additional tools for this hack to work... I'm not yet familiar with how things are set up for the different test environments, but all that I did was use git and sed in run_single.sh, perhaps we just need to install those two programs?

Okay, so it turns out that testing this wasn't as simple as calling an underlying function since the logic to get & sort the matching symbols is implemented in the watchdog itself

There isn't really any logic there apart from a qsort call and an extract that we can ignore for the tests, no?
#eval #[`Array.extract, `Lean.extractMainModule].filterMap (fun n => (n, ·) <$> fuzzyMatchScoreWithThreshold? "extract" n.toString) |>.qsort (·.2 < ·.2) |>.map (·.1)

Something like this would be much preferable over being reliant on actual Environment data that's constantly changing.


Cycle & Foot Path preset missing from search results in France

Describe the bug
When searching for presets for cycle tracks in France using the search string "cycle &" the presets Cycle & Foot Crossing and Cycle & Foot Path do not show up in the presets list whereas in the UK the same search produces those presets as part of the results. Such paths occur both in the UK and France as the presets cover both segregated and unsegregated versions of such paths.
To Reproduce
Search for presets using the search string "cycle &" when over an area of France.
Expected behavior
Presets Cycle & Foot Crossing and Cycle & Foot Path showing up in the search results.
Screenshots

the preset has an explicit exception to not show up in France (and some other countries), see https://github.com/openstreetmap/iD/issues/6836#issuecomment-529391949
If I understood this right, this is because the preferred tagging of a "Cyle & Foot Path" in France is highway=path + bicycle=designated + foot=designated. Is that right?
In this case, it would make sense to provide an additional preset for cycle-and-foot paths in these countries using the highway=path tagging variant.

Ah. I see it's the same sort of exceptionalism as the silly treatment of addresses in France. Aka not wanting the consistent treatment and tagging of things just because.
It's one thing where there are genuine legal differences. Priorite a droite's an example of that. Are there places in France with segregated cycle track and pavement where the only segregation is a white line? Yes. One of them is exactly where I wanted to use the correct preset.
Solution? Consistent tagging. Where there is a genuine need for different tagging such as legal differences then support it and encourage its use. If it's just some people being contrary, even if it's an entire national community being contrary, then it needs to be treated as such.
This is a substantive difference. It produces different renderings. It causes unnecessary complications for data consumers. Therefore it needs to be eliminated. Choose one scheme or the other. Then eliminate the second.

This was added in https://github.com/openstreetmap/id-tagging-schema/pull/1384
Please use the PR preview to test it out.


Register school 8 Nuremberg

@ds-softime Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


GitBook's own version control: yay or nay?

I merged the new organization again and GitBook didn't render it right again (don't worry, I reverted the merge!). So I have a new idea:
GitBook offers the following feature:

We can sync as many branches as we want from GitHub
We are also able to transform them into versions (doc version 1.0.0, etc) publicly accessible to anyone or delete a whole deprecated version easily

My meta GitBook showcases this. I set up the open-collectivebranch (https://github.com/contraexemplo/metadocumentation/tree/open-collective) as the main docs/most current documentation and there's a link to the redirect branch (https://github.com/contraexemplo/metadocumentation/tree/redirect) with the old version of said documentation. We could do the same for the new organization while keeping the old version live as well.

CC @jaskirat2000 and @alanna

Follow up after the meeting I had with @alanna: I will try this tomorrow and see how it goes. We agreed that we are at a point of the project that moving on to other tasks will be more beneficial to the docs. We also agreed that talking to the developers about developing a strategy to document new versions of the app is much needed—and if we choose to stick with GitBook in the end, this feature may be handy.
Tasks for tomorrow:

[ ] Check the Releases functionality page again to identify the best strategy for our documentation
[ ] Perform some tests on my test GitBook
[ ] Stage changes through GitBook
[ ] Evaluation: did it work as expected?
[ ] Write a blog post about all of this!

@alanna I was able to successfully import and render the new organization using the Release functionality: https://docs.opencollective.com/help/v/v2/

Great! It looks good. So is the plan to continue editing the V2 release and then migrate it to be the main docs by the end of the project?

@Alanna Yes, we would mark it as the main branch and it would take the place from the current documentation.

v2 is now the default docs for everyone on GitBook but I need to make a change here to make that branch the main one here. @alanna I don't have the access permissions to do this, would you be able to make that change?

I'm not sure how to do that, @contraexemplo - I think I succeeded in making you an admin of this repo just now so can you try again? If you need me to do it let me know how.

Thanks @alanna! v2 is now the main branch on GitBook and GitHub. :tada:

@contraexemplo can you change "V2" to something more descriptive like "help" or "docs" so it shows up here?


Added Think Perl 6 by Allen Downey

Love the Green Tea books!
Especially considering the title similarities in the Perl books, could you add the Author in the listing? Thanks.

Sure! Commit done!

Thanks @quobit !


Add Ripple effect when items selected

On Android 5.0 or higher make use of the ripple selector to add a grey ripple when a movie item is selected or the main menu is clicked.  See the following gist:
https://gist.github.com/kingargyle/b17012527d509c448ab3521aeda8f3aa

This doesn't need to be implemented with the feedback that TvRecyclerView provides.


[Feature] Event Anonymisation

Currently events are not anonymised.
Whilst this is not dangerous in itself, we would prefer to occlude sensitive data wherever possible.
As an example; events may include pod names which might reveal some trade secrets.
This issue is to track and discuss a solution to sending raw event data to the inference AI backends.

hi @AlexsJones can we do it with some dynamic anonymization


Refactor add test and travis

This PR contains test files discussed in #47.
It will be rebase when #48, #49 will be merged.
@owais I will list my use cases and will test them. Could you give me advice on what tests to add ?

Thanks @melck. Let's start with adding simple tests that verify all existing functionality. Mainly let's test different scenarios with currently supported webpack version and verify we generate the stats file as expected. That should be good enough to begin with. Then we can add more tests along with support for newer versions of webpack. Perhaps taking a look at django-webpack-loader tests and try to replicate the ones that make sense for this project would be good start. https://github.com/owais/django-webpack-loader/blob/master/tests/app/tests/test_webpack.py

@owais I've added some simple test :

Test generation stats file
Tests for options
Test show errors from compilation

I think we can merge like this. I let you check it's ok and enable travis when merged ;). We could add build status and coverage on README file avec that.


Any way to get LibSassBuilder to work on the M1 processor?

Heya, I upgraded to an M1 processor, and now I'm getting build errors.
/Users/jost/.nuget/packages/libsassbuilder/1.6.4/build/LibSassBuilder.targets(90,5): error MSB3073: The command "dotnet "/Users/jost/.nuget/packages/libsassbuilder/1.6.4/build/../tool/LibSassBuilder.dll" files "/Users/jost/Desktop/FT/ver/ver-self-service-portal/src/FaroeseTelecom.Ver.Web/wwwroot/css/styles.scss" --outputstyle expanded --level verbose " exited with code 130. [/Users/jost/Desktop/FT/ver/ver-self-service-portal/src/FaroeseTelecom.Ver.Web/FaroeseTelecom.Ver.Web.csproj]
I am currently running libsassbuilder 1.6.4. I found that I can upgrade, but then I'm simply told that libsasshost does not support the arm64 architecture.
I have tried a million different combinations  (such as this dotnet/sdk thread), but to no avail
Do you know of a way? :)

forgot to mention that a vanilla project works perfectly fine with the adjustments suggested by the issue

Nevermind, I have switched to DartSassBuilder.
That fixed all my problems :)
I've been lead to believe that this library will be deprecated, and replaced with the DartSassBuilder.
I merely replaced the LibSassBuilder in the .csproj file, with the DartSassBuilder:
<PackageReference Include="DartSassBuilder" Version="0.2.1-beta" />

and it just worked with no issues :)

Hi @jostFT - interesting.
@johan-v-r  I am still having issues with LibSaasBuilder on my M1 ARM Maccok Pro.
Error:
/Users/xyz/.nuget/packages/libsassbuilder/2.0.1/build/LibSassBuilder.targets(95,5): error MSB3073: The command "dotnet "/Users/xyz/.nuget/packages/libsassbuilder/2.0.1/build/../tool/LibSassBuilder.dll" files "/Users/xyz/Sources/blazor-wasm-things-to-know/IsolatedJS/Client/Shared/MainLayout.razor.scss" --outputstyle compressed --level default " exited with code 134.
But, I am not successful with DartSassBuilder, either.
It just does not compile my .scss files at all. But no error...
Any ideas?

@jostFT I switched to DartSassBuilder and added Microsoft.ClearScript.V8.Native.osx-arm64 for it to compile without error. Is your setup compiling SASS into CSS files? Mine runs without error with these 2 packages but does not update CSS files when SASS files are changed.

@mrlife @ChristianWeyer, hey sorry.
Firstly, my inbox decided this was spam for some reason, so sorry for the late reply.
Secondly, I assumed it worked, but it turned out that that it had cached my previously compiled .css file.
I also tried WebCompiler - but it is very indecisive if it should work or not.
Sometimes it compiles it perfectly, and then at other times it decides that it does not support the arm architecture.
So currently I am at a loss. Even with installing the Microsoft.ClearScript.V8.Native.osx-arm64 package, it proceeds to complain about it not existing.


[Console] Add SQL auto complete in druid console

In the SQL console, we are enabling auto complete by detecting keywords from:

Local words
Datasource names
Database column names
Druid SQL functions

Things to note:

The function documentation, i.e. syntax and usage, will be displayed when hovering over the function in the popover list.
Auto complete can be disabled by the user and will always be disable when the user input JSON data rather than SQL queries in the text area
The SQL function documentation is saved as a JSON variable in a TypeScript file, which is auto generated by the create-sql-function-doc in script directory in web-console.
Before running npm start in web-console, run ./script/build in the web-console directory to generate the SQL function documentation file, and do not modify the file in anyway.

I have reviewed these changes already and it has my 👍
Some of my review comments (that have already been addresses) can be found here: https://github.com/implydata/druid/pull/18


Usage doesn't get printed

When I run gofuck --help it outputs
Usage of gofuck:
With nothing after that.
OSX version 10.12.4 x86_64
Go version: go1.8.1 darwin/amd64
Uname -p: i386
Uname -o: Darwin
Uname -i: MacBookPro12,1

Can you give me some details on the system? If you have Go installed, running go env and pasting the output here will help out quite a bit.

@apkrieg
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/ender/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/k7/wt966sbs13v387mnmgg6bnzc0000gn/T/go-build443093053=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

Nevermind, there was never a help page. I'll add one in the next version.

FTFY
https://github.com/apkrieg/gofuck/pull/2

Fixed 7b54986


Top pvp page [Issue #89] and various other fixes along the way

closes #89

What is the intent of the adminPanel changes?


Support linux build/test

Swift supports Linux now (and windows, in fact), we should support linux for building/testing. This eliminates the hard-requirement on macos for swift support. This will also require changes in okapi to support the target:
error: artifact 'OkapiNative' does not support the target platform and architecture ('Triple(tripleString: "x86_64-unknown-linux-gnu", arch: TSCUtility.Triple.Arch.x86_64, vendor: TSCUtility.Triple.Vendor.unknown, os: TSCUtility.Triple.OS.linux, abi: TSCUtility.Triple.ABI.unknown)')

okapi can't specify the xcframework for linux easily, which makes this side impossible. Closing due to significant work to support for minimal gain.


Simplify search dir

Remove if if if and replace with a loop

This will need a rebase

waiting fix for #264 before rebase this


Fix Credits Crash when creating new scene

Fixes #1100

Thanks for the pull request @joseph-kaile!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
Maintainers, here's how to check for a submitted CLA.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

Good catch, @joseph-kaile! I almost certainly broke this in https://github.com/CesiumGS/cesium-unreal/pull/1085/commits/2ab3ae1b5b9d565396b2351ae5d15a868284c63a.
This change looks good. I just changed the dynamic_cast<> to a UE Cast<> because I think dynamic_cast isn't always guaranteed to be available on all UE platforms.


VSC Upgrade OpenStack not rebooted

https://github.com/nuagenetworks/nuage-metroae/blob/612d9f93691b900490a760c4b7e9ce7e4034ed2b/src/roles/vsc-upgrade-deploy/tasks/main.yml#L102
the when condition contains "vcenter" twice, the second time it should actually be "openstack"
-> as a result of this bug
upgrade of vsc using deployment type openstack, does not reboot the vsc, and the vsc than stays in the older version

Fixed with #1538, due to be released with MetroAE v4.1.0.


ROX-22474: Do not build Konflux images with release GOTAG

Description
As a workaround, we need to build Konflux images without release GOTAG.
That is to use the SCANNER_VERSION and COLLECTOR_VERSION files to find the respective images.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.
It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.
It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest

Please check that scanner-v4 build is not broken by this, before merging.
https://console.redhat.com/preview/application-pipeline/ns/rh-acs-tenant/pipelinerun/scanner-v4-on-pull-request-qhkmp

Please double-check that scanner-v4 build is not broken by this, before merging. To me, it seems like it's not.

task show-summary has failed: TaskRun "scanner-v4-on-pull-request-qhkmp-show-summary" was cancelled. TaskRun cancelled as the PipelineRun it belongs to has timed out.

I agree, it looks like a generic timeout. Build finished successfully.


vendor.[revision].js not pushed in self.__SW_MANIFEST

In a vue2 app using @vue/composition-api and vite, the vendor.[revision].js is not present in the self.__WB_MANIFEST variable in service worker.
Here is how the plugin is configured un my vite.config.ts:
    VitePWA({
      mode: 'development',
      srcDir: 'src',
      filename: 'sw.ts',
      base: '/',
      strategies: 'injectManifest',
      registerType: 'autoUpdate',
      includeAssets: ['/favicon.svg'], // <== don't remove slash, for testing purposes
      manifest: {
        name: 'myApp',
        short_name: 'myApp',
        theme_color: '#0070B2',
        icons: [
          {
            src: '/pwa-192x192.png', // <== don't remove slash, for testing purposes
            sizes: '192x192',
            type: 'image/png',
          },
          {
            src: '/pwa-512x512.png', // <== don't remove slash, for testing purposes
            sizes: '512x512',
            type: 'image/png',
          }
        ],
      }
    })

registerSW.ts that is imported in main.ts (because virtual:pwa-register/vue can't be used with vue 2):
import { registerSW } from 'virtual:pwa-register'

function handleSWManualUpdates(swRegistration: ServiceWorkerRegistration | undefined) {
  // noop
}

function handleSWRegisterError(error: any) {
  // noop
}

try {
  const updateSW = registerSW({
    immediate: true,
    onOfflineReady() {
      console.log("onOfflineReady")
    },
    onNeedRefresh() {
      console.log("onNeedRefresh")
    },
    onRegistered(swRegistration) {
      swRegistration && handleSWManualUpdates(swRegistration)
    },
    onRegisterError(e) {
      handleSWRegisterError(e)
    }
  })
} catch {
  console.log("PWA disabled.")
}

the service worker himself:
import { precacheAndRoute, cleanupOutdatedCaches } from 'workbox-precaching'
import { clientsClaim } from 'workbox-core'
declare let self: ServiceWorkerGlobalScope

precacheAndRoute(self.__WB_MANIFEST)

self.skipWaiting()
clientsClaim()

cleanupOutdatedCaches()

self.addEventListener('message', (event) => {
  if (event.data && event.data.type === 'SKIP_WAITING')
    self.skipWaiting()
})

@vcastro45 take a look at https://vite-plugin-pwa.netlify.app/frameworks/vue.html#vue-2

@vcastro45 see also https://github.com/antfu/vite-plugin-pwa/issues/81

@userquin It still not working in vue 2 using the code you suggested in the code (mixin used in the App.vue component in my case).
isn't it possible to just make it available with the "composition api way" for vue 2 ?

@userquin It still not working in vue 2 using the code you suggested in the code (mixin used in the App.vue component in my case).

can you provide a repo? some error on client side? maybe you have some ui error...
the repo on #81 is working, you can compare your client logic...

isn't it possible to just make it available with the "composition api way" for vue 2 ?

This repo is about pwa, it is framework agnostic, right now there is no plan to add support for vue2.

@vcastro45 you are using auto update behavior on your custom service worker? the onNeedRefresh will never be called.
You need to remove/comment out these 2 lines from your custom service worker:
// self.skipWaiting()
// clientsClaim()

@userquin After some more investigations, I resolved the problem. I had to increase the value of the maximumFileSizeToCacheInBytes variable in config (that is a part of the workbox config editable through the VitePWA config).
The default value is 3000000 bytes and I needed more.
I don't know if it is an issue for Workbox or vite-plugin-pwa but in my opinion it must show an error in the console, but it still silent.
Here is the config to add:
injectManifest: {
  maximumFileSizeToCacheInBytes: 3000000 // Change this value to your needs
}

@vcastro45 thx, I'll investigate, seems you're using injectManifest strategy I'll try to log warnings returned by workbox while injecting the manifest.

@vcastro45 changing the module to log warning and configuting "injectManifest: { maximumFileSizeToCacheInBytes: 100 }" result building vue-basic-inject-manifest is:
vite v2.4.4 building for production...
[plugin:replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
✓ 2 modules transformed.
✓ 20 modules transformed.
dist/assets/my-worker.5c299b37.js   0.19kb
dist/index.html                     0.76kb
dist/manifest.webmanifest           0.39kb
dist/assets/index.40de6d3d.css      0.45kb / brotli: 0.21kb
dist/assets/index.f88b1f55.js       2.44kb / brotli: 1.03kb
dist/assets/vendor.04fc395e.js      52.48kb / brotli: 18.76kb
@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
assets/index.40de6d3d.css is 461 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
assets/index.f88b1f55.js is 2.5 kB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
assets/my-worker.5c299b37.js is 192 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
assets/vendor.04fc395e.js is 53.7 kB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
index.html is 777 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.

Thx, I'll psuh a PR and include some hint on the docs.

Also need to log when using workbox-build::generateSW, also configurable on workbox plugin option when using generateSW strategy.

I'll also log the result when viteOptions.logLevel === 'info', the warnings will be always logged.

Using vue-basic-inject-manifest as example with:
      injectManifest: {
        maximumFileSizeToCacheInBytes: 100,
      },

will log following on console:
vite v2.4.4 building for production...
[plugin:replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
✓ 2 modules transformed.
✓ 20 modules transformed.
dist/assets/my-worker.5c299b37.js   0.19kb
dist/index.html                     0.76kb
dist/manifest.webmanifest           0.39kb
dist/assets/index.40de6d3d.css      0.45kb / brotli: 0.21kb
dist/assets/index.7628d999.js       2.44kb / brotli: 1.03kb
dist/assets/vendor.04fc395e.js      52.48kb / brotli: 18.76kb
@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.

PWA workbox-build::injectManifest result:
  - Total number of precached entries: 4 entries
  - Aggregate size of all the precached entries: 0 bytes
  - Written to swDest:
    - F:/work/projects/quini/GitHub/antfu/vite-plugin-pwa/examples/vue-basic-inject-manifest/dist/sw.js

PWA workbox-build::injectManifest warnings:
  - assets/index.40de6d3d.css is 461 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/index.7628d999.js is 2.5 kB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/my-worker.5c299b37.js is 192 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/vendor.04fc395e.js is 53.7 kB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - index.html is 777 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.

while removing maximumFileSizeToCacheInBytes: 100 the result will be:
vite v2.4.4 building for production...
[plugin:replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
✓ 2 modules transformed.
✓ 20 modules transformed.
dist/assets/my-worker.5c299b37.js   0.19kb
dist/index.html                     0.76kb
dist/manifest.webmanifest           0.39kb
dist/assets/index.40de6d3d.css      0.45kb / brotli: 0.21kb
dist/assets/index.d6db4d87.js       2.44kb / brotli: 1.03kb
dist/assets/vendor.04fc395e.js      52.48kb / brotli: 18.76kb
@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.

PWA workbox-build::injectManifest result:
  - Total number of precached entries: 9 entries
  - Aggregate size of all the precached entries: 57667 bytes
  - Written to swDest:
    - F:/work/projects/quini/GitHub/antfu/vite-plugin-pwa/examples/vue-basic-inject-manifest/dist/sw.js

Using vue-router as example with:
      workbox: {
        maximumFileSizeToCacheInBytes: 100,
      },

will log following on console:
vite v2.4.4 building for production...
[plugin:replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
✓ 2 modules transformed.
✓ 38 modules transformed.
dist/assets/my-worker.5c299b37.js   0.19kb
dist/index.html                     0.76kb
dist/manifest.webmanifest           0.38kb
dist/assets/about.dbc02b0b.js       0.37kb / brotli: 0.27kb
dist/assets/home.49c5ea42.js        0.81kb / brotli: 0.43kb
dist/assets/[name].19b70817.js      0.46kb / brotli: 0.30kb
dist/assets/index.09ee2ee1.js       3.62kb / brotli: 1.47kb
dist/assets/index.40de6d3d.css      0.45kb / brotli: 0.21kb
dist/assets/vendor.31de95e7.js      77.22kb / brotli: 26.93kb

PWA workbox-build::generateSW result:
  - Total number of precached entries: 4 entries
  - Aggregate size of all the precached entries: 0 bytes
  - Written to swDest:
    - F:/work/projects/quini/GitHub/antfu/vite-plugin-pwa/examples/vue-router/dist/sw.js
    - F:/work/projects/quini/GitHub/antfu/vite-plugin-pwa/examples/vue-router/dist/workbox-4c95f9b5.js

PWA workbox-build::generateSW warnings:
  - assets/[name].19b70817.js is 468 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/about.dbc02b0b.js is 379 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/home.49c5ea42.js is 828 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/index.09ee2ee1.js is 3.71 kB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/index.40de6d3d.css is 461 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/my-worker.5c299b37.js is 192 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - assets/vendor.31de95e7.js is 79.1 kB, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.
  - index.html is 777 B, and won't be precached. Configure maximumFileSizeToCacheInBytes to change this limit.

while removing maximumFileSizeToCacheInBytes: 100 the result will be:
vite v2.4.4 building for production...
[plugin:replace] @rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
✓ 2 modules transformed.
✓ 38 modules transformed.
dist/assets/my-worker.5c299b37.js   0.19kb
dist/index.html                     0.76kb
dist/manifest.webmanifest           0.38kb
dist/assets/about.c97efa85.js       0.37kb / brotli: 0.24kb
dist/assets/home.e174882d.js        0.81kb / brotli: 0.43kb
dist/assets/[name].5815f9b3.js      0.46kb / brotli: 0.30kb
dist/assets/index.40de6d3d.css      0.45kb / brotli: 0.21kb
dist/assets/index.eb71fcbe.js       3.62kb / brotli: 1.47kb
dist/assets/vendor.31de95e7.js      77.22kb / brotli: 26.93kb

PWA workbox-build::generateSW result:
  - Total number of precached entries: 12 entries
  - Aggregate size of all the precached entries: 85895 bytes
  - Written to swDest:
    - F:/work/projects/quini/GitHub/antfu/vite-plugin-pwa/examples/vue-router/dist/sw.js
    - F:/work/projects/quini/GitHub/antfu/vite-plugin-pwa/examples/vue-router/dist/workbox-4c95f9b5.js

@vcastro45 can you take a look at docs on the PR?

https://deploy-preview-135--vite-plugin-pwa.netlify.app/workbox/generate-ws.html
https://deploy-preview-135--vite-plugin-pwa.netlify.app/workbox/inject-manifest.html

See Missing assets from SW precache manifest and Log injecManifest result.

@userquin looks good to me
Thanks for your prompt response and fix


Mini preview works, but screensaver is black screen (Sonoma)

This may be related to #75 - if it is, please close this one!
I'm on an M1 macbook pro, since running Sonoma (yeah I know, should have left it a few more months) all I get is a black screen from WebScreenSaver 2.2.1.
I've tried my usual screensaver (which is a pretty simple HTML + CSS + raw Javascript thing). I've also tried a "hello world" bit of plain HTML - neither work, and neither do any other websites I've tried (eg. google home page, BBC, etc). All of these look okay in Safari. I have also made sure it's not a case of black text over a black background ;-)
In System Settings -> Screensavers, I see the little preview window at the top, which "works" in so much as I see my content in it - it's all a bit wrongly scaled and whatever, but I can see it's my screensaver.
I've tried uninstalling previous installs, brew installing, installing from the Zip ... you name it, they all seem to do the same thing.
Here's how it's supposed to look: https://www.pre-emptive.net/screensaver/
Here's a hacked version with all the JS removed, some HTML removed, lots of styles removed: https://www.pre-emptive.net/screensaver/simple/ (this one sometimes shows the logo, sometimes it doesn't, sometimes is just black, sometimes white)
To finish, I'd like to say how awesome this screensaver is/has been - it's a super simple and great way to 'brand' a Mac with company colours and whatnot. I've historically used it to show I'm a contractor and not one of the corporate drones in the office. I'm always amazed I don't see more people doing the same thing!

Definitely the same as #75
Please try out newly released v2.3 and lmk.

Awesome! v2.3 works very nicely - and I like the new preview 'eye' feature too. It feels like the settings dialogue box is more responsive too - all told, a lovely update :-)
As a side note, weirdly, even though I changed the URL from .../screensaver/simple/ to just .../screensaver/, the old one continued to show when the screensaver came on (or if I click the preview box on the Settings page - not the new 'eye'). I killed off two processes called /System/Library/Frameworks/ScreenSaver.framework/PlugIns/legacyScreenSaver.appex/Contents/MacOS/legacyScreenSaver and then it worked fine (and the processes have been refreshed).


Error when checking scope assignments in Admin portal

Description:

When clicking on the scope assignments for any user, the following error is getting thrown.
Cannot read property 'length' of undefined

Steps to reproduce:

Go to admin portal
Click on scopes assignment tab
Click on scopes assignment for admin user (or any user)

Affected Product Version:

wso2am-4.0.0-alpha
Environment details (with versions):

OS: Mac
Client:
Env (Docker/K8s):

This issue is no longer reproducible in the latest pack


Fixup: Populate BootInfo::cmd{line,size}

As an oversight in https://github.com/hermitcore/rusty-loader/pull/123, I forgot to populate BootInfo::cmd{line,size}.
Closes https://github.com/hermitcore/hermit-entry/issues/3.

bors r+


How to update the document field in collection using restangular

I want to update the username field in user document using restangular..I can't understand how to update the filed using restangular.
please help me how to resolve this,
thanks in advance

just use patch method to update document syntax is show in bellow .
Restangular.one(people,<some_id>).patch({'username':'somenamme'},{},{<headers})


Return valid code MTRError when commissioning is attempted with duplicate NOC

Problem
MTRError doesn't define code for duplicate fabric, therefore clients receive MTRError with default code 1. Here is how error message looks like-
Error Domain=MTRErrorDomain Code=1 "Undefined error:126." UserInfo={underlyingError=<MTRErrorHolder: 0x106223f20>, NSLocalizedDescription=Undefined error:126., errorCode=126}

Proposed Solution
We should define a new MTRError code and return that instead of above

This is needed so we can gracefully handle cases where the accessory is already added to the fabric previously.

Note to self: that's CHIP_ERROR_FABRIC_EXISTS.


Rename MSFragger to FragPipe (issue #166)

Since the actual software is called FragPipe and MSFragger is the search engine, we should rename all of those.

This looks great, thanks. I just added a few modifications in the docs.


go fmt

post-fix #234
I did not want to hold up merge of #234 on account of gofmt

now golint issue

done


brew install lazydocker don't work

brew install lazydocker don't work. The message is:
Docker event stream returned error: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

I'm running it on MacBook Pro M1. Docker is running.

You must run your docker engine first  ( dockerd )

Same thing was happening to me, it's a bug fixed two days ago; see changelog for 4.13.1

Had the same problem, can confirm that the latest Docker update fixes the issue.

After installing lazydocker both the one and the other method of application in the latest MacOs does not start.

@Zbigniewlatka is there an error message? Is it a M1 mac?

there is no message. MacBook 2020 M1. :)

Found my solution here, on MacOS looks like the docker socket is somewhere else by default so I had to create a symlink
sudo ln -s ~/Library/Containers/com.docker.docker/Data/docker.raw.sock /var/run/docker.sock
DOCKER_HOST=unix:///var/run/docker.sock docker ps # test that it works using linked socket file

Source -> https://stackoverflow.com/a/74148162

The solution above worked for me, but that's pretty annoying and might make some people stop using this app. Any expectations to include this fix to the main lib?

Is this something that can be fixed by bumping the docker SDK from within lazydocker or do users just need to update their docker versions?

I think this may be fixed in the latest Docker Desktop release, or at least there is an option to get the behavior I would expect.


Create design for WebDev team modal

Description
With reference to #98, provide a design for WebDev team modal to be displayed on the hG website. You should be following space theme for this. Kindly go through the website to get the design asthetics of the website and make this relevant to the present design. The modal should contain all the avatar/card of all the contributors of the project. You should also make a design for mobile version of the modal.
Screenshots/testimonials
NA

Heads up @EricLiclair and @tusharjain0022!

may i know the details to be included in the cards ?
Name, email? Github link? linkedin?
what else?

name, github, linkedin, email sounds good anything more @EmperorYP7 @hariom1625 @tusharjain0022

Yep that's all we need.

Do we've any progress here? @EricLiclair

Based on the info that we can get from the GitHub contribution list API (Profile pic , profile link , repo link, no. of contributions) , I've created few designs for this issue.
1

2

I would prefer 1 over 2. What do you all think? @hariom1625 @ankiiitraj @Vishal19111999 @EricLiclair

My vote goes to 2

We need progress on this @EmperorYP7

Oops. missed it.

I will vote for 1 and on click on photo it should open my github profile in new tab.
Really liked your work @tusharjain0022 🎉

working on it 🙌


Document building standalone dkms modules (that can be built against multiple kernels and work) from the contents of https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/tree/master/drivers/gpu/drm/amd

Are there any official (I have found some obsolete unofficial, but I guess there should be the ones AMD uses itself somewhere...) docs/recepies/scripts for generating Debian packages from the contents of https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/tree/master/drivers/gpu/drm/amd ? I ask because it seems the official packages targeting obsolete (I mean, considered obsolete by the ones having SNS syndrome) versions of Ubuntu are incompatible with vanilla Debian, and so it'd be nice to build own ones.

An internal ticket has been created to track the progress of this query.


add codeblock thing for tags when tag-based commands are used

when someone uses a tag-based command, such as edittag or teampen, instead of making the player numbers still highlighted, make tags have numbers that are highlighted to show indexes.

done in commit ea2c1d86aee3fea88d17719a4e49fe2052ddd1fa