Finetune of scripts/train/yamls/finetune/mpt-7b_dolly_sft.yaml with alibi and triton emits sketchy log

Tried setting max_seq_len to 5k and added alibi to attn config with Triton flash attn.
Otherwise using: scripts/train/yamls/finetune/mpt-7b_dolly_sft.yaml.
Finetuning seems to be working but it does emit this sketchy log during pretraining. Wondering if anyone has seen this?
Map:  12%|█▏        | 1750/15015 [00:01<00:08, 1573.51 examples/s]Token indices sequence length is longer than the specified maximum sequence length for this model (5201 > 5120). Running this sequence through the model will result in indexing errors

You can ignore these specific warnings. The Hugging Face code emits this warning when tokenizing the dataset if it sees a sample that, when tokenized, is longer than the model_max_length parameter of the tokenizer.
Our finetuning code handles truncation based on the max_seq_len parameter that you set, and it will give you its own messages to announce any truncation that it is going on.
We have not seen any sign of the indexing errors that the HF warning refers to.


electrofishing site names do not contain ef

are they actually ef sites or should they be pulled from table 4.3

Oh I just realised what you meant by this. There are two site names 197534_us4 and 197534_us5 in table 4.3 that aren't electrofishing sites. Those are the two hab surveys we did upstream of the ford. I can filter those out.


CGI Removal

Removed cgi due to deprecation and updated to use email.message.Message instead.

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?
Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?
Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

All files have been updates and both black and mypy commands have been run with corrections made.


Change ConfFile API

Followed suggestions on https://github.com/01org/camera-streaming-daemon/pull/29

First 4 patches applied

Branched updated. All proposed fixes that I said that I would fix, or that were not commented were fixed.
I added some documentation on how to use ConfFile too.
And I removed the global_instance() static function because we won't need to use ConfFile as singleton in mavlink-router nor camera-streaming-daemon and it makes more sense to have it as a regular class.

Another issue I've found: if I run mavlink-router without pointing to any config file, it just exits, no error, no nothing.

Pushed new branch with all proposed fixes

Branch updated with proposed fixes and new api for looping subsections

Great stuff!!
Thanks for all the rework. It looks like a really good API now.  I added 2 small commits on top with minor things/nitpicks. Applied.


Gitpod webpage unresponsive when trying to close the "Preview" pane

System config
OS: macOS 10.15.5
Browser: Chrome 86.0.4240.183 (not using Gitpod extension)
Steps to trigger the problem:

Follow each step in the "Instructions" section of README.md. After running gp preview $(gp url 8000), the Preview pane is opened and display the frontend webpage.

Try to close this panel by clicking "Close" on the context menu.

The webpage for Gitpod becomes unresponsive. I need to close this weppage and restart the Gitpod workspace to make it work again.

Other notes

I'm new to Gitpod and eosio-web-ide. So I'm not sure if this problem is caused by Gitpod itself or some config here.
If other user gets the same problem, one workaround is to use external browser for the frontend webpage (in "Open Ports" tab -> "8000", select "Open Browser").

This seems to be a Gitpod issue. We are closing it to focus on other priorities. Please reopen if needed.


Where can I find the data produced by the docker image?

Hi @tdurieux,
I am using the docker image (id fbbb430881e3) you kindly provided to run Nopol on Math-76 from the Defects4J benchmark:
$ mkdir -p /tmp/repairthemall/attempt_9_7_2019
$ docker run -it --rm -v /tmp/repairthemall/attempt_9_7_2019:/results tdurieux/repairthemall Nopol -b Defects4J -i Math_76
1 Running, 0 Waiting, 0/1 Finished, 0 Patched, 0 Error
Running:
1. Nopol Defects4J_Math_76 0:03:13
Patched bug:

1 Finished, 1 Patched, 0 Error

Check the results and logs in /results/

but I can't find the results/log files. I noticed the message Check the results and logs in /results/ but where is that /results/? I was expecting to find the results/log files in /tmp/repairthemall/attempt_9_7_2019, otherwise why would I need to provide a <absolute_path_to_store_results> as suggested in here... 😅
My system:
$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.14.5
BuildVersion:	18F132

$ docker --version
Docker version 18.09.7, build 2d0083d

--
Best,
Jose

Check the results and logs in /results/ but where is that /results/?
This message is only valid when you run it locally. The results are in tmp/repairthemall/attempt_9_7_2019.

That's what I thought but there is not file in /tmp/repairthemall/attempt_9_7_2019.

That is strange :/
Did the folder /tmp/repairthemall/attempt_9_7_2019 exist, when you started the execution?

Yep. As you can see in my first message, I create the folder /tmp/repairthemall/attempt_9_7_2019 before executing the docker command.

It is really strange, I tried again the docker image and the output is correctly created.
(my command line: docker run -it --rm -v /tmp/Chart_1_buggy:/results tdurieux/repairthemall Nopol -b Defects4J -i Math_76)
Are you sure that /tmp/repairthemall/attempt_9_7_2019/Defects4J/Math/76/Nopol/7/repair.log does not exist?
I have the same os version and a slightly older docker version.

It is really strange

Indeed.

I tried again the docker image and the output is correctly created (but no patch is generated).

Are you using docker image id fbbb430881e3?

Are you sure that /tmp/repairthemall/attempt_9_7_2019/Defects4J/Math/76/Nopol/7/repair.log does not exist?

$ cat /tmp/repairthemall/attempt_9_7_2019/Defects4J/Math/76/Nopol/7/repair.log
cat: /tmp/repairthemall/attempt_9_7_2019/Defects4J/Math/76/Nopol/7/repair.log: No such file or directory

I have the same os version and a slightly older docker version.

Any chance you could try to run the command on the same docker version I am using? I know nothing about docker so I followed this guide to install it on my machine. Could my installation be, somehow, broken?

I've just tried a couple other bugs and /tmp/repairthemall/attempt_9_7_2019 is still empty. Is there any log I can access by sshing the docker image? Or maybe any other parameter I could use to make the execution more verbose? So that we could try to understand what's going on...

Are you using docker image id fbbb430881e3?
Yes, I do use the same image

I tried to use the same folder name and the exact same command line and it is working :/
Could you check the permission of the folder /tmp/repairthemall/attempt_9_7_2019?

Any chance you could try to run the command on the same docker version I am using?
Docker said that You’re up-to-date! :/

know nothing about docker so I followed this guide to install it on my machine.
Normally, you have nothing to do to be able to use this Docker image.

Or maybe any other parameter I could use to make the execution more verbose?
The tool does not support a verbose mode for the moment, I will try to do it in the following days.

Could you check the permission of the folder /tmp/repairthemall/attempt_9_7_2019?

The permissions look ok to me:
$ ls -la /tmp/repairthemall/attempt_9_7_2019
total 0
drwxr-xr-x 2 jose wheel 64 Jul  9 17:37 ./
drwxr-xr-x 3 jose wheel 96 Jul  9 17:37 ../

Can I ssh the docker image and run stuff locally? If yes, how?

You can do something like this:
docker run -it --entrypoint /bin/bash tdurieux/repairthemall
cd script;
python repair.py Nopol -b Defects4J -i Math_76;
cat /results/Defects4J/Math/76/Nopol/7/repair.log;

Thanks @tdurieux, that did work without any issue.

I think I got to the bottom of the problem. It seems that /tmp is not mounted by docker (or maybe the VM, I am not sure) and therefore no file could ever be written to that directory. If I change the -v option to, for example, my deskop folder, it works just fine:
$ docker run -it --rm -v /Users/jose/Desktop:/results tdurieux/repairthemall Nopol -b Defects4J -i Math_76

$ find /Users/jose/Desktop/Defects4J/Math/76/Nopol/7/
/Users/jose/Desktop/Defects4J/Math/76/Nopol/7/
/Users/jose/Desktop/Defects4J/Math/76/Nopol/7/result.json
/Users/jose/Desktop/Defects4J/Math/76/Nopol/7/repair.log
/Users/jose/Desktop/Defects4J/Math/76/Nopol/7/detailed-result.json

Although this issue has been around for quite some time, I have not managed to find a proper solution.

Fev, 2015 -- https://github.com/docker/compose/issues/1039
Jun, 2016 -- https://stackoverflow.com/questions/37673140/docker-volume-located-in-tmp-on-osx-empty

Did you configure docker or docker-compose or the VM to be able to read/write to /tmp? I noticed on VirtualBox that the only 'Shared Folder' of the VM that's running is /Users. So, I

Stopped docker, $ docker-machine stop default
Added /tmp as a 'Shared Folder' to the VM on VirtualBox with read/write permissions and auto-mount enabled
Restarted docker, $ docker-machine start default
Re-ran the docker command, docker run -it --rm -v /tmp/repairthemall/attempt_9_7_2019:/results tdurieux/repairthemall Nopol -b Defects4J -i Math_76. And got the same outcome, no file was written or copy to /tmp/repairthemall/attempt_9_7_2019.

I guess I will have to use any directory in /Users.
PS: You might want to add a few words about this problem to the docker section in the README file, so that others could easily figure out why no file is written to the provided directory.

Thank you for investigating this.
Here is my configuration of my Docker File Sharing settings. I don't remember that I modified it but maybe it is different on your laptop.

It is a good idea to add view words about this in the usage.

Ah, I don't think I have that app. Is that 'Docker Desktop for Mac'? Did you install it from docker hub? Or did you use homebrew to install it?

Yes it is 'Docker Desktop for Mac', I installed it from docker hub, I had an issue with homebrew

Ok, I should have installed the following (which is basically the 'Docker Desktop for Mac')
$ brew cask install docker

The files are now written to /tmp.
Once again, thanks for your help @tdurieux.

Once again, thanks for your help @tdurieux.

With pleasure, it is always nice to see that people succeed to use our tool!


Feature/motionhistory dep

Replaces the APCAppCore.h import with APCLog.h to not create an unneeded dependency. We use motion history reporter but not all of AppCore, so cannot import APCAppCore.h.
Second commit collapses some whitespace in the direction of the style guide.

r=me.


attempt a record linkage between EIA utilities and CorpsWatch's SEC filers

This is a next step out of the preliminary investigation from #2225
In scope

[x] use one-off downloaded & extracted CorpsWatch EX-21 data to make a utility table to compare to EIA

[x] probably have multiple records per utility for each address-type

[x] prep an EIA utility table with cooresponding columns to match based on
[ ] setup a simple unsupervised rl process
[ ] key results needed:

[ ] how many SEC filers are matched to EIA utils?
[ ] how many EIA utils are matched to SEC filers?
[ ] Spot check a few dozen for accuracy

Out-of Scope

[ ] archiving CorpsWatch's Exhibit 21 data
[ ] integrating the EX-21 data into pudl
[ ] generating training data

I did an initial pass at record linkage with just 2005 data and here are some questions I'm left with. Pretty much zero tuning went into this model so results are, as expected, nowhere near perfect.
I'm using splink and it provides some helpful charts to understand the modeling process.
This first chart shows the match weight for each of the "comparison levels". For example, if the utility names of two records have a Levenshtein edit distance < 2, then it will be given a positive match weight of ~8 for the utility name comparison. If the city names are very different, it will be given a very negative match weight.

This next chart shows how records that the model deems to be a match are distributed amongst the comparison levels. Of note here is that of the matching records, ~97% have a utility name Levenshtein edit distance > 5. Additionally, of the matching records, 98% have an exact match on city.

Takeaways:

utility name isn't being weighted high enough?

My intuition was that utility name should likely be within close edit distance for matching records. But maybe I'm wrong. There are a lot of situations it seems where two records have the same street address, but the name is very different. Maybe I misunderstood the context of the problem, but I thought we were trying to match parent and owner companies, and 90% of the time it's one to one. I guess the matching companies might have very different names?
My intuition of placing a high weight on utility name matching is also incorporated in my blocking rules. So the blocking currently doesn't reflect the match weights, which means the model isn't performing very well.

city and zip code are dependent variables

I think this is actually kind of a big issue with this first baseline model. As long as the city and zip aren't filled in erroneously, then this is often a one to one mapping. I believe this could mean that a correct city and zip match are being weighted too high, when street address is actually more of the distinguishing location variable.

With just the 2005 data, the model matches about 60% of SEC companies and 10% of EIA companies (assuming that the threshold for a correct match is a score of .5 or greater). There are far fewer SEC companies so this is sort of expected.
I think with some pretty basic tuning, results will get much better.

I'm not sure what you mean by this:

Maybe I misunderstood the context of the problem, but I thought we were trying to match parent and owner companies, and 90% of the time it's one to one.

I may not have enough context here but IIRC, the CorpWatch database has a table that's all of the companies, covering both the parents and subsidiaries, and I thought that the record linkage problem we wanted to do was to find matches between that big SEC list of companies and the EIA list of utilities, without (initially) concerning ourselves about which role they're playing.
With that linkage, we'd hopefully be able to join the SEC/CorpWatch company ID into the utilities_entity_eia or utilities_eia860 table, and use the relationships between parents & subsidiaries reported in the Corpwatch DB (based on their SEC/CorpWatch company ID) to aggregate up EIA ownership or operator data to the parent company level.
Why did you choose 2005 to start with? I could imagine the addresses associated with utilities changing a fair bit from year to year, and it might be that they change at different times in the two datasets (or even that they report entirely different addresses to SEC vs. EIA -- incorporation location in Delaware vs. operational HQ?). Might it make sense to try doing the record linkage without considering year to start with? Just get a deduplicated list of all the companies in both datasets with all the names and addresses they've ever reported?
IIRC, we are not currently harvesting utilities that only show up as owners (See #1393) which means you'll need to compile your own mall-encompassing list of potential utility names and addresses, based on both the ownership_eia860 and utilities_eia860 tables.
On the Zip codes, I would think that it would be common for one city to have many zip codes, and rare for one zip code to have multiple cities (probably only in really rural places), but I'm sure both of them happen.  But I would expect each full address to have an almost perfectly 1:1 relationship with zip code (unless the zip code boundaries got moved, which happens occasionally I think).
I bet there are some standard address normalization libraries out there we could use. Or I think USPS has an API for standardizing addresses too, but it might be annoying to use / rate-limited.
I agree with your intuition that the company names should be highly weighted. You could have lots of companies registered to the same (or almost the same) address, as often happens with PO Boxes in Delaware.
But at the same time, I think a lot of parents and subsidiaries will have similar names, Like look at how many utility names contain the word "Duke" in the EIA data. I think the exact match + Levenshein distance <= 2 criteria might be too stringent, or not the right way to do it. I'm sure there are misspellings, but I think differences will more frequently arise from things lik Inc vs. Incorporated vs. Corp. (or lack of Inc at all), LLC vs. Limited or Ltd. Maybe some address-style normalization of these words makes sense?

@katie-lamb @cmgosnell @jrea-rmi Some work from Climate Trace that might be interesting in the context of this issue:

Write-up on their attempt to figure out who owns which xenoforming stations
Methodology (PDF)
Data downloads as CSV (view by country, and then download the US non-forestry data to get electricity system data, it's behind a registration wall).

That's probably a significant fraction of electricity sector emissions, but doesn't get us owned generation mwh and will miss a lot of utilities that we'd do analysis on. So unfortunately probably not a new complete resource we could use

I may not have enough context here but IIRC, the CorpWatch database has a table that's all of the companies, covering both the parents and subsidiaries, and I thought that the record linkage problem we wanted to do was to find matches between that big SEC list of companies and the EIA list of utilities, without (initially) concerning ourselves about which role they're playing.

Got it. This makes sense. The names actually will match up then.

Why did you choose 2005 to start with? I could imagine the addresses associated with utilities changing a fair bit from year to year, and it might be that they change at different times in the two datasets (or even that they report entirely different addresses to SEC vs. EIA -- incorporation location in Delaware vs. operational HQ?). Might it make sense to try doing the record linkage without considering year to start with? Just get a deduplicated list of all the companies in both datasets with all the names and addresses they've ever reported?

This was mostly because if you ignore year as a blocking rule, there are a ton of essentially duplicate records on both sides that I thought would potentially mess with matching. And I wanted instantaneously fast results lol. Agree that a good next step is going to be deduplicating both datasets. In the SEC data there’s a column for min year and max year, which I assume represent when there was a change in address, and for what years that address is applicable. There’s also a year column that falls within that that range. I thought it might work to just match this year column with the EIA records, but agree that some potentially bad address reporting makes this not a great strategy.

IIRC, we are not currently harvesting utilities that only show up as owners (See #1393) which means you'll need to compile your own mall-encompassing list of potential utility names and addresses, based on both the ownership_eia860 and utilities_eia860 tables.

Ah interesting, I didn’t realize this.

I agree with your intuition that the company names should be highly weighted. You could have lots of companies registered to the same (or almost the same) address, as often happens with PO Boxes in Delaware.
But at the same time, I think a lot of parents and subsidiaries will have similar names, Like look at how many utility names contain the word "Duke" in the EIA data. I think the exact match + Levenshein distance <= 2 criteria might be too stringent, or not the right way to do it. I'm sure there are misspellings, but I think differences will more frequently arise from things lik Inc vs. Incorporated vs. Corp. (or lack of Inc at all), LLC vs. Limited or Ltd. Maybe some address-style normalization of these words makes sense?

Ya I agree that Levenshtein maybe isn’t the right metric here. I did some very basic string cleaning and normalization on the addresses, but definitely more normalization is an easy next step.

@katie-lamb if you haven't seen it, the OS-Climate CompanyNameCleaner has some useful tools for cleaning company names
https://github.com/os-climate/financial-entity-cleaner

I made a few quick changes to the preprocessing and reran the model:

Included the owner names from the PUDLownership_eia860 table that aren't in the utility_eia860 table.
Used the OS-Climate CompanyNameCleaner to clean the company names (LLC -> Limited Liability Company), did another round of cleaning on addresses (St. -> Street).
Deduplicated the records on utility name, address, city, and zip instead of filtering by year. After deduplication, the year attribute is ignored during matching.
Tried to improve blocking and model m and u parameter training to create a higher match weight for utility name.
Switched to using Jaccard similarity instead of Levenshtein edit distance to compare strings.

Results were slightly better, but still too much weight is put on city and not enough on utility_name. This is  something that could be tuned in the blocking/parameter training step by playing with the comparison levels and metrics that are made between records. Additionally, I think I need to use a string distance approach that looks at the corpus of names as a whole, and recognizes that words like "limited", "liability", "company", "corporation", etc. are very common and does a term frequency adjustment for this.
Here's a random sample of the predicted matches

that have a match probability greater than .7.

Ya that's a good question and something I'm trying to figure out with the CCAI work. The hardcoded similarity metrics are Jaccard, Jaro-Winkler, and Levenshtein, but they're subclasses of a generic Distance Metric class that I can use to implement a cosine similarity. I'm not sure how it would actually perform with the model. I think it could work.

The Inverse Document Frequency (IDF) part of TF-IDF deals with the presence of common (and thus not very important) words like "Limited" and "Corp" nicely. If the matching is being impacted more by word-level differences than myriad misspellings, maybe word-level tokenization rather than length-N substrings would be good enough, in which case it wouldn't blow up memory in the same way that it does in the FERC Plant ID assignments?

I'm closing this issue as this was a good first pass to get us to understand what a full integration and linkage would entail. Next steps coming soon & will link back to this PR


Reorder AzureContainerApps main to enable early exit when imageToDeploy parameter is provided.

Duplicate of https://github.com/microsoft/azure-pipelines-tasks/pull/17726 from main task repo.

@jamesmacfd Hey James, apologies for delaying your PR -- we're working on syncing the stable task released in the microsoft/azure-pipelines-tasks repository with the latest changes in this RC repository, so as soon as we get that updated and merged, I'll loop back to this PR and make sure it gets in.

@jamesmacfd Hey James, apologies for an even longer delay -- we just merged a PR that completely refactored the flow of the main method executed for the task, making it easier to follow and sectioning off different scenarios that users can target.
For the issue that your PRs target, this refactoring has resolved the issue as the pack CLI is now only installed when the scenario to build a runnable application image using the builder is targeted, seen here.
Your scenario for providing a pre-built image now has an independent flow that doesn't touch anything relating to building and/or pushing images, seen here.
This refactoring (and other changes) are now available in the 1.0.0 release of the RC task, and will soon be available in the stable task, so feel free to give it a try and let us know if you have any issues and concerns. We appreciate you opening the original set of PRs to get this realignment work in motion!


build: removing reredirect sphinx extension

Description
This is extension is no longer used (or at least I couldn't make it work properly ... almost ever).
Furthermore, with the change in the domain at the higher level, I dont think this extension is explicable for the current cases.
Issue linked
Close #3216
Checklist

[ ] I have visited and read Develop PyMAPDL.
[ ] I have tested my changes locally
[ ] I have added necessary documentation or updated existing documentation.
[ ] I have followed the PyMAPDL coding style guidelines.
[ ] I have added appropriate unit tests that also ensure the minimal coverage criteria.
[ ] I have reviewed my changes before submitting this pull request.
[x] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have marked this PR as draft if it is not ready to be reviewed yet.
[x] I have made sure that the title of my PR follows Commit naming conventions (e.g. feat: adding new MAPDL command)

@pyansys-ci-bot LGTM.

The branch check will never pass until a new branch and PR is set. Sooo... I'm merging anyway.


YouTube-first decks sorting

Sort decks in explorer in default priority:

Decks with youtube attached for last 24 hours
Decks with description more than 200 characters for last 24 hours
Everything else sorted by add date

Limited to the top 3 positions?


Starts drawing only after 5mm into the stroke

Once your drawing your signature it tracks the movement of your finger nicely. It also accepts the tap well. However there is a lag between when you start moving your finger and when the gesture recognizer detects it as a pan gesture.

Thanks for fixing it! :)

You’re welcome - thanks for doing all the rest…
On Dec 15, 2015, at 4:19 PM, GJ Nilsen <notifications<EMAIL_ADDRESS>wrote:
Thanks for fixing it! :)
—
Reply to this email directly or view it on GitHubhttps://github.com/yuppielabel/YPDrawSignatureView/issues/3#issuecomment-164922265.


"You are not authorized with Logz.io! Token OK? dropping logs..." error effectively empty the buffers

Hi there,
When we tried to integrate Fluentd with Logz.io we misused the token part of the endpoint_url parameter. That resulted in HTTP 401 responses from the logz.io endpoint.
As a result, a lot of You are not authorized with Logz.io! Token OK? dropping logs... came out in our container logs.
This message comes from the following code in the lib (line 143)
if response.code == '401'
       log.error "You are not authorized with Logz.io! Token OK? dropping logs..."
       should_retry = false

In the end, it appears the message is effectively pulled out of buffer, then dropped (not retried nor put back in the buffer). That way we lost a bunch of messages by the time we noticed the issue...
Is there a way to prevent the drop of the logs in case of such a misconfiguration ? Or even prevent dropping at all, and preserving in buffers all failed attempts ?
Maybe it's a behavior that could be set as a parameter of the plugin ?
Thank you in advance

Hi @ClemArt
Thank you for notify us on this issue.
I checked and it  doesn't make sense to drop the logs.
We will add a log error with the buffer that failed

I just had a similar issue, and I wonder how we can monitor it. We have alert for fluentd_output_status_num_errors but I see it is 0 - although the plugin clearly has errors.
What would you recommend us to do to monitor such issues? There are not a lot of logs so positive monitoring is hard (2 hours without any log is normal)


Physical robot movement stutters a lot. Possible topic pollution

Running a robot movement using moveit commander over a direct ethernet connection produces highly jittery movement at any speed. Its naturally less perceptible at the stock speeds that moveit configured it to run at, but since I actually intend it to run an industrial application over ROS Just need it to run at normal operation speeds. Uncapping the joints_limits.yaml gave me the speed increase, but it revealed just how rough the robot runs.
I suspect its not an actual issue with the driver nor the connection, but the fact that I am also running a simulator in the background which is polluting the joint_state feedback topic causing the trajectory execution to behave sporadically.
See the image below. I have two nodes publishing to the state topic:

This is due to this issue: #88
Since the documentation is rudimentary at best I can't say i haven't missed something, but if anybody has any idea what to do about it, please let me know.

@MrVolans Hello, could you please provide an update on what you were able to discover? We are seeing a similar shuttering in our case, and just like you, we are using the aubo_robot_simulator node, which could potentially pollute topics. Have you found a way to avoid using the simulator node or reduce its impact (e.g. by using topic remapping, etc.)?

I forgot to send the response, sorry for the wait. Yes I tested out remapping the simulator to a dummy topic, this did nothing as far as i can see. Looking at the source code I figured the simulator is needed to dissect the trajectory into waypoints that the driver then executes. I did not manage to bypass the simulator.  I found the stuttering it might be related to Real Time performance of the device running MoveIt, and so tried compiling an RT kernel for my system. This appears to provide minimal improvements, but compared to the desired smooth movement, this is a marginal difference and probably not the root cause. I suspect the control pc might need the same treatment, but without deeper insight into the routing on the control pc side I really can't say I am sure that this is the solution. This was part of my b.eng. thesis, so please do report any findings back, I would be very interested in some insight into a possible solution.

@MrVolans thank you for providing more information. I tried to investigate the potential topic pollution by recording the sources of the messages from the following topics: /joint_states, /feedback_states and /robot_status, since I suspected it of receiving messages from both the aubo_robot_simulator node and aubo_driver . Just in case someone needs to do the same, the  recorder script gist is here.
Nevertheless, the obtained recordings did not show any polluting messages, which is also supported by your attempt to remap the topics.
My next best suggestion was about using Real-Time kernel, that's why I am glad that you shared your experience with that. Right now I have no access to the PC utilized in the testing scenario, but I will try to provide the specs later.
At the same time, I am not 100% sure if I understood your steps: you've compiled RT kernel for your system, but what did you mean by "control PC" ? Do you mean you have a distributed ROS graph, where a low-end unit (Jetson Nano?) is running the driver node and high-end "control PC" is running MoveIt?

By Control PC I am referring to the linux machine in the robot control box, which I checked the kernel on and its just a generic 14.04 kernel, I apologize for the confusion.
No I don't run a distributed ROS system, its all running on an HP desktop pc. I did consider isolating the move_group node to another device to decrease the impact of other processes taking up resources. I didn't get the chance to though.

Could you, please, also provide information on which ROS distro and which MoveIt version you are using? Have you also applied the "MoveIt update" from the UpdateMoveitLib dir (not sure what it does though)?

I am running MoveIt:
Package: ros-noetic-moveit Version: 1.1.13-2focal.20230801.171807 Priority: optional Section: misc Maintainer: Dave Coleman<EMAIL_ADDRESS>Installed-Size: 22.5 kB Depends: ros-noetic-moveit-commander, ros-noetic-moveit-core, ros-noetic-moveit-planners, ros-noetic-moveit-plugins, ros-noetic-moveit-ros, ros-noetic-moveit-setup-assistant
ROS:
Package: ros-noetic-desktop Version: 1.5.0-1focal.20230620.211638 Priority: optional Section: misc Maintainer: Mikael Arguedas<EMAIL_ADDRESS>Installed-Size: 14.3 kB Depends: ros-noetic-angles, ros-noetic-common-tutorials, ros-noetic-geometry-tutorials, ros-noetic-joint-state-publisher-gui, ros-noetic-robot, ros-noetic-ros-tutorials, ros-noetic-roslint, ros-noetic-urdf-tutorial, ros-noetic-visualization-tutorials, ros-noetic-viz
I tried installing the moveit update lib and it broke my install of moveit. The updatelib is also labeled for Kinetic, so I am not using it atm.

I am also having the same issue with just the aubo_driver and aubo_controller. The robot will stutter even at normal looking joint speeds.
I thought the problem had to do with the rib_buffer_size_, which is used in aubo_driver.cpp. It seems like the robot stores a buffer of the joint commands sent through the command robotServiceSetRobotPosData2Canbus. I thought the stuttering had to do with the rib_buffer_size_ dropping to 0 while the robot was running a trajectory. However even after disabling the publishIOMsg thread and reducing the rate of the timerCallback, which seems to help keep the buffer size above 0, I still get stuttering though not as bad.
I have been in contact with some people at Aubo about developing a ServoJ feature similar to that on the Universal Robot. They actually sent a demo ServoJ function that they were already working on but it suffers from the same issue where the TCP/Canbus connection is unreliable and can cause stuttering. I have been trying to work with them for months since around January, but they aren't very responsive and I still haven't been able to get into direct contact with one of their software engineers.
I proposed a solution to them about implementing a version of ServoJ akin to that on the Universal Robot ROS Driver, where you essentially run servoj in a loop locally on the robot and then remotely update the target joint positions for it. This ensures that even with an inconsistent network that servoj can run continuously. See these links here for how it works:
https://forum.universal-robots.com/t/realtime-control/9495/4
https://backend.orbit.dtu.dk/ws/portalfiles/portal/117833332/Universal_Robot_report.pdf
However, they haven't responded to me about this at all.
The reason we need a reliable ServoJ function is because the ROS driver only supports joint trajectory control and it still stutters. With servoj, it can allow us to integrate aubo robot with ros_control, ros hardware interface, and all of the already-made ros controllers (joint trajectory control, force control, compliance control, twist control)
I apologize for going on this tangent but I've been having a really hard time working with Aubo and wanted to share it with others about what I've found so far.

@ian-chuang  thanks for sharing. I agree with your points and share the same experience with AUBO communication. We sell their robots where I work, but still have a hard time getting response on emails.

RT kernel was not an effective way for me in my case,  and aubo_robot_simulator node will not pollute any topic actually, which not pub any msg on joint state topic and you can comment it. I have connect aubo many times, but no effective response to me

I will provide additional information regarding my (unsuccessful) attempts to identify the root cause of stuttering.
TL;DR;
The most accurate assumption at this point is that the problem lies within the waypoint transformation calculation in the aubo_robot_simulator Python script.
Detailed description of experiments:
I have experimented with the following approaches:

Using a real-time kernel and configuring real-time priority and niceness for AUBO/AUBO+MoveIt nodes. The result remained the same: stuttering persisted.
Adjusting values in aubo_driver.cpp and aubo_driver.h by varying in orders of magnitude. Additionally, I explored modifying the number of threads in driver_node.cpp's AsyncSpinner. While not the most scientific approach, given the multitude of constants, it was the most straightforward option. Result: stuttering persisted in any configuration.
Introducing a delay in setRobotJointsByMoveIt() before robotServiceSetRobotPosData2Canbus() to address the assumption that the robot controller might be overwhelmed with a large number of move requests, potentially skipping some waypoints. Result: The execution of movements slowed down (confirming the effectiveness of the delay), but the abrupt robot moves persisted in the same locations.

Despite these tests, it remained unclear whether the issue might be concealed in how the AUBO driver processes the trajectory within its intricate pipelines. Here, I'll briefly describe my understanding of the internal organization of the driver and the relationships between nodes in the AUBO Driver:

aubo_i3_controller/follow_joint_trajectory action recieving commands from MoveIt - commands are processed in joint_trajectory_action.cpp (referred to as aubo_joint_trajectory_action in the ROS-graph), which publishes the joint_path_command topic.
joint_path_command is consumed in aubo_robot_simulator (Python script), where the trajectory undergoes transformation through specific calculations before being published to the moveItController_cmd topic.
moveItController_cmd is consumed in aubo_driver.cpp, which sends the motion command to the robot controller.
(aubo_robot_simulator.cpp is not used at all).

Somewhere in this processing (over-)complexity, there may be a point causing the transformed MoveIt-generated trajectory to become invalid, resulting in stuttering (potentially due to race conditions or invalid computed accelerations/velocities).
To isolate the influence of MoveIt path planning (which inherently involves randomness), I prepared a script script  allowing the recording and replaying of the same Moveit-generated trajectory consistently.
Using this script, I ran and recorded multiple executions of the same trajectory (ROS bags, and videos of robot movement from the Teach Pendant), analyzing joint variables, velocity, and acceleration data from the joint_path_command and moveItController_cmd topics. I then compared this data with the "ethalon" Moveit-generated trajectory.
The attached Excel document illustrates that the aubo_robot_simulator transforms the same trajectory differently each time (refer to moveItController_cmd charts, apologies for the file's less-than-optimal organization and preparation). Moreover, recorded videos show that, although the stuttering takes place in more or less the same locations along the trajectory, it does not occur every time.
The graph also highlights another "issue" - the disparity between the data published by MoveIt and aubo_joint_trajectory_action: when transforming the trajectory from MoveIt inside aubo_joint_trajectory_action, the data for axes 1, 2, and 3 are swapped (yes, the colors of the legend are correct, it is the issue of the data itself). However, from the moveItController_cmd graph, it is evident that the Python script of aubo_robot_simulator accounts for the swapped axis order and corrects them, thus it is not a big issue.
Apologies for the lengthy explanation, but I hope it proves helpful to someone on the "quest for the truth".
If you require any data from the experiments I conducted, please let me know.

good job

@anion0278 Thank you for your work.I also found that the joint_path_command topic they posted was wrong.The correct order of the first three joint angles is 1, 2, 3, but the published order is 3, 1, 2.This has bothered me for a long time.Thank you.

@anion0278 Thank you for your work.I also found that the joint_path_command topic they posted was wrong.The correct order of the first three joint angles is 1, 2, 3, but the published order is 3, 1, 2.This has bothered me for a long time.Thank you.

would you mind point out where code is wrong about your said ?

@anion0278 Thank you for your work.I also found that the joint_path_command topic they posted was wrong.The correct order of the first three joint angles is 1, 2, 3, but the published order is 3, 1, 2.This has bothered me for a long time.Thank you.

would you mind point out where code is wrong about your said ?

Sorry,I didn't look at their code in detail.As @anion0278  said, this problem has been noticed in aubo_robot_simulator, so it does not affect the actual execution effect. If you are like me and just want to use the data published by the joint_path_command topic, just pay attention to changing the order.Thanks.

@Joinjiang if you would like to find a precise location where this swap is occurring, try to investigate the joint order provided in joint_path_command topic (which provides mapping for aubo_robot_simulator and the one provided in corresponding controller definition, for example i5
Snippet from joint_path_command:
...
joint_names:
  - foreArm_joint
  - shoulder_joint
  - upperArm_joint
  - wrist1_joint
  - wrist2_joint
  - wrist3_joint
...

Snippet from controller definition:
    joints:
      - shoulder_joint
      - upperArm_joint
      - foreArm_joint
      - wrist1_joint
      - wrist2_joint
      - wrist3_joint

As you can see the order is swapped exactly as me and @Hunger-beat described.

@Joinjiang if you would like to find a precise location where this swap is occurring, try to investigate the joint order provided in joint_path_command topic (which provides mapping for aubo_robot_simulator and the one provided in corresponding controller definition, for example i5
Snippet from joint_path_command:
...
joint_names:
  - foreArm_joint
  - shoulder_joint
  - upperArm_joint
  - wrist1_joint
  - wrist2_joint
  - wrist3_joint
...

Snippet from controller definition:
    joints:
      - shoulder_joint
      - upperArm_joint
      - foreArm_joint
      - wrist1_joint
      - wrist2_joint
      - wrist3_joint

As you can see the order is swapped exactly as me and @Hunger-beat described.

thank you for your kindly help! i have got it

@Joinjiang if you would like to find a precise location where this swap is occurring, try to investigate the joint order provided in joint_path_command topic (which provides mapping for aubo_robot_simulator and the one provided in corresponding controller definition, for example i5
Snippet from joint_path_command:
...
joint_names:
  - foreArm_joint
  - shoulder_joint
  - upperArm_joint
  - wrist1_joint
  - wrist2_joint
  - wrist3_joint
...

Snippet from controller definition:
    joints:
      - shoulder_joint
      - upperArm_joint
      - foreArm_joint
      - wrist1_joint
      - wrist2_joint
      - wrist3_joint

As you can see the order is swapped exactly as me and @Hunger-beat described.

sorry to bother you！how can i fix the order ?

@Joinjiang if you would like to find a precise location where this swap is occurring, try to investigate the joint order provided in joint_path_command topic (which provides mapping for aubo_robot_simulator and the one provided in corresponding controller definition, for example i5
Snippet from joint_path_command:
...
joint_names:
  - foreArm_joint
  - shoulder_joint
  - upperArm_joint
  - wrist1_joint
  - wrist2_joint
  - wrist3_joint
...

Snippet from controller definition:
    joints:
      - shoulder_joint
      - upperArm_joint
      - foreArm_joint
      - wrist1_joint
      - wrist2_joint
      - wrist3_joint

As you can see the order is swapped exactly as me and @Hunger-beat described.

thank you for your kindly help! i have got it

to my investigation, it seems that the joint name order in actionclient goal message is not corresponding to the order in the controller.yaml, so it has to remap order and it is not aubo package error! if someone has another ideas about solving this problem, please let me konw.

i have got the exact reasons: follow_joint_trajectory/goal organizes the joint data in the alphabetical form.

@Joinjiang however I think the swapped order is not the reason for the observed shuttering (because if it was, then the robot would completely go haywire and neither segment of the trajectory would have been executed properly).

@Joinjiang however I think the swapped order is not the reason for the observed shuttering (because if it was, then the robot would completely go haywire and neither segment of the trajectory would have been executed properly).

yes, may be use the velocity control better than position control in this package


Implement an optional and configurable code path that uses $apply for PlanDefenition execution

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2733
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
[ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@maimoonak I need your help to understand more about that pls review a PR once you have time. Thanks

Very interesting work @owais-vd! We're working on finalising some of the request API design in the workflow library and in my view they can really simplify a lot of the switch/when statements in this PR. I think it would make a lot of sense for this type of logic to be maintained in a separate library and we can maintain that logic against the standard.
@pld @dubdabasoduba fyi


OpenSearch suggestions

OpenSearch suggestions are a way of offering autocomplete suggestions to the browser. In the context of manpages, they'd be very handy for selecting the correct section or package in a single hop, rather than navigating to one of the candidates and then looking at the other sections/conflicting packages boxes.
A strawman of what I would like:
cron -> ["cron", ["cron.8", "cron/crontab.5", "cron/crontab.1", "systemd-cron/crontab.5", "systemd-cron/crontab.1"]]
If possible, some kind of typo-correction would also be useful (e.g., 'corn' should get results for 'cron').
I don't know what to do about exposing different suites or languages without causing a combinatorial explosion and bad UX.

Thanks, that’s a good suggestion. I briefly verified that opensearch suggestions are supported by Firefox and Chrome.
One open question is whether suggestions should match the beginning of the page name only (e.g. dat matches date) or anywhere in the page name (e.g. dat matches updatedb as well).

Side note: both Firefox and Chrome seem to only take the suggestions themselves, they ignore the descriptions and URLs.

I'd suggest only (fuzzy) prefix-matching; that's what Wikipedia, Wiktionary and YouTube do for suggestions and IME it works really well.
One other feature I've realised would be handy (but please feel free to punt if it'd be too annoying): if the input has a package or a section, that should be respected in the suggestions, and the package name should allow partial matches. So, using the crontab example:
cr/cron -> ["cr/cron", ["cron.8", "cron/crontab.5", "cron/crontab.1"]]
cron.5 -> ["cron.5", ["cron/crontab.5", "systemd-cron/crontab.5"]]

Pushed a commit to implement a suggestion endpoint. The change to the opensearch XML file should be live after the next re-run and mirror sync (within a day or so).
In order to keep the endpoint performant, I had to implement prefix-only matching for now. If people want matching within words and can contribute an efficient implementation, pull requests for that would be welcome.


near2far meep grating coupler example

How could we add a near2far grating coupler example to notebooks/gdsfactory/plugins/meep/002_gratings.ipynb  ?
@simbilod

We'd need to define a new simulation where instead of fiber and fiber ports, there is a near2far monitor. We`d then need define a new analysis function that parses the near2far instead of the S-params.
It`s not so bad, this is how I had it setup originally, so I have some code lying around. It was mostly based on the Simpetus example.

We moved plugins development to it to https://github.com/gdsfactory/gplugins


⚠ Bofrost.at has degraded performance

In 7e5e142, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1041 ms

Resolved: Bofrost.at performance has improved in 12a5990 after 7 minutes.


Theme palette action selected color is not working in MUI version 5

When creating a custom theme, the palette.action.select color property is not working.  The other action color properties are working great.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
The select color on a dropdown select component is not working.

The default theme color is used instead.
Expected Behavior 🤔
The color on a selected dropdown menu item should be set.

Steps to Reproduce 🕹
See this code sample:
https://codesandbox.io/s/palette-select-demo2-6ql8p?file=/src/Demo.tsx
import * as React from "react";
import { Box,InputLabel, MenuItem, FormControl, Select } from "@material-ui/core";
import { createTheme, ThemeProvider } from "@mui/material/styles";
import { red } from "@mui/material/colors";

const theme = createTheme({
  palette: {
    action: {
      select: red[500],
    },
  },
});

export default function Demo() {
  const [age, setAge] = React.useState('');

  const handleChange = (event) => {
    setAge(event.target.value);
  };

  return (
    <ThemeProvider theme={theme}>
      <Box sx={{ minWidth: 120 }}>
      <FormControl fullWidth>
        <InputLabel id="demo-simple-select-label">Age</InputLabel>
        <Select
          labelId="demo-simple-select-label"
          id="demo-simple-select"
          value={age}
          label="Age"
          onChange={handleChange}
        >
          <MenuItem value={10}>Ten</MenuItem>
          <MenuItem value={20}>Twenty</MenuItem>
          <MenuItem value={30}>Thirty</MenuItem>
        </Select>
      </FormControl>
    </Box>
    </ThemeProvider>
  );
}

Your Environment 🌎
Edge and Chrome browsers on Windows 10.

Thanks for the report. The action is called selected not select. From what I can see the MenuItem uses the primary color with the selectedOpacity this is why it is not set. You would need to change either the primary color if that makes sense for your app, or apply an override for this specific component.

@bbarnell we are following the recommendation from MD autonomy (using the primary color with a bit of opacity for the selected state), see https://github.com/mui-org/material-ui/issues/5186#issuecomment-576632332

This is clearly a regression. MUI should be usable for design systems other than material, including ones that use secondary colors on list items.
At a minimum, it's obviously wrong that there's an item that can be specfied (selected) that changes nothing at all about the appearance of the theme.

This is clearly a regression. MUI should be usable for design systems other than material, including ones that use secondary colors on list items.

You would need to do a style override if you want to use secondary colors on list items, but I would say this is less common than using the primary colors, this is why the primary color is the default behavior.

At a minimum, it's obviously wrong that there's an item that can be specfied (selected) that changes nothing at all about the appearance of the theme.

The change was done in order to bring consistency between the states styles across different components, in my opinion this changes was going in the right direction, see https://github.com/mui/material-ui/pull/21930 The theme.palette.action.selected is still used in some places, but the theme.palette.action.selectedOpacity is used much more together with the primary color. Again, you are free to add overrides to fit your design system requirements.

I am trying to adjust theme.palette.action.selectedOpacity and theme.palette.action.hoverOpacity but it seems hit or miss... For example, it affects Buttons with variant secondary but not primary? It also seems to have different effects if I set the primary color in main versus light or dark.


white/light favicon causes invisible buttonbar

The buttonbar in recent releases changes colour based on site's icon, which looks very nice in general.
However, when the icon's colours are white or light, the white icons become invisible.
try for instance:
https://www.bellingcat.com

Yup, I have noticed it too. Thanks for reporting.

A suggestion if to add a border around the icon to fix the seam.

@trymeouteh it also affects the system bar on the top. Guess it would be better to avoid certain colour ranges perhaps.


Provide population allele frequencies for variant on MT genes

It looks like gnomAD doesn't have allele frequencies for variants in mitochondrial genes. Look into annotating from Allele Freq Aggregator ALPHA.

From Ralph R.
...it looks like the gnomAD data is missing, it's not a rare variant (12% of the population in gnomAD) but is shown with gnom AD 0.00 values and no link although the data is available here:
https://gnomad.broadinstitute.org/variant/M-13708-G-A?dataset=gnomad_r4
mitochondrial data is just not available on gnomAD for older versions, but gnomAD 4.1 lists it.
there's also a ClinVar entry for it that doesn't show up in gene iobio:
https://www.ncbi.nlm.nih.gov/clinvar/variation/9696/


文件资源莒理器加载项功能下的源代码文件 和Portable Docu ment Format功能在win10下预览会报错并显示正在加载...，而win11则不会。

Microsoft PowerToys version
任意版本
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
File Explorer: Preview Pane, File Explorer: Thumbnail preview
Steps to reproduce

✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Not able to repro this, going to close. Let us know if you see this again!


documentation: Update Readmes instructions.

The documentation in the repository README about exercise README.md files is out of date:
https://github.com/exercism/ruby#readmes
to do:
Update the Ruby repository README with the information that:
All exercises should have a README.md file.
This file should be generated using the configlet tool.
Probably some command line examples on how to do this.

bin/fetch-configlet Will fetch the configlet appropriate for your system.
bin/configlet generate . --only rotational-cipher Will generate the readme for a particular exercise. rotational-cipher in this case.


Component Types

Would it be possible to create a Dynamic component type that allows for a query input and a plain text, or html output can can be customized to display the query results?
example:
Component to display the number of currently active sessions.
Currently the only way to achieve this is to put it out to a table.

Yes, the single value/metric/kpi component is on the roadmap for v0.8.0 release.

v0.8.0 is released and please try out the Card component.


reset cwd right before relaunch

fixes #46751
The issue is present for any time we relaunch a code instance started with a relative path parameter

Not sure if this is for March or April, up to you @sbatten


homepage cannot be found

iMac-TMP:~ joe$ curl -I https://termsha.re
curl: (6) Could not resolve host: termsha.re

@progrium gentle ping on this.

Is this project dead?


[C] How about introducing naming rule for entrypoint name?

Now, driver implementers can use any name for entrypoint function. How about introducing a naming rule for entrypoint function such as AdbcDriverInit() or ${driver_name}_init()? If we have a naming rule, users don't need to entrypoint option.
We may not be able to use constant name such as AdbcDriverInit() because LoadLibraryEx() doesn't have a local bind flag like RTLD_LOCAL for dlopen().

We may not be able to use constant name such as AdbcDriverInit() because LoadLibraryEx() doesn't have a local bind flag like RTLD_LOCAL for dlopen().

I was slightly concerned about this on Windows, hence I didn't specify a name. But AFAIK, on Windows, LoadLibrary calls do not conflict with each other, right?

But AFAIK, on Windows, LoadLibrary calls do not conflict with each other, right?

I think so indeed.

Oh, sorry. I didn't confirm it.
Then, how about using constant name for entrypoint function?

Sounds good to me. Thanks for pointing this out. I'll put up a PR soon.

See #93.


Default file_cache_path with local-mode may break things and do not honor documentation

Hi,
I've just found a misbehaving ark resource due to the default relative path set as file_cache_path:
./local-mode-cache/cache

Also, the documentation wrongly states:
When running the chef-client using the --local-mode option, ~/.chef/local-mode-cache is the default value for cache_path.

that looks a good path, anyway.
I was running with user root on ~:
chef-client -z -c client.rb

A workaround is to configure file_cache_path in client.rb, e.g.:
data_bag_path "/tmp/chef/data_bags"
environment_path "/tmp/chef/environments"
cookbook_path "/tmp/chef/cookbooks"
file_cache_path "/tmp/chef/cache"
ssl_verify_mode :verify_peer

I made a quick dig into it, and chef relies on File.dirname passing the configuration file as passed on the command-line, so I am getting a relative cache path since I passed a relative path for the configuration file.
It may be a good idea to always return an absolute path?

think this is a dup of another issue as well, but offhand i couldn't find it.

Fixed #2875 via #9042


fix: prevent screen flashes on payments page (bank account)

Details

This PR prevents flashing blank page before opening the plaid login flow.
Fixed Issues

$ https://github.com/Expensify/App/issues/15309
PROPOSAL: https://github.com/Expensify/App/issues/15309#issuecomment-1459797338
Tests

Goto Settings -> Payments
Click on "Add payment method"
Select "Bank account"
Verify that it does not flash blank screen. It should open plaid flow in one go.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Goto Settings -> Payments
Click on "Add payment method"
Select "Bank account"
Verify that it does not flash blank screen. It should open plaid flow in one go.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/77761491/223843944-3336532e-eab3-4183-9f3a-285c8501fc07.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/77761491/223843786-6a8264f3-e9af-476d-af2a-13bb6bc7d014.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/77761491/223843483-3ea1486f-0738-4ebb-a68c-760d9cd02c9e.mov

Desktop

https://user-images.githubusercontent.com/77761491/223843227-6b6b0807-a7ee-4b28-874c-6ccc42551dfe.mov

iOS

https://user-images.githubusercontent.com/77761491/223843136-3b213db7-f548-4618-afb8-5e039b29f009.mov

Android

https://user-images.githubusercontent.com/77761491/223846698-43fc2ca4-7630-409f-81cb-78f48aafd180.mov

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3069065/223938913-a7113579-fb99-4c71-a5bc-0f42dea66602.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/3069065/223938951-b6e3b300-d1da-473a-a3b1-7071caf9044f.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/3069065/223938993-20d6a1e2-d708-44d3-910c-9fac620e7a83.mov

Desktop
https://user-images.githubusercontent.com/3069065/223939018-3652f315-7a89-47de-93bd-441360d07fd0.mov

iOS
https://user-images.githubusercontent.com/3069065/223939074-934e7513-3f83-4b82-818a-d31377c35362.mov

Android
https://user-images.githubusercontent.com/3069065/223939114-83f7cb54-acfe-47a7-9bba-9ed9392148ae.mov

Thanks for the quick PR @mdneyazahmad. This tests well. @johnmlee101 I'd like to highlight while our contributing guidelines state that we don't use React hooks, the current component already uses hooks and I think we're good to use useState here.

@mdneyazahmad You need to complete the checklist. Please mark the items that don't apply, to ensure you've read them.

Thanks @mdneyazahmad. @johnmlee101 All yours.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.2.82-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.82-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Open Browsers Profiles] Open existing browser page if already opened

Extension
https://www.raycast.com/skydiver/browsers-profiles
Description
I use raycast most of the times as a window switcher/window navigator.
It would be nice if this extension would feature an option ofjust going to the current opened window of that specific profile if it exists
Who will benefit from this feature?
People who use raycast as an app switcher
Anything else?
No response

Hi @dagadbm
As most of the browsers in the list supported by this action are based on Chromium, in order to shed some light on the issue and perhaps discover a solution through crowdsourcing, please refer to this comment

I see. I had a feeling it might be a problem on the browser side...
I guess you could file a ticket to them and eventually this would work out of the box no?
Eventually making that ticket available somewhere on the Readme of this extension people would probably go to that ticket and do a thumbs up.
Better than nothing I guess.
But it's up to you I'm ok just understanding the issue.


Implement cargo project templates

Project templates allow users to define custom templates which can be
used to scaffold projects. These templates consists of a directory of
files, each of which will be treated as a mustache template.
Example:
cargo new myproject --template=http://github.com/someone/nickel-template

This would download the template called 'nickel-template' to
~/.cargo/templates/nickel-template. Each file in that directory would
then be compiled and rendered to the new project directory created by
cargo. Once the template is downloaded, future uses can just reference
it by name:
cargo new webapp --template nickel-template

Certain files will be ignored in template directories. These are namely
files which mustache will not be able to compile. Image files, for
example are all ignored.
Closes issue #396

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

Also to note, this converts the standard lib & bin templates to mustache templates. This means that passing cargo new foo --bin is the same as cargo new foo --template bin and cargo new foo is the same as cargo new foo --template lib.

It's also a bit rough around the edges. Let me know where you think I can improve it!

Whoa, nice! I'm quite excited to see some progress on this front :) Some thoughts of mine:

I do agree that with adding templates we'll probably need some form of templating language, but I haven't looked into mustache yet and would just want to take the step lightly to "blessing" the template format for Cargo. It's likely that it may leak out into other parts of Cargo once we add support.
Templates coming through various different protocols probably want to be specified as such. It's somewhat ambiguous how to download an http template because it could be a tarball, SVN, git, etc. I think the syntax for fetching a template remotely will just want to indicate what protocol should be used as well.
It looks like no tests have been added, but I'd like to have extensive testing for this feature.
How does one update a template? For example if a git or http template updates over time, it's not automatically picked up with cargo new --template name.

I think it'd also be worth looking into other package managers to see what they do here. For example how does this compare to bundler's template integration (or is it Rails that has templates over there?).
Also cc @wycats, I'm sure you'll have many opinions on this!

Also cc @rust-lang/tools, you'll probably all in general be interested in this.

@alexcrichton thanks for the comments!
I figured this would spark some discussion, but wanted to get an initial draft done to kickstart it.

I figured the use of mustache would be questioned. Would you prefer I change (for now) to use something else? Perhaps just a regex solution?
I'm working on getting tests together at the moment, I will update here when I have them. Hopefully this afternoon / evening.
re updating, I'm not sure. I could change it so that if you specify a remote template which has already been downloaded, that the existing copy would be deleted, and re-downloaded? Or I could look at adding a cargo template command for managing templates? cargo template download <url> or cargo template update <name>. Let me know what you think is the best approach here.

I know that Django has support for project templates, but I'll check out a few similar solutions and see how they approach it. I'll update this PR as I go. Looking forward to more feedback!

I chatted with @wycats on IRC and he mentioned that handlebars may be more appropriate as a templating language (I'm personally unfamiliar with both), but I just want to make sure that we consider other possibilities.
I'm also not 100% sure about what to do on the update front, so I'm curious what other projects do in this regard. To match cargo's existing behavior then cargo new --template foo will update foo if it's a remote template every time the cargo new command is run, but that's probably a little too surprising.

I'm obviously biased about Handlebars, but it's basically 98% compatible with Mustache but also supports helpers exposed by the host language. In contrast, Mustache supports loops and conditionals.

:umbrella: The latest upstream changes (presumably #1748) made this pull request unmergeable. Please resolve the merge conflicts.

Having the template download/update commands be separate from the project initialization command makes more sense to me. It feels weird to first specify a URL with --template and then change that to a name. The download/update commands could themselves be the same command, maybe just cargo template get?

Sorry for the delay on updating this, working on tests at the moment, then switching over the handlebars per the comments from @wycats. Hopefully get that part done in the next few days!
Another possibility for managing templates would be to just not store them at all. Just download the one you want, scaffold the project, then remove the template. Next time you want it, repeat the process. Just s thought...

So, just did some digging into how the django-admin.py script handles this, which is where I got the idea from in the first place.
It downloads templates to a temporary directory, which will get removed after use. You can also point it at a local folder, which obviously won't download anything. This is a better approach I think. It means that templates won't go out of date, because you need to re-download them every time you want them. If you find yourself re-using a template multiple times then you can download it yourself and point cargo at that each time instead. This changes the responsibility for managing the templates to the user, rather than cargo itself.
What do you think of that approach?

Sounds like a good idea to me!

Closing due to inactivity, but feel free to reopen with a rebase and comments addressed!

This was closed due to inactivity. It's almost a year old so I expect rebasing is not an option. Are there any other options for resurrecting it? It's a really useful project!

Yeah unfortunately this'll need to go through a rebase or start from scratch.


Restore max limit on listing

Allow a bucket listing to return a max keys number
greater than actual keys returned to mirror AWS.

@ironman-machine check it

Hello @LaurenSpiegel
Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "SCALITY_S3_BRANCH": "fix/listingLimit", "DEFAULT_BRANCH": "rel/6.3"}
Please follow http://ci.ironmann.io/gh/scality/Integration/7473 for CI status.


[WFLY-16591] Remove the org.jboss.resteasy.jose-jwt module

https://issues.redhat.com/browse/WFLY-16591
Signed-off-by: James R. Perkins<EMAIL_ADDRESS>

@ronsigal can you please give this a quick review so we can get it in for James?

I converted this to a draft for now until we have a decision. It is being discussed and the current idea is we might remove org.jboss.resteasy.jose-jwt, but keep org.jboss.resteasy.resteasty-rxjava2.

Hey Darren,
Sorry for the late reply - I was on PTO on Friday. Yes, I'll take a look.
-Ron

Well, I don't know much about RESTEasy's jose-jwt, but I was involved in the creation of resteasy-rxjava2, and I would be surprised if it were used somewhere in WildFly. It looks like those two got into common-microprofile/pom.xml in https://github.com/wildfly/wildfly/commit/c4d4f89661f95d1506c86faa0ad66ca7b0c22258. James, do you remember where the dependencies there came from?

Well, I don't know much about RESTEasy's jose-jwt, but I was involved in the creation of resteasy-rxjava2, and I would be surprised if it were used somewhere in WildFly. It looks like those two got into common-microprofile/pom.xml in c4d4f89. James, do you remember where the dependencies there came from?

@ronsigal It looks like resteasy-rxjava2 came in via https://github.com/wildfly/wildfly/pull/11378. The referenced commit is just where we upgraded WildFly Preview to RESTEasy 6.0.
Talking in chat with @asoldano, it sounds like we should likely keep org.jboss.resteasy.resteasy-rxjava2 as is for now, but org.jboss.resteasy.jose-jwt is likely okay to be removed.

Thanks, @jamezp. I have no objections.

Hey @darranl, +1 for this. If you need an official review, just add me as a reviewer and I'll push the button.

@ronsigal FYI, you don't need to be added as a reviewer to use the github UI to approve a PR.

@jamezp Needs a rebase

Hello, jamezp. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

/ok-to-test

Thanks @jamezp


Tree transform to dict

What is your question?
I am trying with some code to transform but im finding difficult to transform the tree to a dict
import json
from lark import Lark, Transformer, v_args, Tree

grammar = r'''start: instruction

?instruction: filters_function

property: "property-insensitive"        -> property_insensitive
        | "property"                    -> property
property_date: "age"                    -> age_filter
             | "date"                   -> date_filter

// To run over special characters
TEXT: (LETTER+) (LETTER+|DIGIT+|"-"|"_")*
FILTER: TEXT
SPECIAL_VALUE: "${" (LETTER+) (LETTER+|DIGIT+|"-"|"_") "}" *
WILD_CARD: "%" TEXT | TEXT | NUMBER
VALUE: WILD_CARD|SPECIAL_VALUE|TEXT

ARGSEP: ":" // argument separator

STAR: "*"
filters_function: FILTER (property | property_date) VALUE *

// find the whitespace so we can ignore
WHITESPACE: (" " | "\n")+

%ignore WHITESPACE
%import common.LETTER
%import common.WORD
%import common.DIGIT
%import common.INT -> NUMBER
%ignore ARGSEP
%ignore " "
'''

parser = Lark(grammar, parser='earley') # lalr
print(parser.parse("filter:property-insensitive:Surname:%Name"))
print(parser.parse("filter:property-insensitive:Sex:M:F:U"))
print(parser.parse("filter:age:on:${today}:Equal:26:years"))
print(parser.parse("filter:date:Equal:${today}"))
print(parser.parse("filter:property:Type:regular:temp"))
print(parser.parse("filter:property:Status:active:deducted:deceased"))
print(parser.parse("filter:date:LessThanOrEqual:YMD-2020-04-15:plus:1:days"))
print(parser.parse("filter:date:LessThanOrEqual:YMD-2020-04-15:plus:1:months"))

final = parser.parse("filter:property-insensitive:Sex:M:F:U")

class TreeTransformer(Transformer):
    out = []

    def start(self, content):
        #out = []
        for token in content:
            if isinstance(token, str):
                print('string')

    def filters_function(self, content):
        for token in content:
            print(token)
        return content

    def property_insensitive(self, content):
        return 'property_insensitive'

    def FILTER(self,content):
        return content

    def property(self, args):
        return 'property'

transformer = TreeTransformer()
print(transformer.transform(final))

What i'm trying with the above parser:

The second value of the string always define the next action filter:property: so im trying to add those as the parent of the dict property. Basically im trying to transform the value to return as below.

{ "property-insensitive": ["Sex", "M", "F", "U"]}

{ "property": ["Type", "regular", "temp"]}

{"date": ["LessThanOrEqual", "YMD-2020-04-15", "plus", "1", "days"]}

for me the property_insensitive tree is always [] empty, im trying to get the same value of property_insensitive or the rest of the value followed after the first two string separated by :

Note: Im a new starter so the code will look bad :( It would also be nice to get a link for the documents of Transform.

Why are you trying to use lark? This looks like a perfect use case for the the python string .split() function.
The documentation for Transformer is linked from the README.md one read-the-docs.

@MegaIng Yes your correct, our existing solutions are written with split, but we end up with lot of conditional statements, as you can see the filters are vary.. there are of 100+ and we dont want to add conditions for all, so we checked for a parser, and gone through antlr and its not that effective and lark is good so we kind of trying out.

@aravindkumaremis There's a lot to do here, and I think you should just read more of Lark's example to get a feel of how it works best.
For example, by using ignore ":", you're saying that Sex:::M::F::::U is valid syntax
It's better if you make it explicit, imho
And in general, you should make sure that rules contain the same elements that you would want in the AST, in the same orders.
Look at tree-shaping operators to see what's what (?, ! etc.)
In general read this top-to-bottom before proceeding: https://lark-parser.readthedocs.io/en/latest/grammar/

Thanks for the Help.


Upgrade grav 1.7.30 and 1.7.29 servr error 500

Hi, I’ve an issue during the grav upgrade form version 1.7.25 to version 1.7.30
aftrer the upgrade I receive server error 500.
I’ve done many test and the issue start with versione 1.7.29. I mean until version 1.7.28 all works well but with version 1.7.29 I receive error 500 from server.
The test was done with Open Publishing Space skeleton.
I’ve check error 500 and no problem with .htaccess
Checking the change log from version 1.7.29  I can see:
Added unicode-safe Utils::basename() and Utils::pathinfo() methods
Improved Filesystem::basename() and Filesystem::pathinfo() to be unicode-safe
Made path handling unicode-safe, use new Utils::basename() and Utils::pathinfo() everywhere
If I look in the logs directory I can see grav.log file (see attachment)
In order to solve the issue I've changed
system\src\Grav\Common\Assets.php  file on line 201
from:
$extension = Utils::pathinfo(parse_url($asset, PHP_URL_PATH), PATHINFO_EXTENSION);
to
$extension = pathinfo(parse_url($asset, PHP_URL_PATH), PATHINFO_EXTENSION);
I've removed Utils::
error.txt
I didn't understand if this is a bug or problem related to my environment
regards

I found the issue:
In the config file user\config\system.yaml
I0ve the following config:
assets:
js_module_pipeline_before_excludes: true
js_minify: true
enable_asset_timestamp: false
enable_asset_sri: false
collections:
jquery :
- 'system://assets/jquery/jquery-2.x.min.js'
- 'user://sweetalert2.all.min.js'
- 'user://jquery.cookiebar.js'
with this config the  Utils::pathinfo return "NULL" that is not accepetd. I need to keep all 3 js. Any suggestion

@NandoPiz I made the methods less strict, but the issue is that some of the files doesn't exist, which causes the method to return false.

@NandoPiz, Please feedback this solution into your Discourse issue and mark that reply as 'solution'.


Week view column headers

On the demo sample the week and 4-day views have a problem with the column headers not lining up properly when the main body has a vertical scroll-bar. Has this been fixed in the released code?

Yes, the fix went out with the last release. I haven't updated the example yet, thank you for noticing.

No problem. It's a great component!


Allow non-root deployment

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
Currently we're trying to install Istio in a managed on premises Kubernetes cluster. Therein it's not allowed to run containers as root user. Thus several Istio components cannot be deployed correctly.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Being able to install Istio in an environment where containers cannot run as root user
Steps to reproduce the bug
Apply Helm chart in an environment where containers cannot run as root user
Version (include the output of istioctl version --remote and kubectl version)
Istio v1.2.3
How was Istio installed?
Helm chart
Environment where bug was observed (cloud vendor, OS, etc)
Managed on premises Kubernetes cluster (Kubernetes 1.14 on CoreOS)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Thanks for the issue. This is being actively worked on right now (multiple PRs merged in last week) and should be ready very soon. I am going to close this as it is being tracked in https://github.com/istio/istio/issues/10768


help with o365

This may seems stupid
buth the only thing i get from my calendars entitys is false /true
how do i actually get "data" from the calendar into the lovelace?

learned hiw to proplrly work with the app this can be closed


Rename schema

Pull request details
Describe the changes made in this pull request
Update the name of the schema
List of related issues or pull requests
Closes #734
Collaboration confirmation
As a contributor I confirm

[x] I read and followed the instructions in README.dev.md
[x] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[ ] Tests are passing
[ ] Lint is passing

Close this PR in favor of #737


关于文本特征

It is really a very original and amazing work! I have a few questions to consult. How to you transoform the 768 / 1024 dimension BERT embedding to 128 dimension embedding for original node embedding? Thanks for your replying. Happy Christmas!

Merry Christmas! We use this version: https://huggingface.co/google/bert_uncased_L-2_H-128_A-2.


A question about Training and Testing

Thanks for your great job!
I have a question about how to use this repo to do training and testing. Are these all same with the original graspnet?
Looking forward to your early reply! Thank you very much!

This repository just uploaded the pytorch version.


unixODBCDrivers.msodbcsql18: init at <IP_ADDRESS>

Description of changes
This is the ODBC Driver 18 for SQL Server, which now supports arm64 (and therefore modern Mac hardware). Download links were acquired from the Linux and macOS installation pages.
I used the Debian packages, as that's what the msodbcsql17 package uses.
I have verified these build appropriately. I haven't tested them thoroughly in nixpkgs, but I have tested them at length as part of hasura/graphql-engine. The contents are copied from nix/msodbcsql18-linux.nix and nix/msodbcsql18-darwin.nix.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Anything I can do to help get this done?
I have a rust project at work that uses odbc-api to connect to mssql. I recently updated the flake.nix for that project which follows unstable nixpkgs, and I'm getting this message:

OpenSSL 1.1 is reaching its end of life on 2023/09/11 and cannot be supported through the NixOS 23.05 release cycle. https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL/

Note that ODBC Driver 17 for SQL Server depends on OpenSSL 1.0 or 1.1:

[Microsoft][ODBC Driver 17 for SQL Server]SSL Provider: [OpenSSL library could not be loaded, make sure OpenSSL 1.0 or 1.1 is installed]

The temp work around is simple enough:
nixpkgs.config.permittedInsecurePackages = [
  "openssl-1.1.1t"
];

I'm guessing msodbcsql18 is the way forward.

I'm not sure, but I think reviewing the PR according to the reviewing contributions documentation would help.
I'm happy to get this PR up to date with the latest minor version (assuming one's been published since I opened it) and fix the merge conflict if it looks like there's good odds on merging it.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-in-distress/3604/72

Also there is a merge conflict now.

@doronbehar, I can think of a few ways to remove the duplication. What would you prefer?

Add a if isDarwin then … else … block for each attribute. There are 5 attributes that would need this. (FWIW I started doing this and it seems to result in more duplication.)
Pull out two functions that each takes the common data and then adds OS-specific attributes, then call the correct one.
Keep the variants separate but move them to top-level attributes (e.g. msodbcsql18Linux) and then just alias the correct one to msodbcsql18.

There might be a better way that I am not aware of.

Oh and next time, when you fix a merge conflict, git rebase master, and don't merge master to your branch.

Result of nixpkgs-review pr 197607 run on x86_64-linux 1

1 package built:

unixODBCDrivers.msodbcsql18

I have no idea what is the purpose of this package, but it seems to evaluate and build fine. I will merge after the comment near the passthru is finished, and optionally the indentation / coding style is fixed.

This almost ready @SamirTalwar, one last thing: Rewrite please the Git History as follows:
maintainers: add SamirTalwar
unixODBCDrivers.msodbcsql18: init at <IP_ADDRESS>
unixODBCDrivers: Document `fancyName` and `driver`

History rewritten! Thanks, @doronbehar.

Thanks for merging this!
I will probably submit a PR to update the version at some point, but I'll have to test it out at work first.

@SamirTalwar hope I'm not too unfairly hijacking this PR.
I've installed unixODBCDrivers.msodbcsql18 and php80Extensions.pdo_sqlsrv. However, when attempting to make a connection to the SQL Server I receive:
This extension requires the Microsoft ODBC Driver for SQL Server to communicate with SQL Server.
Access the following URL to download the ODBC Driver for SQL Server for x64: https://go.microsoft.com/fwlink/?LinkId=163712

Is it possible msodbcsql18 is not being properly registered in obdcinst.ini after install?
I'm extremely new to the Nix world, but it looks like there is a mechanism intended for unixODBCDrivers to be registered in odbcinst.ini?

@jrseliga I used to do this in a flake.nix to get around the issue. The versions below will have to be updated.
shellHook = ''
  # see https://www.systutorials.com/docs/linux/man/7-unixODBC/
  # Overloads path to unixODBC configuration files. By default equals to '/etc'.
  export ODBCSYSINI=$(realpath ./)

  echo "[ODBC Driver 17 for SQL Server]" > ./odbcinst.ini
  echo "Description = ODBC Driver 17 for SQL Server" >> ./odbcinst.ini
  echo "Driver = ${pkgs.unixODBCDrivers.msodbcsql17}/lib/libmsodbcsql-17.7.so.1.1" >> ./odbcinst.ini
'';

FWIW, the OSBCSYSINI environment variable had mixed results when we tried it. It worked on some machines but not others.
We ended up building the path into the executable.


[BUG] - Cannot Add Draft Buttons to Model

Describe the bug
Following the README after I install and create the migration for my model I'm not able to add the buttons to the model to manage drafts. When trying to add the field DraftButton::make('Draft'), to my fields it throws the following error: Class 'App\Nova\DraftButton' not found
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Code Snippet
<?php
...
use OptimistDigital\NovaDrafts;

class Post extends Resource
{
    ...
    public function fields(Request $request)
    {
        return [
            ID::make()->sortable(),
            Text::make('Title')->sortable(),
            ...

            DraftButton::make('Draft'),
            UnpublishButton::make('Unpublish'),
            PublishedField::make('State', 'published'),

        ];
    }
}

Environment(please complete the following information):

PHP version: 7.4.6
Laravel Nova Version 3.6.0
Version 7

It seems that the fields are only available by making this change to the fields:
\OptimistDigital\NovaDrafts\UnpublishButton::make('Unpublish'),
\OptimistDigital\NovaDrafts\DraftButton::make('Draft'),
\OptimistDigital\NovaDrafts\PublishedField::make('State', 'published'),

The Use statement use OptimistDigital\NovaDrafts; doesn't reference anything to let Nova know where the Class NovaDrafts is, so you just need to reference the fields directly to make it work.

Sorry for the late response.
I have fixed the README mistake.
Thank you reporting this issue.


Remove segwit txs

Coverage remained the same at 30.618% when pulling 2aecbad08605c70c12576a012c0769b8ac994619 on remove_segwit_txs into 24a870ec657a14c57bd6291ca353c4ac181f4f69 on master.