Fixed NPE in S7PlcConnection#close.

Fix for the NPE in S7PlcConnection's close method.
After fixing the NPE there was a netty blockingException, thus I had to refactor the program logic a bit.
Please check if this is suitable the way I dit this (I tried to add enough comment to make it understandable).

I incorporated fixes for all comments and tried to fix the failing IT (how can i run them locally?).
As the close in the IT throws a NPE I decided not to change the close method but to add try-catch to the IT as this is due to the ITs setup.

@chrisdutz your fixes in the master made it work for me also.
As I found a solution to avoid the blocking exception in the meanwhile I combined your code with mine.
I think the only obvious solution is, as i propose, to use a CountDownLatch to communicate between the ChannelCloseFuture and the close method on another ThreadPool than the EventLoopGroup (which netty forbids).
Is this solution feasible for you?

one note at this point. As far as I understand netty throws this exception to indicate that it dislikes when the thread gets blocked. By using @chrisdutz or @JulianFeinauer code we might just trick the detection of netty. Im not quite sure but I think this is then more a hack/workaround rather then the intended use of netty. What I found what should come close to the intended behavior ist this. Maybe we should ask on the netty list how it is expected to do such things...

@sruehl my understanding is that netty avoids a scenario where one uses the event loop executors threads for blocking and thus, risks a deadlock. This should not be the case in this situation because the EventLoops Thread wich does the listener notification only counts down the latch.
But as this solution seems uglier than it should be it is possibly a good idea to go over to the netty list and ask there (I am totally new to netty).

Well I Ave started working on an option that works exactly the same way we are doing the connection, by creating a CompletableFuture and commuting this in a channel.closeListener ... Will finish that option tomorrow and have a look at your proposal tomorrow as well. Think we are all learning more and more with stuff like this ;-)

Ok ... so I just checked in the version I was talking about. It is basically structurally equal to the way we are doing things in the connection part. Also I just had a look at your change ... seems we are doing the same thing, but I would like to stick to CompletableFutures as your option is just doing the same but with a different syntax.

And I don't agree with Sebastians assumption. Even if it might be the same thread when running in unit-tests (Here we have to write the response to a request manually ans therefore no thread pool can be used), still I don't think that this pattern is invalid. I have seen it when connecting in other code (I didn't invent that pattern). Blocking inside the protocol handler indeed would be bad, but in this case we have to block somewhere, if we want to shut-down gracefully. Another option would be to return the closable future and to wait for that to finish outside of PLC4X, but that would make things needlessly more complex for our users - I think.

@chrisdutz I guess due to my partial scala background I totally ignore Javas Completable futures as superior and thus didnt think about using them : D
But I agree that it shows the intention of the code clearer.
Perhaps we add a Util Class that "converts" a Netty Future into a Completable Future, as we surely need this functionality more often. What do you think?

I think there is no need to really convert between the two and their existence is more historically. Netty preceeds the existence of the Java 8 CompletableFuture by far and by not using them, they have no problems running Netty applications on Java 7 VMs.
Would it be ok for you to close and drop this PR?

Of course I can drop the PR (I think the discussion was more viable than these 3 lines of code).
And the Plans than that you add the functionality or how do we "enble" this "wait for the plc to close connection" feature?

Well we don't have to enable anything ... it's now on per default.
I am using the CompletableFuture for detecting the close and if this doesn't come within the given timeframe, we do it ourselves. This exactly how the Spec expects us to do it :-)

Okay, perfect, than I'm fine.


fix nil-ptr-deref caused by overwriting reconnectingConn.conn with nil

Plenty of places are accessing reconnectingConn.conn directly, without copying it first and doing a nil check on it. A failing reconnect attempt is currently setting the .conn pointer to nil, making all these direct access call-sites panic from the nil pointer de-reference.
This PR is storing the new .conn value locally and only overwriting reconnectingConn.conn on the happy path.

Thanks for this @das7pad


URI for the package repo for RHEL/Centos/Oracle 7.2-7.9 & Amazon Linux 2 not showing

The URI for the package repo for RHEL/Centos/Oracle 7.2-7.9 & Amazon Linux 2 not showing. It shows
</azure/cognitive-services/speech-service/how-to-configure-rhel-centos-7>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bab0b894-0199-7515-b060-a6724e2c9b9e
Version Independent ID: 988ff83c-c4b5-d2f3-023e-2d8dd191b7ae
Content: Deploy Microsoft Defender for Endpoint on Linux manually
Content Source: microsoft-365/security/defender-endpoint/linux-install-manually.md
Product: m365-security
Technology: mde
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@ruicovelo Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8990
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @ruicovelo Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Issue #192 - User Story 3.8

Issue #192
This PR introduces the ability to upload Excel file which has organization’s warehouse locations Code and Description. On the Manage Organizations page, if there are more than 1 addresses then GLOBAL is shown, otherwise one Location Code and Location Description is shown.

Codecov Report

Merging #254 (8822047) into master (8f2f4a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   86.77%   86.78%
=======================================
  Files          37       37
  Lines        1535     1536    +1
=======================================
+ Hits         1332     1333    +1
  Misses        203      203

Impacted Files
Coverage Δ

server/organization/migrations/0001_initial.py
100.00% <100.00%> (ø)

server/organization/models.py
93.33% <100.00%> (ø)

server/organization/tests.py
100.00% <100.00%> (ø)

server/user_account/tests.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2f4a7...8822047. Read the comment docs.

I am running the new code and tried loading in the Dummy data excel file. I get all the item fields parsed into the location input field.

Ajay, provided us with the Dummy data excel file for different component of this system. For this User Story we are concerned only with the 2nd worksheet which he labeled it as: Location Master. In order to test the functionality, please remove the other 2 worksheet. They will only be uploading 1 Excel file with 1 Worksheet. When you uploaded the Dummy data excel file, it read the first worksheet in that file.


Feature request: Case Toggler

Description of the new feature / enhancement
There should be 5 case toggling shortcuts, which when applied to a selected block of text changes their case:

Flip case, eg: gIThUB -> GitHub
All uppercase, eg: Usa -> USA
All lowercase, eg: LET FLAG=0 -> let flag=0
Sentence case, eg: he is at the school. -> He is at the school.
Capitalise first letter of each word, eg: the three musketeers -> The Three Musketeers

The user should be able to enable all or any combination of the above five case change operations as per their needs and requirements, alongside being able to set custom shortcuts of each of them.
Alternatively, a single shortcut, say, Win+CapsLock may open a context menu with the 5 case toggling options, each with a numeric key, to be selected from the keyboard.
Scenario when this would be used?
Any time when a user is working at fast pace, be it coding or writing emails, they may overlook Caps Lock indicator or whatever is on the screen. When a large block of text is already typed, and the case issues noticed, it is hectic and frustrating to rewrite the whole block in the opposite case.
Furthermore, the sentence case and capitalise first letter of each word modes allow an user to write a large block of text without regards for the case, that interrupts workflow, and can fix it all at the end with a single shortcut key. Such features are already available in MS Word.
Personally, I often write without noticing the Caps Lock indicator, or the rendering on the screen, and notice that I wrote in the wrong case more often than I'd like to admit. Case has a great significance when coding, writing emails, etc.
Supporting information
No response

/dup #907


typing-error

openmms -> opennms
this can be fixed.   Unfortunately, even after cleaning up the tip error, grafana throws an error "e.functionParameters is undefined" at the  deep-dive Netflow-dashboard. I could not fix this one. (current opennms, elastic, drift-plugin, grafana and opennms-grafana-plugin under ubuntu 22.04 ).  Debugging grafana didnt help.  Only level=debug msg="user does not have access to any namespaces" which didnt help.
Pull Request Check Sheet

[ ] Have you read and followed our Contribution Guidelines?
[ ] Have you made an issue in the OpenNMS issue tracker?If so, you should:

update the title of this PR to be of the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
update the JIRA link at the bottom of this comment to refer to the real issue number
prefix your commit messages with the issue number, if possible

[ ] Have you made a comment in that issue which points back to this PR?
[ ] Have you updated the JIRA link at the bottom of this comment to link to your issue?
[ ] If this is a new feature, is there documentation?
[ ] If this is a new feature or substantial change, are there tests that cover it?

Pull Request Process
One or more reviewers should be assigned to each PR.
If you know that a particular person is subject matter expert in the area your PR affects, feel free to assign one or more reviewers when you create this PR, otherwise reviewers will be assigned for you.
Once the reviewer(s) accept the PR and the branch passes continuous integration in Bamboo, the PR is eligible for merge.
At that time, if you have commit access (are an OpenNMS Group employee or a member of the Order of the Green Polo) you are welcome to merge the PR.
Otherwise, a reviewer can merge it for you.
Thanks for taking time to contribute!
External References

JIRA (Issue Tracker): http://issues.opennms.org/browse/${JIRA-ISSUE-NUMBER}
Continuous Integration: CircleCI

Hi, this change needs to be retargeted to the release-9.x branch, probably best to do a rebase.
Mostly likely, in addition to this typo fix, this dashboard needs to be converted to v9. I will open a ticket to do so.

Added a ticket: https://opennms.atlassian.net/browse/HELM-412

Closing this PR, this has been addressed in the release-9.x branch. The latest flow_deep_dive dashboard has been fixed and converted to work with OPG v9.


Issue Label Notifications by using GitHub Action

🚀 Feature

Motivation

As PyTorch Lightning Community grows, some users want to be notified by issues with specific labels. By using GitHub Action would allow to notify the interested users.
Basically, the GitHub Action runs every time a label is attached to an issue, and compares the label to the list of notification recipients that has been specified If a match is found, the action will add a comment to the issue and @mention the notification recipients.
Pitch

Introduce Issue label notifier by using GitHub Action.
https://github.com/marketplace/actions/issue-label-notifier
Alternatives
Keep it as it is.
Use the UI search tool to find the issues/PR with corresponding labels.

Additional context

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

If we introduce this, we also might want to introduce more fine grained labels w.r.t which part of the codebase it touches to directly ping the relevant people there.

Yes,
Let's re-work on our labels to ensure finer control on new issues.
Best,
T.C

It looks nice and seems to be kind of an alternative to PR code-ownsers...

@Borda this is something different. Code Owners only requests reviews on PRs, this could ping people also on issues, which could allow faster resolution by directly pinging the right people :)

@Borda this is something different. Code Owners only requests reviews on PRs, this could ping people also on issues, which could allow faster resolution by directly pinging the right people :)

yes that what I mean, the code-owners works only for PR, compare to this util would work repo-wide

I fancy this suggestion! Shall we proceed forward?


feat(SFU): add sender reports

Description
Add reports to downtracks

This will help ensure SSRCs are synchronized. The other piece of information that's vital is ensuring the SDES/CNAME entry for audio and video is delivered to ensure the coordination of the SSRCs for synchronization purposes. Is that already completed elsewhere? It would not necessarily be present in the SRs RTCP packets.

This will help ensure SSRCs are synchronized. The other piece of information that's vital is ensuring the SDES/CNAME entry for audio and video is delivered to ensure the coordination of the SSRCs for synchronization purposes. Is that already completed elsewhere? It would not necessarily be present in the SRs RTCP packets.

No yet, I will implement it now in this PR !


Fix DeepSpeed CI

Fixes the DeepSpeed CI on the runner by just separating out the integration tests to be ran in a later python process, avoiding the lockup and issues.
Passed CI can be seen here on multi-gpu: https://github.com/huggingface/accelerate/actions/runs/2819545133

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thank you 😄. This is neat and finally all the tests would run as expected 🤗.


IK code

Adds the "IK" capability group to IsaacGym. Closes #27.

@jacky-liang Could you take a look at this? Some things:

Could you give a use case or example file for when a custom ee is used and how GymFranka usually takes care of that?
For set_ee_transform_delta, were you thinking of delta in the EE local frame or world frame? (set_ee_transform is expecting EE transforms in world frame). Either way unless this is strictly necessary for this PR, I would suggest adding it as a separate PR later
The total size of packages is about 5M (roboticstoolbox: 3.4M, spatialmath: 1.5M) so it's pretty small. Compare this to numpy which is 28M. Isaac Gym itself is 380M (at least, according to what pip is checking). So, I can keep the optional ik extras, or we can just add it as a core dependency.

Okay, thanks, that helps me better understand re: custom EEs.
It appears the RTB model is hardcoding a particular EE offset (https://github.com/petercorke/robotics-toolbox-python/blob/51aa8bbb3663a7c815f9880d538d61e7c85bc470/roboticstoolbox/models/URDF/Panda.py#L48). My preference is to try and have RTB load the URDF specified by the IG user to avoid a situation where there could be a URDF mismatch. After briefly looking into this, the URDF loading tools by RTB seem to assume a certain folder structure, but there could be a workaround and I will look into it later.

Okay, thanks, that helps me better understand re: custom EEs.
It appears the RTB model is hardcoding a particular EE offset (https://github.com/petercorke/robotics-toolbox-python/blob/51aa8bbb3663a7c815f9880d538d61e7c85bc470/roboticstoolbox/models/URDF/Panda.py#L48). My preference is to try and have RTB load the URDF specified by the IG user to avoid a situation where there could be a URDF mismatch. After briefly looking into this, the URDF loading tools by RTB seem to assume a certain folder structure, but there could be a workaround and I will look into it later.

Lol we use the same offset
if loading custom urdf is too much of a hassle you can just assume the offsets are the same in which case you can ignore self._gripper_offset.inverse() in the ee_transform calculation


Cannot find Continue On in SCM view

Testing #167433
The instructions say "Continue Working On is surfaced in the SCM view as a secondary action in the SCM action button dropdown", but I don't see Continue On in the viewlet menu (...) nor in the blue button drop-down. Codespaces is the only remote extension installed.

This is as expected. Sorry, the TPI should have specified that Continue Working On is only available with folders and workspaces opened via the GitHub Repositories extension.


mapping quality in PAF output

Hi, I have been testing this software and parsing the produced PAF files. After checking out https://github.com/lh3/miniasm/blob/master/PAF.md I was assuming column 12 is mapping quality, but then I found this thread where it says that wfmash lacks mapping quality.
So I am confused, what's the value in column 12 then?
Thanks,
Bruno

Hi, you are right, wfmash does not yet support mapping quality, and the values output in column 12 are very inaccurate approximations of that, put there as temporary placeholders. Sorry for the confusion.


Upgrade Cypress from 11.1.0 to 12.16.0

This PR upgrades Cypress from version 11.1.0 to the latest 12.14.0 12.16.0. See Changelog for a detailed list of changes, and the Cypress 12 Migration Guide for a good summary.
I've tried to get all of the tests passing against Cypress 12. Most relevant to us are the changes to Test isolation. In Cypress 11, you could do a before(), navigate to a page, and then have a bunch of it() tests that iterated sequentially, each one relying on the output of the previous one. In Cypress 12, the default behavior is to completely run each test in isolation. You can use cy.session() to cache a login session, but you need to load the test page in each test.
Because our site is unfortunately quite slow on lots of pages, this causes the tests to be noticeably slower; for example, whereas previously you'd have a series of tests that loaded the blog and went through a number of interactions, now each test has to load the blog independently each time, which is very slow.
A potential mitigation for this would be to consolidate some tests, such that we try to minimize the number of page loads. We could also choose to add testIsolation=false to our tests to maintain the old behavior, but from the documentation Cypress is trying to discourage this, which seems reasonable, if you want test behavior to truly be independent.
@contolini @mistergone @virginiacc @wpears I've tagged you as reviewers because there are changes here to tests you've created or edited, and also to solicit any opinions on the above. If you look into the commits below I tried to isolate changes app by app. FYI our team has been motivated to upgrade Cypress because we've been seeing quite a few flaky test failures which have been blocking cf.gov merges and deploys.
Edit to add: this PR also introduces cypress-fail-fast so that Cypress fails fast after the first test failure. This should hopefully significantly speed up how long it takes us to detect and iterate on failing tests.
How to test this PR
./frontend.sh to upgrade your Cypress, then follow instructions here.
Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines

Let's revert https://github.com/cfpb/consumerfinance.gov/pull/7829 in here and see how it performs. And thank you!

Fixes https://github.com/cfpb/consumerfinance.gov/issues/7397

With @chosak out, I've reverted the saving of videos on failure (https://github.com/cfpb/consumerfinance.gov/pull/7840/commits/3ec649c5c42606415c2cead680b494823c93fe5f) so this PR can be opened for review, as I'm not sure if that was just for testing purposes here or if the intent was to actually enable saving videos on main.

Thanks @anselmbradford, re-disabled in a830770.


Create hands_on_geostats.md

Add hands-on material for GeoStats.jl

Will copy the material over here as suggested.


wasmd 31 & fix interchaintest

Interchain test

https://github.com/strangelove-ventures/interchaintest/pull/448

For now I'll get it tuned up by using a replace statement, and we can get rid of the replace statement when interchaintest v4 has been updated.
The basic summary of the issue is that interchaintest was using a version of grpc that isn't compatible with the regen modified protobuf compiler.
Interchaintest also needed to be updated to support wasmd v0.31.0
wasmd 31
The Dockerfile needed to be updated to be compatible with wasmvm v1.2.1
# See https://github.com/CosmWasm/wasmvm/releases
ADD https://github.com/CosmWasm/wasmvm/releases/download/v1.2.1/libwasmvm_muslc.aarch64.a /lib/libwasmvm_muslc.aarch64.a
ADD https://github.com/CosmWasm/wasmvm/releases/download/v1.2.1/libwasmvm_muslc.x86_64.a /lib/libwasmvm_muslc.x86_64.a
RUN sha256sum /lib/libwasmvm_muslc.aarch64.a | grep 86bc5fdc0f01201481c36e17cd3dfed6e9650d22e1c5c8983a5b78c231789ee0
RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep a00700aa19f5bfe0f46290ddf69bf51eb03a6dfcd88b905e1081af2e42dbbafc

@Reecepbcups @vuong177 -- doesn't this look oddly similar to some of the issues that we had with the oracle?

Also noticing that maybe I need to be registered on heighliner?

Would rather us not hard code it - see commit 1c00723b61089de0f3786f24bfabe70885afa892 dockerfile line 20-30 (So it will auto update based off our go.mod)

@faddat The gov contracts failing is due to the unity-contract needing to be updated afaik - though the version issues may be another storeKey issue? was icacontrollertypes last time

honestly I am more content with a dockerfie that doesn't update itself


Function references implementation for Wasmtime

This is #5288 but with some more commits I've added onto the end to handle some comments I've noted during a "final" review pass. I think that everything should be in order now and there should be FIXME comments on major ticket items still remaining to do after this PR.
I've opened this as a second PR to provide my assistance in pushing this over the finish line. Many of my comments were relatively minor or stuff I would want to do quickly in a follow-up to help future-proof things as well so I figured I'd go ahead and make the changes here. The vast majority of this work is still Luna's and Daniel's!

Actually, on second though, I'm going to do my PR-the-PR strategy instead of this.


OS 10.0.17763.1369 not supported

Hi,
I have OS build 17763.1369 but hen running the RDPConf.exe I get Listener state: Not listening and not supported
It seems that sections [10.0.17763.1369] and [10.0.17763.1369-SLInit] are missing in rdpwrap.ini, event after trying to update.
Does someone knows how to get the correct offsets for this build ?
Thanks in advance.
Cedric

What version does rdpconf.exe show for the DLL?

Hi,
Wrapper : <IP_ADDRESS>
Service : 10.0.17763.1369

Okay, please upload the DLL so that some clever person can work out the details for the INI sections.

There it is.

rdpwrap.zip

ditto!

remove latest updates for now, worked for me

It's obvious that 1369 has the same offsets as 771.
Sorry, have x64 systems here to test.
Enjoy.
`
[10.0.17763.1369-SLInit]
bServerSku.x64        =ECAB8
lMaxUserSessions.x64  =ECABC
bAppServerAllowed.x64 =ECAC4
bInitialized.x64      =ECAB4
bRemoteConnAllowed.x64=ECAC8
bMultimonAllowed.x64  =ECACC
ulMaxDebugSessions.x64=ECAD0
bFUSEnabled.x64       =ECAD4
[10.0.17763.1369]
LocalOnlyPatch.x64  =1
LocalOnlyOffset.x64 =77AD1
LocalOnlyCode.x64   =jmpshort
SingleUserPatch.x64 =1
SingleUserOffset.x64=1339C
SingleUserCode.x64  =Zero
DefPolicyPatch.x64  =1
DefPolicyOffset.x64 =18025
DefPolicyCode.x64   =CDefPolicy_Query_eax_rcx
SLInitHook.x64      =1
SLInitOffset.x64    =1ACDC
SLInitFunc.x64      =New_CSLQuery_Initialize
`

Says it is fully supported, but does not connect without logging off active user.

Says it is fully supported, but does not connect without logging off active user.
This means that you are doing something wrong.

[10.0.17763.1369]
LocalOnlyPatch.x86=1
LocalOnlyOffset.x86=AFEB4
LocalOnlyCode.x86=jmpshort
SingleUserPatch.x86=1
SingleUserOffset.x86=4D7F5
SingleUserCode.x86=nop
DefPolicyPatch.x86=1
DefPolicyOffset.x86=4BFF9
DefPolicyCode.x86=CDefPolicy_Query_eax_ecx
SLInitHook.x86=1
SLInitOffset.x86=5B30A
SLInitFunc.x86=New_CSLQuery_Initialize
LocalOnlyPatch.x64=1
LocalOnlyOffset.x64=77AD1
LocalOnlyCode.x64=jmpshort
SingleUserPatch.x64=1
SingleUserOffset.x64=1339C
SingleUserCode.x64=Zero
DefPolicyPatch.x64=1
DefPolicyOffset.x64=18025
DefPolicyCode.x64=CDefPolicy_Query_eax_rcx
SLInitHook.x64=1
SLInitOffset.x64=1ACDC
SLInitFunc.x64=New_CSLQuery_Initialize
[10.0.17763.1369-SLInit]
bInitialized.x86 =CD79C
bServerSku.x86 =CD7A0
lMaxUserSessions.x86 =CD7A4
bAppServerAllowed.x86 =CD7AC
bRemoteConnAllowed.x86=CD7B0
bMultimonAllowed.x86 =CD7B4
ulMaxDebugSessions.x86=CD7B8
bFUSEnabled.x86 =CD7BC
bServerSku.x64 =ECAB8
lMaxUserSessions.x64 =ECABC
bAppServerAllowed.x64 =ECAC4
bInitialized.x64 =ECAB4
bRemoteConnAllowed.x64=ECAC8
bMultimonAllowed.x64 =ECACC
ulMaxDebugSessions.x64=ECAD0
bFUSEnabled.x64 =ECAD4
these are the same setting as for 10.0.17763.771
just changed 10.0.17763.771 to 10.0.17763.1369 and it worked

@sbozdag  Please, only provide properly determined INI sections; I understand it works for you, but it may not work fully and properly.

Says it is fully supported, but does not connect without logging off active user.

It is now working after a complete uninstall and reinstall - not sure why it didn't "take" at first like it usually does.

@s8m
copy this rdpwrap 10.0.17763.1369.zip *.ini file to C:\Program Files\RDP Wrapper and restart your pc
thx to @zzelalex

windows server 2019 datacenter 10.0.17763.1369
положить оба файла из архива в папку
"C:\Program Files\RDP Wrapper"
чтобы лежали так:
"C:\Program Files\RDP Wrapper\rdpwrap.dll"
"C:\Program Files\RDP Wrapper\rdpwrap.ini"
после чего ребутнуть винду и все должно работать "без пинка"

rdpwrap_windows_server_2019_datacenter_10.0.17763.1369.zip

windows server 2019 datacenter 10.0.17763.1369
положить оба файла из архива в папку
"C:\Program Files\RDP Wrapper"
чтобы лежали так:
"C:\Program Files\RDP Wrapper\rdpwrap.dll"
"C:\Program Files\RDP Wrapper\rdpwrap.ini"
после чего ребутнуть винду и все должно работать "без пинка"

rdpwrap_windows_server_2019_datacenter_10.0.17763.1369.zip

work with me

Hi, can somebody provide the original termsrv.dll with 17763.1369 for me, thanks a lot!

@wenan1130 If you do the following as an admin user in the C:\Windows directory, you may find the original termsrv.dll in one of the sub-directories, it should be around 1MB in size I expect.
dir/s termsrv*dll
When you find the right file, do something like the following with a cmd file in an admin cmd.exe window to replace a bad one in place:
@echo off

rem c:\windows\system32\termsrv.dll needs to be owned by administrators and modify rights enabled

net stop termservice /y
copy found_file_with_path c:\windows\system32\termsrv.dll /y
net start termservice

You want to run it as a cmd file because as part of the process, you will lose connectivity.... but the cmd file will continue to run in the cmd.exe window and restart the termservice facility.


fix: fix capacity limitation

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

/lgtm


java10 新特性

资料：

JDK 10 的 109 项新特性

Kamino closed and cloned this issue to dongyuanlongwang/feature

Kamino closed and cloned this issue to dongyuanlongwang/feature


I want to wait for the picture to load and then screenshots, how should I do

Steps to reproduce
Tell us about your environment:

Puppeteer version:
Platform / OS version:
URLs (if applicable):

What steps will reproduce the problem?
Please include code that reproduces the issue.

What is the expected result?
What happens instead?

http://lmgtfy.com/?q=wait+for+the+picture+to+load

https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagegotourl-options

https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagewaitforselectororfunctionortimeout-options-args

Please ask questions like this on stackoverflow.


goctl no matched module when generate code via goctl

I got this error when i run this command goctl api new demo2
I'm using WSL on windows 10, please help me fix this error :(( Thank you so much

I solved this problem by update windows to lastest version and upgrade WSL1 to WSL2 ^^


X-Forwarded Headers being modified

I am seeing an issue when using a load balancer that terminates TLS in front of the gorouters. We are injecting  X-Forwarded-Proto and X-Forwarded-Host headers before passing the traffic through to the gorouters. However when the application attempts to use these headers they seem to have been modified again.
The headers coming out of our load balancers before being passed to the routers look like this (I have modified the actual hosts for privacy) :
X-Forwarded-Host: my.external-url.com
X-Forwarded-Proto: https

After passing through the router, the app sees this:
X-Forwarded-Host: my.external-url.com, myapp.cfdomain.com
X-Forwarded-Proto: https, https

is this expected behavior? Is there a way to prevent this form happening ?

@warroyo :
X-Forwarded-Proto header should not overridden if it is already set in the request. We have an environment where ELB is terminating SSL and adding X-Forwarded-Proto header but gorouter respects this value and forwards the same to request.
gorouter does not set X-Forwarded-Host header. If client or LB is setting this header gorouter should pass them through.
To debug this issue further follow instruction on this repository to stage the app. Connect to the application without LB so you eliminate external components as the problem. You might have to be in the network to do the following steps.
curl -vv -H"X-Forwarded-Host:test" -H"Host:golang.cfdomain.com" GOROUTER_IP:PORT/headers

curl -vv -H"X-Forwarded-Proto:https" -H"Host:golang.cfdomain.com" GOROUTER_IP:PORT/headers

Verify the app is receiving your header and let us know if it is still modified?
Regards
Shash

@shashwathi thank you for the information. I have tested with the go app provided  and i do not see the duplicate headers. This issue does not seem to be related to the go router or load balancer. I think this issue can be closed now.


Add filetype t32

TRACE32 is a debug tool for embedded systems. It includes a scripting language for automation purposes. Typically, scripts have the file extension CMM. The suffix T32 is used for auto-generated files with configuration settings.

Is there a reason to not name the file type trace32?  It would seem a lot clearer though there may be some subtlety I'm missing.

Is there a reason to not name the file type trace32? It would seem a lot clearer though there may be some subtlety I'm missing.

This is a valid point. "T32" is the official short name and is frequently used as prefix for related utilities. With that in mind, I would say that users are likely to make that association. However, I fully agree that it might confuse people that are not familiar.


App cast generator null reference

Got this in my email:

I am trying to use the AppCastGenerator with a c# project. It finds my exe without issue - but continues to complain with "Object reference not set to an instance of an object." no matter what I do. I used it successfully to generate keys, but when I try to create the AppCast file, I get this error. Any ideas?

More info:

It looks like it was complaining because I didn't supply a base URL. I'll supply one and see if that helps.

Need to test this out and error out instead of obscure exceptions.

I can confirm that this happened with me as well - it just throws a null object reference exception. For reference, I'm running on Windows, using the last version of the prebuilt (and now deprecated) commandline tools (since I'm unable to download a more modern Visual Studio release to compile this from source due to bandwidth constraints).

Confirming this also happens on Linux as well.

Also confirming that adding a base URL works, and that I need to work on my reading comprehension :-D

@WaseemAlkurdi  Thanks for the confirmation! This bug is fixed, and it's rolling out via CI/CD now.
Can you use dotnet tool install --global NetSparkleUpdater.Tools.AppCastGenerator --version 2.0.1 to install the latest version? (In a few minutes when the CI/CD finishes and NuGet processes stuff.) You shouldn't have to build from source.
Otherwise, here's a zip of the latest build for you since I don't have it auto-publishing to the releases section on GitHub, if this is helpful:
app cast gen 2.0.1.zip

@Deadpikle Appreciated! :)
I can't use the dotnet command since I'm intentionally keeping the VM offline to avoid using up my limited data cap on Windows updates (and therefore, connecting it without updates would expose my host and guest to malware).
I've tried this package, and unfortunately, I got this error:
A fatal error occurred. The required library hostfxr.dll could not be found.
If this is a self-contained application, that library should exist in [C:\Users\Waseem\Downloads\app.cast.gen.2.0.1\publish\].
If this is a framework-dependent application, install the runtime in the global location [C:\Program Files\dotnet] or use the DOTNET_ROOT environment variable to specify the runtime location or register the runtime location in [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x64\InstallLocation].

The .NET runtime can be found at:
  - https://aka.ms/dotnet-core-applaunch?missing_runtime=true&arch=x64&rid=win10-x64&apphost_version=5.0.4

Trying to copy hostfxr.dll from the extracted NuGet package of the final (unsupported) release of the tools package results in another error:
Failed to load the dll from [C:\Users\Waseem\Downloads\app.cast.gen.2.0.1\publish\hostfxr.dll], HRESULT: 0x800700C1
The library hostfxr.dll was found, but loading it from C:\Users\Waseem\Downloads\app.cast.gen.2.0.1\publish\hostfxr.dll failed
  - Installing .NET prerequisites might help resolve this problem.
     https://go.microsoft.com/fwlink/?linkid=798306

I think that installing .NET 5.x would solve it, but since it might be self-contained (and it did mention things about self-containment) I thought I might want to tell you about the error first.

Yeah, the thing I uploaded is definitely not self contained, so those errors are essentially expected.
If you can't install the .NET 5.x runtime on the VM, let me know and I'll get around to uploading a self-contained version for you sometime soon.

@Deadpikle
Installed .NET 5.0.4 Runtime, and it works just fine ... thanks for fixing this!

Thanks so much for fixing! Finally getting round to integrating things today.


Add support for asset.icon where possible and add images to items fragment

What this PR does / why we need it:

.Params.asset.icon is now possible in item and items fragment
Deprecate logos fragment and every reference of it
Add support for image in items fragment's columns
Add items fragment to dev section (unconfigured-images, missing-images, resource-fallthrough)
Add examples of items fragment with image and content and with only image

Which issue this PR fixes:
fixes #325
Special notes for your reviewer:
This is quite a big change. I reviewed it myself so to see whether I've missed anything. The changes to fragments/ examples should be reflected in code-* files as well.

In navbar there are three assets (logo, search, repo) and renaming to asset was not possible.
In members fragment there are two assets (asset for image and icons for social links generally) and renaming to asset was not possible.
In table and item fragment, inside the table there is an icon but I'm not sure how to make that a toml table :D

Release note:
- Breaking: item: Icons should be placed under `asset` table
- Breaking: items: Icon for each column should be placed under `asset` table
- Breaking: logos: Deprecated `logos` fragment in favor of `items` fragment

I feel icon under asset makes the configuration easier and more understandable. We only need to document how to define an asset and which fragment comes with what variables. That would be it. I think that's easier.

Overall good.
A few things that feel a bit weird in items is that the url is set outside the asset and only links the title.
Maybe it should be set in the [asset] and link both the image/icon and the title?
Also the logo example doesn't showcase linking an image, which was a feature of logos.

Did the following, hope I didn't miss anything.

Fix url not located inside the asset
Add url to title and to icon
Remove title from html when it's not provided
Remove content from html when it's not provided
Add more examples


Thumbnail appear blurred/pixelated

Blurred thumbnails for many files, probably scaling issues.
PDF, Videos etc. Files associated with app like Adobe reader or VLC, appear blurred
Probably a scaling issue after switching to grid view, issue is only with files and not folders, seems to affect (around) first 15 files.
To Reproduce
Steps to reproduce the behavior:

Open any folder/location in Files Preview app
Switch to grid view (I tried with medium)
Thumbnails will be highly pixelated

Expected behavior
Scaled thumbnails of the files
Screenshots

Desktop (please complete the following information):

OS Version: Windows 10 2004 21277.1000
App version: v<IP_ADDRESS>

Additional context
Problem doesn't occur after restart
Log file
debug_fulltrust.txt

Duplicate of #2660


fixed issue with valid username restrictions.

Not possible to create user with such username.
> from pyon.util.containers import is_valid_identifier
><EMAIL_ADDRESS>--> False
> is_valid_identifier('ext:john_gmail_com')
--> False
> is_valid_identifier('ext_john_gmail_com')
--> True

Looks good. I can also relax the valid identifier policy for usernames later, so that we have : and @ characters


Is protractor no longer working when using Angular 13?

I'm using protractor and recently upgraded from Angular 12 to Angular 13. I now get an error while starting the e2e tests.
Error: Error [ERR_REQUIRE_ESM]: require() of ES Module<EMAIL_ADDRESS>not supported. Instead change the require of<EMAIL_ADDRESS>to a dynamic import() which is available in all CommonJS modules.
Is this something caused by protractor, angular/cdk or something else?

I think this question should be addressed in angular/angular project.

Hi @Heines1983,
I think this must be a problem with your e2e/tsconfig.json file.
Please check the module attribute in your configuration.
Here's an example:
{   "extends": "../tsconfig.json",   "compilerOptions": {     "outDir": "../out-tsc/e2e",     "module": "commonjs",     "types": [       "jasmine",       "node"     ]   } }
Or you can see the file in my project with Angular 13 and Protractor :
https://github.com/andredesousa/angular-linters/blob/main/e2e/tsconfig.json

The issue is that you are trying to use an ES Module lib but you are running protractor with CommonJS which does not support it. I had the same problem updating to ang13. Our libs no longer generate UMD modules and we can no longer run protractor with them. Need to build our libs with a different tool than ng-packagr that still support UMD.

@rbirkgit Yes, cannot import Angular libs for Protractor tests after Angular 13.

I changed to build our lib with rollup which supports CommonJS/UMD

I changed to build our lib with rollup which supports CommonJS/UMD

Could you give some references? I have the same issue and I haven't found a solution yet.

Just in case somebody else has the same issue. Protractor and cucumber worked quite fine for me, but I haven't realized that in one of my steps, I was using angular libraries which indeed have a problem with protractor, as libraries are in angular are esm, while in protractor commonjs. I had to replace some functions with pure typescript, js libraries, e.g. HTTP client for API calls, with request from nodejs, or axios library.


Load ConnectionString, ConnectionProvider from App Config

It would be nice to not have to maintain the connection string in the cake file when we can already pull that from the AppConfig that is loaded. I've got this working locally by specifying the ConnectionName in the settings instead, and using that to load the correct connection information.

Agreed, however, ConnectionProvider adds some complexity (just not really under MSSQL). Maybe parse a config file for EfMigratorSettings.

Hm. I have no experience with EF when it's not using SQL server, so I don't know what additional issues might be caused with the provider stuff.
From the PostgresQL test project, the connection string is just this:
<add name="SchoolContext" connectionString="{the actual connection string}" providerName="Npgsql"/>, so I'm just pulling out the values of the connection string and provider name based on the provided Connection Name. I do need to clean up my implementation, but if this approach won't always work then I think we'll have to find a different approach.


[BUG] "Depends" breaks request processing

Describe the bug
After adding a dependency to parameter without changing the data format old requests stopped working with error: "422 Unprocessable Entity"
To Reproduce

Create a file "run.py" with:

import requests
from fastapi import Depends, FastAPI
from pydantic import BaseModel
app = FastAPI()

class Item(BaseModel):
    name: str
    description: str = None
    price: float
    tax: float = None

class User(BaseModel):
    username: str
    full_name: str = None

def dependant(item: Item):
    return {'username': 'username', 'full_name': 'full_name'}

@app.post("/items/{item_id}")
def update_item(item_id: int, user: User, item: Item): #User = Depends(dependant)):
    results = {"item_id": item_id, "item": item, "user": user}
    return results

Create a file "run.py" with:

import requests

sample_body = {
    "item": {
        "name": "Foo",
        "description": "The pretender",
        "price": 42.0,
        "tax": 3.2
    },
    "user": {
        "username": "dave",
        "full_name": "Dave Grohl"
    }
}

print(requests.post('http://localhost:2000/items/1', json=sample_body))

Run the server and the test. It works.
Change

@app.post("/items/{item_id}")
def update_item(item_id: int, user: User, item: Item): #User = Depends(dependant)):
    results = {"item_id": item_id, "item": item, "user": user}
    return results

to
@app.post("/items/{item_id}")
def update_item(item_id: int, user: User, item: User = Depends(dependant)):
    results = {"item_id": item_id, "item": item, "user": user}
    return results

Run the server and the test. It does not work.
But I expected it to be working like before.

Expected behavior
I expected, that the change would not affect input format, because the only difference is in internal processing. Also, auto documentation suggests the same.
Screenshots

Environment

OS: Linux
FastAPI Version 0.46.0
Python 3.6.9

Thanks for the help here @nsidnev ! :cake: :bowing_man:
Thanks @AIshutin for reporting back and closing the issue :+1:


Fix an incorrect method of looking up previous keys

This was reported while testing https://github.com/Expensify/App/pull/29169#issuecomment-1770558360
Details
I was able to reproduce the issue with the infinite loading of avatars. While debugging the problem, I found that it was ReportScreen.js which was infinitely re-rendering. This manifested in the infinite loading of avatars. Since ReportScreen is at the top of the view hierarchy, I concluded the issue was definitely in withOnyx().
To debug it further, I began to inspect what happened when componentDidUpdate runs, and then checks to see if the key changed (eg. previousKey !== newKey). I found that the logic was properly detecting that the key changed, so withOnyx correctly tried to reconnect with the new key. When the new connection happened, the logic is supposed to remember what the previous key was (eg. mapOnyxToState[statePropertyName].previousKey = key;). This triggers componentDidUpdate() again and I found that the previousKey was always wrong. It wasn't actually changing, so withOnyx went into an infinite loop trying to reconnect to the same keys over and over again.
I fixed it by utilizing prevProps and prevState arguments from componentDidUpdate() to more accurately calculate what the previous and current keys were, rather than relying on a reference to mapOnyxToState[statePropertyName].previousKey. This now correctly picked up the change to keys and prevents the infinite connection.
Related Issues
https://github.com/Expensify/App/pull/29169
Automated Tests
None
Manual Tests
This requires a little bit of setup.
Setup in NewDot

In NewDot (you should be on main with version 1.0.100 of Onyx), log in as a user and be sure you have an avatar uploaded
Create a workspace and upload an avatar for the workspace
Request money from the workspace (+ > request money > manual)
After you create the request, you will be on the workspace chat

Setup NewDot to run the Onyx fix

Go to the react-native-onyx directory and run npm run build && cp -r dist ~/Expensidev/App/node_modules/react-native-onyx to copy the changes from this PR into NewDot (you may need to adjust the file paths)
For NewDot, start the build with npm run web
Go to the workspace chat that you requested money from
Click on the request preview to go to the report details that lists all the requests
Now click the link in the chat header to go back to the workspace chat
Open the JS console and go to the network tab (be sure to remove all request filters)
Verify that you do not see the avatars loading infinitely
Navigate back and forth between each of those report views a few times
Verify that you do not see the avatars loading infinitely in the network tab

Author Checklist

[x] I linked the correct issue in the ### Related Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native cannot test because no access to network console
[x] Android / Chrome cannot test because no access to network console
[x] iOS / native cannot test because no access to network console
[x] iOS / Safari cannot test because no access to network console
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

cannot test because no access to network console

Mobile Web - Safari

cannot test because no access to network console

Desktop

iOS

cannot test because no access to network console

Android

cannot test because no access to network console

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@jjcoffee could you test this this change as well together? https://github.com/Expensify/react-native-onyx/pull/408

@mountiny Will do!

Ah yes with #408 that now works fine against v1.0.109! On react-native-onyx main there's a bit of an issue with loading the report previews (unrelated to these PRs):
https://github.com/Expensify/react-native-onyx/assets/27287420/a87d7647-6cc2-468f-83a2-269533326021

Hm, the failing test is leading me to believe I didn't have the right solution. I'm still digging into this.

Haha unfortunate timing! :sweat_smile:

OK, after testing this for a while, I checked out the branch from https://github.com/Expensify/react-native-onyx/pull/408 and to my surprise, the original problem could not be reproduced with the infinite avatars. I think my solution here was kind of maybe working around the root of the problem. I think this can be closed.


Handle bool as keywords

Background
We often use bool type when programming using C lang.
But current norminette doesn't support bool as keywords, so it prints unexpected error when we use bool with functional pointer as follows:
struct s_my_struct {
	bool	(*f)(my_type_1 *const val1, my_type_2 val2);
};

Error: SPC_AFTER_OPERATOR   (line:   2, col:  28):      missing space after operator

Changes
I add bool into lexer dictionary to handle it as keywords.

Hello, before reviews please resolve all your conflict

Hello,
bool is not a C keyword, and not a fundamental type. So it should not be added to the lexer dictionnary.
The "#include <stdbool.h>" should be used to define the bool type (the include usually contains #define bool (unsigned int)")


RPN regression loss suddenly becomes NaN

When I use this code to train on customer dataset(Pascal VOC format), RPN loss always turns to NaN after several dozen iterations.
I have excluded the possibility of   Coordinates out of the image resolution,xmin=xmax and ymin=ymax.
[session 1][epoch  1][iter   12/4500] loss: 1.1964, lr: 1.00e-03
fg/bg=(16/496), time cost: 0.503772
rpn_cls: 0.1663, rpn_box: 0.0488, rcnn_cls: 0.9381, rcnn_box 0.0433
[session 1][epoch  1][iter   13/4500] loss: 0.8909, lr: 1.00e-03
fg/bg=(12/500), time cost: 0.516370
rpn_cls: 0.1984, rpn_box: 0.0421, rcnn_cls: 0.6251, rcnn_box 0.0254
[session 1][epoch  1][iter   14/4500] loss: 1.1052, lr: 1.00e-03
fg/bg=(20/492), time cost: 0.490039
rpn_cls: 0.1901, rpn_box: 0.0351, rcnn_cls: 0.8329, rcnn_box 0.0469
[session 1][epoch  1][iter   15/4500] loss: nan, lr: 1.00e-03
fg/bg=(6/506), time cost: 0.530968
rpn_cls: 0.1404, rpn_box: nan, rcnn_cls: 0.2575, rcnn_box 0.0102

I met a similar problem here, trained on KITTI pedestrian detection, converted to voc format
loss would go to NaN in like 20 iters
wondering how to solve the problem.

@ZHOUXINWEN  @rxqy  Have you solved this problem?  I am stuck in the same problem. Thanks！

@xiaomengyc
This should help you. it's to do with your annotations and possible the "-1" when feeding in the annotations in the pascal voc dataset script.
https://github.com/jwyang/faster-rcnn.pytorch/issues/136#issuecomment-390544655

Thank you @Worulz. I have found this solution and fixed my problem.  I train this faster-rcnn on a pedestrian dataset. When I adopted the restriction for the box sizes, the NaN problem disappeared.

@xiaomengyc
How to restrict the box sizes,can you show the modification in code?I have been stuck in the same problem,I need your help.Thanks a lot.

You just need to change this line to
https://github.com/jwyang/faster-rcnn.pytorch/blob/28db6d0b313220d200b739f4e22410fbe35529f4/lib/roi_data_layer/roibatchLoader.py#L190
not_keep = (gt_boxes[:,2] - gt_boxes[:,0]) < 10 and (gt_boxes[:,3] - gt_boxes[:,1]) < 10
where 10 is the minimum width and height.

@xiaomengyc from your description seems that's because RPN couldn't propose very small anchors? How about trying to set config.py:__C.ANCHOR_SCALES to smaller values, e.g. [1,2,3]?

@askerlee As I understand, ANCHOR_SCALES should be set with respect to the scale of ground-bboxes.
Filtering out some very small boxes can avoid the model producing proposals with the area of 0, which may cause NaN problem.
According to my experiments,  loading pre-trained weights, e.g. Faster-RCNN trained on COCO, can also avoid the NaN problem, without filtering out small bboxes.
So, if there are no pre-trained weights, I assume that we can train the model with the filter for several epochs, and then remove the filter to continue training.

@xiaomengyc I've also met the same problem. But the culprits are ground bboxes of sizes around 50x10. So I applied your trick and filtered these bboxes. I guess nan appears because the proposals are too far away from ground bboxes and hence big rpn_box losses are incurred.

@askerlee I might be.
In my case, I traced the code, and found the area of some proposals become zero, which cause the denominator of somewhere to be zero.

@askerlee  Hi, how do you solve your problem, i met the same problem that the sizes of ground bboxes in my datast are small and around to 20*20. And i get no nan loss in first epoch and it gets nan loss from second epoch. Can you tell me your solution, thanks.

@Tianlock do you have large and very small bounding boxes?. You could always crop the image to find feature areas. Then run the algorithm on top.

@Tianlock I fixed it by filtering bboxes smaller than 20x20. You could set the filtering threshold to say 15x15, if 20x20 filters many useful bboxes. You could also try to reduce the learning rate at the same time.

@Tianlock
Great
Can you tell how to filtering the bboxes ??
Thanks

its just for dataset annotations.
you should modify the pascal_voc.py code as follows :+1:
x1 = max(float(bbox.find('xmin').text), 0)
y1 = max(float(bbox.find('ymin').text) , 0)
x2 = max(float(bbox.find('xmax').text) , 0)
y2 = max(float(bbox.find('ymax').text) , 0)
or
x1 = max(float(bbox.find('xmin').text) - 1, 0)
y1 = max(float(bbox.find('ymin').text) - 1, 0)
x2 = max(float(bbox.find('xmax').text)  - 1, 0)
y2 = max(float(bbox.find('ymax').text)  - 1, 0)

not_keep = (gt_boxes[:,2] - gt_boxes[:,0]) < 10 and (gt_boxes[:,3] - gt_boxes[:,1]) < 10

Hi, I get RuntimeError: bool value of Tensor with more than one value is ambiguous error when I tried to replace the line with your code. Any idea why this might have happened? Thanks in advance!

@xiaomengyc

not_keep = (gt_boxes[:,2] - gt_boxes[:,0]) < 10 and (gt_boxes[:,3] - gt_boxes[:,1]) < 10

Hi, I get RuntimeError: bool value of Tensor with more than one value is ambiguous error when I tried to replace the line with your code. Any idea why this might have happened? Thanks in advance!

Try to replace the and operation by * ,  see if it works.

@xiaomengyc

not_keep = (gt_boxes[:,2] - gt_boxes[:,0]) < 10 and (gt_boxes[:,3] - gt_boxes[:,1]) < 10

Hi, I get RuntimeError: bool value of Tensor with more than one value is ambiguous error when I tried to replace the line with your code. Any idea why this might have happened? Thanks in advance!

Try to replace the and operation by * , see if it works.

Yes it works! Thanks. Although I am still getting nan loss but thanks anyways :D


Add "feature" as an alternative to "feat" in the parser.

I always forget and write feature rather than feat, so I figured I'd add it as an alias in the angular parser.

Can this be merged?

Sorry for the late answer. I think this should be opt-in somehow, either by being a separate parser that extends the angular parser or by being an option.

Hmm, why do you say that? Is there a case where someone would start a commit with "feature:" but didn't want it to count as a feature?

As it is called the angular parser it should fit with the specification in the angular commit guidelines. This is important to make it possible to work with other tools. I am not against extending it as long as it follows the specifications as default. Furthermore, consistency is good so I rather see it enforce one label for each type as default.

I'm not sure how to make this an option, though.
I think the easies way would be to add another parser.

I'm closing this, if you want this feature to please open a pr with a new parser.


Swift 3 ?

We have a requirement to integrate this SDK. Any chance this is going to be converted to Swift 3 ?
Thanks
Hemanta

We don't have an ETA yet but we're working on getting the SDK up-to-date for swift 3. I'll reply here as soon as I know more.

Thanks for the prompt reply!!

Hello Hemanta,
There's a new branch called feature/swift3.0 available now. Would you be willing to give it a try and provide us feedback please?
Thanks!

Sure thing. I also wanted to ask, if you have plans to support Carthage ( https://github.com/Carthage/Carthage ).
Thanks

Hey guys, I tested out the swift3 branch. Works great.
Thanks.


Cloudflare Pages after successful login fails call setServerSession in a static web app

Version
@nuxtjs/supabase: "^0.2.0"
nuxt: "3.0.0-rc.12"
Reproduction Link

Steps to reproduce
set ssr: false and deploy to cloudflare pages then try and login
What is Expected?
setServerSession should not be called in a static web app
What is actually happening?
entry.3428e15a.js:9 Uncaught (in promise) FetchError: 405  (/api/_supabase/session)     at async Object.callback (entry.3428e15a.js:9:4034)
export default defineNuxtConfig({
	srcDir: 'src',
	nitro: {
		preset: 'cloudflare_pages'
	},
	ssr: false,
	typescript: {
		shim: false,
		strict: true,
		typeCheck: false,
		tsConfig: { vueCompilerOptions: { strictTemplates: true } }
	},
	modules: ['@nuxtjs/supabase', '@nuxtjs/tailwindcss', '@pinia/nuxt', '@vueuse/nuxt'],
	build: {
		transpile: ['@headlessui/vue']
	}
});

@PoisnFang any luck with this? It doesn't seem limited to cloudflare - even testing locally fails in the same way.

@PoisnFang any luck with this? It doesn't seem limited to cloudflare - even testing locally fails in the same way.

Hey @MikeBman I privately forked the project and made the update myself. Personally I think Server rendered and SPA should be two different repos. I can upload and example of what I did in a day or so.

@MikeBman  I just pulled the composables and plugins folders directly into my project from here. I am deploying to Cloudflare


Suggested to random ip in FetchOne.

Hello. I think your FetchOne function always return the first ip in cache is not perfect.Because we can use dns to do some load-balance.

So, i think you can random your ip in return. Or create another function to return a random Ip.

@karlseguin do you consider to accept a pr for this change?

I don't have access to this repo anymore. I don't know if it's being maintained by anyone. If I was using it, I'd just fork it and maintain my own.

Yeah! That is what I do.
You can see my repo: https://github.com/starsz/dnscache , and I added FetchRandomOne and FetchRandomOneString function.


topic ID is optional

go-natty demo program receive message from public waddell server without topic id (i.e only 16 bytes uuid assigned by server)

Coverage decreased (-0.09%) when pulling af419b1bb01d73dabafd7c089f4cb3c82df2cd80 on ed2k:optional_topicid into d80bb3d12ff60214c4874e23bf143be2fa3f1173 on getlantern:master.

Coverage decreased (-0.09%) when pulling 5d217f5c49be291892e4c10fce87ffa53bf6ca6f on ed2k:optional_topicid into d80bb3d12ff60214c4874e23bf143be2fa3f1173 on getlantern:master.

@ed2k Actually the demo program does use a topic - https://github.com/getlantern/go-natty/blob/master/demo/proxy.go#L87

then, why did waddell server returns a message without topic?

@ed2k Can you construct a unit test to reproduce what you're seeing please?

@oxtoacart the go-natty demo program won't work without this.
./demo -mode server will complain the received message is 16bytes, and expecting 18bytes.

I think the waddell server may have a bad version deployed.  I'll check it out in a little bit.

@ed2k Okay, I think it should work now.  Can you please try again?

yes, works for me now.

@ed2k Thanks for testing, and thanks for letting us know about the problem!


Improve variance_scaling_initializer description

Added mention of the "MRSA initialization" alias. This name has been mentioned in multiple publications. Mentioning it in the docs will make this initializer easier to find.

Can one of the admins verify this patch?

This should be ready for review.

Infra error: docker.
Jenkins, test this please.

Tests seem to be failing for reasons unrelated to this PR. Similar to https://github.com/tensorflow/tensorflow/pull/15099#issuecomment-349307648


AdminService 404 errors

I'm suddenly getting 404 errors in the AdminService logs when the script queries for BIOS or driver packages.  The account password hasn't expired so I don't know why it just stopped working.
Any ideas where to start checking?  What permissions are required for the account being used?  It currently has the "Read-Only Analyst" role in SCCM which I thought was all it needed.
Could this be an IIS permissions issue?
If I paste the following query into a browser logged on as myself, I get a list of packages.
https://<server.name>/AdminService/wmi/SMS_Package?$filter=contains(Name,'Drivers')
If I open an incognito window and paste they query into the browser then use the credentials I've been using for several years I get:
{"error":{"code":"404","message":"Access denied  WMI QUERY: "}}

Found it.  The SCCMAdmins group didn't have WMI permissions to query per the following link.
https://www.anoopcnair.com/configmgr-sccm-how-to-verify-wmi-permission-for-console-access/
Anoop saves the day yet again.

Thanks for this follow up.
Just been upgrading all my SCCM servers from 2016 to 2022 and i have run into this issue on every single one.
Thanks to your link just adding the account i use for the drivers to the WMI has resolved the issue.


[opentelemetry-collector] Add statefulset mode

This PR adds a new mode to the collector chart: statefulset.  When mode: statefulset is used, the collector will be deployed as a statefulset.
I will bump the chart version once the PR is reviewed.
Closes #177

/cc @sherifkayad

Looks like the issue in the description is incorrect

Please take a look at the failing linter

Please take a look at the failing linter

It's the chart version bump.  I was gonna hold off on the bump until the core changes can be reviewed, since the bump will trigger the examples to change and clutter up the files.

@TylerHelmuth Looks really good thanks for the heads up

@sherifkayad No problem. If you use this feature and run into any issues let us know.

Sure thing will do 😉

@TylerHelmuth seems like the volumeClaimTemplates isn't taken into consideration for some reason .. My Yaml config is as follows:
statefulset:
  # volumeClaimTemplates for a statefulset
  volumeClaimTemplates:
  - metadata:
      name: opentelemetry-collector-data
    spec:
      accessModes: [ "ReadWriteOnce" ]
      resources:
        requests:
          storage: 5Gi
  podManagementPolicy: "Parallel"

On another notes, I am also getting this error:
create Pod opentelemetry-collector-0 in StatefulSet opentelemetry-collector failed error: Pod "opentelemetry-collector-0" is invalid: spec.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution[0].topologyKey: Invalid value: "kubernetes.io/hostname null": name part must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]')
My affinity settings are as follows:
affinity:
  podAntiAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
          matchLabels:
            app.kubernetes.io/name: opentelemetry-collector
        topologyKey: kubernetes.io/hostname
    preferredDuringSchedulingIgnoredDuringExecution:
      - weight: 100
        podAffinityTerm:
          labelSelector:
            matchLabels:
              app.kubernetes.io/name: opentelemetry-collector
          topologyKey: failure-domain.beta.kubernetes.io/zone

I opened #368 addressing both these issues.


Pull in the up-core-api 1.5.7 changes

the following uses proto defined CallOptions and changes commstatus from integer to Ucode

@stevenhartley -- is it intended to update to pull in the clarification to make sure the UUri's fields will fit within the bits and bytes of the Micro Form?
I think this update would go into MicroUriSerializer.java based on what I'm seeing.


How to you implement Resnet?

In your code, you import Resnet18, but there is no publicly available library for PyTorch that provides this net. Which repository have you used to be able to run this code:
from resnet import Resnet18
class ContextPath(nn.Module):
def init(self, *args, **kwargs):
super(ContextPath, self).init()
#self.resnet = ResNet.from_name("resnet18")
self.resnet = Resnet18()
self.arm16 = AttentionRefinementModule(256, 128)
self.arm32 = AttentionRefinementModule(512, 128)
self.conv_head32 = ConvBNReLU(128, 128, ks=3, stride=1, padding=1)
self.conv_head16 = ConvBNReLU(128, 128, ks=3, stride=1, padding=1)
self.conv_avg = ConvBNReLU(512, 128, ks=1, stride=1, padding=0)
self.init_weight()
I have tried installing  pytorch_resnet, but the implementation is different. Installing resnet from Python PIP leads to a dependency problem with Tensorflow. The following error is thrown if attempting to use pytorch-resnet:
File "/SAFA/face_parsing/model.py", line 112, in forward feat8, feat16, feat32 = self.resnet(x) ValueError: not enough values to unpack (expected 3, got 1)
This project does not indicate how Resnet has been implemented. How have you installed it on your system? Please advise.

This problem has been resolved by changing the resnet import to .resnet (to reference the file within the library).


Isogram: tests and example

Tests and example for Isogram exercise

@ecrmnn thanks for doing this!
I have a couple points of feedback:

it would be good to have your example (and probably a test or two) that test for casing on the isograms.  EG, shouldn't 'Kicker' fail the test?  Right now I think it would pass BC the two k's are different cases.
The config.json file controls the order in which the exercises are served to users.  This exercise is excellent for JavaScript beginners, but is not as complex to solve as the other exercises at the end of the track, it should be placed closer to the beginning, near something like word-count or pangram.

Would you be able to make those changes?  Let me know if you need help, I'm happy to to assist.

@matthewmorgan Thanks for your feedback.

Changed test from "alphabet" to "Alphabet". This would have passed before, now it's fixed.
I didn't realize it was the order the exercises were served in. Sorry about that. Moved isogram between word-count and pangram.

Great!  Thanks.  One last thing: the custom here is to squash all the commits for a given PR, so there's only one commit in the master history once it's merged.
Are you comfortable squashing this or would you like help?

@matthewmorgan All good now?

oops-- one more thing: all tests but the first should be changed to xit so they don't run out of the box.  Otherwise it looks great.

Oups, fixed

Awesome.  Thanks @ecrmnn !

No problem 😄 Exercise files should probably be merged too in order for this to work

Thanks for the reminder!  I forgot that detail 😊


Add some certbot instructions in wiki

What this PR does / why we need it
PR helps users to generate cert for https with certbot. I saw your note here and wanted to contribute.
If you have any comments on the PR please give a feedback

[x] DCO signed
[x] The PR title has a summary of the changes
[x] The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

@jkroepke hello! Thank you for the feedback, I've fixed your suggestions


Support IAM authentication for AWS RDS databases

Currently Superset only supports connections to postgre-compatible databases with credentials.
The connection URI must be like postgresql://username:password@host/db_name.
AWS RDS provides IAM authentication [1] which allow to connect to a database with a role ARN and a session token (regularly refreshed).
This would allow to use Superset without the need for credentials on the underlying database.
Superset connector PyAthena [2][3] already supports assuming an IAM role, which removes the need for credentials on AWS Athena. Allowing the same kind of feature on RDS databases would be great 🚀
Thank you for your help !
References
[1] https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.html
[2] https://superset.apache.org/docs/databases/athena
[3] https://github.com/apache/superset/discussions/15739

@gforien This is a feature request, which should be raised under 'Discussions'. Please close this issue.

@matt-anon Yes this can surely be achieved by a simple python script for fetching & refreshing the token.
Google even maintains an example of this script for GCP https://github.com/GoogleCloudPlatform/cloud-sql-python-connector
The point was that this script could be provided by Superset, instead of having every cloud-based customer implementing it themselves 🙂


Fix outdated link in resample error message

I found this while trying to reproduce the plot here:
http://matthewrocklin.com/blog/work/2017/01/12/dask-dataframes#time-series
I'm still figuring out what to do with the error but in the meanwhile I fixed the docs :)

I changed another link. I can squash if you prefer.

Thanks!  Squash and merging from here.


Feature request: stream for authstatechanges() just like firebase auth stream builder

Would love to add a state management in built to handle streambuilder widget with stream determining whether the user is logged in or logged off.
This would give a realtime state management of the current user state. (Specially for determining whether to show login page or the main app)

There is experimental method on auth onChange that should provide this.
sdk.auth.onChange...

There is experimental method on auth onChange that should provide this.
sdk.auth.onChange...

Damn... smart.


Assigning in Blaze Component

Can you elaborate on how to assign to Blaze Component? Do you mean doing this?
BlazeComponent.extendComponent({
  onCreated: function () {
    this.totals = new ComputedField(function () {
      // My computations...
    });
  }
});

And will it clean itself up?

And will it clean itself up?

No, you have to call this.totals.destroy() to stop the autorun unless it is already called from a reactive computation in which case it will be automatically stopped.

So I would need to destroy them all onDestroyed of the Blaze Component?
Why not bake a method into Blaze Component that creates a ComputedField the way embox-value does in their package, that way it auto-cleans itself when the template is destroyed.

See example in the README how you can make automatic cleanup of all computed fields.
You could add this to your base class' onDestroyed which extends Blaze Component without any ill effect if there are no computed fields.

The issue is that I do not want to assume in this package that you do not want for the field to survive being working also after onDestroyed. In fact, I sometimes use a pattern where I am reusing the component and I am rendering the same component multiple times. Sometimes you might want things to be stopped in onDestroyed, but sometimes you do not want, because you want them to be kept propagated even when they are not rendered.

(BTW, I renamed destroy to stop.)

My biggest issue is that this code is using global Tracker.autorun and not component's one. So you cannot access template instance inside the autorun. :-( See https://github.com/meteor/meteor/issues/4494

OK, I improved the computed field so it is not necessary to stop it anymore manually. It will be stopped and cleaned automatically when it is not needed anymore. And restored if it is needed again. So just define the fields whenever and wherever you need them and this is it.

Cool, thanks.


fix s3fs folder

when s3fs identify whether the object is a folder, s3fs need to check a header "Content-Type: application/octet-stream" returned by HEAD Object rest api of juicefs s3 gateway

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.01374862 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add kernel time tracing support for gpu

Use pti-gpu to trace the OpenCL kernel execution and print the trace result after the program is finished. The feature is default OFF and could be enable by setting -DGC_ENABLE_GPU_PROFILE=ON.
Example:
./bin/gc-gpu-runner --shared-libs=../externals/llvm-project/build/lib/libmlir_runner_utils.so ../test/mlir/test/gc/gpu-runner/XeGPU/f16_matmul_128x64_transpose.mlir

Unranked Memref base@ = 0x556fbba18bc0 rank = 1 offset = 0 sizes = [32] strides = [64] data =
[5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719,  5.11719]

=== API Timing Results: ===

             Total Execution Time (ns):             63061619
Total API Time for CL CPU backend (ns):                 3418
Total API Time for CL GPU backend (ns):              1952063

== CL CPU Backend: ==

      Function,       Calls,           Time (ns),  Time (%),        Average (ns),            Min (ns),            Max (ns)
clGetDeviceIDs,           1,                3418,    100.00,                3418,                3418,                3418

== CL GPU Backend: ==

                                Function,       Calls,           Time (ns),  Time (%),        Average (ns),            Min (ns),            Max (ns)
                    clEnqueueMemcpyINTEL,           4,             1111814,     56.96,              277953,               12439,              877623
                  clEnqueueNDRangeKernel,           1,              181885,      9.32,              181885,              181885,              181885
                          clBuildProgram,           1,              166584,      8.53,              166584,              166584,              166584
                         clWaitForEvents,           2,              142960,      7.32,               71480,               18542,              124418
      clCreateCommandQueueWithProperties,           1,              113511,      5.81,              113511,              113511,              113511
                   clSharedMemAllocINTEL,           3,              106677,      5.46,               35559,               14840,               70172
                          clMemFreeINTEL,           3,               71023,      3.64,               23674,               15496,               39005
                         clCreateContext,           1,               15468,      0.79,               15468,               15468,               15468
                        clReleaseProgram,           1,                7996,      0.41,                7996,                7996,                7996
           clSetKernelArgMemPointerINTEL,           3,                6909,      0.35,                2303,                1240,                4271
                          clCreateKernel,           1,                6202,      0.32,                6202,                6202,                6202
                   clCreateProgramWithIL,           1,                5263,      0.27,                5263,                5263,                5263
                          clReleaseEvent,           5,                2464,      0.13,                 492,                 214,                1222
clGetExtensionFunctionAddressForPlatform,           6,                2361,      0.12,                 393,                 233,                 660
                         clReleaseKernel,           2,                2077,      0.11,                1038,                 552,                1525
                          clGetDeviceIDs,           2,                1922,      0.10,                 961,                 206,                1716
                          clSetKernelArg,           7,                1670,      0.09,                 238,                  53,                1038
                           clCloneKernel,           1,                1485,      0.08,                1485,                1485,                1485
                   clReleaseCommandQueue,           1,                1332,      0.07,                1332,                1332,                1332
                         clGetDeviceInfo,           4,                 979,      0.05,                 244,                  64,                 527
                   clGetCommandQueueInfo,           4,                 937,      0.05,                 234,                  49,                 550
                     clSetKernelExecInfo,           3,                 544,      0.03,                 181,                  69,                 405

=== Device Timing Results: ===

                Total Execution Time (ns):             63061619
Total Device Time for CL GPU backend (ns):                95680

== CL GPU Backend: ==

              Kernel,       Calls,           Time (ns),    Time (%),        Average (ns),            Min (ns),            Max (ns)
linalg_matmul_kernel,           1,               95680,      100.00,               95680,               95680,               95680

PTI has not yet released OpenCL support as of now for its SDK. The current estimation is that it should take about a month to complete. The API will follow the existing one for L0. There will be a proper library to link against as well.

Thanks for the information! We could switch to link SDK when the OpenCL support is ready

@zhczhong, would it be possible to put the changes inside PTI instead of a fork? A branch maybe?

I tried it but don't have written permission for the PTI repo and cannot create a branch for it.

Here's a public branch for the PTI's interface https://github.com/intel/pti-gpu/tree/exp_opencl_0.11.0. @zhczhong, could you please revive this?

以下是 PTI 接口 https://github.com/intel/pti-gpu/tree/exp_opencl_0.11.0 的公共分支。，您能恢复一下吗？

ok! I will switch the profiling support to the one based on the sdk

This PR depends on https://github.com/intel/pti-gpu/pull/80 for a correct compilation


Add Yagc - Learn on-the-go

YAGC is a dynamic mobile learning platform designed to enhance educational experiences. It provides users with access to a variety of resources, enabling learning on-the-go and fostering a flexible approach to education.
Name: Yagc
URL: https://yagc.tahriver.online
Platform: Education, Online Learning, On-the-go

Hi @imabutahersiddik! Thank you for the suggestion. At present, we are listing information on GitHub repositories. Therefore, the web site is not covered for now. If there is any related code in GitHub, it is possible to list that. Does it exist?

Peace and blessings be upon you,
This is a mistake that unable to recognize before opening issue that it is for repository. Yagc code are not open-source, so there is no repository of it.


docs: Remove IPv6 BPF masquerading restriction with BIG TCP

Now that we have support for IPv6 BPF masquerading, we no longer need to tell users to turn off IPv6 masquerading for using BIG TCP.

Then lets cherry-pick this one for the PR in here? https://github.com/cilium/cilium/pull/26205/commits/27842834c3850ee8fe20874d34c468d66ab2aabd

Sorry, it's already in your PR, which I review this morning :facepalm: Somehow I remembered you had updated test/bigtcp/test.sh but forgot you also had the doc update. I'm closing this one, apologies for the noise.


10/15/2018 01:35 : Create Pull Request for branch master -> prTesting1_2018101501

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Review tutorial docs

Hi @EdCharbeneau
As you are going to see, the updates on my side aim mainly at keeping a level of consistency in:

Capitalization of headings.
Headings are now all capitalized based on the title case approach (capitalizing all words except for conjunctions, articles, and prepositions unless a part of phrasal verbs). There is no right or wrong way as long as a single approach is kept all through the article. So if you want to change it, just choose another rule and stick to it – it’s entirely up to you.
Usage of the Kendo UI product name.
Each mention of the product is now Kendo UI so as to correspond to the company guidelines.
Some general issues.
Client side > client-side when used as an adjective.
Boiler plate > boilerplate
Quick-start > quick start
Etc.

Excellent work, thank you.


Fix Server Crash When Dev Files Not Available

This pull request makes the following changes

Fixes code-collabo/node-mongo/issues/54

General checklist

[x] File or folder now contains changes as specified in the issue I worked on
[x] I have linked the issue I worked on to this pull request submitted by me

Testing checklist

[x] When user is still in atlas mode: User has been informed that they can only use or access the dev:local script command when they have switched to local connection setup type via the npm:change script command
[x] When user is still in local mode: User has been informed that they can only use or access the dev:atlas script command when they have switched to ATLAS connection setup type via the npm:change script command
[x] I certify that I ran my checklist

Ping @code-collabo/node-mongo-api-boilerplate-templates

This pull request is not independent as there are changes in the api-biolerplate-templates that needs to be reviewed before merging the pull request. Check the issue here: https://github.com/code-collabo/node-mongo-api-boilerplate-templates/pull/53#issue-1967941022

Nice work connecting this PR @Festusali, I will review before the end of the week.


Collapsed navbar menu does not popup when clicked

Please provide plunker or repo, and reproduce info
ng2-bootstrap doesn't have navbar or popups components as for now

closing because not enough info to reproduce

Any plans to add the navbar component?

yeap

Can you tell us about your plans please? And why is this issue closed? The bootstrap-navbar-example does not work with ng2-bootstrap: http://getbootstrap.com/components/#navbar The mobile menu is not collapsed when clicked.

navbar is not yet part of ng2-bootstrap, but planned to be added

valorkin any update?

Why has no attention been paid to issues regarding the navbar? Has development slowed down or something? Does anybody know of any alternatives to this framework that actually include basic features such as the navbar?

I was on vacation, we upgraded to ng2 final, now adding metadata for ng cli
compatibility, and tech requirements to all modules, in nearest time all
components will be rewritten
On Fri, Sep 23, 2016, 03:02 Colin Pirillo<EMAIL_ADDRESS>wrote:

Why has no attention been paid to issues regarding the navbar? Has
development slowed down or something? Does anybody know of any alternatives
to this framework that actually include basic features such as the navbar?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/valor-software/ng2-bootstrap/issues/188#issuecomment-249062684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk4x096iDj1N-D_aRQo0KRcsDwcRmXks5qsxcngaJpZM4HZ-xy
.

That's awesome! I look forward to trying it out, and thanks for the update.

What's the status of this? Examples from Bootstrap still do not work.

@coreboarder  https://github.com/valor-software/ng2-bootstrap/issues/540

hi .. i was able to fix this with this solution using ngStyle
<button class="navbar-toggler navbar-toggler-right"
type="button"
(click)="toggleCollapse()"
[attr.aria-expanded]="!isCollapsed"
data-toggle="collapse"
data-target="#navbar-navigation-menu"
aria-controls="navbar-navigation-menu">

.....

Same for me: I had to force the visibility of the menu as @alexinasra did, otherwise the menu doesn't get shown,

As a simpler workaround you can add this to your css:
.dropdown.open .dropdown-menu {   display: block; }

@alexinasra do you have a repo that you can share or something such as a jsbin?

@winnemucca please see https://github.com/valor-software/ng2-bootstrap/issues/540#issuecomment-272884775