Integrate In-Game Settings

Great job with a new mod.
Anyway, I figured out that the new command for inertia is FlightSettings.SetFloat("yawDirectionalityFactor", 700.0) so with "" and it still works but would it be possible to make it adjustable in a way? Native UI seems like a really convenient solution. I would be also happy even if you make an INI file where I can set it once and for all. Thanks in advance for a response. Great work with a new version anyway.

I'm working on this now - it'll work/look similar to how Native Settings does, but works on the backend through RED4ext, instead of through CET.

Ok, great. Thx a lot. It becomes a really, really cool mod with those thrusters, better controls, non-forced navigation and better UI. When UI errors are totally fixed and those flight settings become configurable - you are able to make it top 5 right behind CET, redscript and other frameworks :-D

would it be possible to make it adjustable in a way?

Until the menu is finished, you can open r6\scripts\let_there_be_flight.reds, search the followinng:
let yawDirectionality: Float = this.component.stats.d_speedRatio * FlightSettings.GetFloat(n"yawDirectionalityFactor");
and add your desired value minus 50 like so:
let yawDirectionality: Float = this.component.stats.d_speedRatio * FlightSettings.GetFloat(n"yawDirectionalityFactor") + 650.0 ;

would it be possible to make it adjustable in a way?

Until the menu is finished, you can open r6\scripts\let_there_be_flight.reds, search the followinng:
let yawDirectionality: Float = this.component.stats.d_speedRatio * FlightSettings.GetFloat(n"yawDirectionalityFactor");
and add your desired value minus 50 like so:
let yawDirectionality: Float = this.component.stats.d_speedRatio * FlightSettings.GetFloat(n"yawDirectionalityFactor") + 650.0;

Works great! I did not think of opening the .reds file with a notepad, haha. Something interesting to learn. Thanks a lot for that - literally solves all the issues I had with the current version of a mod. I mean, the UI bugs are still a thing but a minor one.

Happy to help :) This is my all time favourite mod so it's great to be a part of it.
To stop the UI from starting by default, see my comment here:

https://github.com/jackhumbert/let_there_be_flight/issues/31#issuecomment-1155610021
If you're talking about the floating glitch effect, search "glitch" and put a // at the start of every line that comes up. You may need something more better suited than notepad too see the lines clearer such as VScode

a //

Turning the UI off was quite simple but I do not really understand that part about glitching. I am referring a situation when the UI is off, even in driving mode, but the UI glitching starts on impact. This happens both in flight and on the ground. I can understand it happening with the UI on but when it's turned off - the glitching makes no sense and is extremely irritating :-P
However, I am nto able to understand this // thing at the beginning of every line where it comes up. Literally every line showing any result for a word "glitch" should start with // ? I am assuming that // marks a comment/label type of code, not the executable one so by doing that, I am turning the real code lines into a label/comment. Will it be fine with literally every line including a word "glitch"?

I am assuming that // marks a comment/label type of code

Yep that's correct, Try first by commenting this line like so  // this.PlayLibraryAnimation(n"glitch");

I am assuming that // marks a comment/label type of code

Yep that's correct, Try first by commenting this line like so  // this.PlayLibraryAnimation(n"glitch");

Sadly, it did not help. When I have a HUD off it still glitches out at impact on anything.

Sadly, it did not help. When I have a HUD off it still glitches out at impact on anything.

Are you using the latest code from the build/ folder on Github? I pushed a fix for the UI glitching last week, I think.

Sadly, it did not help. When I have a HUD off it still glitches out at impact on anything.

Are you using the latest code from the build/ folder on Github? I pushed a fix for the UI glitching last week, I think.

Yeah, you were right. Haha, sorry. I had one from 0.0.10. Now it works perfectly without glitching and I am still able to edit the jawdirectionality factor by adding +650 at the end :-D

Implemented with Mod Settings.


WebPack fails to bundle libraryTarget: 'amd'

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
with libraryTarget: 'amd' webpack fails with:
crypto.js:70
  this._handle.update(data, encoding);
               ^

TypeError: Not a string or buffer
    at TypeError (native)
    at Hash.update (crypto.js:70:16)
    at MainTemplate.<anonymous> (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/AmdMainTemplatePlugin.js:51:9)
    at MainTemplate.applyPlugins (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:61:14)
    at MainTemplate.updateHash (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/MainTemplate.js:219:8)
    at Compilation.createHash (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:1168:21)
    at sealPart2 (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:619:9)
    at Compilation.applyPluginsAsyncSeries (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:177:46)
    at Compilation.seal (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:579:8)
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compiler.js:514:17
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:271:11
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:481:11
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:452:13
    at nextTickCallbackWith0Args (node.js:489:9)
    at process._tickCallback (node.js:418:13)

If the current behavior is a bug, please provide the steps to reproduce.
git clone git@github.com:vladikoff/bug-webpack-fr783.git
cd bug-webpack-fr783

➜  bug-webpack-FR783 git:(master) ✗ node_modules/.bin/webpack --config webpack.config.amd.js
crypto.js:70
  this._handle.update(data, encoding);
               ^

TypeError: Not a string or buffer
    at TypeError (native)
    at Hash.update (crypto.js:70:16)
    at MainTemplate.<anonymous> (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/AmdMainTemplatePlugin.js:51:9)
    at MainTemplate.applyPlugins (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:61:14)
    at MainTemplate.updateHash (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/MainTemplate.js:219:8)
    at Compilation.createHash (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:1169:21)
    at sealPart2 (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:620:9)
    at Compilation.applyPluginsAsyncSeries (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:177:46)
    at Compilation.seal (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:580:8)
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compiler.js:510:16
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:271:11
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:482:11
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:453:13
    at nextTickCallbackWith0Args (node.js:489:9)
    at process._tickCallback (node.js:418:13)

What is the expected behavior?
➜  bug-webpack-FR783 git:(master) ✗ node_modules/.bin/webpack --config webpack.config.umd.js
Hash: 485bff494b2eb9fe637f
Version: webpack 3.0.0-rc.2
Time: 1111ms
    Asset     Size  Chunks                    Chunk Names
bundle.js  1.68 MB       0  [emitted]  [big]  thing
   [4] (webpack)/buildin/global.js 509 bytes {0} [built]
  [61] (webpack)/buildin/module.js 517 bytes {0} [built]
  [85] ./src/index.js 56 bytes {0} [built]
    + 151 hidden modules

Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
➜  bug-webpack-FR783 git:(master) ✗ node --version
v4.8.3
➜  bug-webpack-FR783 git:(master) ✗ npm --version
2.15.11

Does the same in Node 6 and 8

Node 8 stack:
➜  bug-webpack-FR783 git:(master) ✗ nvm use 8
Now using node v8.0.0-rc.0 (npm v4.5.0)
➜  bug-webpack-FR783 git:(master) ✗ node_modules/.bin/webpack --config webpack.config.amd.js
crypto.js:97
  this._handle.update(data, encoding);
               ^

TypeError: Data must be a string or a buffer
    at Hash.update (crypto.js:97:16)
    at MainTemplate.mainTemplate.plugin (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/AmdMainTemplatePlugin.js:51:9)
    at MainTemplate.applyPlugins (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:61:14)
    at MainTemplate.updateHash (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/MainTemplate.js:219:8)
    at Compilation.createHash (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:1169:21)
    at sealPart2 (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:620:9)
    at Compilation.applyPluginsAsyncSeries (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:177:46)
    at Compilation.seal (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:580:8)
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compiler.js:510:16
    at /Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/node_modules/tapable/lib/Tapable.js:271:11
    at _addModuleChain (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:482:11)
    at processModuleDependencies.err (/Users/vladikoff/dev/bug-webpack-FR783/node_modules/webpack/lib/Compilation.js:453:13)
    at _combinedTickCallback (internal/process/next_tick.js:74:7)
    at process._tickCallback (internal/process/next_tick.js:105:9)

This is a bug.
This line need to be changed:
https://github.com/webpack/webpack/blob/master/lib/AmdMainTemplatePlugin.js#L51
 		mainTemplate.plugin("hash", (hash) => {
 			hash.update("exports amd");
-			hash.update(this.name);
+			if(this.name) hash.update(this.name);
 		});

Do you want to send a PR?

Sure, give me a few

@sokra Hm the suggested fix is not good.
I think the cause of the problem is using an array here: https://github.com/vladikoff/bug-webpack-fr783/blob/master/webpack.config.amd.js#L10 . The output.library property.
In my case I use       library: ['MyCoolLibrary', '[name]'], where name gets generated from multiple entries


Plugin stopped working with 2.15.0-b1

I have upgraded PIWIK to 2.15.0-b1 as there was fix released for Scheduled report. However, IntranetGeoIP plugin stopped working. After checking PHP log, its giving below error. Could you please help in resolving it.
[26-Aug-2015 09:35:34 UTC] PHP Warning: Parameter 1 to Piwik\Plugins\IntranetGeoIP\IntranetGeoIP::logIntranetSubNetworkInfo() expected to be a reference, value given in C:\piwik\core\EventDispatcher.php on line 141
[26-Aug-2015 09:35:34 UTC] PHP Stack trace:
[26-Aug-2015 09:35:34 UTC] PHP 1. {main}() C:\piwik\piwik.php:0
[26-Aug-2015 09:35:34 UTC] PHP 2. Piwik\Tracker->main() C:\piwik\piwik.php:67
[26-Aug-2015 09:35:34 UTC] PHP 3. Piwik\Tracker->track() C:\piwik\core\Tracker.php:98
[26-Aug-2015 09:35:34 UTC] PHP 4. Piwik\Tracker\Handler->process() C:\piwik\core\Tracker.php:121
[26-Aug-2015 09:35:34 UTC] PHP 5. Piwik\Tracker->trackRequest() C:\piwik\core\Tracker\Handler.php:49
[26-Aug-2015 09:35:34 UTC] PHP 6. Piwik\Tracker\Visit->handle() C:\piwik\core\Tracker.php:139
[26-Aug-2015 09:35:34 UTC] PHP 7. Piwik\Tracker\Visit->handleNewVisit() C:\piwik\core\Tracker\Visit.php:160
[26-Aug-2015 09:35:34 UTC] PHP 8. Piwik\Piwik::postEvent() C:\piwik\core\Tracker\Visit.php:274
[26-Aug-2015 09:35:34 UTC] PHP 9. Piwik\EventDispatcher->postEvent() C:\piwik\core\Piwik.php:694
[26-Aug-2015 09:35:34 UTC] PHP 10. call_user_func_array:{C:\piwik\core\EventDispatcher.php:141}() C:\piwik\core\EventDispatcher.php:141

@jagdish-nasit i havent checked the 2.15 tags until yet.
But it seems the current used method is deprecated
https://developer.piwik.org/api-reference/events#trackernewvisitorinformation
http://developer.piwik.org/guides/dimensions
I will try to look into it asap, until the release you have to downgrade or create a fix for it.

@jagdish-nasit please upgrade to the latest beta, there it should be fixed
https://github.com/piwik/piwik/blob/2.15.0-b1/core/Tracker/Visit.php#L274
https://github.com/piwik/piwik/blob/2.15.0-b8/core/Tracker/Visit.php#L283

Sure, let me upgrade and revert back.

@jagdish-nasit please read the the 2nd comment. Its solved in the latest beta of 2.15...
Was not an issue of this plugin

@ThaDafinser I have upgraded to the latest version and its working fine now.
Thanks for helping !!!


Text becomes invisible if event listener is attached to imageView in the drawer

I thought it was a problem with the collectionView in iOS, but after further testing, I determined that when I attach a longpress listener on an imageView in the drawer, the text in every widget disappears. My workaround was to create a Composite widget in the drawer, put the imageView in that, and attach the listener to the Composite widget instead of the imageView.

@jeffmikels can you share a snippet reproducing the issue?


feat(rustfmt): replace configs for new rls-rustfmt

#34
The rustfmt.toml file had mostly defaults, with a few exceptions. Some of those options don't exist anymore but I tried to find the exceptions and turn them on.
rls.toml has been deprecated (https://github.com/rust-lang-nursery/rls). We're meant to either make what seems like an editor specific project file (the main readme mentions settings.json for vscode) or leave it empty.
Thankfully, the option you have turned on workspaces_mode defaults to true, so I don't think we need to do anything.

I took a look at the rustfmt.toml from hawkw/sos-kernel and put some of the options you have there in alarm's rustfmt.toml also. If you're happy with this configuration it may be worth it to have the same file in both projects.

@leshow, this looks good to me with the following additional requests (a majority of which are git style):

can we merge this with the commit message "chore(rustfmt)" rather than "feat(rustfmt)", since this change doesn't add any new features that should show up in changelog?
please add "Fixes #34" or "Closes #34" to the commit message, thanks!
have you invoked Rustfmt with the changed config? if you have, and there were any changes to the source code, can you commit those as well? that way, future commits won't merge as many unrelated formatting changes.

Thanks!

Quick note, the old line limit was defaulted to 80, the new rustfmt line limit appears to be 100. That's the reason for a few of the changes to the src files. Let me know if you'd like to alter the char width limit and I'll re-run rustfmt

@leshow I have a reasonably strong personal preference for 80 column lines, so I'd prefer to see lines wrapped at the 80th column. However, I'm not so attached to this that I'm unwilling to negotiate if a majority of contributors prefer 100 column lines. 🙂
I noticed that this diff also removed whitespace between trait items (e.g. function defs), and modified the licence header comments in some files. I'd prefer not to make those changes if rustfmt still has appropriate config options for this.

Sorry for being so finicky about code style; if you'd prefer, I can also go ahead and merge this PR, and make additional rustfmt changes later.

No problem at all.
I don't have a strong opinion about char widths so long as it's legible. 80 is fine with me. All I can see w/ license headers is it removing a blank character after a comment in one file.
As for the new line between trait and function defs (I hope we're talking about the same thing). I've gone through their configuration doc a few times and the closest thing I can find is a blank line upper and lower bound, however the number is global so it won't be restricted to space in between traits.
The config options have been drastically reduced since about a year ago when I last looked at rustfmt's options.
https://github.com/rust-lang-nursery/rustfmt/blob/master/Configurations.md#blank_lines_upper_bound

The config options have been drastically reduced since about a year ago when I last looked at rustfmt's options.

Yeah, that's why the current config file raises so many warnings. :/
If those things aren't easily configurable, I'm going to go ahead and approve this PR now, and maybe take a closer look at the Rustfmt config options later.


Elements change when clicking in one

Describe the bug
The text and image of the code change when cliking in an item
To Reproduce
Steps to reproduce the behavior:

Add a third Feed, mine CBS
Click in one item big or small
See error

Screenshots
https://github.com/msasikanth/twine/assets/71900639/e18f3257-7a74-491d-949b-5e615e1a9a38
Device Information

Device: Samsung Galaxy A23 5G
OS: Android 14
App Version 1.31.0

I see you are in the unread mode, in this case, if you open a post that post is marked as "read" and removed from the list. So, technically it's working as expected.
But it looks like it is taking a second or two to open the browser, so the post removal is more noticeable. In settings, you can change the app to open an in-app browser which should be quick. I am also working on reader mode which should make it not noticeable in future updates.
Closing the issue for now, since it's not a bug.


Fix/scrollbars

Coverage increased (+0.4%) to 45.69% when pulling 2e672c800f9d230e4e90b65cdd8b8923b099dac5 on fix/scrollbars into a1d7bf3ad8c3e88f4a557e03a927afce5a3ee05d on master.


Upgrade AWS-SDK from v2 to v3

Need to update AWS-SDK from version 2 to 3
After migration:

aws-sdk should be excluded from build (via esbuild externals).  It's only included because node 20 lambdas don't already include v2 anymore, only v3.

Also

WebSocket not part of aws-cdk-lib yet. Need to add alpha library -<EMAIL_ADDRESS>Bootstrapping (https://docs.aws.amazon.com/cdk/v2/guide/bootstrapping.html) - AWS CDK v1 supported two bootstrapping templates, legacy and modern. CDK v2 supports only the modern template. An environment that has been bootstrapped using the legacy template can (and must) be upgraded to use the modern template for use with CDK v2 by re-bootstrapping. So once the first project is redeployed for a given region, we may not be able to make code changes to other projects without upgrading as well.

dynamodb examples - https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/javascriptv3/example_code/dynamodb/actions/scan.js

It's import to use the DocumentClient wrapper because it allows you to use natural javascript types

https://stackoverflow.com/questions/57804745/difference-between-aws-sdk-dynamodb-client-and-documentclient
https://stackoverflow.com/questions/57804745/difference-between-aws-sdk-dynamodb-client-and-documentclient
Examples of use - https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/javascriptv3/example_code/dynamodb/actions/document-client/scan.js


Not working. Rendering all the items

Virtual scroll renders all the items from the list. here is my repo to reproduce
https://github.com/sanjaybhaskar/virtual-scroll

Just three line you need to add.
recent.component.ts - >
constructor(r: Router, public dataService: DataService,private apiEvent: ApiEvent,               private  mdlLayout:MdlLayoutContentComponent){     this.router = r;     let rlcmodel = new rlcModel();     this.rlcObject = rlcmodel.rlcObject;   }
recent.component.html ->
<virtual-scroll [items]="rlcObject" (update)="viewPortItems = $event"                 [childHeight]="72"                 [ngStyle]="{'height.px':mdlLayout.el.offsetHeight}">     <mdl-list>         ......
recent.zip
Specify the height of VirtualScroll, and it's childHeight to make it work. :)

I had a similar issue, however the proposed solution wasn't working for me.
My scenario is I have a flexbox with a percent height that the virtual scroll is intended to fill the remaining space of (has a some form elements above it).  I could nest flexboxes in to get the virtual scroll to take the remaining height, but that only worked in Chrome and not IE11 and FF.
My virtual scroll is wrapped by another component (represented by the inner div below).  Essenetially what ended up working for me (and remain pure CSS) was to lose the nested flexbox I had been using  to get the nested component/virtual scroll to fill the height (but only worked in Chrome).
From:

  <input type="text" style="flex:none">

    <virtual-scroll style="flex:auto">
    </virtual-scroll>

To:

  <input type="text" style="flex:none">

    <virtual-scroll style="position:absolute; height:100%; width:100%">
    </virtual-scroll>

Closing since there are proposed workarounds & this is most likely user error due to not following the documentation properly, since it's working for most users. Please re-open if you continue to experience problems.


Add cookie with Windows.Web.Http.HttpCookieManager does not work on Server 2019 with IE Enhanced Secuirty Configuration set to true

Describe the bug
A customer reported a network issue. He is using Windows Server 2019, build 17763. After hours of debugging, I found out that the it's because of the default settings of enhanced IE security is set to true, and therefore all cookies were not sent. After disabling that setting, the issue was resolved.
Steps to reproduce the bug

Open Server Manager
Set enhanced IE security to true
Use this code

    winrt::Windows::Web::Http::Filters::HttpBaseProtocolFilter filter;
    winrt::Windows::Web::Http::HttpCookie cookie; //Set cookie as needed
    filter.CookieManager().SetCookie(cookie);
    winrt::Windows::Web::Http::HttpClient client{filter};
    client.SendAsync(...); //Send a request

Run and capture the traffic with something like fiddler, observe the cookie in the header

Expected behavior
This setting should not affect apps using WinRT apis, otherwise should be clearly documented
Screenshots
No response
NuGet package version
Windows App SDK 1.4.4: 1.4.231219000
Packaging type
Packaged (MSIX)
Windows version
Windows 10 version 1809 (17763, October 2018 Update)
IDE
Visual Studio 2022
Additional context
Server2019 17763

This is a Windows API, not a WinAppSDK one.  Please log an issue on Feedback and it will be directed to the correct team.  Thanks!


feat: add truffle dashboard

Hi @alvaroserrrano, thanks for your PR. Could you explain your rationale for why it would be worth it to add the Truffle dashboard in this Solidity template?
The template is heavily based on Hardhat, which can't be used alongside Truffle - or rather it would be best to not use it alongside Truffle because things could break apart.

Sure. After seeing this announcement, I saw that the dashboard is tool-agnostic and I thought that it might be helpful to be added to the template. The reason for that is that new developers will eventually get more interested about Solidity programming and, given that this template is one of the most complete, we could prevent human mistakes copy-pasting private keys, uploading to open source by mistake...
Let me know what you think after checking out the article, although I also understand your view and agree with your point of making it Hardhat-oriented

@alvaroserrrano There are likely enough truffle based templates out there.
So I would suggest truffle users go with one of them, and not bloating up a hardhat template.
Nobody wants 2 frameworks in one repo with the risk that things blow up. That would be time consuming for experts and not possible to handle for new developers.

I can see your point. Perhaps it is better to keep that vision for this project. Feel free to close the PR 😉 , there is nothing wrong with that on my side. This template is already very complete, good work on that. I will try to come up with more constructive PRs 😄


python311Packages.hahomematic: 2023.8.9 -> 2023.8.10

Diff: https://github.com/danielperna84/hahomematic/compare/refs/tags/2023.8.9...2023.8.10
Changelog: https://github.com/danielperna84/hahomematic/releases/tag/2023.8.10
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251320 run on x86_64-linux 1

2 packages built:

python311Packages.hahomematic
python311Packages.hahomematic.dist


[QUESTION] Is it possible to remove the default options (--install-completion, ..) in a typer based CLI?

First check

[x] I used the GitHub search to find a similar issue and didn't find it.
[x] I searched the Typer documentation, with the integrated search.
[x] I already searched in Google "How to X in Typer" and didn't find any information.
[ ] I already searched in Google "How to X in Click" and didn't find any information.

Description
Is it possible to remove the default options (--install-completion, ..) in a typer based CLI?
By default we always have the options --install-completion and --show-completion when using typer:
python main.py --help
Usage: main.py [OPTIONS] NAME LASTNAME

Arguments:
  NAME      [required]
  LASTNAME  [required]

Options:
  --install-completion  Install completion for the current shell.
  --show-completion     Show completion for the current shell, to copy it or customize the installation.
  --help                Show this message and exit.

Is it possible to hide that? In case an End User is not familiar with Typer or we are using a non-supported shell (ksh) those options could be confusing/distracting.
Additional context
Question has been asked on stackoverflow as well.

This works but requires using the Click app. Not sure if there's a better solution.
import typer

app = typer.Typer()

@app.command()
def main(name: str):
    typer.echo(f"Hello {name}!")

cli = typer.main.get_command(app)
cli.params = [
    param
    for param in cli.params
    if param.name != "show_completion" and param.name != "install_completion"
]

if __name__ == "__main__":
    cli()

@hellowhistler: Thanks for your answer! Might not be the cleanest solution but at least it works!

I found a better solution, I met the same problem today,i couldn't find anything except this issue and the Stackoverflow question mentioned above,  so dived in the source to find how Typer automatically adds this two options in app, so i found this, when Typer initialiazing itself it automatically sets add_completion to True
class Typer:
    def __init__(add_completion: bool = True)

So when you initialiazing your app you can add this
app = typer.Typer(add_completion=False)

This is how it looks after you add add_completion=False
Usage: main.py [OPTIONS] COMMAND [ARGS]...

Options:
  --help  Show this message and exit.

Thanks for the help here @ycd ! :clap: :bow:
Thanks for reporting back and closing the issue :+1:

Shouldn't this be in the docs?

Note that when you set  add_completion=False Typer does not invoke typer.completion.completion_init(). This causes the original Click completions to run by default.


bitbucket-server-post-build-status 0.0.13

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[ ] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tieme van Veen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.
step.yml changes compared to previous version:
--- steps/bitbucket-server-post-build-status/0.0.12/step.yml	2022-06-14 08:08:53.000000000 +0000
+++ steps/bitbucket-server-post-build-status/0.0.13/step.yml	2022-06-14 08:08:54.000000000 +0000
@@ -7,8 +7,8 @@
source_code_url: https://github.com/teameh/bitrise-step-bitbucket-server-post-build-status
support_url: https://github.com/teameh/bitrise-step-bitbucket-server-post-build-status/issues
-published_at: 2021-11-12T17:41:22.424761+01:00
+published_at: 2022-06-14T09:58:53.464212+02:00
source:
git: https://github.com/teameh/bitrise-step-bitbucket-server-post-build-status.git

commit: 1d7dd9fc055a80b976d89fdab9943b2c293d7387

commit: 08702dc3d799b8671b47078e328cb21518a8de4a
host_os_tags:

osx-10.10

What is wrong here?

Re-pushed with right email for author for CLA

@teameh
Don't forget to follow [semantic versioning]...: nothing is wrong here, this comment is added for every PR. I see why it could be misleading tough.


Added basic descriptions for missing items.

Added missing descriptions. They are really basic

You've added a bunch of empty columns to the CSV files, which isn't gonna work.

Oops. Used LibreOffice to edit these files.

The change on Gale wings and Parental bond occured in gen VII

We should probably add a changelog entry, then:
https://github.com/veekun/pokedex/blob/master/pokedex/data/csv/ability_changelog.csv
https://github.com/veekun/pokedex/blob/master/pokedex/data/csv/ability_changelog_prose.csv

There's a lot of changes on abilities and moves.
More on that subject here: https://pokemondb.net/pokebase/270531/what-are-all-the-nerfs-and-buffs-in-pokemon-sun-and-moon

And some Items changed as well.
Super Potion, Hyper Potion, Rage Candy Bar

Ah, thanks for the link. I only mentioned Parental Bond and Gale Wings because those seem to be the only two abilities updated in the PR.
The other changes look good. I'm happy to merge the PR if you add changelog entries for Parental Bond and Gale Wings. You could also revert those two changes and open a new PR for them.  (And if you wanted to update some of the other moves and abilities that would be fine too 😁 )


Avoids nil pointer dereference

This should avoid our nil pointer dereference we found this morning.  We're attempting to update the status when we cannot get the accountclaim object, so therefore it's probably always nil here.

/hold


Update displayed options

I needed to change the selections in a multiselect programatically.
As far as I'm aware, the plugin doesn't support that - this adds a perhaps-poorly-named 'update' method that just re-processes all the options to be sure they're displayed correctly.

If you want a different name, perhaps "reload" would be an option.

I think the new jQuery UI stuff is using "refresh" as the term. Can you updated it to "refresh" and I'll pull it?

Sounds great. I should be able to hit that right now, actually...
-Nate
http://www.ishness.net - simple is better.
On Nov 18, 2011, at 6:20 PM, Christopher Deutsch wrote:

I think the new jQuery UI stuff is using "refresh" as the term. Can you updated it to "refresh" and I'll pull it?

Reply to this email directly or view it on GitHub:
https://github.com/crdeutsch/multiselect/pull/6#issuecomment-2795741

Embarrassing mistakes, take 2:
I just noticed that I renamed the wrong update function - this patch renamed an internal update method that shouldn't have been touched at all.
I'll push up a patch to fix this, and again, apologies for the (yet again) untested change. You'd think I'd have learned my lesson...


General update of the text.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Some of the content of the readme is autogenerated so from other parts of the repository so you might have to edit other files, I'll let @mandopaloooza comment on that though.

Some of the content of the readme is autogenerated so from other parts of the repository so you might have to edit other files, I'll let @mandopaloooza comment on that though.

Sure - can do if I know what/where.

Also updated text based on @thomascellerier 's comments about 'new' etc.


[Service Connector] az containerapp connection create containerapp: Support ACA2ACA connection

Related command
az containerapp connection create containerapp --source-id  --target-id  --client-type   --container
az containerapp connection create containerapp --rg  --name  --tg  --target-app-name  client-type  --container
Description
This PR is to support ACA2ACA connection CLI. Auth info is not needed in this scenario.
Testing Guide
az containerapp connection create containerapp --source-id  --target-id  --client-type  --container
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Service Connector


Adding automatic mixed precision training support - RNN and Relational Memory Core examples

Automatic Mixed Precision training on GPU for Tensorflow has been recently introduced:
https://medium.com/tensorflow/automatic-mixed-precision-in-tensorflow-for-faster-ai-training-on-nvidia-gpus-6033234b2540
This PR adds GPU automatic mixed precision training to sonnet RNN and Relational Memory Core examples via setting a single OS flag:
export TF_ENABLE_AUTO_MIXED_PRECISION=1

Alternatively, it can also be enabled by directly calling the example with an appropriate flag:
python sonnet/examples/rnn_shakespeare.py --gpu_auto_mixed_precision
python sonnet/examples/rmc_nth_farthest.py --gpu_auto_mixed_precision

@vinhngx would you running pylint over your code. In particular I think it will complain since lines are not within 80chr and you're mixing " and ' in the same file (c.f. https://google.github.io/styleguide/pyguide.html).
@lorenrose1013 mind taking a look at this patch too?

BTW if there are more AMP patches to come it might be worth discussing details over email (we are currently working on AMP with Sonnet 2 and TensorFlow 2). My work email is my github username @google.com if you want to discuss that.

LGTM pending lint fixes

@tomhennigan @lorenrose1013 thanks for your guidance. I've fixed the lint errors.
As I've got time to go through more sonnet examples, I might make more AMP patches available, e.g. rmc_learn_to_execute next.
I'd like to break this down into a series of bite-sized chunks so that it's easier to implement, test and  digest.

@tomhennigan @lorenrose1013 any additional comments you'd like to add?

Hey @vinhngx, sorry it took us so long to get back to you here. We have been very focussed on Sonnet 2 and V1 is largely frozen at this point. I'm going to close out this PR.
FWIW for future readers we do have experimental FP16 mixed precision support in Sonnet 2 https://sonnet.readthedocs.io/en/latest/api.html#module-sonnet.mixed_precision.


Keybase client on macOS displaying an error when I click on "chats"

I opened Keybase today and was greeted with a screenshot similar to the below. I submitted my logs with keybase log send, restarted Keybase, and then saw this same error screen when i clicked on "chats"
my log id: ce0cd23012d63402c9c9bc1c

@shoenseiwaso Try completely quitting Keybase (from the menu bar) and restarting it, it seems like you have a version mismatch between parts of the app.

@mmaxim I did! That screenshot is from after I "Keybase > Quit Keybase completely" and restarted.

 First I quit keybase, then in the terminal I ran:
% ps aux | grep -i keybase
jeffwilliams      2859   8.6 16.5  7637520 2763268   ??  S     6Apr20  18:39.94 /Applications/Keybase.app/Contents/SharedSupport/bin/keybase -d --log-file=/Users/jeffwilliams/Library/Logs/keybase.service.log service

% kill 2859

After this, I started Keybase again and everything is happy. So it seems the upgrade left an old service running?

Yeah my next suggestion was going to be to reboot to effectively do what you
just did. We are trying to track this down, for some reason an old service can get stuck here and be out of sync with the new UI. Sorry for the trouble, and glad you are back in business.


Memcached Web site has insecure .tar.gz download link - Firefox refuses to download it

Firefox (and maybe other browsers?) cannot download the memcached tarball for the 1.6.19 release because the .tar.gz link on https://memcached.org/ is to http://www.memcached.org/files/memcached-1.6.19.tar.gz (an insecure download link cannot be downloaded by Firefox on a secure page).
Firefox's download dialogue pop-up actually displayed this in red:
"File not downloaded: Potential security risk - memcached.org"
It also dubiously left a zero-length memcached-1.6.19.tar.gz on the filestore (which I think is simply a bug that Firefox doesn't clean up itself properly). I then edited the download link to be
https://www.memcached.org/files/memcached-1.6.19.tar.gz and it downloaded fine with Firefox.
I'm using AlmaLinux 8 and Firefox 110.0.1 - apologies if this is the wrong place to report the issue...

Wow, I'm super sorry. I fixed that in a bunch of places but looks like I missed one on the website and one in the release notes. (ie; if you click into downloads from the top tab it was correct). Not sure how it took this long to get reported!
That's fixed now.


[BUG] Navbar is not fixed on top

Describe the bug
The bug is that the navbar is not fixed on top for better user experience.
To Reproduce
Steps to reproduce the behavior:

Go to Home page
Scroll down
See the navbar is not visible

Expected behavior
The navbar should be fixed on top.
Screenshots

Desktop (please complete the following information):

In every device it would happen.
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

In every device it would happen.
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Every website in which I raised this issue they considered so please you might also consider to assign me. Thank you

@aryadevesh go for it


Block joins from accounts that are less than a few days old

Server Insights shows that this is a very small percentage of legitimate new joiners, and many of the scambots that have joined recently have been new accounts. This should put a damper on that.
There should also be a message explaining this for the few legitimate users who will be affected by this, maybe with links to other community Discords for them to bide their time.

This being implemented is contingent on me figuring out why join events aren't being tracked correctly. I have the intents for this enabled.

Unsure if this is still applicable with KupoBot in use.


Using the SDK in a Swift Project with Cocoa Pods

Per the setup instructions in the common error section I'm getting the error:
undef: _utf8_nextCharSafeBody
Undefined symbols for architecture x86_64:
    "_utf8_nextCharSafeBody", referenced from:
    _validate_dispatch_data_partial_string in watsonsdk(SRWebSocket.o)
 ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I am also using Pods to install some other frameworks to use, is the install different for Pod based project vs non pod based project? Or maybe there is some trick to use it with Cocoa Pods?

This may help https://www.ng.bluemix.net/docs/starters/mobilefirst/gettingstarted/existingproject.html#setup_sdk_cocoapods

Thanks, problem was related to my build settings. Make sure to have i386 and x86_64 in your valid architectures.


Network file loading is very (seriously very) slow

This is a great library! But remote files are painfully slow to load. Is it possible to let file start playing before the whole file is downloaded?

The project on iOS uses AVAudioPlayer (instead of AVPlayer) which explains why the audio takes long to load from the network, and instead attempts to download the whole audio file before playing (which can be indefinite).
You can use react-native-audio-toolkit however it's lacking a maintainer currently and a few odd crash bugs on Android.

This is serious issue, beside slow loading, if I want to render several files one after another, sometimes, the sound isn't even loaded, then the next one is and so on. Also annoying thing is after I call stop() function, the sound repeats itself, and stops after approximately one second. So I must use not so good workaround with setVolume(0.0) so the second time is muted...
Anyone had experience with some sites where sounds eventually get loaded instantly? I use github to upload my audio files, but there is always a gap from 1.2 to 1.7 seconds between WillMount and actual loading the audio file.


[Feature] It awesome :)

Hi, script is outstanding, but can it be like some other extension already placed in UI rather than under scripts, for example like in those in green frame?
This will unblock other scripts to use together

Got it!

Thank you :)

Ok, now it is in dropdown list, but it seems that stopped working
Windows,Firefox
Commit hash: c98cb0f8ecc904666f47684e238dd022039ca16f
--xformers --api --listen --enable-insecure-extension-access

I think it should have a switch like in the save intermediate extension to turn on and off

Yes stopped working because now it does not get invoked, it needs a trigger for that. Have a look at this extension and how they have it solved:
https://github.com/fkthebez/Animetard

Hi friends :) Just came back from holiday to see what's wrong, now I understand...
For a AlwaysVisible extension, webui only gives us four hooks: process(), process_batch(),  postprocess_batch() and postprocess(), which surrounds the core code of process_images_inner().
However, this progressive hires.fix needs to take control of that part in order to make the procedure iterative. This requires the run() hook which only works for extension in the dropdown list. 🤔
So currently it cannot be AlwaysVisible, I have to just roll everything back :)

Hi, any chance in the future to have it in the dropdown?

🤔 seems not possible, unless this mechanism is implemented in the webui core, rather then a wrapper script.
(This might also be why the original hires.fix is still coupled in the core and could not be separated out as a pluggable

Have forgot this thread so long...
Now it can work in two morphs, switching by a local config,
So might have solved the issue 🤔, now temporarily close it.


On id: What happened most recently and for recent_incident_children should the names of the children entered be selectable?

@stavros-0 this isnt working right yet in most recent commit


Cf 796 validation for container name

@shintasmith @usnavi @ChandraAddala
Please review, for story https://jira.rax.io/browse/CF-796, to throw 400 if users submit preference with bad container names.
I am uncertain whether we want to do a negative test for invalid characters, or test for only valid characters, which I am also uncertain if they're just limited to ALPHANUMERIC, '.', '-', and '_'
Current implementation is with negative test for invalid characters.  What do you guys think?

Have you taken a look at http://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/UrlValidator.html  ?  I've never used it, but figured it might help us out.

It might.  That validates the whole URL, is it applicable to our case of just validating the container name?
Maybe I should just email Cloud Files or Reach to get the exact rule for what can be in a container name.

I think it should be good for us to validate the full URL. Eventually, Tiamat is going to use the full URL, not just the container name. The goal is to prevent Tiamat getting an error because Cloud Files rejects the URL.

@VinnyQ I found this in their docs
The only restrictions on container names is that they cannot contain a forward slash (/) and must be less than 256 bytes in length. Note that the length restriction applies to the name after it has been URL-encoded. For example, a container name of Course Docs would be URL-encoded as Course%20Docs and is therefore 13 bytes in length rather than the expected 11.
http://docs.rackspace.com/files/api/v1/cf-devguide/content/Containers-d1e458.html

@usnavi @shintasmith @ChandraAddala
Please re-review.  Rewrite the validation to just use apache common UrlValidation for now, to validate the complete URL.

lgtm, I will let @ChandraAddala or @usnavi re-review and merge

Please do not merge yet.  After discussing with the team, we want to add validation of the container name length, '/' and, '?' .  We are ok with hardcoding the regex of obtaining the container name as [http
|https]://hostname/v1/nastId/containerName.

@VinnyQ @usnavi  I think this logic would work

Grag container name from url using regex
Decode the container name and compare with original
if they are not same, which means container name is already  encoded and we are good.
if they are same, encode the original container name.
if the encoded container name is different from the original, return error saying that the url submitted has to be encoded. If it is same, we are good( Ex: container name of say normal text like "tom" would be okay. but "tom sawyer" would fail)

If you want to really do it to the core level, we may have to replicate the code in isPchar() method in the below code.
https://github.com/spring-projects/spring-framework/blob/master/spring-web/src/main/java/org/springframework/web/util/HierarchicalUriComponents.java

My understanding of what we need to do:

run the apache url validator to determine that there are are no invalid characters
verify that the URI is < 256
Cloud Files has the additional restrictions that at least ? # / end the container name, ignoring the rest of the characters.  Super lame from our perspective.  We'll need to ensure that these don't exist in the container, even if they are at the end.

Are there other Cloud Files restrictions?
I assume the encoding/decoding step duplicates step 1).  We don't need to do both.
Does that sound right?

@VinnyQ @shintasmith - see @ChandraAddala  and I's comments above.

@usnavi Only encoded container name has to be of length < 256
"Cloud Files has the additional restrictions that at least ? # / end the container name" Is this documented somewhere? As far as I know, its only this character "/".

@ChandraAddala  - @VinnyQ  & I have verified this behavior for ? # / with curl.

@usnavi @VinnyQ
The chars shown in the below code are the only allowed characters in a path segment of an URI aparently as per the spec. In my opinion any chars other than these should be thrown back as error indicating that the url has to be encoded. (I am sure you guys checked all the special chars but I have doubts that these following chars will cause problems. ':'  '/'  '?'  '#'  '['  ']'  '@')
protected boolean isPchar(int c) {
	return isUnreserved(c) || isSubDelimiter(c) || ':' == c || '@' == c;
}

protected boolean isUnreserved(int c) {
	return isAlpha(c) || isDigit(c) || '-' == c || '.' == c || '_' == c || '~' == c;
}

protected boolean isSubDelimiter(int c) {
	return '!' == c || '$' == c || '&' == c || '\'' == c || '(' == c || ')' == c || '*' == c || '+' == c ||
			',' == c || ';' == c || '=' == c;
}

@usnavi @shintasmith @ChandraAddala
And done.  Latest (and hopefully final) decision, users must url encode any special chars in the container name, and can't have '/' literal or encoded anywhere in the name (literal trailing slash is ok and stripped if present).
I added validation to check for that, and also to make sure container name exists and not longer than 255 bytes.
Please review and merge if lgtu

@ChandraAddala @usnavi Please review, modify decoding to use URI.getPath() instead of URLDecoder.

Here's a few more link about URI encoding in java (basically they all mention using URLEncoder with post processing'.
http://stackoverflow.com/questions/607176/java-equivalent-to-javascripts-encodeuricomponent-that-produces-identical-outpu
Note how the voted up solution is a class they wrote on their own using urlencoder.
Here's an article about what chars are safe and unsafe:
http://alvinalexander.com/blog/post/java/how-encode-java-string-send-web-server-safe-url

and here's another that does the same with using getPath() to decode but using URLEncoder to encode and replace '+' in the result with '%20'
https://play.lighthouseapp.com/projects/57987/tickets/827-urlencoder-used-for-encoding-but-urigetpath-for-decoding

I am going to try using the Spring UriUtils toolset to make the code cleaner and more precise:
http://docs.spring.io/spring/docs/3.0.x/javadoc-api/org/springframework/web/util/UriUtils.html
p.s.  I tried out the URI. toASCIIString() method and it doesn't do any encoding.  e.g. "http://yomama.com/some!crazy$face+path" stays as "http://yomama.com/some!crazy$face+path" when doing:
import java.net.URI
val uri = new URI("http://yomama.com/some!crazy$face+path")
println("uri: " + uri.toASCIIString())

>>> uri:  http://yomama.com/some!crazy$face+path

@ChandraAddala @usnavi
Ok, I redid the validation using the spring framework UriUtils to do the decoding and encoding.
All is good now, with the exception that we are disallowing users to use valid hex encoding the valid chars that don't need it.
e.g. url with encoding ~!@$ etc will return 400...
e.g.
{
  "enabled" : true,
  "data_format" : [ "JSON", "XML" ],
  "default_archive_container_url" : "http://storage.stg.swift.racklabs.com/v1/Nast-Id_1/FeedsArchives/Feeds%21Container"
}

returns 400
(%21 is the hex encoding for '!')
However, a literal '!' is allow:
{
  "enabled" : true,
  "data_format" : [ "JSON", "XML" ],
  "default_archive_container_url" : "http://storage.stg.swift.racklabs.com/v1/Nast-Id_1/FeedsArchives/Feeds!Container"
}

I can't catch the case with the valid hex encoding in the container name because UriUtils does not encode the valid special chars of path fragment such as "!@$" back to the hex encoding.
Please review and let me know if this is ok.

on the web, encoding unreserved characters is discouraged and results in different behavior based on the implementation.  I think we are ok here.

lgtm - @ChandraAddala can review & merge.

@VinnyQ I submitted a PR against your branch. It should handle all the scenarios. If you find some other scenario other the ones in your tests, let me know.
https://github.com/VinnyQ/cloudfeeds-preferences-svc/pull/1

This is good.
@usnavi  please merge if you agree!


Fix setup.py errors/warnings on py3.4

pip install on py34 yields non-fatal warnings. This should also help with linux disto packaging efforts (e.g. Debian Jessie that has 3.4) without patching the sdist.

If you can amend your commit according to my suggestions, that's helpful.
Otherwise I can take care of making the changes myself. Let me know.

Merged with minor changes in 992fc3a2794301ca4dbb94f9ce7801a4515e997d. Thanks!

@RemiCardona I'm not sure how much trouble this issue causes. Does it warrant a new release to PyPI?

Hello @aaugustin,
We do not need a new release since the code is patched at packaging time.
Thanks for your merge !

No particular rush here, feel free to release whenever you see fit. Thanks for the merge!


Simplify code by using Message where applicable

Also:

remove all direct references to Nanopb-generated foo_bar_fields arrays;
minimize references to Message<T>::fields() (only in MakeFoo functions now);
remove FreeNanopbMessage function (it would now only be called from Message's destructor, which now instead calls pb_release directly).

Closing for inactivity. Please reopen to continue.


Missing icon

👋🏼 Hi there! I'm trying to find the refresh icon, but it doesn't seem to exist in the library, or at least I can't find it. Is it possible to add it? Do you accept PRs?
Thanks in advance 🙌🏼

Hello!
refresh has been renamed to arrow-path and you can find it at Heroicons.arrow_path/1.
For what it's worth, http://heroicons.com/ is a better up-to-date resource for Heroicons. I find that https://heroicons.dev is out of date...


Not working on turbo anymore :(

Hey there, the server-cli-only isn't working with dev --turbo anymore. It always throws.

Hi @markomitranic,
Thank you for reporting. I created a new branch to investigate, added an example Next.js project, and tested Next.js with next dev --turbo. I don't have any issues using Turbopack. Everything works as expected.
Can you further describe your issue? Some error output (in a Gist) would be helpful.
Maybe also look at my example project and re-check at your end.

Hey @4lm thanks for the response!
True, perhaps I am using it wrong in some way. I have been using it since you released it without any issues up until recently. I will fork the example and try to open a PR with a reproduction :)

@4lm I just did a tiny bit of additional testing, it would seem that running turbo no longer imports the empty file and instead imports the file with the if statement.
I've copied the if statement into my codebase, just to verify exactly what it resolves to (even tho it shouldn't be running in the first place):
  console.log(typeof process === "undefined");  // false
  console.log(typeof process.env === "undefined");  // false
  console.log(process.env.RUNNING_IN_CLI !== "true");  // true

So, running it with RUNNING_IN_CLI=true npm run dev --turbo works just fine it seems, and serves as a temporary solution, but it is far from ideal of course.

Hi @markomitranic,
I solved the issue and published a new version. Just update, and everything should work as expected.
Context: server-cli-only uses like server-only so-called "poisoned imports" to break things on compile-time so as not to leak sensitive data to the front end. On edge turbopack now weirdly defaults to the browser runtime directive instead of staying with the react-server runtime as before with Webpack:

Webpack: npm run dev on route /api uses react-server runtime
Webpack: npm run dev on route /api/edge uses react-server runtime
Turbopack: npm run dev:turbo on route /api uses react-server runtime
Turbopack: npm run dev:turbo on route /api/edge uses browser runtime (throws an error because React Client Components use the same runtime key and server-cli-only therefore throws an error on )

I looked deeper and realized that turbopack sets the runtime to edge-light or worker if those exports are given instead of using browser as the runtime key. Now, using server-cli-only with Next.js and Vercel, the behavior should be:

Webpack: npm run dev on route /api uses react-server runtime
Webpack: npm run dev on route /api/edge uses react-server runtime
Turbopack: npm run dev:turbo on route /api uses react-server runtime
Turbopack: npm run dev:turbo on route /api/edge uses edge-light runtime (no error anymore, because server-cli-only passes this through)

If you like, look at the updated package.json of server-cli-only. I think this will help to better understand how things work.
PS: I removed the whole env var usage I introduced before for the "node" server runtime because we now have deno and bun as supported server runtime, and the runtime keys should protect enough on build time. But this has nothing to do with your case, and setting the environment variable for the "node" runtime - as you suggested - should have had no effect while running npm run dev:turbo because we would never have hit the "node" runtime directive because the "react-server" and "browser" would have still been used. This whole topic seems a little implicit and hard to grasp 😉

You're welcome! Yes, finding information on this topic seems quite scattered and sparse. For more info, look at this section in the readme of server-cli-only. There, I linked to the WinterCG spec proposal and the implementation of runtime keys via "conditional exports" in react-dom's package.json.
Considering the spec proposal and react-dom's package.json, I included all relevant runtime keys, which can be found in the WinterCG spec proposal and are also implemented in react-dom. Additionally, I've added the Netlify Edge runtime ("netlify"), which now supports RSC on the edge to the best of my knowledge.
Please note that I omitted the runtime key "worker" present in react-dom's "conditional exports" because it isn't in the WinterCG spec proposal. Reading through the commit messages in react-dom's, it isn't clear to me if the "worker" runtime key isn't also used to indicate code that is run on the client side in the browser via Service Workers (the runtime key "worker" is also not present in the WinterCG spec proposal).
Not including "worker" as a runtime keyword seems to be OK for your use-case (Next.js + Turbopack) because I could identify in the Rust code implementation of Next.js's @next-swc package ("responsible for swc compilation customized for next.js") that either the runtime key "edge-light" or "worker" seem to indicate a Next.js Edge runtime. And my tests showed that this seems to be the case. Hence, the "worker" runtime key could be left out until further clarification as long as "edge-light" is used in the conditional exports of server-cli-only.


Added tracing support

Related issues

closes #3506
Short description and why it's useful

This adds support to load a tracing library at the start of the app.
I have added an example for google cloud tracing.
You would use it like this.
src/trace/index.js

module.exports.default = () => {
require('./googleCloud')
}

Screenshots of visual changes before/after (if there are any)

Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and currently important rules acceptance

[X] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

@ResuBaka could you please check the failing CI?

It looks like not a problem from my changes.

https://travis-ci.org/DivanteLtd/vue-storefront/builds/582552893?utm_source=github_status&utm_medium=notification
Should I still fix it or should some one else fix it?

I belive the problem is that modules can’t extend server.js @filrak this is pretty interesting case
Maybe we can just add a hook in core/server.js that can be bound from within the module just before first request is being handled?

If not extending the modules for server app extensions then this way @ResuBaka proposed is the only way; the only thing is that’s gerrnarijg dependency from core to src but at this stage we do have these dependencies anyway so it’s fine with me

Another idea is to add traces from the src/extensions - https://github.com/DivanteLtd/vue-storefront/blob/master/src/extensions/index.ts which won’t require us to modify core/server; these extensions are being registered only serverside

I fist had that Idea too but all tracing stuff should happen as early as it gets. So they trace every thing the right way.
So with my implementation you can add all tracing frameworks which can be implemented this way be called directly before all other code gets loaded.

@ResuBaka so let's wait for #3518 to be finished and then let's make first server module with your change, how does it sound for you? :)

I would use the server module but mine needs to be done before express is started/created so it would still be the best to have it like I have done.
Here you have some info. All of them are telling the user to start it as the first module.
https://docs.datadoghq.com/tracing/setup/nodejs/

https://www.elastic.co/guide/en/apm/agent/nodejs/current/express.html

https://www.npmjs.com/package/@google-cloud/trace-agent

@ResuBaka interesting case, turn out we need to have multiple extension points on server

@filrak so please just sync with @ResuBaka and let's have this ready to merge this week

@ResuBaka @filrak - how about this one? Are we merging it in?

I would say yes when we don't need typescript support for it or is that done in an other PR? @pkarw

OK, I've merged it in

@pkarw
 ;(


[IM] Write Chunking Support

Problem

Support write chunking
Fixes #8029

Change overview

Depend on https://github.com/project-chip/connectedhomeip/pull/13248
Support write chunking

Implement ChunkedWriteCallback
Update ListLongOctetString
Update various cluster (test cluster, acl, server list)

Testing

Python Tests  -- write a large attribute
Test Suite -- writing a large attribute and verify it
Unit test with various attribute length

First, a request: please do not mark my comments "Resolved" when you address them. Just add a comment or some sort of marker if you need to keep track of them. If they get marked resolved, the can't be linked to, and then I can't follow the replies to them....
Once you're done addressing them, please let me know and I will cross-check and resolve them.

Left a checkmark on all comments that are updated / resolved.

Option 1 is that we try to go ahead with this approach. In that case:

We need to rebase on top of 13756 and then re-review the ACL cluster bits.

Done

We need to have a separate PR, landing before this one, which changes ReadHandler to be an ExchangeDelegate and adjusts its lifetime/error handling accordingly, so we're not trying to do it at the same time as the changes in this PR.
We need to rebase on top of that ExchangeDelegate PR and make sure that we're continuing to handle lifetimes correctly.

That is #14821

We need to fix the group write encoding breakage in this PR.

Done, with a TODO but I don't think there is a API break in the future since all changes are in private functions.

I need to understand what is going on with #13641 (comment)

This should be resolved.

Then this can land, and after that we need to fast-follow with a fix to make the implementation actually spec-compliant in term of how it represents chunking on the wire.  I suspect this involves changing exactly how we do ACL checks for a chunked list write so we do the check once up front and don't do it for every chunk in the list.  @mlepage-google thoughts?

Proposed a solution in https://github.com/project-chip/connectedhomeip/issues/14838

I'm taking look at darwin test failures for 13641
Last green CI is 429f8b0b66c48a04afdd56ca83c8d48a32ca3d71
All failed tests related to
2022-02-09T12:45:42.6623140Z 2022-02-09 12:45:42.458295+0000 xctest[44671:349660] Failure performing action. C++-mangled success callback type: 'PFvPvE', error: ../../../../../../../../../../../work/connectedhomeip/connectedhomeip/src/lib/core/CHIPTLV.h:1141: CHIP Error 0x0000000B: No memory

That line is ReserveBuffer
The only place calling ReserveBuffer related to Write interactions is starting a new chunk (StartNewMessage). This hints us we got a buffer which is too small. However, we do get a required buffer, or we will met failure at line 214 in WriteClient.cpp instead of CHIPTLV.h
We are not always hitting this error.
Also, we are not always hitting this error -- we got testSendClusterTestCluster_000017_WriteAttribute failed in attempt 2, but testSendClusterTestCluster_000019_WriteAttribute passed.

After checking all possibilities, I guess the cause might be
https://github.com/project-chip/connectedhomeip/pull/13641/files/429f8b0b66c48a04afdd56ca83c8d48a32ca3d71..165d1750302241dfed2eebae8f2b6eb0792d7622#diff-d9014002808750062754795b50447a0beb3580378e3af98d714e1c0d3f3f6e48R388-R390
What if WriteClient is built without CONFIG_IM_BUILD_FOR_UNIT_TEST but linked to a file using it with CONFIG_IM_BUILD_FOR_UNIT_TEST=1

After checking all possibilities, I guess the cause might be
https://github.com/project-chip/connectedhomeip/pull/13641/files/429f8b0b66c48a04afdd56ca83c8d48a32ca3d71..165d1750302241dfed2eebae8f2b6eb0792d7622#diff-d9014002808750062754795b50447a0beb3580378e3af98d714e1c0d3f3f6e48R388-R390
What if WriteClient is built without CONFIG_IM_BUILD_FOR_UNIT_TEST but linked to a file using it with CONFIG_IM_BUILD_FOR_UNIT_TEST=1

Verified locally, this is caused by mismatch build flags, pushed a commit, https://github.com/project-chip/connectedhomeip/issues/14991 for tracking this issue.


Update dependencies

What changed?
✳ axios (^0.19 → ^0.26.1)
✳ cross-env (^5.1 → ^7.0.3)
✳ laravel-mix (^4.0.7 → ^6.0.43)
✳ fzaninotto/faker (1.9.0 → 1.9.2)
✳ facade/ignition (1.16.15 → 1.18.1)
✳ fideloper/proxy (4.2.1 → 4.4.1)
✳ resolve-url-loader (^2.3.1 → ^5.0.0)
✳ sass-loader (^7.1.0 → ^12.6.0)
✳ laravel/passport (8.0.2 → 8.5.0)
✳ phpunit/phpunit (8.4.3 → 8.5.25)
✳ spatie/laravel-cors (1.6.0 → 1.7.0)

@lewandy As soon as you've time, please check this PR


Drop Python 3.7 support

Per our compatibility policy we should have dropped support for Python 3.7 in December 2021.
The only reason we have kept Python 3.7 support alive is because Colab is still on Python 3.7. When Colab upgrades, we will drop support.

The only reason we have kept Python 3.7 support alive is because Colab is still on Python 3.7. When Colab upgrades, we will drop support.

This happened!
https://medium.com/google-colab/colab-updated-to-python-3-8-4922f9970a72

And we already dropped it!

I haven't done walrus operators, but I have done better f-strings #13458


Brimhaven Agility Arena ticket timer resets after failing specific obstacles

Question
Answer

Java Version
build 1.8.0_45-b15

Operating System
Microsoft Windows 10 Home (Version 1803, OS Build 17134.112)

Description: When failing an obstacle that would make the player fall in or near the spike pit underneath the course the timer would reset back to 59 seconds. Failing obstacles that would not make the player fall (i.e. dart trap, fall rock trap, spinning blades, blade trap, or floor spikes) will not reset timer.
Reproduction: Fail any obstacle that would make the player fall off the course.

Fixed in #4029

@Adam- Doesn't seem to actually be fixed, it will still reset the timer when failing obstacles in the Brimhaven Agility Arena


Problems with 8.3.0 deployment

Hi,
I have the following working config for version 8.1.0 of the UI
  connector:
    image: ghcr.io/international-data-spaces-association/dataspace-connector:6.0.0
    restart: unless-stopped
    environment:
      - SERVER_PORT=8080
      - SERVER_SSL_ENABLED=false
    networks:
      - test
    ports:
      - 8085:8080

  ui:
    image: ghcr.io/international-data-spaces-association/dataspace-connector-ui:8.1.0
    restart: always
    ports:
      - 8088:8082
      - 8087:8083
    environment:
      - CONNECTOR_URL=http://connector:8080
      - UI_BACKEND_URL=http://localhost:8087
      - UI_TITLE=Dataspace Connector UI
    networks:
      - test

Now, with version 8.3.0 of the UI, I changed the UI part of my docker-compose.yml to this:
  ui:
    image: ghcr.io/international-data-spaces-association/dataspace-connector-ui:8.1.0
    restart: always
    ports:
      - 8087:8083
    environment:
      - CONNECTOR_URL=http://connector:8080
      - UI_TITLE=Dataspace Connector UI
    networks:
      - test

And I'm getting a "Get connector settings failed" error message in the UI. When opening a console in the browser, I can see that the frontend is trying to connect to localhost:8083 and not to 8087. How can this be fixed? Adding the UI_BACKEND_URL as with version 8.1.0 does not seem to work anymore.

Sorry, there is still a call to "http://localhost:8083" in the code.
For docker the UI and UI backend are now on same origin so a call to "/" would be correct.
I will fix this.

Fix is now available as docker image (v. 8.3.1)


cluster_master_user_secret output not clear

Description
When enabling manage_master_user_password = true
output for that is weird, instead of getting a map with 3 key:values, it output something with the function tolist
I'm calling the module multiple time , one for each DB, other outputs are working fine

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 8.5.0

Terraform version: 1.6.3

Provider version(s): 5.24.0

Reproduction Code [Required]
Steps to reproduce the behavior:
This is the code for my outputs (one regular and one for master_user_secret)
output "cluster_endpoint" {
  value       = { for key, module in module.aurora : key => module.cluster_endpoint }
  description = "Writer endpoint for the cluster"
}

output "cluster_master_user_secret" {
  value       = { for key, module in module.aurora : key => module.cluster_master_user_secret }
  description = "The generated database master user secret when `manage_master_user_password` is set to `true`"
}

Actual behavior
here's the outputs i am getting:
cluster_endpoint = {
  "admin" = "admin-aurora-mysql-db-c-usea1.cluster-xxxxxxxxxxx.us-east-1.rds.amazonaws.com"
  "app" = "app-aurora-mysql-db-c-usea1.cluster-xxxxxxxxxxx.us-east-1.rds.amazonaws.com"
}
cluster_master_user_secret = {
  "admin" = tolist([
    {
      "kms_key_id" = "arn:aws:kms:us-east-1:xxxxxxxxxxx:key/ddf52ac8-47f4-46fa-bfe3-0dcxxxxxxxxx"
      "secret_arn" = "arn:aws:secretsmanager:us-east-1:xxxxxxxxxxx:secret:rds!cluster-0c256ee8-66dc-4ef3-85f8-523exxxxxxxxxxxxx"
      "secret_status" = "active"
    },
  ])
  "app" = tolist([
    {
      "kms_key_id" = "arn:aws:kms:us-east-1:xxxxxxxxxxx:key/ddf52ac8-47f4-46fa-bfe3-0dxxxxxxxxxxxx"
      "secret_arn" = "arn:aws:secretsmanager:us-east-1:xxxxxxxxxxx:secret:rds!cluster-d840afb3-0b1a-4eaa-a4c8-e9d8xxxxxxxxxxx-xxxxxxxxx"
      "secret_status" = "active"
    },
  ])
}

Additional context
Not sure if this actually because of terraform's provider and not the module,
Would appreciate assistance if it stays like this how to refer for the "Secret_arn" key lets say in 1 of the elements
Thank you

we are simply passing through the output so this is coming from the provider spec. you can access to values as you see fit - using keys for maps or indexes for lists


Feat/local data excel upload v2

use button in app bar to load excel template (
intavia-local-data-template.xlsx
) (Note, the last tab (NL journey) is currently commented out with '--', requires some fixing)

currently it puts out a stringified object in the console (json is stored in the repo: public/data/duerer.json

TODOs in new code base:

store as local entities and events in store

create collections for all data, event tabs

Excel import worked when I tried it with the provided sheet. Unless Stefan or Jakob want to take a look at it first, I think the PR is ready to be merged.

thanks for reviewing! :muscle:


Fix ACME TOS

This PR fixes a bug with the new Let's Encrypt Terms Of Services.
Fixes #579
Signed-off-by: Emile Vauge<EMAIL_ADDRESS>

A small question, but overall LGTM 🐯


Updated NPM packages

Updated packages to their latest versions to fix Dependabot alerts
Closes #22

@dwosk @JAHMCR can we make progress on this?

@gegles is that WhiteSource scan mandatory? If not, we could just let it pass for now to further look into it with more detail

I propose we carefully go through the various dependencies and update as-needed/one-by-one rather than the broad npm update approach. There are a lot of major version bumps with breaking changes so I'd rather we tackle those on an individual basis - does that make sense?
The Dependabot alerts are all for development dependencies. There aren't actually any open for libraries used in production so I don't think this is really all that urgent.


Solving if exists issues

we may need to add to the step below as well it's hard to say if it'll throw at InitialProxy or just InitialModuleBundle

I've actually went ahead and published this package, and done a successful dry run from snaxchain-mainnet-omnibus. Apologies for publishing pre-merge but I didn't want to have to make another pr to fix this issue

you can do dev release to do the test. Please dont make manual releases from branches. This breaks versioning.

can we merge this?


update python3 version for testing to 3.6

Python 3.4 is not supported and since #4835 python 3.6 is used for testing in Travis

SGTM, we should go full on 3.6 soon. I think it's important for libraries to support a wide array of version, but since Superset is a full on product, people can set it up using 3.6.
Maybe we should write a SIP (Superset Improvement Proposal) about it.

Codecov Report

Merging #5562 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5562   +/-   ##
=======================================
  Coverage   63.23%   63.23%
=======================================
  Files         351      351
  Lines       22258    22258
  Branches     2470     2470
=======================================
  Hits        14075    14075
  Misses       8168     8168
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b7ca0...51d3f5e. Read the comment docs.

Updated, a bit unsure about that plus sign in "Python 3.6+" at this point.
Also, setup.py (and therefore pypi) still lists both 3.5 and 3.6.


[Question] How to use new Router with Typescript and Angular2

see title.
http://codepen.io/jvandemo/pen/gbKNox?editors=101
Only found this example can anyone tell me how to change things up to make it work for typescript?

as mentioned a few days ago, i guess @btford will have a example soon for this, right?

:+1:

+1

+2

I think examples are coming but in the meantime you may want to checkout:
configuration.md
and if you're comfortable reading source code:
router in Angular 2 repo

I tried to import RouteConfig, but I guess it's not included in the current angular2.dev.js bundle. What's the recommended way of getting it into my project? Build angular2 from source?

+1

hey all, just one more thing, if you'd like to try using the router with Angular 2's syntax but can't get it to work in NG2, you can use my library A1AtScript which translates Angular 2 syntax including the router to Angular 1: https://github.com/hannahhoward/a1atscript . There's also a starter project here: https://github.com/hannahhoward/a1-starter

Okay I tried to figure out some stuff using the angular.io repo (router branch) for a guide but it is not working (using TS and ng2 .22 alpha)
import {Component, View, bootstrap} from 'angular2/angular2';
import {RouteConfig, Router, RouterOutlet, RouterLink, routerInjectables} from 'angular2/router';
import {HomeComp} from './components/home/home';
import {DetailComp} from './components/detail/detail';
@Component({
selector: 'my-app'
})
@View({
template: '< router-outlet>< /router-outlet>',
directives: [RouterOutlet, RouterLink, HomeComp, DetailComp]
})
@RouteConfig([
{ path: '/', component: DetailComp },
{ path: '/detail', component: HomeComp }
])
class AppComp {}
bootstrap(AppComp, routerInjectables);
import {Component, View, bootstrap} from 'angular2/angular2';
@Component({
selector: 'detail'
})
@View({
template: 'Hello {{name}} This is DETAIL'
})
export class DetailComp {
name:string;
constructor() {
    this.name = 'Detail';
}

}
bootstrap(DetailComp);
Home looking almost alike.  I'm not sure what it's supposed to be.

ya -- try router-link: https://github.com/angular/angular/blob/ecb068019bd218d2cc466a8cf1de47ed3b99c1d3/modules/angular2/test/router/outlet_spec.js#L141

@KhaosTheory1012 I have managed to successfully setup routing using alpha version 25. You can see a working example here. If you want to use TS, follow the docs guidelines how to set it up, but the rest should be the same setup.

@rolandjitsu Thanks but I already made it work with .23 alpha just forgot to update this issue


Fix delete space at space summary page & create e2e test

space summary page looks for fn deleteSpaceWarn, which isn't there
fn is in cf space base component, needs moving
need e2e tests for this... and check that the e2e test for delete space at space list level is there and working

Fixed via #3844


Automatically guess an appropriate icon?

Thanks for stylecloud, it produces awesome results!
One thought: rather than defaulting to a specific icon, could you scan through the common words above a certain minimum threshold, in order, and see if any match the name of an icon? (You could still have a fallback in case none match.) That seems likely to produce amusing, self-describing results; the word describing the icon used as a mask will also appear large in the image.

@joshtriplett This is a brilliant idea, but wondering how much it'd impact performance especially speed!

This is a pretty cool idea! :)
Unfortunately, it's not trivial to add with the current way the text is pipelined. Would have to look into it.


Follow returns success but failed

Hi, I am running Instagram4j with about 4 accounts for about 5 months now and it's great!
Since yesterday I experience the issue, that the FollowRequests doesn't work anymore. Instagram4j doesn't throw any error, but if I check if the user has been followed for real, I realized that it didn't.
It happens for all 4 accounts at the same time with different FollowRequests.
Did Instagram change something or may I been blocked temporarily?
Best regards!

Hey man,
I was running it for multiple accounts a few months ago and I had experienced the same issue with one particular account. There would be no indicator of a failure or even a spam message, but when I tried to send an InstagramFollowRequest the subsequent message would say following:"false". After some time of waiting I would be able to follow again with that account for about 20 follows until the same issue persisted.

Damn all right. So I have to play around with the follow delay maybe. And I will try to find it out with the subsequent message. Thanks for your reponse and your good work!


IAM Error . Role could not be assumed because it does not exist or the trusted entity is not correct

Error: creating EKS Cluster (eks-cluster): InvalidParameterException: Role with arn: arn:aws:iam::xxx:role/eks-cluster-20230113122027302400000001, could not be assumed because it does not exist or the trusted entity is not correct
⚠ Note
I cannot find solution for this Role it looks is valid. I am missing some permission ? But why the error is on trusted entity ?
Versions

Module version [Required]:

Terraform version:
Terraform v1.3.7
on linux_amd64

provider registry.terraform.io/hashicorp/aws v4.49.0
provider registry.terraform.io/hashicorp/cloudinit v2.2.0
provider registry.terraform.io/hashicorp/kubernetes v2.16.1
provider registry.terraform.io/hashicorp/random v3.4.3
provider registry.terraform.io/hashicorp/tls v4.0.4

Provider version(s):

Reproduction Code [Required]
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~>19.5.1"

  cluster_name    = var.eks_cluster_name
  cluster_version = "1.24"

  vpc_id     = module.vpc.vpc_id
  subnet_ids = module.vpc.private_subnets

  cluster_endpoint_public_access = true
  cluster_endpoint_public_access_cidrs = ["<IP_ADDRESS>/32"]

  # EKS Managed Node Group(s)
  eks_managed_node_group_defaults = {
    instance_types = ["t3.medium", "t3.small", "t3.large"]
    ami_type = "AL2_x86_64"

    # We are using the IRSA created below for permissions
    # However, we have to deploy with the policy attached FIRST (when creating a fresh cluster)
    # and then turn this off after the cluster/node group is created. Without this initial policy,
    # the VPC CNI fails to assign IPs and nodes cannot join the cluster
    # See https://github.com/aws/containers-roadmap/issues/1666 for more context
    iam_role_attach_cni_policy = true

  }

  eks_managed_node_groups = {
    loki = {
      name = "loki"
      disk_size = 70

      instance_types = ["t3.medium","t3.small"]

      min_size     = 1
      max_size     = 3
      desired_size = 2
    }

  }

# End module EKS
}

module "vpc_cni_irsa" {
  source  = "terraform-aws-modules/iam/aws/modules/iam-role-for-service-accounts-eks"
  version = "~> 5.0"

  role_name_prefix      = "EKS-VPC-CNI-IRSA"
  attach_vpc_cni_policy = true
  vpc_cni_enable_ipv6   = true

  oidc_providers = {
    main = {
      provider_arn               = module.eks.oidc_provider_arn
      namespace_service_accounts = ["kube-system:aws-node"]
    }
  }

}

Role - Trusted entities
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "EKSClusterAssumeRole",
            "Effect": "Allow",
            "Principal": {
                "Service": "eks.amazonaws.com"
            },
            "Action": "sts:AssumeRole"
        }
    ]
}

Steps to reproduce the behavior:
 no
 yes
 not sure
Expected behavior
Successful create EKS
Terminal Output Screenshot(s)
│ Error: creating EKS Cluster (eks-cluster): InvalidParameterException: Role with arn: arn:aws:iam::xxxxx:role/eks-cluster-20230113122027302400000001, could not be assumed because it does not exist or the trusted entity is not correct
│ {
│   RespMetadata: {
│     StatusCode: 400,
│     RequestID: "xx-a967-4b3b-9db3-xx"
│   },
│   ClusterName: "eks-cluster",
│   Message_: "Role with arn: arn:aws:iam::xxxxx:role/eks-cluster-20230113122027302400000001, could not be assumed because it does not exist or the trusted entity is not correct"
│ }
│
│   with module.eks.aws_eks_cluster.this[0],
│   on .terraform/modules/eks/main.tf line 25, in resource "aws_eks_cluster" "this":
│   25: resource "aws_eks_cluster" "this" {

https://github.com/bryantbiggs/how-to-create-reproduction


Contributions

Hi @Fesaa 👋
I wanted to see how you'd handle the first PR before reaching out and sending a few more. This is a great idea and something I'd been considering doing. Some of my PRs will be a bit heavier, but with the goal of making testing easier which I'll also add.
I'll also add some features too 😄 feel free to ask any questions or for changes.

Heya!
I've made this project for a very specific issue I've had, which it has solved for me. I personally don't really have a direction I want to go with this project, at the moment.
So feel free to implement whatever you need from this project, and I'll be happy to see it fit in
That being said, my apologies for the sloppy code here and there, haha.


removed .range(), added Integer .variance() .standardDeviation()

I removed the .range() and added .variance() and .standardDeviation() for Integer.
I am thinking we could keep the style of implementing the actual logic in the Double file and then for the Integer operations we just map to Double and use the Double functions.
I also think it might be a good idea to keep the iterable version refer to the logic and then the other versions (Sequence, Array) can use .asIterable() and access the functionality there.
Any thoughts on this are welcome of course!

I think I got these covered now. Thank you and let me know what you think of the library now!


Completions in strings/comments

In looking at #12 and #13, it looks like this should be working, but I'm getting completions inside both strings and comments. Is it simply an issue with my configuration or something else?
Tern.sublime-settings:
{
    "tern_argument_hints": true,
    "tern_output_style": "tooltip",
    "tern_argument_completion": true,
    "tern_command": [
      "/path/to/.nvm/versions/node/v4.4.4/bin/node",
      "/path/to/Sublime Text 3/Packages/tern_for_sublime/node_modules/tern/bin/tern"
    ]
}

.tern-project:
{
    "libs":["browser"],
    "plugins":{
        "complete_strings":{},
        "doc_comment": {
            "fullDocs":true
        },
        "es_modules": {},
        "modules": {},
        "node":{},
        "node_resolve": {},
        "webpack": {}
    }
}

It seems the code in #13 didn't actually work. Patch 32342ba should fix it.


More flexible monte carlo

Trying to respond to Vassili's needs, the monte_carlo function now requires the trial() function to return a GaussianResultList instead of a list of GaussianResult. By doing this, the user is free to return customized GaussianResultList (possibly through inheritance) that will provide additional interesting information after the monte_carlo experiment

Looks like it would work. Will have to test it out once merged and see exactly what happens.


We need a proper logo!

Modifying the "community defined" JavaScript logo would probably be the best option as a lot of other JavaScript resources do that.
Here's what the "community defined" JavaScript logo looks like:

I got this particular image from https://github.com/voodootikigod/logo.js/blob/master/registry.md, which lists a load of other modified versions as well.
I'm no graphics designer myself, but from this, I found this brain image which requires no attribution and is free for commercial use. I then modified it to use the above logo's #2e2e2c colour. As I have no image editing software installed, I decided to make a JSFiddle which places this in the correct place on an easily-modifyable 200x200 #f3df49 square. Here's the result:

Here's the JSFiddle: https://jsfiddle.net/JamesD/q3n06jf4

beautiful!

@JamesDonnelly I love it!

@JamesDonnelly fantastic addition, added as the official logo on the readme: https://github.com/harthur-org/brain.js
ty ty ty!

Also added https://github.com/voodootikigod/logo.js/pull/111

@robertleeplummerjr, @JamesDonnelly, just one size?
How about will make 16x16 (32x32) for favicon and other directions? :)

me like!

vector would be nice as well.

Vector?
This is png

Right, but the original parts are not.

The concept is pretty awesome. I gave vectorizing it a shot.

I would love your opinion and whether you consider using it.

Do you have the source vectors?  I love it!

Sure, I just created this. AI or SVG? Should I create an MR?

We'll take what you give.  Svg would be awesome.

  Today we will release v1.0.0.
Its been a fun ride, but it has only just begun.


[Travis] test lowest dependencies

This PR adds a check for the lowest package dependencies.
It also fixes the lowest dependencies.

:-1: Just because our minimum dependencies mean that everything doesn't work, it doesn't mean we should force new ones. People can still want to require php-cs-fixer and not use it's cli interface.

For example, laravel and symfony don't require all dependencies to make everything work, but they have additional dev dependencies to deal with that.

@GrahamCampbell If that is the case why are these dependencies not in the "require-dev" and added to the "suggest"?
Also not testing if your requirements are correct is just bad form why not just do require * for everything?

Also not testing if your requirements are correct is just bad form why not just do require * for everything?

You're not understanding my point. I'm saying, we want to require the dependencies that mean most, but not all things works, for maximum compatibility, then users can, themselves, impose extra version constraints. That's how symfony works. They don't require "proxy manager" for example, so their tests would fail without it, but that's ok.

@GrahamCampbell and your not understanding my point. I'm fine with not requiring all dependencies that why there is a suggest and require-dev section in the composer.json. But I'm not fine with not testing with the lowest dependencies since this can break stuff if someone it using newer methods that don't exist in the lowest dependencies.
So since "symfony/console" is in the require part it must be the correct lowest supported version to avoid breaking builds on related projects/libraries/packages. (aka to avoid throwing a PHP Fatal error:  Call to undefined method Symfony\Component\Console\Output\ConsoleOutput::isVerbose() when trying to run it at the moment see https://travis-ci.org/Tourmanage/Xoip-Components/jobs/55771162)

@boekkooi Would a better solution not be to check if that method exists, thus avoiding the errors, and staying compatible?

@GrahamCampbell that is one option in this case I would go for updating the dependency and making sure it won't happen in the future but if disagree with that then create a PR based on not updating the dependency version.

:+1: for testing lowest versions, we do not add partial support like "if you have .1 we give you this, and on .4 we give you that"

@keradus Are you ok with the version bump for symfony/console or would you rather have that I find all bugs related to version 2.1 and that I try to fix those?

It would be great if we could stuck with 2.1, but if it would require some workarounds then 2.4 is good

Since the work arounds are minimal, we should patch this in 1.5, then remove the work around and bump the min version in 2.0. Otherwise, we'd be breaking bc.

disagree with BC breaking part. What you are saying is sth like update min php version to 5.5 would be BC break... it is not interface change, it change of environment to run a tool.

@keradus Ok so for version 2.1 we would need to remove/replace OutputInterface::VERBOSITY_DEBUG, $output->isVerbose() usages in Console/Command/FixCommand.php and remove Symfony\Component\Console\Output\BufferedOutput usage in Tests/ReadmeTest.
If we bump the version to 2.3 we would only need to replace $output->isVerbose() and BufferedOutput.
Or we can just use 2.4 and have nothing to replace/re-implement.

Or we can just use 2.4 and have nothing to replace/re-implement.

We don't have to re-implement it. Just not support it if it's not available.

@GrahamCampbell It is not a BC break 2.1 is not supported since
762f03cf02ab1834e3c961917f4237b491ba48e9 and 833d8dfa47a8e7b07d8e225d8a8e8bc69a8dad2d
I vote for bump version to 2.3 and skip the buffered test if the class is not there.

I vote for bump version to 2.3 and skip the buffered test if the class is not there.

That would be good actually, yeh. :+1: for that.

Updated PR.
This bumps symfony/console to version 2.3 and skips the ReadmeTest for version 2.3.

This looks much better now. :+1:

what about bumping to 2.4 in our 2.x line and revert that changes (skip test, isVerbose) ?
And, in 2.x thinking... This is tool, most cases are CLI stand-alone usage, not using it as dependency. Do we really need to using possible lowest versions?

@keradus In my opinion --prefer-lowest needs to be in every project/package/etc. that is not committing it's composer.lock file.
Regarding the bump to 2.4 in the 2.x branch I agree, but one could make a case that a tool with this much usage should use a LTS version.

Regarding the bump to 2.4 in the 2.x branch I agree, but one could make a case that a tool with this much usage should use a LTS version.

It's entirely possible that symfony 2.7 will be released by then, lol

Thank you @boekkooi.


Various Additions for Jetbrains

Various additions for Jetbrains (and some changes) I've pulled from @dwiel's config at his request. I don't have the Jetbrains RPC stuff set up, so it may be worth someone who uses Jetbrains testing these first.

Will test them out

@knausj85 @jcaw tested with the rubymine and all work well for me!


How to process nested pointer for arena.New

How to use arena to allocte memory for Outer,should we use arena to allocate memory for the nested field Inner?
Is there some method to identify  the memory-allocated way.
type Outer struct {
   *Inner
}
type Inner Struct {
}

a arena object can not be used concurrently.Is there some example for arena pool

How to use arena to allocate memory...
In this package, if you're using an arena to clone a struct, all newly allocated memory spaces are allocated from the arena.

Here is a sample to clone a value with arena.
ar := arena.NewArena()

// The cloned is a deep copy of v and allocated from ar.
cloned := clone.ArenaClone(ar, v)

Is there any way to identify whether an instance is allocated from an arena...
I don't think we have any formal way to do so. There is a very tricky way to check whether a pointer is in an arena, though not recommended. That is, we can call np := arena.Clone(p) to get a new pointer and then check np == p. If it's true, p is allocated from heap (a.k.a. not from arena), otherwise, it's allocated from an arena. However, even if we know p is allocated from an arena, we still don't know which arena holds the p.

// An arena object cannot be used concurrently...
AFAIK, arena APIs can be used in concurrent environment. You can share an arena instance in different goroutines and use it concurrently. So you don't need to have an arena pool.

How to use arena to allocate memory...

In this package, if you're using an arena to clone a struct, all newly allocated memory spaces are allocated from the arena.
Here is a sample to clone a value with arena.
ar := arena.NewArena()

// The cloned is a deep copy of v and allocated from ar.
cloned := clone.ArenaClone(ar, v)

Is there any way to identify whether an instance is allocated from an arena...

I don't think we have any formal way to do so. There is a very tricky way to check whether a pointer is in an arena, though not recommended. That is, we can call np := arena.Clone(p) to get a new pointer and then check np == p. If it's true, p is allocated from heap (a.k.a. not from arena), otherwise, it's allocated from an arena. However, even if we know p is allocated from an arena, we still don't know which arena holds the p.

An arena object cannot be used concurrently...

AFAIK, arena APIs can be used in concurrent environment. You can share an arena instance in different goroutines and use it concurrently. So you don't need to have an arena pool.

I'm going to use arena  and  CAS2 to improve  lock free hash map
type Dict[K compareable, V any] struct {...}

But the V may be like this：
type Outer struct {
   *Inner
    slice []int
}
type Inner Struct {
}

So, I would create this like this：
ar := arena.NewArena()
outer := arena.New[Outer](ar)
outer.Inner = arena.New[Inner](ar)
...

This seems relatively more steps to create V. The hashmap may use kvpair wrapper to store v. To reduce allcote memory op and gc, a way is using object pool that is built in arena memory. We can allocate all memory the map needs and establish a mechanism for reusing objects like kvpairs  in arena or in a series of arena.Now there seems no use cases for object pools that is built with arena.

Here is a tip for you to make allocation code much simpler.
// Declare a global variable as a template.
var valueTemplate = &Outer{
    Inner: &Inner{
        // initialize more fields...
    },
    slice: []int{},
}

// You will have a newly cloned value allocated from ar.
v := clone.ArenaClone(ar, valueTemplate)


can't see the air fryer list

Hello,
When I try to add integration, in the last step when I have to choose my air fryer in the list, there is no list!

my fryer modèl is MAF02 my server for the cloud is SG
I can't add it manually because my fryer doesn't appear in the Mi Cloud token extractor app, so I can't have the token
What can I do?
Please, help me.

I have the same issue.  Has anyone discovered what to do to solve this?


Updating the hub_api for hub CLI

ref: #3
In this PR, I added template_id and repo_url to the hub_list_api, which are very important for the Hub CLI.

oopsie! I missed some templates, my bad.

I'm going to hold off merging so Karthik has the chance to take a look, since he built the original API machinery and is more familiar with it than I am.


Fix moment import

I got a "moment is not a function" error when using this package while running jest tests.
This small change in the import logic for the moment package fixed that.

@ivokh can you also sign the commit or do you want me to squash it?

Sorry I didn't notice that you require that.
I just signed the commit. That was my first signed commit so I hope everything goes well.
Thank you for the quick response.

no problem, you did well :D


Release v2.0.5

Questions
Answers

Description?
Release with a few minor fixes

Type?
new feature

BC breaks?
no

Deprecations?
no

Fixed ticket?
n/a

How to test?
Full test of the module?

Thank you @khouloudbelguith :)