Flutter onPanStart invokes late when the widget is wrapped inside InteractiveViewer

Steps to Reproduce

Run flutter create bug.
Update main.dart as follows:

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  debugPaintSizeEnabled = true;
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  double _width = 300;
  double _height = 200;

  @override
  Widget build(BuildContext context) {
    final m = MediaQuery.of(context);
    return Scaffold(
      body: SafeArea(
        child: Container(
          height: m.size.height,
          width: m.size.width,
          child: InteractiveViewer(
            maxScale: 30,
            child: Stack(
              children: <Widget>[
                Container(height: _height, width: _width, color: Colors.red),
                Positioned(
                  top: _height / 2 - 10,
                  left: _width - 20,
                  child: GestureDetector(
                    onPanStart: (details) {
                      print("PAN STARTED");
                    },
                    onPanUpdate: (details) {
                      final delta = details.delta;
                      setState(() {
                        _width = _width + delta.dx;
                      });
                    },
                    child: Container(height: 20, width: 20, color: Colors.blue),
                  ),
                )
              ],
            ),
          ),
        ),
      ),
    );
  }
}

I just have a simple container which has a resize handle on center right which means the container can be resized using that handle. It is wrapped inside InteractiveViewer widget.
Expected results:
I expect the onPanStart callback to invoke right away.
Actual results:
onPanStart callback invokes after certain delay.
Note: This problem can only be replicated in simulators. In DartPad, it seems to work fine but still has a very little delay.

Logs
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.0.1 20B29 darwin-x64, locale en-US)
    • Flutter version 1.22.5 at /Users/jaden/development/tools/flutter
    • Framework revision<PHONE_NUMBER> (2 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/jaden/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.8.4

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.0

[✓] Connected device (2 available)
    • Android SDK built for x86 (mobile) • emulator-5554                        • android-x86 • Android 7.0 (API 24) (emulator)
    • iPhone 12 Pro Max (mobile)         • A2D7546A-0E0D-430F-92F0-F9EF1ADBEFF9 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)

! Doctor found issues in 1 category.

@sanjade
When do you exactly get the error ? While dragging the blue container ? I tried the same but didn't notice any delay.

@darshankawar Did you try it in DartPad? If so then you will not notice the delay. You’ve to try it in simulator. I tried it in iOS Simulator.

https://user-images.githubusercontent.com/31353695/103213372-9497c200-4935-11eb-99b3-b347bf1a8cc6.mov

On Android (Pixel 2 API 24)
https://user-images.githubusercontent.com/31353695/103213565-2ef80580-4936-11eb-8fed-7b1722ac4203.mov

I do see a minor delay on mobile as compared to on dartpad.
https://user-images.githubusercontent.com/67046386/103214526-a62d9980-4936-11eb-9d4f-145eff5511cc.mov

flutter doctor -v

[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-IN)
    • Flutter version 1.22.5 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision<PHONE_NUMBER> (3 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • sdk gphone x86 arm (mobile)         • emulator-5554
      • android-x86 • Android 11 (API 30) (emulator)
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)

• No issues found!

@darshankawar Idk its weird. Like on iPhone 12 Pro Max the delay is a bit more than iPhone SE or iPhone 8.

I've got the same issue with my project. Any updates on this?

@OlegBezr  I don’t think iit will be fixed any time soon. This issue doesn’t even have priority assigned.

@OlegBezr I don’t think iit will be fixed any time soon. This issue doesn’t even have priority assigned.

That sounds sad( I'm really puzzled now by the challenge to enable a combination of zooming and paning actions other the same widget. A combination of InteractiveViewer and GestureDetector seemed to be the answer, but the delay spoils all the user experience.

@OlegBezr  Yeah I feel you man. I abandoned my whole project because of this. It’s been 4 months since I raised this issue and still no answer.  I mean I don’t blame flutter team. They have lot in their plate too. There are literally like more than 8k issues here and god knows which page this issue is buried in.

@sanjade, I've created an issue on StackOverflow, hopefully there will be some suggestions: https://stackoverflow.com/questions/67005002/how-to-zoom-a-gesturedetector-with-onpanupdate-call

Hi @sanjade I've found some kind of solution. Using Listener instead of GestureDetector eliminates the delay.
Minimum code with delay:
`import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
void main() => runApp(new MaterialApp(
home: new IssueExamplePage(),
debugShowCheckedModeBanner: false,
));
class IssueExamplePage extends StatefulWidget {
@override
_IssueExamplePageState createState() => _IssueExamplePageState();
}
class _IssueExamplePageState extends State {
bool drawingBlocked = false;
List points = [];
@override
Widget build(BuildContext context) {
return Scaffold(
body: SafeArea(
child: Container(
color: Colors.grey,
padding: EdgeInsets.all(5),
child: Container(
color: Colors.white,
child: InteractiveViewer(
child: AbsorbPointer(
absorbing: drawingBlocked,
child: GestureDetector(
behavior: HitTestBehavior.translucent,
onPanUpdate: (details) {
RenderBox renderBox = context.findRenderObject();
Offset cursorLocation = renderBox.globalToLocal(details.localPosition);
                setState(() {
                  points = List.of(points)..add(cursorLocation);
                });
              },
              onPanEnd: (details) {
                setState(() {
                  points = List.of(points)..add(null);
                });
              },
              child: CustomPaint(
                painter: MyPainter(points),
                size: Size.infinite
              ),
            ),
          ),
        ),
      ),
    ),
  ),
  floatingActionButton: Column(
    mainAxisAlignment: MainAxisAlignment.end,
    children: [
      FloatingActionButton(
        child: Icon(drawingBlocked? CupertinoIcons.hand_raised_fill : CupertinoIcons.hand_raised),
        onPressed: () {
          setState(() {
            drawingBlocked = !drawingBlocked;
          });
        }
      ),
      SizedBox(
        height: 10
      ),
      FloatingActionButton(
        child: Icon(Icons.clear),
        onPressed: () {
          setState(() {
            points = [];
          });
        }
      ),
      SizedBox(
        height: 20
      ),
    ],
  ),
);

}
}
class MyPainter extends CustomPainter {
MyPainter(this.points);
List points;
Paint paintBrush = Paint()
..color = Colors.blue
..strokeWidth = 5
..strokeJoin = StrokeJoin.round
..strokeCap = StrokeCap.round;
@override
void paint(Canvas canvas, Size size) {
for (int i = 0; i < points.length - 1; i++) {
if (points[i] != null && points[i + 1] != null) {
canvas.drawLine(points[i], points[i + 1], paintBrush);
}
}
}
@override
bool shouldRepaint(MyPainter oldDelegate) {
return points != oldDelegate.points;
}
}` - Just change GestureDetector for Listener (use onPointerMove instead of onPanUpdate, there are substitutes for the most of GestureDetector parameters) and there will be no delay! :)

@darshankawar, shall we mark my previous answer as a solution and close this issue?

This still happens in Flutter 3.0.5. I am actually using GestureDetector inside GestureDetector, the lag is so obvious.

Hey guys. I did a little digging into the source code and wrote a customized GestureDetector (only for Pan Gesture). You can just replace the GestureDetector with it. (If you only have onPanxxx Gesture). The point is to let the Gesture be the winner immediately after the onPanDown callback, so that no other Gesture will be examined which might cause the time gap between onPanDown and onPanStart.
import 'package:flutter/gestures.dart';
import 'package:flutter/widgets.dart';

class CustomPanGestureRecognizer extends PanGestureRecognizer {
  @override
  void addAllowedPointer(PointerDownEvent event) {
    super.addAllowedPointer(event);
    resolve(GestureDisposition.accepted);
    //get the GestureRecognizer win immediately after invoking onPanDown
  }
}

RawGestureDetector CustomPanGestureDetector(
    {GestureDragDownCallback? onPanDown,
    GestureDragStartCallback? onPanStart,
    GestureDragUpdateCallback? onPanUpdate,
    GestureDragEndCallback? onPanEnd,
    GestureDragCancelCallback? onPanCancel,
    Widget? child}) {
  return RawGestureDetector(
    gestures: {
      CustomPanGestureRecognizer:GestureRecognizerFactoryWithHandlers<CustomPanGestureRecognizer>(() => CustomPanGestureRecognizer(),(detector){
        detector..onDown=onPanDown
        ..onStart=onPanStart
        ..onUpdate=onPanUpdate
        ..onEnd=onPanEnd
        ..onCancel=onPanCancel;
      })
    },
    child: child,
  );
}```

Reproducible on stable 3.3 and master 3.7 theres a delay onPanStarted on both Android and IOS(bit longer)

Android
IOS

code sample
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  debugPaintSizeEnabled = true;
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  double _width = 300;
  final double _height = 200;

  @override
  Widget build(BuildContext context) {
    final m = MediaQuery.of(context);
    return Scaffold(
      body: SafeArea(
        child: SizedBox(
          height: m.size.height,
          width: m.size.width,
          child: InteractiveViewer(
            maxScale: 30,
            child: Stack(
              children: <Widget>[
                Container(height: _height, width: _width, color: Colors.red),
                Positioned(
                  top: _height / 2 - 10,
                  left: _width - 20,
                  child: GestureDetector(
                    onPanStart: (details) {
                      print("PAN STARTED");
                    },
                    onPanUpdate: (details) {
                      final delta = details.delta;
                      setState(() {
                        _width = _width + delta.dx;
                      });
                    },
                    child: Container(height: 20, width: 20, color: Colors.blue),
                  ),
                )
              ],
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.7.0-3.0.pre.33, on macOS 12.6 21G115 darwin-arm64, locale en-IN)
    • Flutter version 3.7.0-3.0.pre.33 on channel master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (38 minutes ago), 2022-12-05 18:27:21 -0800
    • Engine revision a309d239c4
    • Dart version 2.19.0 (build 2.19.0-463.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.55.20221129

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.94

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Any updates on this issue?

Any update? I also have this bug.

Hey 👋
I land here because I have the exact same behaviour too: the pan gesture has to travel some distance before starting to fire onPanUpdate. I think it may be related to https://github.com/flutter/flutter/issues/54359#issuecomment-613594324.
The workaround from @marksgy works great to handle onPanUpdate immediately, thanks! I did a little digging too and I think we can control how far it has to travel before firing onPanUpdate by giving a DeviceGestureSettings to PanGestureRecognizer, which removes the need to extends PanGestureRecognizer if we set touchSlot to 0.
Here is my final implementation (as a "drop-in" replacement for GestureDetector to use only with onTapXxx):
import 'package:flutter/gestures.dart';
import 'package:flutter/widgets.dart';

class ImmediatePanGestureDetector extends StatelessWidget {
  final Widget? child;
  final HitTestBehavior? behavior;
  final bool excludeFromSemantics;
  final SemanticsGestureDelegate? semantics;
  final GestureDragCancelCallback? onPanCancel;
  final GestureDragDownCallback? onPanDown;
  final GestureDragEndCallback? onPanEnd;
  final GestureDragStartCallback? onPanStart;
  final GestureDragUpdateCallback? onPanUpdate;

  const ImmediatePanGestureDetector({
    super.key,
    this.child,
    this.behavior,
    this.excludeFromSemantics = false,
    this.semantics,
    this.onPanCancel,
    this.onPanDown,
    this.onPanEnd,
    this.onPanStart,
    this.onPanUpdate,
  });

  @override
  Widget build(BuildContext context) {
    return RawGestureDetector(
      behavior: behavior,
      excludeFromSemantics: excludeFromSemantics,
      semantics: semantics,
      gestures: {
        PanGestureRecognizer:
            GestureRecognizerFactoryWithHandlers<PanGestureRecognizer>(
          () => PanGestureRecognizer()
            ..gestureSettings = const DeviceGestureSettings(touchSlop: 0),
          (PanGestureRecognizer detector) {
            detector
              ..onDown = onPanDown
              ..onStart = onPanStart
              ..onUpdate = onPanUpdate
              ..onEnd = onPanEnd
              ..onCancel = onPanCancel;
          },
        )
      },
      child: child,
    );
  }
}


Fix(tests) - Ensure that the hot key challenge tests works

Checklist:

[X] I have read and followed the contribution guidelines.
[X] I have read and followed the how to open a pull request guide.
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #49966

It started timing out on me and alternating between that and not being able to view the site in the tests at all.

There were statement in hotkeys that fails because the container can be null, while it act as it always has value.
It's addressed in this PR #49830, for more context. Just wondering if the change for the container is implemented, will the issue persist?


Update pacakge path

Codecov Report

Merging #109 into release-rc4 will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##             release-rc4     #109      +/-   ##
=================================================
- Coverage          32.06%   32.01%   -0.05%
  Complexity           363      363
=================================================
  Files                 55       55
  Lines               4560     4566       +6
  Branches             392      392
=================================================
  Hits                1462     1462
- Misses              2987     2993       +6
  Partials             111      111

Impacted Files
Coverage Δ
Complexity Δ

...om/webank/wecross/stub/bcos/BCOSGMStubFactory.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../com/webank/wecross/stub/bcos/BCOSStubFactory.java
21.64% <0.00%> (-0.70%)
4.00 <0.00> (ø)

...cross/stub/bcos/proxy/ProxyContractDeployment.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abe472...651f651. Read the comment docs.


add real linter

We only used the formatter before, but it does not check code smells and other non-formatting related code styling rules.
This PR …

sets up analysis rules (automatically detected by IntelliJ)
uses them in the pipeline instead of the formatter
adapts the existing code to the effective dart guidelines

This should make the pipeline less pedantic, as files do not have to be formatted exectly like flutter format would format them, and instead give more valuable hints.

Note: after merging this PR, we have to adapt the branch protection rules to depend on "FE: analyze" instead of "FE: lint". We also have to force merging of this PR using admin power due to the same reason.

Note: after merging this PR, we have to adapt the branch protection rules to depend on "FE: analyze" instead of "FE: lint". We also have to force merging of this PR using admin power due to the same reason.


Transfer fails on local folders containing spaces

Attempting to transfer a local folder containing a space (also presumably any other special unix characters) results in:
scp: ambiguous target
This should be just be a case of escaping the relevant paths in Jscp.java with single quotes to keep bash happy; I'll look into a fix now and hopefully submit a PR.

@berry120 thanks!


feat: support Bun by using ShadowRealm

Description
We could also probably support Bun by using worker threads, but I was too eager to try the Shadow Realm API.
Currently, all jsdom tests are failing because bun doesn't seem to correctly support VM module.
The reason why other tests are failing is still unknown to me,

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

all jsdom tests are failing because bun doesn't seem to correctly support VM module.

The compatibility page says that "VM modules" are not supported but I interpreted that as "importModuleDynamically does not work". Maybe I'm just reading this wrong. 🙃
It does say that core node:vm functionalities are implemented. I think JSDOM was using createContext+runInContext which seem to be exported: https://github.com/oven-sh/bun/blob/51d3d4382281f789f8175079ed426a63529eb3e7/src/js/node/vm.ts#L8. I haven't yet had time to try this out but maybe there's something still missing.


Big Bang Sync

Including resolving merge conflict:
https://github.com/wildfly/wildfly/commit/d92de7282f6be74333e0a61b209ceac93aeb7db8

The test failures on the security manager job look genuine, they are failing for me locally as well.


Mahaboob_RPAChallenge

Mahaboob_RPAChallenge

SourceCode/2023/Sep2023/Projects/Mahaboob/RPAChallenge/project.json
Main.xaml

Remove the unused variable outTransactionItem.
Only use a Flowchart at the top layer for maintainability and readability. Your Flowchart Flowchart is used in a secondary layer.
Make sure all the arguments follow the naming conventions. BreakTriggerScopeInArgument does not respect the set pattern ^in_(dt_)?([A-Z]|[a-z])+([0-9])*$.
Names of activities should give a clear indication of how they are being used. 'Log Message' is used as a display name too often. You used it 2 times. Try to use unique names.
The variable DT_Input should start with a dt_ prefix for DataTable variables.
The variable DT_Input doesn't respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$.
The following activities have default names, use more descriptive titles for clarity:

Get Queue Items
Delete Queue Items
If
Flowchart
Get Transaction Item
Log Message
Set Transaction Status
Break
Log Message

No

SourceCode/2023/Sep2023/Projects/Mahaboob/RPAChallenge/project.json
NoFile:

Add your project's Automation Hub URL in "Project Settings".

If you're not using UiPath.Mail.Activities, UiPath.MicrosoftOffice365.Activities and UiPath.Testing.Activities, scrub them from your project. Cleaning up unused packages quickens your process.

Main.xaml:

If you don't need the variable "outTransactionItem", go get rid of it. Save space, improve efficiency.

Keep your Flowchart at top layer. Makes it easier to read and fix.

Follow the naming convention for your argument. Your argument "BreakTriggerScopeInArgument" is not conforming. Follow this pattern: ^in_(dt_)?([A-Z]|[a-z])+([0-9])*$.

Don't repeat activity names. "Log Message" appears too many times. Keep it unique for clarity.

Follow naming convention for DataTable Variable. Start it with "dt_". Your variable "DT_Input" isn't matching the pattern.

Don't stick with default names for your activities. For instance, "Get Queue Items", "Delete Queue Items", "If", "Flowchart", "Get Transaction Item","Log Message", "Set Transaction Status",  "

SourceCode/2023/Sep2023/Projects/Mahaboob/RPAChallenge/project.json
NoFile Review:

Please include your Automation Hub URL in the "Project Settings" as your organization requires. This detail is missing currently.
You seem to have the packages UiPath.Mail.Activities, UiPath.MicrosoftOffice365.Activities, and UiPath.Testing.Activities included in your project but not used anywhere. To make your process run faster, kindly remove these unused packages.

Main.xaml Review:

The variable 'outTransactionItem' is not used in your code. Please remove any unnecessary variables.
Your Main code has a flowchart structure deep down other than the top layer. To keep it maintainable and readable, please have the flowchart as the top layer.
There seems to be a problem with the naming pattern of argument 'BreakTriggerScopeInArgument'. Make sure to follow the correct naming pattern with arguments.
In your code, 'Log Message' display name has been defined more than once, while the threshold is 1. For clarity, activity names should be unique and specific to their usage, try updating the names.
The variable 'DT_Input' does not follow the set naming pattern. Also, since it's a DataTable variable it should start with a 'dt_' prefix.
6

Mahaboob_W3Test


The /checkout isn't working correctly after I logged in as a user/customer  (with BigCommerce)

There seems to be a problem when a user tries to go to /checkout with BigCommerce, it returns a blank page with the following message:
{"data":null,"errors":[{"message":"An unexpected error ocurred"}]}
I'm not sure where the issue has come from. I've made zero changes to the original code from the starter kit and I think I've configured the store properly in BigCommerce.
Any thoughts or guidance?

I have the same problem

@Nazmer @juandominguezgalvan
add BIGCOMMERCE_STORE_URL and BIGCOMMERCE_STORE_API_CLIENT_SECRET with their respective values to .env file

Also add BIGCOMMERCE_STORE_API_STORE_HASH if you haven't already

Thanks @kogan007,
Could you provide us some guidance on how to obtain these environmental variables?
Because I used the Vercel cli and pulling .env.local from vercel didn't set (BIGCOMMERCE_STORE_URL, BIGCOMMERCE_STORE_API_CLIENT_SECRET, BIGCOMMERCE_STORE_API_STORE_HASH).

@kogan007 @Nazmer  I've created a new API in the Advance Settings Menu from the BigCommerce Dashboard
and now the checkout seems to work.
Thanks again @kogan007 and hope this helps @Nazmer.


Testnet 127 candidate

Candidate build for testnet-127. Do not merge. PR for testing only.

bors try

bors try

bors try

systemtest-blocks-add-node failure looks transitory. I added one small potential fix for systemtest-p2p but I think the p2p 'v2' client test may continue to fail because the p2p-test docker image is very old and doesn't know what to do with the --json-server-new param (the config is shared). No biggie for purposes of the testnet.

bors try

All tests are passing, except one small issue in the p2p test: the "v2 client" docker image doesn't know how to handle the --json-server-new command line arg (I'm 99% sure this is what's causing this test to fail). This is also an artifact of the old API and will go away when that does. I just cut a v0.1.28 release with this build.

bors try

This testnet has been up for a week and looks relatively stable. I updated the testnet wiki doc. I'm going to merge this into the main testnet branch and work with a new testnet-129 branch going forward, for the next candidate.


New branch and tag

Commit to close the issue # 1

This branch should not be deleted, further commits will use it as main branch and make pull request on this one.


NotImplementedError: Unsupported ONNX ops of type: FC

@jamesr66a
I am trying to use the ONNX model provided at the end of this Microsoft Tutorial for Lung-diseases predictions using AI. At the end of the tutorial, a ONNX file is provided:
https://chestxray.blob.core.windows.net/chestxraytutorial/tutorial_xray/chestxray_converted.onnx
I have tried following the ONNX tutorial for opening the model via coreml, but get: NotImplementedError: Unsupported ONNX ops of type: FC.
Any suggestions on how to open and run the ONNX model?
Thank you very much in advance for your time and consideration!

@dzhulgakov wrote that article

Great thank you very much @jamesr66a


luci-app-simple-adblock: convert to js

Thanks @dibdot, @jow-, @vsviridov!
I would appreciate any feedback on this transition as I'll be using this as a template for other packages.
Depends on https://github.com/openwrt/packages/pull/19796
Signed-off-by: Stan Grishin<EMAIL_ADDRESS>

I think that handling of RPC events can be further simplified. Not sure if we need the mini EventEmitter, that kind of complicates things...

I'll leave it be for the weekend and would like to merge on Monday, so would welcome any feedback from other js gurus before then.

I can't save any changes and I get this.


enum subtypes don't properly inherit from a defined parent type

We have a set of Enums implementing a common interface. But in the generated code, the Enums are not implementing the interface.  Using discriminatorMapping - the type is referenced as an External Property
Sample code - The issue, in this case is Cow and Sheep classes in the client do not implement Animal
@Schema(
    description = "Animals",
    discriminatorProperty = "type",
    discriminatorMapping = [
        DiscriminatorMapping(value = "COW_FARM", schema = Cow::class),
        DiscriminatorMapping(value = "SHEEP_FARM", schema = Sheep::class),
    ],
)
@JsonTypeInfo(
    use = JsonTypeInfo.Id.NONE,
    include = JsonTypeInfo.As.EXTERNAL_PROPERTY,
    property = "type",
)
@JsonSubTypes(
    JsonSubTypes.Type(name = "COW_FARM", value = Cow::class),
    JsonSubTypes.Type(name = "SHEEP_FARM", value = Sheep::class),
)
interface Animal

enum class Cow : Animal {
"Moo";
}

enum class Sheep : Animal {
"Baa";
}

enum class FarmType {
"COW_FARM",
"SHEEP_FARM";
}

interface Farm {
  val type: FarmType
  val animal: Animal
}

class CowFarm : Farm {
   val type : FarmType = FarmType.COW_FARM,
   val animal: Cow
}

class SheepFarm : Farm {
   val type : FarmType = FarmType.SHEEP_FARM,
   val animal: Sheep
}

Please provide an example OpenApi3 schema, with expected output vs actual output so we can diagnose and attempt a fix


/whitepapers/platforms/ shows Korean page

English page can't be shown.

/whitepapers/platform-eng-maturity-model/ also shows Korean.


feat(ci): turn on linux UT on MQ

What does this PR do?
Re enable following UT on MQ pipelines

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3

Motivation
Catch more issues during MQ and improve main branch stability

Additional Notes
Before

After

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/ping

/merge


Column Selection when inlineEdit:true

Angular-generic-table have a row selection feature can we do same on column level?
can we select the whole column on click?

Hi @sahilkatia, not sure how you'd like to use the feature but I should be possible to use the columnClick method and do a map on your data and return an array with column values for all rows, and at the same time you could apply some class to you column to make it look lite has been selected. Might not fit your use case do so perhaps you could elaborate a bit on your needs?


Module to package

This pulls in some work of @EricPobot and some of my changes as well.

The single file approach is replaced by package again. There is ev3dev/core.py that has most of the functionality, and there are ev3dev/ev3.py and ev3dev/brickpi.py that has platform-specific code. ev3dev/__init__.py tries to guess the current platform and imports appropriate file. From the user standpoint nothing has changed: import * from ev3dev still works.
Led class is split into Led and Leds. Led is platform-agnostic class that works with single led. Leds is platform-specific stateless class that contains Led instances (such as red_left, red_right for EV3) and color functions (I actually like the chage!). Each platform-specific file defines its own version of Leds.
I've introduced platform-specific constants (OUTPUT_X, INPUT_X) into each of the platform-specific files.
Button class is split into platform-agnostic ButtonEVIO and platform-specific Button. The former stays in core.py.
I've introduced ev3dev/version.py that is generated by setup.py from git_version.py and spec_version.py (hence it is not part of git repo). It allows to determine package version at runtime:

>>> ev3dev.__version__
'0.4.1.post7 (spec: 0.9.3-pre-r2, kernel: v3.16.7-ckt16-7-ev3dev-ev3)'

This PR is accompanied by https://github.com/rhempel/ev3dev-lang/pull/4

Travis says its not good, I am looking at it.

Travis is happy with 933136c. The problem was that version.py was not there after fresh clone. This should not happen to users when they installed the package from pypi or with apt-get.

My instincts told me that eventually we'd move to having the platform specific things in separate files - thanks @EricPobot and @ddemidov for making the changes!

@ensonic, this breaks the Leds API. Basically, you need to use Leds instead of Led now.

May be I should have added @EricPobot to the list of authors, but that line may become quite long at this pace. I would replace it with 'Ralph Hempel et al' (and may be a link to contributors page)

It's getting a bit long, I agree. How does everyone feel about leaving me as author/maintainer, but others get credit and email address in ev3dev.py?

This is fine for me. No problem.

In that case - what is @EricPobot's preferred email address?
Note to all, please indicate if you would rather NOT have your email address in ev3dev.py

I am ok with having my email address on the list. It's on my github
profile.
On Sun, Nov 1, 2015, 23:03 Ralph Hempel<EMAIL_ADDRESS>wrote:

In that case - what is @EricPobot https://github.com/EricPobot's
preferred email address?
Note to all, please indicate if you would rather NOT have your email
address in ev3dev.py
—
Reply to this email directly or view it on GitHub
https://github.com/rhempel/ev3dev-lang-python/pull/46#issuecomment-152858887
.

--
Cheers,
Denis

You can use<EMAIL_ADDRESS>This is the one I use for the activities related to my robotics association, but is forwarded to my personnal one.
I'm sorry about the confusion which can have been created by my posting  with my professional GitHub identity (i.e. ericpascual).

So you want credit as Eric Pascual :-)

Since this is my name IRL, it seems the most appropriate ;)

Re leds.: which version will have that change? I'll ignore 0.4.0 then. Also 0.4.0 still misses the port constants (INPUT_1, ...). So it needs another cycle anyway.

I think this is goind be in 0.4.1. Re constants: this PR has those: https://github.com/rhempel/ev3dev-lang-python/pull/46/files#diff-2d404f179d8fbc68b0ce868c5ac0bd3dR32

I'm working out packaging with @dlech - I'll pull in the constants for the next spin, and since Leds is a breaking change it will be 0.5.0

Also, I've missed INPUT_AUTO and OUTPUT_AUTO. I'll make another PR today.

OK, thks - when I receive that I'll merge, bump the version to 0.5.0, push that to pypi, and update the ev3dev-lang master repo so that we can do a package build for @ensonic.
@dlech, do you have a method of automating package builds when a new tag gets pushed?

Not at the moment.


Multi-cluster enablement

More than one cluster
Locatality options for each cluster
Support Splitting Workloads (node pool types and sizes)
Expanding TF state vs reimplementation of state

Related #65


<EMAIL_ADDRESS>release to circleci orb repo

Orb version:
1.1.0

What happened:
nx<EMAIL_ADDRESS>is not available in the circleci orb repository.

Expected behavior:

Can you publish the latest release to the circleci orb repository?
The current available version is 1.0.0.  version 1.1.0 includes the CIRCLE_API_TOKEN change that is necessary to derive the correct SHAs from the circleci API.
Additional Information:

Hi @michael-golden, thank you for reaching out.
We are trying to resolve it. Hopefully, it will be solved very soon.
Check the thread on the original PR here: https://github.com/nrwl/nx-orb/pull/3

We have released the version 1.1.0 today. Please let us know if there are any issues.


Rendering richtext draft-js atomic block loses children

const getAtomic = (children, { data, keys }) =>
  data.map((item, i) =>
);

Rendering the children here is important, when redraft attempts to group the atomic group with the next group, the children are lost. I don't know enough of draft-js, but for my case it worked something like this:
const getAtomic = (children, { data, keys}) => (
{children}
);

As far as I understand, atomic blocks are meant to signal, in draft-js, that some content "belongs together", so that it would be deleted completely on backspace key. So it makes sense to rewrite it as above.

I guess that's something that @robgietema or @sneridagh need to look into.

This issue can be closed since draft js editor has been dropped in favor of Slate editor.


Document PyTest, OpenTelemetry and Jaeger integration

PyTest has an OpenTelemetry plugin to generate traces.
Need to:

Add pytest-opentelemetry==0.6.2 to requirements.dev
Document in the readme that users can generate traces by running pytest --export-traces to a local collector on http://localhost:4317 (gRPC only)
Link to the docs here: https://github.com/chrisguidry/pytest-opentelemetry

@viktoriussuwandi GitHub being annoying again. Can you comment so I can assign (just in case someone else comes and starts working on this). Trying to prevent people doing work which isn't merged :) Thanks

No problem @agardnerIT


Add hint to using CLI to install plugins

I've spent a considerable amount of time trying to debug why the plugins wouldn't show up in the Add Plugin form in the dashboard. Maybe it's missing because most people start with the prepopulated DB? If so, wouldn't it be better to add some of this to the init db script?

Thanks for the PR. I think it would be better if we add a new section called Install here and we reference it here.

We may want to take the opportunity and fix the dispatch command in the List section where we say dispatch database list instead of dispatch plugins list.

@caioaao thanks for fixing the command. Not sure if you saw my suggestion in this comment: https://github.com/Netflix/dispatch/pull/2569#issuecomment-1266089197


Vardict paired germline

Yo Brad,
This pull request will help us run paired VarDict bare, without any of the paired filtering. Should be used with caution.

Thanks so much for tackling this Miika.


Front-end | Upload Image file to Flutter

Nagawa na initial. But need optimization. Yung "body" as img_file_type, img_file_name, img_file_path(inside CI3).


Composer

I might be being a dope here, but i've added eden core via packagist/composer, but for some reason its not being auto-loaded. Am I missing something?

Please see: https://github.com/Eden-PHP/Core/commit/8922380af1d7e7ca877fee1faec61d65c76763b1
If this didn't help you reply here :)

ta


document building from local packages

cc @strongjz

I tried the local packages docs here but ran into an issue. It may well be my setup but the error was
│ Error: Invalid index
│
│   on tflib/version-tags/main.tf line 13, in output "tag_list":
│   13:   ][0][0]
│     ├────────────────
│     │ var.config.contents.packages is list of string with 24 elements
│     │ var.package is "kube-fluentd-operator"
│
│ The given key does not identify an element in this collection value: the collection has no elements.
╵
╷
│ Error: Invalid index
│
│   on .terraform/modules/kube-fluentd-operator.latest.this/main.tf line 75, in resource "cosign_attest" "slsa-provenance":
│   75:         for k in data.apko_config.this.config.contents.packages : split("=", k)[0] => split("=", k)[1]
│
│ The given key does not identify an element in this collection value: the given index is greater than or equal to the length of the collection.

the main.tf for my kube-fluentd-operator  module has this
module "version-tags" {
  source  = "../../tflib/version-tags"
  package = "kube-fluentd-operator"
  config  = module.latest.config
}

I tried the local packages docs here but ran into an issue. It may well be my setup but the error was

This error indicates that one of the packages in image had an inconsistent version between the two architectures. This is definitely not clear from the error message, so we should both a.) improve the error message, and b.) document it here in TERRAFORM.md.
But at least this isn't an indication that the build instructions in general aren't right, just that you hit a weird temporary case that we're working to fix.
Thanks for testing it out!

Ah that explains it - thanks.  Yeah it started working as soon as I specified the arch, I'm guessing because when I copy my local ./packages folder it only contains arm apks and not x86.
One bit of feedback - I found that when I build a local apk and copy the ./packages folder to the root of my images fork to test... terraform doesn't recognise that there's a new apk and uses the previously built image.  For a while I thought I was testing my latest fixes but an old image was being deployed via the test.
My workaround is to add an env var to my apko config and bump the value each time I copy new packages.  I'm sure there's a better terraform approach to do this.


[FR] - Add multiarch support for the docker image

Internal/External
External
Area
Docker
Describe the feature you'd like
The current docker image runs on x86_64 only. I'd like to expand the range of supported architectures to arm64 and possibly others as well. Initially this will involve building the binaries for arm64, which currently is only possible through convoluted workarounds AFAIK.
Additional context / screenshots
We already have support for arm64 in nessusio/cardano-node so it would be a matter of finding a way to do something similar or better for inputoutput/cardano-node.

Duplicates #2361


Rename Hubot at runtime using respondPattern

Second implementation for #1093 (first was #1104); this pull request adds a changeName method to Robot to change its name at runtime. It updates the name and the respond listeners.
It reconstructs listeners using respondPattern. The original regex are saved in the RespondListener objects.
Should respond also notify the @adapter of the name change? (I suppose the server, too, needs to change the bot's name.)

My use case for this has to do with IRC. Under certain conditions, Hubot can be assigned an alternate nickname when connecting to the server. I'd like to be able to reassign the primary name when it becomes possible, without restarting Hubot.
I imagine this could prove useful in other situations.

From the first pull request (#1104):

If people change the name, do you think they'd want to change the alias too?

I can't think of a case where the alias would need to be changed regularly, but maybe that should be possible, at least to be consistent.

I'd also wonder if there's any caveats to supporting this. Imagine I'm talking to hubot in one room, and someone changes the name somewhere else. I'd expect hubot to still be respond, but it'd start silently ignoring me until I found the new name.

Maybe Hubot could announce his new name?

Note: I haven't updated scripting.md yet.

My use case for this has to do with IRC. Under certain conditions, Hubot can be assigned an alternate nickname when connecting to the server. I'd like to be able to reassign the primary name when it becomes possible, without restarting Hubot.

Thanks for sharing the use case, that helps a lot.
I was doing some commit history spelunking Friday to figure out we have code like https://github.com/github/hubot/blob/master/bin/hubot#L135 to only load scripts AFTER the adapter has connected. git blame brings us back to https://github.com/github/hubot/pull/220 which sites this as a primary reason:

Adapters don't have a chance to customize the robot before scripts start loading.
This can cause problems if the adapter determines the robot's name.

If that's the case, I suspect the IRC adapter could get a name from the server and update the robot before emitting the connected event.

After I hit comment, it occurred to me even if an irc hubot got a different name at startup (ie hubot_ or whatever convention), it'd probably want to change it's name to it's proper name once it's available. That means this rename at runtime could still be useful.

If that's the case, I suspect the IRC adapter could get a name from the server and update the robot before emitting the connected event.

Thanks for the explanation :+1:
I'll look into it and will open a pull request in the repository of the IRC adapter ;)

After I hit comment, it occurred to me even if an irc hubot got a different name at startup (ie hubot_ or whatever convention), it'd probably want to change it's name to it's proper name once it's available. That means this rename at runtime could still be useful.

Actually, that was exactly my use case before I started investigating. I hadn't noticed that Hubot internal name was different from the server's.

doh, I forgot about documentation! 😭
When I mentioned edge cases, I was referring to bugs that arise as a result of changing the name.


Support of buf.build

As title says, it would bice nice if this package was compatible with https://buf.build/ remote plugins, like swagger, grpc-gateway and so on.
Thank you, Nicolas.

Yes!

@nicolasvac @jpfourny I'm soooooo sorry for being late reply.
I've just published to BSR https://buf.build/ysugimoto/grpc-graphql-gateway hope this help you.


Support Rust linter Ruff

Ruff is a Python linter written in Rust. It's compatible with Black and paired with Flake8. It's quite fast.
I think we should support this linter too.

@dinhanhx We have a template that you can use to create your own linter extension. See here: https://github.com/microsoft/vscode-python-tools-extension-template . We created this template to make it easier for the community to build and provide extensions that work with the core python extension. I recommend trying it out.

I created own ruff extension using the template @karthiknadig suggested:
https://user-images.githubusercontent.com/17039389/190895128-dc8263db-3744-4d6c-a815-06537b2fd43e.mov
Source code: https://github.com/harupy/vscode-ruff/pull/1

Thanks @harupy for creating the extension and showing that the template can work with ruff. Hopefully someone from the community can take on the project and publish it.
@dinhanhx the intent with the templates was to allow python community to build extensions for their favorite tools. The python extension itself is migrating to the model where the tools, based on the usage that we see, will have their own extension. So far, we have created, pylint, flake8, black and isort extensions. Unfortunately, we won't be able to take on ruff linter.

There is now a ruff extension: https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff
Thanks @charliermarsh


[ISSUE #773]🔥Optimize Topic request handle⚡

Which Issue(s) This PR Fixes(Closes)

Fixes #773
Brief Description

How Did You Test This Change?

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥


Introduce endpointconfig and endpoint controller

Description of Changes

Add controllers for endpoint config and endpoint resources
Following is the specialized code related to endpoint and a brief explanation for each:

custom_set_output: modifies the Status/Spec of the CR after create/describe/update operation

This PR adds functionality to modify the Status.Conditions and set TempOutofSync condition to true unless endpoint is in InService or Failed state so the reconcile does a periodic requeue until a stable state is achieved

custom_update_api: intercept methods that trigger an update on an endpoint

This PR adds functionality to do a periodic requeue until the endpoint is not in InService or Failed state

custom_update_conditions: update conditions based on the status of resource which is not an AWS API error. e.g. Endpoint being in Failed status is a terminal state for the controller.

This PR adds a check for the example stated above. In future will add more functionality like when an update fails etc.

keep the resources in ignore list for which controllers exist as commented out for easy reference in future

ignore UpdateTrainingJob API for now since it is a special case, only allows modifying few fields and not compatible with the current code-gen pattern

Testing
Integ test: aws-controllers-k8s/community#699
Unit test for custom code: will do in a separate PR
Notes
Can we merged only after:

aws-controllers-k8s/runtime#6
aws-controllers-k8s/code-generator#23

cc Sagemaker Developer Preview

@jaypipes

I don't actually see anything in this patch that requires a custom sdkFind or sdkDelete method?

here are the related methods which needed that PR.
generator.yaml
operations:
  ...
  DescribeEndpoint:
      set_output_custom_method_name: customDescribeEndpointSetOutput // defined in custom_set_output.go
  DeleteEndpoint:
      custom_implementation: customDeleteEndpoint // defined in custom_update_api.go

Ready to merge @jaypipes @RedbackThomson


feat(p-tag): renewal p-tag

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[ ] Not that difficult

Type of Change

[ ] New feature
[ ] Bug fixes
[x] Feature improvement

[x] These changes require a usage change

[ ] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[x] Updated Storybook documents
[ ] Tested with console

Description

add 'Category' spec
add keyItem, valueItem and categoryItem props.
add key, value and category slots.
update storybook
add mock data

Things to Talk About

@minseolee @WANZARGEN
I reflected your opinions.

fix some awkward value in style
prevent side effects that may happen
fix awkward context in docs
change priority between name and label
other points to improve

Thank you for reviewing!

:tada: This PR is included in version 1.1.0-beta.419 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


🐛 [Bug report]: Tons of calls being made on play refresh

Descrcibe the bug?
When you refresh a play page, there are many calls being made which are not related to the page.
Steps to reproduce the bug?

Open reactplay.io
Browse plays
Open any play
Open developer console
Refresh the page
Notice network tab

Expected behavior
Only relevant data needs to be fetched
Desktop (Please provide your system information)
ALL
Mobile (Please provide your device information)
No response
Screenshot / Screenshare
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to work on this @koustov.

I would like to work on this @koustov.

Sure @Sachin-chaurasiya

@Sachin-chaurasiya I suppose this is related to #894

@Sachin-chaurasiya I suppose this is related to #894

Okay, I will investigate it.


Incomplete tuple matching

This is more of a question than a feature request.
In rubocop-rspec's cops there are two patterns have redundancy.

RSpec/SubjectStub

{
  (block (send nil? :subject (sym $_)) ...)
  (block (send nil? $:subject) ...)
}

It is supposed to capture :subject or the subject's name from:
subject { ... }
# or
subject(:name) { ... }

What makes me think it's redundant?

an equal number of captures
same wrapping, e.g. base of the tree is the same

What makes it impossible to turn this into:
(block
  (send nil?
    {
      :subject (sym $_)
      $:subject
    }
  )
  ...
)

is that {} would consider all three expressions as matching options, and there is no way (that I'm aware of) to match two or more subsequent nodes that do not compose a complete sequence (terminology may be distorted, hope the idea is clear though).

The same applies to another cop, RSpec/DescribeClass:

          (block
            [  (send #{RSPEC} :describe $[!const !#string_constant?] ...)
              !(send #{RSPEC} :describe ... (hash <#rails_metadata? ...>)) ]
            ...
          )

It can't be:
(block
  (send #{RSPEC} :describe
    [
      $[!const !#string_constant?] ...
      ... !(hash <#rails_metadata? ...>)
    ]
  )
  ...
)

because there's no way to combine those (newline-separated) elements into tuples.
I would really prefer to keep Node Pattern syntax simple. And, unlike the previously introduced unordered sequence (<>) there's much of a compelling benefit since I could only find two cops that would just slightly (and arguably) benefit from that.
On the other hand, <> is present already, but it disregards the order. Maybe it's possible somehow to respect the order given some specifier?
Not a real proposal, just thinking aloud:
(block (send nil? { <- :subject (sym $_)> $:subject } ) ... )

(Couldn't compile due to invalid token "<".)
(block
  (send #{RSPEC} :describe
     <- $[!const !#string_constant?] ...>
    !<- ... (hash <#rails_metadata? ...>)>
  ) ...)

where <- > is an "ordered sequence".
I didn't look much into RuboCop core's cops, can't estimate if any of them could benefit from such syntax.

Yes, I was thinking about that the other day.
One way would be to extend the syntax in the following way:
{ int int int | sym } => a sequence of 3 ints or a single sym.
{ int sym str } would just be a shorthand for { int | sym | str }

Ha, { | } looks great 👍
I don't insist on [ | ], since:

there's just a single use case for it
I doubt that the following is even readable

(block
  (send #{RSPEC} :describe
     [$[!const !#string_constant?] ... | ... !(hash <#rails_metadata? ...>)]
  ) ...)

Right. Does it actually require the outer []? Can you call RSpec.describe :directly => 'without first argument'
(block
  (send #{RSPEC} :describe
     $[!const !#string_constant?] ... !(hash <#rails_metadata? ...>)
  ) ...)

The only issue with { | } is that it would require to go from the current recursive descent to having an actual AST first and then compiling it, I see no other way.
I kind of had to do that a bit with my Compiler::Sequence class that is kind of a hack, so I think the resulting code might even be nicer.
Other possibility would be to introduce a different notation, say | int int int || sym | instead of { int int int | sym }

I would expect
(block
  (send #{RSPEC} :describe
     $[!const !#string_constant?] ... !(hash <#rails_metadata? ...>)
  ) ...)

to work, but it doesn't, as it doesn't match if there's no hash at all, but it should:
describe 'class' do # Alarma! Should be camel case!
end

RSpec's legit syntax is very permissive in this regard, e.g.:
describe 'Class', '#method', :symbol_metadata, hash_metadata: true do
  # ...
end

{ int int int | sym } looks best to me if you ask, and {{ | }} is not bad either.
I really don't want to push you for a major refactoring for a relatively rarely used feature. No rush. Consider this a crazy idea with intangible value on par with my other today's tickets.

to work, but it doesn't,

(type x ... y) #=> children.size >= 2 for any x and y, even if y is !<something>.

Done and released.

Thank you!


Apply for SANTA CASA CHALLENGE

see: http://mais.scml.pt/casadoimpacto/challenge/
We need to be registered as a Collective Person, which require NPO status.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.
Blocked By:

[BLOCKING: #20, #392, #394, #397] [@schowdhury8, @puzzledbytheweb] #394 - Register as NGO / NPO

We won't be able to because we missed the deadline to get NPO status


Implemented additional rancher::server parameters and accompanying tests

Hi Gareth,
I'm back with another pull request: I've added a few new parameters for rancher::server, along with rspec tests. The new parameters allow for the use of an external database container, along with the ability to specify custom DNS servers, DNS search domains, and Docker container name. Please let me know what you think and if there's anything you'd like me to add.
Cheers,
Isaac

@garethr  I'm not sure why the tests are failing - any ideas?

Thanks @IsaacJT, this looks great. Much appreciated.


County deaths in Florida are crazy

Looks like they must have dumped a big backlog of deaths, in every single county in Florida. E.g.

Possibly related to https://github.com/CSSEGISandData/COVID-19/issues/5196

This spike hasn't been fixed in subsequent revisions. The data later in 2022 continues to behave very oddly (e.g. see large negative spike), so not clear that this is worth patching. TBD


fixed shared windows 10 PC link

The url was having a .md extension, which was the issue

@greg-lindsay @TrudyHa - can you please assist to check, approve and merge the content for this PR based on issue #3078?
Thank you.

@Malind19 The .md suffix is required when linking within a project, the problem is probably the relative path. I'll fix the link on our side, thanks.


comments-time-machine-links doesn't work with branches that have slashes

Example URL:
https://github.com/Cog-Creators/Red-DiscordBot/issues/2988

For files that still exist, this will be fixed by https://github.com/sindresorhus/refined-github/issues/2618
For deleted files, it's complex to fix it because branch/still-branch looks the same as branch/folder in the URL. Since the file is deleted, the URL is the only piece of information we have.

I looked into this. This is github's issue

https://github.com/Cog-Creators/Red-DiscordBot/tree/master@{2019-09-07T19:14:39Z}
It links it to a commit

https://github.com/Cog-Creators/Red-DiscordBot/tree/V3/develop@{2019-09-07T19:14:39Z}
If the branch has a slash it does not. Not only that going into any file/folder will fail

It's a GitHub "bug" in the sense that slashed/branch@{timestamp} URLs work for the root, but they stop working as soon as you open a file/folder. Please report it.

Open https://github.com/Cog-Creators/Red-DiscordBot/tree/V3/develop@{2019-09-07T19:14:39Z}
Open any file or folder

As for this specific bug, the URL that RGH generates is technically correct and detects the slashed/branch correctly:
https://github.com/Cog-Creators/Red-DiscordBot/blob/V3/develop@%7B2019-09-07T19:14:39Z%7D/redbot/core/events.py#L166

It's just that it doesn't work because of GitHub. I don't think this can be fixed by us unless we drop the @{timestamp}

Please report it.

Submitted

Solution: don't use @{date} publicly.
We have to query the API to transform that {branch}@{date} into a commit
Easy temporary solution: use HEAD@{date} when the branch contains a slash. It's might not be correct, but it's better than a 404

Submitted

Hello yakov116,
Thanks for writing in, and we're really sorry it's taken so long to respond to you. Apologies for the delays.
I have looked into this, and unfortunately using reflog-based syntax like @{} in GitHub URLs isn't officially supported. This means that the syntax is not reliable and might change or be fully removed in the future. We previously had some examples of this syntax in our help docs, but the examples were removed last winter to prevent confusion.
Sorry about that, but please let us know if there is anything else we can do for you and we will be happy to assist!
Thanks,
Tammy
GitHub Support


Change redeem to token ids for 721 and add erc721 ticket support

@hboon always returns 1 balance even if there is no balance

@James-Sangalli I missed this earlier: do you want to add an .erc721ForTicketTokens case to TokenInterfaceType?

@James-Sangalli I missed this earlier: do you want to add an .erc721ForTicketTokens case to TokenInterfaceType?

@James-Sangalli Sorry! My bad, James. It's parsed and extracted from the TokenScript file. So we don't need (and can't have) erc721ForTicketTokens/erc721Ticket. So your original way of checking the contract is correct.

All good otherwise. Merge when you are done with removing the directory :P


E2e latency rebase

Using https://github.com/kubernetes/kubernetes/pull/14055 as a reference I updated the last commit to build on current HEAD.

Opening a new PR upstream instead.


I cannot run unittest

Description
What steps will reproduce the problem?

I cannot run unittest.
i typed def TestEmployee(unittest.TestCase):
and it said it is invalid syntax.
When i run the code, it duplicated in my code
Traceback
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2093, in _save_file
    self.modification_changed(index=index)
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2550, in modification_changed
    finfo = self.data[index]
IndexError: list index out of range
Traceback (most recent call last):
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2093, in _save_file
    self.modification_changed(index=index)
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2550, in modification_changed
    finfo = self.data[index]
IndexError: list index out of range
Traceback (most recent call last):
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2093, in _save_file
    self.modification_changed(index=index)
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2550, in modification_changed
    finfo = self.data[index]
IndexError: list index out of range
Traceback (most recent call last):
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2093, in _save_file
    self.modification_changed(index=index)
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2550, in modification_changed
    finfo = self.data[index]
IndexError: list index out of range
Traceback (most recent call last):
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2093, in _save_file
    self.modification_changed(index=index)
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2550, in modification_changed
    finfo = self.data[index]
IndexError: list index out of range
Traceback (most recent call last):
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2093, in _save_file
    self.modification_changed(index=index)
  File "D:\Desktop\pkgs\spyder\plugins\editor\widgets\editor.py", line 2550, in modification_changed
    finfo = self.data[index]
IndexError: list index out of range

Versions

Spyder version: 4.2.1
Python version: 3.7.9
Qt version: 5.12.10
PyQt5 version: 5.12.3
Operating System: Windows 10

Dependencies

# Mandatory:
atomicwrites >=1.2.0            :  1.4.0 (OK)
chardet >=2.0.0                 :  4.0.0 (OK)
cloudpickle >=0.5.0             :  1.6.0 (OK)
diff_match_patch >=20181111     :  20200713 (OK)
intervaltree                    :  None (OK)
IPython >=7.6.0                 :  7.19.0 (OK)
jedi =0.17.2                    :  0.17.2 (OK)
jsonschema >=3.2.0              :  3.2.0 (OK)
keyring >=17.0.0                :  21.5.0 (OK)
nbconvert >=4.0                 :  6.0.7 (OK)
numpydoc >=0.6.0                :  1.1.0 (OK)
paramiko >=2.4.0                :  2.7.2 (OK)
parso =0.7.0                    :  0.7.0 (OK)
pexpect >=4.4.0                 :  4.8.0 (OK)
pickleshare >=0.4               :  0.7.5 (OK)
psutil >=5.3                    :  5.7.3 (OK)
pygments >=2.0                  :  2.7.3 (OK)
pylint >=1.0                    :  2.6.0 (OK)
pyls >=0.36.2;<1.0.0            :  0.36.2 (OK)
pyls_black >=0.4.6              :  0.4.6 (OK)
pyls_spyder >=0.3.0             :  0.3.0 (OK)
qdarkstyle >=2.8                :  2.8.1 (OK)
qtawesome >=0.5.7               :  1.0.2 (OK)
qtconsole >=5.0.1               :  5.0.1 (OK)
qtpy >=1.5.0                    :  1.9.0 (OK)
rtree >=0.8.3                   :  0.9.4 (OK)
setuptools >=39.0.0             :  51.0.0 (OK)
sphinx >=0.6.6                  :  3.3.1 (OK)
spyder_kernels >=1.10.1;<1.11.0 :  1.10.1 (OK)
textdistance >=4.2.0            :  4.2.0 (OK)
three_merge >=0.1.1             :  0.1.1 (OK)
watchdog                        :  1.0.2 (OK)
zmq >=17                        :  20.0.0 (OK)

# Optional:
cython >=0.21                   :  0.29.21 (OK)
matplotlib >=2.0.0              :  3.3.3 (OK)
numpy >=1.7                     :  1.19.3 (OK)
pandas >=1.1.1                  :  1.1.5 (OK)
scipy >=0.17.0                  :  1.5.4 (OK)
sympy >=0.7.3                   :  1.7.1 (OK)

i typed def TestEmployee(unittest.TestCase):
and it said it is invalid syntax.

It should be class TestEmployee(unittest.TestCase): and not def ....
I don't know about the other error ("IndexError: list index out of range").

i typed def TestEmployee(unittest.TestCase):
and it said it is invalid syntax.

It should be class TestEmployee(unittest.TestCase): and not def ....
I don't know about the other error ("IndexError: list index out of range").

Hi @BeanTJH, thanks for reporting. Could you generate an animated gif of your problem and upload it here? That would be really helpful to us.
You can use the Licecap program for that.

Hi @BeanTJH, thanks for reporting. Could you generate an animated gif of your problem and upload it here? That would be really helpful to us.
You can use the Licecap program for that.

Closing because @BeanTJH reported this problem is solved on issue #14605.

Closing because @BeanTJH reported this problem is solved on issue #14605.


[Event Request] Table 38 - Purchase Header - OnValidate Receiving No. Series/Return Shipment No. Series

Hi Team,
can you please add OnBefore and OnAfter events in "Receiving No. Series" and "Return Shipment No. Series" fields validation? This will be helpful to use custom logics and avoid system to check no. series versus standard setup.
Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


idris2-<IP_ADDRESS> fails in windows

Steps to Reproduce

follow installation intructions in a windows machine (tested in windows 10)

Expected Behavior

idris2 should work

Observed Behavior

idris2 helloworld.idr -o main fails with File error in helloworld.idr: Error code: 5
idris2 fails with

Uncaught error: Error: Module Prelude not found

(Interactive):1:1--1:1

more info:

PS D:\dev\ws\idris> idris2 --paths
+ Working Directory      :: "D:\\dev\\ws\\idris"
+ Source Directory       :: Nothing
+ Build Directory        :: "build"
+ Local Depend Directory :: "depends"
+ Output Directory       :: "build\\exec"
+ Installation Prefix    :: "D:\\dev\\app\\idris2-<IP_ADDRESS>\\env"
+ Extra Directories      :: [".", "D:\\dev\\app\\idris2-<IP_ADDRESS>\\env\\idris2-0.6.0\\prelude-0.6.0", "D:\\dev\\app\\idris2-<IP_ADDRESS>\\env\\idris2-0.6.0\\base-0.6.0"]
+ Package Directories    :: []
+ CG Library Directories :: ["D:\\dev\\app\\idris2-<IP_ADDRESS>\\env\\idris2-0.6.0\\lib", "D:\\dev\\ws\\idris"]
+ Data Directories       :: ["D:\\dev\\app\\idris2-<IP_ADDRESS>\\env\\idris2-0.6.0\\support"
PS D:\dev\ws\idris> $env:IDRIS2_PREFIX
D:\dev\app\idris2-<IP_ADDRESS>\env

Thanks in advance!

Thank you for raising this issue! I know you mentioned this issue in Discord as well but sorry, I couldn't get to it yet. I will look into it as soon as possible.

@mmhelloworld thanks for take care! currently i am trying to bootstrap idris-jvm but i am not sure what would be the correct steps, the default install methid needs a prior idris2 with jvm support

That is correct. It needs a previous version of Idris JVM backend compiler which is available in Maven central.

@mmhelloworld thanks, i tried first the regular installation but the same error reported in the issue makes the installation fail:
$  mvn -B install -Didris.tests=only=jvm
mkdir -p D:/dev/ws/idris/idris-jvm/idris-jvm-compiler/target/classes
echo idris.version=0.6.0 > D:/dev/ws/idris/idris-jvm/idris-jvm-compiler/target/classes/config.properties
make[1]: Entering directory '/d/dev/ws/idris/idris-jvm/support/c'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/d/dev/ws/idris/idris-jvm/support/c'
make[1]: Entering directory '/d/dev/ws/idris/idris-jvm/support/refc'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/d/dev/ws/idris/idris-jvm/support/refc'
make[1]: Entering directory '/d/dev/ws/idris/idris-jvm/support/chez'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/d/dev/ws/idris/idris-jvm/support/chez'
echo "-- @""generated" > src/IdrisPaths.idr
echo 'module IdrisPaths' >> src/IdrisPaths.idr
echo 'export idrisVersion : ((Nat,Nat,Nat), String); idrisVersion = ((0,6,0), "f7ef1dbb0")' >> src/IdrisPaths.idr
echo 'export yprefix : String; yprefix="D:/ghcup/msys64/home/atrey/.idris2"' >> src/IdrisPaths.idr
idris2 --build idris2.ipkg
Uncaught error: File error (idris2.ipkg): Error code: 5
make: *** [Makefile:67: /d/dev/ws/idris/idris-jvm/build/exec/idris2] Error 1
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (idris-compile) on project idris-jvm-compiler: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :idris-jvm-compiler

so i can't test a possible fix, is there no way to bootstrap idris jvm, even with a idris2 with no jvm support?

With this change now in main branch, there is a snapshot release here. Could you please try using this as the bootstrap compiler? If it works, we can release this as a new stable version.

Hi, ive tried it but no luck:
PS D:\dev\ws\idris> idris2 --paths
+ Working Directory      :: "D:\\dev\\ws\\idris"
+ Source Directory       :: Nothing
+ Build Directory        :: "build"
+ Local Depend Directory :: "depends"
+ Output Directory       :: "build\\exec"
+ Installation Prefix    :: "D:\\dev\\app\\idris2-0.6.1-SNAPSHOT\\env"
+ Extra Directories      :: [".", "D:\\dev\\app\\idris2-0.6.1-SNAPSHOT\\env\\idris2-0.6.0\\prelude-0.6.0", "D:\\dev\\app\\idris2-0.6.1-SNAPSHOT\\env\\idris2-0.6.0\\base-0.6.0"]
+ Package Directories    :: []
+ CG Library Directories :: ["D:\\dev\\app\\idris2-0.6.1-SNAPSHOT\\env\\idris2-0.6.0\\lib", "D:\\dev\\ws\\idris"]
+ Data Directories       :: ["D:\\dev\\app\\idris2-0.6.1-SNAPSHOT\\env\\idris2-0.6.0\\support"]
PS D:\dev\ws\idris> gcm idris2

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     idris2.bat                                         <IP_ADDRESS>    D:\dev\app\idris2-0.6.1-SNAPSHOT\exec\...

PS D:\dev\ws\idris> idris2 .\helloworld.idr
     ____    __     _         ___
    /  _/___/ /____(_)____   |__ \
    / // __  / ___/ / ___/   __/ /     Version 0.6.0-d51a3d313
  _/ // /_/ / /  / (__  )   / __/      https://www.idris-lang.org
 /___/\__,_/_/  /_/____/   /____/      Type :? for help

Welcome to Idris 2.  Enjoy yourself!
File error in .\helloworld.idr: Error code: 5

@jneira I've fixed the Windows issue. Please try out <IP_ADDRESS> and let me know if you still run into issues.

@mmhelloworld finallly i get some time to test the new version and it works fine in my windows 11 laptop, thanks for take care!


[NativeAnimated][Android] Modulo node

This diff adds ModuloAnimatedNode on iOS. It separates out code originally submitted in #9048.
Test plan (required)
Set up an animation with a modulo node, and useNativeModule: true. Compare results with useNativeModule: false.

By analyzing the blame information on this pull request, we identified @buba447 and @janicduplessis to be potential reviewers.

👍
@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.


added voiceSurvey

Implemented voice assessment and associated files

similar issue to https://github.com/Watts-Lab/surveys/pull/52 re: response text ordering and formatting


[hstr 3.0] pressing Esc on system w/o TIOCSTI outputs page full of garbage

I just installed hstr 3.0 on my Arch Linux system w/o TIOCSTI and replaced the hstr config in my .bashrc with the output of hstr --show-configuration. Then I opened a new console.
When I invoke hstr with Ctrl+R and then abort it by pressing Esc, instead of getting my shell prompt back immediately, it waits for another key press and then outputs a page full of garbage. It looks to have grabbed some lines from my .bash_history and shortened long lines by putting … at the end, and line endings are replaced with a ^M^[[<nr>d sequence where <nr> is a number starting from 1 and counting up for each next line.
Example of what happens after pressing Esc, to abort hstr;

I think there's a problem with this function from hstr --show-configuration output:
function hstrnotiocsti {
    { HSTR_OUT="$( { </dev/tty hstr ${READLINE_LINE}; } 2>&1 1>&3 3>&- )"; } 3>&1;
    READLINE_LINE="$(hstr ${READLINE_LINE})"
    READLINE_POINT=${#READLINE_LINE}
}

If I replace that with the previous code, from hstrcygwin function in https://github.com/dvorka/hstr/pull/481#issue-1630468851, then hstr works as expected and pressing Esc cleanly aborts it:
function hstrnotiocsti {
    offset=${READLINE_POINT}
    READLINE_POINT=0
    { READLINE_LINE=$(</dev/tty hstr ${READLINE_LINE:0:offset} 2>&1 1>&$hstrout); } {hstrout}>&1
    READLINE_POINT=${#READLINE_LINE}
}

@jakedane great catch! It is reproducible. I wanted to make Bash and Zsh functions as similar as possible (simplification and maintenance)... however, it clearly does not work. I will strive to release the fixed version as soon as possible. Thank you for the bug report and Cygwin function test!

Hints:

unfortunately I didn't tested Bash version enough and I left Zsh version in the Bash code:

v buggy version
{ HSTR_OUT="$( { </dev/tty hstr ${READLINE_LINE}; } 2>&1 1>&3 3>&- )"; } 3>&1;
{ READLINE_LINE="$( { </dev/tty hstr ${READLINE_LINE}; } 2>&1 1>&3 3>&- )"; } 3>&1;
^ fixed version

:facepalm:

@jakedane ... actually I think that it might need initialization in certain cases ... still testing the new version...

There were actually two :lady_beetle: in the original function :facepalm:
function hstrnotiocsti {
    { HSTR_OUT="$( { </dev/tty hstr ${READLINE_LINE}; } 2>&1 1>&3 3>&- )"; } 3>&1;    <--- BUG: HSTR_OUT var is wrong
    READLINE_LINE="$(hstr ${READLINE_LINE})"     <--- BUG: this row is not needed at all
    READLINE_POINT=${#READLINE_LINE}
}

@jakedane thank you for your help!

3.1 manpage still shows the incorrect bash config

there is also still an issue in hstrnotiocsti, there should be a -- added after hstr:
{ READLINE_LINE="$( { </dev/tty hstr -- ${READLINE_LINE}; } 2>&1 1>&3 3>&- )"; } 3>&1;
otherwise the following wouldn't work:
$ --help [ctrl-r]


Install podman from kubic on 22.04 Ubuntu instead of building the package manually.

When switched cicd pipeline to use ubuntu 22.04 we started to see static IP addressing tests fail for podman runtime.
No idea what caused that (could very well be netavark requirement?), so will just remove those tests for podman runtime, wishing podman would be friendlier for ubuntu systems in future.
https://github.com/srl-labs/containerlab/actions/runs/4403903309/jobs/7712930803
It still passes with 20.04 - https://github.com/srl-labs/containerlab/pull/1290
/cc @LimeHat in case you want to dive deep into any of that =)

Will take a look. yes netavark broke a things here and there and I kept it on the backburner for a while.

I've stripped down the topo to only contain node l2 and the correct static mgmt ip is assigned.
Polishing my shovel now, getting ready to dig deeper.

good stuff, @steiler
I think the root cause here is that in our CI we don't setup podman via kubic, as podman v4 was not available as a package for 20.04.
Since now we can install podman from kubic with the move to 22.04 we have to rework our cicd workflow to install from kubic, instead of building podman ourselves.
Do you want to try that? Else I can get to it later.

Yeah please go ahead.
This is what I had to do on a plain fresh ubuntu install:
https://github.com/vjayaramrh/one-summit-22-workshop/pull/3/files


Remove built in methods' function wrapper.

I removed the function wrapper for most class' built-in methods because they are marked as one of the hotspots when profiling. And for most cases, the wrapper function is unnecessary anyway.

@hachi8833 do you have time to help me rebase this? I'm afraid I might miss some of your changes if I do it myself 😓

OK, I'll look into it for rebasing.

Could you check https://github.com/goby-lang/goby/pull/747 for the workaround of rebasing? @st0012


feat(amplify-codegen): new codegen command of  model intropection

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] Breaking changes to existing customers are released behind a feature flag or major version update
[ ] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #476 (983866b) into main (750ba15) will decrease coverage by 0.04%.
The diff coverage is 82.00%.

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   85.89%   85.84%   -0.05%
==========================================
  Files         143      147       +4
  Lines        7070     7166      +96
  Branches     1855     1876      +21
==========================================
+ Hits         6073     6152      +79
- Misses        906      923      +17
  Partials       91       91

Impacted Files
Coverage Δ

...elgen-plugin/src/interfaces/introspection/index.ts
0.00% <0.00%> (ø)

...lugin/src/interfaces/introspection/model-schema.ts
0.00% <0.00%> (ø)

packages/appsync-modelgen-plugin/src/plugin.ts
0.00% <0.00%> (ø)

packages/appsync-modelgen-plugin/src/preset.ts
0.00% <0.00%> (ø)

...rc/visitors/appsync-model-introspection-visitor.ts
98.59% <98.59%> (ø)

...amplify-codegen/src/commands/model-intropection.js
100.00% <100.00%> (ø)

packages/amplify-codegen/src/commands/models.js
84.74% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fixes #614. Wrap the get_vcs method in a try-except block and catch t…

…he warning, then use the io writer to write with the very verbose mode.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once, it will save you unnecessary review cycles!

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.
If you have any questions to any of the points above, just submit and ask!  This checklist is here to help you, not to deter you from contributing!
I am not sure if you would like tests or documentation changed for this small change. If additional tests would be preferred, I think we would need to simulate git executable being missing, which seems somewhat strange. Happy to look into that if you'd like.
Best,
Xander

oops, branched off master, I'll open a different PR

Ugh I can't read - this is just a bug fix so I think master was correct actually.

Declined as per owner's thoughts re: #614


Support webmentions feed option in dendron-11ty

Please Select if your Request is Either something new or an Enhancement

[ ] Enhancement of an existing Feature.
[x] Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

[ ] UI
[ ] Workbench
[x] Publishing
[ ] Pods
[ ] Markdown
[ ] Hierarchy
[ ] Graph
[ ] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
I've been wanting to figure out the best way to gather comments, especially if my content is duplicated to multiple formats, or mentioned on multiple social media platforms.
For example, I export and re-post to a dev.to blog, which has comments in the discussion on that site. On Twitter, I share the link, and others comment about the article. Elsewhere, a link is shared or a blog points to my site and I have no idea about it. etc.
Describe the solution you'd like
It looks like webmentions are an excellent way to approach this, and there is a detailed post of someone implementing webmentions into their pages:

https://mxb.dev/blog/using-webmentions-on-static-sites

How the webmentions are rendered on the article: https://mxb.dev/blog/using-webmentions-on-static-sites/#webmentions

I think what would be cool about this is the potential for public vaults to carry their discussions/comments along with them, to wherever they are published. If not that, it would be cool to at least have the webmentions appear on the original published vault online.
I see myself making use of both https://webmention.app and https://webmention.io (which the 11ty example in the blog made use of) with my Dendron site.
Describe alternatives you've considered
The original problem for me was seeing how I can unify a distributed conversation, or if I could do something like embed the dev.to comments section in a post.
A different thing I've seen sites use is a Disqus account embedding on blog/article posts, allowing for a comment section to exist on the page. I like the problem Disqus is trying to solve, but Webmentions seems much better to me.

I've been thinking about this recently. Thanks for the 11ty example. Will
aim to have some form of this implemented in April :)
On Sun, Mar 14, 2021 at 8:53 PM Derek Ardolf @.***>
wrote:

Please Select if your Request is Either something new or an Enhancement

Enhancement of an existing Feature.
Request of a new feature.

Please select the area your request applys to. (Multiple selections are
Possible)

UI
Workbench
Publishing
Pods
Markdown
Hierarchy
Graph
Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
I've been wanting to figure out the best way to gather comments,
especially if my content is duplicated to multiple formats, or mentioned on
multiple social media platforms.
For example, I export and re-post to a dev.to blog, which has comments in
the discussion on that site. On Twitter, I share the link, and others
comment about the article. Elsewhere, a link is shared or a blog points to
my site and I have no idea about it. etc.
Describe the solution you'd like
It looks like webmentions are an excellent way to approach this, and there
is a detailed post of someone implementing webmentions into their pages:

https://mxb.dev/blog/using-webmentions-on-static-sites

How the webmentions are rendered on the article:
https://mxb.dev/blog/using-webmentions-on-static-sites/#webmentions

I think what would be cool about this is the potential for public vaults
to carry their discussions/comments along with them, to wherever they are
published. If not that, it would be cool to at least have the webmentions
appear on the original published vault online.
I see myself making use of both https://webmention.app and
https://webmention.io (which the 11ty example in the blog made use of)
with my Dendron site.
Describe alternatives you've considered
The original problem for me was seeing how I can unify a distributed
conversation, or if I could do something like embed the dev.to comments
section in a post.
A different thing I've seen sites use is a Disqus account embedding on
blog/article posts, allowing for a comment section to exist on the page. I
like the problem Disqus is trying to solve, but Webmentions seems much
better to me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/543, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABPIPRYXEFIEK4USK46M73TDWAEBANCNFSM4ZFX5OZA
.

Just to add the discussion, I've also been looking at how https://brid.gy/about works, but haven't tested it out just yet. The indieweb.org and webmentions concept is very new to me, so it is interesting seeing how others have worked to address things.


roreleaser upload error

Describe the bug
error uploading artifact when generating version
ref: https://github.com/prest/prest/actions/runs/4588950169/jobs/8103507036#step:14:115

added v1.2.4 so we dont bother fixing this error - was probably due to my tag delete + republish.


AttributeError: 'DataFrame' object has no attribute 'append'

masked_language_modeling

AttributeError                            Traceback (most recent call last)
/tmp/ipykernel_97675/3156859266.py in ?()
27
28 # FutureWarning: The frame.append method is deprecated and will be removed from pandas
29 # in a future version. Use pandas.concat instead.
30 # https://stackoverflow.com/questions/75956209/error-dataframe-object-has-no-attribute-append
---> 31 all_data = train_df.append(test_df)
32 # all_data = train_df.concat(test_df)
~/miniconda3/envs/tf/lib/python3.10/site-packages/pandas/core/generic.py in ?(self, name)
5985             and name not in self._accessors
5986             and self._info_axis._can_hold_identifiers_and_holds_name(name)
5987         ):
5988             return self[name]
-> 5989         return object.getattribute(self, name)
AttributeError: 'DataFrame' object has no attribute 'append'

The append() function has been deprecated. I change the line of code to adapt the new change.
from
all_data = train_df.append(test_df)
to
all_data = pd.concat([train_df, test_df])
Then I solve the issue.
Cheers!

Thanks for the update @mikechen66!


Tile layer with custom source subclasses from TileImage

Hello,
is it possible to add custom tile layer with my own source subclass which is in seperate file?
thanks

I'm doing some housekeeping and closing the issue since it's quite old. Please feel free to re-open it if it still persists. Also maybe try to upgrade to the latest version as it might fix it for you.


feat(PRLC100-85) : Add document summary page

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

This has been merged as part another PR https://github.com/hmcts/prl-citizen-frontend/pull/309.

Closing this.


Markdown Messages through Lambda

Does QnABot support markdown messages through lambda? Im trying to pass this "The Q and A Bot uses Amazon Lex and [Alexa]" as a string to event.res.message but it only shows "Amazon Lex" without having the link.

QnABot supports a markdown response field. You'll see this in the Advanced section in the Designer UI when editing a question. Valid markdown can be specified. QnABot returns this value in the appContext.altMessages session variable. The companion LexWebUi (which is also the sample web client in QnABot) will use this value and render markdown in the UI. See https://github.com/aws-samples/aws-lex-web-ui/blob/master/lex-web-ui/README.md#markdown-and-html-support.
{     "appContext":{         "altMessages":{             "markdown":"# hello!"         }     } }
If you are using a Lambda hook in QnABot for a question, the same session attribute can also be set by the lambda function in the result object.

Thank you!


custom $PATH not working in MakeFile

I have added my custom Bin Directories to path variable, which is ~/comp200/bin
bruce@DESKTOP-2FVE10N:/mnt/c/Users/Bruce/Documents/GitHub/winix$ echo $PATH
~/comp200/bin/:~/comp200/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games

In the normal terminal mode, command works fine as expected
bruce@DESKTOP-2FVE10N:/mnt/c/Users/Bruce/Documents/GitHub/winix$ wcc -help
wcc [ option | file ]...
        except for -l, options are processed left-to-right before files
        unrecognized options are taken to be linker options

but when I was trying to use MakeFile to compile, I received command not found
make[1]: wcc: Command not found

Hi @halfer53 -- hm, custom paths work fine for me.  What build of Windows are you running?  (Regular stable Windows, or if an Insider build, what build number?)  Does it help to add ~/comp200/bin to $PATH rather than ~/comp200/bin/?

Also try /home/you/comp200/bin. I don't recall how ~ expansion works in makefiles (and am too lazy to check). Normally (for some value of normal) I'd expect ~ to be expanded in the $PATH variable proper unless you single-quoted it when the variable was set. Eg:
$ export FOO=~/somewhere
$ echo $FOO
/home/ken/somewhere

thanks, it works now


fix: Change multiselect back to supporting numbers and boolean.

Description
Revert the validations change which converts multiselect options values to strings and path the filtering function to handle numbers and boolean
Fixes #7872, #7604
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/multiselect-default-values

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.82 (-0.01)
36.96 (-0.01)
33.8 (-0.01)
55.43 (-0.01)

:red_circle:
app/client/src/workers/validations.ts
73.91 (-1.09)
67.72 (-0.3)
62.5 (-3.13)
76.19 (-0.84)

@vivekverma2312 , Can you test this.

@SatishGandham Please find the list of issues

In Expected structure , value is still showing as only string

Passing value in Default value is not working when Expected value and example mention both value and array of value

Default value is not working with curly braces

Changing this might have impact on other things, since its only cosmetic, we will take care of it later.
Removed the string option from suggestion to discourage users from using it.
Working on it.

@somangshu , if you want to merge this please go ahead. We will take 3 as a separate issue.

@SatishGandham would any map on inside the curly brace work? In that case we could take up the issue later.

@SatishGandham would any map on inside the curly brace work? In that case we could take up the issue later.

They will. Only single values don't.


Strange experience

The opposing BOTs are grouping together, and the teammate BOTs are going up like individuals to give away heads

try to ping the bots to do things you want. may not always do what you want because i do not have the time to make improvements to support the ping command for many situations. but just try it.
You are not a bot, you dont follow what bots do so bots dont seem to group up with you. That's ultimately the actual reason

I dont have a plan to add this layer of cooperation between human + bots. So for now, try you best to lead or work with your ally bots. Or help me to build this layer of support.

OK, I understand


Hot reloading DLL no longer works

I used to be able to hot reload a video game DLL and the debugger picking up the new PDB automatically. It just worked. But now it no longer seems to load the PDB for the new DLL.
What I do is this:

I build game.dll and game.pdb
My host application copies game.dll to game_X.dll where X is a number
The host application loads game_X.dll

When I step into code that uses the new DLL, then I end up at garbage debug symbols, which hints to me that it is still using the old PDB.

I investigated this a bit more, if I write the pdb with a new file each time, then it works. In the past, I think it use to somehow understand the pdb was new even when I overwrote the original one.

I tried with old versions of the debugger and couldn't get it to work with those either. I might have been dreaming that this ever worked. So I guess this is a feature request rather than a bug report now.