Update CI to use v1 orb and job

This PR updates the CircleCI to use the v1 orb and job syntax.

Didn't crash! :)


Simplify Name analyzer and code fix

Current status: it diagnose all FSharpSymbolUses as "unnecessary":

Now we need a list of opened namespaces and modules at point in document to decide what part of qualified name may be omitted.
@dsyme any points how to get namespaces and modules (with "has RequireQualifiedAccess attribute" and "has AutoOpen attribute") at a point in document? Maybe it's better to put them right into FSharpSymbolUse?

A crazy idea. Given a (partially) qualified name line Ns1.Ns2.M1.M2.foo, cut parts from the left until the remain name is still resolvable. The question is: how to try to resolve a long ident?

@dsyme any points how to get namespaces and modules (with "has RequireQualifiedAccess attribute" and "has AutoOpen attribute") at a point in document? Maybe it's better to put them right into FSharpSymbolUse?

This has come up before. I think you just have to plumb this down through the type checker.  The DisplayEnv (denv) active at any particular point contains an approximate list of opened prefix paths, but IIRC it's not exactly what you want, but close.  You might be able to modify it to get precisely what you need.  Then log that (in the TcSink), or it may be being logged already in the active name resolution environment.

@dsyme I've added a method that returns opened ModuleOrnamespaceRef [] at point. Now the plan is:

FindAllUsageOfAllSymbolsInFile (done)
filter out symbol uses at definition
filter out symbol uses which has single part in their LongIdent
get Symbol.FullName, parse it to string []

for each symbol use:

cut first part from symbol use's LongIdent
get all opened namespaces and modules at SymbolUse.RangeAlternate.Start
for each ns or module:

concatenate ns/module FullName with what's left in the symbol use's LongIdent
if the result of ^^ equals to the symbol's FullName, then we are done - this part of LongIdent may be cut

All this does not feel very natural to me. May it be better to try something like

cut the first part as before
NameResolution.TryResolve(pos, LongIdent) |> List.isEmpty |> not (I've no idea if such a function available though)

?

It's ready.

It's ready.

just tried it. but doesn't work for me:

scratch that. somehow VS didn't load my VSIX. Now it works! Good job!

mhm it doesn't work correctly for me:

@forki your screenshot looks totally OK for me. What do you find wrong on it?

Ah, yes. Reproduced.

Also the suggestion text should be improved.
F#:

C#:

Found the bug, will fix in an hour.
Duplicates will also gone.

cool.
so regarding the text:

The C# diagnostic reports "IDE0001 - Name can be simplified"

The C# codefix has title "Simplify name '%s'"

Simplify name '{0}'

...
<data name="Name_can_be_simplified" xml:space="preserve">
  <value>Name can be simplified.</value>
</data>

this is what they use for the DiagnosticsDescriptor:
    new DiagnosticDescriptor(
        IDEDiagnosticIds.SimplifyNamesDiagnosticId,
        s_localizableTitleSimplifyNames,
        s_localizableMessage,
        DiagnosticCategory.Style,
        DiagnosticSeverity.Hidden,
        isEnabledByDefault: true,
        customTags: DiagnosticCustomTags.Unnecessary);

what about the other way around - graying out unused open directives?

@forki It was done in VFPT and it's very complicated and 100% correct. If we are gonna implement it, we should find a (much) better way.

if I understand correctly then DiagnosticCategory.Style maps to localized text "Style". Correct?

I'm not exactly sure what DiagnosticCategory is for.  Maybe @mavasani can shed some light here.

@forki all done, please test.

now it's done...

@vasily-kirichenko this is great work, but 2 questions:

there is still the IDE0001 title missing
M2 could be simplified as well, right? It was proposed from the IDE in you last version

damn, I love that feature. I just hope it makes the cut for RTM. It's just awesome.

ok will send you a PR regarding the texts

so that's fixed.
@KevinRansom please merge

I've fixed the bug with M2.

yes that looks great:

@vasily-kirichenko
the following is technically correct:

But I think we should not suggest to remove the type name for unions - even if they don't have RQA.

just tested Unions with RQA set. that works.

@KevinRansom thanks. Any chance it will come to RTM?

Pretty close to zero.  But Update 1 is not far away.

@forki hm. It's interesting case. I think we should discuss non-RQA types in an issue.

@KevinRansom ok

a bit unrelated: how do we know what already got merged for RTM?

So far the cut-off date is 3rd January.  It may take some hardcore politicking to get more in.  Regardless of that I believe everything makes the cut for Update 1 and so update 1 is going to be a genuinely cool update to take.
  We have a process of continuing improvement, and areas we know that Update 1 is going to be an improvement.  I expect Update 2 and 3 will be even better than the release preceding them.
Be happy that things will improve and quite quickly, or sad that things are not perfect right now ... the choice is up to you ... I'm going with the former .

It's not about the glass being half-empty. I'm talking about the many many regression that we as group tried to solve.  MS and espcially the  community spend the last couple of weeks a crazy amount of time to make that roslyn switch smooth.
But especially the fixes in the last week were super important. TBH working on RC2 is basically impossible - not even simplest things work. There are situations were you can even have workaround other than using VS code or Vs2015/VS2013.
So I really hope Update 1 comes very very very soon. Sorry to sound so negative - but you know I'm meaning well.

@forki That seems like an orthogonal issue to getting this specific feature in.  You are choosing to conflate them.

@CyrusNajmabadi sorry I hijacked the issue for other things. Can you please rephrase the question - I'm a bit out of concext. (Really sorry)

I'm also in the optimistic camp.  I'm super happy that we've put in work here to leverage the work that Roslyn has invested in.  It means we can improve the languges much more quickly.  But it has certainly come at a cost and it doing things like unification certainly is a lot of work.
But, just consider that by doing this we've actually been able to do these sorts of features without each language having to invest hundreds or thousands of hours into duplicating (incompletely) what C#/VB/TS/JS have produced.

@CyrusNajmabadi @KevinRansom the problem is: a lot of the stuff already worked. Now we have really severe bugs in a RTM. That's just not what you as MS should find acceptable.

@forki you said> or in other words: RTM will suck pretty badly ;-(
This was in reply to the statement that this feature would not make it in for update 1.  When you provided more information you explained that you were unhappy because  "I'm talking about the many many regression that we as group tried to solve."
To me, these are orthogonal issues.  Whether or not this feature makes it in, won't address your concerns about "the many many regression".  If you're upset about the state of F# as you see it in RTM, that's fine.  But it's nonsensical to get upset that new feature work won't get in.  If anything, we should be expecting that as the norm so that we can spend time investing in the areas of concern first.

@CyrusNajmabadi absolutely. The new features don't need to be merged.
But things like setting a breakpoint in a IF condition would be really nice.

I'm ok with it.  Because i'm taking a long term view on things.  I see the benefit we get from this work and how it can lead to better features and a better experience coming to users faster.  Previously there were many saying it was unacceptable that F# lagged in features behind C#/VB/etc. so much.  This is an attempt to get us to a state where F# can move along with the other languages with reasonable cost.  Where we share common infrastructure and can all collectively benefit.
But that has come at a cost.  Moving entirely from one architecture to another is no easy thing, and with our schedules it has been difficult.  I'm optimistic though that as we continually improve from update to update this will have been absolutely worth it.

@CyrusNajmabadi how much F# do you write on a daily basis? I personally don't find it acceptable to have such regressions - that's why we tried to fix as many as possible.

I personally don't find it acceptable to have such regressions

That's fine.  I feel differently.
If RTM feels like too much of a step back for you, then i hope you will be able to use the existing versions of VS that you're using until we're able to lift the product up to a suitable level for you.

but that said: @CyrusNajmabadi I'm really really happy that you and your team are helping us to get there. I personally appreciate that a lot and I must confess that I actually enjoyed that last minute sprint. Kudos!
I personally won't have too much trouble with the RTM since I know most of the workarounds - but there are so many more people out there....

just to make that super clear: I am disappointed that we didn't get more fixes in for F# in time, but I'm very happy with the help of the roslyn team members. I hope we can continue on that. Thank you guys.

Continuing off-topic, how easy will it be for those relying on F# to install the side line tooling (from this repository) when RTM is out?

@smoothdeveloper CI must have fresh VS SDK installed. Having this done, it's easy to build and publish the open source vsix as an artifact of each successful build.

I just diffed master with vs2017-rtm - ouch. this RTM will hurt!

@CyrusNajmabadi I think we're all optimistic about the future of Visual F#. I surprised to see you say that you think it's acceptable to release a new version of VS that is actually worse than the current version though - which is essentially what we'll have in RTM.

To bring something positive into the discussion. @KevinRansom did not say there is zero chance for fixes to go in. How about opening a separate issue with a list of all the critical things we really should bring in? Maybe that makes it more easy to decide and can be transformed to a known issues/workarounds list later...
@KevinRansom would you be open for something like that?


Use go 1.23.3

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.99%. Comparing base (2d7c30d) to head (f3fe2bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   94.99%   94.99%
=======================================
  Files         104      104
  Lines       12561    12561
=======================================
  Hits        11932    11932
  Misses        480      480
  Partials      149      149

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$'

I Installed this fantastic plugin.
Then I get error page.

OK. 'debug' = false could turn this error page off.
But I can't access front-page except backend...

Duplicate of https://github.com/scottbedard/oc-debugbar-plugin/issues/6
This is a known problem in the debugbar dependency, it can be solved by upgrading your version of PHP to 5.5 or higher.


fix: import highlights from language other than english

Resolves #19 by not requiring all metadata to be found. Will need to revisit in the future and figure out how to reliably parse metadata that isn't stored in english.
Testing
Works on sample provided by @Gitbreast

Thanks for the work! I will check the latest version later!
Perhaps could recognize by different rows and the “|” vertical bar? or in the setting, let the user define the recognize method through define the keyword or the Regular expression or something like that.
For now it’s ok for me, after all, the page number in kindle would change with the font size changing, so I rarely use it. Haha.

It's already splitting up the rows, fortunately that doesn't change.
The problem with parsing based on the pipe | is their can be different items listed on that line.
I'll try to get it setup so that you can edit the labels in settings, that's a good idea!

@theBenForce That’s nice! Just take it slow. Wait for your good news;)


Update duplicate labels descriptions

Checklist

[X] I added a descriptive title
[X] I searched open requests and couldn't find a duplicate

What is the idea?
The https://github.com/conda/infrastructure/labels/duplicate and https://github.com/conda/infrastructure/labels/duplicate%3A%3Aprimary both specify that they are for issues however they should also be used to identify duplicate PRs.
Why is this needed?
Sometimes we get duplicate community PR submissions solving the same problem.
What should happen?
Update duplicate labels' descriptions to specify that they can be used for both issues and PRs.
Additional Context
No response

Taking this on.


add Apache License / Notice / Disclaimer to all OpenServerless git repos

see #21

I've done a small recap of the status.

REPO
LICENSE
NOTICE
DISCLAIMER

OpenServerless
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless Task
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless CLI
:white_check_mark:
:x:
:x:

OpenServerless Operator
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless Site
:white_check_mark:
:x:
:x:

OpenServerless Testing
:x:
:x:
:x:

OpenServerless Runtimes
:white_check_mark:
:white_check_mark:
:white_check_mark:

Actually there are also other repositories, but are almost empty:

https://github.com/apache/openserverless-documentation
https://github.com/apache/openserverless-python-starter
https://github.com/apache/openserverless-nodejs-starter
https://github.com/apache/openserverless-php-starter

I can prepare a PR for the missing files in CLI, SITE and TESTING so we can close this issue

Actual status after merging previous PR

REPO
LICENSE
NOTICE
DISCLAIMER

OpenServerless
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless Task
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless CLI
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless Operator
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless Site
:white_check_mark:
:white_check_mark:
:white_check_mark:

OpenServerless Testing
:x:
:x:
:x:

OpenServerless Runtimes
:white_check_mark:
:white_check_mark:
:white_check_mark:

Empty repositories:

https://github.com/apache/openserverless-documentation
https://github.com/apache/openserverless-python-starter
https://github.com/apache/openserverless-nodejs-starter
https://github.com/apache/openserverless-php-starter

I can prepare a PR for the missing files in TESTING so we can close this issue

@giusdp the issue is not complete: Openserverless Testing doesn't have required files yet. If you think it's ok, please close the issue

@d4rkstar woah sorry I didn't intend to do it.
I was rebasing my openserverless-cli fork and somehow github decided to close an issue on upstream cause of a commit message. I don't know if it's intended or a bug, seems weird to me that a different repo can do this on the original one.

@giusdp no problem. You're right.  It's caused by that "This will fix " in commit message.


Terminal won't open maxmized when "Run" field in shortcut set to Maximized

Environment
Windows build number: 10.0.18956.1000

Windows Terminal version (if applicable): 0.3.2142.0

Steps to reproduce
Drag tile from Windows Start Menu to desktop to create Link shortcut. Right-click shortcut icon and select properties. Change Run field to Maxmimized. Hit Apply. Close properties. Double-click shortcut icon. Terminal window does not open maxmimized, or at least it doesn't move the window to the upper-left of the screen the same way it would if you hit the Maxmimize button or Windows Key + up-arrow.
Expected behavior
Terminal window should open Maxmimized in the upper-left of the Screen appearing full-screen for immediate use the same way it would as if you hit the Maximize button on the Terminal window or pressed Windows Key + up-arrow.
Actual behavior
Terminal window is opening, but is positioned offset to the lower-right from what is expected. This requires an extra keystroke or mouse movement to maximize the window properly, which is a real show-stopper for terminal dandies like myself who thing you should be able to hit your keyboard shortcut to launch your Terminal and then immediately start using it.

This is, unfortunately, a platform limitation. I have filed MSFT:23202140 on the appropriate team to see if we can't get something done about it.

In what way is that a platform limitation? It works on all other apps, just not here on Microsoft Terminal, like the key place where it should work. Not being able to pull up a full-screen with the OS's built-in keyboard shortcut system is a pretty big deal. Maybe further research is necessary before closing.

It's something that actually doesn't work for any Win32 packaged applications ("Centennial apps"). For example, with Edge or any WSL distro, that doesn't necessarily work. The flag that checkbox sets isn't getting properly passed to the STARTUPINFO of a centennial application.

Maybe further research is necessary

Here's a snippet of the bug I filed on the team that owns "centennial" activation:

It is possible to create a shortcut to a centennial application using "shell:appsfolder" It is further possible to configure that shortcut to spawn the application in Maximized/Minimized/Normal windowing mode.

The WinMain entrypoint has a parameter, "nShowCmd", which should receive this information.
I have created an application that displays a messagebox containing the value of nShowCmd. Here's an example when i run it in different circumstances.

UNPACKAGED (raw EXE)

Double-clicked in explorer

From a shortcut marked RUN MAXIMIZED

PACKAGED (Centennial)

Start Menu

shell:appsfolder

From a shortcut marked RUN MAXIMIZED

As you can see, the centennialized application never receives the show setting. This applies equally well to the App Execution alias.
Because of this, users who create shortcuts to traditional applications (including "Windows Terminal") distributed via centennialization will not be able to configure them to launch maximized.
This was reported by a member of the general public.

Would you like me to do more research?

Yes into a workaround. It's unreasonable for the main Microsoft Terminal app that's supposed to be a game changer and a big part of Microsoft's future to not be able to open maximized, LOL!

Maybe just the option of opening in true Maximized from Settings. There naturally needs to be a way to open a Terminal app fullscreen.

Dude I have the same felling, I just downloaded the thing to try it out and my first impression was: where's fullscreen?!

Dude I have the same felling, I just downloaded the thing to try it out and my first impression was: where's fullscreen?!

How do I launch directly into fullscreen mode is the first thing any real terminal person is going to think, right? If the desktop shortcut isn't the way to do go because of of packaging details, then surely they can add it to the preferences config file.

@mikemaccana Alacritty works


Test PR

Verify CircleCI Build

@chysomee Great effort so far but CircleCI not initiated! make sure CircleCI initiated even from forked repos
Turn it on here;

Thank you @Redeem-Grimm-Satoshi for your comment. I have turned on the CircleCi. you can review here


Update Readme to Close Specs Repo

End of an era.

wait until we've got the OZ audit fixes in please.

@trianglesphere oh yeah, that's fine with me.

Merging despite broken CI in order to ensure visitors are properly directed to the Monorepo.


python310Packages.mypy-boto3-builder: 7.19.1 -> 7.23.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.mypy-boto3-builder is: Type annotations builder for boto3
meta.homepage for python310Packages.mypy-boto3-builder is: https://github.com/youtype/mypy_boto3_builder
meta.changelog for python310Packages.mypy-boto3-builder is: https://github.com/youtype/mypy_boto3_builder/releases/tag/7.21.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 7.21.0 in filename of file in /nix/store/kf1q9vfwsl49r734ayw9fx54jv0mdf1f-python3.10-mypy-boto3-builder-7.21.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.mypy-boto3-builder
python311Packages.mypy-boto3-builder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kf1q9vfwsl49r734ayw9fx54jv0mdf1f-python3.10-mypy-boto3-builder-7.21.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.mypy-boto3-builder https://github.com/r-ryantm/nixpkgs/archive/709377553a17a9394522132d8b2d0288a56d1daa.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/709377553a17a9394522132d8b2d0288a56d1daa#python310Packages.mypy-boto3-builder

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kf1q9vfwsl49r734ayw9fx54jv0mdf1f-python3.10-mypy-boto3-builder-7.21.0
ls -la /nix/store/kf1q9vfwsl49r734ayw9fx54jv0mdf1f-python3.10-mypy-boto3-builder-7.21.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.mypy-boto3-builder

1 package built:

python310Packages.mypy-boto3-builder

Maintainer pings
cc @fabaff for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.mypy-boto3-builder is: Type annotations builder for boto3
meta.homepage for python310Packages.mypy-boto3-builder is: https://github.com/youtype/mypy_boto3_builder
meta.changelog for python310Packages.mypy-boto3-builder is: https://github.com/youtype/mypy_boto3_builder/releases/tag/7.23.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 7.23.0 in filename of file in /nix/store/p9z43fv2rjvk8iqfjax8zz8z4kjbhw0n-python3.10-mypy-boto3-builder-7.23.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.mypy-boto3-builder
python311Packages.mypy-boto3-builder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p9z43fv2rjvk8iqfjax8zz8z4kjbhw0n-python3.10-mypy-boto3-builder-7.23.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.mypy-boto3-builder https://github.com/r-ryantm/nixpkgs/archive/b9fe986fb11745d46bfab6e26870c69838634cb7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b9fe986fb11745d46bfab6e26870c69838634cb7#python310Packages.mypy-boto3-builder

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p9z43fv2rjvk8iqfjax8zz8z4kjbhw0n-python3.10-mypy-boto3-builder-7.23.0
ls -la /nix/store/p9z43fv2rjvk8iqfjax8zz8z4kjbhw0n-python3.10-mypy-boto3-builder-7.23.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.mypy-boto3-builder

1 package built:

python310Packages.mypy-boto3-builder

Maintainer pings
cc @fabaff for testing.

Staging-next is at 7.21.0, please create a new PR against that branch.


Website Optimization

Hello everyone 🖖
I was checking GitHub for labels under good first issue but I also want to help sharing some website optimizations tips.
Image Resize
This image: https://sushiksha.konkanischolarship.com/media/blog-post-thumbnail/SCL_Wall_Paper_Wide.jpg has a whooping 3.3 MB size. It's enormous. Even with a 4K monitor, it's big. I used Cloudinary with JPEG Mini to compress and resize the photo and it's down to 228 KB 😄

I also resized this one: https://sushiksha.konkanischolarship.com/media/blog-post-thumbnail/Sushiksha_Logo.jpg, from 817 KB to 218 KB.

A LOT of icon font
So you are using three icon fonts:
…icofont/icofont.min.css(sushiksha.konkanischolarship.com) | 25.3 KiB | 270 ms
…css/boxicons.min.css(sushiksha.konkanischolarship.com) | 22.3 KiB | 270 ms
…remixicon/remixicon.css(sushiksha.konkanischolarship.com) | 14.6 KiB | 230 ms
My suggestion is to stick with one.
Font Optimization
I suggest you put your font loading on "swap". You can check out more about this property on MDN.
Lighthouse Report
I generated a PDF with Lighthouse recommendations. 😄
lighthouse-big-report.pdf

Hi 👋 ,
Thanks for your valuable feedback, as this issue is already mentioned by one of our collaborators, I am closing this issue. #49


How can i delegate didpressednextbutton?

I want catch action of nextbuttonpressed. I tried but it's not working. i added optional func in delegate and called from control.didpressednextbutton {} function as strongSelf.delegate?.didpressednextbutton?().

I solved problem. I run my code in newVideo optional func. i wrote my control.didpressednextbutton func.


[request] use custom patterns for mentions and hashtags

Hi Andres, thanks again for the lib. It would be nice if we could use our own regex patterns for hashtags and mentions like react-native-parsed-text is doing it.
use case:
By adding custom patterns we can include the user id on the text string eg {id:1, mention:”andres”} but the user will only see @andres. This can came in handy when the user taps on the mention -> navigate to that user’s public profile.
I’ll post an example on how I’m achieving this with react-native-parsed-text.

this is how text is stored on database:
@[johnonesix](qkkA1mR6A9PHkLjEEUcpOZtjSXI2) hey there!
These are the pattern props:
      {
        onPress: (text: string) => props.handleMentionPress(extractMentionUserId(text)),
        pattern: /((.)\[([^[]*)]\(([^(^)]*)\))/i,
        renderText: (matchingString: string) => renderMentionText(matchingString),
        style: { color: props.theme.green },
        suppressHighlighting: true
      },

extractMentionUserId function:
export const extractMentionUserId = (text: string) => {
  const pattern = /((.)\[([^[]*)]\(([^(^)]*)\))/i;
  const match = text.match(pattern);
  return `${match ? match[4] : [1]}`;
};

export const renderMentionText = (matchingString: string) => {
  const pattern = /((.)\[([^[]*)]\(([^(^)]*)\))/i;
  const match = matchingString.match(pattern);
  return `${match ? match[2] + "" + match[3] : [1]}`;
};

using this approach everytime someone taps the mention I get the user id on the onPress function. Hope this helps a bit.


Only one model option available for Pro account in CodyChat

I have the latest update for choosing the model option in CodyChat, but it seems I cannot see the other options but only one. Could you have a look.
I have attached the screenshots for your reference.

Did you try restarting neovim? The other models showed up for me after I did this.

Did you try restarting neovim? The other models showed up for me after I did this.

Yes, I did, but it's still the same.

For me there are 7 models to choose from but it still uses claude 2.0 no matter which one I select. Pro user as well.

Sorry for the delay, I've updated the underlying extension and you should see all the latest models from cody! (I'm working on adding a way to set the default provider atm)

I've found a way to manually set up which model to use as the default one. Just set the default model in the config.
These are my settings:


[ENG-425] feat: Delete integration with id

Test Log
Creating
jaehyunlim@Jaehyuns-MacBook-Pro cli % task build-local && lamp deploy ../testdata/full-example  --project=5e4f06ca-445f-43ea-943e-78465ee1bb7a --key=TASW3OD2BOY252UQHFUK53FHHFDXBP6YHQFKN2A --debug
task: [do_build] go generate ./...
task: [do_build] CGO_ENABLED=0 go build -ldflags="-X github.com/amp-labs/cli/vars.CommitID=e41f7f0578395f8d93f2fd39099fd24d8e2f317f -X github.com/amp-labs/cli/vars.Branch=delete-integration -X github.com/amp-labs/cli/vars.Stage=local -X 'github.com/amp-labs/cli/vars.BuildDate=2023-11-02 10:49PM' -X github.com/amp-labs/cli/vars.Version= -X github.com/amp-labs/cli/vars.ClerkRootURL=https://welcomed-snapper-45.clerk.accounts.dev -X github.com/amp-labs/cli/vars.LoginURL=https://ampersand-cli-auth-dev.web.app -X github.com/amp-labs/cli/vars.ApiURL=http://<IP_ADDRESS>:8080 -X github.com/amp-labs/cli/vars.GCSBucket=ampersand-dev-deploy-uploads -X github.com/amp-labs/cli/vars.GCSKey=AIzaSyBvOQ41f7igI0wtclU0JgqBKfPtOluyjpg" -o bin/amp main.go
2023-11-02T15:49:37-07:00 DEBUG: Uploaded to gs://ampersand-dev-deploy-uploads/2023/11/02/amp_1698965376.zip
2023-11-02T15:49:37-07:00 DEBUG:
>>> API REQUEST:
PUT /v1/projects/5e4f06ca-445f-43ea-943e-78465ee1bb7a/integrations:batch HTTP/1.1
Host: <IP_ADDRESS>:8080
Accept: application/json
Content-Type: application/json
X-Api-Key: TASW3OD2BOY252UQHFUK53FHHFDXBP6YHQFKN2A
X-Cli-Branch: delete-integration
X-Cli-Build-Date: 2023-11-02 10:49PM
X-Cli-Commit: e41f7f0578395f8d93f2fd39099fd24d8e2f317f
X-Cli-Stage: local
X-Cli-Version:

>>> END OF API REQUEST

2023-11-02T15:49:37-07:00 DEBUG:
<<< API RESPONSE:
HTTP/1.1 200 OK
Content-Length: 1693
Access-Control-Allow-Origin: *
Content-Type: application/json
Date: Thu, 02 Nov 2023 22:49:37 GMT
Vary: Origin

[{"id":"682692ac-281f-4948-9717-3c3e36d33a63","provider":"salesforce","projectId":"5e4f06ca-445f-43ea-943e-78465ee1bb7a","name":"readAccountsAndContacts","createTime":"2023-11-02T22:49:37.434765Z","updateTime":"2023-11-02T22:49:37.434765Z","latestRevision":{"id":"344e13fe-fb36-458f-9dec-f74474471b69","integrationId":"682692ac-281f-4948-9717-3c3e36d33a63","createTime":"2023-11-02T22:49:37.428927Z","content":{"displayName":"Read Accounts and Contacts","name":"readAccountsAndContacts","provider":"salesforce","read":{"standardObjects":[{"destination":"accountWebhook","objectName":"account","optionalFieldsAuto":"all","requiredFields":[{"fieldName":"name"},{"prompt":"Which field is the identifier for the account? These IDs allow us to match Salesforce Objects to our Accounts and Users. Once you select a field, you cannot change it.","default":"id","mapToName":"accountId","mapToDisplayName":"Account ID"}],"schedule":"*/15 * * * *"},{"destination":"contactWebhook","objectName":"contact","optionalFields":[{"fieldName":"mobilephone"},{"fieldName":"fax"}],"requiredFields":[{"fieldName":"name"},{"prompt":"Which field is the identifier for the contact? These IDs allow us to match Salesforce Objects to our Accounts and Users. Once you select a field, you cannot change it.","default":"id","mapToName":"userId","mapToDisplayName":"User ID"},{"prompt":"Which field is the identifier for the account that this contact corresponds to? These IDs allow us to match Salesforce Objects to our Accounts and Users. Once you select a field, you cannot change it.","default":"accountid","mapToName":"accountId","mapToDisplayName":"Account ID"}],"schedule":"*/30 * * * *"}]}},"specVersion":"1.0.0"}}]
<<< END OF API RESPONSE

Successfully deployed your integration readAccountsAndContacts.


Keyboard layout module

Based on PR #556.
Fixes #66.
This PR add a sway/layout module. The module display the currently selected keyboard layout.
With the format string {long} / {short} / {variant}, we can expect outputs like:

English (US) / en / us
English (Dvorak) / en / dvorak
French / fr / fr

:wave: @Alexays Is there any way to access the travis status ? I am doing changes on the Dockerfiles, but can't have any feedback on it.

https://travis-ci.org/github/Alexays/Waybar/jobs/673431112
I need to update images on Docker hub 😄
I'll take care of it.

I can't update docker image based on a PR, could you do another PR with only docker file changs?
And once merged, pipeline should be ok.

I can't update docker image based on a PR, could you do another PR with only docker file changs?
And once merged, pipeline should be ok.

#661

#661
https://travis-ci.org/github/Alexays/Waybar
It's obviously not the right packages for alpine and fedora, maybe the devel one?

https://travis-ci.org/github/Alexays/Waybar
It's obviously not the right packages for alpine and fedora, maybe the devel one?

#665

@BlueGone would it be possible to add CSS classes to distinguish layouts and variants? For example, I would definitely want to use different colors for different layouts. I guess the simplest way would be to add CSS classes short-<value> and variant-<value>, such as short-en and variant-dvorak.

@BlueGone would it be possible to add CSS classes to distinguish layouts and variants? For example, I would definitely want to use different colors for different layouts. I guess the simplest way would be to add CSS classes short-<value> and variant-<value>, such as short-en and variant-dvorak.

@BlueGone would it be possible to add CSS classes to distinguish layouts and variants? For example, I would definitely want to use different colors for different layouts. I guess the simplest way would be to add CSS classes short-<value> and variant-<value>, such as short-en and variant-dvorak.

Hum, nice idea. I'll take a look at it, get back to you as soon as I see it if I can.

@BlueGone, to unbreak FreeBSD on CI apply the following:
diff --git a/.travis.yml b/.travis.yml
index 3085d7b..962065c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -34,7 +34,7 @@ jobs:
       install:
         - sudo sed -i '' 's/quarterly/latest/' /etc/pkg/FreeBSD.conf
         - sudo pkg install -y date gtk-layer-shell gtkmm30 jsoncpp libdbusmenu
-               libfmt libmpdclient libudev-devd meson pulseaudio scdoc spdlog
+               libfmt libinput libmpdclient libudev-devd meson pugixml pulseaudio scdoc spdlog
       script:
         - meson build -Dman-pages=enabled
         - ninja -C build

Would it be possible to add support for showing the keyboard modes (num lock, scroll lock, caps lock, etc.) in this module?


Improved Framer X copy and mentioned Framer X team store

Hey @LisaDziuba, I found your Awesome-Deisgn-Tools project while 🏄 surfin' the web and thought it might be a good idea to mention that the Framer Team Store is a great place for creating and maintaining design systems. While there I improved the Framer X copy a bit.
(full disclaimer I'm an engineer at Framer 😬)

hey @fhur! Actually I didn't know that you have a tool for maintaining Design Systems. Thanks for adding this.
Feel free to improve Framer X copy, although current copy is how the community see your tool 😊
The only request I have, please add a legend if it's appropriate and full stops after sentences.
like this:

free icon for free tools (entirely free tools, not freemium). Just copy & paste the following snippet: ![free.svg](https://github.com/LisaDziuba/Awesome-Design-Tools/blob/master/Media/free.svg)

open-source icon for open-source tools. Use the following snippet: ![open-source.svg] (https://github.com/LisaDziuba/Awesome-Design-Tools/blob/master/Media/open-source.svg)

mac icon for Mac only tools. Use the following snippet: ![mac.svg](https://github.com/LisaDziuba/Awesome-Design-Tools/blob/master/Media/mac.svg)

hey, @fhur

I added labels (Mac only)

put Framer Team Store as suggestions because it's part of Framer X (I asked your founder to be sure)

changed the description


User dropdown in bar - see if auto focus can be turned off

remove this ugly dotted rectangle

Wait for EDS to release a fix

Fixed by updating eds


chore: moved handler/envTypeHandler to postDeployment/envTypeSetup

Issue #, if available:
Description of changes:
chore: moved handler/envTypeHandler to postDeployment/envTypeSetup
Since new environmentTypes are only added in the postDeployment step, we can run envTypeSetup during the postDeployment step as well. This will reduce customer cost, since envTypeSetup will no longer run every 5 minutes.
Checklist:

[x] Have you successfully deployed to an AWS account with your changes?
[x] Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I mentioned in the documentation for SWB setup to wait for the handler to add environment types, we should update documentation  here to reflect changes

I mentioned in the documentation for SWB setup to wait for the handler to add environment types, we should update documentation here to reflect changes

Updated


Should input arguments be checked for acceptable values (i.e. booleans, enumerations, ranges, etc)

Some input arguments to operations support an explicit set of values. Parameters such as admin, catalog-only, and no-trash accept 0 or 1 as a boolean value. There are other parameters which act as an enumeration.
Should the HTTP API force users to provide a known value?

for operations where HTTP API is defining these values itself, yes, definitely.
for some things where it's just passing them to iRODS, we should probably let iRODS handle them and send back errors.
so... it depends?

I mostly agree, but there are cases where checking for a particular value in the set is the only thing that matters.
For example, admin=1 mostly means add the ADMIN_KW. Where admin=0 is ignored. admin=ignored is equivalent to admin=0 in this case. We don't waste CPU cycles checking the argument and it's safe.

I see.    Right, so it's still case-by-case.
I think that's okay.

The downside of not checking all inputs for acceptable values is the interface then feels inconsistent. I think that's worst than paying for the extra cycles.

sure, we'll find the balance.    these cycles are cheap.


Codeless Connector Request configuration "Request Body" Parameter

Describe the bug
The Microsoft Sentinel Codeless Connector Platform does not specify how define a request body payload. In the Request configuration payload options for data include "headers", "queryParameters", "queryParametersTemplate" but there is no clear method to provide a request body. There is a "isPostPayloadJson" flag but it is unclear what payload options it is expecting.
To Reproduce
Steps to reproduce the behavior:

Identify an API that uses "request body" payloads (such as 1Password's Event Reporting API)
Use "queryParameters", "queryParametersTemplate" with or without "isPostPayloadJson"
SentinelHealth table returns "Status: Failure", "Reason: MethodNotAllowed" and "Description: Data fetch failed (Hit Transient FlurlHttpException exception)

Expected behavior
Using alternative REST API query tools (such as Postman) with request body options returns a response object.
Screenshots
N/A
Desktop (please complete the following information):

OS: macOS
Browser: Google Chrome
Version: 107.0.5304.121 (Official Build) (arm64)

Smartphone (please complete the following information):
N/A
Additional context
It's possible that request body is supported with the Codeless Connector Platform, it's just unclear how to use it based on the documentation provided.

I dont even see that property in the rest api.  I dont think they support a request body yet.

@rjaakke Well this is super helpful and I'll check it out. Your code also answers my question around query parameters so thanks for that too!


Expire linked files after 7 days

Summary | Résumé
If the sending method is not "attach" then it is "link" and the document is stored in the root of our notification-canada-ca-${var.env}-document-download bucket: https://github.com/cds-snc/notification-document-download-api/blob/main/app/utils/store.py#L67
We already have a lifecycle policy that expires files in the tmp folder after 3 days.
So we just need to add another policy that will apply to the other docs outside of the tmp folder.
In order to have multiple lifecycle rules on the same bucket, we need to assign them unique ids so Terraform doesn't get confused.
Will the 2 lifecycle rules produce the desired behaviour? i.e. files in /tmp expire in 3 days, other files in the root folder expire after 7. According to the AWS docs it should work.

This will mean that after a week end users will not be able to get files where the link was sent to them - have we communicated this with service owners?

@sastels We are following Policy and Product management's call on that one (which they are aware of the implications).


FileKeystore is hard to use with non-file-based keystores

We are implementing JCA KeyStore provider to get certificates and keys via external process over the network. However, code in https://github.com/wildfly/wildfly-core/blob/master/domain-management/src/main/java/org/jboss/as/domain/management/security/FileKeystore.java makes use of such code hard.
It seems that FileKeystore has two modes of operation -- either alias is specified and then the KeyStore is treated as file (isKeyStore = true) which has to exist and it has to be able to list aliases, or the file is not required to exist (isKeyStore = false) but then alias cannot be specified (and if it is specified as alias attribute to <keystore> element, it is ignored).
In case we'd like to be able to use our provider without additional configuration in java.security, we'd like to be able to specify alias to retrieve specified entry, especially since getting the list of aliases might be either slow (for large sets) or not possible. For that however, we need to go the isKeyStore = true route with path specified and file existing. Alas, when we try
    <ssl>
      <keystore provider="custodia-cli" path="/dev/null" alias="wildfly/server-ssl" keystore-password="thepassword" />
    </ssl>

then due to the extra check in WildFly's code, startup fails with
Caused by: org.jboss.msc.service.StartException in anonymous service: WFLYDM0083: The KeyStore /dev/null does not contain any keys.
        at org.jboss.as.domain.management.security.FileKeystore.assertContainsKey(FileKeystore.java:169)
        at org.jboss.as.domain.management.security.FileKeystore.load(FileKeystore.java:120)
        at org.jboss.as.domain.management.security.FileKeyManagerService.loadKeyStore(FileKeyManagerService.java:189)

Please consider removing the
            if (isKeyStore) {
                assertContainsKey(loadedKeystore);
}

code from https://github.com/wildfly/wildfly-core/blob/master/domain-management/src/main/java/org/jboss/as/domain/management/security/FileKeystore.java#L119 since existence of the keystore file does not guarantee that the keys will be stored in it and that the provider will be able to loop through them. The file might be just /dev/null or some config file of the provider.
Ideally though, it should be possible to specify alias even for keystore which has no path specified.

we don't use github issues, please file issue in jira https://issues.jboss.org/browse/WFLY
and select component security, so it gets assigned to right person.

Thanks, filed as https://issues.jboss.org/browse/WFLY-8601.


🐛 [firebase_core] it shows an error when i start debugging the project

i came from
#6703
i don't know why markusaksli-nc  close it and the problem still not solved
anyway this is the problem
when i start building the app it shows me this error
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':firebase_core:compileDebugAidl'.
> Could not resolve all task dependencies for configuration ':firebase_core:debugCompileClasspath'.
   > Could not find com.google.firebase:firebase-common:.
     Required by:
         project :firebase_core

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 12s
Exception: Gradle task assembleDebug failed with exit code 1

when i start building the project in the emulator in android studio this error shows
i m using the latest version of firebase_core.
and
i added firebase to my project
project/android/app
dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
implementation platform('com.google.firebase:firebase-bom:28.2.1')
implementation "com.google.firebase:firebase-analytics"
}

apply plugin: 'com.android.application'
apply plugin: 'com.google.gms.google-services'

project/android

dependencies {
    classpath 'com.android.tools.build:gradle:3.5.0'
    classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    classpath 'com.google.gms:google-services:4.3.8'

}

and the google services file.
I tried also to change firebase sdk version  but it didn't work
also i tried to remose this line
implementation platform('com.google.firebase:firebase-bom:28.2.1')
but still the probem shows

There is no need to open a new issue.
Closing as a duplicate of https://github.com/FirebaseExtended/flutterfire/issues/6703


Added a function for custom regex replacement

Hi, I added a new command

we can add that command to the Custom Commands

Finally, we are able to use custom regular expressions to replace text

I think this is a useful requirement, hope it helps others

Hey @HardwayLinka . This is a good suggestion. I think it can be really useful.
The only problem I have with it is that it does not really fit under the concept of custom commands in the sense that it is a command you can run without specifying params. Thus it seems like it would be better as its own option of custom rules called custom replacement or something like that. Thus it would not need to be added onto custom commands. I am just not sure how well that would work with the command form of it. I would likely need to refactor it some so that it could both run as a rule and as a command.
What fo you think of my feedback? I would be happy to help implement changes where needed.

Hi @pjkaufman.thank you for your patient and detailed feedback.
I agree with what you said. I added this feature to the custom command because it is easier to implement, but at the same time it may be against your design. I will try adding this to a separate option and commit it again when I'm done.

Hi @pjkaufman. I have a question, I added the feature to the Content Settings, but I can't find the feature under the Content Settings

Hi @pjkaufman. I have a question, I added the feature to the Content Settings, but I can't find the feature under the Content Settings

Hey @HardwayLinka , I see that you added it as a regular rule. It would need to be a custom  rule just like custom commands (just different UI elements).
As for it not showing up, I am guessing you did a search for Content instead of the name of the rule or part of the description, or part of the rule alias. That would be why it did not show up though I might be misunderstanding  the screenshot .

Also, sorry about the delay in responding. I was out over the weekend. Thanks for putting in the effort to add this feature!

There's no need to apologize. This project has been very helpful to me, so I'd love to contribute to this project and hope it will help others~

I will take a look at this hopefully some time this week and then determine if any changes need to be made just from a trail run of it. As far as the code looks, it looks good. I just want to make sure I did not overlook something that would cause an odd user experience.

This looks good. It looks to cover several different cases as well. I will go ahead and merge this so we can get it out there in the next release. I will also probably add some documentation around this in the README and refactor this and the custom commands into their own components instead of as they are now. Sorry about the delay on getting to this to verify that it looked to work.
Thanks for putting in the work to get this working! I am sure there will be people that find this useful.


Fix @NonNull argument detection in RestrictiveAnnotationHandler.

@msridhar I really need to learn not to try to read annotations in nullaway without just calling NullabilityUtil.getX methods 😅


TagPlugin - support terraform 0.11

Is the -var different between  11 and 12?
the plugin uses -var="key=value", but the equal sign  might be causing problems with v0.11.
Either remove the = (assuming that works in 12), or build this difference in TerraformVersionPlugin.

See terraform docs

https://www.terraform.io/docs/configuration-0-11/variables.html

terraform apply -var 'foo={quux="bar"}' -var 'foo={bar="baz"}'

https://www.terraform.io/docs/configuration/variables.html#variables-on-the-command-line

terraform apply -var="image_id=ami-abc123"


Newfeature

-Add form index.html
-Style the form with css
-Add logo icon
-Allow my coding partner to modify index.html
-Modify README.md
-Modify linter errors.

New feature branch
-Add form index.html
-Style the form with CSS
-Add logo icon
-Allow my coding partner to modify index.html
-Modify README.md
-Modify linter errors.


Improves the HUD

About the PR
Improves QoL by adding commonly used inventory slots to the HUD, and makes it generally less terrible by arranging them in a grid in the corner.
Also removes the combat mode button and makes it an action.
Screenshots

Changelog

:cl:

tweak: Changed the HUD inventory slots.
tweak: Combat mode is now an action, rather than its own button.

Looks bad. You should decrease the amount of hotbar sloths by two and put the combat mode and doll underneath that.

Comparison photo of our current UI layout

Personally I prefer this stuff on the left where you usually expect things like belt etc to be.

Nuked the combat mode button and made it an action. PR description updated with new pictures.
I need a unique icon for the combat mode action @SweptWasTaken

Added a harm icon from the same DMI as disarm. PR desc updated.

Combat mode being assigned to hotbar is good. Everything else is unneeded.

This just moves all the common inventory buttons further away from the center of the screen and, as such the mouse.
It also wastes valuable screen real estate (since inventory buttons are a small UI element that are easy to fit at the bottom of the screen in a row, instead of chunking them together in a grid like this).
MASSIVE 👎 here.

This just moves all the common inventory buttons further away from the center of the screen and, as such the mouse.
It also wastes valuable screen real estate (since inventory buttons are a small UI element that are easy to fit at the bottom of the screen in a row, instead of chunking them together in a grid like this).
MASSIVE 👎 here.

I was gonna draw lines from the center of the screen to the UI and compare distance but I didn't because I thought people would call me schizo.

@PJB3005 I'd put it on the left with the action bar if it wasn't so ridiculously massive.

Making this a draft until goonhud is finished.

Visually it's fine, code-wise... let's see how review goes.

I still do not like how this looks. Of every part of our current UI, this was the least problem.
The popup hotbar is nice, but it should be using the old icon sprites.

There's no point caring when neither style matches the HUD style.

Plus unlike the old icons, these are all the same size.

There's no point caring when neither style matches the HUD style.

One looks more out of place than the other. Use the old icons. They're different sizes for a reason.

I remembered why I changed it. The old ones were different sizes for no reason.

uSe ThE oLd OnEs

Still looks bad. Instead of 2 conflicting UI designs it's 3.

Stop being a baby, unblock me on discord then send me the icons in a zip and I'll fix them for you.

All-new sprites:

Build failures seem to be unrelated.

What does it look like if the mob has multiple hands?

Old pic but still accurate. Just puts it between the slots, as before.

Kk i'm gonna re-add the blank hand icon without the L or R.

https://discord.com/channels/310555209753690112/770682801607278632/824776596786774033
Here is the icons. I've:

Relayered the icons so that the actual small clothing sprite is on top of the scan-lines
Added some ones you didn't include
Changed the hue to fit more with the UI
Changed the hat and mask icon to be more recognizable

If you could try them in-game and put photos here.


Issues with hiding the mapped turn restrictions

The click button for hiding the existing turn restrictions is not working for nodes. It only hides the line features and leaves the nodes. It would be great if we can hide and unhide both point and line features as well.

cc/ @planemad

Rather strange bug. Fixed now by hiding the noturn via highlight layer. Will need to get to the bottom of it later.


rust-lang/rust: Assign reviews to all active compiler team members and contributors

Implement the suggestion from https://github.com/rust-lang/highfive/pull/266#issuecomment-647040858 and increases the number of assignable people from 9 to 22.
Highfive uses a check based on git blame to increase the chance of the selected reviewer being familiar with the code.
Excluded from the list:

matklad, flodiebold - work on rust-analyzer but not rustc
lqd - works on polonius but not rustc, also inactive?
zackmdavis, scalexm - inactive

r? @nikomatsakis

@nikomatsakis
Closing due to inactivity.
I still think it's a good idea, but I don't like PRs pending for months in my PR list.


fix(extensions): add *.cls

https://github.com/pre-commit/identify/pulls?q=is%3Apr+cls+is%3Aclosed


Time add on

when the music will be playing, I will create an option for adding extra time

hey @sk66641 please add a label and assign me this issue as a gssoc contributor


extractVueStyles adds my vue styles to the start of app.css

Laravel Mix Version: 2.0.0
Node Version: v8.9.4
NPM Version: v8.9.4
OS: Ubuntu 17.10

Description:
after trying every thinkable and unthinkable solution, I still can't get it to work.
I am using laravel-mix in a pure Vue / non-Laravel Project. I am trying to do a prod build with extractVueStyles to a custom location. However it doesn't extract the css to it's own css file but instead adds it to the first line of the app.css file. this has the consequence that some styles are overwritten by global styles in next few lines.
my package.json
{
  "scripts": {
    "dev": "npm run development",
    "development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch-poll": "npm run watch -- --watch-poll",
    "hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "prod": "npm run production",
    "production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },
  "devDependencies": {
    "axios": "^0.17",
    "babel-polyfill": "^6.26.0",
    "cross-env": "^5.1.3",
    "laravel-mix": "^2.0.0",
    "lodash": "^4.17.5",
    "mini.css": "^2.3.7",
    "moment": "^2.20.1",
    "purify-css": "^1.2.6",
    "purifycss-webpack": "^0.7.0",
    "ts-loader": "^3.4.0",
    "typescript": "^2.7.1",
    "vee-validate": "^2.0.3",
    "vue": "^2.5.13",
    "vue-class-component": "^6.1.2",
    "vue-property-decorator": "^6.0.0",
    "vue-router": "^3.0.1",
    "vuex": "^3.0.1"
  }
}

my webpack.mix.js:
mix.setPublicPath(path.resolve('./'));

mix.sass('src/scss/app.scss', 'css/app.css')
    .js('src/js/app.js', 'js/app.js')
    .copyDirectory('src/img', 'img')
    .copyDirectory('src/video', 'video');

if (mix.inProduction()) {
  mix.copy('src/index.prod', 'index.html')
      .options({
        extractVueStyles: 'css/components.css',
        processCssUrls: false
      })
      .minify(['js/app.js','css/app.css'])
      .version();
} else {
  mix.copy('src/index.dev', 'index.html')
      .sourceMaps();
}

everything else works perfectly. except that it is writing the styles into the app.css.
What am I missing?
Steps To Reproduce:

delete node_modules and package-lock.json
npm cache clear --force
npm install
npm run prod

Expected:

css/
| - app.css <- global styles
| - app.min.css <- minified global styles
| - components.css <- vue styles
| - components.min.css <- minified vue styles

Result:

css/
| - app.css <- vue + global styles
| - app.min.css <- minified vue + global styles
| - components.min.css (0 bytes)

Same problem here !

I can confirm that. Just tested it by adding some fixtures and a test to the laravel-mix tests:
test.cb.only('it extracts vue styles correctly', t => {
    // Given we have a js file that imports vue
    mix.js('test/fixtures/fake-app/resources/assets/js/app-with-vue.js', 'js/app.js')
        // And a scss file with some styles
        .sass('test/fixtures/fake-app/resources/assets/sass/app.scss', 'css/app.css')
    // and we want to extract vue styles
        .options({extractVueStyles: 'css/components.css'});
    // When we compile it
    compile(t, () => {
        // Then we expect the js to be built
        t.true(File.exists('test/fixtures/fake-app/public/js/app.js'));
        // And the app.css to be built
        t.true(File.exists('test/fixtures/fake-app/public/css/app.css'));
        // And the extracted vue styles to be in their own css
        t.true(File.exists('test/fixtures/fake-app/public/css/components.css'));

    })

});

It fails when it asserts that components.css is in place. I'll have a look into it.

Currently, it looks to me as if extract-text-webpack-plugin doesn't work correctly, because the given filename is correctly resolved and passed to the constructor of this plugin, which seems to be the correct way of doing this, given a brief inspection of the sources. Directly afterwards, a dump of the plugin reveals that its filename is set to app.css (instead of components.css).

Got it. It's a bug. I'll create a PR for it.

thanks so much for the fast resolution 😁

You're welcome.

@JeffreyWay I will investigate further tomorrow, but this broke the CSS in my app. Reverting to 2.0 fixes the problem for now.

@JeffreyWay This breaks unfortunately.
For me it now:

Suddenly creates a new CSS file called "vue-styles.css"
Just dumps vue-styles.css into /public/, not into /public/css/
I actually want it to concatenate to app.css as I use scoped CSS, so I have no conflicts anyway.
Also insert here the usual rant about semver not being respected, etc, etc.


【Hackathon 5th No.56】

提交黑客松5th问题56“A Physics-Informed Neural Network to solve 2D steady-state heat equation”的RFC。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Moose W. Oler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


SHACL - evaluate use of Unique plan node

This node requires everything to be completely sorted, so when it is used without a trim we might have a problem.
Options:

use Unique only after trim
sort before Unique
make Unique handle partially sorted data (THIS IS NOW IMPLEMENTED!)

"make Unique handle partially sorted data" is now implemented. It assumes that for a stream of tuples like tuple["a", "jfdsof"], the stream is sorted on index 0. Then for every new value it sees at index 0 it will use a hashset to dedupe all tuples with the value at index 0.


SAK-49261 Card Game: Instructors with full access can play with groups

https://sakaiproject.atlassian.net/browse/SAK-49261

I will rebase and mark this PR as ready, when #11937 and #11938 are merged.

Just rebased, now this is ready for review

Thanks @stetsche !


 I will make some research in the rust gui ecosystem

Just looking at some existing things:

On web platforms, specifically click events are tied to keyboard, touch, pen, and mouse-related behavior. Other mouse events  (e.g. mouseup) can only be triggered by the mouse (not touch).

A click event is fired if either Enter is pressed or Space is released when a focusable element is in focus, a touch release is registered within a specific time-frame, or the left mouse button is released.
To unify other types of input and avoid adding separate listeners for different types of input, there's currently a W3C proposal for pointer events that combines all types of pointing device input (pen/mouse/touch) into one set of events. For example, onpointerdown would fire when both onmousedown and ontouchdown would.

React native supports pointer events experimentally. https://reactnative.dev/blog/2022/12/13/pointer-events-in-react-native

Since Qt5, there's been PointerEvent support along with raw mouse events. Qt's native button component, QPushButton has a clicked listener that acts simiarly to how onclick works in browsers.
egui's clicked() method seems to respond to touch events.
Both Xilem and Druid don't support touch yet, but Iced has a pressed event that fires both from touch and mouse.
GTK's click event works similar to the previous cases, and is derived from its button's activate event.
SwiftUI's buttons have an action argument that fires whenever the button is clicked or pressed.

Generally from what i've seen:

Most toolkits tend to keep events specifically labeled as "mouse-events" mouse-only. E.g. onmousedown can't be triggered from touch.
Some also have more general "pointer" events that handle both mouse and touch (and pen) simultaneously so people don't have to maintain separate listeners for each type of input.
The "click" event (which is sometimes called a pressed or action event) isn't specific to just mouse input, and can be triggered a few ways.

Just looking at some existing things:
* On web platforms, specifically `click` events are tied to keyboard, touch, pen, and mouse-related behavior. Other mouse events  (e.g. `mouseup`) can only be triggered by the mouse (not touch).

  * A `click` event is fired if either Enter is pressed or Space is released when a focusable element is in focus, a touch release is registered within a specific time-frame, or the left mouse button is released.
  * To unify other types of input and avoid adding separate listeners for different types of input, there's currently a [W3C proposal](https://www.w3.org/TR/pointerevents/) for _pointer_ events that combines all types of pointing device input (pen/mouse/touch) into one set of events. For example, `onpointerdown` would fire when both onmousedown and ontouchdown would.

    * React native supports pointer events experimentally. https://reactnative.dev/blog/2022/12/13/pointer-events-in-react-native

* Since Qt5, there's been PointerEvent support along with raw mouse events. Qt's native button component, `QPushButton` has a `clicked` listener that acts simiarly to how `onclick` works in browsers.

* egui's `clicked()` method seems to respond to touch events.

* Both Xilem and Druid don't support touch yet, but Iced has a `pressed` event that fires both from touch and mouse.

* Slint uses pointer events under the hood for their `TouchArea` element. https://slint-ui.com/releases/1.0.2/docs/slint/src/builtins/structs.html#pointerevent

* [GTK's `click` event](https://docs.gtk.org/gtk4/signal.Button.clicked.html) works similar to the previous cases, and is derived from its button's `activate` event.

* SwiftUI's buttons have an `action` argument that fires whenever the button is clicked or pressed.

Generally from what i've seen:
* Most toolkits tend to keep events specifically labeled as "mouse-events" mouse-only. E.g. `onmousedown` can't be triggered from touch.

* Some also have more general "pointer" events that handle both mouse and touch (and pen) simultaneously so people don't have to maintain separate listeners for each type of input.

* The "click" event (which is sometimes called a `pressed` or `action` event) isn't specific to just mouse input, and can be triggered a few ways.

Nice, thanks for this explanation 😄 💯
Pointer events are the way to go IMO, I had a look at them a few months ago and I liked them


Crashes upon loading EDIT-file

Hello there,
I JUST stumbled upon this project which seems to be very cool indeed - so I am very new to editing PES files. Forgive me please if n00bness is paramount.
I am running SP Football Life 2024, newest update - thus I take it PES 2021. I am playing BAL and want to edit a custom player's detail. (So sorry if I cannot use this tool at all, it just seems other people have had success with this program).
I am trying to open an EDIT-file, and the program immediately crashes. I see there has been a previous ticket regarding this.
When opening the EDIT-file, I indeed briefly see some stats and sliders changing accordingly, but then it crashes.
Furthermore, I tried another version according to this site which also does not work.
Thanks very much in advance! Let me know if I need to provide further information.

Would you be willing to share the save file you're attempting to edit?  That will make diagnosing the cause of the crash much easier.


Incorrect cardId while creating a card

We are actually having an incorrect card ID while creating a card using API.
We first made a call on mango.CardRegistrations.create for asking to create the card using card datas entered by user and then, we call a second time your API adding accessKey & preRegistration datas necessited to definitively create the card like the code below :
`          mango.CardRegistrations.create({
'UserId': user.mangoId,
'Currency': 'EUR'
}, function(cardRegistrationData) {
let cardData = {
"cardNumber": card.number,
"cardExpirationDate": card.expires.replace('-', ''),
"cardCvx": card.cvv
}
          // Configure the request
          let options = {
            url: cardRegistrationData.CardRegistrationURL,
            headers: {'Content-Type': 'application/x-www-form-urlencoded'},
            form: {
              data: cardRegistrationData.PreregistrationData,
              accessKeyRef: cardRegistrationData.AccessKey,
              cardNumber: cardData.cardNumber,
              cardExpirationDate: cardData.cardExpirationDate,
              cardCvx: cardData.cardCvx
            }
          }

          request.post(cardRegistrationData.CardRegistrationURL, options, function(err, httpResponse, body) {
            cardRegistrationData.RegistrationData = body
            mango.CardRegistrations.update(cardRegistrationData, function (createdCard) {
              if(createdCard.ResultCode !== '000000') {
                extra.popup = notif(createdCard.ResultCode)
              }

              card.resultCode = createdCard.ResultCode

              mango.CardPreAuthorizations.create({
                AuthorId : user.mangoId,
                CardId : createdCard.CardId,
                SecureMode: "FORCE",
                ExpirationDate : new moment().add(1, 'day').unix(),
                DebitedFunds : {
                  Currency : 'EUR',
                  Amount : 100
                },
                SecureModereturnURL   : config.webUri +'/redirect3ds'
              }, function(preAuthorization) {
                if(preAuthorization.ResultCode !== null && preAuthorization.ResultCode !== '000000') {
                  extra.popup = notif(preAuthorization.ResultCode)
                  cb()
                }

                card.popupHtml = preAuthorization.SecureModeRedirectURL
                card.mangoCardId = createdCard.CardId
                card.preAuthorizationId = preAuthorization.Id
                user.cards.push(card)

                user.save(function(err, user){

                  if(err){
                    card.decline(err.message, via)
                    return cb(err)
                  }

                  card = user.card || user.lastCard
                  cb()
                })
              })
            })
          })
        })

`
Everything works fine, but sometime we have a strange answer like an incorrect card id created after the call. I haven't catched the API for the moment, but the informations I got to raise this error are the following car ID returned by the API : 670c2821-4c3d-42b2-b6c6-6af152c96647#1529394882
Then, on the next call using this card ID (payin, payout...) we have this normal answer :

One or several required parameters are missing or incorrect. An incorrect resource ID also raises this kind of error. { Message: 'One or several required parameters are missing or incorrect. An incorrect resource ID also raises this kind of error.',
Type: 'param_error',
Id: '670c2821-4c3d-42b2-b6c6-6af152c96647#1529394882',
Date:<PHONE_NUMBER>,
errors:
{ CreditedWalletId: 'The value bf37ed15-d896-4aff-befd-1977bffe4200#1528708284 is not valid' } }

The user ID problem seems appear on user creation, when I encapsulate callbacks like mango.Users.Create & mango.Wallets.create, and mango.PayIns.Create on the next callback, everything works fine when I do it again manually (by deleting mango user & card infos from user collection).

Hello @DreaMaTiK,
It seems like your request was errored, but error ID was set as a CardID.
I don't know if you're always facing this issue and using the same workaround, please feel free to give us some feedback here.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 16:24:29 on 2023.05.19
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 3, errors out: 0
Original problem ID: 20975
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=20975

Problem has been resolved in 6m 0s at 16:30:29 on 2023.05.19
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 20975


Multiple addressess/hosts for stub zones

With this change, we can once again have multiple addresses/hosts per stub zone.

Hi, :+1: otherwise we have an error… This a regression :-/
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: undefined method `split' for ["<IP_ADDRESS>@10053", "<IP_ADDRESS>@10053"]:Array at /srv/puppet/production/modules/unbound/manifests/stub/validate_addr.pp

This change looks good to me, though I wish we had an rspec test to avoid further regression.

I've sent https://github.com/rswarts/puppet-unbound/pull/1 which if merged, will handle the base spec test I'm after.  I think I have it correct, this code doesn't seem to work for '<IP_ADDRESS>@10053' style addresses, as we have in the readme.  I'd still like clarification around why we append the ,$name to each element.  Is that just to avoid name space collisions?

Hi @xaque208, your test works fine, just had a small typo in it.
The reason for the ugly ,$name appending is indeed preventing two stub zones with the same addresses causing problems. Without involving the future parser and making everyone not using it unhappy, I could not find a nicer way to make this work for both single and multiple addresses for multiple stub zones.

Yep, I figured it out after I continued staring at it. :)  It'd be nice to move the validation logic into a function or some such to clean up the code some.  That sounds like another day's work though.
This all looks good.  Thank you for the efforts, and sorry for the breakage.


Add compatibility with django-hstore

This project is currently incompatible with django-hstore schema mode. hstore introduces it's own VirtualField. I've demonstrated the issue here.
autocomplete expects ._meta.virtual_fields to contain a fk_field property here. However the hstore VirtualField does not have a fk_field.
for field in meta.model._meta.virtual_fields:
    ...
    required=not meta.model._meta.get_field_by_name(field.fk_field)

A check if hasattr(field, 'fk_field'): fixes the issue and I can't see it causing any harm. Would you consider a pull request to support this? If you feel this is better solved on django-hstore's end please let me know. I'd love to get a fix accepted on one of the projects.
See issue on django-hstore too.

Isn't this fixed with master or 2.1.0rc2 ?

Well have a test in 2.3.


Made things work with python 3.

I made xerox work with Python 3. This entailed:

Changing the relative imports within the package to explicit relative imports.
Changing except Exception, why to except Exception as why.
Using subprocess.check_output rather than the (deprecated) commands module.
Always using string.encode("utf-8") and string.decode("utf-8) rather than unicode(string) or str(string.

Also included are two little maintenance-y things that helped a lot:

putting *.pyc in .gitignore
only catching OSErrors, not general Exceptions, so I could actually tell what was breaking.

I ran the tests in 2.7.2 and 3.2, and they pass in both. I don't have a linux or windows box with me, so I couldn't do any cross-platform testing.

Wow, this is fantastic! Thanks :)

:sparkles: :cake: :sparkles:


Clean Up .lock file on SIGTERM

Issue #, if available:
https://github.com/aws-robotics/aws-robomaker-sample-application-objecttracker/issues/14
Description of changes:
Remove .lock file on receiving SIGTERM as a cleanup, so that the exit routine is more graceful.
(This a reopening of https://github.com/aws-robotics/aws-robomaker-sample-application-objecttracker/pull/19, because the previous pull request went stale and is supposedly coming from an unknown repository.)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The callback function on SIGINT/SIGTERM has been confirmed to work in RoboMaker simulation.


Update DINOExtract gpu

When loading DINO, make sure the GPU is available and load the model on the GPU.

Looks great, thank you!


[Bug]: Nightly is not up to date.

The nightly module is not up to date.
Also we probably should not release v240 just yet because master contains a lot of bug fixes and stuff that isn't in release.

Yeah I wonder whose fault that is...

I wonder

Isn't v240 fine though. Like it's nightly that isn't fine

Isn't v240 fine though. Like it's nightly that isn't fine

Nightly seems to work for me
There are bugs in v240 that arent in nightly

Fiiine... No more v240 for you guys

Good news; this gonna be fixed when sceleratis fixes the server today

found another error

Another error where

Another error where

I wonder where

Nightly on roblox or current nightly

nightly

latest one

As always I blame ccuser

Unfortunately, we have failed to fix the server and release v240.

@moo1210 dw sceleratis will DEFINITLEY do that today

It will be updated, stop your yapping

found another error

You have invalid commands if you get that
One of your plugins sets a function to server.Commands

You have invalid commands if you get that
One of your plugins sets a function to server.Commands

Im not using any plugins

this error appears when I switch the chat version to the new one

You have invalid commands if you get that
One of your plugins sets a function to server.Commands

Im not using any plugins

this error appears when I switch the chat version to the new one

It certainly doesn't appear for me. How are you exactly using your nightly module? Did you build the latest nightly from github?

It certainly doesn't appear for me. How are you exactly using your nightly module? Did you build the latest nightly from github?

Yes

It certainly doesn't appear for me. How are you exactly using your nightly module? Did you build the latest nightly from github?

Yes

Compile https://github.com/Epix-Incorporated/Adonis/archive/refs/heads/master.zip with rojo and then show a screenshot of the error.
It doesn't happen with me or anyone else who uses nightly

Ill try that when I get the chance

@ccuser44 I compiled adonis with rojo but its not inserting into studio
Also the same error shows up in-game, not in my console

@ccuser44 I compiled adonis with rojo but its not inserting into studio

Compile to rbxl

Upload server is fixed so issue resolved


Access Violation error on GetText()

I made a real simple console application with the following code:
        static void Main(string[] args)
   `     {
            using (var te = new<EMAIL_ADDRESS>"eng"))
            {
                using (var img = Pix.LoadFromFile(@"./bla4.tif"))
                {
                    using (Page page = te.Process(img))
                    {
                        var text = page.GetTextt();
                        float confidence = page.GetMeanConfidence();
                    }
                }
            }

            Console.WriteLine("Done!");
        }

Whenever I run my application it throws an exception on page.GetText(). I tried to reinstall the nuget packge. Tried to switch from .NET 4.5 to .NET 4.5.1 and reinstalled the NuGet package. I even tried to  rebuild the source and use the new DLLs. But I keep getting t he same exception:
Attempted to read or write protected memory. This is often an indication that other memory is corrupt

What else can I try to fix this error? (using VS2013).

Unfortunately the 3x release is broken and the issue appears to be with the
builds of the native tesseract library rather than the wrapper itself.
Please rollback to 2.4.1 as detailed on the read-me. There is no fail proof
work around for this issue at the moment.
On Sun, Feb 7, 2016 at 5:16 PM, Chinook Project<EMAIL_ADDRESS>wrote:

I made a real simple console application with the following code:
    static void Main(string[] args)

`     {
using (var te = new TesseractEngine(@"/tessdata", "eng"))
{
using (var img = PixLoadFromFile(@"/bla4tif"))
{
using (Page page = teProcess(img))
{
var text = pageGetTextt();
float confidence = pageGetMeanConfidence();
}
}
}
        ConsoleWriteLine("Done!");
    }

Whenever I run my application it throws an exception on pageGetText() I
tried to reinstall the nuget packge Tried to switch from NET 45 to NET 451
and reinstalled the NuGet package I even tried to rebuild the source and
use the new DLLs But I keep getting t he same exception:
Attempted to read or write protected memory This is often an indication that other memory is corrupt
What else can I try to fix this error? (using VS2013)
—
Reply to this email directly or view it on GitHub
https://github.com/charlesw/tesseract/issues/240.

Duplicate of #231, closing


All breakpoints are unverified

VSCode Version: 1.28
Node Version: 10.12
OS Version: Windows 10 1803
Using Typescript: No
Using Webpack: No

Launch configuration
{
  "type": "node",
  "request": "launch",
  "name": "Launch Program",
  "useWSL": true,
  "program": "${workspaceFolder}\\index.js"
}

Steps to Reproduce:

Add breakpoint which appears as a red filled circle
Launch with above configuration
Breakpoint turns to gray outline with hover of 'Unverified breakpoint'
Insert debugger; statement in code
File opens with subtitle 'read-only core module' in the titlebar
Add breakpoint to this read-only file. This breakpoint works as expected
Remove debugger; statement in editable source file
Add functioning breakpoints in the read-only file as required. They all work perfectly.

Line of Examination:

Disabling sourceMaps in the launch configuration didn't work
"localRoot": "${workspaceFolder}" and "remoteRoot": "C:\\Users\\user\\folder" did nothing. Code still opens in separate read-only file
Opening entire folder in Ubuntu and running launch as-is works perfectly. No issue with breakpoints at all.

I have been struggling with this issue since at least July 2018 without finding a working solution. I would be very grateful for help, since I have to go back to inserting console.log statements all over my code.

Does this issue occur when all extensions are disabled?: Yes

@ghirlekar what do you mean by "Opening entire folder in Ubuntu"?
What do you open if breakpoints don't work?

File opens with subtitle 'read-only core module' in the titlebar

If you hover the title of the readonly file, you should be able to see the full path. How is that path different from the real path of the file? That should give us a hint...

File opens with subtitle 'read-only core module' in the titlebar

If you hover the title of the readonly file, you should be able to see the full path. How is that path different from the real path of the file? That should give us a hint...

It doesn't show a full path; only the filename (index.js in this case).
I also tried on the latest Insiders edition 1.29; it has the same issue.

Can you set "trace": true, run it again, and upload the log file here? That should have the info we need.

debugadapter.txt
Due to a conference, I will not have access to this desktop until Sunday morning. Until then, I can reply to comments but not run any launches. Sorry for the inconvenience.

NodeJS: 10.12
VSCode: 1.28.2
I think I have the exact same issue, which started to appear with 10.12 (node 10.11 and before works as expected). Node 11 has the same issue.
Thinks works if I run and debug on Mac, but since node.js 10.12, if I debug from mac to a local docker image (alpine/node 10.12) It seems that node.js 10.12, on linux at least, emit the wrapped js file on debug, which seems to cause confusion for VSCode.

Best case scenario, vscode can recover and find the breakpoint and allows you to step through the emitted file (read-only file). Usually that happen when you put breakpoint on the .js file. Inconvenient, but still workable.

Worst case,  is that if we use some map file (i.e. TypeScript source files), then, nothing get found and cannot set breakpoints on source files.

I rolled back to 10.11 and all work as expected. I think nodejs changed something but I looked at their issues and nobody seems to be mentioning anything about this.
I was hoping that node 11 was going to roll back whatever they did in 10.12, but it does not seems to be the case.
Here is the file I have to debug when running node.js 10.12

With node.js 10.11, I just debug the start.js
I have a little code sample which reproduces this problem by just chaning the docker image from node 10.11 to node 10.12. I can put it online if there are some interest.
This is a big deal for us, I am not sure it is a VSCode issue, but feel free to let us know if there is anything we can do to help VSCode or Node team to get to the bottom of it.

@ghirlekar Does it work if you have your repo under a path that doesn't have a space in the path? Possibly this is from Node's change to use file:/// URIs instead of paths, and we might not decodeURI at the right time.
@jeremychone Do you have a space or any special characters in your project's path? If not, please upload a log too.

@roblourens I will be able to check in about 36 hours and get back to you then.

@roblourens So, no special character or space (beside '-'). Also, in my little experiment, I do not have any symlink as well.
So, in my case, when no map file, I can debug but in this read only mode where the first line (function.... ) is "added" (probably from JS runtime). Not sure who removes it in normal debug (vscode or nodejs debug interface).
Ok, I will read how to make the log upload it.

@roblourens, removing spaces from the file path solves the original issue, but raises a slightly different one.
If I open the source index.js, attach breakpoints and launch, the breakpoints work correctly.
However, the breakpoints trigger into a new index.js which is a read-only core module that seemingly wraps my original index.js in an IIFE.

So for every breakpoint, I have to inspect, close the read-only module, attach breakpoints in the source index.js, etc. all while constantly closing the read-only index.js that keeps opening.
If I remember, debugging used to trip breakpoints in the source file itself, right? I don't recall having to keep closing read-only modules in the past.

Can you provide a new log after you work around the space issue? I will fix the space issue for october.

Here you go.
debugadapter.txt

Ok there seems to be a separate issue with WSL separate from the space issue, I'll have to try it out.

@roblourens So, I had exactly the same "read-only core module" problem as @ghirlekar (I never had special/space char in my paths).
For me, it occurs when I run node.js 10.12 and above in a docker image (all works fine with node.js 10.11 on docker, or even node.js 10.12 when running server on local osx).
I created a minimalistic repo which reproduces the issue: https://github.com/jeremychone/node-vscode-debug-issue (see readme to reproduce the issue)
I tried to put the trace:true, but did not see any output file generated. I might be missing something obvious.
The real problem with the "read-only core module" is that it seems to be the beginning of more serious confusion when we use .map file (.e.g., typescript source file) where none of the breakpoints on .ts files are recognized anymore (if need be, I can create another simple repo to show this case)

Thanks for the repro case, I can repro this issue, fix inbound.

I opened https://github.com/Microsoft/vscode/issues/62354 because the "readonly module" issue is technically separate from the "space in path" issue

I've pushed a couple fixes for these two issues, I'd appreciate if everyone can try using the next Insiders build! (released a couple hours after this post)

@roblourens, I just tried with v1.29.1.
Your fix worked perfectly when I launched from VSCode, but if I have my server running with nodemon and try to attach to that from VSCode, then it shows unverified breakpoint again.
I've attached the trace file.
debugadapter.txt

For an attach configuration, it tells me Property useWSL is not allowed. The docs you linked also use it only with a launch configuration.

In that case I think you need to fill in remoteRoot/localRoot manually.
Example:
"localRoot": "${workspaceFolder}",
"remoteRoot": "/mnt/c/<path>"

That didn't seem to do anything. Breakpoints are still a hollow gray and say 'unverified' on hover.

You probably need to fix those paths. But please open a new issue. Also you can use .scripts to see how the paths are being resolved.

I will open a new issue as you recommend.
BTW, I didn't understand exactly what you meant by needing to fix those paths. I used these in the attach configuration
"localRoot": "${workspaceFolder}",
"remoteRoot": "/mnt/c/Users/admin/Documents/GitRepositories/erp/graphql_server"

Also, I assume you mean tasks. Regrettably, I have zero experience in using those.

If graphql_server is the folder you have open in vscode, then that looks right. But I can help you troubleshoot some more if you open a new issue with a log.
I meant, enter .scripts in the debug console, and it will print the scripts in their original and resolved forms.
Alternatively, if it's possible to use a "launch" type config with "useWSL", it may "just work".


iOS build crashing (duplicate symbol)

Hi there,
We are using version 1.0.1 of this package together with https://github.com/segmentio/analytics-react-native (version 1.3.1).
We noticed, that when we are building our app for iOS (doesn't matter simulator or a real device), we are facing such issue.
Issue screenshot:

Environment:
React Native: 0.63.2; XCode version: 12; Simulator/device: iPhone Xr, iOS 14;
At the same time Android build works well.
Does anyone here know what might be wrong and how this issue can be fixed?

@lyshchenkosergiy Sorry for the late response. I think the reason for this is that our react-native library is based on Segment's one, so that's why there's a conflict. We have a segment integration so you could just turn that on as an easy fix instead.

@lyshchenkosergiy Sorry for the late response. I think the reason for this is that our react-native library is based on Segment's one, so that's why there's a conflict. We have a segment integration so you could just turn that on as an easy fix instead.

@timgl I tried to contribute to the iOS repo with the fix for this issue - https://github.com/PostHog/posthog-ios. But unfortunately I'm not able to push feature branch (permission denied) in order to create pull request. Does PostHog accept contributions from community and is there any chance I can create a pull request?

@serhey-dev Hey, I think you'll need to "fork" the repository first, then you can create a pull request back into that repo. There's some instructions here: https://mattstauffer.com/blog/how-to-contribute-to-an-open-source-github-project-using-your-own-fork/

@timgl https://github.com/PostHog/posthog-ios/pull/9 I just added a Pull Request to ios package repo. This should fix the issue with build on iOS.

Hey @serhey-dev I've finally released 1.1.1 that includes your iOS patch. Please let us know if it works fine or if there are any other issues we can help with.


DCOS-41503: show JSON parsing errors as top level errors

Testing

Go to the Service form and open the JSON editor. Create invalid JSON. Admire the error message being shown on the left side and the review button not doing anything on click
Trade-offs

Decided against system tests, as this is a UI only issue IMHO

Dependencies

None
Screenshots

From 1.12:

@juliangieseke 1.10 integration test failure is due to CI adjustments. Gonna have a look and try fixing it today or just reverting the change.

@juliangieseke @DanielMSchmidt nope, looks like change I made yesterday is sufficient, integration tests should be good. The failure looks like a legit one.

@DanielMSchmidt tests are failing on 1.10 branch. 1.9 unfortunately doesn't have integration tests on CI

So, this PR has nothing to do with it?

@DanielMSchmidt the concern is that if the same change fails on 1.10 it could probably not work on 1.9 as well

Oh, this is the 1.9 backport 🙈


remove tiller/environment dependency from plugin package

This might be controversial. I'm putting this PR out to get some feedback on this.
While writing the helm-diff plugin starting with helm 2.3 I suddenly pulled in a dependency on github.com/kubernetes/kubernetes which as you all know is quite a heavy cross to bear.
Needless to say this is totally unnecessary because the plugin just want to talk to tiller via grpc and does not interact with kubernetes directly.
It also inflates the resulting binary from 13MB to 63MB which is at least a little annoying.
I looked into this a little and turns it is because of a dependency from k8s.io/helm/pkg/plugin to k8s.io/helm/pkg/tiller/environment. Its only used to access the TillerNamespaceEnvVar constant.
k8s.io/helm/pkg/plugin is used by k8s.io/helm/pkg/downloader which is the package I need to import to reproduce the downloading of charts. Arguably these things have nothing todo with kubernetes und having a lighter dependency graph would improve the usability of these packages as libraries considerably.
What do you think?

I don't see any problem with this but also don't understand why that dependency was taken in the first place.


Trouble flashing recovery image

I have a Samsung SM-N910F and i am trying to flash a recovery to my phone to install cyanogen
I am having error downloading PIT file(s?)
here is what i'm getting when trying to flash it.
C:\Users\Fibban\Desktop\Root\Heimdall Suite>heimdall flash --recovery twrp-3.0.2-0-trltexx.img --no-reboot
Heimdall v1.4.0
Copyright (c) 2010-2013, Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
libusbx: error [init_device] device '.\USB#VID_1038&PID_1384&MI_01#6&351DD5F9&0&0001' is no longer connected!
libusbx: error [init_device] device '.\USB#VID_1B1C&PID_1B09&MI_02#6&2BE4B47E&0&0002' is no longer connected!
Claiming interface...
Setting up interface...
Initialising protocol...
Protocol initialisation successful.
Beginning session...
Some devices may take up to 2 minutes to respond.
Please be patient!
Session begun.
Downloading device's PIT file...
ERROR: Failed to send request to end PIT file transfer!
ERROR: Failed to download PIT file!
Ending session...
ERROR: Failed to send end session packet!
Releasing device interface...
I have tried with both winUSB and lbusbK drivers.
Any help? I am a complete newbie so i'm terribly sorry if this seems super simple

did u ever solve this? I have a very similar error


GSB: Start purging the notion of "derived via concrete" requirements

The notion of a 'derived via concrete' requirement was meant to handle the following scenario:
protocol P { associatedtype T : P }
class C<T : P> : P
func foo<X, Y>(_: X, _: Y) where X : P, Y : P, X : C<Y> {}

The requirement Y : P is implied by X : P, since X : C<Y> introduces Y == X.T, we have X : P, and T : P in protocol P. Since X : P is in turn implied by X : C<Y>, we would normally consider both X : P and Y : P redundant -- but as soon as we drop X : P, we must keep Y : P, since X : C<Y> by itself does not imply that Y : P. This was captured by saying that Y : P was "derived via (the) concrete" requirement X : C<Y>.
However, the recently-introduced mechanism for rebuilding signatures after dropping redundant conformance requirements subsumes this notion. In the above example, once we drop X : P, we build the signature X : C<Y>, Y : P. The only thing we have to change is that when rebuilding a signature, instead of dropping all redundant requirements (which would also drop Y : P) we only drop those that are directly implied by a superclass or concrete type requirement. X : P is directly implied by X : C<Y>, but Y : P is derived from X : P.
Since rebuilding doesn't yet work for requirement signatures, we can't remove it outright, but we can narrow it down to only occur with a requirement signature. Once we can rebuild requirement signatures, we can remove this logic entirely.

@swift-ci Please smoke test

@swift-ci Please test

@swift-ci Please test source compatibility


Lhp/fix file formatting

Change encoding of utf8 tests to utf8 from windows-1252

Need to bring in an additional change; will reopen after pushing it

StaplesDataTest running successfully.


Add Partial.asReadonly()

This seems to work, but I have some questions/concerns:

The test stuff is completely arbitrary and I don't know if what I've done really follows the intent
Not sure I named things the way you like - I decided to just be symmetric with Record
Now partial.ts is basically a carbon copy of record.ts...it's just begging to be refactored

Thoughts?
Fixes #152

Coverage increased (+0.006%) to 99.133% when pulling e45820d349ed199f8f7370c5493b915ba5e42eeb on keithlayne:readonly-partial into aaed8327e4ee35c6682701123ff3285d23f2a95a on pelotom:master.

The test stuff is completely arbitrary and I don't know if what I've done really follows the intent

What do you mean by arbitrary?

Now partial.ts is basically a carbon copy of record.ts...it's just begging to be refactored

I agree, what do you think about making Record take an optional argument which marks it as partial, and then Partial just being an alias to Record with that flag set?

Sorry for being unclear.  I meant what I wrote in the tests was pretty much just guessing.  Obviously readonly has no impact on runtime, so (I guess) it should have the same tests as Partial.  Soooo...I didn't know if you'd want me to do something better in the tests.
I will give the refactor a go, looks pretty simple.  Thanks for responding so quickly!

@pelotom How do you feel about the .asPartial()?  I figured you didn't hate it at least since you merged it :)
But probably need to document it.  This is sort of a reminder to myself to try to do that.

It seems fine to me. Documentation would be good though!


Fix Matrix Notifications (charset=utf8)

From: Matrix Notifications<EMAIL_ADDRESS>...
--===============3135740482898039686==
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf8
Content-Transfer-Encoding: base64

Without this patch, if an email with utf8 charset was processed, did we encounter an error?

yes

Thanks, I will push out a new gem release in a few minutes.


Describe anonymous access, system:authenticated group

Docs for https://github.com/kubernetes/kubernetes/pull/32386

This change is

kubernetes/kubernetes#32386 has merged, @ericchiang PTAL

Nothing changed with the unauthenticated port. It still does not hook up the authn or authz chains.

Nothing changed with the unauthenticated port. It still does not hook up the authn or authz chains.
Show all checks

Oh, nevermind then. lgtm pending the typo.


Correlated Events

The correlated events come in through the pan:log sourcetype but do not have the key fields extracted.
It would be great to have these fields extracted like they show up in the PA's Correlated Events screen.
match Time
Update Time
Object Name
Source Address
Source User
Severity
Summary
Match OID
Object ID
Would be great to see Destination Address as well if it becomes available.

Relates to pull request #23