[BUG]: Achievement notifications are broken

Description
When I tried to click on the notification for an achievement; it did this

(optional) What browsers are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@idk23535 can you try recording it?


[FLINK-26289][runtime] AdaptiveScheduler: Allow exception history to …

https://issues.apache.org/jira/browse/FLINK-26289
In FLINK-21439, we've started collecting a history of exceptions in the Adaptive Scheduler. We have a good coverage that this part works properly, but we've missed the part that exposes the history via REST API.
The problematic part is that execution graph attached with the ExecutionGraphInfo does no longer contain a failure info.
This is covered by a new integration test.

Thanks for the contributions and reviews. The CI run succeeded. I'm gonna merge it.


Update README for 0.7 release

The README needs some updates for the 0.7 release:

Add links to new font renderer crates (if they are finished for 0.7)
Update instructions how to run simulator examples (#536)
Change font attribution
Link to new migration guide

Please add any additional items that I forgot.

The only thing I can see right now:

Migration guide for 0.6 -> 0.7

The "Shapes and text" example should be updated:

The border around the display can be drawn by using display.bounding_box() and inside stroke alignment.
The centered text can use TextAlignment::Center and e.g. display.bounding_box().center() + Point::new(0, dy)
In the README version of the example it contains a line that starts with #

How should we handle the remaining images in the README/doc root? I don't think that we can inline them, because GH strips data URLs from Markdown documents. But the images aren't essential to understand the docs, so that IMO it's not a big problem if the aren't visible if someone views the docs without being connected to the internet.
But perhaps we should change all links to GH to include a specific revision of the repo, so that they remain valid even if we change the repo layout or remove an image from the docs in the future.

that IMO it's not a big problem if the aren't visible if someone views the docs without being connected to the internet.

Agreed. I think we should check the alt text of all the images and make sure they're accurate for cases like that - as a reader it's useful to know what I'm not missing if the image didn't load.

But perhaps we should change all links to GH to include a specific revision of the repo, so that they remain valid even if we change the repo layout or remove an image from the docs in the future.

Excellent idea

Do you have an idea how we could make the link to the drawing examples stand out more?
The mysterious YT algorithm had suggested me this video some time ago: https://youtu.be/PfchkNNmonU?t=4095 I did watch some excerpts where they are looking at the e-g docs, which was interesting to get an outside view. At the linked time they don't seem to not notice that the drawing examples still exist in the 0.7 docs.

We could reshuffle the lib.rs docs and move the Examples section up the page, but I like the ordering of the rest of the content as is.
Perhaps we could add a shorter Examples section just below the list of features at the top which links further down the page to the actual Examples section. It could also be used as a place to link to both the examples mod in the docs and https://github.com/embedded-graphics/examples without using up too much space.


Add outline-

I  would like to have Tailwind support changing of outline color, which is the CSS attribute outline-color.
I am currently using a workaround which is:
button:focus {
    outline-color: #ee3150;
}

But I would like to be able to do:
button:focus {
    @apply .outline-pink;
}

I don't like how the colour must be manually set because if the colour is ever changed in Tailwind.js config file, then the person must know to grep the code for #ee3150.
I propose this not only because it appears to be a good idea for me, but it also appears to be a good idea to fully support a11y by allowing people to use focus/hover/active states that are not just outline-none.
I might be able to submit a PR if I could be guided with some approximate instructions because I can't dedicate a lot of time to such a task. My workaround solution works, but I don't love it.
Thanks,
Adam

Hey Adam! An easy way to add outline styles to your own Tailwind projects would be to write a plugin:
https://tailwindcss.com/docs/plugins#adding-utilities
Then you can use @apply to mix it into your other classes just like you've shown in your example 👍🏻

That's beautiful. Thanks for the quick aid and for helping us connect these keywords into Google.

But I do still feel that outline-color is a candidate for fostering a11y. I might argue it is a common appearance-related thing, but that's just for the Tailwind crew to chew on.

Is the outline color you wanna use the same as the text color? If so you could simply write outline-color: currentColor;.
If that's not the case, couldn't you simple do something like outline-color: config('colors.pink');? This is probably closer to what you said you wanted to accomplish and will provide you with more flexibility than using currentColor.

The colour is the same as our primary colour, so something like outline-primary is all I am after, but my goal was to try to get outline to work like bg, text, or border, so I could put any colour like outline-pink or outline-brown without fiddling with anything.
Your mention there is cool, but I don't want it determining the colour based on upstream markup.
Here is the solution that works fine:
  plugins: [
    require('tailwindcss/plugins/container')({
      // center: true,
      // padding: '1rem',
    }),

    ({ addUtilities }) => addUtilities({
      '.outline-pink': {
        outlineColor: colors.pink,
      },
    }),
  ],

The fact that colors is available in there is really all I need.

Sorry for posting to old issues but I stumbled over this via Google and build a little (inline) plugin to provide those in my current project. It dynamically generates utility classes for all available colors and variations (e.g. outline-black and outline-green-700).
module.exports = {
  theme: {
    extend: {}
  },
  variants: {},
  plugins: [
    function({ addUtilities, theme, config }) {

      let newUtilities      = {};
      const boxShadowPrefix = '0 0 0 3px';
      const colors          = theme('colors');
      Object.keys( colors ).forEach(color => {

        const colorData = colors[color];
        if(typeof colorData === 'string') {
          newUtilities[`.outline-${color}`] = {
            boxShadow: `${boxShadowPrefix} ${colorData}`,
          }
        }
        else {
          Object.keys(colorData).forEach(colorVariation => {
            newUtilities[`.outline-${color}-${colorVariation}`] = {
              boxShadow: `${boxShadowPrefix} ${colorData[colorVariation]}`,
            }
          });
        }
      });
      addUtilities(newUtilities);
    }
  ]
}

Sorry for posting to old issues but I stumbled over this via Google and build a little (inline) plugin to provide those in my current project. It dynamically generates utility classes for all available colors and variations (e.g. outline-black and outline-green-700).
module.exports = {
  theme: {
    extend: {}
  },
  variants: {},
  plugins: [
    function({ addUtilities, theme, config }) {

      let newUtilities      = {};
      const boxShadowPrefix = '0 0 0 3px';
      const colors          = theme('colors');
      Object.keys( colors ).forEach(color => {

        const colorData = colors[color];
        if(typeof colorData === 'string') {
          newUtilities[`.outline-${color}`] = {
            boxShadow: `${boxShadowPrefix} ${colorData}`,
          }
        }
        else {
          Object.keys(colorData).forEach(colorVariation => {
            newUtilities[`.outline-${color}-${colorVariation}`] = {
              boxShadow: `${boxShadowPrefix} ${colorData[colorVariation]}`,
            }
          });
        }
      });
      addUtilities(newUtilities);
    }
  ]
}

How do you use this with the focus selector?

That's a good question. I recommend starting a new issue thread quoting that example code. Dr. Wathan might not get notifications effectively in this closed thread.
Additionally, I recommend providing a URL to that new thread in here, so that others in the future could benefit from it.

Sorry for posting to old issues but I stumbled over this via Google and build a little (inline) plugin to provide those in my current project. It dynamically generates utility classes for all available colors and variations (e.g. outline-black and outline-green-700).
module.exports = {
  theme: {
    extend: {}
  },
  variants: {},
  plugins: [
    function({ addUtilities, theme, config }) {

      let newUtilities      = {};
      const boxShadowPrefix = '0 0 0 3px';
      const colors          = theme('colors');
      Object.keys( colors ).forEach(color => {

        const colorData = colors[color];
        if(typeof colorData === 'string') {
          newUtilities[`.outline-${color}`] = {
            boxShadow: `${boxShadowPrefix} ${colorData}`,
          }
        }
        else {
          Object.keys(colorData).forEach(colorVariation => {
            newUtilities[`.outline-${color}-${colorVariation}`] = {
              boxShadow: `${boxShadowPrefix} ${colorData[colorVariation]}`,
            }
          });
        }
      });
      addUtilities(newUtilities);
    }
  ]
}

How do you use this with the focus selector?

It turns out that I only had to specify the focus variant in the variants option of the addUtilities method.
addUtilities(newUtilities, {
        variants: ['focus']
});


editor: remove hover syntax reveal

fixes https://github.com/lockbook/lockbook/issues/2236 (by removing the feature)
PR is in draft because I haven't totally decided if this is the right direction (alternative: https://github.com/lockbook/lockbook/pull/2684)
https://github.com/lockbook/lockbook/assets/6198756/1172e132-5069-4bf2-8d47-d8d95794013b

https://github.com/lockbook/lockbook/pull/2686


common-utils: add bash-completion

This change increases the size of the base images by about 1MB. Below is the size comparison of the base-alpine image with and without the bash-completion package:
$ docker images --format "{{.Repository}}:{{.Tag}}\t{{.Size}}"
without-bash-completion:latest  664MB
with-bash-completion:latest     665MB

Resolve #1043

@microsoft-github-policy-service agree

The pipeline failure appears to be due to a DNS problem, unrelated to the changes made in this PR. Here is the relevant line from the build log:

curl#6 - "Could not resolve host: mirrorlist.centos.org; Unknown error"

@dmytrokyrychuk Would you be able to help fix the tests? You'd need to add similar changes as https://github.com/devcontainers/features/blob/main/src/git/install.sh#L35-L41
That would be very helpful, thanks!

@samruddhikhandale, I applied @trxcllnt's fix to the common-utils feature and verified that the feature installs on centos by running devcontainer features test -f common-utils --filter centos-7 --skip-autogenerated ..


[feature] #3660: Add Numeric type

Description
Introduce unified decimal numeric type for assets, no more Quantity, BigQuantity, Fixed.
Type is represented as 96bit mantissa + scale up to 28 decimal places.

Linked issue

Closes #3660

Benefits
Simplified code, decimals commonly use in monetary applications.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

-210 of 584 (64.04%)  changed or added relevant lines in 24 files are covered.
2894 unchanged lines in 54 files lost coverage.
Overall coverage decreased (-0.1%) to 56.667%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

data_model/src/integer.rs
21
22
95.45%

data_model/src/domain.rs
3
5
60.0%

core/src/smartcontracts/isi/mod.rs
2
5
40.0%

data_model/src/visit.rs
0
3
0.0%

smart_contract/executor/derive/src/default.rs
0
3
0.0%

data_model/src/lib.rs
3
7
42.86%

data_model/src/predicate.rs
46
50
92.0%

core/src/smartcontracts/isi/account.rs
1
6
16.67%

core/src/wsv.rs
5
11
45.45%

smart_contract/executor/src/default.rs
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

core/src/sumeragi/network_topology.rs
1
98.78%

tools/kagami/src/crypto.rs
1
12.12%

data_model/src/metadata.rs
2
78.87%

primitives/src/unique_vec.rs
2
91.24%

config/src/kura.rs
3
80.0%

data_model/src/asset.rs
4
47.45%

config/src/logger.rs
5
72.73%

logger/src/lib.rs
5
94.12%

tools/kagami/src/main.rs
5
0.0%

telemetry/src/dev.rs
7
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
22332

Relevant Lines:
39409

💛  - Coveralls

I think this is very good. I currently have to expose this to library users and have them correctly match "Quantity" and "BigQuantity" et cetera. Having it all be the same type is much better.

pytest works fine locally


[Bug]: es.index-prefix not consistent in es jobs

What happened?
To be able to configure the index-prefix with ES, the flag is es.index-prefix for the collector and query components.
For the jobs (es-index-cleaner, es-rollover and es-mapping-generator), it's using directly index-prefix without the prefix.
If we're using a common configuration for all components, then the jobs are not configured correctly with the indexprefix.
Example with the jaeger helm chart:
https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/_helpers.tpl#L371
Steps to reproduce
Deploy the jaeger helm chart with the elasticsearch storage enabled.
The jobs won't be able to find the indexes.
Expected behavior
It should be aligned and use the es. prefix as well
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
Latest
SDK
No response
Pipeline
No response
Stogage backend
Elasticsearch
Operating system
any
Deployment model
Any
Deployment configs
No response

If the helm chart is using incorrect flags, we should fix the chart.

Then why use the prefix for the username and password ?
https://github.com/jaegertracing/jaeger/blob/main/cmd/es-index-cleaner/app/flags.go#L29
Was it not to align the flags across all usages ?

It's fine to align all usages, but the way we do it is by supporting both new and old flags for some time, see https://github.com/jaegertracing/jaeger#version-compatibility-guarantees

Fair enough, thanks
I'll update de PR based on that

I ran into this bug this week. I had to go through the es-index-cleaner code to understand why my indices where not cleaned as per requested (No indices to delete was the only indication in the logs of the container although it was listing all indices). No indication of any sort regarding the indexPrefix being incorrect...
I had to understand how env vars were used in the es-index-cleaner to notice it was not working with the ES_INDEX_PREFIX envvar name passed by default but was expecting INDEX_PREFIX instead...
If you don't want to solve this, at least update the documentation to mention that INDEX_PREFIX in esIndexCleaner.extraEnv should be set when using storage.elasticsearch.indexPrefix ...

we will address this in jaeger-v2, where we're redesigning configuration completely.


Most of the toast actions do not work

See Kitchen Sink example for Toast - https://studio.ensembleui.com/app/e24402cb-75e2-404c-866c-29e6c3dd7992/screen/9a576805-019a-4bd3-953f-3c623fbfb905
Only Success toast works, rest do not do anything

need to add duration attribute to each. We should have a default duration in case a developer forgets to specify one. When you add duration, it works. Request here is to have a default duration.

also for dismissable toasts, duration should not be required.


Slurm Accounting Configurations

I've made positive progress with CfnCluster and we are using Slurm as the job scheduler. Our application to be deployed on this CfnCluster also uses the Slurm acct to check the job status.
By default the sacct will output "SLURM accounting storage is disabled", so I'll have to install slurmdbd in order to use their MySQL-based accounting storage. I tried several means to configure the slurmdbd with no luck.
Can anyone give me some pointers? I noticed that CfnCluster cookbook installs slurm at /opt/slurm, but when I installed the rpm version of slurmdbd, I have no idea how to configure it.

I tried several times by just using accounting_storage/mysql without SlurmDBD,
# ACCOUNTING
JobAcctGatherType=jobacct_gather/linux
#JobAcctGatherFrequency=30
#
AccountingStorageType=accounting_storage/mysql
AccountingStorageHost=ip-172-31-30-239
AccountingStorageLoc=slurm_acct_db
AccountingStoragePass=123
AccountingStorageUser=slurm

But still getting the following error:
[root@ip-172-31-30-239 shared]# sacct
sacct: error: Couldn't find the specified plugin name for accounting_storage/mysql looking at all files
sacct: error: cannot find accounting_storage plugin for accounting_storage/mysql
sacct: error: cannot create accounting_storage context for accounting_storage/mysql
sacct: error: Couldn't find the specified plugin name for accounting_storage/mysql looking at all files
sacct: error: cannot find accounting_storage plugin for accounting_storage/mysql
sacct: error: cannot create accounting_storage context for accounting_storage/mysql
sacct: error: Problem talking to the database: Operation not permitted

I searched all but couldn't find any useful solution. I checked the CfnCluster cookbook at https://github.com/awslabs/cfncluster-cookbook/blob/master/recipes/slurm_install.rb#L37 and it seems we'll need to specify the mysql_config during the configuration. Otherwise there's no accounting_storage_mysql.so will be created in /opt/slurm/lib.
Is there any thing I can do to have the CfnCluster installed Slurm wot work with MySQL as accounting storage?

@dougalb any suggestions that we can enable the Slurm Accounting with CfnCluster?

In cfncluster-1.3, the slurm build should include the mysql libraries. Please can you test configuring accounting using the latest release?

@dougalb awesome! I'll give it a try! Perfect timing!

So I tried CfnCluster 1.3 and created the AWS cluster that users slurm as the job scheduler. I wanted to use  MySQL as the direct accounting storage without slurmdbd. I have MySQL server installed and created slurm_acct_db database. In this testing case, I'm using MySQL root user with password 123,  and ip-172-31-26-149 the the master node hostname. Below is the corresponding section of /opt/slurm/etc/slurm.conf:
# ACCOUNTING
JobAcctGatherType=jobacct_gather/linux
#JobAcctGatherFrequency=30
#
AccountingStorageType=accounting_storage/mysql
AccountingStorageHost=ip-172-31-26-149
AccountingStorageLoc=slurm_acct_db
AccountingStoragePass=123
AccountingStorageUser=root

I also did scontrol reconfigure, but got this message when I ran sacct command:
sacct: error: mysql_real_connect failed: 1130 Host 'ip-172-31-26-149.ec2.internal' is not allowed to connect to this MySQL server
sacct: error: The database must be up when starting the MYSQL plugin.  Trying again in 5 seconds.

And I also tried "localhost" as the AccountingStorageHost but got a different message instead:
sacct: error: issue converting tables
sacct: error: Couldn't load specified plugin name for accounting_storage/mysql: Plugin init() callback failed
sacct: error: cannot create accounting_storage context for accounting_storage/mysql
sacct: error: issue converting tables
sacct: error: Couldn't load specified plugin name for accounting_storage/mysql: Plugin init() callback failed
sacct: error: cannot create accounting_storage context for accounting_storage/mysql
sacct: error: Problem talking to the database: Interrupted system call

The message is different from what I saw when using CfnCluster 1.2. It seems slurm could find mysql plugin this time, but can't load it or having trouble talking to the MySQL database.

@sean-smith @yuanzhou, did you guys figured this out?

also looking for the cure!

Sorry @jsmedmar if we missed your comment but the issue was marked as resolved and we were not monitoring it (in such cases I'd recommend you open a new issue if needed)
@jsmedmar @eugenov there is an official blog post outlining the accounting setup for Slurm in ParallelCluster: https://aws.amazon.com/blogs/compute/enabling-job-accounting-for-hpc-with-aws-parallelcluster-and-amazon-rds/. Can you check that out and get back to us if you still require some guidance?


feat(hints): add NewHint#19

~Depends on: #1026~
Description
This PR adds the missing hint NewHint#19, now known as EC_DOUBLE_SLOPE_EXTERNAL_CONSTS.

Rebased onto main after merge of #1026


Added initial CashAmount property to BacktestNodePacket

Description

Added optional CashAmount property to BacktestNodePacket class.
Adding unit tests

Related Issue
Closes #3895
Motivation and Context
By adding this property, able to set initial cash amount for algorithms without modifying alorithms
Requires Documentation Change
NA
How Has This Been Tested?
Added unit test, regression tests, cloud backtest
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero thanks for finishing it. Apologies,  was off coding during holiday season, and couldn't reply.

@Martin-Molinero thanks for finishing it. Apologies, was off coding during holiday season, and couldn't reply.

Hey @prasadsom ! no worries, thanks for giving it a shot 👍


KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

John's awesome TaskAssignorConvergenceTest revealed some issues with the current assignor, which he nailed down as being due to the state constrained and balanced assignments not converging.
One way to get an assignment that is as close to the balanced assignment as possible while still being state constrained is of course to start with the balanced assignment, and move tasks around as necessary to satisfy the state constraint. With this basic approach, the converge test is passing.
This PR also includes some semi-orthogonal refactoring, most significantly the removal of the  assignment maps; we now just immediately assign tasks to the ClientState rather than first sticking them in an intermediate map.
Also moves ValidClientsByTaskLoadQueue to its own file.
Apologies for the length of this PR due to the above, but it didn't seem reasonable to do things the wrong way in the parts I changed, just so they could be undone in a followup PR along with the other parts.

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

One build failed with unrelated RocksDBTimestampedStoreTest.shouldVerifyThatMetricsGetMeasurementsFromRocksDB (should actually be fixed already by https://github.com/apache/kafka/pull/8510)

Test this, please.

Test this, please.

Test this, please.

test this please

test this please

Unrelated java 11 failures:
kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup
org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQueryAllStalePartitionStores


Check if HTML and CSS are valid

Check if your HTML and CSS are valid. You may use HTML validator and CSS validator for this.

For html validation there are 2 info messagges and 1 warning:

Warning: This document appears to be written in English. Consider adding lang="en" (or variant) to the html start tag.
Info: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.
Info: Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.

Css validator only gives errors like this one:
Expected class selector ".experiences__company-project-responsibilities" to be kebab-case
So, actually there are no problems with a styles file.