Add TableRetentionValidator to validate the retention policy in table config, and the start/end timestamp in segment metadata

Check on 'segmentPushType', retention duration on APPEND push type for table config.
Check time unit, start/end timestamp in segment metadata for APPEND push type table.
Add it into the pinot-tools collection.

Codecov Report

Merging #1154 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
- Coverage      67%   66.82%   -0.18%
==========================================
  Files         753      754       +1
  Lines       36268    36334      +66
  Branches     4653     4666      +13
==========================================
- Hits        24302    24282      -20
- Misses      10364    10439      +75
- Partials     1602     1613      +11

Impacted Files
Coverage Δ

...pinot/controller/util/TableRetentionValidator.java
0% <0%> (ø)

...ealtime/converter/RealtimeSegmentRecordReader.java
89.74% <0%> (-7.7%)
:x:

...ltime/impl/dictionary/DoubleMutableDictionary.java
49.23% <0%> (-4.62%)
:x:

...mon/utils/retry/ExponentialBackoffRetryPolicy.java
81.81% <0%> (-4.55%)
:x:

...manager/realtime/HLRealtimeSegmentDataManager.java
76.24% <0%> (-2.21%)
:x:

...e/realtime/converter/RealtimeSegmentConverter.java
87.23% <0%> (-2.13%)
:x:

...filter/SortedInvertedIndexBasedFilterOperator.java
77.02% <0%> (-1.36%)
:x:

...ommon/request/helper/ControllerRequestBuilder.java
89.41% <0%> (-1.18%)
:x:

...ata/manager/realtime/RealtimeTableDataManager.java
50% <0%> (-1.05%)
:x:

...manager/realtime/LLRealtimeSegmentDataManager.java
69.24% <0%> (-0.69%)
:x:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b249c35...71d00f3. Read the comment docs.


feat: generate and upload PDF when COJ signed

When a COJ is signed and confirmation received back from TIS a PDF copy of it should be generated and uploaded to S3.
A notification should then be sent to SNS to inform other services that a PDF has been published for the COJ.
TIS21-6106
TIS21-6121

I have no intention to resolve the 7 code smells right now.

All looks pretty solid to me, my only hesitation is the structure of the incoming COJ-signed events.


WSL2 clock skew

Some of our Cadence unit tests are failing sometimes due to apparent clock skew between the WSL Linux distro and the host machine.  This appears to be known issue:
https://github.com/microsoft/WSL/issues/5324
It looks like the time can be way off after the host machine has hibernated (although this apparently has been fixed).  Clock skew still looks like it can accumulate over time, which is what I think we're seeing.
I don't believe this will be a problem for our WSL2 based neonKUBE distro because we're configuring NTP/systemd there.

After reading the whole thread for microsoft/WSL#5324, it looks like MSFT has identified this as a Linux kernel bug and has a fix in the works.  Looks like it'll be an updated kernel.
We me need to have neonDESKTOP check the installed WSL kernel and ensure that the correct version is installed although I still hope that this will work seamlessly since we'll be running NTP services.

Microsoft claims to have fixed microsoft/WSL#5324 but people are still having trouble (as are we).  It looks like this is going to be fixed in a new kernel release?
Here are some links to people trying workarounds:
https://github.com/microsoft/WSL/issues/4245#issuecomment-615327939

One quick workaround for unit testing would be for have the Docker related fixtures run this before starting anything:
sudo hwclock --hctosys

The plit thickens: There may be additional issues for WSL2 running in a VM host, like we're doing for our GitHub runners:
https://tomssl.com/fixing-clock-drift-in-wsl2-using-windows-terminal/

I tried running the new neon-clocksync container in DockerComposeFixture before starting the application, but that didn't work.

MSFT opened a new issue to track this: https://github.com/microsoft/WSL/issues/10006

CLOSING: I'm going to go ahead and close this because it's not impacting us right now; it was impacting Cadence/Temporal client unit testing but we've moved on from being in the Temporal client business.


Added trailing slashes to urls

It's common convention and a Django recommendation to have urls with trailing slashes.

Thanks for this pull request. You're totally right.
The reason why there are no trailing slashes now is that we created this code as a backend for AngularJS application which didn't support trailing slashes on that time. However it does support from version 1.3., so it shouldn't be a problem.
My only concern is backward compatibility. If merge this pull request we should bump the version up to 0.3.0.
@konradhalas what would you say?

@haxoza we should also update README


pdk: open_road_configuration: Get KLayout technology file and metal fill configuration from internal PDK setup

This PR modifies open_road_configuration so that it is now possible for a PDK dependency to define additional two fields:

metal (density) fill configuration JSON file,
KLayout technology LYT file.

The last one is required for GDS configuration so this field was marked as mandatory. The files are used by rules: place_and_route and gds_write. Default values specified for each PDK can be overwritten by attributes density_config and klayout_lyt of those rules.
It is reasonable to move handling of those files to the PDK dependencies setup because these are PDK-specific and can be reused for multiple designs.
CC @proppy

Hi @QuantamHD, please take a look at this PR. Merging this would unblock our work in https://github.com/google/xls/pull/1031

Thanks a lot!


QuicChannel should respect AUTO_READ

QuicChannel itself should respect AUTO_READ which means if the user asks to stop reading we should not create any more streams while still multiple data to the existing streams. The existing streams will do their own flow-control management. Beside this we should also respect AUTO_READ for datagram extension here.

Let's do this for Datagrams first.


Validation Summary/Backend validation

Hi I would like to propagate Backend Error to a Frontend Validation Error. For a specific input control with ng-model, using $setValidity('key', false); $setDirty(); works.
But if I cannot match an error to a specific control, with angular I am able to use $setValidity with the form instead of ng-model. But those errors are not displayed by angular-auto-validate?
Do you have a solution for this use-case? I think it's pretty basic need.
Thank You!

Hi @anatolibarski,
Yes you can use setExternalValidationError on the ngModel controller. See
https://github.com/jonsamwell/angular-auto-validate/blob/master/src/config/ngModelDecorator.js#L61
There isn't any documentation for this yet but I will get around to it one day.
Jon

You can also see the tests here
https://github.com/jonsamwell/angular-auto-validate/blob/master/tests/config/ngModelDecorator.spec.js#L162


Release 1.3.0.Beta30

Summary
Release contains:

https://github.com/quarkus-qe/quarkus-test-framework/pull/937
https://github.com/quarkus-qe/quarkus-test-framework/pull/936
https://github.com/quarkus-qe/quarkus-test-framework/pull/935
https://github.com/quarkus-qe/quarkus-test-framework/pull/934
https://github.com/quarkus-qe/quarkus-test-framework/pull/933
https://github.com/quarkus-qe/quarkus-test-framework/pull/932
https://github.com/quarkus-qe/quarkus-test-framework/pull/931
https://github.com/quarkus-qe/quarkus-test-framework/pull/930
https://github.com/quarkus-qe/quarkus-test-framework/pull/929

Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Release
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests

OCP native seems very much like cluster issues twice in row. I don't believe it is related.


Update plugin-oracle-cloud-infrastructure-compute.yml

Add additional developers to handle release process

Description

Submitter checklist for changing permissions

Always

[ ] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Sorry, I did not "Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name", Close this pull request for now


add experimental gnosis safe implementation

📝 Changed routes:

/gas

(view full size)

Commit 9368e988b111934b0478ee8ac8a88e4091ecaa77 (https://thirdweb-o7dpt1gmw-thirdweb.vercel.app).


Improve UX and vscode UI

Few problems that we have with the current UX/UI:

User needs to type the command to perform many action.
If you open a new vscode window (without any project in the workspace) then you are able to click "View NEAR.social account" button and open an account. But after you open an account, it's opened as a workspace, and when you close this workspace than "View NEAR.social account" button is not visible anymore.
If you have a vscode window with some project in the workspace, these are no buttons to work with, you need to use the command to view the account or login.
When you have an account as a separate workspace, it will be problematic to handle save locally functionality. We would have to make some kind of mix of separate workspaces or add some options to the list of widgets, that will indicate whether it's a local version or not. It might be problematic.

I would propose doing it differently so that it will be easy to work with widgets that are on the chain and locally at the same time. Also some other small changes.
The main change will be that there will be a separate option to the Primary Side Bar (that's how vscode is naming it) that many extensions are using. And closing most of the Near.social functionalities in this option.

When you finish near.social extension installation, a new ICON in the Primary Side Bar appears.
When you click the icon, the new sidebar will open, and there will be several options available:

"View NEAR.social account" - the same options as it is now but always visible
"Login and view account" - it will do the same as the command "login" is doing now - always visible
List of accounts that you are already loggedin to, with the option to LOGOUT from every account separately
The list of all opened accounts and the list of widgets inside the accounts - exactly like it is now. But instead of showing it as a workspace in the vscode EXPLORER, it will be available here. So the user can open a widget, made changes, publish or save locally.

Saving widget locally.
My proposition is to make it work like that:

user is opening the widget by clicking on the widget from the list of the widgets on-chain, like he is doing now
user made some changes and wants to save it locally (not publish it)
the user clicks cmd+s, now the vscode should show the standard options to choose a workspace folder, and after that, the file is saved in this folder
now the user can see this file in the vscode EXPLORER, as a workspace.

The main idea here is that we are separating two main things:

what is on the chain, and all on-chain actions
what the user has locally.

Also, it doesn't matter if the user is working on the local widget file or on-chain widget, he has the options to Publish and Preview available.
If for example, he made a change to the local widget file and clicked Publish, this widget will be published on the chain.

Changes to Preview

OPTIONAL: it would be good to add a loader, it can take a few seconds to load the preview - the user should see that something is happening, and it's worth wait.
if the user is working on a widget file locally he should see the local version of the preview, and it should be refreshed every time he saves
if the user is working on the widget on the chain, the preview should show the version from the chain, and when the user publishes the preview should refresh.

Additional changes:

Show Preview button - it would be nice if this will be a bit more visible option, not only an icon
Publish button - it would be nice if this will be a bit more visible option, not only an icon
Reload preview button - the same, it's not well visible now.

4. When you have an account as a separate workspace, it will be problematic to handle save locally functionality. We would have to make some kind of mix of separate workspaces or add some options to the list of widgets, that will indicate whether it's a local version or not. It might be problematic.

Yes. There is already a functionality on main branch that tracks local changes, but it uses global-storage for the extension. (btw, it also marks widgets that has been edited in the UI, just like git changes).
I didn't test it yet but probably there will be collisions between separate workspaces with same files, probably just like if you open same file in two editors and try to edit and save in parallel - one might overwrite the other in an unpredictable manner.
It is possible to use workspace-storage for that to track changes per-workspace.

I would propose doing it differently so that it will be easy to work with widgets that are on the chain and locally at the same time. Also some other small changes.

I agree, there are many possibilities, it's just a matter of UX decisions - https://code.visualstudio.com/api/ux-guidelines/overview
Ethereum has this full-blown extravaganza - https://marketplace.visualstudio.com/items?itemName=RemixProject.ethereum-remix
Let's see what we can take as inspiration.

OPTIONAL: it would be good to add a loader, it can take a few seconds to load the preview - the user should see that something is happening, and it's worth wait.

Yes.

if the user is working on a widget file locally he should see the local version of the preview, and it should be refreshed every time he saves

Debatable.  I suggest a toggle for live-reload.
The preview now works with your local changes, and it also supports nested widgets previews. So if you work on two widgets where one includes the other - it'll preview also the inner widget. I actually would like to add a UI indicator for the inner widgets, maybe mark them with a colorful border. Let's discuss this.

Show Preview button - it would be nice if this will be a bit more visible option, not only an icon
Publish button - it would be nice if this will be a bit more visible option, not only an icon
Reload preview button - the same, it's not well visible now.

Yes, but we are limited with what VSCode provides us to hook into - https://code.visualstudio.com/api/ux-guidelines/overview
Maybe having a tutorial explaining the usage can help - https://code.visualstudio.com/api/ux-guidelines/walkthroughs
BTW, the preview behavior is an exact (or at least tries to be) replica of Markdown files preview behavior.
The publish button should be on a dedicated NEAR panel so that the user can confidently decide what he wants to do, just like pushing to git. Eventually you would probably work on multiple widgets and publish when you finish, so a dedicated panel for you to review your work is a good option.

Multiple changes have been committed to address these issues.


[BUG] - Position dropdown in NavBar

Describe the bug
The drop-down menu in the Navbar is now being moved according to the site content instead of not moving.
Your Example Website or App
https://nextui.org/docs/components/navbar#with-dropdown-menu
Steps to Reproduce the Bug or Issue
Using preview in page

Go to website
Scroll down
Click Dropdown
Scroll up

Expected behavior
As a user, I expected Dropdown is kept position according to Navbar behavior but i am seeing Dropdown is kept position by content
Screenshots or Videos
https://user-images.githubusercontent.com/63092029/188208459-487da371-5cf7-4867-8959-80c01eb6358a.mp4
Operating System Version
Windows 11
Browser
Edge

I dont think this is a valid bug. Since the dropdown list container is appended in the tail of body and its position is absolute, it is normal for the dropdown to scroll with body.

Perhaps using position: sticky; can be a solution.

Hey guys, I already sent a PR to fix this, in the meantime, you can check this codesandbox to fix it while the new version (v11) is released, thanks! 🙌🏼

Hi @jrgarciadev, I check in your preview and it work but i still see the same problem when use with Avatar component.

@jrgarciadev  you solution only works for fixed navbar position it still breaks in static and in float it overlaps, at least in the codesandbox u provided


Can JWT token be accessed in the context obj in the resolver method?

Hi there,
I am passing JWT token in the request header but cannot figure out how to access in the resolver methods in this library. Could you please help me out? Thanks.
Cheers!

You could put it on the request context, and then extract the value from the context where you need it.

Exactly. So don't use the relay package, use a custom HTTP handler.

@tonyghita and @neelance Thanks. It works great now.


Google Analytics Tracking

@VonSub can you get the guys what they need here?
@KristofVanstappen can you then implement?

Got a code ready to go. Who can I send it to through telegram.

we'll test in on staging but should after testing only be implemented on production environment.

Awaiting feedback for referral_calltoaction project before work on this is continued


Is there a roadmap to implement terraform import...?

Hi, admins.
I use terraform-provider-eksctl for new eks cluster.
Also, I'm thinking to import existing eks cluster with terraform import, Is there any way to import or plan to implement import function for terraform-provider-eksctl?
Error: resource eksctl_cluster doesn't support import

@tetsuya28 Hey! Thanks a lot for trying this provider.
I don't really have a sort of roadmap but I added initial support or terraform import in https://github.com/mumoshu/terraform-provider-eksctl/commit/b9f3a372054b9e3ccfeb1b2345088d11ad12f7ff.
Would you mind trying it?

Any success here?

@jchoi926 I did implement it and confirmed that it works for me 😃
Can we close this and reopen only after anyone finds it to not work?

@mumoshu The import feature seems very basic according to the output of terraform show.
` terraform show
module.eks.eksctl_cluster.cluster:
resource "eksctl_cluster" "cluster" {
eksctl_bin = "eksctl"
id         = "buo1mtmvvhftrxxxxxx"
name       = "cluster"
region     = "eu-west-1"
version    = "1.17"
vpc_id     = "vpc-xxxxxxxxx"
}`
Is there no support for importing the spec block (nodegroups, vpc, etc)?

@jchoi926 I'm not sure how that's technically possible. eksctl doesn't support generating the original cluster.yaml from the eks cluster.
Can't you just bring your original cluster.yaml and put its content into imported eksctl_cluster's spec?

Or maybe we can enhance the import feature so that you can specify the path to the original cluster.yaml like terraform import eksctl_cluster path/to/cluster.yaml? That way, the provider could generate the spec content as well.

@mumoshu Bringing in the existing cluster.yaml unfortunately triggers an update on the cluster. Not a huge deal, just wondering if there was a way to bring in the existing configuration.

@mumoshu I would definitely love to have a way to import the existing cluster spec via terraform import eksctl_cluster path/to/cluster.yaml.
If this could include the ability to add the existing security_group_ids (since that seems to be "(known after apply)" after importing and I can't seem to set it through security_group_ids), that would be great! 😊

@jchoi926 @DragonStuff Thanks for requests! I hear you, but it's just that I don't know how it's technically possible.
AFAIK, terraform-import's syntax is something like terraform import TYPE.NAME TYPE_SPECIFIC_ARBITRARY_ID_STRING and we use eksctl cluster name for the ID. Perhaps we can address your use-cases by somehow parsing your cluster.yaml and producing appropriate terraform state here?
https://github.com/mumoshu/terraform-provider-eksctl/blob/7c4587caa8508b52333260635f6a80d245bf6e69/pkg/resource/cluster/import.go#L11-L18
Would you mind contributing it, by any chance?

AFAIK, terraform-import's syntax is something like terraform import TYPE.NAME TYPE_SPECIFIC_ARBITRARY_ID_STRING and we use eksctl cluster name for the ID. Perhaps we can address your use-cases by assuming the ID is the path to your cluster.yaml, and then somehow parsing your cluster.yaml and producing appropriate terraform state here?
https://github.com/mumoshu/terraform-provider-eksctl/blob/7c4587caa8508b52333260635f6a80d245bf6e69/pkg/resource/cluster/import.go#L11-L18

An idea, perhaps executing eksctl with the given spec and seeing if anything has changed during import would solve this? If there is no difference, and if spec is null, it will import the object as per the definition?
A sample import flow would look something like:

User executes terraform import eksctl_cluster.eks-cluster["eks-some-cluster"] eks-some-cluster
User executes terraform plan <-- The plan notices that spec is empty but the id exists.
--> it then checks via eksctl upgrade cluster or similar mechanism if the cluster has changed
--> if it hasn't, it imports from the file
--> if it has, it does not import

Of course, this point is moot if it does this anyway (if during the apply, it has no change, so it's automatically imported without change). I haven't tested this. 😅

Thanks!

If there is no difference, and if spec is null, it will import the object as per the definition?

Terraform doesn't provide the custom provider to access tf file content and writing tf file from the import process, afaik. So - at least the user must write tf file on their own. Perhaps that makes --> if it hasn't, it imports from the file part impossible?
terraform import eksctl_cluster.NAME already imports a few bits of your cluster info today. So if the user can accept running a few cycle of terraform plan, then terraform apply, and edit tf file after terraform import, it should already work. But if there's anything more to do on the terraform state on the import process, we should do that(That's where I'm not sure what to do).
Thoughts?


FW update problem

I use MCUBoot with 2 image slots on Zephyr device.
I noticed that image verification fails on reboot with image swap (test swap) after overriding image on second partition with image with different size. After failed verification, partition is erased.
On second upload try (after mentioned erase) image verification is successfull and image is swapped.
To override image on second slot with new image data, I use custom code (simply writing content of update binary file from the beginning of secondary partition up to image size in binary file). Rest of image slot remains unchanged. In addition at the end of upload boot_request_upgrade(false) function is called.
Is it necessary to erase whole partition when uploading new image? Or I observe some sort of bug?

I noticed that image verification fails on reboot with image swap (test swap) after overriding image on second partition with image with different size. After failed verification, partition is erased.
On second upload try (after mentioned erase) image verification is successfull and image is swapped.

What version are you using? master? It would be very helpful if you could describe the exact steps you are doing.

Is it necessary to erase whole partition when uploading new image? Or I observe some sort of bug?

No, you just need to erase whatever area you're writing the new image to, not the whole slot. When a verification of the image in second slot fails, it is erased, that is normal behaviour. So, it seems we have to find why it is failing verification.

I noticed that problem was caused by the fact that part of FLASH was not properly erased by application before write operation (it is why problem was not occurring after erasing whole partition). It is fixed already, so I am closing the issue. Sorry for problems.


feature request: ability of selecting sub-scenes from the main 3D view

complex 3D levels may be a pain to edit, if you can't select each elements from the 3d view, you have to find each scene element by browsing the hierarchy tree and, if you have hundred of elements made by sub-scenes, it's very frustrating finding a specific one.

I find it hard to select stuff in the 3D screen in general too. Sometimes it works, sometimes it doesn't at all.

it doesn't work when you try to select instantiated  sub-scenes, otherwise it works. In simple scenes you can always select stuff from the scene tree but on complex scenes is a pain.

Right, I can reproduce your issue, even with "editable children" enabled. Should not make a difference, but I note it just in case.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

I tried to instance a scene into a main 3D scene, clicking on it makes the root node of the instance selected, so I can't reproduce sub-scene selection bug.
Related issue about selection in 3D: https://github.com/godotengine/godot/issues/10979
I still find 3D selection is not always working good in some cases.

There were lots of improvements to selecting scenes in the 3D viewport, as the original problem seems to be fixed, so closing. Remaining issues with scene selection should be tracked in new bug reports against the current master branch.


FFT getValue() returning unexpected results when connected to a synth.

I am getting some wild FFT values when I connect it to a synth.
After playing the first note the values go all over the place and never normalizes. It says the expected output for getValue() of FFT is -1 to 1. I get values much larger than that.
Is this a bug or have I hooked it up wrong?
I tried the same thing with Tone.Analyser("fft",FFT_COUNT) and it gave the same results.
Tone.Analyser("waveform",FFT_COUNT) seems to be working fine.

Output from FFT:

Thanks!

Hi in the linked code example you use Math.scale is this from Underscore or something similar?

@jamesgrubb
These should work:
https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/esnext.math.clamp.js
https://github.com/zloirock/core-js/blob/master/packages/core-js/internals/math-scale.js

Error was in the docs. those float values are decibel levels at each of the frequency bins. that snippet was copy-pasted from the Tone.Waveform which returns -1 to 1.

How come the values are all negative? I mean, I get that they are negative because they are decibel levels, but they are way lower than the decibel level of the output. Is that because with all of them combined the final result is equal to their output level as a whole?
I am actually trying to make a tuner (pitch detection) using the FFT, but I am new to audio processing and I'm wondering if this is the best way to go about it. Maybe I'd be better off analyzing the Waveform data?

@codeitloadit hi I just came across this (which was helpful to understand what the range of fft is) and know it's late but I explain you why - basically decibel is a logarithm of the original scale. log(1) returns 0 no matter what the base is, and log(0) is -Infinity. So when the input is close to 0 (silence), the dB output will end up with a huge negative number. You can use Math.max(-100, fft.getValue()[n]) to clamp the output if that is easier for processing.


Update outdated link in PULL_REQUEST_TEMPLATE.md

Description
The link in the pull request template was a soft redirect.
Solution
Update it to point to the right page.
Tests
NA
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
NA I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
NA I have run ./gradlew check.
NA I have added tests for my changes.
NA I have added documentation for the Reference Guide

Thanks!


Merge develop to main

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6d10fc2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage        ?   59.51%
=======================================
  Files           ?       23
  Lines           ?      778
  Branches        ?      111
=======================================
  Hits            ?      463
  Misses          ?      310
  Partials        ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d10fc2...52edec1. Read the comment docs.


[Feature request] Flutter web, choose the web folder path and use environnement variable

Use case
We would like different web environnements with different favicon, different environnement variables, different index.html. In other word many flavor : development, production, client A, client B...
Proposal
I suggest, if possible, to add one option for flutter build to allow an other web path folder instead of the current ./web by default :
like :
web/development/index.html
web/production/index.html
flutter build web -s web/development
flutter build web --source web/development

In addition support for environnement variable inside index.html / js related files could be cool :).
(Maybe the last things already exist, but i didn't find it...)

@EA-YOUHOU
Check this comment related to flavor for web platform and see if it helps to answer your question.

I see that :
We have no plans to support flavors on the web. As an alternative you might consider using dart-defines or different entrypoints.

We need it.

@EA-YOUHOU
That statement still seems to be the current status of flavors on flutter web, so I am going ahead and closing this based on it.

Hum, you didn't keep open an issue talking about new important feature ? How the flutter team will track it ?

@EA-YOUHOU
I closed it based on the comment indicating there doesn't seem to be a plan to support flavors on web yet. If any new development happens on that front or that features comes in-scope, we'll address it.


test name if it's still null, default node.js

The new test for versions for 'nw' doesn't have a default case if versions is an object, but does not have 'nw'
should fix #125
Making PR to test; will update comment after.

Needs work.

Actually this does work; my testing had mixed versions.

Any progress on this?

shrug it's a pretty simple PR; no clue why it's not merged.

I am in kind of a weird situation now, version 1.3.4 does not work with Node.js and 1.3.3 works fine but crashes when using it with ReactNative.

npm install github:d3x0r/platform.js#patch-1
and/or set package dependency as
"dependencies": {
"platform": "github:d3x0r/platform.js#patch-1"
}
and 'npm install platform'
should only be condsidered a temporary fix as I don't plan on maintaining that patch branch forever.

Still it would be nice to get this PR merged soon

Thanks @d3x0r!

someone else ran into this problem; I thought this was merged... but looking at the code it's still not there actually.  And I didn't see the merge in the revision history of the project.... did you do something like merge it to close it and shut me up then delete the merge?  (sorry I"m cynical)

I think the version was not bumped yet


replace abap unit with atdd

hi, great idea regarding the tech radar. I'd like to enhance the abap unit section with a concrete development methodology / strategy on how to write tests: acceptance test driven development. because I've seen quite some bad unit testing (like test last development - > tests always work) and projects in general need more communication between business and IT. atdd is a way to do this :-)

Interesting proposal. But no? :-)
ATDD depends on ABAP Unit. I'd like to have ABAP Unit in the tech radar so it gets clear that ABAP Unit exists and how to consider it. It is available ootb and already has a significant usage adoption.
ATDD is a methodology on top of ABAP Unit. It is one way how to use ABAP Unit. Therefore I think it is better to have ATDD added as a separate item in the tech radar. The ring will be interesting to discuss. I guess ADOPT is a good fit for ATDD.

it's imho a valid idea to split technologies and methodologies. It's also interesting to hear that abap unit in your eyes has a significant usage adoption. great.
but what quadrant would be in your eyes a good fit for ATDD?  maybe open up a new sector for methodologies? (ATDD, test last, Activate, UAT, DevOps, pair programming, ensemble/mob programming, (enterprise )agile, waterfall, ....)

Agree with Tobias. Methodologies should be independent of technology so I would not place them on the same scale (radar). Maybe a different radar/repo which includes things like project methodologies like SAP Activate, RISE, GROW, and dev related ones Dominik mentioned


fix(all): overlay components no longer display outline when focused

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: fixes https://github.com/ionic-team/ionic/issues/21199
What is the new behavior?

Removed outline from host elements

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Not sure how this managed to slip through the screenshot test the first time... maybe I just missed it


ClearCommandTest: fix tautological tests

Tests in ClearCommandTest always pass because the actual and expected
model refer to the same instance;
`assertEquals(expectedModel, actualModel)` is always true.

As a result, the model's state isn't correctly verified.

Let's update these tests to correctly verify the model's state.

Just one nit:

ClearCommandTest: fix tautological tests

Tests in ClearCommandTest always pass because the actual and expected
model refer to the same instance;

OK, I understand what this is saying.

`assertEquals(expectedModel, actualModel)` is always true.

Can remove this line imo, it confuses more than it clarifies.
I guess it should be something like:
`assertEquals(expectedModel, actualModel)` will always return true if
expectedModel and actualModel reference the same object.

As a result, the model's state isn't correctly verified.

Let's update these tests to correctly verify the model's state.

Fix looks okay.

Sorry, I take that back, can you add back this to the commit message:
Tests in ClearCommandTest always pass because the actual and expected
model refer to the same instance;

Just having "assertEquals(expectedModel, actualModel) is always true because
expectedModel and actualModel reference the same object." says nothing about the problem.


8 executor

Executes given cmds in form of a linked list t_cmd *cmd:
Single cmd:
-> Built-in: executed directly by function call
-> system calls: forked into child process and executed within via execve
Pipes:
-> Built-in: forked into child process and executed within via function call
-> system calls: forked into child process and executed within via execve
-> piping of cmd output into next cmd input
-> precedence of individual infiles, outfiles, heredocs over pipe: fd are set accordingly

all forked processes are waited for by parent after all child processes have been created
heredocs are handled: several heredocs are opened, take input and are unlinked if more follow. last heredoc remains open as input to cmd if no infile follows. If infile follows, all heredocs are unlinked and infile set as input.
unknown cmds: error message is given, rest of pipe is still executed

closes #8
closes #45
closes #47

Looks good.
One - easy fix - memory leak when creating heredocs.
Error handling right now is all over the place - but this is a general theme in the repo right now. As you said: it's best if we look into it together.
Some refactor possibilities, which are not priority but could be remembered in a comment.
Doxygen comments in this module are a bit lacking, and don't live up to the usual standard. Sometimes copied from other repo, often times repeating (I think we don't need to repeat everywhere that pipe[1] is the write side). There is also a file with huge parts commented out (I think if we want it for later we could just reference your pipex again). I only commented on a few of them. Understandable since time constraints but when we have a tested prototype we should look into them. But very industry standard - nobody updates the comments :D

The mem leak has been adressed.
Doxygen documentation has been amended, but a final sweep at the end is anyways necessary as we will certainly do some changes while finishing up the program (including the last functionalities and during testing). When we are content with its functionality and all mem leaks/fds are taken care of, we need to:

update the documentation
check the formatting
remove unwanted comments
do a final round of testing after everything


We should have a mentor button on our site with a link to the Google Form

It would be easier for people to find the mentor registration form if it were linked on the site, rather than getting the giant ugly google URL from us.

Whoops. Just found it 😅

heh


Documentation issue

In the readme the Authorizing Transactions is using an array
$authorization_response = $client->authorize([
    'account' => '4242424242424242',
    'amount'  => '100',
    'expiry'  => '0120',
]);

But the authorize method is using the AuthorizationRequest object
$request = new AuthorizationRequest([
   'account' => '4242424242424242',
    'amount'  => '100',
    'expiry'  => '0120',
   'capture' => true,
]);

$res = $client->authorize($request);

PR#12 fixes this issue too.


Reduce logs in tests

Stop debug log lines from showing up between test indicators when running cargo test.

Alright, thanks for the review! And yeah, like you say, I prefer the separation of concerns this way. It's glue code anyway.


Request for Comment - Infinite Craft project compatibility meta tags

@Mikarific Following our conversation on Discord, I'm posting this here to make it more publicly visible:
The aim is to try and increase compatibility between projects so that end-users don't have to choose between one project or another, and to make things easier for the developers of such projects.
The currently proposed solution is for each project to add a <meta ic-compat> tag to the head of the page, containing information about itself that other projects can read and decide which of its own features it should enable or disable to prevent conflicts. I have drafted a document proposing in more detail how these tags would work. If you have any comments you would like to add, please respond to this issue or issue #29 in the IC++ repo. We would greatly appreciate your input.

I'm currently working on rewriting Infinite Craft Helper from scratch, and I've implemented the meta tag standard as suggested in your current compatibility draft. It will be available in 3.0.0+ when it releases.

Ok so this means we wont be able to use both of these until Helper 3.0? I really want the speedrun and current discoveries counter :/


Paginate make response slow with large database records

Laravel Version: 8.0.0
PHP Version: 7.4.#
Database Driver & Version:Ver 8.0.21 for Win64 on x86_64 (MySQL Community Server - GPL)

Description:
when I using paginate with models directly the response be very slow when working with large databases
Model::paginate ();
Video for the problem
Steps To Reproduce:

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

I've opted for the Laravel simplePaginate() method here because our specific use case involves returning a JSON response, and simplePaginate() neatly provides only 'Next' and 'Previous' links—exactly what we need. It has also noticeably improved performance. While I haven't delved into the inner workings of paginate() with large datasets yet, I might explore the implementation details later on.


New Admin Site (https://new.admin.opencerts.io/)

Hi,
Few questions on the site that our users had discovered just now:

Do we have to use the new admin site starting now?
Can we still use the old admin site? If Yes, till when?
If it's recommended to use the new site & metamask, what's GovTech's recommendation on the Metamask's password? I remember it was recommended by GovTech before that Ledger Nano's pin should be split within 2 staffs, what about the Metamask's password?

Regards,
Ryan (SP)

Hi Ryan,
You don't have to use the new admin site iht now and there is currently no end of life for the current one. The reason we created a new website is purely technical. The current website is very outdated, it was built before we created a lot of libraries around OpenAttestation and OpenCerts.
In term of features, the new website helps you to cancel a transaction, except this, it should be the same... except we dropped the ledger flow... because Metamask already supports Ledger.
Ledger is very troublesome (basically every time someone reports a problem it's related to Ledger) and Metamask has a team to take care of the integration.
There is a guide on the ledger website on how to use ledger through Metamask the safe way. Also, you can already use ledger through Metamask on the current website.
Let me know if this helps or if you need further recommendations from us.


Refactor Scaffold

fixes #407
I noticed a major structural issue with the app.
We are using nested Scaffolds in the app even though this is not allowed. This caused also caused issue with floating snackbars.
The documentation of scafolding in flutter clearly states about nested scafoldings:

The Scaffold is designed to be a top level container for a MaterialApp. This means that adding a Scaffold to each route on a Material app will provide the app with Material's basic visual layout structure.
It is typically not necessary to nest Scaffolds. For example, in a tabbed UI, where the bottomNavigationBar is a TabBar and the body is a TabBarView, you might be tempted to make each tab bar view a scaffold with a differently titled AppBar. Rather, it would be better to add a listener to the TabController that updates the AppBar

https://api.flutter.dev/flutter/material/Scaffold-class.html
Solution
I refactored the app to use a single scaffold.
This required major changes which lead to the discovery of a material design violation. Material AppBars must be shown on all screens or on none. See Principles: https://material.io/components/app-bars-top#anatomy
So in the long term we should move away from default AppBars in the "Datenschutzerklärung", "Akzeptanztellen Detailansicht" or "Karte Verifizieren" views. Instead we should a different UI/UX.
In this PR I replaced all AppBars with transparent ones.
If you test this test #409

In the APK you posted in Mattermost, I noticed that the back button is broken. I think this might be related to this PR.

In the APK you posted in Mattermost, I noticed that the back button is broken. I think this might be related to this PR.

Hm weird so far I could not reproduce this :/


Update friendly_sql.md

Just want to make it clear that the column alias cannot be used in the ON clause of the JOIN clauses. I didn't find any specific instructions in the documentation, so I'll add the description in this section.
Here are the test results for your reference:
duckdb> WITH T1 AS (
   ...> SELECT
   ...> 1 AS X,
   ...> 2 AS Y
   ...> ),
   ...> T2 AS (
   ...> SELECT
   ...> 1 AS X,
   ...> 4 AS Y
   ...> )
   ...> SELECT T1.X AS T1X, T2.X AS T2X
   ...> FROM T1 LEFT JOIN T2 ON T1.X = T2X;
Binder Error: Referenced column "T2X" not found in FROM clause!
Candidate bindings: "T2.X"
LINE 12: FROM T1 LEFT JOIN T2 ON T1.X = T2X;
                                        ^

duckdb> WITH T1 AS (
   ...> SELECT
   ...> 1 AS X,
   ...> 2 AS Y
   ...> ),
   ...> T2 AS (
   ...> SELECT
   ...> 1 AS X,
   ...> 4 AS Y
   ...> )
   ...> SELECT T1.X AS T1X, T2.X AS T2X
   ...> FROM T1, T2
   ...> where T1.X = T2X;
┌─────┬─────┐
│ T1X ┆ T2X │
╞═════╪═════╡
│   1 ┆   1 │
└─────┴─────┘

Thanks!


Test

It looks like you are attempting to push a change to the part repository, for help with deploying please start a new thread in the discussions.


Position.Timestamp wrong on iOS

This is a

[x] Bug

Which plugin does this impact:

[x] Geolocator

Version Number of Plugin: 3.0.4
Device Tested On: iPhone 6 iOS 9.3
Simulator Tested On:
Expected Behavior
Position.Timestamp should return correct UTC timestamp
Actual Behavior
Position.Timestamp returns wrong UTC time
Steps to reproduce the Behavior
Bug Location in Code
The ToDateTime() extension method produces a DateTime with an Kind.Unspecified. Calling the ToUniversalTime() method will assume Kind Local and convert the timestamp to UTC. MSDN Link
Use the static SpecifyKind method instead MSDN Link

@lothrop already created a pull request for this issue, see #266.

Did not see that... Thanks.


Stream resume support

- What I did
Support for stream resume , redesign stream methods and add parsers
- How I did it

Deprecated old stream method
added new method createStream in spec
moved stream logic from at_client_impl to StreamSender and StreamReceiver classes

- How to verify it

Run stream sender and stream receiver code in samples
To test stream resume, stop the receiver after certain bytes have been received. Call stream resume with start byte = received bytes+1

- Description for the changelog

@murali-shris Is there code here which will be useful when we revisit stream properly?


A* plugin

I wrote an A* implementation for sigma.
Repo: https://github.com/A----/sigma-pathfinding-astar
I can make a PR if you want.

@A---- I'm interested in!

You got a PR here #505. Feel free to pick it on linkurious.
Also, there's an example in the repository which isn't in the pull request.

Awesome @A---- ! I'd prefer a proper PR from you on https://github.com/Linkurious/linkurious.js to preserve the history, and I'll add you as a contributor.

Done.

Closing issue. See PR #505.


typo - extraneous word

"If a a cipher name"
to
"If a cipher name"

fixed in master and 1.0.2, thanks.


failed to run submariner on ROKS

What happened:
the submariner-routeagent pods are CrashLoopBackOff when I run submariner on ROKS (Openshift on IBM Cloud).
What you expected to happen:
Please help to check

if the errors are caused by the UDP ports 4500,5800,5000 that has not added into firewall.
what others should be configured for ROKS.

How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Submariner version (use subctl version): 0.7.0
Kubernetes version (use kubectl version): OCP 4.4.29_1525
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Network plugin and version (if this is a network-related bug):
Others:

$ subctl join --kubeconfig kubeconfig-roks broker-info.subm --clusterid roks
* broker-info.subm says broker is at: https://api.yzw.dev04.red-chesterfield.com:6443
* There are 1 labeled nodes in the cluster:
  - <IP_ADDRESS>
    Discovered network details:
        Network plugin:  Calico
        Service CIDRs:   [<IP_ADDRESS>/16]
        Cluster CIDRs:   [<IP_ADDRESS>/16]
 ✓ Discovering network details
 ✓ Validating Globalnet configurations
 ✓ Discovering multi cluster details
 ✓ Deploying the Submariner operator
 ✓ Created operator CRDs
 ✓ Created operator namespace: submariner-operator
 ✓ Created operator service account and role
 ✓ Updated the privileged SCC
 ✓ Created lighthouse service account and role
 ✓ Updated the privileged SCC
 ✓ Created Lighthouse service accounts and roles
 ✓ Deployed the operator successfully
 ✓ Creating SA for cluster
 ✓ Deploying Submariner
 ✓ Submariner is up and running

$ oc version
Client Version: 4.4.4
Server Version: 4.4.29
Kubernetes Version: v1.17.1+45f8ddb
[centos@yzw ~]$ oc get nodes -o wide
NAME            STATUS   ROLES           AGE   VERSION           INTERNAL-IP     EXTERNAL-IP     OS-IMAGE   KERNEL-VERSION               CONTAINER-RUNTIME
<IP_ADDRESS>   Ready    master,worker   72m   v1.17.1+99078c8   <IP_ADDRESS>   <IP_ADDRESS>   Red Hat    3.10.0-1160.6.1.el7.x86_64   cri-o://1.17.5-11.rhaos4.4.git7f979af.el7
<IP_ADDRESS>   Ready    master,worker   72m   v1.17.1+99078c8   <IP_ADDRESS>   <IP_ADDRESS>   Red Hat    3.10.0-1160.6.1.el7.x86_64   cri-o://1.17.5-11.rhaos4.4.git7f979af.el7
<IP_ADDRESS>     Ready    master,worker   72m   v1.17.1+99078c8   <IP_ADDRESS>     <IP_ADDRESS>   Red Hat    3.10.0-1160.6.1.el7.x86_64   cri-o://1.17.5-11.rhaos4.4.git7f979af.el7
[centos@yzw ~]$ oc get pods -n submariner-operator
NAME                                             READY   STATUS             RESTARTS   AGE
submariner-gateway-jllfq                         1/1     Running            0          14m
submariner-lighthouse-agent-854869797-gd9sd      1/1     Running            6          14m
submariner-lighthouse-coredns-599ccb9b5b-47jg4   1/1     Running            0          14m
submariner-lighthouse-coredns-599ccb9b5b-l4w6l   1/1     Running            0          14m
submariner-operator-59b8555b4d-dr8lf             1/1     Running            0          16m
submariner-routeagent-5c66t                      0/1     CrashLoopBackOff   7          14m
submariner-routeagent-lbn9l                      0/1     CrashLoopBackOff   7          14m
submariner-routeagent-whkth                      0/1     CrashLoopBackOff   7          14m
[centos@yzw ~]$ oc logs -n submariner-operator submariner-routeagent-5c66t
+ trap 'exit 1' SIGTERM SIGINT
+ SUBMARINER_VERBOSITY=2
+ '[' false == true ']'
+ DEBUG=-v=2
+ for f in iptables-save iptables
++ find_iptables_on_host iptables-save
++ chroot /host test -x /usr/sbin/iptables-save
++ echo /usr/sbin
++ return
+ location=/usr/sbin
+ '[' /usr/sbin '!=' unknown ']'
+ echo 'iptables-save is present on the host at /usr/sbin/iptables-save'
iptables-save is present on the host at /usr/sbin/iptables-save
+ sed 's!@@PATH@@!/usr/sbin!' /usr/sbin/iptables-wrapper.in
+ for f in iptables-save iptables
++ find_iptables_on_host iptables
++ chroot /host test -x /usr/sbin/iptables
++ echo /usr/sbin
++ return
+ location=/usr/sbin
+ '[' /usr/sbin '!=' unknown ']'
iptables is present on the host at /usr/sbin/iptables
+ echo 'iptables is present on the host at /usr/sbin/iptables'
+ sed 's!@@PATH@@!/usr/sbin!' /usr/sbin/iptables-wrapper.in
+ exec submariner-route-agent -v=2 -alsologtostderr
I1125 14:05:28.928518       1 main.go:47] Starting submariner-route-agent
W1125 14:05:28.928717       1 client_config.go:543] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1125 14:05:28.936363       1 route.go:195] Starting Route Controller. ClusterID: roks, localClusterCIDR: [<IP_ADDRESS>/16], localServiceCIDR: [<IP_ADDRESS>/16]
I1125 14:05:28.936427       1 route.go:199] Waiting for Endpoint informer caches to sync.
I1125 14:05:28.956448       1 route.go:736] Enqueueing endpoint for route controller {"kind":"Endpoint","apiVersion":"submariner.io/v1","metadata":{"name":"roks-submariner-cable-roks-169-60-100-23","namespace":"submariner-operator","selfLink":"/apis/submariner.io/v1/namespaces/submariner-operator/endpoints/roks-submariner-cable-roks-169-60-100-23","uid":"ee58e5aa-cd2d-4b8b-aa73-5e7803647f69","resourceVersion":"61833","generation":1,"creationTimestamp":"2020-11-25T14:01:10Z"},"spec":{"cluster_id":"roks","cable_name":"submariner-cable-roks-169-60-100-23","hostname":"kube-buv54iew0b0jvg5gvfqg-yzwtest-default-000002a6.iks.ibm","subnets":["<IP_ADDRESS>/16","<IP_ADDRESS>/16"],"private_ip":"<IP_ADDRESS>","public_ip":"<IP_ADDRESS>","nat_enabled":true,"backend":"strongswan"}}
I1125 14:05:28.973619       1 route.go:751] Enqueueing sm-route-agent-pod event, ip: <IP_ADDRESS>
I1125 14:05:28.973655       1 route.go:751] Enqueueing sm-route-agent-pod event, ip: <IP_ADDRESS>
I1125 14:05:28.973678       1 route.go:751] Enqueueing sm-route-agent-pod event, ip: <IP_ADDRESS>
I1125 14:05:29.037653       1 driver.go:37] Interface "lo" has "<IP_ADDRESS>" address
I1125 14:05:29.037696       1 driver.go:37] Interface "lo" has "<IP_ADDRESS>" address
I1125 14:05:29.037923       1 driver.go:37] Interface "eth0" has "<IP_ADDRESS>" address
I1125 14:05:29.038079       1 driver.go:37] Interface "eth1" has "<IP_ADDRESS>" address
I1125 14:05:29.038099       1 driver.go:37] Interface "eth1" has "<IP_ADDRESS>" address
I1125 14:05:29.038108       1 driver.go:37] Interface "eth1" has "<IP_ADDRESS>" address
I1125 14:05:29.038245       1 driver.go:37] Interface "vethlocal" has "<IP_ADDRESS>" address
I1125 14:05:29.038419       1 driver.go:37] Interface "tunl0" has "<IP_ADDRESS>" address
I1125 14:05:29.038439       1 driver.go:42] Found CNI Interface "tunl0" that has IP "<IP_ADDRESS>" from ClusterCIDR "<IP_ADDRESS>/16"
I1125 14:05:29.038610       1 driver.go:60] Successfully configured rp_filter to loose mode(2) on cniInterface "tunl0"
I1125 14:05:29.046457       1 iptables.go:22] Install/ensure SUBMARINER-POSTROUTING chain exists
I1125 14:05:29.062345       1 iptables.go:28] Insert SUBMARINER-POSTROUTING rule that has rules for inter-cluster traffic
I1125 14:05:29.071140       1 util.go:221] In nat table, iptables rule "-j SUBMARINER-POSTROUTING", exists at index 2.
I1125 14:05:29.088072       1 iptables.go:34] Install/ensure SUBMARINER-INPUT chain exists
I1125 14:05:29.113098       1 iptables.go:45] Allow VxLAN incoming traffic in SUBMARINER-INPUT Chain
I1125 14:05:29.121920       1 iptables.go:53] Insert rule to allow traffic over vx-submariner interface in FORWARDing Chain
I1125 14:05:29.130726       1 util.go:221] In filter table, iptables rule "-o vx-submariner -j ACCEPT", exists at index 2.
I1125 14:05:29.151189       1 iptables.go:65] Installing rule for host network to remote cluster communication: -s <IP_ADDRESS>/8 -o vx-submariner -j SNAT --to <IP_ADDRESS>
I1125 14:05:29.181045       1 route.go:257] In roks, podIP of submariner-route-agent[0] is <IP_ADDRESS>
I1125 14:05:29.181146       1 route.go:257] In roks, podIP of submariner-route-agent[1] is <IP_ADDRESS>
I1125 14:05:29.181198       1 route.go:257] In roks, podIP of submariner-route-agent[2] is <IP_ADDRESS>
I1125 14:05:29.181245       1 route.go:271] Hostname is "kube-buv54iew0b0jvg5gvfqg-yzwtest-default-000002a6.iks.ibm" and routeAgentNodeName is ""
F1125 14:05:29.181298       1 main.go:98] Error running route controller: could not get the nodeName on host "kube-buv54iew0b0jvg5gvfqg-yzwtest-default-000002a6.iks.ibm"

change to devel, and the same errors in submariner-routeagent pods.
image info:
    image: quay.io/submariner/submariner-route-agent:devel
    imageID: quay.io/submariner/submariner-route-agent@sha256:fe8556c3c288557ffbc8a191ed23fc362550a15747a54c6a62739ed61e82491f

logs:
I1126 00:35:29.091699       1 main.go:47] Starting submariner-route-agent
W1126 00:35:29.092122       1 client_config.go:543] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1126 00:35:29.103507       1 route.go:192] Starting Route Controller. ClusterID: roks, localClusterCIDR: [<IP_ADDRESS>/16], localServiceCIDR: [<IP_ADDRESS>/16]
I1126 00:35:29.103659       1 route.go:196] Waiting for Endpoint informer caches to sync.
I1126 00:35:29.142451       1 route.go:656] Enqueueing sm-route-agent-pod event, ip: <IP_ADDRESS>
I1126 00:35:29.142501       1 route.go:656] Enqueueing sm-route-agent-pod event, ip: <IP_ADDRESS>
I1126 00:35:29.142546       1 route.go:656] Enqueueing sm-route-agent-pod event, ip: <IP_ADDRESS>
I1126 00:35:29.205551       1 driver.go:37] Interface "lo" has "<IP_ADDRESS>" address
I1126 00:35:29.205713       1 driver.go:37] Interface "lo" has "<IP_ADDRESS>" address
I1126 00:35:29.205995       1 driver.go:37] Interface "eth0" has "<IP_ADDRESS>" address
I1126 00:35:29.206199       1 driver.go:37] Interface "eth1" has "<IP_ADDRESS>" address
I1126 00:35:29.206285       1 driver.go:37] Interface "eth1" has "<IP_ADDRESS>" address
I1126 00:35:29.206334       1 driver.go:37] Interface "eth1" has "<IP_ADDRESS>" address
I1126 00:35:29.206613       1 driver.go:37] Interface "vethlocal" has "<IP_ADDRESS>" address
I1126 00:35:29.206857       1 driver.go:37] Interface "tunl0" has "<IP_ADDRESS>" address
I1126 00:35:29.206955       1 driver.go:42] Found CNI Interface "tunl0" that has IP "<IP_ADDRESS>" from ClusterCIDR "<IP_ADDRESS>/16"
I1126 00:35:29.207161       1 driver.go:60] Successfully configured rp_filter to loose mode(2) on cniInterface "tunl0"
I1126 00:35:29.215226       1 iptables.go:22] Install/ensure SUBMARINER-POSTROUTING chain exists
I1126 00:35:29.232408       1 iptables.go:28] Insert SUBMARINER-POSTROUTING rule that has rules for inter-cluster traffic
I1126 00:35:29.243949       1 util.go:225] In nat table, iptables rule "-j SUBMARINER-POSTROUTING", exists at index 2.
I1126 00:35:29.267722       1 iptables.go:34] Install/ensure SUBMARINER-INPUT chain exists
I1126 00:35:29.293085       1 iptables.go:45] Allow VxLAN incoming traffic in SUBMARINER-INPUT Chain
I1126 00:35:29.305155       1 iptables.go:53] Insert rule to allow traffic over vx-submariner interface in FORWARDing Chain
I1126 00:35:29.315651       1 util.go:225] In filter table, iptables rule "-o vx-submariner -j ACCEPT", exists at index 2.
I1126 00:35:29.336858       1 iptables.go:65] Installing rule for host network to remote cluster communication: -s <IP_ADDRESS>/8 -o vx-submariner -j SNAT --to <IP_ADDRESS>
I1126 00:35:29.368211       1 route.go:254] In roks, podIP of submariner-route-agent[0] is <IP_ADDRESS>
I1126 00:35:29.368250       1 route.go:254] In roks, podIP of submariner-route-agent[1] is <IP_ADDRESS>
I1126 00:35:29.368261       1 route.go:254] In roks, podIP of submariner-route-agent[2] is <IP_ADDRESS>
I1126 00:35:29.368270       1 route.go:268] Hostname is "kube-buv54iew0b0jvg5gvfqg-yzwtest-default-000002a6.iks.ibm" and routeAgentNodeName is ""
F1126 00:35:29.368286       1 main.go:98] Error running route controller: could not get the nodeName on host "kube-buv54iew0b0jvg5gvfqg-yzwtest-default-000002a6.iks.ibm"

@zhiweiyin318 thanks for reporting the issue. As discussed over slack, lets retry this with the new route-agent-driver which uses a different mechanism to annotate a node.

it can works on ROKS using submariner devel.
thanks for supports from team.

Just for notes, the problem with route-agent mentioned in this issue is resolved via the following PR - https://github.com/submariner-io/submariner/pull/946/commits/9a384f7f80fed26ab855260b710acf72e3ba87b6


[Tracker]: Custom Notebook Images per DS Project

Description
We would like to give the user the ability to do the same flow as Admins in the Custom Notebook Images section and contain this inside their DS Project.
Target Branch
f/project-custom-images
Requirements
TBD
Itemized UX Issues

https://github.com/opendatahub-io/odh-dashboard/issues/1800

Itemized Dev Issues
TBD
Related artifacts
No response

Move to RFE - close UX issue

Closing - this will be handled by PM prioritization.


Prepare repo for semantic-release

[x] Husky

[x] Lint staged

[x] Commitlint
[x] Prettier
[x] Eslint

[x] Commitizen
[ ] Travis
[x] Semantic Release

Use https://github.com/frontity/share for reference.

:tada: This issue has been resolved in version 1.0.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Swift Language Version (SWIFT_VERSION) build setting Dependency Error Xcode 9

PromiseKit version: PromiseKit (4.4.0)
Xcode version: Version 9.0 (9A235)
CocoaPods version:  1.3.1
Carthage version: ---

Podfile:
source 'https://github.com/CocoaPods/Specs'

install! 'cocoapods', :deterministic_uuids => false

platform :ios, '10.0'
inhibit_all_warnings!
use_frameworks!
swift_version = "4.0"

target 'AcmeApp' do
    project 'AcmeApp'
    pod 'AFNetworking', '~> 2.6.3'
    pod 'Realm', '~> 2.8.3'
    pod 'Realm+JSON', :git => 'https://github.com/nunobaldaia/Realm-JSON'
    pod 'EDColor', '~> 1.0'
    pod 'FormatterKit', '~> 1.8.1'
    pod 'ObjectiveSugar', '~> 1.1'
    pod 'UICKeyChainStore', '~> 2.0'
    pod 'NSHash', '~> 1.2.0'
    pod 'OpenTok', '~> 2.11.4'
    pod 'Mantle', '~> 2.1.0'
    pod 'libextobjc', '~> 0.4'
    pod 'MBProgressHUD', '~> 1.0.0'
    pod 'SpinKit', '~> 1.1'
    pod 'Fabric', '~> 1.6.13'
    pod 'Crashlytics', '~> 3.8.6'
    pod 'EDSemver', '~> 0.3'
    pod 'TOCropViewController', '~> 2.0'
    pod 'PromiseKit', '~> 4.4.0'

    # App has it's own copy of ObjectiveSugar and all the above
    # Tests can access to Crashlytics via the app
    # that hosts the test target, but also has its own pods

    target 'UnitTests' do
        inherit! :search_paths
        pod 'Specta', '~> 1.0.4'
        pod 'Expecta', '~> 1.0.6'
        pod 'OCMock'
        pod 'OHHTTPStubs'
        pod 'Realm/Headers'
    end

end

When running a pod install and then opening the workspace in Xcode 9.0 (9A235) yields a Dependency Error on compilation resulting in a build failure.
The “Swift Language Version” (SWIFT_VERSION) build setting must be set to a supported value for targets which use Swift. This setting can be set in the build settings editor.
There is a workaround to make it compile. Under the Pods project, Targets, PromiseKit, Build Settings, Swift Language Version. Set to Swift 3.2 and recompile. This needs to be done on every pod install which is tedious.
Any help is appreciated.

This is a CocoaPods issue, here is a thread where solutions are offered: https://github.com/CocoaPods/CocoaPods/issues/6791

@mxcl Many thanks!

Long story short, add the following to your pod file:
# force the sub specs in the array below to use swift version 3.2
    post_install do |installer|
        installer.pods_project.targets.each do |target|
            if ['PromiseKit'].include? target.name
                target.build_configurations.each do |config|
                    config.build_settings['SWIFT_VERSION'] = '3.2'
                end
            end
        end
    end

In order to continue to use PromiseKit 4.x in an old Objective-C project (🙈) I had to do this:
pre_install do |installer|
  installer.analysis_result.specifications.each do |s|
    if s.name == 'PromiseKit'
      s.swift_version = '4.0'
    end
  end
end


Movie Detail Screen error handling

As a movie streaming app user,
I want to be informed of any internet connectivity or API issues when accessing the movie detail screen,
so that I understand why content might not be loading and can take appropriate action.
 Please check your network settings."
If the app's API fails to load data, a message should be displayed stating "Oops! Something went wrong. Please try again later."
The user should have the option to retry fetching data with a "Retry" button or action.
There should be an icon or visual cue accompanying the error message to quickly indicate the type of issue (e.g., a disconnected plug icon for internet issues).
If possible, previously loaded data (if any) should still be displayed or cached to allow users to access some content even if the API fails momentarily.
The rest of the UI should remain responsive and accessible even if there's an error on the movie detail screen content.
Error messages should be brief but clear, avoiding technical jargon to ensure all users understand the issue.

If this ticket is still avaialble id love to jump on this and give it a go, if thats ok?

Yes, please go on! 👌

awesome thank you! could you assign me to this issue please? <3

Hey @Kardelio
Are you still working on this user story? Because due to a misunderstanding @u3frajaeian created a PR for this user story.

Hey sorry for the delay respone!
No no im not working on this, so all good go ahead with the PR mentioned above! Thanks for reaching out though!

Done via #21


10770 DEV remove sysWebhookExternalId from systemProperties

https://github.com/Shippable/pm/issues/10770

this is done, closing.


Support cursors without goroutines

Creating something like pagination seems expensive with this way.
Say I run a query like FOR n IN nodes LIMIT 1000 RETURN 20, by using Run, all 1000 results if found in the DB are returned, and no cursor key to manage the request.
Using RunAsync means having a goroutine followCursor created everytime there is more results in the cursor, and I am forced to get everything by checking if there is more just not to have hanging goroutine(s) in the background, or close the channel(meaning I have to begin going through the cursor again).
If I had multiple clients in an application running the same query, I have to keep these goroutines even though none of them might be interested in going through the list of results.
I propose we return the result.ID and let the user(developer) decide a proper method for getting the results.

I get your point even if I'm not sure why one would like to read only the first page of the result he asked for.
The truth is I have to rewrite Arangolite. I wrote this package a long time ago and a lot of things feel dated/clumsy right now. I still like the core idea and the Runnable interface but I definitely have to rewrite a lot of the testing, ugly weird logging and api.
It would certainly keep the Run method because I have the feeling that a lot of users (me included) don't want to deal with pagination in 90% of the case. They just want to get their result and move on.
In the 10% remaining case, we should certainly not interfere and let the user decide, I totally agree.
BTW, I would be more than happy if you were interested in reviewing my PRs when the time comes.

You can try the v2.0.0 branch. It doesn't have goroutine magic anymore ;)

Yeah! :D v2.0.0 is really cool. More organized and all. Sorry I haven't had time to review some of the PRs lately.


Re-Implementing this work in smaller setting

Hi. Thank you for sharing such an awesome work and releasing the code.
I really enjoyed reading the paper! :)
I'm seeing that replicating this experiment requires a lot of compute time, so I'm wondering if this is replicable in smaller setting,
with smaller size of entities and relations. Until far, I haven't been able to find one :(
If you had any smaller-sized setting you have discovered that grokking occurs (or at least in-dist generalization) while conducting experiments, it would be really appreciated if you could share..!

maybe this may help https://github.com/ironjr/grokfast

Thanks for the reply :)
I have one more question. According to the composition.ipynb seems like the authors chose to use "test_inferred_facts" (which is "test_inferred_ood") as eval_dataset. I was wondering whether it would be more intuitive to use "test_inferred_iid" as eval_dataset, so that we can actually observe grokking phenomena while training. or was it set that way to confirm that generalization cannot happen for test_inferred_ood?
Thanks in advance!

Thanks for the interest!
Yes, you can scale down the number of entities/relations/attributes/etc. when generating the atomic and inferred facts; this could be done by changing the numbers in {composition/comparison}.ipynb. We only experimented with larger data sizes in the paper (see, e.g., Section 3.2) and the observations are consistent; I'm rather sure that the same observations should hold in smaller scales (not "too" small, of course).
Regarding the eval, yes we chose the OOD performance as the metric there (btw, on the comparison task the model does generalize in OOD) but you can feel free to change it (or maybe eval on both splits) according to your purpose.


onBlur is not called when using dropdownMode={"select"}

I see there are other issued filed regarding onBlur, but for me blur is fired correctly except when Month & Year selectors are in "select" mode and you use them to select a year. After doing that, when you select a date the control closes and onBlur is not called in this case.

+1


Massive Div Below the Image Import

Howdy, and thanks for making this cool plugin.
Problem
I'm seeing this MASSIVE div below the image when I bring it in. I've tinkered with the imageStyle prop, changing the height and width, but I can't get rid of this huge div below the image. Here's what it looks like.
Stack
"@material-ui/core": "^4.0.0-alpha.8",
"@material-ui/icons": "^4.0.0-alpha.8",
"@material-ui/lab": "^4.0.0-alpha.54",
"@material-ui/styles": "^4.0.0-alpha.8",
"material-ui-image": "^3.2.3",
"next": "^8.1.0",
"react": "^16.8.6",
"react-dom": "^16.8.6"
Forgive me if I'm missing something obvious here, and thanks!

Also, please forgive me for my newbieness if this is an easy fix.

We solved this on StackOverflow here.


Fail to parse typescript type assertion syntax

Hi, i think  the parser fails at angular bracket type assertion syntax, is this an known issue?

The error thrown is SyntaxError: Unterminated JSX contents during @babel/parser here:
https://github.com/jest-community/jest-editor-support/blob/4b34a1850adb8f880aefb5cb31377ac32e3025da/src/parsers/babel_parser.js#L25

yes, this is a known issue, fix is not hard: we are enabling "jsx" babel plugin for all file types, what we should do is only enable "jsx" for react file types.
It's a relatively simple change if anybody is interested. You can start from here

yes, this is a known issue, fix is not hard: we are enabling "jsx" babel plugin for all file types, what we should do is only enable "jsx" for react file types.
It's a relatively simple change if anybody is interested. You can start from here

hi, created PR
#72

JSX is not specific to React; it's used by many different libraries.

@ehaynes99 the current thinking is to only remove 'jsx' babel plugin from .ts files. All the other file extensions will continue to be able to use 'jsx' syntax/plugin. Does that address your concern? If not, please elaborate.
Based on these discussions (Microsoft/TypeScript#26489 and Microsoft/TypeScript#30503), typescript standard is to allow 'jsx' syntax only for .tsx files. Even though many users have asked for 'jsx' in .ts files, the request did not seem to be approved so far. So I think removing 'jsx' plugin from .ts file would be all right as it is aligned with the typescript standard.

I think it's safe to consider bracket-style type assertions and .tsx files to be mutually exclusive, as typescript itself was unable to solve for both in the same file, leading to the introduction of the as keyword.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-1-6.html#new-tsx-file-extension-and-as-operator
It's NOT safe to remove the jsx plugin for .js files. create-react-app started recommending against using the .jsx extension in 2016, and the overwhelming majority of React files are simply .js: https://github.com/facebook/create-react-app/releases/tag/v0.4.1
Finally, it's a misnomer to equate React and JSX. It's the most popular library using it, but certainly not the only one.

https://vuejs.org/v2/guide/render-function.html
https://github.com/ionic-team/stencil
https://github.com/preactjs/preact

Here is a PR that allows for distinct handling of the 3 types. I also did a bit of cleanup on the parser test.
https://github.com/jest-community/jest-editor-support/pull/75


Add a dependency exclusion for guava in org.carlspring.maven:maven-commons

Task Description
It seems that org.carlspring.maven:maven-commons depends on a vulnerable version Guava. Snyk.io is reporting the following:
Deserialization of Untrusted Data
Vulnerable module: com.google.guava:guava
Introduced through<EMAIL_ADDRESS>Detailed paths and remediation
Introduced through<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Remediation: No remediation path available.
Introduced through<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Remediation: No remediation path available.
Introduced through<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Remediation: No remediation path available.
Introduced through<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Remediation: No remediation path available.
Introduced through<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Remediation: No remediation path available.
Introduced through<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Remediation: No remediation path available.
Vulnerable functions
com.google.common.util.concurrent.AtomicDoubleArray.readObject()
Overview
com.google.guava:guava is a set of core libraries that includes new collection types (such as multimap and multiset,immutable collections, a graph library, functional types, an in-memory cache and more.
Affected versions of this package are vulnerable to Deserialization of Untrusted Data.
During deserialization, two Guava classes accept a caller-specified size parameter and eagerly allocate an array of that size:

AtomicDoubleArray (when serialized with Java serialization)
CompoundOrdering (when serialized with GWT serialization)

An attacker may be able to send a specially crafted request which with then cause the server to allocate all it's memory, without validation whether the data size is reasonable.
Tasks

[ ] Add a dependency exclusion for Guava in the strongbox-parent for the `maven-commons.
[ ] Check that the snyk.io pull request validation passes.

Acceptance Test

[ ] Building the code and running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
[ ] Building the code and running the strongbox-distribution from a zip or tar.gz still works.
[ ] Running the strongbox-web-integration-tests still run properly.

Help

Our chat
Points of contact:

@carlspring
@sbespalov
@fuss86

Hello Carl, found out about the Strongbox project and would like to help. Okay if I pick up this one?

@carlspring Okay if I pick up this one?

Yes, feel free to pick it up! :)

@carlspring: Does this still apply?

@ptirador :
I'm not 100% sure, but there's definitely quite a few things you can help us fix in the maven-common dependencies, if you're up for it.

Closing as obsolete.


early tests: adding some color / style to the docs

@TyDunn is this a draft? if so please convert it into one

@TyDunn should that be closed?


Fix ci failure

currently ci failed, fix it

It seems this issue already finish? https://circleci.com/gh/SamuraiT/tinysegmenter/10

yes


fix: only include source directories in config

When generating the default appmap.yml, make sure only source directories are included.
Fixes #690

Thanks for reviewing these changes. I pulled in the suggestions you made.
As far as edge cases go, I feel like we've already spent enough time on this, maybe more than it really merited. I think we've got the majority of the cases covered. If we run into a case where we can't derive the correct location for appmap.yml from the project, we'll fall back to creating it in the current working directory. This seems to me like it's good enough for now.


Cold/Flu - Form Access during registration period & grade period

AC

Everyone with IDIR should have access to submit forms during the OPEN period
Everyone with IDIR should have access to submit forms during the GRACE PERIOD i.e. 2 weeks after end of OPEN period
Only admin should have access to submit forms after GRACE period ends. Regular users should not be able to submit new forms. Regular users can still view their submitted forms, but they cannot edit them.

**TBD - dates open period & grace period **

Can you clarify "submit forms"? We have three actions on cold/flu forms for users:

Submit new forms
View submitted forms
Edit submitted forms

who should have what access when:
Open period June 12th - June 30 : Any one can come in and submit/edit/delete
Grace period: June 30- July 14 time for stragglers, link is removed from Career & MyHR website on June 30th, but available for users inside Digital Journey
1st report due week of July 15
Closed July 14 - only ADMIN can access or edit/add/delete

Heather has prepared copy for the message AFTER grace period when the form is CLOSED:
Worksite registration for the 2023 Cold & Flu Program was June 12-30. This form is now closed. For questions about the program, or if you are interested in registering your worksite for the current, or future programs, please email the Cold and Flu team

duplicate


[FLINK-12580][hive] Rename GenericHiveMetastoreCatalogTest to HiveCatalogGenericMetadataTest, and HiveCatalogTest to HiveCatalogHiveMetadataTest

What is the purpose of the change
This PR simply renames GenericHiveMetastoreCatalogTest to HiveCatalogGenericMetadataTest, and HiveCatalogTest to HiveCatalogHiveMetadataTest, since we unified GenericHiveMetastoreCatalog and HiveCatalog into a new HiveCatalog.
Brief change log

renames GenericHiveMetastoreCatalogTest to HiveCatalogGenericMetadataTest
renames HiveCatalogTest to HiveCatalogHiveMetadataTest*

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @xuefuz @lirui-apache @zjuwangg

thanks @xuefuz , adopted your suggestion. Merging...


symlink mib hrl output in apps `include' directories

this restores compatibility with rebar2 and erlang.mk
the fix is somewhat of a hackjob but without refactoring rebar_base_compiler pretty substantially there's no good way to pass the mib compiler the extra information it needs

+1

This PR puts the MIB include file into 2 locations, the application include and priv/mibs/include.  Is there good reason to place it into priv/mibs/include?  Perhaps @toland from PR #948 could comment on the prevalence priv/mibs/include.  If there really are projects in the wild that use priv/mibs/include, then +1 to this.
When I learned rebar3, unraveling what was going on in the _build dir was frustrating.  I write this comment thinking of the future me's who will see the 2 include instances and wonder what's going on.

i am ok with just putting the header file in include but i know nothing about mibs or how they are used so i'm inclined to just do whatever is suggested
ideally someone would write a decent mibs provider plugin and we could drop mibs support from rebar3

FWIW, I was just trying to preserve what I thought was the original author's intent. I have always put the hrl files in include, but I thought maybe the the original author knew something I don't :)
My vote would be to drop the hrl files in the project include directory and be done with it.

i've altered this pr to remove the header file in priv/mibs/include' and to just move it directly to the application's include' directory

Still +1.

Looks good!  +1.

+1


[BUG] Hooks are ignored if the class in which they are defined lives in a different assembly than the tests themselves.

The example use case here would be a class library that sets up things for multiple test projects in a consistent way so that those test projects can reference this one library and run consistently across the board. MSTest, NUnit, and xUnit all support this scenario so, hopefully, this is indeed a bug, and not the intended behaviour.
Repro Steps:

create 2 projects; project A contains some tests, while project B contains a class with some hooks (e.g. before/after test)
make sure project A references project B, and make the class containing the tests inherit from the class in project B
put some breakpoints on the hooks and observe that they never get hit

@Xen0byte Can you try on version 0.1.773 ?
I'm successfully hitting breakpoints in the hook class:

I've added a test too to verify that the hooks were hit:
https://github.com/thomhurst/TUnit/blob/main/TUnit.TestProject/BasicTests_HooksFromLibrary.cs

The above was Rider ^
And it's hitting is Visual Studio too:

Hi @thomhurst, thank you for getting back to me so quickly. After looking at your unit tests, I've done more digging and finally discovered what the problem was. I was using TUnit.Core in my library, and it turns out that I needed TUnit.Engine instead. After sorting this out, however, I'm now getting test discovery exceptions in my NUnit and xUnit projects, so at this point it's probably worth providing additional context around what I'm building so you can tell me if my potentially very specific scenario can be covered. Essentially I'm working on a library to unify unit testing across my entire organisation (probably around 300-ish developers and QA people who also write tests). This library, amongst other things, sets up the exact same before/after assembly/fixture/test hooks for MSTest, NUnit, xUnit, Reqnroll (SpecFlow successor), and now I'm trying to add TUnit to that list too, so that everybody across the organisation can get the exact same experience regardless of which unit testing framework their team might prefer, and I should probably note that it's not only about preference, but also about being able to retro-fit this library into pre-existing test projects.
So... to make a long story short, TUnit doesn't seem to play well with the others in this potentially very specific scenario.
For instance ...
    <ItemGroup>
        <PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.0-rc.1.24431.7" />
        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.0-rc.1.24431.7" />
        <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="9.0.0-rc.1.24431.7" />
        <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0-rc.1.24431.7" />
        <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="9.0.0-rc.1.24431.7" />
        <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="9.0.0-rc.1.24431.7" />
        <PackageReference Include="Microsoft.Playwright" Version="1.47.0" />
        <PackageReference Include="MSTest.TestFramework" Version="3.6.0" />
        <PackageReference Include="NUnit" Version="4.2.2" />
        <PackageReference Include="Reqnroll" Version="2.1.0" />
        <PackageReference Include="TUnit.Core" Version="0.1.773" />
        <PackageReference Include="xunit.extensibility.core" Version="2.9.0" />
    </ItemGroup>

... works fine, but the TUnit hooks don't get hit, and when I fix this by replacing ...
<PackageReference Include="TUnit.Core" Version="0.1.773" />

... with ...
<PackageReference Include="TUnit.Engine" Version="0.1.773" />

... I start getting a bunch of errors on solution build, along the lines of ...
Unable to connect to testing platform runner process 'path\to\XXX.Core.Tests.NUnit.exe'.
or
Unable to connect to testing platform runner process 'path\to\XXX.Core.Tests.xUnit.exe'.
... where these binaries represent the multiple test projects that I'm using to test the library.

Any thoughts that you might have on this would be greatly appreciated. I would very much like to promote TUnit internally as the preferred framework of choice, but I can only do that if I can integrate it successfully.

Oh actually looking at your screenshot, you have separate test projects for each framework. In the non-TUnit ones just add to their csprojs
<PropertyGroup>
        <IsTestingPlatformApplication>false</IsTestingPlatformApplication>
        <TestingPlatformDotnetTestSupport>false</TestingPlatformDotnetTestSupport>
</PropertyGroup>

Indeed, your analysis of the problem is spot on, however the suggested solution doesn't seem to be doing the trick for me. I've even tried to specify the runners explicitly, e.g. ...
    <PropertyGroup>
        <VSTestRunner>VSTest</VSTestRunner>
        <IsTestingPlatformApplication>false</IsTestingPlatformApplication>
        <TestingPlatformDotnetTestSupport>false</TestingPlatformDotnetTestSupport>
    </PropertyGroup>

... and, respectively ...
    <PropertyGroup>
        <TestingPlatformRunner>Microsoft.Testing.Platform</TestingPlatformRunner>
        <IsTestingPlatformApplication>true</IsTestingPlatformApplication>
        <TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
    </PropertyGroup>

I also tried taking a different approach, by upgrading all the other projects to Microsoft.Testing.Platform and that seems to kind of solve the problem, but all the dependencies required for the upgrade are fairly unstable, so I don't think I can do that just yet.
On top of that, after the upgrade, I keep getting warnings left and right, e.g. The type 'SelfRegisteredExtensions' in '...\XXX.Core.Tests.TUnit\obj\Debug\net9.0\AutoRegisteredExtensions.cs' conflicts with the imported type 'SelfRegisteredExtensions' in 'XXX.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. Using the type defined in '...\XXX.Core.Tests.TUnit\obj\Debug\net9.0\AutoRegisteredExtensions.cs'. or Method 'TestingPlatformEntryPoint.Main(string[])' will not be used as an entry point because a synchronous entry point 'AutoGeneratedEntryPoint.Main(string[])' was found.  which can be resolved with <GenerateTestingPlatformEntryPoint>false</GenerateTestingPlatformEntryPoint>.
I think that for the time being I'll wait until you manage to find some time for refactoring the bits that allow libraries to only require TUnit.Core and after that attempt an upgrade to Microsoft.Testing.Platform across the board again.
Many thanks for the help and the quick responses, and congratulations for making it on Nick Chapsas' vlog today. I think a lot of people are really excited about what you're building here and I can't wait to see what's coming next, and even though for this one project I'll put TUnit on the backburner for a little while until I can get everything to play nice together, TUnit is already my framework of choice and I will continue to try to break it in many interesting ways.

Thanks for the update @Xen0byte ! I'll try and work on sorting out the core package soon to hopefully unblock you. In regards to upgrading your other projects to the testing platform, this won't work. They will need new code changes to interact with the new testing protocol. NUnit and xUnit have been working on it, but I don't know if it'll work for your existing projects. I think you'll have to stick to vstest for now, but I'll try to unblock the core package problems still which I think should hopefully still sort your problems!

@Xen0byte I've just pushed out v0.1.807.
It should allow you to use TUnit.Core in your library projects and hopefully sort out your dependency issues.
Let me know if you still run into problems!

Hi @thomhurst, thank you so much! It would appear that I'm now getting the following exception on test discovery:
Process: path\to\XXX.Core.Tests.TUnit\bin\Debug\net9.0\XXX.Core.Tests.TUnit.exe, Exception: StreamJsonRpc.RemoteInvocationException: System.TypeLoadException: Could not load type 'System.Runtime.InteropServices.MemoryMarshal' from assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at <PrivateImplementationDetails>.InlineArrayAsSpan[TBuffer,TElement](TBuffer& buffer, Int32 length)
   at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.CreateInstance(IServiceProvider provider, Type instanceType, Object[] parameters)
   at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.CreateInstance[T](IServiceProvider provider, Object[] parameters)
   at TUnit.Engine.Extensions.ServiceCollectionExtensions.<>c__DisplayClass1_0.<AddTestEngineServices>b__1(IServiceProvider x)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at TUnit.Engine.Framework.TUnitTestFramework..ctor(IExtension extension, IServiceProvider frameworkServiceProvider, ITestFrameworkCapabilities capabilities)
   at TUnit.Engine.Extensions.TestApplicationBuilderExtensions.<>c__DisplayClass0_0.<AddTUnit>b__1(ITestFrameworkCapabilities capabilities, IServiceProvider serviceProvider)
   at Microsoft.Testing.Platform.Hosts.TestHostBuilder.BuildTestFrameworkAsync(TestFrameworkBuilderData testFrameworkBuilderData) in /_/src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs:line 647
   at Microsoft.Testing.Platform.Hosts.ServerTestHost.ExecuteRequestAsync(RequestArgsBase args, String method, ServiceProvider perRequestServiceProvider) in /_/src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs:line 451
   at Microsoft.Testing.Platform.Hosts.ServerTestHost.HandleRequestCoreAsync(RequestMessage message, RpcInvocationState rpcInvocationState) in /_/src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs:line 398
   at Microsoft.Testing.Platform.Hosts.ServerTestHost.HandleRequestAsync(RequestMessage request, CancellationToken serverClosing) in /_/src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs:line 312
   at StreamJsonRpc.JsonRpc.InvokeCoreAsync[TResult](RequestId id, String targetName, IReadOnlyList`1 arguments, IReadOnlyList`1 positionalArgumentDeclaredTypes, IReadOnlyDictionary`2 namedArgumentDeclaredTypes, CancellationToken cancellationToken, Boolean isParameterObject)
   at Microsoft.VisualStudio.TestWindow.Internal.RemoteAgent.TestingPlatform.RpcClient.DiscoverTestsAsync(Guid runId, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.TestWindow.Internal.RemoteAgent.TestingPlatform.Clients.TestingPlatformClient.<>c__DisplayClass24_0.<<DiscoverTestsAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.VisualStudio.Threading.ThreadingTools.WithCancellationSlow[T](Task`1 task, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.TestWindow.Internal.RemoteAgent.TestingPlatform.Clients.TestingPlatformClient.ExecuteRpcCallAsync[T](Func`1 rpcFunction, CancellationToken cancellationToken)

I'm assuming this is probably specific to the .NET 9 SDK. I'll confirm this tomorrow morning and I will also put together a minimal solution that I can share, for testing purposes.

I take it you're using the preview version of VS and have enabled testing server mode in the preview settings?

Indeed! I've disabled testing platform server mode and now I get this:
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find testhost
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting.DotnetTestHostManager.GetTestHostProcessStartInfo(IEnumerable`1 sources, IDictionary`2 environmentVariables, TestRunnerConnectionInfo connectionInfo) in /_/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs:line 432
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, String runSettings) in /_/src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs:line 226
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.InitializeDiscovery(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler, Boolean skipDefaultAdapters) in /_/src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyDiscoveryManager.cs:line 151

@Xen0byte that attached solution works fine for me. Maybe try checking your VS is up to date?

Hmm ... interesting. I use the preview distribution as my main IDE, so maybe that's the cause of the problem. I'll install the stable distribution and give it a try and report back the outcome.

Hmm ... interesting. I use the preview distribution as my main IDE, so maybe that's the cause of the problem. I'll install the stable distribution and give it a try and report back the outcome.

I don't think the stable version has the option for the new testing platform yet. So this is odd. What .net SDK version are you on?

The funny thing is that I tried it on my home computer, on the latest preview version, and with testing platform server mode enabled, and it works fine ...

... so at this point, the code itself seems to be working fine, but I still need to find out where the problem is on my work machine. I will update that to the latest preview version too, and if that doesn't sort it out I will do a settings export/import too from my work machine, and in theory that should solve the problem.
These are the SDKs I've got installed on my home machine on which the solution works ...

... and I'll check my work machine tomorrow too.
Just knowing that it works is incredibly helpful, thank you so much for finding time for refactoring the code required to use just TUnit.Core in libraries! Having this confirmation, all I need to do is put on my detective hat and figure out what the difference is.

Hi @thomhurst, I've updated my Visual Studio to the latest preview version and imported my home machine settings, and everything is running fine now, so while I don't specifically know what the problem was, it's no longer there. Many thanks for all the work you've put into unblocking me!

Brilliant, glad you got it working! Might have just been VS update issues since this is still preview I'm sure there's some stuff to iron out still