Please add a multi-language setting.

Summary of the new feature/enhancement
This setting can change PowerToys' interface language into other language.

Proposed technical implementation details (optional)
A new setting about change the interface language.
Users can change it.
Also,could you add a translation-program about translate the Powertoys into other languages?

@SteamFinder
the tracker for localization is https://github.com/microsoft/PowerToys/issues/199
Feel free to add you comments there.
Closing as diuplicate.


read property 'TYPED_ARRAY_SUPPORT' of undefined on release candidate

I was having this issue when running react-quill, it would build fine, but would not run in the browser due to: read property 'TYPED_ARRAY_SUPPORT' of undefined.
I found out this:
I added this to the webpack config file for the project (not my webpack config) , then rebuilt it and it worked.
node: {
global: false
},
More Info:
The above fix may only be required if you are using later versions of webpack or react or something. I updated all of react, node webpack ect and create a new version of this rep because I wanted to update  to es6 class class instead of createClass, change some defaults and styles, git rid of MakeFile, blah blah.
You can find it here: https://github.com/SuperheroUI/shQuill.
Thanks zenoamaro for this awesome start to a wrapper, your the best.

Thanks for the heads-up, @SuperheroUI.
I don't feel this is a ReactQuill issue specifically, however.
If you feel we should put out a warning on the README, please reopen.


Code action for induction ... using ...

The current induction code action is really nice, but it doesn't work when using a non-default induction rule.

Is there a possibility to replace it with a generic code action that works for any tactic that produces multiple named goals (induction, cases, refine with ?foo, probably more)? That would likely automatically pick up the right case name with induction … using, and be more generally useful.


[BUG] Discrepancy between number of species & native continent graph

Location of the bug
Global Indicators > Origin > Number of introduced species per year and per native continent
Describe the bug
When I select the species with Degree of establishment == "Invasive" I get just 1 species (Cernuella neglecta) but when I look at the graph I get 12 (4 in each region of origin) species in 2014 and 6 (2 in each region) in 1972. This causes me to suspect the species multiple lines with the same data in the dataset & a simple distinct should most likely fix this issue.
To Reproduce
Steps to reproduce the behavior:

Go to 'exoten-uat.inbo.be'
Click on 'Global Indicators'
Select 'Degree of establishment == "Invasive"' => this should yield only 1 species
Click on Origin
Click on Number of introduced species per year and per native continent
See error

Expected behavior
The graph displays as stacked bar chart with only 1 species per region of origin.
Screenshots

Additional context
This is version v.0.0.5

Display by default the continent of origin.
Also add dropdown to select between Continent (Europe, Africa, ...) & region (Southren Europe, Eastren Europe, ...)


Record video on pipeline slicing

(TBC)

Closing in favour of https://github.com/kedro-org/kedro-viz/issues/2081


Fix issue with pipeline barriers not being inserted

[x] Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
[ ] Updated documentation to reflect any user-facing changes - in this repository
[ ] Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

Fixes: https://github.com/vulkano-rs/vulkano/issues/1265

When converting to a CBKey I drop the list of command_ids and only use the first one. I am not sure if this is important that I retain these or not. Currently this would be the same as the current behavior.
https://github.com/vulkano-rs/vulkano/pull/1290/files#diff-4eeb919345afc97f16ffc03e0fc5843eR255
I was wondering if any other members @rukai @freesig or even the man himself @tomaka have a comment on this patch.


Domain Suggestion for Porn list

Consider adding the following. Thanks for you work.
www2.javhdporn.net/

Thanks @firebytrials!  Ping @sinfonietta.

Added @StevenBlack.

Thank you @Sinfonietta and thank you for suggesting this @firebytrials.
Closing.


quote arguments to script, use spawn_executable

Wallaby was unable so spawn the subprocess when the project path contains a space.
Additional quoting added by using the args option.

I had to touch a test checking that arguments are passed already: https://github.com/schnittchen/wallaby/blob/4acfde96a08873993648f579042ec747938066ac/test/wallaby/phantom/configure_test.exs#L18 What's missing here?

Since we're changing the way that phantom args are being added to the list of script args it would be good to have a test for it. Just something that shows if the configuration includes phantom args they end up in script_args() correctly.

Changes Unknown when pulling 0805a5d71d4b44d6d740abe5ed0280a60151152d on schnittchen:master into ** on keathley:master**.

Hold on. It's failing me locally...

Changes Unknown when pulling 30be89cc78087e53e5b47a86043c2bbe8566bbf4 on schnittchen:master into ** on keathley:master**.

This should work reproducably, but it's a bit verbose, and does not deal with the case the env value has been explicitly set to nil. Maybe not much of an issue, but should a similar thing be needed in another test I'd extract the env fiddling and use fetch_env instead.
WDYT?

LGTM. Thanks! :tada:


Porting to German

Hi guys,
is there a way to port this nice library to german?
Thanks in advance.
chris

@ChrisChross not that I know of. Link:
https://stanfordnlp.github.io/CoreNLP/human-languages.html
This library is a wrapper around the OpenIE functionality of CoreNLP:

And from this table, only english is supported for OpenIE..

Thanks for thies neat table. Also had similar question on stanza that resolved the issue.

@ChrisChross welcome!


[6.x] Unable to see a real exception message with symfony/debug ^4.4

Laravel Version: 6.7.0
PHP Version: 7.2.26
Database Driver & Version: MySQL 5.7

Description:
After updating to symfony/debug 4.4 and getting class FatalThrowableError being deprecated I'm unable to get a real exception message in runtime. As an example I had such trace:
RuntimeException: The "Symfony\Component\Debug\Exception\FatalThrowableError" class is deprecated since Symfony 4.4. in /var/www/app/modules/api/controllers/ApiController.php:286
Stack trace:
#0 [internal function]: ApiController->apiErrorHandler(16384, 'The "Symfony\\Co...', '/var/www/vendor...', 14, Array)
#1 /var/www/vendor/symfony/debug/Exception/FatalThrowableError.php(14): trigger_error('The "Symfony\\Co...', 16384)
#2 /var/www/vendor/composer/ClassLoader.php(444): include('/var/www/vendor...')
#3 /var/www/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/var/www/vendor...')
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass('Symfony\\Compone...')
#5 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(134): spl_autoload_call('Symfony\\Compone...')
#6 /var/www/LaravelApp/Http/Middleware/Localization.php(24): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))

So 6th step is middleware, but after that I got an exception which implements Throwable, so in Pipeline.php:134 Laravel generates object of FatalThrowableError. And It is impossible to track what is real reason of application being stopped, because the only thing I see is about deprecated class.
As i mentioned this problem in PR #31475 I understood it will be OK in Laravel 7, but what I have to do now?
Steps To Reproduce:
I hope you understood me even with my bad English. The only way to reproduce it - update sympfony/debug to ^4.4 and got a Throwable error in runtime.

What is your error reporting level? The fact that a silenced deprecation error is raised should not matter.

@GrahamCampbell E_ALL & ~E_DEPRECATED & ~E_STRICT

And do you have any other error handlers registered? Like flare or bugsnag?

@GrahamCampbell I'm sorry, I guess Laravel bootstraps with -1 and displaces my error reporting level. But -1 is default and this issue happens with default value, is it ok? I don't have any other handlers registered.

The error is trigger as E_USER_DEPRECATED which you usually don't want enabled in production. This is just a notice for you in development to let you know that the class will be removed in a future version. In Laravel 7 this will be remedied.


Enable region specific clearinghouse

Description
To enable multiple clearinghouses the configuration and the clearinghouse service have to be adjusted.
Configuration enhancement
The current ClearinghouseSettings need to get an IEnumerable of region specific clearinghouse settings. Those should include CountryCode, BaseAddress and all KeyVaultAuthSetting properties (even better inherit from KeyVaultAuthSettings)
The AddCustomHttpClientWithAuthentication needs to get enhanced to be able to pass the name of the client to register the token service foreach regional setting, the name should than be sett to ${typeof(ClearinghouseService).Name}{countryCode}
The registration of the settings in the AddClearinghouseService method in ClearinghouseServiceCollectionExtension needs to get enhanced to register the tokenService for each regional clearinghouse setting.
Business Logic enhancements
The method HandleClearinghouse needs to get enhanced by receiving the country code from the address of the company.  (country_alpha2code in the portal.addresses table). The countryCode should than be passed to the ClearinghouseService.
Token Service enhancement
The token service needs to be enhanced. A new method should be implemented to be able to pass a name to get the registered authorizedClient.
Clearinghouse Service enhancement
The httpClient creation needs to be adjusted to receive the region specific httpClient from the tokenService. If no region is set for the country code the default configuration should be taken.
Acceptance Criteria

[ ] Enhance the configuration of the clearinghouse
[ ] Enhance the business logic of the clearinghouse
[ ] Enhance the clearinghouse service
[ ] Enhance the token service
[ ] Enhance HttpClientExtensions
[ ] Bump framework version
[ ] Provide unit tests

@MaximilianHauer fyi


QA Documentation

Complete developer documentation to ready for review

PRIMARY FOCUS: Cosmos SDK Liquidity Module v1.2.1 Markdown docs
Liquidity Module Spec Markdown docs
Swagger HTTP API doc (2.1.1)
Liquidity Module Lite Paper (English) source and PDF
Tendermint published godoc
Liquidityd Client CLI doc Markdown

to help with EcoDev planning, can you let @tosch110 and me know what the target due date is?

Status on Friday April 9
is pool-type-id flag the same thing as pool-id? I see an opportunity for clarity.
Liquidity Module Spec Markdown docs

#201

Extensive first-round and second-round editorial work complete. I still lack a fundamental understanding of how cool the liquidity pool module is, forgive my "I'm still learning" state.

Several outstanding questions remain open in the Files Changes view.

Liquidity Pool liquidityd command-line help Client CLI Documentation QA

#212

First and second rounds complete. Excellent progress getting each flag explained, see [this comment](https://github.com/tendermint/liquidity/pull/212/files#diff-3d2dbc99856e2b9dd214922be356cf8e80279c9a6d411e38a149f600d2bc346eR45

Swagger

#206 is in draft status. Some of the required changes look so familiar, I am wondering if we shouldn't merge and open a new PR. Backstory, the original PR was merged before I looked at every detail. Let's open a new PR if needed. I see repetitive changes that we can iterate on.

godoc

#217 remind me what a godoc is and how we expose it? purpose/audience?

Thanks for the status. I will update the broken link for SwagerHub API docs today.

let's use smaller PRs with more manageable content reviews)...

This will certainly speed up the process.


look at MPI comms

Currently rsopt only uses local comms. This may be restrictive for some applications.

This is now working (with some caveats) as of 35e12f5073e2d1446525b5e4b9d0a827587220c0.

Two outstanding issues:

Resolve #58
Add documentation on how to use since this can significantly change the worker/node setup and requires different rsopt launch commands

MPI comms are now available on master as of dfe4a3b6bebfdd726d27cfd80683cb9edc192fba


small docs wording changes, removed mention of 32b Win

@whoburg, ready for review

Closes #811

closes #758 maybe?

closes #772

closes #777

Let's wait on closing #758  and #811 til we verify that anaconda works on CI

Yes it looks like we can update the docs to recommend installing cvxopt with:
conda install -c omnia cvxopt
That way there is no need for python (x,y).

do we really need omnia?

Yes you need the omnia, see below:
(C:\Anaconda2) C:\Users\acdl>conda install cvxopt
Fetching package metadata .........
Solving package specifications: .

PackageNotFoundError: Package not found: '' Package missing in current win-64 channels:
  - cvxopt

You can search for packages on anaconda.org with

    anaconda search -t conda cvxopt

(C:\Anaconda2) C:\Users\acdl>conda install -c omnia cvxopt
Fetching package metadata ...........
Solving package specifications: ..........

Package plan for installation in environment C:\Anaconda2:

The following NEW packages will be INSTALLED:

    cvxopt: 1.1.8-py27_0 omnia

Proceed ([y]/n)? y

Linking packages ...
[      COMPLETE      ]|##################################################| 100%

(C:\Anaconda2) C:\Users\acdl>

Done!

err, @galbramc, windows7x64 seems to have suffered an error, since this commit only touches .rst files...

retest this please

Yeah looks like it lost the connection. It happens from time to time, and I don't know why... It's not regular enough for me to diagnose.

ok, cool! I wasn't sure how to interpret that error, but now I'll know. :)


Upgrade Zookeeper version to 3.5.x  to prevent UnresolvedAddressException in Java14

An UnresolvedAddressException is thrown if the Zookeeper registry  is used under the enviroment of Java14.
Because the lower version of Zookeeper is not compatible with the Java14 unresolved address format.
The problem is fixed in version 3.5.x of Zookeeper, I suggest upgrade the Zookeeper version of Dubbo to 3.5.x

the lower version of getHostString() method for zk
https://github.com/apache/zookeeper/blob/2d71af4dbe22557fda74f9a9b4309b15a7487f03/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java#L135-L138

jdk rewrite unresolved address format
https://github.com/openjdk/jdk/blob/9a7dcdcdbad34e061a8988287fe691abfd4df305/src/java.base/share/classes/java/net/InetSocketAddress.java#L107-L116

[x] I have searched the issues of this repository and believe that this is not a duplicate.

[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.8 release
Operating System version: macOS 10.13.6
Java version: jdk14.0.1

Steps to reproduce this issue
run the demo
Expected Result
the normal run
Actual Result
throw java.nio.channels.UnresolvedAddressException
If there is an exception, please attach the exception trace:
[17/09/20 10:30:53:424 CST] main-SendThread(<IP_ADDRESS>:2181)  WARN zookeeper.ClientCnxn: Session 0x0 for server <IP_ADDRESS>/<unresolved>:2181, unexpected error, closing socket connection and attempting reconnect
java.nio.channels.UnresolvedAddressException
	at java.base/sun.nio.ch.Net.checkAddress(Net.java:139)
	at java.base/sun.nio.ch.SocketChannelImpl.checkRemote(SocketChannelImpl.java:727)
	at java.base/sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:741)
	at org.apache.zookeeper.ClientCnxnSocketNIO.registerAndConnect(ClientCnxnSocketNIO.java:277)
	at org.apache.zookeeper.ClientCnxnSocketNIO.connect(ClientCnxnSocketNIO.java:287)
	at org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:1021)
	at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1064)

3.4.x and 3.5.x mixing may cause incompatibility issues：
https://stackoverflow.com/a/61630617

3.4.x clients compatible with 3.5.x server
3.4.x and 3.5.x clients can be mixed on 3.5 server
3.5.x clients incompatible with 3.4 server

I encountered the same problem on the dubbo 3.0 branch.
Given that zookeeper 3.4.x has stopped updating, It makes sense to upgrade to 3.5.x

Any progress?

Dubbo already suuport zookeeper with curator 5. You can directly add curator5 dependencies to your project and Dubbo will use curator 5 first.


Determine how citation is generated for DMPs and why it differs within tool

We have had numerous people reach out to ask about how the citation for a DMP is generated, as it often isn't what people expect.  The difficulty lies in the potential non-overlap between the research Project Contributors and the DMP Collaborators, and people have different opinions on who should be an author on the DMP.
Without making a determination of what the authorship should be for now, we have the following issues to gather information on:

Some published DMPs don't list a citation at all, like this one: https://dmphub.uc3prd.cdlib.net/dmps/10.48321/D14F38aa13
Some published DMPs have unclear citations, such as excluding the primary contact, like this one: https://doi.org/10.48321/D1B581751F or excluding the owner like this one: https://doi.org/10.48321/D1A44DD570
DMPs have a different citation showing on the plan page (the cases I saw just showed one author on the Finalize tab) than on the DMP Hub.  Can't find a screenshot at this moment.
One user reports that changing information on contributors can break the citation.  Direct quote: "In trying out some changes to the back end, I edited some of the information for the other contributors which led to one now having a blank ORCID link (I never entered any ORCID information for them on the back end), the link to “Investigation” no longer exists for them (it never existed for Crimaldi), and their name no longer appears in the citation. Additionally, it appears that you can add information into affiliation that breaks how it displays if you don’t specifically choose the option from the pop-up menu."
Sometimes the format splits Data Management || Plan onto a new line

This ticket is not to make any changes, just investigate these issues.
Resolving this ticket means:

We understand how citations are generated
We can give users instructions on how to enter people in roles/slots to become authors
We know what other tickets we need to write to resolve any identified bugs (as opposed to just imperfect options that we'll fix in the rebuild)

Under our new categories I would call this a P2 because it's a minor functionality but affects all (published) users and the wider scientific community.  We should at least be able to tell people how the citation is being generated even if each aspect of the fix is not a P2.

Both the citation on the plan page within the DMP Tool and the DMP ID landing page, use the JSON metadata stored in the DMP Hub (DynamoDB table).
The citation on the plan page uses this logic (where hash is the DMP record stored I the DMPHub):
    hash = hash.fetch('dmp', {})
    authors = hash.fetch('contributor', []).map { |contrib| contrib['name'] }.join(', ')
    authors = hash.fetch('contact', {})['name'] unless authors.present?

    pub_year = Time.parse(hash.fetch('modified', hash['created']))&.strftime('%Y')
    app_name = ApplicationService.application_name

    "#{authors}. (#{pub_year}). \"#{hash['title']}\" [Data Management Plan]. #{app_name}. #{dmp_id}"

So, the plan page will list all contributors OR the owner/creator of the DMP if no contributors exist.
The DMP ID landing page logic looks like this (where investigators is an array of all PI name):
        {investigators.length > 0 &&

When citing this DMP use:

              {investigators}
              ({year})
              "{title}"
              [Data Management Plan]
              {dmptoolName}
              <Link href={dmp_id}/>

        }

So the landing page displays all of the PIs OR nothing if there are no PIs.
When a change is made in the DMP Tool UI, a background job gets kicked off to update the DMP ID record in the DMP Hub. There is a slight delay before it is synced up. I'm not sure about why it would be losing data as the user described in their comment. It's possible that there is a bug in synchronization process, but this is the first time I'm hearing of it and I'm not able to replicate it. I'm also not sure what the person who reported these issues meant by the "back end" in their comment: "In trying out some changes to the back end".
At the very least I guess we should make them the same.

My suggestion for current system, IF it's an easy change:

Citation is all Project Contributors, not just PIs.
If there are no Project Contributors, then just the owner
Finalize page and Landing page use same logic
Order the PIs first, then Data Manager, then Project Administration, then Other
Edit text on Collaborators page to say for Project Contributors "These are the pe

In future:

Allow people to check boxes next to both Project Contributors and DMP Collaborators to decide who is included on the citation
Also allow them to pick the order of it
Consider given guidance on how to determine the order.


[🧹 CHORE]: Beanstalk jobs driver errors log

No duplicates 🥲.

[X] I have searched for a similar issue.

What should be improved or cleaned up?
A communication error written by the beanstalk driver interferes with the perception of logs and their processing, I would like to see the possibility of configuring or simply filtering errors of this type

Hey @SerhiiMova 👋
Planned for v2023.3.8, release date: 14.12.2023.


Add payjoin support

Mostly copied from https://github.com/payjoin/rust-payjoin/blob/master/payjoin/src/uri.rs
cc @DanGould

utACK, I read line by line in the changes. LGTM


Create theatre-of-blood-stats

Provides a more detailed break down of the rooms in theatre of blood by showing time splits and damage dealt

Your runelite-plugin.properties's plugins variable must include the package.
plugins=hsj.external.theatreofbloodstats.TheatreOfBloodStatsPlugin


[MB] Fix Normalizer class not found on scoped Monorepo builder

Ref https://github.com/symplify/symplify/pull/4385?notification_referrer_id=NT_kwDOAAcDgLE0MzIxMDQ5NzIzOjQ1OTY0OA#issuecomment-1235294375

Feel free to merge when ready :+1:

Cool, that's better! :)


Extract app name to config

In preparation for OWF / to make re-branding easier, this PR extracts hardcoded instances of the LCW name and web site into config.
Also, adds a small section in the README on where the config files live.

I'm guessing we should have this pass all checks before review?

I'm guessing we should have this pass all checks before review?

Great question. No, we usually review in parallel to the build jobs.


babel plugin: attempt to fix windows relative bug

Nice!!
Glad you figured it out!
Did you forget to strip out your console.warn lines?


Update README.md

https://dumps.wikimedia.org/jawiki/latest/jawiki-latest-pages-articles.xml.bz2 is huge so I wanted to avoid saving it.
Dan the Passer-By

Thank you for the fix!
Personally I prefer downloading the whole file but I think it's a good idea to make it clear that we can run the script without downloading it.


Improve text contrast ratios

WebAIM's most stringent requirement (Guideline 1.4.6) requires a contrast ratio of at least 7:1. The nav bar fails this requirement.

Improved by 4d5a690af19a824b3c0c771493ac626ade072e6d. Still need to prove its sufficiency.


⚠ ClamAV has degraded performance

In 577e121, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 247 ms

Resolved: ClamAV performance has improved in 8792a62.


Fix capitalization in source-url

We're adding Travis badgest to modules.perl6.org and I noticed incorrect capitalization makes the badge lookup for this distro fail because travis can't find the distro.

Thanks!


Problem with comments in the config file

I have found that any comment lines in the config file cause the rest of processing to be skipped.
If the config file contains no comment lines (i.e. lines starting with a hash symbol) then the deployment proceeds successfully. However, if a comment line is in the file then only lines before the comment line are processed, at which point the line "Validation of config file completed." is written out but then nothing further happens.

Thanks @dfindlay, for letting me know. Let me double-check that.

This is fixed now in ver.0.13


Add @mfpierre as Trusted Collaborator

Hi,
In the same fashion as https://github.com/helm/charts/issues/13120 I'm also working at Datadog and one of the owners of the Datadog chart:
https://github.com/helm/charts/blob/a5b16939ebc25a09200c36d2feb37e69674c907a/stable/datadog/OWNERS#L11
An would like to be added as a trusted collaborator to speed up the development on the Datadog Chart.
Thanks! 🙇
Sponsor: @hkaj

👍

Hey @mattfarina could you have a look at this one ? 🙏 (similar to #13120)

Invitation sent. Sorry for the delay.


How can I show the custom view in the center of the screen after side menu is opened?

New Issue Checklist

I have read the guidelines for contributing and I understand:

[x] My issue is happening in the latest version of SideMenu.
[x] My issue was not solved in the README.
[x] My issue can not be answered on stackoverflow.com.
[x] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[x] My issue is reproducible in the demo project.

Issue Description

I have implemented this SideMenu in my iPad app. I have set  the present mode as SideInOut as followings:
SideMenuManager.default.menuPresentMode = .viewSlideInOut
When I tap the cell item in side menu, I am going to display the MBProgressHUD in center of the iPad screen.
So I have set the view as followings:
let view = sideMenu.view
let loadingHud = MBProgressHUD.showAdded(to: view, animated: true)
As a result, the MBProgressHud is displayed in left side of the screen because the side menu is placed in the left side.
I am not sure how can I set the view to be showed  the progressHud.
Let me know the solution
Thanks

It's up to you to find the solution. SideMenu is not guaranteed to work with every other library.

If I am going to show the ViewController as modally in the center of the screen, how can I get the container view after side menu is opend?

I noticed that you app is not working whenever change the orientation.

It works as expected with the Example project.


Integrate toolbox extension into GIL core

Some of the IO support code in boost/gil/io/ depends on the toolbox extension (i.e., includes boost/gil/extension/toolbox/*.hpp).
Break out the relevant bits from the toolbox extension and integrate them into the GIL core library itself.

It is a good idea.

@stefanseefeld Since,

is not assigned to The Grand Merge
no work has been done for this so far, AFAIK
I'm removing it from Boost 1.68 and postponing.

Feel free to update if you think otherwise.

While cleaning the headers lately, I've added some TODO comments about dependency on the toolbox and dynamic_image extensions.


Adding an annotation to a cron via ui also adds a label with the same name

Summary

Add a cron workflow
Go to the Workflow Metadata tab of that cron workflow in the ui
Enter an annotation name and value  eg  test: issue and hit enter

issue: both the annotations and the labels fields are populated. The manifest is updated to reflect this.
Diagnostics
What Kubernetes provider are you using? EKS 1.19
What version of Argo Workflows are you running?  3.0 (GA)

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

I was unable to reproduce this issue.

Agreed. This does seem to have fixed itself in 3.0.1


STORM-1966 Expand metric having Map type as value into multiple metrics based on entries

PR for 1.x: #1561

populate metric before applying filter so that filter can play with populated metrics
add relevant configs to metrics consumer registration and describe them to storm.config.yaml
add unit test

Please refer https://issues.apache.org/jira/browse/STORM-1966 for more details.

Thanks for thoughtful review, @abhishekagarwal87 ! Addressed your review comments.

Minor nit regarding variable name. Other than that +1.
Please make sure to squash commits before you merge :)

Addressed and squashed.

Thanks @HeartSaVioR . Looks good to me

@harshach Could you take a look?

+1

@HeartSaVioR looks good to me. Just a minor nitpick +1 after that.

@harshach Addressed.
I found RAT issue again (my bad) and fixed it.
Btw, I didn't address review comments to PR for 1.x-branch. Once I'm done I'll mention reviewers  to review from PR for 1.x-branch as well.

Thanks @HeartSaVioR . +1.

I also addressed review comments and also RAT issue to 1.x PR.
Please take a look at #1561 as well. Thanks!


cluster_deploy_operator: fix typo in the subscription name

Note that this typo did not affect the good behavior of the role, as
long as no two operators were deployed in the same namespace.
/cc @sagidayan

Thanks @kpouget !
/ok-to-test

/approve
/lgtm


Display rtd.yml in build output

This works similiarly to our handling of conf.py, for transparency in the build.

Saving this for a less hacky solution.


reset progress bar when cancel button is hit

I added a reset value to the progress bar when the cancel button is clicked

I reverted but still get lots of changes

Only the changes to the first file is needed, please revert the others.

I had problems so I deleted my repo and started again from scratch


Automation: BMC dump TCs fails - But manually able to create and delete

Have able to create dump successfully and delete as well manually.
But in automation found it failing always both todays and yesterday master.

Full Name:
Tests.Test Bmc Dump.Verify User Initiated BMC Dump

Create user initiated BMC dump and verify dump entry for it.

Verify_User_Initiated_Dump

20171006 10:15:59.471 / 20171006 10:21:36.516 / 00:05:37.045

FAIL (critical)

Keyword 'Check Dump Existence' failed after retrying for 3 minutes. The last error was: 404 != 200

Have passed the jenkins details to Rahul.


Trace graph can't display when click the trace what has multiple global trace id

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Bug Description
Screen snapshot:

The trace data look like this:
{"data":{"queryBasicTraces":{"traces":[{"key":"2.23.15204770137120006","operationName":"org.apache.skywalking.test.kafka.MessageConsumer.consumer()","duration":60,"start":"1520477013712","isError":false,"traceIds":["3.84.15204769998380001","3.82.15204769989850001","3.77.15204769964800001","3.80.15204769980050001"]}],"total":1}}}

The 3.82.15204769989850001 look like this:
{"data":{"queryTrace":{"spans":[{"traceId":"3.84.15204769998380001","segmentId":"2.23.15204770137120006","spanId":0,"parentSpanId":-1,"refs":[],"applicationCode":"kafka-consumer","startTime":1520477013712,"endTime":1520477013772,"operationName":"org.apache.skywalking.test.kafka.MessageConsumer.consumer()","type":"Local","peer":"","component":"","isError":false,"layer":"Unknown","tags":[],"logs":[]},{"traceId":"3.84.15204769998380001","segmentId":"3.84.15204769998380000","spanId":0,"parentSpanId":-1,"refs":[],"applicationCode":"kafka-producer","startTime":1520476999839,"endTime":1520476999861,"operationName":"/sendMessage/{count}","type":"Entry","peer":"","component":"SpringMVC","isError":false,"layer":"Http","tags":[{"key":"url","value":"http://localhost:18080/sendMessage/1"},{"key":"http.method","value":"GET"}],"logs":[]},{"traceId":"3.84.15204769998380001","segmentId":"3.84.15204769998380000","spanId":1,"parentSpanId":0,"refs":[],"applicationCode":"kafka-producer","startTime":1520476999846,"endTime":1520476999850,"operationName":"Kafka/Trace-topic-1/Producer","type":"Exit","peer":"<IP_ADDRESS>:9092","component":"Kafka","isError":false,"layer":"MQ","tags":[{"key":"mq.broker","value":"<IP_ADDRESS>:9092"},{"key":"mq.topic","value":"Trace-topic-1"}],"logs":[]},{"traceId":"3.84.15204769998380001","segmentId":"2.23.15204770137120006","spanId":1,"parentSpanId":0,"refs":[{"traceId":"3.84.15204769998380001","parentSegmentId":"3.77.15204769964790000","parentSpanId":1,"type":"CROSS_PROCESS"},{"traceId":"3.84.15204769998380001","parentSegmentId":"3.80.15204769980050000","parentSpanId":1,"type":"CROSS_PROCESS"},{"traceId":"3.84.15204769998380001","parentSegmentId":"3.82.15204769989850000","parentSpanId":1,"type":"CROSS_PROCESS"},{"traceId":"3.84.15204769998380001","parentSegmentId":"3.84.15204769998380000","parentSpanId":1,"type":"CROSS_PROCESS"}],"applicationCode":"kafka-consumer","startTime":1520477013719,"endTime":1520477013759,"operationName":"Kafka/Trace-topic-1/Consumer","type":"Entry","peer":"","component":"Kafka","isError":false,"layer":"MQ","tags":[{"key":"mq.broker","value":"<IP_ADDRESS>:9092"},{"key":"mq.topic","value":"Trace-topic-1"}],"logs":[]}]}}}

Related to https://github.com/apache/incubator-skywalking/issues/1097


Add license information to gemspec!

Dupe of #120, #115, #90, partial #109 and #72

@reiz thank you for your pull-request. It was merged as https://github.com/rack-test/rack-test/commit/fed7b5d6b6143847401870ec7d441806d00fb903 .


[ bug Report ] TR3 Bosses can Explode With Grenades (updated)

TombEngine version
v1.5.
Tomb Editor version
v1.7.2
Describe the bug
If enough grenades are fired at Tony: he will explode. This does not happen in the original and seems like a mistake.
To Reproduce
Simply fire enough grenades at Tony in succession and he will explode.
Expected Behaviour
The grenades should damage him but not explode him.
Additional Content
Please see here for a video of the issue : https://discord.com/channels/1072511394735464498/1072569001986773023/1302742933497184398
Minimal reproduction project
Download here: https://cdn.discordapp.com/attachments/1072569001986773023/1302757575326044181/1451_Tony_Boss_Explode.zip?ex=6729470a&is=6727f58a&hm=597309d85539145b2553d18e79807371cf16c5dd0edbd04dad5d876992d8ac5c&

On further inspection : both Tony and Willard are able to be blown up by explosive weapons. This is applicable to Tony and Sophia with OCB 0.


Allow implicitly cloning arguments instead of referencing

I just discovered this great library yesterday and I think it's fantastic!
Here is a new improvement for it that will allow the user to be more productive
by not having to deal with references all the time.
This PR allow the user to write types that are not references. If they are not,
the value will be cloned at the beginning of the function.
Properties in Yew should ideally be cheap-to-clone because they are passed from
parent to children by cloning. So it is safe to assume that the user will want
the actual types most of the time instead of references.
Here is an example of its usage:
use yew_autoprops::autoprops_component;
use yew::prelude::*;

#[autoprops_component]
fn CoolComponent( bool1: &bool, bool2: bool, int1: &i8, int2: i8) -> Html {
    if *bool1 {
    }

    if bool2 {
    }

    if int1 > &5 {
    }

    if int2 > 5 {
    }

    html! {
        <div>
        </div>
    }
}

Thank you for both contributions, they seem very useful! I fixed two of the failing tests.
But this PR doesn't seem to work with generics, see the third failing test. I'll be able to look into this only a bit later – I'm completely out of context...
Since you're interested in this project, and have an eye on maybe getting it into yew, I invited you as a maintainer so you can get the CI to run automatically. It goes without saying that this comes with no expectations from you, it's purely for your own convenience if you'd ever want to contribute more.

But this PR doesn't seem to work with generics, see the third failing test. I'll be able to look into this only a bit later – I'm completely out of context...

no worry, its not your job to fix my bugs lol

Released as 0.3.0. Maybe update the README too if you have the time ;-)


Securing authentication across the public internet

Short version: Should we add HMAC signatures when passing authenticated requests upstream?
I've been running oauth2_proxy to implement single sign-on across different apps on different domains for some time, with great results. However, all of those different apps and domains are actually running on the same host.
Recently my team tried to use the same mechanism for an app running on a different host, across the public internet, and hit the thorny problem of being able to access the app both through the oauth2_proxy and when bypassing it completely. It just hit me that adding optional HMAC signatures to authenticated requests might do the trick. It would be up to the upstream application to check the signatures, but that's easy to implement.
Thoughts? (I'm already poking around the code.)

Generally ++ on this. This need doesn't come up often but it would be useful.
I'd love to hear your thoughts on details of what signing mechanism would work. Also, i could be interesting/useful in some cases if there was a separate open source project with a binary that received said secure requests and did the validation passing on only validated requests.
(A long time ago, #1 sort started to tackle this problem, but the specific need driving that work eventually disappeared)

Cool! So what I'm thinking is pretty straightforward: Once the proxy has authenticated a request, it'll do a SHA1 HMAC of the raw request body and add the result as a header, a la GitHub webhooks. Then it's up to the client to store the shared key and check the signature of incoming requests. There could be a "default" secret key, and a mechanism to configure per-host/upstream secret keys if desired.
FWIW, I got the idea this weekend after implementing the github-webhook-validator npm that I'm using to add authentication to 18F Pages webhooks in 18F/pages-server#5.
Regarding the proxy to multiplex secured requests, heh, yeah, I thought about that, too... In our case, it wouldn't help, because our app infrastructure doesn't allow for restriction of incoming requests from a trusted IP, at least no obvious way. But it might be a useful tool when you can deploy to a private subnet, I agree.
I'll get cracking!

In the webhook case it's the body of the message you care about authenticating. Here, it could be the body on a POST, but it's more the authorization state, so the host, URL and headers (ie: cookies, passed access token, auth'd email address). That leads me to think we need an explicit list of things that are part of the HMAC.

@jehiah You beat me to the punch... :-)
So I just realized that GET requests won't typically have a request body. Inspired by http://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html, I'm proposing the signature be a hash of something like: HTTP-Verb + "\n" + Date + "\n" + URI + GAP-Auth header.
How's that sound?

Actually this is what I'm now using, after some thought and experimentation, with each value separated by a newline:

HTTP method
Content-Md5
Content-Type
Date
Gap-Auth
URI
Body

Any values not in the original request are represented by the empty string. Sound OK?

Oh right... Cookies and the passed-through auth token... Not sure how critical the host is, though, but perhaps that's my ignorance showing.

So here's the new package with the signature logic in my 18F/oauth2_proxy#hmac-signatures branch: https://github.com/bitly/oauth2_proxy/compare/master...18F:hmac-signatures?expand=1
How does that look so far? It's actually pretty straightforward stuff; it's easy to update the header set if we decide that what's there isn't what we actually want.
I'm now working on setting up the configuration and hooking it into the proxy. With the code in a dedicated package like this, I'm hoping that will make it easy for go programs to just import and use it, and I may add a basic "proxy proxy", too, dedicated to passing through signed requests, as you'd mentioned earlier, @jehiah.


Update README.md Install Section

fix #55 #50

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Releases: add 0.16.2

Adds release notes and a short blog post.  Previews:

Blog: http://dg0.dtrt.org/en/2018/07/27/release-0.16.2/
Release notes: http://dg0.dtrt.org/en/releases/0.16.2/
Download page: http://dg0.dtrt.org/en/download/

Todo:

[x] Update files to correct dates for release:

_releases/0.16.2.md - change date in YAML header
cd _posts/en/posts/ ; rename 's/.*release/'$(date -u -I)'-release/' _posts/en/posts/2018-07-27-release-0.16.2.md ; git add .

[x] Add magnet URI for torrent to _releases/0.16.2.md
[x] If release notes change, update the release file with the changes

Note: this PR is expected to fail Travis CI as it expects the binaries to be in /bin/, which they're not yet.  The CI should pass once if Travis is restarted after the binaries are in their final location.

Torrent downloads now, tests passed.  I'll add the magnet from #585.
This needs a ACK for its quick blog post before it should be merged.

@harding I can't find a blog post in the two files you edited.

  I never git added it.  It's in commit https://github.com/bitcoin-core/bitcoincore.org/pull/582/commits/06e0c67f3e5677a373277d3a674b1c80a66e65fd ; I'm going to squash this all and force push.


Generate form from Model with Array and Objects

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[x] support request

Current behavior
I am trying to generate the form using a Model. But my Model has fields that are of another Model type and also has fields that are same Model type. I'm having challenges in going beyond 1 level of array.
Eg:
`export class Variant {
year: number;
color?: string;
}
export class Car {
brand: string;
model: string;
variants: Variant[];
similar: Car[];
}`
Now to generate something that is formly friendly I would have to do a little initialization and conversion like in the stackblitz here: https://angular-p5rqay-rlf4zh.stackblitz.io
I am having trouble in getting the objects recursively and generate the form for child objects in the similar cars object.
Expected behavior
This is not a bug. It is rather a question or support request if something like this has been achieved or can be achieved easily.
Minimal reproduction of the problem with instructions
Example: https://angular-p5rqay-rlf4zh.stackblitz.io
UI Material: https://stackblitz.com/edit/ngx-formly-ui-material
What is the motivation / use case for changing the behavior?
If something like this can be achieved, it will be possible to generate fields based on the model, optional fields can be honored and type can be converted to some extent.
Please tell us about your environment:
MacOS HighSeierra, VSCode

Angular version: 7.xx

Browser: [all | Chrome XX |] Only tried in Chrome, should not matter for this case

Language: TypeScript | ES5]

that's on the plan :) but not soon!
I'll try to provide you an example when time allows, we've done a similar feature in json-schema for a recursive array: https://angular-12fcs4.stackblitz.io/

oh, okay. good to know that it is on the plan. about the example, is it the same as the json-schema link you shared or is there anything else?
if there is a branch somewhere or a work in progress, I could help bringing it to a certain level if I can. I don't know what you think about it. But I'm not 100% that I can actually make a difference.

here is an example of recursive repeat type: https://stackblitz.com/edit/angular-rhagg9 which you may use.

is it the same as the json-schema link you shared or is there anything else?

yes, part of https://ngx-formly.github.io/ngx-formly/examples/advanced/json-schema

if there is a branch somewhere or a work in progress

right now still an experimental feature which is only implemented for json-schema extension.

is it possible to do recursion with FieldGroup instead? Have tried but seems to trigger: Maximum call stack size exceeded.

fill a new issue with an example of what you want to achieve.

Created: https://github.com/ngx-formly/ngx-formly/issues/1882


'A game has not been started yet'

I am unable to run a game. It opens the black sc2 window as if it is loading the client, and then it closes after a couple seconds and I get this:
INFO:sc2.protocol:Client status changed to Status.launched (was None)
INFO:sc2.controller:Creating new game
INFO:sc2.controller:Map:     BelShirVestigeLE
INFO:sc2.controller:Players: Bot(Race.Zerg, <main.ZergBot object at 0x000001AB22610198>), Computer(Race.Terran, Difficulty.Easy)
INFO:sc2.protocol:Client status changed to Status.init_game (was Status.launched)
INFO:sc2.protocol:Client status changed to Status.launched (was None)
INFO:root:Player id: 0
INFO:sc2.sc2process:kill_switch: Process cleanup
INFO:sc2.sc2process:Cleaning up...
Traceback (most recent call last):
File "D:/Games/StarCraft II/ai/sc2ai.py", line 14, in
], realtime=True)
File "C:\Users\Bobby\Anaconda3\lib\site-packages\sc2\main.py", line 187, in run_game
_host_game(map_settings, players, **kwargs)
File "C:\Users\Bobby\Anaconda3\lib\asyncio\base_events.py", line 468, in run_until_complete
return future.result()
INFO:sc2.sc2process:Cleanup complete
File "C:\Users\Bobby\Anaconda3\lib\site-packages\sc2\main.py", line 115, in _host_game
result = await _play_game(players[0], client, realtime, portconfig, step_time_limit, game_time_limit)
File "C:\Users\Bobby\Anaconda3\lib\site-packages\sc2\main.py", line 87, in _play_game
result = await _play_game_ai(client, player_id, player.ai, realtime, step_time_limit, game_time_limit)
File "C:\Users\Bobby\Anaconda3\lib\site-packages\sc2\main.py", line 29, in _play_game_ai
game_data = await client.get_game_data()
File "C:\Users\Bobby\Anaconda3\lib\site-packages\sc2\client.py", line 110, in get_game_data
upgrade_id=True
File "C:\Users\Bobby\Anaconda3\lib\site-packages\sc2\protocol.py", line 56, in _execute
raise ProtocolError(f"{response.error}")
sc2.protocol.ProtocolError: ['A game has not been started yet']

Same as #65

Duplicate of #65. Please comment here if that doesn't work.


Strip any additional ror pkgs

@bparees got rid also of the RAILS_ENV envar, which we might want to add to the rails-ex json ?

yeah that's a good idea.
thanks for cleaning this up @jhadvig, let's merge it once the dust settles on 3.0.1.

Here is the PR for the rails-ex https://github.com/openshift/rails-ex/pull/35

LGTM (@jhadvig explained me that we are doing this to keep the ruby image clean and prepare some space for ror image in future)


No support for reqex on whole server's response body

From @mchmielarz on February 24, 2016 20:42
It would be quite useful to have possibility to do regular expression on whole response body returning for server side. Here is my case:
io.codearte.accurest.dsl.GroovyDsl.make {
    request {
        method('POST')
        url(PATH)
        headers {
            header("Content-Type": FORM_CONTENT_TYPE)
        }
        body(
                """field=${value(client("something"), server("else"))}"""
        )
    }
    response {
        status 400
        body (value(client("Processing failed with 400 status."), server(regex(".*400.*"))))
    }
}

I want to return 400 in a body of the client stub. And that's ok actually. On the other hand for server tests I'm able to generate such status by sending malformed request. In this case body will contain some standard HTML with 400 added somewhere in between. Regex in such case will free me from pasting whole HTML in stub definition.
Copied from original issue: Codearte/accurest#199

As a workaround you can write that piece of functionality in the code and use this https://github.com/Codearte/accurest/wiki/3.-Contract-DSL#executing-custom-methods-on-server-side

From @mchmielarz on March 4, 2016 21:53
The workaround didn't worked.

Now you can do it via test matchers. You could do a test matcher with $ regex and manually provide a regular expression


Release azure-cli-network 0.1.2rc1

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Release of 'azure-cli-network' with version '0.1.2rc1' successful. View at https://pypi.python.org/pypi/azure-cli-network/0.1.2rc1.


Set up necessary account vars and add it to production environment

Blocked by #26

I think this can be closed since we're currently deploying to production. All vars are located in GitHub.


Test wheel

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Current working directory is not a Cordova-based project

Hello,
I get this error while running :
ionic plugin add com-sarriaroman-photoviewer
Do you have any idea?
(I already did npm uninstall -g ionic and npm install -g ionic)
Thanks!

@cissecedric create a www folder at the root of app and try again.
Here's the fix.

it works now, thank you!


domainManager.loadDomainModule should emit a 'newDomains' event

This event notifies clients that they should refresh the interface (fetch the latest domain definitions via HTTP call).  This is particularly important when handling plugin/generator restart scenarios.
This affects only the newer domain registration process (used by generator-spaces plugin) where the domain is loaded during plugin startup (vis a vis the original process wherein clients register the domains externally).
When the NodeDomain/NodeConnection code attempts to handle a dropped connection, it polls the websocket until it becomes active and then tries to load the domain definitions.  However, there can be a small delay during plugin initialization between the time the websocket begins accepting connections, and when the domain is fully loaded.  See: https://github.com/adobe-photoshop/generator-core/blob/master/lib/generator.js#L1927
NodeDomain already attempts to account for this possible time gap by retrying a few times before giving up.  But for this to work reliably, the underlying NodeConnection must refetch the domain definitions via an HTTP call.  THIS PR forces that refetch by emitting the "newDomains" event.  Side note: This event emission already happens in the other (original) domain registration process, but was omitted in the implementation of the new domain registration process.
@iwehrman please take a look.
I cleaned the loadDomainModule function up a bit for clarity, but the only functional change is the new .emitEvent()

Very nice analysis and write-up. For anyone else following along at home, this is what happens on the client when the newDomains event is received.
I believe this to be a sufficiently low-risk change that we can take it for the next release.


[Feature]: Airtable Connexion

Is there an existing issue for this?

[x] I have searched the existing issues

Summary
A database that is very used in the "no code" sphere. Airtable is a good way to have a database with multiple views.
Why should this be worked on?
Airtable is a reference in cloud databases for no code / low code projects. It's a simple way to have a database with some relationship easily.

Hi @crystalnoir 👋 Thank you for the feature request. We have this issue tracked here #801
You can follow it for updates :)


net/http: TestClientTimeoutCancel is flaky

From the linux-ppc64le-power9osu (https://build.golang.org/log/bc146619a7844f5eadaff5632418865af83dacf4):
--- FAIL: TestClientTimeoutCancel (0.00s)
    client_test.go:1353: error = read tcp <IP_ADDRESS>:42466-><IP_ADDRESS>:40975: use of closed network connection; want errRequestCanceled
FAIL
FAIL	net/http	7.264s

CC @laboger @bradfitz

I'll take a look.

I tried a standalone build in that system and can't reproduce. Can't reproduce in any of my POWER9 systems as well. Looks like it's one of those intermittent failures.

@ceseo I think you need to try and reproduce using GOMAXPROCS=2 since that is the number of processors on the build systems.

2019-11-03T19:43:59-ab4a71f/windows-amd64-2008

2019-11-11T12:40:04-f07059d/linux-amd64-jessie
2019-11-08T21:32:23-0bbcce9/windows-amd64-2012
2019-11-08T18:11:01-1fd3f8b/linux-mips-rtrk

https://storage.googleapis.com/go-build-log/90770a22/windows-amd64-2016_87869979.log

2020-04-21T00:38:14-12665b9/linux-amd64-longtest
2020-04-17T13:30:49-8ce21fa/linux-386-longtest
2020-03-25T19:14:38-fcb8f83/linux-amd64-longtest
2020-02-27T23:06:33-3061d89/freebsd-arm64-dmgk

2020-08-24T06:01:43-328214e/linux-amd64-jessie
2020-08-17T21:05:19-ba97be4/linux-amd64-staticlockranking
2020-06-03T14:51:34-5aaeda1/darwin-amd64-nocgo

Also https://storage.googleapis.com/go-build-log/d1511a2e/android-amd64-emu_dd85a88c.log (a TryBot).

2020-10-28T13:46:11-a0a4439/windows-amd64-race
2020-10-22T13:49:19-b4c8b67/freebsd-386-11_2
2020-09-16T23:00:02-f5d59d0/linux-amd64-longtest
2020-09-16T03:02:13-eaa97fb/darwin-amd64-10_15

CC @empijei @neild

2021-03-19T17:34:25-1c59066/windows-amd64-longtest
2021-03-05T04:30:32-f0b6d37/windows-amd64-longtest
2021-02-22T18:51:18-b2bdadf/freebsd-amd64-11_2

This was really hard to track down.
The problem is that (*Transport).cancelRequest calls a per-request cancellation function, but a racing call to cancelRequest can return before that function has been called.


Fix release issues

Purpose

Fix release issues

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@18bab2f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #16303   +/-   ##
=========================================
  Coverage          ?   11.88%
  Complexity        ?     2748
=========================================
  Files             ?     1496
  Lines             ?    72404
  Branches          ?     8692
=========================================
  Hits              ?     8606
  Misses            ?    62992
  Partials          ?      806

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bab2f...57c61fd. Read the comment docs.


ActiveSupportNotification Log Subscription triggers feature db query on every request

Using the following gems / versions:
gem 'flipper', '0.23.0'
gem 'flipper-active_record', '0.23.0'
gem 'flipper-ui', '0.23.0'
ruby '3.0.2'
gem 'rails', '<IP_ADDRESS>'

I've found a problem when analyzing my SQL queries. For every request I receive in my application e.g. a default get request the following feature flipper query is also triggered. Do you know what the cause of this could be?
SELECT "flipper_features"."key" AS feature_key, "flipper_gates"."key", "flipper_gates"."value" FROM "flipper_features" LEFT OUTER JOIN "flipper_gates" ON "flipper_features"."key" = "flipper_gates"."feature_key"
Query Trace:
/ruby/3.0.2/lib/ruby/gems/3.0.0/gems/active_record_query_trace-1.8/lib/active_record_query_trace.rb:105:in `fully_formatted_trace'
/ruby/3.0.2/lib/ruby/gems/3.0.0/gems/active_record_query_trace-1.8/lib/active_record_query_trace.rb:66:in `sql'
/ruby/3.0.2/lib/ruby/gems/3.0.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/subscriber.rb:150:in `finish'
/ruby/3.0.2/lib/ruby/gems/3.0.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/log_subscriber.rb:115:in `finish'
/ruby/3.0.2/lib/ruby/gems/3.0.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications/fanout.rb:157:in `finish'

My flipper.rb initializer looks like this:
# frozen_string_literal: true

# Require adapter to set default store
require 'flipper/adapters/active_record'

# Simple check if flipper table exists
def flipper_table_exists?
  ActiveRecord::Base.connection.tables.include?('flipper_features')
rescue StandardError
  false
end

# For the test environment an in-memory adapter will be used
# and all features are disabled by default. See /test/test_helper.rb
if !Rails.env.test? && flipper_table_exists?
  # Get all features
  features = Flipper.features
  Flipper.memoize = true
  Flipper.preload_all

  begin
    feature_keys = %i(test_1_key, test_2_key)

    feature_keys.each do |feature_key|
      unless features.any? { |f| f.key == feature_key.to_s }
        if Rails.env.production?
          Flipper.disable feature_key
        else
          Flipper.enable feature_key
        end
      end
    end
  rescue StandardError => e
    # Ignore exceptions on app startup
    Rails.logger.warn("Ignoring exception on flipper feature initialization: #{e.message}")
    Rails.logger.warn e.backtrace.join("\n")
  end
end

Adding
 Rails.application.configure do
    config.flipper.preload = false
end

to my initializer/flipper.rb didn't change the behaviour. The query is still triggered every time I access a route.
Any other ideas how to remove this db request?

@michaelwapp there's a bug in the current release that causes preload/memoizer settings in config/initializers to be ignore. It is fixed in #586 and will be in the next release.
In the mean time, moving those settings to config/application.rb should fix it.

Using both (in config/application.rb)
 Rails.application.configure do
    config.flipper.preload = false
    config.flipper.memoize = true
end

results into a kind of strange behaviour.
If I set memoize to true and preload to false the above mentioned query goes away. However, the memoizing doesn't work correctly as there are queries being executed on each request for the specific / dedicated feature keys. So its an either - or decision where in both cases queries are executed which I don't want or need.
Ideas?

If I set memoize to true and preload to false the above mentioned query goes away. However, the memoizing doesn't work correctly as there are queries being executed on each request for the specific / dedicated feature keys.

This is as designed.
memoize will save the result of each feature check after the first time, so subsequent calls will not trigger another query.
preload will load all your features once per request, so no matter how many features you check or how many times you check them, there will only ever be one query.

So its an either - or decision where in both cases queries are executed which I don't want or need.

Are you seeing a performance issue?
You could disable the preload config and manually call Flipper.preload_all or Flipper.preload(*feature_names) in controllers that you want it.

memoize will save the result of each feature check after the first time, so subsequent calls will not trigger another query.

That's exactly what it doesn't do if I set both memoize = true and preload = false. That's why I'm confused. Subsequent SQL queries are triggered if configured like this.

Would you mind setting memoize to true and preload to false, restarting your app, refreshing the page and the snagging the features you are checking and the sql logs? I'd love to give that a look.

Here is my config/application.rb file:
module TestWeb
  class Application < Rails::Application
    # Initialize configuration defaults for originally generated Rails version.
    config.load_defaults 6.1

    config.middleware.move_after ActionDispatch::ShowExceptions, Flipper::Middleware::Memoizer
    config.flipper.preload = false
    config.flipper.memoize = true
  end
end

Starting and accessing my route where the feature flipper sentry_tracing is used results into the following SQL logs:
  Flipper::Adapters::ActiveRecord::Gate Load (1.4ms)  SELECT "flipper_gates".* FROM "flipper_gates" WHERE "flipper_gates"."feature_key" = $1  [["feature_key", "sentry_tracing"]]
  ↳ config/initializers/sentry.rb:26:in `block (2 levels) in <main>'
  Flipper feature(sentry_tracing) enabled? true (67.4ms)  [ thing=nil gate_name=boolean ]
method=POST path=/api/iot/v1/test ...

  Flipper::Adapters::ActiveRecord::Gate Load (3.1ms)  SELECT "flipper_gates".* FROM "flipper_gates" WHERE "flipper_gates"."feature_key" = $1  [["feature_key", "sentry_tracing"]]
  ↳ config/initializers/sentry.rb:26:in `block (2 levels) in <main>'
  Flipper feature(sentry_tracing) enabled? true (8.0ms)  [ thing=nil gate_name=boolean ]
method=POST path=/api/iot/v1/test ...

  Flipper::Adapters::ActiveRecord::Gate Load (2.0ms)  SELECT "flipper_gates".* FROM "flipper_gates" WHERE "flipper_gates"."feature_key" = $1  [["feature_key", "sentry_tracing"]]
  ↳ config/initializers/sentry.rb:26:in `block (2 levels) in <main>'
  Flipper feature(sentry_tracing) enabled? true (10.3ms)  [ thing=nil gate_name=boolean ]
method=POST path=/api/iot/v1/test ...

If I change the config to only have config.flipper.memoize = true it results into the following SQL queries:
 (1.4ms)  SELECT "flipper_features"."key" AS feature_key, "flipper_gates"."key", "flipper_gates"."value" FROM "flipper_features" LEFT OUTER JOIN "flipper_gates" ON "flipper_features"."key" = "flipper_gates"."feature_key"
  Flipper feature(sentry_tracing) enabled? true (0.2ms)  [ thing=nil gate_name=boolean ]
method=POST path=/api/iot/v1/test ...

   (5.0ms)  SELECT "flipper_features"."key" AS feature_key, "flipper_gates"."key", "flipper_gates"."value" FROM "flipper_features" LEFT OUTER JOIN "flipper_gates" ON "flipper_features"."key" = "flipper_gates"."feature_key"
  Flipper feature(sentry_tracing) enabled? true (0.0ms)  [ thing=nil gate_name=boolean ]
method=POST path=/api/iot/v1/test ...

   (1.4ms)  SELECT "flipper_features"."key" AS feature_key, "flipper_gates"."key", "flipper_gates"."value" FROM "flipper_features" LEFT OUTER JOIN "flipper_gates" ON "flipper_features"."key" = "flipper_gates"."feature_key"
  Flipper feature(sentry_tracing) enabled? true (0.0ms)  [ thing=nil gate_name=boolean ]
method=POST path=/api/iot/v1/test...

@michaelwapp I think I'm going to need to setup a test rails app and see if I can reproduce this.


UI update when using the DLY/RVB knob

I read Dian Iliev's post on Facebook, where he mentioned that he added the UI update function without even having an amp for testing. Great effort!
When checking this function I came across two issues:

The UI feedback only seems to work on the first channel. Channels 2 to 7 are unaffected.
It only works for changing the delay mix. When holding down the TAP button to switch to reverb (light of the button changes colour), the reverb level won't change in the app.

Clearly a low priority issue.

I can't find a reason for this behavior. I have a possible theory though. The amps use midi for communication but it's implemented incorrectly. I don't know if you are familiar with it but it allows you to control up to 16 channels. NUX could have used 7 of them to map to the actual 7 channels of amp, but they don't. At least in direction Amp->App they only use midi channel 0 for all communication. Now maybe in the other direction they properly use 7 channels, idk. If that's the case, my app expects everything on channel 0 and that's why it doesn't work.
Maybe the send something more specific for that control. All the parameters should have the same message code for both directions but maybe this is an exception.

There's a way to log the messages that the amp sends which will help me alot in order to find what's wrong. Go to Settings, scroll down and tap on App version 7+ times. Then scroll a bit more and you'll see 2 new options. Tap on MIDI Commands Utility. Then when you change something on your amp, the corresponding message will show up.
For example if you change the amp gain, it should be something like this:
176, 13, X - where X from 0 to 127.
If my assumption about the channels is correct, then for channel 2 to 7 the first value won't be 176 but 177, 178 etc...
You can also check what the message is for reverb knob.

Hi Tuntorious,
thanks for letting me know about the MIDI utility. I have no experience with MIDI, so I used the standard settings in the MIDI console and didn't change any of the available settings.
Here‘s a list of the values for the different knobs. The numbers stay the same, when using different channels:
Gain:      128,128,176,79,X
Volume: 128,128,176,81,X
Tone:     128,128,176,80,X (Jazz Clean)
Reverb: 128,128,176,87,X
Delay:    128,128,176,85,X
I specifically test reverb and delay channels 1, 2 and 7 and the behavior was the same for all of these. Please find the results below.
In general the range lies between 1 and 127 when turning from off to full and 125 to 0 when going from full to off.
However, many times the maxima for full wasn't reached and only did go to e.g. 125 instead of 127. It needed a couple of attempts to go to the full 127. I assume the reason for this could be the controller button on the amp not being overly accurate as you sometime can see jumps between the numbers somewhere else e.g. going from 12 to 14, or 33 to 32.
I also noticed a random message appearing every X seconds in the midi log, which I also included below. Interestingly, the fourth number from last changed during my initial tests, but now I can‘t reproduce this behavior and the number always stays 99.
I found that the tone knob, also isn't supported correctly yet. I will open a separate issue for that.
Please let me know, if you need more information.
Changing reverb from off to full on channel 1:
128,128,176,87,1 to 128,128,176,87,127
Changing reverb from full to off on channel 1:
128,128,176,87,125 to 128,128,176,87,0
Random message: 128,128,240,0,17,34,48,0,112,5,66,96,19,50,67,128,247
Note that the fourth number from last differs to the random message sent by delay.
No midi output when switching between delay and reverb and vice versa by pressing DLY/RVB button on amp. Please note, that second last number in the midi command changes from 87 to 85.
Changing delay from off to full on channel 1:
128,128,176,85,1 to 128,128,176,85,127
Changing delay from full to off on channel 1:
128,128,176,85,124 to 128,128,176,85,0
Random message: 128,128,240,0,17,34,48,0,112,5,66,96,19,8,67,128,247
Note that the fourth number from last differs to the random message sent by reverb.
Changing reverb from off to full on channel 2:
128,128,176,87,1 to 128,128,176,87,127
Changing reverb from full to off on channel 2:
128,128,176,87,125 to 128,128,176,87,0
Random message: 128,128,240,0,17,34,48,0,112,5,66,96,19,95,66,128,247
Note that the fourth number from last differs to the random message sent by delay.
Again no midi output when switching between delay and reverb and vice versa by pressing DLY/RVB button on amp. Again, the second last number in the midi command changes from 87 to 85.
Changing delay from off to full on channel 2:
128,128,176,85,1 to 128,128,176,85,127
Changing delay from full to off on channel 2:
128,128,176,85,124 to 128,128,176,85,0
Random message: 128,128,240,0,17,34,48,0,112,5,66,96,19,95,66,128,247
Note that the fourth number from last differs to the random message sent by reverb.

Thanks a lot for the extensive testing.
You don't have to change anything on the midi utility screen. This is used if you want to send a message.
Don't worry about values not going fully 0-127. It's normal for those analog potentiometers, they are simply not that accurate.
The recurring message is the battery status. Just ignore it.
Anyway, I found what the problem is. Very silly mistake. It works only on the first item in whatever effect slot it controls. For example it works only on Jazz clean amp, because it's the first one. It's just a coincidence that this amp is setup by default for channel 1 and all the rest of the channels have other amps. Same thing for delay/reverb. It will work only for analog delay/room reverb. You can test it to confirm this but I'm sure that's the problem.

Happy to help.
Just checked with the first item on the list for amp, delay and reverb on channel 3. Works like a charm. Guess you found the issue. Great job!


App keeps closing

Doesn't matter what I do, the app keeps closing itself so I'm wondering if the background process is working properly.
The phone runs on MIUI, battery saver off, autostart on, and the app is locked in the launcher to prevent auto-cleanup.
What I noticed is that the watch rarely has the RCVD symbol and it's caused by the following. When I open the app a few minutes before the specified time (e.g. 6:30), the RCVD works perfectly at 6:30, within seconds. However, when not opening the app for a while the RCVD never shows up. When I press the time receiver button on the watch, it flashes for a while and then says ERR.
When I press the app icon, the app seems to be in a closed state. As soon as it's up, manual RCVD works perfectly.
In comparison, the official Casio Watches app does not have this issue. I have the same settings on it, battery saving off, autostart, locked and the sync works right on time at 6:30, even though the last time I opened the app was yesterday.
Phone: Redmi Note 10 pro, miui 14, android 13.
Watch: GW-B5600

So, this happens because Android swaps the app out of memory after a while. This is a standard feature of the Android OS. Some phones, like OnePlus and Google Pixel, allow you to keep some apps locked in memory indefinitely, but most don't.
One way to keep it running is to use something called a foreground service. This is what the official app uses. We have decided not to use this approach for the following reasons:
It uses up significantly more battery.
There is always a notification associated with the app. This is annoying for some users, described as the "Always in your face" problem.
For users who really want to have the app running all the time, there are 3rd party apps that allow you to run apps periodically. Here are two of them:
Macrodroid - I have used it, and you can set it up to start GshockSmartSync periodically, every 6 hours, if it is not already running. It is free for simple tasks, AFAIK.
Tasker - I have not used it, but it is very popular.

Thanks for the details! I'm already experimenting with MacroDroid to see if I can solve this. I also have a Raspi at home, so I might go that way.

👍
On Wed, Jun 12, 2024, 9:34 AM bodydisplaynone @.***>
wrote:

Thanks for the details! I'm already experimenting with MacroDroid to see
if I can solve this. I also have a Raspi at home, so I might go that way.
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2163026415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37TSGOQRON4RMK5IJSDZHBE7JAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGAZDMNBRGU
.
You are receiving this because you commented.Message ID:
@.***>

I updated the Python project last night. If you're trying it, update with
the new version
On Wed, Jun 12, 2024, 9:38 AM Ivo Zivkov @.***> wrote:

👍
On Wed, Jun 12, 2024, 9:34 AM bodydisplaynone @.***>
wrote:

Thanks for the details! I'm already experimenting with MacroDroid to see
if I can solve this. I also have a Raspi at home, so I might go that way.
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2163026415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37TSGOQRON4RMK5IJSDZHBE7JAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGAZDMNBRGU
.
You are receiving this because you commented.Message ID:
@.***>

Can you please tell me how this exactly works? I have managed to install it on a Raspi3 and it runs, but nothing happens when I press the watch button. Do I have to remove pairing with my phone first, or? I don't understand how the watch should recognize that it should connect to the Pi instead of my phone.

I'm actually using pi zero. Are you sure raspberry pi has Bluetooth?
On Mon, Jun 17, 2024, 11:04 AM Ivo Zivkov @.***> wrote:

Yes, you should stop the app on all other devices, like your phone. The
watch will connect randomly to any devices that are listening. Also, make
sure the official app is not running
On Mon, Jun 17, 2024, 10:41 AM bodydisplaynone @.***>
wrote:

Can you please tell me how this exactly works? I have managed to install
it on a Raspi3 and it runs, but nothing happens when I press the watch
button. Do I have to remove pairing with my phone first, or? I don't
understand how the watch should recognize that it should connect to the Pi
instead of my phone.
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173604156,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37V2LKO2LJUHX7B6UM3ZH3YQRAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGYYDIMJVGY
.
You are receiving this because you commented.Message ID:
@.***>

I tried it with no luck. Switched off bt completely on my phone. Then
presed the sync button but the watch returned ERR. Yes, the server is
running. When I turn off bt on the Pi, the server throws errors so it
recognizes the bt module correctly.
On Mon, 17 Jun 2024, 5:20 pm Ivo Zivkov, @.***> wrote:

I'm actually using pi zero. Are you sure raspberry pi has Bluetooth?
On Mon, Jun 17, 2024, 11:04 AM Ivo Zivkov @.***> wrote:

Yes, you should stop the app on all other devices, like your phone. The
watch will connect randomly to any devices that are listening. Also,
make
sure the official app is not running
On Mon, Jun 17, 2024, 10:41 AM bodydisplaynone @.***>
wrote:

Can you please tell me how this exactly works? I have managed to
install
it on a Raspi3 and it runs, but nothing happens when I press the watch
button. Do I have to remove pairing with my phone first, or? I don't
understand how the watch should recognize that it should connect to the
Pi
instead of my phone.
—
Reply to this email directly, view it on GitHub
<
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173604156>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AA7M37V2LKO2LJUHX7B6UM3ZH3YQRAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGYYDIMJVGY>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173697922,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFM4KFGMUZGD6WVYOGY35ITZH35FXAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGY4TOOJSGI
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

What is the model of your watch?
On Mon, Jun 17, 2024 at 12:04 PM Ivo Zivkov @.***> wrote:

Try removing the config.ini file, and restart the server. Or run it with --multi-watch
flag on.
On Mon, Jun 17, 2024 at 11:54 AM bodydisplaynone @.***>
wrote:

I tried it with no luck. Switched off bt completely on my phone. Then
presed the sync button but the watch returned ERR. Yes, the server is
running. When I turn off bt on the Pi, the server throws errors so it
recognizes the bt module correctly.
On Mon, 17 Jun 2024, 5:20 pm Ivo Zivkov, @.***> wrote:

I'm actually using pi zero. Are you sure raspberry pi has Bluetooth?
On Mon, Jun 17, 2024, 11:04 AM Ivo Zivkov @.***> wrote:

Yes, you should stop the app on all other devices, like your phone.
The
watch will connect randomly to any devices that are listening. Also,
make
sure the official app is not running
On Mon, Jun 17, 2024, 10:41 AM bodydisplaynone @.***>
wrote:

Can you please tell me how this exactly works? I have managed to
install
it on a Raspi3 and it runs, but nothing happens when I press the
watch
button. Do I have to remove pairing with my phone first, or? I don't
understand how the watch should recognize that it should connect to
the
Pi
instead of my phone.
—
Reply to this email directly, view it on GitHub
<

https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173604156>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AA7M37V2LKO2LJUHX7B6UM3ZH3YQRAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGYYDIMJVGY>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173697922>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFM4KFGMUZGD6WVYOGY35ITZH35FXAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGY4TOOJSGI>

.
You are receiving this because you modified the open/close
state.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173774935,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7M37XS4V32YR6RZXACBM3ZH4BCLAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTG43TIOJTGU
.
You are receiving this because you commented.Message ID:
@.***>

Its a B5600 (2er). Video attached for reference.
On Mon, 17 Jun 2024, 6:05 pm Ivo Zivkov, @.***> wrote:

What is the model of your watch?
On Mon, Jun 17, 2024 at 12:04 PM Ivo Zivkov @.***> wrote:

Try removing the config.ini file, and restart the server. Or run it with
--multi-watch
flag on.
On Mon, Jun 17, 2024 at 11:54 AM bodydisplaynone @.***>
wrote:

I tried it with no luck. Switched off bt completely on my phone. Then
presed the sync button but the watch returned ERR. Yes, the server is
running. When I turn off bt on the Pi, the server throws errors so it
recognizes the bt module correctly.
On Mon, 17 Jun 2024, 5:20 pm Ivo Zivkov, @.***> wrote:

I'm actually using pi zero. Are you sure raspberry pi has Bluetooth?
On Mon, Jun 17, 2024, 11:04 AM Ivo Zivkov @.***> wrote:

Yes, you should stop the app on all other devices, like your phone.
The
watch will connect randomly to any devices that are listening.
Also,
make
sure the official app is not running
On Mon, Jun 17, 2024, 10:41 AM bodydisplaynone @.***>
wrote:

Can you please tell me how this exactly works? I have managed to
install
it on a Raspi3 and it runs, but nothing happens when I press the
watch
button. Do I have to remove pairing with my phone first, or? I
don't
understand how the watch should recognize that it should connect
to
the
Pi
instead of my phone.
—
Reply to this email directly, view it on GitHub
<

https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173604156>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AA7M37V2LKO2LJUHX7B6UM3ZH3YQRAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGYYDIMJVGY>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173697922>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AFM4KFGMUZGD6WVYOGY35ITZH35FXAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGY4TOOJSGI>

.
You are receiving this because you modified the open/close
state.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173774935>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AA7M37XS4V32YR6RZXACBM3ZH4BCLAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTG43TIOJTGU>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173798841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFM4KFFSQT5AQSSIL3J5UELZH4COJAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTG44TQOBUGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Ok, I did not get the video. Is it GW-5600? Should work. Did you try what I suggested. Any output on the screen I can see?
Thnaks

Nice! I deleted the config which contained the CasiOak by default. After
that I pressed the button, received a console log but the watch threw an
error again.
I restarted the server and now it runs properly with the --multi-watch
modifier, but not without it.
On Mon, 17 Jun 2024, 7:36 pm Ivo Zivkov, @.***> wrote:

Ok, I did not get the video. Is it GW-5600? Should work. Did you try what
I suggested. Any output on the screen I can see?
Thnaks
—
Reply to this email directly, view it on GitHub
https://github.com/izivkov/CasioGShockSmartSync/issues/83#issuecomment-2173967122,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFM4KFCGB63KUNTWGTQGDWLZH4NCTAVCNFSM6AAAAABJGFBY72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTHE3DOMJSGI
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I managed to make it work without the --multi-watch after a proper raspi reinstall but the time is set incorrectly. Opened a new issue at
https://github.com/izivkov/GShockTimeServer/issues/11


Add Tests

Description
Get some tests going for this project. Learn how to test in Go 😓

@all-contibutors please add @tearingItUp786 for docs, code, and author

@all-contibutors please add @tearingItUp786 for docs, code, and author

@all-contributors please add @tearingItUp786 for docs, maintenance, review

@all-contributors please add @sixlive for docs, code

https://github.com/all-contributors please add @tearingItUp786 for code

@all-contributors please add @tearingItUp786 for docs, maintenance, review

@all-contributors please update @tearingItUp786 for code


Delete Big Folders

I would like that in the editor we could delete big folders like node-modules.

/needsMoreInfo
What exactly you want, how it should looks and behave?
At this point there is no problems with removing node_modules in explorer view, and it's much faster than rm -rf node_modules in Git Bash on Windows.

It's in context menu for node_modules also removed on Del.
It will be changes to Delete Permanently if modifier key is pressed (on Windows it's Shift or Alt)
It's not clear what exactly problem do you have.
If this context menu item is missing for you - update your post with details required by bug template.
If you don't see node_modules in Explorer - check if it's not in files.exclude setting.

/needsMoreInfo
What exactly you want, how it should looks and behave?
At this point there is no problems with removing node_modules in explorer view, and it's much faster than rm -rf node_modules in Git Bash on Windows.

When i try to delete node_modules in the explorer view that editor crashes. And it doesn't even delete the folder!

When i try to delete node_modules in the explorer view that editor crashes. And it doesn't even delete the folder!

Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled
That's a bug. Please update description according to issue template(VSCode version, OS Version, Reproducible without extension etc.). You can see template here https://github.com/microsoft/vscode/issues/new?template=bug_report.md

Can not reproduce

When i try to delete node_modules in the explorer view that editor crashes. And it doesn't even delete the folder!

Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled
That's a bug. Please update description according to issue template(VSCode version, OS Version, Reproducible without extension etc.). You can see template here https://github.com/microsoft/vscode/issues/new?template=bug_report.md
I have already created a new issue with the template


Code no longer builds serially

This comment is also part of the review https://github.com/openjournals/joss-reviews/issues/6637
With the changes in commit 54875fa, the preprocessor directives for #ifdef NUDUSTC_ENABLE_MPI were commented out in src/main.cpp at lines 21 and 23, 60 and 65. Therefore, this code sections are being compiled even when building serially.
If these lines are uncommented, the code can be built again by running cmake -DNUDUSTC_ENABLE_MPI=OFF .. and make

Ah, this is why my compilation fails :-)


Form validation and hidden fieldGroups

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[x ] support request

Current behavior

Currently I have a really big form with multiple use cases based on a few select inputs. So if the user selects an option form the first select input I show different fieldGroups.
The problem I have is that in the beginning only the displayed inputs have values in the model ( I think it's normal ) but even though all the hidden options are required, after the user completes the first 4 inputs displayed, the form is VALID even though the initially hidden inputs are empty.
Expected behavior

How can I stop the form from being valid even though there are empty inputs ?
Thank you !
Minimal reproduction of the problem with instructions

This is just a small portion of the form. There are actually several select inputs and based on their values I show other fieldGroups.
   for (let i in this.users) {
            this.fields = [...this.fields,
                {
                    className: "section-label",
                    template: `<h2>User ${i + 1}</h2><hr />`,
                },
                {
                    fieldGroupClassName: "row",
                    fieldGroup: [
                        {
                            key: `users[${i}].firstName`,
                            type: "input",
                            className: "col-6",
                            templateOptions: {
                                label: "Prenom",
                                required: true,
                            },
                        },
                        {
                            ...
                        },
                    ]
                },
                {
                    fieldGroupClassName: "row",
                    fieldGroup: [
                        {
                            ...
                        },
                        {
                            key: `users[${i}].status`,
                            type: "select",
                            className: "col-6",
                            templateOptions: {
                                options: [
                                    {label: "Sélectionner", disabled: true, value: null},
                                    {label: "Etudiant", value: "student"},
                                    {label: "Independant", value: "freelancer"},
                                    {label: "Salarie", value: "employed"},
                                ],
                                label: "Status",
                                required: true,
                            },
                        },
                    ]
                },
                // Situation if student is selected
                {
                    className: "section-label",
                    hideExpression: `model.locataires[${i}].status != 'student'`,
                    template: `<hr /><h4>Situation de l'etudiant</h4>`,
                },
                {
                    fieldGroupClassName: "row situation",
                    hideExpression: `model.users[${i}].status != 'student'`,
                    templateOptions: {label: "Situation de l'etudiant" },
                    fieldGroup: [
                        {
                            key: `locataires[${i}].revenue`,
                            type: "input",
                            className: "col-6",
                            templateOptions: {
                                type: "number",
                                addonRight: {
                                    class: "fa fa-euro"
                                },
                                label: "Revenus nets",
                                required: true,
                            },
                        },
                        {
                           ...
                        },
                        {
                            ....
                        },
                    ]
                },
...
...

] };

Angular version: 5.0.X

Browser: [all]

still not clear to me, if fieldGroups is hidden then all it's fields should not affect the form validation. is that what you asked for ?

If they are hidden they should not affect the validation. But after I select a value from the select input, they are visible and required so should affect validation.

given a form that contains one field: firstname, if firstname is required and hidden then the should be valid and that's an expected behavior.
can you provide me a reproduction example here is a good start: https://stackblitz.com/edit/angular-fkdaxi
Thanks!

Hello. Thanks for taking time to look into my problem. So exactly the same thing I want to happen in my form, the same as in your example.
I tried to replicate my problem using a small example, but strangely it was still working. So I'm sure it must be something about my implementation. I ended up putting almost all my form in there, sorry for that.
https://stackblitz.com/edit/angular-heko5x
But there is a different thing happening. On stackblitz if I check form.value, all the inputs in the form has a null value. In my app, only the first 4 inputs (initially visible) have a null value, hence the form valid after completing only these inputs.
Sorry if I'm not clear enough, I'm new to Angular and also it's the first time I use formly.
Thanks again.

I'm able to reproduce it, thanks!

it should work now using 2.0.0-rc.29 version.

Thank you so much! It works like a charm now.


has_method crashes when used on a class that is passed to a function

Godot version
v4.0.beta1.official.20d667284
System information
MacOS 10.15.7
Issue description
If you call has_method on Node2D
print(Node2D.has_method('adsf'))

it will give you this error as expected:
SCRIPT ERROR: Parse Error: Cannot call non-static function "has_method()" on the class "Node2D" directly. Make an instance instead.

If you try this in a function,  using a parameter, Godot crashes
extends SceneTree

func example(thing):
	print(thing.has_method('asdf'))

func _init():
	example(Node2D)

Crash log:
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.beta1.official (20d6672846b3fd1537603ac080116dcc914c10e3)
Dumping the backtrace. Please include this when reporting the bug on: https://github.com/godotengine/godot/issues
[1] 1   libsystem_platform.dylib            0x00007fff72b315fd _sigtramp + 29
[2] 2   libobjc.A.dylib                     0x00007fff7cd2eced GCC_except_table740 + 190324253
[3] Object::can_translate_messages() const
[4] Object::can_translate_messages() const
[5] Object::can_translate_messages() const
[6] Object* ClassDB::creator<ENetConnection>()
[7] JSON::get_data() const
[8] VariantInitializer<Vector<Color> >::init(Variant*)
[9] Object* ClassDB::creator<ENetConnection>()
[10] Object::get_instance_id() const
[11] JSON::get_data() const
[12] VariantInitializer<Vector<Color> >::init(Variant*)
[13] Object* ClassDB::creator<ENetConnection>()
[14] Object* ClassDB::creator<ENetConnection>()
[15] ScriptInstanceExtension::_add_property_with_state(void*, void*, void*)
[16] Object* ClassDB::creator<Time>()
[17] 17  Godot                               0x000000010bb5145d Godot + 4506717
[18] RendererCompositorRD::_create_current()
[19] 19  libdyld.dylib                       0x00007fff72938cc9 start + 1
[20] 20  ???                                 0x0000000000000003 0x0 + 3
-- END OF BACKTRACE --
================================================================

Steps to reproduce
See Description.
Minimal reproduction project
See Steps to reproduce.

I'm on this one, it seems pretty easy

core/variant/binder_common.h:731:33: runtime error: member call on null pointer of type 'const struct __UnexistingClass'
core/object/object.cpp:630:6: runtime error: member access within null pointer of type 'const struct Object'

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.beta.custom_build (18177828ad97286ca88cbdcfb763c967858d051b)
Dumping the backtrace.
-- END OF BACKTRACE --
================================================================

I think I've found the culprit, it's these lines of code:
	MethodBind *method = ClassDB::get_method(name, p_method);
	if (method) {
		// Native static method.
		return method->call(nullptr, p_args, p_argcount, r_error);
	}

in modules/gdscript.cpp, this was added in #59947 and I ask @vnen to take a look at it, if available. I don't know the exact intent of the feature and what gdscript code triggers the if-statement without causing errors.
Currently, the nullptr goes straight through the call stack without ever being caught. Other static methods seem to go through
	virtual Variant call(Object *p_object, const Variant **p_args, int p_arg_count, Callable::CallError &r_error) override {
		Variant ret;
		call_with_variant_args_static_ret_dv(function, p_args, p_arg_count, ret, r_error, get_default_arguments());
		return ret;
	}

in modules/gdscript_vm. This method has the same name but does something entirely different. Maybe this was the confusion?

P.S. I can't fix the issue very well right now because compiling takes 30 minutes and when it is quick it still doesn't work somehow.

Almost forgot: in the example code has_method can be replaced with any other non-static method that works on an instance of Node2D.  Node2D is also not special, as long as the instance of the object given, goes with the method, this error will occur.

Still reproducible as of: e93266b9ff359c98e9f8e2a550e16ad77490fc4d
Backtrace:
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.beta.custom_build (e93266b9ff359c98e9f8e2a550e16ad77490fc4d)
Dumping the backtrace. Please include this when reporting the bug to the project developer.

-- END OF BACKTRACE --
================================================================


Create section in the docs that explain shared structs in operator CRDs

We are working towards introducting a global shared structure in all our CRDs, for example:

clusterConfig
rolegroups
rolegroupconfig
logging
...

For all the stuff that is global we should have a section in the docs that shows this shared structure and explains at a high level what goes where.

most things that exist across operators already have a concepts page https://docs.stackable.tech/home/stable/concepts/index.html (i.e. roles and role groups, logging).
I have sketched out before an overarching page that brings all of these together. I like your idea!

I am closing this, feel free to reopen this @soenkeliebau if you think something is still missing.


contracts: add backup logic for deposits

Description
Introduces backup logic for deposits that prevents users from
accidentally making bad deposits. Deposits that don't complete
successfully will be returned back to the layer where the deposits were
made.

Codecov Report

Merging #428 (50a97b4) into sc/base-messenger (230aff6) will decrease coverage by 1.68%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           sc/base-messenger     #428      +/-   ##
=====================================================
- Coverage              53.10%   51.42%   -1.69%
=====================================================
  Files                     62       57       -5
  Lines                   6498     5781     -717
=====================================================
- Hits                    3451     2973     -478
+ Misses                  2608     2436     -172
+ Partials                 439      372      -67

Impacted Files
Coverage Δ

opnode/l2/api.go
60.00% <0.00%> (-14.20%)
:arrow_down:

bss/sequencer/driver.go
72.05% <0.00%> (-2.95%)
:arrow_down:

opnode/test/geth.go
63.93% <0.00%> (-0.87%)
:arrow_down:

opnode/test/setup.go
72.12% <0.00%> (-0.70%)
:arrow_down:

opnode/service.go
0.00% <0.00%> (ø)

opnode/node/api.go
58.64% <0.00%> (ø)

opnode/eth/heads.go
69.56% <0.00%> (ø)

opnode/node/config.go
33.33% <0.00%> (ø)

opnode/rollup/types.go
18.18% <0.00%> (ø)

opnode/rollup/driver/driver.go
100.00% <0.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230aff6...50a97b4. Read the comment docs.

You will need to run forge snapshot and then commit in the diff to the .gas-snapshot


addon upgrades: only use manifest version to determine upgrade

Why is this PR needed?
When determining when an addon has to be upgraded (using skuba addon upgrade apply or skuba addon upgrade plan), rely on the manifest
version exclusively, and if different, treat the addon version as a
regular string.
If the manifest version is always bumped with every single change,
necessarily it has to be a newer version of the addon, so no need to
perform a semver parsing of the actual version of the addon (that may
contain semver pre-releases suffixes, or metadata builds -- ignored
when comparing, or not deeply compared; e.g. any prerelease
information < no prerelease information, since it's considered
prerelease vs release [1]).
[1] https://semver.org/#spec-item-11

Comment left, thanks Rafa.


GitHub readme is out of date

Trying to follow the quick example:
from griptape.drivers import OpenAiChatPromptDriver
from griptape.structures import Agent
from griptape.tools import WebScraper

agent = Agent(
    prompt_driver=OpenAiChatPromptDriver(
        model="gpt-3.5-turbo"
    ),
    tools=[WebScraper()]
)

agent.run(
    "based on https://www.griptape.ai/, tell me what Griptape is"
)

Gives the error that OpenAiChatPromptDriver cannot be found - I believe the example should be
from griptape.drivers import OpenAiPromptDriver
from griptape.structures import Agent
from griptape.tools import WebScraper

agent = Agent(
    prompt_driver=OpenAiPromptDriver(
        model="gpt-3.5-turbo"
    ),
    tools=[WebScraper()]
)

agent.run(
    "based on https://www.griptape.ai/, tell me what Griptape is"
)

Cheers!

I believe this is related to main not yet matching PyPi. We're working up an update.

0.15 was pushed to PyPI.

This all looks good now!


Replace panel: toggle replace only visible rows

If filters is active add the option to replace only visibile rows

hey can you assign me this issue, I will be happy to work on this.


Daily nuget feed not updating

Actual behavior
It seems stuck on version 0.3.110 of May 14th.

I fixed that earlier today in #1225. We should get an updated CI build out overnight.