Support for comments.

One of the biggest gripes people have with json format is the lack of support for comments.
E.g. see this reddit thread.
Many libraries, including jsoncpp and RapidJSON have support for comments in spite of the RFC.
Additionally, RapidJSON allows further relaxations to grammar, e.g. trailing commas and nan/infinity for fp-numbers.
If we want to be user-friendly, perhaps we shouldn't alienate users that have need for comments in their config files?

For this library, we do not plan to support any input which is not compliant to RFC 7159.
See #363, #311, #294, #192.

Another argument (I think) against comment support would be that the library then should preserve comments so that they do not disappear in the serialization.

Understood. But it the case you decide to support the comments, such support, by definition; should only entail ignoring them in the input; preserving them should definitely not be in scope.

I agree that it would be nice if the library could ignore comments when parsing JSON. Maybe json::parse could add a parameter flag do allow non-standard additional parsing options. Similar to the options used by this lib as an example: https://github.com/niklasfrykholm/nflibs/blob/master/nf_json_parser.c#L22

I know how I would realize this feature. But I do think that this library is better off without comments.

I'm about to start hacking on the library to support trailing commas (although I have no idea where to start looking =) ). When dealing with config json files it drives me nuts that I need to constantly tweak the commas. And comments would make those config files much more readable.

I'm about to start hacking on the library to support trailing commas

I thought that was specifically disallowed by the JSON spec?
If you are using them as a config file or so then why not use TOML or HOCON or something?

I'm about to start hacking on the library to support trailing commas

I thought that was specifically disallowed by the JSON spec?

Could be, but I don't see any harm with that as it still parses json written per the spec. Especially in config files, which are not parsed by anyone else but my application.

If you are using them as a config file or so then why not use TOML or HOCON or something?

Thanks, I wasn't aware of HOCON. I need to have a look. I did try TOML, but I didn't move to it. I can't recall what was the issue, but possibly the main issue was that this json library is great, and I anyway need it for parsing received json data. So having additional library which is more difficult to use than this does not sound good. Especially if the only missing piece is the trailing commas =).

The harm in relaxing standards is IMHO nicely described in The Harmful Consequences of the Robustness Principle.

I like the library, and was planning to use it to load config files. My company wants to put comments in json file. But it doesn't support/ignore comment, and is stopping me using it.

You should tell your company that the JSON format does not support comments, and forcing you to do so limits the number of libraries - not only in C++.

Seriously, what harm could comments do? The implementation would not harm the library, and it would make JSON a lot more usable, especially in large scale apps with teams of developers who all want to mess with configuration files.

The problem is portability. JSON does not support comments.

It is not a problem if feature is opt-in.

It is, because then this library would accept more than just JSON. And that JSON+x would not be portable any more. I'm sorry, but https://github.com/nlohmann/json#comments-in-json is all I can add to that.

This library already accepts more than json.

You mean the formats CBOR, MessagePack, etc.? These are independent of JSON.

I think the library could provide an hook to introduce non standard behaviors (like a way to process tokens in advance and substitute then): that way the library itself would be clean of any "heretic" interpretation. But I understand if the author is not interested, then he should not do it. Also, it would introduce a small performance penalty.

Anyhow as long as it is opt-in i see no issue with incompatibilities. If people explicitly opt in i trust they understand what they are doing. And this blatant refusal without a compelling argument seems stubborn.
For anyone who wants json with comments: https://github.com/Tencent/rapidjson/

JSON now has support for comments in the standard. https://json5.org/

That is not JSON (as of RFC 8259), but slightly related standard.

Hmm... I realize though that since you use std::map in the DOM, supporting comments would not only not according to RFC 8259, but damn near impossible. Since I need a format that can annotate settings, and be read AND writeable, I might need to find another solution.

I'm not sure what this has to do with std::map.

Since it is ordered. How would an implementation know how comments, or annotations, are related to the respective fields? A write could easily destroy this.

I see.


doc: added reference and geopoint data types examples

@samtstern yeah sure! Didn't have the insight behind that decision ;)


image directive doesn't accept URL as arg

I am sure that an image URL is a valid argument for the image directive,
but snooty is disagreeing:

I've confirmed in rstspec.toml that uri is a valid arg type for figure that image inherits from, but can't see where to go from there to try to debug further.
Seeing this in version 1.11.4.dev0

The direct cause is in parser.py that argument[0].value won't work when an URI is served. But even fixing that won't allow URI as image/figure argument, as snooty has other checks that only work for path.
Thus, I don't plan to fix it at this moment.

Thanks, @lextm. I appreciate the confirmation of the issue, the pointer to looking deeper into the code, and the context that it has a bigger, deeper root cause.


Remove VM Insights workbooks from workspace gallery

I pushed these same changes to https://github.com/ericc1103/Application-Insights-Templates-Dev but for some reason the Log Analytics workbook gallery is still showing VM Insights templates. Will take a look again tomorrow.

I'm going ahead and pushing this in since it's a relatively safe change and there appears to be some blockage on INT.


the content of return array created in jitted funtion is not correct

test on numba 0.22.0, win64, python 64bit
from numba import njit
import numpy as np
@njit
def f():
    a=np.ones(10,np.float64)
    b=np.ones(10,np.float64)
    #if put the defination of  a and b outside the function, then everything is fine
    return a,b[:]
f()  #if use print f(), it will crash python

here is the results:
(array([ 1.,  1.,  1.,  1.,  1.,  1.,  1.,  1.,  1.,  1.]),
array([ -9.86830992e+148,  -9.86830992e+148,  -9.86830992e+148,
-9.86830992e+148,  -9.86830992e+148,  -9.86830992e+148,
-9.86830992e+148,  -9.86830992e+148,  -9.86830992e+148,
-9.86830992e+148]))

Bug is reproduced and it is not platform dependent.
The problem is (again) traced to the reference count optimization pass inside numba.

This has now been fixed. Thanks for reporting!


image_test.go: Improve the test content

Signed-off-by: zhouhao<EMAIL_ADDRESS>

@xiekeyang @coolljt0725 PTAL

@q384566678  we need to bump the image-spec first before we have this changes, because Labels is not in the image-spec which the image-tool currently used.

@coolljt0725 I do not quite understand the meaning of bump, can you please explain to me? thanks.

@q384566678  https://github.com/opencontainers/image-tools/pull/69 is an example of bump

@coolljt0725 Since #102  has been merged, the bump is complete.

LGTM

LGTM


Nested expressions

This essentially only adds one feature over #135 yet needs the commits from #135. However, git should be able to merge this.
This allows to do something like this:
do {
    let exp = try Expression(string: "$a + 5 - $b + $a")
    // -> $a + 5.0 - $b + $a
    let a = try Expression(string: "$b - 2")
    // -> $b - 2.0
    let b = 4.0
    // -> 4.0
    let simplified = exp.simplify(["a": a], evaluator: .default)
    // -> $b - 2.0 + 5.0 - $b + $b - 2.0
    let result = try Evaluator.default.evaluate(exp, substitutions: ["a": a, "b": b])
    // -> 5.0
} catch {
    print("Failed: \(error)")
}

Since this adds new features, I've also increased the version to 3.1.

@davedelong Any comments on this and #135? Thought I'd wait until after WWDC before pinging you... 😉

I like the use of a Substitution protocol 👍


ArgumentNullException from Microsoft.AspNetCore.Mvc.HttpContextExtensions.GetRequestedApiVersion

Asp.net core web app,
below code throws null ref for requests(https://localhost:63838/health/check) with no version
version = _httpContextAccessor.HttpContext?.GetRequestedApiVersion()?.ToString();
Code reference
https://github.com/microsoft/dicom-server/blob/main/src/Microsoft.Health.Dicom.Api/Logging/TelemetryInitializer.cs#L41
Call stack of error
at System.ThrowHelper.Throw(String paramName)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
at Microsoft.AspNetCore.Mvc.Versioning.ApiVersioningFeature.get_RawRequestedApiVersion()
at Microsoft.AspNetCore.Mvc.Versioning.ApiVersioningFeature.get_RequestedApiVersion()
at Microsoft.AspNetCore.Mvc.HttpContextExtensions.GetRequestedApiVersion(HttpContext context)
at Microsoft.Health.Dicom.Api.Logging.TelemetryInitializer.AddApiVersionColumn(ITelemetry telemetry) in C:\repos\dicom-server\src\Microsoft.Health.Dicom.Api\Logging\TelemetryInitializer.cs:line 44

Do you actually have UI controllers with versioning applied? I did not see that. It's seemingly rare, but some people actually want that.
UseApiBehavior was a simple, backward-compatibility flag to disable controller filtering. Before ASP.NET Core 2.1, there was no way to distinguish between an API controller and a UI controller. Once [ApiController] was introduced, there was a clear way to determine which controllers are for APIs and which are for the UI, if you are mixing and matching. This is facilitated by the IApiControllerFilter service, whose default implementation accepts a collection of IApiControllerSpecification instances. There are 2 specifications (in 2 different packages): one that looks for ApiControllerAttribute and one that looks for ODataAttributeRoutingAttribute. When the filter executes, any controllers that do not meet one or more specifications is excluded from API versioning. This is a breaking change for anyone that wanted to use API Versioning with UI controllers. UseApiBehavior = false was a very simple way to opt out of all filtering. This option sat in there for a long time, but starting in 6.0, there was really no reason to preserve it. If you need to retain this capability, there is an out-of-the-box implementation to meet that requirement - NoControllerFilter, which applies no filtering. There is no state and the filter is only called once during initialization so there is no reason to keep it in memory (e.g. singleton).
IControllerConvention operates on a controller, but the core library supports Minimal APIs where there are no controllers. Conventions are still supported, but the configuration has been moved to a new library with a slightly different configuration.
Based on your current code, the new setup should be:
// equivalent to the old ApiVersioningOptions.UseApiBehavior = false
// note: if you don't have any UI controllers, this is unnecessary
services.Replace(ServiceDescriptor.Transient<IApiControllerFilter, NoControllerFilter>());

services.AddApiVersioning(options =>
        {
            options.ApiVersionReader = new UrlSegmentApiVersionReader();
            options.AssumeDefaultVersionWhenUnspecified = true;
            options.ReportApiVersions = true;
        })
        .AddMvc(options => options.Conventions.Add(new ApiVersionsConvention(featuresOptions)))
        .AddApiExplorer(options =>
        {
            // The format for this is 'v'major[.minor][-status] ex. v1.0-prerelease
            options.GroupNameFormat = "'v'VVV";
            options.SubstituteApiVersionInUrl = true;
        });

AddApiVersioning() now returns IApiVersioningBuilder and all extensions hang off of that:

IApiVersioningBuilder.AddMvc add MVC Core support for controllers
IApiVersioningBuilder.AddApiExplorer adds the API Explorer extensions
IApiVersioningBuilder.AddOData adds OData support
IApiVersioningBuilder.AddODataApiExplorer adds OData API Explorer extensions

Thank you.
I am still getting the ArgumentNullException

Thanks. You are right HttpContext.RequestServices is null for us all the time, it blows up only for the health check request because https://github.com/dotnet/aspnet-api-versioning/blob/main/src/AspNetCore/WebApi/src/Asp.Versioning.Http/ApiVersioningFeature.cs#L35 is null.
Not sure what we are doing to make it null. This request is happening after the webhost is started and the app is ready.
Also, I just noticed during the service registration we already have AddMvc
https://github.com/microsoft/dicom-server/blob/main/src/Microsoft.Health.Dicom.Api/Registration/DicomServerServiceCollectionExtensions.cs#L110
The new one(.AddMvc(options => options.Conventions.Add(new ApiVersionsConvention(featuresOptions)))) does not seem to register the Convention at all. Also need help on how to solve it,

For the 2nd part, you've misunderstood. IServiceCollection.AddMvc does something completely different from IApiVersioningBuilder.AddMvc. AddApiVersioning only adds the required core components for Minimal APIs. In order to support controllers, you need IApiVersioningBuilder.AddMvc, which adds additional services and support for conventions. If you follow the example I provided above - verbatim, you'll see the difference.
For the 1st part, let me see if I can enlist some help. I know this issue is external and related to IHttpContextAccessor, but I'm not entirely sure how to guide you toward a solution. I try not to punt issues.

After quite a bit of searching, I don't see anything related to HttpContext.RequestServices ever being null. While it is possible to assign the property to null that is very strange and highly unlikely. Looking at the source, this property is never null, except for:
https://github.com/dotnet/aspnetcore/blob/2745e0b1e0b8bdfe428d8d115cae0d0f42bcea7b/src/Http/Http/src/DefaultHttpContext.cs#L88
This suggests to me that ITelemetryInitializer.Initialize is happening after DefaultHttpContext.Uninitialize has been called. I can also see that this only happens when the DefaultHttpContextFactory is disposed:
https://github.com/dotnet/aspnetcore/blob/2745e0b1e0b8bdfe428d8d115cae0d0f42bcea7b/src/Hosting/Hosting/src/Http/DefaultHttpContextFactory.cs#L88
This would likely happen when the scoped IServiceProvider for the request has been disposed. I know very little about this code or how Application Insights is being used, but it looks to me like it's happening after the request has been torn down. If you're able to debug and watch the value, I suspect you can see that DefaultHttpContext._active is false, which would confirm my suspicion that it has been uninitialized, but it hasn't been GC'd - yet.
@davidfowl do you have any additional thoughts or suggestions here?

Ohh my favorite issue https://github.com/dotnet/aspnetcore/issues/42040

@davidfowl thanks for taking the time to confirm. That issue seems to be inline with the behavior described. The issue referenced seems to suggest an exception should be thrown when you do something wrong. Will that actually fix the issue? Is there a possible workaround for @smithago, no matter how ugly? I imagine that involves some type of horrible locking strategy, but that may be the only option to get unblocked in the short term.

I believe this is happening due to what I mentioned above. I noticed that although all of your controllers inherit from ControllerBase, you are not applying ApiControllerAttribute which applies the API Behaviors. This is not a requirement and you may well have a perfectly valid reason for doing that, but it is resulting in all of your controllers being filtered out from API versioning. Subsequently, that means your convention never runs because no controllers are ever processed.
There are multiple options available.

Apply [ApiController] to your API controllers

If all controllers will always be API controllers, you can use:

[assembly: Microsoft.AspNetCore.Mvc.ApiController]
or you can put it into your *.csproj, Directory.Build.props or Directory.Build.targets a la:
<ItemGroup>
 <AssemblyAttribute Include="Microsoft.AspNetCore.Mvc.ApiControllerAttribute" />
</ItemGroup>

When the attribute is applied to the assembly, all controllers are marked as API controllers.

You can replace the default IApiControllerFilter with:

services.Replace(ServiceDescriptor.Transient<IApiControllerFilter, NoControllerFilter>());

This would not filter anything and is equivalent to the old ApiVersioningOptions.UseApiBehavior = false configuration option. That appears to cover your scenario, but if you need something more, you can create a custom IApiControllerFilter or just add a custom IApiControllerSpecification. For example:
internal sealed class ControllerBaseSpecification : IApiControllerSpecification
{
    public bool IsSatisfiedBy(ControllerModel controller) =>
        typeof(ControllerBase).Equals(controller.ControllerType.BaseType);
}

indicates that any controller that inherits from ControllerBase is an API Controller (which is only true if your app says it is). You would then register it with:
services.TryAddEnumerable(ServiceDescriptor.Transient<IApiControllerSpecification, ControllerBaseSpecification>());

That's a lot of options with pros and cons. You'll have to choose the one that makes the most sense for you.

Thanks, we only use APIControllers, I went with option#3.
I can see the versions are now applied to the controller in the convention. But I see versions are not getting enforced. I call /v3/... and it continues to work. Before it would throw UnsupportedApiVersion

@smithago Following up to see if there was any additional progress or questions. Happy to help you drive this to conclusion. It would seem you're pretty close.

This thread has gone dark. It appears that you solved or found a suitable workaround. If I've missed something, feel free to re-open the issue.


Improve look of documentation website

We have several possibilities:

Move to Mkdocs Material
Update our CSS

In all cases, we should redo the tree structure to be more "Profesh"

Using mkdocs-material I can get this type of look.
What do we think about it?

I made a lot of work on the branch docs/mkdocs, would appreciate if someone would run it locally and give some feedback. I'll continue next week.

Will run locally tonight

Maybe poetry clean --all ?

There's the double "None" on the tutorials page.  Also lemme if you know about loose ends and would prefer feedback on what's already there / looks complete.

Would be really nice to either have a timeline for the papers, or a grid with links to them and some categorisation in terms of the types of content / focus of the techniques.

Another None

I don't see a "Getting started" type tab, or an installation (just with a link to https://pypi.org/project/baal/)

Forgot to commit the symlink to notebooks. just fixed many issues as well.


refactor(native-filters): update dataMask and ExtraFormData schema

SUMMARY
This PR implements native filter and cross filter API simplification efforts introduced in https://github.com/apache-superset/superset-ui/pull/1040 and https://github.com/apache-superset/superset-ui/pull/1053 . The following changes are done:

setDataMask hook now has new structure:

{
   filterState: { value: any, ...otherProps: any }
   ownState: { ...otherProps: any }
   extraFormData: ExtraFormData
}

Nested append_form_data and override_form_data fields in ExtraFormData type are moved up one level into the main filter object
currentValue removed from formData now it passed in props.filterState.value
In SuperChart injected ownState and filterState
Fixed bug when remove cross filter from dashboard it's wasn't from dashboard metadata
Fixed bug that filter_select was attached to filterBoxes
Fixed bug that when user just added cross filter without setting, it's scoping filter not appeared in filter badge
migrate old filter set metadata to new format
upgrade Python code for legacy charts that depend on viz.py

TEST PLAN
Affected areas:

Native filters
Cross filters
Own state of charts
Filter sets

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[x] Includes DB Migration (follow approval process in SIP-59)

[x] Migration is atomic, supports rollback & is backwards-compatible
[x] Confirm DB migration upgrade and downgrade tested
[x] Runtime estimates and downtime expectations provided: only affects dashboards with filter sets. Will only affect environments running the DASHBOARD_NATIVE_FILTERS_SET feature flag

[ ] Introduces new feature or API
[ ] Removes existing feature or API

LGTM, Let's see what CI reveals

FYI: marking this as WIP until all superset-ui dependencies have been resolved

LGTM! It seems that there's still the old structure used in findExistingFilterSet.test.ts


Add feature to specify custom table names in Firestore Identity

I would like to add this feature to support multiple apps running within the same GCP project and use Firestore Identity in each of them.
I was not able to run the tests locally, due to keys being encrypted in the repo.
I'm open for discussions about the solution too.

@aguacongas I see that CI has some problems with those keys too 🤔

@marrrcin no, it's because secured variables on AppVeyor can be used only on PR from the same repo https://www.appveyor.com/docs/build-configuration/#configuring-build. And the token to access to the Firebase DB is secured.

@marrrcin no, it's because secured variables on AppVeyor can be used only on PR from the same repo https://www.appveyor.com/docs/build-configuration/#configuring-build. And the token to access to the Firebase DB is secured.
Localy you can use your personnal key and update the configuration but don't commit it.

The test setup seems little weird to me. I've put my service account (having full access to Firestore) into the identityfirestore.jsonfile (in the tests folder) and it still crashes on:
System.AggregateException: One or more errors occurred. (Error reading credential file from location /var/folders/xh/m03r7y7573lbjy_44c9vm4n40000gp/T/...

System.AggregateException
One or more errors occurred. (Error reading credential file from location /var/folders/xh/m03r7y7573lbjy_44c9vm4n40000gp/T/tmp3U35Sp.tmp: JSON data does not represent a valid service account credential.
Please check the value of the Environment Variable GOOGLE_APPLICATION_CREDENTIALS) (The following constructor parameters did not have matching fixture data: FirestoreTestFixture fixture)
  Exception doesn't have a stacktrace

Could you provide a stub files for both identityfirestore.json and testsettings.json so I will know what is the expected structure in them?

identityfirestore.json
{
  "FirestoreAuthTokenOptions": {
    "type": "service_account",
    "project_id": "identityfirestore",
    "private_key_id": "{the private key id}",
    "private_key": "{the private key}",
    "client_email"<EMAIL_ADDRESS>    "client_id": "{the client id}",
    "auth_uri": "https://accounts.google.com/o/oauth2/auth",
    "token_uri": "https://oauth2.googleapis.com/token",
    "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
    "client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/firebase-adminsdk-4txvf%40identityfirestore.iam.gserviceaccount.com"
  }
}

testsettings.json
{
  "FirebaseOptions": {
    "DatabaseUrl": "{firebase db url (https://*****.firebaseio.com)}"
  },
  "AuthTokenOptions": {
    "type": "service_account",
    "project_id": "{firebase project id}",
    "private_key_id": "{firebase project id}",
    "private_key": "{firebase project key}",
    "client_email"<EMAIL_ADDRESS>    "client_id": "{firebase client id}",
    "auth_uri": "https://accounts.google.com/o/oauth2/auth",
    "token_uri": "https://oauth2.googleapis.com/token",
    "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
    "client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/firebase-adminsdk-md4q3%40identityfirebase.iam.gserviceaccount.com"
  }
}

Thanks for that.
I was fightning with the failing unit tests and realized that your main pipeline is also failing on some.
Not found: VerifyTwoFactorTokenAsync() failed for user 0a53ae2c-bd2c-4f3a-852c-0f61591ebe07.
In value:  List<String> ["VerifyTwoFactorTokenAsync() failed for user."]

So it seems like some kind of mismatch between the test cases that you base on and the target framework (?). I see that on main branch of the ASP.NET Core the log string indeed looks like the one produced (no user id) https://github.com/dotnet/aspnetcore/blob/4d3191176696d69a289ec465c38f2374553ed324/src/Identity/Extensions.Core/src/UserManager.cs#L1830 whereas the test expects user id there. Weird.

Oh yeah, I forgot that. Actually the package Microsoft.AspNetCore.Identity.Specification.Tests is not compatible with .Net 5. I open an issue : https://github.com/dotnet/aspnetcore/issues/27873. It's fixed but not yet published.

I merged but I forgot one thing: the doc. Can you add a README.md in the Firestore project folder to document this new feature please ?


Gherkin 8 rule

Upgrades to use Rule

Thanks Aslak.
@sebrose we'll need to update the teaching materials to match this eh?

I'm merging this since @sebrose demoed it's already on cyber dojo


Issues after update automatic1111

Sampler dpm++ SDE karras make blurry images after update and don't see that samplers that everyone writing, i mean that one's with "3m"
Even after fresh install on gdrive.

Check the issues in the A1111 repo https://github.com/AUTOMATIC1111/stable-diffusion-webui

i'm having the same issue, all SDE named samplers is giving bad results, pixelated and blurry, this bug started right after i updated  stable diffusion


Users/adi ro h/bug1246 interurban resolution

resolving bug #1246
https://github.com/hasadna/anyway/issues/1246

A file, under an external folder from the code, also includes the bug:
anyway/static/data/news_flash_infographics_mock/mock_data.json includes also בינעירוני , coded to utf-16: \u05d1\u05d9\u05e0\u05e2\u05d9\u05e8\u05d5\u05e0\u05d9 (first line in the file, the value of resolution).
For resolving the bug, I changed only the code itself, in "anyway" folder. not this file

@AdiRoH great work!
Since I added some prs - there is a conflict in anyway/flask_app.py (the code was transferred to another file in this pr) - please fix and push changes.

@idosavion is right :) I think that this is a good idea, but there are files, that you can't use this method:
anyway/static/data/news_flash_infographics_mock/mock_data.json
contains words in utf-16
anyway/tests/accidents_definitional_ynet.tsv:

of course 😄 , meant only in *.py files.

also, consider amending the commit message into something describing the actual change being made:
Modify interurban resolution text\extracting interurban resolution text to a constant or anything similar 😄


vm-aot-android-release-arm64c: Failures in standalone/io/socket_cancel_connect_test, standalone/io/unix_socket_test, standalone/io/regress_flutter_57125_test, and service/process_service_test

There are new test failures on [vm/ffi] Fix Struct use in @Natives...Revert "Reland "[VM/Timeline] Add test that makes TSAN check the track metadata map"".
The tests
service/process_service_test/dds RuntimeError (expected Pass)
service/process_service_test/service RuntimeError (expected Pass)
standalone/io/regress_flutter_57125_test RuntimeError (expected Pass)
standalone/io/socket_cancel_connect_test/0 RuntimeError (expected Pass)
standalone/io/socket_cancel_connect_test/1 RuntimeError (expected Pass)
standalone/io/socket_cancel_connect_test/2 RuntimeError (expected Pass)
standalone/io/socket_cancel_connect_test/3 RuntimeError (expected Pass)
standalone/io/unix_socket_test RuntimeError (expected Pass)

are failing on configurations
vm-aot-android-release-arm64c

Logs:

service/process_service_test/dds
service/process_service_test/service
standalone/io/regress_flutter_57125_test
standalone/io/socket_cancel_connect_test/0
standalone/io/socket_cancel_connect_test/1
standalone/io/socket_cancel_connect_test/2
standalone/io/socket_cancel_connect_test/3
standalone/io/unix_socket_test

Same set of commits also caused failures on vm-aot-android-release-arm_x64:
There are new test failures on [vm/ffi] Fix Struct use in @Natives...Revert "Reland "[VM/Timeline] Add test that makes TSAN check the track metadata map"".
The tests
standalone/io/http_on_unix_socket_test RuntimeError (expected Pass)
vm/dart/regress_b_216834909_test Timeout (expected Pass)

are failing on configurations
vm-aot-android-release-arm_x64

Logs:

standalone/io/http_on_unix_socket_test
vm/dart/regress_b_216834909_test


Azure Bot Services Integration

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ X] No

Pull Request Type
What kind of change does this Pull Request introduce?
Azure Bot Services to chat with the data

Deploy a WebApp

Deploy an Azure Bot Services with Multi Tenant

Update the Environment variables

set API_ENDPOINT= app-backend.sdasda-azurewebsites.net
MicrosoftAppId = <AppId>
MicrosoftAppPassword=<AppPassword>

Deploy WebApp

Update BotServices --> Configuration --> MessagingEndPoint --> https:/<webapp>/api/messages

[ ] Bugfix
[ X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@vrajroutu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="Siemens Healthineers"]

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Siemens Healthineers"

@vrajroutu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@vrajroutu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree


Ringsail does not distinguish between twitter.com/usagov and facebook.com/usagov

I just tried to enter http://facebook.com/usagov to my instance of Ringsail. I got the following error:
Mysql2::Error: Duplicate entry 'usagov' for key 'index_outlets_on_service_id_and_account': INSERT INTO outlets (account, created_at, info_url, language, organization, service, service_url, updated_at, updated_by) VALUES ('usagov', '2011-12-14 18:42:52', 'http://USA.gov', 'English', 'USA.gov', 'facebook', 'http://facebook.com/usagov', '2011-12-14 18:42:52'<EMAIL_ADDRESS>It looks like we'll need to distinguish between usernames as entered on different outlets within MySQL.
Let me know if you need further clarification on this.

The database had an old, unneeded validation on the outlets table. I've removed it. Thanks for catching this.


move class Etym from helpers.py to qfysc.py

along with all functions that go with it. Also fix the tests.

Fixed in commit 1deb455c5254f9e0340c09759e6ca3d190e28481


File management

We should discuss how to best handle the storage and sync of locally cached files.
I'd think the options should be:

delete on sync if file present - pi checks server and deletes any local file that is already there
Delete on sync - each file is locally deleted as soon as it is successfully uploaded (different from previous because if we have a different process on the remote server that is moving files as they are uploaded, the pi won't be able to check which files are on the server to compare what is there with the local set)
Cache local and never delete - Files are never deleted from the picam
** Would also be nice to have some space reporting (could be a button the user clicks to load the details if this slows things down too much) - should list: * number of local files; * how much space there is *estimate of number of captures remaining (count) * Estimate of captures remaining - time (count of images / frame rate), but formatted nicely (i.e. days, hours minutes left before it is full)
Cache local, no upload - files are stored on pi but not uploaded (but this shouldn't disable upload for the webcam image)
Delete all local images button
** (Even better would be an additional option to "delete all files older than..." for space management

Gareth this never got assigned to you and was under the wrong repo. not sure how much is still relevant.

Umm. You just need to input bogus login credentials for 3 and 4.
And 1,2,5 happen automatically.
5: Why wouldn't you just delete them when you copy them off the pi if they are stored locally?

Ill look at putting the buttons in for file management.
Can we have these issues on spc-eyepi rather than gigavision?

This was implemented ages ago. Closing.


Extension thinks I'm using old jest

I get this message on vscode startup: "This extension relies on Jest 20+ features, it will continue to work, but some features may not work correctly."
But I am using jest 20, installed into my node_modules:
$ node_modules/.bin/jest -v
v20.0.4

The same thing for me. Any ideas?

Maybe a workaround would be to add<EMAIL_ADDRESS>to your package file instead of just jest-cli.

That could be it, I don't use global commands like that - so it's likely that in all my projects there's a direct dependency on Jest's internals

Same thing here. Create React App 1.0.7 with macOs

I still received the error after adding<EMAIL_ADDRESS>to my CRA package.json.
I then updated react-scripts, restarted Code and the error was gone.
Not sure if its a fix but it worked for me

I still received the error after adding<EMAIL_ADDRESS>to my Create-React-App package.json.

Note: this is entirely unsupported by Create React App. If you add jest to package.json in a Create React App project, we make no guarantees that test will work in the future.

I just saw this. Using vue webpack template

What steps can we take to reproduce that problem @robertmain? The vuejs-templates/webpack repo is using Jest 21 so it might be worth looking into. If you run npm ls jest or yarn list jest in that directory, what version of Jest do you get?

$ yarn list jest
yarn list v1.3.2
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─<EMAIL_ADDRESS>Done in 1.38s.

$ npm run unit

><EMAIL_ADDRESS>unit C:\Users\robert\Code\Node\dashboard
> jest test/unit/specs --coverage

No tests found
In C:\Users\robert\Code\Node\dashboard
  28 files checked.
  testMatch: **/__tests__/**/*.js?(x),**/?(*.)(spec|test).js?(x) - 1 match
  testPathIgnorePatterns: \\node_modules\\ - 28 matches
Pattern: test/unit/specs - 0 matches
----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|

You can find the repo here: glow.dev.maio.me/impulse/dashboard/tree/develop/

Do you continue to see the warning about the old version of Jest @robertmain? I couldn't reproduce the issue with your repo and the latest version of the extension. I didn't not appear for me.
Also in your console output, no tests were found running npm run unit because that testPathPattern test/unit/specs doesn't work on Windows. Here's the relevant issue: facebook/jest#3793

Do you continue to see the warning about the old version of Jest @robertmain? I couldn't reproduce the issue with your repo and the latest version of the extension. I didn't not appear for me.

I actually uninstalled the extension when it first started happening because I couldn't make it behave. I re-installed it when I saw your comment so I'd guess that fixed it :)

Also in your console output, no tests were found running npm run unit because that testPathPattern test/unit/specs doesn't work on Windows

Yeah, I've noticed that - I've taken to using npx jest --watch instead


Update README to fix issue #262

In version 0.9.0, some packages have been separated from @apollo/experimental-nextjs-app-support/ssr,
this PR updates the correct usage so people can follow.

@nodegin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

I'm sorry, but that's not the intended way of using it.
If you are using @apollo/experimental-nextjs-app-support, you should also import everything from @apollo/experimental-nextjs-app-support - and in this case from @apollo/experimental-nextjs-app-support/ssr.
We will eventually move the /rsc and /ssr imports together to @apollo/experimental-nextjs-app-support and rename NextSSRApolloClient etc. to just ApolloClient. That's planned for version 0.11.0.
But you'll always only be importing from  the @apollo/experimental-nextjs-app-support and @apollo/client packages.
"@apollo/client-react-streaming" is only interesting for you if you want to integrate Apollo Client with another framework (or a hand-written solution).


[stable/traefik] Update API versions, add Kubernetes endpoint config

What this PR does / why we need it:

Updates the API versions for RBAC and Deployments
Adds the ability to specify the Kubernetes master API endpoint in the Traefik configmap.

/ok-to-test

Very clean!
👏

/lgtm


feat(icons): add guillemets

What is the purpose of this pull request?

[x] New Icon
[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description

Adds guillemets icon.
Icon use case

This icon represents guillemets, which are used as quotation marks in many regions as well as other uses:

quotation mark in several regions
in UML to indicate a stereotype
in Microsoft Word as a mail merge field

Note that these are separate from chevrons and angle brackets, which have different uses and appearances. This icon more visually matches parentheses, brackets, and braces.
Alternative icon designs

Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[x] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[x] The icons are solely my own creation.
[ ] The icons were originally created in # by @
[ ] I've based them on the following Lucide icons:
[ ] I've based them on the following design:

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[x] I've made sure that the icons look sharp on low DPI displays.
[x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[x] I've made sure that the icons are visually centered.
[x] I've correctly optimized all icons to three points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

Should the icon not match with chevrons-left-right and chevrons-left?

Should the icon not match with chevrons-left-right and chevrons-left?

Yeah, true, these look much more like double angle brackets than guillemets.


Compile issue with Debian Stretch

Im trying to compile cudaminer but am currently coming accross annoying errors.
Operating System: Linux-x86_64 - Debian Stretch
GPU - Nvidia 1080 GTX
GPU Drivers -367.27
I have tried with both CUDA toolkit 7.5 and 8.0 and am getting the same error on compile
These are the commands I run
mkdir build
cd build
cmake -DBUNDLE=cudaminer ..
make -j8
[ 33%] Building CXX object libdevcore/CMakeFiles/devcore.dir/TrieCommon.cpp.o
[ 35%] Building CXX object libdevcore/CMakeFiles/devcore.dir/Log.cpp.o
[ 37%] Linking CXX shared library libethash-cl.so
[ 37%] Built target ethash-cl
[ 39%] Building NVCC (Device) object libethash-cuda/CMakeFiles/ethash-cuda.dir/ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o
nvcc fatal   : redefinition of argument 'std'
CMake Error at ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o.cmake:207 (message):
  Error generating
  /home/user/cpp-ethereum/test/libethash-cuda/CMakeFiles/ethash-cuda.dir//./ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o

libethash-cuda/CMakeFiles/ethash-cuda.dir/build.make:63: recipe for target 'libethash-cuda/CMakeFiles/ethash-cuda.dir/ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o' failed
make[2]: *** [libethash-cuda/CMakeFiles/ethash-cuda.dir/ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o] Error 1
CMakeFiles/Makefile2:320: recipe for target 'libethash-cuda/CMakeFiles/ethash-cuda.dir/all' failed
make[1]: *** [libethash-cuda/CMakeFiles/ethash-cuda.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 41%] Building CXX object libdevcore/CMakeFiles/devcore.dir/StructuredLogger.cpp.o
[ 43%] Building CXX object libdevcore/CMakeFiles/devcore.dir/TrieDB.cpp.o
[ 45%] Building CXX object libdevcore/CMakeFiles/devcore.dir/CommonJS.cpp.o
[ 47%] Building CXX object libdevcore/CMakeFiles/devcore.dir/CommonIO.cpp.o
[ 50%] Building CXX object libdevcore/CMakeFiles/devcore.dir/Base64.cpp.o
[ 52%] Building CXX object libdevcore/CMakeFiles/devcore.dir/Common.cpp.o
[ 54%] Building CXX object libdevcore/CMakeFiles/devcore.dir/CommonData.cpp.o
[ 56%] Building CXX object libdevcore/CMakeFiles/devcore.dir/RLP.cpp.o
[ 58%] Linking CXX shared library libethstratum.so
[ 58%] Built target ethstratum
[ 60%] Building CXX object libdevcore/CMakeFiles/devcore.dir/Worker.cpp.o
[ 62%] Building CXX object libdevcore/CMakeFiles/devcore.dir/TransientDirectory.cpp.o
[ 64%] Building CXX object libdevcore/CMakeFiles/devcore.dir/FixedHash.cpp.o
[ 66%] Linking CXX shared library libdevcore.so
[ 66%] Built target devcore
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

There are a few warnings earlier in the log about depreciation and some "note: declared here"
if you would like me to post whole log.

I temporary resolved adding -D_FORCE_INLINES to CMAKE_CXX_FLAGS and removing all -std=c++11 from generated Makefiles (after running cmake and before running make), especially in libethash-cuda/CMakeFiles/ethash-cuda.dir/ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o.cmake
Newer version of compilers and drivers perhaps have different behaviour managing std flags...

[ 39%] Building NVCC (Device) object libethash-cuda/CMakeFiles/ethash-cuda.dir/ethash-cuda_generated_ethash_cuda_miner_kernel.cu.o
nvcc fatal   : redefinition of argument 'std'
this is "normal" behavious ..
you can fix this by using one of the pull requests ..
like this https://github.com/Genoil/cpp-ethereum/pull/76

Hello,
I'm also hitting a problem compiling on Debian Stretch. CUDA only supports gcc versions up to 5.3 and make gives this error:
 #error -- unsupported GNU version! gcc versions later than 5 are not supported!
  ^~~~~

I've tried adding gcc-5 as an alternative (using this helpful page) however, while Stretch still has gcc-5, it doesn't have g++-5, which still leads to errors (cc: error trying to exec 'cc1plus': execvp: No such file or directory).
Any clues? Thanks.


Revert behaviour of deprecated Compara endpoints

Description
Ensembl REST PR #583 deprecated Compara REST endpoints supporting queries by gene/sequence object stable ID, and introduced replacement endpoints supporting queries by species name and object stable ID. (See ENSINT-1416 for more info.)
In PR #583 and the follow-up PR #587, the deprecated endpoints were coded to try to catch duplicate stable IDs. However, the approach taken was not performant, so this draft PR proposes to completely revert endpoints [/cafe/genetree/member/id/:id] and [/genetree/member/id/:id] to be consistent with their previous behaviour, and partially revert the behaviour of [/homology/id/:id].
The homology endpoint is partially reverted because a complete reversion is not practical in light of the removal from the Compara API of the method MemberAdaptor::fetch_by_stable_id which was used in the EnsEMBL::REST::Controller::Homology::fetch_by_ensembl_gene method until Ensembl 109.
Unit tests of handling of stable ID clashes are removed.
Use case
This PR is intended to address performance issues with updates to the 3 deprecated Compara REST endpoints.
Benefits
The deprecated Compara endpoints would be more performant.
Possible Drawbacks
Not all member stable ID clashes would raise an error. However, this is not a disimprovement on the previous behaviour of the affected endpoints.
Testing
All Compara unit tests pass locally, whether with or without the multi/stable_ids test database.
Notes
No PR has been submitted to ensembl-rest_private, as no changes have been made to the documentation.

Awesome @twalsh-ebi , thanks. As agreed, asking Botond to confirm before going on and merge. Cheers


NTLM Authenticator

Hey @ellipsis-dev please implement an NTLM authenticator client that must be defined with the following structure:
type Client struct {
    User           string
    Password       string
    Hash           []byte
    Domain         string
    Workstation    string
    TargetSPN      string
    ChannelBinding *ChannelBindings
}

You can expand the struct as needed. This client must implement the following interface:
type Authenticator interface {
    Negotiate() ([]byte, error)
    Authenticate(msg []byte) ([]byte, error)
    Metadata() interface{}
    Sign(msg []byte) ([]byte, error)
    Encrypt(msg []byte) ([]byte, error)
}

The client must implement the Authenticator interface, but can also extend it if needed. I want to use this client as an authenticator in different contexts, such as an authenticator for a SMB connection, as well as an authenticator for a MSRPCE connection.
Please implement this client to receive raw bytes (such as the NTLM challenge) and return raw bytes containing the NTLM response, store useful information about the server, such as the Netbios Computer Name, DNS computer name, Tree name etc...

@ellipsis-dev, implement this


Can't use Home and End keys to go to beginning or end of line

Arrow keys work, but the Home key and the End key do nothing. They're really convenient when I'm writing long one-liners.

Hello, thank you for raising this issue!
Home and End keys are not yet implemented. However ctrl-a/ctrl-e are.  Let me know if you have problems with these two.
I will implement Home and End right now :)

Implemented here!


I don't see a corresponding option in convco config --default.
Could we have a way to configure/override this?
Otherwise a message like chore: format, which is a valid "conventional commit" as per the specs, is rejected by convco

Conventional commits specs do not say anything about the minimum or maximum length, so it is up to the tool to set some limits. But it is indeed better if this would be configurable.

@sripwoud I made #228 to add this as a configuration option. Would this fit for you or should this also be available as a cli option?

@hdevalke a config option like you implemented is perfect for me!


How to apply theme tokens to border-bottom

This doesn't work
border-bottom: 1px solid "[theme: listItemBackgroundHovered, default: #f4f4f4]";

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a7a0e56-b781-1779-9bcf-bb688892a0f0
Version Independent ID: a3ccd2c0-b0c0-84bc-ffd2-41bdaddede56
Content: Use theme colors in your SharePoint Framework customizations
Content Source: docs/spfx/use-theme-colors-in-your-customizations.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

You can do this by setting those properties separately rather than using the shorthand border-bottom attribute. So, this should take care of the issue:
border-bottom-width: 1px;
border-bottom-style: solid;
border-bottom-color: "[theme: listItemBackgroundHovered, default: #f4f4f4]";


Remove fixed seed for test_sparse_nd_save_load

Description
Remove fixed seed for test_sparse_nd_save_load
Unable to reproduce flakiness of test - ran 10000 times
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[X] Changes are complete (i.e. I finished coding on this PR)
[X] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[X] Remove fixed seed for test_sparse_ndarray:test_sparse_nd_save_load

Comments

Related issue - https://github.com/apache/incubator-mxnet/issues/11741

@haojin2 @szha

For this kind of case please refer my changes to #11888 and add the link to the tracking issue in the code so that we can backtrack if it happens to fail again.


Canvas Context's toDataURL not returning webp

Which version of PhantomJS are you using? Tip: run phantomjs --version.
2.5.5-beta
What steps will reproduce the problem?
Using WhammyJS Tutorial to generate webm video
Which operating system are you using?
OSX-Seirra
Did you use binary PhantomJS or did you compile it from source?
Binary
Please provide any additional information below.
Canvas's context.toDataURL is returning a base64 png file, however the modern browsers returns base64 encoded webp images for the same. Though phantom does have support for webp, it would be great if canvas's dataURL too can be returned in webp format.

PhantomJS is abandoned. The maintainer recommends you use Chrome Headless instead.
https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE

@csvan Hi. Could you please stop posting messages like this? I know that people still open issues and wait for fixes, but we have more than 1000+ issues here. Are you going to comment all of them? :-)
PhantomJS is not abandoned yet (until we hear an official statement from Ariya)

@Vitallium sorry, it's been fixed.

@csvan Thank you!


issuance: Unconfirmed asset issuance transaction - does not refresh showing confirmed

Issue an asset to the wallet and transaction remains unconfirmed. Double clicking on the unconfirmed transaction in electrum wallet shows below error.
Wallet must be closed and then reopened in order to see tx's confirm (despite many blocks)
Traceback
Traceback (most recent call last):
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/history_list.py", line 302, in on_doubleclick
self.parent.show_transaction(tx)
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/main_window.py", line 810, in show_transaction
show_transaction(tx, self, tx_desc)
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/transaction_dialog.py", line 57, in show_transaction
d = TxDialog(tx, parent, desc, prompt_if_unsaved)
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/transaction_dialog.py", line 163, in init
self.update()
File "/Users/cryptopoly/cb-client-wallet/electrum/gui/qt/transaction_dialog.py", line 256, in update
fee = self.tx.get_fee()
File "/Users/cryptopoly/cb-client-wallet/electrum/transaction.py", line 1153, in get_fee
return self.input_value() - self.output_value()
File "/Users/cryptopoly/cb-client-wallet/electrum/transaction.py", line 1140, in input_value
return sum(x['value'] for x in self.inputs())
File "/Users/cryptopoly/cb-client-wallet/electrum/transaction.py", line 1140, in
return sum(x['value'] for x in self.inputs())
KeyError: 'value'

Fixed too by @tomt1664


[$250] Saved search - Unable to delete saved search using Enter key

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to Search.
Click 3-dot menu next to the saved search (save a search if there is no any).
Click Delete.
Press keyboard Enter.

Expected Result:
User should be able to delete saved search using Enter key.
Actual Result:
User is not able to delete saved search using Enter key.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/aa01bf4f-915d-4b83-a51e-de7fb0019c1b

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836866373768762286
Upwork Job ID:<PHONE_NUMBER>768762286
Last Price Increase: 2024-09-26

Issue OwnerCurrent Issue Owner: @akinwale

We think that this bug might be related to #wave-collect - Release 2

@OfstadC  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Saved search - Unable to delete saved search using Enter key
What is the root cause of that problem?
The yes button has pressOnEnter enabled in confirm content here
https://github.com/Expensify/App/blob/47d375e3078a51867b50e4e614f8f859b06e5c3e/src/components/ConfirmContent.tsx#L202
https://github.com/Expensify/App/blob/47d375e3078a51867b50e4e614f8f859b06e5c3e/src/components/ConfirmContent.tsx#L230
Which would activate listening of Enter key via KeyboardShortcutComponent
https://github.com/Expensify/App/blob/47d375e3078a51867b50e4e614f8f859b06e5c3e/src/components/Button/index.tsx#L334-L335
But KeyboardShortcutComponent but key listening is active only if the current screen is focused
https://github.com/Expensify/App/blob/47d375e3078a51867b50e4e614f8f859b06e5c3e/src/components/Button/index.tsx#L166
but in our case the screen that holds the confirm modal is not focused
What changes do you think we should make in order to solve the problem?

To deal with this kind of exceptions we can allow pressOnEnter buttons inside ConfrimContent to have keyboard shortcut listening activated when the modal isVisible
we can add a new param isActive in KeyboardShortcutComponent and change the condition to
https://github.com/Expensify/App/blob/47d375e3078a51867b50e4e614f8f859b06e5c3e/src/components/Button/index.tsx#L166
            isActive: pressOnEnter && !shouldDisableEnterShortcut && (isFocused || isActive),

and pass down isVisible prop from ConfirmModal here https://github.com/Expensify/App/blob/47d375e3078a51867b50e4e614f8f859b06e5c3e/src/components/ConfirmModal.tsx#L126
to ConfirmContent > The two confirm buttons ( with pressOnEnter) inside Confrim Content > KeyboardShortcutComponent
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Saved search - Unable to delete saved search using Enter key
What is the root cause of that problem?
The yes button has pressOnEnter enabled in confirm content here
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/ConfirmContent.tsx#L202
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/ConfirmContent.tsx#L230
Which would activate listening of Enter key via KeyboardShortcutComponent
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L334-L336
But KeyboardShortcutComponent but key listening is active only if the current screen is focused
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L166
but in our case the screen that holds the confirm modal is not focused
What changes do you think we should make in order to solve the problem?

To deal with this kind of exceptions we can allow pressOnEnter buttons inside ConfrimContent to have keyboard shortcut listening activated when the modal isVisible
we can add a new param isActive in KeyboardShortcutComponent and change the condition to
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L166
            isActive: pressOnEnter && !shouldDisableEnterShortcut && (isFocused || isActive),

and pass down isVisible prop from ConfirmModal here
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/ConfirmModal.tsx#L126
to ConfirmContent > The two confirm buttons ( with pressOnEnter) inside Confrim Content > KeyboardShortcutComponent
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Saved search - Unable to delete saved search using Enter key
What is the root cause of that problem?
The yes button has pressOnEnter enabled in confirm content here
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/ConfirmContent.tsx#L202
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/ConfirmContent.tsx#L230
Which would activate listening of Enter key via KeyboardShortcutComponent
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L324-L326
But KeyboardShortcutComponent but key listening is active only if the current screen is focused
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L166
but in our case the screen that holds the confirm modal is not focused
What changes do you think we should make in order to solve the problem?

To deal with this kind of exceptions we can allow pressOnEnter buttons inside ConfrimContent to have keyboard shortcut listening activated when the modal isVisible
we can add a new param isActive in KeyboardShortcutComponent and change the condition to
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L166
            isActive: pressOnEnter && !shouldDisableEnterShortcut && (isFocused || isActive),

and pass down isVisible prop from ConfirmModal here
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/ConfirmModal.tsx#L126
to ConfirmContent > The two confirm buttons ( with pressOnEnter) inside Confrim Content > KeyboardShortcutComponent
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.

User is not able to delete saved search using Enter key.

What is the root cause of that problem?

The delete confirm modal is in SearchPageBottomTab:
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/pages/Search/SearchPageBottomTab.tsx#L57
https://github.com/Expensify/App/blob/b0ce2068ee57c252ec47aa1f09319eee8b4f673c/src/pages/Search/SearchTypeMenu.tsx#L253

and its "Delete" button just listen to the "ENTER" event if its parent screen is focused:
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Button/index.tsx#L166

Meanwhile, SearchPageBottomTab is always "not focused" in case of large screen, so we never can delete saved search using ENTER key.

What changes do you think we should make in order to solve the problem?

We should add the delete confirm modal to Search page instead of SearchPageBottomTab. So the isFocused from useIsFocused will be true. Details bellow:

Refactor useDeleteSavedSearch: Currently, that function return both {showDeleteModal, DeleteConfirmModal}. We need to refactor it so that we can use showDeleteModal in SearchPageBottomTab page to open DeleteConfirmModal in Search page.

function DeleteConfirmModal() {
    const {translate} = useLocalize();
    const [hashToDelete] = useOnyx(ONYXKEYS.HASH_TO_DELETE);
    const handleDelete = () => {
        SearchActions.deleteSavedSearch(hashToDelete);
        Onyx.set(ONYXKEYS.HASH_TO_DELETE, null);
        SearchActions.clearAdvancedFilters();
        Navigation.navigate(
            ROUTES.SEARCH_CENTRAL_PANE.getRoute({
                query: SearchUtils.buildCannedSearchQuery(CONST.SEARCH.DATA_TYPES.EXPENSE, CONST.SEARCH.STATUS.EXPENSE.ALL),
            }),
        );
    };
    return (
        <ConfirmModal
            title={translate('search.deleteSavedSearch')}
            onConfirm={handleDelete}
            onCancel={() => Onyx.set(ONYXKEYS.HASH_TO_DELETE, null)}
            isVisible={!!hashToDelete}
            prompt={translate('search.deleteSavedSearchConfirm')}
            confirmText={translate('common.delete')}
            cancelText={translate('common.cancel')}
            danger
        />
    );
}

function useDeleteSavedSearch() {
    const showDeleteModal = (hash: number) => {
        Onyx.set(ONYXKEYS.HASH_TO_DELETE, hash);
    };

    return {showDeleteModal};
}

export {useDeleteSavedSearch, DeleteConfirmModal};

Move DeleteConfirmModal to Search page:

We need to move this code:

https://github.com/Expensify/App/blob/b0ce2068ee57c252ec47aa1f09319eee8b4f673c/src/pages/Search/SearchTypeMenu.tsx#L253
to:
https://github.com/Expensify/App/blob/25450d96aca5d30b0fef7bdbfc9379fa71e7cd74/src/components/Search/index.tsx#L434
What alternative solutions did you explore? (Optional)

@akinwale Could you please review the proposals by EOD tomorrow? Thank you!

Friendly bump @akinwale 😃

@FitseTLT's proposal is the best approach here.
🎀👀🎀 C+ reviewed.

Deployed yesterday so I believe payment should be issued 2024-10-09

@akinwale could you please complete the BZ checklist above? Thank you!

@akinwale Please complete BZ checklist today so I can issue payment tomorrow. Thank you!

[x]  [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[x]  [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

[x]  [@akinwale] Determine if we should create a regression test for this bug.
[x]  [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Launch Expensify
Navigate to the Search page
Click the 3-dot menu next to a saved search (create a saved search if there are none).
Select Delete.
Press Enter on the keyboard.
Verify that the saved search is deleted.

Do we agree 👍 or 👎?

@OfstadC Done!

Payment Summary

@akinwale paid $250 via Upwork
@FitseTLT paid $2450 via Upwork

Thank youuu!


Use 64 bit dokan drivers on 64 bit windows

Anyone need to review first @maxtaco @gabriel ?
The actual app is still 32 bit. As a side note, if we're not supporting Win XP, shipping just 32 bit code may make less sense.

:thumbsup: Please could I get a new build with 64-bit dokan to test?


Cross-scheduler inconsistent result structure

What happened:
Due to a mistake in our code, we were persisting a dask dataframe in one scheduler, but then ran the compute while specifying threads scheduler. What was weird was that the computation returned a pandas Series of Futures instead of the expected DataFrame (or exception).
What you expected to happen:
I'm not sure what the best behavior is. Could be erroring on conflicting scheduler, running on the original scheduler, or running on the specified scheduler. Either way, the result structure should be consistent.
Minimal Complete Verifiable Example:
from distributed import Client, LocalCluster
import pandas as pd
import dask.dataframe as dd

cluster = LocalCluster()
client=Client(cluster)

df = pd.DataFrame({'a': [1,2,3]})

ddf = dd.from_pandas(df, npartitions=3)

ddf = client.persist(ddf)

# Works, and returns a DF as expected
print(ddf.compute())

# Returns a pandas Series with a row per-partition with a future as the result
print(ddf.compute(scheduler="threads"))

Anything else we need to know?:
Environment:

Dask version:
Python version:
Operating System:
Install method (conda, pip, source):

Thanks @davidhao3300 for opening up this issue! Would you feel comfortable opening up a PR, with the suggestion from @jsignell?

@jrbourbeau pointed me to https://github.com/dask/dask/issues/7082 as a broader idea that would help with this specific issue. It is probably overkill if this is the main improvement, but keeping track of some metadata about persisted layers could make cases like this more obvious.

Feel free to just open a pull request @ppsbs as soon as you start work.

Thanks, @jsignell !
I've worked a few hours on this task in the last 2 days and (based on my little experience with dask) I cannot see an unexpected behavior. As ddf.compute(scheduler="threads") runs asynchronously and compute always update the scheduler inside of get_scheduler, for me it is expected that it would return a future. And, on the other hand, as ddf.compute() runs synchronously, for me it's expected that it would get the result from the futures created by client.persist(ddf).
Or, maybe I haven't understood which would be the "objects that the scheduler can't understand" that you mentioned, @jsignell '^ ^
Thank you!
cc @davidhao3300

Once you are understand what is going on it might make sense, but it is not the behavior that a user would naively expect. This is not likely to be what the user intends to get back:
In [6]: ddf.compute(scheduler="threads")
Out[6]:
0    <Future: finished, type: pandas.core.frame.Dat...
1    <Future: finished, type: pandas.core.frame.Dat...
dtype: object

To close this issue, we would like to be able to at least give the user some warning that the operation is likely not what they intended.

I get your point @jsignell ! So, we could maybe raise an exception in the case where compute (and consequently get_async) are called with a dask graph whose result has already started being computed. Do you think that is a good path? Another option that I can think of is forcing start_state_from_dask to always convert cached futures to "results" (hence giving to ddf.compute(scheduler="threads") the same behavior of ddf.compute()), but I'm not sure of the impact of that modification.

I think raising an exception or even just a warning is the right path.

With #8700, we raise a warning when we set dask.compute(scheduler="<single-machine-scheduler>".
It'll be nice to also raise a warning if the scheduler is set using dask.config.set.
Minimal example:
import dask.dataframe as dd
from dask.distributed import Client

client = Client()

ddf = dd.DataFrame.from_dict({"x": [1, 2]}, npartitions=1)

ddf.compute(scheduler="sync") # UserWarning: Running on a single-machine scheduler when a distributed client is active might lead to unexpected results.

with dask.config.set(scheduler="sync"):
    ddf.compute() # No warnings

client.close()

@jsignell I'll re-open this, please let me know if it'll be better to open a fresh issue instead. :)

I agree with the initial report and agree that there should be an error raised if something like this happens. However, I believe the warning we have right now is confusing. I consider it a perfectly valid use case to use a threaded scheduler and a distributed scheduler at the same time.
As a matter of fact, in the distributed repo we ended up having to ignore this warning frequently because this is indeed valid behavior
What should not be allowed is to use a different scheduler/executor on a collection that contains futures of another executor which is what happens in case of calling persist.
For instance, when using two different distributed clients, it is now allowed to mix the futures. This currently raises here https://github.com/dask/dask/blob/534d1d8bf7d7f4c5dc90085a47f4d4362e1312a7/dask/highlevelgraph.py#L389-L393
and I believe a similar logic should be in place for this issue. The warning that's currently in there is not sufficient.


Typo in page title

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Steps:

Go to Image List page
Look at the title of the page

Current behavior 😯
No response
Expected behavior 🤔
No response
Context 🔦
No response
Your environment 🌎
No response

A regression from #34848


⚠ Bofrost.fr has degraded performance

In 12b6722, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1203 ms

Resolved: Bofrost.fr performance has improved in 33182b0.


fix(source): Protobuf Any as canonical JSON

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Revert #12291 which attempts to reinvent canonical JSON for google.protobuf.Any with ugly and buggy code.
https://protobuf.dev/reference/protobuf/google.protobuf/#json
This is a pre-req to fix (via refactoring) the parsing of normal message/struct according to expected RisingWave column data type. Right now the expected RisingWave column data type is ignored and it could potentially return a different Datum causing mismatch panic.
The unit tests will be updated to expect-test in a follow-up.

Checklist

[ ] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
Given the documentation has been wrong since day 0 the feature was "finished", I think we can keep it as hidden / unreleased ("Technical preview" but actually no one is using it so no feedback).

How do you think about the risk of breaking change?

As I mentioned in https://github.com/risingwavelabs/risingwave/issues/12291#issuecomment-2325751959, the previous behavior is never documented, so it is an unreleased feature and no one is actually using it.


Important bug! In ver 5.3.2 tabs erases after exit

What steps will reproduce the problem?

Open some tabs
Close Grabber
Open Grabber again
in 90% cases tabs will not be restored, you will lose it.

How often does this problem occur?
Almost in all cases.
What version of the program are you using? On what operating system?
5.3.2. win 7
it starts from current version
It 100% wasn't happen in 5.3.0.alpha and earlier versions
Please provide any additional information below
I lost all my tabs.... twise. there was 56+ tabs :(
Please do something with that.

in 90% cases tabs will not be restored, you will lose it.

So you mean it does not always happen?
Because I just tried to open a few tabs, change pages, change sources, open new tabs, merged and not merged, etc. When I closed and re-opened they were still there.
Because I agree this is a major issue (losing tabs is a real pain) but if you had some way to reproduce that'd help a lot. For example, your tabs.txt file before opening the program + a few actions that will 100% cause the tabs to not save.

It's very strange... I tried it yesterday many times and it was around 90% repeatability.
But today I tried many times but can't reproduse even a single time. So I now a bit confused.
I will see, will it happen again, but now, I guess you can freeze or close this issue.

It's very strange... I tried it yesterday many times and it was around 90% repeatability.
But today I tried many times but can't reproduse even a single time. So I now a bit confused.

That could be an indicator that it either depended from something that happened on some source, some network issue or simply different tabs/settings. But that sounds improbable given all of those are unrelated to the way tabs save.

I will see, will it happen again, but now, I guess you can freeze or close this issue and remove it from 5.3.3 plan..

I'll remove it from the 5.3.3 roadmap then.

well, you know that if I can, then I try to investigate and reproduse all issues that I reporting)

Yeah, I know that. Your issues are actually part of the ones giving enough details to reproduce bugs easily (in cases where it's possible at least). :+1:
This remark was more of an introduction for the next sentence that maybe it's related to the initial state of the tabs.txt file (corruption, special tab order inside, etc.) so maybe always starting from the same one could help make it reproducible :smile:

can you instead add https://github.com/Bionus/imgbrd-grabber/issues/851 to 5.3.3 plan?... just asking)

I don't faced with this promlem simce then, so I will close the issue


Testing

Hi,
did anyone try testing using Mock JavaMail these days? I'm getting an exception on the line val mailer = Mailer("localhost", 25)()
Future(Failure(com.sun.mail.util.MailConnectException: Couldn't connect to host, port: localhost, 25; timeout -1; nested exception is:java.net.ConnectException: Connection refused (Connection refused)))

Then momsInbox is empty.
@mcamou

Hi @Arminea , how are you?
Since you are talking about the Mock, I assuming you are referring to the testing part of the README: https://github.com/dmurvihill/courier#testing.
In this part, we show how to run test using a fake mailer implementation that is provided by a third party library. The doc says that by dropping: libraryDependencies += "org.jvnet.mock-javamail" % "mock-javamail" % "1.9" % "test" in your build.sbt you should be able to run the code in the example without having the Mailer trying to really initiate a connection on localhost:25 (which is your problem, the mock is not used, the mailer tries to connect and fail).
Before we dig into this deeper can you check that:
the exception you are getting comes from test sources (that is scala sources files located under src/test/scala/*  and not src/main/scala/*
My first guess is that the line libraryDependencies += "org.jvnet.mock-javamail" % "mock-javamail" % "1.9" % "test" adds a dependency for you test sources and not your regular sources. If the exception you have come from regular sources files (under src/main/scala) then you might want to change the line to (no % "test" at the end):
libraryDependencies += "org.jvnet.mock-javamail" % "mock-javamail" % "1.9"
Hopefully this will help you

Hi, thanks for quick answer :)
I checked location of my file and it is in src/test/scala/*. Also I use gradle but I belive that's not the problem. I just add dependency like this testCompile group: 'org.jvnet.mock-javamail', name: 'mock-javamail', version: '1.9'.
How does it work that the Mailbox stores the messages in memory and the client doesn't automagically connect to localhost without being reconfigured/mocked?

Great, we're confident it's not working hahaha!
It seems like the Transport.send select the transporter dynamically at runtime. Do you mind if I investigate this later today/tomorrow?
I believe that we've updated javax.mail and we did not bother checking the doc and they are outdated. There's probably a little bit of configuration to do use the mocked transport/mailbox.

Well, I was too curious, so I gave it a try. Can you try that (if it works for you, I'll update the documentation):
package courier

import java.util.Properties

import javax.mail.Provider
import org.jvnet.mock_javamail.{Mailbox, MockTransport}
import org.scalatest._

import scala.concurrent.Await
import scala.concurrent.ExecutionContext.Implicits.global
import scala.concurrent.duration._

class MockedSMTPProvider extends Provider(Provider.Type.TRANSPORT, "mocked", classOf[MockTransport].getName, "Mock", null)

class MailSpec extends WordSpec {
  private val mockedSession = javax.mail.Session.getDefaultInstance(new Properties() {{
    put("mail.transport.protocol.rfc822", "mocked")
  }})
  mockedSession.setProvider(new MockedSMTPProvider)

  "the mailer" should {
    "send an email" in {
      val mailer = Mailer(mockedSession)
      val future =<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>            .subject("miss you")
            .content(Text("hi mom")))

      Await.ready(future, 5.seconds)
      val momsInbox =<EMAIL_ADDRESS>      momsInbox.size === 1
      val momsMsg = momsInbox.get(0)
      momsMsg.getContent === "hi mom"
      momsMsg.getSubject === "miss you"
    }
  }
}

Trick is providing a session with a Provider that give the MockTransport implementation (which writes mails to the mocked MailBox. Notice: I have removed the Mailer(localhost, 25)() in favor of Mailer(mockedSession)

I will try it first thing on Monday and I will get back to you with the result :)

Hi,
I tried your code. I had to do just a little change.
val ec =  scala.concurrent.ExecutionContext.Implicits.global
val future = mailer(envelope) (ec)

I was getting this error
Error:(98, 25) Cannot find an implicit ExecutionContext. You might pass
an (implicit ec: ExecutionContext) parameter to your method
or import scala.concurrent.ExecutionContext.Implicits.global.
    val future = mailer(envelope)

All right, I will fix the documentation. Thanks to you.


Have any way to login my account in other app via code?

Hi, this is great, so can I using this API for storage file in my game, can log in my account to any device thought my info in code, don't need to log in via a browser. Thanks so much for the git!

You can store any files on the drive as long as user has enough space quota. To access the Drive API user have to complete OAuth procedure, which requires opening a browser window to login and allow the app to access their drive. This limitation is enforced by Google for security reasons; more info here: https://developers.google.com/identity/protocols/OAuth2


Update Reconcile Test to Validate Specific Errors

Until now, the test for Reconcile function in nmc_reconciler.go only checked that the errors were not nil. Now, the test will ensure that the returned errors match the expected errors exactly.

/ok-to-test

/lgtm
/approve


0.9.2

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28]
Old-style Python selectors (py27, py35, etc) are only available for Python 2.7, 3.4, 3.5, and 3.6. Please use explicit comparisons with the integer py, e.g. # [py==37] or # [py>=37]. See lines [28]
noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


feat: Introduce StorageInsights

See b/278561593.

Please do not merge until i have a chance to review!

Documentation is now available for this component! https://cloud.google.com/php/docs/reference/cloud-storageinsights/latest

Fixing this in #6151


How would I use this with Shopify's new Flashlist?

Instead of Tabs.FlatList I want to use @Shopify 's new FlashList package.
How would I replace Tabs.FlatList with FlashList?

@shopify

same +1

same +1

@efstathiosntonas It's really funny you mentioned that because @bonfim996 was working with me and he created that fork to solve exactly this issue!
I recommend that fork as well.

FlashList support is available in version 6.1.0


Adds 'log_stream_strftime' option to allow user to specify a log stream that looks like a timestamp

Hi is there any appetite to pull this in? The use_todays_log_stream param included in #122 also meets my needs. Would love to use the official version of the plugin rather than my forked version.

I'm closing this in favor of #122.
Anyway, thank you for sending patch!


Enable premium AKS and Long Term Support configuration

Describe your changes
Issue number
#477
Checklist before requesting a review

[x] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[ ] I have passed pr-check on my machine

Thanks for your cooperation!

@microsoft-github-policy-service agree company="Alerant IT Ltd."

Thanks @ecklm for opening this pr! I've checked the CHANGELOG, this feature was introduced in 3.84.0, would you please update the provider requirement in versions.tf file too? Thanks!

Sure. Done in 5d24e33.

Sure. Done in c2013a2

Can this be expected in a release soon? I see it's been a year since the last one.

Can this be expected in a release soon? I see it's been a year since the last one.

The 6.8.0 is not the latest release, for some reason GitHub is not displaying the correct information. @lonegunmanb
@ecklm 8.0.0 is the current release, check the git tag to see the release date


Update stale.yml

Updated mark comment for issues because of a typo.

This change is

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Problem with  spice console(RHEVM)

Firstly, spice console "Connecting (encrypted) to: VM", after three minutes of waiting - "Connection timeout".
There is no error in logs.

Sorry, it was my error related to network settings.


When the project is run, FullRect anchored elements increase in size in scenes opened but not selected

Tested versions
4.2.2
System information
Godot v4.2.2.stable unknown - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; <IP_ADDRESS>22) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads)
Issue description
https://github.com/godotengine/godot/assets/23440295/2c19998f-add8-48f9-957b-9c82c99d0d7c
When running the project while ui.tscn is in the project tabs, but where ui.tscn is not the currently selected tab, the size of a specific element that is anchored with FullRect fill will increase drastically in size. This does not happen if ui.tscn is not currently open in the tabs or if it is open but is the scene that is selected when the play button is clicked.
Steps to reproduce

Open both ui.tscn and game.tscn so that both scenes are in your tab view. Click on 2D viewport.
Observe the size of the "PlayBar" node in ui.tscn
Select game.tscn such that ui.tscn is still open in your tabs but minimized.
Click the F5 run button (the play project button) at the top right of the engine.
Close the game
Click back on ui.tscn, and observe the size of the "PlayBar" node again.
Click on "PlayBar", click on Anchors preset, and click the "undo" button. Then click on the dropdown and select "full rect". this will make it fix itself.

Minimal reproduction project (MRP)
AnchorBug.zip

Thank you for reporting, consolidating in:

https://github.com/godotengine/godot/issues/90079

See there for more details, if you think something was missed about this and it's not the same issue, please comment here and it can be reopened


VG-4343 - User Login Screen Errors do not match errors throughout the rest of the application.

Current coverage is 79.78% (diff: 100%)

Merging #68 into master will not change coverage

@@             master        #68   diff @@
==========================================
  Files           113        113
  Lines          7400       7400
  Methods        1585       1585
  Messages          0          0
  Branches       1087       1087
==========================================
  Hits           5904       5904
  Misses         1496       1496
  Partials          0          0

Powered by Codecov. Last update d496c0d...7646ede


Add RecordedFuture-ImportToSentinel as deploy dependency to other playbooks

Required items, please complete
Change(s):

Added one of the solution playbooks as deploy dependency to three of the other solution playbooks.

Reason for Change(s):

Previously, when solution was deployed, it failed due to this dependency not being enforced.

Version Updated:

Required only for Detections/Analytic Rule templates
No

Testing Completed:

Need help

The issue this PR is targeting requires a full solution deploy to verify. I have not found a way to test a full solution deploy of a solution that is not available in the store.
Checked that the validations are passing and have addressed any issues that are present:

Yes

Now this PR is without any real change. I think we could solve our problem by reordering our playbooks in the Solution_RecordedFuture.json file when generating the solution package.

@devikamehra Please review the comments and provide your sign off. thanks!!

Hi @johannesh-recordedfuture , Deployment for main template is failing with below errors. Please looks into this.

@NikTripathi all playbooks validate one by one but the outbut from createSolution.ps1 does not install. We have dependency of URL, IP, DOMAN and HASH to ImportToSentinell logicapp.
I have updated theSolution_RecordedFuture.json input file so the ImportToSentinelplaybook is first. Do you have any suggestions on how to fix this issue?

@RecordedFutureOskbo This issue is because in mainTemplate.json default value of PlaybookNameBatching is incorrect. It should be the name of ImportToSentinel playbook whereas it is name of the calling playbook itself. Fixing the same should make it work.

@devikamehra ok thanks, Is that something that I have to manually edit after generation?
When I look at for example from the file RecordedFuture-URL-Recent_Rep_by_Insikt_Group-IndicatorProcessor.json then correct name is in the file but not in the generated mainTemplate.json.
"parameters": {
        "PlaybookName": {
            "defaultValue": "RecordedFuture-URL-Recent_Rep_by_Insikt_Group-IndicatorProcessor",
            "type": "String"
        },
        "PlaybookNameBatching": {
            "defaultValue": "RecordedFuture-ImportToSentinel",
            "type": "String"
        }
    },

@devikamehra I manually fixed the defaults and had to add dependson "[resourceId('Microsoft.Logic/workflows',parameters('playbook6-PlaybookNameBatching'))]" in order for the logic apps to be installed in correct order.
But now It finally works! Each playbook validates when I test and the generated/edited masterTemplate.json and createUiDefinition.json will pass Test-AzTemplate, and I'm able to install them using manual "Deploy from a custom template" in my test environment.


HuggingFace version for BEiT3

Hi,
When can we expect a hugging face version for BEiT3?

@donglixp , should this issue be re-opened since progress at the linked pull request appears to have stalled out?


ceres-solver: add example dynamic LAPACK

this PR adds an example testing ceres-solver built with SuiteSparse using a dynamic LAPACK lib. I'm using this configuration in all my projects. It would be nice that this configuration is tested and maybe even cached
should we maybe merge the ceres-tests into one testing branch pkg.ceres-solver instead of the two we have now?

ceres-solver-suitesparse testing merged into pkg.ceres-solver branch:

https://github.com/ingenue/hunter/blob/pkg.ceres-solver/.travis.yml

Feel free to add ceres-solver-dynLAPACK example.


Corners in views

Layouts are drawing content really cut out by their corners, but simple views can just draw backgrounds with corners.

In the end it doesn't matter in terms of performance. It's just more difficult to code.


Fix: Add the channel to prevent the resource race.

Adjust the unit test time unit to increase fault tolerance

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Https Api endpoint

Currently not working for Mac and Linux - the certificate store is different and we will need a different strategy, unless we missed something from the .Net Core framework
User can provide the name of an exiting certificate to use from his Root store in appsettings
Otherwise, the default is to create a default certificate with a random password and add it to the root store if it doesn't already exist (this will give a warning dialog in Windows) otherwise, just re-use the default certificate from last run (no warnings, no change in user experience).
This PR also contains a change done with @ArcSin2000X to add a guid to integration test folders to try and make them more stable.

Why do you use store at all?

Let me remove the change that adds a Guid to the folder name

@Aprogiena so far, on windows, we have not found a workaround that gives a seamless user experience. It looked like the certificate needed to be in the Trusted Root Certification Authority folder, otherwise Chrome and other browsers get in panick mode.
This is definitely not ideal and very windows bound, I am looking at alternatives for Mac and Linux, and hopefully they can port to Windows too. We wanted to put that in PR now for people to let us know what they think in the meantime

so far, on windows, we have not found a workaround that gives a seamless user experience. It looked like the certificate needed to be in the Trusted Root Certification Authority folder, otherwise Chrome and other browsers get in panick mode.

@monsieurleberre How is this envisioned to be used? Is this is API, why do we care about chrome? I would expect some API client to access the API and not a browser. So where does browser come in?

@Aprogiena so currently I think people are relying on a fair bit on Swagger to do the calls, therefore they use the browsers. I think there is also a plan to have apps in browser at a later stage.
Then if I try to use only a local certificate (in "my" store) then in postman and probabl other stuff like fiddler, you need to specifically ask it to not do SSL validation, otherwise you get errors that say "couldn't get any response"

End-users are not going to use swagger, so I don't see a valid use case there. As for the applications in the browser, it still seems completely useless to use the store. HTTPS only makes sense if you try to connect to remote location. As such you would expect the client browser to be a different machine than the node, so installing a certificate into the node certificate store will not affect the client browser. I still can't see a valid use case why should we store the Certificate into the certificate store.

Is this still in progress? Will you remove the password things?

So the way this works now

there is a flag "usehttps" that one can pass as startup argument, it is false by default and no certificate is then required
if the usehttps flag is used, http:// doesn't work anymore and https:// is used instead

When Https is activated

by default the ApiFeature will look for the certificate file at StratisNode/stratis/Network/StratisApi.pfx, if it doesn't exist it will create a new one and offer the option to secure it with a password. Users will then have to manually add it to the store of their OS if they want to remove browser warnings.
alternatively, users can add an existing/trusted certificate file in the StratisNode/stratis/Network/ to use with https and pass in the argument "certificatefilename" if their certificate isn't the default StratisApi.pfx. A password will only be asked if needed.

I have tested on Windows and MacOs, it seems to work as expected

I think in the interest of simplicity, we should

not create a certificate for the user as it's not the node's business to do so (maybe a UI wrapping the node could do that in the future). If someone wants to use a certificate, they should create it and put it in the right folder and the store.
not prompt for a password and not use a password. It works very well and it's cool but in practice a password can't help the user as an attacker can just use http and the protection given by a password is voided.

testing on MacOs revealed this issue
https://github.com/dotnet/corefx/issues/31328
should I put back my changes to allow users to input password and try again ?


[BI]-Add a dashboard view for PM's monthly report.

This issue is only used for tracking, there should not have sensitive data here.

Closing this, we don't use github issue to track bi.


docs: Groom the documentation

Some of the technical docs needed to be cleaned up in terms of
how we show parameter types and default values. Various other
small corrections, too.

Looks like there could be a few more examples for alerts, or at a minimum, stop using<EMAIL_ADDRESS> That's a real address and it should be indicative of the user's email.


printerr(strToVar("string")) outputs  in console

printerr(strToVar("string")) outputs  in console. am i doing something wrong?

godot's str_to_var is like eval so to speak.
<EMAIL_ADDRESS>If you want it to work with str_to_val, the statement would be as follows.
printerr(strToVar("\"string\""))

However, if you simply want to create a Variant that represents a string, I suggest you use variant() instead.
printerr variant("string")

I've added Variant section to the Coding Quick Guide on the wiki. See also that.
https://github.com/godot-nim/gdext-nim/wiki/Coding-Quick-Guide#variant

ah ok thanks


Revert "[Feature blogpost][1.22] CSI Windows Support with CSI Proxy reaches GA"

Reverts kubernetes/website#29105
We're changing the blogpost release date to August 25, 2021
/cc @jlbutler @jingxu97

I'm going to create another PR that only updates the dates instead