feat: use fillable tx trait for rpc tx env

Renames FillableTransaction to TryFillableTransaction, and introduce an infallable trait called FillableTransaction. This replaces the tx_env_with_recovered method, which is removed.

going to wait for #6051, since I would rather deal with merge conflicts on this PR than conflicts on 6051

next steps here?

next steps here?

need to rebase and fix all the conflicts, then this should be good

@mattsse ptal

closing this because we will solve this differently


how to track custom campaign parameters?

Hi,
We have more parameters that we would like to track on Mixpanel besides these ones:

utm_source
utm_medium
utm_campaign
utm_content
utm_term

I've noticed that you have a function to track those, but it doesn't allow to add anything else.
My first thought was to monkey patch your library but that will probably cause us to fall behind on any updates you release, I wonder if there's a better way to pass the extra parameters into the mixpanel-js library to be tracked?
https://github.com/mixpanel/mixpanel-js/blob/48f217f82a114670aae873e7e0207cefa399667d/src/utils.js#L1378
Thank you,
David.

Campaign param tracking is just a lightweight convenience that the SDK offers. The params are read off the URL and saved as superproperties. You can add anything you want by calling register() or register_once().

So, if I understood correctly, it can be as simple as doing?
mixpanel.register({
  'utm_custom' : $.urlParam('utm_custom')
})

Yup, you'll want to use register_once for first-touch and register for last-touch. You may find Mixpanel's community site useful for getting answers to usage questions like these!


[resotocore][feat] Add rich console rendering and improved help

Description
Add rich console rendering and improved help

To-Dos

[x] Add test coverage for new or updated functionality
[x] Lint and test with tox

Issues Fixed

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Codecov Report

Merging #614 (d2c653b) into main (4c04f41) will increase coverage by 0.06%.
The diff coverage is 93.80%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   88.90%   88.96%   +0.06%
==========================================
  Files          63       64       +1
  Lines        8410     8504      +94
==========================================
+ Hits         7477     7566      +89
- Misses        933      938       +5

Flag
Coverage Δ

resotocore
88.96% <93.80%> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resotocore/core/cli/command.py
85.83% <50.00%> (ø)

resotocore/core/web/api.py
65.04% <86.66%> (+0.31%)
:arrow_up:

resotocore/core/cli/cli.py
88.29% <92.85%> (+0.17%)
:arrow_up:

resotocore/core/cli/model.py
96.20% <93.33%> (-0.23%)
:arrow_down:

resotocore/core/console_renderer.py
97.01% <97.01%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c04f41...d2c653b. Read the comment docs.

@lloesche I added a command line option --no-color. You should get monochrome output after setting this. Can you retry if this works better?

@aquamatthias hasn't done anything to improve the scaling performance. But terminating iTerm and restarting has. Now it's okay even with colors. No idea what caused the crazy slowdown before. Having the monochrome option is still great!


Convert adds an additional token (= token missmatch to the base model)

When I run mlx_lm.convert for berkeley-nest/Starling-LM-7B-alpha my mlx model suddenly has 32003 instead of 32002 tokens. This creates issues if you want to train and later export a .gguf file via llama.cpp
python -m mlx_lm.convert \
--hf-path berkeley-nest/Starling-LM-7B-alpha \
--mlx-path /Volumes/T9/mlx_models/starling-lm7b-alpha-8bit \
-q \
--q-group-size 64 \
--q-bits 8 \
--dtype float16

Original models added_token.json (https://huggingface.co/berkeley-nest/Starling-LM-7B-alpha/blob/main/added_tokens.json)
{
  "<|end_of_turn|>": 32000,
  "<|pad_0|>": 32001
}

added_token.json after converting it to mlx
{
  "<sep>": 32002,
  "<|end_of_turn|>": 32000,
  "<|pad_0|>": 32001
}

I think there is something to do with the HF tokenizer behavior. I can see that <sep> is in https://huggingface.co/berkeley-nest/Starling-LM-7B-alpha/blob/main/tokenizer_config.json#L55. but it doesn't exist in https://huggingface.co/berkeley-nest/Starling-LM-7B-alpha/blob/main/tokenizer.json. somehow it has been added as new special token.


New Sub-Menu Not Showing

I create a new menu with its sub-menus, but when I see it on the left menu it doesn't appear. I have made the status sub-menu ON, but when I want to give privileges to the user, the sub-menu I created does not exist.
I was checking the database on "Menus" its there.

Hello, is this still an issue or did you manage to solve it?

We have tested this sub-menu issue, its working fine as per the latest code.
You can take reference from the multilevel menu in the template sidebar, It’s working for static data.
It seems you are facing issues in getting menu items from the database.

Feel free to comment on this issue if you're still facing problems and we'll reopen.


enhancement: enables screen capturing for all views except the mnemonics

Summary
This PR disables the screen capturing just for views which display a recovery phrase or a seed.
Changelog
- Adds privacy enbale/disable function to capacitorAPI
- Enables the privacy for RecoveryPhrase, VerifyRecoveryPhrase and TextImport (onboarding)

Relevant Issues
Closes #4491
Testing
Platforms

Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[ ] Linux
[ ] Windows

Mobile

[x] iOS
[x] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...
Checklist

Please tick all of the following boxes that are relevant to your changes.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or modified tests that prove my changes work as intended
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have verified that my latest changes pass CI workflows for testing and linting
[ ] I have made corresponding changes to the documentation

@amadeu2 On my devices I'm able to do screenshots with iOS no matter if the privacy is enabled or not. Could you confirm that? I'm a bit confused about the plugin description regarding iOS: https://github.com/capacitor-community/privacy-screen

@amadeu2 On my devices I'm able to do screenshots with iOS no matter if the privacy is enabled or not. Could you confirm that? I'm a bit confused about the plugin description regarding iOS: https://github.com/capacitor-community/privacy-screen

Yes on iOS the plugin isn't working as we need, we could use userDidTakeScreenshotNotification and show the grey screen
https://developer.apple.com/documentation/uikit/uiapplication/1622966-userdidtakescreenshotnotificatio


is it possible to get rid of the default padding top on a column

i tried adding

where right is

but it didnt work.. is my syntax the problem

The property is called ´style´ but you have ´styles´ written. Its a mistake I used to make all the time, rename it and it should work.

uhm fluid option?
<Column fluid sm={1}>

That would work to remove all the padding, but I think he's just trying to remove the top padding.

I just find it inconsistent when you inline the styles on styled-components.
I think the const NewColumn = styled(Column) is more consistent code for me.


Change executable and tool templates to use main.swift

The recent changes to templates switched these templates away from using @main which seems to not be compatible with Xcode's build system. The only non-@main way for executables that is supported is naming the primary source file "main.swift", so that is what this PR does.

@swift-ci please smoke test

@swift-ci please smoke test


Details component enter key only fires in IE if contained within a form

If you focus on the <details> element on https://design-system.service.gov.uk/components/details/default/index.html within Internet Explorer (eg IE11) and then press [Space] or [Enter], the component opens/closes.
However, if the <details> element is not contained within a <form> element (as it is on that example page), then only the [Space] key works, but not the [Enter] key.
This seems to be down to a longstanding bug/feature within Internet Explorer which is that [Enter] keypress do not fire on elements (other than buttons) unless they are contained within a form. See conversation on this bug reported to angular.js.
Possible fixes:

Wrap each <details> element in a <form> element. Not ideal, as you'd have to only do this if it wasn't already within a form.
Add some logic within the handle inputs polyfill to fire the click event from within the keyup listener (but only if not already fired from the keypress listener).

When visiting https://govuk-frontend-review.herokuapp.com/components/details/preview in Internet Explorer 11 and pressing 'enter' I see the details open and close.
This is using browserstack so might be some weirdness there, do you see something different?

@nickcolley hmm, yes, that works for me too in IE11 / browserstack.
But the bug can still be found here: https://www.ethnicity-facts-figures.service.gov.uk/culture-and-community/community/feeling-of-belonging-to-britain/latest (eg the "Things you need to know" details component).
Strange!


PDF: Enable whole of project book style PDF

This PR enables a whole of project book style PDF

the index_toc document should be passed in as a configuration variable to indicate which document contains the book toc for pdf

thanks @AakashGfude the testing is looking good -- I had waited for some changes in the python lecture repository such as a change to index but the extension handled these changes nicely.
I just need to fix CI and then I will merge these changes into master and release 0.5.2 with book support.

[ ] @mmcky fix travis testing

[ ] test for book is not setup but will merge this once CI is green and add that test in later.

fixes #277

the need to update docs has been captured by #302


The number of grammar rules (94) is inconsistent with the pre-trained model (97)

I find that the number of the grammar rules is 94 when I follow the instructions to preprocess the data (with the hyper-parameter fs=2). But the size of rule_embedding in the pre-trained model is 97.
Traceback (most recent call last):
File "run.py", line 104, in
main()
File "run.py", line 83, in main
infer.main(infer_config)
File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/commands/infer.py", line 239, in main
model = inferer.load_model(args.logdir, args.step)
File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/commands/infer.py", line 48, in load_model
last_step = saver.restore(logdir, step=step, map_location=self.device, item_keys=["model"])
File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/utils/saver.py", line 122, in restore
items2restore, model_dir, map_location, step)
File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/utils/saver.py", line 40, in load_checkpoint
item_dict[item_name].load_state_dict(checkpoint[item_name])
File "/home/yuhao/.conda/envs/zhenwen/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1407, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for EncDecModel:
Unexpected key(s) in state_dict: "decoder.state_update._input_dropout_mask", "decoder.state_update._h_dropout_mask".
size mismatch for decoder.rule_logits.2.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([94, 128]).
size mismatch for decoder.rule_logits.2.bias: copying a param with shape torch.Size([97]) from checkpoint, the shape in current model is torch.Size([94]).
size mismatch for decoder.rule_embedding.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([94, 128])

Can you solve this problem? I had the same problem.
Looking forward to the reply.

Can you solve this problem? I had the same problem like yours:
Traceback (most recent call last):
File "run.py", line 104, in
main()
File "run.py", line 66, in main
train.main(train_config)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/commands/train.py", line 270, in main
trainer.train(config, modeldir=args.logdir)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/commands/train.py", line 135, in train
last_step = saver.restore(modeldir, map_location=self.device)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/utils/saver.py", line 122, in restore
items2restore, model_dir, map_location, step)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/utils/saver.py", line 40, in load_checkpoint
item_dict[item_name].load_state_dict(checkpoint[item_name], False)
File "/home/zrs/anaconda3/envs/gap-text2sql/lib/python3.7/site-packages/torch/nn/modules/module.py", line 847, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for EncDecModel:
size mismatch for encoder.question_encoder.0.embedding.weight: copying a param with shape torch.Size([1580, 300]) from checkpoint, the shape in current model is torch.Size([164, 300]).
size mismatch for encoder.column_encoder.0.embedding.weight: copying a param with shape torch.Size([1580, 300]) from checkpoint, the shape in current model is torch.Size([164, 300]).
size mismatch for encoder.table_encoder.0.embedding.weight: copying a param with shape torch.Size([1580, 300]) from checkpoint, the shape in current model is torch.Size([164, 300]).
size mismatch for decoder.rule_logits.2.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([75, 128]).
size mismatch for decoder.rule_logits.2.bias: copying a param with shape torch.Size([97]) from checkpoint, the shape in current model is torch.Size([75]).
size mismatch for decoder.rule_embedding.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([75, 128]).
size mismatch for decoder.node_type_embedding.weight: copying a param with shape torch.Size([55, 64]) from checkpoint, the shape in current model is torch.Size([49, 64]).
Looking forward to the reply.

I find that the number of the grammar rules is 94 when I follow the instructions to preprocess the data (with the hyper-parameter fs=2). But the size of rule_embedding in the pre-trained model is 97.
Traceback (most recent call last): File "run.py", line 104, in main() File "run.py", line 83, in main infer.main(infer_config) File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/commands/infer.py", line 239, in main model = inferer.load_model(args.logdir, args.step) File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/commands/infer.py", line 48, in load_model last_step = saver.restore(logdir, step=step, map_location=self.device, item_keys=["model"]) File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/utils/saver.py", line 122, in restore items2restore, model_dir, map_location, step) File "/home/yuhao/zhenwen/repair_model/gap-text2sql-main/rat-sql-gap/seq2struct/utils/saver.py", line 40, in load_checkpoint item_dict[item_name].load_state_dict(checkpoint[item_name]) File "/home/yuhao/.conda/envs/zhenwen/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1407, in load_state_dict self.class.name, "\n\t".join(error_msgs))) RuntimeError: Error(s) in loading state_dict for EncDecModel: Unexpected key(s) in state_dict: "decoder.state_update._input_dropout_mask", "decoder.state_update._h_dropout_mask". size mismatch for decoder.rule_logits.2.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([94, 128]). size mismatch for decoder.rule_logits.2.bias: copying a param with shape torch.Size([97]) from checkpoint, the shape in current model is torch.Size([94]). size mismatch for decoder.rule_embedding.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([94, 128])

Can you solve this problem? I had the same problem like yours:
Traceback (most recent call last):
File "run.py", line 104, in
main()
File "run.py", line 66, in main
train.main(train_config)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/commands/train.py", line 270, in main
trainer.train(config, modeldir=args.logdir)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/commands/train.py", line 135, in train
last_step = saver.restore(modeldir, map_location=self.device)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/utils/saver.py", line 122, in restore
items2restore, model_dir, map_location, step)
File "/home/zrs/gap-text2sql/rat-sql-gap/seq2struct/utils/saver.py", line 40, in load_checkpoint
item_dict[item_name].load_state_dict(checkpoint[item_name], False)
File "/home/zrs/anaconda3/envs/gap-text2sql/lib/python3.7/site-packages/torch/nn/modules/module.py", line 847, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for EncDecModel:
size mismatch for encoder.question_encoder.0.embedding.weight: copying a param with shape torch.Size([1580, 300]) from checkpoint, the shape in current model is torch.Size([164, 300]).
size mismatch for encoder.column_encoder.0.embedding.weight: copying a param with shape torch.Size([1580, 300]) from checkpoint, the shape in current model is torch.Size([164, 300]).
size mismatch for encoder.table_encoder.0.embedding.weight: copying a param with shape torch.Size([1580, 300]) from checkpoint, the shape in current model is torch.Size([164, 300]).
size mismatch for decoder.rule_logits.2.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([75, 128]).
size mismatch for decoder.rule_logits.2.bias: copying a param with shape torch.Size([97]) from checkpoint, the shape in current model is torch.Size([75]).
size mismatch for decoder.rule_embedding.weight: copying a param with shape torch.Size([97, 128]) from checkpoint, the shape in current model is torch.Size([75, 128]).
size mismatch for decoder.node_type_embedding.weight: copying a param with shape torch.Size([55, 64]) from checkpoint, the shape in current model is torch.Size([49, 64]).
Looking forward to the reply.


Make huggingface bert example use transformers v4

Signed-off-by: Jonathan Chang<EMAIL_ADDRESS>

Hi, this changes affect many other parts, like tests/bert/th_bert_unit_test.py.


V86.prototype.update_file(..) ?

I've noticed that this (awesome) project has V86.prototype.read_file() and V86.prototype.write_file().
However, calling write_file twice will not persist the inode (I want to update a file from javascript which is being monitored by tail -f).
Is this a usecase for adding V86.prototype.update_file()?
Or is there another way I can write from javascript to the filesystem (stream to a named pipe?)
As a (slow) workaround for now, I'm monitoring a file in the background (shellscript) and write changes to a named pipe (monitored by tail -f
Anyways, FOSS FTW & keep up the good work ❤

fwiw, the clunky v86pipe shellscript I wrote which allows tailing files (updated by write_file()) indirectly via a (tailable) named pipe:
#!/bin/sh
#
# this daemon allows 'tail -f' on v86 files (which don't persist inode when updated
# via javascript)
# more info see: https://github.com/copy/v86/issues/1140
#
# Hopefully as V86 (or my understanding of it) matures, this will be no longer needed

test -z $2 && { echo "usage: v86pipe <logfile> <namedpipe>"; exit 0; }

# Start reading from the last line in the log file
last_size=0
LOG_FILE=$1
LOG_PIPE=$2

test -f $LOG_FILE || touch $LOG_FILE
test -p $LOG_PIPE || mkfifo $LOG_PIPE

while true; do
    # Get the current size of the file using wc -c (count bytes)
    current_size=$(wc -c < $LOG_FILE)

    if [ "$current_size" -gt "$last_size" ]; then
        # If the file has grown, read the new content and send it to the pipe
        tail -c +$((last_size + 1)) $LOG_FILE >> $LOG_PIPE
        last_size=$current_size
    fi

    # Sleep for a moment to avoid excessive CPU usage
    sleep 0.2
done

Example
$ v86pipe /mnt/log.txt log &
$ tail -f log

Now write_file('log.txt', ....) will make tail -f work as expected.

Did you look at #530? This uses a hook with the emulator.fs9p.Read() function.

Thank you!
I started to fiddle (unsuccesfully) with .Read() too, and gave up.
Seeing your (referenced) issue is exactly what I wanted.
On Thu, Sep 5, 2024 at 8:30 AM SuperMaxusa @.***> wrote:

Did you look at #530 https://github.com/copy/v86/issues/530? This uses
a hook with the emulator.fs9p.Read() function.
—
Reply to this email directly, view it on GitHub
https://github.com/copy/v86/issues/1140#issuecomment-2330706372, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABL6ZD7X7DPJBX3VGJNZYDZU73BJAVCNFSM6AAAAABNKAYTSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQG4YDMMZXGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
L Ξ Ο N   V Λ N   Κ Λ Μ Μ Ξ N
Creative technologist & researcher #FOSS #commons
▹ @@.*** @.***> (fediverse)
▹ http://leon.freshrss.isvery.ninja (aggregated RSS feed of activities)
▹ https://2wa.isvery.ninja
▹ https://x.com/coderofsalvatio
▹ https://www.linkedin.com/in/leonvankammen

I think this feature request is reasonable, but I don't like adding update_file to the public API of v86 (and thus committing to maintaining and not breaking the API).
Since there are several workarounds (such as using emulator.fs9p directly), I will close this issue.


"vitest run --watch" does not work correctly.

Describe the bug
Sorry, The previous issue was closed, so I had to create one again.
Here is my use case:
I'm using monorepo, and I wrote a script in the package.json of subdirectory: "test": "vitest run --passWithNoTests --andSomeOtherArgs"
For me, run is necessary because I want the npm test command can exit normally in root directory.
But when in a subdirectory, I hope to be able to temporarily enable watch mode instead of writing a script, For example, passing a --watch parameter to npm test command. But it not works.
I think it's probably a bug, otherwise — what's the use of the --watch parameter？
Reproduction
Just run the command: npx vitest run --watch
System Info
System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 203.06 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.volta/tools/image/node/20.11.1/bin/node
    Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 10.2.4 - ~/.volta/tools/image/node/20.11.1/bin/npm
    pnpm: 8.15.3 - ~/Library/pnpm/pnpm
    bun: 1.0.18 - ~/.bun/bin/bun
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 122.0.6261.129
    Safari: 17.2.1
  npmPackages:
    vitest: ^1.2.1 => 1.3.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

The default mode is the watch mode, what is the meaning of the --watch parameter?

It is default in non CI-environments. You can force watch mode with this flag if Vitest wrongly thought you are running in CI, or it you need to run watch mode in CI for some reason.


Multiple collapse group items (parent and children) - not working

When I want to create collapsing group item like is written in this example - http://v4-alpha.getbootstrap.com/components/collapse/#accordion-example but with that difference - to have much more multiple levels - it doesn't work. Everytime when I'm opening child level and their content, it is covered by parent on top level. When I tried to changed version of Bootstrap to 3.3.5, it worked.
For better explanation - here is example what is working in 3.3.5 and not in v4 alpha. Could you please fix it somehow? :) http://www.bootply.com/vlLkd53dZb
Edit: I'm using v4-alpha version

Hi @dejwne!
You appear to have posted a live example (http://s.bootply.com/render/vlLkd53dZb), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 60, column 21: E023: .panel-body must have a .panel or .panel-collapse parent
line 61, column 25: E026: .panel-title must have a .panel-heading parent
line 10, column 9: W013: Bootstrap version might be outdated. Latest version is at least 3.3.5 ; saw what appears to be usage of Bootstrap 3.2.0
line 128, column 9: W013: Bootstrap version might be outdated. Latest version is at least 3.3.5 ; saw what appears to be usage of Bootstrap 3.2.0

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

@dejwne Please fix the above problems in your example.


Set CDQ only for current source

Fixes
https://issues.redhat.com/browse/HAC-1984

Description
Set & return the CDQ only for the provided source.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
https://user-images.githubusercontent.com/20013884/186921549-e7d26d25-a8f5-4f27-a2c4-5181bdfc9e15.mp4

How to test or reproduce?
Select sample multiple times in the sample selection page.

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/cc @sahil143


ripgrep (rg) requires vcruntime140 (Visual C++ Redistributable)

rg doesn't work after installing it, because of a missing dependency "vcruntime140.dll".

Does scoop install extras/vscredist afterwards allow rg to work?

Yes, it works. In fact, vcredist2015 is enough, no need all versions


Cadence incongruity when bike goes from zero cadence to non-zero

After a period of time sitting at zero cadence, the first non-zero cadence update will generate a bunch of pedal events:
Oct 04 22:01:07 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:07.171Z] pinging app since no pedal strokes for 6s
Oct 04 22:01:07 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:07.262Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:07 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:07.858Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:08 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:08.163Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:08 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:08.768Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:09 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:09.374Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:09 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:09.678Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:10 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:10.284Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:10 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:10.890Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.201Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.808Z] received stats from bike [power=1W cadence=15rpm]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.815Z] pedal stroke [timestamp=1601863043002.3733 revolutions=210 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.821Z] pedal stroke [timestamp=1601863047002.3733 revolutions=211 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.828Z] pedal stroke [timestamp=1601863051002.3733 revolutions=212 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.834Z] pedal stroke [timestamp=1601863055002.3733 revolutions=213 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.839Z] pedal stroke [timestamp=1601863059002.3733 revolutions=214 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.845Z] pedal stroke [timestamp=1601863063002.3733 revolutions=215 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.851Z] pedal stroke [timestamp=1601863067002.3733 revolutions=216 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.857Z] pedal stroke [timestamp=1601863071002.3733 revolutions=217 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.863Z] pedal stroke [timestamp=1601863075002.3733 revolutions=218 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.868Z] pedal stroke [timestamp=1601863079002.3733 revolutions=219 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.873Z] pedal stroke [timestamp=1601863083002.3733 revolutions=220 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.879Z] pedal stroke [timestamp=1601863087002.3733 revolutions=221 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.885Z] pedal stroke [timestamp=1601863091002.3733 revolutions=222 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.893Z] pedal stroke [timestamp=1601863095002.3733 revolutions=223 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.901Z] pedal stroke [timestamp=1601863099002.3733 revolutions=224 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.906Z] pedal stroke [timestamp=1601863103002.3733 revolutions=225 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.912Z] pedal stroke [timestamp=1601863107002.3733 revolutions=226 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.918Z] pedal stroke [timestamp=1601863111002.3733 revolutions=227 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.921Z] pedal stroke [timestamp=1601863115002.3733 revolutions=228 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.926Z] pedal stroke [timestamp=1601863119002.3733 revolutions=229 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.931Z] pedal stroke [timestamp=1601863123002.3733 revolutions=230 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.935Z] pedal stroke [timestamp=1601863127002.3733 revolutions=231 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.939Z] pedal stroke [timestamp=1601863131002.3733 revolutions=232 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.943Z] pedal stroke [timestamp=1601863135002.3733 revolutions=233 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.947Z] pedal stroke [timestamp=1601863139002.3733 revolutions=234 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.951Z] pedal stroke [timestamp=1601863143002.3733 revolutions=235 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.955Z] pedal stroke [timestamp=1601863147002.3733 revolutions=236 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.959Z] pedal stroke [timestamp=1601863151002.3733 revolutions=237 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.963Z] pedal stroke [timestamp=1601863155002.3733 revolutions=238 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.967Z] pedal stroke [timestamp=1601863159002.3733 revolutions=239 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.971Z] pedal stroke [timestamp=1601863163002.3733 revolutions=240 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.975Z] pedal stroke [timestamp=1601863167002.3733 revolutions=241 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.979Z] pedal stroke [timestamp=1601863171002.3733 revolutions=242 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.983Z] pedal stroke [timestamp=1601863175002.3733 revolutions=243 power=1W]
Oct 04 22:01:11 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:11.987Z] pedal stroke [timestamp=1601863179002.3733 revolutions=244 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.001Z] pedal stroke [timestamp=1601863183002.3733 revolutions=245 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.006Z] pedal stroke [timestamp=1601863187002.3733 revolutions=246 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.011Z] pedal stroke [timestamp=1601863191002.3733 revolutions=247 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.015Z] pedal stroke [timestamp=1601863195002.3733 revolutions=248 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.022Z] pedal stroke [timestamp=1601863199002.3733 revolutions=249 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.032Z] pedal stroke [timestamp=1601863203002.3733 revolutions=250 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.036Z] pedal stroke [timestamp=1601863207002.3733 revolutions=251 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.039Z] pedal stroke [timestamp=1601863211002.3733 revolutions=252 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.054Z] pedal stroke [timestamp=1601863215002.3733 revolutions=253 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.057Z] pedal stroke [timestamp=1601863219002.3733 revolutions=254 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.061Z] pedal stroke [timestamp=1601863223002.3733 revolutions=255 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.086Z] pedal stroke [timestamp=1601863227002.3733 revolutions=256 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.092Z] pedal stroke [timestamp=1601863231002.3733 revolutions=257 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.106Z] pedal stroke [timestamp=1601863235002.3733 revolutions=258 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.114Z] pedal stroke [timestamp=1601863239002.3733 revolutions=259 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.159Z] pedal stroke [timestamp=1601863243002.3733 revolutions=260 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.177Z] pedal stroke [timestamp=1601863247002.3733 revolutions=261 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.189Z] pedal stroke [timestamp=1601863251002.3733 revolutions=262 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.219Z] pedal stroke [timestamp=1601863255002.3733 revolutions=263 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.227Z] pedal stroke [timestamp=1601863259002.3733 revolutions=264 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.231Z] pedal stroke [timestamp=1601863263002.3733 revolutions=265 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.249Z] pedal stroke [timestamp=1601863267002.3733 revolutions=266 power=1W]
Oct 04 22:01:12 gymnasticon gymnasticon[1805]: [2020-10-05T02:01:12.262Z] pedal stroke [timestamp=1601863271002.3733 revolutions=267 power=1W]

An initial readthrough of src/app/simulation.js leads me to believe this has to do with the early return in schedulePedal(), but I'd need to tease through this logic a bit more directly.

Added some logging -- we're passing a nextPedalTime that ends up being in the past, which causes these to rapid-fire through.
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.185Z] received stats from bike [power=0W cadence=0rpm]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.490Z] received stats from bike [power=0W cadence=25rpm]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>497 timeSinceLast: 43374.333251953125 nextPedalTime:<PHONE_NUMBER>522.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.504Z] pedal stroke [timestamp=1601864132522.6667 revolutions=3 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>509 timeSinceLast: 40986.333251953125 nextPedalTime:<PHONE_NUMBER>922.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.515Z] pedal stroke [timestamp=1601864134922.6667 revolutions=4 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>520 timeSinceLast: 38597.333251953125 nextPedalTime:<PHONE_NUMBER>322.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.526Z] pedal stroke [timestamp=1601864137322.6667 revolutions=5 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>530 timeSinceLast: 36207.333251953125 nextPedalTime:<PHONE_NUMBER>722.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.537Z] pedal stroke [timestamp=1601864139722.6667 revolutions=6 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>542 timeSinceLast: 33819.333251953125 nextPedalTime:<PHONE_NUMBER>122.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.548Z] pedal stroke [timestamp=1601864142122.6667 revolutions=7 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>553 timeSinceLast: 31430.333251953125 nextPedalTime:<PHONE_NUMBER>522.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.559Z] pedal stroke [timestamp=1601864144522.6667 revolutions=8 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>563 timeSinceLast: 29040.333251953125 nextPedalTime:<PHONE_NUMBER>922.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.570Z] pedal stroke [timestamp=1601864146922.6667 revolutions=9 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>575 timeSinceLast: 26652.333251953125 nextPedalTime:<PHONE_NUMBER>322.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.580Z] pedal stroke [timestamp=1601864149322.6667 revolutions=10 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>586 timeSinceLast: 24263.333251953125 nextPedalTime:<PHONE_NUMBER>722.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.593Z] pedal stroke [timestamp=1601864151722.6667 revolutions=11 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>596 timeSinceLast: 21873.333251953125 nextPedalTime:<PHONE_NUMBER>122.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.602Z] pedal stroke [timestamp=1601864154122.6667 revolutions=12 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>605 timeSinceLast: 19482.333251953125 nextPedalTime:<PHONE_NUMBER>522.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.610Z] pedal stroke [timestamp=1601864156522.6667 revolutions=13 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>613 timeSinceLast: 17090.333251953125 nextPedalTime:<PHONE_NUMBER>922.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.618Z] pedal stroke [timestamp=1601864158922.6667 revolutions=14 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>621 timeSinceLast: 14698.333251953125 nextPedalTime:<PHONE_NUMBER>322.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.626Z] pedal stroke [timestamp=1601864161322.6667 revolutions=15 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>629 timeSinceLast: 12306.333251953125 nextPedalTime:<PHONE_NUMBER>722.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.633Z] pedal stroke [timestamp=1601864163722.6667 revolutions=16 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>636 timeSinceLast: 9913.333251953125 nextPedalTime:<PHONE_NUMBER>122.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.641Z] pedal stroke [timestamp=1601864166122.6667 revolutions=17 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>644 timeSinceLast: 7521.333251953125 nextPedalTime:<PHONE_NUMBER>522.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.649Z] pedal stroke [timestamp=1601864168522.6667 revolutions=18 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>652 timeSinceLast: 5129.333251953125 nextPedalTime:<PHONE_NUMBER>922.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.656Z] pedal stroke [timestamp=1601864170922.6667 revolutions=19 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>659 timeSinceLast: 2736.333251953125 nextPedalTime:<PHONE_NUMBER>322.6667
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:13.664Z] pedal stroke [timestamp=1601864173322.6667 revolutions=20 power=0W]
Oct 04 22:16:13 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>667 timeSinceLast:<PHONE_NUMBER>53125 nextPedalTime:<PHONE_NUMBER>722.6667
Oct 04 22:16:14 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:14.098Z] received stats from bike [power=3W cadence=24rpm]
Oct 04 22:16:14 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>102 timeSinceLast:<PHONE_NUMBER>53125 nextPedalTime:<PHONE_NUMBER>822.6667
Oct 04 22:16:14 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:14.700Z] received stats from bike [power=3W cadence=24rpm]
Oct 04 22:16:14 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>705 timeSinceLast: 1382.333251953125 nextPedalTime:<PHONE_NUMBER>822.6667
Oct 04 22:16:15 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:15.003Z] received stats from bike [power=3W cadence=24rpm]
Oct 04 22:16:15 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>009 timeSinceLast: 1686.333251953125 nextPedalTime:<PHONE_NUMBER>822.6667
Oct 04 22:16:15 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:15.609Z] received stats from bike [power=3W cadence=23rpm]
Oct 04 22:16:15 gymnasticon gymnasticon[1946]: now:<PHONE_NUMBER>620 timeSinceLast: 2297.333251953125 nextPedalTime:<PHONE_NUMBER>931.3623
Oct 04 22:16:15 gymnasticon gymnasticon[1946]: [2020-10-05T02:16:15.936Z] pedal stroke [timestamp=1601864175931.3623 revolutions=21 power=3W]

Initial testing of clamping nextPedalTime looks like a good call for now - only did one test ride to confirm for now, need to think through how we can add some tests around this behavior.
src/app/simulation.js
62:     let nextPedalTime = Math.max(now, (now - timeSinceLast + this._interval));

Thanks for reporting this! I agree it would be good to add some tests here. I'll have a look at pushing out this fix tomorrow morning.

I just pushed up #18 but can't actually test it with a bike right now. I think it should fix this issue, hopefully also the Garmin issue you mentioned earlier, and also adds some tests around pedal timestamps and cadence changes. As soon as I have a chance to test it properly I'll push out a fix -- if you have a chance in the meantime, let me know how it goes!

Initial test last night looked good.

Nice, just tested here too and looks good.


fix regression tests 934130-6 title duplicate

Simple changes.

Good catch - thank you, and welcome your first contributing!


arch/x86: reorganization ahead of Grand Unification

This patch consists of the simple addition of a config flag, CONFIG_X86_LONGMODE, and re-organizing the x86 arch files.  The idea is to create a structure to bring x86 and x86_64 support under the same umbrella, as subarchitectures or variants of the same arch, rather than completely separate arches.
There are no functional changes.  No actual 64-bit code is yet migrated.
I'm putting in this PR now to prevent merge headaches as changes continue to be made to the existing x86 sources, as moving things around in this way is somewhat intrusive.

Force-pushed to rebase due to merge conflict.


Add Type Hints to image/init.py

I wanted to fix https://github.com/pyglet/pyglet/issues/787 so I type hinted it.

NOT done

Ok. Are you the only one reviewing pyglet PRs.
On Wed, May 24, 2023 at 2:03 AM Benjamin @.***> wrote:

Pardon the delay, but it's quite challenging to review this PR. There are
many mistakes, and it takes a lot of time to review manually. I added a few
more comments for issues that I found. There are also several issues that
appear all throughout, but I did not comment them.

Many of the classmethods are wrong. cls should be the actual object of
the class that will be returned, but it's often shown as AbstractImage.
This might pass a type checker, but it's returning the subclass is more
accurate.
2.
There are many unnecessary docstring breaks. All docstrings should
start on the same line as the triple quotes for compactness. For example:
def function():
"""This is preferreddef function():    """
Not this

Many functions are unnecessarily wrapped. pyglet adheres to PEP8,
with the exception of a relaxed line length limit. It's acceptable (and
preferred) to allow function definitions to reach 100 (or up to 110)
columns, rather than splitting to multiple lines.

—
Reply to this email directly, view it on GitHub
https://github.com/pyglet/pyglet/pull/818#issuecomment-1560727336, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ATHLIH7HGS5QINI6F3FVYDDXHXFFZANCNFSM6AAAAAAXRGF2NM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Failed using gpu when training at google colab

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
No
OS Platform and Distribution
Linux ubuntu 22.04
Python Version
3.10.12
MediaPipe Model Maker version
No response
Task name (e.g. Image classification, Gesture recognition etc.)
Object Detection
Describe the actual behavior
Cannot detect GPU because its install new tensorflow version
Describe the expected behaviour
Google colab must be have preinstalled tensorflow that can use for GPU, but when install mediapipe-model-maker using pip its also install new version of tensorflow and uninstalling the old one
Standalone code/steps you may have used to try to get what you need
Just run command at google colab

!pip install mediapipe-model-maker

Other info / Complete Logs
No response

Hi @schmidt-sebastian,
I was able to replicate the issue on our end. As reported by @AlifAbhiesa, the GPU is not being detected following the installation of the MediaPipe Model Maker. Please refer to the Colab gist for a more comprehensive understanding.
Thank you

You need to use a Colab instead that has CUDA drivers and an X-Server running.

You need to use a Colab instead that has CUDA drivers and an X-Server running.

Whan do you mean colab with cuda? Is for enable CUDA just change the runtime into GPU right? I've done with it, but still cause new version of tensorflow cuda not detected

Hi @schmidt-sebastian,
I was able to replicate the issue on our end. As reported by @AlifAbhiesa, the GPU is not being detected following the installation of the MediaPipe Model Maker. Please refer to the Colab gist for a more comprehensive understanding.
Thank you

Is there any proper solution for this?

Hi @AlifAbhiesa,
This issue is fixed. After installing the MediaPipe model maker, the GPU is now being detected(Gist). Please check to see if the issue persists on your end and let us know.
Thank you

Hi @AlifAbhiesa,
Could you kindly review the preceding comment and provide us with an update?
Thank you!!


Batch.complete typo?

batch.complete? and batch.status.complete? are returning opposite values. I'm assuming this is not supposed to be the case?
https://github.com/emailable/emailable-ruby/blob/57b9746506089ed68c9dd25e2c4edcf89c8d0176/lib/emailable/batch.rb#L42-L44

Thanks for bringing this to our attention. This has been fixed in 3.2.0.


{{trigger.to_state.entity_id}} removes underscores & {{trigger.entity_id}} only works in if statements not in a telegram message

I have these problems as discussed here and think it might me an issue: https://community.home-assistant.io/t/trigger-entity-id-not-working-as-expected/78842
In summary:
My entity_id is called: light.kitchen_node_1_led_light_1
3 Problems:
1)
{{trigger.to_state.entity_id}} when sent in a telegram message sends light.kitchennode1ledlight1,it removes the underscores.
2)
trigger.entity_id is working when used in an if statement but not when I want to send it as a telegram message with {{trigger.entity_id}}
3)
entity_id is always sent without an underscore, but when you want to use it in an if statement you have to use underscore in order to get a true if statement.
____Working: {% if trigger.entity_id == 'light.kitchen_node_1_led_light_1' %}
Not working: {% if trigger.entity_id == 'light.kitchennode1ledlight1' %}
____Working: {% if trigger.from_state.entity_id == 'light.kitchen_node_1_led_light_1' %}
Not working: {% if trigger.from_state.entity_id == 'light.kitchennode1ledlight1' %}
____Working: {% if trigger.event.data.data == '/dafang_1_get_1_snapshot' %}
Not working: {% if trigger.event.data.data == '/dafang1get2snapshots' %}
More detail:
Works:
  {% if trigger.entity_id == 'light.kitchen_node_1_led_light_1' %}
  7: with underscore
  {% endif %}

sends: 7: with underscore
Not working:
  {% if trigger.entity_id == 'light.kitchennode1ledlight1' %}
  7: without underscore
  {% endif %}

sends an empty line
When I use trigger.from_state.entity_id instead of trigger.entity_id the same happens.
Telegram callback:
I am also using telegram callback, same thing here:
The callback is waiting to receive : /dafang_1_get_1_snapshot
in message {{trigger.event.data.data}} telegram sends /dafang1get1snapshot
Works:
   {% if trigger.event.data.data == '/dafang_1_get_1_snapshot' %}
   with underscore
   {% endif %}

sends: with underscore
Not working:
  {% if trigger.event.data.data == '/dafang1get2snapshots' %}
  without underscore
  {% endif %}

sends an empty line

I tried more and discovered that underscores also don`t work in telegram messages, the message never gets send.
I put a -  and {{ '_' }} in the message.
- not working
Error:
Error sending message: Can't parse entities: can't find end of the entity starting at byte offset 27. Args: (373476846, 'Kitchen LED Light\n⚫ OFF _'), kwargs: {'parse_mode': 'Markdown', 'disable_notification': False, 'disable_web_page_preview': None, 'reply_to_message_id': None, 'reply_markup': None, 'timeout': None}
byte offset 27 is the underscore.
{{ '_' }} not working
No double double quotes because it use them around the whole message.
Error:
Can't parse entities: can't find end of the entity starting at byte offset 27. Args: (373476846, 'Kitchen LED Light\n⚫ OFF _'), kwargs: {'parse_mode': 'Markdown', 'disable_notification': False, 'disable_web_page_preview': None, 'reply_to_message_id': None, 'reply_markup': None, 'timeout': None}
It might be a problem with the telegram component or telegram itself.

OK. I got an answer from mebers of the homeassistant community.
I will just poste their answers here.
https://community.home-assistant.io/t/trigger-entity-id-not-working-as-expected/78842/15?u=naitsimp

Try parse_mode html for your telegram component. You’re currently using markdown as your parse mode and it doesn’t like uneven numbers of underscores.

https://community.home-assistant.io/t/trigger-entity-id-not-working-as-expected/78842/16?u=naitsimp

So I’m guessing underscores mean something in markdown for telegram.
@naitsimp, that’s why your entity id’s are getting changed, and its on telegrams side. So the underscores are actually there, it’s just that markdown is suppressing them.
EDIT: FYI I debugged into telegram and it does not doctor your messages. It just passes them through. So this is 100% on the telegram side.


CG fix for AzureWebAppV1

Task name: AzureWebAppV1
Description: CG fix
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run


General API requests module created

What -

This is a single API request module built using angular2's http.
From now on we can use this module instead of direct http in services for API requests.

Why -

With the growing code base we'll have n number of services with time.
In future if we decide to use something else other than angular's http we just have to edit one file.
To remove code redundency.

This change is

@joshuawilson  @aslakknutsen please review.

@aslakknutsen have a look at the second commit. This is not nicer, but this is the only way I could find to pass external parameters in a provider's constructor. It looks like Angular2 only allows injectors to instantiate another provider in a constructor. So I had to create a provider class Keys and using injector I instantiate it in Requests constructor. I tried almost all the possible way other than this, nothing seems work. This commit is just for testing purpose. Once you are done testing, I can reset the head for now.
CC: @joshuawilson

@sanbornsen @nimishamukherjee is doing this as part of the Login work. Not sure what her solution is, but.. ?

Yes, so she is doing the same thing. She has created an authentication service provider, just like I created a keys provider for an example.

@michaelkleinhenz can you please review this PR?

I think this should be done as a service. I am also always careful when introducing new layers of abstraction. In this case, it might be reasonable to have something like this, but I would definitely wait until we have a stable understanding on how authentication will work. As Aslak mentioned, this will definitely have an impact on how we should do things here.

We can make it as a service, and every other service will use it as a Request Service. Actually it is a service, just it doesn't follow the naming and positioning conventions.
As I replied earlier in this thread, yes we can pass multiple parameters i.e. headers inside the constructor for authentication and any other operation using another service provider and instantiate it into this service's constructor.


 Here I'm explaining what the bug was along with its root cause.
Then I'm explaining how I fixed it.

Signed-off-by: FirstName LastName <email address>

Fixes: https://github.com/instructlab/instructlab/issues/1096
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

@leseb I think this is something we need to discuss as a policy before creating an action to enforce it

@leseb putting a hold on this for now as the issue is in discussion

Where is the discussion? It's not on the issue ...

I'd like to leave this open for feedback from others on they feel this lands on the spectrum of "helpful improvement to consistency" to "would drive me crazy".
I'm not opposed necessarily -- just want to make sure there's good support

Agree with @hickeyma and @bjhargrave

Thank you all for your input! This has been a great discussion. I understand the challenge of balancing consistency with avoiding micromanagement. However, we already have the DCO bot handling some of this micromanagement. Implementing another bot would further relieve maintainers from repeatedly requesting well-formatted messages, helping users adhere to our guidelines more easily. Enforcing this at the CI level is crucial for maintaining consistency and ensuring a clear commit history as we move toward production. Contributing to a project involves more than just writing code; it includes following the contribution guidelines.
This is my final attempt to convince you all 😅  Thanks again for reading!

Signed-off-by is a legal necessity so the DCO bot confirms we have the IP rights to contributions. That is a different level than the format of the other text in the commit comment ✌🏻

Alright, looks like the "people have spoken", I'm closing this and hoping that maintainers will continue to pay attention to commit messages :). Thanks!


SpatialObjectDetector doesn't produce spatial coordinates.

@themarpe Referenced from #651
As reported, we had depth images going into the spatial object detector, however in upgrade to 2.19.1 these lost all spatial coordinate information. I did confirm that a valid depth image was being linked into the spatial object detector.
I was getting alignment warnings
[1944301051BBED1200] [1.5] [60.628] [SpatialDetectionNetwork(15)] [warning] Neural network inference was performed on socket 'RGB', depth frame is aligned to socket 'RIGHT'. Bounding box mapping will not be correct, and will lead to erroneus spatial values. Align depth map to socket 'RGB' using 'setDepthAlign'.
book: 67.93
book: 67.80
book: 67.54
book: 58.83
book: 53.12
book: 49.90
book: 46.88
book: 46.09
book: 45.95
book: 45.51
book: 43.68
[1944301051BBED1200] [1.5] [60.701] [SpatialDetectionNetwork(15)] [warning] Neural network inference was performed on socket 'RGB', depth frame is aligned to socket 'RIGHT'. Bounding box mapping will not be correct, and will lead to erroneus spatial values. Align depth map to socket 'RGB' using 'setDepthAlign'.

Until I made the depth aligment to the RGB Socket whereupon, the spatial information was sometimes populated.
I hate to raise a second issue in this but aligning depth to the RGB socket is not a simple issue, as the depth image resolution changes to the same size as the RGB camera. This is addressed in the spatial object detector examples by resizing it to the mono cameras, but I don't see why changing the socket alignment should resize the depth image.
How does the spatial detector handle NAN in the depth information?

I'm also not sure it post processing filters that were working, particularly a decimation filter, still are applied, I think they are as the depth image seems blocky and not too speckley.
However, but the change in resolution which was previously a result in applying the decimation filter, has caused me to doubt this.

Also how does this affect intrinsic parameters? Should I be using the intrinisic params for the RGB camera on this new depth image?

@themarpe Have you seen this issue? I was able to implement my own spatial detector on the Host Side which works well, so there is definitely enough information in the depth image to work with.

@PeterQFR sorry for the delay. Do you mind appending the MRE and expected output?
@szabi-luxonis anything upon a quick glance from your end?
First thing that comes to mind is tweaked image transformation which would yield different results in the unaligned case

Not immediately sure @PeterQFR , but will be able to tell after seeing the pipeline, at first it sounds like a regression.

Hey the pipeline is here

I also have noticed that when I use the Image Manipulation Node to rotate my depth image 90 degrees, that, while it transposes my pixel values, this is within a image the same shape as my original image. That is, the number of rows and cols is not changed. The data is cropped, and padded with zeros in the depth image. A similar thing might be happening on the RGB side.. @szabi-luxonis is this a clue?

@PeterQFR wrt rotating, would ImageManip Rotate example work??

I did look at that an using the RotatedRect was a different approach, but I didn't understand what the order of transformations were, and the image looked a bit offset. The cropping and choosing a center were a bit unclear how they were to be applied and I didn't see a lot of difference using them.
In the end I removed the image manip and did it on the host side using opencv.
cv::rotate(img, img, cv::ROTATE_90_CLOCKWISE)

Which was exactly what I wanted. Maybe implementing with exactly this functionality would sort out this issue.
But I think that this might also be the issue with spatial detector.

In your pipeline remove the ImageManip node that rotates depth image, remove the ImageManip node that rotates preview from ColorCamera.
If you still want to rotate preview ,you can move the ImageManip node after SpatialDeteectionNetwork and rotate the passthrough output.
It's likely that some image transformation data is not set properly when doing ImageManip.
Anyway, what is the reason for rotating the image in your pipeline?

the camera is rotated, and there is a definite degradation in the object detector accuracy and recall if the image is rotated 90 degrees I found.

I had the same problem, and using stereo.setOutputSize(480,480), I get a square depth image as output of the stereo node. As a square image, it's well rotated by ImageManip.
A spatial detection yolo doesn't seem to mind the square depth image. I did not test accuracy though.


ADD INSTRUCTIONS TO MAKE PR AFTER CLONING TO LOCAL REPO

IMPROVE the instructions to make a simple PR after cloning to local repo. This can be aguide to a complete beginner on how to easily create a PR without much difficulty.

Adding a file like that without asking is not what I want here. It should go to CONTRIBUTING.md file.


Dedicated nodes: difficult to read the hint on the price

Fixed tooltip at development__313_farm_enhancement branch ll create PR soon

Tooltip is not fixed yet.

it seems my code was overridden :)
https://github.com/threefoldtech/tfgrid-sdk-ts/commit/6819bfbc2c9e70e12eb4030fde22f28693fa7bf1
created new PR
https://github.com/threefoldtech/tfgrid-sdk-ts/pull/1634

Verified,

Devnet
13a87cf
TC2219 - List Dedicated Nodes

Verified:

Devnet
2.3.0-alpha3


use fa-certificate when person declare it's a certificate and not a course

Purpose
As I have many certification but not so many PhD; I though it would be nice to make a visual differentiation
So instead of
[[education.courses]]
  course =

we could use
[[education.courses]]
  certificate =

and the result is this

Documentation
will follow soon

Thanks for the feedback, opened #1094 .


Remove logging from pyswitch wrapper.

There is no reason to include logging in the wrapper code. The approach
would be to raise Exceptions appropriate to the api

@dpasupathi can you approve this PR, else github will think its just a comment :)


chore(packages): update testing packages to latest

drop quote on test:unit so windows shell can exec
update test related packages to latest (testing-library, chai, chai-enzyme, jsdom, mocha

Thanks!


Does Mass Action Scheduler support External Objects?

Hey there :smile: was just wondering whether the Mass Action Scheduler supported reading External Objects? Thanks!

Hi @Clint-Chester, I don't see why not. I haven't tried personally.
Did you ever try this yourself? Let me know if it doesn't work and I'll re-open this issue to investigate.
Thanks!

Just thought I'd let you know that External Objects do work 😄

Sweet, thanks for the update


PBJMediaWriter crash on endVideoCapture

Hi,
When I try to end recording a video, the app crashes at [_assetWriterVideoInput markAsFinished]; or [_assetWriterAudioInput markAsFinished];. This never happened to me before iOS10, but since it was release I've had to update my Info.plist file to include the newly required "Privacy" strings Privacy - Camera Usage Description, Privacy - Media Library Usage Description and Privacy - Microphone Usage Description. The crash happens only at first try, when the user is prompted by the to give access to the Camera and Microphone. If the user accepts both and continues recording the video, then tries to end video capture, the app crashes. If the user has already given these permissions before, the app will not crash and will work as expected.
So I'm guessing it's something to do with the permissions. Should I not wait for the popup to appear automatically? Should I somehow ask for the permissions before the video capture starts?
Any help would be greatly appreciated.

hey @dimovskidamjan i recently started developing a swift version of this library and encountered the same situation. there is API to check the permission status, which you can call to avoid when the authorization is triggered. i haven't solved it in the other library yet just because i've been so busy but it's on my checklist, can bring it over here too.
here's some links that'll help:
📎 https://github.com/NextLevel/NextLevel/blob/master/Sources/NextLevel.swift#L921-L922
📎 https://github.com/NextLevel/NextLevel/blob/master/Sources/NextLevel.swift#L672-L686
checklist:
✅ https://github.com/NextLevel/NextLevel/issues/5

I have managed to fix it by asking for permissions before starting PBJVision, like so:
[AVCaptureDevice requestAccessForMediaType:AVMediaTypeVideo completionHandler:^(BOOL granted) {             if (granted) {                 [AVCaptureDevice requestAccessForMediaType:AVMediaTypeAudio completionHandler:^(BOOL granted) {                     if (granted) {                         //Your PBJVision code goes here...                     }                 }];             }         }];
In my case, this was for recording a video with audio, that's why I needed both permissions granted.


[UT]Fix pushdown subfield ut

Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[x] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.4
[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0

@mergify backport branch-3.4

@mergify backport branch-3.3


add notes from experimentation

@ronmiab,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jborsecnik - The proposed changes are under review.

Please #sign-off


commandToSkipShell doesn't control showCommands

Testing #11137

VSCode Version:1.5.0
OS Version:Windows 7

Steps to Reproduce:

Add default terminal.integrated.commandsToSkipShell
Remove workbench.action.quickOpen
Try Ctrl+P from Integrated Terminal and now ^P shows up in the terminal
Now remove workbench.action.showCommands
F1 correctly doesn't bring up Command Palette. Show last keys typed instead.
Ctrl+Shift+P still brings up Command Palette.

Same behavior in Win 10 and Ubuntu 16.04. When workbench.action.quickOpen is removed, Ctrl-Shift-P works while F1 doesn't.

This is as designed. Some keybindings are not handled by xterm.js, when this is the case they are bubbled up the vscode.


Split terminal check to add build tags to support App Engine.

Related issue: #634

Howdy @sirupsen, can we please merge this?
This is forcing us to pin this dependency on many services.


Gearpump Security

This is an umbrella for multi-tenancy related issues.

[x] user management. Authentication/authorization/audit
[ ] #1074   It shouldn't be possible to disturb akka clustering mechanism that is used in multi-master configuration feature P2 security
[x] #1073		It shouldn't be possible to look at the other org’s applications in services console feature P2 security
[ ] #1072		It shouldn't be possible to send messages to other org’s actors feature P2 security
[ ] #1071		It shouldn't be possible to sniff other org’s communication between actors feature P2 security
[x] #1070		It shouldn't be possible to kill other org’s GP instance. feature P2 security
[x] #1069		Gearpump multitenancy in context of security feature P2 security
[ ] #1458                Gearpump Kerberos Support

For the new UI with authentication, please see demo at http://<IP_ADDRESS>:8090/

"SignOut" is not shown on mobine

@manuzhang
fixed in PR #1867

migrated to https://issues.apache.org/jira/browse/GEARPUMP-74


fix: Fix name convertor

Hi, thank you for this project

Description

The gRPC Java codegen makes k8s_cluster field name to K8SCluster.
But because of the protoc-gen-kotlin-ext makes k8s_cluster to K8sCluster, the compilation error is occuring.
Fix it to works

Thank you.
There might be other things I’ve missed as well. I’ll go ahead with the merge for now, but I’ll also conduct further checks on my end and make any necessary adjustments before releasing.
ref: https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/compiler/java/names.cc


N-dim example, or maybe MNO

Codecov Report

Merging #17 (787528f) into master (29d55da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           50        50
=========================================
  Hits            50        50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d55da...787528f. Read the comment docs.

This is not a Markov Neural Operators.

This is not a Markov Neural Operators.

Please take closer look at the model introduced by the paper.


detect removed registry

When the internal image registry is disabled ("Removed"):

stop generating service account token secret
stop generating image pull secret
delete existing secrets

/test all


\yii\db\ActiveQuery::count() ignores named expressions

I have some named expression declared in SELECT part of query:
$query = \app\models\Provider::find()->
            select(['id', 'val' => new \yii\db\Expression('(id * 2)')]);

In real case I use a little bit more sensible expression, of course, but it doesn't matter for now. Next, I want to filter results by declared expression's value:
$query->having('val > 2');

Now, if I would call $query->all(), correct results would be returned, but if I would call count() I would get following error:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'val' in 'having clause'
The SQL being executed was: SELECT COUNT(*) FROM `provider` HAVING val > 2

As you may notice, generated query is SELECT COUNT(*) FROM `provider` HAVING val > 2 while, as I assume, it should be something like SELECT COUNT(*) FROM (SELECT (id * 2) AS val FROM `provider` HAVING val > 2) c but such query is genererated only if groupBy or union is not empty or query has distinct = true.
Is it a bug or I missed something?
I am using Yii 2.0.3 on PHP 5.6.7 with MySQL database.

the current implementation does not cover this use case, could be improved.

Check for 'having' present should be added here:
https://github.com/yiisoft/yii2/blob/master/framework/db/Query.php#L388

Well, not I am not so sure. If you run a query with HAVING but without group by (which presence is covered), you will get 'General error: 1 a GROUP BY clause is required before HAVING'.

No, MySQL allows it.

Issue resolved by commit b8081b5

:+1:


better doc on auto-updater

I can see that it uses Squirrel.Mac, and I can read what the server needs to do. However, once the thing sees that there is an update available... where will it fetch the updated assets from? And what format do those assets need to be in?
Also, I have heard that you are re-vamping the auto-updater. I would love to see more doc on that.

I suggest bringing this up in issues list of Squirrel.Mac, you should be able to get much better answers there, and the documents on auto-updater in Electron just links to there.


[boltdb] testcase failed

i got the following message when I tried to run test on store/boltdb
--- FAIL: TestMultiplePersistConnection (0.00s)
        Error Trace:    boltdb_test.go:69
        Error:          An error is expected but got nil. %s

turns out the underlying FcntlFlock implementation has been changed (https://github.com/boltdb/bolt/commit/ebe310138bbbe1e1d146197ab8b7fa772da38b1d) and boltdb also removed the corresponding test cases (https://github.com/boltdb/bolt/commit/b9eb643780505525197ad791e275fc7ebc208bc8), so I am not sure whether this testcase is still necessary?

/cc @sanimej


needpie with zero needs causes matplotlib crash of build

I think there is a bug that causes the build to crash if there is a needpie filter condition does not return any needs.
I'm using version sphinxcontib.needs version 0.7.7.


fix(query): unable to bind custom arguments

:tada: This PR is included in version 0.5.7 :tada:
The release is available on:

GitHub release
v0.5.7

Your semantic-release bot :package::rocket:


Update SecuritySettings component

[x] Fix existing bug
[x] Update component
https://github.com/aeternity/superhero-wallet/blob/develop/src/popup/router/pages/SecuritySettings.vue

The component was updated in https://github.com/aeternity/superhero-wallet/pull/642


Fix JS for torrent/user deletion that would delete even if you refused to confirm

Coverage remained the same at 38.881% when pulling e41333289a3c14bb5073fa715498d6d80f17b9b4 on admin into 357012932b4e53b170c7f5ac6e6816f17959cb74 on dev.


Delay problem in first/last slides when on loop mode

First off, thanks for making this script, it's really great! I've been having this small problem with it though:
When loop mode and slide are set, there is a bug with the first/last slide in which if you make a full circle between the slides to either side, the next time you click to move a slide, it does not trigger slide change. If you wait long enough before clicking this doesn't happen. There is a similar problem when dragging between first and last slides mode than once.
If the disabled state is removed from the prev/next buttons, it just jumps about in a slide it shouldn't be.
It seems to be some delay when moving active from the cloned slide into the first/last slide.
Removing/reducing (I've set it at -100) the 100ms extra time in the timeout below made the problem much smaller (though it didn't eliminate it), and I haven't noticed any drawbacks, is there any reason for the delay in the code?
            resetSlide: function (s) {
                var $this = this;
                $slide.find('.lSAction a').addClass('disabled');
                setTimeout(function () {
                    scene = s;
                    $slide.css('transition-duration', '0ms');
                    slideValue = $this.slideValue();
                    $this.active($children, false);
                    plugin.move($el, slideValue);
                    setTimeout(function () {
                        $slide.css('transition-duration', settings.speed + 'ms');
                        $slide.find('.lSAction a').removeClass('disabled');
                    }, 50);
               }, settings.speed + 100);
            },

Not sure this is the same issue, but when using loop, quickly going from last to first or vise versa bugs out and gives a quirky behavior. Jumpy-like. Is there a fix for this? It's the only reason I would consider using something else.

I am no longer working on the project involved with this script, but if I recall correctly, your description sounds to me like the same problem, or at least related. The first/last slides get cloned so you can move to them and see the proper animation, so they're treated a little differently than the others.


Consumer not able to commit offsets for some partitions

So we are trying to debug this issue where the consumer is not able to commit offsets for certain partitions and it starts reading again from the same offset. This goes into infinite reading.
So in the phobos log, this is what we see:
[2018-01-26T21:20:14:846+0000Z] INFO -- Phobos : <Hash> {:message=>"Committed offset", :batch_size=>1133, :partition=>1, :offset_lag=>567, :highwater_mark_offset=>2853, :listener_id=>"e8398e", :group_id=>"events_group", :topic=>"events", :time_elapsed=>968.744}

[2018-01-26T21:20:14:846+0000Z] INFO -- RubyKafka : Committing offsets: events/1:2286

[2018-01-26T21:20:14:846+0000Z] WARN -- RubyKafka : Connection has been unused for too long, re-connecting...

[2018-01-26T21:20:14:884+0000Z] ERROR -- RubyKafka : Error committing offsets: Kafka::UnknownMemberId

[2018-01-26T21:20:14:885+0000Z] INFO -- RubyKafka : Joining group `events_group`

[2018-01-26T21:20:14:886+0000Z] ERROR -- RubyKafka : Failed to join group; resetting member id and retrying in 1s...

Any suggestions or ideas would help? Please and thank you!
FYI, phobos config:
consumer:
  # number of seconds after which, if a client hasn't contacted the Kafka cluster,
  # it will be kicked out of the group
  session_timeout: 300
  # interval between offset commits, in seconds
  offset_commit_interval: 10
  # number of messages that can be processed before their offsets are committed.
  # If zero, offset commits are not triggered by message processing
  offset_commit_threshold: 0
  # interval between heartbeats; must be less than the session window
  heartbeat_interval: 10

backoff:
  min_ms: 1000
  max_ms: 60000

@dorner @mehdimuv The default behavior for phobos is to process messages in batches. If you have a lot of messages that are small in size, but each take almost a second to process you will most likely exceed the session_timeout for the kafka consumer. When processing messages in batches, ruby-kafka does not try to send a heartbeat to the kafka broker or commit offsets until the entire batch is processed. If the time to process the batch takes longer than the session timeout, the consumer will fail to send a heartbeat to kafka in time. Kafka will kick the consumer out of the group (hence the Kafka::UnknownMemberId error) and offsets will fail to commit. If you set the delivery option for the listener to message, ruby-kafka will check if needs to commit offsets / send heartbearts after "each message" vs "each batch." How often it sends heartbeats / commits offsets will depend on the settings in your phobos config. This might be the better option for you if each message takes awhile to process. See the conversations in https://github.com/klarna/phobos/pull/42 for more details. @klippx I know I mentioned potentially making each_message the default behavior at some point in the future. Do you have anymore thoughts on this?
What @klippx says about changing the max_bytes_per_partition setting is correct. However, be careful in tweaking this setting. If there is a message in a partition that is larger in bytes than the max_bytes_per_partition setting (and kafka allows a message size this large), ruby-kafka won't be able to fetch the entire message. Processing on that partition will stall.

@dorner @mehdimu Any updates on this issue, were you able to get it working?
@jasondoc3 I don't know if it would be strictly better to change the default. Maybe we should compile a living document with compelling pros and cons we can live with, or discuss it more in the Discord chat :)

@klippx yep, it appears that switching from batch to message solved the problem. We were wondering why the consumer settings like offset_commit_interval weren't working :) At the very least, the default phobos.yml should indicate in the comments that those settings will only work in message mode and not batch mode.

@dorner Those settings do work in batch mode.
However, ruby-kafka only checks to send heartbeats / commit offsets after the entire batch has been processed. In other words, sending heartbeats and committing offsets are done in the same thread as the processing itself. If your batches take 5 seconds to process and your offset_commit_interval is 20 seconds, offsets are committed after the 4th batch is successfully processed. If your batches take 20 seconds to process and your offset_commit_interval is 5 seconds, offsets are committed after every batch.
See the source code here: https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/consumer.rb#L283

@klippx I'd be happy to create a document or discuss :)

@jasondoc3 you are welcome to join the discord chat and we can discuss next steps there


🐛 Patch CVE-2021-32810

In the affected version of this crate, the result of the race condition is that one or more tasks in the worker queue can be popped twice instead of other tasks that are forgotten and never popped. If tasks are allocated on the heap, this can cause double free and a memory leak. If not, this still can cause a logical bug. Crates using Stealer::steal, Stealer::steal_batch, or Stealer::steal_batch_and_pop are affected by this issue.
CVE-2021-32810
9.8/ 10

Two issues:

This crate doesn't use the Stealer, so this advisory doesn't seem relevant. Cargo doesn't use lockfiles for libraries, so downstream users aren't affected either way.

It seems that you've edited the lockfile by hand, because the checksum hasn't changed. This file needs to be maintained by Cargo.

I've updated the lockfile.


Result for a connection without parameters

Thanks, Rafael.
How did you make the call to the API? You need to send a request body in the following format:
{   "resource": "catalog_product.list" }
Regards,

Tiago

@tiagosampaio here works well, in this report I did want to report the error without parameters, without callback message, is it the normal comportment?

I just made the adjustments.
Thanks,
- Tiago


Error message shown below of subscribe section if empty field submit or invalid email entered

close #406
Changes proposed
empty error message shown below of subscribe field.
invalid email validation added.
Screenshots

@Susmita-Dey Please review it. issue#406 resolved.

@Susmita-Dey check this PR#420 hope it works fine!!


not work on random.org now

dear sir,
today, i install addon on chrome and use this. But, it not work.
please help me
thanks sir

You read https://github.com/azate/anti-random.org#using ?


Add missing doc comments on examples

All examples should start with a module doc comment (//!) explaining what the example is demonstrating. I should maybe add a check for that too...

I think we can close this, now that the examples all have READMEs with examples.