<> long-press operation

I want to activate different key codes by long-press and short-press
It is an operation that is not found in a normal PC keyboard, but it is a popular operation in embedded systems.
It can be used for careful operations and infrequent operations.
Thank you for the wonderful environment for me!

Although, it sends long-press keycode on UP after a long-press (not at the set time),
kbd.define_mode_key :SHORT_A_LONG_1, [ Proc.new { kbd.send_key(:KC_A) }, Proc.new { kbd.send_key(:KC_1) }, 500, nil ]

is not enough?

Wow　It's almost working!!
In my behavior, the keycode is entered with Long-press set time (500).  (Not key UP)
And, If the Long press time is set to 2000, key omissions will occur in continuous operations.
(short -> long -> short -> long ......)
Thanks yswallow

Keyboard#define_mode_key was basically designed to combine a normal key and modifier/layer hold key.
Maybe I should implement a new feature to fulfill @koyoko1127's request.
Let me think how to realize that because I'm personally excited that PRK Firmware will possibly be used in prototyping a real product 💪

Thank you for your aggressive suggestions.
If you are aiming for a multifunctional long press operation, you need to think about the context of use.
I have 4 stories（See figure below）
I think this includes Hi-dynamic range operations with repeat motion. Set the repeat interval time or set nil.

@koyoko1127
[a]      [A]      KC_NO      0

This is not a case this feature should cover because...
kbd.define_triple_function_key :BUTTON_A, :KC_A, 300, [:KC_LSFT, :KC_A], nil, nil
kbd.define_triple_function_key :BUTTON_B, :KC_B, 300, [:KC_LSFT, :KC_B], nil, nil
kbd.define_triple_function_key :BUTTON_C, :KC_C, 300, [:KC_LSFT, :KC_C], nil, nil
kbd.define_triple_function_key :BUTTON_D, :KC_D, 300, [:KC_LSFT, :KC_D], nil, nil
kbd.define_triple_function_key :BUTTON_E, :KC_E, 300, [:KC_LSFT, :KC_E], nil, nil
kbd.define_triple_function_key :BUTTON_F, :KC_F, 300, [:KC_LSFT, :KC_F], nil, nil
kbd.define_triple_function_key :BUTTON_G, :KC_G, 300, [:KC_LSFT, :KC_G], nil, nil
(...)

Nobody wants to write such a verbose code, right?
(Of course you can do it. But it's not supposed to do)
BTW, could you tell me more about "Hi-dynamic range operations"? I don't know it.

Ah, but, you may be able to write like this, lol
("A".."Z").each do |c|
  kbd.define_triple_function_key "BUTTON_#{c}".to_sym, "KC_#{c}".to_sym, 300, [:KC_LSFT, "KC_#{c}".to_sym], nil, nil
end

Evel Ruby...

Ah, but, you may be able to write like this, lol
("A".."Z").each do |c|
  kbd.define_triple_function_key "BUTTON_#{c}".to_sym, "KC_#{c}".to_sym, 300, [:KC_LSFT, "KC_#{c}".to_sym], nil, nil
end

Evil Ruby...

@hasumikin
I don't know what " Hi-dynamic range operations " is officially called.
For example, when searching for an arbitrary value from 0 to 1000.
If you have a wide range of values and want to set them in detail, you need both micro motion and coarse motion.
micro motion  (微動） ==> 0,1,2,3,4,....1000
coarse motion（粗動） ==> 0.20,40,60,80,.....1000   *It is better to have a repeat in the long-press
From now on, we need to control high resolution and large (long) size data in photo, CAD, and video.
Using multiple inputs with one key, I prototype an embedded product.
Thanks

@koyoko1127
Understood, thanks!
Let me think for a while


sizes

Hello, and thanks for this nice directive!
How would you go about changing the size of the swtich?

ui-switch="{color:'#5C9C4D', size: 'small'}"
works for me

Are you looking for https://github.com/abpetkov/switchery#user-content-sizes?

This is due to an outdated version of switchery being used. Can the library be updated?

Closed with #28 ;)


Fix SDLHMIZoneCapabilities class case

Fixes #54, based on the new distribution branch #57, can be merged after that one is.

Recreate against new develop branch


[BUG] Documentation about rules is leading to error    Definition for rule 'vitest/valid-title' was not found

We are updating our configuration to the new plugin with the latest version.
We followed the documentation for legacy code and we defined the configuration as follows:
    {
      "files": ["src/**/*.test.[tj]s?(x)"],
      "excludedFiles": ["src/**/*.e2e.test.[tj]s?(x)"],
      "extends": [
        "plugin:jest-dom/recommended",
        "plugin:testing-library/react",
        "plugin:@vitest/legacy-all"
      ],
      "rules": {
        "@vitest/valid-title": [
          "error",
          {
            "mustMatch": {
              "it": [
                "^should.*when.+$",
                "Test title must include 'should' and 'when'"
              ]
            }
          }
        ]
      }
    },

But it leads to a bug since we are using @vitest plugin.
It can be fixed by using @vitest on the rules. Hence, the documentation for legacy code must be updated.
There is no problem with the new ESLint configuration.

I don't know if it makes sense to update docs since the legacy will eventually deprecated.

I don't know if it makes sense to update docs since the legacy will eventually deprecated.

But It is not deprecated yet.


Revert PR #675

This reverts #675 due to some concerns over potential race conditions with deletion of some of the resources affected.

/cherrypick release-4.5


fix: resolve & reset deferred upon refresh error

What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently refreshingDeferred does not get resolved/rejected upon error. Also the deferred does not get reset to null during an error. See #334
What is the new behavior?
 Like this the deferred Promise behaves like the Promise returned by _callRefreshToken itself.
Additional context
Closes #334

Thank you for looking into this. This fixes the problem for me.

Coding wise, would it make sense to move the actual callRefreshToken logic into another private function (e.g. callRefreshTokenConcurrently) that will not be concerned with concurrency. While the callRefreshToken will be only creating/resolving/rejecting the deferred promises as appropriate to share the concurrent calls. That is just to keep things more robust against future changes. Just to make it less likely that somebody who touches error-matching logic, or session saving, or subscriber notifications will introduce another dangling promise bug.

Have you considered adressing the problem of this being called with different refresh tokens simultaneously? e.g. _callRefreshToken(token_a) and _callRefreshToken(token_b) should not resolve to the same result. I don't think this is exposed to the users now, at least not in any common path, but it's a potential issue.

For reference here is an earlier implementation of shared token refreshes, where these two points are addressed https://github.com/supabase/gotrue-js/pull/203/files#diff-3522461172efd6058d6b8da62fc2d30d8b524d2b64894ea2c67218c52f7fdff5

Regarding @wattroll's points:

would it make sense to move the actual callRefreshToken logic into another private function (e.g. callRefreshTokenConcurrently) that will not be concerned with simultaneous calls. The callRefreshToken will then only be creating/resolving/rejecting the deferred promises as appropriate to share the concurrent calls.

The implementation in #203 does not protect from race condition. _callRefreshTokenConcurrently() could accidentally be called internally without going through _callRefreshToken() and like this introduce concurrent calls to this.api.refreshAccessToken(). Therefore I prefer @alaister's implementation introduced into next with #285, regarding this point.

Have you considered adressing the problem of this being called with different refresh tokens simultaneously? e.g. _callRefreshToken(token_a) and _callRefreshToken(token_b) should not resolve to the same result. I don't think this is exposed to the users now, at least not in any common path, but it's a potential issue.

This indeed is a potential issue. But the solution to have a promise/deferred for each token would shift the race condition down to saveSession(). When calling _callRefreshToken(token_a) and _callRefreshToken(token_b) concurrently the last one that resolves would write to the storage. As the storage in gotrue-js currently is a single user storage it probably would make more sense to abort pending refresh requests, when _callRefreshToken() is called concurrently with another refresh token (should be possible to do that by passing an abort signal to the fetch request).
My intention for this PR is solely to fix a Bug (see #334) introduced with #285. Probably it makes sense to open a new Issue with @wattroll 's points to discuss them further?

Moved CallRefreshTokenResult to lib/types.ts and comited prettier changes affecting code introduced with this PR. I didn't dare to commit prettier changes to other areas of the code base.
Prettier changed this line
const { session: session3, error: error3 } = await authWithSession._callRefreshToken(session?.refresh_token)

to 3 lines, which resulted in the TS error Type 'undefined' is not assignable to type 'string' during tests. When the code is on one line this error is not thrown. I decided to use a non null assertion as there is already a expect(session).not.toBeNull() a couple of lines above.


Do not publish tests

When installing the module in a project I noticed that the test/source.js file causes flow errors because of nonexistent imported modules.
This PR adds a .npmignore based on the .gitignore to stop npm from publishing the test/ directory.

Thanks! I added a whitelist rather than an ignore list in case we add more test and maintenance files in the future


connections to multiple parents

At the moment I only have one parent per icon. Drakon diagrams allow for multiple connections to many parents, so this rendered will need it.
Let's start with one end icon being reachable from different steps.

OK, this is something I've been preparing myself for a while now. This change represents the hardest code in the application so far, so it will probably take a while to get it right.
Below is a sample problematic situation we can get into today:

action 3 is a child of both:

question 2
question 3

which results in some problems:

it and its children should not be rendered twice
each icon should only be rendered once
there can be multiple connections from a child to its parents (we already have multiple connections from a parent to many children)

A reasonable next step would be to flesh out the troubleshooting mode with:

replace max width with an actually useful information like origin coordinates
a bool signifying whether an icon has already been rendered

OK, origin coordinates for troubleshooting done:

I added a comment to the TODO function a while ago which stated:
-- we should have a bit of new logic here:
-- if, while iterating through the list of icons, you come across an icon
-- that is already in the returned collection of triples (rendering order, max width, (coordinates, diagram))
-- take that found end icon from the returned collection and mappend a connection to the new parent node to it

Now that I:

started working on adding the "already rendered" troubleshooting indicator
took the time to read the code very carefully

I realised that it would be impossible. That collection of triples I mentioned only contains nodes that are assigned to the current node as children - it doesn't contain all graph nodes. I will have to rethink how we keep track of already rendered nodes...

So at this stage I'm convinced that while rendering individual steps, we shouldn't also connect to their parents as, if we spot a new parent while iterating through the list of icons, we would have to retrace back to that already rendered icon and then connect it to the newly found parent. I feel it's unnecessarily complicated.
Additionally, I realised that even if I remove the functionality that connects newly rendered icons with their parents, the positioning will still be wrong (it already is wrong). Icons should not be rendered if they are already rendered.
I fear I will have to rethink this general group of functions:
[Icon] -> [Diagram]


tests: add tests and refactor utils package

Codecov Report

Merging #424 (96fe82b) into main (a00110d) will increase coverage by 0.13%.
The diff coverage is 44.73%.

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   47.10%   47.24%   +0.13%
==========================================
  Files          90       92       +2
  Lines        6088     6088
==========================================
+ Hits         2868     2876       +8
+ Misses       2890     2879      -11
- Partials      330      333       +3

Impacted Files
Coverage Δ

utils/prompt.go
0.00% <0.00%> (ø)

utils/utils.go
100.00% <ø> (+42.00%)
:arrow_up:

utils/uuid.go
89.47% <89.47%> (ø)

utils/zero.go
53.33% <0.00%> (+53.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00110d...96fe82b. Read the comment docs.


Add Host Storage component and interactive from Home Page

Summary
Before this PR, the static host Netlify could not read local or Dropbox galleries. This PR allows a Dropbox token or localhost path to be stored on the browser's local storage for accessing private photos

Test plan
Yes added Formik validation unit test and fixed a Jest config to execute JSX filenames

Coverage remained the same at 93.368% when pulling 25f6745001be97513f7f55e7adf7414f2118697e on danactive/prompt-dropbox into 388a4f8332a952e4259d4f2f0bafb1b66a079bb0 on master.


✨ Create GitHub OAUTH for ServiceNow

Create a new oauth application for integration with ServiceNow.
https://docs.servicenow.com/bundle/sandiego-devops/page/product/enterprise-dev-ops/concept/dev-ops-github-oauth-apps.html
DoD
The following information is sent to Roustan

[ ] Client ID
[ ] Client Secret
[ ] Token URL

Update GitHub and ServiceNow - Working Group thread in teams

Have requested permission with Operations Engineering in slack

Create GitHub App ServiceNow-devops-sandbox distributed details to developer.


Add markdown capitalization linting, fix errors

For a more consistent and easier review process, and for higher quality
docs results.
Copies markdownlint configuration from the website.
Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

These failures seem to be on usages that are in code blocks. The config should ignore anything in code blocks. I think this works, using the same config and GHA, in the website CI.
Error: submariner-operator/diagnose-refactor-ocm.md:22:20 MD044/proper-names Proper names should have the correct capitalization [Expected: Submariner; Actual: submariner]
Error: submariner-operator/diagnose-refactor-ocm.md:24:9 MD044/proper-names Proper names should have the correct capitalization [Expected: Submariner; Actual: submariner]
Error: submariner-operator/diagnose-refactor-ocm.md:2[8](https://github.com/submariner-io/enhancements/runs/6099105497?check_suite_focus=true#step:4:8):38 MD044/proper-names Proper names should have the correct capitalization [Expected: Submariner; Actual: submariner]
Error: submariner-operator/diagnose-refactor-ocm.md:43:[9](https://github.com/submariner-io/enhancements/runs/6099105497?check_suite_focus=true#step:4:9) MD044/proper-names Proper names should have the correct capitalization [Expected: Submariner; Actual: submariner]

[~/go/src/submariner-io/enhancements]$ markdownlint markdownlint -c .markdownlint.yml .
[~/go/src/submariner-io/enhancements]$ echo $?
0
[~/go/src/submariner-io/enhancements]$ markdownlint --version
0.28.1

@dfarrell07 are you working on this for 0.13?

I think this should work now that the GHAs are auto-updated. Need to manual rebase.

This seems to be correctly failing now.


Get state fullscreen at map load

How can I get the current state before clicking the control? So on first load of the map?

map.isFullscreen()


MS SQL - Foreign Key Columns

I just started using this wonderful application today. Thanks for it !
I am using it with an Azure SQL database
I had created many, multiple column foreign key cascade delete constraints on tables before (in MS SQL Management Studio) .. but they are only showing me 1 column in DBBeaver.
I thought maybe I'd stuffed up so I have been deleting them and adding them back in using SQL Scripts in DBeaver .. BUT .. those are only showing me 1 column also (instead of 2 or 3) when I Right click on a FK & Choose Edit Foreign Key

Thanks

There is no update on the ticket more than a year.
If the issue is still reproducible for you - feel free to reopen the ticket and add some details or create the new one.


dist folder of the package contains old code :)

dist/src/grpc/clients.js

src/grpc/clients.ts

Hello @dwojno , we have solved this issue in v0.4.1. Can you close the issue after testing it?


How are my private repositories visible?

?!

@joe733 Hi, can you point out the private one? or have you open it before and change it to private recently?
GitHub won't allow us to get private events/activities...

have you open it before and change it to private recently?

Not recently, few months ago I guess I changed it to private. It that why it showed up in stats?

@joe733 Yes, GitHub will give all activities of repo if the repo visibility is public.


chore(upgrade): add troubleshooting to V2 upgrade guide

:tada: This PR is included in version 2.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enable JSX files extension

JSX extension is much used in React, this would be a natural addition for React Native.
See: https://github.com/facebook/react-native/issues/2303

@facebook-github-bot shipit

@skevy Is there anything I have to do about the Import Failed tag?

@kdemoya nope.
@mkonicek any idea what happened here?

An intermittent unrelated error didn't allow the commit to land. I've just restarted the process. Should land soon :)

I see a "naming collision detected", looks unrelated. Merging again. We should implement retries to get around this problem.

@mkonicek it would be interesting looking at a dashboard to see why most of the pull requests fail to land. The bot already adds a special label to the issues. Besides this week due to the stability issues we had, I bet that most of the problems are because the pr needs to be rebased. It would be great that if that happens we could comment on the github issue advising the pr owner to rebase :)

Im puzzled by this. Why would you want to call a file .js when it is not a proper javascript file and break all other tooling? The question isn't wether .jsx files should be supported, the obvious and in your face bug is that supporting .js files as if they are .jsx files is breaking the standard, makes tool integration harder and is generally considered to be 'HARMFULL BEHAVIOR' just like renaming a .json file to an .xml file would be. It is self centered. We may want to use tooling (linting, beautifiers) that expects the file extensions to follow the proper conventions. As nice or imporant as this project may be, it is not important enough to warrent the arrogance of diluting a standard filetype association.

Not sure why this has been closed.  JSX is a separate language to ES and should not use the same file extension in order to allow external tools (e.g. code formatters, linters, code metric generators, etc) to identify the type and behave appropriately.  Not supporting this just because there are edge cases that might require thought is absurd.

temp solution. but we need built-in one!
http://www.fallingcanbedeadly.com/posts/enabling-react-native-jsx-extension

@savvaoff why don't you make a PR about this solution?

@gabrielmaiaf because that is not a problem at all. Many of us knows how to fix this but the core contributors will no take the PR.

Just so everyone one knows it is possible to use JSX files with react native. Inside of the root of your project add a file named rn-cli.config.js and place the following code into it.
// ./rn-cli.config.js
module.exports = {
  /// @name Make ReactNative Great Again
  /// @description Allows you to enable support for JSX files, and `.mjs` files which is the new node standard
  /// @source: http://www.fallingcanbedeadly.com/posts/enabling-react-native-jsx-extension
  /// @note: One caveat, The `index.js` file in the root of your project has to be `.js`.
  getSourceExts: () => [ 'jsx', 'mjs', 'js' ],
}

@tjbenton's solution seems to not work in newer versions of RN (I'm on 0.57.7) but as per https://github.com/facebook/metro/issues/248#issuecomment-421479180, this works:
module.exports = {
  resolver: {
    sourceExts: ['js', 'json', 'ts', 'tsx', 'jsx']
  }
};

In newer version just change metro.config.js
  transformer: {
    getTransformOptions: async () => ({
      transform: {
        experimentalImportSupport: false,
        inlineRequires: false,
      },
    }),
  },
  resolver: {
    sourceExts: ['jsx', 'js'],
  },
};```

module.exports = {
resolver: {
sourceExts: ['js', 'jsx']
}
};

I'm on RN 60.4
rn-cli.config.js
module.exports = {  resolver: {        sourceExts: ['js', 'jsx']    } };
metro.config.js
module.exports = {   transformer: { ...  },   resolver: {     sourceExts: ['jsx', 'js'],   } };
nothing is working.. Unable to resolve module

Turns out the reason why sourceExts: [ 'jsx', 'js' ] doesn't work is because js has to be defined first. I would also in resolverMainFields: [ 'main' ]  because there's several packages that are starting to use the "react-native": "src/index.ts" setting the in package.json which tells the metro parser to use the ts files instead of the "main": "lib/index.js" file. An example of this can be found in the latest version of the react-native-permissions library. Note the resolverMainFields isn't required to fix this problem it just seems to make it run faster.
module.exports = {
  resolver: {
    sourceExts: [
      'js', // note this has to be defined first or you get an error
      'json',
      'mjs',
      'jsx',
    ],
  },
  // this prevents the `react-native` field from being used so `ts` and `tsx` files don't have to be transpiled
  resolverMainFields: [ 'main' ],
  transformer: { ... },
}

Here's a screenshot of this config working for me

If you don't put the 'js' option first you get this error.
TypeError: EventTarget.apply is not a function. (In 'EventTarget.apply(void 0, WEBSOCKET_EVENTS)', 'EventTarget.apply' is undefined)


Want add another Tasmoate Version bigger than 512kb

Hello,
i want add in tuya-convert/files an older tasmota version. But all versions are bigger than 512kb.
Only the minimal and lite version are smaller but i dont want install this version.
Why do we have this limit and can i turn it up to 600kb ? Because than i can install every version i want.

Use the included Tasmota and then upgrade to the version you want

If i do like this i have to downgrade because i want use 7.1
And i think downgrade to 7.1 is not possible afer i install 8.1

Then why not start with minimal? The limit is not ours, it is a technical limitation that applies to every ESP OTA upgrade.

You can also add (A55AA55A FFFFFFFF 5AA55AA5) to the end of any firmware to allow Tasmota 8.1 to upgrade to it.

Danger Will Robertson! Danger!
Do not flash with tasmota-minimal. You have to start with something that will let you configure the Wi-Fi parameters and minimal will not. This version expects to find the Tasmota settings already in place.

absolut right @meingraham
i tryed one plug with minimal and got an error at wifi conect. Now i can not access to this plug.
Its a TP22 Plug i can also not open it to flash with ftdi -.-

Thanks for chiming in @meingraham, I'll keep that in mind


No mention of how to structure a PendingAirdropId

Problem
Not clear here https://docs.hedera.com/hedera/sdks-and-apis/sdks/token-service/claim-a-token what the pendingAirdropId is in order to claim / reject an airdrop. It looks a composite of the sender, receiver, and token but I had to go to https://github.com/hashgraph/hedera-sdk-js/blob/main/examples/token-airdrop-example.js to figure out what to do.
Solution
Introduce the example from https://github.com/hashgraph/hedera-sdk-js/blob/main/examples/token-airdrop-example.js as a tutorial in the docs and reference what the pendingAirdropId is in the specific SDK sectionf
A tutorial on how to reconstruct the PendingAirdropId without the CreateAirdrop record would also be useful
Alternatives
No response

I added a link to the example as a reference as a short term solution. we'll have to discuss how the tutorial will be prioritized over other items


replace cdn.jsdelivr.net with unpkg.com to speed up the doc site

What's the purpose of this PR
replace cdn.jsdelivr.net with unpkg.com to speed up the doc site
Which issue(s) this PR fixes:
Fixes #4284
Brief changelog

replace cdn.jsdelivr.net with unpkg.com
remove reference to mermaid.min.css as it seems not required anymore(not mentioned on its official site and works ok after removed)
move mermaid initialization as late as possible since its file size is large
the github images loaded by https://cdn.jsdelivr.net/gh/ are not changed as it is still better than https://raw.githubusercontent.com/

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

Codecov Report

Merging #4296 (24a085f) into master (fd1774a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4296      +/-   ##
============================================
+ Coverage     53.17%   53.18%   +0.01%
- Complexity     2669     2670       +1
============================================
  Files           488      488
  Lines         15253    15253
  Branches       1577     1577
============================================
+ Hits           8111     8113       +2
+ Misses         6587     6586       -1
+ Partials        555      554       -1

Impacted Files
Coverage Δ

.../apollo/internals/RemoteConfigLongPollService.java
77.71% <0.00%> (+0.60%)
:arrow_up:

...ervice/service/ReleaseMessageServiceWithCache.java
87.05% <0.00%> (+1.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1774a...24a085f. Read the comment docs.


Documentation:  Update admiral hex to be transparent

Please select a category the issue is focused on?
Other
Let us know where something needs a refresh or put your idea here!
The current logo for admiral-core is not transparent.  This is reflected in the tab icon and is noticeably different when comparing different admiral website together.

You will need to track down the newest version of the admiral logo.
Using pkgdown functions update the website to the most current version of the logo

I believe this is the fucntion https://pkgdown.r-lib.org/reference/build_favicons.html

I think someone just needs to run build_favicons and commit all the updated files it delivers here, as the original logo was fixed via https://github.com/pharmaverse/admiral/pull/1143

@thomas-neitmann do you mind uploading to box into the hex-stickers folder?

Done 👍


When quantizing the Paddle‘s RT-DETR model  , an error occurs during pruning due to the Pad operator.

Hi, sorry for the bug, and I think this bug is already fixed, can you try
pip install git+https://github.com/inisis/OnnxSlim@main


Someday Form renders console error in dev

Prerequisites

[x] Using an up-to-date main branch

Expected Behavior

Start Compass in dev mode locally
Open Dev Tools
Click sidebar to start a new Someday Event
Expected: No console error

Current Behavior
This console error (screenshot below)

Possible Solution (Not obligatory)

Context
This likely started happening as part of #125 / #153

Hey @tyler-dane, you're right about that it started happening after #153. Maybe I will work on this one since is my responsibility.

Sounds good, @DiegoMutre

Unassigned due to inactivity


Handle unencrypted RTCP for AEAD_AES128_GCM

Do we have a test for it?

I'm just reversing a test in the RFC atm


Documentation for command-line tool is out of date

The documentation at https://kythe.io/docs/kythes-command-line-tool.html seems to not correspond with what I get when I run the tool. For example, this is the "help" I get (it doesn't have the search or refs subcommands that are on the documentation page, and adds xrefs and other subcommands):
$ ../kythe/bazel-bin/kythe/go/serving/tools/kythe/kythe -api http://localhost:8080 help
Usage: kythe <flags> <subcommand> <subcommand args>

Subcommands:
	identifier       list tickets associated with a given identifier
	ls               list a directory's contents

Subcommands for graph:
	edges            retrieve outward edges from a node
	nodes            retrieve a node's facts

Subcommands for usage:
	commands         list all command names
	flags            describe all known top-level flags
	help             describe subcommands and their syntax

Subcommands for xrefs:
	decor            list a file's decorations
	diagnostics      list a file's diagnostics
	docs             display documentation for a node
	source           retrieve a file's source text
	xrefs            retrieve cross-references for the given node

Top-level flags (use "kythe flags" for a full list):
  -json=false: Display results as JSON
  -log_requests=false: Log all requests to stderr as JSON

So many of the examples on that page don't work because of this. 😞

The descriptions in the "help" are too pithy to figure out (except for edges, nodes, xrefs ... I can't figure out what kind of argument to give to ls, identifier, decor, etc. A few examples for commands that don't take a ticket would help a lot.


Php extensions

Hello! good package, I need to run the build of a specific project that needs php ext-ftp, even though it is specified in composer.json it gives me the following error:
Box Requirements Checker

Using PHP 8.2.4
PHP is using the following php.ini file:
WARNING: No configuration file (php.ini) used by PHP!

Checking Box requirements:

The package "league/flysystem-ftp" requires the extension "ftp". Enable it or install a polyfill.

any thoughts?

I have some code that relies on zlib, hoping there's a path forward with this🙏


Canonicalize option settings earlier

#535 / 3a7ddcd was a bug due to _zsh_highlight_load_highlighters running with the interactive environment's options. We already call emulate -L in _zsh_highlight for precisely this reason.
Long-term we should switch to an autoload design (#252), but in the interim, we should review the driver to see if we can either:

Run more of the driver's code under canonicalized option settings; or
Review the driver's code to see if it's robust for being run under arbitrary setopt's (particularly including those that change syntax)

Cross-referencing #688.

Triage: not a blocker; depends on #252/#688 which depend on redrawhook which depends on https://github.com/zsh-users/zsh/pull/57; so: deferring to 0.9.0 and labeling so that once redrawhook is merged we'll re-triage this.

Re-triaged.  The dependencies #252/#688 are milestone 0.9.0, therefore so is this issue.  Removing the temporary label (see previous comment).


Provide different classes for the first and last days in date range.

There was no different classes provided for the first and last days in date range, so it was impossible to set different styles for that days. This commit should fix that issue.

Codecov Report

Merging #85 (bd58ddb) into master (4c4bad6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   91.08%   91.14%   +0.06%
==========================================
  Files          23       23
  Lines        1413     1423      +10
  Branches      316      316
==========================================
+ Hits         1287     1297      +10
  Misses        126      126

Impacted Files
Coverage Δ

.../src/lib/components/day-view/day-view.component.ts
100.00% <100.00%> (ø)

.../lib/services/angular-mydatepicker.util.service.ts
90.15% <100.00%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4bad6...bd58ddb. Read the comment docs.

Hi @kuuusama
I merged this pull request and published a new version (0.11.3) of component to npm.


GO build handler not compatible with Windows

When trying to build a stack containing a GO lambda (including the "other/go" template unmodified), on Windows, the following output is generated:
$ npm run build

><EMAIL_ADDRESS>build
> sst build

Error: Failed to build

This is due to a combination of:

the path separator not being escaped correctly;
use of single quotes to surround the -ldflags and -o values.

In addition, the source of the error was obfuscated by the fact that the exception details are not output.
Our modification, which worked on Windows (but may not be compatible with other platforms?) was:
https://github.com/serverless-stack/sst/blob/master/packages/sst/src/runtime/handlers/go.ts
lines 79-94
              if (input.mode === "deploy") {
                try {
                    const target = path.join(input.out, "bootstrap");
-                   await execAsync(`go build -ldflags '-s -w' -o '${target}' ./${src}`, {
+                   const srcPath = src.replaceAll("\\", "\\\\");
+                   await execAsync(`go build -ldflags "-s -w" -o "${target}" ./${srcPath}`, {
                        cwd: project,
                        env: {
                            ...process.env,
                            CGO_ENABLED: "0",
                            GOARCH: input.props.architecture === "arm_64" ? "arm64" : "amd64",
                            GOOS: "linux",
                        },
                    });
                }
-               catch {
-                    throw new VisibleError("Failed to build");
+               catch(ex) { // include exception detail in error message
+                   throw new VisibleError(`Failed to build: ${ex}`);
                }
            }

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


fix: add dependency ts-morph for Signals Input migrator

Add ts-morph as a dependency, which is needed for the Signals Input migrator.

Thanks for the PR. Not sure why I missed this. Even ng-packagr was updated to have ts-morph x.x
@all-contributors please add @rainerhahnekamp for code


docs: add documentation for Ginkgo-based GHA

This commit adds comprehensive documentation on how to use GitHub Actions for Ginkgo Workflows, how to run tests locally, and test a particular SHA using GitHub.
The docs were written on top of https://github.com/cilium/cilium/pull/26019. The PRs can be merged independently.

I note that https://github.com/cilium/cilium/pull/26019 has been merged, so we're good to go about referencing the new YAML files.


Can't download source image: Can't allocate input format context: Server returned 400 Bad Request

the origin in question requires HTTP header passthrough.
HTTP header passthrough works fine for image manipulation.
However, on video thumbnail extraction, it seems like the header is not being sent when making the request via ffmpeg.
{"level":"warning","msg":"[http @ 0x54568c0] HTTP error 400 Bad Request\n","source":"FFmpeg","time":"2023-11-13T12:32:27Z"}
{"client_ip":"<IP_ADDRESS>","error":"Can't download source image: Can't allocate input format context: Server returned 400 Bad Request","level":"warning","method":"GET","msg":"Completed in 83.009904ms /insecure/rs:fit:640:480/vts:5/plain/http://origin/c6141/videos/202303/29/428454621/720P_4000K_428454621.mp4","request_id":"rEK4f-T2OVJANhXkeAmcs","status":404,"time":"2023-11-13T12:32:27Z"}

LGTM


Is there any chance to add Tivibu

Source
https://itveas.tmp.tivibu.com.tr/
Notes
epg: https://itvepg10008.tmp.tivibu.com.tr/iptvepg/frame3046/sdk_getmultiprevuedata.jsp?begintime=2022.08.24+00:00:00&endtime=2022.08.24+23:59:59&channelcodelist=ch00000000000000001064,ch00000000000000001307,ch00000000000000001221,ch00000000000000001021,ch00000000000000001001,ch00000000000000001092,ch00000000000000001159,ch00000000000000001081,ch00000000000000001360,ch00000000000000001361,ch00000000000000001183,ch00000000000000001260,ch00000000000000001024,ch00000000000000001027,ch00000000000000001156,
channel list: https://itvepg10008.tmp.tivibu.com.tr/iptvepg/frame3046/sdk_getchannellist.jsp?columncode=020000&pageno=1&numperpage=500&ordertype=1&isqueryfavorite=1&isqueryprevue=1&ischecklock=1
Sadly it has geoblock, only accessible in turkey :(

I'm sorry, but we can't add a source that is only available from one country.
We use GitHub servers located all over the world to download the guides and we simply have no control over which country the request is sent from.


Bug: Rotate threshold not used in recognizedWith

When setting a threshold on the rotate recognizer and then supplying it to a pinch recognizer, the threshold value is ignored.
Expected behaviour:
When pinching, the rotate threshold should still be used and only start rotating after the threshold is passed.
Actual behaviour:
The threshold is ignored and rotating starts immediately.
Code example:
https://codepen.io/TheDutchCoder/pen/wNoQwV

+1, any progress here?


[UI] make task menu more clearly

Simple improvement, add a space between the menu.
Part 1: Actions regardings this task
Part 2: Action regarding task in context

I splitted the sidebar with 2 menus. I will see after a while if it's better to use...


Add --name suggestion for cargo new

Resolves #8613
Since check_name have already got a parameter to show name help, I reuse the logic and sync the behavior between cargo init and cargo new. The divergence seems to be intentionally made in #7959:
...Only print the --name suggestion for cargo init.
Feel free to discuss.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

r? @Eh2406 Since @Eh2406 are involved in previous discussion.
Also cc @ehuss as the original author of --name suggestion.

I feel like suggesting --name is a little unusual here. The common case doesn't seem likely to be "I want to create an unusual directory name but name the project something different"; that's not a pattern we should actively encourage. The common case is likely to be "Oh, I should use a different directory name". Steering people towards --name doesn't seem like the right answer.

How does something like "if you need the directory name to not match the project name consider the --name flag" sound?

On Wed, Sep 09, 2020 at 03:04:17PM -0700, Jacob Finkelman wrote:

How does something like "if you need the directory name to not match the project name consider the --name flag" sound?

That sounds great.

@ehuss how does this seam to you?

Just rephrase as "If you need a crate name to not match the directory name, consider using --name flag." So the whole message would be something likes
[ERROR] invalid character `¼` in crate name: `a¼`, characters must be Unicode XID characters (numbers, `-`, `_`, or most letters)
If you need a crate name to not match the directory name, consider using --name flag.

I did not choose the suggestion approach mentioned in this comment because in real world the situation is more complex and we may lead to suggest another invalid name.

@ehuss how does this seam to you?

The most recent update looks good to me!

Sounds like the team is on board!
Thank you @weihanglo!
@bors r+

:pushpin: Commit c6fcb0e2efa74131cf456ddf8f3e26a5e65d5aad has been approved by Eh2406

:hourglass: Testing commit c6fcb0e2efa74131cf456ddf8f3e26a5e65d5aad with merge 2c10f2611f123c6964efe46711ad0b945891ee08...

:sunny: Test successful - checks-actions
Approved by: Eh2406
Pushing 2c10f2611f123c6964efe46711ad0b945891ee08 to master...


Install default files from cakebuild.net

bootstrapper
sample build file
configuration file

The sample build file should also be usable as file template (right click -> new File -> Cake)

The sample build file should also be usable as file template (right click -> new File -> Cake)


Remove selections of IR points outside the frame

A few hundred points (<0.03% of total) are somehow recorded as being outside of the 424x424 bounding box of the IR counterpart. Eg,
...
"ir" : {
				"0" : {
					"x" : "-48.5",
					"y" : "391.5299987792969"
				},
				"1" : {
					"x" : "-48.5",
					"y" : "391.5299987792969"
				},
				"2" : {
					"x" : "-48.5",
					"y" : "391.5299987792969"
				}
			}
...

There aren't any obvious similarities in user, subject, survey, operating system, date, physical location of subject, or position with regard to the bounding box.
Needs something in the code to automatically remove these points from consideration.

Same applies to (just a few) radio points as well.


Renaming of finos-fo repo to financial-objects

Description
The name of the Financial Objects repository on GitHub finos-fo does not describe the project and is potentially difficult to find in the FINOS organisation and through GitHub and Google Search.
Potential Solution
By renaming the FINOS Financial Objects repository from finos-fo to financial-objects the new repo name describes the project and becomes easier to find in the FINOS GitHub organisation and through search.
The reference to FINOS is also maintained through the FINOS organisation on GitHub which is referred to within the following URL - https://github.com/finos/financial-objects
Potential Risks

The current url https://github.com/finos/finos-fo/ is indexed on Google and is driving traffic to the project.
The current url https://github.com/finos/finos-fo/ is referred to in documentation and will potentially need to change.
The current url https://github.com/finos/finos-fo/ is referred to in code and will potentially need to change.

Next Steps
The viability of the change should be assessed by the Financial Objects project and potentially be discussed on an Open Developer Platform project call before prioritising the change if relevant.

@grizzwolf - any word of wisdom re. the risks around Google indexing? I suppose it's possible to use Google online tools to ask a reindexing of those pages - and remove old references, right?
@mcleo-d - In any case, GitHub will provide a redirect, so we won't loose traffic.

done!


[BugFix] Allow for nested output keys in Probabilitic modules

Description
Addresses https://github.com/pytorch/rl/issues/927

Codecov Report
Base: 87.96% // Head: 87.89% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (fd5ffbb) compared to base (4d56931).
Patch coverage: 35.71% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   87.96%   87.89%   -0.07%
==========================================
  Files          28       28
  Lines        9561     9572      +11
==========================================
+ Hits         8410     8413       +3
- Misses       1151     1159       +8

Flag
Coverage Δ

linux-cpu
85.91% <35.71%> (-0.07%)
:arrow_down:

linux-gpu
87.82% <35.71%> (-0.07%)
:arrow_down:

linux-macos-cpu
85.91% <35.71%> (-0.07%)
:arrow_down:

linux-stable-cpu
85.94% <35.71%> (-0.07%)
:arrow_down:

linux-stable-gpu
87.82% <35.71%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tensordict/nn/common.py
67.74% <27.27%> (-3.57%)
:arrow_down:

tensordict/tensordict.py
81.00% <66.66%> (-0.03%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@tcbegley Ready for review


chore(codecov): set project coverage rules

Summary by CodeRabbit

Chores

Added configuration for code coverage analysis.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.33%. Comparing base (515ed59) to head (265ed6c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   24.33%   24.33%
=======================================
  Files          78       78
  Lines        6794     6794
=======================================
  Hits         1653     1653
  Misses       5141     5141

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@chemelli74 we should enable this, the lib looks stable.

@chemelli74 we should enable this, the lib looks stable.

Agree, done !


How to merge a local coordinate system in your project?

Hello!
first of all thank you very much for your project. It works perfectly.
I am a beginner in programming for HoloLens 2, so my question is probably not directly for your project, but maybe you can help me.
The plane appears on the center of the QR code, but I want to use this QR code as an orientation to connect a local coordinate system in my space, for example from a robotic system, to the coordinate system of HoloLens2. So that the origins are the same and I can display a hologram on the Hololens with the coordinates from the robotic system. I don't know where in your project to access the coordinates and how to merge the systems.

Hi, I really have no idea, as I have no idea what kind your system might use. HoloLens basically defines 0,0,0 as the place where it was when it started the app, and "forward" as de direction in the horizontal plane it was rotated at that same moment. Maybe the coordinates you need are the coordinates and rotation of the airplane (or the QR code marker) itself? If you know that that should be according to your own coordinate system, you might do some translation math. How that should work, no idea


[BUG Surfer 2.0.5] Upvoting time showing 19 hrs for all

Describe the bug
Upvoting time is showing 19 hrs for all. Suppose if @someuser upvoted in my post 2 minutes ago then 2 minutes should display there but showing 19 hrs flat for all.
To Reproduce
Steps to reproduce the behavior:

Launch eSteem surfer 2.0.5.
In profile page select any blog and check upvoter list.
See the right side.
See error

Expected behavior
In my one new post, i checked the upvoter list and suddenly saw that time is showing 19 hrs but should show 3 minutes.
Screenshots or Video

Smartphone (please complete the following information):

Device: [Hp Laptop]
OS: [Windows10]
Version [10]

Additional context
Time syncing with the server is not proper.

I forgot to let you know this, but this may be related to this: https://github.com/steemit/steem/issues/3245
It's happening to steemd (show nothing), steempeak (second ago). what they're showing depends on how they handle null :)
So I think this isn't esteem's problem (especially considering that steemd has the same problem). probably dsteem library has a problem? based on I tried to figure out myself.

@face2face-utopian That's another well-know problem: https://github.com/steemit/steem/issues/3240
Due to the hivemind migration, many things seem unstable :(

@roadscape let me know in steemit/steem#3240 that this is hive issue: already discussed here: https://github.com/steemit/hivemind/issues/161

Thanks for feedback @face2face-utopian As @economicstudio mentioned this problem is related to hive's backend problem. A temporary patch applied in order to fix it until hive's problem fixed.

Thanks a lot dear.
On Thu, 14 Feb 2019 at 9:59 PM, Talha Buğra Bulut<EMAIL_ADDRESS>wrote:

Thanks for feedback @face2face-utopian
https://github.com/face2face-utopian As @economicstudio
https://github.com/economicstudio mentioned this problem is related to
hive's backend problem. A temporary patch applied in order to fix it until
hive's problem fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/esteemapp/esteem-surfer/issues/208#issuecomment-463694066,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AidL0GHVxEsfcmB8cUXhhfMu4tPia7Vdks5vNY7dgaJpZM4aghjb
.


Precompile Integration Tests

Describe your changes and provide context
(Same as https://github.com/sei-protocol/sei-chain/pull/1379/files just off of seiv2)

Add hardhat tests for each of the precompiles
Test different precompile functions

Testing performed to validate your change

Verified with seilocal hardhat run
Verified with npx hardhat test --network seilocal test/EVMPrecompileTester.js

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.78%. Comparing base (eb56128) to head (d32a63f).
Report is 3 commits behind head on seiv2.

Additional details and impacted files

@@            Coverage Diff             @@
##            seiv2    #1440      +/-   ##
==========================================
- Coverage   62.87%   62.78%   -0.09%
==========================================
  Files         350      350
  Lines       23965    23970       +5
==========================================
- Hits        15068    15050      -18
- Misses       8029     8051      +22
- Partials      868      869       +1

see 2 files with indirect coverage changes


Unsure of keyboard navigation pattern for custom dropdowns

Does down arrow go to list? How do you tab to the link if tab closes the menu?

Old global navigation task. Closing.


feat: Add support for connecting to Redis clusters

This PR adds support to Appsmith server to be able to connect to ElastiCache Redis with cluster mode turned on. When the APPSMITH_REDIS_URL is set to redis://..., the current default behaviour is preserved. But if it is set to redis-cluster://..., then we setup a pooled connection with cluster mod enabled.

/ok-to-test


is there a solution to play drm protected content like spotify?

i can't play spotify when i log in to my account i get this error message {playback of protected content is not enabled}any one has a solution for this issue?

I forgot how many times I've seen someone who doesn't search about their issue first...
Let's answer anyway: There is a Widevine patcher in Supermium program folder, called win7_fixwidevine.bat, if it will work, will work, if it won't, then you're OUT OF LUCK (Just find some music service without DRM or look for patched versions for Win7)

I forgot how many times I've seen someone who doesn't search about their issue first... Let's answer anyway: There is a Widevine patcher in Supermium program folder, called win7_fixwidevine.bat, if it will work, will work, if it won't, then you're OUT OF LUCK (Just find some music service without DRM or look for patched versions for Win7)

thnnks man working for me (solucion a widwvine funciona

As a new-ish supermium user I've been working through this issue as well.
If you need a browser on Windows 7 to play protected content, as I type this, Firefox Legacy ESR 115 does work with CBS, HBO and Netflix which means it probably works for many/most things.
Firefox has a VMP signature, and supermium doesn't, so services that require a VMP signed browser won't allow their content to play. For even more detail see https://github.com/win32ss/supermium/issues/813

@swinokur thank u for the suggestion it seems firefox esr is the only browser that works with drm protected content i've tested so many browsers all of them didn't work with drm content i hope this problem can get solved before firefox esr end the support for w7.

@gokuzgt1 did spotify worked for u?

@Half-Modern i did some recherche before i opend an issue here but i found nothing that helps with this issue,and thanks for mentioning the hiding Widevine patcher file,i just tested it unfortunately it did not work,it seems the only way to play drm content for now by using firefox esr that still support w7,i don't like to use firefox i like to use chromium based browsers like supermium and thorium they are so much smoother and  faster.

@gokuzgt1 did spotify worked for u?

no really now just open but cant  listen any song in spotify :(

Unfortunately, Supermium will need a VMP certificate to play back most content using Widevine. The size of the company can't support the fees to licence a certificate.
I am working on alternative methods, to ensure the continued usage of Widevine and VMP signatures on Windows 7 after all supporting browsers have been discontinued, but it's possible that a browser that already has a VMP signature may be required instead of Supermium.

Unfortunately, Supermium will need a VMP certificate to play back most content using Widevine. The size of the company can't presently support the fees to licence a certificate.
I am working on alternative methods, to ensure the continued usage of Widevine and VMP signatures on Windows 7 after all supporting browsers have been discontinued, but it's possible that a browser that already has a VMP signature may be required instead of Supermium.

no need it at the all just keep support xp and old windows thnks for your hard work god bless all human :)

@win32ss thank you,u already did amazing job with supermium we are grateful for ur work 🙏


Is there any realistic network model on CoreNEURON?

CoreNEURON  is very efficient in network simulation and I found some test results on the ring network. Is there any published realistic network models on CoreNEURON? Thank you so much.

@pineider : Sorry for delay in response.
We are in process of doing this. In meantime if you need any help or have question, I will be happy to help.


Accessing the body response in HTTP searches

Hey guys!
May we have access in body response to make some validations on that?
In my case, the status code is not enough because I'm using an old version of elastic search (1.7.1) that is not compatible with the supported version but I can query in this version using get requests directly, for example:
http://localhost:9200/nginxaccess-*/_count?q=status:%5B500%20TO%20600%5D%20AND%20@timestamp:%3E=now-10m%20AND%20urlpath:\/some-resource*

I have this response body:
{"count":0,"_shards":{"total":8,"successful":8,"failed":0}}

So I can validate the body with a simple regex like: count\":[1-9]+.
Thank you!

@quintanilhar I don't have time to look at this atm, but a PR would be welcome! You'd have to update this file.


Initialize README

As agreed today at the call, adds basic info

@StackScribe

How does one add a new integration or another idea for a potential integration to this repository?

Just creating an issue? Do you expect more documentation?

What action does one take if one is working on an integration that satisfies an idea listed here?

Fair point. Would be nice to document

What about instructions for creating, testing, documenting, and releasing a new integration? Is there a good place to reference for information about getting started? This may be some of the documentation we need to create but, if we have anything, it might be nice to include a link.

I referenced the golang template that should document it. Also we have https://keptn.sh/community/contributing/#keptn-integrations that should be probably improved


Add platformVersion variable due to appium 1.14.x changes

This variable should also be in a "device.properties" file

Coverage decreased (-0.05%) to 31.664% when pulling 8f928b412ab0143f9e6313536d3ceed00ff9e24d on ilia-tad:platform_version_support into ba6835177001a67d5618260d1aeeeea8fece9384 on alfa-laboratory:master.


MINOR: add unit test for Utils.murmur2

I recently needed to port the Utils.murmur hash function to Go for a project I'm working on. I realized there were no definite test cases for the Java implementation that I could use to tell me whether my ported implementation was correct and returned the same results as the code in this project. And although there is test coverage of this hash function by way of a caller in the testKeyPartitionIsStable unit in DefaultPartitionerTest, the granularity of the test there is not sufficient for any developer to write a reliable port in another language of choice.
Fortunately, I found someone who ran into the same trouble as me:
https://stackoverflow.com/questions/48582589/porting-kafkas-murmur2-implementation-to-go
who provided test cases with their solution. I took the test cases from the above and codified them as unit test cases for this hash function in UtilsTest. In this way, any developer writing a custom Kafka client or server in any language can look at these reference cases to confirm the correctness of their implementations with absolute confidence that keys hashed with this murmur function (modulo some number of partitions) land on the right partition.
An open question to the maintainers (and to anyone with expertise in non-cryptographic hashing): do the cases I've given add enough surface area to cover the complete inner workings of this function's mappings?

Not sure how this regression got introduced https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/17834/testReport/junit/kafka.api/PlaintextConsumerTest/testLowMaxFetchSizeForRequestAndPartition/. Any ideas?

retest this please

@mimaison ok to merge this in?

@natemurthy I'm not a committer so I cannot merge it.
@omkreddy @rajinisivaram Can you take a look?

Ping @omkreddy @rajinisivaram


Upgrade dsmr_parser to 0.12

Description:

Upgrades dsmr_parser to version 0.12

Related issue (if applicable): NA
Pull request in home-assistant.io with documentation (if applicable): NA
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Is there a changelog?


Check getresponse signature on import

HTTPConnection.getresponse only accepts a buffering
argument on Python 2.7.
Moving the check to import time means that calls  in
urllib3.connectionpool will always use the correct
signature, regardless of Python version.

Thanks @ncoghlan! It'd be really good if we could test this in some way.

(Note: CI failure is due to flake8, I'll look more closely at the formatting tomorrow)
As far as testing goes, I was treating this more as a refactoring than anything else - if the existing tests pass across all supported runtimes, then I didn't break anything and the replacement code is functionally equivalent to the old code.
What would you be looking for a dedicated test to actually test? The one thing that comes to mind for me would be a test that mocks out urllib3.connectionpool._get_httplib_response to ensure that it's actually being called as expected.

I guess my biggest concern is to confirm that the functionality is really working as we expect, but it's possible that treating this as a refactor is good enough.

I'd second a test, any time you do introspection like this things can easily break on regression later.

Current coverage is 100% (diff: 100%)

Merging #1048 into master will not change coverage

@@           master   #1048   diff @@
=====================================
  Files          21      21
  Lines        1881    1892    +11
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
+ Hits         1881    1892    +11
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update ed7b0f0...f5e5f51

While adding the comments @Lukasa requested, I realised that a really robust guard against a mistake in the import time introspection would be to still trap the possible TypeError when passing buffering explicitly.
However, as I added that guard, I also realised that given the combination of a helper function and the TypeError guard, it becomes possible to replace the helper at runtime the first time it fails, and the import time introspection can be discarded completely.
Essentially it becomes a module level implementation of the strategy pattern - we start with the CPython 2.7 strategy (i.e. pass buffering=True), but if that isn't compatible with the current runtime, we replace it with an approach we know will work.

With the latest changes, I think I'm seeing some sensible test cases as well:

The already suggested case of mocking out _get_httplib_response and ensuring it gets called when expected.
I need to tweak the patch so that the default _get_httplib_response implementation remains available as _get_buffered_httplib_response even if it gets replaced. Then the tests can make sure that conn.getresponse(buffering=True) is called as expected by default and that the implementation gets replaced if that call throws TypeError.

Uh...github seems quite confused about the diff.

Heh, I guess I pushed the online editor to its breaking point :)
I'll switch to editing locally, and not push any new updates until I have the tests written as well.

Starting to write the test case made it clear that the import-time check suggested in this version of the PR is fundamentally flawed, as it doesn't account for ConnectionCls potentially being set on subclasses, so I'm going to close this PR.
However, it should still be possible to only do the try-and-fail-with-TypeError once per connection pool instance, rather than on every attempt to read a response from a connection object, so I'm going to see if I can make a PR that works that way instead.


Add cpus mem

$ docker info
Containers: 0
Nodes: 3
 fedora-1:X.X.X.X:4242
  └ CPUs: 1
  └ Total Memory: 1.957 GiB
 ubuntu-2: X.X.X.X:4242
  └ CPUs: 1
  └ Total Memory: 1.954 GiB
 ubuntu-1: X.X.X.X:4242
  └ CPUs: 1
  └ Total Memory: 1.954 GiB

I see this is marked as in progress -- does that mean you also plan on adding information about how many resources are being used? As far as I can tell, there currently doesn't seem to be a good way to get that information. But, it would be super useful to have for debugging purposes if a container can't be scheduled but you expect it to be able to.
cc @minrk

@jhamrick good idea.

@jhamrick something like this:
Containers: 1
Nodes: 3
 ubuntu-2: X.X.X.X:4242
  └ Total CPUs: 1
  └ Reserved CPUs: 0
  └ Total Memory: 1.954 GiB
  └ Reserved Memory: 1 GiB
 fedora-1: X.X.X.X:4242
  └ Total CPUs: 1
  └ Reserved CPUs: 0
  └ Total Memory: 1.957 GiB
  └ Reserved Memory: 0 B
 ubuntu-1: X.X.X.X:4242
  └ Total CPUs: 1
  └ Reserved CPUs: 0
  └ Total Memory: 1.954 GiB
  └ Reserved Memory: 0 B

@aluzzardi what do you think about the UI ?

Maybe better:
Containers: 1
Nodes: 3
 ubuntu-1: X.X.X.X:4242
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.954 GiB
 fedora-1: X.X.X.X:4242
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.957 GiB
 ubuntu-2: X.X.X.X:4242
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 1 GiB / 1.954 GiB

@vieux Yeah, that second example you gave is exactly what I was thinking. Also maybe you could include how many containers are running on each node, in addition to the total number of containers?

@jhamrick @aluzzardi please take another look:
Containers: 10
Nodes: 3
 ubuntu-2: XXXX:4242 - Containers: 7
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.954 GiB
 ubuntu-1: XXXX:4242 - Containers: 1
  └ Reserved CPUs: 1 / 1
  └ Reserved Memory: 0 B / 1.954 GiB
 fedora-1: XXXX:4242 - Containers: 2
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 1 GiB / 1.957 GiB

I'm worried that it won't be easily parsable by external calls to the API - do we care about doing that?

I feel like it was useful information, @jhamrick ?
I agree it looks heavy, but docker info | grep <name> | cut -d : -f 2,3 still works :D

Looks great to me! :+1:

this looks very useful! :+1:

LGTM


Add blog for e2e-skeleton plugin

Signed-off-by: John Schnake<EMAIL_ADDRESS>

Tweaked the ci for the linter; seems odd but extending the timeout did make a meaningful difference. It took 1m28s to complete, just over the 1m default timeout. But really? Because of my one new file?
Regardless, leaving those tweaks in with the blog post.

Fixed based on your feedback; I did lean on that crutch of using a TL;DR; to get full context early on. Updated some CSS to make block quotes more attractive. Typically used for "NOTE: ..." or "TL;DR; ...."


Add ability to Invite user(s) to a workspace in offline mode

Add ability to invite user in offline mode and display offline info in the bottom of the member page.
Details

Fixed Issues

$ https://github.com/Expensify/App/issues/6676
Tests

[x] Verify that no errors appear in the JS console

Open workspace member page
Turn off internet/wifi
Verify offline message appear at the bottom of the page
Go to invite page and invite some users
Verify invited  users emails/name is grayed out
Turn on wifi and wait until re-sync icon indicator disappear and please make sure invite API request success
Go to HOME url
then navigate to that MemberPage
Verify the grayed out members displayed  same as other (in black color)
Repeat steps from 1-5.
Close browser tab
Turn on Wifi
Open Home URL and please make sure Invite API request success
Verify the grayed out members displayed  same as other (in black color)

QA Steps

[x] Verify that no errors appear in the JS console

Open workspace member page
Turn off internet/wifi
Verify offline message appear at the bottom of the page
Go to invite page and invite some users
Verify invited  users emails/name is grayed out
Turn on wifi and wait until re-sync icon indicator disappear and please make sure invite API request success
Go to HOME url
then navigate to that MemberPage
Verify the grayed out members displayed  same as other (in black color)
Repeat steps from 1-5.
Close browser tab
Turn on Wifi
Open Home URL and please make sure Invite API request success
Verify the grayed out members displayed  same as other (in black color)

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop
[ ] iOS
[x] Android

Screenshots

Web

https://user-images.githubusercontent.com/1313124/152715282-ec41c23f-7049-46fc-ad83-f205011a4674.mp4
Mobile Web

https://user-images.githubusercontent.com/1313124/152715913-5c914f30-878f-40f8-bccf-a38ff5b8757c.mp4
Desktop

iOS

Android

https://user-images.githubusercontent.com/1313124/152715865-42631d0d-b419-42b5-8945-3be83c1df835.mp4

@NikkiWines If you have free time, Could you test this PR? So we are clear which part of the code/functionalities that need to be modified.
Thank you.

Yep, sorry I'm OOO doing some recruitment this week but will try to get to this when I have time

Seems to be some weird behavior from step 7 onwards for the QA steps @K4tsuki. After going back online the greyed-out users stay grey and then a couple of seconds later they disappear.
https://user-images.githubusercontent.com/16747822/153501163-7ed5f170-1ae7-4086-b958-6504886192f9.mov

@NikkiWines Could you confirm in the developer tools that Policy_Employees_Merge request, after reconnect to network, that API request is keep on pending.
https://user-images.githubusercontent.com/1313124/153518859-4e1e07cf-831f-49a0-b059-e94e1228353c.mp4
This is because the network isn't quite ready and there is no timeout setting for http fetch:
https://github.com/Expensify/App/blob/1aa52edd2e0960a92ce704e342fa5490c36512ac/src/libs/HttpUtils.js#L22-L28
So the request is keep on pending.
My solution is to add timeout setting around 4-5 seconds in the fetch after network reconnect and then revert back to current fetch setting after couple of seconds.

@NikkiWines I have updated the QA steps.
Many changes on the code based on parasharrajat  request.

When testing locally I'm not seeing Policy_Employees_Merge successfully completing after reconnecting. It just ends up failing immediately. Seems like maybe we need to make sure that call is included in the reconnection callbacks we handle after coming back online? We seem to do something similar in PersonalDetails.js for fetchPersonalDetails().

For reconnection callback, we already have the mechanism, if user don't close browser tab/application on offline state the  Policy_Employees_Merge will be automatically requested after user reconnect.
If user close browser tab, then that API request will not send, and here  I add persisted: true flag in API request to make it persisted in onyx local data even after user close tab and reopen it.
Persisted requests is processed here:
https://github.com/Expensify/App/blob/5e37ec71184956ca5bd7c6d471cf45054e09d503/src/libs/Network.js#L105-L119
After network back to online flushPersistedRequestsQueue is called, but right after reconnect network isn't quite ready so the request is get pending, I setTimeout for  flushPersistedRequestsQueue();  around 1500ms and it works
I have another suggestion above to add timeout of the http request, so the browser will fail that request after certain seconds and application will retry the request.

For reconnection callback I have used it retrieve policy data, to check policy members stored in the server after pending invitations requested, but parasharrajat requested to remove it.
What should we do here?

@NikkiWines For reconnection callback, we already have the mechanism, if user don't close browser tab/application on offline state the Policy_Employees_Merge will be automatically requested after user reconnect.

Sorry for being unclear, or maybe I'm misunderstanding something. What I meant to explain was that I'm not seeing that behavior (even if I don't close the tab/browser/app)
Here's a video. You can see that for several seconds after reconnecting nothing happens. After refreshing the pending users are removed.
https://user-images.githubusercontent.com/16747822/154594658-4031a238-c386-4331-bf84-0ea8b6e737e5.mov

@NikkiWines I am sorry for being really unclear.
In my PR:
The Policy_Employees_Merge after adds persisted: true. when network reconnect, the request is being processed here:
https://github.com/Expensify/App/blob/5e37ec71184956ca5bd7c6d471cf45054e09d503/src/libs/Network.js#L105-L119
in  line -> flushPersistedRequestsQueue();  and there is no wait some seconds after network reconnect so the request get pending for a long time.

In current code: (without persisted: true)
The Policy_Employees_Merge in offline mode is being queued and processed here after network reconnect:
https://github.com/Expensify/App/blob/c049cc4d16ec71606fb635a7d7913d21b0e876f1/src/libs/NetworkConnection.js#L20-L25
Notice the 5000, so right after reconnect it waits 5000ms.

If I remove the persisted: true, it will be the same with current code  and will be processed inside triggerReconnectionCallbacks above.

@K4tsuki I'm still not understanding why we're not leveraging NetworkConnection.onReconnect() to help with the pending requests.
However, I think let's first apply @parasharrajat's feedback about making these changes specific to Policy.js instead of adding global utilities. Once those changes have been applied we can do another fresh review to dig into things more

@NikkiWines ,

why we're not leveraging NetworkConnection.onReconnect() to help with the pending requests.

So basically what I want to say is: by removing persisted: true we get the same behavior as NetworkConnection.onReconnect().
We don't need to explicitly add NetworkConnection.onReconnect callback for Policy_Employees_Merge.

first apply @parasharrajat's feedback about making these changes specific to Policy.js instead of adding global utilities. Once those changes have been applied we can do another fresh review to dig into things more.

All right.

Done, but just some lint error. Need review.
And waiting for @NikkiWines for network onReconnect details.

@NikkiWines are you suggesting In offline stateto make Policy_Employees_Merge API request after NetworkConnection.onReconnect on pending invitation list?

Yes, this is what I was thinking

Yes, this is what I was thinking

How about invitation message? Save it in pendingInvitation list too? So it will be list of object right?
When user open App should I call the callback in fetchAllReport? or where should I call it?
Thank you.

How about invitation message? Save it in pendingInvitation list too? So it will be list of object right?

Oh yeah, good point. I think we'd want to  save the workspace name and policyID actually. But saving the whole welcomeNote would also work in place of the workspace name. It would be a list of objects, yes.

When user open App should I call the callback in fetchAllReport? or where should I call it?

I think it should be a new function sendPendingWorkspaceInvitations or something like that in Policy.js - then that function can would call invite()? Does that make sense?

@parasharrajat, definitely a good call to make sure we're still doing things optimistically.
We still add the user to the policy employee list optimistically (in invite()), so I think it might be fine?  But definitely happy to consider a more optimistic approach as well.

I haven't forgotten this PR. I will review it tomorrow first thing. It seems that the above discussion is yet to be concluded.

@K4tsuki do need more clarification from me about https://github.com/Expensify/App/pull/7595#issuecomment-1047357894 or does the 👍 mean you agree and/or what I said makes sense.
@parasharrajat are your concerns about the optimistic check for my suggestion alleviated?

Do need more clarification from me about https://github.com/Expensify/App/pull/7595#issuecomment-1047357894

@NikkiWines No, I will try to make the commit.

Sorry, wasn't aware of this PR but I'm going to close it out. These changes are going through a Design Doc process instead. Maybe there's some good stuff here we can use 😄

@marcaaron can you clarify which design doc we'll include this within? I just want to ensure I'm listing the right "next step" on https://github.com/Expensify/App/issues/7587

Nevermind - we just closed that GH, ignore me.


Enhancement: IAM role support

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html
I'd love to use this.  But, without the IAM role support I really can't.

@Shawn When running rClone config please try the auth param. Please try
adding the additional IAM params required to End Point when running rClone
config wizard https://s3.amazonaws.com?TheParam=value&
?TheParam=Value&
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/Query-Requests.html
On Tue, Jun 30, 2015 at 2:25 PM Shawn Butts<EMAIL_ADDRESS>wrote:

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html
I'd love to use this. But, without the IAM role support I really can't.
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/85.

I'm afraid I don't know very much about IAM roles.  If @zeshanb idea works I'd be happy to write it up in the docs.
This would probably be made easier by the branch I have for using the official AWS API...

I couldn't get it to work.
I'm sure this will work out of the box with the official AWS SDK.
Thanks

Thanks for having a go
-- Nick


Expose error in status property when loading from local file system

When making a GET from the local file system an error will not be visible from the outside caller as the status property will be set to 0 which is the same as if the GET was successful.

I'm not sure if it completely adheres to the XHR spec, but it's better than returning status code 0. I'll merge it and I'll let you know when I release it.

Thanks!

I've just released this in version 2.0.0.

Thanks!


Using pre-compiled FStar binaries with master branch

Thank you very much. I have replaced fstar.exe by fstar_<IP_ADDRESS>_Windows_x64. Before I used fstar.exe of fstar_<IP_ADDRESS>_Windows_x64. But there are still some questions. The errors are showed in the following figure. I don't know the reason. I am looking forward for your answer. Thank you very much.

We re-enabled weekly binary builds: https://github.com/FStarLang/binaries/tree/master/weekly
These binaries are kept up to date with changes in FStar, but still aren't guaranteed to work without any other commit hash than the one they were built from.


CurrencyField

Lots of models have a currency field but the field attributes are duplicated each time.  This could be
simplified if we had a currency field class.

This should set the correct decimal settings and support a default value

The currency field alone is not very usable - multi-currency sites might need functionality for currency conversion etc, so I believe for now the most efficient would be integrate third-party application that implements both field and conversion.


Inoke-DbaQuery with multiple result sets

Hey all:)
I'm struggling to get this working...
Executing a Stored Procedure with Inoke-DbaQuery which returns multiple result sets with at least one row each.
I'm only receiving the e first set as output...
$test | Invoke-DbaQuery -Database master -Query '[POB_Dataload].[GetAllServiceUser]' -CommandType StoredProcedure
Best
Matthias

Have a look at the parameter -As

Wow, that was quick and exactly what I needed!

No problem, glad I could help.


Remove unused TraceEvent Windows-only dependencies two ways.

Summary
The unused Windows-only TraceEvent native dependencies are being included in the published output of dotnet-monitor. This is happening because publish is not resolving the paths in absolute terms. To fix this, add another removal entry that matches the relative paths used by TraceEvent to prevent them being included during publish.

Release Notes Entry

/backport to release/7.0

/backport to release/6.x


👌 Parse test name to mock executable

Can be useful for the hash hook (and if we want to add a hook to dump inputs with no cache-hit)

I guess you are also planning of using it?

So in terms of the hashing: I was thinking to use it for https://github.com/lsmo-epfl/aiida-lsmo/pull/108#issuecomment-1326778113; to read in and manipulate the .xyz file, only for the specific test that was failing. But for now I've just gone for a more simple fix.
For outputting input files for failed cache hits (not yet implemented), it would certainly be useful though; to put them in an output folder based on the test name.


Support the tags with equals reference

Extend support for multiple tags of equals context.
Example:
<link rel="icon" href="favicon-32.png">
<link rel="icon" href="favicon-64.png">
<link rel="icon" href="favicon-128.png">

But, it makes no sense to manipulate favicons, you have to is fixed in index.html

@airtonix
Thanks for feedback man, will be available in the next release Issue 9


[oracle] price alarms dispatch error handling algorithm

Current implementation uses submessages reply mechanism to remove successful alarms from the storage, which is not efficient.
A new algorithm should remove alarm on sending and reinsert it in case of an error.

already implemented


Implement multi-column index

Currently the cross-column indices are composed as strings, for example
id_name
this does not work well with numeric fields (e.g. integer, number, date) because of lexical sorting order e.g.
-1_1 > 10_1
need to change the design. Things to consider include (but not limited to)
B-tree with multilevel keys
Quad-tree
R*-tree
Grid File

The multi-column index implementation is removed. Need to implement a working one. Most likely we would implement B-Tree with custom comparators as a stop-gap solution, but it cannot replace other possible data structures for different needs (e.g. spatial data with lots of range queries are more efficient with Grid File).

Multi-column indices have now been implemented (using B-Tree). Marking this bug as fixed. We can open a separate bug when/if the time comes to add other implementations (Grid file etc).


feat: add AWS SDK v3 upload example

Closes https://github.com/remix-run/examples/issues/163
Description

Moves the "old" S3 upload example in a different folder and calls out that its for an old version of the S3 SDK.
Adds a new example for the new AWS S3 SDK v3.

@mcansh @MichaelDeBoey

@mcansh of course! I'll try and update the code and the branch this weekend, as this week is full with work 👌

@MichaelDeBoey Yes! However, I need to find the time 🙏


Closes #1375 1375_fix_single_dose: split data before data checks

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

@bms63 , I have update the first test to test that the bug is fixed.

I would consider missing EXDOSFRQ as a data issue. So I think we do not need a test for it.


Wrong path in "Metrics, Parameters and Plots" "Get Started" Docs

Hi all,
I think this path: https://github.com/iterative/dvc.org/blob/b89c074d6faca564e54898247ae42452363f2353/content/docs/start/data-management/metrics-parameters-plots.md?plain=1#L77C22-L77C22 must be changed to eval/live/metrics.json, otherwise dvc metrics show yields an error claiming it cannot find eval/metrics.json.
Result with original dvc.yaml:
❯ dvc metrics show
DVC failed to load some metrics for following revisions: ''.
Path
eval/metrics.json

Result with changed dvc.yaml:
❯ dvc metrics show
Path                    avg_prec.test    avg_prec.train    roc_auc.test    roc_auc.train
eval/live/metrics.json  0.9014           0.95704           0.93196         0.97743

I'm using python 3.10.12 and dvc 3.24.0.

Thanks for the report @CoffeeMugTwo! That path is correct, but unfortunately it looks like the code that you downloaded in https://dvc.org/doc/start/data-management/data-pipelines#setup is outdated. We will get it fixed ASAP. In the meantime, you can find the updated code in https://github.com/iterative/example-get-started.


ROCm 5.0 bare metal with 6800xt/6900xt

Hello,
My workstations still run 4.5.2 within docker compute environment, which is a compromise from bare metal, which i couldn't get to work at the time. I'm tight on time for experimenting and hesitating to run 5.0 just yet without community confirmation.
How's the ROCm 5.0 bare metal experience with 6800xt/6900xt now? Any hick ups?
Regards

I've just spotted fresh tensorflow-rocm package, version 2.8.0, in pip. Works on bare metal with 6800xt, installed the driver with "rocm,hip,opencl" and simple pip install tensorflow-rocm. I've yet to test 6900xt, should be a breeze.
Just an update before closing issue.

@ROCmSupport Thank you for clarification, if it wasn't for 4.5 i'd jump off MAD ship. Trajectory of 5.0 just gave me peace of mind.
You explicitly mention 6800XT, should i expect 6900XT to work? I'm fine with it running just OpenCL, but a clear pointer would save me time on experimenting.
Also with understanding and acknowledging of unofficial support status, will 6850XT/6950XT be similar enough to 6800XT/6900XT to be viable upgrades for next purchases in terms or ROCm use?

Hi @aoolmay
I can not comment on future plans. Request to keep track of our documentation.
Thank you.

I've just spotted fresh tensorflow-rocm package, version 2.8.0, in pip. Works on bare metal with 6800xt, installed the driver with "rocm,hip,opencl" and simple pip install tensorflow-rocm. I've yet to test 6900xt, should be a breeze. Just an update before closing issue.

Hey can you shred light on the Rx 6800. Afaik it is Navi 21 also, so it should be simple too. I just want a quick confirmation before purchasing. Thank you.

ROCm 5.0.2 + tensorflow-rocm works well with 6800XTs and lately 6900XT as well if that's your focus. OpenCL works great. I gave up on experimenting with out of spec software setups, so just do everything as per manual.
Hybrid, but off the shelf water+air cooled cards run days on ridiculous overclocks, which nets +25% performance on some workloads. Mind you i have my workstations in separate room that's air conditioned to 16 degrees Celsius 24/7. Might want to pay a little extra and get one with the highest boost ceiling, if time to completion means money to you it'll pay off in spades.
Poor performance on small parallel workloads though. GPU time doesn't get divided equally, so there's some uncertainty there to work around.

I've tested ROCM5.1.3 with 6900XT, 6950XT, Radeon PRO W6800 cards.
6950XT is better than 6900XT.
Installation was so simple!

@SturtKoh Did you have the opportunity to test multi task capability of W6800?
From my testing 6800XT and 6900XT can't handle any two or more tasks efficiently. Compute resources are divided extremely unevenly and this leads to unpredictability. Navi cards ( both gaming and workstation versions ) didn't have problems with running multiple tasks at all, i'd run 20 models on WX7100 without problems. I'm wondering if W6800 would solve my multi tasking problem.


Fix dead lock from pending threads

Fixes: #252

:+1: . Looks good to me.

I noticed another issue not related, fontContext can have a single reference from threads and and be deleted from there, which involve atlas texture deletion and a bad access. I'll open an issue for that.