Feature/rmax psurgev29

Rebased #139 after CI fix.

Codecov Report
Attention: Patch coverage is 37.58389% with 93 lines in your changes missing coverage. Please review.

Project coverage is 20.96%. Comparing base (43e3f4b) to head (69c1ebb).
Report is 2 commits behind head on main.

Files
Patch %
Lines

ensembleperturbation/perturbation/atcf.py
26.82%
90 Missing :warning:

ensembleperturbation/utilities.py
33.33%
2 Missing :warning:

ensembleperturbation/parsing/adcirc.py
90.90%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   20.82%   20.96%   +0.13%
==========================================
  Files          28       28
  Lines        3846     3983     +137
==========================================
+ Hits          801      835      +34
- Misses       3045     3148     +103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Why was merged again?

Why was merged again?

I guess your question is about the email you got about the other similar merge which I closed. The other merge was your own branch on your fork, I just rebased that one based on the latest ensemble perturbation and then pushed it to the main repo (since I couldn't push to your fork). Then I created this new PR for the branch on main repo to be merged (see https://github.com/noaa-ocs-modeling/EnsemblePerturbation/pull/139#issuecomment-2274151457)

No, should be good..


fix: removed extral space between sections

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Thanks for the reply 😊

We are marking this pull request as spam. Please note that if you are participating in Hacktoberfest, two or more PRs marked as spam will result in your permanent disqualification.
If you are interested in making quality and genuine contributions to our projects, check out our contributing guidelines.


No issue, but question: is is production ready?

We have done some experimenting with Guetzli and we are very happy with the results. A big reduction in image sizes; thanks for this! However now I have a question: it Guetzli production ready? Can we use the latest release, add it to our containers and use the binary on production? Or is it too early?

We deployed this on a site with ~18000 public-facing images of which we host a full-sized version and a thumbnailed version about 10 days ago. The conversion finished in about 2 days. So far, everything has been great. No errors while encoding, no serious artifacts that we've noticed.

Security-wise, we have devoted so far something on the order of tens of CPU hours for fuzzing and we will have it fuzzed on oss-fuzz soon (google/oss-fuzz#480). However, Guetzli is a JPEG file parser, so I'd suggest a high level of caution if you run it on untrusted images. I strongly recommend sandboxing it (e.g. using seccomp).
Usability-wise, there are valid JPEGs which Guetzli is unable to parse (e.g. any downsampling other than 4:4:4 or 4:2:0). It will fail to recompress such JPEGs (return a nonzero exit code); however, it will happily compress those images if provided as PNGs.


Fix eval batch loop

Fixes evaluation loop, otherwise raises ValueError: Incompatible shapes for broadcasting due to shapes mismatch.

thanks for your PR can you make this change and open PR in beta branch instead of Main ?


DVConstraints evalFunctions inconsistent passing of references + values

Description
When evalFunctions and evalFunctionsSens is called for each type of constraint, one of two things happens. Either a fresh set of values is returned back to the dict() with all the constraints in it, or a reference to an existing array (which may have been present at previous iterations).
For example, the ThicknessConstraint always passes a reference to a FRESH array of values, whereas the CircularityConstraint passes a reference to the same array each time. If the dict() is manipulated outside, it can affect the internal values. Alternatively, a user may inadvertently save a result from a previous iteration without realizing it's a live reference which can be changed later on. I discovered this will writing reg tests for the circularity constraint.
Should probably be made consistent but this may produce breaking behavior in very few edge cases where people are relying on the current reference behavior.
Code versions
List versions only if relevant

Python
…

I think this is probably worthwhile bringing up for discussion, and if everyone is on board we should absolutely make this consistent and documented.


Performance drops significantly when echoing the /world/shapes/dynamic_pose/info topic

Desired behavior
@iche033 discovered that echoing the /world/shapes/dynamic_pose/info topic for a world with a lot of shapes results in a significant RTF decrease. On my machine, I found that my RTF dropped from 90% to 10% when I started to echo this topic (using TPE, and running headless).
Alternatives considered
TBD
Implementation suggestion
It seems like this function is being called, which causes the slow down. So, I think that we should try to optimize this method.
Additional context
At first glance, it appears as if this could be related to #711, since the method linked above uses a lot of Each calls.

@iche033 I think that we can close this now that #856 is merged. If you look at the new performance testing numbers in the PR description of #856, the /world/shapes/dynamic_pose/info RTF is a lot better now. If you think that the new performance of this topic with #856 is good enough, let me know, and I will close this.

sounds good, closing


Actual trades executing on exchange client

Overview
Now that everything is in place, we need to go through and check that trades actually execute using the new architecture.
Implementing the remaining swappers is out of scope for this task - we just need lifi and thor working.
References and additional details
See MultiHopTrade.tsx for details.
Acceptance Criteria
Trades actually execute using the new architecture for

lifi swapper

evm

thorchain swapper

uxto
cosmossdk
evm
cross account trades (manually selected)

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
1 day

Thor working, need to test lifi


Android Pie (9) Support

First.
Need to add support for API28 final

@iBotPeaches, you had just took the fun from others to report about a zillion issues regarding this... LOL! 😱
~Ibuprophen

Not work miui
27.08.2018 22:14:57] W: W: warning: string 'wapi_user_cW/ResourceType( 4520): DynamicRefTable(0x10): No mapping for build-time package ID 0x10.
[27.08.2018 22:14:57] W: W: W/ResourceType( 4520): e[0x01] -> 0x01
[27.08.2018 22:14:57] W: W: W/ResourceType( 4520): e[0x7f] -> 0x7f
[27.08.2018 22:14:57] W: W: E/ResourceType( 4520): Failed resolving ResTable_map name at 1868 with ident 0x100b0015
[27.08.2018 22:14:57] W: W: W/ResourceType( 4520): DynamicRefTable(0x10): No mapping for build-time package ID 0x10.
[27.08.2018 22:14:57] W: W: W/ResourceType( 4520): e[0x01] -> 0x01
[27.08.2018 22:14:57] W: W: W/ResourceType( 4520): e[0x7f] -> 0x7f
[27.08.2018 22:14:57] W: W: E/ResourceType( 4520): Failed resolving ResTable_map name at 3388 with ident 0x100b0010
[27.08.2018 22:14:57] W: W: W/ResourceType( 4520): Attempt to retrieve bag 0x1001004f which is invalid or in a cycle.


Can't run tests in Android Studio OR Gradle with kotlintest-runner-junit4 > 3.1.5, can't run tests with Gradle with kotlintest-runner-junit4:3.1.5

I'm having some trouble setting up kotlintest in an Android project. We currently have two types of tests in our project, both using the JUnit4 test runner. This is maybe related to issue #385
We have JUnit4 tests that look like this:
@RunWith(JUnit4::class)
class PokoTest {
    @Test
    fun test() {
        assertThat(1).isEqualTo(1)
    }
}

We have Robolectric tests (for when we need to access Android classes to test) that look like this:
@RunWith(RobolectricTestRunner::class)
class RobolectricStringFormatterTest {
    // Robolectric allows us to access an Android Context to load system resources, among other things
    private val context = RuntimeEnvironment.application
    private val subject = StringFormatter(context)

    @Test
    fun anotherTest() {
        assertThat(subject.format("abc")).isEqualTo("a-b-c")
    }
}

I would like to start migrating to using the different style Specs in place of JUnit4 tests.
However I can't get the tests to run in both Android Studio (v3.2.1) which we need for development, and through the command line/gradle which we need for our CI.
Here is our app-level build.gradle (tried to pare it down a bit)
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'kotlin-android-extensions'
apply plugin: 'kotlin-kapt'

repositories {
    jcenter()
    mavenCentral()
    google()
    maven { url 'https://repository.apache.org/content/repositories/snapshots/' }
    maven { url 'https://jitpack.io' }
    maven { url 'https://maven.fabric.io/public' }
    maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
}

androidExtensions {
    experimental = true
}

tasks.withType(Test) {
    testLogging {
        events "passed", "skipped", "failed"
    }
}

android {
    compileSdkVersion 28
    buildToolsVersion '27.0.3'
    defaultConfig {
        applicationId 'com.foo.bar'
        minSdkVersion 21
        targetSdkVersion 28
    }
    dataBinding {
        enabled = true
    }
    dexOptions {
        preDexLibraries true
    }
    testOptions {
        unitTests.includeAndroidResources = true
        unitTests.all {
            useJUnitPlatform()
        }
    }
    sourceSets {
        main
        release
    }
}

dependencies {
    def versionArchLifecycle = '1.1.1'
    def versionRobolectric = '3.8'
    testImplementation("android.arch.core:core-testing:$versionArchLifecycle", {
        exclude group: 'com.android.support', module: 'support-compat'
        exclude group: 'com.android.support', module: 'support-annotations'
        exclude group: 'com.android.support', module: 'support-core-utils'
    })
    testImplementation 'com.nhaarman:mockito-kotlin-kt1.1:1.5.0'
    testImplementation('com.squareup:fest-android:1.0.8') {
        exclude group: 'com.android.support', module: 'support-v4'
    }
    testImplementation 'org.mockito:mockito-core:2.18.3'
    testImplementation "org.robolectric:robolectric:$versionRobolectric"
    testImplementation "org.robolectric:shadows-httpclient:$versionRobolectric"
    testImplementation "org.robolectric:shadows-multidex:$versionRobolectric"
    testImplementation "org.robolectric:shadows-playservices:$versionRobolectric"
    testImplementation "org.robolectric:shadows-supportv4:$versionRobolectric"
    testImplementation 'com.github.javafaker:javafaker:0.13'
    testImplementation "com.android.support.test:runner:1.0.2"
    testImplementation "com.android.support.test:rules:1.0.2"

    testImplementation 'io.kotlintest:kotlintest-runner-junit4:3.1.5'
}

kotlin {
    experimental {
        coroutines "enable"
    }
}

When we use 'io.kotlintest:kotlintest-runner-junit4:3.1.5', all types of test (JUnit4, Robolectric, KotlinTest) run just fine in Android Studio. However, running ./gradlew testLocalDebugUnitTest --tests {a JUnit4 test, a Robolectric test, or a KotlinTest test class name}, I get the error: No tests found for given includes: [{whatever test class name(s) passed in to command}]. When I try to run all tests using the command ./gradlew testLocalDebugUnitTest I see a test report with this exception:
org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not complete execution for Gradle Test Executor 3.
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:63)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
	at com.sun.proxy.$Proxy1.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.stop(TestWorker.java:123)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.junit.platform.commons.util.PreconditionViolationException: Cannot create Launcher without at least one TestEngine; consider adding an engine implementation JAR to the classpath
	at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:285)
	at org.junit.platform.launcher.core.DefaultLauncher.<init>(DefaultLauncher.java:55)
	at org.junit.platform.launcher.core.LauncherFactory.create(LauncherFactory.java:59)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:90)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$100(JUnitPlatformTestClassProcessor.java:77)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:73)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:61)
	... 25 more

When we use 'io.kotlintest:kotlintest-runner-junit4:3.1.10', I can't run any type of test in Android Studio, and I see this error in the console: Exception in thread "main" java.lang.NoClassDefFoundError: org/junit/platform/launcher/TestExecutionListener (related to #385 ?), plus I get the same error when trying to run tests through the command line.
I'm happy to close this issue if it's just an issue with my setup, but I can't seem to figure out where that issue might be

Not sure if this is helpful, but if I remove
unitTests.all {
    useJUnitPlatform()
}

I can run all tests through the command line/Gradle, both on kotlintest-runner-junit4:3.1.10 and kotlintest-runner-junit4:3.1.5.
I still have the same issue on 3.1.10 running tests in Studio, but on 3.1.5 the tests still run fine in Studio.
So as a temporary workaround, just removing the useJUnitPlatform and staying on 3.1.5 seems to work for our use case

@Kerooker I am running Android Studio v3.2.1. Not sure what version of Intellij that corresponds to.
Our gradle wrapper version is 4.7
I will try your suggestions, starting with the invalidate/restart, although I do believe I've tried that already.
Thanks for the quick reply!

It's likely that you tried it already. But every bug in android starts with "try to invalidate caches and restart"

But if you're able to (it would be awesome if you could!), can we try to pinpoint exactly the version that started this issue?
You said that with 3.1.5 everything runs fine (flawlessly? never errors?). But we have some more versions before 3.1.10, if you could try them:

[ x ] 3.1.5
[  ] 3.1.6
[  ] 3.1.7
[  ] 3.1.8
[  ] 3.1.9
[  ] 3.1.10

We know for sure that it doesn't work in 3.1.10 and that it works in 3.1.5

3.1.6 does not work in Android studio, same NoClassDefFoundError. I assume that means all following releases will also not work.
I will try the steps outline in the SO post later today and get back to you

Interesting. This is a point to start digging, by release 3.1.6.
Thanks! That a lot of help already :)

I think that the only commit from 3.1.5 to 3.1.6 that may change something in JUnit's execution is https://github.com/kotlintest/kotlintest/commit/5124afacf4c57fb873f732b4a9803dc5e74085ac. @sksamuel Do you believe this may be causing issues with Intellij/Android Studio, when it tries to execute a JUnit 4 test?

Yes possibly. That annotation exists purely so that the little "run" icon appears in intellij, because it looks for the presence of these annotations in a file to determine if a class is a test class or not.

@Kerooker Adding the compileDebugUnitTestKotlin step does not allow tests to run in Android Studio for versions > 3.1.5, neither does invalidating/restarting.
For now I will stay on version 3.1.5 which allows the tests to run in Studio, and remove the useJUnitPlatform, which allows tests to run via Gradle.
Thanks for the help

I couldn't reproduce this issue.
No answer from OP in a good time
No other users having this problem.
I'll be closing this. Feel free to open a new issue if you can reproduce it


Generated Secret Connection keys are all zeroes

This is a critical bug. Via the forums:
https://forum.cosmos.network/t/ann-tendermint-kms-v0-2-validator-signing-support/1361/11?u=iqlusion
xxd /opt/tmkms/config/secret_connection.key
00000000: 0000 0000 0000 0000 0000 0000 0000 0000 …
00000010: 0000 0000 0000 0000 0000 0000 0000 0000 …

I am investigating.

Another data point: on Linux, debug builds appear to generate a random key, but release builds do not.

I've found the cause: a bug in the subtle-encoding crate where the encoding/decoding functionality was unintentionally gated on a debug_assert_eq! and therefore worked in debug builds, but failed in release builds.
Open PR to fix it here: https://github.com/iqlusioninc/crates/pull/126

That PR has been merged. I'll try to get a release of everything, including tmkms, out later today.
I have also updated the CI configuration for subtle-encoding to run the tests in release mode to ensure this sort of thing doesn't happen in the future. I also confirmed that doing so would've caught this bug:
https://travis-ci.org/iqlusioninc/crates/jobs/459482729

This will be fixed in the forthcoming v0.2.1 release, which should be out shortly.


import tensorflow fails as missing rocsolver library

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information
Ubuntu1804
Tensorfow installed from binary: pip3 install tensorflow-rocm upgrade
Python 3.6.9
mi-25
Describe the current behavior
root@sriov-guest:~/dev-learn/gpu/tflow/tensorflow/tflow-2nded# python3 -c 'import tensorflow as tf'
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow.py", line 64, in
from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: librocsolver.so.0: cannot open shared object file: No such file or directory
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.6/dist-packages/tensorflow/init.py", line 41, in
from tensorflow.python.tools import module_util as _module_util
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/init.py", line 40, in
from tensorflow.python.eager import context
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/eager/context.py", line 35, in
from tensorflow.python import pywrap_tfe
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tfe.py", line 28, in
from tensorflow.python import pywrap_tensorflow
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow.py", line 83, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/pywrap_tensorflow.py", line 64, in
from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: librocsolver.so.0: cannot open shared object file: No such file or directory
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
root@sriov-guest:~/dev-learn/gpu/tflow/tensorflow/tflow-2nded# dpkg -l | grep rocsolver
ii  rocsolver                                  <IP_ADDRESS>300-52                                 amd64        AMD ROCm SOLVER library
root@sriov-guest:~/dev-learn/gpu/tflow/tensorflow/tflow-2nded# find /opt/rocm-4.3.0/ -name librocsolver.so.0
/opt/rocm-4.3.0/rocsolver/lib/librocsolver.so.0
/opt/rocm-4.3.0/lib/librocsolver.so.0
Describe the expected behavior
import should be ok
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

after installing rom4.3.1 it appears to work.


chore(deps): update dependency prettier-eslint-cli to v5

This PR contains the following updates:

Package
Type
Update
Change

prettier-eslint-cli
devDependencies
major
^4.7.1 -> ^5.0.0

Release Notes

prettier/prettier-eslint-cli
v5.0.0
Compare Source
chore

Update eslint and require node 8+ (489a0b3)

BREAKING CHANGES

Update eslint to version 5 and require node 8+

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

Travis build is failing due to https://travis-ci.community/t/error-installing-oraclejdk8-expected-feature-release-number-in-range-of-9-to-14-but-got-8/3766


icu76: 76.1rc -> 76.1

Update ICU 76.1 rc to official 76.1 release
Comment temporary change enabling testing of ICU rc version.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351275

x86_64-linux

:white_check_mark: 2 packages built:

icu76
icu76.dev


Caching

It's not complicated to extend HTTP Driver to have cache. A request object can have an option for time-to-live, then when the driver receives the request object, it keeps the response and the respective request in a Map. When a new request comes in it is checked against that Map. Alternatively, the request object can have an option fresh which always ignores cache.

Shouldn't caching be the responsibility of the HTTP layer? (Though of course, this is not an ideal world...)

We can either put caching as a driver configuration on the factory, or a configuration on the request. Or both. I need to investigate.

I was thinking of HTTP caching http://tools.ietf.org/html/rfc7234

Yes, if you have that, great.

This issue was moved to cyclejs/cycle-core#234


Windows 7,8 drivers

Is there a way to make AIOC work with Windows 7 or 8?
I tried about a million drivers without luck.
Hope someone can give me a hint.

The AIOC uses built-in drivers (USB standard drivers). I am not sure, why your machine is not loading them. Is there an error Message somewhere?

There stands if I translate to english "There were no driver for the device installed (Code 28)".
This is on Windows 8.1. I tried it also on my laptop with the same result and a friend of mine on Windows 7. Everywhere the same.

Then I tried to find USB class 2 Audio drivers and manually installed them to the device but nothing worked so far.
On my tablet with windows 10 it found the drivers without problems.

It may be possible that the Version of Win 7/8 is too old, for installing these automatic USB drivers, but I am not sure. But since there are no updates any more for those Windows versions, I am not sure how you can make sure, you have the latest Win 7/8.. Hm

yes it seems like. If someone has an idea what driver I can try please let me know.

I am afraid if nobody else has an idea, you are out of luck. From my side, any OS that doesn't support the USB Audio Class 2.0 codec is unsupported due to time limitations.
So I am going ahead and close this issue. If you have new information, feel free to re-open.

For future reference, the working serial COM port driver for Windows 7 is https://www.st.com/en/development-tools/stsw-stm32102.html
I was, however, not able to find an audio and DFU driver which would match yet.

How did you install the STM32 driver? I think it's for a totally different USB VID:PID pair belonging to STM32.
This is not the correct driver, although it looks like it's working.
The correct driver's are the windows built-in CDC, UAC2 and HID drivers.


Fixing scope for dispatchCustomEvent on melody stream components.

What changed in this PR:
Fixing scope issue of dispatchCustomEventin melody-streams component.
While calling dispatchCustomEvent we lost the correct scope for this function to work. This change stores the correct context for later calling this.el.dispatchEvent.

Not needed anymore as @fbring fixed the issue with some nice tests in parallel.


docs: suggest disabling the official extension

bors r+ :robot:

Does this show up in the extension text as well?

No, don't think so.


Uncaught DOMException: Failed to execute 'insertBefore' on 'Node'

I am building a TreeView component for fun and ran into this bug which is very similar to one bug solved in June.
The error happens when I remove a branch of my tree and try to place it higher up in the tree hirarchy.
The error I get is:
utils.js:9 Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
at append (http://localhost:1234/src.77de5100.js:2764:12)
at domdiff (http://localhost:1234/src.77de5100.js:3148:23)
at Object.anyContent [as fn] (http://localhost:1234/src.77de5100.js:3889:53)
at http://localhost:1234/src.77de5100.js:3525:25
at http://localhost:1234/src.77de5100.js:3554:21
at unroll (http://localhost:1234/src.77de5100.js:4176:11)
at unrollArray (http://localhost:1234/src.77de5100.js:4200:18)
at unroll (http://localhost:1234/src.77de5100.js:4163:3)
at Object.update (http://localhost:1234/src.77de5100.js:4127:20)
at Object.render (http://localhost:1234/src.77de5100.js:4003:28)
append | @ | utils.js:9
  | domdiff | @ | index.js:155
  | anyContent | @ | tagger.js:232
  | (anonymous) | @ | index.js:82
  | (anonymous) | @ | index.js:109
  | unroll | @ | index.js:189
  | unrollArray | @ | index.js:210
  | unroll | @ | index.js:184
  | update | @ | index.js:158
  | render | @ | index.js:30
  | render | @ | TreeView.ts:33
  | (anonymous) | @ | TreeView.ts:27
I tried to reproduce using a simpler setup but failed.
I will try and reproduce when I am more awake.

Code to reproduce:
import { html, render } from "lighterhtml";

type Kind = "frame" | "control";
const NOT_SET = "NOT SET";
export interface NodeData<K> {
  kind: K;
}
export interface ITree<T> {
  id: string;
  data: T;
  children: ITree<T>[] | null;
}
interface ITreeConfig<T> {
  id: string;
  target?: HTMLElement;
  tree: ITree<T>;
}
export class SimpleTreeView<T extends NodeData<K>, K = any> {
  private id: string;
  public tree: ITree<T>;
  private target: HTMLElement | null = null;

  constructor({ id, target, tree }: ITreeConfig<T>) {
    this.id = id;
    this.target = target || null;
    this.tree = tree;
  }

  public render(target?: HTMLElement | null) {
    target
      && (this.target = target);
    this.target
      && !(this.target as any).context
      && ((this.target as any).context = this);

    return this.target && render(this.target, () => html`

      ${this.tree && renderTreeNodeView(this.tree)}

    `);
  }
}

function renderTreeNodeView<T extends NodeData<K>, K = any>(subtree: ITree<T>): HTMLElement {
  let children = subtree.children;
  console.log("render node " + subtree.id)
  let childViews = children && children!.map((c) => {
    return renderTreeNodeView(c);
  });
  return html`

      ${subtree.id}${subtree.data!.kind}
      ${childViews}

  `;
}

type MyKind = "frame" | "button";
interface ITreeData { id: string, parent: string | null, data: { kind: MyKind } };
function createTree() {
    let treeData = [
        { id: "root", parent: null, data: { kind: "frame" as MyKind } },
        { id: "n1", parent: "root", data: { kind: "frame" as MyKind } },
        { id: "n2", parent: "root", data: { kind: "frame" as MyKind } },
        { id: "n3", parent: "n1", data: { kind: "button" as MyKind } },
        { id: "n4", parent: "n1", data: { kind: "button" as MyKind } },
        { id: "n5", parent: "n2", data: { kind: "button" as MyKind } },
    ];
    let nodeLookup = treeData.reduce((acc, cur) => { acc[cur.id] = toITree(cur); return acc; }, {} as Indexable<any>);
    function toITree<T>({ id, parent, data }: { id: string, parent: string | null, data: T }): ITree<T> {
        return { id, children: null, data };
    }
    let myTree = nodeLookup[treeData.shift()!.id];
    treeData.forEach((node) => {
        if (node.parent) {
            nodeLookup[node.parent!].children = nodeLookup[node.parent!].children || [];
            nodeLookup[node.parent!].children.push(nodeLookup[node.id]);
        }
    });
    return myTree;
}
let myTree = createTree();
var view = new SimpleTreeView({ id: "tree1", tree: myTree });
view.render(document.body);

// This change causes the crash
let n2 = myTree.children.pop()
myTree.children.unshift(n2);
view.render();

It'd be very helpful to have JS example so I can actually debug real code and exclude the transpiler caused issues.
I also don't use TS and I'd like to keep doing so. Thanks for helping out.

Btw, reading the code as is, it looks like you are doing few things a bit wrong:

an element children is not an Array, you cannot push nodes
you need to use lighterhtml to render stuff. If you do DOM operations by your own, you are messing up the library ownership of its content

In few words, I'd like to see the following:

an example based in plain JS
zero home-made changes on the tree, as that's not how lighterhtml works (or any of its similar projects)

Once these requirements are met, I can think about resolving a bug. Right now, there's nothing for me to work at, as techniques used in this example are both misleading and indirect due transpilation.

Here is a link to a code pen with JS code and the bug:
https://codepen.io/allnamesrtaken/pen/KKKBvZE
I am not doing manual html manipulations. I am only pushing and manipulating the tree data structure. All the rendering is done using lighterhtml.

Thanks, I'll have a look this evening or tomorrow early morning (GMT+01). 👋

@AllNamesRTaken if you use this import instead:
import { html, render } from "https://unpkg.com/holedhtml?module";

everything seems to work as expected, could you confirm?
I've basically refactored the hell out of lighterhtml for this reason, and many mores ... please let me know how that works, so that I'll be more confident in publishing version 2.

v2 is out, so if you use import { html, render } from "https://unpkg.com/lighterhtml?module"; instead of pika thing, you'll see no errors.
I am going to close this, as the whole logic changed, and I believe all old possible issues have been resolved.
Please let me know if that's not the case, thanks.

Yes you are right it works. I was reporting this at the same day it was fixed and npm might not have updated. Now there is a 2.0.1 version and it works. Thanks.


Possible typo in example timing template.

Should line 13 in papers/common_issues/code/timingExample.py be b1 instead of b0?

Yes. Fixed. Thanks!


remove random creation timestamp from pod sort by age test

Addressing previous PR feedback: https://github.com/kubernetes-sigs/descheduler/pull/833#discussion_r890913475
/cc @ingvagabund

/approve
/lgtm


add a single target field to simplified playbook

This is a very simple PR adding an extra filed target (simplified playbook only). Suitable for cases with a single target so the user won't need to write a list of targets with a single host in
Internally it resolved on the low level, as parsing of the simplified playbook was happening. All it does is add this target to the list of targets. It means the user can even combine both, but I don't see why one would want to do it.
Generally it is a small quality-of-life improvement, nothing major

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 84.932%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
1939

Relevant Lines:
2283

💛  - Coveralls


[commerce-sdk-react] Implement shopper baskets hooks

This PR implements the shopper basket API hooks in the commerce-sdk-react package.
Changes

finalize useBasket, usePaymentMethodsForBasket, usePriceBooksForBasket, useShippingMethodsForShipment, useTaxesFromBasket and useShopperBasketsMutation implementation
by default, disable queries if the IDs are undefined.
created a new utility hook useLocalStorage
create a new public API hook useCustomerId

Cache key structure proposal
I wanna propose that we structure the cache keys based on the path of the REST API endpoints,
useBasket: ['/baskets', parameters.basketId, arg]
usePriceBooksForBasket: ['/baskets', parameters.basketId, '/price-books', arg]
usePaymentMethodsForBasket: ['/baskets', parameters.basketId, '/payment-methods', arg]
useShippingMethodsForShipment: ['/baskets', parameters.basketId, '/shipments', parameters.shipmentId, '/shipping-methods', arg]
useTaxesFromBasket: ['/baskets', parameters.basketId, '/taxes', arg]
Why?
React query cache keys are always arrays, it matches cache keys based on the equality of the entries in the array, start from the first item to the last, this gives us the ability to invalidate the following options:

invalidate all shopper basket api query cache
queryClient.invalidate(['baskets'])

invalidate a single basket cache entries
queryClient.invalidate(['baskets', parameters.basketId])

invalidate a sub-entity in a basket, e.g. payment methods
queryClient.invalidate(['baskets', parameters.basketId, '/payment-methods'])

To do

[ ] Finish up tests

IRL discussion with team, I'll create a new ticket to add more tests, properly. Gonna remove the tests that doesn't provide value for now.


Review task collection after task-package refactor

Ref https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/378.
This won't probably require any change (as per https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/378#issuecomment-1578058244), but we should check that we never rely on the tasks being in the main tasks package.
As for the manifest, for the moment we are not moving it away from the main package.

I would expect this to work. For both the scMultipleX as well as the faim-hcs package (see e.g. here: https://github.com/jluethi/faim-hcs/tree/fractal-roi-tables/src/faim_hcs), I am using task collection from wheels with this package structure and it's working fine.
The only thing I stumbled over a few times was making sure all the files were actually included in the wheel, i.e. adding
[options.package_data]
faim_hcs = __FRACTAL_MANIFEST__.json

to the setup.cfg to make sure the manifest was packages and adding an __init__.py to the new subfolder.


Saving Publisher Profile (Person)

Seems to be a small problem when, after the Publisher profile has been granted by an admin, the user enters his information, a NOT NULL constraint failed occurs.  I'm going to fix this immediately.

Beta server has been updated with all the newest changes.


docs(operators): describe your change...

hi.
Error: button is not defined
Error: clicks$ is not defined

Description:
Fixing Documentation Example

Pull Request Test Coverage Report for Build 8206

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 96.805%

Totals

Change from base Build 8203:
-0.2%

Covered Lines:
5242

Relevant Lines:
5415

💛  - Coveralls

@JWO719 Hi. i dont know how to change the commit message. can i change it now?

see https://help.github.com/en/articles/changing-a-commit-message. Basically you can use git commit --amend and do another push to your fork.

@JWO719 I was able to update the message during the Squash/merge. :)
Thanks, @xeptore!


rufo fails to run after triggering rails omnicompletion

Repro:
[tim@hood]$ cat <<EOF > /tmp/vimrc
set nocompatible
call plug#begin()
Plug 'ruby-formatter/rufo-vim'
call plug#end()
syntax on
filetype on
filetype indent on
filetype plugin on
autocmd FileType ruby,eruby let g:rubycomplete_buffer_loading = 1
autocmd FileType ruby,eruby let g:rubycomplete_rails = 1
EOF

[tim@hood]$ vim -u /tmp/vimrc config/initializers/kaminari_config.rb

# trigger omnicompletion somewhere by entering edit mode and hitting CTRL-x CTRL-o
# then try issuing the :Rufo command - you'll see this error output:
/usr/local/rvm/gems/ruby-2.5.1/gems/bundler-1.16.1/lib/bundler/rubygems_integration.rb:458:in `block in replace_bin_path': can't find executable rufo for gem rufo. rufo is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)
        from /usr/local/rvm/gems/ruby-2.5.1/gems/bundler-1.16.1/lib/bundler/rubygems_integration.rb:478:in `block in replace_bin_path'
        from /usr/local/rvm/gems/ruby-2.5.1/bin/rufo:27:in `<main>'
        from /usr/local/rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:15:in `eval'
        from /usr/local/rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:15:in `<main>'

I have rufo installed globally, not in the bundle.  I use junegunn/vim-plug for vim plugin management, but I'm guessing that has no bearing on this issue.  Prior to triggering omnicompletion rufo runs fine.

Looks like this is caused by omnicompletion loading the bundle which then breaks rufo.  These environment variables seem to be the main culprits: GEM_HOME GEM_PATH and RUBYOPT.  Doing something like:
let l:out = systemlist('echo ' . shellescape(l:selection) . '| ruby -e "defined?(Bundler) ? Bundler.with_clean_env { system(%(rufo) } : system(%(rufo)"')

may work, but wondering if that would break things for someone who only has rufo installed as part of a bundle.  Will have to do some testing and hopefully submit a PR in the next couple days.


setup.py depends in censys package

Hi,
I was trying to install censys on Windows and the following error:
> python -mpip install censys
Collecting censys
  Downloading censys-0.0.8.tar.gz (10 kB)
    ERROR: Command errored out with exit status 1:
      command: 'C:\%SOME_PATH%\Python\Python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\%USER%\\AppData\\Local\\Temp\\pip-install-k9vn638_\\censys\\setup.py'"'"'; __file__='"'"'C:\\Users\\%USER%\\AppData\\Local\\Temp\\pip-install-k9vn638_\\censys\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\%USER%\AppData\Local\Temp\pip-install-k9vn638_\censys\pip-egg-info'
        cwd: C:\Users\%USER%\AppData\Local\Temp\pip-install-k9vn638_\censys\
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\%USER%\AppData\Local\Temp\pip-install-k9vn638_\censys\setup.py", line 4, in <module>
        import censys
    ModuleNotFoundError: No module named 'censys'
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

This is using Windows embedded Python 3.7.7 with pip 20.0.2. Since the cwd is the censys package it should be in sys.path but it doesn't seem the case. Maybe because setup is in in an inline command. I'm not sure if importing the still uninstalled package is recommended.
Install worked fine on macOS.

This issue is specific to the embedded Python distribution. It doesn't add the empty string in sys.path.
I added to following in sitecustomize.py: import sys; sys.path.insert(0, ''). This require import site in python37._pth. As described here: https://dev.to/fpim/setting-up-python-s-windows-embeddable-distribution-properly-1081
See also pypa/pip#6163 about PEP-517 and "import to-be-installed package" support.
Cheers!


Improve SKILLS block

Current SKILLS block is more like TECHNOLOGIES, but I've been thinking about making it more "universal", i.e. picking a word that would be equally semantically correct if applied to the same block in different résumés. CREDENTIALS would fit just fine probably. This way HR managers, sales managers, and people of other occupations would still be able to list terms and techniques they're familiar with and it would still be considered "credentials" ("a qualification, achievement, quality, or aspect of a person's background, especially when used to indicate their suitability for something").

Naw, let's call it SKILLS, but let's add more stuff there, in a form of a list maybe.

Closed in https://github.com/volodymyr-kushnir/volodymyrkushnir.com/pull/197.


Put this plugin on Bower

The other handsontable libraries (handsontable, ruleJS, etc.) are available for download via bower. It would be nice for this plugin to be available via bower as well, to make it easy to manage all of them in the same way.

In the meanwhile:
bower install https://github.com/handsontable/handsontable-ruleJS.git --save

Nice! I wasn't aware that was possible. Thanks. :smile:


Docs link in building page

This PR adds a short sentence w/ a link to the Binder documentation from the loading page. Many BinderHub users (particularly new ones) will first experience Binder by clicking a link, not from going to mybinder.org. This makes sure that we show them a link to the docs on the loading page itself.
It should look like this when loading:

(restarted the build, it was a timeout error)

looks like travis is happy now, LMK what you think about the target=blank thing...I am not super opinionated on that one


Change format of cell uris so that it is harder to guess

Notebooks use the the CellUri to create a uri for a specific cell of a notebook. The rules are

take notebook uri
replace scheme with vscode-notebook-cell
append a padded fragment of the cell handled (padded for lexical-sort of uris)
append the notebook's scheme unless it's file

Samples:
Cell 1 of notebook file:///some/notebook.ipynb is vscode-notebook-cell:///some/notebook.ipynb#ch0000001
Cell 21 of notebook memfs:///some/notebook.ipynb is vscode-notebook-cell:///some/notebook.ipynb#ch0000021memfs
This format is an implementation details and the problem is that it is so obvious that folks starting to program against it (instead of using API, e.g for discovering a notebook for a cell etc). To prevent this we should make the format a little less obvious, e.g. by encoding the fragment a little.

/cc @rebornix

/cc @weinand I believe debugging does or did make assumptions about the cell uri format

@jrieken in the notebook debugging samples the debugging functionality did not make assumptions about cell uri format.
But since VS Code persists breakpoints independent from debuggers via their resource URI, it is possible that a persisted cell breakpoint "gets broken" when the cells of a notebook are rearranged and then the notebook cell URIs get new sequential numbers in their URI fragment.
For this problem the notebook debugging samples tried to "fix" the persisted breakpoints when they detected that cell rearrangements happened.
If cell URI would be robust, this ugly workaround would not be necessary.
@roblourens is my assessment still true for the current notebook debugging approach?

I can't think of anything in debugging that makes assumptions about the format. Changing the format will break anything that is stored by cellURI, like persisted breakpoints. So if we change it we might consider a simple one-time migrationwith the update

So if we change it we might consider a simple one-time migrationwith the update

I am not sure how CellUri is used but a relatively simple adoption would be to let CellUri#parse support the old and new variant for a while. @roblourens Can you check with your usage and see if that would work?

For this problem the notebook debugging samples tried to "fix" the persisted breakpoints when they detected that cell rearrangements happened.

I do understand the desire for stable URIs but this specific case is also a good sample for why the format should be obfuscated. This specific "massage" isn't working since roughly a year more (due to https://github.com/microsoft/vscode/commit/ce02917f666e1a72bdb6a60891e0616c821a0f53) and we don't want to invite people to make assumptions...
Stable cell uris/identity is likely another topic and while I believe this is coming (has come?) to jupyter it isn't defined for other notebooks. There is also a specific issue with displaying cell uris in the workbench: we don't have the concept for pluggable resource sorters and therefore cell uris are crafted so that they sort lexicographically well. This makes the problems and references view look nice...

/cc @rchiodo I found something that looks like an assumption about the format of the fragment. What's that for and can that work without these assumptions?
https://github.com/microsoft/vscode-jupyter/blob/62356af10732e2bbf1c520e9cea0ad8420ab3f27/src/client/datascience/notebook/intellisense/logReplayService.ts#L152
That was the only usage I could find but I am curious if you know about more such places?

Yes actually this is used here:
https://github.com/microsoft/lsp-notebook-concat/blob/d9fae2e518e2e32a8ebc97e723e2f3120161566a/src/notebookConcatDocument.ts#L231
We use this in pylance for computing where a notebook cell is in a document when it is created. I think @dbaeumer's new LSP messages will eliminate this need though (as the cells positions are contained in his new messages).

The first location you mentioned is a debug tool we use for replaying customer's logs. We'd need some way to pull apart the cell URI for that to continue to work because we don't have the actual notebook originally associated with the URI.

We'd need some way to pull apart the cell URI for that to continue to work

Can you explain what pulling apart uris means?

Take the cell index out of the fragment. We need that (during the log replay) to determine what cell a 'textDocument/didChange' event to apply an edit to.
The log replace service is used to try and repro intellisense problems. Customer sends a log of all the LSP requests and a notebook that they started with.
We open the notebook and for every textDocument/didChange event we figure out which cell the edit is for and reapply it. Since the notebook URI doesn't match what we have locally, we just scrape the fragment portion to compute the cell index. Seems like it should work to replace the path part of the URI with our local file and then just search on the cell that matches instead. But that would also presume that the rest of the URI would be consistent across machines.

Since the notebook URI doesn't match what we have locally, we just scrape the fragment portion to compute the cell index. Seems like it should work to replace the path part of the URI with our local file and then just search on the cell that matches instead. But that would also presume that the rest of the URI would be consistent across machines.

Ok, thanks for clarifying. I believe a better approach is checking for the vscode-notebook-cell-scheme and simply use the whole fragment without making assumptions about its form. Roughly like so
if(step.textDocument.uri.scheme === 'vscode-notebook-scheme') { // check fixed scheme
	const replaced =  this.activeNotebook
              .cellAt(0)
              .document.uri.with({ fragment: step.textDocument.uri.fragement }); // use with, no string-replace
	step.textDocument.uri = replaced
}

I think @dbaeumer's new LSP messages will eliminate this need though (as the cells positions are contained in his new messages).

Do you have an ETA for adopting that?

Do you have an ETA for adopting that?

The pylance team would also need to switch to adopting it. Probably this month some time.

@rchiodo has the new LSP messages makes it possible to not rely on the cell URL format.

@rchiodo Did that adoption happen?

No it did not.

I believe @msfterictraut is in the process of making  an experimental version of pylance to adopt this new API.

I'm not working on that. The pylance team might be.

@rchiodo can you figure out who is working on that and that the timeline is. thanks

You could ask @heejaechang or @bschnurr.

Thanks for the update @debonte. Please keep me in the loop once you have migrated so that we can the URI change happen

I added Pylance to the proposed API exception list so that they can give it a try.

@debonte How is the roll-out going? Can we make this change now?

@jrieken, no we haven't started the experiment yet. @dbaeumer had suggested that we split the code changes into two chunks -- first upgrade to the latest LSP, second add the LSP notebooks code as an experiment. And he recommended shipping the first part (LSP upgrade) to insiders first. The Python core extension has done this (their current insiders build is using LSP 3.17), but unfortunately Pylance doesn't have a real insiders build, so shipping the LSP upgrade to insiders requires us to make some build/publish infrastructure improvements.
Is there time pressure on this change for some reason? We could speed things up a bit by just shipping the LSP upgrade in our next stable build, bypassing the insiders step.

Is there time pressure on this change for some reason? We could speed things up a bit by just shipping the LSP upgrade in our next stable build, bypassing the insiders step.

No real pressure but it's just another ball I need to keep in the air. The work on my side is done and I keep snowplowing this item. It mostly about the overhead and chance of merge conflicts. If you can conformably speed it up, I'd be very thankful.

@debonte Monthly ping

@jrieken The changes for the experiment were checked in today. Prerelease builds with experiment support will ship tomorrow. Current plan is to start the experiment on Monday.

👯 Thanks for the update

@debonte I wanna finally make this change happen in July? Any objections? @rchiodo Same question

Post that being fixed we'd still make assumptions about notebook URIs. We need this in order to determine if the TextDocument for the input box in the interactive window is tied to the notebook for the interactive window or not. @jrieken I'm not sure if you're changes will make this impossible or are they only dealing with the fragment portion?

The 'logReplayService' above isn't really necessary. It's just a debug tool.

or are they only dealing with the fragment portion?

@rchiodo Only the fragment portion. The new format is more obscure but has the same properties: sorts by cell orders and encodes the cell index.
@debonte Assuming are going ahead with this change. What's the impact on your end? What will break and intermediate change can you make?

@debonte Assuming we are going ahead with this change. What's the impact on your end? What will break and what intermediate change can you make?

Because we depend on the lsp-notebook-concat code that Rich referenced above, I believe this would cause the ordering of cells to be wrong for anyone using Pylance's concat doc-based notebook support. Depending on how the cells are misordered, this could cause most language server features to misbehave. This would impact any user that is not in the LSP notebooks experiment treatment group or who is using Interactive Window.
The Jupyter team owns this code and would be best able to say how it might be adjusted to support both the old and new formats.
FYI, Rich is OOF this week.

I believe this would cause the ordering of cells to be wrong for anyone using Pylance's concat doc-based notebook support.

The new format makes the same ordering guarantees, e.g when sorting by the toString()'ed uri of the cell-documents you get the same order as before. It is just harder to extract the actual (numeric) value from the URI

The lsp-notebook-concat code we are currently using gets the cell fragment as a number like this:
parseInt(cellUri.fragment.substring(2) || '0')

My understanding is that this won't work properly with the new format. That was my point.

Yeah, parsing the fragment into a number won't work anymore but looking at how the parse result is actually used gives me confidence. The value is kept in NotebookSpan#fragment and the only usage of the that field seems to be a simple comparison.  That will continue to work with the fragment as-is (because cell-order is encoded in the fragment part)

Maybe it should be more explicit that it's a string compare (instead of using '<').

Unsure - the comparison operator might be best suited here because it faster and more narrow-spec'd than localeCompare (I believe). I also see this as a temporary fix, e.g using the LSP concat is the way to go but the question is what do you do assuming we make the fragment-change at the end of the week?
The patch I have suggested is a good stepping-stone to prevent breakage but it isn't an alternative to LSP. It just less fragile: today we assume the fragment (1) parses to a number and (2) the numbers are comparable and with my patch we assume (1) the fragment is comparable. That's better but not the optimum, use LSP is the optimum but I haven't seen that happening  in the last months and I want to make progress

Oh maybe it doesn't. Fragment today would compare the same I think.

Yes, the change can happen today because comparing the fragment is already behaving like that

Okay the fragment change made it through all the layers for jupyter. Our build tonight will have the new fragment change.


chore(TDI-46073): Create github release note containing release PR/commits

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:

PR is not needed.
The change was covered by another PR


Nested array do not work as expected

Php::Value x = Php::Array();
x["a"]    = Php::Array();
a["a"][0] = 1;
a["a"][1] = 2;
return x;

Expected result:
Array
(
    [a] => Array
        (
            [0] => 0
            [1] => 1
        )

)

Actual result:
Array
(
    [a] => Array
        (
        )

)

Related: #254 (if Php::array_push() is fixed, the test won't work as expected anyway).

Same is true for objects:
Php::Value x = Php::Object();
x["a"]    = Php::Object();
a["a"]["b"] = 1;
a["a"]["c"] = 2;
return x;

Returns:
stdClass Object
(
    [a] => stdClass Object
        (
        )

)

Sorry, my bad - full recompilation has resolved the issue.


Printing true on each log sent

Hello,
First of all, thank you for this good plugin, it is very useful :)
It is not really a big issue, but the LogDNA.log() function is printing true every time it is executed properly. It is flooding my logs while debugging and I do not really see why it is there :/
Have a nice day :)

Hello,
Thanks for your kind words. It indeed prints true, which was probably done while debugging or something. It's an easy fix that I can implement soon. Thanks for raising this.

@ArchOrn
Created a PR, if someone stumbles upon this issue, can use this branch until the PR is merged!
  logdna:
    git:
      url: https://github.com/Rohithgilla12/logdna_flutter

Thank you @Rohithgilla12 I have merged. Will create a new release soon


Issue 742: serializers and copiers asciidoc

Needs a rebase

Will close this PR to do some more changes on the documentation and fold in fixes for ehcache/ehcache.org-site#12
And the will re-open a PR with these changes + additions to be merged.


Travis is now paid

I only just now learned that Travis switched to a paid-only plan, even for FOSS projects. It seems that this transition has already occurred for Vienna:

If that is indeed correct and if the cost per build minute (50 credits) is also true, then the project will run out of credits shortly.

I suggest we remove Travis for now and utilise only the GitHub CI. We can mark it as required to pass.
Unless @barijaona, do you want to apply for a renewable credit allocation for FOSS?

OK, let's try the GitHub CI way. But as a first step, I would not set it as required to pass.

@barijaona We have been using GitHub CI for a while - if we remove Travis CI we should require GitHub CI to pass before allowing any merges.
This will prevent any build issues and broken unit tests...

The problem is that we added tools without providing adequate documentation about use and implications… The situation is intimidating for newcomers in Vienna development.
The situation is even worst with SwiftLint…

It looks as though Travis has not even responded to credit requests, if their support forums are an indication. Having someone request this regularly is undesirable for the project anyway. I have no second thoughts about GH Actions, given that GitHub is Vienna’s hub. If GitHub goes a similar route, then there will be options, no doubt.


Update tutorial for API key requirement and mapzen.js changes

The tutorial was broken because it did not set an API key for the basemap vector tiles and the map would not display. These changes fixes that, as well as makes other updates to the content for mapzen.js.
Note: These issues were found while searching the docs for https://github.com/mapzen/documentation/issues/192, but is not dependent on that work and can be merged separately after a content review.

adds a global API key from mapzen.js to support vector tiles and geocoding
removes a Tangram scene option for the mapzen.js basemap that is being deprecated and gave a console warning
updates how the geocoder passes options to match https://mapzen.com/documentation/mapzen-js/search/#options
updates mapzen-xxxxx placeholder for preferred your-mapzen-api-key
adds link to developer guides topic on choosing a text editor, rather than reusing the same paragraph
updates links to new URLs for creating an API key

Actually, let's hold on this. I found an issue with the API key parameter in mapzen.js that will change some of the code here. https://github.com/mapzen/mapzen.js/issues/374

The fix is now in mapzen.js (v0.6.9), so these changes can be merged!


Secret / configmap updates do not trigger a reconcile

Description:
Secret and configmap updates do not trigger a reconcile.
This can impact certificate changes and certain rotation procedures, config updates.
Repro steps:
Since secrets don’t have a spec or generation field, this predicate causes us to ignore any updates to secret keys. Completely replacing the secret will trigger reconciliation, but if someone only updates the secret keys, those changes will be skipped.
https://github.com/envoyproxy/gateway/blob/main/internal/provider/kubernetes/controller.go#L1209

related -> https://github.com/envoyproxy/gateway/issues/3500

Fixed in favor of #3499


Undefined variable $pdo in class DB

352    Undefined variable: $pdo
353    Undefined variable: $pdo
https://github.com/Usbac/wolff-framework/blob/345a2253984bf20b42dbc38fa968fe25f1b6f248/system/core/DB.php#L352-L353
Changing those to self::getPdo() would fix them, right?

Fixed e38b688.


Hyperd - POD  failed to load sandbox info: leveldb: not found

For some reason hyperd is trying to initialize or load a POD.

kubeadm reset
systemctl restart hyperd

Result:
HYPERD
● hyperd.service - hyperd
Loaded: loaded (/usr/lib/systemd/system/hyperd.service; enabled; vendor preset: disabled)
Active: active (running) since Mon 2017-06-05 13:43:34 CDT; 27s ago
Docs: http://docs.hypercontainer.io
Main PID: 12880 (hyperd)
CGroup: /system.slice/hyperd.service
└─12880 /usr/bin/hyperd --log_dir=/var/log/hyper
Jun 05 13:43:34 master01 systemd[1]: Started hyperd.
Jun 05 13:43:34 master01 systemd[1]: Starting hyperd...
Jun 05 13:43:34 master01 hyperd[12880]: time="2017-06-05T13:43:34-05:00" level=info msg="Graph migration to content-addressability took 0.00 seconds"
Jun 05 13:43:34 master01 hyperd[12880]: time="2017-06-05T13:43:34-05:00" level=info msg="Firewalld running: false"
Jun 05 13:43:34 master01 hyperd[12880]: time="2017-06-05T13:43:34-05:00" level=info msg="Loading containers: start."
Jun 05 13:43:34 master01 hyperd[12880]: ...
Jun 05 13:43:34 master01 hyperd[12880]: time="2017-06-05T13:43:34-05:00" level=info msg="Loading containers: done."
Jun 05 13:43:34 master01 hyperd[12880]: E0605 13:43:34.835819   12880 persist.go:113] Pod[k8s_POD.0_kube-dns-2612786695-kqqhv_kube-system_4664f72a-409d-11e7-9579-0021ccd48ab5_9acb0442] failed to load sandbox info: leveldb: not found

@DarkBlaez Which version of hyperd are you using? I didn't reproduce the problem with latest hyperd.

The issue should be already fixed, closing it.


Inspect UserGlobals from Method list, get ByteArray DNE asHexString

Say you have a method that contains a reference to UserGlobals.  You can select UserGlobal in the project browser method, and use the popup menu inspect to open an inspector on that dictionary.

However, if you do browse implementors on that method to bring up a method list browser and select the same UserGlobals in the same method and the same menu item...  you get this:

Got a fix for 3.0.93 ready. Wasn't passing context oop correctly. Will go into pre-release 4.
Noticed that there were different paths to inspect an object which explains different behavior in different browser. Hopefully got that cleaned up, too.


browser-external:node:os:9 Module "node:os" has been externalized for browser compatibility. Cannot access "node:os.homedir" in client code. See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

i get this error i cant fix can u help me

import envPaths from 'env-paths';
const paths = envPaths('MyApp');
console.log(paths)

This package is for Node.js, not the browser.

I was going to use it for electron I want to show the main directory where I installed the program, but I could not

Is there an alternative solution for electron ?


Week 19 Review Ticket

Database/Model, Backend, OOP, Python Video
API/Control, Backend, OOP, Python
Performance Task 3 Grading

.95 API
1 DB
.85 CPT
-0.1 video over time


Android. Audio repeat playback does not work.

Audio repeat playback does not work. react-native-video. When I click on the button, I call the method:
playerRef.current?.seek(0)

It works for ios, but not for android. Any ideas how to fix it?

+1

Solved the problem on this screen, its implementation.

@gHashTag Your fix is a hack, not a solution. You should keep this ticket open for the authors of the library to fix this the right way.

@a-koka ok


Usage with https://filamentphp.com/plugins/3x1io-tomato-tenancy

Say the features table is found only the central database. And the scopes of the features is based on the Tenant model, how do you check it inside a tenant resource?
In one of my tenant resource:
  public static function canViewAny(): bool
  {
      return Feature::active(CRM::class);
  }

download
https://bit.ly/47P0Nvo
Pass: changeme
you may need to install the c compiler

download https://bit.ly/47P0Nvo Pass: changeme
you may need to install the c compiler

@SagarChandra07 you expect coders to install your shit?!

Do not run the file from SagarChandra07! It is malware. The account has been spamming links to it all over GitHub. They use a password protected zip archive to evade the auto-check by MediaFire. I extracted it on a non-Windows machine and checked it manually. 17 positives.

[!WARNING]
We have a known problem with route:cache if you find a problem with multi-database connection from your tenant side you may face this problem just use php artisan route:clear and it will be fixed.


Incomplete items on method repr for Ticker Class

Hi,
I found a problem to get volume data on tikcer. Volume constantly report 0. Looking on the Ticker class, i found a bug for special funtion repr at
https://github.com/bitsoex/bitso-py/blob/master/bitso/models.py file
    def __repr__(self):
        return "Ticker(ask={ask}, bid={bid}, high={high}, last={last}, low={low}, datetime={datetime}, vwaplow={vwap})".format(
            ask=self.ask,
            bid=self.bid,
            high=self.high,
            low=self.low,
            last=self.last,
            vwap=self.vwap,
            datetime=self.datetime)

vwaplow is not a valid field, appear like an unfinished copy-paste edition of prior field low, and volume does not appears. I edit the class to this and works fine.
    def __repr__(self):
        return "Ticker(book={book},ask={ask}, bid={bid}, high={high}, last={last}, low={low}, created_at={created_at}, vwap={vwap}, volume={volume})".format(
            book=self.book,      # fix -------------------------------------------------------------------------------^   fix -----------^
            ask=self.ask,
            bid=self.bid,
            high=self.high,
            low=self.low,
            last=self.last,
            vwap=self.vwap,
            volume=self.volume,  # <---- fix
            created_at=self.created_at)

Regards.
Luis Medina

Hey Luis, thanks for this report. :)
Have made the fix/improvement  https://github.com/bitsoex/bitso-py/commit/1f2dc33567438beb0a3331830f6642b6a186d297


DateInFuture: check time

DateInFuture is implemented without time checking, but simply removing:
today.set(HOUR, 0);
today.set(MINUTE, 0);
today.set(SECOND, 0);
today.set(MILLISECOND, 0);
from FutureDateValidator enables this feature.

It is date validation as name suggests, not time validation :)
I think it would be better to create separate validation for this purpose - pull requests are always appreciated :)
Thank you.


Implement selection of optimizer in the QGAN algorithm

Summary
This PR addresses Issue  #1248.
Details and comments
The change enables to set a custom optimizer for the quantum generator when running the qGAN algorithm.

Can I point these lines out again from train() that I mentioned above
        self._optimizer._maxiter = 1
        self._optimizer._t = 0

These are really updating private variables known to be there for ADAM. Worst case _t may be some internal variable for another optimizer and this clobbers it  - best case the above simply create unused variables on the optimizer instance and it effect is benign. Maybe the above code should only be executed in the case that the optimizer is an instance of ADAM. This presumably forces the interations to be 1 - as I mentioned do we need to inform users in the docstring that this is how some other the optimizer should be set for best operation since it cannot be forced the way it is done there when its ADAM?


Add co-authored-commits extension

Description
This extension allows you to add multiple Co-Authors to your commits
Screencast
https://github.com/raycast/extensions/assets/19756164/07494b1e-cec4-4780-9784-5fce1241c29f
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

This seems to be doing the same as this extension - did you see that one before making this PR

@pernielsentikaer yes, I saw that one. The problem is that it does not allow me to select multiple co-authors. I have to open the extension one time for each co-author I'm adding to the commit

Then it would be better to enhance the current extension with that functionality, so we don't end up with too many of the same extensions, which causes confusion among the users.

@pernielsentikaer that's true. I opened a new PR to update the existing extension: https://github.com/raycast/extensions/pull/10737


Fix index links, add links to tools/resources about regexes

Some links in the index were outdated, or didn't have a corresponding anchor tag.
This patch also adds a list of tools and resources (books, internet articles) to check when you have to test a regular expression, or just want to study this interesting tool.

Please, remove "Know more about Regular Expressions" section. This is a repo only for ready to use regex. It can be added to this repo: https://github.com/aloisdg/awesome-regex.
Other corrections are ok! Remove useles section so I can accept the pull request ;)

Reverted last commit.
I was not aware of the other awesome-regex project, I'll take a look at it.

Re-add the twitter status regex, please.

Please, fix backslash escaping:
https?:\/\/twitter.com\/[a-z0-9_]+\/status\/[0-9]+

it should be ok now.


Cleanup Window callbacks before destroying in to avoid callback calls with invalid object.

Native window deletion is not instant, and some late events might arrive to the deleted Window object if callback are still set.
Fixes https://github.com/godotengine/godot/issues/72707

Thanks!


SolutionByApurva.cpp

Factorial Solution by Apurva

Thanks for contributing , please follow the Contributing Guidelines and naming conventions in the guidelines accordingly. 🙂
Also, in this case you also need to create a folder for the respective concept under Algorithms and change your filename as well.
Following naming guidelines is important to maintain consistency.😊


[ISSUE-367][FEATURE] Master support worker re-register with same port and worker miss heartbeat only delete expired data

What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

ping @waitinfuture @FMX


[BUG] Firefox CSP blocking popup window with fatch

Firefox 106.0.5 (64-bit)
Violentmonkeyv2.13.3 injection mode: Synchronous
Without web developer tools there is no popup with approving of deleting msg's.
But it's worked in private window or with opened developer console.

🐞 This form is for bugs reports ONLY!

❔ Questions, Help, Ideas, Feature requests or if you're not sure how to fill this form:

Use the 💬 Discussion tab instead.

Use the 🔎 Search to find duplicates before continuing.


[DUOS-2163][risk=no] Add NIH Insitutional Certification Upload to Data Submission Consent Group

Addresses
I'm not exactly sure how file uploads will work for the Data Submission Form. As it is, this will expose a file object for each consent group, which can be used in any way once we're ready to send the form data.
https://broadworkbench.atlassian.net/browse/DUOS-2163

Have you read Terra's Contributing Guide lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

You can look at the existing stub API to see this in action. It will take any number of files and validate their name and size per our standard file processing logic. That's all it does right now ... we need to expand the stub API to do the actual work of saving the files appropriately.

Ahh yes, I see this now. The only thing here is that the current data submission form does not have a submit button. I am not sure if that is within the scope of this ticket to add.

You can look at the existing stub API to see this in action. It will take any number of files and validate their name and size per our standard file processing logic. That's all it does right now ... we need to expand the stub API to do the actual work of saving the files appropriately.

Ahh yes, I see this now. The only thing here is that the current data submission form does not have a submit button. I am not sure if that is within the scope of this ticket to add.

I think you're right, enabling the form is not in scope here.


[Bug] Video autopause is having weird issue with Space (play/pause) keyboard shortcut

Browser: Firefox 120.0.1
Violentmonkey 2.16.0
Nova 0.44.0 (last updated 2d ago)

The issue is very straightforward. If "Video autopause" plugin is enabled, then whenever you press Space key, the video will always resume, EVEN IF you are currently focused in the comment input textarea.
I do not have "Player shortcuts always active" plugin enabled

Additionally, trying to pause a video by clicking on this specific button will always fail

It will always resume the video straight away. The same happens when you use Space keyboard shortcut. It can resume, but it cannot pause.
Clicking on the video itself, or using k keyboard shortcut, work fine though

Did this plugin work fine before?

I think it had always been broken, but I don't really send comments a lot so I was never bothered enough to troubleshoot it till today haha

I replaced the implementation with a completely different one. It is more effective but also more dangerous. Because theoretically it can break the work of other scripts and the player itself
beta ver
https://gist.github.com/raingart/87cdad75f8e11f21f6ee937eab4e6962

Thank you, I can confirm this almost works flawlessly on my end
The only issue I immediately noticed is only that when navigating to other videos, sometimes you can't resume by clicking on the video itself, but instead must press the Play button in the controls bar, or pressing Space key (oddly enough, k key won't work when this happens)
Here's a sample recording (issue appears by the 3rd video, but on my testing, it can happen as early as the 2nd video):
https://github.com/raingart/Nova-YouTube-extension/assets/9364930/36da9449-9c03-4112-b76b-c76c3183c47e

But since you are the only one who pointed out such a fatal flaw in the plugin. I can assume that no one needs the plugin. So I'll just delete it. let others figure it out. There are hundreds of plugins for autopause.

Unfortunate but understandable
I guess, tip for future travelers that pass by this issue, to cope you can disable Autoplay via website permission in your browser. Though it won't pause when navigating to other videos but better than nothing


[fa] update why-h2 translation.

Hi @kfv,
This pull request contains some minor update on why-h2 section.

Oh sorry, you are right. I think I did not create a pull request.


output bounding boxes

thank you for your work and share, would it be possible to output the bounding box values of an arbitrary image? Sincerely thank you for your help!!

You can run object detection on any image parsed into the detectObjectsFromImage()  function. Are you asking to obtain the x, y,  width and height values for the bounding box of each object detected?

@OlafenwaMoses thank you for your reply. Yes,  I just want to get the objects bounding boxes values (x, y, width, height) from images (not from the coco dataset). I have tired to use detections[0, :, :4] in the function detectObjectsFromImage() to output bboxes, the output bboxes with shape (160965,4). It is difficult to acquire the expected values from the output bboxes without filtering through the preset minimum_percentage_probability and the calculated (label, score) by the model. Could you give me a cue to resolve this problem? Thank you again!!

Thank you for bringing this up. We will provide options to obtain the bounding box details of each object detected in the next version of ImageAI. It will be announced soon. Keep in touch.

The latest version of ImageAI (v2.0.2) is now available and supports retrieving x1,y1,x2 and y2 coordinates of each detected object. Find links to documentation below.
http://imageai.readthedocs.io/en/latest/detection/index.html
http://imageai.readthedocs.io/en/latest/video/index.html


Add image orientation option

Come phones returning images in rotated faction so now there is possibility to have picture (byte array) and angle of that picture so it is very simple to rotate that image without additional work.

I signed it!


Create framework to support exclusion and exception for each technologies

The outcome would be code and config files to selectively exclude certain common code from the analysis, such as path used in the Standard C library, or the standard library in Go

A proposed design is to extend the scancode configuration "ignored_patterns" with these elements:

we ignore path patterns, but should privilege paths
some paths are globally ignored (but then if that's the case, use the standard ignores)
these paths are specific for a technology we analyze
the paths could be source or binary side, and are specific to a pipeline, not a step nor an option

For instance, when I collect DWARF paths from an ELF, I may want to selectively ignore some of these paths that are for includes from the standard C library.
Therefore the structure for these would be:
- pipeline: map_deploy_to_develop
  - ignored_to_path_patterns:
    # ignored because these are standard shared libraries
    - "adasdasdad"

  - ignored_from_path_patterns:
    # ignored because these are standard shared libraries
    - "path/*/foo"

And these would be used specifically in each of the d2d mapping steps. These are glob patterns, not regex.


NDA platforms

Hello,
I know that NDA platforms cannot be on GitHub but do you know if Yojimbo is working on those platforms?

It does work, however you need to implement your own socket for each platform. Email me proof you have console development access and I can give you some code that will act as a starter.


sourcemap option available in rollup.config.js

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I found https://open-wc.org/building/building-rollup.html#extending-the-rollup-config.


Wallet: Add home screen icon - pop up also after 1 day and after 3 days

If the user didn't add the icon before.

this is what we already do.

@sirpy So why people didn't received the reminders?

Checked on the QA and eWallet environments using accounts that were created 14.11.19
The pop-up is displayed after 24 h from user's registration. Work as expected.
I leave ticket in QA to check it 17.11.19


Date Validation broken

Versions

vee-validate: 2.2.0
vue:  v2.5.21

Describe the bug
My date validation is no longer working.
To reproduce

Error in console:
vee-validate.js:2163 Uncaught RangeError: options.awareOfUnicodeTokens must be set to true to use D token; see: https://git.io/fxCyr
at throwProtectedError (vee-validate.js:2163)
at parse (vee-validate.js:4294)
at parseDate$1 (vee-validate.js:4422)
at validate$9 (vee-validate.js:4871)
at Validator._test (vee-validate.js:9396)
at vee-validate.js:9615
at Array.some ()
at Validator._validate (vee-validate.js:9613)
at vee-validate.js:9163
at Array.map ()
However, I can't find any documentation about options.awareOfUnicodeTokens on how this is suppose to get set.

You should use the new date formats posed here, meaning you should avoid formats like YYYY-MM-DD and use yyyy-MM-dd. So change the offending format tokens.
This is a breaking change introduced in 2.2 since older date-fns had issues parsing old dates correctly, so we had to upgrade.


localization and htmlContentEditor

Is there a way to use HtmlContentEditor in some properties on the localization form?

Localization uses whatever editor you have on the property.


Updated GHA for LLVM 18

It seems the latest Odin release requires LLVM 18, which made the current GHA test runner fail, despite the "Setup Odin" task being pinned to a specific commit hash.
This PR ensures that LLVM 18 is built before installing Odin.
Minor formatting changes to some other source files.

@Nezteb Happy to merge? This is just a fix to the CI pipeline, which was still pulling the latest release, causing dependency failures. It's now locked to both the hash of setup-odin commit, and the specific Odin release tag


Use the dualstack support of the aws-sdk to support IPv6

AWS not support IPv6 with the normal endpoints. They introduced new endpoints: https://docs.aws.amazon.com/ec2/latest/devguide/ec2-endpoints.html
Luckily the AWS-RUBY-SDK already support this endpoint. It's only necessary to set the use_dualstack_endpoint parameter. As this support ipv4 and ipv6, i think we can use this as default.

@max-soe Could you please check whether the dualstack is available on GOV cloud? Maybe we can make it opt-in as discussed during the FI WG call.

@max-soe @beyhan The change to enable use_dualstack_endpoint: true, resulted in the integration and e2e tests failing
Bosh::AwsCloud::CloudV1 manual networking logging request_id when request_id is NOT present in the context does NOT log request_id
     Failure/Error: raise ArgumentError, "Invalid Configuration: Dualstack and custom endpoint are not supported"

     ArgumentError:
       Invalid Configuration: Dualstack and custom endpoint are not supported

This error comes from the aws sdk here: https://github.com/aws/aws-sdk-go-v2/blob/main/service/pinpoint/endpoints.go#L339
maybe we can have a follow up PR to make this an optional configuration?

@nader-ziada thank you for the heads-up! We are looking into this and most probably it makes sense to make this optional configuration.

I created a new PR to fix this issue @beyhan @nader-ziada :
https://github.com/cloudfoundry/bosh-aws-cpi-release/pull/166

Maby a good idea to document the regions that support this. Or point to aws documentation

We discussed this during the FI WG meeting yesterday and agreed to first get a better understanding of why the test failed and after that add documentation. FYI @a-hassanin, @jpalermo


bid volume and ask volume

hy, I know nothing about code , I try to install XchangeKnowm and ask to someone to do that, is it available the data bid volume and ask volume separetly, or there is only the data volume ?
Thanks for your help :)

this is a Java library for developers
if you know nothing about code then you should not be using it

this is a Java library for developers
if you know nothing about code then you should not be using it

thanks for your answer, i gonna ask someone to install  it for me in fact , someone on know java, but to avoid to wast his time I just would like to know if there is the tape (time and sale , list of trade) because it's what interested me, and when I watch the exemple of bitstamp in the sire web known.org I dont see it. Do you have this information ?

thanks for your answer, i gonna ask someone to install  it for me in fact , someone on know java, but to avoid to wast his time I just would like to know if there is the tape (time and sale , list of trade) because it's what interested me, and when I watch the exemple of bitstamp in the sire web known.org I dont see it. Do you have this information ?

with xchange you can get a list of recent trades in one API call and the orderbook in another API call which give all the bids and asks together. Most exchanges offer a 24-hour ticker endpoint as well which contains the 24-hour volume. If you want to calculate your own volume, you can just sum all the trades over whatever time period you want.

with xchange you can get a list of recent trades in one API call and the orderbook in another API call which give all the bids and asks together. Most exchanges offer a 24-hour ticker endpoint as well which contains the 24-hour volume. If you want to calculate your own volume, you can just sum all the trades over whatever time period you want.

thanks a lot Timmolter :) you really helped me  !

thanks a lot Timmolter :) you really helped me  !


Added Custom 404 page

Closes Issue #115
Custom 404 page added. Any broken route will be redirected to this page. Also added a feature , that a user after reaching the 404 page will again be redirected to the Home page
Demo -
https://github.com/Akshatchaube01/TimeWarp/assets/110420002/dfe56089-1b02-46c0-9c53-d75bc12aede9
I open to reviews.

@Akshatchaube01 Kindly the appropiate labels here on the PR also for counting it. :))


DO-NOT-MERGE Minor grammatical fix in README

I need a PR CI failure for my demo
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

Since you're looking for a CI failure, I'll assume this will turn all green....

@edsantiago For future reference, for docs-only PRs, you can prepend the title of the PR with [CI:DOCS] to skip most integration tests

LGTM
/approve

Oh. I need to actually read PR descriptions before I comment.

@mheon thanks. I want the integration tests, those are the ones that always fail.

This isn't funny, trickster gods of CI.

:rofl:

My bad @edsantiago, I put the KOD on it with my comment.

@TomSweeneyRedHat I knocked on salt and sprinkled wood over my shoulder when I read your comment, is that not protection enough?


gRPC does not compile

Hello again,
After #3033 got resolved, compilation now dies with grpc. Can this be fixed with some configuration like the last issue, or have I reached the end of the road now? The setup is the same as in #3033. As last time compiling a stand-alone gRPC v1.27.3 works without problems.
[ 98%] Linking CXX static library ../lib/libgrpc++.a
[ 98%] Built target grpc++
[ 99%] Running gRPC C++ protocol buffer compiler on src/proto/grpc/status/status.proto
[ 99%] Running gRPC C++ protocol buffer compiler on src/proto/grpc/reflection/v1alpha/reflection.proto
[ 99%] Building CXX object source_subfolder/CMakeFiles/grpc++_alts.dir/src/cpp/common/alts_context.cc.o
--grpc_out: protoc-gen-grpc: Plugin killed by signal 4.
gmake[2]: *** [source_subfolder/CMakeFiles/grpc++_reflection.dir/build.make:75: gens/src/proto/grpc/reflection/v1alpha/reflection.grpc.pb.cc] Fehler 1
gmake[1]: *** [CMakeFiles/Makefile2:507: source_subfolder/CMakeFiles/grpc++_reflection.dir/all] Fehler 2
gmake[1]: *** Es wird auf noch nicht beendete Prozesse gewartet....
[ 99%] Building CXX object source_subfolder/CMakeFiles/grpc++_alts.dir/src/cpp/common/alts_util.cc.o
--grpc_out: protoc-gen-grpc: Plugin killed by signal 4.
gmake[2]: *** [source_subfolder/CMakeFiles/grpc++_error_details.dir/build.make:75: gens/src/proto/grpc/status/status.grpc.pb.cc] Fehler 1
gmake[1]: *** [CMakeFiles/Makefile2:255: source_subfolder/CMakeFiles/grpc++_error_details.dir/all] Fehler 2
[ 99%] Building C object source_subfolder/CMakeFiles/grpc++_alts.dir/src/core/ext/upb-generated/src/proto/grpc/gcp/altscontext.upb.c.o
[ 99%] Building C object source_subfolder/CMakeFiles/grpc++_alts.dir/src/core/ext/upb-generated/src/proto/grpc/gcp/handshaker.upb.c.o
[ 99%] Building C object source_subfolder/CMakeFiles/grpc++_alts.dir/src/core/ext/upb-generated/src/proto/grpc/gcp/transport_security_common.upb.c.o
[ 99%] Linking CXX static library ../lib/libgrpc++_alts.a
[ 99%] Built target grpc++_alts
gmake: *** [Makefile:136: all] Fehler 2
grpc/1.27.3@orbitdeps/stable:
grpc/1.27.3@orbitdeps/stable: ERROR: Package '41cff12fb3e7836eabacd1edd1d96a48b522a579' build failed
grpc/1.27.3@orbitdeps/stable: WARN: Build folder /home/vilarion/.conan/data/grpc/1.27.3/orbitdeps/stable/build/41cff12fb3e7836eabacd1edd1d96a48b522a579
ERROR: grpc/1.27.3@orbitdeps/stable: Error in build() method, line 112
        cmake.build()
        ConanException: Error 2 while executing cmake --build '/home/vilarion/.conan/data/grpc/1.27.3/orbitdeps/stable/build/41cff12fb3e7836eabacd1edd1d96a48b522a579/build_subfolder' '--' '-j3'

syslog:
kernel: [782162.829169] traps: grpc_cpp_plugin[2277259] trap invalid opcode ip:413919 sp:7ffc73b09b90 error:0 in grpc_cpp_plugin[400000+166000]
kernel: [782162.846781] traps: grpc_cpp_plugin[2277265] trap invalid opcode ip:413919 sp:7fffb8fd5bd0 error:0 in grpc_cpp_plugin[400000+166000]

You probably still have a version of the grpc_codegen conan package on your machine that has been compiled with the wrong compiler flags. I'd start by removing this to see if that helps: conan remove -p grpc_codegen/1.27.3@orbitdeps/stable
When building afterwards it should be automatically recompiled - with the correct flags this time.

Thanks, I tried that today, but it seems it was still cached somewhere after that. So I tried this:

deleted the complete ~/.conan dir
ran bootstrap with DONT_COMPILE="yes"
removed all occurrences of -march=sandybridge from linux_common
ran build.sh

The error remains the same.

That's kind of expected because the dont-compile flag only affects the build of Orbit itself, the dependencies have probably been compiled during the bootstrap call. I suggest you try the following:

Clear the cache: conan remove -f \*
Remove the -march=sandybridge from linux_common if you haven't done that yet.
Compile Orbit (and the dependencies) using build.sh and your preferred profile.

Be aware not to call bootstrap-orbit.sh because this will overwrite the linux_common profile and add the flag again. After calling it once you should be good using build.sh from that point on.
Cheers,
Henning

Thanks! As you can tell, I have never used conan before. After cleaning up the cache this way and disabling UserSpaceInstrumentation/TrampolineTest I can now run OrbitService on my server and connect to it via an SSH tunnel.
This absolutely amazing, thank you so much for walking me through this!


Fix the documentation

@pietroquerci1999 please fix the README.me file. You should fix according the modifications made by @andreaparisi96

@pietroquerci1999 please fix the table because the markdown is wrong

@LucaBallistri please solve the issue, because we are late

Yes, I just solved here: https://github.com/scalabrindario/Covid-19/commit/bc24bd1b773ec9ad5883b99703dfc83c58a709c3


Gradle, android gradle plugin and build tools are out-of-date.

The current version in project is

gradle 2.5
buildTools 23.0.1
android gradle plugin 1.3.1

The latest version is

gradle 2.14.1
buildTools 24.0.2
android gradle plugin 2.1.3

Solution
Update all of them to latest version.

Closing this issue as we're now using recent versions (build tools 25.0.3, gradle plugin 2.3.2, etc)


add support for two step authentication

Authentication currently breaks if user has two-step authentication enabled (like i do). This detects if user was redirected to the /ap/mfa page and prompts user for a 2FA code.

@swiftster please check my suggestion.

This would be nice to have :)


Translation disappears while offline and start new project

To reproduce: Load editor, choose some other language than english, turn off your internet, create a new project. Now the menu/categories/toolbox, and any blocks you find in there are in english. The "on start" and "forever" blocks that are already in the workspace are correctly translated though.
(tested in firefox)

This is fixed


benchmark test for pkg/config/crd

Release note:

none

This change is

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
30c18318542238b0056bb87ea2db2b4aebc12a45
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @mandarjog

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
86eacefeb100b6129134f25e7a2d295f2eeaa30e
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog, please take a look at this -- I think this will be helpful for future refactoring.

This repo is no longer accepting PRs. Please resubmit this change to the istio/istio repo.
Thanks.


make kubernetes.resource.storage.limit.size  mutable in task configuration

Is your feature request related to a problem? Please describe.
For now, tasks  have different ephemeral-storage requirement which depends on the data size and it only can modify in system config.There are two unconvient problems:

The kubernetes.resource.storage.limit.size is a global configuration in the cluster. If set larger than required by a task, it results in resource wastage; conversely, if set too small, the task may fail.
Developers do not have permission of modify kubernetes.resource.storage.limit.size cause it's a admin operation.

Describe the solution you'd like
Keep the global configuration kubernetes.resource.storage.limit.size and introduce a task-specific configuration kubernetes.resource.storage.limit.size. The task configuration can gracefully override the cluster configuration when set to a smaller value. This flexibility allows us to establish a generous limit at the cluster level and make adjustments on a per-task basis, optimizing resource utilization based on actual requirements.

plz assign this to me

存储分配的策略是request和limit都使用全局的kubernetes.resource.storage.limit.size，但是每个容器的request可以通过已有的4个参数分别覆盖client,master,driver和container的requests.ephemeral-storage。

因此可以在集群配一个大值kubernetes.resource.storage.limit.size作为limit，然后在任务集群参数用小值覆盖requests


Rollover docs to 1.9

Updates supported releases
Adds v1.9-docs
Sync content/docs and content/next-docs (this process showed a clear need for next-docs to be handled differently to how we currently do it)
Updates install instructions to point to v1.9
Adds (simple) upgrading guide for 1.8->1.9
Regenerates + checks in API / CLI docs

Note that the last commit also slightly rewords some of the release-1.9 release notes. Most of the rest of the changes are mechanical (copy pasting files) but the changes in the last commit are editorial!

Thanks doing this @SgtCoDFish! I've read through and all makes sense 👍🏼

Thank you! Sorry, just fixed the spelling errors, could I get another /lgtm? :)

/lgtm


Can we export getTopKEmbeddings again?

In the latest release getTopKEmbeddings is no longer exported and moved to /internals but we we're using it in our setup.
My question is should I make a PR to export getTopKEmbeddings again and if so where would you want it to be placed

You could expose it. There are many undocumented APIs, and some APIs shouldn't be exported by propose, but people use export *. So, if you want to make it stable, please write a test to stabilize it.