extern(C++) interfaces should format

schveiguy (@schveiguy) reported this on 2014-04-23T18:38:02Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=12627
CC List

yebblies

Description
This is very similar to issue #11175, and can be solved in the same way.

The gist of it is that when an interface does not support toString, it is cast to Object to call toString. If casting to object does not work, it simply prints null.

Well, we can print at least the address of the object if toString is not supported.

One issue is that it's a little difficult to unit-test this. You need a C++ object, and there is no way to create it in D. From my attempts, I can't even *cast* a void * pointer to a C++ interface. The compiler doesn't seem to allow any type of casting to C++ interfaces (bug?).

Here is the only way I was able to get it to test:

module cppcast;

// need to circumvent mangling
extern(C) void *cppcast(void *ptr)
{
   return ptr;
}

module testcppcast;

version(unittest)
{
   extern(C++) interface X
   {
   }

   extern(C) X cppcast(void *ptr);
}

unittest
{
   auto dummy = cast(void*)1234;
   auto x = cppcast(dummy); // dummy c++ class, doesn't need to be valid
   string expected = format("%X", dummy);
   formatTest(x, expected); // fails, x is printed as 'null'
}

Special-casing C++ interfaces to cast to void * if they don't have a toString method should work, just like the IUnknown solution.

schveiguy (@schveiguy) commented on 2014-04-24T18:03:47Z
Thanks.

An updated unit test:

version(unittest)
{
   extern(C++) interface X
   {
   }

   extern(C++) class C : X
   {
   }
}

unittest
{
   X x = new C;
   string expected = format("%X", cast(void *)x);
   formatTest(x, expected); // fails, x is printed as 'null'
}

@yebblies While fiddling around, I found an issue with extern(C++) classes (not related to this). See issue #12636

yebblies commented on 2014-04-24T16:59:38Z

The requested example of how to create classes usable through extern(C++) interfaces - pretty much how you'd expect.

import std.stdio;

extern(C++)
interface I
{
    void fun();
}

extern(C++)
class C : I
{
    void fun() { writeln("This works..."); }
}

class D : I
{
extern(C++):
    void fun() { writeln("And so does this!"); }
}

void main()
{
    I i = new C();
    i.fun();
    i = new D();
    i.fun();
}


"Internal Server Error" returned when running example URLs

Thank you for this great api.
For the last few days I'm receiving "Internal Server Error" when running the herokuapp.com example URLs you provided (links below)
Not sure if the timing coincided with recent Redis shut down (but its my understanding dependencies have already been removed)
https://torrents-api-py3.herokuapp.com/api/v1/all/search?query=avengers&limit=5
https://torrents-api-py3.herokuapp.com/api/v1/search?site=1337x&query=eternals

that is why because apis are not hosted links will be updated soon.


[FLINK-17617] Fix SQL Client autocomplete

What is the purpose of the change
Fixes SQL autocomplete hints so that the completion hint makes sense relative to the cursor position.
Brief change log
Changed the SqlCompleter logic to take the cursor pos into account and not return the full command hint
Verifying this change
This change added tests and can be verified as follows:
Extended CliClientTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): No
The public API, i.e., is any changed class annotated with @Public(Evolving): No
The serializers: No
The runtime per-record code paths (performance sensitive): No
Anything that affects deployment or recovery: No
The S3 file system connector: No

Documentation

Does this pull request introduce a new feature? No
If yes, how is the feature documented? not applicable

This looks good to merge! You think you can still use your committer powers? 😉

I think my powers still work :) Thanks for checking it, will merge it!

☕


Add diagnostic: Module must exist

Example:
TestModule = require(script.Parent.TestModule)
squiggles: script.Parent.TestModule does not exist

Great extension by the way! Do not mean to overwhelm, feel free to discard or prioritize however you like 😊


Fonts not loading in version 2020.7.0

From a direct email from user:
I am having a really hard time with the Character Map UWP, when opening it continues to say “loading fonts” and will not open. I’ve exited, and opened again. I’ve restarted the program. I’ve uninstalled, restarted my computer and then installed it back. Nothing.
It continues to show me this:

I really do love using Character Map, I use it for work. So i’m really anxious to have this working again. Please help!

This issue seems to be introduced in #86
CC @JohnnyWestlake

Will take a look in a few hours... Might have something to do with the TitleBar so I'll manually throw a few exceptions in there and see what happens

A little stuck on this one, I can't ever get it into this state. Any C++ error tends to terminate the app entirely with no warning, so it's not that. And C# errror during startup shows the exception dialog from my tests

It's not a single case, there are a few users suggesting the same thing in feedback.

I can't reproduce the issue on 3 of my machines with Windows 10 v1909 - 2004, existing upgrade and new installs are all good. It's wired. @JohnnyWestlake

@JohnnyWestlake
From the screenshot, I guess the font is actually loaded because the font name is showing in the title bar as "A little sunshine", but the loading animation didn't dismiss.
An ugly and violent workaround is to force dismiss the animation after TitlePrefix is updated in XamlTitleBar, but since I can't reproduce the issue, I don't have much confidence to write such a workaround, we haven't found the root cause yet.

My 1809 machine seems to have updated itself to 1903 so I can't double check that.
It's strange as the LoadingRoot is visible with x:Load, so if the ViewModel.IsLoadingFonts is set to false it is literally removed from the VisualTree.
But if it does not get set to false, the error dialog should show up 😐

Boom, hello. So I've got an ancient tablet that I found in a closet that's running 1809 and exhibits this problem - I'll stick debugger on it and let you know

Version 2020.8.2 has submitted to Microsoft yesterday, but the Store certification is taking longer than usual. This issue may last a couple more days before updates are rolling out.

Version 2020.8.2 passed verification and rolling out now.


⚠ Spryr has degraded performance

In 05d4805, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5183 ms

Resolved: Spryr performance has improved in bc77ccf after 34 minutes.


add limit options

增加一个limit参数，可以设定一个图片大小的阀值。图片大小 > limit的生成webp格式的图片

Codecov Report

Merging #4 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   98.36%   98.38%   +0.02%
==========================================
  Files           2        2
  Lines          61       62       +1
==========================================
+ Hits           60       61       +1
  Misses          1        1

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032f68f...3458a8a. Read the comment docs.

Please update the doc, add limit options. Thanks


Add DCDD shock capture to free surface

This adds DCDD shock capturing to the free surface solver. It's a bit diffusive, but it really helps dam breaks test cases and the likes.

@jeannejoachim All comments have been applied.
If you don't have more, i'll merge after the CI passes.


Allow specifing the length of arrays in ArrayMesh.add_surface_from_arrays

Godot version:
Godot 3.0.2
OS/device including version:
All (I'm on X11/linux)
Issue description:
For mesh generation I currently store one PoolVector3Array for vertices and then update the mesh using ArrayMesh.add_surface_from_arrays.
This is reasonably efficient but whenever the amount of vertices changes I need to resize the PoolVector, which causes extra allocations.
It would be beneficial to be able to specify the length of the arrays in add_surface_from_arrays, this would allow me to use one large buffer for all vertices.
Is this something worth adding, I could probably create a pull request?

@Zylann Seems to be different for PoolVectors, they don't seem to have the realloc next-power-of-2 padding that Vectors have.

Note that Godot 4.0 replaces PoolArrays with PackedArrays. Please check if the new data structure suits your performance needs before opening a proposal.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


Improve / fix status indicators

The status indicators for downloading, loading data and the fact that you may need to zoom in are a little broken right now.

"Zoom in to show data" now works correctly, and the status icons for downloading do too.
Only thing left to do is the icon that indicates the app is processing data.

Processing data icon added as well.
Closing this as I'm pretty happy with the state of the status indicators right now.


ENH: CSP multiclass uwedge implementation + examples

As discussed in https://github.com/mne-tools/mne-python/pull/3485, the current multi class CSP is quite slow for high dimensions; uwedge should be faster, although probably less good.
Additionally the CSP examples need a lifting and an additional example is necessary for > 2 class problems.

I'm going to close this and hope that it lands (or has landed) in pyriemann


quid MessagesBundle_TLC.properties and Impressum_TLC.png files ?

I think that it would be more rational to place the MessagesBundle_TLC.properties and Impressum_TLC.png files with the Galleries material.

The Impressum.png must certainly stay with Surfer-java.

The Impressum_{en,de,nl}.png are distributed within the surfer-alggeo-java deb ball (read: not within the surfer-alggeo-galleries deb balls.

Concerning the MessagesBundle_TLC.properties data files: I am wondering if the few info they contains could be encapsulated in the PDF file. The rational is that we can then only deal with the PDF files (which BTW can be viewed with any regular pdfviewer)

I am definitively think that the MessagesBundle_TLC.properties keywords list must be encoded in the PDF files, in practice in the SurferDesc.cls LaTeX CLaSs file.

The MessageBundle_TLC.properties files contain the localization strings for various labels in the SURFER program. It is entirely independent of the galleries. These labels have no relation to the PDF files of the galleries.
A different story is that both, the MessageBundle_TLC.properties and the galleries, are needed for full localization of SURFER to another language. But the .properties file still doesn't contain any information relevant for the galleries or vice versa.
I don't see a point of putting the property files into the gallery repository nor does it make any sense to make them available in the LaTeX class file.

I will close this and think of where to put the MessageBundle_TLC.properties files in the SURFER project (see IMAGINARY/SURFER#14). It's clearly not a good idea to just keep them inside the jar blobs.

My issue was mainly: what does happens if a gallery material in a foreign language not yet supported in the viewer is added ?

Nothing happens. The viewer looks for all the languages that have a MessageBundle_TLC.properties file. Only if the program itself is supporting the language (via the message bundle), the PDF will be loaded. Otherwise it will be ignored.

Have you already wiped out the gallery material from the SURFER source ?

No. I was working on jsurf first, then the galleries and tomorrow I plan to work on Surfer itself.

I think this is a part of the wipe out, so let come back to this mater later to see clearer.


remove from document instead of parent

sometimes the msg is not a direct child.

Pull Request Test Coverage Report for Build 34

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 33:
0.0%

Covered Lines:
198

Relevant Lines:
198

💛  - Coveralls


remove user_panels from download_data call

user panel information is not needed for downloading data. (https://github.com/EBI-G2P/ensembl-gene2phenotype/pull/34)

merged into master and release/104


Consider using TypeScript instead of Flow

Related: #1938
@kevinbarabash It seems you own https://github.com/Khan/flow-to-ts, how difficult is it to migrate to TS?

I think it's worth understanding what  benefits TS would be providing us vs what benefits Flow already provides us.  I don't think it would be particularly difficult to migrate.  I do have concerns about the lack of exact object types in TS.  Another concern is around type-safety.  Flow treats all variable assignments and passing of variable params invariantly (readonly when variables/params are covariant) whereas TS treats them as covariant all of the time which is inherently unsafe.

I imagine the main issue is that TypeScript is becoming pretty popular. At least, providing TypeScript bindings would be nice, so that a caller can try to be typesafe, though I think there isn't yet a nice way to do that directly in our own repo/NPM package (?).

We could add a katex.d.ts file at least manually to start with.  It would nice to build the .d.ts file automatically in the future though.

I've started using TS for a project and it's working well.  I actually used flow-to-ts to do the conversion.  The two main issue around type safety are:

TS allows passing parameters that are covariant
TS doesn't check if the implementation of a type guard actually results in the type refinement that it promises to do.

The first issue can mainly be addressed by making parameters to functions readonly which is a good practice anyways.  The second issue is actually a double edge sword.  Even though TS doesn't check that the refinement makes sense, it means that we can write type guards that aren't possible in Flow since Flow restricts itself to a single expression.
I think that assertion functions that were added in the 3.7 release could be quite useful in our codebase.

In terms of the actually difficulty of the this change, I don't think it'll be that hard.  The main thing that we'll have to do manually is update our type guards and make the appropriate changes to our build config.
I do think that once we make the change, we should consider making as many things readonly as we can.  Unfortunately, things in TS are not readonly by default which means having a bazillion readonlys everywhere unfortunately. 😞

I do think that once we make the change, we should consider making as many things readonly as we can. Unfortunately, things in TS are not readonly by default which means having a bazillion readonlys everywhere unfortunately. 😞

You could reduce the bazillion readonlys to just a few million by using the Readonly<T> utility wrapper. Basically instead of applying readonly to each field, you surround the type definition and all fields will be made readonly. More info on linked docs.


Add Spacer component

Finish

Can we have a spacer inside a navigation? Do you have an example?

For Example http://www.getmdl.io/templates/dashboard/index.html: drawer has a main menu, and in the bottom of the help button

Thanks @Graf009. I manually merged it because I changed a few details from your implementation ;-)


Fix windows follow symlinks on delete

Context
This PR fixes "Delete task always follows symlinks on Windows" #6478, therefore avoiding bad surprises when you (have to) work with symlinks on Windows.

https://github.com/gradle/gradle/issues/6478
https://github.com/gradle/gradle/issues/4065
https://github.com/gradle/gradle/issues/8119

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@DreierF This is a great first step, let's push this over the finish line. There's some unrelated changes that we can split out and there's some missing test coverage. I have split a PR for https://github.com/gradle/gradle/issues/8119 in https://github.com/gradle/gradle/pull/8519, so you can revert the deleteIfExists change.
For the other two issues, we need to provide test coverage for them: Project#delete(Object...), Project#delete(Action) and Delete task. It seems most test for the first two delete methods are covered by DeleterTest. For the Delete task, the coverage is handled by DeleteTaskIntegrationTest.
The test coverage should also be extended to cover hard link, junction point as well as symbolic link on Windows so we have the right expectation. The hard link should behave like a normal file thus not detecting symbolic link. As for the junction point and symbolic link, they should both behave like a symbolic link according to follow and not follow link feature.
Can you help with those tests?

@lacasseio How would you test hard links? I did test them manually, but as you need administrator privileges to create them I see no way how these could be created as part of a test without running the tests as admin of course.
Also I'm not sure if and when I find the time to add more tests. I'm quite busy at the moment.

Don't worry about it @DreierF, I went ahead and wrote the test coverage for this PR inside https://github.com/gradle/gradle/pull/8556. I'm closing this in favour of the other PR.


docker copy instead of volume mount to resolve dubious ownership issue

Resolved dubious ownership issue due to which test cases are failing.
✨ Special Thanks to @rohitagg2020 and @renuy for helping in resolving this.

LGTM


GeneList to show genes only

Add button to GeneList tool to show only genes.

added filter toggle button to show only genes/transcript.


Query outputs projection - no values returned

The projection : Query_Outputs_Projection does not seem to be returning the [Targets] collection that it should be getting from the Query.OutputLocationSet event being handled.
(On running it over a query event stream that does have that event in, the collection is returned empty)

Interesting - the output location set event was not persisted to the stream (maybe not called?)
  {
    "$type": "CQRSAzure.EventSourcing.Azure.Blob.BlobBlockJsonWrappedEvent, CQRSAzure.EventSourcing.Implementation",
    "EventName": "QueryCreated",
    "Sequence": 0,
    "Version": 1,
    "Timestamp": "2019-03-04T22:23:43.0343673Z",
    "CorrelationIdentifier": "",
    "EventInstanceAsJson": {
      "$type": "TheLongRun.Common.Events.Query.QueryCreated, TheLongRun.Common",
      "QueryName": "Get League Summary",
      "Date_Logged": "2019-03-04T22:23:42.8411281Z",
      "QueryIdentifier": "53d009aa-091e-001c-62ab-afb72e001846",
      "AuthorisationToken": ""
    },
    "EventInstanceClassName": "TheLongRun.Common.Events.Query.QueryCreated"
  },
  {
    "$type": "CQRSAzure.EventSourcing.Azure.Blob.BlobBlockJsonWrappedEvent, CQRSAzure.EventSourcing.Implementation",
    "EventName": "QueryParameterValueSet",
    "Sequence": 1,
    "Version": 1,
    "Timestamp": "2019-03-04T22:23:44.5123114Z",
    "CorrelationIdentifier": "",
    "EventInstanceAsJson": {
      "$type": "TheLongRun.Common.Events.Query.QueryParameterValueSet, TheLongRun.Common",
      "Name": "League_Name",
      "Value": "New Booterstown Retirees Divisional"
    },
    "EventInstanceClassName": "TheLongRun.Common.Events.Query.QueryParameterValueSet"
  },
  {
    "$type": "CQRSAzure.EventSourcing.Azure.Blob.BlobBlockJsonWrappedEvent, CQRSAzure.EventSourcing.Implementation",
    "EventName": "ProjectionRequested",
    "Sequence": 2,
    "Version": 1,
    "Timestamp": "2019-03-04T22:23:48.5315634Z",
    "CorrelationIdentifier": "",
    "EventInstanceAsJson": {
      "$type": "TheLongRun.Common.Events.Query.ProjectionRequested, TheLongRun.Common",
      "DomainName": "Leagues",
      "AggregateType": "League",
      "AggregateInstanceKey": "New Booterstown Retirees Divisional",
      "ProjectionTypeName": "League_Summary_Information",
      "AsOfDate": null
    },
    "EventInstanceClassName": "TheLongRun.Common.Events.Query.ProjectionRequested"
  },
  {
    "$type": "CQRSAzure.EventSourcing.Azure.Blob.BlobBlockJsonWrappedEvent, CQRSAzure.EventSourcing.Implementation",
    "EventName": "ProjectionRunStarted",
    "Sequence": 3,
    "Version": 1,
    "Timestamp": "2019-03-04T22:23:55.6153335Z",
    "CorrelationIdentifier": "",
    "EventInstanceAsJson": {
      "$type": "TheLongRun.Common.Events.Query.ProjectionRunStarted, TheLongRun.Common",
      "DomainName": "Leagues",
      "AggregateType": "League",
      "AggregateInstanceKey": "New Booterstown Retirees Divisional",
      "ProjectionTypeName": "League_Summary_Information",
      "AsOfDate": "2019-03-04T22:23:55.2049776Z",
      "ProjectionRunnerIdentifier": "53d009aa-091e-001c-62ab-afb72e001846"
    },
    "EventInstanceClassName": "TheLongRun.Common.Events.Query.ProjectionRunStarted"
  },
  {
    "$type": "CQRSAzure.EventSourcing.Azure.Blob.BlobBlockJsonWrappedEvent, CQRSAzure.EventSourcing.Implementation",
    "EventName": "ProjectionValueReturned",
    "Sequence": 4,
    "Version": 1,
    "Timestamp": "2019-03-04T22:24:30.7797924Z",
    "CorrelationIdentifier": "",
    "EventInstanceAsJson": {
      "$type": "TheLongRun.Common.Events.Query.ProjectionValueReturned, TheLongRun.Common",
      "DomainName": "Leagues",
      "AggregateType": "League",
      "AggregateInstanceKey": "New Booterstown Retirees Divisional",
      "ProjectionTypeName": "League_Summary_Information",
      "AsOfDate": "0001-01-01T00:00:00",
      "ReturnedValue": {
        "Row_Number": 0,
        "Date_Incorporated": "2018-07-01T16:41:00.9584103Z",
        "Location": "",
        "Twitter_Handle": "@merrion"
      },
      "AsOfSequenceNumber": 0
    },
    "EventInstanceClassName": "TheLongRun.Common.Events.Query.ProjectionValueReturned"
  }```

Closing this and opening an issue for the real problem - no "OutputLocationSet" event was written.


[RFE]: Do not upload tarball if MD5 hasn't changed

If we're rerunning a pipeline in the event of a failure we are skipping configuring many services
We should also avoid uploading the tarball if the file is the same as the remote one maybe storing an MD5 file on the registry to compare the one used before

N/A


Add method to delete attachment to ArtifactStore

As discussed on mailing list a method should be added to delete attachment to allow deletions in ArtifactStore implementation which store binary data in a separate store. To enable that

Add a method to ArtifactStore

  protected[core] def deleteAttachment[T](doc: DocInfo, name: String)(
    implicit transid: TransactionId): Future[Boolean]

Have this method exposed in DocumentFactory
Have the method in (2) invoked by WhiskAction
In CouchDBStore add a no op implementation which returns a successful future as delete is handled implicitly in del call for the entity

Currently when any entity is deleted we do not have entity instance. So this would make it tricky to implement deleteAttachment(docInfo, name). Instead we can have a method like
protected[core] def deleteAttachments[T](doc: DocInfo)(
    implicit transid: TransactionId): Future[Boolean]

Here the ArtifactStore implementation can remove all attachments related to the given docId. This requires that

custom AttachmentStore (probably a new SPI for later) stores attachment with blob id set to "${doc.id.id}/$name"
Delete operation can be implemented by removing all blobs with id starting with document id

This may involve multiple calls depending on AttachmentStore  implementation.
S3
S3 does not provide a direct call to delete by prefix. Instead we need to

first list blobid matching given prefix
Delete then via multiple delete support

Azure Blob Storage
It does not support performing multiple deletes in single call. Instead we would need to

List Blobs matching given prefix
Delete then one by one

Closed via #3366


[CAPI] Add ml_train_model_compile_with_params() internally for C# DllImport

[CAPI] Add internal API for C# DllImport

ml_train_model_compile() and  ml_train_model_run() has a va_list and this is a problem with DllImport in C#, va_list must be passed dynamically for each architect, this is not guaranteed to work for some architects. so C# will pass the model compile params as a single string

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1911. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

I will uploaded unittest to another commit.

Need to fix the CI.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1911-202205201019430.36557197570801-9e4988970add1b8b6480efea198f54242550d298/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1911-202205241200190.3069269657135-f0a8d443e0d6bc739c6f9cae393724857580c8b0/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1911-202205241400370.84899711608887-a28405666c59ba7ef383b4f6bb5587c3ba8d3d4d/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1911-202205241449050.42337203025818-49a272e5d8674023f1cedf87e53ef1c56fdfe94a/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1911-202205241614120.80211496353149-98f01c5c080ca50905488701dc8b8d56b86602f9/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1911-202205241746570.93659496307373-05defed60f7a52109d4772aede2c0715b79e382a/.

I fixed code related to all comment.

thank you!!


USPTO images missing for the "small" train script

Hello, I've recently been attempting to retrain MolScribe using the scripts you provide in scripts. First of all, thanks for providing all your data and training scripts, extremely helpful.
Second, when running train_uspto_joint_chartok.sh I get a series of missing image warnings like:
[<EMAIL_ADDRESS>global loadsave.cpp:248 findDecoder imread_('data/uspto_mol/2002/20020723/US06423704-20020723/US06423704-20020723-C00135.TIF'): can't open/read file: check file path/integrity

I downloaded the ZIP from the link provided in the README: https://www.dropbox.com/s/3podz99nuwagudy/uspto_mol.zip?dl=0, and unzipped it into data. This is not an issue when running train_uspto_joint_chartok_1m680k.sh. The problem is the uspto_mol/train_200k.csv has paths to images not provided in the ZIP archive.
It would be good to be able to run the smaller training set for quicker comparisons to your saved checkpoint. Let me know if this is fixable. Thanks for your time and this model!

Sorry for the late reply. In our paper, we only keep the model trained with 1M synthetic data and 680K patent data. Therefore only these data are released and we encourage to use them for future comparison.
If you still want that 200K data, please send me an email at<EMAIL_ADDRESS>I can give you a link for private download.

Thanks for the explanation, the 200k data isn't necessary for me. But, it may be good to make a note that it is not released in the 200k training script or README, however.


Add cossim_pow support to direction and direction_neuron

Increasingly, it looks useful to multiply cosine similarity into your objective when visualizing directions. This allows one to emphasize the angle of the activation vector more.
This PR adds initial support for this to direction and direction neuron. Care is taken to ensure it is numerically stable.

Pull Request Test Coverage Report for Build 193

4 of 17 (23.53%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 62.896%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lucid/optvis/objectives.py
4
17
23.53%

Totals

Change from base Build 191:
-0.3%

Covered Lines:
934

Relevant Lines:
1485

💛  - Coveralls

So currently direction doesn't seem to return a rank-0 tensor/scalar loss:

That is different from what the other objectives return—it's usually a scalar loss. Is that intentional? If so, should we mention it in documentation?

My understanding is that in the plain direction method, there should be one more reduction over the spatial dimensions when computing the dot product. Can you confirm or correct, @colah ?


New option for custom package names, tests and updated README

Hey!  I was using grunt-check-dependencies, and there's a nasty situation we've run into where we have two versions of the same package:
"dependencies": {
"package-old": "package#0.8.5",
"package": "1.2.1"
}
I saw there was a part of check-dependencies which almost handled this (the checkGitUrls option).  I left that intact, and added a checkCustomPackageNames option that works the same way.
I updated the tests and the README, too.  Let me know what you think!
Thanks,
Adam

Thanks for the PR! Is this a Bower feature? The following:
{
  "dependencies": {
    "bluebird": "2.8.1",
    "bluebird-old": "bluebird#2.8.0"
  }
}

causes an error with npm install:
npm ERR! 404 Not Found: bluebird-old
npm ERR! 404
npm ERR! 404 'bluebird-old' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

If this is just for bower then maybe the option should have no effect if packageManager is npm? In such a case tests for the feature should be restricted to bower as well, they should be put in test/bower-fixtures instead of test/npm-fixtures.

Ok thanks! :)  Sorry it took me a bit to fix these issues, but as you suggested, I made sure this feature applies to bower only and not NPM.

@apachols I've added a couple of comments.

Landed, thanks! :) I have published 0.9.0-beta.1. I haven't tagged a full release yet since I have tests failing on Windows:
https://ci.appveyor.com/project/mzgol/check-dependencies/build/125
https://github.com/npm/npm/issues/6554
I'd like to fix them before the final release but I'm not sure when I'll have time for this.


Escaped characters in xaml are not preserved

Escaped characters are unescaped when going through XDocument.Load and XElement.WriteTo(XmlWriter):
<FontIcon Glyph=""&"" />

becomes
<FontIcon Glyph="&" />

This should help preserving them:
input = input.Replace("&", "&");
//...
output = output.Replace("&", "&");

-- https://stackoverflow.com/a/10705108


Created a hidden group but I still see all members

I created a hidden group via
New-UnifiedGroup -DisplayName "group-name" HiddenGroupMembershipEnabled
but I still see all the members in the group. What am I missing?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03921866-8345-7e01-e873-3ec191191fbf
Version Independent ID: cb374ec2-99c3-7186-66ed-c037a678e946
Content: New-UnifiedGroup (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/New-UnifiedGroup.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

I'm tempted to resolve this as a duplicate of #9879.
Are you using certificate-based authentication (CBA) to connect? That likely won't work.


ldc: 1.10.0 -> 1.11.0, dmd: 2.081.1 -> 2.081.2, dtools: 2.081.1 -> 2.081.2

Motivation for this change
Update to latest stable releases.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: dmd, dtools, ldc
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)
Attempted: dmd, dtools, ldc
Partial log (click to expand)

Total Test time (real) =  43.28 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0
checking for references to /build in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0...
warning: path '/nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0' claims to be content-addressed but isn't
error: unexpected end-of-file

The Linux build error can be ignored because there is something wrong with the build machine GrahamcOfBorg is running on.
The problem it's running into is documented in https://github.com/NixOS/nix/issues/2155 and was last seen in https://github.com/NixOS/nixpkgs/pull/44904#issuecomment-413348452
So this is ready to be merged.

While reviewing this I noticed that Literate is broken that was submitted by @RocketPuppy:
Linking...
bin/tangle -odir source lit/*.lit
dub build --build=release
Package dmarkdown not found in registry at https://code.dlang.org/ (fallback ["registry at http://code.dlang.org/", "registry at https://code-mirror.dlang.io/", "registry at https://code-mirr
or2.dlang.io/", "registry at https://dub-registry.herokuapp.com/"]): Couldn't resolve host name on handle D72200
Performing "release" build using dmd for x86_64.
dmarkdown ~master: building configuration "library"...
lit/markdown/source/dmarkdown/markdown.d(820,10): Deprecation: module `std.ascii` is not accessible here, perhaps add `static import std.ascii;`
literate ~master: building configuration "application"...
source/globals.d(19,1): Error: Implicit string concatenation is deprecated, use "Lit: Literate Programming System\x0a" ~ "\x0a" instead
source/globals.d(20,1): Error: Implicit string concatenation is deprecated, use "\x0a" ~ "Usage: lit [options] <inputs>\x0a" instead
source/globals.d(21,1): Error: Implicit string concatenation is deprecated, use "Usage: lit [options] <inputs>\x0a" ~ "\x0a" instead
source/globals.d(22,1): Error: Implicit string concatenation is deprecated, use "\x0a" ~ "Options:\x0a" instead
source/globals.d(23,1): Error: Implicit string concatenation is deprecated, use "Options:\x0a" ~ "--help       -h         Show this help text\x0a" instead
source/globals.d(24,1): Error: Implicit string concatenation is deprecated, use "--help       -h         Show this help text\x0a" ~ "--tangle     -t         Only compile code files\x0a" inste
ad
source/globals.d(25,1): Error: Implicit string concatenation is deprecated, use "--tangle     -t         Only compile code files\x0a" ~ "--weave      -w         Only compile HTML files\x0a" i
nstead
source/globals.d(26,1): Error: Implicit string concatenation is deprecated, use "--weave      -w         Only compile HTML files\x0a" ~ "--no-output  -no        Do not generate any output fil
es\x0a" instead
source/globals.d(27,1): Error: Implicit string concatenation is deprecated, use "--no-output  -no        Do not generate any output files\x0a" ~ "--out-dir    -odir DIR  Put the generated fil
es in DIR\x0a" instead
source/globals.d(28,1): Error: Implicit string concatenation is deprecated, use "--out-dir    -odir DIR  Put the generated files in DIR\x0a" ~ "--compiler   -c         Report compiler errors
(needs @compiler to be defined)\x0a" instead
source/globals.d(29,1): Error: Implicit string concatenation is deprecated, use "--compiler   -c         Report compiler errors (needs @compiler to be defined)\x0a" ~ "--linenums   -l    STR
 Write line numbers prepended with STR to the output file\x0a" instead
source/globals.d(30,1): Error: Implicit string concatenation is deprecated, use "--linenums   -l    STR  Write line numbers prepended with STR to the output file\x0a" ~ "--md-compiler COMPILE
R  Use COMPILER as the markdown compiler instead of the built-in one\x0a" instead
source/globals.d(31,1): Error: Implicit string concatenation is deprecated, use "--md-compiler COMPILER  Use COMPILER as the markdown compiler instead of the built-in one\x0a" ~ "--version
 -v         Show the version number and compiler information" instead
source/weaver.d(299,18): Error: Implicit string concatenation is deprecated, use "<!DOCTYPE html>\x0a" ~ "<html>\x0a" instead
source/weaver.d(300,18): Error: Implicit string concatenation is deprecated, use "<html>\x0a" ~ "<head>\x0a" instead
source/weaver.d(301,18): Error: Implicit string concatenation is deprecated, use "<head>\x0a" ~ "<meta charset=\"utf-8\">\x0a" instead
source/weaver.d(302,18): Error: Implicit string concatenation is deprecated, use "<meta charset=\"utf-8\">\x0a" ~ "<title>" instead
source/weaver.d(307,18): Error: Implicit string concatenation is deprecated, use "</style>\x0a" ~ "</head>\x0a" instead
source/weaver.d(311,15): Error: Implicit string concatenation is deprecated, use "<body onload=\"prettyPrint()\">\x0a" ~ "<section>\x0a" instead
dmd failed with exit code 1.
make: *** [Makefile:3: release] Error 2
builder for '/nix/store/x2i0rsa60hy3199c91jy7j0yd6hy6ckv-Literate-2017-05-28.drv' failed with exit code 2

While reviewing this I noticed that Literate is broken that was submitted by @RocketPuppy:

There are only 4 new commits to the repo at https://github.com/zyedidia/Literate/commits/master.
Current Nix package is at https://github.com/zyedidia/Literate/commit/23928d64bb19b5101dbcc794da6119beaf59f679.
The 4 new commits don't seem to be fixing any of the deprecation errors.
@zyedidia Could you please fix the compilation with newest compilers upstream?

We could mark it as broken in the meantime.

Yes that's the way to go.

done in https://github.com/NixOS/nixpkgs/commit/bbf5f232e0bf1a7dab8043ea670735fa7e6181a7

I believe these errors have been fixed with the latest commit to zyedidia/Literate.

Yes that fixes the build, thanks.
There are still some deprecation warnings though:
lit/tangle/src/parser.d(212,14): Deprecation: package std.regex is not accessible here, perhaps add static import std.regex;
lit/tangle/src/util.d(48,25): Deprecation: parser.matchAll is not visible from module util
lit/tangle/src/util.d(48,45): Deprecation: parser.regex is not visible from module util
lit/tangle/src/util.d(48,68): Deprecation: parser.matchAll is not visible from module util
lit/tangle/src/util.d(48,88): Deprecation: parser.regex is not visible from module util
lit/tangle/src/util.d(50,29): Deprecation: parser.matchAll is not visible from module util
lit/tangle/src/util.d(50,49): Deprecation: parser.regex is not visible from module util
lit/tangle/src/util.d(54,41): Deprecation: parser.canFind is not visible from module util
lit/tangle/src/util.d(54,89): Deprecation: parser.canFind is not visible from module util
lit/tangle/src/util.d(69,24): Deprecation: parser.canFind is not visible from module util
lit/tangle/src/util.d(77,31): Deprecation: parser.canFind is not visible from module util
I might update the package in another PR.


Log in from command line

Login workflow for Google is:

Client opens a new windows with a URL like this one:
http://localhost:3999/auth/google?client_id=1054515969695-3hpfg1gd0ld3sgj135kfgikolu86vv30.apps.googleusercontent.com&redirect_uri=http%3A%2F%2Flocalhost%3A3000%2F&response_type=code&token_access_type=offline&state=http%3A%2F%2Flocalhost%3A3000
New window redirects to Google and then user goes through login steps
After login steps are done, new window sends an auth token to google/redirect endpoint and gets back an access token that encodes their user and role
New window sends this access token to the main window, which stores in in localStorage. This token then automatically gets added to the headers for requests to the collaboration server

We need to research what solutions are out there for doing something like this without using a browser if possible. For reference, this is a pretty standard OAuth2 workflow, so the solution might not have to be Google-specific.
It would be nice to have something similar to the npm login command for NPM, which allows you to log in once on the command line and then stay logged in.

Here's some more information about his issue:

If you need client ids or secrets for testing, you can probably use the ones here: https://github.com/GMOD/Apollo3/blob/c5d7c0a37246d137f14ba195a0d16dd99e3cbea3/packages/apollo-collaboration-server/.development.env
This "secret" only works on localhost:3000, so it's only for testing. We'll worry about how to supply the actual client values later.

Client opens a new windows with a URL like this one:

After the login flow, the window opened by this link will redirect to JBrowse, but you can change that by changing the redirect_uri in the URL. The CLI might have to start a temporary server and redirect to that instead (see oclif example discussed below). (Try opening this in an incognito/guest window to make sure it doesn't log you in automatically).

https://github.com/lelylan/simple-oauth2 might work, but I'm not sure how it handles things like Google logins that typically need a browser window to open.

I found an interesting example here: https://github.com/wnqueiroz/oclif-keycloak-oauth2-flows-sample
If we can figure out how this works, I think we can apply what it does for our use case. I see that it opens a window from the CLI that redirects to a temporary server that the CLI starts up. (n.b. In the readme of that repo, I think when it says "pooling" it means "polling")

Done in #354


Add more operating system sites

Hi @Igglybuff I would like to contribute to this. Can this issue be assigned to me??


Unable to install absl at HEAD using homebrew

Describe the bug
When trying to install absl-cpp using homebrew, the install fails with a cmake related error.
 ~: brew install abseil --head
==> Cloning https://github.com/abseil/abseil-cpp.git
Updating /Users/sameeragarwal/Library/Caches/Homebrew/abseil--git
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
HEAD is now at 92fdbfb3 Release the Abseil Logging library
==> cmake<EMAIL_ADDRESS>-DCMAKE_CXX_STANDARD=17 -DBUILD_SHARED_LIBS=ON
Last 15 lines from /Users/sameeragarwal/Library/Logs/Homebrew/abseil/01.cmake:

    GTest::gmock

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  absl/log/CMakeLists.txt:514 (absl_cc_library)

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

Steps to reproduce the bug
brew install abseil --head

What version of Abseil are you using?
https://github.com/abseil/abseil-cpp/commit/92fdbfb301f8b301b28ab5c99e7361e775c2fb8a
What operating system and version are you using
21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000 arm64

What compiler and version are you using?
Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Please include the output of gcc -v or clang -v, or the equivalent for your
compiler.
Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

What build system are you using?
cmake version 3.24.1

https://github.com/abseil/abseil-cpp/blob/92fdbfb301f8b301b28ab5c99e7361e775c2fb8a/absl/log/CMakeLists.txt#L514-L537
https://github.com/abseil/abseil-cpp/blob/92fdbfb301f8b301b28ab5c99e7361e775c2fb8a/CMake/AbseilHelpers.cmake#L100-L103
It looks like we have our CMake setup so that we build all libraries that are marked TESTONLY and PUBLIC by default. The TESTONLY libraries often depend on GoogleTest, but you usually don't have GoogleTest unless you intend to build the tests, which isn't the default. I'm thinking we should maybe add a CMake option to build the test helpers (without running the tests) that is off by default.
It also looks like we have no build that doesn't run the tests, so we don't catch this issue. Ironically, running the tests caused us not to catch this.

I have googletest installed via homebrew too.


Coverflow of Finder view in mac

Coverflow is great! I want to modify it a little to closely match the coverflow view of Finder view in a Mac (The example tilts the images on both sides, instead I want them to be partly hidden behind the front facing image like Finder view does) with title of the selected image. Any help appreciated!

+1


Fix branch condition on tags

Ignore branch condition on tag events to prevent issues like the one reported on https://github.com/woodpecker-ci/woodpecker/issues/894.

we need documentation about this behavior

Codecov Report

Merging #917 (7482b6e) into master (70af29f) will increase coverage by 0.08%.
The diff coverage is n/a.

:exclamation: Current head 7482b6e differs from pull request most recent head 2ba0277. Consider uploading reports for the commit 2ba0277 to get more accurate results

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
+ Coverage   51.59%   51.67%   +0.08%
==========================================
  Files          80       80
  Lines        6096     6096
==========================================
+ Hits         3145     3150       +5
+ Misses       2768     2763       -5
  Partials      183      183

Impacted Files
Coverage Δ

server/logging/log.go
54.65% <0.00%> (+5.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70af29f...2ba0277. Read the comment docs.


Markdown support for topic description

There's no way to style topic descriptions at the moment, not even newlines.
Markdown would be a very well known way to do formatting. It would also be a solution for #1 and #2.

There also a suggestion to support html, this might be harder to implement since we'd need to exclude certain html tags to prevent injection/ screwing with the template.

I don't know if following lists are complete, but I guess HTML will be less work:
HTML:

The backend will have to clean up whatever the user
Rendering is easy, just display what the backend sends...

Markdown:

We'll have to check if there are ways to do some sort of injection with markdown
I guess we'll have to check if it's valid
Find a library that renders it on the front-end.

But personally, I still favor markdown because it is nicer to read and edit.

I'm also more fan of Markdown since I know it. But not all developers know Mardown most know html though.
HTML
You can display HTML (coming from an external endpoint) straight in the page with Angular without explicitly ignoring it's safety checks. It's pretty easy to to put some kind of injection in html code.
e.g. just include an external script and since you're forcing Angular to just accept whatever that's in there it will just render it.
Markdown
I don't think it's (easily) possible. I don't think we should have a markdown validation. If it's not valid we can just leave it, triggering the user to update it. Of course some kind of validation or preview can always be added in a later stage.
We can also write our own simple markdown parser. This way we can control what'll be rendered and what not. This helps us out because we'll not have to worry about injections etc as long as we keep it simple enough. We can iteratively increase to more Markdown support and check for injection possibilities. It'll be easier then including a library and then having to worry about every feature of that library. A lot of features won't be used anyway. Since most people will just use it to make some bulletlists and add some headers or basic formatting.
Extra option: rich editor
We could also just include some kind of rich editor. Since we just try to have some formatting to make the description more readable.


Replaced kevee/quail with quailjs/quail

Hello. I noticed that this repository still has references to kevee/quail, despite being moved to quailjs/quail, so I replaced them for you in this pull request. Using the old URL could be confusing and inefficient, and is also causing a 404 error when https://travis-ci.org/kevee/quail is visited.

Committed to the master branch: 27ac01337eed4d3c15c8a23cc8aff977025bda49

Thank you @honzi !


Vue Upgrade Stalls

Version
4.1.2
Environment info
  System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
  Binaries:
    Node: 12.12.0 - /usr/local/bin/node
    Yarn: 1.19.1 - /usr/local/bin/yarn
    npm: 6.13.4 - /usr/local/bin/npm
  Browsers:
    Chrome: 79.0.3945.88
    Firefox: Not Found
    Safari: 13.0.4
  npmPackages:
    @coreui/vue: ^2.1.2 => 2.1.2
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.9.2
    @vue/babel-preset-jsx:  1.0.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.0.0
    @vue/cli-overlay:  3.9.0
    @vue/cli-plugin-babel: ^3.4.1 => 3.9.2
    @vue/cli-plugin-eslint: ^3.4.1 => 3.9.2
    @vue/cli-service: ^3.6.0 => 3.9.2
    @vue/cli-shared-utils:  3.9.0
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/test-utils: ^1.0.0-beta.29 => 1.0.0-beta.29
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    eslint-plugin-vue:  4.7.1
    portal-vue:  2.1.6
    vue: ^2.6.8 => 2.6.10
    vue-apollo: ^3.0.0-rc.7 => 3.0.0
    vue-class-component:  7.1.0
    vue-cli-plugin-apollo: ^0.19.1 => 0.19.2
    vue-cli-webpack:  1.0.0
    vue-eslint-parser:  2.0.3
    vue-functional-data-merge:  3.1.0
    vue-hot-reload-api:  2.3.3
    vue-router: ^3.0.6 => 3.0.7
    vue-slider-component: ^3.0.41 => 3.0.43
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.8 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: 4.1.2

Steps to reproduce

Have a Vue project containing the package  "@vue/cli-service": "^3.6.0"
Attempt to upgrade via vue upgrade

What is expected?
After running vue upgrade via CLI in my vue project directory, I expect an upgrade wizard to assist with upgrading @vue/cli dependencies.
What is actually happening?
I receive the following message, one about a slow connection to the NPM registry, and another never-ending "Gathering package information..." loading message
⠹  Gathering package information...?  Your connection to the default npm registry seems to be slow.
⠇  Gathering package information...

I've tested my connection to the default npm registry, and in every other case it is not slow at all. Have tried the usual re-starting, upgrading, etc, but to no avail

On a sidenote, it says "Firefox: Not Found" when I run vue info, but I do, in fact, have Firefox 71.0 installed. This is a separate issue, I realize

+1

+1

Thanks @garlian. Solved the problem for me

@bzelba's woraround worked for me. Still the original issue is very annoying, according to docs only vue upgrade is required to update dependencies https://cli.vuejs.org/guide/installation.html#project-dependencies ([plugin-name] being optional)


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 853

Questions ?
Please refer to the Backport tool documentation


⚠ File access (beta) has degraded performance

In 78e999f, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 4273 ms

Resolved: File access (beta) performance has improved in 545e637 after 170 days, 23 hours, 27 minutes.


Update the gradle configuration and dependency versions to work properly

Dear Project Team,
I hope this message finds you well. I wanted to bring to your attention an issue we are currently facing with the project. The current version of the project is outdated and cannot be loaded on the latest version of Android Studio. To address this issue, I have made some updates to the project configuration and dependencies, aiming to make it easier for future users to utilize this example.
Here are the key changes I have made:
Updated Android Studio Version: I have migrated the project to the latest version of Android Studio (2022.3.1). This ensures compatibility with the most recent features and improvements.
Modified Configuration Files: I have reviewed and updated the project's configuration files to align with the new Android Studio version. This includes updating the build.gradle files, manifest files, and any other necessary configuration files.
Upgraded Dependencies: I have upgraded the project's dependencies to their latest versions. This ensures that we are utilizing the most up-to-date libraries and frameworks, providing better performance, security, and compatibility.
You can find the pull request here. I have also provided detailed comments within the pull request, explaining the rationale behind each change.
Please feel free to ask any questions or provide feedback on the proposed updates. I am open to discussing any concerns or suggestions you may have.
Thank you for your attention and support in maintaining the project's quality and usability.
Best regards,
HuairenWu

Please review again. I have already signed the Individual Contributor License Agreement (CLA).


Code styling fix: Indent heredocs for more readable code.

Since heredocs support indentation, they do not have to have 0 indent which makes the code a bit unreadable.

Related to https://github.com/manastech/crystal/commit/b32a5a7edb89b04cfac6d6d63f15c36b0fcf0868 by @asterite

Thank you!! :+1:


seems like systemd is missing? or something something something devbox installer doesn't work

with the following workflow:
on:
  push:
    branches:
      - master

permissions:
  contents: write
  pull-requests: write
  packages: write

name: ReleaseManagement

jobs:
  Release:
    runs-on: ubuntu-22.04

    outputs:
      release_created: ${{ steps.release.outputs.release_created }}
      releases_created: ${{ steps.release.outputs.releases_created }}
      tag_name: ${{ steps.release.outputs.tag_name }} # e.g. v1.0.0
      version: ${{ steps.release.outputs.version }} # e.g. 1.0.0
      json: ${{ toJSON(steps.release.outputs) }}
    steps:
      - uses: google-github-actions/release-please-action@v3
        if: ${{!github.event.act}}
        id: release-please
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          command: manifest
          release-type: go
          extra-files: |
            meta/package.go
      - id: release
        name: act interop
        run: |
          if [ "${{!github.event.act}}" == "false" ]; then
            echo "release_created=true" >> $GITHUB_OUTPUT
            echo "releases_created=true" >> $GITHUB_OUTPUT
            echo "tag_name=snapshot" >> $GITHUB_OUTPUT
            echo "version=snaphot" >> $GITHUB_OUTPUT
          else
            echo "release_created=${{ steps.release-please.outputs.release_created }}" >> $GITHUB_OUTPUT
            echo "releases_created=${{ steps.release-please.outputs.releases_created }}" >> $GITHUB_OUTPUT
            echo "tag_name=${{ steps.release-please.outputs.tag_name }}" >> $GITHUB_OUTPUT
            echo "version=${{ steps.release-please.outputs.version }}" >> $GITHUB_OUTPUT
          fi

  Build:
    if: needs.Release.outputs.releases_created

    runs-on: ubuntu-22.04
    needs: [Release]

    env:
      REGISTRY: ghcr.io
      IMAGE_NAME: ${{ github.repository }}

    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
          fetch-tags: true

      # - name: Set up QEMU
      #   uses: docker/setup-qemu-action@v2
      # - uses: docker/setup-buildx-action@v2
      # - name: Docker Login
      #   uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
      #   with:
      #     registry: ${{ env.REGISTRY }}
      #     username: ${{ github.actor }}
      #     password: ${{ secrets.GITHUB_TOKEN }}

      - name: setup jetpack devbox
        uses<EMAIL_ADDRESS>
      - name: Run GoReleaser
        env:
          registry: ${{ env.REGISTRY }}
          IMAGE_NAME: ${{ env.IMAGE_NAME }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: |
          if [ "${{ !github.event.act }}" == "true" ]; then
            devbox run -- gorelease release --clean
          else
            devbox run -- gorelease build --clean --snapshot
          fi

with this .actevent.json
{
  "act": true
}

and this command
  act push \
    --platform ubuntu-22.04=catthehacker/ubuntu:full-latest \
    --eventpath .actevent.json \
    --workflows .github/workflows/release.yml \
    --job Build

i get this output:
act push --platform ubuntu-22.04=catthehacker/ubuntu:full-latest --eventpath .actevent.json --workflows .github/workflows/release.yml --job Build
[ReleaseManagement/Release] 🚀  Start image=catthehacker/ubuntu:full-latest
INFO[0000] Parallel tasks (0) below minimum, setting to 1
[ReleaseManagement/Release]   🐳  docker pull image=catthehacker/ubuntu:full-latest platform= username= forcePull=true
INFO[0002] Parallel tasks (0) below minimum, setting to 1
[ReleaseManagement/Release]   🐳  docker create image=catthehacker/ubuntu:full-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[ReleaseManagement/Release]   🐳  docker run image=catthehacker/ubuntu:full-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[ReleaseManagement/Release]   🐳  docker exec cmd=[chown -R 1001:127 /mnt/Store/Projects/Mine/Github/bank-downloaders] user=0 workdir=
[ReleaseManagement/Release]   ☁  git clone 'https://github.com/google-github-actions/release-please-action' # ref=v3
[ReleaseManagement/Release] ⭐ Run Main act interop
[ReleaseManagement/Release]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/release] user= workdir=
[ReleaseManagement/Release]   ✅  Success - Main act interop
[ReleaseManagement/Release]   ⚙  ::set-output:: version=snaphot
[ReleaseManagement/Release]   ⚙  ::set-output:: release_created=true
[ReleaseManagement/Release]   ⚙  ::set-output:: releases_created=true
[ReleaseManagement/Release]   ⚙  ::set-output:: tag_name=snapshot
[ReleaseManagement/Release] Cleaning up container for job Release
[ReleaseManagement/Release] 🏁  Job succeeded
[ReleaseManagement/Build  ] 🚀  Start image=catthehacker/ubuntu:full-latest
INFO[0004] Parallel tasks (0) below minimum, setting to 1
[ReleaseManagement/Build  ]   🐳  docker pull image=catthehacker/ubuntu:full-latest platform= username= forcePull=true
INFO[0006] Parallel tasks (0) below minimum, setting to 1
[ReleaseManagement/Build  ]   🐳  docker create image=catthehacker/ubuntu:full-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[ReleaseManagement/Build  ]   🐳  docker run image=catthehacker/ubuntu:full-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127 /mnt/Store/Projects/Mine/Github/bank-downloaders] user=0 workdir=
[ReleaseManagement/Build  ]   ☁  git clone 'https://github.com/jetpack-io/devbox-install-action' # ref=v0.7.0
[ReleaseManagement/Build  ] ⭐ Run Pre setup jetpack devbox
[ReleaseManagement/Build  ]   ☁  git clone 'https://github.com/actions/cache' # ref=v3
[ReleaseManagement/Build  ]   ☁  git clone 'https://github.com/actions/cache' # ref=v3
[ReleaseManagement/Build  ]   ☁  git clone 'https://github.com/DeterminateSystems/nix-installer-action' # ref=v4
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Pre Install nix
[ReleaseManagement/Build  ]   ✅  Success - Pre Install nix
[ReleaseManagement/Build  ]   ☁  git clone 'https://github.com/actions/cache' # ref=v3
[ReleaseManagement/Build  ]   ☁  git clone 'https://github.com/actions/cache' # ref=v3
[ReleaseManagement/Build  ]   ✅  Success - Pre setup jetpack devbox
[ReleaseManagement/Build  ] ⭐ Run Main actions/checkout@v3
[ReleaseManagement/Build  ]   🐳  docker cp src=/mnt/Store/Projects/Mine/Github/bank-downloaders/. dst=/mnt/Store/Projects/Mine/Github/bank-downloaders
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127 /mnt/Store/Projects/Mine/Github/bank-downloaders] user=0 workdir=
[ReleaseManagement/Build  ]   ✅  Success - Main actions/checkout@v3
[ReleaseManagement/Build  ] ⭐ Run Main setup jetpack devbox
[ReleaseManagement/Build  ]   🐳  docker cp<EMAIL_ADDRESS><EMAIL_ADDRESS>[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127<EMAIL_ADDRESS>user=0 workdir=
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Main Get devbox version
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1-composite-0.sh] user= workdir=
| Found devbox latest version 0.8.2.
[ReleaseManagement/Build  ]   ✅  Success - Main Get devbox version
[ReleaseManagement/Build  ]   ⚙  ::set-env:: latest_version=0.8.2
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Main Mount devbox cli cache
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ]   🐳  docker cp src=/home/zenobius/.cache/act/actions-cache-restore@v3/ dst=/var/run/act/actions/actions-cache-restore@v3/
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127 /var/run/act/actions/actions-cache-restore@v3/] user=0 workdir=
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[node<EMAIL_ADDRESS>user= workdir=
[ReleaseManagement/Build  ]   💬  ::debug::Resolved Keys:
[ReleaseManagement/Build  ]   💬  ::debug::["Linux-devbox-cli-0.8.2"]
[ReleaseManagement/Build  ]   💬  ::debug::Checking zstd --quiet --version
[ReleaseManagement/Build  ]   💬  ::debug::1.5.5
[ReleaseManagement/Build  ]   💬  ::debug::zstd version: 1.5.5
[ReleaseManagement/Build  ]   💬  ::debug::Resource Url: http://<IP_ADDRESS>:38721/_apis/artifactcache/cache?keys=Linux-devbox-cli-0.8.2&version=10c3673137184e8fc98ee7019556b49e59a4412bda7618d1ecdeb71d8913cc9a
[ReleaseManagement/Build  ]   ⚙  ***
[ReleaseManagement/Build  ]   💬  ::debug::Cache Result:
[ReleaseManagement/Build  ]   💬  ::debug::{"archiveLocation":"***","cacheKey":"linux-devbox-cli-0.8.2","result":"hit"}
[ReleaseManagement/Build  ]   💬  ::debug::Archive Path: /tmp/397c456e-f8f8-4241-aca7-c328ecdbbde2/cache.tzst
[ReleaseManagement/Build  ]   💬  ::debug::Use Azure SDK: false
[ReleaseManagement/Build  ]   💬  ::debug::Download concurrency: 8
[ReleaseManagement/Build  ]   💬  ::debug::Request timeout (ms): 30000
[ReleaseManagement/Build  ]   💬  ::debug::Cache segment download timeout mins env var: undefined
[ReleaseManagement/Build  ]   💬  ::debug::Segment download timeout (ms): 600000
[ReleaseManagement/Build  ]   💬  ::debug::Lookup only: false
| Cache Size: ~8 MB (8449799 B)
| [command]/usr/bin/tar -xf /tmp/397c456e-f8f8-4241-aca7-c328ecdbbde2/cache.tzst -P -C /mnt/Store/Projects/Mine/Github/bank-downloaders --use-compress-program unzstd
| Cache restored successfully
| Cache restored from key: linux-devbox-cli-0.8.2
[ReleaseManagement/Build  ]   ✅  Success - Main Mount devbox cli cache
[ReleaseManagement/Build  ]   ⚙  ::set-output:: cache-primary-key=Linux-devbox-cli-0.8.2
[ReleaseManagement/Build  ]   ⚙  ::set-output:: cache-matched-key=linux-devbox-cli-0.8.2
[ReleaseManagement/Build  ]   ⚙  ::set-output:: cache-hit=true
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Main Configure nix access-tokens
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1-composite-5.sh] user= workdir=
[ReleaseManagement/Build  ]   ✅  Success - Main Configure nix access-tokens
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Main Install nix
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ]   🐳  docker cp src=/home/zenobius/.cache/act/DeterminateSystems-nix-installer-action@v4/ dst=/var/run/act/actions/DeterminateSystems-nix-installer-action@v4/
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127 /var/run/act/actions/DeterminateSystems-nix-installer-action@v4/] user=0 workdir=
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Main Install Nix
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/1-composite-6-composite-0.sh] user= workdir=
| Set NIX_INSTALLER_EXTRA_CONF=experimental-features = ca-derivations fetch-closure
| trusted-users = root
| Set NIX_INSTALLER_URL=https://install.determinate.systems/nix?ci=github
| Set NIX_INSTALLER_LOGGER=pretty
| Set NIX_INSTALLER_DIAGNOSTIC_ENDPOINT=https://install.determinate.systems/nix/diagnostic
| Set NIX_INSTALLER_NO_CONFIRM=true
|   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
|                                  Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 16008  100 16008    0     0   9717      0  0:00:01  0:00:01 --:--:-- 64032
| info: downloading installer https://install.determinate.systems/nix/tag/v0.14.0/nix-installer-x86_64-linux
| `nix-installer` needs to run as `root`, attempting to escalate now via `sudo`...
| Error:
|    0: Planner error
|    1: Error executing action
|    2: Action `configure_init_service` errored
|    3: Could not detect systemd; you may be able to get up and running without systemd with `nix-installer install linux --init none`.
|       See https://github.com/DeterminateSystems/nix-installer#without-systemd-linux-only for documentation on usage and drawbacks.
|
| Location:
|    src/cli/subcommand/install.rs:197
|
| Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
| Run with RUST_BACKTRACE=full to include source snippets.
|
| Consider reporting this error using this URL: https://github.com/DeterminateSystems/nix-installer/issues/new?title=%3Cautogenerated-issue%3E&body=%23%23+Error%0A%60%60%60%0AError%3A+%0A+++0%3A+Planner+error%0A+++1%3A+Error+executing+action%0A+++2%3A+Action+%60configure_init_service%60+errored%0A+++3%3A+Could+not+detect+systemd%3B+you+may+be+able+to+get+up+and+running+without+systemd+with+%60nix-installer+install+linux+--init+none%60.%0A++++++See+https%3A%2F%2Fgithub.com%2FDeterminateSystems%2Fnix-installer%23without-systemd-linux-only+for+documentation+on+usage+and+drawbacks.%0A%60%60%60%0A%0A%23%23+Metadata%0A%7Ckey%7Cvalue%7C%0A%7C--%7C--%7C%0A%7C**version**%7C0.14.0%7C%0A%7C**os**%7Clinux%7C%0A%7C**arch**%7Cx86_64%7C%0A
[ReleaseManagement/Build  ]   ❌  Failure - Main Install Nix
[ReleaseManagement/Build  ] exitcode '1': failure
[ReleaseManagement/Build  ]   ❌  Failure - Main Install nix
[ReleaseManagement/Build  ] exitcode '1': failure
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[node /var/run/act/workflow/hashfiles/index.js] user= workdir=
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[node /var/run/act/workflow/hashfiles/index.js] user= workdir=
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ]   ❌  Failure - Main setup jetpack devbox
[ReleaseManagement/Build  ] exitcode '1': failure
[ReleaseManagement/Build  ] ⭐ Run Post setup jetpack devbox
[ReleaseManagement/Build  ]   🐳  docker cp<EMAIL_ADDRESS><EMAIL_ADDRESS>[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127<EMAIL_ADDRESS>user=0 workdir=
[ReleaseManagement/Build  ] 'runs-on' key not defined in ReleaseManagement/Build
[ReleaseManagement/Build  ] ⭐ Run Post Install nix
[ReleaseManagement/Build  ]   🐳  docker cp src=/home/zenobius/.cache/act/DeterminateSystems-nix-installer-action@v4/ dst=/var/run/act/actions/DeterminateSystems-nix-installer-action@v4/
[ReleaseManagement/Build  ]   🐳  docker exec cmd=[chown -R 1001:127 /var/run/act/actions/DeterminateSystems-nix-installer-action@v4/] user=0 workdir=
[ReleaseManagement/Build  ]   ✅  Success - Post Install nix
[ReleaseManagement/Build  ]   ✅  Success - Post setup jetpack devbox
[ReleaseManagement/Build  ] 🏁  Job failed
Error: Job 'Build' failed

This is not an issue with image. Containers do not contain nor cannot run systemd.


🏷 update pusher-js imports due to changes moving from definitelytyped

Previous version was relying on @types/pusher-js which is incompatible with the officially released definitions in the pusher-js package. This updates imports and ensures compliance with official types.

All good - I have removed references to pusher-js in the ./src folder. It's still a dependency because the examples depend on it. As mentioned further work would be to set up a package.json for each (or all) of the examples so the pusher-js-mock library does not depend on itself.

Addresses #25

Thank you so much for this @mayteio! I'll try to work on examples to have package.json in order to lose pusher-js as a dependency from the library.

Can do - won’t be until tomorrow though. Unless you wanted to jump in and revert.

It's fine, I'll do a release over the weekend when I'll have more time to focus and get this right


Unknown module(s) in QT: uitools

This issue concerns the installing instructions for goqt. Executing qmake "CONFIG+=release" causes an project error: "Project ERROR: Unknown module(s) in QT: uitools".
Is this error due to a missing QT module or is it caused by the project itself?

sudo apt-get install qttools5-dev qttools5-dev-tools does the trick.


Selective transform fails when transforms are not sampled

Often happens when p(transform)=0.5. The pipeline crashes.

Issues occurs in Perspective transform.


Process Objects from Queue of User Reported Content (original #351)

This issue has been migrated from the CC Search Catalog repository
Author: annatuma
Date: Fri Apr 03 2020
Labels: 🙅 status: discontinued

Problem Description
We need to develop a process by which we pull objects from a flagging queue, and add metadata in the catalog.
Further ticket work required
Relates to: https://github.com/creativecommons/cccatalog-frontend/issues/848

Closing this issue in favor of the project that Content report moderation: https://docs.openverse.org/projects/proposals/trust_and_safety/content_report_moderation/20230411-project_proposal_content_report_moderation.html


Tidier wording, and punctuation, in BootSplash.cpp

Primarily: 'Workspace' in lieu of 'Desktop(s)', and 'Applications' in lieu of 'System Applications'. Plus other minor changes to wording. Ellipses (…) – with leading space, see for example http://english.stackexchange.com/a/28208/11504

Thanks for cleaning that up!


Add CORS Header configuration to server

If you define custom headers in the JS client (see https://github.com/canoo/dolphin-platform/issues/243) than the CORS filter on the server must change. This should be configurable by the server DP configuration.

merged with https://github.com/canoo/dolphin-platform/pull/360


feat: service based load balancing

This still maintains the existing route table, it's just that every entry now points to the kube service.
If we are going to completely re-vamp route tables I think it is better to do it as part of a larger commit that also adds rolling deployments, but I will leave that decision up to @alecthomas

Awesome!


Improve default menu icons

The default menu has some hard-coded icons which seem to be unavailable on some systems. I think the default menu should look good on

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Fedora 31
[ ] Fedora 32
[ ] Pop!_os 20.04

I changed some icons; now it looks ok on most systems.


New silo: Cohost

Cohost is a tumblr-like social media network. It has a public API in progress.

Thanks for filing! For anyone looking at this, developer instructions for adding a new silo here, contributions and PRs welcome!

Alas, Cohost is no more


Fix truck for zpp

As you left.
Further work should be done in other branches.

I think we can make an exception here regarding the failed build, since everything is working fine except job shop scheduling für complex truck (which is now default so job aborts, since it is not terminating). I would like to investigate this on a separate PR.


Cannot read property'name' of null.

on staging:
when i log into my account, genie is looping on the message, "Sorry, that did not work: Cannot read property'name' of null."
if i enter text, i get the following response, "Sorry, I had an error processing your command: Cannot read property'name' of null."

Filed also as https://github.com/stanford-oval/genie-toolkit/issues/695. Related PR at https://github.com/stanford-oval/genie-toolkit/pull/696.


qa_crowbarsetup: improve reboot test coverage

because we observed a problem with
cinder local loop-device backend
where the thin volume was not activated on boot
thus tgtd errors ; and one cannot start instance with that attached volume

rebase
please add a comment to the code to document why it is disabled
maybe better than commenting out is to enclose the block in an if-clause that could be enabled by exporting a "want_something" variable.

actually, this was meant to reproduce the problem we saw on the cloudfoundry cloud http://bugzilla.suse.com/show_bug.cgi?id=971766
but it did not

I would like to keep cleanup functions. Tempest is also cleaning up resources after tests.


Fix order of mode restoration

While using Jujutsu on Windows 10/11 in PowerShell, I discovered a bug that's very easy to fix. Whenever I enter the pager (for example with jj log) for the second time in a row, it fails to properly repaint. That's because the order of operations in term::cleanup is not exactly the inverse of term::setup. The problem is that the EnableMouseCapture command in crossterm stores the current mode and DisableMouseCapture restores it, so in effect it used to restore raw mode (which was enabled before enabling mouse capture) during cleanup after having disabled it.
I only observed this behavior in PowerShell so far, not cmd.exe. Maybe only PowerShell respects these accidentally mixed up mode settings between invocations while cmd.exe restores the original mode somehow.

It most likely is a Windows-specific problem since I never came across this in all the Linux terminals that I tested minus on. Anyways Merging this.

Thank you for the quick turnaround, much appreciated.


CentOS7 compatibility

CentOS7 compatibiliy

Use poise-service to manage both systemd and upstart
Update metadata
Update Cheffile

Delete useless templates and config file
Update kitchen.yml
Correct global_options error with kitchen

Add new attribute debug_options
Correct template file
Correct kitchen.yml

lgtm

please also make a PR to the upstream repo

yes of course @kamaradclimber . Just want some internal review before ;)

+1

Why removing the init script in case the user doesn't want to use upstart?

:+1:


Don't require Cargo.toml for cargo yank

Same fix as #923.
Closes #1138

@bors: r+  b2e658c

:hourglass: Testing commit b2e658c with merge c2c6f40...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64


bug: Tuples cause imports to be missed

Describe the bug
When exporting a struct with the following field:
pub variants: Vec<(VariantId, VariantOverview)>,

It is exported as:
// This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually.

export type DatasetSplit = { field: string | null, variants: Array<[VariantId, VariantOverview]>, };

But there are no imports for the VariantId and VariantOverview types. Imports for other things work correctly.
Expected behavior
The generated typescript file has the required imports.
Version
ts-rs = { version = "8.1", features = ["uuid-impl", "chrono-impl"] }

This started appearing when upgrading to version 8.

Thanks for opening the issue!
I think I found & fixed that bug in (https://github.com/Aleph-Alpha/ts-rs/pull/306#discussion_r1561517414).
I'll try to get the PR merged as soon as I find some time. In the meantime, could you try that branch, and see if it fixes your issue?
ts-rs = { git = "https://github.com/Aleph-Alpha/ts-rs", branch="better-dependencies", features = ["uuid-impl", "chrono-impl"]}

Thanks!

Thanks!
I have already done a workaround in my project, but it definitely looks like that commit will fix the issue.
Though, of course, I'd recommend adding a unit test to make sure it never happens again :)
Feel free to close when that PR is merged.

fixed in #306

Thanks.
Minor note. The test you added seems to only ensure it can be exported without any errors, but it doesn't actually validate that the output has the imports that this issue mentioned was missing.

It does - our CI runs tsc over all outputs.


Migrate Icon and FloatingActionButton to function component

Details

coming from https://github.com/Expensify/App/pull/26654 and https://github.com/Expensify/App/pull/33224
Fixed Issues

$ https://github.com/Expensify/App/issues/16163
$ https://github.com/Expensify/App/issues/16150
Tests

Icon Test:

Verify that the app icons render correctly

FAB test:

Verify that the Floating action button ''+'' icon color is initially light
Verify that the Floating action button ''+'' icon color is not initially rotated
Verify that the Floating action button background color is initially green
Click on the FAB
Verify that the FAB ''+'' icon color is dark
Verify that the Floating action button ''+'' icon color is rotated
Verify that the Floating action button background color is dark (in the dark theme) or light (in the light theme)
Verify that clicking the FAB toggle the animation between the two states.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

same as tests above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/77965000/4d34299f-9548-4927-bc19-fd0027acc78b

Android: mWeb Chrome

https://github.com/Expensify/App/assets/77965000/b9c1b352-345c-417a-9958-18c1f31b8f14

iOS: Native

https://github.com/Expensify/App/assets/77965000/016daec9-d662-4e31-b028-83c2912debb5

iOS: mWeb Safari

https://github.com/Expensify/App/assets/77965000/26a52fcc-676b-46f1-9719-fa908fa57bbf

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/77965000/e6466756-e65c-49d9-86a4-bc91655de87a

MacOS: Desktop

https://github.com/Expensify/App/assets/77965000/a85ec4c0-996f-43f7-8aee-b5fc92beaa26

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

react-native-reanimated version bump here caused crash in android dev.
context: https://expensify.slack.com/archives/C01GTK53T8Q/p1704705454920009?thread_ts=1704683824.693909&cid=C01GTK53T8Q
repro step: https://github.com/Expensify/App/issues/34017
https://github.com/Expensify/App/assets/108292595/cf459eec-480b-48d5-9842-43bbfa65bdff


Improve input-validation for words

Implement measures to prevent contributors from storing invalid words.

[ ] https://github.com/elimu-ai/webapp/issues/420
[ ] https://github.com/elimu-ai/webapp/issues/1366

@watr-sheep Hi, Sandun. Do you need assistance with this?

@watr-sheep Hi, Sandun. Do you need assistance with this?

@nya-elimuai Not really, actually I couldn't look into the issue as I was busy for the past few days. I'll take a look today and will inform you if I need any help with it. Thanks.