chore: rename DivInvMonoid.Pow

This didn't match the naming convention at all.
Loogle tells me that ZPow is slightly more common than PowInt, though both are used.
This is an instance, so the name needs no deprecation

Thanks
bors merge


Can't get PDF output to work for rasterize

<EMAIL_ADDRESS>commented:

What steps will reproduce the problem?

Use the example rasterrize JS script
Run against any web page
Use test.pdf for output

What is the expected output? What do you see instead?
Working PDF, but instead it creates a blank one. It does appear to be the correct dimensions but its always blank. Here's a test PDF I generated:
http://dl.dropbox.com/u/1420136/test.pdf

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #102.
:star2:   8 people had starred this issue at the time of migration.

It sounds like several people are having this problem with several different pages.  Has anyone tried PhantomJS 2.0 yet?  That includes a major update to Webkit which may well have fixed the problem.
If you can reproduce the problem with PhantomJS 2.0, please try to construct a self-contained minimized HTML page which demonstrates the problem, and attach it to this issue.

I am using Phantomjs 2 for html to png,jpg and pdf (single page) conversion.  For some html files Phantomjs gives  blank pdf. I have  attached phantomjs_issue text file. It contain code of render.js and html page code

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed. In the future, if we see the need to attend to this issue again, then it will be reopened.
Thank you for your contribution!


Add some helper methods for working with ServerBossBars

API | Common
Adds #1533
Test plugin: https://gist.github.com/kashike/bb89aee16738a68f078a6e0c82432583

@kashike can you update the comments above for the suggestions so I can look into merging this.

@kashike @Zidane would we want this in API 7 at all?


UTF not supported

Replace doesn't work with UTF or UTF without BOM encoded files. Only works with ANSI encoded files.

Hi, this has been addressed in the latest version (v1.6) and is available for download here: http://www.phdesign.com.au/npptoolbucket/.


Added Y Combinator & KPMG engineering related opportunities

Added a few cool opportunities that may be of use!

KPMG Data Science Virtual Internship - learn how data science is used in industry
Y Combinator 'Learn how to work at a startup' - learn how engineering is done in Y Combinator-backed startups

Thanks @andsnw


Allow key_binding mods have space

This will allow  mods: Control | Shift, action: Copy.

Makes sense. Thanks!


algolia search bar not integrated

The search bar does not produce results because algolia has not be integrated yet.

Fixed inadvertently in #50, search is no longer used in new UI layout

Fixed inadvertently in #50, search is no longer used in new UI layout


Added zh-TW translation.

Added Traditional Chinese translations for UI text.

Thanks for the PR @oopsmonk

It's my pleasure. :-)


VerifyCsrfToken  middleware is Missing when I installed Laravel-AdminLTE in my project

Hi,
I noticed some basic Laravel files have gone missing when I installed  Laravel-AdminLTE in my project.
Few more middleware  files are missing too.
Is this a known issue?
I need to disable CSRF Protection for Specific Routes.
Is there a way this could work without a middleware?

Hi @chanakaDe Laravel files are not deleted during the installation process. Did you use the installation process mentioned here?
On the other hand, what Laravel version are you using, and what version of the package are you installing?

Hi @dfsmania Thank you so much.
I'm using Laravel Framework 11.19.0.
Yes I followed the instruction thee & got the latest version.
Is there a known way to repair Laravel installation ? :-)

I don't know if there is a way to restore a Laravel installation. If your project was tracked with a control version system, then you can figure out what files you deleted locally and restore they from the upstream.
If you just deleted files from the vendor folder, then executing composer install or composer update should restore them.
I'm not sure what you have done, can you share some screenshots or details of your issues?

@dfsmania  t seems in Laravel 11, we have no Middleware folder by default.
""Laravel 11 does not include the app/Http/Middleware folder unless you create or need custom middleware. This is because Laravel tries to keep the directory structure minimal and only includes directories that are actually in use."". Not an issue. Thank you for information.

@chanakaDe Oh, yeah they simplified the folder structure in version 11 (some middlewares were moved to the illuminate framework I think). So, it was just a misunderstood or this package have some kind of issue when installing on Laravel 11?
Can we close the issue?

@dfsmania  yes of course we can close the issue.
There are no issues with this package & Laravel 11.
Works fine.
Sorry for my misunderstanding if that caused any trouble. 👍🏻


Filter and reset button of grid are invisible

Laravel Version: 5.5
PHP Version: 7.1
Laravel-admin: 1.5.x-dev

Description:
Read on a resolved issue that this was a bug, that you already fixed. But, I have latest version and have this bug! Noticed that when I refresh the grid, it shows again.

Can you please show your filter code?

In controller:
$grid->filter(function($filter){
$filter->disableIdFilter();
$filter->like('name', 'Name');
});


[Task] Export and Import Current Configurations

Description
export current configurations in shenyu admin
Task List

[ ] export shenyu admin configuration including auth, metadata, plugin data, selector data, rule data.
[ ] import shenyu admin configuration including auth, metadata, plugin data, selector data, rule data.

assgin me , pls


feat(Partner Usage Reports): add partner resource usage report service to Partner usage reports

PR summary

Adding new partner API to fetch resource usage reports.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/cosell/partner.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/2063
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Integration test results

Example test results

:tada: This PR is included in version 0.59.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix mismatched function names in Last Modified Time recipe

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)

Description
The recipe for Add Last Modified Time sets the Astro config to import a function called remarkModifiedTime:
import { remarkModifiedTime } from './remark-modified-time.mjs';

export default defineConfig({
  markdown: {
    remarkPlugins: [remarkModifiedTime],
  },
});

But the plugin exports a function named modifiedTime:
export function modifiedTime() {
   return function (tree, file) {
     const filepath = file.history[0];
     const result = statSync(filepath);
     file.data.astro.frontmatter.lastModified = result.mtime.toISOString();
   };
}

When running the recipe as-is, this creates a vague console error:

Renaming the function from modifiedTime to remarkModifiedTime fixes the error.

CC @carsakiller, who made this recipe (thank you so much, I'm using it on my site as of today!)

Ah! Nice catch! I was adapting what I had for the article and ended up mixing the two up a bit 🤦♂. Glad you found it helpful!

Ah! Nice catch! I was adapting what I had for the article and ended up mixing the two up a bit 🤦♂. Glad you found it helpful!

I had no idea something like this was possible, it's kinda magic! Beats the pants off of trying to remember to update a static field in the frontmatter every time I edit an article.


Adds maven project under group id io.github.openfeign

This will allow us to fork into the openfeign org and test
based on #404

👍


Don't ignore errors when copying data

When copying data to the new table we're using INSERT IGNORE INTO ...
From the MySQL documentation:

If you use the IGNORE keyword, errors that occur while executing the INSERT statement are ignored. For example, without IGNORE, a row that duplicates an existing UNIQUE index or PRIMARY KEY value in the table causes a duplicate-key error and the statement is aborted. With IGNORE, the row is discarded and no error occurs. Ignored errors may generate warnings instead, although duplicate-key errors do not.

Silently dropping rows of production data should be avoided at all cost. Instead let's fail the migration by raising an error. This allows another path to be taken towards the desired DB schema without the stress of restoring from DB backups!

Will this work or does it cause race conditions between triggers and the copy process?

It will create a race condition between the triggers and copy process. A row that is above the high water mark of the copy process may already be copied to the target table through the triggers (eg. it was updated). In that case when the copy process reaches the chunk with that row, an insert (without ignore) would fail for that chunk due to duplicate key(s).

Thanks @SingerWang for the explanation ...
pt-online-schema-change also uses a ignore, see https://github.com/percona/percona-toolkit/blob/2.2/bin/pt-online-schema-change#L9274

@arthurnn If I understand it correctly, there is always a possibility of data loss when we add UNIQUE index to an existing column. Even though we can check the uniqueness of the current values in the column, we cannot guarantee there is no duplicated value gets added during the online migration.
I'm wondering if we can run a check before INSERT IGNORE to make sure that we are only ignoring the duplicates in PK and not in other columns, in which case we should raise an error.


Count of vulnerabilities not match

Hello team, we start to use Inspector for PoC to replace Snyk
After scanning we get a report where the count of vulnerabilities in the short report does not match the vulnerabilities in a long report
For example

On the screen, you can see
Critical	2
High	2
Medium	7
Low	1
Other	5
But in the list of vulnerabilities, we saw only 1 Critical

is this a bug or did we miss something?
We plan to fail the pipeline when the count of critical vulnerabilities is  greater than 0 but in this case, we always have 1 Critical vulnerability
P.S Question we compare the Vulnerabilities that are shown in the AWS Inspector console with what we get in the GitHub action pipeline and those 2 lists do not match too
In AWS Inspector we got

3 Critical
5 High
10 medium
For example, vulnerabilities CVE-2023-42282 and MAL-2022-4691 did not show in the Pipeline report
Does AWS Inspector use different types of scanning? Can we achieve the same report in both tools?

Hello, thank you for notifying us of your issue.
We are happy to investigate.
In order to assist our investigation, would you kindly send us the following documents?

Your GitHub Actions workflow definition (Inspector-portion is all we need)
The raw SBOM (json)
The raw Inspector scan (json)

We will use these files to try to reproduce the issue and identify root cause of the problem.
Please feel encouraged to sanitize any private information from your files.
Please send these files to:
<EMAIL_ADDRESS>@PLeS207

Hello, Mail with report sent

Mail received. We will continue this thread there.


add README.md for Sentence transformer examples with HPU device

What does this PR do?
This PR will add one README.md for all sentence transformer HPU examples although they have each readme on how to run for each example. This README will give the whole pictures on all examples for sentence transformer with HPU device and their supported features/test configurations as below like :

Before submitting

[X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


lintText and lintTextSync forcefully interact with the file system API

Hi team!
We're planning to use standard as a formatting API tool, since we know this repo offers functions such as lintText and lintTextSync. However, our target software does heavy interactions with the file system, and we do heavily mock the file system in our unit tests. I wonder if we could optionally disallow standard to use the file system API for lintText and lintTextSync. What do you people think? 🤔❔

lintText calls the internal parseOpts function
this function uses pkgConf to scan the filesystem for a package.json to look for additional options. This may be the filesystem calls that are happening.
there may also be additional calls inside executeOnText function in eslint itself (I didn't get a chance to check it thoroughly)

It may be worth using standard-engine directly (with eslint-config-standard and passing the customParseOpts option to send a modified parseOpts function. This would be a way to avoid the file system call to read package.json. Another option is to just use eslint directly :).
Part of the philosophy of the standard tool is to avoid having lots of configuration. Dropping down to using standard-engine directly may be the fastest way to accomplish your goal.

@Flet Maybe we should change standard-engine so that lintText doesn't take into account the package.json settings? It seems pretty random that lintText would behave differently depending on the current working directory.

@feross yeah that makes sense!

PR sent: https://github.com/Flet/standard-engine/pull/166
@sadasant Can you check if using standard with that PR applied to standard-engine solves your issue?


Ensure PMU Virtualization is turned off

Having PMU Virtualization turned on in Parallels on Macs may cause the MobyLinuxVM to not properly start up and consume considerable amount of CPU finally letting Docker on Windows to fail altogether
Proposed changes
I was not able to run Docker for Windows on my MacBook Pro Mid 2018 as host running Parallels Version 14.1.0 (45387) with a Windows 10 (1809, 17763.195) VM. Docker for Windows complained about "No activity on VM" and failed. I tried all things mentioned #2404 and #1808 and others, such as completely re-installing Docker for Windows, ensuring to have the latest Windows 10 build (I initially started having this issue with an earlier version than stated above).
Related issues (optional)
May help for #2404 and #1808

Deploy preview for docsdocker ready!
Built with commit f9950129d83d6b534790e9021f5c13593a382925
https://deploy-preview-7945--docsdocker.netlify.com

Great, thanks @zulli73! We appreciate your contribution.


chore(devops): Add example performance VM

Sets up boilerplate for Azure performance testing infra.
They have some really interesting high performance VMs that would be fitting for our use cases, including ones with RDMA-enabled Infiniband networking cards if we really want to go wild.

@conectado The NIC on this VM consistently gets over 1 Gbps:
adminuser@vm-westus2:~$ speedtest
Retrieving speedtest.net configuration...
Testing from Microsoft Azure (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by Actual Broadband (The Dalles, OR) [239.46 km]: 21.291 ms
Testing download speed................................................................................
Download: 1471.64 Mbit/s
Testing upload speed......................................................................................................
Upload: 1279.35 Mbit/s

We should add some docs on how to use this.
I can do it once I figure it out.

I am assuming the idea is to compile in the VM? Can we setup Rust and clone the repo as part of terraform?

I think that's out of scope for this PR -- I was just adding this to demonstrate how to spin up some VMs on Azure using Terraform to test performance with.
Will have to think if it's worth adding the CI complexity to automatically performance-test in Azure in the pipeline... tbh I would like to avoid adding more external dependencies to CI if possible. Maybe it can be a manually-run workflow or something.


Post release automated changes for translation releases

Post release automated changes for azure-rest-ai-translation-text

API change check
API changes are not detected in this pull request.


disable ECed output for nodelay decoding

A temporary fix of nodelay API.
see:
https://rbcommons.com/s/OpenH264/r/1193/

The failed UT case is the encoder interface test and this bug fix is important for decoder.


Removes setCredHelper, setKnownRegistryCredentials.

Part of #774
Had to change a lot of the HelpfulSuggestions-related code since the setCredHelper and setKnownRegistryCredentials were tightly coupled with that. Once the new eventing system is in place, we can completely revamp the HelpfulSuggestions system to be much cleaner and more maintainable.

@briandealwis The GradleHelpfulSuggestionsBuilder uses values from BuildConfiguration, PluginConfigurationProcessor, and other local scope variables, so it probably makes more sense to keep it decoupled from the full BuildConfiguration.


COCOS-145 : Support Other Private/Public Key Pair Algorithms

What type of PR is this?
This is a feature because it adds support for other Public/Private key pair types.
What does this do?
This adds the following private/public key pair types in addition to the already existing RSA:

ecdsa
ed25519

The PR allows generation of these keys, and modifies sdk to accept multiple key types to be used as digital signatures for agent.
Which issue(s) does this PR fix/relate to?

Resolves #145

Have you included tests for your changes?
No
Did you document any new/modified feature?
No

update agent/auth, test/computations test/manual/agent-auth

update agent/auth, test/computations test/manual/agent-auth


Boot Sequence execution may be delayed by earlier (overdue) FarmEvent sequence executions

For the case where FBOS has been down (powered off, e.g.) for more than 15 minutes and an existing Sequence Farm Event execution becomes due within a time window starting 15 minutes prior to boot up, then the overdue Farm Event sequence will run before the Boot Sequence (see pic.)
I'd like to work on a solution but first I have questions :)

Does FBOS reaally need to deal with overdue executions scheduled 15 minutes in the past ?
(@RickCarlino was surprised the code did this)
The CeleryScript Scheduler begins work on these overdue executions even well before the firmware is ready so they fail if they need the firmware !
What is the desired user story here ?

Thanks :slightly_smiling_face:

@jsimmonds2 I think handling the overdue executions was originally to help users who scheduled sequence events too closely together. For example, if a sequence was scheduled at 7:20 took 1 minute and 3 seconds to complete, that would cause a sequence scheduled at 7:21 to get skipped. However, 15 minutes is an excessively long grace period I think. We could reduce that period to 1 minute, or remove that functionality altogether if it allows FBOS test coverage and overall code maintainability to increase. Any affected users will simply need to space their sequence executions farther apart or combine the back-to-back executions into a single sequence to avoid having to pay attention to how long things take to finish.
Any executions that were scheduled to occur while the device is powered off (or not fully booted) should be thrown out to avoid runtime errors (lack of firmware) and just because that is somewhat unexpected behavior in my opinion.
Thanks for looking into this @jsimmonds2!

Thanks for looking into this @jsimmonds2!

@roryaronson . . and thanks for your informative reaction !
Will submit a PR, based on this, very soon.


Cannot delete custom field after creating it through the Metadata API

I'm running into a strange issue when attempting to use the mdapi to create, and delete custom lookup fields on a custom object. Basically the app I'm working on allows you to create, and remove custom lookup fields on a specific custom object. After creating, and deleting the same lookup field twice I start getting a cryptic internal server error upon trying to delete the lookup fields either through the mdapi or the standard Salesforce UI. The steps to reproduce my issue are:

Create lookup field using mdapi
Delete the above created lookup field using the mdapi
Create another lookup field using the mdapi
Attempt to delete the above created second lookup field using the mdapi; this is where the error starts.

My initial reaction when trying to delete the 2nd lookup field was to go into the setup UI, and try deleting it from there. However I was getting the same error below. Note that I would get this error when trying to delete the 1 field in the deleted field recycle bin, if you will, or the second field that hadn't been deleted yet.
An internal server error has occurred
An error has occurred while processing your request. The salesforce.com support team has been notified of the problem. If you believe you have additional information that may be of help in reproducing or correcting the error, please contact Salesforce Support. Please indicate the URL of the page you were requesting, any error id shown on this page as well as any other related information. We apologize for the inconvenience.
Thank you again for your patience and assistance. And thanks for using salesforce.com!
Error ID: 310618243-119730<PHONE_NUMBER>)
After banding my head against the wall trying to figure out how to get rid of these lookup fields I tried changing the child relationship name, saving the field, and then trying to delete the field; this worked. In order to delete the first field that was in the deleted field recycle bin I had to undelete it, change the child relationship name, and then delete it again.
Even though I now have a workaround I still need to figure out why this is happening, and how to fix/avoid it. My gut tells me it may have something to do with how I'm creating/deleting the fields... Like maybe I'm forgetting to populate some important field properties?
Here's my code to create the lookup field:
/*******************************************************************************************************
* @description Create a lookup field on any object to any object
* @param Name of the object this lookup field is to be created on
* @param Name of the other object this lookup field will relate to
* @param The lookup field's label
* @param The lookup field's name
* @param The lookup field's description
* @param The lookup field's help text
* @param The label for the relationship that will be created between the source and lookup object
* @param The name for the relationship that will be created between the source and lookup object
* @return Created lookup field name
* @example
* configMetaUtils.createLookupField(
* 	'Payment__c',
*	'Opportunity',
*	'Payment Opportunity',
*	'Payment_Opportunity',
*	'The opportunity related to this payment.',
*	'Select the opportunity this payment was created from.',
*	'Payments',
*	'Payments'
* );
*/
public String createLookupField(
	String relatedFrom,
	String relatedTo,
	String fieldLabel,
	String fieldName,
	String fieldDescription,
	String fieldHelpText,
	String childRelationshipLabel,
	String childRelationshipName
) {

    // Validate from and to objects
    SObjectType relatedTosObjectType = Schema.getGlobalDescribe().get(relatedTo);
    SObjectType relatedFromsObjectType = Schema.getGlobalDescribe().get(relatedFrom);
	if(relatedTosObjectType == null) {
		throw new Configuration.ApplicationException(
			'"' + relatedTo + '" is not a valid object to relate to. Please try again.'
		);
	}
	if(relatedFromsObjectType == null) {
		throw new Configuration.ApplicationException(
			'"' + relatedFrom + '" is not a valid object to lookup to. Please try again.'
		);
	}

	// Create custom field
	configuration_MetadataService.CustomField customField = new configuration_MetadataService.CustomField();
    customField.referenceTo = relatedTo;
    customField.label = fieldLabel;
    customField.fullName = relatedFrom + '.' + fieldName;
    customField.description = fieldDescription;
    customField.inlineHelpText = fieldHelpText;
    customField.relationshipLabel = childRelationshipLabel;
    customField.relationshipName = childRelationshipName;
    customField.type_x = 'Lookup';
    List<configuration_MetadataService.SaveResult> results;
    results = this.service.createMetadata(new configuration_MetadataService.Metadata[] { customField });
    this.handleSaveResults(results[0]);

    // If no exceptions have been thrown thus far go ahead, and return the lookup field's name
    return fieldName;
}

Here's my code to delete the lookup field:
/*******************************************************************************************************
* @description Delete an existing lookup field
* @param Name of the object the lookup field will be deleted from
* @param Name of the lookup field
* @example
* configMetaUtils.deleteLookupField('Payment__c', 'Opportunity__c');
*/
public void deleteLookupField(String fieldObjectName, String fieldName) {
    List<configuration_MetadataService.DeleteResult> results =
        this.service.deleteMetadata(
            'CustomField', new String[] { fieldObjectName + '.' + fieldName });
    this.handleDeleteResults(results[0]);
}

Any help, advice, or insight would be much appreciated. This code is part of my apps setup wizard which is so close to being finished. Thanks in advance!

Your app sounds most exciting!
 There is a facility with the deploy operation to do a forced delete which bypasses the field / custom object recycle bin, however i'm not aware of any on the CRUD metadata options (though worth double checking headers and such like). Other thought would be can you try a second delete operation on the fields deleted name which i think becomes something like Fred_del__c?
Finally, GACK's are worth passing to Salesforce as if they can give you the underlying messages these can sometimes be quite helpful, so might be worth doing a repo in CURL and sending that over to SF via a Support Case.


Question on Point's dimension limit

According to https://docs.rs/rstar/latest/rstar/trait.Point.html, Point can be built from arrays/tuples of dimension up to 9. Is there any specific reason why 9 is chosen to be the upper limit?

Tuple impls are done via a macro, so there is typically a limit to it.  Array impls where probably coded before const. generics became standardized, so it may be possible to support arbitrary, but compile-time-chosen dimensions here.
Note that, r-star as a data-structure gets quite inefficient as the dimension (of the space) increases.  You may want to consider other techniques:  locality-sensitive hashing, dimension-reduction, etc. for high-dimensional data.

Thanks for explaining. I'll try reducing the dimension and see how it runs.


glib: Use a reference to a pointer of correct mutability for from_gli…

…b_ptr_borrow()
This hopefully makes it easier to use and harder to get the returned lifetime wrong.
Fixes https://github.com/gtk-rs/gtk-rs-core/issues/1373

CC @sophie-h

Also need to update gstreamer-rs after merging this.


LDAP backend support

Originally created by Antoine Nguyen on 2012-10-21T10:18:35Z
Amavis is able to look into an LDAP directory, we should support this. (policies, etc.)

This issue was moved to modoboa/modoboa-amavis#11


docker compose quick-start demo

DRAFT
#!/bin/bash
git clone git@github.com:PaimaStudios/paima-game-templates.git paima-quickstart
cd paima-quickstart
git checkout feature/quick-start
curl -L -O https://github.com/PaimaStudios/paima-engine/releases/download/v1.0.0/paima-engine-linux
cd chess
./quick-start.sh
# open http://localhost:9000

I would put all of this in @paima/build-utils so that it can be used from any game (and not just chess) and people can use it from a simple npx command


Importing large repositories to KIE Sandbox will hang forever

Importing huge repositories (such as kie-tools) to KIE Sandbox via the Import from URL section will hang forever waiting for the editor to load, without logging or displaying any messages.
It's expected for the repository to be correctly imported and the editor to be loaded with the first editable file available. It's fine if it takes a while but shouldn't hang.
Optionally, it would be good if the loading message when importing was more descriptive.
Errors should be logged into the console while also providing the user with some feedback.

It turns out the problem is not related to the size of the repository but to the existence of symlinks.
This simple example is able to reproduce the issue.
circle-link.zip

Seems like the issue is not related to the size of a repository, but instead if it has a circular symlink!
This repo provides a simple sample of an import that breaks.
What's weird is that things only break if imported via Git integration. If I try to import this repo directly via file import, things work normally.

@thiagoelg Can we rename this issue then? To reflect what the problem really is...


Use ioutil.TempFile for safeFiles

Use ioutil.TempFile instead of adding a "_temp" suffix when creating a new safeFile.
Added tests as well.

I'm not sure I agree with this. One advantage of _temp is that if a user complains of data loss, we can say "just rename x_temp to x." Also, the tmp dir is subject to cleanup by the OS, so those files may be lost after a reboot or similar event.

This is true, although the "_temp" file is likely to be incomplete. Isn't the purpose of safeFile to prevent incomplete data? Unless the user or Sia can fix up an incomplete file by filling in missing information.

Removed change to ioutil.TempFile.

looks good except that the files aren't being created in build.SiaTestingDir. Also, you can just use the name of the test (e.g. TestUnitNewSafeFile) as the name of the file. Something like:
NewSafeFile(filepath.Join(build.SiaTestingDir, "persist", "TestUnitNewSafeFile"))


Browser agent injected from the php APM extension is not working anymore

Description
I have the browser agent injected automatically in the HTML by the newrelic PHP extension (newrelic.browser_monitoring.auto_instrument=1).
Starting from the night of 2022-08-31, the browser agent fails to load with the following error in the browser console.
index:5 Uncaught (in promise) Error: Missing Configuration -- New Relic Browser agent requires applicationID, errorBeacon, beacon, licenseKey
    at index:5:68039
    at new Promise (<anonymous>)
    at index:5:66044
    at index:5:68344
    at index:5:68349
    at index:5:185
    at index:5:189

Steps to Reproduce
Let it inject automatically by APM.
Expected Behavior
The browser agent works correctly.
Relevant Logs / Console output
The necessary secrets (applicationID, errorBeacon, beacon, licenseKey) are also injected automatically. They are in the page, but the agent fails anyway.
Your Environment

NR PHP Agent <IP_ADDRESS>2 (upgraded yesterday after the first failures, <IP_ADDRESS>1 before).
Chrome
Ubuntu 20.04

Additional context
If I copy the content of the script tag that loads the agent into the browser console to run it, then the agent correctly starts.
I see it loads the agent's latest version (v1218).
Also, I see that the APM-injected version changed to v1218 on the same day.
https://docs.newrelic.com/docs/release-notes/new-relic-browser-release-notes/browser-agent-release-notes/browser-agent-v1218/

Thanks for the bug report @ilario-pierbattista . We're actively looking at why this occurs for you and hope to track it down quickly. Can you share some details about your setup? How are your secrets included in page when auto injected? Do they show up before or after the agent script?

The secrets are injected as well by the PHP extension. It places them at the end of the body tag. The snippet is placed as the first script in the head tag.
Today it magically works again. But I see that the snippet loads the v1216 version of the browser agent.
What kind of detail might you need to know?

This is great. Yeah, we rolled back to the previous version while we investigate and put a fix in place. Thanks!

We have raised a PR for addressing this --> https://github.com/newrelic/newrelic-browser-agent/pull/274
This should be reviewed and hopefully deployed with our latest changes by EoD, and we will follow up with you to ensure that nothing else has affected your implementation of the Browser Agent as we roll out

We will leave this bug report open until we roll out the next version of the agent with this fix and have you validate things are working as expected @ilario-pierbattista

Hi @ilario-pierbattista can you confirm this issue is resolved?

Hi @patrickhousley sorry I forgot to give feedback. Yes I confirm it's solved.
Thank you

Thanks for the confirmation @ilario-pierbattista


Pull down RegionLabel rules from PD

Pull down RegionLabel rules from PD
Required for #16141 #16417
RegionLabel rules are not yet presently imported from PD. Uses the JSON endpoint. See TiDB code for sample usage.

/assign @afeinberg


Iblockchain-guardian.js

Describe the bug
A simple starckblitz container filled withith web3 assets for a simplified experience
Link to the blitz that caused the error
https://stackblitz.com/github/nuxt/starter/tree/v2-stackblitz?file=README.md,.vscode%2Fsettings.json
Steps to reproduce
Clone the repository to your local filesystem
Expected behavior
A simple website template registrar with the option to choose bitcoin java, Ethereum or the Polkadot Ecosystem as the initial layout, https://v3-apidocs.cloudfoundry.org/version/3.126.0/index.html
stackblitz/webcontainer-core#812
stackblitz/webcontainer-core#795
stackblitz/webcontainer-core#637
stackblitz/webcontainer-core#405
stackblitz/webcontainer-core#210
stackblitz/core#2361
#Opswap.xyz
#$OPSWAPCOIN
stackblitz/webcontainer-core#206
#0xB45A7510EaaD1Ef02CFaD55C67c0EA084CDD40d2;#0x0364c8DBdE082372E8d6A6137B45613dd0F8138a
stackblitz/webcontainer-core#681 stackblitz/webcontainer-core#731 stackblitz/webcontainer-core#598 stackblitz/webcontainer-core#734 #web3
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
https://opencontainers.org/
Platform
Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 105
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 64000000,
  "usedJSHeapSize": 60300000,
  "jsHeapSizeLimit": 747000000
}
Hash = d0cd7a8669bec74204b2f31e5c2487ab3f6a28b6

Additional context
https://java-buildpack.cloudfoundry.org/openjdk/trusty/x86_64/index.yml
crd-shim-demo-mk3.mp4
https://www.envoyproxy.io/
https://istio.io/latest/docs/examples/bookinfo/
cat << EOF > "${PWD}/config.json"
{
"cf_system_domain": "bosh-lite.com",
"cf_admin_user": "admin",
"cf_admin_password": ,
"cf_internal_apps_domain": "apps.internal",
"cf_internal_istio_domain": "istio.apps.internal",
"cf_istio_domain": "istio.",
"product_page_docker_tag": "cfrouting/examples-bookinfo-productpage-v1:latest",
"reviews_docker_tag": "cfrouting/examples-bookinfo-reviews-v3:latest",
"ratings_docker_tag": "istio/examples-bookinfo-ratings-v1:1.5.0",
"details_docker_tag": "istio/examples-bookinfo-details-v1:1.5.0",
"wildcard_ca": "<envoy_wildcard_ca.ca>"
}
EOF
#1111111111111111111111111111111111111111
https://renproject.github.io/gateway-staging/?network=testnet
https://blog.blockstream.com/blockstream-amp/
https://tml.klapka.cz/?intro=0
https://wager07.xyz/ad
https://uimega.com/
https://nextearth.io/
https://www.chainguard.dev/
https://smarthealth.cards/en/
https://v3-apidocs.cloudfoundry.org/version/3.126.0/index.html
https://www.sunnya97.com/blog/daoifying-uniswap-automated-market-maker-pools
#wallet:0x90F8bf6A479f320ead074411a4B0e7944Ea8c9C1
https://play.theatlantis.io/

Hi @PinkDiamond1! :wave:
Thanks for opening this issue! I'm struggling to understand what's the issue here. Which command did you expect to work that didn't?

:wave: We're closing this due to inactivity. Please, feel free to open a new one if you're still encountering any errors.


[ai-vision-face] should this package be under sdk/vision directory?

The package is currently at sdk/face/ai-vision-face-rest directory.  face doesn't feel like an azure service.
There's already sdk/vision/ai-vision-image-analysis-rest there.

According to this documentation: What are Azure AI services?, face, vision, speech, document intelligence are parallel services, so current structure looks reasonable to me.
Besides, since they logically belong to Azure AI Services (formerly Azure Cognitive Services), probably the structure in azure-rest-api-spec is more like what you want? https://github.com/Azure/azure-rest-api-specs/tree/main/specification/ai

face, vision, speech, document intelligence are parallel services, so current structure looks reasonable to me.

Hmm, there must be a reason why vision is added before face?  Also should image-analysis be moved out of vision directory if we follow api-specs structure? I see Face and ImageAnalysis there.

I see a 'vision' service folder in .NET and Python:
https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/vision
https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/vision
Neither seem to have this version of the SDK yet, only the old version under cognitiveservices.

Docs doesn't seem very consistent, I see Face is listed as one of AI Vision services here: https://learn.microsoft.com/en-us/azure/ai-services/computer-vision/

I see a 'vision' service folder in .NET and Python:
https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/vision https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/vision
Neither seem to have this version of the SDK yet, only the old version under cognitiveservices.

Face SDK for the other languages are still under review. All of them are targeting sdk/face folder.
Computer vision and Face API are different service when creating resource in Azure. That's why we put SDK in different folders.
We should have a discussion with our PM if we need go to vision folder with image anaylsis.
.NET PR: https://github.com/Azure/azure-sdk-for-net/pull/43820
Java PR: https://github.com/Azure/azure-sdk-for-java/pull/40023
Python PR: https://github.com/Azure/azure-sdk-for-java/pull/40023

Our PM said we should keep branding in vision for now, but it might be pull out of vision in the future.
We'd like to purpose staying at sdk/face to keep the flexibility.
We tried to move our code to sdk/vision in each language but encountered several pipeline issues.
JS got test failure.
Java got  TypeSpec generation validation failure.
Since we are separate services owned by separate teams, we should not block each other's development.
@xirzec @jeremymeng do you feel it's okay for us to stay at sdk/face?

@Han-msft I have a question, do you have independent service tree nodes?

@Han-msft I have a question, do you have independent service tree nodes?

Yes, Face API is Cognitive Services Face API under Cognitive Vision.
https://microsoftservicetree.com/services/82b9a1cf-bbe3-488b-bdf9-fee717fa393a
Image analysis is a subset API in Cognitive Services Computer Vision API under Cognitive Vision.
https://microsoftservicetree.com/services/a2eae2da-667d-4b19-8789-9471e346ca84

Then I think it's fine to put them into two different folders.

@Han-msft thanks for confirming! I am fine with sdk/face too.  It's not customer-facing and more for the consistency of our repo.


elasticsearch6: refactor plugins

The plugins command didn't actually work with elasticsearch6 so
I have added a new derivation for elasticsearch6 plugins. This
also means there won't be problems with versions of plugins that
only work for ES5 and not ES6.
Unfortunately it is down to the user to use the elasticsearch6Plugins
packages when setting up an elasticsearch server but I couldn't
think of a way around this.
Currently there is only 1 plugin, the discovery ec2 plugin since
this is the one I am using.
Motivation for this change
elasticsearchPlugins doesn't work with ES 6
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

I think we should drop elasticsearch 1.7 and elasticsearch2 before the next release. Both are end of live: https://www.elastic.co/support/eol

@Mic92 agreed.

none of the elasticsearch plugins I tried work.
When I start the elasticsearch service, I get:
AccessControlException: access denied ("java.io.FilePermission" "/var/lib/elasticsearch/plugins/elasticsearch-analysis-lemmagen/meta-plugin-descriptor.properties" "read")

When I start elasticearch manually:
org.elasticsearch.bootstrap.StartupException: java.lang.IllegalStateException: Could not load plugin descriptor for plugin directory [commons-logging-1.1.3.jar]
        at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:140) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:127) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:124) ~[elasticsearch-cli-6.3.2.jar:6.3.2]
        at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-cli-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:93) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:86) ~[elasticsearch-6.3.2.jar:6.3.2]
Caused by: java.lang.IllegalStateException: Could not load plugin descriptor for plugin directory [commons-logging-1.1.3.jar]
        at org.elasticsearch.plugins.PluginsService.readPluginBundle(PluginsService.java:487) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.plugins.PluginsService.findBundles(PluginsService.java:469) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.plugins.PluginsService.<init>(PluginsService.java:147) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.node.Node.<init>(Node.java:311) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.node.Node.<init>(Node.java:252) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:213) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:213) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:326) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:136) ~[elasticsearch-6.3.2.jar:6.3.2]
        ... 6 more
Caused by: java.nio.file.FileSystemException: /var/lib/elasticsearch/plugins/discovery-ec2/commons-logging-1.1.3.jar/plugin-descriptor.properties: Not a directory
        at sun.nio.fs.UnixException.translateToIOException(UnixException.java:91) ~[?:?]
        at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) ~[?:?]
        at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) ~[?:?]
        at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214) ~[?:?]
        at java.nio.file.Files.newByteChannel(Files.java:361) ~[?:1.8.0_181]
        at java.nio.file.Files.newByteChannel(Files.java:407) ~[?:1.8.0_181]
        at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384) ~[?:1.8.0_181]
        at java.nio.file.Files.newInputStream(Files.java:152) ~[?:1.8.0_181]
        at org.elasticsearch.plugins.PluginInfo.readFromProperties(PluginInfo.java:163) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.plugins.PluginsService.readPluginBundle(PluginsService.java:484) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.plugins.PluginsService.findBundles(PluginsService.java:469) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.plugins.PluginsService.<init>(PluginsService.java:147) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.node.Node.<init>(Node.java:311) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.node.Node.<init>(Node.java:252) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:213) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:213) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:326) ~[elasticsearch-6.3.2.jar:6.3.2]
        at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:136) ~[elasticsearch-6.3.2.jar:6.3.2]
        ... 6 more

Any idea what is missing?

@Mic92 does 44389 make my PR obsolete? If so I am happy to close and will keep an eye on 44389.
I am using this fork in production using master branch of nixpkgs for the elasticsearch package. Did you get that error using this fork?

I got the error in pull request, which includes you changes from this pull request. Do I miss anything? https://github.com/NixOS/nixpkgs/blob/3f889f30bee92c3f2d5eaf53e56aef68f61efc4a/pkgs/servers/search/elasticsearch/plugins.nix

@Mic92 sorry for the delay in answering, what version of elasticsearch are you using for this? I am using the elasticsearch6-oss package in my fork.

@Mic92 perhaps its this https://github.com/NixOS/nixpkgs/pull/44389/files#diff-2d12e9f116784c475c19d55f07fee064L22
Previously when using es6 your if statement was not using the es5 branch so the security manager was disabled, now it is not.

@Mic92 can this PR be closed now?

To answer my own question, I have tried master branch and it works for me now so closing this PR. Thanks for the good work @Mic92 !


[ZEPPELIN-4597]. Deprecate r module

What is this PR for?
This PR just deprecate the existing the r module, but keep the source code until someone pick it up. We may delete it later if no one would like to take over it.
What type of PR is it?
[Refactoring]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4597

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Just general comment - should we have a document that will describe "bigger" changes, like, removal or addition of interpreters, etc.?

Make sense, thanks for the suggestion. @alexott


Fixes the overflow and padding problem for secondary nav items.

@catherine-jones Could you briefly review? (:

👍 Merge when ready


Status menu applications: odd behavior on multiple displays

I have noticed an intermittent problem with Status Menu applications that run in the background.  The problem only pops up when I have multiple displays, and I click on a Status Menu application which is running on a menu bar on the inactive display (i.e., the menu bar is partially transparent).  I am running OS X 10.10.4.
It is perhaps best described with an example:

On my main display (the one with the Dock) I click my app, DemoApp, in the menu bar.  It displays "Choice A", "Choice B", and "Quit DemoApp" as expected.
I go to my secondary display and open a window, do some work, etc.
I bring the mouse back to the main display and click on DemoApp (note at this point, the menu bar is partially transparent, as it is active on the secondary display and not this one).  It displays only "Quit DemoApp".  The choices are not displayed.  Uh oh.
The second time I click DemoApp, the normal behavior returns.
I can now sometimes repeat this example from the top. It doesn't seem to happen every time.

Thanks, let me know if that doesn't make sense or you'd like a screen capture of the problem.

Update: I've noticed this error periodically when using a single display, and if may have nothing to do with multiple displays.
I can't come up with a procedure to produce the problem every time.  However if I just sit here and slowly and continually click my Status Menu application in the menu bar, about 1 in 25 times or so it will come up with "Quit ..." as the only selection.

This is now fixed in master.

I'm still seeing this occasionally in 5.0... it's hard to repeat, but maybe 1 in every 30 times I click the app in the menu bar, all that's there is "Quit ...".  Click elsewhere, then go back, and everything is fine.

Hmmm.... I'll take a closer look.

Here's some more information that might help.  I've figured out a way to reproduce the problem in a pretty robust way, at least on my system.  This method requires multiple monitors.

Click the Status Menu app on screen 1.
Click the desktop of screen 1.
Click the Status Menu app on screen 2.
(Maybe 1 out of 2 times this produces an "empty" menu.  If not, continue.)
Click the desktop of screen 2.
Click the Status Menu app on screen 1.
(Maybe 4 out out of 5 times this produces an "empty" menu.  If not, start again from step 2.  If I keep playing this back and forth game, the error always pops up within a few seconds!

This is just a way to demonstrate a problem that otherwise seems to pop up "randomly".

Now fixed in master.


Updating converter diff hashes in all of the fluent SDK impls

Hi @martinsawicki, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (marcins). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Emotion/Loadable Components with SSR

I've been following https://github.com/shakacode/react_on_rails_tutorial_with_ssr_and_hmr_fast_refresh which worked fine, until I began using Emotion/Loadable Components.
With them I get a ReferenceError: "window is not defined" error as they seem to be incompatible with SSR.
In the server webpack config it mentions that in order to get those to work, you must use a node renderer– which would require RoR pro.
Is this the only solution?

Okay, so I was actually able to get SSR working with emotion & loadable components with the following setup.
Inside the server web pack config, I added the following:

  serverWebpackConfig.module.rules.forEach((loader) => {
    const use = loader.use;
    if (use) {
      loader.use = loader.use.map((item) => {
        if (item.loader === 'style-loader') {
          item.loader = 'null-loader';
        }
        return item;
      });

      console.log(loader.use);
    }
  });

all I did there was remove the style-loader as that would lead to an issue with the document not being defined.
additionally, I added serverWebpackConfig.resolve.aliasFields = ['module']; which solved any issue with emotion.

Okay, so I was actually able to get SSR working with emotion & loadable components with the following setup.
Inside the server web pack config, I added the following:

  serverWebpackConfig.module.rules.forEach((loader) => {
    const use = loader.use;
    if (use) {
      loader.use = loader.use.map((item) => {
        if (item.loader === 'style-loader') {
          item.loader = 'null-loader';
        }
        return item;
      });

      console.log(loader.use);
    }
  });

all I did there was remove the style-loader as that would lead to an issue with the document not being defined.
additionally, I added serverWebpackConfig.resolve.aliasFields = ['module']; which solved any issue with emotion.


Cannot access gated repo for url https://huggingface.co/meta-llama/Llama-2-7b-hf/resolve/main/config.json.

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
Cannot access gated repo for url https://huggingface.co/meta-llama/Llama-2-7b-hf/resolve/main/config.json.
Access to model meta-llama/Llama-2-7b-hf is restricted and you are not in the authorized list. Visit https://huggingface.co/meta-llama/Llama-2-7b-hf to ask for access.
Expected behavior
在运行example示例时候出现报错，无法访问
System Info
No response
Others
No response

llama2 加了权限申请限制，可以从 modelscope https://modelscope.cn/models/modelscope/Llama-2-7b-chat-ms/summary
站点下载。

export USE_MODELSCOPE_HUB=1
--model_name_or_path [modelscope/Llama-2-7b-chat-ms](https://modelscope.cn/models/modelscope/Llama-2-7b-chat-ms/summary)


[mle] clear last received Leader Data TLV on Mle::Stop

This commit clears the mLeaderData which is last received Leader
Data TLV from Mle::Stop() after network data is cleared.
This addresses an issue where if Mle::Stop() is called after an
attach (on MTD device) and then afterwards Thread is started again. The
device may assume it still has the correct network data and will not
request it from parent.

@abtink, can you detail where the network data is not getting properly communicated to an MTD from it's parent?  On a normal attach, the MTD always requests the network data in the Child ID Request.  Any other time, the parent is responsible for sending a Child Update Request to the child until the child acknowledges with a Child Update Response.

The issue seems to happen when app/user stops Thread (right) after device is attached and then starts it a bit later.
The child goes through the "Child Update" reattach (full attach works ok as we get the network data in "Child ID response" from parent).
If I am not mistaken, when the child gets the child update response, from HandleChildUpdateResponse() we call HandleLeaderData() where we check the  leader data TLV from received message with the saved mLeaderData TLV.  I think it it matches we skip requesting network data.
I noticed we used to have the same line memset(&mLeaderData, 0, sizeof(mLeaderData)) in Mle::Stop() earlier but was changed from https://github.com/openthread/openthread/pull/2250. I don't remember the background of this. Need your help to understand and fix this.

The problem lies in the fact that Mle::Stop() clears the (local and leader) network data state on the device.  How about we remove the calls to clear the network data in Mle::Stop().  In particular: https://github.com/openthread/openthread/compare/master...jwhui:network-data.

That can work.  I was also considering setting mRetrieveNewNetworkData to true from either Start or Stop as another approach.
If we keep network data, there is one thing which we need to be careful about: The case where a device is factory-reset and needs to join to a new network... (if I remember correctly on wpantund, added code to issue a NCP reset after "leave" command). I think we should always ensure an NCP reset/reboot to start clean before joining a new network.

Closing this for https://github.com/openthread/openthread/pull/2590.


Double clicking on a node a does not create the edge to b if b is already displayed

I am working on an example where there are Account, Person, and Address nodes. There is a Person node P1 with email<EMAIL_ADDRESS>that should have a LivesIn edge to an Address node A1 with value "953 Kyle Loop, Johnview, MT 59065". I'm playing around with double clicking on nodes to expand to their neighborhoods. Suppose A1 is already displayed on the panel, e.g., because I double clicked on the other Person node P2 that lives in the same address. Then if I click on P1, it will not generate the LivesIn edge to A1.
Some images:

This is the case when A1 is not on the screen and double clicking on P1 correctly puts A1 and the P1-[LivesIn]->A1 edge on the panel.

This is the case when both A1 and P1 are already on the panel and double clicking does not do anything.

We run a query:
MATCH (src:${tableName}) -[r]- (dst) WHERE src.${primaryKey} = $pk RETURN r, dst LIMIT ${sizeLimit}

to randomly sample from the neighborhood of a node when double clicking. Currently we filter out rows with destionations that already exist in the graph before processing. I disable this behavior in #162. However, due to the sizeLimit when the graph is large, it does not guarantee to always be able to add the edges.

If the behavior of always automatically connecting all the nodes on double clicking is required. Please reopen this issue.


{azure-mgmt-compute} Add LICENSE to pypi package

Fixes: azure/azure-sdk-for-python#20159
Signed-off-by: Major Hayden<EMAIL_ADDRESS>

Closing in favor of #20193 instead.


Treant creation

Just started using datreant, so maybe I have not wrapped my head around the logic yet. For my use case I'd like to provide a path to a specific script. This script should then load the Treant object if the path already exists, thus not creating a new Treant.
The problem is that Treant.exists always returns True, because it will create a non-existing Treant before checking the filesystem.
In [1]: import datreant.core as dtr

In [2]: ll
total 0

In [3]: dtr.Treant('some-path').exists
Out[3]: True

In [4]: ll
total 4
drwxr-xr-x 2 migecht 4096 Sep 14 16:53 some-path/

I would expect it to return False if the Treant does not yet exist. In the end you guys provide Treant.make() and Treant.makedirs() for the creation of new Treants, so why should a simple call of dtr.Treant() always create it immediately?

Because a Treant requires a state file, it will always give True when calling Treant.exists. As you pointed out, it seems strange that a Treant has methods like make() or makedirs() that simply will never be necessary. The reason these are here is that a Treant is a subclass of a Tree, which is the object you want to use directly here.
So you could do
import datreant.core as dtr

if dtr.Tree('some-path').exists:
    treant = dtr.Treant('some-path')

Note that some-path might not be a Treant already, since all we tested here was whether it existed as a directory. In other words, there might not be a state file inside it.
You could also take advantage of the fact that a Bundle will only ever find Treants, but will never create them. Say I have a bunch of trajectories one_fish, two_fish, red_fish, blue_fish, and only red_fish is a Treant:
>>> dtr.Bundle('one_fish', 'two_fish', 'red_fish', 'blue_fish')
<Bundle(['red_fish'])>

the Bundle will only contain elements that are actually Treants already. You could then extract out the Treant from the Bundle with indexing or however else you like.
Does that help?

Yes, that clears up things nicely. I just want to make sure not to create Treants when providing the script with a wrong path. Thanks!


Unstyled checklist (in iframe)

Hi there,
Thanks for providing us with this extension. Me and my team started using it today but realized that the "Issue Checklist for Jira" app from herocoders loads in an iframe and was thus not enjoying the inverted styling.
Would you consider accepting a PR or implement support for this yourself?
(This relates to Eric Satterwhite his comment under the support tab on the chrome web store)
The patch would be as follows:
Index: manifest.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/manifest.json b/manifest.json
--- a/manifest.json	(revision 17afdcd103f40ea166865520fedbe150998dc881)
+++ b/manifest.json	(revision f3c42d5d1e0164a7e43419c056b006d3b85dbda4)
@@ -9,9 +9,10 @@
   },
   "content_scripts": [
     {
-      "matches": ["https://*.atlassian.net/*"],
+      "matches": ["https://*.atlassian.net/*", "https://*.herocoders.com/issue/*"],
       "js": ["script.js"],
-      "css": ["style.css"]
+      "css": ["style.css"],
+      "all_frames": true
     }
   ]
 }
\ No newline at end of file

Hey!
Many thanks for your contribution, unfortunately I don't use herocoders so I could not test it.
Your contribution could also be a direct PR, but I can do it right away.
I gave the code of this small extension just to make it more universal and to get good ideas from users like you ! \o/
Let me test it, and push it to Chrome Dev so that it will be updated tonight.
Keep an eye on the version on the store / extension manager : it'll be the 0.2.5

Legend, thanks!

It's live in the Chrome Store since this morning. Don't hesitate to tell me if it's not working !

It's working :ok_hand:

Same issue for Smart Checklists. The url that the Smart Checklists plugin uses is the following: jirachecklist.com.
Could you add a feature to allow adding our own filters?  Thanks!

@codeversed Interesting point, unfortunately, after the last modification I made with herocoders, the extension had a significant drop in usage as chrome will block it for 100% of the users. It'll come back if they agree on giving the new right to read another domain. "No big deal" in a way, but it's like a never-ending story as the amount of jira integrated extensions is gigantic.
I would suggest to have this extension installed as a developper.
You can directly get this branch in which I made the very simple edit: https://github.com/jbronssin/jira-black/tree/Jirachecklist


Support named tuple output in the swagger ts plugin

What is the problem this feature would solve?
Named tuples may be used for easier to read function parameters, or for other structured tuple data.
Example:
export type MyfuncParams = [id: number, my_interesting_field: number, optional_field?: string | undefined];

There are no utility functions in Typescript to support conversion from a struct:
export type MyfuncRequest= { id: number; my_interesting_field: number; optional_field?: string | undefined };

What is the feature you are proposing to solve the problem?
Named parameters are usable for functions:
function myFunc(...params: MyFuncParams) {}

Named parameters are useful for tuples in an IDE,:
const a: MyFuncParams = result.nextRow();
const test = a[0];

In Visual Studio Code, the test variable will hover with: (property) 0: number (id), as the type annotation carries through.
While  this is a request for an extra option on the swagger ts plugin to just export alongside the generated Request structure for json-body style inputs.
What alternatives have you considered?
Request / Response pairs could be written out as a function:
type Myfunc = (id: number, my_interesting_field: number, optional_field?: string): MyfuncResponse
type MyfuncParams = Parameters<Myfunc>

OAS has Tuple support with a description field. It's a bit of a chore with min and max array lengths. Adding tuples to all input types could be a bit verbose, in trying to include query and path params.
This is intended as an optional feature, with the default of false.

Working int his space - great resource for actually getting aliasess to show up when they sometimes don't in type hints in your IDE:
https://stackoverflow.com/questions/57683303/how-can-i-see-the-full-expanded-contract-of-a-typescript-type
This one in particular will expand tuples, especially useful for return type:
type Expand<T> = T extends infer O ? { [K in keyof O]: O[K] } : never;

For:
type myfunc = (myarg: number) => [col1: string, cold2: number, col3: string][]

export interface example {
    myfunc(...args: Parameters<myfunc>): Promise<Expand<ReturnType<myfunc>>>
}

Again this is very VS Code hinting-oriented, but it was nice to see that interface work on an include. I'm in a JSDoc centric world so that's picked up in javascript file via:
/** @typedef {import("./api.d.ts").example} example */
/** @type {example} */
const exampleImpl = /** @type {const} */ {
    async myfunc(myarg) {
        return ...
    }
}

Some extra const in there to allow more type testing to flow through.

Not sure what the use cases are here, do you want to have function that will be used by React-Query be typed as tuples or do you want to have tuples that are named(in our ts plugin)? Do you have an example(based on the Swagger/OpenApi Petstore) of what you want to see as result?

This will be resolved with https://github.com/kubb-labs/kubb/issues/1195

I would like named/labeled tuples support in play;
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#labeled-tuple-elements
These are poorly supported by OpenAPI by using min and max element counts for an array of values.


Remove deprecated password validation rule

In #37650 the password rule was renamed to current_password with the intention of removing the old rule in the next major version. This PR removes it.
The original reasoning behind this was that later password could be used as an alias for the new Password::defaults() while I'm still supporting the idea I'm not sure whether it should be done in the next version or in a later one.
The problem with implementing it right away is that it can pass for the provided password even if it's not valid for developers who does not follow the upgrade guide. By waiting a few minor or even a major version we could prevent security issues because it would simply throw an exception.
If it should be included in this version I'm willing to create a pull request for it.

Feel free to ignore the failing PHP 8.1 tests for now.
Btw, shouldn't we update the tests to use the current_password rule instead?

The current_password rule already have the same tests at line 749

I would support aliasing the new Password::defaults() rule to password in Laravel 9.
What about adding an validation config where you can configure the Password rule?

@netpok if you rebase with master test should pass now

Rebased it
@Jubeki what do you mean by adding a validation config?

If you mean to support the old or the new behavior I'm against that, developers should just simply migrate.
If you mean to configure the default password rule you can already do that by using Password::default, adding a new config option (and file) is out of the scope for this PR.


New feature: image detection strategy "edge"

Hi,
with this pull request I want to share the work of my valued colleague @gautamilango and me.
It introduces another strategy edgeto detect images in situations when too much pixels are different and further loweringconfidence would lead to false (or no) results.
The key here is to pre-process both images (reference image and screenshot) with canny edge detection (https://scikit-image.org/).
This reduces the images to the most relevant parts before they are compared.
It makes image detection extremely rebust against

inpredictable colour nuances (example: "hover"-colors for buttons)
compression artifacts (e.g. when testing over RDP/Citrix, which compress screen information depending on the available bandwidth)
pixel deviations of dynamic image sources (e.g. map from 3rd party providers)
...

Debug Image is a helper keyword and starts a UI (written by Gautam) which gives worthful insights about

the best strategy (default oder edge),
its parameters (confidence, egde detection params),
the number of matches (unknown so far)
the match score of the best match (also unknown, done with try&error).

There is also a detailled debugger. It shows the edge detection results in oder to fine-tune the parameters.

We are already using the edge strategy successfully in production (synthetic e2e monitoring with Checkmk/Robotmk) and it works pretty well.
To make this strategy as integrated as possible, we have put a lot of effort into this, without breaking any existing functionality.
Thanks to ABRAXAS Informatik AG in Switzerland, which spent the ressources to make this possible at all!  👍
That's all for now - we are looking forward to hearing from you.
Any suggestion is highly appreciated! :-)
Best regards,
Simon
(simon.meggle at elabit.de)
PS: See also https://blog.robotmk.org/

Hi @simonmeggle,
This on the first glance seems an awesome addtition to the library!
I need to check this thoroughly which I haven't had time yet. I hope to check this in the coming weeks.

Hi Tattoo, glad to hear that you find this useful.
I understand that this is a big commit which needs to be carefully reviewed.
Take your time, I can provide you any assistance you need!

Hi Tattoo, I just want to ask if I can be of any help? Regards, Simon

I I am already looking for such a feature, as I often struggle with (nested) remote desktop connections.

This would be very useful in our environment. Hope it gets implemented soon.

Happy new year!
Is there already a timeline to implement this.
This function would be very helpful for my use cases.
Many thanks.

Is there already a timeline to implement this.
It will be implemented soon, but obviously not in this library (the pr still hangs, no one has ever reviewed it).


Autogenconfig doesn't exclude RSpec/NestedGroups

I've added this here as it feels like a core rubocop issue (not from rubocop/rspec)
When you have both a manually defined config and an autogenerated config for RSpec/NestedGroups - rubocop will always fail

Expected/Actual behavior

Create a codebase, with some rspec tests which have 5 nestings
Set .rubocop.yml to

RSpec/NestedGroups:
  Max: 4

Run rubocop --auto-gen-config
Observe the todo file contains

RSpec/NestedGroups:
  Max: 5

run rubocop
You will get failures for (I've added my OSS codebase example here)

spec/site_prism/page_spec.rb:187:9: C: RSpec/NestedGroups: Maximum example group nesting exceeded [5/4].
        context 'when validations are disabled' do
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/site_prism/page_spec.rb:206:9: C: RSpec/NestedGroups: Maximum example group nesting exceeded [5/4].
        context 'when validations are disabled' do
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Steps to reproduce the problem
You can clone the codebase at https://github.com/site-prism/site_prism Then add a manual value of 4 to the .rubocop.yml file
RuboCop version
Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:
$ [bundle exec] rubocop -V
0.73.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.8 x86_64-linux)

@koic I believe the NestedGroups is only used as an example, and the problem is not related to RuboCop RSpec. It would be easy to reproduce the same issue with, say, ModuleLength.
As far as I understand, if there's a setting in .rubocop.yml and there are offences in the codebase when a .rubocop_todo.yml gets generated with a more permissive setting, it's getting overridden by a more strict setting in .rubocop.yml.
I'm not sure if it's a problem with --auto-gen-config, and it should make sure the settings from .rubocop_todo.yml won't be overridden, or there should be a warning message given when a setting is overridden (very unlikely, since it's a common use case), or settings from .rubocop_todo.yml should take priority somehow.

Also, I think it's with the way the auto-gen works.
When auto-gen has excludes, they're ignored fine. And can be combined with a rule override.
When auto-gen has a rule override, and you provide a more recessive rule override then the issue occurs.
i.e.
# todo
CopOne/Thing
  Exclude:
    - file/a
    - file/b

combines with
# yml
CopOne/Thing
  Max: 4

BUT
# todo
CopOne/Thing
  Max: 8

DOES NOT combine with
# yml
CopOne/Thing
  Max: 4

@pirj Oops. Thanks for your explanation.


Documentation lacks pathParams details

There's no clear information in the docs on how to implement pathParams in a contract.  It should be clear that pathParams expects a zod schema - I think it'd make sense to include an example using z.coerce.number() as well.
Happy to take a swing at updating the docs w/ some guidance on where it'd make sense to include this information.
Something like:
export const contract = c.router({
  getUser: {
    method: 'GET',
    path: '/users/:id',
    pathParams: z.object({
      id: z.string()
    }),
    // ...
  }
})

// or, if the ID is a number, use zod coerce:
export const contract = c.router({
  getUser: {
    method: 'GET',
    path: '/users/:id',
    pathParams: z.object({
      id: z.coerce.number()
    }),
    // ...
  }
})

Great feedback! I think it would make sense to include this here: https://ts-rest.com/docs/core/fetch#typed-query-parameters
relevant md file: https://github.com/ts-rest/ts-rest/blob/a02ea90f5194caf657287c0ddf9d756832013bcd/apps/docs/docs/core/core.md

@michaelangeloio I wasn't exactly sure how it would fit in to the page you sent.  With #469 I added some details into the Contract page, though I'm of course open to feedback/suggestions.


Drawing Layer: Provide Settings

Tasks

[ ] possibility to choose color for shapes
[ ] possibility to choose stroke width

Use case
Drawing Layer

Thank you for creating the issue! Is filling somewhere else?


Script to automate the heroku deployment

An automated shell script might be beneficial for users who want to deploy the server with one click, e.g. as reflected in https://github.com/magpie-ea/magpie-backend/issues/99
AC:

A shell script is present to deploy the server automatically (tested on MacOS at least)

Added


sync to live (#661)

Update SoCsAndCustomBoards.md (#659)

updated NXP details

Update TOC.md (#660)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/TOC.md
:white_check_mark:Succeeded

windows-iotcore/learn-about-hardware/SoCsAndCustomBoards.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat

大佬，官网能出个简单拖拽的demo吗，不是那种交换顺序的拖拽，就是简单纯拖拽单个物体

Do you mean you want a feature to manually drag and modify the position of a DOM element? If so, you can use useDraggable from VueUse to achieve this. You can find more information about it here.


Call async_fetch_->Done after all usages.

AsyncFetch::Done will delete itself. Accessing
async_fetch_->extra_respond_headers() will crash nginx.

Was this fix included with the #834 change?

@jeffkaufman No -  see https://github.com/pagespeed/ngx_pagespeed/blob/trunk-tracking/src/ngx_fetch.cc#L467

Closing this, re-opened a modified pull to apply to the current codebase: https://github.com/pagespeed/ngx_pagespeed/pull/919


CORE-13501: First part of the rewrapWrappingKey function

This is not complete, the test does not contain assertion, but it's a good stepping stone towards creating the rewrapping function and the underlying changes for it.

As mentioned in the description, this is not complete, but it is a good stepping stone towards the rewrap function and shows the underlying changes.


Invalid occurrences for "every 2 months on the last Monday"

The following test fails:
#[test]
fn issue_YY() {
    let dates = "DTSTART;TZID=Europe/London:20231030T140000
RRULE:FREQ=MONTHLY;INTERVAL=2;BYDAY=-1MO"
        .parse::<RRuleSet>()
        .unwrap()
        .all(3)
        .dates;

        common::check_occurrences(
            &dates,
            &[
                "2023-10-30T14:00:00+00:00",
                "2023-12-25T14:00:00+00:00",
                "2024-02-26T14:00:00+00:00",
            ],
        );
}

This is the output:
Given: [
    "2023-10-30T14:00:00+00:00",
    "2023-12-25T14:00:00+00:00",
    "2024-03-25T14:00:00+00:00",
]
Expected: [
    "2023-10-30T14:00:00+00:00",
    "2023-12-25T14:00:00+00:00",
    "2024-02-26T14:00:00+00:00",
]

It seems all occurrences after crossing the year 2023/2024 are wrong.

@tomquist Really busy these days so wont be able to provide much guidance the next couple of weeks. Any help on fixing this is appreciated.  My initial suspicion is that something is off in RRuleIter::generate. Also thank you for reporting this issue!

Submitted a fix here https://github.com/fmeringdal/rust-rrule/pull/106 which resolves this issue although I'm not 100% sure it's fully correct.


HID Keyboard - space not working

Cannot set the HID Keyboard to insert a space. when coded, nothing happens.

Can you describe your hardware setup?

we are using the Jacdac HID Brain with the STM32F chip, and then a standard Jacdac button by Kittenbot.


Cloud Volumes Add/Delete/Update/Attach/Detach UI

This pull request is intended to add toolbar buttons and forms for adding, updating, and removing Cloud Volumes as well as attaching and detaching them from instances.

@dclarizio @Loicavenel Screenshots updated

@mansam I am missing the flow here are we starting from the instance or from the Volume list? What I think end-user want to do:
Regular user - Go to an instance, and Attach/Detach a volumes
Admin user - Go to list of Volumes:  create a volume, attach/detach volumes to instances
@dclarizio does all these new menu options will be automatically in RBAC or it has to be coded?

@Loicavenel It looks like @mansam has added product features, which will allow them to be chosen in the Role editor.  We may want to review the OOTB roles to see if these should be included in any of them (they may be, if they are children of already included features).

@Loicavenel It appears the screenshots showed up out of order which might have been confusing. This is starting from the Volume list or Volume Details page. I can add a flipped attach/detach interaction to Instances as well if that is desired.

@mansam Yes, from the instance that will make sense..

@dclarizio yes, we are adding new features, and these new UI options should be available at RBAC

@Loicavenel @dclarizio

@mansam @Loicavenel in the first screenshot above (the list of Instances), does the attach/detach button light up when only a single Instance is selected?  I don't know enough about this, but if it only acts on 1 instance, it might be better to only have the buttons showing on the Instance summary view and, of course, only have them enabled if they apply. (i.e. maybe some instance types we don't yet support this functionality on as well as don't enable Detach if there is no current volume attached to the Instance)  Of course, if disabled, the hover text for the button should denote why.

@dclarizio @mansam yes, I suggest to do it at the install level, I don't think multi-selection should apply here. We may have people requesting it later, then we will add it.

Those buttons only light up when a single instance is selected, and they are present on the summary views as well. I can take them off of the list view if desired.

@mansam I think you can keep it here, this is sometimes easier when you applied a filter.

Okay, cool

@dclarizio anything else you need from me on this?

@mansam I think this needs a rebase after I merged your other one.

@miq-bot add_label darga/yes

@dclarizio anything else this needs?

@mansam just passing tests :smile: . . . take a look and let me know if they are unrelated.  Thx, Dan

@dclarizio I'm not entirely certain that those failures are related to this PR. I see them even if I run the tests on master locally.

@dclarizio Looks like tests are passing again!  How does this PR look now?

Hurray! Thanks @dclarizio


SillyTavern conversion example

After creation

After I write my first message

[
    {
        "role": "system",
        "content": "Write My Char Name's next reply in a fictional chat between My Char Name and Paul. Write 1 reply only in internet RP style, italicize actions, and avoid quotation marks. Use markdown. Be proactive, creative, and drive the plot and conversation forward. Write at least 1 paragraph, up to 4. Always stay in character and avoid repetition."
    },
    {
        "role": "system",
        "content": "[Paul is a very fit 40 years old man who does marathons]"
    },
    {
        "role": "system",
        "content": "The description here"
    },
    {
        "role": "system",
        "content": "[Start a new Chat]"
    },
    {
        "role": "assistant",
        "content": "My first message"
    },
    {
        "role": "user",
        "content": "Hello!"
    }
]


Possibly incorrect implementation of Batch Renorm

I came across your implementation of batch re-normalization in the BatchReNormDNNLayer class, and I think there might be an error that might be affecting the model's performance.
My understanding of batch re-norm is that it applies the standard BN normalization first, then applies the r/d correction, and then finally applies the gamma/beta scaling and bias. Something along the lines of this:
normed_x = (x - batch_mean) / batch_std    # standard BN
normed_x = normed_x * r + d                # The batch renorm correction
normed_x = normed_x * gamma + beta         # final scale and bias

However, this line is applying the r/d correction after the scaling and centering with gamma and beta.
https://github.com/ajbrock/Neural-Photo-Editor/blob/master/layers.py#L128
It probably works anyway, based on the good results you seem to have gotten. I just thought I'd bring it to your attention.

Thanks, this is definitely a discrepancy, likely born of the fact that I threw this layer together in a couple minutes right after seeing the paper << Also because cuDNN's batchnorm does the scale+shift automatically. If you want to submit a pull request to fix it (just moving the gamma+beta outside the cuDNN bnorm call would do it) feel free, though I'm not really supporting much of the code in this repo thse days <<


tab line palette for non-focused edited tab?

palette.tabline's airline_tabmod is used to set the palette for the focused tabs that are modified (which is nice) but I'd like to also have them show up in this special color (but probably a little dimmer) if they're not selected.
No such issue exists for when tabline is in buffers mode, because you can't have a buffer be unsaved if it's not open.

this was implemented by https://github.com/bling/vim-airline/pull/595


Add API for clearing file cache on search nodes

Description

Introduces a new API to clear the file cache on search capable nodes

Sample Output  - POST /_filecache/clear
{
    "_nodes": {
        "total": 1,
        "successful": 1,
        "failed": 0
    },
    "cluster_name": "runTask",
    "nodes": {
        "cp-GjpOoRqedOuLwQCW6AQ": {
            "name": "runTask-0",
            "roles": [
                "cluster_manager",
                "data",
                "search"
            ],
            "cleared": true,
            "item_count": 6227
        }
    }
}

Issues Resolved
Resolves #6030
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #7323 (b0e8077) into main (d984f50) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

:exclamation: Current head b0e8077 differs from pull request most recent head 0664b6b. Consider uploading reports for the commit 0664b6b to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #7323      +/-   ##
============================================
- Coverage     70.71%   70.61%   -0.10%
+ Complexity    59497    59456      -41
============================================
  Files          4859     4859
  Lines        285339   285369      +30
  Branches      41133    41135       +2
============================================
- Hits         201772   201517     -255
- Misses        66965    67303     +338
+ Partials      16602    16549      -53

Impacted Files
Coverage Δ

.../main/java/org/opensearch/action/ActionModule.java
95.95% <100.00%> (ø)

.../org/opensearch/client/support/AbstractClient.java
31.33% <100.00%> (ø)

... and 460 files with indirect coverage changes

https://build.ci.opensearch.org/job/gradle-check/14640/

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':modules:lang-mustache:test'.
> Process 'Gradle Test Executor 608' finished with non-zero exit value 1
  This problem might be caused by incorrect test process configuration.
  Please refer to the test execution section in the User Manual at https://docs.gradle.org/8.1.1/userguide/java_testing.html#sec:test_execution

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':modules:ingest-common:test'.
> Process 'Gradle Test Executor 611' finished with non-zero exit value 1
  This problem might be caused by incorrect test process configuration.
  Please refer to the test execution section in the User Manual at https://docs.gradle.org/8.1.1/userguide/java_testing.html#sec:test_execution

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

Seems to be unrelated.

https://build.ci.opensearch.org/job/gradle-check/14639/

#6287

Details

Unrelated failure:
REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.action.admin.cluster.stats.ClusterStatsIT.testNodeRolesWithDataNodeLegacySettings" -Dtests.seed=5568C86430BA738A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-LY -Dtests.timezone=Atlantic/Bermuda -Druntime.java=19

org.opensearch.action.admin.cluster.stats.ClusterStatsIT > testNodeRolesWithDataNodeLegacySettings FAILED
    java.lang.IllegalArgumentException: duplicate element: [cluster_manager]
        at __randomizedtesting.SeedInfo.seed([5568C86430BA738A:7C15068B9D7AB34C]:0)
        at java.****/java.util.ImmutableCollections$Set12.<init>(ImmutableCollections.java:791)
        at java.****/java.util.Set.of(Set.java:487)
        at org.opensearch.action.admin.cluster.stats.ClusterStatsIT.testNodeRolesWithDataNodeLegacySettings(ClusterStatsIT.java:415)

#7327

Why not add this as a new case to the existing API? e.g. POST _cache/clear?file=true
https://opensearch.org/docs/latest/api-reference/index-apis/clear-index-cache/

Why not add this as a new case to the existing API? e.g. POST _cache/clear?file=true
https://opensearch.org/docs/latest/api-reference/index-apis/clear-index-cache/

I thought of that. The caveat there is that it operates on a shard level, and we want a node level request.
Also, the existing request checks for write blocks (Ref: Here) which holds true for snapshot backed indices and will need a mutual exclusion from other flags being set to make the request go through, which is also what got me to a new API.

Why not add this as a new case to the existing API? e.g. POST _cache/clear?file=true
https://opensearch.org/docs/latest/api-reference/index-apis/clear-index-cache/

I thought of that. The caveat there is that it operates on a shard level, and we want a node level request. Also, the existing request checks for write blocks (Ref: Here) which holds true for snapshot backed indices and will need a mutual exclusion from other flags being set to make the request go through, which is also what got me to a new API.

+1 to @andrross point, I understand the current limitation but the new API introduces the inconsistencies with existing _cache APIs (which actually are opaque to the level they operate on, shard/node/cluster/...). Moreover, I believe the files in cache is always associated with the backed index, having the POST /<target>/_cache/clear form would be even more useful.

Why not add this as a new case to the existing API? e.g. POST _cache/clear?file=true
https://opensearch.org/docs/latest/api-reference/index-apis/clear-index-cache/

I thought of that. The caveat there is that it operates on a shard level, and we want a node level request. Also, the existing request checks for write blocks (Ref: Here) which holds true for snapshot backed indices and will need a mutual exclusion from other flags being set to make the request go through, which is also what got me to a new API.

+1 to @andrross point, I understand the current limitation (which we could work through) but the new API introduces the inconsistencies with existing _cache APIs (which actually are opaque to the level they operate on, shard/node/cluster/...). Moreover, I believe the files in cache are always associated with the backed index, having the POST /<target>/_cache/clear form would be even more useful.

I do believe that cache and filecache are separate entities, which is also what prompted me to add in a new API along with the other reasons I mentioned before.
The ideal course of action here would be to change the cache APIs to operate at index or shard level to actually represent the action that the end user wants to perform, instead of pruning the whole cache, which is how it is implemented now. (Apart from the changes that we would need to make for the write block checks).
@reta Do you think filecache and cache should still have the same _cache endpoints given the fundamental differences in what they represent and the level they operate on?

@reta Do you think filecache and cache should still have the same _cache endpoints given the fundamental differences in what they represent and the level they operate on?

To me, the _cache API looks universal, it operates over absolutely unrelated caches (or entities) - query cache, fields data cache, file cache ... It does not mean that is the only way - but this is what we have and its important to keep API consistent.

@reta Do you think filecache and cache should still have the same _cache endpoints given the fundamental differences in what they represent and the level they operate on?

To me, the _cache API looks universal, it operates over absolutely unrelated caches (or entities) - query cache, fields data cache, file cache ... It does not mean that is the only way - but this is what we have and its important to keep API consistent.

I think that clears it up for me. Thanks @reta and @andrross!
I'll update the logic to re-use the existing endpoint.

Closing in favor of #7498


Copy control

var MySaveField = function(config) {
	jsGrid.Field.call(this, config);
};

MySaveField.prototype = new jsGrid.Field({
	css: 'save-field',
	align: "center",

	itemTemplate: function(value) {
		return this._itemButton = $("<input type=button value=Save-As id=SaveRuleAs>")
	},

	insertTemplate: function(value) {
		return this._insertButton = $("<input type=button value=Save-As id=SaveRuleAs>")
	},

	editTemplate: function(value, item) {
		return this._editButton = $("<input type=button value=Save-As id=SaveRuleAs>").on("click", function() {
			//alert("Hey, knock it off:" + item.id)
			$.ajax({
			type:'GET',
			url:'http://localhost:8000/rules/BCAAPI/' + "{{ plane_model }}" + "/" + "{{ table_type }}" + "/" + item.id + "/",
			success:function(data) {
				alert("Hey, knock it off!")

				}
			})
		})
	},

});

So I dove through the closed issues and was able to get this far. I tried calling $("#grid").jsGrid("insertItem", item) to insert a new row with the data in the current row. I see the alert message but there are no changes to the grid. Is it possible to reference the grid in which a control has been rendered and issue an insertItem grid controller message?
Braden.

@richraid21 Perhaps you know if this is possible?

I'm a bit confused as to what you want to accomplish.
You want a button on each row, that when clicked, creates a duplicate row at the top of the grid?

insertItem: function(item) {
				return $.ajax({
					type: "POST",
					url: "http://localhost:8000/rules/BCAAPI/{{ plane_model }}/{{ table_type }}/",
					data: $.extend(item.fields, { id: item.id,
							model: item.model,
							table: item.table,
							source_ip: item.source_ip,
							destination_ip: item.destination_ip,
							protocol: item.protocol,
							source_port_lo: item.source_port_lo,
							source_port_hi: item.source_port_hi,
							destination_port_lo: item.destination_port_lo,
							destination_port_hi: item.destination_port_hi,
							Pcapfile: item.Pcapfile,
							origin: item.origin,
							created: item.created,
							last_edited: item.last_edited,
							owner: item.owner,
							tailnumber: item.tailnumber,
							feature: item.feature,
							comments: item.comments})
				});

It something like a Save-As feature where a user can take a row, copy its contents, and modify it then save it.
I included the insertItem controller portion to illustrate how the grid is currently using that controller.

This might be a good starting point.

Thats really great, thank you man! Love the jsGrid!

@bradybray, thanks!
@richraid21, thank you for the great answers as usual!


Add fallback for when LBT_DEFAULT_LIBS is not set

Adding a compile-time specified fallback makes it easier to use LBT as a
drop-in replacement for any given BLAS implementation. One simply needs
to add a definition for LBT_FALLBACK_LIBS to CFLAGS at build time to
specify the fallback.

This looks good to me.

Sounds good to me; I think I also want to add the ability to get the value of default_libs from the config object now that it's getting more complicated; could be valuable when debugging.


Labels of attached boundary events don't stick to the event

When moving things around, the labels of attached boundary events get lost.

see https://app.camunda.com/jira/browse/SUPPORT-3423

Closed via https://github.com/bpmn-io/diagram-js/commit/286151c9adbcca528442e3105558fc599d754cbd


Add cyw43_spi_set_clock_divisor() to allow CYW43 to work with over/underclocked RP2040

Fixes issues #1297 and #1392
This is a straightforward patch to allow the Pico W to work with the WiFi/BT module when heavily over- or underclocked.  The previous code had the SPI clock divisor hardcoded to a value of 2, this allows the programmer to explicitly set it to any value they'd like.
In both instances, simply set the desired clock divisor PRIOR to initializing the WiFi module:
set_sys_clock_khz(48000, true);      // cyw43 init will hang or fail, see issue #1392
cyw43_spi_set_clock_divisor(1,0);   // Speed up the SPI bus so it will work
if (cyw43_arch_init_with_country(CYW43_COUNTRY_USA)) { ...

or
set_sys_clock_khz(266000, true);      // cyw43 init will fail for reasons similar to #1297
cyw43_spi_set_clock_divisor(4,0);     // Slow down the SPI bus
if (cyw43_arch_init_with_country(CYW43_COUNTRY_USA)) { ...

I guess this is similar-but-different to #1499 ?

It's similar to #1499, but having an actual SDK call means that Micropython users (and Lua, JS, etc.) aren't stuck with whatever SPI clock speed was chosen at compile time.  That patch looks like it's entirely compatible with this one and I rather like the option to do it either way.

Any updates on this? Has anyone found an alternative I could use so users don't have to edit the SDK when they want to overclock their pi pico w?

@FrankLaterza does this change work for you?

After overclocking to 400MHZ this change worked perfect for me.

Is this something that needs to be dynamic? I'd vote for making this a PICO_ define which defaults to the old values

If the system clock wasn't dynamically adjustable I'd agree that it should be a simple #define, but Micropython and other VMs expose set_system_clock_mhz to the user and need to be able to adjust the SPI clock at runtime.  Otherwise you end up with weird cases like "the Pico W works fine in Micropython when under- or overclocked, unless you want to use WiFi, in which case you'll have to rebuild the entire VM from scratch."

Your change has more or less been implemented. You need to define CYW43_PIO_CLOCK_DIV_DYNAMIC and then cyw43_set_pio_clock_divisor is available. Or else at build time you can use CYW43_PIO_CLOCK_DIV_INT and CYW43_PIO_CLOCK_DIV_FRAC. This is all in pico_cyw43_driver. There's an example here https://github.com/raspberrypi/pico-examples/blob/master/pico_w/wifi/blink/picow_blink_slow_clock.c


Fixes so that the app does not crash on iPad

This pull request hopefully gives us a working release that the iTunes team will approve for beta release, unblocking our testing!
After I updated the UI and workflow of the phone version of the app, the iPad layout was left in a bit of a broken state. This pull request updates the behaviour of the iPad app so that the app can be opened and used. I've made some design modifications to get it looking more like the phone app, but functionality-aside, design changes are out of scope for this phase of work, so I've not done more than I need to to get the app unbroken. I'm hoping to have some time this week to jump in and try and make some more improvements, as I know many families use this app on an iPad due to it's larger size and readability.

There's a BUNCH of things annoying me here that I'd like to fix (but don't affect the app working)

The blue on the search bar is  darker. There's no reason in code for it. It just is. ???
I'd like to fix the webview containing the about content to the bottom of the screen. I also wonder if it should go in the right hand column when there is no search (I think this is the 'out of scope' bit)
The layout of the main part of the screen needs some major typographical and spacing adjustments to look nicer
I'd like to put the "NZSL Dictionary" app title up the top left like the phone version has. It's going to be a bit of a positioning nightmare.

Some CI would be choice as.

Do you think we should add Raygun so we have more info on strange crashes that might get reported.

@Br3nda RE: CI and Raygun. I'd like to add these, but I'd like to get through the changes that Micky has asked for first (same goes for Android). In my experience, setting up CI for a native project is not as simple as a web application, and (especially so for iOS) I expect to need to do a lot of research and debugging in Travis before the CI would be up and running.


Add the client information to the cookies. Otherwise the login won't …

…work. (Verified on foreign phone login.)

Merged. Thanks!


Switch from lazy_static to once_cell

@GuillaumeGomez @EPashkin

Regen check fails and seems need same fix as in https://github.com/gtk-rs/gdk/pull/326