Support basic templating in server options

Add support for some basic template interpolation in the server_options field. The name, host, and port of a particular backend server are made available for insertion into a server_options block, so that a server options configuration can be supplied to synapse that will vary based on the details of a host being configured. This allows options to be set that are dependent on information coming from the service discovery backend.
In particular, this allows one to disable TLS health checks for a TLS backend by specifying check port <portnumber>, where portnumber varies depending on the backend port that has been discovered by your discovery system.
@lap1817 @juchem @Jason-Jian

LGTM


US 06.01.01

As a player, I want to see a map of geo-locations of nearby QR codes.
User story points: 5

Sunday
triet


functional attempt on spi connection recovery

#159  👈 (View in Graphite)
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.


Mm/goblin prover polynomials folding

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

batch_insert_into_append_only_tree_16_depth_ms (2): 19.1 (+79%)
circuit_simulation_time_in_ms (private-kernel-init): 213 (-32%)
circuit_simulation_time_in_ms (private-kernel-inner): 293 (-31%)
tx_pxe_processing_time_ms (0): 379 (-25%)
tx_pxe_processing_time_ms (1): 1,089 (-20%)
node_history_sync_time_in_ms (5): 16,249 (+20%)
node_history_sync_time_in_ms (10): 30,866 (+21%)
node_database_size_in_bytes (5): 3,513,063 (-80%)
node_database_size_in_bytes (10): 3,554,301 (-89%)
l2_block_processing_time_in_ms (8): 1,473 (+28%)
l2_block_processing_time_in_ms (32): 5,434 (+24%)
l2_block_processing_time_in_ms (128): 21,263 (+23%)
note_successful_decrypting_time_in_ms (8): 373 (+39%)
note_trial_decrypting_time_in_ms (32): 88.5 (+149%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 6e1d958b and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,412
179,524
716,068

l1_rollup_calldata_gas
221,632
866,860
3,446,776

l1_rollup_execution_gas
314,051
984,532
3,666,365

l2_block_processing_time_in_ms
:warning: 1,473 (+28%)
:warning: 5,434 (+24%)
:warning: 21,263 (+23%)

note_successful_decrypting_time_in_ms
:warning: 373 (+39%)
961 (+6%)
3,711 (+7%)

note_trial_decrypting_time_in_ms
85.2 (+11%)
:warning: 88.5 (+149%)
146 (+2%)

l2_block_building_time_in_ms
16,203 (-10%)
64,342 (-10%)
257,134 (-10%)

l2_block_rollup_simulation_time_in_ms
11,772 (-9%)
46,864 (-9%)
187,647 (-9%)

l2_block_public_tx_process_time_in_ms
4,393 (-13%)
17,386 (-14%)
69,191 (-13%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
:warning: 16,249 (+20%)
:warning: 30,866 (+21%)

note_history_successful_decrypting_time_in_ms
2,180 (-13%)
4,252 (-4%)

note_history_trial_decrypting_time_in_ms
114 (+14%)
186 (-8%)

node_database_size_in_bytes
:warning: 3,513,063 (-80%)
:warning: 3,554,301 (-89%)

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
:warning: 213 (-32%)
44,681
25,561 (-2%)

private-kernel-ordering
166 (-14%)
43,753 (-2%)
14,809 (-1%)

base-rollup
1,193 (-14%)
128,338
881

root-rollup
79.2 (-3%)
4,088
677

private-kernel-inner
:warning: 293 (-31%)
71,208 (-1%)
25,561 (-2%)

public-kernel-private-input
206 (-14%)
31,863 (-2%)
25,561 (-2%)

public-kernel-non-first-iteration
203 (-15%)
31,905 (-2%)
25,561 (-2%)

merge-rollup
7.70 (+1%)
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455 (-1%)
32,219 (-12%)

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
:warning: 379 (-25%)
:warning: 1,089 (-20%)

Metric
1 public data writes

tx_sequencer_processing_time_ms
537 (-14%)


Feature Request: flow-upgrade with tabs instead of spaces

It would be great if flow-upgrade codemods could respect projects that use tabs instead of spaces.

Closing since flow-upgrade will only do best attempt format preservation. If you really care about format, you should use prettier.


2 problems for bookmarks

ugly font for bookmarks in Chinese
toggle "bookmarks bar" not always work (not always reproducable)

a new version is on building now

a new version is on building now

Same issue in chrome.
Will probably be fixed in 124.
https://www.theverge.com/2024/3/25/24111273/microsoft-google-chrome-text-rendering-improvements

The font problem haven't been solved in the most recent version 123.0.6312.86-1.1
Wait for version 124


[Synapse] Duplicate definition names

In https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/entityTypes/Trigger.json#L338
    "BlobEventTypes": {
      "type": "array",
      "items": {
        "type": "string",
        "enum": [
          "Microsoft.Storage.BlobCreated",
          "Microsoft.Storage.BlobDeleted"
        ],
        "x-ms-enum": {
          "name": "BlobEventTypes",
          "modelAsString": true
        }
      },
      "description": "Blob event types."
    },

The Enum name is defined as BlobEventTypes, but the top level schema name is also defined as BlobEventTypes. We need to rename either one to resolve the conflict in AutoRest.

hi @idear1203 could you pls have a look at the issue?

Fixed in https://github.com/Azure/azure-rest-api-specs/pull/11864


Update Carousel.svelte so one can apply custom styles

I am making this change to make it possible to give the carousel some background color and border-radius, I assume that can be a feature that many can use.

Hello @andishehk
Thanks for using the component.
The idea was not to pass styles via props, but using css class names prefixed by sc, e.g. sc-carousel__carousel-container.
Otherwise it would be need to pass such style props for each and every piece of the carousel...

Hello @andishehk Thanks for using the component. The idea was not to pass styles via props, but using css class names prefixed by sc, e.g. sc-carousel__carousel-container for customization. Otherwise it would be need to pass such style props for each and every piece of the carousel...

Many thanks @vadimkorr for your response, you're right, we can do that as well. Thank you for the very useful component. I am also trying to see if I can make it show half of the last item, when hiding arrows, so it is more obvious that it has more items, in that case. Haven't spent much time on that yet.


Poedit after draft translation of lines shows a different number of lines

The Poedit after draft translation of lines shows a different number of lines. I noticed this after the last update. I have the current version: 2.3 (PRO)
Screenshot: http://prntscr.com/r0v1vn

Some strings were pre-translated twice (once from your local TM, once online with a better match).
Closing as it doesn't affect the OSS version this tracker is for.


[Feature] Ability to provide custom CA Certificate

libcurl provides a way to specify a CA bundle used for requests (CURLOPT_CAINFO). Currently, this is being used to provide a base CA bundle for Windows and Linux, but a user-supplied bundle could be concatenated to this fairly easily.
To-Do

Add setting to workspace settings to import a custom CA bundle (PEM format)
Add logic to concatenate user-supplied bundle to base bundle (if Windows or Linux). On Mac, simply provide user-supplied bundle

Unknowns
Since Curl retrieve the base CA bundle from the OS on Mac, it's unclear whether or not setting CURLOPT_CAINFO will override this bundle entirely or add to it. This needs to be tested.

Providing a CA on a per environment or per request basis might provide better flexibility than per workspace. For example talking to Kubernetes API and providing the cert to validate with.

This is something I'd be very interested in having. I'd love to give a PR a try.

@aaron-trout I agree that it's more flexible but I don't think the use case for a global CA cert is much more common. If we see enough desire to add per-request CA certs later, we can come up with a mechanism to do so.
@coderjoe are you still wanting to give this a try? It might end up being quite a bit of work but I'm happy to point you in the right direction. I'm picturing a new tab in the workspace setting (beside Client Certificates) to upload additional CA certificates.

@gschier absolutely still interested. I'll likely need help with testing on Mac OSX as I only have Linux and Windows machines.

Sure, I could definitely help test that out :smile:

Sorry for the delay. I very much appreciate the guidance/suggestions. If I run into any snags or questions I'll be sure to ask here.

Nice! 👍 😄

As is probably obvious by lack of commits, I ran into some snags and haven't had time to come back to this issue. If anybody else wants to give it a whack please feel free. I have no significant progress to share at this time.
I am still interested in the feature, it just isn't really a critical feature for me anymore. Maybe I'll have time later this year to revisit it.

Just had the issue with our internal root CA. Would be nice to make this work.

Another +1, I cannot use this without this functionality.

Hi @lsuttle, there is a PR currently open but is blocked on testing and validating the new functionality (https://github.com/Kong/insomnia/pull/2020#issuecomment-630466618). Is this something you may be able to help with? If so, I can prepare a bundle to install on your OS.

I could help with validation. I'm on elementary OS 5.1.5 (like Ubuntu Precise) and I'm using mkcert as my local CA for API testing. If you can provide a bundle I'd be happy to try it with that configuration.

Sure I can give it a try, I have most recent Windows 10 install.

Hi, is this still in consideration? Thanks! :)

Still relevant, please leave open =D

Yis! Mistakenly marked as stale 😞

Woohooo, feature accepted! Thanks! 🥳


Remove connection box from rr-graph patching.

Here is a spreadsheet with the results for 50/100T and 200T: results
They look good in general, with the biggest tests having better QoR in average.
(Note that the t_crit_geomean metric is a more robust indicator of CPD, as it might happen that a different clock CPD gets displayed in t_crit


feat: Adding new slogan

Fixes Issue
Closes #2217
Relates to #2173

Changes proposed
This PR does the following:

[x] add LinksHub's new slogan to the README.
[ ] add the new slogan to the design.

Screenshots

Note to reviewers
This is still a work-in-progress. Also, the second checkbox will be addressed once the new design for the Welcome page is merged

Going to do a new one once the home design is merged


python312Packages.busylight-for-humans: init at 0.28.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

Could you also utilize busylight udev-rules to generate these udev Rules and provide it from this package?


readme: see also

Added Related Link in README.md

I've also contacted him, and he is considering it. You can read the issue


[DevOps Center] Merge WI-000001 to Integration

DevOps Center created this pull request. It will be merged automatically upon promotion in DevOps Center. If you merge it outside of DevOps Center, DevOps Center provides you the option to deploy the changes to complete the promotion.

ok for merge


YJIT-Metrics CI Benchmarking: Benchmark at 2021-12-24-071114 is significantly slower than the one before (2021-12-23-191111)!

Error running benchmark CI job on Linux ip-172-31-8-3 5.8.0-1038-aws #40~20.04.1-Ubuntu SMP Thu Jun 17 13:25:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux:

Latest failing benchmark: blog_speed_details_2021-12-24-071114.tripwires.json
Compared to previous benchmark: blog_speed_details_2021-12-23-191111.tripwires.json

Failing benchmark names: ["liquid-render"]

Failure details:

[
  {
    "benchmark": "liquid-render",
    "current_mean":<PHONE_NUMBER>6589457,
    "second_current_mean":<PHONE_NUMBER>8641787,
    "current_stddev": 2.3083296253975933,
    "current_rsd_pct": 1.7952882332990883,
    "second_current_stddev": 2.4828033769779254,
    "second_current_rsd_pct": 2.1535922347294765
  }
]

Test issue - disregard


docs: improve examples

With updated examples, it would be easier to write the sigsci terraform configs. I did run into some parallelism issue when destroying the resources.

looks like no interest for this PR, closing it now.


Add tracing and debugging support

Added tracing support for local and cloud
Added debugging for front and backend
Updated Bicep deployment
Update requirments.txt
Updated corresponding docs
TODO: Remove custom packages after the AI packages are public

Hi @sudivate, is this ready for review?

@marlenezw  Yes


Bad Gateway upon fresh deployment

Hi there,
On my AWX on K3S deployment, I get a "Bad Gateway" same as described here in issue #10. Can you please give me some pointer how may I go about troubleshooting this?
Environment

OS: Open SUSE 15.3
k3s version v1.22.6+k3s1 (3228d9cb)
go version go1.16.10
AWX Operation version 0.14.0

Issue Description
I'm able to start all of the pods:
awx-nathan:~ # kubectl -n awx get all,ingress,awx
NAME                                                   READY   STATUS    RESTARTS         AGE
pod/awx-postgres-0                                     1/1     Running   0                141m
pod/awx-operator-controller-manager-68d787cfbd-2jlsf   2/2     Running   0                144m
pod/awx-b85cd74b6-l4zn4                                4/4     Running   20 (6m49s ago)   140m

NAME                                                      TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
service/awx-operator-controller-manager-metrics-service   ClusterIP   <IP_ADDRESS>   <none>        8443/TCP   149m
service/awx-postgres                                      ClusterIP   None            <none>        5432/TCP   141m
service/awx-service                                       ClusterIP   <IP_ADDRESS>    <none>        80/TCP     140m

NAME                                              READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/awx-operator-controller-manager   1/1     1            1           149m
deployment.apps/awx                               1/1     1            1           140m

NAME                                                         DESIRED   CURRENT   READY   AGE
replicaset.apps/awx-operator-controller-manager-68d787cfbd   1         1         1       149m
replicaset.apps/awx-b85cd74b6                                1         1         1       140m

NAME                            READY   AGE
statefulset.apps/awx-postgres   1/1     141m

NAME                                    CLASS    HOSTS            ADDRESS         PORTS     AGE
ingress.networking.k8s.io/awx-ingress   <none>   awx-nathan.com   <IP_ADDRESS>   80, 443   140m

NAME                      AGE
awx.awx.ansible.com/awx   141m

But when I try to access the AWX GUI, I get a "Bad Gateway error":

Any pointer would be really appreciated! Thanks.

Thanks @kurokobo. It seems to be due to database migration. I will continue to look into this. Thanks.
awx-nathan:~ # kubectl -n awx logs deployments/awx -c awx-web -f
[wait-for-migrations] Waiting for database migrations...
[wait-for-migrations] Attempt 1 of 30
[wait-for-migrations] Waiting 0.5 seconds before next attempt
[wait-for-migrations] Attempt 2 of 30
[wait-for-migrations] Waiting 1 seconds before next attempt
[wait-for-migrations] Attempt 3 of 30
[wait-for-migrations] Waiting 2 seconds before next attempt
[wait-for-migrations] Attempt 4 of 30
[wait-for-migrations] Waiting 4 seconds before next attempt
[wait-for-migrations] Attempt 5 of 30
[wait-for-migrations] Waiting 8 seconds before next attempt
[wait-for-migrations] Attempt 6 of 30
[wait-for-migrations] Waiting 16 seconds before next attempt
[wait-for-migrations] Attempt 7 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 8 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 9 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 10 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 11 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 12 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 13 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 14 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 15 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 16 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 17 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 18 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 19 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 20 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 21 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 22 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 23 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 24 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 25 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 26 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 27 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 28 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 29 of 30
[wait-for-migrations] Waiting 30 seconds before next attempt
[wait-for-migrations] Attempt 30 of 30
[wait-for-migrations] ERROR: Database migrations not applied

So you should check the logs of PostgreSQL too.
kubectl -n awx logs statefulset/awx-postgres

Just F.Y.I., as of my past experience, there are several possibilities:

DB issue

Something has occured on DB side.
Check the logs of PostgreSQL pod.

Firewall issue

Firewall might block communication between AWX and PSQL.
Disable any kind of firewall on your K3s host, like firewalld or SuSEfirewall2.

K3s issue

Very rarely, internal network in K3s might be broken and block something.
Try uninstall and reinstall K3s.

Thank you for your tips @kurokobo.  It's super helpful. Turned out it's the K3S host firewall that's giving me grief. Once firewallD disabled, I do not get the Bad Gateway error anymore.
On a separate note, can I pick your brain a bit on the following error from the postgres pod logs?
2022-03-02 17:53:51.376 UTC [1356] ERROR:  relation "conf_setting" does not exist at character 158
2022-03-02 17:53:51.376 UTC [1356] STATEMENT:  SELECT "conf_setting"."id", "conf_setting"."created", "conf_setting"."modified", "conf_setting"."key", "conf_setting"."value", "conf_setting"."user_id" FROM "conf_setting" WHERE ("conf_setting"."key" = 'OAUTH2_PROVIDER' AND "conf_setting"."user_id" IS NULL) ORDER BY "conf_setting"."id" ASC  LIMIT 1

It doesn't seem to be giving me any issue. My postgres pod has been up for 20+ hours with no restarts. I'm reading through the issue threads in the AWX repo but have not yet gotten to any conclusion yet. Thank you, and I promise will close this issue after this. Thanks a bunch!

@nathanlin24
I've double checked that the same errors on my environment. I haven't digged into this error in details, but this seems can be safely ignored at this time if it works well.

Thank you for your tips @kurokobo. It's super helpful. Turned out it's the K3S host firewall that's giving me grief. Once firewallD disabled, I do not get the Bad Gateway error anymore.
On a separate note, can I pick your brain a bit on the following error from the postgres pod logs?
2022-03-02 17:53:51.376 UTC [1356] ERROR:  relation "conf_setting" does not exist at character 158
2022-03-02 17:53:51.376 UTC [1356] STATEMENT:  SELECT "conf_setting"."id", "conf_setting"."created", "conf_setting"."modified", "conf_setting"."key", "conf_setting"."value", "conf_setting"."user_id" FROM "conf_setting" WHERE ("conf_setting"."key" = 'OAUTH2_PROVIDER' AND "conf_setting"."user_id" IS NULL) ORDER BY "conf_setting"."id" ASC  LIMIT 1

It doesn't seem to be giving me any issue. My postgres pod has been up for 20+ hours with no restarts. I'm reading through the issue threads in the AWX repo but have not yet gotten to any conclusion yet. I promise will close this issue after this. Thanks a bunch!

Faced the same issue, thanks for the advice!

Thanks for your feedback @kurokobo!


Usernames on a shared instance must be unique

Users are not database specific, they are RDS instance specific. On a shared instance, custom usernames need to be scoped to the database, possibly by adding a prefix. Unfortunately, mysql has a 16 character username limit. Some solution needs to be found for this and implemented.

So we don't actually have to have custom usernames for mysql. We only need them to get around postgres permissions. So we could say;

Custom usernames are only allowed for postgres
On a shared instance, the custom username is prefixed by the instance GUID
MySQL usernames are always random and 16 characters long


Integrate Account Creation Flow

⚠ This PR checkout from PR https://github.com/webb-tools/webb-dapp/pull/683. Please review that PR first, thank you.
Summary of changes

Integrate the account creation flow

Reference issue to close (if applicable)

Closes NaN

Code Checklist

[x] Tested
[x] Documented

Screen Recording
https://user-images.githubusercontent.com/60747384/200834591-7817ad52-8e50-493e-ba73-66c8aacd4bd6.mp4

LGTM although this PR also has the wrong Webb logo orientation. Please address accordingly and resolve conflicts.

The icons issue is resolved here in the latest PR that I opened @dutterbutter.


Rework schema definitions

Reviewers will probably want to read the following description, and then go through the changes commit-by-commit.
Schemas were previously defined for each document type by essentially
writing the elasticsearch mapping for the field, and adding a few additional
properties to it using a "details" hash.
This had several shortcomings:

it was possible for fields with the same name to be defined in
different ways in different document types.  This makes it awkward to
implement, eg, faceting across all document types.

it was awkward to change the elasticsearch configuration for a
particular type of field, eg, searchable text fields, since we need
to change the configuration in all places.  This makes it hard to implement
better support for synonyms, for example.

any non-elasticsearch configuration, such as the allowed values for a
field, needed to be separated out from the elasticsearch
configuration in order to set the schema.

elasticsearch configuration was being cut-and-pasted when defining
new fields, resulting in invalid configurations being created.  For
example, we had several date fields defined with a index property
with a value of analyzed - but this value is only valid for string
fields.  Keeping the elasticsearch configuration in one place makes
would make it easier to audit that it is being defined correctly.

Instead the schema definitions now split the elasticsearch configuration
from other metadata, and define the type of each field in only one
place.  This is done by splitting schemas into three pieces (each
defined in JSON files):

A field_types file which defines some named types to be used when
defining fields.  These types contain all the elasticsearch
configuration to be used for the field as a property (es_config),
but also contain information on other application-level things such
as whether the field is allowed to have multiple values.  They also
contain a description property, which is a comment field,
describing what the type is indended to be used for.

A field_definitions file which defines the actual named fields
being used in the search index - tying field names to the types
defined in the field_types file.  This ensures that there is only
one definition for each field name.

JSON files for each format (and core.json for fields which exist in
all formats) which define which fields are used by each document
type.  These files can also define the values which are allowed to be
taken by a named field in documents of a particular type.

JSON files for each index, defining which field types are allowed in that index.

Changing the schema in this way has been discussed several times, but
the motivation for doing it now is:

To improve our synonym support, we'll need to modify the index-time
configuration of searchable text fields, and this will be easier if
the schema definitions allow us to change how all searchable text
fields are indexed in a single place.

Migrating to elasticsearch 1.x requires us to define in some way
which fields should return array values, in order to retain API
compatibility in return values (and in order to provide reasonably
easy to work with return values).  Adding this information to the
schemas as they were defined would have made it more awkward to
rework the schemas in future.  In this new scheme, it is simply
necessary to define a field type with the multivalued property set to
true, and use that field type for the appropriately named field.

In order for this rework to be useful, the "government" index is now
included in the "JSON" style schemas.  Previously, it had been left
hard-coded in the elasticsearch_schema.yml file.
One other change which this schema change requires is to index all
date fields for sorting and filtering.  This change is simply for
convenience; indexing all the date fields for searching will use slightly
more index space, but very few extra resources unless they're being
used.
No changes should happen to the public API of rummager as a result of
these schema changes.

Needs a rebase (probably because of #368)

:+1: Looks good to me.


Error Processing mzml files from msconverted bruker timstof .baf file

Howdy all,
I am having some errors processing .mzml data converted from bruker .baf files.
the error I get no matter what task I run is:
Run failed, Exception: Object reference not set to an instance of an object.
I have attached the output files and can send the .mzml and .baf file if needed.
Thanks!
-Conor
2022-03-03-12-42-04.zip

also to note, I have attempted this by exporting to .mzml using Bruker's software and I am getting the same issue.

Hi Conor,
We noticed this issue of searching converted Bruker mzML for a while. We don't have a perfect solution yet. But great thanks to MSFragger friends, they figure out a way to convert the format please check it here see if it works: Convert .d to mzml (https://fragpipe.nesvilab.org/docs/tutorial_convert.html)
Best,
Lei


i love you

very nice software thank you

could add more info for files description for results of search?  Is it possible to make the program non-interactive? So one command of soulseek-cli search song   to return in terminal and end program? Rather than it go into a "pick file" prompt. Seperate commands, search/download ?

Ok, managed to make it fit my use case better, but as a feature request: Could you add more information from the search results? Like bit-rate, song duration?

Hello, thanks for the love message! :smiley:
I added some extra information in the latest release (0.0.17): average speed, folder size and bitrate. I don't have the info on song duration, so I can't display it.
For the non interactive version, I don't think it could work since the first result can be very far away from what you want to get. IMO, it needs human control.

Since the new version I'm unable to install. I tested across two different systems (my laptop and desktop) the errors are the same across both.
`/usr/local/bin/soulseek -> /usr/local/lib/node_modules/soulseek-cli/cli.js

<EMAIL_ADDRESS>install /usr/local/lib/node_modules/soulseek-cli/node_modules/keytar
prebuild-install || npm run build

prebuild-install WARN install EACCES: permission denied, access '/root/.npm'
npm ERR! code EACCES
npm ERR! syscall scandir
npm ERR! path /root/.npm/_logs
npm ERR! errno -13
npm ERR!
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR!
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 65534:1000 "/root/.npm"
glob error [Error: EACCES: permission denied, scandir '/root/.npm/_logs'] {
errno: -13,
code: 'EACCES',
syscall: 'scandir',
path: '/root/.npm/_logs'
}

<EMAIL_ADDRESS>build /usr/local/lib/node_modules/soulseek-cli/node_modules/keytar
node-gyp rebuild

gyp WARN EACCES current user ("nobody") does not have permission to access the dev dir "/root/.cache/node-gyp/14.15.4"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/usr/local/lib/node_modules/soulseek-cli/node_modules/keytar/.node-gyp"
gyp WARN install got an error, rolling back install
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/soulseek-cli/node_modules/keytar/.node-gyp'
gyp ERR! System Linux 5.10.14-200.fc33.x86_64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/soulseek-cli/node_modules/keytar
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! code ELIFECYCLE
npm ERR! errno 243
npm ERR<EMAIL_ADDRESS>install: prebuild-install || npm run build
npm ERR! Exit status 243
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-02-15T05_01_55_307Z-debug.log`
relevant bits from the debug.logs
2841 silly install<EMAIL_ADDRESS>2842 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>2843 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle false 2844 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/usr/local/lib/node_modules/soulseek-cli/node_modules/keytar/node_modules/.bin:/usr/local/lib/node_modules/soulseek-cli/node_modules/.bin:/usr/local/lib/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/var/lib/snapd/snap/bin 2845 verbose lifecycle<EMAIL_ADDRESS>CWD: /usr/local/lib/node_modules/soulseek-cli/node_modules/keytar 2846 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'prebuild-install || npm run build' ] 2847 silly lifecycle<EMAIL_ADDRESS>Returned: code: 243  signal: null 2848 info lifecycle<EMAIL_ADDRESS>Failed to exec install script
I agree that in most cases you would want user control, but currently my goals are to have something that can automatically download spotify playlists via soulseek. Currently I have spotify playlists converted to a .txt with Artist - Title on each line, then shell script and your program to pass those lines into search queries and download the 1st result. But often the downloads would be in low bit-rate, now that bit-rate is specified in the search results I think I can have a good auto .flac downloader for large playlists.
But if you could make instructions on how to compile from source I could try to add that natively in the program and merge. I have not developed node before but my pursuit of free music is a strong driver :P

Since the new version I'm unable to install. I tested across two different systems (my laptop and desktop) the errors are the same across both.
/usr/local/bin/soulseek -> /usr/local/lib/node_modules/soulseek-cli/cli.js

><EMAIL_ADDRESS>install /usr/local/lib/node_modules/soulseek-cli/node_modules/keytar
> prebuild-install || npm run build

prebuild-install WARN install EACCES: permission denied, access '/root/.npm'
npm ERR! code EACCES
npm ERR! syscall scandir
npm ERR! path /root/.npm/_logs
...

It looks like a permission issue on your side, are you trying to install soulseek-cli as root?

I agree that in most cases you would want user control, but currently my goals are to have something that can automatically download spotify playlists via soulseek. Currently I have spotify playlists converted to a .txt with Artist - Title on each line, then shell script and your program to pass those lines into search queries and download the 1st result. But often the downloads would be in low bit-rate, now that bit-rate is specified in the search results I think I can have a good auto .flac downloader for large playlists.
But if you could make instructions on how to compile from source I could try to add that natively in the program and merge. I have not developed node before but my pursuit of free music is a strong driver :P

For now, soulseek-cli is filtering everything that is not a mp3, but I guess I could make a flac mode. Also, you could already filter by bitrate (--quality=320 for example)
Please see CONTRIBUTING.md for instructions on how to develop your own features.

Update: I added a mode option to choose if you want mp3 or flac. Please see the updated README for more info (version 0.0.18 has been published)

In my experience the quality filter did not work (but from prev version), I had it set to 320 and would result with many 128 & 192 rips.
The errors I supplied earlier were ran under a root account. Thursday I will have time to troubleshoot.
Again thank you for the very nice software, was pulling my hair out trying to get museek to work before I found this

In my experience the quality filter did not work (but from prev version), I had it set to 320 and would result with many 128 & 192 rips.

Good catch, I just fixed the quality filter (available in the new version 0.0.19).

The errors I supplied earlier were ran under a root account. Thursday I will have time to troubleshoot.
Again thank you for the very nice software, was pulling my hair out trying to get museek to work before I found this

Thanks a lot!

Closing this issue for now, I'll be happy to review your PR once you'll add your feature. Thanks again!

came here to also share the love


Implementation of CI/CD in .NET application Using Shell Executor on GitLab

Proposed title of article
Implementation of CI/CD in .NET application Using Shell Executor on GitLab
Introduction paragraph (2-3 paragraphs):
Shell Executor is a very simple executor which helps to build the solution locally on the machine, where GitLab Runner is installed. However, it also helps to run Bash and Windows PowerShell scripts and Windows Batch is deprecated. There will be a few requirements and path configuration need to set up GitLab Runner in Shell Executor mode and start implementation on it.
In this article, the reader will understand all processes involved in implementing CI and CD in .NET application.
Key takeaways:
The following are the key takeaways:

what shell executor is.
requirements specifications.
path configuration.
Gitlab runner setup.
Windows GitLab Runner Command

References:
N/A

@djayjames
Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it. 🚀

What do you think of this topic? @louisefindlay23  I'm not familiar with the topic.

What do you think of this topic? @louisefindlay23  I'm not familiar with the topic.

Hi, @ahmadmardeni1. I'm afraid I don't have experience with these areas either. Perhaps someone in the list-of-peer-reviewers doc does?

Please let me know your thoughts if you have experience with the topic.
@srishilesh @zolomohan @mbaabuones

@ahmadmardeni1 Thanks for pinging me.
I don't have experience working with GitLab or .NET. But, based on what I've looked out on the internet, I found very similar articles to this topic:

Article on GFG
Article on Medium

@djayjames How is your article different from the above two articles?
Also, I find one such similar article at Section - Implementing CI/CD using GitLab for Java app. Probably, @kayere could help us in the approval, since he has already reviewed one such article.
Thanks.

Please let me know your thoughts if you have experience with the topic.
@srishilesh @zolomohan @mbaabuones

@ahmadmardeni1 Im not familiar with this topic.

Hello @srishilesh and @ahmadmardeni1  I have looked at the topic you suggested.
I have noticed that those articles do not give a beginner the guide and knowledge to create the .gitlab-ci.yml files . For example, the first suggestion you gave, prompt the reader to copy-paste the file which is not beginner-friendly. In my article, I will let the reader know how to create the .YML file step by step. Also I will show the reader  how to install GitLab runners, register that runner, disabling shared runners and then how to auto deploy from GitLab to the server.

Good topic @djayjames - approved. One important note: please be sure to put your article through a thorough grammar/readability editing review prior to submitting for final approval. This will help increase the likelihood of your article getting published.


Slack integrations

Push build errors into a separate channel of the SWT2-2016 Slack.

Should publish errors to #errbit Slack channel of swt2-2016


add yarn max allocation per heatbeat

adapt this patch to 2.9.0 to fix #2364 : https://issues.apache.org/jira/browse/YARN-8896

Coverage remained the same at 52.647% when pulling e037ee56ce8d3bcd12d9f867cacf31ec04302d1a on zimiao/add_maxallocation_perheatbeat into 0f80208482eade027af88c61b4d58b78bf39b57a on master.

Coverage remained the same at 52.647% when pulling e037ee56ce8d3bcd12d9f867cacf31ec04302d1a on zimiao/add_maxallocation_perheatbeat into 0f80208482eade027af88c61b4d58b78bf39b57a on master.

@fanyangCS
Can't reproduce, but our scheduler get stuck in the same loop, so this workaround should work.


nullptr is undefined

k4a_device_t device = nullptr;
Please add documentation on the resolution.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50f08064-28da-6415-1e57-858760b31c64
Version Independent ID: ff491440-06d2-b9a0-12d0-deb3d1a68b6c
Content: Quickstart - Build your first Azure Kinect body tracking application
Content Source: articles/kinect-dk/build-first-body-app.md
Product: kinect-dk
GitHub Login: @qm13
Microsoft Alias: quentinm

@Shri-Humrudha Thank you for your feedback . We will investigate and update the thread further.

@Shri-Humrudha Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@Shri-Humrudha please see the PR where the sample application has been modified.

@Shri-Humrudha Can you please confirm that your feedback has been addressed?

Since we haven't heard back from you. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


add 17 tld (app, asia, best, bond, cat, click, cloud, fit, icu, kiwi,…

… ovh, red, shop, top, vip, win, xin)

beautiful thanks


wasm: improve error message when wasm file is not supplied

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
O111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/greg/.cache/go-build"
GOENV="/home/greg/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/greg/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/greg/wasmbrowsertest/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build552182410=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Tried running a WASM binary with wasm_exec.js but didn't properly supply a .wasm file, or perhaps some other error happened. The specifics aren't important - I've seen this error a couple different ways when I did something wrong.
I saw this:

TypeError: Cannot read property 'exports' of undefined
at global.Go.run (http://localhost:49700/wasm_exec.js:439:40)
at http://localhost:49700/:59:13

Which was a bit baffling the first time I read it until I poked around.
I want to see this:
wasm instance was not supplied to go.run
or a similar error message.
You can get this effect by modifying wasm_exec.js a bit:
// existing code before here...
async run(instance) {
    if (instance == null) {
        throw new Error("wasm instance was not supplied to go.run")
    }
// existing code continues...

I believe this is the only public function in wasm_exec.js where someone might conceivably run into an error and have no real understanding of how Javascript works since the other functions in wasm_exec.js seem rather low-level.

/cc @neelance

I think this should be handled in wasmbrowsertest rather than inside the run function. I checked the code and the error paths can be improved to show a better error for cases like these.
If you use the node runner, then you don't get an error like this. So I think it falls on wasmbrowsertest to handle this case.

I saw this before I ever used wasmbrowsertest, when I was messing around with index.html to switch it from clicking a 'Run' button to starting on window load / from the instantiatestreaming callback. I'll have to modify it again when I start messing with service workers in earnest.
My point is people who actually use index.html in a real application aren't going to have a run button and will definitely modify index.html's code which calls into wasm_exec.js. Once they do that their index.html is going to start to look nothing like the current index.html. Presumably the plan is for such apps to continue to use wasm_exec.js unmodified to make it easier to take changes from the Go repo. When such apps do so, I think it's reasonable to expect wasm_exec.js to throw exceptions when you use its public APIs incorrectly instead of throwing errors which require devs to read and understand wasm_exec.js's code.

Please keep in mind that wasm_exec.js's API is not fully "public" until js/wasm is stable. Right now it is meant for early adopters and can change at any time. However, I agree with you that a better error message can ease this pitfall at almost zero cost. I'll add it in the next release cycle.

Once they do that their index.html is going to start to look nothing like the current index.html.

Ah yes, that's a good point.


suggestion: set extra data

I'd like to remove files after upload. For that, it would be good to put values before start the service and to get them at the handler afterwards.

In the projects where I use the library, I needed also to associate
additional data to upload requests, but instead of carrying around extra
data in and out of the service, which personally I think it's not a good
practice, I just made a class with static methods to set and retrieve
additional data based on the UploadID. Maybe you need the same thing, too.
Il 23/nov/2015 08:07 PM, "YoungjaeKim"<EMAIL_ADDRESS>ha
scritto:

I'd like to remove files after upload. For that, it would be good to put
values before start the service and to get them at the handler afterwards.
—
Reply to this email directly or view it on GitHub
https://github.com/alexbbb/android-upload-service/issues/58.

@alexbbb  thanks for the reply. Then, how can I get UploadID before request.startUpload();? This could be the only one that I can treat before/after job tracking.

@YoungjaeKim you set the UploadID in the constructor of the upload request. It can be whatever string you like. Usually I use UUID4 so I'm sure every UploadID is unique. Check the example: https://github.com/alexbbb/android-upload-service#http-multipart-upload-example

OMG. sorry to bother you. I missed that.


Simplify and break out contributor guidance

Simplify and break out contributor guidance - reduce the noise and break into tasks with links to seperate pages

This is now done


maximum size of user id is magic number

Currently, there is not defined constant, so the maximum size of a user id is magic number.
It is just only described in parameter description of FaceAuthenticator::Enroll().

Max user id size is 15 bytes (max total of 16 bytes including the terminating zero byte).

I think it should be defined as constant in RealSense ID SDK.
namespace rsid
{
    constexpr int32_t MAX_USERID_LENGTH = 16; // add define constant of this proposal
}

// e.g. How to use constant in RealSenseID::FaceAuthenticator::QueryUserIds()
char** user_ids = new char*[number_of_users];
for (unsigned i = 0; i < number_of_users; i++){
    user_ids[i] = new char[rsid::MAX_USERID_LENGTH]; // use constant for pre-allocate output memory
}
authenticator->QueryUserIds( reinterpret_cast<char**>( user_ids.data() ), number_of_users );

BTW, I think this API is not very user-friendly. I think RealSenseID::FaceAuthenticator::QueryUserIds() should create an new API that takes std::vecotrstd::string& as an output argument. I think it is usefull allocate memory for output inside api. And, It will be automatically released, because it is vecotor container and string. It's give safe for user.
std::vecotr<std::string> uder_ids;
authenticator->QueryUserIds( user_ids, number_of_users );

Of course, I know we can do something similar with current version. However, It is a little less than smart.
std::vector<std::vector<char>> user_ids( number_of_users, std::vector<char>( rsid::MAX_USERID_LENGTH ) );
authenticator->QueryUserIds( reinterpret_cast<char**>( user_ids.data() ), number_of_users );

Your request for constant for max length of user id  makes sense. Will add it to next release.
Regarding QuertUserIds() - Unfortunately MCU (embedded OSs) customers cannot use "std" types and asked us not to use any stl containers in API.

Regarding QuertUserIds() - Unfortunately MCU (embedded OSs) customers cannot use "std" types and asked us not to use any stl containers in API.

Very well. It makes sense. Thanks,

There was a change in the latest released https://github.com/IntelRealSense/RealSenseID/releases/tag/v0.15.0 regarding user id size.


Using as a command-line tool?

I'd like to use Rezoom.SQL as command-line tool: you give it your migrations, and it generates some source code for you (or indeed a minimal assembly).
Pros:

usage on constrainted platforms (I'm looking at .NET CF primarily, but also Mono, Xamarin, etc.)
usage in the wider .NET ecosystem (painless interop with C#, VB -- and it also makes it easier to introduce F# in a project)

Cons:

needs a separate build step
more difficult to iterate compared to F# type provider (still much better, I think, than the hand-written DAL where you need tests to ensure that everything works as expected)

Looks like a type provider can be run via fsc on command line. Maybe it's all that I need, will check it out this evening.


More options to indicate public environment variable then simple  publicPrefix

Describe the problem
i like  sveltekit support array for publicPrefix config.
I have to deal with a vendor lib that expect public environment variables prefixed with NHOST_* and rest used PUBLIC_* . With current limitation, I have to define duplicate variables
my usecase : https://github.com/xmlking/spectacular/blob/916ef57220c6ef451dc9317e26201bb75a1641c3/.env.example#L42****
Describe the proposed solution
While using some 3rd party service provides ( CMS, Backend-as-a-Service, payment systems) with SvelteKit, we have to use vender provided libraries to interact with their system, sometime they have some Convention-over-configuration to use environment variables that are prefixed with certain text (e.g., NHOST_,  VERCEL_ etc) . If those environment variables are needed on both client-side as well as server-side, we have to duplicate them once with vendor prefix and PUBLIC_which leads to duplication.
It will be nice to allow multiple patterns/prefixes to indicate public variables in SvelteKit to support such use-cases.
Alternatives considered
Inspired from  Astro astro:env , methodology described here seams more flexible https://astro.build/blog/astro-4100/
Importance
nice to have
Additional Information
Ref https://x.com/xmlking/status/1803533098170327073?s=61&t=prjj5Lm6MXpnSZaenY1B-A

What if the prefix could accept an array so that you could specify both PUBLIC and NHOST?

What if the prefix could accept an array so that you could specify both PUBLIC and NHOST?

Yes that could solve my needs


Sidebar with Table Of Contents covers entire site at width 767px

Describe the bug
There is an edge case issue around the breakpoint at 768px width. At 766px and 768px, the site appears to be usable. At 767px width, the sidebar stretches across the whole page with no way to dismiss or see the content underneath it.
To Reproduce
Steps to reproduce the behavior:

Navigate to any article where the Table Of Contents sidebar is present. E.g. https://docs.microsoft.com/en-us/azure/devops/boards/get-started/what-is-azure-boards-basic-process?view=vsts
Resize window to 767px width. (Using Chrome Developer Tools, click the Toggle device toolbar button, or press Ctrl + Shift + M, and enter 767 for the width.)
Compare with widths 766px and 768px.

Expected behavior
The sidebar seems it should not be visible until the window has been sized to 768px. But regardless of the technical decision, the site should be viewable at 767px.
Screenshots
766px:

767px:

768px:

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 71.0.3578.98

Additional context
This is incidentally the width that my browser becomes when I use the Windows "Snap To" feature to make it take up half of my screen (which I ESPECIALLY use with documentation... 😑). I am running at 1920x1080 with 125% scaling being used. (1920 / 1.25 = 768... And I suppose less 1px for the window border?)

@SpareNichols Thanks for reporting this bug, and sorry you ran into it! I've passed this along to our frontend team to investigate.

@SpareNichols This bug should be fixed—please confirm and close this issue out if everything looks good.

@SpareNichols Closing this out. Feel free to reopen if it's not fixed for you.


Showing api errors without translation

If an error response is received from the API, it can either contain a translation key OR a message shown to the end user as-is.
Just one example could be during "rename" if there is a conflict, and the backend can enlighten the user about this even if no translation key is present. If new translation keys are added, they will have precedence over the API response message according to the implementation of this commit.

Thank you for this open source project. I work for a med-tech company and this is just what we needed for a small web application involving a file manager.
Feel free to edit, request change or ever reject any PR that I put up, no hard feelings. :-) In the end, we are running our own fork because we needed to manage uploads and downloads via pre signed URL:s (from S3 buckets) and using multipart upload. We also needed to customise the features, turning off archive and preview since we mainly work with very large files containing genetic data.
Let me know if you are interested in some feature-toggle where some features like these can be turned off, and other features (like working with signed URL:s) can be turned on.
Download via pre-signed URL was very easy, but for upload we needed to replace the plupload package.

I'm really glad to hear that the project is coming in handy for you. As in the readme, I have a roadmap for the project, and thought about the feature-toggles before. Unfortunately, Im currently tied up with some other things.  Its ok to customize the features as long as you maintain flexibility.
I want to make the library as modular, just like editor.js. But it is a long way.
Btw, If the translation key is not present, t() function must returns the keyword back. You might have missed it.
https://github.com/n1crack/vuefinder/blob/42998daf79cd7fbc780013526f55a47ef98a54c8/src/composables/useI18n.js#L39-L44

npm and demo files updated. But Im not sure of this MR yet.

Btw, If the translation key is not present, t() function must returns the keyword back. You might have missed it.

Yes, I did. Thanks for a firm review! (It proved that the missing value was due to our backend returning the message in the wrong property, we mistook that for a missing translation key). If I may suggest, we can still keep the safeguard to check that the message is there all together, but of course the check from the translation function is not necessary.

there are many things changed. Currently we don't get the error message from this.


请问有requirements文件吗，我想查看我的版本是否兼容

Hi. When I created this repo I did not add requirements (it's been a year almost, but the repo looks like updated last week. actually it's not I just removed the commit history :-) . I am planning to update this repo in this weekend and add new losses.

@RainFo666, now you can use it. I refactored the repo and provided pretrained weights in weights folder and requirements to run the code.
I am closing this issue. If you have any further issues, feel free to reopen the issue again.


can we get    [1.2.2] Mark One Laboratory Extensions (M.O.L.E.) v.1.6.6   added to ckan?

Thanks for wanting to bring an issue to our attention!
Before you open a ticket, please do a quick search of the existing issues to see if it's already been brought up.
Please note that this repository is strictly for metadata (issues relating to incorrect information about mods, missing versions, or incorrect installations). If you want to suggest something or report a bug relating to CKAN as a whole, open the issue in: https://github.com/KSP-CKAN/CKAN

Last year @Angel-125 wanted to de-list his mods from CKAN, so we respect his decision.
Reference #4294


💡 Get already configured \PDO connection from Database instance.

I have an idea!
Hello! Some legacy classes in my project required \PDO instance. At the moment I am not able to get it from Database instance.
In doctrine we have this opportunity.
/* @var \Doctrine\DBAL\Driver\PDOConnection $pdo */
$pdo = $entityManager->getConnection()->getWrappedConnection();

I need some similar method in cycle.

You can get PDO instance using closure:
$pdo = (fn () => $this->getPDO())->call($driver);

But it doesn't guarantie that PDO connection hasn't got a timeout error.
If you want to just get a PDO connection that mustn't depend on DBAL then use
$pdo = (fn () => $this->createPDO())->call($driver);

@roxblnfk said that in long running applications it is dangerous to get Pdo instance because the connection can be broken in any time.
Some variants to achive for me
\assert($driver instanceof \Cycle\Database\Driver\Driver);
$pdo = (fn () => $this->getPDO())->call($driver);

// creates new Pdo connectino
class PdoFactory
{
    protected function __construct(
        protected DriverConfig $config
    ) {}

    /**
     * Create instance of configured PDO class.
     */
    public function createPDO(): PDO|PDOInterface
    {
        $connection = $this->config->connection;

        if (!$connection instanceof PDOConnectionConfig) {
            throw new \InvalidArgumentException(
                'Could not establish PDO connection using non-PDO configuration'
            );
        }

        return new PDO(
            dsn: $connection->getDsn(),
            username: $connection->getUsername(),
            password: $connection->getPassword(),
            options: $connection->getOptions(),
        );
    }
}

But it doesn't guarantee that PDO connection hasn't got a timeout error.

Many drivers support automatic recovery for such case.
F.e. PDO::MYSQL_ATTR_INIT_COMMAND.


New clean test

Hello @pgabor! Thanks for submitting the PR.

In the file xrayvision/tests/test_clean.py, following are the PEP8 issues :

Line 85:33: E231 missing whitespace after ','

I think it would be good if clean told the user why it stopped it either reached threshold or niter


Add support for fusion 360 custom screw creator extension

Is your feature request related to a problem? Please describe.
I'm using fusion 360 on linux and would like to known if this extension works.
Describe the solution you'd like
Add support for this extension

Hi @integrated-circuit I will testing this extension after my holidays. :+1:

Thx another question. Fusion 360 can export a 3d model to a slicer like cura in windows, but if the slicer is installed on linux, Fusion wont detect it as it cannot access the linux fs. Could you add smth to allow fusion to find the cura executable in the linux fs?
Integrated-circuit


Add File

The GDUFS version.
Difference
    The system used by GDUFS must verify identity with random code, so the value of code should be posted with other data.
Fixed
    The program will exit when the task is all clear now.

Thanks for your commit, although the choosing class mode will change in SUSTech in the next semester.


Separate footer data from the component

I have found this pattern commonly on other React projects, especially in components with menu items. It makes the component easier to change by extracting its data into an array of objects.
Advantages:

Makes the code more modular and easier to maintain.
Allows for easier customization of the footer links without having to modify the component code.
Makes the code more readable and easier to understand.

Disadvantages:

Adds an extra layer of complexity to the code.

In my opinion, advantages overweight the disadvantage.

Sounds good! I'll give the Webpack JSON import a try and merge if all goes well.


[W5][W17-1]Pai Si Kai

Can consider adding test cases for ParserTest class to test whether the findByNum command works. Can also add instructions to use findByNum command in the HelpCommand class.


Issue with Installation

Connect to the Raspberry Pi over SSH using the default user and password
Run wget http://nmacleod.com/public/libreelec/getwidevine.sh
Run sh getwidevine.sh
Reboot the Raspberry Pi
When I follow the installation instructions above, I get:
*** THIS SCRIPT IS OBSOLETE ***
Any guide recommending the use of this script is out of date.
The widevine library should now be installed (and updated) by
script.module.inpustreamhelper.
script.module.inputstreamhelper will be installed automatically as a dependency
when installing video addons (Netflix etc.) from a suitable repository.
Contact the video add-on author if the video add-on does not support
script.module.inputstreamhelper.
Netflix was working then all of a sudden it stopped. Are the install instructions out of date?

getwidevine.sh isn't necessary anymore, the plugin pulls in the needed Widevine lib by itself now. Just install it, like you would do with any plugin and it should be fine.


default startup is development mode

in server/__init__py:35
If a server admin forgets to set the APP_SETTINGS env or has a typo there the projects starts in development mode.
For security reasons the default mode should be production - still better to start in broken production environment than starting in develop mode where e.g. authentication might be disabled

Sounds good. Want to do a PR?


[LexicalSummary] Add LexicalDispersionPlot

Add a LexicalDispersionPlot to show the dispersion of matches across a text.

[x] #139
[x] #140

[ ] Support lexical patterns as input
[ ] Each row is a unique match; Each column is a position of the match

All tasks completed.


Update toc.yml

DO NOT MERGE [yet]

Hi @bradygaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


feature/connectiongater

Overview
Resolves https://github.com/celestiaorg/rollmint/issues/386
datastore.Datastore interface to persist blacklists/whitelists is not yet implemented.
Blacklists/whitelists are only applied while starting the Client, and do not update while the Client is running.
This PR is a draft to check that everything is roughly as requested.
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

Codecov Report

Merging #610 (a18fc15) into main (3a518be) will decrease coverage by 0.08%.
The diff coverage is 58.62%.

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   55.46%   55.38%   -0.09%
==========================================
  Files          50       50
  Lines       10285    10330      +45
==========================================
+ Hits         5705     5721      +16
- Misses       3719     3737      +18
- Partials      861      872      +11

Impacted Files
Coverage Δ

node/node.go
60.26% <50.00%> (-0.46%)
:arrow_down:

p2p/client.go
60.74% <59.61%> (-2.31%)
:arrow_down:

types/validation.go
36.36% <0.00%> (-13.64%)
:arrow_down:

state/executor.go
67.89% <0.00%> (-0.74%)
:arrow_down:

block/manager.go
68.28% <0.00%> (+1.02%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for the submission! Left some comments. Had one question, when are whitelists useful as opposed to just having a blocklist? Or is the point to have overlap in whitelists and blocklists when unblocking a peer? Also, what happens when there are duplicate peer IDs in these blocklists/whitelists?

When we get to the point where peers are blocked automatically (because of for example spamming, sending invalid FPs, etc), we might want to manually unblock specific peer.

When we get to the point where peers are blocked automatically (because of for example spamming, sending invalid FPs, etc), we might want to manually unblock specific peer.

That makes sense but instead of having that peer in both the whitelist and blacklist, is it possible to just remove the peer from the blacklist instead since this is done during client initialization?


Add GH Actions configuration

Build and test Go project
Build a Docker image with Kaniko

Closed in #3.


Support for PostgreSQL

Add support to copy change data from PostgreSQL

I can pick this issue, do we wanna discuss how should we approach this?

Thanks @atiqsayyed. There are 2 things that need to be done here.

Updating this project
a. Add one more entry for PostgreSQL in DatabaseProduct.scala.
b. Add prepareStatement to poll data from PostgreSQL in IdBasedDataService.scala, TimeBasedDataService.scala and TimeIdBasedDataService.scala.

Updating sample project
a. add docker functional test KafkaConnectPostgresqlFunctionalTest.scala

I've started working on it


"@remix-pwa/push": "^1.0.2" is missing

I can't build mu project because I'm using 1.0.2 of remix-pwa/push

1.0.2

👋, sorry for the late response. The new push package version is 2.10.0 not 1.0.2, if you want the old, legacy push package - that's available via @remix-pwa/old-push

Closing this issue as stale


Error while updating property 'play' of a view managed by: ReactYouTube

Hello! Could you tell me please how to solve this problem?
Error while updating property 'play' of a view managed by: ReactYouTube
"react-native": "0.63.0"
"react-native-youtube": "^2.0.0"

+1

I have one:
Error while updating property 'fullscreen' of a view managed by .....


Improve code coverage.

It's embarrassing having only 25% code coverage with literally just
Hello World. This should bump it up by subbing out stdout. See:
http://stackoverflow.com/a/2169336/101923

LGTM

[Current coverage][cc-pull] is 66.66%

Merging [#25][cc-pull] into [master][cc-base-branch] will increase coverage by 41.66%

@@             master        #25   diff @@
==========================================
  Files             1          1
  Lines             4          3     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits              1          2     +1
+ Misses            3          1     -2
  Partials          0          0

Powered by Codecov. Last updated by [e70092c...86fa42f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/GoogleCloudPlatform/java-repo-tools/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/GoogleCloudPlatform/java-repo-tools/compare/e70092ce9d05b3ea75939360ea5fd4d3eff3aa49...86fa42f850bb934ff91326a856880cede1c29176
[cc-pull]: https://codecov.io/gh/GoogleCloudPlatform/java-repo-tools/pull/25?src=pr


[CT-2976] Fix untyped functions in clients/jinja.py (mypy warning)

Problem
When we hit a mypy error the console is flooded with mypy warnings as well.  Clean up the warning to improve developer experience.
Reproduction
Simply force a mypy error (change types) and the warnings will be generated.
Relevant Output
core/dbt/clients/jinja.py:195: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]

Fixed in #8416


add text2video retrieval

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: deplay:x: jpWangYou have signed the CLA already but the status is still pending? Let us recheck it.


Hide answered rows in Matrix and store answers before completing.

Are you requesting a feature, reporting a bug or ask a question?
Question
What is the current behavior?
I have Matrix question with about 30 rows and 10 radiobuttons in each row.
Everything works fine.
What is the expected behavior?
Is there any way to hide row which was answered?
I mean - when user picks one of ten radiobuttons (answers) in row - that row should be hided.
And by the way - is there any method to take Matrix rows answers "on-the-fly" before completing survey?
How would you reproduce the current behavior (if this is a bug)?
it is not a bug
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
your_code_here

Specify your

browser: Chrome
browser version: 58.0.3029.110 (64-bit)
surveyjs platform -  jquery
surveyjs version: latest

@GreatEarl Are you talking about this? http://plnkr.co/edit/hDXPsZk3HhpyxnBqGoRO?p=preview
Thank you,
Andrew

@andrewtelnov  Thanks Andrew, that's it!  And is there any way to reset answers of question like this? I'll explain - I want to hide rows when user answers but I need to give him ability to reset answers only on current question if he think that some answers were wrong. May be there is a method to reinit question not all syrvey.

@GreatEarl You may show the same question, with the same name and properties (just copy it) on the next page. The value for this questions will be stored in the same place data["questionName"], so they will share it.
Thank you,
Andrew

@andrewtelnov  Ok, I've got the point but actually, I have 6 pages, and the page with matrix is 3-rd. Right now I don't imagine how it'll work, need to be tested ))
If interesting - I want to implement a kind of ratings. When User has to spread let say 15 points of rating between 4  positions (rows) assessing from 1 to 5 each. And when user can't set maximum rating of 5 for each position - in this case the sum of pionts will be 20 but user has only 15. So user must evenly distribute 15 points between positions. And when he thinks that there was an error in answers - I want to reset all answers.
Best,
Ravil.

@GreatEarl Then you may have a button outside the survey "Reset answers", it will be shown when the question/page is visible and actually it will reset the rows: survey.getQuestionByName("myMatrix").rows = savedRows;

@andrewtelnov Andrew thanks for the direction and explanation I'll play around it )  btw
survey.getQuestionByName("matrix").rows  - returnt list of objects when "question" itselft accepts array in rows. Or do I need to save my rows as object before?

Yes, it is better to save the rows before survey starts. However, on setting rows property, the library will convert the array of strings into ItemValue array anyway.

Thank you Andrew, the rest I need - to find proper way to store rows and re-assign them on reset.


Register confirmation is not working

We do not receive any registration confirmation when registering a new user.
Is this related to the fact that you deleted the [IdentityNoOpEmailSender.cs] file ?

Don't forget to configure these parameters for your SMTP server.

It's configured correctly, other e-mails are working fine.
In my case : the register confirmation e-mail is not sent via e-mail.
I have to go with the Admin account, set the new registered user as "Active", and then, he will get the e-mail to reset the password.
After that, though, he cannot login, because in the database the "EmailConfirmed" value is 0.
btw, why do i have to setup a password at signup, and after that, when the user gets the confirmation e-mail, he has to reset the password again ?

Btw, this is the error message we get :
[14:08:35 ERR ] Failed to send templated email. Subject: Account Activation Required, Template: _useractivation. An exception occurred.
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'IServiceProvider'.
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ThrowHelper.ThrowObjectDisposedException()
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
at Microsoft.Extensions.DependencyInjection.FluentEmailServiceCollectionExtensions.<>c__DisplayClass0_0.b__0(IServiceProvider x)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass2_0.b__0(ServiceProviderEngineScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)
at FluentEmail.Core.FluentEmailFactory.Create()
at PropertyManagement.Infrastructure.Services.MailService.SendAsync(String to, String subject, String template, Object model) in D:\Dev\xxx\src\Infrastructure\Services\MailService.cs:line 71
at PropertyManagement.Application.Features.Identity.Notifications.UserActivation.UserActivationNotificationHandler.Handle(UserActivationNotification notification, CancellationToken cancellationToken) in D:\Dev\xxx\src\Application\Features\Identity\Notifications\UserActivationCommand.cs:line 29

Can you debug and fix this error?

Can you debug and fix this error?
also you can check the email template file in the folder \Resources\EmailTemplates_authenticatorcode.cshtml

Looks like the dependency container already disposes the service before the service is needed. I would try and fix this myself, but I'm currently on Vacation to Japan for 3 weeks 😅

Can you debug and fix this error? also you can check the email template file in the folder \Resources\EmailTemplates_authenticatorcode.cshtml

Hard to debug...
I have all the files in the correct place.
At this line of code in my MailService i get that error :
        else
        {
            return _fluentEmailFactory
                .Create()
                .To(to)
                .Subject(subject)
                .UsingTemplateFromEmbedded(string.Format(TemplatePath, template), model, Assembly.GetEntryAssembly())
                .SendAsync();
        }


devcontainer configuration for rudr dev environment.

This is the initial .devcontainer config and Dockerfile to create the dev environment.

This is good, could you give some documentation for using this?

I can add docs.  But, this is just the standard VS Code Remote Container feature.  Where do you want the info to be added?

 So we don't know what to do with this PR. I guess it would be enough to add a document under docs/developer just pointing toward some external documentation on what this is and what it is supposed to do.

I'm adding a Quick Start section to the Contributing.md that explains how to use this to develop.

OK.  I added documentation.  Let me know what you think.

Is this still blocked?

@dumbnose , it would be good to add information on how this can be used for people trying to use Rudr instead of contribute to it as well.
However, I think we can do that in separate follow up PRs. Thanks for this contribution. @wonderflow, can we merge this now?

I was writing some docs and @dumbnose, I think these docs make sense in the docs/developer folder. Can you move it in there?

After read the README, I find it seems this is only benifit for vscode users. I don't know whether we really want to add it to project.
Are we possible to setup dev environment like this by using Makefile ?

@wonderflow , what if there was a container that users can start by mounting the Scylla directory into and they have an environment which now contains kubectl, Docker, helm3, Rust etc. This allows customers on any platform to try out the examples, docs and also the VSCode experience.

@suhuruli I believe that if we wanted to, we could add a third stage to the build in the Dockerfile which would do that. But it feels like sort of a niche thing that is not really part of the core experience for the project. Maybe we should put that in a separate repo where it could be built and then pushed to DockerHub. (That's closer to the way Dapr did their repo structure)

That's a great idea to have it as a step in the original Dockerfile.

What is the final verdict on this? Do we need to just put something in here for now and move it later? Or have we found another place already?

What is the final verdict on this? Do we need to just put something in here for now and move it later? Or have we found another place already?

I fixed up this PR and I think it's good to go now. I can be on point for the maintenance moving forward.

Created a GitHub Action that runs on push which generates the dev container image.
Split the contributing docs up into using the dev container image as an optional step for contributors
Separately, I believe we can also use the dev container image as part of Quickstart's and How-To's for people who want to consume Rudr and don't want to install all the dependencies etc.


IPV6 support in log_parser

Ref: #23 - Not addressed in log_parser code. Resulting in tons of CloudTrail errors as the lambda is trying to add IPV6/32 instead of IPV6/128
"errorMessage": "Update failed, invalid CIDR block: cannot parse IPV6/32 as a CIDR"

Thanks

Created a pull request for this Rrf: #58

Hi,
I saw the PR related to this. Added to be considered for the next release.
MANY thanks for the contribution.

Hi @vr00n.
We've just pushed a new version with IPv6 for LogParser included.
Thanks!


Failed validation: #/definitions/QuoteSummaryResult

Validation Error
Minimal Reproduction

Symbol(s) that it happened for
-OARK

Error Message

The following result did not validate with schema: #/definitions/QuoteSummaryResult
[
  {
    instancePath: '/topHoldings',
    schemaPath: '#/required',
    keyword: 'required',
    params: { missingProperty: 'stockPosition' },
    message: "must have required property 'stockPosition'",
    data: {
      maxAge: 1,
      holdings: [],
      equityHoldings: {
        priceToEarnings: 0,
        priceToBook: 0,
        priceToSales: 0,
        priceToCashflow: 0
      },
      bondHoldings: {},
      bondRatings: [],
      sectorWeightings: []
    }
  },
  {
    instancePath: '/topHoldings',
    schemaPath: '#/required',
    keyword: 'required',
    params: { missingProperty: 'bondPosition' },
    message: "must have required property 'bondPosition'",
    data: {
      maxAge: 1,
      holdings: [],
      equityHoldings: {
        priceToEarnings: 0,
        priceToBook: 0,
        priceToSales: 0,
        priceToCashflow: 0
      },
      bondHoldings: {},
      bondRatings: [],
      sectorWeightings: []
    }
  }
]

Environment
Browser or Node: node
Node version (if applicable): v18.12.0
Npm version:
Browser verion (if applicable):
Library version (e.g. 1.10.1):
Additional Context

sorry, duplicate :-(


Why tempDir is created by this package and not by ufs-local package?

There are a lot of adapters that don't need a temp file. Or it can be optional.

It's mainly for performance reason, as it receives a chunk, the store writes it directly on the local file system which is the fastest way to save data and then get the next chunk, instead of establishing a network connection, then forwarding the chunk (I am thinking about cloud storage).
But it also provide an easy way to cancel or remove the file if something went wrong during transfer.
It is also secured in a way that it not written to the store until the file has been completely uploaded.
I really don't think that using a temp file has more bads than goods, so I'll keep it, but if someone shows me a better way, I can remove it later, this won't change a lot of things in the API.

I understand, but we can have some another temp options, like MongoDB as a temp store.
Can exists cases when user don't have permission to write to FileSystem with the user that is running the application.
Can exist a temp in memory too. Probably in this case more options is Better.

@rodrigok, a temp in memory is just the worst idea you could have when creating a temporary file, we are not on a user's desktop, we're talking about servers with potentially thousands of user requests per seconds, a single user could easily upload a 10Mo file, but what if 100 users did that at the same time, 1Go of RAM ? no way... say hello to outOfMemoryException and good bye to service availability (but maybe I misunderstand your idea, so tell me).
For a Mongo temp storage, why not, but this would involve using GridFS, because a document in Mongo is limited to 16Mo and I see this as a duplicate of the work you are currently doing on the ufs-gridfs store.
But you're right, there is a possibility that some developers do not have write permissions on a private local directory, however this concerns IMO a very small portion of people, as nowadays even on a shared hosting, you have an access to a "home" dir that is not accessible from Internet.
Now, as I said, until someone tells me that this is a problem for him because he has no write permissions, I don't see this feature as a priority, so it will be delayed for future releases as a "bonus".
Just to know, are you facing this problem of write access ?

Hei @jalik, you are right, this is not a priority now, and I'm not facing this problem now.
I understand all problems generated by keeping file in memory during upload, however use FS to store the file before send to GridFS seems a lack of performance with no necessity.
If user don't have a server with SSD this solution can be very slow in same cases.
My ideia isn't remove the temp store, but make it optional and enabled by default, so users can disable to improve performance or solve access problems in some cases.
But, as you said, isn't  a problem now, but I think it is a good issue to resolve in a near future.

Today I installed Rocket.chat (which uses your Meteor package) with mup on a DigitalOcean server. These are the temp directory permissions: drwxr-xr-x 2 root root    4096 Jan  6 03:59 ufs
Rocket.Chat runs as meteoruser so could not write here. So not sure if this qualifies as a Rocket.chat or jalik-ufs bug but an in-memory/mongetemp default would have prevented this.

@ericvrp Hi, as the UFS doc says, you can define your own tmpDir path, it can be wherever you want, so you could event point to a folder in your home dir where you have the permissions :
// Set the temporary directory where uploading files will be saved
// before sent to the store.
UploadFS.config.tmpDir = '/tmp/uploads';

The problem for now, is to define this config after RocketChat, otherwise it will be overwritten.
I would like to solve this quickly but I don't have lot of time for such improvements (let's say it's not a bug).
Quick reminder : InMemory storage is a bad idea as I said in a previous post, we're talking about uploading files, potentially hundred of MB of data...

Yes I found that line in the docs, which made me look for it in RocketChat but it's not there so either I looked not at the right place or it relies on the default. In any case /tmp/ufs had the wrong filesystem permissions. It would be good to know why.
I agree with the worst case scenario for inmemory temp storage but it has advantages too. One option could for instance be to allow a max amount of memory usage before a. falling back to disk or b. pausing the upload until below the memory threshold again.
One could ofcourse already store inmemory by using a ramdisk. for the /tmp directory.
BTW at this stage not to important anyway probably. I have also posted my findings on a RocketChat channel because perhaps the /tmp/ufs permission is something they can fix or provide better error messages for.

When using mup deploy, the app is started as root and the temp dir created is owned by root,
with permissions rwx r-x r-x. However, when the app steps down to meteoruser, it no longer has permissions to write in the temp folder.
Please add a config option to specify permissions for the temp dir and/or specify which user owns the folder.

@pavelpep There is no need to add such an option since the current permission is the one needed to make it work, don't you agree that the user that created the temp folder should be the only allowed to write into it ?
It's not that I don't want to help but you want to fix this issue in the wrong way giving more permissions than needed on a temp folder.
In your case, the problem is with MUP, why is it starting your app as root ? it's insecure, you should check your config if you can force MUP to execute the app only with the meteor user.
Also, you can create yourself the folder and set ower/permissions before you start the app.

@jalik Thanks for the quick reply! The second work around you suggested (create the folder manually) is what we are currently using,  but it would be much cleaner if there was a way to explicitly set the owner of the temp folder right in the UFS config.
I agree the user who created the folder should be the only one to write to it. But, it would also be useful limit 'others' from reading the contents. Currently, when we create the folder manually with permissions 740 , they get overridden to the library default 744 upon app start-up.

@pavelpep The ufs-local package has it's own documentation and issue tracker : https://github.com/jalik/jalik-ufs-local#creating-a-store
You can set folder's permissions passing mode: 740 and file's permissions using writeMode: 740 to new UploadFS.store.Local(options).

@jalik, I know, but what I am referring to above is strictly regarding the temporary folder and its permissions.
The ufs-local package already has the option to specify permissions for the data storage folder and files, I was just asking if you could implement similar options for the temporary folder created by this package.

@pavelpep Sorry I was focusing on the Local store, you can now define temp directory permissions by setting the UploadFS.config.tmpDirPermissions to  a string like 0700.
See https://github.com/jalik/jalik-ufs/tree/v0.6.4#configuration.

@jalik awesome, thank you :)


Propagate cassandra port in load schema

Coverage decreased (-0.03%) to 68.384% when pulling 7a82266c09b7facab0bcf47eccf5a592245f7a49 on cassPort into 9c2d1a1c05e4dd58155a21869c6337558d4115de on master.


"py -3" command does not work when pyenv is used.

Hi! Thank you for the great package!
I have one question related to windows user.
If windows user installed Python with pyenv, I think Python would be launched by "python" command.
Therefore, "py -3" will cause an error in FD_HAS_PY3().
How about returning "python" when ENV["PYENV"] exists?
https://github.com/tlienart/Franklin.jl/blob/5c8f5e1af7d1279f5aad9e1437f7d883f4302307/src/build.jl#L1-L11

Hello!
Yes I think what you say makes sense. Maybe we could just add an if around line 6, would you be interested in a PR?
Note: the Python path in Franklin is bound to disappear. It is only used to run the minification (this script: https://github.com/tlienart/Franklin.jl/blob/master/src/scripts/minify.py relying on css_html_js_minify which is unmaintained and not great but simple); it's actually not particularly helpful so the next planned major release gets rid of Python.
In short: if this is bothering you and you'd like to have a small fix for it for now, I'll gladly merge a PR to this effect, I was just commenting on the fact that in the medium term this will all go away :)


Set facility name in CCM chart

How to categorize this PR?

/kind enhancement
/priority normal
What this PR does / why we need it:
The Packet CCM allows specifying the Packet facility in two ways: Using an env var and using the Packet metadata service.
When deploying a Packet shoot with a seed which runs outside of Packet, the CCM which runs in the seed is crashlooping because it can't communicate with the Packet metadata service to figure out the facility automatically.
Since the Spec.Region key of the Shoot resource seems to be required, looks like we can always specify the facility explicitly. Doing so allows using non-Packet seeds and shouldn't have any effect for Packet seeds as far as I can tell.
Release note:

Packet facility is now explicitly passed to the CCM. This allows running the CCM in seed clusters which don't run on Packet.

Thank you @johananl for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Fixing the generation problem.

@rfranzke I'm running make generate but the command doesn't produce a diff. Am I doing something wrong? :thinking:

@johananl Can you try running make install-requirements first?

@johananl Can you try running make install-requirements first?

Done! That was it.


Non-full backward hook with shap.DeepExplainer + PyTorch

Error: Using a non-full backward hook when the forward contains multiple autograd Nodes is deprecated and will be removed in future versions. This hook will be missing some grad_input. Please use register_full_backward_hook to get the documented behavior.
PyTorch Model:
class aggregation_model(nn.Module):
    def __init__(self,fit_iterations,n_features):
        super(aggregation_model,self).__init__()
        self.models = nn.ModuleDict()
        self.fit_iterations = fit_iterations
        self.n_features = n_features

        for iter_ in tqdm(np.arange(fit_iterations)):
            model_weights = torch.load("model_iterations/model_iteration_cat_{:d}.pt".format(iter_))
            self.models["model_iterations/model_iteration_cat_{:d}".format(iter_)] = nn.Sequential(nn.Linear(n_features,1),nn.Sigmoid())
            self.models["model_iterations/model_iteration_cat_{:d}".format(iter_)].load_state_dict(model_weights)

    print("Initialized Aggregation Model")
    def forward(self, x):
        model_iteration_predictions_open = []#torch.zeros((x.shape[0],1),requires_grad=False)
        for iter_ in np.arange(self.fit_iterations):
            model_iteration_predictions_open.append(self.models["model_iterations/model_iteration_cat_{:d}".format(iter_)](x).view(-1,1))

        model_iteration_mean = torch.cat(model_iteration_predictions_open,dim=1).mean(1).unsqueeze(1)
        return model_iteration_mean

model = aggregation_model(fit_iterations,27)
e = shap.DeepExplainer(model,X_pytorch)
shap_values = e.shap_values(X_pytorch)

Versions: PyTorch 1.8.0 , Shap 0.39.0
I have seen similar posts in the closed / open section but no resolution to this issue... Is there a way to rewrite the PyTorch model to avoid this warning? Does this warning mean that it is only using 1 of the models in the nn.Module() function for the shap value calculation?
Any suggestions would help a lot.

+1, would love to see an answer here!

You can not avoid this warning without rewriting shap, since shap is using a deprecated torch method in its code. Prior the deprecation of register_full_backward_hook in torch, it simply did not show a warning at all while having the same (probably erroneous) behavior. torch improved the backward hook and gave the method a new name register_module_full_backward_hook in this pull request.
I made a pull request which is now using register_module_full_backward_hook.
Regarding your question: shap does not seem to support every possible model configuration and it does not seem to always give a warning in that case. If you want to be more sure, clone the shap repository, follow the installation guide in CONTRIBUTING.md, add a test in test_deep.py by copying test_pytorch_single_output() and replacing the class Net(nn.module) with your own network structure. Run the test by calling pytest ./tests/explainers/test_deep.py and see if it succeeds.


Fix dark mode flash (#3)

Fix for #1508. Adding rocket-loader override to hopefully get rid of flash.
(This next iteration on #1593 -that PR was closed).
Note: this is just a single line and should work on merge.

Now it works fine


Add Github Pipeline for building

A Github Pipeline for building it would help others to avoid issues for building this.

I added a circleCI build. Does that cover your concerns?

yes


⚠ RPC server - Astar has degraded performance

In ad8a987, RPC server - Astar ($ASTAR_RPC_URL) experienced degraded performance:

HTTP code: 429
Response time: 325 ms

Resolved: RPC server - Astar performance has improved in 415eb84 after 6 minutes.


Dead letter queue does not work when topic contains a wildcard

In what area(s)?
/area runtime
What version of Dapr?

1.8.3
master

Issue
When an app subscribes to a topic using a wildcard (something that can be done for example with pubsub.mqtt by subscribing to foo/#), failed messages are not sent to the DLQ.
The problem is here:
https://github.com/dapr/dapr/blob/e8080af869f56d78ca44e8fe4603d2e41c4d9ee7/pkg/runtime/runtime.go#L610
This checks for the DLQ topic by using msg.Topic. However the topic used to subscribe contains the wildcard (e.g. foo/#), while the topic in msg.Topic is the "actual" topic (e.g. foo/3).
Release Note
RELEASE NOTE: FIX Failed pubsub messages are not sent to DLQ if the topic subscription has a wildcard

/assign


[Feature-request] support amd gpus without matrix cores in rocBLASLt

Should be doable to "emulate" these in the GCN5.0/RDNA2+ ISA

@IMbackK I will check with the internal team and will let you know. Thanks!


Starting Service / GCM tutorial

I can not able to see where we starting RegistirationIntentService.
Please add this line to second major topic if not exist;
startService(new Intent(MainActivity.this, RegistrationIntentService.class));
If exist, forgive me.
Thanks.

Isn't there http://guides.codepath.com/android/Google-Cloud-Messaging#create-a-instanceid-listenerservice?

Where do we starting MyInstanceIDListenerService ?
I was only able to get pushToken after i started RegistirationIntentService from my MainActivity.
Without the line I offered nothings happen.
It seems we does not start both of these services anywhere.

MyInstanceIDListenerService starts up as a background service and will launch the intent service onTokenRefresh() as mentioned in the guide: http://guides.codepath.com/android/Google-Cloud-Messaging#create-a-instanceid-listenerservice
Yeah we should mention you need to start the intent service in OnCreate() as shown in this example:
https://github.com/googlesamples/google-services/blob/master/android/gcm/app/src/main/java/gcm/play/android/samples/com/gcmquickstart/MainActivity.java#L71-L75

Updated here: https://github.com/codepath/android_guides/wiki/Google-Cloud-Messaging#implement-a-registration-intent-service
You only need to initiate the RegistrationIntentService though, not the InstanceIDListenerService.

This is great, thanks for closing the loop on that


When using Conformer in speech recognition

The output of DecoderRNN-T is combined with 4 dimensions, how to use it to recognize speech? Besides, the auther make the model architecture with the LAS? Such as: Conformer-Encoder, LSTM-Decoder, Attention?

Check this project


Update policy readme Tue Jul 16 15:20:59 UTC 2019

Update policy readme Tue Jul 16 15:20:59 UTC 2019

Duplicate of #59


feat: Throw error if unused suppressions are found.

Description
Unused suppressions are a code stink and could lead to future unintended suppressions. If unused suppressions are discovered an error should be thrown.
Use Case
Unused suppressions, especially for IAM policy wildcards, could lead to future suppressions which were not expected.
Proposed Solution
Implement a "NaggingSynthesizer" stack synthesizer, this synthesizer would maintain state tracking what suppressions are found, and which suppressions are used. In the synthesize method, call super to synthesize the stack, and then perform checks to ensure all found suppressions were actually called by ignoreRule. If not, throw an error complaining of unused suppressions.
Other information
This would not incur any breaking changes, and would be an optional implementation by requiring the implementor to use the NaggingSynthesizer stack synthesizer.
Acknowledge

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

This is somewhat tricky. If this were to be implemented we would have to consider the following

Stack level suppressions would need to be accounted for
Applying suppressions with applyToChildren would cause errors when those suppressions get applied to non relevant children (could be worked around).

Additionally if implemented I think this should be an optional feature

Unused suppressions, especially for IAM policy wildcards, could lead to future suppressions which were not expected.

This could be a problem, but users do have the option to apply granular suppressions (example 5) for better control over that situation.

I agree, this could potentially cause more pain than gain. I think this pull request will help avoid the type of unused suppressions I was considering (path misses)


Define icons for android possible?

Describe the feature you would like to see
I can send a cloud message with this package, but i can;t find anywhere if it is possible to define the android icon.
$notification = [
            'title'     => $request->title,
            'body'      => $request->body,
            'image'     => $image_url,
        ];

`  $message   = CloudMessage::withTarget('token', $request->firebase_token)
            ->withNotification($notification);

Works like a charm on android. I even get the image. But the icon is just a circle with the first letter of the website in it.
Is it possible to define/set the wanted icon with this package?

You can define platform-specific configuration with the withAndroidConfig() method.
https://firebase-php.readthedocs.io/en/stable/cloud-messaging.html
In the docs above you'll find a link that points to the official docs describing the possible config values:
https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages


Resolving some preprocessing issues

Fixes:

A couple of naming issues in the density calculation (original code still looking for lat and lon instead of x and y).
Added additional possible names for the z coordinate (zi and zl, present in some GFDL models)

No issues on my side. Do you want to merge or leave it open for future changes?

Let's merge it - next time I will try to not make a load of changes, break the package, and then change them all back again!