Coordinating wasm-bindgen versions

Fixes #146. This aims to solve the issue of making sure that there is (a) a locally installed wasm-bindgen and (b) that it is the same version as specified in the Cargo.toml file.
As of now, there are still some rough edges that I want to hone down here. It seemed like a good idea to check in the existing work on this issue that I got done today, to make sure that I am headed in the right direction on this. Any feedback is totally welcome!
I'll also close #81 now, since I believe this will also take care of #51.
I should be able to get this all wrapped up tomorrow, had to spend a little more time than expected today getting up to speed with the changes that have occurred since then. Loving all the stuff people have contributed! :smile:

Make sure these boxes are checked! 📦✅

[x] You have the latest version of rustfmt installed and have your
cloned directory set to nightly

$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly

[x] You ran rustfmt on the code base before submitting
[x] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

I think this is ready for review now :smile: Let me know if you have any feedback!

@data-pup awesome! i'll take a look soon- in the meantime it looks like rust fmt needs appeasing lolsob. thanks for putting so much effort into this! it's super appreciated. as mentioned previously- i think i'm down to sneak this in in a point release because it's gonna make everything way more awesome :)

Ahh pardon! I ran fmt before I rebased this, that's fixed now :) Happy I could help!

Added some more commits to fix the issues mentioned in @mgattozzi 's review. Thanks for the feedback! I added some platform specific path strings, and changed the get_wasm_bindgen_version function to return a Result<String, Error>.

then you can do return Err(Error::crate_config("wasm-bindgen version dependency was empty"))

Regarding this point, I realized that there was already a crate_config error, but did run into the same issue I'd seen with the other cli helper function. These were returning a Result<(), Error>, which meant that they aren't usable in a function that does return a value in the success case.
I altered these so that they return Self, so that we can use these methods elsewhere too. This felt a little opinionated on my part, but I don't think it affects readability.

You'll also need to make sure the part that calls wasm-bindgen in the build step uses the local one!

Still need to take care of this part, I'll do that right now though! :smiley:

Ready for another round of review, whenever you have time!

I like your points regarding the --no-installs flag, that's an important detail I don't think my changes currently account for. Would it make sense in that case to search through the locations in the $PATH environment variable for wasm-bingen?
Overriding the local behavior with a flag makes sense to me, but right now I'm not sure if I have a solid answer to the story about how this works either. I will think about this too, but feel free to follow up if you come to a decision :)

@data-pup i also don't know exactly what we should do! very open to suggestions. i can take some time this weekend to think on it :)

Doesn't no installs imply using a local one anyways? From my understanding it won't be installing a global version. In fact wouldn't it make more sense to just use a sandboxed version anyways rather than relying on a global one? In tools like stack/cabal for Haskell it uses sandboxed versions of everything unless specified to use a global one which seems like the better choice, unless I'm misunderstanding what you mean by --no-installs @ashleygwilliams

Just wanted to follow up on this, do you happen to have any advice for next steps on my end? If there might still be some thought required regarding the interface etc., I'm happy to hold off on this!
I know I can definitely add some extra logic to handle the --no-installs flag, but a little unsure what that should generally look like at the moment.
Btw, thanks for being nice maintainers! Appreciate the feedback so far :)

I saw that #146 has been marked as Blocking Rust 2018, so I rebased this off of master to prepare for further work on this. At this point I think all of the changes requested by Michael have been taken care of, and I can take care of some of the minor details mentioned in Ashley's review today.
My current plan is to look for a globally installed version of wasm-bindgen that matches the dependency version if --no-installs is provided. If that cannot be found in the path, then it will fail rather than installing a new version.
If I should take a different route, let me know!

Took a swing at this today :) Let me know if you spot any problems!

@data-pup I'll have to take a look now that I'm back when I get the chance

Sounds good to me! I can also rebase this again, now that the path things from #220 have landed :+1:

Thanks for the feedback @fitzgen! I can resolve the merge conflicts today, and take care of some of your inline comments as well. I can have something EOD, since this relates to a 'Blocking Rust 2018' issue :crab:

Continuing this work in #244, because the merge conflicts got a little too drastic.


last update from main repo

Why? ;-|

You know, that I Newbie on github.
It's my mistake.
I'm sorry to trouble you

Yeah, but you don’t have to send pull request every time you try something new ;-)


Two nit-picks in README.md

[This is a cleanup change, in violation of the checklist requested, but I hope that it is uncontroversial enough to be quickly reviewed.]
Description of this change
Fix a grammar error and a spelling error in the repository's README.md

Thanks for the fixes, Janak, and sorry for the delay. I just only noticed it today.


Polymer integration

As a developer I want to use Vaadin Router with Polymer-based route components.
DoD:

all features of Vaadin Router work with Polymer-based web components
there is a demo for how to use Polymer 2 / 3 web components in a Vaadin Router app

The common DoD applies.

The current demos at https://vaadin.github.io/vaadin-router/vaadin-router/demo use Polymer.


Websocket causing Stackoverflow

Whenever i join a Aram game the Websocket causing a Stackoverflow, this does not happen when i comment socketConnection.Send($"[5, "OnJsonApiEvent"]"); out but then i can not listen to websocket events. I tried Using .NET 7, .NET 6 and .Net Core 3.1. In all cases it resulted in a stackoverflow after the champion selection

Oh okay, yea i tried fixing it by listening to process starts but the problem is this also happens on login/after the league client closing for a unknown amount of time. i might check for a fix but currently im clueless


sql: implementation of parser API in Rust

Description in proposal doc: https://github.com/OpenLineage/OpenLineage/pull/627
Signed-off-by: Maciej Obuchowski<EMAIL_ADDRESS>Closes: https://github.com/OpenLineage/OpenLineage/issues/582

Codecov Report

Merging #644 (2e8e519) into sql/common-api (4393409) will increase coverage by 1.05%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           sql/common-api     #644      +/-   ##
==================================================
+ Coverage           84.05%   85.10%   +1.05%
==================================================
  Files                  43       48       +5
  Lines                2389     2558     +169
==================================================
+ Hits                 2008     2177     +169
  Misses                381      381

Impacted Files
Coverage Δ

...egration/common/openlineage/common/sql/__init__.py
100.00% <100.00%> (ø)

integration/dagster/openlineage/dagster/utils.py
100.00% <0.00%> (ø)

integration/dagster/openlineage/dagster/cursor.py
100.00% <0.00%> (ø)

integration/dagster/openlineage/dagster/sensor.py
100.00% <0.00%> (ø)

integration/dagster/openlineage/dagster/adapter.py
100.00% <0.00%> (ø)

...ntegration/dagster/openlineage/dagster/__init__.py
100.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Error: Failed to execute 'transaction' on 'IDBDatabase'  while changing routes

While changing routes I get this error DOMException: Failed to execute 'transaction' on 'IDBDatabase': The database connection is closing.
I am using this inside web component which is then imported inside a Vue app, app/ component is not crashing or anything just seeing this as an error log.

Sounds good! Thanks.

What browser/OS are you seeing this in? When you say "changing routes," what do you mean exactly? Are you changing routes in a multi-page app or single-page app – i.e. are these actual page navigations, or in-app pseudo-navigations?
I'm not sure it helps, but you may want to look into the Page Lifecycle API. In particular, in the section on the "frozen" event, note that it recommends "Close all open IndexedDB connections." In emoji-picker-element this can be accomplished with:
document.querySelector('emoji-picker').database.close()

This worked for me. Thanks!

This does not work for me. Looks like the component gets unmounted by react before the database close function completes. Any suggestions?

@ekimber Can you call database.close() (as described above) before the component unmounts?

@ekimber Can you call database.close() (as described above) before the component unmounts?

I can call it before it unmounts, however, it is of course async, and from what I can observe, the unmount is occurring before the close promise completes

Actually that may be wrong. I tried pausing execution there but it doesn't help.
Here is the stack trace:
    at eval (http://localhost:8280/_js/compiled/cljs-runtime/module$node_modules$emoji_picker_element$database.js:4:118)
    at new Promise (<anonymous>)
    at dbPromise (http://localhost:8280/_js/compiled/cljs-runtime/module$node_modules$emoji_picker_element$database.js:4:74)
    at get (http://localhost:8280/_js/compiled/cljs-runtime/module$node_modules$emoji_picker_element$database.js:14:68)
    at eval (http://localhost:8280/_js/compiled/cljs-runtime/module$node_modules$emoji_picker_element$database.js:9:76)
    at Array.map (<anonymous>)
    at hasData (http://localhost:8280/_js/compiled/cljs-runtime/module$node_modules$emoji_picker_element$database.js:9:67)
    at checkForUpdates (http://localhost:8280/_js/compiled/cljs-runtime/module$node_modules$emoji_picker_element$database.js:23:421)```

You might need to do an unhandled rejection event listener or something.
database.close().catch(() => {}) may also work. This is a good blog post on the subject: https://jakearchibald.com/2023/unhandled-rejections/

Thanks, I managed to get rid of the warning by doing this database.close().catch(() => {})
I have to do it as soon as the component is mounted. Odd, but it still seems to function ok.


Add Volvo Cars to adopters

Signed-off-by: Emil Dabrowski<EMAIL_ADDRESS>

@stefanprodan We're really happy to hear! :D We very much enjoy working with FluxCD and really appreciate the help you guys are giving in the Slack channel!

@brovoca Thanks so much!! ❤  Any chance our community managers can chat with you or your team to hear how you're using flux and get your feedback? Please lmk and thanks again for taking the time to add yourself!! 🧸

@mewzherder Sure, I think that could be something we could arrange! 😇

@brovoca awesome! ❤  I guess I'll email you? Look for subject line "chat about Flux" I guess :D Thanks!!!


Download queue gets stuck after 3 episodes downloaded

There is an Issue I run into that happens everytime is when you queue to download an entire series, After 3 episodes are downloaded the downloads hang and never download. It would be nice if there was a fix for this issue.

I'm going to need some more details regarding this issue.
1: The link/name of series you are trying to download
2: Any logs you see after enabling debug messages in the settings

Bunnicula https://www.wcoforever.net/anime/bunnicula
Where do I my log file path to submit to?
Thanks. Forgive me because this is the first time I'm doing this type of stuff.

That's ok the series link is more than enough.
The program doesn't currently support episodes with 2 videos, but I'm working on an update and i'll see what I can do about this.
Specifically: https://www.wcofun.net/bunnicula-episode-1-2-mumkey-business-walking-fish this one right here.
and possibly others. I did notice how it hangs and stops downloading entirely.
I'll look into this.

Thank you! You are a godsend against corporations making viewing shows harder and harder! 😎✌

This has been fixed in 1.0.5
Please let me know if you still have any issues in the next week. If you don't respond, I'll close this issue.

Assuming this is fixed i'm closing the issue


Netflix vulnerability

The vulnerabilities reported by Netflix https://vuls.cert.org/confluence/pages/viewpage.action?pageId=56393752 require that grpc is upgraded to at least 1.23.0
https://github.com/grpc/grpc-go/releases
The go.mod file for grpc-health-probe points to grpc 1.17.1
Please fix

I'm bumping to 1.24.0, the go.mod looks uglier for some reason. It's not able to tidy it up to be as clean as before. I hope this doesn't cause any problems.

Many thanks

I'm always surprised to see people using this repo, as I have no idea who’s using this repo out there. :)

DO I use go get to get this change or download a new binary? - I see that there is no new release...

Ah, we need to tag a release for the binary to occur.

v0.3.1 is now released.

Thanks very mush for your attention - much appreciated


LFS: Return 404 for unimplemented endpoints

Without this change a 401 is returned for unspecified endpoints, making the LFS client ask for HTTP credentials. This behaviour was introduced with the new locking API:
https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md
git-lfs trace before and after patch:
trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload
trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify
trace git-lfs: HTTP: 401
trace git-lfs: setting repository access to basic

trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload
trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify
trace git-lfs: HTTP: 404
Remote "origin" does not support the LFS locking API. Consider disabling it with:
$ git config 'lfs.https://localhost/test/test.git/info/lfs.locksverify' false

LGTM

LGTM


Add "name" to the effective data requirements library

The result of an effective data requirements calculation is a module definition library. As a Library resource, it is subject to the lib-0 constraint on name defined in the base resource, which requires that the name element be usable as a machine-processable identifier. Set the "name" element of the resulting module definition library to "EffectiveDataRequirements" to satisfy this constraint.

This change will go into the clinical_quality_language repository and updated here once resolved

Resolved by https://github.com/cqframework/clinical_quality_language/pull/1214


Disable serialization for specific Entities

For some games you may not wish to serialize all Entities, since you may generate some of them when the game starts.
For this cases, disabling serialization of specific Entities is ideal.
There are two possible ways to go about this:

Have an internal boolean on an Entity that can be toggled via methods to set whether the Entity should be serializable or not.
Have a Component that is built into Concord and is given automatically for EVERY Entity, but may be removed by the user.

I'm gonna push for the second one because it has some other added benefits like being able to Filter serializable Entities. (It also aligns better with my proposal for #38)

I think @speakk has a possible PR for option 1?
Which most likely will have the correct logic in the World:serialize function and may be reused even if we choose to go with option 2.

I think @speakk has a possible PR for option 1?
Which most likely will have the correct logic in the World:serialize function and may be reused even if we choose to go with option 2.

Here is my PR for option 1
https://github.com/Tjakka5/Concord/pull/41

Here is my PR for option 1
https://github.com/Tjakka5/Concord/pull/41


Propagate server errors in ASGI testing

Describe the bug
I'm writing some tests with the library and I noticed that this library does not propagate the server errors like the httpx test client and hangs the test indefinitely. Call the test with some asyncio timeout solves the hang issue, but I'm still unable to see the stacktrace of the exception. The issue gets slightly worse if the exception happens before websocket.accept(): it appears that it would block on thread.join() somewhere. In Linux this can be aborted with a Ctrl-C but in Windows this is uninterruptable :(
To Reproduce
I took the sample almost as-is from the docs. The main change is that I added a 1/0 in ws_hello.
import asyncio

import httpx
from httpx_ws import aconnect_ws
from httpx_ws.transport import ASGIWebSocketTransport
from starlette.applications import Starlette
from starlette.responses import HTMLResponse
from starlette.routing import Route, WebSocketRoute

async def http_hello(request):
    return HTMLResponse("Hello World!")

async def ws_hello(websocket):
    1/0
    await websocket.accept()
    await websocket.send_text("Hello World!")
    await websocket.close()

app = Starlette(
    routes=[
        Route("/http", http_hello),
        WebSocketRoute("/ws", ws_hello),
    ],
)

async def main():
    async with httpx.AsyncClient(transport=ASGIWebSocketTransport(app)) as client:
        http_response = await client.get("http://server/http")
        assert http_response.status_code == 200

        print("connecting to ws")
        async with aconnect_ws("http://server/ws", client) as ws:
            message = await ws.receive_text()
            assert message == "Hello World!"

    print("done")

asyncio.run(main())

Expected behavior
The httpx client to propagate the error the server encountered.
Configuration
Python 3.10.4 (tags/v3.10.4:9d38120, Mar 23 2022, 23:13:41) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import starlette, httpx, httpx_ws
>>> starlette.__version__
'0.26.1'
>>> httpx.__version__
'0.23.3'
>>> httpx_ws.__version__
'0.3.0'

Thank you for the detailed and relevant bug report, @ysmu 👍  This is fixed! I'll make a release.

@all-contributors add @ysmu for bug


Vulnerability roundup 104: fossil-2.14: 1 advisory [7.5]

search, files

[ ] CVE-2021-36377 CVSSv3=7.5 (nixos-21.05)

CVE details
CVE-2021-36377
Fossil before 2.14.2 and 2.15.x before 2.15.2 often skips the hostname check during TLS certificate validation.

Scanned versions: nixos-21.05: 2262d7863a6.
Cc @maggesi
Cc @viric

Fossil is now 2.18


Add new extra handlers for the spatial editor

From https://github.com/godotengine/godot/pull/21421.

I'm not sure what's the purpose of the hashes file but it changes a lot each time anyone pushes an update, I guess it's sorting is non deterministic/system-specific.
I'd suggest to just put it in .gitignore and remove it from the repo.

Fixed conflict thanks to #34.

Thanks!


can't seem to run "python train.py"

When I am trying to run python train.py in the terminal, there is an error telling
mat1 and mat2 shapes cannot be multiplied (64x1024 and 64x2).
I am using Jupyter Notebook and have successfully downloaded and installed all the prerequisites for the code to run.
Here is also a screenshot of the error.

@YingtongDou

The shape of the first matrix should be 1024 x 64 (batch_size x emb_size), please check your code and make sure the GNN output has the above shape.

same problem. just modified the shape of mat1 using torch.t, but the training result had little classification performance.

same problem. just modified the shape of mat1 using torch.t, but the training results had little classification performance. looks like the code needs to be fixed.

Sorry for the inconvenience. The problems are fixed in the last update #9. If there are any further questions, please don't hesitate to contact us.

same problem. just modified the shape of mat1 using torch.t, but the training results had little classification performance. looks like the code needs to be fixed.

Thanks


Mt win support

There are failures on travis, because of EPEL repository does not exists, or is temporarily down.


wal: Replace promauto with injected registry

All of tsdb consistently uses an injected registry, let's stick with that pattern.
@gouthamve @krasi-georgiev @cstyan

Agreed.


Separate UI from state / network engine

I think we should move towards having jackline communicate with the user using an IPC protocol for emitting and receiving UI events.
This would enable users to make their own UIs for jackline, and make customizing the UI easier.
Some such a change would make possible:

being able to use jackline as the engine for "bots"
rapid prototyping of new protocols or UI features
graphical clients

offloading the majority of the UI work to someone else who likes writing UI code
variable-width fonts; more text on screen
inclusion in Tails and the like targeting "regular people"
prettier notifications since we can detect if the X window is currently in focus in the WM)
running the UI in an execution context that doesn't have network access (IMHO accidentally clicking links in the terminal is a bit annoying)

Making this change would require identifying the UI interaction primitives we currently rely on.
The ones I can remember off the top of my head:

Update window contents (user chat history, status window)

Scroll events (the UI should take care of linewrapping; not us)

Prompt for / receive user for input

OTR SMP
Chat message input
Account creation dialogs

Change configuration / contact settings
Presence notifications

Thoughts?

not yet in scope. there are more pressing issues. but src contains UI-independent code, whereas cli has a command-line interface.

There's huge progress being done in this direction (by switching to notty terminal library which just landed in master)... still not separate libraries, though.

I forgot message notifications as discussed here: https://github.com/hannesm/jackline/issues/118


Correct 'XCTAssertEqual(::)' argument order.

#109 moved all TensorFlow APIs from apple/swift to this repository. However, some test assertions weren't updated because the argument order of the expectEqual(_:_:) function is different from that of XCTAssertEqual(_:_:) in that expectEqual(_:_:) expected the first argument to be the expected value, while XCTAssertEqual(_:_:) expected the second argument.
Here's a concrete example of a test assertion that used the old order:
https://github.com/tensorflow/swift-apis/blob/f194110443638f9f1a989307f21e43b653a5deb0/Tests/TensorFlowTests/OperatorTests/MathTests.swift#L22
It should be changed to:
XCTAssertEqual(x.sum(), Tensor(30))

Task
Go through all tests (especially the ones in OperatorTests/) and make sure XCTAssertEqual(_:_:) arguments are ordered correctly: The first argument should be the value to be tested, and the second argument should be the expected value.

Good catch! I'll take this on tomorrow.

Thanks Anthony! If you are too busy with existing PRs, parhaps @Shashi456 could help also.

Thanks Richard, that would be great! Generally, I'll try to get as much in by Saturday because after that I am traveling to give a talk at NAACL and organize a workshop at ICML, right before proposing for my thesis :P I'll still be online after Saturday, but way busier for the next 2-3 weeks.

:o @eaplatanios All the best for the NAACL talk and ICML workshop, Absolutely amazing stuff.
and @rxwei yea alright, I'll take a look into this.

Thanks @Shashi456! :)


Disable -var and -var-file flags when running terragrunt apply with a plan file

If you run terragrunt apply <PLAN_FILE> and you use extra_arguments anywhere to pass -var-file or -var flags, Terraform will give you the error:
You can't set variables with the '-var' or '-var-file' flag
when you're applying a plan file. The variables used when
the plan was created will be used. If you wish to use different
variable values, create a new plan file.

We either need to build in a special exception for the apply command with plan files, or have some way to optionally turn of extra_arguments (--terragrunt-no-extra-arguments).

This prevents me to use terragrunt in atlantis.
I use extra_arguments to retrieve AWS account ID and region (multi-account AWS setup):
  terraform {
    extra_arguments "bucket" {
      commands = ["${get_terraform_commands_that_need_vars()}"]

      optional_var_files = [
        "${get_tfvars_dir()}/${find_in_parent_folders("account.tfvars", "ignore")}",
        "${get_tfvars_dir()}/${find_in_parent_folders("region.tfvars", "ignore")}",
      ]
    }
  }

Is there any workaround until terragrunt handles this use case?
Also, how can I help? :-)

PRs are always welcome 😃
FWIW, I'm not sure of the best way to fix this. --terragrunt-no-extra-arguments would be the easiest, but it's not clear it's the right solution (e.g., what if you want to disable -var-file arguments, but not other types?). A special case for apply seems ugly and has the same problems. Perhaps the commands list can recognize apply and apply-with-plan as separate commands? And by default, get_terraform_commands_that_need_vars() only returns apply?

Perhaps the commands list can recognize apply and apply-with-plan as separate commands? And by default, get_terraform_commands_that_need_vars() only returns apply?

Would be an option I suppose, although I understand it's not ideal because it means adding a special argument that deviates from the terraform CLI syntax.
I see that there are 2 possibilities for terragrunt apply positional arguments:  PLAN or DIR.
What about parsing the argument and drop -var and -var-file if it's not a directory?
terraform does it this way:
https://github.com/hashicorp/terraform/blob/d4ac68423c4998279f33404db46809d27a5c2362/command/meta_new.go#L152

When running terragrunt apply PLAN, get_terraform_commands_that_need_vars() should exclude apply. Again, it could be done by checking if the positional argument is a directory.

While this one actually feels like the most "correct" solution—after all, apply PLAN does NOT need vars, so this is a bug in the method—it doesn't cover the case where someone manually sets commands = ["apply"].

What about parsing the argument and drop -var and -var-file if it's not a directory?

Doing this check for all apply <ARG> calls seems like it would handle all use cases. I'm not a fan of special cases, but in this case, it's a special case in Terraform itself, so Terragrunt will need to do the same. And I think doing this automatically for users will be less error prone than having separate apply and apply-with-plan commands and having to educate users about them.

would you like a PR submitted for this?

Please and thank you! 🍺

@ldormoy Any update from your side? I'm willing to try this out :)

Hi Pawel, unfortunately no. From my side you are very welcome to give it a try! Thanks for this :-)

I stumbled upon this issue while working on a CI script with Terragrunt.
Since we were in a hurry I quickly pulled together a PR to cover this scenario as discussed in previous posts (at least I think :D )
Hope this helps.

Thanks @marcoreni !

This is hopefully now fixed thanks to @marcoreni! Give https://github.com/gruntwork-io/terragrunt/releases/tag/v0.16.13 a shot.

@brikis98 After some checks with our systems I realized that I made a wrong assumption on the check. In fact, plan file is the last parameter added to the command, not the second.
This fix will therefore work if no parameters are added (eg. terragrunt apply plan.out), but does not work if you have parameters provided in the CLI command (eg. terragrunt apply -no-color plan.out).
I'll work on this and create a new PR shortly. Sorry about that.

@marcoreni Ah, good point, I missed that too!

@marcoreni @brikis98 In terragrunt v0.17.0, I'm seeing extra_arguments passing -var-file to terraform apply even when a plan file is provided. Is there a toggle or something to enable the behavior that was fixed in the patches for this issue?

Shouldn't require anything special, so it might be a bug. Can you paste the full command and log output so we can see what's happening?

Eh, my config is a little complicated. I'll try to distill it down and see if I can reproduce it in a minimal config. About to head out of town for a few days and gotta wrap up some other things first, so probably won't get to it until next week.

We are also seeing this issue with extra_arguments.
the command: terragrunt apply plan.out
relevant log:
Running command: terraform apply -var-file=/var/lib/jenkins/jobs/JENKINS-JOB-NAME/workspace/aws/PATH/TO/TFVARS/FILE/../../../../remote-state.tfvars plan.out You can't set variables with the '-var' or '-var-file' flag when you're applying a plan file. The variables used when the plan was created will be used. If you wish to use different variable values, create a new plan file.

Hello. Having the same issue.
But I'm running terragrunt plan-all -out=plan --terragrunt-non-interactive and then terragrunt apply-all plan --terragrunt-non-interactive, so 'plan' is the file name in every folder, and I can't specify the full path for plan.
Is there a solution for terragrunt apply-all scenario?
To workaround this I specified
extra_arguments "common_vars" {
    # do not use `get_terraform_commands_that_need_vars()` here
    # as there is an issue with `apply-all` command
    # https://github.com/gruntwork-io/terragrunt/issues/493
    # https://github.com/gruntwork-io/terragrunt/issues/457
    commands = [
      "plan"
    ]

in root terragrunt.hcl file

But I'm running terragrunt plan-all -out=plan --terragrunt-non-interactive and then terragrunt apply-all plan --terragrunt-non-interactive, so 'plan' is the file name in every folder, and I can't specify the full path for plan.
Is there a solution for terragrunt apply-all scenario?

This is actually an antipattern and is not recommended. There are various scenarios where this doesn't work and you can easily shoot yourself in the foot. To understand this, consider the following scenario:
Suppose you had two modules: vpc and app. The vpc module provisions a VPC, while the app module provisions an EC2 instance and takes as input the VPC to deploy into. The app module relies on the outputs of the vpc module.
It is obvious why the plan-all => apply-all setup doesn't work in the initial state, when you have nothing deployed. You can't get a valid plan for the app module because the VPC doesn't exist.
What about after everything has been deployed and you are making changes? Suppose that you are now adding a new subnet to the VPC and want to observe how that will affect things. If you do a plan-all after the code has been modified, you will see the plan for the VPC being modified. However, you will not see any changes in the app module even if you depend on an output that will change. This is because the output doesn't change until the VPC changes are applied. So the plan is being made based on the previous state of the vpc module.

With all that said, one use case for this is if you have mechanisms for "steady state" type workflow. In this scenario, you want to continuously loop between plan-all and apply-all until no changes are being made. Locking plan files enable you to ensure that downstream changes won't be applied in the first go around, since no changes will be recorded when the plan is being made on the previous state. You do have to continuously loop between plan-all and apply-all though because the plan will change once the upstream dependencies have been applied.

Thank you @yorinasub17 for stepping into and for detailed answer.
Saying "This is actually an antipattern" are you saying about "using plan-all and apply-all"?
But what the reason to have at least apply-all then?
Yes, we're trying to build a workflow where we can put TF changes to Pull Request and then CICD pipeline will plan these changes and apply them after human approved.
And yes, we have a lot of TF folders, that's why we need Terrgrunt with its *-all functionality.
I understand your point about issue with plan-all on new infra (I read about mock so I didn't think it's antipattern if there is a solution in TG for this).
But actually we're not running TF code against new infra frequenlty, more useful - to modify existing functionality. And for case when dependency is not applied yet - I think we can deal with it by splitting into 2 PRs and deploying these changes in a sequence.
But generally, do you have any recommendations on how to build differently the workflow when you want to be able to apply the TF changes located in different folders and not with human (resolving what should be applied, and in which order) but somehow more automated and guaranteed way.
My assumption was TF+TG+CICD gives you this result. And with CICD - you still need *-all commands, what's the other way?
Thank you.

Saying "This is actually an antipattern" are you saying about "using plan-all and apply-all"?

xxx-all was a pattern that we started implementing for the use case of managing the full stack, optimized for the use case of standing up the full stack from scratch or tearing the whole stack down for testing purposes. We use apply-all and destroy-all on a day to day basis for this reason, but plan-all is not something that we use or have invested the time in to make it work.
Now taking a step back, the whole pattern around terragrunt came about because of the antipatterns of a giant terraform module. There are many reasons why a single state file for your entire infrastructure is generally discouraged (blast radius, scalability, being able to understand better, etc). OTOH, managing many modules can get difficult because you have duplicate configurations for common setups (e.g state config). Terragrunt helps avoid repeating yourself while allowing you to break up your terraform modules in to multiple state files.
Using plan-all and apply-all on a day to day basis suggests that possibly those modules should be a single unit, at which point it probably makes more sense to use terraform directly. There are edge cases where you can't do that (e.g you want different state buckets in a multi tenant scenario), but in general that feels like a design smell.

Yes, we're trying to build a workflow where we can put TF changes to Pull Request and then CICD pipeline will plan these changes and apply them after human approved.
And yes, we have a lot of TF folders, that's why we need Terrgrunt with its *-all functionality.

Unfortunately, I don't think the community has really "solved" this yet in that there is no single generic solution that will work for all cases. I think there are specific scenarios where a plan-all => apply-all sequence works, but you need to understand the implications and drawbacks to know if it will.
Your best bet is to consider the above, and design your workflows to mitigate. E.g the looping logic is one approach, investing in tooling to only run plan and apply on the infrastructure that has been touched is another, updating your pipeline to plan and apply in dependency order is also valid, or contributing to improve plan-all output to fix issues like you are seeing + a forward propagating plan would be killer!

"but you need to understand the implications and drawbacks"
I completely agree with that.
It has similar things like monolith vs. multi-services approach. It's easier to control dependencies with monolith by just compiling your project. But if you need some granularity and "dynamics" you should pay with having more complex dependencies and control them more precisely (like controlling your API contracts/endpoints).
It's clear that if you drop VNet in one TF folder, you will have some effect in another TF folder which has resources relying on that VNet.

Using plan-all and apply-all on a day to day basis suggests that possibly those modules should be a single unit
That was our option as well. But we decided to keep many folders to not have single giant tfstate file, which at least scary to lose/corrupt.

For now, we'll keep using *-all command in CICD pipeline. If we find some issues in the workflow, I will try to share them.
Thanks for you input again, @yorinasub17

Hi folks,
Unfortunetly the merged fix #577 seems to have problems with relative directories. It uses skipVars := cmd == "apply" && util.IsFile(secondArg) to check if vars need to be skipped. But when you specify the path to the plan file relatively the util.IsFile seems to fail and terragrunt passes still the -var arguments which leads to the above mentioned issue again:
How to reproduce?
terraform {
  extra_arguments "defaults" {
    commands = get_terraform_commands_that_need_vars()
    arguments = [
      "-var-file=${get_terragrunt_dir()}/../defaults.tfvars"
    ]
  }
}

terragrunt plan --terragrunt-working-dir my_module/ -out plan.out
terragrunt apply --terragrunt-working-dir my_module/ plan.out

which results in:  Error: Can't set variables when applying a saved plan
Temporarily Solution
Specifying the plan.out file as absolute path for the apply command works. Eg.
terragrunt plan --terragrunt-working-dir my_module/ -out plan.out
terragrunt apply --terragrunt-working-dir my_module/ /my/path/to/plan.out

Expectred behaviour
I expect the special treatmeant for apply with a plan to also work with a correct relative path.

Hey @kschu91 , this odd behavior had been already pointed out in https://github.com/gruntwork-io/terragrunt/issues/493#issuecomment-452086522 .
The issue may be resolved by running Abs on the last parameter in order to make it an absolute path no matter what.
I'm just not sure if there may be some unintended behavior..

Using relative paths with Terragrunt is problematic, as the source parameter results in Terragrunt checking out code to a separate  dir (in .terragrunt-cache) and switching to that as the working dir. We recommend using absolute paths when possible.


[BUG][CCI]  FAQ.md has wrong link to licence

Can I use OUI? FAQ.md  refers to  https://github.com/opensearch-project/oui/blob/main/LICENSE

instead of https://github.com/opensearch-project/oui/blob/main/LICENSE.txt

@Aigerim-ai Do you want to be assigned to this?

Hi @joshuarrrr If the issue is available, can I take it?

@joshuarrrr  Yes, thank you!

In this case, I'll give it to @Aigerim-ai, since they opened the issue.


Upgrade Triton version to 23.05

Periodical Triton version upgrade.

CI MESSAGE: [8550896]: BUILD STARTED

CI MESSAGE: [8550896]: BUILD FAILED

CI MESSAGE: [8630216]: BUILD STARTED

CI MESSAGE: [8632138]: BUILD STARTED

CI MESSAGE: [8632138]: BUILD FAILED

CI MESSAGE: [8632646]: BUILD FAILED

CI MESSAGE: [8632646]: BUILD STARTED

CI MESSAGE: [8630216]: BUILD PASSED

CI MESSAGE: [8640595]: BUILD STARTED

CI MESSAGE: [8640595]: BUILD FAILED


Temporarily only do one pass

Still under experimental flag, but this changes the catching approach to prepass.

after upgrading from canary.14 to canary.15 and above (which includes only this patch), start getting this error:
TypeError: Cannot read property 'current' of undefined
    at Object.<anonymous> (/***/node_modules/react-ssr-prepass/dist/react-ssr-prepass.development.js:842:45)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Module.require (internal/modules/cjs/loader.js:636:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/***/node_modules/react-ssr-prepass/index.js:4:20)
    at Module._compile (internal/modules/cjs/loader.js:688:30)

@sarkistlt Hiya, maintainer of react-ssr-prepass here; The lines in question seem to be these:
https://github.com/FormidableLabs/react-ssr-prepass/blob/v1.0.2/src/index.js#L20-L24
ReactCurrentDispatcher being undefined hints at a React version that's older than 16.8.0, so maybe something went wrong when you upgraded? Maybe try to upgrade at least to 16.8.0 or even better as bumped in this PR to 16.8.6.
I probably will also need to update react-ssr-prepass' peer dependencies to reflect this. I've added 16.6.0 as a minimal version before and clearly this would need some changes to support the ReactCurrentDispatcher change that I was previously unaware of.

@kitten upgrading React helped, thanks!

@sarkistlt note that you're using an experimental API that is guaranteed to break in your application between any releases.


[release/v2.6] Check if image tag is empty during export

https://github.com/rancher/rancher/issues/37738

As mentioned in your issue it would be good to check that the tag actually exists before adding to the artifact as there are other images in the list for 2.6.5 that do not exist like rancher/system-agent-installer-k3s:v1.18.20-k3s1


[Question] About Server Monitoring

Question
I have a MacOS system server and I want to monitor the usage of the system. How should I monitor them

I added Linux monitoring, but none of this information can be displayed

I added Linux monitoring, but none of this information can be displayed

hi , you can edit this monitor, and click the test button to test if available your server or the ip port username password params is right or not.


[iconography] Write down the guidelines for adding new icons

Done, can be found here: https://adevinta.zeroheight.com/styleguide/s/101119/p/258b11-icons


Support HTTP/S Source Provider

Is your feature request related to a problem? Please describe.
Currently it is only possible use git repos as a provider for sources in specmatic.json. In some cases API Specs may already be stored in a web repository which can't be accessed by Specmatic currently.
Describe the solution you'd like
Add a http provider that will allow you to specify the location of an API spec that is stored on a web server.
Describe alternatives you've considered
Alternative would be to migrate all existing API specs to a new git repository.
Additional context
N/A

@noelmccrory thanks for reporting this. It is indeed on our list. Will keep you posted.

Hi @noelmccrory, we've just implemented web sources in Specmatic. You can read about it in our documentation. It will be out soon in the next release.


fix crash

Description
Resolves #18725
I could have done a better job understanding why the code got into the state it did. But, the code blocks involved are more complex than I had time to fully understand. So, I've applied a fix that corrects the crash without understanding root cause.
Type of change

[x] Bug fix~~
[ ] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?

Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[x] I have commented my code where applicable.~~
[x] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have confirmed new and existing unit tests pass locally with my changes.
[ ] I have added new baselines for any new tests to the repo.
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Thanks for the quick fix!


Getting Error: Prune mode is incompatible with -txindex. on launching omnicore

I have just installed the new omnicore version 0.10.0 ( https://www.omnilayer.org/download.html ) and launching the app shows the the error below:

Error: Prune mode is incompatible with -txindex.

I had the previous version 0.9.0 and it was running perfectly fine as testnet wallet. Had a Mac OS upgrade and the Omnicore stopped working as it kept showing N/A for addresses and Invalid Transaction for every transaction i made. Uninstalled the previous version completely and downloaded the 0.10.0 version  ( https://www.omnilayer.org/download.html) and installed. Upon launching it getting

Error: Prune mode is incompatible with -txindex. on launching omnicore

Refer to the error here :

Machine details : Macbook Pro ( macOS big sur version 11.4 )
Any suggestions to fix this error ?

@Mith01 You can not run prune mode and txindex at the same time. As the message states, they are incompatible. The reason is that omni core needs txindex enabled in order to access / parse the omni data out of the bitcoin transactions (both current and previous historical txs).
Prune mode discards old txs which prevents omni core from having access to the data it needs to operate.
You need to disable prune mode, make sure txindex is enabled in your config file and restart omni core one time with -reindex
Also make sure you upgrade to the latest release, 0.11


Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.

backends.sqlite.tests.ThreadSharing.test_database_sharing_in_threads
backends.tests.ThreadTests.test_default_connection_thread_local: on SQLite, close() doesn't explicitly close in-memory connections.
servers.tests.LiveServerInMemoryDatabaseLockTest
test_runner.tests.SQLiteInMemoryTestDbs.test_transaction_support

Check out https://github.com/python/cpython/pull/108015.

@carltongibson Thanks for checking :+1: :hugs:


Binding Uuid in postgres fails in certain prepared statements

Bug Description
Binding Uuid in certain ways (unsure of the exact pattern) fails to prepare prepared statements.
The where clause in the reproduction will give you the following error after execution: bind message supplies 0 parameters, but prepared statement "sqlx_s_5" requires 1
This doesn't always happen as a CREATE query will work with a Uuid
Minimal Reproduction
    pub async fn patch(id: Uuid, username: Option<String>, pool: &Pool<Postgres>) -> Result<bool> {
        let mut query: sqlx::QueryBuilder<'_, Postgres> = sqlx::query_builder::QueryBuilder::<Postgres>::new("UPDATE users SET ");
        if let Some(v) = username.as_ref() {
            query.push("username = ").push_bind(v);
        }
        query.push(" WHERE id = ").push_bind(id);

        dbg!(query.sql()); // "UPDATE users SET username = $1 WHERE id = $2"

        query.build()
            .execute(pool)
            .await
            .map(|res| res.rows_affected() == 1)
            .map_err(Into::into)
    }

Test schema if you want it:
CREATE TABLE
    users (
        id UUID DEFAULT gen_random_uuid () PRIMARY KEY,
        username VARCHAR(255) NOT NULL UNIQUE,
    );

Info

SQLx version: 0.7.1
SQLx features enabled: [
"runtime-tokio",
"tls-native-tls",
"uuid",
"json",
"chrono",
"macros",
"postgres",
"migrate",
]
Database server and version: [REQUIRED] Postgres 16.1.0
Operating system: Windows 11
rustc --version: rustc 1.74.1 (a28077b28 2023-12-04)

Not sure why but i did a cargo clean and now it's working again. Maybe PEBKAC :<


Never use if(var) to check the existence

on methods
function slidePrev (speed, runCallbacks, internal) {
line 2117
if (prevSnap) {}
need to be replaced by
if (prevSnap !== undefined && prevSnap !== null) {
Otherwise, it can happen that if the prevSnap value is 0, the click on the arrow go to the first slide of the slider instead of the previous one.

Was fixed in e9ebeb0


Don't check for existing password emptyness

Pointed out by @PugaBear, it's possible for a user to have an empty password. There isn't really a need to check for password emptyness, it will simply fail with wrong old password instead. This allows users with an empty password to be created and allows them to set a password.
While I think a temporary password should be used instead, we allow creating a user with no password so we should also handle it.

@maxpoulin64, why not reversing this and instead prevent creating/using empty passwords altogether?
I don't see a good use case for that and it's much, much better security-wise IMO.

@astorije: as said on IRC, I'm not a fan of it either but I don't see any case where we'd want to block password changes when there is no existing password either. I'll mark this as not ready for merging and disallow empty password later and fix #316 while at it.

Do you think there is a value as reviewing/merging this by itself, or the changes you have here will be removed with the other fix you mention?

No, I was thinking of doing both. I consider the current behavior to be a bug, because it's possible to get into a situation where the user can't use the feature because of conflicting conditions. The user will still be able to get into this situation if the json is edited manually, but it's reasonable to disallow it through the official ways. And there really is no possible harm by not doing that check, as comparing an empty password to a non-empty password will return a failure anyway.

:+1:
The check is pretty much unnecessary here, as it compares the password either way.

👍


Keypad calls GetNetworkedInt instead of GetNWString

See this.
Fix please; I guess this is right:
local Display = self:SetNWString("keypad_display", "")

Why not fix yourself?

Why not fix yourself?

Because I am busy. Also, yet another issue is coming up in a moment..

Because I am busy. Also, yet another issue is coming up in a moment..


Gated Feedback LSTM implementation

This PR aims to add a GFLSTM implementation in contrib.
Some of the reasoning for adding a new MultiCell is explained. The new cells cannot be used without a MultiCell, since rnn doesn't know how to pass the state properly.
I am not sure whether splitting all the h's before is better or not, but I think it should use less memory overall on a high number of layers.
The state_is_tuple implementation has not been tested but follows what's being done in the current MultiRNN and LSTM cell so they should be fine.
I'm also open to suggestions for the TODO item, I'm not sure how to handle that.

Can one of the admins verify this patch?

The PR looks ok to me, but it will need tests. Please add tests to rnn_cell_test and make sure to test both with and without state_is_tuple.

Is there a guide on setting up an environment where I can test? The contributing page doesn't seem to say anything.
Also any suggestions for the TODO item and the slicing part?

I think you can just run rnn_cell_test to test locally, and then github/jenkins will test all other test for you, right? As for TODO: do you mean that MultiGFRNNCell needs to work with other cells than GFXXX cells? Maybe not, we have MultiRNNCell for that in the end. Or did I misunderstand you?

So for the TODO bit: I'm using this piece of code to test whether the cell that's passed in is a GFLSTMCell if not isinstance(cell, GFLSTMCell). However, that GFLSTMCell can be wrapper by a dropout wrapper for example and then I'd need to test cell._cell and so on. I was wondering if there's an easier way to do this. I don't know beforehand how many wrappers are around the cell. I guess I could just do if cell._cell and isinstance(cell._cell) and recurse on that but it feels yucky.
I refactored the MultiCell a bit to allow it to potentially work with other GF cells. It now passes the whole previous state along with an index to identify the input previous state for the particular cell.

Would it be possible to extend MultiRNNCell by an optional argument rather than making a separate MultiGFXXX Cell? Maybe that'll be cleaner?

Initial comment:
Don't import _linear.  Use contrib.layers.linear with the appropriate initializer instead.
Lulasz: I prefer not making MultiRNNCell more complicated, so this is a good place for this code for now.

Oh, and get rid of the state_is_tuple. That's for backwards compatibility. Assume it's true.

Ping. Any progress on this?

Not really. I was busy finishing my thesis, which I just presented today :)
Hopefully, I can finish it by the end of this or the next week, with the main issue being the tests themselves. I started using state_is_tuple in my project so that bit works. Also, still unsure of how to deal with accepting only the proper cell types.

(another friendly ping!)

Since it's been about a month since the last ping with no activity, I'm going to close this pull request. @bogdanteleaga please feel free to re-open it when you have the time!


[HxInputBase] Not binding to properties in net8's server-side rendering (SSR)

If you create a brand new net8 "Blazor Web App", and set up a Form with <HxInputText's bound to properties, none of the changes made in the HxInputText get bound to the variables - https://github.com/surgicalcoder/HavitBlazorNet8Issue/blob/master/BlazorApp6/Components/Pages/Home.razor
If you create a form (on a different page) with just InputText's, it works as expected - https://github.com/surgicalcoder/HavitBlazorNet8Issue/blob/master/BlazorApp6/Components/Pages/Textbox.razor
Replicated in https://github.com/surgicalcoder/HavitBlazorNet8Issue
Not sure if I've missed something obvious?

It seems we are missing the name attribute on underlying input (added in net8 in https://github.com/dotnet/aspnetcore/pull/47754).
Will try to fix this ASAP.

[X] HxAutosuggest
[X] HxInputTextBase (HxInputText + HxInputTextArea)
[X] HxInputDate
[ ] HxInputDateRange
[X] HxInputRange
[X] HxInputNumber + HxInputPercent
[ ] HxInputTags?
[X] HxCheckbox + HxSwitch
[X] HxSelect(Base)
[ ] HxMultiSelect

@surgicalcoder SSR forms fixed for basic input components in v4.3.2-pre1. Please give it a try.
I'll have to dig deeper to find our whether we can support more complex components such as HxInputDateRange or HxMultiSelect.

@hakenr It looks like it works!
I spent 2 days figuring out why my webapps all suddenly broke, hence why I created the simplest PoC to prove it wasn't happy. I thought I was going mad 🤣

@surgicalcoder Thanks for verification. Fix released in v4.3.2.
Will get back to the more complex components later.

For now, let's consider those two components as interactive-only (without SSR forms support).
I will file an issue to signalize the SSR compatibility of components in doc.


Add unsigned int validation

I think the next PR should split UnsignedIntegerTlv in its own file since TlvSchema file starts to be too big.
I suggest to move them to this directory, since this is Matter-specific:
/src/matter/tlv

I suggest to move them to this directory, since this is Matter-specific: /src/matter/tlv

I agree with the spirit of moving all Matter TLV related codec, parsing, and schema handling to src/matter/tlv or even src/tlv.

Merging this down to the base branch (add-tlv-schema) to be able to refactor to /tlv directory


Use a custom PostCSS plugin for expanding nested selectors for static styles

Currently we use postcss-nested to expand nested selectors. This causes a problem because it's inconsistent with the way we expand styles without extractStatic.
For example,
const cls = css`
  .some-class {
    background-color: hotpink;
  }
`

will expand to this without extractStatic
.css-hash.some-class {
  background-color: hotpink;
}

but it will expand to this with extractStatic
.css-hash .some-class {
  background-color: hotpink;
}

Maybe it could be better to fix postcss-nested or fix how emotion uses postcss-nested

@ai We don't use postcss-nested to expand selectors at runtime and we expand them differently to the way postcss-nested does. It's not really about fixing postcss-nested because emotion and postcss-nested expand them differently, neither way is necessarily wrong.

Closing since we use stylis now.


App is only scaling up not scaling down once memory consumption is below the defined policy.

I am testing my autoscaler deployment. I created the service and bounded it with an app. After defining the policy and increase the traffic load, the app is scaling up and it's not scaling down when memory usage of each instance is below the threshold defined in the policy.
The app is now running with the maximum number of instances defined in the policy.

@Nishanksingla , could you provide your policy and the current stats information of the app?
we may require more information for debugging purpose later.

Hi
Here is the policy.
{
    "instance_min_count": 1,
    "instance_max_count": 4,
    "scaling_rules": [
        {
            "metric_type": "memoryused",
            "stat_window_secs": 300,
            "breach_duration_secs": 60,
            "threshold": 10,
            "operator": "<",
            "cool_down_secs": 300,
            "adjustment": "-1"
        },
        {
            "metric_type": "memoryused",
            "stat_window_secs": 300,
            "breach_duration_secs": 60,
            "threshold": 20,
            "operator": ">=",
            "cool_down_secs": 300,
            "adjustment": "+1"
        }
    ]
}

Here are details of the app instances
state     since                  cpu    memory         disk           details
#0   running   2018-04-09T18:15:23Z   0.2%   419M of 1G     135.3M of 1G
#1   running   2018-04-10T16:12:39Z   0.1%   445.7M of 1G   135.3M of 1G
#2   running   2018-04-10T15:53:47Z   0.1%   431M of 1G     135.3M of 1G
#3   running   2018-04-09T20:02:08Z   0.1%   438.2M of 1G   135.3M of 1G

you are using metric "memoryused" which is the absolute value of used memory. And you set the lower threshold to be 10, which means scale down when used memory < 10MB. Apparently all your instances have memory used  more than 10MB

you can use metric "memoryutil" which is the percentage of the memory used / memory limt, that is what you intent to use?

Thanks, @boyang9527 for the valuable reply.
Can you please tell me where I can get information regarding other metric_types?
Is there a metric type for CPU usage?

https://github.com/cloudfoundry-incubator/app-autoscaler/blob/develop/docs/Public_API.rst

we don't support CPU now... given the CPU is shared among containers in the same cell. Using CPU usage directly will be problematic.
See more discussions here: https://docs.google.com/document/d/1PBOati9Opusfss2s7HX_Hl3D0A-SRTmmMhNk2NRCUSo/edit

there is no documentation right now except  the API doc.. will add

Hi @boyang9527
Thank you for the replies. I appreciate a lot. With memoryutil I was able to scale down the application. But the problem with using memoryutil metric is that not all the time memory utilization increases with the increase in traffic. I was testing with an application where CPU utilization was increasing with the traffic but the memory utilization was not spiking a lot thus not triggering the rules.
Pivotal autoscaler uses CPU utilization for the scale up and scale down operation. I understand from the document that you sent that CPU metric exposed by Garden/Diego/Cloud Foundry is worse but still, I believe it's a good number in the sense of giving an idea about the traffic load and taking scaling up decision.
If you know of other metric type that could be useful please let me know.
Thanks
Nishank

I don't think using the CPU utilization reported by CF to scale app is correct.  It does not indicate whether you are running out of CPU resources or not.
We will not add cpu based unless Garden adds CPU limit or we come up with a new idea to handle the weighted shared cpu strategy in CF.
You can use responsetime or throughput instead.  To enable this, you need to make sure you are using "streaming" as the method to collect metrics.  The bosh release defaults to "streaming", but just want to make sure you did not change it in your deployment manifest.
https://github.com/cloudfoundry-incubator/app-autoscaler-release/blob/develop/jobs/metricscollector/spec#L91

Thank you for the response.
Can I set policy to 2 different metrics? Like this
{
   "instance_min_count":1,
   "instance_max_count":4,
   "scaling_rules":[
      {
         "metric_type":"memoryutil",
         "stat_window_secs":120,
         "breach_duration_secs":60,
         "threshold":40,
         "operator":"<",
         "cool_down_secs":60,
         "adjustment":"-1"
      },
      {
         "metric_type":"memoryutil",
         "stat_window_secs":120,
         "breach_duration_secs":60,
         "threshold":50,
         "operator":">=",
         "cool_down_secs":60,
         "adjustment":"+1"
      },
      {
         "metric_type":"responsetime",
         "stat_window_secs":120,
         "breach_duration_secs":60,
         "threshold":7000,
         "operator":"<",
         "cool_down_secs":60,
         "adjustment":"-1"
      },
      {
         "metric_type":"responsetime",
         "stat_window_secs":120,
         "breach_duration_secs":60,
         "threshold":10000,
         "operator":">=",
         "cool_down_secs":60,
         "adjustment":"+1"
      }
   ]
}

@Nishanksingla , @rohitsharma04  ,  yes, it is true to set policies against 2 different metric type, but the scaling result depends on your application characteristics.
For above policy,  if your memoryutil is lower than <40% (i.e. not a memory intensive app), but the response time is longer than 10000 , then  the target instance number may go up and down

Thank you @cdlliuy for the reply and the adding the documents. I would definitely go through them.


[ENH] index formatted cutoff option for STEP 17 (dealing with freq deprec)

This adds an option 3 to STEP 17 on how to deal with the freq deprecation in pd.Timestamp.
FYI @khrapovs, and thanks for all your work on this which I feel has clarified a lot to me!

Partial implementation here: https://github.com/alan-turing-institute/sktime/pull/2909
(BaseForecaster sided refactor, not covering ForecastingHorizon)


Port to jbuilder

Also added compiler-libs to the META

@let-def what do you think?

Looks good to me. The main user of merlin-extend is reason, I guess they will switch to jbuilder too so that's fine.

Hmm, if that's the case then I wonder why isn't merlin-extend just part of reason?


Burst buffer path environment variables are inconsistent

$DW_JOB_STRIPED includes the "global" directory in the path.
$DW_PERSISTENT_jobname does not, so users must specify $DW_PERSISTENT_jobname/global when using persistent buffers.
Can we make the behaviour of these consistent?

They should be no need to specify /global for persistent buffers, as the mount is always global.
Why do you see the need to append /global? I am not sure that directly should actually exisit, or maybe I mounted it in the wrong place?

The global directory exists in the persistent buffer and users cannot write above that level, eg:
$ cd $DW_PERSISTENT_jobname
$ ls
global
$ touch test
touch: cannot touch ‘test’: Permission denied
$ touch global/test
$ ls global
test

ah, OK. Got it. thanks.

this should now be fixed, and the unit test was finally added in this commit: https://github.com/RSE-Cambridge/data-acc/commit/56f6096f0bef825a7d00c16477b394edbc4fd137

This has been resolved thanks.


Suggestion: use "Squash and merge" instead of a merge for pull request

Hi CNB members!
Great appreciation for the project. Thank you for contributing your time to improve everyones workflow.
I'd like to suggest an admin of this repository will disable the normal "merge button" in GitHub so that pull requests that are merged in this repository are merged as a single change and are shown on the git history of the master in the right point in time.
This makes it much easier for your users to understand the changes that happened between versions.
For example see the current changes from v0.2.0 to master:

The counter argument has always been that defaulting to squash merge "deletes" the journey that the developers working on the changes have gone. In the case of Github that is not really correct since the original PR and it's associated branch are always available with all their commits, comments and checks. Frankly it's more common that the commits are not a good representation of the parts that compose the pull request, with lots of "fix typo" and revert commits.
As a user of many OSS projects I can say that those that switched to squash merges are much easier for me to navigate and contribute to.

Thanks for the suggestion @neerfri! I'm glad that you appreciate the project.
Up to this point, our philosophy has been "don't re-write other people's work."
To me, avoiding rebasing/squashing on merge is less about preserving the user journey, and more about preserving the sanctity of original author's contributions. Consider that contributors may PGP sign their commits and/or expect that the authorship of each commit be preserved as-is. It's difficult to know what a PR submitter is comfortable with, and it isn't practical to ask each submitter.
Additionally, the CNCF requires that each commit into the project contain a DCO sign-off from whomever authored the code. I assume that these are supposed to be preserved after the merge (but I'm not certain).

@sclevine Thanks for your response.
As you can see below, kubernetes, that has similar requirements and similar mindset is using a form of squash-merge for their master:

Just to make sure I am understood. We are not expecting any developer to rebase or squash their commits. We are talking about an automatic button in GitHub that does something very similar to git merge --squash (not the same as squash via git rebase -i)
See https://maori.geek.nz/githubs-squash-and-merge-doesn-t-squash-and-doesn-t-merge-5044be7cd124 for expansion on this.
The PGP signatures will remain in the original PR and should be validated before the PR is approved for merging.
The authorship of the commit is preserved as-is, in the context of the PR.
With squash-merge, fat-finger-authorship (which sometimes happens...) will not leak to master

I am supportive of this idea. It's nice when the git history is informative.

I'd like to support this as well with the addition of stating that reverting a feature (PR) is much easier when it's only a single commit instead of a collection of commits that need to be "rolled-back".

@neerfri I changed the pack repo settings.
@sclevine Last chance to object, otherwise I will close this

I changed it back for now. I'd prefer input from the other project owners before we decide. I also think a project-wide policy makes more sense.
Personally, I still feel strongly about keeping the current policy. I don't believe that PGP signatures only exist to verify commits before they are merged, and I don't believe in re-writing other people's commit history. Git was designed to deal with non-linear history. Throwing history away because Github has poor UX for it seems unfortunate.
 You must not rebase
commits other people did. Basically, if it doesn't have your sign-off
on it, it's off limits: you can't rebase it, because it's not yours.

<EMAIL_ADDRESS>

I'm not sure I'm following the squash rebase rewrites history issue. It does not affect the the PR history, just allows for a clear and manageable master branch. Github keeps references to the PR in master commit messages (just a pr number like in comments will do). If one is curious the untouched paper trail is there, and available.

This conversation has been quiet for awhile. Currently, we don't intend to make this change. Feel free to reopen if you want to continue the discussion :)


Another hot module reloading attempt

Another attempt at https://github.com/erikras/react-redux-universal-hot-example/pull/157 but keeps the dev server in it's own process to keep server reloading as per glenjamin's suggestion: https://github.com/erikras/react-redux-universal-hot-example/pull/157#issuecomment-137583760.
I think this PR also consolidates babel configs in .babelrc as per https://github.com/erikras/react-redux-universal-hot-example/issues/53

Works for me!

Excellent work, @stevoland!! :+1: :beers:

cheers! :tada:

FYI
https://github.com/gaearon/react-transform-hmr/issues/5#issuecomment-141979096
when you'll be upgrading to react-transform-hmr there will be an error in the console


pull request for e2e test at 01/23/2017 02:26:16

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update Swift log any support

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

Pull Request Description
Update Swift log "Any" support, related issue: #1144

/run_checks

/run_checks

@ffried we can merge this, right?

@Sunnyyoung I've rebased the PR to get the latest changes to the Dangerfile to run the checks.

/run_checks

/run_checks


Simplex of size 0 still causes problems in Stan

Summary:
As per #580 problems with 0 length simplices should have been solved. This is however not the case.
Description:
I have observed two weird behaviors when trying to allocate a simplex of size 0:
a) The program throws a std::badalloc (don't have a short reproducible example)
b) Stan never stops (I do have a reproducible example)
I believe those two might be related.
Since issue #580 was reported in this repo, I am not reporting in stan, even though it might actually be a Stan problem.
Reproducible Steps:
This R code with a Stan program:
code <- "
data {
int N;
}

parameters {
simplex[N] a;
}
"

stan(model_code = code, data = list(N = 0), chains = 1, iter = 10)

Current Output:
Stan starts and never finishes.
Expected Output:
An error message claiming that I can't allocate a 0 size simplex.
Additional Information:
Provide any additional information here.
Current Version:
rstan_2.17.3

@martinmodrak --- were you going to submit a PR to fix it?  If not, we can assign someone else.
It should throw a std::domain_error in the transform.  This is an easy fix.  It can use the check_greater function with y = 0 and low the input container.

Are you referring to check_simplex()? There's already a check_nonzero_size(function, name, theta);,
I tried to replace it with check_greater(function, name, theta.size(), 0); and nothing much changed. If you point me to the correct place I could have another go.

check_simplex() is for validating arguments.  What you need is the reader code calling the transforms or the transforms themselves.  I think the problem could be fixed by adding a condition to both versions of simplex_constrain() (there's one that computes a Jacobian and one that doesn't).  The relevant file is stan/io/reader.hpp.

@bob-carpenter  Sorry for the late reply, I am not planning on working on this in the near future.

Was this fixed by https://github.com/stan-dev/stan/pull/2773?

Yes, fixed by https://github.com/stan-dev/stan/pull/2773.  Closing.


Minor cleanups in data-structure-on-rocksdb docs

btw, it is a good article. thanks for the efforts


charge_subscriptions: Report even when there are no pending charges

Coverage remained the same at 72.714% when pulling 3693cf9a9702ce058e8318625601959e8ede559b on charge-subscriptions-report-no-pending_charges into 07c63860b6924f291505c01ddf1fb0151708d01c on master.


Updates chalk to 1.0.0.

Updates Chalk to latest version, 1.0.0. See the releasenotes for the changes.
This is the first major version, and the API can now be considered stable.
This commit and PR is auto-generated. Please merge with care. My apologies if it's undesirable.
Made with ♥ by Sindre, Joshua, and all our wonderful contributors.

Coverage remained the same at 99.59% when pulling 04a0cdaf25273497b2215c51bb00c3554df864a0 on jbnicolai:update-chalk-v1.0.0 into 052b9c6a8eb664ebe19a0342f34a18f0663f7b74 on pereckerdal:master.


avoid pushing nothing to spider_seq which will cause error in plots

Should add a test for it.

@ChenZhao44  can we copy the case errored in YaoPlots to the test here?


fix golang version compare

Which issue(s) this PR addresses:

Closes #
microshift failed to build on 4.15 when recent golang bumped to 1.20.10
https://download.eng.bos.redhat.com/brewroot/work/tasks/9029/56369029/build.log

Thanks, @Ximinhan , I didn't see this PR until we had already started approving #2489 and #2495

The release-4.15 branch is still mirroring main right now, so we need a fix in a PR against the main branch. I think #2495 is a good fix, and it's on the right branch, so we'll go with that one. We hope to remove this check entirely when we move to go 1.21, since the compiler will perform the check for us then.

Closed in favor of #2495
/close


Root password is not gamer

Am I missing something thinking that the root password was supposed to be gamer? I have reinstalled and redownloaded and cannot access root so that I might repair the bluetooth sleep issue. Ive attempted sudo, I have attempted both su and sudo su. Cant change the user password either for gamer.

with the dash? I have been trying without.

Not sure it matters on this, I use it on my RHEL servers because otherwise it switches the user to root but the session and environment variables from the regular user hang around. If it's not working without it, try it with it.  But it should work without it too I think.
You're using "sudo su" and then entering "gamer" for the password? That really should be working.

Am I missing something thinking that the root password was supposed to be gamer? I have reinstalled and redownloaded and cannot access root so that I might repair the bluetooth sleep issue. Ive attempted sudo, I have attempted both su and sudo su. Cant change the user password either for gamer.

What are you trying to run?

Am I missing something thinking that the root password was supposed to be gamer? I have reinstalled and redownloaded and cannot access root so that I might repair the bluetooth sleep issue. Ive attempted sudo, I have attempted both su and sudo su. Cant change the user password either for gamer.

This is an irregular occurance but we have seen it in the past. Typically a reboot will restore functionality. We haven't been able to identify a root cause (heh) yet but it is on our radar. After the reboot the sudo password will be gamer

Closing as there is no answer

Closing as there is no answer

overlay bug?

had this same bug on recent installation

On a fresh installation there is no root password set. You will have to set it with sudo passwd root. Also be carefull setting the root password, you should probably set it to something other than gamer


C7000.OnBeforeSalesLinePriceExistsProcedure() param must be VAR

C7000
local procedure OnBeforeSalesLinePriceExistsProcedure(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; ShowAll: Boolean; TempSalesPrice: Record "Sales Price" temporary; var Result: Boolean; var IsHandled: Boolean)
begin
end;
TempSalesPrice must obviously be VAR

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


listen1: init at 2.31.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Can you build it from source?

Can you build it from source?

no, It build from AppImage

Result of nixpkgs-review pr 256639 run on x86_64-linux 1

1 package built:

listen1

You should add yourself as maintainer.

Can you build it from source?

I Can'nt build it on my NixOS

You should add yourself as maintainer.

ok， I have added myself to listen1 and anytype

Result of nixpkgs-review pr 256639 run on x86_64-linux 1

1 package built:

listen1


fix(types/ref): correct type inference for nested refs

close #11532

/ecosystem-ci run

/ecosystem-ci run

Sorry, I didn't notice that you already submitted a PR. I just created #11537. I found that in your PR, you modified the type, but the issue causing #11532 is because when we set a value to a ref, it leads to this._value = ref(xxx), and we didn't unwrap it in the getter. So, this caused the problem in #11532.

It's better to align the types with existing runtime behavior, since changing runtime behavior is actually breaking.


Reading tfrecord reaches deadock or crushes in one computer and works just fine on another.

Laptop -System information

Linux Ubuntu 16.04
TensorFlow installed with pip:
TensorFlow 1.3.0
Python 2.7.12
Spyder 2.3.8

Workstation -System information

Linux Ubuntu 16.04
TensorFlow installed with pip:
TensorFlow-gpu 1.0.0
Python 2.7.13

Problem description
I want to create and read a tfrecord file with build_cgd_dataset.py as the writer and reader_iter.py as the reader. Everything works smooth in the workstation but it reaches a deadlock or gets stuck in the laptop. The dataset are from Cornell grasping dataset.
I narrowed down the error in this special cases where it doesn't show any problem, for example:

if it reads a int64_list with one value, so a list with one elemnet
if it reads a float_list with one element

If the lists have more than one element the program freezes.

I could not reproduce on my workstation, after changing the paths in the programs to point to directories on my local workstation. To clarify, you are waiting for build_cgd_dataset.py to finish before starting reader_iter.py, right?
Try to reproduce the problem in a very simple case. Before, you were limiting the the number of elements in the lists, but instead try limiting the number of tf.train.Examples. Also try creating the tfrecords on your workstation and read them on the laptop, or vice versa. And try using the same TensorFlow versions on both, to see if the issue is caused by a certain TensorFlow version.

So, I write the tfrecord with build_cgd_dataset.py. This works always. The problem lies in reading them.
I've done some more careful tests today. I'm writing here the programs:
writer.py
import tensorflow as tf

def _int64_feature(v):
    return tf.train.Feature(int64_list=tf.train.Int64List(value=v))

def _floats_feature(v):
    return tf.train.Feature(float_list=tf.train.FloatList(value=v))

def convert_to_example():
    return tf.train.Example(features=tf.train.Features(feature={
            'a': _floats_feature(a)}))

#a = [1, 2, 3]
a = [1., 2., 3.]
def main():
    writer = tf.python_io.TFRecordWriter('tfrecord_float')
    example = convert_to_example()
    writer.write(example.SerializeToString())
    writer.close()

if __name__ == '__main__':
    main()

reader.py
import tensorflow as tf

filename = '/home/tomi/issue/tfrecord_float'
record_iter = tf.python_io.tf_record_iterator(path=filename)
example = tf.train.Example()
l = []
for record in record_iter:
    example.ParseFromString(record)
    a = example.features.feature['a'].float_list.value[:]
    print(a)

Running the reader from the terminal (and not Spyder 2.3.8) everything works as should. Running the reader from Spyder reading a list of floats crushes Spyder. With a list of integers, more often than not, the reader works fine. Maybe the issue should be closed.

I also could not reproduce running from the terminal. You should verify that Spyder is using the same versions of Python and Tensorflow as when you run from the terminal.
Marking as contributions welcome if someone can reproduce in Spyder.

Hi,
Could you verify that you're using the same TensorFlow version on both computers. Different versions might have variations in how they handle TFRecords.
Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.
Thank you!


automation(test): Triggering CI build

DO NOT MERGE
Summary
This is a PR to track test flakiness.
Issue reference
Fix KAG-3458

Will reopen this if we need to count again.


docs: installation instructions for mac drive new users into vboxfs sendfile bug

Description of problem:
The Installation on on Mac OS X tutorial instructs users to mount a local folder as a container volume for nginx to serve.
$ docker run -d -P -v $HOME/site:/usr/share/nginx/html --name mysite nginx
$ echo "my new site" > index.html
$ echo "This is cool" > cool.html
etc.

This works, but if you're a little red riding hood such as myself, you may let the whale-wolf trick you into venturing into the forrest to pick some flowers for your grandmother, or in my case overwrite one of the files with new data. This will drive you into the arms of a 5 years old vboxfs sendfile bug, causing updates to the file to show only partially, or not at all, when served via nginx. And we all know how that story ends :smile: .
docker version:
Client:
Version:      1.9.1
API version:  1.21
Go version:   go1.4.3
Git commit:   a34a1d5
Built:        Fri Nov 20 17:56:04 UTC 2015
OS/Arch:      darwin/amd64
Server:
Version:      1.9.1
API version:  1.21
Go version:   go1.4.3
Git commit:   a34a1d5
Built:        Fri Nov 20 17:56:04 UTC 2015
OS/Arch:      linux/amd64
docker info:
Containers: 12
Images: 65
Server Version: 1.9.1
Storage Driver: aufs
Root Dir: /mnt/sda1/var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 89
Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.1.13-boot2docker
Operating System: Boot2Docker 1.9.1 (TCL 6.4.1); master : cef800b - Fri Nov 20 19:33:59 UTC 2015
CPUs: 1
Total Memory: 1.956 GiB
Name: default
ID: P2Y6:MOYK:HJRI:XNP2:LAZ5:JB4C:CLHS:I56K:BEVH:WTTK:ZY3G:IGPY
Debug mode (server): true
File Descriptors: 20
Goroutines: 35
System Time: 2015-12-15T13:16:40.814333675Z
EventsListeners: 0
Init SHA1:
Init Path: /usr/local/bin/docker
Docker Root Dir: /mnt/sda1/var/lib/docker
Username: felixge
Registry: https://index.docker.io/v1/
Labels:
provider=virtualbox
uname -a:
Darwin Felix-MBP-2012.local 15.0.0 Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64 x86_64
VirtualBox:  5.0.10 r104061
Steps to Reproduce:

Follow the tutorial
Overwrite one of the html files with e.g. "echo 1235" > index.html after initially creating it
Reload the file in the browser

You may need to overwrite several times with different data to see the problem. I've also found that echo <data> > <file>  produces the problem more reliably than editing it with vim.
Ideally this bug could be fixed in VirtualBox. But short of that, I think the best solution is to create a dedicated description of this as a "known issue" somewhere, and link to that article from the installation tutorial, as well as other tutorials that make use of nginx / containers that are using sendfile.

This works, but if you're a little red riding hood such as myself, you may let the whale-wolf trick you into venturing into the forrest to pick some flowers for your grandmother, or in my case overwrite one of the files with new data.

Haha :smile_cat:

Ideally this bug could be fixed in VirtualBox. But short of that, I think the best solution is to create a dedicated description of this as a "known issue" somewhere.

Yes, we may want to add a note if many people are running into this. Perhaps it should also be mentioned here; https://docs.docker.com/machine/drivers/virtualbox/ (that file is in the "machine" repository; https://github.com/docker/machine/blob/master/docs/drivers/virtualbox.md)
Are you interested in creating a pull request to add a note in the "installation" section? The Markdown files for Mac and Windows are here; https://github.com/docker/docker/blob/master/docs/installation/mac.md and https://github.com/docker/docker/blob/master/docs/installation/windows.md

@thaJeztah sounds good. I'll send a PR tomorrow.

@felixge awesome! I see you've not contributed before; we have a contributors guide in our documentation that contains lots of useful information https://docs.docker.com/opensource/

@thaJeztah I created PR for the machine docs here: https://github.com/docker/machine/pull/2597
Once that is merged, I'll send a PR for the mac/windows docs to link to the detailed problem description.
Let me know what you think.

Thanks @felixge! Your PR in "machine" was just merged (yay!)

@thaJeztah sweet. I'll do another one for the installation tutorials tomorrow.

@felixge great! I marked this issue "claimed" for you. No hurry :smile:

This is an old issue.  I will close it as stale.


Update to Rails 4.2.1

http://weblog.rubyonrails.org/2015/3/19/Rails-4-2-1-and-4-1-10-have-been-released/

:+1:


event index attribute does nothing

Solidity has indexed event fields. This attribute does nothing in anchor. What is its intent?
Should be remove it?

Great question for @Henry-E @callensm ?


Fix last test vector

The last test vector in Appendix B.2 of draft-12 is failing. I think it might be the decoder rather than the test.

Fixed by #22


Ship is awsome. Why stop develop it?

Thanks! We did move a lot (most) of the functionality of ship into a new project at replicatedhq/kots. Which features of Ship are you interested in?


BUG: Set nperseg size to the size of an already-initialized window on periodogram

Reference issue
Fixes #14809
What does this implement/fix?

This PR makes sure that any window (array-like) that is passed as parameter to periodogram that has a length less than the input signal is used as-it-is instead of raising error. By doing so, the periodogram analysis is truncated to the size of the window
Additional information

@rgommers, thanks for the review! I've just updated the PR to reflect the first and second comments. I'll add a test once the intended changes of this PR are correct. Please let me know if the changes now reflect the bug that the OP reported

@rgommers, thanks for the detailed observations, after reading the discussion on https://github.com/scipy/scipy/issues/14809#issuecomment-1231179775, I've just added a check to verify if the window and the input sizes are the same, if not, then an exception is raised. Please let me know if the new diff is accurate, so a test can be written


Get an error for a TODO without an expiration constraint

Hello, great package!
I may have not searched correctly, but is there a way to get PhpStan fail with an error if a TODO exists without an expiration constraint?
For instance, if I write:
// TODO: write tests

I'd like to configure phpstan-todo-by in a way it will reject my TODO until I set a condition.
Is it possible?

hey,
its not yet possible. I think it would be a good idea though to optionally report invalid TODO comments.

hmm thinking again about it.. most comments usually not have a expiration and forcing people to write a expiration condition sounds like a frustrating experience

hmm thinking again about it.. most comments usually not have a expiration and forcing people to write a expiration condition sounds like a frustrating experience

Why not making this an option disabled by default, to prevent it to break PhpStan if this behavior is not wanted?

could you elaborate on how this "breaks phpstan"?

Why not making this an option disabled by default

I can think of a project in which you really want a expire condition on every comment in the codebase. this sounds like a hurdle which might prevent people from commenting stuff at all

I can think of a project in which you really want a expire condition on every comment in the codebase.

Not on every comment, but on every todo comment (@todo etc.).
While working on bigger features I often use temporary todo comments which should be fixed before merging into main. So in my main branch all todo comments should have an expiration.


refactor: messaging abstraction

PR Description
PR Checklist
Releasing

[ ] Always bump the version in shells/chrome/manifest.edn, pom.xml, and package.json. We want to keep these in sync to avoid confusion.

The refactor of messaging creates breaking changes for integrations.

@wade go through all msg/sends and try to use ::type-of-msg where appropriate


Set rustpush as Default Branch

Considering that the code for OpenBubbles is in the rustpush branch, it would be great if rustpush could be set as the default branch instead of master.

Done


Could you give me more detail information of how to use it ?

Your file report,py will close when clicked,and I can not see any more tips about whether I succeed or not ,can you give me more help ? thank you very much.

Please read the README.md, there are some guidelines in it.

Sorry to disturbe you ,but I really read the README.md totaly,but I still do not know how to use ,because it will close quickly ,when I click the report.py,without any other tips ,so I think it must have something wrong,can you help me ?

You need to first install python3 and add it to the environment variable PATH, and open cmd，follow the instruction and type command and enter to run the program

But when I get into cmd and open the python environment ,I input report.py ,it just show me"
`C:\Users\XXXX>python
Python 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:50:30) [MSC v.1933 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

report.py
Traceback (most recent call last):
File "", line 1, in
NameError: name 'report' is not defined. Did you mean: 'repr'?"`
why can't I enter it ?


Text Inputs should support more types (email, url, tel, search)

Text Inputs currently only support text and passwords.
https://modus-web-components.trimble.com/?path=/story/user-inputs-text-input--default&args=includeSearchIcon:true;maxLength:1;required:true
They should really also support email, url, tel and search - these are useful for presenting user with an optimised virtual keyboard on touch screen devices and can aid accessibility too.
REF: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types

@coliff Do we need to keep this issue?

yes, I think it's important - helps with usability and a11y for forms. It should be quite easy to do. I might even see if I can do it myself :-)


ActiveRecord::ReadOnlyError not getting raised in rails 6.1 with use_transactional_fixtures set to true

With rails 6.1, inserts or updates on replica databases are no longer raising the ActiveRecord::ReadOnlyError exception when use_transactional_fixtures is set to true. However, the same when tried in rails console or with use_transactional_fixtures set to false, raises the exception as expected. With

Hello @ritikesh
Did you tried to use rails-6-1-dev branch? https://github.com/rspec/rspec-rails/tree/rails-6-1-dev
You can follow this comment https://github.com/rspec/rspec-rails/issues/2419#issuecomment-747004546
If the problem still happens can we add a basic rails app to reproduce the issue?

Hey @benoittgt, yes, I did try this on the rails-6-1-dev branch and the issue persists. I can try sharing a basic rails app to reproduce this issue.

Given we're a wrapper around Rails helpers here, it's worth seeing if this happens in minitest too and if so raising an issue with rails instead.

Hello @JonRowe, you're right, this happens in Rails test cases(which internally uses minitest) too. I will report it on the rails repo. Because it is working alright in rails console, I was led to believe that this had something to do rspec. Thanks.

Thanks for the following @ritikesh


Multi-Server / Swarm Configuration ?

Can this setup be used to route traffic to multiple docker containers, such as a swarm setup ? From the documentation, it seems I can only get the nginx proxy to route to a single container (per domain), or am I misunderstanding ?
We are fine with only running a small handful of containers, we don't need a full swarm setup. But we do need proxying/balancing to at least two containers somehow.

Hi.
This project (JrCs/docker-letsencrypt-nginx-proxy-companion) "only" purpose is to:

enable the automatic creation of certificates from containers env var.
put them in the right place with the right name so they can be used by nginx-proxy docker-gen template.
reload the nginx proxy when needed (cert creation or renewal).

What you want to achieve depends entirely on the jwilder/nginx-proxy project, which does the actual proxying and is maintained by different peoples.
We only deal with issues related to letsencrypt-nginx-proxy-companion, so please submit your nginx-proxy issues directly to the nginx-proxy repo.

Thank you, sorry for posting this on the wrong repository.


NPC Indicators "Ignore Dead NPCs" considering Nightmare a "dead" npc when shield drops

Type
Incorrect behavior
Operating System
Windows
OS Version
W10
Bug description
I was doing some Nightmare yesterday and I noticed that the boss would no longer be highlighted after I dropped her shields to 0, the client would consider her a "dead" NPC and no longer highlight. I then tested it on Phosani and it also happened there.
Screenshots or videos
No response
RuneLite version
No response
Logs
No response

This is basically a duplicate of #12453--the NPC reaches 0 hp, but has other mechanics which prevent it from actually dying.


Never combine taskbar buttons + hide labels.

https://superuser.com/questions/947070/how-can-i-hide-taskbar-labels-in-windows-10-without-combining-icons

Closing against https://github.com/microsoft/PowerToys/issues/2343


Allow multiple updates in a time window for an Oracle

Context
The current oracle implementation uses the timeUpdateWindow for both computing the new value and triggering the swap between the current value and the next value. We need to add another time window that will allow us to update the nextValue separately from the currentValue/nextValue swap.
Details
By having two separate update intervals for the currentValue / nextValue we can better control computed values.
Alternatives
No simpler alternative.
Has the feature been requested before?
No
If the feature request is approved, would you be willing to submit a PR?
Yes

We can deprecate this one


Feature request: Rectangluar image despite circle viewport

I'm using a circle viewport because I'm showing my users' avatars in circles, and this gives the user a great UX that shows how the cropped image will look. However, in order to be future-proof, I'd very much not want to store the images as circles, but rectangles. Is there a way to keep the nice circle editing UX, but store the cropped pictures as a square without resorting to hackery with a custom circle overlay?
Thanks!

Yes :
imageCrop.croppie('result', {
                                                        type: 'blob',
                                                        quality: 0.8,
                                                        format: "jpeg",
                                                        circle:   false
                                                    }).then(function (resp) {
}

you put on circle : false

Awesome! I tried that one but probably made a typo because it didn't apply that. Tried it again and it was working. Thanks so much for taking the time Guillaume!

Thanks @cromartie1984


The output of jcxxgen is a header. Specify as such in the library.

More stricter interpretations of the library dependency check otherwise
would consider the header not to be a declared include.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report

Merging #988 (58a88c0) into master (5784ecb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   92.84%   92.84%
=======================================
  Files         323      323
  Lines       21040    21040
=======================================
  Hits        19535    19535
  Misses       1505     1505

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5784ecb...58a88c0. Read the comment docs.