Use a modular log function

This comes from https://github.com/bmrf/tron/pull/50 and more specifically this article.
I have tested a dry run of stage 0 and stage 1, but I have not completed a full run. My test was successful and there is no difference in functionality with this code change. This code change will allow the proposed change in the discussion of https://github.com/bmrf/tron/pull/50
It may be desired to replace call log.bat with something like call function\log.bat.
This type of change may also be applied to other functions, but the log function is a good start.

Let me mull this over

My concern is that the logging function is called a lot, and putting it into a separate file that must be read from disk every time may end up eating up any speed gains we get from shortening the SMART check code. Thoughts?

Honestly I think the SMART check code is one case of a potential many that Tron could run into in the future. I agree that there may be a performance hit on disk io, but loading a 3 line bat file a couple hundred times is nothing compared to some of the tools Tron already includes.

One of the main advantages is the log file being the same code across all parts of Tron. Currently the log function exists in multiple files and changing something about how Tron acts on its need to log output means changing the same code multiple times.

I agree with nemchik on the statement of "loading a 3 line bat file a couple hundred times is nothing compared to some of the tools Tron already includes." Clearly you can see that is true.
The reasoning as well, changing one file versus change multiple means less overhead when you need to make a change.

I've read all comments; thoughts so far:
I understand the argument to just have a single piece of code in a separate file to handle logging, it reduces complexity (good).
Counter-thought is that logging code doesn't change very often (if ever) and it's easy to do a find/replace across the different files if a change is needed. Thoughts on this?
So as I see it, for this change:
Benefit: No discernible benefit to end-users. Reduction of complexity for developers (us) is the primary benefit.
Penalty: Slight increase in runtime
If we do the change, where is the most logical location for function files? \resources\functions?

Re- Find/Replace: I am a huge fan, when it works, but if you (or any dev) is ever in a hurry to make a change and doesn't catch something where find/replace failed to accurately make the needed change to a file then you end up with code inconsistencies and possibly breakage for the users. An example of this would be the log code should exist in let's say 8 files, and 7 of them get changes but one is missed. If the one that was missed calls a function that got renamed or does something different than the currently desired behavior this breaks the user experience. So really this change doesn't benefit the user now, but it protects the user later.
Re- Penalty: Another thing to consider is that once the bat file is loaded from disk into the memory of the OS it will be "cached" in memory in some way and so the "couple hundred calls" I mentioned is really a lot less intense than I made it sound.
Re- Similar Changes: Yes, any function that is called multiple places in Tron could be made into a separate function.bat . There is no end-user benefit to this, but for any dev looking to help out on the project if we want to know where a function is we have one common place to look. There would not be a need to redefine any functions for use in multiple files (which is how the log function is currently setup). This opens up various functions in Tron to be available to be called anywhere during the full run. An example I can think of is set_cur_date would be usable in between the KVRT and SVRT tools, rather than just before and after.
Re- \resources\functions: I can update the PR to reflect this change.
Extra Thought: Really the goal of this change isn't to cater to the SMART check. This change is meant to resolve the issue presented by the article in the OP where CMD/BAT has trouble reusing pre-existing functions through a pipe | because certain actions in CMD/BAT end up creating a separate process that cannot see the functions from the parent process unless the functions are called from an external file. (That's my half understood explanation of the article).

That all makes sense to me. I agree. Let's go ahead and do it.
If you can update the pull request to call \functions\log.bat and create log.bat under that directory I'll go ahead and approve it.

PR updated. I tested just to make sure it's working as expected.


Improve GitHub Actions for pull requests

See https://github.com/Senzing/community-roadmap/issues/71

Pull requests:

https://github.com/Senzing/resolver/pull/105


GML import/export

Now you can export a graph to a .gml file and import a graph from one. (Good for viewing and editing graphs with a tool like Gephi)

Hi! I have text network output files in xml and would like to import them into Gephi to generate graphs and statistics. Can I convert the xml file to gexf or is there another preferred method? Any guidance is appreciated. Thanks a bunch! Ed

Hi! Thank you for your reply.  I very well may have to take that route. Thanks again and have a nice weekend!


hashtag in password -connection failed

It took me days to find out that hashtag in my mqtt password prevents from connect to the mqtt broker.

Good to know! It's probably a bug of the device firmware and not an issue of the integration. What do you think?


[642] Use UUID's for primary keys (NO NOT MERGE)

Context
https://trello.com/c/GvWFCHfI/642-add-uuid-for-all-records
Changes proposed in this pull request

Remove all exisiting migrations files
Create new migrations for each table based on schema.rb
Configure migrations to use the Postgres UUID extension
Set the primary key for each table to be a UUID including foreign keys
Change deployment config to drop, create and migrate

Guidance to review

run rake db:migrate:reset (should work without any problems)
run rspec (all the tests should pass)
run rake example_data:generate and load up the server (apart of noticing UUID based URLs, everything should continue to work as normal)

 [S] Add UUID for all records

Looks like we don't have perms to drop the database in deployed envs. From the PEN env:
/app # bundle exec rails db:migrate:reset
PG::InsufficientPrivilege: ERROR:  must be owner of database rdsbroker_768968c8_de64_4362_9ac0_a28c17b8378a
Couldn't drop database 'rdsbroker_768968c8_de64_4362_9ac0_a28c17b8378a'

Looks like we don't have perms to drop the database in deployed envs. From the PEN env:

See further comments on Trello card.


extended single-cell-rnaseq template for variable column names

allow specification of extra column names in isa-tab template

ok from my side


Update finer details of Developer Guide

Updated user stories
Standardised use cases of all commands
Fixed other finer details

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage     30.86%   30.86%
  Complexity      189      189
=========================================
  Files            61       61
  Lines          1565     1565
  Branches        172      172
=========================================
  Hits            483      483
  Misses         1056     1056
  Partials         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdafd25...6111f0d. Read the comment docs.


chore(main): release 2.6.2

:robot: I have created a release beep boop
2.6.2 (2023-08-31)
Bug Fixes

don't override Docker systemd unit file for Flatcar (#890) (50f37c7)
force redownload of Kubelet and kubectl binaries for Flatcar (#889) (8e07f9c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mesosphere/konvoy-image-builder/releases/tag/v2.6.2 :sunflower:


code remake

TODO:

Update packages (especially djs)
Change code structure
Change database structure

moving to nodecord


Guest and host Git status bar item not alligned

Testing: https://github.com/Microsoft/vscode/issues/67299
Guest:

Host:

Closing as wont fix.


[Bug]: Lora refuses to load from disk without extremely weird manipulations with file paths

Your current environment

The output of `python collect_env.py`
Collecting environment information...
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.3 LTS (x86_64)
GCC version: (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31

Python version: 3.12.6 | packaged by Anaconda, Inc. | (main, Oct  3 2024, 07:30:27) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.4.0-84-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 12.1.66
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 4060 Ti
GPU 1: NVIDIA GeForce RTX 4060 Ti

Nvidia driver version: 560.28.03
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          48
On-line CPU(s) list:             0-47
Thread(s) per core:              2
Core(s) per socket:              12
Socket(s):                       2
NUMA node(s):                    2
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           79
Model name:                      Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz
Stepping:                        1
CPU MHz:                         1226.794
CPU max MHz:                     2900.0000
CPU min MHz:                     1200.0000
BogoMIPS:                        4400.11
Virtualization:                  VT-x
L1d cache:                       768 KiB
L1i cache:                       768 KiB
L2 cache:                        6 MiB
L3 cache:                        60 MiB
NUMA node0 CPU(s):               0-11,24-35
NUMA node1 CPU(s):               12-23,36-47
Vulnerability Itlb multihit:     KVM: Mitigation: Split huge pages
Vulnerability L1tf:              Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Full generic retpoline, IBPB conditional, IBRS_FW, STIBP conditional, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT vulnerable
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm rdt_a rdseed adx smap intel_pt xsaveopt cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts md_clear flush_l1d

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==<IP_ADDRESS>
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==<IP_ADDRESS>
[pip3] nvidia-cufft-cu12==<IP_ADDRESS>
[pip3] nvidia-curand-cu12==<IP_ADDRESS>
[pip3] nvidia-cusolver-cu12==<IP_ADDRESS>
[pip3] nvidia-cusparse-cu12==<IP_ADDRESS>
[pip3] nvidia-ml-py==12.560.30
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] nvidia-nvjitlink-cu12==12.6.77
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] pyzmq==26.2.0
[pip3] torch==2.4.0
[pip3] torchvision==0.19.0
[pip3] transformers==4.45.1
[pip3] triton==3.0.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-cublas-cu12        <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cuda-cupti-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-nvrtc-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-runtime-cu12  12.1.105                 pypi_0    pypi
[conda] nvidia-cudnn-cu12         <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cufft-cu12         <IP_ADDRESS>                pypi_0    pypi
[conda] nvidia-curand-cu12        <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusolver-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusparse-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-ml-py              12.560.30                pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] nvidia-nvjitlink-cu12     12.6.77                  pypi_0    pypi
[conda] nvidia-nvtx-cu12          12.1.105                 pypi_0    pypi
[conda] pyzmq                     26.2.0                   pypi_0    pypi
[conda] torch                     2.4.0                    pypi_0    pypi
[conda] torchvision               0.19.0                   pypi_0    pypi
[conda] transformers              4.45.1                   pypi_0    pypi
[conda] triton                    3.0.0                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.6.1.dev238+ge2c6e0a82
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    NIC0    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      SYS     SYS     0-11,24-35      0               N/A
GPU1    SYS      X      PHB     12-23,36-47     1               N/A
NIC0    SYS     PHB      X

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

NIC Legend:

  NIC0: mlx5_0

Model Input Dumps
No response
🐛 Describe the bug
So, for me to load lora from disk you need to load it 4 times for some reason. This is clean env and vLLM installed from source. First I tested lora with fp8 and found that bug, but later I reproduced it with other model I can load without quantization. And in general it looks like loading issue first. I did all testing in jupyter notebook, but I can confirm that it works the same way in usual python, I managed to do the same loading process with 4 lora requests inside for loop with try/except and on 4th try it loaded correctly.
Reproducing steps. First we load and prepare prompt/parameters, verify that model loaded correctly.
from pathlib import Path
from vllm import LLM, SamplingParams
from vllm.lora.request import LoRARequest
from transformers import AutoTokenizer

llm_path = Path("/media/data/username/models/vicuna-7b-v1.5")
llm = LLM(model=llm_path, max_model_len=500, enable_lora=True, tokenizer_mode='slow')
tokenizer = AutoTokenizer.from_pretrained(llm_path, use_fast=False)
terminators = [tokenizer.eos_token_id]
sampling_params = SamplingParams(
            min_tokens=5,
            max_tokens=30,
            top_p=1.0, # 0.9
            repetition_penalty=1.0,
            length_penalty=1.0,
            temperature=0, # 1.0
            stop_token_ids=terminators
        )
prompt = "USER: 2+2 is ?\nASSISTANT:"
outputs = llm.generate(
            [prompt],
              sampling_params=sampling_params
        )
outputs[0].outputs[0].text
# ' 2+2 is 4.'

Lora load 1: giving path to directory. (You can repeat this step as many times, error stays the same)
lora_path = Path("/media/data/username/models/loras/v0_vicuna/")
lora_request_1 = LoRARequest(lora_name = "Test_1", lora_int_id = 1, lora_path = lora_path)
outputs = llm.generate(
            [prompt],
              sampling_params=sampling_params,
              lora_request=lora_request_1
        )
outputs[0].outputs[0].text
# ValueError: Unrecognized model in /media/data/username/models/loras/v0_vicuna. Should have a `model_type` key in its config.json, or con

Lora load 2: giving path to json config. Model now tries to load adapter_config as if I'm passing path to directory?
lora_path = Path("/media/data/username/models/loras/v0_vicuna/adapter_config.json")
lora_request_1 = LoRARequest(lora_name = "Test_1", lora_int_id = 1, lora_path = lora_path)
outputs = llm.generate(
            [prompt],
              sampling_params=sampling_params,
              lora_request=lora_request_1
        )
outputs[0].outputs[0].text
# NotADirectoryError: [Errno 20] Not a directory:
# '/media/data/username/models/loras/v0_vicuna/adapter_config.json/adapter_config.json'

Lora load 3: giving path to directory, again. Getting some weird assertion error.
lora_path = Path("/media/data/username/models/loras/v0_vicuna/")
lora_request_1 = LoRARequest(lora_name = "Test_1", lora_int_id = 1, lora_path = lora_path)
outputs = llm.generate(
            [prompt],
              sampling_params=sampling_params,
              lora_request=lora_request_1
        )
outputs[0].outputs[0].text
# -> 1034 assert len(running_scheduled.prefill_seq_groups) == 0
# AssertionError:

Lora load 4: giving path to directory, yes, again. Now it works.
lora_path = Path("/media/data/username/models/loras/v0_vicuna/")
lora_request_1 = LoRARequest(lora_name = "Test_1", lora_int_id = 1, lora_path = lora_path)
outputs = llm.generate(
            [prompt],
              sampling_params=sampling_params,
              lora_request=lora_request_1
        )
outputs[0].outputs[0].text
' 2+2 is 4.'

As you can see, steps 1, 3, and 4 are exactly the same. I don't know why it refuses to load before you jiggle paths like that. Want to repeat, I can confirm that on load 4 it loads lora and it works, I tested it with audio LLM with passing embeddings before and with lora it worked correctly - it processed audio embeddings which base llm was not trained for. Well, almost, there were weird artifacts with tokenizer but I'm too tired to debug that now.
Also, wanna mention that it's extremely weird that vLLM do not allow to load lora and change parameters from within python, so if I want to change alpha and load lora with different alpha I have to make a directory on disc for each set of parameters despite them having same weights.
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Facing the same issue with llama 3.1 model adapters

Adding config.json of the base model to the lora adapter path can solve the problem.
But this is not a fundamental solution.
For similar reasons, if there is no tokenizer.json in the lora adapter path
WARNING MM-MM HH:MM:SS tokenizer.py:144] No tokenizer found in your lora adapter directory, using base model tokenizer instead.
The following warning message is output.


No Normalization2D for compact_cnn?

I see that you have disabled the normalization of melspec in compact_cnn. was there any reason?

Yes, because it didn't help but hurt the performance, the difference was small though.


Some question

In the original Trades, it uses the beta to trade the adv loss and clean loss. But  I did not find beta in the code?

This code mainly involves experiments on PGD-AT. You can simply modify the code to implement TRADES referring to this draft.

This code mainly involves experiments on PGD-AT. You can simply modify the code to implement TRADES referring to this draft.

OK, This means the provided code is used for PGD-AT, not for Trades. And we can run the Original Trades with weight-decay 5e-4 to get the model against AA 53.8% .  Moreover, whether is weight decay useful for all models? When I use the Resnet18 as the target model, the impact of weight-decay is very small.

Yes, you can only change the weight decay from 2e-4 to 5e-4 in the original TRADES code. You can refer to Figure 1(a) in our paper, larger models (e.g., WRN-34-10) will be more significantly affected by weight decay.

Yes, you can only change the weight decay from 2e-4 to 5e-4 in the original TRADES code. You can refer to Figure 1(a) in our paper, larger models (e.g., WRN-34-10) will be more significantly affected by weight decay.

Thank you for the reply


Error in libpng opening png file

I'm currently getting the fatal, non-catchable error from libpng: libpng error: Not a PNG file
It looks like any tiff or jpeg image will cause this error as it's just pushing those bytes through libpng to see if it'll work; but it fails hard.
traceback:
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff3e4526e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff3e288ff in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff320251a in ??? () at /lib/x86_64-linux-gnu/libpng16.so.16
#6  0x00007ffff3204654 in png_error () at /lib/x86_64-linux-gnu/libpng16.so.16
#7  0x00007ffff320a58f in png_read_info () at /lib/x86_64-linux-gnu/libpng16.so.16
#8  0x00007ffff320ec1f in png_read_png () at /lib/x86_64-linux-gnu/libpng16.so.16
#9  0x00007ffff390c660 in capypdf::internal::(anonymous namespace)::load_png_file (f=0x555555afb990) at ../src/imagefileops.cpp:425
#10 0x00007ffff390c7ad in capypdf::internal::(anonymous namespace)::load_png_file (fname=filesystem::path "/tmp/ink_raster_jpeg_XXXXXX6C9WY2" = {...})
    at ../src/imagefileops.cpp:435
#11 0x00007ffff390d8f5 in capypdf::internal::load_image_file (fname=filesystem::path "/tmp/ink_raster_jpeg_XXXXXX6C9WY2" = {...})
    at ../src/imagefileops.cpp:575
#12 0x00007ffff3877a92 in capypdf::internal::PdfGen::load_image (this=0x555556660d10, fname=filesystem::path "/tmp/ink_raster_jpeg_XXXXXX6C9WY2" = {...})
    at ../src/generator.cpp:66
#13 0x00007ffff3937084 in capy_generator_load_image (gen=0x555556660d10, fname=0x555556661620 "/tmp/ink_raster_jpeg_XXXXXX6C9WY2", out_ptr=0x7fffffffc370)
    at ../src/capi.cpp:330
#14 0x00007ffff6b13f6a in capypdf::Generator::load_image (this=this@entry=0x7fffffffc9b0, fname=<optimized out>)
    at /home/doctormo/.build/inkscape/deps/include/capypdf-0/capypdf.hpp:669
#15 0x00007ffff6b1364e in Inkscape::Extension::Internal::PdfBuilder::Document::load_image

I made a quick fix to use setjmp/longjmp. If this fixes it for you feel free to close the issue, otherwise post whatever is the new error message it prints ous.

The error has changed, but there is still a crash:
Before

sRGB Jpeg - Crash
CMYK jpeg - Crash
Icc Tiff - Crash
sRGB PNG - Works

After

sRGB Jpeg - Works
CMYK jpeg - Blank, but no crash
Icc Tiff - Crash (see below)
sRGB PNG - Works

libpng error: Not a PNG file
libpng error: Not a PNG file
Unsupported image file format: /tmp/ink_raster_jpeg_XXXXXXSV74Y2

** (org.inkscape.Inkscape:654299): WARNING **: 13:58:10.489: Could not add image to PDF: Failed to load data from file.
libpng error: Not a PNG file
Segmentation fault (core dumped)

(gdb)
#0  __longjmp () at ../sysdeps/x86_64/__longjmp.S:147
#1  0x041e69afe4b9d070 in ??? ()

Could you post just the unaltered TIFF file?

Actually never mind, should be fixed now.

Confirmed working. I'll close this one. Want me to make a fresh report with the unsupported files attached?

Is it something else than CMYK jpegs? Because those are jank and I don't really know why.

The tiff with an icc:
image.zip

For cmp, this is the CMYK jpeg

One thing I had thought was that the jpegs might be getting broken by the PDF's own lack of profile information. The output from scribus tends to make a cmyk profile with a flat definition in the header, but capypdf wouldn't do that when I tried.

That was the case, but I changed it recently so the internal icc profile is extracted and used in PDF. In my testing Scribus converted cmyk jpegs into three channel ICC RGB jpegs. Which is not efficient as that has to re-encode the entire image.

At least in that case it's theoretically possible to get the CMYK values back out at print time, by using the same lossless rendering intent (assuming the RGB gamut is bigger, which it usually is) and that's fine for photographs and things like that. But I bet a lot of folks would be surprised they loose control over the black channel if it's a logo or something else like that.

It turns out things are complicated and broken due to legacy reasons.
I made the code invert all CMYK channels and it worked with all test images I had available.

Thanks. That is a 100% success, at least on my tests. Likely I will expand these tests as user errors come in. One of the main goals I have to think about is how conversion of filters will work, since converting them to CMYK rasters will require rendering them out in CMYK channels, something inkscape (cairo) can't do yet. At least I'll know that it's not the raster format itself that's the cause of any difficulty!


[v0.6.5] Error render of "page" failed

Hi! After upgrading all modules with hugo mod get -u, I've noticed that revision v0.6.5 is breaking hugo server, that won't start any more. Downgrading revision to v0.6.4 fixes the problem. See the error messages below.
ERROR render of "page" failed: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/blog@v0.37.0/layouts/blog/single.html:2:5": execute of template failed: template: blog/single.html:2:5: executing "main" at <partial "hb/modules/blog/single" .>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/blog@v0.37.0/layouts/partials/hb/modules/blog/single.html:53:12": execute of template failed: template: partials/hb/modules/blog/single.html:53:12: executing "partials/hb/modules/blog/single.html" at <partial "hugopress/functions/render-hooks" (dict "Name" "hb-blog-post-content-end" "Page" .)>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hugomods/hugopress@v0.5.0/layouts/partials/hugopress/functions/render-hooks.html:34:8": execute of template failed: template: partials/hugopress/functions/render-hooks.html:34:8: executing "partials/hugopress/functions/render-hooks.html" at <partial .partial $ctx>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/blog/modules/revision@v0.1.0/layouts/partials/hugopress/modules/hb-blog-revision/hooks/hb-blog-post-content-end.html:1:4": execute of template failed: template: partials/hugopress/modules/hb-blog-revision/hooks/hb-blog-post-content-end.html:1:4: executing "partials/hugopress/modules/hb-blog-revision/hooks/hb-blog-post-content-end.html" at <partial "hb/modules/revision/index" .Page>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/revision@v0.6.5/layouts/partials/hb/modules/revision/index.html:17:21": execute of template failed: template: partials/hb/modules/revision/index.html:17:21: executing "partials/hb/modules/revision/index.html" at <.IsContentAdapter>: can't evaluate field IsContentAdapter in type *source.File
ERROR render of "page" failed: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/docs@v0.17.3/layouts/docs/single.html:24:13": execute of template failed: template: docs/single.html:24:13: executing "main" at <partial "hb/modules/docs/doc" .>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/docs@v0.17.3/layouts/partials/hb/modules/docs/doc.html:6:3": execute of template failed: template: partials/hb/modules/docs/doc.html:6:3: executing "partials/hb/modules/docs/doc.html" at <partial "hugopress/functions/render-hooks" (dict "Page" . "Name" "hb-docs-doc-content-end")>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hugomods/hugopress@v0.5.0/layouts/partials/hugopress/functions/render-hooks.html:34:8": execute of template failed: template: partials/hugopress/functions/render-hooks.html:34:8: executing "partials/hugopress/functions/render-hooks.html" at <partial .partial $ctx>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/docs/modules/revision@v0.1.0/layouts/partials/hugopress/modules/hb-docs-revision/hooks/hb-docs-doc-content-end.html:1:4": execute of template failed: template: partials/hugopress/modules/hb-docs-revision/hooks/hb-docs-doc-content-end.html:1:4: executing "partials/hugopress/modules/hb-docs-revision/hooks/hb-docs-doc-content-end.html" at <partial "hb/modules/revision/index" .Page>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/revision@v0.6.5/layouts/partials/hb/modules/revision/index.html:17:21": execute of template failed: template: partials/hb/modules/revision/index.html:17:21: executing "partials/hb/modules/revision/index.html" at <.IsContentAdapter>: can't evaluate field IsContentAdapter in type *source.File
ERROR render: failed to render pages: render of "page" failed: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/blog@v0.37.0/layouts/blog/single.html:2:5": execute of template failed: template: blog/single.html:2:5: executing "main" at <partial "hb/modules/blog/single" .>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/blog@v0.37.0/layouts/partials/hb/modules/blog/single.html:53:12": execute of template failed: template: partials/hb/modules/blog/single.html:53:12: executing "partials/hb/modules/blog/single.html" at <partial "hugopress/functions/render-hooks" (dict "Name" "hb-blog-post-content-end" "Page" .)>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hugomods/hugopress@v0.5.0/layouts/partials/hugopress/functions/render-hooks.html:34:8": execute of template failed: template: partials/hugopress/functions/render-hooks.html:34:8: executing "partials/hugopress/functions/render-hooks.html" at <partial .partial $ctx>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/blog/modules/revision@v0.1.0/layouts/partials/hugopress/modules/hb-blog-revision/hooks/hb-blog-post-content-end.html:1:4": execute of template failed: template: partials/hugopress/modules/hb-blog-revision/hooks/hb-blog-post-content-end.html:1:4: executing "partials/hugopress/modules/hb-blog-revision/hooks/hb-blog-post-content-end.html" at <partial "hb/modules/revision/index" .Page>: error calling partial: "/modules/modules/filecache/modules/pkg/mod/github.com/hbstack/revision@v0.6.5/layouts/partials/hb/modules/revision/index.html:17:21": execute of template failed: template: partials/hb/modules/revision/index.html:17:21: executing "partials/hb/modules/revision/index.html" at <.IsContentAdapter>: can't evaluate field IsContentAdapter in type *source.File

My apologies, it's a backwards compatibility issue, which calling newer methods in older Hugo version, should be fixed in<EMAIL_ADDRESS>

Thanks! It's now working fine again. :smile:


Exclude attribute from api response

Is your feature request related to a problem? Please describe.
There should be a way to mark fields as private and not return them in get calls.
Describe the solution you'd like
There should be a metadata field to indicate a field as private.
Describe alternatives you've considered
a change to iter should be made. Maybe change __iter__ to asdict from dataclasses, this way we can still generate dict's with full fields. Or use as_dict as a private method that generates the full representation.
Additional context
Add any other context or screenshots about the feature request here.

I believe this shouldn't be closed...


Add MatchCardinalityImageToImageMetricv4 for registration of labelmaps

Description
Currently, there is no Match Cardinality metric compatible with the "v4" registration framework.
I can use the mean square metric for binary mask registration, but to register a labelmap with many labels the difference between label 1 and 2 is penalized less than the difference between 1 and 500. This can be managed to some extend via remapping labels and for a few labels, but does not scale.
I could one-hot encode the labelmap and use the mean square metric, since it supports vector images. This is not so bad, but probably increases memory consumption and increases the metric computation time linearly with the number of labels. Currently this workaround is not supported by the Python wrapping.

Expected behavior
It would be nice if there was a MatchCardinalityImageToImageMetricv4, i.e. a match cardinality metric for the v4 registration framework.
Only the v4 registration framework is supported by SimpleITK, so adding this metric would benefit SimpleITK users (see https://github.com/SimpleITK/SimpleITK/issues/1896).
As a workaround (for python users), wrapping MeanSquaresImageToImageMetricv4 for vector real types ({WRAP_ITK_VECTOR_REAL}) would be needed to use one-hot encoded labelmaps.
CORRECTION: Looking at VectorImageToImageMetricTraitsv4, it seems the framework must be compiled for a fixed number of components/channels.

Actual behavior

It does not exist
The metric (and vectorimage + mean square metric) workaround is not available in ITK Python and SimpleITK

Additional Information

I had a look into writing this new class based on the MeanSquaresImageToImageMetricv4, but am unsure how the moving image gradient should be handled.

Adding the explanation why the moving image gradient is needed from

Could the desired functionality be achieved by converting the label images to labeled pointsets?
https://insightsoftwareconsortium.github.io/ITKDoxygen/classitk_1_1LabeledPointSetToPointSetMetricv4.html

@cookpa Maybe, but how can I convert the labelfield to a labeled pointset? If there is such a filter, is it exported to Python (it looks like it is not available in SimpleITK)?
For the actual implementation:
Should I subsample the labeled pointset, i.e. convert only a percentage of the labelfield to points (to reduce memory/increase performance)?

Sorry for being slow @dyollb. I learned about the label point set metric from ANTs, but I'm not super familiar with the implementation. It just sounded conceptually similar to what you're trying to do with matching cardinality. I'm not sure about Python coverage. I looked at SimpleITK and I don't think any point set registration is available there.
In ANTs, labeled points are directly transformed from an index to physical space (code). Optionally, the labels can be downsampled with a LabelContourImageFilter first, so you only have to deal with the boundary points.

Unfortunately, I still have not tested the suggestion by @cookpa (and it might be good since it would weight the labels by surface area instead of volume. It might also be more robust to bad initialization/poor overlap).
But after looking at the GenericLabelInterpolator module I realized it provides an approach that could be used to implement the MatchCardinality metric using label adaptors (one image adaptor for each label):
https://github.com/InsightSoftwareConsortium/ITKGenericLabelInterpolator/blob/master/include/itkLabelImageGenericInterpolateImageFunction.hxx


Added logic to down sample high depth windows and select individual chromsomes

Hello Graham (et al),
This is Nick a postdoc in the Tishkoff lab. You might remember me as we chatted briefly earlier this winter when you visited Penn.
Anyway, the RNAseq libraries I've been processing with WASP have some very high depth regions. When find_intersecting_snps.py hits one of these regions the memory requirements quickly blow up the analysis. To deal with these regions I've modified WASP so that if a window exceeds more than a user defined number of reads no more reads are added to the window (e.g., downsampling that window). I've also added an option to run WASP on a user defined chromosome and some rough logic to handle sorted BAM files.
Feel free to incorporate these updates if you think other users will find them useful. You may want to double check my downsampling logic as getting Bam_scanner to place nice with main() was a bit tricky.
Cheers,
Nick

I think the biggest problem with memory usage was recursion depth. This has now been solved in WASP release v2 through the addition of --max_seqs and --max_snps arguments. In addition it is now possible to reduce recursion depth by only considering haplotypes that are present in the samples (rather than all possible allelic combinations from overlapping SNPs).


Make it possible to consume different network (e.g. Ropsten testnet)

It might be useful for developers to have access to the Etherscan Ropsten API.
Base URL is https://api-ropsten.etherscan.io/api
Documentation can be found here:
https://ropsten.etherscan.io/apis

Yeah, they incorporated those API functionality since I've used this.  It would be good to include them.

#41 is working on getting ropsten in there


Consume the involvement API

In this pull request, I added two modules for consuming the Involvement API to get and post the likes and comments

Hello @tjay1760
Great work adding the involvement API. Both like and comment is working well. The is nothing more to say than it is time to merge :1st_place_medal:


Institution list index out of range, a test scenario

>>> import yfinance
>>> t=yfinance.Ticker('BRK-B')
>>> t.info
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/Users/westerhoff/Developer/lucrum/.venv/lib/python3.7/site-packages/yfinance/ticker.py", line 138, in info
    return self.get_info()
  File "/Users/westerhoff/Developer/lucrum/.venv/lib/python3.7/site-packages/yfinance/base.py", line 415, in get_info
    self._get_fundamentals(proxy)
  File "/Users/westerhoff/Developer/lucrum/.venv/lib/python3.7/site-packages/yfinance/base.py", line 286, in _get_fundamentals
    self._institutional_holders = holders[1]
IndexError: list index out of range

The base code needs an error handler for cases where there are no institutional holders. There are some PRs that could solve this issue, but while they are not merged, you can install my fork (don't forget to uninstall yfinance and restart the runtime):
pip uninstall yfinance
pip install git+https://github.com/rodrigobercini/yfinance.git
I've just tested for BRK-B and it's working fine. Cheers!


Bump supported version to 3.6

could this please be merged now that 3.6.0 is officially released. It's the only dependency who can't be installed because version mismatch right now 💕


Precache our Dart dependencies in Travis

Fixes https://github.com/flutter/flutter/issues/2737

LGTM

Closing this PR for now. This was not particularly successful.


Update Template Names (Remove Basic)

We use a templated system for our products which can combine several asset types into one product.  This is not very obvious at present as there are only bare minimum templates in place with the exception of Illustrated Text which combines two asset types.
Right now we use template names for the asset types to help delineate what the user is purchasing.  The qualifier Basic  is prepended to help denote the template (and not the product itself), but as a result, it appears to qualify the product inadvertently.

I have updated the names in the database and will update on the next deployment


BlobServiceClientTest.Statistics failing live test with GeoReplication.LastSyncTime.HasValue() returning false

Live test failing on Validate Win_x86_with_unit_test and Validate MacOS_x64_with_unit_test:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=617252&view=logs&j=ddb28780-e8af-530a-eff5-5360f22a15cb&t=2d6865e5-8b1d-55bc-bd31-c956ff709149&l=118
120: [ RUN      ] BlobServiceClientTest.Statistics
120: D:\a\1\s\sdk\storage\azure-storage-blobs\test\blob_service_client_test.cpp(326): error: Value of: serviceStatistics.GeoReplication.LastSyncTime.HasValue()
120:   Actual: false
120: Expected: true

cc @Jinming-Hu

Does it always fail or only fail occasionally?

Can anybody identify what kind of storage accounts are being used for this test?

Maybe @katmsft knows those details since he worked on setting up the daily live tests

Maybe @katmsft knows those details since he worked on setting up the daily live tests

Okay then, assigned to @katmsft

Please reference this doc, LastSyncTime can be empty in some scenarios, the test case shouldn't treat it as a non-empty value by default.

Please reference this doc, LastSyncTime can be empty in some scenarios, the test case shouldn't treat it as a non-empty value by default.

then i'm gonna fix it


No notifications until app is opened

I only get notifications about new emails after I open the app. Why not get notifications while app is in dock unopened?
Inboxer 1.0.1
Electron 1.7.9
darwin x64 17.3.0

Is this still an issue with latest version?

I want to close this project. Take a look at the explanation: #101
If you still need this project, please, fork the repo.


Notifications merge master

@zalun r? and merge if ok

It's merged isn't it?
pt., 29.04.2016, 20:20 użytkownik Harald Kirschner<EMAIL_ADDRESS>napisał:

@zalun https://github.com/zalun r? and merge if ok
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/zalun/platatus/pull/1#issuecomment-215837537


Make kind create cluster --image X kustomizable

Because the used version of kind created 1.25 kubernetes clusters where PSPs are not supported anymore - the CRD is not present - and this causes our older installations to fails.

Tested with: https://github.com/giantswarm/flux-app/pull/145


Show decisions if user is not logged in (--> Show register / login buttons or just enter username and play without an account)

https://github.com/sopra-fs24-group-41/sopra-fs24-group-41-client/commit/8ecdd3320618d0264e6db858145504f182ab8f68


cd tab completion not working

Category

[ ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[x] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

For some reason, cd <tab> is not auto-complete for me. I am running on a linux terminal X11-forwarded to a Windows machine.
fzf version is 0.16.6.
I have narrowed down the problem to these lines in shell/completion.bash:
# Directory
for cmd in $d_cmds; do
  _fzf_defc "$cmd" _fzf_dir_completion "-o nospace -o plusdirs"
done

Commenting them out gives me back the regular tab autocompletion behavior.
Please let me know if there's some way I could debug this further.

You should cd **<tab> I guess?

I'm not sure what you mean. cd foo<tab> should match any file/ directory that starts with foo.

Oh sorry, I guess I now understand what you meant. You are saying that the normal, default bash behavior of autocompletion does not work after installing FZF, right? That sounds strange.

@dqgthb  yes that's exactly what I meant. It is very strange to me too.

Is that only for cd, or for others as well such as vim foo?

What's the output of complete | grep cd$?

It is for others as well, not just cd.

Hmm yeah I'm not sure - the one I have is bash version 4.3.42(1)

Sorry for the slow response. I needed to wait and try it on the work
terminal where this is happening.
If I paste the command on the shell directly, tab completion for cd works
again.
 Still no plusdirs?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/junegunn/fzf/issues/872#issuecomment-288904726, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABk3c7hcp8LvibxL758a1TdCvN82lBPjks5roxZggaJpZM4MbQjW
.

Then it's probably you have some other plugin or configuration that are interfering with completion. Can you check if you can still reproduce the problem with a vanilla bashrc that only loads fzf and nothing else?

Here's what I just tried:
:; bash --noprofile --norc
# cd tab-completion works
:; source ~/.fzf.bash
# now tab-completion does not work
:; cat ~/.fzf.bash
# Setup fzf
# ---------
if [[ ! "$PATH" == */home/tnguyen14/.fzf/bin* ]]; then
  export PATH="$PATH:/home/tnguyen14/.fzf/bin"
fi

# Auto-completion
# ---------------
[[ $- == *i* ]] && source "/home/tnguyen14/.fzf/shell/completion.bash" 2> /dev/null

# Key bindings
# ------------
source "/home/tnguyen14/.fzf/shell/key-bindings.bash"

I'm as clueless as you are. You're getting different results when you run complete -o nospace -o plusdirs -F _fzf_dir_completion cd manually and when it's run by completion.bash. 😕

I have this exact same issue since a few days.
As soon as this line is executed:
[[ $- == *i* ]] && source "$HOME/.fzf/shell/completion.bash" 2> /dev/null

tab completion stops working.
On an older system with bash 3.2.25 everything is still working.
When using putty from Windows to the Linux-system tab completion is still working.
This is the only bash plugin installed.
Running complete -o nospace -o plusdirs -F _fzf_dir_completion cd does not change anything, tab completion is not working.
System:
Red Hat Enterprise Linux 7.2
bash 4.2.46

Hmm, I can't seem to reproduce the issue on Centos 7. I used this Dockerfile to set up the environment.
FROM centos:7

RUN yum -y update
RUN yum -y install git vim
RUN git clone --depth 1 https://github.com/junegunn/fzf.git ~/.fzf && \
    ~/.fzf/install --all
WORKDIR /usr/

I don't know what the differences between RHEL7.2 and Centos 7 (version?) are or how the Docker environment is different to a real installation.
fzf has just been uninstalled and reinstalled from scratch and the issue still exist.
What do you suggest for debugging completion.bash ?

Here you go:
> complete | grep cd$
complete -o nospace -F _fzf_dir_completion cd

this is with latest status on the master branch. Tab completion is not working.

@ezschemi Does the output of complete | grep cd$ change when you manually execute the complete command?
complete -o dirnames -o nospace -F _fzf_dir_completion cd

If it doesn't, do you have any clue why it's not correctly applied to your system? Since I can't reproduce the problem locally, I need your assistance on this.

It does change:
> complete | grep cd$
complete -o nospace -F _fzf_dir_completion cd
02:36:38 /home/ezschemi
> complete -o dirnames -o nospace -F _fzf_dir_completion cd
02:37:19 /home/ezschemi
> complete | grep cd$
complete -o dirnames -o nospace -F _fzf_dir_completion cd

but tab completion still does not work.
Also note that tab completion does not work for commands like ls or cat, not just cd.

Okay, so it does change when you do it manually, but it doesn't change when it's called within completion.bash script? Strange, right? Can you help debugging the issue?

Sure I can help. I have never debugged a bash script before though. What do you want me to do?
Let me see if I can quickly create a VM with RHEL 7.2 for you with remote access. Then you can debug it. Might be more efficient...

I got unset tab complete not working.
Tested in Gentoo & Arch

I am having the same issue as @ezschemi mentioned. when I run complete | ag cd$ I get the output
complete -o dirnames -o nospace -F _fzf_dir_completion cd

If I manually change it to complete -o bashdefault -o default -F _fzf_dir_completion cd that fixes it. For now that is going to be my workaround until this issue is resolved.
System:
Suse Linux
bash 4.4.0

I'm having same problem.
I have tried with only this line
[ -f ~/.fzf.bash ] && source ~/.fzf.bash
My bash version is 4.3.48.
The output of
complete | grep cd$ is
complete -o nospace -F _fzf_dir_completion cd

@junegunn You need to look at the problem from this angle, maybe.
I found out that the problem is with tmux. When I'm outside tmux, inside neovim's terminal, tab-completion works normally. But when I'm inside tmux, it doesn't work. So, there must be something wrong with tmux.

I'm on CentOS 7.5, having the exact same issues as mentioned above.
 What happened?

Just for the sake of it, just tried complete | grep cd$ under various versions of bash (3.2.53(1)-release and 4.4.23(1)-release), under screen and under tmux (with the latest fzf). The result was always the same:
~> complete | grep cd$
complete -o dirnames -o nospace -F _fzf_dir_completion cd

@enanajmain

I stopped using fzf for this issue

That doesn't make sense to me as you can easily opt-out fuzzy completion during the installation process.

How do I opt-out fuzzy completion?

you can easily opt-out fuzzy completion
I installed it with vim, so I didn't get the yes/no options that I got today when I installed it using git. I guess it was my bad.

FYI, install script provides flags (see ./install --help) for non-interactive installation.
# All but fuzzy completion
./install --all --no-completion

# Just download the binary, and nothing else
./install --bin

Ya, changed my init.vim. Thanks.

I am experiencing this same issue running a vanilla .bashrc with only source $HOME/.fzf.bash.
Running on CentOS Linux release 7.5.1804 with GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu). Interestingly, the issue only occurs using Gnome Terminal (3.22.1) or Xfce terminal, in Xfce-4, and not via SSH or with XTerm.

I had same issue on bash, and finally figured out (at least in my case) it's related to the location fzf.bash get sourced, at the end of my default .bashrc, there are some stock completion like below erased fzf completion, after moving fzf bash source after this fix the issue.
.bashrc:
source fzf.bash # was sourced here and not working!
if ! shopt -oq posix; then
if [ -f /usr/share/bash-completion/bash_completion ]; then
. /usr/share/bash-completion/bash_completion
elif [ -f /etc/bash_completion ]; then
. /etc/bash_completion
fi
fi
source fzf.bash # move to here works!

OK running on Mac with homebrew and I discovered that for me, it has to go to the BOTTOM of ~/.bashrc. I think this is because there are some completions that are overwriting. A quick look at the bash.completion script makes it hard to figure out what is going on here, but basically the shortcuts seem to work anywhere, but the ** completion only works when it behind all the other completions. I have to have it after the bash completion installation.
This probably related to me installing bash_completion and not bash_completion@2 as described by https://docs.brew.sh/Shell-Completion, but for v1 on bash 5.x this does work
source "$(brew --prefix)/ext/bash_completion"
[ -f ~/.fzf.bash ] && source ~/.fzf.bash

Hey just a note my cd complete reads as complete -o nospace -v -F _fzf_dir_completion cd and works however you might want to try switching the trigger from ** to ^^ or ~~ i believe your shell options (shopt) are causing bash ti interpret the ** as a glob pattern and not a trigger in-fact i was able to reproduce by set -o posix
Try set +o posix and that should fix your issue if im correct posix

Ok what I see is that if I don’t put it after the bash completion that there is no FSD complete for cd at all. They are there for other commands like vim.
So seems like bash completion is overwriting the fzf completions for fzf
Sent via Superhuman iOS<EMAIL_ADDRESS>)
On Wed, Nov 4 2020 at 12:20, Derek <<EMAIL_ADDRESS>> wrote:

Hey just a note my cd complete reads as complete -o nospace -v -F
_fzf_dir_completion cd and works however you might want to try switching
the trigger from ** to ^^ or ~~ i believe your shell options (shopt) are
causing bash ti interpret the ** as a glob pattern and not a trigger
in-fact i was able to reproduce by set -o posix
Try set +o posix and that should fix your issue if im correct posix
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
https://github.com/junegunn/fzf/issues/872#issuecomment-721954161 ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AANTCR2YIMFEKQJIJWLQI5DSOGZR7ANCNFSM4DDNBDLA
).

Hmm maybe its a separate issue i found then because the only way i could reproduce is (while working) set -o posix then it stopped working or does set spawn a new environment i had a script for a while that was on / off switch for environmental variables that broke fzf completion would unset some of the completion variables try adding an echo “$SHLVL” before and after both the fzf source and the bash complete source will help narrow down how the environment is being effected.

@richtong

it has to go to the BOTTOM of ~/.bashrc. I think this is because there are some completions that are overwriting

That's correct. The fzf completion should be loaded at the end. The completion script of fzf is smart enough to keep the previous completion function as the fallback, but you can't expect the other scripts to do the same.
@rayiik Thanks for trying to help, but @richtong already found the right answer.

It probably should be documented somewhere. Or the installer script might add as a comment when it sticks it into the profile :-)
Sent via Superhuman iOS<EMAIL_ADDRESS>)
On Thu, Nov 5 2020 at 00:54, Junegunn Choi <<EMAIL_ADDRESS>> wrote:

@richtong ( https://github.com/richtong )

it has to go to the BOTTOM of ~/.bashrc. I think this is because there are
some completions that are overwriting

That's correct. The fzf completion should be loaded at the end. The
completion script of fzf is smart enough to keep the previous completion
function as the fallback, but you can't expect the other scripts to do the
same.
@rayiik ( https://github.com/rayiik ) Thanks for trying to help, but @richtong
( https://github.com/richtong ) already found the right answer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/junegunn/fzf/issues/872#issuecomment-722237807 ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AANTCR7DLJDCD7NVEBJM2BLSOJR5JANCNFSM4DDNBDLA
).

FWIW, @rayiik gave the clue I needed.  I was playing with various shopt glob settings and discovered nullglob will break completions.  Handy for scripts but a bad idea for interactive login shells.


The average distance calculated is distorted to some extent due to false positives.

This has been resolved by the solution of issue 101. Average distance calculation has been rendered useless due to more advanced methods


Vulnerability through bundled dependency got > cacheable-request > http-cache-semantics

There is a vulnerability in http-cache-semantics.
Having a bundled dep seemingly makes it impossible to override the vulnerable http-cache-semantics package version (I could be wrong, but I can't see a way).
Is it possible to update deps to avoid the vulnerability, or change to not use bundled packages (excuse me if I have some assumptions wrong, I wasn't aware of bundled dependencies until this came up)?
npm audit

npm why http-cache-semantics

Thanks!

Fixed with #213.

FYI with jsii we must use bundled deps unfortunately...


Bower fails for latest version of angular-material

I am using angular-material version 1.1.3 and bower fails because the library requires version 1.1.1.
Is there a way to work around keeping the latest version of the angular material and use the table library? or should the dependencies for this library be updated to latest version and only then it can be used?

@anukiransolur did you find any workaround ?

@LabN36 Nope we are using another library for the table by https://github.com/daniel-nagy/md-data-table.


Support dependencies using ESM exports

Right now, all packages using the ESM exports are failing to be bundled with Snackager. Unfortunately, Metro/RN lacks support for these dependencies as of writing.
Luckily, this is changing with the "Metro package exports support" RFC. Once this is finalized, we can also work on supporting this in Snackager.

All issues related to this are marked with the label snackager - exports support

It appears that commonjs packages bundled with target "ES6" are failing to compile as well. See https://forums.expo.dev/t/unable-to-resolve-module-module-babel-runtime-helpers-interoprequiredefault-js/68960/2. Let me know if you need more info.
Thank you!


Can't find text2room/checkpoints

Hi,
I'm trying to move irondepth_scannet.pt and normal_scannet.pt into folder: text2room/checkpoints but don't see that directory in the text2room directory.
Thanks!

Hi, please create the directory manually :)

Hi again,
Now, I'm getting error:
ERROR: No matching distribution found for nvidia-cudnn-cu11==<IP_ADDRESS>
Thanks!

You can try to relax the versions in the requirements.txt file and install any (the latest) version of the respective packages yourself.

Let me know if you have further questions about installation.


Question: Xaml Compiler

Is the Xaml compiler source available on GitHub? If so, which project has it?

It is not, sorry.


[FLINK-4127] Check API compatbility for 1.1 in flink-core

I checked all the newly introduced methods in public APIs by going through the reports generated from japicmp.
I've also put the reports (before my PR) into the JIRA: https://issues.apache.org/jira/browse/FLINK-4127
I added the new configuration parameters to the documentation, and renamed some new configuration keys.
@uce @tillrohrmann @mxm: What do you think about the renaming of the configuration keys?

Thanks for updating the documentation! I've made some suggestions regarding the names of the new configuration keys.

Good changes @rmetzger.

I addressed all comments. It seems to me that the configuration parameters for YARN are overly complicated now because they are separated in resource manager and YARN now.

The YARN settings are now spread across three prefixes:

yarn.
containerized.
container.

I don't think this is helpful for making the system easy to configure.
What's your opinion on this @tillrohrmann @uce @StephanEwen ?

That would be good to address. Can we get away with only yarn. and taskmanager.?

There are a lot of config options that seem to exist in two variants: One for standalone setup, one for containered setup.
Why are we making this distinction?

I think it's a good idea to merge container and containerized.
I think the idea is to introduce some general container parameters, such as the heap-cutoff-ratio, which are valid not only for yarn but also for mesos. Therefore, the container/containered/containerized prefix was introduced. Given that we don't have mesos support yet it might be confusing. However, changing the parameter names too often, given that they are declared public evolving, will cause pain for users.
Which duplicate configuration parameters are you referring to @StephanEwen?

I'll rename containerized to container once I got a third confirmation from a committer on this issue.

Sorry for chiming in late, but can't - heap-cutoff-ratio and heap-cutoff-min be general parameters that apply to all VMs we start?
Same for master.env.* and taskmanager.env.*. Shouldn't this also apply to all VMs that we start?

So you are suggesting to use the heap cutoff also for the JVM started in standalone mode?
The cutoff was introduced for YARN because there is a difference in the amount of used memory for a container we specify to YARN vs the memory the JVM is actually using.
So if we specify a container of 1000 MB, it will be killed by YARN as soon as we use 1001 MBs. For operating systems, this doesn't apply and if users run into issues, the can just set a lower heap size.
For Mesos, I don't know how it behaves, but I hope that there is a similar requirement, otherwise, we would have prematurely optimized the configuration keys.
I'm against applying this mechanism to all JVMs we start.
For the environment variables of the standalone mode, its quite easy to put the environment variables into the config.sh file, or just set the env variables.
But true, we could do a follow up JIRA to extract those env variables and set them in the config.sh script.

My thinking was that Mesos maybe didn't require this, yes. Having it for Yarn only makes for a better user experience right now. So we could leave it under the "container" namespace.

But with this argument, it would be even better to leave the configuration parameters as they are in 1.0 until we are 100% certain that mesos needs a similar mechanism.

Yeah, then let's leave them as they were since we don't know yet what mesos will require there.

All the container* config keys are now renamed to containerized., so we have yarn. and containerized. as prefixes. But these config keys will be undocumented for now.
In the documentation, we still only list the yarn. configuration keys (and they are also picked up by the system).
I guess with the 1.2 release (when we are adding Mesos support) we can reconsider this decision and see how we are naming / grouping the configuration keys.
I'm going to merge this pull request after 24 hours.


Why did I import the model into this way? From the outside, it looks like it's through the mold

plz

Thank you for your help


Check slot names before training

What problem are you trying to solve?
When run the training it shows this error ERROR    rasa.shared.core.trackers  - Tried to set non existent slot 'requesteds_slot'. Make sure you added all your slots to your domain file.. This error states there is a typo on the slot or there is a non exist slot you want to set.
What's your suggested solution?
So, It will be useful to check the slots name in rules.yml before training through any commons let's say through rasa data validate or a new command.
Examples (if relevant)
- rule: Submit Registration form
    condition:
      # Condition that form is active.
      - active_loop: simple_reg_form
    steps:
      # Form is deactivated
      - action: simple_reg_form
      - active_loop: null
      - slot_was_set:
      # Here is the typo
          - required_slot: null
        # The actions we want to run when the form is submitted.
      - action: utter_submit

Is anything blocking this from being implemented? (if relevant)
No response
Definition of Done
start training the model without any error that will interrupt the training.

Thanks for submitting this feature request 🚀 @yennycheung will get back to you about it soon! ✨


Preprocess templates for performance improvements

Use HTMLTemplateElement, DocumentFragment, and preprocessing. Each template should be initialized into a document fragment (using template when available). The fragment's DOM can be walked and pre-processed, creating a bindings hash with index => bindings where the index is the location of the element in the flattened tree (i.e. fragment.querySelectorAll('*')[index]). Then when an instance of the template is required it can clone the node and initialized the bindings much more quickly.
This has a few benefits.

cloning a document fragment is faster than creating the HTML from a string for each instance
this limits the DOM-walk to once per template instead of once per instance
removal of the "bind attributes" happens once per template, instead of once per instance
using the built-in HTMLTemplateElement when available will speed up documentFragment creation and be more future compatible with new elements

Done in https://github.com/chip-js/fragments, available in chip 1.1 and 2.0


open-appsec in Linux Nginx deployment doesn't detect any traffic

Problem description
I'm trying to install open-appsec in a a Linux vm and deploying it using nginx. I've followed the online documentation (also the video tutorial) but it seems that for some reason the traffic is not detected/inspected (similar to #45).
Environment
Linux distribution: Ubuntu 22.04.2 LTS (Jammy Jellyfish)
nginx version:  nginx/1.22.1 (it's listed as supported here)
Installation steps
I already have nginx running, working in proxy_pass mode for a local application. I can access the application through the reverse proxy without any problem.
I've run the open-appsec-install --auto --prevent and it looks it successfully installed:
luca@luca-virtual-machine:~$ sudo ./open-appsec-install --auto --prevent
open-appsec for NGINX and Kong Installer v1.2245.1
For release notes and known limitations check:
https://docs.openappsec.io/release-notes
Searching local NGINX…
NGINX version found: 1.22.1-1-jammy
Downloading open-appsec NGINX attachment... stored in '/tmp/open-appsec'
Downloading open-appsec agent... stored in '/tmp/open-appsec'
Add your email to receive important security updates and so you can approach us with technical questions (enter IGNORE to ignore):
IGNORE
Installing open-appsec for NGINX...
Updating NGINX server configuration...
Starting open-appsec installation...
Setting mode to prevent-learn...
Successfully installed open-appsec for NGINX and Kong...

Also, to check if the traffic was actually inspected by open-appsec I've set the all-web-requests to true
(and applied the policy again). However, I can't see any log related to HTTP requests (using open-appsec-ctl -vl). So I presume that the traffic is not inspected at all.

Hi Luca!
Thanks for the detailed description!
This does seem to relate to the issue you mentioned, but to be sure, could you please provide the content of /etc/cp/conf/policy.json. feel free to censure any sensitive information such as URLs etc.
If these do relate, a fix will be delivered really soon

Hi @MaxShapiro and thank you for the quick reply.
Below the /etc/cp/conf/policy.json and I don't see any URL configured. Maybe that's the issue ? However I couldn't find any information on how to configure these URLs (following the documentation and the online video-tutorial). But maybe I'm missing something
{
    "waap": {
        "WAAP": {
            "WebAPISecurity": [],
            "WebApplicationSecurity": [
                {
                    "context": "practiceId(392a4832-6e1f-43d8-b502-c92f56732382)",
                    "webAttackMitigation": true,
                    "webAttackMitigationSeverity": "critical",
                    "webAttackMitigationAction": "low",
                    "webAttackMitigationMode": "Prevent",
                    "practiceAdvancedConfig": {
                        "httpHeaderMaxSize": 102400,
                        "httpIllegalMethodsAllowed": 0,
                        "httpRequestBodyMaxSize": 1000000,
                        "jsonMaxObjectDepth": 40,
                        "urlMaxSize": 32768
                    },
                    "csrfProtection": "Disabled",
                    "openRedirect": "Disabled",
                    "errorDisclosure": "Disabled",
                    "practiceId": "392a4832-6e1f-43d8-b502-c92f56732382",
                    "practiceName": "local_policy/webapp-default-practice",
                    "assetId": "Any",
                    "assetName": "Any",
                    "ruleId": "Any",
                    "ruleName": "Any",
                    "schemaValidation": false,
                    "schemaValidation_v2": "Disabled",
                    "oas": [],
                    "triggers": [
                        {
                            "$triggerType": "log",
                            "id": "6990a50d-a2a4-4af9-a613-95ea3c22abb5",
                            "name": "local_policy/appsec-default-log-trigger",
                            "log": {
                                "context": "triggerId(6990a50d-a2a4-4af9-a613-95ea3c22abb5)",
                                "triggerName": "local_policy/appsec-default-log-trigger",
                                "triggerType": "log",
                                "verbosity": "Standard",
                                "acAllow": false,
                                "acDrop": false,
                                "complianceViolations": false,
                                "complianceWarnings": false,
                                "extendloggingMinSeverity": "high",
                                "extendlogging": true,
                                "logToAgent": true,
                                "logToCef": false,
                                "logToCloud": false,
                                "logToK8sService": false,
                                "logToSyslog": false,
                                "responseBody": false,
                                "responseCode": false,
                                "tpDetect": true,
                                "tpPrevent": true,
                                "webBody": false,
                                "webHeaders": false,
                                "webRequests": false,
                                "webUrlPath": false,
                                "webUrlQuery": false,
                                "urlForSyslog": ":514",
                                "urlForCef": ":0",
                                "formatLoggingOutput": false
                            }
                        }
                    ],
                    "applicationUrls": "",
                    "overrides": [],
                    "trustedSources": [
                        {
                            "id": "9122f32c-e67f-442f-bc40-625b6395c959",
                            "name": "",
                            "numOfSources": 0,
                            "sourcesIdentifiers": [],
                            "parameterType": "TrustedSource"
                        }
                    ],
                    "waapParameters": [],
                    "botProtection": false,
                    "antiBot": {
                        "injected": [],
                        "validated": []
                    },
                    "botProtection_v2": "Detect"
                }
            ]
        }
    },
    "triggers": {
        "rulebase": {
            "log": [
                {
                    "context": "triggerId(6990a50d-a2a4-4af9-a613-95ea3c22abb5)",
                    "triggerName": "local_policy/appsec-default-log-trigger",
                    "triggerType": "log",
                    "verbosity": "Standard",
                    "acAllow": false,
                    "acDrop": false,
                    "complianceViolations": false,
                    "complianceWarnings": false,
                    "extendloggingMinSeverity": "high",
                    "extendlogging": true,
                    "logToAgent": true,
                    "logToCef": false,
                    "logToCloud": false,
                    "logToK8sService": false,
                    "logToSyslog": false,
                    "responseBody": false,
                    "responseCode": false,
                    "tpDetect": true,
                    "tpPrevent": true,
                    "webBody": false,
                    "webHeaders": false,
                    "webRequests": false,
                    "webUrlPath": false,
                    "webUrlQuery": false,
                    "urlForSyslog": ":514",
                    "urlForCef": ":0",
                    "formatLoggingOutput": false
                }
            ],
            "webUserResponse": [
                {
                    "context": "triggerId(bd5173b4-51ca-4c0f-9262-71d8157eebb0)",
                    "triggerName": "local_policy/appsec-default-web-user-response",
                    "details level": "response-code-only",
                    "response body": "",
                    "response code": 403,
                    "response title": ""
                }
            ]
        }
    },
    "rules": {
        "rulebase": {
            "rulesConfig": [
                {
                    "assetId": "Any",
                    "assetName": "Any",
                    "ruleId": "Any",
                    "ruleName": "Any",
                    "context": "All()",
                    "priority": 1,
                    "isCleanup": false,
                    "parameters": [
                        {
                            "parameterId": "",
                            "parameterName": "",
                            "parameterType": "Exception"
                        }
                    ],
                    "practices": [
                        {
                            "practiceId": "392a4832-6e1f-43d8-b502-c92f56732382",
                            "practiceName": "local_policy/webapp-default-practice",
                            "practiceType": "WebApplication"
                        }
                    ],
                    "triggers": [
                        {
                            "triggerId": "6990a50d-a2a4-4af9-a613-95ea3c22abb5",
                            "triggerName": "local_policy/appsec-default-log-trigger",
                            "triggerType": "log"
                        },
                        {
                            "triggerId": "bd5173b4-51ca-4c0f-9262-71d8157eebb0",
                            "triggerName": "local_policy/appsec-default-web-user-response",
                            "triggerType": "WebUserResponse"
                        }
                    ],
                    "zoneId": "",
                    "zoneName": ""
                }
            ],
            "usersIdentifiers": []
        }
    },
    "exceptions": {
        "rulebase": {
            "exception": [
                {
                    "context": "Any()",
                    "exceptions": []
                }
            ]
        }
    },
    "version": "3bba636fb9a4c44b37dc6ce9c68ddc7852a843b03189a4fc5033f925840243c2"

Hey @lfama,
It seems we couldn't recreate the issue on our end. Would you mind sharing your NGINX configuration with us? That way, we can give it a shot using the same setup.
Also, could you attach the transaction handler logs for us? You can find them at:
/var/log/nano_agent/cp-nano-http-transaction-handler.log1
/var/log/nano_agent/cp-nano-http-transaction-handler.log2
Thank you for your help!
Oriane

Hi,
We've recreated the setup on our end without encountering the issue. One possibility is that the problem might arise if you're accessing the test application using a URL different than localhost since the server_name is configured specifically for localhost. This can be tested by changing the server_name to default (server_name _;)
If you're up for it, we'd love to schedule a call to explore your deployment together. Feel free to reach out to us at<EMAIL_ADDRESS>and we can take it from there.
Appreciate your cooperation,
Oriane
open-appsec team


Clarify sample apps at 'dotnet/blazor-samples'

Fixes #26376
Thanks @gnnsekhar and @Ducki! :rocket:
💥 Ooops! 💥
There are some build problems this morning with the new 7.0 moniker showing up in the doc version selector. We're discussing it offline now, and I'll get back to this after we (or the doc build folks) work out the 🐞.

btw @Rick-Anderson ... Just minutes ago, I put up another one that doesn't even touch a markdown file, only sample app files. It also 💥 on me ...
https://github.com/dotnet/AspNetCore.Docs/pull/26387

Ok ... I'm back ... trying it now without the metadata indicating >=3.1.

Didn't work ... no effect ... same warnings ... and would've had the terrible side effect of an empty article for unsupported doc versions. Reverting now.


✨ New navigation featuring Pipelines and TA side-by-side

New navigation UI that shows Pipelines and Test Analytics side-by-side. This PR replaces the existing sidebar navigation paradigm.
See the 🎦 Loom video https://www.loom.com/share/0f94be9f72804b5eb37e5f4b1a3f342f or read summary below:
Summary of changes:

[x] Manage navigation content in YAML
[x] New header and navigation UI
[x] Pills in sidebar nav
[x] Remove old sidebar code
[x] Scroll padding for anchor links
[ ] Add notification message advising of recent big changes

Excluded from this PR
To keep this PR as small as possible, the following features will come later:

Breadcrumbs
New header on homepage
Not changing any pages' paths relative to the new structure

Screenshots

Not sure why I'm getting a 500 error on the preview. I hope this won't cause a problem on the production site 😬.
Works on my local dev. Any ideas? 🤷♂

Pulled back to draft to add notification message advising customers of major navigation changes.

Added notification message in commit https://github.com/buildkite/docs/pull/1591/commits/a0efe723c8610e0c99ac1888a2453598ecae96aa. Ready for review again.

Add notification content in data/notification.yml
Keep notification dismissed state in localStorage
Four different style options (i.e. success, info, warning, and danger)

Thanks @karensawrey I'll take a look at the typo fixes.
The 500 server error is really strange 🤔 I thought pushing a commit again would fix it. It works on my local dev, but will investigate to double make sure. 🔍

500 error resolved in https://github.com/buildkite/docs/pull/1591/commits/8c4cad3b0541187a575abe909ddc76d61ce0a8be


Add filtering of the dependencies node based on a capbility

@dotnet/project-system @abpiskunov

:shipit:


[BEAM-7801] Fix wordcount_xlang postcommit.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @ihji

Run Python 2 PostCommit

Run Python PreCommit


Feature request: Invoking find copies selected text into Find

I use this a lot - select a string and press cmd-F
saves the copy/paste and tabbing to the find text field

I'll just do myself.

I already did it! :) will check in shortly.


Chapter recurrent neural networks/text preprocessing

Job d2l-zh/PR-877/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/6 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/7 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/8 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/

Job d2l-zh/PR-877/9 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-877/


prevent headerTemplate outlet context from regenerating on every change.

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#785
What is the new behavior?
Modified DataTableHeaderCellComponent
A new outlet context object will only be created when one of its properties changes. Triggered by ngOnChanges.
Also added changeDetection: ChangeDetectionStrategy.OnPush
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Shouldn't break existing code unless the OnPush change detection change causes issues for people who are mutating objects instead of setting Inputs.
Other information:

@arlowhite - i updated it to the implementation i did with body cell in 10.0.4. Do you wanna check it out and see if it addresses the issues?

Yes, 10.0.5 fixes this issue. :+1:
Tested in my project with custom headerTemplate, and template doesn't reset on change detection anymore.


[Event Request] table 900 "Assembly Header" procedure RunWhseSourceCreateDocument()

Please can you add the following code/event to the above procedure...
WhseSourceCreateDocument.SetAssemblyOrder(Rec);
if not ShowRequestPage then
   WhseSourceCreateDocument.Initialize(
                AssignedUserID, "Whse. Activity Sorting Method".FromInteger(SortingMethod), PrintDocument, DoNotFillQtyToHandle,
                SetBreakBulkFilter);

WhseSourceCreateDocument.UseRequestPage(ShowRequestPage);
WhseSourceCreateDocument.RunModal();
WhseSourceCreateDocument.GetResultMessage(2);
Clear(WhseSourceCreateDocument);

OnAfterRunWhseSourceCreateDocument(Rec, ShowRequestPage, AssignedUserID, SortingMethod, SetBreakBulkFilter,
       DoNotFillQtyToHandle, PrintDocument);    // NEW **CODE**

The event publisher should be as follows...
[IntegrationEvent(false, false)]
local procedure OnAfterRunWhseSourceCreateDocument(var AssemblyHeader: Record "Assembly Header"; ShowRequestPage: Boolean; AssignedUserID: Code[50]; SortingMethod: Option; SetBreakBulkFilter: Boolean; DoNotFillQtyToHandle: Boolean; PrintDocument: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10897.


Made Changes

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All tests pass and I've made any necessary test changes.
[ ] I have run the Sandbox successfully.

@kautuk98. Thanks for the contribution. Before we can accept the pull request, you'll need to sign the Adobe CLA: http://opensource.adobe.com/cla.html
I'll be adding a few inline questions to the pull request as well. Thanks!

Thank you for the contribution @kautuk98 but I agree with @Aaronius, we won't be merging this PR. But don't let that stop you from contributing in the future.

Thanks to you, I learnt a thing or two.


Add error handling in install.sh

The install.sh script can be used to install the binary into /usr/bin. This script is really optimistic so this MR
adds at least two error checks:

We should validate we were able to create the temporary directory. If this fails we may download the project to an unintended path and running rm -rf on something that may not be the expected temporary directory may lead to unexpected and dangerous results
The script has to install the binary into /usr/bin and a normal user will not be able to do that. So the install.sh script performs the move with sudo. This assume that sudo is available on the system and the user actually has the necessary rights to perform the move. We now check the return value of the move instead.

Thank you for your PR!
This really make this script more graet.


Separate content in Tutorial for Effector-users and for non-Effector-users

Will be done in other way in #337


Uncouple circular dependency with Codec2

Adds required files from Codec2 so that LPCNet doesn't have to be linked with Codec2 per https://github.com/drowe67/codec2/discussions/342. For those files, we compile with -fvisibility=hidden so that there aren't conflicts with the Codec2 versions when we link LPCNet into the former (source for info about that compiler flag).
Current status: when linked with this PR, Codec2 ctests on master currently fail. However, it's unknown if these failures are related:
The following tests FAILED:
	 13 - test_FDMDV_modem_octave_mod_demod (Failed)
	 18 - test_COHPSK_modem_freq_offset (Failed)
	 21 - test_OFDM_modem_octave_port_Nc_31 (Failed)
	 74 - test_freedv_api_2020C_mpd (Failed)

Additionally, LPCNet ctests are failing due to use of developer specific paths (e.g. build_linux inside test_core_nn.sh):
40% tests passed, 3 tests failed out of 5

Total Test time (real) =   0.15 sec

The following tests FAILED:
	  1 - core_synthesis_default (Failed)
	  2 - core_synthesis_load_20h (Failed)
	  3 - core_synthesis_mag (Failed)

Also, a lot more files needed to be brought in than I thought (though the majority are .h files).

Thanks for working on this @tmiw.
These tests run OK for me (no path problems) but fail:
The following tests FAILED:
	  1 - core_synthesis_default (Failed)
	  2 - core_synthesis_load_20h (Failed)
	  3 - core_synthesis_mag (Failed)

I recall there were some numerical/precision issues which made some of these tests work on one machine and not another.  Not very good tests I guess.  Still, it would be nice to check we haven't broken anything :thinking:

Thanks for working on this @tmiw.
These tests run OK for me (no path problems) but fail:
The following tests FAILED:
	  1 - core_synthesis_default (Failed)
	  2 - core_synthesis_load_20h (Failed)
	  3 - core_synthesis_mag (Failed)

I recall there were some numerical/precision issues which made some of these tests work on one machine and not another. Not very good tests I guess. Still, it would be nice to check we haven't broken anything 🤔

Well, at least the paths seem to be made more platform/developer independent, but still no dice on my end.
FWIW, the test that's currently being done in GitHub actions/freedv-gui builds is this:
# simple test to make sure the code runs
cd src && sox ../../wav/wia.wav -t raw -r 16000 - | ./lpcnet_enc -s | ./lpcnet_dec -s > /dev/null

I manually checked the feature file is the same for master and ms-uncouple-codec2:
~/tmp/LPCNet/build_linux ms-uncouple-codec2 $ ./src/dump_data --test --c2pitch ../wav/birch.wav birch.f32
~/tmp/LPCNet/build_linux ms-uncouple-codec2 $ diff birch.f32 ~/LPCNet/unittest/birch.f32

The pitch estimate is in one of the fields in the .f32 file, so this suggests this PR is doing the same thing as master, which uses the libcodec2 pitch estimation code :+1:

Should the LPCNet README.md build instructions be tweaked?

Should the LPCNet README.md build instructions be tweaked?

Yep, just did. 👍

@tmiw In https://github.com/drowe67/LPCNet/pull/44 I've had a go at building up some ctests that pass and can run with GitHub actions.  Please try merging this PR with LPCNet/master and lets see if the tests work with this PR.  The first ctest should pick up any pitch estimator issues, as that's one of the features dump_data generates.

@tmiw In #44 I've had a go at building up some ctests that pass and can run with GitHub actions. Please try merging this PR with LPCNet/master and lets see if the tests work with this PR. The first ctest should pick up any pitch estimator issues, as that's one of the features dump_data generates.

All tests pass for me now. 👍

@tmiw OK to merge now?  I bumped the version number, as I figure this will need a new release.

@tmiw OK to merge now? I bumped the version number, as I figure this will need a new release.

Yep.

Should a new release be tagged at https://github.com/drowe67/LPCNet/releases?

Should a new release be tagged at https://github.com/drowe67/LPCNet/releases?

Yes, but how about we wait until codec2 and freedv-gui have been updated in line with this change?  There might still be some LPCNet tweaks required before the dust settles.

Should a new release be tagged at https://github.com/drowe67/LPCNet/releases?

Yes, but how about we wait until codec2 and freedv-gui have been updated in line with this change? There might still be some LPCNet tweaks required before the dust settles.

That works. I think there's an issue compiling freedv-gui for Windows so I'll investigate that.


Changed to use NotoSans and Japanese can be used

Summary
This PR includes the following changes:

Changed to use NotoSans
Added Japanese language support
Fixed several typos

As a Japanese person, I wanted to play in Japanese, so I submitted this PR.The default language pack for egui causes garbled text when dealing with CJK characters, so I changed it to use NotoSans. I am not very familiar with the Rust writing style, so if you could merge it, I would appreciate it if you could point out any problems in your review

Thanks for the pull request! Everything looks good, so I'm merging it.


Irrigation Module

Overview:

Adds new land BCs version (v13)
Allows Irrigation on Catchment ("land") tiles

Repositories affected by updates:
_GEOSgcm_GridComp, GEOSldas_GridComp_
New Files:

GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOSirrigation_GridComp/GEOS_IrrigationGridComp.F90
GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOSirrigation_GridComp/irrigation_model.F90
GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/module_irrig_params.F90

Brief description:
New land BCs version:
v13 : NL3 + JPL veg height + PEATMAP + MODIS snow alb v2 + Irrigation
The bcs generation package reads different irrigated area datasets and generates a new file "irrigation_IMxJM_DL.dat" containing, for each tile, a static:  irrigation fraction, Paddy fraction, Rainfed fraction, crop irrigation fraction, crop irrigation type, crop planting and harvest dates, sprinkler fractions, drip fractions, flood fractions, and minimum and maximum LAI.
Irrigation module:
Adapted from: feature/SM_irrigation_model
The irrigation module computes irrigation rates by applying three different irrigation schemes: sprinkler, drip, and flood (furrow). Irrigation is triggered based on location, growing season (Implemented alternative options: LAI-based and Crop Calendar-based), and soil moisture.
New Output Variables: each variable is weighted based on the specific irrigated fractions:
SPRINKLERRATE: sprinkler_irrigation_rate (kg m-2 s-1)
DRIPRATE: drip_irrigation_rate (kg m-2 s-1)
FLOODRATE: flood_irrigation_rate (kg m-2 s-1)
IRRLAND: total irrigation rate (kg m-2 s-1) = SPRINKLERRATE + DRIPRATE + FLOODRATE
LDAS nightly test

Runtype
Clone
Build
Build Time
Model Run/Compare
Assim Run/Compare

-------
-----
-----
----------
-----------------
-----------------

conus
pass
pass
43 min
pass/pass
-- / --

global
--
--
--
pass/pass
pass/pass

globalcs
--
--
--
pass/pass
pass/pass

globalcnclm4
--
--
--
pass/pass
-- / --

The latest commits updated flood irrigation by differentiating it between furrow irrigation (now applied only to irrigated fractions) and flood irrigation (now applied only to paddy fractions).
The main difference consists of where the water is applied: furrow irrigation rate is still applied to the root zone, while flood irrigation rate is now applied to the surface excess.
Output Variables: each variable is weighted based on the specific irrigated fractions:
SPRINKLERRATE: sprinkler_irrigation_rate (kg m-2 s-1)
DRIPRATE: drip_irrigation_rate (kg m-2 s-1)
FURROWRATE: furrow_irrigation_rate (kg m-2 s-1)
FLOODRATE: flood_irrigation_rate (kg m-2 s-1)
IRRLAND: total irrigation rate (kg m-2 s-1) = SPRINKLERRATE + DRIPRATE +FURROWRATE+ FLOODRATE

Note: GNU seems unhappy with some of the OpenMP pragmas, see:
https://app.circleci.com/pipelines/github/GEOS-ESM/GEOSgcm_GridComp/7271/workflows/2674d6a6-5641-48d0-b141-0de7a5680f0a/jobs/14422/parallel-runs/0/steps/0-109

Note: GNU seems unhappy with some of the OpenMP pragmas, see:
https://app.circleci.com/pipelines/github/GEOS-ESM/GEOSgcm_GridComp/7271/workflows/2674d6a6-5641-48d0-b141-0de7a5680f0a/jobs/14422/parallel-runs/0/steps/0-109

Thanks, Matt, for pointing this out.  We'll have to sort it out.  Not sure if it worked before I merged develop into the branch.


Stopped working after the update

Hello, an error occurred after I used 'bulk generate vocabulary frequency'
Debug info:
Anki 2.1.65 (aa9a734f) Python 3.9.15 Qt 6.4.3 PyQt 6.4.0
Platform: Windows-10-10.0.19041
Flags: frz=True ao=True sv=3
Add-ons, last update check: 2024-07-08 17:34:43
Caught exception:
Traceback (most recent call last):
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 230, in
bulk_generate_frequency.triggered.connect(lambda _, brow=browser: on_bulk_generate_vocab(brow))
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 240, in on_bulk_generate_vocab
bulk_generate_vocab_frequency_fg(browser.selectedNotes())
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 86, in bulk_generate_vocab_frequency_fg
reload_json_config()
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 53, in reload_json_config
word_type_field = config["03_word_type_output_field"]
KeyError: '03_word_type_output_field'
This is my configuration, it was working before the update

hey, a new field called "word type" has been added. I am not sure why this is not reflected in your config file. I guess anki did not add it. Either try uninstalling the add-on and seeing if you get the field in the config file after reinstallation or manually add it the config file. Please check the read me about the new field and how it works. I hope this helps. if not, let me know.

Hi
I reinstalled the addon and a new error appeared
Caught exception:
Traceback (most recent call last):
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 230, in
bulk_generate_frequency.triggered.connect(lambda _, brow=browser: on_bulk_generate_vocab(brow))
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 240, in on_bulk_generate_vocab
bulk_generate_vocab_frequency_fg(browser.selectedNotes())
File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 87, in bulk_generate_vocab_frequency_fg
freq_db = sqlite3.connect(freq_dict)
sqlite3.OperationalError: unable to open database file
my configuration:

I noticed that unlike the example photo you posted, the 'freq_dict' field was missing. I added it to this configuration, but it didn't solve the problem.
Maybe the problem is my Anki version? I am using version 2.1.65. I could update my version if that would solve the problem

I don't think that that is an issue, but you can try it. I tested everything before hand, but I will test on some other computers too.
Could you check the add on files on your computer to see if it downloaded the databases?
It could be that they are missing.

I checked, apparently everything is fine

I updated the comment.

Hi
I reinstalled the addon and a new error appeared
Caught exception: Traceback (most recent call last): File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 230, in bulk_generate_frequency.triggered.connect(lambda _, brow=browser: on_bulk_generate_vocab(brow)) File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 240, in on_bulk_generate_vocab bulk_generate_vocab_frequency_fg(browser.selectedNotes()) File "C:\Users\LS\AppData\Roaming\Anki2\addons21\1004691625\main.py", line 87, in bulk_generate_vocab_frequency_fg freq_db = sqlite3.connect(freq_dict) sqlite3.OperationalError: unable to open database file
my configuration:

I noticed that unlike the example photo you posted, the 'freq_dict' field was missing. I added it to this configuration, but it didn't solve the problem.
Maybe the problem is my Anki version? I am using version 2.1.65. I could update my version if that would solve the problem

The file path my not be correct or the database might be opened up by another program (on accident). Check your task manager if some other program is accessing the database or if you have multiple instances of anki running in the background.

It still doesn't work, I couldn't find any problem. I really don't know what it could be, I've been using this addon for months without any issues and after the update it started giving errors. If the addon is only giving me problems, then it must be something on my PC. I'll check it out later and let you know if I find anything. I appreciate you trying to help me.

The only things that I can offer is an older version of the add on or I can look at your computer personally via zoom or google meets and debug it there.

I hadn't seen the suggestion to use \ in my configuration. I tried it right now and it worked. I appreciate you helping me.

try with the following deck and note type test.apkg.zip
Try with this config. I was having problem with single slashes. So, I used doubled ones.
{
    "01_note_type": "Japanese",
    "02_vocab_input_field": "Target Word",
    "03_frequency_output_field": "Frequency Ranking",
    "03_word_type_output_field": "Word Type",
    "04_overwrite_destination_field": true,
    "0_freq_dict": "C:\\Users\\ls\\AppData\\Roaming\\Anki2\\addons21\\1004691625\\databases\\freq_dict.db",
    "0_jm_dict": "C:\\Users\\ls\\AppData\\Roaming\\Anki2\\addons21\\1004691625\\databases\\jmdict.db"
}

This configuration worked, thank you

perfect! could you please comment the add on accordingly so that others can see how you solved the problem. Also, please star this repo and like the add on website, if you haven't. That would mean a lot to me. If you have any suggestions for the the addon, please let me know!


Create Shelves

books>categories>shelves
Create shelves for tagging groupings of content by contribution collaborations via organizations or topics.
Possibly the first Shelf would be MetaGame OG Academy content.

Maybe an organization can have a Shelf that also contains Books from other organizations?

see also https://github.com/MetaFam/TheGame/issues/1775

Org pages and shelf initial pages have been created.
Community curation shelves are on the way.
We need to sort how to add Org tags, shelf tags with QC factory contracts?
@dysbulic