Connection errors aren't caught

requests.exceptions.ChunkedEncodingError is raised all too often.
Traceback (most recent call last):
  File "~/virt_env/bin/waybackpack", line 9, in <module>
    load_entry_point('waybackpack==0.3.2', 'console_scripts', 'waybackpack')()
  File "~/virt_env/lib/python2.7/site-packages/waybackpack/cli.py", line 88, in main
    root=args.root,
  File "~/virt_env/lib/python2.7/site-packages/waybackpack/pack.py", line 63, in download_to
    root=root
  File "~/virt_env/lib/python2.7/site-packages/waybackpack/asset.py", line 45, in fetch
    res = session.get(url)
  File "~/virt_env/lib/python2.7/site-packages/waybackpack/session.py", line 20, in get
    **kwargs
  File "~/virt_env/lib/python2.7/site-packages/requests/api.py", line 71, in get
    return request('get', url, params=params, **kwargs)
  File "~/virt_env/lib/python2.7/site-packages/requests/api.py", line 57, in request
    return session.request(method=method, url=url, **kwargs)
  File "~/virt_env/lib/python2.7/site-packages/requests/sessions.py", line 475, in request
    resp = self.send(prep, **send_kwargs)
  File "~/virt_env/lib/python2.7/site-packages/requests/sessions.py", line 617, in send
    r.content
  File "~/virt_env/lib/python2.7/site-packages/requests/models.py", line 741, in content
    self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
  File "~/virt_env/lib/python2.7/site-packages/requests/models.py", line 667, in generate
    raise ChunkedEncodingError(e)
requests.exceptions.ChunkedEncodingError: ('Connection broken: IncompleteRead(0 bytes read)', IncompleteRead(0 bytes read))

Thanks for flagging! Do you have an example URL where that raises this error?

Sure:
waybackpack -d BugExample --from-date<PHONE_NUMBER>0431 --to-date<PHONE_NUMBER>0431 http://www.reuters.com/finance/deals/

Thanks, and indeed quite strange. I'm having an experience similar to yours: When I visit the archive page for that link, I sometimes get data, and other times an empty response. In terms of handling those errors, would you rather:
(a) waybackpack skip those snapshots, or
(b) retry up to x times, or
(c) follow some other behavior?
Also: @wumpus, any thoughts on what might be happening re. these Wayback Machine responses?

The simplest option, IMO, would be to leave the decision to the user:

catch the exception;
log the error to stderr in an easily greppable/parseable format;
move on.

Rationale:

retries in close succession are not guaranteed to work and may be considered DOS/TOS violation by the Waybackers;
skipping snapshots without telling the user is kinda bad UX.

First pass at handling this, here: https://github.com/jsvine/waybackpack/pull/20
Adds --ignore-errors flag. Though perhaps it should be --skip-errors?
Does this look/work as expected? Or were you thinking of another approach?

Haven't tried the test yet, but the changes look sound to me - https://github.com/jsvine/waybackpack/pull/20/commits/9603712201307f4410aa4b2440c0d81aee1f9298

Merged, incorporated into v0.3.3 and pushed to PyPi!


RFC: gpsd evaluation

This is a basic hack to pull GPS information from gpsd.  There seemed to be some interest in assessing the usefulness of gpsd, so I created this as an excuse to learn Go and play with gpsd.  This is my first Go project so any feedback is appreciated.  If anyone can think of any features that might help with assessment, please let me know.
To run this you will need to connect your Pi to the internet, apt-get install gpsd gpsd-clients, and enable/start the service.
Some initial observations:

GPS hotplug works great.  Basically a non-issue on the stratux level.
It will take data from more than one GPS, however, there is not (currently) any code for selecting which report to use.  Whatever is the latest to be received is what is used.
The gpsd shipping with Raspbian Jessie (3.11) does not have udev rules for ublox > 6.  My ublox7 receiver worked fine after adding rules.  However, it may be a good idea to install a newer version of gpsd, which is available in Stretch (3.16).
This code does not coexist with native ry835ai.go, so most of that is disabled.  If there is some interest I would be willing to add it.
stratux has no notion of a 2D fix that I can see.  So 2D fix is presented as 3D at the last known altitude.  It could also ignore 2D fixes.  Is there a preference here?
I can't find a reliable and easy way to tell if the fix is WAAS or not.  So, all fixes are presented as a normal 3D fix for now.  See: http://catb.org/gpsd/faq.html#waas
There is an ATT status gpsd provides which could probably be used for AHRS.  However, the only two products I could confirm support it seem quite expensive. This might be worth further investigation.  Gpsd its self doesn't seem to do AHRS calculations but it looks for proprietary NMEA messages from devices that do them.  I added handling for these messages, but can't test it.

For troubleshooting I recommend to try the cgps gps command line client to confirm gpsd is working and receiving a fix.  Stratux will connect to gpsd on startup.

@foonix - Thank you for submitting this. Just looking at it now, sorry it took so long.

stratux has no notion of a 2D fix that I can see. So 2D fix is presented as 3D at the last known altitude. It could also ignore 2D fixes. Is there a preference here?

EFBs take the 3D position and calculate terrain and/or traffic alerts based on this data. Most EFBs don't account for an invalid altitude input. If we fudge the 3D fix by using last known altitude, that has potential to cause some ugly bugs. 2D-only fixes are mostly edge cases anyways, if the user is only getting a 2D fix I'd rather they get no information at all, as they should be forced to figure out the problem with their receiver. For that reason, as you noted, most of the stratux code counts on all GPS fixes to be 3D fixes

I can't find a reliable and easy way to tell if the fix is WAAS or not. So, all fixes are presented as a normal 3D fix for now. See: http://catb.org/gpsd/faq.html#waas

This is where we start asking questions on why we want to use gpsd. We can make the simplifying assumption that all users will be using a u-blox 6/7/8, or we can begin to account for the issues as in your link.
This is working well for us currently.

I see now that you've implemented the same SBAS 'detection' in getNMEAName(). Great, this is a really straightforward implementation looks pretty good to me.
I'm modifying this PR now to merge into https://github.com/cyoung/stratux/tree/gpsd, we can start there.
What remains:

gpsd install on images.
udev rules that you reference? Which are those?
Some update vector, would ideal to send this out via .sh files if possible versus a full image update.
Going through processNMEALine() one by one and checking each function there. We're doing custom configuration on u-blox receivers and it would be good to check what we need there and what we don't. Some unimplemented features in this code currently are setting system clock, update rate/baud rate changes (if needed).
It would be a good time to also overhaul the isGPSConnected(), isGPSValid(), isGPSGroundTrackValid(), and isGPSClockValid() functions.

Good point on the altitude.  I'll send another PR with the fix.
getNMEAName() is mostly stolen from processNMEALine(). :)   I'll take a stab at checking the IDs marked as in solution.  If all else fails we can still snoop NMEA via gpsd.  If stratux only says a fix is WAAS if it can positively identify it is, I think it's fair that people using receivers not on the recommended list might not get their fix to show as WAAS even if it is.

The changes in image/10-stratux.rules mimic the rules in question.  The original rules are in /lib/udev/rules.d/60-gpsd.rules and are (gpsd 3.11):

# u-blox AG, u-blox 5 (tested with Navilock NL-402U) [linux module: cdc_acm]
ATTRS{idVendor}=="1546", ATTRS{idProduct}=="01a5", SYMLINK+="gps%n", TAG+="systemd"<EMAIL_ADDRESS># u-blox AG, u-blox 6 (tested with GNSS Evaluation Kit TCXO) [linux module: cdc_acm]
ATTRS{idVendor}=="1546", ATTRS{idProduct}=="01a6", SYMLINK+="gps%n", TAG+="systemd"<EMAIL_ADDRESS>

The gpsd .deb and dependencies would have to be bundled with the .sh unless we can require an internet connection.  It might be mandatory if we need a newer gpsd version than what is in the repo.
Gpsd has code for negotiating baud rates.  There is a mechanism where gpsd can communicated with ntpd over shared memory
To add, I noticed there could be some latency between the gps fix and the ownship report caused by the heartbeat timing loop.  Maybe makeOwnshipReport() could read fixes from a channel or be triggered by callback.


Filling SG versions path_to_frames

Changelog Description
My studio requires uploaded versions' sg_path_to_frames field to be filled in with the EXRs to review / deliver. This checks all representations attached to the product, does basic filtering and takes the path from there.
Additional info
If a product has >1 compatible image representations (created through the oiiotool for example), the last representation's path is used. Last alphabetically, as far as I can tell. Perhaps a tag could be added on the Extract Review output definition to specify which representation name to use, ie "path_to_frames:exr2065". But I'm not sure if there's existing conventions for this, and we needed a hotfix
Testing notes:

Publish a review to SG. I did a nuke render with stock Extract Review settings
Check "sg_path_to_frames" field against the representation's path in ayon

the logic feels wrong as you are doing a second iteration of all the representations within the main loop of representations.
In our fork of ayon-shotgrid I'm skipping the thumbnail repre always as we never want that to be integrated on the version https://github.com/fabiaserra/ayon-shotgrid/blob/release/alkemyx/client/ayon_shotgrid/plugins/publish/integrate_shotgrid_version.py#L58 and also the latest image extension on the representations will be set to sg_path_to_frames without having to do another for loop.

the logic feels wrong as you are doing a second iteration of all the representations within the main loop of representations.
Hey! I've changed this up a bit - now the second iteration isn't happening. We've also added a reference to the representation tag "shotgridpathtoframes" - if a compatibles representation with this is found, these frames are used.
Also, I've used #### for the frame number replacement - this is important for our use case but %04d may be preferred, idk

Hello there, it looks like this PR is stalled and not actively worked on anymore.
As this is a community feature request, I'm going to close it for now, but please feel free to re-open if someone is willing to pursue the work and answer the comments here.


Corrects EntityMapping in ASim detection rule for Solarwinds

Detection rule SUNBURST and SUPERNOVA backdoor hashes (Normalized File Events) uses non-normalized field (MD5) in entity mappings breaking rule deployment.
Change(s):

This PR makes the rule use the correct field as used in the imFileEvent parser (TargetFileMD5).

Reason for Change(s):

Incorrect entity field breaks deployment

Testing Completed:

Yes

In hindsight this is not correct. Algorithm is an enum and the MD5 field needs to be replaced with an "MD5"-string instead.
See also:

https://github.com/Azure/Azure-Sentinel/commit/8768b916756b827da02d1dfd95ece8fbe27049c4
https://docs.microsoft.com/en-us/azure/sentinel/entities-reference#file-hash


Implement configuration cache cleanup

in order not to fill up users disks.
This PR also moves the gradle version from the disk layout to the cache key to align the disk layout with other caches and let the cleanup implementation be simpler.
Cache entries created before this PR will be cleaned up too.
See individual commits for details.

@bot-gradle test RFM
@bamboo PTAL

OK, I've already triggered ReadyForMerge build for you.

Hum, the test introduced in this PR is still flaky, needs more investigation.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFN

OK, I've already triggered ReadyForNightly build for you.


Promote Framework not found (MSB3644) warning to error

When the targeted .NET framework reference assembly folder is not found,
an error (rather than warning) will be generated. This will prevent
producing a build that could be invalid.
Closes #173

Added an override environment variable (just in case) and a test case to test both scenarios.

LGTM


'WebAuthnCredentialManager' object has no attribute 'devices_for_user'

django-otp relies on Device subclasses managers have devices_for_user method. Without that, some code paths will fail:
  File "/home/weblate/weblate-env/lib/python3.11/site-packages/django_otp/forms.py", line 317, in clean
    self.clean_otp(self.user)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/weblate/weblate-env/lib/python3.11/site-packages/django_otp/forms.py", line 102, in clean_otp
    user.otp_device = self._verify_token(user, token, device)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/weblate/weblate-env/lib/python3.11/site-packages/django_otp/forms.py", line 176, in _verify_token
    device = match_token(user, token)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/weblate/weblate-env/lib/python3.11/site-packages/django_otp/__init__.py", line 97, in match_token
    for device in devices_for_user(user, for_verify=True):
    ^^^^^^^^^^^^^^^^^
  File "/home/weblate/weblate-env/lib/python3.11/site-packages/django_otp/__init__.py", line 130, in devices_for_user
    device_set = model.objects.devices_for_user(user, confirmed=confirmed)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


Replace buggy scalafmt autoplugin by hook

Benefits of this approach:

Reformatting only happens before the commit, not at every compilation.
The git pre-commit hook is automatically set up if it doesn't exist.
Incremental compilation works.

Notes:

Those users that have local pre-commit hooks will need to copy paste the
commit hook by hand. It is placed under the scripts dir.

Please review @eed3si9n and @dwijnand. Even if AutomateScalafmtPlugin is working on sbt (it fails on Zinc as I've described in the ticket), I think this is a considerable improvement over the status quo and would like to merge it.

This PR has quickly evolved and the solution I came up it's more sophisticated than the status quo. In short, commit messages are not updated with actions that are done in the git hooks (though the git commit will use whatever change is done and push it correctly). The problem is that user won't see those changes, though they will be pushed, and if some lines have been formatted they will not notice it.
Because of that, the python script in this PR works around this issue and recreates the message with the up-to-date information. This is a general solution that supports anything that the users wants (git templates, alternative git hooks, etc). The issue is that it will readd modified files that have been staged. This may be unexpected for lots of users, especially if they keep a dirty state.
Unfortunately, this is enough of a problem so that I consider closing this PR since it is too sophisticated. I will use these scripts myself, and with more work it's possible to provide an automated way to warn users which formatting changes have been done in "dirty files". But for now, I'm closing this and I will focus on other stuff.

Sounds good. Perhaps a simpler improvement we can add to the existing auto plugin is disable feature that can be called from sbt shell for power users.


Testing Vector Tiles Renderer

Try following renderers than the Mapbox or write a custom one to improve speed.

Tilelive https://github.com/mapbox/tilelive
Tessera https://github.com/mojodna/tessera
Avecado https://github.com/MapQuest/avecado

Duplicate for #13


Assign segments improvements and multiple segments assigning

[x] Assign multiple segments to a single person
[x] Assign single segment to a single person
[x] Create a person if does not exist while assigning
[x] Improve assigning sheet UI

https://github.com/user-attachments/assets/ed8ac85f-ff6e-44e8-bce0-44664ec03512

lgtm @mdmohsin7 🥳


New folder structure

ref :

#112
https://github.com/ai-cfia/nachet-backend/issues/109

TODO🚀
**Datastore -> Nachet 🌱 **
📦 bin/

db-mock-seeds-population.py
deployment_mass_import.py
ml-import.py

📦 blob/azure_storage_api/

init.create_dev_container_folder()

This one might be tricky since its only one function and could be resolved in a separate issue if we really want to move it.

📦 tests/

All of it need to be moved; it is a test file for  deployment_mass_import.py

The structure for db/ needs to be replicated in both nachet/ and fertiscan/. There needs to be:

metadata/
bytebase/

This one already has a file with all fertiscan data and the rest is all Nachet's
This one can be deleted afterward, since it should be empty.

queries/

The project's specific object file need to be moved:

Nachet 🌱
FertiScan 👨🏻🌾

inference
inspection

machine_learning
ingredient

seed
label

picture (only the metadata file, explanation bellow)
metric

nutrients

organization

specification

sub_label l

Special attention:
📦 datastore/db/metadata/validator/init

This file is used in (almost every) tests for its function is_valid_uuid(). However it also has some model structure that might be used in a few Nachet tests.

📦 datastore/db/metadata/template/*

I'm not sure if this is still used in Nachet... 😮💨

📦 datastore/db/queries/user/

I'm not sure what to do with this one. Both project use it since they both use the same user structure. Maybe it should stay in the datastore for now and both project will use it from there?

📦 datastore/db/queries/picture/ & datastore/db/queries/picture_set/

Just like the user, both project use the same DB structure for their project for the picture & picture_set entity. The query module should stay in datastore maybe?
The

📦 doc

Do we want to make a doc directory for each project?

I'm curious, how does nachet-backend or fertiscan-backend install the package now that this has been merged? What happens if they are redeployed currently?

They update where they point towards their respective project.toml file?

I will provide documentation once testing is done. I will also provide changes to both backends to refer to the packages once testing is done


Add caption box to photos

At the moment, we have an "Attribution notes" field associated with each photo but no other place to write a caption giving info specific to an image. In most cases this is fine as images are fairly self-explanatory, but occasionally it would be useful to caption a photo with more specific context. IMO this caption, if any, should display beneath the image when the image display modal is opened.

Nancy Asquith has requested this feature so I'm bumping the issue with her request:
"I do not feel "Link to original" tells enough about a photo. If there are some galls you still need photos of, tell me which and what size/shape and I will work on building a caption into each JPG."


Automatic OBDII Tracker – "err_invalid_client" – Change of authorisation method?

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.50.2
Python release (python3 --version):
3.5.2
Component/platform:
device_tracker/automatic
Description of problem:
When Home Assistant is loading components, it is no longer able to configure a web socket with Automatic's servers. Enabling "DEBUG" logging for all components doesn't give much information, other than an error in the form of "err_invalid_client".
Expected:
Successful connection with Automatic's servers and establishment of Websocket.
Traceback (if applicable):
2017-08-03 08:16:01 ERROR (MainThread) [homeassistant.components.device_tracker.automatic] err_invalid_client
2017-08-03 08:16:01 ERROR (MainThread) [homeassistant.components.device_tracker] Error setting up platform automatic

Additional info:
During the setup of the platform, I can see that a CURL request is made to Automatic servers using the client secret, client ID, username and password as follows:
2017-08-03 08:23:33 DEBUG (MainThread) [aioautomatic.base] Sending POST, to https://accounts.automatic.com/oauth/access_token: {'client_secret': '[REDACTED]', 'password': '[REDACTED]', 'username': '[REDACTED], 'scope': 'scope:location scope:vehicle:profile scope:trip scope:current_location', 'grant_type': 'password', 'client_id': '[REDACTED]'}

Digging through the API documentation for authorisation, I cannot find any method that uses "password" as a grant type. They clearly state that 'value should be "authorization_code"'.
I'm wondering if there has been a change in Automatic's accepted authorisation methods (perhaps since August 1st?  The last location that HA has was received from Automatic on 01/08/17 at 07:57am GMT.  This is near enough to midnight in California where Automatic's head offices are located,  if they did swap at 00:00.

This is not limited to the Pro units either - I am on a first generation unit and am experiencing the same symptoms and same error message.

I am using a 2nd generation Automatic adapter, the one released before the Pro and Lite models were announced.
I have reached out to Automatic's devs via email to see if it is as simple as the API has changed to support 'authorization_code' only — it seems the most likely case.
An update to armills/aioautomatic will be required if so.

Confirm that this is due to a change in authentication; OAuth2 is now required. Just looked at this page:
https://developer.automatic.com/api-reference/#support
I guess we are using OAuth...

Something's up with Automatic, I can't even reset client secret, it just sits there and doe's nothing.

Switching to OAuth2 will be a better model in any case.
We should be able to redirect the user with the configurator.

Let me know if you need someone to test and thanks for looking into this @armills.

Yes thanks @armills . And I too would be glad to help test should it be required.

Update:
It seems like there's some strange things going on with Automatic's authentication servers. I opened a PR that adds OAuth2 support, but when I'm testing I can never re-authenticate with the refresh token they provide. I'm leaving password support in there for now, in case this is just a temporary problem.
I'd appreciate some volunteers to test out the changes in #8962, to see if you're seeing the same behavior. In order to test out the OAuth2 authentication, you need to comment you the username/password in your configuration.yaml. You'll also need to update the OAuth Redirect URL in your Automatic Apps Manager. It should be set to https://<hass-domain>/api/automatic/callback.

`You'll also need to update the OAuth Redirect URL in your Automatic Apps Manager. It should be set to

https:///api/automatic/callback.`

My "OAuth Redirect URL" is currently set to "https://localhost/api/automatic/callback"

@Coolie1101 You'll probably need to use http instead of https unless you have a cert for localhost, otherwise that should be fine, assuming you're doing the authentication on the same machine running hass. You might need to specify the port though. I've opened the docs PR which provides a little more clarification: https://github.com/home-assistant/home-assistant.github.io/pull/3174/files

I think there developer site is still broken, I'm unable to make any changes to the "OAuth Redirect URL".
I re-enabled the Automatic Device Tracker, and HA is throwing the same error.

Yeah, there's definitely some strange things happening there. You should open a ticket with them if you haven't yet to get more eyes on it. Being unable to reset the client secret is a pretty big problem.

I tested with a second app I created a while back, and still get the same error.
Configuration,yaml
device_tracker:
  - platform: automatic
    client_id: 1234567
    secret:<PHONE_NUMBER>
    username<EMAIL_ADDRESS>    password: your_password

Event Delivery Preference = WEBSOCKET

You need to remove username/password from your config to use OAuth2.

2017-08-13 15:31:12 ERROR (MainThread) [homeassistant.config] Invalid config for [device_tracker.automatic]: required key not provided @ data['password']. Got None
required key not provided @ data['username']. Got None. (See ?, line ?). Please check the docs at https://home-assistant.io/components/device_tracker.automatic/

You can't test this without applying the changes from PR #8962.

Above my skill level, as I was never able to locate "requirements_all.txt" while experiencing issues with another component.

@armills I am getting this error
ERROR (MainThread) [homeassistant.components.device_tracker.automatic] Stored refresh token was invalid.
after I restart my HA

@imaredia Thanks for testing! Is this after successfully performing the first authentication?
I've also been getting that error myself. I can't say for certain, but I think this is just part of the problem that Automatic is currently having with their authentication servers. For now it seems that the only solution is reauthenticating each time hass is started.

yup I am able to successfully perform the first auth, but after waiting for couple of mins I didn't see any of my car tracker so decided to do reboot and after that I had to auth again.

INFO (MainThread) [aioautomatic.session] Fetching trips.
INFO (MainThread) [aioautomatic.session] Fetching trips.
INFO (MainThread) [aioautomatic.client] Opening websocket connection.
INFO (Thread-10) [homeassistant.core] Bus:Handling <Event state_changed[L]: entity_id=configurator.automatic, old_state=<state configurator.automatic=configured @ 2017-08-13T15:59:51.103679-05:00>, new_state=None>
INFO (MainThread) [homeassistant.components.device_tracker.automatic] Websocket connected.
Let me restart my car and see if adapter sends some trips info, In automatic app it shows my trip today tho so I dont think that should be a problem.

I see this was closed, but did it really get fixed? I still cannot get my (2) PROS working.  I am unable to edit my OAuth URL in the automatic dev page.

Best I could tell they have a fix but decided to wait on the release. Wasn't clear to me why that decision was made.
Sent from my Sprint Samsung Galaxy S8+.
-------- Original message --------From: bdriscoll<EMAIL_ADDRESS>Date: 8/20/17  6:56 AM  (GMT-06:00) To: home-assistant/home-assistant<EMAIL_ADDRESS>Cc: tggman<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [home-assistant/home-assistant] Automatic OBDII Tracker – "err_invalid_client" – Change of authorisation method? (#8803)
I see this was closed, but did it really get fixed? I still cannot get my (2) PROS working.  I am unable to edit my OAuth URL in the automatic dev page.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/home-assistant/home-assistant","title":"home-assistant/home-assistant","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/home-assistant/home-assistant"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bdriscoll in #8803: I see this was closed, but did it really get fixed? I still cannot get my (2) PROS working.  I am unable to edit my OAuth URL in the automatic dev page. "}],"action":{"name":"View Issue","url":"https://github.com/home-assistant/home-assistant/issues/8803#issuecomment-323580437"}}}

Balloob was pretty clear about it.  It is a breaking change and breaking changes aren't introduced in point releases (unless there is a major issue, like security).

Thanks.  My bad I didn't read all through #8962

If you wanna try you can go ahead and install dev build if you comfortable with it. I installed it and does passes authentication in first step but after that it doesn’t update the status of my car and whenever i restart HA i have to redo authentication.

Yep. We've got a fix in for 0.52, but even with this change Automatic's servers are still acting strange, so there could be problems editing the OAuth2 URL. If you can't get it changed, you can always paste the query parameters ("?" and afterwards) onto the correct URL for your instance to get it running as a workaround. At this point though we've fixed everything we can on the Home Assistant side.

I understand this issue is closed – but since upgrading to 0.52.0, it seems the websocket connection is not functioning. Have created a new issue under #9137 for reference.  Is anyone else experiencing this issue?


Replace mkdirp with fs.mkdirSync with recursive true

Pull Request Test Coverage Report for Build 4128

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 92.134%

Totals

Change from base Build 4127:
-0.004%

Covered Lines:
1125

Relevant Lines:
1166

💛  - Coveralls

@kulshekhar & @ahnpnl should node 8 still be officially supported by ts-jest?

Hi, yes node 8 is still supported because jest 25 does support node 8. We follow closely what jest supports.

Thanks for the quick response. I should've check jest myself :)
And since node 8 is required, there's no way of replacing mkdirp dep with fs.mkdir then... oh well


ci: run only on linux and add pip dependecy caching

Remove macos and windows hosts and add python 3.11 and dependency caching configuration in the setup-python step.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@ca03fbd). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##             main       #17   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         1
  Lines           ?         3
  Branches        ?         0
========================================
  Hits            ?         3
  Misses          ?         0
  Partials        ?         0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Output Messages

Hi,
How to inject logging into tests? or write to output window or any output sink?

Hi @biqas - If you're executing using dotnet run then Console output should display normally.
If you're using Visual Studio, I think they're still working on showing the Console output in each test results window.
If you want to dynamically retrieve a tests output, you could register a global [AfterEvery(Test)] method.
E.g.
    [AfterEvery(Test)]
    public static async Task TestOutput(TestContext context)
    {
        var output = context.GetTestOutput();
        var errorOutput = context.GetTestErrorOutput();

        // Do something with `output` or `errorOutput`
    }

Does that solve your problem?

Hi,
to get the output yes, but i would like to redirect the logger output to the test output. This is in some complex cases needed to see how far a test came along to look at the logs in the test output.

Something like this:
public MyTest(ITestOutputHelper output, LogLevel logLevel = LogLevel.Debug)
{
    Logger = output.BuildLogger(logLevel, GetType().Name);
}

ITestOutputHelper is from xUnit. This redirects all ILogger messages to the output of the unit test. To achieve this there is an extension needed (Neovolve.Logging.Xunit).

@biqas You can do Logger = new DefaultLogger() for a logger that writes to the console.
Otherwise you can define your own class that inherits from TUnitLogger and then define your own logging implementation.
Does that help?

I think the big thing that @biqas is after (and myself as well) is the ability to log and capture logs for a given test and provide that as output similar to how xunit has the ITestOutputHelper.
It's very close to how OutputWriter and ErrorOutputWriter are working with the test context.  The only issue is that the log information is not available in the the IDE when you're inspecting a given test.

I think the big thing that @biqas is after (and myself as well) is the ability to log and capture logs for a given test and provide that as output similar to how xunit has the ITestOutputHelper.
It's very close to how OutputWriter and ErrorOutputWriter are working with the test context. The only issue is that the log information is not available in the the IDE when you're inspecting a given test.

When TUnit finishes a test it sends all the relevant error / standard output to the runner. So I believe not seeing the output is a current limitation of the new Microsoft testing framework (correct me if I'm wrong) and I believe they're working on it over at the testfx repo

Also it might be a limit or the ide. As this is all quite new there's multiple parts here that all need to work together. I think TUnit is fulfilling it's part and that the IDEs simply need to improve support.

These links below might provide some hints as to what @biqas  is asking about.
https://blog.martincostello.com/writing-logs-to-xunit-test-output/
and
https://www.meziantou.net/how-to-view-logs-from-ilogger-in-xunitdotnet.htm

These links below might provide some hints as to what @biqas is inquiring about.
https://blog.martincostello.com/writing-logs-to-xunit-test-output/
and
https://www.meziantou.net/how-to-view-logs-from-ilogger-in-xunitdotnet.htm

I'll take a look but this is referring to the old VSTest runner. Tunit runs on the new runner. I don't think you can compare them like for like

I really miss ITestOutputHelper, or an equivalent. I do lots of weird stuff through tests, like dumping initializer syntax of the data on a failing test, (using my lib of extensions: https://github.com/frankhaugen/Frank.Testing/blob/main/Frank.Testing.TestOutputExtensions/TestOutputCSharpExtensions.cs), so I can re-create the exact state of a flaky test. I just started using TUnit, so I might have alternatives, but I didn't find them immediately.
A similar mechanism, can be an ILogger/ILogger that is exposed in the context that will write to "Test Output" and not just the console, (I use Rider or full Visual Studio)
As a related (vaguely) concept: capturing Console in a test-run is a concept I have toyed with for XUnit, but I might play around in TUnit to see if something fun can be done: https://github.com/captin411/Captin.ConsoleIntercept

I really miss ITestOutputHelper, or an equivalent. I do lots of weird stuff through tests, like dumping initializer syntax of the data on a failing test, (using my lib of extensions: https://github.com/frankhaugen/Frank.Testing/blob/main/Frank.Testing.TestOutputExtensions/TestOutputCSharpExtensions.cs), so I can re-create the exact state of a flaky test. I just started using TUnit, so I might have alternatives, but I didn't find them immediately.
A similar mechanism, can be an ILogger/ILogger that is exposed in the context that will write to "Test Output" and not just the console, (I use Rider or full Visual Studio)
As a related (vaguely) concept: capturing Console in a test-run is a concept I have toyed with for XUnit, but I might play around in TUnit to see if something fun can be done: https://github.com/captin411/Captin.ConsoleIntercept

TUnit captures console output actually. If you check your test context output after a test it should include any console logs.
So by just doing console writeline, your context output will be populated.
If you need to do more with logs, you can create a new class that inherits from TUnitLogger and new that up yourself. Does that help?

I really miss ITestOutputHelper, or an equivalent. I do lots of weird stuff through tests, like dumping initializer syntax of the data on a failing test, (using my lib of extensions: https://github.com/frankhaugen/Frank.Testing/blob/main/Frank.Testing.TestOutputExtensions/TestOutputCSharpExtensions.cs), so I can re-create the exact state of a flaky test. I just started using TUnit, so I might have alternatives, but I didn't find them immediately.
A similar mechanism, can be an ILogger/ILogger that is exposed in the context that will write to "Test Output" and not just the console, (I use Rider or full Visual Studio)
As a related (vaguely) concept: capturing Console in a test-run is a concept I have toyed with for XUnit, but I might play around in TUnit to see if something fun can be done: https://github.com/captin411/Captin.ConsoleIntercept

TUnit captures console output actually. If you check your test context output after a test it should include any console logs.
So by just doing console writeline, your context output will be populated.
If you need to do more with logs, you can create a new class that inherits from TUnitLogger and new that up yourself. Does that help?

Yeah, stumbled on to it 30 secs after posting, but apparently not deleting quick enough.
Awesome response time!

As an update for everyone on test IDE output windows.
The test metadata I send behind the scenes to the test framework has only recently included support for test output data.
So this means IDEs haven't developed it yet.
VS should be working on it already.
I don't know if Rider are already or not so I've raised an issue here with them: https://youtrack.jetbrains.com/issue/RIDER-117847/Testing-Platform-Test-Output-not-showing-in-IDE

Jetbrains have marked the issue as fixed.
Says it'll be available in the Next 2024.3 public build. 🤞

This is now working in 2024.3 EAP 4. You can either download that, or wait until the official 2024.3 release.


Update docker_release script to be more robust

This update will cause the docker_release script to build and
release the Wallaroo Docker image only for the release and
release-* branches. Adds a VERSION file to use to get
the version of Wallaroo instead of relying on the CHANGELOG.

Approved by @SeanTAllen


Inappropriate string literal completions in object literals

Found in https://github.com/Microsoft/vscode/issues/12667
var foo;

interface I {
    metadata: string;
    wat: string;
}

var x: I = {
    metadata: "/*$*/"
}

Expected: Completions of every identifier in the file, or no completions at all.
Actual: Completions of property names for the containing object literal's apparent type.

https://github.com/Microsoft/TypeScript/issues/11044 seems like another duplicate of this issue

That looks to me like an independent issue. . shouldn't be a completion character in that context, but should in others.


No longer assume fixed module versions.

Simple fix for #2658 - all details there.
Without the change the graph shows no restarts for modules with another module version than "1.0".

With the change module restarts get visible again:

PR Checklist

[ x Explain your changes, so people looking at the PR know what and why, the code changes are the how.
[x] Validate your changes using one or more of the testing methods.

If adding or updating templates:

[x] post a screenshot of templates and/or gallery changes
[x] ensure your template has a corresponding gallery entry in the gallery folder
[x] If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
[x] ensure all steps have meaningful names
[x] ensure all parameters and grid columns have display names set so they can be localized
[x] ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
[x] ensure that steps names are unique or they will fail PR validation (step names are used for localization)
[x] grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
[x] remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

Great improvement! Thanks @alaendle for the fix and thanks @veyalla for the prompt approval.


Bagged trees

Just a note that this is the next chapter I'll be working on. Hope to have a draft by Monday the 16th at the latest, ideally.

Full draft in #30


shadowRadius

shadowRadius (for iOS) works but it's not documented.

@onury  thanks for the heads-up. Created a PR for it https://github.com/bradmartin/nativescript-cardview/pull/45


Fix backup cloudspecs

Issue #, if available:

Replace #1004

Description of changes:

Remove manual backup patching
Make updates to backups based on issues with the documentation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

To confirm, all this change is doing is refreshing the enriched specs files against  the latest version?

Yes and should include the fixes that are in 1006.  We had originally patched in all of the backups stuff. So part of this is taking that out too.

@zjullion the long story here is that backup wasn't originally included so we manually patched the entire thing in there.  They finally got it included in the spec so some of this pull request is removing our manual patching but then including your fixes as well.  I didn't manually patch to https because that seemed like overkill for what we needed here.

Also since I built this manually I did it entirely based on the documentation so I'm curious what your thoughts are on the spec file based on the patching you area doing.  It could be that the spec file is correct already but the documentation is wrong (or I just messed up with the original patch I created... which is why I'm happy to remove it).

Oops, sorry, I had started reviewing before you posted your comment and didn't see the bit about https. Do what you like with that, it's by no means a major issue.

Yea, I wish it was https and maybe its just me being lazy.  I'm going to talk to some internal folks about getting that changed to https over us patching it.  I don't see why it wouldn't be https but creating a bunch of patches to switch it may not be completely valuable to us at this time.


Observability task, optimizing the speed of index conversion

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Describe the proposal

EN: With more and more indicator data, indicator conversion and pull will take more time. With low frequency operation for a service, the delay caused by too slow pull will easily lead to the delay of indicator alarm，Try to use certain algorithms to optimize the conversion process
中文：随着指标数据越来越多，指标转换与拉取就需要更多的耗时，随着针对一个服务是低频的操作，如果拉取过慢产生的延迟就容易导致指标告警的延迟，尝试使用一定的算法来优化这个转换过程

assign to me, thanks


Application error/timeout when all academic years selected

From Projects Dropdown “All Projects”

Card View  (Seems to be working okay on the table view side just slow)

Filters selected (All academic years)

Projects --> All Projects
Select All for the Academic Years drop down box --> Click Apply Filters.


WIP – Add student photo to Student Profile Header

Who is this PR for?
All the educators who use the student profile.
What problem does this PR fix?
In large meetings at larger schools, some educators won't recognize a particular child by name alone. For example, at the start of the new school year in the High School, House Masters have hundreds of new students in their caseload and it takes time for them to learn every student's face.
What does this PR do?
Add student photo to the Student Profile page.
Handling edge cases
Students without a student photo
I wondered how many students are missing a student photo.
> Student.active.count
=> 4768
StudentPhoto.count
=> 4777

We've stored more student photos than active students. But some of those stored photos may be for non-active students.
active_no_photo = 0

Student.active.each do |s|
  if s.student_photos.size == 0
   active_no_photo += 1
 end
end

active_no_photo
=> 269

So about 5.6% of active students don't have any imported photos from Aspen/X2.
Different student photo dimensions
Running ls -S -lat > sorted.txt showed a few things about the photos we have from Somerville:

The smallest photo we have is 4,787 bytes. Its dimensions are 172x207.
The largest photo we have is 154,927 bytes. Its dimensions are 356x433.
Excluding three outliers on the large end, most photo dimensions are between 308x364 and 172x207.

Very initial mocks, figuring out how to position the student image in the profile. Very ugly and leaves a ton of white space on the table. I wonder what it would look like to have a fixed sidebar with student name, key details, and photo? That way the photo is visible even when the SST teams have scrolled down to take notes.

@alexsoble Nice! 👍
My vote would be to punt incremental design changes here and tackle this more holistically (eg as part of the "best list" work).  I think an ideal way to do that design work would be to batch up a few known issues (eg, profile data not useful when taking notes, doesn't show student voice info yet, doesn't yet show transition note strengths to all educators).  Then we could spend ~1-2 weeks on design iteration to address those all at once, since those kinds of design and layout changes for different improvements will all be interrelated and in tension with each other.  It might be harder to tackle iteratively and still have the page feel cohesive.  If that's something you wanted to start up now, I'm up for chatting about it!
Or we could 🚢 the smallest incremental change and get photos live this week.  But spending design energy on other layouts seems like it won't have immediate impact (school gets out Thursday) and it would probably be overwritten by other design work later this summer.

@kevinrobinson Interesting! Going to give you a quick phone call to talk about some of the tradeoffs here.

@alexsoble For ClassListsViewPage, you can try out https://github.com/studentinsights/studentinsights/pull/1833, which merges into this PR.  I can verify that the patch affects the behavior of tests locally for me if I change the timezone on my computer.
After merging that change into your PR, you'll also need to re-run the tests and update the snapshot for ClassListsViewPage.  If I read the diff here and the test failures right, that spec doesn't properly fix the timezone in test.  So you probably ran the tests on your computer and saw this snapshot test fail locally.  You then updated the snapshot, which isn't great, since your change shouldn't have impacted the ClassListsViewPage.  But now the snapshot in this PR essentially says "only pass when run in central time zone."  The test had passed in Travis before, but when you checked in the updated snapshot run in CT, that's why it started failing in Travis (which is in ET).
Let me know if that helps issue no. 2 above, or you want to pair on any remaining bits for it.  That one's a bug with the class list test code.

@kevinrobinson Alrighty, we can try that. 😄
Overall I agree with this comment from October 2017: https://github.com/studentinsights/studentinsights/pull/1216#issuecomment-340110958. I feel the fatigue from snapshots failing on every change, and I'm not super good at catching bugs in snapshot diffs. I'm happy to run with it for a while and then discuss it more but right now I'm just not seeing the upside.

@alexsoble Yep, re: snapshots that's my bad if there's first-time learning friction, and I'm happy to pair with you anytime to share what workflow's worked well for me here.  It sounds like the mixture of figuring out snapshots along with a good ol' pesky timezone bug is making this a pain.  It also might be helpful to check out the FAQs https://facebook.github.io/jest/docs/en/snapshot-testing.html.  And it'd be awesome if you can help make find ways to make testing smoother and simpler.
Snapshots are a little different than normal tests, and if the snapshot files themselves are committed with mistakes, it can be confusing to untangle.  Looking back at commits, I think that's what happened early on here: https://github.com/studentinsights/studentinsights/pull/1823/commits/ad0564a5407f839a138dc26a501bc1cc83858d17 - that checks in snapshots with the timezone change and the different pixel values for the SVG bits (which I think is coming from the same underlying timezone problem).  And from that point on it comes harder to understand what's happening because there's drift between local test runs and Travis and it's unrelated to the changes you're actually making :\
Here's a plan to fix the timezone problem going forward:

Let's improve the way we set the timezone in tests, so that when you and I and Travis run the tests we're running the same time :)  Merging https://github.com/studentinsights/studentinsights/pull/1835 to master will do that.
That will let us remove the short-term patch into this PR yesterday.
Reverting https://github.com/studentinsights/studentinsights/pull/1833 will do that.
Then we can update this PR with the code to set the timezone.  Merging master into this branch will do that (since master will now have https://github.com/studentinsights/studentinsights/pull/1835).

At that point, you can check how things work in local development or with the student profile stories using yarn storybook and verify things look good.  If they do:

check out the two snapshot files on this PR back to what's on master to start fresh
run the tests
only the student profile snapshot should be changed
and since you just verified it looks good, you can update it
and then 🚢 !

Thanks for the help with fixing these flaky tests @kevinrobinson! I think we successfully got my machine to run them as if I were in Eastern Time! ✨

@kevinrobinson Yay! Tests are passing! Thanks again for your help. 😄🌈
Next up today, I'm going to add screenshots to the PR description, do a review of the code, and 🚢.

@alexsoble Awesome!  No problem, thanks for spotting this so we can fix it up, and I'm happy to help out so you can keep moving with shipping some awesome 👩🎓 📷 📸s!

Ah! Remembered that we want to only run this front-end code for Somerville, so we need to add this to PerDistrict.js on the front end to match the per-district function on the Ruby side.

Updated the pull request description with screenshots and comments about manual testing . . . time to 🚢.


Provision with existing empty database

Hello,
is there any way to provision into an existing empty database? I've been trying to wrap my head around this for quiet some time because it isn't always the case that you're granted superuser for the DBMS. Any help would be appreciated!

This should work with the latest aca-py release, if you use the published docker image:
https://hub.docker.com/layers/bcgovimages/aries-cloudagent/py36-1.16-1_0.7.0/images/sha256-8bd108e69eecb3a758d02e6dca79a020f5239ebb79c0c7607c5de2c2401de1b2?context=explore
This includes updates to the indy-sdk postgres driver to allow this exact requirement.

Can confirm this worked! Thank you.

I'm sorry can't confirm that it's working. The user needs to permission for CREATE DB ;(

Can you provide some information about what you have done?  How did you create the database and what startup parameters are you providing to aca-py?

Yes, I've created a gist with a docker-compose https://gist.github.com/tomaaron/62b9af5c37992356f820c0ed0fcebd3a

Closing as dormant. Please reopen if appropriate.


Remove qunit

We only have jquery in this project for qunit. Let's shift to mocha and chuck qunit to the curb. Initial mocha unit tests added in https://github.com/cfpb/capital-framework/pull/655
Current behavior

Project uses qunit.

Expected behavior

Project should use mocha like in cfgov-refresh.

Project actually has switched to Jest, not mocha.


libredirect: implement port-remapping

Motivation for this change
This is my proposed approach to address the perennial darwin problem of network port collisions during the check phases of multiple packages built in parallel.
For anyone who hasn't experienced this problem - because darwin lacks network namespaces, tests which exercise network functionality share the same loopback interface, and two build processes attempting to claim the same port at the same time will interfere with each other, leading to unexplained test failures. You'd think this happens extremely rarely, but in fact it happens frequently with python packages as most changes will trigger a rebuild of both the python38Packages version and python39Packages version at the same time. This causes spurious failures both for reviewers running nixpkgs-review and also on hydra when both packages happen to get scheduled onto the same node at the same time.
An example hydra package that's failing right now due to this is python3Packages.zeroconf on darwin: https://hydra.nixos.org/build/158208739
This change gives libredirect the ability to intercept calls to the socket api and transparently remap the port to another. The remapping is controlled by the environment variable NIX_PORT_REMAP_SEED, the idea being that processes sharing the same "seed" value will be able to communicate with one another seamlessly while processes with a different seed value will be able to communicate over the same apparent port to their cooperating processes without anything interfering with each other.
It's intended that builds will set the NIX_PORT_REMAP_SEED to e.g. $RANDOM in the preCheck, thus assigning a unique value for each build. I know that might make some people uncomfortable introducing a possible source of nondeterminism here, but please consider the nondeterminism of the existing situation on darwin.
For the actual permutation of the ports, I was going to do some fancy pseudorandom nonsense, but for now I decided to keep it simple and effectively use the "seed" as an offset.
Ports below RESERVED_PORT_MAX are excluded from the scheme - they shouldn't be used by test suites anyway and we don't want to risk remapping an unreserved port to a reserved port and throw failures that way.
~This still needs tests, which I've started but I think I'm going to defer until 21.11 is out as ZHF (#144627) is more pressing right now.~ Done
(why configure using a "seed" and not a literal offset value? after all $RANDOM gives you a 15bit integer... well, parsing integers can fail and libredirect doesn't have a nice way of handling failures. running a simple FNV hash can't really fail. also it's better not to make any promises to the user over how we're going to do the remapping)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@risicle any interest in pursuing this further / getting it merged?

Only if others think it's a remotely good idea.

Would posting to https://discourse.nixos.org be a viable option to get people involved and eyes on this?


null guard issue?

I have a test in one of my suites... its an ice breaker that just verifies autofixture components downloaded and interacting with my dev studio correctly.  Interestingly, it started failing with my last autofixture update.  I'll put the test below and report the error I'm seeing... it has always passed previously to my knowledge.
Should I just remove the test, point it to some other type or possibly this is unintended behavior that should be fixed?  Thanks!
        [Theory, Gen]
        public void IdiomaticFixturesAreFunctional([Frozen] IFixture fixture, GuardClauseAssertion assertion)
        {
            var tocheck = typeof(Fixture);
            assertion.Verify(tocheck.GetConstructors());
        }
AutoFixture.Idioms.GuardClauseException: An attempt was made to assign the value null to the parameter "engineParts" of the method ".ctor", and no Guard Clause prevented this. Are you missing a Guard Clause?
Method Signature: Void .ctor(AutoFixture.DefaultRelays)
Parameter Type: AutoFixture.DefaultRelays, AutoFixture, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b24654c590009d4f
etc...

Good catch :smiley: Indeed, the guard clause is missing and therefore the assertion fails. Looks expected. If you wish, you could fire a PR and improve that.
Let me know if I misunderstood the question :wink:


parsing.ts: properly handle P5/P6 images with Maxval >255

When the Maxval is greater than 255, the colors for each pixel are stored in 2 bytes rather than just 1.
Includes addition of two new image files - p6-one-byte.ppm and p6-two-bytes.ppm The former comes from https://commons.wikimedia.org/wiki/File:Example.png, which is in the public domain, and the latter is the same image with a Maxval of 512 - they should appear the same when rendered.
Fixes #35

So it looks like the two byte file is severely white shifted compared to the first image. Looking at a hex dump, the pixel data differs quite a bit. Did you generate the second file by doubling the pixel intensities?
In the 1 byte file the first data point is 0xf4 --> 244 which if doubled should be 488 --> 0x01E8 or 0xE801 depending on the endian. It looks like the first two bytes in the other file are 0x01ea which doesn't seem right either way

Other than that the code seems to be handling the different amounts of data correctly :)

So it looks like the two byte file is severely white shifted compared to the first image. Looking at a hex dump, the pixel data differs quite a bit. Did you generate the second file by doubling the pixel intensities?
In the 1 byte file the first data point is 0xf4 --> 244 which if doubled should be 488 --> 0x01E8 or 0xE801 depending on the endian. It looks like the first two bytes in the other file are 0x01ea which doesn't seem right either way

I just used https://linux.die.net/man/1/pamdepth to change the Maxval from 255 to 512, which is slightly more than double. The pixels are stored with the most significant byte first, and 0x01E8 (from doubling) is just under the actual 0x01EA (from slightly more than doubling). If you have a different image that you would prefer thats fine

@DanielS6 ok so I took a look at the code and the issue was that the proper scaling wasn't done when sending it to the display. As far as I know the display code we use can only work with 256 values for each channel so the way we've implemented it is that during file parsing the data gets converted to a range on the scale of 0-255 regardless of the magic number. This ruins the fidelity of the image for higher channel resolution images but I guess it is what it is for now 🤷♂. At least the image is still viewable

@DanielS6 ok so I took a look at the code and the issue was that the proper scaling wasn't done when sending it to the display. As far as I know the display code we use can only work with 256 values for each channel so the way we've implemented it is that during file parsing the data gets converted to a range on the scale of 0-255 regardless of the magic number. This ruins the fidelity of the image for higher channel resolution images but I guess it is what it is for now 🤷♂. At least the image is still viewable

That makes sense - thanks for identifying the problem and adding your fix - looks good to me

@nagata-yoshiteru Feel to merge this PR, it works fine for me on MacOS don't see any other platform issues (NetBPM specifies that the most significant bits must come first in the file so it should be the same on all platforms)

Once merged can you please make a release as soon as you have time? I came across this issue because it was causing problems with a project I'm currently working on

@DanielS6 What is your nationality? We can add you to the list of people who've worked on the project in the readme :)

I'm fine being listed in the README but (without going in to my speech about how code should speak for itself) I'd prefer not to have my nationality included

I think the project owner is still waking up so it may take a bit of time because he's the only one that can publish the extension

Hi, @DanielS6 @BenWeisz ! I'm sorry for my late response, but I've tested the code and worked fine for my Windows envitonment. So I will merge this PR and publish new version!

Thanks so much!

@DanielS6 Can I add your name (without nationality) in README.md after merging this PR?

Sure, just list me as @DanielS6

@nagata-yoshiteru I confirmed that 1.1.2 is available in VSCode, upgraded, and confirmed that I can now see the image - thanks so much for the prompt review (also @BenWeisz)


How to express ACR image?

The doc shows an ACR image being downloaded with:
resources:
  - container: my_private_container
    image: private:ubuntu14
    endpoint: my_acr_connection

But that doesn't work. I've also tried.
resources:
  - container: my_private_container
    image: ubuntu14
    endpoint: my_acr_connection

That too, didn't work.
resources:
  - container: my_private_container
    image: myregistryname.azurecr.io/ubuntu14
    endpoint: my_acr_connection

That didn't work either.
Can we please get updated docs with the proper way to do this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3339a2e0-be29-1363-f588-b231d4472c02
Version Independent ID: 72dd11a3-704d-d0fd-6dfa-cf49f3352de3
Content: Container Jobs in Azure Pipelines and TFS
Content Source: docs/pipelines/process/container-phases.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: macoope

We are hitting the same thing--we see the auth work but then see:
2018-09-14T19:21:00.6228543Z ##[command]/usr/bin/docker pull ***/***/ci-builder
2018-09-14T19:21:01.5791808Z invalid reference format

I hear that it's a server bug. @TingluoHuang is working on a fix.

Ting finished this work and he doc'd it as well.

@atrauzzi https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=vsts&tabs=yaml#endpoints

Thanks for the updated docs. That's great. I wasn't paying attention to them and tried writing out the image name a different way. The really odd thing was that the build went on for nearly 3 minutes, downloading docker images before saying "oh, I can't download this image. So what was it taking nearly 3 minutes downloading??
2018-10-01T14:41:29.7521479Z ##[section]Starting: Initialize container
2018-10-01T14:41:29.7963375Z ##[command]/usr/bin/docker version --format '{{.Server.Version}}'
2018-10-01T14:41:36.0935104Z '18.06.1-ce'
2018-10-01T14:41:36.1873792Z Docker daemon version: '18.06.1-ce'
2018-10-01T14:41:36.1874135Z ##[command]/usr/bin/docker version --format '{{.Client.Version}}'
2018-10-01T14:41:36.3673345Z '18.06.1-ce'
2018-10-01T14:41:36.4282663Z Docker client version: '18.06.1-ce'
2018-10-01T14:41:36.4387276Z ##[command]/usr/bin/docker login --username "***" --password-stdin ***
2018-10-01T14:41:37.4764700Z WARNING! Your password will be stored unencrypted in /home/vsts/.docker/config.json.
2018-10-01T14:41:37.4767530Z Configure a credential helper to remove this warning.  But it took about 30 seconds longer coming from ACR than it took coming from docker hub, which is the opposite of what I was hoping for.

I wonder if an ACR repository in a different azure region would improve performance. What region are the OSS builds happening in?

for your account, it's in azure CUS region

Thanks. Adding a replication region to South Central US brought ACR perf up to Docker Hub levels -- but sadly, not beyond them. I guess I need to accept the 2:27 time to download the image with each linux build.

@AArnott we are working on pre-cache most of the populate linux container base images onto the Hosted Ubuntu 1604 pool. i think after that work is done, your docker pull will get faster. :D


add batch upload support

Coverage decreased (-0.13%) to 79.35% when pulling ed488101979a8386beb8aa1ef56f9a1d1c8fd2ae on sadam21:batch-upload into f1fa84bdad6253530108a4069ec9329bf87afcc4 on martiner:master.

Coverage decreased (-0.13%) to 79.56% when pulling bcfc107711d3cc91f9a88aa2ae5e89506c2ad07f on sadam21:batch-upload into b9712b04e9089d589492462469c247cfd60526f1 on martiner:master.

Coverage decreased (-0.18%) to 79.44% when pulling faa55e9360689494076aa3d7ff6df0181b15fbb5 on sadam21:batch-upload into 6227fe22ea2714adbde37d95634094837903569c on martiner:master.


New check: com.google.fonts/check/color_cpal_brightness

Description
    Layers of a COLRv0 font should not be too dark or too bright. When layer colors are
    set explicitly, they can't be changed and they may turn out illegible against dark or bright backgrounds.
    While traditional color-less fonts
    can be colored in design apps or CSS, a black color definition in a COLRv0
    font actually means that that layer will be rendered in black regardless of the
    background color. This leads to text becoming invisible against a dark background,
    for instance when using a dark theme in a web browser or operating system.

    This check ensures that layer colors are at least 10% bright and at most 90% bright, when not
    already set to the current color (0xFFFF).

To Do

[x] update CHANGELOG.md
[ ] wait for all checks to pass
[x] request a review

This whole check is misguided and confusing (what's "color brightness" anyway, how's that defined?) -- there's two problems:

whether black or white end up being illegible depends on the background, and CPAL version 1 allows specific palettes to be designed for dark or light backgrounds; besides, CPAL can contain more than one palette; this check completely ignores that, just takes the first default palette, assuming it's the only one, and simply goes about complaining that some glyphs are "too dark or too bright" (verbatim). But it's wrong to assume that a given palette entry index maps to only one given color, as there could be several palettes, and some may intentionally be designed for light/dark background.
the check only considers this to be a problem for COLR version 0; why not also COLR  version 1? How's that different from the former in the need to "not be too dark or too bright"? I'm pointing this out not much to recommend you include COLR version 1 in this check as well, but to highlight its arbitrariness.

FWIW, I would just remove this check altogether and remind designers about the possibility of using the 0xFFFF special foreground color palette entry index somewhere else (e.g. documentation about creating color fonts).


Add rope science 11 doc: practical syntax highlighting

This document goes into a fair amount of detail about how a plugin can
efficiently increment transducers (useful in particular for syntax
highlighting) in an incremental way.

rendered

Any improvements (such as graphs) can be added in a later commit.

Next time this gets updated, add:
Chuck Jazdzewski commented:
Interesting. This describes, almost exactly, how syntax highlighting was implemented in Turbo Pascal 7.0 in 1993. We called the "frontier" the high-water mark. We stored a scanner state using one byte per line which included such things as the comment form the scanner was in. We also kept the "invalidated" states as described.
I also demonstrated a technique that would allow recalculating the states without rescanning in certain cases as the end-line state can contain enough information to determine what the state of the line would be given a change in the previous state. This was too difficult to maintain over time so it was never implemented.

Next time this gets updated, add link to https://gist.github.com/marijnh/f29b71c6f751122d53eddd2e13a87e7f


requirements.txt file not found

I'm trying to build this using the deploy.sh file, but when I run it I get the following error
requirements.txt file not found. Continuing the build without dependencies.

Once the lambda deploys it produces errors because the deps are not found.
Any ideas? I'm on a M3 Macbook and using Python 3.9.

Hi @garrypassarellainfluencer,
That error does not constitute to complete build error. All the necessary Python dependencies are built in the Lambda layer instead in the layer directory.
The line Continuing the build without dependencies. actually indicates this is not a critical error and build should proceed. But if you do want to supress it, you can create an empty requirements.txt file in ./function directory.
If you don't mind, you can share the full build logs here while redact necessary information.

By the way, I created a new repo with similar feature to this repos' application trying to use better AWS-native technologies,
but it may require more AWS experience.
https://github.com/gabrielkoo/self-learning-rag-it-support-slackbot

I was able to solve my issue by setting up a virtual environment (I don't use Python that often, so I don't know if not doing this was just down to my ignorance or something worth documenting).
python -m venv venv
source venv/bin/activate

I also had to pin some dependencies in requirements.txt to solve a weird issue where it would throw numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject errors
pandas==2.0.1
numpy==1.24.3

After this everything worked smoothly :-)


paranoid was not found in any of the following sources

Can anyone help to solve this problem
`Plugin [id: 'io.michaelrocks.paranoid', version: '0.3.7', apply: false] was not found in any of the following sources:

Try:

Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Exception is:
org.gradle.api.plugins.UnknownPluginException: Plugin [id: 'io.michaelrocks.paranoid', version: '0.3.7', apply: false] was not found in any of the following sources:

Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
Plugin Repositories (could not resolve plugin artifact 'io.michaelrocks.paranoid:io.michaelrocks.paranoid.gradle.plugin:0.3.7')
Searched in the following repositories:
Gradle Central Plugin Repository
Google
MavenRepo`

Do hou have an solution?
I have same problem!

but its show code 401 🤔 from jitpack


Caesar Cypher needs to conform to normal Bonfire style

We shouldn't have comments, and we should have links to relevant MDN articles.
Challenge Bonfire: Caesars Cipher has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function rot13(encodedStr) {
  var codeArr = encodedStr.split("");  // String to Array
  var decodedArr = []; // Your Result goes here
  // Only change code below this line

  // Only change code above this line
  return decodedArr.join(""); // Array to String
}

// Change the inputs below to test
rot13("SERR PBQR PNZC");

This seems to already be fixed on staging. Closing issue.


files bug? example: qa.restricted: umsp

the message in subsetting logs:
"No metadata file was found to parse binary properties from for variable EUPATH_0043203"
but the files seem to include the variable.
so the message is unclear.

Backend error is:
Caused by: java.lang.IllegalStateException: No metadata file was found to parse binary properties from for variable EUPATH_0025072
	at org.veupathdb.service.eda.ss.model.variable.StringVariable.getBinaryConverter(StringVariable.java:37) ~[service.jar:3.9.0]
	at org.veupathdb.service.eda.ss.model.reducer.BinaryValuesStreamer.streamFilteredEntityIdIndexes(BinaryValuesStreamer.java:49) ~[service.jar:3.9.0]
	at org.veupathdb.service.eda.ss.model.filter.SingleValueFilter.streamFilteredIds(SingleValueFilter.java:49) ~[service.jar:3.9.0]

Resolved by this commit.


Incorrect floating point parsing

Description
I have a sample json file which has an array of array of array of float weights.
{"input_size": 3, "layer_sizes": [2, 2], "weights": [[[0.50, 0.50, 0.50], [0.30, 0.30, 0.30]],[[0.40, 0.40, 0.40], [0.20, 0.20, 0.20]]]}
When I parse json the some of the floating points value show with less precision such as 0.30 is parsed as 0.299999999999
Reproduction steps
`        std::ifstream file(fileName);
nlohmann::json data = nlohmann::json::parse(file);
    int inputSize = data["input_size"];
    std::vector<int> layerSizes = data["layer_sizes"];
    auto weights = data["weights"];`

Expected vs. actual results
expected is to have .30 instead of parsing floating point as .29999999999.
Minimal code example
`       std::ifstream file(fileName);
        nlohmann::json data = nlohmann::json::parse(file);

        int inputSize = data["input_size"];
        std::vector<int> layerSizes = data["layer_sizes"];
        auto weights = data["weights"];`
json file:
`{"input_size": 3, "layer_sizes": [2, 2], "weights": [[[0.50, 0.50, 0.50], [0.30, 0.30, 0.30]],[[0.40, 0.40, 0.40], [0.20, 0.20, 0.20]]]}`

Error messages
No response
Compiler and operating system
VS2017
Library version
3.11.3
Validation

[X] The bug also occurs if the latest version from the develop branch is used.
[X] I can successfully compile and run the unit tests.

The number 0.3 cannot be exactly represented as double, see https://float.exposed/0x3fd3333333333333. This is independent of this library, C++, or your operating system. See https://json.nlohmann.me/features/types/number_handling for more information.


remove operation id prefix

You have read the contributors guide
Your code is properly formatted according to our code style
Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
Pull Request contains link to the issue
Pull Request contains link to any dependent or related Pull Request
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket
Fix https://github.com/quarkiverse/quarkus-openapi-generator/issues/866
When use smallrye openapi operationid strategy CLASS_METHOD,operationId fields take the form of "class_name_method". For example, "User_findAll". We want remove operationId prefix (e.g. User_findAll=> findAll)
In this PR, we add a config properties remove-operation-id-prefix,to delete class name from operationId. The properties are passed to the openapi-generator, and the specific functions are executed by the openapi-generator.
https://github.com/OpenAPITools/openapi-generator/blob/4c5a57fe7bae59483bb8fa9218be8dc4f82e1bda/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java#L5638
You have read the contributors guide
Your code is properly formatted according to our code style
Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
Pull Request contains link to the issue
Pull Request contains link to any dependent or related Pull Request
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket
Fix https://github.com/quarkiverse/quarkus-openapi-generator/issues/866
When use smallrye openapi operationid strategy CLASS_METHOD,operationId fields take the form of "class_name_method". For example, "User_findAll". We want remove operationId prefix (e.g. User_findAll=> findAll)
In this PR, we add a config properties remove-operation-id-prefix,to delete class name from operationId. The properties are passed to the openapi-generator, and the specific functions are executed by the openapi-generator.
https://github.com/OpenAPITools/openapi-generator/blob/4c5a57fe7bae59483bb8fa9218be8dc4f82e1bda/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java#L5638

@ricardozanini   @ricardozanini
Sorry I messed up my commit, so I rebuilt this PR.


fix: unhandled promises in CDP targets

This PR fixes an issue where Node.js throws from unhandled promises in the array due to the await from sending 'Runtime.runIfWaitingForDebugger'.

cc @thiagowfx @Lightning00Blade


Cursor Follower Not Tracking Properly: Cursor Lag or Misalignment

🖥 Frontend Issue
Description
The multicolored cursor follower gets too far from the cursor if one switches tabs or the cursor returns to the web page after navigating the system taskbar.
Expected behavior
The cursor follower should move along with the cursor, even with some time lag but the cursor should be overlap the follower.
Actual behavior
The follower is far away from the cursor. If there is some time lag, it is fine but there seems some issue with the frontend followup of the cursor.
Screenshots or Video

Are you participating in GSSoC?

[x] Yes

Thank you for your response! The issue I’m experiencing is specific to the misalignment of the cursor follower, especially when switching between tabs. After a tab change, the follower appears offset from the cursor, which affects the overall user experience.
I did notice a previously raised issue regarding the cursor follower being slow and laggy. However, my concern is more about the follower’s position rather than its speed.
Please let me know if there's any further information or specific tests I can provide to help address this. Thank you!

@AaryaShrivaastava go for it take your time and make PR


yarn package pins nodes 8 and ignores node 10 installed via default.nix

Issue description
Beware, new nix user here so this may be entirely my fault. Apparently, the "yarn" package gets its own nodes version and ignores the nodejs version configured in the default.nix file.
I have tried finding docs on how to control a possible "indirect" dependency but couldn't figure this out.
Steps to reproduce
I have this default.nix file
with import <nixpkgs> {};
stdenv.mkDerivation rec {
  name = "env";
  env = buildEnv { name = name; paths = buildInputs; };
  buildInputs = [
    yarn
    nodejs-10_x
  ];
}

Running yarn however for a package.json that restricts
  "engines": {
    "node": "^10.12.0"
  }

results in an error.
[nix-shell:~/dev/mc/meshfed-release/panel]$ yarn
yarn install v1.12.3
[1/5] 🔍  Validating package.json...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^10.12.0". Got "8.14.1"
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[nix-shell:~/dev/mc/meshfed-release/panel]$ node --version
v10.12.0

Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.
 - system: `"x86_64-darwin"`
 - host os: `Darwin 18.2.0, macOS 10.14.1`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.1.3`
 - channels(jrudolph): `"nixpkgs-19.03pre165281.7d864c6bd63"`
 - nixpkgs: `/Users/jrudolph/.nix-defexpr/channels/nixpkgs`

For anyone else using nvm:
With nvm, you can't have any version of node to be installed with yarn. To solve this, you can do: (pkgs.yarn.override { nodejs = null; })

For anyone else who usese @jaredramirez's trick, it is broken after this change: https://github.com/NixOS/nixpkgs/commit/4369da19c9f1904fda639b4645c46335cf04984d:
$ nix-shell -p '(pkgs.yarn.override { nodejs = null; })'
error: value is null while a set was expected

       at /nix/store/gl5k534l2h2msyd38i179zfpxfid1hjm-h2mn9hkw60rhlv4fyhz287127dim9r01-source/pkgs/development/tools/yarn/default.nix:38:17:

           37|     maintainers = with maintainers; [ offline screendriver marsam ];
           38|     platforms = nodejs.meta.platforms;
             |                 ^
           39|   };
(use '--show-trace' to show detailed location information)

The fix I'm using is to also override meta.platforms:
$ nix-shell -p '(pkgs.yarn.override { nodejs = null; }).overrideAttrs (oldAttrs: { meta.platforms = nodejs.meta.platforms; })'


feat(secret): immutable secrets

Resolves https://github.com/cdk8s-team/cdk8s-plus/issues/343

💚 All backports created successfully

Status
Branch
Result

✅
k8s-21/main

Questions ?
Please refer to the Backport tool documentation

💚 All backports created successfully

Status
Branch
Result

✅
k8s-20/main

Questions ?
Please refer to the Backport tool documentation


Nivo evaluation

@MaikNeubert the PR is good enough to be merged. Still would like to have some more answers on the questions above

@HaGuesto
I refactored most of the let uses to const and will prefer const more in the future. I also memorized some computations more optimizations will follow in future PRs. In custom-graphs currently only the CenterAxisBarChart will stay, the rest will be deleted so i did not put any more work into refactoring the components.


How to change the initial sandwich icon?

I need to change the inital sandwich icon to a plus icon with a custom svg. How to do it?

I haven't looked at it in customization.
openButtonBuilder: RotateFloatingActionButtonBuilder(
child: const Icon(Icons.account_box),
fabSize: ExpandableFabSize.regular,
foregroundColor: Colors.amber,
backgroundColor: Colors.green,
shape: const CircleBorder(),
),


test_start/stop event hook are never called in 1.5.3

in locust distributed locust I added a test for https://docs.locust.io/en/stable/api.html#locust.event.Events.test_start
@events.init.add_listener
def on_locust_init(environment, **kwargs):
        logging.info("Master init.")
    else:
        logging.info("Worker init")

@events.test_start.add_listener
def test_start(*a, **kw):
    print("test_start 1")

@events.test_stop.add_listener
def test_stop(*a, **kw):
    print("test_stop 1")

class QuickstartUser(HttpUser):
    ...more code here...

test_start (or stop) methods are never called (not in master and not in worker). other events types are called as expected.

my mistake. master not with same test code


Support windows platform compilation

After adding some compilation options, indeed it is possible to compile on Windows. However, compiling on Windows can be slightly cumbersome as it requires the installation of OpenSSL and the setup of some environment variables, such as OPENSSL_LIBS_DIR and OPENSSL_DIR. It would be even better if there were a compilation script like build.rs.

After adding some compilation options, indeed it is possible to compile on Windows. However, compiling on Windows can be slightly cumbersome as it requires the installation of OpenSSL and the setup of some environment variables, such as OPENSSL_LIBS_DIR and OPENSSL_DIR. It would be even better if there were a compilation script like build.rs.

yes, if openssl-sys compile failed,we could set openssl vendor feature


Move Dataset.swift over from TensorFlow.

@eaplatanios A test of moving dataset over.

Confirmed that swift test passes on macOS.

This file should have been adapted to use the tensorflow.org license header and use 4-space indentation.


Revert "[MM-8497] Ability to set Do Not Disturb for a specified period of time  (#7037)"

Summary
This reverts commit 04ebf314dfcb0934ed76d988ce692cfc539e3394.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/15640
Related Pull Requests

Has server changes: https://github.com/mattermost/mattermost-server/pull/17657

Release Note
NONE

Depending on when cloud was cut, this won't cherry-pick cleanly into that branch given the TypeScript typing added. Just a heads up that I may need to do this manually in cloud.

@amyblais should I merge directly, or do you want to have someone from QA looking over it as well?


Support .NET 6 on Linux

Hi,
I'm trying to use this library with .NET 6 on a docker alpine image. However I'm running into this  issue. Are there plans of swapping out the System.Drawing dependencies for one of the recommended libraries?
Thanks!

Hello, I hadn't seen that they killed System.Drawing.Common, I'll check which lib to use now.
Thanks for the report.

Hello, @Tagliatti did you make decision on the library? If so, I can try and put a PR together. I need .NET 6 on Linux support.

@drusellers I'm having a painting quality problem on image sharp and I still don't know how to solve it, if you can help, on the net6 branch.
System.Drawing

ImageSharp


Create globals crate here & bring over generate-binutils-symlinks

are we keeping this open until generate-binutils-symlinks works without having to run two different versions of it?

Yes, that was what I was thinking; but I can also make a separate issue for that if you want

Closed by https://github.com/malleatus/shared_binutils/pull/22


Updating README from branch example

Updates
I updated the readme file. Please review and accept.

Thoughts
Probably shouldn't, but okay 👍


Document need to set app's config file sharing to global

The video tutorial mentions that you need to share config file objects globally for the app that is using eventgen but this isn't mentioned in the documentation. It would be helpful if this is also highlighted in the README and the tutorial doc.

This issue has been fixed. If you see the issue again in the latest version, please open a new issue.


[Accordion] Patch for TypeError on mismatched prop types when type='multiple' and defaultValue='string'

Description
Patch for #958 . Details in issue. Checks defaultValue for type to prevent TypeError

Agreed, I don't think we should silently "fix" things for people who provide an incorrect API. We should guide them to fix their incorrect implementation.
Since this is an issue for non-TS users only, my vote would be something like:
Accordion.propTypes = {
  type(props, propName, componentName) {
    const value = props.value || props.defaultValue;
    if (props.type === 'multiple' && value && !Array.isArray(value)) {
      return new Error('Invalid prop \`type\` of value \`${props.type}\` supplied to \`${componentName}\`. Expects \`single\` when `defaultValue` or `value` prop is type \`string\`.
    }
  },
};

my brain sees it kinda backwards from that, that instead of validating the type, it would be validating the defaultValue or value`

I thought that too initially but then you have two separate prop type validators, this seems less boilerplate.
Accordion.propTypes = {
  value(props) {
    if(props.type === 'multiple' && typeof props.value === 'string') {
      // error
    }
    if(props.type === 'single' && Array.isArray(props.value)) {
      // error
    }
  },
  defaultValue(props) {
    if(props.type === 'multiple' && typeof props.value === 'string') {
      // error
    }
    if(props.type === 'single' && Array.isArray(props.value)) {
      // error
    }
  },
};

Obviously we can abstract the validator into a validator function but the alternative I provided avoids abstraction and achieves the same thing.

All works for me. Thanks for quick response and sharing the thinking of the library on this minor issue. Changes pushed!

Sorry for the delay, thanks for this @hoop71 !

Glad to contribute!


fix: depend on java-war-buildpack

Remove duplicated code taken from the java-war-buildpack and directly use the java-war-buildpack instead.
Update the README file to point to the java-war-buildpack's README for default values of the JAVA_VERSION and JAVA_WEBAPP_RUNNER_VERSION environement variables.

Tested here: https://fku-geo.osc-fr1.scalingo.io/

If it works as expected, perfect

For some reason it doesn't seem to work when running in the context of a multi-buildpack.
In this case, the temporary Geoserver remains unreachable:
+ curl --retry 8 --retry-connrefused -4 http://localhost:4231
---> Started temporary GeoServer on http://localhost:4231 (pid: 584)
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to localhost port 4231: Connection refused
Warning: Transient problem: connection refused Will retry in 1 seconds. 8
Warning: retries left.
...

I'm investigating.

The latest commits (especially https://github.com/Scalingo/geoserver-buildpack/pull/4/commits/bd952039e07f01fb00e9516c35996ae1bc7bc2f1) fix the issue with the multi-buildpack.
Successfully tested with:

geoserver-buildpack alone + scalingo-22
multi-buildpack + scalingo-22
multi-buildpack + scalingo-22-minimal

Kind Ping @soulou: Could you please review the latest changes? Thanks :bow:

Of course, sorry, it was a bit hidden from me thanks for the ping


Ansible 2.x compatibility

Hello
There are some fixes to be compatible with Ansible 2.0/2.1. Please consider merging.

Thanks @zeelax!


Google Sign In issue

Hi,
I've added Google as an identity provider to my Azure Entra instance. Unfortunately I faced the following error message from after trying to sign in via Google.

You'll find the description of the error message here:
https://support.google.com/accounts/answer/12917337?hl=en#403disallowed&zippy=%2Cdisallowed-useragent
It seems like an user agent is missing.

Fixed by PR from @jnelle


registry_external_url not recognised in hiera

Can this be confirmed as working or not?
Every hiera directive for gitlab.rb I need works for me except
gitlab::registry_external_url: 'somedomain.com:4567'
and
gitlab::registry_nginx:
ssl_certificate: '/etc/gitlab/ssl/somedomain.com.crt'
ssl_certificate_key: '/etc/gitlab/ssl/somedomain.com.key'
Before I keep on digging with my local instance I need to know that it does actually work.
thanks.

Hi kalischt,
We use all three of these configuration options through a wrapper module and they work fine, thus I see no reason why they should not work with Hiera. But since this is an old issue I assume you figured it out by now?


prerender parameters

Hello!
I would like to run inference on my own data and I was trying to understand all parameters in MyModel.yaml.
Do I need to change sphere_radius and maximum_body_diameter according to my own model?
If yes, what do these parameters mean?
Thank you!

maximum_body_diameter means the radius of your object.
sphere_radius is the distance between cameras and your object. DeepAC samples several cameras from a sphere and the radius of the sphere is sphere_radius.
For example, the diameter of your object is 0.1m, the maximum_body_diameter should be bigger than 0.1m, such as 0.3, 0.5 and 0.8. Besides, the sphere_radius should be bigger than the maximum_body_diameter, such as 0.8, 1.0 and 1.2.
Set the output_mask to True in your config. The rendered masks will be automatically saved. Make sure that you can watch the whole mask of your object from a sampled camera. If not , you need to update the maximum_body_diameter and sphere_radius to a bigger value.


fix: Update deps to fix runtime no longer support. Close #38

What I'm trying to solve
The runtime parameter of python3.6 is no longer supported for creating or updating AWS Lambda functions. error during the npm run deploy-website step
Steps to reproduce

Follow the instruction until the npm run deploy-website step

Expected behavior

Deploy PowerTunerWebsiteStack successfully

Actual behavior

The runtime parameter of python3.6 is no longer supported for creating or updating AWS Lambda functions. error

Tested result

Hi @mattymoomoo, this PR should fix the minimum runtime issue