Edge Tools , OOM error when ssh connects to a remote resource

Type: Bug
Works fine locally but crashes when remote.
Task Manager shows VS Code memory gradually growing to about 3GB then crashing.
CPUs	Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz (4 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)
Memory (System)	7.73GB (2.94GB free)
Process Argv	--crash-reporter-id 1ec25f90-4b42-4e57-a40d-3c519fe4efec
Screen Reader	no
VM	0%
Extension version: 2.1.3
VS Code version: Code 1.85.0 (af28b32d7e553898b2a91af498b1fb666fdebe0c, 2023-12-06T20:48:09.019Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Connection to 'ssh-remote+(hide remote IP)' could not be established

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30899288
vscaat:30438848
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
282f8724:30602487
89544117:30613380
vscrpc:30673769
showlangstatbar:30737416
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30885897
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
dsvsc019:30917259

Thanks for filing. Marking as a tracked bug so our team can prioritize and take a look.

Thanks for filing. Marking as a tracked bug so our team can prioritize and take a look.

I just tried it, and the issue did not reoccur.
This month, I upgraded version of vscode (1.85.0>1.85.2) and Edge tools (2.1.3>2.1.4), including those on the remote server. Perhaps this issue can be closed now?

Thanks so much for coming back and updating this issue. Yes, let's close it now, and we can always re-open it (or open a new one) if the issue occurs again.


Only return value if it exists.

Previously would return the assertion value (false) if the value did not exist.

:+1:
I can publish since this is not a private repo.

If you would be so kind.


How to use PHP

Hello,
I want to run my website in PHP. I don't find how.
Can you help me to run my php program in a web page ?
Thank's
b.S

https://code.thebaselab.com/extras/frequently-asked-questions#local-runtime

My PHP code is not running in the web privew.
The default web preview only serves static documents and does not run PHP code. To run a local PHP development server, run php -S localhost:8000 in the terminal and visit localhost:8000 in Safari or other browsers.


Converted React Javascript to Typescript

In the latest PR i forgot to convert javascript to typescript, all fixed now!

looks good


fix anchor link to handler registration

Fixes one issue in #4649

Illegal link: [Authorization handlers must be registered](policies.md#security-authorization-policies-based-handler-registration) -- missing bookmark. The file security/authorization/policies.md doesn't contain a bookmark named security-authorization-policies-based-handler-registration.

Reference Build Report

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@scottaddie my first PR from forking -> cloning -> branching -> running docfx -> commiting -> pushing!  🎉

@spottedmahn Glad to hear you're up and running. Thank you for all of your help with the docs!

@spottedmahn  Thanks again. Congrads on the completing the Git process.


Installing kubeadm

Can you please review https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/
if the SWAP needs to be disabled for kubelet is still accurate?
The reason I am asking is based on discussion in https://github.com/kubernetes/kubernetes/issues/53533
There is a development to enable SWAP merged in July 2021.
Has it been released with 1.25 or 1.26 ?
Thanks
Lin

Hi @springland
Currently, it is in the alpha stage. Here is the KEP you can read about it: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2400-node-swap
Corresponding KEP Issue: https://github.com/kubernetes/enhancements/issues/2400

As mentioned in the issue, the beta release is planned for k8s v1.28.
you can enable it by changing the feature gate NodeSwap to true, which is currently by default false.
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

/kind support

Got it. Thanks for the help.

Thanks for the help.

welcome

Closing this issue as it is resolved.
/close


Kibana-5 fails to launch with custom-config - permission denied

In order to switch-off x-pack components (https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html) I have supplied my own kibana.yaml file and provided the following 'CMD' instruction via a docker-compose.yaml file:
kibana -c /usr/share/kibana/kibana-5.yaml
On launch, I now get the following:
"type":"log","@timestamp":"2016-11-14T14:58:13Z","tags":["fatal"],"pid":13,"level":"fatal","message":"EACCES: permission denied, open '/usr/share/kibana/optimize/bundles/monitoring.entry.js'","error":{"message":"EACCES: permission denied, open '/usr/share/kibana/optimize/bundles/monitoring.entry.js'","name":"Error","stack":"Error: EACCES: permission denied, open '/usr/share/kibana/optimize/bundles/monitoring.entry.js'\n    at Error (native)","code":"EACCES"}}

Presumably something to do with the permissions run when the start-up script does not get run with kibana as the only argument?

Can you provide your full docker run line or docker-compose.yml file contents?

The docker-entrypoint.sh script we use doesn't touch any file permissions, but it does switch to the kibana user, so any files Kibana needs to access at runtime need at least read permissions for that user. :+1:

This image is officially deprecated in favor of upstream's images (see https://www.elastic.co/guide/en/kibana/current/_pulling_the_image.html).
For more information, please see docker-library/elasticsearch#160, docker-library/docs#842, and docker-library/docs#945.

This image has been deprecated in favor of the official kibana image provided and maintained by elastic.co. The upstream images are available to pull via docker.elastic.co/kibana/kibana:[version] like 5.4.2. The images found here will receive no further updates once the 5.6.0 release is available upstream. Please adjust your usage accordingly.
Elastic provides open-source support for Kibana via the elastic/kibana GitHub repository and the Docker image via the elastic/kibana-docker GitHub repository, as well as community support via its forums.

Thanks!


Descriptions of the TOP operator and the BETWEEN keyword are missing

.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 46fe839e-e108-404c-03b7-3e93efc0af65
Version Independent ID: 6d90520e-63ea-5820-abad-9541dedb551a
Content: SQL language syntax in Azure Cosmos DB
Content Source: articles/cosmos-db/sql-api-query-reference.md
Service: cosmos-db
GitHub Login: @LalithaMV
Microsoft Alias: laviswa

This document doesn't mention neither TOP nor BETWEEN which can be used in this SQL dialect. All other language elements seems to be described here. I've assumed this omission is not on propose.

@arturek Thank you for the detailed feedback. This is being assigned to the content author to evaluate and update as appropriate.

@arturek thanks for pointing out the issue, the syntax for these commands are not listed in the doc however, you can see some examples in the following docs:
Examples with BETWEEN keyword: https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-sql-query#between-keyword
Examples with TOP keyword: https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-sql-query#TopKeyword
We will add a work item in our backlog to update the doc with syntax. For now, I hope the examples help.

#please-close


Fixing issue #892

Checking the state of Visual Studio (Not minimized) and the ToolWindow (IsOnScreen) before firing autoreload command. Added unit test coverage for the same.

Jim, please take a look when you have some time

PTAL


feat(query-devtools): Add Light mode support

This PR introduces light mode to devtools

Light Mode can be turned on from the settings tab

There is also a system theme that listens to changes on your system preferences for the OS.
These settings are persisted in localStorage so it will remember the user's set theme on reloads and refreshes.

Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

packages/query-devtools/src/utils.tsx
49.20% <74.64%> (ø)

... and 80 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


webpack Warning with local API

Link to reproduction

To Reproduce

Describe the Bug
Discord thread
Hi,
I'm using a custom endpoint on my Product Collection and get this webpack warning:

And here is my endpoint:

I can also add a remark: between v1 and v2 the type returned by "findById" changed from "GeneratedType" to "TypeWithID & Record<string, unknown>".
Doesn't it make more sense to return the "Product" type instead?

Thx !
Payload Version
2.0.3
Adapters and Plugins
"payload": "^2.0.3",  "@payloadcms/bundler-webpack": "^1.0.2",  "@payloadcms/db-mongodb": "^1.0.1",

Hey @ClementLaval — I just did some testing and for me, the findByID operation result is typed as expected:

It might have to do with the fact that you are passing a PAYLOAD_COLLECTIONS.PRODUCTS.
See the example below:
const PAYLOAD_COLLECTIONS = {
  PAGES: 'pages',
}

 // this one works because we say `as const`
const PAYLOAD_COLLECTIONS_AS_CONST = {
  PAGES: 'pages',
} as const

export default buildConfig({
  onInit: async (payload) => {
    // Works (result typed as Page)
    const page = await payload.findByID({
      collection: 'pages',
      id: 123
    })

    // Doesn't work (can't infer based on PAYLOAD_COLLECTIONS.PAGES)
    const page2 = await payload.findByID({
      collection: PAYLOAD_COLLECTIONS.PAGES,
      id: 123
    })

    // Works (PAYLOAD_COLLECTIONS_AS_CONST defined as const)
    const page3 = await payload.findByID({
      collection: PAYLOAD_COLLECTIONS_AS_CONST.PAGES,
      id: 123
    })
  },
  // rest of config here
})

I think this should resolve your issue. Let me know!

@jmikrut You got it! It's ok after generating again my types ! 💪
Thank you !

I got the same issue, and declaring Collection as const , or using string does not work for me.
What works for me is downgrading typescript package<EMAIL_ADDRESS>gives me issue, but<EMAIL_ADDRESS>works fine.


Link to K3s / Azure / Terraform is broken

Jumpstart scenario or ArcBox flavor which you are working on.
Deploy Rancher k3s on an Azure VM and connect it to Azure Arc using Terraform
Describe the bug.
At Deployment the link Navigate to the terraform folder is broken, it points to https://github.com/microsoft/azure_arc/tree/main/azure_arc_k8s_jumpstart/rancher_k3s/terraform and should point to https://github.com/microsoft/azure_arc/tree/main/azure_arc_k8s_jumpstart/rancher_k3s/azure/terraform
To Reproduce.
Steps to reproduce the behavior:

Go to Deploy Rancher k3s on an Azure VM / Deployment
Click on Navigate to the terraform folder
See error 404

Expected behavior.
Section https://github.com/microsoft/azure_arc/tree/main/azure_arc_k8s_jumpstart/rancher_k3s/azure/terraform of GitHub repo is displayed.

As this is a minor issue I would fix it myself and put in a PR.


[Sim plots] Too many plots at once; fix via >1 page selectable via sidebar

TODOs

[ ] Refactor the sim plots webapp, via a tab on left for each group of plots. (See "inspiration" below)

Specifics: using the same style as "inspiration" below, group the plots with the following Sidebar label -> plots:

"Profit" :: {Predictoor profit vs time, Trader profit vs time, pdr profit dist, trader profit dist}
"Model performance" -> {accuracy, f1, log loss}
"Model response" -> {Variable importances, Contours = model response}

Background / motivation
From matplotlib -> streamlit work #749 then streamlit -> dash work #906 we now have beautiful sim plots in a webapp, great. See "status quo screenshot" below.
However there's already a lot of plots in one webapp. They could readily be grouped, each into their own screen, giving them more "space to breathe" with more interactivity etc. For example, impacts + sweeps could go into their own screen.
Towards a solution
What we want is a Plotly/Dash "Multi-Page App", where:

there's a sidebar on the left. Click a button on the sidebar and it will show you some of the plots. (Ideally each button has an icon next to it.) See "Inspiration" below.
it's all still the "sim plots" app

Resources

dash.plotly.com "Multi-Page Apps and URL Support" docs, video tutorial
"dash-multi-page-app-demos", by AnnMarieW, github README, with curated links to many more tutorials
"How to Create a Multipage Dash App", by Michael McManus blog
"Multipage Python Dash App" by Charming Data, video part 1, video part 2. Part 2 at 0:38 shows a left sidebar; the video shows how

Inspiration

Status quo screenshot

Do we really need multiple pages for this?
I suggest using tabs, this will allow to keep common components such as: SimulationID, State visible on the top and only change the displayed plots.

I suggest using tabs, this will allow to keep common components such as: SimulationID, State visible on the top and only change the displayed plots.

I agree.

Do we really need multiple pages for this?

"Multiple pages" has two meanings:

the general idea of an app that has >1 pages, versus different tabs
a Plotly/Dash "Multi-Page App", which is how you implement >1 pages OR different tabs

We are in category (2). We want to implement different tabs, but how you do it with Plotly/Dash is via a "Multi-Page App". (At least that's my understanding of it! If you see a simpler way, go for it.)

This is what I mean:
https://dash.plotly.com/dash-core-components/tab

This is what I mean: https://dash.plotly.com/dash-core-components/tab

Thank you for finding that. I think I'd been confused, it had looked like tabs had been deprecated, but digging around right now, it looks like they're still properly supported.
Therefore: yes do go with the "tab" core component.

Ok


lima summary and lots of min pass filtered reads

Hi there,
Looking at my lima *.summary output for my IsoSeq data I'm getting a sizable number of reads not passing the minimum pass filter. I was under the impression that the --min-passes 0 was the default, is that overridden by --isoseq? I see FullPass : false when I run
lima M145_reads.bam primers.fa M145_reads.fl.bam --isoseq --peek-guess -j 128 --log-level TRACE

And pretty much everything is single pass...
cut -f 28 M145_reads.fl.lima.report | sed '1d' | sort | uniq -c
    139 0
4980823 1

But I've got 1.75M reads getting filtered out?
ZMWs input                (A) : 6726107
ZMWs above all thresholds (B) : 3976716 (59.12%)
ZMWs below any threshold  (C) : 2749391 (40.88%)

ZMW marginals for (C):
Below min length              : 260 (0.01%)
Below min score               : 0 (0.00%)
Below min end score           : 345970 (12.58%)
Below min passes              : 1745284 (63.48%)
Below min score lead          : 0 (0.00%)
Below min ref span            : 302101 (10.99%)
Without SMRTbell adapter      : 139 (0.01%)
Undesired 5p--5p pairs        : 631173 (22.96%)
Undesired 3p--3p pairs        : 86127 (3.13%)
Undesired no hit              : 139 (0.01%)

ZMWs for (B):
With different pair           : 3976716 (100.00%)
Coefficient of correlation    : 0.00%

ZMWs for (A):
Allow diff pair               : 4980823 (74.05%)
Allow same pair               : 4980823 (74.05%)

Reads for (B):
Above length                  : 3976716 (100.00%)
Below length                  : 0 (0.00%)

Any insight is greatly appreciated!

Ah, I've got it, Below min passes is np:i:0 from the CCS bam + NumPasses 0 from lima, which is scored based on adapter structure in the read and is only determined for np:i:n > 0.
samtools view M145_reads.bam | cut -f 12- | tr '\t' '\n' | grep 'np:i:' | sort | uniq -c | sort -k2,2V | head
1745145 np:i:0
 362574 np:i:1
 263808 np:i:2
 234643 np:i:3
 200416 np:i:4
 173981 np:i:5
 156908 np:i:6
 142309 np:i:7
 130874 np:i:8
 121740 np:i:9

So there are 1745145 zero pass CCS reads and if we add the 139 zero pass fl reads from lima we get the Below min passes: 1745284 value. Zero pass CCS reads are counted for the .summary file but are not included in the .report file, which is what confused me!


Handle case where user does not have access to collection

artx-market-app-1       | Error processing request: TypeError: Cannot read properties of undefined (reading 'asset')
artx-market-app-1       |     at Object.getCollection (/app/xidb.js:885:54)
artx-market-app-1       |     at /app/server.js:810:29
artx-market-app-1       |     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
artx-market-app-1       |     at next (/app/node_modules/express/lib/router/route.js:144:13)
artx-market-app-1       |     at Route.dispatch (/app/node_modules/express/lib/router/route.js:114:3)
artx-market-app-1       |     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)
artx-market-app-1       |     at /app/node_modules/express/lib/router/index.js:284:15
artx-market-app-1       |     at param (/app/node_modules/express/lib/router/index.js:365:14)
artx-market-app-1       |     at param (/app/node_modules/express/lib/router/index.js:376:14)
artx-market-app-1       |     at Function.process_params (/app/node_modules/express/lib/router/index.js:421:3)
artx-market-app-1       | GET /api/v1/collections/0e5052c9-7c9e-49e3-a873-a7953deebe01 500 24.182 ms - 59

Fixed in https://github.com/macterra/artx-market/commit/afa411391164865efce50fd55a935ce871bc79f5


Possibility to set up multiple watchers each with a command

Is this possible? E.g. npm run watch-js ; npm run watch-css
Or should I use concurrently for this?

I would recommend to run multiple chokidar-cli processes for this, so yeah e.g. with concurrently. I think this is out of the library scope, as it is simpler to spawn multiple processes. If this is a popular use case, we can reconsider. Closing this for now.

Cool, thanks for the reply,

I too would like this. I use chokidar in package.json to watch source for changes and to run testscases. I'd like to also add a standardjs formatting check.  Doing this would concurrently would require duplicating the entire chokidar command line, which is somewhat complex.  Being able to just add a second -c would be much more convenient.


css files show all lines changed while up-to-date

For some reason all css fils in my project show as changed; even if git status shows nothing new/changed.
Changing focus, refreshing the file or restarting Atom do not fix this.

What can be done to fix this?

My assumption is that you are on Windows and you're having a line-ending issue. I suspect this is a duplicate of atom/atom#3768 and can be resolved in the same way.

You are right on the line-ending part...
I was using Atom on an OSX system, and discarded the line-ending problem at first, but apparently some external (windows created) files got mixed-in, without setting the correct git settings beforehand.
So now using:
git config --global core.autocrlf input on OSX, to set the lineendings to use to LF(default on OSX)
and using a .gitatributes file that contains something in the line of:
# Autodetect text files
* text=auto

# ...Unless the name matches the following
# overriding patterns

# Definitively text files
*.txt text
*.css text
*.php text
*.md text
*.yaml text
*.htaccess text

# Ensure those won't be messed up with
*.jpg binary
*.png binary
*.gif binary
*.pdf binary
*.data binary

after committing the .gitattributes file and all other pending changes (and pushing it upstream, just to be sure) i followed the steps outlined here (choose your platform to see the correct commands for your system)
Thanks for pointing me in the right direction and sorry for stealing your time! ;)

You're very welcome and I'm happy to help!


After upgrading to Laravel 11 and Nova 4 not working at Landlord anymore

Bug description
Hi,
The following was working fine before I upgraded my application to Laravel 11 and Nova 4.
This is in nova.php-config:
    'middleware' => [
        InitializeTenancyByDomain::class,
        'universal',
        'web',
        Authenticate::class,
        HandleInertiaRequests::class,
        DispatchServingNovaEvent::class,
        BootTools::class,
    ],

    'api_middleware' => [
        'nova',
        Authenticate::class,
        Authorize::class,
    ],

When I navigate to http://domain.test/nova > it tells me: "Tenant could not be identified on domain.test"
And when I go to  http://sub.domain.test/nova it shows me Nova like expected.
I cannot access the Landlord Nova with this config.
When I remove InitializeTenancyByDomain::class, from the middleware, it shows me the Landlord version on both, but then there is no way to access the Tenant  Nova.
This is the Bootstrapper of the App:
<?php

use App\Providers\AppServiceProvider;
use Illuminate\Foundation\Application;
use Illuminate\Foundation\Configuration\Exceptions;
use Illuminate\Foundation\Configuration\Middleware;
use Stancl\Tenancy\Middleware\InitializeTenancyByDomain;
use Stancl\Tenancy\Middleware\InitializeTenancyBySubdomain;

return Application::configure(basePath: dirname(__DIR__))
    ->withProviders([
        niklasravnsborg\LaravelPdf\PdfServiceProvider::class,
        Intervention\Image\ImageServiceProvider::class,
        PragmaRX\Google2FALaravel\ServiceProvider::class,
    ])
    ->withRouting(
        web: __DIR__.'/../routes/web.php',
        api: __DIR__.'/../routes/api.php',
        commands: __DIR__.'/../routes/console.php',
        // channels: __DIR__.'/../routes/channels.php',
        health: '/up',
    )
    ->withMiddleware(function (Middleware $middleware) {
        $middleware->redirectGuestsTo(fn () => route('login'));
        $middleware->redirectUsersTo(AppServiceProvider::HOME);

        $middleware->validateCsrfTokens(except: [
            'api/*',
            'api/webhooks/*',
        ]);

        $middleware->throttleApi();

        $middleware->group('public-api', [
            Illuminate\Routing\Middleware\ThrottleRequests::class . ':api',
            App\Http\Middleware\PublicMiddlewareAPI::class,
        ]);

        $middleware->group('universal', []
        );

        $middleware->group('tenant', [
            'web',
            Stancl\Tenancy\Middleware\InitializeTenancyByDomainOrSubdomain::class,
        ]);
    })
    ->withExceptions(function (Exceptions $exceptions) {
        //
    })->create();

There you can see the 'universal' part that's used as middleware.
Steps to reproduce
Have a L9 and Nova 3 CMS and upgrade this...
Expected behavior
That I can have a different Nova for both Tenant and Landlord like I had before
Laravel version
v11.17.0
stancl/tenancy version
v3.8.4

For integrations see the docs or our Discord for support questions. There's no bug in the package here.


version: Update OCW redirects dict to use production values

The OCW production live dictionary of redirects was manually edited after we took the
initial dump of its contents. This reconciles the current values with what we have in
source control so that we can use code as the source of truth going forward.

Description

This updates the redirect dict for OCW sites to use the values as they are in production currently.
Motivation and Context

Move to using this code as the source of truth for the OCW Fastly service
How Has This Been Tested?

The values were pulled directly from production via the Fastly API
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (improves on existing behavior)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

👍


Ignore /dist directory generated by goreleaser

Fix https://github.com/stacklok/minder/issues/1664.
This makes sure we have Dirty: false for minder version output.
I tested this locally, by simulating running goreleaser release --clean in a simulated clean directory with a dummy tag (while the publishing will fail, but the /dist directory is created). Before this change, running minder version gave me:
...
Dirty: true
...

With this change:
...
Dirty: false
...

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Ignore lineage for table not in metadata

Affected module
Lineage
Describe the bug
The tool tries to add lineage indefinitely for a table that doesn't exist in metadata (or has been deleted). Since this table is no longer present, it fails after 750 tries.
[2023-06-23, 01:08:23 UTC] {sql_lineage.py:353} DEBUG - Running lineage with query: INSERT INTO <tablename>
        SELECT "created_on",
               'ROLE ACCESS',
               'ROLE',
               "role",
               "granted_to",
               "grantee_name",
               NULL,
               "granted_by",
               '2023-06-22 18:00:00+00:00'

Additional logs:
[2023-06-23, 01:08:24 UTC] {taskinstance.py:1909} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1802, in _execute_context
    self.dialect.do_execute(
  File "/home/airflow/.local/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 719, in do_execute
    cursor.execute(statement, parameters)
  File "/home/airflow/.local/lib/python3.9/site-packages/snowflake/connector/cursor.py", line 910, in execute
    Error.errorhandler_wrapper(self.connection, self, error_class, errvalue)
  File "/home/airflow/.local/lib/python3.9/site-packages/snowflake/connector/errors.py", line 290, in errorhandler_wrapper
    handed_over = Error.hand_to_other_handler(
  File "/home/airflow/.local/lib/python3.9/site-packages/snowflake/connector/errors.py", line 345, in hand_to_other_handler
    cursor.errorhandler(connection, cursor, error_class, error_value)
  File "/home/airflow/.local/lib/python3.9/site-packages/snowflake/connector/errors.py", line 221, in default_errorhandler
    raise error_class(
snowflake.connector.errors.ProgrammingError: 002043 (02000): SQL compilation error:
Object does not exist, or operation cannot be performed.

To Reproduce

Ignore table via ignoring schema, ingest metadata
Run lineage

Screenshots or steps to reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Version:

OpenMetadata version: 1.0.4

Additional context
Add any other context about the problem here.

hi @nitisha-cb I think @ulixius9 has been trying to reach out since we need more info. Please provide any extra details in the issue, thanks!

closing this ticket as no longer relevant


Neo4j support

Is it possible to get support with this gem:
https://github.com/neo4jrb/neo4j/
For neo4j?  It's closely tied to ActiveRecord, only major difference of note is that relationships work very differently.    Even flat key->value support would be a big help.

Merging into #1377.


ui: display number of selected papers in authors details

fixed missing number of seleted papers when selecting authors publications

ref: cern-sis/issues-inspire#10

@karolina-siemieniuk-morawska thank you for your PR, I would suggest the following:

I would disconnect it and make it a simple component https://github.com/inspirehep/inspirehep/blob/f8b75af3325c18c260f5c8da4dbb8d0fe46ef577/ui/src/literature/containers/NumberOfResultsWithSelectedItemsNumberContainer.jsx
in LiteratureSearch I would add an extra prop call selectedKey (default to literatureSearch) and will pass

<NumberOfResultsWithSelectedItemsNumber
   numberOfSelected={numberOfSelected}
/>

and in
const stateToProps = (state, { namespace, selectedKey }) => ({
  loading: state.search.getIn(['namespaces', namespace, 'loading']),
  loadingAggregations: state.search.getIn([
    'namespaces',
    namespace,
    'loadingAggregations',
  ]),
  numberOfSelected: sate.getIn([namespace, selectedKey]).size
  results: state.search.getIn(['namespaces', namespace, 'results']),
  isCitationSummaryVisible: isCitationSummaryEnabled(state),
  isCatalogerLoggedIn: isCataloger(state.user.getIn(['data', 'roles'])),
});

@karolina-siemieniuk-morawska could you please add a test, in AuthorsPublicationContainer?


ImportErrors for Python 3 Qt 5

When using the standard installation instructions for Python 3 and Qt 5 I get the following error:
Traceback (most recent call last):
  File "labelImg.py", line 15, in <module>
    from PyQt5.QtGui import *
ImportError: No module named 'PyQt5'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "labelImg.py", line 24, in <module>
    import sip
ImportError: No module named 'sip'

It looks like this is caused by not installing the pip package pyqt5. However, this is not noted in the installation instructions.

OS: Ubuntu 16.04
PyQt version:

same problem

try update PyQt to the latest version ( PyQt 5.11 )

try update PyQt to the latest version ( PyQt 5.11 )

I don't think that solves the problem, since the problem seems to be that PyQt isn't installed at all.

Hi everyone! I haven't been able to solve the problem.
I have  updated PyQt to its last version and the same error persists.
Any additional help?

bro already have a solution?
i have same problem

Could you check this which is how we built this repo
https://github.com/tzutalin/labelImg/blob/master/.github/workflows/package.yml

in this case you might  write one of the commend wrong (this error showed to me before I find out the mistake )
first :
conda install pyqt=5
second :
conda install -c anaconda lxml
third :
pyrcc5 -o libs/resources.py resources.qrc
finally you can run :
python labelImg.py

don't forget to cut ( resources.py  and resources.qrc )then paste thim in libs folder


[api] Enhancement features for LMSearch

Description
main features

Enable boolean tensor in Ort
ndList to toTupleIValue conversion
addEllipseDim
unregister NDArray... and NDList in NDScope

Codecov Report
Patch coverage: 71.12% and project coverage change: +1.43 :tada:

Comparison is base (bb5073f) 72.08% compared to head (3c28913) 73.52%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2642      +/-   ##
============================================
+ Coverage     72.08%   73.52%   +1.43%
- Complexity     5126     6959    +1833
============================================
  Files           473      685     +212
  Lines         21970    30425    +8455
  Branches       2351     3152     +801
============================================
+ Hits          15838    22371    +6533
- Misses         4925     6526    +1601
- Partials       1207     1528     +321

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...djl/modality/cv/transform/RandomFlipLeftRight.java
25.00% <0.00%> (-25.00%)
:arrow_down:

...djl/modality/cv/transform/RandomFlipTopBottom.java
25.00% <0.00%> (-25.00%)
:arrow_down:

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...ain/java/ai/djl/modality/cv/util/NDImageUtils.java
67.10% <0.00%> (+7.89%)
:arrow_up:

api/src/main/java/ai/djl/modality/nlp/Decoder.java
63.63% <ø> (ø)

... and 228 more

... and 354 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add a conversion function between RawEvent and CollectorPayload

... and CollectorPayload -> List[RawEvent]?
Technically, it should be almost lossless operation. This is out of scope of snowplow-badrows project, but until we have a better place for these payloads, I think we can leave it.
/cc @peel @benjben

Is there another place that the recovery job where we would want to do that?

That's a good question. It feels that we might want to do it in SCE.

Some hints from Anton:
case class CollectorPayload(
  vendor: String,                     // +
  version: String,                    // +
  querystring: List[NVP],             // Possibly empty. If not empty, body is `None` (it was GET request)
  contentType: Option[String],        // +
  body: Option[String],               // Possibly `None`. If `Some`, contentType is empty (it was POST request)
  collector: String,                  // +
  encoding: String,                   // +
  hostname: Option[String],           // +
  timestamp: Option[DateTime],        // +
  ipAddress: Option[String],          // +
  useragent: Option[String],          // +
  refererUri: Option[String],         // +
  headers: List[String],              // +
  networkUserId: Option[UUID]         // +
)
case class RawEvent(
  vendor: String,                     // +
  version: String,                    // +
  parameters: Map[String, String],    // Either querystring.toList or body.flatMap(parseJson).flatMap(_.asObject).getOrElse(Map.empty)
  contentType: Option[String],        // +
  loaderName: String,                 // ???
  encoding: String,                   // +
  hostname: Option[String],           // +
  timestamp: Option[DateTime],        // +
  ipAddress: Option[String],          // +
  useragent: Option[String],          // +
  refererUri: Option[String],         // +
  headers: List[String],              // +
  userId: Option[UUID]                // +
)

Everything with + is just a direct mapping


Adding cb return when no file

Coverage remained the same at 63.374% when pulling 8ef1f82853da7cf12ee2d665305a933132979333 on aws-upload-cb into 2fa5621cef3bc01e3868f095fc0992aa539d59ef on develop.


[FEATURE REQUEST]  Designing a custom 404 page

Description
Is your feature request related to a problem? Please describe.
I'd like to create a 404 page for the website, so that the user is redirected to that page if he enters an invalid path
Describe the solution you'd like
The theme of the page will conform to the website's theme.
Additional Notes (optional)
@Abhirup-02 , if you think that this issue is useful, please assign it to me.

Already have that


CQM.is_equal() or similar

Probably also want some sort of tolerance parameter.
Requested by @vgoliber

Something similar to this would be wonderful: https://github.com/dwavesystems/dimod/blob/96928a68637ec1d2af5e19e0678417b164ef237d/dimod/binary/binary_quadratic_model.py#L1288

Though I am currently questioning past Alex's judgement for making those separate methods rather than having places as a parameter on .is_equal().


require-pci-squad-approvals

Code Coverage Report

Overall Project
95.91%
:green_apple:

There is no coverage information present for the Files changed


Windows builds lack .pc (pkg-config) file

Other platforms ship with a pkg-config file (geos.pc), but not the Windows builds. This lack of symmetry propagates as platform-specific build code. It would be great if this could be resolved!
I.e., please ship with %PREFIX%\Library\lib\pkgconfig\geos.pc.
Example downstream issue: https://github.com/conda-forge/r-terra-feedstock/pull/96

Currently only happens on non-MSVC targets (see https://github.com/libgeos/geos/blob/main/tools/CMakeLists.txt#L82). Happy to receive a PR with a patch, but maybe raise this upstream?

Always slightly nervous linking MSVC code with gcc code BTW, never quite sure what will happen.

@gillins thanks for identifying the source! I sent a PR to remove the condition.

Always slightly nervous linking MSVC code with gcc code BTW, never quite sure what will happen.

I'll turn on the unit testing to check the builds on the downstream package is actually functional.

I'll turn on the unit testing to check the builds on the downstream package are actually functional.

Thanks @mfansler, really interested to hear how this goes. I've always thought we may need to have a g++ variant of the builds for Windows to properly support R but this is A Lot Of Work....

Just to follow-up: indeed no success in mixing the MSVC-compiled lib with GCC compilation. There are a couple relevant PRs (r-terra PR96, PR97) to see how this went - or didn't. The second one attempted switching out to clang, but the terra package itself is using C++23 features not yet available in clang/MSVC.
The pkg-config was also ultimately not so useful because the .pc for PROJ needed an openssl .pc, which similarly isn't packaged and I wasn't motivated to accept that indefinite PR quest.


Enforce Issue Template

I have been noticing a lot of spam issues on scrcpy. it would be nice to have an issue template for example the Gimp Organization. this helps the maintainers to get all the information without asking for it again from the issue holder.
this is a feature request, I have seen the same issue repeatedly come up again, out of the 1k issues, probably only 10% would be a genuine one.
thanks

As a first step, I'm working of FAQ improvements: https://github.com/Genymobile/scrcpy/blob/faq/FAQ.md (branch faq).
(I'll reference the FAQ from the issue template)
Do you see other common problems which should be explained here?

Ok, thanks for this, but I actually wanted to way to control the amount of spam issues which is not visually appealing to some extend, or which needs to be reported. This repository is developing very nice, and I personally didn't want the current position to go down. During the stream of unusual issues, I was forced to Unwatch the repository because it spammed by Inbox too. Maybe a member from @github could help us out.

@rom1v , maybe it is necessary to add these to the FAQ improvement (some suggestions)

add the add to PATH for Windows, Scrcpy too

scrcpy not found

Add to PATH using GUI, as mentioned here https://www.architectryan.com/2018/08/31/how-to-change-environment-variables-on-windows-10/

Shortcut to scrcpy on windows

Thanks


Upgrade from 5.0 to 5.1 fails due to DatabaseType Error

When upgrading ORM-Lite in my app from 5.0 to 5.1, we suddenly start to receive the following errors:
'
error: method extractTableName in class DatabaseTableConfig<T#2> cannot be applied to given types;
String mapTableName = DatabaseTableConfig.extractTableName(Map.class);
^
required: DatabaseType,Class<T#1>
found: Class
reason: cannot infer type-variable(s) T#1
(actual and formal argument lists differ in length)
where T#1,T#2 are type-variables:
T#1 extends Object declared in method <T#1>extractTableName(DatabaseType,Class<T#1>)
T#2 extends Object declared in class DatabaseTableConfig
'
According to the documentation, this should not happen as the database type should be set internally to SqliteAndroidDatabaseType

I have same errors.


fix error when url redirect happens in mx oauth bank

fix error when url redirect happens in mx oauth bank
An config entry naming inconsistency introduced by moving to Ucp-login

Thought this PR was merged that I pushed another change,
hence there are now 3 small changes included.

Thought this PR was merged that I pushed another change, hence there are now 3 small changes included.

@sophtron-jishun Approved


[stress-tests] add network-forming test

This PR adds the network-forming stress test that verifies the robustness of network forming process of networks of different sizes.

Codecov Report

Merging #92 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   40.07%   39.99%   -0.09%
==========================================
  Files          16       16
  Lines        2438     2438
==========================================
- Hits          977      975       -2
- Misses       1441     1443       +2
  Partials       20       20

Impacted Files
Coverage Δ

web/web.go
42.02% <0.00%> (-2.90%)
:arrow_down:

@simonlingoogle , please help resolve conflicts.


Added Widgets that interact with asynchronous computations

Added three new Widget types for building Widget sub-trees based on interaction with asynchronous computations such as Futures and Streams.
These Widgets are intended to be used e.g. with native interop (upcoming pull-requests that expand on the current hello_services example) and background computations (later).

nit: Please read https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo and update the code to Flutter style. Thanks!

This is a very interesting set of widgets. (cc @abarth, why may also find them interesting)
Is there a use case for having the separate StreamFold abstract widget other than for testing?

Thanks for including tests, by the way. Much appreciated.

Thanks for your detailed review comments! I somehow completely missed the
link to the Flutter style guide... I'll update the pull request accordingly.

Cool, thanks. Let me know when it's updated and I'll take another look.

As for the utility of StreamFold, I think there are numerous use cases, and
the class was not intended to just facilitate testing. Please note that
StreamBuilder only has access to the latest snapshot of interaction with
the Stream when building, and so would be unable to do things like

create a Text widget with the running average of a Stream, or
render the current direction or speed based on a stream of geolocation
coordinates, or
implement a game of snake based on a stream of accelerometer data, or
render a graph based on a stream of data points.

We could leave out StreamBuilder instead, but I do think there are use
cases for reflecting just the latest event (or error) from a stream in the
UI. Latest sale or stock price for instance.

that makes sense. maybe rename StreamFold to StreamBuilder and StreamBuilder to StreamSnapshotBuilder?
or maybe the former should just be StreamBuilderBase?

PTAL.
On Tue, Jan 31, 2017 at 9:21 AM, Ian Hickson<EMAIL_ADDRESS>wrote:

Cool, thanks. Let me know when it's updated and I'll take another look.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/7733#issuecomment-276302043, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AV33XYA0YRwX9Q9nk4uMYlVITZgfkfB_ks5rXu8FgaJpZM4LxeWm
.

--
Mikkel Nygaard Ravn
Software Engineer

This looks pretty neat.  My only real comment is about simplifying FutureBuilder to use the Future interface directly instead of plumbing through streams.

Thanks again for the reviews! I've re-implemented FutureBuilder on top of the Future API and made the test code conform to the Flutter style guide.

Let me know if you need someone to land this for you.


Added Fork Image

I added a fork image to the First-Contributions tutorial page. However, I was sadly not able to add an image to the other steps as I was not sure how they would look for other people and I did not want the page to look too messy. I do hope you will accept at least my one image as this is my first time ever submitting a pull request and using open-source in general. Thank you and have a good day, if you have any tips please let me know!

I know you may be nervous when submitting your first contribution but I can't really accept this as it is incomplete.
As well, you added yet another folder called assets when there was an /images folder already in the repository. I simply can't have this repository getting out of control with the number of folders.
My tip would be to keep trying and research how to do things through Google and YouTube. Keep at it, you can do it.

Thank you for your tips, I am very sorry for not doing it right.

No, I am not going to report this as spam as you clearly made an effort to contribute. Although I am a bit disappointed you gave up so quickly. You could've finished it if you kept at it.
Can you at least try and add your name to the contributors.md file? That should help build confidence in the future.

No, I am not going to report this as spam as you clearly made an effort to contribute. Although I am a bit disappointed you gave up so quickly. You could've finished it if you kept at it.
Can you at least try and add your name to the contributors.md file? That should help build confidence in the future.

Sorry about not finishing, its just that when I was trying to show an example image of inputting the text into the Git application, some of the command prompts were not working. Me and my friend were working on it for several hours but we just couldn't seem to figure out why it was not working as it should. Although thanks for at least giving me the opportunity because It helped me understand hacktoberfest much better.


POC proxied sessions method for pandas reader

Proxied pandas sessions for remote data access -- POC for #53

Coverage decreased (-1.8%) to 60.395% when pulling 027d850a0cc7f9686604d51727518472e4fda90a on feature/pandas_session into dd2cf266bb4005387f173a7647d46b1b6484db7d on master.

Coverage decreased (-1.8%) to 60.395% when pulling 027d850a0cc7f9686604d51727518472e4fda90a on feature/pandas_session into dd2cf266bb4005387f173a7647d46b1b6484db7d on master.


Refactor: expose AsyncRuntime Oneshot via trait

What does this PR do
Exposes Oneshot via trait Oneshot.
Closes #1198
Checklist

[ ] Updated guide with pertinent info (may not always apply).
[x] Squash down commits to one or two logical commits which clearly describe the work you've done.
[ ] Unittest is a friend:)

This change is

Do I need to include a changelog entry in the PR description? Something like
Changelog
Change: Interfaces of the oneshot channel in AsyncRunime have their own trait trait Oneshot now

Do I need to include a changelog entry in the PR description? Something like
Changelog
Change: Interfaces of the oneshot channel in AsyncRunime have their own trait trait Oneshot now

Use a commit message starts withChange: , instead of a Refactor:  for a breaking change. It will be included in the change log when publishing. No need to add another # Changelog entry in the commit message.
The PR title is not used when building change log.

Use a commit message starts withChange: , instead of a Refactor:  for a breaking change.

Use a commit message starts withChange: , instead of a Refactor:  for a breaking change.

This is a breaking change for users who implement their own AsyncRuntime, do you need to manually edit the changelog when crafting a new release?

The change log is built with this script:
https://github.com/datafuselabs/openraft/blob/main/scripts/build_change_log.py
After that,  the generated change-log still needs a  few manually update.

The change log is built with this script:
https://github.com/datafuselabs/openraft/blob/main/scripts/build_change_log.py
After that, the generated change-log still needs a few manually update.

Get it, thanks for showing me this!

Use a commit message starts withChange: , instead of a Refactor:  for a breaking change.

This is a breaking change for users who implement their own AsyncRuntime, do you need to manually edit the changelog when crafting a new release?

I forgot the commit message needs to be updated when merging. I've force-pushed the main branch to correct the commit message...

I forgot the commit message needs to be updated when merging. I've force-pushed the main branch to correct the commit message...

Thanks for fixing that for me! 😄


[CRASH] occultism & minecolonies crash on world gen

Describe the bug
crash on world generation when both occultism 1.125.0 & minecolonies-1.20.1-1.1.561-BETA are present
To Reproduce
Steps to reproduce the behavior:

create new world with both mods present

Expected behavior
not crashing lol.
System (please complete the following information):

Occultism Version: 1.125.0
OS: SteamOS
Minecraft Version: 1.20.1
Modpack Link and Version, or list of mods:
+curios api 5.8.1
+Domum Ornamentum-1.20.1-1.0.184-BETA
+geckolib4 4.4.4
+minecolonies-1.20.1-1.1.561-BETA
+modonomicon 1.69.0
+occultism 1.125.0
+smartbrainlib 1.13
+structurize-1.20.1-1.0.725-BETA
+blockui -1.20.1-1.0.151-BETA

Additional context
https://mclo.gs/9JoQl2r

The crash is due to the wrong variant of SmartBrainLib being used.
There is a version for Neoforge and one for Forge, Curseforge launcher sometimes picks the wrong one. Make sure to use the one for your mod loader and this crash will not happen any more.
This is a duplicate of #1029, see also https://github.com/Tslat/SmartBrainLib/issues/57#issuecomment-1891803412 for comments of SBL's author.

Ahhhhhh, alright, I'll test this later once I'm at my pc again. Tysm, I only searched for Minecolonies didn't think to check the smart brain library version.


Hope to have a better way to start and connect to remind

Hope to have a better way to start and connect to remind，For example, when starting the wallet, under the windows system environment, you can click the mouse to start it quickly. You can provide a script file. When the connection is disconnected, there should be a pop-up reminder. In this way, the user experience is better. It is suggested that you can also develop quick API order operation and humanized files.

We are working on improving the UX of the wallet, and we will try to cover this need. Closing it.


C: Alerts: Point to or include the research - Alertes : inclure la recherche

We've used this alert pattern in the Travel advice project, and have done independent tests to directly compare this pattern to the current box design. The details of these tests need to either be included in the pattern or in a blog post that we can link to.

Should this be merged with https://github.com/canada-ca/design-system-systeme-conception/issues/59?

That's done in the live documentation: https://design.canada.ca/common-design-patterns/contextual-alerts.html#research

That's done in the live documentation: https://design.canada.ca/common-design-patterns/contextual-alerts.html#research


Bump to Alpine 3.19

Alpine 3.19 has been released earlier this month and includes newer versions of containerd and docker.
This should be a minimal change:
--- Makefile
+++ Makefile
@@ -1,4 +1,4 @@
-ALPINE_VERSION ?= 3.18.0
+ALPINE_VERSION ?= 3.19.0
 REPO_VERSION ?= $(shell echo "$(ALPINE_VERSION)" | sed -E 's/^([0-9]+\.[0-9]+).*/v\1/')

Unfortunately this breaks ssh support in Lima:
$ make EDITION=std lima
ALPINE_VERSION=3.19.0 EDITION=std ARCH=x86_64 ./lima.sh
WARN[0000] Ignoring non-existent instance "std"
[...]
INFO[0001] SSH Local Port: 40022
INFO[0001] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"
INFO[0029] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"
INFO[0039] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"
INFO[0049] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"
INFO[0059] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"

Using the QEMU display running ssh -vvvv localhost from inside the VM works just fine (I think, I didn't actually generate a key to login, but I see all the ssh logging and eventually the password prompt).

I get: unable to open config for system login, from PAM (_pam_load_conf_file) in syslog

Linking system-login to login makes the ssh connection work, not sure what you need?

alpinelinux/aports@bb00d97 removed /etc/pam.d/system-login
alpinelinux/aports@8bc65a7 added /etc/pam.d/sshd

Thanks for the research! Looks like PAM configuration works now out-of-the-box.


Fix: Implement skeleton view in workspace member page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/43605
PROPOSAL: https://github.com/Expensify/App/issues/43605#issuecomment-2169132300
Tests

Open app.
Go to workspace member page
When the data is loading, verify there is a skeleton displayed:

In large screen:

https://github.com/Expensify/App/assets/170341821/2b9794e8-a658-4bbd-b3ef-37f94806b0f3

In small screen:

https://github.com/Expensify/App/assets/170341821/dab154a6-08cd-4573-8cf9-e622c8e9b64f

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/170341821/bab2927d-192f-44a2-8a27-5501e35eea8e

Android: mWeb Chrome

https://github.com/Expensify/App/assets/170341821/576445e8-ec50-4842-a199-63e51870ffa9

iOS: Native

https://github.com/Expensify/App/assets/170341821/b525b505-08cc-44fe-9458-d4f0fe7a3465

iOS: mWeb Safari

https://github.com/Expensify/App/assets/170341821/4c07bb89-777c-4d82-bad0-a6b2103eb92e

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/170341821/43fd4022-c910-42e4-805e-9b6ec1301715

MacOS: Desktop

https://github.com/Expensify/App/assets/170341821/91ba6eaf-b121-4a7b-8503-712e460f3d9f

@shawnborton Do we have a ticket to handle a small screen? Currently with the change in PR, small screen looks like:
https://github.com/Expensify/App/assets/170341821/574ec728-e98e-4f67-a8f5-83f3d0312935

Do we have a ticket to handle a small screen? Currently with the change in PR, small screen looks like:

I don't think we need to show anything different for small screens - what you have looks good to me.

Tested and this feels pretty good to me!

@truph01 Please can you fix the lint errors? Thanks :pray:

@jjcoffee I fixed lint errors.

@truph01 Thanks! I will test soon, once BE issues are resolved.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@truph01 You've ticked off all items on the checklist but you haven't actually completed every item. You're missing test steps and there are no screenshots for iOS & Android. Please can you make sure you complete all checklist items before marking your PR ready for review in future.

You've ticked off all items on the checklist but you haven't actually completed every item. You're missing test steps and there are no screenshots for iOS & Android. Please can you make sure you complete all checklist items before marking your PR ready for review in future.

@jjcoffee Oh, I noted that. I've updated all the test steps and videos. Initially, I didn't include the videos on mobile devices because I needed confirmation about this question. After receiving internal confirmation, I forgot to add them. It is my bad.

@jjcoffee I updated PR to fix your comment.

Before we merge, let's get a quick @Expensify/design review (I'll look now)

@truph01 can you confirm that the table rows have horizontal padding of 16px and vertical padding of 12px? Like so:

It looks like the left edge might be using 20px padding so just wanna check that quickly.

@truph01 can you check my comment above? I can't seem to test this very well, the loading state goes away immediately.

It looks like the left edge might be using 20px padding so just wanna check that quickly.

I fixed via commit. Here is result:

That feels better. Can you confirm that the two stacked lines are 12px away from the circle shape to their left? That's the last confirmation I think we need before we can merge this. Thanks!

@shawnborton

That feels better. Can you confirm that the two stacked lines are 12px away from the circle shape to their left? That's the last confirmation I think we need before we can merge this. Thanks!

I updated PR. Here is result:

Wonderful, thanks! All good on my end, cc @Expensify/design in case you see anything, otherwise this is looking good to go @blimpich

will give it till EOD for others to comment on the updated style, then I'll merge if nothing comes up

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[aavegotchi] newer staking pool power

Changes proposed in this pull request:

add logic to calculate new staking pools

Hi @candoizo Existing proposals could be affected by this change, especially the proposal that is open
https://snapshot.org/#/aavegotchi.eth/proposal/0x396844d504394f7f335f070d443c33455300ee21d90db6c4b089760a3e0469bf
It is better to create a -v2 strategy for this

There should be a v2 of the strategy if you don't want past proposal to have different results

In this case after reviewing with team the preferred option is to apply the change on the existing strategy


Opening the toolkit in unity throws an OpenVR error if steam isn't installed on machine

Overview
It appears that some aspect of the toolkit's configuration expects openvr to be installed:
[10:58:13] XR: OpenVR Error! OpenVR failed initialization with error code VRInitError_Init_PathRegistryNotFound: "Installation path could not be located (110)"!
Either the toolkit should list that steam is required in order to not get this error, or this error should only appear when
Expected Behavior
MRTK doesn't display any errors when opening in unity after completing setup instructions
Actual Behavior
MRTK shows the following error when opening in unity after completing setup instructions:
[10:58:13] XR: OpenVR Error! OpenVR failed initialization with error code VRInitError_Init_PathRegistryNotFound: "Installation path could not be located (110)"!
Steps to reproduce

Get a PC that does not have steam installed
Install unity
Open MRTK with unity
Observe OpenVR Error

Unity Editor Version
2018.3.1f1 was used to repro this bug, but I have heard that the issue also exists in previous releases
Mixed Reality Toolkit Release Version
This is an issue when using the mrtk_development branch

This same / similar error occurs if the user does not have a headset plugged in. The message is coming from the OpenVR package.
Please be sure that Unity has the OpenVR package installed or the OpenVR SDK is not enabled in the Standalone player settings (presuming the application does not wish to target OpenVR / Steam)


Modify examples in readme file.

To let the user not stuck about what's data variable.

Thanks for your contribution. Merged.


Peer connect and event websocket connection hooks.

Implements #314
.use(function() {
  // Peer connection
  server.httpServer.onPeerConnect(function(request, socket, head, next) {
    // Handle auth logic,
    next(); // Continue the peering process
    // or
    next(new Error('Some error')); // Response to peer will be 500
  })

  // Regular data websocket connections
  server.httpServer.onEventWebsocketConnect(function(request, socket, head, next) {
    // Handle auth logic,
    next(); // Continue the event_socket process
    // or
    next(new Error('Some error')); // Response to client will be 500
  })
})

It also allows for multiple hooks for each event by calling the method more than once. In that case each hook is called in series.

+1


Sample Dom0 functionalities PR for internal review

@firscity pls, fix this
 LONG_LINE: line length of 136 exceeds 100 columns
File:boards/shields/xenvm_dom0/example/xen.dts
Line:35

Acked-by: Mykola Kvach<EMAIL_ADDRESS>

Reviewed-by: Dmytro Semenets<EMAIL_ADDRESS>

@lorc thank you for a close review.

Hi, @firscity
Do we need this pull ?
as far as know we have full version of changes here https://github.com/xen-troops/zephyr/pull/43


Does Tensorflow support learning of embeddings for output classes in multi-class classification?

Hi,
I came across this research paper released by YouTube, on how they use deep learning neural networks for recommendations. It's located here: https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/45530.pdf
In the paper, the candidate generation neural network model outputs a softmax with 256 dimensions, which acts as an "output embedding" of each of the 1M video classes.
How is this possible to implement in Tensorflow, for example? Isn't softmax supposed to be only 1-Dimensional. If the model outputs an "embedding" like this, as they say it does, how would the training data's labels be formatted as 256-dimensional? In other words, how do they compute the 256-dimensional vector for each of the videos in their training dataset?
Also, is it possible to create an output embedding layer when the labels in the training dataset are one-hot encodings of a particular class. In other words, can the output layer automatically learn embeddings for the output class?
Thank you so much for your time and help, guys! I have also asked this question on StackOverflow here: http://stackoverflow.com/questions/43297567/how-to-create-a-multi-dimensional-softmax-output-in-tensorflow
Tensorflow details: Windows, version 1.01, binary (via pip)

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Java adaptor.

I cannot seem to set this up for java, I have used vs code debugger for java, and therefore copied over my vscode java configuration. Also I am use ST4. For some reason the package control file did not seem to work at all, so I downloaded the one from the git main page, but now I have double Debugger options in my menu bar.

I created a sublime project , and saved my configurations there.
Put breakpoint in a perfectly fine java program , and tried to debug it.

Also I installed adaptors but only for python, since it is the other language I know.

Here are my vs code configurations for java.

I removed the jdk path , and the debugger still will not work.
I think the main problem is I do not have an adaptor installed for java.
It says cannot find the adaptor.
It would be nice to have this working, I really do not like vs code , but need it for the debugger (60% of my coding).  Also if someone could tell me if I made any mistakes in my setup, that will be great.
I am getting this error in the terminal.

There isn't support for a java adapter yet.
There is some initial stuff to support the java debug adapter supplied by jdtls here https://github.com/daveleroy/sublime_debugger/pull/106 which requires LSP-jdtls to be running and has not been finished yet. Because of the way the java debug adapter is setup it is not friendly and easy to integrate like many of the other debug adapters out there.

Okay thanks for letting me know. Do you have a timeline, on when you think it might be done , on your side. Also do you think when it is done, you can upload it to the package control website for Sublime text. It will be great to keep checking over there.
It would help new developers a lot, since java is more of a beginners language.
Thanks for your work on the debugger though.


Kyc documents table

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #91
Test URLs:

Before: https://main--piramal--aemsites.hlx.page/home-loans
After: https://kyc-documents-table--piramal--aemsites.hlx.page/home-loans

@asthabh23 I saw that you added the class in UE with the kyc-docs, but shouldn't it appear as an option to one of the blocks. Also I saw that that the URl (to the kyc docs fragment dissapeared). My idea is to give an A tag and if the category is "other-documents" do nothing and if it is different e.g "kyc-document" or something else, just fetch the first URI as a fragment and display it. Does it make sense?

Yes it will appear as a class name on the block - afaik, the changes get reflected only when modeling is merged in main as it always picks up from main branch, on this current branch the option to add the block doesn't appear in UE


Fixing user help link

Fixes https://github.com/silverstripe/silverstripe-cms/issues/1407

@dhensby shouldn't this go into the 3.3 branch?

@scott1702 darn it!

see #5131


Add leafcutter ant leaf gathering

Implement the first version of leafcutter ants.
See #188 for more details.
The ants should have an inventory with a maximal capacity.
When their inventory is empty, they should search for an acacia plant (see #196) and gather leaves. Gathering a leaf can be instant for now (if it's easier) and should transfer the leaf from the plant's output to the ant's inventory.
Once the ant inventory is filled, the ant should walk around again.
Actually using the leaves will be done in a separate issue, to keep the scope small.
Blocked by #196.

This is fixed!


browseURL() doesn't work with file:// URLs

The vscode-R hook for browseURL() doesn't work with file:// URLs. Instead it prints the error message: File not exists.
To Reproduce:
Run the code below in an R terminal with the R: Session Watcher option enabled in vscode-R:
# create a temporary local HTML file to test with
test_file <- file.path(tempdir(), "bug_test.html")
cat("
test file
\n", file = test_file)

# doesn't work in vscode-R; does work in plain R or RStudio
browseURL(paste0("file://", test_file))

# works if the built-in R browseURL() implementation is used
options(browser = NULL)
browseURL(paste0("file://", test_file))

This was triggered in real life by trying to fit an RStan model in multi-core mode. See https://github.com/stan-dev/rstan/blob/da2fc9c079534a82d3d26adda51ad17bf22f5e2b/rstan/rstan/R/stanmodel-class.R line 642-643; they have some RStudio-specific logic too, but for now I'd be happy with vscode-R being compatible with the plain R behaviour.
Do you want to fix by self? (We hope your help!)
I could try to fix this if your time is limited, though I suspect it would take me longer than someone more familiar with the vscode-R code base.
(If yes,) what kind of help do you want? (e.g. Which file should I fix, Survey (related documents)
Looks like the error message is generated in R/session/vsc.R line 576.
Expected behavior:
When given a valid URL, browseURL() should open either an external web browser, or a VSCode web view. The latter is probably preferred for file:// URLs, unless there's some VSCode limitation I'm not aware of.
I would argue that browseURL() calling stop() is always a bug; the built-in implementation fails silently when given an invalid URL.
Environment:

OS: Windows 10
VSCode Version: 1.6.1
R Version: 4.1.1
vscode-R version: 2.3.7

That would be an easy fix, except the code that's adding the file:// is not mine - it's in a commonly used R package, and this works everywhere except with vscode-R.
Moreover, the documentation for utils::browseURL() says "Some platforms also accept file paths." while explicitly listing http://, https://, ftp:// and file:// URL schemes as being supported (depending on browser and OS). There is even an example provided in the help with a file:// URL.

Would you like the try the build from #817 and see if it works for you?


WithError method on Logger

With the current interface we can log the error in a structured fashion as:
log.WithField("err", err.Error()).Error("something bad happened")

This is a pattern that I face often, hence I think it would be nice to have a syntax sugar for the above line, for example:
// the line below is equal to log.WithField("err", err.Error()).Error("something bad happened")
log.WithError(err).Error("something bad happened")

The Logger could also accept an option to customize the field name to be used in this method.

Just don't forget. You have to implement in the 3 implementations (zap, zerolog and logrus).

Issue solved by PR #29


#[br(dbg)] doesn't work when pad_before directive is also used

When the debug attribute #[br(dbg)] is used for a field in the same struct as a #[br(pad_before=N)] attribute, the offset printed to output is incorrect.
When the following is used, the offsets printed would be 0x00, 0x04, and 0x08; but they should be 0x00, 0x08, and 0x0c.
#[derive(Debug)]
#[binrw]
struct Header{
    #[br(dbg)]
    field1: u32,
    #[br(dbg)]
    #[br(pad_before=4)]
    field2: u32,
    #[br(dbg)]
    field3: u32
}

Thanks for your report, and sorry for the delay. This will be fixed in the next release.


Fix Celsius-Fahrenheit conversions

I'm not entirely sure where the existing numbers come from; besides the conversion rate being 1.8, not 2.2 (1kg = 2.2lb, perhaps?), 2.2*15 = 33. The citation uses Celsius, so I kept those numbers the same.

Hm, using the 2019 average monthly temperatures in Central Park (NWS), the difference between the hottest month and the coldest month is 47.1°F or 26.2°C. Meanwhile the simulations use a value of 0.4, citing 15°C*0.0225, but 15*0.0225 = 0.3375.

Frick, thanks for catching this! How embarrassing. I made, like, three different mistakes simultaneously:

Yup, I confused the metric/Imperial conversion for pounds vs Fahrenheit
To convert "15°C" to Fahrenheit, I just typed "15°C in F" on Google and it said 59°F, but I forgot that it's converting absolute degrees, not difference
The simulation said 15*0.0225 because I screwed up the calculation twice. One, yeah it should be 0.3375 not 0.4. And two, the "Reduction of R by 0.0225" number comes from Wang et al, but I forgot to divide by their estimate of R = 1.83.

Huge thanks again! I also linked to the weather.gov link you posted as a source for the summer-winter difference in NYC, thanks for finding a more solid source for that!