ToDo: diffs FF59-FF60b16

v59.0 and v60.0b16 - 152 diffs ( 93 new, 40 gone, 19 different )
FF60 is scheduled for release May 9th

new in v59 stuff we forgot

[ ] layout.css.moz-document.content.enabled=false

scratchpad scripts

[ ] being an ESR major release, we can redo our scratchpad scripts up to ESR60

redundant in 60 due to RFP privacy.resistFingerprinting

[ ] webgl.enable-debug-renderer-info 2011 1337157

new in v60.0b16:

[x] pref("browser.cache.offline.insecure.enable", true); 1354175 - https://github.com/ghacksuserjs/ghacks-user.js/commit/d04ff8457e49877ed8e5f50fffde57a9af3e1e3d
[x] Browser Error Reporter 1426482 - https://github.com/ghacksuserjs/ghacks-user.js/commit/6309822d336011a05ba454d544abcfdbf35176bb

pref("browser.chrome.errorReporter.enabled", false);
pref("browser.chrome.errorReporter.submitUrl", "https://sentry.prod.mozaws.net/api/339/store/");

[x] pref("extensions.screenshots.upload-disabled", false); 1432694 - https://github.com/ghacksuserjs/ghacks-user.js/commit/75534b4e6c6b4dfad135710fcf0b01cb6d6e7118
[ ] pref("extensions.webextensions.restrictedDomains", "accounts-static.cdn.mozilla.net,accounts.firefox.com,addons.cdn.mozilla.net,addons.mozilla.org,api.accounts.firefox.com,content.cdn.mozilla.net,content.cdn.mozilla.net,discovery.addons.mozilla.org,input.mozilla.org,install.mozilla.org,oauth.accounts.firefox.com,profile.accounts.firefox.com,support.mozilla.org,sync.services.mozilla.com,testpilot.firefox.com"); 1415644: Access Denied
[ ] pref("network.trr.mode", 0); 1434852
[x] security.insecure_connection_text* - 1335970 - https://github.com/ghacksuserjs/ghacks-user.js/commit/e373a0f6e10b5727368d6d2b5f5ce9117f5dffb7

pref("security.insecure_connection_text.enabled", false);
pref("security.insecure_connection_text.pbmode.enabled", false);

pref("app.normandy.api_url", "https://normandy.cdn.mozilla.net/api/v1"); 0503
pref("app.normandy.enabled", true); 0503
pref("app.shield.optoutstudies.enabled", true); 0503
pref("identity.fxaccounts.enabled", true); 5000

pref("app.normandy.first_run", true);
pref("browser.startup.blankWindow", false);
pref("browser.urlbar.openintab", false);
pref("devtools.policy.disabled", false);
pref("dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content", false);
pref("dom.push.alwaysConnect", false);
pref("dom.registerProtocolHandler.insecure.enabled", true);
pref("media.cubeb.sandbox", false);
pref("media.getusermedia.camera.off_while_disabled.delay_ms", 3000);
pref("media.getusermedia.camera.off_while_disabled.enabled", true);
pref("media.getusermedia.microphone.off_while_disabled.delay_ms", 3000);
pref("media.getusermedia.microphone.off_while_disabled.enabled", true);
pref("network.cookie.same-site.enabled", true);
pref("network.ftp.enabled", true);
pref("security.mixed_content.upgrade_display_content", false);
pref("security.pki.distrust_ca_policy", 1);

removed, renamed or hidden in v60.0b16:

[ ] pref("browser.newtabpage.activity-stream.enabled", true); 1433324
[ ] pref("browser.newtabpage.directory.source", "https://tiles.services.mozilla.com/..."); 1370930
[ ] pref("browser.newtabpage.enhanced", true); 1433133
[ ] pref("browser.newtabpage.introShown", false); 1433133
[ ] pref("dom.workers.enabled", true); 1434934
[ ] pref("view_source.tab", true); 1418403

placeholder

changed in v60.0b16:

[ ] the parrot needs some love - article, 107264, 440908, 1423840

[ ] fix wiki stuff about the parrot

[ ] flip 4503 privacy.resistFingerprinting.block_mozAddonManager to active?
pref("security.tls.version.max", 4); // prev: 3 1202

pref("browser.schedulePressure.timeoutMs", 300); // prev: 1000
pref("devtools.debugger.features.root", true); // prev: false
pref("dom.ipc.useNativeEventProcessing.content", false); // prev: true
pref("dom.moduleScripts.enabled", true); // prev: false
pref("gfx.webrender.blob-images", 1); // prev: 2
pref("gfx.webrender.hit-test", true); // prev: false
pref("layout.css.servo.chrome.enabled", true); // prev: false
pref("privacy.resistFingerprinting.reduceTimerPrecision.microseconds", 1000); // prev: 2000
pref("security.webauth.webauthn", true); // prev: false

ignore
==NEW
pref("app.normandy.dev_mode", false);
pref("app.normandy.logging.level", 50);
pref("app.normandy.run_interval_seconds", 86400);
pref("app.normandy.shieldLearnMoreUrl", "https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/shield");
pref("browser.chrome.errorReporter.infoURL", "https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/nightly-error-collection");
pref("browser.chrome.errorReporter.logLevel", "Error");
pref("browser.chrome.errorReporter.projectId", "339");
pref("browser.chrome.errorReporter.publicKey", "c709cb7a2c0b4f0882fcc84a5af161ec");
pref("browser.chrome.errorReporter.sampleRate", "0.001");
pref("device.sensors.ambientLight.enabled", true);
pref("device.sensors.motion.enabled", true);
pref("device.sensors.orientation.enabled", true);
pref("device.sensors.proximity.enabled", true);
pref("devtools.browserconsole.filter.css", false);
pref("devtools.browserconsole.filter.debug", true);
pref("devtools.browserconsole.filter.net", false);
pref("devtools.browserconsole.new-frontend-enabled", false);
pref("devtools.browserconsole.ui.filterbar", false);
pref("devtools.debugger.features.replay", false);
pref("devtools.responsive.reloadConditions.touchSimulation", false);
pref("devtools.responsive.reloadConditions.userAgent", false);
pref("devtools.responsive.reloadNotification.enabled", true);
pref("dom.serviceWorkers.update_delay", 1000);
pref("dom.webdriver.enabled", true);
pref("dom.webmidi.enabled", false);
pref("extensions.getAddons.compatOverides.url", "https://services.addons.mozilla.org/api/v3/addons/compat-override/?guid=%IDS%&lang=%LOCALE%");
pref("extensions.langpacks.signatures.required", false);
pref("general.document_open_conversion_depth_limit", 20);
pref("identity.fxaccounts.remote.root", "https://accounts.firefox.com/");
pref("image.animated.decode-on-demand.batch-size", 6);
pref("image.animated.decode-on-demand.threshold-kb", 4194303);
pref("image.mem.animated.use_heap", false);
pref("image.mem.volatile.min_threshold_kb", -1);
pref("image.multithreaded_decoding.idle_timeout", 600000);
pref("intl.tsf.hack.japanist10.do_not_return_no_layout_error_of_composition_string", true);
pref("javascript.options.array_prototype_values", true);
pref("javascript.options.spectre.jit_to_C++_calls", true);
pref("javascript.options.spectre.object_mitigations.barriers", true);
pref("javascript.options.spectre.object_mitigations.misc", true);
pref("javascript.options.spectre.string_mitigations", true);
pref("javascript.options.spectre.value_masking", true);
pref("layers.omtp.dump-capture", false);
pref("layout.css.individual-transform.enabled", false);
pref("layout.css.paint-order.enabled", true);
pref("layout.word_select.stop_at_underscore", false);
pref("marionette.debugging.clicktostart", false);
pref("marionette.enabled", false);
pref("network.dns.native-is-localhost", false);
pref("network.trr.allow-rfc1918", false);
pref("network.trr.blacklist-duration", 259200);
pref("network.trr.bootstrapAddress", "");
pref("network.trr.confirmationNS", "example.com");
pref("network.trr.credentials", "");
pref("network.trr.early-AAAA", false);
pref("network.trr.request-timeout", 3000);
pref("network.trr.uri", "");
pref("network.trr.useGET", false);
pref("network.trr.wait-for-portal", true);
pref("privacy.resistFingerprinting.reduceTimerPrecision.jitter", true);
pref("services.sync.engine.bookmarks.buffer", false);
pref("services.sync.engine.passwords.validation.interval", 86400);
pref("services.sync.engine.passwords.validation.maxRecords", 1000);
pref("services.sync.engine.passwords.validation.percentageChance", 10);
pref("services.sync.prefs.sync.browser.urlbar.matchBuckets", true);
pref("services.sync.prefs.sync.privacy.resistFingerprinting.reduceTimerPrecision.jitter", true);

==REMOVED or HIDDEN
pref("browser.newtabpage.activity-stream.aboutHome.enabled", true);
pref("browser.newtabpage.columns", 5);
pref("browser.newtabpage.compact", false);
pref("browser.newtabpage.rows", 3);
pref("browser.newtabpage.thumbnailPlaceholder", false);
pref("browser.places.useAsyncTransactions", true);
pref("devtools.highlighter.writingModeAdjust", false);
pref("devtools.webide.monitorWebSocketURL", "ws://localhost:9000");
pref("dom.secureelement.enabled", false);
pref("extensions.alwaysUnpack", false);
pref("extensions.getAddons.getWithPerformance.url", "https://services.addons.mozilla.org/%LOCALE%/firefox/api/%API_VERSION%/search/guid:%IDS%?src=firefox&appOS=%OS%&appVersion=%VERSION%&tMain=%TIME_MAIN%&tFirstPaint=%TIME_FIRST_PAINT%&tSessionRestored=%TIME_SESSION_RESTORED%");
pref("extensions.hotfix.cert.checkAttributes", true);
pref("extensions.hotfix.certs.1.sha1Fingerprint", "91:53:98:0C:C1:86:DF:47:8F:35:22:9E:11:C9:A7:31:04:49:A1:AA");
pref("extensions.hotfix.certs.2.sha1Fingerprint", "39:E7:2B:7A:5B:CF:37:78:F9:5D:4A:E0:53:2D:2F:3D:68:53:C5:60");
pref("extensions.hotfix.id", "firefox-hotfix@mozilla.org");
pref("extensions.interposition.enabled", true);
pref("extensions.interposition.prefetching", true);
pref("gfx.font_loader.families_per_slice", 3);
pref("identity.fxaccounts.remote.connectdevice.uri", "https://accounts.firefox.com/connect_another_device?service=sync&context=fx_desktop_v3");
pref("identity.fxaccounts.remote.email.uri", "https://accounts.firefox.com/?service=sync&context=fx_desktop_v3&action=email");
pref("identity.fxaccounts.remote.force_auth.uri", "https://accounts.firefox.com/force_auth?service=sync&context=fx_desktop_v3");
pref("identity.fxaccounts.remote.signin.uri", "https://accounts.firefox.com/signin?service=sync&context=fx_desktop_v3");
pref("identity.fxaccounts.remote.signup.uri", "https://accounts.firefox.com/signup?service=sync&context=fx_desktop_v3");
pref("identity.fxaccounts.remote.webchannel.uri", "https://accounts.firefox.com/");
pref("identity.fxaccounts.settings.devices.uri", "https://accounts.firefox.com/settings/clients?service=sync&context=fx_desktop_v3");
pref("identity.fxaccounts.settings.uri", "https://accounts.firefox.com/settings?service=sync&context=fx_desktop_v3");
pref("layout.css.stylo-blocklist.blocked_domains", "");
pref("layout.css.stylo-blocklist.enabled", false);
pref("security.xcto_nosniff_block_images", false);
pref("services.sync.errorhandler.networkFailureReportTimeout", 1209600);
pref("services.sync.prefs.sync.browser.newtabpage.enhanced", true);
pref("services.sync.scheduler.eolInterval", 604800);
pref("signed.applets.codebase_principal_support", false);
pref("svg.paint-order.enabled", true);

==CHANGED
pref("app.update.url.details", "https://www.mozilla.org/%LOCALE%/firefox/beta/notes"); // prev: "https://www.mozilla.org/%LOCALE%/firefox/notes"
pref("app.update.url.manual", "https://www.mozilla.org/firefox/beta"); // prev: "https://www.mozilla.org/firefox/"
pref("browser.safebrowsing.provider.mozilla.lists", "long-string"); // prev: "long-string"
pref("devtools.devedition.promo.enabled", true); // prev: false
pref("editor.use_div_for_default_newlines", true); // prev: false
pref("extensions.getAddons.get.url", "https://services.addons.mozilla.org/api/v3/addons/search/?guid=%IDS%&lang=%LOCALE%"); // prev: "https://services.addons.mozilla.org/%LOCALE%/firefox/api/%API_VERSION%/search/guid:%IDS%?src=firefox&appOS=%OS%&appVersion=%VERSION%"
pref("font.name-list.sans-serif.ko", "Malgun Gothic, Gulim"); // prev: "Gulim, Malgun Gothic"
pref("security.sandbox.content.level", 5); // prev: 4
pref("urlclassifier.disallow_completions", "long-string"); // prev: "long-string"

bugzilla tickets

app.normandy.api_url
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

app.normandy.dev_mode
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

app.normandy.enabled
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

app.normandy.logging.level
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

app.normandy.run_interval_seconds
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

app.normandy.shieldLearnMoreUrl
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

app.shield.optoutstudies.enabled
Bug 1436113 - Part 2: Refactor "shield-recipe-client" to "normandy"

browser.cache.offline.insecure.enable
Bug 1354175 - Disable AppCache in insecure contexts.

browser.chrome.errorReporter.enabled
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.chrome.errorReporter.infoURL
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.chrome.errorReporter.logLevel
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.chrome.errorReporter.projectId
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.chrome.errorReporter.publicKey
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.chrome.errorReporter.sampleRate
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.chrome.errorReporter.submitUrl
Bug 1426482 Report browser errors in Nightly to Mozilla.

browser.newtabpage.activity-stream.aboutHome.enabled
Bug 1433324 - Part 1. Assume true for browser.newtabpage.activity-stream.aboutHome.enabled.
Bug 1396274 - Disable Activity Stream about:home in browser_aboutHome.js
Bug 1392324 - Add pref to enable Activity Stream on about:home.

browser.newtabpage.activity-stream.enabled
Bug 1433324 - Part 3. Assume true for browser.newtabpage.activity-stream.enabled.
Bug 1396654 - Enable Activity Stream by default for all channels.

browser.newtabpage.columns
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

browser.newtabpage.compact
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

browser.newtabpage.directory.source
Bug 1370930 - remove DirectoryLinksProvider,

browser.newtabpage.enhanced
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

browser.newtabpage.introShown
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

browser.newtabpage.rows
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

browser.newtabpage.thumbnailPlaceholder
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

browser.places.useAsyncTransactions
Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the

only version.

browser.policies.enabled
Bug 1442759 - Enable the policy engine by default on Nightly and early Betas.

browser.safebrowsing.provider.mozilla.lists
Bug 1423229 - [4.0] Add support for category-based tracking lists.

browser.schedulePressure.timeoutMs
Bug 1436423 - Reduce the schedule pressure limit closer to the values that users are reporting.
Bug 1406414 - Switch to an APNG loading indicator when the browser is under schedule pressure.

browser.startup.blankWindow
Bug 1336227 - Show about:blank as soon as possible during startup (pref'ed off),

browser.urlbar.openintab
Bug 1394304: Part 1 - Use pref to control whether to open url bar results in a new tab.

device.sensors.ambientLight.enabled
Bug 1359076: Disable all Device Sensor APIs except orientation by default

device.sensors.motion.enabled
Bug 1359076: Disable all Device Sensor APIs except orientation by default

device.sensors.orientation.enabled
Bug 1359076: Disable all Device Sensor APIs except orientation by default

device.sensors.proximity.enabled
Bug 1359076: Disable all Device Sensor APIs except orientation by default

devtools.browserconsole.filter.css
Bug 1435092 - Add a util object to manage preferences;
Bug 1204808 - Move devtools prefs to its own file in /devtools folder.

devtools.browserconsole.filter.debug
Bug 1435092 - Add a util object to manage preferences;

devtools.browserconsole.filter.net
Bug 1435092 - Add a util object to manage preferences;
Bug 1204808 - Move devtools prefs to its own file in /devtools folder.

devtools.browserconsole.new-frontend-enabled
Bug 1435084 - Create a pref to enable the new console UI in the browser console;r=nchevobbe

devtools.browserconsole.ui.filterbar
Bug 1435092 - Add a util object to manage preferences;

devtools.devedition.promo.enabled
Bug 1204808 - Move devtools prefs to its own file in /devtools folder.

devtools.highlighter.writingModeAdjust
Bug 1430919 - Enable grid highlighter writing mode support.
Bug 1303171 - Adjust highlighters to account for writing mode and text dir.

devtools.responsive.reloadConditions.touchSimulation
Bug 1428816 - Add RDM UI to control whether we reload.

devtools.responsive.reloadConditions.userAgent
Bug 1428816 - Add RDM UI to control whether we reload.

devtools.responsive.reloadNotification.enabled
Bug 1428816 - Show reload help on first RDM open.

dom.ipc.useNativeEventProcessing.content
Bug 1430744: Stop processing native events in the content process on Windows in Nightly.

dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content
Bug 1443117 - Restart to dispatch "keypress" event for non-printable keys and key

combinations on Nightly and early-Beta until Google fixes related bugs of their web apps
Bug 1440189 - part 1: Stop dispatching keypress event to the default event group in web content (only
Nightly and early Beta)
Bug 1433101 - part 1: Add new pref which disables keypress event for non-printable keys only for the
default event group in web content

dom.moduleScripts.enabled
Bug 1438139 - Enable <script type="module"> by default
Bug 1428685 - Use dom.webcomponents.shadowdom.enabled pref for Shadow DOM.

dom.push.alwaysConnect
Bug 1440467 - Add a pref to always connect to the Push server without existing subscriptions.

dom.registerContentHandler.enabled
Bug 1398169 - Use pref to disable registerContentHandler in non stable builds.

dom.registerProtocolHandler.insecure.enabled
Bug 1429732 - Use a pref to disable registerProtocolHandler in insecure contexts.

dom.secureelement.enabled
Bug 1353329 - Remove remains of SecureElement API.

dom.serviceWorkers.update_delay
Bug 1432846 - Delay update runnables from service workers that don't control any clients.

dom.webdriver.enabled
Bug 1169290 - Guard navigator.webdriver behind dom.webdriver.enabled pref.

dom.webmidi.enabled
Bug 1201590 - WebMIDI Utility classes;

dom.workers.enabled
Bug 1434934 - Remove dom.workers.enabled pref,

editor.use_div_for_default_newlines
Bug 1430551 - Make editor use <div> as defaultParagraphSeparator even in release channel

extensions.alwaysUnpack
Bug 1444502: Remove support for installing unpacked extensions.

extensions.getAddons.compatOverides.url
Bug 1402064 Switch to modern AMO metadata API

extensions.getAddons.get.url
Bug 1402064 Switch to modern AMO metadata API

extensions.getAddons.getWithPerformance.url
Bug 1402064 Switch to modern AMO metadata API

extensions.hotfix.cert.checkAttributes
Bug 1356331 Remove hotfix code from addons manager and related tests

extensions.hotfix.certs.1.sha1Fingerprint
Bug 1356331 Remove hotfix code from addons manager and related tests

extensions.hotfix.certs.2.sha1Fingerprint
Bug 1356331 Remove hotfix code from addons manager and related tests

extensions.hotfix.id
Bug 1356331 Remove hotfix code from addons manager and related tests

extensions.interposition.enabled
Bug 1443983: Part 2 - Remove remaining interpositions.
Bug 1412456 - Disable add-on interposition

extensions.interposition.prefetching
Bug 1443983: Part 2 - Remove remaining interpositions.

extensions.langpacks.signatures.required
Bug 1444487 Add preference for langpack signing.

extensions.screenshots.upload-disabled
Bug 1432694 - Add a default value for the Screenshots upload-disabled pref;

extensions.webextensions.restrictedDomains
Bug 1415644: Create a list of restricted domains.

font.name-list.sans-serif.ko
Bug 1431570 - Use Malgun Gothic as default font of Korean on release channel.

general.document_open_conversion_depth_limit
Bug 1440663 - Add a preference to limit document opening data conversion recursion depth to

nsDocumentOpenInfo,

gfx.font_loader.families_per_slice
Bug 1440411 - Remove the obsolete gfx.font_loader.families_per_slice pref (no longer used by any

code).

gfx.webrender.blob-images
Bug 1362115 - turn on blob-images by default with webrender.
Bug 1425260: gfx.webrender.all turns on all preferences that are needed for webrender.

gfx.webrender.hit-test
Bug 1421380 - Enable gfx.webrender.hit-test by default.
Bug 1423982 - Only do the WR-based hit-test if WR is enabled.

identity.fxaccounts.enabled
Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA.

identity.fxaccounts.remote.connectdevice.uri
Bug 1427674 - Unify FxA content server URL preferences.
Bug 1418466 - Add Connect Another Device button to relevant Sync UI.

identity.fxaccounts.remote.email.uri
Bug 1427674 - Unify FxA content server URL preferences.
Bug 1411714 - Handle action=email in about:accounts.

identity.fxaccounts.remote.force_auth.uri
Bug 1427674 - Unify FxA content server URL preferences.

identity.fxaccounts.remote.root
Bug 1427674 - Unify FxA content server URL preferences.

identity.fxaccounts.remote.signin.uri
Bug 1427674 - Unify FxA content server URL preferences.

identity.fxaccounts.remote.signup.uri
Bug 1427674 - Unify FxA content server URL preferences.

identity.fxaccounts.remote.webchannel.uri
Bug 1427674 - Unify FxA content server URL preferences.

identity.fxaccounts.settings.devices.uri
Bug 1427674 - Unify FxA content server URL preferences.

identity.fxaccounts.settings.uri
Bug 1427674 - Unify FxA content server URL preferences.

image.animated.decode-on-demand.batch-size
Bug 523950 - Part 3. Add preferences to control animated image decoding behaviour.

image.animated.decode-on-demand.threshold-kb
Bug 523950 - Part 3. Add preferences to control animated image decoding behaviour.

image.mem.animated.use_heap
Bug 1427639 - Part 1. Add preferences to control image frame allocations in volatile memory or the

heap.

image.mem.volatile.min_threshold_kb
Bug 1427639 - Part 1. Add preferences to control image frame allocations in volatile memory or the

heap.

image.multithreaded_decoding.idle_timeout
Bug 1436247 - Part 2. Shutdown idle image decoder threads after the configured timeout.

intl.tsf.hack.japanist10.do_not_return_no_layout_error_of_composition_string
Bug 1435730 - part 1: Make TSFTextStore::GetTextExt() not return TS_E_NOLAYOUT error to Japanist 10

when the range is in composition string

javascript.options.array_prototype_values
Bug 1420101 - Add default enabled pref for Array.prototype.values.

javascript.options.spectre.jit_to_C++_calls
Bug 1438886 - Prevent speculative execution after returning from GC-capable C++ code.

javascript.options.spectre.object_mitigations.barriers
Bug 1437483 part 3 - Enable Ion object type barrier mitigations by default.
Bug 1437483 part 1 - Add pref for Spectre mitigations for Ion object type barriers.

javascript.options.spectre.object_mitigations.misc
Bug 1442561 part 3 - Flip the pref.
Bug 1442561 part 1 - Add browser pref for misc Spectre object type mitigations.

javascript.options.spectre.string_mitigations
Bug 1434230 part 4 - Enable Spectre string mitigations by default.
Bug 1434230 part 1 - Some Spectre mitigations for loadStringChars.

javascript.options.spectre.value_masking
Bug 1433111 - Add JS Shell and about:config switch for Value masking.

layers.omtp.dump-capture
Add 'layers.omtp.dump-capture' for logging DrawTargetCapture (bug 1435938,

layout.css.individual-transform.enabled
Bug 1207734 - Part 2. Add a preference to enable/disable individual transform.

layout.css.paint-order.enabled
Bug 1435684 - Enable the paint-order property for HTML text.
Bug 1426146 - patch 2 - Support the paint-order property for HTML text (in addition to SVG); currently

preffed-off by default.

layout.css.servo.chrome.enabled
Bug 1417138 part 2 - Enable stylo-chrome by default.
Bug 1430014 - Part 1: Add --enable-stylo=only configure option and MOZ_OLD_STYLE define.

layout.css.stylo-blocklist.blocked_domains
Bug 1426223 - remove Stylo domain blocklist mechanism.

layout.css.stylo-blocklist.enabled
Bug 1426223 - remove Stylo domain blocklist mechanism.

layout.display-list.retain
Bug 1413546 - Add pref to allow retained display lists within the parent process.

layout.word_select.stop_at_underscore
Bug 1431672 - Add a pref to control whether underscore is treated as a word-forming character.

media.cubeb.sandbox
Bug 1434156 - Remove nightly gate from AudioIPC for Linux.
Bug 1425788 - Disable AudioIPC on macOS while investigating fallout.

media.getusermedia.camera.off_while_disabled.delay_ms
Bug 1299515 - Disable turning off camera while disabled by default on android.

media.getusermedia.camera.off_while_disabled.enabled
Bug 1299515 - Disable turning off camera while disabled by default on android.

media.getusermedia.microphone.off_while_disabled.delay_ms
Bug 1436352 - Enable turning microphone off on track-disable by default.

media.getusermedia.microphone.off_while_disabled.enabled
Bug 1436352 - Enable turning microphone off on track-disable by default.

network.dns.native-is-localhost
bug 1434852 - introducing TRR (DOH);

network.ftp.enabled
Bug 1374114 - Add a pref to disable ftp.

network.tcp.tcp_fastopen_enable
Bug 1431738 - We will disable TFO on late beta and release.

Bug 1425462 When reducing the precision of timestamps, also apply fuzzytime to them

security.insecure_connection_text.enabled
Bug 1335970 - Add prefs to add "Not Secure" text to insecure pages.

security.insecure_connection_text.pbmode.enabled
Bug 1335970 - Add prefs to add "Not Secure" text to insecure pages.

security.mixed_content.upgrade_display_content
Bug 1440709 - Disabling mixed content upgrading for now.
Bug 1435733 - Upgrade mixed display content pref.

security.pki.distrust_ca_policy
Bug 1442075 - Enforce Symantec distrust in Firefox 60
Bug 1437754 - Add a pref and disable the Symantec distrust algorithm

security.sandbox.content.level
Bug 1441824: Let level 5 (Alternate Desktop) for the Windows content sandbox ride the trains.
Bug 1126437 - Add Linux content sandbox level 4 for blocking socket APIs.
Bug 1417959: Bump Alternate Desktop to Level 5 and make that the Default on Nightly.
Bug 1417959 - Bump Alternate Desktop to Level 5 and make that the Default on Nightly.
Bug 1415250 Part 2: Make level 4 the default for the Windows content process sandbox.
Bug 1402351 - Make the Linux level 3 / read sandbox ride the trains.
Bug 1402340 - On non-Nightly revert back to Windows content process sandbox level 3 to fix suspected

top crashes.
Bug 1229829 - Part 2 - Use an alternate desktop on the local winstation for content processes;
Bug 1388046 - Disable sandbox read restrictions (level 3) on beta/release.

security.webauth.webauthn
Bug 1432542 - Enable Web Authentication
Bug 1428918 - Enable Web Authentication in Nightly
Bug 1399959 - Prefer hardware instead of software U2F tokens

security.xcto_nosniff_block_images
Bug 1397740 - Removed security.xcto_nosniff_block_images from about:config

services.sync.prefs.sync.browser.newtabpage.enhanced
Bug 1433133 - remove unused prefs and exported bits from NewTabUtils.jsm,

services.sync.prefs.sync.browser.urlbar.matchBuckets
Bug 1430994 - Sync the browser.urlbar.matchBuckets pref.

services.sync.prefs.sync.privacy.resistFingerprinting.reduceTimerPrecision.jitter
Bug 1425462 When reducing the precision of timestamps, also apply fuzzytime to them

signed.applets.codebase_principal_support
Bug 1434952 - Remove signed.applets.codebase_principal_support pref.

svg.paint-order.enabled
Bug 1437267 - Remove the svg.paint-order.enabled pref.
Bug 1362115 - turn on blob-images by default with webrender.

urlclassifier.disallow_completions
Bug 1423229 - [4.0] Add support for category-based tracking lists.
Bug 1407879 - Check password field url against the local whitelist.
Bug 1385484 - Cleanup Safe Browsing prefs and sync the download protection setting.

view_source.tab
Bug 1418403 - Remove viewing source in a standalone window.

removed? pref("dom.workers.enabled", true); .. WTF? Are you F kidding me?

totally forgot about this from diffs 58->59

layout.css.moz-document.content.enabled=false might be worth considering.
https://bugzilla.mozilla.org/show_bug.cgi?id=1035091
https://www.fxsitecompat.com/en-CA/docs/2015/moz-document-support-will-be-dropped/

Questions: the extension CSS Exfil Protection handles this stuff

Does this setting make the extension obsolete?
Does this pref and/or the extension become obsolete in FF61 (or thereabouts? see compat article)

^^I have asked/pointed the CSS Exfill author to your question.
Cheers

Hi all, I'm the author of CSS Exfil Protection.  To answer Thorin's question, no I don't believe this removal would make the plugin obsolete as the plugin guards against several other methods that could be used to exfil data (background-image, list-style, cursor, & content).
Actually, the plugin as it stands today does not block anything related to the -moz-document selector.  Today is the first I've heard of this selector, although it sounds like it's getting phased out so it's likely I won't need to add protection.
(PS - I would love for a day when my plugin becomes completely obsolete.  Although it's fun hacking away at it, I'd rather see the protection offered by default in major browsers.)

Bug 1446470: Make the moz-document-in-content pref false by default.

See here.

The @document at-rule has been limited to use only in user and UA sheets (bug 1035091)

See here.
While @mlgualtieri plugin works by pre-processing the CSS which is loaded onto a web page.

Inspection and sanitization of each CSSRule is done through the browser's native CSSStyleSheet JavaScript API. If a CSSRule.selectorText is detected that: 1) Parses the value attribute of an element, and 2) If the corresponding CSSRule.cssText includes a call to a remote URL, a new rule is created to override the call to the remote URL.

See Defense for Web Users.

https://trac.torproject.org/projects/tor/ticket/25559

network.ftp.enabled
security.mixed_content.upgrade_display_content
dom.registerProtocolHandler.insecure.enabled
browser.cache.offline.insecure.enable
dom.registerContentHandler.enabled

https://www.bleepingcomputer.com/news/software/firefox-gets-privacy-boost-by-disabling-proximity-and-ambient-light-sensor-apis/ - 4 new prefs
// 4604: [2512] disable device sensor API
   // [WARNING] [SETUP] Optional protection depending on your device
   // [1] https://trac.torproject.org/projects/tor/ticket/15758
   // [2] https://blog.lukaszolejnik.com/stealing-sensitive-browser-data-with-the-w3c-ambient-light-sensor-api/
   // [3] https://bugzilla.mozilla.org/buglist.cgi?bug_id=1357733,1292751
   // user_pref("device.sensors.enabled", false);

--new bit--
   // user_pref("pref("device.sensors.ambientLight.enabled", false); // (FF60+)
   // user_pref("pref("device.sensors.motion.enabled", false); // (FF60+) default: true
   // user_pref("pref("device.sensors.orientation.enabled", false); // (FF60+) default: true
   // user_pref("pref("device.sensors.proximity.enabled", false); // (FF60+)

^^ is this worth it when we have the master switch?

@earthlng do you use the // default: true comments in your scripts? because if you search for // default there are 5 that don't fit the pattern with the colon missing etc
0420 - 2 lines
1402 - 3 lines (we could remove these because they are western defaults, not universal ones)
note: we already have 4604 device.sensors.enabled which is inactive with a setup tag. Just add them as false inactive to the 4604

In your code-bit above you have it exactly the wrong way around.

Oh, I see now. Need MOAR coffee.

@claustromaniac : the parrot will be removed (see deprecated first section). Is this used in any way for the updater, prefs cleaner (besides the ignoring those lines)?

certain syntax errors stop the parsing and the debug pref is still useful in those cases. We just need to change the last one to something less definite.

WTF! where did all our sticky issues go?? am I the only one seeing this?

Pants is gone too???!!!! https://github.com/Thorin-Oakenpants

It seems all of Pants' issues are gone, not just the sticky ones. They must have been banned, or hacked, or this is their way of saying "fuck it".
Can anyone contact them?

Indeed, all his issues are gone.
from https://help.github.com/articles/deleting-your-user-account/ :

Deleting your user account removes all repositories, forks of private repositories, wikis, issues, pull requests, and pages owned by your account. Issues and pull requests you've created and comments you've made in repositories owned by other users will not be deleted

but the wiki is still here, no idea how that is possible. and

If you’re the only owner of an organization, you must transfer ownership to another person or delete the organization before you can delete your user account.

Pants is/was the only owner of the organization and the repo but he apparently was able to delete his account without transferring ownership to me or someone else. Maybe his account was banned?  He could've just abandoned his account or at least say something first so that I could have copied the stickies, etc. All the infos he's collected over months in the stickies is now just totally gone.
I've written him an email asking what's going on.

I've written him an email asking what's going on.

Nice.

How many Pants' are there?

Billions.
If you expected a more serious answer, then read this. If it was just a rethorical question, well... sorry.

Billions.

If you expected a more serious answer, then read this. If it was just a rethorical question, well... sorry.
Ha, totally kidding. Thought about putting a smiley or something but figured it wasn't needed, glad you knew and good to see the Pants' are reaching such high population numbers.

When I saw most of issues were gone, I didn't understand.
Thanks earthlng for giving some information.

@Pants I wish this will be sorted out fast and without a pain.
About CK... if he is behind or not, I still cannot express my opinion about him and in the same time not to go in the ocean of bad words.

I hope @Thorin-Oakenpants finds his way back soon!

WELCOME BACK MY FRIEND! you had me worried for a moment there! I'm glad everything got sorted out and is now back to normal, all your stickies and issues un-hidden, etc.
so the CHEF-KOCH got you banned, huh?! HOLY SHIT!
I'd love to know more about the conversations you had with github support to get your account un-banned.

Just to confirm, it was he who shall not be named... he must have spent ages pouring over the T&C finding something - it was a comment of mine that pointed readers to his "Say Thanks" asking you to say "Thanks" to him. Removed the comment, and now I am not flagged.  :)

Geez!  Not that I would ever do that of course! DON`T DO THAT, GUYS! :)

Sheeshus .. don't you start .. if you get flagged I'll lose the diff issues

there is one I think I will keep top and center, just keep adding to it

yeah for sure. And thanks for the email - you handled it well.

Ha, totally kidding. Thought about putting a smiley or something but figured it wasn't needed, glad you knew and good to see the Pants' are reaching such high population numbers.

Oh. But I didn't really know. I just bundled three different answers.

Shame? I just presented some of the less-complex possibilities I could think of. Besides, it just means I consider you significantly high-profile to be worth a hack, which should be kind of flattering! I could be exchanging words with terrorists and all sorts of lunatics here, for all I know.
Sorry if it offends you.

Singular. They. Same argument as before: you could be an alien or some paranoid AI for all I know. You should be thankful I didn't use "it", instead.
What the hell, man.  It's a genuine question, it's not my native language.
On second thought, if you were an alien it probably wouldn't be your native language either. Unless you were a Hollywood alien, of course.
Anyway, I'm just glad you're back.

BTW you could actually be several people for all I know... :zipper_mouth_face:

BTW you could actually be several people for all I know...

No, we are not several people. I'm not schizophrenic, and neither am I, BTW.

/* 2730b: disable offline cache on insecure sites (FF60+)
 * [1] https://blog.mozilla.org/security/2018/02/12/restricting-appcache-secure-contexts/ ***/
user_pref("browser.cache.offline.insecure.enable", false);

moved from new to ignore:
pref("dom.webdriver.enabled", true); // marionette related
pref("general.document_open_conversion_depth_limit", 20);
pref("marionette.debugging.clicktostart", false); // marionette is always disabled by default
pref("marionette.enabled", false); // always false anyway
pref("privacy.resistFingerprinting.reduceTimerPrecision.jitter", true);

extensions.webextensions.restrictedDomains - @earthlng check yur email

IDK about that. If you don't trust your installed webextensions it might be a good idea. But if f.e a hacker manages to inject external JS into one of those domains, you'd normally see + block that with uMatrix.
If uMatrix etc are locked out with that pref you won't notice anything.

network.dns.native-is-localhost - For testing purposes!

^^ I'm digging. See more emails. I do not think this is anything more than them locking down Mozilla domains to be proactive against 3rd parties (eg block lists, scripts, extensions) whether they are malicious or not. You have to have trust in the platform/store and bad press (even if its not caused by Mozilla) is a no no. I'm pushing to see if there is anything else to it.
So for 99.9% of users this is all good. But the trade off is that we have no control over said domains.
Anyway, see email

browser.chrome.errorReporter.* - only enabled in Nightly.
https://wiki.mozilla.org/Firefox/BrowserErrorCollection
https://support.mozilla.org/en-US/kb/firefox-nightly-error-collection
https://firefox-source-docs.mozilla.org/browser/browser/BrowserErrorReporter.html

extensions.getAddons.get.url - never used thanks to 0306 - moved to ignore

^^ cool. I like future proofing though. Remember, ~~that one~ those several times at bandcamp, when FHR or telemetry didn't respect a master pref?

https://bugzilla.mozilla.org/show_bug.cgi?id=1453988

/* xxxx: disable Browser Error Reporter (FF60+)
 * [1] https://support.mozilla.org/en-US/kb/firefox-nightly-error-collection
 * [2] https://firefox-source-docs.mozilla.org/browser/browser/BrowserErrorReporter.html ***/
user_pref("browser.chrome.errorReporter.enabled", false);
user_pref("browser.chrome.errorReporter.submitUrl", "");

maybe 0380? or move the remaining 2 prefs in 0360 somewhere else because those 2 alone don't really "quiet fox" the new Activity-stream page anymore.

So in FF60+ the 4503 pref is meaningless

without that pref you give them access to a special mozAddonManager API. Unnecessary IMO.

But ME, I'm definitely editing out AMO from that pref

that won't work because the code to restrict webextension access checks both the new pref and 4503

that won't work because the code to restrict webextension access checks both the new pref and 4503

I have 4503 in my overrides

0380 sounds fine.  You've seen the countless reddit posts asking why AMO detects their FFs as an older version. I assume, based on the mozAddonManager pref being an RFP sub-pref, the whole point of the mozAddonManager was to be able to detect the FF version despite RFP.

I'd put it under 2600, something like this:
/* 26xx: disable webextension restrictions on certain mozilla domains (FF60+) ***/
   // user_pref("extensions.webextensions.restrictedDomains", "");

add notes and/or warnings as you see fit

OT: https://bugzilla.mozilla.org/show_bug.cgi?id=1410106  Interesting bug. I thought PB mode didn't allow IDB, seems workers could bypass that at some stage - hell, it even has a CVE

For 3rd party scripts only, starting from FF 43 until today:

The Web Storage API now respects the browser’s third-party cookies preference, so it will no longer work when the script is in a third-party context and the user has disabled third-party cookies. The IndexedDB API and the new Service Worker Cache API will also obey the same constraint.

...see link here.

Atavic, I don't see the relevance -  the whole point of PB mode was no persistent data. IDB was explicitly left out for a reason - there was no sanitizing mechanism. It's the oversight that I'm pointing out, not how persistent data is controlled.

If the 1st party uses web workers, then it is able to use IndexedDB.
I don't see it as an oversight, cliqz is partner wit Mozilla.

If the 1st party uses web workers, then it is able to use IndexedDB.
I don't see it as an oversight, cliqz is partner with Mozilla.

I know web workers can use IDB, what I am talking about is that in PB MODE they made a decision to not allow IDB due to a lack of ability to sanitize it on close, and completely forgot about workers using it. Maybe I read the bug wrong

I totally agree! But it cannot be an oversight.

It definitely IS an oversight. They decided the rule was ZERO persistent web data. That meant web site breakage with a secondary consideration, i.e no IDB (and they did that, see, even extensions got caught up in it), but then they didn't check everything did they. That's the very definition of an oversight.

^^ https://medium.com/@konarkmodi/breaking-bad-to-make-good-firefox-cve-2017-7843-219034357496

Since we're using this issue for totally OT-stuff rather than doing anything diff-related ...
:jeans:, I disabled Projects in the settings

Projects
Project boards on GitHub help you organize and prioritize your work. You can create project boards for specific feature work, comprehensive roadmaps, or even release checklists.

:jeans:, I disabled Projects in the settings

Sweet. That takes a lot of potential workload off my shoulders. I did have a dozen projects lined up, but now I can forget about them :) Thanks :+1:

60b16 changes since 60b9
new
pref("app.normandy.first_run", true);
pref("image.animated.decode-on-demand.threshold-kb", 4194303); // 60b9: 20480
pref("network.cookie.same-site.enabled", true);
changed
pref("layout.display-list.retain", true); // prev: false
pref("privacy.resistFingerprinting.reduceTimerPrecision.microseconds", 1000); // prev: 2000

same site cookies

pref("network.cookie.same-site.enabled", true);
https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60/
insert bugzilla here

Here's the meta bug for same-site cookies: https://bugzilla.mozilla.org/show_bug.cgi?id=samesite-cookies
Probably no point in listing this pref in user.js since it's enabled by default and it restricts cookies further. The pref is only there in case we need to turn the feature off quickly due to unforeseen bugs/breakage.

SameSite=strict goes further than disabling third-party cookies. It also strips the first-party cookie if you follow a link from a different site. See http://www.sjoerdlangkemper.nl/2016/04/14/preventing-csrf-with-samesite-cookie-attribute/ for a good explanation.

@fmarier thx
If I understand correctly this behavior is server side controlled over header and not client side by preferences?

This browser setting lets the end-user disable all third-party cookies. The same-site cookie attribute, on the contrary, gives web sites fine-grained control over how to handle their cookies.

We already block all 3rd party cookies (in fact we I already block all cookies). Also, bend me over and call me Susan, but wouldn't FPI also mitigate this (if you allowed 3rd party cookies .. but then again the only reason I would do so is for login purposes eg secure.bank.com on bank.com). That .nl link is pretty nice :+1:
2706 is the next slot. Wouldn't mind nudging them down and stealing 2703

AFAIK FPI only works on domain anyway ie secure.bank.com has access to cookies etc from bank.com and vice-versa.
same-site cookies makes it so that when you click a link to yourbank.com and you happen to be logged in to yourbank.com in another tab (or didn't logout) the cookie will not be sent and therefore preventing potential CSRF. FPI has nothing to do with that.

bend me over and call me Susan

I'm OK with that.

maybe secure.bank.com and bank.com was a bad example (not sure how those tlds work). Take a look at the article again - I'll use facebook.com cookies as 3rd party (i.e the FB widget/like buttons etc)
FPI means that the FB cookies used on siteA cannot be used on siteB - that's what First Party Isolation means. They even want to enable 3rd party cookies in TBB (quote Arthur if I can find where he said it was in the pipeline)

my 2 cents:
pref("app.normandy.first_run", true); - probably unnecessary but we can add it to the other normandy stuff, up to you
pref("browser.startup.blankWindow", false); - nothing to do with privacy/security and IMO not worth adding to 5000 either
pref("browser.urlbar.openintab", false); - sounds pretty annoying. I'd ignore it
pref("devtools.policy.disabled", false); - devtools are awesome. Why would anyone want to disable that? IMO move to ignore
pref("dom.push.alwaysConnect", false); - default is false which is what we want and thus it's safe to ignore but I don't mind adding it with the other push stuff just in case
pref("network.ftp.enabled", true); - maybe add as inactive for those who want to disable it. I think FF61 will disable ftp for sub-resources which is probably the better option
pref("media.cubeb.sandbox", false); - something to do with audio on linux (and maybe Mac, IDK). It's true on linux and false on Windows. I'd say move to ignore
changed:
IMO move to ignore:
pref("browser.schedulePressure.timeoutMs", 300); // prev: 1000
pref("devtools.debugger.features.root", true); // prev: false - no idea what this is but most people probably don't use the debugger anyway
pref("gfx.webrender.blob-images", 1); // prev: 2
pref("gfx.webrender.hit-test", true); // prev: false
pref("layout.css.servo.chrome.enabled", true); // prev: false - seemingly removed in FF61
pref("privacy.resistFingerprinting.reduceTimerPrecision.microseconds", 1000); // prev: 2000

:jeans: you forgot to move 0512 to deprecated/removed

well f%$k :trollface:  .. why wasn't it listed in the removed, renamed or hidden section? or the deprecates sticky for that matter, which relies on this section?

I can't find any reference to the two prefs in the diffs - do you not pick up on system addon diffs? Also, a bugzilla would be nice

I am going to make 4503 privacy.resistFingerprinting.block_mozAddonManager active (as true). It reduces extra data collection (by Mozilla) and now with extensions.webextensions.restrictedDomains in FF60+ at default, there is no risk of scripts injecting etc. While Mozilla is probably a special case at times, to me, all domains are to be treated equal (personally I'm also blanking restrictedDomains - I'm a big boy and can take care of myself - no to GA and yes to allowing extensions to work on those domains)
ESR52.x users who will hang out until the bitter end instead of moving to ESR60 branch .. not affected since 4503 is a FF57+ pref

you forgot to move 0512 to deprecated/removed

Did a commit, and added to the deprecated sticky. BUT, I gotta ask @earthlng ), how did these two prefs not get listed in the diffs above - I rely on the diffs to generate the sticky issue and drive changes here. Just asking, not throwing stones or anything. Is is something to do with being a system addon, and the prefs are hidden until created by the addon?

Is is something to do with being a system addon, and the prefs are hidden until created by the addon?

yes exactly. I already planned to change the way I retrieve the default prefs for the next diff because of some changes mozilla made in 61 but I'll update this diff as well as soon as FF60 portable is available.
I'll have to install a certain version to get a diff for it and thus I won't be able to create OS-diffs anymore because I don't have a Mac.

moved from new to ignore

pref("browser.urlbar.openintab", false);

agreed it sounds silly. searchbar I get, but the urlbar? why would anyone type over a current tab and then open in a new one? Does the old urlbar URL come back? IDK, don't care.

pref("dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content", false);

sounds complicated and over my head, I don't even have any idea what this is really, but it ain't privacy related

pref("dom.push.alwaysConnect", false);

1440467 - ignore it, we can add it IF they ever flip it

pref("network.ftp.enabled", true);

Agreed. Ignore it. We can look at FTP subresources in 61 as you said

--
should we add this one?

pref("dom.registerProtocolHandler.insecure.enabled", true);

1429732
fxsitecompat
if I read this right, then we want it to be false, which will happen in FF62 anyway, but it would benefit ESR60 users

I'm taking the day/night off. Feel free to commit ftp and the 2xregister*handlers :beer: :cocaine: :hookers:

updated the 1st post.
following are the prefs set by system addons or not included in the default prefs files and therefore missing in the diffs. some of them are NEW in FF60 and are now included in the updated 1st post.
click me
pref("browser.newtabpage.activity-stream.collapseTopSites", false);
pref("browser.newtabpage.activity-stream.default.sites", "https://www.youtube.com/,https://www.facebook.com/,https://www.wikipedia.org/,https://www.reddit.com/,https://www.amazon.com/,https://twitter.com/");
pref("browser.newtabpage.activity-stream.disableSnippets", false);
pref("browser.newtabpage.activity-stream.enableWideLayout", true);
pref("browser.newtabpage.activity-stream.feeds.favicon", true);
pref("browser.newtabpage.activity-stream.feeds.migration", true);
pref("browser.newtabpage.activity-stream.feeds.newtabinit", true);
pref("browser.newtabpage.activity-stream.feeds.places", true);
pref("browser.newtabpage.activity-stream.feeds.prefs", true);
pref("browser.newtabpage.activity-stream.feeds.section.highlights", true);
pref("browser.newtabpage.activity-stream.feeds.section.topstories", false);
pref("browser.newtabpage.activity-stream.feeds.section.topstories.options", "{\"api_key_pref\":\"extensions.pocket.oAuthConsumerKey\",\"hidden\":true,\"provider_description\":\"pocket_description\",\"provider_icon\":\"pocket\",\"provider_name\":\"Pocket\",\"read_more_endpoint\":\"https://getpocket.com/explore/trending?src=fx_new_tab\",\"stories_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=en-US&feed_variant=default_spocs_off\",\"stories_referrer\":\"https://getpocket.com/recommendations\",\"privacy_notice_link\":\"https://www.mozilla.org/privacy/firefox/#suggest-relevant-content\",\"disclaimer_link\":\"https://getpocket.com/firefox/new_tab_learn_more\",\"topics_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/firefox/trending-topics?version=2&consumer_key=$apiKey&locale_lang=en-US\",\"show_spocs\":false,\"personalized\":true}");
pref("browser.newtabpage.activity-stream.feeds.sections", true);
pref("browser.newtabpage.activity-stream.feeds.snippets", true);
pref("browser.newtabpage.activity-stream.feeds.systemtick", true);
pref("browser.newtabpage.activity-stream.feeds.telemetry", true);
pref("browser.newtabpage.activity-stream.feeds.topsites", true);
pref("browser.newtabpage.activity-stream.filterAdult", true);
pref("browser.newtabpage.activity-stream.migrationExpired", false);
pref("browser.newtabpage.activity-stream.migrationLastShownDate", 0);
pref("browser.newtabpage.activity-stream.migrationRemainingDays", 4);
pref("browser.newtabpage.activity-stream.section.highlights.collapsed", false);
pref("browser.newtabpage.activity-stream.section.highlights.includePocket", true);
pref("browser.newtabpage.activity-stream.section.topstories.collapsed", false);
pref("browser.newtabpage.activity-stream.section.topstories.showDisclaimer", true);
pref("browser.newtabpage.activity-stream.sectionOrder", "topsites,topstories,highlights");
pref("browser.newtabpage.activity-stream.showSearch", true);
pref("browser.newtabpage.activity-stream.showSponsored", true);
pref("browser.newtabpage.activity-stream.showTopSites", true);
pref("browser.newtabpage.activity-stream.telemetry", true);
pref("browser.newtabpage.activity-stream.telemetry.ping.endpoint", "https://tiles.services.mozilla.com/v4/links/activity-stream");
pref("browser.newtabpage.activity-stream.telemetry.ut.events", false);
pref("browser.newtabpage.activity-stream.tippyTop.service.endpoint", "https://activity-stream-icons.services.mozilla.com/v1/icons.json.br");
pref("browser.newtabpage.activity-stream.topSitesRows", 1);
pref("extensions.pocket.api", "api.getpocket.com");
pref("extensions.pocket.oAuthConsumerKey", "40249-e88c401e1b1f2242d9e441c4");
pref("extensions.pocket.site", "getpocket.com");
pref("extensions.webcompat.perform_ua_overrides", true);
pref("pdfjs.cursorToolOnLoad", 0);
pref("pdfjs.defaultZoomValue", "");
pref("pdfjs.disableAutoFetch", false);
pref("pdfjs.disableFontFace", false);
pref("pdfjs.disablePageLabels", false);
pref("pdfjs.disablePageMode", false);
pref("pdfjs.disableRange", false);
pref("pdfjs.disableStream", false);
pref("pdfjs.enablePrintAutoRotate", false);
pref("pdfjs.enableWebGL", false);
pref("pdfjs.externalLinkTarget", 0);
pref("pdfjs.pdfBugEnabled", false);
pref("pdfjs.renderer", "canvas");
pref("pdfjs.renderInteractiveForms", false);
pref("pdfjs.showPreviousViewOnLoad", true);
pref("pdfjs.sidebarViewOnLoad", 0);
pref("pdfjs.textLayerMode", 1);
pref("pdfjs.useOnlyCssZoom", false);

pref("app.shield.optoutstudies.enabled", true); was added to the default pref files in FF60 but apparently existed before that as a pref set by a system addon. I kept it under NEW regardless.

earthlng commented 9 minutes ago
earthlng edited 31 minutes ago (first post)

I'll assume you're in the middle of adding them then :+1:

what do you mean?

^^ You said you updated the 1st post, but I'm struggling to see what you added. I thought you meant you were going to add all those prefs in the click me . Nvm - I'm sure it's all sorted. I need some sleep

FYI: FF60 security advisories CVE-2018-5152 - This is the extensions.webextensions.restrictedDomains pref. It links to 1415644 which we already listed, but also to 1427289 (no idea what's in there - as both are still access denied). Anyway the description is

WebExtensions with the appropriate permissions can attach content scripts to Mozilla sites such as accounts.firefox.com and listen to network traffic to the site through the webRequest API. For example, this allows for the interception of username and an encrypted password during login to Firefox Accounts. .. [etc]

pdfjs is ... secure/vetted as any pdf reader out there
Exploits are rare

really? https://www.mozilla.org/en-US/security/advisories/mfsa2018-11/#CVE-2018-5158

Anything related to pdf and office files isn't secure. They are widely used, sent by mail and exploited.

really? https://www.mozilla.org/en-US/security/advisories/mfsa2018-11/#CVE-2018-5158

So the second one in 4 or 5 years. What's your point. Shit happens. It's been patched.  Here is the full sentence

and as secure/vetted as any pdf reader out there (more than most)

wanna finish this?
what to do with the parrot? change the header of the first pref? what's the relevance of link 2?

wanna finish this?

probably

what to do with the parrot etc

We're using a bird (in this case a parrot, cuz Monty Python) just like a canary in a coal mine - a missing or dead canary indicates something went wrong. I know it's not for "warrants" but the concept is identical

If you want we can remove the two existing links
Remove line about redundancy, replace with line about "not all errors are now caught (see [3])" and add a [3] article link
^^ add same info to wiki page on how a user.js works

Do we want to change the wording for the last instance?

If you want we can remove the two existing links

:+1:
IDK if we need the 3rd link either. Better to just explain what it means for users. maybe something like

In FF60+, not all syntax errors cause parsing to abort ie reaching the last debug pref no longer necessarily means that all prefs have been applied. Check the console right after startup for any warnings/error messages related to non-applied prefs.

I do not know if they flip these for ESR at the same time

probably not. Maybe if someone asks them to. The prefs are already there and it would be a simple change.

or ... ignore them and let FF take their course

:+1:
re: moz-document - FF61 will also have an exception to avoid most breakage. It's unlikely that this will be backported to ESR. "ignore it since it will be covered by default in 61+" :+1:

Suggest we delete them all and just create two up to ESR60 - deprecated and removed

and maybe one for RFP-ALTS?

cleanup scripts: I kinda liked the [changes-only] because users can reset everything with a single script. Otherwise they need to run 3 or 4 and commented-out won't be covered.

and maybe one for RFP-ALTS?

:+1:   so three scripts then

I kinda liked the [changes-only]

We only have one of those. Kinda forgot about it. It looks lonely. We should put it out of it's misery. I was thinking more about the two the rest ones. Waste of time now - that's what the prefs cleaner is for and is not based on our master's state of active/inactive.
I need a list of removed items since last release
And I'm confused: If we have a deprecated up and including to ESR60, then running it on ESR60 = always up to date for ESR60 branch .. It's the next version (61) we add a line gap in deprecated and start a new ESR one char switch .. OK, I had to type that out to get my it straight .. not confused anymore

I need a list of removed items since last release

everything we removed since last release only enforced the default values and doesn't need to be reset because they weren't stored in prefs.js anyway.

That may be so, but I still want the list to be in the scratchpad so its complete. Just waiting on that (I guess I could go thru the commits if you can't rustle up a quick diff) and then I will run the three scripts, and then upload

on my setup, there were no errors, but one pref failed to reset (probably because I am on 59 still) - it was browser.newtabpage.enhanced. I have three files I'll upload in a sec

ghacks-clear-FF60inclusive-[deprecated].js
ghacks-clear-FF60inclusive-[removed].js
ghacks-clear-FF60inclusive-[RFP-alternatives].js

They all reference up to and including ghacks user.js 60-beta. The removed one includes 14 prefs commented out - they were all from the e10s section, and playing with that caused issues in the past - only two of them were ever active anyway (shims and browser.tabs.remote.separateFileUriProcess I think), so no big deal.
There were other items removed, I'm sure of it, but it's so hard to follow the 2600 changes with it all being reordered. As per the wiki section on Scratchpad Scripts

The REMOVED script is the ONLY single point of reference for everything we once tinkered with, but is now gone. ...

^^ I'd like the list to be complete. Also, users may have tinkered and changed the value from default and then removed it. So adding them does no harm.
Can you pretty please do a quick diff from 59-alpha vs now for removed prefs :kiss:

All done. Scripts uploaded. Will set to beta and create a release if you're ready - just thumbs up if thunderbirds are go

https://github.com/ghacksuserjs/ghacks-user.js/releases/tag/v60.0-beta
If you want to add anything to the description re changing from alpha to beta naming, that's cool - go for it


User Request: Add an option to select what image you want for every chess piece

Hi, currently I use the Custom Chess Pieces tool for this but I have run into some problems with it.  Could you add this functionality to your tool?

LiChess Tools is not a style enhancing extension. There are others that cover that niche. I try to stay away from anything graphical. Can't you raise the issue with the Custom Chess Pieces developer?


Returning x and y coordinates for nodes using viewGenerator

Description
I am trying create a tree like web where there are special nodes that go straight down like a timeline. and branch nodes that stem from those node nodes. So would like to keep the default functionality where branch nodes x and y coordinates are calculated, but those special nodes always need to have same value returned as their x coordinate. Y can increment based whatever value.
To Reproduce
I am using default graph settings but passing in default x and y for time nodes.
  data: {
    nodes: [
      {
        id: '02af27e0-34f1-4381-bc19-85f525a54f94',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 1',
      },
      {
        nodeType: 'timeLabel--case',
        id: '02af27e0-34f1-4381-bc19-85f525a54f94-t',
        name: '2019-08-30',
        x: 400,
        y: 120
      },
      {
        id: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 2',
      },
      {
        nodeType: 'timeLabel--case',
        id: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        name: '2019-08-26',
        x: 400,
        y: 240
      },
      {
        id: '7ea1661a-504c-44c7-8cc9-9a809ce59d84',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 3',
      },
      {
        nodeType: 'timeLabel--case',
        id: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        name: '2019-08-22',
        x: 400,
        y: 360
      },
      {
        id: '9caccc16-4696-48aa-b69b-1529b03d880c',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 4',
      },
      {
        id: '45ccc16-4696-48aa-b69b-1529b03d880c',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 5',
      },
      {
        nodeType: 'timeLabel--case',
        id: '9caccc16-4696-48aa-b69b-1529b03d880c-t',
        name: '2019-02-21',
        x: 400,
        y: 480
      }
    ],
    links: [
      {
        source: '02af27e0-34f1-4381-bc19-85f525a54f94-t',
        target: '02af27e0-34f1-4381-bc19-85f525a54f94'
      },
      {
        source: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        target: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48'
      },
      {
        source: '02af27e0-34f1-4381-bc19-85f525a54f94-t',
        target: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        color: '#00d3d3'
      },
      {
        source: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        target: '7ea1661a-504c-44c7-8cc9-9a809ce59d84'
      },
      {
        source: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        target: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        color: '#00d3d3'
      },
      {
        source: '9caccc16-4696-48aa-b69b-1529b03d880c-t',
        target: '9caccc16-4696-48aa-b69b-1529b03d880c'
      },
      {
        source: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        target: '9caccc16-4696-48aa-b69b-1529b03d880c-t',
        color: '#00d3d3'
      },
      {
        source: 45ccc16-4696-48aa-b69b-1529b03d880c,
        target: '9caccc16-4696-48aa-b69b-1529b03d880c'
      }
    ]
  }

Expected behavior
My hopes was that I could use viewGenerator or some other method to force the calculator to use my x and y coordinates for the timeLabel nodes.
Environment:

OS: Mac v10.10.5
Browser: chrome v76.0.3809.132
Node version: v10.3.0
react-d3-graph: version 2.1.0
d3 version: 5.11.0
react version: 16.7.0

Additional context
This isn't so much bug as it is a question about the limitations of the library. (Potentially a feature request). My purpose is to create a timeline with where the date nodes will have a corresponding event node. and from there event nodes can branch off like a regular web.

Hi, @jalite1991 could you please use the bug report template and provide more detail? Also, some code examples would be great so that we can see exactly what's not working in your integration.

Sorry about that.
Description
I am trying create a tree like web where there are special nodes that go straight down like a timeline. and branch nodes that stem from those node nodes. So would like to keep the default functionality where branch nodes x and y coordinates are calculated, but those special nodes always need to have same value returned as their x coordinate. Y can increment based whatever value.
To Reproduce
I am using default graph settings but passing in default x and y for time nodes.
  data: {
    nodes: [
      {
        id: '02af27e0-34f1-4381-bc19-85f525a54f94',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 1',
      },
      {
        nodeType: 'timeLabel--case',
        id: '02af27e0-34f1-4381-bc19-85f525a54f94-t',
        name: '2019-08-30',
        x: 400,
        y: 120
      },
      {
        id: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 2',
      },
      {
        nodeType: 'timeLabel--case',
        id: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        name: '2019-08-26',
        x: 400,
        y: 240
      },
      {
        id: '7ea1661a-504c-44c7-8cc9-9a809ce59d84',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 3',
      },
      {
        nodeType: 'timeLabel--case',
        id: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        name: '2019-08-22',
        x: 400,
        y: 360
      },
      {
        id: '9caccc16-4696-48aa-b69b-1529b03d880c',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 4',
      },
      {
        id: '45ccc16-4696-48aa-b69b-1529b03d880c',
        nodeType: 'node--case',
        updatable: true,
        name: 'Title 5',
      },
      {
        nodeType: 'timeLabel--case',
        id: '9caccc16-4696-48aa-b69b-1529b03d880c-t',
        name: '2019-02-21',
        x: 400,
        y: 480
      }
    ],
    links: [
      {
        source: '02af27e0-34f1-4381-bc19-85f525a54f94-t',
        target: '02af27e0-34f1-4381-bc19-85f525a54f94'
      },
      {
        source: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        target: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48'
      },
      {
        source: '02af27e0-34f1-4381-bc19-85f525a54f94-t',
        target: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        color: '#00d3d3'
      },
      {
        source: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        target: '7ea1661a-504c-44c7-8cc9-9a809ce59d84'
      },
      {
        source: 'ef9ea598-6ed6-4e12-a864-f3a414b90a48-t',
        target: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        color: '#00d3d3'
      },
      {
        source: '9caccc16-4696-48aa-b69b-1529b03d880c-t',
        target: '9caccc16-4696-48aa-b69b-1529b03d880c'
      },
      {
        source: '7ea1661a-504c-44c7-8cc9-9a809ce59d84-t',
        target: '9caccc16-4696-48aa-b69b-1529b03d880c-t',
        color: '#00d3d3'
      },
      {
        source: 45ccc16-4696-48aa-b69b-1529b03d880c,
        target: '9caccc16-4696-48aa-b69b-1529b03d880c'
      }
    ]
  }

Expected behavior
My hopes was that I could use viewGenerator or some other method to force the calculator to use my x and y coordinates for the timeLabel nodes.
Environment:

OS: Mac v10.10.5
Browser: chrome v76.0.3809.132
Node version: v10.3.0
react-d3-graph: version 2.1.0
d3 version: 5.11.0
react version: 16.7.0

Additional context
This isn't so much bug as it is a question about the limitations of the library. (Potentially a feature request). My purpose is to create a timeline with where the date nodes will have a corresponding event node. and from there event nodes can branch off like a regular web.

Hi, @jalite1991 thanks for the more detailed report. Now I understand what you're trying to achieve. Unfortunately, you cannot give coordinates to some nodes and leave other nodes without coordinates.  I would first recommend you to use staticGraphWithDragAndDrop property, you can read in the docs about it, and then you would need to provide coordinates to all the nodes, not only the ones you need to keep in the timeline.
Btw, node.viewGenerator it's something else entirely, it basically allows you to provide a custom render method for your node, you can still, of course, have custom x and y props being pass down alongside with that custom node, but it won't fix your problem.

@jalite1991 any workaround for this? Did you manage to achieve the behavior you intended?

@danielcaldas I had to turn on the staticGraph to true and try to place the x/y coordinates myself. It works but it is not achieving the desired function since I am having trouble adding new nodes, and rearranging old nodes to accommodate the new node positions.
I am trying to figure out a way onComponentUpdate to recreate the graph with the new node positions without unmounting it first. Any suggestions?

FYI if you want to be able to still drag&drop nodes around you can use staticGraphWithDragAndDrop.
Your strategy seems reasonable. You just need to make sure that whenever you add new nodes you do not create new references of new values for the existent nodes, you need instead to just fine tupe the positions of existent nodes. In theory, it looks that it might be exactly what you're looking for.

Awesome. Thank you.
Do you think this is a plausible feature request. The ability to set certain nodes to specific x,y value and having the other nodes be calculated around them.

Hey @jalite1991 do you mean something like this https://github.com/danielcaldas/react-d3-graph/issues/208?

That's pretty close to the idea

@jalite1991 As I mentioned, I don't have the current time to look into this in detail, it's a feature that react-d3-graph does not support out of the box, but it could be extended in that way. I'll tag it as a feature request, PRs are always welcome.

Hi, @jalite1991 thanks for the more detailed report. Now I understand what you're trying to achieve. Unfortunately, you cannot give coordinates to some nodes and leave other nodes without coordinates. I would first recommend you to use staticGraphWithDragAndDrop property, you can read in the docs about it, and then you would need to provide coordinates to all the nodes, not only the ones you need to keep in the timeline.
Btw, node.viewGenerator it's something else entirely, it basically allows you to provide a custom render method for your node, you can still, of course, have custom x and y props being pass down alongside with that custom node, but it won't fix your problem.

So glad I ran across this. I was facing the same issue of statically placing nodes in a hierarchical structure. Never occurred to me to calculate the offsets myself before rendering. It would be nice to have a setting where we could define groupings of nodes and levels so that we could dynamically generate a hierarchical structure.


The bottom border and persistence on history browser after action

Could be joined together with #1499

When I don't have anything in history, probably hide the button at all?
https://github.com/kodadot/nft-gallery/pull/1488#issuecomment-992373361

the bottom border should be fixed?

I would preserve dialog once remove button is clicked as user might want to remove more than one from browsing history, like 2-3 and don't want to open dialog each time.

https://user-images.githubusercontent.com/5887929/145807133-f646dab0-5d8b-44eb-9a31-76c2064be451.mov
Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/pull/1488#issuecomment-992389018

On it. Sorry about the weird headline issue if nothing is in history.


DerivedCR deletion webhook

What this PR does / why we need it:
This fixes the bug similar to https://github.com/kubermatic/kubecarrier/issues/280 for the DerivedCR. It forbids the derivedCR deletion if any derived CRD instances are present since it would lead to concurrent elevator deployment deletion (which is the only one owning the finalizers on the derived CRD instances) making it unable to ever delete the derived CRD nor its created instances.
To better achieve this goal the following changes are also present in this PR:

DerivedCustromResouce .status.derivedCR the field is now an object reference, as it should have been in the first place
manager is using clusterRoleAggregation
upon creating elevator a clusterRole is created for the manager, is included in its clusterRoleAggregation
derivedCR integration test is simplified (there's no need having CatalogEntry thrown in there, it's testing DerivedCustomResource, the catalog is tested heavily in other integration/e2e tests)

NONE

/retest

/unhold


Support for INSERT ... RETURNING

We support INSERT ... RETURNING for the following databases:

H2
MariaDB
PostgreSQL

simple example
To use INSERT ... RETURNING, invoke the returning function:
Kotlin code:
val a = Meta.address
val address = Address(16, "STREET 16", 0)
val address2: Address = db.runQuery { QueryDsl.insert(a).single(address).returning() }

generated SQL:
-- H2
select address_id, street, version from final table (insert into address (address_id, street, version) values (?, ?, ?))

-- MariaDB
insert into address (address_id, street, version) values (?, ?, ?) returning address_id, street, version

-- PostgreSQL
insert into address (address_id, street, version) values (?, ?, ?) returning address_id, street, version

another examples
You can combine returning and onDuplicateKeyUpdate.
val d = Meta.department
val department = Department(5, 50, "PLANNING", "TOKYO", 0)
val query = QueryDsl.insert(d).onDuplicateKeyUpdate().single(department).returning()
val department2: Department = db.runQuery { query }

You can also use multiple instead of single to process multiple records.
val a = Meta.address
val addressList = listOf(
    Address(16, "STREET 16", 0),
    Address(17, "STREET 17", 0),
    Address(18, "STREET 18", 0),
)
val addressList2: List<Address> = db.runQuery { QueryDsl.insert(a).multiple(addressList).returning() }

Does it support returning specific fields (a subset of those in the entity)?

Does it support returning specific fields (a subset of those in the entity)?

It has not been implemented yet, but we would like to consider it.

A common thing is to return an id after an insert... to return the whole record could be a waste.

A common thing is to return an id after an insert... to return the whole record could be a waste.

In that case, there is no need to use INSERT ... RETURNING. As for the generated ID, we have already set it in the entity that is obtained in the return value.
entity class:
@KomapperEntity
data class Person(@KomapperId @KomapperAutoIncrement val id: Int = 0, val name: String)

query execution:
val p = Meta.person
val person = db.runQuery { QueryDsl.insert(p).single(Person(name = "ABC")) }
assertNotEqual(0, person.id) // The generated id value is obtained from database after inserting

That returns the WHOLE person object (and issues a SELECT after the INSERT?), whereas in lots of cases, all I need is the new ID created and I don't want to have to send a SELECT after the INSERT to get it...

That returns the WHOLE person object (and issues a SELECT after the INSERT?

No.
Both JDBC and R2DBC provide APIs for retrieving generated IDs:

https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/Statement.html#getGeneratedKeys()
https://r2dbc.io/spec/1.0.0.RELEASE/api/io/r2dbc/spi/Statement.html#returnGeneratedValues-java.lang.String...-

Komapper uses these APIs.

Now we support returning specific fields:
val a = Meta.address
val address = Address(16, "STREET 16", 0)
val result: Pair<Int, String> = db.runQuery {
    QueryDsl.insert(a).single(address).returning(a.addressId, a.street)
}

Thanks :+1: !


Improve "Signature" styling and allow for multiple signatures on one page

From issue #13 https://github.com/budparr/gohugo-theme/issues/13#issuecomment-298066907

Okay, and while looking at the signatures, noticed that when @moorereason added more than one signature, they aren't separated by a line break, for example:

https://hugodocs-170426.netlify.com/functions/index-function/

[ ] Make type size consistent with body copy
[ ] test for and create separate instances of signatures
[ ] consider putting a heading over the signatures (one heading for all signature instances.

My simple partial for multiple sigs is in https://github.com/rdwatters/hugo-docs-concept/blob/master/themes/hugo-docs-concept/layouts/partials/functions-signature.html

Thanks!


accountsReducer [nfc]: Followups on handling restart events

These are some small tweaks in the handy new restart-event implementation added in #4707.

LGTM, thanks! Merged.


windows 10 can't run the solutions. Requires Windows 8.1

I updated some of the tutorials from this repository. They are working on Visual Studio 2019 as of today August 2021. I also created the step-wise tutorials.
The link to the repository
Cheers,


az webapp deploy with zip does not overwrite new static files

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

az --version
azure-cli                         2.47.0
core                              2.47.0
telemetry                          1.0.8
Dependencies:
msal                              1.20.0
azure-mgmt-resource               22.0.0
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\abc\.azure\cliextensions'
Python (Windows) 3.10.10 (tags/v3.10.10:aad5f6a, Feb  7 2023, 17:05:00) [MSC v.1929 32 bit (Intel)]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.

Related command

az webapp deploy --resource-group ${{ parameters.azResourceGroup }} --name app-${{ parameters.projectName }}-webapp-${{ parameters.envName }} --src-path ${{ parameters.webAppDeployPackageFilePath }} --type zip

Describe the bug
We have an ASP.NET application that contains static files. We use the standard .NET command for publishing the application.
dotnet publish $(PUBLISH_PROJECT_PATH) --no-restore --configuration $(BUILD_TYPE) -o $(PUBLISH_PROJECT_TARGET_FOLDER_ZIP_SOURCE) --runtime $(DOTNET_RUNTIMES) --self-contained true

The raw files are then zipped via powershell.
The zip is uploaded as an artifact in Azure DevOps during the build and used in the release step via az webapp deploy.
Issue: The new CSS files are not delivered via app. After a longer debugging, we saw that there are still old files in the KUDU section of the App Service.
However, we can verify in the Artifact ZIP that definitely the new files are included.
So the exclusion procedure is that az webapp deploy does not write the new files to the Web App.
We have also tried the --clean true command with unfortunately the same result.
To Reproduce
See command
Expected behavior
Files should be updated.
Environment summary
Azure DevOps with Self Hosted Windows Agent

Thank you for opening this issue, we will look into it.

Found more info.

az webapp deploy says it succeeded
WebApp Deployment Center says it succeeded

But the logs say it failed
Copying file: 'WindowsBase.dll'
Copying file: 'af\Humanizer.resources.dll'
Error: EINVAL: invalid argument, open '/home/site/wwwroot/af\Humanizer.resources.dll'
An error has occurred during web site deployment.
Kudu Sync failed
\n/opt/Kudu/Scripts/starter.sh "/home/site/deployments/tools/deploy.sh"

Huge KUDU bug.
Looks like its again the issue it that kudu cannot handle zip files from Windows to a Linux App.
Exists for years for the "AzureWebApp@1" Task and no fix. Frustrating....

Hi @BenjaminAbt, this seems to be an issue with Powershell module used for creating the zip archive. It uses \ instead of / as separator which is causing issues during Kudu sync.
You can notice in your logs, the .dll path is a mix of / and \, which caused Error: EINVAL: invalid argument, open '/home/site/wwwroot/af\Humanizer.resources.dll'
I was able to repro this issue when creating zip archive with Powershell, but it works fine if I use other utility to create the zip archive.
Relevant powershell issue: https://github.com/PowerShell/Microsoft.PowerShell.Archive/issues/48


[Feature][UI] Fix Bug SQL and Python Editor Highlight not Work

Purpose of the pull request
This pull request fix  SQL and Python editor highlight not working

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #10753 (1af385a) into dev (4ac3349) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev   #10753   +/-   ##
=========================================
  Coverage     40.71%   40.71%
  Complexity     4820     4820
=========================================
  Files           900      900
  Lines         36143    36142    -1
  Branches       3982     3979    -3
=========================================
  Hits          14717    14717
+ Misses        19972    19971    -1
  Partials       1454     1454

Impacted Files
Coverage Δ

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac3349...1af385a. Read the comment docs.

Hi @vivostar Are you still interested in following up with this PR? Thanks : )

I think the issue has been resolved, so I will not work on this, thanks.


Updated CoreObject Examples

I just updated some examples.
PS: If you're curious why there are 14 random commits of me adding and removing files, it cause I was working on a different project in the same repo, and decided to scrap it. If you're even more curious, I was working on the Teams tutorial because it said that you needed in the Projects tab. I may continue that if it doesn't get done soon.

Nice, will take a look next week! If you want to remove those extra commits, git squashing is the way to do it.

Thank you and sorry that it took so long!


Index error in comprehension

There is a 500 error happening somewhere in the Comprehension module. The pod logs showed this:
prediction = self.model.predict(passage=str(X[0]), question=str(X[1]))['best_span_str'] IndexError: index 1 is out of bounds for axis 0 with size 1

I dealt with this error by checking to see if len(X) == 2. However, at this point X should always have a length of 2 (i.e., X[0] is the knowledge base article text, and X[1] is the original message/question). It seems like maybe the right meta and/or X isn't getting passed from KB-search to comprehension in some cases, or comprehension isn't parsing that correctly. Still need to follow up on that point.
(cc @shirishph)


Add types missing in girder_worker to support translation from slicer CLIs

Done through this pull request to girder_worker repo.


[flink][flink-cdc] Add FLOAT type adaptation to HAVE_SCALE_LIST

Purpose
Fixed the problem that when using cdc for data synchronization, when the field type of the data source is float, an exception message will appear during synchronization: just like … :java.lang.NumberFormatException: For input string: "10,2"
Tests
API and Format
Documentation

@JingsongLi  please review, thanks!

@JingsongLi  I'm. sorry, I overlooked the getScale method and it has been fixed


Consider restricting awskms:// options for admission control

I was looking at the AWS KMS options here: https://github.com/sigstore/cosign/blob/main/KMS.md#aws
There are soooo many ways of expressing the same key, but some of these forms only partially specify things and lean on the environment (e.g. AWS_REGION) and I don't think we should support these forms in ClusterImagePolicy.
I think we should require one of the form(s): awskms://[host]/{arn} where:

host is the optional endpoint, and
arn is either the key ARN or an alias ARN.

@hectorj2f @vaikas WDYT?

Yes, i am happy with restricting it. I also find it complex and we already had several bugs about it.


Multiple micro-ROS agents causes data loss

Issue template

Hardware description: Nvidia Jetson running ubuntu 20.04
RTOS: Teensy 4.0
Installation type: docker agent
Version or commit hash: foxy

Steps to reproduce the issue

I use the following commands to start up a micro-ROS agent (never gone deeper than this):
sudo docker run -it --rm -v /dev:/dev --privileged --net=host microros/micro-ros-agent:foxy serial --dev /dev/serial/by-id/<device-id> -v6 && export ROS_DOMAIN_ID=20
One device plugged in, one agent running, one device's data received normally
Two devices plugged in, one agent running, one device's data received normally
Two devices plugged in, two agents running, two device's data received intermittently & issue arises:
Expected behavior
Should be able to run multiple agents for multiple devices plugged in.
Actual behavior
There are occasional freezes to the incoming data, and these freezes are synchronised between the devices. We then also get an initial value which is far from the expected value (temperature, pressure etc.) see attached screenshots.
Additional information
I get the impression that multiple devices should be able to run off one micro-ROS agent, but can't find any guidance or examples on this. Can two agents running interfere with each other? Can the Jetson be CPU-overwhelmed by the overhead of running two agents? Is setting the DOMAIN_ID the same on two simultaneous agents a problem? Is there a simple way to modify the agent docker command above to listen to multiple devices?

Hi @Benblob688,
You can use the multiserial agent directly, avoiding multiple agent instances with unnecessary overhead:
sudo docker run -it --rm -v /dev:/dev --privileged --net=host microros/micro-ros-agent:foxy multiserial --devs "/dev/1 /dev/2 ..." -v6
Also, you dont need to set ROS_DOMAIN_ID on the Agent, this is configured on the micro-ROS client side.
In fact, a single Agent can handle communications on multiple domain IDs: Check this example link or this tutorial link

Hi @Acuadros95,
I used the command as you suggest, and the screenshot is below. It does find the devices but I don't get the rapid printout of a single connection, nor do the ros topics list. The agent stops at the initialisation stage. Interestingly, it did not care when I unplugged the devices. Nothing changed. I tried with and without the export ROS_DOMAIN_ID with no change, as you explained.

Interestingly, it did not care when I unplugged the devices
What do you mean with this? You can start the agent with the serial devices disconnected (The file is not present on /dev/...) and the Agent should wait for the connection.

Can you try that? Start the multiserial agent with both ports disconnected, then connect them one by one while checking the log.

I mean that on theserial version of the docker command, unplugging the devices would result in a server stopped and then repeated serial port not found messages every second.
In this case with multiserial version of the docker command, I can unplug the devices and no error codes occur, no print statements come out. For example, in the screenshot attached, I followed your request to start with none plugged in, then one, then both. I then unplugged both. The screenshot is taken with no devices attached, but it has not reverted back to the serial port not found behaviour that I expect to see.

in terms of the micro-ROS app, we haven't implemented it in this way, we followed this style: https://github.com/micro-ROS/micro_ros_arduino/blob/galactic/examples/micro-ros_publisher/micro-ros_publisher.ino
do you think this could be the cause of the multiserial command getting stuck on the Root.cpp step?

I could not replicate on our side using micro-ros_publisher.ino code and 2 Teensy 4.1.

Can you try with this exact example code?
Are you using v2.0.4-foxy release?
Also make sure you have the latest agent image: docker pull microros/micro-ros-agent:foxy
Can you run the image without sudo?

Any updates on this?

Closing, feel free to reopen if the problem is not solved.

It looks like select implementation differs between architectures: select() returned EINVAL errno for tv_usec >= 1 second values on a RPi, but this does not happen on my AMD laptop.
Regular serial agent works because it uses poll() instead of select(), avoiding this bug.
This PR should fix the problem: https://github.com/eProsima/Micro-XRCE-DDS-Agent/pull/311
Will update when the fixed ARM dockers are ready.

Dockers updated!
Run docker pull microros/micro-ros-agent:foxy and try again

Hello, I'm a novice, and I've been using multiple micro-ros recently. Can you share the following how you realize multiple micro-ros? I'd be very grateful. Thank you.

Hello, I'm a novice, and I've been using multiple micro-ros recently. Can you share the following how you realized multiple micro-ros, or provide some information? I'd be very grateful. Thank you.


Reload on create

Adding watcher.onDidCreate where it was just watcher.onDidChange fixes The PDF does not refresh #115 for me.
I didn't look into it deeply enough to see if both were needed or if just watcher.onDidCreate was sufficient, but this works for both cases.

Hey @lhl2617, anything else I can do here, to help get this merged?

Hey @lhl2617 It would be nice if we could get this merged.

I can confirm this is working. To test is locally, I just edited this file (on Mac) and reloaded VSCode:
~/.vscode/extensions/lhl2617.lilypond-pdf-preview-0.2.8/out/extension/pdf-preview.js

I've previously set a shortcut for go to pdf and with auto build on save looks like it will be the perfect possible workflow to me!
Please @lhl2617 do merge it whenever you can, and/or maybe consider adding someone as collaborator so they can merge pull requests (doc). Thanks everyone!

Maybe someone should fork the project. Unfortunately, the author no longer seems to be able to take care of the project. It would be a shame if the project were to become orphaned. Especially on the Mac, I don't know of any alternative that works as smoothly as VSLilyPond.

I am having issues with this. I added the onDidCreate lines into my pdf-preview.js file, restarted VSCode and it still does not auto refresh. Any ideas why that might be the case?

Anyone still having issues with this? I added the onDidCreate lines into my pdf-preview.js file, restarted VSCode and it still does not auto refresh. Any ideas why that might be the case?

Merge, please!


Make sure there is only one instance of dash-darksend thread

A trivial safety check - there should be no way to run this thread twice.

Merged, thanks!


Cannot load file

When music file name contains language specific characters (non ascii), app shows that it could not load file.
Example chars: ł, ą, ó, ś, ć

It's Windows, right?

Yes

I also have an issue related to file loading where certain files will resulting this error
free(): double free detected in tcache 2

I fixed the problem of loading the file: "Fix for issue #29: Change the Codepage of the process to UTF-8 #42". But in the UI the Unicode characters render as underscores.


[display] add udev rules for adding device targets

this can be used by other services as a dependency to make sure they have their necessary input devices available before starting.  this is just one way of approaching the problem (that input devices aren't available when remux is starting). alternatively, can make remux/genie die if the input device is unrecognized
STATUS: untested.

yes, please add them!

PS: this is addressing https://github.com/rmkit-dev/rmkit/issues/141 (adding crosslink so that post gets updated to)

Moved the udev rule to the toltec-bootstrap package as discussed on Discord.

i think remux needs to depend on toltec-bootstrap in order to get the udev rules installed and configured

i think remux needs to depend on toltec-bootstrap in order to get the udev rules installed and configured


Better compatibility for setup script

Signed-off-by: Kevin Cormier<EMAIL_ADDRESS>

/hold

/unhold


Tag Maker Job

We want to seperate the creation of the tags from the crawler.
The creation of the tags requirements are as follow:

Cron job that runs every 24 hours.
Re-compute the tags of a plan if the last update time of the plan is after the last update time of the tags of this plan.
Before re-computing the tags of a plan, remove all previous tags for this plan.
The creation of father tags are not needed as of now, but beware that we need to add that functionality later. (Make sure that it will be comfortable to add this functionality)
This code should sit in the cron directory. It should resemble the existing crons in its behavior.

Hi @TomerMe2 @muamichali Please update status of this task

Hi @TomerMe2 @muamichali Please update status of this task

We got the function that does this, but it needs a little touchups. It's the updatePlanTags function in controller/cron.js.
The function needs a filter for which plans to update, but other than that it's fine.
Someone needs to schedule it because we have no idea how.

@muamichali can you update here on the status? thank you 🔅

It's what @TomerMe2 said above, Tomer will take over adding it to a cron and calling it from there with an appropriate filter.


Vue + Bootstrap

This looks promising
http://yuche.github.io/vue-strap/#getting-started

I think we can close for now


adding jenkins directory

@aleccf0 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Please use your own fork for this.