Header does not work in MSVC C++

The header uses C style literals
(Vector2){1,2};
this is not valid C++ code, and won't compile in MSVC's C++ compiler.
If this file is intended for C only, it should have a #define error if cpp is defined.
if it is intended to work in C and C++ on all compilers, it should not use the C style code, and define specific variables.

No that does not fix it, you still have tons of places that use c literals.
Search the code for '){'
there are a bunch of them left.

@JeffM2501 Sorry for the rush, they should all be replaced now, and I also fixed the warnings received with -Wall (https://github.com/Bigfoot71/rlights/commit/954edb12f1b0fa41947fa1e597aa91452f9f0759 - https://github.com/Bigfoot71/rlights/commit/7461a7b829f9213e9aa602ed35752b99a200ab7a)

Better, but designated initializers require C++20

@JeffM2501 I don't think I've seen other similar cases in the code, this case is fixed (https://github.com/Bigfoot71/rlights/commit/ac15b97ad70182f2749918b7278da45843044f1e)
I compiled with g++ ... -std=c++11 and g++ ... -std=c++17 without any error or warning on my side

@JeffM2501 Was it good on your side?


@xstate/test state.invoke is not called

Description
state.invoke is not called when the state machine is tested using @xstate/test
Expected Result
state.invoke is called when a state machine is tested using @xstate/test package
Actual Result
Services should be invoked when testing the state machine. There are cases where async operations need to be performed as part of the tests, when @xstate/test is used for running e2e tests of real applications. Mocking the data defeats the purpose here, it would be nice to be able to call such services by using the invoke api provided in the docs.
Reproduction

Codesandbox repro link

Additional context

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Repro code
const { Machine: createMachine } = require("xstate");
const { createModel } = require("@xstate/test");

const machine = createMachine({
  id: "toggle",
  initial: "inactive",
  states: {
    inactive: {
      invoke: {
        id: "callMe",
        src: (context, event) => {
          return new Promise((resolve) => {
            console.log("I am not being called");
            resolve();
          });
        }
      },
      on: { TOGGLE: "active" }
    },
    active: {
      on: { TOGGLE: "inactive" }
    }
  }
});

const model = createModel(machine).withEvents({
  TOGGLE: {}
});

const execute = async (plans) => {
  plans.forEach((plan) => {
    console.log(plan.description);

    plan.paths.forEach(async (path) => {
      console.log("    " + path.description);

      await path.test({ ctx: "foo" });
    });
  });
};

(async function () {
  await execute(model.getSimplePathPlans());
})();

Console.log generated by the repro code
reaches state: "#toggle.inactive"
    via
reaches state: "#toggle.active"
    via TOGGLE

@davidkpiano Since the issue has been marked as an enhancement, I'm wondering if there are any other features of the state machines that are not working while using machines to drive e2e tests. I didn't find in the docs a place where this is explained, am I missing something obvious here?

@dalwlad I'm working on this as part of the next version of @xstate/test https://github.com/statelyai/xstate/pull/3036/commits/4e2be879a289c8914ba36dcd05d5d402bac45516

Actually, marking this as a wontfix, since machines used for testing (in model-based testing scenarios) differ than using @xstate/test to test actual machines.
The machine model used for MBT should be a statechart that represents states and transitions in your app in a pure sense, without executing any side-effects of its own. For example, if you're testing a page loading data, you would not model that as an invoke in the statechart modeling your app. Instead, you should model that as a loading state that might have something like a data.loaded event, where the execution of that event is awaiting something to appear on screen that indicates that the data has loaded.
To test invocations in machines, you should use one of the strategies listed here: https://xstate.js.org/docs/guides/testing.html#testing-services

Actually, marking this as a wontfix, since machines used for testing (in model-based testing scenarios) differ than using @xstate/test to test actual machines.
The machine model used for MBT should be a statechart that represents states and transitions in your app in a pure sense, without executing any side-effects of its own. For example, if you're testing a page loading data, you would not model that as an invoke in the statechart modeling your app. Instead, you should model that as a loading state that might have something like a data.loaded event, where the execution of that event is awaiting something to appear on screen that indicates that the data has loaded.
To test invocations in machines, you should use one of the strategies listed here: https://xstate.js.org/docs/guides/testing.html#testing-services

I was hoping to be able to use the same machine for testing as well. This makes it hard as I will have to recreate each machine I have in order to test it.
Also If I make modifications to my machine that wont make my tests fail. I have to maintain the test machine and ensure they operate in a similar logic.
Is there any work around to make the machine work with a test model as well?

@nullbytesoftware Can you post this as a discussion in https://github.com/statelyai/xstate/discussions/new ?


Missing Stripe POD

Describe the bug
A clear and concise description of what the bug is.
The Stripe Pod is missing from the list of pods to install.
To Reproduce
Steps to reproduce the behavior:
Install the plugin, build the app, and then do npx cap sync
Expected behavior
A clear and concise description of what you expected to happen.
The plugin should include the Stripe Pod by putting its reference into the Podfile
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: iOS
Version Latest

Smartphone (please complete the following information):

Device:  [iPhone X]
OS: Latest

Additional context
Here is the error
[error] Error running update: Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "Stripe":
In Podfile:
CapacitorCommunityStripe (from ../../node_modules/@capacitor-community/stripe) was resolved to 0.0.1, which depends on
Stripe (= 21.0.1)

I was able to fix the issue by removing the dependency version on the podspec file and then placing  pod 'Stripe', '~> 21.0.1' in both targets in the podfile

I was able to fix the issue by removing the dependency version on the podspec file and then placing  pod 'Stripe', '~> 21.0.1' in both targets in the podfile

Thanks for issue!
Today this plugin of v3 is released. This not compatible with v1. All APIs have been revamped. So I will close this issue. If you still have the same problem, please create a new Issue. Thank you.


How can i use name function with url-loader?

Operating System:
Node Version:  v10.15.3
NPM Version: 6.4.1
webpack Version: 4.28.4
url-loader Version: 0.6.2

Feature Proposal
Feature Use Case
file-loader screenshot:

url-loader screenshot:
name function not work.

How can i use name function with url-loader?
thank you!

Please use stackoverflow or gitter for questions, i don't know what is boilerplates you are use, open issue in your boilerplate


NO-ISSUE: Adding validation to IBI create iso flags in order to minimize user errors

NO-ISSUE: Adding validation to IBI create iso flags in order to minimize user errorsAdding description to ibi create iso flags

Background / Context
in order to minimize user input issues we need to add validation to ibi create iso command

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

/test ibi-e2e-flow

/approve

/lgtm


Add an example for non-encrypted packet format on send/recv

An example will be nice, although it is quite clear what you mean there

@borisPis would you willing to propose a PR? I'm not exactly sure what kind of format you'd want for an example.


Help suffix space

Normalize the log for docker subcommand usage, delete the trailing space at the end of option.
Add checking for for suffix of option in each line of help, to make sure no extra space in it.

hmm, it looks like you moved it, I wanted it in both places  :-)

@duglin sorry for careless, remodified it again.

@zenlinTechnofreak thanks
LGTM
/cc @tiborvass

LGTM


[WFRP4e System] bug

We are playing WHFB. There is a problem with checking concentration of wizards. If the spell is not memorized by the character, then the set of successes does not increase.
For example:
a spell requires 12 successes(if the spell is not memorized);
a spell requires 12 successes(when it is memorized).
However, when performing a check, there is a threshold of 6 successes maximum, no higher is added. In both cases.
From: Grinpis#9194foundry: 11.307wfrp4e: 6.6.1wfrp4e-core: 3.1.6Active Modules: babele, dice-calculator, dice-so-nice, lib-wrapper, ru-ru, wfrp4e-character-details

Non reproducible, CN is halved as expected, and user can't be contacted.

the number of successes on the check does not match to the number of the CN creation (when the spell is not remembered)

or

Ok I think I understand now


[TypeScript Resolvers] Apollo Server resolvers types mismatch

I use typed resolvers generation and define my resolvers like:
import { QueryResolvers, MutationResolvers, SubscriptionResolvers, User } from './generated/graphql'

const query: QueryResolvers.Resolvers = {
  allUsers: (root, args, ctx) => {
    const result: User[] = []
    return result
  }
}

const mutation: MutationResolvers.Resolvers = {
  signup: (root, args, ctx) => {
    const res = ctx.gql.mutation.createUser({
      input: {
        user: {
          firstName: 'John Doe'
        }
      }
    })
    const result: User = { firstname: 'asdf', lastname: 'asdfasdf' }
    return result
  }
}

export default {
  mutation,
  query
}

When it comes to configure apollo-server like this:
import resolvers from './app/resolvers'

const server = new ApolloServer({
      typeDefs,
      resolvers,
      mocks: true,
      context: (c: any) => ({
        ...c,
        orm: connection,
        gql: postgraphileConnection
      })
    })

then apollo-server gives an error about types mismatch:
Type '{ mutation: Resolvers<GqlContext, {}>; query: Resolvers<GqlContext, {}>; }' is not assignable to type 'IResolvers<any, any>'.
  Property 'mutation' is incompatible with index signature.
    Type 'Resolvers<GqlContext, {}>' is not assignable to type '(() => any) | GraphQLScalarType | IEnumResolver | IResolverObject<any, any> | IResolverOptions<any, any>'.
      Type 'Resolvers<GqlContext, {}>' is not assignable to type 'IResolverObject<any, any>'.
        Index signature is missing in type 'Resolvers<GqlContext, {}>'.ts(2322)

types.d.ts(28, 5): The expected type comes from property 'resolvers' which is declared here on type 'Config & { cors?: boolean | CorsOptions; }'

What should be done in order to solve it?

Fixed in 0.18.0 🎉

Hello, I am not sure if relevant to this issue, but I am getting this error:

I am using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@panzelva it was fixed in the recent refactor, and it will be available soon in 1.0.0.

I am still getting this issue with v1.0.0.
My resolvers:
import { IResolvers } from '../generated/graphql'
import { GameServer } from './GameServer'
import { Mutation } from './Mutation'
import { Query } from './Query'
import { User } from './User'

const resolvers: IResolvers = {
  GameServer,
  Mutation,
  Query,
  User,
}

export default resolvers

export interface IApolloContext {
  prisma: Prisma
}

const apolloServer = new ApolloServer({
  context: {
    prisma: new Prisma(),
  },
  resolvers,
  typeDefs: parse(importSchema(path.join(__dirname, '../schema.graphql'))),
})

Error:

(property) Config.resolvers?: IResolvers<any, any> | undefined
Type 'IResolvers' is not assignable to type 'IResolvers<any, any>'.
Property 'GameServer' is incompatible with index signature.
Type 'GameServerResolvers<IApolloContext, GameServer> | undefined' is not assignable to type '(() => any) | GraphQLScalarType | IEnumResolver | IResolverObject<any, any, any> | IResolverOptions<any, any, any>'.
Type 'undefined' is not assignable to type '(() => any) | GraphQLScalarType | IEnumResolver | IResolverObject<any, any, any> | IResolverOptions<any, any, any>'.ts(2322)
types.d.ts(30, 5): The expected type comes from property 'resolvers' which is declared here on type 'Config'

It's hidden behind a flag because you type safety is less strict then.
Try useIndexSignatures: true

That's it! No more problems using useIndexSignature: true (notice that there is no 's' at the end).

@kamilkisiela would you mind editing your comment to remove the s? (and thanks @P4sca1 )

I am getting Index signature is missing in type 'Resolvers'. I tried using useIndexSignature: true after reading through the comments, but the problem persists.
TSError: ⨯ Unable to compile TypeScript:
src/index.ts:29:5 - error TS2322: Type 'Resolvers' is not assignable to type 'IResolvers<any, any> | IResolvers<any, any>[] | undefined'.
  Type 'Resolvers' is not assignable to type 'IResolvers<any, any>'.
    Index signature is missing in type 'Resolvers'.

I am using programmatic usage. What should I do?

@ankitjena which version do you use?
It seems like your configuration is valid, the useIndexSignature: true should make it compatible with Apollo server.

For anyone else who lands here and useIndexSignature: true isn't working — you have to kill the codegen server and restart it. The config hot reload doesn't work for this.

For anyone wondering where to put the useIndexSignature: true, my codegen.yml looks like this (see the last 2 lines):
overwrite: true
schema: "src/schema.graphql"
documents: null
generates:
  src/generated/graphql.ts:
    plugins:
      - "typescript"
      - "typescript-resolvers"
    config:
      useIndexSignature: true

I literally spent an entire day on this problem. I wish things like this would be mentioned in README, something about known issues.

@dzmitry-kankalovich would you mind having a go at a PR that would make it easier for the next to follow?

@dzmitry-kankalovich It's documented in our docs website, you can even find it easily in the search:

And there is a section for integration with Apollo Server: https://graphql-code-generator.com/docs/plugins/typescript-resolvers#integration-with-apollo-server
This is not a "known issue", because the resolver signature is agnostic to any GraphQL platform. If you wish to have it running with Apollo Server, you'll need to add the flag, because Apollo-Server expects a different signature than plain graphql.js.

@dotansimha You are absolutely right, it's there, and I've overlooked it. I am a newbie to TS and the index signature keywords were not catching my attention TBH.
I guess my larger problem was that I falsely expected it to "just work", considering that JS + Apollo is probably the most common starting point for a new GraphQL development - which is not really a problem of the codegen, but rather of Apollo.
I may suggest dropping a code snippet to that section, so it's just a bit more eye-catchy. Or maybe rephrase the doc like By default Apollo Server will not work with generated Resolver interface....
Thanks!

@dzmitry-kankalovich well, it definitely fixed an issue for me, but this hack kills type safety...

@dzmitry-kankalovich well, it definitely fixed an issue for me, but this hack highlights incorrect types for ApolloServer resolvers.

Can you please share more details? The main issue here is the fact that Apollo-server signature expects a general type with index signature, while codegen can generate the exact named types and fields based on the schema. Then, a mismatch happens because the type provided by codegen does not match exactly to the open signature of Apollo-Server.
As suggested above, using useIndexSignature: true, noSchemaStitching: true will make sure to create slim TS signature (without schema stitching resolvers) and with the index signature that Apollo-Server expects, and this should work without casting to any.
If that doesn't work for you, can you please report a new issue with a reproduction and an example? Thank you!

@dotansimha I have generated resolvers types as recommended, and now I have diffrent errors in resolvers.
Basically in some cases types forcing me to make resolvers of dictionary/Record/object type, where each field is resolver async (parent, args, context, info) => value, and errors out if I want to use async function (args, context, info) directly.
In other cases it accepts async function without errors, and I have no idea why.
Originally schema.json is generated from old Rubi graphql api.

@JustFly1984 async function (args, context, info) is not a valid resolver signature for GraphQL-js. I didn't understand the use-case. Could you give more details, maybe an example CodeSandbox in a different issue?

@ardatan basically I have next query structure:
query {
  page(id: ID) {
    id
    type
    title
 	item(id: ID) {
 		id
		content
        type
 	}
  }
}

resolver page:
import { item as itemResolver } from './item-resolver'

export async function page(parent: void, args, context, info): Promise<Page> {
  const { id, type, title } = await context.models.Pages....
  return {
    id,
    type,
    title,
    // Here it complains on function, and requires plain object
  	item: itemResolver,
  }
}

item-resolver:
export async function item(parent: Page, context, info): Promise<Item> {
  const { id, type, content } = await context.models.Items....
  return { id, type, content }
}

resolvers:
import { page } from './page'
import { item } from './item'

export const resolvers: Resolvers<ResolversContext> = {
  Page: page,
  // Here it complains on function,
  // and requires an object with some props as resolver function type
  // {
  //.   id: (parent: Item, context, info) => id,
  //.   type: (parent: Item, context, info) => 'Item',
  //.   content: 'Item Content'
  //  }
  // and others simple types.
  Item: item,

I do not understand why parent type is Item, and how should I get Args as it is described in query type.

As I asked above, if anyone has an issue, please create a new issue with a clear minimal production on CodeSandbox. I'm locking this issue because this issue is pretty old.
@JustFly1984 I don't think resolvers can be like that;
https://www.graphql-tools.com/docs/resolvers


Animixplay - Error Getting Links

Source information and language
Animixplay 13.13 (English)
Steps to reproduce

Choose any episode of any anime.
Press play button.
Video cannot be played.
Error message popup, "Error getting links"

Expected behavior
It should play the video as usual.
Actual behavior
The app plays the video normally without any issues before this.
Aniyomi version
<IP_ADDRESS>
Android version
Android 12
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.13.5.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

I think website internal player are unavailable , they said it will fix automatically and also they are working on what they do to fix that, They already mentioned that in their discord(Anime discord not Aniyomi) and it's not related to Aniyomi .
I'm not a dev hope it help

Oh I see. Thank you for the information. Have a good day to you!

I think website internal player are unavailable , they said it will fix automatically and also they are working on what they do to fix that, They already mentioned that in their discord(Anime discord not Aniyomi) and it's not related to Aniyomi . I'm not a dev hope it help

Now It's gone forever. This is sad.

Yup it kinda sad to know that they don't return, There a fake scrapper of animixplay, i don't know would they add that as an extension or not.


Added a proper homepage with link to documentation.

In this PR, I created an homepage for the Corbado's React Passkeys example, also styled the homepage.
This is to give the user some information and a link to the documentation, as well as not to make the example look boring.


No eplusout.csv in the output file, thus cannot use monitoring function

Hi, I run the simulation till the step function returns DONE=True, and got a list of outputs but without eplusout.csv.

The environment is the manually installed energyplus 9.5.0 on MacOS with an M1 chip. But when I run exactly the same code in a Linux docker the eplusout.csv shows.
Is it possible to fix this issue by working around the code? Or do I have to switch to docker instead?

Hi @DDDOH, there should be no difference in code executed inside and outside a container: EnergyPlus is called with -r which invokes transformation of .eso to the expected .csv. It happens at the very end of the execution of the simulation (hence end of episode) and it’s tackled by a different binary (ReadVarsESO). Could you try to rerun for 2 complete episodes and check the output folder of the first one? If eplusout.csv is still missing please share the logs of the execution.

Thanks for your reply. I tried run the code in the docker environment and the issue is resolved. The missing .csv may related to the MacOS M1 version Energyplus.


Add examples dir

We need to create an examples directory to add sample code.
ref: https://github.com/aws/aws-sdk-java/tree/master/src/samples

Adding test code to LitmusClient does the same thing as above.


The writing

you could rewrite in portuguese not only in english.

Would you be interested in translating the current English version into Portuguese?

Better to translate it in bigger languages like French or Spanish. But your idea is really good. Well I'm not a contributor so I can't do anything...


no coverage for terminated processes

The following example won't give me coverage for the process
import time
import unittest
import multiprocessing

def target():
    a = 1
    while a < 10:
        time.sleep(0.1)
        a += 1
    return a

def spawn():
    process = multiprocessing.Process(target=target)
    process.start()
    return process

class TestAsdf(unittest.TestCase):
    def tearDown(self):
        self.p.terminate()

    def test_asdf(self):
        self.p = spawn()

if __name__ == "__main__":
    unittest.main()

[run]
source = tests/testcases/
concurrency = multiprocessing

coverage run tests/testcases/asdf.py && coverage combine && coverage report -m
.
----------------------------------------------------------------------
Ran 1 test in 0.001s

OK
Name                             Stmts   Miss  Cover   Missing
--------------------------------------------------------------
tests/testcases/__init__.py          0      0   100%
tests/testcases/asdf.py             20      5    75%   7-11

However, when removing the tearDown function, it catches it:
Name                             Stmts   Miss  Cover   Missing
--------------------------------------------------------------
tests/testcases/__init__.py          0      0   100%
tests/testcases/asdf.py             18      0   100%

-- sys -------------------------------------------------------
                        version: 5.3
                       coverage: /usr/lib/python3.8/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: /mnt/data/Code/setxkbmap-gtk/.coveragerc
                   configs_read: /mnt/data/Code/setxkbmap-gtk/.coveragerc
                    config_file: /mnt/data/Code/setxkbmap-gtk/.coveragerc
                config_contents: b'[run]\nsource = tests/testcases/\nconcurrency = multiprocessing\n'
                      data_file: -none-
                         python: 3.8.5 (default, Sep  5 2020, 10:50:12) [GCC 10.2.0]
                       platform: Linux-5.4.72-1-MANJARO-x86_64-with-glibc2.2.5
                 implementation: CPython
                     executable: /usr/bin/python
                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 7240
                            cwd: /mnt/data/Code/setxkbmap-gtk
                           path: /usr/bin
                                 /usr/lib/python38.zip
                                 /usr/lib/python3.8
                                 /usr/lib/python3.8/lib-dynload
                                 /home/mango/.local/lib/python3.8/site-packages
                                 /usr/lib/python3.8/site-packages
                                 /usr/lib/python3.8/site-packages/evdev-1.3.0-py3.8-linux-x86_64.egg
                                 /usr/lib/python3.8/site-packages/coverage_badge-1.0.1-py3.8.egg
                                 /usr/lib/python3.8/site-packages/dbus_python-1.2.16-py3.8-linux-x86_64.egg
                                 /mnt/data/Code/setxkbmap-gtk
                    environment: COVERAGE_PROCESS_START = .coveragerc
                                 COVERAGE_RCFILE = /mnt/data/Code/setxkbmap-gtk/.coveragerc
                   command_line: /usr/bin/coverage debug sys
                sqlite3_version: 2.6.0
         sqlite3_sqlite_version: 3.33.0
             sqlite3_temp_store: 0
        sqlite3_compile_options: COMPILER=gcc-10.2.0
                                 ENABLE_COLUMN_METADATA
                                 ENABLE_DBSTAT_VTAB
                                 ENABLE_FTS3
                                 ENABLE_FTS3_TOKENIZER
                                 ENABLE_FTS4
                                 ENABLE_FTS5
                                 ENABLE_JSON1
                                 ENABLE_RTREE
                                 ENABLE_UNLOCK_NOTIFY
                                 HAVE_ISNAN
                                 MAX_EXPR_DEPTH=10000
                                 MAX_VARIABLE_NUMBER=250000
                                 SECURE_DELETE
                                 TEMP_STORE=1
                                 THREADSAFE=1

is it because this never happens: https://github.com/nedbat/coveragepy/blob/7f8dd68dd6da360374603f3a352c07713a3b082d/coverage/multiproc.py#L51 ?

problem was probably because the process was killed before it even started. this works:
class TestAsdf(unittest.TestCase):
    def tearDown(self):
        self.p.terminate()

    def test_asdf(self):
        self.p = k()
        time.sleep(0.4)


Create CollabW22 Hack Day Presentation

@decbays is working on this using google presentation to allow easier linking/sharing.

First 3 slides will be talked through by @FlicAnderson , next 2 will be @shermanlo77, then hand over to @jsteyn for product demo with screensharing.


BanHTTP Tests do not work on various platforms

My CL was reverted with a5611cdda2088ed6dc0aab9c9ae65d3cbe926537 because tests are timing out on Windows. I don't have a Windows development machine (yet) so I am not sure how to make them pass. This is a placeholder issue to discuss with @sortie and figure out what to do next.
My current theory is that:
  final server = await HttpServer.bind(Platform.localHostname, 0);
  final uri = Uri(scheme: 'http', host: Platform.localHostname, port: server.port);
  await asyncTest(() => httpClient.getUrl(uri));

does not work on Windows due to use of localHostname. If other HTTP tests are passing, it could be because they all use localhost or loopback addresses. I cannot use these to test this functionality since loopback addresses are always allowed.
Several ideas come to mind:

Disallow loopback based on an environment flag. [Not preferred since it reduces coverage and increases complexity]
Disable tests on windows. There's no platform specific code in that CL.
Figure out a way to allow binding to the host name rather than localhost. [Preferred]

The tests failed on AOT Android tests as well.
This is a bigger mystery since the test is failing with SocketException when I try to ban HTTPS via a zone variable:
  asyncExpectThrows(
      () async => await runZoned(() => httpClient.getUrl(uri),
          zoneValues: {#dart.library.io.allow_http: false}),
      (e) => e is StateError);

Same in the embedder test:
// Passes
  asyncExpectThrows(
      () async => await httpClient.getUrl(httpUri), (e) => e is StateError);
// Passes
  asyncExpectThrows(
      () async => await runZoned(() => httpClient.getUrl(httpUri),
          zoneValues: {#dart.library.io.allow_http: 'foo'}),
      (e) => e is StateError);
// Throws `OSError` ?
  asyncExpectThrows(
      () async => await runZoned(() => httpClient.getUrl(httpUri),
          zoneValues: {#dart.library.io.allow_http: false}),
      (e) => e is StateError);

Looking at test scripts, it seems like these tests are running on a phone. They also contain different exceptions.
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8884020471788653472/+/steps/test_results/0/logs/new_test_failures__logs_/0
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8884022100584288160/+/steps/test_results/0/logs/new_test_failures__logs_/0

OK. I resolved the windows problem. Basically httpClient.close needs to be called explicitly on Windows. I also restructured the tests to be more readable.
Unfortunately, I am unable to solve the Android phone problem. I tried using NetworkInterface to find a local IP to bind to but the phone does not provide such an interface. So I don't think this can be tested on phone.
Is there a way to ban tests on certain platforms?

you can update tests/standalone_2/standalone_2*.staus file, tests/standalone/standalone*.status file and add an entry that states Skip for that configuration.

The CL relanded banning Android tests.


[Marker.io] expanded menu modal does not get closed if the user clicks on the empty region on top of the menu bar

Steps to reproduce:

click on any menu having submenus to expand the modal
click on the region above the menu bar
(empty region)

Actual result: modal does not get closed
Expected result: not sure if its possible to do this. but probably we should close this modal since it is an empty area.

Reported by: vinod<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://wf-b.stg.prezzee.com/en-us/whatever?marker=true
Issue details: Open in Marker.io
Device typedesktopBrowserFirefox 132.0Screen Size1366 x 768OSWindows 10Viewport Size1366 x 615Pixel Ratio@1x

deferring for now

to be considered as part of the nav

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


Nessie and Flink Demo

(rather a dup of https://github.com/projectnessie/nessie/issues/1117)

Let's leave it open as a reminder until we have everyhing and can make the demo publicly available.


Update/unify getting started docs

I installed PUDL and built a postgres database from scratch on a Mac. Along the way I encountered a few issues (see below). The mac/linux/windows docs aren't always consistent, which should also be fixed.
PostgreSQL

Mac instructions don't talk about using a .pgpass file. Should they?
Mac instructions say

After installing PostgreSQL, open the application.

They should probably also say to click initialize

A description of the terminal code (sudo mkdir -p /etc/paths.d && echo /Applications/Postgres.app/Contents/Versions/latest/bin | sudo tee /etc/paths.d/postgresapp)  and expected output of which psql would be helpful.

Other issues

Mac and windows instructions need pip install -e .
Linux has a nice example of options for downloading initial data (python update_datastore.py --sources ferc1 eia923 eia860 --years 2014 2015 2016 2017) - add this to the Mac and windows instructions
Neither mac/windows talk about scripts/settings.yml for use with init_pudl.py. Linux has python init_pudl.py -f local_settings.yml, which I think is the same file but with a different name? Either way, it would be nice to have a description of settings for downloading data with the data store vs loading things into postgres.

Would you be willing to just go ahead and update the docs and make a PR? I'm on Linux, and we start over from scratch rarely... so this kind of blank slate revision is very useful.

Sure. What is the expected way to define the data to be downloaded vs initialized in the database? Is it arguments and settings.py? Having all of CEMS downloaded by default seems like it might catch users by surprise. I modified settings.py before runing init_pudl.py and assumed that it would be used for data download.

@gschivley, my understanding is that postgres.app defaults to trusting any connection, so there's no need for a .pgpass file

Right now the datastore and the DB initialization are managed completely separately, though I could see update_datastore.py reading the same settings.py file to figure out what it ought to download. But at the moment it's command line arguments for update_datastore.py which determine what gets downloaded, and the years listed for each data source in settings.py that determines what gets pulled into the DB.

@gschivley, my understanding is that postgres.app defaults to trusting any connection, so there's no need for a .pgpass file

Ok, interesting. I couldn't add/drop tables as the catalyst user (with the reset_db.sh file). Had to start psql and do it as the default user (Greg). Is that related?

@gschivley Maybe it depends which user created / owned the database?  When I was on a Mac I also recall never having to deal with any permissions stuff.

@gschivley Maybe it depends which user created / owned the database? When I was on a Mac I also recall never having to deal with any permissions stuff.

No idea. Maybe I'll add a quick note about it in the getting started.

@gschivley Did you feel like the updated getting started document was satisfactory?

Much better. A note about updating multiple data sources with different calls to update_datastore.py might be nice. Sounds simple but seeing the CI code pulling in one source at a time was helpful.
python update_datastore.py -s eia923 -y 2017
python update_datastore.py -s eia860 -y 2017
python update_datastore.py -s epaipm


Fix #1313 do not collapse row details when row updated

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#1313
What is the new behavior?
Rows (including grouped rows) stay expanded when rows are updated, as row expansion now uses rowIdentity to keep track of whether a row is expanded or not.
Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

Previously, row expansion collapsed after a row was updated, this fix keeps expanded rows expanded after row updates.
Per comments in #1313, users may have kept track of the expanded rows themselves and toggled rowExpansion after a row change in order to keep the row expanded. This toggling caused the expanded row to flash (close and open again). After this fix, any additional toggle can/should be removed.
Impact on grouped rows: if grouped rows are set to expanded by default, the previous behaviour after a row change was for grouped rows to all be expanded again. After this fix, group row expansion will retain their previous state too.
Note: row expansion now uses rowIdentity to track whether a row is expanded or not, hence users of this functionality may need to provide a rowIdentity function.
Other information:

@therealjing can you revert the changes to the release folder please? Those files are generated only when we release.

@marjan-georgiev sure, will do that in the next few days.

@marjan-georgiev done, changes to release folder reverted.

Nice job @therealjing! We're facing the same problem in our project and are waiting for the merge to fix it. Is there anything we can do to help?

This is the only issue we are facing. This needs to be merged

How about this issue?

We have published a forked package of this fix under https://www.npmjs.com/package/@acaisoft/ngx-datatable

Guys any updates on whether or not this is planned to merge any time soon?

@marjan-georgiev We're waiting on this change also. Can we get a status update?

In order to approve the merge, the conflicts must be resolved.
Also it requires some reviews from swimlane members in order to ensure the quality and proper behaviour of the library.
Just wait for it, there is a lot of issues being on the review queue and also other ngx-* libraries on top of that.

So when can we expect to get this merged?

Looks good. I resolved the conflicts in https://github.com/swimlane/ngx-datatable/pull/1778, and merged it.
Thank you @therealjing and everyone else for the contribution!


Test support for PlanetScale/Vitess

Setup the test suite similar to Yuga and Cockroach. Check to see where we're at. If there's any small fixes we can make, let's do it. If it requires a lot more work, we'll schedule that work separately.

I've attempted to approach this like we did for Yuga / Cockroach, and the setup is quite different. I tried integrating both the vitess/base and vitess/lite docker images into our CI, but both are rather involved to setup and I don't think we're in a position where we could maintain them without allocating substantial resources to it.
After discussing this with @matthewmueller, we decided it was best to pivot into investigating the PlanetScale hosted option, mostly to get a sense for compability with Prisma client, and provide feedback on what's missing to see this through to success. However apparently @timsuchanek also been looking into this, so today we've agreed he'll continue his investigation into PlanetScale, and take note of any incompatibilities that arise along the way. I believe an incompatibility around the SHOW query has already surfaced.
But to conclude my investigation: it seems that if we want to add support for Vitess / PlanetScale to Prisma Engines, we'll need to either have expert support on configuring and maintaining the CI setup, or rely on a hosted option to test against.

I've attempted to approach this like we did for Yuga / Cockroach, and the setup is quite different. I tried integrating both the vitess/base and vitess/lite docker images into our CI, but both are rather involved to setup and I don't think we're in a position where we could maintain them without allocating substantial resources to it.
After discussing this with @matthewmueller, we decided it was best to pivot into investigating the PlanetScale hosted option, mostly to get a sense for compability with Prisma client, and provide feedback on what's missing to see this through to success. However apparently @timsuchanek also been looking into this, so today we've agreed he'll continue his investigation into PlanetScale, and take note of any incompatibilities that arise along the way. I believe an incompatibility around the SHOW query has already surfaced.
But to conclude my investigation: it seems that if we want to add support for Vitess / PlanetScale to Prisma Engines, we'll need to either have expert support on configuring and maintaining the CI setup, or rely on a hosted option to test against.

Sprint is quite packed. We'll try to push this forward in a minimal way though.

Some internal context: https://prisma-company.slack.com/archives/CGMCB82N8/p1612340668093300

Tom enables migration engine here for planetscale: https://github.com/prisma/prisma-engines/pull/1613

Initial tests done https://www.notion.so/prismaio/PlanetScale-tests-30c94c15c9ff48049aa2da7e714dc923

This issue is about running the whole Rust and TypeScript test suite once.
When we have that done, we can close this issue.

Internal writeup on compatibility of QE to Vitess by @pimeys: https://prisma-company.slack.com/archives/C01N3V81YAG/p1615905999006500 (Summary: Kinda works, a few things we need to talk to Vitess)
Steps open for QE + Vitess:

[ ] Make a PR that can be merged that puts Vitess into our normal CI
[ ] Add Vitess MySQL 8 as well and make sure nothing else breaks there

Future work:

Validating Migration and Introspection Engine with Vitess
Further Planetscale Cloud validation (tbd, around shadow database and similar)


PageControl

Where is the page control added to the UI?
I want to get rid of the white background and have it transparent.
Great work!
Thanks.

Hey, there,
thanks for the issue created.
I just need a little bit of clarification - are you talking about the page control dots added that keep track of the page you are on at the moment? And is it where the pages automatically switch or you zoom them in and out?
Please let me know when you can.
Thanks

Your question totally makes sense.
Let me look into it real quick, now when you have the info I need, and I will write back ASAP today.

Actually, I do have the solution for you.
This is really the dirty and quick way to do things:

On the other hand, there is a better way!
You can use the delegate provided for you with setupAppearance function where you can control the appearance of the first page control (the one you are talking about) and the appearance of the second page control (the one with the GalleryVC):

This is directly taken from a project at work where we use the carousel. What you need to do for your project is:
firstPageControl.backgroundColor = .clear
This is also described in the ReadMe file here on GitHub but it is all the way down at the bottom of the file which is why you may have missed it. Sorry about that!
The picture is also not going underneath the page control at this point but I will work on that too!!
P.S. Could I ask you to start the project if you feel like it indeed 👍

P.S. again,
now I do remember I did have an issue with the image going under the dots, and it was because of the default implementation of UIPageControl that does not allow you to do that. I managed to fix it in the GalleryVC when I wanted stuff to be zoomable and etc.
I think the best way to solve the issue at hand is to provide two options for the actual and initial page view controller - one will be with the default page control background, dots and etc, and one can be the way you need it, with the picture going underneath.
Let me know if the current solution I have for you in the previous comment worked though.

Hi
I’m not at my Mac at the moment, I’m sure I tried changing the appearance though before. And yes I am looking to have the page control over the image so maybe need to look at a full Page Control rather than the free one from UIPageViewController.
Cheers
Iain
Sent from my iPhone

On 26 Jun 2017, at 03:28, Deyan Aleksandrov<EMAIL_ADDRESS>wrote:
Hey, there,
thanks for the issue created.
I just need a little bit of clarification - are you talking about the page control dots added that keep track of the page you are on at the moment? And is it where the pages automatically switch or you zoom them in and out?
Please let me know when you can.
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Already working on it 👍

Ok, the solution we are looking for your case is quite easy but not really good looking.
In public class SwiftImageCarouselVC, add this piece of code:
        super.viewDidLayoutSubviews()
        for view in self.view.subviews {
            if view is UIScrollView {
                view.frame = CGRect(x: view.frame.minX , y: view.frame.minY, width: view.frame.width, height: view.frame.height + 37)
            } else if view is UIPageControl {
                view.backgroundColor = .clear
            }
        }
    }

No matter whether you imported the framework it as a cocoapod or you added it as a dependency by copying the framework, you can edit the project classes and etc.
Meanwhile,
I will update the framework on GitHub and the Cocoapod web site.

Codebase and Cocoapod version updated to support function mentioned in issue, Readme file updated. Please star the project if you still like it :) It boosts my ego 🥇 👍

I thought about just doing this, agree it’s not nice but certainly achieves the outcome, probably better to use the height of the page control rather than a hard coded value. Knowing Apple, they will change the height soon 😉
Thanks 😊

On 26 Jun 2017, at 10:05, Deyan Aleksandrov<EMAIL_ADDRESS>wrote:
Ok, the solution we are looking for your case is quite easy but not really good looking.
In public class SwiftImageCarouselVC, add this piece of code:
    super.viewDidLayoutSubviews()
    for view in self.view.subviews {
        if view is UIScrollView {
            view.frame = CGRect(x: view.frame.minX , y: view.frame.minY, width: view.frame.width, height: view.frame.height + 37)
        } else if view is UIPageControl {
            view.backgroundColor = .clear
        }
    }
}

No matter whether you imported the framework it as a cocoapod or you added it as a dependency by copying the framework, you can edit the project classes and etc.
Meanwhile,
I will update the framework on GitHub and the Cocoapod web site.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yeah, it is just a quick fix for now. I plan on soon updating to swift 4 anyways. I do not think there will be much that will change with this particular repo but still :)

I am actually fixing it not to be hardcoded but dynamically received value. Thanks for pointing that out. And thanks for the star


Fixed #25415 -- made test runner perform system checks

Revival of #5293.
Ticket 25415

Current failures on Django test suite (local)
admin_views.Recommendation.recommender: (models.E006) The field 'recommender' clashes with the field 'recommender' from model 'admin_views.title'.
foreign_object.SlugPage.containers: (fields.E311) 'SlugPage.slug' must set unique=True because it is referenced by a foreign key.
foreign_object.SlugPage.descendants: (fields.E311) 'SlugPage.slug' must set unique=True because it is referenced by a foreign key.
introspection.Article.reporter: (fields.E304) Reverse accessor for 'Article.reporter' clashes with reverse accessor for 'Article.unmanaged_reporters'.
	HINT: Add or change a related_name argument to the definition for 'Article.reporter' or 'Article.unmanaged_reporters'.
introspection.Article.unmanaged_reporters: (fields.E304) Reverse accessor for 'Article.unmanaged_reporters' clashes with reverse accessor for 'Article.reporter'.
	HINT: Add or change a related_name argument to the definition for 'Article.unmanaged_reporters' or 'Article.reporter'.
many_to_many.InheritedArticleA: (models.E015) 'ordering' refers to the non-existent field 'title'.
many_to_many.InheritedArticleB: (models.E015) 'ordering' refers to the non-existent field 'title'.
model_forms.Author1.publication: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
model_formsets.ClassyMexicanRestaurant.restaurant: (models.E006) The field 'restaurant' clashes with the field 'restaurant' from model 'model_formsets.place'.
model_meta.FirstParent.first_ancestor: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
model_meta.SecondParent.second_ancestor: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
ordering.Article.author: (fields.E304) Reverse accessor for 'Article.author' clashes with reverse accessor for 'Article.second_author'.
	HINT: Add or change a related_name argument to the definition for 'Article.author' or 'Article.second_author'.
ordering.Article.second_author: (fields.E304) Reverse accessor for 'Article.second_author' clashes with reverse accessor for 'Article.author'.
	HINT: Add or change a related_name argument to the definition for 'Article.second_author' or 'Article.author'.
queries.JobResponsibilities.job: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
queries.JobResponsibilities.responsibility: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
queries.OrderItem.order: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
queries.StaffUser.staff: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
queries.Task.creator: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.
queries.Task.owner: (fields.E320) Field specifies on_delete=SET_NULL, but cannot be null.
	HINT: Set null=True argument on the field, or change the on_delete rule.

WARNINGS:
distinct_on_fields.Celebrity.greatest_fan: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
expressions_case.CaseTestModel.comma_separated_integer: (fields.W901) CommaSeparatedIntegerField has been deprecated. Support for it (except in historical migrations) will be removed in Django 2.0.
	HINT: Use CharField(validators=[validate_comma_separated_integer_list]) instead.
get_or_create.Profile.person: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
inspectdb.ColumnTypes.comma_separated_int_field: (fields.W901) CommaSeparatedIntegerField has been deprecated. Support for it (except in historical migrations) will be removed in Django 2.0.
	HINT: Use CharField(validators=[validate_comma_separated_integer_list]) instead.
inspectdb.PeopleData.people_pk: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
inspectdb.PeopleMoreData.people_unique: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
model_fields.AllFieldsModel.csv: (fields.W901) CommaSeparatedIntegerField has been deprecated. Support for it (except in historical migrations) will be removed in Django 2.0.
	HINT: Use CharField(validators=[validate_comma_separated_integer_list]) instead.
model_fields.VerboseNameField.field4: (fields.W901) CommaSeparatedIntegerField has been deprecated. Support for it (except in historical migrations) will be removed in Django 2.0.
	HINT: Use CharField(validators=[validate_comma_separated_integer_list]) instead.
model_forms.CommaSeparatedInteger.field: (fields.W901) CommaSeparatedIntegerField has been deprecated. Support for it (except in historical migrations) will be removed in Django 2.0.
	HINT: Use CharField(validators=[validate_comma_separated_integer_list]) instead.
model_formsets.Location.place: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
model_formsets_regress.UserProfile.user: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
model_inheritance_regress.BusStation.bus_routes: (fields.W901) CommaSeparatedIntegerField has been deprecated. Support for it (except in historical migrations) will be removed in Django 2.0.
	HINT: Use CharField(validators=[validate_comma_separated_integer_list]) instead.
model_regress.Model2.model1: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
model_regress.Model3.model2: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
queries.Celebrity.greatest_fan: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
raw_query.BookFkAsPk.book: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
relatedapp.Article.author: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
select_related_regress.Connection.end: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
select_related_regress.Connection.start: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.
select_related_regress.Person.user: (fields.W342) Setting unique=True on a ForeignKey has the same effect as using a OneToOneField.
	HINT: ForeignKey(unique=True) is usually better served by a OneToOneField.

@timgraham I've fixed all but the "CommaSeparatedIntegerField has been deprecated." warnings. Is there a recommended way of fixing them? We could just ignore the warning in the tests, or we could subclass it to ignore the warning and use that subclass throughout the test suite

Can we use SILENCED_SYSTEM_CHECKS? I don't think we should change all instances of ForeignKey(unique=True) to OneToOneField, for example, as it's a valid scenario that should continue to be tested.

Although some instances are testing behaviour that might be dfiferent for OneToOneField, most of the ForeignKey(unique=True) instances seem to be more valid as OneToOneFields though.
Silencing across the entire test suite is potentially dangerous as it might prevent problems in future tests. Ideally we'd be able to silence for specific instances of warnings, though that sounds like a big yak shave...

The idea of silencing specific warnings has come up before. It would be a nice to have, but as you said, not quite sure of the best implementation and how much work it would be.
I don't see foresee any problems with silencing the warnings for CommaSeparatedIntegerField and ForeignKey(unique=True) but if you come up with some other solution, I'll be happy to look at it.

Updated to use SILENCED_SYSTEM_CHECKS - setting it in runtests.py seems to work, afaict this is the 'base' of the settings used in tests.

Added a release note, turned into two commits - one to fix discoverrunner, one to fix the errors :+1:

There are some problems with the MySQL and MySQL GIS builds.

Both seem unrelated
MySQL:
  File "/home/jenkins/workspace/pull-requests-trusty/database/mysql/label/trusty-pr/python/python2.7/django/contrib/gis/db/models/fields.py", line 120, in db_type
    return connection.ops.geo_db_type(self)
AttributeError: 'DatabaseOperations' object has no attribute 'geo_db_type'

MySQL GIS:
  File "/home/jenkins/workspace/pull-requests-trusty/database/mysql_gis/label/trusty-pr/python/python2.7/django/contrib/gis/db/models/fields.py", line 420, in _check_connection
    raise ImproperlyConfigured('Raster fields require backends with raster support.')
django.core.exceptions.ImproperlyConfigured: Raster fields require backends with raster support.

Just rebased on master to retrigger builds, GIS error seems to have happened again.

In the first case, I think the problem is that the checks are run on GIS models when a GIS backend isn't in use.

Ah, that would do it

Looks like you'll need to skip these checks if not all(getattr(connection.features, feature, False) for feature in field.model._meta.required_db_features)

Adam, will you return to this or should we close it for now?

Yes I will return, I've just been super busy recently. Have more free time now though, will look at working on it this week.

Simon, I'm not sure where you envisioned that check skipping logic to live?

To address the new clashing table errors, I think we should modify that check to ignore unmanaged models. The patched I attached to https://code.djangoproject.com/ticket/27204 fixes the check errors that popped up in model_options and unmanaged_models.

Some additional output capturing might be needed. I see several "System check identified no issues (21 silenced)." in the test output.

@timgraham , Model (and fields) checks must not be run if all not all required db features are available on all connections. We should make Model.check() abort immediately if not all(getattr(connection.features, feature, False) for feature in self._meta.required_db_features).

@timgraham, that's what I had in mind: #7227.

I've merged in something similar to #7227 but only for the failing models. In the process I also found and removed some import hacks from the GIS tests which were missed when making GDAL a required dependency. Tests are green, ready for re-review  🎉

Will fix MySQL failure. That's annoying, tests were passing before my rebase yesterday.

I found that there were more problem models in other parts of gis_tests that have started failing checks, idk why exactly though. Since it was only the MySQL check_field that was actually failing when it called db_type, I've moved the check for 'model enabled' there. It's not the most logical place but it 'works for now'. In other news its check_field needed updating anyway because it was using django.db.connection instead of self.connection, meaning it'd start using the wrong connection if you had e.g. postgres as your default DB and mysql as a secondary.

buildbot, test this please.

More check failures following 7cddd8a02e60332c0d02f565c450b0eea0d88438 😄  :
ERRORS:
max_lengths.PersonWithCustomMaxLengths.vcard: (fields.E202) FileField's 'upload_to' argument must be a relative path, not an absolute path.
	HINT: Remove the leading slash.
max_lengths.PersonWithDefaultMaxLengths.vcard: (fields.E202) FileField's 'upload_to' argument must be a relative path, not an absolute path.
	HINT: Remove the leading slash.
serializers.FileData.data: (fields.E202) FileField's 'upload_to' argument must be a relative path, not an absolute path.
	HINT: Remove the leading slash.

@adamchainz hopefully we can ship this before introducing yet another failing check 😄

buildbot, test this please.

merged in 6d947e8c3218c7137cd3fffecf1ca5b9274a20c6, 391c450fbae8c3301954563288147578a1ae4a6d, 5eff8a77838540b27b6bef024dfccfd76008fd4c, thanks!


CML PR for 3-remote-experiments e7105c6e

Automated commits for https://github.com/iterative/demo-bank-customer-churn/commit/e7105c6eaeeedbc45457c8d7ef64312f2909013b created by CML.

45f5d52
Metrics

Path
f1
f1_by_geo.France
f1_by_geo.Germany
f1_by_geo.Spain
roc_auc
roc_auc_by_geo.France
roc_auc_by_geo.Germany
roc_auc_by_geo.Spain

metrics/metrics.json
0.61005
0.53165
0.66667
0.63576
0.86488
0.84644
0.8486
0.87502

Confusion Matrix


layers/GC: index retains entries for commits that have been GC'ed; this can lead to "read from gap" exceptions when querying via RPC

The current layers/GC implementation focuses on the store.pack file; the index is not changed. The index typically stores entries commit_id -> (offset,length,_), mapping a commit id to an (offset,length) in the store.pack file. After a GC (say, for the most recent commit), then any older commits will have been garbage collected. However, the index still maintains entries for each of these older commits.
Then you can trigger an error by asking the node to access one of these older commits:
tezos-client rpc get /chains/main/blocks/42/context/contracts/KT1VqarPDicMFn1ejmQqqshUkUXTCTXwmkCN/storage

(Aside: the "savepoint" -- which I believe is now also the point at which the last layers-GC occurred -- can be found using tezos-client rpc get /chains/main/levels/savepoint .)
A possible solution is to link the index to the layers implementation, so that finding in the index always returns None instead of Some(offset,length,_) if the relevant commit has an offset that is before the most recent GC position.

This will be solved by treating keys pointing to gap as non-member of the store


[Feature Request] -showsystray argument to open the system tray?

Is your feature request related to a problem? Please describe.
Related to #942 - Currently, Taskbar Segments mode looks like a dream, but the System Tray is too useful on Windows for it to be usable. TrayPopup, a RocketDock tool, works like this, but it's archived (difficult to find) and it would be nice to only use one program, TaskBarX
Describe the solution you'd like
-showstartmenu shows the start menu. -showsystray could toggle the System Tray, from a similar shortcut to the Start Menu?
Describe alternatives you've considered
TrayPopup, a small EXE for RocketDock usage, can already be used for this purpose.
Additional context
Would solve #942

While at it, might it be worth implementing -showdesktop, too? Same manner as -showstartmenu. To take the place of the far-bottom-right WIN+D button?

I just noticed that -showstartmenu only triggers the start menu (i.e. only toggle on), rather than toggling it on/off like the start button does.


Dendron Paste Image: Not working in .devcontainer

Please select the area your Bug applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Open Your Dendron workspace in a .devcontainer in VSCode. I chose the Open In Volume option but I think this happens with any option. I also chose the VSCode Image Node.js & Typescript.
Copy image to clipboard on MacOs
Run the Dendron Paste Image Command
Error Message pops up saying You need to install Xclip
exec  sudo apt install xclip
Run the Dendron Paste Image Command
Error Message pops up There is not an image in the clipboard.

Expected behavior
Paste Markdown Image/ Add image to assets
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)

OS: MacOs
Version 11.2

This seems potentially relevant.
https://code.visualstudio.com/docs/remote/troubleshooting#_clipboard-does-not-work

Yeah, pretty sure we do use clipboardy in which case, hopefully this is a quick fix to support remote installs of Dendron.

Yeah, pretty sure we do use clipboardy in which case, hopefully this is a quick fix to support remote installs of Dendron.

Just looked and it seems the paste image functionality is using this library?
https://github.com/mushanshitiancai/vscode-paste-image

Yes
On Sat, May 29, 2021 at 2:19 AM 8brandon @.***> wrote:

Yeah, pretty sure we do use clipboardy in which case, hopefully this is
a quick fix to support remote installs of Dendron.
Just looked and it seems the paste image functionality is using this
library?
https://github.com/mushanshitiancai/vscode-paste-image
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/749#issuecomment-850802142,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABPIPQLGM7YGP4J2FTWC5DTQCWT3ANCNFSM45K5LSSA
.


WIP: Add Wagtail video player module

Per the discussion in this thread, we want to add a standalone video player module to Wagtail.
As it stands now, this is the absolute MVP for doing this. All it does is create a bare-bones "wrapper" module in Wagtail, whose template just calls the existing video player macro. This ensures that we're not interfering with anything else that uses the existing video player macro (namely, Event pages and the FCM).
I think this is what we want, because the video player needs to be called from within other modules, like the FCM, so it can't just be a Wagtail module. But I labeled this a WIP because I wasn't sure if we should take the time now to do any other refactoring or issue solving with the video player. (For example, the close button overlaps the video when used within an FCM.)
Please give me your thoughts on if you think this PR is good to go as-is, or should take on other updates.
Additions

Wagtail module for placing a video player on the page.

Testing

Pull down this branch
runserver
Create/edit a Learn page and add a Video Player to the content area

Review

@cfpb/cfgov-frontends
@cfpb/cfgov-backends
@schaferjh
@jimmynotjim

Screenshots

Notes

The module is currently only made available on Learn pages. Should it be available elsewhere? @schaferjh

Todos

[ ] Add the migration
[ ] Update the change log
[ ] Minor styling fix: dead space under the video preview image

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

The module is currently only made available on Learn pages. Should it be available elsewhere?

No, for now let's stick with keeping this module on Learn pages.

Tested locally and the player was easy to add and worked as expected. Only a few comments above.

👍 , was thinking it might make more sense for it to be an organism due to it's complexity.

@sebworks Agreed. Will make that change.

All comments and todos addressed, with the exception of the CHANGELOG, which I haven't updated because the one in master has not been updated to reflect the 4.2 release. What's the process for doing that, @rosskarchner @willbarton?

@richaagarwal Did you still want to review this? I plan to merge Monday morning.

Hallelujah!


MyHeritage.FamilyTreeBuilder version <IP_ADDRESS>38

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Mood
On Mon, Mar 20, 2023, 10:00 PM azure-pipelines[bot] <
@.***> wrote:

Azure Pipelines successfully started running 1 pipeline(s).
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/winget-pkgs/pull/100121#issuecomment-1476562484,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6SFHNBS6CO5V24GH7YSDI3W5CAYTANCNFSM6AAAAAAWBKJXIQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hm, I see. I actually received that link from the support team. Here's the mail:
Dear Mr. ---,
Thank you for contacting us. My name is --- and I am happy to help you.
I sincerely apologize for the late reply, it shouldn't have taken so long to process your request.
I understand you would like a direct link to download the Family Tree Builder software.
The following link is for the Windows version:
https://ftb.mhcache.com/FP/FamilyTreeBuilder/family_tree_builder_8638.exe
The following link is for the Apple IOS version:
https://ftb.mhcache.com/FP/FamilyTreeBuilder/family_tree_builder_8532.dmg
If I can be of any further assistance, please let me know.
I wish you a nice day and all the best!
Best regards,
MyHeritage Support Team

@wingetbot waivers Add Validation-Domain


te-Jenny hoia estonia

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Is your app/project/product currently shipping and/or have the source code available?
[x] If an app, does your homepage include links to download the Android and/or iOS apps?
[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~10 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
item Estonia (HOIA) has an invalid repo https://koodivaramu.eesti.ee/tehik/hoia

Build failed because of:
item Estonia (HOIA) has an invalid repo https://koodivaramu.eesti.ee/tehik/hoia

LGTM

LGTM


Fix Python syntax error in test_websocket.py

flake8 testing of https://github.com/acarabott/ChromeREPL
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./libs/websocket/tests/test_websocket.py:14:48: E999 SyntaxError: invalid syntax
import ChromeREPL.libs.websocket as websocket as ws
                                               ^
1     E999 SyntaxError: invalid syntax
1

Thanks for finding this, fortunately as a test it didn't affect production.
In order to fix this properly, the patch script (https://github.com/acarabott/ChromeREPL/blob/master/libs/patch.sh) would need to be edited.
If you can fix that, it would be great. Otherwise I'll have to take a look at this in a few days.

I think you will need to modify patch.sh.

I haven't had time for modify patch.sh but I have manually fixed the import as part of another commit: https://github.com/acarabott/ChromeREPL/commit/485d40570b0bee01c0540035b71c0ce91301db74


Home Page: Remove Videos.

For the migration phase, we are not presenting any videos

To remove the video from the home page, update the section that contains the tab block, and replace it with the block  from the referenced fragment page.

Pretty much added this so I make sure to do this...Thanks Bryan


Merge-back v1 to main

Realign main with v1 after https://github.com/github/codeql-action/pull/210
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.

Ugh, it's getting "This branch is out-of-date with the base branch" because this PR is opened directly from v1 to main, and v1 is behind main. I'm sorry but this may require yet another PR, to instread create a new branch to do the merge manually. See what Chris did in https://github.com/github/codeql-action/pull/134
We'll make sure to also document this so it's less hassle next time. Sorry this has all fallen to you.


edit_modal = True doesn't work with form_edit_rules

This block don't work:
class MyModelView(ModelView)
    edit_modal = True
    form_edit_rules = [
        rules.FieldSet('name', 'date')
        ]

I should choose between modal and ruleset, both doesn't work.

Looks like adding {% set render_ctx = h.resolve_ctx() %} to the template fixes it.


style(all): re-format with clang 1.0.36

Looks like clang 1.0.36 was released and it has impact on our code base.
Not sure how I feel about all the changes but hey, clang sets the rules here...

If clang keeps on doing those kind of things we might consider pinning a version we are using...

I am completely against this change. One quote for HTML is horrible.

I am completely against this change. One quote for HTML is horrible.

Not to mention that it breaks our code.... The only alternative I can see is to pin to a previous version of clang... Sight...

I think it's a good idea, in general, to pin versions until we have a chance to test the changed library in a controlled upgrade.  Otherwise, bugs significantly more subtle than a breaking build can creep in and we won't know it until someone reports it.  This has happened to us at work.

I think it's a good idea, in general, to pin versions until we have a chance to test the changed library in a controlled upgrade.

In this case we might consider shrink-wrapping our package.json. It is pain n a neck, but at least deals with the problem we are seeing here :-)

I can't tell if you're agreeing with me or not.  :-)


teardown should always try to unmount all attachments

Extra context:
This was recently seen when requesting swap that failed for some reason (I believe 8GB swap failed, where 4GB worked). The problem we have here is Slurm calls teardown to do all the tidy up, but we haven't unmounted the compute nodes, so we end up leaving hanging mounts on the compute node, which causes other issues for future executions.

Should be fixed with this commit: https://github.com/RSE-Cambridge/data-acc/commit/d3c7e454eb60150479699911a603cfc8d1a2ebaf


Document migration from Katana 3.0.1 -> 4.0.0

Users are hitting a couple of issues when moving from 3.0.1 -> 4.0.0
There are some simple things that if we document properly, we could cover most likely 90% of issues.

Remove all IdentityModel references, some users upgrade to System.IdentityModel.Tokens.Jwt and leave Microsoft.IdentityModel.Protocols.Extensions
Help people understand that SecurityKeys are used to sign not SecurityTokens
Make sure users know that 5.x doesn't work with Katana 3.0.1

https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/wiki/Migrating-from-Katana-(OWIN)-3.x-to-4.x


remove use-sdk from AndroidManifest

fix The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.
fixes #246

Fixed in another PR.


[BUG] - Crash on 1.20.1

Description
Game doesnt launch on 1.20.1
To Reproduce
Steps to reproduce the behavior:

Download 1.2.2 version of mod
Launch minecraft 1.20.1
Game doesnt launch

Expected behavior
Launch
Screenshots

Version (please complete the following information):

Minecraft version: 1.20.1
Carpet version: 1.4.112
Mod version: 1.2.2

Additional context
Quilt Loader 0.19.2-beta.7

Hi, thanks for raising the issue!
Did you download the mod from github, CurseForge or Modrinth? We haven't got round to officially releasing a 1.20.1 version for 1.2.2 yet.
This will be resolved asap.

im download on modrinth because it marked as 1.20.1 compatible

i think you need to change this

and yes

Strange that it has come up as 1.20.1 compatible 😕 Cool, we will sort that. Thanks!

@Rozbiynk Release has now been made for 1.20.1:
github
modrinth


Need to comment out LDFLAGS += $(RAYLIB_PATH)/src/raylib.rc.data for examples to run on windows

[x] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[x] My code has no errors or misuse of raylib

Issue description
As said in the title, examples didn't work until that line was commented out. Don't know what the problem is because that line is windows specific in the first place.
Environment
Windows 10, mingw64 from w64devkit
Issue Screenshot
i386 architecture of input file `../src/raylib.rc.data' is incompatible with i386:x86-64 output

https://raylib.handmade.network/forums/t/7074-examples_build_errors_on_windows_with_mingw

This usually means that the rc.data file was compiled assuming one architecture (e.g., x86 32 bit), and the second linking stage is looking for x64-compatible material.  So this may be a compilation settings issue.
Which specific example are you attempting?

For getting started, the make files are too exotic and elaborate for learning simple compiles. They cover amazing ground, but troubleshooting them requires considerable understanding of what is going on. I think they may also require customization for actual situations.

Yea I'm not worried about understanding everything right now, just wanted to report this issue.

With regard to the PLATFORM= parameter to mingw32-make, you'll see extensive conditional variation in the make file itself.

I was actually referring to mingw32-make compared to make not the parameter my bad, I figure if you compile raylib yourself it shouldn't make a difference? (this has nothing to do with the issue though)
Like I said I was able to compile all examples after commenting out that specific line in the makefile, but it should probably be fixed/changed.

https://github.com/skeeto/w64devkit/releases/tag/v1.18.0 I downloaded the one at the top of the list here, below source.tar. Isn't that the x64 bit one? w64devkit-1.18.0.zip

Yea it literally says 64 bit in the readme that came in the download, this should be re-opened.

@lesleyrs Yeah, I checked it and fixed it. I don't know what happened because the resources shipped with the installer have the right architecture... In any case, I updated them.


Investigate flaky unit tests

At the moment - there are several unit tests failing in 'main'.
4 of them are mentioned here:
https://github.com/speedb-io/speedb/issues/9#issuecomment-1164276865
Since those 4 are failing in RocksDB 7.2.2 we should decide weather to fix them or remove them.
EnvTest.GenerateRawUniqueIdTrackEnvDetailsOnly
EventListenerTest.OnBlobFileOperationTest
EventListenerTest.OnFileOperationTest
EventListenerTest.ReadManifestAndWALOnRecovery
additional one:
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PerfContextTest
[ RUN      ] PerfContextTest.DBMutexLockCounter
db/perf_context_test.cc:611: Failure
Expected: (get_perf_context()->db_mutex_lock_nanos) > (0), actual: 0 vs 0
terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException'
  what():  db/perf_context_test.cc:611: Failure
Expected: (get_perf_context()->db_mutex_lock_nanos) > (0), actual: 0 vs 0
Aborted (core dumped)

As long as those tests keep failing we will not be able to make the automation process work as expected.

the issue does not reproduce on current main (1698da4cc0d66c5623916b3d083df8d42e061703) with Azure instances. all unit tests. if the problem recurs, its possible to switch to using the mock clock


Add support for setupSuite and tearDownSuite

This is an extremely naive attempt at #7
My use case is very similar to what described in #7 (setting up actor systems, database fixtures, and similar stuff that I would like to perform once per test suite).

Hi @alexandru, did you get a chance to take a look at this?
Just today I had a use case for it: I need to close my db's connection pool after all tests have run.

Sorry for the latency @gabro, looks good — if you tested it and it works, then I can merge it and do a release later today.

Thanks for the feedback @alexandru. I've done some basic tests and it seems to work. Let me beta-test it in a project at work and report back.

Ok, I've published it locally and I've done a smoke test on a real project. It seems to work as expected.
Let me know you have bandwidth to merge and release this, @alexandru and thanks :)

Will publish tonight.

Very sorry for the delay @gabro, I'm publishing it right now, will let you know when finished.

No apologies needed, thanks for taking care of this!

@gabro should be published.

Thanks! I'll try it soon


Research degradation rewards

when we have multiple competitions,

reduce gradually incentive for best miner when model isn't improving or just by small amount

for example, we have 3 competitions, for 3 different models, each receives 33% of miner emissions
when improvement is less than 1% during a week, reduce by 10%
figure out the numbers

https://docs.google.com/spreadsheets/d/1GVHXBTZRGbMMbyjestGxKpmFY1jvsQiJ19TJHmVUmto/edit?gid=0#gid=0
emisja cala minus konkursy z decayem*procent spadku i pozostała ilosc procentow emisji dzielona na ilosc konkursow bez deceya upraszczajac


Run scripts/update-pycodestyle.sh to fix the pycodestyle test failure

Due to the issue with travis not reporting job result back, https://github.com/kubernetes-client/python-base/pull/195 was merged with a pycodestyle test failure.
This PR runs scripts/update-pycodestyle.sh to fix the test.
/cc @palnabarun @vishnu667

/hold
until the travis job successes

Looks like it will be fine
/lgtm

/hold cancel
https://travis-ci.org/github/kubernetes-client/python-base/builds/701073102


Please support bcrypt cryptography

Hello,
I would appreciate it if YTT could support bcrypt in the same way as it does SHA256. Maybe using something like https://godoc.org/golang.org/x/crypto/bcrypt
Thanks!

hey @dben, ytt has a goal to produce configuration deterministically (one example is no access to random data). bcrypt ultimately needs a salt (in addition to password and cost factor) as an input. https://godoc.org/golang.org/x/crypto/bcrypt internally uses crypt/rand to get x number of random bytes. even if we expose bcrypt function that explicitly takes salt argument, one would have to provide it via a data value (similar to password content) or hard code, and of course hard coding of salt would not be great. im curious how are you planning to use bcrypt in your configuration to understand if we can do something about it.

closing this for now since bcrypt requires access to randomness unless salt is provided explicitly. at that point you might as well provide bcrypted password. feel free to reopen if more info arises.

Came up again: https://kubernetes.slack.com/archives/CH8KCCKA5/p1658338062768589

Providing the salt to make things consistent seems like a doable workaround, since the password would already need to be stored securely and the salt could be generated prior to ytt call

Re-opened because we're seriously entertaining this. Exploring the viability of the "workaround" suggested, here.

Any update to this?


Gauge calling method that returns a future

Gauge[Integer]{
  taskManager.countTasks()
}

countTasks returns a Future[Int]
Would be nice to have a Gauge that accepts futures or is this a bad idea?

Hi @francisdb, thanks for your suggestion!
The metrics-scala library wraps dropwizard metrics. The Gauge interface there does not allow a future, all reporters want the value synchronously. Of course we could wrap that in the metrics-scala library which raises the question on how to await for the future: what would be the timeout, what executor context do you want to run it on? I can't answer these questions for you so you'd have to pass them along. What's left then is that metrics-scala will simply invoke what you provide. So in the end the functionality is so thin that having it in your own code adds almost no overhead.
Did I miss something?

Ok, just wanted you opinion on this, currently I'm just calling Await.result which works but is suboptimal.

@francisdb one option would be to:

create a dropwizard Gauge that wraps an AtomicInt
add an onSuccess callback to your future that does an atomic update on the AtomicInt

This at least gets you out of the await, for a little more complexity.


Bumped main branch version to 3.0.

Description
Bumped main branch version to 3.0.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The unit and cypress test workflows are currently failing with the following error; however, because we don't guarantee stability on main branches, we can review and merge in this bump, and resolve those workflow failures in separate PRs.
Cache not found for input keys: cypress-cache-v2-Linux-d9e92abea0f3a9fd094be38db0e88a4810d49cc9d834c308b47ef396d26d9b55, cypress-cache-v2-Linux-d9e92abea0f3a9fd094be38db0e88a4810d49cc9d834c308b47ef396d26d9b55


Sencha Cmd error on build - callParent has no target

Using Sencha Cmd v<IP_ADDRESS> to build my project (ie. sencha app build), I get the following error:
[WRN] C1014: callParent has no target (me.callParent in Ext.ux.DateTimeField.mim
icBlur) -- C:\app\ext\src\ux\DateTimeField.js:36

Running with ExtJS 5.1.1

Hi, I couldn't reproduce this at all. Placed my DateTimeField inside the packages folder, then added
"requires": [
"DateTimeField"
]
to my app.json file in my app root. My project built with no errors using CMD <IP_ADDRESS>

Ah, well that clarifies more how to add the package. Added:
"requires": [
"sencha-charts",
"DateTimeField"
],
So this resolves one part of my other reported issue.  However, this warning is still showing.
[WRN] C1014: callParent has no target (me.callParent in Ext.ux.DateTimeField.mim
icBlur) -- C:\..\app\packages\DateTimeField\src\DateTimeField.js:36

Hi,
Please run this test with me,
1 - sencha -sdk <path to your 5.1.1> generate app DateTimeTest ./DateTimeTest
2 - cd DateTimeTest
3 - Copy the DateTimeField folder to the packages folder
4 - Edit app.json and add DateTimeField to your requires
5 - Edit app.js file and replace with
Ext.application({
    name: 'DateTimeTest',
    extend: 'DateTimeTest.Application',
    launch : function () {
        Ext.create('Ext.Panel',{
            width: 400,
		height: 400,
		title: 'Testing DateTime Field',
		items: [{
	            xtype : 'datetimefield',
	            fieldLabel : 'Testing'
		}],
		renderTo: document.body
	    });
    }
});

6 - sencha app build

Oh, I just saw what you mean. This is just a warning because the Parent class doesn't have the mimicblur method declared explicitly, but it will inherit it eventually. I only use this method to keep the package compatible with ExtJS 4 and 5.

Sorry, haven't had a chance to run your test code.  Based on your second comment, is it safe to remove that line / comment it out since I'm only using Extjs 5?

No because even though it's deprecated, the method still works and it is what makes the picker collapse properly. Just disregard the warning.


Add trendline to similarity tab plot

Also, make minor adjustments to other aesthetic things with the plot

Something odd is going on here – several changes that are present on master are being shown here too.  The party function, for example.  If you can rebase (only) your commits onto master that should sort it out.  I can help if needed.


libflashmq-dbus-plugin interferes with LWT (Tasmota devices)

When VenusOS started using FlashMQ, it seemed like a good idea to transfer all MQTT related communication to VenusOS given that FlashMQ is supposed to a high-performance MQTT broker (and you ideally want only one in your local network).
After doing the switch, myself and others (see https://github.com/halfgaar/FlashMQ/issues/84) started seeing sporadic issues with LWT state of their Tasmota devices which would happen to be "off" with no good reason. I started debugging this in order to try and figure out where the root cause was and what I needed to do to make it work.
Ultimately, it boils down that the usage of libflashmq-dbus-plugin.so with FlashMQ made LWT messages break. I used the following test config to validate this (with /run/flashmq being empty) :
thread_count 1
#plugin /usr/libexec/flashmq/libflashmq-dbus-plugin.so
max_packet_size 16777216
client_max_write_buffer_size 4194304
expire_sessions_after_seconds 86400
#include_dir /run/flashmq
zero_byte_username_is_anonymous true
log_level debug
allow_anonymous true

listen {
  protocol mqtt
  port 1884
}

When pointing my Tasmota device to the VenusOS device on port 1884 (without the plugin) and running mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v, I would consistently see this:
$ mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v
tele/my-device/LWT Online
$ mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v
tele/my-device/LWT Online
$ mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v
tele/my-device/LWT Online

When uncommenting plugin /usr/libexec/flashmq/libflashmq-dbus-plugin.so and enabling the plugin, it would consistently look like this:
$ mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v
tele/my-device/LWT Online
$ mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v
tele/my-device/LWT Offline
$ mosquitto_sub -h venus.local -p 1884 -t 'tele/#' -v
tele/my-device/LWT Offline

This may be working as expected since FlashMQ with libflashmq-dbus-plugin.so might not have been considered to be an MQTT broker outside of VenusOS; however, it would be great to get this fixed so users don't have to setup bridges or consider other workarounds where that's not needed since they could be happy with a single MQTT broker instance in their local network - and that being FlashMQ on VenusOS :)

The plugin removes the retain flag on incoming publishes:
https://github.com/victronenergy/dbus-flashmq/blob/4d534bc6724427472d40449af61f6e4451fb967d/src/flashmq-dbus-plugin.cpp#L80
Now that I look at it, that actually only has affect on non-LWT publishes, which is kind of an ommision. In any case, the effect would be that once 'offline' is set as retained message by an LWT, it will not go back to 'on-line' as retained message. Only on-line clients will see the 'on-line' message coming by. Is that the behavior you see?
You could perhaps also post the output of mosquitto_pub with the -d flag, so I can see the retain flags.
As for a fix, I'd have to give it some thought. The transition from retained to non-retained messages in Venus was quite complicated, in subtle ways.

I ran a tcpdump for the Tasmota device, and it does set the retain flag for LWT as expected:

What is the reason to remove it? Would it make sense to adjust the function to filter for Venus-internal topics instead if this is a requirement internally?

Only on-line clients will see the 'on-line' message coming by. Is that the behavior you see?

Basically, yes - I'm not sure what happens in clients like Home Assistant, but maybe the MQTT reader thread restarts and therefore loses all LWT information for the topic/instances; since upon reconnection, LWT is either Offline (or doesn't exist, I've seen both now) it never knows the Tasmota device's status until after that device restarts/reconnects (and in the process, resends its LWT: Online message).

Still, would it make sense to adjust the function to filter for Venus-internal topics only instead globally if this is a requirement internally?

We came up with the same idea:
https://github.com/victronenergy/dbus-flashmq/commit/59550e56db9f609cd0e520d7c89a96f1c0f9913f
It will probably be in Venus 3.40~ testing builds soon. Ticket will be updated.

Its in beta v3.50~1; which will be available in a few days max I expect


Beyond I2CMaster_WriteThenRead

Hi,
I2CMaster_WriteThenRead API combines a "write then read" as a single bus transaction. I am wondering why Azure Sphere doesn't provide an API to generalize it to multiple read/write operations in a single transaction.
For example, this is what Linux provides.
https://github.com/torvalds/linux/blob/master/Documentation/i2c/dev-interface
  struct i2c_rdwr_ioctl_data {
      struct i2c_msg *msgs;  /* ptr to array of simple messages */
      int nmsgs;             /* number of messages to exchange */
  }

Thanks,
Qiutong

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aadc4a17-7ca5-1ef5-1952-6f3712c77a2b
Version Independent ID: 282cf84e-09c0-a393-d21f-b264690e029c
Content: I2CMaster_WriteThenRead function - Azure Sphere
Content Source: AzureSphere/articles/reference/applibs-reference/applibs-i2c/function-i2cmaster-writethenread.md
Product: azure-sphere
GitHub Login: @esalc
Microsoft Alias: azurespheredocs

@qiutongs Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @qiutongs would you please provide that valuable feedback at https://feedback.azure.com/forums/915433-azure-sphere/filters/top?page=2 this way it can get upvoted and prioritized by the product team.

Hi @qiutongs Since this feedback is related to the actual product vs the documentation. We will be closing this issue now.
Please share the link to your feedback post so others coming across this issue can go and up-vote your idea. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Fix get_bluetooth to use .json exception catching in AlexaAPI

Should resolve #39.

We should really wrap all requests in a try catch. My goal was to make it into its own function call so we didn't have a bunch of try catch statements, but this can be handled when I complete the move to a pip module.


Fix result dtypes of special functions

It seems that scipy.special converts float16 to float32.
>>> scipy.special.j0(numpy.ones((2,), dtype=numpy.float16))
array([0.7651977, 0.7651977], dtype=float32)

OK, Thanks.
jenkins, test this please.

Jenkins CI test (for commit b79a0acaac158fea8b5f5ee2cf81ea42fd3b1d63, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM!


Empty strings

Hi!
href={text('href', undefined)}

works perfectly until I enter some text and delete it again. instead of removing my href prop it fills in an empty string. Which I don't really understand because, normally, react will remove the prop if its empty (right?).
So initially my component looks like
<Button .. />

and after editing href and deleting again it looks like
<Button href="" />

Is this a bug or do I use it the wrong way?
My component passes the href prop immediately to the attribute like this here:
href={href}

Cheers!

Will be nice if have something link this:
<Button href={text.optional('href', 'http://google.com')} />

When uses with .option can appear a checkbox in front of textfield, to enable/disable this.
When disabled, it pass undefined to value, and when enabled it pass the textfield value.

@renatorib's proposal would work well for select as well, which could add an initial blank to the <select> which when chosen would exclude the prop from being sent to the component.

Unfortunately storybook's repos are almost abandoned. =(

For others interested in this problem (in the future), here's our solution:
/*
 *
 * Use for props that can take null value so that Storybook doesn't complain.
 * example use:
 * `nullify(select('propName', [null, 'value', 'two']))`
 * `nullify(select('propName', ['', 'value', 'two']))`
 *
*/

const nullify = (v) => v === '' ? null : v;

export default nullify;

This allows a story author to identify knobs that need to be treated differently than always-convert-to-empty-string, i.e. null support cases. Simply use it like this in a story:
import nullify from '../src/utils/nullify.js';
...
<Slider
    orientation={nullify(select('orientation', [null, 'vertical', 'radial']))}
>

The prop will even be omitted in the storybook component info screen when the null option is selected, just like you'd expect. selects render the null as a blank (no text) in the dropdown for that item. Also, because the developer must intentionally add it, it's not going to break existing stories that expect empty strings.

@Djspaceg great!

Just last week I realized it would be nice to incorporate strict equality to false, which would remove optional props from appearing in the "info" addon too. You could apply nullify to Boolean props:
Things like <Button round>Basic</Button> will not appear as <Button round={false}>Basic</Button> but instead as simply <Button>Basic</Button>.
const nullify = (v) => (v === '' || v === false) ? null : v;

or even smaller:
const nullify = (v) => !v ? null : v;


cmd/compile/ssa: don't load/save unused values in a block

The currently regalloc does a silly thing--it loads all live values as it enters a block, whether or not they are used in that block, and then saves them on exit. Example:
After schedule:
b132: ← b5
Plain → b8

After regalloc:
b132: ← b5
v292 = LoadReg <uint32> v49 : AX
v290 = Copy <uint32> v292 : CX
v401 = StoreReg <uint32> v290
Plain → b8

The new regalloc is coming, just wanted to file this so that we double-check to make sure that this gets fixed by it.
/cc @randall77

Close this now?

Yes, the new regalloc should fix this.


Develop2.0 colormap

Hey @desean1625, Travis should be working now. Do a
git remote add upstream https://github.com/LGSInnovations/sigplot
git pull --rebase upstream develop-2.0
git push --force origin develop2.0-Colormap

to get the latest .travis.yml and re-run CI.

I've found two issue:

Run grunt jsbeautifier:cleanup to fix up the formatting in m.js
The "scrolling raster" unittest for the original implementation shows a rainbow plot, but with the new color map shows all dark blue.  This appears to be due to a bug in getColor.

I've fixed those and merged this into develop-2.0