WIP s390x arch support

per https://github.com/openzipkin/zipkin/issues/3310
Current status:
Running in native arch, we can build the images. Running via qemu (needed for multi-arch docker push) crashes still, most easily seen via the following:
DOCKER_BUILDKIT=1 docker build --progress=plain --platform linux/s390x . --build-arg java_version=15.0.1_p9
DOCKER_BUILDKIT=1 docker build --progress=plain --platform linux/s390x . --build-arg java_version=11.0.9_p11 --build-arg java_home=/usr/lib/jvm/java-11-openjdk

jar_version_crash_jdk15.txt
java_version_crash_jdk11.txt
I asked for help here though it might not be solvable in aports https://gitlab.alpinelinux.org/alpine/aports/-/issues/12128#note_128541

@BbolroC  can you chase this up? openzipkin/alpine is all set with s390x
note: tests only cover amd64 that's why this is green despite the failures.. if we ever get quota on travis again, we could check those archs directly (aarch64/arm64 and s390x)

updated description with latest status

More direct way to test this using qemu is here:
$ docker buildx imagetools inspect ghcr.io/openzipkin/alpine:3.12.1
Name:      ghcr.io/openzipkin/alpine:3.12.1
MediaType: application/vnd.docker.distribution.manifest.list.v2+json
Digest:    sha256:0b0902a5d4c3be34aacca5e3c830deb57f7218c3264ba4f8e86494558911a678

Manifests:
  Name:      ghcr.io/openzipkin/alpine:3.12.1@sha256:2ed48aa628d8cc9d241bbb26a40e7a1bbb918193810600164d4c3cfa2971919d
  MediaType: application/vnd.docker.distribution.manifest.v2+json
  Platform:  linux/amd64

  Name:      ghcr.io/openzipkin/alpine:3.12.1@sha256:c71937ea48493b4d58491b428947e2722dcd82cb7bb3f6f10b560a423ef47151
  MediaType: application/vnd.docker.distribution.manifest.v2+json
  Platform:  linux/arm64

  Name:      ghcr.io/openzipkin/alpine:3.12.1@sha256:62cdb30dbd1f99e226d8400fbb9778ab67014ce67967653a7ed8bee1b60f1886
  MediaType: application/vnd.docker.distribution.manifest.v2+json
  Platform:  linux/s390x
$ docker run --rm -it --entrypoint /bin/sh ghcr.io/openzipkin/alpine:3.12.1@sha256:62cdb30dbd1f99e226d8400fbb9778ab67014ce67967653a7ed8bee1b60f1886
/ # uname -a
Linux 9fea89e78b6b 5.4.39-linuxkit #1 SMP Fri May 8 23:03:06 UTC 2020 s390x Linux
/ # apk --no-cache add openjdk15-jmods=~15.0.1_p9 openjdk15-jdk=~15.0.1_p9 binutils tar wget
--snip--
/ # /usr/lib/jvm/default-jvm/bin/jar -version
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGILL (0x4) at pc=0x0000004010e16240, pid=67, tid=71
#
# JRE version: OpenJDK Runtime Environment (15.0.1+9) (build 15.0.1+9-alpine-r1)
# Java VM: OpenJDK 64-Bit Server VM (15.0.1+9-alpine-r1, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-s390x)
# Problematic frame:
# J 1 c1 java.lang.Object.<init>()V<EMAIL_ADDRESS>(1 bytes) @ 0x0000004010e16240 [0x0000004010e16200+0x0000000000000040]
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# //hs_err_pid67.log
Compiled method (c1)     552    1       3       java.lang.Object::<init> (1 bytes)
 total in heap  [0x0000004010e16010,0x0000004010e163b8] = 936
 relocation     [0x0000004010e16168,0x0000004010e16198] = 48
 constants      [0x0000004010e161c0,0x0000004010e16200] = 64
 main code      [0x0000004010e16200,0x0000004010e16300] = 256
 stub code      [0x0000004010e16300,0x0000004010e16358] = 88
 metadata       [0x0000004010e16358,0x0000004010e16370] = 24
 scopes data    [0x0000004010e16370,0x0000004010e16380] = 16
 scopes pcs     [0x0000004010e16380,0x0000004010e163b0] = 48
 dependencies   [0x0000004010e163b0,0x0000004010e163b8] = 8
Compiled method (c1)     563    1       3       java.lang.Object::<init> (1 bytes)
 total in heap  [0x0000004010e16010,0x0000004010e163b8] = 936
 relocation     [0x0000004010e16168,0x0000004010e16198] = 48
 constants      [0x0000004010e161c0,0x0000004010e16200] = 64
 main code      [0x0000004010e16200,0x0000004010e16300] = 256
 stub code      [0x0000004010e16300,0x0000004010e16358] = 88
 metadata       [0x0000004010e16358,0x0000004010e16370] = 24
 scopes data    [0x0000004010e16370,0x0000004010e16380] = 16
 scopes pcs     [0x0000004010e16380,0x0000004010e163b0] = 48
 dependencies   [0x0000004010e163b0,0x0000004010e163b8] = 8
#
# If you would like to submit a bug report, please visit:
#   https://gitlab.alpinelinux.org/alpine/aports/issues
#
Aborted

tried this:
diff --git a/Dockerfile b/Dockerfile
index 09191a3..14be982 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -46,6 +46,8 @@ ARG maven_version=3.6.3
 LABEL maven-version=$maven_version

 COPY --from=code /code/install.sh .
+ADD https://gitlab.alpinelinux.org/bratkartoffel/aports/-/jobs/260329/artifacts/download /tmp/openjdk.zip
+RUN (cd /tmp && unzip openjdk.zip && cd packages/community/s390x && apk add --allow-untrusted openjdk11-11.0.9_p11-r1.apk) && rm -rf /tmp/openjdk.zip /tmp/packages
 RUN ./install.sh $java_version $maven_version && rm install.sh

 # Use a temporary target to build a JRE using the JDK we just built
@@ -53,11 +55,8 @@ FROM jdk as install

 WORKDIR /install

-# Opt out of --strip-debug when openjdk15+arm64 per https://github.com/openzipkin/docker-java/issues/34
-# This is because we cannot set the following in jlink -Djdk.lang.Process.launchMechanism=vfork
-RUN if [ -d "/usr/lib/jvm/java-15-openjdk" ] && [ "$(uname -m)" = "aarch64" ]; then strip=""; else strip="--strip-debug"; fi && \
 # Included modules cherry-picked from https://docs.oracle.com/en/java/javase/15/docs/api/
-jlink --vm=server --no-header-files --no-man-pages --compress=0 ${strip} --add-modules \
+RUN jlink --vm=server --no-header-files --no-man-pages --compress=0 --strip-debug --add-modules \
 java.base,java.logging,\
 # java.desktop includes java.beans which is used by Spring
 java.desktop,\
diff --git a/install.sh b/install.sh
index c380978..fb3f9cc 100755
--- a/install.sh
+++ b/install.sh
@@ -32,8 +32,9 @@ maven_version=${2?maven_version is required. ex 3.6.3}
 java_major_version=$(echo ${java_version}| cut -f1 -d .)
 package=openjdk${java_major_version}

-apk --no-cache add \
-${package}-jmods=~${java_version} ${package}-jdk=~${java_version} binutils tar wget
+#apk --no-cache add \
+# binutils tar wget
+# ${package}-jmods=~${java_version} ${package}-jdk=~${java_version} binutils tar wget

 # Typically, only amd64 is tested in CI: Run commands that ensure binaries match current arch.
 if ! java -version || ! jar --version || ! jlink --version; then maybe_log_crash; fi

Hey, I am back. I also checked the discrepancy between the native and qemu. I appreciate your hard work in the meantime. I tried what you had tried above and executed the following command:
$ docker run --rm --privileged multiarch/qemu-user-static:5.1.0-7 --reset -p yes
$ DOCKER_BUILDKIT=0 docker build --platform linux/s390x . --build-arg java_version=11.0.9_p11-r1

and got an error on java --version. I am not sure I got the same result as you, but just simply tell me about what I could contribute to this draft. Thanks.

Thanks and glad you are back @BbolroC! If you can, please tell simon here that you are taking over from me on troubleshooting. https://gitlab.alpinelinux.org/alpine/aports/-/issues/12128#note_128674 I last sent him a dump from his debug build. If there's something on aports side they can do, either it would be retrying a custom download from simon or a new version of the package in the repo (ex -r1 to -r2). a new version of the package in the repo is easiest as no changes to the dockerfile are needed.. you simply build and see.
It may also be outside aports control to fix this, it might need collaboration with someone from https://github.com/multiarch/qemu-user-static or https://github.com/qemu/QEMU. Possibly an issue on either, or a connection to someone active there.
Anyway, once the dockerfile builds we simply merge this as it is mechanical apart from the current crashing.
/me will get back to job interviews :)
cheers

Thanks for the guideline. I would like to check the permission for the contribution to those projects first with my manager before starting the work. I will get back to you soon, but please understand it could take longer due to the Christmas season.
Good luck to the interview. (not sure if you are an interviewer or an interviewee :D)

Hey, I got a good news. I can take over the tasks for alpinelinux and qemu from you. I will keep the discussion with Simon and at the same time try to figure out another solution from the qemu perspective (I got some of the names working on that repo.)
I will notify you after the Dockerfile itself intact works on s390x with a fix outside.

@BbolroC please thank your manager for helping in open source! looking forward to this

No responses so far internally from the qemu team, so I opened up an issue at https://github.com/multiarch/qemu-user-static/issues/129

No responses so far internally from the qemu team, so I opened up an issue at https://github.com/multiarch/qemu-user-static/issues/129

I made some progress here: https://lists.nongnu.org/archive/html/qemu-s390x/2021-02/msg00097.html
It looks like taking some time to solve this problem.

WIP on upstream: https://gitlab.com/qemu-project/qemu/-/issues/319

The patch has been merged and the corresponding issue has been also closed: https://gitlab.com/qemu-project/qemu/-/issues/319
→ tried and confirmed the success with the qemu 6.1.0-rc2 (https://gitlab.com/qemu-project/qemu/-/tree/v6.1.0-rc2) where the patch is applied:
$ # build the qemu-user-static local docker image named 'localhost:latest' from the qemu 6.1.0-rc2
$ docker run --rm --privileged localhost:latest --reset -p yes
$ # replace 'aarch64' with 's390x' (see https://github.com/openzipkin/docker-java/blob/master/Dockerfile#L58)
$ docker buildx build --progress=plain --platform linux/s390x . --build-arg java_version=15.0.4_p5-r0

The patch has been applied to the latest http://ftp.de.debian.org/debian/pool/main/q/qemu/qemu-user-static_6.1+dfsg-1_amd64.deb and the qemu-user-static image has been updated on the 26th of August by https://github.com/multiarch/qemu-user-static/pull/153. It is confirmed that the following instructions were successfully building the docker image:
$ # install a buildx feature
$ export DOCKER_BUILDKIT=1
$ docker build --platform=local -o . git://github.com/docker/buildx
$ mkdir -p ~/.docker/cli-plugins
$ mv buildx ~/.docker/cli-plugins/docker-buildx
$ # install qemu-user-static
$ docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
$ # create/use a new builder for multi-arch support
$ docker buildx create --use --name mybuilder
$ docker buildx inspect --bootstrap
$ # docker build
$ git clone https://github.com/openzipkin/docker-java.git
$ cd docker-java
$ sed -i 's/aarch64/s390x/' Dockerfile
$ docker buildx build --progress=plain --platform linux/s390x . --build-arg java_version=15.0.4_p5-r0

looks congruent with https://github.com/openzipkin/docker-alpine/search?q=s390x and the travis build passes which is the important part.
I handed back access as I'm not current on the project anymore, but clicking "ready for review" can give someone else a chance to merge this. and it LGTM
If any real use of this is expected, version updates should happen on docker-alpine and this repo (docker-java) as are way out of date by now.

looks congruent with https://github.com/openzipkin/docker-alpine/search?q=s390x and the travis build passes which is the important part.
I handed back access as I'm not current on the project anymore, but clicking "ready for review" can give someone else a chance to merge this. and it LGTM
If any real use of this is expected, version updates should happen on docker-alpine and this repo (docker-java) as are way out of date by now.

Thanks. But I do not have the ready for review because I do not have a write permission to the repo. (This PR was created by you as reminder and additional consideration for s390x should be taken at https://github.com/openzipkin/docker-java/blob/master/Dockerfile#L58 on top of the current PR if you notice my last comment.) Unfortunately, I cannot make any code contribution atm because there is a legal clearance issue on my side and I am currently waiting for an approval. I would be grateful if you could point me out to a good way of handling this PR before I get the approval. :wink:

@BbolroC sorry I didn't realize this was my PR. you have my permission to copy the same stuff into a PR of your control! Assume this a complete IP grant of the lines here 😎


Integration Test - Release - 2021/12/27 10:02:08

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

#please-close

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#unassign PRMergerTest1

#unassign NonAllowedUser


[vite]: Rollup failed to resolve import "#node-web-compat"

I'm trying to include this library in a Vue 3 project using vite build but seeing the following error.
[vite]: Rollup failed to resolve import "#node-web-compat" from "node_modules/aws-jwt-verify/dist/esm/jwt-rsa.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

Is this expected, and if so, is there a recommended workaround to allow vite to accept this package?

Last I checked, Rollup needs a bit of extra config to make sense of the subpath import. See here: https://github.com/awslabs/aws-jwt-verify/blob/main/tests/vite-app/vite.config.ts

That's what I needed, thanks.


How I set configuration about store data for only 10 minutes in real-time node?

I have some question about retentionTime.
I want to store the data in Real-time node with only 10 minutes.
And I tested below configuration :

{
    "tableName":"loadTest",
    "segmentsConfig" : {
        "retentionTimeUnit":"MINUTES",
        "retentionTimeValue":"10",
        "segmentPushFrequency":"daily",
        "segmentPushType":"APPEND",
        "replication" : "1",
        "schemaName" : "loadTest",
        "timeColumnName" : "time",
        "timeType" : "MILLISECONDS",
        "segmentAssignmentStrategy" : "BalanceNumSegmentAssignmentStrategy"
    },
    "tableIndexConfig" : {
        "loadMode"  : "HEAP",
        "lazyLoad"  : "false",
                "streamConfigs": {
                        "streamType": "kafka",
                        "stream.kafka.consumer.type": "highLevel",
                        "stream.kafka.topic.name": "loadTest",
                        "stream.kafka.decoder.class.name": "com.linkedin.pinot.core.realtime.impl.kafka.KafkaJSONMessageDecoder",
                        "stream.kafka.zk.broker.url": "localhost:2181",
                        "stream.kafka.hlc.zk.connect.string": "localhost:2181"
                }
    },
    "tableType":"REALTIME",
        "tenants" : {
                "broker":"brokerOne",
                "server":"serverOne"
        },
    "metadata": {
    }
}

An error had occurred.

2015/06/24 17:18:53.593 ERROR [com.linkedin.pinot.controller.helix.core.retention.RetentionManager] [] Error creating TimeRetentionStrategy for table: loadTest_REALTIME, Exception: java.lang.NullPointerException

Can you explain about retention configurations?
How I set configuration about store data for only 10 minutes in real-time node?

Hey @1teed the issue is that the realtime flush time and size by default is 1hour and 5M documents respectively, you should add the following 2 properties to the stream configs ...
"realtime.segment.flush.threshold.time" : "3600000",
"realtime.segment.flush.threshold.size" : "50000"
and set the flush time to something smaller than 10 minutes, and try it out again.
Also remember to pull the latest.


move arnim to the end of the post

part of #205

@damianavila I think this has already been merged and can be closed :)

@damianavila I think this has already been merged and can be closed :)

Yep, I was just adding a reviewer post-merge to keep track of things in our internal system, sorry about the noise!


[WIP] Adding axi lite top

This is a version of BP which is AXI-lite master only.  TODO: Make single AXI bus configuration option by having internal crossbar

Hi @flaviens sorry for the delay! I have identified the burst issue with the AXI lite top. There is a minor fix I’ll try to get to in the next week. I’ll let you know when it’s updated and I’d appreciate you trying it out!

Cool! Does this relate to that issue?

Yep same issue!

@flaviens Sorry for the delay again! I've updated the AXIL master to handle bursts properly, which should 🤞 fix the issue that you're seeing

Hi Dan,
Thank you very much for the fixes!
Indeed the problem disappears.
However, I still have issues running simple code. If the first instruction is an infinite look it runs fine, but as soon as I add some nops before the infinite loop, the CPU ends up jumping to address 0.
Have you also observes such behaviors?
Thanks!
Flavien

I dug a bit more into the waveforms. The observation is the following:

The bursts are 8 instructions long but in a single burst, the address does not change (the exact same 2 instructions (64 bits)) are fetched 8 times in a row. Apparently only the first of two instruction is executed.
Once a fetch burst is done, the PC increases by 0x40, so apparently 7 of 8 instructions are ignored.

I made a quick experiment where I inserted 7 nops after each instruction. It does not run perfectly, but apparently it already ran some instructions.
Let me know if I can help.

Hi Dan, thanks for the update! Is the branch ready for a retry already?

Hi Dan, thanks for the update! Is the branch ready for a retry already?

Yep! Think this should be good to go

Thanks! I'm having some difficulties with the parametrization (the repo defines are unfortunately inadapted to search by name). Specifically, I'm stumbling into the error  data width and Bedrock fill width must match (probably 64b)., where AXI Lite width is 64 bits but Bedrock width is 128. How to set the bedrock fill width to the correct value properly?

Sorry @flaviens that's a spurious warning! We support different fill widths, I've removed the warning (make sure to update to latest BP to ensure compatibility)

I'm pretty sure this should work, so I'm going to go ahead and merge as part of housekeeping. Please keep me posted if you discover anymore issues @flaviens !


RSS Link Is Missing

Hi
I have generated a RSS feed using the hexo-generator-feed and adding its location in the _config.yml. However there isn't any icon or link to the feed in the generated site. I guess it's meant to show up in the header:
layout/_partial/header.ejs:
    <% if (theme.rss){ %>
      <a id="nav-rss-link" class="nav-icon" href="<%- theme.rss %>" title="<%= __('rss_feed') %>">
    <% } %>

my blog: https://mehranbaghi.com/
Feed: https://mehranbaghi.com/atom.xml

@Mehran-Baghi thanks, done.

Thank you.
One more place to fix: Link is not inline nor has the same color (grey-bold) in the articles (posts) headers.
Suggestion: I think it makes more sense for RSS link to be in the right hand float:right.

@Mehran-Baghi Thanks, welcome a PR


Unhandled Home Assistant entity

Almond Server v1.7.2 - Locally hosted.
Home Assistant 0.103.3
I am seeing a continuous stream of Unhandled entities in the almond log.
Does this point to a problem with my configuration or is there a way to filter Unhandled entities.
I cannot find any reference to this kind of report in the documentation.
Here is a very small log sample.
Unhandled Home Assistant entity sensor.xxxxxxxx with domain sensor
Unhandled Home Assistant entity binary_sensor.xxxxxxxx with domain binary_sensor
Unhandled Home Assistant entity group.xxxxxxxx with domain group

Any suggestion on how to filter out these reports? Or even a starting point on investigating them?
I am assuming these are just entities that are not yet recognised by almond, but they are outputting constantly in the logs.

Thanks for the bug report, yeah this is just a spammy debugging log about unsupported features, and there is no problem for your configuration. I opened a PR to make it quieter.
(OTOH, if you would like to have Almond support those entities, we have a guide at https://almond.stanford.edu/doc/home-assistant-integration.md - we'd love some help!)

Thanks for the PR and I will definitely be taking a look at the link.

Your PR appear to have solved the issue. Closing.


Committing a byzantine violation without declaring a validator on-chain will cause a chain halt

The function process_evidence is called in the staking component's begin_block whenever a validator commits a byzantine violation. It attempts to look up the validator in the chain's mapping from tendermint consensus key to validator identity key, and then if this is successful, it tombstones the validator in the penumbra chain state.
https://github.com/penumbra-zone/penumbra/blob/43768e74c1e4a6bd8280dd3faeb487b791b49fc0/crates/core/component/stake/src/component.rs#L859-L867
However, notice above that this method is fallible: if the validator's consensus key cannot be found in the lookup table from consensus key to validator identity, it returns Err. This function is called in begin_block like so:
https://github.com/penumbra-zone/penumbra/blob/43768e74c1e4a6bd8280dd3faeb487b791b49fc0/crates/core/component/stake/src/component.rs#L941-L945
This unwrap means that if a validator commits a byzantine fault while they are not known to the penumbra state, they will trigger a panic on every node, halting the chain. This is possible to do, because being a validator according to tendermint and being a validator according to penumbra are not the same thing: if you configure tendermint to run in validator mode, it will begin to sign blocks before you ever upload a validator definition.
The solution here is straightforward: ignore byzantine violations from unknown validators in process_evidence — it should be infallible. This is sound because a validator that is unknown to the chain cannot have more than zero stake delegated to it, and so cannot be slashed.

@zbuc did your unwrap-related changes already fix this by chance?

@zbuc did your unwrap-related changes already fix this by chance?

No, the issue still exists


MAC hotkeys for radar, longterm and forecast uses metakey. It is in conflict with global hotkeys

uses ctrl and shift now


add new format sqldatabase

specifically im working with snowflake but would love to be able to select a table, or set of tables as a format source from my data warehouse

I know you were technically first, but this is a duplicate of #94, I said what I think about this there.


UI: codes appear too cramped to line numbers

Gogs version (or commit ref): 2016 Gogs Version: <IP_ADDRESS>7 (latest)
Git version: git version 1.9.1
Operating system: Linux 14.04.1-Ubuntu x86_64
Database:

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Description
I think codes are too close to the line numbers. For example:

I think (following GitHub's UI design) equal padding to the left (of lines-code class) as much as there are pixels to the padding to the right (of lines-num class).

Should I make a pull request (if my commit is acceptable)?

Thanks, but I think you patch does not fix anything or maybe I test it wrongly. Can you take a screenshot?

Thanks for the screenshot, but the final result on DOM does not seem line number has equal padding?

@neolit123 Thanks!
The 10px padding on left and right looks much better based on the following addition:
.lines-num {
  0 10px 0 0 !important;
}

.lines-code {
  0 0 0 10px !important;
}

@initbar, github also has the min-width: 50px; for the line number area (e.g. .lines-num).

@neolit123 Of course - I think although the min-width: 50px doesn't affect the structure initially, but useful for reduced vw.
I've made minor adjustments to the colors so that the top bar and line background doesn't look flushed out from the global "white" theme.
.ui.attached.header {
    background-color: #fefefe; /* (changed from) background: #f0f0f0 */
}

.repository.file.list #file-content .code-view .lines-num {
    vertical-align: top;
    text-align: right;
    color: #999;
    background-color: #fafafa; /* (changed from) background: #f5f5f5 */
    width: 1%;
    min-width: 50px; /* (added) */
}

/* (added) */
.lines-num {
    padding: 0 10px 0 0 !important;
    border: solid #eee;
    border-width: 0 1px 0 0;
}

/* (added)
  this is for the event when cursor is hovering over the line numbers.
 */
.lines-num *:hover {
    color: #0a0a0a;
}

/* (added) */
.lines-code {
  padding: 0 0 0 10px !important;
}

Before:

After:

And enhanced top 3 buttons:
/* will be changed for more direct pointer to top 3 buttons */
.ui.button {
    background-color: #fefefe;  /* (changed from) background: #e0e1e2; */
    border: solid #e0e0e0;  /* (changed from) border: none; */
    border-width: 1px;  /* (added) */
    color: rgba(0,0,0,0.9);  /* (changed from) color: rgba(0,0,0,.6); */
}

Before:

After:

@initbar Thanks! But we need to do one thing at a time.
You can propose a PR about equal padding first, after that one is merged, then we can think about other changes.

@Unknwon Got it - just one question: should I edit and commit just the appropriate .less files and you'll generate the resulting .css files before the release? Or should I generate, minify, and commit both .less and .css files to the PR?

@initbar you can generate the gogs.css file without minified as you can tell.

@Unknwon Sounds good I'll make the PR later today

Oh my goodness.. I'm so sorry about the messy references to this Issue - I've made a mistake with committing and didn't realize the reference was to this page..
The PR should only deal with the latest commit f027c3c and the first two 988fa2c and bde6661 shouldn't affect with merging.
Once again sorry for the messy references :(

It should be good now.


Minimum Node version upgrade released as a patch

Have you read the Tutorials?
n/a
Have you read the FAQ and checked for duplicate open issues?
n/a
What version of Shaka Player are you using?
3.3.13
Please ask your question
Hey there, we recently upgraded from v3.3.4 to v3.3.13 and we found out that, starting from this commit, Shaka seems to require at least Node v14.
Our project uses Node v12 and yarn, which validates engines.node. If node version does not match, it prevents some dependencies from getting installed. This actually forces us to upgrade to Node v14 (not a bad thing, actually, but it messes up our plans and requirements), hence this seems to be a breaking change that got released as a patch.
$ yarn install
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14". Got "12.22.7"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

My first thought was that this property got mistaken as a "project-only" property, just for maintainers.
Is there a specific reason this have been changed and released as a patch?
Thank you very much!

Since node is merely a dev dependency, the node version doesn't affect the backward compatibility or API of the library itself.  Therefore it wasn't considered a "breaking" change at the time.
I'm honestly not sure from the commit history why the minimum node version was changed at the same time.  There should have at least been a mention in the commit or the PR, but there wasn't.  So perhaps it was a mistake.
If you revert the minimum node version to 12, can we still npm install all of Shaka Player's dev deps?

Hey @joeyparrish, thanks for your reply. I'm actually not very sure. I mean, I'm experiencing some "stucking" issues with installing eme-encryption-scheme-polyfill on both Mac M1 and Mac Intel and I'm not understanding the reason. Could you try too perhaps? Maybe you are luckier than me.

Hey @joeyparrish, I've asked a colleague of mine to do the same test and these are the results:

npm install without deleting package-lock.json -> OK
npm install with deleting package-lock.json -> OK
yarn install -> KO.

yarn found that jsdoc requires klaw, which requires node >= 14. So perhaps this might be the reason...

Well, since nodejs is a dev dependency, and not a runtime dependency, it is not a breaking change to update it IMO.  It was done 4 months ago, and reverting it doesn't work.  So I think we'll have to live with it and update the docs to match.
Sorry for the inconvenience!


Payload decoding update

When decoding a payload that has no recipients, return an empty list without further inspection of the byte buffer.
This reduces the need to calling methods to determine ahead of time
which of the decode methods should be called.

Codecov Report

Merging #501 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
+ Coverage     99.38%   99.38%   +<.01%
- Complexity     1260     1261       +1
============================================
  Files           217      217
  Lines          4070     4072       +2
  Branches        213      214       +1
============================================
+ Hits           4045     4047       +2
  Misses            5        5
  Partials         20       20

Impacted Files
Coverage Δ
Complexity Δ

...quorum/tessera/transaction/PayloadEncoderImpl.java
98.93% <100%> (+0.02%)
11 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b2053...438cc59. Read the comment docs.


[DX11] Escape from Tarkov crashes while loading the "Lighthouse" map since DXVK 1.10.1.

The game Escape from Tarkov crashes while loading the "Lighthouse" map since commit 48046e009c9d3d8bd4f8128d4e893990908c2819. The crash occurs during the "loading loot" section in the loading screen and I am not aware of a workaround via game or DXVK options. Versions before that commit work perfectly fine.
Software information
Game: Escape from Tarkov
Settings: Any
System information

GPU: AMD Radeon RX 6700 XT
Driver: Mesa 22.3.1
Wine version: lutris-7.2-2-x86_64
DXVK version: 1.10.1+ / Commit 48046e009c9d3d8bd4f8128d4e893990908c2819

Apitrace files
Since the game uses BattlEye and blocks additional DLLs in the game folder on Windows, the traces had to be done on Linux. It also crashes at an earlier point in the loading screen when doing an apitrace and I'm not sure if that's a problem. Just to be safe, I made both a broken (release 1.10.1) and a working (release 1.10) trace. WineD3D is completely broken in that game, so I wasn't able to use that for traces.

Broken (1.10.1): https://drive.google.com/file/d/1nS1RMqll5dI-3wy2xyjx87rlDrKdthux
Working (1.10): https://drive.google.com/file/d/1Q0OYukx9tchQP-usOMMexlKgsJ4Ua6M9

Logs (first bad commit)

d3d11.log: EscapeFromTarkov_d3d11.log
dxgi.log: EscapeFromTarkov_dxgi.log

Logs (last good commit)

d3d11.log: EscapeFromTarkov_d3d11.log
dxgi.log: EscapeFromTarkov_dxgi.log

Video examples
Crash (first bad commit): https://youtu.be/FGA2IluBIGg
Working (last good commit): https://youtu.be/PFGNbzPyf1I

That makes sense. It does indeed work when using Proton 7 as well as wine builds in Lutris that are based on Proton, such as lutris-GE-Proton7-33-x86_64. I should have checked that beforehand, my bad.
However, is it not possible to add checks in DXVK, to ensure it at least does not crash on versions that don't have it? It clearly works on DXVK versions without it at all.

Proton 7 does not have the shared resources wine patches yet, only experimental. So it might be some kind of issue with the lutris wine.

@Vinjul1704 Am i correct in that this was a solved issue when not using lutris wine?

@Vinjul1704 friendly ping

Sorry, I completely missed the first ping. I believe so, yes, but I can't test it myself currently. I'll ask some others if they have time to confirm it though.

@Vinjul1704 Was this able to be confirmed?

It seems to happen for me too, sadly. Loading into Lighthouse crashes the game (it used to work fine), loading into Streets of Tarkov map works fine.
Can't test it with different Wine version right now, as it only works for me lutris-GE-Proton-8.4 for some reason :thinking: …

On a fresh install, it does indeed crash when using the older lutris-7.2-2 wine version. Using a newer version, like wine-ge-25, works fine.

Okay, I tried with the new Wine version, it seems to load, so I guess it might be fixed upstream, or is dependant on some patches that are applied by some Wine forks that may correlate with something on DXVK?

(same installation, just replaced the Wine version to the one I compiled today)


Vault.write overwrite old secret to new

Vault.write overwrite old secret to new

unuseful issue; Please add information if you'd like it to be addressed.


PhpdocTrimConsecutiveBlankLineSeparationFixer - must run after AlignMultilineCommentFixer

Your test prove the priority issue, however after testing I'm not sure why this dependency is here based on your example. Can you talk me through it?

For the example:
<?php
/**
 * foo
 *

 * bar
 */

first fixer - align_multiline_comment - "aligns" the empty line, which in this case means making it  *.

Thank you @kubawerlos.


Add prompt to overwrite existing application

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
When installing an application that has an existing file, prompt to overwrite. I do not mean overwrite an existing formula/brew install, but usually leftovers from a brew remove. Example:
==> Installing Cask emacs-mac
==> Purging files for version emacs-28.2-mac-9.1 of Cask emacs-mac
Error: It seems there is already an App at '/Applications/Emacs.app'.

shows after
brew remove emacs-mac
brew install --cask emacs-mac

What is the motivation for the feature?
I would like it if I could just have brew overwrite the artifact.
How will the feature be relevant to at least 90% of Homebrew users?
I'm sure there are plenty of formulas that leave artifacts after removal, and so reinstallation shouldn't require manual cleanup.
What alternatives to the feature have been considered?
Manual removal is tedious and less pleasurable to the user.

Have you tried
brew install --overwrite --cask emacs-mac

?

Or brew reinstall --force emacs-mac.
There's multiple workarounds so passing on this.

Ah, I was unfamiliar with those options @carlocab @MikeMcQuaid thanks for the info & apologies!


Deploy using github pages

Update README file by just-

[x] Add deployed site URL in README file

Added deployed link


Update sawtooth_app_state.go

Signed-off-by: konsmosc<EMAIL_ADDRESS>

Please update commits in this PR (do not create a new PR) with a better commit message. See:
https://chris.beams.io/posts/git-commit/

Done

I have made the commit message better here:
[https://github.com/hyperledger/sawtooth-seth/commit/3089c16e518fa8040ada6f6eb2855944c08f4ac8]
Is it something else that I have to do @vaporos ??

Hey, this looks good now, but you will need to rebase on master, to pickup some Rust dependency changes.

Hey, this looks good now, but you will need to rebase on master, to pickup some Rust dependency changes.

I think now it should be fine, isn't it?


Adding GitHub action workflow for PR validation

The workflow checks consist of following steps-

Should check for the PR Description in the pull request
Check for the issue number, if the PR is not addressing any issue it should include Fixes #NEW

@DeadmanAbir
Pls assign me this issue give me labels like gssoc-extd,hacktoberfest,level3

The workflow checks consist of following steps-

Should check for the PR Description in the pull request
Check for the issue number, if the PR is not addressing any issue it should include Fixes #NEW

@DeadmanAbir Pls assign me this issue give me labels like gssoc-extd,hacktoberfest,level3

take it


Add Star Track to template list

We should add phonegap-app-star-track to the template list.

Merged in!


Inkwell Ripple effect doesn't work on stack

Inkwell ripple effect is not visible on stack items.
Add icon on red container doesn't show ripple effect but the Add icon which is outside of stack seems to show ripple effect
Steps to reproduce:

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Stack(
              alignment: AlignmentDirectional.center,
              children: [
                Container(
                  height: 300,
                  width: 300,
                  color: Colors.red,
                ),
                Center(
                  child: InkWell(
                    hoverColor: Colors.grey[400],
                    borderRadius: BorderRadius.circular(50),
                    child: Container(
                      height: 45,
                      width: 45,
                      decoration: BoxDecoration(shape: BoxShape.circle),
                      child: Icon(
                        Icons.add,
                        size: 30,
                      ),
                    ),
                    onTap: () {},
                  ),
                ),
              ],
            ),
            InkWell(
              hoverColor: Colors.grey[400],
              borderRadius: BorderRadius.circular(50),
              child: Container(
                height: 45,
                width: 45,
                decoration: BoxDecoration(shape: BoxShape.circle),
                child: Icon(
                  Icons.add,
                  size: 30,
                ),
              ),
              onTap: () {},
            ),
          ],
        ),
      ),
    );
  }
}

flutter doctor log
[√] Flutter (Channel beta, 1.22.0, on Microsoft Windows [Version 10.0.18363.1082], locale en-IN)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
[√] Chrome - develop for the web
[√] Android Studio (version 4.0)
[√] VS Code (version 1.49.3)
[√] Connected device (4 available)

• No issues found!

@Baluds
just wrap the inkwell in a widget with fixed size

sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(
        home: MyHomePage(),
      );
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) => Material(
        child: Stack(
          alignment: AlignmentDirectional.center,
          children: [
            Center(
              child: SizedBox(
                height: MediaQuery.of(context).size.height,
                width: MediaQuery.of(context).size.width,
                child: InkWell(
                  hoverColor: Colors.grey[400],
                  borderRadius: BorderRadius.circular(50),
                  child: Container(
                    height: 45,
                    width: 45,
                    decoration: BoxDecoration(shape: BoxShape.circle),
                    child: Icon(
                      Icons.add,
                      size: 30,
                    ),
                  ),
                  onTap: () {},
                ),
              ),
            ),
          ],
        ),
      );
}

Wrap your inkwell with material

Wrap your inkwell with material

worked wrapped with material and assigned color property of material to transparent. Thank you

@Baluds
just wrap the inkwell in a widget with fixed size
sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(
        home: MyHomePage(),
      );
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) => Material(
        child: Stack(
          alignment: AlignmentDirectional.center,
          children: [
            Center(
              child: SizedBox(
                height: MediaQuery.of(context).size.height,
                width: MediaQuery.of(context).size.width,
                child: InkWell(
                  hoverColor: Colors.grey[400],
                  borderRadius: BorderRadius.circular(50),
                  child: Container(
                    height: 45,
                    width: 45,
                    decoration: BoxDecoration(shape: BoxShape.circle),
                    child: Icon(
                      Icons.add,
                      size: 30,
                    ),
                  ),
                  onTap: () {},
                ),
              ),
            ),
          ],
        ),
      );
}

Tried it still if the fixed size is smaller than the stack element it doesnt show

Wrap your inkwell with material

But i still didn't understand, why was their need to use material . Normally ripple should be present right?

Wrap your inkwell with material

But i still didn't understand, why was their need to use material . Normally ripple should be present right?

Check this https://stackoverflow.com/questions/45424621/inkwell-not-showing-ripple-effect

Wrap your inkwell with material

But i still didn't understand, why was their need to use material . Normally ripple should be present right?

Check this https://stackoverflow.com/questions/45424621/inkwell-not-showing-ripple-effect

Thank you 👍


Hide entire layer

Complements #25 which is just hiding a set of cells.

Close this in favor of #25, for now.


Playing Ambisonic File with Resonace Audio Web SDK

Hi,
This is my first time using Resonance Audio Web SDK and I'm unsure of how to play an ambisonic file with resonance audio. I followed the tutorial to play a monophonic file and changed "resonanceAudioScene.output.connect(audioContext.destination)" to "resonanceAudioScene.ambisonicOutput.connect(audioContext.destination)" and then I changed removed all the code for creating an audio input source.
So I remove:
let source = resonanceAudioScene.createSource();
audioElementSource.connect(source.input);
source.setPosition(-0.707, -0.707, 0);
And replaced it with:
audioElementSource.connect(resonanceAudioScene.ambisonicInput); //to add the Ambisonic soundfield.
Am I going about this correctly? Or am I missing something? Thanks for your help.

@prioleaud Have you tried Omnitone? That might be a more appropriate solution.

@brianchirls No I haven't tried it. Thanks for the suggestion! In what way, do you think it will be better suited?

Since Resonance Audio is powered by Omnitone, is there a way to access the Omnitone object from Resonance Audio, or do you have to load it separately? It would be great if there was some documentation on creating an ambisonic node and connecting it to the audioContext.

It seems as though all nodes created with .createMediaElementSource() are one channel mono.  I'm not sure how to feed the ambisonic input a 4-channel file.  That seems to be the issue.  Furthermore, it seems that regular single source nodes are converted to mono as well even if your  is a stereo file.

My component kit is complicated because it has far more features than just being an ambisonic player.  That said, if you are just trying to implement playing ambisonic files, you need to include a function that does this (from resonance-audio-room component):
  connectBuffer() {

    //Create 4 channel splitter
    this.splitter = this.resonanceAudioContext.createChannelSplitter(4);

    //Connect bufferNode to splitter
    this.bufferNode.connect(this.splitter)

    //Create merger as ambisonicSourceNode
    this.ambisonicSourceNode = this.resonanceAudioContext.createChannelMerger()

    //Connect splitter to ambisonicSourceNode
    this.splitter.connect(this.ambisonicSourceNode, 0, 0)
    this.splitter.connect(this.ambisonicSourceNode, 1, 1)
    this.splitter.connect(this.ambisonicSourceNode, 2, 2)
    this.splitter.connect(this.ambisonicSourceNode, 3, 3)

    //Setup ambisonicInput to receive source
    this.resonanceAudioScene.ambisonicInput.channelInterpretation = "discrete"
    this.resonanceAudioScene.ambisonicInput.channelCountMode = "clamped-max"
    this.resonanceAudioScene.ambisonicInput.channelCount = 4

    //Connect ambisonicSourceNode to ambisonicInput
    this.ambisonicSourceNode.connect(this.resonanceAudioScene.ambisonicInput)

    //Set up
    this.resonanceAudioScene.ambisonicInput.gain.value = this.data.gain

    if (this.data.loop) {
      this.bufferNode.loop = true
    }
    if (this.data.autoplay && this.resonanceAudioContext.state === "running") {
      this.playSound()
    }
    this.connectedSrc = true
  }

Let me know if you have any questions about this.

As suggested by @brianchirls, you'd be better off using Omnitone if the goal is to simply play an ambisonic media. (FOA, SOA, TOA).
@prioleaud Please feel free to follow up or close the issue if needed.

At least some of the other Resonance implementations, iOS for example, seem to have playing sound fields as a feature. The confusion here is that the web SDK doesn't, though it seems to include internals to do so.

@jwarchol That makes sense. Thanks for the clarification. So the solution is to expose the Omnitone decoder as a part of API?

Perhaps. I think @prioleaud's original notion of doing something like audioElementSource.connect(resonanceAudioScene.ambisonicInput); feels good, if that sort of an interface is possible.


textDocument/formatting is not supported

Language server as per LSP documentation can support textDocument/formatting method, which is called in any LS clients (mainly in editors) whenever whole file formatting is needed.
At the moment, this plugin has formatting implemented as a VSCode-only feature and not a part of LSP specification, which results in failure to format Tact code when the language server of this plugin is used independently (i.e. here) — a message such as this is shown: "textDocument/formatting not supported for tact".
The solution would be to register formatting capabilities and handle the textDocument/formatting request.
Additionally, there are two similar methods specified in LSP, which may also be handled to further improve UX:

textDocument/rangeFormatting
textDocument/onTypeFormatting

I assume that this part can be done within grants-and-bounties task. PR is welcome.

@logvik Good suggestion, will do!

Resolved at #38


Grav is giving error during deploying

Hi Paul,
I was deploying the website locally before to publish on the server, but I'm getting the following error:

Server Error

Sorry, something went terribly wrong!
E_WARNING - require_once(): \RocketTheme\Toolbox\StreamWrapper\ReadOnlyStream::stream_set_option is not implemented!
For further details please review your logs/ folder, or enable displaying of errors in your system configuration.

In user/themes I've 3 folders:
mytheme
quark
quark-open-publishing
mytheme is inheriting from quark-open-publishing and during a trial and error I discovered that mytheme.php is the guilty. By removing it , the site works. This is the content:

<?php
namespace Grav\Theme;

use Grav\Common\Theme;

class myTheme extends QuarkOpenPublishing
{
}
?>

do you have some ideas?

Hi @ghtmtt , can you give me a few more details of the site you are trying to deploy? Was this a new skeleton or an existing site updated? What version of Grav and PHP are you running?

Right, sorry for the few information.
Grav Package Manager 1.6.22
PHP 7.4.3 (cli) (built: Feb 23 2020 07:07:28) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
on a Linux Debian Sid computer.
The webiste (running) is this: https://www.faunalia.eu/it/
I created the site based on both quark and quark-open-publishing. Just added some css and layout stuff.

I've seen some mentions of possible issues with PHP 7.4.x, can you try the site with an earlier version of PHP?

trying with another version of PHP can be a little bit hard. Have to adapt the whole ecosystem..
that's strange that by removing one single file it works smoothly..

By using an inherited theme other routines might be called etc. I notice you posted an issue on Grav's repo to (https://github.com/getgrav/grav/issues/2850) so let's see if that is responded to.

yep, let's see. Thanks for the quick answer.


Dataset Unavailable

I have used the huggingFace API to fetch the dataset.
On 23 August 2023
When the api is fetched it returns the error: {"error":"The server is busier than usual and the response is not ready yet. Please retry later."}
Just a few days before today (around 15 August, 2023) the api worked perfectly without any errors.
I rely heavily on the availability of the dataset. It is critical that the server is back running in no time.
When will the issue be fixed. If this is not the right place to post this issue, then where is the most appropriate place.

The appropriate place is the huggingface API


Use different query to get tenantId

az aks show --name $clusterName --resource-group $resourceGroupName --query aadProfile.tenantId -o tsv returns me empty value
getting tenantId seems more reliable from identity.tenantId

@Nickomang

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @polinaouk, thanks for your feedback! I tested the deployment and confirmed your proposed changes. As I am working on doc updates in a separate PR, I will close this one. I'm addressing your changes in my separate PR. Thank you again!
#please-close


Codec vectors update

GP 0.4.*

Added "segment root lookup" dictionary to "work report"
WR "prerequisites" is now a set and not an option

GP 0.5

Add "exports count" to "work package spec"
Extrinsic items order changed
Add tickets entropy to epoch marker

According to the set encoding rule in GP, it seems we don't have length discriminator.
In the test vector, refine_context.bin gives us:
0xc0564c5e0de0942589df4343ad1956da66797240e2a2f2d6f8116b5047768986f6967658df626fa39cbfb6014b50196d23bc2cfbfa71a7591ca7715472dd2b489329de635d4bbb8c47cdccbbc1285e48bf9dbad365af44b205343e99dea298f360751ab5b251361fbfd3ad5b0e84f051ccece6b00830aed31a5354e00b20b9ed2100000000

Shouldn't we remove the last 1 byte 0x00?
It made sense when it was representing the old Option::None, but now I think we should remove it.
Maybe currently it is encoded following variable byte sequence encoding rather than set encoding, which also gives 0x00 for empty vec..

In GP 0.5.0, extrinsics are encoded in the following order:
tickets -> preimages -> guarantees -> assurances -> disputes
While the test vector has:
tickets -> disputes -> preimages -> assurances -> guarantees

According to the set encoding rule in GP, it seems we don't have length discriminator.

Are you talking about prerequisites?

Are you talking about prerequisites?

Yes!

As per eq.311, prerequisites requires length prefix.

Ahh.. I missed it, my bad. Thanks for clarifying!

In GP 0.5.0, extrinsics are encoded in the following order: tickets -> preimages -> guarantees -> assurances -> disputes
While the test vector has: tickets -> disputes -> preimages -> assurances -> guarantees

https://github.com/w3f/jamtestvectors/pull/19/commits/01528ae99f307279a13d9d05d3c492b73fc5e11b

seems epoch marker is missing the second entropy, in equation 5.10 (v0.5.0)

seems epoch marker is missing the second entropy, in equation 5.10 (v0.5.0)

https://github.com/w3f/jamtestvectors/pull/19/commits/b00799a5299dd74f7646384f295e131109e3c106

I'm sorry

seems epoch marker is missing the second entropy, in equation 5.10 (v0.5.0)

but what second entropy are we talking about ? there is no second entropy in He in 5.10 for me (0.5.0).

I'm sorry

seems epoch marker is missing the second entropy, in equation 5.10 (v0.5.0)

but what second entropy are we talking about ? there is no second entropy in He in 5.10 for me (0.5.0).

Disregard all above. I somehow have a mid-0.5.0 (not tagged) without the second entropy.


Dev/1.1.2

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (b077db2) 66.43% compared to head (a970ab0) 66.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   66.43%   66.42%   -0.01%
==========================================
  Files          11       11
  Lines        4379     4378       -1
  Branches      861      756     -105
==========================================
- Hits         2909     2908       -1
  Misses       1301     1301
  Partials      169      169

Impacted Files
Coverage Δ

dtool_ibeis/__init__.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update AzureFeed value

Change is not live yet so starting with a draft
Related to https://github.com/dotnet/install-scripts/pull/557 and https://github.com/dotnet/core/issues/9671

Internal previews

📄 File
🔗 Preview link

docs/core/tools/dotnet-install-script.md
dotnet-install scripts reference

@Thraka @BillWagner @gewarren @CamSoper @tdykstra @Rick-Anderson
Hey folks. We have a strong need to get this content merged and deployed.


Skip file picking doesn't work for "Image preview" option

Pretty much the title

It's intended, because there is an option to pick entire folder

Got it. I didn't noticed the folder


install-mac.sh installs OpenSSL with homebrew, but does not find it automatically

The install-mac.sh fails and produces the following error:
CMake Error at /usr/local/Cellar/cmake/3.8.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):   Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the   system variable OPENSSL_ROOT_DIR (missing: OPENSSL_INCLUDE_DIR) Call Stack (most recent call first):   /usr/local/Cellar/cmake/3.8.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)   /usr/local/Cellar/cmake/3.8.2/share/cmake/Modules/FindOpenSSL.cmake:387 (find_package_handle_standard_args)   CMakeLists.txt:8 (find_package)
I had to change cmake .. with cmake -DOPENSSL_ROOT_DIR=/usr/local/Cellar/openssl/1.0.2l -DOPENSSL_LIBRARIES=/usr/local/Cellar/openssl/1.0.2l/lib .. to make the script work as mentioned in #32 .
Can you adjust the script that it automatically detects the openssl root dir?

Looks like this was fixed in 9dc2e6f - thanks for pointing out.


Not able to run ReSeq !!! bool reseq::DataStats::ReadBam

Hi,
I am trying to use ReSeq with the following genome GCF_000005845.2_ASM584v2 and reads SRR490124 downloaded from NCBI but I go an error apparently associated with the bam file.
To generate the bam I used the same command suggested in the Quick start examples:
bowtie2-build GCF_000005845.2_ASM584v2.fa GCF_000005845.2_ASM584v2_DB
bowtie2 -p 32 -X 2000 -x GCF_000005845.2_ASM584v2_DB -1 ./SRR490124_pass_1.fastq.gz  -2 ./SRR490124_pass_2.fastq.gz | samtools sort -@ 4 -o SRR490124.bam -
The sorted bam I got looks good to me:

And to run ReSeq I used the following command and I got this error:
./bin/reseq illuminaPE -j 32 -r ./GCF_000005845.2_ASM584v2_genomic.fasta -b ./SRR490124.bam -1 ./SRR490124_pass_1.fastq.gz -2 ./SRR490124_pass_2.fastq.gz

27-07-22 12:59:04: info:  Running ReSeq version 1.1 in illuminaPE mode
27-07-22 12:59:04: info:  Reading reference from /home/bioinfo/users/niber/phd/coli/MG1655/NC_000913.3/genome/GCF_000005845.2_ASM584v2_genomic.fasta
27-07-22 12:59:04: info:  Read in 1 reference sequences.
27-07-22 12:59:04: info:  Reading mapping from /home/bioinfo/users/niber/phd/coli/MG1655/reads_MG1655/reseq/SRR490124.bam
27-07-22 12:59:04: info:  Storing real data statistics in /home/bioinfo/users/niber/phd/coli/MG1655/reads_MG1655/reseq/SRR490124.bam.reseq
27-07-22 12:59:04: info:  Tiles will be ignored and all statistics will be generated like all reads are from the same tile.
27-07-22 12:59:04: info:  Starting PreRun
27-07-22 12:59:30: info:  Finished PreRun
Total number of reads: 21553358
Read length: 100 - 100
Read length on reference: 82 - 110
Quality: 2 - 40 ( 33-based encoding )
Mapping Quality: 0 - 42
Maximum InDel Length: 18
27-07-22 12:59:30: info:  Detected adapter 2: AGATCGGAAGAGCGTCGTGTAGGGAAAGAGTGTAGATCTCGGTGGTCGCCGTATCATT
27-07-22 12:59:30: info:  Detected adapter 1: AGATCGGAAGAGCACACGTCTGAACTCCAGTCACCAGATCATCTCGTATGCCGTCTTCTGCTTG
27-07-22 12:59:30: info:  Starting main read-in
27-07-22 12:59:31: info:  Read 5% of the reads.
27-07-22 12:59:33: info:  Read 10% of the reads.
27-07-22 12:59:35: info:  Read 15% of the reads.
27-07-22 12:59:37: info:  Read 20% of the reads.
27-07-22 12:59:38: info:  Read 25% of the reads.
27-07-22 12:59:41: info:  Read 30% of the reads.
27-07-22 12:59:43: info:  Read 35% of the reads.
27-07-22 12:59:44: info:  Read 40% of the reads.
27-07-22 12:59:46: info:  Read 45% of the reads.
27-07-22 12:59:48: info:  Read 50% of the reads.
27-07-22 12:59:49: info:  Read 55% of the reads.
27-07-22 12:59:53: info:  Read 60% of the reads.
27-07-22 12:59:54: info:  Read 65% of the reads.
27-07-22 12:59:56: info:  Read 70% of the reads.
27-07-22 12:59:58: info:  Read 75% of the reads.
27-07-22 12:59:59: info:  Read 80% of the reads.
27-07-22 13:00:01: info:  Read 85% of the reads.
27-07-22 13:00:03: info:  Read 90% of the reads.
27-07-22 13:00:04: info:  Read 95% of the reads.
27-07-22 13:00:06: info:  Read 100% of the reads.
27-07-22 13:00:15: info:  Needed to create 465 coverage blocks.
27-07-22 13:00:15: info:  Excluded 100 of 4641652 bases [0%] in the reference due to contig ends and N's over 2 regions.
27-07-22 13:00:15: info:  Finished processing all reads.
27-07-22 13:00:15: info:  Of the 21553358 reads in the file
27-07-22 13:00:15: info:  0 (0%) could be used for all statistics
27-07-22 13:00:15: info:  0 (0%) had too low mapping qualities with adapters detected
27-07-22 13:00:15: info:  0 (0%) had too low mapping qualities without adapters detected
27-07-22 13:00:15: info:  0 (0%) mapped to excluded regions of the reference
27-07-22 13:00:15: info:  21553358 (100%) were mapping too far apart from their partner or in wrong direction
27-07-22 13:00:15: info:  0 (0%) are on reference sequences that are too short
27-07-22 13:00:15: info:  0 (0%) were in an unmapped pair with adapters detected
27-07-22 13:00:15: info:  0 (0%) were in an unmapped pair without adapters detected
!!! bool reseq::DataStats::ReadBam(const char*, const char*, const char*, const string&, reseq::uintSeqLen, reseq::uintNumThreads, bool) [/home/bioinfo/bin/ReSeq/reseq/DataStats.cpp:1257]: error: No reads in the file passed all criteria to be used for the statistics

Could you help me understand how does the program is expecting me to align the reads since in theory the reads I selected are also part of one of the test case?
Thank you!

Hi,
Thank you for reporting this. The filter that filters all your reads:
27-07-22 13:00:15: info: 21553358 (100%) were mapping too far apart from their partner or in wrong direction
Checks if the reads map in the forward-reverse order typical for Illumina paired-end and if they are not further than 2000 apart. Could you look at a few pairs and let me know, what the distances or orientation are, please?

You have a different file name for the reference used in bowtie and the one used in reseq, check they are the same. ?
I've been meaning to look at this so tried 'reseq' out on the data set you used.
I seemed to run it ok and generated output reads. see attached notes and output. (though my bam did not have .1 and .2 appended to qname)
run_output_and_notes.txt

Hi,
Thanks for giving it a look!
At the end was a problem of the reads I downloaded because their name included an extra number to specify the mate pare (e.g. SRR490124.5521767.1 and SRR490124.5521767.2).
Once I removed the extra number in the name of the reads in the sam file ReSeq worked perfectly.
Original bam: >>> samtools view SRR490124-srt.bam | head

Corrected bam: >>> samtools view SRR490124-cor-srt.bam | head

Sorry, that I missed this. The newest version on git also gives warnings when it does not find the other read of a pair.
To fix these files I have python script that also adds the tile information (although by default it is not used, because it does not really improve the result if you are not interested in tile effects and makes it much slower for some datasets):
bowtie2 -p 32 -X 2000 -x my_reference -1 <(reseq-prepare-names.py my_data_1.fq my_data_2.fq) -2 <(reseq-prepare-names.py my_data_2.fq my_data_1.fq) | samtools sort -m 10G -@ 4 -T _tmp -o my_mappings.bam -


Google+ API Shutdown

Google+ API is shutting down on March 9, 2019.  The progressive shutdown begins as early as January!
https://developers.google.com/+/api-shutdown

So far as I know, there are no plans to discontinue plain OAuth 2.0 authentication, so passport-google-oauth2 should continue working, but I would definitely appreciate some confirmation on that.

I've changed those lines to work without Google+ :
https://github.com/mstade/passport-google-oauth2/blob/59253f8449d1200d07aa61e4ae7205f75e175159/lib/oauth2.js#L45-L46 with :
  options.authorizationURL = options.authorizationURL || 'https://accounts.google.com/o/oauth2/v2/auth';
  options.tokenURL = options.tokenURL || 'https://www.googleapis.com/oauth2/v4/token';

https://github.com/mstade/passport-google-oauth2/blob/59253f8449d1200d07aa61e4ae7205f75e175159/lib/oauth2.js#L91 with :
  this._oauth2.get('https://www.googleapis.com/oauth2/v3/userinfo', accessToken, function (err, body, res) {
In my Google Strategy I use "email" not "profile, so I've changed for :
  passport.use('google', new GoogleStrategy({

      clientID: config.google.clientID,
      clientSecret: config.google.clientSecret,
      callbackURL: config.google.callbackURL,
      passReqToCallback : true

    }, (req, accessToken, refreshToken, email, done) => {

Finally, in your routes file you can request like this :
passport.authenticate('google', { scope: ['email'] })
or like this if you need profile (do not forget to add it in your GoogleStrategy callback)
passport.authenticate('google', { scope: ['email', 'profile'] })

Hey guys! are you gonna fix this?

Hey guys
I did this PR based on @jeremiepape advice. I also updated some other field in profile to maximise compatibility between the current one and the new one.
Don't forget that google is shutting down https://www.googleapis.com/plus/v1/people/me on march 8 2019 (tomorrow).
Reviews is welcomed (for example @mstade)

Resolved in #15 – many thanks for the assist @Guisch!


Use /usr/bin/env in fastcopy-chainstate.py

Switch to using .format()

Concept ACK, but please edit the PR description to make it more complete.
The description should be useful also in the absence of the title :-)

I agree in general this is the maintainer tools so the requirements for commit messages are somewhat less stringent than on the main repo. This is simply a "modernize python" thing.
Will test.


Traefik + ExternalDNS + cert-manager + Amazon Route 53

ExternalDNS

https://github.com/kubernetes-sigs/external-dns

Helm charts

https://artifacthub.io/packages/helm/bitnami/external-dns
https://artifacthub.io/packages/helm/external-dns/external-dns

Issues

https://github.com/kubernetes-sigs/external-dns/issues/4292

cert-manager
Issues

Error configuring TLS error: secret xxx does not exist

Related issues

https://github.com/cert-manager/cert-manager/issues/3283
https://github.com/cert-manager/cert-manager/issues/3300

Solution: https://stackoverflow.com/a/78676171/2000548

Done by

https://github.com/hongbo-miao/hongbomiao.com/pull/17733


Add missing commands and attributes for CI

Problem

Missing clusters in simulated app for CI.

Change overview

Add commands and attributes for CI.
Change storage type to external so ZAP doesn't complain about size.

Testing
Generated missing cluster YAML files.

Fast tracking test addition.


[Bug] TableRelation with or filter "|" creates a wrong LookUp filter

Hey,
when a field has a table relation that has an or ("|") filter, it creates a wrong LookUp when the related record fits in the filter that is not in the first place
The below example is taken from BaseApp - BOM Component table:
Field No. has TableRelation with | in the filter

Having an Item that is of type Non-Inventory.

Selecting the Item and making the page non-editable so clicking on the No. field brings up the Item Tile:

The presented LookUp page is for the wrong Item and also Page Inspection shows that the first filter specified in the TableRelation was set:

The whole scenario works fine if the related record would be part of the first filter option.

Hi, this issue is out of scope of for this repository. You should do one of the following:

Open a support request to CSS through the PartnerSource portal
Open a bug in Collaborate
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

As a reminder, this repository only handles issues to do with the compiler or VSCode development experience for AL.


Move handlers and httpd from cmd/ to coordinator/

Move handlers and httpd from src/cmd/services/m3coordinator to src/coordinator.
I've done a find/sed to replace all path references.

Fair point. How do you want to handle versioning? Not sure what is convention here - does a coordinator/api/v1/handler make sense?

I've moved them into /api/v1 for now - seems like some people do it this way and makes sense to me. Tell me if you prefer something else.

Oh yeah, that would have been my recommendation as well :)


Enhancement: Starting volume as a docker parameter

Excellent dockerfile! Can you pull the starting volume value as a docker variable? I think it would make it more convenient for speakers with analogue controls as you could crank up the volume there and set it to say 50 in docker and then adjust it with your phone. As it is now, it's 100 and starts at max volume as soon as you connect.

I'm not really focusing on this project right now. If you find it helpful, feel free to submit a PR and I'll gladly merge it and update the image.


Convert SCD to another Edition

As a COMPAS service user, this US purpose is to convert a given SCL file to another Edition.
As an integrator, I would like to be able to use a SCD from Compas software into old ICT software.
Prerequisites : an existing SCL file.
Inputs
A previous existing SCL file (Mandatory)
The wanted edition
This US is covering the first part of the following functional service as described in the 61850-6:
S61 Previous version(s) and revision(s) export
The name of the exported file is ....
If the SCL file contains data that aren't compatible with target, they are deleted from target file.
Outputs
The output of the service is an new SCL file compatible with selected edition
Error
If the tool could not create an valid SCL file, it should raise an error and create the file.

Hi @legrosjf
Are we working on SCD file or SCL file in general ?

If the tool could not create an valid SCL file, it should raise an error and create the file.

You create a file any way on error ?

Hi @legrosjf
Are we working on SCD file or SCL (ICD,IID,CID,SED ...) file in general ?

If the tool could not create an valid SCL file, it should raise an error and create the file.

You create a file any way on error ?

Why should we limit the scope to SCD files for this code? I think that if there is no contraindications we shouldn't reduce features.
For the creation of result file even if there is some error, I think that it will help to understand errors and to correct them.

Why should we limit the scope to SCD files for this code?

I think you are in the best position to answer to this question. :)
My question is all about the scope. You mentioned indifferently SCL and SCD, hence my question (In the title it's SCD an d the description is SCL & SCD).

I think that it will help to understand errors and to correct them

And error message isn't sufficient?
Assumed, the solution is to create the file (error or no error), then on error what type of file is create? An SCL?
For editor of issue, some time implicit can seem obvious, but it doesn't :). It happens to me as well.
Just want to understand.

Correction of the description of the story to answer to @syllamoh comment:
As a CoMPAS service user, this US purpose is to convert a given SCL file to another Edition.
As an integrator, I would like to be able to use a SCD from CoMPAS software into old ICT software.
As an integrator, I would like to be able to import an IID, CID, ICD file from old ICT software into CoMPAS software.
Prerequisites : an existing SCL file.
Inputs
A previous existing SCL file (Mandatory)
The wanted edition
This US is covering the first part of the following functional service as described in the 61850-6:
S61 Previous version(s) and revision(s) export
The name of the exported file is ....
If the SCL file contains data that aren't compatible with target, they are deleted from target file.
Outputs
The output of the service is an new SCL file compatible with selected edition
Error
If the tool could not create an valid SCL file, it should raise an error and create the file.

About the error handling:
By experience, the error messages from Java XSD validation could be some obscure error messages. The result is an invalid file (same type as the input). Maybe this behavior could be not suitable for end user, only for developer user.


Run aNMM

I am new to MatrchZoo. I wonder how to run aNMM. The docs don't have usage for aNMM. I feel I have to run a script for calculating the bin_sizes for aNMM? But I cannot find where this script lies.
Furthermore, my training data does need to have a format like here:
https://github.com/NTMC-Community/MatchZoo/blob/master/matchzoo/datasets/toy/train.csv
right?
And, where are the batches created? Since you have positive and negative documents for each query, the batch should contain examples with pos and negs samples, right?
How can I load my own data?
Thanks.

@ctrado18 Thanks for the questions!
For the code for generating the bin sum in the interaction matrix, currently you can refer to https://github.com/NTMC-Community/MatchZoo/blob/1.0/data/WikiQA/run_data.sh and https://github.com/NTMC-Community/MatchZoo/blob/1.0/data/WikiQA/gen_binsum4anmm.py in MatchZoo V1.0. As for MatchZoo V2.0, I am preparing another tutorial to demonstrate how to run aNMM on WikiQA data. You can check back later.

In ranking (input a question output one or two answers) like with aNMM or siamese networks or any other ranking deep learning models where you usee a rank loss, is it just enough to have labels with value 0,1 indicating wether the answer is right or false? How many negative examples I need? I just want to learn relevant and irrelevant documents.

@ctrado18 The labels could be binary or multiple different levels in integers deeps on your setting. For WikiQA, the negative examples in the training data are from human annotations. If you use negative sampling to create the negative training data, you can try different settings for the number of negative examples. But this is not needed for data like WikiQA/TRECQA.
You can refer to the code of point/pair/list generator here https://github.com/NTMC-Community/MatchZoo/tree/1.0/matchzoo/inputs

Thanks. I just confused about the relationship of the label (0,1) for a contrastive loss which claculates the loss from a score and not the label. So how does my rank model (any one like aNMM in keras) to relate the label with the corresponding loss?  If I understand your aNMM paper right you are doing so.
Up to now I have no experience in using rank losses in tenroslfow/keras or in general.

@ctrado18 Let's take pointwise ranking loss and pairwise ranking loss as the example. In pointwise ranking loss, you are treating ranking as a special case of classification/regression tasks. Basically you are trying predicting the ground truth label based on the features of  a query/doc pair. However, in pairwise ranking loss, you are trying predicting the relative order of a positive doc and a negative doc given a triple <query, pos_doc, neg_doc>. During training stage, you can generate these triples based on document labels like (0,1). So in general pairwise ranking loss has a better correlation with the final ranking metrics compared with pointwise ranking loss. For listwise ranking loss, it tries optimizing the whole list of documents given a query. So the search space is all the permutations of the list of documents. Most neural ranking models like aNMM/DRMM/MatchPyramid/MV-LSTM adopted a pairwise ranking loss.
If you want to learn these technical details systematically, I recommend the survey on neural ranking models by Prof. Jiafeng Guo (https://arxiv.org/abs/1903.06902) and the survey on LTR by Dr. Tie-yan Liu (https://dl.acm.org/citation.cfm?id=1618304) as great reading resources.

Thanks! I think I am going to understand. I read the papers.
For pointwise ranking you could also have just labels 0 and 1? Or do you have then in your training data just the pairs of query and positive document together with one of multiple (>2) labels?
And in pairwise loss you use the final score from the final layer to compute the loss, instead of using a label, right?
Do you know any simplified code (or a github repo) in keras/tensorflow using a neural model like DSSM shwoing how to build the batches and using a pairwise ranking loss?

@ctrado18 You can refer to the code of point/pair/list generator in MatchZoo 1.0 here
https://github.com/NTMC-Community/MatchZoo/tree/1.0/matchzoo/inputs

In v2  is this the same like pairDataGenator?  I can use this in v2 for aNMM too, right? Where the difference between v1 and v2?Also in v1 there are no examples showig the general usage?
Are there any small example in v1 or v2 showing to run a model with a pairwise loss?

@ctrado18 Currently I suggest you to use the aNMM model in v1. As for v2, I am preparing a tutorial on how to run aNMM. You can check back later. The input data format and model implementations of v1 and v2 are very different. I think you can follow the documentation here https://github.com/NTMC-Community/MatchZoo/tree/1.0 (which is easy to follow) if you want to run aNMM on datasets like WikiQA or your own datasets.

Thanks I will try it with with my own Data!

In pointwise ranking loss, you are treating ranking as a special case of classification/regression tasks. Basically you are trying predicting the ground truth label based on the features of a query/doc pair.

Could this be also binary labels with 0,1? Then you would also add negative examples for each query? Then for me it is difficult to discrimante both point and pairwise since also pointwise would learn to discriminate between negative and positve label? Maybe I am on the wrong rote? :-)

@ctrado18 Yes, it can be binary labels. Think of loss functions like MSE or Cross Entropy. You don't have to sample negative examples for each query. All you need to do is to build batches of training instances according to <q,d> for pointwise ranking or <q, d+, d-> for pairwise ranking to train your model.

I assume that also I can try first aNMM or DSSM with a pointwise loss? Is this possible with the hinge loss?

@yangliuy I see it you can since there is also a classification example. Fine. One question what is the DRMM   PairGenerator?`Why do I need it for aNMM classification? Is it working with normal PairGenerator too?
For aNMM I need to run this bin sum script first to get this hist_file, right? And what is the relation file?
Sorry for those trivial questions.

@ctrado18 You can check the config files under here https://github.com/NTMC-Community/MatchZoo/tree/1.0/examples/wikiqa/config and https://github.com/NTMC-Community/MatchZoo/tree/1.0/examples/QuoraQP/config . For classification, you can refer to the config files of QuoraQP.
Yes, you need to run the binsum script. As for what the relation file is, please find it in the readme file. I suggest you to spend some time reading the readme file and docs, running the examples for WikiQA and Quora, diving in the code before you ask new questions. Many answers are already in the readme file and examples.

I am almost done. But I see that you manually have to give the vocab size? That is a bit hard to find out everytime. Am I right that this is the size of the word_dict?

@datistiquo Yes, you're right.

@Bt for v2 there is no anmm preprocessor so I wnated to create one. But it seems that there is no callback or preprocessing for gernating the bin sums?

@datistiquo Yes, the preprocessing for generating the bin sums in v1 hasn't been added into v2 yet. You are welcome to make contributions on this part!

@yangliuy would I do this with preprocessor or with a callback instead like calculating the mathcing histograms via callback? What way would be suitable for anmm? Is that all to take care for anmm?

I think it should be via callback. But I also need to double verify this. Maybe @faneshion can give you better answers on this.

@datistiquo You can refer to the function for histogram computation here: https://github.com/NTMC-Community/MatchZoo/blob/master/matchzoo/preprocessors/units/matching_histogram.py and https://github.com/NTMC-Community/MatchZoo/blob/master/matchzoo/data_generator/callbacks/histogram.py . This solution may introduce duplicated computation of matching histograms for the same <q,d> pair. You can also try to add it into the preprocessors, which pre-compute the matching histograms as caches to be more efficient.

@yangliuy Isn't it the matching histogram scheme the same as needed for anmm? So you can use it as it is. But I don't know if this will work as the input for DRMM and ANMM (query plus matching matrix) is different?

@datistiquo You can try to run experiments to test this. The main difference is that ANMM will compute the sum of weights in each bin and aggregate them via the feedforward networks and question term attention networks.

@yangliuy I meant it in the way implementing it in the matchzoo framework. Caluclating bin sum is like calculating the histogram. So procedure is doing like DRRM? I just modify the matching histogram to calculate the sums and would train like DRRM just with ANMM model. I just ask if the output of this callback is suited for ANMM since DRRM just want the matching histogram but ANMM want also the query plus the bin sum matrix?!

Yes, you can modify the matching histogram to calculate the sums and train ANMM similar to DRMM. Both ANMM and DRMM need queries as the input. The differences are in the construction process of matching histogram and bim sum matrix. You need to run and debug the code to verify whether the output of this callback function is suitable.

I hope things are working well for you now. I’ll go ahead and close this issue, but I’m happy to continue further discussion whenever needed.


multidimensional arrays result in Can't find field value on result object

This works fine in GraphiQL, but when I use it in Apollo Client I get

Can't find field value on result object $ROOT_QUERY.multidimensional().rows.0."
networkError

Hypothetical Schema
type Table {
    rows: [ [ Cell ] ] # This is causing issues
}
type Cell {
    value: Float
}

Hypothetical JQL
{
  multidimensional() {
    table {
      rows {
        value
      }
    }
  }
}

Hypothetical result
[
  [{ value: 1 }],
  [{ value: 2 }],
  [{ value: 3 }]
]

This works as expected when testing with GraphiQL.
In Apollo client this throws an error.
The issue is made apparent in const value: any = result[resultFieldKey]; because resultFieldKey is value,  but result is an array of Cell types, rather than a single Cell type.
I feel like I tried many alternative query and schema layouts to work around this issue, but none have helped. I've only have a few hours of experience using GraphQL and Apollo, so I will be excited to learn if I'm doing something incorrectly or this is an issue that can be fixed in the client.
Thank you!

I think this is an accidental oversight that will be fixed in Apollo Client 0.5, since we've now refactored to use graphql-anywhere: https://github.com/apollostack/graphql-anywhere
We're hoping to publish a 0.5 preview in the next day or two, I'll make sure to post here.

I can verify that the nested array issue I reported is now working for me using<EMAIL_ADDRESS>Thank you for the super quick turnaround!


Add report section for non-archived activities with missing leads

This is basically the same as one of the checks, but is worth including in the report to facilitate the PMC's steering responsibilities.

Fixed in rev c6521795886d7115793816861d89edb4643108d0.


it's written in python

but what about this

it was either perl or python if im gonna code in a shit language i want it to be readable at least

u just starred this

i didnt write it
also it has the !lick command on linbot which is amazing

sounds bad Bront


Summary grammar fix

@languitar Oh... Thanks! I'm not knowledge in English, and I quite often use google translator - sometimes there are such cases...
Thanks again for correcting the mistakes. If not difficult, you could fix a similar error in setup.py (I will point to her in the review)

No problem. It's included now.
Just as an alternative: for the languages I speak DeepL gives much better results.

@languitar Perfect! Thank you very much for your contribution to the repository and the useful link to the translator service.
By the way, the answer I write using this service.The only thing missing is a quick change of language (Russian -> English and English -> Russian).


🛠 Repo: Lint failures on fresh clone for ESLint not finding eslint.config.* file

After a fresh pnpm i and pnpm build, running eslint . as part of pnpm lint > lint:js gives:
><EMAIL_ADDRESS>lint:js /Users/josh/repos/eslint-plugin-functional
> eslint .

Oops! Something went wrong! :(

ESLint: 9.6.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

I'm guessing this was an overly aggressive Renovate bot merge?

That should have triggered a release... hmmm.

And yeah, it would have been a renovate update that caused the issue. The main branch should still be on eslint 8.

Thanks!

Thanks for the quick fix!


cloud.commandframework.minecraft.extras.TextColorArgument has broken color order

'3': DARK_GREEN -> DARK_AQUA
'4': DARK_AQUA -> DARK_RED
DARK_GREEN was listed twice, DARK_AQUA was shifted by 1, DARK_RED was missing from the list

fixed in 1.8.0


[Feature Request] Make minimap use same highlight information as main editor

It would be really sweet if the minimap could be made to use the same highlighting info as the main buffer.
This would make it visually much more useful as everything would visually match between the minimap and the actual editor.

Hi :D
Thanks for the report!
The minimap is actually another instance of nvim, which is crafted to have the same appearance as the current buffer displayed by the main nvim. Cases where it differs from the main highlight need to be considered separately.
The following cases are currently known, but please let us know if there are others.

folded column
search matches

Tree-sitter highlighting is still in the process of being supported, and there may be cases where tree-sitter highlighting is not applied to minimap in some environments.
Anyway, if there is a difference in highlighting between minimap and the main buffer, I would like to know the specific case.
In your case, what coloscheme are you using, what plugins are you using, and what specific differences in highlighting do you see between minimap and the main buffer?

Hi,
I'm using this colorscheme:
https://github.com/rakr/vim-one
and this is the list of my active plugins:

coc.nvim
delimitMate
nerdtree
typescript-vim
vim-airline
vim-autoformat
vim-easymotion
vim-fugitive
vim-gitgutter
vim-lsp-cxx-highlight
vim-toml
xterm-color-table.vim
yats.vim

This is an example of the highlighting discrepancy.

I'm using the lastest nightly 0.5.0-dev version of Neovim on Ubuntu 20.10, if that is relevant.

Hi,
I have improved the color scheme applying process of the minimap for this problem.
You can get the latest binary from the following link, if you could try it in your environment.
https://github.com/akiyosi/goneovim/actions/runs/756168041

Hi.
I'ts different, but it's still incorrect
CPP file:

.vimrc file:

Hmm, it seems to work well in my environment.
There may be other factors that depend on your environment.
I generated a binary with debug log added;
https://github.com/akiyosi/goneovim/actions/runs/760734717
Is it possible to generate a debug log with this binary and share it on Gist, etc.?
The debug log can be generated by specifying the following arguments.
/path/to/goneovim --debug

Here is a log without calling GonvimMiniMap
https://pastebin.com/mNCszXsH
Here is a log WITH calling GonvimMiniMap and then doing nothing. This had the minimap having NO highlighting at all. (see first screenshot below)
https://pastebin.com/498f7qfK
Here is a log WITH calling GonvimMiniMap and then changing buffers from the current one, to the next one and then back.
This had the minimap starting with NO highlighting at all, and then after changing buffers having highlighting, but completely incorrect highlighting (see second
screenshot below)
https://pastebin.com/Ja7Ea6gz
Hope these help!
No Highlighting:

Wrong Highlighting

Possibly related,
The most recent build you asked me to use crashes when opening any markdown file
https://pastebin.com/2zBLNNpZ

I have tried to improve it again based on the information in your debug log.
Could you please try the following latest binary?
https://github.com/akiyosi/goneovim/actions/runs/767450844

Behavior is identical to before.
Here is a log without calling GonvimMiniMap:
https://pastebin.com/xEvpSHuh
and here is one with calling GonvimMiniMap and changing buffers:
https://pastebin.com/1YXQM8B4

I've also created an improved version again.
Could you please try the following latest binary?
https://github.com/akiyosi/goneovim/actions/runs/771129462

Highlighting sometimes shows up without having to change buffers, but sometimes you do have to change buffers for it to show up. In either case, the actual highlighting is still 100% incorrect. Screenshots from last reply still apply.
Here is a log from before calling GonvimMiniMap:
https://pastebin.com/YcgFvQaK
And here is one after calling GonvimMiniMap and changing buffers once
https://pastebin.com/ADJ7auwk
Interestingly, on Windows this is ALMOST right (almost the exact same setup. Only differences are I think I might be on Nvim 0.4.4 there instead of 0.5, and Windows instead of Ubuntu, obviously). You still have to swap buffers to get the highlighting to load, but once you do the highlighting coming solely from the colorscheme is correct. Highlighting coming from plugins (eg C++ semantic highlighting via coc.nvim and vim-lsp-cxx-highlight) isn't picked up though.


Custom ID is Always 1

I don't have time to fix this today but if anyone comes up with a fix that's great. This is what is being used now:
num = db.col.count() + 1

It always returns num as 1.

Had to do: ```py
db.suggestions.count()


Use Option<T&> instead of Option<T*> in C++

This is a very large rework of the ABI which overall I am much much happier with.
Core changes:

On C++ side, you now get to use Option<T&>
RustOption now transmutes into std::option::Option for everything, so no more reading a union in rust to see if its None. This matches how RustVec does stuff. This also means we no longer need to ensure that the inner value has the same size as usize, which unlocks Option<&str> and Option<String> (and slice/vec) in the future. It does still require the niche optimization for now though
RustOption now always uses indirect ABI, which means that internally we pass RustOption* to C++ which then dereferences it. The user does not see this, it all happens in the codegen, they think they are just passing by value. This also simplifies a ton of logic inside Option because we dont have to jump between refs/boxes and pointers anymore

Minor changes:

I noticed that I accidentally missed something to support bool, added that and a test to make sure it works
Cleaned up some internal APIs for getting the value

Added second commit which goes back to direct ABI. Core idea: Option<&T> -> RustOption<&T> -> T* -> rust::Option<T&> (and same for Box). This is how rust::Box is currently implemented. I have no idea what the tradeoffs are between the 2 approaches though

Looks like conflicts reported in tests/ui_build/option_not_sized.stderr otherwise LGTM


Unable to find kernel headers for debian_5.8.0-1-cloud-amd64_1

Describe the bug
By debugging https://github.com/falcosecurity/evolution/issues/43 (more info here, I found that the debian builder is not able to find kernel headers for these prebuild driver configurations (ie., debian_5.8.0-1-cloud-amd64_1).
How to reproduce it
Run driverkit docker -c ... with one of the YAML files here.
Expected behavior
To successfully find the kernel headers for that particular debian.
Screenshots

I think that this happens also for other kernel versions, like 5.9.0-1-amd64, reading the prow periodic job logs.

I think that this happens also for other kernel versions, like 5.9.0-1-amd64, reading the prow periodic job logs.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


I want to give a class name to the enlarged image.

Is it possible to give a specific class name to a specific enlarged image?

Hi there @asako08 👋  thanks for the question.
At this stage, there's no way to do this specifically, but a workaround is to use the default enlarged image class .lum-open, or pass a namespace property when creating the Luminous instance, which will then cause the lightbox to have a class of .{namespace}-open, when enlarged.
new Luminous(document.querySelector("a"), {
  namespace: 'my-custom-namespace'
});

Documented here.
Thanks!

Hi there @asako08 👋  thanks for the question.
At this stage, there's no way to do this specifically, but a workaround is to use the default enlarged image class .lum-open, or pass a namespace property when creating the Luminous instance, which will then cause the lightbox to have a class of .{namespace}-open, when enlarged.
new Luminous(document.querySelector("a"), {
  namespace: 'my-custom-namespace'
});

Documented here.
Thanks!

Thank you very much.
Solved!

Thank you very much.
Solved!


Adding dashes to quick accent

There are also other symbols I would love to see in Quick Accent, like en- and em-dashes 🙂

Originally posted by @stephtr in https://github.com/microsoft/PowerToys/issues/20390#issuecomment-1242171923

This has been addressed as part of the 0.67 release cycle. Thank you!

Thank you all, really useful 😁


fix template issue

Hi,
I was having problems with the template system where strings not between brackets were being replaced.
To reproduce this issue add the following template:
background = {background.rbg}

It creates a file with:
color0A0E1F =10,14,31

I think this is due to the changes done to allow for calling util.Color methods from the template file. I fixed it for my use case however, I have not tested it thoroughly.
I will leave this here, feel free to do whatever you want with it, and hopefully it might help someone out.

This one fixes #495.

Thanks @SrKomodo for taking a look. I made the changes you suggested. It now fails to due a trailing white space in wallpaper.py, from yesterday's merge.

I'll fix the CI. Thanks. :+1:


EditableText Widget  collect  clipboard strings after focued and initialized

there is a compliance issue in China ,our app was not allowed to collect user's info without user's authorization. but EditableText source code used clipboard apis obtain clipboard content is empty or not (hasStrings = await Clipboard.hasStrings();  // text-selection.dart).
so,if there's a solution to avoid this situation?
tks

Hello @Jimmuy. Could you post a permalink to the code you mentioned? Also, could you describe in more detail the issue here, and what behavior would you prefer instead?


Blueprint API Populate Where not working

Hi
I have created sample project and created models like:
Photo.js:

module.exports = {

  attributes: {
    owner:{
      model:"User"
    }
  }
};

User.js

module.exports = {

  attributes: {
    photos:{
      collection:"Photo",
      via:"owner"
    }
  }
};

Then created some test data: (result from http://localhost:1337/user)
[
  {
    "photos": [
      {
        "owner": 1,
        "createdAt": "2015-07-08T17:52:37.854Z",
        "updatedAt": "2015-07-08T17:52:37.854Z",
        "id": 1
      },
      {
        "owner": 1,
        "createdAt": "2015-07-08T17:52:39.886Z",
        "updatedAt": "2015-07-08T17:52:39.886Z",
        "id": 2
      }
    ],
    "createdAt": "2015-07-08T17:52:18.501Z",
    "updatedAt": "2015-07-08T17:52:18.501Z",
    "id": 1
  },
  {
    "photos": [],
    "createdAt": "2015-07-08T17:52:21.212Z",
    "updatedAt": "2015-07-08T17:52:21.212Z",
    "id": 2
  }
]

And right now I'm trying to get all photos by specific user.
I followed documentation (http://sailsjs.org/documentation/reference/blueprint-api/populate-where)
and figured out that I need to GET on (in my example) : http://localhost:1337/user/1/photos but it returning 404 error.
I haven't changed anything in config directory.
Am I doing sth wrong? or it's a bug?

I can confirm this issue. Here are the steps to reproduce.
Create a new Sails app
$ sails new foo
$ cd foo
$ sails generate api purchase
$ sails generate api employee

Edit api/models/Purchase.js
module.exports = {

  attributes: {
  	     cashier: {
	    model: 'Employee'
     }
  }
};

Create some sample data:
http://localhost:1337/employee/create/?name=%22Mr.%20T%22&age=25
http://localhost:1337/purchase/create/?name=%22Purchase%201337%22&cashier=1
Now, navigate to http://localhost:1337/purchase/1/cashier. Server responds with 404 instead of the data.

Hi, I'm also having this problem and got it sorted out.
I'm currently using version 0.11.2
quick fix:
at lib/hooks/blueprints/index.js
go to line 376
change
_bindRoute( _getAssocRoute('get %s/:parentid/%s/:id?'), 'populate', opts ); to _bindRoute( _getAssocRoute('get /%s/:parentid/%s/:id?'), 'populate', opts );


Error labels don't line up with error location

I tried running the multiline example and the label does not line up with the error. Here is an image to show what I mean:

Oh goodness, this sounds like #19. Does this work on master, or not?

Hi, I'm not sure what you mean, I don't see any other branches other than main so that's the one I tried running the example on.

Oh goodness, this sounds like #19.

Okay so I just tried replacing the new lines from CRLF to LF and that seems to have fixed it. So this appears to be a duplicate of #19. Thank you for your time.

Sorry this hasn't been fixed yet, Hopefully this will be fixed in the new year!


Inbox search bar for intent qualification bug in v21.3.2

Since the v21.3.2, the search bar for intent qualification is available.
The feature doesn't seem too work all the time.
The requalification is not updated and the Tock Studio admin keeps the first intent detected in the bar.
Example :

I choose here the correct intent :

After the click the first intent found by the bot is back :

@Cypres-c can you check that the bug is no longer reproductible on https://demo.tock.ai/nlp/inbox ?

I see the same problem on the ED Bot demo.
Intent detection remains blocked on the same intention unless I refresh the page.
image

After checking the demo, the bug seems to be fixed. When will it be released ?

I think I will release a patch at the end of the week


⚠ Bofrost.lu has degraded performance

In 853ccc7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1077 ms

Resolved: Bofrost.lu performance has improved in 334160c after 20 minutes.


CTD at lauunch with v 0.92.0

Describe the bug
CTD
Steps to reproduce
1.update to v 0.92.0
2.launch tthe game
3.CTD
Logs
https://mclo.gs/JFMwUMI
Additional context
No response

Fixed in 0.92.0+1.11.1+1.20.1.