webkit2gtk out of date

@cemkeylan

Yup, the musl build is having issues I am repatching it. I will send a PR by tonight.

I won't be able to push the PR right now. There are still issues regarding JavaScript execution. Here is the updated patch for musl fixes if you would like to inspect it.  https://gist.github.com/4ae621256ffd730d238a649879db8bd9

It's rather important that this be kept up to date (within a reasonable time) as it's a web browser and each release brings with it security fixes.
Ping @cemkeylan

I couldn't do it. I checked other musl distros that package webkitgtk.
Alpine's patches do not build (they have also added libwpe as a
dependency). Void did not update their packages yet.
My own patch does build, but some javascript core functions don't work.
Funnily enough, I noticed it when I was going to add a Pull Request and
couldn't click the compare across forks button. My later changes to
the patch either did not build or did not fix.
I think we can mark this issue with needs help. If anyone has a deeper
knowledge of webkitgtk, I can also drop maintainership. I'm sorry this
took so long.
On 20/03/25 12:58AM, dylan wrote:

It's rather important that this be kept up to date (within a reasonable time) as it's a web browser and each release brings with it security fixes.
Ping @cemkeylan
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/kisslinux/community/issues/542#issuecomment-603694613

@cemkeylanyou can try to look at the patches on this gentoo musl pull request

Patches here are for older versions, webkitgtk hasn't been updated in the musl overlay of Gentoo yet. Thank you regardless.
On 26 March 2020 21:17:53 GMT+03:00, "João Paulo Pulga"<EMAIL_ADDRESS>wrote:

@cemkeylanyou can try to look at the patches on this gentoo musl pull
request
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/kisslinux/community/issues/542#issuecomment-604594427

--
Cem Keylan

I have just tested alpine's build of webkit2gtk which seems to be the only musl distro that updated. Keep in mind that they have only bumped their versions in the edge repository, which is alpine's "build first, test later" branch.

I have installed their package in a chroot and built surf. It crashes before starting.
I thought it would be a better idea to see a webkit browser they package themselves and installed epiphany. Only an empty window is opened and my terminal is immediately filled with WARNING [...] Web process crashed messages.

I think it is safe to say that we don't have a working webkit in any of the musl distros at the moment.
My patch doesn't have web process crashes, and there are no issues regarding basic web functions, but all I am doing right now is inspecting the changes between 2.26.4 and 2.28.0 and trying my best. Long build time isn't helping me either.

I'll see what I can do. :+1:

I have working webkit2gtk, here's a patch you can apply to the repository files here.
diff --git a/community/webkit2gtk/build b/community/webkit2gtk/build
index 05ba8c8..aac25cc 100755
--- a/community/webkit2gtk/build
+++ b/community/webkit2gtk/build
@@ -4,7 +4,7 @@ patch -p1 < fix-musl.patch

 # Remove gettext requirement.
 sed -i 's/ngettext/printf/g' Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
-sed -i '/po_files *.po/d'    Source/WebCore/platform/gtk/po/CMakeLists.txt
+sed -i '/po_files \*\.po/d'  Source/WebCore/platform/gtk/po/CMakeLists.txt
 sed -i '/^GETTEXT_C/d'       Source/WebCore/platform/gtk/po/CMakeLists.txt

 export DESTDIR="$1"
@@ -16,6 +16,7 @@ cmake -B build \
     -DPORT=GTK \
     -DCMAKE_SKIP_RPATH=ON \
     -DENABLE_BUBBLEWRAP_SANDBOX=OFF \
+    -DENABLE_SAMPLING_PROFILER=OFF \
     -DENABLE_GEOLOCATION=OFF \
     -DENABLE_GLES2=ON \
     -DENABLE_INTL=OFF \
diff --git a/community/webkit2gtk/checksums b/community/webkit2gtk/checksums
index b31dccb..41c8aea 100644
--- a/community/webkit2gtk/checksums
+++ b/community/webkit2gtk/checksums
@@ -1,2 +1,2 @@
-4386900713dfadf9741177210b32623cab22562a79ffd0d446b66569934b113f  webkitgtk-2.26.4.tar.xz
-b83f933a8e2309a8845010b8839043dd98a147a74609c6f16f51fea5728ad746  fix-musl.patch
+361f3d178f62a9c112cbadfedd46106c34455c26d57a12a28fb3b09178d20e8b  webkitgtk-2.28.0.tar.xz
+67f7138b8d04e8bc02ce1bdbf728342abb55ef08566371105b3aefa0d3955a57  fix-musl.patch
diff --git a/community/webkit2gtk/patches/fix-musl.patch b/community/webkit2gtk/patches/fix-musl.patch
index a9479a6..ee53a2f 100644
--- a/community/webkit2gtk/patches/fix-musl.patch
+++ b/community/webkit2gtk/patches/fix-musl.patch
@@ -1,136 +1,88 @@
-Source: @q66, @pullmoll
-Original upstream: Alpine Linux
-Reason: fixing machine context access for musl libc; reduce stack/heap usage for jsc; fix some overly restrictive __GLIBC__ checks
-
-Updated for latest webkit2gtk.
-
+diff --git a/Source/JavaScriptCore/runtime/MachineContext.h b/Source/JavaScriptCore/runtime/MachineContext.h
+index c5052527..dabd3733 100644
 --- a/Source/JavaScriptCore/runtime/MachineContext.h
 +++ b/Source/JavaScriptCore/runtime/MachineContext.h
-@@ -188,7 +188,7 @@ static inline void*& stackPointerImpl(mcontext_t& machineContext)
+@@ -196,7 +196,7 @@ static inline void*& stackPointerImpl(mcontext_t& machineContext)
  #error Unknown Architecture
  #endif
-
+
 -#elif OS(FUCHSIA) || defined(__GLIBC__) || defined(__BIONIC__)
 +#elif OS(FUCHSIA) || defined(__linux__)
-
+
  #if CPU(X86)
      return reinterpret_cast<void*&>((uintptr_t&) machineContext.gregs[REG_ESP]);
-@@ -335,7 +335,7 @@ static inline void*& framePointerImpl(mcontext_t& machineContext)
+@@ -347,7 +347,7 @@ static inline void*& framePointerImpl(mcontext_t& machineContext)
  #error Unknown Architecture
  #endif
-
+
 -#elif OS(FUCHSIA) || defined(__GLIBC__) || defined(__BIONIC__)
 +#elif OS(FUCHSIA) || defined(__linux__)
-
+
  // The following sequence depends on glibc's sys/ucontext.h.
  #if CPU(X86)
-@@ -482,7 +482,7 @@ static inline void*& instructionPointerImpl(mcontext_t& machineContext)
+@@ -498,7 +498,7 @@ static inline void*& instructionPointerImpl(mcontext_t& machineContext)
  #error Unknown Architecture
  #endif
-
+
 -#elif OS(FUCHSIA) || defined(__GLIBC__) || defined(__BIONIC__)
 +#elif OS(FUCHSIA) || defined(__linux__)
-
+
  // The following sequence depends on glibc's sys/ucontext.h.
  #if CPU(X86)
-@@ -639,7 +639,7 @@ inline void*& argumentPointer<1>(mcontext_t& machineContext)
+@@ -656,7 +656,7 @@ inline void*& argumentPointer<1>(mcontext_t& machineContext)
  #error Unknown Architecture
  #endif
-
+
 -#elif OS(FUCHSIA) || defined(__GLIBC__) || defined(__BIONIC__)
 +#elif OS(FUCHSIA) || defined(__linux__)
-
+
  // The following sequence depends on glibc's sys/ucontext.h.
  #if CPU(X86)
-@@ -756,7 +756,7 @@ inline void*& llintInstructionPointer(mcontext_t& machineContext)
+@@ -773,7 +773,7 @@ inline void*& llintInstructionPointer(mcontext_t& machineContext)
  #error Unknown Architecture
  #endif
-
+
 -#elif OS(FUCHSIA) || defined(__GLIBC__) || defined(__BIONIC__)
 +#elif OS(FUCHSIA) || defined(__linux__)
-
+
  // The following sequence depends on glibc's sys/ucontext.h.
  #if CPU(X86)
---- a/Source/JavaScriptCore/runtime/Options.h
-+++ b/Source/JavaScriptCore/runtime/Options.h
-@@ -112,6 +112,16 @@ constexpr bool enableWebAssemblyStreamingApi = true;
- constexpr bool enableWebAssemblyStreamingApi = false;
- #endif
-
-+#if defined(__GLIBC__)
-+constexpr unsigned jscMaxPerThreadStack = 4 * MB;
-+constexpr unsigned jscSoftReservedZoneSize = 128 * KB;
-+constexpr unsigned jscReservedZoneSize = 64 * KB;
-+#else
-+constexpr unsigned jscMaxPerThreadStack = 80 * KB;
-+constexpr unsigned jscSoftReservedZoneSize = 32 * KB;
-+constexpr unsigned jscReservedZoneSize = 16 * KB;
-+#endif
-+
- #define JSC_OPTIONS(v) \
-     v(bool, useKernTCSM, true, Normal, "Note: this needs to go before other options since they depend on this value.") \
-     v(bool, validateOptions, false, Normal, "crashes if mis-typed JSC options were passed to the VM") \
-@@ -126,9 +136,9 @@ constexpr bool enableWebAssemblyStreamingApi = false;
-     \
-     v(bool, reportMustSucceedExecutableAllocations, false, Normal, nullptr) \
-     \
--    v(unsigned, maxPerThreadStackUsage, 4 * MB, Normal, "Max allowed stack usage by the VM") \
--    v(unsigned, softReservedZoneSize, 128 * KB, Normal, "A buffer greater than reservedZoneSize that reserves space for stringifying exceptions.") \
--    v(unsigned, reservedZoneSize, 64 * KB, Normal, "The amount of stack space we guarantee to our clients (and to interal VM code that does not call out to clients).") \
-+    v(unsigned, maxPerThreadStackUsage, jscMaxPerThreadStack, Normal, "Max allowed stack usage by the VM") \
-+    v(unsigned, softReservedZoneSize, jscSoftReservedZoneSize, Normal, "A buffer greater than reservedZoneSize that reserves space for stringifying exceptions.") \
-+    v(unsigned, reservedZoneSize, jscReservedZoneSize, Normal, "The amount of stack space we guarantee to our clients (and to interal VM code that does not call out to clients).") \
-     \
-     v(bool, crashIfCantAllocateJITMemory, false, Normal, nullptr) \
-     v(unsigned, jitMemoryReservationSize, 0, Normal, "Set this number to change the executable allocation size in ExecutableAllocatorFixedVMPool. (In bytes.)") \
---- a/Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp
-+++ b/Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp
-@@ -728,7 +728,7 @@ int yydebug;
- #if YYERROR_VERBOSE
-
- #    ifndef yystrlen
--#        if defined __GLIBC__ && defined _STRING_H
-+#        if defined __linux__ && defined _STRING_H
- #            define yystrlen strlen
- #        else
- /* Return the length of YYSTR.  */
-@@ -743,7 +743,7 @@ static YYSIZE_T yystrlen(const char *yystr)
- #    endif
-
- #    ifndef yystpcpy
--#        if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE
-+#        if defined __linux__ && defined _STRING_H && defined _GNU_SOURCE
- #            define yystpcpy stpcpy
- #        else
- /* Copy YYSRC to YYDEST, returning the address of the terminating '\0' in
---- a/Source/WTF/wtf/Platform.h
-+++ b/Source/WTF/wtf/Platform.h
-@@ -707,7 +707,7 @@
-
- #endif /* OS(DARWIN) */
-
--#if OS(DARWIN) || OS(FUCHSIA) || ((OS(FREEBSD) || defined(__GLIBC__) || defined(__BIONIC__)) && (CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(ARM64) || CPU(MIPS)))
-+#if OS(DARWIN) || OS(FUCHSIA) || ((OS(FREEBSD) || defined(__linux__)) && (CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(ARM64) || CPU(MIPS)))
- #define HAVE_MACHINE_CONTEXT 1
- #endif
-
+diff --git a/Source/WebCore/xml/XPathGrammar.cpp b/Source/WebCore/xml/XPathGrammar.cpp
+index 0875a5ec..98d51533 100644
 --- a/Source/WebCore/xml/XPathGrammar.cpp
 +++ b/Source/WebCore/xml/XPathGrammar.cpp
-@@ -966,7 +966,7 @@
+@@ -966,7 +966,7 @@ int yydebug;
  #if YYERROR_VERBOSE
-
+
  # ifndef yystrlen
 -#  if defined __GLIBC__ && defined _STRING_H
 +#  if defined __linux__ && defined _STRING_H
  #   define yystrlen strlen
  #  else
  /* Return the length of YYSTR.  */
-@@ -989,7 +989,7 @@
+@@ -989,7 +989,7 @@ yystrlen (yystr)
  # endif
-
+
  # ifndef yystpcpy
 -#  if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE
 +#  if defined __linux__ && defined _STRING_H && defined _GNU_SOURCE
  #   define yystpcpy stpcpy
  #  else
  /* Copy YYSRC to YYDEST, returning the address of the terminating '\0' in
+diff --git a/Source/JavaScriptCore/runtime/OptionsList.h b/Source/JavaScriptCore/runtime/OptionsList.h
+index 41cab118..2ac66c7a 100644
+--- a/Source/JavaScriptCore/runtime/OptionsList.h
++++ b/Source/JavaScriptCore/runtime/OptionsList.h
+@@ -90,9 +90,9 @@ constexpr bool enableWebAssemblyStreamingApi = false;
+     \
+     v(Bool, reportMustSucceedExecutableAllocations, false, Normal, nullptr) \
+     \
+-    v(Unsigned, maxPerThreadStackUsage, 5 * MB, Normal, "Max allowed stack usage by the VM") \
+-    v(Unsigned, softReservedZoneSize, 128 * KB, Normal, "A buffer greater than reservedZoneSize that reserves space for stringifying exceptions.") \
+-    v(Unsigned, reservedZoneSize, 64 * KB, Normal, "The amount of stack space we guarantee to our clients (and to interal VM code that does not call out to clients).") \
++    v(Unsigned, maxPerThreadStackUsage, 80 * KB , Normal, "Max allowed stack usage by the VM") \
++    v(Unsigned, softReservedZoneSize, 32 * KB, Normal, "A buffer greater than reservedZoneSize that reserves space for stringifying exceptions.") \
++    v(Unsigned, reservedZoneSize, 16 * KB, Normal, "The amount of stack space we guarantee to our clients (and to interal VM code that does not call out to clients).") \
+     \
+     v(Bool, crashIfCantAllocateJITMemory, false, Normal, nullptr) \
+     v(Unsigned, jitMemoryReservationSize, 0, Normal, "Set this number to change the executable allocation size in ExecutableAllocatorFixedVMPool. (In bytes.)") \
diff --git a/community/webkit2gtk/sources b/community/webkit2gtk/sources
index 1e2090f..59eae1a 100644
--- a/community/webkit2gtk/sources
+++ b/community/webkit2gtk/sources
@@ -1,2 +1,2 @@
-https://webkitgtk.org/releases/webkitgtk-2.26.4.tar.xz
+https://webkitgtk.org/releases/webkitgtk-2.28.0.tar.xz
 patches/fix-musl.patch
diff --git a/community/webkit2gtk/version b/community/webkit2gtk/version
index 1f639c0..02e982b 100644
--- a/community/webkit2gtk/version
+++ b/community/webkit2gtk/version
@@ -1 +1 @@
-2.26.4 1
+2.28.0 1

Building it now. Thanks a lot, Dylan.


v0.9.68

FB Prophet has a hard dependency on v0.9.68, so make a build on a separate branch for that.

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Reset the build number to 0 (if the version changed)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Local node on docker refuses to connect to ganache-cli running on port <IP_ADDRESS>:8545

Do you want to request a feature or report a bug?
No i do not.
What is the current behavior?
Graph-Node on docker refuses to connect to ganche-cli running on port <IP_ADDRESS>:8545, error object returned in logs
WARN Trying again after eth_getBlockByNumber(0, false) RPC call failed (attempt #10) with result Err(Transport error: Error(Connect, Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }))
I also deployed my upgradeable contracts to rinkeby, created and deployed a subgraph to the legacy explorer but it fails to capture events, at first i thought i did something  wrong until yesterday when i saw in the logs it was trying to index past events and then it stopped, i would like to know if this is expected with testnets on the legacy explorer, if so we don't mind running our own nodes locally just for testing until we deploy to mainnet
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
What is the expected behavior?

Hey @carterax seems like you solved your problem so closing the issue, please re-open if you are still having issues!

I have tried @carterax method but still having the issue.
Here is the full error log https://drive.google.com/file/d/1WS1ZBevkkoTreqoZUfQAr1jmALGdUBU3/view?usp=sharing


Project Feedback!

Hello Aoi,
Looks like your submitted Github repo is missing some of the app code. Please push your code to Github and then re-submit your project through the course system.

Hi,
Sorry I didn't push all the files for some reason. I repushed all of it for sure now, and resubmitted the assignment.
Please take a look at my repo again.
Thank you,
Aoi

:+1: nice work. A few notes after checking out the code:

Nice to see you successfully used OAuth login. OAuth is widely used and it's important to understand OAuth v1 and v2 properly.
Good to see you were able to format the timestamp cleanly.
Good to see you added the new tweet directly to the home timeline after it was successfully posted to Twitter.
Nice touch with the character count being displayed while the user composes a tweet.
Consider adding local persistence of tweets by using DBFlow in the Tweet and User. See the persistence guide and this other guide for more details.
Consider using GSON to conveniently serialize and deserialize API responses into objects.
Consider using the folder structure and naming conventions defined in http://guides.codepath.com/android/Organizing-your-Source-Files.
Try out the third-party ButterKnife library to simplify a lot of boilerplate findViewById() calls.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.


🐛 Bug Report: Project specification is required on Azure DevOps integration

📜 Description
When configuring Azure DevOps Discovery  the 'project' variable is set as required when, by documentation, it is optional.

On the plugin-catalog-backend-module-azure the variable is being read as required:

But when calling the API Endpoint has the wildcard (but it would never be in the first place)

The error:

I refer to index.js of the plugin instead of the source, so sorry about that.
The plugin version: 0.1.14
👍 Expected behavior
It should let me use a wild card at the project property
👎 Actual Behavior with Screenshots

👟 Reproduction steps
Let the project variable empty and try to execute it
📃 Provide the context for the Bug.

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

If I set the parameter with the wildcard in the yml file:

Is working as expected, but I don't think this is the expected behavior for an optional param. If I'm wrong just close the issue.

Hi @EnmanuelParedes, thanks for the detailed issue. I think you are correct that something is not right here - either the code should be updated or the documentation should be changed to match that this is actually required. We should keep this open so that someone can do that.
I totally missed this when I did the testing on our on-prem Azure DevOps Server instance when PR #14847 was being worked on, must not have tried not setting the project and just used the wildcard :(

@MarcBruins @Jtreher @cal5barton are you using this feature? Do you have any opinions on how this should be handled?

Yes we are actively using this feature. I would expect it to be a wildcard/all projects if not supplied.

Hi, i am using with devops 2020 on premise it's working perfect this way
providers:
azureDevOps:
BDEstruturaConsignado:
host: xxxxxxxx
organization: xxxxx
project: ''
repository: ''
path: /catalog/catalog-*info.yaml

It looks like we are also specifying the '*' even though it is "optional" in the docs. I think this likely came up as a misunderstanding from discussion on the PR.
Is the solution to just change it to config.getOptionalString("project") or just change the docs? I'm fine with either solution. I suppose explicitly requiring people to put in a * forces them to consider what they are doing rather than just omitting it until they learn later because not everyone reads the docs carefully on initial usage (eyes self).

I understand, for me the ideal is change the docs, is very important your discussion ;)

Alright, seems like updating the docs is the way forward, will one of you do that? If not I can. Also, this doesn't me we can't change the code to make this truly optional down the road if we really wanted to

@awanlin and @jtreher, can you review please?
https://github.com/backstage/backstage/pull/17322

I'm almost sure this is not related, but in my configuration, I have a list of allowed kinds to be searched:

But when is founded the app throws a warning like this:
catalog warn Entity resource:default/enlinea-db at url:https://dev.azure.com/<path>?path=/catalog-info.yaml, originated at url:https://dev.azure.com/grupouniversal/<path>?path=/catalog-info.yaml, is not of an allowed kind for that location type=plugin entity=location:default/generated-dffd2a899a77f2d7a6b9368ff9d3d0a93b91315c location=url:https://dev.azure.com/<path>?path=/catalog-info.yaml

The global rule is not being used for the provider? I need to use the alternate processor for this?  If I add a kind:component is being added successfully like it is the only valid

Yep, I think this can be closed. Great job!


Add default responseData

Add default responseData so that empty response bodies like for status code 204 don't result in UNIHTTPClientHelper.m returning a nil UNIHTTPResponse

Can someone please review and merge this please? When included into Fuse application, this library crashes on status code 204 responses all the time.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Evgeny Gushchin:x: ailiaoEvgeny Gushchin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Use in react class

How can I use this in a react class?

Thank you for this issue!
The current purpose of use-tus is to make it easier to handle tus in functional components.
Therefore, please consider replacing the upload component with a functional component.
If also, your upload component strongly depends on a class component, consider using tus-js-client


telegraf: 1.16.3 -> 1.17.0

Motivation for this change
Update telegraf to latest version  v1.17.0. Release notes available here.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

/nix/store/cwsv4zwj0zbqsa34pn7lgvh4xqbbw1sp-telegraf-1.16.3      103.0M
/nix/store/11l2r06dm32hjykqy0ysgr6bd0g5apz4-telegraf-1.17.0      104.0M

[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108930 run on x86_64-darwin 1

1 package built:

telegraf

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108930 run on x86_64-darwin 1

1 package built:

telegraf

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108930 run on x86_64-linux 1

1 package built:

telegraf

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108930 run on x86_64-linux 1

1 package built:

telegraf


Reduce overhead of having many repositories

Forked off from #1369.
Many times a repository is only added to provide a small subset of the project's dependencies. Yet Gradle will still check all repositories for dynamic dependencies or when a dependency can't be found further up in the list.
The current approach is very basic and could be improved e.g. by remembering that a certain module was completely absent from a repository and never checking for that module there again until the cache times out.

@oehme I believe that we now have many things in place to reduce that overhead:

Missing modules (group:name or group:name:version) are remembered forever, see #4436.
Caching of dynamic versions and changing modules can be user controlled, and defaults to 24h.
Before failing a build due to a missing dependency, Gradle will ignore cached results.

Given all that, I believe the pure performance aspect is covered and this can be closed.
Wdyt?

I don't think this can be closed. There's still one issue which is not addressed: we're reduced the amount of requests that need to be made on a repository thanks to the metadataSources DSL, which lets us explain that's it's not worth looking for a jar file is metadata is missing. So far so good. But as soon as we will enable Gradle metadata, it's going to introduce a lot of requests to search for .module files when we know, at least in the beginning, that most modules will not provide it. So the situation is going to be worse than with looking for jar files.
While it should be possible to configure, say, mavenCentral not to look for Gradle metadata, this is not an acceptable solution.
So I'd refrain from closing this as we don't know what is going to be the impact of enabling Gradle metadata in practice, and how to improve the situation in general.

Yes I think #4436 addresses this issue.

This no longer applies.


No reflection data for raw arrays

If I have a shader that has
@binding(0) @group(0) var<uniform> viewUniforms: array<vec4<f32>, 7>;

It appears the no reflection data is returned. Sorry, I didn't try to fix it myself yet.

I'm going to guess that raw non-arrays have the same issue
@binding(0) @group(0) var<uniform> viewUniforms: f32;

Oversight on my part. I assumed without looking that uniform buffers could only be structs, but it makes sense they can be anything. I'll get that fixed tonight after I get through my day job work :-)

See if this works for you.
struct ViewUniforms {
  viewProjection: mat4x4<f32>
};

struct ModelUniforms {
  model: mat4x4<f32>,
  color: vec4<f32>,
  intensity: f32,
  view: array<ViewUniforms,2>,
  f32Array: array<f32,2>
};
@group(0) @binding(0) var<uniform> model : ModelUniforms;
@binding(1) @group(0) var<uniform> uArray: array<vec4<f32>, 7>;
@binding(2) @group(0) var<uniform> uFloat: f32;

      const u0 = reflect.getUniformBufferInfo(reflect.uniforms[0]);
      test.equals(u0.name, 'model');
      test.equals(u0.type.name, 'ModelUniforms');
      test.equals(u0.members.length, 5);
      test.equals(u0.size, 240);

      const u1 = reflect.getUniformBufferInfo(reflect.uniforms[1]);
      test.equals(u1.name, 'uArray');
      test.equals(u1.type.name, 'array');
      test.equals(u1.type.format.name, 'vec4');
      test.equals(u1.type.format.format.name, 'f32');
      test.equals(u1.size, 112);
      test.equals(u1.align, 16);

      const u2 = reflect.getUniformBufferInfo(reflect.uniforms[2]);
      test.equals(u2.name, 'uFloat');
      test.equals(u2.type.name, 'f32');
      test.equals(u2.size, 4);
      test.equals(u2.align, 4);

Thanks Brendan!
I'm wondering though... If I have this
struct Test {
    foo: array<vec3<f32>, 16>,
};
@group(0) @binding(0) var<uniform> myUniformsStruct: Test;
@group(0) @binding(1) var<uniform> myUniformsArray: array<vec3<f32>, 16>;

Somewhere I'd expect the data I get for myUniformArray to be similar to the data I get for myUniformStruct.foo as they're the same.
Currently, for myUniformStruct.foo I get
arrayCount: 16
arrayStride: 12
isArray: true
isStruct: false
member: AST {_type: 'member', name: 'foo', attributes: null, type: AST}
members: undefined
name: "foo"
offset: 0
size: 256
type: AST {_type: 'array', name: 'array', attributes: null, format: AST, count: '16'}

but for myUniformArray I get
align: 16
binding: 1
group: 0
name: "myUniformsArray"
size: 256
type: AST {_type: 'array', name: 'array', attributes: null, format: AST, count: '16'}

would it make sense for the info for myUniformArray to include isArray, isStruct, arrayCount, arrayStride?  Then, to the outside code, the 2 are the same.
Maybe getUniformBufferInfo could return
binding: 1
group: 0
size: 256
memberDefinition: ???

Where memberDefinition is the data returned for a member of a struct (since a member of a struct can be a base type, an array of base types, a struct, an array of structs. And similarly, getStructInfo would also return a "memberDefinition" that happens to be struct, since again, the data for a nested struct should be the same as the data for a top level struct.

Yeah you're right, they should be the same. I added isArray, isStruct, arrayCount, arrayStride to the non-struct case.
I'm not sure I follow the memberDefinition suggestion, maybe you can mock that up. I'm all for finding a clean and consistent API.


SYNPY-966 Cache Implementation

In progress. Please do not merged.

Hello @kimyen! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spccore/internal/cache.py:

Line 110:44: E252 missing whitespace around parameter equals
Line 110:45: E252 missing whitespace around parameter equals
Line 317:60: W605 invalid escape sequence '\d'
Line 320:76: W605 invalid escape sequence '\d'


Added JSON parsing support for json map values

Was unable to send json data appropriately.
Added supoport for json parsing.
settings added to control, useJsonParsing to enable or disable.
If enabled it parses the message for json data and sends as individual fields for peoper json formatted data.

While I would find this handy in a practical sense, NLog itself isn't so much designed to be a structured logging facility as this plugin isn't supposed to decode stringized JSON messages to get them ready on wire.  Ideally using some other structured logging library such as serilog or semantic logging with a fluent backend appears to be the better way to go.  What do you think of this?

Technically you are correct, I agree. However, community benefit wise it might be good. The adoption of NLog as logging framework is large. There is no other direct target for fluentd except this one. Another workaround my peers have used is use a network type target in NLog to achieve nearly same but it does not offer same ease of use. Adding another framework for logging might deter a lot of developers. Options I can think of is, either we offer this as feature in this target or create another target for the same for NLog and call it maybe 'StructuredFluentDTarget' or something similar.
Having said that, I would like to hear your thoughts in terms of community benefit and approach we can take.

Also I see Serilog has sync for NLog. Maybe you are right about the approach of using Serilog.

I will close this request, I agree with your approach. Thanks for sharing insight.

Think it is a good idea to allow capture of additional properties, even if not support structured logging.
Instead of using this target, then it should be possible to use the NLog-NetworkTarget together with the JsonLayout. This will take the Json-Layout-output and encode to UTF8 and send to fluentd using TCP.
Just like done here:
https://github.com/VQComms/Serilog.Sinks.Fluentd.Core/blob/master/src/Sinks/FluentdSink.cs
"ts":"{timestamp}",
"ticks":"{timestamp-as-ticks}",
"msgtmpl":"{message-raw}",
"level":"{level}",
"{exception-as-json}",
"{propertyname}":"{propertyvalue}",

Btw. NLog 4.5 will support structured logging by default, and handle message-template and capture properties.


data('datetimepicker').date() doesn't return current value

Tempus Dominus Bootstrap4 v5.27.2
Hello.  We have a few questions.  We just downloaded and started using this project yesterday to replace the main project because we ran into several issues and found your version to be more up to date.  We thank you but have just a few questions:

As indicated in the subject line, will you be fixing this issue in your project (you'll see a comment from someone called attitudemattrs on the thread - he is one of our developers):

https://github.com/tempusdominus/bootstrap-4/issues/321

Is it safe for us to switch from using the main project to this project full-time?

Since we have swapped out the main project with your version, do you plan on maintaining this branch going forward even if it gets merged into the main project?

Again, we appreciate your time on this.  I do realize that you didn't want general questions submitted here, but we do have an issue (321) and I wasn't sure where to go in stackOverflow to submit my questions.
Thank you so much!

Hi @jweidner711,

As indicated in the subject line, will you be fixing this issue in your project (you'll see a comment from someone called attitudemattrs on the thread - he is one of our developers):

Just post me a example reproducing the issue you are facing and I will take a look (you can use this fiddle).
Or, even better, if you already know where the issue is and how to fix it, don't be shy to send a PR like other contributors did 😉 .

Is it safe for us to switch from using the main project to this project full-time?

The current major version is still 5 (5.27.2), so there are no breaking changes and I think you are good to go, I and other contributors patched several things, updated NPM deps, fixed several bugs which are still present on the upstream repo and added new features (like the support for Feather icons).

Since we have swapped out the main project with your version, do you plan on maintaining this branch going forward even if it gets merged into the main project?

Yes, I plan to maintain this project, accept PRs, review them and discuss new features together with other contributors.
I don't think this fork will ever get merged into the upstream repo, the original author of the upstream Tempus Dominus Bootstrap repo seems to be unresponsive.
If it ever gets merged, then even better, we can keep on building this fork and send PRs to the upstream repo as well.
Will wait for an example reproducing the bug or a PR to review it! Thank you!

https://jsfiddle.net/m5gnq236/
I think I found the same issue as @jweidner711 . See the above fiddle.
If I select a value in the datepicker then both the viewdate and date are correctly updated. When I manually modify the month of the datepicker to a different one, then the viewdate is updated but the date itself is not.

Hi @sgentens!
I looked at your fiddle and couldn't reproduce the use case you're mentioning in your second screenshot where the viewdate differs from the selected date.

When I manually modify the month of the datepicker to a different one, ...

How do you do it? What do you mean by manually modify the month? Do you use $('#picker').datetimepicker('date', new Date()) though the programmatic API?
Here is a fork of your fiddle -> https://jsfiddle.net/qu2Los9n/ where I do that and the view date stays in sync with the selected date in this case.
Try to select a date that is different from today before the timeout of 5 seconds is reached and you will see that after the 5 seconds the viewdate and the selected date are both set to today.
Otherwise, send me a fiddle reproducing you second screenshot where the two dates differ and I will take a look.

What also happens is, when you clear the date input (either manually or via the clear button), the selected date is cleared, but the viewdate is not. That might not be related, but should those be kept out of sync?

The viewdate and selected date may not be in sync: for example, when you navigate to another month or year in the picker, the selected date remains the one you selected, but the viewdate changes accordingly to your current month/year and so on. The two are independent from each other from what I am concerned.
Let me know! Thank you!

I actually just did the same in your fiddle. What I mean by manually modify the month is by actually selecting the month value in the input, typing in a different number, e.g. when the current month is 10 I type in 08 and then click outside. By doing so, the viewdate and selected date differ.
So I'm talking about modifying the date through the UI, without anything programmatic interfering. I'll see whether I can make a video.

Thank you @sgentens. Now I see it. You meant modifying the date directly on the input field by typing, without using the picker widget.
I consider this to be a bug, I would expect the view date to be in sync with the selected date in this case.

Try this: https://jsfiddle.net/w0gr1v69/4/
I have released a new version v5.29.0 with the fix for your use case. Just confirm me everything works as it should now and I will close this issue.
@jweidner711 Is this fix ok for your use case too?

This seems to be working, thanks for the quick update! 👍
P.s.  will there be a webjar available for this version as well in the near future? The ones I can find on webjars.org are a bit outdated (last version there is 5.23.0)

I don't know what webjars.org is.
If you can guide me we can try to do that! I don't know who released version 5.23 on webjars.
Why don't you install tempusdominus-bootstrap through NPM or Yarn in your project? That's the easiest way to use it and you will always get the updated version when you run npm update or yarn upgrade.

Hmm, I think I didn't test it sufficiently for my own use case. In our framework we only show the datetimepicker when the calendar icon is clicked, not on-click for the input field, in which case the bug still remains. (Hence why we also used the blur/focusout to reset the date). In these cases the viewDate is still updated, but the date only when the input field is cleared for instance.
Added a fiddle with configuration similar to ours (left out the hidden input stuff): https://jsfiddle.net/0fcmrn1w/1/
And a modification applied to your last fiddle: https://jsfiddle.net/v69425rz/ (removed data-toggle on html line 7 + uncommented the blur/focusout)
The main difference between your last fiddle and this one, is that we don't provide a data-toggle attribute on our datepicker input field, because of this, the current fix doesn't work sadly.

Hi @sgentens,
Is this the issue you are facing?

Input without data-toggle="datetimepicker" attribute;

Click on the input field (input receives focus);

Click outside the input field (input loses focus, blur event);

viewDate is set to current datetime, picker's current date is not set.

If yes, then I think that it doesn't make sense to set the viewDate at all when a user clicks on the input field and the input field doesn't have the data-toggle attribute.
This will lead to both the viewDate and picker's current date being empty at step 3.
I think this could work. Let me know what you think!

@tonix-tuft thank you for the quick response and I apologize for my very delayed response!  I will try your latest and see if it fixes my issue.  It certainly sounds like the same problem.  Thanks again!

@tonix-tuft Ok.  I downloaded the latest (5.32.0) and re-ran my test.  I am still having the issue.  But I did discover a difference between what I have and what you and @sgentens tested with.  In my HTML, my INPUT field doesn't have the data-toggle="datetimepicker" attribute.  Like both of you, I DO have the data-toggle on the DIV for the "input-group-append", BUT I do NOT have it on the INPUT field.  If I add the data-toggle to my INPUT field, then it works as described.  However, I don't want to add it to my INPUT field, because I want my users to be able to manually enter a date and time without the Calendar control popping up when they type.  As stated in my original post, we fixed the issue by modifying the _change function by altering the line:
this._setValue(parsedDate);
to this:
this._setValue(parsedDate, 0);
Again, sorry for the responding so late.  I'll keep checking the post for updates. Thanks!

Yes, that's I think the same issue as the one we are having.
Here's a video describing the issue: https://puu.sh/GnV9C/4fbb506c89.mp4
As you can see, the selected date is never updated unless modified through the calendar picker or when the value is cleared in its entirety. ( I used the same fiddle from my post above: https://jsfiddle.net/0fcmrn1w/1/ )

I'm behind :)  When I wrote my comment yesterday, I didn't notice that you (@sgentens) pointed out to @tonix-tuft the same thing I noticed - not having the data-toggle on the INPUT field.  The problem is, we want to be able get the value of the date using:
$("#datetimePicker").data("datetimepicker").date()
without concerning ourselves on HOW the date was entered (whether it was selected from the control or entered manually).
Obviously, we cannot do that with how it works today since the date() method is only returning dates that were selected within the control.  Modifying the _change function by adding the 0 parameter to the _setValue method fixes it as described in
https://github.com/tempusdominus/bootstrap-4/issues/321
Hoping to hear back from @tonix-tuft.
Thanks!

I am reopening this issue and will be back to you asap guys!

OK guys,
I have released v5.32.1, it features this bugfix thanks to @jweidner711's suggestion:
- this._setValue(parsedDate);
+ this._setValue(parsedDate, 0);

The only thing you have to be aware of:
If you use your picker with the allowMultidate option set to true (which allows setting more than one date on the picker), then you have (at least for now) to live with the fact that you will only be able to change the first date if you change the input field directly instead of using the picker widget (i.e., only the leftmost date in the input field will change).
Let me know if everything works for you both now, and I will close this issue. Thank you!

Tested it both in the fiddle and in our base module, seems to work perfectly! Thanks!

@sgentens Good to know! @jweidner711 Should I close this now? Does this fix work for you too?

Thanks @tonix-tuft!  I probably won't have a chance to test it till next Tuesday.  But as soon as I do, I'll let you know!  Thanks again for your quick response.  Appreciate it.  I'll be in touch.

@tonix-tuft  - Downloading it now - I'll update you as soon as I know,

@tonix-tuft It works!  Thank you again for the fast turn-around.

Also, remember that if you use React, I have ported this project to React as well:
https://github.com/tonix-tuft/react-tempusdominus-bootstrap
😃

Ok.  Thanks again!


Add an ADR for Pagination

The AP team are preparing to add pagination / filtering to an endpoint.  Ahead of this, I wanted to get everyone’s eyes on a possible approach, so we can make sure we’re all aligned.

@brownbearsoftware

I would suggest that maybe instead of the pageNumber query parameter being absent meaning page 1 it should mean return everything to preserve current behaviour or we'll encounter weird behaviour when trying to roll this out. We could then change this to mean page 1 once the frontend is fully deployed.

Great idea!

Closing this in favour of #859, which has the implementation too.


number of snaps to take then exit

It would be nice to be able to specify the count of snaps to take and then exit.
use case:
 I would like to schedule a set of snaps to be taken for upcoming OP.  I can make a script that I can start from cron and have it exit after taking so many pictures.

(not sure how to apply a label, but this is an enhancement)

Done :smile: Please update your ice :)


Add xQueueUnblock function to unblock threads waiting on a queue

Related to #1113
Add xQueueUnblock function to unblock threads waiting on a queue.

Add xQueueUnblock(QueueHandle_t) function to queue.c to unblock threads waiting on a queue.
Update xQueueGenericSend and xQueueReceive functions to handle the new unblock functionality.
Add necessary headers and setup functions for the new xQueueUnblock function.
Include usage examples and explanations in the documentation for xQueueUnblock.

So many error are still persists please add in comments I will work of fixing those

Hi @vishwamartur
Thank you for your contribution . I see this is a change in the FreeRTOS Kernel repository primarily. Can you please help in raising a PR to this repository  directly.

Closing this PR as this PR should be opened to the Kernel repo as per @kar-rahul-aws's suggestion.


It doesnt´t work for me the "Usage on Android"

I tried this but it doesn't work for me:
In android/app/AndroidManifest
<application ...
  android:networkSecurityConfig="@xml/network_security_config" >

 <meta-data android:name="io.flutter.network-policy"
        android:resource="@xml/network_security_config"/>

Then create a folder xml inside create a file: network_security_config.xml
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
  <base-config cleartextTrafficPermitted="true">
     <trust-anchors>
        <certificates src="system" />
    </trust-anchors>
  </base-config>
 </network-security-config>

I replaced for that and works!
Add  usesCleartextTraffic in your Android Manifest file, located in <project_root>/android/app/src/main/AndroidManifest.xml
<manifest>
    <application android:usesCleartextTraffic="true">...</aplication>
</manifest>

PD: Works fine with 2 physical devices on network with internet connection, but when a create a Hospot in a device without internet connection the LAN communication doesn´t work anymore :C

I'm assuming the problem is with dio on the hotspot without a internet connection. However, i will look into this issue and see if i can solve it

Thanks! uwu

It still works fine for me when I used hotspot with no internet access.
But I have an Android (Lenovo K520) that can't forward the broadcast (xxx.xxx.xxx.255) to another devices, but everything else (Start Server, Start Client,  Receive Data, Send Data) is fine. Not sure this problem from dio, another package, or the phone itself.

I've tested it only one time. I will test it with other and the same devices, and I'm going to tell you the updates :)

Haven't heard further problems so closing for now. Reopen if the problem persists


Current tech issues

[ ] Student argocd instance has permission issues deploying into cluster
[ ] Git Icon on Menu and naming for all clusters
[x] oc credentials not working
[ ] oc endpoints will not open - just print the urls, don't provide selection
[ ] Cannot find way of logging into SonarQube to see if projects were created
[ ] Point IBM Cloud account to IBM Image Registry

endpoint command in igc has been updated. The image build(s) are in progress to pick up the change

@mjperrins Do you still have the issue with SonarQube?

you shouldn't need to log in to see the results, and
if you want to log in, hopefully the fix to oc credentials will help with that


Remove @lint markers which are now deprecated in Credo.

Coverage increased (+0.1%) to 84.138% when pulling e0bbeb56e1bdba9bfb80e0e44b2ed34480a869ec on remove-lint-markers into 5e5b6f8606e46b55d0ad9eaf2603e7f8ead29edf on master.


[Firefox][SCM] "Staged changes" and "Changes" disappear when "Incoming/outgoing" appears

Steps to Reproduce:

Open a directory with Git initialized.
Make "Incoming/Outgoing" section in the SCM pane appear. Could be done by either:

Make sure the current branch has an upstream branch, then commit something. Or
Set scm.showIncomingChanges and scm.showOutgoingChanges to always.

Refresh the page.
Make a change to a file.

Expected result: the file appears under "Changes" section in SCM pane.
Actual result: the "Changes" section doesn't appear in SCM pane.

Run git add <such file>

Expected result: the file appears under "Staged changes" section in SCM pane.
Actual result: the "Staged changes" section doesn't appear in SCM pane.

Happens on Firefox 121.0, Ubuntu 22.04. Doesn't seem to happen on Chromium 120 and WebKitGTK 2.42.3.

Expected behavior (Chromium 120)
Actual behavior (Firefox 121)

Happens in GitHub Codespaces:
Version: 1.85.1
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0
Embedder: codespaces

Also happens with code-server:
code-server: v4.20.0
Code: 1.85.1
Commit: 0b84523121d6302fbe30eda7899ec3b81810748e
Date: 2023-12-18T20:21:20.879Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Also happens with OpenVSCode Server insider:
Version: 1.86.0-insider
Commit: 54192b6218e127145f30f2d5194f4d8ec8db68e0
Date: 2023-12-29T23:13:22.924Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

I'm experiencing the same or a very similar issue in latest code-server using Firefox. I can no longer open the repository in source control if there are any incoming/outgoing changes and instead am getting an ERR Invalid comparison: compare@https://srp.nico.re:8443/stable-0b84523121d6302fbe30eda7899ec3b81810748e/static/out/vs/workbench/workbench.web.main.js:2573:100714 exception in the browser console without the repository opening. Likely the reason the issue appears slightly differently for me is because I have multiple repositories in source control.
For anyone else affected the following settings are making this issue to not occur:
"scm.showIncomingChanges": "never",
"scm.showOutgoingChanges": "never"

Same here but not consistent:
Version: 1.85.1 (user setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Tested with OpenVSCode-server insiders, which is rebased on top of commit 48905201c0ae ("Sanity Bounds for "window.zoomLevel" (fix #152028) (#202682)") [1]. The issue still exists. code-server doesn't release insider builds, and I don't know how to test insider builds of GitHub codespaces' web UI, so I can't test those.
(Off topic, but does GitHub codespaces provide an insider build for web interface by any chance?)
[1]:
Version: 1.86.0-insider
Commit: 6f047b7a9a3b97fc67e82cc923774a709f48bffe
Date: 2024-01-17T23:13:45.240Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Thank you. Tested with the GitHub Codespaces + VSCode insiders [1], the issue can still be reproduced.
Interestingly, if I change the scm.show{Incoming,Outgoing}Changes to never and then to always again, the "Source control" pane essentially freeze: the "Incoming/Outgoing" section doesn't comeback, and further changes to the working directory is not shown anymore (like, if you add another file, it doesn't show up, even after I click "Refresh" button).
[1]
Version: 1.86.0-insider
Commit: 800e60abdfb1675a59520bac6a9473bc380d49ea
Date: 2024-01-23T06:18:07.155Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

@peat-psuwit, thanks for trying this out. Could you please confirm that this indeed can only be reproduce in Firefox and everything works as expected in a Chromium based browser (ex: Chrome, Edge, etc)?
Could you please the developer tools console and see if there are any relevant errors there?
Could you also invoke the "Git: Show Git Output" command and send me the contents of it?

@peat-psuwit, thanks for trying this out. Could you please confirm that this indeed can only be reproduce in Firefox and everything works as expected in a Chromium based browser (ex: Chrome, Edge, etc)?

Yes. This only happens in Firefox. It doesn't happen in Chromium [1], and Gnome Web (WebKit-based) [2].

[1]

Version: 1.86.0-insider
Commit: 800e60abdfb1675a59520bac6a9473bc380d49ea
Date: 2024-01-23T06:18:07.155Z
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

[2]

Version: 1.86.0-insider
Commit: 800e60abdfb1675a59520bac6a9473bc380d49ea
Date: 2024-01-23T06:18:07.155Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15

Could you please the developer tools console and see if there are any relevant errors there?

There seems to be. As soon as I change scm.showIncomingChanges to always, this error pops up in the brower's console. And it seems to pop up every time I press "Refresh" in the source control pane too.

Uncaught (in promise) Error: Invalid comparison
    compare scmViewPane.ts:1184
    K asyncDataTree.ts:1082
    K asyncDataTree.ts:1390
    z asyncDataTree.ts:911
    w async.ts:27
    F asyncDataTree.ts:911
    E asyncDataTree.ts:865
    D asyncDataTree.ts:848
    C asyncDataTree.ts:834
    B asyncDataTree.ts:804
    z asyncDataTree.ts:556
    updateChildren asyncDataTree.ts:542
    Cc scmViewPane.ts:3145
    a async.ts:239
    promise callback*queue async.ts:239
    Cc scmViewPane.ts:3136
    queue async.ts:216
    Cc scmViewPane.ts:3135
    W scmViewPane.ts:2723
    y event.ts:1127
    fire event.ts:1158
    z event.ts:152
    y event.ts:1127
    z event.ts:1138
    fire event.ts:1162
    Lb configurationService.ts:1114
    wb configurationService.ts:813
    reloadLocalUserConfiguration configurationService.ts:654
    Hb configurationService.ts:1040
    updateValue configurationService.ts:361
    updateValue configurationService.ts:361
    Pc settingsEditor2.ts:1106
    Mc settingsEditor2.ts:1015
    b async.ts:349
    promise callback*trigger async.ts:343
    Mc settingsEditor2.ts:1015
    Lc settingsEditor2.ts:912
    ge event.ts:169
    y event.ts:1127

Could you also invoke the "Git: Show Git Output" command and send me the contents of it?

Here it is. Although, I'm not sure how useful it is.

2024-01-23 10:40:31.442 [info] Log level: Info
2024-01-23 10:40:31.442 [info] Validating found git in: "git"
2024-01-23 10:40:31.442 [info] Using git "2.43.0" from "git"
2024-01-23 10:40:31.442 [info] > git rev-parse --show-toplevel [126ms]
2024-01-23 10:40:31.442 [info] > git rev-parse --git-dir --git-common-dir [9ms]
2024-01-23 10:40:31.442 [info] Open repository: /workspaces/core-base
2024-01-23 10:40:31.442 [info] > git config --get commit.template [78ms]
2024-01-23 10:40:31.442 [info] > git rev-parse --show-toplevel [65ms]
2024-01-23 10:40:31.481 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/main refs/remotes/main [22ms]
2024-01-23 10:40:31.483 [info] > git rev-parse --show-toplevel [5ms]
2024-01-23 10:40:31.501 [warning] ENOENT: no such file or directory, open '/workspaces/core-base/.git/refs/remotes/origin/main'
2024-01-23 10:40:31.523 [info] > git rev-parse --show-toplevel [5ms]
2024-01-23 10:40:31.523 [info] > git rev-parse refs/remotes/origin/main [23ms]
2024-01-23 10:40:31.630 [info] > git status -z -uall [89ms]
2024-01-23 10:40:31.631 [info] > git rev-parse --show-toplevel [70ms]
2024-01-23 10:40:31.674 [info] > git rev-parse --show-toplevel [18ms]
2024-01-23 10:40:31.675 [info] > git config --get commit.template [4ms]
2024-01-23 10:40:31.716 [info] > git rev-parse --show-toplevel [26ms]
2024-01-23 10:40:31.718 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/main refs/remotes/main [12ms]
2024-01-23 10:40:31.736 [warning] ENOENT: no such file or directory, open '/workspaces/core-base/.git/refs/remotes/origin/main'
2024-01-23 10:40:31.755 [info] > git rev-parse refs/remotes/origin/main [20ms]
2024-01-23 10:40:31.784 [info] > git merge-base refs/heads/main refs/remotes/origin/main [30ms]
2024-01-23 10:40:31.855 [info] > git status -z -uall [84ms]
2024-01-23 10:40:31.863 [info] > git rev-list --count --left-right refs/heads/main...refs/remotes/origin/main [17ms]
2024-01-23 10:40:33.111 [info] > git config --local branch.main.github-pr-owner-number [138ms]
2024-01-23 10:40:33.111 [warning] git config failed: Failed to execute git
2024-01-23 10:40:49.678 [info] > git config --get commit.template [2ms]
2024-01-23 10:40:49.709 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/main refs/remotes/main [5ms]
2024-01-23 10:40:49.732 [warning] ENOENT: no such file or directory, open '/workspaces/core-base/.git/refs/remotes/origin/main'
2024-01-23 10:40:49.733 [info] > git rev-parse refs/remotes/origin/main [1ms]
2024-01-23 10:40:49.768 [info] > git status -z -uall [9ms]
2024-01-23 10:40:49.854 [info] > git merge-base refs/heads/main refs/remotes/origin/main [2ms]
2024-01-23 10:40:49.873 [info] > git rev-list --count --left-right refs/heads/main...refs/remotes/origin/main [2ms]
2024-01-23 10:41:41.011 [info] > git config --get commit.template [15ms]
2024-01-23 10:41:41.012 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/main refs/remotes/main [3ms]
2024-01-23 10:41:41.026 [warning] ENOENT: no such file or directory, open '/workspaces/core-base/.git/refs/remotes/origin/main'
2024-01-23 10:41:41.029 [info] > git rev-parse refs/remotes/origin/main [2ms]
2024-01-23 10:41:41.049 [info] > git status -z -uall [7ms]
2024-01-23 10:41:41.112 [info] > git merge-base refs/heads/main refs/remotes/origin/main [2ms]
2024-01-23 10:41:41.131 [info] > git rev-list --count --left-right refs/heads/main...refs/remotes/origin/main [3ms]


recaptcha plugin not working in new version of puppeteer-real-browser?

I add the recaptcha plugin to the plugins section, but when I use page.solveRecaptchas();, I unexpectedly receive the Error: TimeoutError: Waiting failed: 10000ms exceeded error.
Or sometimes it doesn't give an error but it doesn't solve the captcha. The same code was fine in older versions.
There was no such problem in the old version when we integrated it directly into the index.js file. But now I need to switch to the new version and there is a problem.
const RecaptchaPlugin = require('puppeteer-extra-plugin-recaptcha');

const { page, browser } = await connect({
        tf: false,
        turnstile: true,
        args: [
          '--aggressive-cache-discard',
          '--disable-cache',
          '--lang=en-US',
          '--intl.accept_languages=en-US',
        ],
        headless: 'auto',
        customConfig: {},
        skipTarget: [],
        fingerprint: true,
        turnstile: true,
        connectOption: {},
        plugins: [
          RecaptchaPlugin({
            provider: {
              id: '2captcha',
              token: apiKey,
            },
            visualFeedback: true,
            throwOnError: true
          })
        ]
      });```

https://github.com/zfcsoftware/puppeteer-real-browser/issues/32#issuecomment-2338933954
If the problem persists, simply report it here.


chore: release v2.6.7

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.274%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
318

Relevant Lines:
346

💛  - Coveralls


WIP Team single page refactor to allow for exclusions

REF https://vmware.slack.com/archives/D04B9R7M1BK/p1679961136815989?thread_ts=1679674200.982109&cid=D04B9R7M1BK

#2685 Refactor performed here. Will open new PR for advocate specific requests.


Asset 367: wrong answer ID for Bupropion

This asset currently uses PUBCHEM.COMPOUND:3031065 as the expected answer ID for Bupropion. But this chemical appears to have a different structure than Bupropion (the chlorine on its ring is in a diff position compared to Bupropion). I also think the NodeNorm entry for this ID seems odd: none of the ID labels are bupropion (Dev NodeNorm).
Instead, there's another entity with the name Bupropion and lots of equivalent IDs, including the PUBCHEM.COMPOUND:444 that I referenced above: CHEBI:3219.
This shows up in BTE's results with a high score/rank (top 10%).
I think the answer ID for this test needs to be changed.

Updated issue: figured out that the wrong ID is being used, so this isn't a synonymization issue.

Confirmed CHEBI:3219 with Name Resolver.


Tests for App-Gimei-v0.1.1 have started to fail

The following two reports were generated before and after I installed YOUPONG/Data-Gimei-v0.4.0.tar.gz for that perl:

before, pass: http://www.cpantesters.org/cpan/report/eb559220-4532-11ed-aad1-25a89cedbcb2
after, fail: http://www.cpantesters.org/cpan/report/fe63a942-4532-11ed-8191-96a89cedbcb2

Thank you for the report.　I have released the supported version.
Try App-Gimei-v0.2.0.


[Site]: support structured schema (JSON-LD)

Current State
Description of the current state/issue: For each page under the Apache APISIX Website, we don't provide a structured schema for search engines, so the search engine has to try to understand each page's content meaning. Structured Schema is an Advanced SEO solution, please refer to the following links for more information.

https://moz.com/blog/json-ld-for-beginners
https://developers.google.com/search/docs/advanced/structured-data/intro-structured-data
https://stackoverflow.com/questions/38670851/whats-a-script-type-application-ldjsonjsonobj-script-in-a-head-sec/38745339#38745339
https://support.google.com/knowledgepanel/answer/9163198?hl=zh-Hans&ref_topic=9164489
https://developers.google.com/search/docs/advanced/guidelines/get-started

Desired State
Validator Tools: https://validator.schema.org/

If we need a good type prompt, we can use https://www.npmjs.com/package/schema-dts.

I'm interested to contribute on this one. It can be a quick win.

Hi, Nicolas, Thanks!!

I've checked in more detail and it's not as quick a win as I thought.
The number of items is pretty limited. I believe we can use How-To and Article quite easily. Others, such as Learning Video and Software App are a bit harder to push in.
Hence, I think I could start with one article from the blog and see what I can make out of it.

@juzhiyuan @nfrankel @SkyeYoung we have to work on this to improve discoverability in Google. From experience, adding schema to the site can help in getting a "Knowledge Panel" in Google search. @SkyeYoung With your help, I can probably look into what we can do and take this forward.

Yes, I wanted to work on that months ago... and did nothing. Feel free to own it


Poor Voice quality

Hi Twilio Support,
Some of our customers are reporting issues with poor voice quality on incoming and outgoing calls in the iPhone app. Is there any way to resolve this? The iPhone build uses Twilio Voice 2.0.0- beta14.

Hi @bchen-twilio
I will provide you Call SIDs of all the users who are facing the issue.
Thanks

@ojhakapil Much appreciated! 👍

Closing this issue. Please feel free to open a new issue if you run into poor audio quality issue in the future.


Could You port it to asyncio?

https://github.com/kszucs/asyncpw
I've tried to use asyncpg (only postgres) as backend, but gut stuck.
Here is the diff: https://github.com/snower/torpeewee/compare/master...kszucs:master
There is no usable asyncio orm right now.

Already supported!


chore(changesets): use .cjs file extension for the changeset-version script

🎯 Changes

used a .cjs file extension for the changeset-version script

✅ Checklist

[x] I have followed every step in the contributing guide.
[x] If necessary, I have added or updated the tests related to the changes made.
[x] If necessary, I have added documentation related to the changes made.

Current dependencies on/for this PR:

main

PR #23   👈

This comment was auto-generated by Graphite.


add Comparison to Batsh to readme

https://github.com/BYVoid/Batsh Looks promising. Though I'm mostly a JS dev.

..and jsh while at it..
Notable difference with both is that nscripts are written in plain javascript (or TypeScript / CoffeeScript)


fix: restore cli mode

fix: restore cli mode

:tada: This PR is included in version 6.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Official Debian package

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I am able to build 1.10.0 but get these lintian errors and warnings:
E: memray: arch-independent-package-contains-binary-or-object [usr/lib/python3/dist-packages/memray/_inject.abi3.so]
E: memray: arch-independent-package-contains-binary-or-object [usr/lib/python3/dist-packages/memray/_memray.cpython-311-x86_64-linux-gnu.so]
E: memray: arch-independent-package-contains-binary-or-object [usr/lib/python3/dist-packages/memray/_memray.cpython-312-x86_64-linux-gnu.so]
E: memray: arch-independent-package-contains-binary-or-object [usr/lib/python3/dist-packages/memray/_test_utils.cpython-311-x86_64-linux-gnu.so]
E: memray: arch-independent-package-contains-binary-or-object [usr/lib/python3/dist-packages/memray/_test_utils.cpython-312-x86_64-linux-gnu.so]
E: memray: helper-templates-in-copyright
E: memray: missing-dependency-on-libc needed by usr/lib/python3/dist-packages/memray/_inject.abi3.so and 4 others
E: memray: privacy-breach-uses-embedded-file You may use the libjs-bootstrap package<EMAIL_ADDRESS>E: memray: privacy-breach-uses-embedded-file You may use the libjs-jquery package<EMAIL_ADDRESS>[usr/lib/pyth
E: memray source: source-is-missing [docs/_static/flamegraphs/memray-flamegraph-fib.html]
E: memray source: source-is-missing [docs/_static/flamegraphs/memray-flamegraph-mandelbrot.html]
E: memray source: source-is-missing [docs/_static/flamegraphs/memray-flamegraph-nbody.html]
E: memray source: source-is-missing [docs/_static/flamegraphs/memray-flamegraph-sqlite.html]
E: memray source: source-is-missing [src/memray/reporters/templates/assets/flamegraph.js]
E: memray source: source-is-missing [src/memray/reporters/templates/assets/flamegraph_common.js]
E: memray source: source-is-missing [src/memray/reporters/templates/assets/table.js]
E: memray source: source-is-missing [src/memray/reporters/templates/assets/temporal_flamegraph.js]
E: memray: unstripped-binary-or-object [usr/lib/python3/dist-packages/memray/_inject.abi3.so]
E: memray: unstripped-binary-or-object [usr/lib/python3/dist-packages/memray/_memray.cpython-311-x86_64-linux-gnu.so]
E: memray: unstripped-binary-or-object [usr/lib/python3/dist-packages/memray/_memray.cpython-312-x86_64-linux-gnu.so]
E: memray: unstripped-binary-or-object [usr/lib/python3/dist-packages/memray/_test_utils.cpython-311-x86_64-linux-gnu.so]
E: memray: unstripped-binary-or-object [usr/lib/python3/dist-packages/memray/_test_utils.cpython-312-x86_64-linux-gnu.so]
W: memray source: dh-make-template-in-source [debian/manpage.1.ex]
W: memray: no-manual-page [usr/bin/memray3.11]
W: memray: no-manual-page [usr/bin/memray3.12]
W: memray: no-manual-page [usr/bin/memray]
W: memray: privacy-breach-generic [<script src="https://cdn.datatables.net/1.10.23/js/datatables.bootstrap4.min.js">] (https://cdn.datatables.net/1.10.23/js/da
W: memray: privacy-breach-generic [<script src="https://cdn.datatables.net/1.10.23/js/jquery.datatables.min.js">] (https://cdn.datatables.net/1.10.23/js/jquery
W: memray: privacy-breach-generic [<script<EMAIL_ADDRESS>(https://cdn.jsdelivr.net/npm/d3
W: memray: privacy-breach-generic [<script<EMAIL_ADDRESS><EMAIL_ADDRESS>W: memray: privacy-breach-generic [<script<EMAIL_ADDRESS><EMAIL_ADDRESS>W: memray: privacy-breach-generic [<script<EMAIL_ADDRESS><EMAIL_ADDRESS>W: memray: privacy-breach-generic [<script<EMAIL_ADDRESS>(https://cdn.jsdelivr.net/npm/popper.js
W: memray: privacy-breach-generic [<script src="https://d3js.org/d3-scale-chromatic.v1.min.js">] (https://d3js.org/d3-scale-chromatic.v1.min.js) [usr/lib/pytho
W: memray: privacy-breach-generic [<script src="https://d3js.org/d3.v4.min.js" charset="utf-8">] (https://d3js.org/d3.v4.min.js) [usr/lib/python3/dist-packages
W: memray: python-module-in-wrong-location usr/lib/python3.12/dist-packages/memray-1.10.0.egg-info -> usr/lib/python3/dist-packages/memray-1.10.0.egg-info
W: memray source: space-in-std-shortname-in-dep5-copyright <special license> [debian/copyright:11]
W: memray: unusual-interpreter /usr/bin/python3.12 [usr/bin/memray3.12]

With 1.11.0 I fail completely with this build log:
http://sid.ethz.ch/debian/memray/memray_1.11.0-1_amd64.build
Expected Behavior
1.11.0 should build, and 1.10.0 should have no warnings and errors
Steps To Reproduce
On Debian GNU/Linux with sid/unstable
dget the source (*.dsc) and build it with debuild
Memray Version
1.10.0 and 1.11.0
Python Version
3.11
Operating System
Linux
Anything else?
No response

Hi @alexmyczko and thanks for opening the issue. Looking at the build failures I am seeing the following:
x86_64-linux-gnu-gcc -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -g -fwrapv -O2 -g -O2 -ffile-prefix-map=/var/www/debian/memray/memray-1.11.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -D_FILE_OFFSET_BITS=64 -DUSE_MEMRAY_TLS_MODEL=1 -Isrc/memray/_memray -I/usr/include/x86_64-linux-gnu -Isrc -I/var/www/debian/memray/memray-1.11.0/src/vendor/libbacktrace/install/include -I/usr/include/python3.11 -c src/memray/_memray.cpp -o build/temp.linux-x86_64-cpython-311/src/memray/_memray.o -std=c++17 -Wall -flto -fvisibility=hidden
src/memray/_memray.cpp: In function ‘int __pyx_pf_6memray_7_memray_7Tracker___cinit__(__pyx_obj_6memray_7_memray_Tracker*, PyObject*, PyObject*, bool, unsigned int, bool, bool, __pyx_t_6memray_7_memray_FileFormat)’:
src/memray/_memray.cpp:11950:48: error: too few arguments to function ‘std::unique_ptr<memray::tracking_api::RecordWriter> memray::tracking_api::createRecordWriter(std::unique_ptr<memray::io::Sink>, const std::string&, bool, FileFormat, bool)’
11950 |     __pyx_t_8 = memray::api::createRecordWriter(cython_std::move<std::unique_ptr<memray::io::Sink> >(__pyx_t_7), __pyx_v_command_line, __pyx_v_native_traces, ((enum memray::tracking_api::FileFormat)__pyx_v_file_format));
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/memray/_memray.cpp:859:
src/memray/_memray/record_writer.h:61:1: note: declared here
   61 | createRecordWriter(
      | ^~~~~~~~~~~~~~~~~~
error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1

This doesn't make any sense to me, it looks like you have not regenerated the Python sources. I can build memray locally without any problems and the CI can build it as well so this must be some problem in your Debian rules file or the way you are building the package. Unfortunately we cannot help more here unless you provide us with a reproducer that doesn't use any Debian infrastructure.

For more details, notice that src/memray/_memray.cpp is generated during the build process and these are the lines generated from the latest version:
    __pyx_t_9 = memray::api::createRecordWriter(cython_std::move<std::unique_ptr<memray::io::Sink> >(__PYX_STD_MOVE_IF_SUPPORTED(__pyx_t_8)), __pyx_v_command_line, __pyx_v_native_traces, ((enum memray::tracking_api::FileFormat)__pyx_v_file_format), __pyx_v_trace_python_allocators);

as you can see there, the call is totally different and includes __pyx_v_trace_python_allocators which is not in your build logs.

Hi @pablogsal that hint about src/memray/*.cpp was already helpful, thank you.

E: memray: arch-independent-package-contains-binary-or-object [usr/lib/python3/dist-packages/memray/_inject.abi3.so]

This error in particular indicates that you're trying to produce an architecture-independent package for Memray. That's wrong: memray includes native code, and needs to be compiled for each architecture. We support x86-64 (aka amd64) and aarch64 (aka amd64). So at least one problem that you've got here is that you've declared that the package should be architecture-independent, rather than architecture-dependent.

The ITP link is https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1009970

Ok now when I try to run it get this:
memray -h
Traceback (most recent call last):
  File "/usr/bin/memray", line 33, in <module>
    sys.exit(load_entry_point('memray==1.11.0', 'console_scripts', 'memray')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/bin/memray", line 25, in importlib_load_entry_point
    return next(matches).load()
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/importlib/metadata/__init__.py", line 202, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/lib/python3/dist-packages/memray/__main__.py", line 3, in <module>
    from memray.commands import main
  File "/usr/lib/python3/dist-packages/memray/commands/__init__.py", line 19, in <module>
    from . import attach
  File "/usr/lib/python3/dist-packages/memray/commands/attach.py", line 19, in <module>
    from .live import LiveCommand
  File "/usr/lib/python3/dist-packages/memray/commands/live.py", line 7, in <module>
    from memray.reporters.tui import TUIApp
  File "/usr/lib/python3/dist-packages/memray/reporters/tui.py", line 30, in <module>
    from textual.app import ComposeResult
ImportError: cannot import name 'ComposeResult' from 'textual.app' (/usr/lib/python3/dist-packages/textual/app.py)
root@phd-sid:/var/www/debian/memray# ls -la /usr/lib/python3/dist-packages/textual/app.py
-rw-r--r-- 1 root root 18220 Jan  5  2022 /usr/lib/python3/dist-packages/textual/app.py
root@phd-sid:/var/www/debian/memray# dpkg -S /usr/lib/python3/dist-packages/textual/app.py
python3-textual: /usr/lib/python3/dist-packages/textual/app.py
root@phd-sid:/var/www/debian/memray# dpkg -l python3-textual
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name            Version      Architecture Description
+++-===============-============-============-=================================================================================
ii  python3-textual 0.1.13-1     all          TUI (Text User Interface) framework for Python inspired by modern web development

This is because you seem to be using textual 0.1.13 while our requirement (check setup.py) is textual >= 0.34.0

that is what i thought, what was confirmed yesterday on irc. and why i posted the version ;)

Ooh, that's a mistake on our part... it looks like we actually require at least Textual 0.39 now. Can you try with that version, @alexmyczko?

Alternatively, if you aren't able to upgrade Textual to (at least) 0.39 yet, you should be able to build and run Memray 1.10 (one version older than the newest) with Textual 0.34. The dependency on features that require 0.39 came with Memray 1.11.

Correction: it looks like the minimum Textual version we support from Memray 1.11 on is now Textual 0.41, not Textual 0.39 (I've corrected my two comments above).

0.41.0 is no problem: https://sid.ethz.ch/debian/memray/python3-textual/
can confirm memray runs now.

I don't think there's anything left to do for this particular issue.
Let me know if I'm wrong, @alexmyczko.

well i'd really like to get this packaged for debian main, but i think i'll have to remove
docs, tests, and src/memray/reporters will it still be useful for live/cli only mode? is building/running it that way supported somehow?

and src/memray/reporters will it still be useful for live/cli only mode?

Removing the reporters directory will make memray unusable and broken and is certainly not supported. Please, do not package memray that way

and i'd like to also de-vendor src/vendor/libbacktrace, is that supported?

Not only it is not supported but it also won't work because we keep some patches on top of libbacktrace so it's not just a plain vendoring but a fork.

perfect answer. so there must be a way to selfhost the html stuff. and thanks for the info on libbacktrace


Allow setting of the cache driver via an env var.

This closes #487 where APC doesn't work on Azure.

Just rebased the last commit in master.


Updating org.json:json dependency

Updating Dependency:
org.json:json:  20201115 -> 20231013

/azp run java - core - ci

/azp run java - core

/azp run java - core - ci

Preview cloud is failing due to deployment, all other clouds pass. Since this is an update on non-released code, I'll override check enforcer for this PR

/check-enforcer override


Create array dialog's default array size can overwrite exising code

The current code logic only takes account into the next data variable or the segment end, and it ignores the next basic block, which could cause the default size to be too large

This will be fixed by https://github.com/Vector35/binaryninja-api/compare/test_improve_create_array

This should call 'GetNextUnknownDataEnd'


Half hexes

[ ] Option to only draw half of a hex (with proper border)
[ ] Option to cut half a row off at a game/map level

I hit this as a blocker while trying to transcribe a prototype into 18xx-maker. The London offboard is impossible to represent without giving it the same color as the ports


Fix missing platform info

As defined in the web api, OicDeviceInfo must contain platform info.
Use case is:
perform multicast discovery of devices
Expected: for each device the OicDeviceInfo contains device and platform info

Issue:

At the C API level (OCDoResource and OCClientResponse)
Following deivce discovery OCClientResponse provides devAddr
So devAddr can be used directly to make a unicast query for the platform info of the device.
At the C++ API level (OCPlatform::getDeviceInfo and OCRepresentation)
there is no such direct link
When retrieving device info we have to:

retrieve resources from this device
then, once the resources are retrieved get the resource host, which is the host of the device
then use this host to make a unicast request for each platform info

It is possible to do but not efficient in temrs of processing and number of requests sent

Note: this issue is not relevant for iotivity-node as it uses the C API.
@poussa, @zolkis, am I missing something?
Providing host info at OCRepresentation level would simplify things.

You are right, they should be optional (nullable). And it is a good question if there should be separate function for platform discovery, or should we bound them together, as you seem to have understood.
Looks like the C++ API is out of sync with the OIC Core spec 1.0. Platform should be a core resource on each instance of an OIC device. If getting platform for a device (supposedly a local operation) is not supported in the C++ API, I think we should not work that around in the JS API. We just leave it as null. Or, use the C API...
In general, in the API when we use a structure, it is not guaranteed that a given operation provides all properties of that structure. So it is not a problem if platform info is missing after discovery, but we do need to fix the API, and does need to be documented.
As an example on partial information, when doing device discovery, only a list of device id's (UUID) is returned, eventually together with a list of { resourceURL, resourceType, interfaces } per device. But the (partial) resource list may be missing. If present, a retrieve operation can be made right away, otherwise a resource discovery is needed.
Anyway, I am going to fix the spec. Also, I have added a new file describing the new version of the high level spec. Both are in this PR:
https://github.com/otcshare/iotivity-node/pull/30/files
Take a look, and if you have any feedback, we can still modify the API relatively easily.
It would be nice to get this kind of feedback as early and as much as possible. Thank you!

Looks like the C++ API is out of sync with the OIC Core spec 1.0. Platform should be a core resource on each instance of an OIC device. If getting platform for a device (supposedly a local operation) is not supported in the C++ API, I think we should not work that around in the JS API. We just leave it as null. Or, use the C API...

In fact the C++ API permits retrieval of both platform and device info (independently), so it complies with the spec there.
The issue is when doing multicast oic/d and oic/p discovery info with C++ API:

multiple device and platform info are retrieved from all the other hosts on the network.
But there is no means in the C++ API to map device to platform info.
In C API this is straightforward using OCClientResponse->devAddr

We just leave it as null.

OK. But then the web API provides no platform info.

Or, use the C API...

OK.
hm, how about fixing the C++ API? E.G: providing host info in OCRepresentation.

Yes, it needs to be fixed in IoTivity (my point was only that we should not work around it in the JS API). Please file a bug.

https://jira.iotivity.org/browse/IOT-828


Update pl.json [27.03.2024]

Updated missing lines in pl.json,
match everything so it will be same as en.json.

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update

What is the current behavior? (You can also link to an open issue here)
Missing lines

What is the new behavior (if this is a feature change)?
Added new lines

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Comment below

@chrismaltby
I believe there is some bug in GBS 3.2.1 when it comes to "pop-up tips/hints".
When you hover on some command (Add event -> whatever command, example: Show Dialog)
the pop up hint is in English, although it is already translated in the file.
Maybe I should also open an issue about this.

Closing this PR, since there is already a new PR with more content.


multiple spawn_local call in single microtask. is it intended?

Since the documentation said "The future will always be run on the next microtask tick", I thought that multiple spawn_local would run on each different ticks. So I used spawn_local a lot.
But there are frame drops. When I did some profiling, the spawn_locals I called multiple times were all running in one tick, interfering with the animation frame.
Is this intentional? Do I have to use a trick to use something like setTimeout outside of spawn_local to not affect the animation frame?

Scheduling is done on the microtask tick with promise.then(...) to schedule the next callback. If that interferes with animation frames then you'll want to use setTimeout or similar, yeah.


Issue #56 - refactor permission checks

Separate permission check concerns and allow for override by derived class

Thanks for this. Can you just give me a use case or two for why one would want to override these methods? The behaviour and need is pretty platform driven and there is a means to disable it, what else would you want to do in your overrides? Sorry to be a bit of a stickler for this, just make sure that if in the future we look back on some of this flexibility and ask ourselves why we have a good reason. :+1:

No worries on the questions Andrew, actually encourage that you ask them.  The conversation ultimately leads to a better product whether the ideas are included or not included.
For some background, see the comment I just made in PR #71.  In short, we can't rely on standard SFDC security and have to custom roll our own checks.
My thinking with this PR is to separate the "permission check" concern from the handle methods.  It's similar to the way onApplyDefaults is separated in the before insert handler.  It would be easy enough to set defaults in the handleBeforeInsert but by separating it out to its own concern, it makes the code much easier to read, maintain and test.  For my situation, I could have the base class check security based on EnforceCRUD setting and then in my onBeforeXXX handlers, check custom security.  Similar to onApplyDefaults, separating the concern provides a discrete location to perform security checking.  I'm viewing security checking (like default setting, etc.) as an underlying core concept that always need to be evaluated (unless disabled) so that is the basis for this PR.  In short, just separating out the concern.
Also, as fflib looks to be enhanced through PR #71, this gives the SObjectDomain an opportunity to have ISecurity injected and defer to the injected instance rather than directly check isCreatable, etc.
Hope that helps.  Look forward to your thoughts and whether or not you think this proposal makes sense for the base library.  Thanks!

Yeah the fog is clearing a bit on what your trying to do with your own custom security model. I'm torn, as of course i want to see the library be generic useful and accept as many PR's as I can, and to be honest this is a fairly non contentious change and even just makes the base class code easier to manage. Though i'm still not sure what i'd say to an audience if they asked for use cases for overriding these virtual methods, e.g. what is a good use case that fits with the platforms best practice. So keen to discuss more and see your thoughts on the main discussion thread around your custom security model idea. Please understand that this is not a no to merging this, just need to understand more, lots of folks are increasingly using this library on the platform and we need to justify changes fairly well.
P.S. Would my accepting the PR that made the handler methods virtual help you here? You could switch off the base security checking and implement your own checking in the overriden ones and still delegate to the base class ones to get the routing?

Our use case is definitely outside the norm and at the end of the day, deviates from best practices.  The custom security model that we have implemented is required based on our business requirements and the limitation of SFDC that only permits a single role & single profile.  At the end of the day, it would be better to change our requirements than implement the custom security model but unfortunately that's not an option for us.
That all said, I'm with you and that coming up with a use case that would follow platform best practices would be difficult.  I do think and agree with your comment that the proposed change in this PR is non contentious and makes the base class easier to manage.
PR #69 (make handlers virtual) would give me the flexibility I need to have a derived base that does the custom security check.  Assuming PR #69 is approved and given that from a best practice perspective there really shouldn't be a need to ever override security checking, I think we should just close out this PR.  I'll add a comment to #71 to revisit the "checkXXXPermission" refactor as that is explored.
Make sense?

@jondavis9898 just doing some house keeping, i see we merged PR #69, so we should be good here. Let me know if not. Thanks again for the great submissions!


Create classes Book and Label

In this PR we:

[x] created the Book class with all its methods
[x] created the Label class with all its methods
[x] implemented tests for:

Book
Label

[x] built options for:

Listing all books
Creating a book
Listing all labels

[x] built JsonHandlers file to handle preserve data

There is nothing else to do other than merge it! Approved, Congrats!


ORA-28009: connection as SYS should be as SYSDBA or SYSOPER error for OCI_PoolCreate

We can try below-mentioned code to reproduce the issue.
#include "ocilib.h"
#define MAX_THREADS 50
#define MAX_CONN    10
#define SIZE_STR   260
void err_handler(OCI_Error *err)
{
printf("%s\n", OCI_ErrorGetString(err));
}
void pool_worker(OCI_Thread *thread, void *data)
{
OCI_Connection *cn = OCI_PoolGetConnection(data, NULL);
char str[SIZE_STR + 1] = "";
OCI_Immediate(cn, "select to_char(sysdate, 'YYYYMMDD HH24:MI:SS') from dual", OCI_ARG_TEXT, str);
printf("%s\n", str);
OCI_ConnectionFree(cn);
}
int main(void)
{
OCI_Thread *th[MAX_THREADS];
OCI_ConnPool pool;
int i;
if (!OCI_Initialize(err_handler, NULL, OCI_ENV_DEFAULT | OCI_ENV_THREADED))
{
return EXIT_FAILURE;
}
/ create pool /
pool = OCI_PoolCreate("db", "sys", "password", OCI_POOL_SESSION, OCI_SESSION_SYSDBA, 0, MAX_CONN, 1);
/ create threads /
for (i = 0; i < MAX_THREADS; i++)
{
th[i] = OCI_ThreadCreate();
OCI_ThreadRun(th[i], pool_worker, pool);
}
/ wait for threads and cleanup */
for (i = 0; i < MAX_THREADS; i++)
{
OCI_ThreadJoin(th[i]);
OCI_ThreadFree(th[i]);
}
OCI_PoolFree(pool);
OCI_Cleanup();
return EXIT_SUCCESS;
}

Hi,
I will check if the issue is in OCILIB code or if it is an Oracle limitation.
Using sys account for connection pools seems quite unusual as sys account should only be used for specific DB administration operations.
Regards,
Vincent

Hi,
It appears that when session pooling was introduced in oracle 9i, connecting as sysdba was not possible/documented in OCI documentation.
In the meanwhile oracle has added the possibility to do (new flag OCI_SESSGET_SYSDBA for OCI call OCISessionGet() ).
I did not implemented it as it was not available at the time I added support for session pools years ago.
I regularly check for OCI changes and I missed that one.
I will add support for it and commit tomorrow in a new development branch for v4.6.4 release.
Best regards,
Vincent

Hi,
I've committed a fix for the issue in the develop-v4.6.4 branch.
Note that sysdba connection will only work for session pools, not connection pools.
Best regards,
Vincent


Will this construct be made available internally via Brazil or otherwise?

I'd be very interested in using this construct in some of my teams packages and additionally as part of a builderhub template.

It is available internally via the internal NPM proxy. Please reach out internally if you have further questions.


Reconsider the choice of adding a newline after multi-line help string

First, thanks for your work.
I ask you to reconsider the feature introduced with PR https://github.com/pallets/click/pull/1081.

Adding a newline only to some options feels inconsistent and leads to a weird-looking "non-uniform" help strings. It's even worse when you use an extension that adds new help sections (e.g. Cloup for option groups), since some sections are not clearly demarked or too much demarked. It looks like a complete mess.

I'm pretty sure it's non-standard. Why should it be the default?

As a consequence, it feels like a bug. I did mistake it for a bug. Another developer reported it as a bug (issue https://github.com/pallets/click/issues/1559). The few people I asked don't like it and consider it a problem worth the effort of writing additional code to get rid of it. Most people in the original issue (https://github.com/pallets/click/issues/1075) are for an all-or-nothing behavior and described the current behviour as inconsistent as well.
Here's some alternative proposals.

Remove the feature.
Make it possible but non-default. Two solutions here:

Add a parameter to HelpFormatter. It can be made as simple as a boolean or as complex as a "list item separation strategy". A user can pass a custom factory function as Context.formatter_class (which probably could be called formatter_factory).
Refactor HelpFormatter to make it easy for people to override without copying, pasting and modiyfing the current code of HelpFormatter.write_dl.

Thank you again.

Refactor HelpFormatter to make it easy for people to override without copying, pasting and modiyfing the current code of HelpFormatter.write_dl.

Yes, as stated in https://github.com/pallets/click/issues/1075#issuecomment-644964531, making the formatting customizable is what I want.

That said, I'm not sure why I accepted it so quickly in the first place, but that was 3 years ago. Feel free to revert it.


Run on failure does not work correctly if named argument syntax is used

Describe the bug
Run on failure does not work correctly if named argument syntax is used in keywordxs args.
Originally reported in here
User are experiencing an issue:
[ WARN ] Keyword 'Take Screenshot ('fullPage', True)' could not be run on failure: 'tuple' object has no attribute 'upper' same with all possible arguments.

Tested on my local Windows environment and on browser-docker image.

Hello @aaltat,
Looks like it still not working correctly for filename argument. All others are fine.
Try with:
Register Keyword To Run On Failure  Take Screenshot  filename=robotframework-browser-screenshot-{index}
It's failing because:
Keyword 'Take Screenshot    filename=robotframework-browser-screenshot-{index}' could not be run on failure: take_screenshot() got multiple values for argument 'filename'
Working fine for positional argument.
Checked on version 11.1.1

Interesting, could you raise an issue about with --loglevel trace attached, so that we do not forget it.

done https://github.com/MarketSquare/robotframework-browser/issues/1702


MarkdownScrollViewer.Source improvement

Even if we set 'https://raw.githubusercontent.com/whistyun/Markdown.Avalonia/master/README.md' to this property, Markdown.Avalonia get no images.
I think AssetPathRoot should be updated based on Source

supported in v0.9.0 and v0.10.0.

supported in v0.9.0 and v0.10.0.