Question about writing advanced rules

For reference, I am trying my hand at writing a rule to detect PendingIntents used dangerously, as noted in https://www.researchgate.net/publication/325818237_PIAnalyzer_A_Precise_Approach_for_PendingIntent_Vulnerability_Analysis, and I have a rule that can detect implicit intents being initialised as its source, and something like this for its sink.
{
  "model_generators": [
    {
      "find": "methods",
      "where": [
        {
          "constraint": "parent",
          "inner": {
            "constraint": "name",
            "pattern": "Landroid/app/PendingIntent;"
          }
        },
        {
          "constraint": "any_of",
          "inners": [
            {
              "constraint": "name",
              "pattern": "getB.*"
            },
            {
              "constraint": "name",
              "pattern": "getA.*"
            },
            {
              "constraint": "name",
              "pattern": "getS.*"
            }
          ]
        }
      ],
      "model": {
        "for_all_parameters": [
          {
            "variable": "x",
            "sinks": [
              {
                "kind": "PendingIntentSink",
                "port": "Argument(x)"
              }
              ]
          }]
        }
    }
  ]
}

However, I am unable to abstract this flow as its own standalone source/sink. Would like to develop this further to detect instances of PendingIntents being initialised with implicit intents, and then sent off as another Intent's extraData. How should I link these 2 use cases up? Appreciate any advice regarding this!

Could you describe what flow you are trying to catch? I don't have access to this paper.
Please give a concrete example.

Hi @arthaud, sure! The example vulnerable code is here:
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main_vuln);
    Intent baseIntent = new Intent();
    PendingIntent pendingIntent = PendingIntent.getActivity(this, 1, baseIntent, PendingIntent.FLAG_UPDATE_CURRENT);
    Intent implicitWrappingIntent = new Intent(Intent.ACTION_SEND);
    implicitWrappingIntent.putExtra("vulnPI", pendingIntent);
    sendBroadcast(implicitWrappingIntent);
}

Basically, I want to find any invocations of PendingIntent, via either getActivity(), getActivities(), getBroadcast()
or getService(), check that the the baseIntent that is initialised within PendingIntent is implicit, and that the PendingIntent itself is wrapped in another implicitWrappingIntent, before being sent out.
So far, I could get the source of the rule to be checking for initialization of a implicit intent, and I can trace up till the getActivity function, but not sure how to chain this rule with a rule that checks that the pendingIntent is then wrapped within another implicit intent.

Like below
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main_vuln);
		// 1.implicitly IntentCreation Source 1
    Intent baseIntent = new Intent();

    // 2. implicitly intent source flows into PendingIntent.getActivity, then pendingIntent is tainted
    PendingIntent pendingIntent = PendingIntent.getActivity(this, 1, baseIntent, PendingIntent.FLAG_UPDATE_CURRENT);

    Intent implicitWrappingIntent = new Intent(Intent.ACTION_SEND);

    // 3. tainted pendingIntent flows into implicitWrappingIntent, then implicitWrappingIntent is tainted
    implicitWrappingIntent.putExtra("vulnPI", pendingIntent);

    // 4. sendBroadcast(0) is sink
    sendBroadcast(implicitWrappingIntent);
}

How do I ensure that the taint path must have PendingIntent in it though? Or is it not possible to define that sort of granularity within the rules?

I don't think there is a good way to model this currently.
I would personally use features to mark that the taint went through PendingIntent.getActivity and Intent.putExtra, but you will probably get a good amount of false positives.
It could be solved with a technic we call Taint Transforms but it is not implemented in Mariana Trench.

Thanks @arthaud! Will keep that in mind, and work with features for now.

Hello @chuayupeng , could you share how you achieved your goal with features? I am trying to learn propagations and features, which are not well-documented (few examples and not much detailed) and simple to understand, in my opinion.


Modify isJsFile() to detect if CoffeeScript is a valid filetype

I've been looking into how we could keep Coffeescript support for PhantomJS v1.x and SlimerJS, while possibly adding support for PhantomJS v2.x.
So far, I've found that require.extensions holds the possible filetypes that the engine can support when being required, which should roughly match those that are available to be used with phantom#injectJs()
PhantomJS v2.0:
{
    ".js": "[Function]",
    ".json": "[Function]"
}

PhantomJS v1.9.8 / SlimerJS 0.9.6:
{
    ".coffee": "[Function]",
    ".js": "[Function]",
    ".json": "[Function]"
}

I've written a patch that uses the file extensions above (without .json) to allow isJsFile() from utils.js to determine the correct filetypes based on the engine.
I'll submit a PR when I have the time to thoroughly test the patch on each of the engines.
This allows PhantomJS v2.x to ignore the CoffeeScript tests, allowing us to keep them around for testing SlimerJS and PhantomJS v1.x

Beat me by 3 hours. I support a solution like this

This allows PhantomJS v2.x to ignore the CoffeeScript tests, allowing us to keep them around for testing SlimerJS and PhantomJS v1.x

Thanks for taking the time to dig into this. I think keeping cs compatibility is important for casperjs users.

I think this is closed with your merged PR https://github.com/n1k0/casperjs/pull/1310 in current master, see  https://github.com/n1k0/casperjs/blob/master/modules/utils.js#L467.
Please re-open if I am wrong.


command 'istioctl manifest generate' returns errors

Bug description
I am trying to upgrade istio from v1.4.10 to v1.5. Istio v1.4.10 was installed using Helm templates followed by Kubectl apply. Knowing this and considering that upgrade using istioctl is now the recommended way to procceed I am trying to 'migrate' current setup to istioctl as follows:

istio-1.4.10# bin/istioctl manifest migrate my-values.yaml > migrate_export.yaml
istio-1.4.10# bin/istioctl manifest generate -f migrate_export.yaml > generate_export.yaml

When executing the step 2) istioctl returns unknown field "istio-internal-ingressgateway" in v1alpha1.GatewaysConfig.
➜  istio-1.4.10# bin/istioctl manifest migrate my-values.yaml > migrate_export.yaml
proto: tag has too few fields: "-"
➜  istio-1.4.10# bin/istioctl manifest generate -f migrate_export.yaml > generate_export.yaml
input file failed validation with the following errors: unknown field "istio-internal-ingressgateway" in v1alpha1.GatewaysConfig

In addition to default gateway "istio-ingressgateway" we have many others such as this "istio-internal-ingressgateway".
Am I executing the 'migration' procedure correctly?
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[x] Multi Cluster
[ ] Virtual Machine
[x] Multi Control Plane
Expected behavior
No errors.
Steps to reproduce the bug
Execute:

istio-1.4.10# bin/istioctl manifest migrate -f my-values.yaml > migrate_export.yaml
istio-1.4.10# bin/istioctl manifest generate -f export.yaml > generate_export.yaml

**Version
➜  istioctl version --remote
client version: 1.4.10
citadel version: 1.4.10
galley version: 1.4.10
galley version: 1.4.10
ingressgateway version: 1.4.10
ingressgateway version: 1.4.10
internalingressgateway version:
internalingressgateway version:
nodeagent version:
nodeagent version:
nodeagent version:
nodeagent version:
nodeagent version:
nodeagent version:
pilot version: 1.4.10
pilot version: 1.4.10
policy version: 1.4.10
policy version: 1.4.10
sidecar-injector version: 1.4.10
sidecar-injector version: 1.4.10
telemetry version: 1.4.10
data plane version: 1.4.10 (21 proxies), 1.4.3 (5 proxies)

➜  kubectl version --short
Client Version: v1.17.3

How was Istio installed?
Helm template to yaml files and then kubectl apply those files.
Environment where bug was observed (cloud vendor, OS, etc)
Istio is installed on EKS v1.16

I have the same issue!


Merge Eribon in the develop branch

This change is

Codecov Report

Merging #25 into develop will decrease coverage by 0.29%.
The diff coverage is 98.36%.

@@            Coverage Diff             @@
##           develop      #25     +/-   ##
==========================================
- Coverage    96.46%   96.17%   -0.3%
==========================================
  Files           10       11      +1
  Lines          537      470     -67
==========================================
- Hits           518      452     -66
+ Misses          19       18      -1

Impacted Files
Coverage Δ

grmpy/test/random_init.py
99.01% <ø> (ø)
:arrow_up:

grmpy/read/read_auxiliary.py
87.93% <0%> (ø)
:arrow_up:

grmpy/test/test_integration.py
96.29% <100%> (-0.38%)
:arrow_down:

grmpy/test/auxiliary.py
100% <100%> (ø)

grmpy/test/test_unit.py
100% <100%> (ø)
:arrow_up:

grmpy/simulate/simulate_auxiliary.py
99.06% <98.41%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9008cbe...d869e27. Read the comment docs.

Reviewed 2 of 3 files at r1, 8 of 9 files at r2.
Review status: 10 of 11 files reviewed at latest revision, 1 unresolved discussion.

grmpy/test/auxiliary.py, line 6 at r2 (raw file):

def cleanup():

Docstring?

Comments from Reviewable

grmpy/test/auxiliary.py, line 6 at r2 (raw file):
Previously, peisenha (Philipp Eisenhauer) wrote…
Docstring?

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Update spartacus installation script to support @next versions

PR here: https://github.tools.sap/cx-commerce/spartacus-installation/pull/12


The alignment of the get VID via AID page is not proper

Describe the bug
The alignment of the get VID via AID page is not proper, acting weirdly each time, in both themes
To Reproduce

authenticate the app and get in
go to the home page
click on add id button
click on the "dont have your UIN/VID? get it here" button

Expected behavior
The alignment should be proper in all themes and every time
Actual behavior
The alignment of this page is acting weird every time of the use, in all time
Screenshots

Smartphone :
device : redmi k20 pro
ble : 5.0
android : 11
MOSIP Version : <IP_ADDRESS>
MOSIP server : qa-1201-b2.net
APP link : https://github.com/mosip/inji/actions/runs/4447486079

The "?" info button's alignment is also not proper, its using a lot of space and intermittently gets stuck in the middle of the screen as shown in the below screenshot, please look into this too
Screenshtot :

Smartphone :
device : redmi k20 pro
ble : 5.0
android : 11
MOSIP Version : <IP_ADDRESS>
MOSIP server : qa-1201-b2.net
APP link : https://github.com/mosip/inji/actions/runs/4447486079

verified as fixed in the build with commit id in the below screenshot.


Improve cache mechanism by introducing a flexible cache key helper

Currently - in addition to all request parameters - a valid user handle is taken into account as part of the cache key when a request is cached in Kalamar. That way, users with different access rights will receive different cache results.
But in the following scenario this is not enough:

A user logs into Kalamar inside the IDS
The cache stores requests with IDS access of the user
The user leaves the IDS and logs into the system outside the IDS
The cache will deliver falsly cached requests with IDS access

To help with this scenario, the cache key should also include a trimmed IP to recognize the change of access location.
However, this is a very special scenario for the IDS. To realize this in a more general way, the cache key should be generated by a cache key helper or modified by a cache key hook, that can be specified using a plugin or a configuration file.

A better solution may be to remove Caching from Kalamar and relocate the result caching to Kustvakt - or a separated cache instance between Kustvakt and the search backend.


Batch inference for Iris Model

Greetings! Firstly, thanks for this wonderful project! I am currently using Iris models, and I would like to ask whether it's possible to do the batch inference(e.g. batch size=2) for the iris tflite model? Since I found the inference speed is relatively slow compared with the facemesh model, I want to improve the inference speed when using them together.
I found there is an option options.compile_options.dynamic_batch_enabled in inference_calculator.cc (https://github.com/google/mediapipe/blob/f96eadd6df64a5f9a31918d6319e51847497641a/mediapipe/calculators/tensor/inference_calculator.cc), so does the iris model support dynamic_batch?
Thanks very much!

Hi @cmfcm, Could you please test the same with the latest release and let us know if you still see any less inference speed as compared to previous.  We are improving our solutions continuously in all platforms to give the community better products.


Publish to npmjs registry

I didn't want to include this in https://github.com/paritytech/ss58-registry/issues/28 which I suspect is already underway. This is also about publishing, but slightly different.

After https://github.com/paritytech/ss58-registry/pull/33 we can now align the version of the root package.json with the Rust sources. To do so you can run npm run alignVersion. The suggested approach here is that after we tag/create a version (as per #28), we run this command and then can push the changes back to GitHub.

After https://github.com/paritytech/ss58-registry/pull/34 we can now publish the JS packages to npmjs as well. Basically  run npm run alignVersion and then npm run build, which will create the outputs and then we can publish with cd npm_dist && npm publish --access public

The npm publish here should be no different from what we do in other @substrate packages (just not that familiar with the process generally employed for these on Parity CI)

If we can do #28 as a github action as well, I'm in

I'm planning to do https://github.com/paritytech/ss58-registry/issues/28 using gitlab ci. I'll add this task to the ci/cd issue tracker


docs: Update IntelliSense for WebStorm in latest doc

Description
Update IntelliSense for WebStorm in latest doc to match the beta doc
Additional context
The latest doc is the default, and the IntelliSense for WebStorm doc needs to update.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Nice catch, thanks!


Couldn't opn a zarr example

First off, thanks for doing this awesome work 👍
But I did run into some trouble trying to load some data that does work when I use the ome_zarr package.
There's a gist code that works with the same data source here.
But when I use the itk.OMEZarrNGFFImageIO I get this error:
>>> zarrEndpoint = "https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/4007801.zarr"
>>> image = itk.imread(zarrEndpoint, imageio=imageio)
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/opt/sr/python-install/lib/python3.9/site-packages/itk/support/extras.py", line 1314, in imread
    reader = template_reader_type.New(**kwargs)
  File "/opt/sr/python-install/lib/python3.9/site-packages/itk/support/template_class.py", line 661, in New
    return self._NewImageReader(
  File "/opt/sr/python-install/lib/python3.9/site-packages/itk/support/template_class.py", line 165, in _NewImageReader
    imageIO.ReadImageInformation()
RuntimeError: /Users/runner/work/ITKIOOMEZarrNGFF/ITKIOOMEZarrNGFF/src/itkOMEZarrNGFFImageIO.cxx:383:
ITK ERROR: OMEZarrNGFFImageIO(0x7fc84001ae60): tensorstore error: FAILED_PRECONDITION: Error opening "zarr" driver: Error reading https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.1/4007801.zarr/0/.zarray: Error parsing object member "fill_value": Expected integer in the range [0, 65535], but received: "0" [source locations='tensorstore-src/tensorstore/internal/json_binding/json_binding.h:859,tensorstore-src/tensorstore/driver/kvs_backed_chunk_driver.cc:1055,tensorstore-src/tensorstore/kvstore/kvstore.cc:252,tensorstore-src/tensorstore/driver/driver.cc:112'] [tensorstore_spec='{\"context\":{\"cache_pool\":{},\"data_copy_concurrency\":{},\"http_request_concurrency\":{},\"http_request_retries\":{}},\"driver\":\"zarr\",\"kvstore\":{\"base_url\":\"https://uk1s3.embassy.ebi.ac.uk\",\"driver\":\"http\",\"path\":\"/idr/zarr/v0.1/4007801.zarr/0/\"},\"recheck_cached_data\":false,\"recheck_cached_metadata\":false}']

This is a deviation from specification, see this issue: https://github.com/google/tensorstore/issues/107.

Interesting, thanks.  Funny thing is that this is the reference example dataset that is suggested by the zarr resources I worked from at the time.
In any case do you have other data sources that should be working?  I would like to try loading directly from a bucket, like from s3 or gcs.

BTW, I was testing this in Slicer's python, but the same error occurred in a conda based pure python 3.9 environment.  This makes sense if the data doesn't match the spec.

Hi @pieper , thanks for using ITKIOOMEZarrNGFF 😄
Yes, as @dzenanz noted, we ran into the same issue in setting up cloud integration tests. We believe it is an underlying issue in Google's Tensorstore library, specifically in that it strictly parses quoted JSON values as strings. As I understand it, this is technically adherent to the JSON spec, but in practice results in brittle parsing that fails on minor deviations in real-world data such as that you linked.
If you are looking for sample data for testing ITKIOOMEZarrNGFF, I suggest referring to OME-Zarr v0.4 data discussed at https://github.com/ome/ome-ngff-prototypes. We have had success in loading this data and currently reference it in our test suite.
If you are looking to load data that is affected by https://github.com/google/tensorstore/issues/107, you may need to download the data yourself and manually edit the OME-Zarr .zattrs header file to remove quotes from numeric values, i.e.
fill_value: 0

instead of
fill_value: "0"

Hope that helps.

This is great, thanks @tbirdso and @dzenanz !
In case anyone else wants to try in Slicer:
pip_install("itk-ioomezarrngff")
import itk
imageio = itk.OMEZarrNGFFImageIO.New()
zarrEndpoint = "https://s3.embl.de/i2k-2020/ngff-example-data/v0.4/zyx.ome.zarr"
image = itk.imread(zarrEndpoint, imageio=imageio)
volumeNode = slicer.util.addVolumeFromArray(image)
slicer.util.setSliceViewerLayers(background=volumeNode, fit=True)

gives this:


Saving Eloquent models with Composite Keys causes an error

I created a composite index in the a typical database schema
$table->primary(array('some_name','some_value'));

I defined the model like the following, no difference between protected or public decleration
protected $primaryKey = array('some_name','some_value');

I try to save the model
$modelobject->save()

Error:
{"error":{"type":"ErrorException","message":"Illegal offset type in isset or empty","file":"\/srv\/www\/laravel\/vendor\/laravel\/framework\/src\/Illuminate\/Database\/Eloquent\/Model.php","line":1587}}

Trace:
https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Eloquent/Model.php#L1587
https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Eloquent/Model.php#L1575
https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Eloquent/Model.php#L1453
https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Eloquent/Model.php#L1387

Guys, can you suggest a Laravel 5 compatible solution? This does not work.

tsilenzio took the save function in the Model.php and overrode it his own model. In the process keeping a lot of the event hooks and other stuff but then changing the are labeled "START FIX" to "END FIX" to handle composite keys. His code was for Laravel 4, but you can do the same in Laravel 5. The Laravel5 Model->save() is much cleaner. To accomplish a similar thing what I did was take the $query variable that is set at the top of Model->save() and just added some ->where()'s to it....
public function save(array $options = array())
{
$query = $this->newQueryWithoutScopes();
// MY MODEL SPECIFIC FIX
$query->where('OTHER_ID', '=', $this->OTHER_ID);
// END MY FIX
// the rest of the standard model->save() code is here but I cut it out for brevity. Use what is in Model.php already.
}

@carsonevans thank you for sharing your findings. I did what you wound up doing but was finding that the update query that was being generated kept generating like this: UPDATE .... WHERE ... AND "Id" = NULL
I had to add the following for my model class to override the setKeysForSaveQuery function since my table does NOT have an Id column but has a composite primary key:
/**
 * Set the keys for a save update query.
 * This is a fix for tables with composite keys
 * TODO: Investigate this later on
 *
 * @param  \Illuminate\Database\Eloquent\Builder  $query
 * @return \Illuminate\Database\Eloquent\Builder
 */
protected function setKeysForSaveQuery(Builder $query)
{
    $query
        //Put appropriate values for your keys here:
        ->where('column1', '=', $this->column1)
        ->where('column2', '=', $this->column2);

    return $query;
}

Its works!!!
I ignored the model of the relationship table and set "belongsToMany" in the two tables with a little details: set the two  foreign key of two tables and set the name of the relationship table. The whole foreign keys will works like a composite key.
Ex:
//--------- Model "Table1": ------------//
class Table1 extends Model {
...
public function table2()
{
return $this->belongsToMany('App\Table2', 'table_relashionship', 'id_table2', 'id_table1');
}
}
//--------- Model "Table2": ------------//
class Table2 extends Model {
...
public function table1()
{
return $this->belongsToMany('App\Table1', 'table_relashionship', 'id_table1', 'id_table2');
}
}
Now the Eloquent undestand that you have a 'table_relashionship' in your database with columns 'id_table1' and 'id_table2' and you can access the data with the comand:
$table1 = Table2::find(1);
dd($table1->table2)
Its solve my problem!

@ccuono
I used your method, but without fix the field names ...
and with a "if".
This way I expect to be able to use in a extension of the Model class!
But in the save method I get an Exception :
PDO::lastInsertId() expects parameter 1 to be string, array given
I'll try to fix ... until then  I'm using the save method of like @tsilenzio suggest.
Hope this helps someone else
Thanks!
/**
 * Set the keys for a save update query.
 * This is a fix for tables with composite keys
 * TODO: Investigate this later on
 *
 * @param  \Illuminate\Database\Eloquent\Builder  $query
 * @return \Illuminate\Database\Eloquent\Builder
 */
 protected function setKeysForSaveQuery(\Illuminate\Database\Eloquent\Builder $query) {
        if (is_array($this->primaryKey)) {
            foreach ($this->primaryKey as $pk) {
                $query->where($pk, '=', $this->original[$pk]);
            }
            return $query;
        }else{
            return parent::setKeysForSaveQuery($query);
        }
    }

This should definitely not have been closed. It's still an issue in 5.1. For example, if you do:
$item = Item::firstOrNew(['pk_col_1' => $x, 'pk_col_2' => $y]);
$item->col_3 = 'content';
$item->save();

It gives the "Illegal offset type in isset or empty"
Thanks @cmnardi for the fix. I have all of my "models" extending a BaseModel which extends Eloquent Model, so it was easy to stick in. This should really be merged into master

Thanks. Not sure to understand why it's not merged :'(

Thanks for the fix @cmnardi. Why is the issue closed although the error still exists?

Maybe is because they don't see this like an error.
You should create a field like a primary key in every table

@cmnardi

You should create a field like a primary key in every table

Only when it makes sense, right? If they expect everyone to always put a single field ID, composite primary keys shouldn't be supported. There is no sense to support them partially.

@cmnardi the database shouldn't be structured in a certain way to support the framework, it should be the other way around.

I agree @cmoralesweb and @andrewtweber the database must be independent of the framework
in some cases the database already exists and you need to build the application 'around'

@cmnardi, to prevent the exception PDO::lastInsertId() expects parameter 1 to be string, array given, you should set to false $incrementing
public $incrementing = false;

Also note that, if the the relationships are set properly, there's no need to override the save function to have the inserts working. Just the setKeysForSaveQuery for the updates

Any reason why this issue is closed?

People are trying to find how to make work composite keys with Eloquent, issues like #5355 are trying to help. If Laravel don't want to support the requested feature, at least do not close the thread that are trying to help.
+1 to Composite Keys

+1 Composite keys

These will never be supported because it makes no sense in the context of routing, and our interface for generating routes.


[Bug] REI does not wrap around portal gui

Minecraft Version
1.20.x
Mod Loader Version
0.14.22 api 0.87.0
Mod Version
1.0.2
Describe the Issue
REI does not wrap around the portal GUI like other gui's do, resulting in REI overlaying part of the interface making it difficult to see and use without turning off REI.

latest.log
not relevant
Do you use any other mods except the required ones?
no

Fixed with https://github.com/Globox1997/DungeonZ/commit/ed771a2bafe2e2a36cf9072d20df7e6e4036dfbb


Manage fulfillment in pre-booked state

The state model currently does not allow for fulfillment in pre-booked state. Some IMSs require at least an id in pre-booked state for their processes.

We need to define which states are mandatory to be provided by providers and to be understood by consumers of the OSDM API.

Move Fulfillment Status from FulfillmentParts to Fulfillment
Add PREBOOKED to FulfillmentStatus
? Align BookingPartStatus with FulfillmentStatus when makes sense


Can't install Xamarin.Android.Support.Compat 24.2.1

Xamarin.Android Version (eg: 6.0):
<IP_ADDRESS>
Operating System & Version (eg: Mac OSX 10.11):
Win 10 Anniversary
Support Libraries Version (eg: 23.3.0):
24.2.1
Describe your Issue:
When adding the NuGet package I get this:
...
Attempting to resolve dependencies for package 'Xamarin.Android.Support.Compat.24.2.1' with DependencyBehavior 'Lowest'
Resolving dependency information took 0 ms
Resolving actions to install package 'Xamarin.Android.Support.Compat.24.2.1'
Resolved actions to install package 'Xamarin.Android.Support.Compat.24.2.1'
Retrieving package 'Xamarin.Android.Support.Compat 24.2.1' from 'nuget.org'.
For adding package 'Xamarin.Android.Support.Compat.24.2.1' to project 'MYPROJECT' that targets 'monoandroid60'.
Install failed. Rolling back...
Package 'Xamarin.Android.Support.Compat.24.2.1' does not exist in project 'MYPROJECT' Package 'Xamarin.Android.Support.Compat.24.2.1' does not exist in folder 'D:\PATH\MYPROJECT\packages'
Executing nuget actions took 6 ms
Could not install package 'Xamarin.Android.Support.Compat 24.2.1'. You are trying to install this package into a project that targets 'MonoAndroid,Version=v6.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
Steps to Reproduce (with link to sample solution if possible):
Create a new blank android project, target:
Compile: 5.1, Min: 4.1, Target: 4.1

We are following Google's recommendations now, which is you should always use the same API Level # as the Major version # for the Support Libraries you reference (so, API Level 24, you can use Support 24.2.1, API Level 23 should use Support 23.x, etc).  In fact, if you try and mix and match in Android Studio, gradle will give you an error telling you they are mismatched.
Really, you should always try and compile against the latest SDK level.  Here's a great article on picking your minSdkVersion, targetSdkVersion, and compileSdkVersion (same as our Target Framework). https://medium.com/google-developers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd#.6sw1nhe2h

That makes sense. It seemed a bit odd behavior to me, since appcompat 23.x worked even with 5.1 (v22).
Futhermore I installed only 7.1.x SDK which wasn't picked by VS/compile target and I had no option to set it.
Anyway, installing 7.0 SDK and setting compilation to latest version (or 7.0) solves it.
Thanks for the details.

Your app needs to have its Target Framework set to Android 7.0 (API Level 24) or higher to install these.
How do you change the target version of the Android App!?


fix(call): fixes call()

Closes #46.
Important changes: true, false and null need to be explicitly called as resources in askcode.
What used to be this in AskCode:
ask(true)

now needs to be this
ask(true())

For AskScript there is no change - ask { true } works as it used to.
See the changed files for more examples.

@mhagmajer I cannot see any approvals on this page. Who approved it?

@czerwinskilukasz1 I've merged it promptly to unblock myself, if you have any comments, please feel free to submit them here.

@mhagmajer , why did you force introducing rules of contributing if you are breaking them afterwards?


Add new checkout UI template

WHY are these changes introduced?
Fixes #671
Fixes #673
WHAT is this pull request doing?
Adds a new option to yarn generate extension:

This option should only be available to shopifolk.  Selecting this option creates a new template:

This template is based upon the existing checkout UI extension with the following changes:

shopify.ui.extension.toml uses the new schema.
Two extension points are created (Checkout::Dynamic::Render and Admin::Checkout::Editor).
The readme has updated instructions to reflect that both of these extension points are created.

How to test your changes?

Delete fixtures/app/extensions
Inside fixtures/app run yarn generate extension and select a pre-existing UI extension
Repeat step 2 for every UI extension EXCEPT the new one.
Run yarn dev to check that nothing broke the generation of existing extensions.
Run yarn generate extension and this time select the new UI Extension ( Checkout UI Beta (shopifolk only) ).

Creating a new extension should work. Note that if you run any command after creating the new extension it will fail because the CLI doesn't understand the new toml schema.
Post-release steps
None
Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

I haven't tested this but from your screenshot it looks like the file extension is missing in the generated template?

Yeah, this is now fixed.

Closing as we've been shipping this code ontop of Isaac's refactor.


FlareSystems: add workbook

This adds a workbook to our solution!
Cheers,

Included as part of https://github.com/Azure/Azure-Sentinel/pull/2326


v14.3.10 JS: improve Page Mgr

[Current coverage][cc-pull] is 99.20%

Merging [#314][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #314   diff @@
==========================================
  Files            24         24
  Lines           374        374
  Methods          77         77
  Messages         77        154    +77
  Branches          0          0
==========================================
  Hits            371        371
  Misses            3          3
  Partials          0          0

Powered by Codecov. Last updated by [10759bb...642a082][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/10759bb19b02f02953536d849a9e74ba49b19365...642a0822216986aee5c3f43735b04fa3d17dc50d
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/314?src=pr


Rebuild Configs Round 3

This should hopefully be the last round. This set of commits eliminate a lot of the manual config generation that makes adding / removing to configs challenging. It delegates creation and mutating of a config to the config structure itself. The caller should only modify / access fields that make sense for the caller. As a result, adding / removing fields should be isolated only to the pieces of code that are relevant to it.

This PR actually begins at
[config] simplify full node network generation
as it a follow up to round 2.

you might have to rebase since round2 has merged

:umbrella: The latest upstream changes (presumably 8add4436356314416c10a26a278a70b7db4e1f6d) made this pull request unmergeable. Please resolve the merge conflicts.

Saw a couple things that need some looking at but looks good overall

Looks like we've still got a bit of work to do, but this is definitely long enough as is. Thanks again for working on this!
@bors-libra r+

:pushpin: Commit 05a0966 has been approved by bmwill

:hourglass: Testing commit 05a09669356326cc4428f69ee2114818c8b27afe with merge c786b9b5e8102fc0752a72005f572e963f89638d...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:pushpin: Commit 9871e69 has been approved by bmwill

:hourglass: Testing commit 9871e69c004c1c89eff686c713db28d10745536c with merge ca993fe5ed7ffd61baae490dd7781ed44c1fab8d...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit 9871e69c004c1c89eff686c713db28d10745536c with merge 119ed015f0be04971d3e36caeb65a4c7ea057f6d...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing 119ed015f0be04971d3e36caeb65a4c7ea057f6d to master...


fix: it is not possible to have _ in package names

When trying to add an entity to a package that has _ in the name, it does not work.

Unable to recreate


Auth Issue Using the REST API

I'm trying to use the REST API to read a manifest and I'm running into Auth Problems. I've searched and read various articles on this including the Docker docs on getting a token, and it's just not working like I expect. I'm probably doing something dumb, but I've given it a really good effort. I'm using Postman, but I'm getting the same issue in my Java code. I make the request:
https://registry-1.docker.io/v2/library/confluentinc/cp-kafka-res/manifests/5.0.1

This gives me a 401 result with a www-authenticate header.
www-authenticate: Bearer   realm="https://auth.docker.io
/token",service="registry.docker.io",scope="repository:library/confluentinc/cp-kafka-res:pull"

I then make a request:
https://auth.docker.io/token?service=registry.docker.io&scope=repository:library/confluentinc/cp-kafka-res:pull

and I'm given a token. I then copy the token value into Postman's Authorization tab and set the type to "Bearer Token".
I then repeat my request. On the second request, the header for www-authenticate comes back as:
www-authenticate: Bearer ... error=insuficient_scope

Through trial and error, I've found that if I copy/paste the token incorrectly, I get an invalid token error, so I know I'm doing that part right.
Can anyone give me some ideas on what I'm doing wrong?

Some additional information. I went back and re-read these docs, particularly the part about intersection of sets of permisisons.
https://docs.docker.com/registry/spec/auth/jwt/
I ran the token the the JWT decoder at https://jwt.io
Looking at the decoded PAYLOAD: DATA, it shows an empty access set. Similarly, if I request a token for:
scope=repository:library/fruit/banana:pull
I get a token back with an empty access set. It appears I'm using the wrong registry. Can anyone help me understand what registry to use? I tried using registry.docker.io, and that gives a 503 Service Unavailable error.

OK, after some poking around, what I figured out is:
if there's a path in the image name, e.g. confluentinc, then the request path is host/v2/path/image-name. If there's not a path element in the image name, it's host/v2/library/image-name.


WebScenarioTests_BlazorWasm_CSharp test is failing in main

Steps to reproduce:
Using a source-built .NET 7 SDK (I used the one from this build):

Run dotnet new blazorwasm --name WebScenarioTests_BlazorWasm_CSharp --output WebScenarioTests_BlazorWasm_CSharp --language "C#"
Add a NuGet.config file with the following content:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="dotnet-public" value="[https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json"](https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json%22) />
    <add key="dotnet7" value="[https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json"](https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json%22) />
    <add key="dotnet7-transport" value="[https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7-transport/nuget/v3/index.json"](https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7-transport/nuget/v3/index.json%22) />
  </packageSources>
</configuration>

Run dotnet build
The expected behaviour is the project should build cleanly, but we observe the following error:

/data/WebScenarioTests_BlazorWasm_CSharp_MS/Program.cs(3,7): error CS0246: The type or namespace name 'WebScenarioTests_BlazorWasm_CSharp' could not be found (are you missing a using directive or an assembly reference?) [/data/WebScenarioTests_BlazorWasm_CSharp_MS/WebScenarioTests_BlazorWasm_CSharp.csproj]

I cannot reproduce this using the official build of the .NET 7 SDK linked in the https://github.com/dotnet/installer README file.

@jaredpar do you know anyone who could help us diagnose this?

My starting point would be to get a binary log file for each build (just add /bl to the dotnet build command line). Then compare the differences in arguments to the <Csc> task where the error is happening. If you have both binlogs I'm happy to help take a quick look.

Here are the binlogs.tar.gz.
Also I looked at the Csc tasks and ran them through a comparison tool. Controlling for the executable paths and ignoring the version number differences, It looks like the official microsoft build has a couple extra /analyzers:... arguments. See for yourself:
csc_failure.txt
csc_success.txt
(7.0.100-rc.1.22370.6 is Microsoft version, 7.0.100-rc.1.22369.1 is Source Build version)

Thanks. I did a quick formatting on these files, diffed them and this is the result

It appears none of the Razor code generators are being passed through from the .NET SDK to the compiler in the source build version of the tools. Analyzers are though which is surprising. Can you check and see if they're installed on the source build instance?

@NikolaMilosavljevic - Is this something you can investigate?

Re-opening as there was a test that was disabled as a result of this regression that needs to be re-enabled.


color: array wish

Would love to see possibility to add a color array for e.g. Progress.Circle as the Progress.CircleSnail

Hi, what would be the intended visual output of this? A gradient?

Linear and/or radial gradient =D

Any progress or implementation of a progress color gradient?


Error installing blitz

Ritiks-Air:~ QueenandI$ pip3 install bob.blitz
Collecting bob.blitz
Using cached https://files.pythonhosted.org/packages/8c/42/c72dc24fcd7454e4b4a4e4d5cbbc237e3b3e5e7d6e281d44479e1890c39a/bob.blitz-2.0.15.zip
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/private/var/folders/5n/t6_jrv0j3yzg4zj7_39jn3cw0000gn/T/pip-install-vuextloj/bob.blitz/setup.py", line 70, in
system_include_dirs=system_include_dirs,
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/bob/extension/init.py", line 438, in init
pkgs = check_packages(packages)
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/bob/extension/init.py", line 77, in check_packages
p = pkgconfig(splitreq[0])
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/bob/extension/pkgconfig.py", line 136, in init
raise RuntimeError("pkg-config package %s' was not found" % name)     RuntimeError: pkg-config package blitz' was not found
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/5n/t6_jrv0j3yzg4zj7_39jn3cw0000gn/T/pip-install-vuextloj/bob.blitz/

You need to install blitz before trying to install bob.blitz.
This is an issue with bob installation and is unrelated to this project. If you still encounter similar issues, you can open an issue in the bob project.

been there done that. Thank-you for replying this fast tho👍.

This is a question about blitz and not directly related to this project. Closing now and you can ask blitz community for help.


enhancemtmv query sql expand star

before: SELECT * from user
now: SELECT internal.zd.user.k1, internal.zd.user.k2 from internal.zd.user
Therefore, there is no need for EnvInfo to store catalog and db information when creating materialized views

run buildall

run buildall

run performance

run buildall

run buildall

run buildall

run buildall

run buildall


Add --recurse-submodules to git-clone installation command

The plugin doesn't work if it's installed without it, failing with
Error detected while processing [...]/vim-cmake/plugin/cmake.vim:
line   24:
E117: Unknown function: libs#logger#Get
and other similar errors.

It took me some time what was going on after installing the plugin, so I hope that mentioning this here should help others avoid wasting time on this.

I had indeed missed this, thanks!


Hero image with image and content, longer words escaping container

When on a smaller mobile device with text enlarged, longer words escape the blue container.
Screenshot:

A potential fix could be to make the blue container fill the full-screen width on mobile devices. However, this will need to be tested further
Screenshot:

I'd be happy with this. However, it would then ask the question what's the point of the background image if it's mostly hidden?

You might want to consider using the CSS overflow-wrap: break-word; property too. Support isn't too bad:
https://caniuse.com/#feat=wordwrap

This was released in 3.0.0


Doesn't work with pterodactyl

The configuration process is broken and commands are really delayed.
And some text is 🤔

@Jesus-QC fix?

Has been fixed.

thanks

Only took a year 😏

Only took a year 😏

See, AAA quality


Changing the position of the date parameter and removing two compilation warnings

Resolved / Related Issues
Closes #7227
Details of Changes
Raise the position of the date format parameter below that of the language
Removal of two unused variables which creates alerts during compilation
Validation

[x] Built and ran the app
[ ] Tested the changes for accessibility

Screenshots (optional)

@coldu thank you!


🐞 Bug: Simulator has a persistent flickering issue, when working within it

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
For reference, I have witnessed this bug with the MacBook Air M1, on both safari and google chrome. When working on circuits in the simulator, there is an issue where the background will flicker to other subcircuits every 5-10 seconds. As someone using the simulator for lectures, this can be quite a visual disturbance (and also when I am working on circuits on my own).
Steps To Reproduce

Go to simulator
Create at least 2 subcircuits
Click on inputs / generally create gates or work with the simulator in any way
Witness flickering occurring

Expected Behavior
I expect there to be no flickering on the simulator
Screenshots
https://github.com/CircuitVerse/CircuitVerse/assets/57878148/20389cca-36bd-457e-9cdf-623ae81bdd5f
Device Information [optional]
- OS:macOS Sonoma 14.0
- Browser: Chrome and Safari
- version:

Additional context
No response
Are you working on this issue?
No

Hey @tanmoysrt @DhairyaMajmudar , i would like to work on this issue. Can you please assign this to me.

I am able to reproduce the same issue.
@Affanzuhaib  you can work on the issue.

Hello @tanmoysrt,
I have attempted to address the console errors occurring during the flickering issue. Whenever the flickering happens, I notice net::ERR_CONNECTION_TIMED_OUT errors in the console. I've tried to locate the client.ts file where the error occurs, but it seems to be missing from the code.
I would appreciate your assistance, as I'm unsure how to proceed further in resolving this issue. If you have some time, could we discuss this matter further? I've recorded a video detailing all the events that occurred during the flickering. You can find the video attached for your reference.
https://1drv.ms/v/s!AgHHfDszkSi5gka8FniKUn5v537W

Hello @tanmoysrt,
I have attempted to address the console errors occurring during the flickering issue. Whenever the flickering happens, I notice net::ERR_CONNECTION_TIMED_OUT errors in the console. I've tried to locate the client.ts file where the error occurs, but it seems to be missing from the code.
I would appreciate your assistance, as I'm unsure how to proceed further in resolving this issue. If you have some time, could we discuss this matter further? I've recorded a video detailing all the events that occurred during the flickering. You can find the video attached for your reference.
https://1drv.ms/v/s!AgHHfDszkSi5gka8FniKUn5v537W

@Prerna-0202 @Arnabdaz can you check the issue ?


Hello, the images are not included directly for licensing reasons, and if the buttons are like in the picture, it does not violate licensing. [Question❓]

I do not understand your question.

PyMatting uses images form http://alphamatting.com/datasets.php for testing if PyMatting works correctly. We can not include those images directly in this GitHub repository because the person currently in charge of http://alphamatting.com does not allow it.
You posted a photo of the website https://clipdrop.co/remove-background which offers a background removal service. People can upload their own photos from their computers to this website, but I do not see how this website is related to PyMatting.

Could you clearly state what your question is?

Closed by https://github.com/pymatting/pymatting/pull/89 (Maybe. OP did not add more details.)


GDExtension: PtrToArg::convert() uses const-reference where possible

Fixes #80074.
In the cases where reinterpret_cast is immediately dereferenced, PtrToArg::convert() returns a const-reference instead of a value. This allows to reuse the object located at the address of the passed const void* pointer, instead of triggering the copy constructor.
We cannot return const-references where temporary values are constructed. Most manual PtrToArg specializations fall under this category and are thus untouched.
In some cases, we now return a const-reference to scalar types like int, bool etc. Since the function is annotated as _FORCE_INLINE_, I expect any such indirections to be optimized away though.
I did some tests with the Rust binding (gdext) already, but I'd appreciate some input on this!

CI job Editor with doubles and GCC sanitizers failed with:

ranlib: /home/runner/work/godot/godot/godot-cpp/bin/libgodot-cpp.linux.template_debug.dev.x86_64.a: No space left on device

I encountered the same issue in my own nightly builds, also gcc memcheck running out of disk space... Was there a regression? Or GitHub decreased available disk space?

@Bromeon See:

#79919
#buildsystem channel on Godot Contributors Chat.

Good catch!
This makes sense to me. Even outside the context of GDExtension, we do ptrcalls with code like:
template <class T, class... P, size_t... Is>
void call_with_ptr_args_helper(T *p_instance, void (T::*p_method)(P...), const void **p_args, IndexSequence<Is...>) {
	(p_instance->*p_method)(PtrToArg<P>::convert(p_args[Is])...);
}

In the case that one (or more) of the method's arguments takes a const &, this would also avoid a copy.
I ran godot-cpp's automated tests and they passed. So, this seems OK from the perspective of GDExtension. It could probably use to be reviewed by the core team as well.

Rebased onto master.

Discussed at the GDExtension meeting, and we think this makes sense. This is also on the agenda to discuss at the core team meeting, where we hope to double check with them that this won't cause any other problems.

Great Catch!
For anyone who is intersted, I made a small demo in compiler explorer, even with -O3 the copy can not be elimated.
https://godbolt.org/z/qPWP86WcG

For anyone who is intersted, I made a small demo in compiler explorer, even with -O3 the copy can not be elimated.

The compiler has to be conservative, because the pointer passed to convert() is opaque: it cannot know what happens to it once we've made a copy. This copy could as well be deliberate because we're intending to change the original object. The copy itself could have side effects (which might be disproved by inspecting the copy constructor implementation; not sure how deep compilers go here).
It is our "insider knowledge" that a GDExtension binding keeps that pointer unchanged, as it's in a function call.

Thanks!


Demo to public

Menu

Hide Site Management
InputHarnesses -> InputDemo
Customers -> NestedFieldDemo
Remove list editor example

CMD

Add reset DB cmd

Login

Add tips and account info to login page

@moluuser: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@moluuser: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dup with https://github.com/qor5/admin/pull/57


CHB token FIX

I'm submitting a ...
[ ] bug report
[ ] feature request
[ x] question about the decisions made in the repository
[ ] question about how to use this project

CHB FIX 10 #26927
I'd like an automatic merger, please.

I'll need approval from @mercs-shashank

ssds


Add max_attribute_value setting

Overview
Add config setting that increases the custom event limit's attribute value size.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b2e9e74) 81.79% compared to head (9f36757) 81.76%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

newrelic/core/custom_event.py
92.30%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
- Coverage   81.79%   81.76%   -0.03%
==========================================
  Files         190      190
  Lines       19597    19604       +7
  Branches     3405     3406       +1
==========================================
+ Hits        16029    16030       +1
- Misses       2588     2593       +5
- Partials      980      981       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sidebar shortcode

Summary and motivation
I like the idea of sidenotes/sidebars; sitting somewhere between a proper paragraph and a footnote.
On desktop (or a big tablet), there's plenty space on the left/right margins to add this feature.
It could look like:

on mobile:

Live: https://diataxis.fr/
Implementation details
Diataxis uses font size 90%.
Checklist

[X] I've searched existing issues to make sure this feature hasn't already been requested.
[X] This feature aligns with tabi's philosophy (minimal JS, accessible…)
[X] I'm willing to contribute to the implementation of this feature.

I like the idea!

Something to consider: adding footnotes as sidenotes:

https://www.lesswrong.com/posts/dLg7CyeTE4pqbbcnp/language-models-model-us
For desktop: notes are shown in two places: right next to the mention + at the end.
On mobile, they are only shown at the end.


Fixed right-left flip if template is not RPI

Checklist
GitHub

[ ] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[ ] I've applied the relevant labels to this PR
[ ] I've applied a release milestone (major, minor, patch) in line with Semantic Versioning guidelines
[ ] I've assigned a reviewer

PR contents

[ ] I've consulted SCT's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description
When running sct_register_to_template -ref subject with a custom template which is not in RPI orientation (e.g., this one), the creation of a label "to the right" fails, because the "right" is in fact "left" if the image is in LPI orientation. This results in a right-left flip of the image, as illustrated in #3300.
In this PR we:

Add a test to catch that issue: test_sct_register_to_template_non_rpi_template()
Fix the issue by forcing the image to be RPI before creating the label.

Linked issues
Fixes #3300

I am bumping into this issue, which I need to solve before being able to make progress: https://github.com/sct-data/sct_testing_data/issues/6

@jcohenadad Some tests are still failing. I can take a look at these for you if you would like. :slightly_smiling_face:

@jcohenadad Some tests are still failing. I can take a look at these for you if you would like. 🙂

that would be absolutely awesome, thank you!!!


Changes to enable Kinesis client to work with LocalStack

We would like to use the client, but we have a requirement to be able to run end-to-end tests against a containerised stack, which rules out hitting AWS. With these changes, it's possible to override the endpoint that is used by the three clients that are created (Kinesis, DynamoDB, CloudWatch), so it can be set to the LocalStack endpoint (e.g. http://localhost:4566). It is also possible to change the retrieval mode, as the default (FanOut) doesn't work with LocalStack.

@JohnG84 Thank you for contribution, this is great PR. I would like you to add some LocalStack tests. There is docker compose with localstack service, you can add Kinesis there and look at fs2.aws.kinesis.KinesisConsumerSpec to refactor the tests, or maybe create new test suit running against localstack

@semenodm Test added. Could you review please?


os: clarify documentation for O_TRUNC

The comment for os.O_TRUNC currently says:
https://github.com/golang/go/blob/78c0e1f81d4052f8ca5a50e4e7c5bb35ddec6519/src/os/file.go#L76
The “if possible” part of that comment is ambiguous: on Linux it seems to mean “if the file is a regular file or symlink to a regular file” (i.e., not a stream like /dev/stdout), but it could be “impossible” to truncate the file for other reasons (such as a permission error), and os.OpenFile with os.O_TRUNC seems to report an error in those cases.
We should drop the “if possible” phrase and instead explicitly document the conditions under which O_TRUNC is ignored.

(CC @rsc @robpike @ianlancetaylor)

I fear that making the os package document every aspect, for every OS, of the calls it wraps is a Sisyphean endeavor and not worth pursuing.


clean up code

Hi! I know this PR is huge, but there is almost no logic change!
This is pretty much a code clean up.
There are a few breaking changes though.
I moved all structs to a subfolder called structs. This is, imo, better for organization, and it also allows for testing functions to have access to those structs. As they were before, it wasn't possible to write test functions based off of those structs.
Cleaned up a few unnecessary new lines, as well as nested vars into var (...) instead of var ... var ... var ...

I noticed there were two type guild struct one having more fields than the other, but all the fields of the smaller struct were present on the bigger struct. So I merged them into one single struct, and added the omitempty tag to the fields that didn't exist in the small guild struct.

I made the exactly same change as above for the type world struct

⚠ Breaking Change! ⚠
I noticed that on the TibiaGuildsGuildV3 function the JSONData were returning Guilds: Guilds when it was not necessary, because it is always a single guild. So instead I changed to return a single guild directly.

⚠ Breaking Change! ⚠
The same as above was happening to the TibiaSpellsSpellV3 function, so I changed it to return the spell directly instead of Spells: Spell

I divided the webserver.go file into three files: webserver.go, main.go and TibiaUtilsV3.go.
On the webserver.go file I left only http related functions.
On the main.go file I placed the main function as well as all relevant vars and the TibiaDataInitializer function.
On the TibiaUtilsV3.go file I placed all the utility functions such as TibiadataHTMLRemoveLinebreaksV3, TibiadataRemoveURLsV3, etc.
I didn't make any logic change to any of these functions, I just reorganized them.

On the TibiaSpellsSpellV3 and the TibiaWorldsWorldV3 functions I moved away from using a lot of if's to using a switch

As requested by @tobiasehlert I'm closing this PR to split it up in a few smaller ones :)


Add WHALE token to the Mainnet token list

This PR adds the WHALE token to the ERC-20 token list for Mainnet. This data is taken from https://github.com/neonlabsorg/token-list/blob/055531c62a9e5779df8a00e174a4c0bf033231ae/tokenlist.json#L530.

"transfering" should be "transferring"
File: ./docs/composability/using_composability/transfer_spl_token.md Line: 381 Context: Description of token transfer process

@Vedad84 Thanks for pointing this out. This PR is not related to the composability docs. Will it be okay if I change/update this typo error when I push new PR for the Composability feature? Let me know, or otherwise I will change it in this PR itself.

@sukanyaparashar please create PR to the develop branch before merging it to main branch.

@sukanyaparashar please create PR to the develop branch before merging it to main branch.

@oable ! Sure, I will create a PR to the develop branch now.

Hey @sukanyaparashar ,
If you are creating the PR to align with 'develop' branch, please try to fix it in that instance if not too late.
Otherwise, leave it for the next PR.
Thanks.

Closing this one because a new PR has been created against the "develop" branch.


Docs by MDR (Closes #331)

Add MDR
Add Markdown support to translations
Refactor installation page to markdown document
Add Learning the Basics document, closing #331
Add some server configuration

I think we are better merging this now rather than wait for the other documents.
Those could take some time, and will just lead to a bigger diff in the future.

@emersion I'm not a fan of your "cleanup" of MDR. It's bad practice to put comments on the same line of code and I like knowing what brackets close what. I've also removed the l10n inclusion seeing as it's pulled in with the header already.

Okay, do what you want, I though this wasn't intentional ;-) everyone has its own vision of beautiful code

If someone can fix the conflicts I am okay with this being merged.

Let's do this


Upgrade RuboCop dependency to >= v0.58.0

This new version or RuboCop drops support for Ruby v2.1, so we have to do the same. See https://github.com/rubocop-hq/rubocop/pull/5990

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

The two “status items” ci/circleci: ruby-2.1-rspec and ci/circleci: ruby-2.1-rubocop will of course need to be marked as not required.


feat(auth): FR-1924 - add showBackButton property for SignUp

Please, do not approve it yet. There's a thing to discuss

@aviadmizrachi @davidantoon
I understand that the best decision would be to throw showBackButton prop through Route props. But I can't get it because of something. You can see showBackButton inside AuthRoutes component, but It doesn't appear as it should in SignUp component. If I understand David's idea in a right way

If the problem with pageProps is exist, it will take a while to solve it. The task is quite urgent. So, I can't decide what I should do


Gun completely disappeared after swapping hands

I wanted to test whether you could wield guns in either hand however after swapping back (using the VSS) my gun seeming has been removed. The gun was acquired from a bandit if that matters
This is reproducible by simply putting a weapon in your offhand and attempting it aim/fire
Version: MW 2.0 Contagion v<IP_ADDRESS> mc1.12.2
Mods Included:

The issue only happens with RPG-Hud installed? Which RPG-Hud version are you using?

Please close and ignore me, I don't have RPG Hud installed I mistook the other requests as the Modern Warfare mod github

Did you google the github page or how did you end up here instead?

Googled the issue, saw this github came up with a plethora of other Vics Modern Warfare mod issues that looked similar and thought I'd add a ticket, leapt to conclusions sorry

No problem. I hope your issue gets fixed.


services/horizon: Check state rebuild in state verification integration test

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Recreating because https://github.com/stellar/go/pull/3102 was removed because I removed a release branch.
What
Check state rebuild in state verification integration test.
Why
All integration tests start from empty state so we don't test building state from history archives. Extended state verification integration test to trigger state rebuild (horizon expingest trigger-state-rebuild) and verify rebuild state again. Such test would catch the bugs like https://github.com/stellar/go/pull/3100 and https://github.com/stellar/go/pull/3096.
Known limitations
It will make the test 3x slower so let's merge it after moving integration tests to nightly runs.

@Shaptic good feedback. Changes implemented in https://github.com/stellar/go/pull/3127/commits/063ffe2155dfb3a28c2d5689c0c596a0dec84c0b.

I merged master with #3167 and reverted https://github.com/stellar/go/pull/3127/commits/e8d89da83f1351e03eb5915b55b96ad979bea941 (integration tests are quick now). Can I have one last review? @2opremio @tamirms @Shaptic


Timeout errors when calling DELETE after upgrade

From community Slack:
Original post
Description:

Good day. After I upgraded InfluxDB from version 2.0.6 to 2.1.1 I started getting http timeout errors specifically when I call DELETE using InfluxDB java client. The other operations (read & write) seem to be fine. Any ideas?

Hi, did you resolve this? Delete seems extremely slow with even small-medium sized data sets.


Preflight reports missing dependencies in SCSS files on Windows

The "No dependency problems" check fails on Windows with create-react-app projects using SCSS:
⚠ No dependency problems
  ✖ No unused dependencies
    › Missing dependencies found:
    * C: .\src\styles.module.scss
    Add these missing dependencies by running the following command for each dependency:
      $ pnpm add <dependency name here>

No issue on macOS or Linux. Maybe related to the backslashes are causing this issue with the path?

This check is performed by depcheck, so that repo is maybe a good place to follow up with that.
https://github.com/upleveled/preflight/blob/4057ea99986fbdaaa6ed4d722349828061cdb3c0/src/checks/noDependencyProblems/noUnusedDependencies.ts#L59-L62

Fixed in Depcheck v1.4.6 (released in Preflight v2.1.17)

https://github.com/depcheck/depcheck/releases/tag/v1.4.6
https://github.com/upleveled/preflight/releases/tag/v2.1.17


Use full court name in search results and applied filters ...

…and human formatted dates in search results
Changes in this PR:
This improves readability of search results in a few different respects - using full court names everywhere, and dates formatted in human-readable style.
(This one was a @timcowlishaw and @Donna-H co-production)
Trello card / Rollbar error (etc)
https://trello.com/c/SJ79Bqk5/772-🔍-pui-replace-court-code-with-full-court-name-in-search-result-listing
https://trello.com/c/QKkEAnJp/767-🔍-pui-use-a-standard-human-readable-date-format-everywhere-we-show-dates-across-pui
and
https://trello.com/c/5wCZuSKW/763-🔍-pui-use-court-name-instead-of-court-abbreviation-in-applied-filter-dropdowns
Screenshots of UI changes:
Befo

re
After

Codecov Report

Merging #624 (6182032) into main (0e63693) will increase coverage by 0.12%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   84.13%   84.25%   +0.12%
==========================================
  Files          17       17
  Lines         750      756       +6
  Branches       48       47       -1
==========================================
+ Hits          631      637       +6
  Misses        104      104
  Partials       15       15

Impacted Files
Coverage Δ

judgments/feeds.py
92.95% <100.00%> (-0.10%)
:arrow_down:

judgments/models.py
96.15% <100.00%> (+0.40%)
:arrow_up:

judgments/templatetags/court_utils.py
100.00% <100.00%> (ø)

judgments/tests.py
94.00% <100.00%> (+0.02%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

If we're making additional visual tweaks, can we make them in another PR so this one has better separation?


Investigate why upload coverage sometimes gets stuck for sdk e2e or unit test jobs

Description
The coverage upload step seems to get stuck for two minutes and then exit without any output.
When this happens the only a part of the SDK coverage is reported so the reported coverage is less than what is expected, which makes the PR non-mergeable.
The step exits with 0 status so the CI passes properly but since the coverage is decreased it stops the PR from being merged.
Acceptance criteria

Tasks

[ ]

Does not seem to be an issue anymore.


Input doesn't work on bash for Windows

Tried compiling and running the demos through the newly released bash on Ubuntu on Windows; compilation and running the demos worked fine, but input doesn't work. Seemingly holding down ctrl C + Q for a few seconds does trigger an exit on the keyboard demo, but it's not immediate.
I'm wondering what the problem is, and where in the code I might begin trying to fix it. I had a brief look at the event polling functions, but without any concrete idea what might be causing the issue I wasn't sure how to proceed. Any ideas?

No idea, how do you run ubuntu on windows? Some virtual machine?

Ah, no, the new Linux subsystem that shipped in the latest Windows 10 update. https://blogs.msdn.microsoft.com/wsl/2016/07/08/bash-on-ubuntu-on-windows-10-anniversary-update/

Oh I see, I keep autoupdating disabled on my windows 10 machine, have no idea when I have a chance to try it out. Don't know what it's doing and how.
Maybe you can ditch C and try https://github.com/nsf/termbox-go instead. It has native windows port. If that's an option.

I've used the Go version in the past, it is really good and I will surely use it again. Quite intrigued to see if I can debug this through the bash on Windows though, so will post if I figure anything out. Thanks for your responses anyway :)


LD_RUNPATH_SEARCH_PATHS.substr is not a function

Have been getting this error when I try to build with CLI.  i am using the new -cli version from the other issue.  This was doing this on the previous version as well however.
cordova build --device --debugu
cordova-plugin-firebasex: Preparing Firebase on iOS
LD_RUNPATH_SEARCH_PATHS.substr is not a function
Not sure what this is about.

Removed platform ios and re-added
cd platforms/ios
pod install
Analyzing dependencies
Downloading dependencies
Generating Pods project
Integrating client project
Pod installation complete! There are 9 dependencies from the Podfile and 34 total pods installed.
[!] The Oil Analysis [Debug] target overrides the LD_RUNPATH_SEARCH_PATHS build setting defined in Pods/Target Support Files/Pods-Oil Analysis/Pods-Oil Analysis.debug.xcconfig'. This can lead to problems with the CocoaPods installation     - Use the $(inherited)` flag, or
- Remove the build settings from the target.
[!] The Oil Analysis [Release] target overrides the LD_RUNPATH_SEARCH_PATHS build setting defined in Pods/Target Support Files/Pods-Oil Analysis/Pods-Oil Analysis.release.xcconfig'. This can lead to problems with the CocoaPods installation     - Use the $(inherited)` flag, or
- Remove the build settings from the target.
wc-mavic:ios michaeldemutis$

That error looks like it does not arise from this plugin, it's just coincidentally following this plugin's console log statement.
Please use the --verbose option when building to get a more detail log and also build the example project as a known working reference.

Ah, wait yes I can see that it does

I removed platform ios and re-added and it seems to be ok now.  Can also build from cli no problem.   I'm using cordova ios 5.1.1.   Not sure if that is the latest version but that's what it installed.

I will have a look and see if I can see the cause

It's building fine from cli now so not sure what was happening.  Removing the ios platform then re-adding seems to work.

I can't reproduce this issue so will close this for now but if you encounter it again let me know

Its an issue with platform cordova-ios v6, removing and adding the platform as 5.1.1 fixes the issue
cordova platform remove ios
cordova platform add<EMAIL_ADDRESS>

this is what i see.
cordova-ios v5.1.0 returns a string for LD_RUNPATH_SEARCH_PATHS as
"@executable_path/Frameworks"
cordova-ios v6.0.0 returns an array of string now as
"@executable_path/Frameworks","$(inherited)"
The following function expected this variable to be a string and hence the substr failed. Modifying the following function in file /plugins/cordova-plugin-firebasex/scripts/ios/helper.js fixes it.
function addRunpathSearchBuildProperty(proj, build) {
const LD_RUNPATH_SEARCH_PATHS = proj.getBuildProperty("LD_RUNPATH_SEARCH_PATHS", build);
if (!LD_RUNPATH_SEARCH_PATHS) {
proj.addBuildProperty("LD_RUNPATH_SEARCH_PATHS", ""$(inherited) @executable_path/Frameworks"", build);
}
// Following code is to handle arrays.
if (Array.isArray(LD_RUNPATH_SEARCH_PATHS)) {
LD_RUNPATH_SEARCH_PATHS.forEach(eachpath => {
if (eachpath.indexOf("@executable_path/Frameworks") == -1) {
var newValue = eachpath.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1);
newValue += ' @executable_path/Frameworks"';
proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build);
}
if (eachpath.indexOf("$(inherited)") == -1) {
var newValue = eachpath.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1);
newValue += ' $(inherited)"';
proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build);
}
});
}
else{
// Assuming is a string
if (LD_RUNPATH_SEARCH_PATHS.indexOf("@executable_path/Frameworks") == -1) {
var newValue = LD_RUNPATH_SEARCH_PATHS.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1);
newValue += ' @executable_path/Frameworks"';
proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build);
}
if (LD_RUNPATH_SEARCH_PATHS.indexOf("$(inherited)") == -1) {
var newValue = LD_RUNPATH_SEARCH_PATHS.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1);
newValue += ' $(inherited)"';
proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build);
}
}
}

I can repro this with<EMAIL_ADDRESS>

I still have this issue with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>The project can be built only once after platform adding and the next time it gives this error "LD_RUNPATH_SEARCH_PATHS.substr is not a function".

@vladsms use cordova ios 5.1.1

Has this been released? I'm in dependency hell at the moment.

@vladsms use cordova ios 5.1.1
I am using iOS 5.1.1 platform, but I still have this problem ... I am using cordova 10.0 Plugin version<EMAIL_ADDRESS>tried iOS 5.1.1, 5.1.0, 5.0.0, 6.1. 1, 6.1.0, 6.0.0 - everywhere the same problem (((

@vladsms use cordova ios 5.1.1
I am using iOS 5.1.1 platform, but I still have this problem ... I am using cordova 10.0 Plugin version<EMAIL_ADDRESS>tried iOS 5.1.1, 5.1.0, 5.0.0, 6.1. 1, 6.1.0, 6.0.0 - everywhere the same problem (((

I had to downgrade to<EMAIL_ADDRESS>due to another android issue, but this LD_RUNPATH_SEARCH_PATHS is still there and I simply live with it. Maybe even earlier version can do the job? Did you try 8.x.x?

Switching to capacitor resolved the issue for me. I could not workout why downgrading cordova-ios did not work.

@toxaq Have you been able to use this plugin successfully with capacitor?  Does your app use push notifications?  I was under the impression that this plugin does not work with capacitor (at least for push notifications).

@jh-gh no, I just pulled the whole thing and use the capacitor push notifications plugin. That was all I was using functionality wise. I spent less time rewriting than I did trying every variation of versions to never succeed in getting this to compile.

@toxaq Thanks for the reply.  I may have to do something similar at some point if I move to capacitor.  However I would prefer to keep using this awesome plugin if possible as it has great features and incredible support ... just not for capacitor unfortunately at this point.

i am getting this build issue :
ionic: 5
cordova-ios: 6.0.0
cordova : 9.0.0
cordova-plugin-firebasex: 11.0.2,
Preparing Firebase on iOS
LD_RUNPATH_SEARCH_PATHS.substr is not a function

You folks don't like this answer but problem is cordova-ios 6.x.x as mentioned above.
I spent hours on this error with Cordova (9 & 10) FirebaseX (8.0.1 & 11.0.3) but couldn't find another solution. Including XCode build settings. First i suspected Cordova 10 but no it's just about cordova-ios version. 5.1.1 works well.
ionic cordova platform add<EMAIL_ADDRESS>

Man, indeed downgrading to 5.1.1 saved me. Been on this issue for 2 days already, nothing worked except this.

@lifox89 I am in the need to use<EMAIL_ADDRESS>as APP STORE is keep rejecting my app because existence of something called "UIWebView". This soliton is a suggested solution in this discussion

@Crypt0Graphic I am just doing like you right now!
I am doing math and trying to mix versions numbers with each other to get a successful build to the APPLE STORE!!

Here is what WORKED FOR ME.
You just open XCode and build the app from it. That's it !!
You can also Archive and Validate the app.

@lifox89 I am in the need to use<EMAIL_ADDRESS>as APP STORE is keep rejecting my app because existence of something called "UIWebView". This soliton is a suggested solution in this discussion

5.1.1 uses the new WKWebView you just had to put in the config.xml explicitly.

This way when it builds, it will force to use the new wkwebview. I always make sure that I build prod from the ionic cli, so that I won't miss anything. Incomplete build from ionic cli might leave something that is needed, and the app might not work properly in produciton.

@lifox89
Here is sample of my config.xml

I don't know what's wrong!! I've uploaded 8 apps to store till now and they are all rejected!!

Trying cordova@5 or 6 with cordova 9 or 10 didn't help, although all of suspicions plugins have been updated to latest versions as suggested from the fellas.

@lifox89 I am in the need to use<EMAIL_ADDRESS>as APP STORE is keep rejecting my app because existence of something called "UIWebView". This soliton is a suggested solution in this discussion

UIWebView is another issue. It's not about cordova-ios:

The App Store will no longer accept new apps using UIWebView as of April 2020 and app updates using UIWebView as of December 2020.

I use that preference under ios section. No problem with App Store:
<platform name="ios">
<preference name="WKWebViewOnly" value="true" />

More Info: https://ionicframework.com/blog/understanding-itms-90809-uiwebview-api-deprecation/

just had this issue. Simply removing and re-adding the ios platform again resolves it for me. You may need to force it for the add part
cordova platform remove ios
cordova platform add ios --force

@lifox89 I am in the need to use<EMAIL_ADDRESS>as APP STORE is keep rejecting my app because existence of something called "UIWebView". This soliton is a suggested solution in this discussion

UIWebView is another issue:

The App Store will no longer accept new apps using UIWebView as of April 2020 and app updates using UIWebView as of December 2020.

I use that preference under ios section for cordova-ios 5.1.1. No problem with App Store:
<platform name="ios">
<preference name="WKWebViewOnly" value="true" />

More Info: https://ionicframework.com/blog/understanding-itms-90809-uiwebview-api-deprecation/

Hello @Crypt0Graphic
Maybe because your app is already on the store. Actually this is a first time app. Believe me I've tried many stuff. I ended up migrating to another framework :(

Hello @Crypt0Graphic
Maybe because your app is already on the store. Actually this is a first time app. Believe me I've tried many stuff. I ended up migrating to another framework :(

I uploaded a new app in April '20. I remember i got a similar error and solved as i said. Btw December '20 is last date for existing apps. We will see if it's a valid solution soon.

It's 2021! any tries with App Store yet. xD

It's 2021! any tries with App Store yet. xD

It's 2021! any tries with App Store yet. xD

Anymore new or existing apps are in same situation and i published a new version of existing app in 2021 without problem. Solution seems ok.

It's 2021! any tries with App Store yet. xD

Anymore new or existing apps are in same situation and i published a new version of existing app in 2021 without problem. Solution seems ok.

Any news about this? The problem seems persist with the latest cordova-ios.

this is what i see. cordova-ios v5.1.0 returns a string for LD_RUNPATH_SEARCH_PATHS as "@executable_path/Frameworks"
cordova-ios v6.0.0 returns an array of string now as "@executable_path/Frameworks","$(inherited)"
The following function expected this variable to be a string and hence the substr failed. Modifying the following function in file /plugins/cordova-plugin-firebasex/scripts/ios/helper.js fixes it.
function addRunpathSearchBuildProperty(proj, build) { const LD_RUNPATH_SEARCH_PATHS = proj.getBuildProperty("LD_RUNPATH_SEARCH_PATHS", build); if (!LD_RUNPATH_SEARCH_PATHS) { proj.addBuildProperty("LD_RUNPATH_SEARCH_PATHS", ""$(inherited) @executable_path/Frameworks"", build); } // Following code is to handle arrays. if (Array.isArray(LD_RUNPATH_SEARCH_PATHS)) { LD_RUNPATH_SEARCH_PATHS.forEach(eachpath => { if (eachpath.indexOf("@executable_path/Frameworks") == -1) { var newValue = eachpath.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' @executable_path/Frameworks"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } if (eachpath.indexOf("$(inherited)") == -1) { var newValue = eachpath.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' $(inherited)"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } }); } else{ // Assuming is a string if (LD_RUNPATH_SEARCH_PATHS.indexOf("@executable_path/Frameworks") == -1) { var newValue = LD_RUNPATH_SEARCH_PATHS.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' @executable_path/Frameworks"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } if (LD_RUNPATH_SEARCH_PATHS.indexOf("$(inherited)") == -1) { var newValue = LD_RUNPATH_SEARCH_PATHS.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' $(inherited)"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } } }

this is what i see. cordova-ios v5.1.0 returns a string for LD_RUNPATH_SEARCH_PATHS as "@executable_path/Frameworks"
cordova-ios v6.0.0 returns an array of string now as "@executable_path/Frameworks","$(inherited)"
The following function expected this variable to be a string and hence the substr failed. Modifying the following function in file /plugins/cordova-plugin-firebasex/scripts/ios/helper.js fixes it.
function addRunpathSearchBuildProperty(proj, build) { const LD_RUNPATH_SEARCH_PATHS = proj.getBuildProperty("LD_RUNPATH_SEARCH_PATHS", build); if (!LD_RUNPATH_SEARCH_PATHS) { proj.addBuildProperty("LD_RUNPATH_SEARCH_PATHS", ""$(inherited) @executable_path/Frameworks"", build); } // Following code is to handle arrays. if (Array.isArray(LD_RUNPATH_SEARCH_PATHS)) { LD_RUNPATH_SEARCH_PATHS.forEach(eachpath => { if (eachpath.indexOf("@executable_path/Frameworks") == -1) { var newValue = eachpath.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' @executable_path/Frameworks"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } if (eachpath.indexOf("$(inherited)") == -1) { var newValue = eachpath.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' $(inherited)"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } }); } else{ // Assuming is a string if (LD_RUNPATH_SEARCH_PATHS.indexOf("@executable_path/Frameworks") == -1) { var newValue = LD_RUNPATH_SEARCH_PATHS.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' @executable_path/Frameworks"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } if (LD_RUNPATH_SEARCH_PATHS.indexOf("$(inherited)") == -1) { var newValue = LD_RUNPATH_SEARCH_PATHS.substr(0, LD_RUNPATH_SEARCH_PATHS.length - 1); newValue += ' $(inherited)"'; proj.updateBuildProperty("LD_RUNPATH_SEARCH_PATHS", newValue, build); } } }

The function needed some adjustments because newValue was several time defined and EsLint warnings, but worked


[Tests] Measure and track the execution cost

We need to measure the execution cost of various workflows. We aim to use it for regression detection and new implementation analysis.
An easy though not full solution is to measure only the storage cost. It takes the form of a storage decorator that wraps the
MockStorage.

The suggested solution would not work since it pulls the CW multi-test, which does not support gas measurement.
The adopted solution is based on the manual execution of certain tests from the Nolus Money Market end-to-end JS test suite.


Developing Spring Backend

[x] Line by line review of joke and person
[x] Read about Spring and creating stand-alone applications. Reading
[x] Figure out what files are needed --> Person has 4 more files than joke

Quote.java:

Defines the "Quote" class.
Each instance has attributes like "quote" and "emotion."

QuoteApiController.java:

Here create endpoints for:
- GET random quotes by emotion
- POST new quotes
- PUT existing quotes
- DELETE quotes.

QuoteGeneration.java:

needed to add initial quotes to database during the application startup.
implements the CommandLineRunner interface to populate quotes

QuoteJpaRepository.java:

extends Spring Data JpaRepository
defines methods for accessing and manipulating the "Quote" entity
includes methods for saving and querying quotes.

QuoteService.java:

service provides methods for saving quotes
uses "QuoteJpaRepository" for operations on the data
used to manage quotes within the application.


Release V0.0.4 - page load caused 404 on png

[ ] Using yarn dev
[ ] Using node 12.14.4
[ ] Using an up-to-date Release V0.0.4

Expected Behavior
Pool page loads without any error console errors
Current Behavior
Every time the pool page is loaded, or Refresh button is pressed a 404 is produced. This happens when entering and existing a pool.
https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/binance/assets/BUSD-BAF/logo.png

Possible Solution
Update the call to where the png is located.
Steps to Reproduce (for bugs)

Create wallet

Go to the pools area

Move into a pool (any) via + Liquidity Button

Same occurs when pressing the back button

Good catch!
Currently ASGARDEX loads icons of (almost all) icons from Trustwallet sources. Assets names for this sources are based on mainnet, that's why we have 404 in case of testnet. However, we will fix that issue.
TODO (ASGDX team)

Prevent 404 in AssetIcon for testnet
Extend AssetIcon to provide assets of all chains we currently support (not just for Binance)


Optimizing Performance and Resource Utilization with Concurrent Asynchronous Execution 🚤

Hi, this PR introduces a minor performance improvement by running the asynchronous function concurrently using Promise.all, which enhances the speed and optimizes the utilization of hardware resources.

@sanjaiyan-dev Any idea how can we run this lib on colab? It doesn't support python 3.10.

@sanjaiyan-dev Any idea how can we run this lib on colab? It doesn't support python 3.10.

Hi @pratyaksh123 , try running it by running in the lower version of python


Support memcached for query frontend

Signed-off-by: Ben Ye<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Add support for Memcached cache for query frontend.
Verification

I am already reusing the memcached client config, please check https://github.com/thanos-io/thanos/pull/3032/files#diff-8b5ab7fe39fd04754734fceb6a9966dfR38.
There is another validity field here because the Cortex cache interface Store method needs to specify a ttl.

I updated this pr. PTAL again.

Closing for the sake of #3114 cc @yeya24 @krasi-georgiev


Skip experimental import when sklearn version is >= 1.0

This avoids the user warning
"Since version 1.0, it is not needed to import enable_hist_gradient_boosting anymore. HistGradientBoostingClassifier and HistGradientBoostingRegressor are now stable and can be normally imported from sklearn.ensemble."
for users with a newer (>= 1.0) scitkit-learn version.

This is good to suppress the flood of warnings. Good to merge from my perspective.
Wondering if we should also just require an sklearn version to be >=1.0.2. @amit-sharma What do you think? There's currently no restriction on the sklearn version, but I think it's fair to require something above 1.0, now that it's there. BTW, for testing we have this explicit statement:
https://github.com/py-why/dowhy/blob/e6777f18d4df971931d7b90990fc3b5dbf81b727/.github/workflows/python-package.yml#L32
(newer version caused problems in causalml installation)


add Mikita Stryzhak to list

Access to repository is granted and you may assign yourself to one of the issues. Please check our [contributing.md] file before submitting a pull request


Replace thiserror with color-eyre

A follow-up to the chat about error reporting. This PR replaces most uses of thiserror with color-eyre.
Note, color-eyre is intended for unstructured error, and thiserror is intended for structured error, so they are not 1-to-1 equivalents. However, every thiserror enum (except 1 or 2) were just used to make ? work properly. No pattern matching was done on this, it was just unwrapped in main(). By bubbling up a Report all the way, we can capture backtrace information and get more insight into the cause of problems.
Going forward, most fallible APIs should use Result<T, Report> (unless you need to catch the error higher up):

eyre!("custom error text {some_variable}") can be used to create an ad-hoc Report object
bail!("custom error text") expands to return Err(eyre!("custom error text"));
for Result<T, impl std::error::Error>, you can provide additional context with:

result.context("some context"),
result.suggestion("try getting it right next time")
result.warning("this seems suspicious")
result.note("this error happens when blah blah blah")

Some examples (after adding std::fs::read("doesnt_exist")?; to various VotersRewards::exec):
cargo run --bin catalyst-toolbox rewards voters --registration-threshold 0 --snapshot-path asdf --total-rewards 123 --votes-count-path 123

RUST_BACKTRACE not set
Error:
   0: No such file or directory (os error 2)

Location:
   catalyst-toolbox/src/bin/cli/rewards/voters.rs:68

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

RUST_BACKTRACE=1
Error:
   0: No such file or directory (os error 2)

Location:
   catalyst-toolbox/src/bin/cli/rewards/voters.rs:68

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 5 frames hidden ⋮
   6: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual::hf4f62443ce7efde0
      at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/result.rs:2064
   7: catalyst_toolbox::cli::rewards::voters::VotersRewards::exec::h59997f272f50c2f8
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/rewards/voters.rs:68
   8: catalyst_toolbox::cli::rewards::Rewards::exec::h22c7a59c05fee778
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/rewards/mod.rs:24
   9: catalyst_toolbox::cli::CatalystCommand::exec::he69fc825e7646d22
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/mod.rs:80
  10: catalyst_toolbox::cli::Cli::exec::h1891a1709d78f56a
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/mod.rs:68
  11: catalyst_toolbox::main::h1f2ca0d2de89362a
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/catalyst-toolbox.rs:7
  12: core::ops::function::FnOnce::call_once::h2302dd43543f5e1c
      at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227
                                ⋮ 15 frames hidden ⋮

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

RUST_BACKTRACE=full
Error:
   0: No such file or directory (os error 2)

Location:
   catalyst-toolbox/src/bin/cli/rewards/voters.rs:68

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 5 frames hidden ⋮
   6: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual::hf4f62443ce7efde0
      at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/result.rs:2064
   7: catalyst_toolbox::cli::rewards::voters::VotersRewards::exec::h59997f272f50c2f8
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/rewards/voters.rs:68
        66 │             vote_threshold,
        67 │         } = self;
        68 >         std::fs::read("doesnt_exist")?;
        69 │
        70 │         let block = common.input.load_block()?;
   8: catalyst_toolbox::cli::rewards::Rewards::exec::h22c7a59c05fee778
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/rewards/mod.rs:24
        22 │     pub fn exec(self) -> Result<(), Report> {
        23 │         match self {
        24 >             Rewards::Voters(cmd) => cmd.exec(),
        25 │             Rewards::CommunityAdvisors(cmd) => cmd.exec(),
        26 │             Rewards::Veterans(cmd) => cmd.exec(),
   9: catalyst_toolbox::cli::CatalystCommand::exec::he69fc825e7646d22
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/mod.rs:80
        78 │         use self::CatalystCommand::*;
        79 │         match self {
        80 >             Rewards(rewards) => rewards.exec()?,
        81 │             Push(notifications) => notifications.exec()?,
        82 │             Recover(recover) => recover.exec()?,
  10: catalyst_toolbox::cli::Cli::exec::h1891a1709d78f56a
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/cli/mod.rs:68
        66 │             Ok(writeln!(std::io::stdout(), "{}", env!("SOURCE_VERSION"))?)
        67 │         } else if let Some(cmd) = self.command {
        68 >             cmd.exec()
        69 │         } else {
        70 │             writeln!(std::io::stderr(), "No command, try `--help'")?;
  11: catalyst_toolbox::main::h1f2ca0d2de89362a
      at /home/cameron/work/catalyst-toolbox/catalyst-toolbox/src/bin/catalyst-toolbox.rs:7
         5 │ fn main() -> color_eyre::Result<()> {
         6 │     color_eyre::install()?;
         7 >     cli::Cli::from_args().exec()?;
         8 │     Ok(())
         9 │ }
  12: core::ops::function::FnOnce::call_once::h2302dd43543f5e1c
      at /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227
                                ⋮ 15 frames hidden ⋮

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.

Colors
And because GH doesn't show colors, here's a screenshot:

Red stack frames are defined in your crate, green stack frames are from foreign crates

Looks much more better IMO !

It definitely looks good and agree we were using thiserror in places it was not really necessary, like in the cli apps. However, the lib version of catalyst toolbox might be used by other clients outside of this crate and I would still like to maintain the distinct error variants there, in case someone wants to match on that.


[GLOBAL] - Homogenize links design

It doesn't care if the links color are black (or some black scale) or primary color, but it needed to be pretty the same.

Where are links? in case i miss them


Issues caused by use of SwiftUI's NavigationStack

When targeting iOS 16 and above, the use of NavigationView is deprecated (since iOS 16.2 and similar). Stinsen internally uses NavigationView (in its NavigationViewCoordinator) in combination NavigationLink for navigation.
This implementation detail came up as an issue in a custom ViewWrapperCoordinator that was doing if #available checks for iOS 16 and then using SwiftUI's NavigationStack instead.
Environment

iOS 16.2 / Xcode 14.2
Stinsen 2.0.13

Problematic behaviour
The problem is that the dismissal of views and coordinators is broken with the approach described above. Inconsistent behaviour and white screens are symptoms. The console also frequently shows the warning: NavigationLink presenting a value must appear inside a NavigationContent-based NavigationView. Link will be disabled..
Presentation of views and coordinators actually works just fine, as far as I can tell.
Proposed changes
I know Stinsen strives to be backward very compatible. Coming from iOS 13, there is a long way until the minimum supported version will be iOS 16. Even then, NavigationView still works the same as in previous versions of iOS.
However, it would still benefit users if there was support for the new navigation types, as it would make integrating more current implementations much easier and familiar going forward.
As NavigationView is still widely used, there could be an option to either use the old or new version.
At the very least it would be very helpful if there was a hint (e.g. in the README) that custom ViewWrapperCoordinators for stack-based navigation should use NavigationView instead of NavigationStack.
Let me know what direction you would prefer and if I could be of any help.

The requirement for moving to the new APIs isn't unknown, it just ... hasn't happened yet

Thanks for the quick reply and for referring to the existing discussion. I didn't expect the topic to be in the comments to that issue but now I read it.
Are there any updates on the topic?
I think the suggested Backport solution might make it somewhat manageable to keep both implementations around for the foreseeable future.
Also, do you want to keep tracking the progress in the other ticket? Then I'll close this one.

I figured out that wrapping Coordinator in a NavigationView solves a lot of issues for me.
WindowGroup {
    NavigationView {
        UnauthenticatedCoordinator().view()
    }.navigationBarHidden(true)
}

However, I am not sure about production-readiness of this workaround, because I didn't test all the Stinsen's features yet.