Couldn't update subscription with default values

Describe the bug
Method update_subscription of filip.clients.ngsi_v2.ContextBrokerClient has following configuration for request serialization:
res = self.patch(
                url=url,
                headers=headers,
                data=subscription.json(exclude={'id'},
                                       exclude_unset=True,
                                       exclude_defaults=True,
                                       exclude_none=True))

If a subscription is created/updated with non default values you can never re-set the default ones because defaults are excluded from serialization.
To Reproduce
Steps to reproduce the behavior:
As an example try to update the status of a subscription:
        with ContextBrokerClient(url='http://localhost:1026',
                                 fiware_header=FiwareHeader(
                                     service='fw-service',
                                     service_path='/testing',
                                 )) \
                as cb_client:

            subscription = cb_client.get_subscription('xyz')
            subscription.status = Status.INACTIVE

            cb_client.update_subscription(subscription)

→ subscription updates status to "inactive"
            subscription.status = Status.ACTIVE
            cb_client.update_subscription(subscription)

→ subscription still has status "inactive"
Environment (please complete the following information):

OS: Windows 10
Version 20H2
Python 3.8

update_registration has same issue.

@dnikolay-ebc which version of the library are you currently using?

@dnikolay-ebc
I tested with a small example:
from pydantic import BaseModel, Field

class Model(BaseModel):
    test: str = Field(default='123')

model = Model(test='123')
print(model.json(exclude_defaults=True))

Does indeed skip the default although set, while
print(model.json(exclude_defaults=False))

would do the trick.
I am actually surprised by this behavior of pydantic.
We will correct this as soon as possible.


Create new windows interpreter

This fixes #52
After debugging it looks like the poetry output had a trailing \n on it so when strings got made they were not valid and could not be found. Adding a simple trim call to the output resolved all problems and a new interpreter can now be made.

@akinnear
Thank you for creating this PR.
I have tested the PR in my Linux environment.
It works fine.
I'm going to publish Monday.
Thank you very much.


Table error when saving as pdf

Delete the above section and the instructions in the sections below before submitting
Description
"Class tables" and "Descriptive Text Boxes" borders are glitching out when saving as a pdf. See attached images and code below:

Brew code to reproduce : Click to expand
PASTE BREW CODE HERE

##### The Concierge
| Level | Proficiency Bonus | Features | Cantrips Known | Spells Known | 1st | 2nd | 3rd | 4th | 5th | 6th | 7th | 8th | 9th |
|:---:|:---:|:---|:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:|:---:|
| 1st | +2 | Genetic Banishing | 3 | 1 | 2 | — | — | — | — | — | — | — | — |
| 2nd | +2 | Spiritual Biochemistry | 3 | 1 | 3 | — | — | — | — | — | — | — | — |
| 3rd | +2 | Civil Alchemy | 4 | 2 | 4 | — | — | — | — | — | — | — | — |
| 4th | +2 | Ability Score Improvement, Consecrated Biochemistry | 4 | 3 | 4 | 1 | — | — | — | — | — | — | — |
| 5th | +3 | Seismological Divination | 4 | 3 | 4 | 2 | — | — | — | — | — | — | — |
| 6th | +3 | Ability Score Improvement | 5 | 4 | 4 | 3 | 1 | — | — | — | — | — | — |
| 7th | +3 | Civil Alchemy | 5 | 4 | 4 | 3 | 2 | — | — | — | — | — | — |
| 8th | +3 | Ability Score Improvement, Biochemical Sorcery | 6 | 4 | 4 | 3 | 2 | — | — | — | — | — | — |
| 9th | +4 | Genetic Banishing | 6 | 5 | 4 | 3 | 2 | — | — | — | — | — | — |
| 10th | +4 | ─ | 7 | 5 | 4 | 3 | 2 | — | — | — | — | — | — |
| 11th | +4 | Spell Analyst | 8 | 5 | 4 | 3 | 2 | — | — | — | — | — | — |
| 12th | +4 | Ability Score Improvement, Demonic Anthropology | 9 | 6 | 4 | 3 | 2 | — | — | — | — | — | — |
| 13th | +5 | Exo Interfacer | 10 | 6 | 4 | 3 | 2 | — | — | — | — | — | — |
| 14th | +5 | Ability Score Improvement, Divinatory Mineralogy | 11 | 6 | 4 | 3 | 3 | — | — | — | — | — | — |
| 15th | +5 | Astrological Botany | 11 | 6 | 4 | 3 | 3 | 2 | — | — | — | — | — |
| 16th | +5 | Ability Score Improvement, Orbital Gravedigger | 11 | 6 | 4 | 3 | 3 | 3 | 1 | — | — | — | — |
| 17th | +6 | Spiritual Biochemistry | 11 | 6 | 4 | 3 | 3 | 3 | 2 | — | — | — | — |
| 18th | +6 | Biochemical Sorcery | 11 | 6 | 4 | 3 | 3 | 3 | 3 | — | — | — | — |
| 19th | +6 | Ability Score Improvement, Civil Alchemy | 11 | 6 | 4 | 3 | 3 | 3 | 3 | 1 | — | — | — |
| 20th | +6 | Biochemical Sorcery | 12 | 7 | 4 | 3 | 3 | 3 | 3 | 2 | — | — | — |

##### Time to Drop Knowledge
Use notes to point out some interesting information.
Tables and lists both work within a note.

Your provided code doesn't cause the issue for me. So, a couple things:

Was this on the latest version of Chrome? Other browsers are not supported and may not work as expected.
If so, can you provide the share link to your document? Maybe something else is going on?

Strange. It's doing this for all my documents, even old ones that printed
to pdf properly before. It all looks fine until I click "get pdf" and it
only bugs out within the print screen (see attached). To answer your
questions:

This is in the latest version of chrome. I'll try it on another computer
later though.
http://homebrewery.naturalcrit.com/share/SyQThgGRz I created this one as
a test.

On Thu, May 10, 2018 at 12:06 PM, Trevor Buckner<EMAIL_ADDRESS>wrote:

Your provided code doesn't cause the issue for me. So, a couple things:

Was this on the latest version of Chrome? Other browsers are not
supported and may not work as expected.
If so, can you provide the share link to your document? Maybe
something else is going on?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stolksdorf/homebrewery/issues/683#issuecomment-388118373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AlUvXOX7Zshp40TpWoDw5mPQV_peJ2ppks5txHORgaJpZM4T47as
.

I also seem to be having the same issue. I've tried on 2 different computers. I'm using the latest version of Chrome. My last pdf through "get pdf" that was fine was on the 13th. Noticed the issue for myself 2 days ago, so in my case at least the problem happened between then.

Me and a friend tested this on both homebrewery and GM Binder, with the same issue. (chrome updated, extensions off, separate machines, mine on a fresh install). The default class wide table examples will not work in chrome, at all for us. If it is a user-end issue, it would be a monumental coincidence. This is print preview specific in nature.

I am still unable to reproduce this. Does it only happen with the "wide class table" and "descriptive text box"?

@calculuschild Yes, it occurs with the wide class table (noted as Class table in examples option list) and the descriptive text box. It happens in GM Binder and Homebrewery.
Try it out with another machine to see the effect yourself. In terms of reproducing it otherwise, I have no idea. Again, it seems like a print preview issue specifically with chrome.
What's upsetting is that this renders the class table feature virtually worthless for me. :(
I really like the tables too!

I can reproduce the issue using Version 66.0.3359.181 (Official Build) (32-bit) on Windows 10.
Preview in Chrome printing dialog:

Content of the printing page (if you close the printing dialog):

Resulting PDF:

I cannot reproduce this on three different machines (and a phone), so debugging this might be tricky. I imagine this is some recent issue with Chrome if it started popping up on GMBinder as well, and hopefully it will resolve itself on its own.
In the mean time, if this doesn't happen on any of the other snippets (Note, Monster Stat Block, etc.), then I see one possible thing in common between these two.
Could someone try adding this bit to their document and see if it fixes the problem?
<style>
    .phb .classTable {
        border-image-repeat: stretch;
    }
    .phb .descriptive {
        border-image-repeat: stretch;
    }
</style>

I've created an account just to tell you that your solution worked perfectly for me, as i had the same problem for a couple of weeks. Great job!

@calculuschild
Also tested, and it works. Thank you so much. You have no idea how much this means to me.

@calculuschild  Created an account to come and report the issue which I just experienced today, saw the work-around, implemented it, and it worked for me as well (as long as the bit is there; deleting it (and making sure that the brew is saved) and trying to make a pdf reverts it back to the broken format).

I've had the same problem. The fix by calculuschild seems to work.
I spent AGES trying to work this one out.

Took me a while of fidgeting with it but I got it to work eventually will try it on other documents as well thanks.

Thank you so much @calculuschild !  I made a 129 page DMs guide for myself and just about to put my fist through the computer screen when I went to start printing it out.

 Thankfully I stumbled across this thread. Thanks @calculuschild
Will the future fix repair previous files saved or should we just patch them to be safe?

The future fix should work for all projects on the site. Unfortunately we are all stuck waiting to hear back from @stolksdorf before we can apply the changes. He has the keys to the kingdom to actually get the fixes live, but we haven't had much luck in contacting him for a while.

Hello everyone. I have this same issue, and I tried using the patch you suggest, but it doesn't fix it for me, it just fixes the descriptive box one. Class tables are still a mess. Any suggestion on how I could fix it? What's the exact place where I should place the patch at? Thanks in advance

It will probably work best at the very beginning of your document. Depending which styles you have in your document you might already have some <style> tags. You can just grab the inner part of the above snippet and paste it inside.
Make sure you have the whole piece of code. Note that there is a part that says "classTable" and another part that says "descriptive". You need the "classTable" part if you want it to fix those.

That's what I did, @calculuschild , but for some reason I can't understand, it fixes the descriptive notes, but not the class tables

To anyone who had this problem, we've finally managed to push some changes live. Can someone verify that this has been fixed on the live site? (I was never able to see the issue on my own computer, so any feedback from you all would be great!)

Closing because the fix has finally been pushed live. Thanks for bearing with us on this!


Feature names cannot always be free of placeholder words

The recommendation for [C-FEATURE] says:-

Do not call the feature use-std or with-std or any creative name that is not std.

I like this naming convention. Unfortunately, it's not always possible to follow. For example, say I want to add optional support for serde, the obvious name for such a feature would be serde. However, if some of my types can be derived automatically, I would also want to optionally depend on serde_derive. Part of my manifest will then end up as follows:
[features]
serde = ["serde", "serde_derive"]

[dependencies]
serde = { version = "1", optional = true }
serde_derive = { version = "1", optional = true }

However, this is not possible since feature names must not conflict with other package names in the manifest. In such a case, I will either have to use a name like with-serde or come up with a creative name for my feature.

You should be using serde = { version = "1.0", optional = true, features = ["derive"] }.
https://serde.rs/feature-flags.html#-feature-derive
https://github.com/serde-rs/serde/blob/v1.0.38/serde/src/lib.rs#L245-L283

Awesome! Glad to know that there is already a workaround for this for serde. Thanks @dtolnay :)
It's still an issue for crates that don't implement such workarounds and potentially other use cases but closing in favour of https://github.com/rust-lang/cargo/issues/1286.


Configuration for more than one domain?

From<EMAIL_ADDRESS>on November 04, 2010 05:51:46
How do you configure mod_pagespeed when apache is serving more than one domain?
Original issue: http://code.google.com/p/modpagespeed/issues/detail?id=12

From<EMAIL_ADDRESS>on November 04, 2010 06:49:46
Please use the ModPagespeedDomain directive to authorize mod_pagespeed to rewrite resources in a particular domain.  E.g.
ModPagespeedDomain cdn.mysite.com
ModPagespeedDomain *.mysite.com
We support wildcards * and ?

From<EMAIL_ADDRESS>on November 05, 2010 08:14:38
Please re-open this bug if this did not fix your problem. Thanks.
Status: Fixed
Owner<EMAIL_ADDRESS>Labels: -Type-Defect Type-Other


CASSANDRA-9043: Add test case for COPY from COUNTER csv

CASSANDRA-9043: Add test case for COPY from COUNTER csv

Thank you for the test! Patched trunk passes, and existing branches fail (after fixing the table name error in the test itself).
Once you address my comments I'll be +1. Do you anticipate the patch being merged soon? If so, I'd rather just hold off merging these test changes until that happens.

Hi all, I have updated based on the comments. and CASSANDRA-9043 has been merged. Can you check this PR again? thank you

Merged, thanks!


b2: Warn when account ID or key is empty

Closes #1490

Codecov Report

Merging #1491 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
- Coverage   51.59%   51.59%   -0.01%
==========================================
  Files         138      138
  Lines       11073    11077       +4
==========================================
+ Hits         5713     5715       +2
- Misses       4487     4490       +3
+ Partials      873      872       -1

Impacted Files
Coverage Δ

cmd/restic/global.go
22.82% <0%> (-0.28%)
:arrow_down:

internal/archiver/archiver.go
64.81% <0%> (-0.22%)
:arrow_down:

internal/backend/test/tests.go
58.8% <0%> (+0.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e353b00...84e493b. Read the comment docs.


Support for Elm 0.19

Nice library! Do you have any plans to re-release it to be compatible with the current version of Elm?

Thanks, @duncanmalashock.    I would, though, be happy to hand over support to someone with the time and interest in maintaining it.


Add proper "you are disconnected" fix

Currently, the workaround I have added will make the "X new messages" when you first join the chat be reduced by 1. It's not much of an issue, since that ribbon is not supposed to appear at all when you first join the chat, but I've found it to be a bit of an "It's not a bug, it's a feature" situation.
This issue is more a "TODO" for myself rather than anything.

No longer a valid issue in chatbox++ v2


onSelect should retrieve the mentioned word

Using onSelect event retrieves an object. But the value is not the raw value. It's something like html. Why not retrieving the original word too?
See:
onSelect: function (item, insertItem) {
        console.log(item)
        insertItem(item)
}

item.value returns:
"lector de colectivo".
And I just want lector de colectivo.

i had the same issue, but i did fixed it with editor.getText(0) basically just adding the number zero as an argument will make quill to not add the html formatting when parsing text to the editor


mysql56 patch bump

Fixes #1430

cmake needs modified to use std_cmake_args to fix this build on 10.11. https://github.com/Homebrew/homebrew-core/pull/5288/files will likely help point you in the right direction. Thanks!

Thanks for your contribution to Homebrew!  You rock!
For future reference the preferred commit message format for version updates is mysql56 5.6.34. Please complete the issue template in future PRs where this format is detailed in the linked Contributing guidelines. Thanks!


fix: Reconcile on HTTPRoute labels change

Which issue(s) this PR fixes:

Fixes #4278

    --- FAIL: TestGatewayAPIConformance/HTTPRouteObservedGenerationBump (60.06s)
        --- FAIL: TestGatewayAPIConformance/HTTPRouteObservedGenerationBump/observedGeneration_should_increment (60.04s)

    --- FAIL: TestGatewayAPIConformance/HTTPRouteObservedGenerationBump (60.06s)
        --- FAIL: TestGatewayAPIConformance/HTTPRouteObservedGenerationBump/observedGeneration_should_increment (60.04s)

@zirain i tried running conformance tests on local using make conformance, but they didn't run properly on my local it seems i saw a lot more errors. Also looked into similar issues in istio and cillium, but couldn't get what could have went wrong here.

yeah, I believe you fix is good, but want to know why test failed.

@luvk1412 here's how I run conformance tests

Setup a k8s cluster (I use docker desktop k8s)
make kube-deploy
make run-conformance

we probably need to peek into the envoy gateway deployment logs to see if the issue is the gateway api runner is not getting  the message or is the status update ignoring the status update

conformance looks to be pasing now but not sure why multiple enQueue(which would happen on mentioning multiple predicates instead of using or) would fail TestGatewayAPIConformance/HTTPRouteObservedGenerationBump/observedGeneration_should_increment 🤔


Mobile - Add "time-out" status for transaction history

Describe the task
Add "time-out" status for transaction history
Actual: The history show status = Failed if timeout (2 minutes)
Expect:

Show status = time-out for this case
Sync status with Subscan to show correct status

Link design: https://www.figma.com/file/mfCcK60D4OWv42MlVvrJF4/SubWallet-UI-Base-1.0.1?type=design&node-id=2967-40372&mode=design&t=JHo7dD7CTbYYGOKY-0

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-308-1415-merge-2024-01-31T04-26-50.ipa
Device test: IP 11

[ ] Do not sync transaction status with Subscan

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-309-1415-merge-2024-02-01T10-40-22.ipa
Device test: IP 11
Validation passed.


File endpoint hardcoded (getFile)

When using telegram-bot-api as telegram server, it has different path for the file endp;oint which comes from getFile, But the file endpoint hardcoded here
I was trying to send a PR for this but i couldn't figure it out where is the usage of telegram.php in the codebase?
I mean this item:
https://github.com/telegram-bot-sdk/laravel/blob/547ee486b9e70c76dbf81fa858095273cea81150/config/telegram.php#L107C1-L112

Share a sample URL? Currently the SDK does not support configuration for the file endpoint but I can look into it and consider adding the support for customization if there's sample data.

To get the path a file we should use getFile right? it return:
this is coming from from https://api.telegram.org/botTOKEN/getFile?file_id=FILE_ID

So to download this file we should put the file_path to this endpoint:
https://api.telegram.org/file/bot/<file_path>
look at the file keyword in this url
But the problem is when using telegram-bot-api as a standalone telegram server, it return something like:
     all: [
       "ok" => true,
       "result" => [
         "file_id" => "qweqwe-Dc1EMLkisBAAdtAAMrBA",
         "file_unique_id" => "AQqweADoQ4AqwegJYGVNqwe",
         "file_size" => 1216,
         "file_path" => "/var/lib/telegram-bot-api/BOT_TOKEN/thumbnails/file_159.jpg",
       ],
     ],
   }

To download this file we have to put file_path to this endpoint:
http://localhost:8081/var/lib/telegram-bot-api/BOT_TOKEN/thumbnails/file_159.jpg

As you can see there is no file keyword in the above url

I've just added the support to set a custom file url template. You can manually set by calling withFileUrl(string $fileUrl) method or set it in config under http -> file_url.
Commit:
https://github.com/telegram-bot-sdk/telegram-bot-sdk/commit/3a449a9d3d8aa5d8d1598146a811fa31000ac8e6
Default Template: {BASE_API_URL}/file/bot{TOKEN}/{FILE_PATH}
Usage
Config
// ...
'http' => [
	// ..
	'file_url' => '{BASE_API_URL}/file/bot{TOKEN}/{FILE_PATH}',
	// ...
],
// ...

On-the-fly
Telegram::withFileUrl('{BASE_API_URL}/file/bot{TOKEN}/{FILE_PATH}');

Supported Shortcodes

These shortcodes get replaced with appropriate values in the template.

{BASE_API_URL}: Your Base API URL or default https://api.telegram.org.
{TOKEN}: Bot token depending on which bot you make the call from.
{FILE_PATH}: The path you provide to the getFileUrl($path) method.


Add support for Digispark + Micronucleus

These changes add support for the Digispark board with the Micronucleus ATtiny 'virtual usb' boot loader
Requires PR https://github.com/Rahix/avr-hal/pull/364 to be merged,
then BEFORE PUBLISHING update line 21 in Cargo.toml:
19 [dependencies.arduino-hal]
20 git = "https://github.com/rahix/avr-hal"
21 rev = "3b8f39fa2ec5e3359c7bedc33d982e75e8cc3700"

This last change requires https://github.com/Rahix/avr-hal/pull/367 to be merged too


Boost Release Report -  html page and print as pdf

visual improvements and other items to be added

The next step here is that we need to design how we want the final report to look and then work backwards to make dreams into reality.

General design here:
https://docs.google.com/presentation/d/1oye8ZeJQTOhdsT9MK8T_6IFozB3TK4fl9N6x-1El-Zo/edit#slide=id.g30bf3a59df8_0_15
Let me know if you want to discuss

Instead of having a statistic for "open issues"  we would like to replace that with "closed issues & Merged PR's"
However there may be special cases for authors who insist on keeping the "upstream" repo of their contributions outside of boostorg

Completed


Update setup.py to include the missing dependency

This missing dependency results in an incomplete list of deps being included in the METADATA part of the wheel, leading to pip-compile like tools failures to resolve all necessary dependencies if not built from source.
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing
N/A
Checklist:
N/A

Do you mind signing the CLA above so that the PR can be merged? Thanks!

Hey, I think I have signed the CLA already.


LocalTpmReceiveTpmResponse does not return size of response buffer

The TCTI-specification states that TSS2_TCTI_receive should return the size of the response buffer, if NULL is given as a response buffer and the size of the answer is known (see the command description on page 12). The method LocalTpmReceiveTpmResponse (in tcti_device.c) that implements this method for a local device calls check_receive (in tcti.c) which returns TSS2_TCTI_BAD_REFERENCE in that case.

looks like a bug to me


Fix aurbuild fail on creating a new container

This fixes 2 bugs that caused aurbuild to fail when creating a new container (introduced in 1.3.3)

Thanks. We should probably go back to pacconf --raw for a more complete fix.

Done with 92b6b56b4e522b01cbf76d2f5b72f70045d52d59


Converting to Skeleton-Plus from Skeleton?

I am currently using skeleton css in my app. How hard would it be for me to make a switch? Would it be faster?
Thanks!

@ErvinSabic I will add information on it next week.

Hi @oltdaniel - this would be handy if you have a moment!

@BillTripple I'll change some stuff today. Totally forgot about this project...

@BillTribble @ErvinSabic I am really sorry for no changes. But I decided to rebuild the project as I discovered that it is nothing near the original sekeleton anymore as initally planned. Your opinions?

Sure thing, fine with me! Haven't used yet :)
On Wed, Apr 3, 2019 at 8:29 AM Daniel Oltmanns<EMAIL_ADDRESS>wrote:

@BillTribble https://github.com/BillTribble @ErvinSabic
https://github.com/ErvinSabic I am really sorry for no changes. But I
decided to rebuild the project as I discovered that it is nothing near the
original sekeleton anymore as initally planned. Your opinions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oltdaniel/skeleton-plus/issues/31#issuecomment-479372873,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFoBfNQhjIxb3U88UL1zZiv5Sw6AY5syks5vdFhGgaJpZM4SJcr7
.

@ErvinSabic Building an documentation with a detailed class to class comparison with the original skeleton is on the ToDo with the additional issues I started.


Update to Vault 3.2.1

Not sure what the long-term plans are, but FTR it would be very easy to whip up an http4s-steward. See: https://github.com/armanbilge/diy-steward

There is a typelevel-steward for Nix flakes, which is nice because it's from @typelevel-bot and not a person.  Is there a good reason we couldn't just install that here?

Is that a "true" bot (e.g. managed by the org admins) or just a user account made for botlike purposes?
by "true bot" I mean something like this:
https://github.com/apps/lucuma-steward
https://github.com/gemini-hlsw/lucuma-svgdotjs/pull/105

@typelevel-bot is a GitHub account with a shared login.  It created the typelevel-steward app corrected link.  I originally called it typelevel-flake-steward.
I guess we'd want separate apps in case flake updates and Scala updates ever needed distinct permissions, but it seems unlikely: they just wake up and open PRs.

@typelevel-bot is a GitHub account with a shared login. It created the typelevel-steward app corrected link.

IMHO this seems a bit arcane. Seems that typelevel-bot should transfer the typelevel-steward app to the org and retire.

I don't remember org apps being an option when I set that up, but it sounds fine now.  I'll work on it after lunch for Typelevel and http4s.


Attempted import error: 'useId' is not exported from 'react' (imported as 'React'). ````

Could not reproduce the issue in a codesandbox. I'm using the packages in a next.js application, and when trying to build, have the following error:
Failed to compile.
<EMAIL_ADDRESS>Attempted import error: 'useId' is not exported from 'react' (imported as 'React').

Can be reproduced here: https://github.com/matyushen/floating-ui-test
Used the Tooltip from the recipes.
The issue is no longer there is I upgrade to React 18, but doing that was not part of my plan yet.
Will appreciate any help, thanks!

That was quick! Thanks 🙏🏼


Polymer 3-0 preview on roadmap?

Hello,
Is there any plans to make Polymer-3.0-preview branch?

There is a polymerfire3 npm package, does this mean there is a polymer 3 compatible polymerfire library working?


selectAddress or selectRange

Hi,
I can't figure out how to use the "optional properties" in the cell-node and the sheet-to-Json-node.
I have the example working but only with the Cell-address field filled in with literally A2 (for example)
and the Range field filled with literally A1:F2 (for example)
The input in both cases is the output of Sheet-node.
But this is not very flexible. I would like to use another node to select which cell on that sheet or what range on that sheet is converted to the payload object.
What do I fill in in the Cell-address field of the Cell-Node?
Where or how do I specify which cell I am looking for ?
Sorry if it should be very obvious, I am relatively new to node-red
Thanks, Oscar

Some additional:
I have looked through the Closed Issues, and there is one that seems somewhat related.
#3 Jomel Jan 2019:
"As per the node documentation you can supply the name fo [of] the sheet to be selected in the sheet node either via the node prop or via incoming message prop. "
I am guessing message prop is short for message property, but it doesn't hint at what property or how to set it.
I have tried (several spellings of) "cellAddress" in different formats (J-Expression, string) in a change node, and then having the same name in the celladdress field of the Cell-Node.  It always comes back with invalid cell address.

@DozoG you can specify a cell address or a sheet range by using selectAddress or selectRange property of msg object. For example, to get A1 value, you put a change node between a sheet node and a cell node and set A1 to msg.selectAddress in the change node. Note that when using these propeties, the cell address property on the cell node and the sheet range property on the sheet to json node should be left empty.

Thank you so much. This works for me.
I was missing the correct property "selectAddress"
I swear I (thought I ) had tried exactly that. But obviously not.
Thanks again, I learned something.


Support parsing C++ templates (at least concrete specializations)

What is the feature you'd like to have?
The type parser should support parsing C++ template concrete specializations. Specifically concrete specializations and specifically just parsing into types, i.e. this does not involve creating templates in the typesystem like #3305.
Is your feature request related to a problem?
I want to import C++ headers which use templates, like things that use std::vector<int>
Are any alternative solutions acceptable?
I can manually create types for all of the template stuff, but that is tedious and error prone.
Additional Information:
Need to extend clang_svcs.cpp ClangTypeToBinja and add CType::TemplateSpecialization. Probably also need to add a bunch of other clang structures to deal with the scaffolding around the templates, but with any luck this can be limited to only fully concrete types for which a layout and fields can be generated.

Context (for searchability): I was trying to use the 'Import Header File' feature with some C++ headers from the JUCE audio library, and got an error like this:
error: /Users/devalias/Desktop/path/to/juce-6.0.4-osx/modules/juce_core/streams/juce_InputStream.h:261:5 CType::TemplateSpecialization not implemented

The code on that line looks like:

https://github.com/juce-framework/JUCE/blob/6.0.4/modules/juce_core/streams/juce_InputStream.h#L261C5-L261C63

private:
    JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (InputStream)
};

And it's defined as:

https://github.com/juce-framework/JUCE/blob/6.0.4/modules/juce_core/system/juce_PlatformDefs.h#L223-L228

#define JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(className) \
    JUCE_DECLARE_NON_COPYABLE(className) \
    JUCE_LEAK_DETECTOR(className)

This may or may not be relevant, but I was looking at ways to potentially work around this in the meantime via potentially pre-processing/expanding the headers. There seem to be a few ideas/tools mentioned here, but from a quick skim, I don't think any of them would do the full 'pre-process/expand' on their own:

https://stackoverflow.com/questions/5193867/how-to-expand-preprocess-c-template-code

As well, we may want to look into a "collapse sub-structures" option, since most STL types are unholy hydras of nested zero-size structures and unions.


Allow creation and deletion of auth zones

This PR adds all functionality needed to allow the creation/deletions of auth zones by terraform. My intention is to add support for this to the official provider when this PR is merged.

@somashekhar Hi, sorry to bother you but I see you've recently merged a PR. Is it possible to get this merged? I'm unclear if anything else is required or what the usual process is

@yuewko


How do you prevent generating [MASK] token at the last step

Thanks for your great work! I have a question about the sampling process. The sampling process at each timestep t is equivalent to sampling from p_theta(x0 | xt), and then sample from q(x_{t-1} | x0, xt), right? Then this conditional posterior distribution contains MASK token, which is theoretically inevitable to encounter when sampling. But in the end, we cannot use [MASK] sample to generate image. So, can you elaborate how to prevent this from happening, i.e., getting [MASK] when sampling from q(x_{t-1} | x0, xt)?

I have same question about it..


delta score and ambiquity

delta score = 0 for ambiguous peptides (not using third best peptide).

Are you sure? That shouldn't be possible. The second best scoring peptide is required to not have the same score as the highest scoring peptide.
`        public void AddOrReplace(PeptideWithSetModifications pwsm, double newScore, int notch, bool reportAllAmbiguity, List matchedFragmentIons)
{
if (newScore - Score > ToleranceForScoreDifferentiation) //if new score beat the old score, overwrite it
{
_bestMatchingPeptideWithetMods.Clear();
_bestMatchingPeptideWithetMods.Add((notch, pwsm));
            if (Score - RunnerUpScore > ToleranceForScoreDifferentiation)
            {
                RunnerUpScore = Score;
            }

            Score = newScore;

            PeptidesToMatchingFragments.Clear();
            PeptidesToMatchingFragments.Add(pwsm, matchedFragmentIons);
        }
        else if (newScore - Score > -ToleranceForScoreDifferentiation && reportAllAmbiguity) //else if the same score and ambiguity is allowed
        {
            _bestMatchingPeptideWithetMods.Add((notch, pwsm));

            if (!PeptidesToMatchingFragments.ContainsKey(pwsm))
            {
                PeptidesToMatchingFragments.Add(pwsm, matchedFragmentIons);
            }
            else
            {
                //TODO: Do we need to do anything????????????????? if the thing is already there?
                throw new MetaMorpheusException("Cannot add duplicate peptides to the same PSM!");
            }
        }
        else if (Score - RunnerUpScore > ToleranceForScoreDifferentiation)
        {
            RunnerUpScore = newScore;
        }
    }`

Perhaps I'm confused; do you mean that ambiguous peptides currently have delta scores of zero, or that they should have delta scores of zero but currently do not?
The argument against having a delta score of zero for ambiguity is that the user can already see the other possible ambiguous matches. Additionally, PTMs that are unlocalized get delta scores of zero.

I think PTM localization is a different issue than ambiguous base sequences. Ambiguous base sequences could (probably) come from different proteins wherease the ptm thing is simply that we dont have fragmentation evidince. one can be used in parsimony and quantification and one (the sequence ambiguous assignment) cannot.

I think I understand. In my mind, ambiguity means that there isn't a best peptide, but there's a best group of peptides. So in that case, the delta score is currently the score between the highest and second highest scoring peptide groups.
I'm not a huge fan of removing additional information (the score difference is between peptide groups), when the ambiguity information (delta score = 0) is already known (because there are multiple full sequences). The user can always override the delta score for ambiguous peptides, but they can't go back and find the delta score between peptide groups.
That being said, I don't have any investment in delta scores. If making this change helps us with something, then we should do it.


Please add information about network protected registry to windows container article

In this github issue, engineer said Windows container updated its feature.  https://github.com/MicrosoftDocs/azure-docs/issues/89178
Since windows container can use pulling from VNET connecting to ACR, this article should be adding this topic like linux container article.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1d385179-7730-3b99-aff6-75491deb070a
Version Independent ID: 7da429ea-5421-9d99-3e7c-af1b3fee5ca8
Content: Configure a custom container - Azure App Service
Content Source: articles/app-service/configure-custom-container.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@kohei-miyoshi, Thanks for the feedback! We are taking a look into this and will get back to you soon.
@cephalin, requesting your review and comments.

@kohei-miyoshi it looks like this feedback has been addressed - https://learn.microsoft.com/azure/app-service/configure-custom-container?tabs=debian&pivots=container-windows#use-an-image-from-a-network-protected-registry
Please confirm this is the update you were looking for?

@apwestgarth Yes, this article has been revised. I close this issue.


Ensures InitDocker has run before attempting to use Docker client

Fix for https://github.com/skybet/cali/issues/36 should look like.
Introduces a few changes to function return types.

I've ported this change into my fork of Cali, and it does indeed break Staticli due to the changed return types.  Specifically, the following no longer works:
if docker.ImageExists(image) {

Which needs changing to:
imageExists, _ := docker.ImageExists(image)
if imageExists {


Typo in the docs

I believe there is a typo in the code snippet:
intractive_type = message_response.get("type")
Can we change it to interactive?

Yes sure @heraldjose10
Can you send a pull request for this ?

I think this issue can be closed, right?

Issue fixed #70


Bug In youtube-dl

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.03.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2019.03.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

C:\youtube-dl>youtube-dl -v https://www.hotstar.com/tv/pyaar-ke-papad/s-2013/omkar-impresses-triloki/1000232219
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.hotstar.com/tv/pyaar-ke-papad/s-2013/omkar-impresses-triloki/1000232219']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.03.18
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17763
[debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1, phantomjs 2.1.1
[debug] Proxy map: {}
[hotstar]<PHONE_NUMBER>: Downloading webpage
[hotstar]<PHONE_NUMBER>: Downloading JSON metadata
...
<end of log>

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
youtube-dl is stop after  Downloading JSON metadata and not responding. I have tried 3 to 4 time and the same thing in happened over again YouTube-dl not progress  after Downloading JSON metadata. Please fix this issue

> py -3.7 .\youtube_dl\__main__.py https://www.hotstar.com/tv/pyaar-ke-papad/s-2013/omkar-impresses-triloki/1000232219
[hotstar]<PHONE_NUMBER>: Downloading webpage
[hotstar]<PHONE_NUMBER>: Downloading JSON metadata
[hotstar]<PHONE_NUMBER>: Downloading m3u8 information
[download] Destination: Omkar Impresses Triloki-1000232219.mp4
ffmpeg version N-85653-gb4330a0 Copyright (c) 2000-2017 the FFmpeg developers
  built with gcc 6.3.0 (GCC)
  configuration: --enable-gpl --enable-version3 --enable-cuda --enable-cuvid --enable-d3d11va --enable-dxva2 --enable-libmfx --enable-nvenc --enable-avisynth --enable-bzlib --enable-fontconfig --enable-frei0r --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libfreetype --enable-libgme --enable-libgsm --enable-libilbc --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenh264 --enable-libopenjpeg --enable-libopus --enable-librtmp --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzimg --enable-lzma --enable-zlib
  libavutil      55. 61.100 / 55. 61.100
  libavcodec     57. 93.100 / 57. 93.100
  libavformat    57. 72.101 / 57. 72.101
  libavdevice    57.  7.100 / 57.  7.100
  libavfilter     6. 87.100 /  6. 87.100
  libswscale      4.  7.101 /  4.  7.101
  libswresample   2.  8.100 /  2.  8.100
  libpostproc    54.  6.100 / 54.  6.100
Input #0, hls,applehttp, from 'https://hses.akamaized.net/videos/bharat/pkpsb/29_79499be7f7/1000232219/1553177024110/5d0f83c3ccbf4501cf952bdfc8c0d785/media-6/index.m3u8':
  Duration: 00:20:45.76, start: 0.111111, bitrate: 0 kb/s
  Program 0
    Metadata:
      variant_bitrate : 0
    Stream #0:0: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, fltp
    Metadata:
      variant_bitrate : 0
    Stream #0:1: Video: h264 (High) ([27][0][0][0] / 0x001B), yuv420p(tv, bt709), 1920x1080 [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 90k tbn, 50 tbc
    Metadata:
      variant_bitrate : 0
Output #0, mp4, to 'file:Omkar Impresses Triloki-1000232219.mp4.part':
  Metadata:
    encoder         : Lavf57.72.101
    Stream #0:0: Video: h264 (High) ([33][0][0][0] / 0x0021), yuv420p(tv, bt709), 1920x1080 [SAR 1:1 DAR 16:9], q=2-31, 25 fps, 25 tbr, 90k tbn, 90k tbc
    Metadata:
      variant_bitrate : 0
    Stream #0:1: Audio: aac (LC) ([64][0][0][0] / 0x0040), 48000 Hz, stereo, fltp
    Metadata:
      variant_bitrate : 0
Stream mapping:
  Stream #0:1 -> #0:0 (copy)
  Stream #0:0 -> #0:1 (copy)
Press [q] to stop, [?] for help
frame=  133 fps= 23 q=-1.0 Lsize=     777kB time=00:00:05.37 bitrate=1184.2kbits/s speed=0.934x
video:766kB audio:5kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.696614%
Exiting normally, received signal 2.

ERROR: Interrupted by user


Employment questions

Added 2 new questions from JW and deleted the employment question.

I think he prefers J-Dubz to JW, but :+1:


Unsafe code

As of now, the code is littered of unsafe. The proposal is to change the code with the ultimate goal of removing all unsafe blocks from the codebase.
First of all, the finaloutput variable should not be global: there's no reason for it because there are other possible ways to achieve the same thing, some of those include better readability.
About the ENV variables, the same thing as above applies.
Possible solution: create a struct where everything could be loaded inside.

but then the struct would have to be global

hm, interesting
the reference would have to be mutable?

if you modify the values inside then yes

finaloutput is modified kinda often in the code

A singleton struct would be ideal in this case

I'm not sure if this should be done soon or in 3.0
Since it looks like it would require quite a refactor

I'm not sure if this should be done soon or in 3.0 Since it looks like it would require quite a refactor

I don't think it needs to wait that much

I volunteer to work on this

@Maiori44 as the pr got merged, will you close this issue or leave it until 3.0?

guess it's no longer for 3.0, so I'll close it


Add a tool to concatenate datasets

Not sure how useful this is in practice, but might be a good exercise to demonstrate the structure of the objects, and demonstrate pointer swizzling/unswizzling.

I've been looking into the COCO-Assistant dataset utility functions for some inspiration: https://github.com/ashnair1/COCO-Assistant/blob/master/coco_assistant/coco_assistant.py
One of the key features of COCO-Assistant is that a specific directory structure is adhered to.


Improve performance of settings change propagation

Currently the app has some settings that are generated by the user interacting with the activity. These are saved to shared preferences. There is no way for different parts of the app to keep local copies of immutable settings and be notified when they change.
I propose using the green robot event bus in order to make this happen.

The service would register a listener in onCreate and unregister it in onDestroy.
When the activity changes the settings it would trigger a settings changed event.

This way a local cached copy of the settings object can be kept. And when they change the event would be used to invalidate this local copy and get another immutable one.

https://greenrobot.org/eventbus/


[BUG] PageBuffer free queue in MemoryCache.cs grows unbounded (memory leak)

Version
LiteDB v5.0.8
Describe the bug
The _free queue of PageBuffer in MemoryCache.cs can grow without limit. In our use case we have 6406 entries in the free list. This uses about 55 MB of RAM (which is more than half of the applications entire RAM usage).
Code to Reproduce
Unable to write something small and concise at the moment.
Expected behavior
The free list should cap somewhere so that we do not keep leaking memory without limit.
Screenshots/Stacktrace

Additional context
We insert and update a few hundred thousand documents to four different collections in the same database while at the same time reading from all these collections randomly (but with indices on relevant fields).

I see the same issue, but it seems to be limited to operations spanning a lot of documents.
Doing a COUNT or trying to delete using a query often ends in OutOfMemoryException.
Doing small transactions it usually ends up using 1662 extendpages before doing snapshot and freeing the cache.

How to reduce cache usage on operations that really does not store data (eg. count)
Should memorycache be able to reduce itself as well?

I've managed to save some RAM by storing the basic information of an entry in the table, and the payload into the FileStorage.
I still get too much memory usage when there are more than 50 messages.
Is there any way to force clearing the cache? Will that cause issues?

I'm experiencing this issue too, MemoryCache is using more than 100MB most of which for _readable ConcurrentDictionary that contains more than 35k entries.

Is there any way to free up this space? @lbnascimento

Any updates? PageBuffer generated 19MB of data in memory just after about 4000 operations of read and write to db. It's not much in a short term but in a week it stuff up all of my 20GB memory and crashes.
I have two databases and two instances of LiteDB:

first instance is in a static field and connection is open until I close an WPF app. In a window closing event I dispose the instance;
second instance is running in a separate thread (not UI thread) and opens and closes connection periodically. During opened connection it reads and writes in both instances of LiteDB.

This is a bit of an issue for me, too. I load around 300k documents, which are only used for a short mount of time and RAM usage grows uncontrollably.


Minimum Blank Size

[x] See if possible to have mono pd, when entering the pd for right eye and split this in two and input into the left
[x] Make the answers more presentable
[x] Invlude nice formatting by bootstrap for input
[x] More validation, can effective diameter be less than frame size or default to frame size.
[x] Explanation
[ ] Diagram

Problem from Facebook:

When the form is blank and you enter a number in the right PD and press tab, the focus doesn't go to the left PD field as you'd expect it to. (But later after you have entered data into each field, the tab works as expected from R to L PD.)

Rework this. Also need to under in one lens, no need for both. Similiar code to BVP.


exporters.tflite initial support

What does this PR do?
This PR adds the exporters.tflite subpackage, enabling the export of Transformers models to TFlite.
It defines the basic blocks, following the exporters.onnx philosophy, and one config to export BERT models.
This idea is to add support for a lot of models in the coming days / weeks once this PR is merged.
cc @sayakpaul @hollance @mfuntowicz

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for your work here. If it's not a blocker, can I review it on Monday?


Auth not working

Hey Fantastic job with the repo.
However when the email returns a link and I click it, it doesn't seem to authenticate.
Any Ideas ? I see the code in the URL but then nothing happens.

The return URL doesn't look correct. It should be going to /auth/callback
You can see the associated code here: https://github.com/KolbySisk/next-supabase-stripe-starter/blob/main/src/app/(auth)/auth/callback/route.ts
And this is where it redirects to that route: https://github.com/KolbySisk/next-supabase-stripe-starter/blob/main/src/app/(auth)/auth-actions.ts
Try updating your redirect URL in Supabase to include http://localhost:3000/auth/callback
https://supabase.com/docs/guides/auth/redirect-urls
Let me know if you get it working

Hi there @KolbySisk, I am running into this issue as well. I'm relatively new to Supabase auth so I am trying to figure this out as well. Is this how the Supabase URL needs to be set up?

When clicking this link now from my email it takes me to my Vercel URL, not my localhost. However when I head back to localhost it recognizes me as logged in.
This fixes this for me for now but would ultimately want to make sure I have this set up correctly in the long haul. Happy to help with documentation, code comments, or anything else to help newbies getting up and running with this.

@pnandha I think I figured this out. I needed to set the NEXT_PUBLIC_SITE_URL in my .env.local to http://localhost:3000. This set the authActions.js file with all the helpers in it to use getUrl correctly to properly set /auth/callback` to work as the redirect.

@RobErskine Happy to hear you figured it out.
I see the problem now. The redirect uses the getURL util function which looks for the NEXT_PUBLIC_SITE_URL and when not found falls back to localhost:3000. The intention here was that this var wouldn't be set locally and so it would always fall back.
But I merged this PR: https://github.com/KolbySisk/next-supabase-stripe-starter/pull/3 which sets the NEXT_PUBLIC_SITE_URL to a bad default. I should have paid closer attention. I think an easy fix here is to set the var to localhost:3000 locally.
Thanks for the help.


Copy backtrace binary to image

Fixes #2855

[x] ad hoc deploy and test crashing behaviour

BTs are in the logs now but hard to spot, because they bypass our service filters (their logs don't go through standard logging, which makes sense, but that means they don't show up in our standard service logs).
They're a bit hard to spot, because they don't have a format that lends itself to filtered out and alerted on. I've raise an issue to ask for support for a common prefix (suffix) to make that easier: https://github.com/apple/swift/issues/71057
In the meantime, we can look for the Backtrace took line at the end or perhaps Backtracing from for the start (the former seems more reliable, I'm not sure if the latter is universal).

The biggest issue is that backtraces take 45s or more, so we'll want to limit them to dev. I tried various options but none affect runtime in any noticeable way.


Support for multiple MCP sources for endpoints

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
For endpoints/service discovery, multiple MCP sources should be supported in multi cluster environment.
To sync service discovery from external sources, example consul(https://github.com/costinm/istio-consul), MCP sources for endpoints should be available and will sync the updates with Pilot/envoy.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Service discovery integration between istio and consul using MCP endpoints.
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
Istio 1.x.x
How was Istio installed?
helm templates
Environment where bug was observed (cloud vendor, OS, etc)
Ubuntu
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

@nmittler
I believe multiple MCP sources are supported in the config - the problem seems to be that we want the first ( or one ) to be used for config objects, and the others to be used for ServiceEntry only.
Or to adjust the config to have a set of 'endpoint' sources, separate from the config sources.
One option worth considering here - given that there are other implementations of consul adapters exposing endpoints as EDS - is to have one adapter in pilot that can retrieve endpoints from an EDS source. Long term we are considering converging MCP and XDS ( by extending XDS ), so effectively this will allow Pilot to aggregate endpoints expressed as either EDS or ServiceEntry.

@costinm @ozevren @Nino-K
Is the problem simply that Galley publishes ServiceEntry resources in the same collection as everything else? So if you subscribe to multiple galleys, you get duplicates of all of the resources?
Perhaps a first step would be to put ServiceEntry into a separate collection that Pilot can consume selectively?

I am not sure what the problem is - I think setting up ( something about the sortedCollections flags).
This is using Consul - which does its own readiness, so it doesn't have the issues we have with k8s, and
having the ServiceEntry sent in the same collections should be fine.
So documentation or some existing test that configures Pilot with 2 MCPs would probably unblock this.
And making sure that we only ask for ServiceEntries - not all other collections - for non-primary MCP servers.

@ayj @ozevren @Nino-K  it appears that Pilot always consumes all types from all MCP servers that it's configured with. This doesn't seem right to me. I would think we should be able to select the collections we receive from each server in the mesh config.  That would effectively just require adding a list of "collections" to this proto (empty means everything).
WDYT?

The PR that is in flight right now for synthetic service entries does exactly that, it leaves the main controller for all the the config types except ServiceEntries (synthetic)/ endpoints and one dedicated controller just for ServiceEntries/endpoints. Also the dedicated controller can be horizontally scaled by providing multiple source addresses. As for configuring pilot to only support specific types we had this conversation in the past here, there are a few ways that it can be tackled, but nevertheless I agree, I think pilot should be able to only listen and support configured types.

@Nino-K

The PR that is in flight right now for synthetic service entries does exactly that, it leaves the main controller for all the the config types except ServiceEntries (synthetic)/ endpoints and one dedicated controller just for ServiceEntries/endpoints

That's not exactly what we want here ... this is a bit more generic.  In this case we would want real ServiceEntry resources to be served from all MCP servers (for endpoints), but the rest of the configuration to only come from a single (i.e. this cluster's) MCP server.
Making this change would (I think) dovetail nicely with your PR ... in fact it should make some of your plumbing in Pilot a bit more generic.

@nmittler The idea of having a dedicated controller(s) just for endpoints and one controller for other config is mainly what I meant.

Making this change would (I think) dovetail nicely with your PR ... in fact it should make some of your plumbing in Pilot a bit more generic.

+1

@Jpatel86 re-reading the description, it isn't clear to me what the issue is. IIUC the mesh config already supports multiple galleys, and each galley can serve ServiceEntry. Are you saying that it's not working?

@nmittler The issue I am working on, service discovery sync between consul and Istio. I came across the consul-istio adapter which @costinm created(https://github.com/costinm/istio-consul), it listens on local consul agent and expose MCP on specific port(15098).
If I talk about this specific software, pilot detects this MCP server but it's  unable to synchronize endpoints. I think it's missing command line flags ,sortedCollections , implementation.

@Jpatel86 thanks for clarifying
@costinm do we have any integration tests for the consul integration? I took a quick look through and didn't see anything.


[Bug Report] Minor User Warning : WARN: Overriding environment HandManipulateBlockRotateZ-v1 already in registry.

Describe the bug
Getting user warning  UserWarning: WARN: Overriding environment HandManipulateBlockRotateZ-v1 already in registry.
when importing Gym.
Code example
System Info
Describe the characteristic of your environment:
gym 0.26
python 3.10
windows

Python version

Checklist

Updating the init file will fix it.

Thank you @leonasting for notifying. Will you be able to make a PR with the changes?

Yes, I have created a request. Pull https://github.com/Farama-Foundation/Gym-Robotics/pull/20


FIX for #4417: Ensuring ->removeValidation() is defined on instances of Validator. Setup new API for enabling/disabling validation. Documentation and better type handling.

Replying to original PR here: #4418
@dhensby @tractorcow
Firstly: I was in the process of setting this up in master, however I realized that maybe it'd make more sense to go ahead and rethink this and take a different approach (since we're going against master and we can be a little more flexible with the API). That is -- since there must not be very many implementations of this which are already broken by the lack of ->removeValidation() method, maybe it will make more sense to update the API take the "enable" vs "disable" approach. I think if you need the ability remove validation, you should also then have the ability to enable it again. So, I'd suggest having a new method like ->setEnabled($enabled) which ->validate() will check first before actually doing anything useful.
Secondly: Since needed to have ->removeValidation() available by default (due to it's calling/usage elsewhere), it makes sense for it to do something. In light of the above API (->setEnabled()) we can have it just be an alias for ->setEnabled(false) and, in order to make it functional, it can maintain state for the ->validate() method, which (if I'm correct) is the goal. That is, to be able to allow regular execution of the ->validate() method without triggering errors (to effectively disable/remove validation, but temporarily if desired).
Thirdly: This PR contains that along with a cleanup of ->errors to be consistent with ->getErrors() documentation (that is, it's expected to always be an array). An empty array loosely validates to false just as well as null does, plus we're being more explicit here and, in my opinion, it's simpler to just return the same type all of the time.

I forgot to mention two things:

More important: I typecast ->requireField() since it appears it would error anyway if the $data variable weren't an array (at least with a warning). I think it makes sense to do this since you should never be passing anything by an array here.
I added a bunch of PHPDoc too for clarity and type hinting.

Could you please add a test case? It could be a simple validator that fails if a field value isn't a set value, but passes if you call removeValidation() on it. :)
Code looks good to me!

I'd like to ask you not to use short array syntax too... but our coding conventions doc is mute on this point ;)

@dhensby  Alright, no problem. I've updated the array syntax to be consistent with the rest of the entire system (d'oh on my part, good habit I suppose). I realize it's in master and the PHP version for 4.x will be well above 5.4 however, that Massive Refactor(TM) hasn't happened yet, so good luck to whoever is going to be responsible for that one :) Don't want to trip them up.
On the array type hinting, I was going to be bullheaded about this. I did that initially as a proactive measure since if you're calling this, you're doing so from code you wrote and apparently not CMS/framework code (I searched for references, couldn't find any). So if the user passes anything except an array  there, it will give them an error anyway, except it'll be a little more cryptic. Apparently a string will still work (dammit SilverStripe) but at least if a user looks at the method definition, the syntactical sugar is already there to tell them "This should be an array!".
Why on earth is this code producing the error PHP Catchable fatal error:  Argument 2 passed to requireField() must be of the type array, string given when executed in a plain PHP file, yet not producing it when incorporated into SilverStripe?!?
$fieldName = "foobar";
$data = "this is a string";
requireField($fieldName, $data);

function requireField($fieldName, array $data) {
	if(is_array($data[$fieldName]) && count($data[$fieldName])) {
		echo "I will never execute :(";
	}
}

That seems like a more important issue, since at this point SilverStripe (or something in it somewhere) is causing unexpected functionality at a reasonably low level. If I were to guess, I'd probably say it's somewhere in that ErrorControlChain object tampering with standard behavior.
Let me know your opinion on that please. In the meantime I'll try to stamp out that unit test @tractorcow

@patricknelson Hmm, that should’ve already been solved in master: https://github.com/silverstripe/silverstripe-framework/issues/2928

Ok, got my test case up @tractorcow
@kinglozzer Really? How long ago?
Also, now that I'm involved, I suppose everything spirals out of control, hah. I wanted to give an opinionated rant that apparently (now that I'm testing the Validator) it has an important dependency upon a Form instance and some contortions are requires to set that up first before it can even be tested. From my shortsighted standpoint, that's a little bit of a cross contamination of concerns but that's just, like, my opinion, man. :confounded:

@patricknelson March 2014 is when the fix was merged. I just checked out master and can confirm it does error as expected:
[Recoverable Error] Argument 1 passed to TestClassFoo::bar() must be of the type array, string given, called in...

I got you @kinglozzer  I see why it didn't happen. I have my own test script (call it test.php) which includes another script that I created that initializes the SilverStripe framework similar to this, used by another module (a portion of which I authored indirectly: https://github.com/titledk/ttools-silverstripe/blob/master/lib/workbench-include.php)
So it bootstraps differently than the main.php include, which also bootstraps differently from the cli-script.php file which bootstraps differently from . . . oh nevermind.

Great, love the tests - I'm not a fan of type hinting, because really any iterable object should work here (the is_array check is silly and redundant and (looks to be) broken if an array isn't passed in).

That's right, I suppose my goal would be to have it fail earlier rather than later when that array style access is attempted but doesn't work. Also note that is_array() is being done on $data[$fieldName], not $data which is the error I was referencing originally (i.e. accessing it as an array first, via is_array(), when $data itself is not an array).
Would be a framework level thing, but maybe you could setup a standard method that could be called to detect if something allows that sort of array access (albeit an array or Traversable), similar to the function proposed here: http://stackoverflow.com/questions/3584700/iterable-objects-and-array-type-hinting
But instead, it'd be like this so you can still use array style syntax $data[$key]:
function ss_is_array($var) {
	return (is_array($var) || $var instanceof ArrayIterator);
}

Or similar.

@tractorcow @dhensby @kinglozzer
This has sat around a little while, so I've rebased on master again to keep things clean. Also just to ping and bug you guys :sunglasses:
p.s. Sorry @tractorcow I posted this comment on the wrong issue/PR a few seconds ago, in case you're confused (I'm following up on some of these since I've got some free time this week and next).

Haha, I replied to your other comment already. It's all good. :)

@sminnee shall I just merge this in by hand to deal with the conflicts?

Validator has changed a lot in the last 2 years. I suggest to raise it as a new PR.

Hmm - there have been too many changes for this to be merged by hand without having it reviewed again. I've rebased and worked it into the new file but  I can't push. @patricknelson can you enable maintainers to push to this PR please? 👼

Ok @dhensby I've added you, @tractorcow @sminnee and @kinglozzer as collaborators to my fork of silverstripe-framework. I've never had much time to follow up on my issues/PR's since usually my only time is within the day or two of initially submitting them 😔

@patricknelson you don't have to add us to the whole repo, there's a check box on the right hand side of pull request pages saying "allow contributors [write access]"
But access to the whole fork works too ;)

Ah there it is, got it @dhensby . I'll revoke ;) Let's do it the right way, sorry @tractorcow @kinglozzer @sminnee

Linting issues:
FILE: ...rstripe/silverstripe-framework/tests/php/Forms/ValidatorTest.php
----------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
 16 | ERROR | [x] Opening brace of a class must be on the line after
    |       |     the definition
 21 | ERROR | [x] Spaces must be used for alignment; tabs are not
    |       |     allowed
 21 | ERROR | [x] Spaces must be used for alignment; tabs are not
    |       |     allowed
 22 | ERROR | [x] Spaces must be used for alignment; tabs are not
    |       |     allowed
 24 | ERROR | [x] Opening brace should be on a new line
 27 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 35 | ERROR | [x] Opening brace should be on a new line
 56 | ERROR | [x] The closing brace for the class must go on the next
    |       |     line after the body
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 42.37 secs; Memory: 59.75Mb

Was there a poll/vote anywhere about these coding conventions per chance? Couldn't find easily after a quick googling (in case you have on-hand).

@patricknelson we adopted the PSRs; there were previous discussions about whether to step into line with the PSRs but beyond "yes, let's do that" we didn't get into the details of specific rules. I don't think it was a poll, the consensus was pretty clear that PSRs are the way to go.

Well, the discussion goes back years and years... it took us quite a while to actually get from the initial conception to actually moving over to psr2.
https://groups.google.com/forum/#!topic/silverstripe-dev/_ebPef7HgKQ
In fact there are still several parts of psr2 we don't yet adhere to (listed exemptions in framework/phpcs.xml.dist), but we are looking to remove those as we improve our adherence to the standard.  Shall I abstain in order to annoy the pedants?
Sarcasm aside, I get the need for the formatting standards since you'll have about as many variations in coding style as you have coders, so ¯_(ツ)_/¯  I just think halting on the foreach should be soft, non-fatal (notice/warning, not error). Space indentation, even the curly braces on a new line (which I certainly don't prefer): sure, since it more severely affects consistency and readability.
@tractorcow I can't find phpcs.xml.dist. @dhensby Where's the linter?

I think I answered both questions, sorry. https://github.com/silverstripe/silverstripe-framework/blob/master/composer.json#L87 @tractorcow did you mean tests/phpcs/ruleset.xml?

See https://github.com/silverstripe/silverstripe-framework/pull/6908. Once this is merged you can just do composer run-script lint-clean and it'll clean up your code before pull request stage.
You can use an IDE plugin to automatically show linting issues as you go.

@patricknelson most of us run with linters in our editors to pick up on these things as you're editing. What editor do you used?
Also: "composer run-script lint" runs the checks locally if that helps

@tractorcow can we correct the location of the ruleset so that IDEs can be configured more easily?

Patrick, my view on syntax rules is that they're either hard rules or no-rules-at-all — soft rules merely rot.
As a community I think getting the IDE linters into our contributors workflows is probably the best outcome and so happy to help with that/.

@tractorcow can we correct the location of the ruleset so that IDEs can be configured more easily?

My PR moves it to the standard "default" location https://github.com/silverstripe/silverstripe-framework/pull/6908, so it should (in more cases) not need specifying if runinng the linter on the repository root.

We are greed and ready to go :)

@sminnee

Patrick, my view on syntax rules is that they're either hard rules or no-rules-at-all — soft rules merely rot.

I agree 😄 Not my project and I've had less and less time to contribute to PR's, so despite the lint rules making it more difficult to swallow (so to speak), I can only ... deal with it :dark_sunglasses:

Did you manage to get your IDE set up to respect the linter rules? Did merging 6908 make it easier?

@tractorcow are you happy now?


BuildBarracksTechLabDifferentPoint failed

Describe the bug
Missing an order in a unit definition?
To Reproduce
Build and install then run 'all_tests' in the bin directory
it prints
Test: 3sc238TestBuildBarracksTechLabDifferentPointE failed!
Error: Expected order not in unit orders
Expected behavior
This test should not fail
Desktop (please complete the following information):

OS / Distro: macOS big sur 11.5.2
cpp-sc2 Version: commit c295c562ecdd3bbd773b53d7311116c6e34c3cf5
StarCraft II version5.0.7

Hi @emyr666
Thank you for reporting the issue. Unfortunately, this is known problem appeared after the one of the breaking patches. So far I have no idea how to handle it.

After some sleuthing, it seems 'test_unit_command.cc', line 194 should be 'TERRAN_BARRACKSFLYING'.
As currently there are no orders on the TERRAN_BARRACKS.
As TERRAN_BARRACKSFLYING we get 2 orders: land, build_techlab.
With test set to 'realtime', we can see this barracks is flying to get to a different point.
I used this addition of code in 'test_unit_command_common.cc' to verify one had orders and the other did not.
Starting line 84:
void TestUnitCommand::VerifyUnitOrders(const Unit* unit, ABILITY_ID test_ability) {
        bool order_found = false;

###            for (UnitOrder order : unit->orders) {
###                std::cout << "Order_Ability_Id: " << order.ability_id << std::endl;
###                std::cout << "Test_Ability_Id: " << AbilityTypeToName(test_ability) << std::endl;

I'll try and get a PR done soon, if no one else does, but I stayed up too late investigating to do it tonight/this morning.

Great! Thank you, looks like this is the source of the issue.

Closed, as the issue was fixed.


Slipping prediction issues

When a lag spike occurs and the client gets slipped before the server its aware your movement you get """"stunned"""" permanently and your movement becomes funky

Fixed by #3552


mapToClass not applied to bulkGet results

Table.mapToClass is not applied to the results of Table.bulkGet. (Using Dexie 3.0.1)
Example: https://codesandbox.io/s/dexie-maptoclass-bulkget-test-7x15x?file=/src/index.ts
I think the underlying issue is that mapToClass relies on the readHook, and that hook is run in get but not in bulkGet.
It's not entirely clear from the mapToClass docs whether this is expected, but it seems odd. (Especially since it looks like all the other bulk operations do run their corresponding CRUD hooks via the hooksMiddleware.)

Thanks for the report and the fix :)

My pleasure. Thanks for Dexie!


db: fix MultiGet() memory leak

cc @achille-roussel

Oh my! Nice catch!
Looks good to me 👍

thanks!


fix: add user v2 pw change required information on query

Closes #6614
Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz can you please assign me or @eliobischof when the PR is ready


Unclosed div sections

Where to find the issue

https://www.coronawarn.app/en/faq/results/#where_can_i_get_tested

https://www.coronawarn.app/de/faq/results/#where_can_i_get_tested

https://www.coronawarn.app/en/faq/results/#in_a_nutshell

https://www.coronawarn.app/de/faq/results/#in_a_nutshell

Describe the issue

The <div> tag in https://www.coronawarn.app/en/faq/results/#where_can_i_get_tested in the second row with the image "Testzentren in Ihrer Nähe" is not closed.
The <div> tag in https://www.coronawarn.app/en/faq/results/#in_a_nutshell with the low risk image is not closed.

Steps to reproduce
Run https://validator.w3.org/ on

https://www.coronawarn.app/en/faq/results/
https://www.coronawarn.app/de/faq/results/

and note the error message:
"Unclosed element div"
Suggestion

Add one more </div> end tag to the second row in https://www.coronawarn.app/en/faq/results/#where_can_i_get_tested with the image "Testzentren in Ihrer Nähe".

Add one more </div> end tag to the low risk image in https://www.coronawarn.app/en/faq/results/#in_a_nutshell.

PR #3237 submitted to resolve this issue

Verified that https://validator.w3.org/ run on

https://www.coronawarn.app/en/faq/results/
https://www.coronawarn.app/de/faq/results/

no longer outputs the error message
"Unclosed element div"
following on the merge of PR #3237.


Ansi to html

Fix for #1057

You disliked #1059 ?

😂 no I hadn’t seen it! Can we pick the best of both?

Dupe of #1059


[WIP] Implement a VSTest data collector to write coverage data to disk

Fixes #210
Still need to register the data collector using something like this.

@sharwell can I somehow help you getting this done?

FYI we've added some new logging infos and seems that on my local I hit issue also with coverlet build https://github.com/tonerdo/coverlet/pull/353

Still need to register the data collector using something like this.

@sharwell I did some test with collectors https://github.com/Microsoft/vstest-docs/blob/master/docs/extensions/datacollector.md and I saw that it works(deriving from DataCollector not InProc)) using simply command line
dotnet test ... --collect name --test-adapter-path path

question, why do we need config file?

why do we need config file?

No one previously knew how to enable it otherwise :)

I was testing this PR locally to see how it fixes the issue and I have a question about the implementation. With CoverletDataCollector calling UnloadModule when the test session is over, is the registration of the unload events in the Instrumenter.cs file required anymore?
In particular this block I think and maybe the code block below it as well? I'm not too familiar with this file
// Fixup the custom tracker class constructor, according to all instrumented types
if (_customTrackerRegisterUnloadEventsMethod == null)
{
    _customTrackerRegisterUnloadEventsMethod = new MethodReference(
        nameof(ModuleTrackerTemplate.RegisterUnloadEvents), module.TypeSystem.Void, _customTrackerTypeDef);
}

Instruction lastInstr = _customTrackerClassConstructorIl.Body.Instructions.Last();

if (!containsAppContext)
{
    // For "normal" cases, where the instrumented assembly is not the core library, we add a call to
    // RegisterUnloadEvents to the static constructor of the generated custom tracker. Due to static
    // initialization constraints, the core library is handled separately below.
    _customTrackerClassConstructorIl.InsertBefore(lastInstr, Instruction.Create(OpCodes.Call, _customTrackerRegisterUnloadEventsMethod));
}

I added few logs statements and I can see UnloadModule being called twice, but I'm not sure if there is any consequences to that?

Is there an easy way to get a PreRelease NuGet of this (preferably in coverlet.msbuild package) so I can test this on a project that has these symptoms?

@sharwell let me know if you would like some help to go on with this, if you don't have free cycles I could give it a try!

Just to chime in here, we're seeing the error from #210 pop up with both 2.5.0 and 2.6.0 on Azure DevOps. I'll see if I can run a test with a version in our private NuGet feed

@MarcoRossignoli It looks like using the --collect and --test-adapter-path flags isn't going to work for this collector since it is an InProc one. Looking at this code from VSTest it looks like the only way to inject an in-process data collector is through the runsettings file.

@jmezach yes I saw, as I said above I did test deriving from DataCollector that is not in proc, I wonder if it could work like in proc one to avoid settings file and use switches, it seems a simpler/more elegant approach to me.

@MarcoRossignoli I tried that today, but it looks like I don't have access to the AppDomain where the instrumented code is running, so I can't call the Unload method from there. Or at least not that I can see.

I don't have access to the AppDomain where the instrumented code is running

I think that is the reason to use InProc...or maybe some with out of proc we need a way to "call test process", something like pipes or block TestSessionEnd with some shared event if possible in a cross plat way.

@sharwell we can close this we'll implement collectors as part of https://github.com/tonerdo/coverlet/issues/395

Implemented in https://github.com/tonerdo/coverlet/pull/410


Port to RxJava 2.0

https://github.com/ReactiveX/RxJava/releases/tag/v2.0.0
Time and tide wait for no one. Should start porting these

How do you want to approach this? My suggestion would be to create a separate branch for rxjava 1.X and proceed with 2.X on master. I would be happy ot help out with the migration process as a rxjava learning exercise.
btw. I've just discovered your podcast. Love it!

You can have 1.x and 2.x in the same project, branching could make it harder to find examples for 1.x. Having both in the same branch also means you can have interop examples.

So what is the idea? Create alternative versions for each class, like TimeoutDemoFragment2 as a RxJava2 version of TimeoutDemoFragment? I'm not convinced if this is a right approach.
A link to the 1.X branch could be provided in the README so it should be easy enough to find.

I was thinking top level packages.

Ok, but how to present the examples app? Create a top level selection: rxjava / rxjava2?

I now understand where your coming from now. Shared source means we would also need to add a GUI switch. Keeping with having all source immediately visible. Yes a tabbed main page world work.
I do see why you would want a branch it.

Mostly to keep things separate. I'm also fine with one branch and top level packages. Ultimately @kaushikgopal should decide about the approach.

@qunerd : thanks for the kind words 🙏
@marukami + @qunerd: thanks for kickstarting this again.

So my original thought process was not to keep both 1.x and 2.x. Here's my reasoning:

simplicity.

To @qunerd's point, having two versions like TimeoutDemoFragment & TimeoutDemoFragment2 is a complete no no. that would be a maintenance nightmare. also there isn't a canonical reference to point 2.
also, it isn't simple to point someone to say "here's how you do X with RxJava". we would have to qualify it all saying ... actually, if you're doing RxJava 1.x then here's the one, alternatively 2.x....
nope, that sounds confusing.

new folks should be using 2.x now anyway

the original intent of this repository has always been to help folks get on board with RxJava. people starting off with Rx today, should be starting off with RxJava 2.0. so there's no reason for them to know how it's done with 1.x & 2.x (especially since there are fundamentally different api changes between the two)

☝ all that being said. for us existing folks still using 1.x and who can't necessarily up and change to 2.x. it would be nice to have:

a comparison of sorts (like 1.x vs 2.x)
a migration path. for e.g. how does this same example that i know really well how to do in 1.x look in the world of 2.x.

I think both of the above though could just as easily be satisfied with the git history and a well organized migration PR.
we have quite a few examples at this point that demonstrate 1.x use, so people can always look up the version history for that example to see how it's done in 1.x (yes it's slightly more painful and less accessible but probably the price to pay for seeing the now non-standard way of doing things)
exposing the PR would clearly show the diffs between the old way and the new way, so i think that might be a better approach. I found this to be super useful for a Dagger 2 migration process. i looked up the repo and saw the PR that performed the migration and it was invaluable.

Ok, so how should we go about doing this. I'll open up a WIP PR and jot down all the examples that need to be ported. The problem with porting these example by example is that, for the interim time both 1.x and 2.x will have to co-exist. I think this is fine until we get the final PR merged. Given that RxJava has conveniently exposed them already in different packages. I think this should be fine. But we should eventually port them all, so there's no need for any 1.x references.
Let me know what you folks think. I'll start setting up the WIP PR meanwhile.

@kaushikgopal Sounds good. Totally agree!

Just to make sure. Migration to RxJava2 should be made by creating PRs to this branch: https://github.com/kaushikgopal/RxJava-Android-Samples/tree/feat/rxjava_2?

closing this issue. interested folks should watch #83

@marcinkunert : drats. you're right. hmm... ok moving this discussion to the PR


npx github:fedeb95/truffle-flattener is error!!!

npm ERR! Error while executing:
npm ERR! X:\XX\xxx\bin\git.EXE ls-remote -h -t<EMAIL_ADDRESS>npm ERR!
npm ERR! ssh: Could not resolve hostname github.com: Name or service not known
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR!
npm ERR! exited with error code: 128
npm ERR!      X:\npm-cache_logs\2021-11-22T02_46_24_545Z-debug.log

sudo npm install "https://github.com/fedeb95/truffle-flattener.git#master" -g --save

Closing to clean up the repository. If this problem persists, please open a new issue with a clear explanation.


Implement Meet Page: Render Videos

Add the ability to view community videos in a grad layout on Desktop
Add the ability to view the community videos in a single column layout on mobile

@mcdonoughsh I believe this is complete. We'll demo this on Tuesday and understand how this connects to the PP team "Love Stories" shift of the meet page.


Add limited difficulty

Add the limited difficulty added in JDM #1300
(also changed a few places that still referenced deletion instead of access)

Incredible!
Thank you very much for your PR


Canot run outlines with Ollama via OpenAI compatible server

Describe the issue as clearly as possible:
OpenAI errors out when trying to set tokenizer.
Steps/code to reproduce the bug:
# must have ollama running

import tiktoken
from outlines import generate, models

model = models.openai(
    "phi3.5",
    base_url="http://localhost:11434/v1",
    api_key="ollama",
    tokenizer=tiktoken.get_encoding("cl100k_base"),
)

generator = generate.text(model)

result = generator("Question: What's 2+2? Answer:", max_tokens=100)
print(result)

Expected result:
LLM generation

Error message:
TypeError: AsyncOpenAI.__init__() got an unexpected keyword argument 'tokenizer'

Outlines/Python version information:
Version information

(.env) [duarteocarmo:~/Repos/tricount]$ python -c "from outlines import _version; print(_version.version)" (main✱)
0.0.46
(.env) [duarteocarmo:~/Repos/tricount]$ python -c "import sys; print('Python', sys.version)" (main✱)
Python 3.12.4 (main, Jun 14 2024, 09:57:09) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
(.env) [duarteocarmo:~/Repos/tricount]$ pip freez (main✱)
ERROR: unknown command "freez" - maybe you meant "freeze"
(.env) [duarteocarmo:~/Repos/tricount]$ pip freeze (main✱)
aiohappyeyeballs==2.4.0
aiohttp==3.10.5
aiosignal==1.3.1
annotated-types==0.7.0
anyio==4.4.0
attrs==24.2.0
certifi==2024.8.30
charset-normalizer==3.3.2
cloudpickle==3.0.0
datasets==2.21.0
dill==0.3.8
diskcache==5.6.3
distro==1.9.0
filelock==3.15.4
frozenlist==1.4.1
fsspec==2024.6.1
h11==0.14.0
httpcore==1.0.5
httpx==0.27.2
huggingface-hub==0.24.6
idna==3.8
interegular==0.3.3
Jinja2==3.1.4
jiter==0.5.0
jsonschema==4.23.0
jsonschema-specifications==2023.12.1
lark==1.2.2
llvmlite==0.43.0
MarkupSafe==2.1.5
multidict==6.0.5
multiprocess==0.70.16
nest-asyncio==1.6.0
numba==0.60.0
numpy==1.26.4
ollama==0.3.2
openai==1.43.1
outlines==0.0.46
packaging==24.1
pandas==2.2.2
pillow==10.4.0
pyairports==2.1.1
pyarrow==17.0.0
pycountry==24.6.1
pydantic==2.9.0
pydantic_core==2.23.2
python-dateutil==2.9.0.post0
pytz==2024.1
PyYAML==6.0.2
referencing==0.35.1
regex==2024.7.24
requests==2.32.3
rpds-py==0.20.0
setuptools==74.1.2
six==1.16.0
sniffio==1.3.1
tiktoken==0.7.0
tqdm==4.66.5
typing_extensions==4.12.2
tzdata==2024.1
urllib3==2.2.2
xxhash==3.5.0
yarl==1.9.11

Context for the issue:
No response  nooo

What happens when you don't pass the tokenizer? The endpoint should be returning text so a tokenizer shouldn't be necessary.

@lapp0:
# must have ollama running

import tiktoken
from outlines import generate, models

model = models.openai(
    "phi3.5",
    base_url="http://localhost:11434/v1",
    api_key="ollama",
)

generator = generate.text(model)

result = generator("Question: What's 2+2? Answer:", max_tokens=100)
print(result)

Error:
KeyError: 'Could not automatically map phi3.5 to a tokeniser. Please use `tiktoken.get_encoding` to explicitly get the tokeniser you expect.'

@duarteocarmo thanks for pointing this out to me.
I've removed the unnecessary tokenizer requirement. Could you please try
pip install --force-upgrade git+https://github.com/lapp0/outlines@openai-structured-generation

@lapp0  - that solves it! Thanks for the help :)

Great news, glad to help!

Are you able to get a proper JSON response?
I am using ollama and llama 3.1 8B model .
I keep getting validation errors.

@Pavel401 Could you please share reproduction steps in a separate issue and include your full version information via pip freeze


[server] Post validation

https://github.com/tikitko/blog-server/commit/a1c0a8b5b7a96b6cd76c8cc08be5d0f2491f453c

https://github.com/tikitko/blog-server/commit/a1c0a8b5b7a96b6cd76c8cc08be5d0f2491f453c


Add grunt integration_test to Shippable

Not ready for review: Add grunt integration_test to Shippable

We haven't been using Shippable for a while now - good to close this?

Yup, sorry for the delay but good to close this.  We can re-open if we decide to use Shippable again


Add share links at the end of the tutorial

What kind of changes does this PR include?

Changes to the docs site code

Description
This adds two simple buttons to the end of tutorial. No external styles or anything, just imports the standard button component and passing in the share links with the following text URL encoded
Just finished learning how to build my first Astro blog!

Check it out at https://docs.astro.build/!

Here's a screenshot of the website

I took the creative liberty of adding the text to invite the user to share, please do tell me if you want me to change it, but I think it's fun 😄

Congratulations on completing the Astro blog tutorial! Share your achievement with the world and let everyone know you’re an 🧑🚀Astronaut now!

Related Issue / Implementation PR

Closes Issue #4044

I just noticed we could make flex the buttons @newtoallofthis123, we should ask Otterlord what he thinks about the current orientation of that block and verify if the responsive design works for small screen sizes.

I checked the responsiveness, it worked well because I just used the already existing responsive <Button /> component. Yeah actually, I just left a comment on his original issue. Let's see what he has to say. Thanks for the review :)

Hey @TheOtterlord! Just made the changes you recommended :)


Connect GitHub To Heroku

On the deployment setting page in Heroku, you can connect an app to GitHub. Apparently, this allows for easy creation of review apps. Also this will allow the deploy code command in Travis to be deleted.

Adding the integration to push to Heroku on merges into a branch was easy. The review app part needs more setup with a pipeline. Helpful article: https://devcenter.heroku.com/articles/pipelines

Pretty cool that you can see review app environments easily within GitHub.

There is a cost to Heroku CI so I'm not trying that, but the rest of the integration works nicely.


Print DSO base address in DWARF stack trace

(From the discussion in https://docs.google.com/document/d/1HjFIJJSo1pRKo6FH84yafKbeEoSjPOXtFwwZfIeQNM0/edit?disco=AAAAJe7uY38)
Many existing symbolication tools need to use the offset relative to the DSO, but in the current dwarf stack trace format, there is no way to obtain this offset. We could print the DSO base address so that it is possible to calculate the relative offset for each stack frame.
cc @mraleph @sstrickl
Thanks.

This is done for non-symbolic stack traces. The only reason I haven't closed it yet is because I'd also like to add the DSO bases to the stack traces produced by the signal handler, now that it's accessible via the BSS sections and so we don't need signal-unsafe function calls to get it.

@sstrickl is there anything remaining here or can this be closed?


[#240] exclude rouge 1.9.1

https://github.com/trulia/hologram/issues/240

Much belated, but thank you.


Refactor typescript types

The final goal is to generate the API section in the README automatically based on the code via JSDoc, instead of having to maintain it manually.
While trying to work on that, I noticed that the usage of typescript could be improved in various places.
Hope this is ok :)

lgtm


How to set up ElasticSearch on a remote server

Anywhere we can specify the ip of the remote server to access?
Thanks

Yeah:
Tire.configure { url "http://somewhereinthecloud.com" }


Manual zoom from sliders/range input

Hi is it possible to do a zoom on the canvas from sliders or range input ?
I guess i need to grab the zoom data and add something like the plus and minus button
thx for the support

Sure, just put in a slider and whenever it changes, call viewer.viewport.zoomTo() with the appropriate value. You'll probably want to convert the slider range to a logarithmic scale. Also, you should watch for zoom events and update the slider.

Sure, just put in a slider and whenever it changes, call viewer.viewport.zoomTo() with the appropriate value. You'll probably want to convert the slider range to a logarithmic scale. Also, you should watch for zoom events and update the slider.

Hi, sorry to reopen this old thread but i must admit i can't find out how to achieve the last part of your answer with tiled images, what a noob...
my slider work very well when it comes to zoom the viewport but i can't get it to be updated depending on the zoom level when zoomed with the mouse
a little help would be very welcome :)
have a nice day

Sure! Something like this should do it:
viewer.addHandler('zoom', () => {
    const zoom = viewer.viewport.getZoom();
    // Set your slider value to the zoom value
});

I haven't tested that, but it's the basic idea.
There's a possibility you might get into some sort of infinite loop where you are watching the zoom to change the slider and watching the slider to change the zoom... You can fix that by keeping track of the most recent slider update and not updating it from your zoom handler if you're within a certain time threshold since then.

Hi Ian
and thanks again and again for your help
actually, that's exactly what i've done, it works very well with a single image (i've used animation-finished to avoid too many requests and it works fine, too, my range slider updates the viewer and the viewer updates the range slider after some simple math with the viewer zoom value)
when it comes to tiled Image (i've read what you say about being less accurate and tried, but unsuccessfully, to use TiledImage) it starts working at big zoom values (probably because it has less tiles to manage) but at lower ones i get funny results (with zoom eventhandler this time as nothing usable with animation or animation finished, just requests responses about the tiles that are in the viewer)
using the console to see what it returns, i understand what you said about accuracy
you know, i think i'll go without this range slider for the moment, the + / - buttons and the mouse do the job very well :)
have a nice day

Hmm, I'm curious what you mean about the accuracy. You're saying the zoom values are weird when you're zoomed too far out? Or too far in?

hi,
well, actually, using the console, that's what i get around big zoom values (being zooming in of course, not back and forth)

seems better if i use getZoom(false) i just get one value but is it the right one? :)
but at low levels i get a lot of get requests logs between the values, probably when it changes the image folder it uses
on animation-finished it doesn't return any value for getZoom(), only a huge series of get requests
not that important, honestly i can manage to get what i want without that range slider, whatever size the image is
have a nice day

@virtualgadjo Okay, thank you for the further information!


Add warning re TopFiveSongs aggregator

See discussion on https://issues.apache.org/jira/browse/KAFKA-12446
and https://github.com/confluentinc/kafka-streams-examples/issues/380

@confluentinc It looks like @benissimo just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

Thanks @benissimo!


[mempool] fix sequence_number_cache setter

previously it was possible under race to get value higher than storage one

@bors-libra r+

:pushpin: Commit dd73f77 has been approved by andll

:hourglass: Testing commit dd73f77dbf358af7dc7ffd1b41f2993c56f1b8eb with merge c64f8e6722d9c32cdec14bb60d791446af1656a7...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: andll
Pushing c64f8e6722d9c32cdec14bb60d791446af1656a7 to master...


How can I include unaccent pgsql function in Dynamic Linq queries?

I need to make a query like this:
habitantes = _context.HABITANTES.Where(h => _context.Unaccent(h.Apellido1) == _context.Unaccent("GARCÍA"));
But I don't know how to put the Unaccent postgress function in mi where string;
whereStr = $"{nameField} {searchOpeStr} "{searchString}"";.

Not familiar with PostgreSQL, but how would you call the Unaccent function from a strongly-typed query in C#?
You'd probably use this or another overload.
I would suggest registering the DbFunctions class with Dynamic LINQ so its' members will be recognized by the parser.

Hi,
A strongly-typed EF 6 query may be something like this:
habitantes = _context.HABITANTES.Where(h => _context.Unaccent(h.Apellido1) == _context.Unaccent("GARCÍA"));
And it works fine.
I forgot to say before that I'm working with Entity Framework 6 NOT with Entity Framework Core.
So, I think the solutions you give me are only suitable for EF Core, right?

On which type is the Unaccent method defined for the EF6 provider? I can see that for the EF Core provider it's defined on the static class Microsoft.EntityFrameworkCore.NpgsqlFullTextSearchDbFunctions, but I can't seem to find the same for EF6.
If that type (presumably inheriting from DbContext) is an instance method, you could pass in the context as a parameter, and call Unaccent on it:
habitantes = _context.HABITANTES.Where($"@0.Unaccent({nameField}) {searchOpeStr} @0.Unaccent(\"{searchString}\")", _context);

If that type is a static type, you'll need to register the type using a custom type provider. For example, the EF Core functions could be registered like this:
using Microsoft.EntityFrameworkCore;

public class PostgreSQLTypePRovider : DefaultDynamicLinqCustomTypeProvider {
    public override HashSet<Type> GetCustomTypes() =>
        new[] { typeof(NpgsqlFullTextSearchDbFunctions) }.ToHashSet();
}

Then, you set the provider in a config object, and pass the config object as the first parameter (although I'm not sure how to get an instance of DbFunctions:
var config = new ParsingConfig {
    CustomTypeProvider = new PostgreSQLTypePRovider()
};

var fns = /* get instance of DbFunctions; not sure how to do that */;
habitantes = _context.HABITANTES.Where(config, $"NpgsqlFullTextSearchDbFunctions.Unaccent(@0, {nameField}) {searchOpeStr} NpgsqlFullTextSearchDbFunctions.Unaccent(@0, \"{searchString}\")", fns);

@rdeharo
Is this question still relevant to you? else I'll close it.

Closing...


TITLE

Title
4 Tips to Transition from Contributorhood to Maintainership
Author or authors
Chrissy Codes
Description
In honor of Maintainer's Month, my blog post focuses on four tips to transition from contributor to open source maintainer.
Resource link
https://chrissycodes.hashnode.dev/4-tips-to-transition-from-contributorhood-to-maintainership
Content type
Blog Post
Related topics
Open Source

Thanks @CBID2! This is live on the website!
Here's our asset kit to make it easy for you to share: https://gist.github.com/abbycabs/39f8f8577f2a7dae3a9b1c88b9ff6aeb