bug(mat-form-field): Does not show placeholder text when mat-label is empty

Reproduction
Use StackBlitz to reproduce your issue:
https://stackblitz.com/edit/angular-w1cssx?file=src/app/form-field-appearance-example.html
Steps to reproduce:

Create a Material form field with an empty mat-label and an input with placeholder

<mat-form-field appearance="outline">
  <mat-label></mat-label>
  <input matInput placeholder="Placeholder" />
  <mat-icon matSuffix>sentiment_very_satisfied</mat-icon>
  <mat-hint>Hint</mat-hint>
</mat-form-field>

The placeholder only appears if you remove the empty mat-label
Expected Behavior
Show the placeholder
Actual Behavior
Placeholder is not shown
Environment

Angular:11.0.0
CDK/Material:11.0.0
Browser(s):Chrome 88
Operating System (e.g. Windows, macOS, Ubuntu): MacOS

I agree that it's a bug, but dealing with it on our end in a reliable and performant way will be tricky, because we'd have to observe the DOM for changes. Furthermore, providing empty labels is an accessibility issue. I'm closing this issue, because it can be handled by the consumer by not providing an empty mat-label in the first place.

I'm dynamically creating / adjusting form elements based on user actions... if I remove the label in one scenario then re-add it in another it breaks...

Couldn't you put an ngIf on the label so it doesn't render when empty?

adding *ngif to the label doesnt work, it will never reappear... I ended up creating a custom directive to fix the issue to call change detection on the parent
@Directive({ selector: '[cdMatLabelFix]' })
export class MatLabelFixDirective {
  private _value: string | undefined = '';

  @Input()
  set value(value: string | undefined) {
    if (this._value === value) return;
    this._cdRef.markForCheck();
    this._value = value;
  }

  constructor(@SkipSelf() private _cdRef: ChangeDetectorRef) {}
}


cmake: Fix CMake build to allow for whitespace

closes #166
Tested locally to reproduce issue.

CI Vulkan-ExtensionLayer build queued with queue ID 30242.

CI Vulkan-ExtensionLayer build # 274 running.

CI Vulkan-ExtensionLayer build # 274 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 30264.

CI Vulkan-ExtensionLayer build queued with queue ID 30270.

CI Vulkan-ExtensionLayer build # 276 running.

CI Vulkan-ExtensionLayer build queued with queue ID 30294.

CI Vulkan-ExtensionLayer build # 277 running.

CI Vulkan-ExtensionLayer build queued with queue ID 30304.

CI Vulkan-ExtensionLayer build # 278 running.

CI Vulkan-ExtensionLayer build # 278 failed.

CI Vulkan-ExtensionLayer build # 278 failed.

This one looks like a CI failure. I've now fixed the Windows build.

CI Vulkan-ExtensionLayer build queued with queue ID 30329.

CI Vulkan-ExtensionLayer build # 279 running.

CI Vulkan-ExtensionLayer build # 279 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 30656.

CI Vulkan-ExtensionLayer build # 280 running.

CI Vulkan-ExtensionLayer build # 280 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 30670.

CI Vulkan-ExtensionLayer build # 281 running.

CI Vulkan-ExtensionLayer build # 281 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 30711.

CI Vulkan-ExtensionLayer build # 282 running.

CI Vulkan-ExtensionLayer build # 282 passed.


bug fix: no error thrown in openMenu() when theme options set to false

Just added another
if (themes) {
    ...
}

to prevent a loading error (Cannot read property 'getAttribute' of null) when menu is opened while Themes options is set to false.

Done. v0.9.2

Thanks!


Remove querystring from exposed URL

If ReDoc is initiated on a page containing query strings in the URL, the generated URL is misbehaving as shown on the following image

Live example at https://demo.api-platform.com/?ui=re_doc&spec_version=3
After this change the exposed URL would be https://demo.api-platform.com/books as expected

Coverage increased (+0.01%) to 81.757% when pulling ffb186dd21d3aab08b785e8de1145feec3b3935f on antograssiot:filter-querystring into 5dd5d6d704ec6e6f739c6f0c4ac868c73fbca0a0 on Rebilly:master.

updated as requested I think @RomanGotsiy

Thanks!


Remove reference to direct OSO datasets from Open Collective blog post

What is it?
push to subscribe

https://github.com/opensource-observer/oso/pull/2383


[sycl] Install Intel OpenCL CPU runtime 2<IP_ADDRESS>.04 as an external

@AuroraPerego can you try if this works for you ?

Thanks for adding it :)
The only issue I see is that INTELOCLCPU_BASE is used at line 162 but defined at line 266. If I move the definition before line 162, everything works. I'll try it also with alpaka.


opening Xcode project does not open the actual project, shows the content of the descriptor only

VSCode Version:1.49.3
OS Version:Darwin x64 19.5.0

Steps to Reproduce:

create a simple Xcode project
save it
open the resulting .xcodeproj in VSCode

What opens is the content of xcodeproj and not the actual code files that are described by them:

Does this issue occur when all extensions are disabled?: Yes/No
YES

We don't natively support xcode's project format.. if you know where the files are on your disk, opening VS Code to that directory should allow you to work on them.


feat: create reuseable error component

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
This PR:
Adds reusable error component.
-It takes errorMessage as a string for its optional parameter. If the errorMessage is not passed it will show the default error message "Something went wrong".
-It takes the optional fullWide as a boolean parameter. The default value is false. We have to pass the value true if we want
to make it full-wide.
I used this component for repo look up error message.

Related Tickets & Documents
Fixes #781 #700

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

When a repo is not being indexed, we still want the user to go to the discussion for now.

When a repo is not being indexed, we still want the user to go to the discussion for now. Your updated error message does not provide that context.

@bdougie
We still have the component to visit the discussion page if the repo is not indexed.
Did you mean something else?

@shamimbinnur this needs at least one story for this to the design system also.
Some examples are in the atoms folder https://github.com/open-sauced/insights/tree/beta/stories/atoms

@brandonroberts added stories!


[C++][Parquet] Add option to set RPATH to ORIGIN

Made this an option as the actual RPATH value differs between OSX and Linux.
Reporter: Uwe Korn / @xhochy
Assignee: Uwe Korn](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=uwe) / @xhochy
Note: This issue was originally created as PARQUET-903. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 265
https://github.com/apache/parquet-cpp/pull/265

Uwe Korn / @xhochy:
PR: https://github.com/apache/parquet-cpp/pull/265


Nuxt 3 + @unocss/nuxt "content.pipeline.exclude" not work.

UnoCSS version
<EMAIL_ADDRESS>Describe the bug
Fresh install Nuxt3 add @unocss/nuxt s module. When provide exlude option it must exclude that dirs. Also you can check it in devtools.
Reproduction
Fresh install Nuxt3 add @unocss/nuxt.
export default defineConfig({
  content: {
    pipeline:{
      // include: ['pages/**/*.vue','components/**/*.vue'],
      exclude: ['node_modules','.git','.output'],
    }
  },
  ...
})

It will not work and when build project it will contain classnames from node_modules
but if i uncomment include it will work.
System Info

Operating System: Darwin
Node Version:     v20.3.0
Nuxt Version:     3.6.2
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, modules
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

mark

mark

mark what ?)


pass complete flask request to handler.py

Passing the entire request to the handler opens a number of possibilities, among them support for multipart/form-data. Based on this change, I can create a function that accepts multiple pdf files as multipart/form-data and joins them into a single pdf:
from PyPDF2 import PdfFileMerger, PdfFileReader
from flask import send_file
import tempfile

def handle(req):
    """handle a request to the function
    Args:
        req (request): flask request
    """
    files = req.files
    file_storages = files.getlist("files")
    merger = PdfFileMerger()

    for file_storage in file_storages:
        pdfFileReader = PdfFileReader(file_storage)
        merger.append(pdfFileReader)

    fout = tempfile.TemporaryFile()
    merger.write(fout)

    for file_storage in file_storages:
        file_storage.close()

    fout.seek(0)
    return send_file(fout, 'application/pdf')

Hi @dschulten as nice as this sounds, it's a breaking change and can't be merged due to the effect on our existing users.
Btw. all changes must be proposed through an issue and approved before being worked on.
Alex


ioredis 4.0.1 don't found referenced redis-commands bzpopmin()

Hello,
I've just tested from scratch, and I still have the problem:
const util = require('util')
const dump = (obj) => console.log(util.inspect(obj, false))

const Redis = require('ioredis')
const redis = new Redis('redis://:mySecretPassword@<IP_ADDRESS>:6379')

redis.on('connect', async () => {
  try {
    const x = await redis.bzpopmin('myZSet', 0)
    console.log('SUCCESS')
    dump(x)
  }
  catch (e) {
    console.log('ERROR')
    dump(e)
  }
})

ERROR
TypeError: redis.bzpopmin is not a function
at Redis.redis.on (/www/test/test.js:9:27)
at emitOne (events.js:116:13)
at Redis.emit (events.js:211:7)
at _combinedTickCallback (internal/process/next_tick.js:132:7)
at process._tickCallback (internal/process/next_tick.js:181:9)

I use the last version 4.0.1, include the redis-commands 1.3.5:

% cat package.json | grep ioredis
"ioredis": "^4.0.1",
% cat node_modules/ioredis/package.json | grep commands
"redis-commands": "^1.3.5",

The redis-commands correctly declare the command bzpopmin:
https://github.com/NodeRedis/redis-commands/search?q=bzpopmin&unscoped_q=bzpopmin
EDIT: And I use Redis 5.0 RC5, and if I use the command in my redis-cli it's works fine.
Regards

In my node_modules/redis-commands/package.json I have the last version, 1.3.5, but the node_modules/redis-commands/commands.json doesn't include Redis 5.0 commands.... It's not the master branch where the Redis 5.0 commands have been added in July.
BTW, there is an error on Circle CI caused by the devDependency of ioredis: https://github.com/NodeRedis/redis-commands/compare/greenkeeper/ioredis-4.0.1

Sorry for not noticing that. Just published a new version for redis-commands. Now a fresh install of ioredis will support Redis 5.0 commands.

Hello @luin , is it possible to update the commands list with latests/newest additions, such as the LPOS command (Available since 6.0.6)?


How can i implement this library to do a Menu Item Search?

I know, in the example say how. But not clear for me... please help!

you can find in example. Just dig to the example.


Restore support for querying user roles

Earlier versions of HTTP-RPC supported the Roles interface, which provided the isUserInRole() method that allowed a caller to test user role membership. This capability may still be useful. It could be restored via a different API; for example, the WebService class could provide a getRoles() method that would return a Set containing the user's available roles.
WebService could provide a protected setRoles() method to allow the environment to configure the user's roles. If s, the initialize() method should probably be deprecated in favor of protected setUsername() and setLocale() methods.

Support for user roles has been restored. The WebService class now provides an abstract getUserRoles() method that returns a Set<String>. The set can be queried for role membership.


Using "Show in Explorer" command on a folder in the treeview does not show the complete folder path on Windows

Description : It is not possible to navigate easly in the windows explorer when using the "Open in explorer" command in the Atom Tree view on Windows.
To test :
Create a folder with a text file in it.
Right click > Open with Atom
In the tree view, click on "Open in explorer"
http://i.imgur.com/NUNUBYA.png
To compare, click on the path at the top of the window that just opened, and copy & past it into a new window explorer
You can see from the following image that the explorer that Atom opened (left one in the printscreen) does not show all the path and that you can not click on the previous button either.
http://i.imgur.com/tbe0n8y.png
Because of that behavior, it is difficult to navigate in windows that Atom opens.

+1
I have to deal with this all the time at work.

@zephraph Probably, I did not check the other atoms projects so I did not know it existed. Maybe we can move it there.

@Tareck117, close this issue and see my pull request. This is a tree-view issue.

@zephraph Perfect. Thank you very much


[Question] Is it possible to mock indirect imports?

Lets say my JS source has function.js:
import { depFun } from '../more-function.js';

export const impFun = () => {
   depFun();
}

then I have more-function.js:
import { deepFun }  from './deep-function.js';

export const depFun = () => {
   return deepFun();
}

and deep-function.js:
export const deepFun = () => {
   return "deep original";
}

Then in my unit test I would like to mock the deepFun() that is indirectly imported
describe('Test test', () => {
  it('mytest', async () => {
    const { impFun } = await esmock(
      './function.js', {
        './more-function.js': {
          './deep-function.js': {
            deepFun: () => "mocked"
          }
        }
      });
    assert.equal('mocked', impFun());
  });
});

But this doesn't work. I get a SyntaxError: Unexpected token '.' at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:168:18)
Is something like this possible with esmock?

do one of these work for you?
// mock deep-function.js' 'deepFun' only for
// function.js -> more-fuction.js -> deep-function.js
const { impFun } = await esmock('./function.js', {
  './more-function.js': await esmock('more-function.js', {
    './deep-function.js': {
      deepFun: () => "mocked"
    }
  })
})

// globally mock deep-function.js' 'deepFun'
const { impFun } = await esmock('./function.js', null, {
  './deep-function.js': {
    deepFun: () => "mocked"
  }
})

closing, feel free to reopen for any reason

Thank you @iambumblehead . I can confirm that both approaches work!

Hi @iambumblehead I have a slight follow up question:
Let's say I have function.js like this:
export const myFun = () => {
  return 'fun';
}

export const impFun = () => {
  return myFun();
}

And I would like to mock myFun() from it so that when I call impFun() it returns mocky. I tried this but that doesn't work. I also tried it with null as the second parameter:
      const { impFun } = await esmock('./function.js', {
        './function.js': {
          myFun: () => 'mocky'
        }
      });

     assert.equal('mocky', impFun());

It's probably a beginner's mistake 😄

esmock cannot do that.  esmock modifies import paths to import mocked definitions, and so mock definitions must be imported.  This limitation allows esmock to work without usage source code transformations,
It does something like this
function.js
-import deep from './deep-function.js'
+import deep from './deep-function.js?with-mocked-definitions'

deep('is mocked')

It's probably a beginner's mistake 😄

Probably esmock is difficult to understand. A review I found on the internet recently https://adamtuttle.codes/blog/2024/mocking-esm-dependencies-for-tests/ writes,

[esmock] seemed like it might be simpler, I couldn't get it working the way I wanted (see also: "at all") and the docs were not super clear.

Thanks for using esmock despite difficulties. esmock tries to be as useful and practical as possible.

Thanks for explaining @iambumblehead I was thinking, maybe I can do it by adding a level of indirection? E.g. adding a functionimporter.js alongside that imports function.js and calls its methods. It seems similar to the other scenarios, but unfortunately I wasn't able to get it to work...
Something like this functionimporter.js:
import { impFun } from "./function.js";

export const impFunCaller = () => {
  return impFun();
}

And then use it something like this:
      const { impFunCaller } = await esmock('./funcimporter.js', {
        './function.js': {
          myFun: () => 'mocky'
        }
      });

      assert.equal('mocky', impFunCaller());

@bosschaert this test resembling yours passes here https://github.com/iambumblehead/esmock/pull/301

@bosschaert thanks :)


Using this with homestead

Hi guys,
Great work on this! I've just managed to get my head around it and once again the Laravel community has outdone itself.
I just wanted to point something out for anyone starting out with this package, which wasn't immediately clear to me.
I had issues getting this to work with presence channels.  When authenticating user against the channel, it was throwing a 404 error for the /broadcasting/auth route.  Digging in, I found that the default authHost was http://localhost, which makes sense, but this wasn't the correct address for my laravel app via homestead.
When I specified the "authHost" in "server.js" with what was configured in homestead (e.g. 'http://app.dev'), then this worked fine.
This may be obvious to some, but I spent a few hours trying to crack this one!
Otherwise, thank you very much for your efforts!

Thanks for this very useful feedback. I'll be working on better documentation and a setup process for version 1.0. I'll keep this open and when we get there you can check it out.

No problem! I assumed it was an optional config, which it still could be, but for me in this case, I had to specify the authHost address.
Thanks again.


bug: can not sync delete namespace action

Describe the bug
When I create an ns, it is created synchronously in the physical cluster, but when I delete it, it cannot be deleted synchronously
Steps To Reproduce

$ k delete ns demo-ns
namespace "demo-ns" deleted
$ KUBECONFIG=.kcp/admin.kubeconfig k get ns
kcp-35890zhta3f8                          Active   15m

Expected Behaviour
success delete ns
Additional Context
none.

Hey @SakuraAxy, sorry for getting back to you late. Can you maybe provide the YAML for the namespace objects and the kcp version you are using? Is this a problem you are still facing?

/transfer-issue contrib-tmc

/transfer-issue contrib-tmc


[Event Request] Codeunit 90 Purch.-Post - OnAfterPostPurchLines

Hi, would it be possible to modify the event OnAfterPostPurchLines in Codeunit 90 Purch.-Post in order to add PurchLine and TempInvoiceBuffer as parameters ?
    [IntegrationEvent(false, false)]
    local procedure OnAfterPostPurchLines(var PurchHeader: Record "Purchase Header"; var PurchRcptHeader: Record "Purch. Rcpt. Header"; var PurchInvHeader: Record "Purch. Inv. Header"; var PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; var ReturnShipmentHeader: Record "Return Shipment Header"; WhseShip: Boolean; WhseReceive: Boolean; var PurchLinesProcessed: Boolean; CommitIsSuppressed: Boolean; EverythingInvoiced: Boolean;
    var PurchLine : Record "Purchase Line" ; TempInvoicePostBuffer : Record "Invoice Post Buffer")
    begin
    end;

?
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Router context invalidate Promise resolve does not invalidate context

Describe the bug
In the code below, which was suppose to invalidate the context and navigate to the following route. for context i'm following the example given in tanstack authenticated routes example. Even after navigation the context isn't invalidated which I can see in console log. It results in redirect to login page not working properly after clicking logout and just stuck in the "/" page.
router.invalidate().finally(() => {           navigate({ to: "/" });         });
It only invalidates or I can see it invalidates when I manually reload the page, which means during the navigation the context isn't invalidate.
PS: I do have an api request in the logout function.
Your Example Website or App
...
Steps to Reproduce the Bug or Issue
Following the tanstack example locally.
Expected behavior
Router context should've been already invalid in .finally or .then even before navigating.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

i got same issue, and stuck with this, any solution ? when i am use authenticated using local storage, there is no problem, but when using api, not navigate after login success

i got same issue, and stuck with this, any solution ? when i am use authenticated using local storage, there is no problem, but when using api, not navigate after login success

Still no reply from the devs as of now

same issue here

can you please provide a minimal complete example by forking one of the router examples on stackblitz?

can you please provide a minimal complete example by forking one of the router examples on stackblitz?

https://stackblitz.com/edit/tanstack-router-4achrw?file=src%2Froutes%2F_auth.tsx
Here a link to a fork, I've only made one change to this, instead of navigating to "/" which is a public route, it navigates to "login", which shouldn't be a problem if context is invalidated, however it isn't. so even after clicking logout, it doesn't go back to "login" route.

Same here while using supabase auth api. No issue when working with local storage.

update guys, the current hack seems to use sleep(1000) as explained here :
https://github.com/TanStack/router/discussions/1668
// This is just a hack being used to wait for the auth state to update
// in a real app, you'd want to use a more robust solution
      await sleep(1)

This trick works on my side, but this is a serious issue with Context.

I'm currently using the flushSync solution as a workaround following suggestion by SzelamC at https://github.com/TanStack/router/discussions/1668#discussioncomment-9726727

I'm currently using the flushSync solution as a workaround following suggestion by SzelamC at #1668 (reply in thread)

So where should I use flushSync regarding this issue?

Thanks @ilia-luk, it works great, I didn't thought about this solution.
@ZahidHasan321 use flushSync in your AuthProvider when you set your new user/session state like in the thread mentionned by @ilia-luk .

I've noticed that the issue was not there in version 1.16.1 of @tanstack/react-router, but it was found in the latest release, version 1.56.1. Could you provide a proper solution or let us know if there is a patch release available?


Using Nanopolish with R9 reads

Hi,
I tried using Nanopolish on my R9 dataset. However, I encounter this error :
HDF5-DIAG: Error detected in HDF5 (1.8.14) thread<PHONE_NUMBER>20704:
#000: H5D.c line 358 in H5Dopen2(): not found
major: Dataset
minor: Object not found
#001: H5Gloc.c line 430 in H5G_loc_find(): can't find object
major: Symbol table
minor: Object not found
#002: H5Gtraverse.c line 861 in H5G_traverse(): internal path traversal failed
major: Symbol table
minor: Object not found
#003: H5Gtraverse.c line 641 in H5G_traverse_real(): traversal operator failed
major: Symbol table
minor: Callback failed
#004: H5Gloc.c line 385 in H5G_loc_find_cb(): object 'Model' doesn't exist
major: Symbol table
minor: Object not found
terminate called after throwing an instance of 'hdf5_tools::Exception'
what():  /Analyses/Basecall_1D_000/BaseCalled_template/Model: error in H5Dopen
I think that it searches for the field  /Analyses/Basecall_1D_000/BaseCalled_template/Model which is not present anymore in R9 fast5 files.

Hi,
R9 support is not public yet but the development version can be found in the branch r9-new-model. You'll also need model files - can you email me at<EMAIL_ADDRESS>to discuss?

Sure, I am going to email you.

R9 version (0.5.0) is live


Improvement: Include some summary info and docs in main README

Is your feature request related to a problem? Please describe.
When landing on the GitHub repo a potential user should be able to get a quick summary of what the tool does, why it's useful, and maybe some simple usage examples.  It's also a good place to put additional documentation such as how to contribute, etc...
Right now the README doesn't tell me much:
AllocationOpt is a library for optimising how an indexer should allocate its stake in [The Graph Protocol](https://thegraph.com/en/). For details, visit our [documentation](https://graphprotocol.github.io/AllocationOpt.jl/dev)

The description raises questions: optimize for what? Is it really a library or also a CLI tool? A user shouldn't have to search elsewhere to find some of this high level information.

Thanks for your feedback @fordN! We've updated the README on the main branch now. Please let us know if you have any further suggestions!
https://github.com/graphprotocol/allocation-optimizer/blob/main/README.md

There hasn't been any response in a while so we will close for now. Feel free to open new issues for further improvements


docs: clarify trailing slash policy regarding 301 redirects

Fixes #15

I may have to do some tests on that one. I'll post back afterwards.
Yes, makes sense I'll add that.


Random Color Generator (rgb color)

I would like to add a mini project in which a random color s generated and it's rgb value is given. I have started my started my web development journey last month and made a small project.
Please assign me this issue under LGMSOC'21 so that I can start working on it.

I would like to add a mini project in which a random color s generated and it's rgb value is given. I have started my started my web development journey last month and made a small project.
Please assign me this issue under LGMSOC'21 so that I can start working on it.

ok assigned you ✔👍


Adding global Lustre filesystem prevents undeploy

Creating a lustrefilesystem.cray.hpe.com resource prevents nnf-deploy undeploy from completing.
$ nnf-deploy deploy
$ kubectl apply -f ./lslide-dm.yaml
lustrefilesystem.cray.hpe.com/kern created

A subsequent undeploy will block indefinitely in lustre-fs-operator.  Removing the finalizer in lustrefilesystem.cray.hpe.com allows it to continue.
Undeploying Module lustre-fs-operator...
  Finding Overlay...
  Running Undeploy...
  <blocked>

You need to ensure that all lustrefilesystems resources, like workflow resources, are all deleted prior to running undeploy. Otherwise, and as you observed, you risk the undeploy becoming stuck.

Duplicate of https://github.com/NearNodeFlash/nnf-deploy/issues/32

Please see the newly added undeploy instructions. If you continue to have issues please re-open the ticket


nil pointer evaluating interface in ranges

.Release contains an nil value when using range in template
Output of helm version: version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:48:33Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.3+k3s1", GitCommit:"61a2aab25eeb97c26fa3f2b177e4355a7654c991", GitTreeState:"clean", BuildDate:"2021-11-04T00:24:35Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): k3s

@k3env Can you provide a example? Thanks very much.

template:
{{- range .Values.values }}
kind: ConfigMap
apiVersion: v1
metadata:
  name: test-{{ .config }}
  namespace: {{ .Release.Namespace }}
data:
  config:  {{ .config }}
  value: {{ .value }}
{{ end -}}

values:
values:
  - config: foo
    value: bar
  - config: abc
    value: def

expected output:
helm template test-chart .
---
# Source: test-chart/templates/config.yaml
kind: ConfigMap
apiVersion: v1
metadata:
  name: test-foo
  namespace: default
data:
  config:  foo
  value: bar

kind: ConfigMap
apiVersion: v1
metadata:
  name: test-abc
  namespace: default
data:
  config:  abc
  value: def

output:
helm template test-chart .
Error: template: test-chart/templates/config.yaml:6:24: executing "test-chart/templates/config.yaml" at <.Release.Namespace>: nil pointer evaluating interface {}.Namespace

@k3env  In the range statement, the scope of . is changed. You should assign the global . to the variable outside the range statement, and then refer to it.

Thanks for the explanation.
I used {{ $.Release.Namespace }} instead of {{ .Release.Namespace }} and it worked.
Didn't pay attention to this section https://helm.sh/docs/chart_template_guide/control_structures/
where it says directly that $ is a pointer to the root scope

Thanks, @k3env !! It works for me.  Same problem. <3

Didn't worked.
at <$.mdnsOverlay.replicas>: nil pointer evaluating interface {}.replicas

@yxxhero I followed the comment made by @k3env, but I still get the same error, as also reported a week ago by @kkashyap1707.
Error: template: .../deployment.yaml:3:8: executing ".../deployment.yaml" at <include "named.template" .>: error calling include: template: .../_helpers.tpl:6:17: executing "named.template" at <$.Release.Namespace>: nil pointer evaluating interface {}.Namespace
_helpers.tpl
{{- define "named.template" }}
apiVersion: apps/v1
kind: Deployment
metadata:
  name: {{ .config.name | default "def-nam" }}
  namespace: {{ $.Release.Namespace }}
spec:
[trimmed]
---
{{- end }}

deployment.yaml
{{- range .Values.values}}
  {{- include "named.template" . }}
{{- end }}

Error: template: .../deployment.yaml:3:8: executing ".../deployment.yaml" at <include "named.template" .>: error calling include: template: .../_helpers.tpl:6:17: executing "named.template" at <$.Release.Namespace>: nil pointer evaluating interface {}.Namespace

Maybe you need pass all .Values in named template via variable
Look here for solution: https://helm.sh/docs/chart_template_guide/named_templates/#setting-the-scope-of-a-template


Specifying thread affinity at runtime

It's important to specify the thread affinity at runtime for my application. I've locally modified OpenBLAS to expose a function to set the thread affinity (Linux-only) and I'd love to see it upstreamed. In drivers/others/blas_server.c:
void openblas_setaffinity(const cpu_set_t* cpu_set) {
    for (int i = 0; i < blas_num_threads - 1; ++i) {
        pthread_setaffinity_np(blas_threads[i], sizeof(cpu_set_t), cpu_set);
    }
}

I'm happy to submit a PR. Is it sufficient to hide this function behind #if __linux__? Any other comments / suggestions about adding this function?

#if defined(OS_LINUX) && !defined(NO_AFFINITY) I would think... and expose it in cblas.h
ISTR there is a gotoblas_set_affinity already in the code but that is probably just an internal helper to apply the initial affinity mask to a thread.

Thanks for the quick response! Yes, there is a gotoblas_set_affinity and it is internal as you said.
I'm not sure gating on !defined(NO_AFFINITY) is right here. A caller explicitly specifying thread affinity seems independent of whether OpenBLAS sets thread affinities automatically or not (which, AFAICT, is the purpose of NO_AFFINITY).

There are ways to prevent OS scheduler to migrate running processes off the caches. If something is badly sub-optimal there are ways with system tuning that benefits other software outside openblas alike.

Was not sure offhand if all the required code would be compiled with NO_AFFINITY set, but I guess if it already compiled and worked for you, you will be right. (And probably no reason not to provide an entirely optional interface in the library - not everybody will be able to make system-wide changes on their hardware, and not all OS may provide a working, scheduler-based solution.)


errors during cell classification

Hi,
I have a Seurat object named seurat_test
An object of class Seurat
20387 features across 16489 samples within 1 assay
Active assay: RNA (20387 features, 2000 variable features)
 1 dimensional reduction calculated: pca

and a trained scPred object
✓  Prediction variable = CellType
✓  Discriminant features per cell type
✓  Training model(s)
Summary

|Cell type                    |     n| Features|Method    |   ROC|  Sens|  Spec|
|:----------------------------|-----:|--------:|:---------|-----:|-----:|-----:|
|CD14+ Monocyte               |  1458|       50|svmRadial | 0.996| 0.760| 0.994|
|CD19+ B                      |  4184|       50|svmRadial | 0.963| 0.674| 0.998|
|CD34+                        |   141|       50|svmRadial | 0.999| 0.893| 1.000|
|CD4+ T Helper2               |    69|       50|svmRadial | 0.693| 0.000| 1.000|
|CD4+/CD25 T Reg              |  4587|       50|svmRadial | 0.911| 0.321| 0.987|
|CD4+/CD45RA+/CD25- Naive T   |  1392|       50|svmRadial | 0.814| 0.002| 1.000|
|CD4+/CD45RO+ Memory          |  2273|       50|svmRadial | 0.852| 0.086| 0.995|

but when I do scPredict(seurat_test, scpred), I get stuck at the following errors:
●  Matching reference with new dataset...
	 ─ 2000 features present in reference loadings
	 ─ 2000 features shared between reference and new dataset
	 ─ 100% of features in the reference are present in new dataset
●  Aligning new data to reference...
Harmony 1/20
0%   10   20   30   40   50   60   70   80   90   100%
[----|----|----|----|----|----|----|----|----|----|
**************************************************|
Harmony 2/20
0%   10   20   30   40   50   60   70   80   90   100%
[----|----|----|----|----|----|----|----|----|----|
**************************************************|
Harmony 3/20
0%   10   20   30   40   50   60   70   80   90   100%
[----|----|----|----|----|----|----|----|----|----|
**************************************************|
Harmony converged after 3 iterations
●  Classifying cells...
Error in `.rowNamesDF<-`(x, value = value) : invalid 'row.names' length
In addition: Warning message:
In method$prob(modelFit = modelFit, newdata = newdata, submodels = param) :
  kernlab class probability calculations failed; returning NAs

Any suggestion on how to proceed? I generated seurat_test and seurat_train splicing the original dataset using a 4-fold cross-validation method, scPred is a scpred object trained on seurat_train.
Cheers,
Carlo
sessionInfo()
R version 4.0.3 (2020-10-10)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Big Sur 10.16

Matrix products: default
LAPACK: /Library/Frameworks/R.framework/Versions/4.0/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] parallel  stats4    stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
 [1] pbapply_1.4-3               scPred_1.9.0                magrittr_2.0.1              doParallel_1.0.16           iterators_1.0.13
 [6] foreach_1.5.1               SeuratObject_4.0.1          Seurat_4.0.1                SingleCellExperiment_1.12.0 SummarizedExperiment_1.20.0
[11] Biobase_2.50.0              GenomicRanges_1.42.0        GenomeInfoDb_1.26.7         IRanges_2.24.1              S4Vectors_0.28.1
[16] BiocGenerics_0.36.1         MatrixGenerics_1.2.1        matrixStats_0.58.0          forcats_0.5.1               stringr_1.4.0
[21] dplyr_1.0.6                 purrr_0.3.4                 readr_1.4.0                 tidyr_1.1.3                 tibble_3.1.2
[26] ggplot2_3.3.3               tidyverse_1.3.1

loaded via a namespace (and not attached):
  [1] readxl_1.3.1           backports_1.2.1        plyr_1.8.6             igraph_1.2.6           lazyeval_0.2.2         splines_4.0.3
  [7] listenv_0.8.0          scattermore_0.7        digest_0.6.27          htmltools_<IP_ADDRESS>      fansi_0.4.2            tensor_1.5
 [13] cluster_2.1.2          ROCR_1.0-11            recipes_0.1.16         globals_0.14.0         modelr_0.1.8           gower_0.2.2
 [19] spatstat.sparse_2.0-0  colorspace_2.0-1       rvest_1.0.0            ggrepel_0.9.1          haven_2.4.1            xfun_0.23
 [25] RCurl_1.98-1.3         crayon_1.4.1           jsonlite_1.7.2         spatstat.data_2.1-0    survival_3.2-11        zoo_1.8-9
 [31] glue_1.4.2             polyclip_1.10-0        gtable_0.3.0           zlibbioc_1.36.0        XVector_0.30.0         ipred_0.9-11
 [37] leiden_0.3.7           DelayedArray_0.16.3    kernlab_0.9-29         future.apply_1.7.0     abind_1.4-5            scales_1.1.1
 [43] DBI_1.1.1              miniUI_<IP_ADDRESS>         Rcpp_1.0.6             viridisLite_0.4.0      xtable_1.8-4           reticulate_1.20
 [49] spatstat.core_2.1-2    lava_1.6.9             prodlim_2019.11.13     htmlwidgets_1.5.3      httr_1.4.2             RColorBrewer_1.1-2
 [55] ellipsis_0.3.2         ica_1.0-2              pkgconfig_2.0.3        nnet_7.3-16            uwot_0.1.10            dbplyr_2.1.1
 [61] deldir_0.2-10          utf8_1.2.1             caret_6.0-88           tidyselect_1.1.1       rlang_0.4.11           reshape2_1.4.4
 [67] later_1.2.0            munsell_0.5.0          cellranger_1.1.0       tools_4.0.3            cli_2.5.0              generics_0.1.0
 [73] broom_0.7.6            ggridges_0.5.3         fastmap_1.1.0          goftest_1.2-2          ModelMetrics_<IP_ADDRESS>   knitr_1.33
 [79] fs_1.5.0               fitdistrplus_1.1-3     RANN_2.6.1             future_1.21.0          nlme_3.1-152           mime_0.10
 [85] xml2_1.3.2             rstudioapi_0.13        compiler_4.0.3         beeswarm_0.3.1         plotly_4.9.3           png_0.1-7
 [91] spatstat.utils_2.1-0   reprex_2.0.0           stringi_1.6.2          highr_0.9              lattice_0.20-44        Matrix_1.3-3
 [97] vctrs_0.3.8            pillar_1.6.1           lifecycle_1.0.0        spatstat.geom_2.1-0    lmtest_0.9-38          RcppAnnoy_0.0.18
[103] bitops_1.0-7           data.table_1.14.0      cowplot_1.1.1          irlba_2.3.3            httpuv_1.6.1           patchwork_1.1.1
[109] R6_2.5.0               promises_<IP_ADDRESS>       KernSmooth_2.23-20     gridExtra_2.3          vipor_0.4.5            parallelly_1.25.0
[115] codetools_0.2-18       MASS_7.3-54            assertthat_0.2.1       withr_2.4.2            sctransform_0.3.2      GenomeInfoDbData_1.2.4
[121] harmony_1.0            mgcv_1.8-35            hms_1.0.0              grid_4.0.3             rpart_4.1-15           timeDate_3043.102
[127] class_7.3-19           Rtsne_0.15             pROC_<IP_ADDRESS>          shiny_1.6.0            lubridate_1.7.10       tinytex_0.31
[133] ggbeeswarm_0.6.0

Dear reader,
I ran into a similar problem.
Seurat object:

Trained scPred object:

After running SeuratObject <- scPredict(SeuratObject, scPredObject)
I get the following error:

Could you please provide a suggestion on how to continue the scPred script?
Thank you in advance.
Kind regards,
Naomi Karmi

Encountered the same issue.  It seems that a simple solution is to (fork this repository and) comment out those rownames() commands in scPred::scPredict().  Alternatively, it is possible to modify the scPred::scPredict() directly as follows:
scPredict2 <- scPred::scPredict
b <- lapply(body(scPredict2), function(a) {
    gsub("(rownames\\(.*\\) <- .*)(;?\\n?)",
         "message('Try to set the row names.'); try(\\1)\\2", deparse(a))
})
body(scPredict2) <- parse(text = c(do.call(c, b), "}"))
environment(scPredict2) <- environment(scPred::scPredict)
assignInNamespace("scPredict", scPredict2, ns = asNamespace("scPred"))

## example
library(magrittr)
library(Seurat)
#> Attaching SeuratObject
#> Attaching sp
library(scPred)

reference <- scPred::pbmc_1
query <- scPred::pbmc_2
reference <- reference %>%
  NormalizeData() %>%
  FindVariableFeatures() %>%
  ScaleData() %>%
  RunPCA() %>%
  RunUMAP(dims = 1:30)
#> Centering and scaling data matrix
#> PC_ 1
#> Positive:  MALAT1, RPS12, RPL13, RPS18, RPS4X, LTB, IL32, IL7R, EEF1A1, RPL10
#>     NOSIP, RPS2, CD2, CD7, CCR7, CD27, CD69, MAL, TSHZ2, ITM2A
#>     MYC, TRAT1, CD247, FHIT, GZMM, SH3YL1, TXK, AQP3, TESPA1, PIM1
#> Negative:  CST3, FCN1, LYZ, LST1, CSTA, S100A9, SERPINA1, CD68, AIF1, SPI1
#>     CFD, MNDA, S100A8, VCAN, TYROBP, KLF4, CLEC7A, CTSS, PSAP, S100A12
#>     FCER1G, MS4A6A, TYMP, FTL, NCF2, FGL2, CYBB, IFI30, IGSF6, CD14
#> PC_ 2
#> Positive:  NKG7, CST7, GNLY, GZMA, GZMB, FGFBP2, PRF1, CCL5, B2M, CTSW
#>     KLRD1, GZMH, KLRF1, CCL4, HOPX, SPON2, CLIC3, CMC1, KLRB1, GZMM
#>     FCGR3A, IFITM2, TMSB4X, EFHD2, MATK, ITGB2, MYO1F, PFN1, SRGN, CD247
#> Negative:  RPL13, RPS12, RPS18, LTB, RPS2, EEF1A1, RPL10, RPLP1, RPS4X, TPT1
#>     MS4A1, CD79A, HLA-DRA, BANK1, MEF2C, LINC00926, HLA-DQB1, HLA-DQA1, VPREB3, CD79B
#>     NCF1, IL7R, CCR7, BIRC3, TNFRSF13C, MARCH1, RALGPS2, TCL1A, HLA-DMB, CD22
#> PC_ 3
#> Positive:  CD79A, MS4A1, CD79B, HLA-DQA1, CD74, BANK1, HLA-DRA, LINC00926, HLA-DPB1, HLA-DPA1
#>     HLA-DQB1, HLA-DRB1, MEF2C, VPREB3, TCL1A, RALGPS2, HLA-DMB, JCHAIN, BCL11A, HLA-DMA
#>     BLK, TCF4, CD22, ADAM28, SPIB, TNFRSF13C, MARCH1, IGLL5, LINC01781, IRF8
#> Negative:  IL7R, TPT1, NOSIP, RPS12, VIM, IL32, MAL, S100A12, S100A9, S100A8
#>     VCAN, AIF1, ANXA1, TRAT1, RPL13, S100A10, FCN1, CD14, CCR7, CSTA
#>     TSHZ2, LYZ, S100A6, RGCC, RPS4X, RPL10, TNFAIP3, CD2, RBP7, RP11-1143G9.4
#> PC_ 4
#> Positive:  S100A12, VCAN, MS4A6A, S100A8, CD14, MGST1, CD36, RNASE6, RP11-1143G9.4, PLBD1
#>     CXCL8, S100A9, CSF3R, RBP7, GPX1, MNDA, QPCT, LYZ, CLEC4E, ALDH2
#>     LGALS2, CYP1B1, FOLR3, KCTD12, GRN, FPR1, PTPRE, RETN, SERPINF1, RP11-160E2.6
#> Negative:  CDKN1C, HES4, TCF7L2, MS4A7, CKB, SMIM25, VMO1, HMOX1, LYPD2, FCGR3A
#>     CXCL16, ICAM4, SIGLEC10, CSF1R, IFITM3, PILRA, MEG3, LILRA5, LRRC25, ADGRE1
#>     MTSS1, LILRB2, ADGRE2, PECAM1, C1QA, ZNF703, TNFRSF8, IFI30, WARS, SPI1
#> PC_ 5
#> Positive:  SERPINF1, LILRA4, LRRC26, PLD4, PPP1R14B, TPM2, ITM2C, SCN9A, PTCRA, MZB1
#>     SCT, LINC00996, DNASE1L3, CLEC4C, IRF7, UGCG, C1orf186, GAS6, TCF4, LILRB4
#>     RP11-117D22.2, CCDC50, DERL3, MYBL2, JCHAIN, APP, IL3RA, ZFAT, SPIB, IRF8
#> Negative:  MS4A1, CD79A, LINC00926, CD79B, VCAN, S100A12, VPREB3, BANK1, S100A8, FCER2
#>     CD22, ARHGAP24, TNFRSF13C, RALGPS2, LY86, CD14, MNDA, FCRL1, LINC01781, HVCN1
#>     S100A9, BLK, ADAM28, PLBD1, CSF3R, RP11-1143G9.4, CD24, CLEC4E, RBP7, CYP1B1
#> Warning: The default method for RunUMAP has changed from calling Python UMAP via reticulate to the R-native UWOT using the cosine metric
#> To use Python UMAP via reticulate, set umap.method to 'umap-learn' and metric to 'correlation'
#> This message will be shown once per session
#> 22:58:36 UMAP embedding parameters a = 0.9922 b = 1.112
#> 22:58:36 Read 3500 rows and found 30 numeric columns
#> 22:58:36 Using Annoy for neighbor search, n_neighbors = 30
#> 22:58:36 Building Annoy index with metric = cosine, n_trees = 50
#> 0%   10   20   30   40   50   60   70   80   90   100%
#> [----|----|----|----|----|----|----|----|----|----|
#> **************************************************|
#> 22:58:36 Writing NN index file to temp file /var/folders/qk/8d34qqss0538pp8mm6y8g0840000gn/T//RtmpC4AaeV/file37c178ef3c10
#> 22:58:36 Searching Annoy index using 1 thread, search_k = 3000
#> 22:58:37 Annoy recall = 100%
#> 22:58:37 Commencing smooth kNN distance calibration using 1 thread
#> 22:58:37 Initializing from normalized Laplacian + noise
#> 22:58:38 Commencing optimization for 500 epochs, with 158046 positive edges
#> 22:58:43 Optimization finished
reference <- getFeatureSpace(reference, "cell_type")
#> ●  Extracting feature space for each cell type...
#> DONE!
reference <- trainModel(reference)
#> ●  Training models for each cell type...
#> Loading required package: ggplot2
#> Loading required package: lattice
#> maximum number of iterations reached 0.0001163544 -0.0001154305DONE!
query <- NormalizeData(query)
query <- scPredict(query, reference)
#> ●  Matching reference with new dataset...
#>   ─ 2000 features present in reference loadings
#>   ─ 2000 features shared between reference and new dataset
#>   ─ 100% of features in the reference are present in new dataset
#> ●  Aligning new data to reference...
#> Harmony 1/20
#> Harmony 2/20
#> Harmony 3/20
#> Harmony 4/20
#> Harmony 5/20
#> Harmony 6/20
#> Harmony 7/20
#> Harmony 8/20
#> Harmony 9/20
#> Harmony 10/20
#> Harmony converged after 10 iterations
#> ●  Classifying cells...
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> Try to set the row names.
#> DONE!
crossTab(query, "cell_type", "scpred_prediction")
#>             B cell CD4 T cell CD8 T cell cDC cMono ncMono NK cell pDC
#> B cell         250          0          0   0     3      0       0   0
#> CD4 T cell       0       1178         25   0     3      0       0   0
#> CD8 T cell       0         47        602   0     1      0      39   0
#> cDC              0          0          0  20    14      0       0   1
#> cMono            0          0          0   0   281      0       0   0
#> ncMono           0          1          0   0     1    119       0   0
#> NK cell          0          0         11   0     0      0     230   0
#> pDC              0          0          0   0     0      0       0  11
#> Plasma cell      0          0          0   0     0      0       0   0
#> unassigned       0         12         38   0   106      0       1   0
#>             Plasma cell
#> B cell                0
#> CD4 T cell            0
#> CD8 T cell            0
#> cDC                   0
#> cMono                 0
#> ncMono                0
#> NK cell               0
#> pDC                   0
#> Plasma cell           6
#> unassigned            0

Created on 2022-06-05 by the reprex package (v2.0.1)
Notice that I added the message "Try to set the row names." on purpose to confirm that the function scPred::predict() had been modified to set the row names optionally.

Hi Naomi,
Looking at the Celltypes, I think I am using the same dataset as a reference. Were you able to solve this issue yet, as the fork suggestion is not working for me.
Best,
IJsbrand


No Salt in User Password Hash

The password hash value for 2 different users with the same password have the same hash values. This indicates that there is no per user salt employed. This is confirmed by the lack of a Salt filed in the table AspNetUsers.
The source code for the hash is designed to use unique salts, but this is not being used.

Salts are directly combined in the hash, added a test just to be sure 3321adbe640d846913be19f82b5a51cba8c0642e


Deployment to OTP fails if server name field has a dash character

 Issue by landonreed
Tuesday Mar 06, 2018 at 20:16 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/issues/66

This may also be the case for other special characters in the name field.

 Comment by landonreed
Tuesday Nov 13, 2018 at 18:17 GMT

This has been fixed, but future enhancements to deployments will replace the use of the server name with unique identifiers.


Force Bitcode When Building

Enabling bitcode in Xcode only adds the -fembed-bitcode-marker flag, which doesn't actually create bitcode. The Archive action transforms that flag to -fembed-bitcode which actually creates the bitcode. Adding the User-Defined Setting BITCODE_GENERATION_MODE=bitcode forces bitcode to be created without archiving.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I added some pertinent comments about this in issue #321


⚠ Secret Website 3 has degraded performance

In a523a52, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3317 ms

Resolved: Secret Website 3 performance has improved in f6ed5a4.


Flexibility of the grid

Hey Ben, thanks for a great library.
We are using it in our startup. But we are facing some issues with the options and could not find best settings to fit our desired behaviour.
We have 2 root problems.

When we set a really small number for column width and row height and high number for max columns with auto resizing we get weird behaviour when dragging/resizing. Random widgets get randomly moved around the grid. Here is the settings: http://prntscr.com/b9vnbu interaction is also slow. We want small size for "cell"s, to be very flexible in terms of granularity. I can't really understand what's going under the hood, any hint would be helpful.
Is it possible to set minimum/maximum item size (col, row) per grid item?

Would be really great to get your feedback.
Thanks,
Tigran

Hi,
On top of what was mentioned by Tigran we would also like to implement some responsiveness into the grid without letting columns grow and shrink (we would prefer keeping column width fixed) but rather pushing everything that doesn't fit into one row into the next one and restoring everything to its original row when window is resized back to original dimensions.
It could be great if we could collaborate on these features. This is the final step to launch our dashboard app and we would prefer improving this library rather than transforming https://github.com/ManifestWebDesign/angular-gridster to angular 2.
We would really appreciate if you could give us some feedback in the short term.
Best regards,
Jorge

Hey guys,

What kind of weird behaviour are you finding with the drag resize? I'll have a play and see if I can figure out what exactly is causing the issue.

Not as yet, no. I'm happy to open a new issue for that as a feature request, though!

 So when you resize the page, items stay fixed size but re-arrange based upon the remaining space. There's a discussion there to be had about how items cascade/re-arrange themselves. I'm guessing you'd expect:

| 1 | 2 | 3 | 4 |
| 5 | 6 | 7 | 8 |

To become:
| 1 | 2 | 3 |
| 4 | 5 | 6 |
| 7 | 8 |

At the moment it would probably become:
| 1 | 2 | 3 |
| 5 | 6 | 4 |
        | 6 |
        | 8 |

Which is probably not what you want.... I have an open issue for adjusting how the cascade works (see #87) which this will probably link nicely to.
Getting it to go back to the previous positions would also take some thought. It's not as simple as just enumerating the items and managing positions based upon that, because gaps... Hmmm more thought required... Does gridster already handle this?

Hi Ben,
Many thanks for your quick reply.
Let me first show you the dashboarding app that we are working on:  http://prnt.sc/ba21qp We want to allow users to add the widgets that they desire and to be able to share their dashboard with others. We need to be able to relocate and resize widgets since we would like avoid having empty spaces.

We are aiming for big widgets as shown in the screenshot with increments as small as the cell size squared in red referenced there. The reason why we aim at this is because for table based widgets we can't go below the size shown in the screenshot, as that's as small as their rows can get. Since the number of rows depend on other settings (i.e. number of users) and we want to be able to avoid white spaces we would like to be able to resize other widget by multiples of that cell size. As for the weird behavior I will let Tigran elaborate on this.

This would be great as I said above some of our widgets can go beyond a certain minimum size.

It think that for our app this is the crux of usability. Think on what happens in this screencast https://giphy.com/gifs/xT8qB5N3Sc4n0TY6zu/fullscreen A user has created a nice compact dashboard resizing and aligning all widgets but suddenly he resizes the window and all sizes and locations are lost event when he restores the original window size. So I think two things are needed here: Defining a maximum column width (even when elements are pushed into the next line we might not want them to grow) and responsive relocation working in the following way:

a)  User creates dashboard to fit his default screen size ("_" represents width of widget and empty spaces out of widget. "{}" represents window viewport size):
{|_1_|_2_|__3__|__4__|}
{|_5_|__6__|__7__|_8_|}

b) When screen size is reduced everything is rearranged in the following line as much as they fit, occupying more lines as needed (but without growing their size by implementing maximum_column_width):
{|_1_|_2_|__3__|_}
{|__4__||_5_|____}
{|__6__|__7__|___}
{|_8_|___________}

c) As the window is resized back all widgets would be restored to their original position:
{|_1_|_2_|__3__|__4__|}
{|_5_|__6__|__7__|_8_|}

d) Making the window bigger than original design size would have any effect except for having more empty space:
{|_1_|_2_|__3__|__4__|______}
{|_5_|__6__|__7__|_8_|______}

As for gridster this seemed to work almost fine yesterday when we tried the latest version of angular-gridster. By the way, as for rows_height we didn't encounter these issues as we are planning on assigning max_rows=0 for infinite vertical scrolling.
Do you think implementing these features in angular2-grid would be possible? As you see we are a very active team and would love collaborating with you, but our deadlines are very tight now.

OK, I think I've figured out the weird behaviour. Was an issue with calculating the sizes within the grid items and how it checks against the minimums. That's fixed. I'll look into the speed issue, but I think that's due to the internal representation of this grid, especially at such small row/column sizes. I'll look into the other issues first, if that's ok with yourselves? Figure they're more urgent to you right now.

#90

OK, so I think there's a change of wording required on the demo. "Minimum Column Width" should be "Minimum Item Width" (and the same with height) which is why when the screen gets small, the items all resize. Also, in both of your configurations, you seem to be using the max columns value which auto updates the column width when you resize. From what you've described you definitely don't want that to be set.  As I write this I realise you probably already figured that out, but just in case I'll leave it here :P

That is about what I expected. I would say that it is possible, but as to how long it will take, well I'm not good at estimates :P I need to figure out how it will handle different cases such as
|_1_|___|_2_|
|_3_|_4_|_5_|

should it go to:
|_1_|_2_|
|_3_|_4_|
|_5_|___

or
|_1_|___
|_2_|_3_|
|_4_|_5_|

and the bit I have to get my head round is how to convert the regular row/column state to the collapsed state. I'm thinking the best way is just to store a "current position" and a "configured position" and... actually that might not be too difficult... I'll keep you posted...

Hey Ben, many thanks for your reply, you are awesome, it’s a pleasure working with you!

Excellent, Tigran will test this and give you some feedback. Agree with regard to speed, let’s look at that once the other issues are solved.

Thanks for creating #90. Count on us for the testing.

As for “max_columns” and “auto-resize” we are aware about the undesired auto-updating behavior but the problem is that with those off when the window is resized we get a horizontal scroll-bar which would also like to avoid. It seems like the solution is enabling a third mechanism intermediate to these two, which would work basically as we have discussed here: dynamically pushing widgets into the next row and recovering them as window is resized.

As for the last scenario that you mentioned:
|_1_|___|_2_|
|_3_|_4_|_5_|

My bet is that it should be handled as:
|_1_|___
|_2_|_3_|
|_4_|_5_|

Since apparently the user had good reasons to include an space between 1 and 2 I think we should not do “magic” removing those spaces. I think it should work as a conveyor belt, pushing into the next line what doesn’t fit into the current one.
Regarding the way to implement it I also think maintaining two positions is optimal. “Configured position” would the position defined by the dashboard designer for his viewport size, while “Current position” would be the position dependent on viewport size. If current viewport size is equal or bigger than the one the dashboard was designed for then current_position=configured_position, if current viewport is smaller current_position would be calculated as per the overflow algorithm described above.
Please let us know what you think and how we can help keeping this moving forward.

That's pretty much what I figured, on both counts (you knowing about the config and how to handle the gaps). If you can think of any other edge cases that might be worth considering, even better!
I probably won't bother with storing the viewport, it can be figured out by looking at the row/column config set. I think I've got enough to get started. I'll keep you guys posted :+1:

The only other edge case I can think of right now is when widget is bigger than the viewport size. I think that in that case our overflow algorithm would try to accommodate pushing one widget per row but would still show a horizontal scroll provided that the widget can not be resized (if auto_resize=off) neither broken into pieces.
Many thanks again Ben for all your support. We look forward to hearing from you in the following days.

Hey Ben,
I've tested the 1) point. So far so good, your fix works. I can't reproduce the issue.
Also I've opened up 2 other PR fixes, which we were used in our project. Please take a look and tell me what you think.
Btw, how are you doing with other issues? We are almost ready to kick-off live our app except for this. Any update would be appreciated

Many thanks Ben, that would be great if you could address points 2 and 3 this weekend, that would mean we could launch our Beta release by Wednesday-Thursday. We will be online polishing other things, feel free to ping us for doing the testing.

OK, I've sorted min/max cols/rows for items and started on the framework for point 3. If I don't manage to sort the page shrinking stuff this weekend, at least you have a framework to kick off from!
Anywho, I had another couple of scenarios to run by you guys:
{|_1_|___2___|_3_|}

Should it go to:
{|_1_|_____}
{|___2___|_}
{|_3_|_____}

or:
{|_1_|_|_3_|}
{|___2___|__}

Also, this situation could be troublesome:
{|_1_|___|_2_|}
{|_3_|___|_4_|}

Should it be:
{|_1_|_2_|}
{|_3_|_4_|}

or
{|_1_|____}
{|_2_|____}
{|_3_|____}
{|_4_|____}

We can't put anything in the gaps or it will be cascaded ending up with:
{|_1_|_3_|}
{|_2_|____}
{|_4_|____}

Hi Ben, I show you implemented #90, that's really great news for us. Thank you!
As for you scenarios above we must assume that the grid owner has designed it to look optimal at a certain minimum viewport size and he has some reasons to include all those empty spaces in between items (|___|). Although knowing those reasons would lead us towards one option or another on how to display in smaller viewports, the problem is that the grid doesn't know those reasons and hence we have to give a single solution for all the possible range of grid owner reasonings.
Based on this I would opt for implementing the most simplistic approach possible, let's call it "simple conveyor belt". In this approach all items and spaces would be maintained as they were initially designed but they would be pushed into the next line as the viewport shrinks. The effect would be very similar to what happens with a resizeable text area like this if we were to consider words as widgets http://www.w3schools.com/cssref/tryit.asp?filename=trycss3_resize
So back to your scenarios this is what I would chose using the "simple conveyor belt" approach.
For the first one it would result in you proposal a:
{|_1_|_____}
{|___2___|_}
{|_3_|_____}

For the second one it would result in you proposal b:
{|_1_|____}
{|_2_|____}
{|_3_|____}
{|_4_|____}

Again under this option I am assuming that the grid designer has his reasons to include those gaps and hence we shouldn't  just remove them. But there is a second option which we could call "condensed conveyor belt" that follows the same principle as above but removing all empty spaces when viewport width is smaller than original width. Under this option I would say that your firs scenario should still result into proposal a (there are empty spaces shown but just because no widget fits in those empty spaces):
{|_1_|_____}
{|___2___|_}
{|_3_|_____}

While the second scenario would now result into your proposal a (empty spaces are used to fit the next widget in the conveyor belt):
{|_1_|_2_|}
{|_3_|_4_|}

I think both "simple conveyor belt" and "condensed conveyor belt" are valid and I would leave to you to decide which one is best.
Just one more note:

If a single item is wider than the available viewport width then we have no option other than showing horizontal scroll.
If an empty space is wider that the available viewport width then under the "simple conveyor belt approach" my choice would be to simply crop the empty space. I would't create a horizontal scroll just to scroll through empty space and I would break the empty space in two so that it occupied two lines in the grid.

Hope this helps, feel free to bounce off any other questions that you come across.

OK, I've gone for the second method because it's just easier. Everything will just get squashed in where possible (basically...). It's currently live on my demo page, feel free to give it a go. Let me know any bugs you find ASAP and I'll try and fix them before your launch (no promises there though, I'm afraid). It still doesn't limit where items can be dropped at the moment. That's the next item on the list, but hopefully this will be enough to get you started.

Hi Ben, I've seen your implementation and this is precisely what we were aiming for! Thank you very much, you really rock!
Apart from dropping order as mentioned in you comment (|1|__|2|3| being compressed as |1|3|2|) I see a few other issues that I will document later. Let me focus here on a couple of them which I think are critical:

In order to get the desired "conveyor belt" effect with we must configure the following settings:

Auto-resize = false
Limit-to-screen = true
Max-columns = different from 0 in order not to have an unlimited canvas

It works fine when column-width is larger than minimum-item-width (well, almost fine as it seems to allow to cut a bit off the last item: this http://prntscr.com/bcvsih results into this http://prntscr.com/bcvstb cuttting number 6 and showing a horizontal scroll bar) but if I design an scenario with minimum-item-width larger to column-width in order to have high granularity for size increments I don't manage to
control when limit-to-screen is going to kick in.
Example of grid design http://prntscr.com/bcvw7r and what happens when resizing http://prntscr.com/bcvwnc

The second issue that I see is when the mobile layout is kicked-in like in this example http://prntscr.com/bcvx3z as items get resized despite of having auto-resize=false. Under this situation I would expect items being pushed to as many lines as needed and complying with their sizing even if a horizontal bar has to be shown to scroll through their entire width.

Hopefully fixing just these two will enable us launching Beta. Thanks once again Ben!

As per 1) point I think it is not relevant anymore. Since minimums are achieved by minCols and minRows per widget. We just don't need to set min_height and min_width.

Responsiveness still a question for me. I don't understand how the limit_to_screen works, but I do think it also tries to eliminate vertical scroll? Because I had 2 lines, reduced window vertically and the items moved above, which created horizontal scroll.

Hi Tigran,
Did you check point 1) using minCols and minRows per widget? Did it work fine? My fear is that it will behave in the same way I described above (unfortunately I can't test this in the demo page).
As per your point 2) I think that limit_to_screen is mainly about trying to eliminate horizontal scrolls whenever possible (it is only not possible when the width for a single grid item is wider than the viewport width) so what you describe shouldn't happen.
Let's hope that Ben can take a look at my two issues above plus this new second issue that you mention.

The first point 2) The mobile layout is supposed to ignore sizes/layouts completely. The fact it's not, I'll need to look at... It's an optional CSS file so you probably don't have it, no worries :p
I'll look into the other issues. Note: you don't need to set a max columns value. Limit to screen will keep them within the bounds of the screen now.

Hello Ben, thanks for you work during the last weeks. The grid works much better for us now, specially after the performance improvement done as part of #102. We are now almost ready for a Beta public release of Kaizana.com, but there are however some grid issues that we would like to bounce off to see if you could finetune during the next days.Your help will be very very much appreciated.

When using limit-to-screen there is the case that an item can be resized outside of the viewport borders. In this screenshot you see that we can resize but not place that same widget in the space (item shoudn't be placeable but it shouldn't be resizable beyond the viewport size either) https://giphy.com/gifs/l46CBLcnzHd8wATv2

The desired conveyor effect works almost OK except when it fails. Pay attention to the blue "Keep Calm" item in this screenshot. On the first resize it recovers it position but it doesn't do so in the second one. https://giphy.com/gifs/xT8qBuU4z18J0N6HKg

When the viewport is small enough our whole grid gets broken with items overlapping and growing out of their size. https://giphy.com/gifs/xT8qBngR6XHBIv26Ag

When adding new items to the grid we would like to position them at the bottom of the grid, instead there are automatically added at the top pushing down whatever content we have there https://giphy.com/gifs/xT8qAY3sgAShHHsvQY We have tried setting prefer_new: false, but when done so the grid gets unresponsive.

There is an slight issue when resizing items below their minimum size. I don't know if you can appreciate in the following screencast but as the item border is pulled in the content temporarily outgrows its borders until the mouse is released an the item size is restored to its minimum https://giphy.com/gifs/3o72ETLSgImrUp8niU

Hey Jorge, apologies for taking a while to respond. I don't have as much time as I'd like to work on this, so sorry about that.
RE: 1 and 2, I'm currently working on a better implementation of the conveyor which will help to deal with these issues.

It looks like the overlap/grow is due to the content of your item. If you set overflow: hidden on the item, it should prevent that, though, I can't say why your items are being expanded like that internally. The size of the items shouldn't be (and don't look to be) changing. Feel free to inspect using dev tools and let me know if they are.

Yes, if prefer_new is set to true and you add an item with {col: 1, row: 1} it will take that spot. I'll look into the prefer_new: false issue, but I think that's what you'll want.

Again, if you disable overflow it will fix that issue. The minWidth and minHeight properties prevent dragging below a certain item size, which I imagine you'll want to be able to set per item, similar to the minCol/minRow. I can look into adding that as well.

Thanks for sticking with me, I'll try and get to the above this weekend. Any more issues, please do let me know.

OK, I have updated the limit grid function and made it use a bin packing-style algo. In all of my (admittedly limited) tests it does the job, better than before. Give it a go and see if it fixes your problems :)

Thanks Ben, we're going give a try to your new version. Were you also able to look into issues related overflow:hidden, prefer_new:false and being able to set minWidth / minRow per item?

Hi Ben, we tested it and it is working much better now. We also see that prefer_new:false is working well now. Let me just recap the issues that we see pending:

There is one scenario in which the grid doesn't recover it original design after resizing. I think it is related to having a tall item in the middle of a row (not at the end of the row which works well) Take a look at items 3 and 4 in this gif https://giphy.com/gifs/l41YuEFVxdS1Lmtqw

Being able to set minWidth / minRow per item would solve our overflow problems.

By the way, we also noted that for the limit-to-screen setting to work well Cascade Direction can't be set to "off". We changed it to "up" with no problem, but just for you to know.

Yes, at the moment limit to grid only works with cascade up. For the time being I have no intention to changing that because getting it work as it does know has caused me much headache and I have other things I want to be doing :P
I never encountered any issues with prefer_new: false so I don't know what was going on there.
Will keep you updated on the other bits

Whoops, nice little logic mistake there! Should be fixed now, and I've added minWidth/minHeight in for you too. Give it a go and hopefully we're good!

Excellent, it works almost to perfection now. After extensive testing I found that in all cases all items recovered their original grid position :-) I just found a case in which items will leave some weird empty space when resizing. Take a look at item number 4 in this gif https://giphy.com/gifs/3o6gE6vPNmV71P5Zkc
We'll also test minWidth/minHeight and will let you now.
Finally I have an open question. When should the new grid configuration be considered as new target? We have two options:

Right now when viewport is resized all elements are considered fluid and recover their initial position when viewport is resized back, except for those elements that are repositioned by the user. For those repositioned items the dashboard considers them as new target positions and hence won't recover their initial position, but the other untouched items will recover their position resulting in a kind of mixed situation.
An alternative would be considering that if the user repositions at least one item his real intention is to design a new whole target dashboard and hence we should consider all the new item positions as new target, so we shouldn't recover any other position for any item beyond this dashboard design.

I am in favor for the logic of scenario 2, mainly due to the fact that most always if you reposition a single item, trying to recover the original dashboard design as per scenario 1 will result in a mix of old and new positions that won't make sense. At least in scenario 2 you know that if you adjust something this whole dashboard is your new target and you get something that still makes sense. What do you think?

Cool, thanks for that. Fix is pushed now. Will be live on the demo site ASAP (currently writing this on a train).
At the moment it's probably closer to the first scenario. What will happen at the moment is that the moved/resized item and any items that get cascaded because of the move will be saved to there too. Unfortunately, at the moment the cascade effect saves when it happens, which means if you move an item, other items reshuffle, and then you put the first item back, they will all be saved with the new positions. Does that make sense? To change to scenario 2, it'd just be a case of updating the saved positions of the items on drag/resize stop if that's the optimal solution? I could probably do it with a new config option saveAllOnDragStop which effectively toggles between the two options, but would have very little effect on the general running of the grid. I'll wait to hear from you guys on that one.

Yes, I think that the fact that moving an item does affect other cascaded items but not the items above, which will be the only ones returning to their original position upon resizing, is producing a nonsense dashboard result.
What I have experienced with my test users is that when decreasing the window size and experiencing the result of limit-to-screen they feel tempted to adjust a widget here or there, but this has terrible consequences when dashboard is restore to original image. This may also happen accidentally, and I might even have to consider including a switch in the dashboard settings so that users disable accidental item re-positioning.
In any of the cases I do consider that scenario 2 is best for users. If you are considering doing it with a config option that's even better, although I can't honestly think of any use case in which scenario 1 would be preferred. As for your comment below I don't really get how you are intending to implement it

To change to scenario 2, it'd just be a case of updating the saved positions of the items on drag/resize stop if that's the optimal solution?

but I think you got it, the idea is that upon resizing/moving at least one of the items, all the other items would save their position as if this was the new target position selected by the user for every single one of them. This means that further increasing the viewport width wouldn't result in any item movement, while reducing it would result in the expected conveyor belt effect.

Hi Ben, just checking in how everything is going. I am aiming for a beta release this week, do you have availability to solve the point above plus two new issues that were discovered? Let me do a summary:

When limit-to-screen is enabled, adjusting a single item should result in the whole grid design being saved as described in my last comment above.
When limit-to-screen is enabled, the conveyor belt effect (items moving from one line to the next when there's not enough viewport width) is not kicking in upon first dashboard load, meaning it doesn't work unless window is resized: https://giphy.com/gifs/l46ClSwy862vg2dOw
Sometimes my grid doesn't maintain it desired design after reloading. Take a look at the two top left items and the chart just below them https://giphy.com/gifs/3o6Zt9BlQScsUiDlw4

I would be great having your feedback. Thanks!

Hello Ben,
We remain using our app with a private group of users but would like to move into public Beta release as soon as these pending issues are solved. Please find all the information about our Kaizana app at http://kaizana.com/ live now for the first time.
Could you help us solving the issues summarized in my last comment above?
Many thanks in advance!


Allow .vue Components (and other) to be imported as StoryblokComponent

Description
As a developer using Storyblok with Astro, but with Vue (and/or Svelte) Frontend Library, I want to be able to write storyblok Components as .vue or .svelte Files. Right now in Astro, when initiliasing storyblok with its Components, these component paths get suffixed with .astro.
Suggested solution or improvement
I would be great to auto-detect the components type by its file suffix. So we could use the full astro potential by being able to use any frontend library and even mix them if needed.
Additional context
No response
Validations

[X] Follow our Code of Conduct

storyblok({
    accessToken: env.STORYBLOK_TOKEN,
    components: {
      page: "storyblok/Page",
      simpleText: "storyblok/SimpleText",
    }
  }),

Currently these paths in components would be prefixed with src/ and suffixed with .astro, leading to the unability to use a storyblok/SimpleText.vue Component

Hey @fiveam-lukas,
thanks for opening the issue. The integration was designed like this on purpose because Vue/Svelte/React/... components would require a client directive.
You can implement such components as shown in the Astro SDK Demo.
I'd be happy to consider a better solution, do you have any suggestions? 🙂
By the way, src folder can be changed using the componentsDir option. 😉

Hey @fiveam-lukas, what do you think?


[Bug]: codec erorr

What happened?

Expected Result

Branch
master/main
What operating systems are you seeing the problem on?
No response
Relevant log output
Everything is installed added key ffmepg ffprobe shaka aria2c but still this erorr

Video files are only 1kb

Other information
No response

Try an older version: https://github.com/Puyodead1/udemy-downloader/commit/4b80e32433dd341a2eaccdd60aa60cb6588b7900

Thanks for reply, issue was ffmepg version or something i added diff versions of ffmepg ffprobe maybe

Thanks for reply, issue was ffmepg version or something i added diff versions of ffmepg ffprobe maybe

Interesting, glad you figured it out 👍🏻

Thanks for reply, issue was ffmepg version or something i added diff versions of ffmepg ffprobe maybe

How did you manage to solve the problem, I facing it right now, you download a new version or what of ffmpef?


Deals does not store into DB the name of a customer

Laravel CRM Version: latest
PHP Version: 8.2

Description:
Deals does not store into DB the name of a customer
Steps To Reproduce:
Create new deal, write customer name... create...

I kinda fixed it. It seems column client_id is missing from migration from create_deals_table....
so from phpmyadmin manualy I added client_id column and it worked.

I cant find the create_laravel_crm_deals_table migration file.

Thanks for reporting, I'll take a look at this. For reference the initial migrations were run in the one file
2023_01_19_045623_create_laravel_crm_tables.php
There is an update migration that adds the client_id to the deals table however. So it is strange the client id was missing from your table.
2023_04_12_071404_add_client_to_laravel_crm_deals_table.php


MRG: Add filtering default

Closes #3239.
Still need to update the background tutorial a bit, plus update whats_new.py.
Sorry in advance for the big diff...

Sorry for the huge diff. CIs are happy other than the recent flake8 stuff fixed in #3456.
This one is ready for a round of review. I'm still fighting with sphinx-gallery to render the docs perfectly, but it's close enough to look at.
Lots of changes, see whats_new.rst for description that is hopefully complete:
https://1891-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/whats_new.html#api
And here are the accompanying updated tutorials, with some rationale:
https://1891-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_background_filtering.html
https://1891-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_artifacts_correction_filtering.html
Here is what the new docstring looks like:
https://1891-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/generated/mne.io.Raw.html#mne.io.Raw.filter
I also added a tutorial that we had a source file for but didn't have in the index:
https://1891-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_modifying_data_inplace.html

Phew, links and table fixed:
https://1893-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_background_filtering.html#some-pitfalls-of-filtering
Now it's actually MRG I think.

[Current coverage][cc-pull] is 52.52% (diff: 67.55%)

Merging [#3449][cc-pull] into [master][cc-base-branch] will decrease coverage by 34.10%

@@             master      #3449   diff @@
==========================================
  Files           339        339
  Lines         58537      58610      +73
  Methods           0          0
  Messages          0          0
  Branches       8911       8885      -26
==========================================
- Hits          50712      30787   -19925
- Misses         5145      25975   +20830
+ Partials       2680       1848     -832

[][cc-pull]

Powered by Codecov. Last update [6957b93...0e47da7][cc-compare]
[cc-base-branch]: https://codecov.io/gh/mne-tools/mne-python/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/mne-tools/mne-python/compare/6957b937e15fab9768c9f0cfd235b549bfceced6...0e47da792336de7c7595d038b6f0ca4188f128ad?src=pr
[cc-pull]: https://codecov.io/gh/mne-tools/mne-python/pull/3449?src=pr

Rebased and CIs are happy

Awesome discussion on the pros, cons, and pitfalls of filtering in its various forms.
Regarding the defaults, I unfortunately don't have time for testing right now, but they seem very reasonable to me.

Thanks for the look @rkmaddox
cc @choldgraf @jona-sassenhagen @dengemann @kingjr you were involved in related issues so feel free to look at the updated defaults and tutorials if you have time

Loving the pitfalls section Eric! Great simulations.

 Will be a great resource for teaching etc. I wonder if there's a way to auto-convert these examples to jupyter notebooks somehow. (not for the MNE docs but for teaching / playing around w/ examples purposes)

that's it for me.
thanks heaps @Eric89GXL for tackling this !

One other thing (and semi-related to all the edits @agramfort is suggesting now) some of the jupyter folks have been working on a linter for prose within markdown. I'm not sure if this works for .py files or not, but might be useful for these kinds of situations (e.g., I think it has a spellchecker) https://github.com/amperser/proselint

@choldgraf - if you scroll down to the bottom of the page you can download the example as a jupyter notebook

Comments addressed in latest commit. @agramfort I found we can fix the ref thing locally with a CSS fix (implemented):
https://1977-1301584-gh.circle-artifacts.com/0//home/ubuntu/mne-python/doc/_build/html/auto_tutorials/plot_background_filtering.html#id22
@jona-sassenhagen can you check to make sure you're happy with my treatment of the new ref?
Good to go from my end and the CIs are happy.

@jona-sassenhagen ok to merge?
+1 on my side

Looks good to me, great addition!

thanks @Eric89GXL !


dc-monitor of syncs with qp

make the dc-monitor be qp-aware.

read the qp from the sync infotons
create new dc virtual infotons that accept qp
make sure that the monitor won't mix two different qps from the same dc-id
stucks

on is stuck and one is working - kill the jvm
one is on horizon and there are more infotons on the source that should be synced - don't kill the jvm

@yanpom to test


Help needed

I succesfully downloaded the model as .obj format but I can't open or use them. Plus I don't know what to do with the viewer.txt file, I can't seem to be able to import it to tampermonkey. Am I supposed to export it to a different format ? Sorry I'm very bad at coding stuff : (

@Khuengoan don't need viewer.txt file . if you want open .obj format file . you need software like autodesk maya 。

@Khuengoan don't need viewer.txt file . if you want open .obj format file . you need software like autodesk maya 。

ah I figured out that the model I downloaded has a bunch of decoy files that display jacked up geometry or unable to open. Thanks for helping out.


Cant open albums list

On iOS 11 can't open albums list

This is a known issue in iOS 11, hopefully they'll fix it soon.
But I've released 2.7.1 with a workaround.

I fix it by change in PhotosViewController.swift on line 121 navigationItem.titleView = albumTitleView

Or you could update to 2.7.1 which puts the button directly in the title view :)


improve diff abund api

depends on https://github.com/microbiomeDB/microbiomeComputations/pull/20
this does a couple things:

introduces a wrapper around microbiomeComputations::differentialAbundance. this wrapper, rather than expecting a Comparator, takes a covariate name and optional predicates for defining groups within that covariate.
adds a wrapper around Maaslin2::Maaslin2 which takes a CollectionWithMetadata object, grabs out of that object what it needs in terms of data, and otherwise just passes along whatever arguments maaslin would usually take.
adds a new method DESeqDataSetFromCollection which will take an AbsoluteAbundanceData object and build a DESeqDataSet from it. this can then be used w deseq as one usually would. the method is named as it is in order to align as much as possible w the deseq api, where we already see things like DESeqDataSetFromMatrix.

im considering that getCollection maybe should check to see if all values are ints, and in that case return AbsoluteAbundanceData rather than AbundanceData objects. id appreciate thoughts and opinions there, bc i dont generally like conditionally returning different things from the same method. maybe an arg to override that behavior if desired for some reason? or an arg to turn it on?

diffabund(data, comparator = "hairColor", groupA = ['red', 'blue'], groupB = ['green'])
i wanted to be able to handle continuous vars as well w a single api, and this is where i landed. looking at other tools, there doesnt appear to be any consistency in api for covariates that i can see either.. though ill say using formulas is something deseq supports, and i suppose i was hoping predicates would be no more confusing than that..


No Instrumental In Week 6.

When Playing Week 6, There is no instrumental

For me it was just Senpai and Thorns.

try these options:

check if Inst file is .ogg
check in the chart editor the Mute Instrumental checkmark is active
if it's none of these, try to pick the Inst from the original FNF and drag and drop into the song folder


Update disable-private-endpoint-network-policy.md

Remove trailing slash in code sample

The issue that's addressed in the pull request appears to be addressed in master. We'll close this pull request. If there are outstanding issues or questions, please add a comment or create a new pull request. Thanks, all.


The generated HTML has no style in it.

I really liked your project XLog and inspired me to make my own digital garden as you said, I already tried it but after building the generated html has no style in it, I there is specific step i missed.

Can you provide the steps you followed so I can regenerate the issue on my machine?

I'm Running Windows 11 on my machine.
The steps:

installed xlog go install github.com/emad-elsaid/xlog/cmd/xlog@latest
mkdir msalah-site
xlog
Then type a basic index file
xlog --sitename "Mohamed A. Salah" --build .\msalah_blog_web\
The open index.html in  .\msalah_blog_web\ with firefox

This what looks like.

I see where did it go wrong in this case, I think you opened the file
directly in the browser. but keep in mind that the resources like css/js
are linked in the browser by absolute path
   6   │     <link rel="icon" href="/public/logo.png">
   7   │     <link rel="stylesheet" href="/public/style.css">

so you have to serve the output directory with a web server and visit
localhost:port to load the resources.
the reason this is absolute path because it simplify rendering the page. as
xlog will generate nested pages it's important to refer to the same file.
absolute path makes it easier instead of generating a path relevant to each
generated path ../ ../../../ ..etc.
On Fri, Sep 8, 2023 at 9:40 PM Mohamed A. Salah @.***>
wrote:

I'm Running Windows 11 on my machine.
The steps:

installed xlog go install @.***
mkdir msalah-site
xlog
Then type a basic index file
xlog --sitename "Mohamed A. Salah" --build .\msalah_blog_web\
The open index.html in .\msalah_blog_web\ with firefox

This what looks like.
[image: Screenshot 2023-09-08 at 22-39-42 Mohamed A Salah]
https://user-images.githubusercontent.com/22938158/266714828-ea719b8f-7fe3-4b6c-997e-c268643a55e4.png
—
Reply to this email directly, view it on GitHub
https://github.com/emad-elsaid/xlog/issues/37#issuecomment-1712141456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANJA2IOHKNTS3YTYUTEQTXZNYC5ANCNFSM6AAAAAA4QZV5VM
.
You are receiving this because you commented.Message ID:
@.***>

Okay, I get it now Thanks Emad.


[206eb] Update kustomization images

This Pull request aims to update the kustomization images

/deploy dev

@r00ta this doesn't seem to be working

You have to merge It first

/deploy dev


Exported project with utf8 chars in resource name fails to load scene, works fine in editor

Godot version:
3.1-stable
OS/device including version:
Windows 10 64 bits
Ubuntu 18.04
Issue description:
What happened :
When importing a resource containg utf8 chars in it (like 'é' or 'è'), the scenes using the resources works fine when used in the editor, but when the project is exported, these scenes fail to load.
The error looks like #21524 but the cause is not the same.
What was expected:
Either the scenes fails to load in the editor so it's possible to know before exporting that there is an issue with utf8 file names,
or the scene loads in the exported binary.
Steps to reproduce:

Create a godot project
Import a resource called "carré.png"
Add a sprite to the scene that displays the texture "carré.png"
Launch the project on the editor (it works fine)
Export the project for any platform
Launch the binary (the scene fails to load)

I was unable to reproduce the issue, on Arch (Kernel 4.20.15 64bit). Were you using a 3D or 2D sprite?

For Android, it does not support utf8 file name for assets, buy only ascii.

That's a my bad from me.
When looking back at my projects structure :  the problem seems to be quite different. I modified the name of a file used in a tileset then exported the project.
So the issue is quite different from what i thought.
I'm closing this issue as it is no longer relevant.


Add ci_nmstate role

As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running
[ ] Appropriate documentation exists and/or is up-to-date:

[ ] README in the role
[ ] Content of the docs/source is reflecting the changes

Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/642

recheck

recheck

@marios @cjeanner baremetal ran on this one and passed OK https://review.rdoproject.org/zuul/build/9cdf0425c5c94a6689cd7deaa2f42990

recheck

/retest

/approve

/lgtm


undefined referece to kaldi_io

I have install sherpa done in server, but failed in my computer. Sherpa build lib failed because don't see kaldi_io libriary, But I check it's exist. It's my log. Can you help me to check it? tks.
log_error.txt

Could you try the latest sherpa?

install lastest version fixed it. Tks


Fix popcnt for small integers

Fixes https://github.com/bytecodealliance/wasmtime/issues/3615

Thanks! Can you add some run-tests too?

Done. Also made the existing aarch64 popcnt tests run on x86_64.

Would it be possible to get a patch release with https://github.com/bytecodealliance/wasmtime/pull/3610, this PR and maybe https://github.com/bytecodealliance/wasmtime/pull/3619? #3610 and this PR fix a miscompilation and I switched cg_clif back to crates.io releases after feedback from my PR to distribute cg_clif as rustup component on nightly.

Would it be possible to get a patch release

Yes, I think actual miscompilation merits this (for clarity to others, Wasm is not affected, just 8/16-bit types). I'll give our new semi-automated patch release process a try; right now this implies a patch release of Wasmtime as well, which will be a no-op, and we need a better story for just patching Cranelift in the future, but this will do. If there's some unexpected issue and I can't get it out in reasonable time today then the next major release on Jan 5 will include all the changes.


Build fails with latest dmd toolchain

$ dub build
Fetching io 0.2.2 (getting selected version)...
Fetching darg 0.1.0 (getting selected version)...
Performing "debug" build using dmd for x86_64.
darg 0.1.0: building configuration "library"...
io 0.2.2: building configuration "library"...
button 0.1.2+commit.6.gde3f6e8: building configuration "application"...
source/button/cli/build.d(15,8): Error: module `text` is in file 'io/text.d' which cannot be read
import path[0] = source/
import path[1] = /mnt/1/home/hsteoh/.dub/packages/darg-0.1.0/darg/source/
import path[2] = /mnt/1/home/hsteoh/.dub/packages/io-0.2.2/io/src/
import path[3] = /usr/src/d/druntime/import
import path[4] = /usr/src/d/druntime/src
import path[5] = /usr/src/d/phobos
dmd failed with exit code 1.

Thanks for the prompt response!


travis: bump Elasticsearch versions

Bump Elasticsearch version as requested in inveniosoftware/invenio#3961.

closing this, no use for travis anymore 😅


{Core} Expose public interface for SecretStore

Description
Expose public interface for using encrypted SecretStore so that command modules or extensions (such as https://github.com/calvinsID/azure-cli-extensions/pull/97) can leverage msal-extensions to save custom data such as tokens.
Testing Guide
On Windows:
> az demo secret-store save "name=Johann Sebastian Bach" job=musician
Data written to C:\Users\username\.azure\secret_store_demo.bin: {'name': 'Johann Sebastian Bach', 'job': 'musician'}

> az demo secret-store load
{
  "job": "musician",
  "name": "Johann Sebastian Bach"
}

Turn off token encryption:
> az config set core.encrypt_token_cache=False

> az demo secret-store save "name=Johann Sebastian Bach" job=musician
Data written to C:\Users\username\.azure\secret_store_demo.json: {'name': 'Johann Sebastian Bach', 'job': 'musician'}

> az demo secret-store load
{
  "job": "musician",
  "name": "Johann Sebastian Bach"
}

Core

/azp run

@rayluo, CLI is helping msal-extensions have more users! 🤣


Bigquery method to retry failed Job

When starting Bigquery jobs through the API, sometimes a job us unable to finish successfully.
We can see this, by checking the status of a job periodically, until the job has finished.
A nice feature would be, to be able to retry a job if the errormessage implies it is possible.
(400 The job encountered an error during execution. Retrying the job may solve the problem.)
There is currently no public method on the Job class, probably in any of the client libraries
(for python there is a similar feature request, and i've run into the same situation using NodeJS)

Job identifiers are unique, and a job cannot be retried using the same ID.  It's also difficult to reason about idempotence from an automatic retry perspective when we're talking about jobs.  We can do things like specify jobId to ensure idempotent behavior on jobs.insert in the library, but execution failures for the asynchronous job execution are more challenging.
Can we ensure it's easy to copy the job configuration out of a historical job, so that users who have identified places where a job needs to be retried can reuse the configuration to define the new job?

@shollyman that would be helpful for me. I have separate job launching and collecting threads and only pass the Job ID along via a Queue. Copying the failed job into a new request would make the suggestion in that error message a lot more reasonable.

After some investigation, accomplishing this with the current client is possible, but rather clunky. I'm planning to add a new method, BigQueryClient::duplicateJob() or similar, which will accept a Job or job ID and create an identically configured JobConfigurationInterface instance which you can use to run the job again.

@jdpedrie Is this still in the works?

We have decided not to do this in order to keep this consistent with the other clients (currently, only Python does this; most of the BigQuery clients do not). cc: @shollyman


Review How to Document using mkdocs

[x] Review how mkdocs is used to document current documentation
[x] Follow tutorials / Research mkdocs
[x] Do a sample tutorial

Hey team! Please add your planning poker estimate with Zenhub @ChelseaChX @ShahFragcolor @sinkingsugar

I can help with that if you have any questions since I wrote the CI script that builds the doc and the website.

I can help with that if you have any questions since I wrote the CI script that builds the doc and the website.

Noted with thanks!

Sample tutorial is done, but still needs polishing and converting to markdown.