MAINT: construct csr and csc matrices from integer lists

closes https://github.com/scipy/scipy/issues/5353

self-merging like a caveman

you've got so many open PRs that you're probably entitled to this one....
Anyway, LGTM.


TextField Component from docs is crashing

Description
The docs about Componentization shows a TextField component, which when copied as is, results in the following error:
TypeError: Cannot read properties of undefined (reading 'toString')

Furthermore, inspecting the code with an IDE, shows a longer typescript error on the {form} prop:
Type '{ subscribe: (this: void, run: Subscriber<{ email: string; password: string; }>, invalidate?: Invalidator<{ email: string; password: string; }> | undefined) => Unsubscriber; set(this: void, value: { ...; }, options?: { ...; } | undefined): void; update(this: void, updater: Updater<...>, options?: { ...; } | undefine...' is missing the following properties from type 'SuperForm<ZodValidation<AnyZodObject>, unknown>': form, formId, errors, constraints, and 14 more.ts(2740)

If applicable, a MRE
Here is a stackblitz example to reproduce the issue:
https://stackblitz.com/edit/vitest-dev-vitest-xqw4v1?file=src%2Froutes%2FLoginForm.svelte

You haven't followed all the instructions, the form prop for TextField takes the whole SuperForm, not the form store inside its object. And the other prop is called field, not name.
With these changes, everything works: https://stackblitz.com/edit/vitest-dev-vitest-rj4hhb?file=src%2Froutes%2FTextField.svelte,src%2Froutes%2FLoginForm.svelte

@ciscoheat You're absolutely right, looks like I really need a break. Thanks for your quick help and nice library :)

I know the feeling. :) Glad you like it!


[FLINK-11589][Security] Service provider for security module and context discovery

What is the purpose of the change
This PR refactors SecurityUtils.class in flink-runtime and replace with an extendable module based on the service provider pattern. With this extension, users can {create extendable security modules](https://docs.oracle.com/javase/tutorial/ext/basics/spi.html) with 3rd-party implementations.
Brief change log

Added SecurityFactoryService class for discovering installed SecurityFactory(s) in the classpath.

Extended into SecurityModuleFactory and SecurityContextFactory.

Replace SecurityUtils with SecurityEnvironment class that holds all installed security-related objects.
Replace current security installation process with a 2-step installation - first install security module(s) per user-defined properties, then install security context based on security modules and properties
Refactored current Hadoop/JaaS/Zookeeper modules into extendable class.

Verifying this change
This change is already covered by existing tests in flink-runtime and ITCases in YARN and Kafka modules, also added to the tests:

Modified YARN and Kafka test modules to install modules/context through service provider discovery
Included test module factories and a default security context factory in test path.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes (affects security installation)
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? not yet, awaits review.

closing this


syscall: on ARM-based MacOS, read() is unable to read more than 1024 bytes at once

Go version
go version go1.22.6 darwin/arm64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/USERNAME_REDACTED/Library/Caches/go-build'
GOENV='/Users/USERNAME_REDACTED/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/USERNAME_REDACTED/Developer/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/USERNAME_REDACTED/Developer/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/opt/homebrew/Cellar/go/1.22.6/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.22.6/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.6'
GCCGO='gccgo'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='0'
GOMOD='/Users/USERNAME_REDACTED/Developer/GitBins/PROJECT_REDACTED/src/PROJECT_REDACTED/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/m4/whlp11796rqd17gnlgwz5fpw0000gn/T/go-build594205049=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?
package utils

import (
	"bufio"
	"fmt"
	"os"
	"strings"
)

func ReadUserInputSingleLine(prompt string) (string, error) {
	fmt.Println(prompt)
	reader := bufio.NewReader(os.Stdin)
	text, err := reader.ReadString('\n')
	if err != nil {
		return "", err
	}
	return strings.TrimSpace(text), nil
}

My computer is running MacOS 14.5 (23F79) with M1 chip.
I tried to receive user input interactively from stdin using the code above.
lsof -p PID returned fd 0 (stdin) is linked to /dev/ttys001.
What did you see happen?
Then when I run the program in iTerm2/Goland terminal:

Input 1024 bytes repeated A, press enter, the program will be no response.
Don't exit, just remove the last A, so the whole input in memory is 1023 bytes A + trailing null byte, press enter, now it works.

According to your builtin library code, this should be available for receiving max 4096 bytes at once, but now it is only 1024 bytes, totally unexpected. I can't determine whether the bug is on Apple side or Golang side.
I tried to set breakpoint on read syscall, then when it is trying to read input, it goes to svc #0x80.
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.2
    frame #0: 0x000000018dbd6dac libsystem_kernel.dylib`read
libsystem_kernel.dylib`read:
->  0x18dbd6dac <+0>:  mov    x16, #0x3
    0x18dbd6db0 <+4>:  svc    #0x80
    0x18dbd6db4 <+8>:  b.lo   0x18dbd6dd4               ; <+40>
    0x18dbd6db8 <+12>: pacibsp
Target 0: (go_build_REDACTED_cmd_REDACTED) stopped.
(lldb) c
Process 10306 resuming

If I compile the same code and run on go1.22.6/Windows/AMD64, this code is working as expected, can receive more than 1024 bytes.
What did you expect to see?
when I run the program in iTerm2/Goland terminal:

Input 1024 bytes repeated A, press enter, the program will continue to run.

Related Issues and Documentation

os: Read() blocking on named pipe despite O_NONBLOCK #66239 (closed)
os: EINTR on Darwin when reading from os.Stdin #22838 (closed)
crypto/rand: rand.Reader.Read is buffered on some systems #45217 (closed)
Partial Line returned from Reader.ReadLine() #28718 (closed)
cmd/compile: fatal error on Mac when caller changes stdout buffering #25170 (closed)
syscall: syscall.Read from syscall.Socketpair lost piece of data #27603 (closed)
bufio: panic in ScanBytes #52351 (closed)
affected/package:  #59923 (closed)
bufio: Scanner.Scan panics on poorly behaved io.Reader during an error #38053 (closed)
bufio: panic: tried to fill full buffer after calling Reset #37347

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

I really love the Dynamic-Wallpaper software. If there were a Windows or Linux version, I would be willing to purchase it for a lifetime.

After I debug, I found first time run into syscall function, and the program did not come out

It helps to show a complete stand-alone program.  Thanks.
The portion you posted looks incorrect.  bufio.NewReader buffers input; that's why it exists.  It will read all the available input into its buffer.  In your ReadUserInputSingleLine function, you are creating a buffer, reading a single line from the buffer, and then discarding anything else that is in the buffer.
I have no particular reason to think that that is the problem here, but without a complete program it's hard to be sure.

It helps to show a complete stand-alone program. Thanks.
The portion you posted looks incorrect. bufio.NewReader buffers input; that's why it exists. It will read all the available input into its buffer. In your ReadUserInputSingleLine function, you are creating a buffer, reading a single line from the buffer, and then discarding anything else that is in the buffer.
I have no particular reason to think that that is the problem here, but without a complete program it's hard to be sure.

Thanks for response. Just call ReadUserInputSingleLine function in main should work.
The problem is its behavior is inconsistent in multiple platforms, for ll platforms should be consistently 4096 bytes buffer. Also, buffer is NOT created on bufio package level, it is used in every read call. And the problem, from my POV, is the underlying syscall, instead of bufio.
If you think screenshot would be helpful, please let me know.

The buffer is created by bufio.NewReader.  That's what the bufio package does.  Your program will behave incorrectly if multiple lines are available on os.Stdin when ReadUserInputSingleLine is called.

Standalone program:
package main

import "REDACTED/utils"
import "fmt"

func main(){
        tokenizer, err := utils.ReadUserInputSingleLine("Tokenizer? ")
	if err != nil {
		panic(err)
	}
        fmt.Println(tokenizer)
}

Then I modified this ReadUserInputSingleLine to use reader := bufio.NewReaderSize(os.Stdin, 1020), then input AAAA(single "A" repeated 1024 times) WITHOUT line break, then press enter, same thing still happened, and still 1023*"A" will get a response from program.
Or to solve the problem in another way, which way do you think would be perfect for such kind of purpose?

Even after I migrate to io.ReadAll() , it's still limited to 1024 bytes, is there any workaround (I believe problem might be on MacOS side)?
func ReadUserInputSingleLine(prompt string) (string, error) {
	fmt.Println(prompt)
	b, err := io.ReadAll(os.Stdin)
	if err != nil {
		log.Println(err)
	}
	lb_loc := bytes.Index(b, []byte("\n"))
	var text string
	if lb_loc != -1 {
		text = string(b)
	} else {
		text = string(b[:lb_loc])
	}
	return strings.TrimSpace(text), nil
}

Test case:

A single line with repeated 1024 times "A", no response from program. Delete last "A", press enter, everything works as normal.
A single line with repeated 512 times "A", repeated three times, means three lines of 512 repeated "A", program is working as normal.

So the limitation is on MacOS side, is it possible for any workaround?

Problem is on tty driver, for MacOS users, try using pipe to solve this problem or add STTY=-icanon environment variable before you run your program.
For more details, check:

https://stackoverflow.com/questions/36990514/fgets-prompt-limited-to-1024-bytes
https://unix.stackexchange.com/questions/204815/terminal-does-not-accept-pasted-or-typed-lines-of-more-than-1024-characters
https://unix.stackexchange.com/questions/131105/how-to-read-over-4k-input-without-new-lines-on-a-terminal


tensorflow 2.0.0b0 ImportError: cannot import name 'Layer'

When I import the tensorflow, it has show the following errors :
(tensorflow 2.0.0b0)

import tensorflow as tf
Traceback (most recent call last):
File "", line 1, in
import tensorflow as tf
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow_init_.py", line 40, in
from tensorflow.python.tools import module_util as _module_util
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python_init_.py", line 83, in
from tensorflow.python import keras
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras_init_.py", line 27, in
from tensorflow.python.keras import applications
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\applications_init_.py", line 25, in
from tensorflow.python.keras import engine
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\engine_init_.py", line 23, in
from tensorflow.python.keras.engine.base_layer import Layer
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\engine\base_layer.py", line 50, in
from tensorflow.python.keras.saving import saved_model
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\saving_init_.py", line 20, in
from tensorflow.python.keras.saving.hdf5_format import load_attributes_from_hdf5_group
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 32, in
from tensorflow.python.keras.utils import conv_utils
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\utils_init_.py", line 38, in
from tensorflow.python.keras.utils.multi_gpu_utils import multi_gpu_model
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\utils\multi_gpu_utils.py", line 22, in
from tensorflow.python.keras.engine.training import Model
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\engine\training.py", line 39, in
from tensorflow.python.keras import metrics as metrics_module
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\metrics.py", line 33, in
from tensorflow.python.keras.engine.base_layer import Layer
ImportError: cannot import name 'Layer'
import tensorflow as tf
Traceback (most recent call last):
File "", line 1, in
import tensorflow as tf
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow_init_.py", line 40, in
from tensorflow.python.tools import module_util as _module_util
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python_init_.py", line 83, in
from tensorflow.python import keras
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras_init_.py", line 27, in
from tensorflow.python.keras import applications
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\applications_init_.py", line 25, in
from tensorflow.python.keras import engine
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\engine_init_.py", line 23, in
from tensorflow.python.keras.engine.base_layer import Layer
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\engine\base_layer.py", line 50, in
from tensorflow.python.keras.saving import saved_model
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\saving_init_.py", line 20, in
from tensorflow.python.keras.saving.hdf5_format import load_attributes_from_hdf5_group
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\saving\hdf5_format.py", line 32, in
from tensorflow.python.keras.utils import conv_utils
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\utils_init_.py", line 38, in
from tensorflow.python.keras.utils.multi_gpu_utils import multi_gpu_model
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\utils\multi_gpu_utils.py", line 22, in
from tensorflow.python.keras.engine.training import Model
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\engine\training.py", line 39, in
from tensorflow.python.keras import metrics as metrics_module
File "D:\Users\1\Anaconda3\lib\site-packages\tensorflow\python\keras\metrics.py", line 33, in
from tensorflow.python.keras.engine.base_layer import Layer
ImportError: cannot import name 'Layer'
How to deal with it ? Should I pip the tensorflow 2.0 agnain ?

@xichuanhit,
Please uninstall available tensorflow and python and install both again. Please try installing latest Tf version 2.0.0.rc1.  Thanks!

@xichuanhit,
Any update!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

I have solved this problem by using anaconda.Use "conda install -c conda-forge tensorflow" in cmd on Windows.I have used pip and pycharm tools but failed.I uninstalled it and run "conda install -c conda-forge tensorflow".This works.

I'm having the same issue, I've tried uninstalling and installing again both python and TensorFlow and it didn't work

C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\Scripts\python.exe C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\Lib\site-packages\keras_vggface\vggface.py
2024-02-22 20:50:57.382238: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable TF_ENABLE_ONEDNN_OPTS=0.
WARNING:tensorflow:From C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\lib\site-packages\keras\src\losses.py:2976: The name tf.losses.sparse_softmax_cross_entropy is deprecated. Please use tf.compat.v1.losses.sparse_softmax_cross_entropy instead.
Traceback (most recent call last):
File "C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\Lib\site-packages\keras_vggface\vggface.py", line 9, in
from keras_vggface.models import RESNET50, VGG16, SENET50
File "C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\lib\site-packages\keras_vggface_init_.py", line 1, in
from keras_vggface.vggface import VGGFace
File "C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\lib\site-packages\keras_vggface\vggface.py", line 9, in
from keras_vggface.models import RESNET50, VGG16, SENET50
File "C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\lib\site-packages\keras_vggface\models.py", line 16, in
from keras.utils import layer_utils
ImportError: cannot import name 'layer_utils' from 'keras.utils' (C:\Users\LENOVO\PycharmProjects\pythonProject1\venv\lib\site-packages\keras\utils_init_.py)
Process finished with exit code 1


Same breadcrumb in Datastore config as in other modules

Same breadcrumbs markup as on other pages (ie. Accounts page).
I wasn't sure about this one, as some other pages (General, Addons) use h1

thanks!


404 at /engine/understanding-docker/

URL: /engine/understanding-docker/  is missing, but several doc articles are referencing it.

This works for me. It redirects to https://docs.docker.com/engine/docker-overview/. Be sure Javascript is enabled and please reopen this issue if you are still seeing a problem.


How to: Multiple products

Let me start, by thank you for the awesome simple code you've been maintaining @Torann.
More of a question, rather than an issue :
Our system needs to create a schema, connecting a product, with it's three most popular. Thus:
https://schema.org/Product -> https://schema.org/isSimilarTo -> Many https://schema.org/Product
For one product, no problem, we're awesome.
What about when we want to connect it to many other contexts products?
How might we go on to implement that feature?  Is this the way to go? https://github.com/Torann/json-ld/pull/20/files
Thank you in advance

Future reference: the above passes the validation at https://search.google.com/structured-data/testing-tool/u/0/

Great work! 👍


RNConfig Empty Android

import RNConfig from 'react-native-config'
console.log("RNConfig", RNConfig);
IOS can export data, but Android cannot. I tried downgrading the version but to no avail.
"react-native": "0.73.2",
"react-native-config": "^1.5.1",

The same issue, iOS loads all correctly but Android consfig is empty.
"react-native": "0.73.6",
"react-native-config": "^1.5.2",

If you have different flavors, don't miss this step.
https://github.com/lugg/react-native-config?tab=readme-ov-file#advanced-android-setup


Improved: Invoice Payments for user with 'VIEW' permission (OFBIZ-12384)

renamed CreateApplicationList.groovy to InvoicePayments.groovy
adjusted reference in acc-invoices.adoc regarding invoice payments
renamed HELP_editInvoiceApplications.adoc to HELP_invoicePayments.adoc
AccountingMenus.xml:

changed menu-item for invoice payments (name and label and link for better perception alignment)
InvoiceScreens.xml:
re screen InvoiceOverview
removed redundant property-map references
adjusted groovy script reference to new file name.
removed link definitions in screenlets (duplicate of menu-items related to the invoice)
adjusted references to invoice payment definitions in InvoiceForms.xml for better perception alignment
re screen for invoice payment
renamed screen from 'InvoiceApplication' to 'InvoicePayments'
adjusted references to titleProperty, tabButtonItem and helpAnchor for better perception alignment
adjusted groovy script reference to new file name.
added conditions for CREATE and UPDATE permission to the start section
adjusted reference to the form (grid) to update existing invoice payments (for users with CREATE or UPDATE Permissions)
adjusted reference to the form (grid) for invoice payments (for users with CREATE or UPDATE Permissions)

InvoiceForms.xml

renamed 'ListInvoiceApplications' to 'InvoiceOverviewApplications. Changed from form definition to grid definition, adjusted field order.
renamed 'EditInvoiceApplications' to 'InvoicePayments' for user with VIEW permission. Changed from form definition to grid definition. adjusted field order.
added 'UpdateInvoicePayments for user with 'CREATE' or 'UPDATE' permissions.

controller.xml

adjusted requests related to invoice payments for better perception alignment
renamed view-map related to invoice payments for better perception alignment.

This change does not only fix the issue but also introduces various name changes, also for requests which possibly breaks  custom uses. Please provide a PR which only fixes the issue and maybe another one for proposed improvements or name changes. Thanks.

Also, please avoid merge commits, you can better update your personal repository using a rebase.

Please list every offence.

Please list every custom code it breaks.
You might have forgotten, but in the comments at the top of each file is stated: 'software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied'.
That makes that the project, nor the contributor can be held accountable for custom code (in a downstream repository, or implementation).

Also, please avoid merge commits, you can better update your personal repository using a rebase.

Thanks for the suggestion.

You missed my point. If you want to fix something which is broken, please do it solely in a PR and avoid to introduce additional changes. It's harder to test/review and also has more risks to introduce additional bugs if you mix it up with other changes.
Changes like name changes also have to be dicussed and reviewed diffrently from bug fixes. They should not slip in with a bug fix.
Thanks.

When talking about a bug fix, there is a (potential) validity. However, this is not the case.

I may not be up to date with latest 'rule' changes, but again: please state for each offence, which rule it violates and point out where that violated rule can be found.
I am, as I have been, always motivated to work with the community.

The description of the corresponding issue reads: "Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the payments screen on an invoice sees fields editable and triggers to requests reserved for users with 'CREATE' or 'UPDATE' permissions."
If you call it an improvement or bug (which I would call it), the description explains what should be fixed/improved.
The changes in this PR are a lot more than just fixing the permission bug decribed there.
I think I was clear enough and won't add more to this issue. I won't merge the PR as it is now.

Tak for pointing that out. I will change the subject of the ticket.

Quoting Michael
You missed my point. If you want to fix something which is broken, please do it solely in a PR and avoid to introduce additional changes. It's harder to test/review and also has more risks to introduce additional bugs if you mix it up with other changes.

Changes like name changes also have to be dicussed and reviewed diffrently from bug fixes. They should not slip in with a bug fix

Also it's often quite harder to revert...

Pierre,
You need to refrain yourself to put unrelated changes into a sole PR. It complicates things for committers, TIA

Sounds a bit weird to now change the issue to match the PR instead of changing the PR to match the issue...
Anyway, you should give the community some good explanations WHY you want to do all those renames then. In the description.

Pierre,
You need to refrain yourself to put unrelated changes into a sole PR. It complicates things for committers, TIA

Thanks for the tip, Jacques.
But does the PR break anything in trunk?

As I said in the Jira it works

Thanks Jacques.
If members of the community feels that there must be a rule for having each minor or trivial improvement to  beraised as a separate ticket, and having its own PR, instead of being combined with another ticket (and the PR associated  with that), they can of course start that discussion in dev.
Addressing those minor and trivial issues (even without their own tickets) in one go with other tickets (and even without), has been done by every contributor - non-privileged and others - in the past 15 years without raising eye-brows.

It's simple, create sufficient PRs inside the same Jira to separate things . That's what most savvy contributors did for years, using patches before. Then it's easier for committers to:

review
validate (test, etc.)
revert if necessary

If you don't do that you will always front what you seem to feel as negligence from committers. We just prefer an easier and especially safer work.

Hi Pierre,
First I must say that in general it's not a good idea to edit comment sin GitHub. Because there is no history or way to compare once done, or I don't know how. Also I think that mixing comments in Jira and GH PR is not helping. Anyway, here is an answer to your last comment above.
You ask about rules, etc. You don't need rules here, just common sense. And it was clearly explained by Michael above. Not all can be ruled, and even with rules you need a judge. Michael and I were your judges here.
Though I wonder how for a "Proud contributor of Apache OFBiz since 2008 (without privileges)" you don't see what the problems are. You are lucky I'm in a good day.
Here are more details. If you feel cosmetic changes, like renaming things, should be done you should have made them in another PR. I mean changed/renamed AccountingUiLabels.xml, InvoicePayments.groovy, acc-invoices.adoc, HELP_invoicePayments.adoc, the controller.xml, AccountingMenus.xml , in another PR. Only InvoiceForms.xml and InvoiceScreens.xml should have be part of this PR but without renaming in them.
You remember https://github.com/apache/ofbiz-framework/commit/6727f46 ? That's what I want to avoid. Even if I must say it certainly has not the same extend here.
Also, I don't know if it's related to GitHub patches or how Eclipse apply patches. When using apply patch from clipboard in Eclipse to locally test, file renaming is not working. Maybe it's due to how you rename files and should read https://www.patrick-wied.at/blog/rename-files-and-folders-with-git or something alike?
That's what I get in cmd line after saving https://patch-diff.githubusercontent.com/raw/apache/ofbiz-framework/pull/344.patch locally.
C:\projectsASF\Git\ofbiz-framework>git apply --stat 344.patch
 .../accounting/config/AccountingUiLabels.xml       |    6 +-
 .../groovyScripts/invoice/InvoicePayments.groovy   |    0
 .../asciidoc/_include/HELP_invoicePayments.adoc    |    0
 .../src/docs/asciidoc/_include/acc-invoices.adoc   |    2 -
 .../webapp/accounting/WEB-INF/controller.xml       |   18 +++---
 applications/accounting/widget/AccountingMenus.xml |    4 +
 applications/accounting/widget/InvoiceForms.xml    |   42 +++++++++------
 applications/accounting/widget/InvoiceScreens.xml  |   57 +++++++-------------
 8 files changed, 61 insertions(+), 68 deletions(-)

C:\projectsASF\Git\ofbiz-framework>git apply --check 344.patch
error: patch failed: applications/accounting/config/AccountingUiLabels.xml:24357
error: applications/accounting/config/AccountingUiLabels.xml: patch does not apply
error: applications/accounting/groovyScripts/invoice/CreateApplicationList.groovy: No such file or directory
error: applications/accounting/src/docs/asciidoc/_include/HELP_editInvoiceApplications.adoc: No such file or directory
error: patch failed: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc:56
error: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc: patch does not apply
error: patch failed: applications/accounting/webapp/accounting/WEB-INF/controller.xml:213
error: applications/accounting/webapp/accounting/WEB-INF/controller.xml: patch does not apply
error: patch failed: applications/accounting/widget/AccountingMenus.xml:171
error: applications/accounting/widget/AccountingMenus.xml: patch does not apply
error: patch failed: applications/accounting/widget/InvoiceForms.xml:188
error: applications/accounting/widget/InvoiceForms.xml: patch does not apply
error: patch failed: applications/accounting/widget/InvoiceScreens.xml:182
error: applications/accounting/widget/InvoiceScreens.xml: patch does not apply

C:\projectsASF\Git\ofbiz-framework>git am 344.patch
error: patch failed: applications/accounting/config/AccountingUiLabels.xml:24357
error: applications/accounting/config/AccountingUiLabels.xml: patch does not apply
error: applications/accounting/groovyScripts/invoice/CreateApplicationList.groovy: does not exist in index
error: applications/accounting/src/docs/asciidoc/_include/HELP_editInvoiceApplications.adoc: does not exist in index
error: patch failed: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc:56
error: applications/accounting/src/docs/asciidoc/_include/acc-invoices.adoc: patch does not apply
error: patch failed: applications/accounting/webapp/accounting/WEB-INF/controller.xml:213
error: applications/accounting/webapp/accounting/WEB-INF/controller.xml: patch does not apply
error: patch failed: applications/accounting/widget/AccountingMenus.xml:171
error: applications/accounting/widget/AccountingMenus.xml: patch does not apply
error: patch failed: applications/accounting/widget/InvoiceForms.xml:188
error: applications/accounting/widget/InvoiceForms.xml: patch does not apply
error: patch failed: applications/accounting/widget/InvoiceScreens.xml:182
error: applications/accounting/widget/InvoiceScreens.xml: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: Improved: Invoice Payments for user with 'VIEW' permission (OFBIZ-12384)
Patch failed at 0001 Improved: Invoice Payments for user with 'VIEW' permission (OFBIZ-12384)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

So I can't test your changes locally and something must be done.


HADOOP-17612 : Bump Zookeeper version to 3.7.0

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 11s

trunk passed

+1 :green_heart:
compile
20m 38s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
17m 58s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 51s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
2m 19s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 50s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
0m 38s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
14m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
19m 52s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
19m 52s

the patch passed

+1 :green_heart:
compile
17m 54s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
17m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 45s
/results-checkstyle-root.txt
root: The patch generated 1 new + 367 unchanged - 2 fixed = 368 total (was 369)

+1 :green_heart:
mvnsite
2m 51s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 18s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
2m 52s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
0m 36s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
14m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 35s

hadoop-project in the patch passed.

-1 :x:
unit
1m 13s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
unit
0m 58s
/patch-unit-hadoop-common-project_hadoop-registry.txt
hadoop-registry in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

182m 13s

Reason
Tests

Failed junit tests
hadoop.registry.client.impl.TestMicroZookeeperService

hadoop.registry.client.impl.TestCuratorService

hadoop.registry.cli.TestRegistryCli

hadoop.registry.secure.TestSecureRegistry

hadoop.registry.operations.TestRegistryOperations

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2840

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 11b54bcca879 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 57f13f779602a4d04de8b44ada48d0a29504894d

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/1/testReport/

Max. process+thread count
689 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 12s

trunk passed

+1 :green_heart:
compile
25m 40s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m 55s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
4m 33s

trunk passed

+1 :green_heart:
mvnsite
9m 56s

trunk passed

+1 :green_heart:
javadoc
7m 31s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
8m 46s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
0m 39s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
18m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 11s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
mvninstall
0m 10s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

-1 :x:
mvninstall
0m 10s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

-1 :x:
compile
0m 14s
/patch-compile-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
0m 14s
/patch-compile-root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 13s
/patch-compile-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
javac
0m 13s
/patch-compile-root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
root in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 12s
/buildtool-patch-checkstyle-root.txt
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 14s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
mvnsite
0m 13s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

-1 :x:
mvnsite
0m 13s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
xml
0m 13s

The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 11s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-nfs-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-nfs in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt
hadoop-yarn-client in the patch failed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
javadoc
0m 13s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-nfs-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-hdfs-nfs in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
javadoc
0m 14s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt
hadoop-yarn-client in the patch failed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.

-1 :x:
spotbugs
0m 14s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
spotbugs
0m 13s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

+0 :ok:
spotbugs
0m 14s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 12s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

-1 :x:
shadedclient
2m 27s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
6m 55s
/patch-unit-hadoop-common-project_hadoop-auth.txt
hadoop-auth in the patch passed.

-1 :x:
unit
1m  8s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
unit
1m  8s

hadoop-registry in the patch passed.

-1 :x:
unit
0m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
unit
0m 13s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-nfs.txt
hadoop-hdfs-nfs in the patch failed.

+1 :green_heart:
unit
0m 14s

hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 20s

hadoop-yarn-applications-mawo-core in the patch passed.

-1 :x:
unit
0m 14s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
unit
17m 34s

hadoop-yarn-server-common in the patch passed.

-1 :x:
unit
0m 56s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch failed.

+0 :ok:
asflicense
0m 14s

ASF License check generated no output?

213m 16s

Reason
Tests

Failed junit tests
hadoop.security.authentication.util.TestZKSignerSecretProvider

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2840

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux e9472073b057 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 560cf3b848348ac25dbe6f68eb505eea8648bf71

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/2/testReport/

Max. process+thread count
601 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 27s

trunk passed

+1 :green_heart:
compile
20m 38s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
17m 56s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
3m 47s

trunk passed

+1 :green_heart:
mvnsite
9m 15s

trunk passed

+1 :green_heart:
javadoc
7m 48s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
8m 38s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
0m 39s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
14m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 33s

the patch passed

+1 :green_heart:
compile
19m 57s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
19m 57s

the patch passed

+1 :green_heart:
compile
18m  8s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
18m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 46s
/results-checkstyle-root.txt
root: The patch generated 1 new + 367 unchanged - 2 fixed = 368 total (was 369)

+1 :green_heart:
mvnsite
9m 13s

the patch passed

+1 :green_heart:
xml
0m 13s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
7m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
8m 38s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
0m 35s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
14m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 35s

hadoop-project in the patch passed.

-1 :x:
unit
6m 40s
/patch-unit-hadoop-common-project_hadoop-auth.txt
hadoop-auth in the patch passed.

-1 :x:
unit
1m 17s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
unit
1m 21s

hadoop-registry in the patch passed.

-1 :x:
unit
1m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
unit
2m 59s

hadoop-hdfs-nfs in the patch passed.

+1 :green_heart:
unit
17m 52s

hadoop-yarn-server-common in the patch passed.

-1 :x:
unit
1m  7s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch failed.

-1 :x:
unit
0m 44s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
hadoop-yarn-client in the patch failed.

+1 :green_heart:
unit
0m 40s

hadoop-yarn-applications-mawo-core in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

277m  6s

Reason
Tests

Failed junit tests
hadoop.security.authentication.util.TestZKSignerSecretProvider

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2840

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 72541ac8b097 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b8eb0a0b8a9d58bad60d6a2e7b832b8054b8cd3f

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/3/testReport/

Max. process+thread count
640 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2840/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

As per discussion on Jira, keeping this on hold for some time. Closing the PR.


Enable spring-boot actuator to allow monitoring of elastic services

Description
In order to allow health checks and liveness probes in container orchestrators and service discovery services, a health check API endpoint must be available.
Implement using out of the box Spring Boot Actuator (/actuator/health)

Issue was implemented in scope of upcoming presentation and is in use and working in several deployments.


Draft: prevent react-core components from injecting component css styles out…

… of react-styles

Thanks @jschuler for the PR. this has been merged as part of #86


[Request] Sweet Clown ~Gozen San-ji no Okashi na Doukeshi~

I'd really appreciate it if someone could find and share the script for this otome game (Switch version): Sweet Clown -Gozen San-ji no Okashi na Doukeshi- / Sweet Clown -午前三時のオカシな道化師-
Thanks in advance!

+1 Request!

+1 Request!

+request please!

+1 REQUEST


How does a process know that there are messages waiting?

Let's say you have a client and server situation.   The client can enqueue messages and the server can pull the messages off the queue.   Can you define the server so that it will "wait" for a message to arrive so that it can then retrieve it and then go back and wait for more?
The documentation seems to imply that you should only retrieve a message if you know one is there,  because a retrieve will return nothing if there are no messages, rather than wait for something to arrive - but that doesn't make much sense :(
There seems to be a missing "consume" method which would allow a process to wait for messages to arrive, and retrieve them when they do.

Is the answer to use rsmq-worker?

Correct. rsmq-worker is a helper that polls a queue for you in defined intervals.
Depending on your use case you could have a few hundred clients that do just this or just a single one.

OK - so in the scenario where there is a single client and a few hundred workers (any of which might process the message), how would one know when it is safe to dispose of the queue?   Presumably if the client disposes of the queue while workers are waiting for messages on the queue nasty things will happen?

This is the main guarantee of rsmq:

Guaranteed delivery of a message to exactly one recipient within a messages visibility timeout.

So no nasty things will happen, as long as the visibility timeout of a message is long enough for a worker to possibly finish a message.
Let's say you have 1,000,000 video encoding jobs to work on.

Each video is between 1 and 10 minutes long so lets say each encoding will take max. 10 Minutes.
Once an encoding is finished your worker deletes that message.
Your visibility timeout should be 10 minutes or a little bit more.
Now every worker will receive a message that will not be received by another worker for at least those 10 minutes.
If a worker does not finish in 10 minutes and deletes the message. The message will show up again.

Yes I think I understand that bit but I didn't explain myself well.   I need to be able to safely delete a queue completely using deleteQueue() but I only want to do so when I am sure there are no workers attempting to consume messages from the queue - and my workers will be popping messages rather than receiving them. In my use case as soon as a worker gets a message I don't want any others to have any chance of getting it even if the worker crashes.

Use the popMessage for that. And before you remove a queue use getQueueAttributes to make sure no messages are "in flight".

Yes still not quite what I need though unfortunately.  It will be quite legitimate for a queue to be empty for long periods of time.   What I need to be able to do is ensure that a client can delete a queue when there are no workers attempting to consume messages from it.  So the trigger will be that all the workers have gone away, not that the queue is empty.

As an aside, there doesn't seem to be a way to tell rsmq-worker to pop messages rather than receive them - so I guess I will just have to delete them on the "message" event.
My worry over deleting queues might not be such a big deal.   My only concern is that I leave queues in redis that are completely redundant and therefore bloat the database.  I don't suppose there is a ttl option on queues?    That aside, I guess I might just be able to delete all the queues on startup using listQueues ?

So what you need is a deleteQueueOnlyWhenEmpty right?

No not when it is empty - when there are no workers waiting for messages on the queue.  It could be that the queue is empty for hours, but I don't want to delete it because workers are still there waiting.
Consider this:
A single clients creates a queue.
It then spawns 100 child processes, and each child process becomes a rsmq-worker consuming messages on that queue.
Each worker may process 0-n messages.
If the queue is empty, the workers still wait for messages.
A worker may decide to stop() listening for messages (reason not important this this).
When, and only when, all the workers have stopped listening for messages. the client will delete the queue (regardless of whether or not it contains messages).
So this would be like a deleteQueueWhenNothingListening type of thing.

Alternatively have a TTL on the queue so that it disappears by itself when nothing is consuming it or enqueueing messages.
What I basically would like is a similar facility to that provided by busmq.  So processings can attach to a queue and detach from a queue.  When there are no processes attached to a queue, it will expire in redis (after a TTL interval).

I can probably work around this for now, but I have a bigger issue with rsmq-worker
https://github.com/mpneuried/rsmq-worker/issues/15


Remove cypress

Slows down package install - re-add only for integration tests

Merged as part of #12.


Do not loose Map instance when mapping MultiOccurenceVariable to a Map

This pull request fixes #82.
It makes the generated mapper preserve the values of a target map, when mapping from a MultiOccurenceVariable to a MultiOccurenceVariable.

I tested this fix on master, orika-1.4.x and orika-1.5.x branch.
Unfortunately I had to cherry-pick a331d31 into my branch to get the local build passing


coverall : need to aggregate sub-projects coverages

Apparently since recent project splitting (common/autosleep/autowakeup) our coverage has reached high scores 👍 ...
...unfortunately this is not due to our dev team expertise, but rather to the fact that only autosleep module is taken into account 😞
see https://coveralls.io/builds/6213523 for instance

This could help :

https://github.com/kt3k/coveralls-gradle-plugin#use-with-mutli-project-build
https://github.com/ben-manes/caffeine/blob/master/build.gradle

Closed because merged in feature-wildcard-proxy branch.


Reduce the jQuery and Moment version constraints

Currently, using a jQuery version newer than 2.2 is not allowed. This change makes it less restrictive.
Also, allows Moment versions newer than 2.10.

Hi, did this commit make it into the npm version? I just required it and it seems that the package.json is still requiring older versions of jquery/moment.


Get user roles from database for use in JWT

Resolves https://github.com/NASA-AMMOS/aerie/issues/862

Queries for user roles in DB and sets them in JWT
Creates user in DB if they do not exist and assigns them default 'user' role

TODO

[x] Update the queries in this commit with the real table name and columns that are added in https://github.com/NASA-AMMOS/aerie/issues/938

PR looks good. I'll test it once we have the users table in the DB

@Mythicaeda This is ready for review when you have some time this week


data.tar.gz did not unpack correctly. Possibly corrupted?

Possible workaround is to download the data.tar.gz file via the Browser(GUI).
Possibly to do with line endings...
FYI @Gfeuillen @toon-vc

Thx. I also found the way of downloading via the browser  is useful.


Allow for custom DEV URL

Is your feature request related to a problem? Please describe.
The extension currently recognizes localhost:3000 as DEV URL. My team's DEV is a containerized environment in the cloud, where localhost:3000 within the container is externalized to another URL that do not meet the URL pattern the extension expects
Describe the solution you'd like
Allow to specify custom DEV URL within extension options
Describe alternatives you've considered
Looked into using the PRODUCTION Hostname without success
Additional context

To enable a custom dev URL for a project:

Right-click the AEM Sidekick icon and select Options

Click Advanced

Click Edit next to your project config

Enter the custom dev origin (without slash or path)

Click Save

:tada: This issue has been resolved in version 6.18.0 :tada:
The release is available on:

GitHub release
v6.18.0

Your semantic-release bot :package::rocket:


Create namespace when adding new SSH keys to Virtual Machines

Summary
PR Checklist

Is this a multi-tenancy feature/bug?

[ ] Yes, the relevant RBAC changes are at:

Do we need to backport changes to the old Rancher UI, such as RKE1?

[ ] Yes, the relevant PR is at:

Are backend engineers aware of UI changes?

[ ] Yes, the backend owner is:

Related issue: https://github.com/harvester/harvester/issues/5419

Occurred changes and/or fixed issues

Technical notes summary

It adds namespace creation in VirtualMachineSSHKey component, for both pages:

Create Virtual Machines
Create Virtual Machines templates

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@mergify backport release-harvester-v1.2 release-harvester-v1.3


Old documentation

Great work with the latest release of Monk !!
Still, is it possible to leave online the old documentation before we update ?
Also, does the new syntax support callback syntax or is it only with .then ?
Thanks a lot !

it does support the callback syntaxt

The old readme is still accessible here: https://github.com/Automattic/monk/tree/4b0114440d91d1c570b30c713c3f4613e4b5933d


Confusion regarding usage of pyspark.mlllib

In the examples you are using pyspark.ml library but what if I have to do the classification using SVM via the pyspark.mllib library .
How can i implement the 'fit()' function then?

I was able to finally do it via the following code -
p = featurizer.transform(train_df)
data = p.rdd
'''
Function to convert convert type <class 'pyspark.ml.linalg.DenseVector'> into Vector
""
def as_mllib(v):
if isinstance(v, ml_linalg.DenseVector):
return MLLibVectors.dense(v.toArray())
else:
raise TypeError("Unsupported type: {0}".format(type(v)))
data = data.map(lambda row: LabeledPoint(row.label, as_mllib(row.features)))
model = SVMWithSGD.train(data1, iterations=1)
Is there a simpler way to do this thing?

@jkbradley is there a simpler way?

@a7b23 the SVM interface is indeed not available yet in spark.ml, but it will be in Spark 2.2.

@thunterdb So by converting the features to rdd data type and then applying svm over it am I compromising the performance in terms of speed ?


Thumbnails with finite=true works like finite=false

Describe the bug
Thumbnail carousel looks infinite even with finite=false in settings
Expected behavior
Thumbnails end with the main carousel
Also I think the thumbnail shouldn't dissapear if it's already preloaded
How to reproduce
Link to sandbox
Screenshots / Logs

Additional context
No response

Thumbnail carousel looks infinite even with finite=false in settings

This is actually the intended design. In "finite" mode there are no thumbnails to the left of the first slide and to the right of the last slide, and the first and the last visible thumbnails have a vignette effect (which you can disable with thumbnails={{ vignette: false }}).
Please see the below screenshots demonstrating the difference between finite: true and finite: false.
carousel={{ finite: true }}

carousel={{ finite: false }}

You can probably adjust the number of preloaded thumbnails based on the viewport size to achieve the desired behavior.
const [open, setOpen] = React.useState(false);
const [viewport, setViewport] = React.useState<number>();

React.useEffect(() => {
  const updateViewport = () => {
    setViewport(window.innerWidth);
  };

  updateViewport();

  window.addEventListener("resize", updateViewport);
  return () => window.removeEventListener("resize", updateViewport);
}, []);

return (
  <>
    <Lightbox
      open={open}
      close={() => setOpen(false)}
      slides={slides}
      plugins={[Thumbnails, Video, Zoom]}
      carousel={{
        finite: true,
        preload: viewport ? Math.min(Math.floor((viewport - 170) / 292), 3) : undefined,
      }}
      thumbnails={{ vignette: false }}
    />

    {/* ... */}
  </>
);

Does this address your concern?

Also I think the thumbnail shouldn't dissapear if it's already preloaded

IMO, this behavior would look odd on large viewports.

But in

In "finite" mode there are no thumbnails to the left of the first slide and to the right of the last slide

But on my screenshot there are thumbnails to the right of the last slide. This is the last image and below I can see the last and the first thumbnail

Can you provide reproducible example? You can use the following sandbox as a template.
https://codesandbox.io/p/sandbox/yet-another-react-lightbox-205-xf4w77

@oceandrama any chance you can share a reproducible example? I'm not seeing any issues with the sandbox you provided in the description.
The first slide:

The last slide:

Hmm, now it works well. That's strange. Sorry for misleading.
My primary goal was to make thumbnails scrollable for quick navigation between images (and I tried different combinations of options that lead to this bug). I can preload all images and add scroll using css, but because of placeholders it doesn't work well. Is it possible to implement this feature?

Thank you for the update. Please see the following discussion re: swipeable thumbnails - https://github.com/igordanchenko/yet-another-react-lightbox/discussions/193
Can you also describe the UX you want to achieve with swipeable thumbnails?

When there are a lot of images, a few dozens, user want to quick navigate between them. Current thumnails implementation allow only to skip the next image, so if you need to go to the end you need to click and wait too many times

I'm closing this ticket since it sounds like this bug report was created erroneously.


Add button_dialog, including docs/examples

Provides the ability to render several buttons with values of your choosing.
Updated docs and examples to show how it works.

Codecov Report

Merging #583 into 2.0 will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##              2.0     #583      +/-   ##
==========================================
- Coverage   71.06%   71.05%   -0.01%
==========================================
  Files         123      123
  Lines       11926    11929       +3
==========================================
+ Hits         8475     8476       +1
- Misses       3451     3453       +2

Impacted Files
Coverage Δ

prompt_toolkit/shortcuts/__init__.py
100% <100%> (ø)
:arrow_up:

prompt_toolkit/shortcuts/dialogs.py
28.76% <33.33%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c59f3...07b642e. Read the comment docs.

Sorry, but I don't have any idea how to write tests for this... But it works!

Done!  Truthfully, the yes_no_dialog could just call the button_dialog now to maintain DRY...
Glad to have been able to contribute (and to learn about functools.partial today) :)

Thanks a lot for this! It's very much appreciated. Feel free to create another merge request to rewrite yes_no_dialog building on top of this.
It also reminds me that I should fix the background of the buttons when they are selected. I removed the 'focussed' class from the style in the Window because that was not the right place to add this, but it should be added somewhere else.
Cheers!

I was actually going to ask you how to do this!

From: Jonathan Slenders<EMAIL_ADDRESS>Sent: Wednesday, February 7, 2018 3:21:17 PM
To: jonathanslenders/python-prompt-toolkit
Cc: sreyemnayr; Mention
Subject: Re: [jonathanslenders/python-prompt-toolkit] Add button_dialog, including docs/examples (#583)
Thanks a lot for this! It's very much appreciated. Feel free to create another merge request to rewrite yes_no_dialog building on top of this.
It also reminds me that I should fix the background of the buttons when they are selected. I removed the 'focussed' class from the style in the Window because that was not the right place to add this, but it should be added somewhere else.
Cheers!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jonathanslenders/python-prompt-toolkit/pull/583#issuecomment-363914647, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIKYTldRKW-FrZW9K7Oop3eIoapNr8dkks5tShPNgaJpZM4R7a7L.

See here: https://github.com/jonathanslenders/python-prompt-toolkit/commit/3c8a29ed52203b0f470bc24c01fd735c60cd029d

Nice! I’ll knock that yes_no_dialog piece out in a bit. Such a cool project, I’m honored to contribute!
Ryan Meyers

From: Jonathan Slenders<EMAIL_ADDRESS>Sent: Wednesday, February 7, 2018 4:11:54 PM
To: jonathanslenders/python-prompt-toolkit
Cc: sreyemnayr; Mention
Subject: Re: [jonathanslenders/python-prompt-toolkit] Add button_dialog, including docs/examples (#583)
See here: 3c8a29ehttps://github.com/jonathanslenders/python-prompt-toolkit/commit/3c8a29ed52203b0f470bc24c01fd735c60cd029d
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jonathanslenders/python-prompt-toolkit/pull/583#issuecomment-363928481, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIKYTg0c5xFhYitRzumNH5-5RIqF2qJvks5tSh-qgaJpZM4R7a7L.


refactor: Make BitcoinUnits::Unit a scoped enum

Ported from https://github.com/bitcoin/bitcoin/pull/17877.
Since Qt 5.5 there are means to register an enum type with the meta-object system (such enum still lacks an ability to interact with QSettings::setValue() and QSettings::value() without defined stream operators).
In order to reduce global namespace polluting and to force strong type checking, this PR makes BitcoinUnits::Unit a scoped enum (typedef BitcoinUnits::Unit BitcoinUnit;).
No behavior change.

bitcoin/bitcoin#17877 has Concept ACKs from:

@promag
@practicalswift
@elichai
@jonasschnelli
@Empact

@promag @jonasschnelli Mind reviewing this PR?

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

Rebased 243205f85b8b10e4f43865557cdd8ea3aa71c380 -> b109ae6d2b292f561d2afbc3e4985651f06575be (pr60.01 -> pr60.02) due to the conflict with #35.

tACK b109ae6
I just noticed one practical downside of this separate repo; having to add another remote: git remote add hebasto-gui git@github.com:hebasto/gui.git

@Sjors I only have git@github.com:bitcoin-core/gui.git and my gui fork.

I manually call git fetch https://github.com/hebasto/gui/ 200814-unit, which works without a remote

FWIW, I'm like @promag and using @jonatack's scripts to fetch all PRs:
[remote "upstream"]
        fetch = +refs/pull/*/head:refs/remotes/upstream/pr/*

then you can just git checkout upstream/pr/60.

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

Rebased b109ae6d2b292f561d2afbc3e4985651f06575be -> 7e636c7fe129afff8ff248cdd6b55e59445f1e0e (pr60.02 -> pr60.03) due to the conflict with #176.

Rebased b109ae6d2b292f561d2afbc3e4985651f06575be -> 7e636c7fe129afff8ff248cdd6b55e59445f1e0e (pr60.02 -> pr60.03) due to the conflict with #176.

Concept ACK

Updated 7e636c7fe129afff8ff248cdd6b55e59445f1e0e -> cb08a1c22d5bbf7baf5dc5003dd29185660efd78 (pr60.03 -> pr60.04, diff):

addressed most of @promag's comments

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

Updated cb08a1c22d5bbf7baf5dc5003dd29185660efd78 -> 68baad3cfac5c0daf9589a92ea1e99c20cc0e380 (pr60.04 -> pr60.05):

rebased due to the conflict with #263
option renamed s/display_unit/DisplayBitcoinUnit/ to be in line with other recently added options, see #295

Rebased 68baad3cfac5c0daf9589a92ea1e99c20cc0e380 -> 8eb1a34937990012d661d262a029e33c8cb67776 (pr60.05 -> pr60.06) due to the conflict with #275.

Code Review ACK 8eb1a34937990012d661d262a029e33c8cb67776
looks like a reasonable cleanup

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

cc @hebasto, a rebase is needed :)

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡ Please close.
Did the author lose interest or time to work on this? ➡ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

I have a rebased version here: https://github.com/bitcoin-core/gui/compare/master...jb55:units-scoped-enum
I can submit a PR if you want me to take this over @hebasto

I have a rebased version here: master...jb55:units-scoped-enum
I can submit a PR if you want me to take this over @hebasto

@jb55
Thank you! I'll appreciate if you do that.

Closing in favor of #556.


traffic_ops_ort.pl transliteration to go

This PR is a transliteration of the traffic_ops_ort.pl perl script to go.  It built command is 'traffic_ops_t3c' and is designed to replace the perl script entirely.  'traffic_ops_t3c' depends on and uses 'atstccfg'.  The go version here implements all the functionality in the perl version.  unit and integration tests will be added.  Looking for feedback from the community on this Draft PR.
Which Traffic Control components are affected by this PR?

Traffic Ops ORT

What is the best way to verify this PR?
Using a test environment, compare the run results from traffic_ops_ort.pl to the run results from 'traffic_ops_t3c'
The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[X] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[X] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.

command usage:
`./traffic_ops_t3c --help
Usage: traffic_ops_t3c [options] <Traffic_Ops_URL>
 = URL to Traffic Ops host. Example: https://trafficops.company.net
	  Example: 'username:password'

	[options]:
	  --dispersion=[time in seconds] | -D, [time in seconds] wait a random number between 0 and  before starting, default = 300s
	  --login-dispersion=[time in seconds] | -l, [time in seconds] wait a random number between 0 and  befor login, default = 0
	  --log-location-debug=[value] | -d [value], Where to log debugs. May be a file path, stdout, stderr, or null, default stdout
	  --log-location-error=[value] | -e [value], Where to log errors. May be a file path, stdout, stderr, or null, default stdout
	  --log-location-info=[value] | -i [value], Where to log info. May be a file path, stdout, stderr, or null, default stdout
	  --log-location-warning=[value] | -w [value], Where to log warnings. May be a file path, stdout, stderr, or null, default stdout
	  --run-mode=[mode] | -m [mode] where mode is one of [interactive | report | badass | syncds | revalidate ], default = report
	  --cache-hostname=[hostname] | -H [hostname], Host name of the cache to generate config for. Must be the server host name in Traffic Ops, not a URL, and not the FQDN
	  --num-retries=[number] | -r [number], retry connection to Traffic Ops URL [number] times, default is 3
	  --reval-wait-time=[seconds] | -T [seconds] wait a random number of seconds between 0 and [seconds] before revlidation, default is 60
	  --rev-proxy-disable=[true|false] | -P [true|false] bypass the reverse proxy even if one has been configured, default = false
	  --skip-os-check=[true|false] | -s [true | false] bypass the check for a supported CentOS version. default = false
	  --traffic-ops-timeout-milliseconds=[milliseconds] | -t [milliseconds] the Traffic Ops request timeout in milliseconds. Default = 30000 (30 seconds)
	  --traffic-ops-url=[url] | -u [url], Traffic Ops URL. Must be the full URL, including the scheme. Required. May also be set with the environment variable TO_URL
	  --traffic-ops-user=[username] | -U [username], Traffic Ops username. Required. May also be set with the environment variable TO_USER
	  --traffic-ops-password=[password] | -P [password], Traffic Ops password. Required. May also be set with the environment variable TO_PASS
	  --wait-for-parents | -w [true | false] do not update if parent_pending = 1 in the update json. default = true, wait for parents

	  --help | -h, Print usage information and exit`

I think the current plan for the future of ORT is in the related blueprint.

Command Usage:
`Usage: traffic_ops_t3c [options] <Traffic_Ops_URL> <Traffic_Ops_Login>
<Traffic_Ops_URL> = URL to Traffic Ops host. Example: https://trafficops.company.net
<Traffic_Ops_Login>  Example: 'username:password'
[options]:
  --dispersion=[time in seconds] | -D, [time in seconds] wait a random number between 0 and <time in seconds> before starting, default = 300s
  --login-dispersion=[time in seconds] | -l, [time in seconds] wait a random number between 0 and <time in seconds> befor login, default = 0
  --log-location-debug=[value] | -d [value], Where to log debugs. May be a file path, stdout, stderr, or null, default stdout
  --log-location-error=[value] | -e [value], Where to log errors. May be a file path, stdout, stderr, or null, default stdout
  --log-location-info=[value] | -i [value], Where to log info. May be a file path, stdout, stderr, or null, default stdout
  --log-location-warning=[value] | -w [value], Where to log warnings. May be a file path, stdout, stderr, or null, default stdout
  --run-mode=[mode] | -m [mode] where mode is one of [interactive | report | badass | syncds | revalidate ], default = report
  --cache-hostname=[hostname] | -H [hostname], Host name of the cache to generate config for. Must be the server host name in Traffic Ops, not a URL, and not the FQDN
  --num-retries=[number] | -r [number], retry connection to Traffic Ops URL [number] times, default is 3
  --reval-wait-time=[seconds] | -T [seconds] wait a random number of seconds between 0 and [seconds] before revlidation, default is 60
  --rev-proxy-disable=[true|false] | -P [true|false] bypass the reverse proxy even if one has been configured, default = false
  --skip-os-check=[true|false] | -s [true | false] bypass the check for a supported CentOS version. default = false
  --traffic-ops-timeout-milliseconds=[milliseconds] | -t [milliseconds] the Traffic Ops request timeout in milliseconds. Default = 30000 (30 seconds)
  --traffic-ops-url=[url] | -u [url], Traffic Ops URL. Must be the full URL, including the scheme. Required. May also be set with the environment variable TO_URL
  --traffic-ops-user=[username] | -U [username], Traffic Ops username. Required. May also be set with the environment variable TO_USER
  --traffic-ops-password=[password] | -P [password], Traffic Ops password. Required. May also be set with the environment variable TO_PASS
  --wait-for-parents | -w [true | false] do not update if parent_pending = 1 in the update json. default = true, wait for parents

  --help | -h, Print usage information and exit`

I think the current plan for the future of ORT is in the related blueprint.

Right, the goal here is to enable that. The Perl is extremely difficult to maintain and ensure correctness while modifying. Doing the blueprint wholesale would be a very large project, and difficult to ensure the end is correct and has parity. Doing the blueprint one piece at a time while continually modifying the Perl would likewise be difficult and dangerous.
This lets us do the Blueprint one piece at a time, carving out pieces of the now-Go script, and modifying the main/old script in Go to use each new, small piece will be much easier and safer than Perl.

Okay, but why not use the transliteration from Perl to Python that already exists under infrastructure/cdn-in-a-box/ort?

I think most of us who work with ORT and ATS in Production are just more familiar with the prod Perl script. Learning and working with the Python would introduce another step of having to learn thousands of lines of code, and then we would have to verify that whatever we did with it has parity with the Perl used for Production, so we'd still have to learn and understand the Perl script. It's just more work, more to learn, and more to test.
That's how I would feel if I were doing it, anyway. I don't have any philosophical objections to working with the Python; it would just take me longer.
But at the end of the day, IMO it should be up to the implementer. Whoever is implementing it knows what's fastest and safest for them.

Why is learning and working with the Python more work than learning and working with the Go? They're both not the Perl script.
FWIW, the Python script has the advantage of already being tested as good enough for a CiaB environment, and it was also tested once a while back on a production server. It wasn't much of a test, but it showed that with actual production data it can output correct configs (that was also before atstccfg, so means a bit less).

@ocket8888 As a team, caching proxies, decided this work is part of the overall ORT rework as outlined in the blueprint for the reasons @rob05c has mentioned.  It was assigned to me in the CDN Q2/Q3 work plan and I'll continue with the ORT blueprint work.  I'm not arguing wether one is better than the other (go vs python) but all the remaining blueprint work will be in go as well.
This go version does manage rpm installation and does require /sbin/service and /bin/systemctl to insure that systemd loads/reloads 'service' files

It also works without systemd. Which means it can work in CiaB. If we transliterate again, then Python will still need to stick around anyway, unless the new one can also run without systemd.

This go version does manage rpm installation and does require /sbin/service and /bin/systemctl to insure that systemd loads/reloads 'service' files

The Blueprint breaks it up, so the part that interacts with SystemD should be one small app.
We should write the overall "ort" app that binds them together in such a way that it's easy (maybe a flag?) to omit those calls, so the whole script works without SystemD. Not an immediate concern, by-design that shouldn't be difficult to do after the fact. But something we should keep in mind.
ATS can be reloaded and restarted by calling it directly. Maybe have a flag with the option to do SystemD, ATS Directly, or none?

I think it's fine to eventually include a flag to bypass the SystemD calls if it can be done and make it so we don't have to maintain two version of ORT (which we never should have anyway).
We decided, even during the blueprint discussions, that we would be moving towards re-implementing ORT in golang. For the most part the programming language shouldn't matter; we should embrace community over code and be thankful that we are addressing the issues with ORT and working to make it better.
I understand that there is a python version of ORT but IMO that is not a production piece of code and we should not continue to maintain it if we do not have to.

I understand that there is a python version of ORT but IMO that is not a production piece of code

Right, Go blows Python out of the water in terms of performance.

yeah the systemd stuff is easily removed or bypassed but, the initial goal was to transliterate the perl.

@rob05c I fixed the issue where Traffic Ops was not getting updated.

I'm merging this: it's a step toward the ORT Rewrite Blueprint, and I've tested and it seems to work as expected.
It's also fairly safe: it doesn't remove the old Perl, so users can keep using that while testing this, until we're confident enough to deprecate & remove the Perl. The only Production thing this changes is the RPM, adding t3c. I tested that thoroughly, the RPM builds and installs correctly for me, should cause no issues for anyone in production.


Feature request: download automatically

Any chance we could just select the model, and then LlamaChat downloads the necessary files automatically?

+1
I have currently downloaded 20GB+ of models, none is working -_-'

@umaar Definitely been thinking about this for the publicly available models. This won't be happening for most though because of their distribution terms 👎
@matthieu-lapeyre If there are specific problems could you open another Issue? I wonder if maybe your problems are related to #3 — I have some ideas for this in the works!

That's fair, how about a middle ground - include a direct download link to the model file, or if it's required we accept some terms, direct link to the model landing page?

yeah, I think at least for GPT4All which publish a direct download link this will work!

That's fair, how about a middle ground - include a direct download link to the model file, or if it's required we accept some terms, direct link to the model landing page?

maybe adding some more information on the Readme page, like where to download, what to download, and how to set up the environment to deploy the app. with sections for each one of the supported models(maybe some links).

@mignochrono there are some links already in-app but agreed that these could be improved. I think it would be better to improve the UI here because the plan is to add more models, which could get unwieldy if they're all documented in the README.

how to set up the environment to deploy the app

What do you mean by this exactly? Building from source, or something else?

Can someone post a short instruction on how to downlaod and install a model that worked for them?
I also had problems getting it working and this would be nice.
Having a quickstart guide on how to get your first chat running would be nice


Update install wiki with download and unzip csv + install nits

@sbenthall  I tried to install everything on a windows machine here. followed Niels' intructions, everything seems to be fine (except for Levehnstein module that requires C++ compiler v9, indeed I downloaded it)
but i get 'Error no module named...' on bigbang owns' libraries when importing them from notebooks
do you have any idea what may I be missing out? (I already successfully installed everything on my windows machine)

This is something for all of us to review at 17:30 today and possibly earlier @sbenthall @davidberra


iot2050-firmware-update: Fix env that preserved is not right

Issue:
we used this tool on the previous release image found that if there were tow identical values will be used to sort higher. However, the backward value is used on the latest image.
It is unreasonable to have two identical environment variables in the same uboot env file. So remove the same environment variables from the default list to fix this issue.
Signed-off-by: chao zeng<EMAIL_ADDRESS>

As we have discussed offline, if the env does not exist, for 1.1.1 the error must be handled.

Sorry, the commit message does not fully parse for me. Was this observed in a real setup?

Yes. it was observed on a real setup.
for the latest release image, this tool works well. but in the previous image(transitional image), it would fail.
in the default env file u-boot-init-env,  there exists one env  boot_targets,
if we want to preserve that env boot_targets, for the original design, we would append the env item to the last of  u-boot-init-env, then using mkenvimage  to create a new binary then flash to the env mtd partitions.
the problem is that if we append one that exists in the u-boot-init-env, so there would two identical env items in the same file.
Through experiment,  in the Debian bullseyes, using fw_printenv it would select the last one, so it could work as our expectation. But in the buster, it would select the previous one, we would get the wrong env.
Has two same environments in the file is not correct, so remove one

OK, makes more sense. Maybe enhance to commit log a bit (also: tow -> two).


[explorer] #3611 show address view by default if object id dne

Problem
Right now the following is shown if a user searches for a 20 bytes string that does not match with the id of any existing objects or a non-empty address.

Summary of Changes
Navigate to empty address page.
Fixes #3611

Generated summary (powered by Graphite)

What changed

Added a check to see if the input is a valid Sui address
Added logic to navigate to the empty address page if the input is a valid Sui address
Added logic to navigate to the missing page if none of the queries find a result

Impact
The diff adds logic to navigate to the empty address page if the input is a valid Sui address.
Testing
This diff can be tested by providing a valid Sui address as input and verifying that the user is navigated to the empty address page.

Thanks for opening this PR! we've reworked the search functionality so this shouldn't b needed anymore.


feat(account): Add support for (un)delegation in paratimes

Also, the new txes are not supported on Ledger. I added request for implementation: https://github.com/Zondax/ledger-oasis/issues/204

Isn't the implementation generic, supporting arbitrary method calls?

Also, the new txes are not supported on Ledger. I added request for implementation: Zondax/ledger-oasis#204

Isn't the implementation generic, supporting arbitrary method calls?

Seems not. Getting:
Error: failed to sign transaction: signer info 0: failed to sign transaction: ledger: failed to sign: Unexpected method

Also updated account display to show runtime delegations.


feat: Support more types with BloomFilterAgg

Which issue does this PR close?

Closes #1023.
Rationale for this change

What changes are included in this PR?

The other integer types just need a cast. For strings I had to add put_binary to spark_bloom_filter.
How are these changes tested?

Added more types to test for Spark 3.5+.

Marking as draft because it's complete for #1023, but I want to quickly check if I need to explain BloomFilterMightContain's support for these other types.

If I'm reading this Spark code correctly, BloomFilterAgg supports integers and string types as input, but the probe BloomFilterMightContain only supports Long.

I don't see Spark introducing any BloomFilterAggs when I run TPC-DS SF100. Maybe it's just not enough data since the initial design doc talks about TPC-DS with 3TB data set. I could play with the knobs a bit to try to trigger the rewrite in the optimizer, but I'll just call this PR ready.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.31%. Comparing base (845b654) to head (caf13bd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1039      +/-   ##
============================================
- Coverage     34.46%   34.31%   -0.15%
+ Complexity      888      887       -1
============================================
  Files           113      113
  Lines         43580    43574       -6
  Branches       9658     9643      -15
============================================
- Hits          15021    14954      -67
- Misses        25507    25548      +41
- Partials       3052     3072      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks @mbutrovich @andygrove @kazuyukitanimura


CIS Check Hide Instance' option is set to 'Yes' for Production SQL Server instances

Ensure 'Hide Instance' option is set to 'Yes' for Production SQL Server instances

Close #728


Limit carb impact predictions to 30g/h

When SMB'ing for very large meals of 120g (the maximum COB oref0 allows by default before capping it), we've seen low BG situations with lots of COB, presumably because insulin activity is so high that the liver starts storing all the incoming carbs as glycogen.  In order to help mitigate this, we want to prevent oref0 from assuming that very high current deviations will continue.  This change caps the maximum projected deviations at a rate equivalent to 30g/h for purposes of calculating COBpredBGs.  The slightly lower projected deviations slightly reduce how much it SMBs up front, and instead causes it to predict the carbs to hit a bit later on.  This does not affect UAMpredBGs, so they can start out rising faster than COBpredBGs, but are limited to 3h of total impact, so end up lower in this scenario.

This just adds a safety check, so I think it's good to merge if no objections.

30g/h seems too low to me. However, I rarely eat a single meal with more than 45g of CHO so my experience is probably not applicable here. I tend to see SMB's not occurring quickly enough.
Perhaps in this case people need to drop their maxIOB instead?

@tepidjuice what is the highest carb impact you routinely see (in mg/dL/5m) for more than 15m in a row?
We also lowered max_iob at the same time I made this change, but I don't want to rely on user-set maximums to bandaid over deficiencies in the algorithm.

I'd say up to 4 g/5m of CHO absorption would be typical giving a CHO impact of 4*csf. A typical post meal rise without insulin would be somewhere between 0.5-1.25 mmol/L/5m. But like we discussed on gitter there is a steep rise in CHO absorption which is not captured by the algorithm.
It seems like this would mainly be an issue for those on FIasp? The main advantage of SMB's is preloading insulin to prevent hyperglycaemia. In my experience delaying SMB's with novorapid would take away a lot of the benefits.
Also are you sure it is a deficiency in the algorithm? Isn't this what maxIOB is there to prevent? If you're correct is saying that:

presumably because insulin activity is so high that the liver starts storing all the incoming carbs as glycogen.

then maxIOB should be set to prevent that from occurring.
I don't know if this is would be a problem in real world use. If this gets merged and I see problems I can always change 30 to 40 or 50 on my own rig.

Thanks.  I do think there are some other interactions that come into play here.  As you noted, aggressive SMBs are mostly needed up front, when remainingCI dominates, and this 30g/h limitation on the extrapolation of current carb absorption would not have any effect.  (If necessary, remainingCI can exceed 30g/hr at its peak: this change doesn't touch that part of the algorithm.)  The maxCI we're setting here comes into play when actual observed carb impact is at its peak.  In that case, assuming that really rapid carb absorption will continue can be problematic in two scenarios, both related to large meals that won't absorb all at once at the same rate.  The first situation is where there are some fast-acting carbs in the meal, followed by slower-acting ones.  If we assume the whole meal will absorb at the rate of the fastest carbs that hit first, we might overestimate how quickly the rest of them will absorb.  The second situation is where the speed of absorption (BG impact) is actually a function of the insulin concentration (due to the liver kicking in).  That can be partially mitigated by setting maxIOB, if you know to do that, but this seems to me like a relatively costless way to do so in the algorithm as well.
I suspect you won't see this kicking in for <= 45g meals, as by the time carb absorption has a chance to ramp up to full speed, half of those carbs have already absorbed, and UAM is likely taking over anyway.  But if anyone does observe mid-meal SMBs coming too slowly on fast-absorbing meals, to the point where they're actually wanting to change this in the code, we can make it a (non-displayed) preference at that point.


Data modal

what is added new to the project

[ ] Create a new app. Give it a meaningful name.
[ ] Initialize your project with Git.
[ ] Make sure that your project has Postgres database set up.
[ ] Build your project schema.
[ ] Create and run the necessary migration files.
[ ] Table and column names should match the ERD diagram.
[ ] note: photo for users table should be a link to an image
[ ] Foreign keys should be included.
[ ] Pay attention that in posts table the column holding the foreign key to the users table should be named author_id
[ ] All columns that are foreign keys should have a corresponding index.

what is added new

[ ] ref key changed from user_id to author_id in likes table
[ ] Readme file updated


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: asherthussain sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Revert changes to framework package creation logic

#2214 included some changes to the framework package creation logic. This passed the PR build, but caused the CI build to start failing. Only the CI build runs tests against the framework package which is why the issue was not caught by the PR build.
It is not worth the time to investigate the root cause of the break, so instead I am just reverting the changes. The important part of that PR was the updates to the docs and I am not reverting that.

/azp run

/azp run


Format being skipped on view rendering

await ctx.render({ view: 'deals/category', format: 'json'}, { deals }); the category.html.tmpl is being loaded instead of category.json.tmpl file.

And fixed. https://github.com/mojolicious/mojo.js/commit/b8aa5076747a78bcee849a1485925ad5f8a53be8

when will this be released?

4 hours ago. 😉

got it and confirmed it works.


Support for LLVM 17

Nixpkgs is finally up-to-date enough for us to support LLVM 17 properly in CI; this PR makes some updates to the Nix infrastructure to allow that update (thanks @goodlyrottenapple!), and adds LLVM 17 to our set of integration tests.
Fixes #855

Blocked on: https://github.com/NixOS/nixpkgs/pull/282727


Make changing languages in GUI one button click

Is your feature request related to a problem?
The steps to change human language of GUI are given here
We should make a one-button way to do this, maybe a pull-down in prefs in the GUI...though I am not sure all of the stuff can be set after the executable has launched. We should think about that if possible to make it run-time switchable.

Strongly support this. At least the german translation is unusable and very strange/wrong in many places.
Minor: On Windows I don't want to deal with environmental vars or wrapper scripts. I also dont want to mess with the .qm/.ts files because then the installation gets broken.


#38: Add release drafter & changelog workflow

Closes #38

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev-0.2.0@abda8bb). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-0.2.0      #43   +/-   ##
============================================
  Coverage             ?   93.25%
============================================
  Files                ?        8
  Lines                ?      178
  Branches             ?        0
============================================
  Hits                 ?      166
  Misses               ?        9
  Partials             ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abda8bb...1c7af5e. Read the comment docs.


Add the Jenkins Otel Plugin Version resource attribute

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

what

Refactor the getJenkinsVersion and use the one in the OtelUtils
Add Resource Attribute for the Jenkins OpenTelemetry Plugin version.

Closes https://github.com/jenkinsci/opentelemetry-plugin/issues/258
UI

@v1v who got guidance from @trask on

https://github.com/open-telemetry/opentelemetry-java-contrib/issues/152#issuecomment-996140982

We should use OpenTelemetry.getTracer(instrumentName, instrumentVersion)
See
https://github.com/jenkinsci/opentelemetry-plugin/blob/opentelemetry-1.1.0-rc1/src/main/java/io/jenkins/plugins/opentelemetry/OpenTelemetrySdkProvider.java#L159
Could you use the OtelUtils.getOpentelemetryPluginVersion() you introduced with OpenTelemetry.getTracer(instrumentName, instrumentVersion)?