Unrecognized taskwarrior file format

Hi,
I have been using freecinc for several months now without any problems. Yesterday there was a small issue, but it was fixed.
Since the server was down, I have been unable to sync, getting the message: Sync failed.  The Taskserver returned error: 500 Unrecognized taskwarrior file format. at line 2015.
I believe the problem is with freecinc, because when I try syncing with another server there are no issues:
# Changed to inthe.am credentials
$ task sync init
Please confirm that you wish to upload all your pending tasks to the Taskserver (yes/no) y
Syncing with inthe.am:53589

Sync successful.  311 changes uploaded.
$ task
[task next]

ID Age Tag                     Recur Due  Description                                        Urg
...

But when I try to sync using freecinc:
# Trying with freecinc credentials
$ task sync init
Please confirm that you wish to upload all your pending tasks to the Taskserver (yes/no) y
Syncing with freecinc.com:53589

Handshake failed.  Error in the pull function.
Sync failed.  Could not connect to the Taskserver.

$ task sync init
Please confirm that you wish to upload all your pending tasks to the Taskserver (yes/no) y
Syncing with freecinc.com:53589

Could not connect to freecinc.com 53589
Sync failed.  Could not connect to the Taskserver.

$ task sync init
Please confirm that you wish to upload all your pending tasks to the Taskserver (yes/no) y
Syncing with freecinc.com:53589

Sync failed.  The Taskserver returned error: 500 Unrecognized taskwarrior file format. at line 2015

It's all the same data, so it makes no sense that it won't sync with freecinc, but will with other services.
I believe this is related to #3. Could my log file have been the one that filled the disk, causing it to be cut off and corrupted?

I don't think it really matters that there's only one log file; that wasn't really part of the issue. I've updated the question so that it's hopefully a little more clear what the issue is.

So you are suggesting that your account on freecinc is essentially corrupt, or otherwise unusable? And you propose that it is a by-product of the outage?

Essentially, I believe that part of my file was lost during the outage. I could be wrong, but here's what I believe happened:

I ran task sync
taskwarrior sent my log file to the server
The server began storing new log, but then ran out of room, truncating the file

Now, whenever I try to sync, I believe this is what happens:

I run task sync
taskwarrior fetches my log file from the server
taskwarrior tries to read the log file and apply the new changes
Because the log file was truncated, the file is corrupt and unreadable

This is just my educated guess, based off of it failing to sync to freecinc, but syncing perfectly fine with other services.

@davisdude Are you requesting your account be reset somehow?

That's what I assume would be needed, though I know on the website it's mentioned that there is no option to "delete my account," so I'm not sure how possible it is.

@davisdude what's your username? I'll try deleting it.

I suppose it would be more correct to say there is no automated way to delete your account.

I'm not sure what you mean. I don't think I had to make a username when creating the account; as far as I remember, I just generated the cert, key, and ca and that was it.

@davisdude Can you send me the filename of one of your freecinc certs? For example, mine is freecinc_1fc768cb.cert.pem. Everything before the "cert.pem" is your username.

Ah, got it. Mine username is freecinc_a4918972

@davisdude Your suppositions appear to correct. Here is the last line of your tx.data:
{"description":"<>","due":"<>","entry":"<>","modified":"<>","status":"pending","tags":[<>],"uuid":"6c346ddc-6114-412e-a91a

The "<>" are sections I removed for privacy reasons. But the line is clearly unfinished. It ends partway through a (36-character) uuid.
Anyway, I've renamed your tx.data file so taskd will (likely) recreate it when you sync again. Let me know how that goes.

That did it, thanks! :+1:

It appears that most of the format is expected to be JSON, except for the last line which is simply an uuid.
This command prints the last line of each account's tx.data file, which is expected to simple be an uuid. If it's not, it probably is corrupt by the same fashion.
tail -n 1 */tx.data

Found five other accounts with incomplete last lines, and repaired them.


change colors to be handled inside scss

This PR changes the way colors are used in the scss files.
Now, we can just use color: spiceColor(text); which basically translates to color: var(--spice-text);.
Or color: spiceColor(text, 0.5); which translates to color: rgba(var(--spice-rgb-text), 0.5);.
This also generates color.ini based on this and sets the initial colors as css variables.
The reason for this change is just me being lazy and wanting vs code to auto complete those kinds of variables, as using the var(--xxx) doesn't autocomplete because the vars are only set by spicetify / js.
I haven't changed the styles to actually use spiceColor() because I'm working on some styles, and don't want to commit this both at the same time, that's why this is a draft. Otherwise this is done

Make sure you delete original color.ini

I have

My bad, couldn't see it from android app. Time to go to bed!

No problem.
Good night!


Improvement Agri-PV EEG-Price

Moreover, the EEG prices are only constant for a defined period of time after conclusion of the contract. This was disregarded in our case. For this, an electricity price development analysis could be carried out and provided with a risk.
Electricity is traded on the stock exchange..

in the "value varier function" you could also simply use the option "absolute_trend =" or "relative_trend =" and thus more easily integrate a trend in the electricity price in the code :D


Error with order not going through and program crashing

It successfully places an order on Bitfinex, but when it places it on Kraken the order seems to go through but then the program crashes at the end.
What's going to be the future fallback incase one order doesn't go through?
What about the program crashing?
What's the recommended manual steps for when an order doesn't go through? (Revert orders and start program again?)
[ 07/25/2017 21:07:18 ]
   Bitfinex:    2,544.8000 / 2,546.6000
   OKCoin:      2,659.4400 / 2,672.2000
   Bitstamp:    2,533.5200 / 2,535.0000
   Kraken:      2,497.1400 / 2,516.3410
   ----------------------------
   OKCoin/Bitfinex:     -4.77% [target  0.80%, min -5.98%, max -3.82%]
   Bitstamp/Bitfinex:    0.39% [target  0.80%, min -0.86%, max  1.77%]
   Kraken/Bitfinex:      1.13% [target  0.80%, min -0.93%, max  1.48%]   trailing  1.40%  1/1
<Bitfinex> Looking for a limit price to fill 0.023078 BTC...
<Bitfinex> order book: 1.664482@$2,546.30

[ ENTRY FOUND ]
   Date & Time:       07/25/2017 21:07:18
   Exchange Long:     Kraken (id 3)
   Exchange Short:    Bitfinex (id 0)
   Fees:              0.26% / 0.20%
   Price Long:        2,514.00 (target)
   Price Short:       2,546.30 (target)
   Spread:            1.13%
   Cash used:         58.73 on each exchange
   Exit Target:       -0.29%

<Kraken> Trying to send a "buy" limit order: 0.023339 @ $2,514.00...

Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
Cloudflare Ray ID: 38421695ab8b23a8
•
Your IP: <IP_ADDRESS>
•
Performance & security by Cloudflare

  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
Error with cURL: Timeout was reached
  URL: https://api.kraken.com/0/private/AddOrder
  Retry in 2 sec...
{"error": ["EService:Unavailable"]}

same issue - anyone any ideas?
Kraken seems to be having cloudflare issues and issues with their API...
Any pointers?


Older vsts-python-api packages have unconstrained upper dependency on msrest

Comment:
With the new mamba dep solver, I am seeing very aggressive attempts to install older packages with unconstrained dependencies.  In this case, it is finding older vsts-python-api releases with a dep of msrest >=0.5.0.  I'll PR a metadata patch to constrain these to <0.6

While we should update these packages metadata, it is odd that this regression is creeping up.

Thanks for the repodata patch merge, I am not reproducing the issue locally anymore.


[ACR] Adding StatusZero error docs for listing repos or tags

@ankurkhemani could you please review this PR?

@hkuadithya : Thanks for your contribution! The author(s) have been notified to review your proposed change.

/cc @dlepow

@hkuadithya : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@sajayantony - Would you review the proposed changes and indicate whether you approve the PR to be merged? Thanks.

@hkuadithya : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hkuadithya : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hkuadithya : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dlepow  Please merge this PR if everything looks good. The two reviewers from my team have approved the PR.


Replace all "--" with "—" in dialogueAutoCorrect

Currently "--" characters are replaced by the "—" character when they occur at the beginning of the text line.  It would be good if all consecutive occurrences of "--" were replaced as well, so that following text:
-- Hi -- he said. -- I'm looking at you.
should be auto modified into:
— Hi — he said. — I'm looking at you.

In some languages, the dialogue marker should be em-dash — and it is used only at the beginning of a sentence. All other markers are en-dash character, that is a bit smaller –.
I thing the best way to address this is to provide an additional option, that handles replacements of inner -- characters to either em-dash or en-dash.

An options is added to handle beginning of line and rest of the line replacements


how does this differ from lodash?

hi, ercmnn.
i am just confused, how does this differ from lodash?

Mostly in the syntax. You can do all this with lodash if you like. Its a convenience for Laravel users, from what I understand. :) I'll let @ecrmnn answer officially, though.

Hi, Afghl.
As @mikebronner said it's mostly in the syntax. Collect.js is a JavaScript port of Laravel collections. You can use lodash or underscore if you'd like, but if you want a similar way to work with arrays/objects on your backend and frontend this is a nice way to achieve that.


Disk Array Restructuring

To support bypassing the WAL when writing new pages to disk arrays (an important performance optimization for #2938), it will be necessary to track the end of the file within the file itself. Currently, new pages are added by using the filehandle's page counter. As a consequence of this, allowing writes to bypass the WAL will mean that any pages written as part of an aborted transaction will not be re-used. If a page counter is stored in the file, then as long as updated pages are written to the WAL (which will always include the header), we can truncate or overwrite untracked pages since the page counter won't be modified when pages are appended directly to the end of the file.
I think the best way to handle this is like what I'd done in the disk overflow file (#2857), that is, having a parent collection which stores a header tracking the number of pages.
This also provides an opportunity for some optimizations, as the parent collection can handle writing the headers instead of needing to allow each disk array to write its own header independently. Currently, disk array headers are 48 bytes and stored in their own pages. This is somewhat inefficient and leads to some bloating (E.g. 255 unnecessary pages in the hash index file: see #2625).
If we cut down what's being stored in the disk array headers to the bare minimum, we should be able to fit 256 headers into a single page:
For each array, we need to store:

numElements (8 bytes)
firstPIPPageIdx (currently stored as an 8 byte int, but really it's a page_idx_t, which is 4 bytes)

All other properties are either derived, or in the case of the element size, are known at compile time (it might be a good idea to include the element size anyway as a sanity check; it could be stored in 2 bytes, since elements cannot exceed the page size, or one if we store the alignedElementSizeLog2).
Global data:

Number of arrays (uint32_t is sufficient given that the number of arrays is constrained by the size of firstPIPPageIdx)
page counter (4 bytes)
Page index of the next header page (4 bytes; header pages are always read, so there's no disadvantage to storing them as a linked list).

This is sufficient to store headers for (4096 - 12)/12 = 340 arrays per page, and leaves 3 extra bytes per array header which could be used for additional data while still storing the 256 hash index headers in a single page.
Currently, disk arrays are initialized using a header page index. That would just be changed to a header index, as it no longer refers to a specific page, but remains fundamentally the same.

On reflection, it might make sense to add WAL records noting that pages have been added to a file other than the WAL. Like the page update/insert record but without actually storing or writing the page. That would still have some overhead, but if it stores a range of pages it could be done with a single record.
Then the file could be truncated if the transaction is rolled back.

Fixed by #3557 (with the exception of handling truncating the file on rollback, but that's a missing feature more broadly speaking).


Reverted the changes which possibly has caused error #2111

Fixes #2111
Checks

[x] Ran yarn test-build
[x] Updated relevant documentations
[x] Updated matching config options in altair-static

Changes proposed in this pull request:
Reverted the changes which possibly has caused error.

Thanks! If we checked for window?.chrome?.runtime?.id would that also work? I can't figure out any other reason why that should throw an error

I think it should work.

I've confirmed that that fixes it

Updated

I don't think you pushed the changes?

I did push.


add list method for  threads object

Confirm this is a feature request for the Python library and not the underlying OpenAI API.

[X] This is a feature request for the Python library

Describe the feature or improvement you're requesting
It seems that there's an undocumented GET endpoint for the threads in the underlying OpenAI API that can list all the treads. It's convenient for developers to see all the threads since this can't be done in the Assistants page in the playgound site.
Additional context
No response

If and when that endpoint becomes officially documented, this library will support it.

There is also an issue with not being able to remove threads that were created during test runs. Currently, there is no way to access previous threads either from UI or from API. This is incredibly frustrating.

@BernardasJuzumasBiomapas this might be help to find out all the threads you created.
def list_threads(api_key):
    response = requests.get(
        'https://api.openai.com/v1/threads?order=desc&limit=20',
        headers={
           'Content-Type': 'application/json',
            'Authorization': f'Bearer {api_key}',
            'OpenAI-Beta': 'assistants=v1'
        }
    )
    if response.status_code == 200:
        return response.json()['data']
    return None

@BernardasJuzumasBiomapas this might be help to find out all the threads you created.
def list_threads(api_key):
    response = requests.get(
        'https://api.openai.com/v1/threads?order=desc&limit=20',
        headers={
           'Content-Type': 'application/json',
            'Authorization': f'Bearer {api_key}',
            'OpenAI-Beta': 'assistants=v1'
        }
    )
    if response.status_code == 200:
        return response.json()['data']
    return None

Thanks!
Not sure if this is just me, but I am not allowed to use the API key to perform this query. Had to get my session key from the browser UI to make it work.

I think someone disable it. The response status code is 401.

Accessing the endpoint outside a browser session is blocked by the server now.

this issue is still happening

Same here


feat(github): add cmx testing github action examples

add simple version of how to create cmx cluster and test the helm install
add complete version of how to create cmx cluster and test the helm install for user to customise

demo1 (complete mode): https://github.com/replicated-collab-dev/platform-examples/actions/runs/10106334694
demo2 (simple mode): https://github.com/replicated-collab-dev/platform-examples/actions/runs/10135602397
Related PR: https://github.com/replicatedhq/replicated-actions/pull/71

Thank you @diamonwiggins. I have updated the PR to reflect the changes


Enable CORS using rack-cors

This allows XHR requests from the client app.

:+1:

This looks pretty straight forward, what do you think @lasley ?

Simple enough 👍


Disable autofill year in dd.mm.yyyy input mask

Is there any setting to disable the autofill feature of the year?
Whenever I input a date, for example: 01.01.2020. and I have written 01.01.20, the second part of the year 20 is automatically filled, triggering the oncomplete handler. However, this causes a problem with the current implementation that I have. Is there a workaround for this?

The problem was with the environment, not with the mask.


Test color in pytest

With pytest, the conclusion of the black_shape_is_not_taken_when_it_has_a_liberty is in red when it is successful and green when it is failed. Very disturbing when you only look at the color 😄

With pytest, the conclusion of the black_shape_is_not_taken_when_it_has_a_liberty is in red when it is successful and green when it is failed. Very disturbing when you only look at the color smile

Can you provide an exemple/screenshot/link please ?

Done

With and without the marker @pytest.mark.xfail

With and without the marker @pytest.mark.xfail

Not sure to understand what you want/talking about, come to discord to discuss directly about "this" ^^


Add issues

As the maintainer of a Collaborate repo, keeping Issues up-to-date will help the student community understand what they can do to contribute. Issues should vary by the easy (update documentation) to the difficult (add a new feature). The more involved you are, the more opportunities there are to collaborate.
Recommendations:
Add issues of varying difficulty to the repo often. you can add the tag GSSoC'24, good first issue etc.
Generate issues even if you plan on solving them, so the repository appears as active.
Contribute/commit often to the repo so it does not go stale.
Reference https://github.com/Recode-Hive/Stackoverflow-Analysis/issues

I want to contribute in your project some areas need improvement like:

there should be hover effect on icons
there should some space on text (why krishi connect)
there need some colour in sq box for more effectiveness
please could you assigned it to me?


a multi-cluster node authorizer for ambient mesh

Co-authored-by: zhlsunshine<EMAIL_ADDRESS>Co-authored-by: osswangxining<EMAIL_ADDRESS>Please provide a description of this PR:
This PR fixes https://github.com/istio/istio/issues/47489. It adds an implementation of a multi-cluster form of node authorizer, which allows node authorizations for CSRs with impersonate identity from remote cluster. This could help istio CA to authenticate ztunnel in remote clusters in an external control plane scenario.
This PR also supplies some e2e test cases for node authorization scenario.
Please refer to https://docs.google.com/document/d/10uf4EvUVif4xGeCYQydaKh9Yaz9wpysao7gyLewJY2Q/edit?resourcekey=0-6i9VYHbp91h6Avy6syu_oA#heading=h.xw1gqgyqs5b for more details.

Hi @delavet. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Everything in Dynamo category will be kept as is for now.

Problem that occurs
Classes and methods become visible in Dynamo even though they are not dynamo facing. This might happen as someone is developing a class or method in FemDesign.Core - as Dynamo defaults to visible this class or method will be automatically made visible in Dynamo.

Originally posted by @andosca in https://github.com/strusoft/femdesign-api/issues/120#issuecomment-957306963

No longer relevant.


Add AC references to association tests

We want to start integrating ACs with Cypress tests.
This may require tests to be rewritten or new tests added to fit with the ACs
ACs can be found in:
https://github.com/vegaprotocol/specs/blob/62af5e047880327ba39998aed60b786d50030d80/user-interface/1000-ASSO-associate.md
For now we can reference ACs by adding comments next to tests with the AC ids
Tool for measuring coverage:
https://github.com/vegaprotocol/approbation

There are following ACs missed that should be covered by separate flows:

if the connected ethereum wallet has vesting tokens: must be able to select to associate from either the vesting contract or the wallet 1000-ASSO-0006
must be warned if the amount being associated is greater than the amount 1000-ASSO-0010
If some of the tokens for the given eth key are held by the vesting contract: must select to return tokens to Vesting contract 1000-ASSO-0024

Following ACs are missed and can be covered by putting validations into the flows, or by creating specific state in vegacapsule and then running through validations:

must see feedback whether my association has been registered on Ethereum 1000-ASSO-0012

must see feedback that the association has been registered by Vega and that it can be used after the number of Ethereum block confirmations required (typically 50) 1000-ASSO-0013

on completion: should be prompted to go on to nominate and/or participate in Governance 1000-ASSO-0030

must see a list Vega keys that the connected Ethereum wallet has associated too 1000-ASSO-0019

must see an amount 1000-ASSO-0020
must see the full Vega public key associated too 1000-ASSO-0021
must see the the origin of the association: wallet or vesting contract 1000-ASSO-0022
Should be able to select one row to populate disassociate form 1000-ASSO-0023

should be warned that disassociating will forfeit and rewards for the current epoch and reduce the Vote weigh on any open proposals 1000-ASSO-0026


Add ability to update certain link constants in the google sheet

This adds a new google sheet table that should be named "Constants" and contain 2 columns: name, value. When a command is performed that would normally display a link from one of the specified constants, the code will instead try to load the constant from the constants tab of the google sheet.  If successful, the loaded value will be used instead of the value from constants.py.  The format of the "constants" tab is column A is a name that would match a constant name from constants.py, and column B is the value of the constant.  Database related python files added/updated to support the new table. bot_helpers/get_constant.py adds a new method for retrieving the database constant.  main.py altered to update the commands to use the get_constant() method.
The following constants are supported:
LINK_ACCUMULATED_POINTS
LINK_ACTION_LIST
LINK_BOT_COMMANDS
LINK_BOT_INSTRUCTIONS
LINK_CALENDAR_EU
LINK_CALENDAR_NA
LINK_DISCORD_CHANNEL_EML_COC
LINK_DISCORD_CHANNEL_EML_SUPPORT
LINK_DISCORD_CHANNEL_EML_TICKETS
LINK_ECHO_VR_LOUNGE
LINK_ECHO_VR_LOUNGE_TICKETS
LINK_EML_WEBSITE
LINK_LEAGUE_MATCHES
LINK_LEAGUE_ROSTER
LINK_LEAGUE_RULES
LINK_STAFF_APPLICATION
LINK_TEAM_RANKINGS

Looks good to me.


add 4-basics

I did it this way because I didn't have time
tomorrow I will try to do it from DOM

Please fix linter errors

Hey @DavidTereshchenko great job! I like it) For the future get HTML elements by data-attributes, like data-result, because somebody can remove your class to fix css and broke the logic

ok, I'll pay attention to that, thanks


build(autoware.repos): remove ament_cmake fork repository

Description
When I compiled the Autoware repository, several warnings appeared.
WARNING:colcon.colcon_core.package_selection:Some selected packages are already built in one or more underlay workspaces:  'ament_cmake_core' is in: /opt/ros/humble ...
I found the ament_cmake has a local version in src/universe/external/ament_cmake, and ROS-humble also has another version.
After a period of investigation, I found the following comment in the file autoware.repos
universe/external/ament_cmake: # TODO(mitsudome-r): remove when https://github.com/ament/ament_cmake/pull/448 is merged.
The ament_cmake pr/448 has been merged on Mar 30, so the ament_cmake local version may need to be removed.
Tests performed

I checked the changed files by  ament_cmake pr/448, the current ROS-humble distribution has already merged this modification.
/opt/ros/humble/share/ament_cmake_libraries/cmake/ament_libraries_deduplicate.cmake
/opt/ros/humble/share/ament_cmake_libraries/cmake/ament_cmake_libraries-extras.cmake.
Effects on system behavior

The compilation warnings have been eliminated.
Interface changes
Nothing changed.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I see, also the humble backport PR was merged in 2024-07-16 too:

https://github.com/ament/ament_cmake/pull/530

Thank you!

(^_^)


Cannot import fuse.js library

Hey guys,
Mentioned it in gitter a couple days ago, still haven't been able to get a workaround so I figured I'd open an issue so we can track it.
I'm unable to import this package: http://fusejs.io/
Seems like it's causing havoc in the import and errors out with Uncaught (in promise) Package not found fuse.js
@nchanged tried your solution of creating an imports file, that didn't work either. Let me know if I can get you some more diagnostic info. Thanks!

Interesting, It uses the webpack UMD wrapper...

I think it's the .js part causing it to mess up, since I've not had this kind of issue with any other package.

@mattoni could you provide a small demo repository? It would be a huge help for us to try and find out what is causing the problems.

what is funny is that i cant install it with npm i fuse.js as there is already file fuse.js in my project!

after installing with npm i<EMAIL_ADDRESS>and importing using import * as fuse from "fuse.js"; there is no error, but lib is undefined

ok i confirm, i renamed the fuse.js folder in node_modules to fuse and imported it as import * as fuse from "fuse"; and now i can console log it and see it

problem is i can't do that if i want the typescript definitions from definitely typed :/ let me know when there is some progress on this :)

FuseBox v4 Major Upgrade
As of today, the latest major version of FuseBox v4 is available in fuse-box@next. FuseBox has undergone a full re-write from scratch, learning from its mistakes in the previous versions.
There are a lot of improvements, speed and config wise.
Get started here
We are still working on the documentation and polishing before the major release. We are getting very close. And we need help testing.
npm install fuse-box@next

Most of the issues that I am closing have been resolved, however, if you find that your issue is still relevant in v4 don't hesitate to re-open or (better) create a new one with v4 configuration.


Feature/simulator

PR for Feature Simulator.
PR Status
IN DEVELOPMENT
Changes proposed in the pull request:

Adds a simulator which allows you to execute your Wombat's code (and modify it).
Adds step button which increments the current step.

Screenshot of feature:

@emilyseibert @oconn @dehli

Gonna go ahead and merge this so we can get the new QA build out. If there's any other changes you'd like, let me know.


[DisplayList] consider caching the DlRegion inside DlRTree

For context: https://github.com/flutter/engine/pull/42552#discussion_r1228567586

Fixed via https://github.com/flutter/engine/pull/42620


Fixes Scroll Bars on pop-up.

This fixes https://github.com/keithamus/LinkyPass/issues/21.

@Zoltu great work! Thanks!


This PR:

Adds a new framework topic to the Hydrogen docs that does the following:

Describes the analytic events that Hydrogen emits by default
Explains how to subscribe to events, configure custom events, send analytic data from the server side, and unsubscribe from events

Relates to https://github.com/Shopify/shopify-dev/pull/17920, https://github.com/Shopify/hydrogen/pull/890, https://github.com/Shopify/hydrogen/pull/1016, https://github.com/Shopify/hydrogen/pull/934, and https://github.com/Shopify/hydrogen/pull/1029

Tophatted

@wizardlyhel These are the source docs that correspond with https://github.com/Shopify/shopify-dev/pull/17920 and the work you've been doing in https://github.com/Shopify/hydrogen/pull/890. Open to any feedback!

@wizardlyhel These are the source docs that correspond with https://github.com/Shopify/shopify-dev/pull/17920 and the work you've been doing in https://github.com/Shopify/hydrogen/pull/890. Open to any feedback!

Do you think this flow chart would be useful in this doc?
Analytic data flow diagram

@wizardlyhel I think it would be useful! I can look into incorporating that as part of the doc.

Hello.
I've set up a vanilla "Demo Store - Typescript"... followed the first part of this tutorial "Subscribe to an Event"... and expected the "payload" to be logged to the console... but nothing got logged.
Has this tutorial been recently tested against the Demo Store? I can't get anything to log following this tutorial, nor using the EventsListener.client.tsx which is already built into the Demo Store.
I don't doubt I'm doing something wrong and/or having a fundamental misunderstanding...
TY!

Hey @wizardlyhel! 👋  Would you be able to help out @grichards with the question above, and work with Ren on any docs updates that are required?


Local attention with two-sided window (non-causal)

Hi!
Thanks for adding causal local attention (left)! Would it be possible to support local attention with both window_size_left > 0 and window_size_right > 0 (right)? For the case where window_size_left == window_size_right.
This would be incredibly useful for large input sets where causality is not requred.
Many thanks.

It's already supported. You can just pass in window_size=(3, 3) for the example on the right.

Great thank you for the clarification. I read the or here as exclusive.


Message connection system

Support message connections on actor declarations, but not modifying dynamically the connections. For the first version is enough.


Fighters not fighting

Despite following the instructions on how to run llm-colosseum in the README and trying make run , make local and make demo executions (still following instructions exactly) the window pops up and the players just sit there and the clock ticks to zero. Then the console defaults to Player 1 always winning despite no actual winners. What am I not doing or doing wrong?
P.S. Is there a Discord for this project?

Here's the output i'm seeing in the terminal
🏟  (b18f) (0)Starting game
🏟  (b18f) (0)Waiting for fight to start
2024-08-07 09:37:46.525 Python[54119:2568961] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.
Exception in thread Thread-5:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
Exception in thread Thread-6:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
    self.run()
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/eval/game.py", line 369, in run
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/eval/game.py", line 383, in run
    self.game.player_2.robot.plan()
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/agent/robot.py", line 134, in plan
    self.game.player_1.robot.plan()
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/agent/robot.py", line 134, in plan
    next_steps_from_llm = self.get_moves_from_llm()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/agent/robot.py", line 293, in get_moves_from_llm
    next_steps_from_llm = self.get_moves_from_llm()
    llm_stream = self.call_llm()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/agent/robot.py", line 293, in get_moves_from_llm
                 ^^^^^^^^^^^^^^^
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/agent/robot.py", line 369, in call_llm
    llm_stream = self.call_llm()
                 ^^^^^^^^^^^^^^^
  File "/Users/ken/PROJECTS/DIAMBRA/llm-colosseum/agent/robot.py", line 369, in call_llm
    resp = client.stream_chat(messages)
           ^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'stream_chat'
    resp = client.stream_chat(messages)
           ^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'stream_chat'
🏟  (b18f) (0)Round won by P1
(0)Moving to next round
 Player1 mistral:mistral-small-latest 'Baby' won!
🏟  (b18f) Closing console
🏟  (b18f) (0)----------------------------------------
(0)   Thank you for using DIAMBRA Arena.
(0)   RL is the main road torwards AGI,
(0) better to be prepared... Keep rocking!
(0)                   -
🏟  (b18f) (0)          https://diambra.ai
(0)----------------------------------------

Hello !
Looks like this error was related to : https://github.com/OpenGenerativeAI/llm-colosseum/issues/62
I pushed your suggested fix : renaming ollama.py to local.py
Thank you for figuring this out !
For the Discord, we hang out on the Diambra Discord : https://discord.com/invite/jDcW8z4gft
My user tag is roger_jacques

#62 does fix the issue for make local. However, the issue still remains when using remote models.

What is the error message you encounter when using remote models ?
Client is also None ?

What is the error message you see when using remote models ? AttributeError: 'NoneType' object has no attribute 'stream_chat' ?

Yes, that's the one.

Okay, I understand now.
This is my fault, I merged a PR 5 months ago that refacto'd this and removed mistral from the list of supported models. I changed this on main https://github.com/OpenGenerativeAI/llm-colosseum/pull/68
Can you please follow the following instructions:
0. Fetch the latest version git checkout main, then git pull

Create a new python virutal environment python -m venv env
Activate the env source env/bin/activate (if you're on Windows, the command is different)
Install requirements with make install. If this doesn't work, do pip install -r requirements.txt
Try first to run with openai: make run (You need to create a .env file with an OpenAI API key, and you need Docker installed and running)
Launch Ollama locally (ollama), install the mistral model (ollama run mistral), then run make local to launch local version

Tried all of this on my machine and it worked fine.
So I'm not sure which step actually fails for you.
As you see, there is a lot of setup and Python gotchas.
Please tell me if it works now. If it still fails, please tell me at which step.
Feel free to book a call with me here: https://cal.com/nicolas-oulianov
We'll get to the bottom of this!!!!!

I cannot currently test the make run against the gpt-4o models defined in script.py but the make local works. Do you know anyone else that can test the make run?
Also note that Podman works as a great open source alternative to Docker. That's what I've been using.

I'm getting this error when running make demo:
ModuleNotFoundError: No module named 'llama_index.llms.mistralai'
    from llama_index.llms.mistralai import MistralAI
ModuleNotFoundError: No module named 'llama_index.llms.mistralai'
2024-09-16 18:51:54.698 Python[60482:257677] +[IMKClient subclass]: chose IMKClient_Legacy
2024-09-16 18:51:54.698 Python[60482:257677] +[IMKInputSession subclass]: chose IMKInputSession_Legacy

Did you run make install before running make demo ?
From the error, you are missing the package llama-index-llms-mistralai. Running make install will install it for you

Did you run make install before running make demo ?
From the error, you are missing the package llama-index-llms-mistralai. Running make install will install it for you

Good catch it was the lack of make install. Somehow I got caught with a new venv and didn't do the install again. So I got make demo to work but ran into a paywall with the Free Mistral tier:
INFO:httpx:HTTP Request: POST https://api.mistral.ai/v1/chat/completions#stream "HTTP/1.1 429 Too Many Requests"


Dynamic library

As promised, I have attempted to port this library to vcpkg: microsoft/vcpkg#27839
The good news that it works for all the static triplets.
The bad news that it doesn't work for the dynamic triplets.
So what was needed was to set the property WINDOWS_EXPORT_ALL_SYMBOLS to on, so the DLL builds correctly.
As executables in windows lack rpaths, the test executable and DLLs are now placed in the same build directory.
The CI needed to be changed to reflect the changed test binary directory.
The SOVERSION property is set for linux dynamic libraries.
Note that the option BUILD_SHARED_LIBS is still off by default, as this library is intended to be a static library.
Also there's a commit to fix this for 32-bit builds.

Once again, awesome PR, thanks a lot :) Once merged, the last step will be to make a PR on the vcpkg repository right ?

I've already made a PR: https://github.com/microsoft/vcpkg/pull/27839
However yes, once this is merged, I can rebase that PR and finalise it.

@Sygmei Are you going to merge this?

Merged :) Thanks again


Switching to a sprite focuses on most recent block comment

Expected Behavior
Selecting a sprite should not select/focus on any of the comments.
Actual Behavior
If there are any block comments on a sprite you switch to it will add a blinking cursor to the comment.  If the project is controlled by keyboard keys you could end up typing in the comment.
Steps to Reproduce
Create a project
Add a second sprite
In one sprite drag a block onto the workspace
right click the block and add a comment
type something in the comment
Switch to the other sprite
switch back
Note: the cursor is on the comment.
Note: This is not the case with workspace comments.
Note: if there is more than one block comment it will highlight the newer one.
Operating System and Browser
Chrome on Mac

/cc @kchadha

Related to this (I believe) @ericrosenbaum found the following issue in a smoke test on 6/8:

On android chrome, loading a project with a comment enables the soft keyboard on load (but not 100% of the time?)


Decide on a kotlin SDK publishing solution

Currently using jitpack, not viable in the long term.
Context: https://sq-tbd.slack.com/archives/C05SXUR39FE/p1696907744806279, https://github.com/TBD54566975/web5-kt/issues/68

There is an ongoing effort related to supply-chain security run by @ALRubinger and @leordev that has overlap with this. Links to this doc will be shared in our internal discussion channel.

Landed on maven central


One FLMD file per data file or data package?

Submitter: Kim Ely
I suggest the following changes:
It is unclear from the instructions whether a FLDM file is required per data file, or per package.
"Create file-level metadata for each data file using the template.
    a. Start new row for each data file"
One FLMD file per package, with a row for each data file makes sense to me. A separate FLMD file per data file would be onerous for data creators, and perhaps not useful for users.
My suggested correction would be to update the instructions to: "Create file-level metadata for each data package using the template."

@regnans Good catch. It should be per data package.
@robcrystalornelas Can you make the change that Kim points out?

@regnans Good catch. It should be per data package.
@robcrystalornelas Can you make the change that Kim points out?

@tvelliquette I can definitely make the changes. Thanks @regnans for catching this, and for making suggestions on how we can update the instructions.

@tvelliquette I can definitely make the changes. Thanks @regnans for catching this, and for making suggestions on how we can update the instructions.

Thanks to Kim's suggestion, text in the instructions file now indicates we only need one FLMD file per data package


Incorrect Analytic calcluations.

Describe the bug
I believe the logic on some of the analytic rules may be incorrect. For example "SharePoint_Downloads_byNewIP" but others using similar logic.
In particular, I find the below method of calculating a "baseline" to be incorrect. I believe to achieve the desired effect, there should be some form of bin/bucketing the time by 1 day (since the recent counts are calculated by 1 day intervals in the searches). The first summarize to get a Count is performed over a 13 day period (-14 to -1 days) across only UserId, Operation, Site_Url, ClientIP. This is the total count. Then, the second summarize takes the average of that count over the same fields, which is just that count, not an average over any period of time. This makes the baseline average calculation incorrect.
  let userBaseline = OfficeActivity
  | where TimeGenerated between(ago(starttime)..ago(endtime))
  | where RecordType =~ szSharePointFileOperation
  | where Operation in~ (szOperations)
  | where isnotempty(UserAgent)
  | summarize Count = count() by UserId, Operation, Site_Url, ClientIP
  | summarize AvgCount = avg(Count) by UserId, Operation, Site_Url, ClientIP;

The solution:
Use a bucket for time of 1 day spans and the first summarize should count by those time buckets. Then the second summarize will effectively average out the count.
I believe there are other analytics in this repo using this same or similar logic. They would all have the same issue.

Hi @CyberGumShew , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates. Thanks!

Hi @CyberGumShew , Just to confirm, you would like me to modify the SharePoint_Downloads_byNewIP analytic rule to calculate the baseline average count of file operations correctly.
Specifically, you want me to:

Use 1-day time buckets to count the file operations.
Calculate the average count of the file operations over these 1-day time buckets.

Is that correct? Please let me know if I've understood your request accurately.

That is what I perceive as the intent of the detection but I would defer to the original author of the rule if that is a misunderstanding.

Hi @CyberGumShew , Sorry We are still not getting your request. It would be really great if you could give more descriptive on this issue. It would be really helpful for us if required to reach out to query author and share these details.
Based on your issue description we have modified the below query to meet your expectations:
let userBaseline = OfficeActivity
| where TimeGenerated between(ago(starttime)..ago(endtime))
| where RecordType =~ szSharePointFileOperation
| where Operation in~ (szOperations)
| where isnotempty(UserAgent)
| summarize Count = count() by UserId, Operation, Site_Url, ClientIP, bin(TimeGenerated, 1d)
| summarize AvgCount = avg(Count) by UserId, Operation, Site_Url, ClientIP;

Yes, I believe that would meet the intent of the detection.

Hi @CyberGumShew,
We have noted your point and will share it with the concerned team for analysis. However, as this request is specific to you, you can modify the analytic rule while configuring it:
| summarize Count = count() by UserId, Operation, Site_Url, ClientIP, bin(TimeGenerated, 1d)
| summarize AvgCount = avg(Count) by UserId, Operation, Site_Url, ClientIP;
This rule will help you achieve the desired results.
As of now we are closing this issue. If you still need support for this issue, feel free to re-open it any time.
Thank you for your co-operation.


patch for rtp message

Codecov Report

Merging #48 (07acafb) into master (4ceba23) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 07acafb differs from pull request most recent head cdadbe1. Consider uploading reports for the commit cdadbe1 to get more accurate results

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   98.83%   98.83%
=======================================
  Files          73       73
  Lines       12124    12124
=======================================
  Hits        11983    11983
  Misses        110      110
  Partials       31       31

Impacted Files
Coverage Δ

pkg/pacs_v08/pacs.go
90.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ceba23...cdadbe1. Read the comment docs.


[Java Script Issue][chromedp]

I face the issue to generate the graph correctly on aws server using chromedp. its working fine on my mac
i have check the chrome version on server .chrome version is same on both server and mac.
when i pass 0 value to my java script function they cannot generate graph but on server on 0 graph is appear.
Can some one please help me why this happen is there is a different way to handle java script etc.
Google Chrome 89.0.4389.90 version on server
Please find complete
untitled.html.zip
html file in attachment for testing thanks
must pass value to js function between 0 and 1

Could you please provide the info of the instance on AWS?

According to #785, it seems that you finally managed to make it work on AWS. Closing this one now.


How to use \<any> feature?

INSTRUCTIONS
Before submitting a new issue, please follow the checklist and try to find the answer.

[x] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[x] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[x] I have searched the issue tracker for a similar issue and not found a similar issue.

\<any>: escape <any> character means that drop backslash symbol and only use <any> character

How to use \<any> feature?

@murphyzhao this feature is suitable for special user scenarios.
please see as https://docs.espressif.com/projects/esp-at/en/latest/AT_Command_Set/TCP-IP_AT_Commands.html#cmd-sendex.

Get, thanks


Failed to load audio: ffmpeg: error while loading shared libraries:

Hi!
Many thanks for the brilliant work!
When executing demo_part1.ipynb step 4:
reference_speaker = 'resources/example_reference.mp3'
target_se, audio_name = se_extractor.get_se(reference_speaker, tone_color_converter, target_dir='processed', vad=True)

I received the following error:

CalledProcessError                        Traceback (most recent call last)
File ~/miniconda3/envs/openvoice/lib/python3.9/site-packages/whisper/audio.py:58, in load_audio(file, sr)
57 try:
---> 58     out = run(cmd, capture_output=True, check=True).stdout
59 except CalledProcessError as e:
File ~/miniconda3/envs/openvoice/lib/python3.9/subprocess.py:528, in run(input, capture_output, timeout, check, *popenargs, **kwargs)
527     if check and retcode:
--> 528         raise CalledProcessError(retcode, process.args,
529                                  output=stdout, stderr=stderr)
530 return CompletedProcess(process.args, retcode, stdout, stderr)
CalledProcessError: Command '['ffmpeg', '-nostdin', '-threads', '0', '-i', 'resources/example_reference.mp3', '-f', 's16le', '-ac', '1', '-acodec', 'pcm_s16le', '-ar', '16000', '-']' returned non-zero exit status 127.
The above exception was the direct cause of the following exception:
RuntimeError                              Traceback (most recent call last)
Cell In[4], line 2
1 reference_speaker = 'resources/example_reference.mp3'
----> 2 target_se, audio_name = se_extractor.get_se(reference_speaker, tone_color_converter, target_dir='processed', vad=True)
File ~/AI_DL_MODELS/GIT/OpenVoice/se_extractor.py:141, in get_se(audio_path, vc_model, target_dir, vad)
139     wavs_folder = audio_path
140 elif vad:
--> 141     wavs_folder = split_audio_vad(audio_path, target_dir=target_dir, audio_name=audio_name)
142 else:
143     wavs_folder = split_audio_whisper(audio_path, target_dir=target_dir, audio_name=audio_name)
File ~/AI_DL_MODELS/GIT/OpenVoice/se_extractor.py:79, in split_audio_vad(audio_path, audio_name, target_dir, split_seconds)
77 def split_audio_vad(audio_path, audio_name, target_dir, split_seconds=10.0):
78     SAMPLE_RATE = 16000
---> 79     audio_vad = get_audio_tensor(audio_path)
80     segments = get_vad_segments(
81         audio_vad,
82         output_sample=True,
(...)
85         method="silero",
86     )
87     segments = [(seg["start"], seg["end"]) for seg in segments]
File ~/miniconda3/envs/openvoice/lib/python3.9/site-packages/whisper_timestamped/transcribe.py:1265, in get_audio_tensor(audio, device)
1263 def get_audio_tensor(audio, device="cpu"):
1264     if isinstance(audio, str):
-> 1265         audio = whisper.load_audio(audio)
1266     if isinstance(audio, np.ndarray):
1267         audio = torch.Tensor(audio)
File ~/miniconda3/envs/openvoice/lib/python3.9/site-packages/whisper/audio.py:60, in load_audio(file, sr)
58     out = run(cmd, capture_output=True, check=True).stdout
59 except CalledProcessError as e:
---> 60     raise RuntimeError(f"Failed to load audio: {e.stderr.decode()}") from e
62 return np.frombuffer(out, np.int16).flatten().astype(np.float32) / 32768.0
RuntimeError: Failed to load audio: ffmpeg: error while loading shared libraries: libopenh264.so.5: cannot open shared object file: No such file or directory

What could be the reason for the missing file.
Also in step 2, I've received warnings and missing keys:

/home/pedro/miniconda3/envs/openvoice/lib/python3.9/site-packages/torch/cuda/init.py:88: UserWarning: CUDA initialization: CUDA unknown error - this may be due to an incorrectly set up environment, e.g. changing env variable CUDA_VISIBLE_DEVICES after program start. Setting the available devices to be zero. (Triggered internally at /opt/conda/conda-bld/pytorch_1670525539683/work/c10/cuda/CUDAFunctions.cpp:109.)
return torch._C._cuda_getDeviceCount() > 0
Loaded checkpoint 'checkpoints/base_speakers/EN/checkpoint.pth'
missing/unexpected keys: [] []
Loaded checkpoint 'checkpoints/converter/checkpoint.pth'
missing/unexpected keys: [] []

Thank you

You don't have ffmpeg installed on your device or the path to ffmpeg in your environment variables aren't set correctly. Install ffmpeg and restart your ide after adding the path to your environment and you should be good to go.


[Accessibility][Usable - Bot Responses-Edit]: No Keys Information is provided for keyboard users to navigate out from the edit field.

User Experience:
For better usability purpose and for keyboard users it will be good if proper information about keys to be used is provided either in terms of tooltip or some pop-up as provided using screen reader.
Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19569.1000)
Microsoft Edge Version: 82.0.436.0 (Official build) canary (64-bit)
Test URL: http://localhost:3000/home
Repro Steps:

Open URL: http://localhost:3000/home
"Bot Framework Composer" homepage will gets opened.
Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
Note: Better to create new "Dialog Actions" bot from example.
Select 'Bot Responses' from left navigation.
Navigate throughout the page when "Edit toggle button is enabled".
Observe the issue when user reach within the edit field.

Actual Result:
No Information is provided i.e. what keys should be used for keyboard users that will help to navigate out from the edit field. Normally 'esc' key is used but here esc key is also not working.
Note:
Same issue is repro within 'User Input - Edit Mode'.
Observation:
By using screen reader, user is able to know the keys i.e. Press 'Alt+F1' to open the dialog, then use 'Ctrl+M' key to navigate out.
Expected Result:
Proper Information should be provided i.e. what keys should be used for keyboard users that will help to navigate out from the edit field. Information either in terms of Tooltip or some pop-up should be provided.
MAG Guidelines:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc={F98F4235-B6BD-47D3-8DA4-F28B9B6FBFA8}&file=Guideline 101 – Recommended Assistive Technology Tools for MAS Testing of Microsoft Digital Properties.docx&action=default&mobileredirect=true
Attachment:
Usable_Bot Responses_Edit Mode.zip

Can we also get a11y tags added to this issue? Including severity :)
@ShellySoni, is there a resource for seeing out other code editors within Microsoft (for example, VS Code or Visual Studio) handle keyboard flow for accessibility?

Should we re-consider this? I know the Esc key is currently used for dismiss suggestions. And it's very easy to press Esc, use click Edit mode button to exit seems more reliable.

@Andy I tried on https://github.com/microsoft/BotFramework-Composer/pull/2329. Clicking esc will jump out of edit mode directly. Do we need to reconsider this like zhixiang said?

That's a great point @zhixzhan. @beyackle didn't you say there is already a key combo that removes focus from the editor?

Ctrl-M, at least in Edge and Firefox, switches between "use Tab to move to the next element" and "use Tab to insert tabs" mode, and the screen-reader follows along with this focus.

Is there any indication to a SR or KB user to do this? If not, maybe we need some documentation added.

It wouldn't hurt. I don't know what documentation screen-readers typically come with or how much training people who need to use them get, so they might not be aware that it's an option. Also we should check more browsers to see how standard a key shortcut this is.

Yeah. I'm thinking since monaco is basically its own application hosted inside of ours, it would probably be helpful to have a pointer to documentation somewhere.
It could be a KB/SR only visible link before the editors. @sangwoohaan @mareekuh what do you think?

Oh, that explains why I couldn't find that Ctrl-M thing in the usual docs. It's a Monaco thing. So, yes, we should definitely document that somewhere.

@awalia13, @ShellySoni, Please see the following gif:

The Monaco editor has documentation on accessibility. In this case I don't think a tooltip is appropriate, so would it be sufficient to provide a documentation pointer (as described by @a-b-r-o-w-n above) in Composer?

"[..] It could be a KB/SR only visible link before the editors. @sangwoohaan @mareekuh what do you think?[..]"
@a-b-r-o-w-n - yes, I like that suggestion.
@zxyanliu - would you be able to assist with this?

@mareekuh
I would be happy to help. I was not aware of this keyboard usability issue and it seems to be important to some users.
If we have the keyboard shortcut combo, I would be more than happy to add them to the current Composer documentation. Please let me know.

@corinagum I am agree with the idea of documentation pointer. If the KB user will aware how to exit from the edit field or the shortcut key, it is helpful for them.

Is this being worked on? Is the keiboardshortcut cheat-sheet available in the documentation?
@zxyanliu

This is definitely a documentation issue, and a cheat-sheet would be a good way to solve it.

Sure. I can add a keyboard short cut cheat-sheet in the Composer docs. Who should I contact for the list of the short cut?

@zxyanliu I found this, which looks like it'd be a good basis for one: https://github.com/Microsoft/monaco-editor/wiki/Monaco-Editor-Accessibility-Guide

#Nonbenchmark;


Make esx encryption use aws credentials to get image from s3

Forcing anonymous s3 access to the bucket locked us out from
using non-public buckets. This change addresses that by allowing
the use aws credentials (if they exist).
If no credentials are found in the environment, we will fall back
to an anonymous connection.

👍


[Feature]Support lake persistent index (backport #25925)

Signed-off-by: smartlxh<EMAIL_ADDRESS>(cherry picked from commit 6a2717cfe8c18aaef9d58d2e7ad56081e446f4f6)
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 53 / 65 (81.54%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/system/Backend.java
0
1
00.00%
[296]

:large_blue_circle:
com/starrocks/system/ComputeNode.java
3
5
60.00%
[472, 473]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
11
16
68.75%
[1975, 1982, 2016, 2026, 2027]

:large_blue_circle:
com/starrocks/system/HeartbeatMgr.java
3
4
75.00%
[304]

:large_blue_circle:
com/starrocks/catalog/TableProperty.java
9
11
81.82%
[479, 480]

:large_blue_circle:
com/starrocks/server/OlapTableFactory.java
5
6
83.33%
[281]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/common/proc/ComputeNodeProcDir.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/system/BackendHbResponse.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/task/CreateReplicaTask.java
5
5
100.00%
[]


File js/vendors.js not defined in asset manifest.

ErrorException in Application.php line 43:
File js/vendors.js not defined in asset manifest. (View: D:\xampp\htdocs\music\resources\views\index.blade.php)

Check if you have gulp, bower and composer installer
If you have, try to install manuall these packages:
bower install plyr
npm install -g notify-send gulp-notify


How should i avoid making two history instances?

I tried demonstrating navigating by link using redux-simple-router in react-slingshot, but i encountered a problem. I have a workaround, but how to (properly) avoid making two history instances?
What i did was follow the redux-simple-router example and it dit not fully work. The browser URL changed but not the shown page.
After some comparing between my code and the redux-simple-router example i figured this was due to history existing in both src/index.js and src/store/configureStore.js. I was under the impression that it would return a singleton but it apparently not. So as a workaround i moved all src/store/configureStore.js code to src/index.js... and yep, it now works.
This workaround is not ideal of course. How should i fix this without merging the files?

I'd like to replace this workaround in the feature-router branch that i present in https://github.com/coryhouse/react-slingshot/issues/10

Fixed in 2b0f9681481c729b35a31e7c2462e62fe7af7bfc


Sharing from iOS' "instant markup" doesn't do anything

There seems to be an issue when sharing images from some apps, mainly from "instant markup".
To replicate this, take a screenshot, and once the screenshot pops up on the bottom left, click on it to show the "instant markup" tool. If you now draw something on the picture, hit "share", and select the app that uses "receive_sharing_intent", nothing will happen.
From what I can tell, in this case, iOS doesn't send a URL for the image, but the data itself.
I think the problem and solution is something close to this discussion.
I tried to get the image data and store them in a file instead of copying them from the URL, but I couldn't get it to work as I don't really do swift and suck at it.
Has anyone else ever bumped into the issue? If so, I'd really appreciate if you could share your handlers for images. :)
Thank you!

bump

I solved this problem.
@geoah Thanks for the link on StackOverflow, it helped. That happened cause the instant markup was sending the UIImage instead of url of file
To fix it, add the following code to the "ios / Share Extension / ShareViewController.swift" file
This line in the place of declaring constants
let uiImageContentType = kUTTypeData as String

Add this method
private func handleUIImages (content: NSExtensionItem, attachment: NSItemProvider, index: Int) {
        attachment.loadItem(forTypeIdentifier: uiImageContentType, options: nil) { [weak self] data, error in
            if error == nil, let imageData = data as? UIImage, let this = self {
                DispatchQueue.main.async {
                    let newName = UUID().uuidString
                    let newPath = FileManager.default
                        .containerURL(forSecurityApplicationGroupIdentifier: "group.\(this.hostAppBundleIdentifier)")!
                        .appendingPathComponent("\(newName).png")
                    let copied = this.createFile(image: imageData, srcURL: newPath)
                    if(copied) {
                        this.sharedMedia.append(SharedMediaFile(path: newPath.absoluteString, thumbnail: nil, duration: nil, type: .image))
                    }
                    if index == (content.attachments?.count)! - 1 {
                        let userDefaults = UserDefaults(suiteName: "group.\(this.hostAppBundleIdentifier)")
                        userDefaults?.set(this.toData(data: this.sharedMedia), forKey: this.sharedKey)
                        userDefaults?.synchronize()
                        this.redirectToHostApp(type: .media)
                    }
                }
            }
        }
    }

And this condition to viewDidLoad() method
if attachment.hasItemConformingToTypeIdentifier(uiImageContentType) {
                        handleUIImages(content: content, attachment: attachment, index: index)
  }

@gicha
Not a good solution. It fails text data to be handled.
It's better idea to check data type inside handleImages method.
                let fileExtension: String = {
                    if let url = data as? URL {
                        return this.getExtension(from: url, type: .image)
                    }
                    if data is UIImage {
                        return "png"
                    }
                    return ""
                }()

                let newName = UUID().uuidString
                let newPath = FileManager.default
                    .containerURL(forSecurityApplicationGroupIdentifier: "group.\(this.hostAppBundleIdentifier)")!
                    .appendingPathComponent("\(newName).\(fileExtension)")

                var copied = false
                if let url = data as? URL {
                    copied = this.copyFile(at: url, to: newPath)
                }
                if let image = data as? UIImage, let imageData = image.pngData() {
                    do {
                        try imageData.write(to: newPath)
                        copied = true
                    } catch {}
                }
                if copied {
                    this.sharedMedia.append(SharedMediaFile(path: newPath.absoluteString, thumbnail: nil, duration: nil, type: .image))
                }


Rebaseline performance test scenarios after 7.5 release

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Not thread safe file manipulation results in build failures of multi-module projects

Maven Version
3.9.8
Version
0.0.8
Sentry SDK Version
7.14.0
Steps to Reproduce

Have a multi-module Maven project
Run mvn install -T1C (or higher concurrency)

This breaks non-deterministically
Expected Result
Sources are uploaded to Sentry
Actual Result
Getting an error
/bin/sh: 1: /tmp/.sentry-cli10465974399318709029.exe: Text file busy

As far as I understand it is coming from this line https://github.com/getsentry/sentry-maven-plugin/blob/daa4fd948819a186f0397ee8ef6d3f5d447a6229/src/main/java/io/sentry/cli/SentryCliRunner.java#L75
Which is preceded by https://github.com/getsentry/sentry-maven-plugin/blob/daa4fd948819a186f0397ee8ef6d3f5d447a6229/src/main/java/io/sentry/SentryCliProvider.java#L112
After reviewing how thread safe the implementation is, I couldn't pinpoint where the issue is.
Not having other ideas, it seems like the root cause may lie in the JVM bug: https://bugs.openjdk.org/browse/JDK-8068370
It is suggested that a retry could help with that issue. Would be happy to accept a PR that implements a single-attempt retry logic for this bit of code?

Thanks for opening this issue. We haven't optimized the sentry-maven-plugin for parallel execution (yet).
We could ensure only a single SentryCliRunner is being used. I'm not certain this is possible as I haven't read up on how parallelism works in Maven. If everything is running inside a single process where the classloader is shared, it shouldn't be a problem to do so.
We could then synchronize runSentryCli to only have one invocation of sentry-cli running at any time.
I'm afraid merely retrying would only fix the problem in a few cases but not all of them and it'd just take longer to fail - not sure that's much better than the current behaviour.
Or do I misunderstand the issue and it's only a problem right after sentry-cli is copied to a temporary location and unrelated to multiple invocations of it?
We're gonna take a look at this in more detail but I can't give an ETA at this point, as we're currently working on v8 of the Java SDK.

With the above in mind @adinauer , what do you think about adding the following parameter, which is also part of a few other Maven plugins:
<configuration>
  <failOnError>false</failOnError>
  ...

If you think it's acceptable for you guys, I can quickly open a PR.
Otherwise, we are quite happy with how errors looks now in Sentry 🙌

That sounds good, only downside is probably that on a fail you have to upload the sources somehow. I'm not quite sure how that'd play out exactly. On a later upload you just need to make sure you use the same ID that's been packaged with the JAR as io.sentry.bundle-ids in sentry-debug-meta.properties.
We can tackle that problem separately as I'm not sure how exactly we wanna solve it.
A PR would be very welcome! Thanks for the feedback!

Regarding the original problem here, maybe it's sufficient to just sleep for a bit and only then use the freshly copied file.

I've realized something basic that I oversaw initially, the reason this was happening is that the plugin tries to source the binary/script from its own JAR, and we can tell it to not do that and provide it with our own sentry-cli. That was my workaround, so I'm pre-downloading the sentry-cli (currently on a separate build step, but soon will bake it as part of the build image), and configuring the plugin with <sentryCliExecutablePath>${env.SENTRY_CLI_PATH}</sentryCliExecutablePath> to tell it to use that binary.
As for the root cause fix, I think you're right and a short sleep might actually help, I'd try that.


adds .js to the extensions supported by the jsx language

fixes #144 for good

This actually will not fix the problem you are having ( #144 ), however I am merging it anyway because it will not change anything.
While the addition of the js extension is not necessary, it will not break anything because the priority of the grammar supersedes the extensions ( see https://github.com/Glavin001/atom-beautify/blob/master/src/languages/index.coffee#L86 ). The JavaScript grammar will of course be default in Atom for .js unless changed by user.
Furthermore, the real bug is #353. Basically, extensions was not working, at all. I had a couple typos. It was actually only using the grammars, for which both JavaScript (JSX) and JSX are already supported.
I will be publishing fix for #353 soon, however given any extensions are effectively useless in the currently published version, I wonder: did you test this pull request? Did it work? If so, then it was something else, such as restarting Atom or updating Atom Beautify, etc, that actually is making it work for you now, as the grammars JavaScript (JSX) and JSX were already added and usable under language JSX.
Thank you for your contributions, regardless.

Published to v0.27.4

Thanks for the explanation.


Remove Nightly Features & Enable Clippy

This PR removes our dependence on nightly features (allowing us to build on stable), adds support for the clippy linter, and fixes nearly all of the lints reported by clippy.

This change is

Reviewed 17 of 17 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


feat(android): implemented Network Connectivity status monitoring

Description

Added useIsOnline() hook to monitor current Network status of the device in real time...
Compatibility

OS
Implemented

iOS
❌

Android
✅

Windows
❌

Checklist

[X] I have tested this on a device/simulator for each compatible OS
[X] I added the documentation in README.md
[X] I updated the typings files (privateTypes.ts, types.ts)
[X] I added a sample use of the API (example/App.js)

react-native-netinfo handles these cases - it is a fiendishly complex thing to implement in fact, and I have no intention of mixing the two packages by adding this functionality here, apologies


When i click Set Time button or AM/PM change Page will be reloaded

i added control in angular 2 html page and open when i select date and click confirm date will be updated in my input box. when i select picker and change time and click set time button page will be reloaded.
html:
<input class="picker-input" [ngModel]="fromDt" [returnObject]="'string'" [viewFormat]="'MM/DD/YYYY hh:mm A'" [(dateTimePicker)]="fromDt" [hourTime]="'12'" [mode]="'dropdown'" readonly>

@Parthiban130487
Normally, when you click 'Set Time', it will go back to the calendar. And when you click confirm, it will close the picker.

#14 I opened a pull request to solve this.

@timmyrosen
Ah~~~I see....that's a scenario I didn't test....
Thanks man, I will look at it right away....

Thank you, it's now working for me..


Bug scenario items...

Bug scenario items...
Hello, I'm new here ...
I have a problem when I put an item in my scenario ...
Even by adding the right code in {c:QItemX} for example, when I test the scenario, the item completely changes to another that I haven't even added.
I don't know if this issue was reported here, or started due to the import of the new version of MoM into steam ...
Any solution?
Tys
Valkyrie Version 2.4.06

If you select an item but have the category (aka weapon) it will randomly select an item from that category, excluding the item you select.
To get a static item that you select hit the red - next to the category (probably weapons in your situation).

Tys man, it worked here...

Happy to help, feel free to PM me on BGG (scrubbless) or @tag me on github if you need any help.


Add swxmlhash <IP_ADDRESS> for rules_swift 2.0 compatibility

We need this to increase compatibility level with rules_swift 2.0

Hello @keith, @jpsim, modules you maintain (swxmlhash) have been updated in this PR. Please review the changes.


Resize/update events, $.on(), wrappers for any block and more

Also added $.fn.tinyscrollbarUpdate() method, for window resize events.
Thumb min size (very helpful for long lists). Improved selectors speed
and heights calculation.
Please check it out and if makes sense - standalone version update is required as well.

@wieringen wow, just realized it's still open! :)


[bug][fs][v2] unable to get path from XX

When I want to read a text file such as C://users/user/temp.json, fs.readTextFile is work.
But it reports the unable to get path from c://users/user/temp.json error recently.

tauri-plugin-fs: v2
@tauri-apps/plugin-fs: 2.0.0-rc.1

I'm sure https://github.com/tauri-apps/plugins-workspace/pull/1658/commits/f8ba7e8e causes this bug😅

Hello I am also facing the same path and fs issues on windows. I am not able to read a json path nor check an path for existence with the exist function from the fs plugin for tauri v2. I tried multiple rc versions but all of them fail in the end. Some bug got introduced then recently which might cause pathing issues.

This bug accurs after https://github.com/tauri-apps/plugins-workspace/pull/1658 merged,you could lock the plugin version to an exact commit before it to prevent this bug.

Heya I tried that all now the last hours but nothing seems to solve the issue unfortunately.
The weird thing is on macos there are no issues it is only affecting windows on my end. I matched the versions to my macos one and still no luck.

Heya I tried that all now the last hours but nothing seems to solve the issue unfortunately.

https://github.com/BTMuli/TeyvatGuide/blob/master/src-tauri%2FCargo.lock This is my proj lock file,the plugin fs is beta11 version and everything works well.

Thank you so much BTMuli! Thanks to your proj lock file example I was able to make it work again using beta11! Really appreciate it! Also I learned new stuff now with project locking because before I was mainly changing the js guest bindings for the nextjs part whereas in my cargo.toml I kept it on v2 for all the plugins BUT the key was the cargo.lock file as you pointed it out! Thank youuuu

I get the same issue. The following updates were breaking changes:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
So, to fix, you need to pin your deps:
"dependencies": {
    "@tauri-apps/plugin-dialog": "2.0.0-rc.0",
    "@tauri-apps/plugin-fs": "2.0.0-rc.2",
}

tauri-plugin-dialog = "=2.0.0-rc.2"
tauri-plugin-fs = "=2.0.0-rc.0"


Benchmarking Changes

Hey Tom, I was wondering about benchmarking the api performance on pull requests to see if they significantly affect the performance. Sort of like code coverage testing but against an API benchmark test instead. Just a thought!

At some point in the not too distant future let's consider something like this, yes. Perhaps eg once we've got the full suite of TechEmpower tests, rather than just the trivial hello, world.

Refs #18 , should I close this issue for now?

Let's do, yes. I should probably adopt a policy of "open issue = actively on the radar". Things tend to get messy if we just keep open everything that we might do one day! :)