[Bug-12868][UI] Data target type is only HDFS

Purpose of the pull request
#12868
fix bug: drag a SQOOP task, select SQL as the data source modeltype, the data target type contains HIVE and HDFS.
Then I switch the data source modeltype from SQL to Form, and then switch to SQL, the data target type is only HDFS.
Brief change log
Update use-sqoop-target-type.ts, add HIVE
Verify this pull request
This pull request is code cleanup without any test coverage.

Codecov Report

Merging #12902 (05cf337) into dev (6d8befa) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12902      +/-   ##
============================================
- Coverage     39.46%   39.42%   -0.04%
+ Complexity     4247     4243       -4
============================================
  Files          1052     1052
  Lines         39860    39860
  Branches       4582     4586       +4
============================================
- Hits          15731    15716      -15
- Misses        22349    22366      +17
+ Partials       1780     1778       -2

Impacted Files
Coverage Δ

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-6.46%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
51.19% <0.00%> (-1.20%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


A caveat when using respond_to in pair with respond_with

I found a flaw when using respond_to in pair with respond_with: before responding with 406 status, some of the controller actions (create, updatee and destroy) are still performed. So, one having requested wrong format, still can delete/update/create the reource.
# app/controllers/application_cotroller.rb

require "application_responder"

class ApplicationController < ActionController::Base
  self.responder = ApplicationResponder
  respond_to :json

  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception

  rescue_from 'ActionController::UnknownFormat' do |exception|
    render json: exception.message, status: :not_acceptable
  end
end

# app/controllers/posts_controller.rb
class PostsController < ApplicationController
  before_action :set_post, only: [:show, :update, :destroy]
  # ...
  # POST /posts
  # POST /posts.json
  def create
    post = Post.new(post_params)

    if post.save
      respond_with post, location: post
    else
      render json: post.errors, status: :unprocessable_entity
    end
  end

  # PATCH/PUT /posts/1
  # PATCH/PUT /posts/1.json
  def update
    if @post.update(post_params)
      respond_with @post, location: @post
    else
      render json: @post.errors, status: :unprocessable_entity
    end
  end

  # DELETE /posts/1
  # DELETE /posts/1.json
  def destroy
    @post.destroy
    respond_with(:no_contnet)
  end
  # ...
end

# spec/requests/posts_request_spec.rb
require 'rails_helper'

RSpec.describe "Posts", :type => :request do
  # ...
  describe 'POST #create' do
    let(:post_item) { create(:post) }

    subject {response}

    context 'when requested a wrong contnet' do
      it 'doesn\'t save the new post to the database' do
        expect{
          post posts_path, {post: attributes_for(:post)}, {Accept: Mime::XML}
        }.to_not change(Post, :count)
      end
      # expected #count not to have changed, but did change from 0 to 1
    end
  end

  describe 'PATCH #update' do
    let(:post_item) { create(:post) }

    context 'when requested a wrong content' do
      before do
        put post_path(post_item.id), {post: attributes_for(:post, title: 'updated')}, {Accept: Mime::XML}
      end

      it 'doesn\'t update a post' do
        expect(assigns(:post).title).to_not eq('updated')
      end
      # expected: value != "updated"
      #     got: "updated"
    end
  end

  describe 'DELETE #destroy' do
    let!(:post_item) { create(:post) }

    context 'when requested a wrong contnet' do
      it 'doesn\'t delete a post' do
        expect {
          delete post_path(post_item.id), {}, {Accept: Mime::XML}
        }.to_not change(Post, :count)
      end
     # expected #count not to have changed, but did change from 1 to 0
    end
  end
end

@d3crypt3d yes, this is a nasty caveat - #143 aims to fix it.

@d3crypt3d 2.2.0 was released with #153, let me know how it works for you :)

Works like a charm, thanks!


bitbox02: fix singlesig signing regression

script_configs[0].script_config.multisig is always True - a protobuf
pitfall. The way to check which variant it is is by using WhichOneof.

cc @ben-kaufman, who discovered it during testing of RC2.

Will test.

tACK 308763d
master signing fails with the vague "path" message, this PR branch signs correctly. I did not test multisig to make sure that wasn't broken.


api: map query parameters to validation options

Allow HTTP API users to set FedWireMessage.ValidationOpts via query parameters when creating files.

Codecov Report

Merging #356 (6a411ac) into master (71d51ac) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

:exclamation: Current head 6a411ac differs from pull request most recent head 847269f. Consider uploading reports for the commit 847269f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   74.85%   74.82%   -0.03%
==========================================
  Files          73       73
  Lines        8653     8684      +31
==========================================
+ Hits         6477     6498      +21
- Misses       1609     1619      +10
  Partials      567      567


Support Exporting/Importing/Syncing to/from Google TEAM Drives

The Google Drive integration is excellent, but it appears I cannot use the feature with my company's team drive, which means I can't (easily) share my docs with other colleagues or keep them in the company library with the rest of our documents.

https://github.com/benweet/stackedit/pull/1285

Fixed in v5.11.1.


group_2_ass_1_2024_task1

En esta sección se completará la tarea #1 para el grupo #2.
Ejemplo:
Alexander
a. Database: Nexus Ministry of Education
b. Information: Data about teachers at the kinder, primary, and secondary levels for the years 2015-2023
c. Interest: I would like to study information on teacher migration within Peru - or any other general idea about a possible research question.

Nathaly Belapatiño
a. Database: Ventas_Una_Piedra_2023
b. Information: Data about Uno Piedra's sales volume for the years 2023
c. Interest: I would like to study information on sales volume and consumer behavior to plan marketing activities more efficiently.


Got Issues when pip install -r requirements.txt

Outputs:
Collecting fastapi==0.86.0 (from -r requirements.txt (line 1))
  Downloading fastapi-0.86.0-py3-none-any.whl (55 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 55.5/55.5 kB 1.1 MB/s eta 0:00:00
Collecting numpy==1.22.3 (from -r requirements.txt (line 2))
  Downloading numpy-1.22.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (16.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 16.8/16.8 MB 56.3 MB/s eta 0:00:00
Collecting psutil==5.8.0 (from -r requirements.txt (line 3))
  Downloading psutil-5.8.0.tar.gz (470 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 470.9/470.9 kB 24.5 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... done
Collecting pydantic==1.10.2 (from -r requirements.txt (line 4))
  Downloading pydantic-1.10.2-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (12.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 12.8/12.8 MB 46.1 MB/s eta 0:00:00
Collecting pynvml==11.0.0 (from -r requirements.txt (line 5))
  Downloading pynvml-11.0.0-py3-none-any.whl (46 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 46.1/46.1 kB 5.6 MB/s eta 0:00:00
Collecting pytorch_lightning==1.7.6 (from -r requirements.txt (line 6))
  Downloading pytorch_lightning-1.7.6-py3-none-any.whl (707 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 707.5/707.5 kB 64.0 MB/s eta 0:00:00
Collecting scikit_learn==1.1.3 (from -r requirements.txt (line 7))
  Downloading scikit_learn-1.1.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (30.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 30.5/30.5 MB 18.4 MB/s eta 0:00:00
Collecting setuptools==58.0.4 (from -r requirements.txt (line 8))
  Downloading setuptools-58.0.4-py3-none-any.whl (816 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 816.5/816.5 kB 64.2 MB/s eta 0:00:00
Collecting starlette==0.20.4 (from -r requirements.txt (line 9))
  Downloading starlette-0.20.4-py3-none-any.whl (63 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 63.6/63.6 kB 7.7 MB/s eta 0:00:00
ERROR: Could not find a version that satisfies the requirement torch==1.11.0+cu113 (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 2.0.0, 2.0.1)
ERROR: No matching distribution found for torch==1.11.0+cu113

Then I tried to pip install https://mirror.sjtu.edu.cn/pytorch-wheels/cu113/torch-1.11.0+cu113-cp310-cp310-linux_x86_64.whl, still got issues like:
! pip install https://mirror.sjtu.edu.cn/pytorch-wheels/cu113/torch-1.11.0+cu113-cp310-cp310-linux_x86_64.whl
Collecting torch==1.11.0+cu113
  Downloading https://mirror.sjtu.edu.cn/pytorch-wheels/cu113/torch-1.11.0+cu113-cp310-cp310-linux_x86_64.whl (1637.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.6/1.6 GB 977.0 kB/s eta 0:00:00
Requirement already satisfied: typing-extensions in /usr/local/lib/python3.10/dist-packages (from torch==1.11.0+cu113) (4.7.1)
Installing collected packages: torch
  Attempting uninstall: torch
    Found existing installation: torch 2.0.1+cu118
    Uninstalling torch-2.0.1+cu118:
      Successfully uninstalled torch-2.0.1+cu118
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torchaudio 2.0.2+cu118 requires torch==2.0.1, but you have torch 1.11.0+cu113 which is incompatible.
torchdata 0.6.1 requires torch==2.0.1, but you have torch 1.11.0+cu113 which is incompatible.
torchtext 0.15.2 requires torch==2.0.1, but you have torch 1.11.0+cu113 which is incompatible.
torchvision 0.15.2+cu118 requires torch==2.0.1, but you have torch 1.11.0+cu113 which is incompatible.
Successfully installed torch-1.11.0+cu113

It seems like some conflicts within requirements.txt.

Thank you for your feedback, we will update it soon.


[BUG] Multithreaded Crash with SKShaper and SKTypeFace

Description
Well, it may not necessarily be SKShaper related, but it's how I can make it happen. I can reproduce it by adding the below unit test code to the SKShaperTest class. Importantly, the typeface class has completely lost its Handle value! It'll do it whether I wrap the typeface in a using block or not. I think something is prematurely disposing and eliminating typefaces that might still be in play? Sometimes the unit test will complete, so be patient and try it a few times. In debug mode I had to remove the THROW_OBJECT_EXCEPTIONS compile flag to catch it.
It didn't happen with 1.68.0, but it's definitely happening with <IP_ADDRESS>.
Same code will reproduce it via a .NET Core Console app too. Started with that but figured I'd get a little more info with the extra debug info from the test project instead of it killing the process outright.
Code
[SkippableFact]
		public void TestMultiThreadCrash()
		{
			const int count = 20000;
			var threads = new List<Thread>();

			for (var i = 0; i < count; i++)
			{
				var t = new Thread(new ParameterizedThreadStart(Work));
				t.TrySetApartmentState(Thread.CurrentThread.GetApartmentState());
				t.Name = i.ToString();
				t.Start(i);
				threads.Add(t);
			}
			for (var i = 0; i < count; i++)
			{
				threads[i].Join();
			}
		}
		private void Work(object state)
		{
			var text = $"Some wonderful text goes here {state}.";
			var typeface = SkiaSharp.SKTypeface.FromFamilyName("Arial", SkiaSharp.SKFontStyle.Bold);
			//using (var typeface = SkiaSharp.SKTypeface.FromFamilyName("Arial", SkiaSharp.SKFontStyle.Bold))
			//{
			SkiaSharp.HarfBuzz.SKShaper.Result result;

			using (var paint = new SkiaSharp.SKPaint())
			{

				using (var shaper = new SkiaSharp.HarfBuzz.SKShaper(typeface))
				{
					result = shaper.Shape(text, 75, 75, paint);
				}

				var imageInfo = new SkiaSharp.SKImageInfo(128, 128);
				using (var bitmap = new SkiaSharp.SKBitmap(imageInfo))
				using (var canvas = new SkiaSharp.SKCanvas(bitmap))
				{
					var bytes = result.Codepoints.Select(cp => BitConverter.GetBytes((ushort)cp)).SelectMany(b => b).ToArray();
					paint.TextEncoding = SkiaSharp.SKTextEncoding.GlyphId;
					canvas.DrawPositionedText(bytes, result.Points, paint);
				}
			}
			//}
		}

As console app:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;

namespace ConsoleApp {
	class Program {

		static void Main(string[] args) {

			Console.WriteLine($"IntPtr size: {IntPtr.Size}");

			const int count = 100;
			var threads = new List<Thread>();

			for (var i = 0; i < count; i++) {
				var t = new Thread(new ParameterizedThreadStart(Work));
				t.TrySetApartmentState(ApartmentState.MTA);
				t.Name = i.ToString();
				t.Start(i);
				threads.Add(t);
			}
			for (var i = 0; i < count; i++) {
				threads[i].Join();
			}
			Console.WriteLine("Done.");
		}

		private static void Work(object state) {
			var text = $"Some wonderful text goes here {state}.";
			var typeface = SkiaSharp.SKTypeface.FromFamilyName("Arial", SkiaSharp.SKFontStyle.Bold);
			SkiaSharp.HarfBuzz.SKShaper.Result result;

			using var paint = new SkiaSharp.SKPaint();

			using (var shaper = new SkiaSharp.HarfBuzz.SKShaper(typeface)) {
				result = shaper.Shape(text, 75, 75, paint);
			}

			var imageInfo = new SkiaSharp.SKImageInfo(128, 128);
			using var bitmap = new SkiaSharp.SKBitmap(imageInfo);
			using var canvas = new SkiaSharp.SKCanvas(bitmap);

			var bytes = result.Codepoints.Select(cp => BitConverter.GetBytes((ushort)cp)).SelectMany(b => b).ToArray();
			paint.TextEncoding = SkiaSharp.SKTextEncoding.GlyphId;
			canvas.DrawPositionedText(bytes, result.Points, paint);
		}

	}
}

Expected Behavior
Typefaces shouldn't be disappearing?
Actual Behavior
Typefaces are disappearing!
Basic Information

Version with issue:  <IP_ADDRESS>
Last known good version:  1.68.0
IDE:  VS2017/2019
Platform Target Frameworks:

Windows Classic:  Win10 via xUnit x86 / .NET Core 3 x64

Screenshots

Thanks for this issue, it brought up an interesting case where sometimes the font manager returns the same object. This results in the disposal of one causing issues for the rest.
I have a fix that I am testing locally that should correctly identify and prevent this from happening.

Awesome, thanks!

Released to NuGet as version 1.68.2-preview.60


add support for new SvelteKit and Vite integration

Latest version of SvelteKit now uses Vite, that's, SvelteKit is just another plugin (check this repo https://github.com/userquin/pwa-sveltekit-vite):

we need to move the _generateSW to writeBundle: SvelteKit uses process.exit on closeBundle
we also need to detect the vite-plugin-svelte-kit on SSR (we need to generate the SW before SvelteKit calls process.exit when prerender enabled)

      async writeBundle() {
        const sveltekitPresent = viteConfig.plugins.find(p => p.name === 'vite-plugin-svelte-kit')
        if ((!viteConfig.build.ssr || sveltekitPresent) && !options2.disable)
          await _generateSW();
      },

/cc @antfu  @benmccann

updated https://github.com/userquin/pwa-sveltekit-vite using local copy of #327
it is working but we need to wait SvelteKit to fix the process.exit in the closebundle hook: we've included a sequential plugin hook that sleeps 1sc and then call pwa closeBundle hook and finally call kit closeBundle hook.
https://github.com/sveltejs/kit/issues/5306

Is this the cause for the error in the sveltekit example?
svelte-kit build is no longer available — use vite build instead

@benquan yes and no: new kit has a few internal breaking changes, the cli is just one, you  need to install kit as a plugin.
We are adding integration, just released 0.13.0 version to support Vite 3.1 sequential hook (Rollup), that's required to run new kit apps.

Released initial version of astro integration: https://vite-pwa-org.netlify.app/frameworks/sveltekit.html
The example in this repo Will be removed, check the New repo for new custom kit plugin here https://github.com/vite-pwa/sveltekit

When I do the install routine (), then I get error - Cannot find module '@vite-pwa/sveltekit' or its corresponding type declarations.ts(2307) - in vite.config.ts
package.json:
"devDependencies": {
		"@sveltejs/adapter-static": "^1.0.0-next.44",
		"@sveltejs/kit": "next",
		"@typescript-eslint/eslint-plugin": "^5.27.0",
		"@typescript-eslint/parser": "^5.27.0",
		"@vite-pwa/sveltekit": "^0.0.1",
		"eslint": "^8.16.0",
		"eslint-config-prettier": "^8.3.0",
		"eslint-plugin-svelte3": "^4.0.0",
		"npm-run-all": "^4.1.5",
		"prettier": "^2.6.2",
		"prettier-plugin-svelte": "^2.7.0",
		"svelte": "^3.44.0",
		"svelte-check": "^2.7.1",
		"svelte-preprocess": "^4.10.6",
		"tslib": "^2.3.1",
		"typescript": "^4.7.4",
		"vite": "^3.2.0",
		"vite-plugin-pwa": "^0.13.1"
	},

import type { UserConfig } from 'vite';

import { sveltekit } from '@sveltejs/kit/vite';
import { VitePWA } from 'vite-plugin-pwa';
import { pwaConfiguration } from './pwa-configuration.js';
import { SvelteKitPWA } from '@vite-pwa/sveltekit'

const config: UserConfig = {
	plugins: [
		// VitePWA(pwaConfiguration),
		sveltekit(),
		SvelteKitPWA(pwaConfiguration)
	]
};

export default config;


WIP: espresso devnet

Commitment task
Misc tweaks
[ ] https://github.com/EspressoSystems/espresso-sequencer/pull/588

Close #54

Maybe we should unconditionally generate the L2 genesis block in Espresso mode, since the timestamp is important?

Sorry https://github.com/EspressoSystems/op-espresso-integration/pull/56/commits/e800c9695f6d3d0e8203ae225251a88678d7ea1e doesn't fully work because we need the initial state for the postgres DB to be there.


Add ".toml" to default config file reference

Those we can close this stalled merge request, please do.  It prevents that this dangling MR will drain further human energy.


Conversation switching keyboard shortcuts incorrectly displayed in OS X

In v1.4.1, the OS X shortcuts shown in the View menu for "Previous Conversation" and "Next Conversation" are incorrect.
Because the shortcut is Command-up or Command-down, I’d expect to see up and down arrows in the menu.
Instead, the menu shows the symbol for Tab, which would lead users to believe the correct shortcut for switching conversations is Shift-Command-Tab or Command-Tab (which in OS X for will switch apps).

@vnaylon does the (Shift+)Command+Tab work? I guess this is the official shortcut as it is the one that is visible :)
The other shortcut is defined directly in the code (input.coffe), no idea why this is being done in 2 places
I guess being a hidden shortcut is not good UI policy, maybe we should converge to just a single one that's advertised in the menu. thoughts @davibe, @vnaylon ?


Update image_classification_with_vision_transformer.py

Not sure if this is a bug in checkpoint logic. I got error like below:

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[10], line 41
     37     return history
     40 vit_classifier = create_vit_classifier()
---> 41 history = run_experiment(vit_classifier)
     44 def plot_history(item):
     45     plt.plot(history.history[item], label=item)

Cell In[10], line 23, in run_experiment(model)
     15 checkpoint_filepath = "/tmp/checkpoint"
     16 checkpoint_callback = keras.callbacks.ModelCheckpoint(
     17     checkpoint_filepath,
     18     monitor="val_accuracy",
     19     save_best_only=True,
     20     save_weights_only=True,
     21 )
---> 23 history = model.fit(
     24     x=x_train,
     25     y=y_train,
     26     batch_size=batch_size,
     27     epochs=num_epochs,
     28     validation_split=0.1,
     29     callbacks=[checkpoint_callback],
     30 )
     32 model.load_weights(checkpoint_filepath)
     33 _, accuracy, top_5_accuracy = model.evaluate(x_test, y_test)

File /opt/conda/envs/keras-jax/lib/python3.10/site-packages/keras/src/utils/traceback_utils.py:123, in filter_traceback.<locals>.error_handler(*args, **kwargs)
    120     filtered_tb = _process_traceback_frames(e.__traceback__)
    121     # To get the full stack trace, call:
    122     # `keras.config.disable_traceback_filtering()`
--> 123     raise e.with_traceback(filtered_tb) from None
    124 finally:
    125     del filtered_tb

File /opt/conda/envs/keras-jax/lib/python3.10/site-packages/keras/src/models/model.py:373, in Model.save_weights(self, filepath, overwrite)
    363 """Saves all layer weights to a `.weights.h5` file.
    364
    365 Args:
   (...)
    370         via an interactive prompt.
    371 """
    372 if not str(filepath).endswith(".weights.h5"):
--> 373     raise ValueError(
    374         "The filename must end in `.weights.h5`. "
    375         f"Received: filepath={filepath}"
    376     )
    377 try:
    378     exists = os.path.exists(filepath)

ValueError: The filename must end in `.weights.h5`. Received: filepath=/tmp/checkpoint

Neel, I think /tmp/checkpoint is a valid path for saving checkpoint. Maybe this is a corner case for ModelCheckpoint callback with save_weights_only=True

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b6df549) 78.89% compared to head (4150205) 56.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18740       +/-   ##
===========================================
- Coverage   78.89%   56.26%   -22.64%
===========================================
  Files         336      336
  Lines       33937    33937
  Branches     6651     6651
===========================================
- Hits        26776    19093     -7683
- Misses       5584    13397     +7813
+ Partials     1577     1447      -130

Flag
Coverage Δ

keras
56.26% <ø> (-22.54%)
:arrow_down:

keras-jax
?

keras-numpy
56.26% <ø> (ø)

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 184 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi Scott,
This is actually intended behavior, since we want all weights files saved in Keras 3 to have the extension ".weights.h5".
The /tmp/checkpoint path was valid for checkpointing in legacy TF-Keras, but we are moving everyone to using this new format.


Add --all flag to cargo test

Work towards #2878.
This flag allows a user to test all members of a workspace by using cargo test --all. The command is also supported when using a virtual workspace manifest.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks for the PR! Unfortunately I'll be pretty busy this week so it may take awhile to get back to this, but I haven't forgotten it!

:umbrella: The latest upstream changes (presumably #3242) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased. Hopefully will get a chance to work on this more later this week.

:umbrella: The latest upstream changes (presumably #3280) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased, and ready for another round of review, @alexcrichton

Still working on this, haven't had much time for open source lately! Hoping to finish up by the weekend.

Ah no worries, let me know if you need any help getting it over the finish line!

:umbrella: The latest upstream changes (presumably #3310) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton Most comments addressed, I commented on the remaining issues.

Sorry for taking awhile to get back to this! I just want to dig into the "is a member" issue a bit and then we should be able to land this.

@alexcrichton, no problem! Everything should be addressed now.

@bors: r+
Awesome, thanks!

:pushpin: Commit addbb7e has been approved by alexcrichton

:hourglass: Testing commit addbb7e with merge fec03d3...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing fec03d31f27855af2b1c0d45a3f39b46e30983fd to master...

Was it expected that this changed cargo's behavior so that tests of dependent lib crates are no longer dropped in the target/debug folder?

@khuey no I think that may have been accidental! Oddly enough https://github.com/rust-lang/cargo/issues/3660 was just reported as well and I believe that bug was fixed in https://github.com/rust-lang/cargo/pull/3478, could you test beta/nightly to see if they're working for you?

It's still broken on tip (de2919fd32f1d4f599bb59ac78ea4f01f3a33e46)

Woops, I was testing the wrong binary.  It is indeed fixed on tip.  I'll bisect for a fix cset.

Ok, thanks for checking!

It was indeed fixed by 3cbf141.
The regression is present in the cargo that ships with rustc 1.15.  That's not a big deal for me (I just won't use it) but something you may want to be aware of.

Sure thing, thanks for the heads up regardless


OMP: Error #15: Initializing libiomp5.dylib, but found libomp.dylib already initialized.

python image_from_text.py --text='a comfy chair that looks like an avocado' --seed=4

OMP: Error #15: Initializing libiomp5.dylib, but found libomp.dylib already initialized.
OMP: Hint This means that multiple copies of the OpenMP runtime have been linked into the program. That is dangerous, since it can
degrade performance or cause incorrect results. The best thing to do is to ensure that only a single OpenMP runtime is linked into
the process, e.g. by avoiding static linking of the OpenMP runtime in any library. As an unsafe, unsupported, undocumented workarou
nd you can set the environment variable KMP_DUPLICATE_LIB_OK=TRUE to allow the program to continue to execute, but that may cause c
rashes or silently produce incorrect results. For more information, please see http://www.intel.com/software/products/support/.

Anyone else has seen this issue previously? The suggested remedy seems to work.
Intel MBP 16"

This is typically due to some funkiness with an existing Conda / Tensorflow install. Bunch of people have. Doing an uninstall/clean install seems to set it right for many - see https://stackoverflow.com/questions/53014306/error-15-initializing-libiomp5-dylib-but-found-libiomp5-dylib-already-initial


Not animating between dotColor and dotIncreasedColor

When you swipe the dots indicators only animate the size - color is set directly. This looks bad especially when you have all the dots of the same size and just depend on the color animation.

I would also love to have this feature!


Proposal: Add mode agnostic css class

We'd like to propose a bit of a change in the components base class. I kinda did a bit of a concept. And i am willing to go through all the components and implement this.
https://github.com/alan-agius4/ionic/commit/5b3b5a250a034a6ea97d2ba21d0ec32d3d004475
basically at the moment for a component a class is added according to the mode set ex: .item-md, .item-wp, .item-md. However, if you'd like to override or add some for all modes it would be quite useful to have a mode agnostic class that you can target ex .item.
To be discussed with @adamdbradley and @brandyscarney.

Agreed, I've had to adjust many styles because of mode-specific classes. As of now, it just causes us to make more CSS

Related, most likely duplicate: #8533


(BUG): Share Post To Public

When starting an Airdrop I have picked "Share link to public" where you are suppose to be able to share the link on any site to claim the airdrop.
I have many subscribers saying it does not allow you to input the URL after you have set up your account.
They have showed me the post and I told them I would report the issue. They are using a site called Minds.com to post the link if that helps.
Edit: Airdrop URL : https://www.mintme.com/token/MTCG/intro/airdrop
Thanks

Hello, it's not connected https://github.com/mintme-com/explorer/issues/32 so please write to<EMAIL_ADDRESS>or any of our social media platform to answer your query in the right way


[5.0] Router group helper

Just adding the missing group helper.
group(['middleware' => 'auth'], function()
{

});

Please send to 5.1.


Optimize the toggle of the prop description

Currently the description toggle is too far and too small to be triggered easily.
There could be some optimization, such as

make the whole item clickable
provide hover tooltip
move the toggle from right to the left

Hi @zhaoyao91,


Filter malfunctioning on genome list

I was looking at Acinetobacter baumannii and saw that there were 134 total genomes:

Under Disease, there is a really weird top entry of (35):

When I click on it, nothing happens except that the page seems to reload.   Not sure what this is doing here, but the its unfortunate that it is at the top of the filter list for Disease.  When I click on anything else in Disease, the filtering seems to work.

metadata problem.


Add AdditionalInfo property to report

For teams that create their own crash reports, they would like to have additional properties to use in their notification templates.
We can add an Dictionary<string, string> AdditionalInfo to the Report object.
https://github.com/microsoft/onefuzz/blob/d99960323de7336e0463f92babb80ebc841fa627/src/ApiService/ApiService/OneFuzzTypes/Model.cs#L489-L513
Then in a notification template, someone could reference is by doing something like report.additional_info.my_custom_field
AB#164905

To further inform the implementation, we are looking to add additional fields that correspond to URLs for extra-outputs artifacts we produce from our analyzer task.
We can generate the download URLs ourselves for these artifacts and add them as additional_info fields, but if they were made explicit then perhaps your agent could add metadata such as error information if the upload failed (for instance).

Closing because this already exists as ExtensionData


Python 3.7+ support

Starting from Python 3.7 async is a reserved keyword and cannot be used, as it causes SyntaxError:
lib/python3.7/site-packages/protorpc/remote.py", line 581
    return async_method(self.async, *args, **kwargs).response
                                 ^
SyntaxError: invalid syntax

it there any way to fix this not changing self.async to self.async_xxx ?


Add opentype features to typetester

If Specimen Skeleton would make use of https://github.com/Wakamai-Fondue/wakamai-fondue-engine/ this would be easy to do. (It'd basically give you access to everything inside the font, variable and features!)

This would be great, @RoelN. When you say 'easy'... ;)
Could you give me a nudge in the right direction for integration into 11ty and Specimen Builder?

This would require a change in Specimen Skeleton Support, instea of the builder/11ty side. The current variable data pipeline should be replaced by Wakamai Fondue Engine, while the rest of the font details would need to be added in a way the Specimen Skeleton could handle them. I figure a day or two worth of work, including adding tests!


Tile sink output options

This could be considered details related to #1002.
When we write an image, we want to be able to control how downsampling is done for lower resolution layers.  In vips, we have (https://www.libvips.org/API/current/VipsRegion.html)
VIPS_REGION_SHRINK_MEAN | use the average
VIPS_REGION_SHRINK_MEDIAN | use the median
VIPS_REGION_SHRINK_MODE | use the mode
VIPS_REGION_SHRINK_MAX | use the maximum
VIPS_REGION_SHRINK_MIN | use the minimum
VIPS_REGION_SHRINK_NEAREST | use the top-left pixel

and, in PIL we have https://pillow.readthedocs.io/en/stable/reference/Image.html#resampling-filters.  PIL properly does this (see https://zuru.tech/blog/the-dangers-behind-image-resizing).
We want to add an optional kwarg: resample that would an enum that would include the PIL Resample modes and the vips options.  For any of the PIL modes, we should just use PIL for downsampling.  For other modes, we probably need to implement this with numpy.
Also, when downsampling, to reduce tile edge effects caused by filtering (e.g., when using Lanczos or hamming), we probably want to pick a larger area, downsample that, and crop.

This issue is a superset of #1486


Why there are max_epoch and max_iter?

As title, why you use max_iter in training loop but still have max_epoch in args?

Hi,
I have the same question. In the default setting, the max_iter=40000, which is mean that the network just need to be trained 38 epoch? (number of images is 12388 in GTA, equal to 1032 batch (batch size=12), 40000/1032 = 38.75)
Thank you!

Hi,
As you know, the optimal epoch can be different depending on your batch size, network architecture, datasets, and so on.
Therefore, training on GTAV may require more iterations as the number of GTAV images is much higher than for Cityscapes.
But, I simply conducted the entire experiment with a fixed iteration of 40K.
Our study does not need to find the optimal epoch, compares our method with other methods under the fair conditions.
It is required to find optimal values for various parameters in order to compete with other methods for best performance in the leaderboard, but our study has not covered this competition.
Thank you!
Sungha.

I got it. Thanks for your help. : )


[W5.3b][W10-A1]Joshua Lee Kai Sheng

-Extracted commonalities from Phone, Email and Address classes into a parent class called Contact

@jlks96
Some comments added. Please ack & close the PR after reading comments.

Acknowledged. Thanks.


Consent subscription support for CJM

https://jira.corp.adobe.com/browse/CJM-7442

In the previous version of the XDM, the "marketing.preferred" and "marketing.any" objects could appear in the main section, "consents.marketing.preferred/any" and in the idSpecific section, such as<EMAIL_ADDRESS>We have no use cases where these should be specified in the idSpecific section, and no data that has been ingested into AEP where this is the case. In my update, these two fields are only allowed to appear in the main section.

@RussStringham - is there anyone else needed to be reviewed and be approving this ?

The PR requires approval from the UPS and CJM teams

LGTM for CJM use cases


Add a --base-path option to the CLI

Changes proposed in this pull request:

add a --base-path option to the CLI which overrides (or provides) the basePath from the spec

This allows deploying at different paths without editing the API spec.

Coverage remained the same at 100.0% when pulling 8a67a3bf3fe6b9dd377397d58edd867380e04b6a on havocp:base-path-via-cli into 1d3fd38a444b3c36ce8f963f4b4fbfba5f6d4c9f on zalando:master.

Coverage remained the same at 100.0% when pulling 8a67a3bf3fe6b9dd377397d58edd867380e04b6a on havocp:base-path-via-cli into 1d3fd38a444b3c36ce8f963f4b4fbfba5f6d4c9f on zalando:master.

Thanks for the PR!

:+1:

Released in https://github.com/zalando/connexion/releases/tag/1.0.124

That was very efficient. Thanks!


Fixed #27670 -- Prevented shell command from masking ImportErrors.

Ticket

Thanks @adamchainz, @timgraham, and @knbk for your reviews.  I think I've addressed all the comments.
However, there's a problem with the new tests, in that they pass when run individually or as part of the full test suite with --parallel=1, but as soon as tests run in parallel, the tests fail.  This is because something (I haven't worked out what yet) is closing stdin, causing the select here to return something, which means we never get to the new code.
Is there a way for a test to detect whether it's being run in parallel?  If so, could we skip these tests in that case?

If so, could we skip these tests in that case?

I think we should just fix the fundamental problem. It was probably only added 14 days ago in #7681 , maybe not detected then because there weren't any other tests running shell after ones it added.

Would changing
 if sys.platform != "win32" and select.select([sys.stdin], [], [], 0)[0]:
    exec(sys.stdin.read())
    return

to
if sys.platform != "win32" and select.select([sys.stdin], [], [], 0)[0]:
    data = sys.stdin.read()
    if data:
        exec(data)
        return

be an adequate fix?
Or should we aim to fix the problem of stdin getting closed when tests are run in parallel?

I think your change is against the spirit of #7681 , which was trying to bring ./manage.py shell in line with python, which still "executes" an empty stdin and exits:
$ python <<< ''
$

That said it's such an edge case it might be more convenient to just do it. Fixing the parallel test environment to match the non-parallel one is likely to prevent future similar bugs with stdin of course.

Makes sense. Test failures all seem to be widget rendering ones

I'm not sure if I like the approach in general. Would it be possible to make a change in the python method to raise something other than ImportError for the problematic case you discovered so that same boilerplate isn't needed in the other methods?

@timgraham It's not possible as far as I understand because the import errors we're trying to avoid masking occur in the non import lines e.g. app = TerminalIPythonApp.instance() and it's not possible in python to detect what exactly failed to import where, without doing horrible traceback inspection.

Okay, Peter perhaps you can confirm that's the case -- it's not clear to me from the ticket exactly where the problem is. Anyway, that does give me the idea to first remove support for IPython < 1.0 to simplify this a bit: https://github.com/django/django/pull/7821.

The original ImportError was actually raised when using the python interface when exec()ing my .pythonrc.py file.
I should have thought through this properly sooner, but I think the fix is actually to catch any exception raised by that exec, print the traceback to screen, and carry on.  This would match the behaviour of the normal Python prompt, as well as that of bpython and IPython.
I'll close this PR and open two more: one to fix this problem, and one to provide a better error message when you try to use a shell that's not installed.


Update ISSUE_TEMPLATE.md

Edited the format of the ISSUE_TEMPLATE.md
Bullet points for the questions to make more clear and easy to read.
Happy to help the OTTO project!

Thanks welcome to the developer Otto community!


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_04b0cyuh2t/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_04b0cyuh2t/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_04b0cyuh2t/clone/recipe/meta.yaml:43: http_url: http://doc.devpi.net/ is not https
ERROR: /tmp/abs_04b0cyuh2t/clone/recipe/meta.yaml:43: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_04b0cyuh2t/clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
Errors were found


missing laserVisibility ViewfinderView

Description of the problem:
missing laserVisibility ViewfinderView
version: 4.0.2
I cannot find the laserVisibility  property in ViewfinderView

This will be included in the next release.

Thanks! 😄

Thanks, released in 4.1.0.


Add some space on Cart Icon and enhance the cart page

add some space in this icon

Enhance this cart page

also add a product remove button on it so that costumer can remove any product which they want

I would like to work on this issue. please assign this to me @codervivek5

any update ???

@codervivek5 I am working on it.


[FEAT] Passing arbitrary graphql variables to hasura dataProvider

Is your feature request related to a problem? Please describe.
I am very pleased that gqlQuery allows us to perform arbitrary GraphQL Queries against hasura.
https://github.com/refinedev/refine/issues/5489
However, it is not possible to use hasura's powerful filters because only CrudFilter[] can be passed to filters in the useTable. It is also not possible to use variables type information generated by graphql codegen.
In my case.
Given a type with the relation User has many Books, I can write a query in hasura to get a list of Users who have 3 or more Books, which is not possible in the current CrudFilter.
Describe alternatives you've considered
added to the following line in hasura dataProvider.
        variables = {
          ...hasuraPagination,
          ...(hasuraSorting &&
            (namingConvention === "graphql-default"
              ? {
                orderBy: hasuraSorting,
              }
              : {
                order_by: hasuraSorting,
              })),
          ...(hasuraFilters && {
            where: hasuraFilters,
          }),
          ...(meta?.gqlVariables && meta?.gqlVariables), // added
        };

https://github.com/refinedev/refine/blob/master/packages/hasura/src/dataProvider/index.ts#L181
This allows the addition of any where condition supported by hasura, using type information hints, as follows.
  const { tableProps } = useTable<GetFieldsFromList<BlogPostsQuery>>({
    syncWithLocation: true,
    meta: {
      gqlQuery: BlogPostsDocument,
      gqlVariables: {
        where: {
          _and: [
            {
              title: {
                _ilike: "%test%",
              },
            }
          ],
        },
      } as BlogPostsQueryVariables, // generated type from graphql query
    },
  });

Additional context
No response
Describe the thing to improve

add gqlVariables?: any to GraphQLQueryOptions

Ideally, I would like to pass the type information generated from the graphql query by type parameter instead of any, but I can't think of a way to achieve that right now.

use meta.gqlVariables in getList, getMany of hasura dataProvider

Hello @tomoemon, thanks for the issue.
It seems like a good idea, but can you give me the GQL Query you want to generate so I can better understand the problem? Maybe we can make CrudFilter[] to support this.

@alicanerdurmaz Thank you for your response!
For example, I want to execute the following query
Trying to get a list of categories that have at least one Posts with the string "test" in the title.
If the Posts is related to another type, I want to add more nested filters.
query Categories {
    categories(
        where: {
            posts_aggregate: {
                count: {
                    predicate: { _gte: 1 },
                    filter: {
                        content: { _ilike: "%test%" }
                    }
                }
            }
        }
    ) {
        id
        title
    }
}

schema
type Posts {
    id: ID!
    title: String!
    content: String!
    categories: Categories!
}

type Categories {
    id: ID!
    title: String!
    posts: [Posts!]!
    posts_aggregate: posts_aggregate!
}

In my opinion, such a condition would be too complex to add to the CrudFilter. Writing complex filter conditions without type completion may also cause bugs.

@tomoemon Thanks for the detailed explanation, we'll see what we can do.

Hey @tomoemon I think you should use meta.gqlQuery and meta.gqlMutation fields. There you can pass your GraphQL queries created with graphql-tag.
https://refine.dev/docs/data/packages/hasura/#usage-with-graphql-tag

@BatuhanW
I don't understand why it was closed.
Do you mean that I should put a specific filter condition directly on the where argument in the gql tagged query?
If so, I can use any filter in hasura, but then how do I give it a dynamic value?

Hey @tomoemon, you are right. I think we can accept extra variables field in the data provider and pass it to the query variables.

We are open to contributions for this. This feature can be applied to following packages:

@refinedev/hasura
@refinedev/graphql
@refinedev/nestjs-query

Hi @BatuhanW
I'd love to work on this feature, could you assign it to me? Thanks!

Hi @aliemir can you please assign this ticket to me? I've begun working on adding support for this enhancement! 🚀

Hey @Sergio16T assigned! Let us know if you have any issues 🙏

Hello @aliemir, @BatuhanW, @alicanerdurmaz I've opened an initial draft PR!  The PR description contains notes on pending work that was out of scope for initial changes as well as some questions to consider about desired functionality for meta.gqlVariables and how these should affect table column filters(initial, clear).
Currently the changes apply the meta.gqlVariables to each query with the assumption that these filters are used to reduce the data set returned by the graphQL query and any table column filters will apply to the dataset returned.
The scope of this PR includes packages/hasura and core package GraphQLQueryOptions type. Once discussion is resolved I can continue dev work on nestjs and graphql packages.As well as any potential changes to useTable Hook.
Let me know what your team thinks after reviewing the PR description.
I look forward to hearing from you.


Cholesky2

copied branch cholesky to cholesky2 to see if it fixes checks running. If so, this will be the cholesky PR.

Codecov Report
Base: 70.28% // Head: 66.52% // Decreases project coverage by -3.76% :warning:

Coverage data is based on head (eb005a5) compared to base (4f75b5f).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   70.28%   66.52%   -3.77%
==========================================
  Files          10       10
  Lines         212      230      +18
==========================================
+ Hits          149      153       +4
- Misses         63       77      +14

Impacted Files
Coverage Δ

src/matrix_utilities.jl
60.52% <11.76%> (-34.72%)
:arrow_down:

src/distributions/normal.jl
97.14% <100.00%> (+0.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I guess two points of discussion would be:

What kind of covariance parametrisation should the outputs of

marginalise(N, K)
invert(N, K)
have? Currently the outputs should have the same covariance parametrisation in N but this is not in tests yet.

[Matrix; Diagonal]
returns a SparseArrays.SparseMatrixCSC, which breaks stein / schur_red without dispatching on Diagonal which is the current solution.


No method for setBaselineFunc on iOS

Report

[x] I have searched existing issues and this is not a duplicate

Issues and Steps to Reproduce
On iOS, we use flexlayout by YGLayout . If  I want to align items by baseline, I found it didn't work. After searching the code of Yoga, I found that I should provide baselineFunc.
But there isn't any method for me to set baselinefunc, I can't get the node of view either.
Expected Behavior
Providing a method to set baselineFunc.
Link to Code
https://github.com/facebook/yoga/blob/master/YogaKit/Source/YGLayout.h

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.


ThreadError can't create Thread: Resource temporarily unavailable

Debian wheezy or  jessie. ruby 2.4 and bunder 1.16.1
error in bundle install
user@labsrv:~/test$  rvm use 2.4 do bundle install --path ./gems
Fetching gem metadata from https://rails-assets.org/..
Fetching gem metadata from https://rubygems.org/.Failed to create threads for the Compact Index (rubygems.org) worker: can't create Thread: Resource temporarily unavailable
Retrying fetcher due to error (2/4): ThreadError can't create Thread: Resource temporarily unavailable.
Retrying fetcher due to error (3/4): ThreadError can't create Thread: Resource temporarily unavailable.

Hi!
No
user@labsrv:~/test$ rvm use 2.4 do bundle install -j 1 --path ./gems/
root@labsrv:~# ps -mu user | wc -l
50

That's probably because the compact index updater is set to automatically use a whole bunch of threads

I guess the key point is the 25 hardcode in https://github.com/bundler/bundler/blob/master/lib/bundler/fetcher/compact_index.rb#L100
def bundle_worker(func = nil)
        @bundle_worker ||= begin
          worker_name = "Compact Index (#{display_uri.host})"
          Bundler::Worker.new(Bundler.current_ruby.rbx? ? 1 : 25, worker_name, func)
        end
        @bundle_worker.tap do |worker|
          worker.instance_variable_set(:@func, func) if func
        end
      end

I'm going to limit thread pool for compact index updater. What is the best way to impement this fix?

Introduce new ENV variable which set pool size
Align compact indexer thread pool size with -j option
Introduce new option to set this

The worker should transparently handle hitting the thread limit...

@mislav please try with bundler 1.16.2

@segiddins not working for me using 1.16.2

With the same backtrace ?

On a BlueHost server...
Retrying fetcher due to error (2/4): ThreadError can't create Thread: Resource temporarily unavailable.
Retrying fetcher due to error (3/4): ThreadError can't create Thread: Resource temporarily unavailable.
Retrying fetcher due to error (4/4): ThreadError can't create Thread: Resource temporarily unavailable.
^C/home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/timeout.rb:81:in start': can't create Thread: Resource temporarily unavailable (ThreadError) 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/timeout.rb:81:in block in timeout'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/timeout.rb:101:in timeout' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/net/http.rb:878:in connect'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/net/http.rb:863:in do_start' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/net/http.rb:858:in start'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb:702:in start' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb:967:in reset'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb:630:in connection_for' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/vendored_persistent.rb:23:in connection_for'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb:996:in request' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/fetcher/downloader.rb:51:in request'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/fetcher/downloader.rb:17:in fetch' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/fetcher/compact_index.rb:117:in call'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/compact_index_client/updater.rb:53:in block in update' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/2.3.0/tmpdir.rb:89:in mktmpdir'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/compact_index_client/updater.rb:31:in update' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/compact_index_client.rb:82:in update'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/compact_index_client.rb:98:in update_info' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/compact_index_client.rb:55:in block in dependencies'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/fetcher/compact_index.rb:88:in block (3 levels) in compact_index_client' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/worker.rb:64:in apply_func'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/worker.rb:59:in block in process_queue' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/worker.rb:56:in loop'
from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/worker.rb:56:in process_queue' 	from /home2/miamini2/.rvm/rubies/ruby-2.3.7/lib/ruby/site_ruby/2.3.0/bundler/worker.rb:90:in block (2 levels) in create_threads'
<EMAIL_ADDRESS>[~/museum]# bundle env
fatal: not a git repository (or any parent up to mount point /home2)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Environment
Bundler       1.16.2
  Platforms   ruby, x86_64-linux
Ruby          2.3.7p456 (2018-03-28 revision 63024) [x86_64-linux]
  Full Path   /home2/miamini2/.rvm/rubies/ruby-2.3.7/bin/ruby
  Config Dir  /home2/miamini2/.rvm/rubies/ruby-2.3.7/etc
RubyGems      2.7.7
  Gem Home    /home2/miamini2/.rvm/gems/ruby-2.3.7
  Gem Path    /home2/miamini2/.rvm/gems/ruby-2.3.7:/home2/miamini2/.rvm/gems/ruby-2.3.7@global
  User Path   /home2/miamini2/.gem/ruby/2.3.0
  Bin Dir     /home2/miamini2/.rvm/gems/ruby-2.3.7/bin
Tools
  Git         2.17.1
  RVM         1.29.4 (latest)
  rbenv       not installed
  chruby      not installed

I've proposed PR which demonstrates the problem and possible solution.

Could someone please provide a workaround? The client's breathing down my neck.

@dwn I can't figure how to workaround, you may build version from my PR and use it providing COMPACT_INDEX_POOL=1 env variable.


Tween follow_property/method return Nan on the last frame

Godot version: 3.0, 3.0.2 and a9acdd84b7a6fd074f21d500a64976326f6cbb67
OS/device including version: Ubuntu 64 bit
Issue description:
follow_property and follow_method at the last frame set node's position to (0,0)
Steps to reproduce:

Your project HAS to be EXPORTED as with DEBUGGING OFF
Call "follow_property" on a tween interpolating node's position (I only tested with Vector2)
Let it playout till the end
Notice that node's position at the last frame teleports to (0,0)

It also works if you do it with "follow_method".
That way i figured out that in the last frame it gives NAN
Minimal reproduction project:
WARNING: this project was opened by the 3.1 so 3.0.* cant open it
TweenBug.zip

This may be compiler specific and/or related to the other Vector2 -> NaN issue we found before? (happened when compiling with clang)

Retested with 4b6846a59d785af3bef6a29958387ed0ee0f6575 and bug still happends

Still occuring on a 3.1 beta 3.
Created a minimal testing project for this: TweenFollow.zip in 2D
with shortcuts for tweening, reloading scene and switching between follow_property and follow_method.

I leared something recently in Godot 3.1 and 3.1.1. When you use custom method to set position it works fine. Here is an updated project from DleanJeans with that fix included as an option TweenFollow.zip

Fixed by #32951.


Update README.rst

Add issues section and note about python 3 support

I've changed base.py in my fork to remove the call to encode. I'd like to perform the full changes to support python3, any suggestions on where to start?

@chrisgogreen awesome!
I wish I could be more help, but ATM none of our clients are using ODBC backends, so we haven't been able to use this library in a while with a production app. If you're working with one atm, just get started and submit an ongoing PR so we can manage the merge. Would definitely be great to have Python 3 support :)


chore: upgrade Kalix Proxy to 1.0.15

References Kalix Proxy 1.0.15

Leaving this as draft until 1.0.15 is in prd

CI failing with is missing the following properties from type 'ProxyInfo__Output': 'internalProxyHostname', 'proxyPort'..
I believe these are new fields introduced on the protocol and relate with #396 .. So I believe we need to wait for that PR to be merged and then I expect this to be ok.

CI failing with is missing the following properties from type 'ProxyInfo__Output': 'internalProxyHostname', 'proxyPort'..
I believe these are new fields introduced on the protocol and relate with #396 .. So I believe we need to wait for that PR to be merged and then I expect this to be ok.

That's strange. PR #396 should depend on this PR, not the other way around.
New fields were introduced in proxy 1.0.15, but the SDK should remain compatible.

Depends on #401

Rebased against main. See if CI likes this better :)

CI is upset about all this.

CI is upset about all this.

And rightly so because I forgot @octonato 's contribution to this PR and ended sweeping his changes with the rebase. 😅
On it :)

CI happy now.. Merging

CI failing with is missing the following properties from type 'ProxyInfo__Output': 'internalProxyHostname', 'proxyPort'..
I believe these are new fields introduced on the protocol and relate with #396 .. So I believe we need to wait for that PR to be merged and then I expect this to be ok.

That's strange. PR #396 should depend on this PR, not the other way around.
New fields were introduced in proxy 1.0.15, but the SDK should remain compatible.

The __Output types are what will be received on the protocol, and these have all properties as required, as they'll have defaults applied for anything that's missing. This test creates the messages directly, so will need values when the protocol is updated. But it's only this test, the rest will be compatible.


Different model name in test_dota_r3det.py

In test_dota_r3det.py:  if cfgs.NET_NAME in ['resnet152_v1d', 'resnet101_v1d', 'resnet50_v1d']:
When downloaded from the link names are represented as: resnet_v1_50.ckpt, resnet_v1_101.ckpt, resnet_v1_152.ckpt

@aihyper11


Feature/add tooltips to left panel

Resolves: Add hover tooltips to left panel
The proper positioning of the tooltips over the non-star checkboxes was tricky, and the best solution I could come up with was to manually set their alignment offsets in pixels to match the position of the checkboxes in the current layout.

Pull request recommendations:

[x] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
[x] Link to any relevant issue in the PR description. Ex: Resolves [gh-##], adds tiff file format support
[x] Provide description and context of changes, including any helpful screenshots.
[ ] Provide relevant tests for your feature or bug fix.
[x] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

The code looks good to me, but in the screen shot, the tooltip over the background is really hard to differentiate, I thought it was a glitch at first... does it look clear when it's interactive?

The code looks good to me, but in the screen shot, the tooltip over the background is really hard to differentiate, I thought it was a glitch at first... does it look clear when it's interactive?

The code looks good to me, but in the screen shot, the tooltip over the background is really hard to differentiate, I thought it was a glitch at first... does it look clear when it's interactive?

No, I agree that it's hard to see the shape of the bubble. How's this? I can't figure out a way to add a border to the bubble (the triangular tip of the bubble gets left outside of the outline when I try) but can change the color to something like this.

The code looks good to me, but in the screen shot, the tooltip over the background is really hard to differentiate, I thought it was a glitch at first... does it look clear when it's interactive?

No, I agree that it's hard to see the shape of the bubble. How's this? I can't figure out a way to add a border to the bubble (the triangular tip of the bubble gets left outside of the outline when I try) but can change the color to something like this.

I like the lighter color for legibility but it seems like the tint isn't one of our grays? Just that it's missing the slight purply/cool tone. But otherwise yeah, I think that's a lot clearer.

I like the lighter color for legibility but it seems like the tint isn't one of our grays? Just that it's missing the slight purply/cool tone. But otherwise yeah, I think that's a lot clearer.

I like the lighter color for legibility but it seems like the tint isn't one of our grays? Just that it's missing the slight purply/cool tone. But otherwise yeah, I think that's a lot clearer.

Okay how is this? :)

I like the lighter color for legibility but it seems like the tint isn't one of our grays? Just that it's missing the slight purply/cool tone. But otherwise yeah, I think that's a lot clearer.

Okay how is this? :)

I agree the lighter color sticks out better, and the bluish gray one looks good

I agree the lighter color sticks out better, and the bluish gray one looks good

that looks great!

that looks great!


Missing horizon graph from UI

Hi there,
Small question, I saw this visualization in the gallery section https://rawgraphs.io/gallery_project/datavizsociety-slacks-activity/ it's written that they use the "Horizon Graph" but I can't find this option in the RawGraph UI.
This type of visualization was removed or it is under another name?
PS: Sorry if I use the wrong label for the issue

Closed with f34edf9c4c23dc1b69b573765cbd562b5fad8e7d. It's available on the dev version, will be publicly available in the next release


Lambda filter 403, error

I use aws lambda filter , and get 403 , I confirm I use right AK/SK , Region in my docker env, I'm not sure there have anything I missed .
myconfig:
admin:
  access_log_path: /tmp/admin_access.log
  address:
    socket_address:
      protocol: TCP
      address: <IP_ADDRESS>
      port_value: 9901
static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address:
        protocol: TCP
        address: <IP_ADDRESS>
        port_value: 10000
    filter_chains:
    - filters:
      - name: envoy.filters.network.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          stat_prefix: ingress_http
          access_log:
            - name: envoy.file_access_log
              config:
                 path: "/dev/stdout"
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains: ["*"]
              routes:
              - match:
                  prefix: "/"
                route:
                  cluster: service_bing
          http_filters:
          - name: envoy.filters.http.aws_lambda
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.aws_lambda.v3.Config
              arn: "arn:aws:lambda:us-east-1:111111111111:function:hello_envoy"
              payload_passthrough: true
          # - name: envoy.filters.http.cors
          #   typed_config: {}
          - name: envoy.filters.http.router
            typed_config: {}
  clusters:
  - name: service_bing
    connect_timeout: 10s
    type: LOGICAL_DNS
    # Comment out the following line to test on v6 networks
    dns_lookup_family: V4_ONLY
    lb_policy: ROUND_ROBIN
    metadata:
      filter_metadata:
        com.amazonaws.lambda:
           egress_gateway: true
    load_assignment:
      cluster_name: service_bing
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: lambda.us-east-1.amazonaws.com
                port_value: 443
    transport_socket:
      name: envoy.transport_sockets.tls
      typed_config:
        "@type": type.googleapis.com/envoy.api.v2.auth.UpstreamTlsContext
        sni: "*.amazonaws.com"

docker logs output:
[2020-05-22T06:38:46.302Z] "POST /2015-03-31/functions/hello_envoy/invocations HTTP/1.1" 403 - 14 192 1749 1748 "-" "curl/7.54.0" "8960a55f-500c-413a-856e-528019e0a2b9" "localhost:10000" "<IP_ADDRESS>:443"
curl test get error message:
{"message":"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details."}

this is envoy debug log,
====================
envoy print  AWS credentials information
2020-05-22 07:18:36.067][12][debug][aws] [source/extensions/common/aws/credentials_provider_impl.cc:41] Getting AWS credentials from the environment
[2020-05-22 07:18:36.067][12][debug][aws] [source/extensions/common/aws/credentials_provider_impl.cc:54] Found following AWS credentials in the environment: AWS_ACCESS_KEY_ID=AKIAYVBRQ5UTN2M9TBSR, AWS_SECRET_ACCESS_KEY=*****, AWS_SESSION_TOKEN=
====================
envoy print  sign header
[2020-05-23 00:26:19.868][12][debug][router] [source/common/router/router.cc:597] [C5][S8274519224793556409] router decoding headers:
':authority', 'localhost:10000'
':path', '/2015-03-31/functions/hello_envoy/invocations'
':method', 'POST'
':scheme', 'https'
'user-agent', 'curl/7.54.0'
'accept', '/'
'content-type', 'application/json'
'content-length', '312'
'x-forwarded-proto', 'http'
'x-request-id', 'cbc645fc-701f-4984-85e9-49f91106961c'
'x-amz-invocation-type', 'RequestResponse'
'x-amz-content-sha256', 'b867b51fb7fabda085c87dda7b0845d27e1fe7b0f37b8f93f56397d94af8e090'
'x-amz-date', '20200523T002600Z'
'authorization', 'AWS4-HMAC-SHA256 Credential=/20200523/us-east-1/lambda/aws4_request, SignedHeaders=accept;content-length;content-type;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-invocation-type;x-request-id, Signature=1585fa55648ec1170dd24b3c83453bd92b9eb598d907acad73cc2762bd8ba514'
'x-envoy-expected-rq-timeout-ms', '15000'
====================
envoy print  403 error
[2020-05-23 00:26:20.882][12][debug][http] [source/common/http/conn_manager_impl.cc:1767] [C5][S8274519224793556409] encoding headers via codec (end_stream=false):
':status', '403'
'date', 'Sat, 23 May 2020 00:26:20 GMT'
'content-type', 'application/json'
'content-length', '192'
'x-amzn-requestid', '13b01d25-1b7a-4f34-94f8-1ab5d3e123d8'
'x-amzn-errortype', 'InvalidSignatureException'
'x-envoy-upstream-service-time', '1013'
'server', 'envoy'
I'm not familiar with c++,  so I try use python use this header , create post function send data to lambda endpoint(https://lambda.us-east-1.amazonaws.com), get same 403 error too.

I missing "host" header ,  aws signer use default host "localhost:10000" for sign string,  I use -H 'Host: lambda.us-east-1.amazonaws.com' ,  it's works !
curl -v -H "Content-Type:application/javascript" -H 'Host: lambda.us-east-1.amazonaws.com' -X POST -d @data.json localhost:10000

I flound this error because signer use default header "localhost:10000" , but upstream is aws lambda endpoint , need set host same to as endpoint , etc "lambda.us-east-1.amazonaws.com".
I think  customer already setup lambda arn etc. "arn:aws:lambda:us-east-1:111111111111:function:hello_envoy",  so I think customer don't need set special header , so I create PR use lambda region as default host.

cc @marcomagdy

@stevensu1977 I copy pasted your configuration, changed only the function ARN and It works perfectly fine for me.
We don't need to set the host header. The upstream cluster takes care of that.

@marcomagdy  thank your quick feedback,  but I think there still have  issue , I get detail from trace log, you can see , if I don't use host header ,  envoy should use "host:localhost:10000" to aws auth signer and general "authorization" header for aws lambda filter , when I lambda filter invoke post to aws lambda endpoint this authorization is wrong (because host is aws lambda endpoint ), I use base image id  "envoyproxy/envoy-dev:54dedadaa8aeac2963c7d47d46199ba3323527e5", if I missing something please tell me , thank you !
my test :
➜  serverless-controller curl -H "Content-Type:application/json"  localhost:10000
{"message":"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details."}%                                                                                ➜  serverless-controller curl -H "Content-Type:application/json" -H "host:lambda.us-east-1.amazonaws.com" localhost:10000
"hello lambda from EKS. body is: "%
trace log:
[2020-05-27 08:40:13.124][11][debug][http] [source/extensions/common/aws/signer_impl.cc:66] Canonical request:
POST
/2015-03-31/functions/hello_envoy/invocations
accept:/
content-length:265
content-type:application/json
host:localhost:10000
user-agent:curl/7.54.0
x-amz-content-sha256:95f404cd309a87a04ae9702689de02ad5945535f9e57d02146e1abb144f21f1c
x-amz-date:20200527T084000Z
x-amz-invocation-type:RequestResponse
x-request-id:556c8dd5-e32b-41ad-8eb6-e700402d25d1
accept;content-length;content-type;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-invocation-type;x-request-id
95f404cd309a87a04ae9702689de02ad5945535f9e57d02146e1abb144f21f1c
':authority', 'localhost:10000'
':path', '/2015-03-31/functions/hello_envoy/invocations'
':method', 'POST'
':scheme', 'https'
'user-agent', 'curl/7.54.0'
'accept', '/'
'content-type', 'application/json'
'x-forwarded-proto', 'http'
'x-request-id', '556c8dd5-e32b-41ad-8eb6-e700402d25d1'
'x-amz-invocation-type', 'RequestResponse'
'content-length', '265'
'x-amz-content-sha256', '95f404cd309a87a04ae9702689de02ad5945535f9e57d02146e1abb144f21f1c'
'x-amz-date', '20200527T084000Z'
'authorization', 'AWS4-HMAC-SHA256 Credential=AKIAYVRRQ4TUN2M4TBSR/20200527/us-east-1/lambda/aws4_request, SignedHeaders=accept;content-length;content-type;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-invocation-type;x-request-id, Signature=7341f24dffc0d300ef6e5f69dea305670c2659734b2a2d7aec746cb580e2505c'

@stevensu1977 I was able to reproduce what you are seeing.
The problem will not happen if you pass any host header. It doesn't have to be Lambda's regional endpoint. In fact, if you pass -H "Host: localhost" it will work just fine.
The problem happens when you don't pass any host header, Envoy sets the header to
"localhost: 10000" and then the port section gets signed. On the other hand the AWS Lambda side won't include the port in the signature, therefore you end up with that error.
So, I don't know if we need to make any changes to the filter. But if we do, it would be to
remove the :<port> part from the host header before signing it.

@marcomagdy , thank your comments , I got it , you are right , send any host header it's work ,  I should close this issue and PR , thank's again.


Remove usage od deprectaed LegacyMap

Which components does the task require to be changed? (think hard pls)
snforge
Description
In some places in packages in crates/forge/tests/data we're still using deprecated LegacyMap. We should update it to use starknet::storage::Map instead.
Example usages:
https://github.com/foundry-rs/starknet-foundry/blob/8df49f64d420740e1b946f68ec7c414af77aca0e/crates/sncast/tests/data/scripts/map_script/contracts/src/lib.cairo#L13
https://github.com/foundry-rs/starknet-foundry/blob/8df49f64d420740e1b946f68ec7c414af77aca0e/crates/forge/tests/data/component_macros/src/oz_ac_component.cairo#L18

I'd be glad to work on this issue. Could you please assign it to me?

Hello @franciszekjob ,
Please  assign this issue  to me .

This issue is reserved for ODHack. Please apply through the page as outlined there after the hack starts
https://app.onlydust.com/hackathons/odhack-90

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hello,
I started learning blockchain programming 2 years ago in my free time. I would like to continue my learning by contributing to open source projects. I'm also very excited to learn the different github workflows related to open source contribution. I have a first experience in Cairo via Node Guardians and BaseCampX.
How I plan on tackling this issue
I'll fork the repository, run the tests first to see if everything is ok. Then I'll find and replace the LegacyMap instance with the Map (and update the crates to use). Run the test and fix any issues if there are any.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi @franciszekjob, I'm a software developer with 2+ years of experience and I have worked with backend technologies such as Cairo, Java, C# and frontend with React, NextJS, JS/TS. Also, I'm a member of the Dojo Coding community here in CR and I have made contributions in Cairo VM Go, Cairo VM TS, Cairo Lints etc. Likewise, I’m a Cairo developer working on ByteBeasts, a fully on-chain RPG game built using the Dojo Engine framework.
How I plan on tackling this issue

I’ll locate all instances of LegacyMap in the mentioned files and update them to use starknet::storage::Map.
After making the changes, I’ll run tests to ensure everything works correctly.
I’ll also check for any other occurrences of LegacyMap in the codebase to ensure a complete update.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I'm Poulav Bhowmick, a Starknet Wolf. I am a software engineer at Invisible Studios, and a blockchain engineer with a robust background in TypeScript, Rust, Solidity Cairo, fullstack development and blockchain technology. My experience includes building robust applications, optimizing functionalities and blockchain integration. I have actively participated in events and open source contributions, enhancing my capability to tackle real-world tech challenges. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum, Stellar ecosystem.
How I plan on tackling this issue
To resolve this issue, I will identify all instances where the deprecated LegacyMap is still being used within the affected packages, particularly in the snforge directory. I will replace these usages with the newer starknet::storage::Map type. This change will involve updating the imports, as well as modifying the syntax where LegacyMap is used in contracts, tests, and scripts. Specifically, I will refactor instances like storage: LegacyMap::<felt252, felt252> and SRC5_supported_interfaces: LegacyMap<felt252, bool> to use the new Map type. Once the refactor is complete, I will ensure that all tests pass by running the test suite and verifying that no functionality is broken due to the update.
ETA- 1 day

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi my name is Osas, I am a Cairo and Javascript Developer , I love to contribute to projects like this because I use them everyday and really love and appreciate them
How I plan on tackling this issue
I would go through all the files and with the help of my language server find and change the legacy map to naps an the I would compile and test the codebase

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hello again, My name is Deon and I am a Full-Stack Web3 developer with sufficient experience building web3 applications/smart contracts with Rust, as well as high-performance backends.
I have a solid understanding of both backend development and data management which I believe makes me qualified to tackle this issue.
How I plan on tackling this issue

Firstly I’ll review the code in crates/forge/tests/data to locate all instances of LegacyMap usage.

Then I’ll replace with starknet::storage::Map: Update each occurrence to use starknet::storage::Map instead, ensuring that the new implementation aligns with the intended functionality.

I’ll then run the existing test suite to verify that all tests pass after the changes, ensuring that the refactoring did not introduce any issues.

Then If necessary, update any related documentation to reflect the changes made during the update.

I believe by following these steps, I will modernize the codebase, enhancing compatibility and ensuring that we are using the most current practices.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, I am a skilled Cairo dev with lots of experience contributing to amazing projects, my profile is a witness to that statement and i've had experience upgrading contracts to the latest versions of Cairo.
How I plan on tackling this issue
I'll refactor the necessary aspect of the repo and ensure no existing functionality/test are broken.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a Rust developer with a solid background in blockchain technology and experience contributing to various projects. My proficiency with Rust has been honed through multiple projects where I worked on optimizing performance and ensuring code sustainability. I’m passionate about contributing to open-source initiatives, especially those that drive innovation in blockchain, like Starknet Foundry.
How I plan on tackling this issue
To address the issue of removing the deprecated LegacyMap from the codebase, I plan to:

Identify all occurrences of LegacyMap within the crates/forge/tests/data package.
Refactor each instance, replacing LegacyMap with the updated starknet::storage::Map.
Run the existing tests to ensure that all functionality remains intact after the refactor.
Implement any additional test cases if necessary to cover edge cases specific to the starknet::storage::Map usage.
Conduct a thorough review of the changes to ensure compatibility and correctness across the package.

I’m excited about the opportunity to contribute to Starknet Foundry and would love to be considered for this issue.

Let me know if you'd like any tweaks!

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
GM @kkawula, I am Sagar Rana, a smart contract developer and full stack engineer. I have 3 years of experience building robust full stack applications and over a year of writing smart contracts. You can see my projects and contributions to some major repos on my GitHub profile. The tech stack I use mainly includes Solidity, Rust, JavaScript and Typescript. I am also contributing to the Starknet and Rust ecosystems and building on Cairo and Rust languages. I am interested in contributing to projects like this to learn more about these technologies and help make these projects better. Please assign me as I would be really glad to be a contributor in this project! :)
How I plan on tackling this issue

I found 14 instances where LegacyMap has been used across the codebase. I will replace each and every one of them to use Map instead, from starknet::storage::Map
Test the codebase by running and make sure no errors arise.
Create the PR

ETA: 1 Day

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, please can I be assigned this please? This would be my first time contributing to this project and I would love to be the given the opportunity to contribute. I have experience in html, css, JavaScript,TypeScript and solidity, and Cairo.
How I plan on tackling this issue
To solve this issue, I’ll take the following steps:
1. I’ll have to first identify all instances of LegacyMap in the codebase, particularly in test and contract files under crates/forge/tests/data and crates/sncast/tests/data.
2. Then replace LegacyMap with starknet::storage::Map in all occurrences. Mappings like:
LegacyMap::<felt252, felt252> → starknet::storage::Map::<felt252, felt252>
For boolean maps: LegacyMap::<felt252, bool> → starknet::storage::Map::<felt252, bool>.
3. Next, I’ll update imports to include starknet::storage::Map where necessary. I’ll also clean up any deprecated code related to LegacyMap after the transition is complete.
4. Lastly, i’ll run tests to ensure the changes work correctly.
Please assign me, I’m ready to work.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hello, I’m Jose Mario from Costa Rica. With over 15 years of experience in development, I am passionate about contributing to open-source projects and currently expanding my skill set with Rust, Cairo, and Solidity, participated in ODHacks since 7.0 as part of my involvement with Dojo Coding. I am eager to apply my extensive experience and newly acquired skills to new challenges and innovative projects.
How I plan on tackling this issue
. Locate all instances of LegacyMap and replace with starknet::storage::Map
. Ensure that all method calls used with LegacyMap are compatible with Map, adjusting as necessary
. Run tests to verify that everything works correctly after the changes

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hello, can I be assigned to work on this issue?
I'm a software developer with over 4 years experience
Here's my OnlyDust profile https://app.onlydust.com/u/raizo07
ETA: One day

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
i have experience in cairo and blockchain previously as personal projects and OS, so hoping to make use of them here and mark my first odhack contribution
How I plan on tackling this issue
I'll approach the LegacyMap modernization systematically across both crates/forge/tests/data and crates/sncast/tests/data directories, with special focus on component_macros and map_script contract tests, while implementing a validation script to ensure we catch any deeply nested instances that standard searches might miss.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am an experienced Rust dev and have experience working on various open sources projects.
I've implemented a cheatcode in the foundry repo: https://github.com/foundry-rs/foundry/pull/8258/
How I plan on tackling this issue
I will find all instances of LegacyMap and update it to use starknet::storage::Map instead, and I will make sure the tests will passing and the replacement won't break things.


Got exception of object has no attribute 'infer_read_length' when running with BAM file by minimap2 with nanopore fastq files

I'm using Nanopore to sequence long reads and then use minimap2 to align to human genome. I got the following exception when run NanoSV with BAM file generated.
Exception:
Wed May 16 17:08:46 2018 Busy with calculating the coverage distribution...
Wed May 16 17:32:04 2018 Busy with parsing bam file...
Traceback (most recent call last):
File "/home/kitsanyeung/.local/lib/python3.5/site-packages/nanosv/NanoSV.py", line 64, in
main()
File "/home/kitsanyeung/.local/lib/python3.5/site-packages/nanosv/NanoSV.py", line 52, in main
utils.parse_bam.parse_bam()
File "/nfs/home/kitsanyeung/.local/lib/python3.5/site-packages/nanosv/utils/parse_bam.py", line 46, in parse_bam
read = r.Read(line.query_name, line.infer_read_length())
AttributeError: 'pysam.libcalignedsegment.AlignedSegment' object has no attribute 'infer_read_length'
I checked the pysam document:
infer_read_length(self)
infer read length from CIGAR alignment.
This method deduces the read length from the CIGAR alignment including hard-clipped bases.
Returns None if CIGAR alignment is not present.
I checked the version of pysam used.
Python 3.5.1 (default, Feb 28 2017, 11:00:48)
[GCC 4.6.4] on linux
Type "help", "copyright", "credits" or "license" for more information.

import pysam
pysam.version
<module 'pysam.version' from '/software/python3.5.1/lib/python3.5/site-packages/pysam/version.py'>

Any ideas/suggestions?

I can't see the version number of pysam. Could you execute the following command to check the version of pysam:
pip freeze | grep pysam

You can also check the version with
import pysam pysam.__version__
Also see #24 .
Probably you have the same version problem.


Add formatting for MERGE statements

While testing my code with sql_formatter, I saw that the project lacks support for MERGE statements. Since many databases support MERGE, it would be great to get them formatted as well.
Currently, I am using sql_formatter to compare SQL statements stored in files with ones I am generating from metadata.

Hi @PabloRMira, sorry for my late response. But a few good examples can be found at:

Microsoft
Oracle
Postgres

Hi @AHulshoff , thanks for providing the examples!
Since I've never worked with MERGE statements and because of time contraints at the moment I have to admit that I will not be able to develop this feature in the short term.
But if you would like to develop it yourself feel free to contribute with a pull request. In that case please follow the instructions under Contributing to the code basis


Use unified methods to read primitives from Read

This removes a bit of the boilerplate around reading primitives from std::io::Read.
This trims about 90 lines from the source, making it a bit more accessible.
The lines in question are also fairly tricky to read and unrelated to surrounding code, so this helps too.
Alternative
An alternative would be not to define those methods as a trait extension for Read, but rather as free functions. Then you would simply call them.
This method is not inferior to the one I chose. But trait extensions are more rusty.

Put in draft mode, as it makes tests fail.


the inputs

Hi！According to the readme.md, I have downloaded and processed the dataset from https://github.com/abisee/cnn-dailymail. Then I got the folder “finished_files” which contains : test.bin , train.bin , val.bin , vocab and a folder “chunked”.
Can you tell me how to generate the inputs : train.source ,  train.target , val.source , val.target , test.source , test.target. Or can you provide these documents?
Thank’s for your help!

Follow the instructions here to download the original CNN and Daily Mail datasets. To preprocess the data, refer to the pointers in https://github.com/pytorch/fairseq/issues/1391 or check out the code here.

已收到


When the version is released, webhooks not triggers the new tag

When the version is released, webhooks not triggers the new tag

Gogs version (or commit ref):
Git version: 0.8.4
Operating system:  docker
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[x ] No
[ ] Not relevant

Log gist (usually found in log/gogs.log):

...

follow on this, I add log when new tags are pushd: (tail -f gogs.log output)
2018/03/10 15:29:36 [TRACE] Session ID: 39515931ae8881bc
2018/03/10 15:29:36 [TRACE] CSRF Token: MtdcmPAXLeVg4ZtClGcvMp4kkdc6MTUyMDY5NTc3Njk2MDY4NzAwMQ==
2018/03/10 15:29:36 [TRACE] TriggerTask 'Rakuten/refs/tags/v0.3.1' by 'danielecr'
2018/03/10 15:29:36 [TRACE] DeliverHooks [repo_id: 8]
2018/03/10 15:29:36 [TRACE] AddTestPullRequestTask [head_repo_id: 8, head_branch: refs/tags/v0.3.1]: finding pull requests
2018/03/10 15:29:36 [TRACE] AddTestPullRequestTask [base_repo_id: 8, base_branch: refs/tags/v0.3.1]: finding pull requests

when commit is pushed:
2018/03/10 15:35:00 [TRACE] Session ID: 9e5aeeb57775e4a1
2018/03/10 15:35:00 [TRACE] CSRF Token: Bm9Av_0UPlmlMoNluNzk4g69b6Y6MTUyMDY5NjEwMDQxODk5MjI2OA==
2018/03/10 15:35:00 [TRACE] TriggerTask 'Rakuten/master' by 'danielecr'
2018/03/10 15:35:00 [TRACE] AddTestPullRequestTask [head_repo_id: 8, head_branch: master]: finding pull requests
2018/03/10 15:35:00 [TRACE] DeliverHooks [repo_id: 8]
2018/03/10 15:35:00 [TRACE] AddTestPullRequestTask [base_repo_id: 8, base_branch: master]: finding pull requests
2018/03/10 15:35:00 [TRACE] Hook delivered: df45a5d8-ed6d-4512-bae8-bafc02bd3562


Remove args from clang-format in pre-commit

This PR closes #166.

CI indeed now fails due to clang-formatting issues https://github.com/N-Wouda/PyVRP/actions/runs/4330215575/jobs/7561301668.

The downside of this is that it doesn't show what needs to be changed in the CI. Is there a way we can get it to both format, but also show what it did in output? (not sure)

The downside of this is that it doesn't show what needs to be changed in the CI. Is there a way we can get it to both format, but also show what it did in output? (not sure)

I looked for this, but it seems that we can't have both. Either we have a dry run which shows the changes necessary, or we have the non-dry-run which will make the file changes in place. I prefer the latter, because it's easier for contributors to just run pre-commit to get the formatting right. Otherwise, they will need a separate clang-format installed with the right version to make the formatting changes.

I looked for this, but it seems that we can't have both. Either we have a dry run which shows the changes necessary, or we have the non-dry-run which will make the file changes in place. I prefer the latter, because it's easier for contributors to just run pre-commit to get the formatting right. Otherwise, they will need a separate clang-format installed with the right version to make the formatting changes.

What I don't like about this is that we then force new contributors to also set-up the pre-commit workflow locally. It's not a lot of work if you know what it is, but when you're very new to this stuff everything's hard. The problem also exists for black, which doesn't really say what's wrong either. I'd prefer tools that you could run locally, but if that's not done, then at least the CI should explain what's wrong.
Let's merge this in for now, but keep in mind that we should really improve the CI on this aspect.


Scrollbar click and/or drag causes close to fire

This is a tricky one because technically it could be the correct behaviour.
If the user clicks and drags a top level scrollbar in the browser chrome, it will fire the on close event. Here's an example of a floating navigation bar with content underneath it. You can see me dragging it, then opening the popup and trying to do the same thing. The popup will fire the handleClickOutside and close on mousedown on the scrollbar.
https://www.youtube.com/watch?v=rVA6F9hFgM4

Is this the built-in scrollbar?

Wow, that's pretty amazing. The document scrollbar is considered part of the <html> element, so that's a neat problem to deal with.

We can probably check, at the html element, whether the event's x coordinate is larger than document.documentElement.clientWidth. If so, despite being a click "on the html element", that will have been a click on the associated scrollbar, not the html element's content.

This seems to also yield the correct result for Firefox.

Checking the document dimensions is pretty much the conclusion I came to as well. Ugly though. And I'm not convinced the existing behaviour is actually incorrect, just unexpected.

Do you want me to try and put together a PR for this?

Even stranger, click and dragging on internal scrollbars, e.g. and overflow: scroll; DOES NOT trigger the close! Fun!

yeah the html level scrollbars, as far as I can tell, are very special this way, which is why document dimensions actually work (it's the only scrollbar for which this trick should work).
If you want to try your hand at a PR, that'd be fantastic! It might also need a test though, not sure a unit test will cover this particular one... we might need a manual in-browser test.

Sounds good. I'll wait until our PM's scream loudly enough here about it to allocate some time to fixing it :smile:

closing for now, but feel free to reopen or refile if this becomes a problem again.


Recommend DateTieredCompactionStrategy in README

@pyr I saw you recommended using DateTieredCompactionStrategy in your talk at Monitorama (btw, are the slides available online?). The README still mentions SizeTieredCompactionStrategy, so perhaps it should be changed.

Hi @ebpitts, this is now fixed in #80, thanks!


🐛 [cloud_functions] Unhandled Exception: [firebase_functions/unavailable] UNAVAILABLE

Bug report
Error when trying to call an HTTP cloud function.
This was working until a few days ago. It randomly stopped working.
Errors I get:
SSL handshake aborted: ssl=0xaf688b98: Failure in SSL library, usually a protocol error
error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER (third_party/openssl/boringssl/src/ssl/tls_record.cc:242 0xa86a9ce6:0x00000000)
Unhandled Exception: [firebase_functions/unavailable] UNAVAILABLE
Steps to reproduce

Create an HTTP cloud function
Call the function:

HttpsCallable` callable = FirebaseFunctions.instance.httpsCallable('testFunctionName');
return callable();

Hi @CollinEsmon
Could you please provide your flutter doctor -v and flutter pub deps -- --style=compact?
Thank you

Could you provide the full stack trace of the error?

This randomly started working again with no code change and I've been unable to reproduce since

It was probably an outage on the Firebase side of things. Going to close since it seems it's not this library which is causing issues.


Add support for X509 client certificate "authentication"

It's important for a number of enterprise and financial API / OAuth scenarios.
@blowdart already has 85% of it done - please include that in ASP.NET itself.

@blowdart - do you already have a sample of this somewhere? We're concerned this might be a big cost to bring up to production, including testing. We can discuss more when you're back.

Who is "we" in this case? Damian allowed approved it.
It's be a matter of moving https://github.com/blowdart/idunno.Authentication/tree/master/src/idunno.Authentication.Certificate and testing some more

Thanks for the link. When you're back let's discuss exactly what needs to be done in terms of test coverage.

@HaoK said he should be able to take a look at this since @Tratcher is deep in Kerberos land now ;). It's in preview 5 right now, but it can certainly be moved (fyi @ajcvickers @Eilon).
Also, we should support the X-ARR-ClientCert header that forwards the client certificate from the ARR front-end (i.e. in Azure App Service). I believe @blowdart 's component supports this, just adding it to the test matrix.

Note if we support X-ARR-ClientCert it should be in ForwardedHeaders, not directly in the cert auth handler.

@HaoK , I believe this is on your plate now?

Client certificates are a commonly used way to authenticate gRPC service clients. We'll be interested in using this middleware in our documentation and tutorials.

https://github.com/aspnet/AspNetCore/pull/9756


[add-resource] New Plugin/Theme

I would like to add my new plugin/theme to the Grav Repository.
Here are the project details: https://github.com/michielStaes/grav-theme-phantom
https://github.com/getgrav/grav/issues/1969

Wilkl get this added soon

Added!


Improvements

Check commits,
Untranslated strings:

Reset WingetUI icon and screenshot cache
Show Scoop packages in lowercase
Use system Chocolatey (Needs a restart)
Reset chocolatey cache
{action} was successfully!

Hi, untranslated strings still not added to tolgee, thanks
@marticliment

Done!


[Question/Enhancement] Why are the all the data stored in flags instead of an external data structure like .json

Won't this approach cause all the roll data to be presistently loaded together with the users causing an overall drop in performance the more data is stored? Especially that it bloats with evert session?
On the Foundry wiki the answer for storing data of that kind seems to be an external data storage like .json. I've seen few other modules do that. (eg. DF Chat Enhancements does exactly that to lighten the load of the session and creates a .json-based archive of chat history)
It would be nice if the archived data was loaded only when the statistics screen is being opened.

Oh, that's a clever way to store the roll info, I like it :D
I was worried that you'd register the results themselves in an ever-grownig array/archive. (Only had took a glance at the module so far.) So I was worried about the performance impact of having that loaded up in the cache at all times even if player is not looking at the stat analysis, because my players already start to complain about the performance of our session.
Now that you explained it I'm relived. Seems like the module is a lot more lightweight than I expected even if it's all kept in flags at all times :)
Thanks for the work and godspeed to you :D

Original design of the mod that I forked had an every growing list and wanted a way to avoid that. Especially when needing to do math on these giant arrays.
Glad you like it and may your averages be above average XD!
Also Take a look at the Usage->Icons section of the readme to update some of your players icons if you haven't yet!


Errors in temp.sp file.

When writing code with errors, errors are shown in another temp.sp file. In the main file, these errors do not show. How to make errors show only in the main file?

Related to #248.
Will be fixed in rhe next release 👍

Fixed in #250.


Disable codecov for out of source builds

@Dead2. I know you said this was configurable via codecov, but I put this PR here in case you change your mind. If not you can close it.

Have a look at this:
https://codecov.io/gh/zlib-ng/zlib-ng/tree/4a740b14893dfa92a1abfe6902b06ef4578e1914
It looks to me like the system include files are no longer included, and the out-of-tree files are no longer listed separately from the main files either, in addition to the previous fixes.

Nice! LGTM


Update README.md

A new inspection was created.

Looks like new PRs won't have those edits... 🤞 Let's see.

The inspection completed: No new issues


Will the MAXFPS limit be increased for PPSSPPSDL in the future?

I found that the MAXFPS limit was turned off at the beginning of 1.15, and this function can make many games flow smoothly in RK3326. It would be a pity to cancel this function.

It functioned no differently than frameskip on 1.14 and the feature doesn’t work at all on 1.15.  You can achieve the same result of maxfps with frameskip on 1.15.