Need GUI driven development environment for AL code development

VS code environment currently used for AL code development is not working very well for a large scale, real life development work.  It is lacking high level visual design feature.  Developers are spending more and more time working on the nitty-gritty of syntax error rather than concentrating on design work on objects such as Pages and Reports for example.  Even after getting speed with working with AL code, the VS code environment is quite considerably slowing them down working on AL code.  To address this can Microsoft come up with similar development environment like the current C/SIDE development environment.  This high level development environment needs to have an inbuilt and integrated source code repository stored in the database as current as well.  Such high level visual (WYSIWUG) development environment will significantly speedup and improve project delivery using AL code.  Having the source code stored in the database (such as in Object/Object metadata table) will help the customer to switch partners easily.  Something Microsoft is encouraging now a days.  To help this process it is essential the source code for any changes needs to be stored in the database rather than in an outside source (.al file) as currently done in VS code environment.

This seems to be a somewhat duplicate of https://github.com/Microsoft/AL/issues/1542 and https://github.com/Microsoft/AL/issues/1958 but is still true! To all questions "Where is my F5", the answer is "It's not there"...

My point is more than adding feature to intelligence. To have a new visual development environment for AL and to abandon VSCode. It is not a suitable development environment for NAV/Business central. Also please note my request to have a centralised and integratef code storage stored in NAV/Business Central database. So my request is quite different from the one highlighted in previous comment.

Thanks for the feedback. We are not going to abondon VS Code, but we are aware of the visual designer gaps and efficiency impact, and have plans to invest in this in the future.
As to source code availability, extensions can contain source code, allowing customers to download this from their tenant when/if switching partners. This requires ShowMyCode to be true.

How about source code management for on premises version of Business Central ?

Having used NetSuite extensively prior to working with Tenant Specific Extension on Business Central, I can tell you all have their drawbacks.   NetSuite with it's database driven configuration of fields, custom form variations and workflow designer are far ahead in terms of empowering power users to work with the solution.
Yet where Microsoft is heading is powerful and has potential.  Using Visual Studio Code gives them access to a lot of sophistication baked in. Even NetSuite and SAP B1 are both coding down the coding route for power developers and partners. You can see them trying to work from two ends with their personalisation and visual designer.
If they can keep their cadence up they might end up in 2 years being ahead. But you can see a massive engineering effort is required to drag the dinosaur onto the web (whilst trying to make it a beneficial transition from the windows client).
I can see 2019 is the year in which the substantial (user facing) transition is complete.  I'd imagine they had better in 2020 start adding significant functional differentials leveraging cloud - from global enterprise search, semantic understanding of relationships to improve navigation.
Personally I'm not a coder and my main criticisms isn't so much with the tooling, but with the lack of concrete examples, documentation and the fact that I need to look into forums and ask questions for even relatively simple patterns. That is where an interactive visual designer helps, but a much better modern pattern database and examples would also go a long way.

Having a WYSIWYG designer for objects such as Pages, Report, XML Port, Table with the ability to manipulate its property using the GUI interface will significantly (by 3 folds) changing/designing in AL language (using Visual Code editor) compared to CSIDE Development Environment.  Going from CSIDE Development to Visual Code editor environment without similar GUI interface is a huge step backwards and will affect the industry as a whole in big way.
With the industry (with NAV) for the last 22 years, I can tell, Microsoft need to recognise one of the secret behind NAV's success is the ease in which you can alter/customise things to fine adjust any solution to suite customer's requirement.  One critical in this is the property driven GUI driven development.  When you have finished with the design work on can export the changes as txt.  Now we almost have to interact and manipulate the txt representation of the change which is rather inefficient and prone for many syntax errors.  What we are proposing is to have the same the current development environment and have a feature as to save as .AL file.  That is what we really want.

There are a lot of drawbacks in their own way and you hit many limitations pretty quickly. I’d say Microsoft has the largest scale engineering team in terms of trying to get productivity from the environment.  The fact that they are using the same environment as customers and partners seems to be driving some fairly rapid innovation, but also huge demand for improvement – for example support for interfaces, intelligent dependency management.
My assessment remains the same. Essentially everyone prior to 2020 is an early adopter of Business Central. They won’t really have all the tooling in place to satisfy existing customers and a level of robustness until then. 2018 was a start. 2019 is to get across high priority items and I’d hope 2020 is to consolidate and start to deliver solid and tangible benefits from the new environment.
If you want what you’ve got with no downside and only upside then wait. If you want to get onboard early, so you are an expert by the time it get’s finished then start learning.
From: Rama-M<EMAIL_ADDRESS>Sent: Tuesday, 26 February 2019 6:05 AM
To: Microsoft/AL<EMAIL_ADDRESS>Cc: Russell Kallman<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/AL] Need GUI driven development environment for AL code development (#4592)
Having a WYSIWYG designer for objects such as Pages, Report, XML Port, Table with the ability to manipulate its property using the GUI interface will significantly (by 3 folds) changing/designing in AL language (using Visual Code editor) compared to CSIDE Development Environment. Going from CSIDE Development to Visual Code editor environment without similar GUI interface is a huge step backwards and will affect the industry as a whole in big way.
With the industry (with NAV) for the last 22 years, I can tell, Microsoft need to recognise one of the secret behind NAV's success is the ease in which you can alter/customise things to fine adjust any solution to suite customer's requirement. One critical in this is the property driven GUI driven development. When you have finished with the design work on can export the changes as txt. Now we almost have to interact and manipulate the txt representation of the change which is rather inefficient and prone for many syntax errors. What we are proposing is to have the same the current development environment and have a feature as to save as .AL file. That is what we really want.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/AL/issues/4592#issuecomment-467138577, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AooDXvc_cBRL0GCSyRQqN9J6NwhM5sYWks5vRDPjgaJpZM4a0M7l.

No true developer would prefer a visual designer over a clean light-weight editor like VScode. There's a reason why VScode is one of the most popular editors out there. Saying file based coding doesn't work and that code belongs is the application database is a laughable remark.

@erikrijn your statement reads to me as following (because there are reasons for all sorts of things). "No true driver would ever sit on a bicycle or in electric vehicle". I agree with your last sentence though and everybody should embrace file based programming.

@yrest would you take a web dev serious if he/she uses a visual designer?

@erikrijn I would take seriously anyone who's professional and proficient in the tools they use and prefer. It's not only about development, part of work we all do with this product is design - of pages, reports, etc.

We all should appreciate each other’s views, not to take this too personal.  I have done programming since high school, university and something I do for living at the moment.  During these 35 years I have done coding in a range of programming language such as Assembly Language to C++ to C# to Visual Basic to C/SIDE to TSQL.... My comments about the lacking visual designer for AL was actually came after losing some of my hair trying to convert our vertical to be an extension using AL code.
I like to bring to the attention of @erikrijn that in NAV C/SIDE there are very high level objects (such as Table,Query,Page,Menu,Report,XML Port).  You can achieve a lot simply manipulating the properties and the code element is only there as a "glue logic" and for many instance it is a very minority part when it comes to any customisation.  This is true for 90% of the practical work we do in a day by day basis (ie we do not touch / modify the code in many instance).  In fact you spend 60% of your time planning / Considering/Impact access your change and you only spend 30% actually coding.  Further many of the NAV consultants up there are not developers and they do changes like changes to Pages, XML Port, Adding table field (without validation code) and they do not anywhere near writing code.  Any such coding work is left for developers such an myself.  Any seasoned NAV developer would back the above practice.
Now in AL code even to add a field to an existing page would require a fair amount of coding knowledge.  It would be almost impossible to train all these people to be a hardcore developers only to add a field to a page.  Which is currently achieved by simply achieved by dragging and dropping the field.  Currently coding in AL language reminds me writing something like 100 line of code to add two line of code to add two decimal numbers in assembly language.  End of the day everything runs in computer in binary and one could argue it is the most light wait most efficient coding language.  I also have to agree with @erikrijn view on this.  But why we are not using it ? the answer is to boost productivity and hence other high level languages are invented to boost productivity.
To summarise C/SIDE is a high-level language compared to AL in current form (without a similar visual designer).  Going from a high level language (C/SIDE) to AL is like going from C# to Assembly language where you manipulate the register address and it's value in hex !!.
In my opinion we all are sleep walking towards a major disaster to the NAV industry (to make the implementation and customisation much much expensive and hard to make change, etc...) By replacing C/SIDE by AL without a visual designer, which is only a good fit to only replace the Codeunit Object but not the rest of the objects such as (Table,Query,Report,XML Port, Page, Menu).
This is the over whelming opinion of the NAV community and the industry and having a visual designer will go a long way to mitigate this issue.  Microsoft need to appreciate this fact.

Rama-M has some very good perspectives. Again, coming from outside the legacy dinosaur ecosystem, I can take a step back.
Business Central in its current form (along with all the design tooling) is not ready to be out there. It just isn’t.  I congratulate Microsoft are being very ‘lean’ thinking in getting a product to market and iterating. Anyone adopting it is by definition an early adopter. You need to put up with all sorts of constraints and limitations.  The fact is, I doubt they can credibly go head-to-head with other solutions until 2019 October Release.
My bigger issue is them not resolving underlying usability issues in terms of task flow and simplicity.  I see at the moment a company obsessed with reinventing a technology solution on the web, but in the process not solving fundamental business process problems.  Where are the intelligent menus that understand your context and workflow state, where is the global search for information that helps you resolve business queries fast?
Microsoft really has until 2020 to be actually breaking new ground and innovating with Business Central – not simply slightly improving on features that had already existed in a Windows client. Otherwise Acumatica, Sage, NetSuite and yes (even tired old SAP B1) will catch up or exceed them with their web interfaces. In 2019, even little old open source Odoo is far more advanced and fully featured with their Studio offering.
That said, for the price – it is rather impressive. Even a relatively modest person like myself has been able to extend and add fields and achieve complex functionality that was extremely difficult and cumbersome in NetSuite. The ideas place seems fairly responsive and there are promising extensions appearing in AppSource.
I don’t think Microsoft is sleep walking – but I think they are going way too slow given the competition.
From: Rama-M<EMAIL_ADDRESS>Sent: Saturday, 9 March 2019 6:02 AM
To: Microsoft/AL<EMAIL_ADDRESS>Cc: Russell Kallman<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/AL] Need GUI driven development environment for AL code development (#4592)
We all should appreciate each other’s views, not to take this too personal. I have done programming since high school, university and something I do for living at the moment. During these 35 years I have done coding in a range of programming language such as Assembly Language to C++ to C# to Visual Basic to C/SIDE to TSQL.... My comments about the lacking visual designer for AL was actually came after losing some of my hair trying to convert our vertical to be an extension using AL code.
I like to bring to the attention of @erikrijnhttps://github.com/erikrijn that in NAV C/SIDE there are very high level objects (such as Table,Query,Page,Menu,Report,XML Port). You can achieve a lot simply manipulating the properties and the code element is only there as a "glue logic" and for many instance it is a very minority part when it comes to any customisation. This is true for 90% of the practical work we do in a day by day basis (ie we do not touch / modify the code in many instance). In fact you spend 60% of your time planning / Considering/Impact access your change and you only spend 30% actually coding. Further many of the NAV consultants up there are not developers and they do changes like changes to Pages, XML Port, Adding table field (without validation code) and they do not anywhere near writing code. Any such coding work is left for developers such an myself. Any seasoned NAV developer would back the above practice.
Now in AL code even to add a field to an existing page would require a fair amount of coding knowledge. It would be almost impossible to train all these people to be a hardcore developers only to add a field to a page. Which is currently achieved by simply achieved by dragging and dropping the field. Currently coding in AL language reminds me writing something like 100 line of code to add two line of code to add two decimal numbers in assembly language. End of the day everything runs in computer in binary and one could argue it is the most light wait most efficient coding language. I also have to agree with @erikrijnhttps://github.com/erikrijn view on this. But why we are not using it ? the answer is to boost productivity and hence other high level languages are invented to boost productivity.
To summarise C/SIDE is a high-level language compared to AL in current form (without a similar visual designer). Going from a high level language (C/SIDE) to AL is like going from C# to Assembly language where you manipulate the register address and it's value in hex !!.
In my opinion we all are sleep walking towards a major disaster to the NAV industry (to make the implementation and customisation much much expensive and hard to make change, etc...) By replacing C/SIDE by AL without a visual designer, which is only a good fit to only replace the Codeunit Object but not the rest of the objects such as (Table,Query,Report,XML Port, Page, Menu).
This is the over whelming opinion of the NAV community and the industry and having a visual designer will go a long way to mitigate this issue. Microsoft need to appreciate this fact.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/AL/issues/4592#issuecomment-471038997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AooDXgk0CvDSLvrOOKybQfN0eWs4xXg2ks5vUrOtgaJpZM4a0M7l.

Hi, Please go ahead and post this to our Ideas forum at https://aka.ms/BusinessCentralideas, or vote up the idea if its already there. We're constantly monitoring top Ideas and will consider them for a future release.
If you wish to continue the discussion, please do so on Yammer.


Communication: Support File Sharing

Problem Description
This PR introduces a new feature that allows users to upload files directly to a conversation.
Changes

File Upload UI:
Added buttons for file in message area
Validation:
Enforced a 5MB file size limit.
Restricted uploads to supported file types.
Steps for testing
Test the new buttons added to the messsage field for file upload.
Upload a file or image and verify:
Files/images are displayed with appropriate markdown.
Screenshots

Maybe something in general that we could think about for a follow up: Do we want to combine uploading images and files into a single button with a menu (like the + on the left)? I think that's how we do it on the web app, and most other apps do something similar

Maybe something in general that we could think about for a follow up: Do we want to combine uploading images and files into a single button with a menu (like the + on the left)? I think that's how we do it on the web app, and most other apps do something similar

I think we can discuss this and depending on the outcome also we create one more ticket for Android as well


[Bug] Logging in after connecting telnyx causes LateInitialization error

Bug Category

[x] Credential Login
[ ] Token Login
[ ] Local Audio Issue
[ ] Remote Audio Issue
[ ] Audio Device Switching
[ ] Mute / Unmute
[ ] Hold / Unhold
[ ] Performance issues
[ ] Other

SDK Version
telnyx_webrtc: latest
Describe the bug
No, it does not occur in the example app because the example does not log in right after you connect the client. I had this issue for a long time and the workaround I did to fix it was using a delay of 4 seconds to log in after you connect the client because the connect() method is not asynchronous, but in release the delay is not really working and users are not able to automatically login into the client.

Expected behaviour
A clear and concise description of what you expected to happen.
Logs
Please provide any logs available to you, remember to enable verbose logging within the SDK.

logs: https://katb.in/imumumesagi

LateInitializationError: Field '_socket@254383924' has not been initialized.
same error

Same Issue... still no solution

Did you try connecting after a delay?

yes tried.. multiple time also tried web demo
https://webrtc.telnyx.com/
getting error   "sipReason": "Connection has no Outbound Profile assigned D38",

solved It
this error comes when you try to connect client and login simultaneously. just connect client first and after some delay try to login. there will be no error
Cheeers

solved It
this error comes when you try to connect client and login simultaneously. just connect client first and after some delay try to login. there will be no error
Cheeers

Its not really a solution, its a workaround

you can not login until client is not connected & client it will take some time to connect.
so you have to wait for client connection

you can not login until client is not connected & client it will take some time to connect. so you have to wait for client connection

Yes i know that, ive been doing that ever since i opened this issue, but you might still run into connection issues, if you have  a poor network or slow device.

yes, it will be an error in that case. because there is no way to detect whether a connection is established on not.

Make the connect function Asynchronous so we can wait for it and then call the login function.


Feature: generify dynamic JPA query templates by creating a main abstraction

In order to keep this implementation more flexible, this is an implementation to enable multiple template providers.
There's is also minor fix for postgres type casting in queries and a rollback from using commons into the same project.

Sound good. However the commons package should be moved to spring-dynamic-commons

Great, thank you! I just felt like the whole commons was an "over" thing after I have resignified a few things and the commons ended up with 3-4 files, ended up looking like it had no purpose.
This module plus an external module for each template implementation looks like a decent approach, what do you think?
com.github.joutvhu:spring-dynamic-jpa
com.github.joutvhu:spring-dynamic-jpa-freemarker
com.github.joutvhu:spring-dynamic-jpa-handlebars
Anyway, just a thought or two, don't mean to intrude.
Thanks :D

spring-dynamic-commons is decoupled for general use for spring-dynamic-r2dbc and spring-dynamic-jpa.
The implementations should be separated as follows:

spring-dynamic-commons
spring-dynamic-jpa
spring-dynamic-r2dbc
spring-dynamic-freemarker
spring-dynamic-handlebars

To use, the user will combine them, for example:

spring-dynamic-commons
spring-dynamic-jpa
spring-dynamic-freemarker

Or:

spring-dynamic-commons
spring-dynamic-r2dbc
spring-dynamic-handlebars

...

Hey there! Sounds good, I will tackle this ASAP when I have some extra time this week.
Should be pretty straightforward.

Sorry for the delay, I've pushed some changes you asked me to commons and this project.
Please let me know what you think.


Completing open source implementation

[x] MUST have a OSI-approved license distributed with public source code repositories by end of Q2.
[x] Create contributing guidelines for all Open Source repositories. Explain how someone makes a contribution to the projects. Add to documentation website created in previous quarter.
[x] Create public tickets/issues that correspond to planned features and known bugs/problems with Open Source repositories.
[ ] Establish an Open Source quality assurance process.
[ ] Explore unit testing frameworks for front-end/back-end software, if applicable. Document user stories and test cases for games, if applicable. Document data structures and algorithm decisions for data science, if applicable.
Add either developer or user documentation to the Open Source documentation site. (Hint: Developer docs often include API docs, architecture or system state diagrams, or deployment guides.)
[ ] Identify a Code of Conduct for any public Open Source repositories. Upload it to public source code repositories. Create internal documentation for how to respond to a Code of Conduct report, if one were to be made.

[x] OSI Approved License Distribution: https://github.com/AQ-AI/openaq-engine/blob/master/license
[x] Create contributing guidelines for all Open Source repositories:  https://github.com/AQ-AI/openaq-engine/blob/master/.github/CONTRIBUTING.md
[x] Create public tickets/issues: https://github.com/AQ-AI/openaq-engine/issues
[x] Code of Conduct for Public Open Source Repositories: openaq-engine: https://github.com/AQ-AI/openaq-engine/blob/master/.github/CODE_OF_CONDUCT.md


Update native-aot.md

Internal previews

📄 File
🔗 Preview link

aspnetcore/fundamentals/native-aot.md
ASP.NET Core support for native AOT

@tdykstra  closing this as you moved it to a better place.


Add guide on how to train your own models

I need help on writing a guide on how to train your own models.
If you know how to do that please reply.

Put your model folder to waifu2x-converter-cpp location
Add "--model_dir " parameter (for example your folder is "models" then your parameter is "--model_dir models"

Put your model folder to waifu2x-converter-cpp location
Add "--model_dir " parameter (for example your folder is "models" then your parameter is "--model_dir models"

parameter list can be found by adding "-h" parameter after waifu2x-converter-cpp.exe

parameter list can be found by adding "-h" parameter after waifu2x-converter-cpp.exe

I meant training your own models, not using them. I updated the post now, didn't phrase that correctly.

You can't training on waifu2x-converter-cpp even you have NVIDIA GPU cuz it doesn't support training models, only convert image.

I noticed that there is model training in https://github.com/DeadSix27/waifu2x-converter-cpp/tree/master/appendix/ but I have no idea how to use it :(

Currently, training is only supported on my implementation. I think it's hard to implement it from scratch.
https://github.com/nagadomi/waifu2x#train-your-own-model
In addition, my implementation has already switched to new architecture called upconv_7. waifu2x-converter-cpp supports only old vgg_7 architecture. If you want to train the model for waifu2x-converter-cpp, you need to specify the -model vgg_7 option on train.lua.
You can export your trained model with:
th tools/export_model.lua -i <path to your model> -o my_mode.json

This JSON file will work with waifu2x-converter-cpp.

@nagadomi on that note, will you keep support/scripts for the old model?

@DeadSix27 Hey there, I am able to help you with the model training. I have got gtx 1080 ti so it should be fast. If you want me to train new or existing model for this converter, contact me somehow =]

Since upconv_7 model uses vgg_7 model too, training vgg_7 is not duplicates to upconv support. (If we supports training vgg_7, it can be use to upconv_7 too)


DAX Formatter calls don't specify app/version

I've seen that the code in DaxFormatter.cs don't have the property CallerApp and CallerVersion assigned - however, the code to do that is commented. It would be nice to be able to get statistics from calls made using Tabular Editor, but the current calls don't allow to get detailed info.
Is there a reason for which you commented out the code? Is there something I can do to help?
Thanks!

Hi Marco,
I was receiving error 500 with the API call, when including the CallerApp and CallerVersion. However, I just tried again this morning, and now everything seems to work (perhaps I was calling an older version of the API earlier?). Anyway, I've uncommented the code and released a new version (2.0.6176) where this is fixed.
Could you please try and let me know if you correctly receive the statistics with this release?
Thank you.

I confirm it works well!
When I have time, I will publish a public dashboard with the statistics from DAX Formatter (in Power BI of course!).
Thanks!
Marco


Remove the !Sub checks in the Allowed Pattern rule

Issue https://github.com/aws-cloudformation/cfn-python-lint/issues/725, if available:
A !Sub can also be used as a !Ref, in which the string that is checked is empty. The PR handles this scenario (added the test scenario from the issue)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

closing in favor of #731


Update Eslint Parser

Our current parser for eslint is outdated: The State of Babel Eslint
The deprecation of babel eslint has caused multiple errors when it comes to running the command itself. As such, this PR updates our eslint parser from babel-eslint to babel/eslint-parser.
Be aware that the script ran when running npm run lint is also updated (Check package.json).
Resolves #985

Shoutout to my sister Anna homies


Avalonia display exception in Linux

myPlot.XAxis.Label.Text = "Horizontal Axis";
myPlot.YAxis.Label.Text = "Vertical Axis";
myPlot.TitlePanel.Label.Text = "Plot Title";

The above code is invalid in ScottPlot.Avalonia.(Linux)

Hi @zichen-ye, unfortunately I think this issue is incomplete.
What is the exception message?
Can you provide the full code for your avalonia source code file? https://scottplot.net/faq/repro/
I'm happy to re-open this issue if there is a little more information about what the problem is 👍


Improved testing of python driver

Changes

Added test on test1 multicolumn returns
Deleted unnecessary print
Added more test on single column returns

Outdated


batch//jobs endpoint does not exist

BatchHandler.get_jobs --> does not exist, despite what the router says.
Looks like this turned into a flag on BatchHandler.get.

Referenced the PR # in the PR by mistake, closing manually. Thanks for merging @kofalt!


Default values for retry proxies

There was a reason that the dbExtractor used it's own retryProxy wrapper.  Because it got to set defaults for all extractors, such as
https://github.com/keboola/db-extractor-common/blob/9.3.2/src/Keboola/DbExtractor/RetryProxy.php#L21
I think it could be enough to set default values in common for these things, or make a simple retry wrapper here in db-common that uses these overridable defaults.

or if you like to follow the current pattern, then a class keboola\dbExtractorRetry that extends keboola\retry could also work.

@ondrajodas If you like I can create a quick PR to describe what I mean


Fix handling of FlagIndex in LowLevelILFunction.expr

Several functions, including LowLevelILFunction.set_reg, default to architecture.FlagIndex(0) if no flags are explicitly provided. However, LowLevelILFunction.expr did not recognize FlagIndex as a valid type for flag arguments, and would thus throw an assertion error

Actually needs to use isinstance int. See: https://github.com/Vector35/binaryninja-api/pull/2617 I have a local fix for this that will be pushed shortly. Thank you for the PR


fix password variable shadowing

My bad. While the password is randomly generated, it doesn't actually get stored in
the original password variable as it is declared in a new scope with :=.
So an empty string will always be the password anytime -random-password-length is used

Codecov Report

Merging #5405 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   37.45%   37.45%   -0.01%
==========================================
  Files         312      312
  Lines       46510    46510
==========================================
- Hits        17422    17420       -2
- Misses      26597    26599       +2
  Partials     2491     2491

Impacted Files
Coverage Δ

models/repo_list.go
63.29% <0%> (-1.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e022a9...31096c9. Read the comment docs.


added graffle compatible shim

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 22 (81.82%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 89.231%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

event_fetcher.go
18
22
81.82%

Files with Coverage Reduction
New Missed Lines
%

event_fetcher.go
8
81.54%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
2958

Relevant Lines:
3315

💛  - Coveralls


Create Utility to Generate Javadoc Codesnippet Stubs

Our Javadocs use codesnippets which copy a range of code from /samples between a named comment block. Preparing the named blocks is a manual task and the name is based on the API name and the parameters, given the strictness of the name we could create a utility tool which accepts .java files and generates a .java with all snippets blocks generated.
For example, given the Java client class
public Response<Void> deleteX(String name) {
    // API code
}

public Response<X> getX(String name) {

}

These would be the snippet block names we'd create
// BEGIN: deleteX#String
// Javadoc snippet code
// END: deleteX#String

// BEGIN: getX#String
// Javadoc snippet code
// END: getX#String

Triaging old issues... @alzimmermsft, you may have already addressed this with some of your recent investments.


Set access_scope

Is it possible to set the access scope within stravalib?
For example, I am doing:
client = Client(access_token='MYACCESSTOKEN')
activities = client.get_activities()
I want this to also find private activities, so I think I need to set the scope to 'view_private', but I don't know how/where.

Yeah, you can do this; you need to specify the scope in the authorization URL.  Here's a (Flask) snippet:
@blueprint.route("/authorize")
def join():
    c = Client()
    public_url = c.authorization_url(client_id=app.config['STRAVA_CLIENT_ID'],
                                     redirect_uri=url_for('.authorization', _external=True),
                                     approval_prompt='auto')
    private_url = c.authorization_url(client_id=app.config['STRAVA_CLIENT_ID'],
                                      redirect_uri=url_for('.authorization', _external=True),
                                      approval_prompt='auto',
                                      scope='view_private')    # <--  Here's the important bit!
    return render_template('authorize.html', public_authorize_url=public_url, private_authorize_url=private_url)

And just for completeness, here is a simplified version of my callback URL handler (aka "view"):
@blueprint.route("/authorization")
def authorization():
    """
    Method called by Strava (redirect) that includes parameters.
    - state
    - code
    - error
    """
    error = request.args.get('error')
    state = request.args.get('state')
    if error:
        return render_template('authorization_error.html', error=error)
    else:
        code = request.args.get('code')
        client = Client()
        access_token = client.exchange_code_for_token(client_id=app.config['STRAVA_CLIENT_ID'],
                                                      client_secret=app.config['STRAVA_CLIENT_SECRET'],
                                                      code=code)
        # Now store token

Thanks for the reply, I've been away for a while.
I'm not using Flask (or any framework), I'm just using Stravalib in a python shell script. I'm not doing any of the "authorization_url" stuff you mentioned. Any chance I could see the authorize.html template so I can try to put these pieces together? I need to see how you are getting the code that you are exchanging for access_token.

Hope I can help -- the authorize.html that I was probably referencing would be this one: https://github.com/hozn/freezingsaddles/blob/master/bafs/templates/authorize.html  -- but the important point is that the user, logged-in to Strava in web browser, has to navigate to a URL that will ask them whether they would like to give the application ability to read data (maybe including private).
If you are just doing this yourself, you can construct your own URL to paste into the web browser using something like:
private_url = c.authorization_url(client_id=app.config['STRAVA_CLIENT_ID'],
                                      redirect_uri='http://localhost:8000/',
                                      approval_prompt='auto',
                                      scope='view_private')    # <--  Here's the important bit!

The redirect_uri is going to need to be set to a server you have running (e.g. on localhost) that will take the code and exchange it for a token (that is my {{/authorization}} example above).  Hope that is clear.
More here: https://strava.github.io/api/v3/oauth/

That helps, I should be able to get it going. Thanks!


Abandon threads and go to processes

Even with the thread refactor they are not reliable on all platforms.  It's time to move to processes.  Performance testing has also show that they are not very efficient.
Before starting:

Run four processes from the command line in parallel and make sure this is actually faster and make sure this is faster than running four threads.  RESULTS: Processes are not measurably faster than threads, but it's still a good idea to replace them for portability reasons.  Threads are not well supported and in fact are officially deprecated.

There will be a few steps to this effort:

Separate protocol from remote

Tried running four separate processes and was only somewhat successful with queuing and signalling this small difference would likely melt away.  Probably limitations of my laptop and/or Perl.  Will need to test on bigger hardware to be sure.
1 thread 32.5s
4 threads 15.4s
4 processes 12s

Just chiming in here.  The use of Perl ithreads is also a significant barrier to entry on Gentoo.  The perl package on Gentoo is built without ithreads by default -- the packagers seem to take the view that the compatibility risks of ithreads generally outweigh its usefulness.
I don't personally have an opinion about ithreads, but it does mean that if you want to install pgbackrest on Gentoo, you must first rebuild perl with non-default options, and then rebuild everything that is linked against perl.  It's not ideal.
All of this being a rather long-winded way of saying "+1 to ditching ithreads and going to processes".

It may not look like it from the comments but I've already decided to go this way.  Even though I have threads working OK on the platforms that support them there are issues other than portability.  It happens that I have a decent protocol layer for communicating with the remotes so no reason that can't be applied locally.  Except for time, of course.  Was hoping to have it done before the Ottawa conference but now that's looking unlikely.  It's a top priority, though.

Cool, thanks for the reply @dwsteele.  I am very interested in seeing a subprocess-based pgbackrest, so if there is any way that I can assist, let me know.

I appreciate that - the biggest help would be to test out the code once I have something working.  I plan to start on that in the next week once I'm done with the current info functions so I'll let you know.

Moved to xml backlog.

If you would like some testing on high core count hardware, I can do that.

If you would be willing to test dev versions that would be awesome.  I'll let you know when I have something.

I'd be happy to test dev versions.

@direvus Perl threads were replaced with child processes in 1.07, if you are still interested.

That's great, thanks @dwsteele.  I look forward to taking it for a spin.


[DOCS] Change Default Branch To Show Updated README

Description

Actually, I was switching to the dev branch, but it was not happening. Otherwise, I have followed the installation guide.

u have missed the very first step
of uncheck that box

I looked over some prs and in pr #508 . You commented that the programmer didn't follow the README.
The problem is when someone new comes to this project they will see the README file which was merged into main branch because the main branch is the default one.
Two options:

Every time that there is a change in Docs , we have to merge it also in the main branch right away
Make the dev branch the default one so newcomers will see the updated docs

Screenshots
https://github.com/thecyberworld/TheCyberHUB/assets/76536506/8c75c38b-d214-43ed-9740-52f8474a8c4e
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

nice, didn't think of that way
thanks for this 👍


Feature: Add calculate-finances command

Add functionality to generate an invoice to be forwarded to the tutee's guardian

Closing due to constraints


fix: Modal Widget Context switching

Description

Fix issue where modal widget did not reliably open when the url has the modal widget id
Fix issue where modal widget did not open when url has the modal widget's child id

PR fixes following issue(s)
Fixes #20439
Fixes #27204
Media
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing
How Has This Been Tested?

[x] Manual
[ ] JUnit
[ ] Jest
[x] Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview skip-tests=true

Tested in this PR:

Accessing Modal widget & its children using URL having the widgets/<modal widget id> suffix.

https://github.com/appsmithorg/appsmith/assets/39921438/9e7bc0a0-be50-48eb-9d30-597501558a16

Accessing the Modal widget & its children by passing the respective URLs inside an onClick function of a different widget in another page
https://www.loom.com/share/698dfa0f8ba146f4861a19644dc3f407

Looks good.


'Already purchased' error for consumable purchases

When a consumable purchase is purchased through the RMStore library, the user intermittently and completely at random, seems to get a modal error on screen saying You have already bought this product.  We'll restore your purchase, but no restore happens. No success or error callbacks are executed by the library so I am unable to handle the error. This is the first time that the user has purchased the product.

I have the same problem as you.

@jw10126121 my 'solution' was to write my own lightweight abstraction layer using StoreKit, getting rid of RMStore.

Please tell me how you do it.


Upgrade to Go 1.22

Fixes #12010

At some point we'll probably want to pull in html/template changes...

html/template
Javascript template literals may now contain Go template actions, and parsing a template containing one will no longer return ErrJSTemplate. Similarly the GODEBUG setting jstmpllitinterp no longer has any effect.

And remove the related stuff from the security config.

@jmooring haven't we already?

@bep I forgot we (you) had already done this in https://github.com/gohugoio/hugo/pull/11771.


Bump wrangler to 2.1.13.

Codecov Report

Merging #97 (af2395e) into main (aad29da) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   94.37%   94.76%   +0.38%
==========================================
  Files          20       20
  Lines        1848     2023     +175
  Branches      198      187      -11
==========================================
+ Hits         1744     1917     +173
- Misses        104      106       +2

Flag
Coverage Δ

unittests
94.76% <ø> (+0.38%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


When tool use is aborted and a new tool selected, un-highlight feature

If the users makes a selection with the update tool and then with out using the abort button on the form selects the move tool the feature selected of update stays highlighted.

Resolved.
Colours also changed. All were red, this created confusion between review and editing items.
Review (table selection) is now red, all map selections for editing = green - @Deb-Jones this may be of interest to you


infinite github.com in know_hosts

https://github.com/webfactory/ssh-agent/blob/ea17a056b908d85ca1f46c275ab91389eb65c9fa/index.js#L30
from line 30 to 32 will keep adding the same key to know_hosts over and over by job running. could you add an option to add this to know_hosts or precheck know_hosts has the existing host alreaday? Or run a ssh-keyscan instead by child_process? Thank you!

This is a duplicate of #106, happy to take patches!


[Feature request] Add dynamic icon and text support for go back and plus icon in NavigationCollapse

I cannot change the Go back and the plus icon svg in Navigation collapse section. I have checked the NavigationCollapse component and found that those are hardcoded. It would be more flexible and user-friendly if these elements could be customized using props, allowing for dynamic values to be passed in.
See image for reference:

@MuhammedNihad Thanks for your feedback. It is already fixed in our keep next version which will be release very soon.

Can I expect the release this week?


Add DNE 33 - Remoto da depressão to podcasts list

Hi guys,
I'm adding more one cast about remote work.

Thanks o/ 🍻


Suggestion: Candle lily pads do not melt ice

Akin to jack-o-lanterns/pumpkins, candle lily pads should be able to be placed without melting ice. Currently, they melt ice.
Lily pads on ice, whats not to love?

....jack-o-lanterns do melt ice (or at least, I can't find any mention of this on the wiki, or anything about this in the code).
This would make candle lilypads unique of all light sources- and it's also not clear how this would work.


Refactor returned/thrown error values

Purpose

Avoid error reason being sent to client
Refactor thrown error values
Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18692 into master will increase coverage by 5.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18692      +/-   ##
==========================================
+ Coverage   15.04%   20.52%   +5.47%
==========================================
  Files          48       52       +4
  Lines        1263     1345      +82
  Branches      199      205       +6
==========================================
+ Hits          190      276      +86
+ Misses       1059     1055       -4
  Partials       14       14

Impacted Files
Coverage Δ

...s/vscode/src/project-tree-view/project-overview.ts
0% <0%> (ø)
:arrow_up:

...ool-plugins/vscode/src/debugger/config-provider.ts
0% <0%> (ø)
:arrow_up:

...ugins/vscode/src/project-tree-view/project-tree.ts

composer/packages/tracing/src/ToolBar.tsx
71.05% <0%> (ø)

composer/packages/tracing/src/TraceList.tsx
94.44% <0%> (ø)

composer/packages/tracing/src/DetailView.tsx
79.31% <0%> (ø)

composer/packages/tracing/src/TraceLogs.tsx
70.37% <0%> (ø)

composer/packages/tracing/src/index.ts
0% <0%> (ø)

tool-plugins/vscode/src/trace-logs/traces.ts
21.05% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df244bf...a40b531. Read the comment docs.


Make hologram works on Windows

Hologram do not work on windows. I'm using the Power Shell. Ruby was installed with http://rubyinstaller.org and https://github.com/oneclick/rubyinstaller/wiki/Development-Kit
I do have a hologram config files and it perfectly works on OSX.
PS C:\myProject> hologram
C:/Ruby200/lib/ruby/gems/2.0.0/gems/posix-spawn-0.3.8/lib/posix/
'which' is not recognized as an internal or external command,
operable program or batch file.
(?°?°)?? ???  Build not complete.
 Could not load config file, try 'hologram init' to get started

I've got this working for Mac, but another user using the same repo setup on Windows is still having trouble, even with 1.2.0.
Getting the same build failed errors as above, and notice about doing hologram init. Also, the documentation_assets, referencing cortana, are not being copied into the styleguide directory, so although it's partly working despite the warnings, the style guide doesn't look like it should.
documentation_assets: assets/bower/cortana doesn't seem to work for Windows (fine on Mac) - case matches the path in the repo.
custom_markdown: assets/bower/cortana/CortanaMarkdownRenderer.rb is copied fine.
Maybe documentation_assets are not having the slashes reversed or something daft to satisfy Windows?

We just released version 1.3.0 to rubygems.org, could you test with the new version and report back? I know there were a few updates that should make Windows users much happier.

Windows user reporting in. 1.3.0 seems to have helped a lot. The new output looks like:

I do not know what the warning means but hopefully it's helpful to you.

The warning is from hologram parsing your source code, you have two documentation blocks with the same name ('d-small'). That said if your output is what you're looking for it, it's not a big worry.
Thanks for the update though, I'm glad to hear it's working better.

Just confirming (Robin and I are working on the same project), and yes, there are indeed two documentation blocks with the name d-small; useful warning!


Creating meta-reducer with DI

Question
Is it possible to create a meta-reducer and inject dependencies?
I have seen this question posted elsewhere, but w/o a response. I know that it is possible using ng2-redux

The store has a replaceReducer method which could be used:
import { reducers } from './somewhere';
import { ActionReducer, combineReducers, Store, Action } from '@ngrx/store'

@Injectable()
class InjectedMetaReducer {

    private reducer: ActionReducer;

    constructor(private store: Store<any>) {
        this.reducer = combineReducers(reducers);
        this.store.replaceReducer((state, action) => this.metaReducer(state, action));
    }

    metaReducer(state: any, action: Action) {
        return this.reducer(state, action);
    }
}

That won't run until it's injected somewhere.  Probably in your AppComponent.

Awesome, that was actually exactly what I needed @adharris


Blog issues

Expected behavior and actual behavior
@tdreyno Thomas is the blog extension being updated at this juncture - had some issue in there for some time. Some important ones I think also:
https://github.com/middleman/middleman-blog/issues/320
Steps to reproduce the problem (from a clean middleman installation)
Additional information

Ruby version:
Middleman version:
OS version:

Fixed with blog: [name] in frontmatter - but not as dynamic a fix as I wanted


Add a generate method to LazyReact

LazyReact builder = new LazyReact(100,100);

Currently to process a generative data supply we have to similate generate with limit with range functionality. E.g.
builder.range(0,max)
           .map(i->dataPool.next())
           .forEach(data -> work(data);

Generate with a limit would be more intuitive
builder.generate(()->dataPool.next())
           .limit(max)
           .forEach(data -> work(data);

LazyReact.reactInfinetely does this already


Spiffs slow to mount while running in a task created by xTaskCreate but not xTaskCreatePinnedToCore  (IDFGH-5006)

If you enable the Power Management feature, and attempt to mount either Spiffs or NVS in a separate thread create by xTaskCreate (regardless of the priority), and the rest of the tasks in the project are in wait state, both nvs_flash_init() and esp_vfs_spiffs_register() will take 9-10 seconds to return.
Creating the task using xTaskCreatePinnedToCore (regardless of the core selected) solves the issue and those mounting functions will return within 200-300 ms (on my 80mhz ESP32).
Acquiring locks doesn't seem to do anything.

I can confirm that I'm seing this behaviour on ESP32-S3 with IDF v4.4.4


[YouTrack] Add ability to create tasks

Extension
https://www.raycast.com/tiulpin/youtrack
Description
Hi! Thanks for your effort.
It would be a cool addition to be able to create a task from Raycast.
Who will benefit from this feature?
me :)
Anything else?
No response

@skoch13 hey king, you dropped this 👑

@snpefk thanks. Have you tried it already? Any feedback?

Yeah, it would be nice if I can change task status to "In progress" from creation page.


Steps where not resolved in all cases

👓 What did you see?

✅ What did you expect to see?
All steps should be detected.
📦 Which tool/library version are you using?
Windows10
vscode 1.74.3
Cucumber ext. v1.7.0
🔬 How could we reproduce it?
Steps to reproduce the behavior:

Clone https://github.com/tbeede/python-cucumber.git
Install Cucumber 1.7.0
Open file features/create_folder.feature
The following line should not be resolved as expacted.
https://github.com/tbeede/python-cucumber/blob/master/features/create_folder.feature#L7

📚 Any additional context?
settings.json
{
    "cucumber.glue": [

        "src/test/**/*.java",
        "features/**/*.js",
        "features/**/*.jsx",
        "features/**/*.ts",
        "features/**/*.tsx",
        "features/**/*.php",
        "features/**/*.py",
        "tests/**/*.py",
        "tests/**/*.rs",
        "features/**/*.rs",
        "features/**/*.rb",
        "*specs*/**/.cs"
    ],
    "cucumber.features": [

        "src/test/**/*.feature",
        "features/**/*.feature",
        "tests/**/*.feature",
        "*specs*/**/.feature"
    ],
}

Same here but running on MacOS 12.5.1, VSCode 1.76.0

Hi @MS-Astra, thanks for raising. The link shared appears to have become inactive, so currently unable to reproduce as mentioned. Are you able to provide a copy of the repository you used or indicate whether you found a resolution? Likewise @nicopaez?
Note: If you are using the @step decorator with Behave, this is not supported and you will need to migrate to @given, @when, and @then.
If the issue can no longer be reproduced or if we do not have an understanding of the environment in which the issue was raised, I would make the recommendation that we close the issue and reopen it if becomes necessary.

@MS-Astra, @nicopaez; located a fork of the linked python-cucumber repository.
The undetected step definition pattern in this case was:
@when('user adds a folder with name "{folder_name}"')
def step_impl(context, folder_name):
    context.settings_page.create_folder(folder_name)

Issue
The Cucumber Language Service - which implements language support for the extension - interprets named arguments (such as {folder_name}) as Cucumber Expression custom parameter types - which need to be defined outside the step definition pattern. You will observe this error from the Output window (see below image).
[Info  - 21:20:03] Scheduling reindexing in 3000 ms
[Info  - 21:20:06] Reindexing file:///Users/<user>/projects/python/python-cucumber
[Info  - 21:20:07] * Found 7 feature file(s) in ["src/test/**/*.feature","features/**/*.feature","tests/**/*.feature","*specs*/**/.feature"]
[Info  - 21:20:07] * Found 24 steps in those feature files
[Info  - 21:20:07] * Found 10 glue file(s) in ["src/test/**/*.java","features/**/*.js","features/**/*.jsx","features/**/*.ts","features/**/*.tsx","features/**/*.php","features/**/*.py","tests/**/*.py","tests/**/*.rs","features/**/*.rs","features/**/*.rb","*specs*/**/.cs"]
[Info  - 21:20:07] * Found 0 parameter types in those glue files
[Info  - 21:20:07] * Found 7 step definitions in those glue files
[Error - 21:20:07] * Step Definition errors: Error: This Cucumber Expression has a problem at column 31:

user adds a folder with name "{folder_name}"
                              ^-----------^
Undefined parameter type 'folder_name'.
Please register a ParameterType for 'folder_name'
    ...
    at u (/Users/<user>/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:454:11308)

The Language Service does not provide support for the default step matcher used by behave (which uses the Python parse package). However, where patterns in that format overlap with the syntax of Cucumber Expressions, matches are detected.
The extension README documenting 'Behave' support is perhaps slightly misleading in this regard, lacking this detail; and likewise the 'python-cucumber' repository does not actually use Cucumber step patterns - though of course uses gherkin which the Cucumber team defines.
Mitigating the issue
Use anonymous/positional arguments instead of named arguments
Cucumber Expressions and Behave's default matcher both support 'anonymous' parameters. Thus, simply removing the name from the parameters will treat values passed to the step definition as positional arguments rather than keyword arguments; and will be detected by the Cucumber extension AND executable by Behave - matching anything passed to it.
@when('user adds a folder with name "{}"')
def step_impl(context, folder_name):
    context.settings_page.create_folder(folder_name)

I have created a fork of python-cucumber that uses unnamed parameters.
Use regex matcher
Behave's regex matcher can be used alternatively, and regex is supported by the extension. Though this is perhaps a developer-unfriendly alternative (see Behave documentation on Regular Expressions).
Migrate to using Cucumber Expressions with Behave
Use Behave Cucumber Matcher to enable support for Cucumber Expressions in Behave. Follow the README to see how to integrate it.
pip install behave-cucumber-matcher

Once you've integrated Cucumber Expressions support, you will have a number of different options in how you want to use those expressions. It is best to consult the Cucumber Expressions documentation in this regard. However, some considerations are outlined below.
Ideally Behave would provide this support natively. There is an open issue on Cucumber Expressions support natively in Behave, which would be an ideal scenario - I would encourage you both to upvote it.
Create custom Cucumber Expressions types
Creating the below Cucumber Expressions parameter type would require no change to the original step definition pattern. The regexp keyword argument defines the patterns to match.
color_parameter = ParameterType(
    name="folder_name",
    regexp="<add your regex for matching a valid folder name here>",
    type=str,
    transformer=lambda s: s,
    use_for_snippets=True,
    prefer_for_regexp_match=False,
)

Use native Cucumber Expressions types
With the below example, we replace the quotations and the original named parameter with the Cucumber Expressions string type. This will match gherkin text in quotations.
@when('user adds a folder with name {string}')
def step_impl(context, folder_name):
    context.settings_page.create_folder(folder_name)

Use Regex within the pattern
Cucumber Expressions support regex, which can be used alternatively to parameter types or native Cucumber Expressions types. You can use regex in part or all of the expression.
Migrate from generic @step decorator
Behave's generic @step decorator is unsupported in Cucumber by design as it has been considered that patterns should rarely fall into all three contexts (Given/When/Then). You can still execute it, but it won't be detected by the extension. However, decorating the same step definition with each required decorator works.
@given('user adds a folder with name "{}"')
@when('user adds a folder with name "{}"')
@then('user adds a folder with name "{}"')
def step_impl(context, folder_name):
    context.settings_page.create_folder(folder_name)

Resolution
For me, this issue can be marked resolved by updating the documentation to clarify and simplify some of the above comments. I will raise a PR time-allowing.
I will leave it out up to you both whether you want to open a feature request on the Cucumber Language Service for the default Behave matcher; though we currently only support Cucumber Expressions and Regular Expressions across our language support.

@kieran-ryan Thank you for the detailed clarification of the reported behaviour. For my own projects I will try to use anonymous arguments instead of named arguments.
Great Work!


Removal of Scaffolds -4

@yuvrajsinghgmx I will remove scaffolds for the following files:
1)SizePreferences.kt
2)PrivacyPolicy.kt
3)Terms.kt
4)AddBankAccountScreen.kt
5)AddDigitalWalletScreen.kt

@yuvrajsinghgmx Kindly , assign and I'll start working on it immediately.....Thanks :)


No longer works with leaflet master version

Broken by Leaflet/Leaflet@789c35601775d47cbbd4747aa586b78a94c787c1
Hopefully an easy fix

Still / again doesn't work. Take leaflet master and markercluster master, build them, and it gives an error to leaflet-src.js line 135 on method trim. It seems, that root of the cause is here:
https://github.com/Leaflet/Leaflet.markercluster/blob/master/src/MarkerClusterGroup.js#L46
L.FeatureGroup.EVENTS are undefined. Any hints how this will work? If EVENTS property is removed from featuregroup, how to fixed this?


Admin: Get message by id (full details)

Won't do: getting all messages for admin already provides all details.


Add visionOS support and update ContentView for immersive experience

A small Christmas gift from the 👑

Implemented visionOS interface in pISSStreamApp with a new WindowGroup and ImmersiveSpace.
Added visionOS-specific modifiers in ContentView to enhance user experience.
Updated settings to support XR features for iPhone and iPad.

Oh wow, someone's been busy! I'll just give you commit rights, no point in having to wait for me on these

Alright @durul you're now a collaborator! Don't make me regret this 😀

Alright @durul you're now a collaborator! Don't make me regret this 😀

“Aw, thanks! I’ll be sure to sprinkle in just the right amount of chaos to keep things interesting. You’re gonna love it!” 😍


Publish Low Resolution

Is there an existing issue for this?

[x] I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?
Some projects will have more than 4k resolutions.
we probably don't need to work with project settings sometimes, especially when it's going for during the initial stage of shot. rendering the higher resolution effects the production time.
Suggested implementation?
It would be great to have the exposed format parameter on the write node. let the user publish the previews at his won resolution.
The current validation is good for hinting the artist before publishing
Describe alternatives you've considered:
I ran some tests on the above solution, correct me if this is already existed

Yes, this will need to be added. Thank you for the suggestion. We will need to make sure all validators will pass too. Currently, we are validating the Render product is settings the Shot attributes for output resolution.


ServerlessSecurity Defender Integration

Releasing new Host versions.
V3 Release
V2 Release

PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] If applicable, the PR references the bug/issue that it fixes in the description.
[ ] New Unit tests were added for the changes made and CI is passing.

Other Useful Information

Size of Node18 Image reduced from 862 MB to 831 MB
Size of dotnet in-proc image reduced from 864 MB to 743 MB

Closing the PR as defender integration is delayed for now.


[3pt] Log processing times per section in post processing

Recently, each section in the fim_post_processing.sh has been taking longer and longer. At this point, AWS can log it but it is so overwhelmed with output logs that it is very hard to find. AWS saves off only small parts of console output at a time and ultimately create many hundreds of AWS logs for our run. And they are non-searchable. You can find stuff, but it takes a large amount of error.
Let's add a new output file for the output folder, maybe called post_processing_times.log.  For each section, record its section name and duration in a log file all run by post processing. This gives us a simple, quick file to see what is happening in the post processing file. This is a pretty small easy fix but has big value.

Not sure if this is an anomaly, but fim <IP_ADDRESS> BED took 15 hrs 45 min to post process on AWS EC2 Prod3and that is at 40 cores. No wonder AWS Step functions can handle it. While this could be an anomaly, spot checking showed it was very slow getting through agg by huc.
Considering we are how realizing you can not re-run post processing as files are compromised during each run, this makes this system very risky. Efforts are already in place to address the re post processing issue. See 1141
It is also worth while to review
This Issue closes and replaces 1175 and 1095 issues.

Closing this Card.  This is currently being rolled into another issue card 1095 which is being updated currently.


https://github.com/users/ONJoseph/projects/3

https://github.com/users/ONJoseph/projects/3
There are 2 people in the team.
@ivanmvh
@ONJoseph

Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
The provided project link is inaccessible, like mentioned in the previous review. This might be due to you marking the repository as private. In that case, please change the permission to public so that it is accessible.
GitHub project access:

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @ivanmvh and @ONJoseph,
Highlights
✔ Descriptive PR
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻

[ ] All your tasks do not have descriptions. Kindly ensure all your issues have descriptions.

[ ] You are missing an issue for this task.

[ ] You are missing an issue for this task.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

All your requirements were done. Thank you.

Hi @TEAM,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

Group work ✔
Good implementations ✔

Required Changes ♻

[ ] [REQUIRED] Good job so far! Please implement the previous reviewer's suggestion, kindly add description to this tasks =>
#14
#13
#12
#11
#10
#9
#8
#7
#6
#5
#4
#3
#2

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Good I understood better  how to create the Kanban Board. Thank you.

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

[ ] Nice job implementing the changes 🚀

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


remove refs to Istio 1.0 in docs, move grpc samples to samples/apigee

Change-Id: I704c389c87f2a65e3afa188624aba9d180d2718a

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #283   +/-   ##
=====================================
  Coverage      82%    82%
=====================================
  Files          22     22
  Lines        1667   1667
=====================================
  Hits         1358   1358
  Misses        189    189
  Partials      120    120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17e3f4...5cc38ce. Read the comment docs.


Target of URI doesn't exist: 'package:fl_chart_app/presentation/resources/app_resources.dart'

The error "Target of URI doesn't exist: 'package:fl_chart_app/presentation/resources/app_resources.dart'" occurs when trying to import this package (included in the examples provided).
Versions used:
fl_chart : 62.0
Flutter: 3.10.2
Dart SDK version: 3.0.2

There might be a problem in your local environment.
Can you do a clean git pull from the latest version of fl_chart and flutter please?

Hi, I'm having this exact same problem, installed fl_chart 0.66.0 using flutter pub add fl_chart and running the latest stable version of Flutter (3.16.8)

I don't understand why it is happening.
Because when you import fl_chart, example/ app will not retrieved.

I have the same question，anybody can help me？


Status hook for conversion

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[ ] I've searched the bugtracker for similar questions including closed ones

Question

Hello, I was wondering if there is anyway I can check for the status of the conversion?
if ['status'] == 'finished'  is really nice for checking the download, but I could not find anything regarding the conversion. Thanks in advance!

Currently, no.


Youtube-dl error download playlist

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description
Error youtube-dl -i "link_playlist"
[youtube:tab] playlist: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
WRITE DESCRIPTION HERE

PASTE VERBOSE LOG HERE

Why not do that?

PASTE VERBOSE LOG HERE

Why not do that?

[youtube:tab] playlist: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Like this!


Plus background in wrong position

Development branch.
The background to the plus is not below the plus. It's up in the corner.

thx


Add a lock to ClusterQueueFromLocalQueue

What type of PR is this?
/king bug

What this PR does / why we need it:
This function should lock and unlock to prevent race conditions.
Which issue(s) this PR fixes:

Fixes #1954
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @alculquicondor
/assign @tenzen-y


Pathfinder goes to last death position of target instead to new positions

Hi, these are relevant code snippets:
Basically the normal following works great, but (default behaviour) when the target disconnects the bot just stays where it was.
So, I tried this by setting a new goal after the target joins again.
After 3 seconds (delay) the bot runs for half a sec towards the target BUT then stops, stays in place and says:
"I can get there in 1 moves. Computation took 2115.72 ms"
with increasing ms up to around 5000.
What is going on? Also, the bot just stays there after the target died, even if it respawns right next to him. Is there some callback to catch for the entity going missing instead of manually tracking who joined or died?
My code:
//Follow command, works everytime after being called:
goal_memory = [new goals.GoalFollow(target, 2), (cmd[2] ? (isYes(cmd[2]) ? true : false) : true)]
                bot.pathfinder.setGoal(goal_memory[0], goal_memory[1])

//Event, doesnt work at all in very strage way.
//Note that the getPlayer function is somewhat a bot.players[username]
//The log of the entity returns the valid entity as json
//goal_memory[1] stores if its dynamic (which it is everytime in this scenario)
bot.on("playerJoined", (player) => {
        if(goal_memory && goal_memory[0] instanceof goals.GoalFollow && goal_memory[0].entity.username.trim() === player.username.trim()) {
            setTimeout(() => {  //Non blocking while(!p.entity)) would be better
                if(getPlayer(player.username) && getPlayer(player.username).entity) {
                    log(JSON.stringify(getPlayer(player.username).entity, null, 2))
                    //log(getPlayer(player.username).entity.username)
                    //bot.pathfinder.setGoal(null)
                    bot.pathfinder.setGoal(null)
                    bot.pathfinder.setGoal(new goals.GoalFollow(getPlayer(player.username).entity), goal_memory[1])
                    //let walk_pos = bot.spawnPoint
                    //bot.pathfinder.setGoal(new goals.GoalXZ(walk_pos.x, walk_pos.z, 0))
                    log("[Pathfinder] Set goal to last memory.")
                } else {
                    log("[Memory] Error, could not get entity of " + player.username + ".")
                }
            }, 3000);
        }
    })

Here, it thinks it arrived but when I move away it stays there and this happens:
[Pathfinder] I can get there in 2 moves. Computation took 40.44 ms.
[Pathfinder] I can get there in 2 moves. Computation took 94.30 ms.
[Pathfinder] I can get there in 2 moves. Computation took 161.60 ms.
[Pathfinder] I can get there in 2 moves. Computation took 203.47 ms.
[Pathfinder] I can get there in 1 moves. Computation took 249.68 ms.
[Pathfinder] I can get there in 1 moves. Computation took 311.29 ms.
[Pathfinder] I can get there in 1 moves. Computation took 352.61 ms.
[Pathfinder] I can get there in 1 moves. Computation took 393.60 ms.
[Pathfinder] I can get there in 1 moves. Computation took 449.94 ms.
[Pathfinder] I can get there in 1 moves. Computation took 512.24 ms.
[Pathfinder] I can get there in 1 moves. Computation took 553.87 ms.
[Pathfinder] I can get there in 1 moves. Computation took 595.18 ms.
[Pathfinder] I can get there in 1 moves. Computation took 652.28 ms.
[Pathfinder] I can get there in 1 moves. Computation took 715.80 ms.
[Pathfinder] I can get there in 1 moves. Computation took 757.57 ms.
[Pathfinder] I can get there in 1 moves. Computation took 799.94 ms.
[Pathfinder] I can get there in 1 moves. Computation took 853.86 ms.
[Pathfinder] I can get there in 1 moves. Computation took 915.52 ms.
[Pathfinder] I can get there in 1 moves. Computation took 957.69 ms.
[Pathfinder] I can get there in 1 moves. Computation took 998.88 ms.
[Pathfinder] I can get there in 0 moves. Computation took 40.43 ms.
[Pathfinder] I can get there in 0 moves. Computation took 41.09 ms.
[Pathfinder] I can get there in 0 moves. Computation took 40.09 ms.
[Pathfinder] I can get there in 0 moves. Computation took 40.66 ms.
[Pathfinder] I can get there in 0 moves. Computation took 81.38 ms.
[Pathfinder] I can get there in 0 moves. Computation took 128.63 ms.
[Pathfinder] I can get there in 0 moves. Computation took 40.29 ms.
[Pathfinder] I can get there in 0 moves. Computation took 107.02 ms.
[Pathfinder] I can get there in 0 moves. Computation took 148.00 ms.
[Pathfinder] I can get there in 0 moves. Computation took 188.93 ms.
[Pathfinder] I can get there in 0 moves. Computation took 243.91 ms.
[Pathfinder] I can get there in 0 moves. Computation took 304.13 ms.
[Pathfinder] I can get there in 0 moves. Computation took 345.77 ms.
[Pathfinder] I can get there in 0 moves. Computation took 387.00 ms.
[Pathfinder] I can get there in 0 moves. Computation took 436.55 ms.
[Pathfinder] I can get there in 0 moves. Computation took 494.13 ms.
[Pathfinder] I can get there in 0 moves. Computation took 556.67 ms.
[Pathfinder] I can get there in 0 moves. Computation took 598.19 ms.
[Pathfinder] I can get there in 0 moves. Computation took 638.71 ms.
[Pathfinder] I can get there in 0 moves. Computation took 698.44 ms.
[Pathfinder] I can get there in 0 moves. Computation took 739.00 ms.
[Pathfinder] I can get there in 0 moves. Computation took 780.43 ms.
[Pathfinder] I can get there in 0 moves. Computation took 837.93 ms.
[Pathfinder] I can get there in 0 moves. Computation took 899.68 ms.
[Pathfinder] I can get there in 0 moves. Computation took 940.65 ms.
[Pathfinder] I can get there in 0 moves. Computation took 981.95 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1042.17 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1103.71 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1145.34 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1186.64 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1241.06 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1303.01 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1344.68 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1385.92 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1445.09 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1506.72 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1547.71 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1588.29 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1648.49 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1710.68 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1752.28 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1793.35 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1851.09 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1892.45 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1933.16 ms.
[Pathfinder] I can get there in 0 moves. Computation took 1989.95 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2054.47 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2096.29 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2137.81 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2192.01 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2255.52 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2296.03 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2336.80 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2397.22 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2461.22 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2502.55 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2545.64 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2602.93 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2643.72 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2684.44 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2740.14 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2804.34 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2844.98 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2887.05 ms.
[Pathfinder] I can get there in 0 moves. Computation took 2942.66 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3004.59 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3045.04 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3086.52 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3143.37 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3205.62 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3247.10 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3288.34 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3347.08 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3408.05 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3450.61 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3491.12 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3549.59 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3590.37 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3632.21 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3682.59 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3733.64 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3796.29 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3860.76 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3902.05 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3942.99 ms.
[Pathfinder] I can get there in 0 moves. Computation took 3995.64 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4061.45 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4102.83 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4143.82 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4197.15 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4259.91 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4301.08 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4341.87 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4401.95 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4443.10 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4484.13 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4536.47 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4589.41 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4650.02 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4690.99 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4732.09 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4789.39 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4851.83 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4892.89 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4934.01 ms.
[Pathfinder] I can get there in 0 moves. Computation took 4985.22 ms.
[Pathfinder] I can get there in 0 moves. Computation took 5000.15 ms.

ok, strangely I fixed the respawn target issue with this:
let target = getPlayer(player.username).entity

                    goal_memory[0] = new goals.GoalFollow(target, 2)
                    bot.pathfinder.setGoal(goal_memory[0], goal_memory[1])

If somebody knows why it fixed it please tell me
And the running to the last spot (when target dies) is due to that the bot saves the last copy of the entity when the entity is null, right? I would change that to eiter make the goal finish or let it abrupt.

Invalid follow goals on entity should be fixed. Reopen or make a new issue if you find issues about this on the latest version.


[SPARK-30960][SQL] add back the legacy date/timestamp format support in CSV/JSON parser

What changes were proposed in this pull request?

Add back the support of the legacy date/timestamp format in CSV/JSON parser, which was removed by https://issues.apache.org/jira/browse/SPARK-26178 and https://issues.apache.org/jira/browse/SPARK-26243.
Why are the changes needed?

It doesn't hurt to keep this legacy support. It just makes the parsing more relaxed.
Does this PR introduce any user-facing change?

yes, to make 3.0 support parsing some csv/json values that were supported before.
How was this patch tested?

new tests

Test build #118979 has started for PR 27710 at commit 766fb50.

cc @MaxGekk @HyukjinKwon @srowen @xuanyuanking

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23727/
Test PASSed.

Test build #118979 has finished for PR 27710 at commit 766fb50.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118979/
Test FAILed.

Test build #118988 has started for PR 27710 at commit 7613d54.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23736/
Test PASSed.

Test build #118988 has finished for PR 27710 at commit 7613d54.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118988/
Test PASSed.

Test build #119048 has started for PR 27710 at commit 16db32f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23794/
Test PASSed.

Test build #119048 has finished for PR 27710 at commit 16db32f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119048/
Test PASSed.

cc @xuanyuanking

Merged to master and branch-3.0.

Thank you all!


Known Issues with Azure Services

Please update the 'Known Issues with Azure Services' to include that the Cloud Management Gateway (if installed) on the Primary, needs to be uninstalled first to expand a stand-alone primary site.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b3c02ca-4813-9b76-65a6-e9afce739bad
Version Independent ID: 8fd815c3-c681-247a-7674-76109d5ed1e6
Content: Prerequisites for sites - Configuration Manager
Content Source: sccm/core/servers/deploy/install/prerequisites-for-installing-sites.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

This issue is closed because I submitted a change for it that will publish tomorrow


Release 2.0.8

Resolves #21, #20, #19, #18, #17.
Changes in this Release

Fixed Reactor output being capped at 8192EU/t. It's now possible to exctract entire power generated from the reactor at voltage 5.

Fixed IC2 Version extraction when the mods are in the 1.12.2 folder. I think most people forgot about this Forge feature, that was later on just removed 😄

Night Vision effect is now removed instantly also from the Quantum Suit Helmet.

All IC2 Jetpacks can now be disabled. This won't probably work for IC2 jetpacks from addons.

Chunk Loader now works again. OV and OD Scanners don't crash anymore and function properly.

[Experimental] WorldData now only gets replaced when new reference is the same class as the original on the first load. Another attempt at fixing randomly disconnecting cables.

Waiting for E2EE dev to test the patcher out. From my testing on E2E it appears to work just fine on 164 😄

After testing, the release is good to go 👍
Sorry for soo much delay to everyone that reads this >.>


Makefile: support containerd in minikube-install target

Makefile: support containerd in minikube-install target
The minikube-install target was using 'minikube docker-env', which only
works with the docker container runtime. Also support 'minikube image
load' for other container runtimes.
How to use
$ minikube start --container-runtime=containerd --cni=calico
...
$ make minikube-install
...
Image on the host:
docker image list --format "table {{.ID}}\t{{.Repository}}:{{.Tag}}\t{{.Size}}" |grep albantest.azurecr.io/gadget:alban_minikube_containerd
dbda06991888   albantest.azurecr.io/gadget:alban_minikube_containerd                        805MB

...
Image in Minikube:
minikube image ls --format=table | grep "albantest.azurecr.io/gadget\s*|\s*alban_minikube_containerd" || true
| albantest.azurecr.io/gadget             | alban_minikube_containerd | sha256:dbda06 | 354MB  |

...
kubectl rollout status daemonset -n gadget gadget --timeout 30s
Waiting for daemon set "gadget" rollout to finish: 0 of 1 updated pods are available...
daemon set "gadget" successfully rolled out
Image used by the gadget pod:
kubectl get pod -n gadget -o yaml|grep imageID:
      imageID: sha256:dbda06991888a342f38c19938cd62f953f450cd7a76824e723da730d6e171447

Testing done
Tested with minikube start --container-runtime=containerd --cni=calico

Updated. I also added an option to disable the liveness probe as a temporary workaround for https://github.com/kinvolk/inspektor-gadget/issues/712

Thanks!
The CI failed but it is unrelated to this PR, and the CI on main was also failing.


Added General Motors, which just announced today.

Adds or updates the following companies, events, or universities:

General Motors

Checklist
Company updates

[Yes] I have put the most recent relevant date in the "Last Update" column
[N/A] I have linked to the article about the change, not the company's homepage (Please put N/A if there is no public post)

We just received this news this morning.  I'm sure there'll be a news article about it at some point today.

Closing due to rebase and staleness. Feel free to re-open after fixes, thanks for your patience.


Find Client by inboxId not address

Replaces all the spots we use to store clients by address with inboxId so that we can fetch all of the content correctly going forward even after addresses are removed from an identity.

Looks good code wise, however my worry is that integrators upgrading to this will have a difficult time updating as address and inboxId are both considered strings, I wonder if we should introduce using a branded types instead to help catch issues of using address/inboxId wrong
type InboxId = string & { readonly brand: unique symbol };
Working Typescript example:
https://www.typescriptlang.org/play/?#code/FAFwngDgpgBAkgOwEYHsAecAmMC8MDOIATgJYIDmMAZDAN4xFQCGmKCANmDEkUwpgC4YAVwQkAjsNj4wAW1TsYAXwDcwYAGM2hGCCiEAgpkyN8+XDABEABjQBGAEwBmACyXN2kLv0hEqDNh4lo6uAKyWMEzmfuhY6loIOgBmohp2FgAULCb6+EKEpBQAlLgAfHTAMFUwCfgo7FAAdOwo5FnGpvhFwEqVMB6JXikIGg6ZZP5YQjEBJTjltH1VtfVNLW0TsZjdvcDDaRl6hh253ft2hz4zWN17qQ6XhNfbdyMPRyBGOWbdQA


The files are not loading correctly

I visited the website. The jQuery and other files are not loading. Because they don't have full url in src. they just have relative path
https://uk1.unblockvideos.com/index.php?q=ytimptduZZLarK6S0KappKKRxmOW0dGR
Can you please look into it
thanks!

or see this http://www.abc.org.uk/
so if the webiste has relative path. it will break

Yup. The problem was with CSS import directives that weren't "proxified". All fixed now: https://github.com/Athlon1600/php-proxy/commit/357dca4ff90e2fe3b577ff309a7743b2f9b53ac2

After download the latest Code when i run it

As you can see the html is loading inside js request. can you please check it . thanks!

I can't access phpproxy.local. Can you rehost it on some public server?

let me upload on server then give you the url

http://techesthete.net/php-proxy
please see here.

https://www.mottmac.com/ is the url that is being loaded

I'm very confused. Are you using php-proxy-app or php-proxy alone? https://www.mottmac.com/ loads just fine on unblockvideos.com.
If you're only using php-proxy and trying to "mirror" the output back to client, then you will need to enable "ProxifyPlugin".

Ok i configure php-proxy-app on server. It still not load relative jquery and image .
please check here
http://techesthete.net/php-proxy/index.php?q=3Nnn5OefoqPr3Oqi4dTn6OHG1qLX1OCj
thanks!

did you check ?

https://github.com/Athlon1600/php-proxy/commit/d9964b49e8ebf97dfabbfb8ebb813db5e7fe6fc6
Yes, everything seems to load now with the exception of the big image at the top which probably isn't that important.

thanks for the update. It looks good now.
I can still see some error like in original site there is a sidebar that is not showing anymore. Plus i can see the fonts are not loading. let me show you one example
https://www.dropbox.com/s/1itv6a1go9d6064/Screenshot 2015-08-25 11.30.45.png?dl=0

Btw everything is important. it has to load everything. I hope we can make this script more and more better :)