try codium

@CodiumAI-Agent /review

try

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: This PR mainly focuses on updating the website's CSS and HTML files to improve the visual appearance and functionality. It also updates the author's personal information in the _config.yml file.
📝 PR summary: The PR includes changes to the CSS files to add new classes and animations, updates to HTML files to include new scripts and links, and modifications to the _config.yml file to update the author's personal information. It also modifies the navigation.yml file to update the website's navigation structure.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, because the PR includes a significant amount of changes to the CSS and HTML files which require a careful review to ensure they do not break the website's layout and functionality.
🔒 Security concerns: No security concerns found

PR Feedback
💡 General suggestions: The PR seems to be well-structured and the changes are logically grouped. However, it would be beneficial to include a more detailed description of the changes in the PR description, explaining the purpose of each change and its impact on the website's appearance or functionality.
 🤖 Code feedback:relevant fileassets/css/main.scsssuggestion
It would be beneficial to separate the CSS classes into different files based on their functionality for better organization and easier maintenance. [medium]
relevant line.tooltip {relevant file_includes/head.htmlsuggestion
It would be better to load the CSS files from a local source instead of a CDN to reduce the website's dependency on external sources. [medium]
relevant linerelevant file_config.ymlsuggestion
It is recommended to avoid hardcoding personal information in the _config.yml file. Instead, consider using environment variables or a separate configuration file that is not tracked in the version control system. [important]
relevant lineemail<EMAIL_ADDRESS>file_sass/_animations.scsssuggestion
The naming of the animation 'blink' is too generic. Consider using a more descriptive name that indicates its purpose or effect. [medium]
relevant line@keyframes blink {

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Review

      PR feedback                       ⏱ Estimated effort to review [1-5]
4, because the PR includes a wide range of changes across multiple files, including CSS, HTML, and configuration files. The changes involve both content updates and stylistic adjustments, which require careful review to ensure consistency and compatibility across different parts of the project.

 🧪 Relevant tests
No

 🔍 Possible issues

The tooltip CSS in both '_sass/_page.scss' and 'assets/css/main.scss' might cause redundancy and inconsistency. Consider consolidating these styles.
The use of transform: scaleX(0); and transform: scaleX(1); for the tooltip underline animation could be improved for browser compatibility.
The addition of multiple font-awesome related files and links might lead to loading performance issues. Consider using a single, minified version.
The removal of some navigation items in '_data/navigation.yml' without explanation could impact site navigation and user experience.

 🔒 Security concerns
No

 Code feedback:
relevant file_sass/_page.scss
suggestion

Consider merging the tooltip styles defined in '_sass/_page.scss' and 'assets/css/main.scss' to avoid redundancy and ensure consistency. [important]

relevant line.tooltip {
relevant file_sass/_page.scss
suggestion

Use a more compatible approach for the tooltip underline animation instead of transform: scaleX(0); and transform: scaleX(1);. Consider using visibility or opacity for better cross-browser support. [medium]

relevant linetransform: scaleX(0); /* 初始时隐藏下划线 */
relevant file_includes/head.html
suggestion

Consolidate the font-awesome CSS links to use a single, minified version to improve loading performance. [important]

relevant line
relevant file_data/navigation.yml
suggestion

Ensure the removal of navigation items like "News", "Projects", and "Experience" is intentional and consider the impact on site navigation and user experience. [medium]

relevant line# - title: "News"

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


DSD-314: Slider component

Fixes JIRA ticket DSD-314
This PR does the following:

Adds the Slider component based on Chakra's Slider and RangeSlider components.
Note: This PR branch also updates Chakra similar to PR #766 . Let's merge that one in before this one since that one is clearer about its update and intention.

Two important dev notes:

I did not use the value prop as specified in the spec doc. I don't think users need to control this component since it already has an internal state to keep track of the display value. They can get the value by passing in the onChange function. Let's see how that turns out.
I did not add the variation in the Figma file that shows two volume icons for its display since those icons are not available in the repo.

Another minor note: the latest version of chakra adds extra data-* attributes to labels so you'll see changes in some snapshot tests.
How has this been tested?
Storybook.
Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr767-dpz2pjuzo30blvaz5r0mthuqm9qryizo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6195677e908ae1473b5cb474

Tugboat has finished building the preview for this pull request!
Link:

https://pr767-dpz2pjuzo30blvaz5r0mthuqm9qryizo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6195677e908ae1473b5cb474

Tugboat has finished building the preview for this pull request!
Link:

https://pr767-dpz2pjuzo30blvaz5r0mthuqm9qryizo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6195677e908ae1473b5cb474

Tugboat has finished building the preview for this pull request!
Link:

https://pr767-dpz2pjuzo30blvaz5r0mthuqm9qryizo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6195677e908ae1473b5cb474


Update Microsoft.Resources swagger to include new alias contract

These properties are already available for some time now, the swagger is out of date.
The main goal is to add the alias path metadata related properties. I also had to add the default API version and API profiles because they show in the example payload and it won't pass validation otherwise.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[x] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Hi @raych1 what is the next step? Is there anything else i need to do in order to merge this PR?


Update badge for travis in README.md

Update README for updating travis badge.
After click badge of travis, i got the following information:

Maybe it's not a bad idea updating the url of the badge :D

Description
Update badge for travis in README.md

This PR has:

[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Key changed/added classes in this PR

README

LGTM. I think the failure was a false alarm, because no code was changed. Thanks!

LGTM. I think the failure was a false alarm, because no code was changed. Thanks!


Thin or small fonts rendered on Windows appear colorfully blurry.

Until looking through the code, I had thought Atom was using Microsoft's WPF graphics rendering interface for the GUI. In which case the solution is simply setting the text-formatting option to "Display" rather than the default "Ideal".
www.hanselman.com/blog/WPFAndTextBlurrinessNowWithCompleteClarity.aspx
I don't know what's causing blurry fonts on Atom, but it's certainly not my system configuration to blame; I'm not using any unusual settings/hardware; default DPI with a 1440x900 display. Other software (Notepad++, Visual Studio, Eclipse, etc) render fonts just fine.

Hey @xFleury, thanks for leaving your feedback! :bow: We are aware that there are some issues with text rendering on Windows and we have already planned to work on them, although they usually arise with high-DPI screens.
Is this something that appeared recently? If yes, would you help us tracking down which version was the culprit?
Atom doesn't use WPF internally, but it simply delegates to Chromium (and its internals) the hard work of rendering and painting on screen. Thus, I am afraid we're out of luck with the "Text Formatting" option. By having a look at the screenshot you provided, though, I can tell that the text is being render using sub-pixel antialiasing (which normally is a good thing). As a temporary workaround, you may try to force Chrome to ignore this setting by dropping the following snippet into your styles.less:
atom-text-editor::shadow .lines {
  -webkit-font-smoothing: antialiased;
}

This will make text rendering fall back to grayscale anti-aliasing and should, at least, prevent this unfortunate colorful blurriness you're experiencing. Not sure, though, if it will make the experience reasonably acceptable.
My hope is that we will be able to fix this once for all as soon as we complete #6055: that will enable us to make use of the recent subpixel-font-scaling feature which, based on the IE 9 blog, fixes blurriness for normal screens as well as high-DPI ones.
/cc: @nathansobo @paulcbetts

The text on non-high DPI screens (i.e. 96DPI) actually looks pretty alright, it seems unique to high-DPI screens

@paulcbetts Do you think re-enabling subpixel font rendering could fix the issue. Seems like it might. In that case #6083, which fixes our character measurement, will enable us to turn that back on.

@nathansobo I'm gonna try it on my machine that repros this issue on Monday (/cc @as-cii, was gonna do this on Friday but wasn't able to)

So, it appears that subpixel font rendering doesn't actually have much of an effect - this isn't super surprising, on High DPI displays the pixels are already too small to be visible.
However! Disabling direct-write does seem to improve text quality, at the (possible) expense of scroll speed. DirectWrite is also soon becoming the main (only?) render platform in Chrome, so disabling it is probably a short-term solution.
Another interesting facet of this bug is that it seemed as if the font size had an effect - as I hit Ctrl-+, the font would go blurred => not blurred => blurred, which is Odd™.

Thank you @paulcbetts for your extensive investigation! :clap:

So, it appears that subpixel font rendering doesn't actually have much of an effect - this isn't super surprising, on High DPI displays the pixels are already too small to be visible.

This is interesting: I have always assumed that the blurring could have been caused by pixels being scaled inappropriately, thereby introducing some rounding error which, in turn, made characters look blurry.

Another interesting facet of this bug is that it seemed as if the font size had an effect - as I hit Ctrl-+, the font would go blurred => not blurred => blurred, which is Odd™.

This would seem to confirm the above hypothesis and sub-pixel font scaling should have an effect on text rendering I am not quite sure why it doesn't. @paulcbetts: could you confirm that lines (.tile and .line) are being positioned with integral coordinates (i.e. Math.round(x) == x) across font sizes? @nathansobo: could it be possible that something like e.g. lineHeightInPixels is the culprit?
Now that I think about it, I recall @paulcbetts reporting that translate worked just fine and, as far as I know, translate in Chrome rounds pixels automagically (http://stackoverflow.com/a/18259138/464250, not sure if this is actually correct though).
@paulcbetts: Also, I am wondering... Could you try reproducing this through a bare minimum example which makes use of translate3d? Probably you can simply try it in a Chrome web page, although it's probably better to build a simple Electron application which matches Atom's version. The idea is to have only something like the following:

    Hello World!

And check if it looks blurry. If it does, it could be interesting to check if changing the translation amounts (e.g. 9px, 9.5px, etc.) has any effect on text rendering.
@paulcbetts: I am sorry for asking you all this stuff; I'd love to investigate this without bothering people but I haven't got any High-DPI machines at hand, unfortunately. If you don't feel like giving this a try, it's totally fine and I would understand that. So, thanks anyway! :raised_hands:

However! Disabling direct-write does seem to improve text quality, at the (possible) expense of scroll speed. DirectWrite is also soon becoming the main (only?) render platform in Chrome, so disabling it is probably a short-term solution.

I agree we need to solve the issue in harmony with DirectWrite and I'll definitely do some more research on this in the meantime.

@paulcbetts: also, how does the gutter render compared to text lines?

On a side note, I have managed to reproduce it with the following configuration:

Windows 8.1 Virtual Machine (virtualized via Parallels)
1080p display
150% scaling (both for all the displays, or just the current one)

I have been playing with the DOM under the above configuration and, apparently, everything looks crisp when I round translateY(n) to an odd number. This seems to be somewhat similar to the problem that was reported over here: I would classify this as a Chrome bug, though, and, as a result, we should probably collaborate with them to identify what's the root of this pesky issue.
@paulcbetts: as a stopgap, would you be willing to try out this branch and see how it performs on your machine? It basically applies to the code what I stated previously about the odd translateY value.

Now that I think about it, I recall @paulcbetts reporting that translate worked just fine and, as far as I know, translate in Chrome rounds pixels automagically (http://stackoverflow.com/a/18259138/464250, not sure if this is actually correct though).

translate seems to improve but not fix the situation - what completely fixes it is removing the translation altogether (but of course, breaks the app)

I have been playing with the DOM under the above configuration and, apparently, everything looks crisp when I round translateY(n) to an odd number. This seems to be somewhat similar to the problem that was reported over here: I would classify this as a Chrome bug, though, and, as a result, we should probably collaborate with them to identify what's the root of this pesky issue.

Could that multiple be related to devicePixelRatio? Or will it always be an odd number

Could that multiple be related to devicePixelRatio? Or will it always be an odd number

As far as I can tell it works just by using odd numbers on my machine, but Your Mileage May Vary™. The more I think about this, the more I am convinced it’s not an issue on Atom and Chrome 2d and 3d translations are the culprit instead.
@nathansobo: how should we proceed on this? Should we fallback to top/left positioning for High DPI Windows machines? Or it’s just better to contact the Chrome team and work with them to fix this problem?

@as-cii Good question. We should try to come up with a workaround if we can. Can we detect when we're in hi-DPI mode? If so, rounding to the nearest odd pixel could be an interesting route, since it probably won't be noticeable at that resolution. Then we can get some feedback on whether this helps and if it doesn't fix things in enough scenarios, drop back to a non-accelerated translation.
Either way, it would be good to open a bug on their issue tracker if one isn't already there. Maybe we can send some emails to direct attention to it.

@nathansobo Yeah, it's just window.devicePixelRatio > 1.0

@paulcbetts: using a multiple of devicePixelRatio doesn’t seem to work on my machine, whereas using odd numbers seems to be quite right. This has definitely something to do with this invisible pixel grid which comes from DPI and how the OS handles it. What is your experience with that branch? I have added a couple of commits more and I believe each one is worth a git checkout. Could you share how do those changes feel on a real high DPI machine?
@nathansobo: I am going to write down something and then I’ll report a bug where appropriate (either a new issue or a previous, yet similar one) in the next couple of days. :rocket:

Just commenting to say that I now have this issue on a new laptop that's at 150% DPI (the recommended was 125%, but that was a bit too small for me).  I can confirm what @paulcbetts said about increasing the font size alternating between blurry and not-blurry.
Atom 1.9.0-dev-6991246, Windows 10 x64, 1920x1080 screen.

Yeah same problem as @50Wliu

Dell XPS 13 is a great device to test this on. 150% scaling by default, it's only $1000 and it's a great little machine (except atom and apparently all other electron-based apps are blurry)

Closing this, as I think it has been solved by https://github.com/atom/atom/pull/15372.


Filtering images

How can you only keep the images for the filtered categories? Is that possible?

The code would need to be modified so that as you filter segmentations, any images referenced in those segmentations would be added to a new list of images.

The code would need to be modified so that as you filter segmentations, any images referenced in those segmentations would be added to a new list of images.


Force rebuild of all components

Issue #, if available:
Description of changes:
In my commit yesterday changing the kube-proxy-base to use the new iptables-wrapper as the default, the kube components were not rebuilt since they had not technically changed.  There are a few files, like the root Makefile where if changed it will trigger a full rebuild.
A future tasks should be done to improve the postsubmit rebuild logic to check if kube/release changes and if it does, trigger kube rebuilds.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


lr seting doesn't match actual lr,so confusing

U can see 0.0001 mismatch 2e-2

This is because the LR saved in the checkpoint is 2e-2. This seems to be a bug and we will fix it in the future.

Could you try the latest mmcv and mmdet, I can't reproduce this error.
When I resume the model of faster rcnn from epoch 5, the default learning rate is 2e-2 and I change the learning rate in config to be 8e-2, then the learning rate of learning rate is 8e-2, it is expected.

Could you try the latest mmcv and mmdet, I can't reproduce this error.
When I resume the model of faster rcnn from epoch 5, the default learning rate is 2e-2 and I change the learning rate in config to be 8e-2, then the learning rate of learning rate is 8e-2, it is expected.

I will try my model, thanks for ur attention.

Could you try the latest mmcv and mmdet, I can't reproduce this error.
When I resume the model of faster rcnn from epoch 5, the default learning rate is 2e-2 and I change the learning rate in config to be 8e-2, then the learning rate of learning rate is 8e-2, it is expected.

I change lr by set config/cascadefolder/casxxx.py,and still

Could you try the latest mmcv and mmdet, I can't reproduce this error.
When I resume the model of faster rcnn from epoch 5, the default learning rate is 2e-2 and I change the learning rate in config to be 8e-2, then the learning rate of learning rate is 8e-2, it is expected.

I think i installed the latest

This is because the LR saved in the checkpoint is 2e-2. This seems to be a bug and we will fix it in the future.

Could you try the latest mmcv and mmdet, I can't reproduce this error.
When I resume the model of faster rcnn from epoch 5, the default learning rate is 2e-2 and I change the learning rate in config to be 8e-2, then the learning rate of learning rate is 8e-2, it is expected.

So I sovle the problem by seting this

I resume from epoch_12 and set  lr_config = dict(policy='step', step=[12, 22])
lr = 0.002


 How can I use your framework to achieve relationship prediction? Should I retrain or can I use it directly?
Can you give me a brief step-by-step explanation?
Thank you very much

Hello, if you want to train a model for relationship prediction you need to have an annotated dataset with relations between objects. The easiest way to do so is to use this tool to annotate some images with your classes. Alternatively, you can use the Visual Genome dataset as based annotations and re-process them to fit your requirements. I made some scripts that could be useful for that here (there is no documentation for this procedure for now).
Best

thanks!

Hello, if you want to train a model for relationship prediction you need to have an annotated dataset with relations between objects. The easiest way to do so is to use this tool to annotate some images with your classes. Alternatively, you can use the Visual Genome dataset as based annotations and re-process them to fit your requirements. I made some scripts that could be useful for that here (there is no documentation for this procedure for now). Best


Reddit JSON API OAuth requirement not met.

After a convo in #mods today, we found out that the json feeds on reddit are still required by TOS to have OAUTH. This will need to be added into the bot, as the current method of getting the r/Python feed is without OAUTH, and we're having to tell people to comply in our own server, making this look a bit awkward.

I'd like to work on this.


[Feature request][Playground] Ability to know how many versions of a scene exists

I don't know if it's even possible, but what do you think to add a little menu to navigate between different versions of a playground scene ?
We can imagine something like that:

This can be usefull to user for example by alllowing him to quickly go to the last version of an old scene linked in an old forum thread, to see if the code was updated. Same thing for the playground links.
What do you think about that idea?
[edit] note that I've update the button "Version: latest" to avoid confusion.

The main problem is that there is no guarantee that versions are related. You can change everything between versions

Yes, but is it really annoying? The user will probably notice if something is wrong between versions.
But indeed, maybe this is not a valuable idea, 'cause user always can increment manually the anchor value.
I close this request.


Suggestion : Twitter login

It would be cool if you could make a version in which the user was forced to login with their Twitter credentials. That way you build a community without having to deal with membership. Each time I entered the room I would get my Twitter handle like @RichGriese and as a person visited the community more, you would get to know the person. And... be able to follow them via Twitter. This would eliminate the need to have any kind of user registration within the system, but would allow for unique and persistent nicknames.
It would also enable hack.chat to offer kind of meeting rooms for the entire Twitter community.
Cheers!

I'm working on an entirely new version with user logins, file uploads, and plugins. Someone could write a user authorization handler for it that calls Twitter's API. It'll probably be done within the decade...


Working sample for .vscode/ablunit-test-profile.json

Do you have a working sample for an .vscode/ablunit-test-profile.json file?
I need to add startup parameters (-assemblies) and might want to test with multiple profiles (European, American dates, different DB's, etc).
Thanks!

If you search files in this repo for ablunit-test-profile.json there are numerous unit tests that can serve as examples.  Let me know if that helps, otherwise I'll throw something together after this next release.  Hoping to get it out this weekend as I'm way behind on where I want to be 😔

Thanks, that helped!

Hasn't been released yet.  Should be cutting a pre-release today which will have this and be the release candidate for v1.0.


Adding example for https://github.com/microsoft/vscode/issues/115807

Need c+ reader

Closing as the pr does not explain why this is needed


Update README.md

This is a small change to test the CLA setup

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


[UBS-Admin. Pricing page] Cross button is present in the Region ('Область') dropdown

Environment: Windows 10 Pro, Chrome 101
Reproducible: always.
Build found: May 18, 2022
Preconditions
User should be logged in as Admin.
Steps to reproduce

Go to https://ita-social-projects.github.io/GreenCityClient/#/ubs-admin/tariffs
Click on 'Region' ('Область') dropdown and select any entry from the dropdown window (e.g. Київська область).
Click on the dropdown arrow.

Actual result
A cross button with dropdown arrow is present in the 'Region' ('Область') dropdown. There are two entries available in the dropdown list: the selected one (e.g. 'Київська область') and 'Усі' option.

Expected result
Only a dropdown arrow is present in the 'Region' ('Область') dropdown. All available entries of the 'Region' dropdown are present in the dropdown list (just like when you click on the field initially:

User story and test case links
User story #3835
Test case

The actual result is correct. We need to change story and mock-up according how it works now.


Remove bucket_name validation in Bucket constructor.

We prefer to use the server for validation (beyond things like "not empty"), because the server is the source of truth.

There no longer is a Bucket constructor, nor do we validate bucket names in the Client class.


[path_provider_linux] Migrate to null safety

Description
Migrates path_provider_linux to null safety.
Related Issues
Fixes https://github.com/flutter/flutter/issues/70219
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@blasten The PR to migrate xdg_directories to nnbd has been merged and I have updated the versions in this PR also. Can you please review it? Thanks

@blasten The PR to migrate xdg_directories to nnbd has been merged and I have updated the versions in this PR also. Can you please review it? Thanks

Looks like tests are timing out again @stuartmorgan, any idea why ?

The re-runs were very slow to be scheduled

I misread, they actually still haven't been scheduled yet. They are all still showing Scheduling was delayed due to a concurrency limit on community tasks.

They did time out again. I don't see any reason these changes should cause timeouts, so I've restarted them one more time. It's odd that it was repeatable though.

Definitely a persistent error. Were you able to build and run the example?

@yash1200 Tests in example/test/ also need to run and succeed. Make sure it is the case as I'm not sure you've tried since it was conflicting.

I see the issue; path_provider_linux predates my realization from Windows plugin work that having a dependency from the implementation example to the app-facing package is an anti-pattern (since it creates circular references), and didn't flag that during the review of the initial example setup. That circular reference makes it impossible to do this migration.
I'll rework the example and push an update to this branch.

While testing my change I discovered a regression in the nullsafe verison of xdg_directorsies that causes it to always fail, so I'm fixing that, then will return to this.

Most issues should be resolved now. I also had to fix a latent code format issue (since it only checks plugins that change, it hasn't shown up before), and merged in master to get a tooling fix that caused unrelated errors.

(The publish failure is a known issue that should be resolved by https://github.com/flutter/plugins/pull/3506)

All green! 🎉
@yash1200 Thanks for the contribution, and for bearing with the turbulence. I'll land this now, and get it published later today (or possibly tomorrow).

Thank you @stuartmorgan and @gaetschwartz for the help! :smile:


BUG: Fixed defect with maxiter #9419 in dual annealing

@andyfaff, @ilayn, @rgommers
A PR fixing #9419 (and addressing @js850 comments from #9306) with only one commit (rather the 31 ones in the old branch). This is cleaner. Thanks all for your help.

LGTM, merged. Thanks @sgubianpm, all


mesh: A stack overflow in task MEVT has been detected (IDFGH-3508)

Environment

Module or chip used:  ESP32-WROVER-B
IDF version: v4.0.1
Build System: idf.py (cmake - the same)
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0
Operating System: Linux
Using an IDE: No
Power Supply: USB

Problem Description
I setup my mesh as:
    ESP_ERROR_CHECK(esp_mesh_init());
    ESP_ERROR_CHECK(esp_mesh_set_max_layer(CONFIG_MESH_MAX_LAYER));
    ESP_ERROR_CHECK(esp_mesh_set_vote_percentage(1));
    ESP_ERROR_CHECK(esp_mesh_set_ap_assoc_expire(10));

    // I don't want my nodes to connect to the internet on the mesh layer.
    esp_mesh_fix_root(true);

    mesh_cfg_t cfg;
    memset(&cfg, 0, sizeof(cfg));
    cfg.crypto_funcs = &g_wifi_default_mesh_crypto_funcs;
    cfg.channel = CONFIG_MESH_CHANNEL;
    cfg.mesh_ap.max_connection = CONFIG_MESH_AP_CONNECTIONS;

    memcpy((uint8_t*)&cfg.mesh_id, MESH_ID, 6);

    ESP_ERROR_CHECK(esp_mesh_set_config(&cfg));

    ESP_ERROR_CHECK(
        esp_event_handler_register(MESH_EVENT, ESP_EVENT_ANY_ID, &handle_event_, this));

And when I flash and then run the program it is crashed each time with the following:
***ERROR*** A stack overflow in task MEVT has been detected

I guess when I call esp_mesh_start() internal task that is responsible for mesh management service is started. If yes it would be nice to have an option to configure size of this task, otherwise my app will crash each time.
P.S. I was able to temporary avoid crash reported in #5440 by disabling BLE stack (I still need BLE stack in production environment).
cc: @dongdong004, @ESP-iPENCIL
Relates: #5440

There should be no such task named MEVT on IDF version  v4.0.1.

Environment

Module or chip used:  ESP32-WROVER-B
IDF version: v4.0.1
Build System: idf.py (cmake - the same)
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0
Operating System: Linux
Using an IDE: No
Power Supply: USB

Problem Description
I setup my mesh as:
    ESP_ERROR_CHECK(esp_mesh_init());
    ESP_ERROR_CHECK(esp_mesh_set_max_layer(CONFIG_MESH_MAX_LAYER));
    ESP_ERROR_CHECK(esp_mesh_set_vote_percentage(1));
    ESP_ERROR_CHECK(esp_mesh_set_ap_assoc_expire(10));

    // I don't want my nodes to connect to the internet on the mesh layer.
    esp_mesh_fix_root(true);

    mesh_cfg_t cfg;
    memset(&cfg, 0, sizeof(cfg));
    cfg.crypto_funcs = &g_wifi_default_mesh_crypto_funcs;
    cfg.channel = CONFIG_MESH_CHANNEL;
    cfg.mesh_ap.max_connection = CONFIG_MESH_AP_CONNECTIONS;

    memcpy((uint8_t*)&cfg.mesh_id, MESH_ID, 6);

    ESP_ERROR_CHECK(esp_mesh_set_config(&cfg));

    ESP_ERROR_CHECK(
        esp_event_handler_register(MESH_EVENT, ESP_EVENT_ANY_ID, &handle_event_, this));

And when I flash and then run the program it is crashed each time with the following:
***ERROR*** A stack overflow in task MEVT has been detected

I guess when I call esp_mesh_start() internal task that is responsible for mesh management service is started. If yes it would be nice to have an option to configure size of this task, otherwise my app will crash each time.
P.S. I was able to temporary avoid crash reported in #5440 by disabling BLE stack (I still need BLE stack in production environment).
cc: @dongdong004, @ESP-iPENCIL
Relates: #5440

Hi, @dshil
I follow your mesh configuration here, and there is no stack overflow.

Are you willing to provide your sample code, so that you can quickly locate the source of the problem?
Could you provide configuration configuration, maybe it is caused by some settings.
Are you willing to provide the log of the problem, we can use the log to locate the problem.

@dshil Thanks for reporting, would you please help share if any updates for this issue? Thanks.

Hi @Jiangyafeng, and thanks again for coming back to me.
Sorry, my initial report was not clear, let me clarify what is going on.

I follow your mesh configuration here, and there is no stack overflow.

You were right. First, I want to make it clear that I live C++ environment. The code posted above was called in the object constructor. I have the following workflow:
#include <stdio.h>

#include "pipeline.h"
#include "board.h"

extern "C" void app_main() {
    pipeline::Pipeline pipeline;
    app::Board board(pipeline);

    configASSERT(board.start());
    configASSERT(pipeline.start());
}

Pipeline and Board are 2 classes that I can't share but inside then there are tones of components and near about 10 different tasks. You can be sure we use a lot of system resources. Lets move next. In the pipeline class I initialized the class that is responsible for mesh network management. I use almost the same code as from examples (examples/mesh/manual_networking).
The interesting thing is that when I start a mesh it works fine, the problems appear when I handle first event about mesh start using the following code:
    // Since I want to control routing by myself I disable the self-organization mode
    ESP_ERROR_CHECK(esp_mesh_set_self_organized(0, 0));

    mesh_addr_t id = {
        0,
    };
    esp_mesh_get_id(&id);

    ESP_LOGI(TAG, "mesh-network: started: heap=%d mac=" MACSTR "", MAC2STR(id.addr),
             heap_caps_get_minimum_free_size(MALLOC_CAP_INTERNAL));

    ESP_ERROR_CHECK(esp_wifi_scan_stop());

When I call ESP_ERROR_CHECK(esp_wifi_scan_stop()); I got the posted stackoverflow error.

In the current section I will try to provide my step by step debugging process. I tried the following things:

compile and flash the code from examples/mesh/manual_networking on my board - no problem;
trace the stack size of different tasks - no problem;
trace heap usage of different tasks - no problem;
increase stack size of system components as - no result:

CONFIG_LWIP_TCPIP_TASK_STACK_SIZE=4096
CONFIG_ESP_IPC_TASK_STACK_SIZE=4096
CONFIG_ESP_TIMER_TASK_STACK_SIZE=4096
CONFIG_ESP_SYSTEM_EVENT_TASK_STACK_SIZE=4096

After all this debugging stuff I had zero idea what is the problem and one day I tried to check the logging process (I don't know why I god this idea). We replace the standard logger with our own, since we need some pre and post processioning. When I disable custom logger we won't have any stackoverflow issue. I tried to print the remaining stack size of the task that log something and got the following result:
esp-idf: I (1749) mesh: <SYSTEM_EVENT_SCAN_DONE>status:fail, num:0, id:129
bytes remain: 796

esp-idf: I (6439) mesh: 3367<scan>self-organized is disabled, users shall read out scan results by themselves.
bytes remain: 1772

I use the following code:
int log_handler(const char* format, va_list args) {
    configASSERT(format);

    // In release build most of the time Info level is enabled, thus to ensure
    // won't miss any ESP-IDF specific log that does not contain level prefix,
    // LogInfo is used by default.
    LogLevel level = LogInfo;

    switch (format[0]) {
    case 'E':
        level = LogError;
        break;
    case 'I':
        level = LogInfo;
        break;
    case 'W':
        level = LogWarn;
        break;
    case 'D':
        level = LogDebug;
        break;
    case 'V':
        level = LogTrace;
        break;
    default:
        break;
    }

    if (level > core::Logger::instance().level()) {
        return 1;
    }

    char message[core::Logger::EntrySize] = {};
    vsnprintf(message, sizeof(message) - 1, format, args);

    fprintf(stdout, "esp-idf: %s: %d\n", message, uxTaskGetStackHighWaterMark(nullptr));

    return 0;
}

When I replace
    fprintf(stdout, "esp-idf: %s: %d\n", message, uxTaskGetStackHighWaterMark(nullptr));

with my own:
    my_log(level, "esp-idf: %s", message);

I got the stack overflow.

As you can see after we receive SYSTEM_EVENT_SCAN_DONE there is a few bytes remaining in stack. I think it would be viable if you can provide an option to set the size of mesh event stack size to be able to avoid such problems.
P.S. sorry for a long response, was experimenting a lot with this issue.
cc: @Alvin1Zhang

Hello everyone, @Alvin1Zhang  @Jiangyafeng would you plan to take a look into this issue? If not I will close the issue.

First of all, if your API is incorrect, change
ESP_LOGI(TAG, "mesh-network: started: heap=%d mac=" MACSTR "", MAC2STR(id.addr), heap_caps_get_minimum_free_size(MALLOC_CAP_INTERNAL));
to
ESP_LOGI(TAG, "mesh-network: started: heap=%d mac=" MACSTR "", heap_caps_get_minimum_free_size(MALLOC_CAP_INTERNAL), MAC2STR(id.addr));
Can you print the task-list regularly and check the task memory.
For memory problems, you can take the following measures:

You can enable "run freertos only on first core" under component config/freertos in menuconfig, which will change dual-core to single-core use;
You can enable "Enable'nano' formatting options for prinrf/scanf family" under component config/Newlib in menuconfig.

@dshil

I added your code in the MESH_EVENT_STARTED event. Your stack overflow does not appear, and you are not sure of your specific reasons, so I suggest you use the above methods to debug first to see if the problem can be solved.

@dshil Thanks for reporting, and sorry for slow turnaround. Would you please help share if any updates for the issue? Thanks.

Hello everyone, sorry for a delay, was quite busy.
@Jiangyafeng,

First of all, if your API is incorrect, change

Thanks, it was a typo.

I added your code in the MESH_EVENT_STARTED event. Your stack overflow does not appear

Let's simplify the reproducing process by using the following:

Use example/mesh/internal_communication from the latest master
Add simple custom logger:

int log_handler(const char* format, va_list args)
{
    char message[512] = {};

    if (vsnprintf(message, sizeof(message) - 1, format, args) < 0) {
        message[0] = '\0';
    }

    fprintf(stdout, "stack=%u msg=%s\n", uxTaskGetStackHighWaterMark(NULL), message);

    return 0;
}

Set this logger at the beginning of app_main as:

void app_main(void)
{
    esp_log_set_vprintf(log_handler);
    // other code
}

Compile and flush the example, you should see something similar to:

stack=336 msg=I (12885) mesh_main: <MESH_EVENT_PARENT_CONNECTED>layer:0-->1, parent:e0:3f:49:d3:2c:30<ROOT>, ID:77:77:77:77:77:77, duty:0

stack=336 msg=I (13705) mesh_main: <IP_EVENT_STA_GOT_IP>IP:<IP_ADDRESS>

stack=684 msg=W (730045) mesh_main: [#RX:718/718][L:1] parent:e0:3f:49:d3:2c:30, receive from 24:6f:28:f0:10:80, size:1460, heap:169476, flag:0[err:0x0, proto:0, tos:0]

As you might see there is a little amount of stack left. Since custom logger provided above is very short and does not consume a lot of stack we won't run out of stack but in real application where custom logger can be more complicated the stack overflow issue can easily happen  (as happened in our application).

@dshil
Thank you for your feedback,

First of all, the small stack that appears in the instance is determined by the size of the memory allocated by the corresponding running task. If you want to increase it, you can increase the corresponding running task memory. I use the method of increasing the size in the example, as follows:
E.g:

        xTaskCreate(esp_mesh_p2p_rx_main, "MPRX", 3072, NULL, 5, NULL);

change:
        xTaskCreate(esp_mesh_p2p_rx_main, "MPRX", 4096, NULL, 5, NULL);

you can see:
stack=340 msg=I (13743) esp_netif_handlers: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>

stack=340 msg=I (13743) mesh_main: <IP_EVENT_STA_GOT_IP>IP: <IP_ADDRESS>

stack=1704 msg=W (13983) mesh_main: [#RX:2/2][L:1] parent:20:a6:80:98:dc:b4, receive from 98:f4:ab:76:32: c4, size:1460, heap:157196, flag:0[err:0x0, proto:0, tos:0]

stack=1704 msg=W (14983) mesh_main: [#RX:3/3][L:1] parent:20:a6:80:98:dc:b4, receive from 98:f4:ab:76:32: c4, size:1460, heap:157140, flag:0[err:0x0, proto:0, tos:0]

If there is not enough memory in the application, you can also use the following method to save some memory.

You can enable "run freertos only on first core" under component config/freertos in menuconfig, which will change dual-core to single-core use;
You can enable "Enable'nano' formatting options for prinrf/scanf family" under component config/Newlib in menuconfig.

Thanks for reporting, will close due to short of feedback, feel free to reopen with more updates. Thanks.


Python: memberOf function

This change adds a function to the Python library that corresponds to the memberOf FHIRPath function.
This would allow Python users to add a column to a Spark dataframe that represents the membership of a coded column within a nominated FHIR ValueSet.
This is the intended method documentation, this would be an instance method on PathlingContext:
memberOf(df: DataFrame, codingColumn: Column, valueSetUrl: str, outputColumnName: str) → DataFrame

Takes a dataframe with a Coding column as input. A new column is created which contains a Boolean value, indicating whether the input Coding is a member of the specified FHIR ValueSet.
Parameters
df - a DataFrame containing the input data
codingColumn - a Column containing a struct representation of a Coding
valueSetUrl - an identifier for a FHIR ValueSet
outputColumnName - the name of the result column
Returns
A new dataframe with an additional column containing the result of the operation.

We have a prototype implementation of this on the spike/tlg_python branch.


Bad layout on high dpi at certain browser width

This feedback was received from the Zurich JavaScript team at a training event recently hosted. While users were reading the ArcGIS API for JavaScript and the browser zoom (Ctrl/Cmd + 1) is activated on high dpi displays, the layout is bad around the breakpoint. Both navigation tabs and dropdown are visible, and the content is below the sidebar. I am not sure what browser or version was used.
devicePixelRatio: 1.25
window.innerwidth: 1023

I just looked into this and fixing will be extremely difficult. Essentially the problem is that in media queries, once you are zoomed in, the browser handles the math differently. We use max-width: $breakpoint - 1 for some of our media queries and when zoomed in, there is a small number of pixels that actually fall inside that pixel because the 1px is now larger due to being zoomed in. To fix this we would need to do one of several things:

use level 4 media queries (width < $breakpoint). This is impossible in Sass currently and has poor support
Change all of our breakpoints to use ems/rems. This would be a huge breaking change, and could have bugs with people who are resetting the html font size for smaller type
Change how the responsive show hide classes are implemented. I looked into this and because there is no way in css to reset from display: none to the browser default, this will most likely break a lot of people's code.

None of these are appealing to me. This is a pretty small edge case (zoomed in and screen width is exactly X pixels wide), so I think this should be tabled until Sass and Browsers implement level 4 media queries, at which point we can address it.
For what it's worth, bootstrap also had this issue and they decided to not fix: https://github.com/twbs/bootstrap/issues/19197

@paulcpederson thanks for looking into this. I see that this is hard to fix properly.

This is a pretty small edge case (zoomed in and screen width is exactly X pixels wide)

The reason I'm running into this regularly, is that the critical pixel width happens to be exactly half the width of my screen, and I often dock the browser with the windows key + arrow keys.
Would it be possible to move the breakpoint by a few pixels to make this edge case less likely to be hit in practice?
My setup (everything pretty common I think):

OS: windows
Browser: chrome
Screen resolution: 2560x1440
Zoom: 125%

@sreinhard why do you zoom in?

@sreinhard @lheberlie can you two try this out again. There was a slight tweak to the columns, so I'm wondering if that helped at all.

@paulcpederson how would I test this? I can still reproduce the issue on https://jscore.esri.com/javascript/latest
The reason I zoom in, is that text is easier to read on my monitor. Note that this is a global Windows setting, which the browser picks up. The zoom level in my browser is 100%.

@sreinhard visit the Calcite Web docs (http://esri.github.io/calcite-web/documentation/) with the configuration that's problematic and see if that breakpoint hits at the exactly wrong place for you still

@paulcpederson on this page the half screen layout is ok. the bad layout happens at around 859 pixels now, which is very hard to hit manually for me.

OK, I think we can close this as a known issue. Once level-4 media queries are widely supported and Sass allows their syntax we can reopen and improve.


Migrate 1.13.7 to 1.14.1 failed - Error 1071: Specified key was too long; max key length is 767 bytes

Gitea version (or commit ref): 1.13.7 -> 1.14.1
Git version: 2.17.1
Operating system: Ubuntu 18.04 with amd64 binary from dl.gitea.io

Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Log gist:

./gitea --config /home/gitea/gitea/custom/conf/app.ini migrate
2021/04/19 11:36:28 ...dules/setting/git.go:101:newGit() [I] Git Version: 2.17.1
2021/04/19 11:36:28 cmd/migrate.go:31:runMigrate() [T] AppPath: /home/gitea/gitea/gitea
2021/04/19 11:36:28 cmd/migrate.go:32:runMigrate() [T] AppWorkPath: /home/gitea/gitea
2021/04/19 11:36:28 cmd/migrate.go:33:runMigrate() [T] Custom path: /home/gitea/gitea/custom
2021/04/19 11:36:28 cmd/migrate.go:34:runMigrate() [T] Log path: /home/gitea/gitea/log
2021/04/19 11:36:28 ...om/urfave/cli/app.go:277:Run() [I] PING DATABASE mysql
2021/04/19 11:36:28 ...ations/migrations.go:357:Migrate() [I] [SQL] SELECT `TABLE_NAME` from `INFORMATION_SCHEMA`.`TABLES` WHERE `TABLE_SCHEMA`=? and `TABLE_NAME`=? [gitea version] - 2.959856ms
2021/04/19 11:36:28 models/models.go:220:NewEngine() [I] [SQL] SELECT `COLUMN_NAME` FROM `INFORMATION_SCHEMA`.`COLUMNS` WHERE `TABLE_SCHEMA` = ? AND `TABLE_NAME` = ? AND `COLUMN_NAME` = ? [gitea version id] - 3.08131ms
2021/04/19 11:36:28 models/models.go:220:NewEngine() [I] [SQL] SELECT `COLUMN_NAME` FROM `INFORMATION_SCHEMA`.`COLUMNS` WHERE `TABLE_SCHEMA` = ? AND `TABLE_NAME` = ? AND `COLUMN_NAME` = ? [gitea version version] - 1.48779ms
2021/04/19 11:36:28 ...rm.io/xorm/engine.go:1130:Get() [I] [SQL] SELECT `id`, `version` FROM `version` WHERE `id`=? LIMIT 1 [1] - 818.839µs
2021/04/19 11:36:28 ...ations/migrations.go:394:Migrate() [I] Migration[159]: update reactions constraint
2021/04/19 11:36:28 models/models.go:220:NewEngine() [I] [SQL] BEGIN TRANSACTION [] - 417.804µs
2021/04/19 11:36:28 ...s/migrations/v159.go:33:updateReactionConstraint() [I] [SQL] CREATE TABLE IF NOT EXISTS `tmp_recreate__reaction` (`id` BIGINT(20) PRIMARY KEY AUTO_INCREMENT NOT NULL, `type` VARCHAR(255) NOT NULL, `issue_id` BIGINT(20) NOT NULL, `comment_id` BIGINT(20) NULL, `user_id` BIGINT(20) NOT NULL, `original_author_id` BIGINT(20) DEFAULT 0 NOT NULL, `original_author` VARCHAR(255) NULL, `created_unix` BIGINT(20) NULL) DEFAULT CHARSET utf8mb4 ROW_FORMAT=DYNAMIC [] - 688.16µs
2021/04/19 11:36:28 ...s/migrations/v159.go:33:updateReactionConstraint() [I] [SQL] CREATE UNIQUE INDEX `UQE_tmp_recreate__reaction_s` ON `tmp_recreate__reaction` (`type`,`issue_id`,`comment_id`,`user_id`,`original_author_id`,`original_author`) [] - 767.418µs
2021/04/19 11:36:28 ...ations/migrations.go:447:recreateTable() [E] Unable to create uniques for table tmp_recreate__reaction. Error: Error 1071: Specified key was too long; max key length is 767 bytes
2021/04/19 11:36:28 ...ations/migrations.go:397:Migrate() [I] [SQL] ROLLBACK [] - 280.417µs
2021/04/19 11:36:28 cmd/migrate.go:38:runMigrate() [F] Failed to initialize ORM engine: migrate: do migrate: Error 1071: Specified key was too long; max key length is 767 bytes

My current database version is now 159.

I have encountered the same issue when tried to migrate to the latest release.
Upgrade was done from 1.13.7 to 1.14.1. MariaDB version:
mysql  Ver 15.1 Distrib 10.5.9-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

The issue is that MySQL 5 has a rather short indexed varchar limit on utf8mb4 of 191 bytes. Later versions of MySQL/MariaDB do not suffer this.
Googling appears to indicate:
SET GLOBAL innodb_file_format=Barracuda;
SET GLOBAL innodb_file_per_table=1;
SET GLOBAL innodb_large_prefix=1;

May help.
Xorm likely needs to detect these versions of MySQL and set its default string size to 191 in order to avoid this.

@zeripath Thank you for your help. After changing these variables migration to 1.14.1 was successful.


[WIP] Cython spiceypy prototype

Prototype of Cython based interface to CSPICE. Links to the existing CSPICE shared library so is able to work along side the existing spiceypy interface allowing gradual development of features. Current focus will be to provide faster vectorized functions first and then consider what makes sense to cythonize from that point.
This is very much a work in process, as I am still learning cython best practices, and changes to python packaging may be outpacing cython's development and documentation.
Current speedups are modest for vectorized functions, about 1.5-1.7 times faster than pure python versions. This may be due to unavoidable overhead in certain portions such as dealing with strings.
This PR will probably be open for a while until enough of the issues around cross platform compilation, docstrings, and cython usage improvements are made.
suggestions are welcome!

Hey @alfonsoSR thanks for your interest and I appreciate the feedback. As this will be a long PR, I think it's best to just comment on the code inline in the PR with suggested changes for now. If I do merge it I don't plan to expand it much beyond the current functionality, so prs will be acceptable then to expand the number of supported functions. Currently really need to solve the packaging issues and ensuring I am writing the most performant reasonable code.
As for the various items you mentioned

I could not reproduce the missing header issue on my system, on macos the header files are present and in the correct folder. Maybe post the details about your system (os version, cpu architecture, etc)? But in any case the cythonized extension wasn't able to work with the pxd file in an early attempt. I should try again now that more of the compilation side is working.
I am aware of the unicode string conversion for python 3 in cython, earlier versions of the branch used that directive. However, cspice itself does not support unicode, so I elect for the moment to use bytes that cspice expects. I don't think either way it's a big issue yet and something I can change back to once I'm happier with the overal code
I wasn't aiming to implement the single-function call versions just yet, I do think it's something to add eventually but I'd organize it differently than you have them to define the private functions first and then declare the single call. I am also curious to see how the cython complier is able to optimize these functions vs just providing the single call and vectorized call individually without the wrapper.
I really am not a fan of the pytest parameterize syntax in general as a stylistic choice. I think you were missing the pytest-benchmark dependency also, but thats just an opinion really and not consequential to making progress here yet. The benchmark part is something I want to keep for the moment to help demonstrate the value of the changes but will probably be moved to an external test script later.

For now I think keep commenting on my code as I develop it, I should be able to add credit to you if/when this gets merged to recognize your contributions. Currently there are still many issues with the compilation side and changes introduced by recent peps for pyproject.toml and using pypa build.
One question you could answer for me though is that I saw usage like this in your branch:
    cdef cnp.ndarray[dtype=cnp.double_t, ndim=2] ptarg_v = np.zeros((n, 3))
    cdef double[:, ::1] _ptarg_v = ptarg_v

when from what I understand about memoryviews in cython this should be equivalent:
    cdef double[:,:] ptargs = np.zeros((n,3), dtype=np.double)

as I've already cimport-ed numpy

Hi @AndrewAnnex, thanks for the answer!
I agree with what you say about inline comments. I created a new branch because I wanted to understand how the installation scripts work and to test my ideas before making any suggestions. Now that I am up-to-date with what you've done, I'll follow your commits and add comments with suggestions.
Regarding the rest of your comments:
Header files
I am working with Python 3.11 and macOS Ventura 13.3.1 on a 2020 MacBook Pro with Intel processor, so Darwin system with x86_64 architecture.
The issue with missing headers does not affect your branch nor mine, so I am not sure about how did you try to reproduce it. Just to be sure, you can reproduce the issue as follows:

In my branch, replace the _unpack() method of the GetCSPICE class with its original version --which I include here.

    def _unpack(self):
        """Unpacks the CSPICE package on the given root directory. Note that
        Package could either be the zipfile.ZipFile class for Windows platforms
        or tarfile.TarFile for other platforms.
        """

        if self._ext == "zip":
            with ZipFile(self._local, "r") as archive:
                archive.extractall(self._root)
        else:
			cmd = (
				f"gunzip | tar {'xfC -' if host_OS == 'FreeBSD' else 'xC'}"
				f" {self._root}"
			)
			proc = subprocess.Popen(cmd, shell=True, stdin=subprocess.PIPE)
			proc.stdin.write(self._local.read())
		self._local.close()

Delete the src/spiceypy/cspice directory if it exists and execute the get_spice.py script, which should not give any problems.
Now execute python setup.py build_ext -if to compile cyice.pyx. You should get a fatal error because the header file SpiceFrm.h is missing from src/spiceypy/cspice/include.

PXD file
I first tried to just copy-paste the declarations of the original cyice.pyx script to cyice.pxd and the program did not work. I then decided to rewrite the functions one by one and to add the declarations to a fresh .pxd file as they were required. I did not face any issues during the process.
Memory view
You are right about the fact that you can directly assign the NumPy array to the memview, but since you want to return ptargs, you will need to use np.asarray to turn it into a NumPy array.
From my personal experience, binding the memview to the buffer of a pre-existing array is more efficient than using np.asarray, which can become pretty slow as the size of the array increases.
On a different note, just in case you don't know it, by using cdef double[:, ::1] instead of cdef double[:, :], you are specifying that the memview is C-contiguous. From O'Reilly's book: Cython, a guide for Python programmers,

When possible, it is advantageous from a performance standpoint to declare arrays as C or Fortran contiguous, as this enables Cython to generate faster code that does not have to take strided access into account.

Since NumPy arrays are C-contiguous by default, declaring multi-dimensional memviews as C-contiguous can make the code more efficient.
Rest
I wasn't aware that cspice does not support unicode. I didn't have any issues by directly passing Python strings to cspice functions, but I agree that it is not particularly important.
The rest of the things you mention are a matter of style and the code is yours, so I've got nothing to say about that :).

@alfonsoSR okay so the missing header files are because you are not specifying an environment variable check I added to get_spice.py. Try setting "export CSPICE_NO_TEMP='True'" in the terminal first and you should see it build fine. This is because by default get_spice creates a temporary directory to build cspice and in order for it to work correctly currently, as you noticed, you need to have a src/cspice directory for cython/build_ext to have the headers in the correct directory.
Most cython projects assume for the most part that the library source in included in the python project or available system-wide so get_spice does a lot of work to make a temporary directory to do the compilation.


Temporary workaround (until parser is refactored) for fixing evaluation of simple 'identifier'-like expressions

LGTM.

LGTM

make push


Allow json-style value for siteConfig.appSettings in Microsoft.Web/Site

Is your feature request related to a problem? Please describe.
I think is a bit too verbose the way we currently need to define appSettings inside siteConfig in a Microsoft.Web/Site, being an array of objects with name and value. It is more tedious when the app we are deploying has an appSettings with nested objects for better settings organization. A classic example is the initial settings added for a web app:
{
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Microsoft": "Warning",
      "Microsoft.Hosting.Lifetime": "Information"
    }
  },
  "AllowedHosts": "*"
}

to have this logging settings declared in bicep we need to have the following:
resource myWebApi 'Microsoft.Web/sites@2020-06-01' = {
    name: 'api'
    properties: {
        siteConfig: {
            appSettings: [
                {
                    name: 'Logging:LogLevel:Default'
                    value: logLevelParam
                }
                {
                    name: 'Logging:LogLevel:Microsoft'
                    value: 'Warning'
                }
                {
                    name: 'Logging:LogLevel:Microsoft.Hosting.Lifetime'
                    value: 'Information'
                }
            ]
        }
    }
}

Describe the solution you'd like
I would like that appSettings supports json-style declaration of the settings json as follow:
resource myWebApi 'Microsoft.Web/sites@2020-06-01' = {
    name: 'api'
    properties: {
        siteConfig: {
            appSettings: {
                'Logging': {
                    'LogLevel': {
                        'Default": logLevelParam
                        'Microsoft": 'Warning'
                        'Microsoft.Hosting.Lifetime': 'Information'
                    }
                }
            }
        }
    }
}

We will share this feedback with the app services team, but this is not in itself a bicep issue. This is an issue with the web/site API itself.
Going to close this, but feel free to open an item in their UserVoice.
cc @jeffhollan as FYI

Thanks @alex-frankel for the quick response, you are totally right 👍


Upstream the errors properly

Hi, congrats on the project.
I'm having a hard time trying to get errors from the driver, please take a look:
https://github.com/denodrivers/mongo/blob/d5445a476308a6ded290ded326654aa4c92e5e76/src/collection/collection.ts#L191
Could we replace that by the following:
 const [error] = writeErrors;

There's no reason to not upstream the entire error. I tested it by changing the cache file.
Before:
MongoError: "Document failed validation"
    at Collection.insertMany (https://deno.land/x/mongo@v0.31.0/src/collection/collection.ts:192:13)
    at async Collection.insertOne (https://deno.land/x/mongo@v0.31.0/src/collection/collection.ts:149:29)
    at async createCampaign (file:///home/jamal/Desktop/side-projects/satiro.co/core/services/create-campaign.service.ts:10:17)
    at async Server.<anonymous> (file:///home/jamal/Desktop/side-projects/satiro.co/functions/create-campaign.function.ts:20:24)
    at async Server.#respond (https://deno.land/std@0.140.0/http/server.ts:298:18)

Now:
Error: MongoError: {"index":0,"code":121,"errInfo":{"failingDocumentId":"62ef419eb11a449f45637eed","details":{"operatorName":"$jsonSchema","schemaRulesNotSatisfied":[{"operatorName":"required","specifiedAs":{"required":["id","influencer","product","status","expiredAt","affiliateLink"]},"missingProperties":["id"]}]}},"errmsg":"Document failed validation"}
    at Collection.insertMany (https://deno.land/x/mongo@v0.31.0/src/collection/collection.ts:192:13)
    at async Collection.insertOne (https://deno.land/x/mongo@v0.31.0/src/collection/collection.ts:149:29)
    at async createCampaign (file:///home/jamal/Desktop/side-projects/satiro.co/core/services/create-campaign.service.ts:10:17)
    at async Server.<anonymous> (file:///home/jamal/Desktop/side-projects/satiro.co/functions/create-campaign.function.ts:20:24)
    at async Server.#respond (https://deno.land/std@0.140.0/http/server.ts:298:18)

With that, I can parse the errors and give some hints to solve the problem when the user is trying to save the document with the wrong schema or handle errors accordingly with its error code.
Update:
We also need to add the errInfo to the class just like the nodejs driver: https://github.com/mongodb/node-mongodb-native/blob/417655ac9d87c1c9ca255dfcc81ca828ffde731a/src/error.ts#L171

we could also wrap the extra details in a cause error

Hi, first of thank you for the library. Makes life easier working with the mongo on Deno. I am working on the app, which requires the collection validationSchema. As per the new Mongo DB update, the details of this error are sent through the errorInfo field, which is very helpful. can you please help with entire details. Thank you !
{
   "code": 121,
   "errmsg": "Document failed validation",
   "errInfo": {
       "failingDocumentId": ObjectId("5fe0eb9642c10f01eeca66a9"),
       "details": {
           "operatorName": "$jsonSchema",
           "schemaRulesNotSatisfied": [
               {
                   "operatorName": "properties",
                   "propertiesNotSatisfied": [
                       {
                           "propertyName": "price",
                           "details": [
                               {
                                   "operatorName": "minimum",
                                   "specifiedAs": {
                                       "minimum": 0
                                   },
                                   "reason": "comparison failed",
                                   "consideredValue": -2
                               }
                           ]
                       }
                   ]
               }
           ]
       }
   }
}


localization number format and date format

localization for number format and date format is missing. Can we expect a implementation in future?

@mahidhar25 Number and date format sanitization is possible using an extension package @rxweb/ngx-translate-extension. Have a look at the documentation of santizers. For getting started with package refer Extensible Guide


New Version of App Implemented

New version of the application (/10)
The implementation should have been started.  It is recommended to begin with the UI and some classes such as sign-up, login, etc. The developers should lead this and are expected to, as needed, review/complete parts of the Interactive React Textbook earlier than other team members, do self-directed learning using Google, StackOverflow, other online resources, and ask people or other classmates questions.
If there is no code/HTML/scripts, and no changes from last time, this part will be graded as 0.
As a reminder, review the class policies about copyright and AI use. You can even use code from prior projects to help start your project.
Setting up the build environments and the necessary dependencies.
If there is nothing, deduct -5 points.
Your README file should detail the installation and build process for your application. Make sure it works on each person’s machine.
If there is nothing, deduct -5 points.

The build works, README is updated as necessary


SqlSmith: Fix operators with NumericOutOfRange

SELECT (SMALLINT '22' << SMALLINT '34') / 21.81402348310204 AS col_0, REAL '18.92711622257903' AS col_1;

thread 'main' panicked at 'Failed to execute query: db error: ERROR: RPC error: Status { code: Internal, message: "Expr error: NumericOutOfRange", metadata: MetadataMap { headers: {"risingwave-error-bin": "CBwSHUV4cHIgZXJyb3I6IE51bWVyaWNPdXRPZlJhbmdl"} }, source: None }

I think the right way to handle this is to permit NumericErrors. Since these are runtime errors from valid queries.

The alternative is to be conservative about the types of expressions we generate.
For instance when generating lshift / rshift / div, we constraint the left and right exprs to set of valid expressions.
In the above case, it means only literals, or compound expressions of literals. Additionally these should have valid bounds (e.g. right expr of div is non-zero).
We can't have column exprs, since these can still fail during runtime.

Note that the erroring behaviour here diverges from postgres, this is intentional: https://github.com/singularity-data/risingwave/blob/b4eb1107bc16f8d583563f776f748632ddcaa0cb/src/expr/src/vector_op/bitwise_op.rs#L24.
We see similar behaviours for other arithmetic expressions e.g. division by zero.

Resolved by #3929


MGMT-11217-fix the issue with skopeo crypto engine

Signed-off-by: Alberto Morgante Medina<EMAIL_ADDRESS>Description
using our current command:
skopeo copy --remove-signatures docker://${package} docker://${DESTINATION_REGISTRY}/${OLM_DESTINATION_REGISTRY_IMAGE_NS}/$(echo $package | awk -F'/' '{print $2}')-$(basename $package) --all --authfile ${PULL_SECRET}
we sometimes get the next error with skopeo and cryptoengine:
./olm-sync.sh: line 180:  6025 Aborted                 (core dumped) skopeo copy --remove-signatures docker://${package} docker://${DESTINATION_REGISTRY}/${OLM_DESTINATION_REGISTRY_IMAGE_NS}/$(echo $package | awk -F'/' '{print $2}')-$(basename $package) --all --authfile ${PULL_SECRET}
[deploy-disconnected-registry : mirror-olm] INFO: Failed Image Copy, retrying after 5 seconds...
[deploy-disconnected-registry : mirror-olm] Copying 4 of 4 images in list
[deploy-disconnected-registry : mirror-olm] Copying image sha256:91a091df86a8e78200dfdd9f22074eff625877ede1a25758e5cfda744d23c97f (1/4)
[deploy-disconnected-registry : mirror-olm] time="2022-07-19T11:24:37Z" level=fatal msg="Source image rejected: None of the signatures were accepted, reasons: Invalid crypto engine; Invalid crypto engine; Invalid crypto engine; Invalid crypto engine; Invalid crypto engine; Invalid crypto engine"
[deploy-disconnected-registry : mirror-olm] INFO: Failed Image Copy, retrying after 5 seconds...
[deploy-disconnected-registry : mirror-olm] Copying 4 of 4 images in list
[deploy-disconnected-registry : mirror-olm] Copying image sha256:91a091df86a8e78200dfdd9f22074eff625877ede1a25758e5cfda744d23c97f (1/4)
[deploy-disconnected-registry : mirror-olm] time="2022-07-19T11:24:49Z" level=fatal msg="Source image rejected: None of the signatures were accepted, reasons: Invalid crypto engine; Invalid crypto engine; Invalid crypto engine; Invalid crypto engine; Invalid crypto engine; Invalid crypto engine"

This PR enables the use of a flag in the skopeo commands to retry internally and get more time between our retry policy
Fixes # MGMT-11217
Type of change
Please select the appropriate options:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change is a documentation update

Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Tested on SNO:  https://github.com/rh-ecosystem-edge/ztp-pipeline-relocatable/runs/7454521589?check_suite_focus=true
[ ] Test B

Test Configuration:

Versions:
Hardware:

Checklist

[ ] I have performed a self-review of my own code
[ ] If a change is adding a feature, it should require a change to the README.md and the review should catch this.
[ ] If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
[ ] A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
[ ] PRs should not be merged unless positively reviewed.

Close this pull request...not working as expected so no improvements to current code


Ensure Ergo gets compiled when loading template from archive

Ergo logic doesn't get compiled properly when loading a template from archive (rather than from disk).

Fixed on contract branch. See bbb195826f5543d3f7112ebf885e4d3235e4c793 and 3c58dd84a1920b5e054924b5688aaa8f26ecd355.


trousers: 0.3.14 -> 0.3.15

Motivation for this change
Fix CVE-2020-24332, CVE-2020-24330 and CVE-2020-24331.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

3 packages marked as broken and skipped:

chaps
gnutls-kdh
tlspool

10 packages built:

opencryptoki
pond
simpleTpmPk11
strongswanTNC
tboot
tpm-luks
tpm-quote-tools
tpm-tools
tpmmanager
trousers

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110897 run on x86_64-linux 1

3 packages marked as broken and skipped:

chaps
gnutls-kdh
tlspool

10 packages built:

opencryptoki
pond
simpleTpmPk11
strongswanTNC
tboot
tpm-luks
tpm-quote-tools
tpm-tools
tpmmanager
trousers

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110897 run on x86_64-linux 1

3 packages marked as broken and skipped:

chaps
gnutls-kdh
tlspool

10 packages built:

opencryptoki
pond
simpleTpmPk11
strongswanTNC
tboot
tpm-luks
tpm-quote-tools
tpm-tools
tpmmanager
trousers


Invalid model generated

Problem statement
Invalid code is generated when the swagger spec below is run through go-swagger to generate a client.
The following code is generated which fails to compile:
func (m *Pets) validateCrazyPets(formats strfmt.Registry) error {

	if err := validate.Required("CrazyPets", "body", m.CrazyPets); err != nil {
		return err
	}

	for k := range m.CrazyPets {

	}

	return nil
}

Swagger specification
swagger: '2.0'
info:
  version: v1
  title: Model bug
  description: Swagger definition showing bug in go-swagger model generation
basePath: /SomeBasePath
schemes:
  - http
paths:
  /api/pets:
    get:
      tags:
        - Pets
      summary: Get all pets
      consumes:
        - application/json
      produces:
        - application/json
      responses:
        '200':
          description: Provides the pets in some crazy data structure.
          schema:
            $ref: '#/definitions/Pets'
definitions:
  Pets:
    description: Some crazy pets data structure.
    required:
      - CrazyPets
    type: object
    properties:
      CrazyPets:
        description: Crazy pets
        type: object
        additionalProperties:
          type: object
          additionalProperties:
            type: array
            items:
              type: string

Steps to reproduce

Run go-swagger with following command: swagger generate client
Try to build code to get compilation error in models\pets.go.
./pets.go:45:6: k declared and not used

Environment
swagger version: version: 0.14.0 commit: 25e637c5028dee7baf8cdf5d172ccb28cb8e5c3e
go version: go1.10.1 linux/amd64
OS:  Linux

Can you reproduce this with current master?

Your spec generates and builds properly in 0.15.

After a bit of digging I guess it might have been fixed in PR #1521...


cmd/go: tries to resolve github.com as a module

What version of Go are you using (go version)?

$ go version
go version devel +c4ca60313e Sun Jul 28 18:09:57 2019 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/tmp/tmp.4LfxYnl2lH"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/tmp/tmp.Byzg7Tw4cq/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build167955296=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Simply reproduced via the following (with a clean GOPATH):
$ go get<EMAIL_ADDRESS>go: finding github.com/myitcv/gobin v0.1.11
go: finding github.com/myitcv/gobin v0.1.11
go: finding github.com v0.1.11
go: finding github.com/myitcv v0.1.11
go get<EMAIL_ADDRESS><EMAIL_ADDRESS>invalid version: unknown revision v0.1.11

v0.1.11 does not exist; that's expected.
What did you expect to see?
No attempt to resolve github.com or github.com/myitcv
What did you see instead?
As above.
cc @bcmills @jayconrod

Is the issue that we're trying to resolve github.com and github.com/myitcv specifically? It would be reasonable to add a special case for github.com, since we know any module will have at least two path components after the domain there. However, I don't think we have any special cases here, and I'd be hesitant to start adding them. It would be nice to keep the proxy protocol very simple.
Or is the issue that, having discovered github.com/myitcv/gobin is a module (without v0.1.11), we stop searching for other modules with prefixes of that path? This part may be working as intended. Anecdotally, I've heard of packages moved from a root module to a nested module (I think this was in github.com/hashicorp/vault). There are overlapping versions across those modules, and it would not be safe to stop the search early.

Note that avoiding those particular paths is just an optimization, and the requests are made in parallel so the optimization would have relatively little effect on overall latency.
(To my knowledge, there is nothing currently stopping GitHub from using <meta name="go-import" […]> tags to publish their own module at the root of github.com, or to allow users to publish their own modules at github.com/$USER.)

There is an interesting implication for program encapsulation, in that a top-level github.com module could potentially provide packages that allow access to the internal paths of other modules hosted on github.com.
However, the presence of such a module would be relatively easy to detect: if it can be fetched through proxy.golang.org then it will be recorded in the public index (at index.golang.org), and if it cannot be fetched through proxy.golang.org then it will also not be recorded in the checksum database (and go1.13 will error out at that step).
(Besides, projects hosted on github.com are already trusting GitHub to serve unadulterated contents for their modules. Trusting GitHub not to serve a malicious top-level module doesn't seem like much of a stretch.)

Ah, it could be my misunderstanding. I thought I remembered cmd/go stopping at github.com/X/Y and not going any higher... hence why I raised the issue. But my memory might well be failing me!

@myitcv I believe this is the recent change in go1.13. For users like me who don't know the underlying go command implementation the message "go: finding github.com v0.1.11" will be quite surprising. Shouldn't the message be hidden by default?

@hyangah, that's more the purview of #26152. (See https://github.com/golang/go/issues/26152#issuecomment-516468145 for my current thoughts on that.)

Since as far as we're aware the impact on overall latency is negligible, we don't plan to change this — I don't think it would even be worth the code complexity as a contributed change. Closing.


Move FIRInstanceIDInstanceProvider into the private header file for components to look up an instance of FIRInstanceID

Move FIRInstanceIDInstanceProvider into the private header file for components to look up an instance of FIRInstanceID. This is needed when a components loads with componentsToRegister and depends on instanceID when initializing.

This change is no longer needed with a fix Core initialization (https://github.com/firebase/firebase-ios-sdk/pull/4030)


[fix][cms] "500" error on event/agents/nodes/page

Coverage decreased (-3.9%) to 80.616% when pulling 998ca35e51500dbe27be00c55696fe773f844431 on fix-500-error-on-event-page into a601bd57bdda1a81e54e0dd2c46d9b9addbbfdae on master.


X-Forwarded-* headers are not passed

I've installed a simple httpbin (https://github.com/postmanlabs/httpbin) service to check if X-Forwarded-Proto header is passed from ALB. According to this documentation https://docs.aws.amazon.com/elasticloadbalancing/latest/userguide/how-elastic-load-balancing-works.html#request-routing it must be supported.
However it doesn't return them:
$ curl -H "Host: test.staging.example.com" https://db863288-default-httpbin-34b6-1237199957.eu-west-1.elb.amazonaws.com/headers
{
  "headers": {
    "Accept": "*/*",
    "Content-Length": "0",
    "Host": "test.staging.example.com",
    "User-Agent": "curl/7.70.0",
    "X-Amzn-Trace-Id": "Root=1-5ef53771-9cc00b44b9570f4082ba5c39",
    "X-B3-Sampled": "0",
    "X-B3-Spanid": "3fad25f5e1ed70e1",
    "X-B3-Traceid": "d7f279e8734a22133fad25f5e1ed70e1"
  }
}

Service configuration:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: httpbin
---
apiVersion: v1
kind: Service
metadata:
  name: httpbin
  labels:
    app: httpbin
spec:
  type: NodePort
  ports:
    - name: http
      port: 80
      targetPort: 80
  selector:
    app: httpbin
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: httpbin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: httpbin
      version: v1
  template:
    metadata:
      labels:
        app: httpbin
        version: v1
    spec:
      serviceAccountName: httpbin
      containers:
        - image: docker.io/kennethreitz/httpbin
          imagePullPolicy: IfNotPresent
          name: httpbin
          ports:
            - containerPort: 80
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    alb.ingress.kubernetes.io/actions.redirect:
      '{"Type": "redirect", "RedirectConfig":
      { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301"}}'
    alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:eu-west-1:.....
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80}, {"HTTPS":443}]'
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/target-type: instance
    alb.ingress.kubernetes.io/ssl-policy: ELBSecurityPolicy-TLS-1-2-Ext-2018-06
    alb.ingress.kubernetes.io/success-codes: "404"
    kubernetes.io/ingress.class: alb
  name: httpbin
  namespace: default
spec:
  rules:
    - http:
        paths:
          - backend:
              serviceName: redirect
              servicePort: use-annotation
            path: /*
    - host: "test.staging.example.com"
      http:
        paths:
          - backend:
              serviceName: httpbin
              servicePort: 80
            path: /*

Kubernetes environment
AWS EKS (Kubernetes 1.16)
aws-alb-ingress-controller 1.1.6

I was wrong, I had to use:
curl -H "Host: test.staging.example.com" https://db863288-default-httpbin-34b6-1237199957.eu-west-1.elb.amazonaws.com/headers?show_env=1

How do you got those X-B3 OpenCensus headers to work?


Harsh

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Closing. Looks like a spam.


spelling and grammar edits

Love this list; these are offered to be helpful, not critical!

s Thanks for the grammar help (I need it!).  Sorry it took forever to merge


0.12.8 won't build?

Description
Upgraded Cargo.toml from 0.12.7 to 0.12.8 and rebuilt. Getting compile errors in sea-orm...
Steps to Reproduce

Build against 0.12.7
Change Cargo.toml to 0.12.8 and rebuild
See the error

Expected Behavior
Should build fine.
Actual Behavior
error[E0308]: mismatched types
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:80:45
|
80  |             DbBackend::MySql => $stmt.build(MysqlQueryBuilder),
|                                       ----- ^^^^^^^^^^^^^^^^^ expected &DatabaseBackend, found MysqlQueryBuilder
|                                       |
|                                       arguments to this method are incorrect
...
111 | build_query_stmt!(sea_query::WithQuery);
| --------------------------------------- in this macro invocation
|
note: method defined here
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:21:8
|
21  |     fn build(&self, db_backend: &DbBackend) -> Statement;
|        ^^^^^
= note: this error originates in the macro build_any_stmt which comes from the expansion of the macro build_query_stmt (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:81:48
|
81  |             DbBackend::Postgres => $stmt.build(PostgresQueryBuilder),
|                                          ----- ^^^^^^^^^^^^^^^^^^^^ expected &DatabaseBackend, found PostgresQueryBuilder
|                                          |
|                                          arguments to this method are incorrect
...
111 | build_query_stmt!(sea_query::WithQuery);
| --------------------------------------- in this macro invocation
|
note: method defined here
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:21:8
|
21  |     fn build(&self, db_backend: &DbBackend) -> Statement;
|        ^^^^^
= note: this error originates in the macro build_any_stmt which comes from the expansion of the macro build_query_stmt (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:82:46
|
82  |             DbBackend::Sqlite => $stmt.build(SqliteQueryBuilder),
|                                        ----- ^^^^^^^^^^^^^^^^^^ expected &DatabaseBackend, found SqliteQueryBuilder
|                                        |
|                                        arguments to this method are incorrect
...
111 | build_query_stmt!(sea_query::WithQuery);
| --------------------------------------- in this macro invocation
|
note: method defined here
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:21:8
|
21  |     fn build(&self, db_backend: &DbBackend) -> Statement;
|        ^^^^^
= note: this error originates in the macro build_any_stmt which comes from the expansion of the macro build_query_stmt (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0308]: mismatched types
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:101:66
|
101 |                 Statement::from_string_values_tuple(*db_backend, stmt)
|                 -----------------------------------              ^^^^ expected (_, Values), found Statement
|                 |
|                 arguments to this function are incorrect
...
111 | build_query_stmt!(sea_query::WithQuery);
| --------------------------------------- in this macro invocation
|
= note: expected tuple (_, sea_query::Values)
found struct statement::Statement
note: associated function defined here
--> /Users/scotte/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sea-orm-0.12.8/src/database/statement.rs:47:19
|
47  |     pub(crate) fn from_string_values_tuple(db_backend: DbBackend, stmt: (T, Values)) -> Statement
|                   ^^^^^^^^^^^^^^^^^^^^^^^^                           -----------------
= note: this error originates in the macro build_query_stmt (in Nightly builds, run with -Z macro-backtrace for more info)
Reproduces How Often
Always
Workarounds
None
Reproducible Example
Versions
├── sea-orm v0.12.8
│   ├── sea-orm-macros v0.12.6 (proc-macro)
│   │   ├── sea-bae v0.2.0 (proc-macro)
│   ├── sea-query v0.30.2
│   │   ├── sea-query-derive v0.4.0 (proc-macro)
│   ├── sea-query-binder v0.5.0
│   │   ├── sea-query v0.30.2 ()
├── sea-orm-migration v0.12.3
│   ├── sea-orm v0.12.8 ()
│   ├── sea-orm-cli v0.12.3
│   │   ├── sea-schema v0.14.1
│   │   │   ├── sea-query v0.30.2 ()
│   │   │   └── sea-schema-derive v0.2.0 (proc-macro)
│   ├── sea-schema v0.14.1 ()
├── sea-orm v0.12.8 ()
├── sea-orm-migration v0.12.3 ()

Updated to 0.12.9 and the build went through. I suspect you are correct in that sea-query wasn't being updated automatically (I don't reference it in my Cargo.toml)

Yes, thanks for reporting back. Depedency management is tricky sometimes haha.