Asset 355: fosinopril answer ID

This asset currently uses PUBCHEM.COMPOUND:55891 as the expected answer ID for fosinopril.
However, there's a different NodeNorm entity for FOSINOPRIL SODIUM (PUBCHEM.COMPOUND:73415812) with more IDs mapped to it. BTE gives this sodium-variant a higher score/rank (although it's still not in the top 10%).
Should this test use the different ID? Or is this a NodeNorm issue?

May be very similar to the rabeprazole example mentioned in https://github.com/NCATSTranslator/Tests/issues/62#issuecomment-2195095652

Added to https://github.com/NCATSTranslator/Tests/issues/62#issuecomment-2207903878 to consolidate issues.


Fix (build): Bump APPMANIFEST_AR_URL to v1.0.1 to fix hlds builds

This should be done after https://github.com/startersclan/hlds-appmanifest/pull/1 is released.

To be addressed in https://github.com/startersclan/docker-sourceservers/pull/54.
Closing.


Owls83995 - Sample scripts to shutdown and start a specific managed server/cluster/domain

Scripts to start and stop a specific managed server (startServer.sh and stopServer.sh)
Scripts to start and stop a specific cluster (startCluster.sh and stopCluster.sh)
Scripts to start and stop the entire domain (startDomain.sh and stopDomain.sh)
Updated product documentation describing how to use the scripts, including

Guide for basic use cases to start/stop a server, cluster, or the whole domain
Details on the choice to either have the replica count rise & fall or to stay consistent when managing a clustered server

I have added new integration tests in ItLifecycleSampleScripts and ran it in external jenkins. The test results are at - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/2622/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/2622/testReport/oracle.weblogic.kubernetes/ItLifecycleSampleScripts/

The test class ItLifecycleSampleScripts.java should be merged with ItSamples.java
Test for all sample scripts in a single class makes it more readable and manageable and optimize the overall test run. We can create another JIRA for integration tests.
ok, sure. Will you be creating another JIRA or I should create one?

General comment:  Hi Anil - Once you've completed the latest recommended doc changes, I think they'll be ready for Rosemary to make an edit pass.  Since you've added a significant amount of documentation, the easiest way to do this is probably to invite her to the review, ask her to make edits herself directly, and refrain from making any changes while she's editing.

@rosemarymarano Hi Rosemary, can you please review the documentation changes in this PR and make edits as necessary. Please let me know when you start making the edits so that I'll not make any changes during that time. Thanks!

@ankedia, only minor comments. I do need to try this on my Mac! :)

@tbarnes-us @rjeberhard I have made the changes to server start and stop scripts as per our discussion for new algorithm. Please review and let me know if I missed something. Thanks.

@tbarnes-us I have addressed the latest review comments. Please let me know if I missed something.


Inference questions

Is the NS2 model you posted in that GitHub repository also capable of SVC? I checked in the inference step and saw that it is only capable of TTS. Can you help me with this, thank you.

Dear @CHK-0000
Hello, I apologize for the delayed response.
Currently, the code only supports TTS (Text-to-Speech). Initially, I considered supporting SVC as part of the long-term plan, but given that the performance of the TTS itself is not yet fully satisfactory, I have decided that it would be difficult to move on to the next step. As a result, it has not been implemented.


Move lodash to dependencies

Error in webpack:
ERROR in ./~/react-datepicker/dist/react-datepicker.min.js
Module not found: Error: Cannot resolve module 'lodash' in /app/node_modules/react-datepicker/dist
 @ ./~/react-datepicker/dist/react-datepicker.min.js 1:117-134

Getting this same one..

Fixed by #140

Thanks, will release these changes today.


updation in main.py and resources/icons

add more badges in main.py and resources/icons

added in main.py


Watch proc with ebpf

One of the only filesystems we can't watch is the virtual /proc filesystem on Linux.
There is a way to create an ebpf program for the kernel to run which lets us know about modification events on those paths.

https://github.com/e-dant/watcher-bpf-experimental


The preview is only partially visible

When I click on the icon in the menu, only say the bottom tenth of the preview square is showing, the rest is too high up off screen.
I have the latest version of everything installed.

I'm also facing the same issue.
Using the latest version in macOS High Sierra Version 10.13.6 (17G65)

I have the same issue, running Mojave 10.14.3

do you use multiple screens? if so how are they arranged?

two screens, side by side. Main is on the left

do you use multiple screens? if so how are they arranged?

No, just one screen.

Reverting back to Spotmenu 1.8.0 solves the issue

Reverting back to Spotmenu 1.8.0 solves the issue

Hey, it worked. Thanks.

do you guys have the menubar set to automatically hide and show?

SpotMenu.zip
Please try this version

Tried the new version, both with menubar set to automatically hide and not, and both times the top was just a bit cut off

Reverted back to 1.8.0 for now


fix(User): ensure _mergeMagicFields returns data

Codecov Report

Merging #493 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   67.01%   67.14%   +0.13%
==========================================
  Files          36       36
  Lines        2901     2910       +9
==========================================
+ Hits         1944     1954      +10
+ Misses        957      956       -1

Impacted Files
Coverage Δ

src/user.js
60.79% <ø> (-0.19%)
:arrow_down:

src/object.js
82.27% <100%> (+0.4%)
:arrow_up:

src/utils/index.js
95% <0%> (+0.19%)
:arrow_up:

src/captcha.js
15.38% <0%> (+1.65%)
:arrow_up:

src/cloudfunction.js
35.48% <0%> (+2.15%)
:arrow_up:

src/live-query.js
25.92% <0%> (+2.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9597355...4e74ba1. Read the comment docs.


feat(tabs): disallow deselect of tab in onDeselect

We had the need to disallow changing tabs according to business rules.  This pull request implements the functionality where the return value (true/false) of onDeselect() determines if switching tabs is allowed or not.

This would require documentation change.


$ivy ignores Repl colors

If colors are disabled, it would be nice if $ivy didn't try to use terminal color characters.
Running:
import $ivy.`com.fasterxml.jackson.module:jackson-module-scala_2.13:2.11.4`

Has results:
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.13/2.11.4/jackson-module-scala_2.13-2.11.4.pom
    0.0% [          ] 0 B (0 B / s)
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.13/2.11.4/jackson-module-scala_2.13-2.11.4.pom
    0.0% [          ] 0 B (0 B / s)
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.13/2.11.4/jackson-module-scala_2.13-2.11.4.pom
  100.0% [##########] 4.2 KiB (14.8 KiB / s)
[... snip ...]

Sure wish it understood that I disabled colors.

This behavior is from the upstream Coursier project. @alexarchambault is there an easy way to turn of special characters in the Coursier output logs?


Cannot run app to simulator and physical devices (IOS 13.3 and IOS 14) using XCode 12

Steps to Reproduce
Before I update my XCode version, my Flutter app can be launched without any problems. However, when I have updated my XCode through the App Store today, I tried to build and run my app to the simulator and physical devices, the app was successfully built without any errors, but then after the app finished installing and tried to launch, the app turns into a white screen and XCode popped a dialog
Then, I had restarted my mac and run the following commands, but the problems still exist.
pod deintegrate
pod install
flutter build ios

Here is my version info:
macOS Version 10.15.6 (Build 19G2021)
Xcode 12.0 (17219)
(Physical devce) IPhone 7 Plus IOS 13.3
(Physical devce) IPhone 11 IOS 14
(Simulator) IPhone 11 Pro Max IOS 14

Run flutter create bug.

  bug/ios/Runner.xcworkspace/contents.xcworkspacedata (created)
  bug/ios/Runner.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist (created)
  bug/ios/Runner.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings (created)
  bug/ios/Runner/Info.plist (created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
  bug/ios/Runner/Assets.xcassets/LaunchImage.imageset/README.md (created)
  bug/ios/Runner/Assets.xcassets/LaunchImage.imageset/Contents.json (created)
  bug/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png (created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
  bug/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json (created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
  bug/ios/Runner/Base.lproj/LaunchScreen.storyboard (created)
  bug/ios/Runner/Base.lproj/Main.storyboard (created)
  bug/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata (created)
  bug/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist (created)
  bug/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings (created)
  bug/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme (created)
  bug/ios/Flutter/Debug.xcconfig (created)
  bug/ios/Flutter/Release.xcconfig (created)
  bug/ios/Flutter/AppFrameworkInfo.plist (created)
  bug/ios/.gitignore (created)
  bug/test/widget_test.dart (created)
  bug/bug.iml (created)
  bug/.gitignore (created)
  bug/.metadata (created)
  bug/android/app/src/profile/AndroidManifest.xml (created)
  bug/android/app/src/main/res/mipmap-mdpi/ic_launcher.png (created)
  bug/android/app/src/main/res/mipmap-hdpi/ic_launcher.png (created)
  bug/android/app/src/main/res/drawable/launch_background.xml (created)
  bug/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png (created)
  bug/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png (created)
  bug/android/app/src/main/res/values/styles.xml (created)
  bug/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png (created)
  bug/android/app/src/main/AndroidManifest.xml (created)
  bug/android/app/src/debug/AndroidManifest.xml (created)
  bug/android/gradle/wrapper/gradle-wrapper.properties (created)
  bug/android/gradle.properties (created)
  bug/android/.gitignore (created)
  bug/android/settings.gradle (created)
  bug/android/app/build.gradle (created)
  bug/android/app/src/main/kotlin/com/example/bug/MainActivity.kt (created)
  bug/android/build.gradle (created)
  bug/android/bug_android.iml (created)
  bug/pubspec.yaml (created)
  bug/README.md (created)
  bug/ios/Runner/Runner-Bridging-Header.h (created)
  bug/ios/Runner/AppDelegate.swift (created)
  bug/ios/Runner.xcodeproj/project.pbxproj (created)
  bug/lib/main.dart (created)
  bug/.idea/runConfigurations/main_dart.xml (created)
  bug/.idea/libraries/Dart_SDK.xml (created)
  bug/.idea/libraries/KotlinJavaRuntime.xml (created)
  bug/.idea/modules.xml (created)
  bug/.idea/workspace.xml (created)
Running "flutter pub get" in bug...                                 4.8s
Wrote 71 files.

All done!
[✓] Flutter: is fully installed. (Channel stable, 1.20.4, on Mac OS X 10.15.6 19G2021, locale en-HK)
[✓] Android toolchain - develop for Android devices: is fully installed. (Android SDK version 30.0.0)
[✓] Xcode - develop for iOS and macOS: is fully installed. (Xcode 12.0)
[!] Android Studio: is partially installed; more components are available. (version 4.0)
[✓] VS Code: is fully installed. (version 1.49.0)
[✓] Connected device: is fully installed. (3 available)

Run "flutter doctor" for information about installing additional components.

In order to run your application, type:

  $ cd bug
  $ flutter run

Your application code is in bug/lib/main.dart.

Errors from Simulator:

Errors from Physical Device:

Hi @konewltd
iOS 14 is in the dev channel
if you want to switch to dev channel then type flutter channel dev
Thanks

Hi @konewltd
iOS 14 is in the dev channel
if you want to switch to dev channel then type flutter channel dev
Thanks

The problem still exist after switching to dev channel.

Hi @konewltd
Can you please provide your full  flutter doctor -v  and flutter run --verbose  in a plain text file .txt and attach in the comment s
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


history

Description
History document was added onto the site
What
History document is now present in the history tab
Why
The history of Mount Sion needed to be displayed
How
Made separate history branch, edited history text through wordhtml. History text was put into the 'history.html' file.
Verification Steps
http-server
ensure history text is in the history.html tab
Checklist:

[x] This pr is linked to the related trello card
[x] My code follows the style guidelines of this project
[ ] I have requested a code review from (at least) two team members
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] This change has been verified by another team member

@evanhearne UWU

@SinenWew could you attach this to the related Trello Card?

@SinenWew thanks for attaching that. I will review it, but there seems to be a conflict. I will help you with this after I check to see if changes are working.

@SinenWew changes work fine, we will fix conflicts first though before approval :)

@SinenWew changes have been made. I will review this now.

@SinenWew changes look good. Would you like to merge this yourself or would you like me to do it for you. If you're reading by email you can reply via email. :)

@SinenWew we discussed that I will merge this for you as you don't have write access.


01_scrape: Fix: Do not rely on existence of parent id

Problem
ctfd2pages works fine on https://ctf2022.maplebacon.org/challenges, because the parent of .challenge-button has an unique id.

  <button class="[...] challenge-button [...]" value="7">
    [...]
  </button>

I tried to archive the CTF of my team (https://ctf.kitctf.me/challenges) and it failed, because our HTML has this structure.

  <button class="challenge-button [...]" value="9">
    [...]
  </button>

I know that CTFd should in theory always add this parent id (https://github.com/CTFd/CTFd/blob/3c299095cb501a30a05e1e7b96c582f4724cedf2/CTFd/themes/core/assets/js/pages/challenges.js#L320) but I think that our custom theme interfered with this in some way.
"Solution"
Try to match the value=id of .challenge-button which is (in theory) also always added (https://github.com/CTFd/CTFd/blob/3c299095cb501a30a05e1e7b96c582f4724cedf2/CTFd/themes/core/assets/js/pages/challenges.js#L325-L334)
Feel free to close/ignore this PR if this is not a change you want to do.

Perhaps a more long-term solution (and robust against CTFd theme changes) would be to use the CTFd API instead of puppeteer. I think this change is good though, perhaps using this as a fallback would be good.

Perhaps a more long-term solution (and robust against CTFd theme changes) would be to use the CTFd API instead of puppeteer. I think this change is good though, perhaps using this as a fallback would be good.

I don't think CTFd API gives you the theming and all the templates being rendered, right? I mean, there are other CTFd archival tools out there, but they just archive the challenge with descriptions and handouts, rather than have a website so people can see what the CTF looked like while it was ongoing. And I think if we are to rely on the API alone, that's what we'll end up getting, just JSONs of data instead of renders.
Though, here, if a web page accesses an API end point, that API result is archived too, such as: https://github.com/sigpwny/2022.uiuc.tf/tree/main/api/v1

I checked if 'value' exists on the chals of UIUCTF. While it exists for UIUCTF 2020 and 2021, it doesn't work on 2022 where the HTML is like:

[...]

[...]

Need something to somehow hold a strong reference to the elements I think rather than load it by value or ID.

Perhaps a more long-term solution (and robust against CTFd theme changes) would be to use the CTFd API instead of puppeteer. I think this change is good though, perhaps using this as a fallback would be good.

I don't think CTFd API gives you the theming and all the templates being rendered, right? I mean, there are other CTFd archival tools out there, but they just archive the challenge with descriptions and handouts, rather than have a website so people can see what the CTF looked like while it was ongoing. And I think if we are to rely on the API alone, that's what we'll end up getting, just JSONs of data instead of renders.
Though, here, if a web page accesses an API end point, that API result is archived too, such as: https://github.com/sigpwny/2022.uiuc.tf/tree/main/api/v1

Ah sorry, I misread this stage and thought it was mainly for downloading handout files.

Apparently puppeteer has this Page.$ API that I never realized existed: https://pptr.dev/api/puppeteer.page._
diff --git a/01_scrape/index.js b/01_scrape/index.js
index d126a99..10a315b 100644
--- a/01_scrape/index.js
+++ b/01_scrape/index.js
@@ -209,30 +209,20 @@ class PageHandler {
   async handleSpecials(page) {
     if (this.pageUrl === `${this.parent.origin}`) {
       // Puppeteer headless don't fetch favicon
-      const favicon = await page.evaluate(() => {
-        return document.querySelector('link[rel*=\'icon\']').href;
-      });
+      const favicon = await page.$eval('link[rel*=\'icon\']',
+          (e) => e.href);
       this.parent.allHandouts.add(favicon);
     } else if (this.pageUrl === `${this.parent.origin}challenges`) {
-      const chals = await page.evaluate(() => {
-        return Array.from(document.querySelectorAll(
-            '.challenge-button')).map((e) => e.parentElement.id);
-      });
+      const chals = await page.$$('.challenge-button');

       for (const chal of chals) {
         // Challenge Tab
         this.browseCompleted = new HeartBeat();
-        await page.evaluate((chal) => {
-          document.getElementById(chal)
-              .querySelector('.challenge-button')
-              .click();
-        }, chal);
+        await chal.click();
         await this.browseCompleted.wait();

-        const handouts = await page.evaluate(() => {
-          return Array.from(document.querySelectorAll(
-              '.challenge-files a')).map((e) => e.href);
-        });
+        const handouts = await page.$$eval('.challenge-files a',
+            (l) => l.map((e) => e.href));
         for (const handout of handouts) {
           assert(handout.startsWith(this.parent.origin));
           this.parent.allHandouts.add(handout);
@@ -240,12 +230,12 @@ class PageHandler {

         // Solves Tab
         this.browseCompleted = new HeartBeat();
-        await page.evaluate(() => {
-          document.querySelector('.challenge-solves').click();
-        }, chal);
+        await (await page.$('.challenge-solves')).click();
         await this.browseCompleted.wait();

+        await sleep(500);
         await page.keyboard.press('Escape');
+        await sleep(500);
       }
     }
   }
@@ -261,9 +251,8 @@ class PageHandler {

     await this.browseCompleted.wait();

-    const links = await page.evaluate(() => {
-      return Array.from(document.querySelectorAll('a')).map((e) => e.href);
-    });
+    const links = await page.$$eval('a',
+        (l) => l.map((e) => e.href));

     for (let link of links) {
       if (!link.startsWith(this.parent.origin)) {

Wdyt? Apparently I also had to add some delay around the escape press or it'll hang for some reason. Animation?

I now understand why it failed for our theme, we are using ctfd-core-beta and it has a different structure:
https://github.com/CTFd/core-beta/blob/main/templates/challenges.html#L45-L50

using ctfd-core-beta

Ah hmm... The hooks in 08_hook_challenge (https://github.com/sigpwny/ctfd2pages/blob/main/08_hook_challenge/webpack-index.js) might not work for you either. If you want you can check what functions to hook instead in the beta, or I can do it later.
In any case, does that patch above look good to you? If so I'll commit it.

Your patch works very well.
And you are right, the hooks are not working.
I fixed it by hooking CTFd.fetch.
I don't think hooking CTFd.pages.challenge.submitChallenge (https://github.com/CTFd/CTFd.js/blob/main/pages/challenge.js#L36-L57)
would have been a better choice.
Notes

I'm not really a JS developer so some stuff can likely be improved.
I believe this does not handle hints at all (https://github.com/CTFd/CTFd.js/blob/main/pages/challenge.js#L60-L66), but our CTF did not have any hints.

diff --git a/08_hook_challenge/webpack-index.js b/08_hook_challenge/webpack-index.js
index f493755..edb20db 100644
--- a/08_hook_challenge/webpack-index.js
+++ b/08_hook_challenge/webpack-index.js
@@ -1,7 +1,6 @@
 /* global CTFd */

 const FLAGS = require('./flags.json');
-const md = CTFd.lib.markdown();

 const sha256sum = async (string) => {
   const utf8 = new TextEncoder().encode(string);
@@ -11,7 +10,12 @@ const sha256sum = async (string) => {
       .join('');
 };

-CTFd.api.post_challenge_attempt = async function(parameters, body) {
+if (CTFd.api !== undefined) {
+  CTFd.api.post_challenge_attempt = post_challenge_attempt_hooked;
+  CTFd.api.get_hint = get_hint_hooked;
+}
+
+const post_challenge_attempt_hooked = async function(parameters, body) {
   const {challenge_id: chalId, submission: flag} = body;
   const expectedSHA = FLAGS[chalId];
   const submittedSHA = await sha256sum(flag);
@@ -46,7 +50,8 @@ CTFd.api.post_challenge_attempt = async function(parameters, body) {
   }
 };

-CTFd.api.get_hint = async function(parameters) {
+const get_hint_hooked = async function(parameters) {
+  const md = CTFd.lib.markdown();
   const hintId = parameters.hintId;

   for (const hintOrig of CTFd._internal.challenge.data.hints) {
@@ -68,3 +73,15 @@ CTFd.api.get_hint = async function(parameters) {

   throw new Error('Hint not found');
 };
+
+if (CTFd.fetch !== undefined) {
+  const originalCTFdFetch = CTFd.fetch;
+  CTFd.fetch = async function(url, options) {
+    if (/\/api\/v1\/challenges\/attempt/.test(url) && options.method === 'POST' && options.body !== undefined) {
+      const jsonResponse = await post_challenge_attempt_hooked({}, JSON.parse(options.body));
+      return new Response(JSON.stringify(jsonResponse));
+    } else {
+      return await originalCTFdFetch(url, options);
+    }
+  };
+}

Your patch works very well.

Thanks for testing! I'll merge it in a sec.

I don't think hooking CTFd.pages.challenge.submitChallenge (https://github.com/CTFd/CTFd.js/blob/main/pages/challenge.js#L36-L57) would have been a better choice.

Could you clarify on why you think so? I see the block
  if (CTFd._functions.challenge.submitChallenge) {
    CTFd._functions.challenge.submitChallenge(challengeId, challengeValue);
    return;
  }

and it seems to me that it's almost like it's intended to be hooked there

Actually let me create an issue for this so I can close this PR.

Fixed, thanks for reporting and the patch! Though I still want to hear your thoughts on the hooking, if you would.


Issue with documentation

Hi,
Thank you for taking the time to release this!
I came accross an issue that isn't really any fault of NToastNotify or yours, it's more of a VS2017 issue.
When using NuGet in Visual Studio 2017 to install something like this, or a css framework, nuget doesn't add the css or js files to the project, meaning we have to manually download them and add them to our project.
I'm not sure if its a bug or by design, however it does mean that your documentation is missing the instruction for users who don't realise that this issue exists.
I'm not sure it's something you should worry about, but thought I'd mention it. :)

Hi @CybrZr00
Thanks for the heads-up.
Yes It is by design that the js/css files are not included along with the package. This is because there are so many factors that can affect the front-end side of things such as folder structure/ IDE / package-managers/ transpilers etc. So, I thought it would be better to let the developer decide how, when and where the the required files are included.
However, We could have a default setting where if specified the package will include the js/css files. That is one possible options. We can look in to it.
I should have been more specific while specifying that the toastr files have to be downloaded before referencing. I will add this information to the ReadMe file.


FR: Action: Track: Open/close UI for INPUT FX #1-8 on last touched track

Action: Track: Open/close UI for INPUT FX #1-8 on last touched track
Input FX could use some love.

This Lua script seems to work here.
local FX_number = 1 -- set desired FX # here, 1-based

local track = reaper.GetLastTouchedTrack()
if track ~= nil then
  local fxIdx = 0x1000000+(FX_number-1) -- 0x1000000 accesses input / monitoring FX
  if reaper.TrackFX_GetFloatingWindow( track, fxIdx) ~= nil then -- is floating?
    reaper.TrackFX_Show(track, fxIdx, 2) -- close
  else
    reaper.TrackFX_Show(track, fxIdx, 3) -- float
  end
end

Let me know if it does it for you.

This is great.  It doesn't toggle.  Once the fx is floating, sending the command again has no effect.  I don't really need it to toggle for my purposes.
Much appreciated.

Toggling works here when assigning the script to a shortcut with modifier (e.g. Ctrl+I), I think these are always 'passed through', but not when assigning to a 'pure' shortcut (e.g. I).
Anyway,  would you think the request is sufficiently covored so we can close this issue? :)

I tried assigning a global shortcut with modifier, and also non-global.  It still doesn't toggle on my system (Win 7/64).   But honestly, I don't need it to toggle, so I'm happy.  Let's close 'er.


Quick Sync without host driver

It would be possible to enable Quick Sync without driver installed on host?
For example,
I'm using Photoprism and Docker container installs drivers internally during init process:
environment:
    - PHOTOPRISM_FFMPEG_ENCODER: "h264_qsv"
    - PHOTOPRISM_INIT: "intel-graphics tensorflow-amd64-avx2"
...
devices:
    - "/dev/dri:/dev/dri"

I guess it depends on which driver you talking about.  There are multiple drivers at different level.
For example, this container does provide the Intel Media Driver (for VAAPI), but the i915 Linux kernel driver needs to be installed on the host.

Closing this issue.  Please re-open if needed.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

wrong pull request


[Ogre 2.x] DepthCamera integration test fails on macOS

depth camera integration test (INTEGRATION_depth_camera) fails with ogre2 plugin on macOS.
error message from jenkins:
/Users/jenkins/workspace/ignition_rendering-ci-pr_any-homebrew-amd64/ign-rendering/test/integration/depth_camera.cc:247
Expected: (mb) > (0u), actual: 0 vs 0

ogre.log reveals some warnings when validating glsl shaders, see gist

I think this is #332


[TB, Epic] Create better documentation linking WCAG, atom and molecule values

Problem/Concern
Consider this as an epic, whose goal is to help users appreciate how the values they select in atoms and molecules will affect the overall accessibility of the resulting design system.  Another goal is to educate the user on how the WCAG standards affect the choices that they available to them and why.
Tasks governed by this epic:

[ ] Write documentation around how shades, chroma, etc affect accessibility (#751)

[ ] Identify what, if any, of this new documentation should be available to the user through the UI

[ ] Design Thinking on how a user might best discover the information through the UI (#752)
[ ] Identify and link relevant WCAG guidelines to appropriate atoms and molecules. Write documentation to be displayed to the user (#754)
[ ] Update UI with documentation per design produced by Design Thinking (#753)

See Figma File: https://www.figma.com/file/qplg5PqoDAK6dh9Y58JlMD/Building-Themes?type=design&mode=design&t=PUwaunPdRh9LHxLm-1

The WCAG requirements for each component:
https://hedgedoc-hedgedoc.apps.aws-useast1-apps-dev-1.ocpdev.us-east-1.ac.discoverfinancial.com/9zB8IpsbRcyirC4Js-e4LA?both


SDC-7861. Test with Date parsing is falling on Non-US locale

This pull request has been cut from this one https://github.com/streamsets/datacollector/pull/42
These fixes allows to run tests on any locale

Looks good to me @estatic  - let me run it by internal test server and merge :)

The change was merged, thank you for your contribution @estatic !


Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations.

Subject of the issue
I moved from rspec-mocks 3.9.0 to 3.10.0 recently and it breaks several tests that were working before. Typically, it'll throw this message Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations.
Your environment

Ruby version: ruby 2.7.5p203 (2021-11-24 revision f69aeb8314) [x86_64-darwin21]
rspec-mocks version: 3.10.0

Steps to reproduce
After investigating, it occurs systematically when I use allow_any_instance_of against a model in Rails. I couldn't find anyone talking about it precisely anywhere, which's odd.
For example, if I do
allow_any_instance_of(Identity).to receive(:destroy_hook_service)

And then call my subject it'll crash. I know we should avoid doing that and prefer stubbing a precise record, but from time to time you really want to cover all the instances of the classes. In this example, I can't actually target a specific identity, it's checking global destruction of some sort.
Expected behavior
It stubs/mocks some methods
Actual behavior
It crashes.

After investigating, it occurs systematically when I use allow_any_instance_of against a model in Rails. I couldn't find anyone talking about it precisely anywhere, which's odd.

#1356 and #1357
This previously raised a type error when attempting to proxy onto a frozen object, and now raises this argument error explicitly. It's possible something in Rails is errorenously saying its frozen due to its own proxying and triggers this without triggering the original error, but we'd need more details to reproduce. Frozen objects are definietly not modifiable by our mocks.

I have identified the root cause of this issue.  Following code reproduces the problem:
class Tmp
  def result
    'true result'
  end
end

describe 'Tmp' do
  before do
    allow_any_instance_of(Tmp).to receive(:result).and_return('mocked result')
  end

  it 'does not raise any exception' do
    tmp = Tmp.new
    expect(tmp.result).to eq('mocked result')   ### <--- This line is important
    tmp.freeze
    expect(tmp.result).to eq('mocked result')
  end
end

If we have ### <--- This line is important line, second expectation does NOT raise any exception.  If we remove the important line, we get FrozenError.
Background story is like this: rspec-mock prepends its own anonymous module (is a kind of RSpecPrependedModule) on to the subject object's singleton class, and when the anonymous module is already prepended, rspec-mock reuses the anonymous module to add a stub method.  Therefore, if we had had any expectation before the subject object is frozen, we can avoid FrozenError even after the subject object is frozen.

Ahhh sorry, my explanation above is completely wrong... this is just because overridden tmp.result method remains.  I'm investigating again...

I'm getting this same issue. I'm wondering if you ever reached a conclusion?

I'm going to call this closed by #1401, thanks to @keegangroth we now rescue the error to reraise with the warning, let me know if that doesn't solve your problems.


select the row on double click

This PR fixes #3643
select the entire row when a cell is double clicked so that it is easier to know whichrow is selected when the user needs to scroll horizontally.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 42.223%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/query/browser/gridPanel.ts
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
30867

Relevant Lines:
67851

💛  - Coveralls


Some problems when training

Thank you for your transformer code!
When I ran the code, I encountered such issue:
Traceback (most recent call last):
File "train.py", line 539, in
train()
File "train.py", line 451, in train
loss.backward()
File "/data1/baiye/miniconda3/envs/torch04py3/lib/python3.6/site-packages/torch/tensor.py", line 93, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "/data1/baiye/miniconda3/envs/torch04py3/lib/python3.6/site-packages/torch/autograd/init.py", line 89, in backward
allow_unreachable=True)  # allow_unreachable flag
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation
My enviroment is pytorch 0.4. And I checked the code and did not find any inplace operation.

Could you please provide more information about how you ran the code? If you use pytorch 0.4.1 and run it as is, it should be ok.

I met the same problem and solved it by upgrading pytorch from 0.4.0 to 0.4.1.


Saving and importing a topology in simulation

Saving the topology into a json file:
From the Topology web page, it's possible to download a json file that contains : Motes position list, connections list and DAGRoots list for the current Topology

Importing a Topology from a json file:
From the terminal, the '--importTopo' option followed by the json file's path let you reload a previous configuration you saved

Excellent, congrats!
Could you implement the handful of changes? I will merge after that,
:+1:

Thank you,
We tried to fix everything you pointed out, please tell us if you would like us to do further modifications.
Quentin will soon create the issues on JIRA

Wonderful! I left a couple of comments, but you're almost there!
:tada:

I tried to fix everything, not sure about tabs though because they already appears as 4 spaces to me in my editor...

Thanks a million @quentinl-c  and @vince-nayal for the excellent work, including during the numerous discussions on this PR. I believe that this PR is adds a very important functionality to the OpenVisualizer, and I congratulate you on the high quality of the code.


Add link to godoc in README

Fixes issue #50.

You can see what it looks like here:
https://github.com/turtlemonvh/service/tree/patch-1
Pretty standard stuff.


image gen not fixed !

ImageGenerator Error: Redirect failed.
ImageGenerator Usage: /image_gen
also I tried the script on Render
it got build and running well...
but as script not end the building/deploying process at any istance
it always shows deploying
as of the conditions of render anything not deployed within 15 mins , get terminated and shows deployed failed
pls fixed these bugs !

every thing works well, it's your problem!
update cookie. when you see "Redirect failed."


Bumped up to 2.0-alpha-3

@kohsuke

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.


Hide empty collection on users profile

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #1367
[ ] <brief_description_of_what_I've_added>

Thanks for the query written by @vikiival
Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Tested on: /rmrk/u/JHMAL5CyvxWc3Ud42QxRUTpSnUa4m56mRSzPK69d1TU8NG7?tab=collection
before:

my pr:

Otherwise LGTM

wait! I will add the pagination soon.

Missing pagination, check profile @jkdizajn

In order to implement paging, the query needs to return the ‘totalCount’ parameter.  cc @vikiival

@Jarsen136
here you go sir

@Jarsen136 I found the edge case I was not aware a couple of days ago :) so i fixed it

Cool! You are very nice!

😍 Perfect, I’ve sent the payout
💵 $100 @ 185.66 USD/KSM ~ 0.539 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x48238200530555711bcd7fdca2c5d523680dcab47676ba592ea12c426c04b611
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Display Sonner when search query is rejected

Problem
The search box will silently reject search queries that are empty or too short.
https://github.com/RequestNetwork/request-scan/blob/efc69d4089c632bc9a6f6fdcde8904fce829b8dc/src/components/search.tsx#L16
Proposed Solution
Display a sonner when a search query is rejected.

@MantisClone could you please give me an example? Maybe a video showing this issue? Thanks!

@rodrigopavezi I updated the issue description with more details. Please let me know what you think of the proposed solution - whether you agree or disagree.


added a python solution for Codeforce problem CF9-D2-A

congratulations on your hactoberfest contribution. if you like this repo then give it a star. Happy hacking..


Resolve lodash vulnerabilities

Summary
Issue: https://github.com/facebook/react-native/issues/28082
Resolves ~4000 vulnerabilities associated with lodash

Changelog

[General] [Security] - Resolve lodash to ^4.17.12
Test Plan
Run yarn audit, lodash vulnerabilities should not show up.

@hramos What's the action then for this? Should we close this PR?

Closing as not relevant anymore


[SPARK-23173][SQL] rename spark.sql.fromJsonForceNullableSchema

What changes were proposed in this pull request?
spark.sql.fromJsonForceNullableSchema -> spark.sql.function.fromJson.forceNullable
How was this patch tested?
Made sure there are no more references to spark.sql.fromJsonForceNullableSchema.

cc @mswit-databricks @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3208/
Test PASSed.

Test build #96210 has started for PR 22459 at commit f6f427f.

Test build #96210 has finished for PR 22459 at commit f6f427f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96210/
Test PASSed.


[AWS provider v4] Error: Cross-package move statement

Describe the Bug
After upgrading the AWS provider to v4.2.0 and the S3 bucket module to 0.49.0, I receive this error on plans:
│ Error: Cross-package move statement
│
│   on .terraform/modules/s3_example/main.tf line 27, in data "aws_partition" "current":
│   27: data "aws_partition" "current" { count = local.enabled ? 1 : 0 }
│
│ This statement declares a move from an object declared in external module
│ package "registry.terraform.io/cloudposse/s3-bucket/aws". Move statements
│ can be only within a single module package.
╵

Expected Behavior
No errors of this nature
Steps to Reproduce
Steps to reproduce the behavior:

Create a module like this with AWS v3 provider

module "s3_example" {
  source             = "cloudposse/s3-bucket/aws"
  version            = "0.47.1"
  name               = local.bucket_name
  enabled            = true
  user_enabled       = false
  versioning_enabled = true

  logging = {
    bucket_name = module.s3_logs.bucket_id
    prefix      = "logs/"
  }

  tags = local.common_tags

Upgrade AWS provider to v4 and S3 module to 0.49.0

Environment (please complete the following information):
Plans run in Terraform Cloud, but here's the output from terraform version
Terraform v1.1.3
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v4.2.0
+ provider registry.terraform.io/hashicorp/helm v2.4.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.8.0
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/null v3.1.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/time v0.7.2

Additional Context
The problem does not exist when using registry.terraform.io/hashicorp/aws v3.74.3 and version 0.47.1 of the s3 bucket module

I cannot reproduce this. None of our modules have moved statements in them (which is what the error message is complaining about), so I suspect the error is caused by other code you are using.
Here's what I did to try to reproduce this:

I put the following code in main.tf

Full source code (click to reveal)
provider "aws" {
  region = "us-east-2"
}

locals {
  bucket_name = random_pet.id.id
  common_tags = { Name = local.bucket_name }
}

resource "random_pet" "id" {
  length = 3
  prefix = "eg-test-s3-bucket-issue-136"
}

module "s3_example" {
  source             = "cloudposse/s3-bucket/aws"
  version            = "0.47.1"
  name               = local.bucket_name
  enabled            = true
  user_enabled       = false
  versioning_enabled = true

  logging = {
    bucket_name = module.s3_logs.bucket_id
    prefix      = "logs/"
  }

  tags = local.common_tags
}

module "s3_logs" {
  source             = "cloudposse/s3-bucket/aws"
  version            = "0.47.1"
  name               = "${local.bucket_name}-logs"
  enabled            = true
  user_enabled       = false
  versioning_enabled = false

  tags = local.common_tags
}

Ran terraform init -upgrade && terraform apply -auto-approve
Edited main.tf, replacing "0.47.1" with "0.49.0"
Ran terraform init -upgrade && terraform apply -auto-approve

No errors, everything worked fine. Note: Although this worked, it is recommended that you perform manual imports of the new resources created by AWS v4. See the upgrade instructions.


distil-small.en AttributeError

Followed steps provided in the following URL:
https://huggingface.co/distil-whisper/distil-small.en
pip-24.0 used to install  transformers-4.38.1-py3-none-any.whl.metadata using python 3.12.1 in venv
distil-large-v2 runs with no issues however distil-small.en displays the following error:
AttributeError: 'GenerationConfig' object has no attribute 'lang_to_id'
Any ideas on how to solve? Much appreciated for any assistance provided

Same for distil-medium.en, I just used the large version

If size of the model is a concern then I have found the following worked for me:
https://huggingface.co/openai/whisper-tiny.en
There are a few models available with tiny.en being the smallest.
This ran with sub 3 second latency once the model built on my NUC style device.


query params

@sfc-gh-bhess pointed out that because of how we reset query params for security, I think we will lose the query params while using the app. I think this is definitely true pre authentication but i'm not sure it is post authentication

upon further inspection, this will only happen when you try to set or get query params after authentication (which happens most of the time anyway)


Reference implementation for Layer-activation does not compile

When using the reference code the following way, the compiler doesn't let me compile the code. app_nfo and extensions are defined before and work as expected, when the third parameter is set to None.
// ...

let layers_use = instance::layers_list()?.map(|l| l.name());
let inst = Instance::new(Some(&app_nfo), &extensions, layers_use)?;

I actually get two independent compiler errors. The first is that vulkano::instance::layers is private, hence I cannot even implement From for my error handling (so the ? operator does not work and I had to replace it). The second one is:
error[E0271]: type mismatch resolving `<[closure@src/renderer/vulkan__new.rs:55:45: 55:57] as std::ops::FnOnce<(vulkano::instance::LayerProperties,)>>::Output == &&str`
  --> src/renderer/vulkan__new.rs:57:20
   |
57 |             inst = Instance::new(Some(&app_nfo), &extensions, layers_use)?;
   |                    ^^^^^^^^^^^^^ expected str, found &str
   |
   = note: expected type `&str`
   = note:    found type `&&str`
   = note: required because of the requirements on the impl of `std::iter::Iterator` for `std::iter::Map<vulkano::instance::LayersIterator, [closure@src/renderer/vulkan__new.rs:55:45: 55:57]>`
   = note: required by `vulkano::instance::Instance::new`

Version info:
rustc: rustc 1.13.0
cargo: cargo 0.13.0 (built 2016-12-10)
Installed from Portage, running on Gentoo Linux

The first is that vulkano::instance::layers is private

I suppose you mean LayersListError. That should be easy to fix.

The second one is:

Yes unfortunately it's a known problem. The example you linked indicates it:

// FIXME: this example doesn't run because of ownership problems ; Instance::new() needs a tweak

The problem is that in order to make Instance::new easy to use, I made it so that the third parameter is an iterator that produces &&str.
Which means that for now you need to build a Vec<String> from the list of instances you want, then a Vec<&str> that references the first Vec, and then you can pass second_vec.iter().

I suppose you mean LayersListError.

Yes, exactly!

The example you linked indicates it:

Yeah, I was a little blind there (ups), but still it's a good thing that there's an issue for it, now :) I will try to make a PR, but since I am still quite new to Rust itself, I cannot promise anything...

This took me quiet a while to get to something that compiles.
let layers: Vec<String> = instance::layers_list()
                .unwrap()
                .map(|l| String::from(l.name()))
                .collect();
            let layers: Vec<&str> = layers.iter().map(|ln| ln.as_str()).collect();
            Instance::new(None, &extensions, layers.iter())
                .expect("failed to create Vulkan instance")

Is there a clearer way to write this?


Controller Address Changing

The object address of the search controller changes over time (cout << this << endl). This means state in the controller is lost. There is no obvious recreation of the controller in LogicController.

Is it possible that your actually getting the address of the pointer that points to searchcontroller
We regularly create new superclass controller pointers that point to each of subclass controllers as part of the priority reassignment. My best guess is that since this pointer is what the call to dowork is made using then that why the address is changing. That's my guess off the top of my head.
However if the cout was in say the set currentLocation function which calls searchcontroller by its actual reference the address wouldn't change.

I attempted and was unable to replicate the changing adress


Whats the use of FrontViewPosition?

Hello i wanted to know what the use of this // Enum values for setFrontViewPosition:animated:
typedef enum
{
FrontViewPositionLeftSideMostRemoved,
FrontViewPositionLeftSideMost,
FrontViewPositionLeftSide,
// Left position, rear view is hidden behind front controller
FrontViewPositionLeft,

// Right possition, front view is presented right-offseted by rearViewRevealWidth
FrontViewPositionRight,

// Right most possition, front view is presented right-offseted by rearViewRevealWidth+rearViewRevealOverdraw
FrontViewPositionRightMost,

// Front controller is removed from view. Animated transitioning from this state will cause the same
// effect than animating from FrontViewPositionRightMost. Use this instead of FrontViewPositionRightMost when
// you intent to remove the front controller view to be removed from the view hierarchy.
FrontViewPositionRightMostRemoved,

} FrontViewPosition;

try this:
self.revealViewController().setFrontViewPosition(FrontViewPosition.leftSideMost, animated: true)


Pull Civic Patterns

Description
Because civicpatterns.org is broken, we should pull the patterns directly from https://github.com/Code-for-All/civicpatterns.org
Screenshots

Files

https://github.com/Code-for-All/civicpatterns.org

To Reproduce
N/A
Tasks

[ ] Add download task to commons.js
[ ] Add formatting task to commons.js
[ ] Create items and item layouts for the patterns.

Update: CivicPatterns.org is fixed.


feat(ui): introduce dark theme

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR introduces a dark theme to the website.  After all, there can't be a website-based project I contribute to and don't introduce a dark theme.  :D
The sun and moon icons used were pulled from MDN Web Docs, which uses only icons compatible with the Apache 2.0 license.

Probably still needs a white background for the logos though, as some of them look bad on a dark background

Oop!  Let me fix those before we merge!


Example is_block == to player?????

The fox example is clear... but I'm sorry, the syntax usage with the 'player' as the value to check against makes no sense. I cannot even figure out how this is even possible. is_block is a filter to see if the block desired is being used. How can a block be a player?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4ab12a09-51a1-3bb1-2204-bfbfdec267ce
Version Independent ID: 05c088c5-f211-93bf-1731-d1afcccb674a
Content: Entity Documentation - is_block
Content Source: creator/Reference/Content/EntityReference/Examples/Filters/is_block.md
Product: gaming
GitHub Login: @mammerla
Microsoft Alias: mikeam

The errant 'player' value will be removed from the samples on the next release.


Image caption is not populated on parseEditorState

Save an EditorState with an image caption, try populating it again (i.e. by uploading a file). It doesn't show up

Closing as this seems to have been fixed with the recent changes to nested editors.


is it a bug or supposed behaviour?

https://github.com/Hypercontext/linkifyjs/blob/3eb5b8aacc286e57e220cd6ce2d9c139d96e7322/packages/linkifyjs/src/core/fsm.js#L79-L81
nextState.jr.append(templateState.jr);
nextState.jr = templateState.jd; // <- should not it be `nextState.jd` here?
nextState.t = token || templateState.t;

Hi @plandem, great catch, this is a bug. It's fixed in the latest v4.0.0-beta.5 (install with npm install linkifyjs@beta)

Is it possible to fix v3?


Do not say that the login account was not found

If a user enters a wrong password, the error is "username/password incorrect".
If the username is wrong the error is "account not found".
The error should always be "username/password incorrect"

+1.  it was like this at one point in time.  it must have been changed in an update.  thanks for the feedback.


feat: add header and nav elements to all HTML files

We already have a header and nav in our index.html. You can copy and paste this code into our other HTML files or use JavaScript to render the header element dynamically.

I would like to take this one please 🙇🏻♂

has this been completed?

Hey @eram23, sorry I missed this message. I think we only still need the header and nav for our 'Actvities' page, if you would like to work on it.

@michaella23 no worries! I can definitely still do that 😁


COOKBOOK_BOOKMARK - templating

Motivation
to solve this look

hardcoded fa-li class is causing neither FA icon is displayed (I know it needs ul class too)

Thanks, needs fixing. I am closing this one in favour of #18


Missing projected volume in crd install job

Coming from here https://gigantic.slack.com/archives/C02EVLE9W/p1701179146770809

The last release was in August and now CI is failing, without my change it also fails. I dont want to spend time on it, so I will skip it


Kindly help me how to install this

KIndly help me how to install this plugin.

Hi sorry, I just saw this. If you still need my help, you could DM me on twitter, my handle is gsingh7.


module undefined for 1.7.0 (works for 1.6.4)

error: Cannot find module 'angular-formio'

Sorry about that. Version 1.8.0 fixes this problem.


CuffLinks 2.2.1+ Eigen3 problems to build on Ubuntu 16.04

make for Cufflinks 2.2.1 and Eigen3 fails on the following line:
In file included from /usr/include/eigen3/Eigen/Core:297:0,
                 from /usr/include/eigen3/Eigen/Dense:1,
                 from abundances.h:21,
                 from abundances.cpp:16:
/usr/include/eigen3/Eigen/src/Core/DenseCoeffsBase.h: In instantiation of ‘Eigen::DenseCoeffsBase<Derived, 0>::CoeffReturnType Eigen::DenseCoeffsBase<Derived, 0>::coeff(Eigen::Index) const [with Derived = Eigen::PartialReduxExpr<Eigen::Matrix<double, -1, 1>, Eigen::internal::member_sum<double>, 0>; Eigen::DenseCoeffsBase<Derived, 0>::CoeffReturnType = double; Eigen::Index = long int]’:
/usr/include/eigen3/Eigen/src/Core/DenseCoeffsBase.h:181:19:   required from ‘Eigen::DenseCoeffsBase<Derived, 0>::CoeffReturnType Eigen::DenseCoeffsBase<Derived, 0>::operator()(Eigen::Index) const [with Derived = Eigen::PartialReduxExpr<Eigen::Matrix<double, -1, 1>, Eigen::internal::member_sum<double>, 0>; Eigen::DenseCoeffsBase<Derived, 0>::CoeffReturnType = double; Eigen::Index = long int]’
abundances.cpp:3815:28:   required from here
/usr/include/eigen3/Eigen/src/Core/util/StaticAssert.h:119:9: error: ‘THIS_COEFFICIENT_ACCESSOR_TAKING_ONE_ACCESS_IS_ONLY_FOR_EXPRESSIONS_ALLOWING_LINEAR_ACCESS’ is not a member of ‘Eigen::internal::static_assertion<false>’
         if (Eigen::internal::static_assertion<static_cast<bool>(CONDITION)>::MSG) {}
         ^
/usr/include/eigen3/Eigen/src/Core/DenseCoeffsBase.h:141:7: note: in expansion of macro ‘EIGEN_STATIC_ASSERT’
       EIGEN_STATIC_ASSERT(internal::evaluator<Derived>::Flags & LinearAccessBit,

The problem is that if you install Eigen3 via sudo apt-get install libeigen3-dev Ubuntu's 16.04 package is incompatible with cufflinks ... workaround - install an older EIgen3 from the EIgen3 website.

Hi,
Jakub Wilk found a better workaround for the Debian package:
https://anonscm.debian.org/cgit/debian-med/cufflinks.git/tree/debian/patches/lib_eigen.patch

While saying so the best workaround is probably using the Debian package maintained by the Debian Med team.
Kind regards
      Andreas.


[Horovod Unittest] - Script Fix

@pkanwar23 I fixed the code and tested in the container: nvidia/cuda:11.0-devel-ubuntu18.04 it works
@tgaddair I switched the script to use master as you requested ;)

@pkanwar23 I added it back.
This line made the install to fain on my side. If it keeps on fail. I would advise to look into that line

@DEKHTIARJonathan Can you please resolve conflicts? Thanks!


Issue #152 - KDBX Version 4

This PR is likely not ready.  There are a few kinks to work out, including some JSON end of string error.
However, version 4 (all combinations of ciphers) are working now.  You can take a look at the code and see what's what.

Ready for review.

Hold off on reviews just yet.  I've rethought a couple things over the weekend and am working on tidying some things up.

Alright, let's see how this looks.  I tried to make the changes as uninvasive as possible.

Bump.   I'll have a lot of time to work on this next week, then probably not so much.

Due to lack of activity, I've forked the project over to https://github.com/suBDavis/CKPX
It is available for install via https://subdavis.com/CKPX/

This work is complete.


\ adds spaces on first hit in insert mode

Maybe this is because I am running ssh in powershell, not sure:

It's something in basic, but I couldn't find it.

I don't think this is an issue with my vimrc, but your setup ;-)

Yeah, seems better in conemu.


Inbox feed constructor error

I would like to fetch my account inbox but when I try to, got some errors . Here is my code

var feed = new Client.Feed.InboxFeed(session);
feed.get()
.then(function(data){
console.log(data, "you just got first page");
return feed.get()
})
.then(function(data) {
console.log(data, "you just got second page")
})

at the end this code raise an error like this

var feed = new Client.Feed.InboxFeed(session);
^

TypeError: Client.Feed.InboxFeed is not a constructor

it is not
https://github.com/huttarichard/instagram-private-api/blob/master/client/v1.js#L30
try this instead:
var feed = new Client.Feed.Inbox(session);


[entt] Update to 3.5.0

Bumping version to the newest release.

Looks like there's 3.5.1 already. Should we just skip 3.5.0 and update to 3.5.1 in this PR?

@Vennor Up to you

/azp run

@BillyONeal, ok, thanks! Updated to 3.5.1 then.

Thanks for your contribution!


Fatal error on linking

Hi,
I'm trying to use libuv in a project and I wish to statically link it to it, in order to get easily distributable executables.
My environnement is an ubuntu 14.04  on Cloud9 (https://c9.io), an online IDE.
I downloaded the latest sources from the releases here on github, then I followed the autotools instructions.
I had a warning on one test about tty (error below) but I don't think it's relevant to the problem. Then make install seemed to have worked perfectly, I can see that the lib is installed in my /usr/local/lib. I did an ldconfig, then I added in my source code #include <uv.h> and to my Makefile -luv so my final gcc command is something like that gcc -o whatever whatever.c -Wall -std=c11 -pedantic -lsodium -luv
Here is the fatal error I'm getting :
/usr/local/include/uv-unix.h:66:30: fatal error: pthread-barrier.h: No such file or directory
 # include "pthread-barrier.h"

make check warning :
not ok 29 - tty
# exit code 6
# Output from process `tty`:
# width=162 height=10
# Assertion failed in test/test-tty.c on line 120: height > 10

./configure output
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking if gcc supports -pedantic flag... yes
checking for gcc way to treat warnings as errors... -Werror
checking if gcc supports -fvisibility=hidden... yes
checking if gcc supports -g flag... yes
checking if gcc supports -std=gnu89 flag... yes
checking if gcc supports -Wall flag... yes
checking if gcc supports -Wextra flag... yes
checking if gcc supports -Wno-unused-parameter flag... yes
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking whether make supports nested variables... (cached) yes
checking for dlopen in -ldl... yes
checking for kstat_lookup in -lkstat... no
checking for kvm_open in -lkvm... no
checking for gethostbyname in -lnsl... yes
checking for perfstat_cpu in -lperfstat... no
checking for pthread_mutex_init in -lpthread... yes
checking for clock_gettime in -lrt... yes
checking for sendfile in -lsendfile... no
checking for socket in -lsocket... no
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking sys/ahafs_evProds.h usability... no
checking sys/ahafs_evProds.h presence... no
checking for sys/ahafs_evProds.h... no
checking for pkg-config... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating libuv.pc
config.status: creating Makefile
config.status: executing depfiles commands
config.status: executing libtool commands

the 10th line of the cmakelist.txt of mysocks project https://github.com/zhou0/mysocks has the solution to your problem.

Indeed, it seems to be compiling just fine now ! Thanks 😄
For future reference, I added -D_XOPEN_SOURCE=600 to my gcc flags


docs: Deprecate TapDetector in favour of TapCallbacks

Description

Deprecate TapDetector in favour of TapCallbacks

Checklist

[x] I have followed the Contributor Guide when preparing my PR.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

@luanpotter what were our concerns here again? I think it would be great to only have TapCallbacks.


Kobo Libra Color  - Database disk image is malformed

Hi Marcus!
October Version:
Model: Kobo Libra Color
Error: There was a problem sending your highlights: database disk image is malformed (11)
Readwise access token: Set
Upload highlights from store-bought books: Check (even when unchecked, same issue).
The app does not manage to establish a proper connection with the Kobo eReader. See screenshots bellow. Thank you for your assistance and your useful software!

Here are the logs:
{"level":"info","msg":"Logger should be initialised now","time":"2024-05-05T22:28:35+02:00"}
{"level":"info","msg":"Backend is about to start up","time":"2024-05-05T22:28:35+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:28:35+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:28:35+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:28:35+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:28:35+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:28:35+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:28:35+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:28:37+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:28:37+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to retrieve content from device","time":"2024-05-05T22:28:38+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:28:54+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:28:54+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:28:54+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:28:54+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:28:54+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:28:54+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:29:18+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:29:18+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to retrieve content from device","time":"2024-05-05T22:29:26+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:29:28+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:29:28+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:29:28+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:29:28+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:29:28+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:29:28+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:29:30+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:29:30+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:29:36+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:29:36+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:29:37+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:29:37+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:29:37+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:29:37+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:29:37+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:29:37+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:39:38+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:39:38+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to retrieve content from device","time":"2024-05-05T22:39:39+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:42:47+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:42:47+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:42:47+02:00"}
{"kobos_found":1,"level":"info","msg":"Detected one or more Kobos","time":"2024-05-05T22:42:47+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"info","msg":"Found an attached device","time":"2024-05-05T22:42:47+02:00"}
{"device_id":"00000000-0000-0000-0000-000000000390","level":"warning","msg":"Found a device that isn't officially supported but will likely still operate just fine","time":"2024-05-05T22:42:47+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:43:16+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to count bookmarks on device","time":"2024-05-05T22:43:16+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to retrieve content from device","time":"2024-05-05T22:43:17+02:00"}
{"error":"database disk image is malformed (11)","level":"error","msg":"Failed to retrieve content from device","time":"2024-05-05T22:43:38+02:00"}

Hey @WilliamK6,
Sorry for the delay in getting back to you. First off, it's news to me that Kobo put out some new colour devices so thanks for the heads up 🙂
I'm surprised that your database is apparently malformed even though I presume you can still use the device. I vaguely remember this popping up with some new devices as a fluke.
I don't imagine that it's strictly related to October, as it just reads database files and nothing else but I can have a look at the database file anyway and see whether it is indeed malformed or not.
If you can send me an email at<EMAIL_ADDRESS>I can work you through how to get a copy of your database.
I'm also not sure what operating system you're on exactly (macOS? Windows?) so that'd be good to know as the instructions are slightly different between the two.
Thanks again,
Marcus


Bumped version number to 0.1.6

Finish the git flow, started via release process in #1377

You probably also need to run npm install - this should update package-lock as well

Oh snap you're right! I didn't see this comment before I merged. Oops, oh well, we'll get it in the next release branch.


rendering issue on swipe from left edge (android)

when i swipe from the left screen edge, the content area shifts over a few pixels to the right, revealing what appears to be content from another page. i can scrub the area slowly after to reset it.

I just encountered this when clicking a link as well, so it is not limited to the gesture.


large file upload doesn't upload

hi.
i can't upload 300Mb file

Hi @jbabaei you should check the backend server configuration and maybe modify the backend bridge to support that kind of filesizes


Improve y-axis label placement.

It's awkwardly rendering just inside the bottom left corner of the
graph, so let's place it outside and rotate it so it fits in the
margins. It's still a little odd, but it's better.
before:

after:

(note: the line-colours in the after differ a little, due to some styling cruft on my branch)

Beautiful. Thanks so much!


ASB-1253:  Removal of Crown from footer

Task
https://pins-ds.atlassian.net/browse/ASB-1253?atlOrigin=eyJpIjoiZTgxMjcyNGYyMTQwNDRkZWE1YTUzZTk2ZDA2NzM0Y2MiLCJwIjoiaiJ9

:tada: This PR is included in version 2.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


7/18: notes and links

Closes #69.

(still working through this episode 🙂)

Wow! This is looking great. Looking forward to your notes on the rest. Thank you!!

Would you mind if I merged this first bit? It's a great start

Sure!
Sorry for the delay, I should have time to fill in the rest tomorrow afternoon.


Multiple passes are necessary

When a file ends with multiple blank lines, I need to run ktlint multiple times to fix it.
With this file (ending with two blank lines, i.e. three \n characters):
class Test()

Using these commands:
$ ktlint Test.kt
/home/trygve/Test.kt:3:1: Needless blank line(s)
$ ktlint -F Test.kt
/home/trygve/Test.kt:3:1: Needless blank line(s)
$ ktlint Test.kt
/home/trygve/Test.kt:3:1: Needless blank line(s)
$ ktlint -F Test.kt
$

After the first run with -F, the file ends with one blank line. After the second, none. I'm using ktlint 0.29.0.

Thank you for reporting, @trygveaa 🙇


Add junit report for racetest

Please provide a description for what this PR is for.
This should allow prow to report which tests failed, currently it just says it failed and you have to find the failure amongst thousands of logs
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [howardjohn]
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
bcbcd2ca336363961f4c91a1df3404aef007fe21
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
bcbcd2ca336363961f4c91a1df3404aef007fe21
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
bcbcd2ca336363961f4c91a1df3404aef007fe21
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Related to https://github.com/istio/istio/issues/15121

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: linsun, ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @linsun @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [howardjohn]
pkg/OWNERS
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/racetest.sh
bcbcd2ca336363961f4c91a1df3404aef007fe21
link
/test istio-racetest-master

prow/integ-mixer-k8s-presubmit-tests.sh
bcbcd2ca336363961f4c91a1df3404aef007fe21
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
2ffc7c99d05bf3bb601b811fb77ed4f26b87b873
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard-master

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
2ffc7c99d05bf3bb601b811fb77ed4f26b87b873
link
/test e2e-dashboard-master

prow/integ-mixer-k8s-presubmit-tests.sh
2ffc7c99d05bf3bb601b811fb77ed4f26b87b873
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, icygalz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [howardjohn]
pkg/OWNERS
prow/OWNERS [icygalz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @geeknoid @nmittler @ozevren

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, icygalz, utka
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [howardjohn]
pkg/OWNERS
prow/OWNERS [icygalz,utka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
2ffc7c99d05bf3bb601b811fb77ed4f26b87b873
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
7938ad816f206ceedb3af5fb66ad4818cfdf5699
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, icygalz, nmittler, utka
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [howardjohn]
pkg/OWNERS [nmittler]
prow/OWNERS [icygalz,utka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test e2e-mixer-no_auth-master


[fix#12257][Data Quality] Fix no main class set in JAR

Purpose of the pull request
close #12257
Brief change log
Verify this pull request
Manually verified the change by testing locally

How about set main class in maven build

Quick fix:

find ./ -name 'dolphinscheduler-data-quality-*'
and open vim  dolphinscheduler-data-quality-3.1.0.jar
edit META-INF/MANIFEST.MF
add line:  Main-Class: org.apache.dolphinscheduler.data.quality.DataQualityApplication

Quick fix:

find ./ -name 'dolphinscheduler-data-quality-*'
and open vim  dolphinscheduler-data-quality-3.1.0.jar
edit META-INF/MANIFEST.MF
add line:  Main-Class: org.apache.dolphinscheduler.data.quality.DataQualityApplication

I don't recommend doing this, because if you rebuild, you have to change this file every time. If you want to use maven, I recommend overwriting shade or jar plug-ins in the pom.xml and adding the corresponding configuration, but this implementation is not readable or maintainable

Yes, this is not a good idea. Just use in case the release not public

Hi @pandong2011 are this issue in version 3.0.x or version 3.1.x?

@pandong2011 can you test latest code? it should work

Close by #13360


Is there a (minimal) doc somewhere on how to use?

Hello
Setup went smooth but I am not able to use it as I don't even understand the logic :)
Is there a minimal doc explaining how to scan the photo (it is written in the setup doc so I guess I did it well but nothing is really happening), what to expect, where can we see the progess (I see something on top but not sure if it is real as I still have 0 photos) etc
thx

Did you see that? https://github.com/LibrePhotos/librephotos#first-steps-after-setting-up

Did you see that? https://github.com/LibrePhotos/librephotos#first-steps-after-setting-up

yes but then I did not see anything for the rest.
Where can I see the progress?.... I end-up finding something but that doesn't move that much
Where are logs? (the logs folder is empty)
Is it normal that no photos is displayed after some minutes? (= does it wait to scan all the files before to display anything?)
Scanning but not progressing (the numbers do not move)

It seems like it got stuck. Usually you should see the pictures after scanning. Does it show pictures when you click on "Photos -> No Timestamp"? Do you use a special directory like an network attached drive? We have some issues with these: https://github.com/LibrePhotos/librephotos/issues/167

yes I do use a NAS (nfs mount)... I got no issue when I tried it with Photoprism... Will look into the other issue thread


[PE-D][Tester D] Multiple cost supported

The app currently allows multiple c/ cost tags to be added to a single entry, which could lead to confusion in handling cost information.
Steps to Reproduce:
Enter an item with multiple c/ cost tags, e.g., add i/Monitor i/Mouse e/2020-02-02 a/311, Clementi Ave 2, #02-25, S120300 c/$100 c/$123 s/not delivered t/Difficult address to deliver t/Best before Wednesday
Submit the entry.
Expected Result:
Only one c/ cost tag should be accepted per entry, or an error should be shown if multiple c/ tags are entered.
Actual Result:
The app accepts multiple c/ cost tags without any error or warning, potentially causing ambiguity in recorded costs.

Labels: severity.Medium type.FunctionalityBug
original: arnav12344/ped#1

This is a bug fix because the format of the add command for deliveries mentioned in our UG is: add i/ITEM… e/ETA a/ADDRESS c/COST s/STATUS [t/TAG]… and unlike the fields tag and item cost is not supposed to take more than one cost.


Update to next LTS version of Jenkins : 1.625.2

Hi,
Update Dockerfile to use last release of LTS Jenkins version 1.625.2 which contain "Important security fixes".
Regards,
Jean-Pascal
PS : This is my first PR, i'ma sorry if it's not done in right way.

:+1:  from me.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


Parse VersionReq with nom

This is an in-progress PR to move the rest of the parser to nom.
At the moment, this is mostly removing older stuff, and getting things to compile.
/cc @geal

This seems like it adds a lot of code.

where did the op go?


Improve tagging

Addresses #98
This should improve tagging to use the git tags. For some reason it's not triggering the PR CI though. Hate testing GH actions.

Hm, actually. Not sold on the action/plugin, will try something else.

Ready to review, think this one is going to require another iteration if something borks on main. Kind of a PITA

Cool, PRs are working (should mean it's easier/quicker to check the app integrity when we have changes to check on a small PR) and hopefully tags will be picked up when it's on main 👍