App crashes when using publish and unpublish API

[Description of the issue]
FATAL:TwilioVideo:[Core]:Track Id for the SSRC mismatch:
FATAL:TwilioVideo:[Core]:SSRCs count mismatch old:
Steps to Reproduce

call publishVideoTrack
call unpublishVideoTrack

app crashed
Device:
iphone 6, iphone 5
IOS:
11.2
11.4

Hi @Zakaru,
Thanks for writing in. We would like to reproduce/fix this issue but can you please provide the information requested in the issue template?
Most critically, which SDK version are you using? Can you provide a stack trace when the crash occurs? How often does the crash occur?
I would suggest that as a workaround you wait for the publication to either succeed or fail before unpublishing the track in the success case. Please see TVILocalParticipantDelegate for more information.
Best,
Chris

Stack Trace

thread #50, name = 'MediaFactoryImpl::signaling', stop reason = EXC_BAD_ACCESS (code=1, address=0x17)

frame #0: 0x00000001811292a0 libc++.1.dylibstd::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::basic_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 32 frame #1: 0x00000001030bf1e0 TwilioVideotwilio::media::SDPUtils::replaceSsrcs(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >&, std::__1::map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > > > >&) + 752
frame #2: 0x00000001030ee8b0 TwilioVideotwilio::signaling::PeerConnectionSignaling::onCreateSessionLocalDescription(std::__1::unique_ptr<webrtc::SessionDescriptionInterface, std::__1::default_delete<webrtc::SessionDescriptionInterface> >, twilio::video::TwilioError) + 332 frame #3: 0x00000001030f81e8 TwilioVideotwilio::signaling::CreateLocalSdpObserver::OnSuccess(webrtc::SessionDescriptionInterface*) + 96
frame #4: 0x0000000102f7e640 TwilioVideowebrtc::WebRtcSessionDescriptionFactory::OnMessage(rtc::Message*) + 228 frame #5: 0x0000000102ba2e30 TwilioVideortc::MessageQueue::Dispatch(rtc::Message*) + 196
frame #6: 0x0000000102c32360 TwilioVideortc::Thread::ProcessMessages(int) + 88 frame #7: 0x0000000102c322dc TwilioVideortc::Thread::PreRun(void*) + 104
frame #8: 0x0000000181bdd220 libsystem_pthread.dylib_pthread_body + 272 frame #9: 0x0000000181bdd110 libsystem_pthread.dylib_pthread_start + 292
frame #10: 0x0000000181bdbb10 libsystem_pthread.dylib`thread_start + 4

System information:
Iphone devies:

Iphone 5: iOS 11.4.1 - 16Gb
Iphone 6: iOS 11.4.1 - 32Gb

SDK version:

TwilioVideo: 2.3.0

Hi Christopher,
Thank you for your reply,
Stack Trace

thread #50 https://github.com/twilio/video-quickstart-swift/pull/50,
name = 'MediaFactoryImpl::signaling', stop reason = EXC_BAD_ACCESS (code=1,
address=0x17)

frame #0: 0x00000001811292a0 libc++.1.dylibstd::__1::basic_string<char,
std::__1::char_traits, std::__1::allocator

::basic_string(std::__1::basic_string<char, std::__1::char_traits,
std::__1::allocator > const&) + 32 frame #1: 0x00000001030bf1e0
TwilioVideotwilio::media::SDPUtils::replaceSsrcs(std::__1::basic_string<char,
std::__1::char_traits, std::__1::allocator >&,
std::__1::map<std::__1::basic_string<char, std::__1::char_traits,
std::__1::allocator >, std::__1::vector<std::__1::basic_string<char,
std::__1::char_traits, std::__1::allocator >,
std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits,
std::__1::allocator > > >, std::__1::less<std::__1::basic_string<char,
std::__1::char_traits, std::__1::allocator > >,
std::__1::allocator<std::__1::pair<std::__1::basic_string<char,
std::__1::char_traits, std::__1::allocator > const,
std::__1::vector<std::__1::basic_string<char, std::__1::char_traits,
std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char,
std::__1::char_traits, std::__1::allocator > > > > > >&) + 752
frame #2 https://github.com/twilio/video-quickstart-swift/issues/2:
0x00000001030ee8b0
TwilioVideotwilio::signaling::PeerConnectionSignaling::onCreateSessionLocalDescription(std::__1::unique_ptr<webrtc::SessionDescriptionInterface,
std::__1::default_deletewebrtc::SessionDescriptionInterface >,
twilio::video::TwilioError) + 332 frame #3: 0x00000001030f81e8
TwilioVideotwilio::signaling::CreateLocalSdpObserver::OnSuccess(webrtc::SessionDescriptionInterface*)

96
frame #4 https://github.com/twilio/video-quickstart-swift/pull/4:
0x0000000102f7e640
TwilioVideowebrtc::WebRtcSessionDescriptionFactory::OnMessage(rtc::Message*)
228 frame #5: 0x0000000102ba2e30
TwilioVideortc::MessageQueue::Dispatch(rtc::Message*)
196
frame #6 https://github.com/twilio/video-quickstart-swift/pull/6:
0x0000000102c32360 TwilioVideortc::Thread::ProcessMessages(int) + 88
frame #7: 0x0000000102c322dc TwilioVideortc::Thread::PreRun(void*) +
104
frame #8 https://github.com/twilio/video-quickstart-swift/issues/8:
0x0000000181bdd220 libsystem_pthread.dylib_pthread_body + 272 frame
#9: 0x0000000181bdd110 libsystem_pthread.dylib_pthread_start + 292
frame #10 https://github.com/twilio/video-quickstart-swift/issues/10:
0x0000000181bdbb10 libsystem_pthread.dylib`thread_start + 4

System information:
Iphone devices:

Iphone 5: iOS 11.4.1 - 16Gb
Iphone 6: iOS 11.4.1 - 32Gb

SDK version:

TwilioVideo: 2.3.0

Zakaru

IOS/Mac Software Developer

On Fri, Aug 24, 2018 at 12:27 AM Christopher Eagleston <
<EMAIL_ADDRESS>wrote:

Hi @Zakaru https://github.com/Zakaru,
Thanks for writing in. We would like to reproduce/fix this issue but can
you please provide the information requested in the issue template?
Most critically, which SDK version are you using? Can you provide a stack
trace when the crash occurs? How often does the crash occur?
I would suggest that as a workaround you wait for the publication to
either succeed or fail before unpublishing the track in the success case.
Please see TVILocalParticipantDelegate
https://twilio.github.io/twilio-video-ios/docs/latest/Protocols/TVILocalParticipantDelegate.html
for more information.
Best,
Chris
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twilio/video-quickstart-swift/issues/298#issuecomment-415501867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGY9G_3kX8w4dJa2nJU55b17fv_hFZeYks5uTuXvgaJpZM4WJKGB
.

Hi @Zakaru,
Thanks for the info. Our next release (2.4.0) will include a refactor of this code path, which should resolve this particular crash. I'm adding some additional tests in this area to get more certainty before declaring the bug fixed.
Best,
Chris

@Zakaru We have just released 2.4.0 which includes a refactor of this code path, which should resolve this particular crash. [Here] are the change logs for 2.4.0.   Try it out and let me know if you still run into the crash.
Best,
Piyush

Hey @Zakaru,
Were you able to give this a shot? I wrote a few tests for this case before I left for vacation but they didn't immediately reproduce the crash on impacted versions.
Best,
Chris

Hi,
We've now released 2.4.1 which has further hardening in this area.
Now that we have a release I'll close this one out. Please re-open if you're still experiencing this crash in 2.4.1 or newer.
Thanks,
Chris


no member named 'GetCocoaServer'

Hi;
When I compile openCV 3 (HEAD) version, it has been broken compiling.
I can use PCL and VTK normaly.
How can I solve this problem.
/tmp/opencv320160323-37738-fjug24/modules/viz/src/vtk/vtkCocoaInteractorFix.mm:284:81: error: no member named 'GetCocoaServer' in 'cv::viz::vtkCocoaRenderWindowInteractorFix'
        vtkCocoaServerFix *server = reinterpret_cast<vtkCocoaServerFix*> (this->GetCocoaServer ());
                                                                          ~~~~  ^
/tmp/opencv320160323-37738-fjug24/modules/viz/src/vtk/vtkCocoaInteractorFix.mm:285:20: error: no member named 'GetCocoaServer' in 'cv::viz::vtkCocoaRenderWindowInteractorFix'
        if (!this->GetCocoaServer ())
             ~~~~  ^
/tmp/opencv320160323-37738-fjug24/modules/viz/src/vtk/vtkCocoaInteractorFix.mm:288:19: error: no member named 'SetCocoaServer' in 'cv::viz::vtkCocoaRenderWindowInteractorFix'
            this->SetCocoaServer (reinterpret_cast<void*> (server));
            ~~~~  ^
/tmp/opencv320160323-37738-fjug24/modules/viz/src/vtk/vtkCocoaInteractorFix.mm:300:81: error: no member named 'GetCocoaServer' in 'cv::viz::vtkCocoaRenderWindowInteractorFix'
        vtkCocoaServerFix *server = reinterpret_cast<vtkCocoaServerFix*> (this->GetCocoaServer ());
                                                                          ~~~~  ^
4 errors generated.
make[2]: *** [modules/viz/CMakeFiles/opencv_viz.dir/src/vtk/vtkCocoaInteractorFix.mm.o] Error 1
make[1]: *** [modules/viz/CMakeFiles/opencv_viz.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

I meet this too, how's the progress?

I had the same problem with VTK 7.0.0 and OpenCV 3
After reading multiple posts online I figured out the reason.
Since VTK version 6.2, the GetCocoaServer() and SetCocoaServer() function calls were moved from vtkRenderWindowInteractor to vtkRenderWindow.
The opencv-3.1.0/modules/viz/src/vtk/vtkCocoaInteractorFix.mm was designed to solve this Issue, so it will fix potential problems for VTK version >= 6.2
The original vtkCocoaInteractorFix.mm code uses a one-line version detection macro, i.e.
#if VTK_MAJOR_VERSION >= 6 && VTK_MINOR_VERSION  >=2
If we use VTK 7.0.0, although it is a newer version, the minor version is less than two, so the vtkCocoaInteractorFix.mm will handle this as older VTK versions and that causes the problem.
So to fix this we just need to add the version number 7 to the line.
#if VTK_MAJOR_VERSION >= 6 && VTK_MINOR_VERSION  >=2 || VTK_MAJOR_VERSION >=7
Then the opencv3 can be built successfully.

Thank you very much for solving the problem. @chengguo1987
Should we create a PR about this?

@DelightRun I already made a pull request on the opencv github site.

Shouldn't this patch also be applied to the 2.4 branch? Same problem is happening there.


embedding doesn't work

I just found out that from version 3.18.5 embedding doesn't work well.
Let's take this as an example of the "twinny" repository.
In version 3.18.4, if I run the explain @extension.global.d.ts, I'm getting a file analysis:

But in versions 3.18.5 and later, I just get "reflections on the topic":

So I had to roll back to 3.18.4...

I tried 3.19.0, and it seems that this issue does exist. I haven't looked at the code in detail yet, but I suspect it might be related to the fileContents that was removed in a710b6b.

in version 3.19.0, the embedding process does not start processing (I waited a long time without recording):
https://github.com/user-attachments/assets/425d2f16-98e9-4ae1-9180-38797ef50073

Thanks for the detailed report. It seems related to this issue: https://github.com/twinnydotdev/twinny/issues/386 Will be investigating soon, since we removed some default ignored file list (in favour of user defined) we have some crashes.  Are there any errors in the console?  Help > Toggler Developer Tools.
Many thanks!

I'll take a look now. There is only one moment at once - all the files in the folder (from the video) are less than 100 lines.

2024-11-13 15:08:14.755 [error] [Extension Host] Fetch error: TypeError: Cannot read properties of undefined (reading '0')
	at EmbeddingDatabase.getEmbeddingFromResponse (c:\Users\JuriKor\.vscode\extensions\rjmacarthy.twinny-3.19.0-win32-x64\out\index.js:57898:31)
	at onData (c:\Users\JuriKor\.vscode\extensions\rjmacarthy.twinny-3.19.0-win32-x64\out\index.js:57787:24)
	at fetchEmbedding (c:\Users\JuriKor\.vscode\extensions\rjmacarthy.twinny-3.19.0-win32-x64\out\index.js:57697:5)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Please provide API details of embedding API for ollama.

Please provide API details of embedding provider API for ollama. Please make sure it's /api/embed as described here it's the new standard it replaced the old API endpoint: https://github.com/ollama/ollama/blob/main/docs/api.md#generate-embeddings

Thanks, it helped. The problem with the implementation process is coming to an end, but the initial problem still remains. However, as far as I understand, this problem will be solved with #389


Azure service principal auth saves credentials, uses them for other unrelated requests

We use docker-machine in Rancher to create VMs.. Because we're multi-tenant and and doing it on behalf of someone in response to an API call, the interactive auth prompting was a non-starter for us.  Support for directly passing --azure-client-id and --azure-client-secret was recently added and appeared to solve our problems.
But when creating a machine with --driver=azure --azure-subscription-id=X --azure-client-id=Y --azure-client-secret=Z,  {X,Y,Z} are still saved into ~/.docker/machine/credentials/azure.  This then makes them available so that a subsequent create with no client id/secret provided (--driver=azure --azure-subscription-id=X) will re-use the previous credentials automatically.
It would seem that the credentials should be saved tied to just that specific machine when the credentials were passed in specifically to create it, as they are in other drivers.
The bigger problem though is that for a subscription that already has saved creds the credentials that were passed in are completely ignored and use the ones saved on disk are used instead.  So I can pass in --driver=azure --azure-subscription-id=X --azure-client-id=complete --azure-client-secret=garbage and a machine is successfully created anwyay because of a side-effect of a call made long ago, even though I provided completely invalid credentials .
Example:
root@763aaa9ef0f0:~# rm -rf ~/.docker/machine/credentials/azure
root@763aaa9ef0f0:~# docker-machine create --driver=azure --azure-subscription-id=X --azure-client-id=Y --azure-client-secret=Z foo
Running pre-create checks...
(foo) Completed machine pre-create checks.
Creating machine...
(foo) Querying existing resource group.  name="docker-machine"
(foo) Resource group "docker-machine" already exists.
(foo) Configuring availability set.  name="docker-machine"
(foo) Configuring network security group.  name="foo-firewall" location="westus"
(foo) Querying if virtual network already exists.  name="docker-machine-vnet" rg="docker-machine" location="westus"
(foo) Creating virtual network.  name="docker-machine-vnet" rg="docker-machine" location="westus"
(foo) Configuring subnet.  name="docker-machine" vnet="docker-machine-vnet" cidr="<IP_ADDRESS>/16"
(foo) Creating public IP address.  name="foo-ip" static=false
(foo) Creating network interface.  name="foo-nic"
(foo) Creating virtual machine.  name="foo" location="westus" size="Standard_A2" username="docker-user" osImage="canonical:UbuntuServer:16.04.0-LTS:latest"
Waiting for machine to be running, this may take a few minutes...
Detecting operating system of created instance...
Waiting for SSH to be available...
Detecting the provisioner...
Provisioning with ubuntu(systemd)...
Installing Docker...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
Checking connection to Docker...
Docker is up and running!
To see how to connect your Docker Client to the Docker Engine running on this virtual machine, run: docker-machine env foo

root@763aaa9ef0f0:~# docker-machine create --driver=azure --azure-subscription-id=X bar
Running pre-create checks...
(bar) Completed machine pre-create checks.
Creating machine...
(bar) Querying existing resource group.  name="docker-machine"
(bar) Resource group "docker-machine" already exists.
(bar) Configuring availability set.  name="docker-machine"
(bar) Configuring network security group.  name="bar-firewall" location="westus"
(bar) Querying if virtual network already exists.  location="westus" name="docker-machine-vnet" rg="docker-machine"
(bar) Virtual network already exists.  name="docker-machine-vnet" rg="docker-machine" location="westus"
(bar) Configuring subnet.  name="docker-machine" vnet="docker-machine-vnet" cidr="<IP_ADDRESS>/16"
(bar) Creating public IP address.  name="bar-ip" static=false
(bar) Creating network interface.  name="bar-nic"
(bar) Creating virtual machine.  osImage="canonical:UbuntuServer:16.04.0-LTS:latest" name="bar" location="westus" size="Standard_A2" username="docker-user"
Waiting for machine to be running, this may take a few minutes...
Detecting operating system of created instance...
Waiting for SSH to be available...
Detecting the provisioner...
Provisioning with ubuntu(systemd)...
Installing Docker...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
Checking connection to Docker...
Docker is up and running!
To see how to connect your Docker Client to the Docker Engine running on this virtual machine, run: docker-machine env bar

root@763aaa9ef0f0:~# docker-machine create --driver=azure --azure-subscription-id=X --azure-client-id=garbage --azure-client-secret=garbage baz
Running pre-create checks...
(baz) Completed machine pre-create checks.
Creating machine...
(baz) Querying existing resource group.  name="docker-machine"
(baz) Resource group "docker-machine" already exists.
(baz) Configuring availability set.  name="docker-machine"
(baz) Configuring network security group.  name="baz-firewall" location="westus"
(baz) Querying if virtual network already exists.  name="docker-machine-vnet" rg="docker-machine" location="westus"
(baz) Virtual network already exists.  rg="docker-machine" location="westus" name="docker-machine-vnet"
(baz) Configuring subnet.  name="docker-machine" vnet="docker-machine-vnet" cidr="<IP_ADDRESS>/16"
(baz) Creating public IP address.  name="baz-ip" static=false
(baz) Creating network interface.  name="baz-nic"
(baz) Creating virtual machine.  name="baz" location="westus" size="Standard_A2" username="docker-user" osImage="canonical:UbuntuServer:16.04.0-LTS:latest"
Waiting for machine to be running, this may take a few minutes...
Detecting operating system of created instance...
Waiting for SSH to be available...
Detecting the provisioner...
Provisioning with ubuntu(systemd)...
Installing Docker...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
Checking connection to Docker...
Docker is up and running!
To see how to connect your Docker Client to the Docker Engine running on this virtual machine, run: docker-machine env baz

root@763aaa9ef0f0:~# rm -rf ~/.docker/machine/credentials/azure
root@763aaa9ef0f0:~# docker-machine create --driver=azure --azure-subscription-id=14a619f7-a887-4635-8647-d8f46f92eaac --azure-client-id=garbage --azure-client-secret=garbage bat
Running pre-create checks...
Error with pre-create check: "Error creating Azure client: Failed to get a token with service principal: autorest#WithErrorUnlessStatusCode: POST https://login.microsoftonline.com/abb5adde-bee8-4821-8b03-e63efdc7701c/oauth2/token?api-version=1.0 failed with 400 Bad Request: StatusCode=400"
The default lines below are for a sh/bash shell, you can specify the shell you're using, with the --shell flag.

@vincent99 This is kind of by design. I assumed you would create one service principal to manage a subscription that holds your docker-machines. I will see what we can do for this.

That seems like reasonable behavior for the default console-interactive auth prompting; but if I'm providing keys in the arguments I would expect them to be specifically used for that operation (not other ones that happen to be on disk) and not later used for other operations on other machines (by saving them to the creds dir).

Just sent a PR fixing this, thanks for reporting.


Define project wide apps and packages

This defines a few packages providing a space to introduce project-wide customizations:

commands, serializers, template tags, ... (the core app);
models (the db app);
admin area (the admin app overriding the django.contrib.admin);
generic views and forms (the views and forms packages, respectively).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (46166c8) 87.71% compared to head (9e40ee0) 92.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   87.71%   92.04%   +4.32%
==========================================
  Files           3       12       +9
  Lines          57       88      +31
  Branches        2        2
==========================================
+ Hits           50       81      +31
  Misses          5        5
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ci: test that vector integreity check can be toggled on index update with AVS 1.0.0 vec-448

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.03%. Comparing base (79fd24a) to head (9f2527f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   87.03%   87.03%
=======================================
  Files          42       42
  Lines        2962     2962
=======================================
  Hits         2578     2578
  Misses        291      291
  Partials       93       93

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"Commands"

Command buffers are used by Bevy to spawn/despawn entities and create/destroy archetypes while no systems are running. Current proposal by alice-i-cecile has some interesting ideas:

The basic outline goes something like this:
Commands which mutate the same data are stored together, like an enhanced version of Cart's ECS PR
Commands are processed one-type-at-a-time in a just-in-time fashion: automatically inserting a system that takes write-access to all of the data that they mutate immediately before the next system that reads any of the data that they would modify
We take advantage of component and resource registeration plus the dynamic system cosntruction
insertion tech to replace anything left that still needs access to everything in the world
We remove exclusive systems and stages, eliminating all hard sync points, except at the end of the game loop.
At the end of the game loop, process any remaining outstanding commands then in parallel by creating a bunch of command-handling systems
I fully expect there to be some serious feasibility questions around it, but it would:
a) remove all hard sync points
b) simplify the conceptual model of how to use Bevy apps by making commands always take place instantly*
c) allow commands to be efficiently batch-processed
d) allow different types of commands to be safely processed in parallel
e) open the door to event-triggered systems that work in exactly the same way
f) give us the tech needed to do automatic index updating
*not actually instantly, but there would be no way to accidentally run your system before commands resolve

The current scheduler I thought of is very conservative wrt mutation (blocks any read/write iteration on all components that satisfy the minimum system query). Command buffers allow simultaneous reading and writing, but don't allow for instant access to new components until the next stage. JITing the command buffers is a neat solution.

AFAIK each system has a local command buffer that gets flushed per type at one of these JIT points by the scheduler. Archetype creation/destruction still happens at end-of-loop.

Ok, we need two additional type parameters to track component actions (insert/remove) and archetypal actions (whether it spawns/despawns any entities).


Seals are now corporeal and can't walk through walls

I can currently walk through walls.

Also - seal movement is pretty crazy pants. It works for now, but we should eventually fine tune that.

How did you walk through the wall?
I tried really hard to get it to let me through.

 Right now this is what my scene pane looks like:

From what I can remember of your screen, I suspect that we've left something out via the .gitignore that should be there.

This should be the screen before hitting play?

:+1: that's what I'm seeing, too.
But something really weird is going on over here. When I get to the wall, the seal is disappearing behind the wall, but he'll pass through it.

That means that somewhere I the update to the blocking layer didn't get updated correctly, which sounds like .gitignore

Try that new one

Bright side - I can dance on top of walls.
Crappy side - Pretty sure that's not what you want.

I did a separate check out and that didn't work, too.

well that's weird.

try that?

I'm stuck in a box! :+1: merging


Add UI for managing application users

Also tweaks some of the user management UI for consistency/correctness.

 Move client configuration into DB


How can I use static libraries ?

I want build my project by static linking. I got a solution in this page .
https://devblogs.microsoft.com/cppblog/vcpkg-updates-static-linking-is-now-available/
The method mentioned is as follows.

But it don't work in Visual Studio 2019 .
When I put that in my .vcxproj file , then rebuild it . It shows
error LNK2001	unresolved external symbol  __imp__PathIsRelativeA@4

Static linking isn't available for  Visual Studio 2019 ?
If it can ,how can I use it ?
Thank you very much .

try linking Shlwapi.lib (vcpkg integration with msbuild doesn't pull additional dependencies, you have to specify them manually)

I just tried this and it worked just fine. Can you double check? Note that you'll need to install libraries under the associated chosen triplet for them to be found.

I also can't reproduce this issue in the latest vcpkg(2021-08-03-1a6d67b8150e94b7f473c6ab1c0cfd).
Meanwhile, instead of modifying the vcxproj file, you can now set the use of static in Project->Properties->vcpkg in the ide interface:

This issue should be fixed.


GEOMESA-1334 OSM XML/PBF converters

Supports 'nodes' and 'ways' but not 'relations'
All ways are treated as linestrings
References to missing nodes are dropped, but the way is still created

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

we still waiting on a CQ?

cqs added

i'm testing this out by ingesting the ways out of the whole planet-latest.osm.pbf, but the h2 database is really starting to struggle with ingesting the nodes. it's up to 72G of files, but it's slowed down to a crawl... if no one has any bright ideas, I'll open a ticket to address it later.

how big is the h2 db? i wonder if a hash index as the primary key would be better...depends on how much mem you have but would give direct lookups.

i was trying not to rely on main mem - the h2 got to be 70G+ on disk... i think i might have figured out the problem though - i was using the node id as the primary key, but h2 says that it keeps files sorted by primary key, so any insert would likely touch half the files. I'm trying again without any primary key (so it will use a 1-up internal id), then creating an index on the id field after all the nodes are ingested.

gotcha yeah i think most do a clustered database on the primary key

going to try a few other things - want to be able to ingest the whole planet-osm file.

@elahrvivaz, apologies for the delays in getting the CQs approved.  In case that continues, are there bits of this PR which should be merged (like the DeleteFileVisitor)?
If there are issues with the CQs, would the work be able to be committed to a module/tutorial repo?

I need to go back and fix this - all the embedded databases I've tried can't handle the whole-planet osm file for the ways ingestion. I've run out of ideas at this point... I don't think there are any parts worth separating out. moving to an alternate repo might be an idea but waiting for cqs is ok for now.

@elahrvivaz yeah... I'm suggesting the alternate repo since I think getting the CQs approved might take quite a bit of work...
Is there a sensible way to use Accumulo for managing the intermediate database?  All the lookups for nodes should be fast...

yeah, using a 'real' db would probably fix the problem. i was hesitant to require something like that in the converter framework though. might be the way to go...

@elahrvivaz what if we allowed a jdbc string for a driver instead? so if you wanted to do it you could?

@jahhulbert-ccri yeah, good idea

ah looks like it needs a little master merge too.

looks like one more cq: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11802

What! it's done?!?!!? one more build/cqs possibly then we can merge.

Yes.  There is light at the end of the tunnel!  Looks like we need to re-run the build-cqs.tsv, resolve conflicts and shippit!

yay! cool once @elahrvivaz get's that in I'll merge. There's some other OSM GPX code I need to get in that apparently is in my repo and I'm going to pull it over: https://geomesa.atlassian.net/browse/GEOMESA-1730

rebased and double-checked cqs, think we should be good now


Andy joins then restarts immediately after

I start the bot, he joins then 5 seconds later leaves and restarts.
it says,
TypeError: Cannot read properties of null (reading 'match')
at containsCommand (file:///C:/Users/####/Downloads/mindcraft-main/mindcraft-main/src/agent/commands/index.js:19:34)
at Agent.handleMessage (file:///C:/Users/####/Downloads/mindcraft-main/mindcraft-main/src/agent/agent.js:151:32)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v18.18.0
Agent process exited with code 1 and signal null
Restarting agent...

I have this same issue, but it crashes immediately when joining.

I fixed this for me by correcting the model name. In my case it was llama3 when it should've been llama3.2

I fixed this for me by correcting the model name. In my case it was llama3 when it should've been llama3.2

I'll try this and see if it works, thanks for telling me how you fixed it though


declaration of ConnectionFactory::createConnection() breaks Laravel 5.1 LTS

[ErrorException]
Declaration of Bosnadev\Database\Connectors\ConnectionFactory::createConnection() should be compatible with Illuminate\Database\Connectors\ConnectionFa
ctory::createConnection($driver, $connection, $database, $prefix = '', array $config = Array)

I have created a pull request to fix this.


Changing led pin issue?

Hello,
I am having some trouble using mclighting. I want to use pin 14 on an esp03 with an upgraded flash for the strip, but somehow i cannot change the gpio pin on the web page. On the definitio.h i wrote led pin = 14, but on the webpage its always on pin 3. Already made my pcb with pin14?
Any help please

Hi @huge-11,
in the recent versions, you can configure the PIN dynamically via HTTP call.
Have a look here: https://github.com/toblum/McLighting/wiki/Software-installation#configure-pin--rgb-mode--numleds-only-for-v221-or-later
Greetings

I have the same trouble. When I try to access this link :
http://YOUR_ESP8266_HOSTNAME_OR_IP/pixelconf?ct=16&rgbo=grb&pin=4
nothing hopping, and I get this :
File Not Found
URI: /pixelconf

@cralex11 Did you use the latest version? /pixelconf should always return something.

Sorry, Mclightning V2 works perfectly, but V3 from attached link have this problem with port 3, I can't change it from settings and from link.

Then you should better ask in the https://github.com/FabLab-Luenen/McLighting project for help.


CLI command length

If possible can SFDX CLI commands made Shorter ?
For example in other frameworks like Angular to generate a component we use -
ng g c 'name';
Shorter names are easier to remember and are fast.
sfdx force:lightning:component:create --type lwc --componentname helloWorld --outputdir force-app/main/default/lwc
to -
sfdx force:l:c:c --type lwc

Interesting suggestion.  While we mull it over you can use and alias in your bash profile. Something like alias force:o:d='sfdx force:org:display'

Will use alias till then.


net/rpc: add client support for RPC over HTTPS

While net/rpc supports HTTPS trivially in the server, there's no built-in way for a
client to connect to one since rpc.DialHTTPPath calls net.Dial itself. With some
duplicated code from client.go it's possible to create a working DialHTTPSPath in user
code, though this is suboptimal since DialHTTPPath references an unexported package
variable which must be duplicated.

https://golang.org/cl/100140043 implements rpc.DialHTTPS and rpc.DialHTTPSPath
which are exact analogues to DialHTTP and DialHTTPPath apart from also accepting a
tls.Config. This issue is mainly to track that CL during the 1.3 code freeze.

I originally proposed this at
https://groups.google.com/forum/#!topic/golang-nuts/M0LwsijM9bo; no objections were
offered.

The net/rpc package is frozen, so closing this.


Openwhisk updates api 4 24

@mdeuser could you review api doc, I included info on wsk bluemix login

@mdeuser see the intro section now.

@mdeuser going to merge this as first pass


Uncaught SyntaxError: private fields are not currently supported

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: 71.0
Operating system and its version: Linux mint
PDF.js version: https://mozilla.github.io/pdf.js/build/pdf.js
Is a browser extension: No

Not getting the issue in the latest version of mozilla browser.

Web browser and its version: 71.0

That's just a version number, hence it's not entirely clear which browser it actually refers to!
However, assuming that it's Mozilla Firefox, note that that browser version is over two years old and consequently shouldn't be used any more (since it may contain known security vulnerabilities).
Please refer to the FAQ for the official PDF.js support information: https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support

PDF.js version: https://mozilla.github.io/pdf.js/build/pdf.js

Note that you're really not supposed to use that as a CDN, please see https://mozilla.github.io/pdf.js/getting_started/#including-via-a-cdn for that.
Furthermore, you should use official releases for anything except development purposes; please see https://mozilla.github.io/pdf.js/getting_started/#download

Not getting the issue in the latest version of mozilla browser.

Again, you shouldn't use old and outdated browsers. However, you'll need to use a legacy-build of the PDF.js library for anything except the very latest browsers; note the two different builds at https://mozilla.github.io/pdf.js/getting_started/#download


Easier tab completion

Hi there,
I stumpled across a nice feature in https://github.com/davetron5000/gli . If you call
cmd help -c

it only returns the subcommands which can be invoked (no more help text). It would be great to see a similar functionality in thor as well.
cmd help -c
new
rm
chg

cmd new help -c
file
pic
vid

#or

cmd subcmds
new
rm
chg

cmd new subcmds
file
pic
vid

If there is that kind of functionality given in thor, I would be grateful if you point me to the documentation of it. Thx.
Cheers max meyer

:+1:


Restructuring readme

Okay, so I've changed the structure of the readme quite a bit. I hope you like it.
Can be best tested by navigating the branch directly here: https://github.com/hfossli/socket.io-client-cpp/tree/readme

Thanks for the great works.


feat: convert to TypeScript

This converts the code to TypeScript. This allows using this library in the TypeScript code without errors.

I initially design this under Node v12 which it only tests on, most of your additions seem to require v18.
The CI file needs updating or some conditional version build instructions and/or maybe major version update change.

I have updated the CI build file, no issues revealed. The typescript related errors needs to be addressed in https://github.com/TheTechsTech/node-sys/actions/runs/2925392401

I had to rebase the branch for the changes to be effective


"Prefetch" feature

Might be best left to turbolinks, although there is no movement on them ever implementing this.
See: https://gist.github.com/hopsoft/ab500a3b584e2878c83137cb539abb32 && https://github.com/turbolinks/turbolinks/issues/313
I am seeing it as a data-trimmings-prefetch="true" or similar.

Yeah, I think implementing this in Trimmings would break cross-compatibility with Turbolinks, or add a lot of complexity (and explicit knowledge of the Turbolinks API) in order to not break it. Trimmings is, in general, more about facilitating the triggering of native DOM-related events, rather than extending or overloading them, so I don't think this fits the project.
I'd love to see that gist you links packaged up and provided as its own isolated script that kicks in when it detects that Turbolinks is installed, though–and then it would work just fine alongside Trimmings too!


Cannot add authorized users in web interface

when I go to the
Authorization Settings tab and start editing the file, the save button greys out as soon as I add text.
Is there another way to add users to a zone?

@lfrank It will be grayed out if the yaml doesn't adhere to the spec. See what happens when you add a complete and proper record.

Ah, got it. Thanks...
On Apr 19, 2023, at 3:53 PM, Jeremy Magland<EMAIL_ADDRESS>wrote:
This Message Is From an External Sender
This message came from outside your organization.
@lfrankhttps://urldefense.com/v3/__https://github.com/lfrank__;!!LQC6Cpwp!sRdvYccEJ9hsbXSOexP2RQt6R2W_WfwwIQem9jC0sgCA3j-fSsCSuCXB5WXiPf47WYAgCMKunrYCOOtiQXDpl7x9Dg$ It will be grayed out if the yaml doesn't adhere to the spec. See what happens when you add a complete and proper record.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/flatironinstitute/kachery-cloud/issues/18*issuecomment-1515482107__;Iw!!LQC6Cpwp!sRdvYccEJ9hsbXSOexP2RQt6R2W_WfwwIQem9jC0sgCA3j-fSsCSuCXB5WXiPf47WYAgCMKunrYCOOtiQXB526uoiQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABV4PSIS4CGQ626THI2DXOTXCBUFVANCNFSM6AAAAAAXEV3MNY__;!!LQC6Cpwp!sRdvYccEJ9hsbXSOexP2RQt6R2W_WfwwIQem9jC0sgCA3j-fSsCSuCXB5WXiPf47WYAgCMKunrYCOOtiQXAG8Xxg4A$.
You are receiving this because you were mentioned.


Add a simple keyboard containing only the letters to type the word

Add a keyboard containing only the letters/characters that build the word. i.e class, need to provide a keyboard containing c,l,a,s .

Added.


fix(router): add test for deactivation when router outlet is missing

I've also signed the CLA so merging this shouldn't be a problem.

@vincentjames501 thanks for contributing! I took the liberty of fixing some indentation issues in your commit that made the linting step fail in the CI.

D'oh! Thanks bud. Looks like angular will keep our thing with a bad cla label. You may want to just recommit this commit in your name so the CLA is yes and hopefully the Angular team doesn't ignore it. I give you permission!


Question about pre-training a Task

I have trained a model for a given task and now I want to pre-train the network with a large-scale data set to see if it improves performance. Is there an easy way to transfer all the pre-processing parameters from the original task to the pre-training task? The only difference is the detection classes. The original Task only has instances of one detection class (abdominal bleeding), while the pre-training task has instances of 21 different classes (organ landmarks).
Any help here would be very welcome!

Dear @NataliaAlves13 ,
there is currently no pre-implemented way to transferring model weights between tasks but it shouldn't be too difficult to implement that logic. The exact complexity will differ depending on what you are planning to transfer, i.e. encoder weights, encoder + decoder weights or the entire architecture (probably requires exchanging the detection and regression layers at the end of the detection head).
Best,
Michael


INSUFFICIENT_FUNDS when publishing operation starts

Description
During publishing the test material (JPEG image), I and my colleague had the following message on the console:
[DEBUG]::Error Message insufficient funds for intrinsic transaction cost (transaction="0x02f9015383aa36a780843b9aca00843b9aca7283055730941fa4c72680af35fe1eb7345509e39498be6ce03b80b8e4c88efd15598b24f8f8c69e1f2ff548150185e0790706a184f3f517e25eee58827aa051a10000000000000000000000000000000000000000000000000000000000000080626574610000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000000250f0155122080e37307f6a588c4c829630f43d29ac8f9777de193c779adc5f9fccf42f7d8bf000000000000000000000000000000000000000000000000000000c080a080a6d266b2e35601ea130cfd569a08a23b20aebfb4e0d6939d911ade5de65469a0170399e287b013ea04549e942c4fd018df53ce86df6ba0a2ef0368942594678a",
info={ "error": { "code": -32000,
"message": "insufficient funds for gas * price + value: balance 0, tx cost<PHONE_NUMBER>00000, overshot<PHONE_NUMBER>00000" }
}, code=INSUFFICIENT_FUNDS, version=6.10.0)

This brakes the publishing pipeline, and it looks like an internal blockchain problem

How are you publishing? Because this shows that you don't have sufficient funds in your wallet to finalise the publishing process.


The req documentation incorrectly states that we default to md5 (1.0.2)

Just remove that statement. It's not been true since 2005.
This is the 1.0.2 version of #6905.

Pushed. Thanks.


add src to npm package

Hello @gerbenmeyer!
Would you consider to add src to npm package,
so it became possible to direct import components.
Here example from vis.js

Sure, will do that in the next version

And it's there :smile:


Feature/issue 424

Simply skips assignment if the variable is named "_"

@ear7h Can you add some tests on VM side as well?

@ear7h I hope you can also add integration tests in VM's TestAssignmentEvaluation

@st0012 doh

@ear7h This is quite useful, thanks!


HSEARCH-4240 Separate artifacts for compatibility with Jakarta EE 9.1 (Jakarta Persistence 3)

https://hibernate.atlassian.net/browse/HSEARCH-4240
This creates additional Maven artifacts, which are copies of some of the current ones, except their artifact ID is appended with -jakarta (e.g. hibernate-search-mapper-orm-jakarta), and they use Jakarta APIs instead of Java EE APIs.
This is done through source transformation and recompilation. Dependencies of the new artifacts are different (pointing to Jakarta APIs instead of Java EE ones, as well as Hibernate ORM's -jakarta artifacts). References to javax. packages in the source code is replaced with references to jakarta. packages. Same for XML namespaces.
I used source transformation instead of bytecode transformation because:

It seems safer and easier to debug. If something is wrong, it likely won't compile, and then you just look at the generated source code to find out what's wrong exactly.
We don't need all the power that bytecode transformation provides, because we're don't have as much coupling to JPA as Hibernate ORM.
I hope to use the same solution for ORM6-specific artifacts, which will not only need replacements of packages (since ORM 6 will use Jakarta APIs), but also a few patches to address backwards incompatible SPIs or APIs. With source transformation, I could add patch files to the repository, and have the build apply these patches before compilation.

I also did the source transformation for integration tests, which guarantees that these new artifacts work correctly. To check that the source code actually uses Jakarta APIs, just run mvn clean install -DskipTests, then have a look at the code in target/copied-sources: this is the one that get compiled, then executed in tests.
Note that I did not add the new artifacts to the distribution ZIP, on purpose: it's too much hassle, and since this is an experimental feature anyway, it's unlikely to be needed by people who still don't use Maven in 2021.

I used source transformation instead of bytecode transformation because:

this was great!

Merged, thanks!


Faster training with token downsampling

This PR adds support for training with token downsampling and replaces my token merge PR (#1146).
Token downsampling is a lossy optimization that significantly speeds up inference and training. It tries to avoid the quality loss of token merging by only downsampling K and V in the attention operation (Q is preserved) and replaces the expensive token similarity calculation with simple downsampling.
Applying the optimization during training seems to have less quality loss compared to inference, so I was able to increase the amount of downsampling a lot without negative effects.
With a downsampling factor of 2 and resolution of 768px I get a 2x speedup for SD1.x LoRA training.
Downsampling at both levels with factors 4 and 2 gave me an even bigger 3.2x speedup with no visible quality loss. I'm not sure how much this is affected by dataset, so YMMV.
SDXL benefits less because its architecture is already more efficient, but I still saw about 1.3x speedup at 1024px with downsample factor 2.
This PR adds two new flags:

--todo_factor: (1 or 2 floats) token downsampling factor(s). The inputs of the unet's self-attention layers are scaled down by this factor. 2 values can be provided for SD1/2 to set downsampling factor for depth_1 and depth_2.
--todo_args: (list[str]) pass "key=value" args to ToDo. See list below.

Advanced options:

downsample_factor_depth_1: (float) amount to downsample in 1st down block of unet.

Default: --todo_factor
Note: Does nothing for SDXL because it doesn't have this block.

downsample_factor_depth_2: (float) amount to downsample in 2nd down block of unet.

SD1/2 default: 1 (no downsampling) or --todo_factor if a second value is given
SDXL default: --todo_factor

downsample_method: (str) torch.nn.functional.interpolate mode argument for downsampling.

Default: nearest-exact

Sample usage:
--todo_factor 4 2 --todo_args "downsample_method=nearest-exact"
The unet is patched when the model is loaded, so the optimization should automatically work with all training scripts, but I only tested train_network.py and sdxl_train_network.py.
The downsampling operation is implemented with pytorch forward pre hooks, so model saving should be unaffected.
Example:

Name
Downsample factors
s/it
Speedup

feffy-v3.50
None
2.0
1x

feffy-todo2
2/1
1.0
2x

feffy-todo4_2
4/2
0.63
3.2x

Training details:

7900 XTX with --mem_eff_attn
768px resolution with bucketing
Batch size 4

Very impressive improvement in speed as well as maintaining training quality.
Additionally, when I use --todo_args "downsample_method=nearest-exact", a parameter parsing error occurs, but it does not affect anything since it is the default value

@gesen2egee I see the problem and pushed a fix.
To be honest, --todo_args doesn't seem necessary. It's a leftover from the research code which had a lot more options. Here it's only needed for downsample_method, and the default method already works so well that there isn't much reason to use a more expensive interpolation mode. I could remove it and simplify the code

Ok I think that settles it. I'll go for simplicity

このPRは私のRX 6600上で完璧に動作しています!
This PR works perfectly on my RX 6600!

Hi, Very interesting, could you add that to the flux lora training aswell? or is it straight forward?


go-demo-6 to 1.0.35

Promote go-demo-6 to version 1.0.35

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Expose webpack build stats (like hash) for plugins

What problem does this feature solve?
I'm trying to build a plugin that would write webpack build hash in a file that a backend framework (in this case Django) could read for better integration between front and backend. The current UI app reads the generated stats JSON and then deletes it, but I haven't found a way to hook into this data. It would be useful to be able to get either the hash or the full webpack generated stats file in development mode, too.
What does the proposed API look like?
For example, add configuration like: "webpackStats: true" and "webpackStatsFile: 'stats.json'"

I think a plugin like this one should solve this nicely for you.
https://www.npmjs.com/package/stats-webpack-plugin
No need for another config option in my opinion.


Trigger invite flow via comments

Adding an email followed by a trigger  @ | + should show an option to open the invite modal with the email prefilled
Fixes #4639
Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: invite-via-comment

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
51.63 (0.02)
32.38 (-0.09)
29.88 (0.04)
52.1 (0.01)

:green_circle:
app/client/src/actions/applicationActions.ts
75 (3)
100 (0)
22.22 (9.72)
61.11 (2.29)

:red_circle:
app/client/src/api/Api.ts
85.19 (-6.48)
30 (-7.5)
66.67 (-13.33)
85.19 (-6.48)

:red_circle:
app/client/src/comments/CommentCard/ResolveCommentButton.tsx
90 (-0.32)
70 (0)
80 (-3.33)
89.29 (-0.37)

:red_circle:
app/client/src/comments/inlineComments/AddCommentInput.tsx
71.84 (-5.94)
41.67 (-33.33)
63.16 (-3.51)
72.73 (-5.84)

:red_circle:
app/client/src/components/ads/MentionsInput.tsx
66.67 (-1.58)
34 (-28.5)
30 (2.22)
64.62 (-1.45)

:green_circle:
app/client/src/components/editorComponents/form/FormDialogComponent.tsx
82.61 (1.36)
40 (0)
50 (16.67)
80.95 (2.38)

:green_circle:
app/client/src/pages/Editor/EditorHeader.tsx
87.36 (0.15)
46.34 (0)
73.91 (0)
87.06 (0.16)

:green_circle:
app/client/src/reducers/uiReducers/applicationsReducer.tsx
11.54 (1.15)
0 (0)
8.33 (2.62)
12 (1.19)

:green_circle:
app/client/src/selectors/applicationSelectors.tsx
67.11 (1.36)
27.27 (0)
43.48 (2.57)
59.32 (1.43)

/ok-to-test sha=9c5baf2

/ok-to-test sha=9c5baf2


what command can I use to format my file ?

as you posted this in your read-me file I can see you have the sample file (sample.js) which you messed the indentation of it then entered the Visual Block mode and selected the whole file then typed a command which fixed the styling.
What is that command ? I can not figure it out.
the second question how I can make the indent automatic. I tried to open unformatted jsx file in vim after adding the plugin but nothing is changed in the file and It did not get formatted.
however the coloring of the closing tags does work fine and the other configs.

Try the command ggVG= to format the whole source file.
This plugin can automatically indent the new line when you start a new line or press ==. For the pre-existed unformatted file, you might need the command above to format them. It's not a code formatting tool, so if you want the more advanced formatting, you might need the other code formatting tools, like prettier

That was clear.
Thank you, I have already yesterday started to read prettier Repo read-me file and will add it now.
thank you very much.


UI build

#26 #27

Added UI to the project

Hello @Rebelzob
✅ Good job implementing the UI
STATUS APPROVED


feat: mask password param

solves: #60

all parameters which have the word "password" or "secret" are masked in the output

currently the masking is based on the naming of the parameters. there is a new prompt class, which can distinguish between generating a prompt for visible output or executable commands.
todo:

parameters should be part of the prompt, not of commands. so that a command can have multiple prompts (multiline prompts) and each prompts has it's parameter values. if so, we can mark parameters as "secret" and don't have to rely on naming conventions.
history still saves the unmasked password (because of already parsed prompt strings from multiLineCommand)

Was copied in the new #112 password branch as merging was almost impossible.


Extract PathWatcher

Closes #2678
Extract PathWatcher

How could we bypass the ToDo comment error?

See http://checkstyle.sourceforge.net/config_misc.html#TodoComment
Add this check into the checkstyle rules, or edit it if it already exists and set it to issue warnings instead of errors.

Do you know how to make Codacy ignore it?

I removed and restarted the build. Thanks for following up.


bug: White screen on update to to Ionic 4.6.0 ( root element never receives 'hydrated' class)

Bug Report
Ionic version:

[x] 4.x
Current behavior:

The <html> root element never receives the <html class='hydrated'> hydrated class, preventing the application from appearing, even though the app is ready and running. Adding the hydrated class manually causes the app to appear and function normally.
The application builds normally in both dev and --prod modes without warnings or errors. No warnings or errors appears in the javascript console. I'm simply at a loss!
Expected behavior:

The hydrated class should be applied and the application should appear.
Steps to reproduce:

// update from Ionic 4.5.0 to 4.6.0 -- no other changes made to app.
rm -rf node_modules/
npm i -s<EMAIL_ADDRESS><EMAIL_ADDRESS>npm i
// Run application - white screen appears

Related code:

Not currently able to reproduce in a sample app. I'll keep trying but it's not feeling great :)
insert short code snippets here

Other information:

Ionic info:

Ionic:

   Ionic CLI                     : 5.2.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.6.0
   @angular-devkit/build-angular : 0.800.3
   @angular-devkit/schematics    : 7.3.1
   @angular/cli                  : 8.0.3
   @ionic/angular-toolkit        : 1.5.1

Cordova:

   Cordova CLI       : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms : not available
   Cordova Plugins   : not available

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   Android SDK Tools : 26.1.1 (/usr/local/share/android-sdk)
   ios-deploy        : 1.9.4
   NodeJS            : v12.3.1 (/usr/local/Cellar/node/12.3.1/bin/node)
   npm               : 6.9.0
   OS                : macOS Mojave
   Xcode             : Xcode 10.2.1 Build version 10E1001

Also tried updating<EMAIL_ADDRESS>-- no luck.

Hi there,
Thanks for the issue! Is this reproducible using one of the starters? If not, can you give me an idea of what I would need to do to reproduce this issue?
Thanks!

are you using another stencil library other than ionic?

@liamdebeasi Not currently reproducible, and I have absolutely no idea what might be happening so not sure where to start.
@manucorporat Actually yes, I am using ionic-super-tabs... good thinking. Let me try removing that.

https://github.com/zyra/ionic-super-tabs

@manucorporat BINGO. Removing that does seem to get things loading. That's unfortunate. @ihadeed - Looks like an update might be necessary to move to Stencil One? I'm guessing that would be the fix.

@lincolnthree I have a local branch with the Stencil One update ready, just needs some debug code cleanup. Will push/publish it soon.

I'm going to close this since it has been fixed in Stencil, please follow along on issue #18655 for updates on the hotfix release. 🙂

Thank you @brandyscarney !

I am having the exact same issue, but I don't have ionic-super-tabs in my project. Still my root html-element is missing the hydrated class and the screen is white.
This happened completely randomly, like it worked perfectly a week ago. It's hard to reproduce since it's an existing project but here is my ionic info:
Ionic:

   Ionic CLI                     : 5.2.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.6.0
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 8.0.0, ios 5.0.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.1.1, (and 14 other plugins)

Utility:

   cordova-res : 0.3.0 (update available: 0.5.1)
   native-run  : 0.2.3 (update available: 0.2.7)

System:

   ios-deploy : 1.9.4
   ios-sim    : 8.0.1
   NodeJS     : v12.1.0 (/usr/local/Cellar/node/12.1.0/bin/node)
   npm        : 6.9.0
   OS         : macOS Mojave
   Xcode      : Xcode 10.2.1 Build version 10E1001

Dependencies:
"dependencies": {
    "@angular/common": "^7.2.2",
    "@angular/core": "^7.2.2",
    "@angular/forms": "^7.2.2",
    "@angular/http": "^7.2.2",
    "@angular/platform-browser": "^7.2.2",
    "@angular/platform-browser-dynamic": "^7.2.2",
    "@angular/router": "^7.2.2",
    "@bugsnag/core": "^6.2.0",
    "@bugsnag/js": "^6.2.0",
    "@bugsnag/plugin-angular": "^6.2.0",
    "@ionic-native/android-permissions": "^5.5.1",
    "@ionic-native/barcode-scanner": "^5.9.0",
    "@ionic-native/camera": "^5.5.1",
    "@ionic-native/contacts": "^5.5.1",
    "@ionic-native/core": "^5.0.0",
    "@ionic-native/deeplinks": "^5.5.1",
    "@ionic-native/device": "^5.5.1",
    "@ionic-native/facebook": "^5.5.1",
    "@ionic-native/file": "^5.5.1",
    "@ionic-native/file-path": "^5.5.1",
    "@ionic-native/firebase": "^5.5.1",
    "@ionic-native/google-analytics": "^5.5.1",
    "@ionic-native/in-app-browser": "^5.5.1",
    "@ionic-native/ionic-webview": "^5.5.1",
    "@ionic-native/keyboard": "^5.5.1",
    "@ionic-native/splash-screen": "^5.0.0",
    "@ionic-native/status-bar": "^5.0.0",
    "@ionic/angular": "^4.3.1",
    "@ionic/storage": "^2.2.0",
    "@ngxs-labs/async-storage-plugin": "0.0.1",
    "@ngxs/logger-plugin": "^3.4.3",
    "@ngxs/storage-plugin": "^3.4.3",
    "@ngxs/store": "^3.4.3",
    "cordova-android": "^8.0.0",
    "cordova-ios": "5.0.1",
    "cordova-plugin-add-swift-support": "^2.0.2",
    "cordova-plugin-android-permissions": "^1.0.0",
    "cordova-plugin-camera": "^4.0.3",
    "cordova-plugin-contacts": "^3.0.1",
    "cordova-plugin-device": "^2.0.2",
    "cordova-plugin-facebook4": "^4.2.1",
    "cordova-plugin-file": "^6.0.1",
    "cordova-plugin-filepath": "^1.5.4",
    "cordova-plugin-firebase": "git+https://github.com/dpa99c/cordova-plugin-firebase.git#GH-1057-April-05-android-build-issue",
    "cordova-plugin-google-analytics": "^1.8.6",
    "cordova-plugin-inappbrowser": "^3.0.0",
    "cordova-plugin-ionic-keyboard": "^2.1.3",
    "cordova-plugin-ionic-webview": "^4.0.1",
    "cordova-plugin-splashscreen": "^5.0.2",
    "cordova-plugin-statusbar": "^2.4.2",
    "cordova-plugin-whitelist": "^1.3.3",
    "cordova-sqlite-storage": "^3.2.0",
    "core-js": "^2.5.4",
    "ionic-plugin-deeplinks": "^1.0.19",
    "konva": "^3.2.5",
    "moment": "^2.24.0",
    "rxjs": "~6.5.1",
    "tslib": "^1.9.0",
    "zone.js": "~0.8.29"
  },

@timmyrosen Could you please try out the dev build and let me know if that fixes it? npm i @ionic/angular@dev

Hi there,
I've got the same issue when upgrading to 4.7 (from ^4.4)
It seems that the hydrated class is not applied to the html element if no ionic custom elements are present on the page at init.
I'll just override `html:not(.hydrated) body { display: none; } for now...

@QuentinFchx Can you please create a new issue?


Ghost 1.5 compatibility

Hi Kelvin,
Great theme, thanks! Some simple changes I made for my personal b log to make the theme work on Ghost 1.5, feel free to borrow if useful.
Geert-Jan

Thanks for the change and sorry for the delay! I have pulled this request and this should now be available as part of the latest v3.0.0 release.
Because this release was done to support the new Ghost v1.*  update, please let me know if you run into any issues.


Table option wont' work

The options table wont work**
Also the table work only with Chrome- Error from FF and Safari
this my table setup
  <DataTable
        striped // -> not striped the rows
        withTableBorder // -> not border the table
        withColumnBorders // -> no column border appear
        borderRadius="sm" // -> no border radius
        highlightOnHover // -> no highlight the rows
        verticalSpacing="xs" // -> works well
        fz="xs" // -> works well
        verticalAlign="center" // -> works well

        rowExpansion={} // -> works well

Chrome with no options rendered

Firefox Error

I have Mantine 7 in React application
My index tsx
import React from 'react';
import ReactDOM from 'react-dom/client';
import App from './App';
import { createTheme, MantineProvider } from '@mantine/core';
import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>import 'mantine-datatable/styles.layer.css';
import './layout.css';

const theme = createTheme({
  /** Put your mantine theme override here */
});

const root = ReactDOM.createRoot(
  document.getElementById('root') as HTMLElement
);
root.render(
  <MantineProvider theme={theme} defaultColorScheme="dark">
  <React.StrictMode>
    <App />
  </React.StrictMode>
  </MantineProvider>
);

So can help me to sovle this issue
Thanks

Hey @sundsx,
You can check that striped, withTableBorder withColumnBorders, borderRadius and highlightOnHover attributes work perfectly on this page in the documentation (which is actually a Next.js application):
https://icflorescu.github.io/mantine-datatable/examples/basic-table-properties/
As you can see, that page works in all browsers - which means there must be an error somewhere else in your code.
Since it's not a bug in Mantine DataTable, I am going to covert this issue to a discussion and perhaps somebody will be able to point you in the right direction.
Related to your code, I don't understand:

why are you importing the Mantine core styles twice - once the standard version, once the layers version?
How are you controlling the order of layers? What's the content of your layout.css?


Release build gets stuck on device

I made release build (android) according to this docs: https://flutter.io/android-release/
But it gets stuck when I run it on device (everything is ok on emulator).
Debug build works ok for both emulator and device.
Code sample: https://gist.github.com/MariaMelnik/9faa74b34dce2930399059b8d15acb29
Android version on device 8.0.0
Flutter doctor:
[✓] Flutter (Channel beta, v0.8.2, on Mac OS X 10.13.6 17G65, locale en-RU)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
[✓] Android Studio (version 3.1)
There is another issue with this code example (not sure if it is related to this): https://github.com/dart-lang/sdk/issues/34473

@a-siva - not sure if this should be filed on vm or moved to flutter.

Note that https://github.com/dart-lang/sdk/issues/34473 deals with 5x "slowness" of AOT compared to JIT.  Does "stuck" mean it takes a long time, or does it really never terminate?

Note that #34473 deals with 5x "slowness" of AOT compared to JIT. Does "stuck" mean it takes a long time, or does it really never terminate?

Yes, it is not slower 5x or 10x (even 100x) it just gets stuck.
Release build slower then debug build (but works) on emulators.
But release build gets stuck on devices. It doesn't work at all.

I have finally had a change to try this on the real device (I have Nexus 5x).
I added a print to see if the loop inside convert was making any progress like so:
    for (int i = 1; i <= l; i++) {
      final sw = Stopwatch()..start();
      for (int i = 0; i < c; i++) {
        U_i = hmac.convert(U_i).bytes;
      }
      print('took ${sw.elapsedMilliseconds} ms');
    }

and I have gotten the following:
─ ~/src/flutter/flutter/examples/hello_world ‹master*›
╰─$ flutter run --release -t lib/main.dart --target-platform android-arm
Initializing gradle...                                       0.8s
Resolving dependencies...                                    1.7s
Launching lib/main.dart on Nexus 5X in release mode...
Gradle task 'assembleRelease'...
Gradle task 'assembleRelease'... Done                       23.7s
Built build/app/outputs/apk/release/app-release.apk (5.0MB).
Installing build/app/outputs/apk/app.apk...                  3.8s

To quit, press "q".
I/flutter ( 6733): took 18834 ms

I/flutter ( 6733): took 37019 ms
I/flutter ( 6733): took 44640 ms
I/flutter ( 6733): took 20295 ms
I/flutter ( 6733): took 38270 ms
I/flutter ( 6733): took 42919 ms

So I think nothing really gets stuck - it's just we are really-really bad on ARM32 which is #34473

Duplicate of #34473


Ceph (RBD) trash support

Description
Since Ceph Luminous (12.2.x) there is support for putting RBD images in a "trash" bin (namespace). Instead of directly deleting an image from a pool the image can be put in the "trash" instead.
Use case
By putting an IMAGE in the "trash" it provides the user / admin the possibility to undo unwanted delete actions without relying on backups. This might avoid accidental data loss in case someone accidentally deletes an IMAGE or a TEMPLATE including disk images.
Interface Changes
This change will need adjustments from drivers, Sunstone as well as CLI / API commands. An overview of IMAGES in "trash" as well as a way to definitively get rid of them.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Merge to master:

https://github.com/OpenNebula/one/pull/3341
https://github.com/OpenNebula/infra/pull/258
https://github.com/OpenNebula/development/pull/627
https://github.com/OpenNebula/docs/pull/627

Hi @hydro-b
The target implementation is roughly as follows:

New CEPH_TRASH attribute for the ceph datastores

Hi @hydro-b
Overview of the implementation

New CEPH_TRASH attribute for the datastores and disk
A disk includes CEPH_TRASH = yes all rbd rm operations are replaced by rbd trash move
This attribute can be set per DISK to only move to trash that given disk, or globally at DS level
When a disk contains snapshots all the snapshots are also moved to trash

Compared with your original request we are not implementing an OpenNebula side inspection of the CEPH_TRASH.


fix: have a timeout on the wait when closing BigtableIO#Writer

Batcher#closeAsync already sends out remaining elements and wait on them to finish before closing. Calling closeAsync let us set a timeout on the future and it should not take longer than the operation timeout.
Another hang seems to come from calling service.close() in tearDown. Since we create the service in startBundle, closing the service in finishBundle addresses the issue.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Java Tests failures were a hiccup earlier today not related


Cosmos documentation draft

First version of the Cosmos integration docs.

@kruspy Let's change the base branch to something other than main (so the main branch can reflect the upstream main).


Single SparkContext parallelization

#331
Using multiple SparkInterpreters causes an exception because each SparkInterpreter creates its own SparkContext, but there can't be more than 1 SparkContext in one JVM. This PR adds some logic to share a SparkContext by creating a pool for each SparkInterpreter. Ideally, each interpreter runs in its own JVM, but I see that's under consideration #278, so this is intended as a temporary workaround until that happens.
There is one problem though. If multiple SparkInterpreters share the same SparkContext, it's not possible to close the SparkContext when closing one of the SparkInterpreters, so once a SparkContext is created, changes can't be made. Are there comments about how to best address this?

Thanks for deep consideration about internal.
To handle that problem, i think counting number of reference to SparkContext and close SparkContext when they become Zero, is one available way. That counter can increase value inside of open() and decrease it's value inside of close().
By the way, isn't it already possible to use single SparkContext by creating single interpreter setting and bind it across all notebooks?

Thanks for the comments. I was considering the counter idea just earlier. It does mean still mean that a SparkContext can't be changed until all interpreters are closed though.
It is possible to use a single SparkContext by binding a single interpreter to multiple notebooks. But the problem I'm trying to address with this PR problem is providing concurrent execution when there are multiple Spark interpreters. Since all the interpreters are in the same JVM, they can't have their own SparkContext, and must share it.
Binding a single interpreter to all notebooks also has the problem where all jobs go into the same pool, so it's one one fewer way of sharing resources to different jobs. With different interpreters, each with a different pool (or SparkContext), there is more control on resource sharing.

@cdfhuang Thanks for explanation. I think using single SparkContext to leverage it's fair scheduler is good idea. I tested this code and found a problem.
Let's say i have SparkInterpreter a and b and they use singleton SparkContext. Each SparkInterpreter embeds their own scala compiler. So any lambda function, class definitions are dynamically compiled to *.class file. There're http server for serving these *.class file to spark worker. The problem is SparkWorker always looking for class from class server in SparkInterpreter a (if a initialized first).
Therefore for some lambda function defined in b, Spark worker raise ClassNotFoundException.

@Leemoonsoo  Thanks for your explanation. I did some investigation, and it seems like it's not possible to get around the ClassNotFoundException. Each SparkIMain created by a SparkInterpreter will create its own HTTPServer. But the shared SparkContext is only aware of one of those HTTPServers (set by spark.repl.class.uri).
So I guess this PR will not work, unless there is another workaround. Ideally, I think #278 is the way to solve the concurrent SparkInterpreter issue though.


METRON-1309: Change metron-deployment to pull the plugin from apache/metron-bro-plugin-kafka

Contributor Comments
Based on the conversation on the mailing list, this removes the bro kafka plugin from this repo and pulls it from our new apache/metron-bro-plugin-kafka repo.
Testing

Create a working directory and pull in this PRmkdir ~/metron-1309
git clone https://github.com/apache/metron ~/metron-1309/metron
cd ~/metron-1309/metron
git remote add jonzeolla https://github.com/jonzeolla/metron
git pull jonzeolla METRON-1309

Modify this to remove sensors, (to spin up the real sensors).sed -i '' "s/ansibleSkipTags=.*/ansibleSkipTags=\'quick_dev\'/" metron-deployment/vagrant/full-dev-platform/Vagrantfile

Spin up full-devcd metron-deployment/vagrant/full-dev-platform/
vagrant up

Set up the environment in full-dev.vagrant ssh
sudo su -
export PATH=$PATH:/usr/local/bro/bin
service monit stop && service sensor-stubs stop bro && broctl stop

Monitor the bro kafka topic# Open a new terminal
cd ~/metron-1309/metron/metron-deployment/vagrant/full-dev-platform
vagrant ssh
sudo su -
export PATH=$PATH:/usr/local/bro/bin:/usr/hdp/current/kafka-broker/bin
kafka-console-consumer.sh --zookeeper localhost:2181 --topic bro

In the first terminal, run bro against some public pcaps.mkdir -p ~/brotmp/nitroba ~/brotmp/example-traffic
wget https://www.bro.org/static/traces/exercise-traffic.pcap -O ~/brotmp/example-traffic/exercise-traffic.pcap
wget http://downloads.digitalcorpora.org/corpora/network-packet-dumps/2008-nitroba/nitroba.pcap -O ~/brotmp/nitroba/nitroba.pcap
cd ~/brotmp/example-traffic
bro -r exercise-traffic.pcap /usr/local/bro/share/bro/site/local.bro -C
cd ~/brotmp/nitroba
bro -r nitroba.pcap /usr/local/bro/share/bro/site/local.bro -C

Verify that logs are properly getting to the bro kafka topic, via the second terminal.

Note, that if you look in the Kibana UI for the non sensor-stub logs, you will need to change your view to be ~now-10y.

Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[X] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[X] Have you included steps or a guide to how the change may be verified and tested manually?

[X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

This is ready for review.

+1  Followed instructions, everything worked as expected.  One question, but mostly out of curiosity

Great job @JonZeolla

+1 LGTM.  Thanks!


Changes on Emote/Emoji and SelectMenu

In this request, the name of the Emote was changed to CustomEmoji and all the names of the Emote (for example, IEmote) were changed to Emoji (that is, IEmoji), because these are more correct and understandable names.
Emoji class now has a static TryParse method and the constructor now has an internal modifier.
Label was removed from SelectMenuBuilder, because it does not exist in the api, and Disabled was added to SelectMenu classes and builders.

I would hold off on modifying the DNET base stuff as changing names like that will cause anyone whos going to update to have a lot of errors if they are using emotes/emojis. I would only merge that if it was coming from dnet.
On the other hand, the changes to the SelectMenus look good!

Maybe undo renaming Emote, but save emoji parsing?

Maybe undo renaming Emote, but save emoji parsing?

Yeah, the addition of TryParse is fine, just dont rename any of the emote/emojis stuff as i can already see the Unknown Reference exceptions in the issues tab

I undone renaming. I also wanted to ask, I noticed that the Components property of message interfaces is a collection with IMessageComponent, why it not a ActionRowComponent?

I undone renaming. I also wanted to ask, I noticed that the Components property of message interfaces is a collection with IMessageComponent, why it not a ActionRowComponent?

Discord might add different component roots, and those can be added under the interface


🚀 Feature: Tabs in settings redesign

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Made the desired changes for better Ui/Ux

Why was this change needed? (You can also link to an open issue here)
Fixes: #1285

Other information:

@holopin-bot @AkashJana18  Thank you!


update for tms connected and update url for image

Please review and approve it.

I could not see the dialog box updates in the map component

Done

Have same name and keys in the dialog box.

Renamed as expected


Convert the OverlayManager class to use private fields/methods

Convert the OverlayManager class to use private fields/methods

Change OverlayManager.open to always error if the overlay is already active
The old code would allow an overlay to force close itself, before immediately re-opening itself, which actually isn't very helpful in practice since that won't re-run any overlay-specific initialization code.
Given how the overlays are being used this really shouldn't have caused any issues, but it's a bug that we should fix nonetheless.

/botio-linux preview

Thank you for doing this!


feat: Add GridFS Basic API

Closes https://github.com/denodrivers/deno_mongo/issues/238
Tasks:

[x] Add Interfaces that cover the Basic API
[x] Delete API (was tested)
[x] Upload (was tested)
[x] Download (was tested)
[x] Find (was tested)
[x] Add missing Index checks
[x] Add Tests

deno.land has currently some issues and I can't really control that, but the work is done

@erfanium do you want to review it?

Nice work!


Local k3s upgrade should not be allowed on single node install

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Versions seen:
v2.5-ac483705ad321e9bdfc868bcf72a0c6ca167d7e1-head and v2.5.5

Spin up a rancher single install on 2.5.5 and 2.5-head
Once the rancher is active, from the local cluster, edit and upgrade the k3s to the newer version and save.
The local cluster is in updating state forever.

Result:
Local cluster upgrading should be disabled.
Other details that may be helpful:
https://github.com/rancher/rancher/issues/29412

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.5-ac483705ad321e9bdfc868bcf72a0c6ca167d7e1-head and v2.5.5
Installation option (single install/HA): Single

Component | Version
Rancher | v2.5.5
User Interface | v2.5.4
Helm | v2.16.8-rancher1
Machine | v0.15.0-rancher49
Rancher | v2.5-ac483705ad321e9bdfc868bcf72a0c6ca167d7e1-head
User Interface | v2.5-dev
Helm | v2.16.8-rancher1
Machine | v0.15.0-rancher49

I see this problem as well... It just keeps running a ugprading cycle

I see this problem as well... It just keeps running a ugprading cycle

As linked in description, this looks like a regression of: https://github.com/rancher/rancher/issues/29412

@cbron looks like it.
But how do I set it back to the original version, so it dosen 't enter the endless upgrade loop?

@hornbech I haven't looked into this specific case yet but there are some comments on the various issues about solving it.
Otherwise you can always try reloading from a backup.

I believe this problem is specific to embedded k3s that comes with docker installs, as was https://github.com/rancher/rancher/issues/29412. It seems like it may be related to the UI, I don't see anything that would caused that is different in the backend. When I run a docker install of v2.5.5, then set ui-offline-preferred to false, then set ui-index to https://releases.rancher.com/ui/2.5.3/index.html, upgrade options no longer appear. My assumption is that the UI used to check if the cluster had a k3sConfig (the embedded cluster does not on startup), but no longer does so the upgrade options appear. Once submitted the cluster does have this field.

On master-head - commit id: eac20a5ee and 2.5-head - commit id: 761c805d

Local cluster --> Edit --> K8s version dropdown is not available.

https://github.com/rancher/rancher/issues/29412#issuecomment-813526642

Even though this is listed as a UI issue, it's possible Ricky may be able to sort out something on the backend.

The UI fix for clusters that have a null k3sConfig (only way to tell this is a docker installed cluster) have been merged. K3s clusters that meet this criteria will no longer see the cluster options section that allows  users to change the version, drain options, and concurrency options. The user can still save the cluster to change fields not on the k3sConfig.
I believe there are some backend changes incoming as well that will prevent editing a null config at the api level as well. @rmweir is this correct?

Testing:
Will want to make sure the option to upgrade does not appear in the UI and that it is not possible to add a k3sConfig to an embedded cluster through the API.

Test report:

I was able reproduce the issue on rancher:2.5.5 (infinite loop of upgrades)

Fix validated on singlenode docker k3s deployment by using image rancher/rancher:v2.5-head commit 9b0058c (docker image id: 88ba240394dc)

UI Test:
The option for k8s upgrade disappeared from Edit Cluster Dialog:

Before (2.5.5):
After (v2.5-head):

API Test:
The upgrade over k3sConfig key in API is not possible anymore:

Before (2.5.5):
Request over API Edit:

k3sConfig: {
  "kubernetesVersion": "v1.19.9+k3s1",
  "type": "/v3/schemas/k3sConfig"
}

Response 200 OK -> infinite loop of upgrade visible in Ember UI

After (v2.5-head):
Request over API Edit:

k3sConfig: {
  "kubernetesVersion": "v1.20.5+k3s1",
  "type": "/v3/schemas/k3sConfig"
}

Response 422 Error -> Upgrade not triggered:
{
"baseType": "error",
"code": "InvalidBodyContent",
"message": "k3sConfig cannot be changed from nil",
"status": 422,
"type": "error"
}

@rmweir It works as expected, but I have two questions:

Is the Error 422 from API when trying upgrade ok?
Is it desired that the k3sConfig value field is "null" but still editable in API Edit? Shouldn't be the field imutable/inactive instead?

Also the upgrade is now not possible on k3s rancher/rancher:master-head commit 698590b (docker image id: 654ff50c873e)

Fields for upgrade over UI not visible anymore
Upgrade over API:

Request (current k8s version v1.19.8+k3s1):
k3sConfig: {
  "kubernetesVersion": "v1.20.5+k3s1",
  "type": "/v3/schemas/k3sConfig"
}

Response Error 422 -> Upgrade not triggered:
{
"baseType": "error",
"code": "InvalidBodyContent",
"message": "k3sConfig cannot be changed from nil",
"status": 422,
"type": "error"
}

According to Ricky the Error 422 is fine (from Slack). Closing.


Modifying the ExternalService configuration will affect the corresponding ServiceEgressRule setting

I have a ExternalService and a corresponding ServiceEgressRule, like this:
CES release: 0.5.3:
ExternalService:
kind: ExternalService
apiVersion: kubeovn.io/v1alpha1
metadata:
   name: es-test
   namespace: default
spec:
  addresses:
    - <IP_ADDRESS>
  ports:
    - name: tcp-443
      protocol: TCP
      port: "443"

ServiceEgressRule:
apiVersion: kubeovn.io/v1alpha1
kind: ServiceEgressRule
metadata:
  name: ser-test
  namespace: default
spec:
  service: nginx-service-root
  action: accept-decisively
  logging: true
  externalServices:
    - es-test
  logging: true

After modifying the ServiceEgressRule configuration and applying the change, for example change the "address“ from "<IP_ADDRESS>" to "<IP_ADDRESS> and <IP_ADDRESS>", the "source" setting of the corresponding ServiceEgressRule in AFM will be changed to "Any", like this:
before:

after:

Thanks.

fixed in the new 0.5.3. pls try. thanks


Detect when numbers are used as keys in Mappings

cfn-lint version: 0.5.1
Description of issue.
Given the following template:
Mappings:
  AccountMap:
    # Dev
<PHONE_NUMBER>12:
      Some: Foo
    # Prod
<PHONE_NUMBER>21:
      Some: Bar

this should raise an error because the account ids have to be quoted.

Quickly validated that... And you're completely right, good find! 👍
Template validation error: Template format error: [/Mappings/AccountMap] map keys must be strings; received numeric [123456789012] instead ```

This issue can be closed, I think.

👍Awesome! Thanks pointing it out.


Allow string enums to use set string values in stringer function

This MR is related to #7
This makes it so that if a enum is of type string it will use the given values in the enum definition.
type Day string

const (
    Unknown Day = "Uknown" //enum:invalid
    Monday  Day = "MonDay"
    Tuesday Day = "Tuesday"
    Wednesday Day = "wednesDay"
    Thursday Day = "Thursday"
    Friday Day = "Friday"
    Saturday Day = "Saturday"
    Sunday Day = "sunday!"
)

This will become the following stringer function
func (day_enum Day) String() string {
    switch day_enum {
    case Unknown:
        return "Uknown"
    case Monday:
        return "MonDay"
    case Tuesday:
        return "Tuesday"
    case Wednesday:
        return "wednesDay"
    case Thursday:
        return "Thursday"
    case Friday:
        return "Friday"
    case Saturday:
        return "Saturday"
    case Sunday:
        return "sunday!"
    default:
        panic(fmt.Sprintf("no default for enum %T, invalid value: '%#v'", day_enum, day_enum))
    }
}

There is one issue that i found could happen, namely that if someone did not fill in all string values in the enum like so:
type Test string

const (
    Unknown Test = "Uknown" //enum:invalid
    Value1  Test = "test1"
    Value2 Test = "test2"
    Value3
)

It would cause a error in the switch case. thats why i added a loop to check for unique values. in general i think this is good to have to prevent duplicate values in enums because i would say enum values should be unique.
Let me know if things need added or changed.

@lucvankessel enum values not being unique is a fairly common usecase to provide aliases:
const (
  Monday Day = iota
  Tuesday
  Wednesday
)

const (
  mandag Day = iota
  dinsdag
  woensdag
)

@Daan-Adrichem and I had a brief discussion about this issue the other day. Maybe we can continue that here.
I personally don't have an issue with this approach as I cannot see a use case for having a stringly typed enum with generated enum keys. I would however argue that  maybe we want to avoid implementing a stringer on stringly typed enums at all.
So rather than calling .String() directly, we use fmt.Sprint to format the enums.

@lucvankessel @olistrik the point about go-enum is to decouple internal and external values. Using the internal value as the external value removes this abstraction. Where I agree with the sentiment, I disagree with always coupling string enums to their internal values. Adding a flag could do the trick, I have made such a pull-request before. That was limited to some of the marshallers which work without specific string layouts (if I remember correctly everything except ent). That could be extended for string values to include ent. Personally I would suggest to use go-enum to setup basic data validation but create a single marshaller that allows these odd-ball strings. That way the developer (in this case @lucvankessel ) does not wast any time but it does not influence the entire enum.

Maybe changing from using switch cases to if statements?

@lucvankessel  I think making the switch generation smart enough to not include duplicates would also be sufficient.
@dadrichem this isn't related to ent. We're communicating with another API over REST that has inconsistent casing in their own enums.
As this is purely a mapping of an inconsistent enum that is outside our control, I'd argue that any generation of keys is undesirable. Which is why I suggested perhaps not generating a stringer interface and using Sprint Vs .String() directly.
There's two ways we can facilitate this;

a flag such as -case=custom
Not generating a stringer for already string enums.

I personally lean towards 2 because I can't think of a use case where this behaviour is desirable by default:
const (
  Monday Day = "Maandag"
)

var foo Day = Monday
var bar String = "Monday"

fmt.Printf("%s == %s: %t\n", foo, bar, foo == bar)
// Monday == Monday: false


Add an ability to replay and loop FIFO data

In-line with this VERA PR: https://github.com/X16Community/vera-module/pull/11

Wait, this is not applied to hardware yet. I should've changed this to draft first.

Is the PR already submitted to VERA? It's okay to have the emulator lead VERA a little, bit, as this is unreleased code. If this is not resolved by the time we're looking at releasing R44, then we can revert this commit.


OnKeyPressed wishlist

Show a warning if two plugins use the same bind
Show which plugin a keybind is from
Hide vanilla keybinds when they're disabled
Fix #8

Keybinds should be a lot better with the latest commits, make a new issue if anything else is needed


Use underscore convention for "unexported" rules

If a rule uses the underscore convention for "private" rules (i.e. _foo := "bar") , we should warn if that's not used within the same policy, or imported / referenced from another policy.

We could also do simple unused checks on these, as we wouldn't need to scan more than the same AST.
We could perhaps forbid annotations on these as those should document the public API?


switch to https

Since today all API requests require the https protocol

Coverage remained the same at 99.63% when pulling dd24d207a178d59400a20c199e01d3d0118832d1 on nicolaracco:master into 25406e63747df33307accfdd4a87c4f88a64edf9 on mikamai:master.


Adding box-shadow on the editor seems to fix issue #38

Current coverage is 86.25% (diff: 100%)

Merging #39 into master will not change coverage

@@             master        #39   diff @@
==========================================
  Files            15         15
  Lines           320        320
  Methods          53         53
  Messages          0          0
  Branches         42         42
==========================================
  Hits            276        276
  Misses           44         44
  Partials          0          0

Powered by Codecov. Last update 23f5aae...16efa6a

I tested this and it does not fix the issue that you stated. The fix will require changes in the focus/blur behaviour of the editor.

mmm too bad... I thought it was odd too.
Works great on my computer though. I will need to have a deeper look on all the mechanism.


Add summary of adapter trimming, similar to cutadapt (example attached)

cutadapt-trimmed.txt

That would make me change to skewer. Need the detailed report for each sequence I add in the adapters.fa


Write something about the different requirements of DS consumers

As noted in

https://github.com/fonttools/fonttools/issues/1655#issuecomment-505388564
https://github.com/fonttools/fonttools/issues/1631

Also fix the code sample at the beginning of the specification.
Todo:

Cross-check information with information from http://letterror.com/dev/mutmath_varmod/ and https://github.com/googlefonts/fontmake/issues/264

I think this should be part of a larger spec refactoring/updating, closing for now.


Rails 7.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

70 of 70 (100.0%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1047

Relevant Lines:
1047

💛  - Coveralls


Add Command to Set Logging/Filter Rules at Runtime

Description
This PR adds the /c2:loggingrules command. You invoke it like this: /c2:loggingrules chatterino.*.debug=true chatterino.http.debug=false. This will apply both rules. I'm not too sure about the command name/prefix/namespace (my thinking was to have this behind a namespace/prefix, so it's clear that this is a Chatterino command).
This command is mainly for debugging release builds without restarting - so that you get more logs when you attach a debugger/console or even a dedicated program capturing logs.

Thank you!


about cpu and gpu speed

Very excellet job! I have one question. Why your cpu model runs much more faster than gpu model showed in your home page(cpu 200fps, gpu 30 fps). Typically, gpu runs more faster than cpu.

It's not the same model. CPU version uses a lighter model which is provided by dlib. I didn't look into it but maybe it's not even a deep learning model, so it runs a lot faster.

Got it. Thanks!


Updated tutorial-1.rst with Celsius

Simple spelling error, probably due to our author having some other weird unit measure preference.

Well, that's embarrassing. The author is Australian, and uses Celsius natively O_O :-)
Thanks for the contribution!


Iterator without values when debugging

From @carlosbira on July 17, 2017 13:14
Environment data
VS Code version:  1.13.1 (1.13.1)
Python Extension version:  0.6.7
Python Version:   3.6
OS and version:  Mac OS 10.12.5
Actual behavior
When debugging the result of a mysql.connector cursor, after executing the query to retrieve database data, although the internal variables of the cursor display that there were rows in it, the iterator does not return any content (row) at the for loop, skipping it completely since it returns behaves like an empty cursor. When same come is executed outside VS debug environment it works as expected, executing the for loop with the content that was supposed to bring same result when debugging.
Expected  behavior
It should bring the content of each row at each iteration.
Steps to reproduce:
    <import mysql.connector>
    .....

    cursor = connCRM.cursor(buffered=True)
    cursor.execute("SELECT name, title FROM <table> WHERE name = %s", ("content",))
    n = 0

    for (name, title) in cursor:
        print(name)
        print(title)
        n += 1

at the for loop it is skiped. If I use the other possible way, that would be though the use of fetchone(), nothing is returned from cursor.
Settings
Your launch.json (if dealing with debugger issues):

Your settings.json:

Logs
Output from Python output panel

Output from Console window (Help->Developer Tools menu)

Copied from original issue: DonJayamanne/pythonVSCode#1091

From @hjw2015 on September 8, 2017 5:2
+1
Works well if called with Ctrl+F5 also inside VS Code. No result returned from cursor if executed step-by-step.

From @yaoliyc on September 25, 2017 13:4
+1

Closing this issue due to inactivity. If you come across this issue, please reply back with the following issue and re-open the issue:
provide a sample repo (code) with instructions to replicate this issue.


Relax Content-Type enforcement

Catalog is not currently sending header. Will be followed up
with an issue to correctly add back in when supported.

Closing since I'm not sure we really want to merge this to master yet.

Yeah let's not merge this into master.


ADMIN: Delete Announcement -> PHP Error shows up when you type the method for deleting announcements in the browser

Original issue: https://github.com/ejmstark/event_system/issues/418

commit id: c583e49aeeae3b6b46f71fa6caadfb18ed5d03e6


values in the output tensor

Hi, i have a frozen_graph pretrained model. and i what to know values in the output tensor in this model. How can i print it? maybe who know.

Closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Fix: do not try to parse a rsa key if algo is hmac

example config:
definitions {
  jwt "JWTToken" {
    header = "Authorization"
    signature_algorithm = "HS256"
    key = "asdf"
  }
}

before:
panic: loading jwt "JWTToken" definition failed: asn1: syntax error: truncated tag or length

(or different messages depending on length of the key).
after: couper starts and can validate tokens from jwt.io with that key.


Error when importing omnipath?

Hi,
I recently installed omnipath via "pip install omnipath" in a conda environment with python 3.6, but when I try to import it, I get the following error:

import omnipath
Traceback (most recent call last):
File "", line 1, in
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/site-packages/omnipath/init.py", line 2, in
from omnipath._core.utils import options  # from_first in isort is important here
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/site-packages/omnipath/_core/utils/init.py", line 1, in
from omnipath._core.utils._options import options
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/site-packages/omnipath/_core/utils/_options.py", line 8, in
from omnipath.constants import License
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/site-packages/omnipath/constants/init.py", line 1, in
from omnipath.constants._constants import License, Organism, InteractionDataset
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/site-packages/omnipath/constants/_constants.py", line 75, in
class License(PrettyEnumMixin):
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/site-packages/enum_tools/documentation.py", line 76, in document_enum
func_source = dedent(inspect.getsource(an_enum))
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/inspect.py", line 973, in getsource
lines, lnum = getsourcelines(object)
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/inspect.py", line 955, in getsourcelines
lines, lnum = findsource(object)
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/inspect.py", line 768, in findsource
file = getsourcefile(object)
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/inspect.py", line 684, in getsourcefile
filename = getfile(object)
File "/Users/jshi/miniconda2/envs/pypath2021/lib/python3.6/inspect.py", line 654, in getfile
raise TypeError('{!r} is a built-in class'.format(object))
TypeError: None is a built-in class

This is from an installation on a Mac, but I've also tried installing on Linux with the same behavior. Wondering if this is a known issue and what the reason is? Thanks!

Hi @jadeshi,
This module requires Python 3.7 as it uses more recent features of the standard library.
Python 3.6 is a quite old version, reaching its end of life in 9 months from now. I recommend to use omnipath with the current version 3.9 or at least 3.7. In Python 3.6 I could reproduce the error above, while in Python 3.7 I could import the module with no error.
Best,
Denes