The expanded size of the tensor (4096) must match the existing size (35551) at non-singleton dimension 1. Target sizes: [9, 4096]. Tensor sizes: [9, 35551]

Self Checks

[X] This is only for bug report, if you would like to ask a question, please head to Discussions.
[X] I have searched for existing issues search for existing issues, including closed ones.
[X] I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[X] Please do not modify this template :) and fill in all the required fields.

Cloud or Self Hosted
Cloud
Steps to reproduce

installed in colab
useTrump_WEF_2018.mp3 as reference audio about 30 mins
put them in examples
execute python -m tools.webui  --llama-checkpoint-path ../checkpoints/fish-speech-1.4 --decoder-checkpoint-path ../checkpoints/fish-speech-1.4/firefly-gan-vq-fsq-8x1024-21hz-generator.pth --decoder-config-name firefly_gan_vq
load the reference audio
input some text
generate

✔ Expected Behavior
No response
❌ Actual Behavior
No response

too long references

ok, i got it

System Info:
ubuntu20.04
python3.10
CUDA Version: 12.4
FishSpeech1.4
I met a similar issue, the log as blow:
`2024-11-06 13:44:39,692 xinference.model.audio.fish_speech 1730377 WARNING Fish speech does not support setting voice: default.
2024-11-06 13:44:39,693 xinference.model.audio.fish_speech 1730377 WARNING stream mode is not implemented.
2024-11-06 13:44:39.693 | INFO | tools.api:encode_reference:133 - No reference audio provided
2024-11-06 13:44:39.702 | INFO | tools.llama.generate:generate_long:436 - Encoded text: 已为您预约会议，详情如下：
会议室主题:如何进行代码审查
会议室地址:第三会议室
会议开始时间:二零二四年十一月六日二十二时零分
2024-11-06 13:44:39.703 | INFO | tools.llama.generate:generate_long:436 - Encoded text: 会议结束时间:二零二四年十一月七日零时零分
2024-11-06 13:44:39.704 | INFO | tools.llama.generate:generate_long:454 - Generating sentence 1/2 of sample 1/1
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1023/1023 [00:56<00:00, 17.98it/s]
2024-11-06 13:45:36,650 xinference.core.model 1730377 ERROR [request 36e9785a-9c02-11ef-8d96-9cc2c4626bed] Leave speech, error: The expanded size of the tensor (968) must match the existing size (1023) at non-singleton dimension 1. Target sizes: [9, 968]. Tensor sizes: [9, 1023], elapsed time: 56 s
Traceback (most recent call last):
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/utils.py", line 78, in wrapped
ret = await func(*args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 854, in speech
return await self._call_wrapper_binary(
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 520, in _call_wrapper_binary
return await self._call_wrapper("binary", fn, *args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 122, in _async_wrapper
return await fn(*args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 541, in _call_wrapper
ret = await asyncio.to_thread(fn, *args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/asyncio/threads.py", line 25, in to_thread
return await loop.run_in_executor(None, func_call)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/model/audio/fish_speech.py", line 211, in speech
result = list(
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 36, in generator_context
response = gen.send(None)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/model/audio/fish_speech.py", line 164, in _inference
raise Exception(str(result.response))
Exception: The expanded size of the tensor (968) must match the existing size (1023) at non-singleton dimension 1. Target sizes: [9, 968]. Tensor sizes: [9, 1023]
2024-11-06 13:45:36,660 xinference.api.restful_api 1728531 ERROR [address=<IP_ADDRESS>:44253, pid=1730377] The expanded size of the tensor (968) must match the existing size (1023) at non-singleton dimension 1. Target sizes: [9, 968]. Tensor sizes: [9, 1023]
Traceback (most recent call last):
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/api/restful_api.py", line 1485, in create_speech
out = await model.speech(
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xoscar/backends/context.py", line 231, in send
return self._process_result_message(result)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xoscar/backends/context.py", line 102, in _process_result_message
raise message.as_instanceof_cause()
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xoscar/backends/pool.py", line 659, in send
result = await self._run_coro(message.message_id, coro)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xoscar/backends/pool.py", line 370, in _run_coro
return await coro
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xoscar/api.py", line 384, in on_receive
return await super().on_receive(message) # type: ignore
File "xoscar/core.pyx", line 558, in on_receive
raise ex
File "xoscar/core.pyx", line 520, in xoscar.core._BaseActor.on_receive
async with self._lock:
File "xoscar/core.pyx", line 521, in xoscar.core._BaseActor.on_receive
with debug_async_timeout('actor_lock_timeout',
File "xoscar/core.pyx", line 526, in xoscar.core._BaseActor.on_receive
result = await result
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 98, in wrapped_func
ret = await fn(self, *args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xoscar/api.py", line 462, in _wrapper
r = await func(self, *args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/utils.py", line 78, in wrapped
ret = await func(*args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 854, in speech
return await self._call_wrapper_binary(
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 520, in _call_wrapper_binary
return await self._call_wrapper("binary", fn, *args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 122, in _async_wrapper
return await fn(*args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/core/model.py", line 541, in _call_wrapper
ret = await asyncio.to_thread(fn, *args, **kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/asyncio/threads.py", line 25, in to_thread
return await loop.run_in_executor(None, func_call)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/model/audio/fish_speech.py", line 211, in speech
result = list(
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 36, in generator_context
response = gen.send(None)
File "/home/hs/anaconda3/envs/xinf/lib/python3.10/site-packages/xinference/model/audio/fish_speech.py", line 164, in _inference
raise Exception(str(result.response))
Exception: [address=<IP_ADDRESS>:44253, pid=1730377] The expanded size of the tensor (968) must match the existing size (1023) at non-singleton dimension 1. Target sizes: [9, 968]. Tensor sizes: [9, 1023]`

update to latest code by git pull or download 1.4.2


hasOne relationship not working in 3.0.0

When I try to do a hasOne relationship (with foreign key explicitly set, due to a schema error I now can't correct), I can't seem to actually access the object requested.
My code for the relationship itself is:
    public function state() {
        return $this->hasOne('App\ObjectStates', 'object_id');
    }

I have tried querying this relationship with all the following:
$object->state->toArray(); // This is how the Laravel docs say it should work
$object->state()->toArray();
$object->state->get()->toArray();
$object->state()->get()->toArray();
$object->state->all()->toArray();
$object->state()->all()->toArray();

I might have misinterpreted the Laravel docs themselves, however all of the above either return an empty array, or an exception of some description.
I checked using the MongoDB console that my relationship was working correctly, and for every Object, a corresponding state was set, with object_id set to the expected object.
Thanks

Can you check what queries are being executed?

Sorry about the delay.

 This is what profiling gave me:
{
        "op" : "query",
        "ns" : "database.object_state",
        "query" : {
                "$query" : {
                        "$and" : [
                                {
                                        "object_id" : "568fe409d52bab43c80000c1"
                                },
                                {
                                        "object_id" : {
                                                "$ne" : null
                                        }
                                }
                        ]
                }
        },
        "ntoreturn" : 1,
        "ntoskip" : 0,
        "nscanned" : 0,
        "keyUpdates" : 0,
        "numYield" : 0,
        "lockStats" : {
                "timeLockedMicros" : {
                        "r" : NumberLong(156),
                        "w" : NumberLong(0)
                },
                "timeAcquiringMicros" : {
                        "r" : NumberLong(4),
                        "w" : NumberLong(3)
                }
        },
        "nreturned" : 0,
        "responseLength" : 20,
        "millis" : 0,
        "ts" : ISODate("2016-02-18T10:00:55.181Z"),
        "client" : "<IP_ADDRESS>",
        "allUsers" : [
                {
                        "user" : "username",
                        "userSource" : "database"
                }
        ],
        "user" : "username@database"
}

Shouldn't that object_id in the query be wrapped in ObjectId()? So, "object_id": ObjectId("568fe409d52bab43c80000c1"). Or have I just fragged my schema some?

Update: Thanks to info on #744, I updated the code to use $object->state()->get()->toArray(). This doesn't error, however returns an empty array, in every case. Manually querying the database confirms that the state objects do exist (as mentioned above, using ObjectIDs on the relation).

Was this ever resolved? I am having the same problem.

I was having the same problem for 3.0 but adding a ->with('relation_name') to the model query fixed it. I don't remember if this was required before but maybe that helps. Doesn't feel "right" but I had exhausted all other options short of going through each line of this extension.
Additionally, fill() wouldn't update the relation, instead I would have to do it on the model its self: $item->relation_name = (MongoID).


make docker build_binaries.sh macOS compatible

On my macbook build_binaries.sh didn't work :
readlink: illegal option -- f
usage: readlink [-n] [file ...]

Turns out that readlink is something slightly different here :
STAT(1)                   BSD General Commands Manual                  STAT(1)

NAME
     readlink, stat -- display file status

[...]

     -f format
             Display information using the specified format.  See the FORMATS
             section for a description of valid formats.

However, regarding the -f flag that is used, the readlink man page for linux also mentions

realpath(1) is the preferred command to use for canonicalization functionality.

And that command also works on macOS :-)

Maybe you should change .travis.yml accordingly for consistency.

good point @guillaumelecerf , I wasn't aware it was being used in different places.
.travis.yml has also been updated, and a quick grep shows that there are no other places where readlink -f was being used.

Thanks!


Maximum allowed requested length exceeded

Ported from https://github.com/bitcoin/bitcoin/issues/18537.
When running bitcoin qt over x11 remote session (DISPLAY=<IP_ADDRESS>:0) in a clean machine, wallet stops with error.
Expected behavior
Initial intro dialog (were to put the data files) opened.
Actual behavior
I got this:
The X11 connection broke: Maximum allowed requested length exceeded (code 4)
XIO:  fatal IO error 2 (No such file or directory) on X server "<IP_ADDRESS>:51"
      after 219 requests (219 known processed) with 0 events remaining.

To reproduce
Need a clean machine (~/.bitcoin sould be not exists), need a remote x11 "desktop".
export DISPLAY=<IP_ADDRESS>:0
./bitcoin-qt

System information
ubuntu bionic/xenial tested
x64/arm cpu tested
remote x11 session: xvnc and pure xorg tested
The issue
Intro dialog sets the windowicon, this bitmap is 1024x1024 pixels. the qt5 convert this into argb32 format (=1 pixel 4 bytes), thats 4M data. The x11 remote connections allow only less than 4M length.
Possible fix
We dont need 1024x1024 dialog icon, just 128x128 or 256x256. So scale the icon:
intro.setWindowIcon(QIcon(QPixmap(":icons/bitcoin").scaled(QSize(128, 128), Qt::KeepAspectRatio, Qt::SmoothTransformation )));

Qt has fixed this issuehttps://codereview.qt-project.org/c/qt/qtbase/+/408178


[Feature Request] Configure starting storage capacity

I noticed there are configs for how much extra storage the apples add, but I would like to be able to configure starting capacity as well. In my case, I actually want it to be zero so that I have no storage until my first apple is eaten.

good idea


UpperCase permission string problem

permission.toUpperCase() (in ReactNativePermissionsModule.java:117) converts "microphone" to "MİCROPHONE" so we get "MİCROPHONE is not a constant in com.jshblour.reactnativepermissions.ReactNativePermissionsModule$RNType"
when we try to use MICROPHONE instead of "microphone"  ==> "Possible Unhandled Promise Rejection" and module is not working...

@okkan - that's so strange, it works perfectly for me:

what versions are you using? (gradle, android, rn, rn-permissions)

closing for inactivity


EID-895 Tidy up stub IDP's that are not being used.

-Changed references to stub-idp-demo to stub-idp-demo-one, including yml file name.

Can't find stub-idp-demo-one logo so is failing the frontend tests. If Karol is right and it isolated from the hub journey then maybe it won't be needed.

Fails on:
No route matches [GET] "/stub-logos/stub-idp-demo-one.png"
Guessing that the file in question is still stub-idp-demo.png in https://github.com/alphagov/verify-frontend/tree/master/public/stub-logos.

The frontend has its own "fake" hub-fed-config, called stub-api so it can be self-contained and run its tests without relying on anything outside the repo. It's fine to leave it as it is.


Update Multiple Instance Learning Pipeline

Fixes #637
Description
This PR updates Multiple Instance Learning Pipeline with the new components in MONAI.
Status
Ready
Checks

[ ] Notebook runs automatically ./runner [-p <regex_pattern>]

@Nic-Ma Here is the accuracy metric of the updated pipeline with respect to the original one that Andriy has run the experiment and produced the figures. The dark blue is the original one and the orange is the updated one (ignore the other colors). Both dark blue and orange ones are performing very similarly considering the different randomness that they have.

@Nic-Ma I believe this pipeline is already tested by @myron and equivalent performance is reported. Can you please help to merge it?


No resource provider called Microsoft.WorkloadMonitor

The document says to ensure the following resource providers are registered Microsoft.WorkloadMonitor
Microsoft.WorkloadMonitor and Microsoft.Insights.
However I do not find a resource provider called Microsoft.WorkloadMonitor.
I do see these two
Microsoft.WorkloadBuilder and Microsoft.Workloads
Has the name changed for the resource provider called Microsoft.WorkloadMonitor?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8b0ecacc-0792-42eb-f396-551988b74b8b
Version Independent ID: a9799067-aa80-3f4b-cbcb-2d4ccefe2baf
Content: Enable VM insights guest health (preview) - Azure Monitor
Content Source: articles/azure-monitor/vm/vminsights-health-enable.md
Service: azure-monitor
Sub-service: virtual-machines
GitHub Login: @bwren
Microsoft Alias: bwren

@rz1qt2
Thanks for your feedback! We will investigate and update as appropriate.

@rz1qt2, thank you for this question. The VM insights guest health (preview) will retire on 30 November 2022. Therefore, the recommendation is to Migrate from VM insights guest health to Azure Monitor log alerts.
It is for this reason, the Microsoft.WorkloadMonitor resource provider seems to be not getting displayed on the portal.
Please see this link  for details on "Monitor virtual machines with Azure Monitor"
Please let me know if you have any questions.

@rz1qt2, we will now proceed to close this thread as we have not heard back from you. If there are further questions regarding this matter, please tag me in your reply and reopen the issue. We will gladly continue the discussion.

Thank you yes you can close this based on explanation.
On Tue, Nov 8, 2022 at 10:51 PM Anurag Singh @.***>
wrote:

@rz1qt2 https://github.com/rz1qt2, we will now proceed to close this
thread as we have not heard back from you. If there are further questions
regarding this matter, please tag me in your reply and reopen the issue. We
will gladly continue the discussion.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/100726#issuecomment-1308208905,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANYWIF7EEDG2S4I5MLLPHPTWHMUWPANCNFSM6AAAAAARS7QY34
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add More Components Docs

Related issue
#420 [Docs] Create missing component docs
Components

Breadcrumbs
CircleIcon
Price
Property
Rating

You're my hero <3


UXUI-239 - Rename some files and remove styles from components and place into docs

What does this PR do? (please provide any background)

We originally decided to add some margin to some of our components when two of the same component are next to one another, however in practical use this causes more headaches than it should, so we have removed the styles from the component and just added them to the docs.
I have renames justified_button component to sit with other components using a -

What tests does this PR have?
None
How can be this tested?

Check the code for anti-patterns
run grunt docs and check thats the example work as intended (button, flag and justified button)

Screenshots / Screencast

What gif best describes how you feel about this work?

Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):

[x] I have checked the contributing document and I'm happy for this to be reviewed.

Software Engineer or Developer review:

[x] I’ve witnessed the work behaving as expected (this could be on the authors machine or screencast).
[x] I’ve checked for coding anti-patterns.
[x] I’ve checked for appropriate test coverage.
[x] I’ve run all the tests locally and they pass.

Software Engineer or project guru review:

[x] I’ve witnessed the work behaving as expected (this could be on the authors machine or screencast).
[x] I’ve checked for coding anti-patterns.
[x] I’ve checked for appropriate test coverage.
[x] I’ve run all the tests locally and they pass.

Taking Dev

:+1:

taking se

:+1:


Make dotnet-maintenance-packages ready to accept libraries

[x] Enable internal build - may require assigning service tree entry - get help from @rbhanda
[ ] Define branch scheme for releases, create internal branch
[x] Update the SDK / tools / arcade - 8.0
[x] Adopt NuGet Central Package Management
[x] Remove non-needed infrastructure

[x] test infra already provided by Arcade
[x] Publishing.props.

[x] Remove the Build.proj as we already have a solution file
[x] Clean-up the feeds, we shouldn't point to any previous release.
[x] Enable APICompat + baseline validation
[x] Enable package validation?
[x] Do a trial run of an existing package

[x] Move source & test code over with history
[x] Retarget to in-support frameworks - make sure to define properties like NETFrameworkMinimum  etc.
[x] Ensure we add targets to package that message out of support frameworks: https://github.com/dotnet/runtime/blob/5cb5dafd4d49f171425958e4d92d9e9066cad58b/eng/packaging.targets#L201
[x] Is there any other infrastructure from dotnet/runtime libraries build that we need to move over? @ViktorHofer
[x] Enable APICompat for package (turning on and setting baseline package version, restoring it).
[x] Enable package for servicing by setting properties to version & build it.
[ ] Document along the way :)

[ ] Refine Assembly versioning pattern, document the process, and trial it (readiness)
[ ] Determine which version of Arcade is appropriate for this repo -- which will need to regularly ship from main
[x] Version and update System.Buffers to be ready to ship. (drop out of support frameworks)
[ ] Capture the list of packages which need to be moved here and set a timeline for each.
[ ] Prepare public docs describing support lifecycle for these packages.
[ ] Enable analyzer that suggests the correct license header.

cc @ViktorHofer @carlossanlop

Update the SDK / tools / arcade - 8.0

I assume we want to update to 8.0 because this repo is merely for servicing, so we want the latest released version of arcade, not the one currently in development. Correct?
In that case, I updated this repo's darc subscription to arcade to point to the .NET 8 Eng channel (it was pointing to 7).
Here's the deps flow PR, it was already open, but triggering the subscription updated the same PR: https://github.com/dotnet/maintenance-packages/pull/17

I assume we want to update to 8.0 because this repo is merely for servicing

That was my assumption as well.  I was also expecting us to want to ship from this repo before 9.0 releases.
@ViktorHofer can you let us know what features we might need out of 9.0 here?  Could those be backported to 8.0 arcade to avoid a dependency on non-stable tools?

@ViktorHofer can you let us know what features we might need out of 9.0 here? Could those be backported to 8.0 arcade to avoid a dependency on non-stable tools?

None. 8.0 and 9.0 versions of the Arcade.Sdk are nearly identical aside from version updates.

Refine Assembly versioning pattern

@ericstj I'm unsure what this item tracks, can you please elaborate? @carlossanlop and I met few weeks ago, discussed the versioning infrastructure and agreed on that what we now have in main makes sense and just needs documentation.

One thing I noticed is that it needs to handle cases with pinned assembly versions and non-pinned in the same package.  For example for packages like System.Buffers and System.Memory we'd need to freeze the netstandard & netcore assembly versions while rev'ing the netframework one.  I think it needs more discussion to understand all the details of how it works.  Ideally I want to make sure we keep it simple without developers having to maintain complexity in their projects.  I said "refine" here to indicate that what we have is fine we just need to walk through all the cases it needs to handle (package types and servicing operations) and describe how those work and make any changes we see necessary.
My assumptions based on what I'm seeing right now (this is not complete, but this is the sort of docs I'm expecting that might reveal what refinement we need).
Initial porting:

PackageVersion should initially be one minor version higher than the last shipped package version.
AssemblyVersion should be initially set as follows:

Same as last shipped for any library compatible with a shared-framework library
Incremented from last shipped otherwise (EG: NetFramework target, or non-shared-framework library).
NOTE: there may be special cases like https://github.com/dotnet/runtime/blob/465e0060782c84bfc086971e507e5c5dabd7c12f/src/libraries/System.Speech/Directory.Build.targets#L4-L6 where AssemblyVersion should remain fixed.

PackageValidationBaselineVersion should be set to the last shipped package version.

Every release time:

Developers set IsPackable on a project when they wish for that project to ship in a given release.
A branding operation done by the repo owner is responsible for incrementing AssemblyVersion, PackageVersion, PackageValidationBaselineVersion after a release when a package set's IsPackable.

NOTE: any frozen AssemblyVersions should not be incremented, we should distinguish these in some way.

Yes that exactly describes what we currently do in main. I just had another meeting with @carlossanlop and he will document the steps.

Something I couldn't quite see working here is how the AssemblyVersion exclusions will work - how do we keep those separate and make sure the branding operations won't touch them?

I would just move the fixed assembly version somewhere else so that whoever increments the versions (i.e. a bot) doesn't touch it. And I recommend to add a code comment to highlight that the assembly version is frozen because of X.

Refine Assembly versioning pattern, document the process, and trial it (readiness)

@ericstj is it possible to try the servicing process without accidentally pushing the nuget package?

Yeah you can change the default channel to General Testing so that a package gets pushed to the general testing nuget feed only.

We should also make sure that these stable builds don't directly publish to shared feeds.  Normally our stable servicing builds of repos like dotnet/runtime will push their stable packages to a temporary feed.  (perhaps separately) We should make sure this repo is set up to do that.
Additionally we might think about if it makes sense to have this repo produce "pre-release" servicing packages so that it's easier to test nightly builds.  Then we flip the switch at some point to make it stable.

Determine how new builds of packages that ship from this repo flow into the rest of the product - eg: Microsoft.Windows.Compatibility, netstandard2.0 and netframework builds from in-support branches.

Just my take on this, I don't think repositories should connect to maintenance-packages via dependency flow. I would rather have them use dependabot to update packages when a new version's out on nuget.org.

Determine how new builds of packages that ship from this repo flow into the rest of the product - eg: Microsoft.Windows.Compatibility, netstandard2.0 and netframework builds from in-support branches.

Just my take on this, I don't think repositories should connect to maintenance-packages via dependency flow. I would rather have them use dependabot to update packages when a new version's out on nuget.org.

NuGet.org might be too late in the case of servicing events that we wish to sim-ship - suppose a critical fix to System.Memory that needs be referenced by many products.  Still I don't think dependency flow is the answer because that's used for product releases.

Is release still planned?

It should release around the time .NET 9.0 goes out.  @Romfos are you interested in this for any particular reason?  Is there some fix you're expecting?

Small reason:
We are trying to plan next major release and would be nice not to base it on deprecated libraries
Yea, we can update it also later, but if you have predicted release date we can align with it

Understood.  Yeah - expectation is that the first wave should ship around the time .NET 9.0 does.


Basic: correct fd check as identified by clang

clang objects to the ordered comparison between HANDLE and int.
Provide a trait based validation check for the FD.  Windows
traditionally uses INVALID_HANDLE_VALUE to indicate an invalid handle.

Should fix the error identified by clang: https://compnerd.visualstudio.com/windows-swift/_build/results?buildId=6719&view=logs&j=b9e62f99-1a98-5ed7-01d2-f4794231ed79&t=5380b2be-52f4-5798-26ce-9385034a3cf2&l=86

@swift-ci please smoke test


Installed the package but unable to configure phpcs on PHPStorm.

I've installed the package and it works great!
I understand it comes with phpcs and other tools so I've trying to integrate those into my IDE (PHPStorm).
I've configured phpcs but unabled to set/find the ruleset.xml file under the vendor/tightenco directory.
One of the things I've tried was to copy the ruleset.xml under https://github.com/tighten/duster/blob/2.x/standards/Tighten/ruleset.xml but I believe that's not the idean solution I most likely have to be doing something wrong.
Any help is much appreciated!
Thanks!
Jose

Nope, I think that's on me.  I think I just need to allow those to be downloaded.  I'll let you know when that's fixed.  Thanks for reporting.

Thank you! Let me know if there’s anything I can do to speed that up :). This is a great package!

The latest release now ships with the standards folder.

After a quick fire testing I’ve discovered that PHO_CodeSniffer doesn’t work correctly and doesn’t highlight the error while using the standards directory.

@joepages you may need to tell PHP_CodeSniffer where to find the config:
https://github.com/squizlabs/PHP_CodeSniffer/wiki/Configuration-Options#setting-the-installed-standard-paths

I did that already. Working on custom xml but not when referencing the standards path to tightenco. Check attached screen shot.

I don't use PHPStorm, so it's harder for me to debug. Are you installing Duster globally?  Does the global composer vendor file contain all the files you need?
When you run phpcs -i do you see the Tighten rule?  You might need to start testing outside of PHPStorm get more feedback.


Control Panel crash when opening TextExtractor settings

Microsoft PowerToys version
0.76.0
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
TextExtractor
Steps to reproduce
Regardless of whether TextExtrator module is enabled or not, the control panel crashes when clicking on its sidebar or tab of TextExtrator. But the entire PowerToys program and backend processes are still running normally.
✔ Expected Behavior
Navigate to the settings page of the TextExtractor.
❌ Actual Behavior
Control panel crashes.
Other Software
No response

Does this happen only on TextExtractor page?

Yes, it only happen on TextExtractor page. Two of my device have the same issue.

@max1219choy can you update to 0.77 and see if the Settings page for Text Extractor still crashes? /needinfo

I think the issue is cause by Windows, I updated to 0.77 and it still crash. But after I upgrade my Windows to 23H2 it just fixed.

@max1219choy strange, but good that it is fixed. I'll close this issue then.


[DAEF-420] show transaction status based on condition

This PR adds support for the ctCondition property that comes with every transaction from the backend and provides information about its status in the blockchain. It can have the following values:

CPtxApplying transaction application is in progress
CPtxInBlocks transaction is detected to be in blockchain
CPtxWontApply  transaction can't be applied (and it will not with up to high assurance, i.e. unless severe rollback occurs, UPD: this is not true now, this status is permanent now)
CPtxNotTracked  transaction was made not by us / before last wallet restore - this state never changes

Which are simplified by our frontend into:
export type TransactionState = 'pending' | 'failed' | 'ok';

TODOS:

[x] Implement final design specs for all themes
[ ] Try with working (real) backend / transactions (i built this with storybook now because i have no keys for wallets to work with atm)
[ ] Inject missing Japanese translations:

  wallet.transaction.state.failed: !!!Transaction failed
  wallet.transaction.state.pending: !!!Transaction pending

CC @a-rukin

for failed transactions we have separate icon, also updated those animated statuses for "pending" and "retrying"
https://zpl.io/2ynM1yV

if we can't track retrying transactions, then ignore them in zeplin

@a-rukin @darko-mijic i implemented the latest design specs now (with pending animation bar), please review again!
@a-rukin please notice that the pending bar does not look 100% the same as in the designs, please consider if this is good enough because it would be additional work to change it … if you like this version too then let's go with it 😉

This PR contains fixed styling for confirmation-dialog on dark-theme:


Slim down: Get rid of notebook and stubs, try just using codecell and kernel (again)

It's possible, and would make things simpler. I got it working mostly, but for the interactive widgets.
Edit: This branch is as far as I got in like half an hour. Everything works, basically, except for the interactive widgets. This is totally doable.

Closing this for now. Compared to jquery-ui, this wouldn't slim it down much anyway.


How to convert to json

Hello how to convert it to json format, I've got only csv format
login.somesite.com and cookie: "ADRUM_BT1="

Hello,I will update in the next few days


obtain_stream_url breaks because dvrorigin is replaced with dvrorigingr

i had to force the code to always use "dvrorigin" instead of "dvrorigingr" or else it would not work.

The new way ertflix works doesn't use dvorigin so probably this issue is fixed.


project status?

Hi all
Could I query whether this project is being kept up to date as the design system moves on?
We've been exploring it but notice that it uses a now quite old version of the frontend project ("govuk-frontend": "^2.13.0",)
If it's now no longer recommended for use as a template or as a learning tool this would also be useful to know.
Many thanks.

Hi,
Unfortunately, as you've identified, it doesn't seem like anyone is currently maintaining this.
I suspect bits of it are still relevant as a reference, but without anyone keeping the dependencies up to date I'm going to archive it to try and better reflect its current status.
Thanks for bringing this to our attention.


Create Bluefin Ollama + WebUI Boxkit

Hey @castrojo I saw the new local LLM justfile in bluefin
https://github.com/ublue-os/bluefin/blob/6b58f9836bffb7ec0250296d2809e30e2c9325b6/just/bluefin-tools.just
I was wondering if it would make sense to use the Ollama + WebUI combo within a single distrobox based on bluefin-dx? I had a bad experience with justfiles and think that this feature would be a great use case for the Boxkit logic.
@p5 do you think that Boxkit is a better way to get ollama on ublue devices?
Many thanks!

How about a dedicated container we could put in ublue-os/toolboxes with
what you want in there? ublue-os/ollama or something, we could build it off
of wolfi so it's nice and small and then just build it every time there's
an update? If you've got time to help out I think this would be great, I
don't have time to work on it for a while tho. And we could do rocm6 and
cuda versions, etc too?
On Fri, May 3, 2024 at 12:10 PM Thomas Mecattaf @.***>
wrote:

Hey @castrojo https://github.com/castrojo I saw the new local LLM
justfile in bluefin
https://github.com/ublue-os/bluefin/blob/6b58f9836bffb7ec0250296d2809e30e2c9325b6/just/bluefin-tools.just
I was wondering if it would make sense to use the Ollama + WebUI combo
within a single distrobox based on bluefin-dx? I had a bad experience with
justfiles and think that this feature would be a great use case for the
Boxkit logic.
@p5 https://github.com/p5 do you think that Boxkit is a better way to
get ollama on ublue devices?
Many thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/ublue-os/boxkit/issues/72, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJUT3IB3GZZYNOHP2CQCRTZAOZIZAVCNFSM6AAAAABHFYYXIGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TOOJZG4YTMNA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for the quick reply @castrojo. This could live in ublue-os/toolboxes. Submitted a first PR over there. I chose to build the container off bluefin-cli.
In later iterations we can add a nvidia-specific image, but for now let's do without.
Finally we could set up the systemd units by drawing inspiration from https://github.com/wayblueorg/wayblue/tree/live/config/systemd/system and the systemd module from bluebuild instead of having a justfile that writes the quadlets?


feat!: add python code tool over http

Which issue(s) does this pull-request address?
Part of: #149
Description

Modify the existing PythonTool over gRPC to go over HTTP.
Add tests (written for gRPC but adapted for the new one).
Requires CODE_INTERPRETER_URL env var to point to exposed HTTP port (50081).

Checklist

[x] I have read the contributor guide
[x] Linting passes: yarn lint or yarn lint:fix
[x] Formatting is applied: yarn format or yarn format:fix
[x] Unit tests pass: yarn test:unit
[x] E2E tests pass: yarn test:e2e
[x] Tests are included
[ ] Documentation is changed or added
[x] Commit messages and PR title follow conventional commits

Marking as draft because custom tool will also have to be updated.

You could probably remove some of the grpc dependencies together with this PR -- IIRC we use gRPC in a different part of the codebase, but through a different library.


To deploy/run the app on docker, instructions must clearly indicate the use of IP address

The  instructions to deploy and run the app using Docker should clearly indicate that the browser on the host machine should use the IP address.
Perhaps, a new Step 6 can be added to the existing list of steps as shown below:
6. Point your browser(running on the host machine) to point at
http://<ip-address-from-DOCKER_HOST-env-variable>:8090/hello

Thanks for opening the issue.  You don't need to use the IP address, you can go to http://localhost:8090/. I've updated the README to state this.  Thanks.


fix(gateway): respond to Heartbeat with stored sequence

Upon receiving OpCode::Heartbeat shards should not try to deserialize the sequence but respond with the currently stored sequence number.
Detected in and split out of #1964

Could arguably also break Event and GatewayEvent and remove the u64 inner value on the Heartbeat variant since its no longer used, but I'm hesitant that I'd break some other use case.

Could arguably also break Event and GatewayEvent and remove the inner u64 value on the Heartbeat variant since it's no longer used, but I'm hesitant that I'd break some other use case.

https://github.com/discordjs/discord-api-types defines a separate HeartbeatRequest for incoming Heartbeats which does not contain an inner d (u64) field, still I don't like making this change now as it's too close to Twilight 0.14

This has conflicts, also we should check the docs on Shard::heartbeat


Complex intent data

I had an issue recently that forced me to modify HASS event data generation like this: daniele-athome/rhasspy@bd644f2236c7db02e596f8bd94ac868ad80562d5
The issue arised when I needed complex data provided by Duckling through Rasa. For example, when asking to start a timer, I would have a duration slot in either hours, minutes or seconds (or even mixed one, like "2 minutes and 30 seconds"). Duckling would correctly recognize this, but in the event data received in HASS, I didn't have the time units, just the numbers (2 and 30).
Maybe my approach wasn't the best one, I'm just giving you an idea on what the problem is.
Possibly related to #40.

The HASS event should contain _text and _raw_text properties with the complete spoken sentence. Do you have an example of your intent? Depending on how you wrote it, I could see Rhasspy either including or excluding the unit names from the slot values.

The HASS event should contain _text and _raw_text properties with the complete spoken sentence.

It does, but I'd prefer that the event comes already completely processed by Rhasspy (I mean this is part of the Rasa NLU pipeline anyway).

Do you have an example of your intent?

This is my configuration in sentences.ini:
[SetTimer]
(imposta|avvia|metti) [un] timer [(per|di)] (2 minuti e 40 secondi){duration}
(imposta|avvia|metti) [un] timer [(per|di)] (1 minuto){duration}
(imposta|avvia|metti) [un] timer [(per|di)] (13 secondi){duration}

This is the raw intent data without my patch:
{
   "entities" : [
      {
         "confidence" : 0.9883932124,
         "end" : 29,
         "entity" : "duration",
         "extractor" : "CRFEntityExtractor",
         "start" : 18,
         "value" : "due secondi"
      },
      {
         "additional_info" : {
            "type" : "value",
            "value" : 1
         },
         "confidence" : 1,
         "end" : 8,
         "entity" : "number",
         "extractor" : "DucklingHTTPExtractor",
         "start" : 6,
         "text" : "un",
         "value" : 1
      },
      {
         "additional_info" : {
            "normalized" : {
               "unit" : "second",
               "value" : 2
            },
            "second" : 2,
            "type" : "value",
            "unit" : "second",
            "value" : 2
         },
         "confidence" : 1,
         "end" : 29,
         "entity" : "duration",
         "extractor" : "DucklingHTTPExtractor",
         "start" : 18,
         "text" : "due secondi",
         "value" : 2
      }
   ],
   "intent" : {
      "confidence" : 0.9984958172,
      "name" : "SetTimer"
   },
   "intent_ranking" : [
      {
         "confidence" : 0.9984958172,
         "name" : "SetTimer"
      },
      {
         "confidence" : 0.0005479114,
         "name" : "GreetingGeneral"
      },
      {
         "confidence" : 0.0002262423,
         "name" : "GetDate"
      },
      {
         "confidence" : 0.0001869724,
         "name" : "GreetingGoodMorning"
      },
      {
         "confidence" : 0.0001819576,
         "name" : "GetTime"
      },
      {
         "confidence" : 0.0001679873,
         "name" : "AllLightsOff"
      },
      {
         "confidence" : 0.0001459537,
         "name" : "GreetingGoodNight"
      },
      {
         "confidence" : 3.90133e-05,
         "name" : "SetDinnerEating"
      },
      {
         "confidence" : 7.7541e-06,
         "name" : "GetExternalTemperature"
      },
      {
         "confidence" : 3.854e-07,
         "name" : "LivingUtilityLightOn"
      }
   ],
   "raw_text" : "avvia un timer di due secondi",
   "siteId" : "default",
   "slots" : {
      "duration" : 2,
      "number" : 1
   },
   "speech_confidence" : 1,
   "text" : "avvia un timer di due secondi",
   "time_sec" : 0.0218460559844971,
   "wakeId" : ""
}

See the slots data? "duration" is just "2" but HA has no clue if those are seconds or minutes or hours. That information can be found however in an entity provided by DucklingHTTPExtractor.

In the meantime I've modified Rhasspy once more to better pack those additional slot information, but I think a better proposal for this would be #40. If you agree, feel free to close this issue as duplicate.

Oh, I see what you're saying now. I think this is something unique worth considering for the HASS events. Maybe the entire "entities" should just come over in the event as "_entities" in the event, probably keyed by slot name?

Ok for an _entities field, as in the raw data coming from the intent resolution provider, but those values should be parsed in a meaningful way and intent-resolution-provider-agnostic. You already do that in your code, but that's not enough for complex entities.
To summarize: I guess this issue could be used, as you said, for the _entities field (which will contain the raw entities data as provided by the intent resolution provider), but #40 will provide changes to provide a common interface for this data. Is that correct?

rhasspy-homeassistant-hermes passes the complete Hermes intent in the slot _intent to HA. Suggest rhasspy-rasa-nlu-hermes ensure that slot kinds and units are set appropriately.


WIP DOC: Add author contributions using the CRediT taxonomy

This PR adds author contributions using the CRediT taxonomy.
@arokem, @mnarayan, @jyeatman, @nrs02004, please review and approve my description of the author contributions.
It also refines many of the bibtex entries for our references, adding DOIs where possible.

Partially addressed JOSS reviewer comments here.

Coverage remained the same at 95.12% when pulling e897828acc51f34f699a2a003a9bb793cb859737 on doc/paper-credit-and-dois into 36189d3095b277cc39c472af7c5c8fbc841c0fbe on main.

LGTM!
On Wed, Feb 17, 2021 at 6:18 AM Adam Richie-Halford <
<EMAIL_ADDRESS>wrote:

This PR adds author contributions using the CRediT taxonomy
http://dx.doi.org/10.1087/20150211.
@arokem https://github.com/arokem, @mnarayan
https://github.com/mnarayan, @jyeatman https://github.com/jyeatman,
@nrs02004 https://github.com/nrs02004, please review and approve my
description of the author contributions.
It also refines many of the bibtex entries for our references, adding DOIs
where possible.
You can view, comment on, or merge this pull request online at:
https://github.com/richford/groupyr/pull/42
Commit Summary

DOC: Add author contributions using the CRediT taxonomy. Add dois to
most references
DOC: Remove leading https://doi.org/ from some dois

File Changes

M paper/paper.bib
https://github.com/richford/groupyr/pull/42/files#diff-c7ec3d0f2ff5bf83e6afaac85d8fa2a792d68b694676683802edf49098a891d3
(80)
M paper/paper.md
https://github.com/richford/groupyr/pull/42/files#diff-e504eb580b095a7e65428b098183a581e475f0fb316db95287eacd7d4f344424
(24)

Patch Links:

https://github.com/richford/groupyr/pull/42.patch
https://github.com/richford/groupyr/pull/42.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/richford/groupyr/pull/42, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA46NUGMSLPUMGI2PUSIXTS7PF3RANCNFSM4XYN22NQ
.

This is WIP pending co-author review.
Also, I resolved the missing identifier for the sklearn_api reference by adding the arXiv preprint identifier. arXiv does not issue DOIs and I could not find an official reference for the recommended proceedings reference. So the arXiv identifier seemed like the best alternative.


[Impeller] Fence waiter is holding on to textures

At first I thought it was my PR (https://github.com/flutter/engine/pull/45654), but it appears to happen at HEAD (which at this moment in time is 33a24fff8129a5f42fabcde2e91e5da595ea2642).
How to reproduce:

Get a Linux VM (I couldn't reproduce this on MacOS+MoltenVK) or machine.

Setup a simple host engine configuration
(I reproduced with ./tools/gn --runtime-mode debug --unopt)

Build just impeller_unittests:
ninja -C ../out/host_debug_impeller_vulkan impeller_unittests

Try running the Play/RendererTest.*/Vulkan tests a few thousand times:
../out/host_debug_impeller_vulkan/impeller_unittests \
    --gtest_filter="Play/RendererTest.*/Vulkan" \
    --gtest_repeat=1000

I've seen some of these following flaky/crash variants:
[ RUN      ] Play/RendererTest.VertexBufferBuilder/Vulkan
zsh: IOT instruction

Repeating all tests (iteration 27) . . .

Note: Google Test filter = Play/RendererTest.*/Vulkan
[==========] Running 16 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 16 tests from Play/RendererTest
[ RUN      ] Play/RendererTest.CanCreateBoxPrimitive/Vulkan
[FATAL:flutter/testing/test_timeout_listener.cc(45)] Check failed: delay < timeout_. Test Play/RendererTest.CanCreateBoxPrimitive/Vulkan/4-byte object <02-00 00-00> did not complete in 300 seconds and is assumed to be hung. Killing the test harness.
zsh: IOT instruction  ../out/host_debug_impeller_vulkan/impeller_unittests  --gtest_repeat=1000

It's not always the same test cases, so I'm guessing it's a general issue and not isolated to specifics.

Related issues:

https://github.com/flutter/flutter/issues/133506
https://github.com/flutter/flutter/issues/134679
https://github.com/flutter/flutter/issues/133708
https://github.com/flutter/flutter/issues/118814

Here is a test I can fail consistently at HEAD:
../out/host_debug_impeller_vulkan/impeller_unittests \
  --enable_vulkan_validation \
  --playground_timeout_ms=1 \
  --gtest_filter="Play/AiksTest.CanRenderTiledTextureDecal/Vulkan"

I turned on VMA_DEBUG_LOG, and get the following output:
Note: Google Test filter = Play/AiksTest.CanRenderTiledTextureDecal/Vulkan
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/AiksTest
[ RUN      ] Play/AiksTest.CanRenderTiledTextureDecal/Vulkan
[INFO:capabilities_vk.cc(50)] Vulkan validations are enabled.
[INFO:flutter_vma.cc(30)] vmaCreateAllocator
[INFO:flutter_vma.cc(30)] vmaCreatePool
[INFO:flutter_vma.cc(30)]   CreatePool: MemoryTypeIndex=1, flags=2
[INFO:flutter_vma.cc(30)] vmaCreateImage
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=0, AllocationCount=1, Size=349520
[INFO:flutter_vma.cc(30)]     Allocated DedicatedMemory Count=1, MemoryTypeIndex=#0
[INFO:flutter_vma.cc(30)]     Allocated as DedicatedMemory
[INFO:flutter_vma.cc(30)] vmaCreateBuffer
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=1, AllocationCount=1, Size=262144
[INFO:flutter_vma.cc(30)]     Created new block #0 Size=33554432
[INFO:flutter_vma.cc(30)] vmaFlushAllocation
[INFO:flutter_vma.cc(30)] vmaDestroyBuffer
[INFO:flutter_vma.cc(30)]   Freed from MemoryTypeIndex=1
[INFO:flutter_vma.cc(30)] vmaCreateImage
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=2, AllocationCount=1, Size=131072
[INFO:flutter_vma.cc(30)]     Allocated DedicatedMemory Count=1, MemoryTypeIndex=#2
[INFO:flutter_vma.cc(30)]     Allocated as DedicatedMemory
[INFO:flutter_vma.cc(30)] vmaCreateBuffer
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=1, AllocationCount=1, Size=131072
[INFO:flutter_vma.cc(30)]     Returned from existing block #0
[INFO:flutter_vma.cc(30)] vmaFlushAllocation
[INFO:flutter_vma.cc(30)] vmaDestroyBuffer
[INFO:flutter_vma.cc(30)]   Freed from MemoryTypeIndex=1
[INFO:flutter_vma.cc(30)] vmaCreateImage
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=3, AllocationCount=1, Size=3145728
[INFO:flutter_vma.cc(30)]     Allocated DedicatedMemory Count=1, MemoryTypeIndex=#3
[INFO:flutter_vma.cc(30)]     Allocated as DedicatedMemory
[INFO:flutter_vma.cc(30)] vmaCreateImage
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=3, AllocationCount=1, Size=786432
[INFO:flutter_vma.cc(30)]     Allocated DedicatedMemory Count=1, MemoryTypeIndex=#3
[INFO:flutter_vma.cc(30)]     Allocated as DedicatedMemory
[INFO:flutter_vma.cc(30)] vmaCreateBuffer
[INFO:flutter_vma.cc(30)]   AllocateMemory: MemoryTypeIndex=1, AllocationCount=1, Size=4224
[INFO:flutter_vma.cc(30)]     Created new block #0 Size=33554432
[INFO:flutter_vma.cc(30)] vmaFlushAllocation
[INFO:flutter_vma.cc(30)] vmaDestroyImage
[INFO:flutter_vma.cc(30)]     Freed DedicatedMemory MemoryTypeIndex=2
[INFO:flutter_vma.cc(30)] vmaDestroyImage
[INFO:flutter_vma.cc(30)]     Freed DedicatedMemory MemoryTypeIndex=3
[INFO:flutter_vma.cc(30)] vmaDestroyBuffer
[INFO:flutter_vma.cc(30)]   Freed from MemoryTypeIndex=1
[INFO:flutter_vma.cc(30)] vmaDestroyImage
[INFO:flutter_vma.cc(30)]     Freed DedicatedMemory MemoryTypeIndex=3
[ERROR:flutter/impeller/renderer/backend/vulkan/allocator_vk.cc(176)] ~AllocatorVK()
[INFO:flutter_vma.cc(30)] vmaDestroyPool
[INFO:flutter_vma.cc(30)] vmaDestroyAllocator
[FATAL:third_party/vulkan_memory_allocator/include/vk_mem_alloc.h(6179)] Check failed: (false && "Unfreed dedicated allocations found!"). Vulkan Memory Allocator Failure!
zsh: abort      ../out/host_debug_impeller_vulkan/impeller_unittests

Just based on above, there:

Types
Creations
Destructions

Pool
1
1

Buffer
3
3

Image
4
3

... so I'm guessing some Image resource is not being deallocated.

I managed to write a fairly minimal sample that triggers VMA panics:
TEST_P(AiksTest, InitialTextureIsCleanedUp) {
  auto context = this->GetContext();
  std::weak_ptr<Texture> weak_texture;
  {
    auto texture = this->CreateTextureForFixture("table_mountain_nx.png",
                                                 /*enable_mipmapping=*/true);
    weak_texture = texture;
    GenerateMipmap(context, texture, "table_mountain_nx");
    Canvas canvas;
    canvas.Scale(this->GetContentScale());
    canvas.Translate({100.0f, 100.0f, 0});
    Paint paint;
    paint.color_source = ColorSource::MakeImage(
        texture, Entity::TileMode::kClamp, Entity::TileMode::kClamp, {}, {});
    paint.color = Color(1, 1, 1, 1);
    canvas.DrawRect({0, 0, 600, 600}, paint);

    ASSERT_TRUE(this->OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
  }

  // This also fails, and then the VMA panic happens on test suite destruction.
  ASSERT_TRUE(weak_texture.expired());
}

Talking to @jonahwilliams on chat, this is the same Fence Waiter issue discovered in https://github.com/flutter/engine/pull/45654, namely that this termination block is not sufficient to break here:
void FenceWaiterVK::Main() {
  fml::Thread::SetCurrentThreadName(
      fml::Thread::ThreadConfig{"io.flutter.impeller.fence_waiter"});

  using namespace std::literals::chrono_literals;

  while (true) {
    std::unique_lock lock(wait_set_mutex_);

    // If there are no fences to wait on, wait on the condition variable.
    wait_set_cv_.wait(lock, [&]() { return !wait_set_.empty() || terminate_; });

    // We don't want to check on fence status or collect wait set entries in the
    // critical section. Copy the array of entries and immediately unlock the
    // mutex.
    WaitSet wait_set = wait_set_;

    const auto terminate = terminate_;

    lock.unlock();

    if (terminate) {
      break;
    }

    // Check if the context had died in the meantime.
    auto device_holder = device_holder_.lock();
    if (!device_holder) {
      break;
    }

    const auto& device = device_holder->GetDevice();

    // Wait for one or more fences to be signaled. Any additional fences added
    // to the waiter will be serviced in the next pass. If a fence that is going
    // to be signaled at an abnormally long deadline is the only one in the set,
    // a timeout will bail out the wait.
    auto fences = GetFencesForWaitSet(wait_set);
    if (fences.empty()) {
      continue;
    }

@jonahwilliams:

just because we've finished encoding the cmd, doesn't mean the GPU (or swiftshader) is done with it, and so its not safe to delete the texture
which means that the fix here is to make sure that we're waiting + joining on the fence waiter firing

While it's possible FenceWaiterVK is a problem, I can reproduce  crashes unrelated. Logs:
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(75)] Adding fence to FenceWaiterVK.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(29)] FenceWaiterVK::UpdateSignalledStatus << Fence signalled.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(176)] FenceWaiterVK::Main << Erased 1 signaled fences from wait set.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(75)] Adding fence to FenceWaiterVK.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(29)] FenceWaiterVK::UpdateSignalledStatus << Fence signalled.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(176)] FenceWaiterVK::Main << Erased 1 signaled fences from wait set.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(75)] Adding fence to FenceWaiterVK.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(75)] Adding fence to FenceWaiterVK.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(29)] FenceWaiterVK::UpdateSignalledStatus << Fence signalled.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(176)] FenceWaiterVK::Main << Erased 1 signaled fences from wait set.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(29)] FenceWaiterVK::UpdateSignalledStatus << Fence signalled.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(176)] FenceWaiterVK::Main << Erased 1 signaled fences from wait set.
[ERROR:flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc(56)] FenceWaiterVK::~FenceWaiterVK << 0 fences in wait set.
[FATAL:third_party/vulkan_memory_allocator/include/vk_mem_alloc.h(6179)] Check failed: (false && "Unfreed dedicated allocations found!"). Vulkan Memory Allocator Failure!

On cases with crashes, the FenceWaiterVK appears to be (accidentally or otherwise) WAI.

A potential source of this, is, ironically, ColorSource:

When the method body is commented out, nothing crashes or has allocation errors.

~TiledTextureContents() never is invoked (I never see this):
TiledTextureContents::~TiledTextureContents() {
  FML_LOG(ERROR) << "~TiledTextureContents | texture_.use_count() = "
                 << texture_.use_count();
}

I wonder if this is the playground itself holding onto the picture object too long?


feat: adding unbound GRE related changes

dependency: none
PR summary

Fixes: The PR adds a support for the new unbound_gre_tunnel network type.
Issue: https://github.ibm.com/CloudBBS/ts-planning/issues/4128
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Set request content type

As noted in Slack (https://stackstorm.slack.com/archives/C029K4CBU/p1532086199000268) I've tried the packages from this PR and tested with developer console, - the headers were not set yet.
So could be something else going on.


refactor: downgrade to c++17 code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

66 of 69 (95.65%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 93.023%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/tc_tea/tc_tea_cbc.cpp
30
33
90.91%

Files with Coverage Reduction
New Missed Lines
%

src/tc_tea/tc_tea_cbc.cpp
1
85.11%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
120

Relevant Lines:
129

💛  - Coveralls


switch-to-configuration starts unmodified units

Describe the bug
When a unit of Type=simple gets stopped, it will be activated again by switch-to-configuration test (or ... switch) even if it didn't change.
Steps To Reproduce
Steps to reproduce the behavior:

Define a unit like

{ systemd.services.foo.script = '' /* ... */ ''; }

It's not even relevant if it's supposed to be a short thing activated by a timer or a long-running script, I observed the issue with both kinds of services already. (see below for more context on its dependencies).
2. systemctl stop foo
3. switch-to-configuration test
4. Now, foo.service should be started again.
Expected behavior
foo.service shouldn't be started again.
Screenshots
no
Additional context
After foo.service is/was stopped, the issue can be boiled down to systemctl daemon-reload; systemctl start multi-user.target which is effectively issued by switch-to-configuration.pl.
Now, there are two combinations I've observed which may be relevant to the issue:

foo.service had wantedBy = [ "multi-user.target" ]; set. I think if the service got stopped before (e.g. by hand), it shouldn't be brought up automagically by switch-to-configuration.pl.
foo.service didn't have wantedBy = [ "multi-user.target" ]; set and no other dependencies declared. However, it had a timer foo.timer declared like this:{
  wantedBy = [ "timers.target" ];
  after = [ "network-online.target" ];
  timerConfig = {
    Persistent = true;
    OnCalendar = "*-*-* 00/2:00:00";
    OnActiveSec = "0s";
  };
}

Notify maintainers
cc @dasj
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

This is directly related to https://github.com/NixOS/nixpkgs/issues/228528

This is directly related to #228528

Oh yeah given that they also suspect systemctl daemon-reload to be part of the problem, both issues had probably the same root cause.
Originally I went from a different starting point (Type=simple most notably and in one case even w/o any timer) to investigate it and given the different base situation I also failed to find another issue being related to that :sweat_smile:
cc @winterqt I think you were right with your suspicion of systemctl daemon-reload as described above.
What I'm wondering is, is this the expected behavior of systemctl daemon-reload? I mean, it's certainly supposed to refresh its state, but not entirely sure if it's supposed to forget about units that were started up correctly. Running systemctl start multi-user.target (as opposed to systemctl restart multi-user.target) doesn't seem to start up these units. So maybe we can defer the entire issue to systemd?


Celery-With-Beanstalk... missing setup.py?

Reproduce:
$ brew install python --framework
$ mkvirtualenv bean -p /usr/local/Cellar/python/2.7.2/Frameworks/Python.framework/Python
$ pip install -U celery-with-beanstalk

Relevent lines from pip.log:
  Downloading celery-with-beanstalk-2.4.tar.gz
  Downloading from URL http://pypi.python.org/packages/source/c/celery-with-beanstalk/celery-with-beanstalk-2.4.tar.gz#md5=348fe773ee727ab8daeddd5e1339a87d (from http://pypi.python.org/simple/celery-with-beanstalk/)
  Running setup.py egg_info for package celery-with-beanstalk
    Traceback (most recent call last):
      File "<string>", line 14, in <module>
    IOError: [Errno 2] No such file or directory: '/Users/glind/venvs/bean/build/celery-with-beanstalk/setup.py'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 14, in <module>

IOError: [Errno 2] No such file or directory: '/Users/glind/venvs/bean/build/celery-with-beanstalk/setup.py'

----------------------------------------
Command python setup.py egg_info failed with error code 1
Exception information:
Traceback (most recent call last):
  File "/Users/glind/venvs/bean/lib/python2.7/site-packages/pip-1.0.2-py2.7.egg/pip/basecommand.py", line 126, in main
    self.run(options, args)
  File "/Users/glind/venvs/bean/lib/python2.7/site-packages/pip-1.0.2-py2.7.egg/pip/commands/install.py", line 223, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/Users/glind/venvs/bean/lib/python2.7/site-packages/pip-1.0.2-py2.7.egg/pip/req.py", line 986, in prepare_files
    req_to_install.run_egg_info()
  File "/Users/glind/venvs/bean/lib/python2.7/site-packages/pip-1.0.2-py2.7.egg/pip/req.py", line 222, in run_egg_info
    command_desc='python setup.py egg_info')
  File "/Users/glind/venvs/bean/lib/python2.7/site-packages/pip-1.0.2-py2.7.egg/pip/__init__.py", line 255, in call_subprocess
    % (command_desc, proc.returncode))
InstallationError: Command python setup.py egg_info failed with error code 1

ls -1:
(bean)517 glind ~ $ ls -1 /Users/glind/venvs/bean/build/celery-with-beanstalk/
PKG-INFO
README
celery_with_beanstalk.egg-info
pip-egg-info
setup.cfg
tmp6vUV58.py

This happens (for me, same conditions) with all the celery-with-* Bundles.  I will see if I can find a fix :)

duplicate of #576 .  closing.


CODEC-303: Refactor NoOpBaseNCodec to improve test logic

Jira

CODEC-303

Description
Replace test class NoOpBaseNCodec by mocking object and improve test design

Motivation

Decouple test class NoOpBaseNCodec from production class BaseNCodec.
Remove the redundant overridden methods.
Make testing logic more explict.

Key changed/added classes in this PR

Created mocking object to replace test subclass NoOpBaseNCodec, decoupled test from production code.
Remove test subclass NoOpBaseNCodec.
Created method that return the mocking object for code reuse.
Add Mockito dependency.

We can also get rid of the method that return the mocking object and directly create the mocking object inside of each test case.

While this seems like a clever use of Mockito, it hinders ease of understanding the code and maintenance IMO.
Mocking is a great technique for certain use cases, this isn't one of them IMO. The current noop adapter is clear, simple, and can be stepped into while debugging if needes.

@garydgregory, thanks for providing the feedback! What do you think about this case, do you think we will get benefit from Mockito by replacing the inheritance with spying object? IMO It seems like the only reason we use inheritance is because we cannot directly create an instance from abstract class.

Using Mockito here I feel falls under the old adage "Once you have a hammer, everything starts to look like a nail." The class in question is an abstract class and therefore cannot be instantiated, the proper use case is subclassing, both for an app and therefore for a test. Using Mockito to avoid using a concrete subclass only obfuscates what the test is trying to do, makes the code harder to maintain and to learn as you are now requiring new users and maintainers to learn Mockito on top of learning the code base.
In other code bases, a noop concrete type might be part of the main tree instead of in the test tree and this whole thread would likely not even come up.
IOW, the shortcut Mockito affords is not worth the complexity it requires to learn and maintain.

@garydgregory I see, thanks you much for providing such detailed feedback!


Fix moderation button time units when not using seconds

Pull request checklist:

[X] CHANGELOG.md was updated, if applicable

Description
This PR fixes the displayed time unit in moderation buttons, when using time units other than seconds in the action.
For example:
In the current behavior, the action /timeout {user} 1m would show as 1s in the button text. After the fix it would show as 1m.
This applies to minutes (m), hours (h), days (d), and weeks (w).
Note that when specifying a time that isn't divisible by the closest unit, it will be rounded down, i.e. 61m displays as 1h.
This is the case with the current behavior, I also considered an alternative implementation that would show the accurate time, however this can lead to some bad looking buttons (1441m instead of rounding to 1d=1440m).
I would like some feedback on which option is preferred.
Fixes #1719

When putting in a stupidly large timeout value (such as 7000d) the numeric value can extend past the button into the user's name:
Pre-change:

Post-change:

Silly edge case but it exists.

The maximum timeout duration is 2 weeks. I think we should limit what the user can input in the settings more than anything.

When putting in a stupidly large timeout value (such as 7000d) the numeric value can extend past the button into the user's name

Note that this already happens pre-change, just if you specify the stupidly large timeout value in seconds/with no unit:
On nightly, with the action /timeout {user} 864000000 I get this button:

My change only generalizes the implementation to correctly display durations specified in units other than seconds (and also apparently adds weeks to the possible displayed durations)
However, I do agree that some sort of limit can/should be put into place, either on the duration or on the number displayed in the button (can maybe limit the button to display max 2w?). With how this is currently implemented the duration might also suffer from an overflow.
I don't mind adding something like this, just not sure if it should happen as a part of this PR.

That's fair, happy for that to be fixed in a separate issue.


Why I can not find the DNS node

My system is armbian

What is going wrong? Is DNS working?

"dnsmasq: failed to create listening socket for port 53: Address already in use"

I can't know which program is occupying the port.

sudo netstat -lntup

Where is my problem?

It looks like you have both a DNS server and dnsmasq trying to listen on port 53, so you'll have to turn one of them off.
Note that this project only supports Raspbian, not Armbian. So you may have to so some investigation of your own if you want to get this working.

Then how do I uninstall the original DNS service?

You will have to solve that yourself. I don't know anything about Armbian.

I don't know that's the default DNS service.

armbian www.armbian.com


Change FMod to SoLoud

Known design flaws:

For some vorbis ogg files that may be corrupted, LoadSound will not work and will need to be streamed using PlayMusic.

See more information in FModToSoLoud .
Note: More testing is needed.

#19

Blitz3D vanilla is migrating to Soloud due to unclear legal issues in Fmod. Blitz3D TSS is also planning on migrating to Soloud.
In theory, this change can remove fmod.dll once and for all from the game's directory only. Currently, the effects of this change are still unclear, and require further testing by developers before it becomes an official feature.
This is a test build for testing. Expressing your thoughts is highly recommended: bin.zip


vscode: yet another refactor commit

It compiles, it runs in dev extension host, It bundles, it runs when bundled and installed.
Removed 5 lines of code as you like less code, especially TypeScript code)

@matklad, do we merge this?

@matklad , do we merge this?

bors r+


text to speech

is there any functionality where we can have speech for the texts on the ui as it replies?

@prairitm Do you mean accessibility for blind people?
I listed accessibility in feature list but it's a huge task, and it cannot come soon.

@prairitm Do you mean accessibility for blind people?
I listed accessibility in feature list but it's a huge task, and it cannot come soon.

Inactivity


(Temporarily) don't download clang package

Nope, still doesn't work - try removing the llvm sources as well?

Done.

Check this : https://github.com/travis-ci/travis-ci/issues/6120

Seems neat, but too hard for me to understand ☹

Urrr. clang: error: unknown argument: '-fno-sanitize-recover=all' - this option comes from our config, but is wrong for the old clang (which needs '-fno-sanitize-recover' instead I think...). Switch ubsan builds to gcc-5?
Otherwise, seems to be working - builds are failing with real errors now :/

@FdaSilvaYY - thanks for the pointer! But swapping compilers is a simpler hotfix for now.

Pushed update to use gcc not clang ☹

@richsalz bad indent I think.
Otherwise +1 (just check that the travis run starts successfully before you push - it'll bail fast if the yml is bad)

Fixed the indent.  Pushing to master now.

I think that I will leave this open as a reminder that we need to revert the commit, a15cfae


Template Variable navigation shows no parent and children for active item

Description:
page.header.navigation.active.children

and
page.header.navigation.active.parent

are null, even if there is a parent and also children.
Environment:
Steps to reproduce:
Make Categories and dumnp() these vars
Expected result:
parentId respectively array of children
Actual result:
null

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-35257.
[created from NEXT-35257, comment 486525]

[public] Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know. Thank you again for your valuable feedback.
[created from NEXT-35257, comment 519435]


GeoPackage divide_id attribute hotfix

HF pre-release files actually use a different schema and different ID attribute for divides, this PR makes that version work properly for GPKG files. The new format in geojson representation is not fixed. This may break older GPKG formats, but tries to leave them working--no guarantees. Going forward GPKG format is only intended to support the latest HF formats.
Additions

Can now pass an id_col when reading features table from GPKG, some probing tries to guess which to pass for the divides layer.

Removals

Changes

Testing

Screenshots
Notes

Todos

Probably remove support for the never-released format, do something with geojson support (update for new format/both formats, or deprecate?)

Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows project standards (link if applicable)
[X] Passes all existing automated tests
[X] Any change in functionality is tested
[X] New functions are documented (with a description, list of inputs, and expected output)
[X] Placeholder code is flagged / future todos are captured in comments
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[X] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist (automated report can be put here)

Target Environment support

[X] Linux

Code otherwise looks reasonable to me.

I finally validated that the updated sample dataset included here does work with routing, so this is ready to go. I noticed that I omitted some deletions however. @PhilMiller or @hellkite500  can you re-approve? Thanks.


Building MAVSDK v1.0.8 with gcc-4.9

Hey,
i'm currently trying to build libmavsdk with gcc-4.9. It seems that some test requires CXX17. Is it possible to build it cc-4.9?
Error Output Log:
CMake Error in src/CMakeLists.txt:
Target "unit_tests_runner" requires the language dialect "CXX17" (with
compiler extensions), but CMake does not know the compile flags to use to
enable it.
CMake Error in src/mavsdk/CMakeLists.txt:
Target "mavsdk" requires the language dialect "CXX17" (with compiler
extensions), but CMake does not know the compile flags to use to enable it.
CMake Error in src/third_party/gtest/googlemock/CMakeLists.txt:
Target "gmock" requires the language dialect "CXX17" , but CMake does not
know the compile flags to use to enable it.
CMake Error in src/third_party/gtest/googlemock/CMakeLists.txt:
Target "gmock_main" requires the language dialect "CXX17" , but CMake does
not know the compile flags to use to enable it.
CMake Error in src/third_party/gtest/googletest/CMakeLists.txt:
Target "gtest" requires the language dialect "CXX17" , but CMake does not
know the compile flags to use to enable it.
CMake Error in src/third_party/gtest/googletest/CMakeLists.txt:
Target "gtest_main" requires the language dialect "CXX17" , but CMake does
not know the compile flags to use to enable it.
CMake Error in src/integration_tests/CMakeLists.txt:
Target "integration_tests_runner" requires the language dialect "CXX17"
(with compiler extensions), but CMake does not know the compile flags to
use to enable it.
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.
[ERROR]: build failed with error Code: 1

MAVSDK C++ is using C++17 features, so you need a compiler that supports these. GCC 4.9 is definitely too old, sorry.


Javascript call opens browser on Android

Hi,
on the top bar i have a back button. I couldn't find a nice way to navigate back with blazor, so i used a js call to do so.
My component has the following elemtn:
<img class="top-row-left" src="assets/ionicons/chevron-back-outline.svg" alt="<" onclick="window.history.go(-1)" />
In the BlazorMobile project this is working fine, while in android it's opening chrome with the last link, which should open in the web view inside the app.
I don't know if this is a bug or by design. Would be nice to find a solution for my back navigation problem though.

There is no plan for blazor to implement the browser history api in the IUriHelper. See https://github.com/dotnet/aspnetcore/issues/12838

Hi !
I have made some code on each supported platforms in order to allow WebView navigations to be catched when detected, allowing you to create your own business app logic, like opening external resource outside your app, allowing the navigation request, or denying it.
It's like the regular Xamarin.Forms OnNavigating event on WebView (and even, i use the same interface internally), the only difference is that i reimplemented the logic on extra platforms (like ElectronNET, and Android because we use GeckoView instead of the OS Browser at runtime).
The other difference is that iframe navigation will also be detected and forwarded, that can be nice too.
The OnNavigating event is totally programmable by yourself.
Please read this from BlazorMobile documentation: Validating the Blazor application navigation
Then go back to me if this fixed your issue, i will then close it.

Forgot to mention that the browser opening behavior you are having now may be because of the default handler implementation shipped within the template. Just put a break point while debugging on Android in your OnBlazorWebViewNavigationHandler.cs file (or another if you create yourself a new one), and inspect the values coming when your navigation occur.

I'll try that and post the result when finished

So on navigation the events url is "http://<IP_ADDRESS>:8888/code/B"
Template default behavior:
`else if (e.Url.StartsWith(WebApplicationFactory.GetBaseURL(), StringComparison.OrdinalIgnoreCase))
{
//Here, our application is loading an URI
//You may add a custom logic, like opening a new view, changing the URI parameters then opening a view...
            e.Cancel = true;

            switch (BlazorDevice.RuntimePlatform)
            {
                default:
                    Device.OpenUri(new Uri(WebUtility.UrlDecode(e.Url)));
                    break;
            }
        }`

When url starts with base url we should maybe do nothing instead of starting the device's browser.
Thank you for helping out. Nice work! Keep going on i'm sure this will be the future of client applications.

Actually, the original line should be right in a Blazor scenario. When navigating through your Blazor application, your browser is not "really" navigating, that would mean a full page navigation instead. That's why when you go from one page to another, even if the URL is different, this handler is not called.
If the event here has been fired this mean that while you have navigated backward with your code, the browser asked for a real page navigation. This may be not what your expecting, as it mean a full reload of the page.
But i don't know what your code is doing. Be just aware of the meaning of this event handler.
Thanks for the congrats ! Some very cool features (and fixes) are coming in a release tomorrow or sunday (i wish), like switching loaded app, storing and loading downloaded app...
It will allow to easily update your app in the background without having your user going to the app store if you like, at least if your "native" codebase have not changed or does not impact your Blazor app runtime !

Very nice. Hyped to see it.
So this means that JS call to window.history.go(-1) calls a "real navigation". So since blazor doesn't support navigating back currently (afaik see issue mentioned above), how to do this in a nice way (I don't want to pass through the origin destination).

Yes of course, it may be not a problem at all, i was just saying that this navigation is a side-effect you don't have when navigating through your gestures on the phone (clicking buttons etc..). And so, will this behave as smooth as expected, or the same ?
Also, i may not be aware of all side effects of the "navigating" event of every browser.
Maybe this event is catched by GeckoView engine (if you are on Android) BUT even if it's notified, maybe it don't do a full reload.
Can you confirm me that if you use window.history.go(-1), your app don't reload completely ?
If so, it would be interesting that i try to exclude theses "not full" navigating behavior (or at least on browsers that do this).
Thanks for your questions !

By the way, you called Gecko. Visual Studio gives me this warning all the time

This warning was there since i started with the creation from template fyi.

Navigating back seems to not reload completely. I'm sure there's a trick to find out. I'm new to blazor so can you tell me how to find out? Can i find out by overriding OnInitialized on the MainLayout component?

By the way, you called Gecko. Visual Studio gives me this warning all the time

This warning was there since i started with the creation from template fyi.

Don't take this warning into account. This is just because a "base" package was set as a dependency on this package, but it doesn't find the right NuGet version at build time, as the number was generic, targeted for all 27.0.x versions of Android API. It resolve with a compatible version
by itself, and it doesn't break anything in fact.

Navigating back seems to not reload completely. I'm sure there's a trick to find out. I'm new to blazor so can you tell me how to find out? Can i find out by overriding OnInitialized on the MainLayout component?

If everything is ok, go ahead in my opinion, with your current behavior.
You have multiple "tricky" way to do this, one would be to inherit all you "page" objects from an extended base model, that would cache the current rendered page. Another would be to try if you can listen to the javascript history change, or if window.location.href change , and store the value.
You will surely find more solutions on the net.
In the end, if you have the previous url (and parameters as well if possible), you may use the navigation manager of Blazor, and try to navigate to the page from the informations you know.
But as i said, if everything is working properly, don't make it complicated yet. Just manage the "false positive" in the WebViewNavigationHandler and go ahead.

Okay then. Thank you very much for helping out. Changing the navigation handlers behaviour to not start a browser resolves the issues.
You are right, i could use the navigation manager of Blazor BUT that would mean i have to pass through the origin destination to every site whith back navigation enabled. I can't understand why they don't want to implement the back navigation in browser history to their interface. But if that is their decision (by design), i keep going on with the js interop workaround as many Blazor users do atm
Have a nice evening ;)

Thanks ! You too !

As I expected, the navigation bug with window.history.go is related to Webextension and onbeforerequest events on it. Someone found this behavior here too: https://github.com/piroor/newtabfromlocationbar/issues/18#issuecomment-347074234 so it’s specific to Webextension modules (and in our case, Android)


How to add Token in every request

Dear Friends.
I did my research but i did not find any solution to add the token if it is already exist.
I know that the updater is supposed to add the token to header after s successful log-in but what about a case when user is already logged in and has a valid token? there should be a function to add the token to any request if the token is available.
is there anything that I am missing here?
I suggest a request function to the interceptors to add the header. is there any similar functionality that i am not aware of?

So this can be closed then?


perf(sourcemap): reduce string copying in ConcatSourceMapBuilder

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4638  👈
#4634 : 1 other dependent PR (#4635 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


control of USART serial format

I've started attempting to use the serial abstraction, and immediately needed to tweak the flags. The existing code:
        usart
            .cr1
            .write(|w| w.ue().set_bit().te().set_bit().re().set_bit());

I needed to change to:
        usart
            .cr1
            .write(|w| w
              .ue().set_bit()
              .te().set_bit()
              .re().set_bit()
              .m().set_bit()    // 9 data bits
              .pce().set_bit()  // enable parity
              .ps().clear_bit() // even parity
              );

        usart.cr2.write( |w| w
          .stop().bits(2)    // 2 stops bits
        );

It didn't seem possible to set these flags prior or after the call to Serial::usart2().  Have you any ideas as to how you would generalise the API to allow control over the serialized format? Perhaps an extra parameter with options to control parity, number of stop bits etc?

I think the builder pattern is most rustic way of doing this kind of thing :smile:

@timbod7 Please close this if you're happy with the current state.
NB: You can also add a "Fixes #" to your PR and then the issue will autoclose when the PR is merged.


Cannot create URL for blob!

Describe the bug
Cannot upload images via method UploadClient.uploadFile on android using Expo Go.
I get the following error:
"Cannot create URL for blob!"

When I try to upload an image to Uploadcare via the JS api client, it fails on android only

Expected behavior
The image 'test.jpg' is expected to be uploaded to ImageCare upon following code being executed:
Code / screenshots
import { UploadClient } from '@uploadcare/upload-client'

const client = new UploadClient({ publicKey: 'XXXXXXXXX',  })

// Uploads an image to UploadCare
export const uploadToUploadCare = async (blob: Blob, fileName: string) => {
	try {
		const fileRef = await client.uploadFile(blob, {
			fileName,
		})

		return fileRef.cdnUrl

	} catch (e) {
		console.warn(e)
		throw e
	}
}

// Grabs first image from gallery and calls uploadToUploadCare
const testUploader = async () => {
	try {
		const images = await MediaLibrary.getAssetsAsync({
			sortBy: 'creationTime',
			first: 1,
			mediaType: [MediaType.photo, ],
		})

		const img = await fetch(images.assets[0].uri)
		const blob = await img.blob()

		await uploadToUploadCare(blob, 'test.jpg')

	} catch (e) {
		alert(e)
	}
}

testUploader()

Environment

Library version:
5.1.1

Language/framework version:
expo: 46.0.0 (managed workflow)
react-native: 0.69.6

OS version:
Android 11 (OnePlus 6)

Hey @slytter,
is it reproducible on the emulator?

We are also experiencing this issue. Is there a solution or workaround available?
@uploadcare/upload-client": "5.1.1"

React: 17.0.2
React Native: 0.68
@uploadcare/upload-client: 5.1.1
Android:
googlePlayServicesVersion = "17.+"
buildToolsVersion = "31.0.0"
minSdkVersion = 21
compileSdkVersion = 31
targetSdkVersion = 31
export default async function uploadPhoto(media: Asset) {
  try {
    if (!media.uri) return;
    // TODO: Add logic to handle video uploads and multiple uploads
    const imageUri = await fetch(media.uri);
    const blob = await imageUri.blob();
    const asset = {
      fileName: media.fileName,
      type: media.type,
      uri: media.uri,
    };

    // asset type works on Android but not iOS
    const filePayload = Platform.OS == 'android' ? asset : blob;

    const uploadedFile = await client.uploadFile(filePayload, {
      contentType: media.type,
      fileName: media.fileName,
    });
    if (uploadedFile.cdnUrl) {
      return uploadedFile.cdnUrl;
    }
  } catch (e) {
    console.warn(e);
  }

I updated the filePayload to use Image asset for android because blob format didn't work on Android
And when I updated the upload care version<EMAIL_ADDRESS>and the following code https://github.com/uploadcare/uploadcare-js-api-clients/blob/ed04c9c991a3a832cef2263b98f40824bcbbe4d1/packages/upload-client/README.md#react-native
Android manifest from your suggestion above, It started failing with upload care public key is required error even when I had the public key attached


Create a standalone package

I think there's a good reason to package some modules into a shared module so we can do something like this:
import FloKit

// from FloKit
AlbumService.fetchAlbums()

So we can use it anywhere across the project. Wdyt @alvinisasi

cool, wait till i grab about package manager


Fix/bug 424 review next cache race

Fixes #424 and #582 (duplicate)
Bonus: avoids syncing for the whole vault by changing scheduledNotes within the reviewDecks in-place.

Hi @karimodm  I'm a little confused by the status shown by GitHub

Do you know why it is saying "lint_and_test Expected — Waiting for status to be reported"? My experience is that this only displays temporarily whilst the test is being performed (a minute or two)
Cheers
Ronny

I think the workflow is waiting for an approval to be run! Can you please approve @ronzulu or we have to ask @st3v3nmw ?

I think the workflow is waiting for an approval to be run! Can you please approve @ronzulu or we have to ask @st3v3nmw ?

Hi @st3v3nmw
@karimodm's fix LGTM and has also been tested by @axb. Could you please approve and merge. I don't think this is something I can do.
Cheers
Ronny

Hi @st3v3nmw
I'm pretty sure that by fixing this @karimodm also fixed:
#437 [BUG] Update number of notes after a review
#837 [BUG] the number of notes to be reviewed in status bar is incorrect
Could you please check. Would be great if we can close off another 2 issues!
Cheers
Ronny


fix "setAttribute" bug in git log

With the latest Mac OS X update I noticed an error being thrown when I try to expand code blocks in the "git log" ui. This fixes the problem

@infininight please merge and publish this patch, otherwise the git browse window is broken

Pulled and deployed, thanks! Sorry for the delay.

Thanks!


Test for virtual host style requests

https://github.com/minio/minio/pull/5095 should have mint tests.
Test can be done like this:

add the following entries in /etc/hosts in docker image

<IP_ADDRESS> test.mydomain.com
<IP_ADDRESS> mydomain.com

This is needed because if the bucket is test and endpoing is mydomain.com then the client requests will be done on the host test.mydomain.com which should be resolved to localhost (docker container itself)

run awscli tests with the following setting (in addition to path style tests)

aws configure set default.s3.addressing_style virtual

@nitisht run.sh should look like this so that it runs both path and virtual style:
#!/bin/bash
#
#  Mint (C) 2017 Minio, Inc.
#
#  Licensed under the Apache License, Version 2.0 (the "License");
#  you may not use this file except in compliance with the License.
#  You may obtain a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
#  Unless required by applicable law or agreed to in writing, software
#  distributed under the License is distributed on an "AS IS" BASIS,
#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#  See the License for the specific language governing permissions and
#  limitations under the License.
#

# handle command line arguments
if [ $# -ne 2 ]; then
    echo "usage: run.sh <OUTPUT-LOG-FILE> <ERROR-LOG-FILE>"
    exit -1
fi

output_log_file="$1"
error_log_file="$2"

# configure awscli
aws configure set aws_access_key_id "$ACCESS_KEY"
aws configure set aws_secret_access_key "$SECRET_KEY"
aws configure set default.region "$SERVER_REGION"

# run tests
endpoint="http://$SERVER_ENDPOINT"
if [ "$ENABLE_HTTPS" -eq 1 ]; then
    endpoint="https://$SERVER_ENDPOINT"
fi
./test.sh "$endpoint"  1>>"$output_log_file" 2>"$error_log_file"
aws configure set default.s3.addressing_style virtual

@nitisht  i see a bunch of commits for this issue. SHould this be closed then?


SCT-1058 Error handling for deleted workspaces in search results

Thanks, uma.
I just wanted to take this opportunity to raise again a couple of issues.
First is how it is possible to get into this situation, in which search results are returned for deleted objects. It is expected that there is a lag between workspace changes and the index update, and in that window this condition may arise.
But in the reported case, and others, the condition for the search result appears permanent.
I don't know if workspace events are considered to be lossy or not, but that is one possible explanation in this case; missed workspace events. Could also simple be a bug somewhere in workspace event emission, transport, handling, etc.
In the context of this change, perhaps the detection of this condition could lead to back pressure on the index to ensure that the offending index entires are corrected?
The other issue is how search represents this condition to callers of the searchapi. I think this set of changes will set the workspace info to null, which is consistent with how workspace calls handle ignoring errors. Another approach is to consider omitting all traces of invalid search results like this and return the results as if the inaccessible results were not there. It may be a simple statement, but it is a complex problem. What about summary results? They will include the invalid results because the summary (search_types) does not consult the container workspace. It also would require multiple ES queries to fill up the results buffer (whatever the page size is). But, it would present a consistent view of search. The alternative requires that all consumers of search account for results which may be associated with inaccessible objects, which could lead to cascading errors.


RoI align in pytorch?

❓ Questions and Help
I see that RoIAlign has been written in cuda here: https://github.com/facebookresearch/maskrcnn-benchmark/blob/master/maskrcnn_benchmark/csrc/cuda/ROIAlign_cuda.cu
I am wondering if there was any particular reason it was not written in python?

roi pool and roi align are now implemented in torchvision.ops. Pretty convenient and easy to work with in Python.


Implement var keyword

One area where I personally see Jakt as hard to read is let mutable. After let, my brain wants to see an identifier. Can you declare more than one identifier per line? Is it let mutable a, mutable b or let mutable a, b? If the latter, it is really ambiguous. If the former, that is some real estate inflation if I want to declare say 5 mutable identifies in something like a math function.
We can say that Jakt is “immutable by default” but in the first two app samples there is mutability everywhere.
Consider reserving let to mean immutability unambiguously. Then use var when mutability is wanted.
Instead of
let mutable c = fgetc(file)
while feof(file) == 0 {
     putchar(c)
     c = fgetc(file)
}

we would write
var c = fgetc(file)
while feof(file) == 0 {
     putchar(c)
     c = fgetc(file)
}

My 2c: It should by intentionally more difficult to write mutable variables, as immutability is good and the default.

The Jakt intro makes the point that code is read more than it is written and that readability should be a priority. I agree with this.
IDE support will take away most of the pain of writing mutable every time anyway. You can see this support being added already. I doubt idiomatic Jakt will be deeply forged by the difference between let mutable and var. One just looks a lot nicer and allows me to understand the code more quickly ( if I see let right now I have to pause and ask which kind of let it is ).

if I see let right now I have to pause and ask which kind of let it is

No, it's the other way around. If you see let, you just continue reading to see which kind of let it is. When you see let or var, you have to stop thinking which one is which.

Well, Andreas implemented it as the mut keyword instead of var but I got my wish as of commit a2b238d14a0f70f6374b02f9c2fc0337cb2c9d14


Update for Poppler v22.01

Poppler 22.01 introduced a change wherein what were previously GooString* instances are now wrapped in an std::optional. This feature is only supported by C++17 and onwards.
This PR updates the build process to use C++17.

@adrianfalleiro, published as v0.11.1

Legend, thanks 🙏


Add Data Steward field to system portal

fidesplus#677 has been split into two tickets. The panel portion will remain in fidesplus

 UX fixes for data map/table


Cannot load trained model

Hi,
Thank you for sharing your work, and for labeling the dataset (looks like a lot of hard work).
I encounter a problem with loading the trained .pth file for evaluating.  Speficifally the error looks like:
model.load_state_dict(checkpoint['model'], strict=False)
KeyError: 'model'
I will appreciate any suggestions on the problem.
Thanks

Hi
Could you provide some additional information? Namely, how do you save the model to the .pth file? And how is your model created?

Hi thanks for getting back to me so quickly! I got the model directly from running python train_rcnn.py --data_path /path/to/MinneApple/dataset --model mrcnn --epochs 50 --output-dir /path/to/checkpoint/directory
Could this be a torch version issue? I am on version 1.1.0...

No this is an issue in the code. I just pushed a fix, I was loading the model differently from what was actually saved. To avoid retraining of your model, you should be able to just load the model like this:
model.load_state_dict(torch.load(PATH))
If you actually need the optimizer and scheduler state, I am afraid you will have to retrain the model with the newly pushed changes.
Hope this helps

Hi Nicola,
Thanks! I just fixed the problem, it's similar to this but you also need to have strict = False at the end, otherwise, It will report a problem about missing parameters.


Injecting Template or Template props on KcApp

First of all thanks for the great work!
I'm trying to use Keycloakify with the least cost of development, but there is a huge gap between only changing the css and adding any kind of customization involving js or html. My current use case is to simply add a logo on the Header Title (for ex. Sign In on the Login page).
I'm unable to do it in a simple manner because the base component Template.tsx is hardcoded on the page components, which makes it impossible to change the Header for every page (I'd need to copy-paste everything for a simple props change in Template).
Would it be possible to have injected the Template component inside KcApp or at least make the props from the Template component available to KcApp? (some care must be taken since we need to access runtime props like i18n when passing them down, so we can continue to use the good support already existing in Keycloakify.
Many thanks!

Hi @julio-louzada, thanks for reaching out.

Would it be possible to have injected the Template component inside KcApp

Yes, this would make a lot of sense, I'll do that.

I didn't forget.
I just didn't find the time yet...

Hi @julio-louzada,
That's it, it's possible in Keycloakify v6.8.0.
https://github.com/InseeFrLab/keycloakify/blob/85a68357482268696be32b0d7f8d67ab6309bbd3/README.md?plain=1#L52-L56
Thank you for suggesting this enhancement,