Error offloading:

I'm getting this error when trying to manually offload a topic to s3 bucket.
Broker config
managedLedgerOffloadDriver=aws-s3
s3ManagedLedgerOffloadRegion=us-west-2
s3ManagedLedgerOffloadBucket=mybucket
s3ManagedLedgerOffloadServiceEndpoint=https://mybucket.blabla.blabla.com/
Error
Reason: Error offloading: org.apache.bookkeeper.mledger.ManagedLedgerException: java.util.concurrent.CompletionException: org.jclouds.aws.AWSResponseException: request POST https://mybucket.blabla.blabla.com/mybucket/3aab7c02-81ab-470b-badb-7e4e5c74bb2d-ledger-19?uploads HTTP/1.1 failed with code 400, error: AWSError{requestId='....', requestToken='....', code='AuthorizationHeaderMalformed', message='The authorization header is malformed; the region 'us-east-1' is wrong; expecting 'us-west-2'', context='{Region=us-west-2, HostId=....}'}

It doesn't matter what region a use in s3ManagedLedgerOffloadRegion I'm always getting the same error. (the right region is us-west-2 as shown on the config)
System configuration
Pulsar version: 2.3.0

@geyrix57 , If you are using other blobstore provider rather than "aws-s3",
you should use config:
managedLedgerOffloadDriver=s3
s3ManagedLedgerOffloadBucket=mybucket
s3ManagedLedgerOffloadServiceEndpoint=https://mybucket.blabla.blabla.com/

Seems currently there was some regression. I am still trying to fix "s3" type. will update this issue once fixed.

We ran into this issue in 2.4 as well. What's the current status/plan? Is this gonna be fixed in 2.4.1?

will check and handle this issue

Also seeing this with pulsar 2.5.1 trying to use a bucket in ap-southeast-2

Also seeing this with pulsar 2.5.1 trying to use a bucket in ap-southeast-2

Thanks @lukestephenson-zendesk feedback, can you provide your configuration? If possible, you can also provide specific error information.

@geyrix57

s3ManagedLedgerOffloadServiceEndpoint=https://mybucket.blabla.blabla.com/

The s3ManagedLedgerOffloadServiceEndpoint useful for testing, If you are using a real AWS-S3 bucket, you can not configure this option, reference to authentication-with-aws.

@wolfstudy I'm getting the same with pulsar 2.5.0 also I use a non-standard region eu-west-1
My pulsar config:
managedLedgerOffloadDriver: aws-s3
s3ManagedLedgerOffloadBucket: test-offload-bucket
s3ManagedLedgerOffloadRegion: eu-west-1

Broker logs:
15:23:53.548 [pulsar-io-24-1] INFO  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:49920][persistent://packhunt/tests/test-topic-1] Creating producer. producerId=0
15:23:53.549 [Thread-1050] INFO  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:49920] persistent://packhunt/tests/test-topic-1 configured with schema false
15:23:53.550 [Thread-1050] INFO  org.apache.pulsar.broker.service.ServerCnx - [/<IP_ADDRESS>:49920] Created new producer: Producer{topic=PersistentTopic{topic=persistent://packhunt/tests/test-topic-1}, client=/<IP_ADDRESS>:49920, producerName=pulsar-50-1007, producerId=0}
15:23:53.603 [bookkeeper-ml-workers-OrderedExecutor-7-0] INFO  org.apache.bookkeeper.mledger.impl.OpAddEntry - [packhunt/tests/persistent/test-topic-1] Closing ledger 2227 for being full
15:23:53.608 [bookkeeper-ml-workers-OrderedExecutor-7-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [packhunt/tests/persistent/test-topic-1] Going to automatically offload ledgers [2215, 2216, 2217, 2218, 2219, 2220], total size =<PHONE_NUMBER>, already offloaded = 0, to offload =<PHONE_NUMBER>
15:23:53.608 [bookkeeper-ml-workers-OrderedExecutor-7-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [packhunt/tests/persistent/test-topic-1] Preparing metadata to offload ledger 2215 with uuid b965b889-7202-4ada-9dd3-d9ce07b552d8
15:23:53.608 [bookkeeper-ml-workers-OrderedExecutor-7-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [packhunt/tests/persistent/test-topic-1] Found previous offload attempt for ledger 2215, uuid b965b889-7202-4ada-9dd3-d9ce07b552d8, cleaning up
15:23:53.618 [pulsar-web-33-3] INFO  org.eclipse.jetty.server.RequestLog - <IP_ADDRESS> - - [16/Jun/2020:15:23:53 +0000] "GET /status.html HTTP/1.1" 200 2 "-" "kube-probe/1.14+" 0
15:23:53.618 [bookkeeper-ml-workers-OrderedExecutor-7-0] WARN  org.apache.bookkeeper.client.BookieWatcherImpl - New ensemble: [pulsar-bookie-3.pulsar-bookie.pulsar2.svc.cluster.local:3181, pulsar-bookie-2.pulsar-bookie.pulsar2.svc.cluster.local:3181, pulsar-bookie-0.pulsar-bookie.pulsar2.svc.cluster.local:3181] is not adhering to Placement Policy. quarantinedBookies: []
15:23:53.621 [pulsar-ordered-OrderedExecutor-5-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperCache - [State:CONNECTED Timeout:30000 sessionid:0x300000237e600ca local:/<IP_ADDRESS>:39918 remoteserver:pulsar-zookeeper/<IP_ADDRESS>:2181 lastZxid:4295194973 xid:14558 sent:14558 recv:15712 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: WatchedEvent state:SyncConnected type:NodeDataChanged path:/managed-ledgers/packhunt/tests/persistent/test-topic-1
15:23:53.621 [pulsar-ordered-OrderedExecutor-7-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperCache - [State:CONNECTED Timeout:30000 sessionid:0x200000249b200c4 local:/<IP_ADDRESS>:59370 remoteserver:pulsar-zookeeper/<IP_ADDRESS>:2181 lastZxid:4295194975 xid:15908 sent:15908 recv:17066 queuedpkts:0 pendingresp:1 queuedevents:1] Received ZooKeeper watch event: WatchedEvent state:SyncConnected type:NodeDataChanged path:/managed-ledgers/packhunt/tests/persistent/test-topic-1
15:23:53.621 [bookkeeper-ml-workers-OrderedExecutor-7-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [packhunt/tests/persistent/test-topic-1] Metadata prepared for offload of ledger 2215 with uuid b965b889-7202-4ada-9dd3-d9ce07b552d8
15:23:53.621 [pulsar-ordered-OrderedExecutor-0-0-EventThread] INFO  org.apache.pulsar.zookeeper.ZooKeeperCache - [State:CONNECTED Timeout:30000 sessionid:0x100045f141f00d4 local:/<IP_ADDRESS>:40648 remoteserver:pulsar-zookeeper/<IP_ADDRESS>:2181 lastZxid:4295194973 xid:16249 sent:16249 recv:17421 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: WatchedEvent state:SyncConnected type:NodeDataChanged path:/managed-ledgers/packhunt/tests/persistent/test-topic-1
15:23:53.625 [pulsar-ordered-OrderedExecutor-7-0-EventThread] INFO  org.apache.bookkeeper.client.LedgerCreateOp - Ensemble: [pulsar-bookie-3.pulsar-bookie.pulsar2.svc.cluster.local:3181, pulsar-bookie-2.pulsar-bookie.pulsar2.svc.cluster.local:3181, pulsar-bookie-0.pulsar-bookie.pulsar2.svc.cluster.local:3181] for ledger: 2233
15:23:53.625 [pulsar-ordered-OrderedExecutor-7-0-EventThread] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [packhunt/tests/persistent/test-topic-1] Created new ledger 2233
15:23:54.092 [offloader-OrderedScheduler-1-0] ERROR org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreManagedLedgerOffloader - Failed delete Blob
org.jclouds.aws.AWSResponseException: request POST https://test-offload-bucket.s3.amazonaws.com/?delete HTTP/1.1 failed with code 400, error: AWSError{requestId='031C5FE0A1D8315F', requestToken='F3G4gdz0gL7xFVMwIR1Dqcx+tNejlS7XeeRKc65VD6TpvCUYBeuPH5wOGmQHicUPZWchEhkihQQ=', code='AuthorizationHeaderMalformed', message='The authorization header is malformed; the region 'us-east-1' is wrong; expecting 'eu-west-1'', context='{Region=eu-west-1, HostId=F3G4gdz0gL7xFVMwIR1Dqcx+tNejlS7XeeRKc65VD6TpvCUYBeuPH5wOGmQHicUPZWchEhkihQQ=}'}
	at org.jclouds.aws.handlers.ParseAWSErrorFromXmlContent.handleError(ParseAWSErrorFromXmlContent.java:75) ~[?:?]
	at org.jclouds.http.handlers.DelegatingErrorHandler.handleError(DelegatingErrorHandler.java:65) ~[?:?]
	at org.jclouds.http.internal.BaseHttpCommandExecutorService.shouldContinue(BaseHttpCommandExecutorService.java:138) ~[?:?]
	at org.jclouds.http.internal.BaseHttpCommandExecutorService.invoke(BaseHttpCommandExecutorService.java:107) ~[?:?]
	at org.jclouds.rest.internal.InvokeHttpMethod.invoke(InvokeHttpMethod.java:91) ~[?:?]
	at org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:74) ~[?:?]
	at org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:45) ~[?:?]
	at org.jclouds.rest.internal.DelegatesToInvocationFunction.handle(DelegatesToInvocationFunction.java:156) ~[?:?]
	at org.jclouds.rest.internal.DelegatesToInvocationFunction.invoke(DelegatesToInvocationFunction.java:123) ~[?:?]
	at com.sun.proxy.$Proxy67.deleteObjects(Unknown Source) ~[?:?]
	at org.jclouds.s3.blobstore.S3BlobStore.removeBlobs(S3BlobStore.java:343) ~[?:?]
	at org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreManagedLedgerOffloader.lambda$deleteOffloaded$6(BlobStoreManagedLedgerOffloader.java:575) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_232]
	at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125) [com.google.guava-guava-25.1-jre.jar:?]
	at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57) [com.google.guava-guava-25.1-jre.jar:?]
	at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78) [com.google.guava-guava-25.1-jre.jar:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_232]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_232]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:1.8.0_232]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:1.8.0_232]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_232]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_232]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.43.Final.jar:4.1.43.Final]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]
15:23:54.100 [bookkeeper-ml-scheduler-OrderedScheduler-7-0] WARN  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - Error cleaning up offload for 2215, (cleanup reason: Previous failed offload)
org.jclouds.aws.AWSResponseException: request POST https://test-offload-bucket.s3.amazonaws.com/?delete HTTP/1.1 failed with code 400, error: AWSError{requestId='031C5FE0A1D8315F', requestToken='F3G4gdz0gL7xFVMwIR1Dqcx+tNejlS7XeeRKc65VD6TpvCUYBeuPH5wOGmQHicUPZWchEhkihQQ=', code='AuthorizationHeaderMalformed', message='The authorization header is malformed; the region 'us-east-1' is wrong; expecting 'eu-west-1'', context='{Region=eu-west-1, HostId=F3G4gdz0gL7xFVMwIR1Dqcx+tNejlS7XeeRKc65VD6TpvCUYBeuPH5wOGmQHicUPZWchEhkihQQ=}'}
	at org.jclouds.aws.handlers.ParseAWSErrorFromXmlContent.handleError(ParseAWSErrorFromXmlContent.java:75) ~[?:?]
	at org.jclouds.http.handlers.DelegatingErrorHandler.handleError(DelegatingErrorHandler.java:65) ~[?:?]
	at org.jclouds.http.internal.BaseHttpCommandExecutorService.shouldContinue(BaseHttpCommandExecutorService.java:138) ~[?:?]
	at org.jclouds.http.internal.BaseHttpCommandExecutorService.invoke(BaseHttpCommandExecutorService.java:107) ~[?:?]
	at org.jclouds.rest.internal.InvokeHttpMethod.invoke(InvokeHttpMethod.java:91) ~[?:?]
	at org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:74) ~[?:?]
	at org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:45) ~[?:?]
	at org.jclouds.rest.internal.DelegatesToInvocationFunction.handle(DelegatesToInvocationFunction.java:156) ~[?:?]
	at org.jclouds.rest.internal.DelegatesToInvocationFunction.invoke(DelegatesToInvocationFunction.java:123) ~[?:?]
	at com.sun.proxy.$Proxy67.deleteObjects(Unknown Source) ~[?:?]
	at org.jclouds.s3.blobstore.S3BlobStore.removeBlobs(S3BlobStore.java:343) ~[?:?]
	at org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreManagedLedgerOffloader.lambda$deleteOffloaded$6(BlobStoreManagedLedgerOffloader.java:575) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_232]
	at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125) ~[com.google.guava-guava-25.1-jre.jar:?]
	at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57) ~[com.google.guava-guava-25.1-jre.jar:?]
	at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78) ~[com.google.guava-guava-25.1-jre.jar:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_232]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_232]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:1.8.0_232]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:1.8.0_232]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_232]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_232]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.43.Final.jar:4.1.43.Final]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]

There is thread in slack channel for same issue https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1601393534056700
It depends on other configs, but maybe it can help you
In short try:

s3ManagedLedgerOffloadServiceEndpoint: https://s3.YOUR_REGION.amazonaws.com
If you cluster is running on AWS allow the IAM policy you are running as to do GetBucketLocation

Another related slack thread with the same issue https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1591968316415200?thread_ts=1591924819.402800&cid=C5Z4T36F7

There is thread in slack channel for same issue https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1601393534056700
It depends on other configs, but maybe it can help you
In short try:
* `s3ManagedLedgerOffloadServiceEndpoint: https://s3.YOUR_REGION.amazonaws.com`

* If your cluster is running on AWS allow the IAM policy you are running as to do `GetBucketLocation`

I can confirm I had the exact same issue and adding permissions for GetBucketLocation solved it.

Cool @yanirj. Looks like it's related to the configurations of the s3. So I will close this first and feel free to reopen it if needed.

I don't think this should have been closed.  Yes it is related to the configuration of pulsar / S3, but the fact the pulsar logs don't indicate the problem correctly make it almost impossible to debug.

I opened a new issue https://github.com/apache/pulsar/issues/9084, to help improve this within core Pulsar.
I agree that there can be improvements made to make this more straight forward! Some of the logging issues would also be a good improvement but it may take us understanding jcloud internals a bit more, as the error is seen essentially in part of initializing jcloud, so it may be difficult to get clearest context about these sort of issues


Adding a watch-close plugin/event

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
The only way to know when the watcher stops watching is if you add a callback to watcher.close(). If I don't have access to the watcher (e.g. hot-dev-middleware created it and I no longer have access to the middleware), then I have no way of knowing that the watcher stopped.
What is the expected behavior?
There's already a watch-run event.
I would like webpack.plugin('watch-close', () => console.log('watching closed')) to be emitted when the watcher has closed and compilation is done.
https://github.com/webpack/webpack/blob/479a0a4b7b22ed9c65c2f3c472a1be56db5ee0f0/lib/Compiler.js#L135
If this is a feature request, what is motivation or use case for changing the behavior?
To simplify waiting on a number of compilers to close.

I'm can submit a PR if you're happy with the behaviour described above.

Sure a PR would be great. Also see MultiCompiler.js


Remote API: Failure start to start registry:2 created through remote API

I ran into the issue during debugging of the Pineapple project, https://java.net/jira/browse/PINEAPPLE-1139
I have reproduced the issue using the Chrome advanced Rest client.  The container created through the remote API doesn't contain the values of the ENTRYPOINT directive from the registry image dockerfile.

Attempting the start the "hopeful_wozniak"container fails:

[docker@localhost vagrant]$ docker ps -a
CONTAINER ID        IMAGE                  COMMAND                CREATED             STATUS                   PORTS               NAMES
f8fb00707c11        docker.io/registry:2   "/etc/docker/registr   35 minutes ago                                                   hopeful_wozniak
9a6f91cc9082        registry:2             "/bin/registry /etc/   21 hours ago        Exited (2) 3 hours ago                       registry
[docker@localhost vagrant]$ docker start  hopeful_wozniak
Error response from daemon: Cannot start container hopeful_wozniak: [8] System error: exec: "/etc/docker/registry/config.yml": permission denied
Error: failed to start containers: [hopeful_wozniak]

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Everything the docker CLI does is via the remote API.
In your create API request, you have specified "Entrypoint": [], this overrides what is in the image.
In your create API request you are using "Image": "docker.io/registry:2, where as on the run you are using just registry:2.
Closing.

Thank you for the help.
I had the misunderstanding that sending "Entrypoint": [], i.e. the empty array, would correspond to sending no input in the request. Sending "no input" must be implemented sending null and not the empty array in the request. Usage of the "Image": "docker.io/registry:2" was a typo, the observed behavior is the same whether , "docker.io/registry:2" or "registry:2" are used.

Yep. You only need to send the things you want to change.
Really to create a container, all you need to do is curl -XPOST /containers/create -d '{"Image": "registry:2"}'


Format Agnostic RawReader Pass

Issue #, if available: N/A
Description of changes:
This PR adds a format agnostic Position for error reporting of locations within an Ion document. For both text and binary formats the Position holds a byte offset. Positions within text documents can also add an optional Line and Column to the Position for better error reporting in the text format.
The addition of Position allowed the text only error IncompleteText to be removed and the RawTextReader can now use the Incomplete error like RawBinaryReader.
This PR also adjusts the handling of incomplete data in the RawBinaryReader's step_out. Prior to this PR if step_out was called without enough data in the buffer, the function would return Ok(()) and set the reader's state to Skipping with the remaining bytes that could not be skipped. This PR continues to consume, and set the Skipping state, but returns an Incomplete error rather than Ok(()) in order to match the behavior of the RawTextReader.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sounds good to me! Let's open an issue for it and tackle it in a separate
PR.
On Thu, Jan 19, 2023, 15:23 Richard Giliam @.***> wrote:

@.**** commented on this pull request.
In src/result.rs
https://github.com/amazon-ion/ion-rust/pull/458#discussion_r1081820027:

}

-#[derive(Clone, Debug)]
+/// Position represents the location within an ion document where an error has been
+/// identified. For all formats byte_offset will contain the number of bytes into the document
+/// that have been processed prior to encountering the error. When working with the text format,
+/// line_column will be updated to contain the line and column as well.
+#[derive(Clone, Debug, PartialEq, Eq)]
pub struct Position {
pub byte_offset: usize,
pub line_column: TextPosition,
Thoughts on converting IonError to a struct and moving the individual
errors (Incomplete, IoError, etc) into an ErrorKind, similar to the way
std::io::Error works?
It's a pretty big change, imo, but it would let us move things like
position out of the enum variants and instead require position info for any
error creation, rather than relying on the variants to include it. That
would make accessors make more sense to me, since the information would be
expected for each error variant.
Thoughts?
—
Reply to this email directly, view it on GitHub
https://github.com/amazon-ion/ion-rust/pull/458#discussion_r1081820027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEVKIEQC5S7ZAF3QQ2OFNTWTGPDLANCNFSM6AAAAAATVHZZLQ
.
You are receiving this because you commented.Message ID:
@.***>


Add authz e2e test coverage

What would you like to be added:
Currently authz is lack of e2e test
Why is this needed:
With e2e test, we may introduce regression, recently https://github.com/kmesh-net/kmesh/issues/484

/assign


highcharts-ng width resize issue in ngDialog

Highcharts is not rendering properly inside an ngDialog popup when it's is opened. It never fits inside the dialog. But after resizing the window the chart automatically changes the width property and fits into it. Why doesn't it fit to the dialog window when dialog popup is loaded?
Thank You!!!

You can try using the reflow function in a call back or after the DOM has rendered the parent container to resize the chart with respect to its parent. A bit dodgy but it will get the job done.
$(element).highcharts().reflow()

I have this issue also, and used a tip from a similar issue raised previously. It's a bit hacky but it seems to work.
Add the following to your chart config...
func: function (chart) {           $timeout(function () {             chart.reflow();           }, 1000);         }
chart.reflow() stops the animation so you can set a longer timeout to allow animation before calling reflow(), which resizes the chart correctly. The downside to this is the chart jumps after a second.


Added YGOFM SFX and Free Duel Music Packs

Added YGOFM SFX and Free Duel Music Packs
Yu-Gi-Oh! Forbidden Memories - SFX
Yu-Gi-Oh! Forbidden Memories - Free Duel
https://github.com/stewartisme/Steam-Deck-AudioLoader-Packs
Checklist
Failure to complete this checklist or deleting boxes from the checklist will result in the closing of your pull request unless this is a pack update. Please write any comments regarding this checklist at the bottom of your pull request.
Check every box.

[x ] I am the original author of this pack or have permission from the original author to make this pull request.
[x ] All copyright of this pack's contents belong to the listed author or is cited in the description and repository linked above.
[x ] This theme works properly on the latest versions of SteamOS for Steam Deck, decky-loader and SDH-AudioLoader.
[x ] This pack is under 10MB in size and uses the least disk space possible.
[x ] This pack is safe for work and does not contain any sexual, drug-related, or profane content.
[x ] This pack does not contain loud, distorted, or otherwise bad faith sound files.
[x ] This pack is only for either music or sounds and only adds or modifies the intended sound files.

Due to recent concerns regarding copyrighted material, approvals for music packs are currently on hold. If your song meets one of the following requirements, please let us know by putting a comment on this pull request. Otherwise, please expect a verdict regarding copyrighted songs in the next week or so.

Original compositions and performances
Copyright-free and public domain performances
Music from other console operating system menus*

*Operating system songs must still be approved by repository maintainers. Unnecessary songs and songs from first-party applications (ex. Wii Shop, Nintendo eShop) may be denied.

I removed the free duel music and left the SFX. When will the hold on music end?

Your music pack is being denied due to new copyright requirements, but we will continue to review your sound pack. #60

Removed the extra files so hopefully it is fine now.

Are soundtrack things allowed now?


Unable to find property 'users' on class: org.apache.shardingsphere.core.yaml.config.common.YamlAuthentication

Bug Report
For English only, other languages will not accept.
Before report a bug, make sure you have:

Searched open and closed GitHub issues.
Read documentation: ShardingSphere Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot reproduce it on current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Which version of ShardingSphere did you use?
Sharding-proxy with docker 4.0.0-RC1
docker run -d --name sharding-proxy -v /d/docker/sharding-sphere/conf:/opt/sharding-proxy/conf --env PORT=3308 -p13308:3308 shardingsphere/sharding-proxy:latest

Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-Proxy
Expected behavior
Actual behavior
Please check the STDOUT file: /opt/sharding-proxy/logs/stdout.log
        at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.construct(Constructor.java:189)
        at org.yaml.snakeyaml.constructor.BaseConstructor.constructObject(BaseConstructor.java:182)
        at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.constructJavaBean2ndStep(Constructor.java:297)
        ... 11 more
Caused by: org.yaml.snakeyaml.error.YAMLException: Unable to find property 'users' on class: org.apache.shardingsphere.core.yaml.config.common.YamlAuthentication
        at org.yaml.snakeyaml.introspector.PropertyUtils.getProperty(PropertyUtils.java:132)
        at org.yaml.snakeyaml.introspector.PropertyUtils.getProperty(PropertyUtils.java:121)
        at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.getProperty(Constructor.java:322)
        at org.yaml.snakeyaml.constructor.Constructor$ConstructMapping.constructJavaBean2ndStep(Constructor.java:240)

Reason analyze (If you can)
Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
server.yaml
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

######################################################################################################
#
# If you want to configure orchestration, authorization and proxy properties, please refer to this file.
#
######################################################################################################

# orchestration:
#  name: orchestration_ds
#  overwrite: true
#  registry:
#    type: zookeeper
#    serverLists: localhost:2181
#    namespace: orchestration

# authentication:
#   username: root
#   password:

authentication:
 users:
   root:
     password: root
   sharding:
     password: sharding
     authorizedSchemas: sharding_db

# props:
#  max.connections.size.per.query: 1
#  acceptor.size: 16  # The default value is available processors count * 2.
#  executor.size: 16  # Infinite by default.
#  proxy.frontend.flush.threshold: 128  # The default value is 128.
#    # LOCAL: Proxy will run with LOCAL transaction.
#    # XA: Proxy will run with XA transaction.
#    # BASE: Proxy will run with B.A.S.E transaction.
#  proxy.transaction.type: LOCAL
#  proxy.opentracing.enabled: false
#  sql.show: false

Example codes for reproduce this issue (such as a github link).

Hi, obviously, in your version, you should config as:
# authentication:
#   username: root
#   password:

Please see your commented fragment in yaml

I am trying to use , but it doesn't work .
authentication:
  username: root
  password: root

I am trying to use , but it doesn't work .
authentication:
  username: root
  password: root

finally got it. We cannot use any UI tool to connect to the sharding-proxy, only command line
mysql -u${your_user_name} -p${your_password} -h${your_host} -P13308 is accecptable.


Remove pip-tools, use uv for all operations

Haven't updated the docs just yet but wanted to get some folks to look at the code changes first.

Rebased main, and squashed out my previous commits

I think I'll take a stab at the docs too now and then move this out of draft

Docs updates added

Sorry for the delay on this one. I'll take a look soon.


Add react/no-object-type-as-default-prop to react/recommended

I propose to add the rule react/no-object-type-as-default-prop at least with warning if not error to the react/recommended set.
Reason: I don't see a good reason not to enable it. It helps you not to fall into the trap of endless rendering. I even had a case where I wrote a component which just seemed to fail in my test environment, but just because this was the only place I didn't set the prop which had an object as default.
If you see a reason not to enable this, I'm thrilled to hear!

Here's just one way of creating a component which will have an endless render:
export const MyObject = ({
  myFancyThing = { test: 1 }, // Never set an object here as default! It will be a different object every time this element is rendered!
}: {
  myFancyThing?: { test: number };
}) => {
  const [foo, setFoo] = useState<string | undefined>(undefined);

  useEffect(() => {
    setFoo("")
  }, [myFancyThing]); // This will always run, because the dependency is always a different object!

  return (
    <...>
  );
};

Adding anything to the recommended config is a breaking change, but I agree it should be done at some point.


Provide a JSON schema for the AST + custom additons

For both our own use, as well as for authors of custom rules, it would be really useful if we had a JSON schema defining the AST JSON, including any custom additions we have added. This would help catch mistakes in Regal policy, and could be integrated as part of our build pipeline.

Running into a stack overflow in the OPA type checker for recursive reference like else clauses. I'll make these non-recursive for the time being, and will have the schema updated when it's been fixed in OPA.


test(mssql): add support for running tests against ms sql server (#91)

coverage: 95.599%. remained the same
when pulling 51a5cc49f7c4096c4dd0258dee3df077fe380c5c on mssql-feature
into 987250648d5313e9516b2f0da092b7e7326dd0f2 on main.

coverage: 95.599%. remained the same
when pulling 476d8dcb3aef11f9e6d4f75218e1a3ffbe81b1cd on mssql-feature
into 987250648d5313e9516b2f0da092b7e7326dd0f2 on main.

coverage: 95.599%. remained the same
when pulling 3b9936ab68ee11b7edbb087cb6da438696568cf1 on mssql-feature
into 987250648d5313e9516b2f0da092b7e7326dd0f2 on main.

coverage: 95.599%. remained the same
when pulling c00a211bb421566f20323e1343d8c097a0bbd0d9 on mssql-feature
into 987250648d5313e9516b2f0da092b7e7326dd0f2 on main.


[r] refractor matrixZeroBasedView

addresses #1403

Codecov Report
Patch coverage has no change and project coverage change: -11.51 :warning:

Comparison is base (1169798) 65.30% compared to head (055e544) 53.80%.

:exclamation: Current head 055e544 differs from pull request most recent head d6ea8a9. Consider uploading reports for the commit d6ea8a9 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1411       +/-   ##
===========================================
- Coverage   65.30%   53.80%   -11.51%
===========================================
  Files          98       68       -30
  Lines        7959     5526     -2433
===========================================
- Hits         5198     2973     -2225
+ Misses       2761     2553      -208

Flag
Coverage Δ

python
?

r
53.80% <ø> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 33 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@pablo-gar implementation as R6 class looks good here. I wonder will switching to R6 will make it harder if we do come back to adding the [ syntax sugar in the future? The matrixZeroBasedView originally was in S4 following the examples I could find for overriding [. I'm OK with switching to R6 overall, just thought this point was worth checking.


slang-rhi: Add WGSL back-end

Here is my WIP patch, if it's useful:
https://github.com/shader-slang/slang-rhi/compare/main...aleino-nv:slang-rhi:aleino/wgsl


Second level multifieldpanel

when using the multifieldpanel xtype inside of another multifieldpanel, the second level one adds extra qoutes and escape characters (ie: backslashes). This is causing an issue with using widgets:getMultiFieldPanelValues. it does not map this second level and im not able to access those keys.
example of what gets generated:
name: tabEntries
value:
{"tabName":"xxx","tabIcon":"aaa","accordion":["{\"itemName\":\"eec\",\"itemIcon\":\"fff\"}","{\"itemName\":\"ddd\",\"itemIcon\":\"iii\"}"]}

This works:
<c:set var="tabEntries" value="${widgets:getMultiFieldPanelValues(resource, 'tabEntries')}"/>
<c:forEach items="${tabEntries}" var="tabEntry">
                ${tabEntry.tabIcon}
                    ${tabEntry.tabName}
</c:forEach>

but this does not:
<c:set var="tabEntries" value="${widgets:getMultiFieldPanelValues(resource, 'tabEntries')}"/>
<c:forEach items="${tabEntries}" var="tabEntry">
                <c:forEach items="${tabEntry.accordion}" var="item">
                      ${item.itemName}
                </c:forEach>
</c:forEach>

+1

+1

What do you mean "it does not work"? What does that second example output?

tl;dr: inner multifields stored as string value in outer multifield in classic, but stored as json objects in touch.
This is due to a difference in how the content is serialized inside a multifield, if I am reading the code correctly. From what I remember about the classic multifieldpanel xtype,  inner multifields are serialized first as a string value, which is placed in the form. Then outer multifields place this string value into their own structure. When the resulting object is serialized to a string, the inner multifield has been serialized twice.
From what I can tell from the touch version, nested multifields are handled by collecting all the data in a single object, with nested multifields' objects (unserialized) being stored into the outer multifield then being serialized. This means the inner multifield is serialized only once.
Example:
Given the pseudo form, with values below
<form>

			<input name="field_1" value="outer_1_field_1"/>

					<input name="field_1" value="inner_1_field_1"/>
					<input name="field_2" value="inner_1_field_2"/>

					<input name="field_1" value="inner_2_field_1"/>
					<input name="field_2" value="inner_2_field_2"/>

</form>

Classic will produce the following json when serialized:
{
  "field_1": "outer_1_field_1",
  "inner_multifield": [
    "{\"field_1\":\"inner_1_field_1\",\"field_2\":\"inner_1_field_2\"}",
    "{\"field_1\":\"inner_2_field_1\",\"field_2\":\"inner_2_field_2\"}"
  ]
}

Touch will produce the following json when serialized:
{
  "field_1": "outer_1_field_1",
  "inner_multifield": [
    {
      "field_1":"inner_1_field_1",
      "field_2":"inner_1_field_2"
    },{
      "field_1":"inner_2_field_1",
      "field_2":"inner_2_field_2"
    }
  ]
}

The last time I used the classic version, the nested multifield content actually broke some of AEM's built in features (move page process, for example), which led us to reworking any component that used nested multifields, to eliminate them. If what I know and have read about the touch version is accurate, the differences in JSON structure would be significant enough to cause major problems when moving from classic to touch

in support of a deprecated ClassicUI .. closing as wont fix

While I understand the desire to fully deprecate classic, this will turn into a huge barrier to migrating from classic to touch. I feel that closing for that reason is rather short sighted.

Feel free to re-open with a PR to solve if you'd like.  It's just not in our best interests going forward to encourage folks to keep using classic UI.  It is going away.  People need to stop using it.

@paul-bjorkstrand the biggest reason this is closed is because no one felt it was important enough to fix (provide a PR) since it was opened in 2014. By all means, PR away for anything you please :)
We really need to clean-up our issues as theyre getting crusty to the point its hard to figure out what relevant things to work on are. If you feel super-strongly thought, re-open and ideally provide a PR to fix.


Successful related response needed

The section being referred to: http://jsonapi.org/format/#fetching-resources-responses
At the bottom is an example of a response from a GET request to /articles/1/author.  However, only an unsuccessful request is shown, so no example of how to best format this response if an author is found is provided.
Would it be similar to a request to GET /articles/1/links/author or would it take a format of:
{
  "links": {
    "self": "/articles/1/author"
  },
  "data": {
    "id": "21",
    "type": "person"
  }
}

Thinking about it further, I fail to see the point of having both /articles/1/author and /articles/1/links/author.  It seems rather redundant to me.

The relationship url (/articles/1/links/author) allows you to directly manipulate the authors related to an article independently from the article itself. For a toOne relationship this may seem a bit useless, but for a toMany relationship it is quite important for supporting non-destructive updates.

@tkellen I am wondering if you could potentially elaborate a bit more with respect to the difference between self, related on relationships. Perhaps an example of how one would manipulate a relationship and how that would differ from the self link? Why wouldn't related go to the author resource for instance? For example:
  "relationships": {
    "author": {
      "links": {
        "self": "/articles/1/relationships/author",
        "related": "/people/9"
      },
      "data": { "type": "people", "id": "9" }
    }

@alexwen Could you please raise this question on http://discuss.jsonapi.org?
The members of a links object always refer to the container it resides in. Because JSON-API allows direct manipulation of relationships, the self link of a relationship is the "relationship url".
In the example you've provided, no matter who the author of the article is, you can find it at the relationship url /articles/1/relationships/author. The related link points to the actual author, but that can change any time.


Automatically delete invalid subscriptions

Description
An invalid subscription is a subscription where the subscriber no longer have access to the related data. Rights and roles changes for different reasons all the time. The Events component should regularily verify that the subscriber still have the necessary rights to  access the data.
Subscriptions that never push any events still have a performance cost and over time they might become the majority of subscriptions unless there is a mechanism to delete them.
Additional Information
The idea is to have an Azure function scheduled to run once a day. The logic should perform an authorization check to see if the subscriber still have read access to the data in question. If the result is negative, the function would proceed to delete the subscription.
Possible implementations

Scheduled authorization check
This would be an increasingly large job as the number of valid subscriptions continue to grow.
Delete on during push if authorisation fails during push
This might not cover all cases, subscriptions might never be tested if they never "trigger.
Register message to a Kafka Topic if authorisation fails during push
Almost identical to the point above, but most of the job is done asyncronously.

@OddArneSaetervik Før vi bruker noe tid på å refine denne ønsker vi avklaring på hvorvidt det er greit å bare slette abonnementer. Burde det gis en beskjed til eier av abonnementet om at det er slettet eller skal det være en slags "grace period" hvor vi beholder abonnementet, men ekskluderer det fra push logikken.

@SandGrainOne


SOLR-15182: replica API conversion to annotations

Description
The v2 API currently has APIs implemented two ways: using an JSON 'apispec' file, or using a JAX-RS -like annotation framework.  The former framework is deprecated and we're in the process of moving APIs over to the latter, as it generally results in less duplication and has some other advantages.
Solution
This commit rewrites the lone replica API ("DeleteReplicaAPI") to use the annotation-based approach.
Tests
See V2ShardsAPIMappingTest
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.

Hmm, yeah, looks like I've got some IntelliJ editor settings to figure out.  Is there a settings file we have to import or something, or is it just manual settings people have formed consensus on?

I checked the /dev-docs/ folder, assumming there might be something...   Readme says:
- *IntelliJ* - IntelliJ idea can import the project out of the box.
               Code formatting conventions should be manually adjusted.


Update components to use 3.1.0 tokens

This PR does some cleanup on the tokens used in various components, fixing some inconsistent usages and aligning with new tokens in 3.1.0:

c816270 and c8e916f: Switch
9ba8d67: Select
f0dedc2: Header

@ty2k leaving this in draft for the moment, expecting there may be more commits to come on this.

@ty2k I'm done with this branch now. Over to you for review, or feel free to use this branch to fold in any other revisions on your backlog!


Price library is not working

Trying to use the BITBOX.Price library returns a bunch of errors and HTML.
Here is an example node.js application to reproduce this issue:
const BITBOXSDK = require('bitbox-sdk')
const BITBOX = new BITBOXSDK()

async function myfunc() {
  try {
    let current = await BITBOX.Price.current();
    console.log(current);
  } catch(error) {
   console.error(error)
  }
}
myfunc()

This is based on the BITBOX documentation:
https://developer.bitcoin.com/bitbox/docs/price

In addition to that bug here is another method that returns HTML. From this tutorial. https://developer.bitcoin.com/tutorials/bitbox-cli/
BITBOX.Network.getNetworkInfo().then((result) => { console.log(result); }, (err) => { console.log(err); });

@MaxHastings we were advised to remove that endpoint so it no longer exists. That's why we no longer have a Network class here. I'll update that tutorial to remove that example

Blockchair has removed their bulk price endpoint so we're removing that functionality.
This is resolved in BITBOX SDK v5.1.3
https://developer.bitcoin.com/bitbox/docs/price


fix LogCleaner::IsLogFromCurrentProject for filename_extension

https://github.com/google/glog/pull/631#issuecomment-814690267
fix it

@aesophor PTAL


Accessing probabilities of bagged models

Hi, I was wondering if there's any way of accessing the probabilities of each of the bagged models which are averaged to get the output of predict_proba() for the L1 models? This would be helpful to be able to calculate uncertainties for each of the models as well as uncertainty for the entire weighted ensemble
Thanks!

Hi @Innixma, any way I could help? I've been modifying the repo to access this, so if there's a branch it's being worked on I could try to help!

@amanmalali Thanks for your interest! if you have a branch with the changes, I could take a look as a reference. For this one it is a bit in-depth for the official implementation, since I want the fold models to also be viewable in predictor.leaderboard(..., show_folds=True).
For the implementation I would be basing things off of BaggedEnsembleModel.predict_proba_children to fetch the fold predictions. If you have an implementation for calculating uncertainty of a bagged model based on the child predictions, that could be valuable to share as a reference code implementation. We could add it as a new method to BaggedEnsembleModel, such as BaggedEnsembleModel.compute_uncertainty(X_holdout)


icons: Updated bot icon with single antenna version.

This PR makes an update to the previous bot icon, replacing it with a new single antenna bot icon. This PR fixes #978
No tests have been written or updated for this PR as the changes made were minimal and did not involve changing any dart code, just updating the SVG asset file and rebuilding the icon font.
Thank you.

Please write down specifically where you got the new icon from. The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Please write down specifically where you got the new icon from. The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Yes, the icon was gotten from the zulip repository from this PR about updating the icon. https://github.com/zulip/zulip/pull/31673
I downloaded the SVG file from that repository and used it.

Please write down specifically where you got the new icon from. The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Yes, the icon was gotten from the zulip repository from this PR about updating the icon. zulip/zulip#31673 I downloaded the SVG file from that repository and used it. Specifically from https://github.com/zulip/zulip/blob/main/web/shared/icons/bot.svg

Should I send an updated commit with a description of where I got the icon from or adding a comment here would be fine? @chrisbobbe

Yes, please update the commit. As I said above:

[…] The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Yes, please update the commit. As I said above:

[…] The commit message is a good place for that, and the first place someone in the future will look when they want to know where it came from.

Okay, understood, thank you.

I have updated the commit @chrisbobbe

Ah, I see you've also wrapped the URL onto two lines :) but we do like to keep URLs intact instead of breaking them. So that can be an exception to the wrap-to-68-columns rule.

Ah, I see you've also wrapped the URL onto two lines :) but we do like to keep URLs intact instead of breaking them. So that can be an exception to the wrap-to-68-columns rule.

Yeah, I was actually confused about what to do with URLs, let me update that then.

Ah, I see you've also wrapped the URL onto two lines :) but we do like to keep URLs intact instead of breaking them. So that can be an exception to the wrap-to-68-columns rule.

Yeah, I was actually confused about what to do with URLs, let me update that then.

Updated

Ah, and one thing I forgot in my previous reviews: since this makes a visible change, please post before/after screenshots. The code and commit message look good to me though, and I'll move this along to Greg for his review (but please do post those screenshots).

Oh, I see you did post screenshots, just on the issue thread instead of here: https://github.com/zulip/zulip-flutter/issues/978#issuecomment-2393209398
In future, please post the screenshots on the PR thread. But I do think those screenshots look good.

Thanks @fombalang for taking care of this, and @chrisbobbe @PIG208 for the previous reviews!
This looks good; merging. I fixed one nit in the commit message:
-    icons: Update bot icon with single antenna version
+    icons: Update bot icon with single-antenna version


update_auto_scaling_group not work

update_auto_scaling_group  throws exception with no message.
Is this supported?

The update_auto_scaling_group method is supported. See here for an example.
Can you give some more details? What code were you running and what did the exception look like?

that's the traceback:
Traceback (most recent call last):
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/moto/core/models.py", line 71, in wrapper
    result = func(*args, **kwargs)
  File "/home/mamad/Working/secret-ops-scripts/tests/helpers/aws/test_asg_descale.py", line 43, in test_retrieve_autoscaling_groups_in_vpc
    AutoScalingGroupManager('eu-west-1').scale(asg['AutoScalingGroupName'], MinSize = 1)
  File "/home/mamad/Working/secret-ops-scripts/modules/aws/auto_scaling_group_manager.py", line 13, in scale
    client.update_auto_scaling_group(AutoScalingGroupName=name, **kwargs)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/client.py", line 252, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/client.py", line 531, in _make_api_call
    operation_model, request_dict)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/endpoint.py", line 117, in make_request
    return self._send_request(request_dict, operation_model)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/endpoint.py", line 146, in _send_request
    success_response, exception):
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/endpoint.py", line 219, in _needs_retry
    caught_exception=caught_exception)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/hooks.py", line 226, in emit
    return self._emit(event_name, kwargs)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/hooks.py", line 209, in _emit
    response = handler(**kwargs)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/retryhandler.py", line 250, in __call__
    caught_exception)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/retryhandler.py", line 265, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/retryhandler.py", line 313, in __call__
    caught_exception)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/retryhandler.py", line 222, in __call__
    return self._check_caught_exception(attempt_number, caught_exception)
  File "/home/mamad/Working/secret-ops-scripts/.env/local/lib/python2.7/site-packages/botocore/retryhandler.py", line 355, in _check_caught_exception
    raise caught_exception
KeyError: None

Creating ASG works well, just update fails. I tried to change parameters but I didn't manage to make it work.
The actual code without Moto works well and updates the ASG group properly.

Thanks for opening! Let me know if that doesn't solve it.


⚠ Jenkins Plugins Artifactory has degraded performance

In 939cc31, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1326 ms

Resolved: Jenkins Plugins Artifactory performance has improved in dfe4122 after 1 hour, 24 minutes.


Add capability for testing actions.

Per discussion in #25 this PR adds the capability to test actions with a single call like:
    goal_handle, feedbacks, result_response = env.send_action_goal_and_wait_for_response(
        name="fibonacci",
        action_type=Fibonacci,
        goal_msg=Fibonacci.Goal(order=4),
    )

I couldn't figure out how to improve typing hints, so have a bunch of Any types.
Also I couldn't figure out how to auto-infer action type similar to _get_service_client, could use help with that.

@felixdivo PTAL.

Hey @vik748, I know I owe you a few comments, also regarding mock testing. Sorry for taking so long. I'll probably respond by the end of the week. I really value your efforts, and at first glance, it looked great. I'll have to find a few more minutes to go through it more slowly, though, hopefully this weekend. :)

Regarding the automatic detection of action type. We always get a goal, e.g. Fibonacci.Goal(order=4). Can't we then parse and import the "main" Type (in this case Fibonacci) ver similar to how it is done for services in _get_service_client?
This might works if you pass in goal_class = Fibonacci.Goal:
# Get the type of the service
# This is a bit tricky but relieves the user from passing it explicitly
module = import_module(goal_class.__module__)
# We cut away the trailing "_Goal" from the type name, which has length 5
base_type_name = goal_class.__name__[:-5]
base_type_class: Type = getattr(module, base_type_name)

Great work so far!

@vik748 I am sorry for my slow responses. I will make sure to answer at least on a weekly basis from May one!

For the record, this is how I do this kind of stuff now. It's an implementation without sleeps, so perhaps can serve as inspiration:
from action_msgs.srv import CancelGoal
from my_package.action import MyAction

def test():
    client = ActionClient(node, MyAction, "my_action")
    assert client.wait_for_server(10.0), "No actionclient for my_action found"

    event = threading.Event()

    def unblock(future):
        nonlocal event
        event.set()

    send_goal_future = self.send_goal_async(goal, **kwargs)
    send_goal_future.add_done_callback(unblock)

    event.wait()
    goal_handle = send_goal_future.result()
    assert goal_handle.accepted

    print("Canceling action")
    response: CancelGoal.Response = goal_handle.cancel_goal()
    assert response.return_code == CancelGoal.Response.ERROR_NONE, "Canceling action failed"

event.wait()

You could even pass a timeout to it.

I'll react to PRs etc. more regularly from now on.

Hey @vik748, after finally completing #33 and many minor cleanups, I was able to have a closer look at this. I was inspired by the ROS source code and @Timple's very similar suggestions. Since I did not want to bother you with more requests, I implemented the changes myself in #37. Thank you for the great work here and your patience. :)


tabindex on map leading to non-working interactions when map el in shadowRoot

Describe the bug
I have the following situation:

OL map's target element is inside of a shadowRoot of a custom DOM component
tabindex="0" is set on the map's target element in order to gain accessibility according to the corresponding official OL example
Now the map interactions, like pan and zoom stop to work

I did some investigations and for my understanding the following happens:

defaultInteractions on the map have onFocusOnly: true as default
focusWithTabindex detects that there is a tabindex attribute on map's target and calls the focus method
focus method tries to detect if the map target has the focus, but the current approach does not detect map focus correctly if in inside shadowRoot, since the contains functions used there does not reflect elements as shadowRoot children.

A possible solution could be using an extended contains functions, which iterates down to shadowRoot elements or there might be another approach to detect focus at all.
To Reproduce
Steps to reproduce the behavior:

Create an OL map and set its target to an element inside a shadowRoot
Ensure map target has an tabindex="0" attribute
Check map and see that map interactions do not work anymore.

Expected behavior
The  map interactions should work if the map has the focus, so the map can be panned and zoomed with mouse and keyboard.

Thanks for the bug report. Maybe when using shadow DOM, a better approach would be to handle the focus on the custom element instead of the map's target. So looking at the https://openlayers.org/en/latest/examples/es2015-custom-element.html example, that would be
    <ol-map tabindex="0" id="map" class="map"></ol-map>

If I understand you correctly, you tried to set the tabindex attribute on the map's target element inside the shadow DOM. That would only make sense if all focusing / tab switching takes place inside the shadow DOM. Is that what you're aiming for? That would be quite unusual, as opposed to having native and custom elements in the document, and one of these native or custom elements has the focus.

Thanks for your feedback @ahocevar. You are right, the tabindex should be on the outside component, so one element in the "main" document has the active element. But the keyboard interactions like KeyboardZoom and KeyboardPan don't seem to work without a tabindex attribute on the map's target element. Do I miss something?

@ahocevar thanks for code and yes, I can take over and start today, but may take some time to finish fully fledged due to vacations...


fatal error: runtime: bsdthread_register error

Command
cf --version
CLI Version
lastest
Error
fatal error: runtime: bsdthread_register error
runtime stack:
runtime.throw(0x9e5a20, 0x21)
/usr/local/go/src/runtime/panic.go:530 +0x90 fp=0x7fff5fbff7a0 sp=0x7fff5fbff788
runtime.goenvs()
/usr/local/go/src/runtime/os1_darwin.go:76 +0x8d fp=0x7fff5fbff7c8 sp=0x7fff5fbff7a0
runtime.schedinit()
/usr/local/go/src/runtime/proc.go:440 +0xa7 fp=0x7fff5fbff810 sp=0x7fff5fbff7c8
runtime.rt0_go(0x7fff5fbff840, 0x2, 0x7fff5fbff840, 0x0, 0x2, 0x7fff5fbff9f0, 0x7fff5fbff9f3, 0x0, 0x7fff5fbffa35, 0x7fff5fbffa43, ...)
/usr/local/go/src/runtime/asm_amd64.s:138 +0x132 fp=0x7fff5fbff818 sp=0x7fff5fbff810
Stack Trace
CC API Version
CF Trace
For bugs related to HTTP requests, please run the command with env var CF_TRACE=true
Platform Details
e.g. Mac OS X 10.10.5
Shell
iTerm
I've tried installing the CLI every way, and still getting the issue.

Hi @ryanmkaplan
Thanks, we'll look into this.
Can you confirm at which release it stopped working? 6.16.0? 6.15.0?
Regards,
Dies Koper
CF CLI PM

@dkoper thanks, it's not working on 6.16; I was told 6.15 works fine

@ryanmkaplan we believe this error is happening due to Anti-Virus/Security software. do you have one of the following, or other Anti-Virus/Security software installed?

McAfee Endpoint Protection for Mac
Trend Micro Data Loss Prevention
Websense Endpoint
Digital Guardian

@ryanmkaplan Also, if you temporary disable your antvirus/security software, does cf 6.16.x work?
Knowing that would help us tremendously in pinpointing the cause of the issue.

I have the same issue. And the issue persisted even after disabling the McAfee Endpoint Protection for Mac.

@dkoper @cbguder - sorry for the delay. I'm not able to disable McAfee (do not have permissions) but the downgrade is working fine.

@ryanmkaplan @hadesara We have built a new binary that we think might fix this issue. Please give it a try and let us know if it fixes the issue you're seeing.
Installer: https://s3.amazonaws.com/go-cli/releases/v6.16.1-2016-03-17/cf-cli-installer_6.16.1_osx.pkg
Binary: https://s3.amazonaws.com/go-cli/releases/v6.16.1-2016-03-17/cf-cli_6.16.1_osx.tgz

@cbguder I previously had the same issue as @ryanmkaplan and @hadesara  and the new binary looks like it fixed this issue. Thanks.

@johnrjacobs
Thanks for the confirmation. We have ported the fix into our edge binaries. Any chance you could try out our edge binary as well and confirm the issue is addressed?
https://cli.run.pivotal.io/edge?arch=macosx64&source=github
Cheers,
Dies Koper
CF CLI PM

The fix has been included in cf CLI v6.17.0.
https://github.com/cloudfoundry/cli#downloads
Thanks again!
Dies Koper
CF CLI PM


How do you run the .jar file with groovy shell?

im trying to run this and i do not know what to do

I think you're doing something wrong. Regardless, how to run a jarfile is not an issue with this repository.


Contribution Guidelines

A Contribution Guideline to set the standards and help the new contributors to show the way regarding

where to start
information regarding the use of the Github/Git/
Using Issues and project-specific labels
How to make pull requests/example pull requests/checklist
How to set the environments at their pc locally/dependencies
work in a friendly environment and code of conduct
Recognizing contributions
Contact points
Referenced guidelines

Please assign this issue to me dear @shawnrhoads

Thank you @complexbrains!
I can help with recipe guidelines. For now, this what we decided on:

recipes will be written in Markdown
all recipe files will be saved to `content/recipes/*.md'
recipe files will follow the heuristic: content/recipes/<user-defined-name>_recipe.md
any images associated with a recipe will follow a heuristic: content/recipes/<user-defined-name>_image_<index>.jpg
code included in recipe should be roughly 1-10 lines (maybe we want to set a recommended total number of lines in file)
recipes should include software versions and links to software documentation when possible

https://github.com/neuroimaging-cookbook/neuroimaging-cookbook.github.io/issues/4#issuecomment-743915474

I quickly updated this template file with these guidelines. I added a recommendation to keep recipes concise and no more than 100 lines.
Please leave a comment if you think we should edit/add anything :)
File: https://raw.githubusercontent.com/neuroimaging-cookbook/neuroimaging-cookbook.github.io/main/content/template_recipe.md
Webpage: https://neuroimaging-cookbook.github.io/template_recipe/

Here is the PR for the first draft of the contribution guidelines and code of conduct #18
Please let me know about your comments. Thank you 🤗

Here is the PR for the first draft of the contribution guidelines and code of conduct #18
Please let me know about your comments. Thank you 🤗

AMAZING! Thank you!! I'll take a look at the PR in the next couple of days and let you know if I have any questions/suggestions before merging.

AMAZING! Thank you!! I'll take a look at the PR in the next couple of days and let you know if I have any questions/suggestions before merging.


(PDB-1738) (PDB-1739) Drop jdbc.deprecated

(PDB-1738) (PDB-1739) Drop jdbc.deprecated

Migrate all code to the newer clojure.jdbc API.

Note that the newer jdbc API handles some database operations like
transactions by storing bookkeeping information in nested database
references.  For example, (with-db-transaction ...) creates a new
database connection map with an incremented level, and the library uses
that level to determine where the "top" is, i.e. to decide when to
commit.

To accommodate that approach (without threading a db argument through
all of the existing code), add a jdbc/*db* variable to refer to the
"current" database, and make sure to bind appropriately it in
puppetdb.jdbc wrappers for the relevant clojure.jdbc calls.

Use (jdbc/db) to refer to *db* when invoking the new jdbc API's
functions.

Use jdbc/ consistently to refer to puppetdb.jdbc in altered files.

While updating migrations, combine adjacent db-do-commands into one
broader do-commands.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/8/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/23/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/24/
Test FAILed.

@pljenkinsro retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/28/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/31/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/33/
Test FAILed.

@pljenkinsro retest this please

test this please

@puppetlabs-jenkins test this please

this needs a rebase

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/36/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/41/
Test FAILed.

@puppetlabs-jenkins retest this please...

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/40/
Test FAILed.

@puppetlabs-jenkins retest this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/42/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/43/
Test PASSed.

@rbrw travis is failing right now, looks like migrate-test is hanging?

I think there's a memory leak here. Travis doesn't say OutOfMemoryError, but I see it locally. For me it ran out of memory at storage-test, but only when I ran the whole test suite. If I run just that test it's fine. Also I only saw this on HyperSQL.

managed to get all the way through this. Generally +1, just a few clarifying comments.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/47/
Test PASSed.

@wkalt thanks for the slog - if my explanations sound plausible, then I'll push the typo fix, and perhaps we'll be set.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/50/
Test PASSed.

Lgtm other than small comments, will there need to be a corresponding PR for PE as well?

@ajroetker looks like we're fine there.

Well I g2g on this once the acceptance tests pass!

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/62/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/65/
Test PASSed.


[SPARK-20400][DOCS] Remove References to 3rd Party Vendor Tools

What changes were proposed in this pull request?
Simple documentation change to remove explicit vendor references.
How was this patch tested?
NA
Please review http://spark.apache.org/contributing.html before opening a pull request.

This should be on hold until a JIRA resolution, I'd like to hear what others say.

Test build #75969 has started for PR 17695 at commit 5692124.

LGTM

Test build #75969 has finished for PR 17695 at commit 5692124.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75969/
Test PASSed.

Merged build finished. Test PASSed.

Thanks for the info @srowen - this should be better now.

Test build #76086 has started for PR 17695 at commit e74c2d6.

Test build #76086 has finished for PR 17695 at commit e74c2d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76086/
Test PASSed.

Merged build finished. Test PASSed.

OK, merged it anyway to master/2.2


Experimental/replace 0mq for rifle vampire

@yannick-polius - all the java repos use Rifle/Vampire pattern. I would highly recommend that you create a new pattern and only use the new pattern for the places that are performance sensitive. Using this design, we have to change code across Java, and other repos that have no benefit of using the new pattern.

@shwetabhandare closing to implement your idea


feat(datasource):Support querying different data sources

This change adds the ability to show the worklist against different data sources by using a path /:datasourcename.  It also fixes the various sub-paths so that they return to the correct parent data source name.  For example, in the multiple.js configuration, there are data sources:  default, aws and e2e.  Then, one can query three different back ends with:
http://localhost:3000/default
http://localhost:3000/aws
http://localhost:3000/e2e
You can pull/try those three examples (assuming you have a dicomweb instance on port 5000 running).

@Zaid-Safadi - could you review this PR please?

@wayfarer3130 Can we please stick to the same convention of how we do filtering on mrn, etc.
http://localhost:3000/?description=sdf&patientName=name
so
http://localhost:3000/?datasourcename=aws

Actually I do believe this is just another query like others that we have here
https://github.com/OHIF/Viewers/blob/v3-stable/platform/viewer/src/routes/WorkList/WorkList.tsx#L513-L530
Also look how Ouwen is doing his configURL PR here #2925  which is very similar


Mention timeout unit in ENetConnection::service docs

Add a note about timeout field being in milliseconds.
Had to test locally to figure it out haha.

It is very unorthodox to mention the only parameter of this method in its own line at the very bottom of the description.

Thanks! And congrats for your first merged Godot contribution :tada:


Show all resources across all regions.

It'd be great to have a button to toggle showing all resources across all regions. I'm looking to be able to submit these as a sort of report.

My thoughts as well. Would work on that as soon as I finish going through the list of ALL the resources. Pretty sure that #8 will also help with this, and maybe a print option, or an export as json/csv.


DBZ-6754 Prepares content for downstream use

DBZ-6754
Adds metadata and provides edits to prepare the notfications content for downstream use.
Tested in a local downstream build.

Applied to main (=2.4) and branch 2.3.


Lost ability to install Mill for GHA when build.sc is not at the project root

Hi,
I have a project that builds with a mix of Mill and sbt (for historical reasons), this means that neither sbt nor Mill live at the repo's root level. This worked fine we tried to upgrade to Mill 0.11.1, but now doesn't due to a recent change:
https://github.com/com-lihaoyi/mill/blob/1e5871a8a0740193b339030b420331dc90bca091/runner/src/mill/runner/MillBuildBootstrap.scala#L71
(To answer to the question: "No, I'm not, but I will be." :smile:)
The setup-mill action can no longer install Mill for us, producing this error:

I realise that...

It will be suggested we use the bootstrap script thingy.
I can probably fix this by placing a dummy build.sc at the root.
This is an edge case, most people don't do this.

But I thought I'd raise the issue in case it was indicative of a wider problem. Feel free to close the issue based on any or all of the above reasons.

This should with the merge of #2662, which restores the defunct version command. But I think using mill version could be replaced by mill --version which should return much faster.


Fix migrate to ava for tests

What
fix: migrate to ava for tests

:tada: This PR is included in version 1.40.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Please define customization options that are available / not available for custom SPFx ListView Command Set buttons

Hi
Currently, there is some information missing about custom SPFx ListView Command Set buttons. Can you please add documentation for these?
Documentation to SPFx ListView Command Set:
https://learn.microsoft.com/en-us/sharepoint/dev/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api
Questions I have:

Can we define/find the name of the key that matches a custom button?
Can we set similar customizations (hide, position, text, icon...)?

Cheers
Yves

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

 Could you clarify with a bit more information what you mean by these questions?

Hi Beau
Sure.
I added an extra button using a SPFx ListView Command Set. This button appears in the top command bar when deployed as an app to the SharePoint site.

As the article describes, you can manage the different existing buttons on this bar. Example given, you could move the "New" button to position 2. Or you could hide the button to sync the library.
I would like to change the position of this custom button. But I do not have any documentation on this. If this is currently not supported, there is also no documentation stating this.
Cheers
Yves

Hi! Thanks for clarifying.  AFAIK, no, there is no way to change the position, and you can't use the Command Bar Props Customization (JSON) to re-order a custom list view command set button either.

Hi Beau
Thanks for checking.
The position of the existing buttons, you can change with the "position" parameter. This works nicely.
Cheers
Yves


command 'tc' failed in /TargetContainer

Running pumba directyl in ubuntu 20.04.

tc is installed via iproute2 inside the TargetContainer.
which is installed inside TargetContainer.
docker exec -it TargetContainer which tc shows correct path.
User in TargetContainer is root
tried --cap-add=ALL to TargetContainer, doesn't help
sudo pumba doesn't help

Do you have any idea what I am missing?
Error Message is:
sudo pumba -l info netem --duration 15s delay --time 5000 TargetContainer
INFO[0000] Running netem command '[delay 5000ms 10ms 20.00]' on container c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2 for 15s  app=pumba function=github.com/alexei-led/pumba/pkg/container.dockerClient.NetemContainer source=container/client.go:220
INFO[0000] start netem for container                     app=pumba dryrun=false function=github.com/alexei-led/pumba/pkg/container.dockerClient.startNetemContainer id=c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2 iface=eth0 name=/TargetContainer netem=delay 5000ms 10ms 20.00 source=container/client.go:276 tcimage=
ERRO[0003] command exited with error                     app=pumba exit=2 function=github.com/alexei-led/pumba/pkg/container.dockerClient.execOnContainer source=container/client.go:551
ERRO[0003] command 'tc' failed in /TargetContainer (c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2) container; run it in manually to debug  app=pumba function=github.com/alexei-led/pumba/pkg/container.dockerClient.NetemContainer source=container/client.go:227
ERRO[0003] failed to start netem for container           app=pumba error=command 'tc' failed in /TargetContainer (c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2) container; run it in manually to debug function=github.com/alexei-led/pumba/pkg/chaos/netem.runNetem source=netem/netem.go:26
ERRO[0003] failed to delay network for container         app=pumba error=command 'tc' failed in /TargetContainer (c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2) container; run it in manually to debug function=github.com/alexei-led/pumba/pkg/chaos/netem.(*DelayCommand).Run source=netem/delay.go:178
ERRO[0003] failed to run chaos command                   app=pumba error=command 'tc' failed in /TargetContainer (c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2) container; run it in manually to debug function=github.com/alexei-led/pumba/pkg/chaos.RunChaosCommand source=chaos/command.go:79
FATA[0003] command 'tc' failed in /TargetContainer (c0d333418a6e15508d6a3a89d6872079a0a2277b19a7451fdaaf4633a50114b2) container; run it in manually to debug  app=pumba function=main.main source=cmd/main.go:201

#159 which has been closed without a solution seems to be a similar issue.
Unfortunately I can't find any solutions.
TC does not work even with tc-image and commands from your own readme.
Could this be related to the host docker api running on windows?

I found at that this is purely a windows issue.
WSL 2 currently does not support tc with sch_netem.
If you really need to get this going with windows you need to compile and provide a custom kernel for WSL 2.
Works right away with Linux as a host.


ISPN-13153 Upgrade to Hibernate Search 6.0.5.Final

https://issues.redhat.com/browse/ISPN-13153

Merged, thanks @yrodiere


Allow adding of arbitrary environment variables to start script

I had a need to pass some arbitrary info into Resque via environment vars.  Added a quick and easy way to do this...adds a lot of flexibility in my opinion.

@dhanson358  :+1:
Why no was merged yet?

Conflict resolved...should be up to date now.

Thank you, this looks good :+1:
Not sure how I missed this when you submitted it almost a year ago, sorry for the delay.

Just a quick note: I renamed the variable from extra_env to resque_extra_env.

Sounds good, glad some other people found it helpful.


Generalize the workflow_coupling to more quantum packages

Make the Workflow_coupling usable with other packages different of CP2K

See new parser for Orca Molecular orbitals and basis set in qmworks


DCR: Consistency of method names across ComponentDialog and Dialog

ComponentDialog has methods
dialogBegin
dialogContinue
dialogResume
dialogReprompt
dialogEnd
onDialogBegin
onDialogContinue
onDialogEnd
onDialogReprompt
DialogContext
begin()
cancelAll()
continue()
end()
etc.
Shouldn’t these be the same method names?

docs and samples need to be updated

Can we get a final list of what the exact name changes were that went into the PR so we can optimize for the Docs Team

PRs

[ ] dotnet PR
[ ] dotnet Merged
[ ] js PR
[ ] js Merged
[ ] samples PR
[ ] samples Merged

Merged in the dotNet changes.

Closing this one because we have a node.js counterpart, and also the samples will be done next week when we do a full pass on sample.
@Kaiqb @yochay  @sgellock  This PR affects documentation. Let me know if you have questions!


the name right/left_resource is misleading

these names are misleading. it specifies the index. this should be right/left_resource_index
https://github.com/sfc-aqua/quisp/blob/master/quisp/rules/actions/SwappingAction.h#L16
https://github.com/sfc-aqua/quisp/blob/master/quisp/rules/actions/SwappingAction.cc#L40

it's already removed by #453


nixd: 1.0.0 -> 1.1.0

Description of changes
Diff: https://github.com/nix-community/nixd/compare/1.0.0...1.1.0
Change log: https://github.com/nix-community/nixd/releases/tag/1.1.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 238779 run on x86_64-linux 1

1 package built:

nixd

Probably the commits should be squashed.

Yes they should be squashed

already squashed


Update windows.md  change 'export' to 'set' for setting environment variables

https://stackoverflow.com/questions/18701783/windows-equivalent-of-export

Thanks @allenlai18 for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

it should be 'set' in windows rather than 'export'   to set environment variables

how do i rerun the check. i signed the CLA

@svelle Could you please review this?

using export is technically correct here since we refer to using babun, however babun has been discontinued and we should provide an alternative for setting up the server environment on windows if we want to keep it in the documentation.


Expose wgs84ToWindowCoordinates on the Scene

Expose SceneTransforms.wgs84ToWindowCoordinates in the Scene prototype. Fixes #2645
@mramato Please notice that I have not remove it from SceneTransforms, as I did not know if this is the desired behavior.

This is ready.

Thanks @bampakoa!  This looks good to me, @mramato can you take a quick look and merge if this is what you had in mind?

Actually, one comment.  Your thumbnail for the sandcastle example is a little large.  Use the 'View as thumbnail' button at the top of Sandcastle to make the canvas the correct size for the thumbnail

@mramato I have finished with your recommended changes in the test file, so I am waiting for you guys for the name of the function.

cartesianToCanvasCoordinates it is.

@mramato @emackey I have changed the name of the method along with the tests, the name of the SandCastle demo and I have updated the documentation accordingly.

Thanks @bampakoa!
@emackey @mramato please merge when ready.

I apologize for the delay here @bampakoa.  Doing a final review now.

Canvas Coordinates.JPG should be Canvas Coordinates.jpg

@bampakoa since I dragged my feet on this and your core code was ready to merge, I went ahead and addressed the Sandcastle comments I made and also renamed it to HTML Overlays, since I feel that's more discoverable.
Thanks again for this PR and sorry for the delay!

@mramato I think I need to practice more on sandcastle demos :smiley: I am glad I helped guys! Thanks very much!

And I need to practice staying up to date on pull requests 😄 Thanks again!

Thanks again for the contribution, @bampakoa!  It is much appreciated.
@mramato could you please update CHANGES.md in master?


[MW] PlaybackMode & track randomizer not working properly in large playlists

In playlists with more than 32 songs, PlaybackMode settings stop working (they start playing in both menu and in-race as if they were set to AL); this is noticeable in rather large playlists

This is an issue with the track randomizer. It seems to be poorly written by the original developers.
Due do some bit-shifting shenanigans going on in the function SFXObj_PFEATrax::GenNextMusicTrackID() it loses bits during some calculations.
So for example: setting the track 38 (0x26) to be the ONLY enabled track will cause the game to play track 38 (0x26) and 6 at certain intervals.
Why? Simple, bit 6 gets lost somewhere during game checks.
This will need some deeper investigation.

Just to note a few things before I forget:

This is a problem caused by bitmasks - the game uses 3 integer bitmasks in order to determine which song to play in which mode
A solution to this would be to rewrite this entirely. It shouldn't be too hard to do because we can easily track the game state via the GameFlowManager.

The solution is here:
https://github.com/xan1242/NFS_CustomJukebox/blob/3a36ca50be9d3d7ddc1da60224cfc135537787e0/NFSPS_CustomJukebox/dllmain.cpp#L707
It needs to be backported to this player in order to fully solve these issues (this especially includes Carbon despite it avoiding the issue via recursion).
I will make a CustomJukebox plugin for MW and Carbon, so I'll also try to apply that code here (since it's basically the same part anyways).

I have the same problem when I tried to make own soundtrack