No fluctuation of VOC index

I am testing the VOC algorithm combine with SGP40 sensor and SHT3x for temperature and humidity.
Communication with the SGP40 works fine I get the raw value periodically (with temperature and humidity compensation).
The returned value are within 63800 and 64500 range.
When I give the raw value to the VOC algorithm, the VOC index gently ramps up at start up from 0 to 100 but remains at 100 for all the tests (even after two hours with the SGP40 raw value fluctuating).
Any idea?

Hi @cagna-adrien thanks for checking in. There's something off here, the raw values should be roughly in the 20-40k range in a "normal" environment. The should be low at the beginning and creep up during the first minute of the measurement. If those values are off, the VOC Index will naturally also be wrong. Let's work on fixing the raw measurement first. Are you using this driver (embedded-sgp for sgp40) and what's your measurement command sequence? Could it be that your SGP is damaged in any way or has been exposed to high voltages or currents?

Hi @cagna-adrien thanks for checking in. There's something off here, the raw values should be roughly in the 20-40k range in a "normal" environment. The should be low at the beginning and creep up during the first minute of the measurement. If those values are off, the VOC Index will naturally also be wrong. Let's work on fixing the raw measurement first. Are you using this driver (embedded-sgp for sgp40) and what's your measurement command sequence? Could it be that your SGP is damaged in any way or has been exposed to high voltages or currents?

Hi @abrauchli, i had no clue what the range would be for the SGP40 raw signal in normal conditions (that's a good starting point to troubleshoot).
I dont't use the driver (embedded-sgp spg40), but a reimplementation of this driver using our specific I2C drivers but it roughly keeps the same function (probe, measure_raw, read_raw heater_off and test).
The test command returns 0xD400 which indicates everything is OK on the sensor (according to the datasheet).
I have done some test with temperature/humidity compensation with the temperature and humidity returned by SHT3x.
I have now set the temperature and humidity to the default value given in datasheet which had no effect on the raw signal returned (apart the raw signal is now always at the same value).
Here are some log of the I2C communication with the sensor :
PROBE

SELF TEST COMMAND

READ SELF TEST RESULT

MEASURE RAW COMMAND

READ RAW SIGNAL

Our test board is intended to be power supplied by a 3.6 V (which, I agree, is on the upper limit what the sensor is capable of in term of supply voltage). I don't thinks it is enough to damaged the sensor in some way.
PS: I just tested my code on an other board and i have the same behaviour.
Thanks in advance

Hi @abrauchli, i had no clue what the range would be for the SGP40 raw signal in normal conditions (that's a good starting point to troubleshoot).
I dont't use the driver (embedded-sgp spg40), but a reimplementation of this driver using our specific I2C drivers but it roughly keeps the same function (probe, measure_raw, read_raw heater_off and test).
The test command returns 0xD400 which indicates everything is OK on the sensor (according to the datasheet).
I have done some test with temperature/humidity compensation with the temperature and humidity returned by SHT3x.
I have now set the temperature and humidity to the default value given in datasheet which had no effect on the raw signal returned (apart the raw signal is now always at the same value).
Here are some log of the I2C communication with the sensor :
PROBE

SELF TEST COMMAND

READ SELF TEST RESULT

MEASURE RAW COMMAND

READ RAW SIGNAL

Our test board is intended to be power supplied by a 3.6 V (which, I agree, is on the upper limit what the sensor is capable of in term of supply voltage). I don't thinks it is enough to damaged the sensor in some way.
PS: I just tested my code on an other board and i have the same behaviour.
Thanks in advance

To close the issue,
I finally get the value in the right range (20-40k). The problem was that i turned off the heater after each measurement which cause the sensor to enter idle mode (It seems that sending a raw measurement command while sensor is in IDLE mode returns an unusable sraw value. What i have implemented to solve the problem is to send a command first to quit IDLE mode and then sends the measurement command.
As a consequence, i have the following question : is there a minimum time to wait after heater is turned on to proceed to a measurement (and ensure to get a stabilized value of sraw signal).
Our application  is low power oriented and I would prefer not having the heater turned on all the time (as it is implemented in your SGP40 driver)..

To close the issue,
I finally get the value in the right range (20-40k). The problem was that i turned off the heater after each measurement which cause the sensor to enter idle mode (It seems that sending a raw measurement command while sensor is in IDLE mode returns an unusable sraw value. What i have implemented to solve the problem is to send a command first to quit IDLE mode and then sends the measurement command.
As a consequence, i have the following question : is there a minimum time to wait after heater is turned on to proceed to a measurement (and ensure to get a stabilized value of sraw signal).
Our application  is low power oriented and I would prefer not having the heater turned on all the time (as it is implemented in your SGP40 driver)..

Hi @cagna-adrien thanks for the reply. I understand the requirements for low-power measurements, however the mox material needs to be periodically or permanently heated according to the preset profiles, manually turning off the heater will very likely cause out-of-spec measurements. As to how far off-spec those measurements will be depends on too many factors for a software engineer to answer.. you're welcome to experiment as to which times result in acceptable performance, but we obviously cannot provide additional support for that. I'll thus be closing the issue here.


Add Bicep validation workflow

Purpose
This PR adds a GitHub workflow that checks the AZD template for best practices using Defender to DevOps. This change was part of Anthony's #325 PR but he asked me to split that up for easier review.
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
Wait for action to complete successfully.

Unfortunately, the template-analyzer can't handle the unspecified parameter that we added in order to force people to pick a good OpenAI location. I've filed https://github.com/microsoft/security-devops-action/issues/65 and https://github.com/microsoft/security-devops-action/issues/47
I'll close this PR for now and open a PR without the Defender validation.


VS2019

Why am I directed here when VS2019 fails to render the layout of an activity?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b6deff31-ea26-96a9-b201-b199a5fc4144
Version Independent ID: ea7509c3-2f29-8775-b100-b94594d9f2f8
Content: Android Controls (Widgets) - Xamarin
Content Source: docs/android/user-interface/controls/index.md
Product: xamarin
Technology: xamarin-android
GitHub Login: @conceptdev
Microsoft Alias: crdun

@rob313663 I'm not exactly sure here and apologies for a late response. Is this an info bar or error message that is redirecting you here?

Can't remember the exact details, but I think it was a small bar being displayed at the top of the .xaml preview when the view failed to render, maybe caused by me. I think it the message was "Learn how to something something".
I must have been frustrated by the lack of information for troubleshooting why the layout couldn't be rendered.
My apologies.

I got redirected here as well after a compilation error in the Editor. 'The yellow toolbar says: "Learn how to build native Android UIs" Learn More | Hide'

@JonDouglas there may be some indication that the yellow toolbar is appearing at a confusing time, and is conflated with compile issues? This page makes sense as the target of the "Learn Android UIs" prompt, but error conditions less so 😉


I receving error for compile

Hmm.. First guess would be something wrong with the client / secret ids
from Reddit. That 401 is likely coming from a failed login attempt. Double
check that you've copied them properly from Reddit into the bot global
configuration file.
Worst case scenario, if time is of the essence and you have no need of the
Reddit functionality, remove the Reddit module file and comment out its
load statement in the main file and it should build just fine. I can
investigate this more in detail later.
Additionally, your image shows the secret token, password, etc. I would
recommend regenerating those, as you should be the only person who knows
them.
On Wed, Jan 4, 2017, 09:02 recondiscord<EMAIL_ADDRESS>wrote:

[image: image]
https://cloud.githubusercontent.com/assets/24801374/21644651/a08d419c-d275-11e6-8591-c53af8db47e5.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Lunaerix/LunaBot/issues/62, or mute the thread
https://github.com/notifications/unsubscribe-auth/ATdo8DcYg1lcoYXlLyRrcsGbGB6reBhBks5rO6Z3gaJpZM4LapjS
.

Do you have discordapp ?, lately I do not have much time, to be able to solve this, but I am very interested in hostear your bot, just need a functional build, I would send my apis to you, is that really these times I am very busy

My server discordapp https://discord.gg/az3cnR2 and my nick is BinaryPony

Resolved in #64.


[ROCKETMQ-248] make ConsumeFromWhere work right

JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-248

@evthoriz Thank you. Do you have a test for this?

Coverage decreased (-0.3%) to 38.442% when pulling 827ca7584b62cc8b6e5aa5b06b3b3e6fd56c88bc on evthoriz:develop-my into 118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop.

@evthoriz we usually need some measure to verify our correction, no matter what you do. IMO, unit test is a effective practice when we coding. Looking forward to hear from you again :-)

Coverage increased (+0.2%) to 38.926% when pulling f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my into 98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop.

Coverage increased (+0.2%) to 38.926% when pulling f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my into 98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop.

@shroman @vongosling It seems that plenty of tests are associated with this modification, I will resubmit a patch when I complete the relevant integration test.

@evthoriz Thanks, looking forward to your patch :-)

@evthoriz  I will close the pr, if you happened to the same question, please let me know.


Optional GZIP compression

Hi,
This PR adds support to create gzipped sitemaps.
I know the compression can be done by the webserver on the fly, but when creating very large sitemaps precompressing them saves a lot of disk space.
Regards,

Implemented gzip support based on your code. Thank you!


Read list of URL to download from text file

Add option or code to read the list of URL from a text file. The file will contain all the links to download.
If the provided URL has a known file extension, as .pdf or .tar.gz or .zip, dont parse the file but just download the file.

review the request.headers['content-type'] to understand if a url to a webpage or to a file was provided. If a link to a  file was provided, just try to download the file and not parse the file contents.

Fixed in e385fc5157b544896d828fcd52115d1fec9d898a
Close #1

with e385fc5157b544896d828fcd52115d1fec9d898a is closed.


Using all GPU memorry

Hello, i´m using this implementation to test it in some videos to learn more. But i have seen it consume all the GPU memory even in if it is only been used for inference. i had checked some stacks and says is default tensorflow behaviour. and it can be configured at:
config = tf.ConfigProto()
config.gpu_options.allow_growth=True
sess = tf.Session(config=config)

but cant find something like it in the code.
Any help?
kind regards.

There are no Sessions anymore in TF2.0.

@fnando1995 As you can see here you can also limit the gpu memory allocation in tf2.

Thanks! @DeltaTesting Ill be testing it soon.


Sort lines.  Add link to storage starter.

Based on @jialindai 's comment on https://dev.azure.com/azure-spring-integration/spring-integration-private/_workitems/edit/254 we should add the spring boot storage starter.  I did not know we had one because I based my understanding on what are the available starters on this bullet list.

Issue created https://github.com/Azure/azure-sdk-for-java/issues/13723.


Fix Workflow Structure for Open AI Workflow

Proposed changes:

Fix Workflow Structure for Open AI Workflow

Closing the PR as it has already been resolved.


Revert "Replace '0' .. '9' compares with isdigit()"

Reverts isdigit() changes from PR #2753
Windows codepage issues could cause problems. Also reverts use of isdigit() in a_mbstr.c
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This was generated as a git revert on my own pushed branch for PR 2753.

This actually calls for question if we should sanitize other occurrences of isdigit. One can also ask if it makes sense to swipe through all iswhateter usage cases and ensure that their arguments are unsigned chars. But note that there is ambiguity in last sentence. iswhatever-s are prototyped with int as argument, while we are talking about unsigned char. Cast to unsigned char is simply a way to ensure that most significant bit of character value is not sign extended.

This actually calls for question if we should sanitize other occurrences of isdigit.

Basically question is if you would be willing to do in this request, or elsewhere, or see somebody else do it.

I did catch one in a_mbstr.c since it was in the same directory. I see 10 uses o isdigit(), 5 uses of isalnum(), over 30 uses of isspace(), 6 uses of isupper(), and 12 uses of isxdigit(). Some of these are cast to (unsigned char), others are wrapped with _UC() (which is also a cast)

Are these also used in the other branches?

Basically question is if you would be willing to do in this request, or elsewhere, or see somebody else do it.

I'll do it to repent my original sin, but the question becomes, do we swap out for other implementations, or just cast it?

Are these also used in the other branches?

Yes

10 other uses of isdigit(), 5 uses of isalnum()

We can keep it to isdigit in this request, or we can make it whole request about all iswhatever-s. If latter, one can also set for removal of redundant <ctype.h> inclusions.

but the question becomes, do we swap out for other implementations, or just cast it?

That depends on how the char is used.
Usually I would feel safe with a cast to unsigned char, and except when
the value is later subtracted from '0' and used as an index of some kind.

In terms of churn and risk, I think casting would be an appropriate solution.
When subtracted from '0', it's usually confirmed that the value is '0'..'9' inclusive before doing so, so that ought to be safe regardless.

The subtraction would be performed in 'int' precision anyway, due to default type promotion rules.

I am just unsure if there are language dependent alternate number characters,
like the ones the stackoverflow article mentioned.  That's why.

I see three possible solutions:

Cast everything passed to isXXXX functions to (unsigned char) or use _UC() wrapper
Replace isXXXX with comparison equivalents
Create OSS_isXXXX macros that do either 1 or 2 in the implementation depending on our mood, and avoid (or at least explicitly state) language and code page issues.

Option 1 is the fastest, least risky option.
Option 2 is used for EBCDIC code, but we could hide the difference, and make the code overall more readable with Option 3. In most cases of string manipulation, we are not performance critical.

I would prefer 1, excpet when the value is already unsigned char.
Note that _UC is a reserved name, and should be changed to OSSL_UC or similar.

_UC() is already defined in apps/apps.h

According to the C Standard, 7.1.3 [ISO/IEC 9899:2011],

All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.
All identifiers that begin with an underscore are always reserved for use as identifiers with file scope in both the ordinary and tag name spaces.

Understood, I'm just saying it's already in the code base.

I think we can change this define, it is not part of the ABI :-)

Here is "fun" corner case, pem/pem_lib.c, isb64 macro. This is definitely not the case to have dependency on locale. It should be sufficient to simply add c < 128. [Or one can ask base64 encoder if it's "willing" to handle the character.] Question is if there any case where it would be appropriate to permit dependency on locale...

I think

We have the existing code
We don't have any reported issues (i.e., it works
Some have concerns about the current code

I think a PR to fix one ctype use is a bad thing.  We need someone to fix everything and document how and what to do every other time this comes up, including the file-format issues (base64 case that Andy raised).

So -1 on this one fix.

a PR to fix one ctype use is a bad thing

Except that we can't demand particular contributor to undertake the complete assignment.

I will look into it; there aren't that many ctype uses here (less than 100?). I was going to do something about it on Friday, but other (paid) work came up.
I'm thinking of replacing them all with ossl_isXXX() macros that will either call the ctype function with an (unsigned char) cast, or if its EBCDIC, do appropriate range compares; which ought to cleanup the code somewhat; and give the project more control (vs OS or locale) over how these operations occur.
Thoughts on ossl_isXXX()?

Agree we can't demand anyone to do anything.  But we can say we want a complete fix not a partial one :)
@tmshort, what kind of beverage you want?

Any one of: beer, bier, bière, birra, cerveza, cerveja, öl, olut, øl, piwo, pivo...

I agree, let do this properly.
I mentioned this in #2753 but it seemed worthwhile here to:

How about a local/internal function that does the isdigit check and use that?
int constant_time__isdigit(int n)
{
    return constant_time_select(constant_time_ge(n, '0') & constant_time_lt(n, '9' + 1), 1, 0);
}

We'll guarantee constant time building from the existing primitives.  Just replacing the isXXX calls with corresponding expressions needn't be -- do it properly ;)
Won't the isXXX functions themselves be non-constant time due to the memory reference some libraries add.  The EBCDIC suggestion should be used for ASCII -- everything as range comparisons with no short circuiting.
A also can volunteer the time to do this.

That's neat.  Like Todd, not sure if constant-time is important.  More important is if it's LOCALE or not, I think.

Again, not sure it worth it to be constant time, especially for the code that this is in, but making ossl_isXXX macros will make it easier to switch things to constant time.
Also EBCDIC implementation is inconsistent in some places.

How about this (no EBCDIC  support and not constant time):
#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>

#define F(n)    static int n(int c) { return is ## n (c); }
#include "g.inc"
#undef F

void emit(const char *name, int (*f)(int))
{
    int i;
    int nr = 0, runs[256][2];
    const char *lead = "";

    for (i = 0; i < 256; i++) {
        if (f(i)) {
            if (nr > 0 && runs[nr - 1][1] == i - 1) {
                runs[nr - 1][1] = i;
            } else {
                runs[nr][0] = runs[nr][1] = i;
                nr++;
            }
        }
    }
    printf("int OSSL_is%s(int c)\n", name);
    printf("{\n");
    printf("    c &= 255;\n");
    printf("    return ");
    for (i = 0; i < nr; i++) {
        if (runs[i][0] == runs[i][1]) {
            printf("%s(c == %d)", lead, runs[i][0]);
        } else {
            printf("%s(c >= %d && c <= %d)", lead, runs[i][0], runs[i][1]);
        }
        lead = "\n           || ";
    }
    printf(";\n");
    printf("}\n\n");
}

int main(int argc, char *argv[])
{
    static struct {
        const char *name;
        int (*f)(int);
    } funcs[] = {
#define F(n) { # n, &n },
#include "g.inc"
#undef F
    };
    int i;

    for (i=0; i<sizeof(funcs)/sizeof(*funcs); i++)
        emit(funcs[i].name, funcs[i].f);
    return EXIT_SUCCESS;
}

Where g.inc contains:
F(alnum)
F(alpha)
F(ascii)
F(blank)
F(cntrl)
F(digit)
F(graph)
F(lower)
F(print)
F(punct)
F(space)
F(upper)
F(xdigit)

Of these, isascii is mentioned in a comment but not used and isblank, isgraph and ispunct are not mentioned.
:)

Um... we're trying to make this easier to understand?
I would use a table-based mechanism, swapping in a different table for EBCDIC.

I've added a table based approach to the program that generates the functions ;)  Doing this mechanically prevent human error & is more fun to program.
Glibc stores the results of several of these functions in one table and ands the relevant bit out.  I presume this improves cache coherency, it will save some bytes.
As for EBCDIC, knowing if the characters have been converted already or not is important.  I'm not sure a blind approach based on the define is advisable.

There is a character table used by the ASN.1 code with a few unused bits, see charmap.pl etc.

See #4102 for the start of a ctypes implementation.
No conversion of the uses of these functions yet.

I didn't use the charmap.pl table because there were insufficient free bits.

Closing this in favor of PR #4102


WFLY-7719 HotRod-based distributed session manager

https://issues.jboss.org/browse/WFLY-7719
Design doc: https://github.com/wildfly/wildfly-proposals/pull/127
Requires https://github.com/wildfly/wildfly/pull/11476

I looked at the commits beyond those covered in #11476 over the weekend and, except for my minor points above

All the commits beyond the #111476 one except "WFLY-7719 HotRod-based distributed session manager" look fine.
I didn't see anything wrong in the "WFLY-7719 HotRod-based distributed session manager" commit. It's huge though so I can't say I reviewed it closely. But probably as well as any general code review can do.  I think the key for that is testing, not code review.

I suggest that if anyone else besides James and I looks at this that they focus on that one commit.

@jamezp Rebase is complete.

retest this please

Dependency Tree Analyzer Output:
New Dependencies:

org.wildfly:wildfly-clustering-ee-cache:jar:17.0.0.Beta1-SNAPSHOT:compile
org.wildfly:wildfly-clustering-ee-hotrod:jar:17.0.0.Beta1-SNAPSHOT:compile
org.wildfly:wildfly-clustering-infinispan-client:jar:17.0.0.Beta1-SNAPSHOT:compile
org.wildfly:wildfly-clustering-web-cache:jar:17.0.0.Beta1-SNAPSHOT:compile
org.wildfly:wildfly-clustering-web-hotrod:jar:17.0.0.Beta1-SNAPSHOT:compile

retest this please


Iptables extension fails to build on Linux

The iptables extension fails to build with 4.x due to arithmetic on void pointers. It includes the netfilter library headers which uses the pointer arithmetic.
In file included from /home/akkumar/osquery_workspace/osql/build/libs/src/libiptables/include/libiptc/libiptc.h:12:
/usr/local/osquery-toolchain/usr/include/linux/netfilter_ipv4/ip_tables.h:222:19: error: arithmetic on a pointer to void
        return (void *)e + e->target_offset;
               ~~~~~~~~~ ^
In file included from /home/akkumar/osquery_workspace/osql/build/external/external_trailofbits/osquery_extension_group_main.cpp:18:
In file included from /home/akkumar/osquery_workspace/osql/external/external_trailofbits/iptables/src/ip6tables_ext.h:28:
In file included from /home/akkumar/osquery_workspace/osql/build/libs/src/libiptables/include/libiptc/libip6tc.h:12:
/usr/local/osquery-toolchain/usr/include/linux/netfilter_ipv6/ip6_tables.h:262:19: error: arithmetic on a pointer to void
        return (void *)e + e->target_offset;

This has been fixed by extracting the code we need in custom headers.


Nested stores

This allows you to specify resource stores that are children of another.
For example:
"linodes": {
    "linode_1234": {
        "configs": {
            ... this is another API store ...
        }
    }
}

This also changes how makeApiList is invoked and some of its behavior.

Coverage increased (+0.04%) to 94.171% when pulling 3b8cc4c96d4bde0e3033ed77a1f46d0bbf0aea87 on na3d:nested-stores into 370c741641a1374f4018adf751398f4a2729f1ab on linode:master.

Added [DO NOT MERGE] pending a couple more tests

Coverage increased (+0.1%) to 94.171% when pulling effc4865fd8256fd2d652d04193a9825a1b456cd on na3d:nested-stores into 043297f3623d10bf4466e163a9c712f4a65addaa on linode:master.

Looks good. ready for merge?

Yup

Thank you


Remove leftovers in case assets extraction fails

(Hopefully) closes #1014.

I am thinking if we should also do something when we try to access a file that does not exist. Especially main.js. Should we nuke the cache directory and try again?

@josevalim on one hand it would make sense, but if somehow it's not the extraction, then it would be better to find that out and identify the actual issue.


safari error

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

youtube-dl.exe -U --verbose -u<EMAIL_ADDRESS>-p "my_real_password" "https://learning.oreilly.com/videos/red-hat-certified/9780135987513/"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-U', '--verbose', '-u', 'PRIVATE', '-p', 'PRIVATE', 'https://learning.oreilly.com/videos/red-hat-certified/9780135987513/']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: none
[debug] Proxy map: {}
youtube-dl is up-to-date (2021.06.06)
[safari:course] Downloading login page
[safari:course] Logging in
[safari:course] Completing login
[safari:course]<PHONE_NUMBER>513: Downloading course JSON
[download] Downloading playlist: Red Hat Certified Engineer (RHCE) EX294: Red Hat Ansible Automation
[safari:course] playlist Red Hat Certified Engineer (RHCE) EX294: Red Hat Ansible Automation: Collected 136 video ids (downloading 136 of them)
[download] Downloading video 1 of 136
[safari:api] Downloading login page
[safari:api]<PHONE_NUMBER>513/RHCE_00_00_00: Downloading part JSON
[safari] Downloading login page
[safari]<PHONE_NUMBER>513-RHCE_00_00_00: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 502, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 685, in http_error_302
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Description

I tried to download a video from safari and i get the error mentioned above. If i use cookies the result is the same.
Yesterday i had "KeyError" running same command, but today the errors looks different.
If i use just one video url, it is working ok, like https://learning.oreilly.com/videos/red-hat-certified/9780135987513/9780135987513-RHCE_00_00_00/

You must provide account credentials for any work on this.


WSA crashes with overrun error

Steps to reproduce
Trying to run WSA gives the error:
WsaClient.exe - System Error
The system detected and overrun of a stack-based buffer in this application. This overrun could potentially allow a malicious user to gain control of this application.
IIRC it worked the first time I installed it but I haven't used it since(kinda forgot about it) but I went to use it and I can't get it to start up as this error prevents it from working.
I tried viewing the diagnostic data but nothing is created(this error pops up immediately on top of the "Windows Subsystem For Android" window.
✔ Expected Behavior
No response
❌ Actual Behavior
Crashes.
Other Software
No response
Please specify the version of Windows Subsystem for Android
2301.40000.7.0

From what I have seen, running WSA on CPUs that are not officially supported (do not meet the requirements of WSA), specifically really old CPUs (2nd to 6th Gen Intel Core Processors), often results in this error.

From what I have seen, running WSA on CPUs that are not officially supported (do not meet the requirements of WSA), specifically really old CPUs (2nd to 6th Gen Intel Core Processors), often results in this error.

As I said, it worked fine. Also, brand new top of the line comp. Has nothing to do with hardware specs and I did not change anything since then it was working except for software and windows updates.

From what I have seen, running WSA on CPUs that are not officially supported (do not meet the requirements of WSA), specifically really old CPUs (2nd to 6th Gen Intel Core Processors), often results in this error.

As I said, it worked fine. Also, brand new top of the line comp. Has nothing to do with hardware specs and I did not change anything since then it was working except for software and windows updates.

@Aphexus Please file a feedback hub report with as suggested.

So just now I went to remove WSA using add and remove programs in windows and in the process I came across the ability to reset the settings in it so I went ahead and tried that first the then WSA started right up. Not sure if that had anything to do with it or if something else in between then and now changed on my system that somehow effected it as I didn't try to run it before I went to remove it to see if it was going to work(I just assumed it wouldn't).


Adds seeding mechanism that scales better. and adds accommodation tab…

Adds table for accomodation
Adds seeding mechanism (please follow db)

Data for externals should populate (with fake instance of accommodations)

Adds Accommodations on list tab


⚠ Avatar API Endpoint has degraded performance

In 5295360, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 4572 ms

Resolved: Avatar API Endpoint performance has improved in f817bad after 12 minutes.


Kiota v1.16.0 generated "CS1587: XML comment is not placed on a valid language element" error

What are you generating using Kiota, clients or plugins?
API Client/SDK
In what context or format are you using Kiota?
Nuget tool
Client library/SDK language
Csharp
Describe the bug
I am trying to update our C# Firecracker Management client - update to the latest Kiota packages / regenerate the client using the latest .NET Global Tool
Tool 'microsoft.openapi.kiota' was successfully updated from version '1.14.0' to version '1.16.0'.
Ran the the tool to regenerate the client
kiota generate -l CSharp -c FirecrackerManagementClient -n Firecracker.Management -d https://raw.githubusercontent.com/firecracker-microvm/firecracker/main/src/firecracker/swagger/firecracker.yaml -o "c:\temp\firecracker\client"

And when I build the project, I get the following errors:
c:\temp\firecracker\client\Models\CpuTemplate.cs(8,5,8,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\Drive_cache_type.cs(8,5,8,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\Drive_io_engine.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\InstanceActionInfo_action_type.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\InstanceInfo_state.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\Logger_level.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\MachineConfiguration_huge_pages.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\MmdsConfig_version.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element
c:\temp\firecracker\client\Models\SnapshotCreateParams_snapshot_type.cs(7,5,7,6): error CS1587: XML comment is not placed on a valid language element

All the files above are enums:
CpuTemplate.cs included below:
// <auto-generated/>
using System.Runtime.Serialization;
using System;
namespace Firecracker.Management.Models
{
    [global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.16.0")]
    /// <summary>The CPU Template defines a set of flags to be disabled from the microvm so that the features exposed to the guest are the same as in the selected instance type. This parameter has been deprecated and it will be removed in future Firecracker release.</summary>
    public enum CpuTemplate
    {
        [EnumMember(Value = "C3")]
        #pragma warning disable CS1591
        C3,
        #pragma warning restore CS1591
        [EnumMember(Value = "T2")]
        #pragma warning disable CS1591
        T2,
        #pragma warning restore CS1591
        [EnumMember(Value = "T2S")]
        #pragma warning disable CS1591
        T2S,
        #pragma warning restore CS1591
        [EnumMember(Value = "T2CL")]
        #pragma warning disable CS1591
        T2CL,
        #pragma warning restore CS1591
        [EnumMember(Value = "T2A")]
        #pragma warning disable CS1591
        T2A,
        #pragma warning restore CS1591
        [EnumMember(Value = "V1N1")]
        #pragma warning disable CS1591
        V1N1,
        #pragma warning restore CS1591
        [EnumMember(Value = "None")]
        #pragma warning disable CS1591
        None,
        #pragma warning restore CS1591
    }
}

The issue seem to be with [global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.16.0")]
Expected behavior
For the code to compile :D
How to reproduce
kiota generate -l CSharp -c FirecrackerManagementClient -n Firecracker.Management -d https://raw.githubusercontent.com/firecracker-microvm/firecracker/main/src/firecracker/swagger/firecracker.yaml -o "c:\temp\firecracker\client"
Open API description file
https://raw.githubusercontent.com/firecracker-microvm/firecracker/main/src/firecracker/swagger/firecracker.yaml
Kiota Version
1.16.0
Latest Kiota version known to work for scenario above?(Not required)
No response
Known Workarounds
No response
Configuration
No response
Debug output
Click to expand log
```

</details>

### Other information

_No response_

Hi @HowardvanRooijen
Thanks for using kiota and for reaching out.
What happens if you move the attribute below the doc comment?
What happens if you remove the attribute all together?

If you move the attribute below the comment
    /// <summary>
    /// The CPU Template defines a set of flags to be disabled from the microvm so that the features exposed to the guest are the same as in the selected instance type. This parameter has been deprecated and it will be removed in future Firecracker release.
    /// </summary>
    [global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.16.0")]
    public enum CpuTemplate
    {

It compiles.
This is how all class types are generated:
    /// <summary>
    /// Balloon device descriptor.
    /// </summary>
    [global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.16.0")]
    public partial class Balloon : IAdditionalDataHolder, IParsable
    {

So I think it's something specific about how you're handling enum differently than class

Thanks for confirming the issue here.
Here is where this gets written.
Would you be willing to submit a pull request to address this issue?
https://github.com/microsoft/kiota/blob/main/src%2FKiota.Builder%2FWriters%2FCSharp%2FCodeEnumWriter.cs#L34


Volume Health Monitoring support

Add support for new Kubernetes feature Volume Health Monitoring

We already have limited support for it: https://github.com/piraeusdatastore/linstor-csi/blob/a2252713ab8a006bd7cb1e3cad0072b66a39d301/pkg/client/linstor.go#L1716
Per-node volume condition reporting is not implemented, as it is not trivial to implement without involving the LINSTOR API, and ideally the CSI node part does not interact with the API directly.


[SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3

What changes were proposed in this pull request?
In the PR, I propose to remove already deprecated SQL configs:

spark.sql.variable.substitute.depth deprecated in Spark 2.1
spark.sql.execution.pandas.respectSessionTimeZone deprecated in Spark 2.3
spark.sql.parquet.int64AsTimestampMillis deprecated in Spark 2.3

Why are the changes needed?
To improve code maintainability.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
By existing test suites ParquetQuerySuite and SQLConfSuite.

Test build #116506 has started for PR 27169 at commit 08be129.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21294/
Test PASSed.

I will add the configs to SQLConf.removedSQLConfigs after all tests pass.

Test build #116506 has finished for PR 27169 at commit 08be129.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116506/
Test FAILed.

jenkins, retest this, please

Test build #116510 has started for PR 27169 at commit 08be129.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21298/
Test PASSed.

Test build #116510 has finished for PR 27169 at commit 08be129.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116510/
Test FAILed.

Test build #116526 has started for PR 27169 at commit 3ebf178.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21312/
Test PASSed.

Test build #116526 has finished for PR 27169 at commit 3ebf178.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116526/
Test FAILed.

Test build #116527 has started for PR 27169 at commit fa0ee64.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21313/
Test PASSed.

Test build #116527 has finished for PR 27169 at commit fa0ee64.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116527/
Test FAILed.

@srowen Could you take a look at the PR, please.

Test build #116535 has started for PR 27169 at commit b5c415b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21321/
Test PASSed.

Style check failed because of:
Scalastyle checks failed at following occurrences:
[error] SERVER ERROR: GATEWAY_TIMEOUT url=https://repo.typesafe.com/typesafe/ivy-releases/org.tukaani/xz/1.0/jars/xz.jar
##[error]Process completed with exit code 1.

Test build #116535 has finished for PR 27169 at commit b5c415b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116535/
Test FAILed.

Test build #116547 has started for PR 27169 at commit ff26d47.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21333/
Test PASSed.

Test build #116547 has finished for PR 27169 at commit ff26d47.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116547/
Test FAILed.

jenkins, retest this, please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21336/
Test PASSed.

Test build #116550 has started for PR 27169 at commit ff26d47.

Haven't taken a close look yet but +1.

Test build #116550 has finished for PR 27169 at commit ff26d47.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116550/
Test FAILed.

Test build #116558 has started for PR 27169 at commit bdc29f8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21344/
Test PASSed.

Test build #116558 has finished for PR 27169 at commit bdc29f8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class RemovedConfig(key: String, version: String, defaultValue: String, comment: String)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116558/
Test FAILed.

Test build #116566 has started for PR 27169 at commit 5068b22.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21352/
Test PASSed.

Test build #116566 has finished for PR 27169 at commit 5068b22.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116566/
Test PASSed.

Test build #116633 has started for PR 27169 at commit 84a35f2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21414/
Test PASSed.

Test build #116633 has finished for PR 27169 at commit 84a35f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116633/
Test PASSed.

Merged to master.


fix: Add extra requires for shillelagh

SUMMARY
I'm not a python expert, but while trying to enable the gsheets API, I got the error No module named 'google.auth'. It looks like we need to add the extra require from shillelagh like this, but i'm not positive that this is the right syntax. I'm hoping CI will help me out, but i'll also test this locally to see if it fixes the issue
TEST PLAN
CI, dev
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

to: @betodealmeida

LGTM but I'd prefer for @betodealmeida to confirm!

I verified that installing now includes google.auth and querying from sql lab works


Jsonrpc calls

Hi,
I'm trying to connect rust code to ethereum ? Is there any luck in hyperium?? and it should compatible with webassembly as well.
Is hyper help me for this? but I see no wasm support
Thanks

Hello! This library just defines the types often used in HTTP applications, like Request, Response, StatusCode, HeaderMap, etc.
For a simple and feature-full HTTP client, you could look at reqwest. I don't know what to suggest for WASM, though.


tcp tests are timing out

npm test

><EMAIL_ADDRESS>test /Users/tmpvar/work/js/node-bunyan-syslog
> tap test

ok test/sys.test.js ..................................... 3/3
not ok test/tcp.test.js ................................. 0/1
    Command: "node" "tcp.test.js"
    TAP version 13
    not ok 1 test/tcp.test.js
      ---
        exit:     143
        timedOut: true
        command:  "node" "tcp.test.js"
      ...

    1..1
    # tests 1
    # fail  1

ok test/udp.test.js ..................................... 3/3
total ................................................... 6/7

not ok

This is probably because the TCP tests try to connect to port 10514. I've added an example rsyslog configuration for running the tests to this repo, and updated the README.


Terraform Not Taking in Command Options

On the 'validate and apply' task I am trying to pass an additional argument to set my variables file to be a specific file, but when I run it, I don't see the additional arguments being passed in from the Azure DevOps logs. I see just 'terraform.exe validate' being run.

@liamfoneill  Can you please share your debug log to<EMAIL_ADDRESS>?

@liamfoneill Not able to reproduce on our end So I am closing this issue. If you still face any issue please ping us on<EMAIL_ADDRESS>


Don't know how to format @ngdoc: provider

Hi,
I tried to use provider directive with the plugin but I get the following error:
 Don't know how to format @ngdoc: provider

Anybody on this??

I just checked the documentation for ngdocs and there is no provider ngdoc extension. However there is a service, which appears to be a catch all.
/**
* @ngdoc service
* @name MyCoolProvider
**/

I suppose you should suffix your provider name with the word Provider, and the same goes for Service and Factories as well.

@JesseChrestler I noticed that too in ndocs. But in the official AngularJS documentation they use provider as a keyword as you can see in httpProvider documentation

@bampakoa so as it turns out gulp-ngdocs isn't using Dgeni (which is what the good folks of angularjs use) to generate it's documentation. So from that you can assume this doesn't use the dgeni-packages that are offered with dgeni; which has processors to support tags like @ngdoc provider and such. I've also noticed there is no support for @ngodoc event either.
Now that being said there aren't whole lot of options. Dgeni has limited documentation and a couple example projects. However they don't have great templates, yet. I am going to keep searching.

@JesseChrestler thnx for your feedback!

@JesseChrestler any luck on your search?

@LuizGsa21 I ended up abandoning gulp-ngdocs all together. The problem with using them is you can't rely on what documentation is being used by angularjs. Which is what you try to use as a reference. Angularjs Dgeni has limited documentation as well, which was quite frustrating.
So what i did is went to angularjs source directly. I downloaded master (https://github.com/angular/angular.js/tree/master/docs) and tried to get it working using angularjs source. Well without too much trouble it worked. However there was a lot of dependencies back to github and things that I'd need to strip out (the build farms I use do not have internet access) to make it work for any project in a generic way. After a couple hours I was able to point it to my source and it was working with all the nice new features including @ngdoc: provider, and live running examples. It's really nice honestly.
I could probably write a tutorial and include the base source so that you could also do the same for your projects. The site looks exactly the same as the one you find in the angularjs documentation with search and everything. (https://docs.angularjs.org/api)

@JesseChrestler wow that's awesome, thanks for replying back. :) I'm going to attempt to do what you did and hopefully it works out. If you do write a tutorial, let me know, it would be much appreciated.

@LuizGsa21 here is a seed that I setup. Nothing fancy but hopefully it will help you and anyone else looking for a similar solution.
https://github.com/JesseChrestler/angular-dgeni-seed

Hi Jesse, awesome work! I'd like to give this a try also, I'm running into a problem however. Here is the stacktrace:
started configuring docs...
finished configuring docs...
[17:07:53] 'build:docs' errored after 562 ms
[17:07:53] TypeError: object is not a function
    at Function.v.extend.async (C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\validate.js\validate.js:196:14)
    at C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\lib\Dgeni.js:166:23
    at _fulfilled (C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\q\q.js:796:13)
    at C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\q\q.js:857:14
    at runSingle (C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\q\q.js:137:13)
    at flush (C:\Repositories\OtherTrunk\Source\NControl\NCore.Client\node_modules\dgeni\node_modules\q\q.js:125:13)
    at process._tickCallback (node.js:419:13)

Any ideas what I'm doing wrong?

feel free to email me the steps you did. jessechrestler[at]gmail.com I would be more than happy to help you. I just grabbed a zip of the master. Extracted it into a folder. Went into that folder did an npm install. Then I ran the command gulp build:docs. Can send me an email and walk me through the steps you did?

Hi, I was trying to run the gulp task by the task runner explorer from within Visual Studio. If I run the gulp task from the command prompt, it runs just fine. Thanks for the response, I'll try to debug it myself now I know where the problem lies.

Ok, great. If you run into any another issue post the issue on the seed project or send me an email.

@JesseChrestler nice work with your repo! I finally declared it as service and suffixed my provider with word Provider.


Add to zwave services descriptions

Description:
Add to zwave services descriptions.
Mention downside of secure nodes and replace "Refer to OZW.log for details" which sounded like OZW.log has some extra manual, to "Refer to OZW.log for progress"

Cherry-picked for 0.47


Add Ubuntu16.04 build dockerfile

Create and Ubuntu16.04 dockerfile similar to the CentOS6/7 ones so that we can continue to run these on a more secure host for the arm32 JDK8/11 builds which we currently build on Ubuntu 16.04

Checklist

[x] commit message has one of the standard prefixes
[ ] FAQ.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

NOTES:

It looks like openjdk-7-jdk can no longer be located  so I have removed that and set JDK7_BOOT_DIR to point to openjdk-8. It may have been removed from http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/pool/main/o/openjdk-7/ for armhd at some point. I have a tarred up version of the openjdk-7-jdk directory from one of the current build machines so potentially it could be deployed if we decide that using JDK8 to bootstrap JDK8 is not desirable going forward.
If we're going to put this into prodution we'll need a way to generate and distribute the image to the build systems, but putting this dockerfile in place is a first step.
A static copy of an image created form these changes has been created with SHA256 checksum 87a9a90c12eae690b7f3f71e0e7b204e19dcca5575ce889d39fa668703e981a4 (recording that for my own benefit as I have not published it anywhere)

Ansible Lint failure appears unrelated to this PR but will need to be investigated

@sxa I pushed up the jenkinsfile changes in order to build and push this dockerfile

@sxa I pushed up the jenkinsfile changes in order to build and push this dockerfile

If I'm reading that right you've done it for aarch64. This is being done as a requirement for armv7l which we are currently building on Ubuntu 16.04 - we should not require this build for architectures other than armv7l unless there's a different use case that you're thinking of.

I added a build for x64 just because it would be strange to only build an arm64 image but didn't add ppc64le

I added a build for x64 just because it would be strange to only build an arm64 image but didn't add ppc64le

But we only need it for arm32, not arm64 :-)

Haha my bad, I'll update the jenkinsfile later

okay @sxa that should be good now

Thanks. I'm going to hold off on merging for now due to another issue with the compiler that we need to think about ... (I may just think about it, procrastinate for a bit, merge it anyway, then find a better solution later)
Ref: https://github.com/adoptium/adoptium-support/issues/319

Solaris failure does not seem related to this PR therefore merging. Have raised https://github.com/adoptium/infrastructure/issues/2226 to investigate


Fix canary execution during prod release

The new canary secrets weren't being propagated from the root prod release workflow into the CI workflow, so the canary was failing. This PR propagates those secrets, and also makes it possible to run the full CI workflow in a dry-run release so that it's possible to test in the future.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Successful canary run: https://github.com/smithy-lang/smithy-rs/actions/runs/8639272994/job/23685586028


Readme nitpick?

First, congrats on the placing in the Gopher Gala contest.
Ok, so this is just nitpicking about your readme, but:

Nuts are not part of a Gopher's natural diet.
The image shown is a chipmunk, not a gopher.

Maybe you didn't know, or don't care, or maybe it's just a joke that's lost on me.
Again, congrats on the contest.

@kpublik I didn't know much about Gopher's diet but a quick search says it eats nuts. The image may not be a Gopher, but hey, tips to win a hackathon - putting a cute image on the README :beers:! Again, thanks for the interests in the project!


Create login page

Create login page

This is the login screen. You are only here if you are not logged in. Click the "let's go" button to login.

Google login

Map page, redirected here once you logged in. Automatically redirected here if already logged in and accessing site.

This is the login screen. You are only here if you are not logged in. Click the "let's go" button to login.

Google login

Map page, redirected here once you logged in. Automatically redirected here if already logged in and accessing site.

Nice Inclusion of the screenshot!

Hi Andrew, could you tag this to an issue, and add some more description to the PR? For example, 'Create a log in page to allow users to x, y, and z. Addresses the abc section of design doc (with link).
For workflow purposes I'm going to change the assignee back to you, and then you can assign back to Carolyn and I as the comments are addressed.
Thanks!


Make youtube-dl optional in BrozzlerWorker.brozzle_page

Enabled by default (of course).
Speed is significantly improved when it is disabled.
Motivation

Description

Testing and Deployment Plan

👍🏻👍🏻👍🏻


Support request.query decoding

See test, but this effectively works like this, given the query string param1=%F0%9F%91%BE%20&param2=Exterminate%21&%F0%9F%91%BE=123&%F0%9F%91%BE=456
decodeQueryString(request.query)['param1'] == '👾 ' &&
decodeQueryString(request.query)['param2'] == 'Exterminate!' &&
decodeQueryString(request.query)['👾'][0] == '123' &&
decodeQueryString(request.query)['👾'][1] == '456'

i.e.:

Doesn't trim
decodes all utf-8
supports lists of values

It is exposed as an "extension" that's only enabled via Expression::new_extended, but mostly thru Predicate::route_rule that's now only used in the config, when compiling RouteRuleConditions

@guicassolato so this works for your use-case(s)?
Also, that last test is somewhat sad... wdy'all think?

So reading this:
// If a query param is repeated in an HTTP request, the behavior is
// purposely left undefined, since different data planes have different
// capabilities. However, it is *recommended* that implementations should
// match against the first value of the param if the data plane supports it,
// as this behavior is expected in other load balancing contexts outside of
// the Gateway API.
//
// Users SHOULD NOT route traffic based on repeated query params to guard
// themselves against potential differences in the implementations.

Wondering if we shouldn't always have the first param in our Map and drop the List altogether...
I have a PR getting ready that would:
fmt.Sprintf("decodeQueryString(request.query)['%s'] == '%s'", queryParam.Name, queryParam.Value)

@guicassolato do you have an opinion?

Alternate proposal, that I'll implement here right now, pass an optional 2nd bool param, that would dictate whether to return a List when repeated params are present, or only the first one (includeRepeatedParams: bool kinda thing).

In description it says decodeQueryString but in the implementation I see queryMap.