Fork created with updated VMA version and most pending PRs merged

The vk-mem-rs project has been experiencing a lack of maintenance activity. Last year, #62 was merged without reviews which broke the tests and caused build failures. The original author  @gwihlidal seems to have been busy and did not respond to my emails. So to address this issue and ensure the project remains active and useful, a new fork of vk-mem-rs has been created under the dust-engine organization. The new fork has up-to-date dependencies and has merged #63 which fixed the build failure alongside other improvements. The purpose of this fork is to provide an actively maintained version of vk-mem-rs that incorporates the latest community contributions and resolves any outstanding issues.
We invite the community to join us in the new fork of vk-mem-rs. Your contributions, feedback, and assistance in reviewing and merging PRs will be greatly appreciated.
Repository Link: dust-engine/vk-mem-rs
crates.io Link: vma

There is also gpu-allocator which implements the allocation algorithms and business logic for Vulkan and DirectX12 directly in rust :grinning:

@MarijnS95
Thanks! I'm aware of the gpu-allocator project but it's lacking certain features that we need, like defragmentation, memory pools and virtual memory blocks. I will continue to maintain the vk-mem-rs project until gpu-allocator reaches feature parity.

Hey @Neo-Zhixing - apologies for such a late reply - I've been absolutely swamped, and no time for rust sadly (at least right now). I'd be willing to give you co-ownership of this repo instead of maintaining a fork if you are open to that.

@gwihlidal That'd be great! Please also add me to crates.io so that I can publish new versions.

@Neo-Zhixing which repository are you actively maintaining? I'm looking to use some binding to VMA

@bkolligs I'm still maintaining the forked repo since @gwihlidal did not actually give me co-ownership
https://github.com/dust-engine/vk-mem-rs

With #66 the fork is no longer being maintained. I have updated this repo & published the latest changes to cargo.


fix(RadioTile): Accepts className in props

Closes carbon-design-system/carbon-components-react#
label in RadioTile now accepts className via Props
Changelog
New
static propTypes = {
          checked: PropTypes.bool,
          className: PropTypes.string,
          defaultChecked: PropTypes.bool,
          id: PropTypes.string,
          name: PropTypes.string,
          onChange: PropTypes.func,
          value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
  };

Changed

className: PropTypes.string

Removed

N/A

You are very welcome - looking forward to making some more contributions 😄

Thanks @asudoh  and no problem hope to submit more PR's in future 👍


Documentation clarification for universal link settings

Hello there is a slight ambiguity in documentation files,
this link
https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK
and this link
https://start.branch.io/?__hssc=&__hstc=196949811.01a59d63dfb29d34d9136d1e2fa52ef4.1453236561358.1461623127530.1461671981260.17&__hsfp=1189881812&hsCtaTracking=d8a94b5f-4160-45df-9c13-c71f7c5e8031|d4846147-2f7f-4600-ab4d-9facf5fb409b#/integrate-sdk/steps
says

iOS: Enable Universal Links
In iOS 9.2, Apple dropped support for URI scheme redirects. You must enable Universal Links if you want Branch-generated links to work in your iOS app. To do this:
Enable Associated Domains capability on the Apple Developer portal when you create your app's bundle identifier.
In your Dashboard Link Settings, tick the Enable Universal Links checkbox and provide the Bundle Identifier and Apple Team ID in the appropriate boxes.
Add the following entry to your application's config.xml:

> <branch-config>
>     <ios-team-id value="your_ios_team_id" />
>     <host name="bnc.lt" scheme="https" />
> </branch-config>

But this link
https://dev.branch.io/getting-started/sdk-integration-guide/guide/cordova/
says that

Caution: You should also configure Universal Links
In iOS 9.2, Apple dropped support for URL scheme redirects. You must also enable Universal Links to get full functionality from Branch on iOS 9.2+.

Where it says that I must enable universal links, ok:
https://dev.branch.io/getting-started/universal-app-links/
Says on cordova guide tab, that

Prerequisite: Complete the SDK Integration Guide first
This guide requires you to have already integrated the Branch SDK into your app.

Where it says to go back to
https://dev.branch.io/getting-started/sdk-integration-guide/guide/cordova/
Is this some sort of circular dependency?
But okay, I try to follow the enabling universal links part on
https://dev.branch.io/getting-started/sdk-integration-guide/guide/cordova
I have an app id, associated domains enabled, universal links enabled on Branch dashboard, and get to the APP ENTITLEMENT PART where it says

> <branch-config>
>     <ios-team-id value="your_ios_team_id" />
>     <host name="xxxx.app.link" scheme="https" />
>     <host name="xxxx-alternate.app.link" scheme="https" />
> </branch-config>

Now, this is interesting, because on the other links it said:

> <branch-config>
>     <ios-team-id value="your_ios_team_id" />
>     <host name="bnc.lt" scheme="https" />
> </branch-config>

So. What to do next? Which one is right and which one is not. There are referrings, that if I have a bnc.lt on my branch dashboard, I should use bnc.lt. Ok, I keep it that way.
In iOS 8.4 it works, however first opens in Safari.
In iOS 9.2+ it just does not work. It opens the deepview in safari and stays there.
I keep trying to discover more issues in https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/issues/129#issuecomment-214938375

Hey @barocsi ,
I'm not sure if the documentation in https://dev.branch.io is updated.
However, the way the testbed has been implemented follows on what you see in the README.md.
I do only have tested this in the emulator and so far it didn't also opened the app.
Let me investigate more in the issue and what's the probable cause.

Thanks,
Also not that in iOS 9.3.1 also does not work with live device. (mentioned in https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/issues/129#issuecomment-214938375).

I have noticed something.

Open the app
Open Facebook or Gmail, click on a bnc.lt link
Opens in safari, but dont opens in the app
Close the app
Start the app
It opens the originally intended url from step 2.

ok I have found something very similar here:
http://stackoverflow.com/questions/35314966/wkwebview-still-not-handling-universal-link

And a possible another explanation:
http://stackoverflow.com/questions/35172678/universal-links-not-working-with-wkwebview

Another bit of useful information:
https://github.com/EddyVerbruggen/Custom-URL-scheme/issues/144

@barocsi , thanks for the leads.
I'll replicate the issue first and see what I can found and submit a fix.

However if I turn off universal link option on dashboard, should it employ javascript method?
According to this
https://github.com/EddyVerbruggen/Custom-URL-scheme
There some sort of JS to should handle app opening on my branch deepview page, but it still only works below iOS 9.2.

As of iOS 9.2, the dialog Open in "mycoolapp"? no longer blocks JS, so if you have a short timeout that opens the app store, the user will be taken to the store before they have a chance to see and answer the dialog. See below for available solutions.

hmm, not sure if it does need to employ a javascript method for this.
This plugin was based on the previous version of the plugin, so not sure if this is still applicable for the latest. 😕

http://stackoverflow.com/questions/35138257/branch-deep-link-not-opening-application
This could be an issue.

Hey @barocsi - Can you review the support section of the documentation? https://dev.branch.io/getting-started/universal-app-links/support/ios/#appsbrowsers-that-support-universal-links In order to test, we recommend using messages or notes on a live device.
This is likely not a problem with the plugin, as we have successfully tested Universal Link with this version.

I am having the exact same issue as described by barocsi above  ... I have reviewed the troubleshoting guide and doco as suggested. I am testing from the iOS email client on a live device  (which is what we need to work in production).

Wrap up - iOS 9.3
Disclaimer: this is just external testing experience mixed with documentation, not backed up by any developer from Branch.
So far the following is discovered with setting up universal links:

You must match team ids. This means if you run on a device with a code signing profile that does not match the id you have entered in branch.io dashboard it will not work.

For me it only worked with a device with AD-HOC distribution mode. On simulator, Universal Link does not really work according to this

If you change branch.io universal link mode to ON, the links api starts generating for you new type of links from that point and will change from legacy bnc.lt/xyz format to bnc.lt/4char_id/xyz, which is required by  Apple App Site Association file format. This means if you switched to universal link format and think your legacy link will change, it wont. You must test with newly generated links. Legacy links only work below on certain iOS versions because of the point 4. below. It might be considered for Branch team to add some sort of redirect for legacy links to add cross compatibility between links if they do not fix 9.3 URL Scheme fallback. Or just make it clear in the docs.

There are limitations of universal links, sometimes they open, sometimes they dont, there is a nice list of applications supporting or not supporting universal links. For example, I can tap on an universal link in GMail and it opens in my app, but in Facebook it stays there.

If you messed around with opening a link in your app, there usually is a popup. It unfortunately remembers to it, and you REALLY need to discover what is the saved behavior. For example in Safari, you see a deepview instead an app opening, just pull the page down and you see a line with a button to open it in the app. In facebook there is a settings button on the bottom right as well.

When a user taps a universal link that you handle, iOS also examines the user’s recent choices to determine whether to open your app or your website. For example, a user who has tapped a universal link to open your app can later choose to open your website in Safari by tapping a breadcrumb button in the status bar. After the user makes this choice, iOS continues to open your website in Safari until the user chooses to open your app by tapping OPEN in the Smart App Banner on the webpage.

Conclusion
Universal Link does not always trigger app opening. URL Scheme could be still harnessed if possible. As #129 discovers Branch.io displays different deepviews depending on your iOS version meaning if you visit with iOS 8.4 you get an iframe src hack opening yourapp:// . However in iOS 9.2+ it stopped working, so it was discontinued in favor of Universal Links.
But as #129 reference speculates it could be still there using some sort of javascript logic so in case Universal Link does not kick in within a given timeframe, URL Scheme would, as st.derrick mentioned in this SO thread:
The iframe trick no longer works -- my guess is that Apple knows it will encourage more developers to implement Universal Links, more quickly.

You can still set window.location='your-uri-scheme://'; and fallback to the App Store after 500ms. There is a "dance" between popups if you take this approach, as we do at Branch (we do as a fallback if Universal Links don't work).

window.location = 'your-uri-scheme://'; // will result in error message if app not installed
setTimeout(function() {
   // Link to the App Store should go here -- only fires if deep link fails
   window.location = "https://itunes.apple.com/us/app/myapp/id123456789?ls=1&mt=8";
}, 500);

My question is: why this piece of code is missing from bnc.lt/4char/xy links when opened from iOS9.3 as mentioned in #129 ?

Unfortunately, Facebook still blocks both Universal Links and URI scheme approach so you can never test with that browser. Additionally, as you've found, Universal Links don't work on the simulator or on most browsers. The best way to test is with Notes or Messages on a live device.
The reason we don't include the fallback URI scheme method on bnc.lt/4char/xy links on 9.3 is that 100% of the time, the URI scheme popup is ignored before redirecting to the store. Since Apple made that a non-blocking modal, Javascript continues to execute and the redirect occurs before the user can respond. The result is a jarring, modal flash and redirect experience which ultimately results in the user ending up on the App Store page 100% of the time. Therefore, we decided to make that redirect a lot cleaner and faster by just issuing a 3XX redirect to the App Store. We do, however, use this URI scheme redirect technique on Gmail iOS 9+ since that still works.
Ultimately, if you enable Universal Links and support URI, the majority of cases on iOS are handled well. The only one that is actually broken is Facebook, and it's broken for everyone unfortunately since they block both techniques.
I hope this helps clear things up. Closing the ticket for now.


Race condition between storage.clear() and store.update()

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
storage.clear() is clearing the akita storage, but the deleted store is almost immediately being restored to localStorage.
I believe I'm hitting rate condition between storage.clear() and store.update()...  where if an update is in progress to any store the storage.clear() operation is almost immediately rendered pointless as store.update() overwrites the localstorage with an AkitaStores value that contained the store suposedly just deleted.
`
Expected behavior
I expect to be able to safely and atomically remove a store, including removal from storage without any cross-impact caused by events made to other stores.
Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/github-8bgq4j?file=src%2Fapp%2Fapp.component.ts
Instructions provided in the app. All output is provided to console.
What is the motivation / use case for changing the behavior?
I believe store operations need to be independant of each other, we have no control over what operations are called in  parallel so an operation to one store shouldn't impact operations on any other store.  This results in race-conditions and other unexpected behaviour.
For further context I am using akita-ng-fire and firestore; the architecture of which I believe means that I require a dynamic EntityStore for each sub-collection...I mention this only as the choice to have many stores is I believe somewhat thrust upon me.   e.g. if data-model is

 /teams/{team}
     /matches/{match}
     /players/{player}

I end up with a store for teams... and then a matches_store and players_store for each team.

teams_store
team_{team}_matches_store
team_{team}_players_store

The net-result is I have a number of stores, which are updated via akita-ng-fire in an event-driven manor.  I have no direct control over the scheduling/timing of calls to update({}). The operation I am performing which caused me to notice this behaviour is a server-side cascade delete, where there are simultaneous(ish) event calls to delete a team from teams_store, and also triggered operations to clear/remove storage for the two sub-collection stores for matches and players.
Environment

    "@angular/core": "^11.0.2",
    "@datorama/akita": "^5.2.5",
    "@datorama/akita-ngdevtools": "^5.0.3",

Browser:
- [X] Chrome (desktop) version Version 87.0.4280.141 (Official Build) (x86_64) (on Mac).
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:  Mac

Others:

I wonder if this might be the cause of #365 ???

Subsequent to creating this, I think I've also discovered that there is a race-condition between multiple parallel update operations to different stores (i.e. this isn't exclusively restricted to clear storage).  The store getValue() call returns the correctly updated value, but the value persisted in localStorage is not correctly updated.
I've updated the stackbltz.com to also show this behaviour

Subsequent to creating this, I think I've also discovered that there is a race-condition between multiple parallel update operations to different stores (i.e. this isn't exclusively restricted to clear storage).  The store getValue() call returns the correctly updated value, but the value persisted in localStorage is not correctly updated.
I've updated the stackbltz.com to also show this behaviour


Fixed Issue #69

Fixed the colors of the links in the profile dropdown menu to white, so they no longer blend in with the background.
Fixed background color of moments page to $light-bg, to better match the rest of the theme.
Screenshot:

Updated the branch with the changes you recommended.

I'm approving this, but only @tsriram can update it on the store. In the meantime, you can run a local version of the extension so you can get the latest features.

@StewEsho @Nickkaczmarek sorry, I'd been busy with my newborn. Have just published a new version (0.0.18) with this fix. Should be up on Chrome / Firefox stores soon. Thanks much for you contribution :)


Style

The package in general is good, but need more options for change visual

I am glad you like it. However, I am looking for contributors. If you care to join.


Unexpected (incorrect?) port number reported in error when HttpClient connections fail

This is a bit confusing - I'm failing to connect to port 8000 on <IP_ADDRESS> but the error message has a different port number listed (8286). I don't know if this is the local port being used but that doesn't seem like a useful thing (and it would be confusing to display immediately after the remote host/IP).
I'm using x64 Dart SDK v1.21.0 on Windows 10 Pro.
Uri dynamoEndpoint = Uri.parse("http://<IP_ADDRESS>:8000/");

Future<String> _sendRequest(String action, Request request) async {
  final http = new HttpClient();
  final request = await http.postUrl(dynamoEndpoint);
  request.headers
    ..contentType = new ContentType("application", "x-amz-json-1.0");
  request.write(request);
  final response = await request.close().whenComplete(http.close);
  return response.transform(UTF8.decoder).join("");
}

Error:
dart bin\migrate.dart
Unhandled exception:
SocketException: OS Error: The remote computer refused the network connection.
, errno = 1225, address = <IP_ADDRESS>, port = 8286
#0      _sendRequest.<_sendRequest_async_body> (package:chart_data_migrator/dynamodb.dart)
#1      _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:34)
#2      _RootZone.runBinary (dart:async/zone.dart:1410)
#3      _FutureListener.handleError (dart:async/future_impl.dart:146)
#4      _Future._propagateToListeners.handleError (dart:async/future_impl.dart:649)
#5      _Future._propagateToListeners (dart:async/future_impl.dart:671)
#6      _Future._completeError (dart:async/future_impl.dart:485)
#7      _Future._asyncCompleteError.<anonymous closure> (dart:async/future_impl.dart:537)
#8      _microtaskLoop (dart:async/schedule_microtask.dart:41)
#9      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#10     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)
finished (255)

Looks like #12693

Yep, I think you're correct. The original comment there says it's showing local host too, though I'm seeing the remote IP and only local (probably) port (and the most recent comment on that suggests the same).
That case has been open since 2013 😢

Lets track at #12693


Accessors to own CID within mbedtls_ssl_context

Description
Add accessors to own CID within mbedtls_ssl_context, as per request in #5184
Add sanity tests for all of the own CID set / get/config functions.
Status
READY
Requires Backporting
NO
Migrations
NO
Todos

[x] Tests
[x] Changelog updated

Steps to test or reproduce
test_suite_ssl should run clean

@paul-elliott-arm Unfortunately this has conflicts now that #5622 has been merged (add-add, easy to resolve). Could you rebase to resolve them?

Check-files now complaining about missing newline at end of tests/suites/test_suite_ssl.data - probably a side-effect of resolving a conflict in that area. (The only other CI issue is an instance of #5583.)

CI Failures are unfortunately the OpenCI results, which has not yet been re-configured. Internal CI passed Ok.


Fix blob reader closing

Fix for https://github.com/lbryio/lbry/issues/923 and also some continuing work to improve the blob classes (https://github.com/lbryio/lbry/pull/898)
Blob file opened for reading ( BlobFile.open_for_reading() ) was not being closed after file transfer , thus during client reflection, too many blob files would be opened. Commit a4ea49c fixes this.
This kind of mistake could be easily made since blob files opened for reading had to be closed by calling BlobFile.close_read_handle(handle) . We can now just call handle.close() to close the blob files.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger


add python models session submission method

Problem
When executing a dbt python model, users must choose between an all-purpose cluster or a job cluster to run Python models (see docs).
This requirement limits the ability to execute dbt models inline within an existing notebook, forcing model execution to be triggered outside of Databricks.
On the contrary , SQL models can leverage the session connection method, allowing them to be executed as part of an existing session. This separation of model logic from job cluster definitions enables orchestration systems to define clusters based on different considerations.
Request:
We propose introducing a similar session option for Python models. This feature would allow users to submit Python models to be executed within a given session, thereby decoupling model definitions from job cluster specifications.
Solution
The PR offers a new submission method - session.
When selecting this method, the DBT python model compiled code will be executed on the same process DBT is being executed - assuming a spark session is available - this solution is equivalent to the session method
Notes
Related issue in dbt-spark , link
Synced with @dkruh36

@matanmichaely apologies for my delay in reviewing this; I've been very busy prepping 1.9.0 release and getting ready/going to Coalesce.  This is an interesting proposal, and I think the primary thing holding me back from wholehearted approval is that I don't know how we would write a functional test that validates your actual use case, since presumably it would have to be invoked from a notebook.  If you can include one or more functional tests to validate the behavior, we can move forward on this PR.


xcode 8.3 error

Project builds fine in Xcode 8.2.1, but in  Xcode8.3 beta4 the pod SQLite.swift produces >18 issues like:
Swift Compiler Error    Build a shadowed submodule 'Darwin.POSIX.basic'    module.modulemap
build a shadowed submodule 'Darwin.POSIX.sys.types._int8_t'
Is there a simple resolution/workaround?

@WDDong make sure you follow the instructions exactly, especially step 1)
https://github.com/stephencelis/SQLite.swift#cocoapods

@jberkel we are sure about install. This pod isn't usable with Xcode 8.3 for this time..

@ryanholden8 I tried ur setup, but with Xcode8.3 release,  it build failed.
error:  'sqlite3.h' file not found

0.11.3 has been tested with Xcode 8.3, closing.

I just got the same problem in my project too with the version 0.11.3, but I solved this problem.
Just for the record I post the solution that worked for me.
This error was trigger because I had two version of XCode on my computer, 8.3.3 and 9.1.
XCode 9.1 was named "XCode" and XCode 8.3.3 was named differently. The project that use the SQLite framework was running with XCode 8.3.3.
So the solution was to have XCode 8.3.3 renamed in "XCode" instead of the XCode 9.1.

This error was triggered because I had two versions of XCode on my computer, 8.3.3 and 9.1.
XCode 9.1 was named "XCode" and XCode 8.3.3 was named differently. The project that use the SQLite framework was running with XCode 8.3.3.

Confirm. Helped!


fix(cloudcommon): query string may be modified in listItemQuery

query string may be modified in listItemQuery routine, which cause some query
filter is removed and hence ineffective when query over splitable
这个 PR 实现什么功能/修复什么问题:
修正：由于listItem过程中会修改query，导致查询splitable时，一些query filter被移除了，导致不生效

是否需要 backport 到之前的 release 分支:

release/3.6

/cc @zexi
/area util

Codecov Report

Merging #9538 (abbcac0) into master (b300d5e) will increase coverage by 10.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #9538       +/-   ##
===========================================
+ Coverage    5.91%   16.50%   +10.59%
===========================================
  Files         843       87      -756
  Lines      130838     9120   -121718
===========================================
- Hits         7734     1505     -6229
+ Misses     122402     7483   -114919
+ Partials      702      132      -570

Flag
Coverage Δ

aFlag
16.50% <ø> (+10.59%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/dispatcher/dispatcher.go

pkg/mcclient/options/k8s/fed_role.go

pkg/compute/models/networkaddresses.go

pkg/mcclient/options/k8s/fed_joint_resource.go

pkg/multicloud/aws/internetgateway.go

pkg/compute/models/networkresource.go

pkg/monitor/notifydrivers/feishu/client.go

pkg/compute/models/dns_recordset_trafficpolicy.go

pkg/baremetal/tasks/deploy.go

pkg/mcclient/options/k8s/charts.go

... and 745 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b300d5e...abbcac0. Read the comment docs.

/lgtm
/approve


router-view

Vue-router how to write in this framework, I want to configure the same routing exit as Vue.

This question is available on Nuxt.js community (#c2633)

Is there any solution？

https://zh.nuxtjs.org/api/components-nuxt-child#-lt-nuxt-child-gt-组件


set WARNING to 5.7.1.SP1.RELEASE

Please review https://github.com/terasolunaorg/terasolunaorg.github.com/issues/204 .
Set WARNING for old guidelines to 5.7.1.SP1.RELEASE.
relates to TSF4J5-2963.

Closed because it was a duplicate.
https://github.com/terasolunaorg/terasolunaorg.github.com/pull/273


Automated cherry pick of #4423: region MakeCloudProviderInfo instance snapshots

Cherry pick of #4423 on release/2.12.
#4423: region MakeCloudProviderInfo instance snapshots

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@20468aa). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #4425   +/-   ##
==============================================
  Coverage                ?   6.83%
==============================================
  Files                   ?     501
  Lines                   ?   85411
  Branches                ?       0
==============================================
  Hits                    ?    5839
  Misses                  ?   79079
  Partials                ?     493

Flag
Coverage Δ

#aFlag
6.83% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/managedresource.go
0% <0%> (ø)

pkg/compute/models/disks.go
0.62% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20468aa...e662b4a. Read the comment docs.

/lgtm

/approve


add pratt newton method + tests

According to this book , the authors state

Given a possible numerical instability, I've added an alternative method called pratt_newton. This enhances the package and allows users to use a method where the :pratt algorithm may not work properly.
I plan on adding the SVD approach later on as well.

Codecov Report
Patch coverage: 85.71% and project coverage change: -3.68 :warning:

Comparison is base (7ca9a46) 100.00% compared to head (5d1c97a) 96.32%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #12      +/-   ##
===========================================
- Coverage   100.00%   96.32%   -3.68%
===========================================
  Files            1        1
  Lines          101      136      +35
===========================================
+ Hits           101      131      +30
- Misses           0        5       +5

Impacted Files
Coverage Δ

src/CircleFit.jl
96.32% <85.71%> (-3.68%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I simply just added a new function, so nothing changed with existing functionality. I don't know why the last test is failing (perhaps due to a very old version of julia?)

I think there is also an instability problem with the Taubins method. Some time ago I was looking into adding a more stable algorithm to find the eigenvalues, but I did not fully understand the one that was in this paper:  https://doi.org/10.1007/s10851-005-0482-8
I am sure it is very similar to newtons method for Pratts algorithm, which should reliably find the smallest non-negative generalized eigenvalue.

@feanor12 a quick question. as far as Julia packages go, do you need to tag the package for it to be updated in the Julia package registry? I'd like to delete my fork and just do a add CircleFit in my environment.

I just requested a new release to be published so there should be an update soon.

Okay perfect. Then I'll add the SVD in a bit later when I have more time... By the way, this was my first open source contribution! It's quite exciting and satisfying.


[5.6] Revert #24000

#24000 fixed a bindings problem with $withCount and nested where() constraints (#23957).
Since #24240 solves the underlying problem in a more general way, the fix from #24000 is not required anymore: Builder::where() now uses Model::newModelQuery() which creates a query without $withCount.

Instead of reverting the entire PR, could you just revert the changes to Builder.php? It sounds reasonable to keep the test to ensure everything still works.

The test doesn't work anymore because it only tested this specific workaround.

Unless there is a problem with this remaining I will just leave it.


SwiftVirtualNetworkConnectionSlot removed in 2020-12-01 spec Microsoft.Web

Hello,
I'm trying to upgrade terraform to the latest available API version for Microsoft.Web
The API for "Web Apps - Create Or Update Swift Virtual Network Connection Slot", seems to be not available:
https://docs.microsoft.com/en-us/rest/api/appservice/web-apps/create-or-update-swift-virtual-network-connection-slot
I previously raised https://github.com/Azure/azure-sdk-for-go/issues/14690 as I thought it was just missing from the SDK as the API spec was updated after the initial release (after the go SDK had been generated).
But now that the go SDK has been released and terraform has been upgraded I'm not able to upgrade.
Could the Create Or Update Swift Virtual Network Connection Slot method be added? or an explanation given,
See a diff of the API versions for this feature:
 timja in ~/projects/Azure/azure-rest-api-specs/specification/web/resource-manager/Microsoft.Web/stable/2020-06-01 on master*
$ rg SwiftVirtualNetworkConnection
WebApps.json
5728:        "operationId": "WebApps_GetSwiftVirtualNetworkConnection",
5768:        "operationId": "WebApps_CreateOrUpdateSwiftVirtualNetworkConnection",
5857:        "operationId": "WebApps_UpdateSwiftVirtualNetworkConnection",
13943:        "operationId": "WebApps_GetSwiftVirtualNetworkConnectionSlot",
13990:        "operationId": "WebApps_CreateOrUpdateSwiftVirtualNetworkConnectionSlot",
14093:        "operationId": "WebApps_UpdateSwiftVirtualNetworkConnectionSlot",
 timja in ~/projects/Azure/azure-rest-api-specs/specification/web/resource-manager/Microsoft.Web/stable/2020-06-01 on master*
$ cd ../2020-12-01/
 timja in ~/projects/Azure/azure-rest-api-specs/specification/web/resource-manager/Microsoft.Web/stable/2020-12-01 on master*
$ rg SwiftVirtualNetworkConnection
WebApps.json
5925:        "operationId": "WebApps_GetSwiftVirtualNetworkConnection",
5965:        "operationId": "WebApps_CreateOrUpdateSwiftVirtualNetworkConnectionWithCheck",
14808:        "operationId": "WebApps_GetSwiftVirtualNetworkConnectionSlot",

The operation I'm expecting is WebApps_CreateOrUpdateSwiftVirtualNetworkConnectionSlot
Spec in question:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2020-12-01/WebApps.json
The same issue is present in the 2021 API version:
 timja in ~/projects/Azure/azure-rest-api-specs/specification/web/resource-manager/Microsoft.Web/stable/2021-01-01 on master*
$ rg SwiftVirtualNetworkConnection
WebApps.json
5925:        "operationId": "WebApps_GetSwiftVirtualNetworkConnection",
5965:        "operationId": "WebApps_CreateOrUpdateSwiftVirtualNetworkConnectionWithCheck",
14808:        "operationId": "WebApps_GetSwiftVirtualNetworkConnectionSlot",

Looping in people from the previous thread:
@madsd @panchagnula

PG has fixed it in the 2021-01-15 version only.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2021-01-15/WebApps.json
Will close this, I've asked for the SDK to be generated too.


Once you select an affiliate and he starts selling, there's no way to stop him from selling

Attempt was made by reselling a cert offer
On a cert sale, there is no way to change the offer to 0
If for some reason, you could no longer sell the cert and wanted to stop a reseller from selling it, it's not possible.
Removing affiliate from "manage affiliates" list, does not stop an active resale
Changing the original offer to private only delists the original offer, not the latter.
There should be a way for the original merchant to stop the reseller from selling.

are you saying that after removing affiliate that someone was able to accept the offer from the reseller?

looked at the code, heres what a buyer should see:
"SYSCOIN_OFFER_CONSENSUS_ERROR: ERRCODE: 1101 - " + _("Linked offer alias does not exist on the root offer affiliate list");

actually buyer sees a different error, but you are right, he's not able to purchase, error makes no sense:

you should write down the steps for this.. this i think happens only because you have a negative discount offer

please retest in RC9


chore(config/navbar): remove unexpected space

Fixes: #[Add issue number here]
Changes:
Remove unexpected space from Plugin Hub's label.
This will fix below problem.

I noticed @juxianzheng has translated it to Chinese, just like other lines. But as @Baoyuantop saw in preview, this part of change does not show up. Need to take a closer look @juzhiyuan @SkyeYoung .
Originally posted by @yzeng25 in https://github.com/apache/apisix-website/pull/1024#discussion_r852842089

Screenshots of the change:

cc @yzeng25 @juzhiyuan @Baoyuantop


docs(api): remove metadata

Codecov Report

Merging #232 (821b391) into master (5393677) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   26.68%   26.68%
=======================================
  Files          52       52
  Lines        3452     3452
  Branches      659      659
=======================================
  Hits          921      921
  Misses       2251     2251
  Partials      280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5393677...821b391. Read the comment docs.


We shouldn't ask to verify deployment if the web app was created during the deploy wizard

@nturinski @fiveisprime @jinglouMSFT

Fixed in #366


All attribute validations triggered with string property

Using a string next to other types in a model, will always trigger all attribute validations on the string property, by submitting the form.
public class Model
{
	///
	/// Verification day
	///
	[Required]
	[DataType(DataType.Text)]
	public int Day { get; set; }

	///
	/// Verification month
	///
	[Required]
	[DataType(DataType.Text)]
	public string Month { get; set; }
}

In the view there are two forms defined with both one of the properties.

			<form asp-controller="Home" asp-action="Verification">

				<input asp-for="Day" class="form-control verification-day dateinput" placeholder="DD" autocomplete="off" maxlength="2" pattern="\d*"/>

				<input type="submit" value="One" class="btn btn-success" />
			</form>

			<form asp-controller="Home" asp-action="Verification">

				<input asp-for="Month" class="form-control verification-day dateinput" placeholder="DD" autocomplete="off" maxlength="2" pattern="\d*"/>

				<input type="submit" value="Two" class="btn btn-success" />
			</form>

By submitting the from in two-panel, the validation error will only be applied to the Month input. By submitting the form in one-pannel, the validation error will not only be applied to the Day input, but also to the Month input.
If you change the model to only work with interger properties this senario will work fine. Changing it all to sting properties, all input field will get a validation error.

@dougbu ideas?

@kvriel what are the exact validation errors that show up? MVC only deals with in the scenario you've described is [Required] on the two properties. If you're seeing issues related to the maxlength or pattern attributes, this is about your browser.
The other possibility is the verification-day or dateinput classes are causing odd behaviour.
A small repro project e.g. in a GitHub repo would help in any case. I'd like to see exactly what's happening when.

@dougbu I think the repro has enough in it, no?

Just hoping to save a small amount of time if @kvriel already has a repro project. But you're right, it's a very small amount of time :smiley_cat:

The repro covers different server-side model binding and validation errors. [Required] has no effect on non-Nullable value types but the SimpleTypeModelBinder detects invalid conversions, rejecting string.Empty when submitted for an int property. [Required] works later, as part of the validation phase, and the (string) Month property in Scenario 1 is always invalid since you're binding the entire ViewModel1 class.
For more consistent behaviour between value and reference types, suggest enabling client-side validation e.g. the following in both ScenarioX.cshtml files:
@section scripts
{

}

Probably also best to remove [Required] where .NET ignores it -- on all int properties in this case.

@dougbu so is this an app bug? Or an MVC bug? Or something else?

It's an app bug though one we see frequently.
Details: MVC is working as designed. So is .NET but [Required] semantics confuse everyone.

@dougbu is there a suggestion on something we can improve here? Or is it ultimately a design limitation of the system?

This is ultimately a design limitation of the system.
Haven't looked at our model binding or validation docs lately but perhaps we could dedicate a section to [Required] and when it is enforced?

@dougbu feel free to file a doc bug on that. I'm closing this issue for now.


"Medieșu Aurit", "Băbășești", "Iojib", "Medieș-Râturi", "Medieș-Vii", "Potău", "Românești" villages are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Medieșu Aurit" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Medieșu Aurit, PRAHOVA (Medieșu Aurit)".

Step 3
Type "Iojib" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Iojib, PRAHOVA (Medieșu Aurit)".

Step 3
Type "Medieș-Râturi" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Medieș-Râturi, PRAHOVA (Medieșu Aurit)".

Step 4
Type "Medieș-Vii" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Medieș-Vii, PRAHOVA (Medieșu Aurit)".

Step 6
Type "Potău" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Potău, PRAHOVA (Medieșu Aurit)".


Credential Parameter

Again PsScriptAnalyzer I think is confused on the usage here, most likely just need to cast the param as the proper object.
Parameter '$Credentials' should use SecureString, otherwise this will expose sensitive information. See ConvertTo-SecureString for more information.
Line:

774

Using psscredential objects resolves this see: 3b72187a66463de16ccba56e538ea030ff83b151


How to override findAll()?

So I'm trying to override a remote adapter and adjust how it's grabbing data from a response.
The response from the API is formatted as such:
{
  "data": [] # an array of models
}

So I tried adding this mixin:
mixin BooksAdapter on RemoteAdapter<Book> {
  @override
  String get baseUrl => '${dotenv.env['API_URL']!}${'api/$version'}';

  @override
  String get identifierSuffix => 'Id';

  @override
  Future<List<Book>> findAll({
    bool? remote,
    Map<String, dynamic>? params,
    Map<String, String>? headers,
    bool? syncLocal,
    bool Function(Book)? filterLocal,
    OnData<List<Book>>? onSuccess,
    OnDataError<List<Book>>? onError,
  }) async {
    remote ??= true;
    syncLocal ??= false;
    params = await defaultParams & params;
    headers = await defaultHeaders & headers;
    filterLocal ??= (_) => true;

    if (!shouldLoadRemoteAll(remote, params, headers)) {
      final models =
          localAdapter.findAll().where(filterLocal).toImmutableList(); // throws error saying findAll() cannot be used because protected
      models.map((m) => m._initialize(adapters, save: true)); // can't call the private _initialize method
      return models;
    }

    final result = await sendRequest(
      baseUrl.asUri / urlForFindAll(params) & params,
      method: methodForFindAll(params),
      headers: headers,
      requestType: DataRequestType.findAll,
      key: internalType,
      onSuccess: (data) async {
        // just want to change data to data['data']
        final models = data != null ? deserialize(data['data'] as Object).models.where(filterLocal!).toList(growable: false) : <Book>[];
        return onSuccess?.call(models) ?? models;
      },
      onError: onError,
    );
    return result ?? <Book>[];
  }

  @override
  FutureOr<Map<String, String>> get defaultHeaders async => await super.defaultHeaders
    ..addAll({'Accept': 'application/json'});
}

I'm guessing there's a different way? The docs show a way to override an onResponse function but I don't see that anywhere so I'm assuming that's deprecated/removed?

Let me have a look tonight but first thing that comes to mind is calling super.findAll() in the override with a custom onSuccess argument such as:
onSuccess: (data) {
  return deserialize(data['data'] as Map<String, dynamic>, init: true).model;
},

Unfortunately that still doesn't work as the parent findAll method still attempts to convert the data from the API call into a List:
/// lib/src/repository/remote_adapter.dart:261

    final result = await sendRequest(
      baseUrl.asUri / urlForFindAll(params) & params,
      method: methodForFindAll(params),
      headers: headers,
      requestType: DataRequestType.findAll,
      key: internalType,
      onSuccess: (data) async {
        if (syncLocal!) {
          await localAdapter.clear();
        }
        /// This is the line I need to override
        final models = data != null
            ? deserialize(data as Object)
                .models
                .where(filterLocal!)
                .toImmutableList()
            : <T>[];
        return onSuccess?.call(models) ?? models;
      },
      onError: onError,
    );

Sorry if I'm missing something – you do not want to return a List<T>?
If your JSON response data does not adhere to the standard JSON of the adapter can do that by overriding deserialize. Could you share what those look like?

How would I create an adapter for serializing/deserializing the JSON?
Right now it seems like the default deserializer expect the JSON from the API to look like:
[
  {
    "id": 1,
    "title": "Book 1",
  },
  {
    "id": 2,
    "title": "Book 2",
  },
]

but the response actually looks like:
{
  "data: [
      {
      "id": 1,
      "title": "Book 1",
    },
    {
      "id": 2,
      "title": "Book 2",
    },
  ],
}

So I just need to change the deserializer to try and deserialize the data key to get the list of models. If I need to create another adapter, what adapter should my mixin be on and what should I override?

I would think something like:
mixin SomeAdapter<T extends DataModel<T>> on RemoteAdapter<T> {
  @override
  DeserializedData<T, DataModel> deserialize(dynamic data,
      {bool init, String key}) {
    return super.deserialize(data['data'], key: key, init: init);
  }
}

You can then mix this into any model that has that JSON structure

That worked like a charm! And now I think I'm starting to understand the adapter better, thanks for the quick replies and help!

Glad that it worked!

Hello, is there maybe any update on this? Because I am trying to do the same thing with the newest pre release 2.0.0 version (I am not sure if it's also failing in the 1.6.0) and sadly even with overwriting the new parameters, it does not work. ☹
mixin MyJSONServerAdapter on Adapter<Album> {
  @override
  String get baseUrl =>
      "https://crudcrud.com/api/533e9b77b7c841879470be0d79e5a5d0/";

  @override
  Future<DeserializedData<Album>> deserialize(
    Object? data, {
    String? key,
    bool async = true,
  }) async {
    if (data is Map && data.containsKey('docs')) {
      return super.deserialize(
        data['docs'],
        key: key,
        async: async,
      );
    }

    return super.deserialize(
      data,
      key: key,
      async: async,
    );
  }
}

(It's the "docs" key here in the JSON data, instead of "data" in the example from @ArneSaknussemm89 )
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: type 'Null' is not a subtype of type 'num' in type cast
#0      _$AlbumFromJson (package:new_flutter_data_example/core/data/models/album.g.dart:49:23)
#1      _$AlbumAdapter.deserializeLocal.<anonymous closure> (package:new_flutter_data_example/core/data/models/album.g.dart:21:39)
#2      _BaseAdapter.internalWrapStopInit (package:flutter_data/src/adapter/adapter.dart:371:17)
#3      _$AlbumAdapter.deserializeLocal (package:new_flutter_data_example/core/data/models/album.g.dart:21:12)
#4      _SerializationAdapter._deserialize (package:flutter_data/src/adapter/serialization_adapter.dart:90:31)
#5      _SerializationAdapter.deserializeAndSave.<anonymous closure> (package:flutter_data/src/adapter/serialization_adapter.dart:118:25)
#6      _BaseAdapter.runInIsolate.<anonymous closure> (package:flutter_data/src/adapter/adapter.dart:210:18)
<asynchronous suspension>
#7      _RemoteRunner._run (dart:isolate:1092:18)
<asynchronous suspe<…>


[WIP] feat: new generator for React-Native with expo

[WIP] New generator for React-Native using Expo
This PR is WIP
Lifting of the react-native generator
Current version of expo generator was made in Javascript, this version is fully typed with Typescript
Added libraries

Expo Router to handle navigation
Redux-toolkit to handle states & api calls
NativeWind to make the app look like other recent generators
React-Hook-Form to handle forms

TODO

[ ] Add support for mercure (present in current generator)
[ ] Add confirm box for delete button (present in current generator)
[ ] Handle hydra:prefix (not present in current generator)
[ ] Handle entity relations (not present in current generator)
[ ] Fix fields generation bug when generated from api-platform demo (not present in current generator)

Visual preview
Preview are from a real device

Pretty cool! Thank you very much for working on this.
Regarding the stack, two questions:

Is it still worth it to use Redux? It isn't hype anymore and it introduces a lot of complexity. As it's a minimal template, I'm not sure it is necessary
Can we use TanStack Query instead for API queries? It is popular and provides nice feautres.

Pretty cool! Thank you very much for working on this.
Regarding the stack, two questions:
* Is it still worth it to use Redux? It isn't hype anymore and it introduces a lot of complexity. As it's a minimal template, I'm not sure it is necessary

* Can we use TanStack Query instead for API queries? It is popular and provides nice features.

Hello
Yes we could, I'll try the migration to see how it goes but it seems better indeed


mubert-base.commons-math.mid-1070.idx-126070.204.mutant

Remove leading whitespace

Needs to fix indentation to match formatting

@faustinoaq I don't understand your comment. If the change is good, write just LGTM. If not good, point out what specifically is not good.

@faustinoaq I don't understand your comment. If the change is good, write just LGTM. If not good, point out what specifically is not good.

If you open the file the indentation of the public method is wrong please see: https://github.com/Intelligent-CAT-Lab/UIUCPlus/blob/be54dcc89d21e0aaac572337560ce9cade71d867/commons-math/commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/JacobianMatrices.java#L297-L315


ReferenceError: YT is not defined

I get:  ReferenceError: YT is not defined whenever I try to include more then one  youtube video. I define distinct src, ref and id. Is  it possible to define more then one YouTube component?

@coderkawy Did you get this working?
Running it to the same problem.

@coderkawy @marc-kbpm I fixed it by adding the IFrame Script Tag to my Public HTML File.
Just add
<script id="youtube-iframe-js-api-script" src="https://www.youtube.com/iframe_api"></script>
I believe it's because the promise that tries to resolve it breaks.

Alternatively, you can add the following just above your <Youtube /> embed, if you don't want to include it on all pages.
<component is="script" id="youtube-iframe-js-api-script" src="https://www.youtube.com/iframe_api"></component>

I am having this error and adding the script tag to the HTML didn't work for me :(


Nothing changed the same problem

Yes the same issue with the new version wallet . I bought 7 contracts this evening. All of them closed just after 5 minutes. This should be fixed.
Thank you

Let's start with buying one contract and verifying that you're getting inbound hashrate.  When you purchase a contract, do you see anything in the Connections window? If not, then it's likely your inbound network is not configured properly.  If that's not correct, your Buyer's node will close the contract because it's not getting the right hashrate (or any).

This is what it should look like if you have network connections setup properly:

If that's not working, check out the Port Forwarding or 3rd Party VPN Configuration in our Gitbook: https://gitbook.lumerin.io/lumerin-hashpower-marketplace/buyer/2.-network-changes-for-receiving-hashrate


Really check for Statuscode errors and return Error classes

This PR uses the new Error classes to instoduce StatusError classes that are thrown when an unexpected StatusCode is returned.
This also fixes the "waitForSucces" to really wait for a success reswponse and not for "any" response

Ok, I checked more in deoth the throwIfError and waitForSuccess and optimized more ... hopefully now less "duplicate" code

@mfucci Ready for re-reveiw ... I adjusted ... you were right regarding duplicste throwIfError

Ready for re-review


Wrong duration when input is a stream image

Hi,
var stream = fs.createReadStream('image.png');
  ffmpeg()
    .input(stream)
    .withVideoCodec('libx264')
    .loop(30)
    .output('file.mp4')
    .run();

The output is always just 1 frame, so it's 0 seconds.
While, if I'm running the same command in the console:
 cat image.png | ffmpeg -loop 1 -i pipe:0 -vcodec libx264 -t 30 file.mp4

the output is correct, I'm getting a 30 seconds of video.  Am I doing something wrong?
Thanks

Those are not the same command: in the first case you're doing -loop 30 and in the second -loop 1 -t 30. If your command line in the bottom works, use .loop(1).duration(30) to do the same with fluent-ffmpeg.

With the command that I described, inspecting FfmpegCommand() options, it receives:
[ '-loop',
  '1',
  '-i',
  'pipe:0',
  '-y',
  '-vcodec',
  'libx264',
  '-t',
  30,
  '/[PATH]/file.mp4' ]

.loop(30) is setting -loop 1 and -t 30. And when I run .loop(1).duration(30) I get:
  [ '-loop',
  '1',
  '-i',
  'pipe:0',
  '-y',
  '-vcodec',
  'libx264',
  '-t',
  1,
  '-t',
  30,
  '/[PATH]/file.mp4' ]

So the -t is defined twice and I still have the same problem, when the input is a stream I can't set the duration.

Oh, I think you misunderstood the loop() method:

loop() sets -loop 1
loop(1234) sets -loop 1 -t 1234

So you just have to use loop(30). No duration() call.

Yes, you are right and because of that, the command I'm using is what I post in the first comment:
var stream = fs.createReadStream('image.png');
  ffmpeg()
    .input(stream)
    .withVideoCodec('libx264')
    .loop(30)
    .output('file.mp4')
    .run();

The bug still persists thought: the duration isn't set when the input is a stream. It outputs a video with a single frame.

Hey @cat2608 were you able to fix this issue? I'm running into the same thing. When I source from a file it makes the video with the correct duration but if I don't it creates a single frame video. Pretty much the same command as you're using.
I've been able to achieve a longer video by lowering the inputFps, but that makes the code harder to read so I'm not a fan.

Hi @fozzle, have you tried what you need running it in the command line? In my case, with this command:
cat image.png | ffmpeg -loop 1 -i pipe:0 -vcodec libx264 -t 30 file.mp4

I get what I need. What is not working for me is the translation using this node-fluent-ffmpeg...


import path resolve error with aliases + esmResolve

Environment
In stackblitz
System:
OS: Linux 5.0 undefined
CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 0 Bytes / 0 Bytes
Shell: 1.0 - /bin/jsh
Binaries:
Node: 16.20.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.4.2 - /usr/local/bin/npm
pnpm: 8.6.10 - /usr/local/bin/pnpm
Reproduction
c12-repro
https://stackblitz.com/edit/stackblitz-starters-2bmvpw
jiti-repro
https://stackblitz.com/edit/stackblitz-starters-u9wwgy
steps

run node index.js
change import methods in the my.config.js

Describe the bug
It has a file whose path is like middlewares/security/index.js.
When loading files by c12 with the JITI alias, it can't resolve path ~middlewares/security which must be ~middlewares/security/index.
But both paths above can work in JITI.
Additional context
No response
Logs
No response

Hi dear @LoTwT thanks for your nice reproductions and sorry it was hidden amongst other issues.
I have tried your jiti reproduction and it seems it was and issue with jiti until 1.21.0. With latest mlly and pathe utils in 1.21.6 issue seems to be solved! (updated blitz)
You might want to try updating yourlockfile and please let me know if had any other issues.


Ssh terminal repeats bugs.

Describe the bug
A clear and concise description of what the bug is.
Informations

Device : [e.g. iPhone 11]
OS : [e.g. iOS 14b4]
WebSSH Pro version : [e.g. 14.1.2]

Screenshots
If applicable, add screenshots to help explain your problem.
To Reproduce
Steps to reproduce the behavior:

Go to 'Ssh terminal'
Touch on 'Use Chinese input method.'
Touch the keyboard. to 'Enter any content and click to confirm.

'
4. See error

Hello @chuan01
I have fixed the repeat bug. Please note that a black bar will remain above the keyboard (pinyin prediction?) and I will not remove it yet.
Could you test the TestFlight release?
☀ Have a nice day


feat(form/linting): account for full semver specifiying version

Account for full major.minor.patch being serialized in diagrams.
Show major.minor in error messages only

Built Artifacts

https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/form-semver-maj-mi-pa/camunda-modeler-form-semver-maj-mi-pa-linux-x64.tar.gz
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/form-semver-maj-mi-pa/camunda-modeler-form-semver-maj-mi-pa-mac.dmg
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/form-semver-maj-mi-pa/camunda-modeler-form-semver-maj-mi-pa-mac.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/form-semver-maj-mi-pa/camunda-modeler-form-semver-maj-mi-pa-win-ia32.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/form-semver-maj-mi-pa/camunda-modeler-form-semver-maj-mi-pa-win-x64.zip

@andreasgeier I'll provide you with a distribution of this one + all linting related improvements. Stay tuned :clock1:

@philippfromme @andreasgeier Built artifacts available for testing the whole package :arrow_up:.

If you realize unexpected behavior or make changes during implementation, please report it asap so that I can reconsider the proposal and how it affects UI/UX.
Change of order in status bar:
The linting status is placed between profile selection and deploy. I understand the logic behind this change since it reflects the usual workflow: select execution profile -> debug your diagram -> deploy it -> run it.
But I disagree with this change and request the order as it is defined in the prototype. The reason for this is that the text string of the linting output will constantly change (its length) which will cause a repositioning of the following icons for deploy + run every time. This might become an even bigger issue when we have warnings, too.
When we have warnings for the first time, I want to reconsider it and might find a solution with a static width which would allow us to put it in the logical order without flickering of the other symbols. For now, please stick to the design.
Unfriendly validation of tasks
I see that the creation of a task immediately results in a linting error. I will give this a thought because it is not a desired default behavior that users get permanent error messages while they model their process.
However, me might see the same behavior when we integrate implementation property linting. This is a result of not having a dedicated design and implementation phase as originally defined.
@nikku Did you give this a thought and have a proposal how to fix it?

But I disagree with this change and request the order as it is defined in the prototype.

Let's move it.

I see that the creation of a task immediately results in a linting error. I will give this a thought because it is not a desired default behavior that users get permanent error messages while they model their process.

As you mention, this is by design at the moment:

Users must model tasks first, change them to something executable later
A task is shown as an error (which it is; it is not executable), rather than a warning

We could consider tuning in both directions. Looking into the future (i.e. connectors) it will be easier to place stuff that can just be executed right from the palette/context-pad.
For modeling tasks first I'd argue that this is about a user understanding what is needed to make a process executable. The user learns what needs to be done, and that is a good thing.
Mid-term auto-fix capabilities could allow us to move through each of these errors, prompting the user what to do (i.e. how shall that task be implemented?). :arrow_right: This will be a massive improvement to the modeling UX, as it supports the "make an existing diagram executable" story.
Short term, we could move to a execution focused palette (only showing actually executable elements in Camunda Cloud editor). But this is where we came from (and decided to ditch it, in favor of generic first). :arrow_right: I'd not go down that route but wait for feedback first. It is fine to implement something that is incomplete first (cf. also your point on missing properties; it will be a common use-case!).

CC @currandwyer

Regarding validation of tasks in a cloud diagram:
I agree that we should keep it for now as it is: a task without type causes a compatibility error. This is part of a bigger question and is also related to upcoming implementation props linting.
I see some options how we could fix this in the future to avoid unfriendly validation for modeling-only use cases. For instance, let users toggle the linting off/on.

Design review summary:

change order of linting output in status bar
change linting output color to red (see prototype)
let's keep the task linting behavior as it is implemented

I see some options how we could fix this in the future to avoid unfriendly validation for modeling-only use cases. For instance, let users toggle the linting off/on.

Exactly. Users could, at any time, decide which categories of errors to account for. If I'm modeling only I can disable linting for execution this way.

I really like that the click-to-select action is already part of the linting feature ❤

@andreasgeier I've adjusted the linting status bar item and updated the artifacts so you can see it in action.


⚠ Bofrost.de has degraded performance

In 8194dba, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 999 ms

Resolved: Bofrost.de performance has improved in f9395e7 after 20 minutes.


Point2 enhancement

I test new functions this way:
    from sc2.position import Point2, center_point2
    a = Point2((2, 4))
    pprint(2 * a + (- a / 2) - a)
    pprint(abs(a))
    pprint(a)
    b = a + Point2((0.02, -0.01))
    pprint(b.is_same_as(a))
    pprint(a.square_vector(b))
    pprint(a.manhattan_distance(Point2((6, 7))))
    pprint(center_point2([a, b, Point2((3, 5))]))

Now:
a.direction_vector(b)
Point2.center([a, b, Point2((3, 5))])

Point2.center((a, b, Point2((3, 5)))) - is ok too

Merged https://github.com/Dentosal/python-sc2/commit/93a3ccda27a4649aa8ff35b67fae7669485237f7


Provide sample init.d auto-run with automatic .webapp read.

It would be nice to have some init.d to autorun service, with options to run under www-data, automatic reload after dir of webapp's changes, one process per webapp file (similar iis pool config).

In Progress. At first there will be version for one process, then I'll see what can be done additionally to provide autostart for several hyperfastcgi processes (like application pools)

Fixed via https://github.com/xplicit/HyperFastCgi/commit/8ba103a6fb61caabe5c1fa81530dc98353aca7ad
There are two files: init.d script itself and install-service.sh script for Ubuntu.
tested with Ubuntu 14.04 and Ubuntu 15.10

Thank you, going to test soon.


Fixed a rare command sync bug

It was impossible to register commands of different types with the same name. The reason was one of the internal functions that compares old and new commands. It mapped them like {name: cmd} instead of {(name, type): cmd}
Checklist

[x] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running pre-commit run --all-files

[x] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Turns out we no longer need the type_migration diff field. API no longer forces users to manually delete a command in order to replace it with a command of another type but an identical name. I made all necessary changes so now the sync logic should work fine.


Test merge twoerners fork

Several components needed when meta-etnaviv was created have been mailined and are no longer needed. twoerners fork seems to have takens som eof these actions already and may be more up to date. Pull into temp branch before possibly messing up master

Why not get it sent to meta-freescale instead? most of it is there already.

I'll consider it. My testing is on hold for a couple of weeks.


[FEATURE REQUEST] ...

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

no

Describe the solution you'd like
A clear and concise description of what you want to happen.

I'd like to have a column on the budget screen that shows how much more needs to be added to the category to meet my goal. This would allow me to quickly see which budget items are the least funded relative to their goal. Having a total for this column would also allow me to compare the total with what income I expect to come in for the rest of the month which would then allow a user to determine if their goals are attainable this month. It would also help to project how much extra income you may have relative to your goals and start planning where you might put that extra income.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I think we have a few features that are meant to help you see your goal progress (progress bars, display goal amount, highlight underfunded goals, etc) which could be combined to get your your same effect. I fear adding more numbers (total goal amount minus budgeted) would just add too much noise to the already cluttered budget page.


Use of Laravel asset function in script.blade.php cause getFileUrl to return bad path

On Jun 28 a change was made to line 5 of script.blade.php so that it now reads:
var image_url     = "{{ asset(Config::get('lfm.images_url')) }}";
The asset function was added. The use of the asset function causes the trailing / of images_url to be removed.
Then getFileUrl remove the leading / here:
if (path.indexOf(ds) === 0) {
path = path.substring(1);
}
The result is a path like http:://localhost/images1/23423423.png

Thank you!
Will check this later.

Same problem with Ck-editor integration
Exemple :
http://localhost:8000/imagesshares/drap_oc1.gif
A similar problem occur when you try to delete a folder.
C:\Users\Perpleex\Documents\Project/public/files/shares/sharesexemple not found!
Shares is bound two times  and one without /
Some strange things too if you are in images mode and you create a new folder you comeback in file mode.

basename() function is buggy with Chinese characters.
We have to find out another solution.

script.blade.php

function getFileUrl(file) {
...
if (path != ds) {
item_url = item_url + ds + path + ds;
}

Root cause for #102, #103, #106

Update to 1.6.1 would solve this.

that asset thing isnt good when you want to customize your files into a Database field. I removed it but now Im getting double /photos//rNd2zDCdanpj/sliders/57d86ded98d53.jpg slash after photos.
Can you explain why did you include asset?


OCI Registry authentication

Operating system
darwin/arm64
Helmfile Version
v0.169.2
Helm Version
v0.169.2
Bug description
According to the documentation on OCI registries - https://helmfile.readthedocs.io/en/latest/#oci-registries - authentication details can be stored in environment variables REGISTRYNAME_USERNAME|PASSWORD.
I have the following repository configured:
repositories:
  - name: ociregistry
    oci: true
    url: quay.io/ORG_NAME

releases:
  - name: releaseX
    chart: ociregistry/some-chart
    version: X.Y.Z

I then export OCIREGISTRY_USERNAME and OCIREGISTRY_PASSWORD. But in doing so I get 401 error when trying to pull the chart.
I have tried leaving the ORG_NAME off the URL and instead adding it onto the chart (e.g: ociregistry/ORG_NAME/some-chart) but get the same result. The credentials are valid for that registry since I can login to the registry using helm registry login quay.io -u USERNAME and then helmfile commands succeed.
Example helmfile.yaml
repositories:
  - name: ociregistry
    oci: true
    url: quay.io/ORG_NAME

releases:
  - name: releaseX
    chart: ociregistry/some-chart
    version: X.Y.Z

Error message you've seen (if any)
Pulling quay.io/ORG_NAME/SOME_CHART:4.8.0
Pulling registry-1.docker.io/bitnamicharts/redis:20.6.0
in ./helmfile.yaml: [release "xxxxxx": command "/opt/homebrew/bin/helm" exited with non-zero status:

PATH:
  /opt/homebrew/bin/helm

ARGS:
  0: helm (4 bytes)
  1: pull (4 bytes)
  2: oci://quay.io/ORG_NAME/SOME_CHART (42 bytes)
  3: --version (9 bytes)
  4: 4.8.0 (5 bytes)
  5: --destination (13 bytes)
  6: /var/folders/pr/96mq1ylj31xgxy0hj53ql8tw0000gn/T/helmfile419419267/xxxx/xxxxx/SOME_CHART/4.8.0 (129 bytes)
  7: --untar (7 bytes)

ERROR:
  exit status 1

EXIT STATUS
  1

STDERR:
  Error: unexpected status from HEAD request to https://quay.io/v2/ORG_NAME/SOME_CHART/manifests/4.8.0: 401 Unauthorized

COMBINED OUTPUT:
  Error: unexpected status from HEAD request to https://quay.io/v2/ORG_NAME/SOME_CHART/manifests/4.8.0: 401 Unauthorized]

Steps to reproduce
N/A
Working Helmfile Version
v0.169.2
Relevant discussion
No response

@cyrus-mc please post more logs by adding --debug flag.

Turns out this is an easy solve. The problem is a helmfile build doesn't seem to do a registry login first. If I run helmfile template|apply|sync that correctly logins to the registry first.

@cyrus-mc got it.


Firmware 1.5.0_0102

Using the latest xiaomigateway3 plug-in, the original gateway was flashed with custom firmware 1.5.0_0026, and then upgraded to 1.5.0_0102 on the Xiaomi app, now Telnet cannot be opened, and the putty prompt: Network error.connection refused

You need reboot gateway and check MiHome token.

After update to 1.4.0 or 1.4.1 all accessory not response.
1.3.0 works fine.

I was tested on firmware 1.5.0_0102 and 1.5.0_026
After update to 1.4.0 or 1.4.1 all accessory not response.
1.3.0 works fine.

Same As me, 1.4.X can not work

You need reboot gateway and check MiHome token.

I tried this method, the token is also correct, the homeassistant and gateway are also restarted, but it still doesn't work.

I just tried a newly purchased device. The firmware of the newly purchased device is 1.5.0_026. After upgrading to 1.5.0_0102 on the Xiaomi App, it still cannot be accessed like the screenshot I provided.

I just tried a newly purchased device. The firmware of the newly purchased device is 1.5.0_026. After upgrading to 1.5.0_0102 on the Xiaomi App, it still cannot be accessed like the screenshot I provided.

Does MiHome app work with xiaomigateway3?

I just tried a newly purchased device. The firmware of the newly purchased device is 1.5.0_026. After upgrading to 1.5.0_0102 on the Xiaomi App, it still cannot be accessed like the screenshot I provided.

Does MiHome app work with xiaomigateway3?

Normal

Is there a way to solve

I was tested on firmware 1.5.0_0102 and 1.5.0_026
After update to 1.4.0 or 1.4.1 all accessory not response.
1.3.0 works fine.
1.3.0 still doesn't work

I was tested on firmware 1.5.0_0102 and 1.5.0_026
After update to 1.4.0 or 1.4.1 all accessory not response.
1.3.0 works fine.

1.3.0 still doesn't work

I was tested on firmware 1.5.0_0102 and 1.5.0_026
After update to 1.4.0 or 1.4.1 all accessory not response.
1.3.0 works fine.

upgrade homeassistant 1.4.x works fine

I was tested on firmware 1.5.0_0102 and 1.5.0_026
After update to 1.4.0 or 1.4.1 all accessory not response.
1.3.0 works fine.

upgrade homeassistant 1.4.x works fine

Thanks
That helped

I updated to 1.5.0._0102 from here https://github.com/zvldz/mgl03_fw/tree/main/firmware/custom.
This version shows more stable with zigbee body motion, and telnet password is blank. Everything works well from now.

When switching from firmware 1.4.7_0065 to 1.5.0_0102, the token was changed on the gateway. While I figured it out, I broke my head. No where they write about it.

It should not happened. Token changed only when you ADD device to MiHome. Update firmware shouldn't change token

Long time user, i was on 1.4.6_0012 FW and everything was fine.
When i see integration update i decide to upgrade FW to match recommanded version 1.5.0._0102 (was done from xiaomi app).
I reboot the gateway and it's not working anymore in HA. In the log i have :
2021-11-20 11:12:01  DEBUG    gateway3      <IP_ADDRESS> | Can't enable telnet
2021-11-20 11:12:35  DEBUG    gateway3      <IP_ADDRESS> | Can't enable telnet
2021-11-20 11:13:09  DEBUG    gateway3      <IP_ADDRESS> | Can't enable telnet
Gateway is still working on mi app. token has not changed and is still the same.
Could you advice what can i do?
Thanks.

Reboot (not reset): gateway, router, hass server. Check IP-address and token

Firmware 1.5.0_0102 currently supported


Default DSDL-generated package directory path

I realized that it is extremely unlikely that one will ever need to maintain several separate directories with DSDL-generated packages due to the inherent stability and immutability of DSDL definitions. The addition of a library-default path removes a substantial chunk of boilerplate from interactive sessions and simple scripts.
This PR makes the following possible, assuming that the package has been generated beforehand using the CLI tool:
import sys
import pyuavcan
sys.path.insert(0, str(pyuavcan.dsdl.DEFAULT_GENERATED_PACKAGES_DIR))
import pyuavcan.application

Without this change, the functional equivalent would be:
import sys
import pathlib
import tempfile
import importlib
import pyuavcan
dsdl_generated_dir = pathlib.Path(tempfile.gettempdir(), 'dsdl-for-my-program', f'pyuavcan-v{pyuavcan.__version__}')
dsdl_generated_dir.mkdir(parents=True, exist_ok=True)
sys.path.insert(0, str(dsdl_generated_dir))
try:
    import pyuavcan.application
except (ImportError, AttributeError):
    script_path = os.path.abspath(os.path.dirname(__file__))
    pyuavcan.dsdl.generate_package(
        package_parent_directory=dsdl_generated_dir,
        root_namespace_directory=os.path.join(script_path, '../public_regulated_data_types/uavcan')
    )
    importlib.invalidate_caches()
    import pyuavcan.application

This PR also brings a bunch of automatic cosmetic changes to the codebase, hence the large diff.

Pull Request Test Coverage Report for Build 685

46 of 46 (100.0%)  changed or added relevant lines in 19 files are covered.
148 unchanged lines in 13 files lost coverage.
Overall coverage decreased (-0.07%) to 92.28%

Files with Coverage Reduction
New Missed Lines
%

pyuavcan/presentation/_port/_subscriber.py
1
81.14%

pyuavcan/transport/can/media/socketcan/_socketcan.py
1
82.57%

.test_dsdl_generated/uavcan/si/sample/angle/Scalar_1_0.py
1
84.0%

.test_dsdl_generated/uavcan/si/sample/duration/Scalar_1_0.py
1
84.0%

.test_dsdl_generated/uavcan/si/sample/voltage/Scalar_1_0.py
1
84.0%

.test_dsdl_generated/uavcan/si/sample/volume/Scalar_1_0.py
1
84.0%

.test_dsdl_generated/uavcan/si/unit/energy/Scalar_1_0.py
1
84.31%

.test_dsdl_generated/uavcan/si/unit/length/Scalar_1_0.py
1
84.31%

.test_dsdl_generated/uavcan/si/unit/voltage/Scalar_1_0.py
1
84.31%

.test_dsdl_generated/uavcan/si/unit/volumetric_flow_rate/Scalar_1_0.py
1
84.31%

Totals

Change from base Build 678:
-0.07%

Covered Lines:
19316

Relevant Lines:
20410

💛  - Coveralls


[test] Fix flaky TestIncrementalPush::testGetOfflineStatusIncrementalPush

Fix flaky TestIncrementalPush::testGetOfflineStatusIncrementalPush
The expected behavior of this test is that if we have two versions and only the older version has seen the
incremental push then querying the latest version should return the status from the previous version.
This test fails when the version which has seen incremental push gets deleted. This fix makes sure that
the previous version exists before querying the latest version.
How was this PR tested?

Passed in all 50 iterations on GHCI
Passed in all 100 iterations each on both JDK8 and JDK11 on internal CI

Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

This test relies on having two versions of a store (backup which has finished inc-push ingestion and current version which has not yet seen inc-push). However, sometimes the backup version gets purged, and due to this querying the inc-push returns the status of the inc-push version w.r.t. current version only.
Earlier the test didn't explicitly specify how many store versions to retain and hence backup version gets purged. This fix explicitly sets the number of store versions to retain and hence creates a correct context for the test.


ci: create tag on alpha release

Signed-off-by: Timo Glastra<EMAIL_ADDRESS>@JamesKEbert I think this should do it. It will create a tag names alpha.<number> on each release. I think lerna search for the default vX.X.X prefix so should not cause any issues.
Let's try!

Codecov Report

Merging #558 (00aeec9) into main (ba3f17e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   86.01%   86.01%
=======================================
  Files         267      267
  Lines        5840     5840
  Branches      951      951
=======================================
  Hits         5023     5023
  Misses        814      814
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3f17e...00aeec9. Read the comment docs.

CI failed, but that is unrelated to this change. Need to merge a new PR for it to actually run


Create eLife_Application_2019

Putting the eLife application into markdown (new branch)

Pinging @GeorgiaHCA to address the comments above and then merge.

Awesome! Thanks for looking over it :)


config doesn't set to null on in dispose at AndroidGooglePlayPurchaseManager.

Hi Guys.
I found the following.
I see that the config is set to null in the dispose method in both PurchaseManageriOSApple and PurchaseManagerAndroidAmazon, but not in AndroidGooglePlayPurchaseManager.
Here is the dispose method of the AndroidGooglePlayPurchaseManager.
 @Override
    public void dispose() {
        googleInAppBillingService.dispose();
        clearCaches();
        observer = null;
    }

Am I wrong that the purchaseManagerConfig should be set to null in this method?
Thanks.

Also, I'm experiencing the following issue for AndroidGooglePlayPurchaseManager.
If I call the dispose method of the PurchaseManager and install it again, the handlePurchase method doesn't call after the purchase. However, the purchase was made by Google and it is restoring after the restart.
The same flow (dispose and install) is working well for PurchaseManageriOSApple. Not tested for PurchaseManagerAndroidAmazon yet.
Any ideas what is going wrong?
Thanks.

Your first message: this is not an issue in my opinion, it would be better to null the config but still having a reference to the config should be no memory leak at all.
To your second issue, please try the Googlebilling implementation. We are in the discussion of deprecating the Googleplay implementation because the emphasized way by Google is to use their billing lib nowadays. I am sure you'll have no problem with the Googlebilling implementation as I am also disposing and reinstalling it in my app.

Hi @MrStahlfelge . Thanks.
Yes, I agree, there should be no memory leak. Just to be sure.
Hmm... Bad news for me, because I like gdx-pay 👍 Ok. I'll wait before deprecation :D , and then will change to the Googlebilling implementation. ))

I did not suggest not to use gdx-pay, but gdx-pay-android-googlebilling instead of gdx-pay-android-googleplay

Ah, got it. Thanks.

We deprecated googleplay implementation in favor of the googlebilling implementation, so issues for the old implementation will be closed now. Please check if googlebilling works as intended for you.


Add activity diagram for status

Codecov Report

Merging #201 (ebde95d) into master (4fc1bb2) will increase coverage by 2.57%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             master     #201      +/-   ##
============================================
+ Coverage     59.27%   61.84%   +2.57%
- Complexity      616      639      +23
============================================
  Files           112      112
  Lines          2394     2380      -14
  Branches        277      278       +1
============================================
+ Hits           1419     1472      +53
+ Misses          903      842      -61
+ Partials         72       66       -6

see 12 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Transparent gifs

First of all thank you for this nice package!
I was trying to export an animation as a gif with a transparent background. Unfortunately, this was not possible using imageio (at least based on my googeling). There is a solution using PIL (see below).
However, this requires implementing a custom save function. Would you be interested in adding alternative support for PIL to save gifs to allow this solution natively? I would be willing to implement this properly. If not, I hope this issue serves as potential information for others who ran into the same issue I did.
import drawSvg as draw
from PIL import Image
from drawSvg import Drawing, render_svg_frames

def convert_to_transparent_frame(im):
    """Modified from https://stackoverflow.com/questions/46850318/transparent-background-in-gif-using-python-imageio"""
    alpha = im.getchannel("A")

    # Convert the image into P mode but only use 255 colors in the palette out of 256
    im = im.convert("RGB").convert("P", palette=Image.ADAPTIVE, colors=255)

    # Mark all pixels with alpha=0 as transparent
    mask = Image.eval(alpha, lambda a: 255 if a == 0 else 0)

    # Paste the color of index 255 and use alpha as a mask
    im.paste(255, mask)

    # The transparency index is 255
    im.info["transparency"] = 255

    return im

def save_video(frames, file, **kwargs):
    """
    Save a series of drawings as a GIF or video.

    Arguments:
        frames: A list of `Drawing`s or a list of `numpy.array`s.
        file: File name or file like object to write the video to.  The
            extension determines the output format.
        align_bottom: If frames are different sizes, align the bottoms of each
            frame in the video.
        align_right: If frames are different sizes, align the right edge of each
            frame in the video.
        bg: If frames are different sizes, fill the background with this color.
            (default is white: (255, 255, 255, 255))
        duration: If writing a GIF, sets the duration of each frame.
        fps: If writing a video, sets the frame rate in FPS.
        **kwargs: Other arguments to imageio.mimsave().

    """
    if isinstance(frames[0], Drawing):
        frames = render_svg_frames(frames, **kwargs)
    kwargs.pop("align_bottom", None)
    kwargs.pop("align_right", None)
    kwargs.pop("bg", None)
    frames = [
        convert_to_transparent_frame(Image.fromarray(frame, "RGBA")) for frame in frames
    ]
    frames[0].save(
        file,
        save_all=True,
        append_images=frames[1:],
        disposal=2,  # This "cleans" the canvas after every draw
        optimize=False,  # This is critical for transparent background
        **kwargs,
    )

# Draw a frame of the animation
def draw_frame(t):
    d = draw.Drawing(2, 6.05, origin=(-1, -1.05))
    d.setRenderSize(h=300)
    # d.append(draw.Rectangle(-2, -2, 4, 8, fill="white")) # Commented out, as we want to have transparent background
    d.append(draw.Rectangle(-1, -1.05, 2, 0.05, fill="brown"))
    t = (t + 1) % 2 - 1
    y = 4 - t ** 2 * 4
    d.append(draw.Circle(0, y, 1, fill="lime"))
    return d

with draw.animate_video(None, draw_frame) as anim:
    # Add each frame to the animation
    for i in range(20):
        anim.draw_frame(i / 10)
    for i in range(20):
        anim.draw_frame(i / 10)
    for i in range(20):
        anim.draw_frame(i / 10)

    save_video(anim.frames, "test.gif", duration=0.05)

This looks great.  I think it would be a nice addition to drawSvg.
My suggestion would be to make code like this work:
with draw.animate_video('example6.gif', draw_frame, duration=0.05,
                        gif_transparency=True, gif_alpha_threshold=128
                       ) as anim:
    # Add each frame to the animation
    ...

Or maybe a separate function like with draw.animate_gif('test.gif', duration=0.05, alpha_threshold=0) as anim:.
Let me know if you have questions implementing this or making a pull request.

Sry for the silence. Unfortunately, live came in the way of the project I was using this for. At the moment, I don't know when I will have time to look into this again.

No problem.  Your code example should be a good starting point if anyone else wants to contribute.


Squire on iOS without an iFrame does not seem to remember selection

Steps to reproduce:

Create Squire without an iFrame
Write some input into the contenteditable, and then select it with your touchscreen
Click some sort of button outside of the contenteditable to "bold" it.

Focus is lost on the contenteditable or something to that effect -- the bold tag ends up inserted beside it.

I've pushed a change that I think should fix this. If it doesn't please reopen the issue.

using changeset f7774c8 (Always save selection on blur),
This problem seems to still be occuring.
Noticed in the attached screenshot, when the user selects a word, the IOS content-editible menu shows up.  If you then click the Bold link in the demo menu (not the IOS pop up menu), it first loses focus and loses the selection.  As a result, the word is not bolded, the bold is applied at the end of the word (at the cursor).

Can confirm; not fixed. You have to go back TWO selections to get this to work.

OK, that fixes it. :)


Testing Feedback - Staging

Feedback after testing the changes introduced for #72 and #73

Grants content alignment on Grants details page

Page not rendering correctly when navigating to https://staging.casperecosystem.io/grants/gbm_auctions/. Refer https://www.awesomescreenshot.com/video/18382630?key=e6c11c5a79bda764da6c55c2dcda9a6a

Error in the console when trying to test the screen's responsiveness (e.g. mobile version)

Feedback incorporated


Timestamp in StructuredFormatter is stripped from millisecond precision

Due to a refactoring back in April of org.jboss.logmanager.ext.formatters.StructuredFormatter the default timestamp format was set to "yyyy-MM-dd'T'HH:mm:ssXXX" which should be "yyyy-MM-dd'T'HH:mm:ssSSSXXX" or "yyyy-MM-dd'T'HH:mm:ssSSSZ" to keep millisecond precision. Otherwise the order of logs are useless when sent to an ELK stack or similar.

Realized that the pattern can be configured as a property in configuration file

Realized that the pattern can be configured as a property in configuration file

Can you show an example please? Stuck with the same thing

Realized that the pattern can be configured as a property in configuration file

@jasmdk
Can you show an example please? Stuck with the same thing
I have this in my CLI-file:
/subsystem=logging/json-formatter=LOGSTASH_FORMATTER:add(date-format="yyyy-MM-dd'T'HH:mm:ss.SSSZ")


Add support for Celery

Hi @yurishkuro,
I believe that it would be great to have support for Celery in the upstream of opentracing_instrumentation.
Celery's PyPI Stats:
https://pypistats.org/packages/celery
Hello @auvipy and @thedrow,
I suppose this PR might be interesting for you.
Cheers!

Coverage increased (+0.9%) to 79.585% when pulling e35eeb51e99d47524a9a93cfb9741728900e1247 on Jamim:feature/celery-upstream into b49ea9397e3a97fb849d3c8559f39ff835f4b6ff on uber-common:master.

Since it's a uber project, and uber use celery to great extent, I would expect Uber funding celery' development.


Fix bug for plotting var when use_raw=False

#762

Thanks for the PR! Could you add a test too?

@coh-racng, I've merged your fix in #790 with a test added. Thanks!