Part 1 of update to state model

lgtm

[Current coverage][cc-pull] is 38.60%

No coverage report found for master at efd18d7.

Powered by Codecov. Last updated by [efd18d7...4f10439][cc-compare]
[cc-base-branch]: https://codecov.io/gh/linkedin/pinot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/linkedin/pinot/compare/efd18d75808a96c05a807fa3fc6dfbd03cc6be35...4f104393bb809541032b9bd2d3732d197096f8dd
[cc-pull]: https://codecov.io/gh/linkedin/pinot/pull/208?src=pr


Test bash linter

testing linter
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing done


dnstwist Docker image outdated

While the Docker image was recently pushed close to the latest release timestamp, it seems it contains an older version:
$ docker pull elceef/dnstwist
Using default tag: latest
latest: Pulling from elceef/dnstwist
Digest: sha256:473682edb24c5e969c7d35ed86706ae12397d240992bb480d0f95c49b12b00a9
Status: Image is up to date for elceef/dnstwist:latest
docker.io/elceef/dnstwist:latest

$ docker run elceef/dnstwist -h | head -n1
dnstwist 20220120 by<EMAIL_ADDRESS>
Would it be possible to get the latest release in the Docker container?
Many thanks in advance!

This should be fixed now:
Unable to find image 'elceef/dnstwist:latest' locally
latest: Pulling from elceef/dnstwist
Digest: sha256:b00c34481bad01905619efd1f2c3709c001d230042b20972124af91abf6b71c0
Status: Downloaded newer image for elceef/dnstwist:latest
dnstwist 20220815 by<EMAIL_ADDRESS>

Many thanks, I can confirm!
It seems the phash feature is not supported inside the container, since
apt-get install python3-pil python3-selenium chromium-driver --no-install-recommends

are not installed. Is this on purpose to make the container more lightweight?
If so, I'll consider adding another layer on top for my usecase.

Yes, I wanted to keep the image as light as possible. I'm going to add dnstwist:phash tag.

Many thanks in advance, that will be very much appreciated!


pip missing from visit python install

Describe the bug
In a visit install, the pip module is there, but the front end is not
It should be copied like we copy python.

@brugger1 working on this, doing a test install now
(note: it's the visit repackaging of python that needs tweaks, not the python install itself -- so if you want to rebuild TPLs, this isn't a blocker)

Was looking at it as well. Sounds like you're slightly ahead of me. I'll let you get it.

resolved on 3.2RC in #17243  and on develop in #17255


Universal built-in file/directory picker

Need to prepare qt-based file/dir picker - right now it's only available on android and uses android framework to choose file/dir to load/save.
Caused by #2 #1

Prepared some test logic based on the default Qt FileDialog - but it looks very bad. Seems need to build h3ds own interface to navigate both desktop/mobile filesystems easily with mouse/touch support.


Flag for permissions

It would come in handy if we could make a region give temp permission access while in a region. The same goes for negating permissions. E.g. permission to use a command in a specific region or disabling anticheat checks on player in region. Could a useful feature like this be added? Love the plugin keep up the great work!

Closing this as this can solved by using LuckPerms & ExtraContexts addon. I have always been strongly suggesting to use LuckPerms and I don't intend to support other permission plugins.


List zoteroRoam in Zotero's plug-in page

Hey,
Great work, I use this a lot, and it's super helpful.
Have you considered listing it in Zotero's plug-in page?
Obsidian and Logseq are already there.

I've been linked to that page before, but it didn't explain how to add to the list so I eventually forgot about it 😄
Took a look again, and I still couldn't figure it out. I don't mind submitting an entry, just wish there was a how-to somewhere! Let me know if you have more insight about this, it would be nice to have the extension added there but I don't care overmuch.

Cool. There's a 'Edit this page' link in the right section. It requires creating an account as a wiki editor.

Thanks! I'll take a look at that then.

Indeed it doesn't display for me so I was searching in vain:

I'll look into wiki editing settings!


No batch mark fuzzy/needs work in 2.0.1

In the older versions I was able to mark several strings and mark them all as fuzzy (Needs work).
In the new version it don't seem to be possible any more.

Of course it is possible, in the same way it always was, from the Edit menu.
You shouldn't do it, though, there's a reason why Poedit tells you to review them individually.

Please also comment on other issues if you have nothing constructive to say. Please don't create issues unless you are 100% sure it's a bug.
If you are a Pro customer, please use<EMAIL_ADDRESS>


Refactored __export_to_bam function and separated it into its own file

I started doing this because I was wondering about how I could add egg support so I thought I'd poke around the bam expoerter, but the function was hard for me to read and understand, so I broke it down until it made sense to me and maybe it might be easier for other people too. It still exports the model primitives and the collision primitives as well as basic_geom. I'm not sure about every material, because I don't quite know how to test those... yet, but I know at least 1 or 2 of the conditions there works. So, let me know what you think.

Extending the export functionality is certainly a good idea, and I agree with splitting off the main code into a subpackage.
While there are some issues, your current refactoring does make things more readable, so I'm grateful that you want to do this!
A couple of problems I encountered when testing out your changes:

directory in __create_texture_filenames should be self.directory;
__process_basic_geom doesn't seem to be implemented yet, so it's currently not possible to export BasicGeom objects that are part of a Collision Group.

Then there are some methods I'd like to see changed, if you don't mind:

rename __check_model_geom_type(self, coll_solid, scale) to __create_collision_solid(self, scale), with the initialization of coll_solid to None in that method instead of in __create_collision_node;
rename __create_*_collision_geom to __create_*_collision_solid;
rename __*_processing to __process_*s (also more consistent with __process_basic_geom);
rename __check_box_normals(self, dimensions_sizes, center) to __create_inverted_box_planes(self, dimensions, center) and instead of coll_solid, make it return True (when CollisionPlanes were created) or False, in which case the CollisionBox should be created in __create_box_collision_solid.

Also, if you don't mind, in terms of code formatting - specifically blank space - I'd like to see:

one blank line between class/method header and body;
two blank lines between module-level classes/functions.

Sorry if this seems like nitpicking, but it would just make the formatting more consistent with the rest of my project. Thanks!
Regarding the .egg format, that's actually how I started my implementation of model export. The reason I gave up on it was that export to .bam was a lot easier, but also because the data in the .bam file is pretty much an exact copy of the internal Panda structures used to represent the model. There are things like multitexturing that I wouldn't even know how to put into an .egg file. The only reason I see to even use an .egg file is that it can easily be edited, but using this project of mine should make that unnecessary.
If you really want to add export to .egg functionality I won't stop you, but then I expect you to take full responsibility of its implementation, as I'm personally not really interested in it. And don't forget there's bam2egg... ;) .
What I would like to see is export to additional 3D file formats, so use of my project wouldn't be limited to Panda3D users. There's already support for .obj, but it hasn't been properly maintained. In particular, exporting groups isn't possible yet. If you could help with that, I would appreciate that tremendously, but if you don't feel like it, that's OK too.
In any case, I'd like to do some more thorough testing of your work in progress, but as I'm currently working on a side project, it might take a while before I can get to it.

Actually, I was thinking about doing this for the __export_to_obj function, but I wanted to see what you thought of what I did so far before I started that. As for adding support for groups, I'm not sure what that even is unfortunately, so I'm not sure if I can be much help there. Is that like when you parent an object to another?

In my project there are two ways to attach objects: "linking" and grouping. Under the hood, both of these are indeed implemented using the exact same Panda parenting system.
If you want to build a hierarchy of objects, you'll likely want to link child objects to parent objects.
If you want to treat multiple objects as a whole, a monolithic unit, then grouping them all together is an easy way to do that. But groups have an additional purpose: they affect how their member objects will be exported. The member type of the group determines how exactly this will happen. You already know about collision-type groups, but also the model-type group makes its members export in a very special way: they will become Geoms that are all added to the same GeomNode. (If you don't want this to happen, just leave the member type to its default, "Any".) For example if you want to create a sword, you first model the blade and the hilt separately, texture them and finally group them so you can further edit them together as just "the sword". When you load the exported .bam file in your own Panda application, you will also get just a single NodePath, making it easy to reparent, transform etc.
As for .obj export of grouped models, that was a nice surprise: it was actually very easy to add, so I already pushed a fix :) .
Thanks for your recent changes, that's starting to look quite good.
There are still a couple of instances where you forgot to prepend a variable with "self.":

line 108: child
line 111: geom_node
line 167: group_pivot

Then there's a little mistake on line 286, which should read:
        if not has_inverted_normals:
or even more readable:
        if not self.__create_inverted_box_planes(dimensions, center):
(as in: "If creation of inverted box planes failed, create a regular box"), then you don't need the has_inverted_normals variable.
Lastly, I encountered a bug where not all members of a collision group were exported as collision solids, but as GeomNode children of the CollisionNode, which doesn't appear to be happening in my own code.
It's not trivial to reproduce, so I'll need to do more in-depth checking of what's going wrong, but I haven't got time for it right now.

Oh dear. That's a bit odd about the collision solids. So, when you say there are cases when not all members of a collision group were exported correctly is that when you have multiple primitives parented to one group and then turned into collision solids, but instead of all of them being exported as collision solids, sometimes they turn out as a plain model would? Even though I have nothing but time right now, I'm not sure what's even going on with that. Well, whenever you get to it I'll be here, at least for the next few months.

So, when you say there are cases when not all members of a collision group were exported correctly is that when you have multiple primitives parented to one group and then turned into collision solids, but instead of all of them being exported as collision solids, sometimes they turn out as a plain model would?

That does seem to be the case. Although it might be related to the fact that the last model added to the group was not a primitive, but a BasicGeom (it's also the selected object when exporting, although that shouldn't matter). Not sure though.
Attached is a saved scene file that contains a hierarchy with a collision group. Whenever I export it using your fork, the result is like the .bam file that is also in the attached archive.
To verify, open the scene file, don't (de)select anything but immediately do an export; perhaps you can add some print calls to your export code at various points in the export process to check how the hierarchy attached to self.root is being built up.
export_test.zip

I think that specific problem was due to the fact that I was reassigning self.collision_node in the __check_if_basic_geom method, even though neither of the process methods returned anything. I think I also found another bug involving planes and being exported in the wrong position, but I can't quite remember how I did it because I was trying to recreate what you were talking about.

One thing to note is that depending on the order the objects are selected in results in a differing amount of collision solids. When basic_geom is the first member this is debug info I got when I exported a cube basic_geom, a sphere primitive, and a cylinder primitive:
child loop, self.collision_node: None
child loop, self.child: <src.core.helpers.group.Group object at 0x7f5f6feca128>
child loop, self.collision_node: CollisionNode group 0001 (0 solids) T:(pos -0.319807 1.11375 2.95661) (hidden)
child loop, self.child: <src.core.geom.model.Model object at 0x7f5f6fec3128>
how many times?
self.collision_node: CollisionNode group 0001 (0 solids) T:(pos -0.319807 1.11375 2.95661) (hidden)
should be three times
child loop, self.collision_node: CollisionNode group 0001 (12 solids) T:(pos -0.319807 1.11375 2.95661) (hidden)
child loop, self.child: <src.core.geom.model.Model object at 0x7f5f6fec3ac8>
how many times?
self.collision_node: CollisionNode group 0001 (12 solids) T:(pos -0.319807 1.11375 2.95661) (hidden)
should be three times
child loop, self.collision_node: CollisionNode group 0001 (13 solids) T:(pos -0.319807 1.11375 2.95661) (hidden)
child loop, self.child: <src.core.geom.model.Model object at 0x7f5f85f86b38>
how many times?
self.collision_node: CollisionNode group 0001 (13 solids) T:(pos -0.319807 1.11375 2.95661) (hidden)
should be three times

Here's the debug information I got when I selected one of the primitives first:
child loop, self.collision_node: None
child loop, self.child: <src.core.helpers.group.Group object at 0x7f45bc116080>
child loop, self.collision_node: CollisionNode group 0001 (0 solids) T:(pos -1.09291 1.08048 2.3484) (hidden)
child loop, self.child: <src.core.geom.model.Model object at 0x7f4594148390>
how many times?
self.collision_node: CollisionNode group 0001 (0 solids) T:(pos -1.09291 1.08048 2.3484) (hidden)
should be three times
child loop, self.collision_node: CollisionNode group 0001 (1 solids) T:(pos -1.09291 1.08048 2.3484) (hidden)
child loop, self.child: <src.core.geom.model.Model object at 0x7f459414d320>
how many times?
self.collision_node: CollisionNode group 0001 (1 solids) T:(pos -1.09291 1.08048 2.3484) (hidden)
should be three times
child loop, self.collision_node: CollisionNode group 0001 (2 solids) T:(pos -1.09291 1.08048 2.3484) (hidden)
child loop, self.child: <src.core.geom.model.Model object at 0x7f459413af60>
how many times?
self.collision_node: CollisionNode group 0001 (2 solids) T:(pos -1.09291 1.08048 2.3484) (hidden)
should be three times

Let me know if there's anything else I need to fix!

Thanks for looking into this! It does seem to work now.
When I have more time I'll do some additional testing myself.

Finally I had time to look into this further and everything seems to work fine, so I'm going to merge this now.
Thanks!
Nevertheless, there are still some structural changes I'd like to make as well as rename some methods and variables, but rather than annoy you with those details I will just do this additional refactoring myself after the merge; hope you don't mind.
You have also inspired me to implement an ObjExporter class, similar to your ExportBam class, so export to .obj should then also be coded in a more readable way.


backref from colima

on the wiki page describing colima install add a backlink so users can navigate to the next step spot on the Computer Setup page.

I removed the stand-alone colima page as the wiki interface gives pages root level location in the content hierarchy, which looks weird.
I put the colima installation instructions nested (using ) in the macOS section and nested Docker Desktop for Mac installation instructions at the same level using


I read a file, save the fIle, background colors are lost,and some other style lost

var workbook=XLSX.readfile('aa.xlsx',{cellStyles:true});
XLSX.writeFile(workbook,'aaaa.xlsx')

why??
no suport?

before:

after：

protobi/js-xlsx  support write style to cell

@shikelong can you give a demo js for useing how to use the test-style.js for setting style? I am new one for sheetJS

To answer the original question, there is no support for writing styles. Just reading.

protobi/js-xlsx support write style to cell

@pumpkindev could you explain how to use protobi/js-xlsx correctly?
I has installed both xlsx and xlsx-style npm packages, but style is not applyed.


django_gunicorn deprecated

Gunicorn no longer works with the django_gunicorn script.
I have solved the issue by moving /evewspace/evewspace/apache/wsgi.py to /evewspace/ and using this config for supervisor:
command=/home/mapper/eve-wspace/bin/gunicorn wsgi --workers=4 -b <IP_ADDRESS>:8000
directory=/home/mapper/eve-wspace/evewspace

Don't forget to reload your configs.

Another alternative is using uwsgi, which is supposed to be slightly faster. See #194.

Great fix, this helped us a lot thanks.


fifo backup should be changed to sqlite for multi-container use

DriftQueue backup files are currently in feather format, and having multiple container instances up serving same client could cause trouble with metrics


Fix bug where vscode extensions are not installing

Fixes | Closes | Resolves #1350
Changes introduced in this PR:

This PR switched back the installation for the code-server backend to how it was previously provided before we moved to the conda-forge code-server feedstock.
Due to an issue with the docker build for the new image, which seems to be node related, I needed to bump the installation for the dask-labextension to the latest version as well

This includes the fixes proposed for #1327 and adds a new re-branding for dask
The extensions for VScode as well its main config are now presented in /home/<user>/.local/shared/code-server dir

Types of changes
What types of changes does your PR introduce?
Put an x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing
Requires testing

[x] Yes
[ ] No

In case you checked yes, did you write tests?

[ ] Yes
[x] No
[ ]

Further comments (optional)
This should count as a quick fix for the current extension installation issue of VScode, but we need to revisit this after the current sprint.

The previous extension mechanism is preserved

Also, the extension addition mechanism is now working:

from the Terminal:
test-user@jupyter-test-2duser:~/.local/share/code-server$ ls
CachedExtensionVSIXs  CachedExtensions  Machine  User  coder-logs  coder.json  heartbeat  logs  machineid
test-user@jupyter-test-2duser:~/.local/share/code-server$

I just need to test the dask-labextension to make sure it dint break anything

Dask-labextension is now fixed:

It seems that fixing the extensions broke the terminal sync with the Jupyterlab terminal (we now get a blank terminal on vscode), trying to fix that.

It seems that fixing the extensions broke the terminal sync with the Jupyterlab terminal (we now get a blank terminal on vscode), trying to fix that.

These components don't seem related not sure why this would be happening.

It seems that fixing the extensions broke the terminal sync with the Jupyterlab terminal (we now get a blank terminal on vscode), trying to fix that.

These components don't seem related not sure why this would be happening.

seems to be a node thing, the terminal is in there but it's not rendered correctly -- I am trying to change the /bin path to point directly to the code-server + node installation (as we have on quansight-beta), I also update the order of calling the code-server prosy to use the conda env (I think it was being installed in the pip env of the docker image and not the default)
this is the error, for ref.:
[2022-07-06 12:40:58.929] [window] [error] [object Event]: Error: [object Event]
    at Object.E [as ensureError] (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:4182)
    at i._createLoadError (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:8131)
    at i._onLoadError (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:8250)
    at f (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:10089)
    at Object.errorback (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:10445)
    at e.triggerErrorback (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:11144)
    at https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:10850
    at HTMLScriptElement.f (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:11365)


TESTCOV: Sputnik Factory: Ownership

Draft PR for Sputnik Factory Ownership test coverage #121
Tests will be written in Rust in a test module inside a respected file (lib.rs).
Recommendations are very welcome.

We are not compleatly sure that solution for [owner_can_be_a_dao_account] is correct.

Changed as required @TrevorJTClarke


[ServiceBus][DoNotMerge] Message.Clone should create a new independent copy of UserProperties dictionary

Ensuring Message.Clone() creates a new dictionary for UserProperties (though contains the original entries).
Fixes #7690

This is a breaking change, hence, will merge whenever the next major version is planned to release. Note - There is no tentative date for it however.

@nemakam:  Is this PR still active, or should we close this out as stale?

@jsquire , Its one of the good-to-have but not necessary to have changes. But it changes the behavior, so we will have to wait for next version. Whenever that happens, we could merge this before releasing the breaking version. I'm okay waiting for it for several months before we'll have to release this one as a breaking change. Does this sound okay to you?

@nemakam:  Works for me!

@jsquire Is this change in the new version? If so, can we close this out?

@Petermarcu:  The track two library has this functionality.  This PR is a change to the track one library.   When I last spoke to the Service Bus team, they would like to include it in their next major version, as it is a breaking change.  They requested to leave the PR unmerged until they were closer to that release, as they're actively using the master branch for work to be included on minor releases.
@shankarsama: Would you mind offering your thoughts?

/check-enforcer reset

Closing, as Neeraj is no longer working on the product.


Delete zero byte file diff-11-20.txt from root

Looks like this was introduced in 2018 during initial import?
Doesn't appear useful, and should be deleted.

@drewbatgit Looks like you accidentally committed this file? Can I get a sign off?


Correct typo in week4/day4.ipynb

Change function from stream_code_quen to stream_code_qwen

Wow how did I not catch that?! Thank you so much!


make nav arrows configurable

fixes #112
This PR was originally #154 , but I ended up making a mess of git (multiple reorders + squashing after reorder is hard :disappointed: ). So go look there for comments. However here is the original PR message:
This PR adds in the ability to specify navPrev, and navNext to DayPicker incase they want to override the default SVGs that come bundled with react-dates (e.g. ChevronUp, ChevronDown, LeftArrow, and RightArrow).
If navPrev, or navNext aren't specified then DayPicker will fall back to the current behavior of:
isVertical ? <ChevronUp /> : <LeftArrow />;

for the previous button, and:
isVertical ? <ChevronDown /> : <RightArrow />;

for the next button.
I also tried to make this work as much with existing code as possible. As such even with custom icons the class names: DayPicker__nav--prev, and DayPicker__nav--next are still rendered even with custom icons. If you really want to target something inside of your custom icon, you can always tag class names/ids onto the props you pass in. E.g.:
<DayPicker
  navPrev={
    <span className={'MySuperAwesomeIcon'}>
       'Prev'
    </span>
  }
/>

@majapw Here's the new PR sorry about the mess I made with #154 :disappointed:

:bowing_man: Sounds awesome! Thanks for providing such quick reviews!

Coverage increased (+0.4%) to 88.726% when pulling 135f61e750a720e78faa8bc54b709613eec53f06 on SecurityInsanity:c_navigation into 213f26852d1ae7d82b276b6e761c3e31dd4ad1d5 on airbnb:master.

Coverage increased (+0.4%) to 88.726% when pulling 135f61e750a720e78faa8bc54b709613eec53f06 on SecurityInsanity:c_navigation into 213f26852d1ae7d82b276b6e761c3e31dd4ad1d5 on airbnb:master.


Guide on progress bar

Via iterators
Via Jobs
Improve performances (check what I did in Moose mse import export)


Ability to prune comments so that massive comment sections don't take hours to download

I'd like to download all of my saved posts w/ comments, but some of them have absurd numbers of comments (as we're speaking, one of them is up to 50,000.) This adds a huge amount of time to the download.
this would be cool:
An ability to only save the top n comments (by likes)
An ability to only consider the first n comments (in intervals of 250, how they are packaged from instagram)
a note:
I have not tried using the API to do this myself, and I'm pretty sure I could get it to work there, but it isn't so important to be that I'd need to do that.
If the feature request is accepted, would you be willing to submit a pull request?
Yes

This does not seem to fit into Instaloader itself, as it can be easily done with a script that uses Instaloader as a module.


Added approval time check on assignments

I added an extra check to see if 'original_approved_date' item is present on assignments when checking for the Approval date.
This is the fix we came up with to solve the issue of edited/extended assignments which approval time is wrong since we take into account the edge [proposal] -> [assigned] -> [member] creation date which gets updated whenever there is a modification on the assignment.
The approved date content item gets added when ANY proposal is closed & approved.
I also added code to prevent edit & extend proposals from overriding the original assignment data i.e. title & description as well as other content groups (SYSTEM, BALLOT & BALLOT_OPTIONS).

This PR's depends on this other PR [hypha-dao/document-graph] Pull request opened: #27 Added skippable groups on documents merge process
to be merged on document-graph project


README section on testing seems to indicate wrong Ruby version

According to the README section on running the tests:

To test DeviseInvitable for the ActiveRecord ORM with RVM, Ruby 2.0.0:
rvm use 2.0.0
...
rake test DEVISE_ORM=active_record

However, "activesupport requires Ruby version >= 2.2.2":
~/Projects/devise_invitable (master) : bundle install
Fetching gem metadata from https://rubygems.org/............
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Resolving dependencies...
Using rake 11.3.0
Using concurrent-ruby 1.0.2
Using i18n 0.7.0
Using minitest 5.9.1
Using thread_safe 0.3.5
Using tzinfo 1.2.2

Gem::InstallError: activesupport requires Ruby version >= 2.2.2.
An error occurred while installing activesupport (<IP_ADDRESS>), and Bundler cannot continue.
Make sure that `gem install activesupport -v '<IP_ADDRESS>'` succeeds before bundling.

Also, I think the last command is missing bundle exec and should be:

bundle exec rake test DEVISE_ORM=active_record

devise invitable works with ruby >= 2.0 and devise >= 4.0, however devise requires ruby >= 2.1
Devise supports rails 4.1, 4.2 and 5.0. If you use rails 4.x you can use ruby 2.1, but if you use 5.0 you must use >= 2.2.2
I'm chaning README for ruby 2.2.2 because it's not possible to test with 2.0 (devise needs 2.1) and lastest rails may be installed, which requires 2.2.2


Push scylla-bench docker image using gocql version from the PR (TEST PR)

was it closed on purpose?

it was just to test if it is possible to use repo credentials from a repo branch


Make the Landing Page prettier

Precondition before #4

The Landing page is now (just a little bit) better

Closing issue


🍒 Cherry pick PR #20677 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/20677 to staging 🍒

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


reuse the canonical kubernetes icons in the Resources view

the resources view is great. I wonder if we could add the canonical kubernetes icons to each rectangle so its more clear visually at a glance what node thing is?

Older versions of Octant had those icons in the navigation. One of the reasons they were removed was because it was not clear they were meaningful at a glance. (or maybe it takes time to adjust to the icons)
The storybook (npm run storybook) has a sample of what an improved resource viewer might look like.


Authorization Code Flow Refresh Token not working together with Keycloak due to missing at_hash

This is not a bug report, it is just for information.
We discovered that angular-oauth2-oidc library is failing to use the refresh token in the authorization code flow if Keycloak is used as an IDP due to https://issues.redhat.com/browse/KEYCLOAK-15437.
As a workaround you can either omit openid scope (i.e. you will be using plain OAuth2) or set disableAtHashCheck to true.
Unfortunately chances are bad that Keycloak guys will fix the bug, so if anyone is familiar with Keycloak implementation I would be happy if he or she could contribute a fix for this issue to Keycloak.

Thx for sharing! Sorry to hear you had to jump for hoops. Hopefully your issue and Google/Bing/etc will help others find it easily!


Add ACE

Insert URLs to the project here: https://github.com/ai2cm/ace

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All projects listed will be posted on our Mastodon channel

@oliverwm1 @mcgibbon


HomeBrew-Package creates a .gitconfig file and thus breaks devcontainer copy of this file.

The homebrew-package feature which is used by a number of features in this repo adds a git safe directory (The following line can be seen in https://github.com/devcontainers-contrib/features/blob/main/src/homebrew-package/install.sh#L65
git config --global --add safe.directory "$(brew --prefix)/Homebrew/Library/Taps/homebrew/homebrew-core"

This means that when the devcontainer features finish installing the .gitconfig file is left. This then means that the host .gitconfig does not get copied into the devcontainer as it already exists - and thus breaking everyone's gitconfig.
You should change this to use the System config (.git/config) and not the users config (.gitconfig). See here for reference: - https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

Here is another example of the issue: - https://github.com/microsoft/vscode-remote-release/issues/7589

@ross-p-smith thanks for finding this bug! I have changed to --system config as you suggested.
(If this will not help ill simply delete the created .gitconfig  at the end of the installation)

Retested - all works perfectly - many thanks!


There are two Abbotsford "cities" that show up in the autocomplete results

Describe the Bug
There are two Abbotsford "cities" that show up in the autocomplete results
** Steps To Reproduce**
Steps to reproduce the behaviour:

Go to https://organicsinfo.gov.bc.ca/map
Type "abbotsford" in the search bar
See error

Expected Behaviour
Only one shows up
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] Windows 10 Enterprise
Browser [e.g. chrome, safari] Edge baby
Version [e.g. 22]  <IP_ADDRESS>

Explored this and we think this is a UI bug:

We include more than just "cities": https://github.com/bcgov/nr-epd-organics-info/wiki/Map-Search-Autocomplete#places
Original list: https://github.com/bcgov/nr-epd-organics-info/blob/main/frontend/scripts/places.csv
Processed list: https://github.com/bcgov/nr-epd-organics-info/blob/main/frontend/public/places.json

From convo with @mishraomp Potential 2 part approach:
1 - update places.js script to include place type (e.g., community, city, etc...) in the json: https://github.com/bcgov/nr-epd-organics-info/blob/main/frontend/public/places.json
2 - update the autocomplete behaviour (perhaps in https://github.com/bcgov/nr-epd-organics-info/blob/main/frontend/src/pages/map/search/AutocompleteItem.tsx)


make: *** No rule to make target 'argon2/src/argon2.c'

Encountered this when compiling the module:
$ mix compile
make: *** No rule to make target 'argon2/src/argon2.c', needed by '/tmp/argon2_elixir/_build/dev/lib/argon2_elixir/priv/argon2_nif.so'.  Stop.
** (Mix) Could not compile with "make" (exit status: 2).
You need to have gcc and make installed. If you are using
Ubuntu or any other Debian-based system, install the packages
"build-essential". Also install "erlang-dev" package if not
included in your Erlang/OTP version. If you're on Fedora, run
"dnf group install 'Development Tools'".

I've already installed both build-essential and erlang-dev in my Ubuntu. Not sure this is related to asdf as I'm running my Elixir within asdf.

@kianmeng you may need to pull submodule. Can use this command
git submodule update --init --recursive

@laksamanakeris :+1: :tada:


Update the pip recommendations

Recommend at least pip 7 because versions since 1.3 have changed the defaults to better protect end users during install.
Use the new official location for the bootstrap script.

Looks good to me.
Thanks!


Unexpected OOM When Using use_gradient_checkpointing = "unsloth"

Hi! I followed the conda installation and I am using Jupyter notebook in WSL2. System:
32GB RAM
RTX 3090 24GB
Ryzen 5 5600x

No issues with gradient = True.
I installed the latest version from scratch again into a new environment, but the same issue persists.

Error message:
RuntimeError                              Traceback (most recent call last)
Cell In[8], line 1
----> 1 trainer_stats = trainer.train()

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/trl/trainer/sft_trainer.py:361, in SFTTrainer.train(self, *args, **kwargs)
    358 if self.neftune_noise_alpha is not None and not self._trainer_supports_neftune:
    359     self.model = self._trl_activate_neftune(self.model)
--> 361 output = super().train(*args, **kwargs)
    363 # After training we make sure to retrieve back the original forward pass method
    364 # for the embedding layer by removing the forward post hook.
    365 if self.neftune_noise_alpha is not None and not self._trainer_supports_neftune:

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/transformers/trainer.py:1780, in Trainer.train(self, resume_from_checkpoint, trial, ignore_keys_for_eval, **kwargs)
   1778         hf_hub_utils.enable_progress_bars()
   1779 else:
-> 1780     return inner_training_loop(
   1781         args=args,
   1782         resume_from_checkpoint=resume_from_checkpoint,
   1783         trial=trial,
   1784         ignore_keys_for_eval=ignore_keys_for_eval,
   1785     )

File <string>:355, in _fast_inner_training_loop(self, batch_size, args, resume_from_checkpoint, trial, ignore_keys_for_eval)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/transformers/trainer.py:3036, in Trainer.training_step(self, model, inputs)
   3033     return loss_mb.reduce_mean().detach().to(self.args.device)
   3035 with self.compute_loss_context_manager():
-> 3036     loss = self.compute_loss(model, inputs)
   3038 if self.args.n_gpu > 1:
   3039     loss = loss.mean()  # mean() to average on multi-gpu parallel training

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/transformers/trainer.py:3059, in Trainer.compute_loss(self, model, inputs, return_outputs)
   3057 else:
   3058     labels = None
-> 3059 outputs = model(**inputs)
   3060 # Save past state if it exists
   3061 # TODO: this needs to be fixed and made cleaner later.
   3062 if self.args.past_index >= 0:

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/nn/modules/module.py:1511, in Module._wrapped_call_impl(self, *args, **kwargs)
   1509     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1510 else:
-> 1511     return self._call_impl(*args, **kwargs)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/nn/modules/module.py:1520, in Module._call_impl(self, *args, **kwargs)
   1515 # If we don't have any hooks, we want to skip the rest of the logic in
   1516 # this function, and just call forward.
   1517 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1518         or _global_backward_pre_hooks or _global_backward_hooks
   1519         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1520     return forward_call(*args, **kwargs)
   1522 try:
   1523     result = None

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/accelerate/utils/operations.py:825, in convert_outputs_to_fp32.<locals>.forward(*args, **kwargs)
    824 def forward(*args, **kwargs):
--> 825     return model_forward(*args, **kwargs)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/accelerate/utils/operations.py:813, in ConvertOutputsToFp32.__call__(self, *args, **kwargs)
    812 def __call__(self, *args, **kwargs):
--> 813     return convert_to_fp32(self.model_forward(*args, **kwargs))

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/amp/autocast_mode.py:16, in autocast_decorator.<locals>.decorate_autocast(*args, **kwargs)
     13 @functools.wraps(func)
     14 def decorate_autocast(*args, **kwargs):
     15     with autocast_instance:
---> 16         return func(*args, **kwargs)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/models/llama.py:882, in PeftModelForCausalLM_fast_forward(self, input_ids, causal_mask, attention_mask, inputs_embeds, labels, output_attentions, output_hidden_states, return_dict, task_ids, **kwargs)
    869 def PeftModelForCausalLM_fast_forward(
    870     self,
    871     input_ids=None,
   (...)
    880     **kwargs,
    881 ):
--> 882     return self.base_model(
    883         input_ids=input_ids,
    884         causal_mask=causal_mask,
    885         attention_mask=attention_mask,
    886         inputs_embeds=inputs_embeds,
    887         labels=labels,
    888         output_attentions=output_attentions,
    889         output_hidden_states=output_hidden_states,
    890         return_dict=return_dict,
    891         **kwargs,
    892     )

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/nn/modules/module.py:1511, in Module._wrapped_call_impl(self, *args, **kwargs)
   1509     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1510 else:
-> 1511     return self._call_impl(*args, **kwargs)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/nn/modules/module.py:1520, in Module._call_impl(self, *args, **kwargs)
   1515 # If we don't have any hooks, we want to skip the rest of the logic in
   1516 # this function, and just call forward.
   1517 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1518         or _global_backward_pre_hooks or _global_backward_hooks
   1519         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1520     return forward_call(*args, **kwargs)
   1522 try:
   1523     result = None

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/peft/tuners/tuners_utils.py:161, in BaseTuner.forward(self, *args, **kwargs)
    160 def forward(self, *args: Any, **kwargs: Any):
--> 161     return self.model.forward(*args, **kwargs)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/accelerate/hooks.py:166, in add_hook_to_module.<locals>.new_forward(module, *args, **kwargs)
    164         output = module._old_forward(*args, **kwargs)
    165 else:
--> 166     output = module._old_forward(*args, **kwargs)
    167 return module._hf_hook.post_forward(module, output)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/models/mistral.py:213, in MistralForCausalLM_fast_forward(self, input_ids, causal_mask, attention_mask, position_ids, past_key_values, inputs_embeds, labels, use_cache, output_attentions, output_hidden_states, return_dict, *args, **kwargs)
    205     outputs = LlamaModel_fast_forward_inference(
    206         self,
    207         input_ids,
   (...)
    210         attention_mask = attention_mask,
    211     )
    212 else:
--> 213     outputs = self.model(
    214         input_ids=input_ids,
    215         causal_mask=causal_mask,
    216         attention_mask=attention_mask,
    217         position_ids=position_ids,
    218         past_key_values=past_key_values,
    219         inputs_embeds=inputs_embeds,
    220         use_cache=use_cache,
    221         output_attentions=output_attentions,
    222         output_hidden_states=output_hidden_states,
    223         return_dict=return_dict,
    224     )
    225 pass
    227 hidden_states = outputs[0]

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/nn/modules/module.py:1511, in Module._wrapped_call_impl(self, *args, **kwargs)
   1509     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1510 else:
-> 1511     return self._call_impl(*args, **kwargs)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/nn/modules/module.py:1520, in Module._call_impl(self, *args, **kwargs)
   1515 # If we don't have any hooks, we want to skip the rest of the logic in
   1516 # this function, and just call forward.
   1517 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1518         or _global_backward_pre_hooks or _global_backward_hooks
   1519         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1520     return forward_call(*args, **kwargs)
   1522 try:
   1523     result = None

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/accelerate/hooks.py:166, in add_hook_to_module.<locals>.new_forward(module, *args, **kwargs)
    164         output = module._old_forward(*args, **kwargs)
    165 else:
--> 166     output = module._old_forward(*args, **kwargs)
    167 return module._hf_hook.post_forward(module, output)

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/models/llama.py:650, in LlamaModel_fast_forward(self, input_ids, causal_mask, attention_mask, position_ids, past_key_values, inputs_embeds, use_cache, output_attentions, output_hidden_states, return_dict, *args, **kwargs)
    647 past_key_value = past_key_values[idx] if past_key_values is not None else None
    649 if offloaded_gradient_checkpointing:
--> 650     hidden_states = Unsloth_Offloaded_Gradient_Checkpointer.apply(
    651         decoder_layer,
    652         hidden_states,
    653         causal_mask,
    654         attention_mask,
    655         position_ids,
    656         past_key_values,
    657         output_attentions,
    658         use_cache,
    659     )
    661 elif gradient_checkpointing:
    662     def create_custom_forward(module):

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/autograd/function.py:553, in Function.apply(cls, *args, **kwargs)
    550 if not torch._C._are_functorch_transforms_active():
    551     # See NOTE: [functorch vjp and autograd interaction]
    552     args = _functorch.utils.unwrap_dead_wrappers(args)
--> 553     return super().apply(*args, **kwargs)  # type: ignore[misc]
    555 if not is_setup_ctx_defined:
    556     raise RuntimeError(
    557         "In order to use an autograd.Function with functorch transforms "
    558         "(vmap, grad, jvp, jacrev, ...), it must override the setup_context "
    559         "staticmethod. For more details, please see "
    560         "https://pytorch.org/docs/master/notes/extending.func.html"
    561     )

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/torch/cuda/amp/autocast_mode.py:115, in custom_fwd.<locals>.decorate_fwd(*args, **kwargs)
    113 if cast_inputs is None:
    114     args[0]._fwd_used_autocast = torch.is_autocast_enabled()
--> 115     return fwd(*args, **kwargs)
    116 else:
    117     autocast_context = torch.is_autocast_enabled()

File ~/anaconda3/envs/unsloth_env/lib/python3.10/site-packages/unsloth/models/_utils.py:331, in Unsloth_Offloaded_Gradient_Checkpointer.forward(ctx, forward_function, hidden_states, *args)
    328 @staticmethod
    329 @torch.cuda.amp.custom_fwd
    330 def forward(ctx, forward_function, hidden_states, *args):
--> 331     saved_hidden_states = hidden_states.to("cpu", non_blocking = True)
    332     with torch.no_grad():
    333         (output,) = forward_function(hidden_states, *args)

RuntimeError: CUDA error: out of memory
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

@ansz42 Sorry on the delay! Interesting so using our new method rather makes it OOM? Weird

@ansz42 Sorry on the delay! Interesting so using our new method rather makes it OOM? Weird

No worries at all! I appreciate your help.
It works well on Colab, but somehow WSL2 + Jupyter notebook causes an OOM. I suspect this might not be an usual OOM though because RAM, shared VRAM and VRAM use get stuck way below the available amount. It doesn't even try going over 24GB before the OOM error. Let me know if you need me to run anything for troubleshooting.

@ansz42 Apologies llama-3 got the better of me! Hmmm WSL ye the shared RAM could be an issue - I'm unsure if WSL randomnly restricts VRAM usage or something

i got the same error
RuntimeError: CUDA error: out of memory
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

i am following the : https://colab.research.google.com/drive/1_yNCks4BTD5zOnjozppphh5GzMFaMKq_?usp=sharing#scrollTo=2ejIt2xSNKKp  colab notebook
current memory stats
GPU = NVIDIA RTX 6000 Ada Generation. Max memory = 47.988 GB.
6.135 GB of memory reserved.```

*parameters *
``` Unsloth - 2x faster free finetuning | Num GPUs = 1
  Num examples = 1,131 | Num Epochs = 1
  Batch size per device = 2 | Gradient Accumulation steps = 2
  Total batch size = 4 | Total steps = 283
  Number of trainable parameters = 167,772,160```

i am using wsl + jupyter notebook in vs code

@noviljohnson load_in_4bit = False?

thanx i ll try
but i resolved by changing the parameter values
per_device_train_batch_size = 2,
gradient_accumulation_steps = 8,
thank you

Running into the same issue.
Training w/ Unsloth (LLaMA-Factory) through WSL succesfully spills over to system RAM with CUDA "Sysmem Fallback Policy" enabled, allowing me to train a 16k context on a 10GB RTX 3080.
After enabling "use_gradient_checkpointing": "unsloth", it will always OOM. I noticed that it would even OOM in weird scenarios where a 2048 context size worked, but 2047 resulted in OOM, when there was enough VRAM available.
Disabling use_gradient_checkpointing works, but I would love to use it.

Hey! I ran into this in WSL2 as well. I posted in the other thread https://github.com/unslothai/unsloth/issues/600#issuecomment-2181298507 but I think this is due to pinned memory in wsl + coda... when you don't use gradient checkpoint unsloth I don't think it pins anything in memory (or anything massive). With 95gb ram for some reason WSL only allowed 210 mb of pinned memory. To turn it off you can just say use_gradient_checkpointing=True (to use I guess the HF one).

@m0nsky OOO interesting so non_blocking = False works?? Hmm maybe I should make a new method called "unsloth-wsl" for WSL people, to use blocking calls. You will get some slowdowns sadly, since now the transfer of activations to system RAM will block with the GPU

@vladrad Oh yes using use_gradient_checkpointing = True uses normal HF

@m0nsky OOO interesting so non_blocking = False works?? Hmm maybe I should make a new method called "unsloth-wsl" for WSL people, to use blocking calls. You will get some slowdowns sadly, since now the transfer of activations to system RAM will block with the GPU

I tried it last night and it seemed to be a lot slower indeed, not sure if it's going to be worth it. :(

I guess using unsloth-wsl would work solving this issue. I am interested in seeing if we can make it work with unsloth. Im curious what it's doing at that step if you can elaborate maybe I can poke around. Im guessing it has to be the pinnable memory since I have enough vram (a6000 ada 12gb out of 48 used). Im assuming the other option is HF or not using one at all. Is there an option to toss it into ram vs pinnable ram. is there a difference? Some people using unsloth have it working, but I think it's a combo version of the model size and the training data size using the same small memory space.

wonder if there has been an update or if the author/other participants have found a way around it? 🙏


Hourly weather data not matching with https://www.wunderground.com/history

Hi,
I am trying to fetch hourly data for city Northville, Michigan but it's not matching with hourly data given on https://www.wunderground.com/history.
I am using below geocodes and dates to fetch the data, so am I missing something here?

Same Issue, the TEMP/RHUM not matching with the web records


Custom EOL string ?

Q
A

Version
9.0

Question
Hi..
I need update update EOL (End Of Line) string to something like that: ";\r\n"
How to do that ? ($reader->setEOL())
In reader i must trim ";" on every last parsed value..

@neradp this is explain in the documentation website see http://csv.thephpleague.com/8.0/inserting/#handling-newline

Sorry ..i need that functionality for reader.. not writer..

@neradp you do realize that ";\r\n" is not a valid new line sequence ? I would suggest using stream filtering like explain in the document or a simple mapper function.

I do.. thanks...


Fix bug on chrome for Lightning Development (Dusty) page

Not sure if this is on just iOS or also on Android, and perhaps across other browsers other than chrome...
But on iOS using chrome the https://opensats.org/projects/dusty page is not mobile optimized:

Duplicate of #43


feat(gitee): move out the jobs and pipeline files

It was stored in other git repo at gitee.com.
Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/hold

/unhold


Slight Correction to Characterization of 'swprintf()'

This page states that:

swprintf is a wide-character version of sprintf; the pointer arguments to swprintf are wide-character strings

The interface of swprintf is
int swprintf(
   wchar_t *buffer,
   size_t count,
   const wchar_t *format [,
   argument]...
);

and, in particular, supports the count parameter "to specify the maximum number of characters to write."  As such, it seems that this function is instead better characterized as the wide-character version of snprintf:
int snprintf(
   char *buffer,
   size_t count,
   const char *format [,
   argument] ...
);

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a209539e-aeec-2bb4-5887-c4cf90467204
Version Independent ID: ed0abe24-9562-5db6-29dc-c7ad7588081a
Content: sprintf, _sprintf_l, swprintf, _swprintf_l, __swprintf_l
Content Source: docs/c-runtime-library/reference/sprintf-sprintf-l-swprintf-swprintf-l-swprintf-l.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Hi, heksterb.
I don't think I'll make this change. The function is explicitly named after sprintf because it's a secure version of sprintf. The count is about security (not overrunning the buffer) and is only coincidentally similar to snprintf.


TODO: Make comment appear progressively

Appear either line by line, or sentence by sentence. If too much text is show at once, it will overwhelm the viewer

For reference https://github.com/HA6Bots/Automatic-Youtube-Reddit-Text-To-Speech-Video-Generator-and-Uploader has done it


Added Turkish language support

Added full Turkish language support loyal to the original en.json file

Thank you so much for the translations @AtlasFontaine! :)

Thank you so much for this great app! :)


[flaky-test] Terraform tag push and builds are flaky

Flaky Test
<!--File what test failed in automation.
Make sure to assign the appropriate engineering team.-->

Terraform tag build v3.1.0 failed twice. This usually happens every time I try to release tf, it takes a few drone runs for the tf assets to be generated. This blocked QA testing for over a day when tagging the last rc.
Release Branch
source branch of PR: release/vXXX

rancher/terraform-rancher2-provider:master
Drone Build (if applicable)
pipeline stage URL: https://drone-publish.rancher.io/rancher/terraform-provider-rancher2/665

Wile doing the migration from SDK-V1 to SDK-V2 I starter getting the following error:
    testing_new.go:85: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: Bad response statusCode [401]. Status [401 Unauthorized]. Body: [message=Unauthorized 401: must authenticate] from [https://rancher.<IP_ADDRESS>.nip.io/v3/clusters/local]

        Error: Bad response statusCode [401]. Status [401 Unauthorized]. Body: [message=Unauthorized 401: must authenticate] from [https://rancher.<IP_ADDRESS>.nip.io/v3]

Less than 10% of the tests were working.
I tryed to debug adding a print statement to testAccRancher2UpgradeVars.
Once I added the print statement the test stop failing.
That said I do believe that  the flaky test was happening due to a Race condition that was solved with the delay of a sys-call.
The error was happening during the test cleanup, so It can't be a real problem on the provider.


add docs to create new keycloak user

add example to add keycloak user

self-merging - small doc fix, will take force-merge rights away from myself soon


[Question] Is the next() in BitUtils really optimized?

I have a question wrt to the implementation of BitUtils.next()
https://github.com/real-logic/agrona/blob/master/agrona/src/main/java/org/agrona/BitUtil.java#L348
Is it really optimised?
It has branching, which I'm assuming isn't getting optimised by JVM JIT compliers.
Any reason to not do it like:
int next = current;
return ++next % max

Or (in case modulo is expensive on the architecture)
int next = current;
return ++next == max ? 0 : next;

In most cases the max isn't reached. So the branch predictor can speculate that the branch doesn't need to be executed and it can immediately return the value.
Also compiler are pretty smart and can do all kinds of trickery liking converting it to branch free code.
I wrote a small JMH benchmark with the original, and your suggestions and a truly branchfree version (keep in mind that the ? can create a branch depending on what the JIT makes from it).
package org.agrona.concurrent;

import org.openjdk.jmh.annotations.*;
import org.openjdk.jmh.runner.Runner;
import org.openjdk.jmh.runner.RunnerException;
import org.openjdk.jmh.runner.options.Options;
import org.openjdk.jmh.runner.options.OptionsBuilder;

import java.util.concurrent.ThreadLocalRandom;
import java.util.concurrent.TimeUnit;

@Fork(value = 2)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 10, time = 1)
@State(Scope.Benchmark)
public class BitUtilsNextBenchmark {
    private static final int MAX = 1024;

    @Benchmark
    public int nextBranchFree(MyState state) {
        return nextBranchFree(state.r.nextInt(MAX), MAX);
    }

    public static int nextBranchFree(final int current, final int max) {
        int next = current + 1;
        int reset = (next - max) >>> 31;
        return next - (reset * max);
    }

    @Benchmark
    public int nextWithMod(MyState state){
        return nextWithMod(state.r.nextInt(MAX), MAX);
    }

    public static int nextWithMod(final int current, final int max) {
        int next = current;
        return ++next % max;
    }

    @Benchmark
    public int nextOriginal(MyState state) {
        return nextOriginal(state.r.nextInt(MAX), MAX);
    }

    public static int nextOriginal(final int current, final int max)
    {
        int next = current + 1;
        if (next == max)
        {
            next = 0;
        }

        return next;
    }

    @Benchmark
    public int nextTernary(MyState state) {
        return nextTernary(state.r.nextInt(MAX), MAX);
    }

    public static int nextTernary(final int current, final int max)
    {
        int next = current;
        return ++next == max ? 0 : next;
    }

    @State(Scope.Thread)
    public static class MyState{
        ThreadLocalRandom r = ThreadLocalRandom.current();
    }

    public static void main(String[] args) throws RunnerException {
        Options opt = new OptionsBuilder()
                .include(BitUtilsNextBenchmark.class.getSimpleName())
                .build();

        new Runner(opt).run();
    }
}

Results:
Benchmark                             Mode  Cnt  Score   Error  Units
BitUtilsNextBenchmark.nextBranchFree  avgt   20  3.487 ± 0.155  ns/op
BitUtilsNextBenchmark.nextOriginal    avgt   20  2.470 ± 0.043  ns/op
BitUtilsNextBenchmark.nextTernary     avgt   20  2.479 ± 0.054  ns/op
BitUtilsNextBenchmark.nextWithMod     avgt   20  2.394 ± 0.045  ns/op

So the original version has great performance and the branchfree version is actually slowest.

Wow,
Thanks for running the analysis @pveentjer


Graduation Tasks

The ASF board has approved a resolution to graduate MXNet into a full top level project. Thanks to everyone for your help to get to this point.
To transition from the Apache Incubator to a new TLP, there's a few action items we need to do to complete the transition. These are identified by https://incubator.apache.org/guides/transferring.html#life_after_graduation.
If you can help with these tasks, please respond in this issue.

Update Incubator status records

[x] Update the incubator status file (in svn) - @josephevans
[x] Update podling status page - @josephevans

Source repo changes

[x] Create ASF Infra TLP request - @josephevans - https://issues.apache.org/jira/browse/INFRA-23856
[x] Git repos will be renamed to drop the "incubator-" prefix, notify developers to change their remotes
[x] Post announcement to dev list telling everyone the repo is about to be moved
[x] Post an announcement containing instructions for developers describing how to change their git remotes.
[ ] Update website, Jenkins, wikis, pom.xml, and other resources to point to the new repository location - https://github.com/apache/incubator-mxnet/pull/21148

Websites

[ ] If you have any fully qualified links to your podling.incubator.apache.org on your website change them - https://github.com/apache/incubator-mxnet/pull/21148

Mailing Lists

[ ] If you use podling.incubator.apache.org format email addresses, please start using podling.apache.org
[ ] Check project-private mailing list membership. Mentors should be allowed to remain if they wish to do so. The subscriber list should otherwise match that on the resolution. See this and the EZMLM "Moderator’s and Administrator’s Manual".
[ ] Update mail addresses including: issue tracking messages (see administration documentation)
[ ] Double-check that all of your lists have sufficient active moderators.

Issue Tracking

[ ] Ask infra to move the podling to its own top level category in JIRA, if using JIRA (I think we previously used JIRA)

Distribution mirrors

[ ] Create new distribution area (dist.apache.org) release/${project} and dev/${project} folders can be created by PMC members. - new releases will go here. Need to decide on what to do with previous releases under incubator (see section under distribution mirrors here.

I am collecting what we need to ask Apache Infra to update now that we have graduated. These are the git repos for MXNet under Apache. Some of these are stale and have not been updated recently. Do we still need all of these repos?
The following repos should be renamed to remove the "incubator-" prefix.
https://github.com/apache/incubator-mxnet-site
https://github.com/apache/incubator-mxnet-ci
https://github.com/apache/incubator-mxnet-events
https://github.com/apache/incubator-mxnet-examples
https://github.com/apache/incubator-mxnet-test

We probably don't need the -events or -test repos. Also, Infra asked us to change the website publishing and reduce the website size, or otherwise the existing workflow tends to time out.


nvidia-smi not found. CPU will be used.

Hello！
I can get the following screen indicating that the driver is installed successfully
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 470.63.01    Driver Version: 470.63.01    CUDA Version: 11.4     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  Off  | 00000000:01:00.0 Off |                  N/A |
| N/A   43C    P8     7W /  N/A |      6MiB /  5944MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      2827      G   /usr/lib/xorg/Xorg                  4MiB |
+-----------------------------------------------------------------------------+
but WHEN I want to enter Apollo Docker to compile, I get the following prompt：
[WARNING] nvidia-smi not found. CPU will be used.
So did I install the driver successfully or not？

This can only say that your host machine has successfully installed the NVIDIA graphics card driver, but it is not installed in docker. You should install nvidia-docker tool to compile GPU.You can find the installation script at this address：**https://github.com/ApolloAuto/apollo/blob/r5.5.0/docker/setup_host/install_nvidia_docker.sh**,This script is also applicable to 6.0.0 version or later.

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.

This can only say that your host machine has successfully installed the NVIDIA graphics card driver, but it is not installed in docker. You should install nvidia-docker tool to compile GPU.You can find the installation script at this address：**https://github.com/ApolloAuto/apollo/blob/r5.5.0/docker/setup_host/install_nvidia_docker.sh**,This script is also applicable to 6.0.0 version or later.

the link is unreacheable now,do u have one?

I am also getting the same error. Did anyone manage to sort the issue?
root@in-dev-docker:/apollo# ./apollo.sh build_gpu
[WARNING] nvidia-smi not found. CPU will be used.
[WARNING] nvidia-smi not found. CPU will be used.
[INFO] Apollo Environment Settings:
[INFO]     APOLLO_ROOT_DIR: /apollo
[INFO]     APOLLO_CACHE_DIR: /apollo/.cache
[INFO]     APOLLO_IN_DOCKER: true
[INFO]     APOLLO_VERSION: guardstrike/apollo_carla_bridge-2022-11-23-653b3e953
[INFO]     DOCKER_IMG: dev-x86_64-18.04-20210914_1336
[INFO]     APOLLO_ENV:  STAGE=dev USE_ESD_CAN=false
[INFO]     USE_GPU: USE_GPU_HOST=0 USE_GPU_TARGET=0
[WARNING] nvidia-smi not found. CPU will be used.
[WARNING] nvidia-smi not found. CPU will be used.
[WARNING] nvidia-smi not found. CPU will be used.
[WARNING] USE_GPU=1 without GPU can't compile. Exiting ...
The above shared link could not be accessed. Please help


Lots of Warnings due to unexpected clipping

I am able to process the wave files, however i am getting lots of Warnings:
Number of files to be synthesized: 60000
Warning: File #0 has unexpected clipping, returning without writing audio to disk
Warning: File #9 has unexpected clipping, returning without writing audio to disk
Warning: File #10 has unexpected clipping, returning without writing audio to disk
Warning: File #10 has unexpected clipping, returning without writing audio to disk
Warning: File #19 has unexpected clipping, returning without writing audio to disk
Warning: File #27 has unexpected clipping, returning without writing audio to disk
Warning: File #27 has unexpected clipping, returning without writing audio to disk
Warning: File #28 has unexpected clipping, returning without writing audio to disk
Warning: File #33 has unexpected clipping, returning without writing audio to disk
Warning: File #34 has unexpected clipping, returning without writing audio to disk
Warning: File #37 has unexpected clipping, returning without writing audio to disk
Warning: File #42 has unexpected clipping, returning without writing audio to disk
Warning: File #44 has unexpected clipping, returning without writing audio to disk
Warning: File #65 has unexpected clipping, returning without writing audio to disk
Warning: File #65 has unexpected clipping, returning without writing audio to disk
Warning: File #66 has unexpected clipping, returning without writing audio to disk
Warning: File #69 has unexpected clipping, returning without writing audio to disk
Warning: File #79 has unexpected clipping, returning without writing audio to disk
Warning: File #82 has unexpected clipping, returning without writing audio to disk
Warning: File #83 has unexpected clipping, returning without writing audio to disk
Warning: File #88 has unexpected clipping, returning without writing audio to disk
Warning: File #89 has unexpected clipping, returning without writing audio to disk
Warning: File #97 has unexpected clipping, returning without writing audio to disk
Warning: File #98 has unexpected clipping, returning without writing audio to disk
Warning: File #104 has unexpected clipping, returning without writing audio to disk

Is that normal ?

After it mixes clean speech and noise at a particular SNR, there is a chance for the mixed signal to be clipped. We check for clipping and skip writing that particular file and go to the next. There is to ensure that there is no clipping in the synthesized clips. You can comment out lines 183 and 184 in noisyspeech_synthesizer_singleprocess.py if you don't want this message to be printed.

Thank you very much, I am closing the issue.

Great! I've been checking this for a long time.

Great! I've been checking this for a long time.


Provider and OS images

In support of #910 but also all things, it would be super great if the api could serve provider and os images (by images, I mean the .svg that are generated and stored in public/assets/svg).

will ensure consistency of icons across uis
will reduce bundle size of sui assets
will be super cool

This discussion is kinda related but also kinda different: https://gitter.im/ManageIQ/manageiq/ui?at=59ce771f7b7d98d30d510fe2
@chriskacerguis

Will need this resolved: https://github.com/ManageIQ/manageiq-api/issues/92

@AllenBW good call on this.  @Loicavenel and @serenamarie125 are you on board with this too?

Cannot comment on the technology side, but consistency is good.

Moving to BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1502785


fix: unlock incentives so people can withdraw before the unlocking time finishes

Description and Motivation

This PR unlocks the incentives so users can withdraw without waiting for the unlocking time to finish.
This is gonna be done in specific pools which liquidity is being moved.
Related Issues

Checklist:

[x] I have read Migaloo's contribution guidelines.
[x] My pull request has a sound title and description (not something vague like Update index.md)
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation.
[x] The code is formatted properly cargo fmt --all --.
[x] Clippy doesn't report any issues cargo clippy -- -D warnings.
[x] I have regenerated the schemas if needed cargo schema.

This is not to be merged to the main branch since it's only a temporary fix. After the liquidity migration process is done, the contract will be migrated again so the withdrawals will have the timelock as usual.


CIV-869 Email notification to parties SDO

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-869
Change description
This PR creates a handler for the CREATE_SDO journey as well as handlers for the two notification events created in this PR. Along side these class files are the tests.
The CreateSDOCallbackHandler was created based on the CreateClaimCallbackHandler taking out everything that was not needed at this time.
The message Header and Body used are just placeholders until we decide upon what to display to the user, this is the same for the email templates used in the notification handlers and will be changed in a future PR.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closed as changes are included within the following PR that updates the email template used: https://github.com/hmcts/civil-service/pull/664


Add utility for creating a new monorepo package

Explanation

References

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@SocketSecurity ignore<EMAIL_ADDRESS>

This PR is currently blocked on either:

Letting the create-package tests exclusively run under jest@^29, as opposed to the rest of the monorepo's jest@^27.
Migrating the entire monorepo to jest@^29.

After an initial assessment, this does not appear to be trivial.

Unless we come up with an acceptable solution, I will implement create-monorepo-package as a standalone tool in a separate repo, and close this PR.

@SocketSecurity ignore<EMAIL_ADDRESS><EMAIL_ADDRESS>The new author is some kind of Google bot. The original author is still an author.


Additional deploy fixes for dangling symlinks and tfjs-node

Addresses #3330

third time's the charm.


Incorrect types in getCachedData when passing a Data type to useFetch

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.10.3
CLI Version:      3.10.1
Nitro Version:    2.9.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-gfzzpe?file=pages%2Findex.vue
Describe the bug

Open the reproduction link
Run npm run typecheck.
It will complete successfully and caching works (navigate between index & about to see it)
In index.vue, add the type TestDataT to useFetch and repeat step 3, everything work as expected
Comment the first line inside getCachedData function and uncomment the return undefined and repeat step 3, gives a type error.

Additional context
getCachedData accepts undefined or a function that returns a data if found or undefined or null to trigger a refetch as stated in the docs.

getCachedData: Provide a function which returns cached data. A null or undefined return value will trigger a fetch

When not passing a response type to useFetch, things work correctly and getCachedData gets typed as (key: string) => unknown | undefined
<script setup lang="ts">
  const { data } = await useFetch('/todos/1', {
    getCachedData: (key) => {
      // ^ (key: string) => unknown | undefined

      // Both works without type errors
      return nuxtApp.payload.data[key] || nuxtApp.static.data[key]
      return undefined
    },
 })
</script>

<template>
  <div> {{ data }} </div>
</template>

When passing aresponse type to useFetch. getCachedData gets typed as (key: string) => DataT and gives a type error if I attempt to return undefined
<script setup lang="ts">
  type TestDataT = { foo: 'bar' }

  const { data } = await useFetch<TestDataT>('/todos/1', {
    getCachedData: (key) => {
      // ^ (key: string) => TestDataT

      // This works
      return nuxtApp.payload.data[key] || nuxtApp.static.data[key]

      // This gives type error
      return undefined
    },
 })
</script>

<template>
  <div> {{ data }} </div>
</template>

Logs
No response

I think we can track in https://github.com/nuxt/nuxt/issues/25903.


any progress with release?

Unlikely, I named it an "experiment" because it's just a toy thing for me to learn falcor with.
If you want to base something off of it please feel free, I added a license (c08fb1a41daf493241f6e593b339fc586ca80644).
Be careful though, I suspect falcor has changed significantly since I first wrote this.


Questions for running in demo room

List of questions / things to check when running in the Demo room:

[x] What dimensions should each of the spaces be?
[x] Generate some schematic / diagram to map the OVE spaces to the physical monitors and computers in the room.
[x] Is the current http configuration suitable?
[x] Can we initiate sections using the API?
[x] Can we switch / delete sections using the API?

Aha! Link: https://imperial-college-ict.aha.io/requirements/RSE-139-11

All of these questions have been answered.

What dimensions should each of the spaces be? ➡ #19
Generate some schematic / diagram to map the OVE spaces to the physical monitors and computers in the room. ➡  on Whimsical board.
Is the current http configuration suitable? ➡ There were no problems in the demo room.
Can we initiate sections using the API? ➡  Yes, currently demonstrated on api_test branch, to be merged in.
Can we switch / delete sections using the API?  ➡  Yes, currently demonstrated on api_test branch, to be merged in.

We can either close the issue now or when the api changes have been merged in.

Happy to close this. Questions were answers, details being implemented in api_test branch are related to #6 #7 and #9


Update project SWIFT_VERSION to 4.2 for Fix Swift 4.2 build error.

What happened:
When using this library with CocoaPods, Swift Version of the build target is specified as 4.0 and an error occurs.
Approach:
Resolve Swift Version by specifying 4.2 for the entire project.

Thanks.


Support preview Organization Invitation API

New endpoints:

Create organization invitation
List organization invitation teams

Changes to existing endpoints:

List pending organization invitations has two new fields. team_count and invitation_teams_url.

Detailed here:

https://developer.github.com/changes/2018-01-25-organization-invitation-api-preview/

Fixes #838

@gmlewis @kshitij10496 Thanks for the comprehensive review. Will make sure to do the corrections and update the PR ASAP. :smiley:

I believe I have addressed the changes suggested by @gmlewis and @kshitij10496.Please feel free to point out any problems which persist.

Merging.


GCP architecture diagram

@iameskild  is working on this
Should be added to https://lucid.app/documents#/documents?folder_id=278399173

@iameskild  is this being worked on?

Hi @trallard, I think we can close this in favor of https://github.com/nebari-dev/nebari-docs/pull/59


[BUG] Problem with autocomplete

Since I updated DBeaver to latest version (5.2.3 - Released on October 22, 2018), autocomplete isn't working fine. It concatenates the characters I entered at the end of the suggestion I accepted.
Like this:
select * from my ( then suggests my_table)
When I accept suggestion:
select * from my_tablemy
instead of
select * from my_table

It is  known issue, it is already fixed and hotfix version has been releases 24.10. just re-download 5.2.3 version.

Oh. Sorry! Great!
I updated, and it's working fine. Thanks.

Download it onhHomepage after installation u should have <IP_ADDRESS>8-10-23_2047 (without delimter)
But I still have the problem with actual version sequence is still wrong. See pic in #4484

You basically say that when dbeaver says there is a new version, then wait and do not download it as it contains bugs that will be hot-fixed.
After a week or 2, the version might be stable.
The version 5.2.3 that I can download now is not the same as I've downloaded and installed. That is wrong.
Especially because the dbeaver application says there is no update.

@MacNetron yes, you are right. This is because we had to release hotfix version right after 5.2.3 release. It differs only in build number and contains just one fix of critical bug of SQL completion.
Usually we never do such hotfix releases.

@serge-rider please do not do hidden updates, I was waiting for the update from dbeaver interface more than a week and that week was full of suffering and pain.


Runic Charge

https://www.d20pfsrd.com/feats/combat-feats/runic-charge-combat

Thank you for your suggestions! I'm going to move these over to the suggestions thread and close these individual ones out. If you'd like to submit anymore suggestions please do so in the suggestions thread :) https://github.com/Envibel/MartialExcellence/issues/1


Wrong output of minidocument

I'm trying to use the [minidocument] package in my document to do a sort of "how to read" section.
However it doesn't render as hoped.

As you can see the lines and margin are misplaced.
I produce it using this
\begin{minidocument}
  \setchapterstyle{kao}
  \chapter{Dummy chapter}

  \blindtext~\sidecite{something}

  \marginnote[1cm]{\blindtext}
  \marginnote[4cm]{\blindtext}
  \marginnote[10cm]{\blindtext}
  \Blindtext
\end{minidocument}

\begin{figure}[hb]
  \lastminidocument
\end{figure}

I have
\usepackage{minidocument}
\def\minidocumentscale{0.25}
\usepackage{blindtext}

before the \begin{document}.

Sorry for the late reply.
I suspect it's a geometry problem... My best try was adding some code inside the minidocument environment (it enlarges the marginsep, without affecting the style of the chapter title). Note that \setchapterstyle should not be included anymore.
\begin{minidocument}
  \DeclareDocumentCommand{\chapterstylekao}{}{%
    \renewcommand*{\chapterformat}{%
        \mbox{\chapappifchapterprefix{\nobreakspace}\scalebox{2.85}{\thechapter\autodot}}%
    }
    \renewcommand\chapterlinesformat[3]{%
        \vspace*{-4.5cm}%
        \makebox[\textwidth+8.2mm+\marginparwidth]{%
            \parbox[b]{\textwidth}{\flushright{##3}}%
            \makebox[8.2mm][c]{\rule[-.2cm]{1pt}{5.7cm}}%
            \parbox[b]{\marginparwidth}{##2}%
        }
    }

    \RedeclareSectionCommand[beforeskip=0cm,afterskip=1cm]{chapter}
    \setlength{\mtocshift}{0mm}
  }
  \chapterstylekao
  \newgeometry{
    top=27.4mm,
	bottom=27.4mm,
	inner=24.8mm,
	textwidth=107mm,
	marginparsep=32mm,
	marginparwidth=49.4mm,
	includemp
  }%

  \chapter{Dummy chapter}
  \blindtext~\sidecite{something}
  \marginnote[1cm]{\blindtext}
  \marginnote[4cm]{\blindtext}
  \marginnote[10cm]{\blindtext}
  \Blindtext
\end{minidocument}

This is indeed much better! Thanks.
But there are still slight problems with this. It also messes up with the layout of the chapter it's in.
I won't be using minidocument anymore I think.
Thanks a lot.


PR doesn't count as a valid PR for Hacktoberfest, shows Excluded/BAD Repository

I'm not sure why this happened, but I never created this repository with an intention to distribute swags to students or doing anything that doesn't follow the Hacktoberfest guidelines. I created this with an intention to help beginners kickstart their open source career.
I've been contacted by several people who contributed to my repository that this repo is now labelled as an excluded/bad repository for hacktoberfest 2021. I reached out to a discord server (https://discord.gg/dyTJszNF) in the #discussions channel regarding this issue, and found out this::

I tried contacting alot of people regarding this, I've not received a proper reply. Some said that this repo is reported as malicious as the PRs are not meaningful, which I didn't believe at all. Please help me how to get this repo included in Hacktoberfest. I was working from so long for this.
I'm sorry for this, I never wanted this to happen. Please if someone knows how to get this included back, let me know!

I'll try my best to get this repository included for Hacktoberfest 2021 as I believe we were not violating any guidelines, the codes are not basic and I wasn't accepting every PR which I got, actually I closed most of them as they didn't followed the NOTE FOR CONTRIBUTORS.md file.
Till then I request you to participate in some other repository to complete hacktoberfest challenge. (DON'T LOSE HOPE, KEEP CONTRIBUTING). I might not be the one to help you guys with open source contributions this Hacktoberfest, but it is a really nice platform to get into open source. (Keep Hacking 😢)

😪😪

Really this is begineer friendly , i dont understand why would they exclude this .

@passionlord @nm2708  I don't know why this happened, people telling me that this repo might be reported by others claiming it as spam, which I'm not sure why someone will do so.
However, I'll still check out all the PRs and merge the ones that follow the guidelines. And most probably I'll create a sheet of Development Repos where you guys can contribute to now. But again, the intention was never to distribute swags, it was just to make people learn.

What can we do now?

@nishantkumar1308 Find some other repo to contribute in now. This repo is no longer included in Hacktoberfest 2021. Sorry bro! :(

Tbh such an amazing repo, it should be included in Hacktoberfest for sure!

@piyushsharma220699  what can we do  to make repositry  include in hacktober fest?

@nishantkumar1308 I had a conversation with a mentor of Hacktoberfest 2021 Discord channel and this is how it went ::

I think this can't be undone, you need to look for other repositories to contribute :(

@piyushsharma220699
I've submitted three pull requests on  some other guy for Hacktoberfest  project, but unfortunately, all of them have been marked as excluded. I also noticed that the repository has been archived.
Could you please provide some insight into the reasons for excluding my PRs?


Fixes

Hey again!
Fixed HTML encoded characters we noticed earlier today, and also took the time to cleanup the series type stylization
Fixes HTML encoded characters:

Before
After

Multi-words like "Anime_short" is now "Anime Short"

Before
After

Abbrevations like "Ona" is now "ONA"

Before
After

Good stuff!


Throwing in beforeAll is ignored

Describe the bug
I'm building out some tests for my project, and am trying to debug both the tests and the helper functions I'm building to setup the test states, etc.
While trying to debug why my tests weren't working, I discovered that if I throw an error inside of beforeAll, or return a promise that I reject, vitest seems to carry on as if everything completed successfully. This is making it extremely hard to debug tests, as well as disambiguate whether the problem is with my project, the test, or the test setup.
Reproduction
beforeAll(async () => {
   throw new Error("STOP")
})

or
beforeAll(async () => {
   return new Promise((resolve, reject) => { reject(); })
})

System Info
System:
    OS: macOS 12.0
    CPU: (10) arm64 Apple M1 Pro
    Memory: 97.80 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.1/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Chrome: 100.0.4896.127
    Safari: 15.0
  npmPackages:
    vite: ^2.9.6 => 2.9.6
    vitest: ^0.10.0 => 0.10.0

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Everything works with your reproduction: meaning, tests fail.
https://stackblitz.com/edit/vitest-dev-vitest-xqtujg?file=test/suite.test.ts

Aah, I see what is happening. I have multiple describe() blocks, and even if the beforeAll() in the first block throws immediately, I don't see that error until all of the other tests have completed or timed out.
https://stackblitz.com/edit/vitest-dev-vitest-oycgdw?file=test%2Fsuite.test.ts
In our current environment, our tests or dependent on the effects of their previous ones (not ideal, I know, but it's how it is for now) so if any block fails I would like to shown the error immediately and probably exit out. Is there a configuration we can use for that?

This is not possible. describe blocks exist to prevent that :)
Try moving your tests to the same describe block, or move beforeAll to the top level.

Would it at least be possible to show the thrown errors immediately? I can see console logs/errors/etc. as soon as they run instead of after all tests have ended/timed out, and I did notice that I could see the errors if I essentially wrapped all of the functions in
() => {
  try {
    ...
  } catch (e) { console.error(e); }
}

but that seems excessive to have to do for the purposes of faster results/debugging

Would it at least be possible to show the thrown errors immediately?

Depends on what reporter do you use? The base reporter dynamically updates the tree and only the relevant part is visible until every test is processed.
We also have verbose reporter that shows the error immediately.

I guess it would be possible to achieve with "bail" option from https://github.com/vitest-dev/vitest/issues/1459. Closing this issue in favor of it.


Add Code of Conduct

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>As the title says

@rhatdan PTAL

LGTM


selectrum-prescient: Add options to configure filtering and sorting

Similar like for ivy it is useful to be able to configure these now that we have several options for Selectrum, too.

This is a big improvement as long as we don't have Prescient completion styles (#89)!

Would it make sense (maybe in the README) to explain how this would behave with orderless?

With orderless you should disable filtering. I think @clemera described this in the Selectrum wiki.

@minad Thank you, I've seen the update on the Wiki.

I will add an example to the Selectrum README in this PR.


ignore .idea everywhere

Tiny QoL PR.
There's no real reason (that I can see) to only ignore .idea in the repo root. If you only have a Microbit for example, you're going to work in the appropriate subdirectory and any .idea directory that gets created is just clutter.

Thanks for the suggestion!
Not sure git-ignoring an editor-specific dotfile is a great idea at all, actually: once we go down that road there's a lot of things we could do, but it probably belongs in folks' global gitignore instead.
I'm going to remove that line in https://github.com/rust-embedded/discovery-mb2 . Probably won't touch this, as we're trying to move over there soon.
Again, thanks.

Yeah, that makes a lot of sense. I'll close this not to clutter up this repo.


Extension will throw "thisRequestUrl.includes" is not a function if Request object is passed to the fetch function

Request can be passed to fetch function. The extension will throw error if Request object is passed when calling fetch due to it expecting string

Could you provide a specific example? I tested it and it works fine.

May try this example:
https://codesandbox.io/p/sandbox/delicate-tdd-sgt4dk
and try to add rules for https://jsonplaceholder.typicode.com


refactor tests

this is just to split the tests folder into a file for the problems and a file for the actual tests.

Pull Request Test Coverage Report for Build 558931791

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.909%

Totals

Change from base Build 558720865:
0.0%

Covered Lines:
185

Relevant Lines:
197

💛  - Coveralls


Some Questions about the training code

Firstly, I want to commend you on the exceptional work you've published and for making the repository available. It's been enlightening reviewing your code, and I have a few questions that I hope you could help clarify, particularly about the training code:

As we can see, the GradCache technique is used for GradCacheTrainer. In the code, there are six conditions including self.split_emb, self.split_emb_full and so on. I'm curious to understand whether the else clause is the only instance where GradCacheTrainer is utilized in the training process.
When using the GradCacheTrainer, is it necessary to define the training_step function as outlined in the here, or can this be omitted?

My answer to these questions is yes for both.

Firstly, I want to commend you on the exceptional work you've published and for making the repository available. It's been enlightening reviewing your code, and I have a few questions that I hope you could help clarify, particularly about the training code:

As we can see, the GradCache technique is used for GradCacheTrainer. In the code, there are six conditions including self.split_emb, self.split_emb_full and so on. I'm curious to understand whether the else clause is the only instance where GradCacheTrainer is utilized in the training process.
When using the GradCacheTrainer, is it necessary to define the training_step function as outlined in the here, or can this be omitted?

My answer to these questions is yes for both.

else is the only instance where GradCache is used.
Yes this is till necessary. The purpose of that function is to ensure that both gen & emb losses can be tracked in e.g. wandb.

Thank you for your response. Regarding the second question, under the premise of using GradCacheTrainer, I believe there is no need to define the training_step function in run.py. The reason is that line 704 of gradcache_trainer.py has already logged different losses. Therefore, I think that when using GradCacheTrainer, it is not necessary to define a training_step because it will not be called.

Thank you for your response. Regarding the second question, under the premise of using GradCacheTrainer, I believe there is no need to define the training_step function in run.py. The reason is that line 704 of gradcache_trainer.py has already logged different losses. Therefore, I think that when using GradCacheTrainer, it is not necessary to define a training_step because it will not be called.

Ah yeah you're right, sorry. The training_step is never used for the GradCacheTrainer cuz it's commented out here https://github.com/ContextualAI/gritlm/blob/09d8630f0c95ac6a456354bcb6f964d7b9b6a609/gritlm/training/gradcache_trainer.py#L545 and done via the code you pointed to

Thank you for your reply :)

Thank you for your reply!


spatial data, split out notebook functionality

See issue #13

This and issue #13 are finished with the pull request #70.


Highlight left piano when MIDI events are sent

Highlight left piano keys corresponding to MIDI keys being pressed

https://github.com/yuxshao/ptcollab/commit/68327169703a210ff1bfd6d0d812901ed6b174df


UI: Implement Head-Rotation Visualization

The mockups in issue #3 which visualize Individualized Performance describe a head rotation visualization. This issue tracks the progress in developing a visualization from this.

Implementation
Plot.ly has many pre-defined visualizations, but unfortunately does not seem to allow for easy definition of custom visualization mappings. However, SVG is a widely supported web-format which can be embedded into HTML and should be fairly doable to modify, for the purpose of visualizing data (they can even be animated). Maybe we can modify it based on data coming in from R Shiny?
The element IDs to target are headRotationSubFieldGreen, headRotationSubFieldYellow and headRotationSubFieldRed. In order to modify the radius of the different colored elements, the attributes the values of sodipodi:start and sodipodi:end can be changed.
Download the SVG file here:
head-rotation-vis.zip
The SVG code can be modified from a text editor, or straight in the browser via F12 panel. Alternatively, Inkscape can also be used (via the built-in XML editor shown on Ctrl+Shift+X).

I am not sure whether sodipodi:start and sodipodi:end are inkscape specific attributes ..Judging from this website, maybe the story is a bit more complicated - again expressed by some form of matrix:
http://xahlee.info/js/svg_circle_arc.html

I'm going to tinker with the SVG and R to see if I can manage something

Okay, managed to add the SVG to the R app, and it is generated at runtime by the server. The link you provided is really useful, I think what I'll need to do is to convert the arc generation's JavaScript code to R code (seems to be manageable). Then I would have to generate correct arcs depending on the values from the database.
I could also try to directly embed the JavaScript code to R. I'll have a look at this option if converting the JS code to R is too tedious.


feat: Auto-adapt NOTES.txt to HA changes in underlying CF manifest.

Description
Used @jandubois ' proposal to read the HA cell count from the underlying CF manifest, replacing the hardwired 3.
Motivation and Context
See https://github.com/cloudfoundry-incubator/kubecf/pull/1591#discussion_r524586598
How Has This Been Tested?
Local minikube.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Closes https://github.com/cloudfoundry-incubator/kubecf/pull/1593


feat: Added note to ensure that Microsoft.Storage is associated with …

If you are dealing with large datasets, the Microsoft.Storage Service Endpoint needs to be added to the subnet, otherwise syncs will fail with an SSL error.

@nikkiwaghani
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Thanks for your contribution, @djoy2. I merged these changes now in https://github.com/MicrosoftDocs/data-integration-pr/pull/682. #please-close


Bump version of protobuf-java to 3.22.2

Description
There are 3 Gradle sub-projects declared protobuf-java dependency. They have got different version due to upgrade alone.
This PR will unify the version of library protobuf-java used in OpenSearch.
Changed the version for the below 3 libraries in 2 directories.
plugins/repository-gcs/build.gradle :
api 'com.google.protobuf:protobuf-java-util:3.22.2'
api 'com.google.protobuf:protobuf-java:3.22.2'

test/fixtures/hdfs-fixture/build.gradle :
api 'com.google.protobuf:protobuf-java:3.22.2'

There is another protobuf-java dependency declared in plugins/repository-hdfs/build.gradle, the version is already 3.22.2.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #6994 (838a479) into main (20b3ea6) will increase coverage by 0.00%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main    #6994   +/-   ##
=========================================
  Coverage     70.77%   70.77%
- Complexity    59275    59297   +22
=========================================
  Files          4823     4823
  Lines        283985   283985
  Branches      40953    40953
=========================================
+ Hits         200993   200996    +3
- Misses        66459    66491   +32
+ Partials      16533    16498   -35

see 479 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.