Issue with creating meta modules with spack-stack 1.5.1 under Ubuntu/Docker

Describe the bug
I am trying to install spack-stack 1.5.1 to a Ubuntu box under Docker container. In this case, everything is fine and all packages are installed without any issue until last step to create meta modules using spack stack setup-meta-modules command.
To Reproduce

create container docker run --rm --platform linux/amd64 -e DISPLAY=host.docker.internal:0 --net host -it ubuntu:latest
cd /opt
git clone https://github.com/oceanmodeling/ufs-coastal-app.git
cd ufs-coastal-app
./build_deps.sh<EMAIL_ADDRESS><EMAIL_ADDRESS>--install-core-pkgs --install-lmod -v
This will take time and install all the dependency but gives error as it found as following. BTW, if I checked the module names in the /opt/./ufs.local/modulefiles/module-index.yaml file they looks like following

module_index:
  mr53zfa5eus3xfktfbsi3kz3npwme54j:
    path: /opt/ufs.local/modulefiles/Core/bacio/2.4.1-mr53zfa.lua
    use_name: bacio/2.4.1-mr53zfa
  xees72jfzsc473p4ofkqveftxet6sqig:
    path: /opt/ufs.local/modulefiles/openmpi/4.1.6-bazsoby/Core/base-env/1.0.0-xees72j.lua
    use_name: base-env/1.0.0-xees72j
  m6k2xnxfp6wm2lp42kzb2wxwx4j2uxyx:
    path: /opt/ufs.local/modulefiles/Core/bzip2/1.0.8-m6k2xnx.lua
    use_name: bzip2/1.0.8-m6k2xnx

and they have hash names at the end of the module use_name (this is correct in the container that I manually installed). Maybe this will be fixed when meta-modules are created but not sure. I also manually follow the steps previously and it was fine. I am not sure what is the issue in my script since it is following the same procedure.
The content of the /opt/spack-stack/envs/ufs.local/site/compilers.yaml is like following,
compilers:
- compiler:
    spec<EMAIL_ADDRESS>    paths:
      cc: /usr/bin/gcc
      cxx: /usr/bin/g++
      f77: /usr/bin/gfortran
      fc: /usr/bin/gfortran
    flags: {}
    operating_system: ubuntu22.04
    target: x86_64
    modules: []
    environment: {}
    extra_rpaths: []

Expected behavior
Having meta modules.
System:
Ubuntu, 22.04.3 LTS under Docker container
Additional context
==> Regenerating lmod module files
Configuring basic directory information ...
  ... script directory: /opt/spack-stack/spack/lib/jcsda-emc/spack-stack/stack
  ... base directory: /opt/spack-stack/spack/lib/jcsda-emc/spack-stack
  ... spack directory: /opt/spack-stack/spack
Configuring active spack environment ...
  ... environment directory: /opt/spack-stack/envs/ufs.local
Parsing spack environment main config ...
  ... install directory: /opt/ufs.local
Parsing spack environment modules config ...
  ... configured to use lmod modules
  ... module directory: /opt/ufs.local/modulefiles
Parsing spack environment package config ...
  ... list of possible compilers<EMAIL_ADDRESS>'gcc', 'intel', 'pgi', 'clang', 'xl', 'nag', 'fj', 'aocc']'
  ... list of possible mpi providers<EMAIL_ADDRESS>'openmpi', 'mpich']'
['module-index.yaml', 'Core', 'openmpi']
==> Error: No matching compilers found

Did you set the config:packages:all entries as per documentation? Something like
spack config add<EMAIL_ADDRESS>spack config add<EMAIL_ADDRESS>
matching your compiler and mpi versions?
What is the contents of /opt/ufs.local?

@climbfuji Thanks for your help. Yes, I run those commands. Is there any way to double check. I think they will appear in spack.yaml. In my case it is shown like following,
# spack-stack hash: 2605d04
# spack hash: cc9780cd0e
spack:
  concretizer:
    unify: when_possible

  config:
    install_tree:
      root: /opt/ufs.local
  modules:
    default:
      roots:
        lmod: /opt/ufs.local/modulefiles
        tcl: /opt/ufs.local/modulefiles
      lmod:
        core_compilers:
        -<EMAIL_ADDRESS>  view: false
  include:
  - site
  - common

  specs:
  - ufs-weather-model-env~debug
  packages:
    all:
      compiler<EMAIL_ADDRESS>      providers:
        mpi<EMAIL_ADDRESS>    fontconfig:
      variants: +pic
    pixman:
      variants: +pic
    cairo:
      variants: +pic
    libffi:
      version:
      - '3.3'

I have following folder under that directory,
/opt/ufs.local/
|-- bin
|   `-- sbang
|-- gcc
|   `-- 11.4.0
|       |-- bacio-2.4.1-mr53zfa
|       |-- base-env-1.0.0-xees72j
|       |-- bzip2-1.0.8-m6k2xnx
|       |-- c-blosc-1.21.5-lgx4mxz
|       |-- cmake-3.23.1-q3kdrhh
|       |-- cprnc-1.0.3-am4dxph
|       |-- crtm-<IP_ADDRESS>-bys5n5a
|       |-- crtm-fix-<IP_ADDRESS>_emc-jkzbfos
|       |-- curl-8.4.0-rc2ezxf
|       |-- esmf-8.5.0-wy2lwzd
|       |-- expat-2.5.0-u5kpbc7
|       |-- fargparse-1.5.0-2yqzcum
|       |-- fms-2023.04-svdnm6g
|       |-- g2-3.4.5-qz6kili
|       |-- g2tmpl-1.10.2-2xva3qy
|       |-- gdbm-1.23-3d2ady7
|       |-- gettext-0.21.1-lpiiike
|       |-- gftl-1.10.0-pnnpgob
|       |-- gftl-shared-1.6.1-dgb6plh
|       |-- hdf5-1.14.0-lieg5z2
|       |-- hwloc-2.9.1-wcizhtu
|       |-- ip-4.3.0-3fqud5x
|       |-- jasper-2.0.32-7ll3w4u
|       |-- krb5-1.20.1-2q4sthb
|       |-- libaec-1.0.6-skct4kl
|       |-- libbsd-0.11.7-322ozf2
|       |-- libedit-3.1-20210216-6cxsakf
|       |-- libevent-2.1.12-3mi7mi3
|       |-- libffi-3.3-mvlyxmt
|       |-- libiconv-1.17-nzwvzyn
|       |-- libjpeg-turbo-2.1.0-bpk6pnm
|       |-- libmd-1.0.4-hzluctu
|       |-- libpciaccess-0.17-xfzogxu
|       |-- libpng-1.6.37-jjsdac4
|       |-- libxcrypt-4.4.35-q2m4qty
|       |-- libxml2-2.10.3-53bweqq
|       |-- libyaml-0.2.5-ts62deh
|       |-- lz4-1.9.4-nbakpg2
|       |-- mapl-2.40.3-ohcno55
|       |-- nccmp-<IP_ADDRESS>-cqd6vsg
|       |-- ncurses-6.4-a7y7nnp
|       |-- netcdf-c-4.9.2-lur2xpz
|       |-- netcdf-fortran-4.6.1-7zxqoxd
|       |-- nghttp2-1.57.0-2ce7efn
|       |-- numactl-2.0.14-nrwhgn5
|       |-- openblas-0.3.24-q65ugam
|       |-- openmpi-4.1.6-bazsoby
|       |-- openssh-9.5p1-cj7uljl
|       |-- openssl-3.1.3-6lzewj3
|       |-- parallel-netcdf-1.12.2-dnpsayl
|       |-- parallelio-2.5.10-6jhkq73
|       |-- pkg-config-0.29.2-sa4pcl5
|       |-- pmix-5.0.1-vab4yhz
|       |-- py-bottleneck-1.3.7-vujp3lb
|       |-- py-cftime-<IP_ADDRESS>-u5ynnu6
|       |-- py-cython-0.29.36-mcygbos
|       |-- py-et-xmlfile-1.0.1-r5ciajp
|       |-- py-f90nml-1.4.3-onzcpnd
|       |-- py-jinja2-3.1.2-lztju66
|       |-- py-markupsafe-2.1.3-zvr5vyb
|       |-- py-netcdf4-1.5.8-s6f2jr6
|       |-- py-numexpr-2.8.4-7mnnn6m
|       |-- py-numpy-1.22.3-cno4omf
|       |-- py-openpyxl-3.1.2-linbxew
|       |-- py-pandas-1.5.3-sfxry7w
|       |-- py-pip-23.1.2-m6hoiay
|       |-- py-python-dateutil-2.8.2-ks25p6r
|       |-- py-pytz-2023.3-y7ddjqn
|       |-- py-pyxlsb-1.0.10-3edchs2
|       |-- py-pyyaml-6.0-5dvlfax
|       |-- py-setuptools-63.4.3-rdcklus
|       |-- py-six-1.16.0-5wokqhr
|       |-- py-xlrd-2.0.1-6siatx7
|       |-- py-xlsxwriter-3.1.7-wecdmvp
|       |-- py-xlwt-1.3.0-fsq2khq
|       |-- python-3.10.13-3hws57v
|       |-- readline-8.2-nnpkmvt
|       |-- scotch-7.0.4-anqn7jy
|       |-- snappy-1.1.10-uzqxr54
|       |-- sp-2.5.0-467dlxb
|       |-- sqlite-3.43.2-j66erd5
|       |-- ufs-pyenv-1.0.0-fo3e4py
|       |-- ufs-weather-model-env-1.0.0-mhkdutq
|       |-- util-linux-uuid-2.38.1-4pzbp2b
|       |-- w3emc-2.10.0-2ju7vr6
|       |-- xz-5.4.1-eeftbzz
|       |-- zlib-1.2.13-pjmzzzk
|       `-- zstd-1.5.2-lklbosf
`-- modulefiles
    |-- Core
    |   |-- bacio
    |   |-- bzip2
    |   |-- c-blosc
    |   |-- cmake
    |   |-- crtm-fix
    |   |-- curl
    |   |-- expat
    |   |-- fargparse
    |   |-- g2
    |   |-- g2tmpl
    |   |-- gdbm
    |   |-- gettext
    |   |-- gftl
    |   |-- gftl-shared
    |   |-- git
    |   |-- git-lfs
    |   |-- hwloc
    |   |-- ip
    |   |-- jasper
    |   |-- krb5
    |   |-- libaec
    |   |-- libbsd
    |   |-- libedit
    |   |-- libevent
    |   |-- libffi
    |   |-- libiconv
    |   |-- libjpeg-turbo
    |   |-- libmd
    |   |-- libpciaccess
    |   |-- libpng
    |   |-- libxcrypt
    |   |-- libxml2
    |   |-- libyaml
    |   |-- lz4
    |   |-- m4
    |   |-- ncurses
    |   |-- nghttp2
    |   |-- numactl
    |   |-- openblas
    |   |-- openmpi
    |   |-- openssh
    |   |-- openssl
    |   |-- perl
    |   |-- pkg-config
    |   |-- pmix
    |   |-- py-bottleneck
    |   |-- py-cftime
    |   |-- py-cython
    |   |-- py-et-xmlfile
    |   |-- py-f90nml
    |   |-- py-jinja2
    |   |-- py-markupsafe
    |   |-- py-numexpr
    |   |-- py-numpy
    |   |-- py-openpyxl
    |   |-- py-pandas
    |   |-- py-pip
    |   |-- py-python-dateutil
    |   |-- py-pytz
    |   |-- py-pyxlsb
    |   |-- py-pyyaml
    |   |-- py-setuptools
    |   |-- py-six
    |   |-- py-xlrd
    |   |-- py-xlsxwriter
    |   |-- py-xlwt
    |   |-- python
    |   |-- readline
    |   |-- snappy
    |   |-- sp
    |   |-- sqlite
    |   |-- tar
    |   |-- util-linux-uuid
    |   |-- w3emc
    |   |-- wget
    |   |-- xz
    |   |-- zlib
    |   `-- zstd
    |-- module-index.yaml
    `-- openmpi
        `-- 4.1.6-bazsoby

so as you can see spack ended up putting all compiler-only modules (i.e. that don't depend on openmpi) under Core - that typically only happens if the compiler you used is also set as the "core" compiler in the module config. We set the core compiler to something super ancient<EMAIL_ADDRESS>or so) because hopefully nobody will ever attempt to build code with<EMAIL_ADDRESS>in 2024. See https://github.com/JCSDA/spack-stack/blob/2605d043ed937150fd6b090501a230fbcd568772/configs/common/modules_lmod.yaml#L12
Maybe you have a mismatch between TCL and LMOD?
I think the linux.default site config uses tcl, which means it copies configs/common/modules_tcl.yaml to /opt/spack-stack/envs/ufs.local/common/modules.yaml. In this case you also have to use spack module tcl refresh and not lmod.

@climbfuji Okay. Let me look at again. I'll update you if I found something or fix it. I am comparing with the manually installed container that works fine but I could not find any difference at this point. Maybe I am missing something. Again thanks for your help.

@uturuncoglu Any update on this issue?

@climbfuji Sorry I did not update you about it. I switch to tcl as you suggested and that solved the issue. I am not sure how I made it to work with lmod in the first place and could not reproduce it. That is still mystery for me. Anyway, the issue is solved now. I also create a simple wrapper script as a part of the UFS Coastal project to install the dependencies. You could find it in here,
https://github.com/oceanmodeling/ufs-coastal-app/blob/main/build_deps.sh
At this point., I only tested it on Docker container and it still need some work to make it work on supported platforms and also other systems. Thanks again for your help. I think we could close this since I fixed the issue in my end.

Great, thanks for your feedback!


uninstalled packages during installing pinnochio using robotpkg

Hi,
I am using ubuntu 18.04, and I tried installing pinocchio using robot-pkg with python 3.6. I then tried to import pinocchio, but turns out that libhpp-fcl and octomap were not installed during the pinocchio installation. Problem was solved by manually reinstalling the two packages as:
sudo apt install --reinstall robotpkg-hpp-fcl
sudo apt install --reinstall robotpkg-octomap
I thought this might be helpful for someone who had a similar problem.

They should be installed along with pinocchio. @nim65s Could you provide some feedback on this issue?

@nim65s ping.

I don't unsterdand this issue, as this is working for me in a clean container:
root@5e832ab87bff:~/robotpkg# apt depends robotpkg-py36-pinocchio
robotpkg-py36-pinocchio
 |Depends: robotpkg-py36-hpp-fcl (= 1.4.5)
 |Depends: robotpkg-py36-hpp-fcl (= 1.4.4r1)
 |Depends: robotpkg-py36-hpp-fcl (= 1.2.1)
 |Depends: robotpkg-py36-hpp-fcl+doc (= 1.2.0)
 |Depends: robotpkg-py36-hpp-fcl (= 1.4.4)
 |Depends: robotpkg-py36-hpp-fcl (= 1.4.2)
 |Depends: robotpkg-py36-hpp-fcl (= 1.2.0)
 |Depends: robotpkg-py36-hpp-fcl (= 1.3.0)
  Depends: robotpkg-py36-hpp-fcl (= 1.2.2)
 |Depends: robotpkg-py36-eigenpy (= 2.3.0)
 |Depends: robotpkg-py36-eigenpy (= 2.4.0)
 |Depends: robotpkg-py36-eigenpy (= 2.2.0r1)
 |Depends: robotpkg-py36-eigenpy (= 2.4.3)
  Depends: robotpkg-py36-eigenpy (= 2.2.0)
  Depends: robotpkg-pinocchio (= 2.4.7)
 |Depends: robotpkg-octomap (= 1.6.1)
  Depends: robotpkg-octomap (= 1.9.0)
 |Depends: robotpkg-hpp-fcl+doc (= 1.4.2)
 |Depends: robotpkg-hpp-fcl (= 1.4.2)
 |Depends: robotpkg-hpp-fcl (= 1.4.5)
 |Depends: robotpkg-hpp-fcl+doc (= 1.4.4)
 |Depends: robotpkg-hpp-fcl+doc (= 1.4.5)
  Depends: robotpkg-hpp-fcl (= 1.4.4)
  Depends: libboost-python1.65-dev (>= 1.34.1)
  Depends: libstdc++6
  Depends: python3-numpy (>= 1:1)
  Depends: python3.6-minimal (>= 3.6)
  Depends: python3.6-minimal (<< 3.7)
  Depends: libpython3.6-dev (>= 3.6)
  Depends: libpython3.6-dev (<< 3.7)
  Depends: libtinyxml-dev (>= 2)
  Depends: liburdfdom-dev (>= 0.2.8)
  Conflicts: robotpkg-py36-pinocchio
  Replaces: robotpkg-py36-pinocchio

OK. I will close this issue then. Thanks for your feedback @nim65s.


Don't apply any text encoding to binary input data

This fixes barcode generation for arbitrary binary input failing entirely or producing incomplete/incorrect results.
Observed for example with Hungarian domestic railway tickets (zlib compressed data in PDF417).

I have not looked into why this CI test fails. Have you?

Should hopefully be fixed now, the decoder side and the test data were both also applying UTF-8 for BINARY data.

First I thought, there might very well be something off with the encoder because I did not spend too much time and thought in this area. Now that I see what you changed on the decoding side I believe I understand the issue. My current mental model says that the code is correct as it is. The problem is that you used the PDFEncoder incorrectly.
For the decoder, the API is defined to return UTF8 encoded bits in the Result::text() property, independent of the ECI that was used inside the symbol. If you need the raw bytes, use Result::bytes(). The encoding side does not have an equivalent of the raw bytes channel, the only API available takes a UTF8 encoded string as input. That means if you wish to store a number of random bytes inside the symbol, you'd need to convert them to UTF8, then pass that to encode which internally will recode them into whatever the characterset is specified (or a default). I have not checked if that actually works this way currently.
I understand that this is not very user friendly and also counter intuitive but your change would break the API as specified. We could add some kind of encodeBytes function that does what you'd like. It might also be worth checking out how @gitlost serves this use case in libzint. In that regard it is also related to the still open #332.

For reference, that's the user code in question: https://invent.kde.org/frameworks/prison/-/blob/master/src/lib/pdf417barcode.cpp - this used to work for binary content pre-2.0 as-is.
I'll try if applying UTF-8 encoding to the binary data works, but that sounds very wrong and error-prone.

I'll try if applying UTF-8 encoding to the binary data works, but that sounds very wrong and error-prone.

No luck so far, I either end up with an exception going back to an zueci_utf8_to_eci error, or I get an incomplete output.

I'll try if applying UTF-8 encoding to the binary data works, but that sounds very wrong and error-prone.

No luck so far, I either end up with an exception going back to an zueci_utf8_to_eci error, or I get an incomplete output.

I would believe you would need to use the encode(std::string) overload and then basically do what zueci_encode_utf8 does. If that does not work I'm either missing something or there is a bug.
I checked how zint handles this. The library treats every input as UTF-8, except when the --binary switch is present. I think that is basically equivalent to my encodeBytes() idea above.
I could personally also live with a 'hack' that is somewhat similar to your approach above with the difference, that it would only be triggered if there is an explicit use of CharacterSet::BINARY. The way the default is set right now, your code would always be triggered.

Using the std::string overload of encode() seems to truncate at the first null byte (in FromUtf8() in MultiFormatWriter::encode). Using Qt's UTF-8 codec instead gets through null bytes but also doesn't produce something that survives the roundtrip.
Bypassing this by using the std::wstring overload then results in ToUtf8() in TextEncoder::GetBytes() messing things up.
Updated the PR to a more minimal version that only applies to BINARY mode.
And yes, I agree that an explicit API for binary data would probably be best.

In my above mentioned mental model the TextDecoder must not be modified. To make sure this would actually work in the end I started digging into the current implementation trying to really understand where exactly your use case breaks. And now I believe the way you use the writer in your above linked user code should indeed work. Would it be possible for you to provide a (smallish) example of your binary input that actually fails your round trip test?

Correct, my problem is also fixed without the TextDecoder changes, those are only needed to restore the symmetry expected by the unit test.
I don't have a minimized test case unfortunately, but I'll send you the full 202 byte sequence that fails here.

Thanks for the data. I think I have an idea what is going wrong. Your user code std::copy(b.begin(), b.end(), std::back_inserter(input)); casts a signed char to a signed int (on a Linux machine), so the value 0x8b becomes 0xffffff8b instead of simply 0x8b. This leads to invalid unicode codepoints and results in the error in the zueci code. If you do the following instead:
		for (uint8_t c : b)
			input.push_back(c);

it should work, at least the bailing out of the zueci code stops.

No luck with that so far, still the same "Unexpected charcode" exception. However, this does make a difference in the input data, now each character is indeed between 0 and 255 as one would expect, checking the same on the previous code fails (contained chars < 0, as you pointed out). So that's definitely a step in the right direction.
I'll do some more checking tomorrow to be sure we don't mess up the input data anywhere else.

No luck with that so far, still the same "Unexpected charcode" exception.

I know what is missing (forgot to mention it): you need to explicitly specify the character set:
		writer.setEncoding(CharacterSet::BINARY);

Ah, that works!
Thank you very much for the help, and sorry for (again) having bothered you with what turned out to be a bug on our side!


[CMT-305] Announcements - Proposal Fund Builder First Legal Activism DAO

https://github.com/yearn/yearn-comms/pull/638


build: use more portable offsetof

When building for Windows, when using offsetof in a C++ context, we
would use a reinterpret_cast, which is not permissible in the context
of a constexpr statement which we do use.  Use a CRT specific macro to
use the __builtin_offsetof version of the implementation.  Repairs the
Windows stdlib build with the new include path handling.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge

@swift-ci please test and merge


Clean up circular class references

Converted 'instance' classes to datatypeProperties and removed host/pest duplication, using domains.
Deleted proto-attempt at creating vocabs.

I notice that you have multiple domain constraints on some properties. In RDFS these are combined with AND, so
              rdfs:domain :Host , :TargetPest ;

implies that the subject of an instance of this property is a member  of both :Host and :TargetPest classes - i.e. there is a class intersection.
If you want to allow this property to be either :Host or :TargetPest then you have to create a UNION class. It can be anonymous, but it would look like this
  rdfs:domain [
      rdf:type owl:Class ;
      owl:unionOf (
          :Host
          :TargetPest
        ) ;
    ] ;

I've made a series of wording changes and then some property replacements to use DwC properties. Note that the definition changes all follow the Aristotelian pattern and are consistent with the ontology constructs, i.e. the words match the OWL.

I notice that you have multiple domain constraints on some properties

Thanks Simon, right on the money!


Update MAINTAINERS to reflect reality.

Things have changed a bit now. 🙂
Signed-off-by: Flynn<EMAIL_ADDRESS>

@LukeShu I left it plural because it's a table of people that happens to currently have just one row. 🙂


Schema issues.

Fix purchase items data ingestion
and item ids schema for user recommendations

Hi @LuisCabrer, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (luisca). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


apt: Disable etckeeper hooks

This completely disables apt integration for etckeeper, because it creates
different commits on each server, making their histories diverge.
If we do this, we must commit (sic) to using to automation for handling the shell servers' configuration, especially for package installs.
NOTE: Do not merge yet, I'm not sure how we should deal with package upgrades that change their conffiles...

Nevermind, we have to think of something better.


Allow overriding build message on forked builds

This is a feature we've desired for some time now. It would be useful to have the ability to set the build message to something resembling:
Build forked from owner/parent-image #4
I've tested this locally and works with the existing cli, specifying the message as a parameter:
drone build start --fork -p message="new message" owner/child-image 3

I like this functionality, but is this really enough to get displayed in the ui?

Yes it is actually. Any parameters that are specified in the API request are available in the context. I spent a good half an hour tracing through the various code trying to work out how it could be done.


Modify Person Class

Modify Person Class to suit HEY MATEz

Removed Tags attribute
Removed Address attribute
Removed and modified relevant test cases

Codecov Report

Merging #65 (7c31008) into master (fa67966) will decrease coverage by 2.98%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
- Coverage     63.80%   60.82%   -2.99%
+ Complexity      413      383      -30
============================================
  Files            80       80
  Lines          1456     1386      -70
  Branches        153      137      -16
============================================
- Hits            929      843      -86
- Misses          490      510      +20
+ Partials         37       33       -4

Impacted Files
Coverage Δ
Complexity Δ

.../seedu/address/logic/parser/EditCommandParser.java
100.00% <ø> (+7.69%)
6.00 <0.00> (-5.00)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
54.76% <ø> (-21.84%)
9.00 <0.00> (-5.00)

.../java/seedu/address/model/util/SampleDataUtil.java
0.00% <ø> (-20.00%)
0.00 <0.00> (-1.00)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...c/main/java/seedu/address/model/person/Person.java
96.66% <80.00%> (-0.96%)
15.00 <1.00> (-5.00)

...java/seedu/address/logic/commands/EditCommand.java
96.36% <100.00%> (-0.66%)
12.00 <0.00> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)
5.00 <0.00> (ø)

.../java/seedu/address/storage/JsonAdaptedPerson.java
100.00% <100.00%> (ø)
9.00 <1.00> (-2.00)

...ain/java/seedu/address/storage/JsonAdaptedTag.java
0.00% <0.00%> (-100.00%)
0.00% <0.00%> (-5.00%)

src/main/java/seedu/address/model/tag/Tag.java
30.00% <0.00%> (-50.00%)
2.00% <0.00%> (-3.00%)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa67966...7c31008. Read the comment docs.


Getting Started: Connect to MySQL Database using Spring Data

This is my try for a Getting Started Guide for connection with MySQL
Issues:

MySQL is GPL'd, so I think that all code using it must be also GPL'd

These are some of the requested changes. Thanks for reply.

Now made the changes you wanted + some polishing

Merged and re-pushed as https://github.com/spring-guides/gs-accessing-data-mysql. Thanks. Please send change requests to that repo.


Fix inline style key collision

Fix for #28
Uses lodash.assignWith to merge overlapping inline style in order to detect collision in keys

Finally got around to consider this while this solves text-decoration case it might introduce problems with styles that shouldn't be merged like let say font-weight.
consider:
BOLD: {
  fontWeight: 600,
},
STRIKETHROUGH: {
  fontStyle: 'italic',
  fontWeight: 400,
}

Merging this would cause something like font-style: italic; font-weight: 600 400; which would be an invalid style. (not saying this example makes real life sense)
I decided to check how draf-js handles this case. If you look at about here https://github.com/facebook/draft-js/blob/8f0769c3f9a42e92e2589a3850c9491c66f08ad9/src/component/contents/DraftEditorLeaf.react.js#L149 you can see they treat textDecoration key as a sort of special case.
I guess probably it would would be best to handle this in a similar (same?) way.  Any thoughts?

Yeah, handling textDecoration as a special case is better. I didn't look further than the issue we were having, thanks for taking the time to investigate!
I'll update my PR

Looks good. 👍
I'll probably publish a new release later this week.


Corruption test fails

I finally managed to compile this under MinGW and found that the corruption test doesn't pass (all others are OK). The funny thing is that it doesn't pass because with the current design it is not possible to corrupt the data in the way the test tries, i.e. it is not possible to read/write already opened files with the current combination of CreateFileW flags in env_win.cc.
Is this expected? Do you have the same result?
I post the issue here because this file was created in this repo and not in the upstream.

Is this fixed by #17 (which has been merged)?

Have no idea, stopped trying to use LevelDB long time ago.


How to use doxygen?

Hi guys, I happened to find that the doxygen has been supported, however it doesn't work for me.
Can I expect the same thing like doxygen notes ? Or can you share some snippets to show how can I use doxygen with this lib?
Thanks!

Swift-Markdown supports a very limited set of Doxygen commands, specifically just \discussion, \note, \param, and \returns. To parse them from the library API, pass .parseBlockDirectives and .parseMinimalDoxygen for the options parameters in Document.init(parsing:source:options:) or Document.init(parsing:options:).

Thank you, it works!


SGB: Adding 9/26 minutes

@breckbaldwin, can you take a look?

@breckbaldwin, I merged. I gave it another read.
@bob-carpenter, I'll keep lines down to 80 char after this PR.


[Media] Adding additional customization files

Updated public swagger link and added MediaGraphNodeInput.cs and MediaGraphPemCertificateList.cs

LGTM

LGTM


Bug: 1.12.2 Flickering fog

OTG Plugin or Mod

[X] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[X] 1.12.2_v9_r11

Forge or Spigot Versions
forge-<IP_ADDRESS>54
Description
Whenever the ViewDistance is set beyond 16 the fog starts flickering on player movement. The higher you set the viewdistance the more it can be noticed as seen in the following gif:
https://gyazo.com/dea962663e8fe21ade9c10be7bae3f78
Here's a testworld:
DregoraTestMod.zip

Thanks for reporting this, will definitely keep an eye out for this for 1.16.5, for 1.12.2 we won't be fixing this, unless someone does a PR.


Provide HttpOnly option

The HttpOnly flag is being set to false in the CookieListener. Please expose HttpOnly as a config option.

Nevermind, RTFM on cookies. :)


Cut a new release?

It looks like master now supports a few new features like:

putting column encodings as parameters in the table declaration
allowing sortkey/distkey to be defined in the table declaration
parallel unloading of statements

According to PyPI the last release was Jan. 14, any chance you can cut a new release?
(Sorry to nag since I think I also requested the Jan 14 release :)

+1 would be nice to release this with the updates

I've cut a new release called https://pypi.python.org/pypi/sqlalchemy-redshift/


Asynchronous BFS Interface & Implementation

Cleaning up the original async_bfs branch

Compatability changes for current essentials/master branch
Better integration w/ standard essentials APIs -- same param_t, result_t, and problem_t structs; same run interface
Uses an async_enactor_t instead of enactor_t -- much of the functionality in enactor_t is pretty "frontier" specific.  We could possibly implement a queue as a special kind of frontier, and integrate even more tightly.  However, not sure if it's necessary at this point, since this is ~ proof-of-concept phase.
CPU baseline + correctness checking

More comments in line
Future work: This only implements one of the three async methods (thread).  This is the simplest, but had the worst performance in the paper.  But I think this is likely at a point where someone could implement the other (more complex and more performant) async methods.

Leaving my comments there, I am gonna do a minor clean-up and keep this under experimental namespace.


[FEATURE REQ] Swift Package Manager (SPM) support for AzureCommunicationCalling

Is your feature request related to a problem? Please describe.
We are using Swift Package Manager for our dependency management and would like to use AzureCommunicationCalling like this as well. This would help us avoid CocoaPods bloat and make it simple to add the library to our project. Swift Package Manager is also the new leading standard in including libraries on iOS.
I incorrectly assumed that SPM is already supported for this library, due to it being mentioned on this page.
Describe the solution you'd like
Adding the AzureCommunicationCalling library to an iOS project via Swift Package Manager.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

Hi @Svantulden we are already tracking SPM support for Calling here: https://github.com/Azure/azure-sdk-for-ios/issues/828
@raosanat is there a reason the link provided claims SPM support?
https://azure.github.io/azure-sdk/releases/latest/ios.html

Thanks for linking that issue @tjprescott, I had searched the issues for 'SPM' and 'Swift Package', but not 'SwiftPM'.
It seems like the library won't support SPM for some time, due to the issues with linking Objective-C (binary) & Swift dependencies for the package. So it's dependent on transitioning the Calling library to Swift or new insights/features in the Swift package system.
To prevent having to use CocoaPods for the library, we also tried using the direct approach as a workaround and include the release as .xcframework in our project (from the link that is in the binary CocoaPods podspec) and linking the Common library via SPM.
However this has two issues:

The XCFramework provided doesn't seem to have Module Stability so I'm getting a Failed to build module 'AzureCommunicationCalling'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.7.2 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>)', while this compiler is 'Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)'). Please select a toolchain which matches the SDK. error
Probably the same issue will occur here as in getting SPM support implemented, where the Objective-C headers for the SwiftPM Common library won't be found

Do you have any ideas for a short(er) term solution?

Hi @Svantulden,
Unfortunately using calling as .xcframework and installing common using SPM is not going to work AzureCommunicationCalling because it is an Objective-C framework and Swift Package Manager deliberately do not support Swift ObjC interface headers by design(see more here) which means is not possible to work together with AzureCommunicationCalling if installed using Swift Package Manager.
So common would have to be installed using another dependency manager either Pods or another approach.
That is a bit of a hack but since  AzureCommunicationCommon is open source but it doesn't distribute a .xcframework, to make it work would be possible to build an xcframework from source and import both AzureCommunicationCalling and AzureCommunicationCommon as .xcframework.

@lucianopa-msft
Is there a repository for AzureCommunicationCalling that I can install the dependency via SPM?
I confirm that there are repos for AzureCommunicationCommon and AzureCommunicationChat but not AzureCommunicationCalling.
Thanks in advance.

Hi @pa-akiya-ozawa,
Unfortunately there isn't, as mentioned before we still don't have support for SPM on AzureCommunicationCalling since we are still an ObjC binary framework.


Misleading error message in exception from Statement::exec

If Statement::exec is executed with mbDone set to true then an exception is thrown with the correct error code SQLITE_MISUSE returned from tryExec but the error message is "not an error"

Good catch, thanks for reporting it!

@alanbirtles How does it happen? Did you mention this function?

just execute a statement twice without resetting it


AudioTweaks: allows seperate adjustment of BGM / SFX / cutscene volume

As requested at #199, went ahead and added volume sliders to a new Audio section in the re4_tweaks UI too (who knows, maybe we'll figure out more audio fixes eventually 😄)
Most kinds of audio can have volume adjusted at runtime, but it seems BGM usually needs to be reloaded first (eg by reloading the level), also added a note about that to the UI.
I'd guess the volume values we're adjusting here probably get copied somewhere when that audio starts playing, maybe there's some way to track down where & adjust the volume as it plays (looks like the values might be getting transformed a little first though, so might take some work...)
FMV cutscenes seem to use some Criware audio system instead of the stuff main game uses, but luckily wasn't too hard to adjust that as well.
Seems to work across all the usual EXE versions, haven't tested it that much in-game yet though, would appreciate hearing from anyone that tries it out! (build artifact available at https://github.com/nipkownix/re4_tweaks/actions/runs/2457817918)
Some earlier notes that might still apply:

not totally sure if all sounds will be affected by it though - would be interested if anyone finds something that doesn't work with it.

there's also 3 different values for both BGM/SE as well, not completely sure I'm changing all the correct ones, so if you notice some sound effect changing when you adjust BGM, or vice-versa, let me know

E: as noted in the issue linked above, looks like cutscenes don't have BGM/SE separated properly for some reason, all sounds end up being controlled by str_se value... maybe this is part of why they never added audio options themselves.
Looks like  BGM/SE both go through the same func to fetch the volume, but a flag check decides what kind it is, maybe there's some way to set up that flag on the cutscene BGM.
E2: looks like that flag originates inside bio4str.hed :/ Not sure if the format for that is documented anywhere.

Added a workaround for the cutscene audio, seems str_se is mostly only ever used by cutscenes, so moved that over to be affected by BGM slider instead.
Only issue I've noticed is merchant dialog now gets affected by BGM slider too, I guess maybe that's handled same way as cutscenes, not sure if there's any way to change it...

Seem to have volume adjustment during playback working, for the str_* sounds at least, this seems to let us adjust BGM & cutscene audio fine.
I think certain currently-playing effects still aren't updated though, but since effects don't play for that long it's not a huge issue IMO.
Build artifact at https://github.com/nipkownix/re4_tweaks/actions/runs/2463654847

Should have the issue with BGMs fixed, now hopefully all BGMs should be adjustable during playback 😄
Build artifact at https://github.com/nipkownix/re4_tweaks/actions/runs/2464507044

Well there is one small thing I'm not really sure about yet, the mas_bgm/mas_se values, it looks like those are master values which the other values are then multiplied by, initially I updated those as well, but removed that so we could have finer control of the other values.
Right now though when the game changes those mas values itself (SndSubScreenInit), our Snd_set_system_vol_Hook will store the value the game is setting, and then scale that value by the users volume setting to find the new value for str_se/iss_se/etc.
If the game is scaling those str/iss values by mas already though, this would probably end up scaling it by mas twice - SndSubScreenInit sets mas to 1/2 of normal value, so our UpdateVolume then scales eg. iss_bgm by 1/2, and then the games volume calc code scales iss_bgm by mas, maybe ending up at 1/4 of volume?
I'm not totally sure how the mas scaling works though, when I first started playing with this it didn't seem like mas influenced the volume at all, but the code does show it's being added in somehow...
Eh, I'll try having a closer look at it later on, maybe can just remove the code that scales by what game tried to set.

Looks like the volume in subscreens was definitely lower with this hook at 100% compared to vanilla game, went ahead and removed the stuff to scale by value set by game, seems better now.
If game ever updated iss/str volumes itself then the code for storing that & scaling user volume level by it would probably be useful, but seems game only ever updates the mas volume, and since it seems game is already applying scaling for that itself already we don't really need to bother with it.
New build artifact at https://github.com/nipkownix/re4_tweaks/actions/runs/2475491191

Should be good to merge now, haven't had any issues in the few times I've tested with it at least.
Only thing missing now is some way of changing volume of certain effects during playback (eg. the sound that game makes as it fades into main menu, not really sure how that sound is being played atm...), but like mentioned before those effects don't seem to play for that long, so not a big deal, but would be nice to eventually get them adjustable...

Thanks!


docs: fix up documentation on read

I noticed that our documentation on read was incorrect in terms of
how it distinguished adapter options from the filter expression.
I also updated the documentation on from / to / last to match the
new semantics.

@dmehra

+1


Weather support

~weather [place] [optional country] Would be perfect

added, its ~we city country


refactor: Upgrade image versions

Hello @buchdag ,
Thank you for the great repo, with a few touches it worked like a charm on arm64 structure.
There were two issue:
1 - There was a openssl version update after alpine:3.8, for now i just upgraded to 3.9 because latest gave some strange error.
2 - The second was one of golang deps used some new syntax only valid on golang 1.13,
i have made required changes. If it looks good you can merge it.

Thanks for the contribution @unicod3 😃

By the way:

There was a openssl version update after alpine:3.8, for now i just upgraded to 3.9 because latest gave some strange error.

The error you encountered might have been caused by this change in alpine:3.12 (the installation of simp_le requires pip).
My guess is that alpine:3.11 will probably work fine (it's the current alpine version used in the upstream companion image).


Can Elyra DS pipelines work at all in Disconnected Environments? #127

Description of problem:
Possible/practical to use DS pipelines in disconnected environments?
I'm looking at some of the tasks (generated by Elyra) and there is a bunch of "curl this file from github" and "pip install some more things".
JIRA: https://issues.redhat.com/browse/RHODS-9427
JIRA: https://issues.redhat.com/browse/RHODS-10967
Creating a duplicated issue of  https://github.com/opendatahub-io/notebooks/issues/127   as i am  not able to reopen and the issue was not fixed

Closing this duplicate issue.

@mwaykole thank you for also thinking of this, nice.
I am linking the post in the related issue that I think summarized the main remaining tricky config issue that you found out about
https://github.com/opendatahub-io/notebooks/issues/127#issuecomment-1709547310

The changes mentioned in the PR.
There wont be any runtime install of python package , all the required pre-requisite packages
are preinstalled on the packages.
If a user, want to install python packages, they can use pip , and provide
their pypi index URL via PIP_INDEX_URL.

Closing this issue as complete

@harshad16 - Can you confirm if there is a documentation requirement for this work? Do the docs need to be updated as a result of ensuring that Elyra works with a disconnected setup?

Yes @chtyler , there is a docs requirement.
We should connect over this.

@harshad16 - I have created https://issues.redhat.com/browse/RHODS-12962 to cover this docs work. We can discuss this tomorrow.


[$500] LHN shows tag as<EMAIL_ADDRESS>instead of @person

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707498095462179
Action Performed:

Go to any public room
Mention any user in the message

Expected Result:
LHN should show @person
Actual Result:
Shows as<EMAIL_ADDRESS>Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017c3d81a0688971b8
Upwork Job ID:<PHONE_NUMBER>853744640
Last Price Increase: 2024-02-09

Can I get confirmation of this behaviour?
We are explicitly coding to display the users login info in the composer after picking the user, not the display name

Is this a bug?
I find client side support for this here: https://github.com/Expensify/App/pull/26877
But no record of the api sending the account_id or the client setting the account_id to map to @person

Proposal
Please re-state the problem that we are trying to solve in this issue.
Show @Person mentions in LHN
What is the root cause of that problem?
Seems we have no accountID on the  html object we send and retrieve.
What changes do you think we should make in order to solve the problem?
We can start sending the accountid of the mentioned user inside the  node so that https://github.com/Expensify/App/pull/26877 works as expected.
What alternative solutions did you explore? (Optional)

Not overdue. Will look at this more today

Discussing

Confirmed in Slack that this should be fixed by https://github.com/Expensify/Expensify/issues/313934 , closing in favor of that issue!


Fix build and pack as .NET tool

Adjust target frameworks.
Migrate current projects to 4.7.2, add also to target framework in projects referencing these.
Rework referencing projects to get proper referencing.
Fix output type of TFConvert to output executable.
Add hack to allow package as .NET tool despite being able to run only on windows.
Add check for running on Windows platform.
Move properties to package as tool to main project.
Assembly name, package id and tool command name are now all lower case and the same for consistency.

Yes, I can see the same here when trying to install... will try some workarounds in the coming days
As for the testing I comment out those who weren't possible to run because of the change to the new target framework. Most likely they just need some tweak or minor rework. Didn't spent much time on it.

This is defenitly not working at all!
I'm thinking that another approach could be to have the CLI build as a .NET tool, but instead of TFConvert being the tool it would be instead a wrapper that would call the "original" TFConvert CLI that can be build as usual (just that updated to the latest .NET Framework version).


Adding documentation for using the async connection pool...

Formatted to work in the REPL so perhaps it could be adjusted some for doc purposes.

Thanks!


Refactor the code

Currently the code is a mess, functions are coupled, image upload function calls clipboard writing function.
The design is too bad.
I will refactor the code once I got time.

https://github.com/HuakunShen/EzUp/pull/10
Done


Waypoint: Set the Font Family of an Element

"class='red-text'" is omitted from the second paragraph when carried over from the previous waypoint. Quite insignificant but could be confusing to a beginner.

'red-text' class for second paragraph is not omitted it is just not required. Instructions of "Change the Font Size of an Element" Waypoint are very clear.


[cluster test] Use client side latency in cluster version of--emit-tx

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=andll

:pushpin: Commit e2cae5d has been approved by andll

:hourglass: Testing commit e2cae5db6b05b1ff08c55f376abb8acffa625133 with merge a033238461c467a7476004464380c85acb6e3f7f...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: andll
Pushing a033238461c467a7476004464380c85acb6e3f7f to master...


Fix Comment

Located in the main(): function
currently: # Main model (updated every step)
fix: # Main model (updated every 4 steps)

Merged in both pull requests


Version 8.1 (Included patches: 1-2234) breaks support for long paths

Describe the bug
When the path for the file being opened is longer than 66 characters, MacVim shows "Press ENTER or type command to continue." This is something that did not happen in previous versions. This does not happen in the terminal.
Environment (please complete the following information):

Vim version:
VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 30 2019 11:57:56)
macOS version
Included patches: 1-2234
OS: macOS Sierra (10.12.16)

IMHO, this is upstream with VIM. You should probably open an issue there.

@AmaruCoder if you open an issue in the upstream, please, link it back here

Issue opened in the upstream


Not working with jQuery 3

As part of updating our project's dependencies, I updated our version of jQuery from 2.2.4 to 3.1.1. At that point, the tour tips no longer appeared. I haven't untangled the root of the issue, but once I went back to jQuery 2.2.4, the tips worked again.
Based on the fact there is an open PR against the project to change the selection logic to use document.querySelector in place of jQuery, my guess is that it has to do with the selector logic.

@tvsbrent - Have you figured out the issue in relation to jQuery 3.1.1 yet?

@tvsbrent  @booleanbetrayal @DaftMonk
The issue stems from jQuery 3.1.1's .fadeIn not appending display: block; to the div.tool-tip container element. Setting tourConfig.animation = false; will get around this issue, but you lose fade in capability.


Extract null span context

According to the opentracing specification, null may be returned instead of a SpanContext by Tracer->extract(). This PR adds this behaviour and prevents ugly warnings in Jaeger, which complains about invalid span references:

How did you got this warnings, show your step and code.
You should add test for null result

Hm, to be honest, I cannot quite reproduce it with my setup anymore. Maybe it was a caching condition on my side.
Anyways, I added the suggested test cases.


References namespaces in phpseclib - but phpseclib doesn't use namespaces...

I installed the software, tried to run the keygen.php example prog, but it refers to phpseclib - which it doesn't include, so downloading and adding some 'require_once' lines I find it openpgp-php refers to phpseclib namespaces that phpseclib doesn't use/define...
From a baseline install what is the minimum required to get the samples running?

Did you install dependencies using composer?

No, I've never used composer. Can it work with out it?

I've tried to prevent it from being a full dependency, but you will need to set up an autload file like composer would, or else require things in a similar way

It is brilliant work, really appreciated.
I just need to work out something that can de-composerify source code! Maybe auto adding namespace stuff to source files - I'll have to find out more.
Cheers

I have hacked it a bit to get it going removing namspace references and removing some clashing names - plenty good enough for my 'proof of concept'
Thanks again.


Low inference speed

Dear author, thanks for your excellent work，but when I run 'python webcam.py --trt=……'，it's inference speed  (about 1.4s) is much lower than none trt file (about 0.7s). How can I speed up the inference speed when I use trt file?
Look forward to your reply！

Hi @RoseWillow, I've moved the actual development of this project into the new repository: https://github.com/Kolkir/Coarse_LoFTR_TRT. Please take a look at it, I've published model weights, ONNX and TRT engine. However, I also noticed the there is no much performance difference in running TRT or raw PyTorch models, I guess the reason is that the transformer model architecture is not very compatible with TRT. But in my environment there is no such performance gap as you said, I have about 5 FPS on Nvidia Jetson Nano 2GB and about 50 FPS on GTX1060. Also, please notice that this is not the full LoFTR model but just the coarse part.

Hi @RoseWillow, I've moved the actual development of this project into the new repository: https://github.com/Kolkir/Coarse_LoFTR_TRT. Please take a look at it, I've published model weights, ONNX and TRT engine. However, I also noticed the there is no much performance difference in running TRT or raw PyTorch models, I guess the reason is that the transformer model architecture is not very compatible with TRT. But in my environment there is no such performance gap as you said, I have about 5 FPS on Nvidia Jetson Nano 2GB and about 50 FPS on GTX1060. Also, please notice that this is not the full LoFTR model but just the coarse part.

Thanks for your reply! I will have a try.

Hi @RoseWillow, I've moved the actual development of this project into the new repository: https://github.com/Kolkir/Coarse_LoFTR_TRT. Please take a look at it, I've published model weights, ONNX and TRT engine. However, I also noticed the there is no much performance difference in running TRT or raw PyTorch models, I guess the reason is that the transformer model architecture is not very compatible with TRT. But in my environment there is no such performance gap as you said, I have about 5 FPS on Nvidia Jetson Nano 2GB and about 50 FPS on GTX1060. Also, please notice that this is not the full LoFTR model but just the coarse part.

Thanks for your reply! I will have a try.

hi， @RoseWillow ，have you solved the problem of slow reasoning. I have the same problem now.

https://github.com/Kolkir/Coarse_LoFTR_TRT

https://github.com/Kolkir/Coarse_LoFTR_TRT , you can try it!


Is it possible to have two listings or decompiler windows side by side?

I'm working with two different versions of the same binary; I currently have them in the same Ghidra repository and have them open. I can switch tabs easily enough, but it would be nice to be able to undock one of the listings and/or decompilers and display it side by side with the other, or have two listing windows instead of tabs. I don't mean diff view, just being able to see two listings simultaneously? Is this possible within Ghidra as currently implemented?

Sorry, I am dumb. I literally just discovered the snapshot button. It's too early in the morning...


Typed Plonk tests for Linearised and Non-Linearised Prover

Copied from PR https://github.com/AztecProtocol/barretenberg/pull/33

Original author: @suyash67
This copy uses branches with git history restored

Ported the PR changes from: https://github.com/AztecProtocol/aztec2-internal/pull/1414

This PR is now not needed with #135.


Interpreter display in footer shows python version not virtual environment name

After the most recent VS Code update I noticed a change in behavior regarding the interpreter display in the footer. When I select a virtual environment, I no longer see the environment name. Just the python version.
This may be Poetry specific as I notice regular venv's show up, however this did work before the update.
Environment data

VS Code version: 1.49.0
Extension version (available under the Extensions sidebar): v2020.8.108011
OS and version: MacOS 10.15.6
Python version (& distribution if applicable, e.g. Anaconda): Python 3.8.0 64-bit
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): poetry
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: Pylance (2020.9.4)

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour

The footer used to (unless I'm mistaken) show the virtual environment name of the selected interpreter.

Actual behaviour

Only the python version is displayed. Python 3.8.0 64-bit

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]
With poetry installed, and the venv folder added to settings.

Create a project poetry init
Install deps so virtual environment is created poetry install
Select the interpreter from the dropdown (sometimes you have to reload the window or restart code for it to be picked up).

The footer will say the python version of the virtual environment but not the name.

Hi @gmeans, thank you for reaching out!
I've noticed it happening before as well, it depends on which interpreter discovery code returns first. We're planning to address that as part of #12020, so I will be closing this issue and folding it into #12020.
Thanks!


Encourage making descendants of Aggregate and AggregatePart final

There cannot be such a thing as aggregate inheritance because there can be only one class that handles a type of a command. Therefore we need to encourage users to mark classes they create as final.
A Model Compiler can analyze Java code and issue warnings when classes derived from Aggregate or AggregatePart are not declared as final.

This may prevent spying on such classes in tests.


create generate file for protos to keep them synced

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.152%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1901

Relevant Lines:
3269

💛  - Coveralls


virt-handler: Disable gRPC server restart on client errors

The GRPC server shouldn't restart upon client side domain errors.
Update virt-handler to just log in case of domain event errors.
Application errors on any of the gRPC client endpoints should not
cause the restart and disconnection of the server endpoint,
which, in turn, resets all client endpoints.
This commit improves availability of the GRPC server, which servers
all the virt-launchers in the node.
When the gRPC server side has been restarted, it could not communicate
for a short period with the clients
(virt-handler and virt-launcher communication).
Found during investigation of #3575
Signed-off-by: Or Shoval<EMAIL_ADDRESS>None

/cc @AlonaKaplan @EdDev

@oshoval
I was poking in this area just now and I think i found a pretty big issue. [1]
I introduced logic that pipes a socket in virt-launcher pod to the domain notify socket called domain-notify-pipe.sock. The issue is, if the domain socket is reset (which definitely happens when one of these Errors come in) then the domain-notify-pipe is broken.  We never re-estabilish that part of the connection. meaning notifies for all existing vmis on that host stop indefinitely.
Basically, the dial in [1] needs to go into the for loop of [2] or else we're hosed when one of these error events come in.

https://github.com/kubevirt/kubevirt/blob/master/pkg/virt-handler/vm.go#L214
https://github.com/kubevirt/kubevirt/blob/master/pkg/virt-handler/vm.go#L222

I made #3818 to handle the reconnect issue. I still think the notion of reducing the Errors sent over this channel makes a lot of sense. So we should continue with this PR as well.

@oshoval
I was poking in this area just now and I think i found a pretty big issue. [1]
I introduced logic that pipes a socket in virt-launcher pod to the domain notify socket called domain-notify-pipe.sock. The issue is, if the domain socket is reset (which definitely happens when one of these Errors come in) then the domain-notify-pipe is broken. We never re-estabilish that part of the connection. meaning notifies for all existing vmis on that host stop indefinitely.
Basically, the dial in [1] needs to go into the for loop of [2] or else we're hosed when one of these error events come in.

https://github.com/kubevirt/kubevirt/blob/master/pkg/virt-handler/vm.go#L214
https://github.com/kubevirt/kubevirt/blob/master/pkg/virt-handler/vm.go#L222

Thanks, great one

Ignoring the error may not be correct.
/lgtm cancel

@davidvossel
I see in a test
i think i saw it before as well, (after the first take to fix it by updating grpc version),
does #3830 handles it ?
I dont see there domain event ERROR (which this PR changes behavior of)
{"component":"virt-handler","level":"error","msg":"domain pipe listener closed.","pos":"vm.go:225","reason":"accept unix /proc/17216/root/var/run/kubevirt/domain-notify-pipe.sock: use of closed network connection","timestamp":"2020-07-15T16:51:30.575588Z"}
{"component":"virt-handler","kind":"","level":"info","msg":"closing notify pipe connection for vmi: read unix @-\u003e/var/run/kubevirt/domain-notify.sock: use of closed network connection","name":"testvmiw5xzhm6nbxlm58fsr9c6hlrqvngt62l5wxdmtcvlxhhcvmwm","namespace":"kubevirt-test-default","pos":"vm.go:245","timestamp":"2020-07-15T16:51:30.575674Z","uid":"d451568b-c804-4411-a66f-f729b1a3a12b"}

/retest

@rmohr @davidvossel
Would you please take a look ?

/approve


[STREAM-245] - Don't hold other sessions if we're establishing an eager persistent connection.

REPRO:
Place outbound call and toggle queue as its connecting in an org with the FTs on.

I pushed a package-lock update to the demo app too because it was out of date.


wasm-bindgen interfaces for working with PrivateRefs

Internally, we're making use of PrivateRef. They're likely a good abstraction (and we've used it internally), so we should also have them in the wnfs-wasm interface.

This is implemented as of #159


Possibly Unexpected Slot Machine Display

問題說明 Describe the feature
當前老虎機顯示採用10個圖標的循環圖，根據代碼可能有潛在未預期的抽選(只影響顯示)

randomSlot() 僅會生成 1-9 的可能 (all different or one pair)
all same 事件只會產生 0-8 的可能( 根據 Math.random()∊[0,1) )
all same 事件可能與lightning有相同結果，造成明明 :zap: :zap: :zap: 卻不值 50 電電點

(此issue僅從 templates/slot.html 分析，可能有其他機制避免或此為預期，如有錯誤，在此先行道歉)
The current slot machine display uses an image of 10 icons cyclically.
Depending on the code, there may be potentially unexpected draws (only affects the display).

randomSlot() will only generate possibilities 1-9 during all different and one pair
Will only produce 0-8 possibilities during all same (according to Math.random()∊[0,1) )
May have the same result as lightning during all same, even if get :zap: :zap: :zap: but it doesn't worth 50 :zap~1:

(This issue is only analyzed from templates/slot.html. There may be other mechanisms to avoid this or this is expected. If I made any mistake, I apologize first)
Expected behavior

在 slot.png 的圖標都能正常顯示 The icons in slot.png can be displayed normally
:zap: :zap: :zap: 僅存在於lightning發生時 :zap: :zap: :zap: only exists during lightning

又 assign 給我，莫名其妙（

噢，按到了。


Add unlike option

Would it be possible to add an option to unlike tweets?
Thank you! And thank you for your awesome JS! It helped me a lot!

Would also massively appreciate this, since part of the point of deleting all tweets regularly is for privacy/security. That doesn't work so well if someone can still see your likes going back years. This project is extremely helpful nonetheless!

I've another project that does this : https://github.com/Lyfhael/UnlikeAllTweets :)


zs-old file left behind even if there is nothing to update

zs-old file is left behind even if there is nothing to update:
user@host ~ $ /home/user/Applications/AppImageUpdate-383-cf29501-x86_64.AppImage Downloads/Dia-0.97.2.glibc2.15-x86_64.AppImage
AppImageUpdate version 1-alpha (commit cf29501), build 383 built on 2018-11-11 13:03:03 UTC
Updating from Bintray via ZSync
zsync2: /home/user/Downloads/Dia-0.97.2.glibc2.15-x86_64.AppImage found, using as seed file
zsync2: Target file: /home/user/Downloads/Dia-0.97.2.glibc2.15-x86_64.AppImage
zsync2: Reading seed file: /home/user/Downloads/Dia-0.97.2.glibc2.15-x86_64.AppImage
zsync2: Usable data from seed files: 100.000000%
zsync2: Renaming temp file
zsync2: Fetching remaining blocks
zsync2: Verifying downloaded file
zsync2: checksum matches OK
zsync2: used 19359744 local, fetched 0

user@host ~ $ sha256sum Downloads/Dia-0.97.2.glibc2.15-x86_64*
20:33 <probono> f6e28fbe61b4801794c10c13f65c9ae2de99a2bdf80a1dcf8c694018bf0e707a  Downloads/Dia-0.97.2.glibc2.15-x86_64.AppImage
20:33 <probono> f6e28fbe61b4801794c10c13f65c9ae2de99a2bdf80a1dcf8c694018bf0e707a  Downloads/Dia-0.97.2.glibc2.15-x86_64.AppImage.zs-old

The title is incorrect. The issue here is that an update is performed although no update is needed. This is indicated by the line:
zsync2: Usable data from seed files: 100.000000%

The issue is in the Qt updater module, which doesn't perform the update check before starting the normal update routine.

You are totally right. I don't know what I was thinking.


Support explicit return value of unknown (#42)

Note: This is PR #42, but on a branch on this repo directly so I can help modify it.

getNextVal now returns object { found, nextVal }
Resolves #41

Hey what's the status on this PR?
This would be considered a breaking change since it seems to require updates to all of the uses of test engine

@hmillison Yeah I paused on this because I wasn't sure there is a way to accommodate both the current API and a solution to the request made in issue #41. Any feedback?


display lots of markers by canvas

I have more than 10000 markers  need add to map, but it displayed by dom and so slow, how can i display it by canvas ,and I know a plugin named Leaflet.Canvas-Markers can realize ,but this plugin canot bind popup ,so i gave up  this plugin ,Is there any other way to realize this requirement,thanks

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features.
For questions on using Leaflet, please use Stack Overflow or GIS Stack Exchange.
In your case, you would probably be interested in that post:
https://stackoverflow.com/questions/43015854/large-dataset-of-markers-or-dots-in-leaflet
If that does not fit your need, please feel free to open a new question on Stack Overflow.


feedback(list-item): start slot doesn't have default padding.

I forgot to set data-variant on md-list-item so it renders start without padding, maybe better to add the data-variant="icon" behavior as the default ?
Spec says padding is always 16 except for video
Feels more naturally I guess when only needing to add data-variant on special use cases.

converting this into a discussion


Font too small in high resolution display

For example in my Linux laptop displaying QHD+ (WQXGA+, 3200x1800), which I set to 210 DPI, the fonts are about 3 times smaller than in the other apps.
Some other wallets like ZCoin (zcoin-qt) can adjust to the font DPI setting.

Could you please try starting your wallet like this:
QT_SCALE_FACTOR=1.5 ./bulwark-qt
Also please make sure to update to the latest version before you try.

Actually, it's not just the fonts. It's the whole GUI. To demonstrate this on a 2160p display + Windows 10:

Possibly also related: https://github.com/shane-kerr/Mintcoin-Desktop-Wallet/issues/22

you may find this relevant:
High DPI Support in Qt
Ability to provide pixmaps or artwork for high resolution: see Drawing High Resolution Versions of Pixmaps and Images.
Qt 5.6 supports cross-platform high-DPI scaling for legacy applications, similar to the scaling done natively by macOS. This allows applications written for low-DPI screens to run unchanged on high-DPI devices. This feature is opt-in, and can be enabled by the following environment variables:
QT_AUTO_SCREEN_SCALE_FACTOR [boolean] enables automatic scaling, based on the pixel density of the monitor. This will not change the size of point sized fonts, since point is a physical unit of measure. Multiple screens may get different scale factors.
QT_SCALE_FACTOR [numeric] defines a global scale factor for the whole application, including point sized fonts.
QT_SCREEN_SCALE_FACTORS [list] specifies scale factors for each screen. This will not change the size of point sized fonts. This environment variable is mainly useful for debugging, or to work around monitors with wrong EDID information(Extended Display Identification Data).
The format can be either a semicolon-separated list of scale factors in the same order as QGuiApplication::screens(), or a semicolon-separated list of name=value pairs, where name is the same as QScreen::name().
While the macOS style fully supports high-DPI, the Windows desktop style currently has some limitations with certain scale factors. In these cases, consider using the Fusion style instead, which aims to support high-DPI in all cases.
Note: Non-integer scale factors may cause significant scaling/painting artifacts.
The application attribute Qt::AA_EnableHighDpiScaling, introduced in Qt 5.6, enables automatic scaling based on the pixel density of the monitor.
The application attribute Qt::AA_DisableHighDpiScaling, introduced in Qt 5.6, turns off all scaling. This is intended for applications that need to use actual window system coordinates, regardless of environment variables. This attribute takes priority over Qt::AA_EnableHighDpiScaling.
An experimental implementation of high-DPI scaling was introduced in Qt 5.4. It was enabled by the environment variable QT_DEVICE_PIXEL_RATIO, which could be set to a numerical scale factor or "auto". This variable is deprecated in Qt 5.6.
Migration of Existing Applications
In order to get an application designed for low DPI values running on a high resolution monitors quickly, consider one of the scaling options (let the application run as DPI Unaware on Windows or set the environment variable QT_AUTO_SCREEN_SCALE_FACTOR to "1". These options may incur some scaling or painting artifacts, though.
In the longer term, the application should be adapted to run unmodified:
Always use the qreal versions of the QPainter drawing API.
Size windows and dialogs in relation to the screen size.
Replace hard-coded sizes in layouts and drawing code by values calculated from font metrics or screen size.


Add metrics to the heartbeat

Description
Currently, the heartbeat sends a simple POST with only the API key and deployment ID. We should enhance this to include a few metrics from the coordinator run.
Some metrics that should be readily available:

The time the coordinator took to run
The number of successful API calls that were made (count AggregatedApiCall with a responseValue
The number of errored API calls (count AggregatedApiCall with an error code). Double check what sets the aggregated API call error code too.
The number of API call fulfillments, grouped by chain type and chain ID (count ApiCall where status = 'Submitted')
The number of withdrawals, grouped by chain type and chain ID (count Withdrawal where status = 'Submitted')
The block number for each provider, chain type and chain ID. Might be useful for building a history and diagnosing problematic providers

There may be other metrics worth adding too

Tracked by https://api3dao.atlassian.net/browse/AN-135


[BUG]WorkPro: Error: 14 UNAVAILABLE: Wechaty service discovery / resolution failed for target

Please make sure you have read the Wechaty Puppet Service: WorkPro from Wechaty Official Website before you continue writing this issue.
IMPORTANT
Describe the bug
A clear and concise description of what the bug is.
Info
workpro | ><EMAIL_ADDRESS>start
workpro | > cross-env NODE_OPTIONS="--no-warnings --loader=ts-node/esm" node src/workpro.ts
workpro |
workpro | 09:26:13 WARN GrpcManager initClient() TLS: disabled (INSECURE)
workpro | 09:26:15 WARN ResolverWechaty updateResolution() address not found target wechaty://api.chatie.io/puppet_workpro_xxxxx: token does not exist
workpro | 09:26:15 INFO Bot error: Error: 14 UNAVAILABLE: Wechaty service discovery / resolution failed for target wechaty://api.chatie.io/puppet_workpro_xxxxx: token "puppet_workpro_xxx" does not exist
workpro | 09:26:15 WARN ServiceCtl stop() found that is starting...
workpro | 09:26:15 WARN ServiceCtl stop() found that is starting, waiting stable ... (max 5 seconds)
workpro | 09:26:16 WARN ResolverWechaty updateResolution() address not found target wechaty://api.chatie.io/puppet_workpro_xxx: token does not exist
workpro | 09:26:20 INFO Bot error: DEADLINE_EXCEEDED: Timeout after 5000 ms
workpro | 09:26:20 WARN ServiceCtl stop() found that is starting, waiting stable ... timeout
workpro | 09:26:21 WARN ResolverWechaty updateResolution() address not found target wechaty://api.chatie.io/puppet_workpro_xxx: token does not exist
workpro | 09:26:21 INFO Bot error: Error: 14 UNAVAILABLE: Wechaty service discovery / resolution failed for target wechaty://api.chatie.io/puppet_workpro_xxx token "puppet_workpro_xxx" does not exist
workpro | 09:26:21 INFO Bot error: Error: 14 UNAVAILABLE: Wechaty service discovery / resolution failed for target wechaty://api.chatie.io/puppet_workpro_xxx: token "puppet_workpro_xxxx" does not exist
workpro | 09:26:21 INFO StarterBot Starter Bot Started.
To Reproduce
Steps to reproduce the behavior:
设置了 WECHATY_PUPPET_SERVICE_NO_TLS_INSECURE_CLIENT=true 依然无效
token  在有效期

把token提供给销售，然后我们看下具体问题。

@onlylhf 该问题是否被解决了？如果解决了请关闭issue，如果尚未解决可以再提供下问题的详细信息。

暂无反馈，关闭该issue。


detach volume failure

ERRO[405331] detaching volume: controller failed, volume 'dockercon_test2': exit status 1
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x7632ab]
goroutine 270 [running]:
github.com/rancher/longhorn-manager/manager.(*volumeManager).stopMonitoring(0xc4201dd1d0, 0x0)
/go/src/github.com/rancher/longhorn-manager/manager/manager.go:245 +0x6b
github.com/rancher/longhorn-manager/manager.(*volumeManager).doDetach(0xc4201dd1d0, 0x0, 0xf, 0x0)
/go/src/github.com/rancher/longhorn-manager/manager/manager.go:352 +0x50
github.com/rancher/longhorn-manager/manager.(*volumeManager).Detach(0xc4201dd1d0, 0xc4202fdd70, 0xf, 0x10, 0x0)
/go/src/github.com/rancher/longhorn-manager/manager/manager.go:348 +0x7e
github.com/rancher/longhorn-manager/manager.monitor(0x10fd040, 0xc42024c6c0, 0xc4202bc580, 0x10fe940, 0xc4201dd1d0, 0xc4202d9f20)
/go/src/github.com/rancher/longhorn-manager/manager/monitor.go:74 +0x2d4
created by github.com/rancher/longhorn-manager/manager.Monitor.func1
/go/src/github.com/rancher/longhorn-manager/manager/monitor.go:42 +0xc3

Two things are wrong here:

Detach/Delete should be idempotent. The second call passing nil volume for deletion, result in NPE.
There is a race condition between normal Delete operation and monitor thread. Monitor thread didn't stop fast enough and still report volume failure after the volume has been deleted, which result in the second call of Detach.


Automated Package Upgrade

:tada: This PR is included in version 12.4.171 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


message_list_view: Don't select message if the list is not current.

Not having this check caused Mark as unread from here to not work for message which was selected when the list was rendered since we marked it as read again via this.list.select_id after marking it as unread.
Steps for reproducer:

Narrow to a topic / PM with plenty of messages.
Mark some messages as unread in that narrow.
Reload the page.
Now the message which was selected will remain "read" even upon marking it as unread.

discussion: https://chat.zulip.org/#narrow/stream/6-frontend/topic/unable.20to.20mark.20message.20as.20read

This is great, thanks for tracking this down and helping make sure it gets fixed; the "mark as read" performance improvement is actually quite significant when doing large bulk operations. Marked to merge after the readability revisions noted above, thanks @amanagr!

Thanks!


[Communication] - phone-numbers - Add test to update capabilities

Update capabilities was only being tested with an unauthorized number, but not with an empty string, and we want both.
This will add the empty phone number test and the corresponding recordings

API change check
API changes are not detected in this pull request.


Switch to Tailwind CSS

Tailwind results in a much better looking website!

:tada: This PR is included in version 1.2.48 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


when tikv:6.3.0 checkout to tikv:master in k8s, k8s pod cannot start and crashloopbackoff

Bug Report

What version of TiKV are you using?

v6.3.0
Steps to reproduce

tikv:6.3.0 checkout to tikv:master in k8s env
What did you expect?
checkout successfully
What did happened?

k8s pod tikv-7 cannot start and crashloopbackoff

and logs in loki show that pd client assumed tikv version is v6.2.0-alpha

/type bug

/severity major

this maybe docker image version error


How to fix a bounding box class tag to  vehicle if prediction is > 85

i dont want that particular vehicle bounding box predicted class to change frequently anyone here who can help me with that?

just set the min_score_thresh parameter 0.85

@ahmetozlu thank you for your time sir.
Respected Sir,
It is not like that i want the bounding box not to change..like once its is predicted with probability >80% i want that bounding box to be fixed on that object with its class and not change at all..like not detect again and again. I tried your way but it keeps fluctuating .

You need to improve your model detection accuracy, you can perform transfer learning or fine tuning for it. Thus, you can improve the detection results. You should not fix the bounding box on any location of image, if you do it then you can not track the vehicles! The reason of fluctuation is the model accuracy which can not provide good enough detection for your case!

Respected Sir, @ahmetozlu
Okay thank you so much i will do.But there is this file mscoco_label_map.pbtxt .I am a begginer so please tell me the function of this file and how to generate a similar .pbtxt from a tensorflow model type .pb after transfer learning.
Waiting for your reply.Thank you


cryptocurrency wallets

This has been on my mind for a couple of months now with the proliferation of wallet type Casks in the repo.
My concern is that these apps are a high risk category for fakes and/or malware and we only have limited means available to us to "verify" that they are official.
It seems to be common for them to be renamed, discontinued to be replaced by something else similarly named, release multiple versions, change homepages, move offical development to a fork, be forked by a third party and basically everything else you can think of that makes it hard for us to confirm that they are official.
This makes them much more complicated than the average Cask with a much greater chance of a mistake being made.
I'm not quite at the stage where I'm suggesting that we remove and ban them from the repo/s but I would like to discuss the issues that come with these Casks and our options before we have too many of this type, especially as we seem to add a new one every few days.

Closing this out for now as we now enforce a minimum of 50 stars for new Casks.


chore(webfolio): implement about section

Description
Please describe the reason related to the changes:
Type
Please select the type related to the changes:

[ ] bugfix
[ ] build
[ ] continuous delivery (CD)
[ ] continuous integration (CI)
[ ] documentation
[ ] feature
[ ] formatting
[ ] refactoring
[ ] styling
[ ] other (please describe below):

Breaking Change
Does your changes introduce a breaking change?

[ ] no
[ ] yes

Behavior
Please describe the current behavior:
Changes
Please describe the new behavior:
Information (issue, links, logs, etc.)
Please list any other useful information:
Checklist
Please make sure this pull request follow the requirements:

[ ] commit guidelines @commitlint/config-conventional
[ ] 100% code coverage
[ ] tests passing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

29 of 29 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
371

Relevant Lines:
371

💛  - Coveralls


Set fib to -1 if no specific addresses are used

This sets fib member to -1 if no specific addresses are specified and is a FreeBSD specific fix. Mind you, I haven't tested this yet, so please don't merge yet.

Thanks @wcawijngaards. Yes, it works like a charm, no issues (tested without the first patch), so it's good to go.


[bug] Shim for python3 is missing

Describe the bug

python3 should be more recommended if your program expects Python as 3, but it is not available as shim in Proto now.
Steps to reproduce

proto install python 3
@((gcm python).path.replace($HOME, "~"), (gcm python3).path.replace($HOME, "~"))

The last cmdlet produce:
~\.proto\shims\python.exe
~\AppData\Local\Microsoft\WindowsApps\python3.exe

Expected behavior

~\.proto\shims\python.exe
~\.proto\shims\python3.exe

Screenshots

Environment

  System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 13th Gen Intel(R) Core(TM) i7-1355U
    Memory: 19.72 GB / 31.70 GB
  Binaries:
    Node: 20.11.1 - ~\.proto\shims\node.EXE
    Yarn: 1.22.22 - ~\.proto\shims\yarn.EXE
    npm: 10.5.0 - ~\.proto\shims\npm.EXE
  Managers:
    Cargo: 1.76.0 - ~\.cargo\bin\cargo.EXE
  Utilities:
    Git: 2.43.0.
    Curl: 8.4.0 - C:\windows\system32\curl.EXE
  Virtualization:
    Docker: 25.0.3 - C:\Program Files\Docker\Docker\resources\bin\docker.EXE
  SDKs:
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
      Versions: 10.0.22621.0
  IDEs:
    VSCode: 1.87.2 - C:\Users\tatsu\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
  Languages:
    Java: 21.0.1
    Python: 3.12.2
    Rust: 1.76.0
  Browsers:
    Edge: Chromium (122.0.2365.92)
    Internet Explorer: 11.0.22621.1

Additional context

I should have check the repo name, sorry.


[BUG] Exception occurs using annotation implicitcreation to create setter and getter method

Describe the bug
Exception occurs using annotation implicitcreation to create setter and getter method
To Reproduce
using this block of code occured error log when compiler
@Setter @Getter public class TaSellerVo {     /**      * user id      */     private Integer id; }
using this block of code it's working
@Setter @Getter public class TaSellerVo {     private Integer id; }
Expected behavior
compilation successful
Version info (please complete the following information):

Lombok version
 <dependency>          <groupId>org.projectlombok</groupId>          <artifactId>lombok</artifactId>          <version>1.18.6</version>      </dependency>

Platform
javaVersion：jdk7
compilation log：
Error:java: Lombok annotation handler class lombok.javac.handlers.HandleSetter failed on C:\MyTools\codeCloud\xxxxxxxxxxxxxxxxxxxxxxxx.java: java.lang.NoSuchMethodError: java.util.Map.putIfAbsent(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;

Sorry. We shouldn't have used Map.putIfAbsent, since it was only introduced in 1.8.

Duplicate of #2066, already fixed in 1.18.8.

Sorry. We shouldn't have used Map.putIfAbsent, since it was only introduced in 1.8.

get it.


Error when "git clone --recursive..."

NAME:~ NAME$ git clone --recursive https://github.com/PokemonGoF/PokemonGo-Bot-Desktop

Cloning into 'PokemonGo-Bot-Desktop'...
remote: Counting objects: 2363, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 2363 (delta 2), reused 0 (delta 0), pack-reused 2357
Receiving objects: 100% (2363/2363), 27.34 MiB | 186.00 KiB/s, done.
Resolving deltas: 100% (620/620), done.
Checking connectivity... done.
Submodule 'build/gofbot' (git@github.com:PokemonGoF/PokemonGo-Bot.git) registered for path 'build/gofbot'
Cloning into 'build/gofbot'...
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Clone of 'git@github.com:PokemonGoF/PokemonGo-Bot.git' into submodule path 'build/gofbot' failed

I don't know what I did wrong :( just entered the first command in terminal and pressed enter.
OS X Yosemite 10.10.5

#167
https://help.github.com/articles/adding-a-new-ssh-key-to-your-github-account/


Save to file

Hi.
How to save all cookies in file?
And how to load them back into the tough-cookie?

Consider settng the cookie store to a file store. Such as https://github.com/mitsuru/tough-cookie-filestore


correct link to flake8 on github

Flake8 moved from gitlab to github
https://github.com/PyCQA/flake8
https://www.reddit.com/r/Python/comments/yvfww8/flake8_took_down_the_gitlab_repository_in_favor/

Thanks @callumrollo!


Deidentified Camera does not actively describe low resolution, privacy-preserving cameras.

There is a desire to convey to the public when cameras do not collect PII due to low pixel values, but that is not the same as algorithmic deidentification.

Add a "Non-Identifiable" taxonomy item for technologies which do not collect PII


Add support for 'startFrame' parameter in stack trace.

Fixes #308.
When a stack trace contains many functions calls, the 'startFrame' can
be used in subsequent calls to expand a subset of the complete stack
trace.  Although this parameter is optional, if not utilized, it can
prohibit the interrogation of a long list of stack frames when
combined with the 'levels' parameter.

I may get a bit lazy, but do you mind adding the Changelog here, too? I'd merge that tomorrow.

Thanks for another nice contribution!


SPL token lending scaffolding

A bit of a copy / paste job but with TypeScript instead of Flow

Follow up issues:
Migrate from using Flow to TypeScript for JS clients: https://github.com/solana-labs/solana-program-library/issues/581
Too much duplicated JS code across different SPL program clients: https://github.com/solana-labs/solana-program-library/issues/583


How to disable undo (ctrl+z,) redo (ctrl+y) in version 10

I want to disable undo and redo feature in my spreadsheet (V10) but i couldn't find any implementation.

That should work on version 10 (PRO)
jspreadsheet.history.ignore = true;

That should work on version 10 (PRO)
jspreadsheet.history.ignore = true;

That should work on version 10 (PRO)
jspreadsheet.history.ignore = true;

        Thanks, its working. Below is the code

        <Spreadsheet history = {( jspreadsheet.history.ignore = true )} />

That should work on version 10 (PRO)
jspreadsheet.history.ignore = true;

Thanks, it's working. Below is the code how to implement
<Spreadsheet history = {( jspreadsheet.history.ignore = true )}>


Adding yarn, upgrading everything to latest except phantom.

Phantom breaks at 2.x with error UnhandledPromiseRejectionWarning: Unhandled promise rejection phantom 2

These changes are included as part of https://github.com/mpetrovich/imagely/pull/4


Error on validation

I tried training using the guide provided in this repo but failed due to following errors:
Validation:   0%|                                       | 0/100 [00:00<?, ?it/s]
Validation DataLoader 0:   0%|                          | 0/100 [00:00<?, ?it/s]Traceback (most recent call last):
  File "train.py", line 150, in <module>
    train(config)
  File "train.py", line 134, in train
    trainer.fit(model_module, data_module)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 697, in fit
    self._fit_impl, model, train_dataloaders, val_dataloaders, datamodule, ckpt_path
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 648, in _call_and_handle_interrupt
    return self.strategy.launcher.launch(trainer_fn, *args, trainer=self, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 93, in launch
    return function(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 735, in _fit_impl
    results = self._run(model, ckpt_path=self.ckpt_path)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1166, in _run
    results = self._run_stage()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1252, in _run_stage
    return self._run_train()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1283, in _run_train
    self.fit_loop.run()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/loop.py", line 200, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/fit_loop.py", line 271, in advance
    self._outputs = self.epoch_loop.run(self._data_fetcher)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/loop.py", line 201, in run
    self.on_advance_end()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 241, in on_advance_end
    self._run_validation()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/epoch/training_epoch_loop.py", line 299, in _run_validation
    self.val_loop.run()
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/loop.py", line 200, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 155, in advance
    dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/loop.py", line 200, in run
    self.advance(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 143, in advance
    output = self._evaluation_step(**kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 240, in _evaluation_step
    output = self.trainer._call_strategy_hook(hook_name, *kwargs.values())
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1704, in _call_strategy_hook
    output = fn(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/strategies/ddp.py", line 355, in validation_step
    return self.model(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 1008, in forward
    output = self._run_ddp_forward(*inputs, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 969, in _run_ddp_forward
    return module_to_run(*inputs[0], **kwargs[0])
  File "/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/overrides/base.py", line 90, in forward
    return self.module.validation_step(*inputs, **kwargs)
  File "/home/jupyter/src/donut/donut/lightning_module.py", line 72, in validation_step
    return_attentions=False,
  File "/home/jupyter/src/donut/donut/donut/model.py", line 477, in inference
    output_attentions=return_attentions,
  File "/opt/conda/lib/python3.7/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/transformers/generation_utils.py", line 1147, in generate
    self._validate_model_kwargs(model_kwargs.copy())
  File "/opt/conda/lib/python3.7/site-packages/transformers/generation_utils.py", line 863, in _validate_model_kwargs
    f"The following `model_kwargs` are not used by the model: {unused_model_args} (note: typos in the"
ValueError: The following `model_kwargs` are not used by the model: ['encoder_outputs'] (note: typos in the generate arguments will also show up in this list)

Config
resume_from_checkpoint_path: null # only used for resume_from_checkpoint option in PL
result_path: "./result4"
pretrained_model_name_or_path: "naver-clova-ix/donut-base" # loading a pre-trained model (from moldehub or path)
dataset_name_or_paths: ["naver-clova-ix/cord-v2"] # loading datasets (from moldehub or path)
sort_json_key: False # cord dataset is preprocessed, and publicly available at https://huggingface.co/datasets/naver-clova-ix/cord-v2
train_batch_sizes: [1]
val_batch_sizes: [1]
input_size: [1280, 960] # when the input resolution differs from the pre-training setting, some weights will be newly initialized (but the model training would be okay)
max_length: 768
align_long_axis: False
num_nodes: 1
seed: 2022
lr: 3e-5
# warmup_steps: 300 # 800/8*30/10, 10%
warmup_steps: 10 # 800/8*30/10, 10%
num_training_samples_per_epoch: -1
max_epochs: 3
max_steps: -1
num_workers: 8
val_check_interval: 1.0
check_val_every_n_epoch: 1
gradient_clip_val: 1.0
verbose: True
data_dir: ''

This problem is related to the Transformers version. Which version do you have?
Uninstall your current transformer and reinstall Donut.
pip uninstall transformers
pip install donut --force-reinstall

4.22.0.dev0
I will try to re install

closing this issue, reinstalling with a new environment did the fix


pagesize cannot be larger than 100

Get-GSMobileDevice returns a Google API error as the default pagesize value is outside of the permitted range.
Get-GSMobileDevice: Exception calling "Execute" with "0" argument(s): "Google.Apis.Requests.RequestError Invalid value '1000'. Values must be within the range: [value: 1 , value: 100 ] [400]
I have reduced the default value from 1000 to 100.

I also see this error message and can confirm that @Buenno's solution resolves the issue.