Apheleia sometimes overwrites changes in my JS buffers

Short summary: when editing JS files, I often move around pretty quickly, edit or add some text, then save, then move again, add some other code, and save. All within a handful of seconds. The "save often" thing is a sort of muscle memory /  mindless habit that happens when I'm "in the zone".  I don't really think about it.
Now that I'm using Aphelia, If I wait a little while after the second save, often (maybe it depends on timing?) the second set of changes disappears from my buffer. This is in emacs 29.1 .  If I'm not paying attention, I don't even realize it.  I just keep going.  Later, when I run tests, and see confounding results,  I go examine the code and see, the code I had put in place earlier is now gone.
Demonstration: https://www.youtube.com/watch?v=sppRYlaqquU
The setup for my formatter for my JS mode looks like this:
(push '(my-prettier-js .
        ("/usr/local/bin/prettier"
         "--stdin-filepath" filepath "--parser=babel-flow"
         "--trailing-comma" "none"
         (apheleia-formatters-js-indent "--use-tabs" "--tab-width")))
      apheleia-formatters)

(push '(js-mode . my-prettier-js) apheleia-mode-alist)

I think the way I can avoid this is to wait 5-6 seconds after every save, before making any further changes. That feels a little klunky to me. I could also just save ONCE, instead of lots of times.  That's a personal habit that's ingrained, and hard to change.
The README says that Apheleia is designed to not apply the reformatting, if the buffer contents have changed while running the formatter.  But I am not seeing that.
I use Apheleia for various languages (sh, go, java, ...) , and JS is the only case where I've noticed this.  Obviously, the other languages use other formatters.
Can you make suggestions?  Have I done something wrong with setting up the formatter?  how can I diagnose or debug this?  Or better, how can I solve it and eliminate this behavior?
I tested the prettier binary; when I run it outside of emacs, it seems to run quickly and correctly. Results get displayed in much less than a second.  I haven't looked at how long it takes when run within emacs by apheleia in the after-save-hook.  Not sure this is the problem, especially since Apheleia is supposed to not apply re-formatting if the file has changed. If that's so, it shouldn't matter how long the formatter takes to run, right?
I really like Apheleia, thanks for writing it,  it's mostly really good. But it edges into chaotic evil territory when some of my changes get lost, some of the time!
Thanks

I looked into it further. It does seem to take 5-8 seconds between formatting and producing the diff. I don't know why that is the case.  Even so, by design the thing I'm observing shouldn't happen anyway, right?
A possible explanation: race condition?   apheleia-format-buffer is setting the buffer-local var apheleia--buffer-hash . This value gets overwritten by the after-save-hook invocation corresponding to the 2nd save.  The "short circuit" check compares the current hash with the stored hash.  Because the value has been overwritten, it looks like there have been no changes.  And that's true: since the 2nd save, there have been no changes. But the re-formatting from the 1st save somehow gets applied.  I am not sure why the reformatting from the 2nd save does not also get applied. Maybe there is a race condition and sometimes the re-formatting for the 2nd save finishes first?
If there were a way to "de-bounce" the re-formatting and only allow the results of the the LAST reformatting run, that might solve the problem.
Another solution might be to use a lexically bound variable to store the "before state" buffer hash value, rather than a buffer-local variable (apheleia--buffer-hash). That would avoid the overwrite of the buffer-local var. There'd be two separate values, one for each run of apheleia-format-buffer. I am trying that now, so far it seems to work to avoid the problem.
It might partially mitigate the problem if I could make the re-format-and-then-diff happen more quickly than 8 seconds.  Maybe there is something special in my environment causing it to be slow.  If reformatting happened more quickly, It would also make the user experience better.  if you have suggestions on diagnosing and solving that, please share. But in any case, speeding it up  would not solve the problem completely.

Thanks for the detailed report. I agree with your diagnosis, I will see about implementing the best solution right now.

Merged a PR implementing your lexical variable idea. Let's take a look at the performance issue now.

Merged a PR adding detailed logging information with timestamps. Try it again with https://github.com/radian-software/apheleia/pull/235 and post the log, maybe we can determine what is so slow based on that output.

I had a separate problem that was causing the perf issues, which made the race condition much more likely. But I've solved that and you fixed the variable, and I think we're all good now. thank you!


Prevent write at NULL when codec configured not to use multiple threads

Progressive codec accessed 0 memory address when the following condition was met:
[HKEY_LOCAL_MACHINE\Software\FreeRDP\FreeRDP\RemoteFX]
"UseThreads"=dword:00000000

Inside progressive.c: When RFX_CONTEXT_PRIV::UseThreads was set to 0,
progressive_process_tiles() function wrote at memory address 0.

@freerdp-bot test

@akallabeth
Extract from build output https://ci.freerdp.com/job/ios/11176/console :
/Users/freerdp/ci.freerdp.com/workspace/ios/source/winpr/libwinpr/crypto/cipher.c:69:2: error: call to undeclared function 'EVP_CIPHER_CTX_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        EVP_CIPHER_CTX_init((EVP_CIPHER_CTX*)ctx);

Does the error mean CI is not configured for PRs into stable-2.0 branch properly?

@alega-kas means we did not yet backport openssl 3 support to stable-2.0

@alega-kas means we did not yet backport openssl 3 support to stable-2.0

Need I do anything else regarding this PR? Is any action expected from my side?

@freerdp-bot test

@alega-kas no, I´m fixing this.

OK, I stop working on this PR.
In case my action is required, please mention me explicitly.

@alega-kas ok, now it compiles. you need to format your changes though, the format checker fails.
Formatted
@freerdp-bot test

@freerdp-bot test

@freerdp-bot test


Items Lost after dropping Belt

After dropping the Utility Belt while there are still items in the Belt Slots deletes them.
They also don't return after picking up the belt.

This should be fixed in the latest version.


better autocompletion support when seting guru scope

The guru scope is a lot more free-form than the godoc query. The guru scope can contain the ... glob character, and may consist of more than one space-separated entry. In the past it also accepted absolute file paths, but I don't know if that is still true. IIRC it also supports negating package selections.
Reusing the godoc input for this is probably not a good fit. I am not sure how viable it would be to write completion that works well for the guru scope. It would have to support a lot of syntax and be context-aware.

The guru scope is a lot more free-form than the godoc query. The guru scope can contain the ... glob character, and may consist of more than one space-separated entry. In the past it also accepted absolute file paths, but I don't know if that is still true. IIRC it also supports negating package selections.

That's very useful. I wasn't aware of that feature. I always set the scope to the main package. That said, i still see benefit from having the autocompletion if:

you want to set the scope to a single package
you want to autocomplete a prefix and append ...

i don't think we have to overly complicate the completion logic if the user wants to use a more complex scope. WDYT ?

The issue is that the presence of completion often makes it difficult to enter custom text. The default completion will give special meaning to SPC, having it complete entries. And if people use things like ido, ivy, helm etc, it may be even more different.
Thus, the two options are

good completion
no completion

Thus, reusing godoc's completion is probably a bad idea.

I don't think SPC is allowed in the scope according to the doc. It can only be a comma separated list of packages or a wildcard (i.e. /...)
How would ido, ivy or helm interfere with this function, do they replace or advice completing-read ?

I pushed another commit that introduces a new go-guru--read-scope. the new function uses completing-read-multiple which allows multiple entries to be present in the scope.
note vim set guru scope provides similar behavior to what i'm proposing in this pr. see here and here

@dominikh what do you think of the proposed patch ?

Sorry, it'll be a couple days before I can test the patch.

Fixed the prompt and the history var used.

I also squashed the two commits to make the history cleaner

Merged at last, thank you for your patience.

Awesome, thanks!
On Thu, Jun 28, 2018, 6:13 AM Dominik Honnef<EMAIL_ADDRESS>wrote:

Merged at last, thank you for your patience.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dominikh/go-mode.el/pull/249#issuecomment-400985846,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASKleBphewLbA_da8AgiO-FPI29HdUnks5uBKxfgaJpZM4UDSnx
.


Bevy panics with certain skinned meshes

Bevy version
main on fd32c6f0ec2
What you did
I tried to import a glTF file derived from blender's Snow.
What went wrong
Bevy crashes with this wonderfully cryptic error and not much more information:
ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default
thread '<unnamed>' panicked at 'wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 1303, Vulkan)>`
    In a draw command, indexed:true indirect:false
      note: render pipeline = `pbr_opaque_mesh_pipeline-e1505v0`
    The pipeline layout, associated with the current render pipeline, contains a bind group layout at index 2 which is incompatible with the bind group layout associated with the bind group at 2

Why it happens
Under certain conditions (I'm still trying to find them out), an Entity will have a SkinnedMesh component, but the SkinnedMeshInverseBindposes asset for inverse_bindposes Handle will not exist.
This causes SkinnedMeshJoints::build to return None:
https://github.com/bevyengine/bevy/blob/982e33741de20241e4c1c3b46659b7da39dd8a2c/crates/bevy_pbr/src/render/mesh.rs#L239
When it returns None, extract_skinned_meshes will not add the SkinnedMeshJoints to the render-world-extracted Entity as per:
https://github.com/bevyengine/bevy/blob/982e33741de20241e4c1c3b46659b7da39dd8a2c/crates/bevy_pbr/src/render/mesh.rs#L288-L293
This is problematic, because the Entity in question will regardless have a Handle<Mesh> with skinning vertex attributes. Bevy's renderer checks those attributes to chose the bind group layout and shader for rendering the mesh:
https://github.com/bevyengine/bevy/blob/982e33741de20241e4c1c3b46659b7da39dd8a2c/crates/bevy_pbr/src/render/mesh.rs#L666-L668
(this is called by the Prepass and MeshPipeline)
But lo! the render impl of SetMeshBindGroup needs the SkinnedMeshJoints component, and its index, to comply with the bind group layout required by the skinning shader variant:
https://github.com/bevyengine/bevy/blob/982e33741de20241e4c1c3b46659b7da39dd8a2c/crates/bevy_pbr/src/render/mesh.rs#L1228-L1233
Now, we have a mismatch in bind group layout! And we get the wgpu panic.
Suggested improvements

Panic in extract_skinned_meshes when SkinnedMeshJoints::build returns None. Since it will lead to a panic regardless, at least make it explicit why it panics.
There is probably a more elegant minimal degradation route, with only an error! log, but not sure how an implementation would look like.

blender is crashing for me when trying to export this model as a gltf. Could you try to reduce the model as much as possible and still reproduce the issue?

I just got this panic, but it only happened once! I was unable to trigger it again running the same build.

thread '<unnamed>' panicked at 'wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 230, Vulkan)>`
    In a draw command, indexed:true indirect:false
      note: render pipeline = `pbr_prepass_pipeline`
    The pipeline layout, associated with the current render pipeline, contains a bind group layout at index 2 which is incompatible with the bind group layout associated with the bind group at 2

', [HOME]\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wgpu-0.16.3\src\backend\direct.rs:3019:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in exclusive system `bevy_renthread 'Compute Task Pool (1)' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', [HOME]\.cargo\registry\src\index.crates.io-6f17d22bba15001f\bevy_render-0.11.0\src\pipelined_rendering.rs:135:45```

Managed to reproduce it by accident! Was trying to create a new instance of a mesh from a gltf scene that had been spawned via SceneBundle. I was cloning the mesh handle and spawning a new PbrBundle with it and it panics every time.
Minimal reproduction here:
bevy_gltf_mesh_panic.zip

Aggressive Googling led to me this issue! I'm hitting the exact same error when rendering a SceneBundle from a .gltf with animation and bone data.
I've also got a minimal reproducible here which includes the .gltf assets.
In my case, I generated the .gltf from an Unreal Engine Skeletal Mesh with a dancing animation applied. It seems to be a valid .gltf by all accounts: I'm able to load it in a variety of (non-Bevy) viewers without problems (the mesh is skinned and the animation works).
I noticed that if I spawned a PbrBundle from the mesh and material in the scene, Bevy would render it just fine. So, something being wrong with the skeletal data seemed to make sense to me. (But I can't make heads or tails of the wgpu code that raises this error.)

Thank you all for the small reproducible models. I've some clue as to what is going on, but I needed some lighter models to test it on. I'm going to spend some times today on this

I have a fix in https://github.com/bevyengine/bevy/pull/9338, could you test if it works on all your cases?

I have a fix in #9338, could you test if it works on all your cases?

Woohoo!  Great work!


Projects/Reviews bug when you delete a note

I deleted a project note today which i didn't need anymore.

So there are really 2 bugs:

Projects should be resilient enough to survive a missing note in the review list
Dashboard should not have zero content if projects fails
Log:

2024-03-06 15:20:43 | DEBUG | getDataForDashboard :: ---------------------------- Looking for Project items for section #5 -----------------------------
2024-03-06 15:20:43 | DEBUG | jgclark.Reviews v0.13.0 :: Starting getNextNotesToReview())
2024-03-06 15:20:43 | DEBUG | dashboard/getNextNotesToReview :: - Next to review = 'Migrating Plugin Documentation'
2024-03-06 15:20:43 | DEBUG | dashboard/getNextNotesToReview :: - Next to review = '⭐ NP: Overdue React'
2024-03-06 15:20:43 | DEBUG | dashboard/getNextNotesToReview :: - Next to review = 'Passport Renewals'
2024-03-06 15:20:43 | DEBUG | dashboard/getNextNotesToReview :: - Next to review = 'Anique Room Reno 2023'
2024-03-06 15:20:43 ❗ERROR❗ jgclark.Dashboard v1.0.0-a1 :: {
  "message": "undefined is not an object (evaluating 'n.filename')",
  "line": 29222,
...
  "name": "TypeError"
}

In case it's helpful, the failing line is on the last line of this code (which has been transpiled, but variable names should match your actual code):
        const nextNotesToReview = getNextNotesToReview(6);
        if (nextNotesToReview) {
          let itemCount = 0;
          nextNotesToReview.map((n => {
            var _n$filename;
            const thisID = "".concat(sectionCount, "-").concat(itemCount);
            const thisFilename = (_n$filename = n.filename) !== null && _n$filename !== void 0 ? _n$filename : "<filename not found>";
            ```

Thanks. This has already been fixed in the development branch of Dashboard, which I'm hoping to release soon.

Ok but it failed for me on the branch you shared (not the released version)


Maintain paths between Xcode and commandline executables

Update .swift-version to 3.1.1
For #26

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   65.18%   65.18%
=======================================
  Files           4        4
  Lines         247      247
=======================================
  Hits          161      161
  Misses         86       86

Flag
Coverage Δ

#Configuration
65.18% <0%> (ø)
:arrow_up:

#TestProgram
65.18% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

Sources/Configuration/ConfigurationManager.swift
41.4% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84bf28...e5f0d4f. Read the comment docs.


Create C# code snippets for lists

The redis.io webpage for lists needs the C# example as well. The python equivalent can be used to copy the setup and can be found here
The first line of the file needs to be the ID for the example - # EXAMPLE: list_tutorial
Each separate section is delimited with a tag that you will need to copy exactly for it to appear in the correct place, ie.
# STEP_START queue
{code}
# STEP_END

# HIDE_START, # HIDE_END, # REMOVE_START, and # REMOVE_END can be used for debugging and deleting keys. Hide will hide until a user expands the example, remove will only be seen in the source code and will never appear on the webpage.

Examples should live in this folder
@dwdougherty and I will be reviewing and tracking these issues - feel free to tag us with any questions

Done


How to control the speed of producers？

How to get the number of outstanding tasks? If consumers consume too slowly, I want to control the production speed of producers.Does the disruptor have this function? Or how can I achieve it myself?

The producers will know when the ring buffer is full as they will either block when calling next() or
when calling tryNext() an InsufficientCapacityException will be thrown.  The producers can then back-off/retry, drop or implement any other strategy for dealing with producer/consumer imbalance.  This concept is called back-pressure.

You can also used RingBuffer.hasAvailableCapacity to estimate whether the ring buffer would block given a specified number of messages.


smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router

Is it planned to provide smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router ?
https://vertx.io/docs/vertx-web-openapi-router/java/
Thanks.

Which parts of the API would need to be Uni/Multi returning?

Sorry I don't know.
Today, our software is fully based on io.smallrye.reactive:smallrye-mutiny-vertx-web-openapi.
We plan to use the smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router when it is available because of https://github.com/vert-x3/vertx-web/issues/2383#issuecomment-1953720933.
Hope my reply will help you.

Given the revert via https://github.com/smallrye/smallrye-mutiny-vertx-bindings/pull/930, the fix isn't available in v4.5.8. We face the issue https://github.com/vert-x3/vertx-web/issues/2383, that this was supposed to resolve. An ETA for the fix? Thanks.

Can I check it out and test it locally?

Sure, just take the main branch and readd the modules. Do a mvn install -DskipTests (there are no tests in these modules) and you will see the compilation issue.

@cescoffier @pk-work Our Vertx apps are annoyingly impacted by this bug. Any hope the issue would be resolved in the near future?

The added modules aren't functional yet. The generation fails and I don't know the root cause. The upstream code may not follow the generation rules (I already reported issues). Unfortunately, it means fixing it in Vertx, wait for a release, then test here, repeat...

@AdrianVasiliu Hi, sorry for the inconvenience. Due to private circumstances I wasn't able to spent much time into my opensource activities and I don't know when this will change. Maybe 2 weeks, maybe a month. I don't know.
If this is only a smaller issue with e.g. visibility of classes / methods and really important for you, please open a PR in vertx-openapi and/or vertx-web and I will review it.

Hi @pk-work, thanks for the feedback. I follow this issue because we were following https://github.com/vert-x3/vertx-web/issues/2383 which has been closed with the PR reverted due to this issue (if I got well your comment there). I don't have the big picture in my hands.
In the end, for our app, it's about being able to upgrade to a Vertx version where io.vertx.core.VertxException: Thread blocked doesn't hurt any more...


add OCW_IMPORT_STARTER_SLUG to the mass publish pipeline definition code

Pre-Flight checklist

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-studio/issues/983
What's this PR do?
In https://github.com/mitodl/ocw-studio/pull/950, we added a pipeline definition to create a single mass publish pipeline in Concourse for publishing all sites at once.  This PR was missing one env variable, OCW_IMPORT_STARTER_SLUG which is used to create the query string the API is hit with when requesting new courses. as well as news items.  This PR adds the environment variable to the pipeline definition with the proper value in each environment.
How should this be manually tested?
This should be tested in RC by upserting the mass publish pipeline definition with ./manage.py upsert_mass_publish_pipeline followed by triggering the live pipeline.  After the run is complete, inspect https://ocwnext-rc.odl.mit.edu and make sure that the error "OCW Studio URL not configured" is not displayed.

Codecov Report

Merging #984 (bd0ee5c) into master (7021f97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #984   +/-   ##
=======================================
  Coverage   91.50%   91.50%
=======================================
  Files         193      193
  Lines        7369     7369
  Branches     1291     1291
=======================================
  Hits         6743     6743
  Misses        544      544
  Partials       82       82

Impacted Files
Coverage Δ

content_sync/pipelines/concourse.py
90.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7021f97...bd0ee5c. Read the comment docs.


Media not show image after upload if location out side public folder

Version information

Laravel: v8.46.0
Voyager: v1.4
PHP: 7.4
Database:MySQL

Description

Media not show image after upload if location out side public folder
APP_URL=http://localhost:8000
filesystem:

    'disks' => [

        'local' => [
            'driver' => 'local',
            'root' => storage_path('app'),
        ],

        'public' => [
            'driver' => 'local',
            'root' => storage_path('app/public'),
            'url' => env('APP_URL').'/storage',
            'visibility' => 'public',
        ],

        's3' => [
            'driver' => 's3',
            'key' => env('AWS_ACCESS_KEY_ID'),
            'secret' => env('AWS_SECRET_ACCESS_KEY'),
            'region' => env('AWS_DEFAULT_REGION'),
            'bucket' => env('AWS_BUCKET'),
            'url' => env('AWS_URL'),
            'endpoint' => env('AWS_ENDPOINT'),
            'use_path_style_endpoint' => env('AWS_USE_PATH_STYLE_ENDPOINT', false),
        ],

    ],

Screenshots
if upload outside public folder
https://s1.im.ge/2021/06/10/N1p8.jpg
if upload inside public folder
https://s1.im.ge/2021/06/10/NOCX.jpg

I had the same problem.
I solved the problem by making the FILESYSTEM_DRIVER value in the env file public.
And don't forget to php artisan optimize

I found an unorthodox solution, maybe can help.
In \config\filesystems.php i changed from
public_path('storage') => storage_path('app/public'),
to
public_path('storage') => storage_path('app'),
deleted (if present) the storage symlink in public folder
regenerate the symlink in public folder with php artisan storage:link
Obviously it will affect the whole application, so you must check all the places where you used the symlink

Hellow, simply go to filesystem , look at the local drive , update root path to app/public
i.e change from
'local' => [
'driver' => 'local',
'root' => storage_path('app'),
],
to
'local' => [
'driver' => 'local',
'root' => storage_path('app/public'),
],
your problem should be fixed

Thank you @pro-cms

@aroon9002ahmed @pro-cms
It would be better to leave filesystem config untouched and change voyager config file to use public storage.
An explanation on what's happening:
Voyager config file defines which storage to use like this:
'storage' => [
    'disk' => env('FILESYSTEM_DRIVER', 'public'),
],

Since FILESYSTEM_DRIVER was not defined by default in Laravel the public storage was used, but in Laravel 8.5.19 the default value was added.
https://github.com/laravel/laravel/commit/c5d38d469a447d6831c3cf56d193be7941d6586f#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8c
@emptynick @fletch3555 should we change voyager config file and just set public or any other idea?

Yeah I think we can do that

@aroon9002ahmed @MrCrayon @emptynick  #5364 is the best solution , thank you


Can the program read the interlocutor's message and send them

Related Problem
A Clear and Concise Description of what the Problem is
Feature Description
A Clear and Concise Description of the Feature

Can you explain more


chore: bdd-gh-1586840067 to 0.0.1

chore: Promote bdd-gh-1586840067 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[VLM][Bugfix] enable internvl running with num_scheduler_steps > 1

FILL IN THE PR DESCRIPTION HERE
A small fix for InternVL while running with num_scheduler_steps > 1, before this PR, set num_scheduler_steps > 1 for InternVL, will raise an error:
[rank0]:   File "/root/anaconda3/envs/vllm/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
[rank0]:     return func(*args, **kwargs)
[rank0]:   File "/root/anaconda3/envs/vllm/lib/python3.10/site-packages/vllm/worker/multi_step_model_runner.py", line 367, in execute_model
[rank0]:     self._base_model_runner.model.sampler.include_gpu_probs_tensor = (
[rank0]:   File "/root/anaconda3/envs/vllm/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1729, in __getattr__
[rank0]:     raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
[rank0]: AttributeError: 'InternVLChatModel' object has no attribute 'sampler'. Did you mean: 'sample'?

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Can you make this a @property of the model instead of an attribute. While you're here, it would be great if you could also do this for all of the other VLMs.

Can you make this a @property of the model instead of an attribute? It would be great if you could also do this for all of the other multi-modal models.

@DarkLight1337 Currently, all other VLM models use self.sampler = Sampler() or self.sampler = self.language_model.sampler. So I think, right now, changing it to @property is not a good practice. Doing so affects all VLM models and may introduce new bugs.

Can you make this a @property of the model instead of an attribute? It would be great if you could also do this for all of the other multi-modal models.

@DarkLight1337 Currently, all other VLM models use self.sampler = Sampler() or self.sampler = self.language_model.sampler. So I think, right now, changing it to @property is not a good practice. Doing so affects all VLM models and may introduce new bugs.

The intention is to disallow changing the sampler of the VLM model (since it is supposed to be the sampler of the language model). But I guess we can do this in another PR...
Can you fix the linter errors by running format.sh?

PTAL at the CI failure (ignore the AMD ones). Looks like the issue is caused by Phi3 not having its own sampler.

PTAL at the CI failure (ignore the AMD ones). Looks like the issue is caused by Phi3 not defining a sampler at the top level.

The error message show:
[2024-09-24T12:10:47Z] [rank0]:   File "/usr/local/lib/python3.12/dist-packages/torch/nn/modules/module.py", line 1729, in __getattr__
--
  | [2024-09-24T12:10:47Z] [rank0]:     raise AttributeError(f"'{type(self).__name__}' object has no attribute '{name}'")
  | [2024-09-24T12:10:47Z] [rank0]: AttributeError: 'Phi3ForCausalLM' object has no attribute 'sampler'. Did you mean: 'sample'?

@DarkLight1337 The AMD CI still failed, but PP CI test passed

Don't worry about it, I have asked someone to force merge this.


Adds notifier from credentials and acls files to services

Hi!
This pull request adds notifiers from credentials_file and acls_file to services.
Determining whether authorization or authentication is enabled is done during the start of the service e.g., through the --credentials option.
Then, the service reads the corresponding files. For example, you can see the system call that took place when the mesos-master fires up.
6112  open("/etc/mesos/master-credentials", O_RDONLY|O_CLOEXEC) = 7
6112  ioctl(7, TCGETS, 0x7ffc30844c60)  = -1 ENOTTY (Inappropriate ioctl for device)
6112  read(7, "{\"credentials\":[{\"principal\":\"some-principal\",\"secret\":\"some-secret\"}]}", 4096) = 71
6112  read(7, "", 4025)                 = 0
6112  read(7, "", 4096)                 = 0
6112  close(7)                          = 0

I would expect that whenever there is a change/update to those files, the services is notified.

LGTM, thanks!


Add build script

Usage : go to sample folder, and then run 'npm run bundle +
YOUR_SAMPLE_FOLDER_NAME'. After build, you project was been deoply in path proj/vr/build/.
NOTE: work remains

local node_module management : we fix some bugs in some node_module. we need hold them in local.
more build options, like 'npm run bundle all'.

@huningxin  PTAL and Try!

@huningxin  PTAL.

It works!
But I still need to modify the
'../index.bundle.js', -> './index.bundle.js',
correct?
Please document all these steps in the README.md. Then we merge. Sounds good to you?

@huningxin thx for reporting the bug ! and PTAL the latest PR.

Looks good. Thanks for making this!


Trip details should be fetched from array

Use trips array content instead of static one. Regarding this:

Completed as of f7e4c00.


Fix unstake list - finalizable vs non-finalizable operations

its difficult to know which operations have already been finalized.
How tzkt shows finalized operations.
Incorporate these changes in code. There is no restake operation in the protocol. There is only slashing.

Restake operation exists for bakers. The calculations are correct.


rustc: apply patch to fix delay_span_bug ICE

Description of changes
https://hydra.nixos.org/build/207931877
https://github.com/rust-lang/rust/issues/107691
https://github.com/rust-lang/rust/pull/107688
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin, nix-build -A vector

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@NixOS/rust The upstream patch hasn't been approved. Assuming we have to land this today to get it in for this cycle (along with the scheduled OpenSSL update), we have two options:

Let vector (the only package, at least AFAIK, that's affected by this) regress for hopefully just one cycle, as people can always just pin it.
Revert the bump.

Thoughts?

How urgent is the OpenSSL update? Looking at hydra, the regression doesn't seem to effect much more packages, perhaps we can just add back rust 1.66 for vector if we can't apply the patch in time?

@figsoda Upstream approved them, which is why I undrafted this.

Ah I misunderstood https://github.com/rust-lang/rust/pull/107688#issuecomment-1421669871, this is good to go once CI's done

@ofborg build vector

Vector built on both Linux architectures, and Darwin is timing out as expected. Let's do it.

was just about to do that lol


Boombox

About the PR
A boombox has been added, which allows you to listen to looped works + you can be located at a fairly large distance from the device. Therefore, this thing can safely stand in the bar.
Why / Balance
Sometimes the game lacks atmosphere. And music can fix it. If we talk about carrying a boombox with you, which is equivalent to carrying a PAI... Well, the boombox doesn't talk too much.
Technical details
From the official code, I only touched on the radio microphone component. I changed the access to the fields in it so that I could change the volume on the boombox. Everything else is just a sound stream operation.
Media
https://youtu.be/YXTaxbMCzwA

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
:cl: BeatusCrow

add: The boombox!
add: 2 cassettes with the following musical compositions: Space AssHole, The Wizard

I'll answer all the questions tomorrow, I'm sorry. It's already night for me.

If its gonna work if im gonna turn it on and it will keep playin even if i leave the station itself,
This is gonna be huge. I would love it.

Thank God it's not MIDIs.
How does it work netcode-wise? Does it actually sync the playback across all listeners? I.e. if boombox is in the middle of a track and someone enters PVS range, will they start hearing it from the middle? I know you made no changes about that in your PR, so this is a question about the existing netcode audio playback.
Also if the item includes emag interaction please describe it in the PR description. I see it's minor but we want to see the whole picture.

I have changed the PR according to your requirements.

If its gonna work if im gonna turn it on and it will keep playin even if i leave the station itself, This is gonna be huge. I would love it.

https://youtu.be/X0fHXUksAvo I hope I understood your comment correctly.
P.S. I slowed down a bit there...  Does it actually sync the playback across all listeners? I.e. if boombox is in the middle of a track and someone enters PVS range, will they start hearing it from the middle? I know you made no changes about that in your PR, so this is a question about the existing netcode audio playback.

Audio rework handles networking playback position

I made some sprites for musical notes for a separate PR, would you like to use them for the boom box when it's turned on?

I made some sprites for musical notes for a separate PR, would you like to use them for the boom box when it's turned on?

The idea of the notes is interesting, but I'm afraid they will stand out too much... And on a regular basis, the players will not like it. In any case, it is far from certain that the PR will be accepted, so for now I will not change the sprites for the states. But thank you for this offer

There is an error in build test, but it fixes really easily
Just add to entity BaseBoomBox components:
    - type: ItemSlots
    - type: ContainerContainer
      containers:
        boombox_slot: !type:ContainerSlot
          showEnts: False
          occludes: True
          ent: null
    - type: DeviceLinkSource
      ports:
      - Pressed

It does nothing for in-game entity because BaseBoomBox gains these components anyway

And also there may be some errors because of stereo music (I encontered one), so i guess you'd better make them mono or try to adjust the system for it

Feature creep suggestion but in the James Bond movie The Living Daylights they were testing a 'ghetto blaster' gadget, which was a boombox with a concealed rocket launcher

Really would love to see this in-game, would be cool to do more PR's building off this for a juke box and portable cassette players. Im sure the janitors would appreciate some Space Asshole while cleaning up the burning station lol

Re-open if you come back to this.

funny idea


Adding an game over and Menu page

[ ] create a resting page that contains the menu
[ ] create resting page that is triggered on game over

Hey, should we use just plain javascript and html for the task? What do you think about migrating to React.js

Hey, should we use just plain javascript and html for the task? What do you think about migrating to React.js

It is meant to be done in vanilla javaScript.

@vishalkashyap09  Can you assign me this task?
And can you give more details of what to be done?

[ ]  create a resting page that contains the menu
[ ]  create resting page that is triggered on game over

what should be included in the menu?

what should be the contents of the menu?
Name of the game, Logo (can be an animation) with transparent background and button quoting "start"

Please assign this issue to me


About mathbench dataset download

Where can I download the dataset (mathbench_v1)?  I've looked everywhere and couldn't find it.

Where can I download the dataset (mathbench_v1)? I've looked everywhere and couldn't find it.

You can download dataset from releases page.


Use HTTP/2 and SPDY

Thanks so much for building this tool, it's really outstandingly useful.
In keeping with the "the future is today" mentality of most of the newer JS frameworks, would you be willing to entertain a PR that introduced support for HTTP/2 and SPDY via node-spdy?

As a simple development server I don't feel like this has much value. Is there a particular use-case for development that you have that requires HTTP/2?
Running lite-server in production is absolutely not recommended. :)
Another quirk is that this project is a simple wrapper around BrowserSync's server feature. If it can't do HTTP/2, then I assume we'd have large difficulty trying to work that in via lite-server. But if Browsersync ever does include that feature, it could be easily enabled through lite-server's overrides.

I agree with Chris, but curiosity has got me ... I'd like to see what you have in mind just to satisfy that :)

Thanks all. Well, let me lay out my arguments for you here first -- if
they're totally unconvincing it may not be worth the effort.

lite-server is part of the "future, now" Javascript ecosystem. It's
advertised for use developing with JSPM and Angular 2, for instance. HTTP/2
is the future of communication on the Web, so it makes sense to get people
developing on that now.

I have some very, very preliminary data showing that in development
cases where hundreds of objects need to be loaded from the server (common
enough with JSPM and even modestly sized projects these days), HTTP/2 can
cut down time to first load for developers considerably.

It's a little-ish issue, but I think it's also important to get
developers saying the mantra "SSL only," starting from their development
instances. I've already developed a tool that de-complicates the process so
you don't have to worry about bright red SSL warnings more than, say, once
a month. It's true that you could do the same thing against HTTP/1.1 also,
but packaging it with a move to HTTP/2 makes it easier for developers to
swallow -- honey on the rim of the medicine cup, as it were.

If this is at least a colorable argument to you, let me know and I'll take
a pass at it.
All best
Harry
On Wed, Feb 3, 2016 at 5:53 AM John Papa<EMAIL_ADDRESS>wrote:

I agree with Chris, but curiosity has got me ... I'd like to see what you
have in mind just to satisfy that :)
—
Reply to this email directly or view it on GitHub
https://github.com/johnpapa/lite-server/issues/15#issuecomment-179246414
.

+1

Another +1 for this, especially as a development server.
When you load Angular2 via SystemJS, you have quite a large number of requests depending on your import tree.
This is not the production experience, but it kinda slows down the development experience (sample).
HTTP/2 might be a good solution for this development-only problem.

+1


.github: Test in Fedora 34

Since you asked us to rebase this, I've done so and opened #1532 in favor of this one (holding the same commits from @jjardon)


Module for iD.services

Also I did some Makefile cleanup, because it was not re-running the build steps after changing source files.
Tests fail when run on commandline with mocha, but pass when run in browser.
No idea why.. It looks like not everything is getting put in the global namespace like it should.
Any ideas @kepta @tmcw ?

I think I figured it out.  I can't use module level variables (yet).

I think it was because PhantomJS doesn't reliably support const? Regardless, PR looks 👍


Swipe UX bugs

The swipe actions added in #60 have a couple bugs/shortcomings that inhibit usability.

[x] You can only swipe left to right, not right to left which is unintuitive for right-handed users
[ ] Swiping to save in the 'Hottest' posts list has no visible affordance for the user
[x] Swiping an item in the 'Saved' posts list also clears every post below it (???)
[ ] There is no un-save action in the 'Hottest' posts list

#73 fixes the 1st and 3rd problem

Well the remaining items are not swipe related anymore so going to file a separate issue


Support new directory search pagination & search APIs

We're about to increase the number of rooms on Matrix.org by 3x.  To scale properly we'll have to paginate serverside

(The PR that added pagination: https://github.com/matrix-org/synapse/pull/1121)


Firebase updateChildValues operation blocks other Firebase operations.

Xcode version: latest
Firebase SDK version: latest
Firebase Component: Database
Component version: latest

I'm using updateChildValues operation to update values for 500 students in the database, when I trigger it and try to trigger another Firebase operation like observe, the second operation (observe) will not performed and will keeps waiting until the first operation (updateChildValues) completes, which takes nearly 15 seconds.
This is my code for updateChildValues:
@IBAction func menu(_ sender: Any) {
        let storeRecord = UIAlertAction(title: "Store attendance record", style: .default) { action in
            var attendanceTimesDict = [String: Int]()
            var absenceTimesDict = [String: Int]()
            for student in self.students { // 500 students
                if self.attendanceRecord[student.identifier] == true {
                    student.attendanceCount += 1
                    attendanceTimesDict["\(student.identifier)/attendance"] = student.attendanceCount
                } else {
                    student.absenceCount += 1
                    absenceTimesDict["\(student.identifier)/absence"] = student.absenceCount
                }
            }
            Database.database().reference().child("class").child("CS101").child("records").child("27-4-2019").updateChildValues(self.attendanceRecord)
            Database.database().reference().child("class").child("CS101").child("students").updateChildValues(attendanceTimesDict)
            Database.database().reference().child("class").child("CS101").child("students").updateChildValues(absenceTimesDict)
        }
}

And this is my code for observe function:
func getStudentsList() {
        Database.database().reference().child("class").child("CS101").child("students").observeSingleEvent(of: .value) { snapshot in
            for child in snapshot.children.allObjects as! [DataSnapshot] {
                let studentObject = child.value as? [String: Any]
                if let name = studentObject?["name"] as? String {
                    let student = Student(identifier: child.key, name: name)
                    self.students.append(student)
                }
            }
          self.tableView.reloadData()
        }
}

Nearly 2 days without any answer.

@fawzirifai It's unlikely anyone will be available to investigate on a weekend.  Also, you may have better luck on stackoverflow, since this may be closer to a usability question and not necessarily a functionality issue or iOS specific.
If it is an iOS specific issue, all of the code is available if you'd like to debug yourself and send a PR.

@paulb777 sorry for my rush, I forgot about the weekend.

8 days without any answer!

Hey @fawzirifai, changing the order of listener updates/writes may be non-trivial and is unlikely to be addressed by the Firebase team soon. Have you considered using a Cloud Function instead of updating 500 records on the client?

No I’m new to Firebase, so this is normal in Firebase that it takes 30 seconds to update 500 children and blocks other functions while it is updating?

RTDB operations are dependent on a number of factors, like the speed of your network and the speed of your device. It's very possible for 500 updates to take 15 seconds.


new feature: Query /events by targeted resource_id

Schema: /events/by-resource/<resource id>
Example resource id: run/605d1ad4-b3b2-4b60-af99-843c7b8278f9
Resulting query: /events/by-resource/run/605d1ad4-b3b2-4b60-af99-843c7b8278f9

[ ] Check CIMI compliance.

Related to:

#324
#325

The format for the CIMI filtering can be found in Section <IP_ADDRESS> of the CIMI document.  The format is a standard filtering query rather than a separate resource.

MTS:

[ ]  with pagination, check ordering (should be timestamp DESC)


Allow go templates in template define statement

template names require a string literal. It would be easier to reuse for new charts if they could be defined dynamically, e.g:
{{- define (printf "%.mytemplate" .Chart.name) -}}
{{ include (printf "%.mytemplate" .Chart.name) . }}

Suggestions for text/template improvements should be filed with the Go maintainers. Thanks.
https://golang.org/pkg/text/template/
https://github.com/golang/go#contributing


x883—As TS (Katy), I want to record a new operation called CytAssist

Select worknumber
Scan in one or two source barcodes (slides).
Scan in one (external) destination barcode, and specify labware type (see x884 and x885).
Select which section goes to which slot on the new cytassist slide.
Transfer section from the sources to the destination slide. Source section/slides become Used (not discarded) so it can be stored/released/destroyed
State change of transferred: Probes

@seenanair @BenTopping @khelwood testing this out and working nicely (waiting for ilaria's feedback), but for a downstream processing of the newly created visium slide we will need to Stain QC again to add a percentage coverage. but the Stain QC needs the slide to be stained already, which the course labware in this feature was, can we carrying over this staining to the destination barcode on the cytassist feature? or remove the requirement for staining for the Stain QC feature?

@khelwood    I hope Katy has mentioned this- If the source labware in Cytassist  is already stained , it would be better to transfer that stain info (percentage coverage) to destination plate to avoid staining the destination plate again. Is this more on cored side?
Please correct if I am wrong?

@KatyTudor  Sorry,  I didn't get it properly. Can it be considered as a separate story, if the current CytAssist operation is behaving as it is supposed to be.

@seenanair that's fine yeah I can pop a story in for the enhancement of it no problem. Don't apologise its probable me not explaining it correctly :-)


Update MD file on new branch 2017-11-14_02-24-26

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


KV Store: Graveler implement DumpTags

Closes #3726

@itaiad200  Dump flow currently cannot work until we implement all the dump logic. We should do it after we implement all dump logic


Fix instructions for installting GDB on Fedora

The package arm-none-eabi-gdb is no longer provided by Fedora as stated in #364. So let's guide Fedora uses to Other distros then and use a pre-built toolchain provided by ARM. This is also the recommendation from the issue at Fedora.

r? @adamgreig
(rust-highfive has picked a reviewer for you, use r? to override)

I suspect Fedora users can probably use gdb-multiarch as well, but the new instructions here should also work fine.

I had a quick look at https://src.fedoraproject.org/projects/rpms/* but it seems that this package is not available.

Perhaps we should link to a newer version though...

Do you mean the version of the toolchain? 10-2020-q4-major is still the latest release according to their website.

Huh, I guess no further work required then! I assumed there would have been a 2021 release of the GCC toolchain by now but you're right, there's not, so nothing to update. Thanks for checking!

I have been working with Fedora's gdb for the longest time and just using the default package just works :tm: for me:
λ gdb target/thumbv7em-none-eabihf/debug/examples/adc
GNU gdb (GDB) Fedora 10.2-3.fc34
<snip>
Reading symbols from target/thumbv7em-none-eabihf/debug/examples/adc...
(gdb) l main
13      use stm32h7xx_hal::{adc, delay::Delay, pac, prelude::*, rcc::rec::AdcClkSel};
14
15      #[macro_use]
16      mod utilities;
17
18      #[entry]
19      fn main() -> ! {
20          utilities::logger::init();
21          let cp = cortex_m::Peripherals::take().unwrap();
22          let dp = pac::Peripherals::take().unwrap();
(gdb)

My only GDB related packages are:
λ dnf list --installed | grep gdb
gap-pkg-liealgdb.noarch                           2.2.1-4.fc34                           @fedora
gcc-gdb-plugin.x86_64                             11.1.1-3.fc34                          @updates
gdb.x86_64                                        10.2-3.fc34                            @updates
gdb-gdbserver.x86_64                              10.2-3.fc34                            @updates
gdb-headless.x86_64                               10.2-3.fc34                            @updates
gdbm-libs.x86_64                                  1:1.19-2.fc34                          @fedora
wireless-regdb.noarch                             2020.11.20-2.fc34                      @fedora

so it appears to me default fedora gdb just is multiarch already?


feat(plugin-sass-palette): allow empty id

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.304%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
698

Relevant Lines:
1255

💛  - Coveralls


Defer uid lookups on Darwin

Mounts are not supported on Darwin, so carry the trick used on Windows for Darwin (e.g. defer uid:gid lookups).

/retest

/retest


show scrollbar option

the scrollbar is not showed for a reason?
would be nice a option show it...

It's impossible to show scroll when filters are specified, scroll needs to know the total size of visible records, but log-viewer cannot check all records whether it is visible or not, applying filters to all records may take too much time. We can show scroll when no filters are specified, but we always don't show scroll to be consistent.

Is there an option to enable scroll bar when there is no filter applied ? It gives a idea to the user how long the file is and also able to navigate better.


3.29 changes

includes faster arm speed, faster drivebase speed, faster outtake speed, faster everything
also mid preset update

Might want to merge with main to clean up the diff. Also as a miscellaneous note we should probably try to find a way to reduce the drivebase NT boilerplate, but that's low priority.


Integrate VILLAScommon submodule

This integrates the VILLAScommon sub-module directly into VILLASnode.
It is the first step, next we will repeat this for VILLASfpga.
/cc @windrad6 @fwege @n-eiling @al3xa23

Btw. I managed to keep the history of the VILLAScommon repo 🥳

@n-eiling

I would say this only makes sense if we merge fpga as well, and at the same time.

I agree. Do you think we should do this in the same PR? I was planning to open another one shortly after this one is merged. But we can also do it all in one go.

I would keep libxil as a separate repository.

I agree.

Do I need to do anything in fpga to make this work? Running clang-format for example.

No, not necessarily. But as soon as we have integrated the VILLASfpga code into VILLASnode, I would go ahead and run clang-format over everything once again.

What about the CI? We also need to merge that.

Yes, I already did this for VILLAScommon. Its merely a merge of the .gitlab-ci.yml files.

We should probably not build fpga per default, because most setups don't need it. What do you think?

I agree as long as we enable it in the CI. Because I dont want to have any untested/compiled code in the repo.

Doing it separately is fine with me. Just wanted to make sure :)
I support this PR.
The CI fails, and we need some sign-offs (Sonja and Hatim may be an issue?)


Outdated method?

The use of this method results in the following error:
UnhandledPromiseRejectionWarning: TypeError: client.database(...).container(...).items.query(...).toArray is not a function
I have solved this by using fetchAll() instead of toArray()

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c37e9125-19f4-ed9c-5b69-a42dfb6d42b8
Version Independent ID: bd2b39bc-ed3d-8c21-f620-5e094b491aee
Content: Azure Cosmos DB: Build a Node.js app using JavaScript SDK to manage Azure Cosmos DB SQL API data
Content Source: articles/cosmos-db/create-sql-api-nodejs.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @deborahc
Microsoft Alias: dech

@djimmo Thank you very much for your detailed feedback and providing the solution. I will have this addressed in the documentation. If you encounter any additional issues, please continue to use this process to highlight issues and product anomalies.

The area being pointed out is the following:
A SQL query over JSON is performed.
`const querySpec = {
query: "SELECT VALUE r.children FROM root r WHERE r.lastName = @lastName",
parameters: [
{
name: "@lastName",
value: "Andersen"
}
]
};
const { result: results } = await client.database(databaseId).container(containerId).items.query(querySpec).toArray();
for (var queryResult of results) {
let resultString = JSON.stringify(queryResult);
console.log(\tQuery returned ${resultString}\n);
}`
@deborahc  Assigning this to the content team to evaluate and update.

@djimmo The above PR fixes the doc, we will now close this issue.
#please-close


(undefined) message displayed on the dashboard

Not sure what it means in this context, but it is certainly disturbing in term of ux

It should show the preset value. So this somehow was returned from the settings or current status as 'undefined'.  From the image it seems created (stopped), but not started.


maintainer needed?

hey all, I see that some ppl use/need s2i-go, but the repo is kind of frozen. Do we have an active maintainer? Do we need on?
cc: @bparees @danmcp

we should probably see if the SCL team that maintains most of the other language images at this point would be interested in creating an official version of this and maintaining it.  @hhorak wdyt?

There are plans to have golang s2i image (just one version) quite soon, but just as tech-preview. Would that be enough for your needs? @goern

@hhorak sure I think there is lots of good work happening in this repo's fork network, we should somehow try to get it back in sync with this repo...

Any updates on this? Would be happy to help out of work is happening on it

Hey, actually we have a different repo that should be maintained better -- https://github.com/sclorg/golang-container and an s2i image is now available as https://hub.docker.com/r/centos/go-toolset-7-centos7/


Location for PHSA & BCLC Collaboration notes

Describe the issue
Create Teams folder & documents to capture details from separate collaboration meetings with us & PHSA & BCLC
Which Sprint Priority is this issue related to?
The 'Milestone' should clearly list Sprint Priorities - which one is this issue related to?
Additional context
Add any other context, attachments or screenshots
Definition of done
Create Teams folder & documents for both BCLC & PHSA collaboration notes

Team folder created & initial docs created for both PHSA & BCLC.
Added my notes from each meeting to the documents.


Use of unresolved identifier 'Pigeon_project'

Im running to this error when i compile my app.

Use of unresolved identifier 'Pigeon_project'

https://imgur.com/a/y1rBp66

I'm getting the same issue. Any luck on a fix?

Committed major changes to the repo, should be fixed now.


Requests going to the 1st IP always if it's up during Round Robin Connect (ROUND_ROBIN_CONNECT)

OrientDB Version: 3.0.15
Java Version: 1.8.0_211
OS: Windows/Cent OS
Expected behavior
Connection creation should be evenly distributed across the nodes.
Actual behavior
Unfortunately, connections are being created ONLY with the 1st IP in the list. This happens regardless of whether you use a connection pool or not. However if that particular IP is down, then other IPs is/are used (I think only one of them).
Steps to reproduce
I'm using
OStorageRemote.CONNECTION_STRATEGY strategy = OStorageRemote.CONNECTION_STRATEGY.ROUND_ROBIN_CONNECT;
OGlobalConfiguration.CLIENT_CONNECTION_STRATEGY.setValue(strategy);
OrientDBConfig config = OrientDBConfig.builder().addConfig(OGlobalConfiguration.CLIENT_CONNECTION_STRATEGY, strategy).build();
OrientDB orient = new OrientDB("remote:<IP_ADDRESS>;<IP_ADDRESS>;<IP_ADDRESS>", config);
ODatabasePool dbPool = new ODatabasePool(orient,
                                        "database",
                                        "root",
                                        "root",
                                        config);
ODatabaseSession session = dbPool.acquire();

Hi,
This should be already fixed in more recent version of 3.0.x.
Regards


add file TextFiles.gitattributes and add folder ".override/"

Hello, folks!
I found a closed issue here: github/alexkaratarakis/gitattributes/issues/176 with this old idea.

I would like to know if I've thought about creating a folder called ".override" to add .gitattributes files related to document files like txt, html, markdown, xml etc.

I find this idea interesting and would like to contribute, help.

Have you all ever thought of creating a folder called ".override" to add .gitattributes files related to document files like txt, html, xml, markdown?

This pull-request is the solution to this question. For example, here is a .gitattributes file where I have forced GitHub to count all Txt files towards my language stats, except for readme.md.
Use case: This is very interesting when you have a repository full of text files like blog posts or website content. And you want to show statistics in your repository related to the amount of text you've written. For this use case to be satisfied, it is necessary to use the .gitattributes file with these options configured;
filepath: .override/TextFiles.gitattributes
*.txt linguist-vendored=false
*.txt linguist-generated=false
*.txt linguist-documentation=false
*.txt linguist-detectable=true

why a folder called ".override/"?
The folder ".override" serves to separate source code file vs document file.
img-before

img-after

where did your idea come from?
I read these 3 links and did something based on it:

Override languages being included by language statistics: Here is how to create a .gitattributes file with override.
Markdown language is not detected: Here it says why files in md, txt format are ignored in the count.
How to Get Github to Recognize a Pure Markdown Repo: Here it teaches step by step how to create a .gitattributes file with override and why it works.

The reason for using ,override folder could be better justified.
I think we could just store them in the root.

Can this be closed as no longer relevant?


AWS S3 access key required

Hello,
I'm trying to install your package on a fresh Ubuntu instance.
I wonder why the make script asks me for AWS access key? I'm not planning on using AWS services.
If it's required, what kind of key/access are required?
Thank you for this great work.

Hi, apologies for late response.
It's to access public bucket, but let try to do a better job here. Will update.

We realized there might be an issue by using the s3cmd cli, I will work on removing this step for the setup and make it optional.

Fixed by #84


(Opera) AU - no new version

No new version of Opera in repo. As I understood, choco-bot must autoupdate it, but it wasn't

thanks for opening this issue, I've looked at the problem regarding this and seems like we are incorrectly sorting the versions when we try grabbing the latest version.
I'll see if I can't get it updated asap (working on also adding 64bit to the package, so may take some time)

this is now in the process of getting pushed to chocolatey.org.
Once again, thank you for opening this issue.


Error in initImplicitFlow

After upgrading to Angular 6 and angular-oauth2-oidc 4.0.2 I am getting following error when i call this.oauthService.initImplicitFlow('/');

I am blocked, any help would be appreciated.

I am encountering the same issue. I would like to know what your resolution was :)

In angular-oauth2-oidc 4.0.2 you will have to set the configuration via oauthService.configure() method.
for example
const authConfig: AuthConfig = {
issuer: 'https://steyer-identity-server.azurewebsites.net/identity',
redirectUri: window.location.origin + '/index.html',
clientId: 'spa-demo',
scope: 'openid profile email voucher',
oidc : true
}
this.oauthService.configure(authConfig);


Error on trying to run SSR

Hello, I'm trying out the SSR example project made by @eddyerburgh from here: https://github.com/eddyerburgh/vue-cli-ssr-example
When I tried to run the build to run production server, it shows me this:

Any clue what went wrong? Thank you! @yyx990803

Ah, turns out this error is from importing ./register-service-worker, which was added by default on vue-cli 3 main.js file. While the example project here doesn't call that module.

Hi @eddyerburgh sorry for the misplacement. I was thinking to put it here because in your example you're not using registerServiceWorker from the latest vue-cli 3, so I thought of asking it here since the library is the one causing the error.
I've fixed this issue by move the import script of registerServiceWorker.js to entry-client instead.


Consider migrating from Docker Hub to the GitHub Container Registry

Unfortunately Docker have decided to suspend free teams access which will affect the InspIRCd container.
https://blog.alexellis.io/docker-is-deleting-open-source-images/
As we're already on GitHub a good alternative to this would be the GitHub Container Registry. The main downside to this would be that existing container users will need to manually migrate.
Thoughts? Alternatives? etc.

Plenty of projects did exactly this, i dont see any downsides, if someday GitHub does the same thing, you can just look again for somewhere else to go!

I support the move to GitHub. Docker seems content to shoot their feet.

don't use docker for inspircd but ghcr seems like a solid alternative

I've looked into the Docker-Sponsored Open Source Program and I'm unwilling to go through this because:

Despite claiming to be for "non-commercial projects" it seems to be designed by someone who thinks that open source projects have an associated company and/or industry. I have no idea how I'd even fill this in.
It apparently requires me to dox my anonymous GitHub Sponsors which I'm not willing to do (pretty sure this is against the GitHub TOS too).

I'm working on moving over to the GitHub Container Registry now. Will report back soon.

On March 14, 2023, we emailed you about your Free Team subscription, outlining our intention to sunset that plan. After listening to the concerns of the community, we’ve decided to reverse course, and are no longer sunsetting the Free Team plan.

Looks like Docker have changed their mind. I might look into publishing on both GHCR and Docker Hub to future proof things though.


[tests-only] CERNBox setup for ScienceMesh tests

Merging as this is for tests. An issue remains, to be sorted out at a later stage.


Request a Cert with a Friendlyname without Date. Possible?

I need a Cert with a special friendlyname. The cert need the friendlyname "vdm", so the App VMware can find the needed cert in the windows cert store.
Is it possible to get a cert with a friendlyname without the "@ + yyyy.mm.dd ....."?
Best regards
Sven

That would require a little bit of Powershell, which you can include as a script installation step:
https://dscottraynsford.wordpress.com/2017/06/09/change-the-friendly-name-of-a-cert-with-powershell/

Thx for your support.
So it doesn't help, because every time the cert is renewed it get a new thumbprint.
Better is to find it with the old Firendlyname like this.
PS> (Get-ChildItem -Path Cert:\LocalMachine\My\ | Where-Object {$_.FriendlyName -like "FRIENDLYNAME @*"}).FriendlyName = "FRIENDLYNAME_NEU"
This works, when you only have one cert like this, when you have more in this store you must identify it with something like subjectname too.

For future reference: the certificate thumbprint can be provided as a parameter to an installation script, if you want want to rely on more fuzzy heuristics.

Thx for your support.
So it doesn't help, because every time the cert is renewed it get a new thumbprint. Better is to find it with the old Firendlyname like this.
PS> (Get-ChildItem -Path Cert:\LocalMachine\My\ | Where-Object {$_.FriendlyName -like "FRIENDLYNAME @*"}).FriendlyName = "FRIENDLYNAME_NEU"
This works, when you only have one cert like this, when you have more in this store you must identify it also with something like subjectname.

Thank you for this. I went ahead and created a script with a little bit of logic so it restarts the services only when the cert is changed and set it as an additional step in wacs.
#Rename friendly name to vdm from wacs.exe auto
#named scheme with date as VMWare View requires
#vdm as the friendly name. Restart web services
#afterwards.
#
# Rename cert's friendly name
(Get-ChildItem -Path Cert:\LocalMachine\My\ | Where-Object {$_.FriendlyName -like "vdm @*"}).FriendlyName = "vdm"
if ($?)
{
   Write-Host "Renamed Certs Friendly Name"
   Write-Host "Restarting wsbroker"
   restart-service -Name wsbroker
}
else
{
   Write-Host "Cert hasn't changed, exiting..."
}

This works for the security broker and connection server, since they are both the same name.


[stdlib] use @inlinable @inline(always) for Optional equality

Optional's various == operators were inconsistent in their use of @inlinable or @_transparent. As a consequence, the detailed diagnostics surrounding Optional with == and != differ strangely based on minute details. Another PR tried setting them all to @_transparent (https://github.com/apple/swift/pull/59327). This one tries setting them all to @inlinable @inline(__always). Benchmarking may have different results.
Resolves rdar://46444561

@swift-ci please test

@swift-ci please benchmark

Performance (x86_64): -O

Regression
OLD
NEW
DELTA
RATIO

LessSubstringSubstring
23
30
+30.4%
0.77x

EqualSubstringSubstring
23
30
+30.4%
0.77x

EqualStringSubstring
23
30
+30.4%
0.77x (?)

EqualSubstringString
23
30
+30.4%
0.77x (?)

LessSubstringSubstringGenericComparable
23
30
+30.4%
0.77x (?)

EqualSubstringSubstringGenericEquatable
23
29
+26.1%
0.79x

StringUTF16Builder
190
220
+15.8%
0.86x (?)

StringBuilder
180
206
+14.4%
0.87x (?)

FindString.Loop1.Substring
264
302
+14.4%
0.87x (?)

StringBuilderSmallReservingCapacity
187
213
+13.9%
0.88x (?)

StringComparison_longSharedPrefix
293
331
+13.0%
0.89x (?)

StringAdder
237
266
+12.2%
0.89x (?)

StringInterpolationSmall
1090
1200
+10.1%
0.91x (?)

SortStringsUnicode
1945
2110
+8.5%
0.92x

Set.isDisjoint.Box.Empty
52
56
+7.7%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstring
3
2
-33.3%
1.50x

Dictionary4
218
152
-30.3%
1.43x

UTF8Decode_InitDecoding
163
124
-23.9%
1.31x (?)

Dictionary4OfObjects
264
207
-21.6%
1.28x

UTF8Decode_InitFromCustom_contiguous
158
126
-20.3%
1.25x (?)

UTF8Decode_InitFromCustom_noncontiguous
277
241
-13.0%
1.15x (?)

Set.isStrictSubset.Int0
82
75
-8.5%
1.09x (?)

Set.isStrictSubset.Box0
84
77
-8.3%
1.09x (?)

Set.isSuperset.Seq.Int0
124
115
-7.3%
1.08x (?)

DictionaryKeysContainsNative
15
14
-6.7%
1.07x (?)

Code size: -O
Performance (x86_64): -Osize

Regression
OLD
NEW
DELTA
RATIO

LessSubstringSubstring
23
30
+30.4%
0.77x (?)

EqualSubstringString
23
30
+30.4%
0.77x (?)

LessSubstringSubstringGenericComparable
23
30
+30.4%
0.77x (?)

EqualSubstringSubstring
23
29
+26.1%
0.79x (?)

EqualStringSubstring
23
29
+26.1%
0.79x (?)

EqualSubstringSubstringGenericEquatable
23
29
+26.1%
0.79x (?)

StringWalk
1240
1520
+22.6%
0.82x (?)

FlattenListFlatMap
2548
3107
+21.9%
0.82x (?)

StringBuilderSmallReservingCapacity
186
221
+18.8%
0.84x (?)

StringBuilder
178
211
+18.5%
0.84x (?)

FindString.Loop1.Substring
253
299
+18.2%
0.85x (?)

StringAdder
223
256
+14.8%
0.87x (?)

DataCreateEmptyArray
1400
1600
+14.3%
0.88x (?)

StrComplexWalk
2760
3140
+13.8%
0.88x (?)

NSStringConversion.InlineBuffer.ASCII
220
250
+13.6%
0.88x (?)

StringComparison_longSharedPrefix
294
332
+12.9%
0.89x (?)

Chars2
3100
3450
+11.3%
0.90x (?)

Data.hash.Empty
47
52
+10.6%
0.90x (?)

StringUTF16Builder
190
210
+10.5%
0.90x (?)

SortStringsUnicode
1970
2170
+10.2%
0.91x (?)

CharIteration_ascii_unicodeScalars
4840
5280
+9.1%
0.92x (?)

Set.isDisjoint.Seq.Int.Empty
45
49
+8.9%
0.92x (?)

CharIteration_tweet_unicodeScalars
9480
10320
+8.9%
0.92x (?)

CharIteration_korean_unicodeScalars
6040
6560
+8.6%
0.92x (?)

StringMatch
4900
5300
+8.2%
0.92x (?)

SubstringEqualString
166
179
+7.8%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

UTF8Decode_InitFromCustom_contiguous
160
124
-22.5%
1.29x (?)

UTF8Decode_InitDecoding
160
125
-21.9%
1.28x (?)

Diffing.Same
5
4
-20.0%
1.25x (?)

UTF8Decode_InitFromCustom_noncontiguous
275
247
-10.2%
1.11x (?)

Array2D
4640
4176
-10.0%
1.11x (?)

PrefixWhileAnySequence
192
173
-9.9%
1.11x (?)

Set.isDisjoint.Empty.Int
89
81
-9.0%
1.10x (?)

Set.isDisjoint.Empty.Box
90
82
-8.9%
1.10x (?)

Set.isDisjoint.Seq.Empty.Box
91
83
-8.8%
1.10x (?)

Set.isSuperset.Seq.Int.Empty
92
84
-8.7%
1.10x (?)

Set.isDisjoint.Seq.Empty.Int
88
81
-8.0%
1.09x (?)

Set.isDisjoint.Seq.Int100
126
116
-7.9%
1.09x (?)

DistinctClassFieldAccesses
245
226
-7.8%
1.08x (?)

RemoveWhereFilterInts
27
25
-7.4%
1.08x (?)

ArrayInClass
1195
1110
-7.1%
1.08x (?)

Set.subtracting.Seq.Empty.Box
149
139
-6.7%
1.07x (?)

Code size: -Osize
Performance (x86_64): -Onone

Regression
OLD
NEW
DELTA
RATIO

EqualSubstringSubstringGenericEquatable
26
33
+26.9%
0.79x

EqualStringSubstring
28
35
+25.0%
0.80x (?)

LessSubstringSubstringGenericComparable
26
32
+23.1%
0.81x (?)

LessSubstringSubstring
28
34
+21.4%
0.82x (?)

EqualSubstringSubstring
28
34
+21.4%
0.82x (?)

EqualSubstringString
29
35
+20.7%
0.83x

SIMDReduce.Int8
6184
7176
+16.0%
0.86x (?)

StringRemoveDupes
498
572
+14.9%
0.87x (?)

SetSymmetricDifferenceInt100
395
452
+14.4%
0.87x

ObjectiveCBridgeStubToNSStringRef
110
125
+13.6%
0.88x (?)

RC4
11231
12391
+10.3%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

UTF8Decode_InitDecoding
166
131
-21.1%
1.27x (?)

UTF8Decode_InitFromCustom_contiguous
168
133
-20.8%
1.26x (?)

StackPromo
34600
29000
-16.2%
1.19x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 32 GB

Benchmarks have similar noise, wins and losses as https://github.com/apple/swift/pull/59327.
The tests depend on the behaviour of @_transparent, though, so they'd need to be adjusted.
@lorentey Can you think of a reason to take this version over the other?


WIP: HTML improvement

I started to work on the HTML page. Currently I have done:

Cleaned up HTML / JavaScript / CSS coding style.
Added Bootstrap, a popular style library that is used in Qiita.
Redesigned page layout, improved visual effect.

Coverage remained the same at 79.039% when pulling c0fbfe025e8dadb2c378b9b3156eb9120fa72852 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

Coverage remained the same at 79.039% when pulling 108d82e104c88c64b3ed21d9792a5e7ddf70cd12 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

Coverage remained the same at 79.039% when pulling 108d82e104c88c64b3ed21d9792a5e7ddf70cd12 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

2 very small comments :)

Coverage remained the same at 79.039% when pulling e752815ac7a0d2b9e1ea0abbbb44841efb103fa3 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

Coverage remained the same at 79.039% when pulling e752815ac7a0d2b9e1ea0abbbb44841efb103fa3 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

Coverage remained the same at 79.039% when pulling e752815ac7a0d2b9e1ea0abbbb44841efb103fa3 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

Coverage remained the same at 79.039% when pulling e752815ac7a0d2b9e1ea0abbbb44841efb103fa3 on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.

Coverage remained the same at 79.039% when pulling 8e4855f9e3581a3acd7360152a918a0f15a8331a on qiyunzhu:html into 4805056dd33cde10971e35a8f0dccd5ea0f26c5f on amnona:develop.


Any text gets deleted

no text shows when i have optifabric in the mod folder

To debug this, I need you to find options.txt and change glDebugVerbosity to 3, then reproduce the bug, then upload logs/latest.log

merged to https://github.com/qouteall/ImmersivePortalsMod/issues/916


Clean up unused deps

Wanted to add -Dunused-crate-dependencies to CI's RUSTFLAGS, but realized some crates may be used conditionally, e.g. dependent on the target platform. So it seems we don't have a better, automatic way to do deps cleanup.

Please keep log. I know that it looks unused, but I need it when debugging web app specific issues in the compiler (can't use print) and it's a hassle to add it manually. It's in the dependency tree anyway, so it doesn't make any difference performance-wise.

Thanks!


is there an ability to add support for passing --vars to the dbt_command?

i believe because of the need to have a colon the yaml isnt playing nicely, unless im missing something
example:
    - name: dbt-deps
      uses<EMAIL_ADDRESS>      with:
        dbt_command: "dbt deps --target pr --vars 'schema_id: 123' --profiles-dir ."

i consistently get an error like this no matter which syntax for vars i try:
Error: Invalid value for '--vars': String ''schema_id:' is not valid YAML

I also tried some other fixes like prefacing the dbt_command string with a | or a > or escaping the quotes, but i think the problem is the colon
if you have any other suggested fixes for this that would be awesome!

DBT commands that follow the correct format for YAML would be something like this:
dbt deps --target pr --vars "{'schema_id':'123'}" --profiles-dir .

or
dbt deps --target pr --vars "{'schema_id':123}" --profiles-dir .

As seen in: https://discourse.getdbt.com/t/confused-with-cli-vars-syntax/12355
It is possible that you will have to escape some of the quotes to have this working for github actions. Here are some examples: https://unix.stackexchange.com/questions/30903/how-to-escape-quotes-in-the-bash-shell

Found that the issue is the space in the --vars yaml. The parser that reads the dbt_command string and translates it into argument tokens sees the space in the vars yaml as a separator between tokens.
More explanation on the whitespace being seen as a token: https://unix.stackexchange.com/questions/234755/command-line-processing-tokens-and-metacharacters
This issue is solved in other yaml configuration files by seperating the command from the argument list, like is done here: https://github.com/twpayne/chezmoi/discussions/1706
Example:
 dbt_command:
   - command: dbt
     args:
       - deps
       - --target
       - pr
       - --vars
       - 'schema_id: 123'
       - --profiles-dir
       - .

or this:
dbt_command:
   - command: dbt
     args: ['deps', '--target', 'pr', '--vars', 'schema_id: 123', '--profiles-dir', '.']

Found that the issue is the space in the --vars yaml. The parser that reads the dbt_command string and translates it into argument tokens sees the space in the vars yaml as a separator between tokens.
More explanation on the whitespace being seen as a token: https://unix.stackexchange.com/questions/234755/command-line-processing-tokens-and-metacharacters
This issue is solved in other yaml configuration files by seperating the command from the argument list, like is done here: twpayne/chezmoi#1706 Example:
 dbt_command:
   - command: dbt
     args:
       - deps
       - --target
       - pr
       - --vars
       - 'schema_id: 123'
       - --profiles-dir
       - .

or this:
dbt_command:
   - command: dbt
     args: ['deps', '--target', 'pr', '--vars', 'schema_id: 123', '--profiles-dir', '.']

There might be another solution if I can find where the dbt_command is translated into what is executed in the docker container. The issue is that I cannot seem to find the part of the code in this repo that is responsible for using the provided value for dbt_command in the action. I can only find the input value here https://github.com/mwhitaker/dbt-action/blob/master/action.yml#L6
@mwhitaker could you point me at the line of code how dbt_command value is executed in the docker container during the action execution?

thanks appreciate the reply here!


fix: nn_trainer, clear _saved flag if model was changed

Change from this PR allows nn_trainer to save model on existing from train function correclty. We assume that model saving shouldn't be ignored if its parameters were changed since the time of previous save. Since chainer.train_on_batch changes parameters, we need to mark the model as 'dirty'.
Previous version of DP didn't clear _saved flag at all. As a result, the trainer didn't save the last version of model if its save method was called at some point during or before training, e.g. in _validate_first mode.

The point is to only save the model if the target metric was improved

OK, makes sense. I'm updating the PR, please review the code since I left some FIXMEs. The points of confusion are:

_validate_first case. if we call _validate via _validate_first branch then we really compare score with inf and can't be sure if we see an improvement or not. I've included a change fixing this. https://github.com/deepmipt/DeepPavlov/blob/master/deeppavlov/core/trainers/nn_trainer.py#L234
train may still save the model regardless of score https://github.com/deepmipt/DeepPavlov/blob/master/deeppavlov/core/trainers/nn_trainer.py#L300
Strange logic in base class FitTrainer, where we set _saved flag without clear reason.

Rebased to 0.6.0.
The current version should follow the below specification, please check. I'm not sure about your last requirement "But we need to remember to not save at the end if all validations after 0-th did not improve".
CC @yoptar
For the validation savepoint:
* 0-th validation (optional). Don't save model, establish a baseline.
* 1-th validation.
   + If we have a baseline, save the model if we see an improvement, don't save otherwise.
   + If we don't have a baseline, save the model.
* 2nd and later validations. Save the model if we see an improvement

For the at-train-exit savepont:
* Save the model if it happened before 1st validation (to capture early training results), don't save otherwise.


Better documentation for available default validators

Is your feature request related to a problem? Please describe.
Currently you have to look at the code to figure out the arguments, and they won't be auto-completed by an IDE.
Describe the solution you'd like
Some sort of auto-generated docs, or at least a configurable list.
Describe alternatives you've considered
Could do it manually.

We are moving repositories! Please see the new version of this issue at https://github.com/DAGWorks-Inc/hamilton/issues/36. Also, please give us a star/update any of your internal links.
Note that everything else (slack community, pypi packages, etc...) will not change at all.


Sheet wrap content LazyColumn verticalScroll throws Exception

FATAL EXCEPTION: main
java.lang.IllegalStateException: Vertically scrollable component was measured with an infinity maximum height constraints, which is disallowed. One of the common reasons is nesting layouts like LazyColumn and Column(Modifier.verticalScroll()). If you want to add a header before the list of items please add a header as a separate item() before the main items() inside the LazyColumn scope.

LazyColumn should work well within the sheet, any sample code to reproduce the crash?

Closed due to no further information being provided.


Improve C# support for property types

Reason/Context

Support for collectionType = 'List'
The motivation here would be allowing to choose a generic collection type, just as it's done for Java already. Arrays are usually used in very specific cases
Support for more property types
CSharpRenderer supports currently 5 property types, while Java supports 17.

Description

It can be resolved by adding a simple condition in CSharpRenderer.toCSharpType, which would return something else than SomeType[]. I'm also thinking what type of a collection should be returned if 'List' is specified as collectionType. The obvious choice would seem to be List<T>, but from my experience I can say the best practice for .NET would be using IEnumerable<T> which is way more generic. Changing that would require adding a dependency to using System.Collections.Generic; in CSharp's ClassRenderer, but that's also a one-liner.
That's not a breaking change, it adds an option of using more generic collection types, and arrays would be supported just as they're now.

The resolution here would be pretty much copy-pasting the switch case from JavaRenderer.toJavaType to CSharpRenderer.toCSharpType and fixing just a couple of 'typos'. This would allow using types such as double or System.DateTime which are obviously very useful.
It's also not a breaking change by any means. Support for all of the other property types would be there almost unchanged.

And I have already made a PR for it


Create openjdk14-binaries and openjdk15-binaries repos

In order to facilitate openjdk HEAD builds (see https://github.com/AdoptOpenJDK/openjdk-build/issues/1467) it would be good if we had a place to upload nightly releases. Right now there are neither openjdk14-binaries repos nor openjdk15-binaries repos on github. It would be great if somebody could create them.

Thank you for raising this, it was a request that was also echoed by participants at the August OpenJDK committers workshop to the question, "what can we do at the project from a test perspective that would be helpful to OpenJDK developers?".  The answer was build tip, test lots, raise issues early.

Created new repositories called openjdk14-binaries and openjdk15-binaries.
Please check they are as you expected.

Thanks! Looks good. I'll find out once pipelines for 14 and tip are up and running (and they try to publish results there). :)


App orientation resets after closing Modal

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
Environment:
OS: macOS High Sierra 10.13.5
Node: 8.11.3
Yarn: 1.7.0
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 3.1 AI-173.4819257
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: https://github.com/expo/react-native/archive/sdk-28.0.1.tar.gz => 0.55.4
Description
App orientation resets after closing a Modal. This occurs when opening the Modal after orientation change. As well as when changing the orientation while the Modal is opened.

Reproducible Demo
https://snack.expo.io/SJUe2-D4m

I can confirm that.


docs: Clarification for MySQL/Mariadb

I noticed in the installation guide that there are 2 separate packages for MySQL (@mikro-orm/mysql) & MariaDB (@mikro-orm/mariadb) but the inline comments for both have the same description for both. Are these currently interchangeable? Is the older one expected to be deprecated soon?
https://github.com/mikro-orm/mikro-orm/blob/ae81ca98a12d04081b9ca934b492d0c916dee30d/docs/versioned_docs/version-5.3/installation.md?plain=1#L14-L15
https://github.com/mikro-orm/mikro-orm/blob/ae81ca98a12d04081b9ca934b492d0c916dee30d/docs/versioned_docs/version-5.3/installation.md?plain=1#L24-L25
The inline comment should be updated accordingly.

They are both compatible with mysql as well as mariadb. That's all what it means, its up to you what you want to use, they are compatible.


Removing the squash flag

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] All new and existing tests passed.
[x] The code follows the code style and conventions of this project.
[ ] The change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Description of the change

Removing the squash flag
Motivation for the change

Experimental feature that is not available on standard docker install

@dluc
Tried on few and didn't see much difference if any.
| Local Image   (Before) | Local Image   (After) | Difference | Docker Hub   (Before) | Docker Hub (After) | Difference
-- | -- | -- | -- | -- | -- | --
WebUI | 24 MB | 25 MB | 1.13 MB | 7 MB | 7 MB | 0
Device   Simulation  dotnet | 274 MB | 247 MB | 0.1 MB | 113 MB | 113 MB | 0
IoTHub Manager   dotnet | 256.38 MB | 256.38 MB | 0 | 108 MB | 108 MB | 0
Storage Adapter   java | 123.72 MB | 123.72 MB | 0 | 96 MB | 96 MB | 0

nice, thanks for checking


Is it reasonable to make ngx-wig compatiple to use inside a mat-form-field

I am trying to use ngx-wig inside my material angular app. This seem to work as an independent input that I wrapped inside a div.
To get a consistent experience with other fields on a material form, it might be better to be able to wrap ng-wig inside a mat-form-field directive.
Google have instruction to do so https://material.angular.io/guide/creating-a-custom-form-field-control.
Anyone have thought or even a try?

We are working on it...

hey @hungcao181, right now I'm working on it, there will be distinct library with ngx-wig as a dependency with already-made styles

@hungcao181 @stevermeister check it out https://www.npmjs.com/package/mat-ngx-wig


Initial commit to support world-clouds visualization

closes #12
Basic implementation for word-clouds visualization
Add wordcloud to list of  in "requirements.txt" file

Thank you Selim!
It may be opportune to have as input a pd.Series rather than a pd.Dataframe.
Also, for joining the text we may want to use:
>>> import pandas as pd
>>> s = pd.Series(["a", "b", "c"])
>>> s.str.cat(sep=' ')
'a b c'

Can you also add some unittest? You can look at the official world_cloud tests.

I have changed the function have as input a pd.Series @jbesomi .
Regarding unit tests. I have checked official world_cloud tests. However current implementation of the word cloud method would not allow for implementing similar tests. Maybe we can have an underlining method _get_world_cloud which gets the WordCloud object which we can then test for words ..etc?
Do we only need to test the words in the generated word cloud? What else would you want to test?

Thank you. Closing for now.


[Question]: XCode@5 overrides bundle identifier for all targets in the scheme

Task name
No response
Task version
No response
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
iOS
Question
our project earlier contained only one target that was the Designer (main app) target with bundle id com.microsoft.designer

I recently added a new target NotificationServiceExtension with bundle identifier as `com.microsoft.designer.NotificationServiceExtension

The below snippet gives an overview of the existing task which we currently have as part of our build pipeline. As part of this task, I am dynamically updating my app bundle id via args parameter.

- task: Xcode@5
        inputs:
          actions: "archive"
          scheme: "Designer"
          sdk: "iphoneos"
          configuration: "Release"
          xcWorkspacePath: "iOS/ios/Designer.xcworkspace"
          signingOption: "manual"
          signingIdentity: "$(APPLE_CERTIFICATE_SIGNING_IDENTITY)"
          provisioningProfileUuid: "$(DevelopmentProfile.provisioningProfileUuid)"
          args: >
            -archivePath $(System.DefaultWorkingDirectory)/Builds/Designer
            -derivedDataPath $(System.DefaultWorkingDirectory)/ddrpath
            LD_GENERATE_MAP_FILE=YES
            LD_MAP_FILE_PATH=$(System.DefaultWorkingDirectory)/ddrpath/linkmap.txt
            DEVELOPMENT_TEAM=9KBH5RKYEW
            ASSETCATALOG_COMPILER_APPICON_NAME=AppIconDogfood
            PRODUCT_BUNDLE_IDENTIFIER=com.microsoft.designer-dogfood

The issue I am facing is that the pipeline though correctly overwrites the bundle id in the main app target as com.microsoft.designer-dogfood but it also overrides the bundle identifier in the extension target as the same whereas we expect it to be com.microsoft.designer-dogfood.NotificationServiceExtension

Is there a way I can specify targets while setting these args so that I get separate bundle ids for each of my targets? Or as an alternative, if anyone could provide any insight on how we can dynamically update the bundle identifier using the pipeline task

You found any solution for this ?

I added a work around for this. Created multiple configs on Xcode with their corresponding team id and bundle identifier and linked the same config here with configuration param. I guess this can be considered as a working solution for the time being for the ticket

Any news about this issue? I have the same issue and wonder why I need to do the work around?


Workspace - Schedule a setup call button not displayed for expensifail account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing https://github.com/Expensify/App/pull/20639
Action Performed:

Open the app
Login with private domain account or expensifail account
Go to settings
Go to workspaces
Select a workspace
Click the help icon in header (get assistance)

Expected Result:
Schedule a setup call button displayed
Actual Result:
Schedule a setup call button not displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

@kbecciv can you please share the slack conversation link?

Bumped the discussion in Slack.

Based on this discussion in Slack, this is expected behavior, not a bug. Closing this!

@Expensify/applause @Expensify/applauseleads Hey team, can you please check if those steps are not in a regression test in the workspace editor on NewDot specifically? Thanks!