Add LongLora for both full and lora fine-tuning

Follow up of #1346.
This PR introduces LongLora as in https://github.com/Lightning-AI/litgpt/issues/1237 for both the LoRa and full fine-tuning, while also enabling it during generation.
cc @rasbt

@rasbt to answer your previous question: LongLora is not enabled by default as both longlora_context_length and longlora_n_groups are None, but i agree with to have a simpler way to enable it. As you suggested i can add a LongLoraArgs as you have done in the galore branch: in this way i can also check those args in a separate function (like
the validate_train_args)

Thanks! I think LongLoraArgs might be better, especially if it can be used in multiple approaches, e.g., full and lora

I've just trained a model with
python litgpt/finetune/lora.py \
--config=/teamspace/studios/this_studio/litgpt/config_hub/finetune/mistral-7b/longlora.yaml \
--checkpoint_dir=/teamspace/studios/this_studio/litgpt/checkpoints/mistralai/Mistral-7B-Instruct-v0.1

One generation that I've obtained with
python litgpt/generate/base.py \
--checkpoint_dir ../out/finetune/lora-mistral-7b/final \
--prompt="Recommend a movie for me to watch during the weekend and explain the reason." \
--max_new_tokens=128

is the following:
Below is an instruction that describes a task. Write a response that appropriately completes the request.

### Instruction:
Recommend a movie for me to watch during the weekend and explain the reason.

### Response:
I recommend the movie "Inception" directed by Christopher Nolan. This is an excellent sci-fi thriller that will keep you on the edge of your seat throughout the entire film. The story follows a professional thief, Dom (played by Leonardo DiCaprio), who is able to steal information from someone's subconscious while they dream. Dom is offered a chance at clemance in exchange for performing the near-impossible task of planting an idea into someone's mind, an act known as Inception.

This movie is a fantastic choice for the weekend because it's not only entertaining, but it also challenges you to think critically about the concepts presented within the film. The plot is twisting and turning, keeping you engaged from beginning to end. Additionally, the special effects and visuals are stunning, making for a truly immersive viewing experience. Moreover, with its all-star cast, including Joseph Gordon-Levitt, Ellen Page, and Tom Hardy, you know you're in for a treat.

Overall, "Inception" is an outstanding choice for the weekend because it provides an exciting and thought-provoking movie experience that is sure to leave a lasting
Time for inference 2: 15.43 sec total, 16.59 tokens/sec
Memory used: 14.67 GB

Sorry for the long silence, and thanks again for this great PR! I have just been a bit swamped with work lately but hopefully can circle back to it some time.

Sorry for the long silence, and thanks again for this great PR! I have just been a bit swamped with work lately but hopefully can circle back to it some time.

Absolutely no worries! Thank you for taking the time to watch this!


Assessment completed

Comfort: 2
Clarity: 3
Looked up objects and attr's.
http://www-rohan.sdsu.edu/doc/ruby/chp_04/classes.html
http://www.java2s.com/Code/Ruby/Class/CreatingReadableandWritableAttributesuseattraccessor.htm

4.5 / 5 (-0.5 on Q3)
Great job, Cara!


Need detail information.

It would be very helpful if there are more explanations on this page on what every thing on the picture means or at least links to other useful sites where all the terminologies are explained.
It would be nice if you add logical network topology for deploying Skype for Business. I found how to   connect to public internet but can not find how to connect the private company wan.
--

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47b56523-5d43-fe49-d754-ec50d2ac43a8
Version Independent ID: 4d729a96-65a1-bf26-f789-a5cf1b55532b
Content: Technical diagrams for Skype for Business Server 2015
Content Source: Skype/SfbServer/technical-diagrams.md
Product: skype-for-business-itpro
GitHub Login: @jambirk
Microsoft Alias: jambirk

detailed explications of most of the posters would defeat the purpose, they are summaries and not detailed docs by their nature.
A workloads poster for SfBO has been proposed and shot down already. The information changes too frequently to make such a poster practical.


Private files in README.md

Add details into the README.md about Python private_files git_ignore.

Thanks for adding this Ryan, I'll add it into the codebase and close this issue when it's done.


Fixed location of DC/OS Signal integration test

High-level description
What features does this change enable? What bugs does this change fix?
This test was at the wrong location.
Corresponding DC/OS tickets (required)

DCOS-ID JIRA title / short description.

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot override-status teamcity/dcos/test/terraform/aws/onprem/static/group2 https://jira.mesosphere.com/browse/DCOS-57770

@mesosphere-mergebot request-review @janisz @br-lewis @drewvanstone

@mesosphere-mergebot changelog-not-required only re-activating an integration test

@mesosphere-mergebot label Holding

@makkes This PR introduces an error - test_signal was not added to the test_groups.yaml. This was masked by the override issued for the other test_groups.yaml error (https://jira.mesosphere.com/browse/DCOS-57770).
It is revealed in the train #6119 which had DCOS-57770 fixed.

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot label Work In Progress

@mesosphere-mergebot label Ready For Review


Binance trading bot is kept loading after logging in with password

Experts please help me. I have run the trading bot interface in the localhost but the binance trading bot is kept loading for hours but no interface is coming. I have created .env file and added my testnet api key and secret. Please help me.

Hello @hiraobayed329
Please take a screenshot of your browser console log and paste it here.

Hello @hiraobayed329
Sorry, I meant the console log of your browser.

Yes exactly.
It seems there is no issue in the frontend.
Could you please check your Docker container logs?

@habibalkhabbaz I am checking the log and its looks good

Don't understand what to do!!!

Hello @hiraobayed329
I could not see an issue.
You may have to restart your Docker container and after that copy the whole log and attach it here.

The logs are too long to paste in there.
Do I have to make any change to any file to get the interface showing in the browser?

Still the bot not working. I am not getting any help. There is not even any tutorial available. Please help me fixing the issue.

@habibalkhabbaz

Hello @hiraobayed329
Sorry for late reply.
It will be helpful if you can attach the log as file here so I can scan it because I couldn't see any issues from the screenshots.

@habibalkhabbaz Hello brother, Please check the word document above "Logs.docx". There i have included the logs. The log history was too large to paste in here so i have attached a word file for that above

https://github.com/chrisleekr/binance-trading-bot/issues/529#issuecomment-1286477208

Hello @hiraobayed329
Sorry, I just see the log file and I think I found the issue.
{
  "name": "binance-api",
  "version": "0.0.93",
  "hostname": "ede4ce74817c",
  "pid": 45,
  "gitHash": "26a1edc",
  "server": "websocket",
  "payload": {
    "command": "latest",
    "authToken": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdXRoZW50aWNhdGVkQXQiOiIyMDIyLTEwLTIxVDA1OjEwOjEzLjkwNVoiLCJpYXQiOjE2NjYzMjkwMTMsImV4cCI6MTY2NjMzNjIxM30.wLYTTUby8VS_CePDamuU--ctP65f1ct3t2LVNCkF6DI",
    "data": {
      "page": 1,
      "searchKeyword": "",
      "sortBy": "default",
      "sortByDesc": false
    },
    "isAuthenticated": true
  },
  "level": 50,
  "err": {
    "message": "Unexpected token u in JSON at position 0",
    "name": "SyntaxError",
    "stack": "SyntaxError: Unexpected token u in JSON at position 0\n    at JSON.parse (<anonymous>)\n    at Object.handleLatest [as latest] (/srv/dist/server.js:1:119233)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)\n    at async WebSocket.<anonymous> (/srv/dist/server.js:1:114883)"
  },
  "msg": "Something wrong with trailing-trade-common cache",
  "time": "2022-10-21T05:15:11.952Z",
  "v": 0
}

For some reason, your account info was not retrieved and it's throwing an error as it is an invalid JSON format.
Here is the code for reference:
https://github.com/chrisleekr/binance-trading-bot/blob/49271ef5993a2c9c579d54bff1d9d81780b99a2f/app/frontend/websocket/handlers/latest.js#L117
I can submit a PR to solve this but still, maybe your frontend will not be updated because no data to retrieve.
We have to find the source of the issue first.
Please check your test API keys if they are correct or not.

@habibalkhabbaz sorry for my late reply. I have generated new binance test API key and secret. Still the bot is loading but no interface is showing up.

@hiraobayed329 I think most likely invalid configuration with your API key.
Are you sure you set the correct mode?
https://github.com/chrisleekr/binance-trading-bot/blob/master/docker-compose.server.yml#L14
If you are using test API key, BINANCE_MODE must be test, not live.
If you are using live API key, BINANCE_MODE must be live.

I'm having the same problem with the same error log. Perhaps something has changed on Binance's return?

replace
const accountInfo = JSON.parse(cacheTrailingTradeCommon['account-info']);
to
const accountInfo = {}
and reload docker compose

Bonjour, j'ai le même problème!

remplacer const accountInfo = JSON.parse(cacheTrailingTradeCommon['account-info']); pour const accountInfo = {}
et recharger docker composer

cela ne résoud pas le problème, comment pouvons -nous avancer?

accountInfo

I have the same problem
I changed it to const accountInfo = {};
and i had the same error

I solved this by updating redlock in package.json to latest, migrating the required steps in /binance-trading-bot/app/helpers/cache.js as I described in the last post of https://github.com/chrisleekr/binance-trading-bot/issues/618 and then building a new version with docker-compose, as well as adding a "while True" loop of about 30 retries with a second in between each and breaking the loop if the lock is released. Haven't had anything freeze at all since then.
I could make a PR about it, but not sure how that works with the build of docker-compose since I am building local images, and the non-dev bot is using publically uploaded images.


Fails to build on FreeBSD

Hello,
When I try to build the crate on FreeBSD 13.2 this error pops up(it works just fine on Linux):
default-net-0.20.0/src/bpf/binding.rs:82:1
   |
69 | pub struct bpf_hdr {
   | ------------------ previous definition of the type `bpf_hdr` here
...
82 | pub struct bpf_hdr {
   | ^^^^^^^^^^^^^^^^^^ `bpf_hdr` redefined here
   |
   = note: `bpf_hdr` must be defined only once in the type namespace of this module

There's two distinct definitions of that struct so I assume one applies to some OS(es) but not others
One idea would be to remove
pub struct bpf_hdr {
    pub bh_tstamp: libc::timeval,
    pub bh_caplen: u32,
    pub bh_datalen: u32,
    pub bh_hdrlen: libc::c_ushort,
}

and to add something like this?
#[repr(C)]
pub struct bpf_hdr {
    #[cfg(any(target_os = "freebsd", target_os = "netbsd"))]
    pub bh_tstamp: libc::timeval,
    #[cfg(not(any(target_os = "freebsd", target_os = "netbsd")))]
    pub bh_tstamp: timeval32,
    pub bh_caplen: u32,
    pub bh_datalen: u32,
    pub bh_hdrlen: libc::c_ushort,
}

or maybe the cfg for the struct fields should be the other way around.
thanks very much!

Thank you for the report !
I addressed a testing shortfall for BSD OS and implemented necessary fixes, including cfg additions.
These changes will be part of the next release.


Add new lines at EOF & add license headers

This PR fixes the comments in the following PRs.

https://github.com/wso2/apim-apps/pull/354
https://github.com/wso2/apim-apps/pull/359
https://github.com/wso2/apim-apps/pull/356

Hi @dulithsenanayake, is this branch used now? 4.2.0-sdk

Closing this since this is no longer needed


Support sophisticated, parsing rules when reading a dictionary

For example, the parser would need to distinguish between characters and integers in the following, SO post:
http://stackoverflow.com/q/37058112/206543
This would depend on the completion of #58

This can be extended to parse documents into dictionaries, etc.


Opening clrModal through checkbox change results in ExpressionChangedAfterItHasBeenCheckedError

Describe the bug
When you try to open a clrModalOpen through a [click] or [change] event on a regular checkbox or clrCheckbox it will throw an ExpressionChangedAfterItHasBeenCheckedError error.
How to reproduce
https://clarity-v3-light-theme-gflxbg.stackblitz.io/
Versions
App

Angular: 9.1
Clarity: 3.1.5

This appears to be a problem with Angular specifically, because the exception is about ng-touched and that is part of Angular forms. Essentially this kind of error occurs when something changes unexpectedly, and probably doesn't appear if you run it in prod mode. Either way, you can read more about this kind of error on this issue: https://github.com/angular/angular/issues/22426. NgModel has an internal behavior that can cause odd behaviors at times because of change detection.
Here is the fix suggestion for you to workaround if necessary: https://stackblitz.com/edit/clarity-v3-light-theme-fhkiov?file=src%2Fapp%2Fapp.component.ts
I don't know what the use case is to open a modal from selecting a checkbox, it seems like an unexpected side effect, but this solution would allow you to do this.
Closing as not Clarity specific.


HDDS-11938. [Website v2] [Docs] [Quick Start] Try Ozone With Kubernetes

What changes were proposed in this pull request?
HDDS-11938. [Website v2] [Docs] [Quick Start] Try Ozone With Kubernetes
Please describe your PR in detail:
Migrate doc from https://ozone.apache.org/docs/edge/start/kubernetes.html to https://ozone-site-v2.staged.apache.org/docs/quick-start/installation/kubernetes
What is the link to the Apache Jira?
https://issues.apache.org/jira/browse/HDDS-11938
How was this patch tested?
Previewed locally.

Thank you for your feedback! I've addressed the missing pages and added them to the migration.
Regarding the heading, I’ve applied the suggested change to 'Hosted Cluster.' Do you think 'Hosted Kubernetes Cluster' might be clearer?

Thanks for the updates.

Do you think 'Hosted Kubernetes Cluster' might be clearer?

Yes, that may be better.

I also think we need to improve the text in follow-up task(s). As a start, it's best to import it as-is.

I would like avoid importing unfinished content into the new website, it will be hard to track and we will just accumulate debt on an already new project. Remember we are going to have 200-300 pages worth of docs. As part of testing for this PR, please try out the steps locally to verify that they are clear and working.

the command
kubectl apply -f .
result in the following error:
error: error validating "kustomization.yaml": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
To resolve this issue, replace the command with:
kubectl apply -k .
The issue and its solution are discussed in detail in this GitHub issue.
Currently, I am testing the documentation in my local environment (wsl on window) and have encountered some additional issues. It seems that the latest release (1.4.1) has no corresponding Docker image, which results in pod initialization failures.
After switching to version 1.4.0,  I encounter the following error and am still investigating:
NAME         READY   STATUS       RESTARTS        AGE
datanode-0   0/1     Error        8 (2m8s ago)    13m
datanode-1   0/1     Pending      0               16m
om-0         1/1     Running      8 (5m44s ago)   17m
s3g-0        1/1     Running      0               17m
scm-0        0/1     Init:Error   8 (2m49s ago)   13m```

It seems that the latest release (1.4.1) has no corresponding Docker image

Thank you for spotting this.  Recently we switched to Rocky Linux, and published new images for existing versions with tags like 1.4.0-rocky to avoid disruption for users of existing images.  1.4.1 was the first release to only have -rocky image.  But the kubernetes examples were not updated, so they still point to 1.4.1.  I think we should publish additional tag 1.4.1 for the 1.4.1-rocky image.

Docker Image apache/ozone:1.4.1 is now available.

Docker Image apache/ozone:1.4.1 is now available.
Thanks for your help

After switching to version 1.4.0, I encounter the following error and am still investigating:

The issue was due to a misconfiguration in my Kubernetes storage. After fixing it, everything started running correctly.
So I believe the content of the document is valid.

Thanks @Eric977 for testing and updating the doc.  @errose28 please take another look.

Hi @errose28
Thanks for the review, and sorry for the mistakes. I have fixed the comments above.


Support fuzzy finding

Given the input "lsp" I would like to match commands such as "LspInfo".
Right now I have to match the casing and search for "Lsp".
Also fuzzy searching in general would help like typing "lsi" to find "L s p Info".

This plugin uses nvim's internal command line autocompletion and it will suggest the same results as command line does ( case sensitive and without fuzzy finding). On the other hand, it uses your input to search in command history and it won't work well with fuzzy finding.
In any case, typing lsp provides the results what you are looking for. Just ensure you use <TAB> to autocomplete it.


Parquet Redshift Copy Schema mismatch

Parquet Redshift Copy does not seem to error on a mismatch of schema, it performs the copy but all column values are null. Orc Redshift copy in comparison gives an error of and does not populate the given bigquery table:
Error while reading data, error message: Mismatch between schema...

@JesseLovelace, is this something we need to as the BigQuery experts about?

More information is needed.  I suspect this may be a question about using Matillion to import from redshift into BigQuery, but there's not enough information to make it actionable.

Closing this for now due to lack of actionable information.


[sg] Filter pipeline runs by status

Summary

Added a query parameter called "status"
URI -- /api/pipeline_runs?_limit=30&_offset=0&status=failed
Added a filter for filtering results by "status" in process_pipeline_runs( )

Tests

Needs further testing on all possible status values

cc:
@tommydangerous @wangxiaoyou1993

Thank you @soumojit ! Could you also update the ApiPipelineRunListHandler to use the status filter?
Regarding testing, you can test the API locally with the steps

Run server locally with ./scripts/dev.sh repo_name or ./scripts/start.sh repo_name
Call endpoint http://localhost:6789/api/pipeline_runs?status=completed or http://localhost:6789/api/pipeline_schedules/[schedule_id]/pipeline_runs?status=failed. You can test these status values: https://github.com/mage-ai/mage-ai/blob/master/mage_ai/orchestration/db/models.py#L188-L193

@wangxiaoyou1993 updated, please take a look.

@soumojit I just tested your PR. It works well. So I'm going to merge it.

@wangxiaoyou1993 sorry, i was unable to respond yesterday. Yes, I had tested this. Thanks for merging!


No data for Pod Status or Container Status in CCO AKS Dashboard 5.2.pbit

Greetings all, I have been using the CCO AKS Dashboard 5.2.pbit file and get all of the data except for Pod Status or Container Status, the data is blank. I am at a loss and ask if there is any troubleshooting i can do to fix it.
I see data in all the other fields except AKS KubePodInventory and AKS ContainerImageInventory..

Hi @TheResearcher1203 , thanks for reaching out. Unfortunately, the AKS dashboard has some time now and may the APIs have changed and so you are not getting the right data. We are now focusing on the Infrastructure and Governance dashboard. However, as a next step, I would suggest the following:

If the tables for those graphs have data, then it most probably would be an error in some of the relations of the data model.
If the tables for those graphs do not have data then most probably the API has changed and there is an error parsing the content.
Thank you!


Compute Nodes

When the cluster is deployed, how do you add resources (compute nodes)?
kube-dns is stuck waiting for resources with "no nodes available to schedule pods"

Hi, thanks for interest!
Currently I'm working on new kubefarm project which uses kubernetes-in-kubernetes and enables node provisioning for it over PXE.
@egeneralov also was thinking to prepare ansible backend for it.
Unfortunately, both implementations are not finished yet, but already now, you can expose kubernetes-in-kubernetes using standard Kubernetes service with nodePort or loadBalancer and join nodes using standard kubeadm binary.
By the way do not forget to fill up the certSANs information, otherwise kubelet and kubectls will refuse the SSL connection
https://github.com/kvaps/kubernetes-in-kubernetes/blob/10ccfb25a67c5a11cff67a984df4efbbdb937371/deploy/helm/kubernetes/values.yaml#L55-L57

Thanks for the reply, I will follow the project on your repo and see the evolution.
We can close the issue for the moment and will open a new one later if needed.


Back

Description

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-114

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-114


Pin the loose dependency (from hiera) on json_pure to something less than 2.0.2

2.0.1 requires Ruby version: >= 0
2.0.2 requires Ruby version: ~> 2.0
FUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUU
https://twitter.com/agentdero/status/765587955612160001

@jhoblitt I think this PR is good. The beaker tests will not setup right, but I think that's unrelated to this change

agreed.  The beaker tests have been completely unreliable on top of travis.


Decompressing the downloaded tar file is very slow

Could you please provide a method to quickly decompress a large number of tar files?

The point of downloading as tar files is to use that directly during
training with webdataset lib
On Wed, Apr 17, 2024, 2:45 PM Nastu Ho @.***> wrote:

Could you please provide a method to quickly decompress a large number of
tar files?
—
Reply to this email directly, view it on GitHub
https://github.com/rom1504/img2dataset/issues/421, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437UUVVTFAFCI73JYCCTY5ZVHDAVCNFSM6AAAAABGLH5EYKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DQMRQHA3TENI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi @rom1504
I searched the entire repository but couldn't find any examples on how to use these tar files, such as the CC3M dataset. I tried many different methods from the WebDataset library, but they all resulted in errors. Why can't there be an example of how to use these datasets provided with each dataset download?


host: Make max job concurrency configurable

Allow configuring the maximum number of jobs the API will allow to be started concurrently from the command line.

@lmars where is it best to raise this for CI?

@josephglanville https://github.com/flynn/flynn/blob/master/test/cluster/cluster.go#L487

LGTM

LGTM


 and

It'd be nice if Bootstrap offered a component to <audio> and <video> tags using the grid.

Hmm could you maybe add more details about this issue? Not sure i understand... O_O

@Gavrisimo Sorry, what I tried to say was that it would be great to have some kind of built-in component so we can use this media tags more easily. Something like audio.js: http://kolber.github.com/audiojs/

audiojs uses a Flash fallback for older browses ( does not exist in them ), which Bootstrap is supposed to support.
And I don't think @fat wants to mess with Flash ;)

@rodrigomuniz
I don't think this should be included in bootstrap. You can always look on html5please.com about specific parts of HTML5:
http://html5please.com/#video
http://html5please.com/#audio

I'm not saying to use audio.js (with flash fallback) :-)
I just see as a cool idea to have media components built-in so we can have standard player to easily work with. We write <video class="player playlist">... and boostrap come up with something like this: http://cl.ly/Ep41


Allow to set predefined template parameters available in all templates

Coverage increased (+0.3%) to 76.433% when pulling adc637fe1e3af7aac47650b1798dce67767cd420 on Hotas2k4:predefined-params into 36b73dd9377e8aad0b7507ba905696d48109a8b5 on Roave:master.

Coverage increased (+0.3%) to 76.433% when pulling 46262612d463e330cc2aa5a97ca4bcf5cd7550af on Hotas2k4:predefined-params into 36b73dd9377e8aad0b7507ba905696d48109a8b5 on Roave:master.

Coverage increased (+0.3%) to 76.433% when pulling 46262612d463e330cc2aa5a97ca4bcf5cd7550af on Hotas2k4:predefined-params into 36b73dd9377e8aad0b7507ba905696d48109a8b5 on Roave:master.

@Hotas2k4 can you prepare release `1.2.0 or should I?

He can't but I can


Requires do not work

Hi, sorry for a trivial request, but I cannot make fuse-box work. It is telling me "module react not found". But I can see that react was correctly bundled in the vendor bundle. Here is my config:
const {
  FuseBox,
  WebIndexPlugin,
  CSSPlugin,
  CSSResourcePlugin,
  JSONPlugin,
  ImageBase64Plugin
} = require('fuse-box');
const statements = require('tsx-control-statements').default;
const fuse = FuseBox.init({
  homeDir: 'src',
  target: 'browser@es6',
  output: 'dist/$name.js',
  transformers: {
    before: [statements()]
  },
  plugins: [
    WebIndexPlugin(),
    [CSSResourcePlugin({ dist: 'dist/css-resources' }), CSSPlugin()],
    JSONPlugin(),
    ImageBase64Plugin()
  ],
  alias: {
    stores: '~/stores',
    images: '~/images'
  }
});
fuse.dev({ port: 3000 }); // launch http server
fuse
  .bundle('app')
  .instructions(' > [index.tsx]')
  .sourceMaps(true)
  .hmr()
  .watch();

fuse
  .bundle('vendor')
  .hmr()
  .target('browser@es6')
  .instructions(' ~ index.tsx'); // nothing has changed here

fuse.run();

and here is my tsconfig.json
{
  "compilerOptions": {
    "target": "ES2017",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "noEmitHelpers": true,
    "importHelpers": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react",
    "baseUrl": "./src"
  },
  "include": ["src"]
}

I can see emitted react in the vendor bundle.
I tried both import React from 'react' and `import * as React from 'react' syntaxes, but none of them work.

Just a note, I cannot use v4 as custom transformers are not supported and I am using "tsx-control-statements" transformer.

@tomitrescak it's supported in v4 since day 1 basically.

fusebox({
  plugins: [
    pluginCustomTransform({
      before: [],
      after: [],
    }),
  ],
});

Ok, got it running with v4, yet Evergreen package is still no-go in v4 due to #1689. I'll close this one and see if #1689 will get any progress.


Add es6 loader to webpack

Lets us use ES6 for new files and slowly move away from Coffeescript.

@differentmatt I've converted the vue CLAs component and it works on my local proxy build.
Definitely worth checking if it works on ie11. (If it doesn't we can tweak the babel config)

Thanks @differentmatt  - Merging!

Cc @sderickson :)

🎉

Hooray! Only one thing could be better -- if replace coffeescript in the game engine (referee, systems, components)

One step at a time @Bryukh 🌱

Woohoo! Have fun with ES6 😄


retry strategy?

For some reason, I din't find the way to setup retry strategy via ClientBuilder,
not implemented yet?
Here disscussion on reddit about similar thing
It would be nice to at least set not only timeout, but also number of retries via ClientBuilder,
but the better way I suppose will be to have trait RetryStrategy with default implementation. So it would be possible to setup how many retries and which time period between retries to use.

For people like me who are too lazy to handle the error source TimedOut themselves could beg the author do that😄
But it's really nice to have something like this possible to make our code looks better:
let client = Client::builder()
        // wait up to 30s to raise the real TimedOut
        .timeout(std::time::Duration::from_secs(30))
        // retry 5 times in 30s
        .timeout_retry_times(5)
        // just some random strategy here to demonstrate
        .timeout_retry_strategy(tokio_retry::strategy::ExponentialBackoff)
        .build()?

And there also exists retry stratagy in ethers-rs.
Maybe reqwest can put it on the agenda.
Or I am glad to submit a pr.

Would love to see this

ℹ I also opened a feature request for retrying futures on tokio: https://github.com/tokio-rs/tokio/issues/5596

See reqwest-retry in https://github.com/TrueLayer/reqwest-middleware


vcpkg artifacts fails on Linux with sh: 1: Syntax error: "(" unexpected

Describe the bug
Attempting to acquire vcpkg artifacts on Linux fails with the message sh: 1: Syntax error: "(" unexpected.
Environment

OS: Ubuntu 20.04 in WSL
Compiler: N/A
vcpkg: 2022-12-14-7ae0d8527fb488fde10a89c2813802dc9b03b6f9

To Reproduce
$ . <(curl https://aka.ms/vcpkg-init.sh -L)
$ vcpkg use ninja

Expected behavior
Ninja is acquired and activated successfully.
Failure logs
ben@pc:~$ . <(curl https://aka.ms/vcpkg-init.sh -L)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4282  100  4282    0     0   4001      0  0:00:01  0:00:01 --:--:--  4001
installing vcpkg in /home/ben/.vcpkg
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 6283k  100 6283k    0     0  4682k      0  0:00:01  0:00:01 --:--:-- 6410k
Downloading standalone bundle 2022-12-14.
ben@pc:~$ vcpkg use ninja
warning: vcpkg-ce ('configure environment') is experimental and may change at any time.
A suitable version of node was not found (required v16.15.1) Downloading portable node 16.15.1...
Downloading node...
https://nodejs.org/dist/v16.15.1/node-v16.15.1-linux-x64.tar.gz->/home/ben/.vcpkg/downloads/node-v16.15.1-linux-x64.tar.gz
Extracting node...
Downloading vcpkg-artifacts bundle 2022-12-14...
npm notice
npm notice New major version of npm available! 8.11.0 -> 9.2.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v9.2.0
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice
Updating registry data from https://aka.ms/vcpkg-ce-default
 Artifact                           Version  Status        Dependency  Summary
 microsoft:tools/ninja-build/ninja  1.10.2   will install              Ninja is a small build system with a focus on speed.

sh: 1: Syntax error: "(" unexpected
                                         [0/0] microsoft:tools/ninja-build/ninja
                                         0% downloading https://github.com/ninja-build/ninja/releases/download/v1.10.2/
ERROR: Error installing microsoft:tools/ninja-build/ninja - Error: failed to download /home/ben/.vcpkg/downloads/tools.ninja-build.ninja-1.10.2-(763464859c7ef2ea3a0a10f4df40d2025d3bb9438fcb1228404640410c0ec22d).zip from any source

Additional context
The same version of vcpkg appears to work just fine on Windows.

I can also repro with the same command the vcpkg artifacts calls internally. It looks like the parentheses around the artifact hash are causing problems.
$ vcpkg x-download /home/ben/.vcpkg/downloads/tools.ninja-build.ninja-1.10.2-(763464859c7ef2ea3a0a10f4df40d2025d3bb9438fcb1228404640410c0ec22d).zip --z-machine-readable-progress --skip-sha512 --url=https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-linux.zip
-bash: syntax error near unexpected token `('

Could you please help to look at this issue?

@BillyONeal  Could you please help to look at this issue?

@markle11m was looking at this. Any updates Mark?

Should be fixed by https://github.com/microsoft/vcpkg-tool/pull/862


Disabling last item is not smooth

Testing #107623
I see that when you disable the last item in the graph, on the next tick, the first 2 items are re-enabled. The interaction feels choppy and almost like a bug. I would think it is not necessary to do this, allowing an empty graph should be okay. If we must show something, I think the interaction should instantly change state.

Are you doing this through the quickpick or by clicking items inside the view?

items in the view

Hm, am I doing something differently than you? https://memes.peet.io/img/20-09-b89036d8-7ce7-4969-a571-cfaf124e0bb5.mp4

Ah, thanks, I actually fixed that in https://github.com/microsoft/vscode-js-profile-visualizer/commit/181d5317ce4443c8521efffd5c93571ed1d5aee9#diff-ed37fc08d14745b61a4bfafdeaec836e -- I thought before it was just causing some extra DOM stuff, but it looks like it also caused this bug.


Add integration tests

Describe the feature
We should have integration tests similar to other packages that allow us to verify that the ref(), source(), and test_unit_test() macro are working as expected.
Describe alternatives you've considered
N/A
Additional context
See https://docs.getdbt.com/docs/guides/building-packages#4-add-integration-tests
Who will this benefit?
It will be easier to ensure changes we make in the future don't break things.
Are you interested in contributing this feature?
Yes, I am going to work on this next.

Added!


What :before and :after association options do?

I having troubles understanding and finding docs on before and after options in has_many associacions. I know only that they defined here: https://github.com/neo4jrb/neo4j/blob/95db4f8c8e25004c09fa635f3cd553db81082a96/lib/neo4j/active_node/has_n/association.rb#L208
I'm new to neo4j and started working with code consisting such lines:
has_many :in, :companies, rel_class: :CompanyCategorization, unique: true, after: :recalculate
  has_many :in, :reviews,  type: :CATEGORIZATION, after: :update_cached_counts
  has_many :in, :skips,  type: :SKIPS, model_class: :User, after: :update_cached_counts

recalculate and update_cached_counts are methods, but they seem not to fire, or I dont understand when they should, so can someone clarify when should they invoke so I can debug further, or point me to documentation?
Additional information which could be helpful if relevant to your issue:
Runtime information:
Neo4j database version: 3.0.4
neo4j gem version: 7.2.3
neo4j-core gem version: 6.1.6

Aside from a check that the keys are valid, I'm having a bit of trouble finding code and tests that are responsible for those callbacks. @cheerfulstoic were those options removed in favor of ActiveRel?

Yeah, I believe that they were

I seem to remember that discussion and decision, but I guess we (I? Probably!) missed the check for valid association options.
So, @sandric, the recommended path is to use ActiveRel in place of those callbacks. Sorry for the confusion.

@subvertallchris ok, no problem, I just wanted to understand what it was used before to understand current logic. As I showed in example, lets say there's line
has_many :in, :companies, rel_class: :CompanyCategorization, unique: true, after: :recalculate
So recalculate method should be called after new node is added to association, or after association query? My current neo4jrb gem version is 7.2.3. @cheerfulstoic can you recall original logic of this option?

The changelog shows they were removed with 8.1.0, so I found their specs from 8.0.18 here. You can also see where they're executed here.
It looks like they will fire immediately before and after the association is created. Each callback method needs to accept one argument, which is the node instance on the other side of the association. You can roll back the entire association creation if your before callback returns an explicit false.
Hope this helps!


Not getting error response when an exception is throw

Route::api(['version' => 'v1', 'prefix' => 'api'], function()
{
    Route::get('error', function()
    {
        try {
            $divide = 100/0;
        } catch(Exception $e) {
            throw new \Symfony\Component\HttpKernel\Exception\HttpException($e->getMessage);
        }
    });
}

I get a 500 response but the body is empty.

looks like the first param is the status code and the message is second http://api.symfony.com/2.7/Symfony/Component/HttpKernel/Exception/HttpException.html

Updated with a 500 then my message; no dice.
I tried to get as generic as I could with these and the HttpException is the generic I could go. I am aiming for UnauthorizedHttpException for use with my JWT auth, but ran into this issue.
Only way I am getting the expected json response is with API::response()->errorUnauthorized('Not Authroized') which isn't so bad but really like the idea of throwing an exception when I need to an the API handling it automatically

maybe try throwing Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException instead.
Other than that not sure on the face of it. Maybe related to #382

Don't think this is the same. TBH, I might not be doing JWT right, learning as I am going. This is what I am after
Route::api(['version' => 'v1', 'prefix' => 'api'], function()
{
    Route::post('login', function()
    {
        $auth = Sentinel::stateless(Input::only(['user', 'password']));

        if (!$auth) throw new \Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException('not sure what a challenge string should be');

        return JWTAuth::fromUser($auth);
    });
}

I post with incorrect user/password and only get an empty 500 response.

Think I have an underlying issue; I started to protect my endpoints with 'protected' => true and getting that same empty 500. I am sending both Accept and Authorization headers.
I am stumped. Is there anyway that this package could be partially configured?

I discovered https://github.com/dingo/api/issues/369 and applied the fix there but didnt help anything with my empy 500 responses.
Any thoughts?

Okay, I knew I had to have misconfigured something....
I was enticed by API::error() and had set it to return Response::json() which I have known to break Dingo API but not before I added that listener.
Problem solved

@jameswagoner Hi James, i'm actually having the same issue, but i'm not sure what you're referring to with API:error().  Could you be more specific?

API::error() is an function that gets called on error much like App::error(). I was using Response::json() to format my error messages which conflicts with Dingo. Dingo will already return json since that is what I specified in my Accept headers.
I am running things differently now TBH. I have changed my API to always return a 200 response with a success or failure value in addition to the data I return.


Disable save to camera roll and just return a data URI

For my project I use Firebase to store my images as Data URI's. It would be great to disable save to camera roll and just return a data URI string.

+1

Hi,
I had the same needs for one of my projects.
I've made this little modification on the cordova plugin that stops saving on camera roll and returns the photo as a base64 jpg url.
BR

@Jimbo13M, does your modification still work with the current version? I also need the base64 version of the photo but after replacing the file, I still get the same output from setOnPictureTakenHandler:
["assets-library://asset/asset.JPG?id=23569151-278F-469B-98B2-583A8BF839E5&ext=JPG", "assets-library://asset/asset.JPG?id=74749DFD-E078-4E35-976A-47C7DEE13920&ext=JPG"] (2)
Also, in your example, this line is used:
b64url.replace('file:///','')
However, the result I get starts with assets-library:// and isn't Base64 encoded. Help would be greatly appreciated!


core.endpoint.s3.s3_rest:: Could not log bucket operation: TypeError: Cannot destructure property

Environment info

NooBaa Version: VERSION
Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

noobaa non containerized d/s rpm noobaa-core-5.17.2-20241217.el9.ppc64le
Actual behavior

Observed in the logs the following errors , when the Warp IO workload along with the HA functionality testing when "ENABLEMD5 : true"
noobaa.log

Dec 18 14:41:21 node-gui0 [4081247]: 2024-12-18 14:41:21.251401 [PID-4081247/TID-4081247] [L1] FS::FSWorker::OnError: Readfile _path=/ibm/fvt_ces_root/ces
/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json  error.Message()=Protocol driver not attached
Dec 18 14:41:21 node-gui0 [4081247]: [nsfs/4081247]  [WARN] core.sdk.config_fs:: get_config_data: with config_file_path /ibm/fvt_ces_root/ces/s3-config/bu
ckets/newbucket-warp-ha-efix-downstream-18dec2024.json got an error [Error: Protocol driver not attached] { code: 'EUNATCH', context: 'Readfile _path=/ibm/fvt
_ces_root/ces/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json ' }
Dec 18 14:41:21 node-gui0 [4081247]: [nsfs/4081247] [ERROR] core.endpoint.s3.s3_rest:: Could not log bucket operation: TypeError: Cannot destructure property 'event_code' of 'undefined' as it is undefined.    at new NoobaaEvent (/usr/local/noobaa-core/src/manage_nsfs/manage_nsfs_events_utils.js:24:23)    at BucketSpaceFS.read_bucket_sdk_info (/usr/local/noobaa-core/src/sdk/bucketspace_fs.js:157:13)    at async NsfsObjectSDK._validate_bucket_namespace (/usr/local/noobaa-core/src/sdk/object_sdk.js:290:24)    at async LRUCache.get_with_cache (/usr/local/noobaa-core/src/util/lru_cache.js:67:28)    at async NsfsObjectSDK.read_bucket_sdk_config_info (/usr/local/noobaa-core/src/sdk/object_sdk.js:180:28)    at async Object.send_bucket_op_logs (/usr/local/noobaa-core/src/endpoint/s3/s3_bucket_logging.js:12:29)    at async Object.s3_rest [as handler] (/usr/local/noobaa-core/src/endpoint/s3/s3_rest.js:73:17)
Dec 18 14:41:21 node-gui0 [4081247]: 2024-12-18 14:41:21.321307 [PID-4081247/TID-4081275] [L0] FS::FSWorker::Execute: WARNING Readfile _path=/ibm/fvt_ces_root/ces/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json  took too long: 1029.2 ms
Dec 18 14:41:21 node-gui0 [4081247]: 2024-12-18 14:41:21.321323 [PID-4081247/TID-4081280] [L0] FS::FSWorker::Execute: WARNING Readfile _path=/ibm/fvt_ces_root/ces/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json  took too long: 1038.99 ms
Dec 18 14:41:21 node-gui0 [4081247]: 2024-12-18 14:41:21.321391 [PID-4081247/TID-4081247] [L1] FS::FSWorker::OnError: Readfile _path=/ibm/fvt_ces_root/ces/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json  error.Message()=Protocol driver not attached
Dec 18 14:41:21 node-gui0 [4081247]: [nsfs/4081247]  [WARN] core.sdk.config_fs:: get_config_data: with config_file_path /ibm/fvt_ces_root/ces/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json got an error [Error: Protocol driver not attached] { code: 'EUNATCH', context: 'Readfile _path=/ibm/fvt_ces_root/ces/s3-config/buckets/newbucket-warp-ha-efix-downstream-18dec2024.json ' }
Dec 18 14:41:21 node-gui0 [4081247]: [nsfs/4081247] [ERROR] core.endpoint.s3.s3_rest:: Could not log bucket operation: TypeError: Cannot destructure property 'event_code' of 'undefined' as it is undefined.    at new NoobaaEvent (/usr/local/noobaa-core/src/manage_nsfs/manage_nsfs_events_utils.js:24:23)    at BucketSpaceFS.read_bucket_sdk_info (/usr/local/noobaa-core/src/sdk/bucketspace_fs.js:157:13)    at async NsfsObjectSDK._validate_bucket_namespace (/usr/local/noobaa-core/src/sdk/object_sdk.js:290:24)    at async LRUCache.get_with_cache (/usr/local/noobaa-core/src/util/lru_cache.js:67:28)    at async NsfsObjectSDK.read_bucket_sdk_config_info (/usr/local/noobaa-core/src/sdk/object_sdk.js:180:28)    at async Object.send_bucket_op_logs (/usr/local/noobaa-core/src/endpoint/s3/s3_bucket_logging.js:12:29)    at async Object.s3_rest [as handler] (/usr/local/noobaa-core/src/endpoint/s3/s3_rest.js:73:17)
...
Dec 18 14:41:21 node-gui0 [4081247]: [nsfs/4081247] [ERROR] core.endpoint.s3.s3_rest:: Could not log bucket operation: TypeError: Cannot destructure property 'event_code' of 'undefined' as it is undefined.    at new NoobaaEvent (/usr/local/noobaa-core/src/manage_nsfs/manage_nsfs_events_utils.js:24:23)    at BucketSpaceFS.read_bucket_sdk_info (/usr/local/noobaa-core/src/sdk/bucketspace_fs.js:157:13)    at async NsfsObjectSDK._validate_bucket_namespace (/usr/local/noobaa-core/src/sdk/object_sdk.js:290:24)    at async LRUCache.get_with_cache (/usr/local/noobaa-core/src/util/lru_cache.js:67:28)    at async NsfsObjectSDK.read_bucket_sdk_config_info (/usr/local/noobaa-core/src/sdk/object_sdk.js:180:28)    at async Object.send_bucket_op_logs (/usr/local/noobaa-core/src/endpoint/s3/s3_bucket_logging.js:12:29)    at async Object.s3_rest [as handler] (/usr/local/noobaa-core/src/endpoint/s3/s3_rest.js:73:17)
Dec 18 14:42:30 node-gui0 node[4115777]: 2024-12-18 14:42:30.238587 [PID-4115777/TID-4115777] [L1] FS::set_log_config: LOG_TO_STDERR_ENABLED=0 LOG_TO_SYSLOG_ENABLED=1

It has occurred for 4 - 5 times, protocol driver UNATACH is acceptable, since during HA time , there is a movement of CES IP and at that time there are chances of trying to access these buckets in the directory might have run into this operation.
Expected behavior

Please investigate on why the bucket operation is logged when the feature is not enabled in the environment today.
Steps to reproduce

Ran Warp run, but it doesn't seem to be related here
More information - Screenshots / Logs / Other output
Box folder with link to the noobaa and mmfs.log

2 times occurred on the 17th Dec noobaa logs , has different message than 18th Dec log (bucket operation message)  --> https://ibm.ent.box.com/folder/299549553376
occurred mostly on 18th Dec https://ibm.ent.box.com/folder/299550817338

@romayalon @shirady as per our telecon discussion on Thus, opening this defect for further analysis

@rkomandu I added a fix for the failure, didn't disable bucket logging because it's under discussion


Notary V1 Integration RFC

Readable

Codecov Report

Merging #500 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   67.61%   67.69%   +0.07%
==========================================
  Files          74       74
  Lines        3418     3414       -4
==========================================
  Hits         2311     2311
+ Misses        836      832       -4
  Partials      271      271

Impacted Files
Coverage Δ

pkg/apis/build/v1alpha1/builder_types.go
0.00% <0.00%> (ø)

pkg/apis/build/v1alpha1/builder_lifecycle.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983c31b...9bf0105. Read the comment docs.

Most likely going to create a POC to spike out the implementation before deciding what to do with this RFC.

The following branch has a rough proof of concept of how kpack might integrate with notary: https://github.com/pivotal/kpack/tree/notary-poc
Some key takeaways:

Users could supply their own secret refs with private keys so that kpack wouldn't need to generate them
The image digest could be accessed by the image-signer by mounting the layers and reading the report.toml. The image size could be calculated by the image-singer or added to the report.toml.

Next Steps:

Investigate authentication with a notary server and how to thread those credentials into kpack.

Users could supply their own secret refs with private keys so that kpack wouldn't need to generate them.
What format would these keys be in?

Users could supply their own secret refs with private keys so that kpack wouldn't need to generate them.

What format would these keys be in?

I believe it's just a reguler PEM format. Users can generate keys with the notary CLI or openssl.

Codecov Report

Merging #500 into master will decrease coverage by 1.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   67.61%   66.45%   -1.16%
==========================================
  Files          74       74
  Lines        3418     2990     -428
==========================================
- Hits         2311     1987     -324
+ Misses        836      719     -117
- Partials      271      284      +13

Impacted Files
Coverage Δ

pkg/logs/wait_for_image.go
65.15% <0.00%> (-7.71%)
:arrow_down:

pkg/dockercreds/docker_creds.go
64.51% <0.00%> (-7.28%)
:arrow_down:

pkg/cnb/platform_env_vars_setup.go
50.00% <0.00%> (-7.15%)
:arrow_down:

pkg/dockercreds/volume_secret_keychain.go
42.85% <0.00%> (-7.15%)
:arrow_down:

pkg/apis/build/v1alpha1/build.go
16.94% <0.00%> (-6.81%)
:arrow_down:

pkg/git/git_keychain.go
73.91% <0.00%> (-6.42%)
:arrow_down:

pkg/registry/imagehelpers/helpers.go
43.58% <0.00%> (-5.88%)
:arrow_down:

pkg/buildpod/generator.go
59.37% <0.00%> (-5.49%)
:arrow_down:

pkg/registry/client.go
55.55% <0.00%> (-5.43%)
:arrow_down:

pkg/dockercreds/parse_pull_secrets.go
56.41% <0.00%> (-4.96%)
:arrow_down:

... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983c31b...f76703e. Read the comment docs.


Multiple NPC select

Im pretty sure this may be supposed to be posted on citizens but im using this for sentinels sooo....
Can I select more than one sentinel at a time and give them the same command?
I found the squad command wich sounds like its the solution to my problem but I didnt find any commands to make it work other than it being listed in the /help menu I tried the command and it did nothing can you tell me how to use it/what does it do or any other command that allows me to give the same command to multiple sentinels at the same time?

Sorry for the spelling errors

Nope :/ That'd be a request for Citizens if it were to be done...


Block copy with the ALT+MOUSE unexpectedly wraps the copied text into a single string

Environment
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 1.1.1671.0

Any other software?

- WSL Ubuntu 20.04 LTS

Steps to reproduce

Use the default WT settings.
Use the "copyOnSelect": true.
Select a rectangular text block.
Paste the selection.

Expected behavior
The block copy should leave a block as is (including the whitespace). There is an existing default setting in the schema ("singleLine": false), but, it seems, it applies for keyboard shortcuts solely.

Actual behavior
The block copy wraps everything to a single string.

You know what, we might accidentally be taking the line wrap state into account when we do block selection, where we absolutely should not.
/cc @carlos-zamora seem right?

I don't think so but I can look into it a bit more.
What are you connected to in WSL Ubuntu? Vim?

What are you connected to in WSL Ubuntu? Vim?

The screenshots are made with Vim, but I have seen a similar issue with multiple apps, including cat, pico, and so on.

[env : Command Prompt]
I have the same issue with Micro

Environment
Windows Build: 19042.662
Windows Terminal Version: 1.4.3243.0
Any other software: [Micro](https://github.com/zyedidia/micro)

Steps to reproduce:

Create a file with e.g; micro name.c
Select a rectangular block
Open another terminal and create/open any other file and paste.

Expected Behaviour

Actual Behaviour

@carlos-zamora, @DHowett
Wrapping is taken into account - which seems to be a change in the logic in #4578:
// always apply \r\n for box selection
if (!lineSelection || !GetRowByOffset(iRow).GetCharRow().WasWrapForced())

was replaced by
const bool forcedWrap = GetRowByOffset(iRow).GetCharRow().WasWrapForced();
...
if (!forcedWrap)
{

Regarding the trailing whitespaces - it looks that we remove them in any case (if shift not pressed). Probably we should add a logic that in block selection we preserve them in any case.
I will try to write some short PoC.

I'm not sure how I feel about block selection preserving spaces that weren't emitted by the application. Right now, we have an issue where we can't differentiate between spaces emitted by an app and spaces that we use to fill the buffer. I would hate to force block selection to have a bunch of annoying spaces in it unless it was strictly necessary.
(I often use it in a context that could be space-sensitive, like grabbing suffixes off lists of filenames and stuff like that to forward along into another command or an editor.)
How do other terminals do it?

I'm not sure how I feel about block selection preserving spaces that weren't emitted by the application. Right now, we have an issue where we can't differentiate between spaces emitted by an app and spaces that we use to fill the buffer. I would hate to force block selection to have a bunch of annoying spaces in it unless it was strictly necessary.
(I often use it in a context that could be space-sensitive, like grabbing suffixes off lists of filenames and stuff like that to forward along into another command or an editor.)
How do other terminals do it?

@DHowett - the alternative today is to remove the spaces that were potentially emitted by the application. Not sure which one is better :blush:
From what I checked:

MinTTY trims
ConEmu does not.


Output forward connections are in CLOSE_WAIT state

Describe the bug
I have fluentd deployed as a deamonset in kubernetes cluster which is sending logs using output forward plugin.  I have shared the config below. In the netstat output of fluentd, I see alot of close_wait connections. How can I resolve this ?
tcp        1      0 fluentd-operator-:<port> <IP_ADDRESS>:<port> CLOSE_WAIT
To Reproduce
This issue is seen when the remote side of the connection has closed the connection.
Expected behavior
Ideally fluentd should handle closing the connection and relive the socket.
Your Environment
- Fluentd version: 1.13.3
- Package version:
- Operating system: VMware Photon OS: V3.0
- Kernel version: 4.18.0-372.36.1.el8_6.x86_64

Your Configuration
<match **>
  @type forward
  keepalive: true
  recoverWait: 20s
  requireAckResponse: false
  send_timeout: 90s
  keepalive_timeout: 30s
  <buffer>
        @type file
        path buffer1.buf
        flush_mode interval
        flush_thread_count 8
        flush_interval 2
        retry_type periodic
        retry_wait 10s
        retry_max_times 1
        chunk_limit_size 16m
        total_limit_size 32m
        overflow_action drop_oldest_chunk
        disable_chunk_backup true
    </buffer>
</match>

Your Error Log
[error]: #9 failed to flush the buffer, and hit limit for retries. dropping all chunks in the buffer queue. retry_times=1 records=8139 error_class=Errno::EPIPE error="Broken pipe - sendfile"
[error]: #9 suppressed same stacktrace
[error]: #7 failed to flush the buffer, and hit limit for retries. dropping all chunks in the buffer queue. retry_times=1 records=2457 error_class=Errno::ETIMEDOUT error="Connection timed out - sendfile"
[error]: #7 suppressed same stacktrace

Additional context
No response

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Hi, Can anyone please help me out with the issue that I am facing ?

Looks like we need more information to investigate this.

Is the server side out_forward plugin?
Could you please share more logs?

Isn't there some detailed stacktraces?
Isn't there server-side logs (out_forward)?
If you can set log-level to debug or trace, it can help us.

The above Out_forward configuration is on the client side. Server side uses in_forward to receive it. When the server sends reset packet to forcefully close the connection, Sockets on client-side(fluentd) are going into CLOSE_WAIT states.
I see below logs along with the logs that I have already shared.
2024-09-09 16:38:08 +0000 [debug]: #7 connect new socket #<struct Fluent::Plugin::ForwardOutput::SocketCache::TimedSocket timeout=2024-09-09 16:43:08.309568639 +0000, key=["<IP_ADDRESS>", <PORT>, "server.com"], sock=#<Fluent::PluginHelper::Socket::WrappedSocket::TCP:fd 91, AF_INET, <IP_ADDRESS>, 46508>>

  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/socket.rb:62:in `initialize'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/socket.rb:62:in `new'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/socket.rb:62:in `socket_create_tcp'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:410:in `create_transfer_socket'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/connection_manager.rb:46:in `call'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/connection_manager.rb:46:in `connect'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:807:in `connect'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:676:in `send_data'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:365:in `block in write'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/load_balancer.rb:46:in `block in select_healthy_node'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/load_balancer.rb:37:in `times'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/load_balancer.rb:37:in `select_healthy_node'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/service_discovery/manager.rb:108:in `select_service'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/service_discovery.rb:82:in `service_discovery_select_service'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:365:in `write'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/output.rb:1179:in `try_flush'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:353:in `try_flush'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/output.rb:1500:in `flush_thread_run'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/output.rb:499:in `block (2 levels) in start'
  2024-09-09 17:09:59 +0000 [warn]: #1 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/thread.rb:78:in `block in thread_create'
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 failed to send heartbeat packet host="<IP_ADDRESS>" port=<PORT> heartbeat_type=:transport error_class=Errno::ECONNREFUSED error="Connection refused - connect(2) for \"<IP_ADDRESS>\" port <PORT>"
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 connect new socket
2024-09-09 17:09:59 +0000 [debug]: #2 taking back chunk for errors. chunk="621b2d3a10bfccc53dc08c7c6d4019ff"
2024-09-09 17:09:59 +0000 [warn]: #2 failed to flush the buffer. retry_times=0 next_retry_time=2024-09-09 17:10:01 +0000 chunk="621b2d3a10bfccc53dc08c7c6d4019ff" error_class=Errno::ECONNREFUSED error="Connection refused - connect(2) for \"<IP_ADDRESS>\" port <PORT>"
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/socket.rb:62:in `initialize'
2024-09-09 17:09:59 +0000 [debug]: #2 taking back chunk for errors. chunk="621b2d3a10c9e08c09e407b1216c81b2"
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/socket.rb:62:in `new'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/socket.rb:62:in `socket_create_tcp'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:410:in `create_transfer_socket'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/connection_manager.rb:46:in `call'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/connection_manager.rb:46:in `connect'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:807:in `connect'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:676:in `send_data'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:365:in `block in write'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/load_balancer.rb:46:in `block in select_healthy_node'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/load_balancer.rb:37:in `times'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward/load_balancer.rb:37:in `select_healthy_node'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/service_discovery/manager.rb:108:in `select_service'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/service_discovery.rb:82:in `service_discovery_select_service'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:365:in `write'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/output.rb:1179:in `try_flush'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/out_forward.rb:353:in `try_flush'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/output.rb:1500:in `flush_thread_run'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin/output.rb:499:in `block (2 levels) in start'
  2024-09-09 17:09:59 +0000 [warn]: #2 /usr/local/lib/ruby/gems/2.7.0/gems/fluentd-1.14.6/lib/fluent/plugin_helper/thread.rb:78:in `block in thread_create'

I am not sure if these logs will help in analyzing better. Please let me know if you are looking for some specific keyword in the logs, I can try to get the output of those logs.

Thanks!
We can know how the client works from these logs.
We need to investigate if this behavior is intended or not.
One more question.

When the server sends reset packet to forcefully close the connection

Why does the server send reset packet?
Could some issues occur on the server side as well?
Could you attach server-side (in_forward) logs?

@daipom, I do not have access to the server-side logs. I was just checking the output plugin documentation, If we make the tcp connection as long-lived/persistent i.e., my setting keepalive: true ,  Then the fluentd doesn't handle closing of the the socket? Is my understanding correct?
https://docs.fluentd.org/plugin-helper-overview/api-plugin-helper-socket
Lines from the documentation: "The socket plugin helper does not manage the lifecycle of the socket. User must close the socket when it is no longer needed."
Could this be the reason why fluentd is not able to clean-up connections in close_wait state.
I even tried by adding  the below parameters to output forward plugin, Even this didn't help
send_keepalive_packet true
keepalive_timeout 300s

If we make the tcp connection as long-lived/persistent i.e., my setting keepalive: true , Then the fluentd doesn't handle closing of the the socket? Is my understanding correct?

No, out_forward plugin handles the socket closing even if using keepalive.

https://docs.fluentd.org/plugin-helper-overview/api-plugin-helper-socket
Lines from the documentation: "The socket plugin helper does not manage the lifecycle of the socket. User must close the socket when it is no longer needed."
Could this be the reason why fluentd is not able to clean-up connections in close_wait state.
I even tried by adding the below parameters to output forward plugin, Even this didn't help

plugin-helper is a feature for developers of Fluentd plugins, not for Fluentd users.
This is about implementing the plugins, not how to use them.
Here are the documents for plugin users.

https://docs.fluentd.org/output/forward
https://docs.fluentd.org/input/forward

@daipom, ok sure, But I don't see CLOSE_WAIT connections getting closed.  Am I missing any configuration that should be added?

The out_forward plugin has its own logic to handle the sockets, so we need to investigate the implementation.
However, the problem is that I can't reproduce this issue.
In my test, out_forward can close the socket and re-send data to in_forward correctly if in_forward revives.
I found out one thing.
On non-Windows, in_forward sends RST rather than FIN when closing, by default.
It appears that it closes the socket forcefully.
So, by default, I can't reproduce CLOSE_WAIT state sockets that remain.
However, when setting linger_timeout to in_forward, it sends FIN when closing.
This generates some CLOSE_WAIT state sockets.
<source>
  @type forward
  <transport tcp>
    linger_timeout 1
  </transport>
</source>

However, in my testing, this was not a problem.
After in_forward revives, out_forward can reopen the socket and send data correctly in my testing.
So, I'm not sure what is causing this issue phenomenon...

At least, the close_wait socket should be closed after keepalive_timeout elapses.
In my testing, they are closed afer keepalive_timeout.
I need some information to reproduce the phenomenon...

If you can, please try a more recent version.

Hi,
Configuring keepalive_timeout helped me manage sockets in the CLOSE_WAIT state. However, I noticed that after setting keepalive_timeout, not only are inactive or CLOSE_WAIT sockets cleared, but all sockets are being closed. For example, with keepalive_timeout set to 300 seconds, all sockets are terminated after 300 seconds.
Expected Behavior: Since keepalive is enabled and keepalive_timeout is set to 300 seconds, the expectation is that the tcp connections stays persistent and just inactive or CLOSE_WAIT connections would be checked and closed at the 300-second mark. If all sockets are closed, it results in the loss of in-transit data, requiring new connections to be established.
Could you please advise on how I can limit the cleanup to only inactive or CLOSE_WAIT sockets?

Maybe, this issue will be solved by https://github.com/fluent/fluentd/pull/3711
So, could you please update your Fluentd version?

However, I suspect there may be a bug in Fluentd's handling of CLOSE_WAIT connections. When the server closes the connection (e.g., by calling socket.close), Fluentd receives a FIN packet but does not respond with its own FIN packet to gracefully close the connection. As a result, the socket remains in a CLOSE_WAIT state on the Fluentd side.

Is this reproducible with Fluentd 1.16.6?
(Does CLOSE_WAIT socket remain after the in_forward stop?)

@daipom, Yes. It is reproducible with Fluentd 1.16.6

Is there any update on this issue or Can anyone help be resolve this issue?
@daipom, were you able to reproduce the issue?

@karthiknagraj
Sorry for my late response. I will try reproducing this again.


Unable to edit profile on Tusky for Android

Hey, I've noticed two issues trying to edit my bio on Tusky for Android:

The fields I've filled in on the web don't populate in the app (notably the bio field and my custom metadata
When I try to edit any fields or upload either a profile picture or a cover photo, I get a generic "the upload failed" toast

Steps to replicate:

Get an Android device (I'm on a pixel 6 pro running Android 13)
Download and install Tusky: https://play.google.com/store/apps/details?id=com.keylesspalace.tusky
Log in as a user on takahe.social
Open the left sliding menu and tap on "Edit profile"
Try to edit any of the fields (display name, bio, custom fields, profile picture, etc)
Tap the check icon in the action bar
Observe the above failure

Yup, I can see this locally as well. We'll get a fix in shortly!


Update for v2 nat hist

Added 95 new dataset-extraction entries from the archive mapping of the v2 nat-hist experiment.  Updates the dataset_spec for both native and CMIP6 case generation.  Added the standard match patterns for "streams.ocean" and "streams.seaice" for future archive mapping support.
This update also sets YPF to 5 for ocean 3D variables, and updates to latest e3sm_to_cmip version in conda-envs.

Done.


New Extension: TinyPNG

Description

Add a new extensions TinyPNG.
This extension compresses the image selected in the Finder by TinyPNG.
Screencast

https://user-images.githubusercontent.com/11070996/185783961-a6e161c6-d373-4d8f-886e-f561540fe8c4.mp4
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer
Thank you for your review.
I fixed. https://github.com/raycast/extensions/pull/2640/commits/be6fe700fd6c6dc18cf054062258a9cb5dd35fc2
I decided to use Toast to display Erro because I thought that with HUD I might not notice the Error.
Error in credential

Error in file don't selected

Errors in unsupported files

@pernielsentikaer
Thank you for your commit.
Was it okay with this change?
If you have any other change requests, feel free to make them.


Create redis section

What
Created and expanded Redis backing service content:

Set up a Redis service
Bind a Redis service to your app
Unbind a Redis service from your app
Delete a Redis service
Redis maintenance & backups
Further information

Part of https://www.pivotaltracker.com/story/show/154638143
How to review
Describe the steps required to test the changes.

Preview the content locally (see README) and check that it renders as expected.
Manually check that any removed or renamed anchor tags are not in use (linkchecker doesn't do this).
Check that content fulfills requirements of story https://www.pivotaltracker.com/story/show/154638143

Who can review
Anyone except Jon Glassman or Andrew Bruce

eviction policy bits and tweaks LGTM  👍
We still need to remove mentions of "public beta" ... and add the first line/disclaimer about being in "private beta" and how to request access.


Merge master into development branch to sync up with the code

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage remained the same at 60.2% when pulling 8af3e76be0ca81b3140c2211c61f9e6f5b94d026 on master into 7e58cf05a00301893c228a3ca83c7db97a275580 on development.


reloadData does NOT work

Is there a way I can use collectionView reloadData on this collection view? Every time I try to reload the data I get an error like this : 'UICollectionView received layout attributes for a cell with an index path that does not exist:
I am trying to include a search feature to filter collection results but it keeps breaking.
Any ideas on this?

+1

I found a way to get this to work! Took me some time to figure it out, had to keep searching through different comments but if anyone Is interested.
I created a method named 'reload' which is set like this
- (void)reload {     [self.collectionView reloadData];     self.itemAttributes = nil;     [self prepareLayout]; }
So anytime I need to reload the data, I call this function instead of just the collectionView reloadData.
PS: Keep in mind that the itemSize array might also need to be reset but I am using this collection view across several scripts and I am setting up the itemSize based on the controller using it

but how about adding more? it seems this class is not design with all these in mind....

@adamhongmy Are you talking about adding cells? Well your data would come from an array and you can add/remove from that array during run time and then call the reload function above to reload the collection view with the new dataset

@juliusbtesh that is one way to do it but reload the whole layout will cause lag if there are many data (like 200). Don't you think so?

@adamhongmy Very possible. I never really use insert or remove cells... I usually just do reload data but you make a good point


Add a movie pop-up is too dark (i.e. very hard to see text in a box)

it is fixed in new changes of dev branch


fix typo

do we need some kind of migration for that?

Thank you!

do we need some kind of migration for that?

Yes. This change breaks the configuration in the people who are using the setting.
(The setting will be disabled after upgrade.)
So, I want to keep the typo to avoid extra migration in upgrade.

is there no easy way to migrate, and replace the typo on people's config?

Unfortunately, there is not a easy way to migrate the configuration.


Allow any types, without ILiquidizable?

I am trying to pass something like the following object to a view:
var data = new {
   Model = GetMyData(),
   BaseUrl = "/something/";
};

public IEnumerable<Models.MyData> GetMyData();

The trouble is, due to the requirement to have ILiquidizable on all types, I get the error: Liquid syntax error: Object 'Models.MyData' is invalid because it is neither a built-in type nor implements ILiquidizable.
I understand this is by design, but it would be really nice to have the ability to override this restriction if I know that I am passing it a safe-to-use model. This is really annoying since I am specifically using DTOs already, and essentially the only way to get this to work is to implement ILiquidizable and return a new anonymous type that mirrors my actual model.
I tried using  object DotLiquid.ILiquidizable.ToLiquid() { return this; } but that also does not work -- it just silently fails, as if the variables I'm referencing don't exist.
I can picture a couple of ways to do this:
// as a global setting
DotLiquid.Template.AllowAllTypes = true;

// as a wrapper:
Hash.FromSafeType(model);

// as an override
template.Render(DotLiquid.Hash.FromAnonymousObject(model, allowAllTypes:true));
// or
template.Render(DotLiquid.Hash.FromAnonymousObject(model), allowAllTypes:true);

The actual implementation is pretty easy once the method is chosen -- it's a matter of modifying Context.Liquidize().
I will submit a patch if needed, but want feedback and alternatives before I do.
(aside, the page linked in the docs of ILiquidizable -- http://wiki.github.com/tobi/liquid/using-liquid-without-rails -- is gone. It appears to be https://github.com/Shopify/liquid/wiki/Using-Liquid-without-Rails/cadb5d13cb171d36b4aa9239af1b8b70bc699ad1 but I can only find this referenced by search, the current version of that page is also missing?)

Actually, there is already a fork that does this: https://github.com/RevCBH/dotliquid

See https://github.com/formosatek/dotliquid/pull/51


New Extractor ? uptostream

Hello,
is it possible for uptostream ?
exemple :
https://uptostream.com/am9u61zg6ewf
Many thx

I think that should be possible. Examining the source page, the link for the video can be found. For instance, the video URL in your case is "https://www98.uptostream.com/4altmn7a537/360/0/video.mp4". Examining the source page of the URL, I jumped onto this line "var sources = [{"src":"https://www98.uptostream.com/4altmn7a537/360/0/video.mp4","type":"video/mp4","label":"360p","res":"360","lang":"unknown 0","idLang":"0"}];". It contains the download link. Maybe the mods can implement the functionality.

This looks like copyrighted content. youtube-dl does not support sites dedicated to copyright infringement. Do they have rights to distribute this? If not provide an example URL that does not violate any copyrights.


Switch complex_layout back to LazyBlock

We need to study these benchmark numbers more carefully. See #7937

@Hixie


NPE in StaticTypeAnalyze when for-in is unresolved

I was typing something like, an maybe _addedRoots was incomplete and unresolved.
    for (var previousRoot in _addedRoots)

Analyzer Feedback from IntelliJ
Version information

IDEA 182.SNAPSHOT
2.0.0-edge.9672d69a0691ef66a4b554537e26c8c0f95fcbe6
IC-182.SNAPSHOT, JRE 1.8.0_112-b16x64 Oracle Corporation, OS Mac OS X(x86_64) v10.13.4 unknown, screens 1680x1050  Retina

Exception
Please append the contents of:
file:///private/var/folders/cp/32g44l548q8d0bfj4_l9s3m003ky/T/report.txt
Dart analysis server, SDK version 2.0.0-edge.9672d69a0691ef66a4b554537e26c8c0f95fcbe6, server version 1.20.3, error: Analysis failed: /Users/scheglov/dart/pub/lib/src/dart.dart context: exception_20180606_115820_116
NoSuchMethodError: The method 'resolveToBound' was called on null.
Receiver: null
Tried calling: resolveToBound(Instance of 'InterfaceTypeImpl')
#0      Object.noSuchMethod (dart:core-patch/dart:core/object_patch.dart:46)
#1      StaticTypeAnalyzer._findIteratedType (package:analyzer/src/generated/static_type_analyzer.dart:1668:17)
#2      StaticTypeAnalyzer._inferForEachLoopVariableType (package:analyzer/src/generated/static_type_analyzer.dart:1924:33)
#3      StaticTypeAnalyzer.visitDeclaredIdentifier (package:analyzer/src/generated/static_type_analyzer.dart:496:7)
#4      DeclaredIdentifierImpl.accept (package:analyzer/src/dart/ast/ast.dart:3385:49)
#5      ResolverVisitor.visitNode (package:analyzer/src/generated/resolver.dart:6341:10)
#6      UnifyingAstVisitor.visitDeclaredIdentifier (package:analyzer/dart/ast/visitor.dart:2971:57)
#7      ScopedVisitor.visitDeclaredIdentifier (package:analyzer/src/generated/resolver.dart:7527:34)
#8      DeclaredIdentifierImpl.accept (package:analyzer/src/dart/ast/ast.dart:3385:49)
#9      ResolverVisitor.visitForEachStatementInScope (package:analyzer/src/generated/resolver.dart:5996:19)
#10     ScopedVisitor.visitForEachStatement (package:analyzer/src/generated/resolver.dart:7584:7)

https://dart-review.googlesource.com/c/sdk/+/72960


longer prompt

my command is：
CUDA_VISIBLE_DEVICES="0,1,2,3,4,5,6,7,8,9"  python generate.py --base_model=/data/model/h2ogpt-4096-llama2-70b-chat/ --prompt_type=llama2 --use_gpu_id=False --share=True --save_dir=foo
But when I increase prompt length, it appears:
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 2.88 GiB (GPU 0; 21.99 GiB total capacity; 16.69 GiB already allocated; 1.70 GiB free; 19.62 GiB reserved in total by PyTorch) If reserved memory is >>

I don't want the precision of the model to be int-8 or int-4.Is there any way to solve it for longer prompt？Thanks！
Even though I use this command，it still does not support longer prompt：
python generate.py --base_model=meta-llama/Llama-2-70b-chat-hf --prompt_type=llama2 --rope_scaling="{'type': 'linear', 'factor': 4}" --use_gpu_id=False --save_dir=savemeta70b

I don't want the precision of the model to be int-8 or int-4.Is there any way to solve it for longer prompt？Thanks！

Yes, linear factor 4 will use about 4x as much memory, so probably not possible for 70B with each board of 23GB.
@arnocandel thoughts?

Like #692.
If we can do distributed generation with > 8 GPUs, maybe it can solve.


Carousel "_do_touch_up" does not do coordinate transformations

Software Versions

Kivy: 2.1.0

Describe the bug
In the Carousel "_do_touch_up", there is no coordinate transformation from window space to local space for the  touch event.
Expected behavior
Should be the same as _do_touch_up in ScrollView.

I found a similar problem with DragBehavior.
Other classes with "_do_touch_up" methods may have the same problem.

As a temporary solution when event is received in _do_touch_up it should be transformed using Window.transform_motion_event_2d method.
# in _on_touch_up method
me.push()
Window.transform_motion_event_2d(me, self)
# do logic
me.pop()

References to this problem:

https://github.com/kivy/kivy/blob/2.2.0/kivy/core/window/__init__.py#L1684
https://github.com/kivy/kivy/pull/7648


Travis failing?

Observed behaviour
Travis failing flake8 on master, https://travis-ci.org/googlefonts/fontbakery/jobs/459767778

Expected behaviour
Travis passes :)

yep. It seems that the linter got upgraded with a new check while we were performing a new release. (the actual PRs that we merged all passed Travis builds) I'll take care of addressing that. Thanks for the reminder.

These are the things we need to fix:

They're not all new linter-checks. I am not sure how that happened.


distributionManagement/repository contains invalid XML tags.

We should remove "releases" and "snapshots" in "distributionManagement" as follows since they are not valid to Maven POM:
<distributionManagement>     <!-- Copy this section from the Maven section of the "Connect to Feed" dialog -->       <repository>          <id>dev.azure.com-mseng-zcalvinmaven</id>          <url>https://pkgs.dev.azure.com/mseng/_packaging/zCalvinMaven2/maven/v1</url>       </repository>    </distributionManagement>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0448074b-9d76-435b-e3f2-df77c7367099
Version Independent ID: 0d46b076-90ee-8112-1e07-5be2f592ea87
Content: Publish Maven artifacts to your feed using the Maven client
Content Source: docs/artifacts/maven/publish.md
Product: devops
Technology: devops-artifacts
GitHub Login: @chasewilson
Microsoft Alias: phwilson

The issue mentioned is not on this page, but on the connect to feed dialog. This should be a bug on the product not on documentation

Thanks,I will close it.


[index.md] screeb documentation

Proposed changes
Copy and formatted the documentation provided by Screeb, for their new integration.
src/connections/destinations/catalog/screeb/index.md
Merge timing
ASAP
Related issues (optional)
N/A

Hi @tcgilbert. Do you know the status of this integration in Partner Portal? I don't see it available in PAPI yet for the catalog.

Hi Mark,  just set this to "Private Beta."  Let me know if it needs to be Public Beta to show up in PAPI

Hi @markzegarelli, just set this to "Private Beta." Let me know if it needs to be Public Beta to show up in PAPI

Hi @tcgilbert, yes PUBLIC_BETA is the minimum status that is exposed to PAPI.

Hi @markzegarelli just updated to "Public Beta." Apologies, still getting a hang of the order of operations for these integrations, thanks!

It's all good @tcgilbert, I just updated the catalog and am merging now.


chore(chart): update helm chart for option to disable persistence

This PR is a partial restructure of the Grafeas helm chart and includes the following:

Additional comments and references
Moving of fields under persistence field
Option to disable persistence which will not create and PVs or PVCs other that config

For restricted environments, it's not inherently easy for the creation of PV and PVCs. The option to disable PVs and PVCs is a common one for many helm charts.
Open to thoughts and suggestions.

@googlebot I signed it!

Thanks for your contribution! LGTM. Let's wait a couple days before merging this PR to give others a chance to comment.


Caching paginated results

Hi Jeffrey,
First of all, thank you very much for this package. I am a big fan of laracasts :)
I was trying to use the russian doll caching in a view with pagination, so to make it work I have to have this in my controller...
$collection = Collection::make($results->items);

... and then pass it to the view. This way I can cache the results, but I am speding twice the memory. By the way, to allow @cache directive to cache collections I needed to run:
composer require laracasts/matryoshka:dev-master

Do you come up any idea how can I solve this?
Thanks in advance,

i have tested that yet, but as the @cache basicly look for the cache tags in the cache driver, maybe u can use https://laravel.com/docs/5.2/cache#storing-tagged-cache-items and just call that in the directive ? and it should work as it used in the v4.2 pagination,

i havent used the pagination yet so cant tell exactly will the code from the v4.2 will work or will there be a different way.

am in the same boat so i came up with a little solution
@inject('Model','App\Post')

@foreach ($posts as $post)
    @cache("Posts/$post->id-".$Model->cacheDate($post->updated_at))
        ...
    @endcache
@endforeach

cacheDate is basically turning the value into timestamp, and we had to inject the model as the pagination returns an array so calling the method directly on $post wont work.
public function cacheDate($value)
    {
        return Carbon::parse($value)->timestamp;
    }

Hi @ctf0,
Thank you for your reply. This solution may work, but, instead of caching all the page (as I wanted), you are caching those items one by one.
I finally ended up using redis to cache the collection and passing it to the view. It was a lot faster than using this package.
Cheers,

the problem with caching the whole page is when a fragment of that page is updated, u will have to regenerate the whole thing which what this package is the exact opposite of.


Add: Go2Travel TV

Channel Name
Go2Travel TV
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
Go2Travel TV Communications
Country
TR
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
c/TR
Languages
eng
Categories (optional)
travel
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://go2travel.tv/live/#/?playlistId=0&videoId=0
Logo
https://go2travelling.net/wp-content/uploads/2022/04/Logo-za-sajt.png
Notes
No response

Already in the database: https://iptv-org.github.io/channels/us/Go2Travel


ci

Replaces GH actions integration tests with those in CirleCI.
Updates hardhat in the codebase to support test file execution.

Can we report the results of integration tests back to Github?

We already do
On Fri, Apr 29, 2022 at 18:44, Boyuan-Chen @.***> wrote:

@Boyuan-Chen approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Status checks need to be deleted from GH settings and we're fine!

@InoMurko Merge yes, right? Who will delete the status checks need to be deleted from GH settings?

@InoMurko Merge yes, right? Who will delete the status checks from GH settings?

all done, waiting to be merged!


External movement

Description of the PR
... (e.g. what value does it bring? Why should it be merged?)
Review checklist
(based on the work of Karl E. Wiegers)
Structure

[ ] Does the code completely and correctly implement the design?
[ ] Is the code well-structured, consistent in style, and consistently formatted?
[ ] Are there any uncalled or unneeded procedures or any unreachable code?
[ ] Are there any leftover stubs or test routines in the code?
[ ] Can any code be replaced by calls to external reusable components or library functions?
[ ] Are there any blocks of repeated code that could be condensed into a single procedure?
[ ] Are symbolics used rather than “magic number” constants or string constants?
[ ] Are any modules excessively complex and should be restructured or split into multiple routines?

Documentation

[ ] Is the code clearly and adequately documented with an easy-to-maintain commenting style?
[ ] Are all comments consistent with the code?

Variables

[ ] Are all variables properly defined with meaningful, consistent, and clear names?
[ ] Are there any redundant or unused variables?

Arithmetic Operations

[ ] Does the code avoid comparing floating-point numbers for equality?
[ ] Are divisors tested for zero or noise?

Loops and Branches

[ ] Are all loops, branches, and logic constructs complete and correct?
[ ] Are all loops, branches, and logic constructs properly nested and avoid unnecessary nesting?
[ ] Can any statements that are enclosed within loops be placed outside the loops?

Defensive Programming

[ ] Are imported data and input arguments tested for validity and completeness?
[ ] Are files checked for existence before attempting to access them?

@Wang1872 Have you tested it with The ONE and CORE/coreemu-lab? Is it working as expected?

@Wang1872 Have you tested it with The ONE and CORE/coreemu-lab? Is it working as expected?


Cannot create account. coupon_not_exist on v1.1.0

Hi,
I'm testing the latest addon release and I get an error on order activation page "Order Accept Encountered Problems
Cannot create account. coupon_not_exist"

and there is no option to edit the cupon

Also an Invoice on time4vps website is generated, but the order cannot be accepted on the admin dashboard in whmcs.
our dev site runs on: WHMCS 8.7.3 / PHP 8.1 / Time4Vps addon v1.1.0 (same error on WHMCS 8.7.1 / PHP 7.4 )
Please help.

Hi, any help with this ?


Use filename as id instead of have it inside migration script

Would be good to have filename as step id instead of an id written by developer

@marcusberro what do you think to have both file name and developer id in migration persisted object?
What do you think @eberhara?

@wmartins @eberhara I've experienced some mistakes using Mongration with more than one migration scripts. For example, when you have similar scripts that you copy and rename the file, developers can forget to change the id. I guess that would be great to constraint the id just on filename and I'm not sure if it is a good idea to keep both option.

Closing since we agreed that assuming a step id by its file name is not a good practice.


Fix broken links in spanish free programming books

What does this PR do?
This Pull Request addresses the broken free programming books ( books//free-programming-books-es.md) from issue #6942. The issue references some books that had a network timeout. However, as of today, opening those links work fine.
For resources
Description
N/A
Why is this valuable (or not)?
N/A
How do we know it's really free?
N/A
For book lists, is it a book? For course lists, is it a course? etc.
N/A
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

@davorpa No hay de qué, espero poder contribuir más al repositorio :raised_hands:


WebSocket data can be a primitive, causing exception

Hello,
After upgrading from version 3.6.0 to 4.3.0, I started receiving the following error:
TypeError: Invalid value used as weak map key
    at WeakMap.set (<anonymous>)
    at ContextClsStoreMap.set (node_modules/nestjs-cls/dist/src/lib/cls-initializers/utils/context-cls-store-map.js:26:25)
    at ClsGuard.canActivate (node_modules/nestjs-cls/dist/src/lib/cls-initializers/cls.guard.js:34:56)
    at GuardsConsumer.tryActivate (node_modules/@nestjs/core/guards/guards-consumer.js:15:34)
....

I'm using "ClsGuard" in a WebSsocket context, and in this case, my WebSocket data is a string and not an object.
The ContextClsStoreMap.getContextByType function, with context.switchToWs().getData(), is leading to this error.
For now, I'm reverting to 3.6.0. And if I get more time, I'll check if I can fix it and do a pull request.

Thanks for the bug report and also pin-pointing the exact issue!
The context map is there mainly as an escape hatch for some non-trivial GraphQL use-cases (see #88).
In the case of websockets, I think it's safe to use the entire WsArgumentsHost as the context map key, so context.switchToWs() should be enough for a fix (seeing as there is no other object that can be used instead of Data).
If you want, create a PR with that change, otherwise I'll get to it when I get some free time.

Fixed in<EMAIL_ADDRESS>


Update the Operator to support deploying the collector agent to Openshift 4.11

Add proper support to use SecurityContextConstraints

The test failures above should be fixed once we cut a new release for the operator. I'll cut a release today. Merging this code for now.


[5.3] Make mach_absolute_time implementation consistent with libdispatch

Copied from #2907. The diff is exactly same. Considered safe and worth to port to 5.3.

CC @spevans @compnerd

@swift-ci please test


The cloud proxy has suddenly started using host user to connect

I have never had any problems with this before, but now it is struggeling to connect to my database because it doesnt find the role 'X'.
X is the username of my mac.
I tried making a role for this user just to get past it, but it requires a password as well, and I have no idea where it is fetching that from.
But the question is, why has it started doing this?
I need to be able to connect to the SQL for doing analasis, migrations and other things. But now im locked out of it :O
This is my command, obfuscated a bit:
`./cloud_sql_proxy_mac -instances="dev-instance:europe-west1:dev-postgres-instance"=tcp:5432 --credential_file="./dev-instance-f697f46f3a88.json"

The proxy doesn't interact with the database user at all - can you provide more details on the error you are seeing and full list of steps needed to reproduce?

Including what client you are using to connect to the database through the proxy.

@kurtisvg @Carrotman42 yes of course. Im running now the newest mac client from this repo release. But it first happened with a version that was quite much older, 1.5 year maybe.
Im using this to just initiate a connection, so I can do migrations, or connect with my pg admin 4
This is how I run it. And there you can see it is retrying like crazy. If I let it stand for a minute it retries many many times.

This is what the log provides me.

You can see the user "snorre" there. This is nothing I have provided to google, or im providing to the config. But for some reason it picks this up. This username is only been used on my personal mac, nowhere else. So I have no idea why it is picking this up. The reason it says that the password is wrong, is because I created a role with this name in the DB to see if I got further. But dont know what password to put. Tried the local password, that did not work.
Does this help, or is it anything else I can provide?

So this error is unrelated for the proxy - the proxy only wraps the incoming connection and forwards it to the database.
If the connection isn't coming from you, something on your system is attempting to connect to <IP_ADDRESS>:5432 repeatedly, using your machines username. Since 5432 is the default port for Postgres, you can probably avoid seeing the error by switching to a different port (like 5433). However it's probably worth investigating what's trying to make the connection in the first place, on the off chance it's a malicious actor.
I'm going to mark this as closed since it's unrelated the proxy - but feel free to keep commenting if there is something specific we can help with.

Ok, thanks for info. The reason this started happening now is because I updated https://github.com/postgres/pgadmin4 server to a newer version. And I guess this new version did something different than the later version where this did not happen. So that was what confusing. Shutting down the server, makes the proxy work fine again.
So just need to see why this happened now, so I can get my workflow back.