What is the point of wrapping model class inside of @model decorator?

It looks like Model is copied before registering without any changes. It prevents inheritance from registered models. But what is the reason for this class wrapping? Why not get rid of it and allow inheritance from registered models?

There are reasons to do it (e.g., letting the system know which is the modelId of the model and also to execute onInit and lock down property writing without actions only once the last class of the inheritance chain has finished constructing). This last one is basically to work around a "bug" in babel, where it will write undefined to abstract properties on the submodel constructors.
That being said, I found an alternative way to allow ExtendedModel to work over models already wrapped with @model, which I guess was what you wanted to achieve in the end and will get releated as 0.30.0, so feel free to close  the issue if that PR solves it :)

PR: https://github.com/xaviergonz/mobx-keystone/pull/79

Thank you for the answer! Yes, I think the new version will solve the problem. But let me ask please...
Sorry if I misunderstand something, but I believe onInit can be converted to action right on the base class without a wrapper. And property locking can be done in model constructor for example. It will have just a tiny additional cost of checking if model is locked already, but I can find other ways to solve it. I think that this wrapping makes things more complex. For example, it would be possible to register models not only by decorators, but in some other place of code also. I'm planning to use Model classes for each page type of application. It would be nice to avoid using @model decorator in each file and move this registration to some central place with router setup.
Or it could be possible to move model name right into class (as static property) and register the model lazily same way as property locking. This way we could avoid usage of decorators at all.

The problem is for example with this test:
test("issue #18", () => {
  abstract class A extends Model({}) {
    public abstract value: number = void 0 as any // similiar to what babel does when using an abstract prop without default value
  }

  @model("B#18")
  class B extends ExtendedModel(abstractModelClass(A), { value: prop<number>() }) {}

  const b = new B({ value: 1 })
  expect(b.value).toBe(1)
})

Right now the following happens when new B is done:

BaseModel constructor runs, modelReady is not set (therefore property setting will be ignored)
A constructor runs, it sets value to void 0 (something the babel property plugin does for abstract classes for some reason), but is ignored because model is not ready
B constructor runs
wrapping code (the one from modelDecorator) is run, setting the model to ready, allowing property setting to actually work

if property locking (modelReady) is set on the constructor of the base class the following would happen:

BaseModel constructor runs, modelReady is set
A constructor runs, tries to set the abstract property to void 0, throws because a property is being set without an action

As for onInit wrapping, imagine this:
class X extends Model(...) {
  onInit = () => {...} // using an arrow function to set onInit
}

Right now this happens:

BaseModel constructor runs
X constructor runs, sets onInit
wrapping constructor runs onInit

If onInit was run on BaseModel this would happen:

BaseModel constructor runs, there's no onInit found yet, does not get called
X constructor runs, sets onInit

This one could maybe be fixed by doing a defineProperty over onInit and executing it as soon as it is set, but that's kind of weird.
That being said, maybe I overlooked something, so if you see a way to fix those two cases and get the unit tests working then by all means let me know (or even better, please open a PR :) )
As for not using model as a decorator, you can do this right now:
class _X extends Model(...) {}
const X = model("modelName")(_X)

I can easily add an override that could work like
const X = model("modelName", _X)

although you still have to use X and not _X in the end (due to what was explained before).
Would that solve anything?

Ah, another solution would be to use a function to create models instead of new, but that'd be a breaking change. Something like:
registerModel(X, "name")
const x = createModel(X, {...})

models need to be registered (cannot be lazily registered) because they need to be found when using fromSnapshot btw. Right now the decorator does it for you.

I think even the decorator thing is much better than createModel.
if you want, you can always (https://github.com/xaviergonz/mobx-keystone/pull/79 made it possible) use it just like that:
const MyModel = model('myModel')(class extends Model({
 // model props
}) {
  // model methods
});

But it still pretty ugly :)

Thank you very much Javier.
I agree that createModel is ugly. But it can be moved to the BaseModel as static method:
registerModel(X, "name")
const x = X.create({...})

Now it looks prettier and uses same API as MST.)
For backward compatibility the @model could be just a thin layer to this two functions. Like this:
const model = (name) => (cls) => {
  registerModel(cls, name); // or cls.name = name; registerModel(cls)
  const newClass = function(...arg) {
     return cls.create(...arg);
  }
  // newClass[...] = ...
  return newClass;
}

"Lazy" registration is possible with some registerModelDeep which will walk a tree and register all models.
Actually, I'm not sure if it's very helpful because I haven't tried Keystone in practice yet.) But this project seems awesome to me. I'm planning migration from MST. Thank you for mobx-keystone!


fix: deprecated async_forward_entry_setup

Fixes #1171

Hi, will this MR also be merged soon?

Hi, will this MR also be merged soon?

My bad, forgot this, thanks again


Using MMS model with star token for batch size > 1

The current implementation assumes batch size is one, when attaching the star dimension:
https://github.com/pytorch/audio/blob/ea437b31ce316ea3d66fe73768c0dcb94edb79ad/src/torchaudio/pipelines/_wav2vec2/utils.py#L41
However, the underlying Wav2vec model supports batch size greater than one. So this line should instead be:
star_dim = torch.zeros((output.size(0), output.size(1), 1), dtype=output.dtype, device=output.device)

Also hit this problem, any workarounds?


Device list does not refresh properly

Configured a fresh MQTT broker, deployed, and selected a device from the device list. There is only one device paired, an Ikea Dimmer switch.
Node was the Ikea dimmer node (v1).
Then I purposely misconfigured the MQTT broker to a false IP address / IP address where no broker is installed and Deployed.
After the deployment, the connection is gone, but the device list still shows devices. Meaning it has to be cached somewhere.

Screencast

Ok, discussed it with @Dirnei - does make sense because if the bridge is not connected or down, the devices would be cleared.

Ok, discussed it with @Dirnei - does make sense because if the bridge is not connected or down, the devices would be cleared.


[Feature Request] How to set rowheight, not tableHeight! Default is 40px, Im

Existing Component
是
Component Name
table
Description
How to set rowheight,not tableHeight!  default is 40px,Im try to 30px.

Use size or override style directly.


Dependabot flags vulnerability in requirements.txt files in old releases

Package manager/ecosystem
Python3 with pip-tools
What you expected to see, versus what you actually saw
Dependabot recently flagged a vulnerable version of urllib3 against https://github.com/tern-tools/tern. However, it detected the vulnerable package in one of our frozen manifests which we keep for every release as a build reproducibility best practice.
We've since bumped up the version on urllib3 but Dependabot still alerts us because it's looking at a frozen manifest.
We would expect Dependabot look at the top level requirements.txt for this project.
This might be something Dependabot will not be able to solve, in which case, we would like an "other" reason for dismissing the alert (I had to choose "already working on a fix" which isn't the case here).
Thanks!

@nishakm yeah I think falls outside of what we can fix for now. Dependabot alerts is powered by the dependency graph which finds supported manifests in your entire repo and there's no way to ignore certain files yet but will pass along this feedback.
An "other" reason seems reasonable too.

Closing, as explained above there's nothing we can do.
You can now add a custom reason for dismissal: https://docs.github.com/en/code-security/dependabot/dependabot-alerts/viewing-and-updating-dependabot-alerts#dismissing-dependabot-alerts


Populating foreign keys in a seed

While in the early stages of development, I'm using fake data to populate my tables. To create this data quickly, I'm using the faker module to load some dummy data. I'm currently working on a Property seed file that belongs to a Landlord and a Neighborhood. The latter 2 tables have been populated.
What I'm currently doing is retrieving all available neighborhood ids, then retrieving all available landlord ids, then creating n property records using a random neighborhood id and a random landlord id. I have something functional, but it's not pretty. I'm no craftsman with promises, but I'd like to get there and I can't shake the feeling that there must be a better way than this:
knex.select('id').from('neighborhoods')
    .then(function(neighborhoodIds) {
        _.pluck(neighborhoodIds, 'id');

        knex.select('id').from('landlords')
            .then(function(landlordIds) {
                landlordIds = _.pluck(landlordIds, 'id');

                var maxRecords = 250;
                for (var i = 0; i < maxRecords; i++) {
                    var iNeighborhood = _.random(neighborhoodIds.length - 1);
                    var iLandlord = _.random(landlordIds.length - 1);

                    promises.push(
                        createNewRecord(knex, {
                            neighborhood_id: neighborhoodIds[iNeighborhood],
                            landlord_id: landlordIds[iLandlord]
                        })
                    );
                }
            })
        ;
    })
;

Would really appreciate input from folks with more experience working with Knex & promises. What can I do to clean this up?
Thanks.

Did this pretty quickly and it's late but it should work:
var records = 250;

Promise.resolve([
  'neighborhoods',
  'landlords'
])
.map(function (table) {
  return knex.select('id').from(resource).pluck('id')
})
.spread(function (neighborhoods, landlords) {
  return new Array(records).map(function () {
    return {
      neighborhood_id: random(neighborhoods),
      landlord_id: random(landlords)
    };
  });
})
.then(function (properties) {
  return knex.into('properties').insert(properties);
});

function random (array) {
  return array[_.random(array.length - 1)];
}

Wow. This was incredibly helpful. Thanks for taking the time.
One note for anyone that may search this later, the new Array(records).map(...) line doesn't work as-is because the array is filled with empty elements. As a workaround, I used _.range(records).map(...). This initializes the array with actual values. A nuance in the context of the larger solution, of course, but it may save someone a few minutes down the road.
Thanks again.

No problem! The idea of new Array(records).map(fn) is for fn to run records times. So the intent is to have empty elements and then just map them to randomly generated records. Just a functional equivalent to:
var data = [];
for (var i = 0; i < records; i++) {
  data.push(randomRecord());
}


KV cache INT4/INT8

📚 The doc issue
Why is the improvement in inference efficiency after quantization of internlm2-chat-7b smaller compared to llama2？
link：https://lmdeploy.readthedocs.io/en/latest/quantization/kv_quant.html#performance
Suggest a potential alternative/fix
No response

The samller llama2 models do not use GQA.

The samller llama2 models do not use GQA.

thank you


fix(inventory.coffee): fix error in restockable in days

Summary
Fix update error in RestockableInDays
Description
No update is shown when new RestockableInDays value is passed.
Todo

Tests

[x] Unit
[x] Integration

closes #276

Coverage decreased (-63.9%) to 33.713% when pulling 96c2c10c948606289aa20092b3427ac80c835c75 on 276-fix-error-in-restockableInDays into c4ac950282665881541874574d80bf6630f9cf48 on master.

Coverage decreased (-63.9%) to 33.713% when pulling 96c2c10c948606289aa20092b3427ac80c835c75 on 276-fix-error-in-restockableInDays into c4ac950282665881541874574d80bf6630f9cf48 on master.


Pclouds 2683 app service linux write bash script to determine linux distribution

Wrote a bash script that detects which standard C library (musl/glibc) is used in the Azure Linux App Service container and then sets the DT_FLAVOR value accordingly.
It works in the following way:

Parse ldd --version output -> ldd is a utility that prints the shared libraries and it should contain information about libc
If we didn't get the answer from ldd we check the /etc/os-release file and check if it's an alpine based distro as the musl library is usually present in those.
If we still don't know we check if  etc/alpine-release is present for the same reason as before.

Fixed in https://github.com/dynatrace-oss/cloud-snippets/commit/844b8f0baba5513f65c592509befd1b75076304f

Can you rename the script to oneagent_installer.sh and put it in azure/linux-app-service/oneagent_installer.sh? So if we will add more scripts to this repo it will be better categorized


'No active account found with the given credentials' throws 422 instead of 401

It's a bit a strange and I don't think it's an issue with the simplejwt package. But maybe you can give me a hint where I could search for the solution.
Among other packages I use
Django==2.1
djangorestframework==3.9
djangorestframework-jsonapi==2.7.0
djangorestframework-simplejwt==3.2.3

ex 1
The code below returns
[{'detail': ErrorDetail(string='No active account found with the given credentials', code='invalid'), 'source': {'pointer': '/data/attributes/non-field-errors'}, 'status': '422'}]

for invalid credentials. I'd expect a 401 instead of a 422 status.
urls.py

...
urlpatterns = [
    path(
        'token-auth/',
        TokenObtainPairView.as_view(),
        name='token_obtain_pair',
    ),
   ...
]

ex 2
The next code example returns
[{'detail': ErrorDetail(string='No active account found with the given credentials', code='no_active_account'), 'source': {'pointer': '/data'}, 'status': '401'}]

This seems to be the right answer for invalid credentials.
To reach this I had to modify the code slightly:
urls.py

...
urlpatterns = [
    path(
        'token-auth/',
        CustomTokenObtainPairView.as_view(),
        name='token_obtain_pair',
    ),
   ...
]

views.py

class CustomTokenObtainPairView(TokenObtainPairView):
    serializer_class = serializers.CustomTokenObtainPairSerializer

serializers.py

class CustomTokenObtainSerializer(TokenObtainSerializer):
    def validate(self, attrs):
        authenticate_kwargs = {
            self.username_field: attrs[self.username_field],
            'password': attrs['password'],
        }
        try:
            authenticate_kwargs['request'] = self.context['request']
        except KeyError:
            pass

        self.user = authenticate(**authenticate_kwargs)
        print(self.user) # --> None

        if self.user is None or not self.user.is_active:
            self.error_messages['no_active_account'] = _(
                'No active account found with the given credentials') # --> *
            raise exceptions.AuthenticationFailed(
                self.error_messages['no_active_account'],
                'no_active_account',
            )

class CustomTokenObtainPairSerializer(CustomTokenObtainSerializer):
    pass

Without the line marked with * I got the error
  File ".../serializers.py", line ..., in validate
    self.error_messages['no_active_account'],
KeyError: 'no_active_account'

EDIT
Compare the code field values in the examples above as well.

Ok... Updating simplejwt to version 4.3.0 did it!

So what was the problem again? Getting same error and I'm using djangorestframework-simplejwt-4.8.0

@cgitosh did you try downgrading and seeing if it's still a problem?

September 10th, 2021 -- I have the same problem.

I updated my requirements to
djangorestframework-simplejwt==4.8.0
PyJWT==2.1.0

For invalid credentials I get a 401 'no_active_account'. IMHO that's alright.

Don't hash your password @VladMikheenko . Send the password in plain text for the API.
@ro70 Your opinion's correct; we're just not sure why a 422 is thrown.

See (since v4.2.0) https://github.com/jazzband/djangorestframework-simplejwt/commit/2b5e2e2541bd640bc67c80c4aae1b56cd6857b56#diff-5192d507094cc6c3c4bbdc4280b4b25cd5d0db411335e208ad953d3511ecb59d


When trying the example with a model, I get a template generated which do not accept a model arg in the ctor ?

Well, that works for me. Please post a repro.


Forge Mod Loader Crashes after attempting to load the available 1.14.4 Dynamic Surroundings Mods, AppleSkin causes this too.

Mod Version:
Sound Control 1.14.4-<IP_ADDRESS>,
Mob Effects 1.14.4-<IP_ADDRESS>,
Environs 1.14.4-<IP_ADDRESS>
Forge Version:
28.2.0
Link to client log:
https://hastebin.com/lidejuvawi.css
Link to crash log:
https://hastebin.com/uqumazusis.properties
Description:
Description of the problem.  In the case of crashes, it is good to know things like the following:
After the Forge Mod Loader is finished, it crashes.

Did you just add the mod to a pack?
--No

Did it just start crashing, or has it always crashed?
--Just started.

Did you update any other mods in your pack and it started crashing?  This includes Forge.
--No, no mods were updated.  This did happen around the time the launcher updated to include dungeons able to be launched from the same launcher as MC Java, but I disabled the beta and now it's back to the way it was before...still crashes.

If updating multiple mods did you update one by one or all at once?  To help narrow the problem down adding one by one is helpful.
--N/A

Is the modpack you are using available online somewhere?  If the crash is due to mod interaction having the pack available makes things much easier.  It is much harder to work these types of issues with a private kitchen sink pack containing 250 mods.
--Not using a modpack.  I'm using an assortment of mods I hand chose., but in case you don't find it in the crash log, here are the mods I'm using.
[][][]Hwyla-forge-1.10.6-B67_1.14.4
[][][]MouseTweaks-2.13-mc1.14.4
[][][]OptiFine_1.14.4_HD_U_F5
[][][]VoxelMap-Mod-1.14.4
[][][]SoundControl-1.14.4-<IP_ADDRESS>
[][][]Environs-1.14.4-<IP_ADDRESS>
[][][]MobEffects-1.14.4-<IP_ADDRESS>
[][][]AppleSkin-mc1.14.4-forge-1.0.14 (this mod also triggers the error)

Errr.... looks like the problem is in the TOML parser that forge is using.  Do you happen to have a client log?

Errr.... looks like the problem is in the TOML parser that forge is using. Do you happen to have a client log?

Did I not paste the right log under client?  Sorry, I genuinely don't know.  If that's not the information you need, could you tell me where I can find the info you need?

It would be in the logs folder where the Minecraft instance is installed.

https://hastebin.com/bupeqopilo.sql

Nothing stands out to me other than you are using an older Forge version (28.2.0).  Try updating to the latest 28.2.23.  If that doesn't work make a backup copy of the config folder, delete the contents, and restart your client.

Nothing stands out to me other than you are using an older Forge version (28.2.0). Try updating to the latest 28.2.23. If that doesn't work make a backup copy of the config folder, delete the contents, and restart your client.

I can't even get MC to work with the latest forge beta...


Request:line number

how can I display line numbers in code block

I would love this feature.  I found this markdown flavor added a tag (css class?) to the code block type, which was very non-intrusive, but very helpful.  The only down side is that I only get to see those line numbers in my VSCode instance and not on GitHub.
```javascript {.line-numbers}

Would love to have this as a feature, great for presentations

I played around with some CSS and tried to find a solution that doesn't involved JavaScript.
We can  use the counter feature of CSS to count the line numbers (for a specific class) and use content to print them.
This is my trial using remark.js.
line-numbers is the css class that gets added to the <code> element
Markdown:
``` line-numbers
var x = 0;
var y = x++;

function add(num){
  return num + 1;
}

function double(num){
  return num * 2;
}

function square(num){
  return num * num;
}

// some extra lines
// just to check how
// it
// looks
`` `

CSS:
.line-numbers{
  /* Set "line-numbers-counter" to 0 */
  counter-reset: line-numbers-counter;
}

.line-numbers .remark-code-line::before {
  /* Increment "line-numbers-counter" by 1 */
    counter-increment: line-numbers-counter;
    content: counter(line-numbers-counter);
    text-align: right;
    width: 55px;
    border-right: 1px solid #aaa;
    display: inline-block;
    margin-right: 10px;
    padding: 0 5px;
}

produces:

Hi! I think this is a great feature to have. I've made a styles.css file and paste in that CSS code above and put it in the .vscode workspace directory. However, when i do line-numbers or css {.line-numbers} the line numbers don't show up in the vscode markdown preview. Do you have any suggestions for what I may be doing wrong? Thanks! :)


ValueError: axes don't match array

File "./predict.py", line 95, in
modelRecoverCombine = model.model.build_combine_model()
File "/home/zhila/Project/Research_Journal/JSTASR-DesnowNet-ECCV-2020/model/model.py", line 192, in build_combine_model
modelSnow.load_weights('./modelParam/snowmodel.h5',by_name=False)
File "/home/zhila/.local/lib/python3.6/site-packages/keras/engine/saving.py", line 492, in load_wrapper
return load_function(*args, **kwargs)
File "/home/zhila/.local/lib/python3.6/site-packages/keras/engine/network.py", line 1230, in load_weights
f, self.layers, reshape=reshape)
File "/home/zhila/.local/lib/python3.6/site-packages/keras/engine/saving.py", line 1224, in load_weights_from_hdf5_group
reshape=reshape)
File "/home/zhila/.local/lib/python3.6/site-packages/keras/engine/saving.py", line 861, in preprocess_weights_for_loading
weights = convert_nested_model(weights)
File "/home/zhila/.local/lib/python3.6/site-packages/keras/engine/saving.py", line 836, in convert_nested_model
original_backend=original_backend))
File "/home/zhila/.local/lib/python3.6/site-packages/keras/engine/saving.py", line 980, in preprocess_weights_for_loading
weights[0] = np.transpose(weights[0], (3, 2, 0, 1))
File "<array_function internals>", line 6, in transpose
File "/home/zhila/.local/lib/python3.6/site-packages/numpy/core/fromnumeric.py", line 653, in transpose
return _wrapfunc(a, 'transpose', axes)
File "/home/zhila/.local/lib/python3.6/site-packages/numpy/core/fromnumeric.py", line 58, in _wrapfunc
return bound(*args, **kwds)
ValueError: axes don't match array

Can you please help me?

Are you running the following command?
python ./predict.py -dataroot ./testImg -predictpath ./p -batch_size 3
If so, do you modify predict.py ?
I can't reproduce your issue so I would need more detail.

Hi,
Yes I used the same command line to run the program.
I did not change anything in predict.py. I do not know why I have this
error.
I followed your instructions step by step to run. The only issue here I did
not use TensorFlow 1.6, I am using 1.14. But I do not think this is the
problem.
On Mon, Sep 28, 2020 at 3:29 AM cctakaet<EMAIL_ADDRESS>wrote:

Are you running the following command?
python ./predict.py -dataroot ./testImg -predictpath ./p -batch_size 3
If so, do you modify predict.py ?
I can't reproduce your issue so I would need more detail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weitingchen83/JSTASR-DesnowNet-ECCV-2020/issues/1#issuecomment-699923014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKCQ2IK3QBJWVFY2W7XLF5TSIBQRPANCNFSM4RP4FUBA
.

--
Yours sincerely,
Zhila
UBC University, Okanagan Campus
Faculty of Applied Science
EME4242 - 1137 Alumni Ave
Kelowna, BC Canada V1V 1V7
Ph.D. Student
*Tel. *|+15149926299
Alternative Emails<EMAIL_ADDRESS>zhila.bahrami@ http://canscantech.comcanscantech.com

It seems to be an issue of keras/tf.
https://github.com/keras-team/keras/issues/13279
Could you try TensorFlow 1.12.0 ? We actually use this verion for training and testing.
If you want to use docker, we already have docker image on docker hub.
You can get it by docker pull cctakaet/jstasr:latest .

I think you are right the problem is with libraries and packages.
I tried TensorFlow 1.12 to run the code. I could not install TensorFlow
1.12.0 as my Cuda is not matched with that version. My Cuda is 10.1.
I will focus on using the docker container to see if I can run the model
successfully or not.
I am so grateful for your help.
On Mon, Sep 28, 2020 at 11:19 AM cctakaet<EMAIL_ADDRESS>wrote:

It seems to be an issue of keras/tf.
keras-team/keras#13279 https://github.com/keras-team/keras/issues/13279
Could you try TensorFlow 1.12.0 ? We actually use this verion for training
and testing.
If you want to use docker, we already have docker image on docker hub.
You can get it by docker pull cctakaet/jstasr:latest .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weitingchen83/JSTASR-DesnowNet-ECCV-2020/issues/1#issuecomment-700201629,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKCQ2IJZFOHFCPBSPA2PJCTSIDHU5ANCNFSM4RP4FUBA
.

--
Yours sincerely,
Zhila
UBC University, Okanagan Campus
Faculty of Applied Science
EME4242 - 1137 Alumni Ave
Kelowna, BC Canada V1V 1V7
Ph.D. Student
*Tel. *|+15149926299
Alternative Emails<EMAIL_ADDRESS>zhila.bahrami@ http://canscantech.comcanscantech.com


Add retrofit docs

Fixes #88
This MR also:

Removes null returning on error (replaced by exception throwing)
Makes DecodingError extend Exception for much easier debugging
Since Class implements Type retrieving name is not required

Please remember to assign yourself the issue or comment in it if you are going to take it

Pending on https://github.com/47deg/helios/pull/98

@jereksel You should be able to uncomment the example now the issue has been fixed

Superseded by https://github.com/47deg/helios/pull/105


feat: split Junit module between base utils and the integration test runtime

What this PR changes/adds
Splits the Junit module between base utils and the integration test runtime to avoid circular dependencies between SPI and implementation modules.
Linked Issue(s)
Related to #4028

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.19%. Comparing base (7f20ba5) to head (274b2fe).
Report is 163 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
+ Coverage   71.74%   74.19%   +2.45%
==========================================
  Files         919      986      +67
  Lines       18457    19993    +1536
  Branches     1037     1117      +80
==========================================
+ Hits        13242    14834    +1592
+ Misses       4756     4680      -76
- Partials      459      479      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[RFC]Add imports sort feature

I will try to add sort feature for this plugin, now it is just WIP.
try to implement #207

rebased!

I have fixed the extra empty line,when there is no other imports.

Fix issue now, after sortting ,it looks like :

Looks good to me except that it doesn't seem do any sort of divide by JAR.  I'm not sure if that's possible, but it would be nice to keep them separate.

Looks good to me except that it doesn't seem do any sort of divide by JAR

I am not sure if it is really needed,
as you can see before sort by g:JavaComplete_ImportOrder,I have used this func,call sort(importsList),so I think most import from same jar will be together.

You can add the following documentation to README.md if you want (inside the Optional section):
let g:JavaComplete_ImportOrder = '['java', 'javax', 'com', 'org', 'net']' - Specifies the order of import groups. An import group is a list of individual import statements that all start with the same top-level package name surrounded by blank lines above and below the group.
For example, setting: let g:JavaComplete_ImportOrder = '['com', 'org'] and then calling <Plug>(JavaComplete-Imports-*) (where *=Add, AddMissing, or RemoveUnused) would yield:
import org.baz.ClassC;
import com.foo.ClassA;
import net.qux.ClassD;
import com.bar.ClassB;

import com.foo.ClassB;
import com.bar.ClassB;

import org.bar.ClassA;

import net.baz.ClassC;

Hopefully the above information is accurate. Also I wanted to add a detail about subpackages but I was not sure if the current implementation can handle them. What I mean is, is the following supported:
let g:JavaComplete_ImportOrder = '['com.A', 'com.B'] ?

@brcolow
first,thanks for add something in readme.
and I think it is easy to implement sort by subpackages.but for user,I think g:JavaComplete_ImportOrder should be just a list of simple string ,not a list of regular expressions.
let me make some change.

hi @brcolow now by default it is ['java.', 'javax.', 'com.', 'org.', 'net.'],if you want to order bu subpackage name,you can set like this ['java.util.', 'java.sql.', 'com.', 'org.', 'net.']

@wsdjeg Perfect! Great work.

Ok, thanks. I will create separate branch with this modifications. And will investigate more for jar aware sorting.

Please add new commits to import-sorting branch.

can you reopen this PR?and I will push to other branch,just wait this PR be merged.thanks

Yeah, ok.

maybe we can move all g:var init to autoload/javacomplete.vim,just make sure all of this g:var init after vimenter or after JCStart

For me plugin/javacomplete.vim looks more like configuration file. And autoload/javacomplete.vim already has too much stuff. You think there is a chance for g:var not init?

plugin/javacomplete.vim will be sourced when the path be added to rtp,enen if it is not java or jsp file.for neobundoe or vundle the rtp changed when call end().if user put let g:var = 'test' after end()
so let g:var =get(......),will get nothing from g:.

and I will take a look at other plugin,to find out how they init g:var


Landmass shrinkage

I've noticed that the amount of landmass always seems to considerably shrink over time.
At about 4Gy it's easily less than half what it was at the outset, and I reckon quite a bit more than that. I always end up with something like the attached
I'm sure I read in a response elsewhere that continental crust amount was meant to be preserved?

This doesn't appear to be an issue. The first setup of the planet is give it enough mass on the surface to work with. If the planet started out completely flat and bare it would take too long to get continential shields to form. If you really look at it your example shows a planet similar to Earth in terms of land coverage and ocean coverage. There appears to be a large continent submerged under water but this is still a continent and it's pretty cool you got that result. The North American continent was like this for millions of years.

We try to conserve continental crust as much as possible, but IIRC there are still leaks. Each plate is a grid with a slightly different orientation so the cells in the grid don't always line up against each other. Processes like erosion are stored using a single global raster since we need to transfer mass across plate boundaries, but that means we have to somehow distribute the mass amongst plates, and if one cell maps to several you might see gradual mass loss.
@redferret might be right, though, since it looks like that planet from the picture is really super eroded.
There's a way to test this. When the model starts up we store a variable that tracks how much mass we ought to expect per cell for the rest of the simulation. If you open up devtools while running the model you can see it by typing:
sim.focus().lithosphere.average_conserved_per_cell
Then you can compare it to the equivalent amount for the current point in time:
Crust.get_average_conserved_per_cell(sim.focus().lithosphere.total_crust)
If those number don't match then you have some sort of conservation error.
Anybody willing to give it a shot? I've been super intense with the C++ port lately and don't want to get side tracked.

I'd be happy to give it a shot. It really does feel to me that after a good while I have less continent. But, it could just be a trick of the mind!

well i'm 2 years late to the party but you're absolutely correct and it is no trick of the mind

you can see the result of 2.6 billion years of simulation here
however, my starting heightmap is this image:

you can see just how much land was lost between those 2 images
and finally, i put those 2 lines into devtools and got this

i didnt really want to create a duplicate issue but at the same time i'm not really sure if this project is abandoned or not, i just hope somebody will fix this someday because it's a total dealbreaker

I think that if hotspots and oceanic plate rifting were added, we would see an increase in land and not a decrease. Thanks to oceanic plate rifting and hotspots we have on our Earth, the surface land-to-water ratio is changing, earth once had no continents and was just a water world.

This doesn't appear to be an issue. The first setup of the planet is give it enough mass on the surface to work with. If the planet started out completely flat and bare it would take too long to get continential shields to form. If you really look at it your example shows a planet similar to Earth in terms of land coverage and ocean coverage. There appears to be a large continent submerged under water but this is still a continent and it's pretty cool you got that result. The North American continent was like this for millions of years.

Well I do have to say though , if we had the features that i said in the previous comment, we'd be able to form continents from a bare, ocean world quickly, and that would realistically and easily mimic how it went for Earth.


Bot is stuck when kicked by admin

When the bot is forcefully kicked from a voice channel by an admin, it's stuck playing the audio into the abyss. To fix this, the bot has to handle forced disconnection event and disconnect the lavalink player

@orehzzz, please fix this in your spare time

Blocked by #10

I'm taking this one for myself

Can't reproduce, probably fixed by updates. If not, will reopen the issue


Improved modern fortran compliance

This fixes issue #146, please merge this after #145.
Note: The import statement imports the iso_c_binding elements from the module, so use iso_c_binding is not necessary inside the functions.

@scemama @stefabat looks like the merge of PR #145 breaks the compilation of master and this branch.
The error is Error: Parameter ‘c_int32_t’ at (1) has not been declared or is a variable, which does not reduce to a constant expression.
Why was the change of return type of trexio_info important in the first place? We never had issues with it and the Fortran module was tested on 20 archs from Debian build farm and it worked just fine...

Nevermind, my bad...

@q-posev Is it all good now?

@scemama no, looks like something broke when I merge master with PR #145 into this branch (there was a git conflict which I had to solve). Now the compilations fails at trexio_open_c

Found it!


Correct two typos in snakemake.md

Just some minor corrections of typing errors. Thanks for the great work!

Thanks for the approval @joergfunger ! I am wondering, if there is anything I can do for the build job that is expected to run but does not yet.

I'm supposed to be able to approve the action, but not sure where this could be done (this is supposed to be here according to the documentation here, though there is no option available. I'll look into that, if you have an direct idea, let me know.

I guess the workflow is not run, because this contribution is made in a public fork due to the repository settings as described in your linked page. The solution should be described in this part of the official docs, as far as I can see. But to be honest, I have not dealt with GitHub actions and these settings myself yet.


Error: Back up found [ status : 17 ]

I get this error while login using truecallerjs:
{"status":17,"message":"Back up found","userId":9104xxxxxx53472,"requestId":"12422xxxxxxxxxxxf0d0","backupTime":1636871584101}
And I get this while I login using official TrueCaller app:

Anyway to do this programmatically?

Similar to #11


CFG Resolution Weighting of ControlNet

Excellent work!
Could I ask more details? Do you use CFG Resolution Weighting of ControlNet in this work? And if so, could you tell where the code  is?
Thank you very much!!!

We did not use CFG Resolution Weighting, and it seems like ControlNet was also not used (I didn't see any relevant code, please point it out if I'm mistaken)

Thank you for your patient explanation!
I also didn't see any relevant codes in ControlNet repo.


Will you update to 1.21

Not to rush or anything, but is there a plan to update this mod to 1.21 and if so, do you have an ETA?
It's not meant to rush you but more so for me to know if I should keep an eye out on this mod.

What have you been up to? Why haven't you heard anything?
If you don't hear anything in 3 days, I'll fork your package and upgrade the mod myself.
@DuncanRuns

you can use https://modrinth.com/mod/debugify if you are desperate for this fix

https://modrinth.com/mod/title-fix-mod/version/LR1jneCC


How can i do this ? Buffering related question

I want it to buffer like youtube, Only little buffering ahead of your viewing position and if viewer pauses the video buffering should stop as well. I want to do this to save bandwidth. Can this be done ? If yes, how to do it.
What have you tried so far?

If your source is an HLS media, then you may be able to tune using configuration parameters.
(Clappr player is internally using hls.js)
HLS.JS playback configuration can be set using the hlsjsConfig option :
var player = new Clappr.Player({
  source: "https://your.video/playlist.m3u8",
  playback: {
    hlsjsConfig: {
      // hls.js specific options
    }
  },
  // [...]
});

Yes, i am using HLS. As far as i understand  with HLS it loads only some chunks, not whole video
But do you know how can i make it stop loading loading wheen video is paused.

I am not an hls.js expert, in an old issue i have read it will try to load next fragments until buffer >= config.maxBufferSize. It also suggest calling stopLoad() instance method.
Maybe listent to pause event attempt to call stopLoad() on hlsjs instance ?


[W5.7][T13-4]Amber Joseph

Added a module class to Person Object. Nothing works but it is there.

It looks like the Travis build failed because you did not change the arguments elsewhere where Person constructor is used - for example, in AddCommand or AddressBookDecoder. I suggest you try building the project in Intellij and correcting bugs until it builds.


Emoji placeholder support in string template?

Is it possible to support emoji placeholders like
{
    "emoji":"@emoji()"
}

You can try a custom method or use a fork of the project:

Mock.Random.extend
@lavyun's work better-mock
random-emoji

Mock.mock(`@emoji`)

@wll8 Thanks for your prompt reply. I will try it out. By the way, is MockJS still being maintained?

@lmxx1234567
It seems not. The last update was almost 2 years ago.
But it is a useful tool, so if you encounter a problem, someone will provide a solution.
Many people have created a lot of good tools based on it, such as yapi foxapi. I am also creating my own mockm, which is based on better-mock.


Example of wrapping ReactFlow doesn't work as intended(nodes can't be dragged)

Path: /docs/wrapping-react/example
Created nodes can't be dragged, despite specifying so

Hey @Alek99
Looks like onNodeChange is not implemented , Idea is to add a event handler onNodeChange and change the position of the dragged node to the new position. Can I take this up ?

Is there a way to wrap litegraph.js?

@xiong-zhitong I guess you can use Wrapping

@xiong-zhitong I guess you can use Wrapping , to make a custom wrapper of your own and then use it to wrap litegraph.js

Thanks for your reply!  It seems like the LGraph class is very complex. Don't know how to wrap the functions like "add", "start" ...
<html>
<head>
	<link rel="stylesheet" type="text/css" href="litegraph.css">
	<script type="text/javascript" src="litegraph.js"></script>
</head>
<body style='width:100%; height:100%'>
<canvas id='mycanvas' width='1024' height='720' style='border: 1px solid'></canvas>
<script>
var graph = new LGraph();

var canvas = new LGraphCanvas("#mycanvas", graph);

var node_const = LiteGraph.createNode("basic/const");
node_const.pos = [200,200];
graph.add(node_const);
node_const.setValue(4.5);

var node_watch = LiteGraph.createNode("basic/watch");
node_watch.pos = [700,200];
graph.add(node_watch);

node_const.connect(0, node_watch, 0 );

graph.start()
</script>
</body>
</html>

Can I try to attempt to create a wrapper and then wrap litegraph to reflex? I have tried to get assigned to 4262 issue but in case its already finished may I try to attempt this?


Using search index for Ukrainian content

I've noticed that search was broken.
Error code suggested that different index needs to be used.
Before:

Response from Algolia:
{"message":"Index not allowed with this API key","status":403}

After:

@vburlai wow! good catch!!!
thank you 🙏


Set up pre-commit to handle linting (also in cicd)

I have a quick suggestion I would like to make which would be set up pre-commit to handle the linting. pre-commit is easy to run locally (it can be installed with a git hook to run on every commit), ties in easily with github actions and with the same configuration locally and on cicd it easier to ensure that code stays clean.
If this sounds good I am happy to add the configuration and set up the cicd part too :smile: I am primarily asking @b8raoult because I just noticed you did a commit for handling some linting fixes for black.

Hi @leifdenby, thanks for the suggestion.
we had a pretty hefty pre-commit flying around that I worked on.
Happy if you want to add useful parts and if you have suggestions for the CI/CD, as I haven't set that up yet.

Great, I'll make a pull-request


[EPIC] Events Manager to use Groups Building Block for User Events Authorization

Description
As a developer, I need to use Groups Building Block to handle authorization for User Events in Events Manager. Following features will be needed to meet the goals of this Epic:

A user should be granted access to Events Manager User Events space only if they are a member of the Rokwire Group Access AD group urn:mace:uiuc.edu:urbana:authman:app-rokwire-service-policy-rokwire groups access (this AD group membership is verified by the Events Building Block when creating an Event) and is an admin member in at least one of Rokwire Groups (obtained from the Groups Building Block).
After the user successfully logs in, Events Manager needs to get a list of all Rokwire Groups in which the user is an admin and then provide Read/Write access to all user events created by those Groups. A user can view only those events they can manage because of being an admin member in one or more Rokwire Groups. All other events will not be accessible/viewable by the user.
When creating a new event, the user needs to select one of the Groups it will belong to. The Group's ID  will need to be stored in the createdByGroupId field in the Event Schema. The Events Manager will later use this information to provide access to all admin users of this Group.
A user can change the Rokwire Group the event belongs to using the edit option.

Acceptance Criteria
Events Manager uses Groups Building Block for authorizing access to User Events.

1, 2 & 3 are done here.

This is complete. Thanks.


Dynamic graphics pipeline state

Add the ability to set certain graphics pipeline state in a render pass without having to bind a new pipeline. This might seem antithetical to the design of Fwog, but sometimes it is useful to be able to cheaply change some minimal state between draws without having to bind an entire pipeline.
In drivers for modern desktop hardware, some state is practically free to change. The goal is to identify those states and add the common ones to Fwog.
Secondary goal: make a benchmark to test if dynamic state has the intended performance impact of zero.

Do we have a list of possible things, identifying as not intrusive, already?
something like viewport and scissor?

After doing some research, it is apparent that there is no dynamic state which is truly free on all hardware. However, scissor and viewport state is important enough and cheap enough on common hardware that they are included.
The main thing that needs to be watched for, at least on AMD hardware, is frequent changing of these pieces of state. This state is held in context registers and can cause a stall if the user is reckless. This seems to not be a problem on NV hardware.
There may be additional state which falls into a similar category as these. Until those are identified, I will be closing this issue.


Set vault context

Hi
I've tried to set the vault context using  Get-AzureRmRecoveryServicesVault -Name "RecoveryVault" |Set-AzureRmRecoveryServicesVaultContext, and albeit the command looks OK, any subsequent commands to list the Backup Policy all fails stating that I need to set a default context first...
Jan

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e50dfe50-c177-f976-753b-9fa689d20f92
Version Independent ID: 7f787259-8ce5-9ba6-8df7-58ab0b89dd5c
Content: Deploy and manage backups for Resource Manager-deployed VMs using PowerShell
Content Source: articles/backup/backup-azure-vms-automation.md
Service: backup
GitHub Login: @markgalioto
Microsoft Alias: markgal;trinadhk;pullabhk

@digitus0 Thank you for the valuable feedback,we are investigating the issue.

@digitus0 just to clarify, after setting the context using the command you've mentioned, and then listing the vaults using Get-AzureRmRecoveryServicesVault still asks you to set the context ?

@digitus0
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

I am also facing the same issue.

@achal1012 , Thank you for your feedback. Try looking at the information in this GitHub Issue: https://github.com/Azure/azure-powershell/issues/5759, and see if you're able to fix your problem. If you aren't, you should open a new GitHub Issue, as this issue is closed and not as easy to track.

@markgalioto I was able to resolve this by getting the latest version of SDK on a test machine, but it is going to be a problem upgrading it in PROD VM as it uses some legacy Azure commands.

Hi,
Any update on this issue? We are facing issue in Azure Automation Accounts. and pointers would be helpful.


code: 1004, message: No purchases to restore, detail: null

Hey!
I see this error on android in crashlytics when trying to get paywall.
adapty_flutter: ^2.2.4
Non-fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: (code: 1004, message: No purchases to restore, detail: null). Error thrown null.
       at Adapty._invokeMethodHandlingErrors(adapty.dart:266)
       at Adapty.getPaywall(adapty.dart:97)
       at OnboardingChatPageCubit._init(onboarding_chat_page_cubit.dart:161)

hi @otopba
Though it's technically an error, it actually isn't, it just means that the user has no purchases in the history. Do you send it manually from the callback of restorePurchases()?

@vladd-g
Hi!
In my code, the restorePurchases and getPaywall calls are not logically related. But in some situations they can be called one after the other
And I do not really understand why the getPaywall method returns an error related to restorePurchases

@vladd-g Great news. Thank you!

Hey, @otopba! We have fixed this in the latest release!


Handle OSC for setting 256-color values

#24 added support for parsing and displaying them, now the OSC commands for setting the colors should be handled as well.

Without this, vim looks really silly with 256-bit color themes that I use with other terminals (like base16):

This is really easy to add, I'll work on it this evening.

ping @jwilm: this is basically the only thing keeping me from using alacritty in my day-to-day

@jonhoo I've actually started on this, it's a bit more work than I anticipated. Will probably have something by the weekend.

@jwilm thanks! much appreciated!

This should be good to go. Please let me know if you run into any problems!

@jwilm hmm, how would I go about setting these in the alacritty config? It's not immediately obvious to me from looking at the diff.

Oh, there's no way to do this from config. You might want to add it to your startup script. Something like
printf "\x1b]4;%d;rgb:%2.2x/%2.2x/%2.2x\x1b\\" 10 255 255 255

10 is the index, and the next 3 values are R, G, and B.

How did this work in your previous terminal?

With URxvt, this works using *.color16, *.color17, etc. in .Xresources. I'm fine setting it using escape codes, though that feels strange given how colors can already be set using colors.normal and colors.bright in .config/alacritty.yml.

ahh, sure. That sounds like it would make sense to add. Very low on my priority list, though.

For what it's worth, the fix in 2be3e8fc5b72698391423c5b10cf490211a8828a completely fixes my use-case, because I also source color files in my shell, which set all the colors appropriately. This would only matter for cases when the terminal directly executes some non-shell command, but that's pretty rare (at least for me).

@jonhoo can you elaborate a little on how did you manage to fix the issue after all? I'm seeing pretty much the same issues with colors in vim right now – same as on your screenshot.
Did you have to run something from the terminal to fix the colors?


Updating the logic for stale endpoint management

Description
Background:
This issue surfaces when we run the K8s for hyperv containers test https://github.com/kubernetes/kubernetes/blob/6381e6504ac210297e382c22029791267d440d9e/test/e2e/windows/service.go#L51 to reproduce you will need to set up testing cluster using capz windows-testing/capz/readme.md at master · kubernetes-sigs/windows-testing (github.com) and run this specific test. Else you could also look at test-grid logs for details on test failure: sig-windows-experimental Test Grid (kubernetes.io)
In the test Calico is unable to recognize a container endpoint is in ready state as it doesn't attach an endpoint as the logic is based on HNSEndpoint sharedContainers which are an empty field for hyperv containers. https://github.com/microsoft/hcsshim/blob/8beabacfc2d21767a07c20f8dd5f9f3932dbf305/internal/hns/hnsendpoint.go#L146
Calico logic to define a stale container needs to be updated. I do so by using the HNS Endpoint state attribute.
PR for hcshim: https://github.com/microsoft/hcsshim/pull/2177
The change has been backported to hcsshim 0.11 and 0.12 and we here ingest the latest tag to ingest dependent changes.
This change was tested by running kubernetes e2e tests locally for both hyperv containers and process isolated containers. All tests pass.

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Fix that Felix would not recognise HyperV containers as ready.

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/sem-approve

CI failed with a code formatting check, please can you run make fix in the felix dir?

/sem-approve

/sem-approve

/sem-approve

/sem-approve

/sem-approve


isqrt is slow

It is faster for scipy to compute lambertw than for this to compute isqrt.
You should bind to C and do it there. Supporting python's big int looks like the main difficulty of porting the code.

I recommend anyone looking for performance to prefer gmpy2.isqrt

I recommend anyone looking for performance to prefer gmpy2.isqrt

@wjmelements There's also math.isqrt, since Python 3.8.

I recommend anyone looking for performance to prefer gmpy2.isqrt

@wjmelements There's also math.isqrt, since Python 3.8.


Generated js not published to filesystem w/ 1.8.0

Using 1.8.0, when publishing to filesystem, generated .js files aren't published. Reverting to 1.7.6 fixes issue.

Can you be more specific. What do you mean 'publishing'? Is this a Visual Studio scenario?
Project details and repro steps would be helpful.

Sorry for being vague.
Yes, I mean publishing in Visual Studio 2015. I'll see if I can repro

the build log file will be helpful with  /verbosity:diagnostic

This may be related to this issue #6721

this does not seem actionable at the moment. a sample project or a set of steps to reproduce would be appreciated. closing now. please reopen if there additional information.


Add stac ingestor service

Don't we already have a stac-ingestor in eoapi-cdk @vincentsarago ?

I think the idea would be to have an endpoint where users can make a post request to @emileten . The underlying details need to be worked out.

@zacharyDez Users do make a POST request using the eoapi-cdk STAC Ingestor API.
I think we might want to close this issue in favor of the path outlined in https://github.com/developmentseed/eoAPI/issues/94 and open a new issue for implementing the transaction extension that can be used directly in local and k8s deployments.  As well as open a new issue showing how to use the STAC Ingestor API when working with the cdk deployment.

So I think the only TODO in this ticket was to actually add this ingestor service in our demo deployment, which I did : https://ingestor.eoapi.dev/. This will show 'Not found', it's normal. Sorry the /docs endpoint is broken.
I'll fix the docs endpoint, but the gist is that you can make a post request to either the collections or the ingestions endpoint to add a collection/item to your catalog.
I'll close this for now.

there is already a ticket to fix the docs https://github.com/developmentseed/eoapi-cdk/issues/79
there is work in progress to have a standalone repo for this ingestor (we should add docs there)  https://github.com/developmentseed/pgstac-ingestor


Finish unit testing of HW transformations in mrack plugin

Pull Request Checklist

[x] implement the feature

/packit test

/packit test

Full provision test failed on known issues only:

#2687
#2744

Otherwise green.


Update guidelines for v3 and Swagger --> OAS

Create v2.0 folder, move the files there, and update them to reflect OAS wherever that reflects the up to date name of the spec.

Please add extensions.md file at the root of the guidelines folder linking to the moved file under the new directory (to avoid link breakage).

Added the EXTENSIONS.md at the root, linking to the one in 2.0.


[BUG] Hex dependency resolution failed with Phoenix 1.6.0

When trying to use the latest Prom_Ex with Phoenix 1.6.0 I get this dependency issue
Failed to use "telemetry_poller" (version 1.0.0) because
prom_ex (version 1.4.1) requires ~> 0.5.1
mix.lock specifies 1.0.0
** (Mix) Hex dependency resolution failed, change the version requirements of your dependencies or unlock them (by using mix deps.update or mix deps.unlock). If you are unable to resolve the conflicts you can try overriding with {:dependency, "~> 1.0", override: true}
Expected behavior
Latest Prom_Ex should use latest telemetry_poller

Thanks @akoutmos ! Sounds great! I'm looking forward to it!


fixing candidate filtering and adding functional tests for chocolatey_package

Functional tests using small dummy packages against a local feed.

cc @lamont-granquist

I found some issues when adding these and files a separate pr #4378 to fix. I can add those tests here when that is merged.
Also, I created these tests based on the the doc https://docs.chef.io/release/12-7/resource_chocolatey_package.html and now see we should add tests for upgrade too

LGTM :+1:

:+1:

In the process of adding functional tests, I stumbled accross a couple more issues:

The parsing of the choco list was building a hash of name/version pairs, and therefore overwriting older versions with the latest version. I missed this making my changes responding to @lamont-granquist 's comments. So now the initial parsing creates an array of name/versions which are later filtered when determining available versions.

There were issues with name casing. The final name/version hash uses a mixed case key and when filtered against pinned versions that key was compared to a forced lowercase package name. So I convert the name/version pairs to use lowercase names now making the casing equal on both sides of the comparison.

I have added and edited unit tests to account for these cases  in addition to adding functional tests. I'm going to request another review/thumbs up before merging this since there was a fair amount of change to the provider.

responded to @lamont-granquist review. Great to know about each_with_object!

:+1:  LGTM
looks like you need to rebase -- suspect that the double-quotes PR trolled you.
@chef/client-core and @chef/client-windows need review

:+1:


How to make device and format filters strict ❓

Question
Is there a way to make "useCameraDevice" and "useCameraFormat" strict? Currently, if I do this:
const ultraWideBackDevice = useCameraDevice('back', { physicalDevices: ['ultra-wide-angle-camera'] });

It returns a device without "ultra-wide-angle-camera" support. And if I do this:
const hdrFormat = useCameraFormat(device, [{ fps: 30, photoHDR: true }]);

I get a device without HDR support. I need to display HDR and UW buttons on screen if those are supported on the device, but this method doesn't work because they always return a device, even if the requested features are not supported. Do I have to filter the devices manually?
What I tried
No response
VisionCamera Version
3.6.4
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

I ended up doing this:
    const desiredUltraWideBackDevice = useCameraDevice('back', { physicalDevices: ['ultra-wide-angle-camera'] });
    const desiredUltraWideFrontDevice = useCameraDevice('front', { physicalDevices: ['ultra-wide-angle-camera'] });
    const { ultraWideBackDevice, ultraWideFrontDevice } = React.useMemo(() => {
        return {
            ultraWideBackDevice: desiredUltraWideBackDevice?.physicalDevices.includes('ultra-wide-angle-camera') ? desiredUltraWideBackDevice : null,
            ultraWideFrontDevice: desiredUltraWideFrontDevice?.physicalDevices.includes('ultra-wide-angle-camera') ? desiredUltraWideBackDevice : null,
        };
    }, [desiredUltraWideBackDevice, desiredUltraWideFrontDevice]);
    const isUltraWideSupported = ultraWideBackDevice != null || ultraWideFrontDevice != null;

It works, although it looks like it could be simplified in a single hook call. Please let me know if there's a better way to do this.

Well yes, you need to implement your own hook. The point of the hook by VisionCamera is to be safe, as in; always find a device even if the criteria isn't met.


Get local weather conditions

We need to get local weather conditions by thinkpage api.

API document

Got it.


Document PR 96376

do yeet PR: https://github.com/rust-lang/rust/pull/96376
yeet expressions tracking issue: https://github.com/rust-lang/rust/issues/96373
core::ops::Yeet tracking issue: https://github.com/rust-lang/rust/issues/96374

Thanks!


Do some refactoring

Hi @wfxr
I was feeling like I need to do some contribution so here I am.

Check list

[x] I have read through the README (especially F.A.Q section)
[x] I have searched through the existing issues or pull requests
[x] I have performed a self-review of my code and commented hard-to-understand areas
[x] I have made corresponding changes to the documentation (when necessary)

Description

Type of change

[ ] Bug fix
[ ] New feature
[x] Refactor
[ ] Breaking change
[ ] Documentation change
[ ] CICD related improvement

Test environment

OS

[] Linux
[ ] Mac OS X
[ ] Windows
[x] Others:

@zhiburt LGTM. Thanks for your contribution!


Auth for private proxy

Please follow the guide below

Issues submitted without this template format will be ignored.
You will be asked some questions and requested to provide some information, please read them carefully and answer completely.
Put an x into all the boxes [ ] relevant to your issue (like so [x]).
Use the Preview tab to see how your issue will actually look like.

Before submitting an issue, make sure you have:

[ X] Updated to the latest version
[ X] Read the README and docs
[x ] Searched the bugtracker for similar issues including closed ones

Purpose of your issue?

[ ] Bug report (encountered problems/errors)
[ ] Feature request (request for a new functionality)
[ X] Question
[ ] Other

The following sections requests more details for particular types of issues, you can remove any section (the contents between the triple ---) not applicable to your issue.

Describe your issue
I see in the docs how to add a proxy.  But how do we pass a username and password for private proxies?
Login(proxy="user.pass.XXX.XX.XX.XX:8080" this doesnt seem to work
Explanation of your issue goes here. Please make sure the description is worded well enough to be understood with as much context and examples as possible.

have you tried the good old user:pass@ip:port method?

We should add this information to the readme I was going ip:user:pass documents would be nice

Hello!
Seems like user:pass@ip:port doesn't work.
WARNING - Not supported proxy scheme **<user_login>** error
Everything works if I fix api.set_proxy() method like this:
if self.proxy:
    proxies = {'http': 'http://'+self.proxy, 'https': 'https://'+self.proxy}
    self.session.proxies.update(proxies)

use http://user:pass@ip:port


GitHub Issue #227: Add curl_error() to check for log submission failures

This PR injects result of curl_error() into the Response object in case of curl request problems.
Ready for review.

This is ready for review in PR https://github.com/rollbar/rollbar-php/pull/231
The result of curl_error() is injected into Response object under info property and available through getInfo(). @and-megan let me know if this makes diagnosing your issues easier.


Build Playlist Classes and Diagram

Build these playlist domain classes and supporting .cd file in VS:

The entities not included will be added with their own issue and diagram.


Update browser limitation note in SignalR code sample

@BrennanConroy  let me know if you'd like to call this out in https://learn.microsoft.com/en-us/aspnet/core/signalr/authn-and-authz

It's already called out in that page.


Request: Notify in workflow

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Describe the problem imposed by not having this feature
Our team want to add the wecom notify in workflow not in job only.
Describe the solution you'd like
Wecom notify when all the jobs fail or pass in one workflow.
Other
No response

Hi @FuFangyuan, after done some analysis, there is not a simple and quick way to achieve the requirement. Please let me know if you have any ideas.


Logo In Mobile Layout Is Offcenter

As a mobile user when I visit the page the logo is offcenter and not fully displayed

Will update with a better description in the morning.
Also, will add pictures. My mobile github app is kind of garbage right now.

As promised, here are screenshots of the issues. I'm running Android, Version 6.0.1 on Samsung Galaxy Note 5.
On my device, it almost looks like the banner has static settings instead of scaling with mobile screen resolution. Additionally, the hamburger will expand, but I'm unable to collapse it without going back to the previous page or select an option.

First issue is fixed in #526.
Did you try clicking outside of menu to collapse?

@rickr it is not fixed still.

There were 3 issues in this ticket. The first one was resolved (text to big in the header) in #526 and I don't think the 3rd issue is actually an issue so I renamed the ticket to deal only with the offcenter logo. Perhaps I should have closed this one and opened 3 more to avoid confusion.

good call I agree.

Guys I made some changes in the css and after those changes its looking like this .. but I am not used to the ways and means of github so I cannot post the solution. I will try to post it, but this is the expected result right ?

Just do these two changes and you would be good


Add optional location parameter to create_empty_partition Hive procedure

Hey @findepi, I would like to contribute to this. I am new to this and so I will be bothering you a bit. Also if you can elaborate it will be a great help.

very cool, looking forward!
Please use the #dev channel on our slack for any questions you may have.

@Gyanesha : You can ping me too. I am also working on it.


Callback parameter to page.open() is not getting fired

<EMAIL_ADDRESS>commented:

Which version of PhantomJS are you using? Tip: run 'phantomjs --version'.
1.5.1 (development)
What steps will reproduce the problem?

phantomjs.exe rasterize.js "http://latimesblogs.latimes.com/world_now/2012/09/two-killed-as-tunisia-protest-against-film-spiraled-into-violence.html" test1.png

phantomjs.exe rasterize.js "http://www.huffingtonpost.com/sanjay-sanghoee/romney-versus-bloomberg_b_1881218.html?utm_hp_ref=elections-2012" test2.png

What is the expected output? What do you see instead?
The aforementioned webpages aren't getting captured. The callback to page.open() never gets fired and the script never exits.
Which operating system are you using?
Windows 7
Did you use binary PhantomJS or did you compile it from source?
Binary
Please provide any additional information below.

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #780.
:star2:   3 people had starred this issue at the time of migration.

I am having this issue when I run phantom JS on a local page from PHP using shell_exec():
PHP Script:
<?php
error_reporting(E_ALL);
session_write_close();
$result = shell_exec('phantomjs server.js ' . $_GET['url'] );
echo $result;

JS script
/**
 *  PhantomJs server for calling webpages & processing JS
 *  returns page content
 */

var args = require('system').args;
var address = args[1];
address = 'http://local.wordpress.dev/';

console.log('PhantomJs is accessing ' + address);
var page = new WebPage();

/**
 *
 */
page.onResourceError = function(resourceError) {
    page.reason = resourceError.errorString;
    page.reason_url = resourceError.url;
};

/**
 *
 */
phantom.onError = function(msg, trace) {
  var msgStack = ['PHANTOM ERROR: ' + msg];
  if (trace && trace.length) {
    msgStack.push('TRACE:');
    trace.forEach(function(t) {
      msgStack.push(' -> ' + (t.file || t.sourceURL) + ': ' + t.line + (t.function ? ' (in function ' + t.function +')' : ''));
    });
  }
  console.error(msgStack.join('\n'));
  phantom.exit(1);
};

/**
 *
 */
page.onError = function(msg, trace) {

  var msgStack = ['ERROR: ' + msg];

  if (trace && trace.length) {
    msgStack.push('TRACE:');
    trace.forEach(function(t) {
      msgStack.push(' -> ' + t.file + ': ' + t.line + (t.function ? ' (in function "' + t.function +'")' : ''));
    });
  }

  console.error(msgStack.join('\n'));

};

/**
 *
 */
console.log( typeof address );
page.open( address , function (status) {
	console.log('here5');
    if ('success' !== status) {
        console.log(
			"Error opening url \"" + page.reason_url
			+ "\": " + page.reason
		);
		phantom.exit( 1 );
    } else {
		console.log('here');
		console.log(page.content);
        phantom.exit();
    }
});

If I change the URL to a live remote server rather than a local server; for example if I set the URL to twitter.com then I have no trouble getting a response body back from the PHP method.

https://github.com/ariya/phantomjs/issues/13273


[refactor]: introduce syn 2.0 + manyhow showcase

Description
This PR adds syn 2.0 to the workspace (under the name of syn2, to allow co-existence of different versions).
It then updates iroha_version_derive to use syn2, as well as moving from unmaintained proc-macro-error to manyhow.
There are some rough edges in the API, but they are pretty minor and, seemingly, will be resolved soon (see https://github.com/ModProg/manyhow/issues/2#issuecomment-1643604170, https://github.com/ModProg/manyhow/issues/6).
Benefits
Unlike proc-macro-error, manyhow is actively maintained and has cleaner API that does not rely on global state.
Checklist

[ ] Replace uses of Accumulator with upstream Emitter

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

69 of 121 (57.02%)  changed or added relevant lines in 1 file are covered.
2442 unchanged lines in 48 files lost coverage.
Overall coverage decreased (-0.1%) to 59.299%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

version/derive/src/lib.rs
69
121
57.02%

Files with Coverage Reduction
New Missed Lines
%

client_cli/src/main.rs
1
0%

client/src/http_default.rs
1
0%

cli/src/main.rs
1
0%

core/src/smartcontracts/isi/asset.rs
1
29.79%

core/src/sumeragi/network_topology.rs
1
96.77%

derive_primitives/src/lib.rs
1
0%

macro/derive/src/lib.rs
1
94.59%

data_model/src/name.rs
2
94.25%

core/src/smartcontracts/isi/query.rs
3
96.69%

cli/derive/src/lib.rs
5
93.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
19865

Relevant Lines:
33500

💛  - Coveralls


You can Event Horizon people

Description
Dragging someone thru the stairs sends both you and them into space near the ship for some reason
Reproduction
Drag someone thru the stair teleport poing

Should be fixed.


Add unit test for function ListVolumeName

Ⅰ. Describe what this PR did
Add unit-test for Volume Core's ListVolumeName method which locate on storage/volume/core.go.
Ⅱ. Does this pull request fix one issue?

fixes #1763
Ⅲ. Describe how you did it
The test function creates several fake volumes in a fake driver, and then invoke Core.ListVolumeName to get volume names, finally it check whether all the volumes created above are all listed.
Ⅳ. Describe how to verify it

check whether err is nil
check whether volume name is "" (empty string)
check whether all volume name occurs in result

Ⅴ. Special notes for reviews
Baiji Group 2

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.still2009 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

It's Group 2 of Baiji (264)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@afc7a21). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1832   +/-   ##
=========================================
  Coverage          ?   52.95%
=========================================
  Files             ?      200
  Lines             ?    15659
  Branches          ?        0
=========================================
  Hits              ?     8293
  Misses            ?     6372
  Partials          ?      994

Flag
Coverage Δ

#critest
33.54% <ø> (?)

#integrationtest
41.42% <ø> (?)

#unittest
20.37% <ø> (?)


Fix connections leak

I summed up all the fixes about connection leaking in this PR. Please, check the commits @nicobritos.
About the thing that the connection is killed in background - yes, it happens but it's possible to handle it by the package (onConnectionErrorHandler) for example. Moreover, timer (checking for pong) is resumed in foreground - so the package tries too keep connection with all possible methods.
All that we need is to document those use-cases for flutter. Maybe I will create separate .md file.

@mcfugger I think it's OK. It's already merged, but I think that changing the public interface methods like connect to connectSafely isn't necessary and is a burden to the developers using this library, and will need a major version change (from 0.x.x to 1.x.x) not to silently break their projects (pubspect automatically sets a package version with a caret (^) which tells dart to use the latest (or any?) version ranging from that minor version until de next major one, like: ^0.2.2 will get a package with version 0.2.2 <= x < 1.0.0).
I think we should consider not changing the names of these methods to prevent this issue.


Faster headers copy

Improves performance of copying headers when the hashing strategy and name validator are exactly equivalent
Also fixes an issue in CombinedHttpHeaders when copying from another instance of the same type which caused double escaping

@nmittler @buchgr

@buchgr resolved merge conflicts etc. PTAL

@louiscryan LGTM
@Scottmitch do you want to take a look as well?

@louiscryan looks good. why/where do you care about the performance of this?

GRPC is going to store a header template per signature and use that when creating it's calls to avoid some of the costs we incur today converting to Netty headers.
These copying costs showed up in GRPC profiling. I'll provide some no's....

Here's the WIP in GRPC
https://github.com/grpc/grpc-java/pull/1183

ic. makes sense :).

@Scottmitch FYI this PR can be backported to 4.1

@louiscryan - In general LGTM. A few comments / questions

Note that the http header copy fastest path is decently faster than http2s which is a curiosity

Fixed checkstyle issue and nettified the commit message format

Benchmark                         Mode  Cnt    Score    Error  Units
HeadersBenchmark.http2AddAllFast  avgt   10  243.314 ± 28.893  ns/op
HeadersBenchmark.http2AddAllSlow  avgt   10  242.381 ± 17.805  ns/op
HeadersBenchmark.httpAddAllFast   avgt   10  180.437 ± 11.777  ns/op

I am getting this for headers of size 11.

I'm running OpenJDK7 on a linux box. With the latest commit which clearly separates fastest / fast / slow paths I get
Benchmark                            (exampleHeader)  Mode  Cnt     Score     Error  Units
HeadersBenchmark.http2AddAllFastest             FIVE  avgt   10   140.406 ±  17.154  ns/op
HeadersBenchmark.http2AddAllFast                FIVE  avgt   10   203.138 ±  32.585  ns/op
HeadersBenchmark.http2AddAllSlow                FIVE  avgt   10   244.247 ±  72.164  ns/op
HeadersBenchmark.http2AddAllFastest        TWENTYTWO  avgt   10   482.338 ±  16.192  ns/op
HeadersBenchmark.http2AddAllFast           TWENTYTWO  avgt   10  1182.494 ± 260.362  ns/op
HeadersBenchmark.http2AddAllSlow           TWENTYTWO  avgt   10  1032.513 ± 221.226  ns/op
HeadersBenchmark.httpAddAllFastest              FIVE  avgt   10    97.299 ±   7.988  ns/op
HeadersBenchmark.httpAddAllFast                 FIVE  avgt   10   238.553 ±   2.578  ns/op
HeadersBenchmark.httpAddAllSlow                 FIVE  avgt   10   233.353 ±  18.746  ns/op
HeadersBenchmark.httpAddAllFastest         TWENTYTWO  avgt   10   397.501 ±  32.275  ns/op
HeadersBenchmark.httpAddAllFast            TWENTYTWO  avgt   10  1705.913 ± 269.910  ns/op
HeadersBenchmark.httpAddAllSlow            TWENTYTWO  avgt   10  1616.167 ±  47.053  ns/op

Note that I switched to using 10 iterations & 10 warmup iterations with 1 fork. Results seemed more stable that way

@louiscryan - Thanks for the updated results!
@buchgr - Are you still looking into the difference between HTTP and HTTP/2 for the Fastest code path? The HTTP/2 headers do have a difference from HTTP headers in the add0 method. For HTTP/2 the newHeaderEntry method is overridden to enforce the pseudo headers first iteration order.  I wonder if this is disabled (just for the benchmark) how that would impact the benchmark results....let me check this.

@buchgr - My previous hunch seemed to have some impact. After commenting out newHeaderEntry and Http2HeaderEntry in DefaultHttp2Headers I get the following results:
Header size of 8:
Benchmark                            Mode  Cnt    Score   Error  Units
HeadersBenchmark.http2AddAllFastest  avgt    5  102.395 ± 7.644  ns/op
HeadersBenchmark.httpAddAllFastest   avgt    5  101.258 ± 4.519  ns/op

I believe the difference is because HTTP2 has to order pseduo headers before non-pseudo headers and this incurs the overhead

... and I'm too slow on the draw again :)

@louiscryan :wink: We can look into optimizing this pseudo header ordering enforcement as a followup PR if necessary.

@louiscryan - Few more comments then I think we are good.

@Scottmitch Should be good to go now

Working on PR splitting now... Please hold

OK. Should be ready to go now that the other PRs are done.

@louiscryan LGTM

Cherry-picked 4.1 (6e108cb) master (1cdf0cb)
@louiscryan - Thanks! Make sure you follow the commit message template next time.


Release: v0.3.0

v0.3.0
Features

Can specify default strategy for the mapping
Until now, you could only specify the strategy during conversion, so if you
wanted to always use a SETATTR strategy you would have to pass it each time
you convert something. Now you can define the strategy when registering a
mapping and then it will be used as default for all conversions. You can
still override the strategy directly in convert, but the default is now
specified in the mapping.

Changes

The mapping functions do not take name anymore
The name is never used anyway and is always on the other side of ‘=‘ in the
mapping. No need to keep it and makes things longer. Getting rid of it to
simplify the mappers slightly.

Codecov Report

Merging #25 (92ca278) into master (b0c6052) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          144       147    +3
  Branches        22        22
=========================================
+ Hits           144       147    +3

Impacted Files
Coverage Δ

src/mappr/conversion.py
100.00% <100.00%> (ø)

src/mappr/mappers.py
100.00% <100.00%> (ø)

src/mappr/types.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c6052...92ca278. Read the comment docs.


Pass and attack play

Created a draft of a Pass and Attack play. Not used anywhere yet.
Waiting on #773 and #769 to be merged first.

Waiting for comments to be processed


Automated Package Upgrade

:tada: This PR is included in version 5.0.418 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Download pretrained models

Sorry to bother you @jwyang , but I can't download the pretrained models from dropbox because of the GFW. Would you please provide some other links of those models like VT server. I noticed that you put two pretrained base models in https://filebox.ece.vt.edu/~jw2yang/faster-rcnn/pretrained-base-models/, but the directory of /pretrained-models is empty. Can you put the rest models in there? Thank you.

@jwyang I also can't download the your pretrained models from dropbox. Could please put the model on Baidu drive?Thank you a lot!

I also can't download models from dropbox. Could you please put the model on Baidu drive?Thanks

@jwyang  I can't download the pretrained models from dropbox because of the GFW too


utils.py added

@smithdc1 I have migrated several benchmarks and will be adding them as soon as this gets merged. Are there any changes that I have to make to this?

Thanks for this. I assume you'll migrate the benchmarks to use this in following commits?

Thank you for merging this. Yes, I am going to use this in following commits and pr's


Refactoring to allow use of im AND seg in the registration process

For now, in the registration process (namely in msct_register) it is not possible to implement a new method that uses both the image and the segmentation of the source and destination MRI. The contributor is forced to either developp a method that register based on segmentations or on images but cannot use both. This can be easily understood when looking at the parameter type which must be equal to im or seg (or label).
In this PR we introduce the im_seg type and all the necessary changes without breaking compatibility, which will allow further development of registration methods, in particular a method based on the symmetry of the SC, discussed in #2204 and #836.
Feel free to criticize the way this is introduced, as I am not entirely confident on the best way to introduce this change.

First small comment: Document the type im_seg in the help of sct_register_multimodal: https://github.com/neuropoly/spinalcordtoolbox/blob/c7317b9d8fda40d97a433508e0030c0e7cb19720/scripts/sct_register_multimodal.py#L120

First small comment: Document the type im_seg in the help of sct_register_multimodal:

@charleygros we discussed about changing the philosophy of the approach wrt. the new type im_seg(see my comments), so no need to spend time reviewing now because the code will change in the next few days.

I have looked at the new philosophy of the approach and really like it: To use a list of file for fname_src in case of im_seg approach makes complete sense to me.
Also, you made sure that your code allows the addition of further approaches.
Sounds good to me!
Look forward to hearing about your approach based on symmetry / HOG!

On 366fd4cb657096452770f620e5480dfa57700920 I got this error:

julien-macbook:~/sct_example_data/t2s $ sct_register_to_template -i t2s.nii.gz -s t2s_seg.nii.gz -ldisc t2s_label_disc_4.nii.gz -ref subject -param step=1,type=im,algo=centermassrot,rot_method=hog -r 0

Check template files...
  OK: /Users/julien/code/sct/data/PAM50/template/PAM50_t2.nii.gz
  OK: /Users/julien/code/sct/data/PAM50/template/PAM50_levels.nii.gz
  OK: /Users/julien/code/sct/data/PAM50/template/PAM50_cord.nii.gz

Check parameters:
  Data:                 t2s.nii.gz
  Landmarks:            t2s_label_disc_4.nii.gz
  Segmentation:         t2s_seg.nii.gz
  Path template:        /Users/julien/code/sct/data/PAM50
  Remove temp files:    0

Check input labels...

Create temporary folder (/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H)...

Copying input data to tmp folder and convert to nii...
WARNING: File /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/template_label.nii.gz already exists. Will overwrite it.

Check if provided labels are available in the template
WARNING: Only one label is present. Forcing initial transformation to: Tx_Ty_Tz

Binarize segmentation
sct_maths -i seg.nii.gz -bin 0.5 -o seg_bin.nii.gz # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H

Change orientation of input images to RPI...

Remove unused label on template. Keep only label present in the input label image...
sct_label_utils -i template_label.nii.gz -o template_label.nii.gz -remove /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/label_projected_rpi.nii.gz # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H
WARNING: File /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/label_projected_rpi.nii.gz already exists. Will overwrite it.
WARNING: File /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/template_label.nii.gz already exists. Will overwrite it.

Estimate transformation for step #0...
Labels src: [[-0.0, 46.220001220703125, -126.34002685546875], [5.0, 46.220001220703125, -126.34002685546875]]
Labels dest: [[-2.1897559923394851, 12.839687496423721, 6.4044257700443268], [2.7911416130796738, 12.901108872145414, 5.9721228182315826]]
Degrees of freedom (dof): Tx_Ty_Tz
Optimization terminated successfully.
         Current function value: 0.095512
         Iterations: 2
         Function evaluations: 115
Matrix:
[[ 1.  0.  0.]
 [ 0.  1.  0.]
 [-0.  0.  1.]]
Center:
[  0.30069281  12.87039818   6.18827429]
Translation:
[[   2.19930719   33.34960304 -132.52830115]]

Estimate transformation for step #1...
sct_apply_transfo -i template.nii -d /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/data_rpi.nii -w template2subjectAffine.txt -o template_regStep0.nii -x linear # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H
Registration parameters:
  type ........... im
  algo ........... centermassrot
  slicewise ...... 0
  metric ......... MeanSquares
  iter ........... 10
  smooth ......... 0
  laplacian ...... 0
  shrink ......... 1
  gradStep ....... 0.5
  deformation .... 1x1x0
  init ...........
  poly ........... 5
  dof ............ Tx_Ty_Tz_Rx_Ry_Rz
  smoothWarpXY ... 2
  rot_method ... hog

WARNING: algo centermassrot should be used with type=seg.

Create temporary folder (/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105207.322051-register-mgdK7E)...

Copy input data to temp folder...
Traceback (most recent call last):
  File "/Users/julien/code/sct/scripts/sct_register_to_template.py", line 804, in <module>
    main()
  File "/Users/julien/code/sct/scripts/sct_register_to_template.py", line 634, in main
    warp_forward_out, warp_inverse_out = register(src, dest, paramreg, param, str(i_step))
  File "/Users/julien/code/sct/scripts/sct_register_multimodal.py", line 805, in register
    verbose=param.verbose)
  File "/Users/julien/code/sct/scripts/msct_register.py", line 65, in register_slicewise
    convert(fname_src, os.path.join(path_tmp, "src.nii"))
  File "/Users/julien/code/sct/scripts/sct_convert.py", line 68, in convert
    sct.printv('sct_convert -i ' + fname_in + ' -o ' + fname_out, verbose, 'code')
TypeError: cannot concatenate 'str' and 'list' objects

On 366fd4c I got this error:
julien-macbook:~/sct_example_data/t2s $ sct_register_to_template -i t2s.nii.gz -s t2s_seg.nii.gz -ldisc t2s_label_disc_4.nii.gz -ref subject -param step=1,type=im,algo=centermassrot,rot_method=hog -r 0

Check template files...
  OK: /Users/julien/code/sct/data/PAM50/template/PAM50_t2.nii.gz
  OK: /Users/julien/code/sct/data/PAM50/template/PAM50_levels.nii.gz
  OK: /Users/julien/code/sct/data/PAM50/template/PAM50_cord.nii.gz

Check parameters:
  Data:                 t2s.nii.gz
  Landmarks:            t2s_label_disc_4.nii.gz
  Segmentation:         t2s_seg.nii.gz
  Path template:        /Users/julien/code/sct/data/PAM50
  Remove temp files:    0

Check input labels...

Create temporary folder (/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H)...

Copying input data to tmp folder and convert to nii...
WARNING: File /var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/template_label.nii.gz already exists. Will overwrite it.

Check if provided labels are available in the template
WARNING: Only one label is present. Forcing initial transformation to: Tx_Ty_Tz

Binarize segmentation
sct_maths -i seg.nii.gz -bin 0.5 -o seg_bin.nii.gz # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H

Change orientation of input images to RPI...

Remove unused label on template. Keep only label present in the input label image...
sct_label_utils -i template_label.nii.gz -o template_label.nii.gz -remove /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/label_projected_rpi.nii.gz # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H
WARNING: File /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/label_projected_rpi.nii.gz already exists. Will overwrite it.
WARNING: File /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/template_label.nii.gz already exists. Will overwrite it.

Estimate transformation for step #0...
Labels src: [[-0.0, 46.220001220703125, -126.34002685546875], [5.0, 46.220001220703125, -126.34002685546875]]
Labels dest: [[-2.1897559923394851, 12.839687496423721, 6.4044257700443268], [2.7911416130796738, 12.901108872145414, 5.9721228182315826]]
Degrees of freedom (dof): Tx_Ty_Tz
Optimization terminated successfully.
         Current function value: 0.095512
         Iterations: 2
         Function evaluations: 115
Matrix:
[[ 1.  0.  0.]
 [ 0.  1.  0.]
 [-0.  0.  1.]]
Center:
[  0.30069281  12.87039818   6.18827429]
Translation:
[[   2.19930719   33.34960304 -132.52830115]]

Estimate transformation for step #1...
sct_apply_transfo -i template.nii -d /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H/data_rpi.nii -w template2subjectAffine.txt -o template_regStep0.nii -x linear # in /private/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105158.288057-register_to_template-LOaR6H
Registration parameters:
  type ........... im
  algo ........... centermassrot
  slicewise ...... 0
  metric ......... MeanSquares
  iter ........... 10
  smooth ......... 0
  laplacian ...... 0
  shrink ......... 1
  gradStep ....... 0.5
  deformation .... 1x1x0
  init ...........
  poly ........... 5
  dof ............ Tx_Ty_Tz_Rx_Ry_Rz
  smoothWarpXY ... 2
  rot_method ... hog

WARNING: algo centermassrot should be used with type=seg.

Create temporary folder (/var/folders/6f/wy6ljmx9453cgth2qwv5l1s80000gn/T/sct-20190417105207.322051-register-mgdK7E)...

Copy input data to temp folder...
Traceback (most recent call last):
  File "/Users/julien/code/sct/scripts/sct_register_to_template.py", line 804, in <module>
    main()
  File "/Users/julien/code/sct/scripts/sct_register_to_template.py", line 634, in main
    warp_forward_out, warp_inverse_out = register(src, dest, paramreg, param, str(i_step))
  File "/Users/julien/code/sct/scripts/sct_register_multimodal.py", line 805, in register
    verbose=param.verbose)
  File "/Users/julien/code/sct/scripts/msct_register.py", line 65, in register_slicewise
    convert(fname_src, os.path.join(path_tmp, "src.nii"))
  File "/Users/julien/code/sct/scripts/sct_convert.py", line 68, in convert
    sct.printv('sct_convert -i ' + fname_in + ' -o ' + fname_out, verbose, 'code')
TypeError: cannot concatenate 'str' and 'list' objects

Has to do with upper case letter thing, I did call my method "HOG" and not "hog", will change that to lowercase

@Nicolas-Pinon can you run batch_processing.sh and report quantitative results in this PR (this test is more sensitive than Travis testing)? thanks

ok that's what i suspected, probably due to a new py2k deprecation, Travis is now failing on master (while it was passing a week ago, on the same commit): https://travis-ci.org/neuropoly/spinalcordtoolbox/builds/521741144?utm_medium=notification&utm_source=email
@Nicolas-Pinon i'll modify the .travis.yml config file to "fix" it

Results of batch_processing.sh:
Master<PHONE_NUMBER>f8563bd4ff6244ce3722511af7adaa) @Ubuntu (joplin)
t2/CSA:          78.5400045836
mt/MTR(WM):      54.0459866493
t2s/CSA_GM:      12.5743183686
t2s/CSA_WM:      65.411082456
dmri/FA(CST_r):  0.781010621741
dmri/FA(CST_l):  0.76445798757

Thanks a lot for the testing @jcohenadad !


implemented Endless Hunger and Brutal Fervour (100%)

corrected all entries on both ascendency nodes

@Openarl I could not figure out a way to forceful check Leeching with 'Brutal Fervour'. I forced Leeching via code, but could not update the UI too. I elected to do this as a player in combat can never NOT leech with this ascendency point taken.

Cancelling as #1699 supersedes this.