remove subpackage vendor

This change is

remove subpackage vendor from project
add vendor package into project, golang project always add vendor package into project, it will more friendly for developer.

/test tf-k8s-presubmit

/test tf-k8s-presubmit

@jlewi Do you know this CI status, seems i pass all test, but status is failed. thanks

Examples of checking in vendor
https://github.com/kubernetes/kubernetes
https://github.com/kubernetes/client-go/tree/master/vendor
https://github.com/ksonnet/ksonnet
https://github.com/kubernetes/test-infra
Some counter examples
https://github.com/grpc/grpc-go
https://github.com/GoogleCloudPlatform/google-cloud-go
https://github.com/google/glog
https://github.com/kubernetes/helm
It looks like our total repo size is ~125 MB and ~110 MB of this vendor.
But you have to download all 125 MB if you want to fully build it; so a smaller repo size doesn't really make cloning and building the code any faster.
So following the K8s convention and checking in vendor makes sense to me.
I'll investigate the test failure.

Looks like there's a bug in how we report failures and failed steps in our pipeline are not being reported to caicloud.
To see the actual error you'd have to look at Airflow and get the logs. You don't have permission for that but that's something we should fix.
Here's the error; looks like an issue with some dependencies not being found.
[2017-12-14 08:29:19,475] {base_task_runner.py:98} INFO - Subtask: INFO|2017-12-14T08:29:18|/opt/tensorflow_k8s/py/util.py|36| Running: go install github.com/tensorflow/k8s/cmd/tf_operator
[2017-12-14 08:29:19,475] {base_task_runner.py:98} INFO - Subtask: cwd=None
[2017-12-14 08:29:19,475] {base_task_runner.py:98} INFO - Subtask: INFO|2017-12-14T08:29:19|/opt/tensorflow_k8s/py/util.py|69| Subprocess output:
[2017-12-14 08:29:19,476] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/github.com/howeyc/gopass/terminal.go:5:8: cannot find package "golang.org/x/crypto/ssh/terminal" in any of:
[2017-12-14 08:29:19,476] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/crypto/ssh/terminal (vendor tree)
[2017-12-14 08:29:19,476] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/crypto/ssh/terminal (from $GOROOT)
[2017-12-14 08:29:19,477] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/crypto/ssh/terminal (from $GOPATH)
[2017-12-14 08:29:19,477] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/k8s.io/client-go/plugin/pkg/client/auth/gcp/gcp.go:30:2: cannot find package "golang.org/x/net/context" in any of:
[2017-12-14 08:29:19,478] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/net/context (vendor tree)
[2017-12-14 08:29:19,478] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/net/context (from $GOROOT)
[2017-12-14 08:29:19,478] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/net/context (from $GOPATH)
[2017-12-14 08:29:19,479] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/k8s.io/apimachinery/pkg/util/net/http.go:33:2: cannot find package "golang.org/x/net/http2" in any of:
[2017-12-14 08:29:19,479] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/net/http2 (vendor tree)
[2017-12-14 08:29:19,480] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/net/http2 (from $GOROOT)
[2017-12-14 08:29:19,480] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/net/http2 (from $GOPATH)
[2017-12-14 08:29:19,480] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/github.com/PuerkitoBio/purell/purell.go:17:2: cannot find package "golang.org/x/net/idna" in any of:
[2017-12-14 08:29:19,481] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/net/idna (vendor tree)
[2017-12-14 08:29:19,481] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/net/idna (from $GOROOT)
[2017-12-14 08:29:19,482] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/net/idna (from $GOPATH)
[2017-12-14 08:29:19,483] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/k8s.io/client-go/plugin/pkg/client/auth/gcp/gcp.go:31:2: cannot find package "golang.org/x/oauth2" in any of:
[2017-12-14 08:29:19,483] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/oauth2 (vendor tree)
[2017-12-14 08:29:19,483] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/oauth2 (from $GOROOT)
[2017-12-14 08:29:19,484] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/oauth2 (from $GOPATH)
[2017-12-14 08:29:19,484] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/k8s.io/client-go/plugin/pkg/client/auth/gcp/gcp.go:32:2: cannot find package "golang.org/x/oauth2/google" in any of:
[2017-12-14 08:29:19,485] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/oauth2/google (vendor tree)
[2017-12-14 08:29:19,485] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/oauth2/google (from $GOROOT)
[2017-12-14 08:29:19,485] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/oauth2/google (from $GOPATH)
[2017-12-14 08:29:19,488] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/github.com/PuerkitoBio/purell/purell.go:18:2: cannot find package "golang.org/x/text/secure/precis" in any of:
[2017-12-14 08:29:19,489] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/text/secure/precis (vendor tree)
[2017-12-14 08:29:19,489] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/text/secure/precis (from $GOROOT)
[2017-12-14 08:29:19,489] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/text/secure/precis (from $GOPATH)
[2017-12-14 08:29:19,490] {base_task_runner.py:98} INFO - Subtask: /var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/github.com/PuerkitoBio/purell/purell.go:19:2: cannot find package "golang.org/x/text/unicode/norm" in any of:
[2017-12-14 08:29:19,490] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/github.com/tensorflow/k8s/vendor/golang.org/x/text/unicode/norm (vendor tree)
[2017-12-14 08:29:19,490] {base_task_runner.py:98} INFO - Subtask: 	/usr/local/go/src/golang.org/x/text/unicode/norm (from $GOROOT)
[2017-12-14 08:29:19,491] {base_task_runner.py:98} INFO - Subtask: 	/var/lib/data/runs/tf_k8s_tests/2017-12-14T08_29_02/go/src/golang.org/x/text/unicode/norm (from $GOPATH)

@jlewi thanks, this log very helpful.


Access to Comments object

I want to delete one comment in Comments object or replace it, but Comments class has no methods for it. And Translation class has no methods for setting up a new Comments object.
How I can replace a comment? Maybe is there a PHP trick for it?

Mmmm, you're right, there's no way to remove comments!! (I've never need it :) And the same happens with flags.
I'm implementing this:
$comments->delete('This is a comment');

and let you know when it's shipped.
Thanks for notify!

v5.3.0 released

Very cool, thank you @oscarotero.


Still maintained?

Is this gem still maintained? We'd love to use it for a few projects.
@anitsirc, @MadsBuus, it looks like you're maintaining a fork over in https://github.com/karnov/htmltoword, with some great improvements, but have issues disabled?
Edit: The reason I ask, is that I'd also like to contribute. :smile:

Hi Ben,
Yes, we have taken up continuing the development here. Nick was a former employee here at Karnov, did a great initial work on this together with Cristina.
Out development has taken over development, and recently added a lot of cool features, and are planning more soon. We have been using it for several years, on several projects, but recently needed some more features to make the word documents prettier and more flexible.
I have enabled issues now, so please contribute :)
I will ask Cristina and Nick to point others to the fork https://github.com/karnov/htmltoword
Thanks,
Mads

@MadsBuus that's awesome to hear! We're looking to use the Gem for some of our internal workflow here at GitHub (lawyers and government agencies still :heart: Word docs). Looking forward to contributing.
Two last questions:

Any chance on taking over the Rubygems version as well? I've been building against the Fork on GitHub, but it'd make deployments easier.

With @nickfrandsen's permission, we can actually invert the fork graph, if you'd like, to make https://github.com/karnov/htmltoword the canonical version.

Haha, True.
Karnov is in the 'lawyers and government' business as well :)
Yes, I will talk to Nick about reversing the fork, and owning the rubygems version.
Cristina is back in the offfice tuesday, and has access to the repo I think.
Meanwhile, try out our fork:
We have a lot of internal gems, so we use something like:
git_source(:karnov) { |name| "git@github.com:karnov/#{name}.git" }
gem 'htmltoword', karnov: 'htmltoword', branch: 'master'

@benbalter, Rubygems version now points to karnov/htmltoword and it's up to date. And question 2 would be nice to do. @nickfrandsen can you do that?

is it still maintained?


Compilation in src/main/java/com/amazon/redshift/util/StreamWrapper.java with latest versions of Java

The following code doesn't compile with JDK 21 and newer: https://github.com/aws/amazon-redshift-jdbc-driver/blob/5fd2db671a187c6f9e39dc9831798000e1166fe9/src/main/java/com/amazon/redshift/util/StreamWrapper.java#L116
It overrides finalize() in FileInputStream, which throws IOException. That override was removed in JDK 12: https://bugs.openjdk.org/browse/JDK-8192939
The compilation error with newer versions is:
com/amazon/redshift/util/StreamWrapper.java:120: error: unreported exception Throwable; must be caught or declared to be thrown
            super.finalize();
                          ^

Thanks for submitting this issue @cushon . I'll take a look and get back to you when I have an update


Start 2024 Summer School page

This PR starts a page for the 2024 Summer School. There's a lot of "check back here" which we can fill in later. The banner image is also something I just slapped together; not married to it yet.
The page will be at:
https://pyhc.org/summer-school-24

@jibarnum I'm gonna merge right away (like I've been making a habit of lately). That way nothing is holding us back from sharing the press release.
If you have any feedback I'll be happy to incorporate it.


updated urls for django 1.10 compatibility

Coverage decreased (-0.6%) to 70.379% when pulling 8584f714934cb4d98a0be96f664cb7d4ea0dda4c on martibosch:master into e1b969c413ef970dad0de0210aa1ceddf2eae76b on mgaitan:master.

Coverage decreased (-0.6%) to 70.379% when pulling 8584f714934cb4d98a0be96f664cb7d4ea0dda4c on martibosch:master into e1b969c413ef970dad0de0210aa1ceddf2eae76b on mgaitan:master.


PyCharm EAP 2020.1

I'm using kite <IP_ADDRESS> and sadly it is not compatible with PyCharm EAP 2020.1 CE, which I need to use because the stable version is broken on my setup.
Any idea when kite will support this EAP version?

@fdellwing
support for the current EAPs will most likely be released later this week.


Table format doesn't look right

Go to https://sonarwhal.com/docs/user-guide/rules/rule-performance-budget/#can-the-rule-be-configured
This is how it looks in Edge:

Looks like there are styles missing from the CSS.


Heroku deployment.

This change enables continuous delivery to Heroku. The default URL
is http://service-maker-demo.herokuapp.com.

Thanks! Looks like the service is live at http://service-maker-demo.herokuapp.com and is successfully deploying on merges to v1.0 :-)


Improve telemetry for "Edit in Config" and "Create Bicep Configuration File"

https://github.com/Azure/bicep/issues/5711

@StephenWeatherford, what improvements are you looking to make?
I'm thinking the telemetry would be along the lines of:

Capturing which rule they are calling edit in config on
and capturing IF a user called create bicep configuration file at all

Has this been completed?


paper1111: Watch khandokermdabdulmatin.wordpress.com

paper1111 requests the watch of the watch_keyword khandokermdabdulmatin.wordpress.com. See the Metasmoke search here

Duplicate, already watched. (Dupe check didn't find it because of capitalization differences.)


ARTEMIS-4504: use cli script to fix examples shutdown config issue

Passed the PR build a couple times on my fork, and a full test suite build plus the examples verification script.


tf2.0 - tf.keras.optimizers.Optimizer.get_updates() does not work

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux-4.14.79+-x86_64-with-Ubuntu-18.04-bionic
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.0.0-dev20190203
Python version: 3.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the current behavior
When keras optimizer's get_updates() function is called, it raises error "RuntimeError: tf.gradients is not supported when eager execution is enabled. Use tf.GradientTape instead."
Describe the expected behavior
I expect it returns correct operators that can be used to build keras function that changes weights.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
from tensorflow import keras
model = keras.Sequential()
model.add(keras.layers.Dense(1, input_shape=(1,)))
model.compile(optimizer='adam', loss='mse')
loss = keras.losses.mse(model.input, model.output)
updates = model.optimizer.get_updates(params=model.trainable_weights, loss=loss)

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Traceback:
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-4-f4bb57df0d91> in <module>()
      5 loss = keras.losses.mse(model.input, model.output)
      6 model.optimizer.get_updates(
----> 7         params=model.trainable_weights, loss=loss)

/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/optimizer_v2/optimizer_v2.py in get_updates(self, loss, params)
    440
    441   def get_updates(self, loss, params):
--> 442     grads = self.get_gradients(loss, params)
    443     grads_and_vars = list(zip(grads, params))
    444     self._assert_valid_dtypes([

/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/optimizer_v2/optimizer_v2.py in get_gradients(self, loss, params)
    353     """
    354     loss = self._scale_loss(loss)
--> 355     grads = gradients.gradients(loss, params)
    356     if None in grads:
    357       raise ValueError("An operation has `None` for gradient. "

/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/gradients_impl.py in gradients(ys, xs, grad_ys, name, colocate_gradients_with_ops, gate_gradients, aggregation_method, stop_gradients, unconnected_gradients)
    156         ys, xs, grad_ys, name, colocate_gradients_with_ops,
    157         gate_gradients, aggregation_method, stop_gradients,
--> 158         unconnected_gradients)
    159   # pylint: enable=protected-access
    160

/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/gradients_util.py in _GradientsHelper(ys, xs, grad_ys, name, colocate_gradients_with_ops, gate_gradients, aggregation_method, stop_gradients, unconnected_gradients, src_graph)
    545   """Implementation of gradients()."""
    546   if context.executing_eagerly():
--> 547     raise RuntimeError("tf.gradients is not supported when eager execution "
    548                        "is enabled. Use tf.GradientTape instead.")
    549   if src_graph is None:

RuntimeError: tf.gradients is not supported when eager execution is enabled. Use tf.GradientTape instead.

This is fixed TF 2.0 nightly '2.0.0-dev20190718'
Thanks!


Update style button in case disable

[x] Update style icon

[x] Detail Token screen

[x] Import account

[x] Select account type

[x] Attach Read only account

[x] Account detail

[x] Confirmation screen

Version test: v1.0.2(149)
Devices test: IP 11
Validation passed.


KafkaConsumer should be in all.

Hey, just noticed that the new KafkaConsumeris not in __all__ making it hard to import. This PR fixes it :)

Thanks!  TravisCI failure seems like a flapper -- I kicked the test, and will merge when it passes.

Grand! I was wondering if there was any estimated date on when the new version with this consumer is going to be released?

Explicit imports should work without __all__:
from kafka import KafkaConsumer
as well as
from kafka.consumer.kafka import KafkaConsumer
This PR will include the KafkaConsumer in from kafka import * .  I'm not a big fan of * imports, but I acknowledge that many folks find it useful.

Would love to cut a new release as soon as possible. there's lots of new bits since 0.9.2


the link to moody in the readme appears broken

Ah, moody was made private while it under goes some major changes, I'll remove the link for now

Ok, thanks for letting me know
From: Andrew Frost <notifications<EMAIL_ADDRESS>Reply-To: Afrostie/Mopviewer <reply<EMAIL_ADDRESS>Date: Friday, 25 March 2016 at 21:25
To: Afrostie/Mopviewer <Mopviewer<EMAIL_ADDRESS>Subject: Re: [Mopviewer] the link to moody in the readme appears broken (#3)
Ah, moody was made private while it under goes some major changes, I'll remove the link for now

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/Afrostie/Mopviewer/issues/3#issuecomment-201514172

Oh wait, you mean mine, yes, I didn't think anyone was interested in it anyway, there've been no downloads, so I hid it until things were done as regards file formats and such.
From: Andrew Frost <notifications<EMAIL_ADDRESS>Reply-To: Afrostie/Mopviewer <reply<EMAIL_ADDRESS>Date: Friday, 25 March 2016 at 21:25
To: Afrostie/Mopviewer <Mopviewer<EMAIL_ADDRESS>Subject: Re: [Mopviewer] the link to moody in the readme appears broken (#3)
Ah, moody was made private while it under goes some major changes, I'll remove the link for now

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/Afrostie/Mopviewer/issues/3#issuecomment-201514172

I have been playing around with what I assume is an older version of Moody I found on Github.  I added GLFW support and a rendering thread so that it renders to an opengl context instead of writing a mop file.  I will set it aside if you are making changes though.  Thanks!

That version is rather out of date, yes. The mop file format needs a makeover to allow for compression and entry skipping. Given the view optimisations of Mopviewer (particle skipping), the originally planned compression technique is inadequate. It’s this that made me make Moody’s current repository private until my file writer and reader (which is shared with MopViewer) is updated and working. At present all I'm doing is producing test datasets for Andrew.

moody is now public again. I haven't finished all the changes yet, but I've started.
I want to add in FaceBooks Folly library
https://github.com/facebook/folly
and ditch the STD library, but I'm not there yet.

Ok, i added the link back in for the moment, I'll close this for now

Thanks guys!


bge-reranker-large 按照readme微调时warning find_unused_parameters=True was specified in DDP constructor

bge-reranker-large、bge-reranker-base 按照readme微调时，提示如下，请问这个正常吗

Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters in the forward pass. This flag results in an extra traversal of the autograd graph every iteration,  which can adversely affect performance. If your model indeed never has any unused parameters in the forward pass, consider turning this flag off. Note that this warning may be a false positive if your model has flow control causing later iterations to have unused parameters. (function operator())

不用理会这个warning


Adding footer

I would like to add footer to your website in which i want to add your contact links, about your website and also logo.
Like this

Hi @vikhyatsingh123 can I soleve this issue?

hello sir, I want to contribute to this issue so can you please assign this to me.

Hello sir , I want to contribute to this issue, can you please assign me !

I am very much familier with these type of problems. Please assign me for this issue.


Add a search bar to Docusaurus docs

Problem: Searchability is essential to documentation and a search bar no longer exist in the new docs.
Solution: Add a search bar.
This Docusaurus feature might be handy: https://docusaurus.io/docs/en/search

💯 on this. It is my belief that we need to publish the doc site (at the final URL) so that algolia can crawl the docs and index them. Was planning on implementing search within hours of release and site publish.

Update here: I submitted the Druid docs for indexing.


[FLINK-5956] [table] Add retract method for aggregateFunction

This PR adds retraction method for AggregateFunction, it also implements retract methods as well as test cases for all built-in aggregates.
Retraction method is help for processing update message. It will also very helpful for the grouping window and over window aggregation where we may want to retract the out of window data from the accumulator.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

@fhueske, we should add different built-in aggregates for the ones that are not easy to be retracted (for instance Max and Min), one as withRetract(used for over window as # of items are limited, also for the dataStream when retraction is absolute needed) the other one as withoutRetract (used for dataSet and dataStream where retraction is not needed), it is the optimizer to check the rules and decide which aggregate should be used. I think we can go ahead as this (withRetract) for now, and complete the entire design together with dataStream retraction.

Thanks for the PR @shaoxuan-wang. I haven't had a detailed look yet. I think we also need non-retract versions of MIN and MAX. The retracted version cannot be used to compute unbounded OVER windows and will be less efficient for batch queries (which do not need retraction).
Thanks, Fabian

Hi @shaoxuan-wang, yes. That's a very good point. We should definitely add non-retractable MIN and MAX aggregates. Would be good to have them now to use them in batch queries.

@fhueske  sounds great. I updated the PR. Please take a look. I have add non-retractable and retractable aggregates for MIN and MAX. And add a flag parameter via AggregateUtil.transformToAggregateFunctions() to indicate if an aggregate needs to support retract or not.

@fhueske  Thanks for the review. I have addressed all your comments and updated the PR

Thanks for the update @shaoxuan-wang.
PR is good to merge :-)


Navbar "mobile collapse button" not responsive

The mobile collapse button in http://materializecss.com/navbar.html is not behaving as expected. Whenever I resize my window or in mobile view the sidenav doesn't show up in my app. I used the example, and initialized the javascript. Works fine in the browser but the "hamburger" button doesn't work upon resizing the window. PLEASE HELP! REALLY LIKE THIS FRAMEWORK

Please provide a codepen illustrating your issue as indicated in the contributing file.

Never mind I fixed the  problem (had to include the script in my html page before the end of the  instead of having it sit there in the application.js file (I'm using Ruby on Rails)
thanks and my bad


Add support for compile request inside a database transaction

Description
Same PR as #5948 but applied on the iso6 branch, because the version numbers differ.
This PR extends the API of the compiler service with functionality to request a compile inside a database transaction.
Part of inmanta/inmanta-lsm#1249
Self Check:

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches iso6 in 5b7cd8d66eba42be9c0510910dc5f4e21034d524


Update request_handler.py

import datetime --> from datetime import datetime
correct path is datetime.datetime.utcfromtimestamp

import datetime changed to from datetime import datetime
correct path is datetime.datetime.utcfromtimestamp

Thanks for the fix!
Can you please look into that and make the necessary fix. Thank you.
On Thu, Nov 21, 2024 at 4:54 PM Dev Jones @.***> wrote:

Thanks for the fix!
You are receiving this because you authored the thread.Message ID:
@.***>

sadly i don't have time right now... but i will revisit this around january to make the updates.

I'm currently using it for a project so I already looked into it and solved
it. I already submitted a pull request. You can just review it and merge it.
Thank you.
On Thu, Nov 21, 2024 at 8:55 PM Dev Jones @.***> wrote:

sadly i don't have time right now... but i will revisit this around
january to make the updates.
—
Reply to this email directly, view it on GitHub
https://github.com/DavyJonesCodes/PyTweetToolkit/pull/1#issuecomment-2492140053,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUSY5I5RLH26GWKNW2LTIWT2BY3DNAVCNFSM6AAAAABSGLTP72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGE2DAMBVGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


💥 Update gh-pages branch to reflect latest changes in master

We've got quite a few changes in master for index.html that never actually made it across to the gh-pages branch, which is where http://scottjehl.github.io/picturefill/ pulls the content from. Let's get them updated, shall we?
(Related to #474)

@jegtnes
This PR makes your fix version-number PR obsolet, right?
In this case I simply just want to merge this. +1....
What do you think, to simply delete our master branch and make gh-pages master?

@aFarkas I don't think we should get rid of the master branch. We should instead probably find a grunt task to mirror master onto gh-pages. Thoughts?

I'm not very opinionated here. Just thought that we mostly will only move things to master as soon as we do an official release and when we do, we should also always update gh-pages.

+1 to automating things with a Grunt task.


”Sâncraiu de Mureș” is listed in the drop-down menu

Description:
"Sâncraiu de Mureș" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Sâncraiu de Mureș" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Sâncraiu de Mureș, MUREȘ".


faster sshd image creation

Main thing is to install nodejs and npm selectively. Only manual users use it. I will update the client to pass this -a option.
On my system, -a reduces image creation time from ~80s to ~50s.

:+1:


Is v5.0.2 actually out yet?

The changelog suggests it came out on 14 Nov 2016, but there is no v5.0.2 tag on the repo, nor is 5.0.2 available on rubygems.org?
Thanks for any clarification!

Thanks for the report, @atyndall. I'm not sure what happened here. However, I updated the changelog and pushed a new release as v5.1.0, since the changeset had some enhancements. It should be all good now!


Jaai branch components

Furnace Screen

I added a ticker example, we will need to set up components for the furnace data and we will need to set up property delegates and mirror the logic in abstract furnace block entity


Windows 11 cant make window transperant.

I'm trying to run the example from https://github.com/emoon/rust_minifb/blob/master/examples/transparent.rs on Windows but my window is just one solid color, not transparent.
Is it supported on windows?

Was able to get it working with the following code.
    let mut window = Window::new("Raqote", BS_WIDTH as usize, BS_HEIGHT as usize, WindowOptions {
        transparency: false,
        borderless: true,
        scale_mode: ScaleMode::Center,
        none: true,
        title: false,
        resize: false,
        scale: Scale::X1,
        topmost: true,
    }).unwrap();
    let font = SystemSource::new()
        .select_best_match(&[FamilyName::SansSerif], &Properties::new())
        .unwrap()
        .load()
        .unwrap();

    let size = window.get_size();

    let hwnd: HWND = window.get_window_handle() as isize;
    println!("{:?}", hwnd);
    unsafe { SetWindowLongA(hwnd, GWL_EXSTYLE, (WS_EX_LAYERED | WS_EX_TRANSPARENT) as i32) };
    let mut margs = MARGINS {
        cxLeftWidth: -1,
        cxRightWidth: -1,
        cyTopHeight: -1,
        cyBottomHeight: -1,
    };
    unsafe { DwmExtendFrameIntoClientArea(hwnd, &mut margs) };
    unsafe { UpdateWindow(hwnd) };
    unsafe { SetWindowPos(hwnd, HWND_TOPMOST, 0, 0, size.0 as i32, size.1 as i32, SWP_SHOWWINDOW) };

    let mut dt = DrawTarget::new(size.0 as i32, size.1 as i32);
    loop {
        dt.clear(SolidSource::from_unpremultiplied_argb(0, 0, 0, 0));

        let mut pb = PathBuilder::new();
        if let Some(pos) = window.get_mouse_pos(MouseMode::Clamp) {
            pb.rect(pos.0, pos.1, 100., 130.);
            let path = pb.finish();
            dt.fill(&path, &Source::Solid(SolidSource::from_unpremultiplied_argb(50, 0, 0xff, 0)), &DrawOptions::default());

            let pos_string = format!("{:?}", pos);
            dt.draw_text(&font, 36., &pos_string, Point::new(0., 100.),
                         &Source::Solid(SolidSource::from_unpremultiplied_argb(0xff, 255, 0, 0)),
                         &DrawOptions::default(),
            );
        }

        window.update_with_buffer(dt.get_data(), size.0, size.1).unwrap();
    }
    ```

There is an open issue for it here https://github.com/emoon/rust_minifb/issues/133 I haven't added any of this support myself and I have only accepted PR for it, so if you are willing to do that it would be great!

@emoon I'll try to make a PR for it. While I'm at it, do you have any objections to me replacing the winapi crate with the microsoft official windows-sys crate?

Both sound good to me! :+1:


Minor optimization

Computes inv_mask only when edge_weight is provided to add_remaining_self_loops().

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   99.85%   99.85%
=======================================
  Files         121      121
  Lines        3508     3508
=======================================
  Hits         3503     3503
  Misses          5        5

Impacted Files
Coverage Δ

torch_geometric/utils/loop.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac9194...1f58908. Read the comment docs.


backend: dynamically calculate the maximum auto-inc ID

What problem does this PR solve?
Fix #222 (= TOOL-1472).
What is changed and how it works?
Remove the piece of code that pre-calculates the final AUTO_INCREMENT ID. Instead, let the encoder determines the actual value dynamically. This gives a tighter upper bound of the final AUTO_INCREMENT value and avoids overflowing AUTO_INCREMENT columns of shorter integer size (this doesn't work if PRIMARY KEY is not a handle column though, since _tidb_rowid will share the same AUTO_INCREMENT sequence)
Check List
Tests

Integration test

Side effects
Related changes

/run-all-tests

/run-all-tests

PTAL @lance6716 @WangXiangUSTC

LGTM

/run-all-tests


iou calculation

thank you for your good code.
how to calculate iou ?
please guide me

Hi there!
IOU is intersection over union, so first question is how to calculate intersection?
Let's presume, that you have two boxes of coordinates [x1, y1, x2, y2] and [x'1, y'1, x'2, y'2].
Intersection is a field where two of those intersect themself. It means that intersection is a figure within both first and second rectangle.
Two of it's corners belong first rectangle and last two to the second rectangle. Now which one where? The ones that will make "smallest" intersection.
Let's call intersection parameters [ix1, iy1, ix2, iy2]
ix1 is equal to x1 if x1 is bigger than x'1. Otherwise it is equal to x'1. Why? Because intersection is a field inside two other fields, so both rectangles must exist in the same coordinates of Cartessian system.
iy1 is equal to max from [y1, y'1] because of the same logic.
Now what about ix2? Intersection "ends", when at least one figure "ended". So, it means that ix2 is THE SMALLEST among x2 and x'2. Same with iy2 which is the smallest among y2 and y'2.
So, now we have [ix1, iy1, ix2, iy2]. Calculating intersection field is easy now.
intersection = (ix2 - ix1) * (iy2 - iy1)
Now it is time to calculate union. Union is area created by both figures. If we would add rectangle 1 and rectangle 2 we would have union with intersection, because intersection overlaps. So you need to remove intersection to have union.
union = (x2 - x1) * (y2 - y1) + (x'2 - x'1) * (y'2 - y'1) - intersection
Now iou = intersection / union
Hope it helps!


[MX-435] Refactor follows and saves

The type of this PR is: Enhancement

This PR resolves https://artsyproduct.atlassian.net/browse/MX-435
Description
This refactors the saves and follows page to use our custom sticky tab page framework. In the process it was necessary to make the sticky tab bar scrollable, and to fix some minor layout issues in StickyTabPageFlatList that I hadn't accounted for yet.
✨ bonus ✨

Refresh the typography on all saves+follows pages
Add a loading placeholder for the artworks tabs (the other ones seem less likely to come up)
Delete unused code and unused test files

Screenshots
Scrollable tab bar

Artworks list placeholder

Typography Refresh

Artists list

Shows list

Categories List

Zero State

#skip_new_tests

Warnings

:warning:
Missing Test Files:

src/lib/Scenes/Favorites/__tests__/Favorites-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS


Archive description lists readers once per section, not once per project

Per discussion here: since we moved away from 'select DISTINCT', which was slowing things down, we now get duplicates of reader names on the Archive pages.
Someone reading a book solo would have their name repeated for each section, like so:
Read in English by ThisReader; ThisReader; ThisReader; ThisReader; ThisReader; ThisReader;
Looking at the database tables, I think we can 'select from project_readers', and get only one listing per reader.  I'll be testing that on my dev machine, as and when I work out how best to do that.  :laughing:
@twinkietoes-on - for solo projects, showing the reader name only once is obviously an improvement.
But for group projects, do we want to list all the readers on Archive?  It might make sense to name both readers for a duet, where a project with a dozen readers probably ought to say 'read by LibriVox Volunteers'.  Is there a particular number we should cut off at - 1, 2, ...5?  :thinking:

RR - that's probably a discussion for all the admins. In the old days, it used to just have "LibriVox volunteers" when it was a group project (I'm not sure how it was determined programmatically; if it was all group projects or a certain number of readers). But admins might want to list all readers once, or like you say, cut it off at a certain number. That's a forum question.

Sounds good. I'm trying to limit how much I ask at any given time, and I do still need to work out tests, so I'll let this one lie in the meantime.

Meanwhile: I see in the more detailed notes on previous commits, that the project_readers table itself is only a view... which happens to use SELECT DISTINCT!
Perhaps a GROUP BY in the reader list instead.  Sorry to waste your time on reading my musings, Artom.  I'll be back when both questions are answered.  :grin:

As discussed with MCs, solo projects should show the first database result as the reader name, and group projects (no matter how many readers) should elide as "LibriVox Volunteers".  That's exactly how the catalog pages work, and it's how we want things on Archive.
Soon-ish (I'm hoping for this evening), I'll send in a tested PR.  We can avoid any DISTINCT or GROUP BY calls, since we only need a single name.


feat: added continents report

We can keep the query as is for the 2nd option. I changed a little bit the logic

@nkoik Can you let me know if the code should be merged or not? I'm not sure of the state of this PR now


Add "No found games" message to configurator

On the find games screen of the configuration, there should be a "no found games", when the result is empty.
The user may think the program did nothing or is being extremely slow otherwise.

@brliron Will provide PR after https://github.com/thpatch/thcrap/pull/238 is closed.

@brliron See #238


How to set tab width ?

monaco-editor npm version: 0.7.0
Browser: Chrome 54.0.2840.99
OS: Windows 10
I want custom code tab width, use 2 spaces or 8 spaces.

Paging @alexandrudima.

model.updateOptions({ tabSize: 8 }). You can create a model yourself via monaco.editor.createModel(...) or use the one created by the editor on your behalf editor.getModel()

Thanks a lot!

@alexandrudima Is your solution deprecated now? Because for me it works when I call updateOptions on the editor itself, not on the model.

@chinchang seems that tabSize is a language consideration rather than the editor itself:
https://microsoft.github.io/monaco-editor/api/interfaces/monaco.languages.formattingoptions.html

@chinchang tabSize is a model property, so one must call updateOptions on the model instance in order to change tabSize.


Prepared query plans are never unprepared

In the netfx build BuildUnprepare() is present but never called. In core it has been removed. Once a query is prepared the query handle is discarded but is never used to unprepared. This will leave the query plan associated the connection until the real connection closes. This may not be a problem but it is a little surprising, i'd like to determine if this is intentional or whether it needs to be fixed.

That doesn't seem right to me, could you also verify if it's same behavior in System.Data.SqlClient drivers as well?

I checked there too, it's the same as M.D.SqlClient. There are no references to either of TdsEnums.RPC_PROCID_UNPREPARE or TdsEnums.SP_UNPREPARE (r explicit use of sp_unprepasre). I'd noticed no unprepare while working on the rpc PR and thought there must be some way of releasing it that I wasn't aware of so I went looking and can't find one. I think Unprepare() should probably do an rpc call where currently it is deferring for some other thing that doesn't happen.

This has been by design from the very beginning. Unprepare will need to be done via an API call.
Also Prepare() is an explicit call, and to unprepare, the connection can be returned to the pool and then new operations can be done on a new connection.
I had a conversation a couple years ago about this with one of the old time SqlClient leads who is now retired and this is the information that I have.
Yeah, there was a bunch of dead unused code in SqlClient as well which has been removed. I am not sure why, perhaps Unprepare was implemented but then it didn't make sense to include it as an API in favor of the pattern of putting the connection back in the pool and opening a new connection with no prepare context.

Is unpreparng something which should be implemented? Or is it best to leave it as-is? If left alone it might be worth documenting that it is effectively useless.

I would say leave as is. Not worth documenting in docs since the contracts don't expose it.
If you want to document code, then write a comment on the method.

Closing as by design.


[fix] overly restrictive route breakout regex

The regex for validating + files was overly restrictive and did not allow route layout breakout to [foo] or (foo) directories. No tests, yet.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

check seems to be failing with the same sort of error as in #6218. I don't know why this is. It's passing for me locally.

failure is probably related to https://github.com/sveltejs/kit/pull/6222


Make resources related to a published blueprint readonly

Purpose or Intent
Once a blueprint is published, all related resources should be readonly.
The implementation overrides ActiveRecord's readonly? method, relying it to throw errors when any attribute is attempted to be modified.
Resources that have been studied in this PR include

Blueprint
ServiceTemplate
Dialog
ResourceAction
ServiceResource

Resources to be further reviewed and addressed in followup PRs include

Tag
CustomButton
CustomButtonGroup

Links
https://www.pivotaltracker.com/story/show/129940811
Steps for Testing/QA

/cc @gmcculloug @chriskacerguis


Remove one usage of eval()

1 down, 8 to go.

I don't think it's worth the trouble at the moment, wizard code has more oddities, difficult to test too.


Requires.io Service Tests Failing

:clock11: When did the problem start?
At least 20 days ago and probably long before. I got tired of scrolling through Circle logs

:camera: Live badge

https://img.shields.io/requires/github/JettChenT/encryptii-server

:wrench: Is the live badge working?
Largely no for GitHub targets. The API is reporting a 404 for just about every project I've checked, with the one exception being
https://img.shields.io/requires/github/edx/edx-platform

Bitbucket based targets are working

:link: CircleCI link
Take your pick, https://app.circleci.com/pipelines/github/badges/daily-tests/1167/workflows/e4685a3e-7aa0-4964-b238-187ad1094171/jobs/2068/tests#failed-test-4

:beetle: Stack trace
ValidationError: message mismatch: "value" with value "not found" fails to match the required pattern: /^(up to date|outdated|insecure|unknown)$/
    at Object.exports.process (node_modules/joi/lib/errors.js:184:16)
    at Object.internals.entry (node_modules/joi/lib/validator.js:150:26)
    at Object.exports.entry (node_modules/joi/lib/validator.js:27:30)
    at internals.Base.validate (node_modules/joi/lib/base.js:548:26)
    at Object.internals.assert (node_modules/joi/lib/index.js:225:27)
    at Object.attempt (node_modules/joi/lib/index.js:107:26)
    at Function._expectField (file:///home/circleci/project/shields/core/service-test-runner/icedfrisby-shields.js:74:13)
    at IcedFrisbyNock.<anonymous> (file:///home/circleci/project/shields/core/service-test-runner/icedfrisby-shields.js:55:26)
    at IcedFrisbyNock.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:954:10)
    at invokeNextHook (node_modules/icedfrisby/lib/icedfrisby.js:1003:24)
    at /home/circleci/project/shields/node_modules/icedfrisby/lib/icedfrisby.js:1017:7
    at new Promise (<anonymous>)
    at IcedFrisbyNock._runHooks (node_modules/icedfrisby/lib/icedfrisby.js:976:12)
    at IcedFrisbyNock.run (node_modules/icedfrisby/lib/icedfrisby.js:1276:20)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Context.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:1348:9)

:bulb: Possible solution
Note that at least one of the tests will definitely need to be updated, as Zulip (the target currently used by the tests) changed their default branch from master to main. However, there's something else going on upstream with the API.
I've opened an issue upstream (https://github.com/requires/api/issues/5) and pinged the person that seems to have provided the API info to us back in 2014 (refs #206). However, Requires.io doesn't seem to be an actively developed, or even regularly maintained service at least at first glance. Hopefully this will get sorted but if not we may be forced to consider a partial decom.

Looking at the requires.io website, there's a support email address listed there. I've dropped them a short message about this problem. If we don't hear back, I suggest we go ahead and deprecate these badges.

Agreed :+1:

I've had a response. requires.io is basically in maintenance mode. They still provide native badges for their remaining users, and suggested we should go ahead and deprecate the Shields.io implementation. Will submit a pull request to that effect shortly.


Error in documentation (wrapLines instead of new multiline property for Tooltip component)

I am not sure if this is the place to report errors in the docs, if it's not i will take it into account in the future.
In the tooltip section of the documentation wrapLines is mentioned instead of multiline property:

Multiline
By default, tooltip white-space property is set to nowrap. To change that use:
`wrapLines` - to enable line breaks
`width` - to define tooltip width in px

Thanks for reporting this. I have updated the documentation. FYI, the repository for documentation can be found here: https://github.com/snehilvj/dmc-docs.


Add limit and offset to findAll methods in DB layer

Addresses #738
This PR consists of the following changes:

Create a findMore function in the Graphback Data Provider class that can be used to implement pagination
Implement above function in Knex, REST and MongoDB data providers
Write tests for forementioned functionality

Also it might need change in resolvers https://github.com/aerogear/graphback/blob/master/packages/graphback-codegen-resolvers/src/templates/resolverTemplates.ts#L23
After that we will be able to test it

I have modified the findAll resolver to use findMore when limit and offset args are specified in the query. Please check

I have added the GraphbackPage type to GraphbackDataProvider and have modified all implementations to use it such that if no page is specified, findAll will return all records. Please check.
Also I am facing some difficulties in writing tests for the MongoDB provider implementation. It seems that the database records persist between tests. I am confused if it was meant to be like that.

Also I am facing some difficulties in writing tests for the MongoDB provider implementation. It seems that the database records persist between tests. I am confused if it was meant to be like that.

Yes. I seen that as well so adjusted tests to workaround that but if we want to do things like limit it might be challenging. The best way might be to use the serial interface for tests or use after each to wipe out collection

let's see if we can improve unit tests and extend the schema to accept those 2 arguments. We will also need to modify docs "CRUD Spec" to cover new changes

I understand. I think we should write some tests first, to preserve some sanity :P
Could you point me at something I can get started with?

Edit: Is it the graphback-codegen-schema?
@ssd71 Yes

I ran the tests for graphback-codegen-schema and I got Warning - SchemaCRUD: Provided schema has no models. Returning original schema without any changes. and the resulting generated graphql schema didn't have any CRUD fields (it simply returned the input schema i.e. mock.graphql)
I checked mock.graphql and the Note and Comment types didn't have the """@model""" annotation. On adding these in and then generating the schema I got all the CRUD fields in resulting schema.

Good catch. We missed that. As for schema please see https://github.com/aerogear/graphback/blob/master/packages/graphback-codegen-schema/src/SchemaCRUDPlugin.ts#L257

When all done we should be able to start server and test things

I tried some things and I came up with this:
type Query {
      .
      .
      findAllNotes(limit: Int!, offset: Int!): [Note]!
      .
      .
      findAllComments(limit: Int!, offset: Int!): [Comment]!
      .
      .
}

Is this acceptable? I thought that making another 'Page' gql type would be overkill

@ssd71 Awesome! This actually more clever. Rease why I asked for top level type is that there is problem as those two values should be provided together - without that knex will fail on making query.
If we want to do it without wrapper then code should change to figure out defaults. If offset is passed we should pick some default limit like 10. If Limit is passed offset should be 0.
I think that we can drop ! as well!
Amazing work!

Would you like me to change the Data Provider implementations? I believe there should be a better way to do it, but I can't see default arguments anywhere on the gql layer

@ssd71 If we agree that this format is better then yes - we need to drop ! and supply defaults

I have done the following:

Add limit and offset args to findAllX queries in schema generator
Add default arguments for limit and offset in all Data Provider implementations
Write some tests for this (as best as I could, anyway :P)

While running the tests, I encountered a problem: CRUDService.tsin graphback-runtime calls findAll like so:
return this.db.findAll(context);

Which conflicts with the current spec of findAll:
findAll(page?: GraphbackPage, context?: GraphbackContext): Promise<Type[]>;

This resulted in the findAll test of DefaultCRUDServiceTest.ts in graphback-runtime-knex to fail as in that file, findAll is being passed a string. This doesn't fit well with checking the fields of the page argument to fill in default values for missing fields. In the meantime, I have implemented some roundabout way to pass that test by interpreting strings as empty argument and returning all objects:
In KnexDBDataProvider.ts
if(page && (page.limit || page.offset)){
      if (!page.limit) {
        page.limit = 10;
      }
      if (!page.offset) {
        page.offset = 0;
      }
    	query = query.limit(page.limit).offset(page.offset)
    }

I also noticed that there are no CRUD Service Tests for Mongo services.

@ssd71 This is by far the best community contribution that we recieved in Graphback so far. Thank you so much for not only resolving such challenging issues but also managing to do this end to end.
I will take it from there and play with the implementation and try to see if there are some issues or corner cases and get that merged.
I will also merge that without squashing commits so you are getting all 27 commits as contributions to graphback! Thank you so much again - this is world class job and manifest of your skills!

Thank you so much! It was an absolute pleasure contributing, thank you @wtrocki  and @ankitjena and everyone else for making this such a wonderful community! :)

@ssd71 Closing the PR as I see a couple of bugs that I need to fix.

Merged


I wish OpenAPI mentioned in docs instead of swagger 1.2

In http://kubernetes.io/docs/api/ we mentioned swagger 1.2 however as of 1.5 we will support OpenAPI (swagger 2.0) spec. We should update docs to reflect that.

I believe this is pending with the 1.5 changes that are coming out.

Excellent, is there any staging area with that change I can look at?

I don't see any doc changes for OpenAPI. Please link to the change if I am wrong, otherwise we should at lets mention OpenAPI in the docs and later on (1.6 maybe) remove swagger 1.2 references completely.


Clean up HttpRemoteTask error tracking

The HttpRemoteTask mixes error tracking for updates and gets.  Since the gets virtually never fail, the gets cancel out failures from updates.  This PR splits the two into separate error trackers, so they can fail independently.

Looks good


Does not work for Sensei

So something must be missing in your configuration or somewhere else.  First off, Sensei "free" using an external ELK stack  creates indices with the pattern /[dns,alert,conn,http,sip,tls].*/    (e.g. dns-210409, alert-210409, etc.)
You mention creating a datasource for ELK in Grafana with an index name of '*'.  This isn't great if you have more than just Sensei indices in ELK.

My mistake - I missed setting the start_time for the datasource.


Check failed: input_shape.dim_size() <= 4 (5 vs. 4)

####System information
Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): -
TensorFlow installed from (source or binary): -
TensorFlow version (use command below): 1.8.0 rc1
Python version: -
Bazel version (if compiling from source):-
GCC/Compiler version (if compiling from source): -
CUDA/cuDNN version: -
GPU model and memory: -
Exact command to reproduce: -
####Describe the problem
bazel-bin/tensorflow/tools/graph_transforms/summarize_graph --in_graph=one_graphRes.pb
Found 1 possible inputs: (name=input_1, type=float(1), shape=[1,300,480,3])
No variables spotted.
Found 1 possible outputs: (name=predictions/concat, op=ConcatV2)
Found 335304 (335.30k) const parameters, 0 (0) variable parameters, and 7 control_edges
Op types used: 192 Const, 73 Identity, 49 Switch, 21 Mul, 16 StridedSlice, 16 Pack, 15 BiasAdd, 15 Conv2D, 14 Add, 12 Reshape, 9 Sub, 7 Merge, 7 Elu, 7 FusedBatchNorm, 7 Rsqrt, 6 MaxPool, 4 Tile, 4 ConcatV2, 4 Shape, 2 RealDiv, 1 PlaceholderWithDefault, 1 Placeholder, 1 Sum, 1 Max, 1 Exp
To use with tensorflow/tools/benchmark:benchmark_model try these arguments:
bazel run tensorflow/tools/benchmark:benchmark_model -- --graph=one_graphRes.pb --show_flops --input_layer=input_1 --input_layer_type=float --input_layer_shape=1,300,480,3 --output_layer=predictions/concat
bazel-bin/tensorflow/contrib/lite/toco/toco --input_file=one_graphRes.pb --output_file=one_graphRes.tflite --inference_type=FLOAT --input_shape=1,300,480,3 --input_array=input_1 --output_array=predictions/concat
Check failed: input_shape.dim_size() <= 4 (5 vs. 4)

Nagging Assignee @tatianashp: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I also encountered this issue, but i use the python api tf.contrib.lite.toco_convert() to convert, any solution yet? Is it like it will work only with placeholder ?

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Looks like this issue has been open for a while, @iChiaGuo , @PariksheetPinjari909 please reopen if you are still having issues.


Is it safe to ignore .next?

Looks like the dist and bundle caching directory. Is it ok to ignore it on the .gitignore?

Yes

Yes, it should only need to be created when building and running a build step in production and you'd not normally want to commit it to your git repo.

Perfect, many thanks!


hub-agent-dev-portal pod in status  CrashLoopBackOff with error msg "listen tcp :80: bind: permission denied" / "Unable to listen and serve dev portal requests"

Kubernetes Setup

Debian Bullseye 11.6
k0s v1.25.7
containerd

Issue
By default ports <1000 can not be exposed by containers running as non-root users on containerd.
I experience the same permission issues with hub-agent-dev-portal that are described for the traefik Chart in this issue.
kubectl -n traefik get pods

NAME                                     READY   STATUS             RESTARTS         AGE
hub-agent-auth-server-5bd76d8c79-zbkcl   1/1     Running            0                39m
hub-agent-controller-6448fdb84b-bcm7s    1/1     Running            3 (9m30s ago)    39m
hub-agent-dev-portal-6f4c896c89-tbmt6    0/1     CrashLoopBackOff   12 (2m41s ago)   39m
hub-agent-tunnel-7b684d666b-qp8hr        1/1     Running            0                39m
traefik-6f6596fb44-pn6qd                 1/1     Running            0                47m

If I inspect the logs ...
kubectl -n traefik logs svc/hub-agent-dev-portal

Output:
{
  "level":"error",
  "error":"listen tcp :80: bind: permission denied",
  "time":1679946580,
  "caller":"github.com/traefik/hub-agent-kubernetes/cmd/agent/dev_portal.go:149",
  "message":"Unable to listen and serve dev portal requests"
}
{
  "level":"fatal",
  "error":"dev portal stopped",
  "time":1679946580,
  "caller":"github.com/traefik/hub-agent-kubernetes/cmd/agent/main.go:41",
  "message":"Error while executing command"
}

There's currently no way to override the securityContext in the Helm chart's values.yaml.
If I override the securityContext in deployment-dev-portal.yaml as follows:
# [..]
          securityContext:
            capabilities:
              drop:
                - ALL
              add:
                - NET_BIND_SERVICE
            allowPrivilegeEscalation: true
            readOnlyRootFilesystem: true
            runAsNonRoot: false
            runAsUser: 0
            runAsGroup: 0
            seccompProfile:
              type: RuntimeDefault

... the chart can be deployed successfully.
NAME                                     READY   STATUS    RESTARTS        AGE
hub-agent-auth-server-5bd76d8c79-zbkcl   1/1     Running   0               63m
hub-agent-controller-6448fdb84b-bcm7s    1/1     Running   6 (3m40s ago)   63m
hub-agent-dev-portal-5776ddfdf9-z29hk    1/1     Running   0               32s
hub-agent-tunnel-7b684d666b-qp8hr        1/1     Running   0               63m
traefik-6f6596fb44-pn6qd                 1/1     Running   0               71m

A possible solution is to provide an option to overide the securityContext with .Values.devPortalDeployment.securityContext.
This is possible with the traefik Helm Chart here.

@nifr I am sorry for the inconvenience, we kinda missed that in the review.
However, the problem is fixed :-)


More ownable improvements

Lets add a cw_ownable_query macro which adds a #[returns(Ownership<Addr>)] Ownership {} variant to an enum for queries.
Taking advantage of the fact that those macros standardize the interface we can then write a macro which generates a standard set of tests for any contract that uses the library.

initialize_owner should also take an Option<&str> instead of owner: &str to reflect the fact that owners are optional.

Lets add a cw_ownable_query macro

This has been implemented in #8. However, I choose Ownership<String> instead of Ownership<Addr> as the response type based on the idea that contract APIs (i.e. messages and query responses) should only contain unverified types. Addr represents a verified address.


expand-errors with spec function & type arguments

If you run with --expand-errors, this code gives an invalid AIR:
#![allow(unused_imports)]
use builtin::*;
use builtin_macros::*;
use state_machines_macros::*;
mod pervasive;
use pervasive::set::*;

verus!{

spec fn all_contains<A>(s1: Set<A>) -> bool {
    forall |a: A| s1.contains(a)
}

proof fn failing_proof(s: Set<int>)
{
    assert(all_contains(s));
}

}

fn main() { }

note: verifying root module

error: assertion failed
  --> bug4.rs:18:12
   |
18 |     assert(all_contains(s));
   |            ^^^^^^^^^^^^^^^ assertion failed

thread 'rustc' panicked at 'internal error: generated ill-typed AIR code: error 'in call to pervasive.set.Set.contains.?, argument #3 has type "Int" when it should have type "Poly"' in expression '(pervasive.set.Set.contains.? INT (Poly%pervasive.set.Set<int.>. s~2@) a~8$)'', rust_verify/src/verifier.rs:368:21

Just to add a bit of information:
This bug happens when we inline all_contains at the failing assertion.
While the signature of contains is (Type Poly Poly) -> Bool) , the inlined expression of all_contains is  forall |a: int| contains(Int, box(s), a) .  It seems like we need to box the last argument a.
When substituting a generic type with a concrete type (substituting T with int in this case), it seems like we need tobox the substituting expressions in some cases.
But I am not sure when we should box and shouldn't box the substituting expression in general cases of function inlining.

@Chris-Hawblitzel can you take a look this one if you get a chance? looks like it has something to do with boxing so I think the rest of us aren't sure how to approach it

Think I ran into the same thing on #561 . Not having it panic and instead being able to see which part of the assertion failed would be helpful for debugging a proof faster

It should be fixed by https://github.com/verus-lang/verus/commit/4454b0cdc9b86f84021cc4a72fa6a1a0ed603443 .


[Feature]: How to use SSL websocket with remote debugging on Puppeteer?

Feature description
Hope doing well. I am going to use SSL web socket for remote debugging on Puppeteer. But in regular, we are using ws://<IP_ADDRESS>:9222 for the remote debugging.
I will appreciate if you could please help me. Thank you.
ws://localhost:9222/devtools/browser/b0b8a4fb-bb17-4359-9533-a8d9f3908bd8 to wss://localhost:9222/devtools/browser/b0b8a4fb-bb17-4359-9533-a8d9f3908bd8

I am not sure if the browsers support SSL sockets. The recommended way for better security is to use pipes (see the pipe option in https://pptr.dev/api/puppeteer.launchoptions/#properties).

If puppeteer is used on remote computer using puppeteer.connect function then it would be dangerous because of the not secured communication.
Do you have a alternative method to avoid this issule?

@honestydeveloper the secure solution is not expose the browser’s debugging server directly, instead it’s better to start the browser with the debugging pipe and have a custom secure web socket server forward commands. Or automate over a secure network.

if I use pipe option then it could never pass the some security companies.
Thus, I have to use remote debugging as the websocket.
I am not familiar with the automate over a secure network so could you please more explain how to explain it more detail ?

I am not sure either as it depends on your use case, but that goes beyond the scope of Puppeteer.


Custom allocator support

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: Jasper-Bekkers:x: rAzoR8:x: UX3D-schmithuesen:x: UX3D-wahlsterYou have signed the CLA already but the status is still pending? Let us recheck it.


Optimized UI for the game

I have optimized the user interface kindly merge it to main branch.

@Aryansan1999 please star the repository.


Can't refresh access token

I don't see any documentation on how to refresh the access token. The token response gives a refresh token that states it expires in 24 hours, but trying to follow a normal oAuth flow for refreshing the token does not work.

I have the same question. How does one go about refreshing the token?

Can confirm. Not supported yet.

If you are needing to setup an integration to call the APIs programmatically I suggest using the JWT authentication workflow. I just added documentation for how this works here: https://github.com/AdobeDocs/analytics-2.0-apis/blob/master/jwt.md

@mike2184 thanks for the update.
I just want to confirm the JWT workflow as a third party. I work for a company which is integrating with Adobe Analytics for a client of ours who uses Adobe Analytics. Just wanna know exactly what I should instruct them to do before I ask them.
Does this look right?:

My company (the third party) creates a private/public certificate key pair.
I send the client the certificate_pub.crt file that I created.
Our client goes to https://console.adobe.io/integrations, clicks new integration, selects analytics api, and chooses 'Service Account integration.'
Uses my certificate_pub.crt file to complete the integration.
The client would send us all the api tokens (client id, client secret, tech account id, etc)
Using the values from step 5 plus the private key I generated in step 1, I'm able to generate a JWT token.
With client id, secret, and JWT token, I'm able to generate access token.
With access token, I'm able to access info from the analytics API.

Thanks!

@samlehman - That is correct.
Side note: We are working on adding more documentation and examples to the adobe.io authentication docs that will be available soon and should help make the instructions more clear.
https://www.adobe.io/authentication/auth-methods.html#!adobeio/adobeio-documentation/master/auth/JWTAuthenticationQuickStart.md

@mike2184 thanks!

@mike2184 I must be missing a step somewhere. If the JWT expires after 24 hours, how do I programmatically regenerate a new JWT token if the only way to generate a JWT is through the console UI.

@kirstilynn - That is the part that is missing in our documentation. There are many open source tools for programmatically regenerating a new JWT token. For now I can give you this link to our stage documentation that is still being reviewed. It should help you with this step: https://stage.adobe.io/authentication/auth-methods.html#!AdobeDocs/adobeio-auth/stage/JWT/JWT.md

I don't have access to your staging environment but I can just be patient for now and wait for the documentation to be finished 😊 Thanks @mike2184!

@kirstilynn - This might help: https://jwt.io/

Here is some sample code for generating JWT tokens in Java and Node.js
https://github.com/AdobeDocs/adobeio-auth/blob/stage/JWT/samples/samples.md
These are currently on the stage branch of this repo but you should be able to see them.

This conversation branched from OAuth access tokens to JWT. Will refreshing access tokens be a supported part of the OAuth workflow? If not, it feels like the refresh token part of the OAuth docs should be removed

The analytics APIs currently don't support refreshing access tokens. There are other Adobe APIs where you can refresh your access tokens which is why there are some docs about using them. I don't believe that we have any docs in this repo for doing a token refresh, but we may need to note that the refresh isn't supported at this point. We are looking at what it would take to support that flow so it may be something that we have available in the future, but it is only in the exploratory state right now.

Thanks @nateprice7, it looks like I might have just been using a cached version of the docs, I see the updated docs saying "Note: Not all product APIs support refresh_token grant type."


[Bug] Component type "Special" not selectable in version 2.5.3

Describe the bug
In the newest rev of the software, version 2.5.3, the Component type "Special" (which typically contains options for #boardcomponents and #monsters) is not selectable (it is red). Verified on older version on different computer that this is not an issue, seems to be unique to the newest release.
Note: I am able to work around the issue by manually editing the Events text file with Remove: #boardcomponents.

Scenario
Occurs in Editor

Steps to reproduce the behavior:

Go to Scenario Editor
Create new event
Select + to remove component
See at top left, "Special" type component is red and not selectable.

Expected behavior
Special type components should be selectable in editor.

LogFile
Sorry, I can't find any of the log files.

Screenshots

Valkyrie Version

Desktop

OS: [e.g. iOS] Windows 7 64 bit
Browser [e.g. chrome, safari] Downloaded on Chrome, use as app on computer
Version [e.g. 22]

Smartphone

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

I use Valkyrie in Portuguese. I'm building (making? writing?) a scenario where the default language is Portuguese.
I changed Valkyrie's language to English and this problem happened.
I changed the Valkyrie language back to Portuguese and these components were available again.

See comment in #1498


No persistant storage in Docker setup?

Is there a persistant folder to map to the host? Every time the docker updates I loose everything and get the welcome screen again. Have to make a new token ect.

Yes, please refer to https://github.com/qJake/HADotNet.CommandCenter/issues/26
I will be adding documentation for this soon.


Core data observable fix

This should fix issue #249 , not sure what else we need to do in dispose(), if anything.

Good catch @grangej . Fix these small details I mentioned and we can merge this

Closed in favour of https://github.com/pepibumur/SugarRecord/pull/251
I added you as a collaborator @grangej


Documentation contributor - Error: Cannot find module 'C:\Users\tonyh\Documents\vscode\jest\website/backers.json'

🐛 Bug Report
docusaurus-start error
To Reproduce
Follow the guidelines

$ cd website       # Only needed if you are not already in the website directory
$ yarn
$ yarn start

Error: Cannot find module 'C:\Users\tonyh\Documents\vscode\jest\website/backers.json'
Expected behavior
Documentation server starts
Reason for the error
backers.json is required in jest\website\pages\en\index.js
backers.json is not in the repo ( gitignore ), it is generated by fetchSupporters.js
https://github.com/facebook/jest/blob/99c6fb1e5d5db037ab42ea12ddc6cb9ed16e3785/website/fetchSupporters.js#L44
This is not a problem for circleci.
But it is an issue when following the contributing guidelines as yarn start does not ensure the file has been generated
https://github.com/facebook/jest/blob/99c6fb1e5d5db037ab42ea12ddc6cb9ed16e3785/website/package.json#L6
envinfo
System:
OS: Windows 10 10.0.18363
CPU: (4) x64 Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz
Binaries:
Node: 12.13.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Users\tonyh\AppData\Roaming\npm\npm.CMD

Before yarn start you need run node fetchSupporters.js.

Fixed by https://github.com/facebook/jest/pull/10631


Testimonial Carousel on main page

@christianaschoff isn't this done already?

Yeah, I guess it was transferred by mistake from the old board


Update natchez-core, natchez-honeycomb to 0.3.6

About this PR
📦 Updates

org.tpolecat:natchez-core
org.tpolecat:natchez-honeycomb

from 0.3.5 to 0.3.6
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.tpolecat" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.tpolecat" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #380.


Replace if-return with Assume API from Junit in DecimalParquetInputTest

Fixes #12926.
Description
This PR improves the test cases in DecimalParquetInputTest by replacing the if-return blocks that check for unsupported parser types with assumeFalse-- Assume API from Junit.
Replaced if-return blocks with assumeFalse
The existing test cases used if-return blocks like this to skip tests for unsupported parser types:
// parquet-avro does not correctly convert decimal types
if (parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE)) {
  return;
}

This made the test logic implicit. It's preferable to make unsupported preconditions explicit using JUnit's assume methods. The assume function, introduced after JUnit 4, is designed to check for test pre-condition. As mentioned in the document:

Assume functions is a set of methods useful for stating assumptions about the conditions in which a test is meaningful. A failed assumption does not mean the code is broken, but that the test provides no useful information.

I replaced the if-return blocks with equivalent assumeFalse assertions:
// parquet-avro does not correctly convert decimal types
assumeFalse(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE));

A failed assumption will cause the test to be skipped, while still allowing the test to run for supported parser types. This makes the preconditions clearer without changing the test behavior.
This refactoring resolves the silent quit issue by using the Assume API to provide explicit output when tests are skipped.
I applied this change to all three test cases in DecimalParquetInputTest:

testReadParquetDecimalFixedLen
testReadParquetDecimali32
testReadParquetDecimali64

This is a straightforward refactoring that improves test readability without altering functionality. No other code changes were made.

This PR has:

[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Thanks a lot for your first contribution to Druid, @Codegass !


Create presentation?

In all your examples you're showing how to add something to an existing presentation. Is there a way one could do a presentation from scratch? Could you show me how?

No, creating a presentation from scratch https://github.com/ShapeCrawler/ShapeCrawler/issues/53 is not available yet.

Thank you.


Reproducibility across releases

Hi @jwindhager
again, this is more to track this issue rather than a real "issue". I have now run steinbock twice each using v0.13.5 and v0.14.1. Using the same version I can recover exactly the same cells (at least the number of cells match) but I do get different numbers of cells when comparing between the different release. Do you know why this is and if that can be fixed somehow?
I'm using deepcell segmentation.

Hi @nilseling! Indeed, with steinbock v0.14.0, deepcell was upgraded from version 0.11.0 to 0.12.0 (see here), which included an update of the trained models (see here). I'm afraid there is no way to recover the same number of cells across versions, but you can always use multiple versions for the individual steps.


Styles are not imported

I did
import { Rating } from '@smastrom/react-rating';

   <Rating
        value={4}
        items={6}
        style={{ maxWidth: 100 }}
        // className='flex w-[200px]'
      />

but when looking at devtools, the styles are not imported. Here is the output:

What am I doing wrong?

import<EMAIL_ADDRESS>and will work


Filter out beans from CDI from build time discovery

Fixes #499

ok to test

ok to test

ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/460/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/462/


Figma v11 Slack announcement

We need to announce that the Figma v11 library is leaving beta with a complete component and pattern set.
Tasks

[ ] Create a Slack block for the announcement with relevant links.
[ ] Identify channels to announce to.
[ ] Push the announcement!


Repository definition change log addon

Closed https://github.com/Commonjava/indy/pull/1166 and use this new organized one instead.

Still a huge pr (30+ file changes). I need to say sorry about this. I think the most important part is java code in addon/changelog/ module. You can just focus on that when you start to review.

No worry. Big pr happens quite often.

Looks good to me, just one question, will we place the REST resource inside of Indy or outside of it(like AuditQuery)?

Looks good to me, just one question, will we place the REST resource inside of Indy or outside of it(like AuditQuery)?

Actually this rest endpoint is just a test endpoint for functional test. The final querying functions should be hosted in auditquery. I think I should limit this rest endpoint with some warnings and results limitation.

Actually this rest endpoint is just a test endpoint for functional test. The final querying functions should be hosted in auditquery. I think I should limit this rest endpoint with some warnings and results limitation.

That makes sense. 👍


Enable using single number in response body

Based on discussion here, I think it might be useful to allow mocked API to return a single number as response. So I created the following pull request. Please help take a look if this is appropriate. Thank you for the awesome project!!

Hi, is it possible to merge this PR?


kick Single-cell Transcriptome Atlas of Testis Aging from complete -> exported

project: Single-cell Transcriptome Atlas of Testis Aging
uuid: e88714c2-2e78-49da-8146-5a60b50628b4
need to update project level cell count

Hi @rachadele - This submission got a load of other errors while exporting, while we investigate what is happening I am not able to kick it back to exported/Metadata valid
Apologies about this!

it looks like it's complete now! would you be able to kick it back?

thanks enrique :- )


See hours in week view

Hi,
I m using your calendar in my application. Currently we can see in a day in week view only events for this day, not all the free hours for this day.
Can you implements this to permit to see hours of all day in week view for to have an agenda like "google agenda"?
Thanks

You can do this already by setting this option like so, with the caveat that event end times are ignored.
calendarConfig.showTimesOnWeekView = true;

Thanks this help me.


Not working on Video.js 5.10.4

Uncaught TypeError: Cannot read property 'extend' of undefined
VIDEOJS: ERROR: The "Wistia" tech is undefined. Skipped browser support check for that tech.
VIDEOJS: ERROR: (CODE:4 MEDIA_ERR_SRC_NOT_SUPPORTED) No compatible source was found for this media. i {code: 4, message: "No compatible source was found for this media."}code: 4message: "No compatible source was found for this media."proto: Objecte @ log.js:77h.error @ log.js:29b.error @ player.js:2244(anonymous function) @ player.js:1966e @ fn.js:35
Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause().

I've just updated the tech to support Video.js 5. You can find an example here using 5.10.7: http://ryanpatrickcook.github.io/videojs-wistia/
Closed via https://github.com/ryanpatrickcook/videojs-wistia/pull/2


#23 Put processReplacing handling onto a different thread.

Further fix for #23.
Ardour, when handling audioMasterAutomate, calls back into the plugin
using getParameter. It's unclear whether that's VST-legal or not, but at
the moment it seems to deadlock when processReplacing is going on at the
same time.
This commit moves processReplacing onto a thread+queue for itself,
releaving the deadlock.

Thanks for your efforts I will test your changes soon. I'm thinking to make suggested solution optional (configurable through settings). It would be nice not to pay for an additional thread on other hosts only because of the Ardour behaviour.

Yeah it's a bit weird they do that. I tried to get some answers [here] (https://github.com/Ardour/ardour/commit/f806f059b3c229004cfbac50234062333fc38229#diff-bd50c417ef75429417b0415fa2f738d4R372).
Rather than making it configurable, isn't there a way to just detect we're running in ardour?

We could ask the host via audio master request (audioMasterGetVendorString / audioMasterGetProductString).

For some strange reason, I can't get a product string from Ardour at the early stage (when the first argument to audio master proc is null). But according to the Ardour source code, I can't find why this happens - they just do a strcpy. Will be digging into this issue closely.

Great, let me know if you find a reliable way to detect Ardour. This patch allows both Massive and Kontakt 5 to run reliably now. However, they crash internally (null pointer) when tearing down their windows after ardour sends effEditClose. I can get around that by ignoring effEditClose; with that I can load/save.
However, Reaktor 5 doesn't seem to work at all. It wants to resize its VST window, is that something you've tried?

I had Reaktor 5 window resizing working with my wine patch earlier. Right now I don't have it installed. As far as I know there are some working versions of all NI plugins. The newest ones have the issues, of course.

ah, I'll try the patched wine again. I remember I did a clean wine-staging earlier to test sth else.
Brrr, really not looking forward to going through NI's old versions to see what works. Anyways, I'll give it a shot if I have to.  I'm wondering whether I'm the first one to ask them why Massive is their only instrument that seems to reliably not work in 64-bit WINE :-)

No, I haven't. Usually, when I'm asking some company for Linux support, they said that this is not planned, so I just gave up. And NI Massive 1.4.0 (32 bit) is 100% working with WINE, Bitwig Studio and airwave.

TBH, you don't ever need 64-bit plugins (with an exception of NI Kontakt and Omnisphere, which use a lot of samples).

Ok, your changes seem good for me. I tuned them a little and added a check for the Bitwig Studio. Now, if airwave detects that it runs under the Bitwig, it won't use an additional thread. Possibly I should use the opposite logic and check for Ardour. As far as I discovered, Ardour fills its id-string correctly only when it adds a plugin to a session and it doesn't fill the id-string when it just scans the plugin. This wouldn't be an issue for us and there is a chance that I will inverse this logic in the future.
The changes are in the jypma-ardour_fix branch.

Thanks a lot for pulling it in!
I actually thought of an alternative, simpler solution, which would be to hold on to the current parameter value during passing audioMasterAutomate into Ardour, and then have Ardour's callback to getParameter just return the value the thread already has (rather than going through the bridge to reach the plugin at all).
 Not sure when I get some time to try it, but I will. That'd get rid of the extra thread in Ardour.

I think this is a nice idea. Will try to rework the latest commits in a few days, will see what I get.

@jypma I've implemented your idea and pushed my change in the develop branch. It's a simpler that implementation in jypma-ardour_fix branch, thus I consider it a better solution. Could you please check if it works for you? I didn't find any issues on my side, but I did only basic tests.

@phantom-code I tested your changes and they work for me. I have a few suggestions to potentially make the code a bit safer. I added them as comments to your commit.

Closing in preference of just remembering the last-seen value, current top of develop branch.

There is a nasty thing with the current implementation in develop branch. Ardour calls getParameter from different threads: the main thread (audioMaster callback) and other audio thread(s). So our hack with a flag variable should be guarded by the mutex. I've added the locking and now I get deadlock again (when changing a parameter in plugin's UI).

Isn't only the audioMaster callback the one we need to short-circuit? i.e. store the current thread invoking the audioMaster callback as a flag, short-circuit any call to getParameter on the same thread, and let any other threads just lock on the existing mutex to the data channel. Might that work?

I've just done something like that and it seems to be working at the first sight.


Add UI indicator if GitHub-managed permission is greater than permissive's for a repo

The approach I've taken is to simply disable the buttons below GitHub's permission level, rather than alternate styling or other indicators..


feat: run codesign on macOS

codesign is a utility used on macOS to sign binaries and add a way for the system verify their integrity after download. This PR adds an option to run the utility on binaries before uploading them to the GitHub Release. The CI has also been updated to run codesign on macOS, using an ad-hoc developer identity (codesign --sign "-").
Closes #60

Published in 1.18.0.


Initial Cardano.Wallet.Prelude and local package re-org

Description
Basically we want to solve these problems:

Massive numbers of imports in every single source file which makes editing and refactoring especially quite laborious.

Tangled dependencies between cardano-wallet-core and cardano-wallet-shelley packages which cause tangled code.

Testing code mixed up with the application code.

Misleading module and package names where cardano-wallet-specific code has overly general names.

This PR
This is the first cut of Cardano.Wallet.Prelude.

Adds Cardano.Wallet.Prelude to the cardano-wallet-core package.

Adds a cardano-wallet-base package containing shared util code.

Decouples launcher, core, text-class, and test-utils packages from each other.

cardano-wallet-test-utils is now a standalone package, not depending on other wallet packages such as text-class.
Removes cardano-wallet-launcher dependency on cardano-wallet-text-class.

Sets all cabal files to spec version 3.0 (3.4 is not supported by stack).

Adds some Cabal sub-libs for testing code. QuickCheck generators are no longer in the application library and instead have their own separate sub-lib.

Adds common stanzas to the cabal files to reduce duplication.

Resolves a great number of unused-packages and redundant-constraints warnings.

Renames and moves a few modules. For example, the miniprotocols client code is now under Cardano.Wallet.Network.

Renames wallet-specific packages to cardano-wallet-*.

Next PRs:

Disentangle the cardano-wallet and cardano-wallet-core packages.
Get rid of cardano-wallet-core-integration.

Comments
Tips for reviewing: This diff is huge but it's pretty much all deletions, or renaming, or fiddling whitespace (sorry). Concentrate on
what's exported from Cardano.Wallet.Prelude, and what's changed in the Cabal files. The rest is pretty boring. With Cabal common stanzas, some modules got warnings enabled that they previously didn't have, so there are also some tweaks to resolve these warnings.
The contents of the Cardano.Wallet.Prelude will probably need adjustment. Unless it's really wrong, I would propose refining it in future PRs, because this PR is horrible to rebase.
Package dependencies before

Package dependencies after

Issue
ADP-1010, ADP-1322

Looks like we will need PR #3115 merged before this. Stack doesn't seem to be working - even for the private internal libraries case.

This pull request tried to do too many things at once and grew stale too fast. I have saved the module dependency graphs. Closing.


Bootstrap 5 Renderer

This builds on #84
Reverted all the flag bits, found the correct way todo this. Just adding the bootstrap5 class, and passing that to the template renderer does exactly what is needed.
Moved, the example into different directories, this keeps the simple example unchanged, but adds a Bootstrap5 example version.

My day just ended, I will look at this first thing tomorrow.

I appreciate your time.

Published v0.7.2  at https://test.pypi.org/project/flask-nav3/  please verify all is well.

Confirmed with my application I'm working on. Thanks!